[Bug]: pydantic.v1.error_wrappers.ValidationError: 2 validation errors for LLMChain. Langchain Agents

Bug Description
I created a agent_executor with langchain like this:
allTools = [
    QueryEngineTool.from_defaults(
        chat_index_engine,
        name="chat_index",
        description="For answering general questions. Use a detailed plain text question as input to the tool.",
        return_direct=True
    ),
    FunctionTool.from_defaults(fn=delete_signup, return_direct=True),
]

langchain_tools = [t.to_langchain_tool() for t in allTools]

from langchain.agents import initialize_agent

agent_executor = initialize_agent(
    langchain_tools,
    llm,
    agent="structured-chat-zero-shot-react-description",
    verbose=True,
)

But then got this error:
/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/langchain_core/_api/deprecation.py:117: LangChainDeprecationWarning: The function `initialize_agent` was deprecated in LangChain 0.1.0 and will be removed in 0.2.0. Use Use new agent constructor methods like create_react_agent, create_json_agent, create_structured_chat_agent, etc. instead.
  warn_deprecated(
Process SpawnProcess-2:
Traceback (most recent call last):
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/uvicorn/_subprocess.py", line 78, in subprocess_started
    target(sockets=sockets)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/uvicorn/server.py", line 65, in run
    return asyncio.run(self.serve(sockets=sockets))
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/uvicorn/server.py", line 69, in serve
    await self._serve(sockets)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/uvicorn/server.py", line 76, in _serve
    config.load()
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/uvicorn/config.py", line 433, in load
    self.loaded_app = import_from_string(self.app)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/uvicorn/importer.py", line 19, in import_from_string
    module = importlib.import_module(module_str)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/sw/toolcall.py", line 373, in <module>
    agent_executor = initialize_agent(
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/langchain_core/_api/deprecation.py", line 145, in warning_emitting_wrapper
    return wrapped(*args, **kwargs)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/langchain/agents/initialize.py", line 67, in initialize_agent
    agent_obj = agent_cls.from_llm_and_tools(
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/langchain/agents/structured_chat/base.py", line 134, in from_llm_and_tools
    llm_chain = LLMChain(
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/langchain_core/load/serializable.py", line 120, in __init__
    super().__init__(**kwargs)
  File "/home/sw/anaconda3/envs/llama/lib/python3.10/site-packages/pydantic/v1/main.py", line 341, in __init__
    raise validation_error
pydantic.v1.error_wrappers.ValidationError: 2 validation errors for LLMChain
llm
  instance of Runnable expected (type=type_error.arbitrary_type; expected_arbitrary_type=Runnable)
llm
  instance of Runnable expected (type=type_error.arbitrary_type; expected_arbitrary_type=Runnable)

Using just ReActAgent.from_tools() does work, but i wanna use langchain tools.
Is this a bug or am i doing something wrong?
Version
0.10.28
Steps to Reproduce
Create a langchain agent with a queryEngineTool and a FunctionTool.
Relevant Logs/Tracbacks
No response

It looks like you passed a non-langchain LLM to a langchain agent -- I wouldn't expect this to work
I'm also not 100% sure I hooked up the new return_direct properly to to_langchain_tool() --- tbh, I would just use a llama-index agent instead of a langchain agent here
https://docs.llamaindex.ai/en/stable/examples/agent/react_agent/?h=react+agent
https://docs.llamaindex.ai/en/stable/examples/agent/openai_agent_with_query_engine/?h=query+engine+tools


The personal ranking does not match the match on the summary card.

https://user-images.githubusercontent.com/39344769/151660566-0b47ef35-e1ef-4e76-943d-7eaeed1a290a.mp4

DIe biscuits are in the good tab but have only a low match, water on the contrary is at unknown match but shows good match

Not sure if it's exactly the problem, but there's a potential confusion:

On the multi tab page, the products scores are computed with MatchedProduct and ProductPreferencesManager (cf. SmoothItModel.refresh and 3 levels (MatchedProductStatus: YES, NO, UNKNOWN)
On the product card (SmoothProductCardFound) there's a similar but probably not identical algorithm from product_compatibility_helper.dart / getProductCompatibility, with 5 levels (ProductCompatibility: UNKNOWN, INCOMPATIBLE, BAD_COMPATIBILITY, NEUTRAL_COMPATIBILITY, GOOD_COMPATIBILITY)

I don't mean that's good news, I just say the way it is.
https://www.youtube.com/watch?v=gk3v80YfC_M (sorry about that)
Who should we trust, 1 or 2?

We got feedback that 5 levels was way too much. A consensus was reached at 3 levels. So it's 1. @monsieurtanuki
https://youtu.be/AbWdEJbP1yg?t=416

I'm adding a P0


Resize or toggle height of result

Currently the result pane taking up quite a fair bit of space and in fact most of the time we focusing on the query.
Perhaps to feature to allow change of height or close it until next query runs.
Oh, btw, I did noticed there's no time taken in the results pane.
Would be great add-on for those who debugging queries and comparing the time taken to run those queries.
Thanks!

Re 1) - No UI changes are planned for the time being
Re 2) Timing queries is a bit tricky since we not only execute queries on the remote server, but also decode incoming data, and render that on the frontend. I understand that you want to have real timing info - unfortunately pgweb will not be able to provide that. If you would like to contribute timing codebase - please do!


SASL_SSL / SCRAM support

Hi,
as far as I understand SASL_SSL is not supported (and consequently SCRAM-SHA-512 is not supported too) any plans for this or eventually a hint where should I start to hack?

Finally I managed to inject the functionality by

using python-kafka from https://github.com/aiven/kafka-python:aiven-20212201:1b95333: appearantly this commit contains the _send_request_to_least_loaded_node function which is referred in kafka_rest_apis/admin.py
removing the self.kafka_client parameters from the _init function in kafka_rest_apis/init.py and somewhere else

Is this OK? Can you include this in upstream if I raise a PR? Maybe the self.kafka_client parameters have something to do with the different python-kafka versions.

Hello @krisek,
We would most certainly welcome PRs on that topic. Our own operation uses SSL authentication, so we didn't yet have our own plans for extending support to SASL_SSL.
Since Karapace uses kafka-python, supporting SASL should be a matter of propagating the suitable config to the consumer/producer instances (grep for e.g. bootstrap_servers). We have some SASL examples for kafka-python listed in this help article: https://help.aiven.io/en/articles/489572-getting-started-with-aiven-kafka

Hi Hekki @hnousiainen,
actually the functionality is implemented, what about the dependency on _send_request_to_least_loaded_node from aiven-kafka and the self.kafka_client params in the init.py?
Should I raise the PR with or without them?

Hey @krisek , _send_request_to_least_loaded_node is an important bugfix, It is currently waiting on upstream for code review. bugfix: fix infinite loop on KafkaAdminClient #2194. Until the changes are merged I'd recommend using our fork
For SASL_SSL support, it only needs validation of the configuration and then pass it to the class constructors in a few places:

KafkaProducer
KafkaConsumer , and for the rest api
KafkaAdminClient
AIOKafkaProducer

I hope this helps :)


Cluster upgrade issue

When executing upgrade command with K3S minor version higher than 9 I get "New k3s version must be more recent than current version" error.
I guess it can be related to how versions array is organized and compared (https://github.com/vitobotta/hetzner-k3s/blob/decb3f25a51d5e9af5e40013b80038af14c9105b/src/configuration/settings/new_k3s_version.cr#L32):
v1.21.13-rc1+k3s1
v1.21.14+k3s1
v1.21.14-rc1+k3s1
v1.21.2+k3s1
v1.21.2-rc1+k3s1
v1.21.2-rc1+k3s2
v1.21.2-rc2+k3s2
v1.21.3+k3s1

1.21.14 has lower index than 1.21.3.
Steps to reproduce:
$ hetzner-k3s --version
1.0.7

cat k3s.yaml | grep -v \#
---
hetzner_token:
cluster_name: test
kubeconfig_path: "./kubeconfig"
k3s_version: v1.21.3+k3s1
public_ssh_key_path: "~/.ssh/id_rsa.pub"
private_ssh_key_path: "~/.ssh/id_rsa"
use_ssh_agent: false
ssh_allowed_networks:
  - <IP_ADDRESS>/0
api_allowed_networks:
  - <IP_ADDRESS>/0
schedule_workloads_on_masters: false
masters_pool:
  instance_type: cpx21
  instance_count: 1
  location: nbg1
worker_node_pools:
  - name: small
    instance_type: cpx21
    instance_count: 3
    location: nbg1
additional_packages:
  - apparmor-profiles-extra
  - apparmor-profiles
  - apparmor-utils
  - apparmor
enable_encryption: true

$ hetzner-k3s upgrade -c k3s.yaml  --new-k3s-version v1.21.14+k3s1
Validating configuration...
Some information in the configuration file requires your attention:
  - New k3s version must be more recent than current version

Cool :)

@dzadonskii This is fixed in v1.0.8. It was a silly bug...
Closing for now but feel free to reopen if needed.


Enable running BinSkim on Foundation

This change adds a build task to enable BinSkim (a security-oriented analyzer) on our build pipeline, as well as fixes a few project settings to address binskim errors:

Enable Control Flow Guard
Enable Buffer Security Check for Detours project
Upgrade source file hash algorithm in debug info from MD5 to SHA-256.

We'll start off by enabling running BinSkim in each feeder's repo locally. Once those all pass, we'll start running BinSkim in the aggregation pipeline.

You missed dev\ProjectReunion_BootstrapDLL\ProjectReunion_BootstrapDLL.vcxproj

Is that a binary we ship? I don't see it in the published artifcats in the pipeline build. I'm not figuring out how that binary fits into the overall picture.

Is that a binary we ship? I don't see it in the published artifcats in the pipeline build

For 0.5? No. But then again Microsoft.ProjectReunion.dll isn't a feature for 0.5.0 either yet we're shipping it (though arguably we shouldn't have). Same goes for Detours.
For 0.8? Absolutely. Nothing under /dev today is fake or dead code. DIR /s dev\*.vcxproj and there's 3 sets of projects

dev\VSIX
dev\MRTCore
dev*   <= i.e. everything else in ProjectReunion

dev\Detours\Detours.vcxproj
dev\DynamicDependencyDataStore\DynamicDependency.DataStore\DynamicDependency.DataStore.vcxproj
dev\DynamicDependencyDataStore\DynamicDependency.DataStore.ProxyStub\DynamicDependency.DataStore.ProxyStub.vcxproj
dev\DynamicDependencyLifetimeManager\DynamicDependencyLifetimeManager\DynamicDependencyLifetimeManager.vcxproj
dev\DynamicDependencyLifetimeManager\DynamicDependencyLifetimeManager.ProxyStub\DynamicDependencyLifetimeManager.ProxyStub.vcxproj
dev\DynamicDependencyLifetimeManager\IDynamicDependencyLifetimeManager\IDynamicDependencyLifetimeManager.vcxproj
dev\ProjectReunion_BootstrapDLL\ProjectReunion_BootstrapDLL.vcxproj
dev\ProjectReunion_DLL\ProjectReunion_DLL.vcxproj

8 projects that produce artifacts shipping in 0.8. Different types of projects -- static lib (Detours), dll (ProxyStubs, Bootstrap, Reunion), exe (DataStore, LifetimeManager) -- but all C++. BinSkim, /ZH and other changes should be equally applied to all.


folding: introduce foldingEnabled context

Fixes https://github.com/microsoft/vscode/issues/17257
This pr introduces a context foldingEnabled which is true when folding is enabled, and false otherwise.
Now all the folding actions are using this context as a precondition. Which results in the fact that they are not present in the command palette when fodling is disabled.
I have tested this and it seems to work nicely.

@aeschli approved via chat, thus merging in


Improve error message on missing path segment keys

Example:
   file:///C:/Users/chhamo/Programming/autorest.csharp/samples/CognitiveServices.TextAnalytics/foo.json#/components/schemas/paths┬╖v9pjtw┬╖v2-name-manifests-reference┬╖put┬╖responses┬╖201┬╖content┬╖application-json┬╖schema
FATAL: System.Collections.Generic.KeyNotFoundException:
Error while processing request /acr/v1/{name}/_manifests/{reference}: key `reference` was undefined.
Verify that it is correctly defined, and if not please file an issue at https://github.com/Azure/autorest.csharp/issues/new with a swagger that reproduces.
   at AutoRest.CSharp.Output.Models.RestClient.GetPathSegments(String httpRequestUri, Dictionary`2 parameters, Boolean isRaw)+MoveNext() in C:\Users\chhamo\Programming\autorest.csharp\src\AutoRest.CSharp\Output\Models\RestClient.cs:line 471
   at System.Collections.Generic.LargeArrayBuilder1.AddRange(IEnumerable1 items)
   at System.Collections.Generic.SparseArrayBuilder1.AddRange(IEnumerable1 items)
   at System.Collections.Generic.SparseArrayBuilder1.ReserveOrAdd(IEnumerable1 items)
   at System.Linq.Enumerable.Concat2Iterator`1.ToArray()
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)

Hey @annelo-msft thoughts on this error message? Any tweaks you want to suggest while I'm under the hood here?

Cool - thanks for doing this, @chamons!
Re:

key reference was undefined.

I think it's hard for me to make a leap here from what key is -- I know you're holding a dictionary of values somewhere, but I don't know what's in it or where it came from.  If it could tell me what block of JSON to look in because that's where the dictionary values are coming from, I think that would be more helpful.
For the error from yesterday, I'd love it if it could say:

Error while processing request /acr/v1/{name}/_manifests/{reference}: reference not found in parameters block.

I'd give bonus points if it could tell me why it was looking for reference, e.g.

reference in URI path must have a matching definition in parameters block.

I like the part directing you to where to file an issue as well -- thanks for all this!

Next Text:
file:///C:/Users/chhamo/Programming/autorest.csharp/samples/CognitiveServices.TextAnalytics/foo.json#/components/schemas/paths┬╖v9pjtw┬╖v2-name-manifests-reference┬╖put┬╖responses┬╖201┬╖content┬╖application-json┬╖schema
FATAL: System.Collections.Generic.KeyNotFoundException:

Error while processing request /acr/v1/{name}/_manifests/{reference}
  Parameter 'reference' is used in the path template but is not defined in the parameters collection.
  'reference' in URI path must have a matching definition in parameters block.

   at AutoRest.CSharp.Output.Models.RestClient.GetPathSegments(String httpRequestUri, Dictionary`2 parameters, Boolean isRaw)+MoveNext() in C:\Users\chhamo\Programming\autorest.csharp\src\AutoRest.CSharp\Output\Models\RestClient.cs:line 472
   at System.Collections.Generic.LargeArrayBuilder1.AddRange(IEnumerable1 items)

Small tweak suggestion:

Parameter 'reference' is used in the path template but is not defined in the parameters collection.

^ this is the POV of the C# code

'reference' in URI path must have a matching definition in parameters block.

^ this is the POV of the JSON swagger file
It might make sense to decide which POV you want to frame the explanation as being from.  Or do both, and clarify which is which.  i.e. in this one:

'reference' in URI path must have a matching definition in parameters block.

Perhaps consider adding the information "in the input OpenAPI JSON file," or something like this?
I'll also remark that the three sentences in this error refer to the same things in different ways:

"Request", "path template" and "URI path"
Parameter 'reference', 'reference'
parameters collection, parameters block

Maybe just picking one for each to standardize on for each of these would help make it easier to understand.

I'm working on tweaking this, but I realized this isn't playing nice w\ my other PR that calls all exceptions as internal errors. I need to wrap or something.

Ok, what about this text @pakrym @annelo-msft :
Error while processing request '/acr/v1/{name}/_manifests/{reference}'

  'reference' in URI is missing a matching definition in the path parameters collection

Please review your swagger and make necessary corrections.

If the definition is correct file an issue at https://github.com/Azure/autorest.csharp/issues/new with details to reproduce.

🌷 Ship it!


Remove ML-powered queries

Removes the code to load ML-powered queries since this feature is now fully disabled.  For more information, including details on GitHub's investment in AI-powered security technology, see "CodeQL code scanning deprecates ML-powered alerts."
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[x] Confirm the changelog has been updated if necessary.

Removed the ML-powered queries checks from branch protection.


Markdown not getting rendered

Markdown files, after being rendered, are not displayed as required because react is escaping the code to prevent XSS attacks.

Fixed in #9


Handling exceptions

Hey @mario-deluna or other folk who might be happening by,
I was wondering how it would be possible to catch PDO-Exceptions using Hydrahon. My amateurish attempts at just wrapping the PDO-implementation in try/catch didn't yield any results. I'm using this tool for a project where I wanted to build SELECT statements "iteratively" depending on the user-supplied search-model  and it seemed perfect for my requirements.
I simply tried this:
public function getQueryBuilder()
  {
    $conn = $this->connection;
    $builder = new \ClanCats\Hydrahon\Builder(
      'mysql',
      function ($query, $queryString, $queryParameters) use ($conn) {
        try {
          $statement = $conn->prepare($queryString);
          $statement->execute($queryParameters);
        } catch (Exception $e) {
          error_log('Exception in DBConnector class');
          throw new Exception('Error executing DB Query', 0, $e);
        }

        if ($query instanceof \ClanCats\Hydrahon\Query\Sql\FetchableInterface) {
          return $statement->fetchAll(\PDO::FETCH_ASSOC);
        }
      });
    return $builder;
  }

Any hints would be appreciated.

Its possible receive an error if a query does not execute?
ex:
$table->insert([$array])->execute();


wrting datetime64 in netCDF may produce badly formatted or unreadable files

What happened?
When writing datetime64 and NaT values  to netCDF (using h5netcdf engine) using user defined dtype and _FillValue (to comply to some format requirements), I get different results depending on the precision of datetime64 values.
Here I'm writing datetime64 with milliseconds precision:
import xarray as xr
import numpy as np

# writing datetime64 with milliseconds
times = np.ma.array([
   np.datetime64('2010-01-01 12:00:00.005'), np.datetime64('NaT')]).astype('datetime64[ns]')

da = xr.DataArray(
    name='time',
    data=times,
    dims=('time',))
da.encoding['units'] = "seconds since 2010-01-01 00:00:00.000"
da.encoding['_FillValue'] = 1e20
da.encoding['dtype'] = np.float64
ds=xr.Dataset(coords={'time': da})
ds.to_netcdf('milliseconds.nc', engine='h5netcdf')

new_ds = xr.open_dataset('milliseconds.nc')
print(new_ds.time)

above works fine, and fill values are correctly written, as shown by the CDL output:
netcdf milliseconds {
dimensions:
	time = 2 ;
variables:
	double time(time) ;
		time:_FillValue = 1.e+20 ;
		string time:units = "seconds since 2010-01-01" ;
		string time:calendar = "proleptic_gregorian" ;
data:

 time = 43200.005, _ ;
}

However, if instead I write datetime64 rounded to seconds, the output result is wrong:
# writing datetime64 with seconds
times = np.ma.array([
    np.datetime64('2010-01-01 12:00:00'), np.datetime64('NaT')]).astype('datetime64[ns]')

da = xr.DataArray(
    name='time',
    data=times,
    dims=('time',))
da.encoding['units'] = "seconds since 2010-01-01 00:00:00.000"
da.encoding['_FillValue'] = 1e20
da.encoding['dtype'] = np.float64
ds=xr.Dataset(coords={'time': da})
ds.to_netcdf('seconds.nc', engine='h5netcdf')

new_ds = xr.open_dataset('seconds.nc')

The CDL output is as follow (note that -9.22337203685478e+18 is used instead of the required 1e20 as _FillValue):
netcdf seconds {
dimensions:
	time = 2 ;
variables:
	double time(time) ;
		time:_FillValue = 1.e+20 ;
		string time:units = "seconds since 2010-01-01" ;
		string time:calendar = "proleptic_gregorian" ;
data:

 time = 43200, -9.22337203685478e+18 ;
}

As the result, attempting to read the result file will fail:
Traceback (most recent call last):
  File "conversion.pyx", line 228, in pandas._libs.tslibs.conversion.cast_from_unit
OverflowError: Python int too large to convert to C long

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "timedeltas.pyx", line 377, in pandas._libs.tslibs.timedeltas._maybe_cast_from_unit
  File "conversion.pyx", line 230, in pandas._libs.tslibs.conversion.cast_from_unit
pandas._libs.tslibs.np_datetime.OutOfBoundsDatetime: cannot convert input -9.223372036854776e+18 with the unit 's'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/coding/times.py", line 326, in decode_cf_datetime
    dates = _decode_datetime_with_pandas(flat_num_dates, units, calendar)
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/coding/times.py", line 272, in _decode_datetime_with_pandas
    pd.to_timedelta(flat_num_dates.min(), time_units) + ref_date
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/pandas/core/tools/timedeltas.py", line 223, in to_timedelta
    return _coerce_scalar_to_timedelta_type(arg, unit=unit, errors=errors)
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/pandas/core/tools/timedeltas.py", line 233, in _coerce_scalar_to_timedelta_type
    result = Timedelta(r, unit)
  File "timedeltas.pyx", line 1896, in pandas._libs.tslibs.timedeltas.Timedelta.__new__
  File "timedeltas.pyx", line 356, in pandas._libs.tslibs.timedeltas.convert_to_timedelta64
  File "timedeltas.pyx", line 379, in pandas._libs.tslibs.timedeltas._maybe_cast_from_unit
pandas._libs.tslibs.np_datetime.OutOfBoundsTimedelta: Cannot cast -9.223372036854776e+18 from s to 'ns' without overflow.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/coding/times.py", line 218, in _decode_cf_datetime_dtype
    result = decode_cf_datetime(example_value, units, calendar, use_cftime)
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/coding/times.py", line 328, in decode_cf_datetime
    dates = _decode_datetime_with_cftime(
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/coding/times.py", line 242, in _decode_datetime_with_cftime
    cftime.num2date(num_dates, units, calendar, only_use_cftime_datetimes=True)
  File "src/cftime/_cftime.pyx", line 627, in cftime._cftime.num2date
  File "src/cftime/_cftime.pyx", line 421, in cftime._cftime.cast_to_int
OverflowError: time values outside range of 64 bit signed integers

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/conventions.py", line 450, in decode_cf_variables
    new_vars[k] = decode_cf_variable(
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/conventions.py", line 291, in decode_cf_variable
    var = times.CFDatetimeCoder(use_cftime=use_cftime).decode(var, name=name)
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/coding/times.py", line 992, in decode
    dtype = _decode_cf_datetime_dtype(data, units, calendar, self.use_cftime)
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/coding/times.py", line 228, in _decode_cf_datetime_dtype
    raise ValueError(msg)
ValueError: unable to decode time units 'seconds since 2010-01-01' with "calendar 'proleptic_gregorian'". Try opening your dataset with decode_times=False or installing cftime if it is not installed.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/jfpiolle/git/felyx_processor/test_time.py", line 39, in <module>
    new_ds = xr.open_dataset('seconds.nc')
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/backends/api.py", line 588, in open_dataset
    backend_ds = backend.open_dataset(
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/backends/h5netcdf_.py", line 418, in open_dataset
    ds = store_entrypoint.open_dataset(
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/backends/store.py", line 46, in open_dataset
    vars, attrs, coord_names = conventions.decode_cf_variables(
  File "/home/jfpiolle/mambaforge/envs/poetry/lib/python3.10/site-packages/xarray/conventions.py", line 461, in decode_cf_variables
    raise type(e)(f"Failed to decode variable {k!r}: {e}") from e
ValueError: Failed to decode variable 'time': unable to decode time units 'seconds since 2010-01-01' with "calendar 'proleptic_gregorian'". Try opening your dataset with decode_times=False or installing cftime if it is not installed.

What did you expect to happen?
the content of the output in the second example (with values rounded to seconds) should be similar to the first one (minus the precision of the values of course) since same units, _FillValue and variable dtype are used.
I did not met this issue with earlier versions of xarray.
Minimal Complete Verifiable Example
see in issue description.

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[ ] Complete example — the example is self-contained, including all data and the text of any traceback.
[ ] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[ ] New issue — a search of GitHub Issues suggests this is not a duplicate.
[ ] Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output
No response
Anything else we need to know?
 We've recently reworked the CF masking. Is it possible to check, if the latest version (released yesterday) still has this issue?
The other thing is, that nanosecond precision isn't possible with floating point on-disk values. See also https://github.com/pydata/xarray/issues/7817 Internally we use int64 which nicely fits NaT with NetCDF int64 default _FillValue.

@kmuehlbauer thanks for checking. I tried with your latest version (xarray-2024.9.0) and have the same failure. Also ignore the conversion to nanoseconds in my example, was playing around (in particular because of some warning with pandas), but in fact whether or not I convert to nanoseconds I do get the same behaviour.

Ok, @jfpiolle, thanks for testing this out.
If it is not too much of an effort for you, are you able to find a working version in the past? And if there is one, are you familiar with git-bisect?
I'll definitely have a look into this the next days.

@kmuehlbauer I am not familiar with git-bisect; however I can confirm it is working as expected with xarray-2023-12-0.

@jfpiolle Thanks for this information. It's really useful.

@jfpiolle I think I've found the root cause (or at least the point of failure).
The following was added in #8575 to improve handling of chunked times (cc @spencerkclark). I'm not sure if I'm missing something, but this cast should not be at this position in the code. I've tested this and removing these two lines makes the above example work.
https://github.com/pydata/xarray/blob/18e5c87696c2233202bc67066408e6f495d0327d/xarray/coding/times.py#L805-L806
@jfpiolle Are you able to check if the created file conforms to your expectations, if you remove these two lines. I'm sure we can work out a solution but it can be tricky.
@spencerkclark This is another one of those tricky points we have to put on the list. Maybe you see a quick fix hiding around the corner?

Thanks @kmuehlbauer—I’ll try and take a closer look over the weekend.

@kmuehlbauer I confirm that if I remove l.805-806 it works again and the content of the created files is correct!

I’ll try and take a closer look over the weekend.

Thanks @spencerkclark, much appreciated, as I can't immediately see, in which cases these lines are needed.

See #9497 for a quick fix for this issue, though I think you are right @kmuehlbauer that we should rethink the casting in the lines you mentioned.
The motivation behind adding the casting in #8575 was to:

Enable raising an error in the event that for chunked arrays an integer dtype was requested, but floating point values were required (since we cannot modify the encoding units like we can for times in memory).
Enable raising an error in the event that the dtype encoding requested would lead to overflow (#8542).

In hindsight, I think there is a better way to address (1)—essentially we add a branch where we raise instead of modify the units if allow_units_modification is False. I believe this would be more robust than the current approach, which lets some issues slip through the cracks.  It's a little tricky since we catch so many exceptions in that part of the code, but I'm sure we can find a way to ensure we raise an exception that gets through.
With regard to (2), we could decide it is enough of an edge case that we don't try to actively guard against it; for example in principle you could also try to encode ordinary int64 values as int16 values and experience silent overflow, and we don't currently guard against that.  As you note, if we remove the casting it would also help address https://github.com/pydata/xarray/issues/9134.

@spencerkclark Thanks for taking the time to enjoy us with this enlightening ( :heart:  :100: ) description of the different problems and their possible solutions. Maybe it might be useful to discuss ways to a more permanent solution in one of the next meetings?

Sure thing @kmuehlbauer—I'd be happy to discuss these broader issues in an upcoming meeting.  I could try to make it to the next one—it looks like that would be on 9/25?
I went ahead and put together a sketch of the changes I proposed to eliminate the casting step in #9498, just to give a more concrete sense for what that would look like.

I could try to make it to the next one—it looks like that would be on 9/25?

Great, I've missed last meetings, so good occasion to catch up.

I went ahead and put together a sketch of the changes I proposed to eliminate the casting step in #9498, just to give a more concrete sense for what that would look like.

I didn't had a look yet, will do the next days.


Implement go to definition

Currently not implemented in PTVS LS, hence Code, Hover Definition and Intellisense test fails and is disabled.

Folding into https://github.com/Microsoft/vscode-python/issues/1006


feat: add highlight for orphan links

Added a highlight for orphan links.
Closes #501

There have been a few requests for more highlight customization. I want to rethink the highlighting system holistically instead of adding patches for specific cases, so I will be leaving this pending until I can find the time to think about this some more.

Thanks for the PR! I also added a Hl group for the orphaned link's target and highlighted it as an error by default.


[Suggestion] Config Option to Disable Mekanism Steel

In our modpack we are using more difficult means to make Steel. However, since ModTweaker refuses to support Mekanism we cannot easily disable the Mekanism steel recipes. Would you be willing to add a config option to disable the Metallurgic Infuser recipe of making steel?

You could make a fork of this and compile it without the steel recipe

I'd rather not, then it would make sense to add support to remove any recipe. IMC does enough for the time being.

I'd rather not, then it would make sense to add support to remove any
recipe. IMC does enough for the time being.

Steel seems like a bit of a special case, since its difficulty is wildly
different between the various mods. It varies from pretty trivial in
EnderIO, to a bit more involved in Mekanism, to laborious (yet
fundemental) in Immersive Engineering. I could see a pack wanting some
parts of Mek (like the jetpack), but aiming for a general IE vibe,
wanting to make people use the IE steel production.

@BrianEdmonds Can't you remove Mek steel from the OreDict with Tweaker?

I've not played with it myself, I was just observing that the complexity of producing steel is something that varies quite a bit between mods, so would not be unreasonable to configure with a simple option.


Develop

Codecov Report
Patch and project coverage have no change.

Comparison is base (1cd1f45) 89.64% compared to head (c122720) 89.64%.

:exclamation: Current head c122720 differs from pull request most recent head 15faae4. Consider uploading reports for the commit 15faae4 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   89.64%   89.64%
=======================================
  Files          10       10
  Lines         792      792
=======================================
  Hits          710      710
  Misses         82       82

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Describe Composite Formatting of ValidationAttribute ErrorMessages

It recently came to my attention that ValidationAttribute error messages support composite formatting.  I discovered this while reading about localization of DataAnnotations.  That section references a sample code snippet from this repo with the follow property declaration:
https://github.com/aspnet/Docs/blob/4dad08a6662a5cf2eac03c46b4dbb2cd009a43ef/aspnetcore/fundamentals/localization/sample/Localization/ViewModels/Account/RegisterViewModel.cs#L16-L20
The [StringLength] attribute is what caught my eye; I'd never seen anything like that!  A composite format string in an attribute constructor??
Unfortunately, I could not find the parameters for these composite format strings anywhere in the Docs, and had to resort to digging through the .NET Core source code to find how these strings were actually used (usually in string.Format() calls inside overriden FormatErrorMessage() calls).  It really seems like this information should be documented somewhere other than XML comments in the source code.
Possible TOC locations:

Introduction to model validation
Introduction to using tag helpers in forms
Adding validation
Part 6: Using Data Annotations for Model Validation

Suggested reviewers:

@Rick-Anderson
@jerriep
@rachelappel
@damienbod
@hishamco

@Rabadash8820  I think this would make a great addition. Maybe a paragraph describing it and a sample. we could have a list of validation attributes that support this and the list would be a link to the source code.
@danroth27  please comment

@Rabadash8820 is this covered in one of your PRs?

Unfortunately no.  I've had the reference source sitting in an open tab on my browser since I made this issue; just haven't gotten around to combing through it yet. 😛

@mairaw This should be documented in the data annotations docs. Maybe in the API ref?


Show blank image if no user input detected within countdown time

https://github.com/sopra-fs23-group-15/envisage-client/commit/f85b2455b260038e2b7448c5d8d88198723a7586
AND the blank image comes from server - https://github.com/sopra-fs23-group-15/envisage-server/commit/d23a6a2957d2c3cdb44cd9f4cf44098f6bd262ab


Remove use of deprecated/removed allocator typedefs

There are some uses of removed typedefs inside allocators. Example: https://github.com/abseil/abseil-cpp/blob/79e0dc11514df035a8d07a356f9ee1800fb2160c/absl/container/fixed_array.h#L110 uses std::allocator<...>::pointer which is deprecated since C++17 and removed in C++20. This makes abseil fail to compile in C++20 mode
See e.g. https://en.cppreference.com/w/cpp/memory/allocator
Available typedefs: value_type, size_type, difference_type

Thanks for reporting this. It seems we need to migrate to use allocator_traits to replace these.


docs(cdk-stepper): add guide to create stepper

@mmalerba: This is the PR as discussed in https://github.com/angular/material2/issues/8993


Time precision is not being returned

There is time precision in the dates in the following kgtk exploded egde file
but is not returned in the get canonical data api
t2wml-ann.csv.gz

I can't load the annotated file. I've created a dataset called ITAY1 and posted the file to /datasets/ITAY1/annotated .
First it failed because in annotated/post.py you pass the dataset as the first parameter to the validator's validate method. The validate method thinks this is an Excel file, and tries to load it. I changed the call to pass None instead. Then the validation fails, but I can't see the error because after the validation fails, post.py fails because it expects three values to be returned from validate, while only two are returned. So the end result is a 500 error.
It is as if I don't have the correct code for either the validator or the request handler. I'm using the development branch.

Sorry about the assignment mixup, I forgot to update t2wml-annotator, which caused everything to malfunction.

Now that I got the right versions in place, I get validation errors and can't upload the annotated file at all:
    {
        "Error": "Dataset ID in the file is not same as the Dataset ID in the URL",
        "Line Number": 1,
        "Column": "B",
        "Description": "Expected: ITAY1 but got:node1"
    },
    {
        "Error": "Incorrect annotation: First Column",
        "Line Number": 1,
        "Column": "A",
        "Description": "First row in column 1 should be \"dataset\""
    },
    {
        "Error": "Incorrect annotation: First Column",
        "Line Number": 2,
        "Column": "A",
        "Description": "Second row in column 1 should be \"role\""
    },
    {
        "Error": "Incorrect annotation: First Column",
        "Line Number": 3,
        "Column": "A",
        "Description": "Third row in column 1 should be \"type\""
    },
    {
        "Error": "Incorrect annotation: First Column",
        "Line Number": 4,
        "Column": "A",
        "Description": "Fourth row in column 1 should be \"description\""
    },
    {
        "Error": "Incorrect annotation: First Column",
        "Line Number": 5,
        "Column": "A",
        "Description": "Fifth row in column 1 should be \"name\""
    },
    {
        "Error": "Incorrect annotation: First Column",
        "Line Number": 6,
        "Column": "A",
        "Description": "Sixth row in column 1 should be \"unit\""
    },
    {
        "Error": "Annotation missing: variable",
        "Line Number": 2,
        "Column": -1,
        "Description": "Annotation spreadsheet should have at least one column annotated as \"variable\""
    },
    {
        "Error": "Annotation missing: time",
        "Line Number": 2,
        "Column": -1,
        "Description": "Annotation spreadsheet should have at least one column annotated as \"time\""
    },
    {
        "Error": "Annotation invalid",
        "Line Number": 2,
        "Column": -1,
        "Description": "Either \"location\" or \"main subject\" should be present as annotation for a column. None of the columns are annotated as \"location\" or \"variable\""
    },
    {
        "Error": "Roles in following column(s) are invalid: B,C,D,E,F,G,H,L",
        "Line Number": 2,
        "Column": "B,C,D,E,F,G,H,L",
        "Description": "Valid roles are one of the following: main subject,time,location,variable,qualifier,unit"
    }
]```

I know how to fix the first one (with the wrong dataset name), but not the others.

@zmbq please import this file directly into database. This is a KGTK exploded edge file
This file is not supposed to be uploaded via the /annotated API. Sorry for the confusion

The attached file can't be imported as is. For future reference, these are the steps necessary to reproduce the bug

Convert the file to TSV
Create the dataset by POSTing to /metadata/datasets:

{
    "dataset_id": "t2wml_test_02",
    "description": "t2wml test #2",
    "name": "t2wml_test_02",
    "url": "https://nowhere.org"
}

Import the TSV file

Now you can query /datasets/t2wml_test_002/variables/ingo and see the time precision is N/A on every row.

The problem was the precision was retrieved as 11.0 for some reason, which caused a simple conversion issue - int('11.0') throws a ValueError.
Fixed in the development branch.

@zmbq I will have detailed steps to reproduce, my bad.
This is working now, closing the issue


Missing donate button on Tribute pages

We are missing a donate button on the individual tribute fund pages.
See here on CVI http://www.cancervaccine.org.uk/catherinewilson.html
Also i can the button behaves different to the other donate buttons as seen here: http://www.cancervaccine.org.uk/cwdonate.html

Just added a normal donate button for now


Linux doesnt work when the messages contains <>

    MessageAlert {
        title: "FOOBAR",
        //somehow `<` and `>` are invalid characters and cause the msg to get replaced
        // by some generic text thus i replace them
        text: "Doenst <work>",
        typ: MessageType::Error,
    }
        .show()
        .unwrap();

displays another message. it shows : "An error has occured"
tested on arch with i3

Thanks for reporting. The cause is that zenity and kdialog supports html syntax, and <>& are special chars. When there's syntax erroes in messages, kdialog will treat them as pure texts but zenity will fail. I should escape these characters before calling zenity.

Fixed in v0.4.3


[BUG] - ValidationError for kube_context when deploying on existing k8s

Describe the bug
A ValidationError occurs when initializing ExistingInputVars as part of the nebari deploy without passing an explicit value for kube_context. According to the schema validation rules, the validation expects a non-null string for this field when configuring the existing provider type. However, it seems that the default values is not being correctly accessed.
Expected behavior
Default value should be used instead, as originally suggested
https://github.com/nebari-dev/nebari/blob/a26b8df19c31363082ca3104e4e7b2e9354b22ae/RELEASE.md?plain=1#L1137
OS and architecture in which you are running Nebari
Linux
How to Reproduce the problem?

Set the provider to existing in the configuration.
Do not provide a value for kube_context
Attempt to deploy, for easier reproduction running nebari render would trigger the validation as well

Command output
│ 8 in input_vars                                                                                │
│                                                                                │
│   695 │   │   if self.config.provider == schema.ProviderEnum.local:                              │
│   696 │   │   │   return LocalInputVars(kube_context=self.config.local.kube_context).dict()      │
│   697 │   │   elif self.config.provider == schema.ProviderEnum.existing:                         │
│ ❱ 698 │   │   │   return ExistingInputVars(                                                      │
│   699 │   │   │   │   kube_context=self.config.existing.kube_context                             │
│   700 │   │   │   ).dict()                                                                       │
│   701 │   │   elif self.config.provider == schema.ProviderEnum.do:                               │
│                                                                                │
│ in pydantic.main.BaseModel.__init__:341                                                          │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
ValidationError: 1 validation error for ExistingInputVars
kube_context
  none is not an allowed value (type=type_error.none.not_allowed)

Versions and dependencies used.
2024.4.1rc1
Compute environment
None
Integrations
No response
Anything else?
No response

As an extra comment here, I think we should get the current default context from kubectl (we are doing this somewhere already), and apply as the default value. Though, I would also like to add a message to the user to validate such information when attempting to run deploy
$ nebari deploy -c ***
Do you approve deploying Nebari using the current kube_context configuration <value+from+yaml>? (Y/n)


Enable Python 3.11

@LukeWeidenwalker could you please try to enable Python 3.11 as well? This would allow to align with https://github.com/Open-EO/openeo-pg-parser-networkx which already supports it.

I don't have bandwidth to work on this right now, but ofc happy to review any incoming PRs!
Linking to my recommendations for how to do this in https://github.com/Open-EO/openeo-python-client/pull/434#discussion_r1238613033?

Ok, I thought I would need some more specific permissions on the repo to run the tests. I'll do it!

https://github.com/Open-EO/openeo-processes-dask/pull/134


chore: Align package.json name with our primary NPM package

Description
This should allow us to access more GitHub metrics, e.g. https://github.com/cloudscape-design/components/network/dependents
How has this been tested?
N/A

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster Should we change the name in the package-lock.json too?


Test: Rename: ChargebackRateDetailCurrency -> Currency

https://github.com/ManageIQ/manageiq/pull/19538

https://github.com/ManageIQ/manageiq/pull/19542


📨 Generic transaction discord messages

📝 Description
This PR is an improvement of the transaction handler to avoid send the same message on discord on different transaction type.
🏗 Architecture

SendMessage actor message has been modified the get a generic of type Message trait. Message trait is responsible of call the discord library to send the message.
TxHandler now hold a generic of type TransactionMessage trait that should impl Message trait.
TransactionMessage trait allow to generate the message to send to discord based on the transaction result and subscribers.

I put it in draft, for further analysis with @amimart.


Bump maia to latest HEAD and bdk to 0.21

Includes latest BDK and drops backwards compatibility.
BDK changed balance API in 0.21 and now you need to explicitly specify which
balance one you want (I opted for all spendable utxos).
It also includes a breaking change for the wallet derivation paths:
From now on keys for testnet/regtest are derived from the path m/84'/1'/0 while mainnet they are derived from m/84'/0'/0. Before that testnet/regtest keys were derived from m/84'/0'/0 as well.
The second commit includes a fix for #2917
With bdk>=0.20 the wallets are derived from a different derivation paths for testnet/regtest. This may lead to checksum errors if you had a db pre initialized. In order to not ask the user to delete their db we derive the wallet name from the key.
Resolves #2917
Note: this is a breaking change for our testnet setup. Once merged we should withdraw all funds from the old versions or simply fund them again using faucets.
Note2: I opted for the breaking change because I think the testnet setup is not critical. No funds are in danger on mainnet as the derivation path on mainnet has not changed.

Should we just squash the two commits? The first one has a known bug that is fixed in the second one. It's fine either way, because it is nice to have separate commit messages. Your call.

I'll leave it. I think it's nice to have these two commits separately and it is not a real bug (:

bors r+


only one page would be shown except the ranking list

It can only show only one page and it prompts "fail to load".Can you check it and fix it?Thank you.

Pixiv senior member account the site used was outdated, thus the searching feature(ranking by popularity) can only show the illustrations of the first page.

There is a convenient way to search the most popular illustrations.You can put a space and put 10000 after the label you want to search.For example,you can search"オリジナル　10000" to find the illustrations collected by more than 10000 people without the Pixiv senior member account.Can this method solve the problem?


Add row count to output of "query_events"

Goal is to be able to compare row counts of tables between separate ETL runs.
First, look up the ETLs in the current environment with:
arthur.py query_events -q

Let's say the output is:
etl_id           | step    | timestamp
-----------------+---------+--------------------
C92AC14C4AD8442C | upgrade | 2019-05-05T15:47:11
4EA4FC6494CE496B | upgrade | 2019-05-05T20:55:28

If we now fetch the event information, it would create false-positives in comparisons since the time information is included. Consider:
# arthur.py query_events -q C92AC14C4AD8442C
target                           | step    | event  | timestamp           | elapsed | rowcount
---------------------------------+---------+--------+---------------------+---------+---------
redshift_experiments.dimensions  | upgrade | finish | 2019-05-05T15:47:56 |  42.85  |  98765
redshift_experiments.facts       | upgrade | finish | 2019-05-05T15:48:43 |  46.80  |  7654321
(2 rows)

So compare two runs by selecting only rowcount in the output. For example:
# arthur.py query_events -q C92AC14C4AD8442C --column rowcount
target                          | event  | rowcount
--------------------------------+--------+---------
redshift_experiments.dimensions | finish | 98765
redshift_experiments.facts      | finish | 7654321
(2 rows)
# arthur.py query_events -q 4EA4FC6494CE496B --column rowcount
target                          | event  | rowcount
--------------------------------+--------+---------
redshift_experiments.dimensions | finish | 44765
redshift_experiments.facts      | finish | 7654321
(2 row2)

(In this case ... something changed in the second run with the dimensions ... go fix it :-) )
Overall, we'll always show the target and event columns.

Any chance you'd be willing to write up a short runbook/playbook on this use case, exploiting this new feature?


nixos-rebuild: use substitute rather than substituteAll

Description of changes
There's no change in produced output, though this does rebuild the script. Rationale is here:

https://github.com/NixOS/nixpkgs/issues/237216

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is similar to https://github.com/NixOS/nixpkgs/commit/193f4fea90a1b26d7bbf8d04b60f6522e830dd65.

Thanks!


[FEATURE]: Enable contribution panel by default

Change description

Enable the contribution panel by default. If there is no user it will show a contribution panel will show text:
So far we could identify the list of code contributors 🤨, Are you using Git?

Before:

After:

Type of change

[ ] Bug fix (fixes an issue)
[ ] New feature (adds functionality)

Related issues
Fix #354
Checklists
Development

[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[x] Code follows project security practices and guidelines

Code review

[x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to issue tracker where applicable

Looks good to me!
Thank you @developerHet  for your contribution 🚀


Creation of Error Page

We need to create a error page so spring can redirect there if anything dumb happens

Error page created


(scheme time)

[ ] current-jiffy
[ ] current-second
[ ] jiffies-per-second

R7RS compatibility guarantee is changed to v0.3 or later issue.


Changed favicon string to env variable

@lirantal @codydaig LGTM. Whoever gets to this first, just make sure it's fine and then feel free to merge.

@codydaig yes possibly, though maybe a path.resolve or something is better? Also, maybe there should be a test for different favicons based on the environment?

@rodp82 Can you make the changes to use path.resolve and the correct path using ./ and I think this should be good to go.


Follow API style guide

https://ocp-software-handbook.readthedocs.io/en/latest/general/api.html

I think this maybe referred to the download endpoint, which was refactored sometime later.


opend projects not all git repo,git-plus Invalid

RepoA is a SVN repo; RepoB is a GIT repo. open RepoA,and then open RepoB. Now,git-plus will be Invalid on RepoB!
Have you looked at the guidelines for contributing to this codebase?
Have you added tests and run apm test?

I can't reproduce the error. How are you opening Repo B? Are you adding it as a project folder or are you simply opening it in a new window?

Like screenshots, the order is the key to reproduce the error.

What is the error you are seeing that implies the package doesn't recognize repoB?

git-plus version: 7.8.0
git.coffee [sm]:146 Uncaught (in promise) TypeError: Cannot read property 'getWorkingDirectory' of null
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:146:43
    at Array.forEach (native)
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:145:17

Can you also give some exact steps to reproduce this? Which commands are you trying to run?

See this GIF. My Atom Version is 1.14.0.  Notice the Order!

The latest version of atom is 1.17.0. What's preventing you from upgrading?
I'm unable to reproduce this so I'm wondering if upgrading might help you.

same error,with Atom 1.17.0 git-plus 7.8.1
/Users/yanfeng/.atom/packages/git-plus-7.8.1/lib/git.coffee:279 Uncaught (in promise) TypeError: Cannot read property 'getWorkingDirectory' of null
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:146:43
    at Array.forEach (native)
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:145:17
/Users/yanfeng/.atom/packages/git-plus-7.8.1/lib/git.coffee:279 Uncaught (in promise) TypeError: Cannot read property 'getWorkingDirectory' of null
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:146:43
    at Array.forEach (native)
    at /Users/yanfeng/.atom/packages/git-plus/lib/git.coffee:145:17

Alright I just pushed 7.9.1 with the change


[Feature Request] Renamable Loot - Player Loot drop list.

I have been adding plushies to the loot pools of monsters with this mod for my mod pack Shattered Company. I stumbled across a sinister idea when I saw a Scavenger Plushie.
I would love the player to have a 100% chance to drop a plushie with their player name and possibly cause of death on it. I am sure this is not in the scope of your mod. However, the idea excites me, I would love it and had to ask. I think it would be hilarious to see a pool of blood and a plushie sitting there as an erie reminder of those who have past.
A landmark for Laviathin deaths. Locations of where Brackens grabbed their victims. Where players were turned into a mimic. haha
https://thunderstore.io/c/lethal-company/p/Scintesto/Scavenger_Plushie/

Yup probably would make it a separate mod but it is a cool idea and when I have an idea I might hop on to it. Thanks for the cool idea


github actions is migrating to Node.js 20, requiring a new version of the action.

Not specific to this action, but all over github everyone is getting warnings like the following:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dhall-lang/setup-dhall@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Will there be a release of this action to use v20? The last time this migration happened was 12 -> 16, and the commit for that looks trivial: https://github.com/dhall-lang/setup-dhall/pull/6 I'm not a JS developer and I don't know whether there are any breaking changes that would need to be dealt with.

This will be resolved by #11

Thank you!


Demo comments

Add comments to illustration
Basic example but everything is automatic: we don't need to know the pattern a priori or to give an explicit formulat for the optimal coloring
We just provide plain Julia code, switch the backend and voilà
Add number of colors to the figure

Closed by #39.


How to disable the scroll effect while changing tabsContent?

Hey, vertical_tabs is really simple and useful widget. Thanks.
Now I want to disable the scroll effect :
contentScrollAxis: Axis.vertical,
contentScrollAxis: Axis.horizontal,
while changing tabsContent.
In other words, I hope there is only one way to change tabsContent: click the Tab. And no scroll animation.
How should I do ? Thanks.

Hi, If I understand you correctly. you can use disabledChangePageFromContentView  property

changePageDuration: Duration(microseconds: 1)

Hi, If I understand you correctly. you can use disabledChangePageFromContentView  property

I don't you about the guy that made the issue, but sure it helped me. Thanks


CFNTest doesn't delete taskcat auto bucket where it uploads the project files and templates to

Describe the bug
When I run taskcat test run it successfully deletes the auto bucket it creates for the project files and templates
When I run pytest using CFNTest the test successfully passes and all stacks it creates are deleted but the auto bucket for some reason doesn't get deleted not sure why the clean_up method looks like it has code to delete the the buckets
see https://github.com/aws-quickstart/taskcat/blob/main/taskcat/testing/_cfn_test.py#L158 but for some reason the bicket with all the project files and templates is still there ?
To Reproduce
Steps to reproduce the behavior:

aws cloudformation package cloudformation/tests/firehose.yaml > cloudformation/tests/firehose-packaged.yaml

pytest -k test_firehose

observe everything works and is deleted except the auto bucket created to upload the project files and templates too

Are you testing a QuickStart or Custom template?
Not sure I am guessing quickstart ?

Attach or link a copy of the template if possible (remove any sensitive info)

.taskcat.yaml
project:
  name: cf-rest-event-box-test
  regions:
    - us-east-1
  build_submodules: false
  package_lambda: false
tests:
  firehose:
    parameters:
      FireHosePolicyName: $[taskcat_autobucket]
    template: ./cloudformation/tests/firehose-packaged.yaml

./cloudformation/tests/firehose-packaged.yaml
AWSTemplateFormatVersion: '2010-09-09'
Parameters:
  FireHosePolicyName:
    Type: String
    Description: The Name to give to the firehose policy
    AllowedPattern: ^[\w+=,.@-]+$
    MinLength: 1
    MaxLength: 128
Resources:
  KinesisStream:
    Type: AWS::CloudFormation::Stack
    Properties:
      TemplateURL: https://s3.us-east-1.amazonaws.com/${MYBUCKET}/tests-firehose/0866c4ffaa8d213bd354493af7439176.template
  S3Bucket:
    Type: AWS::CloudFormation::Stack
    Properties:
      TemplateURL: https://s3.us-east-1.amazonaws.com/${MYBUCKET}/tests-firehose/7ad3f4ac80a274c0a8537cf1dfd3b236.template
  FirehoseRole:
    Type: AWS::CloudFormation::Stack
    Properties:
      Parameters:
        KinesisStreamModule:
          Fn::GetAtt:
          - KinesisStream
          - Outputs.StackName
        S3BucketModule:
          Fn::GetAtt:
          - S3Bucket
          - Outputs.StackName
        FireHosePolicyName:
          Ref: FireHosePolicyName
      TemplateURL: https://s3.us-east-1.amazonaws.com/${MYBUCKET}/tests-firehose/3d5f42ebf4cc6402254384293d58f0fe.template
  Firehose:
    Type: AWS::CloudFormation::Stack
    Properties:
      Parameters:
        KinesisStreamModule:
          Fn::GetAtt:
          - KinesisStream
          - Outputs.StackName
        S3BucketModule:
          Fn::GetAtt:
          - S3Bucket
          - Outputs.StackName
        StreamType: private
        FirehoseRoleArn:
          Fn::GetAtt:
          - FirehoseRole
          - Outputs.Arn
      TemplateURL: https://s3.us-east-1.amazonaws.com/${MYBUCKET}/tests-firehose/b588143b451d8b1b9482732b295ca2bd.template
Outputs:
  StreamName:
    Value:
      Fn::GetAtt:
      - KinesisStream
      - Outputs.Name
    Export:
      Name:
        Fn::Sub: ${AWS::StackName}-StreamName
  BucketName:
    Value:
      Fn::GetAtt:
      - S3Bucket
      - Outputs.Name
    Export:
      Name:
        Fn::Sub: ${AWS::StackName}-BucketName

test_firehose.py
from taskcat.testing import CFNTest
from .utils import get_config, find_output
import boto3
import time
import json
import uuid
import pytest

def test_firehose():
    test = CFNTest(config=get_config(), regions="us-east-1", test_names="firehose")

    with test as stacks:
        bucket_name = find_output("BucketName", stacks)
        s3 = boto3.resource("s3")
        bucket = s3.Bucket(bucket_name)
        assert not list(bucket.objects.all())
        record = {"foo": "bar", "bar": "foo"}
        stream_name = find_output("StreamName", stacks)
        kinesis = boto3.client("kinesis")
        kinesis.put_record(
            StreamName=stream_name,
            Data=json.dumps(record).encode("utf-8"),
            PartitionKey=str(uuid.uuid4()),
        )
        time.sleep(450)
        assert list(bucket.objects.all())
        bucket.objects.all().delete()

utils.py
rom taskcat import Config
from pathlib import Path
import boto3

def get_config():
    project_root_path = Path(__file__).parent / "../.."
    input_file_path = project_root_path / ".taskcat.yml"
    config = Config.create(
        project_root=project_root_path,
        project_config_path=input_file_path,
    )
    return config

def find_output(output_key, stacks):
    for stack in stacks:
        for output in stack.outputs:
            if output.key == output_key:
                return output.value

Provide the parameters that you passed. (remove any sensitive info)

How did you install taskcat? (docker or pip3)
pip3

Are you using a profile, an instance role or  access keys to run taskcat?
profile

Is your AWS environment configured via aws configure?
Yes  ~/.aws/config

Expected behavior
That the autobucket created to upload project files and templates to is deleted
Screenshots
If applicable, add screenshots to help explain your problem.
**Version (Please make sure you are running the latest version of taskcat)

Taskcat Version (ex: [2018.817.210357])

Note: Python Version (python3 required)
3.7.7
To find versions:
Via taskcat: taskcat -V 0.9.23
Via pip3: pip3 show taskcat 0.9.23
Note: both version should match
To update taskcat run:
for docker : docker pull taskcat/taskcat
for pip3: pip3 install --upgrade taskcat
Additional context
Add any other context about the problem here.

Yeah, I confirm this for taskcat v.0.9.23. I was debugging the code and it's crazy because the CFNTest.clean_up() method invokes the Config.get_buckets() method that creates a new project bucket! That new bucket is the one that is then deleted.

Law of unintended consequences. I'll look at this next week.

Just in case you cannot wait for @andrew-glenn's fix, I slightly modified the file _config.py to "fix it up" (be careful, I have only tested it in a few cases).
diff --git a/taskcat/_config.py b/taskcat/_config.py
index bdcb0e5..93a4c50 100644
--- a/taskcat/_config.py
+++ b/taskcat/_config.py
@@ -282,8 +282,7 @@ class Config:
             name = bucket_objects[region.account_id].name
             auto_generated = bucket_objects[region.account_id].auto_generated
         else:
-            name = test.s3_bucket
-            auto_generated = False
+            return test.s3_bucket
         bucket_region = self._get_bucket_region_for_partition(region.partition)
         bucket_obj = S3BucketObj(
             name=name,
@@ -299,6 +298,7 @@ class Config:
         )
         if new:
             bucket_obj.create()
+            test.s3_bucket = bucket_obj
         return bucket_obj

     def _create_regional_bucket_obj(self, bucket_objects, region, test):
@@ -341,6 +341,7 @@ class Config:
         )
         if new:
             bucket_obj.create()
+            test.s3_bucket = bucket_obj
         return bucket_obj

     @staticmethod

The previous changeset will fail if you set the config parameter s3_bucket to reuse a project bucket. In that case, the test.s3_bucket will have to be converted to a S3BucketObj object. Next changeset also handles that case.
diff --git a/taskcat/_config.py b/taskcat/_config.py
index bdcb0e5..5f48643 100644
--- a/taskcat/_config.py
+++ b/taskcat/_config.py
@@ -281,9 +281,11 @@ class Config:
         elif bucket_objects.get(region.account_id):
             name = bucket_objects[region.account_id].name
             auto_generated = bucket_objects[region.account_id].auto_generated
-        else:
+        elif isinstance(test.s3_bucket, str):
             name = test.s3_bucket
             auto_generated = False
+        else:
+            return test.s3_bucket
         bucket_region = self._get_bucket_region_for_partition(region.partition)
         bucket_obj = S3BucketObj(
             name=name,
@@ -299,6 +301,7 @@ class Config:
         )
         if new:
             bucket_obj.create()
+            test.s3_bucket = bucket_obj
         return bucket_obj

     def _create_regional_bucket_obj(self, bucket_objects, region, test):
@@ -341,6 +344,7 @@ class Config:
         )
         if new:
             bucket_obj.create()
+            test.s3_bucket = bucket_obj
         return bucket_obj

     @staticmethod

Cheers!

thanks for looking at this currently I use a pytest session fixture to empty and delete the bucket after I am done. So an easy enough workaround for now

@tjtaill The CLI taskcat test run uses CFNTest under the hood. I looked at how you created your config in get_config() and compared it to how CFNTest does it.
The difference is that you are not passing the build args.
args = _build_args(enable_sig_v2, regions, GLOBAL_ARGS.profile)
config = Config.create(
    project_root=project_root_path,
    project_config_path=input_file_path,
    args=args
    # TODO: detect if input file is taskcat config or CloudFormation template
)

I'm not sure what the build args do and why they make it so that auto bucket is not deleted but it might have something to do with setting default values.
Another way to do what you are doing is:
@pytest.fixture(scope='session')
def template_root()
    return Path(__file__).parent / "../.."

def test_firehose(template_root):

    input_file_path = template_root / ".taskcat.yml"

    test = CFNTest.from_file(project_root=template_root, input_file=input_file_path,regions='us-east-1')

    test.test_names = 'firehose'

    with test as stacks:
        bucket_name = find_output("BucketName", stacks)
        ...

I'm guessing the from_file wasn't documented well enough. It was here https://aws-quickstart.github.io/taskcat/apidocs/taskcat/ but it seems like it has been removed.
If you are not planning on using the taskcat CLI then you will probably find https://github.com/DontShaveTheYak/cloud-radar a better fit.
from pathlib import Path

from cloud_radar.cf.e2e import Stack

# Stack is a context manager that makes sure your stacks are deleted after testing.
template_path = Path("tests/templates/log_bucket/log_bucket.yaml")
params = {"BucketPrefix": "testing", "KeepBucket": "False"}
regions = ['us-west-2']

# template_path can be a string or a Path object.
# params can be optional if all your template params have default values
# regions can be optional, default region is 'us-east-1'
with Stack(template_path, params, regions) as stacks:
    # Stacks will be created and returned as a list in the stacks variable.

    for stack in stacks:
        # stack will be an instance of Taskcat's Stack class.
        # It has all the expected properties like parameters, outputs and resources

        print(f"Testing {stack.name}")
        ...

This is where the original CFNTest came from. It also has some other capabilities like unit testing (testing without deploying) but that feature is only partially implemented.


Windows Host - Agent not able to stay up result in host getting to "reconnecting" state a few minutes after it gets to "Active" state.

Rancher Version: Build from master - Dec 16 afternoon
library from rancher/rancher-catalog , branch - vnext
Steps to reproduce the problem:
Create Environment with windows template.
Add a Windows host.
Host gets to "Active" state and in a bit gets to"reconnecting" and "disconnected" state.
rancher-agent seems to crash , after it starts successfully.
When I try to stop and start the agent manually , I see the same behavior where the agent task disappears from the "Task Manager" list within sometime after it started.
PS C:\Users\Administrator> cd 'C:\ProgramData\rancher\'
PS C:\ProgramData\rancher> cat .\agent.log
time="2016-12-16T16:45:58-08:00" level=info msg="Launching agent"
time="2016-12-16T16:45:58-08:00" level=info msg="http://<IP_ADDRESS>:8080/v1D7ED80F8D13FEFC9E7ADUJAxT9qs
WCtC9kvTuKPjYvn4p"
time="2016-12-16T16:45:58-08:00" level=info msg="Listening for events on http://<IP_ADDRESS>:8080/v1"
time="2016-12-16T16:45:58-08:00" level=info msg="launching hostapi"
time="2016-12-16T16:45:58-08:00" level=info msg="Starting event router."
time="2016-12-16T16:45:58-08:00" level=info msg="Initializing event router" workerCount=50
time="2016-12-16T16:45:58-08:00" level=info msg="Connecting to proxy." url="ws://<IP_ADDRESS>:8080/v1/co
ken=eyJhbGciOiJSUzI1NiJ9.eyJleHAiOjE0ODE5MzU4NTgsInN1YiI6ImNhdHRsZSIsImlzcyI6Imh0dHA6XC9cL2NhdHRsZS5pbyIs
pZCI6ImI1ZDU0ZDI4LWMxNDQtNDViYy01Y2RmLTIxOGJmMGNiYjE1NiIsImlhdCI6MTQ4MTkzNTU1OCwia2lkIjoiZGVmYXVsdCJ9.n-j
MJsnzF1z8IxAmo0EUa_tp0LCtqbM-ipNccflZ3hzRZ5_KWoQoLONNrd51el6fBaEIjwma7_T972DQVrgfwamGPDYSOsG1RMMyfcBavqlT
LoX_OFz_SouGkHT88tLMVWrkVd9MN6bV9ErwlOwH1cyR7DNiZLvsryDRZ1oAgX2il1NvISI1WZBfh1kigdbtsHDeCroN-jkX12DECHZPR
kTzBbxCDvZpxyl_tJ1v_TiQ18j0QcinvT5hzK1qDcSZ8sF7F6NgKxtbu8RvZHhV1HNHlv1ediJoU0QN-AURA"
time="2016-12-16T16:45:58-08:00" level=info msg="Connection established"
time="2016-12-16T16:45:58-08:00" level=info msg="Starting websocket pings"
time="2016-12-16T16:46:01-08:00" level=error msg="Error getting local storage usage: The system cannot fi
cified."
PS C:\ProgramData\rancher>

This issue was seen because of 2  local windows Vms in my "VMware Fusion" setup ended up having the same bridged ip.


[request] Amplify codegen or Amplify push should ask if codegen should be in TypeScript

Describe the bug
when i run amplify push or amplify codegen, amplify cli generates javascript by default. there is no prompt to generate typescript, unless i run amplify codegen configure and then rerun amplify codegen. this makes typescript seem like a second class citizen.
Amplify CLI Version
4.27

@sw-yx upon the first time amplify push we actually ask whether you want to configure typescript or not. Are you suggesting to asking this on every amplify push?

ah i think the problem here is that i have aliased my CLI to use amplify push --y by default. it makes sense that -y would also pick javascript as the default. sorry for false alarm


Unify TeX files before compiling them

For sentence extraction, definition detection, and for building ordered lists of entities in papers (e.g., answering questions like 'which symbols come before other symbols) it would be useful to unify all the TeX files in a TeX project into a single file before processing it.
On a test of a single paper, I have found that the latexpand included in TeXLive can be used to inline the \input and \include commands. Seems like this tool is worth evaluating as a candidate for combining TeX files.

cc @kyleclo @dykang

The following script can be used to fetch a list of PDFs from arXiv for the purposes of performing a regression test to see whether the unified TeX files compile to have the same appearance.
for arxiv_id in $(cat arxiv_ids.txt | sed -e 's/\s*#.*$//')
do
  wget \
    https://arxiv.org/pdf/$arxiv_id.pdf \
    -O pdfs/$arxiv_id.pdf \
    --user-agent 'Andrew Head, for academic research on dissemination of scientific insight<EMAIL_ADDRESS>  sleep 10
done

This module will need to know which TeX file in a project is the main one. The way that arXiv currently does this is:

AutoTeX calls the FileGuess utility on each file https://metacpan.org/pod/arXiv::FileGuess
Files that look like main files (e.g., that include \documentclass) are attempted first

Also see:

https://arxiv.org/help/faq/mistakes#wrongtex
https://arxiv.org/help/submit_tex#submissions-are-automatically-processed

How to unify

Run compile-tex; scan the log output for what file was eventually compiled (include this in compilation results)
Run latexpand <compiled-filename> --verbose
Scan the output for names of files that were input. Check that they are in the sources directory. Delete them.

Then we need to make sure:

sentence extractor only scans the main files that were compiled

An additional command was added for unifying TeX files, as has been incorporated as of 5a7f8f6.


Interlocked tests

Added integration tests for the interlocked module
Added unit tests for the Windows implementation of the interlocked module
Added the Windows implementation of the interlocked module

#endif

isn't this header missing functions?
where  is interlocked_add_64? Just asking for a friend.

Refers to: inc/azure_c_util/interlocked.h:58 in 6a604e4. [](commit_id = 6a604e42b324f9dd0f03955cee77e1281451a409, deletion_comment = False)

Looks pretty good to me, I'd like to have a look after the comments are applied!

#endif

Do you mean this one? https://docs.microsoft.com/en-us/windows/win32/api/winnt/nf-winnt-_inlineinterlockedadd64

In reply to: 631237098 [](ancestors = 631237098)

Refers to: inc/azure_c_util/interlocked.h:58 in 6a604e4. [](commit_id = 6a604e42b324f9dd0f03955cee77e1281451a409, deletion_comment = False)

#endif

Weird, MSDN doc's link to that Inline named one, but the actaul win32 header shows InterlockedAdd64 does in fact exist:
winnt.h line 2916
#define InterlockedAdd64 _InlineInterlockedAdd64
Looks like an MSDN bug, might be nice to have all of the InterlockedAddN functions in our PAL

In reply to: 632160751 [](ancestors = 632160751,631237098)

Refers to: inc/azure_c_util/interlocked.h:58 in 6a604e4. [](commit_id = 6a604e42b324f9dd0f03955cee77e1281451a409, deletion_comment = False)

MOCKABLE_FUNCTION(, int32_t, interlocked_add, volatile int32_t*, addend, int32_t, value);

Since InterlockedAdd64 exists, it would be really nice to include it as well, as Andrie said. Ok to make a separate task to add it in.

Refers to: inc/azure_c_util/interlocked.h:23 in 918c9b4. [](commit_id = 918c9b4f100a8650b5443dcba46eeddde1a39634, deletion_comment = False)


I am getting no implementation found error

Hi Sir,
I am getting below error when I had integrated the facebook login in my app please help me
MissingPluginException(No implementation found for method loginWithReadPermissions on channel com.roughike/flutter_facebook_login)
  Future<Null> _login() async {
    final FacebookLoginResult result =
        await facebookSignIn.logInWithReadPermissions(['email']);

    switch (result.status) {
      case FacebookLoginStatus.loggedIn:
        final FacebookAccessToken accessToken = result.accessToken;
        print(accessToken.token);
        break;
      case FacebookLoginStatus.cancelledByUser:
        print('Login cancelled by the user.');
        break;
      case FacebookLoginStatus.error:
        print(result.errorMessage);
        break;
    }
  }

Me too :(

I restart the app an Work :)

@roughike Still not working.
Error:
MissingPluginException(No implementation found for method loginWithReadPermissions on channel com.roughike/flutter_facebook_login)

Having the same issue when doing
var loginResult = await _facebookLogin.logInWithReadPermissions(['email', 'public_profile']);
Cold-restarting the app does not solve the issue. Neither does uninstalling, cleaning and re-installing the app.

@roughike its working on android device but on iOS it's not working.Error:
MissingPluginException(No implementation found for method loginWithReadPermissions on channel com.roughike/flutter_facebook_login)

Any update on this? I also encountered this problem, tried restarting the app, different versions of the library & plugin, flutter clean, remove all the pub cache & podfile.lock, nothing works

I've deleted the app on the simulator and iphone, cleared build, deleted pod folder and it worked.

Any updates on this? I'm getting the same issue

I'm getting this error too if I put the facebook id and stuff in build.gradle's manifestPlaceholders instead of strings.xml

No implementation found for method logIn on channel com.roughike/flutter_facebook_login

No implementation found for method logIn on channel com.roughike/flutter_facebook_login

No implementation found for method logIn on channel com.roughike/flutter_facebook_login

Just quit everything and rebuild. It works

me too

MissingPluginException(No implementation found for method logIn on channel com.roughike/flutter_facebook_login

This issue is closed but not solved at all:
MissingPluginException(No implementation found for method logIn on channel flutter_login_facebook

This issue is closed but not solved at all:
MissingPluginException(No implementation found for method logIn on channel flutter_login_facebook

Quit your app, and rebuild, if you want do a flutter clean, cold boot etc, it should works!

This issue still coming, I restarted Android Studio, Upgrade the Flutter, Clean it , uninstall the app, Clear caches. Did Everything but still same issue coming
Unhandled Exception: MissingPluginException(No implementation found for method logIn on channel com.roughike/flutter_facebook_login)

Hi @Yogi09,
I had similar issue than you. What worked for me is to make sure that the strings.xml was correctly formatted with the AppId. Follow this tutorial accurately and you will get it to work: How to integrate Flutter Facebook Authentication

@NizarBsb  I followed this tutorial and also  after replacing my account FBAppID and protocol id copied same strings.xml file in the android, but still it is same. :(

same issue

I solved it using

flutter clean
flutter pub cache repair
and creating a new mobile emulator

I solved it using

flutter clean
flutter pub cache repair
and creating a new mobile emulator

Please anyone solve this issue, getting the same error with shared preferences also, tried all rebooting, cleaning,rebuilding

Please anyone solve this issue, getting the same error with shared preferences also, tried all rebooting, cleaning,rebuilding

@satyamraj123 , for sharedPreferences you can easily solve that issue by adding the following code before you use sharedPreferences.
SharedPreferences.setMockInitialValues(<String, dynamic>{});

same issue

Unhandled Exception: MissingPluginException(No implementation found for method logIn on channel com.roughike/flutter_facebook_login)

same issue, have anyone find any workaround for this problem.

Still have this issue on ios but not on android on android everything runs as expected but not for ios i did flutter clean flutter pub cache repair pod deintegrate i've probably did everything mentioned but nothing was successful

this is 2 years old issue, I am still getting it. I did flutter clean flutter pub cache repair and everything else mentioned here and now I am facing existential crisis 😭

i still have this problem and its like it won't be solved

So i have solved this like below :
I have made a new project where i have copied the sample from the docs of the plugin of pub.dev had run the project everything went well then got back to the app where i had this issue in and it has dispersed like nothing happened hope this helps.
Good luck to everyone.

I solved my issue by doing the configuration. https://facebook.meedu.app/#/android checkout the documentation for the full configuration details. Please flutter clean before starting the app.

No implementation found for method logIn on channel com.roughike/flutter_facebook_login

I faced a similar problem with another library.
after spending lot's of time, I noticed inside
ios>Runner>GeneratedPluginRegistrant.m file, my plugin couldnot register it's channel.
so I add it manually to the file and it work.

to know exactly what names you need to choose for import look for library files

for other libraries it should be the same process.


Support macOS Mojave dark mode

Description
Electron 4.0 adds support for Mojave dark mode: https://github.com/electron/electron/issues/13387. Can nativefier support this as well? Currently the window title bar is "light" grey even if the dark theme is selected on macOS.
Steps to reproduce issue
Run nativefier on any website on macOS Mojave. With dark system theme selected, nativefier should then adapt the window title bar to be dark as well.
Details

Are you nativefying a public website? Yes
Feature request? Have you looked at nativefier --help to see if an existing option could fit your needs? Yes

Would be cool.
Depends on #727 - Review and adapt to electron 4.0 breaking changes.

I would pay for this feature. Keep up the greet work @ronjouch. I look forward to future updates!

Closing as fixed since https://github.com/jiahaog/nativefier/commit/54335699218ac79e75a13c314cf48ff25fee1a80 .


Allow to manage sauce tunnel

This PR allows

launch up sauce tunnel for each test run and close it eventually after the run
use existing sauce tunnel for every test
validate tunnel config

Codecov Report

Merging #4 into master will increase coverage by 5.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   84.73%   89.76%   +5.03%
==========================================
  Files           5        6       +1
  Lines         249      391     +142
  Branches       46       77      +31
==========================================
+ Hits          211      351     +140
- Misses         38       40       +2

Impacted Files
Coverage Δ

lib/settings.js
100% <0%> (ø)
:arrow_up:

lib/tunnel.js
97.46% <0%> (ø)

lib/profile.js
90.66% <0%> (+0.25%)
:arrow_up:

lib/configuration.js
98.64% <0%> (+0.57%)
:arrow_up:

lib/executor.js
71.26% <0%> (+18.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45e26c...3d2a632. Read the comment docs.


Move vSphere CAPI yaml template to separate file

Description of changes:
No logical changes. Just to make it easier to navigate this code.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/test eks-anywhere-presubmit

Merging manually since this is just moving code to a different file and coverage is failing.


Newbies - QnA section

Link to Figma

Please see the implementation of QnA in Maintainers page

please assign me (:


[WIP] In-progress and pending distinction

Pull Request Test Coverage Report for Build 1188

32 of 50 (64.0%)  changed or added relevant lines in 4 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.05%) to 82.302%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Router/Router.ts
4
8
50.0%

src/Actions/Actions.ts
26
40
65.0%

Files with Coverage Reduction
New Missed Lines
%

src/Router/Router.ts
1
81.1%

src/Actions/Actions.ts
4
51.26%

Totals

Change from base Build 1182:
-1.05%

Covered Lines:
567

Relevant Lines:
652

💛  - Coveralls


SEPG Automated Release - v3.2.0

SEPG Details
Release Build Link: https://sou-jenkins2.swinfra.net/job/Auto-Release/651/
Build Token: github.com/CAFapi/buildenv-dotnet-image/master/803d2729d063eec28758a2c7b722e658f63bbf15
Versioning Behaviour: Roll on to next minor
Artifacts For Release
Docker

cafapi/buildenv-dotnet:3.2.0 (Static Tag)
cafapi/buildenv-dotnet:3.2 (Dynamic Tag)
cafapi/buildenv-dotnet:3 (Dynamic Tag)
cafapi/buildenv-dotnet:latest (Dynamic Tag)

 Build Stage
Action
Status

Release Checks
completed
:heavy_check_mark:

Gather Release Data

:white_small_square:

QA Documentation Site Deployment

:white_small_square:

QA Deployment Branch Promotion

:white_small_square:

Docker Image Promotion

:white_small_square:

Maven Artifact Promotion (Closed Source)

:white_small_square:

NuGet Artifact Promotion

:white_small_square:

Artifactory Release Artifact Tagging

:white_small_square:

Generic Artifact Promotion

:white_small_square:

Maven Artifact Promotion (Open Source)

:white_small_square:

Maven Staging Repository Removal (Open Source)

:white_small_square:

Git Tagging

:white_small_square:

Git Release

:white_small_square:

Git Release Asset Deployment

:white_small_square:

Pull Request Merge

:white_small_square:

Release Branch Deletion

:white_small_square:

view the build log here


Dynamic GUIWindow creation

currently to create a GUIWindow you need to specify starting X/Y position and width/height like so...
var window1 = GUIWindow.Begin("window1's title", 10, 10, 200, 400);

make a dynamic positioning to be able to create a window with only title parameter like so...
var window1 = GUIWindow.Begin("window1's title");

support multiple windows that don't cover each other

position is solved in commit 02e5523
dynamic width/height needs to be responding to controls in runtime

dynamic starting size will not be worked on for now
open new issue if requested

added in e853998


Accuracy metric failing for Spark 1.6.0

The accuracy metric in ml_classification_eval fails for Spark 1.6.0 but works for Spark 2.0.0. The accuracy metric does appear to be supported in Spark 1.6.0 see here. Note that other metrics appear unaffected, like f1, which works for both versions of Spark. Example below.
library(sparklyr)
library(dplyr)

sc <- spark_connect(master = "local", version = "1.6.0") # works for 2.0.0
titanic <- data.frame(Titanic, stringsAsFactors = FALSE)
titanic_tbl <- copy_to(sc, titanic, overwrite = TRUE)
ml_fit <- ml_logistic_regression(titanic_tbl, Survived ~ .)
ml_pred <- sdf_predict(ml_fit, titanic_tbl)
ml_pred <- mutate(ml_pred, actual = ifelse(Survived == "No", 1L, 0L))
ml_classification_eval(ml_pred, "actual", "prediction", "accuracy") # works for "f1"

Error: java.lang.IllegalArgumentException: mcEval_79c684d5ddb1 parameter metricName given invalid value accuracy.
    at org.apache.spark.ml.param.Param.validate(params.scala:76)
    at org.apache.spark.ml.param.ParamPair.<init>(params.scala:509)
    at org.apache.spark.ml.param.Param.$minus$greater(params.scala:85)
    at org.apache.spark.ml.param.Params$class.set(params.scala:604)
    at org.apache.spark.ml.evaluation.Evaluator.set(Evaluator.scala:30)
    at org.apache.spark.ml.evaluation.MulticlassClassificationEvaluator.setMetricName(MulticlassClassificationEvaluator.scala:59)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at sparklyr.Handler.handleMethodCall(handler.scala:118)
    at sparklyr.Handler.channelRead0(handler.scala:63)
    at sparklyr.Handler.channelRea

@javierluraschi The issue is some metrics are support in 2.0.0 that are not supported in 1.6.
For Multiclass Evaluators:
1.6 - supports "f1" (default), "precision", "recall", "weightedPrecision", "weightedRecall"
2.0 - supports "f1" (default), "weightedPrecision", "weightedRecall", "accuracy"
For Binary Classification Evaluator:
1.6 - "areaUnderROC" (default), "areaUnderPR"
2.0 -  areaUnderROC
https://spark.apache.org/docs/**1.6.0**/api/scala/index.html#org.apache.spark.ml.evaluation.MulticlassClassificationEvaluator  (replace with 2.0.0 to see the change)
https://spark.apache.org/docs/**2.0.0**/api/scala/index.html#org.apache.spark.ml.evaluation.BinaryClassificationEvaluator
We could add a check in R ... but that would mean updating that check for every version :/ I'm not sure what approach we've taken with the other ml functions. In this case, I'd argue that the error message is pretty clear, but I also agree that it is hard to find what options are supported.
Side note: I didn't implement the regression evaluator, but that would be a nice-to-have that would round out these functions.

I believe the change we want here is to improve error messages to be more descriptive as to what is supported in which versions.

Fixed with https://github.com/rstudio/sparklyr/pull/950


Unified all graphql typedef into shared package call @zkdb/common

Move all the graphql typedef code into a shared package for DRY
Consistent between all packages that using graphql

Affected package api, serverless, zkdb, for now just skip for collection, database, permission


Throw actual Error objects instead of strings in File System module

This would probably break current user scripts though.

I think we would take patches that brought our fs module closer to node's fs module, even if that risked breaking some user scripts.  We have a lot of other stuff on our plate, though, so we're probably not going to work on this ourselves anytime soon.


fix lack of paranthesis in alexnet_insights.ipynb

Hi, I found in jupyter notebook code ( jupyter/alexnet_insights.ipynb  ), and I fixed it.

Thanks!


decouple the path to the SDSS data from the path to the bliss config files

Currently the SDSS data has to be stored in "$BLISS_HOME/data/sdss". It'd be preferable, I think, to have an environment variable called something like BLSS_SDSS that references the directory where SDSS data is staged. That way the data wouldn't have to be stored under "$BLISS_HOME". (It's also possible there's a good way to do this with hydra config files, but the setting would need to be machine specific, so I'm not sure.)
On the GPU server we have a lot more space on the /data partition than in our /home directories. I've created a directory called /data/sdss, added us all to a Linux user group called "bliss", and given the "bliss" group read/write access to that directory. The first use of this new environment variable could be to reference this new directory once the SDSS data has been moved there.

@dereklhansen Is the a way hydra can store the location of the SDSS dataset too? Seems like it might be nice not to mix environment variables and hyrda config variables if possible. The thing is, the location of the SDSS dataset can be different on different computers -- traditionally something env variables would be used for

@dereklhansen Is the a way hydra can store the location of the SDSS dataset too? Seems like it might be nice not to mix environment variables and hyrda config variables if possible. The thing is, the location of the SDSS dataset can be different on different computers -- traditionally something env variables would be used for

Since this is something meant to be hardcoded to one place, we can just put it here:
https://github.com/prob-ml/bliss/blob/7654eb9734efaa2e798cd5877a09ecaaae22a35f/config/config.yaml#L19-L21

Since this is something meant to be hardcoded to one place, we can just put it here:
https://github.com/prob-ml/bliss/blob/7654eb9734efaa2e798cd5877a09ecaaae22a35f/config/config.yaml#L19-L21

Nice

Nice


Himanshu1221 patch 1

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

delete the data/himanshu1221 without the .json one

done !

@himanshu1221 Still the data/himanshu1221 without the .json file is there. Please remove it.

delete the data/himanshu1221 without the .json one

done !

@himanshu1221 Still the data/himanshu1221 without the .json file is there. Please remove it.

removed it maam yo can check it


Automated Package Upgrade

:tada: This PR is included in version 25.3.230 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


support a context dir for imported projects

for cases where folks are not using a microservices approach but have multiple apps they want to release separately from the same git repo that exist in separate folders

this right now happens for custom java projects/wars created via the fabric8 console


Twtxt2rss converts twtxt feeds into RSS feeds and enables people to follow twtxt feeds without a dedicated client.

coverage: 59.89%. remained the same
when pulling 22052c89d2e8358a0dfaaa5db7193c665b895e40 on cicxjo:feature/twtxt
into 8306bc77e8f6c61ab59991a8aa86dd1e8d6b61a2 on newsboat:master.


Don't remove fingerprint on server errors?

Hi,
in upload.js#L314 we trigger a Storage.removeItem(this._fingerprint); even on server errors (statusCode >= 500).
But probably there's only a short service outage and it could be resumed after the backend is up again.
I think we should only remove the stored fingerprint on client errors (< 500). What do you think?

I think we should only remove the stored fingerprint on client errors (< 500). What do you think?

Good idea, would you mind opening a PR for this?

So many PR's, so less time :
I'll see what I can do

Unfortunately the same applies to me or else I would have already taken care of it :) If you need any help, I can provide assistance, of course!


Feature request: support float weights for histograms

Originally opened in hist as https://github.com/scikit-hep/hist/issues/493.
Being able to use floats as weights is convenient, but currently not supported.
import boost_histogram as bh
import dask.array as da
import dask_histogram as dh

x = da.random.uniform(size=(1000,), chunks=(250,))
ref = bh.Histogram(bh.axis.Regular(10, 0, 1), storage=bh.storage.Weight())
h = dh.factory(x, weights=0.5, histref=ref)  # AttributeError: 'float' object has no attribute 'ndim'

Thanks! This was really fast.

low hanging fruit :)


Clarification on how to use this?

Great work with alot of potential, but we need clarification on how to use it.

After you have trained a model, how do you then change the audio so you can do a new rendering on that audio instead of the one used for training?

How do you create this as an output video with the rendered images and the audio?

I have trained a model on my own video clip now, but don't now what to do with it.

+1

I appreciate your work，and i want to know how to make a new video with a new audio and trained model

me too

+1

+1 @sstzal

Refer to https://github.com/sstzal/DFRF/issues/10


Test MPI stray processes for Slurm

MPI job is known to leave stray processes after job termination if slurm process tracking is not setup correctly
Add test cases for this bug

Signed-off-by: Rex<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1696 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1696   +/-   ##
========================================
  Coverage    52.61%   52.61%
========================================
  Files           24       24
  Lines         3959     3959
========================================
  Hits          2083     2083
  Misses        1876     1876

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6113150...9c9f785. Read the comment docs.