Blind copies are not sent by sendmail transport

Laravel Version: 9.3.1
PHP Version: 8.0.14
Database Driver & Version: N/A

Description:
Using a mail controller like this:
class SendmailController extends Controller
{
	public function post_sendmail(Request $request)
	{
		$email = new Sendmail($request->subject, $request->msg);

		Mail::to($request->to)
			->bcc($request->bcc)
			->send($email);

		return "Email sent";
	}
}

If MAIL_MAILER=smtp in the .env file, and a suitable SMTP server is configured, the blind copy is sent, but when MAIL_MAILER=sendmail it isn't.
Steps To Reproduce:

Extract the sendmail app from the attached archive to a linux system with a sendmail binary.
cd sendmail
composer update
cd public
php -S <IP_ADDRESS>:8080
In a web browser, browse to http://<IP_ADDRESS>:8080/
Complete the fields in the form.
Click Send.

sendmail.tar.gz

Take a look

I didn't do a direct comparison of both 8.x and 9.x with the same user code, but I believe the previous mailer likely emitted the Bcc: headers as part of the $message->toString() and then they got picked up by anything which was using the raw message. I did definitely see they weren't there as part of the output when stepping through with the debugger. I don't know if that's required, optional behavior for these mailers or just was a happy coincidence.
My PR in #41362 helps stay within AWS SES' rules of a 50 recipient limit and at the same time breaks reliance on that circumstance/behavior.

@driesvints I do not believe my PR will resolve this issue.

I can confirm that this worked with earlier versions of Laravel that used Swift Mailer.

Heya, thanks for reporting.
We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as separate commits on the main/master branch and share the repository here? Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.
laravel new bug-report --github="--public"

Please do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.
Thanks!

@driesvints I'm not familiar with the process you asked me to undertake, but I've done my best and shared the repository with you.  Please let me know if I've missed anything.

I took a deeper look into this and found https://github.com/symfony/symfony/issues/40070 & https://github.com/symfony/symfony/pull/39744.
It seems this is related to the usage of -t which is the default in Laravel: https://github.com/laravel/laravel/blob/93395a3468b7827bae2117de7543eddd5eb4a4e5/config/mail.php#L61.
Try changing /usr/sbin/sendmail -t -i to /usr/sbin/sendmail -bs -i to see if it works?

Good call! That fixes it.  Thanks for your help.

Cool, I sent a PR to change the default: https://github.com/laravel/laravel/pull/5836


add note for not working AWS redis

as discussed in slack, aws redis is not working (2020-12-08).
Let us prevent other from being frustrated.
In case you know a better place to high-lite this, please let me know.

For others it's working fine out of the box: https://owasp.slack.com/archives/C2P5BA8MN/p1607496169370700?thread_ts=1607441990.368500&cid=C2P5BA8MN
Besides that, we cannot maintain a list of "things defect dojo doesn't work with".
We will look at making / keeping redis working out of the box. If people use any specific serverless solution, it's out of our control.

thanks


refactor: add support of constants for some fields

closes #1772

I'm not sure about this one... I do like things to be typed, but I think this might be a bit too much to add and maintain if we are going this route for the whole package (which we should in order to keep things consistent) 🤔

Agreed. But we have to start somewhere. I will keep this open for another week. If you think, it would be too much maintenance by then too, we can close it

Yeah fine to keep it open for a while as I currently have very little headroom (and time) for doing project maintenance and/or to think about this one (I co-founded a company last year and things are picking up a little)...

Closing this as too much efforts for maintenance

Sorry for being a little less response lately... But I guess this is best for now 👍🏻


Add newer versions to modrinth

1.19.4 is still the newest version on modrinth. Versions for 1.20 and 1.21 are only on curseforge.

still behind but now it is.
modrinth: 1.20
and
curseforge 1.21.1


Local development - WARN exited: octane_00 (exit status 139; not expected)

I performed the following steps to set up my Laravel project with Docker:

Created a new Laravel project.
Navigated to the newly created Laravel project directory and installed Laravel Octane.
After installing Octane, cloned directory contents, including the deployment directory, Dockerfile, and .dockerignore, into the Laravel project directory.
In the Laravel project directory, ran the following commands:

docker build -t octane-test1:latest -f FrankenPHP.Dockerfile .
docker run -p 80:8000 --rm octane-test1:latest
I encountered the following errors (as shown in the screenshot below):

Could someone assist with troubleshooting this issue? Thank you.

Hi @iamvincentong  are you running it on Mac arm64 / v8 or similar ?

Yes running on Mac M3 Max arm64.

I'm running the same problem on a Mac arm64 of my customer with a tested application that run perfectly on Windows and Linux.
Actually I'm unable to test it because I don't have a mac to test it, but seems there's an incompatibility based on arm platform (?!)

First, these Dockerfiles are intended for production, not development. Second, this is an upstream issue. You can follow it in dunglas/frankenphp.

@smortexa, if I read the issue on frankenphp its related to mlocati.


Incorrect error message while incompatible package is added

Trivial fix to the error message dialog.

Hi @abchatra, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Brahma Giri Abhijith Chatra). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


The icons is too small

Uhm is there anyway to customize the size of the icon and like apply more style to the ThemeToggler. Thanks

Edit: It would be better if this is a headless component so users can easily style their own theme toggler (I downloaded the component myself so it would be easier to edit). Anyways, thanks for creating a great packages (I have struggled for days with the theme toggler XD)

I'll look at making it more headless


Climate Functions

There are not all the functions of the App

Product manufacturers may not define standard instruction sets.

My air conditioners also have various functions in the app, such as fan speed, deflector direction, etc

If you have the time and the patience to work with the Tuya IoT platform and HA configurations, you might follow a way similar to the one I used for creating your own climate devices with all the functionalities you need:
See:
https://github.com/tuya/tuya-smart-life/issues/34#issuecomment-1925722994


Get Started with  SAP Cloud  Platform Business Rules

Mission URL: https://developers.sap.com/mission.cp-rules-get-started.html
Tutorials are not visible

Fixed. Please try again. If OK, please close the ticket. Thanks for letting us know.

Thanks. I can see tutorials now.


[EPIC] Devcontainer Tracking Issue

This issue is tracking all of the various updates to the Morpheus Devcontainer that are planned out. These will be completed in stages as outlined by the top level issues.
### Tasks
- [ ] https://github.com/nv-morpheus/Morpheus/issues/702
- [ ] https://github.com/nv-morpheus/Morpheus/issues/703
- [ ] https://github.com/nv-morpheus/Morpheus/issues/704
- [ ] https://github.com/nv-morpheus/Morpheus/issues/705
- [ ] https://github.com/nv-morpheus/Morpheus/issues/706

Moving the tracking issue to 23.07.

Moving tracking issue to next release


Adding support for Xcode 9/Swift 4

Will merge once Xcode 9 is out of Beta. For now anyone can use xcode-9-swift-4 branch for testing.

@ankurp It's out of beta :)

This is released under tag 7.0.0 and published on Cocopods with same version. https://cocoapods.org/pods/Dollar

Why do we need to add backticks around the $ now? @ankurp

Swift 4 doesn't support $ as an identifier now. So you need to have a back tick.


Next Steps Tutorial

This PR implements the Next Steps section of the tutorials.

@garrettmflynn Looks like doc build is failing here

Hmm I'd found a few header mismatches. But I'm not sure what the persistent issue is coming from...

Hmm I'd found a few header mismatches. But I'm not sure what the persistent issue is coming from...

Is it able to build successfully locally?

Yes though I'm using sphinx-build -b html docs/ _build/html/ and commenting out from conf_extlinks import extlinks, intersphinx_mapping in conf.py.
This method doesn't seem to care about things that RTD does—so I'm assuming this isn't really the correct way to test locally.
Can you confirm?

and commenting out from conf_extlinks import extlinks, intersphinx_mapping in conf.py.

You shouldn't have to comment out anything

I have not been able to get around the following error:
  File "/Users/garrettflynn/Documents/GitHub/nwb-guide/docs/conf.py", line 5, in <module>
    from conf_extlinks import extlinks, intersphinx_mapping
ModuleNotFoundError: No module named 'conf_extlinks'

Any suggestions would be appreciated. I seem to be following all available similar documentation appropriately.

Is your pwd inside the docs? Or +/- directory above/below somewhere

I'm running the command from the base of the repository. Running from docs didn't change anything.
Is that the same as the pwd?

Did you  install all the requirements in https://github.com/NeurodataWithoutBorders/nwb-guide/blob/main/docs/requirements-rtd.txt?

Yep no luck. Always the same resolution error for conf_extlinks


Refactoring the Ciphertext/Plaintext/Evaluator design

This is a refactoring of the further modularizing the Ciphertext/Plaintext/Evaluator structures.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Refining language around preview and moving location of Notes

Docs Build status updates of commit 1ab9e69:
:clock10: Full build: the average full build time is 12 min(s) 31 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1ab9e69:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md
:x:Error

Details

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.md
:x:Error

Details

teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md
:x:Error

Details

teams/teams-ps/teams/New-CsGroupPolicyAssignment.md
:x:Error

Details

teams/teams-ps/teams/Remove-CsGroupPolicyAssignment.md
:x:Error

Details

teams/teams-ps/teams/Set-CsGroupPolicyAssignment.md
:x:Error

Details

teams/teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md

[Error]

Unable to load file 'teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently in public pr...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.md

[Error]

Unable to load file 'teams-ps/teams/Get-CsGroupPolicyAssignment.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently only availab...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md

[Error]

Unable to load file 'teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently in public pr...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/New-CsGroupPolicyAssignment.md

[Error]

Unable to load file 'teams-ps/teams/New-CsGroupPolicyAssignment.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently only availab...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/Remove-CsGroupPolicyAssignment.md

[Error]

Unable to load file 'teams-ps/teams/Remove-CsGroupPolicyAssignment.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently only availab...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/Set-CsGroupPolicyAssignment.md

[Error]

Unable to load file 'teams-ps/teams/Set-CsGroupPolicyAssignment.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently only availab...'
 Expect Heading, please use PlatyPS to do content validation

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d698e1e:
:clock10: Full build: the average full build time is 12 min(s) 31 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit d698e1e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md
:x:Error

Details

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.md
:x:Error

Details

teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md
:x:Error

Details

teams/teams-ps/teams/New-CsGroupPolicyAssignment.md
:x:Error

Details

teams/teams-ps/teams/Set-CsGroupPolicyAssignment.md
:x:Error

Details

teams/teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md

[Error]

Unable to load file 'teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently in public pr...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.md

[Error]

Unable to load file 'teams-ps/teams/Get-CsGroupPolicyAssignment.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently only availab...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md

[Error]

Unable to load file 'teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently in public pr...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/New-CsGroupPolicyAssignment.md

[Error]

Unable to load file 'teams-ps/teams/New-CsGroupPolicyAssignment.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently only availab...'
 Expect Heading, please use PlatyPS to do content validation

teams/teams-ps/teams/Set-CsGroupPolicyAssignment.md

[Error]

Unable to load file 'teams-ps/teams/Set-CsGroupPolicyAssignment.md' via processor 'AzureCliDocumentProcessor': Failed to parse this MAML markdown file due to :2:(0) '> [!Note]
> This cmdlet is currently only availab...'
 Expect Heading, please use PlatyPS to do content validation

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6d47d7c:
:clock10: Full build: the average full build time is 12 min(s) 31 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 6d47d7c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsUserPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add readmes for examples

Thanks @willingc, I made some updates.

@blink1073 Looks good. JupyterLab is looking good too. Brian, Cameron, and I enjoyed playing around with it yesterday.

High fives all around!


Issue 84 normalization serial interval bug

Fixes the bug with the use of unnormalised serial intervals as stated in issue #84.

Thank you for your fast fix @I-Bouros :smile:
It seems to be working for me, but let's get #83 merged first

Thank you for your fast fix @I-Bouros :smile:
It seems to be working for me, but let's get #83 merged first


ContractCallTx: delay in showing details

I just performed following tx:

https://testnet.aescan.io/transactions/th_BydyNtqy5xKq3iYou1LfxTLxpN5hednLweta5xpayfhpVWgG9

although the middleware already delivered the missing information in the endpoint, the UI didn't serve the data. I am wondering about the logic on that page.
is the UI currently waiting for 1 confirmation before the actual details will be shown? to me it would be more a bug, but can also be seen as improvement 😁

This will be solved by #466.


Angular-cli should provide fully configured webpack (upon ejecting app)

Bug Report or Feature Request (mark with an x)
- [x] Better configured webpack for ejected angular app(s).

Versions.
@angular/cli: 1.4.2
node: 6.11.0
os: win32 x64
Desired functionality.
Angular now have started to manage its bundling via webpack. Upon Ejecting the project, Angular-Cli automatically configures the application to use webpack. However, the app is not fully configured.
The Script files that are generated upon building the app is not minified. Images and Icons are not automatically copied into the dist folder.
If the Cli will do all this upon ejecting the app, it will be great convenient for user.
(Optional Functionality) =>  When All configurations for webpack has been developed for cli, the new apps that will be generated via ng new may be made pre-ejected (no need to eject it manually).
Mention any other details that might be useful.
In The Angular Webpack guide page, The Sample Application provided by Angular Officials is much better. It minifies the script files, copies images (and many things i don't yet understand).

When you use ng eject, you can also pass in the same options you pass into ng build. This will make a webpack configuration for the flags you used. For a production build webpack config, use ng eject --prod.


Search improvements

Ignore hidden files
Allow search to match file names also
Fix case sensitivity bug

Codecov Report

Merging #1 (73692df) into main (1fa1045) will increase coverage by 0.30%.
The diff coverage is 100.00%.

:exclamation: Current head 73692df differs from pull request most recent head dd4304f. Consider uploading reports for the commit dd4304f to get more accurate results

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
+ Coverage   92.00%   92.30%   +0.30%
==========================================
  Files           1        1
  Lines          25       26       +1
  Branches        5        5
==========================================
+ Hits           23       24       +1
  Misses          2        2

Impacted Files
Coverage Δ

src/index.ts
92.30% <100.00%> (+0.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa1045...dd4304f. Read the comment docs.


Failed to install on Raspberry Pi Zero W

I tried installing on the latest Raspbian.  I have already installed all the dependencies (pip3 install python3-xlib,scrot, python3-tk,python3-dev
The following is the error message:
sudo pip3 install pyautogui
Downloading/unpacking pyautogui
Downloading PyAutoGUI-0.9.36.tar.gz (46kB): 46kB downloaded
Running setup.py (path:/tmp/pip-build-okg4qt6s/pyautogui/setup.py) egg_info for package pyautogui
Traceback (most recent call last):
File "", line 17, in
File "/tmp/pip-build-okg4qt6s/pyautogui/setup.py", line 6, in
version=import('pyautogui').version,
File "/tmp/pip-build-okg4qt6s/pyautogui/pyautogui/init.py", line 115, in
from . import _pyautogui_x11 as platformModule
File "/tmp/pip-build-okg4qt6s/pyautogui/pyautogui/_pyautogui_x11.py", line 160, in
_display = Display(os.environ['DISPLAY'])
File "/usr/lib/python3.4/os.py", line 633, in getitem
raise KeyError(key) from None
KeyError: 'DISPLAY'
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 17, in
File "/tmp/pip-build-okg4qt6s/pyautogui/setup.py", line 6, in
version=__import__('pyautogui').__version__,

File "/tmp/pip-build-okg4qt6s/pyautogui/pyautogui/init.py", line 115, in
from . import _pyautogui_x11 as platformModule

File "/tmp/pip-build-okg4qt6s/pyautogui/pyautogui/_pyautogui_x11.py", line 160, in
_display = Display(os.environ['DISPLAY'])

File "/usr/lib/python3.4/os.py", line 633, in getitem
raise KeyError(key) from None

KeyError: 'DISPLAY'

Cleaning up...
Command python setup.py egg_info failed with error code 1 in /tmp/pip-build-okg4qt6s/pyautogui
Storing debug log for failure in /root/.pip/pip.log

This is telling you that $DISPLAY isn't present in your environment. It appears that pyautogui needs X to be running and accessible during install as well as at runtime. This isn't a bug imo.

For what it's worth, PyAutoGUI does seem to work on my raspberry pi virtual machine.


Doubt about frame-based

Hello, I am having an error when using the z_Convert Format: "clip must be frame-based". I tried to solve it in the ways I know, but it didn't work. Here is the script I am using:
##src
DGDecode_mpeg2source("C:\Anime\Encoder\Anime01.d2v", info=3)
##matrix
ColorMatrix(hints=true)
##Deinterlace
AnimeIVTC(mode=1)
##crop
crop(4, 0, -4, -0)
nnedi3_rpow2(rfactor=2, nsize=4, nns=3, qual=1, etype=0, pscrn=2, cshift="Spline36Resize", fapprox=0)
z_ConvertFormat(width=960, height=720, resample_filter ="Spline36", colorspace_op="470bg:601:470bg:f=>709:709:709:f", dither_type="none")
#fin
Any suggestion?
Thanks.

AssumeFrameBased()?

Yes, it was the first thing I tried.
Even if I remove all filters and leave only the input video, the error persists.
In a test with the AI-upscale filter the error disappears, but I can't use this one, as this filter is slow.
Like this:
AiUpscale(Factor=2, Luma="HQ Sharp", Chroma="Spline36", mode="LineArt")
z_ConvertFormat(width=1440, height=1080, resample_filter ="Spline36", colorspace_op="470bg:601:470bg:f=>709:709:709:f", dither_type="none")

So
Source()
AssumeFrameBased()
z_ConvertFormat()

doesn't work?

Closed for no update


fix(doc): update README

This PR clarifies steps required to run the a11y audit locally. Specifically, we need to mention installing chromedriver and adding to your system path.
Without this knowledge, users trying to run the script will see an error like the one below and it's not so obvious how to fix.
Error: The ChromeDriver could not be found on the current PATH. Please download the latest version of the ChromeDriver from http://chromedriver.storage.googleapis.com/index.html and ensure it can be found on your PATH.
Sort of related to https://github.com/patternfly/patternfly-next/issues/528. It's one of the first experiences one may have in doing a11y stuff with Patternfly, so it would be good to explain all the things upfront, rather than allow user to run into this error and then figure out how to fix it.
list all steps required to run the a11y audit locally

Think this would work for the driver? https://www.npmjs.com/package/chromedriver

Good questions. To @dmiller9911's point if we can ship a binary provided by npm that would be awesome, as it could eliminate the need for users doing this themself altogether and in turn our need to document this much at all. I wasn't sure if it was acceptable/desirable/possible to ship the chromedriver because it's sorta large.. I gave it a shot and the download has only worked for me once out of 5 tries so far.. Does seem to be a simple npm install if it only would work, I noticed adding a path to the driver in a .npmrc file helps it find it, but the download keeps failing. I've tried both of these ways of specifying it
chromedriver_filepath=./node_modules/chromedriver/lib/chromedriver/chromedriver_mac64.zip
chromedriver_cdnurl=https://chromedriver.storage.googleapis.com/2.41/chromedriver_linux64.zip
Below is an example of the error I get when it fails to download, pretty much the same error whether I'm specifying local or cdn. Any ideas?

Thanks for adding this information! I'd love to see this info merged with the instructions we worked on a couple of weeks ago (https://github.com/patternfly/patternfly-next/issues/528). I'm fine with this merging as-is, though and incorporating the remaining info in a later PR.
If you do decide to add the info from https://github.com/patternfly/patternfly-next/issues/528 to this PR, what do you think about moving it to after the Create a new demo section and right before the FAQ section? (i.e. have them test for a11y after they've worked on their contribution).

We can do this work as part of issue #528. And I can work on opening the PR for that later after this is merged.
Thanks :-)


GH-34951: [Ruby] Add methods using MatchSubStringFamilyCondition

Rationale for this change
Ruby binding supported Arrow::Slicer::ColumnCondition#match_substring in #34902.
This PR will use same strategy as this to its family methods.
What changes are included in this PR?

[x] Add Arrow::Slicer::ColumnCondition#start_with?
[x] Add Arrow::Slicer::ColumnCondition#match_like
[x] Add Arrow::Slicer::ColumnCondition#match_substring_regex
[x] Add Arrow::Slicer::ColumnCondition#end_with?

Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
It will add new methods for Arrow::Slicer.

Closes: #34951

Is it better to rename #match_substring to #match_substring? ?


How to handle an object created by operator

Output of helm version:
version.BuildInfo{Version:"v3.1.0", GitCommit:"b29d20baf09943e134c2fa5e1e1cab3bf93315fa", GitTreeState:"clean", GoVersion:"go1.13.7"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:40:16Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:09:08Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Minikube
I'm curious how to handle an object which is created by an operator. My application is installed with helm, and after that, the application deploys other deployments itself. I'd like to wait for these deployments, however, helm install --wait command does not wait for my deployment because they don't know the deployment. How can I wait for this deployment? Thanks.

I'm not sure there is a reasonable way Helm can be made aware of this resource and wait for its readiness. Because Helm only knows about objects it creates (and the children of those resources, i.e. Pods created by a ReplicaSet), I'm not sure there's a way this can reasonably achieved given the current architecture.
Have you had a chance to look at how --wait is implemented?

for reference: https://github.com/helm/helm/blob/master/pkg/kube/wait.go

I'm not sure there is a reasonable way Helm can be made aware of this resource and wait for its readiness. Because Helm only knows about objects it creates (and the children of those resources, i.e. Pods created by a ReplicaSet), I'm not sure there's a way this can reasonably achieved given the current architecture.
Have you had a chance to look at how --wait is implemented?

Thanks for your reply! I took a quick check for your reference, and I agree with you there's no way to helm knows what he did not make. But still, many operators create their own objects. For example, in rook/rook project, there's an operator that deploys a ceph cluster, and toolbox to control the ceph cluster. But the toolbox should be deployed after the ceph cluster is come up. In the current helm chart, there's no way to wait for this. Is it a matter of changing the implementation of the operator itself? or I think we can add some hook (not a yaml) but a shell file or just executing some binaries.

@woohhan  You can try using hooks (post-upgrade post-install ) for this.

@woohhan You can try using hooks (post-upgrade post-install ) for this.

Thanks for the suggestion, I found some example that executes a kubectl command in a container. however, is it the only solution for this? I'm not comfortable with executing a kubectl command in a container...


Multiple interactive sprites not changing mouse cursor appearance

I have multiple sprites that I need to make interactive.

let t = new Tink(PIXI, renderer.view, scale);

let setup = () => {
    ...

    t.makeInteractive(spriteOne);
    t.makeInteractive(spriteTwo);
    t.makeInteractive(spriteThree);
    t.makeInteractive(spriteFour);

    pointer = t.makePointer();

    ...
}

However, when I do so, only the sprite that I most recently made interactive (spriteFour) will trigger the mouse pointer to change to the "pointer" style, signifying that the sprite is clickable. Hovering over spriteOne, spriteTwo, or spriteThree will not trigger a change in the mouse pointer's appearance.
sprite.press = () => {...} and sprite.over = () => {...} event functions will correctly trigger on all sprites, as I can log to the console, but the mouse pointer simply does not change style except over spriteFour. I have tried to overwrite the pointer style manually using if(pointer.hitTestSprite(sprite)){...} in the play function, but it has no effect.
I am using Pixi v4.3.1.

Hi, yes, this is a bug!
I encountered it on one of my own projects a few weeks ago.
I'll look into it.

This is because of the updateButtons() function. The forEach loops which go through all buttons and all pointers should be switched. As it is now, later buttons overwrite the pointer.cursor attribute for every pointer, which was set for earlier buttons (this is why the last button correctly sets the cursor to "pointer").
What's the build process here? I can fix this bug in src/tink.js, but I'm not sure how to re-build bin/tink.js to test this.

@andrewhalle Thanks so much for tracking this down, and I would love your help with this!
The source files are written in ES6 an then compiled down to ES5 using Babel.
If you can post a fix to this bug in this Issue, I can do the new build.

@kittykatattack just submitted the PR!

@andrewhalle Thank you! We were actually working on this at exactly the same time 😄 But I've merged your changes and resolved the conflict and pushed a new build file. Looks good!

@kittykatattack No problem! This is a really great resource you've built, we use it to make menu buttons for our games.


looping test that reads 10 times while running valgrind. See embPattern_loadExternalColorFile() Arduino leak note for more info.

Copied from old to do list.

This is covered by the --full-test-suite.


K3s service failing after etcd reset

Environmental Info:
K3s Version: k3s version v1.25.4+k3s1 (0dc63334)
Node(s) CPU architecture, OS, and Version: Linux QA-k3s-master-1 5.4.0-1109-azure #115~18.04.1-Ubuntu SMP Mon May 22 20:06:37 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration: 3 Masters, 5 Worker
Describe the bug:
Etcd service was not responding (unable to connect via 2379 port)
This made the Master nodes down
We tried to reset the etcd using cluster reset
sudo k3s server --cluster-reset --cluster-reset-restore-path=/application-volume/k3s/server/db/snapshots/etcd-snapshot-qa-k3s-master-1-1687392000 --data-dir /application-volume/k3s

Command ran successfully and then after restarting service  to restart k3s
/usr/local/bin/k3s \
    server \
	'--cluster-init' \
	'--tls-san' \
	'<ip>' \
	'--data-dir' \
	'/application-volume/k3s' \
	'--write-kubeconfig-mode' \
	'644' \
	'--etcd-arg=--data-dir=/var/lib/etcd' \
	'--etcd-arg=--debug' \
	'--disable' \
	'traefik'

But still I am getting
Jun 26 12:05:09 QA-k3s-master-1 k3s[8035]: time="2023-06-26T12:05:09Z" level=info msg="runtime is not yet initialized"
Jun 26 12:05:10 QA-k3s-master-1 k3s[8035]: {"level":"warn","ts":"2023-06-26T12:05:10.657Z","caller":"rafthttp/probing_status.go:68","msg":"prober detected unhealthy status","round-tripper-name":"ROUND_TRIPPER_SNAPSHOT","remote-peer-id":"298b911665c13aa0","rtt":"0s","error":"dial tcp <IP_ADDRESS>:2380: connect: connection refused"}
Jun 26 12:05:10 QA-k3s-master-1 k3s[8035]: {"level":"warn","ts":"2023-06-26T12:05:10.657Z","caller":"rafthttp/probing_status.go:68","msg":"prober detected unhealthy status","round-tripper-name":"ROUND_TRIPPER_RAFT_MESSAGE","remote-peer-id":"298b911665c13aa0","rtt":"0s","error":"dial tcp <IP_ADDRESS>:2380: connect: connection refused"}
Jun 26 12:05:10 QA-k3s-master-1 k3s[8035]: {"level":"warn","ts":"2023-06-26T12:05:10.662Z","caller":"rafthttp/probing_status.go:68","msg":"prober detected unhealthy status","round-tripper-name":"ROUND_TRIPPER_SNAPSHOT","remote-peer-id":"f875d12643597ed2","rtt":"0s","error":"dial tcp <IP_ADDRESS>:2380: connect: connection refused"}
Jun 26 12:05:10 QA-k3s-master-1 k3s[8035]: {"level":"warn","ts":"2023-06-26T12:05:10.662Z","caller":"rafthttp/probing_status.go:68","msg":"prober detected unhealthy status","round-tripper-name":"ROUND_TRIPPER_RAFT_MESSAGE","remote-peer-id":"f875d12643597ed2","rtt":"0s","error":"dial tcp <IP_ADDRESS>:2380: connect: connection refused"}
Jun 26 12:05:10 QA-k3s-master-1 k3s[8035]: time="2023-06-26T12:05:10Z" level=info msg="Tunnel server egress proxy waiting for runtime core to become available"
Jun 26 12:05:11 QA-k3s-master-1 k3s[8035]: time="2023-06-26T12:05:11Z" level=info msg="Waiting to retrieve kube-proxy configuration; server is not ready: https://<IP_ADDRESS>:6443/v1-k3s/readyz: 500 Internal Server Error"

Installed K3s: v1.25.4+k3s1 (0dc63334)

Expected behavior:
After etcd reset and restart k3s it should start the k3s service and work

Did you stop the k3s service before running the cluster-reset command? The output suggests that it's still trying to connect to other etcd peers, which would indicate that the cluster-reset did not complete due to k3s still being running.

@brandond
Yes k3s was completely stopped before resetting
The above logs are after reset when we tried starting k3s service

v1.25.4+k3s1 is from November. Please update to the latest 1.25 release, and try the reset again. If it continues to attempt to contact other peers, please attach the complete k3s log from journald.

closing; please repoen and attach the requested logs if you can reproduce on recent releases.


LLVM Platform issue

I'm currently building an extension to triton (pre-hopper commit) for Apple Silicon and I have settled on a method to do that:

convert TritonGPU To SPIRV; seeing that this has already been implemented I don't want to have to myself if I dont have to
convert ".spv" to Human-readable Metal Shader language using SPIRV-CROSS to .metal
compile .metal to .air
compile .air to .metallib
use metal-cpp to  use .metallib with pybind11 that will get JIT compiled similiar to your usage of SYCL but with Metal

is this a good proccess to do this and how will the different LLVM versions play into this, is the intel fork of LLVM compatible with macos-arm64?
Any feedback would be great

Issue was reported against legacy spirv-target which is no longer supported.


Can't enable notification permissions.

I installed the APK from GitHub, but when I try to enable the permissions, it says I can't enable notification permissions because of security reasons.
I'm on my Google Pixel 4a running Android 13.

Maybe I have to install it from another source? Are there any other options to install it than from the APK?

You can download it from IzzyOnDroid
Smart Edge

Also try enabling developer mode if not

CLosing this due to inactivity please reopen if needed help


Add <meta> theme-color name

From @foolip:

https://chromestatus.com/feature/5398016231997440 says Chrome 39, and https://caniuse.com/meta-theme-color doesn't have data for Chrome Android. Is 80 the correct version?

Initially it was only available on Android in Chrome 39, it landed on Desktop in Chrome 80.

@petele it sounds like BCD is wrong here then:
https://github.com/mdn/browser-compat-data/blob/06a0b03c229b66aaedf5f54d6f750d2f5ecb7f92/html/elements/meta.json#L440
Care to send a PR for that?

Added the blocked label since BCD needs to be updated.


Playlist issue with subfolders only with RFID

Hi there.
Good news fist: I got my phoniebox running well (I2S sound with amplifier, OLED-Display, RC522-RFID, GPIO Buttons, and on/off shim).
That was a long way. Rotary encoder and line out will follow.
That was my first Rasperry Pi project and my fist contact with ssh (runs headless).
I use Rasbian buster 10 and phoniebix 2.0 rc7 classic on a Raspi 4
But there is a problem described following:
What works:
-playing single folders without subfolders (livestream, podcast, normal playlist...all works) via browser and RFID
-playing folders that contain subfolders via browser
Not working:
-playing the same folder that contain subfolders via RFID
I did not expect that starting a playlist behaves different with RFID and Browser.
Folder structure is this:

audiofolders

mainfolder

subfolder 1

livestream.txt (contains valid streamin-URL)

subfolder 2

livestream.txt (contains valid streamin-URL)
*subfolder 3

...

Playing "mainfolder" via browser adds all streams from the subfolders to the file ".../playlists/mainfolder-&RCRSV%.m3u" and starts playing as it should.
After swiping a RFID-card connected to "mainfolder", ".../playlists/mainfolder.m3u" is created, but without content (0 Bytes). If something is playing, this stops. The display shows that phoniebox expects a RFID input.
If I rename mainfolder-&RCRSV%.m3u to mainfolder.m3u I can start the playlist via RFID and I can play and navigate the playlist as expected.
Emptying the playlists dir, trying with a new card, deleting the content of latestID.txt, Latest_Folder_Played, Latest_Playlist_Played, Latest_RFID, all without success.
My workaround: adding several stream-URLs to a livestream.txt -> works, but so I cant assing a certain station to a RFID-card.
Also this shows the songtitles in the playlist instead of the radiostation name (this happens also with livestreams in subfolders and is actually not related to the main issue).
My first attempt was putting each stream-URLs in a different .m3u file (all in one directory), to handle the streams like normal files.
I thought so I can use the shuffle option with webradio.
This did not work at all (creates empty playlist both with RFID and browser).
Beste Grüße
Stefan

Hi, quick question. How did you get the rfid reader and the oled display working? I'd like to do that too, but not sure how to connect multiple i2c devices at the same time. Cheers.


Port commits since May 30th

https://github.com/n0madic/twitter-scraper/commits/master

Major unported features as of #9:

GIF support (https://github.com/n0madic/twitter-scraper/commit/d59ec9529c60facc3c90ff3a81c99e3c0b8c6ba7)
2FA support (https://github.com/n0madic/twitter-scraper/commit/644daafbb65f44464ef357d493f97d29939571c9)
LoginOpenAccount (https://github.com/n0madic/twitter-scraper/commit/fb8ae789bd973266ca2b36b624b3f67124758ce8)

Possibly no longer useful? I need to verify this.


Add Excel tab and additional CSV for Tribal data

Per conversation with @BethMattern and the group, we're going to close this one and rely on @lucasmbrown-usds work on tribal intersection as a proxy to tribal data on downloadable assets


Any plan to support multilingual?

Multilingual is "must have" feature for prod deployment for most international companies , any plan to support it for modules ?
For example , perspective api supports multilingual
https://developers.perspectiveapi.com/s/about-the-api-attributes-and-languages?language=en_US
The concern is some of open source libs and models langkit integrated did not support multilingual yet.

@jack1981 Thanks for the question! We launched with English support primarily but we do plan to support additional languages in the near future. Do you have a top list of initial languages to support?

@andrewelizondo thanks for the response , sorry to take more days to reply as I want to answer the question carefully ( without languages bias :) )
Personally ( not on behalf of company ) , below list of languages will be sufficient for most of cases , I think community can pick up priority
English
French
Spanish
Italian
German
Russian
Portuguese
Dutch
Polish
Chinese (Simplified)
Chinese (Traditional)
Japanese
Korean
Swedish
Danish
Norwegian
Finnish
Turkish
Hungarian
Czech
Thai
Indonesian
Malaysian
Vietnamese
Filipino
Hindi
Arabic
Hebrew
Greek
Icelandic

We need Chinese. Thanks
@andrewelizondo


SemanticDB plugin tempers with ammonite's execution logic

I'd like to have a go at leveraging metals to provide LSP to ammonite scripts. I have some idea of how the different pieces could fit together, but the first hurdle is to make SemanticDB work with ammonite.
After the following fix, running ammonite on the following script :
interp.repositories() ++= Seq(coursier.maven.MavenRepository("https://oss.sonatype.org/content/repositories/snapshots"))

@

import $plugin.$ivy.`org.scalameta:semanticdb-scalac_2.12.4:3.4.0-2-021f7f30-SNAPSHOT`

1+1

yields the following error :
macro implementation not found: generateRoutes
(the most common reason for that is that you cannot use macro implementations in the same compilation run that defines them)
  def apply() = ammonite.main.Router.generateRoutes[$routesOuter.type]
                                                   ^
Compilation Failed

I believe the semanticDB plugin might be tempering with the way ammonite uses the compiler, maybe because of mutations of analysers / reporters on both sides ?
I understand the very experimental nature of what I'm trying to achieve and don't expect to get a lot of support on this, but if I could get some pointers from you guys to better understand the problem and attempt to provide a fix, it'd already be awesome !

It would be awesome to support mill in metals! I have tried mill a bit and my first impressions have been so far great I'm excited to try and use it for my next projects.
The semanticdb compiler plugin emits *.semanticdb files in target under META-INF/semanticdb alongside classfiles (in sbt this is typically something like target/scala-2.12/classes/META-INF/semanticdb). The Ammonite compiler seems to use virtual directories for emitting compilation artifacts and seems to discard non-classfiles https://github.com/lihaoyi/Ammonite/blob/7b6beba1c1c0ba27de2bcd9f24eeb777cdb77a8c/amm/interp/src/main/scala/ammonite/interp/Compiler.scala#L345 For metals to work with mill we will need to write *.semanticdb files to a non-virtual directory. In mill, I suppose out/ would be an acceptable place for that. Any idea how we can detect whether the compiler is running under mill?
Another potential problem that we might encounter is that tree positions are wrong when compiling under ammonite. The SemanticDB format for symbol occurrences (see spec https://github.com/scalameta/scalameta/blob/master/semanticdb/semanticdb3/semanticdb3.md#symboloccurrence) is based on positions. I hit on similar problems when trying to get support for *.sbt files with semanticdb, and I believe the best solution here is to fix upstream tools (sbt/ammonite) to make sure trees have correct positions.

A few undocumented tricks when developing with semanticdb. I have these aliases in my shell
# drop in replacement for scalac
alias metac='coursier launch org.scalameta:metac_2.12:3.4.0 -- -classpath $(coursier fetch org.scala-lang:scala-library:2.12.4 -p)'
# utility to pretty-print *.semanticdb files
alias metap="coursier launch org.scalameta:metap_2.12:3.4.0 --"

You can use these to produce semanticdb files

➜  target git:(master) cat foo.scala
object a extends App {
  println(42)
}
➜  target git:(master) metac foo.scala
➜  target git:(master) metap META-INF/semanticdb/foo.scala.semanticdb
foo.scala
---------

Summary:
Schema => SemanticDB v3
Uri => foo.scala
Text => non-empty
Language => Scala212
Symbols => 1 entries
Occurrences => 4 entries

Symbols:
_empty_.a. => final object a

Occurrences:
[0:7..0:8): a <= _empty_.a.
[0:17..0:20): App => _root_.scala.App#
[0:21..0:21):  => _root_.java.lang.Object#`<init>`().
[1:2..1:9): println => _root_.scala.Predef.println(Any).

metap is helpful to see if positions are for example correct, [1:2..1:9] means "line 1 column 2 until line 1 column 9".

Awesome, thanks for the information, it'll certainly come in handy

Another potential problem that we might encounter is that tree positions are wrong when compiling under ammonite. The SemanticDB format for symbol occurrences (see spec https://github.com/scalameta/scalameta/blob/master/semanticdb/semanticdb3/semanticdb3.md#symboloccurrence) is based on positions. I hit on similar problems when trying to get support for *.sbt files with semanticdb, and I believe the best solution here is to fix upstream tools (sbt/ammonite) to make sure trees have correct positions.

AFAIK ammonite actually does that (I remember seeing a piece of code that does it in the Ammonite codebase). Will do some digging this week.

Some pointers about tuning the compiler in ammonite :

Loading compiler plugins

Setting compiler flags on the go : http://ammonite.io/#CompilerFlags

Thanks for the links! I was able to enable the compiler plugin in the ammonite shell using https://github.com/scalameta/scalameta/commit/91b98c839199c94343167466b3b3d66ad9711568 this change gives a decent workflow to edit semanticdb and run the latest changes in an ammonite repl without having to publish all scalameta modules.
How do you enable compiler plugins for build.sc in mill?

I naively tried to add
interp.repositories() ++= Seq(coursier.maven.MavenRepository("file:/Users/ollie/.m2/repository"))
import $plugin.$ivy.`org.scalameta:semanticdb-scalac_2.12.4:3.4.0-5-761b647e`

to the top of a build.sc but the custom repository doesn't seem to get picked up.

If you mutate the interpreter to dynamically add repositories, you'll have to turn your script into a multi-staged one using the magic @ symbol which gets interpreted by ammonite as "start a new compilation stage"
Sadly there's no syntax to "statically add repositories". Not sure how that could look tbh

For metals to work with mill we will need to write *.semanticdb files to a non-virtual directory. In mill, I suppose out/ would be an acceptable place for that. Any idea how we can detect whether the compiler is running under mill ?

There are two things to take into consideration :

out is to mill what target is to sbt : that's where the mill tasks outputs their results / cache
what's the mill equivalent of project/target ? It used to be under /out, but I recently PR'd mill to be able to have global plugins : https://github.com/lihaoyi/mill/pull/163.

I believe the output of compiling build.sc will be under $HOME/.mill/ammonite, so the question is : how do I detect when the compiler is run by ammonite ? Not sure it's doable in the current state of things, but if you know some way a compiler instance could be "annotated", I don't think @lihaoyi
would oppose a PR that would allow to discriminate the ammonite case.
As for the location where the .semanticdb file relative to .sc scripts should live, I think it'd be better to solve the problem for ammonite in general (as opposed to the specific case of mill).

how do I detect when the compiler is run by ammonite ?

I dirty solution could be something like
val isAmmonite = global.getClass.getName.startsWith("ammonite")

As for the location where the .semanticdb file relative to .sc scripts should live, I think it'd be better to solve the problem for ammonite in general (as opposed to the specific case of mill).

Sure. The semanticdb files can live wherever per se but it would be best to have an easy-to-reproduce way to map from an ammonite script files like build.sc to some location where it's corresponding semanticdb/class files live. In semanticdb lingo we need to know the "target root" and "source root"

target root, the directory that contains the output from the compiler. In sbt this is typically classDirectory and is target/scala-2.12/classes
source root, absolute directory used to absolutize relative filenames inside *.semanticdb files. In metals, we use by convention the "workspace directory" (directory containing build.sc) as the source root.

Compelling point.

source root, absolute directory used to absolutize relative filenames inside *.semanticdb files. In metals, we use by convention the "workspace directory" (directory containing build.sc) as the source root.

Interesting ^^. How does semanticdb know about the "source root" ? A quick look at metals' sbt plugin makes me think it's not communicated by the build tool.

The source root is not persisted to disk because it's not portable across machines. Typically, any tool that loads semanticdb files needs to accept the source root somehow. For example, scalafix has a cli flag --sourceroot, that defaults to the current working directory if it's not provided. In metals, we assume it's the current working directory without a way to configure it.

I see now . I suppose defaulting to pwd / "out" is the right way to go then, even if the out folder is not used by ammonite in general.
How would you set the -P:semanticdb:sourceroot flag programmatically then ? (I'm not too familiar with scalac's internals)

The sourceroot should match the workspace directory, which defaults to sys.props("user.dir"). IIRC, you can set it programmatically given a Global with
global.settings.processArguments("-P:semanticdb:sourceroot" + sourcerootPath :: Nil, true)

Target root should probably be out/somekey.

global.settings.processArguments("-P:semanticdb:sourceroot" + sourcerootPath :: Nil, true)

Gotcha. There seem to be a bug in Ammonite. In the REPL, the compiler-settings mutation gets applied on every execution. I'll try and see if I can fix it and potentially add a pluginOption flag that
semanticdb could inspect and avoid global.getClass.getName.startsWith("ammonite")

Target root should probably be out/somekey.

Am i correct to think that this is the piece of code to amend with the following logic ?
if (the compiler runs in ammonite)
then (targetRoot == "./out/someKey")
else (perform as usual)

or would you envision it otherwise ?

Another potential problem that we might encounter is that tree positions are wrong when compiling under ammonite

Went back digging and found this : https://github.com/lihaoyi/Ammonite/blob/9db2c21bdb41b939b19b44b63b90a480e374970c/amm/interp/src/main/scala/ammonite/interp/AmmonitePlugin.scala#L282 which is the piece of logic I was talking about. Maybe it won't be sufficient, but considering ammonite prints out correct line/column when a script fails to compile, I'm hopeful ^^

Am i correct to think that this is the piece of code to amend with the following logic ?

Correct, but I think it might be worth to refactor targetroot into SemanticdbConfig.targetroot where all the other configuration options are defined.
https://github.com/scalameta/scalameta/blob/ee0143562e012109ff5ccea70360ce74eadb86a6/semanticdb/scalac/library/src/main/scala/scala/meta/internal/semanticdb/scalac/ConfigOps.scala#L7
The default value can be the workingDirectory like sourceroot, but then we override it here https://github.com/scalameta/scalameta/blob/ee0143562e012109ff5ccea70360ce74eadb86a6/semanticdb/scalac/library/src/main/scala/scala/meta/internal/semanticdb/scalac/SemanticdbPlugin.scala#L25 where we have access to a global

but considering ammonite prints out correct line/column when a script fails to compile, I'm hopeful ^^

Fingers crossed.

Taking the liberty to close my own ticket.
Ammonite behaviour is kept unchanged after https://github.com/scalameta/scalameta/pull/1390
Following PR takes steps towards providing ammonite support : https://github.com/scalameta/scalameta/pull/1401
Some work is to be done on the ammonite side to accommodate the semanticdb plugin, namely setting -Yrangepos before the compiler is instantiated, which might require significant effort since ammonite seems to rely on offsets.
I'll open subsequent tickets for more specific questions.
Thank you for the help ^^


Package Refactor

Relates to https://github.com/viaduct-ai/backlog/issues/242
This pr removes all code unnecessary to the functionality of HybridContentsManager. The root directories have been renamed and the dependencies have all been updated to reflect the cut down code. The testing suite has also been updated. To run tests, run the command tox.

Add instructions for testing to the README


Location as require parameter

vnet_location is also required parameter. Can you check and update Read.me file?

Hi @prjelesi , this will be addressed on the next PR. Thanks for checking!

Hi @prjelesi ,
This has been Resolved with #54


Add Teamwork

Opened https://github.com/robchahin/sso-wall-of-shame/pull/501 using the new format and current pricing.
This PR can probably be closed.


CAMEL-20590: avoiding delay to execute timeout to Camel RabbitMQ (InOut)

Description
As described on the issue, the https://github.com/apache/camel/blob/camel-3.21.x/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/reply/ReplyManagerSupport.java#L217 is executing the get excessively. This delay occurs because the ReplyHandler has already been removed by the RabbitMQReplyManagerTimeoutChecker. The contains avoid getting locked when the TimeoutMapEntry does not exist.
Target

[ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

is the map empty, as checking for empty is faster. If you do a exists and then after wards get, then you do x2 the operation.

Hi @davsclaus
Yes, it does the operation x2 inside the map, but not inside the DefaultTimeoutMap. Look at this code:
public V get(K key) {
        TimeoutMapEntry<K, V> entry;
        // if no contains, the lock is not necessary
        if (!map.containsKey(key)) {
            return null;
        }
        lock.lock();
        try {
            entry = map.get(key);
            if (entry == null) {
                return null;
            }
            updateExpireTime(entry);
        } finally {
            lock.unlock();
        }
        return entry.getValue();
    }

Without the contains check the lock is applied even if the entry does not exist. The ReplyManagerSupport calls the get method excessively causing a delay.
    ForegroundTask task = Tasks.foregroundTask().withBudget(Budgets.iterationBudget()
                .withMaxIterations(50)
                .withInterval(Duration.ofMillis(100))
                .build())
                .build();

        return task.run(() -> correlation.get(correlationID), answer -> answer != null).orElse(null);

https://github.com/apache/camel/blob/camel-3.21.x/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/reply/ReplyManagerSupport.java#L217
ForegroundTask no longer being able to locate it (this will happen 50 times). Implementing the 'contains' method ensures that the lock is acquired only when necessary.

camel-rabbitmq is deprecated and removed in v4. You should use camel-spring-rabbitmq, and can you check what it does in this spring component

Sure! I'll test it.
Regarding the update, I believe it's feasible to incorporate it since camel-support is utilized by various components, and it improves the DefaultTimeoutMap avoiding needed lock.

I'll come back soon with results of camel-spring-rabbitmq

Yeah sure the contains check is outside the lock, but is the locking really a bootleneck. And that frequencey is only every 100ms.
@orpiske ^^

MHO, as long as we retain the second if (entry == null) { we should be fine (i.e.: to avoid a TOCTOU issue).
Obs.: without measuring is hard to attest if the lock is a bottleneck , but I think the proposed fix makes sense.


addImports does not support . in from

Environment

Operating System: Darwin
Node Version:     v18.16.1
Nuxt Version:     3.6.2
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      runtimeConfig, modules, build, auth, i18n, css, postcss, imports
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction

Add any import with a . in the from argument (here I'm using chart.js.
Describe the bug
The generated imports.d.ts looks like this:

Note the .js has been removed. I presume as there is something in the import generator that tries to exclude file extensions.
I have tried a number of work arounds including escaping the . which lets me get the dot to come through but nothing quite worked.
Adding a trailing / generates the import ok but then I get a Vite import error when running the application as there are no named exports of the package.
Additional context
No response
Logs
No response

Trying to isolate where the issue comes from it appears to be a problem with unimport.
In the utils.ts file:

However it looks like this should just be taking the from parameter without changing it. I can't see where the extension is dropped.

Found it https://github.com/unjs/unimport/blob/7df98d0a6a7b53437514eb078c295dfc5ec86087/src/utils.ts#L121
This strips all extensions. Found a work around for now... use uppercase letters 😄
Changing my from: to chart.JS sorts this issue for now.

@GerryWilko great debugging! Could you raise an issue in unimport instead ☺?

Yes sir! https://github.com/unjs/unimport/issues/290

Thank you ❤
Let's track there.

Just a note for anyone that tries the workaround it may not be successful in CI as both my GitHub builds and Vercel builds fail to find chart.JS due to casing of the JS.


[docs] Markdown redesign polish

Opening early so that we can iterate with @danilo-leal
Preview link: https://deploy-preview-27956--material-ui.netlify.app/

There are many great design changes here :). The polish opportunities that I can spot on the new design of the documentation:

It seems <h1> is getting set to PlusJakartaSans-ExtraBold for some reason (I didn't dig into it)

+1 for using PlusJakartaSans-ExtraBold on all the markdown headers.

Are we sure about this border applied to the <pre> element? It leaks behind the scrollbar

should we decrese the font weight a bit?

Yes please, it's catching the attention.

I would propose we make the "ad by Material-UI"

There is a layout shift when the search bar loads:

initial paint:

fully loaded:

The scroll-top of the page is no longer stable. Most precisely, the height of the toolbar changes, it's not great for the anchor links:

Do we need the borders in? I personally feels that leveraging spacing would be enough to communicate order:

, that it would give more emphasis on the diamond sponsors without these border.

The diamonds sponsors x2 screen resolution is off. It looks pixelized.

Would it work better with more spacing between the top level nav and its children? It works fine when there is a subheader, but its not always the case, for instance here between "System" and "Basics":

I don't know what we changed about the top level layout but it doesn't work, there are now horizontal scrollbars:

https://deploy-preview-27956--material-ui.netlify.app/components/alert/

Something is off with the edit page button:

@oliviertassinari

Addressed in fcba589
There's a border on this element for dark mode. Is there a better way to do it so it doesn't leak the scrollbar?!
Addressed in 750a108
Addressed in 63b7e3b. I'm not sure if I did it right though.
Need help with this one 😬 @mnajdova or @siriwatknp
Not sure I got what is the weird behavior but @mnajdova or @siriwatknp could probably pull it off.
Moving this discussion to the already opened thread about it.
Addressed in 871ec8e. I have added svgs for Octopus and DoiT (I haven't found it as svg with the International word, is it a problem?)
Addressed in 35614a8.
Very weird. @mnajdova or @siriwatknp any idea?
I guess we could change the markup structure because this button is absolute positioned. Probably using flex would be better?!

I tried to change the Settings Drawer bg color but couldn't do it. Looked it up on the inspect tab and found it weird that there is a background-image being added. When it is turned off, the color I added shows up, but I have no idea where it's coming from.
https://user-images.githubusercontent.com/67129314/131412910-482b11c3-afe0-4818-8081-ce6f2a928c33.mov

asterisk color in dark mode has too much contrast. change to error.300-400 should be fine.

For 10 https://github.com/mui-org/material-ui/pull/27956#issuecomment-908742528 TOC_WIDTH is 210 pixels now

I've fixed it
I think it's related to the change of the width of the table of content (see in AppLayoutDocs it is hardcoded value. I think we need to re-adjust the values of the TOC_WIDTH and NAV_WIDTH.

Just pushed a fix for the Table of Contents width, it seems that it resolved the 10th bullet. 🙏
@mnajdova It seems a bit off having the language menu between the search input and the other icon buttons. My train of thought would be to have all constrained on containers interactive options closer than farther. Do you think there's another way to fix the layout shift (bullet nº5) without changing the component order?

I have pushed small commits trying to simplify and fix more issues, for instance, we were using a font that we don't load, and since loading extra fonts comes with a cost, I defaulted to using the existing ones. @danilo-leal I think that some of these changes could be used as a review of the changes.
The last thing I could notice is the lack of nested side nav. We need it for the date picker, and soon for scaling the content of the date picker. The regression:

I have pushed small commits trying to simplify and fix more issues, for instance, we were using a font that we don't load, and since loading extra fonts comes with a cost, I defaulted to using the existing ones. @danilo-leal I think that some of these changes could be used as a review of the changes.
The last thing I could notice is the lack of nested side nav. We need it for the date picker, and soon for scaling the content of the date picker. The regression:

@oliviertassinari
Great point about the nested Date/Time. I tried to tackle it myself but couldn't pull it off. @mnajdova or @siriwatknp could definitely pull it off easily. I think maybe something like this works for the time being: having the Date / Time "parent" be in the same style as the other ones and just push its children a bit to the left. What do you think?

How should we handle the component sub-section reorder? I can add a commit to this PR per the Figma proposal, or submit a PR to the PR for further discussion...

@mnajdova @oliviertassinari @mbrookes @danilo-leal What do you think if we merge the current progress so that it goes with this week release and then create another PR for what's left?

What do you think if we merge the current progress so that it goes with this week release and then create another PR for what's left?

Sounds good, I will merge this after the package rename, and then we can do the release.

@mnajdova It seems a bit off having the language menu between the search input and the other icon buttons. My train of thought would be to have all constrained on visible containers (borders) interactive options closer than farther. Do you think there's another way to fix the layout shift (bullet nº5) without changing the component order?

@danilo-leal maybe we can move the language at the end (after the settings button)?


Round current temperature

Description:
Now the variable current_temperature is rounded.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @aufano,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

How many decimal places did this variable show?

It's not up to platforms to round. Rounding is already done at the component level: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/climate/init.py#L415-L416

@fabaff @balloob Before my fix my temperatures in my Zwave Popp radiators actuators shows 17.649999618530273 in the current_temperature field, after my fix it show 17.65 all in Celsius.

The fix was in the wrong place. Data has to be rounded on the component level and not the platform level.

Ah ok!, I will fix the component level in #6960 thanks


Switch Music mechanic

Changes

Add a system to switch music genre using the SwitchMusic() function in MusicColorSwitcher script.
Add events to SlingShot (OnNewThrowingColorChange UnityEvent) and GameManager (OnNewColor UnityEvent) to signal when color changes.
Add new test scene based on living room level to test functionality.

Known Issues

First yarn ball does not trigger music change, likely something from Wwise side during setup on first load (i.e., Start in Unity may run before Wwise has started the song, leading to this issue). Will want to fix this in a future dedicated bug fix issue.

Scenes to check
For test of functionality, see: MusicSwitchTestScene. Yarn ball should change music by the following genre:

Red -> Rock
Blue -> Disco
Green -> Children

Have not applied this to other official scenes yet.
Related Items
Will close #2

Has been check by others in Unity and build of the game during playtest, but not officially approved. Making executive decision to merge without being marked approved by another. Will eventually want new programmers to take part in the review process to ease my role as main reviewer.


Is there anyway you can up this mod

Because as of right now I have over 3000B not mb of steam to turn into power I rather use something that takes alot of time to build rather then alot of space. Is there anyway you can increase the limits or the functions of the steam turbine?

I might add more advanced turbines in the future that can process more steam. You could also change the configs.


[FEATURE]: Add deployment supports for Istio Bookinfo demo on Kubernetes

Feature Description
This feature aims to introduce comprehensive support for deploying Istio Bookinfo, a microservices benchmark suite, on Kubernetes environments. This includes creating deployment scripts for Istio Bookinfo, generating intrusive tracing data with embedded tracing framework, and providing detailed documentation on how to deploy and manage these services within a Kubernetes cluster.
Motivation and Context
By enabling Istio Bookinfo deployment on Kubernetes, this project can accurately simulate real-world microservices workloads and assess performance characteristics in a cloud-native ecosystem. The intrusive tracing data will serve as the groundtruth when comparing with the non-intrusive results.
Also, this might be the simplest microservice demo and is a good start.
Alternatives Considered
No response
Potential Impact
No response
Additional Information
Currently, it is meant to be functioned in Kubernetes cluster of

Client Version: v1.29.0
Server Version: v1.29.0

All of the proposed features are added.


Stub all APIs at once

Before we were stubbing each individual stub in a seperate request, which Wiremock struggled with sometimes, now we’re using the Bulk Import API (https://wiremock.org/docs/stubbing/#bulk-importing-stubs), which sends them all in one HTTP request, which is much faster and more reliable.

So, I've figured out what's going on here - Wiremock has the concept of priorities. It usually prioritises the first match, but we can override this, before it kinda worked by accident, but now the order of the stubs is more predictable, so if we want this to work as we expect, then we need to set priorities manually (See https://wiremock.org/docs/stubbing/#stub-priority). This may just be too much work for very little reward though, and we may not want to stub the errors at all in dev.

So, I've figured out what's going on here - Wiremock has the concept of priorities. It usually prioritises the first match, but we can override this, before it kinda worked by accident, but now the order of the stubs is more predictable, so if we want this to work as we expect, then we need to set priorities manually (See https://wiremock.org/docs/stubbing/#stub-priority). This may just be too much work for very little reward though, and we may not want to stub the errors at all in dev.

Are the 'overlapping' requests we'll have the errors and non-error responses?
I don't think we really want to set a priority, we just want the the closest match.
But if we need to set a priority (and I agree that we don't we want to spend much more time on this) would it be possible to bulk load the 2xx responses first and then do the 4xx ones?

Are the 'overlapping' requests we'll have the errors and non-error responses?
I don't think we really want to set a priority, we just want the the closest match.
But if we need to set a priority (and I agree that we don't we want to spend much more time on this) would it be possible to bulk load the 2xx responses first and then do the 4xx ones?

The issue wasn't really that the stub wasn't working, it was much (MUCH) faster and more reliable, but for reasons of Javascript, we were getting the errors being POSTed first, followed by the happy path, now it's just an array, the happy path was getting loaded first, followed by the unhappy path. The way Wiremock works is that it looks through the mocks and finds the first one that vaguely matches that, which is now the happy path. I've got around this by nailing in a 99 priority for the happy path, and then ordering the fields by the biggest amount of missing fields first (so the "unhappiest" path first) and then working down the tree from there.
It seems to largely work now, but not worth spending much more time on, as this is only a development thing to make the application behave in a more "realistic" way.


Implement HeapChunkSelector#select_chunk_for_GC()

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f797726) 78.84% compared to head (091d0b2) 79.86%.

Files
Patch %
Lines

src/lib/homestore_backend/heap_chunk_selector.cpp
78.26%
2 Missing and 3 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   78.84%   79.86%   +1.02%
==========================================
  Files          29       29
  Lines        1035     1058      +23
  Branches      101      106       +5
==========================================
+ Hits          816      845      +29
+ Misses        158      148      -10
- Partials       61       65       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ui not redrawing correctly when using WinitSettings::desktop_app()

Hi,
this issue was fixed a few months ago in #240 but it seems to have cropped back up ever since I updated to bevy 0.14. I'm using WinitSettings::desktop_app(), and when e.g. clicking a button, the UI does not redraw until I move the mouse.
This might have been broken by #278!

Here is a demonstration of the issue. When I click a button, it only appears blue after I wiggle the mouse:
https://github.com/mvlabat/bevy_egui/assets/98399119/a4edca91-31a6-48f9-a0f7-4402579389bc

Hi! I'm sorry to hear the update has broken the redraw functionality for you.
Could you help me to reproduce the issue? I've tried to come up with an example based on your description, but I guess I'm missing something because it's still working for me. Can you please take a look at #293? Feel free to suggest edits.

Hi,
Thanks very much for attempting to reproduce the issue. Weird that it works for you but not for me!
I've also had another redraw issue elsewhere in my project ever since I updated:
I have a flycam which uses WASD to move. Normally holding a key doesn't continuously trigger redraws, so I added a piece of code to the fly cam system to check if the keys are pressed and if so send a redraw event. This always worked in previous versions, but now there's a delay of half a second before the redraws are sent, which is very odd.
I'm going to do some more investigating into this, but it could even be that this issue is nothing to do with bevy_egui! Do you have any idea what could be happening to cause these things breaking?

No idea atm. :(
Have you tried running the example from the linked MR? I'm wondering if it works ok for you. If you can reproduce the issue there, that means the problem might be platform-specific. If not, then it means I've come up with a wrong example.

I'm having the issue as well, with that PR. MacOS.
https://github.com/user-attachments/assets/aa50c784-5f8e-4fab-bb09-3791a6b5dcd4
I was coming at this issue from a different angle. I have a particular interest in spinners continuing to work after this change. if I add a spinner, you can see the buttons behave properly.
https://github.com/user-attachments/assets/f811707e-64b9-451f-90cd-dd0849979c2f
Which makes sense, because spinners cause constant redraws. I will try to investigate this further.

The thing is, I'm also on MacOS, and I still couldn't reproduce it. Now I can though. I don't know what has changed, maybe I was just unlucky or clumsy with my trackpad (e.g. moving the pointer accidentally after pressing a button), but that gives an opportunity to debug it at least 🙃

Just tested your example, and I can reproduce the issue - but only some of the time - sometimes when I click, everything works fine, and other times it doesn't fire enough redraws to show the button becoming blue. So seems like a luck thing, maybe the frequency of the issue happening is influenced by things like the refresh rate or your monitor or maybe ui complexity in the project.....?

I've just pushed another commit to #293 that should fix the issue. Please let me know if it indeed fixes it for you.
@Maximetinu if you can double-check that it doesn't break redraws again, I'll also be grateful :D

Yes, that fixes it for me. Thank you!

@Maximetinu if you can double-check that it doesn't break redraws again, I'll also be grateful :D

I just double checked, it doesn't!

It'd be nice writing a automatic test to cover this, replicating the repro steps that I described in #277
Given that no egui systems are running
When I move the cursor on top of the screen
Then no RequestRedraw event is sent

The given and the then are easy to set up in code, but I don't know how I can simulate the when reliably.. 🤔

The initial issue seems to be fixed. But there may be other issues related to the energy saving settings: #295, #302.


Accessibility - PromptOptions not supporting alt text for images and buttons.

Screenshots

Version
Microsoft Bot Framework v4:
Microsoft.Bot.Builder 4.6.2 Nuget package
Describe the bug
Through Accessibility Scan, we have received the following issues where we could not found a solution to implement using Bot Framework PromptOptions:
Issue description: Ensures  elements have alternate text or a role of none or presentation
Issue description: Ensures buttons have discernible text
These issues occurred where we have created suggested action items (like thumbs up/down, create a ticket, etc) using the PromptOptions class in Microsoft.Bot.Builder.Dialogs. Using the PromptActions, we see that there is no way to add alt text to an image or a button.
Can you please advise on how to achieve accessibility on the PromptOptions in Web Chat?
[Bug]

https://github.com/microsoft/BotFramework-WebChat/pull/2613
Using PromptOptions doesn't have a direct impact on the accessibility of what's rendered in Web Chat. A PR has already been merged to make Suggested Actions accessible, and will be a part of the December 10 release.

@murcinar thanks for the issue. We take accessibility seriously and are coordinating on a change in the CardAction schema definition to include an alt text property for these scenarios. Thanks for your patience as this propagates through the appropriate Bot Framework teams.

@corinagum any updates on this one?

Thank you Chris, I really appreciate your help!
From: Chris Whitten<EMAIL_ADDRESS>Sent: Sunday, February 2, 2020 11:07 AM
To: microsoft/BotFramework-WebChat<EMAIL_ADDRESS>Cc: Murat Cinar<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/BotFramework-WebChat] Accessibility - PromptOptions not supporting alt text for images and buttons. (#2675)
@murcinarhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmurcinar&data=02|01|Murat.Cinar%40microsoft.com|78832531d74d48bac63f08d7a8130830|72f988bf86f141af91ab2d7cd011db47|0|0|637162672007480302&sdata=vV3jyce7TNXLHOsM8cI1tz6oTP07VsxoUwyC263Kgn8%3D&reserved=0 thanks for the issue. We take accessibility seriously and are coordinating on a change in the CardAction schema definition to include an alt text property for these scenarios. Thanks for your patience as this propagates through the appropriate Bot Framework teams.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FBotFramework-WebChat%2Fissues%2F2675%3Femail_source%3Dnotifications%26email_token%3DAN4IWG3XAHCUQVCQNLU4R5TRA4KT5A5CNFSM4JWGBUP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKR6JAY%23issuecomment-581166211&data=02|01|Murat.Cinar%40microsoft.com|78832531d74d48bac63f08d7a8130830|72f988bf86f141af91ab2d7cd011db47|0|0|637162672007490297&sdata=vBxLq%2FnMC6DOK7mvt8Tma%2F8%2F%2BC0tkhmGDMhuT9EK8eY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAN4IWG5CKBVZMARZPGAUU5LRA4KT5ANCNFSM4JWGBUPQ&data=02|01|Murat.Cinar%40microsoft.com|78832531d74d48bac63f08d7a8130830|72f988bf86f141af91ab2d7cd011db47|0|0|637162672007490297&sdata=9Ob3GZAQo07zW40Tfdok4V7Lg25Cm%2BKHcdaEIARNfQI%3D&reserved=0.

Right now we are discussing internally whether or not adding an alt-text to the activity is a viable resolution. The alt-text would be used to add to the image alt, so therefore developers can differentiate between what is read by the screenreader if the img conveys information that is not in the button text.
@murcinar 's use case is a good example, where there is no button text, but the upvote button is commonly used to indicate user response.
I will get an update on the status of this discussion and report back.

Any comments @cwhitten ?

Hi @murcinar, we have agreement that the CardAction schema will change to allow alt-text to be provided from the bot. We're still aligning on a date for this to be available. I'll continue to update this issue with new information.

Thank you Chris! @cwhitten

@murcinar We have (as @cwhitten has already said) the work agreed upon - we just haven't had a chance to book it out yet. I'll update this issue once we assign this to a release.

At the moment, we are still looking to prioritize this issue. This will be at least R10 or after, not for the impending release.

Blocked by SDK changes.

https://github.com/microsoft/botframework-sdk/issues/5874 is resolved. We are unblocked now.

I think we are not punting this one. As Chris didn't tag it as R11 during our last run.


Merge remote-tracking branch 'origin/branch-0.2' into main

Merge remote-tracking branch 'origin/branch-0.2' into main

build


new embedly-jquery version doesn't want to work

I did an upgrade of new javascript, but I have not success to see it working. can you provide some help to check if we need some more info to run it well?
in firebug I checked if all javascript run , and they do
it seems a problem to recognize url

I think i'm having a similar issue.
Here is a website I've developed last year, where I used embedly-jquery (not sure with version, but one older than current release, of course:)
http://www.kantorguitars.com/guitars/kantor-designs/kantor-kamo
There, embedly-jquery and Embed.ly seem to be working fine, even when the code isn't using any authorized key for Embed.ly.
I don't recall having to setup a key at that time (so, I didn't get one), but anyway, even if things changed since then, I'm happy to see that some old code on that website is still working.
But then, on my local copy of the website, where I'm upgrading stuff, including embedly-jquery, I'm getting an error message in JS console:

Failed to load resource: the server responded with a status of 403 (Forbidden) - api.embed.ly/1/oembed?callback=jQuery16406479115984402597_1319123561568&urls=http%3A%2F%2Fyoutu.be%2F_x2xOiXFaS0&maxwidth=500&wmode=opaque&_=1319123566825

To summarize:

publicly accessible website (www.kantorguitars.com) with old code (old version of embedly-jquery) seems to work fine
private (local) website with new code (latest embedly-jquery) doesn't seem to work.

May I be missing a key? But if so, how is that the old code still works?

You need to add a key, it's required for all users. Please sign up for one here: http://embed.ly/pricing.
The website works because we allow a few requests per hour to go through without getting blocked while we transitioned to key based authentication. We will be closing this soon, now that people have had ample time to move to the key based system.
Thanks!

@screeley, thanks for the prompt reply!
I'll sign up for a key then.

@maniqui Great! Happy to help.


Integration Testing Implementation for AppResources

Problem Description

Fixes #220.
Solution
Implements integration testing against OpenTSDB.
Builds upon changes in #274
how you tested the change
Includes integration tests.
Where the following done:

[ ] Tests. Check all that apply:

[ ] Unit tests created or modified that run during ant test.
[x] Integration tests created or modified that run during integration testing
(Formerly called regression tests.)
[ ] Test procedure descriptions for manual testing

[ ] Was relevant documentation updated?
[x] Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

Currently there exists a failing test case due to an unknown EventPort value for the compproc app used in testing. This is causing a connection failure, with the specific location of the issue identified by TODO tasks.

Not sure if it affects much of the current work but fyi we are planning on
removing that event system in favor of standard monitoring tools, likely
opentelemtry.
Which is not to say you dont have to deal with it just maybe dont put
excessive energy in beyond making sure things start. Might be easier to
make sure it's more optional at the OpenDCS core level.
On Tue, Dec 31, 2024, 7:42 AM Ryan Ripken @.***> wrote:

@.**** commented on this pull request.
In
opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/AppResources.java
https://github.com/opendcs/rest_api/pull/311#discussion_r1900169947:

  	else if (!cli.isPresent())

  	{
  		Integer port = appStat.getEventPort();
  		if (port == null)

			return ApiHttpUtil.createResponse(new ArrayList<ApiAppEvent>());

		{

			return Response.status(HttpServletResponse.SC_OK)

					.entity(new ArrayList<ApiAppEvent>()).build();

		}
		apiEventClient = new ApiEventClient(appId, appStat.getHostname(), port, appStat.getAppName(), appStat.getPid());
		apiEventClient.connect();

		LOGGER.debug("Connected to {}:{}", appStat.getHostname(), port);
		clientConnectionCache.addApiEventClient(apiEventClient, session.getId());
	}
	else if (appStat.getPid() != null && appStat.getPid() != cli.get().getPid())
	{
		// This means that the app was stopped and restarted since we last checked for events.
		// Close the old client and open a new one with the correct PID.
		cli.ifPresent(c -> clientConnectionCache.removeApiEventClient(c, session.getId()));

		Integer port = appStat.getEventPort();
		if (port == null)

			return ApiHttpUtil.createResponse(new ArrayList<ApiAppEvent>()); // app not running

		{

			return Response.status(HttpServletResponse.SC_OK)

					.entity(new ArrayList<ApiAppEvent>()).build();

		}
		apiEventClient = new ApiEventClient(appId, appStat.getHostname(), port, appStat.getAppName(), appStat.getPid());
		apiEventClient.connect();

This logic is being duplicated. Its unclear to me why the first branch
doesn't need to check appStat.getPid() != null but the second branch does.
In the second branch you don't need to check cli.ifPresent it has to be
present or you would be in the first branch. I think these two could be
combined and the code would be clearer.
—
Reply to this email directly, view it on GitHub
https://github.com/opendcs/rest_api/pull/311#pullrequestreview-2526561381,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB44KCHYRAIJ4Q6TWDGJINT2IK3QFAVCNFSM6AAAAABUMWWKKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRWGU3DCMZYGE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[Tutorial]: Enable ERC-20 Gas Payments with Coinbase Paymaster

What changed? Why?
New tutorial for enabling ERC20 tokens for gas payments
Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

Review Error for ericbrown99 @ 2024-11-27 14:12:49 UTC
User failed mfa authentication, see go/mfa-help