Add Docs for Binder Badge w/GitHub Actions

Summary of changes made:

Updated conf.py while pair programming with @choldgraf, to enable MyST parser
Added a how-to guide for using Actions to comment on a PR with a binder badge.
Added dependency of myst_parser to doc-requirements.txt

Thanks to @choldgraf for pair programming with me and getting me started.
cc: @betatim

@choldgraf stuck on this one, not sure how to resolve the readthedocs error, does anything stick out to you?

Reposting this comment from @choldgraf as a reminder of TODO for myself:

it would be awesome if you could somehow automate the process of "only trigger this action on a PR from a fork if /binder is added by a member of the GitHub organization that owns the main repo. And if the PR is from within the same repo, trigger /binder for a comment from anyone

@choldgraf

it would be awesome if you could somehow automate the process of "only trigger this action on a PR from a fork if /binder is added by a member of the GitHub organization that owns the main repo. And if the PR is from within the same repo, trigger /binder for comment from anyone

I addressed this with another example and more explanation.  I didn't want to overly complicate the issue, so I provided the building blocks of how you can achieve this with a more simple example and let the user what they want to decide to do themselves.  What do you think?

there are still some open discussions not yet resolved

What is not resolved?   Please let me know!

there are still some open discussions not yet resolved

Nothing any more, you quickly resolved them =) This LGTM! +1 for merge @choldgraf!

  Sharp eye for spacing

Final fix so it doesn't get lost in the big thread: https://github.com/jupyterhub/binder/pull/203#pullrequestreview-450992778

Final fix so it doesn't get lost in the big thread: #203 (review)

Fixed it in https://github.com/jupyterhub/binder/pull/203/commits/d72a4b274749651383d05a1577945180a838c93b

Alright this LGTM as well - thanks all for all of the helpful comments and iteration! And congrats @hamelsmu on figuring out how Sphinx works! You are in rarefied air 😅

It's alive! https://mybinder.readthedocs.io/en/latest/howto/gh-actions-badges.html


Support for modern openff-toolkit versions (>=0.11)

Support for newer and modern versions of openff-toolkit is accomplished by using the openff-units quantities in Molecule objects instead of openmm.unit.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@392d0ec). Click here to learn what that means.
The diff coverage is 0.00%.


Missing parent classes in C++ type hierarchy in debug view

OS: MacOS 12.4
VSCode version:  1.71.0 (Universal)Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c
CodeLLDB version: v0.2.3
Compiler: clang Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5) arm64-apple-darwin21.5.0
Debuggee: lldb-13<IP_ADDRESS>
When browsing the variables in the "RUN AND DEBUG" panel, either their type does not appear (only as an hex number), or some classes are missing.
In the attached screenshot, variable self appears as a number, though it should be a CoreProcess*, and the navigation into variable g is possible but stops at djnn::AbstractGObj, though djnn::AbstractGObj inherits from djnn::FatProcess.
Unfortunately it's difficult to reproduce without my (closed) source code.

Verbose log

Does this reproduce in CLI LLDB?

I get this:
Process 53551 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
    frame #0: 0x0000000101553ff8 libdjnn-gui.dylib`djnn::GLWindow::update_children(this=0x0000000106547580, self=0x0000000104c2df40, force_change=0) at gl_window.cpp:644:48
   641
   642 	    unsigned int self_change = notify_none;
   643
-> 644 	    if (auto * g = dynamic_cast<AbstractGObj*>(self)) {
   645 	        auto update_next_shape_index = false;
   646 	        GLShapeImpl* impl;
   647 	        // if it's a shape...
Target 0: (simplest_app) stopped.
(lldb) p self
(djnn::GUIStructureHolder *) $0 = 0x0000000104c2df40
(lldb) p *self
(djnn::CoreProcess) $1 = {
  _vertex = nullptr
  _bitset = 24
  _debug_parent = nullptr
  _debug_name = "GUIStructureHolder_of_root"
  _dbg_info = (filepath = "/Users/conversy/recherche/istar/code/djnn/smala/cookbook/gui/direct_manipulation/simplest/simplest.sma", lineno = 23)
}

and later after a few iterations/steps:
(lldb) p g
(djnn::Rectangle *) $0 = 0x0000000104a09980
(lldb) p *g
(djnn::AbstractGObj) $1 = {
  _frame = 0x0000000106547c80
  _impl = 0x000000010592e2c0
  _gui_holder = 0x0000000104c336c0
}

Note that when the application is running in the debug mode of VS, in the Debug Console I also get:
print self
(djnn::GUIStructureHolder *) $1 = 0x0000000104c2df40

which seems to mean that lldb inside VSCode also knows that self is a GUIStructureHolder, but for some reasons VSCode does not enable one to explore it as such...

CodeLLDB version: v0.2.3

Wait, what?    Are you sure you are using the codelldb extension?

oops sorry, it's v1.7.4.
I searched for lddb in my extensions, and I picked up the version number of another, not installed, but similarly named extension.

Sorry, I don't know what's going on here.   Further investigation would require a repro.
If you are so inclined, you can try to dump the object hierarchy LLDB exposes via its API (which CodeLLDB uses to render the variables view):
script var = lldb.frame.FindVariable('self')
script for i in range(var.GetNumChildren()): print(var.GetChildAtIndex(i).name)

var will be a SBValue object
(Make sure the Debug Console in in "commands" mode, or else you'll need to prefix commands with /cmd )
Normally, base class should be the first child in this list.

Thank you for your help, if I find a solution, I'll make a notice here.

Well, it seems I found the culprit. Everything seems to run fine when I turn off the use of precompiled headers... There might be some compiler switches to enable both precompiled headers and debug information, but I have not found them yet...


[FEATURE] Add link to Ruby code style guide in linter tooltip

I noticed that linter-rubocop Atom package provides link to Ruby code style guide in tooltip when hoover to offense.
It will be very useful to get this in this extension.

@asux I'm the current maintainer of https://github.com/AtomLinter/linter-rubocop and I was going to use this feature to dive into VSCode plugin development, I was blocked by the fact that you can't put Markdown (currently) into the hover display. That's something I'd love to do when VScode opens the API for that.


str should always return a str type

Thanks for this. Sorry it took so long for the review.
I've fixed this in a different way with fb04b80e3c02695a2d1df3f4a02e317106eaccf3 as doing this fixes that issue, but then causes issues when doing len(crayons.red(1234)). Not sure a case where someone would pass in an object to crayons, edit the object, and then go to print it, so probably safe to just do a str() conversion in the constructor.

Thanks for the fix!


Develop Book Model

User Story: As a developer, I need to create the Book model to manage book data, including ownership and borrowing status, so the application can track books shared within the community.

status as of now: User Model created, but no password hashing implemented yet.

status as of now: Book model created, waiting to push until User model is done, and DB schema and seeds created


[BEAM-4046] revert PR 8581, migrate jenkins tests to use directory based names instead of artifact names

This change is effectively a revert of PR 8581 with additional changes needed to remove references to the artifact based naming of projects.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @adude3141

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java_Examples_Dataflow PreCommit

R: @lgajowy

R: @dmvk

Thanks for taking over, @lukecwik, and sorry for the delay here.
Assigned BEAM-7307 to you.

Apart from typo, LGTM

Run Samza ValidatesRunner

Run Java PreCommit

Run Samza ValidatesRunner

The Java PreCommit was successful here: https://builds.apache.org/job/beam_PreCommit_Java_Phrase/1137/
Github is just taking its sweet time to update the check status so I'm merging.


Fix broken tests after the new heroku deploy flow change

rake db:migrate has been removed from the heroku deploy flow. This
commits fixes tests :)

Thanks for this contribution @delphaber !
There a few more failures lingering in our CI run.
I've tried my best to address them locally. Here's what I've changed:

~
❯ c iron-range-mvp

~/src/iron-range-mvp performance-addition-notifications*
❯ tat
[exited]

~/src/iron-range-mvp performance-addition-notifications* 3m 19s
❯ rails jobs:work
    Sorry, you can't use byebug without Readline. To solve this, you need to
    rebuild Ruby with Readline support. If using Ubuntu, try `sudo apt-get
    install libreadline-dev` and then reinstall your Ruby.
rails aborted!
LoadError: dlopen(/Users/seanpdoyle/.asdf/installs/ruby/2.6.3/lib/ruby/2.6.0/x86_64-darwin18/readline.bundle, 9): Library not loaded: /usr/local/opt/readline/lib/libreadline.7.dylib
  Referenced from: /Users/seanpdoyle/.asdf/installs/ruby/2.6.3/lib/ruby/2.6.0/x86_64-darwin18/readline.bundle
  Reason: image not found - /Users/seanpdoyle/.asdf/installs/ruby/2.6.3/lib/ruby/2.6.0/x86_64-darwin18/readline.bundle
/Users/seanpdoyle/src/iron-range-mvp/config/application.rb:14:in `<main>'
/Users/seanpdoyle/src/iron-range-mvp/Rakefile:4:in `<main>'
/Users/seanpdoyle/src/iron-range-mvp/bin/rails:9:in `<top (required)>'
/Users/seanpdoyle/src/iron-range-mvp/bin/spring:15:in `<top (required)>'
.git/safe/../../bin/rails:3:in `load'
.git/safe/../../bin/rails:3:in `<main>'
(See full trace by running task with --trace)

~/src/iron-range-mvp performance-addition-notifications*
❯ asdf uninstill 2.

~/src/iron-range-mvp performance-addition-notifications*
❯ asdf uninstall ruby 2.6.3

~/src/iron-range-mvp performance-addition-notifications* 15s
❯ asdf install
nodejs 12.11.1 is already installed
Downloading ruby-build...
Cloning into 'ruby-build-source'...
remote: Enumerating objects: 88, done.
remote: Counting objects: 100% (88/88), done.
remote: Compressing objects: 100% (62/62), done.
remote: Total 10028 (delta 44), reused 54 (delta 22), pack-reused 9940
Receiving objects: 100% (10028/10028), 2.14 MiB | 2.80 MiB/s, done.
Resolving deltas: 100% (6493/6493), done.
Note: switching to 'v20191024'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1a902f3 ruby-build 20191024
ruby-build: using openssl from homebrew
Downloading ruby-2.6.3.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.3.tar.bz2
Installing ruby-2.6.3...
ruby-build: using readline from homebrew
Installed ruby-2.6.3 to /Users/seanpdoyle/.asdf/installs/ruby/2.6.3

~/src/iron-range-mvp performance-addition-notifications* 3m 25s
❯ tat

                         C
nSͨpN|Ѷ6/*HK,Q1B CM8awD|巫p/b%x,R

                                Ӥ>0٩BT
                                      lv=Haӹ#h(EcNZ`Dsd?u)=<
                                                            lnxښ7T+s,0HeȆ!Ud~;7`eE"6_cuw<½%^ӚǼJ#hy%,K2
                                                                                0!|W5ud(7_,P
                                                                                L& R( ɂ.ʓH$rQIesDLR'T_w5z4ٖ

~/src/iron-range-mvp masterIesDLR'T_w5z4ٖ
❯

~/src/iron-range-mvp master
❯ production config
=== iron-range-production Config Vars
ADMIN_NAME:               ironrangecomedy
ADMIN_PASSWORD:           johnrusso
APPLICATION_HOST:         iron-range-production.herokuapp.com
DATABASE_URL:             postgres://fchfzsfsdeefsj:b7edaeadb1d43327af20c67959903c0ee61559edcb9654d339029190a162adb4@ec2-54-221-217-204.compute-1.amazonaws.com:5432/d91d8u2pkoqlr6
GA_TRACKING_ID:           UA-147991430-1217-204.compute-1.amazonaws.com:5432/d91d8u2pkoqlr6
GOOGLE_GEOCODING_API_KEY: AIzaSyABq6VYKj_bPL1u1IpMMqUKQYPtUxSp9_0
HONEYBADGER_ENV:          production
RACK_ENV:                 production
SECRET_KEY_BASE:          e368552e95273222b7cc8d84fdc9f1e8d2bbc186e0d98ffcf8a2efcc5420f025c23fa6ba2bc78ffa7fba79374a3eba1362c1979bee284f93f9a1702d08ae280d9bee284f93f9a1702d08ae280d
SENDGRID_PASSWORD:        zbhvhzmg4779
SENDGRID_USERNAME<EMAIL_ADDRESS>SMTP_ADDRESS:             smtp.sendgrid.net
SMTP_DOMAIN:              iron-range-staging.herokuapp.com
SMTP_PASSWORD:            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
SMTP_USERNAME:            apikey

~/src/iron-range-mvp master
❯ f

~/src/iron-range-mvp master
❯
[iron-rang1:CF0* 2:ruby-                                                                [34%] [====      ]  Wed, Nov 13 - 08:46                                                               [98%] [==========]  Fri, Nov 08 - 07:39
  [Restored Nov 15, 2019 at 6:06:41 PM]

~
❯ c suspenders

~/src/suspenders bin-setup-heroku-adapter
❯ g co master
Switched to branch 'master'
Your branch is behind 'origin/master' by 32 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
g
~/src/suspenders master ⇣
❯ g pull
Updating 6834486..12cc650
Fast-forward
 .ruby-version                                              |  2 +-
 .travis.yml                                                |  6 ++++--
 NEWS.md                                                    | 21 +++++++++++++++++++
 README.md                                                  |  8 +++++--
 docs/heroku_deploy.md                                      | 22 ++++++++++++++++++++
 lib/suspenders.rb                                          |  2 ++
 lib/suspenders/app_builder.rb                              | 13 ++----------
 lib/suspenders/generators/app_generator.rb                 |  6 +++++-
 lib/suspenders/generators/base.rb                          |  2 +-
 lib/suspenders/generators/inline_svg_generator.rb          | 14 +++++++++++++
 lib/suspenders/generators/js_driver_generator.rb           |  6 +++++-
 lib/suspenders/generators/production/manifest_generator.rb |  1 +
 lib/suspenders/generators/stylelint_generator.rb           | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/suspenders/generators/stylesheet_base_generator.rb     |  3 +--
 lib/suspenders/generators/testing_generator.rb             |  6 +++---
 lib/suspenders/version.rb                                  |  4 ++--
 spec/features/inline_svg_spec.rb                           | 10 +++++++++
 spec/features/new_project_spec.rb                          |  9 ++++----
 spec/features/staging/pull_requests_spec.rb                |  2 +-
 spec/features/stylelint_spec.rb                            | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 suspenders.gemspec                                         |  3 ++-
 templates/Gemfile.erb                                      | 12 +++++------
 templates/_javascript.html.erb                             |  2 +-
 templates/application.scss                                 |  1 -
 templates/bin_auto_migrate                                 |  5 +++++
 templates/bin_deploy                                       |  2 --
 templates/bin_setup_review_app.erb                         |  1 -
 templates/browserslist                                     |  3 ---
 templates/capybara_silence_puma.rb                         |  1 +
 templates/chromedriver.rb                                  |  8 +++----
 templates/dotfiles/.env                                    |  1 -
 templates/hound.yml                                        |  4 +++-
 templates/inline_svg.rb                                    |  3 +++
 templates/rails_helper.rb                                  | 11 ++++++----
 templates/stylelintrc.json                                 |  3 +++
 35 files changed, 269 insertions(+), 58 deletions(-)
 create mode 100644 docs/heroku_deploy.md
 create mode 100644 lib/suspenders/generators/inline_svg_generator.rb
 create mode 100644 lib/suspenders/generators/stylelint_generator.rb
 create mode 100644 spec/features/inline_svg_spec.rb
 create mode 100644 spec/features/stylelint_spec.rb
 create mode 100755 templates/bin_auto_migrate
 delete mode 100644 templates/browserslist
 create mode 100644 templates/capybara_silence_puma.rb
 create mode 100644 templates/inline_svg.rb
 create mode 100644 templates/stylelintrc.json

~/src/suspenders master
❯ g co -
Switched to branch 'bin-setup-heroku-adapter'

~/src/suspenders bin-setup-heroku-adapter
❯ tat

diff --git a/spec/features/api_spec.rb b/spec/features/api_spec.rb
index d3e210f..9b07cd9 100644
--- a/spec/features/api_spec.rb
+++ b/spec/features/api_spec.rb
@@ -11,7 +11,9 @@ RSpec.describe "Suspend a new project with --api flag" do

     Dir.chdir(project_path) do
       Bundler.with_clean_env do
-        expect(`rake`).to include("0 failures")
+        successfully_executed_rake = system("rake")
+
+        expect(successfully_executed_rake).to eq(true)
       end
     end
   end
diff --git a/spec/features/heroku_spec.rb b/spec/features/heroku_spec.rb
index 312f0eb..6db172b 100644
--- a/spec/features/heroku_spec.rb
+++ b/spec/features/heroku_spec.rb
@@ -36,17 +36,6 @@ RSpec.describe "Heroku" do

       expect(readme).to include("./bin/deploy staging")
       expect(readme).to include("./bin/deploy production")
-
-      circle_yml_path = "#{project_path}/circle.yml"
-      circle_yml = IO.read(circle_yml_path)
-
-      expect(circle_yml).to include <<-YML.strip_heredoc
-      deployment:
-        staging:
-          branch: master
-          commands:
-            - bin/deploy staging
-      YML
     end
   end

If you'd like to continue working on this branch yourself, could you try and get CI green?
If not, could you configure this pull request to allow modifications from maintainers? In that scenario, a maintainer could finish up the changes necessary to land this.
Thanks again!

Sure, I can take a look at it! I need some time though :)

@delphaber closing this in favor of #1011 . I embarrassingly started working on this without looking at the open PRs. I've given you full credit for the fixes in the commit (the email is entirely yours). Thank you so much for working on this!


docs: enhance docs

improve installation guide
improve contribution guidelines
add preview image
add technology badges

I would also like to recommend that we should remove the about section of the readme as the information about the website is already provided below the main heading.

The latest commit removes the additional underline when you hover over a link

Before
After

Thanks @SrNightmare09  for contributing but please make one change per PR, otherwise I will have to merge the entire PR. I can't merge this since the underline in the "GitHub" text is intentional. Can you make another PR making change in just docs.

@SrNightmare09 The best way to get PRs merged is to make small PRs with small changes so that I can roll back rather than 1 big PR with 5-6 commits. Also do one thing in one PR. If PR is about docs only do docs. For any other additions, you can open another PR.

@1Shubham7 I have made the changes and reverted to only change in documentation.

@SrNightmare09  I told you the underline looks good. It is intentional. Please make PR for the other commits where you change the readme doc.

@SrNightmare09  I told you the underline looks good. It is intentional. Please make PR for the other commits where you change the readme doc.

I have removed the changes to the css files, so the underline is still visible. I don't seem to understand what else you want from me.

@SrNightmare09 Its perfect now!! I am really sorry if this was annoying but mostly in open-source one should only do in the PR what he/she was assigned in the issue and make small PRs.

Thank you @SrNightmare09 for your time. Please contribute more. I really value your contributions.


Update meta data

I fixed also some failed test case.
When I fixed these, I referenced this info, https://github.com/google/libphonenumber/blob/master/resources/ShortNumberMetadata.xml .
(Hence it seems this repo need to update 'metadataGenerator' swift file to parse not json files but xml files.)

@paween Thanks for murging it. :D
Could you release newest version for us?

Hey @meccatol, do you know which version you ran this against?
We try to keep all our platforms in lockstep where I’m at.
Also, what was the process to run the tool? It isn’t documented any where that I could find so I had taken a stab in the dark.
Thanks!

Hi @lickel, we used it with latest version, ''0.9.15'.
But this is out dated about a year! So I updated metadata for a newest version.
And I have dug this repo for updating metadata and found this issue, #258 . (It's helpful)
But some info is incorrect, so I followed next steps.
$ cd yourFork/libPhoneNumberTests
$ swift metadataGenerator
(this is swift script file)
$ cd ../libPhoneNumber
$ ./GeneratePhoneNumberHeader.sh

Finally, I've got newest jsons and NBGeneratedPhoneNumberMetaData.h files.
And I figured out this repo use json files, but original repo use xml file.
So I think it need to update 'metadataGenerator' script to use xml file to parse.

Do you remember which version you ran the metadataGenerator against for this PR?
Whatever was on master that day?

I ran that script latest branch, master, commit sha is e50f018. (That time was 0.9.15 ver)


Quest Bot: switch back from in-memory storage

In #158 @therealjohn fixed Quest bot to use in-memory storage since we don't have documentation on obtaining storage string/key yet.
Once we have more information available, we should switch back and/or let the user choose which option they want to use.

[ ] Update the sample
[ ] Update the README.md
[ ] Documentation

Yeah I've done a couple of core fixes for QuestBot as one-off PR's but I also switched QuestBot back to using the MemoryStorage provider.


bug(frontend): panicked in parallel e2e test

Describe the bug
https://buildkite.com/risingwavelabs/pull-request/builds/7999#01831b88-7174-4196-956c-3929447eaa8c/2693-2793
thread 'risingwave-main' panicked at 'internal error: entered unreachable code', src/frontend/src/scheduler/distributed/stage.rs:460:22

full log: frontend-4566.log
To Reproduce
No response
Expected behavior
No response
Additional context
No response

Discussed with @likg227 , seems can no reproduce so we decided to merge #5211 first and see whether it will happen again


Mongo provisioner not able to locate pymongo module

🐛 Bug Report
When using the maintenance/redeployments branch, the Mongo provisioner fails with the error below.
With help from @mcdonnnj, I was able to fix this issue locally by forcing pymongo 3.6.0 to be installed with pip3, rather than with pip2:
- name: Install pymongo 3.6
  ansible.builtin.pip:
    executable: /usr/bin/pip3
    name: pymongo
    version: '3.6'

To Reproduce
Steps to reproduce the behavior:

Use the maintenance/redeployments branch
terraform apply

Expected behavior
All ansible provisioners should run without failure.
Any helpful log output
│ TASK [mongo : Create admin user in admin db (first user, no authentication)] ***
│ An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'pymongo'
│ fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "msg": "Failed to import the required Python library (pymongo) on database1's Python /usr/bin/python3. Please read the module documentation and install
│ it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"}

I believe this was fully resolved in https://github.com/cisagov/cyhy_amis/pull/642 and that the source of this was that @dav3r was using a development branch which included updates to the Debian versions used for AMIs (merged in #641). These version updates (as well as updated logic in Ansible) resulted in Ansible using Python 3 by default instead of Python 2 for the post-deployment Ansible provisioner.


True Color: R and B interchanged

Describe the bug
It seems that, when reading or writing colors, the red and the blue component are interchanged.
To Reproduce
Create a multileader with kind-of blue leader line.
Debug the Color R G B values: we get kind-of orange.
Expected behavior
It should be the RGB as selected in AutoCAD.
Solution
Change line 39 in DwgStreamReaderAC18 to:
color = new Color(arr[2], arr[1], arr[0]);
and change DwgStreamWriterAC18 accordingly.
Related Refactoring
We have an implementation of ReadCmColor in DwgStreamReaderAC18 that can read a color index or a true color.
The implementation in DwgStreamReaderBase is for older versions. It just reads a color index
But:
In DwgMergedReader.ReadCmColor the base implementation is called if (!(this._mainReader is DwgStreamReaderAC18)).
Otherwise, the same code as the implementation of ReadCmColor in DwgStreamReaderAC18 follows.
If I did not miss anything the implementation in DwgMergedReader can be reduced to.
	public Color ReadCmColor()
	{
		return this._mainReader.ReadCmColor();
	}

20240322_ml_with_style.zip

BTW:
What does this comment tell?
//CECOLOR:
//3221225472
//0b11000000000000000000000000000000
//0b1100_0000_0000_0000_0000_0000_0000_0000 --> this should be ByLayer
//0xC0000000
3221225472 = 0xC0000000 = 0b11000000000000000000000000000000
0b1100_0000_0000_0000_0000_0000_0000_0000 indicates a true color, otherwise this bit must be set:
0b0000_0001_0000_0000_0000_0000_0000_0000.
So this is not ByLayer.
But it would be interesting to know what the meaning of the other bits of the byte 3 are:
We read

0b1100_0010 a 0b1100_0011 from DWG files
0b1100_0000 a 0b1100_0001 from DWG files

Hi @mme1950,
I'll open a branch to fix the order of the bytes.
About the DwgMergedReader.ReadCmColor is implemented this way because for versions after AC1018 have the text stream at the end, which means that we need to read the color book name (by now is not supported) using the _textStream and not the _mainStream, there is a comment at the begining of the method:
//To read a color in this version file needs to access to the
//string data section at the same time.

Is not ideal but does the trick.

//CECOLOR:

I did some tests changing the values in the Current Entity Color and I've noticed that some encoding seem to change for this specific value, that's why that comment is there.

Hi @DomCR,
so DwgStreamReaderAC18.ReadCmColor is never called, but the identical code following the if (!(this._mainReader is DwgStreamReaderAC18)) ....

//CECOLOR:
If the value is<PHONE_NUMBER> = 0xC0000000 = 0b11000000000000000000000000000000 we have a true color and we reach the else branch.
This value will not be read as ByLayer. If it should it must be handled explicitly.

Sorry, forgot about that one, I'll add a test too.
thanks!

What is the reason that in DwgMergedReader.ReadCmColor
DwgStreamReaderAC18.ReadCmColor is never called, but the identical code following the
 if (!(this._mainReader is DwgStreamReaderAC18)) ....

That if is to call the ReadCmColor for versions that are lower than AC1018, in that case we only need the index, so the "duplicated" code has to be override.

Hi @DomCR,
would not this code do the same:
	public Color ReadCmColor()
	{
		return this._mainReader.ReadCmColor();
	}

If _mainReader is a base class of DwgStreamReaderAC18, the code that writes only a color index is called.
The code in DwgStreamReaderAC18 can write both.
May be I  missed the point.

The reason for the duplication is this part of the method:
	string colorName = string.Empty;
	//RC: Color Byte(&1 => color name follows(TV),
	if ((id & 1) == 1)
	{
		colorName = this.ReadVariableText();
	}

	string bookName = string.Empty;
	//&2 => book name follows(TV))
	if ((id & 2) == 2)
	{
		bookName = this.ReadVariableText();
	}

The ReadVariableText uses the _textReader because the text is stored at the end of the entity, so it  cannot be handled by the main reader, that's why there is a duplication.
Let me know if I resolved your question.

Oh, I understand. this in DwgMergedReader is clearly not the this in DwgStreamReaderAC18. Is the code in DwgStreamReaderAC18 called and can it work at all?


Minor UI tweaks

Gitea version (or commit ref): 1.7.0

Behavior

[ ] templates/repo/create.tmpl – Once you select a license you can no longer deselect it.
[ ] External issue trackers: The issues tab should have an external-link-alt icon and link directly to the external tracker so that you can see the URL by hovering over it.
[ ] When you select an issue/pull request the toggle button transitions to open & close buttons, which is not only problematic because it still looks like a toggle button but also doesn't make sense because you are never able to open or close an issue/pull request, it's either open or closed, you only ever have one choice (to toggle the current state). I suggest the transition to be removed and instead display an open or close button next to the toggle button.

[ ] The above check boxes should not be displayed for repositories where you are not allowed to open or close issues/pull requests.
[ ] 404 pages of files, issues, pull requests, releases and wiki pages should include the repository header if the repository exists.
[ ] Reset password should directly tell you when a code is invalid: https://try.gitea.io/user/reset_password?code=x
[ ] public/js/index.js – When editing the labels of an existing issue (see screenshot), the labels are currently saved with every select / deselect, which just leads to unnecessary spam. The labels should only be saved after closing the popup, which is also the way GitHub does it.

Visuals

[ ] templates/repo/header.tmpl – Visually disable fork button on own repositories (you cannot clone them) by adding disabled class .

[ ] templates/repo/home.tmpl – Give New Pull Request button a text label instead of a cryptic icon.
[ ] public/less/themes/arc-green.less – The dark theme should use a less vibrant color for green buttons, I suggest #87ab63, the same color used for links.

I think I'll give this a go. I'll make a WIP PR once I've made some progress.


Minor typo and grammar fixes

@no1xsyzy @ziahamza a friendly ping :)

sorry but I don't have write access.
@anthonyraymond


generating pdf outputs

Hi,
Can we use asciidoctor-pdf and asciidoctor-epub to generate respectively html, pdf and epub directly with jekyll ?
I suceeded to get revealjs working but i got an error with pdf.
This is what i've done for now based on the revealjs details found in #136 :
in the adoc source i added the attributes :
:backend: pdf
:page-layout: false

in the _config.yml
plugins:
  - jekyll-feed
  - jekyll-asciidoc
  - asciidoctor-mathematical
  - asciidoctor-revealjs
  - asciidoctor-pdf

The error returned is :
  Liquid Exception: undefined method `to_liquid' for #<Asciidoctor::Pdf::Converter:0x00007f83200d91c0> in feed.xml
             Error: undefined method `to_liquid' for #<Asciidoctor::Pdf::Converter:0x00007f83200d91c0>
             Error: Run jekyll build --trace for more information.

Seems that the converter is called but is it a layout matter ?
What am I missing, thanks in advance for your help, any thoughts are welcome.

This plugin really wasn't designed to produce anything other than HTML. There are several places in the plugin where it assumes it's dealing with a string. However, both PDF and EPUB3 return object data. So those assumptions would have to be changed.
If someone wants to work on this, I'd be happy to assist. I don't have the bandwidth to take it on myself.

Another approach for pdfs would be to emulate asciidoctor-web-pdf and use perhaps https://github.com/YusukeIwaki/puppeteer-ruby to get Chromium to render the pdfs.


Refactor collections and collection property access.

Describe the pull request
This PR improves interfaces and collection handling. The Enumerable container has been replaced in favor of std::generator and where possible references to the underlying arrays are returned. The basic design principle is to use Enumerable where no guarantee about the storage of elements can be made, i.e. where further transformation or filter is applied to a container before returning from it. If the array property maps to a contains relationship, the a reference to the array type is returned instead (which can hardly be beaten in terms of performance). Interfaces use generators to convert the concrete representation into interface pointers and yield them using this interface, so it is (as expected) most efficient to call specialized classes where possible. For inputs, generators can be used to create lazy-evaluated data streams. In some places, overloads have been added that allow to supply both: generators or spans.

Blocked until std::generator is available.


If possible, don't activate on onStartupFinished

When you are onStartupFinished activated, you activate every single time, even if the user has no intention of using the extension. I don't exclusively work in Gists so all of those times I'm not working in Gists, GistPad is activated for nothing which does introduce memory pressure and slows down VS Code.
It's better to be reactive and only activate when the user interacts with your extension:

via a command
via a view being visible

To Reproduce
Steps to reproduce the behavior:

Go to vscode.dev
install gistpad
reload the window
gistpad is activated

Expected behavior
It shouldn't activate until needed.
Additional context
The line in the package.json is here:
https://github.com/lostintangent/gistpad/blob/master/package.json#L63
Activation events for your reference (even though I know you know where these are)
https://code.visualstudio.com/api/references/activation-events

Hey @TylerLeonhardt, please check this PR comment as to why we removed actication on * and added onStartupFinished.
Do you have suggestions about how to display the status bar items without using onStartupFinished?

I read the Wiki's section in the readme... it looks like these status bars are added when:

The folder is named foo-wiki
The folder contains a gistpad.json or a foam.json

The latter can be easily triggered with: "workspaceContains:**/gistpad.json" and "workspaceContains:**/foam.json" activation events.
The former isn't possible at this time... but IMO, if that is really the only thing keeping onStartupFinished... then it doesn't seem worth it. The user is likely to hit one of the other activation events.

a workaround would be to have a separate extension called GistPad Wiki's that is onStartupFinished activated that simply activates GistPad.

if there's an extension that will likely also be installed in this foo-wiki scenario and it contributes a view/webview, maybe you could use that activation event

Actually I'm not sure... I think trying workspaceContains:*-wiki for the former case might be worth trying but I doubt it works.


[DOC] Provide Online Documentation

Rapids-cmake currently provides no online documentation of the functions it provides.

With https://github.com/rapidsai/rapids-cmake/pull/14 merged we are ready to generate online documentation.


Rewrite to TypeScript and serve own definition files

anything I can do to help?

This is finally done, please check out the new version 4.1.1 :wink:


Identifiers that are keywords in JS

It happily translated a variable named function => var function
Maybe there are more such cases?

I've encountered a bug which could be related. When defining object property named 'length' it crashes in javascript when you try to assign to it. Probably will need another macro like py_length / js_length

The same appies to declaring variable named "var" in python


taking in node resources in account

solving #513

@mudverma looks like there's a conflict, we might want to rebase with the latest changes. Thoughts?


Cyclecloud:GPU experiments (WIP)

WIP on adding Cyclecloud GPU experiment SLURM scripts. Will continue to update the description based on progress.
Applications tested:

Kripke

Can you please tell (ping/at) me when this is ready for review? Ty!

@amarathe84 is this ready for review?

Yes, it's ready for review--removed WIP.

@amarathe84 is this ready for review?

@vsoch Yes it's ready for review--removed WIP from title.


April cleanup corrected

Added unit tests, started refactoring Domain presence logic

@russgold @moreaut Russ, in the original April cleanup review, I noted several changes for WDT that were included with your refactored files.  Tom has noted at least one of those here, but I suspect the others are still present in these changes.  Can you please review and remove changes that are specific to WDT.


Collect repo traffic stats

The problem
The GitHub API returns only traffic stats for the last 14 days. It would be interesting to check longer-term terms.
Suggestions
It's a single query and it can be done every 7 days or so from some site, stored in JSON form and processed somehow. A cron job would probably do the trick.

@dontlaugh  - would it make sense to add this as an infra task across all the raku repositories?

All things considered, it sounds interesting, yea. In the past GitHub has been brutal with their API limits, so we have to proceed carefully.
Let's close this here and open on Raku/infra?

Let's close this here and open on Raku/infra?

Done here, I'll let you open the infra ticket. Thanks!


Previous scene will rerender when NavigationExperimental pop

I think scenes will keep in stack, but when I pop the navigator, the previous scene is re-rendered.
why? the experience is so bad.

Thanks for your question!
We want to make sure to keep signal strong in the GitHub issue tracker – to make sure that it remains the best place to track issues that affect the development of React Native.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-native? We'll be happy to answer there. Post a link to your Stack Overflow question here, so that we don't lose track of it.


Implement Flask instrumentation support

A Flask OpenTelemetry instrumentation exists, and supporting it would be neat. If Django is Rails, then Flask is Sinatra: it's the "light-weight", DIY option for making a web application.
To do

[x] Create a test setup for the instrumentation https://github.com/appsignal/test-setups/pull/112
[x] Write an extractor for the agent https://github.com/appsignal/appsignal-agent/pull/990
[x] Add an instrumentation adder for the package https://github.com/appsignal/appsignal-python/pull/60
[ ] Document it for the existing standalone-agent-based setup

@luismiramirez I notice now that the to do list says "document this for the existing stand-alone-based setup". We can still do that if we think it's valuable, but now that the future Python package docs are ready, we might want to only write the docs for the Python package and add them to that PR.
(We also haven't really tested this with the stand-alone setup, I don't think -- which is also fine in my view)

I suggest we write it for the new docs.

Yep, my idea is to add the instructions to this PR


Dungeons: Mobile Joystick scene

Now that parallel scenes are supported, we want to add mobile joystick as a separate parallel scene so that it is not affected by zoom

done


Specify what damage sources are removed

Updated the info to be more specific. Thanks for your interest in my mod!

Thank you!


Topics: add new topic for unannounced channels

Adds a new topic.  An unresolved issue is what to call this topic: unannounced channels or private channels.  The name we choose affects the URL and I really don't want to break a URL (or even setup a redirect) if we change names later, so let's try to choose a good term now.
Arguments for "unannounced"

It's an accurate description of the key attribute of such channels
It has no particular negative or positive connotations (AFAIK)
It has use going back to at least 2017 and a quick search of Lightning-Dev shows it being used by Rusty Russell, Christian Decker, and Bastien Teinturier.  ZmnSCPxj seems to use the related term "unpublished channels".  Those are all significant contributors to LN development and I like to honor contributor terminology choices when they don't get in the way of clear communication

Arguments for "private"

It's also an accurate description of the key attribute, although it may give the mistaken impression that private channels are resistant against surveillance (which they may not be, not any more than, say, private property is resistant against surveillance)
It's the term used in BOLTs 4 and 11
It seems to be the term used by everyone but the people noted above on the Lightning-Dev mailing per a quick search of the archives via my MUA

I originally went with "unannounced" because of Zmn's argument against such channels but @jnewbery questioned the logic there:

I don't fully understand z-man's argument. He says that if a channel is unannounced, then the connected party in that channel knows that all payments to/from that channel are ultimately to/from the other party. He then says that all channels should be announced. But in that case, doesn't the connected party still know that all payments to/from the other party are ultimately to/from the other party if there's only one announced channel to that pubkey? To avoid that, the other party needs to have at least two channels open and route payments (otherwise the spy could send probe payments via the victim and see that it never routes and only ever terminates payments).
Z-man's argument is against non-routing nodes rather than against unannounced channels.

I think I still prefer the "unannounced" name because of its lack of association with the word "privacy".  I think it's better to use bland names than give users potentially unreasonable expectations.  However, I don't have a strong opinion about which name we choose as long as it's something we can stick with long term.

I think 'unannounced' is better. Privacy is multidimensional and to some extent subjective, whereas unannounced is an objective description - it's a channel which is opened and not announced on the lightning gossip network.
I like the shorter unpublished channels delenda est summary.

To avoid that, the other party needs to have at least two channels open and route payments (otherwise the spy could send probe payments via the victim and see that it never routes and only ever terminates payments).

If the party with one published channel itself has unpublished / unannounced channels with other peers (who are foolish enough to use them) then it can route, and the surveilling node will mis-assign a set of payments as terminating to the one-published-channel node without realizing that in fact this is a routing node with its own unpublished peers.
Which suggests to me that basically the non-publishing nodes get their privacy leeched off by the published peer, thus unpublished channels delenda est.

Z-man's argument is against non-routing nodes rather than against unannounced channels.

This is correct.  But a node with one published channel can still route if it has unpublished peers, whereas a completely unpublished node cannot route at all.
In any case "unannounced" / "unpublished" is a better term as it does not imply any privacy --- a node might be more concerned about making sure its onchain funds are not linked to its offchain Lightning activity (which is revealed on publication of a channel), and trust a particular Lightning Service Provider to keep mum about its offchain activity (which I would argue is not something you want to rely on --- people change, and since ultimately all Lightning Service Providers are made up of people, so too will they change, and the entity you find trustworthy today may not be trustworthy tomorrow, and yet the logs exists, thus, unpublished channels delenda est).

I prefer "unannounced" as well, for the good reasons discussed above.

Ok, unanimous agreement so far on naming.  I've rephrased the final paragraph to give the reason for discouraging the name "private channels" as it confusing people into thinking they're more private.  It still links to @ZmnSCPxj post, as I think that's still the best extended explanation of the privacy implications.

@ZmnSCPxj - thanks for dropping in :)
I really don't understand the delenda est terminology, or for that matter any other argument along the lines of "to use Bitcoin/Lightning the way I want to, I need to prevent others from using Bitcoin/Lightning the way they choose to." We recently saw similar arguments about the mortal threat posed to all users of Bitcoin by people choosing to use BIP 157. I still believe in the approach of trying to build something better, rather than trying to prevent people from using something worse. That approach seems much more likely to succeed in the long run (and much more interesting!)

If the party with one published channel itself has unpublished / unannounced channels with other peers (who are foolish enough to use them) then it can route

ok, so lets imagine this world where you've successfully managed to delere all unannounced channels. In this world, nodes with announced channels no longer receive this privacy boost. In the world we live in, the fact that unannounced channels exist is enough to provide privacy cover for all announced channels.

the non-publishing nodes get their privacy leeched

Not true. The privacy/deniability benefits are shared by all announced channels, since any of them could be routing for unannounced channels. Yes, the unannounced channel counterparty does give up some of its privacy for the convenience of not having to be a routing node, which I think is a trade-off that some users want to make. Saying "that's not something I want to use or work on" makes sense to me. Saying "this poses a mortal thread to the entire system" is stretching.

Good discussion!  I forced pushed another attempt at rewriting the final paragraph to try to fairly summarize the issue in as few words as possible (but with references).

ACK 90418f647168190f9511e07e55817e9e2bbeb7f1. Looks good to me. Neutral language is best for the topics summaries!

ACK 90418f6
@jnewbery argument accepted.


[BUG] Readme pub.dev link is incorrect

Link in the readme to pub.dev rowting to the original package page.

Also make sure that the link in pub.dev links back to this repo

ok!


Pattern that the region based isolation checker does not understand how to check

Description
This is a more concise reproducible than others I've seen. Calling an isolated method on an actor from a MainActor-isolated class fails to build if done in the same call with a function result, but succeeds if I break it down to 2 separate calls.
cc @gottesmm
FWIW this built in Xcode 16 b2, fails in Xcode 16 b3 and b4. Also builds with latest release/6.0 toolchain<PHONE_NUMBER>11a, not sure if that means already fixed but not yet shipped in Xcode.
Reproduction
actor SomeActor {
	func doSomething() { }
}

@MainActor
final class SomeIsolatedClass {
	func someActor() -> SomeActor { .init() }

	func doWithSomeActor() async {
		/// This builds:
		let act = someActor()
		await act.doSomething()

		/// This fails:
		await someActor().doSomething()
	}
}

swiftc isolationissue.swift -swift-version 6

Expected behavior
Builds successfully.
Environment
# Xcode 16 beta 4 (fails)
$ swift --version
swift-driver version: 1.112.3 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.8 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
$ swiftc isolationissue.swift -swift-version 6
isolationissue.swift:15:21: error: pattern that the region based isolation checker does not understand how to check. Please file a bug
13 |
14 | 		/// This fails:
15 | 		await someActor().doSomething()
   |                     `- error: pattern that the region based isolation checker does not understand how to check. Please file a bug
16 | 	}
17 | }

# release/6.0 July 21, 2024 (builds)
$ xcrun --toolchain org.swift.600202407211a swift --version
Apple Swift version 6.0-dev (LLVM ec7116ccf9bd8a8, Swift e6aae024fab0927)
Target: arm64-apple-macosx14.0
$ xcrun --toolchain org.swift.600202407211a swiftc isolationissue.swift -swift-version 6
$

Additional information
No response

I've run into a similar situation when awaiting an async var:
            // ✅
            // Breaking this up into 2 lines works around a Swift bug with region-based isolation checking
            let staleTasks = await service.allTasks
            try removeStaleBackgroundTasks(tasks: staleTasks)

            // ❌
            try await removeStaleBackgroundTasks(tasks: service.allTasks)

I've run into same issue in a bit different situation.
actor NotificationManagerr {
    func scheduleTimeIntervalNotification() async throws {
        // ❌ Pattern that the region based isolation checker does not understand how to check. Please file a bug
        try await scheduleNotification()

        // ✅
        try await scheduleNotification(sound: .default)
    }

    private func scheduleNotification(
        sound: UNNotificationSound = .default
    ) async throws {}
}

Another example:

actor S {
  init(
    // Comment this line out and it builds:
    isolation: isolated (any Actor)? = #isolation
  ) {
    fatalError()
  }

  func f() -> S {
    fatalError()
  }
}

func f() async {
  _ = await S().f()
}


cool

this is actualy like happymod but on computer to creator i love you and keep on working on this

Thank you, I will!


Use token macro in comment message

Hi,
It would be great if we could use token macros from https://wiki.jenkins-ci.org/display/JENKINS/Token+Macro+Plugin when posting comments to github. This would give much more flexibility to the message content.
If you think it is a good idea, I would be happy to submit a PR with this change.

:+1:

:+1:

+1

This should be possible now with the downstream job pattern described in the (current version of the) README. That is, by creating a downstream job that receives whatever parameters you send, and sets something using the macro plugin. Let us know if that suffices?

No response (and admittedly this issue did not get a response from our side for a very long time either...I just jumped into help with the plugin recently).
Anyway I think this is possible now so I'm closing the issue.


Allow override of chef-solo directory

From what I can tell, the remote directory used to store the rsync'd chef recipes is /tmp/chef-solo. It would be nice to be able to override this -- maybe with an option to the fix command.

Understood. It is now marked as a feature, so we will look into adding it. Thanks for the detailed explanation.


Release Checklist 23.10

Release Checklist for v23.10:

Status
Task
Start
End
Owner

Pre-release

- [ ]
Notification to team of last feature sprint in milestone
2023-09-18
2023-10-06
@mattahrens

- [ ]
Burndown (no new features for current release)
2023-10-09
2023-10-20
Team

- [ ]
Update docs for current release in spark-rapids without updating release links
2023-10-16
2023-10-20
Team

- [ ]
Create a PR to update release links
2023-10-20
2023-10-20
@nvliyuan

- [ ]
Get RAPIDS 23.12 cudf java build working.
2023-09-25
2023-09-29
@pxLi

- [ ]
Create 23.12 branch including spark-rapids-{jni,private} and spark-rapids
2023-10-16
2023-10-17
@pxLi

- [ ]
Automerge from 23.10 to 23.12
2023-10-18
2023-10-20
@pxLi

- [ ]
Enable Jenkins builds (premerge, nightly, integration, performance) for 23.10
2023-10-16
2023-10-19
@pxLi

- [ ]
Virtual review
2023-10-16
2023-10-27
@mattf

- [ ]
[spark-rapids-private 23.10] Java release to sonatype
2023-10-13
2023-10-13
@NvTimLiu

- [ ]
[spark-rapids-jni 23.10] Java release to sonatype
2023-10-13
2023-10-13
@NvTimLiu

- [ ]
[cudf 23.10] Java release to sonatype
2023-10-13
2022-10-13
@NvTimLiu

- [ ]
Notify RAPIDS team of javadocs for 23.10
2023-10-16
2023-10-16
@GaryShen2008

Staging release

- [ ]
Make 23.12 the default branch
2023-10-16
2023-10-16
@jlowe

- [ ]
Merge all remaining branch-23.10 PRs
2023-10-20
2022-10-20
Team

- [ ]
Update spark-rapids-jni dependency version
2023-10-20
2023-10-20
@pxLi

- [ ]
Create CHANGELOG.md
2023-10-20
2023-10-20
@pxLi

- [ ]
Deliver Snapshot packages to QA
2023-10-16
2023-10-16
@NvTimLiu

- [ ]
Create a PR (not squashed) to merge from branch-23.08 to main. Needs review from repository owner
2023-10-13
2023-10-13
@NvTimLiu

- [ ]
Trigger the release Jenkins job on the main branch and deploy the jar to sonatype staging (including spark-rapids-tools/core)
2023-10-17
2023-10-17
@NvTimLiu

- [ ]
Deliver final packages to QA
2023-10-17
2023-10-17
@NvTimLiu

- [ ]
Run integration tests on staging jars with AQE on, UCX on, Databricks Azure, Databricks AWS, Dataproc
2023-10-17
2023-10-23
@NvTimLiu

- [ ]
Run LHA tests on staging jars
2023-10-17
2023-10-23
@NvTimLiu

- [ ]
CDH testing
2023-10-12
2023-10-17
@GaryShen2008

- [ ]
QA testing with Snapshot on YARN, NGC with Volta and Ampere
2023-10-16
2022-10-18
@yuange98

- [ ]
Run pre-processing workflow for DLRM sample use case
2023-10-17
2023-10-23
@johnzhong

- [ ]
QA testing with final packages on YARN, NGC with Volta and Ampere
2023-10-17
2023-10-23
@yuange98

Release

- [ ]
Tag the release and deploy the staging artifacts to maven central repository
2023-10-25
2023-10-25
@NvTimLiu

- [ ]
Update gh-pages
2023-10-25
2023-10-25
@nvliyuan

- [ ]
Test spark-rapids-examples repo with Spark-Rapids 23.10
2023-10-23
2023-10-25
@nvliyuan

- [ ]
Update docs for current release in spark-rapids-examples
2023-10-23
2023-10-25
@nvliyuan

- [ ]
Update spark-rapids.sh in https://github.com/GoogleCloudDataproc/initialization-actions/tree/master/spark-rapids for the plugin
2023-10-23
2023-10-25
@nvliyuan

the timeline is messed up like 23.08 one, most items are conflicting w/ others.
@caryr35 @mattahrens can you help check what may be the issue? The template that was used for 2308 and 2310 is not correct, thanks


Does this work with the official opencv3 python bindings as well

I'm trying to use this in NixOS, and having to package every single opencv variant on pypi is difficult. NixOS has the proper opencv3 package that exports python bindings. Does imgaug just work with that without having to install opencv-python-headless?

Just tried with OpenCV 3.4.7 compiled from their github repo and I all tests ran through successfully, so as far as I can tell it should work with a proper installation of OpenCV 3 too and not just with opencv-python.

That's awesome. The only problem is that the requirements.txt specifies exactly this unofficial opencv bindings. That means our package script will need to remove that line to avoid the Nix build system from trying to acquire the unofficial package.

Fixed here: https://github.com/NixOS/nixpkgs/pull/67494

Closed this, but wondering if it has relationship to #611.


Cannot run create_tasks.py for qa3 task

Hi, all other tasks I have tried work fine, but for qa3, it generates the 0k set fine, and then this happens when generating the 1k set:
  File "/usr/local/home/santiontanon/my-research/babilong/data/./create_tasks.py", line 73, in <module>
    samples = [dataset_test[i] for i in inds]
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/home/santiontanon/my-research/babilong/data/./create_tasks.py", line 73, in <listcomp>
    samples = [dataset_test[i] for i in inds]
               ~~~~~~~~~~~~^^^
  File "/usr/local/home/santiontanon/my-research/babilong/data/../babilong/babilong_utils.py", line 181, in __getitem__
    sample = self.task_dataset[ind]
             ~~~~~~~~~~~~~~~~~^^^^^
  File "/usr/local/home/santiontanon/my-research/babilong/data/../babilong/babilong_utils.py", line 78, in __getitem__
    references = slc[slc.phrase_num.isin(slc.reference_num.values[-1])].text.values
                                         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^
IndexError: index -1 is out of bounds for axis 0 with size 0

I just did git clone, installed prerequisites and ran python create_tasks.py qa3_three-supporting-facts

Hi, thanks for pointing this out! I made a fix in this commit:  dab48b4

Thanks! I just tested this and it works now! Thanks for the quick fix!


Don't ask for full files access

Describe the problem
Don't need that to allow auto download.
Describe the solution
Don't need that to allow auto download.

I'm not sure I understand.
What kind of file access should be granted?

Look at this screenshot : postimg . cc/RJJWCsHw
Everytime we want to download 1 pic or 1 vid, it asks for full phone files access. But then if we deny, it actually saves the file anyway. So, just stop asking for full files access all along .

I agree, full files special permission is completely inappropriate for this app


Fix newsroom deploys and Add Article - Bitcoin Cash Node 2020 - spanish

For #114 and #122

Closing as already merged


Open folder from explorer by context menu

It would be nice if I could open a folder from the Explorer directly by adding a button to the context menu. This would prevent me from having to use the Open Folder function and going through the native file explorer all over again.

Does this extension do what you want?
https://marketplace.visualstudio.com/items?itemName=chrisdias.vscode-opennewinstance

Does this extension do what you want?
https://marketplace.visualstudio.com/items?itemName=chrisdias.vscode-opennewinstance

That's pretty nice! But I wonder if it could be integrated into vs code itself. For a feature so simple, it would be great to have native support.


Implementing DTX

Could you add support for DTX?
https://opus-codec.org/docs/opus_api-1.3.1/group__opus__encoderctls.html#ga4f053b2db8c5162293213aabfe123773
https://opus-codec.org/docs/opus_api-1.3.1/group__opus__encoderctls.html#gaafbb44454e9f57232b85e4e087337ded
Thank you for maintaining this fork and package!

I added a PR

Wow, thanks for your contribution!


Is it possible to set any filter state?

I'm writing a custom L4 filter for Envoy using this sdk, however I'm not able to set filter state envoy.tcp_proxy.cluster to dynamically select upstream cluster when chaining with tcp_proxy filter. From envoy source it looks like when using setProperty it always prefixes the key with wasm..
Is there a way to set custom filter_state?

no it's not possible due to envoy impl.


Kacper murzyn/codeowners action

What does this PR do?
This PR adds a GH Action that affects all new PRs on main branch - it adds a team label based on the CODEOWNERS file content.
Motivation
Action item after 7.31.1 post mortem: https://datadoghq.atlassian.net/browse/AGENTR-25
Additional Notes
This actions uses fork of https://github.com/pratikmallya/autolabeler-codeowners - the only change is related to DD specific labels that we use to mark teams. Original workflow copies blindly entries from CODEOWNERS (so @DataDog/agent-all for example), changes in the fork replace @DataDog with team.
Possible Drawbacks / Trade-offs
In case there would be changes made by one team to the file, being owned by the other team - this action is going to put owning team label on the PR, therefore requesting this teams QA effort during release creation. It has to be double checked whether it's really what we want to go for, as it requires owning team to remember to remove the label if necessary (additional step that can be forgotten).
The other element to rethink - this PR references workflow that is currently hosted as a public repository in my private space. We should decide whether this approach is acceptable, if so - maybe move the repo to the DD space.
Describe how to test/QA your changes
Workflow was tested on couple of testing PRs with different files change (having single, multiple and no owners according to CODEOWNERS).
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The appropriate team/.. label has been applied, if known.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

This is no longer desired to be done this way. PR is obsolete.


Unable to render react components into PDF

Thank you for submitting an issue to jsPDF. Please read carefully.
Are you using the latest version of jsPDF?
Yes
Have you tried using jspdf.debug.js?
No
What I saw
jsPDF does not render the react components into pdf. Is this functionality not provided or am I making any mistake in writing the code?

            <HelloWorld name="Rambo"/>
            <HelloWorld name="Riya"/>
            <HelloWorld name="Rose"/>

Is it converted?!

HTML to PDF

Lorem ipsum dolor sit amet, consectetur adipisicing

          <button>Hi, Click me</button>

        <button onClick={this.pdfToHTML}>Download PDF</button>

When the above code is written in render() , all the components and tags are displayed in the browser. But when download the pdf, neither the buttons nor react components are getting converted.

Too abstract. Please provide an test case on jsfiddle or jsbin. Thanks.

For the above code, the webpage I get is:

But when I download PDF , I get the following output:
html2pdf (7).pdf
By looking at the two, you can know that the button and react components HelloWorld are not present in the PDF.

I never worked with react so i dont know how the deeper functionality behind it. But probably it doesnt work, because you use unsupported custom html-tags. You have to write your own renderer for your custom tags.

Oh, Ohkay. Thanks!

@steric85 I've just came across this issue as well and t's actually possible to just use ReactDOMServer (imported from 'react-dom/server') and its function renderToStaticMarkup(component) to make html that jsPDF will accept.

@steric85, can you show me an example with react? i did use renderToStaticMarkup but it only printed the  and etc ...
jspdf.text(ReactDOMServer.renderToStaticMarkup(<ResumeContent />), 10, 10, {'width': 180})

@iqbalsafian, you use .fromHTML() instead of .text()
jspdf.fromHTML(ReactDOMServer.renderToStaticMarkup(<ResumeContent />), 10, 10, {'width': 180})

I've tried and the result lost all the styles in the components. This is the normal behaviour?

If you mean, that you had CSS3 and used fromHTML, then yes.