We need a contribution guide, issue and bug report templates

So, I guess we first need to figure out the contribution rules.
And what are issue and bug report templates? I've seen a kind of check lists:

[ ] I haven't found info in the docs
[ ] I've tried it on Linux
[ ] I've tried it on the latest version

Do you mean these things?

a monday ping, sir

@VasilyStrelyaev
Contribution rules:

First create an issue (if there is no issue already for the given bug/functionality).  It may be functionality that unlikely will be landed or bug fix require some bikeshedding, so to avoid doing job that will not be used it's a good idea to discuss functionality and bug details with core team before submitting the PR.
Fork testcafe and create a branch named against the issue number, e.g. gh852, gh853
Commit your changes into the branch
Bug fixes should have regression tests added into the appropriate sections (search for Regression via code). New functionality should be tested as well
Fetch upstream changes and rebase your branch onto master
Run tests: gulp test-server, gulp test-functional-local, gulp test-client before submitting a PR and ensure that everything works properly
Push changes to your fork
Submit a PR. PR name should describe what was done in pull request and contain closes directive with appropriate issue number. Documentation PRs should have [docs] prefix in their title.
Use separate PRs for documentation and functionality

GitHub supports issue templates: https://help.github.com/articles/creating-an-issue-template-for-your-repository/
Required information for the bug report:

Operating system
testcafe version
node version
Test code
Tested page URL
Expected behavior
Actual behavior


labels

Why do event frames with height==240 only have cars and pedestrians in the label map, and do not include trucks, bus, two-wheeler etc? see vis_utils.py file lines 18,19.

Because this work uses the Prophesee GEN1 dataset, which only includes cars and pedestrians. The other labels you mention are part of the Prophesee 1MPX dataset.


As a repo contributor, I want to be able to install and run all code locally, so that I can actively contribute.

Description
This is about making sure internal and external contributors can onboard to the codebase quickly and easily.
Solution

[x] Add clear install steps and dependencies to the README.
[ ] Containerize app so that it's easily portable across machines.

Describe alternatives you've considered
N/A
Links to user research or other resources
N/A
Definition of "Done"

[ ] A new developer confirms they can get up and running locally with the code base in a container with no support from a team member

There is a push and pull here with github actions, which uses its own container.
There is the tool act that let you run gha locally in docker, but this seems a bit imperfect, and has a few limitations, like not allowing you to use the upload/download actions...
Something like this setup would work locally - we would want both dev and prod variants - and I've been experimenting with this. It has the added benefit of abstracting away local dev environment, which has already caused a few headaches. We should probably do this anyway.
A remaining task is to bundle together all the checks currently run on gha so we can run them locally as well.
We should timebox this - simplest is to update readme, second most is to add a single action that runs all CI actions, third most is to create a local dev docker container, hardest is to unite these together. I can progress through these in this order this afternoon and see how far I get.

@ginabeena - this card is related to the convo we had today on adding install steps, etc, to the README.

yeah, thanks for assigning :) I'll be commenting on this and working through it @NatHillardUSDS @switzersc-usds

Any one else getting transitive dependency issues during npm install in /client right now? I'm getting issues resolving from the lock. I can paste node v16.3.0 and npm v 7.15.1

We've been on v14.17.0 because Trussworks seems to require a version <14 - the format of the lockfile and the way dependencies are resolved appears to have changed between those versions . With 14.17.0 at least I'm not seeing these issues, can you try with that?

@NatHillardUSDS @ginabeena status here?


UWP ToInAppBillingPurchase XmlException

Version Number of Plugin: v<IP_ADDRESS>-beta
Device Tested On: Windows Phone
Version of VS: 2015
Version of Xamarin: Forms <IP_ADDRESS>-pre3
Sorry, don't have steps. But this error only occurs when the Windows store returns a non-XML error response. If there is no Windows store error, the control works great.

What is the call stack?
Is it returning a failure of the purchase?

Unfortunately, I don’t have a usable call stack. Just the exception:
Plugin.InAppBilling.Abstractions.InAppBillingPurchaseException: Unable to process purchase.
I did manage to see this in the debugger once. The problem is that Microsoft does not return XML for the failure. It returns a non-XML error message (“Unable to process purchase”), so the XML parser fails.

Ah, I see, but kind of the result is expected that it throws an exception though.  It should have an enum on it that says the issue. In this instance you would catch the exception and have the user try to purchase it again. I think it is pretty correct, maybe could tidy it up a bit...

Yes, I am catching the exception and that works. I just wanted to point it out in case you didn't know about it and thought it should be handled differently. Thanks for the great control!


Upload source for 1.2 to PyPI

Please upload the source for 1.2 to PyPI so that the package can be used on non-x86 platforms and on future versions of Python like 3.13. Currently pip is forced to go back to bfloat16 1.1 on these systems which doesn't contain the recent fixes.

Bump, please.


Set custom cookie Max-Age

Hi, i use opendistro for elasticsearch.
After 1h inactive in interface i need to login again,  i want to increase this timeout
is it possible to configure it?
i use ldap authorization
set-cookie: security_authentication=Fe26.2825c7bb605a776758bbed010d99af2930f13dbd16265bdf5f7042dfda81ca910yEcrEdmu8wDHrKOb0yBtYQbxogIjV4NLzjHUK_2IJXvmXq1bxnQJ_iSJj-1qtOALGUAJaIXuS_VOKfu4fTTgajqKMl3B0G3TiH1a-_aKe04s61MfsTIOK1eXEezT4xipI8Qf8ONo9RnjCzW_3Ih21ZASqlFKUtaU42my577T0jGHTGr-DDxf655wh719TOESylhXzH1-QGo8a0mROKpdYHQoY7EcbvgTOsrZjq1ZXROLGHTLEuP9VC4jU1grKoSJk098b3b2bf35cc56a5920628aa5aad7da9ce323c04de3c284bdf66c6db9ded9d1*hT-vlP2OglYA6RAdeMN9tN2OvGr7G3kFtW7_2buB1ho; ### Max-Age=3600; Expires=Thu, 06 Jun 2019 10:12:13

We are doing some "spring cleaning in the fall", and to make sure we focus our energies on the right issues and we get a better picture of the state of the repo, we are closing all issues that we are carrying over from the ODFE era (ODFE is no longer supported/maintained, see post here).
If you believe this issue should still be considered for current versions of OpenSearch, apologies! Please let us know by re-opening it.
Thanks!


Publish the tracespan docs, since the stackdriver docs reference it.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid,geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
19ff376c7ab7ce44f3f4d562443d7a2773a42cd6
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add support for ignore pattern for LineLength cop

👋 We generally like and enforce the LineLength cop, but there are certain contexts where it's not ideal.
Proposal
My proposal is an IgnoredPatterns option which is an array of regexps. If any of these match a line, the line length cop is skipped.
Metrics/LineLength:
  Enabled: true
  Max: 120
  IgnoredPatterns:
    - '^\s*test\s.*'

Alternatives
There's two existing ways to deal with this (that I know of):

comments to disable the cop
ignore an entire file

Our main use case is ignore line lengths for test/spec descriptions.
Examples:
def test_some_really_long_minitest_test_method_name
end

test 'some really long test description which exceeds length' do
end

It's not ideal to have comments around every test method/description, or to ignore the file entirely.
Solution
I've already made a custom cop that implements this here: https://gist.github.com/swalkinshaw/c540a59b4983b335149c2f6fde69e7b9
I'd be happy to implement this via a PR in the existing LineLength cop if it's wanted.

I'm on the fence about this. Typically I just suggest people to allow longer lines in their tests. (you can have different config files in different folders)
I'm curious to hear about thoughts on the subject.

Yeah I agree it's a slippery slope. Ideally we still want to enforce line length on the test bodies since it's just code and we want to keep it readable. Unfortunately there's just no nice/readable way to make test descriptions multi-line to play by the rules.
So we're left in a weird situation where there are a few legitimate contexts where longer lines should be allowed and they happen consistently enough.
I can only speak for Shopify, but this has come up multiple times with developers asking if there's a way to disable this rule for test/spec descriptions. We have an issue on our styleguide with 35 comments so far about this issue :)
In case this feature doesn't make it in, I have an alternative proposal. I'm perfectly happy making custom cops but right now it's harder since you can't inherit from an existing one.
Please correct me if I'm wrong, but the way all cops are tracked right now via inherited doesn't allow subclassing LineLength for example.
An alternate method to track class descendants might make this more flexible.


Add htop and tmux to image

These tools are helpful for using the backend for code editing and notebook monitoring:
htop :  a task manager, useful for viewing resource consumption
tmux : a multi-window virtual console tool

next time - wait for a review.


Admin features

[ ] Admin auth
[ ] User auth (enable/disable)
[ ] Room permission (per user)
[ ] Admin dashboard (usage, user management)

The public server will always be free and anon, but I can see some use cases for this. Low priority unless requested.

faster pls


feat: use affix sidebar for editor sidebar

Summary

This PR migrates the editor right sidebar to use the Affix component, which will scroll the sidebar content together with the main content.
With this changes, all right sidebars are now migrated to Affix
How to test

Go to http://localhost:8080/#/s:test.wa0x6e.eth/create
The right sidebar should scroll using same behavior as the proposal page sidebar (stop scrolling when reaching top/bottom)

This PR migrates the editor right sidebar to use the Affix component,

whats a Affix component? 🤔 I missed some context 😄

This PR migrates the editor right sidebar to use the Affix component,

whats a Affix component? 🤔 I missed some context 😄

Affix component was introduced here https://github.com/snapshot-labs/sx-monorepo/pull/686
To have the sidebar scroll sync with the main content when needed.


envbuilder caches repo

Is it possible to disable the /workspace cache of a coder build with envbuilder.
Even after restart work spaces it caches to old commit
#1: 📦 Cloning https://bitbucket.org/lorem/repo.git to /workspaces/ipsum..
#1: 👤 Using no authentication!
#1: 📦 The repository already exists! [672.333µs]

What should envbuilder do in this case if the repository contains uncommitted changes?
Should it still fetch changes from the remote?

Couldn't it check for local changes? I had this when the devcontainer build failed and I fixed it in the repo, but I had to destroy the workspace because I couldn't update it easily obviously.

@megla-tlanghorst would the --remote-repo-build-mode option we recently introduced cover your use-case?
Automatically updating the users repo is an interesting proposition too, though. There are some caveats though:

What do we consider dirty? Uncommitted changes? Untracked files?
What do we do if there's an error? I.e. untracked file -> pull -> conflict
What if the user was working on a specific feature but since we pulled the changes they're no longer sure where they were (if it's an opt-in option, the onus is on the user, but it's still a potentially bad experience)

@megla-tlanghorst would the --remote-repo-build-mode option we recently introduced cover your use-case?

Maybe, that's what I'm currently testing.

Alternative possibility is add -> stash -> pull -> unstash. This does run the risk of users being left to clean up a nasty merge conflict though.

Parking this for now due to some open questions:

Do we fetch and checkout versus pull --ff-only? The former seems safer to me.
What do we do in case of local changes? It seems reasonable to just skip fetching updates completely if the worktree is dirty, but is this the behaviour that users expect?
What should we do if a user attempts to clone a different Git repo into an existing one? Right now, we just skip cloning altogether if we detect an existing repo. Should we update the existing repo, or bail entirely?
What if the pre-existing repo has a different remote configured? Which remote do we use? The same as ENVBUILDER_GIT_URL?

@johnstcn I think we should only operate on a clean repository with the default/configured branch checked out. If a user has local changes or a custom branch checked out then we must assume they were in the middle of doing something, and we can't risk removing their anchor, or worse, introduce merge conflicts.
We can instead add a destructive option which simply overwrites the whole repository (delete + new checkout). This is for anyone who wants the workspaces to be ephemeral, but still uses a permanent storage for some reason.

@mafredri One other scenario I could imagine is that a different git repo is cloned to the path into which we wish to clone. Do you think it's sufficient to check that the URL of the remote "origin" is the same  as ENVBUILDER_GIT_URL (after parsing / normalization)?

If I'm understanding you correct, I'd say yeah we want to do that. Essentially we want to check that the remote of the currently checked out branch matches that of envbuilder git URL (name, like "origin" shouldn't matter). If the envbuilder git URL specifies a branch, the currently checked out branch should match as well (match by the remote tracking branch, not necessarily local name). Assuming the repo is clean1 too, we can update.
1 Clean repo means no changes to tracked files, untracked files should be safe to ignore as I think users wouldn't want those to block the update in most cases.

Co-assigning @SasSwart to continue/take over the WIP PR.


Use TagSpecification parameter on EC2 create_node

Take advantage of AWS EC2 tag-on-create feature
Description
This small patch changes the way EC2 compute nodes are tagged when created, by adding the tags on the creation call instead of doing it immediately after. This avoids eventual consistency issues that sometimes happen when an instance isn't created yet so it can't be tagged.
For reference, the AWS docs are here: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_RunInstances.html
This PR would tackle a colleague of mine has reported some weeks ago:
https://issues.apache.org/jira/browse/LIBCLOUD-930
Status

done, ready for review

Checklist (tick everything that applies)

[ ] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[X] ICLA (required for bigger changes) (I've just submitted it.)

Coverage decreased (-0.004%) to 88.971% when pulling 379cfe7e4cce5209b6353e3087bc3131671a9924 on curoverse:apache-libcloud-2.2.0.dev1 into 84735c8924f75394426e37106ed7db5070dd0071 on apache:trunk.

Coverage decreased (-0.0009%) to 88.974% when pulling 386456c245a3518254f5f6a045832ceb6451e486 on curoverse:apache-libcloud-2.2.0.dev1 into 84735c8924f75394426e37106ed7db5070dd0071 on apache:trunk.

Coverage decreased (-0.004%) to 88.971% when pulling f9118e8d62825e42fd155b387bcdf8472f089783 on curoverse:apache-libcloud-2.2.0.dev1 into 84735c8924f75394426e37106ed7db5070dd0071 on apache:trunk.

👍
A few notes:

Please prepend the title of your PR with [LIBCLOUD-930]
There's an unrelated change in init.py
Please remove _idempotent_CreateTags and _services_Eucalyptus_CreateTags in libcloud/test/compute/test_ec2.py

Coverage increased (+0.003%) to 88.978% when pulling 6f0d3aa6d3b5d9db58a998a91ad1088ff3fe6413 on curoverse:apache-libcloud-2.2.0.dev1 into 84735c8924f75394426e37106ed7db5070dd0071 on apache:trunk.

Looks good to me. Thanks!

thanks for your contribution @ldipenti 👍

This fixed https://issues.apache.org/jira/browse/LIBCLOUD-930


Implementing Test Cases

Implementing Test cases in the SDK

@ahujadhruv : This might be useful : https://github.com/Codium-ai/cover-agent


When I use air_gap arg, it does nothing, but gradually freezes my computer

overview
This issue is for:

[x] Bug, feature request, or other (if other, please describe below)? BUG
[x] API, App, both? API
[x] Version? 2.5.0
[x] OS and OS version? Linux Mint 18.1 Serena

expected or desired behavior
Don't crash when I use the air_gap arg :angry: :sob:
actual behavior
When I use air_gap in a transfer, and then run that .py with python on the command line, it gets stuck on that command. My computer slows down and eventually freezes.
steps to reproduce problem
Run this in python:
from opentrons import containers, instruments

p200rack = containers.load('tiprack-200ul', 'A1')
plate = containers.load('96-PCR-tall', 'C1')
trash = containers.load('trash-box', 'A2')

p200_multi = instruments.Pipette(
    axis="a",
    max_volume=200,
    min_volume=20,
    trash_container=trash,
    tip_racks=[p200rack],
    channels=8
)

print("looks good so far")
p200_multi.transfer(
    200,
    plate.rows(0),
    trash,
    air_gap=100  # if you comment this out, it runs fine. If left uncommented, it crashes
    )
print("this never prints")

That example is with an 8-channel -- I have the same problem with a single-channel, too.

@IanLondon i was not able to reproduce the problem. Do you think it's specific to Linux Mint 18.1 Serena?
Tried on mac os x tag 2.5.0 and branch v3a

Unable to reproduce on OSX 10.12.6 and Ubuntu 16.06 with python 3.5.3 and 3.6.1. Tried against opentrons API PyPi 2.5.0, 2.5.2 and current v3a

@zubrabubra
I think the problem was that my calibrations were corrupted (see #306 ), so it was silently using a pipette with a volume of 100. With a pipette of max vol 100 and air_gap=100 you get the error you fixed in #421 !

@IanLondon can this issue be closed?

Seems like we're unable to reproduce, so closing this issue

I can still do
p200.transfer(200, plate[0], plate[1], air_gap=1000)
and get it to hang instead of throw an error.
It's not a linux-only, see https://github.com/Opentrons/opentrons/pull/421 -- infinite while loop

Happens on v2 also:
metadata = {'apiLevel': '2.0'}

def run(ctx):
    tiprack = ctx.load_labware("opentrons_96_tiprack_300ul", "1")
    right = ctx.load_instrument("p300_multi", "right", tip_racks=[tiprack])
    plate = ctx.load_labware('corning_96_wellplate_360ul_flat', '2')
    right.transfer(200, plate['A1'], plate['A2'], air_gap=1000)


feat(input): add copy functionality for context menu

What this PR does 📖

title

Which issue(s) this PR fixes 🔨

Resolve #602

Special notes for reviewers 🗒

I see we use arboard in another place, but I couldn't get the import to work. no idea why
i switched value to mandatory. I doubt we will ever have an input that isn't plugged into some kind of parent component state

Additional comments 🎤

While testing I found a small issue, there are some area's of the app that it doesn't seem to copy text from. In screen recording I try copying text from chat text box and the Settings Search bar but couldn't get it to work.
https://user-images.githubusercontent.com/93608357/207380499-0961110a-6482-4c2e-8eca-71ac2ed12f6f.mov
https://user-images.githubusercontent.com/93608357/207382317-7877f5d3-50d3-4e35-a514-917d9bd03040.mov

this might be OS specific, let's put it on hold for a min might be able to fix with the crate

The chat bar would need a separate implementation. This is strictly related to the standard input component


Add docs badge to README

Hi there,
this patch adds a docs badge to the README to show off inline-documentation to potential contributors:
The badge links to Inch CI, a project that tries to raise the visibility of inline-docs to encourage aspiring Rubyists to document their code. Your status page is http://inch-ci.org/github/causes/overcommit/
What do you think?

Thanks for the pull request, @rrrene.
I've merged this in b0c6beb766993f5ed4091250a2c722dff2901a60.


Fixing release notes path for 2.9

Description
Looks like 2.9 release notes were put in https://github.com/saratvemulapalli/job-scheduler/blob/main/release-notes/release-notes/opensearch.job-scheduler.release-notes-<IP_ADDRESS>.md which is why workflow failed to release it: https://github.com/opensearch-project/job-scheduler/actions/runs/5649165701/job/15302930573
Also fixed main build broken due to: https://github.com/opensearch-project/OpenSearch/pull/8636/
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This will need a rebase after the sample extension BWC version is bumped up to 2.10.0, BWC tests are currently failing due to main still using 2.9

Yup just rebased with main.


How to use the GET /search function?

There is a field for name and submission ID, but I'm not sure how to get faexport to work with the search query.
I've tried https://furaffinityapi.herokuapp.com/search/q=birdo.xml and https://furaffinityapi.herokuapp.com/search/birdo.xml
but it returned a "Not Found".

Try https://furaffinityapi.herokuapp.com/search.xml?q=birdo

Ayy, there we go, thanks!
I was hoping I can figure out if I can make an rss feed of search results, as various artists may create art related to the search term instead of just one artist (e.g. commisions). I'm going to have a try, and I think it might be possible by parsing the GET /search into an rss feed.
If you have any ideas, that would be great!

I was hoping I can figure out if I can make an rss feed of search results
Added in ec553199832914cbd2144947c10179dae6653bc1 check out http://faexport.boothale.net/search.rss?q=birdo for an example

Seems to work on that site for me.  Try again, it might have timed out due to heavy traffic.

Must be. I tried it now and it works. With other search terms I have to wait a while after requesting for it to return the results.
Thanks a ton for this API by the way!

With other search terms I have to wait a while after requesting for it to return the results.

It has to scrape a separate page for every submission which can take a while. After that they stay cached so it only has to check for new submissions (and loads faster).

Thanks a ton for this API by the way!


Pull location display label in Blacklight from external_name

Patrons in Blacklight need to see a different label from staff in the Alma UI. See https://github.com/pulibrary/bibdata/issues/1166

closed by #1182


[tests] Failing WithDockerfileTests

Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=714585
Failing tests
Aspire.Hosting.Containers.Tests.WithDockerfileTests.AddDockerfileLaunchesContainerSuccessfully
Aspire.Hosting.Containers.Tests.WithDockerfileTests.AddDockerfileWithParameterLaunchesContainerSuccessfully
Aspire.Hosting.Containers.Tests.WithDockerfileTests.WithBuildSecretPopulatesSecretFilesCorrectly
Also, WithDockerfileWithParameterLaunchesContainerSuccessfully -build.
These tests have been failing on CI with:
Polly.Timeout.TimeoutRejectedException : The operation didn't complete within the allowed timeout of '00:00:30'.
---- System.Threading.Tasks.TaskCanceledException : The operation was canceled.
-------- System.IO.IOException : Unable to read data from the transport connection: Operation canceled.
------------ System.Net.Sockets.SocketException : Operation canceled

@mitchdenny

Report
Summary

24-Hour Hit Count
7-Day Hit Count
1-Month Count

0
0
0

Tests disabled in https://github.com/dotnet/aspire/pull/4614 .

Looking at the history, this looked to start failing at a very specific moment in time:

Back tracking to see what changed so we can get these tests running again.


feat: add get options

Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] spec PR link included
[ ] Follows the commit message standard
[x] Meets the contributing guidelines (including
functionality, content, code)
[x] Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

因为代码没有 rebase 到最新的 main 分支，所以单元测试覆盖率降低了0.1%.
实际我新增的代码都是覆盖到了，不会造成覆盖率降低。
我先合并。


Approach for incorporating external samples

In last standup the following was identified:

Should have a way for folks to have their Samples in the KEDA repo. Anirudh to follow up

We should provide and document an approach for external samples.

@rasavant-ms @anirudhgarg Was anything more than that discussed?
I see two types of samples:

The ones we maintain today, or are happy to take over and maintain
External ones provided by folks in the community

Would you want to open it up for everbody to move their repo in our org? If so, how will we keep them all up to date?
What if we use https://github.com/kedacore/samples as an incubation where folks can PR their sample in. If folks are interested, they can log an issue there saying they want to donate it and we can evaluate it so that:

We don't already have a similar sample
We have bandwidth to keep it up to date

The reason why I'm skeptical is that we don't perse have to own all the repos as others have done the hard work, it's less work for us to keepe them up to date and our org would become huge.

@tomkerkhove thanks for chiming in.
Currently we have the following ways we are handling samples:
1). We have a samples repo which is basically a link file (linking to different samples)
2). Repos within KEDA org where every repo is a sample
The ask was that if we could also have Samples within the Samples repo (instead of creating a whole repo for a Sample). I think it makes sense as you too pointed out that we should allow folks to submit PR's to the Samples repo and add their Samples there as to not increase the number of repos in the org itself.
Looks like you agree to this - so @rasavant-ms  feel free to submit a PR on the Samples repo with your sample - we can take this as a test to see how it works out.
Basically the ask was that if folks can also use (if they want to) the samples repo to host their samples themselves - currently its a single page with links to samples.

Ah so your idea is to host the content in that repo as well then? What is the reasoning behind that?
Wouldn't that become a big pile of sample dump over time?
Let me ask it otherwise, why does Azure have a repo per sample for example and not one repo with all samples in it?
My suggestion with the PR was more to include a like to their repo, or file an issue as a proposal to donate.
The risk I see is that we end up with a ton of samples which are no longer maintained which is bad from a product perspective.

Why not allow people to submit a PR to link their own repos as samples into the sample repo? And divide the list between internally maintained samples and community/externally provided ones? I was thinking we could submit an example of what we are doing with redis and this would work easy enough for me..

We have https://github.com/kedacore/samples nowadays, closing


zkvm: implement Taproot

Implements the Taproot proposal to store smart contracts in place of the predicate tree. Closes #248 .

@debnil Per my comments about not parsing the program prematurely, we'd probably need a enum ProgramWitness (or smth like that) that holds either ::Opaque(Vec<u8>) (on the verifier's end) or ::Program(Program). This way, impls like MerkleItem can implement hashing both for prover and verifier.

Final note: ProgramWitness sounds like it's non-opaque because it's "witness" (which is unavailable in opaque variants by definition).
Let's find a better name for it, like ProgramItem (and therefore, Data::to_program_item). And its variants named ::Bytecode(Vec<u8>) and ::Program(Program).


System columns

PR to run tests

@RFSH  changes are complete. All tests are passing as we expect them too. Let's talk about a strategy for merging these 3 branches on monday. I'm thinking we want to merge the system columns branch for ermrestDataUtils first. Update ermrestJS travis.yml to point to master for ermrestDataUtils and let the build pass (hopefully). Then we can merge ermrestJS, and I can make the change to travis.yml in chaise and hopefully that build passes and we are good to merge to master.

With the increase of runtime, I ran some experiments in chaise and ermrestjs to just find where we should improve and whether we should be worried now about the time limit or not. You can find the summary in here
We should start the process of merging this branch.


stars package

getOmernikSite() to get ecoregion for each site's location gives error for not having stars package
Works after downloading package

added to necessary list of packages in geospatial_for_conus_waters.RMD


Kotest upgrade

Please have a look at the individual commit messages for the details.

Merging despite the unrelated AskalonoScannerTest failure on AppVeyor due to a socket timeout.


⚠ Bofrost.de has degraded performance

In 2493d14, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1271 ms

Resolved: Bofrost.de performance has improved in fa5e1af after 13 minutes.


[Mod Compat] 1.20.1 CREATE machanical crafting recipies, crushing wheel recipies, Sequenced Assembly recipies not showing up when clicking the blocks inside of the EMI menu

If this issue is related to compatibility with other mods, such as missing recipes, make sure to follow these steps before reporting

[x] Make sure the recipe exists in game and can be crafted
[x] If the mod requires JEI, make sure both EMI and JEI are installed together
[x] Report this issue to the mod if applicable

The mod may require jei. but when i have it installed next to emi it doesnt work.
if i only have jei installed it works

Recipes are showing up on the latest versions of EMI, JEI, and Create


Website redesign

Website issues
Discussion points

[x] list upcoming planned workshops
[x] make clear that there is follow-up funding
[x] create historical section with:

[x] funding partners up to 2021
[ ] training hubs

[x] make clear that gitlab will most likely continue
[x] Home: lead text mentions future activities for a) learners b) volunteers c) institutions
[x] define benefits and show how people can contribute
[x] differentiate "tiers", e.g.: hackmd is available to partners, or an exercise review session is available ...
[ ] who we are:

official consortium partners are a basis
"community champions"

[x] list what we want to happen instead of how it is right now

Structure and contents

[x] Top page:

[x] Vision, inclusive image
[x] Upcoming workshops
[x] How to keep informed
[x] give hints on what persons/orgs can do to help/prepare/stay in touch
[x] Logos of the funders/partners at the bottom (or somewhere) like at https://fair-software.nl/endorse

logos of supporters as well?

[x] positive feedback carrousel

[x] Get involved (becomes a menu)

[x] Get involved(how to join?)

[x] Light-weight!
[x] move "to the left" right after "home"
[x] Concrete: where, how
[x] Hierarchy/steps

Helper
Bring your team
Co-teach
involve orgs etc.?

[x] Subpages of "who we are", "Instructors and helpers", "Funding partners", "Training hubs"
[x] Meeting minutes

[ ] About

[x] meeting minutes -> move under "get involved"
[ ] project

[ ] write new and then check old page whether anything important got forgotten
[ ] split up into history, present, strategy/future
[ ] rewrite objectives from "project owner perspective" to community perspective

[x] history
[ ] strategy: "in 5 years we will be at ..."
[ ] where we are now
[x] Articles and Reports → move to bottom of "About"
[x] move instructors/helpers, "who we are", "Funding partners", "Training hubs" under "get involved"
[ ] describe also what they do and why one would like to do that
[ ] Who we are

example: https://jupyterhub-team-compass.readthedocs.io/en/latest/team.html
example: https://carpentries.org/governance/
https://jupyter.org/about

[x] Workshps/events
[x] Lessons

[x] Separate currently running and
[x] Make more clear that some lessons are outdated but could be revived by somebody ("special topics")
[x] Merge "Resources"
[x] Make clearer which lessons are part of our 6 half-day workshop curriculum

could https://hands-on.coderefinery.org/coderefinery/ be the "virtual workshop list" page?

[x] Blog
[x] Code repository hosting

RB will edit

[x] Resources: -> move all of that close to relevant lessons
[x] Move "Funded by NeIC" somewhere into past/present funding
[x] Refine the interesting points on left of navbar and collect the less important to the right

I added one more thing: workshops/{impact,statistics} → about/ .  I added redirect pages since these are likely to be referred to by various reports and stuff.  (is there a way to do proper redirects?)

get-involved/ needed a section name, and somehow get-involved didn't seem right, so I named it organization.  perhaps there is a better way

I added one more thing: workshops/{impact,statistics} → about/ . I added redirect pages since these are likely to be referred to by various reports and stuff. (is there a way to do proper redirects?)

Example for proper redirects: #606

Some tasks I will convert to follow-up issues and mark the task as "done" (example: adding logos of funders/supporters as this will come later and no need to wait for it to be in place to resolve).

This big issue split up and followed up in #618, #619, and #620.


Check imported assistant instructions for illegal variables

Description

We now also check the assistant instructions for illegal variables for imported assistants
User Impact

Users will not be able to use non-supported variables in the prompts. This is good, since their assistant will not break when they try to chat to it anymore.
Demo

Example: this will show when you try and import an invalid one:

Docs

@coderabbitai full review please

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


comparison of Turbo Models

Hello,
I found in my testing that the turbo model of faster-whisper is slower than OpenAI's. I would like to know if my conclusion is correct?

openai/whisper-large-v3-turbo
mobiuslabsgmbh/faster-whisper-large-v3-turbo

Thanks.

I would like to know if my conclusion is correct?

Probably not, we don't know as you didn't share your benchmarking code.

I would like to know if my conclusion is correct?

Probably not, we don't know as you didn't share your benchmarking code.

faster-whisper

from jiwer import wer
from faster_whisper import WhisperModel
import time

path = "fast_whisper/model"
model = WhisperModel(path, device="cuda")

def transcribe(path):

    start = time.time()
    segments, info = model.transcribe(f'../data/commonvoice/cv-corpus-19.0-delta-2024-09-13/en/clips/{path}', language='en')
    try:
        segments = next(segments)
    except StopIteration:
        return time.time() - start, emptyContent()

    return time.time() - start, segments

data_dict = read_dataset_data_tsv()

total_video = 0
sum_wer = 0
sum_spend_time = 0

with open(f"fast_whisper/other.txt", "w", encoding='utf-8') as file:
    for key in data_dict.keys():

        spend_time, text = transcribe(key)
        ref_text = data_dict[key]

        sum_spend_time = sum_spend_time + spend_time

        wer_num = wer(ref_text.strip(), text.text.strip())

        total_video = total_video + 1
        sum_wer = sum_wer + wer_num

        file.write(f'{key}    {wer_num}\n{data_dict[key]}\n{text.text.strip()}\n\n')

    file.write(f"spend total infer time: {sum_spend_time}s  wer: {sum_wer/total_video}.\n")

whisper

import whisper
from pathlib import Path
from jiwer import wer
import time

model = whisper.load_model('turbo')

def transcribe(path):

    path = Path(f'../data/commonvoice/cv-corpus-19.0-delta-2024-09-13/en/clips/{path}')
    start = time.time()
    res = model.transcribe(str(path), language='en', verbose=True)
    return time.time() - start, res

data_dict = read_dataset_data_tsv()

total_video = 0
sum_wer = 0
sum_spend_time = 0
with open(f"whisper/{dataset}-{size}.txt", "w", encoding='utf-8') as file:
    for key in data_dict.keys():
        spend_time, text = transcribe(key)
        ref_text = data_dict[key]

        sum_spend_time = sum_spend_time + spend_time

        wer_num = wer(ref_text.strip(), text['text'].strip())

        total_video = total_video + 1
        sum_wer = sum_wer + wer_num

        file.write(f'{key}    {wer_num}\n{data_dict[key]}\n{text["text"].strip()}\n\n')

    file.write(f"spend total infer time: {sum_spend_time}s  wer: {sum_wer/total_video}.\n")

Thanks.

Add  compute_type="float16" to faster-whisper's model.
Add these to both transcribe() funcs: beam_size=5, temperature=0
Let's know the results.

Sorry, but the result hasn't changed much. i use commonvoice cv-corpus-19.0-delta-2024-09-13 en other for test.This dataset contains 32 hours of audio data.
The time spent on Faster Whisper has decreased from 4372 seconds to 4268 seconds, but it is much longer than Whisper's 3514 seconds.

faster-whisper

path = "fast_whisper/model"
model = WhisperModel(path, device="cuda", compute_type="float16")

def transcribe(path):
    start = time.time()
    segments, info = model.transcribe(f'../data/commonvoice/cv-corpus-19.0-delta-2024-09-13/en/clips/{path}', language='en', beam_size=5, temperature=0)
    try:
        segments = next(segments)
    except StopIteration:
        return time.time() - start, emptyContent()

    return time.time() - start, segments

Have you added beam_size=5 to Whisper? As far as I know, the default beam size is 5 with faster-whisper, but not with the "classic" Whisper.

Have you added beam_size=5 to Whisper? As far as I know, the default beam size is 5 with faster-whisper, but not with the "classic" Whisper.

sorry, i forget this.I will test it after adding it.

Sorry, but the result hasn't changed much.

But you didn't posted any faster-whisper vs whisper comparison results.

But you didn't posted any faster-whisper vs whisper comparison results.

whisper

def transcribe(path):
    decode_options = {"beam_size":5}
    path = Path(f'../data/commonvoice/cv-corpus-19.0-delta-2024-09-13/en/clips/{path}')
    start = time.time()
    res = model.transcribe(str(path), language='en', verbose=True, temperature=0, **decode_options)
    return time.time() - start, res

faster-whisper

def transcribe(path):

    start = time.time()
    segments, info = model.transcribe(f'../data/commonvoice/cv-corpus-19.0-delta-2024-09-13/en/clips/{path}', language='en', beam_size=5, temperature=0)
    try:
        segments = next(segments)
    except StopIteration:
        return time.time() - start, emptyContent()

    return time.time() - start, segments

32hours test data

faster-whisper
whisper

spend time
4372s
4459s

wer
0.276
0.296

Now you know the answer.
Btw, I think you shared the old faster-whisper result:

The time spent on Faster Whisper has decreased from 4372 seconds to 4268 seconds

yes, I am truly a careless person.  i fix it  :(


Translate all job statuses to Qiskit terminology in client

Fixes #1039
Serverless --> Qiskit nomenclature changes
Pending --> Initializing
Stopped --> Canceled
Succeeded --> Done
Failed --> Error
Summary
In this PR, we translate job statuses from all job clients to Qiskit terminology. Rather than changing the DB structure (currently uses ray status names), we will just do a translation in the serverless client when the user requests the status.
Before merging:

[ ] Verify that Pending --> Initializing is a correct mapping. Qiskit also uses Validating, which I did not include here. Maybe we need to switch some of the Pending statuses to Initializing and some to Validating, or maybe it is fine to call all pending jobs "initializing"?
[ ] Verify that Stopped --> Canceled is a correct mapping. Maybe we should leave Stopped and just change some of those instances to Canceled in the case the user canceled the job? Or maybe it's fine to just call all stopped jobs "canceled".
[x] Make sure notebooks reflect new statuses

Basically what migrations are doing:

they are checking in which state db is (which migration version is applied to DB recenty)
if there are upapplied migrations, they are applied
if any of previous migrations changed, migration will fail

@IceKhan13 , I've fixed this up as you suggested. I don't currently have an idea about this strange sphinx error, but Im looking into it. Doesn't seem to be related to the work in this PR, so it's a little confusing

@IceKhan13 , I've fixed this up as you suggested. I don't currently have an idea about this strange sphinx error, but Im looking into it. Doesn't seem to be related to the work in this PR, so it's a little confusing

Hmm, I fixed it by removing Program from the init file, but it is still not clear to me why that error occured in this PR.

Hmm, I fixed it locally by removing Program from the docstring in the init file, but the error is still happening in CI. Can't reproduce this locally after removing Program from the docstring.

merge main and you will be good :)

PR looks good! simple and clean like all great things 😃


drasitc crashed on my KTR

drasitc crashed when installed the experimental-ktr1-malidriver-r38p1.zip


⚠ ClamAV has degraded performance

In 79ca015, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 108 ms

Resolved: ClamAV performance has improved in cada367 after 5 minutes.


ng2 tutorial step15 edits

Rephrasing for clarity, typos, etc. No code edits.

@ShMcK for some reason this change breaks chapter 15..  can you look into that ?
thanks

@Urigo. I looked into it, but it seems to be working. chapter-15.

it works on the website because I haven't deployed it yet because it didn't ran on my local machine

The "<11" mention of the version number was likely the culprit, probably interpreted as an HTML tag with the following line starting with ">"