Add NepuShiro's mods

[ ] The mod id matches the harmony id if used by the mod and starts with the same id as your author folder
[ ] All used links are valid
[ ] Your ResoniteMod.Version must match the version being added in the manifest and follow Semantic Versioning
[ ] Your AssemblyVersion should match the mod version
[ ] You have included an accurate sha256 hash for each artifact
[ ] Do not remove old mods. Instead, use the deprecated flag
[ ] Follow the Resonite Policies and Guidelines and Mod Submission Guidelines

I've updated every assembly's assembly info and fixed Descriptions


Refactor the end-to-end ACME HTTP01 tests (follow-up to #3444)

This is a follow-up PR to #3444. I struggled a lot understanding what we meant by "validation", so I propose a two changes that will hopefully help with this.
NONE

/kind cleanup
/release-note-none

/cc @irbekrm
😇

@maelvls can this be closed in favor of #4128?


miio discover errors using a virgin device

Hi,
I just received a brand new Mi Robot V1 which has never been paired with a WiFi or the App.
I installed the latest miio (0.15.5) and tried a miio discover. It took me about 3 tries and I had to wait for at least 6 minutes to get the following result. Obviously, the json can't be parsed. Can I be sure that this token is correct? (I masked it with ff)
thing:miio:74399767 <- Handshake reply: <Buffer 58 37 48 4a 55 ff ff ff ff ff ff ff 55 70 42 65> +0ms
  thing:miio:74399767 Using automatic token: 5837484a55ffffffffffffff55704265 +7ms
  thing:miio:74399767 -> (5) {"method":"miIO.info","params":[],"id":1} +2ms
  thing:miio:74399767 <- Message: `` +47ms
  thing:miio:74399767 <- Invalid JSON SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at module.exports (/usr/local/lib/node_modules/miio/lib/safeishJSON.js:10:15)
    at DeviceInfo.onMessage (/usr/local/lib/node_modules/miio/lib/network.js:367:18)
    at Socket._socket.on (/usr/local/lib/node_modules/miio/lib/network.js:160:11)
    at Socket.emit (events.js:160:13)
    at UDP.onMessage [as onmessage] (dgram.js:659:8) +1ms
  thing:miio:74399767 -> (4) {"method":"miIO.info","params":[],"id":101} +2s
  thing:miio:74399767 <- Message: `` +11ms
  thing:miio:74399767 <- Invalid JSON SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at module.exports (/usr/local/lib/node_modules/miio/lib/safeishJSON.js:10:15)
    at DeviceInfo.onMessage (/usr/local/lib/node_modules/miio/lib/network.js:367:18)
    at Socket._socket.on (/usr/local/lib/node_modules/miio/lib/network.js:160:11)
    at Socket.emit (events.js:160:13)
    at UDP.onMessage [as onmessage] (dgram.js:659:8) +1ms
  thing:miio:74399767 -> (3) {"method":"miIO.info","params":[],"id":201} +2s
  thing:miio:74399767 -> (2) {"method":"miIO.info","params":[],"id":301} +2s
  thing:miio:74399767 -> (1) {"method":"miIO.info","params":[],"id":401} +2s
  thing:miio:74399767 -> (0) {"method":"miIO.info","params":[],"id":501} +2s
  thing:miio:74399767 Using automatic token: 5837484a55ffffffffffffff55704265 +7s

Thanks for opening an issue! The token is correct as the vacuum is responding to the miIO.info-requests even though the reply is garbage.
The vacuums are a bit tricky in general, and as far as I'm aware have an issue where they can't be controlled over the local network unless they are also connected to the Xiaomi servers.
There seems to be a way to use dustcloud to enable local control, but that involves rooting the device, probably voiding any warranty and risk breaking your device.
So if you really do not want to connect to Xiaomis servers you can try that, otherwise set it up in the app and then extract the token. The token probably needs to be extracted from the app itself, this repo has no documentation (#93) but a good guide is available here: https://github.com/jghaanstra/com.xiaomi-miio/blob/master/docs/obtain_token_mirobot_new.md

Thanks for your help. I finally managed to get a valid token but this is impossible with miio, neither the latest version (0.15.5) nor an older version (0.14.x) returned a token which was valid at the end. The latest version won't return anything if not running it in debug mode. The older version returned this (which also didn't work eventually after pairing it with the app):
Model info: Unknown
Address: <IP_ADDRESS>
Token: 424d44434b34364f756f5141744f754f via auto-token
Support: Unknown

I had to set it up in the app and extract it from a local unencrypted backup. Even here, the iOS part of your linked documentation is already outdated, as the token is stored in hex with 96 digits (AES). You have to decrypt it back to 32 digits, e.g. with the help of an online tool like this: http://aes.online-domain-tools.com

Another problem I stumbled on was that common homebridge plugins (like homebridge-xiaomi-mi-robot-vacuum) don't work together with the latest miio version. I had to explicitly downgrade miio to 0.14.1 in order to get them to work using `sudo npm install -g<EMAIL_ADDRESS>

Good to hear that you managed to get it to work! The behavior of the vacuum is why the docs need to be updated, there has been changes made where it regenerates its token when it is connected to the cloud. Which is why docs is needed for how to extract tokens from the Mi Home apps for both Android and iOS. If you are interested in the progress, follow #93 as it will updated when I get around to it.
The homebridge plugins are an issue as many of them depend on miio globally which is not recommended. If you have the time please open issues in the repos of the plugins you have tried to encourage the authors to properly include miio as a dependency in their projects.


Allow for configurable error handler in job manager

Problem
Each job script has to define own handling for errors whereas it would be a lot easier to define and configure common handler on job manger level.
Solution
Introduce central error handler in job manager.
Todos:

[x] fix existing Ghost jobs and remove error logging and sentry notification
[ ] ~see if it would be possible to push down this kind of handling to bree~ has to be done in bree itself (https://github.com/breejs/bree/pull/62)

This issue awaits merge in upstream - https://github.com/breejs/bree/pull/62

PRs are merged into master, needs a release in bree.


When time to run (-t) timed out, pending requests seems to be aborted, and the (latest) responses get lost

Description of issue
When time to run (-t) is over, pending requests seems to be aborted, and the responses get lost. Now the last responses get lost
Expected behavior
When time to run (-t) is timed out, I expect Locust to stop generating new requests, but to wait for  pending requests and store their responses.
Actual behavior
When Locust stops, pending requests seems to be aborted and their responses get lost
The -t options is introduced is version 0.9.0
Environment settings

OS: Windows7 and OSX
Python version: 3.7.2
Locust version: 0.9.0

Steps to reproduce (for bug reports)
TBD - please provide example code
Make sure requests are pending and stop locust after run-time has passed

When time to run (-t) is timed out, I expect Locust to stop generating new requests,
but to wait for pending requests and store their responses.

Why would we store responses that occur after the run is over?   AFAICT, this functions as designed.

In my case I created a load test with a database in the background. During the Locust test I create resources by api requests to the target (host). When Locust is finalized, I want to clean up the test by deleting the created resources on the target and I use the database for that purpose. Unfortunately the last response is never stored (but the resource was created), and the resource stays at the target.
In the old version of Locust this was no issue, because there was an option to execute N requests. This option is removed in the latest version.

use a teardown.
https://docs.locust.io/en/stable/writing-a-locustfile.html#setups-and-teardowns

I already use the teardown, but the function will not wait for the final response.


InjectModuleInitializer.exe for .NET 4.5 or greater

Currently the InjectModuleInitializer.exe needs .NET 3.5 to run. Could you create a version that targets the .NET framework 4.5 or greater?

Creating a .config in the same folder as the executable with a supportedRuntime entry should work.


Booking product-- Standard Bagisto

Is your feature request related to a problem? Please describe.
It is an advancement of the Standard Bagisto Booking feature.
Describe the solution you'd like
--> We can add color to the calendar date so that we can sort out the booked date and available dates visually.
Screenshot:-

Thanks!
Describe alternatives you've considered
No response
Additional context
No response

Currently, we are not providing any feature to 1.x branch anymore. In the 1.x branch we are now providing bug fixings only. For this, we will check the new theme.
So I am closing this.


a8ctl release should not include platform in executable name

currently have a8ctl- in executable name for the release. Should likely change that to a8ctl, since all instructions refer to the shorter name. The .tar.gz file can still contain the platform name.
This is doable in tar using --transform flag

we could have a simple step in teh docs that state that people should rename the binary to a8ctl and be done with it. Instead of wasting time on taring/unzipping, etc.

Makes sense.  @GregHanson is updating the docs.


Design round1

This PR completes a first round of design improvements for the fixed bottom design.
The main changes are:

Drivetrain was redesigned by Hannes Labuschagne, PostDoc at NREL (thank you!)
Hub diameter is increased from 7 to 8.4 m
The airfoil polars in OpenFAST have an updated 3d correction because of the slightly different radial position given the larger hub
OpenFAST files are up to date with v3.4.1
Structural twist is fixed in BeamDyn (negative sign and rad vs deg)
Structural damping is set to 0.5% critical for both blades and tower
Tower and monopile are redesigned to increase first system modes from 0.13 Hz to 0.16 Hz and satisfy buckling constraint

The floating configuration will be updated soon by @dzalkind!

that's right, 0.005 critical or approx 3% log dec. we can also pick a lower value if we prefer


getValue/getText API should be added as part of Detox e2e suite

getValue/getText kind of basic API should be added as part of Detox e2e suite
Sometime we need to work upon the text displayed on the UI for validating calculations or verifying any function in the code .
The text is not static most of the times .
If detox can come up with some API which helps to fetch / get the text from the components , then it would be great for functional e2e tests.

Hello,
This has been asked before (e.g. https://github.com/wix/Detox/issues/1057 and https://github.com/wix/Detox/issues/445). Closing in favor of those.


New CI workflow for docs: 1 doc version per major

Description
Full context can be found in this Notion page. TLDR: with 3.0, we will be changing the way we build docs, having one docs version per major version.
Definition of Done

[x] Write down an implementation proposal here and get reviews
[x] Implement the solution and merge into main

💡 worth mentioning that this issue is blocking the full merge of the docs into one 2.x version. We'll need to backport the CI workflow to all the 2.y.x release branches once the 2.8 docs have been merged (see Status section of mentioned PR)

FYI @tmbo

yes!


Push with custom history not working since 5.0.0

Version
5.0.0
Test Case
https://codesandbox.io/s/ox4y7z6w4q?fontsize=14
Steps to reproduce
Go to About section.
Click on 'go to home without props' button.
Expected Behavior
Expecting 'Home' component to be loaded. Same behaviour as if you would click the other button.
Actual Behavior
Url changes but home component is not loaded.
This worked for me on older projects but not in my newest project so I guess it is because of v5. I don't want to use props because I want to push my history inside a redux action creator which is not a react component.

My current workaround is passing this.props.history to my action creator.

You are using the wrong router component. In order to pass a custom history, you need to use Router, not BrowserRouter.

Additionally, your import in index.js is wrong. You're importing from history there, but from /components/history in the about component..

Thank you. I missed the "BrowserRouter as Router" in import and thought I was already using Router. lol... only one day lost


Using Email Channel SPAM replies

Hi
When replying to an email received through the email channel, the bot sends over 400 replies, spamming the inbox. I'm not sure why this happens although it seems like once one email is sent, the code enters a loop of replying and receiving emails and never ends.
I'm using SDK 4 .Net Core, running the code over Visual Studio Locally, using ngrok to debug locally while publishing to Azure Bot Channel portal.
Here's the code:

private static async Task<DialogTurnResult> CheckQuestionAsync(
        WaterfallStepContext stepContext,
        CancellationToken cancellationToken = default(CancellationToken))
        {

             if (stepContext.Context.Activity.ChannelId == "email")
            {
            await stepContext.Context.SendActivityAsync("test");

            return await stepContext.EndDialogAsync();
        }
        }

public async Task OnTurnAsync(ITurnContext turnContext, CancellationToken cancellationToken = default(CancellationToken))
        {
            if (turnContext.Activity.Type == ActivityTypes.Message )
            {

                // Establish dialog state from the conversation state.

                UserInfo userInfo = await _accessors.UserInfoAccessor.GetAsync(turnContext, () => new UserInfo(), cancellationToken);

                await _accessors.UserInfoAccessor.SetAsync(turnContext, userInfo, cancellationToken);

                // Continue any current dialog.
                DialogTurnResult dialogTurnResult = await dc.ContinueDialogAsync();

                // Process the result of any complete dialog.
                if (dialogTurnResult.Status is DialogTurnStatus.Complete)
                {
                    var i = 0;

                    }
                }

                // Every dialog step sends a response, so if no response was sent,
                // then no dialog is currently active.

                else if (!turnContext.Responded)
                {
                    var h = 0;

                        //We need to think how to handle too many attemps.
                        await dc.BeginDialogAsync(MainDialogId, null, cancellationToken);

                }

                // Save the new turn count into the conversation state.
                await _accessors.ConversationState.SaveChangesAsync(turnContext, false, cancellationToken);
                await _accessors.UserState.SaveChangesAsync(turnContext, false, cancellationToken);
            }

            else
            {
                // Commenting this to avoid "event detected" message over the chat.
               // await turnContext.SendActivityAsync($"{turnContext.Activity.Type} event detected");
            }
        }

@DanteNahuel I'm going to close this issue, since it's related to the issue you open above (#1347). Will be working on seeing what's going on that thread.


Permission denied (publickey) when attempting to SSH into Rancher Server

I'm new to Rancher. I've followed the docs to build out a quickstart environment in Azure and after getting over a few hurdles with some gaps I've managed to get Rancher Server deployed. I seem to be having trouble connecting via SSH to the Rancher node (to run rke) It seems like a certificate authentication issue. I've just used the terraform scripts in the quickstart repro. What do I need to do to get authentication working via SSH?:
ssh -i ~/.ssh/ubuntu ubuntu@public_ip:
Permission denied (publickey):
Other details that may be helpful:
Rancher Quick Start deployment in Azure

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

(paste the output here)

Docker version (use docker version):

(paste the output here)

The documentation or the template (or both) should be updated. It looks like you are trying to use the ssh key in your home directory ~/.ssh which is what it appears you should use from the documentation.  Instead, when you run a terraform apply from quickstart/azure, it creates an id_rsa and id_rsa.pub in quickstart/azure.  This is the key you must use so:
ssh -i  <PATH_TO>/quickstart/azure/id_rsa ubuntu@public_ip


Ace of spades privilege.

A player who plays The ace of spades can request a specific suite and number. Or have I been playing by the wrong rules?

This is true but sometime it is prohibited since one can use it to lock the game


feat(module:progress): support nzSuccessStrokeColor property

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
This PR adds nzSuccess and deprecates nzSuccessPercent.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
close #5886
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No, but introduce a deprecation

Other information

Hi @hsuanxyz. I reworked this PR and just added a nzSuccessStrokeColor property.


Enhancing (Our Team) Section of About Us Page

I want to improve the (Our Team )Section of the About Us Page.
Right now all members of different teams are mixed up like web developers with management heads. So I want to create this team section more systematically to improve UI  and user experience.
For eg: Founders/ Co-Founder in a single row, Web Developers in another row so on...
Sample: -

Please assign this task to me under gssoc'23. I am well versed in frontend development tech stacks - react js, HTML, CSS, and javascript.

I'll create issue for contributing page like...please comment on that to get assigned thanks

I'll create issue for contributing page like...please comment on that to get assigned thanks
Ok, Please assign me this task.

@anmode,  I by mistake used my redundant GitHub id for requesting this task, @abhi03ruchi is my official GitHub Id through which I am contributing in Gssoc '23. Please assign this task to me via this id.


Hyperlink in video description

[x] Admin has component to markdown
[ ] Application supports

[x] Web
[ ] Android
[ ] iOS
[x] tvOS

Natively supported in tvOS, so no implementation needed unless we need to implement some fancy QR code things (the url is displayed, not the text if any).


Push touching parent works to the background

Coverage remained the same at 100.0% when pulling 6f4075b6f47b462b95f65a1b68ca7b06b94b128a on ruby-prof into 79269826a2b6429755483666cd5f11c6b0af7ffc on master.

@escowles Agreed on restricting environment - added.


Manual Path?

I got a weird requirejs config so this require call is not working for my set up
var WebRTC = require('webrtc-native');
Wondering what exactly is the main file being used? Will just try an absolute path

the module is located in regular npm module path. webrtc-native/build/Release/webrtc.node


GUACAMOLE-1207: Add Portuguese translation

Add translation files for the webapp and the following extensions:

guacamole-auth-cas
guacamole-auth-duo
guacamole-auth-jdbc
guacamole-auth-openid
guacamole-auth-quickconnect
guacamole-auth-saml
guacamole-auth-totp

@rbm0407: Looking pretty good. However, now you have some extra commits - please squash them all down into a single commit, and make sure the commit message is descriptive. After that I think it'll be ready to go!

Sorry, this is my first pull request hahaha
Squashed to a single commit


Add profile image, Chinese language and other updates

Add some features:

support upload profile image,
support Chinese language,
update not to display dot in front of empty lines in Experience and Project details,
update Social section to be optional

Thank you so much for your contributions 😊
I would appreciate if you could break this PR into different ones by feature so it is easier to review and merge.

Thank you so much for your contributions 😊
I would appreciate if you could break this PR into different ones by feature so it is easier to review and merge.

Ok, I will find time to break this.

I'm closing this PR, feel free to open new ones for each feature.


Dear sir please send me your address book unsubscribe from future mails ie to ya soon ya paran yatas kai tarah ke

AVOID POSTING ISSUES UNDER THIS CATEGORY.
If Pipenv is not functioning as you would like it to, consider filing either a bug report, or a feature request instead.
Please refer to StackOverflow tag for more information.

Please run $ pipenv --support, and paste the results here. Don't put backticks (`) around it! The output already contains Markdown formatting.
If you're on macOS, run the following:
$ pipenv --support | pbcopy

If you're on Windows, run the following:
> pipenv --support | clip

If you're on Linux, run the following:
$ pipenv --support | xclip

No comments links yet


decide on a way to display projects in the future

To clarify: We will not erase any projects from github.
Status quo & pain points:

The current database of projects on codefor.de is outdated and incomplete. It would be very time consuming to review and update all of it. Even with our best efforts, we would not produce a complete list of projects.
Many labs have their own websites. They do not want to add projects more than once, and they already add them to their own website.
Some labs use the codefor.de/nameoftheirlab subpage as the only place to refer to their work. Currently, the database is the only way they can showcase their projects.
Digifarm Münster has built a solid database that features many CFG projects. In many community discussions we conceded that we should build on it/ integrate it, instead of keeping up our own.

How we should display projects in future:
on subpage codefor.de/projects:

make it clear that we are not showing a complete project list of everything CFG has done, because many things are on the labs' own websites.
highlight some (ca. 3) projects with images and short text
link to digifarm with a big button or integrate digifarm (maybe link to first, integrate at a later date as a seperate project)
curate a list of projects that should be displayed (figure out which criteria apply, etc.) => crossreference with https://github.com/okfde/codefor.de/issues/278
rest of projects, everything that should not be displayed, gets moved to "Projektarchiv"
"Projektarchiv" gets a disclaimer that information might be incomplete/ outdated, and once again link to digifarm

on subpages for labs, eg. codefor.de/flensburg

show all the lab's projects that are registered in database (stays as is)
labs are encouraged to write blogposts that highlight their projects (which will also be added to their lab subpage, if they add the relevant tag "labname")

==
[1] (https://github.com/okfde/codefor.de/tree/main/content/projekte) or (codefor.de/projekte) inkl. project archive

this was discussed with Nora and Knut today, we decided on a different way to go about this.


Web - Login - An error is displayed in the console when logging with magic link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/19850
Action Performed:

Log in to the Expensify
Sign in using the magic link with an account with 2fa enabled
Verify that the tab open by the magic link works as usual
Repeat the steps 1-2 with an account with 2fa disabled

Expected Result:
No errors should be displayed in console
Actual Result:
Errors are displayed in the console
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/c7abcbf6-916b-44a3-94d2-920c8d792f04
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

It seems like even with the console errors, the user is able to log in without issue. I don't know if we need to prevent all console errors if the app is working fine, so I'm going to add the engineering label to get advice on whether this is actually something we need to fix.

@MariaHCD what do you think? Is this one a bug that we need to investigate, or is it okay to close since it's not impacting users at all?

It's a little hard to tell because this issue doesn't quite specify what the console error is. Couldn't quite catch it in the screen recording either. Will reproduce the issue.

Okay, tried on staging but I don't see any console errors besides Unrecognized Content-Security-Policy directive 'prefetch-src'. error which will be fixed here, I believe.

I don't see anything that's impacting users either so I think we're fine to #doNothing


Add sublocality to the address details

At least in my case, I have to get sublocality, that provides Google API, or add the ability to show all options, that provide Google. I can improve it if it's required

comp['sublocality'] is not how to use this. I will address this request in a new PR


Kekulization failure on round tripped SMILES through RDKit

Logging this problem here before I forget about it on vacation.
Came across this SMILES string as an output from MolVS, chased it down to RDKit. RDKit is failing to read back in a SMILES it generated due to a kekulization failure.
In [5]: rdkit.__version__
Out[5]: '2018.03.1.dev1'
In [14]: mol = Chem.MolFromSmiles('CN\N=C1/C(=N)C2=C3C4=C1C1=CC=CC5=C1C1=C6C7=C8C(=CC=C57)C=C(C)C=C8C5=CC(C)=C7C8=C(C)C=C9C%10=CC(C)=CC%11=C%10C%10=C(C=C%11)C%11=CC=CC2=C%11C2=C3C(=C8C9=C%102)C(C7=C65)=C41')

In [15]: Chem.MolFromSmiles(Chem.MolToSmiles(mol, True))
[11:32:38] Can't kekulize mol.  Unkekulized atoms: 6 7 8 9 10 11 12 13 14 15 16 17 19 20 21 22 23 25 26 27 29 30 31 32 33 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65

This looks fun... (highlights are the kekulization issues)

Yeah, I’m “looking forward” to tracking this one down.

Some additional info.
There's an order dependence here:
In [19]: mol = Chem.MolFromSmiles('CN=C1C(=N)C2=C3C4=C1C1=CC=CC5=C1C1=C6C7=C8C(=CC=C57)C=C(C)C=C8C5=CC(C)=C7C8=C(C)C=C9C%10=CC(C)=CC%11=C%10C%10=C(C=C%11)C%1
    ...: 1=CC=CC2=C%11C2=C3C(=C8C9=C%102)C(C7=C65)=C41')

In [20]: Chem.MolToSmiles(mol)
Out[20]: 'CN=c1c(=N)c2c3cccc4c5ccc6cc(C)cc7c8cc(C)c9c%10c(C)cc%11c%12cc(C)cc%13ccc%14c%15cccc%16c1c1c2c2c(c43)c(c5c67)c8c9c2c2c%10c%11c(c%14c%13%12)c(c%15%16)c12'

In [21]: Chem.MolFromSmiles(Chem.MolToSmiles(mol))
[04:49:56] Can't kekulize mol.  Unkekulized atoms: 5 6 7 8 9 10 11 12 13 14 15 16 18 19 20 21 22 24 25 26 28 29 30 31 32 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64

In [22]: mol = Chem.MolFromSmiles('ClN=C1C(=N)C2=C3C4=C1C1=CC=CC5=C1C1=C6C7=C8C(=CC=C57)C=C(C)C=C8C5=CC(C)=C7C8=C(C)C=C9C%10=CC(C)=CC%11=C%10C%10=C(C=C%11)C%
    ...: 11=CC=CC2=C%11C2=C3C(=C8C9=C%102)C(C7=C65)=C41')

In [23]: Chem.MolToSmiles(mol)
Out[23]: 'Cc1cc2ccc3c4cccc5c6c(=N)c(=NCl)c7c8cccc9c%10ccc%11cc(C)cc%12c%13cc(C)c%14c%15c(C)cc%16c(c1)c2c3c1c%16c%15c2c3c%14c%13c(c%10c%11%12)c(c98)c3c7c6c2c1c45'

In [24]: Chem.MolFromSmiles(Chem.MolToSmiles(mol))
Out[24]: <rdkit.Chem.rdchem.Mol at 0x7f6de0949300>

I guess the problem did not get resolved?
I am still having this problem when I re-try the above example.
In fact, I have a lot of large molecules like that, and I am having trouble kekulizing them...
It would be great to know if there is any plan on fixing the issue...


return onActivityResult, presenter getView() is null

Hi, Not sure if this is an issue, or I just don't know the correct way to handle this.
In my MainActivity, I fired: startActivityForResult()...
Then onActivityResult() comes back, and I do stuff with my presenter. getPresenter() is fine, but within my presenter, getView() returns null.
Some logging tells me this is the flow:
onResume
startActivityForResult
onPause
onActivityResult
onResume
....
Thanks,
Jia

Hi! This is looks like the intended behavior for 1.3.3 but I'm going to change this for 2.0.0.
I will need to make some additional tests, probably tomorrow.

So, I've made some tests.

This is the intended behaviour for 1.3.3. In 1.3.3 Presenter is connected to the view only between onResume/onPause. So if you need to send something to the view you need to wait until it became available onTakeView OR use RxPresenter's deliver capabilities.

Right now I'm creating an update for 2.0.0 to make start/result scenario reliable even in the case of a process restart. This should work from 2.0.0-beta6, probably tomorrow.

If you need to return some data from the presenter immediately then you can just create a function that returns a value in the presenter.

I ended up doing this and seems to work:
  protected void onActivityResult(int requestCode, int resultCode, Intent intent) {

                getPresenter().takeView(this);
                getPresenter().doXYZ();

    }


RuntimeError: Could not parse python long as longdouble

Describe the bug
I'm using Blender Version 3.1.2 (3.1.2 2022-04-01) on MacOS Montery. When I attempt to export to GLTf, I get a Runtime Error, seems related to Numpy.
To Reproduce
Steps to reproduce the behavior:

Go to Blender
Click on export
Keep default options and click export
See error

Expected behavior
The objects are exported to GLTf
Screenshots
If applicable, add screenshots to help explain your problem.
.blend file/ .gltf
I can't I'm afraid.
Version

OS: MacOS Montery
Blender Version3.1.2

Additional context
Add any other context about the problem here.

Hello,
Seems this is not linked to glTF exporter, but how python is packaged into Blender.
Can you please :

Test with Blender 3.2 alpha ( https://builder.blender.org/download/daily/ )

If error is still there, please test the following :

Open Blender

Open Python Console Editor in Blender

run "import numpy as np"

If you have the same error, please open a ticket on https://developer.blender.org/


SyntaxError: Strict mode does not allow function declarations in a lexically nested statement.

What happens instead?
SyntaxError: Strict mode does not allow function declarations in a lexically nested statement.
in
 var _this = this;       // Motion UI method of reveal       if (this.options.animationIn) {         function afterAnimation() {           _this.$element.attr({             'aria-hidden': false,             'tabindex': -1           }).focus();           _this._addGlobalClasses();
Your Environment

Foundation version(s) used:  6.5.1
Browser(s) name and version(s): all
Device, Operating System and version: all

Checklist

[ ] I have read and follow the CONTRIBUTING.md document.
[ ] There are no other issues similar to this one.
[ ] The issue title and template are correctly filled.

Please provide steps which lead to this error.

@benekex2 Please add more informations about your bug, how to reproduce it and format your code.

This is syntax in your code. You declare function in if statement. This is not allowed in strict mode.
/node_modules/foundation-sites/js/foundation.reveal.js on 256 line
// Motion UI method of reveal
    if (this.options.animationIn) {
      function afterAnimation() {
        _this.$element
          .attr({
            'aria-hidden': false,
            'tabindex': -1
          })
          .focus();
        addRevealOpenClasses();
        Keyboard.trapFocus(_this.$element);
      }
      if (this.options.overlay) {
        Motion.animateIn(this.$overlay, 'fade-in');
      }
      Motion.animateIn(this.$element, this.options.animationIn, () => {
        if (this.$element) { // protect against object having been removed
          this.focusableElements = Keyboard.findFocusable(this.$element);
          afterAnimation();
        }
      });
    }

This is syntax in your code. You declare function in if statement. This is not allowed in strict mode.

We never had this issue with our webpack builds in projects.
Please provide the steps to reproduce this error with a fresh project and config files.

Closing as we did not receive any further feedback.


feat(ingest): add python utility classes for NotebookUrn, CorpuserUrn and CorpGroupUrn

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

the smoke test failure seems not related to my change

Hi @tc350981, my suggestions might have introduced some linter issues. Could you please fix them?


Update package dependencies

This pull request actualizes package dependencies and solves the issue found during vendoring this package in Arch (see discussion).

Summary by Sourcery
Update package dependencies to support Python 3.10 and above, and adjust the import logic for 'Concatenate' and 'ParamSpec' based on the Python version.
Enhancements:

Update package dependencies to ensure compatibility with Python 3.10 and above by conditionally importing from 'typing' or 'typing_extensions'.

@daskol thanks for the PR.
New version with yout fixes uploaded to PyPi.


Add nota executable

This PR adds a Nota executable to the root of the project.

This should help fixing #18


Querying for trigger state

Once a trigger is set it would be really helpful to be able to query the state of the trigger to determine if it has fired, or how many more times it potentially could fire. Depending on the output of the trigger (does not have to be a diagnostics file) it may not always be obvious whether a trigger has fired or not.
A new API could simply output a response describing the basic state of each of the defined triggers.

Do we also want to add enable/disable/reset state for each trigger?


java.se.ee not found when running 'flutter doctor --android-licenses'

Steps to Reproduce
Flutter android integration was working before.
Had to uninstall Android SDK tools and Android Studio before updating my OS.

Just upgraded to Mac OS BigSur
Installed Android Studio and recommended SDK tools
Flutter doctor shows only missing step is accepting licenses

Logs

Logs

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.0, on macOS 11.3.1 20E241 darwin-x64, locale en-US)
    • Flutter version 2.2.0 at /Users/<user>/development/flutter
    • Framework revision b22742018b (5 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/<user>/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/<user>/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.56.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.22.0

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 90.0.4430.212

Hit submit too early.
When trying to accept licenses, this is what I get:
$ flutter doctor --android-licenses
Error occurred during initialization of boot layer
java.lang.module.FindException: Module java.se.ee not found
$ java --version
java 13 2019-09-17
Java(TM) SE Runtime Environment (build 13+33)
Java HotSpot(TM) 64-Bit Server VM (build 13+33, mixed mode, sharing)
Read a bunch of info online about Java versions but couldn't fix this error (I couldn't find any official guidance either).

Also tried this suggestion from another similar bug with no success:
JAVA_OPTS=-XX:+IgnoreUnrecognizedVMOptions --add-modules java.se.ee

Oh I wasn't sure java 8 was still needed. That fixed it, thanks.


Changes in UX of HomePage !

I want to add some hover effect on cards
Pls assign this to me

@saka015 You can work on this issue now.


[Bazel/MSVC] Make Kafka builds on Windows

Working towards enabling //tensorflow/contrib/kafka for Bazel on Windows.

@rongjiecomputer Is this PR ready to be reviewed?

Yes. The actual change to enable //tensorflow/contrib/kafka will be another PR.

Yes. The actual change to enable //tensorflow/contrib/kafka will be another PR.

Windows Bazel builds all failed at link step: LINK : fatal error LNK1000: unknown error at .... Probably just flake.
MacOS Contrib also failed with mysterious "Internal CI infrastructure error".
Rebased against master, please trigger CI test again.


[TE] frontend - harleyjj/comparison - fix bugs from mini bugbash

new granularity check protects against null value
remove anomaly id from investigate link
make cache key more robust against duplicate in anomaly service (preview anomalies can have duplicate ids since they are generated on the fly)
improve error handling for _getAnomalies task

I updated the commit to also handle errors better in _getAnomalies, since one case now entails calling it twice (Edit Alert Preview being called when current anomalies aren't yet loaded)


User is able to fubar fluster cuck a docker instance by pressing Restart and Update in quick succession

Bug Report
System Information

Operating System (Including distribution name and version number) Ubuntu 20.04.5 LTS
AMP version and build date (Always use the version number, 'latest' is not valid!)

Application Version | <IP_ADDRESS>
Release Stream | Release
Build Date | 14/03/2023 23:15

Which AMP release stream you're using (Mainline, Nightly or FastTrack) Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms

What are you trying to do? Not fubar fluster cuck the user's instance
What are you expecting to happen? That if a user hits the restart button, or update button, or ANY other "do this" button other than "Abort" or "Kill" that the API will not try to do such a thing
What is actually happening? ('Nothing' is not an acceptable answer!) It would appear that it is allowing 2 actions to happen simultaneously

Reproduction

Create a project zomboid server
Start the server
Go to the console menu, wait for the server to start
Hit restart, and then hit the update button immediately after
Watch the server fubar flustercuck itself until you restart the instance entirely

This would be indicative that the button presses are immediate and not put into a queue - this can cause a massive lockup.

Fixed in CI, sensitive tasks like updates lock the instance temporarily.


Remove the test/features folder, since it's very out of date (issue 11954)

These tests, and their accompanying Wiki page, haven't received any real updates for many years and are sufficiently out of date to be effectively useless now.
Providing irrelevant compatibility information seems overall worse than not providing any information at all, and as suggested in the issue it'd probably be better to use https://github.com/mozilla/pdf.js#online-demo for checking if a particular platform/browser is supported.
Thanks to version control, it's easy to restore these files should the need ever arise. However, re-introducing these tests would essentially require updating every single test-case and a commitment to keeping them up to date with future code changes.
Fixes #11954

Looks good to me. I have also removed the wiki page and the links to the page now.


fix: ran package to bundle latest changes

forgot to run package in previous PR (https://github.com/robinraju/release-downloader/pull/707)

superseded by #710


1608 | Special Array With X Elements Greater Than or Equal X | C++

Special Array With X Elements Greater Than or Equal X -
New File in C++ directory -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[ ] Improving Code
[ ] Improving Documentation
[ ] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[ ] Python
[x] C++
[ ] Java
[ ] SQL

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign this to me @Yashica7 and @SSKale1


add Web Animations Resources update

Suggest adding in a header image for the tile that is used in the list page of /updates/ ... Will look further tomorrow, but at a high-level, great to see this

Ah. Just realised. This should be pulled against material-branch (sorry for confusion) the pre-amble has changed and needs to be fixed.

Closed in favour of #2238.


FIX: Broken 'Examples' Link in the Footer

The examples link in the footer is broken! This PR fixes that.

The fix has the same link as there is in the header!
Looking forward, to have my first contribution in the Bootstrap! 🍕

https://github.com/twbs/bootstrap/pull/23348

@XhmikosR Shiiiit! Missed the contribution props? :

Huh? That was opened first.

@XhmikosR Didn't see that. Apologies!


Huge amounts of memory usage when collecting data from Thanos/Prometheus

When collecting data from Thanos, the tool uses a lot of memory. I think this is because all the metric data is downloaded and stored in memory while it is being processed and stored to the backend storage.
I know the Thanos Store API does not support streaming of data, but maybe we could chunk our queries somehow.
Same for Prometheus, Remote Read API does support streaming of data but it is not available in the upstream client yet.

What huge means? (:
Performance optimiations is never ending story. We need to find out if:

Perf improvements are worth it, prioritize it. Is tool unusable?  How much memory is a "good" amount of memory to be used vs data fetched? (:  Can you give some numbers, repro? (:

This will help us to find out how much we can improve :hugs:

@gmfrasca do you have more specific numbers for the workflows?

@4n4nd when running on 1-hour chunks, on a few of the larger metrics (subscription_labels, for example) we were getting OOMKilled even with 24GiB RAM allocated.
We initially allocated 12GiB which saw the majority of the metrics getting OOMKilled, which we've worked around by reducing our chunk sizes by half (2 runs per hour, 30-minutes per chunk), but still saw the larger metrics fail at 12GiB.  Due to hardware limitations we unfortunately cannot sustain running pods with 24GiB, but also can't reduce our chunk size much further as we would risk a job 'collision' (the XX:30 job would be running in parallel with the XX:00 job, and would compete for resources that we may not have)
I hope this is helpful, but please let me know if there are any other details I can provide.  Thanks!

Hey @bwplotka! With the holiday season concluding, just wanted bump/signal boost this issue.  Would you have any insights on how we can approach alleviating the memory utilization here?
In the short term I don't think we have a great deal of flexibility allocating more hardware resources, which leaves us in a tough spot for expanding the number of metrics we can retrieve, or adding features to the current pipelines.  It would be great if we could track down and optimize the heavy mem usage areas in-code to get around that, if at all possible.

Hey @bwplotka! With the holiday season concluding, just wanted bump/signal boost this issue.  Would you have any insights on how we can approach alleviating the memory utilization here?
In the short term I don't think we have a great deal of flexibility allocating more hardware resources, which leaves us in a tough spot for expanding the number of metrics we can retrieve, or adding features to the current pipelines.  It would be great if we could track down and optimize the heavy mem usage areas in-code to get around that, if at all possible.

Yea, The way format is to obtain profiles and figure out the problematic spot (:
Feel free to read more about it here: https://jvns.ca/blog/2017/09/24/profiling-go-with-pprof/
pprof endpoint should be already available.
If this is a tool not a service running we could use simple code like this (you can just copy this function) or import https://github.com/efficientgo/tools/blob/main/performance/pkg/profiles/profile.go#L17

Yea, The way format is to obtain profiles and figure out the problematic spot (:
Feel free to read more about it here: https://jvns.ca/blog/2017/09/24/profiling-go-with-pprof/
pprof endpoint should be already available.
If this is a tool not a service running we could use simple code like this (you can just copy this function) or import https://github.com/efficientgo/tools/blob/main/performance/pkg/profiles/profile.go#L17


[Windows] Add script for OpenSSL installation

Description
Add script to install OpenSSL using executable installer rather then choco package. This is mainly to be able to select which version to install and to switch between light and full variants. The problem with choco is that light package doesn't provide up-to-date patch for OpenSSL 1.1.1 and full package doesn't have versions for OpenSSL 3.x.
Script uses repo https://github.com/slproweb/opensslhashes to get information about currently available versions of Win-OpenSSL installers, filters out installers that don't satisfy the requirements provided and selects the latest version among remaining ones.
Currently it is configured to install full variant of the version 1.1.1.
Related issue: https://github.com/actions/runner-images/issues/7283
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022

This breaks building packages on MSYS2, please remove it from PATH.
Add an environment variable for its location instead.


Cannot download Vimeo video

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.04.17. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[X ] I've verified and I assure that I'm running youtube-dl 2019.04.17

Before submitting an issue make sure you have:

[X ] At least skimmed through the README, most notably the FAQ and BUGS sections
[X ] Searched the bugtracker for similar issues including closed ones
[X ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[X ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

My cmd output:
C:\Users\Ali008\Desktop\DS>youtube-dl.exe --verbose https://player.vimeo.com/video/331919542
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://player.vimeo.com/video/331919542']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.04.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17763
[debug] exe versions: ffmpeg 4.1
[debug] Proxy map: {}
[vimeo] 331919542: Downloading webpage
[vimeo] 331919542: Extracting information
[vimeo] 331919542: Downloading JSON metadata
WARNING: Unable to download JSON metadata: HTTP Error 404: Not Found
[vimeo] 331919542: Downloading fastly_skyfire m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 308: Permanent Redirect
[vimeo] 331919542: Downloading fastly_skyfire MPD information
WARNING: Failed to download MPD manifest: HTTP Error 401: Unauthorized
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp1tqz5pcu\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp1tqz5pcu\build\youtube_dl\extractor\common.py", line 529, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp1tqz5pcu\build\youtube_dl\extractor\vimeo.py", line 696, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp1tqz5pcu\build\youtube_dl\extractor\vimeo.py", line 108, in _vimeo_sort_formats
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp1tqz5pcu\build\youtube_dl\extractor\common.py", line 1326, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
...
<end of log>

Does this video still exist?
I can't even view it in the browser. Please check if it's still working for you in your browser.

WARNING: Failed to download m3u8 information: HTTP Error 308: Permanent Redirect

this error happens with recently ended live streams, for some reason youtube-dl can't catch Location header with 308 Redirects, while they appear with --print-traffic option, this will be hard to fix because of the short window to access the temporary live archive manifests.
however, all the streams I've tested serve a source file that can be downloaded with 85b6335d55c7b0ed7f6815f7b8b9a365b0a28c37.


webview_flutter 使用问题

使用webview_flutter，展示的H5网页中的按钮的点击阴影不消失,每次点击按钮的时候,按钮的阴影会留在页面上不消失,只能再次点击一次页面任意位置才会消失,这是什么原因?怎么解决?

@Inisit
Please provide flutter doctor -v and a minimal complete reproducible code sample that shows the issue you are facing.
Thanks

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


testutil: whitelist os.(*file).close

Leak detector is catching goroutines trying to close files which appear
runtime related:
1 instances of:
syscall.Syscall(...)
/usr/local/golang/1.8.3/go/src/syscall/asm_linux_386.s:20 +0x5
syscall.Close(...)
/usr/local/golang/1.8.3/go/src/syscall/zsyscall_linux_386.go:296 +0x3d
os.(*file).close(...)
/usr/local/golang/1.8.3/go/src/os/file_unix.go:140 +0x62
It's unlikely a user goroutine will leak on file close; whitelist it.

Codecov Report

Merging #8284 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #8284      +/-   ##
=========================================
- Coverage   76.42%   76.3%   -0.13%
=========================================
  Files         346     346
  Lines       27055   27056       +1
=========================================
- Hits        20676   20644      -32
- Misses       4901    4926      +25
- Partials     1478    1486       +8

Impacted Files
Coverage Δ

pkg/testutil/leak.go
67.64% <100%> (+0.48%)
:arrow_up:

pkg/transport/timeout_conn.go
80% <0%> (-20%)
:arrow_down:

pkg/adt/interval_tree.go
85.88% <0%> (-5.11%)
:arrow_down:

pkg/testutil/recorder.go
77.77% <0%> (-3.71%)
:arrow_down:

rafthttp/msgappv2_codec.go
67.82% <0%> (-3.48%)
:arrow_down:

clientv3/concurrency/election.go
80% <0%> (-2.41%)
:arrow_down:

pkg/netutil/netutil.go
62.35% <0%> (-2.36%)
:arrow_down:

etcdserver/cluster_util.go
76.64% <0%> (-1.46%)
:arrow_down:

etcdmain/etcd.go
45.06% <0%> (-1.29%)
:arrow_down:

clientv3/watch.go
94.5% <0%> (-1%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608df0f...bb42d2b. Read the comment docs.


Can't delete - custom folder

I cant seem to delete a file after I changed the upload folder.
I don't get an error or anything...just nothing happens when I click the delete button :/
I'm actually getting the path to the upload folder from Mysql and that seems to work fine. Added some messy code to the "__construct" function but it works when I upload but not delete :/
When i change the upload_dir and upload_url back to original I can delete again.
		$check = mysql_query("SELECT * FROM nxxs WHERE news_id = '".$_POST['newsid']."'")or die(mysql_error());
			while($info = mysql_fetch_array( $check )){
				$news_url = $_SERVER['DOCUMENT_ROOT'].$info['news_url']."/";
				$news_url2 = "Http://www.domain.com".$info['news_url']."/";
		}
    $this->options = array(
        'script_url' => $this->getFullUrl().'/'.basename(__FILE__),
		//'script_url' =>$news_url,
        'upload_dir' =>$news_url,
		'upload_url' =>$news_url2,

the output of $news_url is : /home/domain/public_html/is/frettir/frett_1/"
and $news_url2 is : Http://www.domain.com/is/frettir/frett_1/
Does the delete function not just use the same "upload_dir" option as the upload?
Any help would be appreciated :(

trying my best to solve my problem... get an error when I upload now.
"Lighthouse.jpg 	561.28 KB 	Error: SyntaxError: JSON.parse: unexpected character"
BUT it still uploads and when I fresh the page i get the thumbnail AND can delete it! So I'm close ;)
So.. any good advice how to debug this thing? "unexpected character" does not tell me much.

You need to use Firebug in FF to debug the JSON information open firebug click on console make sure (persist, profile and ALL) are selected and then refresh the upload page ctrl f5 and see if any errors show up? If not then continue to upload a file and see if any errors display. and go through the POST GET infromation displayed in the console output.

Thanks! I will try that..


Pipelinerun preview

Fix: https://github.com/redhat-developer/vscode-tekton/issues/175
Demo:

New 'edge' style:

Codecov Report

Merging #232 into master will decrease coverage by 2.51%.
The diff coverage is 61.06%.

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   72.91%   70.40%   -2.52%
==========================================
  Files          37       37
  Lines        2086     2328     +242
  Branches      329      394      +65
==========================================
+ Hits         1521     1639     +118
- Misses        565      689     +124

Impacted Files
Coverage Δ

src/cli.ts
76.56% <ø> (ø)

src/pipeline/preview-manager.ts
26.66% <0.00%> (ø)

src/kubectl.ts
12.82% <5.26%> (-9.91%)
:arrow_down:

src/pipeline/preview.ts
13.41% <5.26%> (-2.08%)
:arrow_down:

src/pipeline/pipeline-graph.ts
42.60% <35.29%> (-53.82%)
:arrow_down:

src/pipeline/pipeline-preview.ts
67.56% <50.00%> (-19.94%)
:arrow_down:

src/yaml-support/yaml-locator.ts
71.42% <66.66%> (ø)

src/util/tektonresources.virtualfs.ts
83.33% <79.16%> (-3.73%)
:arrow_down:

src/yaml-support/tkn-yaml.ts
91.69% <88.32%> (-5.31%)
:arrow_down:

src/extension.ts
89.52% <100.00%> (-0.10%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df9bf5...bd35198. Read the comment docs.


npm install fails on ubuntu 14.04.5 LTS

Trying to run atlas2 (commit 00e42767ce85e7f1788d62130e71f7a4f6a46a19) on an ubuntu box (node v6.10.3; npm  v3.10.10) leads to an error during npm install (see below). Is a newer version of node required? (According to the wiki v >= 6.7.0 is expected to work...)
Error message:
~/atlas2$ npm install

><EMAIL_ADDRESS>install /home/atlas/atlas2/node_modules/phantomjs-prebuilt
> node install.js

module.js:471
    throw err;
    ^

Error: Cannot find module 'graceful-fs'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/atlas/atlas2/node_modules/fs-extra/lib/index.js:4:11)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm ERR! Linux 3.13.0-55-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v6.10.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node install.js'.

The application uses phantomjs-prebuilt to run a headless browser required for png rendering. The headless browser is not a node application, but a platform specific binary, and as authors state:

We only have binaries available for common OS / processor configurations. Sorry.

That means the tool will not run on arm boxes, unless someone improves phantomjs. I will update the wiki.

Changes introduced to  https://github.com/cdaniel/atlas2/wiki/Dev-Setup


TypeError: Cannot convert undefined or null to object

Description
when baseUrl: 'engineersf.com in gatsby-config.js:
  TypeError: Cannot convert undefined or null to object

  - Function.keys

  - fetch.js:534 getValidRoutes
    [engineersf]/[gatsby-source-wordpress]/fetch.js:534:26

  - fetch.js:148 fetch
    [engineersf]/[gatsby-source-wordpress]/fetch.js:148:23

  - next_tick.js:68 process._tickCallback
    internal/process/next_tick.js:68:7

when run with baseUrl: 'wpdemo.gatsbycentral.com' that comes with the wordpress starter it works.
strangely allRoutes.data at fetch.js:534 is not an object and appears to be a json string, which I suspect is the root cause.
Steps to reproduce
https://github.com/danny-waite/engineersf.com
Environment
System:
OS: macOS 10.14.3
CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.9.0 - ~/.nvm/versions/node/v10.15.3/bin/npm
Languages:
Python: 2.7.10 - /usr/bin/python
Browsers:
Chrome: 76.0.3809.132
Safari: 12.0.3
npmPackages:
gatsby: ^2.15.14 => 2.15.14
gatsby-awesome-pagination: ^0.3.3 => 0.3.4
gatsby-plugin-lodash: ^3.1.7 => 3.1.7
gatsby-plugin-netlify: ^2.1.12 => 2.1.12
gatsby-plugin-purgecss: ^4.0.1 => 4.0.1
gatsby-plugin-react-helmet: ^3.1.7 => 3.1.7
gatsby-plugin-sass: ^2.1.14 => 2.1.14
gatsby-plugin-sharp: ^2.2.21 => 2.2.21
gatsby-remark-images: ^3.1.21 => 3.1.21
gatsby-source-filesystem: ^2.1.22 => 2.1.22
gatsby-source-wordpress: ^3.1.31 => 3.1.31
gatsby-transformer-remark: ^2.6.22 => 2.6.22
gatsby-transformer-sharp: ^2.2.14 => 2.2.14
npmGlobalPackages:
gatsby-cli: 2.7.47

I'm also having this exact issue

Same as #49, this is caused by the configuration of the WordPress site. I'll copy my comment from #49.

This is a tough issue. The produced GraphQL schema depends on what your WordPress config looks like. If you have a single post with a featured image, then the post schema gets a featured image field, if not, then it doesn't. Bottom line, you need to carefully setup WordPress to match our demo site's config. We've done our best to document that in the README. Very open to PRs which improve the readme, or add specific tests / better errors to make this stuff clearer.

I'll close this issue for the same reason as #49, it's not caused by this starter, but the WordPress site.


Remove CompoundPlug usage from shaders

This gets us to the point where we're not using CompoundPlug at all outside of GafferCortex, and even there I think we'll be able to cope without. So we're getting close to being able to remove it completely.
@ivanimanishi, I've found a couple of spots in Jabuka that may or may not be vulnerable to the changes introduced by this PR - I'll mail you with the details.

Are you waiting for anything from me on this one @andrewkaufman?


Retry logic

We should support different retry policies when making RPC calls

None
Exponential backoff (maximum time of 30s)

When sending out RPC requests with a timeout we should set expiration on a per message basis. This will help prevent queues from getting clogged up with requests that aren't being waited on. (Be mindful of correlation_id handling)
https://www.rabbitmq.com/ttl.html#per-message-ttl-in-publishers

https://www.rabbitmq.com/reliability.html


Error with symbol_map creation in asl_io.write.write_nl

On attempt to run simplest example in asl_io.write I have an error
AttributeError: 'float' object has no attribute 'model'
The error occurs in line #28 of write.py in preparing symbol_cuid_pairs .
I use Python 3.11.4 (miniconda) and Pyomo 6.7.1
It is the first time when I see this error on using Pyomo and your excellent asl_io functions. Bad news is that I have got the same error and with other Pyomo models...

FYI, this error appears with various Python 3.* interpreters but for Pyomo version younger than 6.5.0 only !
For Pyomo v. 6.5.0 and older the function write.write_nl() works normally.

Thank you for this issue - I couldn't figure the problem either, so I've downgraded my Pyomo version. I haven't been able to figure out which part of the 6.6.0 update broke this functionality. In 6.7.3, I got an error of
AttributeError: 'NoneType' object has no attribute 'model'
The error specifically calls to
  File "**\Python312\Lib\site-packages\pyomo\core\base\componentuid.py", line 414, in _generate_cuid
    model = component.model()
            ^^^^^^^^^^^^^^^

but I simply can't figure out what the update changed. Thank you for the functions, and if anyone can see a fix, I'd love to see it


Server Broke I Too many Files Error

https://hastebin.com/hacubefeju.shell
I have 0 scripts in globalscripts.
Using Skungee latest
Java 8
Linux (ubuntu)
Using only 2 Spigots and 1 Bungee (after a certain amount of time, it said that error)
then I weren't able to use the server, connect to it it said "Disconnected", and in Bungee console it showed errors that it took a long time to send the MOTD message.
It might have to do with the unknown host name error but i'm not 100% sure.

Update: It was spamming it constantly in the Lobby (spigot) server, It did not stop until i restarted

Posting this here incase hastebin expires https://pastebin.com/XCsCt1TJ

If you have other issues please share those console errors aswell. The too many files error happens when the Socket aka Skungee is connecting and disconnecting frequently, so something either the server or another plugin is causing this.

Yup, and in bungee it says this: https://pastebin.com/raw/BdFYWEF8.
Basically the server won't work.
When can you fix this? It is a very bad bug affecting my players + server

You need to configure your security settings to match the exact from the Spigot Skungee, they're currently not the same and it's erroring. Also don't just directly copy the entire configuration from Spigot to Bungee Skungee as I have seen users do that in the past.

Yes, I don't know if it is related to the bug above. But I did copy and paste the configs from the #1 spigot to the other spigots, and this happens sometimes.

Don't copy a paste the configurations.

16:31:11 [WARNING] Event ProxyPingEvent(connection=[/ip] <-> InitialHandler, response=ServerPing(version=ServerPing.Protocol(name= , protocol=404), players=ServerPing.Players(max=2019, online=0, sample=null), description=test, modinfo=ServerPing.ModInfo(type=FML, modList=[]))) took 10,011,000,227ns to process!
Usually this error shows in Bungee and players can't get the MOTD, when the above error happens (the post).

Try to increase the File Descriptor Limit if you own the dedicated server.


How to infer kitti data format with Waymo Pretrained model?

A point of my data include [ x,y,z,intensity]  . But the  Waymo  pretrained model  requires point with column 6.   Moreover , what's  information  in the 6 column  by  column order?

It includes x,y,z, intensity, elongation, timestamp (6-dim)


As a user I can search for vegan restaurants

so that my dietary requirements are met.

Added role to the user


Add docFn to lib, to automatically generate documentation for lib functions

This enables generating documentation about the lib.* functions automatically, and opens doors to a poor mans auto-complete of the standard library functions.
Motivation for this change
Currently it's pretty hard to find out which library functions exist. You have to manually scroll, or grep through the files in lib.
As a proof of concept, I've moved some of the functions in lib/strings.nix to use this docFn function.
The resulting manual build can be seen here.
Discussion

These library functions are used everywhere. This PR is implemented with functors, which might be to slow.
As an alternative, if this proves to be too slow, we could look into adding doc comments to Nix, that will be parsed and made inspectable just like builtins.functionArgs is today. (see the partial implementation)

Interesting! I use a similar approach to document styx functions and templates.
I didn't benchmark but this didn't seem to impact performance much, but as nixpkgs is much larger and complex, it might be of real impact.
This can also be pushed one step further to generate tests from examples.

Would it make sense to have a pure Nix XML builder? https://gist.github.com/anonymous/c52b3c9ca41f586a95a113d1a2bb26d3#file-to_xml-nix-L49-L63

@zimbatm I would use that if it was in nixpkgs.

I'm wondering  what people think about this idea, should I start drafting a RFC for this?

Just now there was a discussion again on IRC about this PR as well as #27394. Comparing the two,
this one seems neater because you won't have the problem of strings/sets of documentation ending up in your sets. As @zimbatm and @Profpatsch pointed out, there may indeed be performance implications.
@LnL7 and @grahamc just had the idea of rewriting the documented functions to just the bare functions when evaluating the fixpoint when something like docs ? false is passed.

My testing suggests this does not appreciably harm performance in some limited testing. @LnL7 also did some testing, and his results agreed with mine. I think we should continue with this route by setting up an eval on hydra to see how it really behaves. Perhaps also merging in some functionality /feedback from https://github.com/NixOS/nixpkgs/pull/27394 like:

types in an attribute
@edolstra's inputs / output example here for tests: https://github.com/NixOS/nixpkgs/pull/27394#issuecomment-316402342

I did also make lib a fixed-point to make it easier to replace the docsfn (https://github.com/NixOS/nixpkgs/compare/master...grahamc:fixed-lib) but I'd rather not merge this.

I don't know, this approach strikes me as too much magic. Values really should not produce different results depending on how they're evaluated (i.e. the x in the expression x y can now mean something different than the x in x.y). I'm not super fond of __functor for that reason.
An approach that doesn't rely on __functor would be something like:
id =
  { docString = "bla bla...";
    examples = [ ... ];
    implementation = x: x;
  };

and do a mapAttrs (n: v: v.implementation) in lib/default.nix.

I'm not super fond of __functor for that reason.

I’m curious: In what way does __functor resemble a functor?


Set TURN server on ACCEPT

We thought we could set the TURN servers and credentials also on accept using the same approach as in #250. But this does not seem to work. Is there any way we can set TURN Servers and credentials when a call is incoming?

Hi wackazong,
I've been looking into this issue this morning, and it looks like we could fix it with little hassle if RTCPeerConnection's 'updateIce' function was implemented correctly. Unfortunately, it looks like they are still working out some kinks.
I hesitate to make the larger change of not creating the MediaHandler until we call accept, so instead, I just completely replace the peerConnection if you pass turnServers or stunServers into the accept function. This also works with the progress function (for early media), but checks are done to ensure that early media calls can not get their peerConnection changed on accept (since media is already set up at that point, so you'd blow it out unknowingly).
Please let me know if this works for you.
Thanks,
James

I'm going to close this, but feel free to re-open if you are still experiencing issues. The changes can be found in version 0.7.3.
Thanks,
James


EPMRPP-68407 || Jira Cloud post issue

Closed in favor of https://github.com/reportportal/service-ui/pull/2917


Fix function comments based on best practices from Effective Go

Hi, we updated some exported function comments based on best practices from Effective Go. It’s admittedly a relatively minor fix up. Does this help you?

LGTM. Thanks!


Blink should support unbounded ranges

Ranges such as ..0 and 0.. are not supported by blink. This makes it impossible to represent ranges that enclose all positive or all negative numbers for example.

Added support for this in 5109d0c95ad9a4aad941d0f5baafd4533e7d8853.
Included in the latest release: v0.14.14.


render :nothing is deprecated; use head instead

I can't find the culprit. This code looks good.
But the failure looks valid:
  1) OpsController can view the db_connections tab
     Failure/Error: expect(response.status).to eq(200)

       expected: 200
            got: 404

       (compared using ==)
     # ./spec/controllers/ops_controller_spec.rb:47:in `block (2 levels) in <top (required)>'


[Form Provider Refactor] ACHContractStep

Details

Changed the Form component into the new FormProvider component in ACHContractStep
Fixed Issues

$ https://github.com/Expensify/App/issues/30314
Tests

Log into an account and create a workspace, make sure the currency of it is set to USD
Using the modal that appears after clicking your profile picture go into your workspace and into the Reimbursement page
Using the Connect the bank account functionality complete all the steps which are: adding your account manually, company form, personal form, either complete the onfido verification or mock correct data in code for faster testing on native devices and then check the correctness of the 4th step, which is labeled as Additional information
After pressing the required checkboxes confirm it with Save & continue and make sure it goes through to the next screen without any errors

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/88325488/504ff8ba-2919-4ee2-8625-37a469a7b857

Android: mWeb Chrome
https://github.com/Expensify/App/assets/88325488/9cfc1c4e-e38c-4bc9-abec-0b1f544a2527

iOS: Native
https://github.com/Expensify/App/assets/88325488/88b94bf2-fd44-4351-b53f-2c79edccaa32

iOS: mWeb Safari
https://github.com/Expensify/App/assets/88325488/2408896a-d7f4-42ce-aaa3-cce28de688a0

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/88325488/d1bb9111-9a1e-4d3d-a8ac-a7366a3c5819

MacOS: Desktop
https://github.com/Expensify/App/assets/88325488/8e458b42-be22-4dbf-bec7-e79378876f9c

@cdOut, a bit strange, when returning to step 3, the form values are reset to empty, but in the production environment, they still have values. 🤔

Should be fixed, the draft values were missing in form provider.
https://github.com/Expensify/App/assets/88325488/3ce42145-d132-4f3e-9a57-43cbfc957779


Intellisense on nodejs app files with no extension

VSCode Version: 1.2.0
OS Version: CentOS 7 -- NodeJS app

Steps to Reproduce:

Use express-generator to create a nodejs app; it creates a bin/www file with no extension
When editing the bin/www file, with language mode as JavaScript, the require, process, etc. entries are indicated as errors.
If a .js extension is added to the bin/www file - the intellisense no longer shows the entries as errors

A bit strange (at least from my perspective) as one would think that intellisense would be driven from the Language Mode not the extension, or lack thereof. "Normal" javascript intellisense is active BTW, it just seems to not be picking up the nodejs references.
Really like VSCode, VS Community just seems "too heavy" for a lot of small-medium projects.
Thanks,
David

We can now send the mode kind in an open. Need to see if this fixes it.

Sending the mode kind is only available in TS 2.0. Need to wait until it is officially available.

Unfortunately this will not make the August milestone since TS is not ready yet.

This got fixed for 1.6 release.


TypeError: RouterOSClient is not a constructor

i was tying to use this package with create-react-app with typescript, at the time of compilation everything goes right, but when i try to use, lets say this simple login function
import { IRosOptions, RouterOSClient } from 'routeros-client';

const login = async (cred: IRosOptions) => {
  const api = new RouterOSClient({ ...cred });
  try {
    const conn = await api.connect();
    if (api.isConnected()) api.disconnect();
    return true;
  } catch (error) {
    throw error;
  }
};

i got this error:
TypeError: net_1.Socket is not a constructor
    at Connector.connect (Connector.js:85)
    at RouterOSAPI.js:137
    at new Promise (<anonymous>)
    at RouterOSAPI.connect (RouterOSAPI.js:100)
    at RouterOSClient.connect (RouterOSClient.js:41)
    at login (MikrotikAPI.ts:19)
    at Login.handleLogin (Login.tsx:55)
    at HTMLUnknownElement.callCallback (react-dom.development.js:147)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:196)
    at invokeGuardedCallback (react-dom.development.js:250)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:265)
    at executeDispatch (react-dom.development.js:571)
    at executeDispatchesInOrder (react-dom.development.js:596)
    at executeDispatchesAndRelease (react-dom.development.js:695)
    at executeDispatchesAndReleaseTopLevel (react-dom.development.js:704)
    at forEachAccumulated (react-dom.development.js:676)
    at runEventsInBatch (react-dom.development.js:844)
    at runExtractedEventsInBatch (react-dom.development.js:852)
    at handleTopLevel (react-dom.development.js:5029)
    at batchedUpdates$1 (react-dom.development.js:21463)
    at batchedUpdates (react-dom.development.js:2247)
    at dispatchEvent (react-dom.development.js:5109)
    at react-dom.development.js:21520
    at Object.unstable_runWithPriority (scheduler.development.js:255)
    at interactiveUpdates$1 (react-dom.development.js:21519)
    at interactiveUpdates (react-dom.development.js:2268)
    at dispatchInteractiveEvent (react-dom.development.js:5085)

even if i change the syntax to old require as in the examples like this
import { IRosOptions } from 'routeros-client';

const { RouterOSClient } = require('routeros-client').RouterOSClient;

const login = async (cred: IRosOptions) => {
  const api = new RouterOSClient({ ...cred });
  try {
    const conn = await api.connect();
    if (api.isConnected()) api.disconnect();
    return true;
  } catch (error) {
    throw error;
  }
};

i got this error
TypeError: RouterOSClient is not a constructor
    at login (MikrotikAPI.ts:6)
    at Login.handleLogin (Login.tsx:55)
    at HTMLUnknownElement.callCallback (react-dom.development.js:147)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:196)
    at invokeGuardedCallback (react-dom.development.js:250)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:265)
    at executeDispatch (react-dom.development.js:571)
    at executeDispatchesInOrder (react-dom.development.js:596)
    at executeDispatchesAndRelease (react-dom.development.js:695)
    at executeDispatchesAndReleaseTopLevel (react-dom.development.js:704)
    at forEachAccumulated (react-dom.development.js:676)
    at runEventsInBatch (react-dom.development.js:844)
    at runExtractedEventsInBatch (react-dom.development.js:852)
    at handleTopLevel (react-dom.development.js:5029)
    at batchedUpdates$1 (react-dom.development.js:21463)
    at batchedUpdates (react-dom.development.js:2247)
    at dispatchEvent (react-dom.development.js:5109)
    at react-dom.development.js:21520
    at Object.unstable_runWithPriority (scheduler.development.js:255)
    at interactiveUpdates$1 (react-dom.development.js:21519)
    at interactiveUpdates (react-dom.development.js:2268)
    at dispatchInteractiveEvent (react-dom.development.js:5085)

im trying to make this work with React and typescript

Oh, I think you misunderstood something. This lib only works with NodeJS on the backend, since the browser won't allow us to work with lower level stuff like network sockets and etc. Packages like 'net', 'http' and etc are from nodejs itself.
You will probably need to setup a backend, connect to the routerboard through there, and on the frontend you query for data using REST or Websockets.

yeah my bad, i didnt understand at first why, i'll try to use this with electron.


Add search bar for managers

 Add a search bar in the manager page "Perform task in place of recommender"


Fix warnings in GitHub actions

Fixes these warnings

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/create-release@v1, actions/upload-release-asset@v1

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Signed-off-by: Sakshi Aggarwal<EMAIL_ADDRESS>

Closes #ISSUE_NUMBER

Is the official actions/create-release action not maintained anymore?

yes, the official actions/create-release action is no longer maintained by github. they deprecated the action and the repository has been archived. so this is alternative release action. but, there are plenty of other options out there that you can use.

yes, the official actions/create-release action is no longer maintained by github. they deprecated the action and the repository has been archived. so this is alternative release action. but, there are plenty of other options out there that you can use.

Ok, cool. This looks good to me, thanks!


Harden AAsCastExpr

Make RTA and the compiler more robust so it does not crashes on #1512
Also some refactorization is added.
Close #1512 (because not more segfault) but does not fix the underlying problem.

+1

reroll: the PR was opened prematurely (issue in the keyboard-hand coordination). Reroll to add tests and harden the same part in the compiler

+1


[Feature] Add signature validation

WHY are these changes introduced?

Because there is no Signature verification when using app proxy.

WHAT is this pull request doing?

Add Utils::validateSignature($params, $secret)
Type of change

[ ] Patch: Bug (non-breaking change which fixes an issue)
[x] Minor: New feature (non-breaking change which adds functionality)
[ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above
[x] I have added/updated tests for this change
[x] I have updated the documentation for public APIs from the library (if applicable)

great idea! It still works?