feat: progress bar headless and styled

What is it?

[x] Feature / enhancement
[ ] Bug
[ ] Docs / tests
[ ] Other

Why is it needed?
This PR adds a headless and styled progress bar component. This is a basic component in UI libraries.

Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[x] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

If you haven't already, I would go through the contributing section.
For the progress component to hit beta it needs:

Tests (see the select)
Docs (I noticed parts of the docs are still copied from the accordion)

Also side note: I like to look and see what do these headless component API's have in common and keep the API as minimal as possible. This is something we've done in the select component.
For example, is there anything Radix UI and Kobalte have that are the same API wise? What about functionality? Anything interesting?
What about kobalte and melt ui? etc.
Awesome job so far!

If you haven't already, I would go through the contributing section.
For the progress component to hit beta it needs:

Tests (see the select)
Docs (I noticed parts of the docs are still copied from the accordion)

side note: I like to look and see what do these headless component API's have in common and keep the API as minimal as possible. This is something we've done in the select component.

For example, is there anything Radix UI and Kobalte have that are the same API wise? What about functionality? Anything interesting?

What about kobalte and melt ui? etc.

Awesome job so far!

I looked at other libraries like Kobalte, MeltUI, and React-Aria.
Radix-UI and MeltUI go in a simple approach only handling with the Bar and Indicator. (as I did)
Kobalte and React-Aria go deeper, the Bar and Indicator belong to a bigger component which also handles with Label, Positioning, Size, and more. Can be an evolution, but not a must-have in my opinion.

If you haven't already, I would go through the contributing section.
For the progress component to hit beta it needs:

Tests (see the select)
Docs (I noticed parts of the docs are still copied from the accordion)

side note: I like to look and see what do these headless component API's have in common and keep the API as minimal as possible. This is something we've done in the select component.

For example, is there anything Radix UI and Kobalte have that are the same API wise? What about functionality? Anything interesting?

What about kobalte and melt ui? etc.

Awesome job so far!

I looked at other libraries like Kobalte, MeltUI, and React-Aria. Radix-UI and MeltUI go in a simple approach only handling with the Bar and Indicator. (as I did)
Kobalte and React-Aria go deeper, the Bar and Indicator belong to a bigger component which also handles with Label, Positioning, Size, and more. Can be an evolution, but not a must-have in my opinion.

Yeah keeping the API simple is great. I'd be curious to know what use cases where React Aria and Kobalte had to use a more complex approach though, and whether there was some actual demand for those use cases.

Happy to merge this initial PR once the comments above have been changed. To recap:

Remove duplicate docs
Remove the visible task
Change the component name to match the library convention
Change data-state to data-progress

To hit beta:

Can be used for most basic use cases
Add docs
Add tests

Also happy to help and pair if you have any questions 👍

Happy to merge this initial PR once the comments above have been changed. To recap:

Remove duplicate docs
Remove the visible task
Change the component name to match the library convention
Change data-state to data-progress

To hit beta:

Can be used for most basic use cases
Add docs
Add tests

Also happy to help and pair if you have any questions 👍

All changes were made, and I also added some simple tests.

Looks good! Merging this initial pr.

Also side note: marking a PR as ready for review will run the CI. Checks if all the tests are passing, any TS errors etc.


Setting create-issues: true wil crash the code

curl -sSL https://download.sourceclear.com/ci.sh | sh -s -- scan . --recursive --allow-dirty --update-advisor  --json=scaResults.json
Starting the scan
/runner/_work/_actions/veracode/veracode-sca/v2.1.6/dist/index.js:18132
output = ${output}${data};
^
RangeError: Invalid string length
at Socket. (/runner/_work/_actions/veracode/veracode-sca/v2.1.6/dist/index.js:18132:42)
at Socket.emit (node:events:527:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

scaResult.json create json with graphs array within json that is never user and creates a bloated scaResults.json

@bnakhlis I think this is already fixed for a while but the issue was never updated. Will close this, if the issue still persists please reopen it.


Add substr tests

As discussed in #258 it seems like SUBSTR is indeed supported and the error was most likely due to case sensitivity.
This PR adds a couple of test cases for SUBSTR since only SUBSTRING was covered.
Also a minor change that replaces the use of now deprecated distutils.version.LooseVersion with packaging.version.Version

Codecov Report

Merging #372 (420ffa9) into main (408f976) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   95.57%   95.46%   -0.11%
==========================================
  Files          67       67
  Lines        2935     2930       -5
  Branches      547      546       -1
==========================================
- Hits         2805     2797       -8
- Misses         79       83       +4
+ Partials       51       50       -1

Impacted Files
Coverage Δ

dask_sql/_compat.py
100.00% <100.00%> (ø)

dask_sql/physical/rel/custom/show_models.py
53.33% <0.00%> (-26.67%)
:arrow_down:

dask_sql/physical/rel/custom/predict.py
95.34% <0.00%> (-0.11%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

dask_sql/physical/utils/sort.py
93.10% <0.00%> (+2.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408f976...420ffa9. Read the comment docs.


The connection to the GPM cannot be established

can this please stop be a thing when I break something in theme?
make it non dependent somehow, please.

How are you getting this error?  It's usually something related to the connection your on, or possible to JS that is failing. I assume this is happening in the admin plugin? We really need more detail on how you are getting this error.

@rhuk I think I've come across a repeatable recipe for this mysterious issue.
Here is my default Course Bootstrap YAML:
name: Course Hub Bootstrap
version: 1.9.6
description: "A customized version of the Bootstrap theme (built with Bootstrap 3) for use with the Grav Course Hub skeleton package."
icon: university
author:
 name: Paul Hibbitts
 email<EMAIL_ADDRESS> url: http://hibbittsdesign.org
homepage: https://github.com/hibbitts-design/grav-theme-course-hub-bootstrap
demo: http://demo.hibbittsdesign.org/grav-course-hub-bootstrap
keywords: bootstrap, theme, framework, course, lms
bugs: https://github.com/hibbitts-design/grav-theme-course-hub-bootstrap/issues
license: MIT

dependencies:
  - bootstrap
  - bootstrapper
  - admin
  - archives
  - email
  - error
  - external_links
  - featherlight
  - feed
  - form
  - git-sync
  - login
  - markdown-fontawesome
  - markdown-notices
  - page-inject
  - pagination
  - problems
  - relatedpages
  - simplesearch
  - taxonomylist
  - youtube

form:
  validation: strict
  fields:
    dropdown.enabled:
        type: toggle
        label: Dropdown in navbar
        highlight: 1
        default: 1
        options:
          1: Enabled
          0: Disabled
        validate:
          type: bool

When I was trying to add a new field, I accidentally got the indent a bit wrong:
name: Course Hub Bootstrap
version: 1.9.6
description: "A customized version of the Bootstrap theme (built with Bootstrap 3) for use with the Grav Course Hub skeleton package."
icon: university
author:
 name: Paul Hibbitts
 email<EMAIL_ADDRESS> url: http://hibbittsdesign.org
homepage: https://github.com/hibbitts-design/grav-theme-course-hub-bootstrap
demo: http://demo.hibbittsdesign.org/grav-course-hub-bootstrap
keywords: bootstrap, theme, framework, course, lms
bugs: https://github.com/hibbitts-design/grav-theme-course-hub-bootstrap/issues
license: MIT

dependencies:
  - bootstrap
  - bootstrapper
  - admin
  - archives
  - email
  - error
  - external_links
  - featherlight
  - feed
  - form
  - git-sync
  - login
  - markdown-fontawesome
  - markdown-notices
  - page-inject
  - pagination
  - problems
  - relatedpages
  - simplesearch
  - taxonomylist
  - youtube

form:
  validation: strict
  fields:
    dropdown.enabled:
        type: toggle
        label: Dropdown in navbar
        highlight: 1
        default: 1
        options:
          1: Enabled
          0: Disabled
        validate:
          type: bool

      bootstrapcss:
          type: select
          size: small
          label: Bootstrap CSS
          default: default
          options:
              default: Default
              canvaslms: Canvas LMS

The above YAML actually triggers the **The connection to the GPM cannot be established ** message! After I unindented the bootstrapcss to align properly the message disappeared and all worked fine.
I hope this info is of help🙂

ok that helps thanks @paulhibbitts... can probably recreate the issue now and get a fix in.


Expose additional values for prometheus configmap-reload in values.yaml

@mgoodness
What this PR does / why we need it:
The config-reload image used in the prometheus chart allows multiple directories to be monitored to trigger config-reloads so expose extraArgs and extraConfigMapMounts in values.yaml so this functionality can be used.
This allows us to do things like separating the alert configs from the main prometheus config making them easier to manage and update.

/assign @mgoodness

@timstoop - made the suggested changes. Thanks!

/ok-to-test

/lgtm

/assign @mgoodness

@timstoop @mgoodness Hold off doing anything with this. I need to split the volumes from the mounts as currently, if for example prometheus-server AND configmap-reload both want to mount the same extraConfigmapMounts, it'll try to create the volume twice and fail. This is because it's creating the volumes based on the mounts here

@mgoodness @timstoop closing in favour of https://github.com/kubernetes/charts/pull/4511


feat: add filter to getAll Pizza

This PR adds a filter to getAll in Pizza model.
Changelog

Creates buildLikeFilter, buildValorFilter and buildWhere pizza helpers;
Refactor the getAll.

@lucaspere can you add postman collection with request and filters for Pizza? Or, cURL. For me to test


Update package/shopify with examples

Added more helpful data in package/shopify to enhance the user view

Nice work @Tarunsharmadoc


bug: Can't find local modules in fresh setup.

Provide environment information
    OS: Windows 11 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
    Memory: 5.34 GB / 15.89 GB
  Binaries:
    Node: 20.15.1 - C:\Program Files\nodejs\node.EXE
    npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.5.0 - ~\AppData\Local\pnpm\pnpm.EXE```

### Describe the bug

1. I grab code using ``npx create-turbo@latest -e https://github.com/t3-oss/create-t3-turbo``.
2. copied ``.env.example`` into ``.env``, changed pg link with real one.
3. ``pnpm install``. done.
4. ``pnpm db:push``. done.
5.  but when I open my editor and just looking through files and found TS Errors on multiple pages:
like... ``packages/auth/src/config.ts``, saying that ``Cannot find module '@acme/db/client' or its corresponding type declarations.`` and ``Cannot find module '@acme/db/schema' or its corresponding type declarations.`` for imports.

I did restart editor as well as tried restart ts server and eslint server. but not errors not going away.

I thought may be i need to run ``pnpm run dev``. for first time to create types and all, but when i ``pnpm dev``,
got errors:

```pnpm dev

> create-t3-turbo@ dev C:\Users\KKR\Desktop\myAppName-t3-oss\v1
> turbo watch dev

╭──────────────────────────────────────────────────────────────────────╮
│                                                                      │
│                   Update available v2.0.8 ≫ v2.0.9                   │
│    Changelog: https://github.com/vercel/turbo/releases/tag/v2.0.9    │
│           Run "npx @turbo/codemod@latest update" to update           │
│                                                                      │
│        Follow @turborepo for updates: https://x.com/turborepo        │
╰──────────────────────────────────────────────────────────────────────╯
 WARNING  stale pid file at "C:\\Users\\KKR\\AppData\\Local\\Temp\\turbod\\f0d016d61cf905e5\\turbod.pid"
• Packages in scope: @acme/api, @acme/auth, @acme/auth-proxy, @acme/db, @acme/eslint-config, @acme/expo, @acme/github, @acme/nextjs, @acme/prettier-config, @acme/tailwind-config, @acme/tsconfig, @acme/ui, @acme/validators
• Running dev in 13 packages
• Remote caching disabled
┌ @acme/validators#dev > cache bypass, force executing 782b224cb9d9b149
│
│ ><EMAIL_ADDRESS>dev C:\Users\KKR\Desktop\myAppName-t3-oss\v1\packages\validators
│ > tsc
└────>
┌ @acme/db#dev > cache bypass, force executing e8177f459864e042
│
│ ><EMAIL_ADDRESS>dev C:\Users\KKR\Desktop\myAppName-t3-oss\v1\packages\db
│ > tsc
└────>
┌ @acme/nextjs#dev > cache bypass, force executing 4442dada2215f5ed
│
│ ><EMAIL_ADDRESS>dev C:\Users\KKR\Desktop\myAppName-t3-oss\v1\apps\nextjs
│ > pnpm with-env next dev
│
│
│ ><EMAIL_ADDRESS>with-env C:\Users\KKR\Desktop\myAppName-t3-oss\v1\apps\nextjs
│ > dotenv -e ../../.env -- "next" "dev"
│
│   ▲ Next.js 14.2.4
│   - Local:        http://localhost:3000
│
│  ✓ Starting...
└────>
┌ @acme/ui#dev > cache bypass, force executing<PHONE_NUMBER>def477
│
│ ><EMAIL_ADDRESS>dev C:\Users\KKR\Desktop\myAppName-t3-oss\v1\packages\ui
│ > tsc
└────>
┌ @acme/expo#dev > cache bypass, force executing 8758b0bff027807a
│
│ ><EMAIL_ADDRESS>dev C:\Users\KKR\Desktop\myAppName-t3-oss\v1\apps\expo
│ > expo start
│
│ Starting project at C:\Users\KKR\Desktop\myAppName-t3-oss\v1\apps\expo
│ Using src/app as the root directory for Expo Router.
│ Starting Metro Bundler
└────>
┌ @acme/api#dev > cache bypass, force executing 25e8ecbdf0d11b4a
│
│ ><EMAIL_ADDRESS>dev C:\Users\KKR\Desktop\myAppName-t3-oss\v1\packages\api
│ > tsc
│
│ src/router/post.ts:4:26 - error TS2307: Cannot find module '@acme/db' or its corresponding type declarations.
│
│ 4 import { desc, eq } from "@acme/db";
│                            ~~~~~~~~~~
│
│ src/router/post.ts:5:40 - error TS2307: Cannot find module '@acme/db/schema' or its corresponding type declarations.
│
│ 5 import { CreatePostSchema, Post } from "@acme/db/schema";
│                                          ~~~~~~~~~~~~~~~~~
│
│ src/trpc.ts:15:20 - error TS2307: Cannot find module '@acme/db/client' or its corresponding type declarations.
│
│ 15 import { db } from "@acme/db/client";
│                       ~~~~~~~~~~~~~~~~~
│
│ ../auth/src/config.ts:10:20 - error TS2307: Cannot find module '@acme/db/client' or its corresponding type declarations.
│
│ 10 import { db } from "@acme/db/client";
│                       ~~~~~~~~~~~~~~~~~
│
│ ../auth/src/config.ts:11:40 - error TS2307: Cannot find module '@acme/db/schema' or its corresponding type declarations.
│
│ 11 import { Account, Session, User } from "@acme/db/schema";
│                                           ~~~~~~~~~~~~~~~~~
│
│
│ Found 5 errors in 3 files.
│
│ Errors  Files
│      2  src/router/post.ts:4
│      1  src/trpc.ts:15
│      2  ../auth/src/config.ts:10
│  ELIFECYCLE  Command failed with exit code 2.
│ command finished with error: command (C:\Users\KKR\Desktop\myAppName-t3-oss\v1\packages\api) C:\Users\KKR\AppData\Local\pnpm\pnpm.exe run dev exited (2)
└────>
  × internal errors encountered: unable to determine why task exited

Link to reproduction
https://github.com/t3-oss/create-t3-turbo
To reproduce
I did not change any part. not a single word. I did changed env vars, which works perfectly because I did pnpm db:push and worked. i confirmed with my supabase dashboard. all tables created. so I have no idea what to fix.
Additional information
No response

for visual ref:

Did u try: pnpm run build in root?

Did u try: pnpm run build in root?

pwsh> pnpm build

> create-t3-turbo@ build C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1
> turbo run build

╭──────────────────────────────────────────────────────────────────────╮
│                                                                      │
│                   Update available v2.0.8 ≫ v2.0.9                   │
│    Changelog: https://github.com/vercel/turbo/releases/tag/v2.0.9    │
│           Run "npx @turbo/codemod@latest update" to update           │
│                                                                      │
│        Follow @turborepo for updates: https://x.com/turborepo        │
╰──────────────────────────────────────────────────────────────────────╯
• Packages in scope: @acme/api, @acme/auth, @acme/auth-proxy, @acme/db, @acme/eslint-config, @acme/expo, @acme/github, @acme/nextjs, @acme/prettier-config, @acme/tailwind-config, @acme/tsconfig, @acme/ui, @acme/validators
• Running build in 13 packages
• Remote caching disabled
┌ @acme/db#build > cache hit (outputs already on disk), replaying logs 459277a26a34a2db
│
│ ><EMAIL_ADDRESS>build C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\packages\db
│ > tsc
└────>
┌ @acme/ui#build > cache hit (outputs already on disk), replaying logs 00fec255097d554b
│
│ ><EMAIL_ADDRESS>build C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\packages\ui
│ > tsc
└────>
┌ @acme/validators#build > cache hit, replaying logs d65186b9438feae2
│
│ ><EMAIL_ADDRESS>build C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\packages\validators
│ > tsc
└────>
┌ @acme/api#build > cache hit, replaying logs c79197e431b63d2a
│
│ ><EMAIL_ADDRESS>build C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\packages\api
│ > tsc
└────>
┌ @acme/auth-proxy#build > cache miss, executing 854adffeec4fb7d8
│
│ > @acme/auth-proxy@ build C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\apps\auth-proxy
│ > nitro build
│
│ ✔ Generated public .output/public                                                                                n
│ itro 12:25:16 pm
│ ℹ Building Nitro Server (preset: node-server)                                                                                n
│ itro 12:25:16 pm
│<EMAIL_ADDRESS>(1:30): The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
│<EMAIL_ADDRESS>(1:38): The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
│<EMAIL_ADDRESS>(7:30): The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
│<EMAIL_ADDRESS>(7:38): The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
│ ^C ELIFECYCLE  Command failed with exit code<PHONE_NUMBER>.
└────>
┌ @acme/nextjs#build > cache miss, executing c6ad9ab5c0759d25
│
│ ><EMAIL_ADDRESS>build C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\apps\nextjs
│ > pnpm with-env next build
│
│
│ ><EMAIL_ADDRESS>with-env C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\apps\nextjs
│ > dotenv -e ../../.env -- "next" "build"
│
│   ▲ Next.js 14.2.4
│
│    Creating an optimized production build ...
│ Failed to compile.
│
│ ./src/app/api/trpc/[trpc]/route.ts
│ Module not found: Can't resolve '@acme/api'
│
│ https://nextjs.org/docs/messages/module-not-found
│
│ ./src/trpc/server.ts
│ Module not found: Can't resolve '@acme/api'
│
│ https://nextjs.org/docs/messages/module-not-found
│
│ Import trace for requested module:
│ ./src/app/page.tsx
│
│
│ > Build failed because of webpack errors
│  ELIFECYCLE  Command failed with exit code 1.
│  ELIFECYCLE  Command failed with exit code 1.
│ command finished with error: command (C:\Users\patel\OneDrive\Desktop\t3-next\mono\v1\apps\nextjs) C:\Users\patel\AppData\Roaming\npm\pnpm.cmd run build exited (1)
└────>
  × internal errors encountered: unable to determine why task exited

 ELIFECYCLE  Command failed with exit code 1.```

To fix this, you can try clearing your cache, removing all your projects, deleting the pnpm~.lock file, and then installing the dependencies again.
Also, it seems like a new version of @auth/core and next-auth is being installed, along with the drizzle adapter. I know that installing a new version can sometimes cause issues.
These packages are still in beta, so be aware of that.
If you’re getting new versions, you can remove the ^ from the package version to get exactly that version, if you want to wait for the PR to fix the code.

To fix this, you can try clearing your cache, removing all your projects, deleting the pnpm~.lock file, and then installing the dependencies again.
Also, it seems like a new version of @auth/core and next-auth is being installed, along with the drizzle adapter. I know that installing a new version can sometimes cause issues.
These packages are still in beta, so be aware of that.
If you’re getting new versions, you can remove the ^ from the package version to get exactly that version, if you want to wait for the PR to fix the code.

thanks. I ran pnpm clean:workspaces, pnpm store prune, rm -rf .turbo, reinstalled with pnpm i and then pnpm build and things worked.

To fix this, you can try clearing your cache, removing all your projects, deleting the pnpm~.lock file, and then installing the dependencies again.
Also, it seems like a new version of @auth/core and next-auth is being installed, along with the drizzle adapter. I know that installing a new version can sometimes cause issues.
These packages are still in beta, so be aware of that.
If you’re getting new versions, you can remove the ^ from the package version to get exactly that version, if you want to wait for the PR to fix the code.

thanks. I ran pnpm clean:workspaces, pnpm store prune, rm -rf .turbo, reinstalled with pnpm i and then pnpm build and things worked.

Thanks a lot for this


Fixed some cases where trying to create an already existing directory was returning an error

ping @jrouault

Good stuff :+1:

Good to go, thanks for the fix :runner:


Clues: Rope/Light Source Visibility

Elite clue: "I live in a deserted crack collecting soles".
Solution: Enter the crack west of nardah rug merchant and talk to the genie.
While the clue notes that you need a rope and light source to enter the crack, it would be useful if those items were indicated with green check / red x depending on whether or not the player has them in their inventory, similar to how a spade is treated for clues where it is needed.
Note: There may be other clues requiring ropes, light sources, or other items. I can think of a few off-hand where they are useful, but for those cases they are not necessary (lummy swamp cave emote light source, observatory cbow+mith grapple). I would like input as to whether or not there would be value to taking a similar approach for these clues. If anyone knows of any other clues with necessary/helpful items it might be nice to comment them on this issue.

It's difficult to accurately label all clues with these requirements because many have multiple routes allowed to complete them or conditions which may make certain requirements obsolete. (eg. observatory has no travel item requirements if the grapple shortcut has been taken, dragontooth island clues have no ecto-token requirement if the ghost captain had been paid the 500 token one-time fee)
That said, others like the desert genie clue could certainly be changed to use more traditional item requirements since that requirement is fixed for all players and has no alternate route.

Not sure if there is either or functionality, but an easy clue to talk to the head chef of chef's guild requires a chef's hat or cooking cape

I'd also leave a +1 to this, there's an elite coordinate clue that needs you to go through cave horrors, and you either need the witchwood icon or a full set of prayer points to pray Protect from Melee.  Maybe a hint text could be a good medium for the optional requirements.

I'll see what I can do -- working on some clue improvements at the moment, no promises though

I double checked the desert Genie clue, and it does have a light requirement set.
Some time in the future, we will get the clue plugin to a state where we can add more arbitrary requirements, and perhaps even recommended requirements. There's work to do before we get to that state though.


Add a check to make plug-ins more secure (draft)

I thought this would increase the security of the WIP plug-ins feature a bit.

Adds function to match plug-in against regexes before adding it to the script, and prints an error into the console if something went wrong

Disallowing process wouldn't matter anyways since nodeIntegration is off right? And what's the problem with eval?

Disallowing process wouldn't matter anyways since nodeIntegration is off right?

Better safe than sorry.

This would be easily bypassed.

@ScolderCreations Is this PR finished?

@ScolderCreations Please add feat: to the beginning of your PR.

@ScolderCreations Any updates to this PR?

Bypassable - obj[key]

Bypassable - obj[key]

Yeah, that’s why I left room for additional regex checks.


Changed namespace of DrawingBarAction to Microsoft.Maps.DrawingTools

Moved DrawingBarAction from Microsoft.Maps to Microsoft.Maps.DrawingTools so it has that namespace

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: perfahlen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you


Added reconnection support.

This will handle closures from the socket and reconnect after sometime. (This could be changed to an option)
This will then resub to all the events it was sub'd to and the original callbacks should then start to get the event payloads again.

@artdude543, thanks for your PR! By analyzing the blame information on this pull request, we identified @UnwrittenFun to be a potential reviewer

Looks good overall, reconnection policy injection is the primary concern

@connor4312 I think I understood on what you was after for the reconnection policy. Based on the timing we have on the chat client socket. Unless I got the wrong idea for what you was after?

Good start, I was meaning that the policy should be typed to an interface so people can provide their own customized backoff strategies. Things often end up being tweaked as projects and load patterns change.

Oh I see, so how like the WebSocket, Promise is being set. To have the same / similar thing for a ReconnectionPolicy class to allow people to inject their own thing as long as it has the methods the client wants?

Yep

Okay I think I understood this time around! 🐹

Also yes @UnwrittenFun tslint would be nice :P


Update dependencies

Fixes #25. Fixes #22. Fixes #24.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 98.246%

Totals

Change from base Build<PHONE_NUMBER>:
1.2%

Covered Lines:
168

Relevant Lines:
171

💛  - Coveralls

Codecov Report

Merging #26 (e212540) into main (af76f1b) will increase coverage by 1.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   97.00%   98.24%   +1.23%
==========================================
  Files           4        4
  Lines         167      171       +4
==========================================
+ Hits          162      168       +6
+ Misses          5        3       -2

Impacted Files
Coverage Δ

src/exact.jl
100.00% <0.00%> (+1.76%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


how can i install it?

HI im new in ROS WORLD and i read about your IDE DEVELOPMENT , but i dont know how can i install it

I would like to notify the creator of the project, in case they're not aware, that the roboware studio website is currently a purchasable domain and does not host the download/install link. The ROS wiki still refers back to this page and does not have any instructions for install that work without said website. This software is extremely valuable, and currently there is no documented method of installation. It is also unclear if the program works with ROS2 as well as ROS. I would really, really think it was nice if this was updated. No pressure ofc, you may have moved on to bigger and better things, but a little update here and there would be pretty handy.

I thought there was no hope and only way was to build it yourself but I stumbled across this other repository:
https://github.com/TonyRobotics/RoboWare
You just need to download right file for your system and install it. For me (on Ubuntu 64bit) it was roboware-studio_1.2.0-1524709819_amd64.deb. After downloading just double click the file and you can install it via 'Ubuntu Software' or if you like you can use terminal

Install
To download the deb file from this link https://github.com/TonyRobotics/RoboWare/tree/master/Studio, after you download the deb fiel  then double click it

It seems like the package doesn't work on Linux 20.04. Please update. Thanks


Consistency fixes

As discussed on the list. Here are the points mentioned broken down to separate commits.

@michael-o I am fine with everything except for 21fb5c1. I would prefer to keep LangUtils until 5.1.

@michael-o I am fine with everything except for 21fb5c1. I would prefer to keep LangUtils until 5.1.

If a public API is released in 5.x, we cannot drop it until 6.0, we should drop it now.

@michael-o I am fine with everything except for 21fb5c1. I would prefer to keep LangUtils until 5.1.

If a public API is released in 5.x, we cannot drop it until 6.0, we should drop it now.

I actually had the same question. I don't mind keeping it, but I see no benefit in doing so.

I have moved the LangUtils removal on top to be easily moved to a separate branch if it shall be retained for any reason in 5.0.

If a public API is released in 5.x, we cannot drop it until 6.0, we should drop it now.

@michael-o We do not need to drop it. We can deprecate it and stop using it. What I dislike about Objects is that hideous static int hash(Object... values) with an extra array allocation due to vararg signature. I would like to upgrade to JRE 8 or 11 and then consider deprecating LangUtils in favor of Objects

If a public API is released in 5.x, we cannot drop it until 6.0, we should drop it now.

@michael-o We do not need to drop it. We can deprecate it and stop using it. What I dislike about Objects is that hideous static int hash(Object... values) with an extra array allocation due to vararg signature. I would like to upgrade to JRE 8 or 11 and then consider deprecating LangUtils in favor of Objects

Now I understand, makes sense. How would Java 8 or 11 make it any better? Those has methods exist since Java 7.

If a public API is released in 5.x, we cannot drop it until 6.0, we should drop it now.

@michael-o We do not need to drop it. We can deprecate it and stop using it. What I dislike about Objects is that hideous static int hash(Object... values) with an extra array allocation due to vararg signature. I would like to upgrade to JRE 8 or 11 and then consider deprecating LangUtils in favor of Objects

Now I understand, makes sense. How would Java 8 or 11 make it any better? Those has methods exist since Java 7.

@michael-o I recall reading that possibly some newer JVMs include a special optimization routine specifically for Objects#hash but it had no time to investigate it.

If a public API is released in 5.x, we cannot drop it until 6.0, we should drop it now.

@michael-o We do not need to drop it. We can deprecate it and stop using it. What I dislike about Objects is that hideous static int hash(Object... values) with an extra array allocation due to vararg signature. I would like to upgrade to JRE 8 or 11 and then consider deprecating LangUtils in favor of Objects

Now I understand, makes sense. How would Java 8 or 11 make it any better? Those has methods exist since Java 7.

@michael-o I recall reading that possibly some newer JVMs include a special optimization routine specifically for Objects#hash but it had no time to investigate it.

Alright, will move it out and merge the rest to master.

Changes merged except LangUtils removal.


Update plugins.md

Added verdaccio-bitbucket plugin, a new version for old sinopia-bitbucket
Type: bug / feature
The following has been addressed in the PR:

There is a related issue
Unit or Functional tests are included in the PR

Description:
Resolves #???

Happy to merge 🤓


"webrtc_aec" module to readmap

Would it be possible to add "webrtc_aec" module to roadmap?
https://github.com/alfredh/baresip-android/issues/24#issuecomment-410344813

yes, the Wiki page is open for anyone to edit.
Please feel free to add the webrtc_aec module to the Roadmap.

Done.


Rebuild tsid to get a build with urdfdom 3

mamba create -n pintsid pinocchio=2.6.8 tsid=1.6.1 currently fails as there is no recent build of tsid compiled with the latest urdfdom, so if an user wants to install tsid it is forced to install an older version of pinocchio. This PR is a workaround for this, forcing a rebuild of tsid that will get compiled with the latest pinocchio. In a sense, this problem is similar to the one described for sdformat v9 in https://github.com/osrf/gazebo/pull/3223#issuecomment-1140019713, and the proper solution is managing urdfdom in https://github.com/conda-forge/conda-forge-pinning-feedstock, as proposed in https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/2925 .

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Is it ready to be merged?

Yes!


GEODE-9009: Finish support for functionality compatible with Redis DE…

…CRBY command
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

force pushed to include "(cherry-picked from )" mesg -  forgot to use -x flag when I cherry-picked


Implement auto-completion

This seems to be a big task but it is definitely worth it.
Maybe SC autocomplete could be implemented via https://langserver.org/
Other implementations of an IDE such as vim, emacs or atom mostly rely on static keywords.
There is an interesting idea mentioned at https://github.com/crucialfelix/atom-supercollider/issues/22#issue-41791462

The Class documentation can be helpful for this.
List all Classes
Class.allClasses.do({|c|
    c.postln;
    nil;
});

Find all methods of a class
Array.dumpAllMethods;

returns
Instance Methods for Array

   reverse (  )
   scramble (  )
   mirror (  )
   mirror1 (  )
   mirror2 (  )
   stutter ( n )
   rotate ( n )

This also returns all Methods of all Superclasses.
Find help for class
Array.helpFilePath

returns
SCDoc: Indexing help-files...
SCDoc: Indexed 2208 documents in 1.18 seconds
-> file:///Users/xxx/Library/Application Support/SuperCollider/Help/Classes/Array.html

This html file contains a link at the end to the schelp file which can be displayed nicer than HTML in a tooltip

helpfile source: /Applications/SuperCollider.app/Contents/Resources/HelpSource/Classes/Class.schelp
link::Classes/Class::

A basic auto-complete is implemented but it is yet very buggy and has no intelligence in it - but regarding the reference implementation in SC IDE it seems there is no proper way to get the methods of an object.

Taking a look at these resources could be helpful
https://github.com/supercollider/supercollider/blob/79c9d77f3946a3caf49fc0522319b52acd51878d/SCClassLibrary/scide_scqt/ScIDE.sc
https://github.com/supercollider/supercollider/blob/fb89a8b6eda01a12593b0976dadc73936628dd0c/SCClassLibrary/Common/Core/Kernel.sc#L622

(
var methodExtractor = {|method|
	(
		name: method.name,
		arguments: method.argNames.collect({|argName, i|
			(
				name: argName,
				default: method.prototypeFrame[i],
			)
		});
	)
};

x = Class.allClasses.collect({|class|
	(
		name: class.name,
		sourceFile: class.filenameSymbol,
                // meta class does not have helpFilePath implemented
		helpFile: if(class.isMetaClass, {""}, {class.helpFilePath}),
		methods: class.methods.collect({|m|
			methodExtractor.value(m);
		}),
		classMethods: class.class.methods.collect({|m|
			methodExtractor.value(m);
		});
	)
});
)

one class as JSON becomes
{
    "classMethods": [
        {
            "arguments": [
                {
                    "name": "this"
                },
                {
                    "default": 28,
                    "name": "columns"
                },
                {
                    "default": 7,
                    "name": "rows"
                },
                {
                    "default": 0.6,
                    "name": "lambda"
                },
                {
                    "default": 1.0,
                    "name": "sigma"
                },
                {
                    "default": 2,
                    "name": "singleEventsPerSec"
                },
                {
                    "default": 5,
                    "name": "maxEventOrder"
                }
            ],
            "name": "new"
        },
        {
            "arguments": [
                {
                    "name": "this"
                },
                {
                    "name": "lambda"
                },
                {
                    "name": "k"
                }
            ],
            "name": "poisson"
        }
    ],
    "helpFile": "file:\/\/\/Users\/scheiba\/Library\/Application Support\/SuperCollider\/Help\/Classes\/Aachorripsis.html",
    "methods": [
        {
            "name": "columns"
        },
        {
            "name": "rows"
        },
        {
            "name": "lambda"
        },
        {
            "name": "sigma"
        },
        {
            "name": "maxEventOrder"
        },
        {
            "name": "matrix"
        },
        {
            "name": "p"
        },
        {
            "arguments": [
                {
                    "name": "this"
                }
            ],
            "name": "init"
        },
        {
            "arguments": [
                {
                    "name": "this"
                },
                {
                    "name": "eventType"
                },
                {
                    "name": "simEvents"
                }
            ],
            "name": "prInsertEvent"
        }
    ],
    "name": "Aachorripsis",
    "sourceFile": "\/Users\/scheiba\/github\/aachorripsis\/Classes\/Aachorripsis.sc"
}

Maybe we could parse the Help Files like in the IDE as well?

this results in a 13mb JSON which is not really practical anymore :/
Maybe we can instead rely on the OSC communication for this?


tab bug after removing addon "sync tab groups" old tabs will not load due to lazytab.

After I had removed your addon "sync tab groups" from my Firefox. When I go to click on a tab, that has not been loaded for a long time. I keep getting this bug:
moz-extension://f4730929-7b9a-4f3b-9d0c-267827747e10/tabpages/lazytab/lazytab.html?title=bluejay%20in%20Plants%2C%20Seeds%20%26%20Bulbs%20%7C%20eBay&url=https%3A//www.ebay.co.uk/sch/Plants-Seeds-Bulbs/181003/i.html%3F_from%3DR40%26_nkw%3Dbluejay&favIconUrl=data%3Aimage/x-icon%3Bbase64%2CAAABAAEAEBAAAAEAIABoBAAAFgAAACgAAAAQAAAAIAAAAAEAIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP84MuX/ODLl/zgy5f84MuX/0mQA/9JkAP/SZAD/0mQA/wKv9f8Cr/X/Aq/1/wKv9f8XuIb/F7iG/xe4hv8XuIb/ODLl/zgy5f84MuX/ODLl/9JkAP/SZAD/0mQA/9JkAP8Cr/X/Aq/1/wKv9f8Cr/X/F7iG/xe4hv8XuIb/F7iG/zgy5f84MuX/ODLl/zgy5f/SZAD/0mQA/9JkAP/SZAD/Aq/1/wKv9f8Cr/X/Aq/1/xe4hv8XuIb/F7iG/xe4hv84MuX/ODLl/zgy5f84MuX/0mQA/9JkAP/SZAD/0mQA/wKv9f8Cr/X/Aq/1/wKv9f8XuIb/F7iG/xe4hv8XuIb/ODLl/zgy5f84MuX/ODLl/9JkAP/SZAD/0mQA/9JkAP8Cr/X/Aq/1/wKv9f8Cr/X/F7iG/xe4hv8XuIb/F7iG/zgy5f84MuX/ODLl/zgy5f/SZAD/0mQA/9JkAP/SZAD/Aq/1/wKv9f8Cr/X/Aq/1/xe4hv8XuIb/F7iG/xe4hv84MuX/ODLl/zgy5f84MuX/0mQA/9JkAP/SZAD/0mQA/wKv9f8Cr/X/Aq/1/wKv9f8XuIb/F7iG/xe4hv8XuIb/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAAAAAAAAAAAAAAAAAAAAAAA8wAAAAwAAAAAAAAAAAAAAAAAAAAAAAAAGAAAAPMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAK4AAABsAAAAAAAAAAAAAAAAAAAAAAAAAG8AAACuAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAkAAAA6gAAAGkAAAAMAAAADAAAAGkAAADqAAAAJAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACcAAAC3AAAA8wAAAPMAAAC3AAAAJwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAUAAAAFAAAAAAAAD4QQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA888AUPPPAFDwD///%2BB8AAA%3D%3D
Can you please tell me how I can fix this?, as I am still using the tabs and do not wont to lose them.
Many Thanks
aurimilky

https://support.mozilla.org/en-US/questions/1259465#answer-1223426

This is for lazy loading the pages, it is automatically managed by the extension. If the extension is no longer used, you have to copy yourself the url parameter from the whole URL.

moz-extension://f4730929-7b9a-4f3b-9d0c-267827747e10/tabpages/lazytab/lazytab.html?title=bluejay%20in%20Plants%2C%20Seeds%20%26%20Bulbs%20%7C%20eBay&url=https%3A//www.ebay.co.uk/sch/Plants-Seeds-Bulbs/181003/i.html%3F_from%3DR40%26_nkw%3Dbluejay&favIconUrl=data%3Aimage/x-icon%3Bbase64%2CAAABAAEAEBAAAAEAIABoBAAAFgAAACgAAAAQAAAAIAAAAAEAIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP84MuX/ODLl/zgy5f84MuX/0mQA/9JkAP/SZAD/0mQA/wKv9f8Cr/X/Aq/1/wKv9f8XuIb/F7iG/xe4hv8XuIb/ODLl/zgy5f84MuX/ODLl/9JkAP/SZAD/0mQA/9JkAP8Cr/X/Aq/1/wKv9f8Cr/X/F7iG/xe4hv8XuIb/F7iG/zgy5f84MuX/ODLl/zgy5f/SZAD/0mQA/9JkAP/SZAD/Aq/1/wKv9f8Cr/X/Aq/1/xe4hv8XuIb/F7iG/xe4hv84MuX/ODLl/zgy5f84MuX/0mQA/9JkAP/SZAD/0mQA/wKv9f8Cr/X/Aq/1/wKv9f8XuIb/F7iG/xe4hv8XuIb/ODLl/zgy5f84MuX/ODLl/9JkAP/SZAD/0mQA/9JkAP8Cr/X/Aq/1/wKv9f8Cr/X/F7iG/xe4hv8XuIb/F7iG/zgy5f84MuX/ODLl/zgy5f/SZAD/0mQA/9JkAP/SZAD/Aq/1/wKv9f8Cr/X/Aq/1/xe4hv8XuIb/F7iG/xe4hv84MuX/ODLl/zgy5f84MuX/0mQA/9JkAP/SZAD/0mQA/wKv9f8Cr/X/Aq/1/wKv9f8XuIb/F7iG/xe4hv8XuIb/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAD/AAAA/wAAAP8AAAAAAAAAAAAAAAAAAAAAAAAA8wAAAAwAAAAAAAAAAAAAAAAAAAAAAAAAGAAAAPMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAK4AAABsAAAAAAAAAAAAAAAAAAAAAAAAAG8AAACuAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAkAAAA6gAAAGkAAAAMAAAADAAAAGkAAADqAAAAJAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACcAAAC3AAAA8wAAAPMAAAC3AAAAJwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAUAAAAFAAAAAAAAD4QQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA888AUPPPAFDwD///%2BB8AAA%3D%3D


If anyone has any more idea can leave it here

Your idea what to do.

It'd be better if you structure your code. It's really messy

Thanks for the feedback!!!!
Yes i know the code is messy now. But onece all the conctributions are done. And the website starts to look clean .
I will make this repo simple and easy to understand.

Well i have structed it now.
Thanks everyone for the waiting i was just waiting so that everyone is able to see the files in one file only as it is easier to work that way.

@PankajSingh2003  It's good that you structured the code, but you completely missed the point here. We structure code so it's easy for everyone to contribute, it was so hard to understand the app where all the files are put together in one folder.

Thanks man for the feedback. Will  structure it the next time i open any webpge  for contribution.


Bookinfo Cleanup.sh should remove virtualservices, gateways and destinationrules

As suggested in #5703
/hold

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
Assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold cancel

/assign @linsun

@ymesika: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
5919a8add5e90eb226690020edb39ad166b248eb
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
@ijsnellf @GregHanson any objections?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: linsun, ymesika
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Button for pretty printing in POST body

I tend to edit my json in the POST body a lot and it's easy to destroy the formatting. It would be great if there were some button to automatically fix the formatting (aka pretty print) in the body (json, xml, ...) and response.

I pushed sth to prettify the body of a GraphQL query. Once merged (and UI validated) I can work on the JSON / XML formatting (at least on the body part).

@j0k3r I've opened the PR for the json request body formatting on #604. You can check it out.

Would this also be possible to implement on the response side?
It would make reading your responses a lot easier.

I also need the "pretty printing" for XML,
Is it ok for you if I start to work on this topic, and try to send a PR before the end of the week ?
I can try to take a look for prettier on response at the same time.

Closing this issue as this feature has already been implemented.


Added FHIR Sink Config Properties to the Pipeline Controller

Description of what I changed
Fixes https://github.com/google/fhir-data-pipes/issues/825

Added  Fhir Sink Config Properties to the Pipeline Controller to enable Synching data from a FHIR server to another FHIR server
  fhirSinkPath: ""
  sinkUserName: "hapi"
  sinkPassword: "hapi123"

E2E test
Adede e2e tests for synching from a hapi fhir sever to another using the pipeline controller  for both FULL and INCREMENTAL modes

TESTED:
Successfully fetched data form OpenMRS and a HAPI FHIR server  to another HAPI FHIR server for both batch and incremental pipeleines
Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.

[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.

[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.

[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

[x] All new and existing tests passed.

[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command git pull --rebase upstream master

@bashir2 , Requesting your review here.
Fixed the e2e tests

hello @chandrashekar-s , After pulling in your changes from  https://github.com/google/fhir-data-pipes/pull/935
Am  now getting an error when running the e2e tests
"Run E2E Test for Dockerized Controller and Spark Thriftserver": java.io.IOException: Could not read footer: java.lang.RuntimeException: file:/workspace/e2e-tests/controller-spark/dwh/controller_DWH_TIMESTAMP_2024_02_13T19_50_30_899562839Z/Encounter/ConvertResourceFn_Encounter_output-parquet-th-517-ts-1707853844285-r-760691.parquet is not a Parquet file (too small length: 4) .
All I do in this PR is do here is to sync data to both a FHIR sink and Parquet dwh at the same time.
The e2e tests  initially ran fine before pulling in your changes for fixing High memory usage

Hi @mozzy11, usually any errors that occur in the pipeline run are not printed in the logs since the docker is ran in the detached mode. You can use this code which was recently added by @bashir2 to debug the errors, I haven't tried it myself yet though.

@chandrashekar-s  increasing the rowGroupSizeForParquetFiles  to 100mb seems to have solved my error

@mozzy11 Thanks for the update. Currently, the build fails sometimes due to some issues which are mentioned in this ticket. So, the build fails sometimes and retriggering usually works.
Regarding the parameter rowGroupSizeForParquetFiles to increasing to 100mb, there is a follow up PR which needs to be merged for it to full take effect. So, this parameter should not affect the build.
Do you mind undoing the changes for this parameter and retriggering a build.

@chandrashekar-s , youre right ,
The build passes even with reverting the rowGroupSizeForParquetFiles property

@bashir2 do you have any comments for this PR ??

@bashir2 do you have any comments for this PR ??

Yeah I was just reviewing this (after the e2e-tests passed); sorry that debugging our e2e-test failures is not trivial.

Codecov Report
Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 50.15%. Comparing base (aa769f0) to head (c2d462a).

Files
Patch %
Lines

...java/com/google/fhir/analytics/DataProperties.java
42.85%
3 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #947      +/-   ##
============================================
- Coverage     50.16%   50.15%   -0.02%
  Complexity      606      606
============================================
  Files            86       86
  Lines          5073     5080       +7
  Branches        632      633       +1
============================================
+ Hits           2545     2548       +3
- Misses         2282     2285       +3
- Partials        246      247       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hello @bashir2 ,
Generally ive notoced the tests consistently fail when i run controller pipelines to sync data to a parquest DWH and a FHIR sink simultaneously , basically because  it consumes too much reaources and the CI build fails

Hello @bashir2 , Generally ive notoced the tests consistently fail when i run controller pipelines to sync data to a parquest DWH and a FHIR sink simultaneously , basically because it consumes too much reaources and the CI build fails.

Thanks @mozzy11 for working on this. What evidence do you have that the root cause of controller failures is a resource starvation issue? Asking because I took a look at some of your failed e2e runs and it was not obvious to me that is the reason (for example this one from last week). Yes, it seems that the controller fails but I am not sure if it is due to resource issues. Can you please reproduce that scenario then following the instructions in this comment to see the logs from the controller?

Ive just adedd empty params for the fhir sink so that data is not synced to fhir sink to a by default . Ill work on another PR to to enable syncing data to a FHIR sink independently wothout dependening on the Parquet DWH

I prefer if we have e2e tests that cover this feature, especially because it is a little bit different than usual scenarios we test (for analytics queries); otherwise we may break this in the future without noticing.
BTW, please also respond to the comments from the last review and resolve those that are addressed.

@bashir2 i investigated the cause of the failure and fixed it.

CC @bashir2

Thanks @mozzy11 for debugging and the changes; I'll take a look soon. In the dev. call tomorrow, do you mind discussing this and the FHIR-server to FHIR-server sync scenario in general? I just want to make sure we are on the same page regarding the shortcomings of the current approach and your plans for how to use this in production.

Thanks @bashir2 . i will discuss


[7.x] Add isNotEmpty() to the Stringable class

@taylorotwell Thanks! Will update the docs accordingly and send a PR to the docs repo.


Task/create family app models

What's this PR do?
It creates the rest of the models for the Family app. It also creates the app core, for utilities that can be used on all the pages.
Where should the reviewer start?
He should start by checking the models, for completeness regarding the design document of the models. Also the reviewer should check the different field types, in order to make sure they are appropriate for the data being stored, e.g. Check the use of TextField, instead of CharField.
After that, the reviewer should check the phone number validator.
How should this be manually tested?
N/A
Any background context you want to provide?
For validators:
https://docs.djangoproject.com/en/1.10/ref/validators/
For the core app:
Chapter 29 of Two Scoops of Django
For phone number standard E.164:
https://en.wikipedia.org/wiki/E.164
For the design of the models
https://docs.google.com/document/d/1OTpyhbl_62TJFM11iFUG2gBb1rHlMx985-CL7ns_Vhg/edit?usp=sharing
This template was adapted ~stolen~ from Quickleft/Sprint.ly

Codecov Report

Merging #17 into develop will decrease coverage by -3.66%.
The diff coverage is 98.43%.

@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
- Coverage    88.78%   85.12%   -3.66%
===========================================
  Files           39       41       +2
  Lines          312      316       +4
===========================================
- Hits           277      269       -8
- Misses          35       47      +12

Impacted Files
Coverage Δ

jp2_online/settings/base.py
95.23% <ø> (ø)
:white_check_mark:

familias/migrations/0004_alumno_tutor.py
100% <100%> (ø)

core/tests.py
100% <100%> (ø)

core/apps.py
100% <100%> (ø)

core/validators.py
100% <100%> (ø)

familias/migrations/0002_comentario_integrante.py
100% <100%> (ø)

familias/migrations/0003_merge_20170223_0525.py
100% <100%> (ø)

familias/models.py
96.87% <95.83%> (-3.13%)
:x:

base/views.py
0% <ø> (-100%)
:x:

base/urls.py
0% <ø> (-100%)
:x:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d6af6...5afda44. Read the comment docs.


Gpg key multiple addresses

This pull request solves issue #672 by:

Searching in all the addresses of a given key (not just the primary) when encrypting/decrypting a message.
Showing always all the addresses of a given key in the dialogs (message composition, message decryption and OpenPGP settings).

This does not include:

Creation of multi-address OpenPGP keys.

Moreover this request includes:

Add sender key to the encryption keys so the email can be later read by the sender itself on the "Sent" folder (I believe  this is how email clients usually do work).
Enable encrypt/decrypt buttons only if user inputs required fields (for instance, password).

Wow!


reorder and coalesce cause features to go missing

I have some input (bit too large to add here), which results in missing features when I use reorder and coalesce.
I'm attaching the mbtiles of one tile that shows the problem (10/525/336), both with and without the coalesce. These were created with:
-Z10 -z10 -D14 -d14 --reorder --coalesce --no-feature-limit --drop-densest-as-needed

(and obviously the other one without reorder and coalesce to show the difference).
Notice the water features go missing when you coalesce...
coalesce.zip

Note: I've assumed that the drop-densest-as-needed does not play a role here. Because (and correct me if I'm wrong), if anything, coalescing the features should result in a smaller tile. So if features aren't being dropped in the normal case, they shouldn't be dropped in the coalesce case either?

If it doesn't say that it's dropping features, it shouldn't drop features, so if things are vanishing without a message about it, that's a bug.
Can you be clearer about what's being lost? The #osmwat layer seems to be there in both cases, so I don't see what is being lost. Is there another water feature layer?
What version of Tippecanoe are you using? There was a bug in --coalesce, fixed in 1.27.8, that could cause some features with non-identical attributes that had passed through an input filter to be coalesced even though they shouldn't have been, although that doesn't sound like the problem here.
My main theory is that the coalesced polygons may be getting too complicated and exposing a bug either in geometry cleaning or in rendering, and I'll be happy to investigate further if you can clarify which features are the ones that are having problems.

Sorry, I think you might be right that this is a rendering issue. I've created two styles that show the difference:
https://api.mapbox.com/styles/v1/liebrand/cjogw7vcz085o2smp9bbdhm7q.html
https://api.mapbox.com/styles/v1/liebrand/cjogw6fjj2b902so9zv0gb8i6.html
Near Ijmuiden in the Netherlands, you'll notice the osmwat layer breaks up near the locks in the coalesce style, see the attached video:
ijmuiden.mp4.zip
As for the reporting of dropping features; I think have seen a number of cases where it did drop features, but it didn't mention it on the command line. I think it's when the 200k limit of features is reached maybe? eg even if the tile is within the 400k limit, it might not include all features (and not report it) if that limit is reached, could that be true?

Normally it will exit with an error if the 200K feature limit is reached without you using --drop-*-as-needed. (But features that are too small to be represented in the tile resolution will be dropped silently.)
I wonder if it would help to do another simplification pass after coalescing, at least for polygons. There may be some overly complicated geometries being left as they are (aside from the cleanup that happens during unioning) instead of having their complexity reduced.

Closing since this seems to be a rendering problem. Please reopen if necessary.


Incorrect precision for numeric values on order lines

Hi,
According to the Merchant API Documentation, the various numeric properties of the order lines should be of decimal precision, but in this SDK they are only double precision?
This causes issues with calculated values like for instance unitPrice because lets say a unit price of 0.15 with a quantity of 2 would give a price of 0.075, but with only double precision that would be rounded to 0.08 which in turn will cause issues with Klarna who expects very precise numeric values.

Hi @caroen, We are using double precision because callback parameters support only 2decimal digits. We have raised this issue to the gateway team and they are looking into it.

@caroen both the gateway amount and the order line amount allows two decimal points.
Could you provide an example of an order the fails, providing:

amount
order lines including (unitPrice, quantity, taxAmount, taxPercent)


Homematic HmIP-SRH "Sensor [...] entity description is missing."

I just took Home Assistant for a spin after home-assistant/core#57396 was merged and was greeted with the following warning:

2021-11-08 19:36:54 WARNING (SyncWorker_2) [homeassistant.components.homematic.sensor] Sensor (0007DA49A7XXXX STATE) entity description is missing. Sensor state (STATE) needs to be maintained

I know this is an issue of the Home Assistant integration and not pyhomematic, but I hope that @danielperna84 will handle it 🙂
The entity is question is the STATE parameter of my HmIP-SRH rotary handle sensor. It still works fine in Home Assistant, but there is just no STATE in the new SENSOR_DESCRIPTIONS dict. Adding the following snippet to SENSOR_DESCRIPTIONS gets rid of the warning for me, but I'm unsure if it breaks anything else:
    "STATE": SensorEntityDescription(
        key="STATE"
    ),

Since this is a bug in Home Assistant, it should also be tracked as an issue there. 👍

Alright then: home-assistant/core#59400


[SPARK-27899][SQL] Refactor getTableOption() to extract a common method

What changes were proposed in this pull request?
This is a part of #24774, to reduce the code changes made by that.
How was this patch tested?
Exist UTs.

cc @gatorsmile @wangyum

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11439/
Test PASSed.

Test build #106188 has started for PR 24803 at commit 3d4b2c3.

Test build #106188 has finished for PR 24803 at commit 3d4b2c3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106188/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11446/
Test PASSed.

Test build #106197 has started for PR 24803 at commit 3d4b2c3.

Test build #106197 has finished for PR 24803 at commit 3d4b2c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106197/
Test PASSed.

LGTM
Thanks! Merged to master.


[badges / badge v1.10.3] green badge color has changed

** poor readability of green badge color **
** changed color --- green from 600 to 400 & font color from white to gray/900 **
** Figma **
Priority (medium)

The issue is closed by using the existing badge component.


Alternative method for buffering on 2x2 chained panel

Hello @mrfaptastic
Been great use this librarry, it’s so straight forward and easy to understand.
Currently I’m able to do 2x2 using class VirtualMatrixPanel on panel fm6124 for total res 128x64.
Try simple scroll text, which I need to refresh each frame with fillscreen(0). This make flickering issues.
And I see example about framebuffer, introduce to flipDmaBuffer(), but it’s not available on VirtualMatrixPanel class.
Can you suggest what best way to get rid this flickering on my code?
Thanks

Can you post your sketch code? In any case I have made an addition to the virtualDisplay class to include the the flip/show dma buffer functions (even though these could be accessed directly from the dma_display instance).
Try again with the latest git version of the library.

this is my function within code to update display:
void disp_update_msg(String msg) {   dma_display.flipDMABuffer();   virtualDisp.fillScreen(virtualDisp.color444(0, 0, 0));   virtualDisp.setCursor(0, 20);   virtualDisp.println(msg);   dma_display.showDMABuffer(); }
but display is blank / not updating.
I'll try latest version soon, will keep updating.
Thanks

Refer to: https://github.com/mrfaptastic/ESP32-RGB64x32MatrixPanel-I2S-DMA/blob/master/examples/DoubleBufferSwap/DoubleBufferSwap.ino
Make sure you're starting with 'true' :
RGB64x32MatrixPanel_I2S_DMA     display(true);      // Note the TRUE -> Turns of secondary buffer - "double buffering"!
                                                    // Double buffering is not enabled by default with the library.

I can confirm that latest version flipDMABuffer() and showDMABuffer() with VirtualMatrixPanel is working.

Refer to: https://github.com/mrfaptastic/ESP32-RGB64x32MatrixPanel-I2S-DMA/blob/master/examples/DoubleBufferSwap/DoubleBufferSwap.ino
Make sure you're starting with 'true' :
RGB64x32MatrixPanel_I2S_DMA     display(true);      // Note the TRUE -> Turns of secondary buffer - "double buffering"!
// Double buffering is not enabled by default with the library.

Yes you're right, I completely forgot to set to true.
Now flicker is all gone, great and thanks.


Gracefully handle a deleted vote message

If someone somehow deletes the vote message before a vote is finished, handle this gracefully by ending/canceling the vote instead of erroring.

Seems to not be working at the moment.
I can delete the vote message and the bot won't end the old vote, or allow a new one to be created until after end_vote command is run.
Attached is the output log from the bot when a vote embed is deleted.
I might look in to this issue myself.
log.txt


in

What was the issue?


[dep] Upgrade theme to 0.4.2

Upgrade our theme to 0.4.2.
Important Changes:

Custom Favicon include File, but we shouldn't use this, and wait for this PR to land in the final release
External Navigation Links
Custom text as Placeholder for searchbar
Navigation Panel speedup, which should allow us to drop our custom nav.html
There's custom styling for blockquotes, which might not look nice
Some ToC changes

Might have missed some.
These might land soon, and might be helpful:

Multi Level navigation

Release notes :

https://github.com/just-the-docs/just-the-docs/releases/tag/v0.4.0
https://github.com/just-the-docs/just-the-docs/releases/tag/v0.4.1
https://github.com/just-the-docs/just-the-docs/releases/tag/v0.4.2

@captn3m0 rc4 is released 6 hours ago : https://github.com/just-the-docs/just-the-docs/releases/tag/v0.4.0.rc4

btw congratz 👍 💯 🥇 🎉

Updated the PR for RC4.0 (pushing in a bit)
Main changes:

Added a link on left to release-data using https://github.com/just-the-docs/just-the-docs/pull/876/files
[ ] Accommodate modular changes as per  https://github.com/just-the-docs/just-the-docs/pull/1058/files

Profile Measurements for RC4:
Build Process Summary:

PHASE
TIME

RESET
0.0001

READ
0.2233

GENERATE
0.0003

RENDER
11.1685

CLEANUP
0.0368

WRITE
0.1094

Site Render Stats:

Filename
Count
Bytes
Time

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_layouts/default.html
201
11277.72K
8.237

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/head.html
201
1487.11K
4.534

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/sidebar.html
201
6889.12K
3.580

_includes/nav.html
201
6779.39K
2.607

_layouts/product.html
198
1693.86K
1.555

_includes/head_custom.html
201
1192.85K
0.729

sitemap.xml
1
61.40K
0.245

assets/js/zzzz-search-data.json
1
226.56K
0.062

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/vendor/anchor_headings.html
201
1764.98K
0.057

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/header.html
201
251.45K
0.022

_redirects
1
38.40K
0.017

_includes/ltslabel.html
2125
13.09K
0.017

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_layouts/table_wrappers.html
201
11285.79K
0.015

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/icons.html
201
796.54K
0.014

_headers
1
83.35K
0.011

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/aux_nav.html
201
149.77K
0.009

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/search_header.html
201
86.96K
0.006

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/footer.html
201
0.39K
0.005

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/breadcrumbs.html
201
0.98K
0.002

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/title.html
201
3.73K
0.002

feed.xml
1
0.43K
0.002

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/search_placeholder_custom.html
201
4.32K
0.002

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/footer_custom.html
201
0.00K
0.001

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/search_footer.html
201
7.26K
0.001

_layouts/schema.html
1
1.79K
0.001

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/nav_footer_custom.html
201
0.00K
0.001

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/code_copy.html
201
262.63K
0.001

assets/js/just-the-docs.js
1
16.12K
0.001

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/css/just-the-docs.scss.liquid
3
0.60K
0.001

_includes/variables.html
1
0.00K
0.001

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/expand.html
201
71.65K
0.001

assets/css/just-the-docs-dark.scss
1
0.20K
0.001

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/header_custom.html
201
0.00K
0.001

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/document.html
201
83.62K
0.000

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/css/callouts.scss.liquid
3
0.17K
0.000

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/link.html
201
89.70K
0.000

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/menu.html
201
84.80K
0.000

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/external_link.html
201
106.00K
0.000

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/icons/search.html
201
78.12K
0.000

CONTRIBUTING.md
1
17.82K
0.000

manifest.json
1
0.54K
0.000

assets/css/just-the-docs-default.scss
1
0.20K
0.000

browserconfig.xml
1
0.27K
0.000

assets/css/just-the-docs-light.scss
1
0.20K
0.000

_layouts/page.html
3
45.79K
0.000

products/ubuntu.md
1
1.90K
0.000

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/js/custom.js
1
0.00K
0.000

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/css/custom.scss.liquid
3
0.08K
0.000

Switched to a full-image logo to avoid hack from https://github.com/endoflife-date/endoflife.date/pull/1900/files#diff-763ac3523acb81380882833d64791adae805b37ea3429ea95cb44b8f5c439593

Favicon Fixes
Dropped the ICO file, and redirect to the PNG file instead.

Dropping the nav.html slightly increases the build times:

Filename
Count
Bytes
Time

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_layouts/default.html
202
8139.78K
15.662

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/components/sidebar.html
202
3652.73K
10.658

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/nav.html
202
3469.86K
9.620

vendor/bundle/ruby/3.0.0/gems/just-the-docs-0.4.0.rc4/_includes/head.html
202
1517.41K
4.885

_layouts/product.html
199
1722.59K
1.731

_includes/head_custom.html
202
1209.83K
0.787

sitemap.xml
1
61.71K
0.336

It's a tax of 7 seconds, but we don't have to maintain our own nav.html.

The new blockquote styling looks good enough, I think:

It's not great on pages without an icon, but its okay.

0.4.0 has been released : https://github.com/just-the-docs/just-the-docs/releases/tag/v0.4.0.

@captn3m0, I rebased the branch against master, upgraded jtd to 0.4.0 and upgrade the dependencies.
I quickly checked the result after that and, appart for the 3 Sass warning when the site is build, so far it looks good.

With most of (all) the absolute links replaced by relative one in jtd, the context.deploy-preview command  in netlify.toml may be useless now (did not test).

Rebased against master and upgraded to jtd 0.4.1.
@captn3m0, I think it's good enough for being merged after an extensive review. Do you think some more work is needed ?

Will review and merge this over the weekend.

Branch rebased and theme upgraded to 0.4.2.

Rebased against master to resolve conflicts introduced by #2759.

Rebased against master and JDT updated to 0.5.0.

Theme upgraded to 0.5.1.

Just compared build time between 0.3.3 and 0.5.1 : 0.5.1 takes twice as time as 0.3.3 to render :

PHASE
0.3.3
0.5.1

RESET
0.0001
0.0001

READ
0.7307
0.7004

GENERATE
0.0006
0.0006

RENDER
23.9191
53.1622

CLEANUP
0.1969
0.1385

WRITE
0.5371
0.2675

TOTAL TIME
25.3845
54.298

Stats for templates taking more than 1s are for 0.3.3:

Filename
Count
Bytes
Time

just-the-docs-0.3.3/_layouts/default.html
226
12526.74K
10.922

_includes/nav.html
226
8598.55K
10.172

_layouts/product.html
223
2196.28K
8.499

sitemap.xml
1
69.17K
1.930

And for 0.5.1:

Filename
Count
Bytes
Time

just-the-docs-0.5.1/_layouts/default.html
226
8697.31K
41.127

just-the-docs-0.5.1/_includes/components/sidebar.html
226
4555.71K
29.609

just-the-docs-0.5.1/_includes/nav.html
226
4363.04K
26.710

just-the-docs-0.5.1/_includes/head.html
226
549.41K
11.223

_layouts/product.html
223
2196.50K
8.749

sitemap.xml
1
69.17K
1.962

I do not see that as a reason to not to upgrade, but that's a lot more time than before !

Opened https://github.com/just-the-docs/just-the-docs/discussions/1256 to see if the performance degradation could be mitigated in future JDT releases.

Just reviewed this PR, looks almost good to me.
Checked and OK:

Favicon
Search feature
Index page : https://deploy-preview-2243--endoflife-date.netlify.app/
"Documentation pages" : https://deploy-preview-2243--endoflife-date.netlify.app/recommendations, https://deploy-preview-2243--endoflife-date.netlify.app/contribute
Page with no EOL : https://deploy-preview-2243--endoflife-date.netlify.app/alibaba-dragonwell
Page with "Show more" button : https://deploy-preview-2243--endoflife-date.netlify.app/alpine
Page with sections / anchors : https://deploy-preview-2243--endoflife-date.netlify.app/rhel
Page with a generated table (table include) : https://deploy-preview-2243--endoflife-date.netlify.app/horizon
Page with release image: https://deploy-preview-2243--endoflife-date.netlify.app/blender

KO :

Logo in dark mode, which is displayed on Google Chrome as  (OK on the current site)
Link to release data in navigation (don't work)

just-the-doc upgraded to 0.5.3.

Next minor version should fix the build time issue with https://github.com/just-the-docs/just-the-docs/pull/1244. On my computer:

current jtd build time: 65s
next jtd build time: 45s
next jtd build time (without activation.scss.liquid): 20s

Test ran with the following modifications:
diff --git c/Gemfile i/Gemfile
index 406df285..e6a584c5 100644
--- c/Gemfile
+++ i/Gemfile
@@ -14,6 +14,8 @@ group :jekyll_plugins do
   gem 'jekyll-seo-tag'
   gem 'jekyll-last-modified-at'
   gem 'jemoji'
+  gem "jekyll-remote-theme"
+  gem "jekyll-include-cache"
 end

 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
diff --git c/Gemfile.lock i/Gemfile.lock
index 3ae1e94c..3cc841d0 100644
--- c/Gemfile.lock
+++ i/Gemfile.lock
@@ -46,9 +46,16 @@ GEM
       webrick (~> 1.7)
     jekyll-feed (0.17.0)
       jekyll (>= 3.7, < 5.0)
+    jekyll-include-cache (0.2.1)
+      jekyll (>= 3.7, < 5.0)
     jekyll-last-modified-at (1.3.0)
       jekyll (>= 3.7, < 5.0)
       posix-spawn (~> 0.3.9)
+    jekyll-remote-theme (0.4.3)
+      addressable (~> 2.0)
+      jekyll (>= 3.5, < 5.0)
+      jekyll-sass-converter (>= 1.0, <= 3.0.0, != 2.0.0)
+      rubyzip (>= 1.3.0, < 3.0)
     jekyll-sass-converter (3.0.0)
       sass-embedded (~> 1.54)
     jekyll-seo-tag (2.8.0)
@@ -91,6 +98,7 @@ GEM
       ffi (~> 1.0)
     rexml (3.2.5)
     rouge (4.1.2)
+    rubyzip (2.3.2)
     safe_yaml (1.0.5)
     sass-embedded (1.64.1)
       google-protobuf (~> 3.23)
@@ -110,7 +118,9 @@ DEPENDENCIES
   icalendar (~> 2.7)
   jekyll (~> 4.3.2)
   jekyll-feed (~> 0.17)
+  jekyll-include-cache
   jekyll-last-modified-at
+  jekyll-remote-theme
   jekyll-seo-tag
   jekyll-timeago
   jemoji
diff --git c/_config.yml i/_config.yml
index 5751f3be..68a28b53 100644
--- c/_config.yml
+++ i/_config.yml
@@ -14,11 +14,13 @@ plugins:
   - jekyll-timeago
   - jekyll-seo-tag
   - jekyll-last-modified-at
+  - jekyll-remote-theme
+  - jekyll-include-cache
   - jemoji

 # just-the-docs settings, see https://just-the-docs.com/
-theme: just-the-docs
+remote_theme: pdmosses/just-the-docs@nav-fix
 nav_sort: case_insensitive

 # https://just-the-docs.com/docs/configuration/#search
diff --git c/_includes/css/activation.scss.liquid i/_includes/css/activation.scss.liquid
new file mode 100644
index 00000000..e69de29b


not working on ubuntu16

WARN Failed to read files, Because of read /proc/sys/fs/binfmt_misc/register: invalid argument
WARN Failed to read files, Because of open /proc/sys/net/ipv4/route/flush: permission denied
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/all/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/default/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/docker0/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/docker1/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/docker_gwbridge/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/enp3s0f0/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/enp4s0/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/enp5s0/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/lo/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/vboxnet0/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth049626c/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth1657467/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth2009782/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth2a9426f/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth302d118/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth349ef38/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth4551040/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth69cd651/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth722b7ba/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth7ae1067/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth9b1b9ec/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/veth9fa3c82/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/vetha2831fe/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/vethae75a1c/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/vethb1940b3/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/vethc62ef08/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/vethc7a420e/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/vethcdd2acf/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/virbr0/stable_secret: input/output error
WARN Failed to read files, Because of read /proc/sys/net/ipv6/conf/virbr0-nic/stable_secret: input/output error
WARN Failed to read files, Because of open /proc/sys/net/ipv6/route/flush: permission denied
WARN Failed to read files, Because of open /proc/sys/vm/compact_memory: permission denied
panic: sync: negative WaitGroup counter
goroutine 49 [running]:
sync.(*WaitGroup).Add(0xc4201020c0, 0xffffffffffffffff)
/usr/local/go/src/sync/waitgroup.go:75 +0x134
sync.(*WaitGroup).Done(0xc4201020c0)
/usr/local/go/src/sync/waitgroup.go:100 +0x34
github.com/ringtail/snout/collectors/cpu.GatherProcessSystemCallWithinTime.func1(0xc4201020c0, 0x5183, 0xc4201020a9, 0xc42016c0c0)
/Users/ringtail/go/src/github.com/ringtail/snout/collectors/cpu/system_call.go:120 +0x24b
created by github.com/ringtail/snout/collectors/cpu.GatherProcessSystemCallWithinTime
/Users/ringtail/go/src/github.com/ringtail/snout/collectors/cpu/system_call.go:97 +0xe1

try with sudo again.

already did.
sudo snout --debug

ok, I‘ll check it on ubuntu 16.04


Exits slowly register themselves

Exits go into state "Registered" over the course of a few minutes, without clicking "connect" on any of them. They had been registered to before from the same gateway. This is not neccesarily bad, but unexpected. close this issue if this is ok.

They should register to any previous exits that they have been connected to, although it is curious why it takes minutes, it should only take a couple seconds, I'll leave this open for investigation

if it's this slow it's either a sync issue or a bug.

it seems fast to me. I think this is part of the multi gateway bug, which should be resolved now or soon. Closing.


[GSoC] Problem of being forced to use relative imports

The structure of the implementations folder (has code_df and notebooks_df) makes it necessary to use relative imports for the notebooks to work. The discussion can be found here.
The main purpose of this issue is to function as a reminder to fix this issue later on.

I am closing this since it has been resolved.


FIX Regenerate session ID on registration to prevent session fixation

This also simplifies some of the logic in the initial method of our LoginHandler. It makes sense to put all the delegation logic in one place.

Unfortunately there's no good way to test this. SilverStripe doesn't provide API for this so I can't really mock it - and sessions don't really start on the CLI between requests in a functional test - you can't actually track changes in session ID. I could probably extract regnerate_session_id into a method and then do some seriously hacky test where I mock the class I'm trying to test - I can do that if you think it's worth it.


Use install:addon syntax in installation instructions

The command ember install:addon combines the npm installation
and generation steps, simplifying installation of the addon
to a single command.

@tzellman Is there a reason you don't want to merge this in?  Do you want me to change something?


Wrong A3C implementation

I believe there is a bug in the A3C algorithm implementation. In the file "ProcessAgent.py" on line 107. The sub-episode return should be the value in the next state not the previous.
I suggest replacing:
prediction, value = self.predict(self.env.current_state)

...
            if done or time_count == Config.TIME_MAX:
                terminal_reward = 0 if done else value

with:
prediction, value = self.predict(self.env.current_state)

...
            if done or time_count == Config.TIME_MAX:
                terminal_reward = 0
               if not done:
                     (_, terminal_reward) = self.predict(self.env.current_state)

I think that the overall design is of a different approach:
            prediction, value = self.predict(self.env.current_state)
            action = self.select_action(prediction)
            reward, done = self.env.step(action)
            reward_sum += reward
            exp = Experience(self.env.previous_state, action, prediction, reward, done)

The last line indicates that experience is backward looking. I assume that's why the terminal_reward that is equal to value is consistent when done is False?


Add support for e2e testing suite

See https://github.com/adyen-examples/adyen-testing-suite

Implemented in PR #24


Update release.yaml - update GH actions versions

Fixing deprecation warning:
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Example of where this warning was seen: https://github.com/score-spec/score-compose/actions/runs/10871545281.

Ready for your review, thanks!


air: action to rebuild and update voedger

Motivation
I'm always frustrated when I'm not able to run Air with new Voedger. Voedger updated -> need to create a separate task + pull request + manage branches to make so the Air run with new Voedger
Functional design
Github action Update Voedger and rebuild

update Voedger to the latest one in go.mod
CD

@host6 What about bp3 action: Update voedger?

@host6 What about bp3 action: Update voedger? You can use this action

It only updates go.mod, airs-bp3 app is not rebuilt in this case. I can not see changes in dev cluster after that action.

Done: Now Update voedger builds and publishes new airs-bp3


[5.4] Storing the name of the migration table in a variable [#20368]

Issue [#20368]

No plans to add this.

@taylorotwell  Why? It's awkward to manually enter the table name in two places.

@andrey-helldar - the use of down() is not really required anymore with the introduction of migrate:fresh in 5.5
So many people will probably stop even writing down() at all....


Fixed InsecureTinyliciousUrlResolver to include relative path and added tests

This resolver doesn't need to be changed to include full path since loader will never be given out to call request. Added a comment for this situation.
Removed a stale comment in getSessionStorageContainer.ts

Closing and reopening to trigger build


[Perf] High Allocator DoWriteIfNeeded

Drill down on Issue #288
Measurements post PR #287
Item 5 on highest allocators in plaintext test

Allocations (2003 requests)

Writes alloc on List.Add not GCHandle.Alloc for clarity
Bytes (2003 requests)

Writes alloc on List.Add not GCHandle.Alloc for clarity

Have PR for this coming

Hopefully resolved by https://github.com/aspnet/KestrelHttpServer/pull/309 will report back

Resolved by  #363 Resuse writes, initalize queues


ERR_UNKNOWN_BUILTIN_MODULE

I got this error??

Hey @cpgarcia518,
can you provide which node version you are using?

Version 10.3.1
From: Timur Olzhabayev @.>
Sent: Tuesday, June 4, 2024 11:05 AM
To: grafana/plugin-tools @.>
Cc: Carlos Alejandro Perez Garcia @.>; Mention @.>
Subject: Re: [grafana/plugin-tools] ERR_UNKNOWN_BUILTIN_MODULE (Issue #938)
Hey @cpgarcia518 https://github.com/cpgarcia518 ,
can you provide which node version you are using?
—
Reply to this email directly, view it on GitHub https://github.com/grafana/plugin-tools/issues/938#issuecomment-2146997426 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AMFBGB3DXPWYRWEE7X2KDPLZFV7NPAVCNFSM6AAAAABIS5EK3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWHE4TONBSGY .
You are receiving this because you were mentioned.Message ID: @.***>

Closing as the fix would be to move to node 20. Please reopen / comment if that does not solve the problem.


Services:set  alert_grouping_parameters

Unable to enable Intelligent Alert Grouping using pd services:set
 % pd service:set -i=PXPW401 -k=alert_grouping_parameters -v="{ type: 'intelligent', config: {} }"
 ›   Warning: pagerduty-cli update available from 0.1.0 to 0.1.3.

500 Internal Server Error
Setting alert_grouping_parameters = '{ type: 'intelligent', config: {} }' on 1 services 0/1 👍, 1/1 👎... done
Failed to set service PXPW401: 500 Internal Server Error

Would also like to be able to set auto_pause_notifications_parameters from pd service:set
    "auto_pause_notifications_parameters": {
      "enabled": true,
      "timeout": 300
    }

Hello,
Same issue here
$> pd version
pagerduty-cli/0.1.4 darwin-arm64 node-v16.15.0

AFAIU it seems to be due to the data submitted towards the API. I can't find the right CLI syntax to have a JSON object, it's a string.
  data: {
    service: {
      id: 'Pxxxxxx',
      type: 'service_reference',
      'alert_grouping_parameters.type': 'intelligent'
    }

A workaround is to use the deprecated alert_grouping parameter.
$> echo "Enable alert grouping" ; pd service:set -i Pxxxx -k alert_grouping -v "intelligent"
$> echo "Disable alert grouping" ; pd service:set -i Pxxxx -k alert_grouping -v ""

Regards

Sorry everyone, yes, as you have noticed, key paths and/or direct JSON is not supported by the *:set commands... the best current workaround is to use rest put instead, like this:
pd rest put -e services/MY_SERVICE_ID -d '{"service": {"auto_pause_notifications_parameters": {"enabled": true, "timeout": 300}}}'

I will start thinking on how to make the *:set commands better for this sort of thing... I am thinking about two possible approaches --

make the set commands accept key paths and/or JSON
implement dedicated commands for things like alert grouping and auto pause notifications etc.

Ideally I would do both

Extending the :set command to accept json would be nice.
I was able to use use pd CLI to enable auto_pause - Thank You!

Hi, I added the ability to give JSON as the value; you can also give JSON dot path notation as the key; also you can give -k and -v multiple times (in order) to set multiple key/values at once. Example screenshot:

This is in v0.1.5, now released as an RC, pd update rc to try it, pd update stable if you want to switch back to 0.1.4... can you give it a try and let me know if it's resolved for you? Thanks

Works fine for me.
Tested:

set intelligent grouping
set time-based grouping
unset grouping
few bad syntaxes (eg: 2 keys but only 1 value, ...)

$> pd version
pagerduty-cli/0.1.5 darwin-arm64 node-v16.15.0

Thank you @sdenef-adeo! I will be looking to close this issue and promote this build to stable soon.

Hi, I just promoted this build to stable so closing this issue...


chore(main): release 1.5.3

:robot: I have created a release beep boop
1.5.3 (2023-12-04)
Miscellaneous Chores

deps: bump actions/checkout from 3 to 4 (32e726e)
deps: bump dependabot/fetch-metadata from 1.5.1 to 1.6.0 (02860f2)
deps: bump google-github-actions/release-please-action (b379d52)
deps: bump stefanzweifel/git-auto-commit-action from 4 to 5 (b1d4b99)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/deloz/wechat-bridge/releases/tag/v1.5.3 :sunflower:


License

Hello - I was wondering if you would be willing to add an open source license such as MIT / Apache 2.0 / BSD?

Done :)


switch combinations

I hope you don't mind me raising issues like this as I don't have the time or really the skills to do direct modifications and pull requests.
Your script has a problem when trying to use the -s (source) switch as you also need to define the -n (code-name) switch as the script still tries to run function latest_release which will fail on the first curl as it can not retrieve a valid file without a code name being provided.

Looks like I'm able to get the desired behavior by making changes to the way I detect if an images is legacy(isolinux) vs el torito. Instead of doing a greater/less comparison on the release number, i'll just check fore the presence of isolinux in the extracted iso itself, and if its there, it's marked as legacy. This seems to let everything build properly.


How to scroll to a target element but only if the direction is down?

How can you scroll to a target element but only do this if the scroll direction is downwards?

You should ask these questions on sites like StackOverflow, there are many more people available there. Github issues are only for bug/feature/enhancement requests.
Regards

But it's a question about using your library? I'm asking whether this is possible with your library. Or if you have any insight into how this can be achieved? If the answer is 'no' then this ticket could lead onto an enhancement request.
Asking the author of the plugin I have a question about seems far more logical than asking a community of people who may or may not have experience of using your plugin.

So far I have achieved this with the following but I wasn't sure whether I'd missed an option in your plugin which I why I opened this ticket:
if($('.target').offset().top > $(window).scrollTop()){
    // Action
}


Constant rewriting of the CRD

Hello!
Using Flux, I deployed the external-secrets operator and its CRD.
The fact is that the external-secrets operator stores the caBundle directly in the CRD and therefore Flux constantly overwrites it.
Question: is it possible to add some manifest fields to those ignored by Kustomization?
 {"level":"info","ts":"2024-04-16T11:13:17.992Z","msg":"server-side apply for cluster definitions completed","controller":"kustomization","controllerGroup":"kustomize.toolkit.fluxcd.io","controllerKind":"Kustomization","Kustomization":{"name":"crds-stack","namespace":"flux-system"},"namespace":"flux-system","name":"crds-stack","reconcileID":"c2167182-e883-4189-814e-7d895b0da69f","output":{"CustomResourceDefinition/clustersecretstores.external-secrets.io":"configured","CustomResourceDefinition/externalsecrets.external-secrets.io":"configured","CustomResourceDefinition/secretstores.external-secrets.io":"configured"}}

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - https://raw.githubusercontent.com/external-secrets/external-secrets/v0.9.14/deploy/crds/bundle.yaml

 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.14.0
   creationTimestamp: "2024-04-10T09:58:54Z"
   generation: 190
   labels:
     kustomize.toolkit.fluxcd.io/name: crds-stack
     kustomize.toolkit.fluxcd.io/namespace: flux-system
   name: clustersecretstores.external-secrets.io
   resourceVersion: "1265682"
   uid: 89ad4f41-1a9c-4bd8-951a-b38ae52dbca5
 spec:
   conversion:
     strategy: Webhook
     webhook:
       clientConfig:
         caBundle: long caBundle
         service:
           name: external-secrets-webhook
           namespace: external-secrets
           path: /convert
           port: 443
       conversionReviewVersions:
       - v1
   group: external-secrets.io
   names:
     categories:
     - externalsecrets
     kind: ClusterSecretStore
     listKind: ClusterSecretStoreList
     plural: clustersecretstores
     shortNames:
     - css
     singular: clustersecretstore
   scope: Cluster

There is no way to ignore fields, you can only tell Flux to apply these objects as one-off:
apiVersion: kustomize.toolkit.fluxcd.io/v1
kind: Kustomization
spec:
  patches:
  - patch: |
      - op: add
        path: /metadata/annotations/kustomize.toolkit.fluxcd.io~1ssa
        value: IfNotPresent
    target:
      kind: CustomResourceDefinition
      name: (clustersecretstores.external-secrets.io|secretstores.external-secrets.io)

@stefanprodan
Thanks for the answer!
How then will the update process occur when changing the version? Will it even work?

There is no update unless you remove the annotation from Git and cluster. I suggest using a HelmRelease for the external-secrets operator, as helm-controller doesn't correct drift by default and bundles will stay put.

We do haven an issue for implementing fields ignore here https://github.com/fluxcd/pkg/issues/696. It may take months/years before I get to this unless someone steps in to work on it.


allow struct tag, add test

allows the usage of gtrs:"x" struct tag

maybe https://github.com/muir/reflectutils/blob/main/unpack.go#L59 is worth exploring.

I was looking for something like this when writing auto conversions. I don't think there is a strong need now 🤷🏻♂ (Especially now that you added tags which seems are not supported there?)

tags are supported in that package
that said, it's up to you. go source code reimplements what you have many
times, so maybe it is okay. (referencing encoding/json and sql.Scan)
On Tue, Nov 28, 2023, 4:45 AM Vladislav @.***> wrote:

maybe https://github.com/muir/reflectutils/blob/main/unpack.go#L59 is
worth exploring.
I was looking for something like this when writing auto conversions. I
don't think there is a strong need now 🤷🏻♂ (Especially now that you
added tags which seems are not supported there?)
—
Reply to this email directly, view it on GitHub
https://github.com/dranikpg/gtrs/pull/13#issuecomment-1829561952, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARH66OVC3SD4NWTXC5HLJ3YGW6GJAVCNFSM6AAAAAA75QBDFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGU3DCOJVGI
.
You are receiving this because you authored the thread.Message ID:
@.***>