[NEW ALGORITHM] -N-Queens Problem with Symmetry Breaking

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[NEW ALGORITHM]
N-Queens Problem with Symmetry Breaking
About:
Propose a new algorithm to be added to the repository
The goal is to place N queens on an N x N chessboard such that no two queens threaten each other. The symmetry breaking technique involves placing the first queen in the first half of the board only, effectively reducing the number of solutions we need to explore
Labels:
new algorithm, gssoc-ext, hacktoberfest, level2

Assignees:

[ ] Contributor in GSSoC-ext
[ ] Want to work on it

Do not create multiple issues.


isosurface not working

Reference: https://uk.mathworks.com/help/matlab/ref/isosurface.html
[x,y,z,v] = flow;
p = patch(isosurface(x,y,z,v,-3));
isonormals(x,y,z,v,p)
p.FaceColor = 'red';
p.EdgeColor = 'none';
daspect([1 1 1])
view(3);
axis tight
camlight
lighting gouraud

[x,y,z,v] = flow;
[faces,verts,colors] = isosurface(x,y,z,v,-3,x);
patch('Vertices',verts,'Faces',faces,'FaceVertexCData',colors,...
    'FaceColor','interp','EdgeColor','interp')
view(30,-15)
axis vis3d
colormap copper

Once it is fixed, please rely with chart studio plots so I can include the in the online documentation.

This issue was fixed by PR #413


[3.x] Create CollisionObject debug shapes using VS

Backport of #48175.

@akien-mga Don't merge it immediately as I'm still testing.

@akien-mga Now it is ready (sorry to make you wait).

Thanks!


Establish confidence in our testing to maintain quality through the proposed refactors (v1->v2, ADS, ???).

[ ] A report exists on our testing plan for ambassador.
[ ] The report includes:

what categories of tests exist
what features are covered (positive)
what features are covered (negative)
what implementation aspects are exposed to the tests
a plan for v1 -> v2 transition
a plan for the file to ADS transition

[ ] Concensus amongst stakeholders post review & discussion of the report.

Some relevant testing ctx was discovered in: https://github.com/datawire/ambassador/issues/429

Note that the Envoy guys have added something that might help here:
bazel run //tools:v1_to_bootstrap <path to v1 JSON/YAML configuration file>
(see also https://github.com/envoyproxy/envoy/pull/3698)


Trying to throw window to different desktop doesn't work

I have a shortcut to work with yabai to "throw" a window to a different virtual desktop, its shift + alt + # where the # is the number of the desktop i want to throw it to. however, this just makes it not part of the windows tiled and it stays on the same desktop, then when I go back to the desktop it was on it becomes part of the tiled windows again.

I am on the new macOS Sequoia beta as well, i don't remember if it didnt work before then or not

Stopped working here too.

Same


feat: support cbf methods

Description
This PR is already complete in terms of implementation accuracy. We will merge it shortly after improving the code style and documentation.
Related Papers
This Pull Request supports control barrier function-based SafeRL algorithms, including:

End-to-End Safe Reinforcement Learning through Barrier Functions for Safety-Critical Continuous Control Tasks
Safe Reinforcement Learning Using Robust Control Barrier Functions
Sampling-based Safe Reinforcement Learning for Nonlinear Dynamical Systems

Example Demo
https://github.com/PKU-Alignment/omnisafe/assets/108712610/31d48d98-c9d6-4dd0-bf9d-936a6ac45871
Experiment and Performance
Note: Since OmniSafe uses Steps as the x-axis scale when displaying benchmark curves, the x-axis scale of the curves is not entirely consistent with the original implementation. However, the total number of interactive steps is the same. For example, in Pendulum-v1, 400 episodes * 200 steps per episode = 80,000 total steps.

Pendulum-v1 Benchmark

Original Implementations

OmniSafe Implementations

Note The IPO algorithm, based on the Logarithmic Barrier Function, conceptually aligns with the CBF method.
Therefore, it is classified as a variant of the CBF approach.

Unicycle Task

Due to the highly coupled nature of the CBF method with the environment, we are currently only validating the performance of the RCBF method in the Unicycle environment, which is the same as in the original paper. Future work will focus on how to achieve environmental decoupling.

Original Implementations

OmniSafe Implementations

Note: Original implementation is zero cost, so it does not include the cost performance curves.
Motivation and Context
The CBF method is an important branch of SafeRL research. Supporting the CBF method will further expand OmniSafe's contribution to the community.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[x] My change requires a change to the documentation.
[x] I have updated the tests accordingly. (required for a bug fix or a new feature)
[x] I have updated the documentation accordingly.
[x] I have reformatted the code using make format. (required)
[x] I have checked the code using make lint. (required)
[ ] I have ensured make test pass. (required)

@Gaiejj Can you please provide instructions on how to reproduce this result? I have been trying to use Omnisafe to produce the result, but I have been experiencing issues.

@umfundii Hello, here is the complete reproduction process:

Create a new conda environment.

conda create -n cbf python==3.8

Install OmniSafe (this is because the CBF-based method requires new Python dependencies).

pip install -e .

Execute the following commands.

python train_policy.py --algo SACRCBF --env-id Unicycle
python train_policy.py --algo DDPGCBF --env-id Pendulum-v1
python train_policy.py --algo TRPOCBF --env-id Pendulum-v1

My Python environment configuration is as follows.

@Gaiejj I have few additional questions.

How to reproduce the graph above if I use an agent. plot() the graphs don't seem to look like the one provided above
Also in the config files(  train_cfgs) why use device CPU instead of GPU? Is there any significance because selecting GPU throws an error being separate devices?

@umfundii Thank you very much for pointing that out! It greatly helps us improve the robustness and usability of the code in this PR.

We have added the functionality to specify reward metrics and cost metrics in plot.py. By running:

python plot.py --logdir LOGDIR --cost-metrics Metrics/Max_angle_violation --reward-metrics Metrics/EpRet

you can reproduce the corresponding results using plot.py.
To further facilitate user convenience, we have also made adjustments to the relevant sections of experiment_grid. Currently, users can reproduce the setup with one click through the Python script in examples/benchmarks/run_experiment_grid.py as shown below:
if __name__ == '__main__':
    eg = ExperimentGrid(exp_name='Benchmark_CBF_Test')

    cbf_policy = ['TRPOCBF', 'DDPGCBF', 'IPO', 'PPOBetaCBF']
    cbf_env = ['Pendulum-v1']
    eg.add('env_id', cbf_env)

    avaliable_gpus = list(range(torch.cuda.device_count()))
    gpu_id = None

    eg.add('algo', cbf_policy)
    eg.add('logger_cfgs:use_wandb', [False])
    eg.add('train_cfgs:vector_env_nums', [1])
    eg.add('train_cfgs:torch_threads', [1])
    eg.add('train_cfgs:total_steps', [80_000])
    eg.add('seed', [0, 5, 10])
    eg.run(train, num_pool=12, gpu_id=gpu_id)
    reward_metrics = 'Metrics/EpRet'
    cost_metrics = 'Metrics/Max_angle_violation'
    eg.analyze(
        parameter='algo',
        values=None,
        compare_num=4,
        cost_limit=1.0,
        reward_metrics=reward_metrics,
        cost_metrics=cost_metrics,
    )

We fixed the cuda support for TRPOCBF and PPOBetaCBF in commit 7423bc1.
We fixed the compensator saving issue in commit 3934192, thanks for your meticulous reminder!
Note: Due to the high dependency of CBF method components, such as compensator and solver, on the dynamics of the training environment, the performance of the CBF method has declined in the evaluation environment.

@Gaiejj
Thanks for the fix and additional questions.

Can you please post plots like the one above with the fix? Because Now DDPG-CBF performance is not that good.
Also, if I want to extend this method to all environments within Omnisafe/ safety-gymnasium, can you please provide guidance on how I can accomplish that?

@umfundii Thank you again for your detailed observations and feedback!

Based on the latest code, we conducted extensive repeated experiments on 5 random seeds and found that the results of DDPGCBF indeed have slight differences compared to the initially published performance in the PR. This difference may be due to randomness caused by equipment differences. We present the latest results as follows:

We believe this is a very forward-looking suggestion because it can better help OmniSafe assist researchers in the study of CBF methods. We are in the process of code refactoring and documentation writing, so that researchers can extend CBF methods to more environments. We will synchronize the updates to this PR within 3-4 days, and we welcome your guidance then.

Thanks again for your help and suggestions!

@umfundii Hello! We have refactored the CBF code. Specifically, we decoupled the solver and dynamics_model to facilitate user customization for specific environments. We have also completed the documentation for this interface. We have built a pre-release version on the branch corresponding to this PR: https://omnisafe-zjy.readthedocs.io/en/latest/saferl/cbf.html


[docs] Create newsletter_september2023.md

NewsLetter Census API September 2023 - covering:
top two points on this issue:
https://github.com/chanzuckerberg/cellxgene-census/pull/716
and the top two points on this issue:
https://github.com/chanzuckerberg/cellxgene-census/pull/612
[EDIT BY @pablo-gar] addresses: #726

@MaximilianLombardo and @pablo-gar - is this ready to go?


use console.trace to improve error handler

Fixes: https://github.com/honojs/hono/issues/554

Thank you! I'll merge it!


SAMZA-2251: Minor diagnostics manager change to emit additional job details

@prateekm can you please take a look, thanks

@cameronlee314 Addressed all comments, defined a pojo for the stream contract, which simpified the change a fair bit. Please take a look.

All done.


can I run async-profiler under root user to profile the java process under another user?

just as the title said, I want to profile a java process under other user. But I fail, even I run async-profiler under root user.  jattach print the error: "Could not start attach mechanism: No such file or directory". And jvm process print some call stack at the same time.
Any solution for this?

I've just commited the fix b39ab0d2aa56fdec403a68d1dcb76ddd933d3ac7 in sudo branch.
It should allow to profile any Java process when run under root.
Please check if it helps.

Thank you for verifying. I've merged the fix into master.


Packange and publish to NPM

Could you please package this and publish it to NPM?

did you see sass.js?

Interesting, it didn't show up when I was searching for it. A link in the
readme would be nice :)
On Apr 12, 2017 3:36 AM, "Rodney Rehm"<EMAIL_ADDRESS>wrote:

did you see sass.js https://www.npmjs.com/package/sass.js?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/medialize/sass.js/issues/78#issuecomment-293498398,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEoccHIszH0PpY_jOtWBi7pXKnOUQo2kks5rvH8ZgaJpZM4M64o5
.


Smart contract params deser

Purpose
De-serializes Smart Contract Update Events Parameters If the Schema is Embedded in the Module.
Changes
De-serializes Smart Contract Update Events Parameters If the Schema is Embedded in the Module.
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

CLA acceptance
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf

[x] I accept the above linked CLA.

@parv0888 : as discussed in the meeting
show hex in case the value cannot be deserialized to a json


Add gitHead to package.json

This is a field normally added automatically by npm publish. It is extremely useful to map packages back to a revision in the git repository (especially when releases are not tagged). Sourcegraph uses it to provide cross-repository go-to-definition.
Closes #458

@sandersn before I solve the merge conflict, could you maybe take a look at this PR?


azcopy login fails silently

Which version of the AzCopy was used?
10.15.0
Which platform are you using? (ex: Windows, Mac, Linux)
WSL on Windows 11
What command did you run?
> azcopy login
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code <redacted> to authenticate.
INFO: Logging in under the "Common" tenant. This will log the account in under its home tenant.
INFO: If you plan to use AzCopy with a B2B account (where the account's home tenant is separate from the tenant of the target storage account), please sign in under the target tenant with --tenant-id
INFO: Login succeeded.
> azcopy login status
INFO: You are currently not logged in. Please login using 'azcopy login'

What problem was encountered?
Login appears to work successfully, but any subsequent azcopy operation fails, saying that I'm not authenticated.
How can we reproduce the problem in the simplest way?
Have you found a mitigation/solution?
#452 lists a workaround:
sudo apt install keyutils
keyctl new_session
azcopy login
keyctl show

@zezha-msft , happy to provide more details if needed

Encountered the same issue. Only comes up on WSL.
@ant0nsc thanks for your workaround, this worked for me too.

same as #1734

Encountering same issue but workaround worked.
System information:
Windows 10 Enterprise
Version	10.0.19045 Build 19045
WSL2 - <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
AZCOPY Version 10.19.0


Fix: yarn dependencies

It partially closes issue #980 (but still actual)
npm install still is not working properly, referencing to the old electron v7 that already not exists in the npm registry
need to resolve and bump all dependencies to the relevant versions and fix configs webpack/babel to the newest version.
I think to do it incrementally from our dependency bot , because of unpredictable estimations for this task
for yarn , working well without warnings related to deps, only one left because of internal deps

I've updated PR description to avoid closing the issue, since it is still actual


chown: changing ownership of '/build': Permission denied

build can not start with error:
chown: changing ownership of '/build': Permission denied
Repro steps:
git clone -b v1.21.0 --depth 1 https://github.com/envoyproxy/envoy envoy-src

cd envoy-src

export ENVOY_DOCKER_BUILD_DIR=~/tmp/envoy-docker-build/

# genedated file: ~/tmp/envoy-docker-build/
./ci/run_envoy_docker.sh 'BAZEL_BUILD_EXTRA_OPTIONS="--define exported_symbols=enabled" TEST_TMPDIR=/tmp ./ci/do_ci.sh bazel.sizeopt.server_only'

cc @phlax @lizan

i think the problem is the TEST_TMPDIR flag


header.matchHeader matches raw, valid values of same name

This hurt #1887, which is breaking master and several other PRs that branched off the broken master. :fire:
[error] x header.matchHeader matches raw, valid values of same name (15 seconds, 1 ms)
[error]  Falsified after 70 passed tests.
[error]  > Falsified after 30 passed tests.
[error]  > ARG_0: Accept: 5z/*; eo="²;:¾B"; +cg=""; rW="¢"; 8|m="ÂÑU1", zb_l/*;q=0.301; +n_="d"; NnZ="msfnË"; K+="", TEXt/*, &/*;q=0.287; r="Y|Õeµ6"; Rae="Ò^}z", tMq|M/*;q=0.429; 8Y8=""; #9ZV="üçj"; Cg=""; p="Ëé¶Z"; f`Bw="", Ds&4U`/*;q=0
[error]  > Some(Accept: 5z/*; eo="²;:¾B"; +cg=""; rW="¢"; 8|m="ÂÑU1", zb_l/*;q=0.301; +n_="d"; NnZ="msfnË"; K+="", text/*, &/*;q=0.287; r="Y|Õeµ6"; Rae="Ò^}z", tMq|M/*;q=0.429; 8Y8=""; #9ZV="üçj"; Cg=""; p="Ëé¶Z"; f`Bw="", Ds&4U`/*;q=0) is Some but Accept: 5z/*; eo="²;:¾B"; +cg=""; rW="¢"; 8|m="ÂÑU1", zb_l/*;q=0.301; +n_="d"; NnZ="msfnË"; K+="", text/*, &/*;q=0.287; r="Y|Õeµ6"; Rae="Ò^}z", tMq|M/*;q=0.429; 8Y8=""; #9ZV="üçj"; Cg=""; p="Ëé¶Z"; f`Bw="", Ds&4U`/*;q=0 != Accept: 5z/*; eo="²;:¾B"; +cg=""; rW="¢"; 8|m="ÂÑU1", zb_l/*;q=0.301; +n_="d"; NnZ="msfnË"; K+="", TEXt/*, &/*;q=0.287; r="Y|Õeµ6"; Rae="Ò^}z", tMq|M/*;q=0.429; 8Y8=""; #9ZV="üçj"; Cg=""; p="Ëé¶Z"; f`Bw="", Ds&4U`/*;q=0 (HeaderLaws.scala:21)

I took a look into this. This pretty snippet generates the arg that fails the test:
val accept = Accept(NonEmptyList(
  MediaRange
    .parse("5z/*")
    .map(
      _.withExtensions(
        Map("eo" -> "²;:¾B", "+cg" -> "", "rW" -> "¢", "8|m" -> "ÂÑU1"))
        .withQValue(QValue.One)),
  List(
    for {
      mr <- MediaRange.parse("zb_l/*")
      q <- QValue.fromThousandths(301)
    } yield
      mr.withExtensions(Map("+n_" -> "d", "NnZ" -> "msfnË", "K+" -> ""))
        .withQValue(q),
    MediaRange.parse("TEXt/*").map(_.withQValue(QValue.One)),
    for {
      mr <- MediaRange.parse("&/*")
      q <- QValue.fromThousandths(287)
    } yield
      mr.withExtensions(Map("r" -> "Y|Õeµ6", "Rae" -> "Ò^}�z"))
        .withQValue(q),
    for {
      mr <- MediaRange.parse("tMq|M/*")
      q <- QValue.fromThousandths(429)
    } yield
      mr.withExtensions(
          Map("8Y8" -> "",
              "#9ZV" -> "üçj",
              "Cg" -> "",
              "p" -> "Ëé¶Z",
              "f`Bw" -> ""))
        .withQValue(q),
    MediaRange.parse("Ds&4U`/*").map(_.withQValue(QValue.Zero)),
  )
).sequence.right.get)

After doing all that I noticed that the diff in the two values is just text/* != TEXt/*. With my snippet, where I parse the MediaRange, TEXt/* is rendered as text/*. In http4sGenMediaRange, the MediaRange is created using the package private constructor, which just takes the main type verbatim, and thus allows differently cased strings.
object test extends App {
  val mr = "TEXt"
  println(new MediaRange(mr))
  println(MediaRange.parse(s"$mr/*"))
}
// MediaRange(TEXt/*)
// MediaRange(text/*)

Is the Gen wrong? I tried looking at the RFC, but couldn't see any references to casing.
Digging some more, this is where the parsed value is downcased.
I'm not sure what the right resolution is here :)

RFC 2045 says:

All media type values, subtype values, and parameter names as defined are case-insensitive.

To be consistent with the rest of our model, we should be using CaseInsenstiveString for mainType and subtype.  But that's a breaking change.  (It's also kind of unpleasant to use, and we should have a talk about that before 1.0).
Should we change the .equals and .hashCode methods in 0.18?  Or downcase from the generator?

I thought that would be the case, but couldn't find the right RFC.
Downcase in generator imo, it's only generating wrong stuff because it's using a private constructor.


Investigate possibility to externalize holo-cli into its own repository

Investigate possibility to externalize holo-cli into its own repository
Pros:
1- Enforce holo modularization. holo-cli is a GRPC client that can be isolated.
2- Decouple holo-cli to all other software. Net-devs can focus on routing modules while app-devs can focus on cli development.
3- holo node can have holo-cli NOT installed. This reduces code size & surface (good for embedded devices)
4- A sort of holo-cli-ctl installed only on an out of band admin network can be implemented in order to connect multiple holo nodes from a sigle host. (no need to installed software like OpenSSHD on the holo nodes)
Cons:
1- Need to use common holo protobuf and yang definition (can be alleviated with git- submodules)
2- Is having a holo-proto repository worth to add in order to have a better tracking of new features addition/deletion in a central place?
3- holo container needs adjustment in order to include holo software suite and holo-cli

Closed by #17


FDG-5243 DO NOT MERGE handle nested parenthesis at endpoint

NOTE: this PR is on hold until we can confirm that the data table endpoints handle parenthesis according to expectations.
https://federal-spending-transparency.atlassian.net/browse/FDG-5243
unit test line coverage: 89.28

DO NOT MERGE

Closing PR for now, but leaving branch up for future merge.


Add unsupervised methods

Some easy to add tools could be density estimation models that learn the distribution of the data without any labels.
Also, one class classification models, novelty or anomaly detection algorithms.

As a general note, possibly you could support the base classes in sklearn (ClassifierMixin, RegressorMixin) rather than individual methods, and then the actual methods could be passed as a parameter (possibly a string, although that's ugly) which would mean less work on your end.

Commit 3260fe6518734fc3be6921ea0324510c179d59dd adds a tool for anomaly detection. That is, it uses a model that can be trained in an unsupervised way and generates scores at every stream. Because the model is passed as a parameter, it is not only anomaly detection but could be density estimation, outlier detection, clustering, or any other unsupervised method. The tool should be refactored in order to indicate that.

Open #3 to refactor the anomaly detection tool into unsupervised learning.


[Bug] mmcls and mmseg clash with KeyError: 'ShiftWindowMSA is already registered in attention'

Describe the bug
Both mmcls (0.13.0) and mmseg (0.15.0) have:
@ATTENTION.register_module()
class ShiftWindowMSA(BaseModule):
    ...

To Reproduce
The command you executed.
>>> import mmcls.models.utils
>>> import mmseg.models.backbones
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ubuntu/tannery/model-etl/.venv/lib/python3.8/site-packages/mmseg/models/__init__.py", line 1, in <module>
    from .backbones import *  # noqa: F401,F403
  File "/home/ubuntu/tannery/model-etl/.venv/lib/python3.8/site-packages/mmseg/models/backbones/__init__.py", line 9, in <module>
    from .swin import SwinTransformer
  File "/home/ubuntu/tannery/model-etl/.venv/lib/python3.8/site-packages/mmseg/models/backbones/swin.py", line 201, in <module>
    class ShiftWindowMSA(BaseModule):
  File "/home/ubuntu/tannery/model-etl/.venv/lib/python3.8/site-packages/mmcv/utils/registry.py", line 309, in _register
    self._register_module(
  File "/home/ubuntu/tannery/model-etl/.venv/lib/python3.8/site-packages/mmcv/utils/registry.py", line 244, in _register_module
    raise KeyError(f'{name} is already registered '
KeyError: 'ShiftWindowMSA is already registered in attention'

Post related information

The output of pip list | grep "mmcv\|mmcls\|^torch"

mmcls                    0.13.0
mmcv-full                1.3.9
mmsegmentation           0.15.0
torch                    1.8.0
torch-optimizer          0.1.0
torchvision              0.9.0

Your config file if you modified it or created a new one.
N/A
Your train log file if you meet the problem during training.
N/A
Other code you modified in the mmcls folder.
None

Thanks for your report, we will try to solve it recently.

Should solved by #375


use latest type! inlined enum

Pull Request Test Coverage Report for Build 2690
Details

4 of 16 (25.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 86.995%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

json/lex_main.mbt
1
2
50.0%

json/lex_string.mbt
1
3
33.33%

json/lex_number.mbt
1
4
25.0%

json/lex_misc.mbt
0
6
0.0%

Totals

Change from base Build 2687:
0.06%

Covered Lines:
3726

Relevant Lines:
4283

💛  - Coveralls


Add a no-op StatsComponent to return when no implementation is available.

The no-op StatsComponent returns a no-op StatsRecorder and a null ViewManager.
The StatsRecorder is non-null so that code that only records stats doesn't need
to check for null.  NoopStatsRecorder.record(...) simply ignores the stats.
However, the ViewManager is null to avoid returning misleading empty results
from NoopStatsComponent.getViewManager().getView(...).

Codecov Report

Merging #468 into master will decrease coverage by 0.13%.
The diff coverage is 90.9%.

@@             Coverage Diff              @@
##             master     #468      +/-   ##
============================================
- Coverage     90.35%   90.21%   -0.14%
- Complexity      585      586       +1
============================================
  Files           106      106
  Lines          2188     2198      +10
  Branches        210      210
============================================
+ Hits           1977     1983       +6
- Misses          157      158       +1
- Partials         54       57       +3

Impacted Files
Coverage Δ
Complexity Δ

core/src/main/java/io/opencensus/stats/Stats.java
75% <100%> (-18.75%)
5 <0> (-3)

.../main/java/io/opencensus/stats/StatsComponent.java
100% <100%> (ø)
3 <2> (+2)
:arrow_up:

...c/main/java/io/opencensus/stats/StatsRecorder.java
80% <75%> (-20%)
3 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37df029...8f3aa39. Read the comment docs.


ERROR: Cannot find control with unspecified name attribute

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x] support request

Current behavior
If I set the list of fields statically, then everything works as it should. But if I load a list of fields from the server, then I get an error "Cannot find control with unspecified name attribute"
Expected behavior
Works without error.
Minimal reproduction of the problem with instructions
stackblitz
What is the motivation / use case for changing the behavior?
Please tell us about your environment:
Windows 7 x64
npm 5.6.0
node 8.11.1

Angular version: 6.0.0

Browser: [Chrome XX]

Language: [TypeScript 2.7.2]

Node (for AoT issues): node --version =

you should return a new ref for the fields in order to take account of the new change which is required to build form again.
see https://stackblitz.com/edit/angular-yyy4rr

I wasted nearly an hour investigating this error. In my case i WAS returning a new ref as @aitboudad mentioned.  The model name (key property) was objectId instead of objectID. Hope this saves someone's time! :-)

Any tips on using provided solution with angular material drag & drop and it's function copyArrayItem? I see that copyArrayItem uses splice and it looses track of elements if I'm writing something custome instead of using this function. https://github.com/angular/components/blob/master/src/cdk/drag-drop/drag-utils.ts#L62


Minor formatting fix.

There were a few names that had inconsistent indentations.

Thanks for your pr 🙌🏻


Use CreatedAt/UpdatedAt/StoppedAt from ECS API.

Closes https://github.com/remind101/empire/issues/682
Fixes https://github.com/remind101/empire/issues/555
$ emp ps -a acme-inc
v1.web.02510d1a-ca9f-4bda-b9d4-d87e4e3a4b7f  1X  RUNNING  26s  "acme-inc server"
$ # kill task
$ emp ps -a acme-inc
v1.web.b46508ce-0aaf-4100-8192-268d6040182e  1X  RUNNING   2s  "acme-inc server"

Still need to test this. I'm not seeing the new fields returned with the aws CLI.
First commit is the actual changes, second is just godep updates.
Depends on https://github.com/remind101/kinesumer/pull/20
Test

[ ] Log streaming still works.
[x] stoppedAt/createdAt/startedAt are never nil.

Tested this locally. *At fields weren't showing up for me in the CLI because of an old version.

:+1:  - what's with the new ConfigProvider & session stuff?  Is this a change in the SDK that we should be using more regularly?

Yeah, v1.0 of the go aws sdk completely changed how you initialize clients.


Added my project 'FINADICT' to the list

Added all the details of the project as per the requirements.

@ramonh I have ammended the changes you requested and added a few more information on the page.

Looks wonderful, thank you! Welcome to Port! 🚢

Thanks for approving ❤


LED Indicator

Is your feature request related to a problem? Please describe.
I've always been unhappy that tkinter does not provide an LED indicator (something like Labview has), and I think it would be great to create one! Plus the color palette naming convention of ttkbootstrap got me thinking about LED's in the first place (success, warning, danger...). Perhaps others have worked on this before, but if not I'm happy to help make something.
Describe the solution you'd like
The solution would include the following features:

Ability to change color of indicator
Disabled or enabled state (ie grayed out or not)
Label positioning relative to LED
Interactive mode (somewhat of a checkbutton?)
Blinking parameters (frequency, duty cycle, boolean)

Initially, I think circles will work fine, but eventually it would be nice to provide a good looking LED with some relief and shadowing (like in this pyqt5 example).
Describe alternatives you've considered
I've simply used labels as status indicators up to now, but it's not as nice looking
Additional context
I'll primarily be using this new widget in an experimental control software for my research group, but I think it could have uses elsewhere.

@nickschw2, this is an interesting idea. Thanks for the recommendation.


 However, this configuration led to numerous bugs when attempting to go full-screen or even encountering certain hover events while using Safari.
I am not knowledgeable enough to know of a better way to achieve this and was hoping to get some support by reporting this as a problem.

You should not use manage=on like this. It is meant for applications that mismanage their accessiblity role on macOS, so that windows can be forced to tile.
What you want is to use the window_created signal to unfloat specific windows upon creation:
window_created
    Triggered when a window is created.
    Also applies to windows that are implicitly created at application launch.
    Eligible for app and title filter.
    Passes one argument: $YABAI_WINDOW_ID

Signal docs: https://github.com/koekeishiya/yabai/blob/master/doc/yabai.asciidoc#signal
Something like:
yabai -m signal --add event="window_created" app="^(Alacritty|Safari|Firefox)$" action="yabai -m window \$YABAI_WINDOW_ID --toggle float"

Thank you, I did not know that manage=on is the cause of that behaviour.
Your window manager currently functions well enough, and I wouldn't want to trouble you. You're a legend for being the primary person behind making usable tiling possible on macOS! I truly appreciate your efforts. So, only consider this if you have the time.
Okay, I have attempted your config and it worked. However, with native mac apps it made yabai tile in the wrong order.

With non native apps it did that plus more delay between the window spawning.
Signals are too slow for anything but non urgent actions.
...
What I want to achieve is to make all windows inherently float except "^(Alacritty|Safari|Firefox)$", this is due to the fact that most apps are intended to float on Mac.
If you can figure a better way to achieve this without issue lmk.


Wallet fails to load on Android 5.0.2

Repro steps

Open wallet on android 5.0.2

Expected Result
Wallet works, If this is a limitation of android versions that is not fixable, then we should ensure the play store does not say we support version 5 and higher, but bump it up a version.
Actual Result

System Info

Minimum support android version is 5.1 or 6.0, would need to double check but 5.0.2 is not supported. Might need to bump the API level to 22 when compiling the app to prevent it from showing up in the playstore.


Adds MDCCurrentTraceContext for log correlation

This adds trace and span IDs to the SLF4J Mapped Diagnostic Context (MDC)
so that you can search or aggregate logs accordingly.
To enable this, configure brave.Tracing with MDCCurrentTraceContext
like so:
tracing = Tracing.newBuilder()
    .currentTraceContext(MDCCurrentTraceContext.create())
    ...
    .build();

Then, in your log configuration, you can use traceId and or spanId.
Here's an example logback configuration:
<pattern>%d [%X{traceId}/%X{spanId}] [%thread] %-5level %logger{36} - %msg%n</pattern>

When a trace is in progress, it would log statements like this:
2017-05-02 23:36:04,789 [fcd015bf6f8b05ba/fcd015bf6f8b05ba] [main] INFO  c.a.FooController - I got here!

Users could then copy/paste the trace ID into the zipkin UI, or use log
correlation to further debug a problem.
Fixes #150
See #369

cc @llinder @devinsba

@ryangardner I know you asked for this a year ago, but everything's coming together now

@jplock @hyleung @takezoe fyi on this, too.. Not sure if SLF4J is a constant for y'all or not

nice!

Looks good to me. Whats up with the circle-ci failure?

Unrelated flake but will have a look
On 3 May 2017 04:02, "Brian Devins"<EMAIL_ADDRESS>wrote:

Looks good to me. Whats up with the circle-ci failure?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/pull/389#issuecomment-298744821, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD613KYN8YoOnsd5AklOtQW4bbRYyG_ks5r14vFgaJpZM4NOUva
.

next release won't be until this weekend, so feel free to provide feedback after the fact. merged so people can play with snapshots

bumped version to 4.3.0-SNAPSHOT

Can this be extended to Log4j2 thread context?

Can this be extended to Log4j2 thread context?

yes.. I already have an impl, just was waiting for someone to ask

Awesome!

https://github.com/openzipkin/brave/pull/392

Currently trying to add the traceID into my logging for any HTTP request..
What is this logback configuration that is referenced(the only xml files I have are my pom.xml)? Also, because the decorator's create() methods are all deprecrated, should I be using the get() method instead?


3.6.0 causes issues with Symfony 3.4 and custom log handler services

Since 3.6.0 we're encountering the following issue, but only when using with Symfony v3.4.45, with v4.4.15 all is working fine:
Fatal error: Uncaught Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: Unused binding "Symfony\Contracts\HttpClient\HttpClientInterface" in service "instanceof.Monolog\Handler\HandlerInterface.0.Pimcore\Log\Handler\ApplicationLoggerDb". in /home/travis/build/pimcore/pimcore/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php on line 50
Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: Unused binding "Symfony\Contracts\HttpClient\HttpClientInterface" in service "instanceof.Monolog\Handler\HandlerInterface.0.Pimcore\Log\Handler\ApplicationLoggerDb". in /home/travis/build/pimcore/pimcore/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php on line 50

This is the used service definition:
https://github.com/pimcore/pimcore/blob/416ed369e071cfab175b33b9a4596c130dbe1a29/bundles/CoreBundle/Resources/config/logging.yml#L33
This all seems to be related with this lines:
https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/MonologExtension.php#L158
But I've currently no idea why this breaks the service definition in Symfony 3.4

Bundles should never use bindings, they don't need to (neither any auto-*, nor named arguments ideally). This config should be made plain old config.
@brusch would you like sending a PR to update this?

I should read more before commenting... This is a rule for autoconfiguration. It's fine.
3.4 doesn't support bindings in autoconfiguration, that's why I suppose.

The bundle should drop support for 3.4 IMHO. IT's EOLedin a few weeks anyway.

Thanks a lot for the really fast response 👍
I'd be fine with dropping the support 😊
Alternatively we'd have to check for the auto-config support for bindings there, right?

I guess we can close this  issue?

As far as I understand this bundle should drop the support of Symfony 3.4 first.

While migrating a 10 years+ project from Symfony 3 to 4 and bumping monolog, I've got the issue.
If it can help others, I patched it by adding a useless HttpClient in the handler's constructor.
public function __construct(HttpClientInterface $httpClient)

To be removed soon enough once in Symfony4+ :-)


Python Outline does not seem to correctly understand a 'pass' statement.

Attached is a picture of this bug. Note that in the source code there is an class definition which has a single 'pass' statement:
class NoPendingGamesException(Exception):
    pass`

In the outline view however the subsequent method definitions are attached to the NoPendingGamesException class, but should not be.

Update: Sorry, it's not really got anything to do with pass statements. It is simply if you have method definitions at the top-level scope. In this case the top-level definitions are "captured" by the most recent class definition.


Adding tags and updating archetype - Issue #27

I went through and added related tags to each of the stories .md files. I also went and updated the archetype to match accordingly and be available for future stories.

So appreciate your first contribution, @Pow3r5! Let me know if there are any other great ideas that you have for our site/experience.


Question, not issue or complaint

Hi. Is there an event model for this, or do we loop / state machine it for reading multiple inputs?
Thanks!

Hi.
There is "partial" event support.
You can use DetectEdge to register for falling/rising edge event, but you still have to manually check if the event occurred by calling EdgeDetected
See the doc and the example  for more info.
And also this issue https://github.com/stianeikeland/go-rpio/issues/21 with some reasoning why it's slightly better then regular polling.


Fixes timestamp issue + Elaborates some text descriptions

REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.

This PR commits the following changes to the `notebooks/official/feature_store/sdk-feature-store-pandas.ipynb` notebook:

Fixes the timestamp issue while ingesting the data to featurestore (adds zonal info. (+00:00)). (PR #1862 )
Elaborates existing textual descriptions with relevant referances.
Removes unnecessary or redundant steps.

REQUIRED: Fill out the below checklists or remove if irrelevant

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[x] Use the notebook template as a starting point.
[x] Follow the style and grammar rules outlined in the above notebook template.
[x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[x] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
[x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

If you are opening a PR for Community Notebooks under the notebooks/community folder:

[ ] This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
[ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

If you are opening a PR for Community Content under the community-content folder:

[ ] Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
[ ] The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
[ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

/gcbrun


Add Create Commitment Verification + DataHash

Use the CreateCommitment function to calculate the PFB commitment and use it for the DataHash. Add it to the Verification and write proper tests. We should also consider adding it to the DA-Interface and extracting it from Rollkit into celestia-openrpc.

Will be part of https://github.com/rollkit/rollkit/issues/829.


WIP. XProjectEnv base and helpers for MSBuild Properties. /vsSBE PR53

Introduces XProjectEnv (spitted IsolatedEnv as the base but without IDisposable)
+ Also adds an regular MSBuild Properties and other related changes for convenient work with this properties like extension method GetFileProperties, AddOrUpdate etc.
Part of https://github.com/3F/vsSolutionBuildEvent/pull/53
WIP

IsolatedEnv still implements IDisposable that helps to release loaded projects as before.
But for some cases we don't need to dispose this at all.
The case is, for example, vssbe. Where EnvDTE can load any other project itself while loading something through EnvDTE.Project collection.
Therefore, we also need to provide like XProjectEnv base for work with this environment 'as is'.
Means that user can also consider some additional resource releasing later.
Please note, the default behavior for Sln wrapper still is IsolatedEnv. That is, this is compatible changes.


Unfocused Appearance editor doesn't appear on +, disappear on Deletion

Windows Terminal version (or Windows build number)
1.11
Other Software
No response
Steps to reproduce
Add or remove an unfocused appearance.
Expected Behavior
No response
Actual Behavior
On add, the + changes to a [trash] icon, but I cannot scroll to reveal an unfocused appearance. It appears if i navigate away and back.
On delete, the [trash] icon changes to a +, but the UI doesn't disappear.

Ah yes I didn't update the notifications we send to xaml when I added the til::feature, thanks for catching this!


Map rotates and I can't stop it easily

When I build a map, or update it, etc. it's not rare that it has a rotational movement, and it's not easy to stop it.
That makes everything difficult, and feeling weird.
Also, with this rotation everything is fuzzy in my mind, both from a memorization point of view, and from a usability point of view: I'd prefer everything to stay still, and let me arrange nodes' positions and whole map rotation in a way that I prefer, except when I explicitly trigger some auto-adjustment, in a way that is impossible to let it trigger in an easy/unwanted way, i.e. with a conformation dialog and what not, to avoid everything getting scrambled.
Instead, the "getting scrambled" mode currently is the default and "always on" mode for the map, and it's not good.

Just found the checkbox option in "Configure view", my bad I wasn't aware of it.
Closing this issue!


Dead link

The link full Azure Bastion security baseline mapping file in the Note section points to a non existing file.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3b4b232e-aef5-1c57-69fc-17d54067397c
Version Independent ID: 3b4b232e-aef5-1c57-69fc-17d54067397c
Content: Azure security baseline for Azure Bastion
Content Source: benchmark/azure/baselines/azure-bastion-security-baseline.md
Service: bastion
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@jeircul
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.
@msmbaldwin FYI

This link has been fixed.  We sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


deprecate: why depracate an entire model/artifact?

It's unclear to me the value of deprecating an entire model/artifact. Why is it not enough to unassign a stage or archive the git repo? I get confused with what this is supposed to do in gto and studio. Is there a known workflow where it is helpful/needed?

It disappears from the MR then. If you just unassign it you can still see it. You can't archive the whole if this is a monorepo, or you have an older model in your history that you don't want to see anymore.


Streaming a video file instead of webcam

I'm trying to establish a WebRTC connection between 2 peers and stream a video file instead of a webcam stream. Currently I'm able to establish a connection with a webcam stream without a problem, but I need the capability to also stream a video (in mp4/mkv/etc, various format support will also be very helpful).
I've searched all over this Issues board and did find a comment that Alex said it's doable. I'd like to know if it's something small that I can fork and maybe build myself, and if so what is the general idea for one to do such a thing?
Thanks

I solved this point via jmuxer and streaming audio & video (h264) via datachannel

This is work in progress.

This is work in progress.

any progress about this?

I think this feature will not to be implemented inside webrtc project and
should be marked as out of scope.
This feature is partially implemented inside banalytics.live project.
https://banalytics.live/
@.***
File media stream source
[image: image.png]
вт, 23 апр. 2024 г. в 11:12, Danny Xu @.***>:

This is work in progress.
any progress about this?
—
Reply to this email directly, view it on GitHub
https://github.com/devopvoid/webrtc-java/issues/77#issuecomment-2071808453,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGKG34ZV3ACY2SP3PFWG33Y6YQZVAVCNFSM52B5BI2KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBXGE4DAOBUGUZQ
.
You are receiving this because you commented.Message ID:
@.***>

--
Best regards,
Siarhei Tserakhau
CTO, Banalytics
https://banalytics.live
@.***
https://www.linkedin.com/pulse/configure-your-safety-banalytics-banalytics-live
https://www.facebook.com/Banalytics


HTTPS is now optionnal and disabled by default for vatlayer requests

This PR introduces a new settings: VATLAYER_USE_HTTPS which is set to False by default.
This closes #6.

Shouldn't Vatlayer automatically use HTTPS when an API key is present?

LGTM, but we'll also need to update readme to reflect this change.

Little bump.

Bump.


⚠ AVS (kty) has degraded performance

In bfb35a4, AVS (kty) (https://avus.com.br) experienced degraded performance:

HTTP code: 200
Response time: 8959 ms

Resolved: AVS (kty) performance has improved in 8ad14e9.


How do you locate rockets after they have landed, but not on launch pad?

My rockets aren't returning to the launch pad and I think this is a good feature. The pad doesn't have a docking pad that tell it to come back here, but there should be a way to locate it once it returns to the planet.. 1st rocket I was unable to locate, 2nd rockets landed 50-100 block away and when i resent I'm not able to locate it.

Well, they should return to the launchapd. But can you send a screenshot? Im not really understanding you.
Unmanned Rockets?
Spacestation or planet?

If the a unguided rocket reaches space, they do not return. If the rocket do not reach outer space and run out of fuel, they will return either on the pad or some blocks outside of it depending on the altitude they gained.
Note: This is purely empyrical information, from a lot of tests. I do not know what the code is supposed to do.

Screenshots not available I left the game running while at work, it crashed and now stalls at 0% when I load the world.
Rockets were unmanned
My first rocket setup was 4  liquid engines,8 fuel cells, 1` sate bay, 1 guidance. It went to space because the sate linked, but didn't  return to the pad. Monitor showed that it had returned to the ground and still had fuel remaining, but I couldn't locate it.
My second rocket setup 5 liquid engines ,10 fuel cells, 1 sate bays, 1 guidance . It went to space left the sates and returned but not to the pad.
Since it wasnt on the pad i took it apart and rebuilt it adding 4  more sate bays. It went to space, left the sates and return, but i couldnt locate. Again monitor showed it had landed and had fuel remaining.

If a rocket is set to launch a satellite and unmanned it will land some distance away from the launch pad, though sometimes in unloaded chunks, so it may appear to get stuck in the tracking station sometimes.
As for tracking where they land it could be printed in the tracking station or visible in world via a smoke flume.

Why didn't make a compass like item that can find the rocket when they land =)

My unmanned rocket placed a satellite into orbit successfully, then "landed" about 200 blocks directly above the launch pad. screen shot attached.

This report is duplicated by #1754, and is otherwise intended.


Exclusively applicable fix-its aren't testable

Description
I have a diagnostic with several fix-its, where only one can be applied. Here's the usage, and note that, while diagnostics is correct and (very!) useful, both fixes and expansion are nonsensical:
assertMacro {
  """
  @MemberwiseInit
  struct S {
    @Init(default: "Blob") var name = "Foo"
  }
  """
} diagnostics: {
  """
  @MemberwiseInit
  struct S {
    @Init(default: "Blob") var name = "Foo"
          ┬──────────────
          ╰─ 🛑 Custom 'default' can't be applied to already initialized variable
             ✏ Remove 'default: "Blob"'
             ✏ Remove '@Init(default: "Blob")'
             ✏ Remove '= "Foo"'
  }
  """
} fixes: {
  """
  @MemberwiseInit
  struct S {
    @Init
  }
  """
} expansion: {
  """
  struct S {
    @Init

    internal init() {
    }
  }
  """
}

To show the actual fix-it behavior applied in Xcode, here's a theoretical array syntax format:
…
} fixes: {
  [
    """
    @MemberwiseInit
    struct S {
      @Init var name = "Foo"
    }
    """,
    """
    @MemberwiseInit
    struct S {
      var name = "Foo"
    }
    """,
    """
    @MemberwiseInit
    struct S {
      @Init(default: "Blob") var name: String
    }
    """,
  ]
} expansion: {
…

And, a theoretical dictionary syntax format:
} fixes: {
  [
    #"✏ Remove 'default: "Blob"'"#:
    """
    @MemberwiseInit
    struct S {
      @Init var name = "Foo"
    }
    """,
    #"✏ Remove '@Init(default: "Blob")'"#:
    """
    @MemberwiseInit
    struct S {
      var name = "Foo"
    }
    """,
    #"✏ Remove '= "Foo"'"#:
    """
    @MemberwiseInit
    struct S {
      @Init(default: "Blob") var name: String
    }
    """,
  ]
} expansion: {

What do you think?
P.S.: swift-macro-testing is great—I'm heavily using/abusing it. Thank you!
Checklist

[X] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
Each fix-it should be applied to the original source independently, each producing a corresponding fixed-source string.
Actual behavior
It's assumed that all fix-its can always be applied on top of each other, accumulating into a single string.
Steps to reproduce
No response
swift-macro-testing version information
0.2.2
Destination operating system
macOS 14.1.2
Xcode version information
Xcode Version 15.0.1 (15A507)
Swift Compiler version information
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0

Whelp, my initial proposal is actually still too simplistic. To fully model the diagnostics domain would require another level of nesting:
  assertMacro {
    """
    @MemberwiseInit(.public)
    public struct Person {
      var firstName = "Foo"
      var lastName: String
    }
    """
  } diagnostics: {
    """
      @MemberwiseInit(.public)
      public struct Person {
        var firstName = "Foo"
        ┬────────────────────
        ╰─ 🛑 @MemberwiseInit(.public) would leak access to 'internal' property
           ✏ Add '@Init(.public)'
           ✏ Add 'public' access level
           ✏ Add '@Init(.ignore)'
        var lastName = "Bar"
        ┬───────────────────
        ╰─ 🛑 @MemberwiseInit(.public) would leak access to 'internal' property
           ✏ Add '@Init(.public)'
           ✏ Add 'public' access level
           ✏ Add '@Init(.ignore)' and an initializer
      }
    """
  } fixes: {
    [
      (
        "🛑 @MemberwiseInit(.public) would leak access to 'internal' property",
        [
          "✏ Add '@Init(.public)'": """
            @MemberwiseInit(.public)
            public struct Person {
              @Init(.public) var firstName = "Foo"
              var lastName: String
            }
          """,
          "✏ Add 'public' access level": """
            @MemberwiseInit(.public)
            public struct Person {
              public var firstName = "Foo"
              var lastName: String
            }
          """,
          "✏ Add '@Init(.ignore)'": """
            @MemberwiseInit(.public)
            public struct Person {
              @Init(.ignore) var firstName = "Foo"
              var lastName: String
            }
          """
        ]
      ),
      (
        "🛑 @MemberwiseInit(.public) would leak access to 'internal' property",
        [
          "✏ Add '@Init(.public)'": """
            @MemberwiseInit(.public)
            public struct Person {
              var firstName = "Foo"
              @Init(.public) var lastName: String
            }
          """,
          "✏ Add 'public' access level": """
            @MemberwiseInit(.public)
            public struct Person {
              var firstName = "Foo"
              public var lastName: String
            }
          """,
          "✏ Add '@Init(.ignore)'": """
            @MemberwiseInit(.public)
            public struct Person {
              var firstName = "Foo"
              @Init(.ignore) var lastName: String = <#value#>
            }
          """
        ]
      )
    ]
  } expansion: {
    """
    public struct Person {
      var firstName = "Foo"
      var lastName: String

      public init() {}
    }
    """
  }

Notes:

The expansion closure string is the original expansion, not after having applied fix-its. That is, the MemberMacro added diagnostics to the context (it didn't throw diagnostics) and returned a declaration.
The fixes closure returns [(String, [String: String])]—a dictionary at the top level isn't ideal because multiple diagnostics with the same message can be present, as is the case in my example. At the deeper level, I think assuming fix-its will always have unique message strings is reasonable, but I could easily see using a tuple for consistency (and to be more correct).

Hey @gohanlon, just wanted to thank you for looking into this issue and to let you know we have seen it! We've just been quite busy with some other things, but we hope to get back to it soon. Most likely in the near year.

No worries! I’ve implemented the proposal and will have a PR ready soon to advance our discussion when the time is right.
While wrapping up the PR, I found and fixed a bug exposed by the new format, where fix-its were misapplied. The issue was with (Swift’s) FixItApplier, replacing a parent instead of a child (like a code block with a variable declaration). To fix, I updated the FixItApplier with a recent, bug-free version from Swift, with minor backporting to 509.0.2. Since that came up late in the PR work, I'll just include it in the PR for now.

@gohanlon Appreciate it! If it's not too much trouble, though, I think we'd take that fix as a separate PR, as it sounds like a no-brainer. That'll make it easier to review your changes.

Indeed, the FixItApplier fix can definitely land sooner than a big PR. I started on that work, just need a test or two and I'll create the PR!


New tutorial for creating a package in ROS 2

I was a little confused about the "minimum required contents" in section 1.
@sloretz Technically setup.cfg is not required unless the package has an executable, right? So it's not really a minimum requirement? I'm not sure, let me know if it should still be included.
Also I'm not sure where to make an issue about needing to backport the ros2 pkg create --build-type ament_cmake... command to Dashing.
My environment populated the name and email for me during package creation, but I'm assuming that's not the norm, so I need someone else to show me what that would look like if it wasn't automatically populated. I think the missing name and email fields are another TODO, so potentially have to make a handful of edits for that.
Signed-off-by: maryaB-osr<EMAIL_ADDRESS>

Also I'm not sure where to make an issue about needing to backport the ros2 pkg create --build-type ament_cmake... command to Dashing.

I guess you are referring to the ament_python version of the command.
The ament_cmake one was already there.
Though we usually don't backport features, I think this one should be backported.

My environment populated the name and email for me during package creation, but I'm assuming that's not the norm, so I need someone else to show me what that would look like if it wasn't automatically populated. I think the missing name and email fields are another TODO, so potentially have to make a handful of edits for that.

The maintainer name is automatically populated with the "login name" of your session.
It probably needs to be edited manually, as usually the login name of your account is a nickname.
The maintainer email is automatically populated with the one you configured in git.
If git is not configured, it will look like<EMAIL_ADDRESS>To make things simple, I would just put:
<maintainer<EMAIL_ADDRESS>
So, it's clear that it has to be checked.

@sloretz Technically setup.cfg is not required unless the package has an executable, right? So it's not really a minimum requirement? I'm not sure, let me know if it should still be included.

IIUC it's only required when a package install executables (so ros2 run finds them). The ros2 pkg create command used in this tutorial creates one, but that makes sense because it's adding an executable with a print statement.

@ivanpauno or @sloretz ready to merge?


Feature: Show image resolution on hover information

What feature or improvement do you think would benefit Files?
Would love it if you added the feature in the original file explorer where when you hover over photos it shows the photo's dimensions. That could really come in handy. instead of going into the parties menu.
Requirements

This proposal will accomplish X
This proposal will accomplish Y
This proposal will accomplish Z

Files Version
<IP_ADDRESS>
Windows Version
Windows 11 Pro 22631.3296
Comments
No response

Thanks for the report, I've added this to the project board.

Your welcome thats the only issue i have. Otherwise this app is perfect keep it up. I hope you keep it for even windows 12 and onwards even tho we wont get windows 12 for now🤣. Great work i should be going into app development as well🔥

@kemar-christie this feature will be included in the next release (v3.5).

Noted with thanks
Kemar Christie
K.CHRISTIE
Email: @.***
On Mon, Jun 10, 2024 at 6:40 PM Yair @.***> wrote:

@kemar-christie https://github.com/kemar-christie this feature will be
included in the next release (v3.5).
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14975#issuecomment-2159499298,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASDQIAYGUJPZFK3V2AP7J2DZGY2NNAVCNFSM6AAAAABE2EPYKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGQ4TSMRZHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Feature Request(/Contribution Offer): Scripts to support easy use of this chart

Thanks so much, this is a really useful project, It has transformed the ease of management of (java) Minecraft servers for me.
However, quite a bit of background in K8S and Helm is required to take advantage of it. I propose that a the project provides a script for a simple CLI for deploying and managing servers.
I have a fully functional project which I'm happy to contribute here if you think appropriate. See the last section of the README for details of my CLI script. (I also include simple instructions for getting a cluster up and running at home)
https://github.com/gilesknap/k3s-minecraft

Close this, given it's now there on https://github.com/itzg/minecraft-server-charts/tree/master/charts/minecraft#tutorials ?

Thanks for the reminder @vorburger


Created the banner structure and fixed the styling

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Added a dynamic banner which will change everytime the page loads
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[ ] I have performed a self-review of my own code

Screenshots or example output

@aimunhidden485 The build fails with a lot of lint errors

Please follow the steps in readme to correct those.

@aimunhidden485 The build fails with a lot of lint errors

Please follow the steps in readme to correct those.

okay I'm checking

Sometime getting preview not available even of there is a cover image

Sometime getting preview not available even of there is a cover image

Okay I'm checking

https://user-images.githubusercontent.com/96931784/213427398-40d04dec-bead-400d-9906-4eff9c6494be.mp4

Hi @aimunhidden485 Can we not truncate the description here?

Can you please fix this so that I can merge?

Hi @aimunhidden485 Do not truncate the description here?

Can you please fix this so that I can merge?

sure


Doubled achievements

Deianeira achievement appears two times in wonderers of the world, and semnai sans ombre appears both in wonderers and Fontaine (III) achievement groups.

Duplicate #488 #491 #493 #497 #498 #500 #504


Add a Gitter chat badge to README.rst

pydanny/cookiecutter-django now has a Chat Room on Gitter
@pydanny has just created a chat room. You can visit it here: https://gitter.im/pydanny/cookiecutter-django.
This pull-request adds this badge to your README.rst:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Already done!


[Request-for-external] Codeunit 80 Sales Post - FillInvoicePostingBuffer

Hi, I was wondering if it would be possible to change the procedure FillInvoicePostingBuffer in Codeunit 80 from local to external.
My team and I use this procedure a lot in our code, and changing it to external would be a huge help.
Thanks for your work, have a nice day

Let me inform you that we implement external changes in next version only, so it will not be available for 17.x or 18.x. We plan do refactor this implementation to make it extendable in 19.x, therefore we cannot make it external right now.


Add value to  with onChange freezes input

The Input component value becomes read-only when an onChange or onInput prop are passed with a value property. Is there a way to add a value to the input? The use case is a user preference form where there are default values (e.g. name, email) present for editing.

version 4.8.0
components: Input

Usage:
<Input
      ref={(f) => this.emailField = f }
      type="text"
      value={this.state.value.email} // <-- causes issue
      placeholder="E-mail Address"
      onChange={this.setEmail.bind(this)}
      className="bg-icon icon-login-inverse" />

This is how react works. React has a separate prop, defaultValue for setting the initial value for an uncontrolled input.
See https://github.com/reactstrap/reactstrap/issues/543#issuecomment-331005424

Now don't I feel stupid.. I'm new to the React ecosystem. Thanks for replying quickly.


Refactor Viperize function

Coverage remained the same at 100.0% when pulling 306f00ec859ad62198ce89d967fc4db478a2593a on lil_cleanup into 1f670290a10179aa0a18f4e042bb1783ab0c5649 on master.

tests already exist for this function (it's more of a test utility function than anything else)

Coverage remained the same at 100.0% when pulling 306f00ec859ad62198ce89d967fc4db478a2593a on lil_cleanup into 1f670290a10179aa0a18f4e042bb1783ab0c5649 on master.

I don't see any tests in this package

Does the coverage check work for all packages e.g. cmd, pkg...?

go only checks coverage for directories that have at least one _test.go file

Coverage remained the same at 100.0% when pulling cfc57b3e533def7bde8fbda000622d3be448cc24 on lil_cleanup into 1f670290a10179aa0a18f4e042bb1783ab0c5649 on master.


Add snippets to Bucket's javadoc, BucketSnippets class and tests

Coverage remained the same at 85.865% when pulling d84a2b23f9f6bfcd61d2a6d5646010aaeee51566 on mziccard:bucket-snippets into 23eb620b8c752841a0148d9932964116c7e13463 on GoogleCloudPlatform:master.

Coverage remained the same at 85.865% when pulling f201a7a034a5a4c44e1c1469d89e4c83389a5ad1 on mziccard:bucket-snippets into 23eb620b8c752841a0148d9932964116c7e13463 on GoogleCloudPlatform:master.

/cc @lesv

LGTM


Harbor tile upgrade from 1.4 to 1.5 failed

1.Deploy Harbor Registry 1.4.0 in Ops Manager
2.Login and create project and push images to harbor
3.Deploy Harbor Registry 1.5.0 to upgrade the 1.4.0
Apply change failed with error:
"Action Failed get_task:"
"result 1 of 3 pre-start scripts failed. Failed Jobs: harbor.
Successful Jobs: enable-bosh-dns, bosh-dns.

Fixed in https://storage.googleapis.com/harbor-ci-pipeline-store/tile-releases/harbor-container-registry-1.5.0-build.27.pivotal


enable query when conprof is disabled

What did:

Enable query history conprof results by changing a date even if the conprof feature is disabled

Codecov Report

Merging #1217 (a9ac833) into master (e79a650) will decrease coverage by 7.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
- Coverage   31.66%   24.07%   -7.59%
==========================================
  Files         291       92     -199
  Lines       17115     9313    -7802
  Branches      686        0     -686
==========================================
- Hits         5419     2242    -3177
+ Misses      11465     6931    -4534
+ Partials      231      140      -91

Flag
Coverage Δ

be_integration_test_latest
?

be_integration_test_v4.0.1
?

be_unit_test
24.07% <ø> (ø)

e2e_test
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79a650...a9ac833. Read the comment docs.


Connection string for Managed instance

Hi, we are planning to move our "on-premise" tabular model to Azure Analysis Services. Currently, we use Windows Auth and the connection string for data source looks like this : Provider=SQLNCLI11.1;Data Source=localhost;Integrated Security=SSPI;Initial Catalog=DatavarehusDB.
How should be the connection string if we want to use AAD Auth and data source is SQL Managed Instance ? Thanks !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ea45d88b-212b-51ae-b902-6efd5873f6c5
Version Independent ID: 6f86e171-7553-3d01-00fa-e0865d8d817b
Content: Data sources supported in Azure Analysis Services
Content Source: articles/analysis-services/analysis-services-datasource.md
Service: azure-analysis-services
GitHub Login: @Minewiskan
Microsoft Alias: owend

@SuperSing Thank you for reaching out. At this time we are reviewing the ask and will provide an update as appropriate.

@SuperSing Please refer to below docs.

Use Azure Active Directory Authentication for authentication with SQL
Tutorial: Managed instance security in Azure SQL Database using Azure AD server principals (logins)
Provision an Azure Active Directory administrator for your Managed Instance

Do let us know if you have any further query. Thanks!

@SuperSing Here is another doc for Using an Azure AD identity to connect from a client application:

Using an Azure AD identity to connect from a client application

@SuperSing We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and reopen the issue. We will gladly continue the discussion.
And if you have a specific scenario which is not directly related to the document content but needs assistance, then please consider posting your question on MSDN-Azure Analysis Services and other forums (stackoverflow - Azure Analysis Services), we have our engineers and others who are monitoring them and will be happy to help.
If you have a document which you are following and if you think it needs an update, please let us know about that here.
Thank you.


Add preview-markdown-result feature

Thanks for contributing! 🍄

LINKED ISSUES: Closes #3711

TEST URLS: https://github.com/sindresorhus/refined-github/edit/main/readme.md

SCREENSHOT:

Tested in Firefox and Chromium.

I like that it’s pretty short!
Does this conflict with our other markdown-source feature?

Does this conflict with our other markdown-source feature?

No, they don't target the same pages.

🙌

One moment too late… what do you think if we rename this to hide-markdown-diff? Technically we’re already on a markdown preview

One moment too late… what do you think if we rename this to hide-markdown-diff? Technically we’re already on a markdown preview

Yeah I don't really like the current name. The description could probably be improved too.

Done


docs: make some small improvement to clarify semantic search use cases

This PR aims to improve the understanding of semantic search applications. Previously, the documentation needed to be more explicit about using the gem for this purpose, leaving users to infer this usage from the more general information provided.
Changes include:

Revised the "Getting Started" section to highlight the semantic search use case better.

Hi @kieranklaassen, thanks for the PR, but I prefer the current docs.


Port the paper-element tests!

Part of https://github.com/dart-lang/polymer_elements/issues/1. This may need to be split up into multiple sub-tasks.

Guys, does anyone started working on this one?

I'd like to help, but I might not be able to get to it until the weekend.  There's 30 so of them, so maybe just pick 5-10 at a time and post them here so we know who's working on what?

sounds good!

If its easier I am also more than happy to split these up into a few different tasks as well

Ok, I'll take first 6 in the /src/paper-*

paper-badge
paper-button
paper-card
paper-checkbox
paper-dialog
paper-dialog-scrollable

These elements are skipped:

paper-behaviors
paper-dialog-behavior

@jakemac53 Thanks, but I think this will work fine.
@vsheyanov Ok.  I'll take the next 6

paper-drawer-panel
paper-fab
paper-header-panel
paper-icon-button
paper-icon-item
paper-input

next batch

[ ] paper-item
[ ] paper-material
[ ] paper-menu
[ ] paper-menu-button
[ ] paper-progress

@jakemac53 should we create a pull request when a batch of test is ready or better to create one in the end?

@vsheyanov however you would prefer

@jakemac53 looks like paper-submenu is missing in polymer-dart, but exists in original repo. What should be done in this case?

@jakemac53 also, could you clarify, is it normally, that constants from JS elements don't exist in generated dart sources? For instance PaperMenuButton.MAX_ANIMATION_TIME_MS = 400; doesn't exist in paper_menu_button.dart and thus cannot be used. Thanks

@jakemac53 I'm looking at the one of the tests for paper-icon-button that's failing.
the dom
<paper-icon-button id="fab1" icon="add" class="style-scope main-app x-scope paper-icon-button-0" role="button" tabindex="0" aria-disabled="false">
    <paper-ripple id="ink" class="circle style-scope paper-icon-button" center="" animating="">

  </paper-ripple>
    <iron-icon id="icon" class="style-scope paper-icon-button x-scope iron-icon-0"><svg viewBox="0 0 24 24" preserveAspectRatio="xMidYMid meet" class="style-scope iron-icon" style="pointer-events: none; display: block; width: 100%; height: 100%;"><g class="style-scope iron-icon"><path d="M19 13h-6v6h-2v-6H5v-2h6V5h2v6h6v2z" class="style-scope iron-icon"></path></g></svg>
    <iron-meta id="meta" type="iconset" class="style-scope iron-icon"></iron-meta>
  </iron-icon>
  </paper-icon-button>

this test is failing
expect(Polymer.dom(b1.$['icon'].jsElement['root']).querySelector('svg'),
          isNotNull);
    });

but I can find iron-meta
expect(Polymer.dom(b1.$['icon'].jsElement['root']).querySelector('iron-meta'),
          isNotNull);
    });

Bug in polymer?

taking the additional tests in the paper-input repo (Added to my original comment)

@vsheyanov I am working on adding a few other missing elements, and I will make sure paper-submenu is a part of that.
In terms of js constants we don't have support for accessing those from dart wrappers today. Usually they are just things used internally, but you could feel free to add an issue if there is a constant which we should actually be exposing.

@ErikGrimes that does seem like a bug, what about if you just do:
'''dart
expect(b1.$['icon'].querySelector('svg'), isNotNull);
'''

@vsheyanov paper-submenu has now been added in master

@jakemac53 I get the same result.  The svg element isn't present in the children property either. The DOM above is from using paper-icon-button in a demo application and inspecting via Dartium.  The element is setup properly and the queries work in the demo app. I was hoping to reproduce the issue in a gist but it's proving to be a bit of pain.  I'm not sure if it's another bug or simply my lack of understanding.
<dom-module id="main-app">
  <template>

    <paper-button on-click="runTest" raised>run test</paper-button>

      <paper-icon-button id="fab2" icon="add" on-click="inspectDom"></paper-icon-button>

      <template id="TrivialIconButton">

              <paper-icon-button id="fab1" icon="add"></paper-icon-button>

      </template>

  </template>
</dom-module>

@HtmlImport('main_app.html')
import 'dart:html';

import 'package:polymer/polymer.dart';
import 'package:web_components/web_components.dart' show HtmlImport;
import 'package:polymer_elements/paper_icon_button.dart';
import 'package:polymer_elements/paper_fab.dart';
import 'package:polymer_elements/iron_icons.dart';
import 'package:polymer_elements/iron_icon.dart';
import 'package:polymer_elements/paper_button.dart';
import 'package:test/test.dart';

@PolymerRegister('main-app')
class MainApp extends PolymerElement {

  factory MainApp() => new Element.tag('main-app');
  MainApp.created() : super.created();

  @eventHandler
  void inspectDom(Event event) {
   PaperIconButton b = event.currentTarget;
    IronIcon i = b.$['icon'];
    print(i.children);
    print(Polymer.dom(b.$['icon'].jsElement['root']).querySelector('svg'));
  }

  @eventHandler
  void runTest(Event e){
    PaperIconButton b1 = fixture('TrivialIconButton').querySelector('#fab1');
    expect(b1.src, isNull);
    expect(Polymer.dom(b1.$['icon'].jsElement['root']).querySelector('svg'),
    isNotNull);
  }

  fixture(String id) {
    var container = this.querySelector('#testContainer');
    if (container == null) {
      container = new Element.html('

');
      this.append(container);
    }
    container.children.clear();

    var elements = new List.from((document.importNode(
        this.querySelector('#$id').content,
        true) as DocumentFragment).children);
    for (var element in elements) {
      container.append(element);
    }
    return elements.length == 1 ? elements[0] : elements;
  }

}

In the above the template is in the children, but can't be found by querySelector.  I grabbed it by id from $, but the it turns out the content is null.
Any advice on getting the repro to work?  Should I merge with the failing test and file a bug pointing to the test?

@ErikGrimes I would just mark it as skipped and link an issue to investigate, I can take a look at it later. Thanks!

Picking up:

[] paper-radio-button
[] paper-radio-group
[] paper-ripple
[] paper-scroll-header-panel
[] paper-slider
[] paper-spinner
[x] paper-styles (no tests)

Next batch:

[ ] paper-tab
[ ] paper-tabs
[ ] paper-tabs-icons
[ ] paper-textarea

[x] paper-toast (no tests)

[ ] paper-toggle-button
[ ] paper-toolbar
[ ] paper-tooltip

Just a heads up, I'm not sure when I'll get back to this. I upgraded my Mac and now content-shell and dartium don't work with test.  Test just times out trying to connect. I filed an issue https://github.com/dart-lang/test/issues/324. So, feel free to pick up the last three from my batch.  I won't be doing anything until I get my dev environment sorted out.

@ErikGrimes no problem thanks for the help and the heads up!

@jakemac53 You're welcome! Don't merge my last pull request. I think it might have something to do with my problems. I made a fresh clone of dart-lang/polymer_elements and the tests work fine. Tests from other projects work as well.  My last change was to common which is included in every test.  The odd thing is I swear all the tests before I pushed and they passed.

@jakemac53 I confirmed it's related to my fork.  I cloned my fork of polymer_elements on my Mac at work and it crashed content-shell.

@ErikGrimes I edited your comment above to remove the remaining items, and I will start working on them:

[ ] paper-ripple
[ ] paper-scroll-header-panel
[ ] paper-slider

ok, all done it looks like!


Update API docs and support guarantees

Cleaning up the docs about API types and their support guarantees.
@jason-ha @DLehenbauer @rohandubal @CraigMacomber please review

@kashms - I suggest the following changes:

Move discussion of experimental/internal packages to end, as these are relevant for the smallest audience.
Removed "We guarantee..." from public, since minor/patch breaks could happen unintentionally (or we could change our policy in the future.)
Removed "Rest assured..." from legacy, since plans could change (e.g., we find it more economical to support legacy DDSes indefinitely.)

(#21490 is an optional PR into your branch that makes these changes with some other light editing.)


batch size selection

Hi, thanks for sharing your implementation. I have a question about the batch size. Why batch size of 2 is selected? Batch size of 2 is also chosen by OICR. Have your ever tired batch size of 1, or other batch size larger than 2?

For the Caffe implementation on the PASCAL VOC datasets, we haven't tried other batch sizes and just follow Fast R-CNN to set batch size to 2. For this PyTorch implementation, we set batch size to 4 because we found that batch size 4 obtains higher accuracy than other choices.

For the Caffe implementation on the PASCAL VOC datasets, we haven't tried other batch sizes and just follow Fast R-CNN to set batch size to 2. For this PyTorch implementation, we set batch size to 4 because we found that batch size 4 obtains higher accuracy than other choices.

Thanks for sharing your experiments with me. I write a Pytorch implementation with batch size 1. A disappoint result is obtained with ROI Align. However, it works well with ROI Pooling. Probably, this is caused by different hyper-parameters (such as  batch size), or some other randomness.

No problem. Actually, many people have told me that ROI Align doesn't work for weakly supervised object detection.

No problem. Actually, many people have told me that ROI Align doesn't work for weakly supervised object detection.

Okay, thanks a lot anyway.


Day 339

Good morning! Here's your coding interview problem for today.
This problem was asked by Microsoft.
Given an array of numbers and a number k, determine if there are three entries in the array which add up to the specified number k. For example, given [20, 303, 3, 4, 25] and k = 49, return true as 20 + 4 + 25 = 49.

Appears to be exactly this classic problem: https://en.wikipedia.org/wiki/3SUM


[stevewhims: recommend closing] Update traversing-the-thread-list.md

Added "const qualifiers" in 2 places.
"string" is also called as "character constants", "string constant" and "anonymous string" in C++. This is because a "string" in the C++ standard has the "const qualifier". But the situation in C is slightly different. Since the "const keyword" did not exist in C until the "ANSI C 1989" standard, "string literals" dont have a "const qualifier" for such historical reasons. Hence "non-const string" in C is evaluated as "undefined behavior". Although the "printError" function has a "non-const" parameter - void printError(TCHAR* msg); -, the program string attempts to pass a "const" argument to this function. For example: "printError( TEXT("Thread32First") );" To eliminate the problem the "printError" function parameter must have the "const qualifier".
Also added double colon before the some function names to emphasize that they are part of Windows API.

Let's take a look at the "declaration" in the input part of the "printError()" function. After editing, the "uninitialized variable, array and wild pointer" are gone, the size of the "array" is replaced by the "MAX_PATH (256->MAX_PATH)" macro, which defines the maximum length value (currently 260) and is more efficient on my opinion. Which value is also supported by "lpBuffer and nSize - 64K bytes = 64000 bytes" parameters of "FormatMessage()" function.

Even if the sysMsg array would not be modified, this part is highly suboptimal and can be performed more optimally with  a single loop. You can test it without sysMsg array modification to be sure this loop is very non optimal. In the first "while loop", all "control characters" - [0 - 32) - except for "9 - \t (horizontal tab)" - "p - pointer" - are "pre- increment" and the following two ending with different characters depending on the version:

// after TCHAR sysMsg[MAX_PATH] = { '\0' }; and while( ( *p > 31 ) || ( *p == 9 ) ) version p: 000000A131EEEC04 *p: 13 <---\
NOTE: index sysMsg[50]: \r = 13 (cycle ends with this character)
// after TCHAR sysMsg[MAX_PATH] = { '\0' }; and 1st modification of the while(((*p > 31) && (*p != 46)) || (*p == 9)) version p: 000000FEDA0EECC2 *p: 46 <---\ after "while" until entering "do-while" loop
NOTE: index sysMsg[49]: . = 46 (cycle ends with this character)
Then, a new second do-while loop kicks in, which I think is more readable in the modified version -

while ((p >= sysMsg) && ((*p == '.') || (*p < 33))); --> while ((p >= sysMsg) && ((*p == 46) || (*p < 33))); The most interesting is the line of code where "post-decrement + indirection" operations are executed together: *p-- = 0; The sequence of operations performed by this code snippet can be found from this official source - https://en.cppreference.com/w/c/language/operator_precedence - we can learn. The post-decrement operation has a higher priority than the indirection (dereference). Moreover, since it is also true from the associativity point of view, we can group this piece of code like this: *(p--) = 0; The value of the expression "post-decrement" is the value of p before the "decrement" operation, but the value of p is also "decremented" at the same time. Actually "operator-- overloading" occurs during "post-decrement" - T T::operator--(int); ---> T operator--(T& a, int); - and in the first step, it creates a copy of the received p, then "decrements" the value of p, and finally from the "decrement" process in the first step returns the previously created copy. Then *(p--) "indirection (dereference)" is applied to these operations:

// after TCHAR sysMsg[MAX_PATH] = { '\0' }; and while( ( *p > 31 ) || ( *p == 9 ) ) version p: 000000A131EEEC04 *p: 13 <---\ when entering "do-while" loop, *(p--) = 0; before the line p: 000000A131EEEC02 *p: 46 <---\ "do-while" loop, after line - *(p--) = 0; p: 000000A131EEEC00 *p: 1099
// after TCHAR sysMsg[MAX_PATH] = { '\0' }; and 1st modification of the while(((*p > 31) && (*p != 46)) || (*p == 9)) version p: 000000FEDA0EECC2 *p: 46 <---\ when entering "do-while" loop, *(p--) = 0; before the line p: 000000FEDA0EECC0 *p: 1099 <---\ "do-while" loop, *(p--) = 0; after the line
In general, it is very inconvenient to run 2 loops to perform the cleaning process and it can be adjusted through a single loop. For this, exactly these code parts should be "refactored".

These lines were changed:
NULL parameters to nullptr in FormatMessage function

@Karl-Bridge-Microsoft can You give an attention to these commits also?

@Karl-Bridge-Microsoft - It's already approximately 2 month that you did not paying necessary attention to this and other 2 significant pr's for Microsoft documentation. It's not about some commas, dots, other punctuation marks and etc. in text of ducuments. All commits including this one are about code level errors and non-optimal solutions. This code snippet has the potential error. I wrote about it full enough and this program code contains non-optimized algorithm in "printError" function. As I mentioned in above comments I actually explained entire problem in code fragments, but despite this no any attentiveness from your side during long period (+-2 month).

@stevewhims, @TylerMSFT
I'm sorry for tagging and disturbing you all here, but I've not seen any another way in such as situation,- I only know you two. Why doesn't this person give the even the slightest attention to these comments and more importantly to commits (3 commits together)? In this case why this person is here? Is it not his work? Please, if you have a time, spend on these commits. Because the responsible person does not give an any attention for solving any of them. I've already encountered several times in demo codes, mini programs, etc. very serious errors and even non-working code snippets in the official Microsoft platform for which some of you are responsible. It's not problem. Problem is that people like me spend a lot of effort who's interested in solve some errors to enhance quality of examples in official platform for other learners and clarify are ignored by the lazybones like the @Karl-Bridge-Microsoft. This is very unmotivated activity from Microsoft. I still don't understand why such people work in these positions in company as Microsoft.

Thanks for this PR, @shalala66! In response, I've reviewed the topic, and I've tried out the code, and I've read all the points you make in the PR.
In reviewing the topic, I saw that the code example didn't compile (as published at the time). So I've published a fix for that. But please read on for reasons why I'm recommending that this particular PR be closed.
Now that the code example builds, runs, and functions as expected, I think that's the highest priority update that was needed for this topic. The other changes in this PR are about improving efficiency, and using modern and C++-specific idioms (for example, updating NULL to nullptr, and things like that). And I don't think those changes meet the bar, nor are great return-on-investment for this topic (which has very low page views).
I know that you put a lot of effort (and expertise) into this PR, and I appreciate that. I'm always tempted myself to make any segment of code more efficient. And that's appropriate for production code. But the focus of this topic is really only to show how to use the APIs. Showing how to use the APIs in a segment of code that's as efficient as possible is a worthy goal. But it's not a high priority one (considering the other work we have to do). One of your points is about improving code readability. And that's important. But I just don't think that this topic needs this much time and effort at this stage.
So I'd recommending that this particular PR be closed now. Other folks might disagree, and that's fine.
Thanks!
-Steve

@stevewhims, I didn't think You would solve the problem via this way. But this contribution is related with your name in official site. It's wrong to do this on my opinion. That's not why I spent so much effort. In this case add my name to contributor lists in 2 places at least. This is my right. Okay?

@stevewhims, I'm waiting for your comeback about the correction of mistake that you have provided as yours contribution instead of mine. Please, correct this mistake and add my name to contributors list in at least 2 places.

Hi, @shalala66. I confess (and apologize) that I hadn't given any thought to attribution (getting credit). I'm grateful to you for bringing this documentation to my attention; that's what led me to discover (and fix) the build issue. And thanks for mentioning attribution just now. I can see that that's important to you, so I'll definitely bear that in mind in future. But this GitHub issue is still open. Until it's either merged or closed, it's probably premature to worry too much about attribution.

Hi, @stevewhims.
Excuse me again to attract you to this problem in this repo. I have 2 interesting questions for you.
First, closing this will resolve the present problem? If yes, I'm ready to close. No problem.
Second, why this guy - @Karl-Bridge-Microsoft - does not merge this pull rrequest? Is he alive? Or maybe he has some personal problems?
I got an attention that here I talk with you whom does not related to these commits and you wanna try to solve current trouble to help, but this guy behaves ownself like if he has nothing to do with this topic. I really don't understand what is going on?

I can let you know that merging the PR will apply the PR's changes to the topic. Closing the PR will not apply the PR's changes to the topic. Here, "closing" really means "abandoning" or "canceling".

Is it not injustice? Okay, let it be. In this case I have no other way except asking you to help me or providing some works in this side to add my name to contributors list in 2 places at least.

Hi @shalala66 - thanks for your suggestions and your patience. As @stevewhims states, he's fixed the code snippets so they build cleanly and published those updates. We both agree that is sufficient for these ref topics. Please note that we have limited resources, a finite amount of time, and thousands of topics to maintain, which requires us to prioritize based on significance, schedule, and workload.
As it stands, we've noted your suggestions and will circle back should time permit.
Closing PR as topics have been updated in a private PR.

That is good news. @stevewhims, @Karl-Bridge-Microsoft, I just want to you is to add my name to contributor lists in the places where the changes were attempted. That's it.


Coverage analysis isn't working correctly when different versions of stryker-api are mixed-and-matched

Summary
Given the following directory structure:
node_modules/
└── @stryker-mutator/
    ├── core
    │     └── node_modules/@stryker-mutator/api
    └── typescript
          └── node_modules/@stryker-mutator/api

When running stryker run here, the coverage analysis perTest is broken.
Stryker config
module.exports = function(config){
  config.set({
    coverageAnalysis: 'perTest'
  });
}

Details
For some time now, @stryker-mutator/api is a direct dependency for core as well es all other plugins. The idea is that, since the api doesn't have direct side effects, it is OK to depend on it and it would be OK if the version used by a plugin is different from the core.
The api does have some class implementations, in particular File.ts. Instances of this class are serialized and deserialized using surrial.
However, this can break serialization/deserialization. The transpiler new's it's own File instances (for example, here). The File constructor class used by the plugin is unrelated to the one used in core. This makes it so it is NOT serialized as an instance of File by surrial. Later, when stryker tries to compare file content using the textContent property it never notices the changes, since it will be comparing undefined === undefined.
Workaround
The (only) workaround is to make sure that @stryker-mutator/api is hoisted to the top level of your node_modules. This should be the case when your stryker version is in sync.
node_modules/
└── @stryker-mutator/
    ├── core
    ├── typescript
    └── api

This wasn't fixed after all, because of https://github.com/nicojs/node-surrial/issues/9


Rotation Module

First attempt at a rotation module. Flow starts at a portal,
which is a list of all the rotation dinners. Each dinner has a table
of all the prefrosh present at that dinner. Each prefrosh page has
their picture and space to add comments/votes. TODO is to add more
support for move up / move down, changing buckets, etc.
Adds two new tables to the schema: a table for prefrosh and all
their associated attributes (images, votes, etc), and a table
for tracking move up/down history.

Also just a side note, but it's good to make many incremental commits that each do one specific thing rather than a single massive commit with everything.


no default value causes remote jobs to fail

not sure how out-of-the-box this is, but i am using this to have an "optional" file to pass in (a user can pass in a file, or all the parameters can be filled out when the job is executed).  i use this mainly for an remote jenkins server to call this job (in this way, the calling jenkins server does not pass in a base64file)
in essence, in my job, the base64file is optional to pass in.  and this works fine when calling it locally from the GUI (I don't have to choose a file).  however, when the job is called via the remote jenkins server (remoteTrigger) it seems that the job is (in essence) requiring the file, as the jenkins server logs show:
2021-02-15 08:02:22.540+0000 [id=1546]	WARNING	h.i.i.InstallUncaughtExceptionHandler#handleException: Caught unhandled exception with ID 9a702ccb-ee2e-4156-8cc6-a60f0a393d72
org.apache.commons.fileupload.FileUploadBase$InvalidContentTypeException: the request doesn't contain a multipart/form-data or multipart/mixed stream, content type header is application/x-www-form-urlencoded

this same job works fine being called from the remoteTrigger if the base64file parameter isn't part of the config.
i am unsure if this is a jenkins issue or this plugin issue, but figured i would start here since the job will in fact launch fine w/o this file-parameter.

Not sure what remoteTrigger is.

it's a pipeline command that allows you to trigger a remote jenkins job (a different jenkins server).
https://plugins.jenkins.io/Parameterized-Remote-Trigger/

Never used that plugin. Also the issue description does not include a stack trace, or any indication of exactly how the upstream and downstream jobs are configured (such as Pipeline script text). Please provide complete, minimal steps to reproduce from scratch.


Enclose text with p tag

Hello @sdmcraft we have discussed about this earlier. Can you please make sure to enclose the text with p tags when there is only one paragraph in the word document? This would simplify prevent us adding a lot of css for no reasons. Thank you.
https://main--sunstar--hlxsites.hlx.page/about/chairman-interview

@rrrragas , can you please help with this one?


scroll_bar: Simplify module.

The content which is scrollable is moved left by the width of the
scrollbar when scrollbar is visible. The navbar, floating recipient bar
and composebox doesn't move. We reduce their width by scrollbar width
to adjust for the reduced width of the scrollable content.
Since floating recipient bar is center aligned (with margin: 0 auto)
we also have to move left by half the scrollbar width.
Group css classes having the same value being assigned together. This
makes the code easier to understand.

This seems like an improvement assuming it works in all cases. But #16411 would be a better solution if someone could finish it, since that removes our dependence on the scrollbar width completely.

Looks like an interesting idea. This approach is not experimental, unlike #16411 since I am just reversing the previously used approach. So, instead of adjusting the scrollable container, I adjusted the fixed containers. I will try to take a look at #16411 next week.

This looks plausible; it's an option to test-deploy this and ask for careful QA if we feel it's likely to work for all OSes.  But maybe it's worth your looking at #16411 first, since that'd be a much nicer endpoint if we're going to do such a QA process.
@ryanreh99 FYI if you have time to update #16411 and/or help test a revision to it, that'd be very helpful.

I've test-deployed this on chat.zulip.org.

Should this come with a change to this block comment in zulip.css?
.app-main,
.header-main {
    width: 100%;
    /* TODO: This 1400px is wrong, but it's hard to do better.  On
       browsers with a nonzero default scrollbar width (i.e. not
       macOS), we actually want a max-width of 1400px+the width of the
       scrollbar, which is done as an override in
       static/js/scroll_bar.js.

       And with the fluid_layout_width setting, we don't want a
       max-width at all.  The consequence is that if you reload a
       Zulip window, there's a brief flash where the content is
       misplaced before the JS code can fix it. */
    max-width: 1400px;
    min-width: 950px;
    margin: 0 auto;
    padding: 0;
    position: relative;
    background-color: hsl(0, 0%, 100%);
}

Merged, thanks @amanagr!