Fix for Xcode 12.0 beta 2

Hi, I tried to build the library but i get the error below:

[x] Undefined symbols for architecture armv7
Symbol: type metadata for Swift._StringObject.Variant
Referenced from: outlined init with take of Swift._StringObject.Variant in Identifier.o
[x] ld: symbol(s) not found for architecture armv7
[x] clang: error: linker command failed with exit code 1 (use -v to see invocation)

and this pull request is fixing it.

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   93.68%   93.68%
=======================================
  Files          12       12
  Lines         903      903
=======================================
  Hits          846      846
  Misses         57       57

Impacted Files
Coverage Δ

Sources/Identifier.swift
98.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85a621...b2b540e. Read the comment docs.

@NosovPavel Thank you so much for putting this together!
LGTM


Perform sanity check SSH commands on remote host

Perform sanity check SSH commands on remote host to verify:

File transfer and location
Internet connectivity
/hold

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/close


Windows docs for changing container storage size have moved

The instructions on https://docs.adamrehn.com/ue4-docker/configuration/configuring-windows-10#step-4-manually-configure-docker-daemon-settings currently point to https://docs.microsoft.com/en-us/visualstudio/install/build-tools-container#step-4-expand-maximum-container-disk-size but the relevant instructions now live at https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/container-storage#storage-limits
Also, it might be worth mentioning in the instructions that one must restart Docker Desktop after applying them, as the MS instructions don't mention that, and ue4-docker info cannot recognise "forgot to restart Docker Desktop".

Thanks for reporting the broken link! I've just updated the docs now.


fix cris-npp outage of 2021; add GEOS-IT support (zero-diff)

Fix for cris-npp shutoff/on 2021 case.

This is zero-diff for cases before Oct 2021

Thanks for checking Tom.

I wouldn't say that this will "fix" the issue with CrIS-FSR NPP as your solution also will likely require a transfusion of bias coefficients.

Thanks Jing

For configuration file(s) for a specific system configuration, for example MERRA2 or in this case GEOSIT, I have always been wondering. Would it be easier for maintenance by adding a branch than adding a subdirectory? For example, we can have branches in parallel to develop, as parallel_develop/MERRA2_config, parallel_develop/GEOSIT_config, etc., where _config suggests that only a small collection of configuration files are (expected to be) different.
Just a thought.

In the case of MERRA2 the decision to use the regular DAS configuration or the MERRA2 configuration is done when the user runs 'fvsetup'.  It may be too much of an inconvenience to have the user need to check out a new branch and possibly rebuild if they wish to switch between running a historical run versus running near real time.  For the GEOSIT I think it is configured appropriately for a 3-D Var experiment and there may be some interest in being able to switch to that configuration via 'fvsetup' as well rather than having a separate build.

In the case of MERRA2 the decision to use the regular DAS configuration or the MERRA2 configuration is done when the user runs 'fvsetup'. It may be too much of an inconvenience to have the user need to check out a new branch and possibly rebuild if they wish to switch between running a historical run versus running near real time. ...

Indeed, if switching between configs after a build is a requirement, create another config object would be a reasonable solution for the problem.  I agree.


HADOOP-18925. S3A: option "fs.s3a.optimized.copy.from.local.enabled" to control CopyFromLocalOperation

Adds a new option to enable or disable the
optimized CopyFromLocalOperation upload operation
when copyFromLocalFile() is invoked.
When false the superclass implementation is used; duration statistics are still collected, though audit span entries in logs will be for the individual fs operations, not the overall operation.

single audit span used for all store operations in the optimized version
option is a path capability so can be probed for. will add this to storediag.

How was this patch tested?

ITestS3ACopyFromLocalFile parameterized to run with/without option.
s3 london  -Dparallel-tests -DtestsThreadCount=10 -Dscale -Dprefetch

For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 11s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 12s

trunk passed

+1 :green_heart:
shadedclient
33m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
32m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 53s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

126m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6163

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux a054c7ed6c49 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 46bf12bd7028555017533e60a945b483bc496904

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/1/testReport/

Max. process+thread count
716 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
19m  6s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
0m 26s
/branch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-aws in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 30s

trunk passed

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 47s

trunk passed

-1 :x:
shadedclient
25m 50s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 23s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)

+1 :green_heart:
mvnsite
0m 27s

the patch passed

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
0m 23s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
spotbugs
0m 24s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
shadedclient
31m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 23s

hadoop-aws in the patch passed.

-1 :x:
asflicense
0m 28s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

87m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6163

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux df9e1fe0ac45 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f4dcedffdb5c73e22efb2c75b1fcf9539ce74bcc

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/2/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

There are conflicts in the PR

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 39s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  8s

trunk passed

+1 :green_heart:
shadedclient
32m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  5s

the patch passed

+1 :green_heart:
shadedclient
32m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
2m 47s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

126m 12s

Reason
Tests

Failed junit tests
hadoop.fs.s3a.impl.TestErrorTranslation

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6163

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 2bf462ce5a4e 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6e7c97550af0c9f003faa8f1d5a10e550ab00103

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/3/testReport/

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 31s

trunk passed

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 14s

trunk passed

+1 :green_heart:
shadedclient
33m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
33m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
2m 52s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

129m 55s

Reason
Tests

Failed junit tests
hadoop.fs.s3a.impl.TestErrorTranslation

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6163

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 9d78d335a552 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3084bc181b9cc94fd5f860da8913eb7060249890

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/4/testReport/

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

test failure is unrelated and will go away on a rebase

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 48s

trunk passed

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 56s

trunk passed

+1 :green_heart:
shadedclient
28m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 46s

the patch passed

+1 :green_heart:
shadedclient
24m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 35s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

101m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6163/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6163

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 65b862a22b81 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3084bc181b9cc94fd5f860da8913eb7060249890

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6163/1/testReport/

Max. process+thread count
694 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6163/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

rebased and testing with ITestS3ACopyFromLocalFile against s3 london; all good

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
45m  5s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  6s

trunk passed

+1 :green_heart:
shadedclient
32m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
32m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 50s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

136m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6163

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 5f2d92d08f77 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 757207bb23a87f1b18695ba5d37ec0d80baaa07e

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/5/testReport/

Max. process+thread count
564 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6163/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ahmarsuhail could i get a quick look at this? thanks

thanks. I'll backport it as needed.


Revert "Add support for paste formatters"

Reverts guardian/scribe#319

Reverting this because it's failing a test on Chrome. We had a brief look at the issue and it seems that Chrome can't insert the data in the custom event. We may look into this more in the future but it seems very close. And of course, it works fine in Firefox!


Show download SBOM command in pipeline run details page

Fixes

https://issues.redhat.com/browse/HAC-3425

Description

Added a new section to show download SBOM command in pipeline run details page.

Type of change

[x] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

https://user-images.githubusercontent.com/6041994/224770077-d2f4d508-23b8-4f1b-8669-27825cd21e65.mov
Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/lgtm

/retest


Cant join discord "unable to accept invite"

Hello guys, can  you please the discord server admins give me access  l`m getting unable  to access for some reasons or verify my user? niro_2020, l have already login in before with no problems please note l can login to other discord servers without any issue
Many Thanks

Hey @bilallamal07 where did you click on the link, it might be an old like I forgot to update, this one should work: Discord

Hello Joaomdmoura
Sorry to disturb you l`m still experiencing this login issue saying enable
to accept the invite
l have tried the vpn and without vpn, bear in mind the other discord server
works with a vpn
with no issues, could please check with admin
Kindest Regards
Bilal
On Fri, 2 Feb 2024 at 16:36, João Moura @.***> wrote:

Hey @bilallamal07 https://github.com/bilallamal07 where did you click
on the link, it might be an old like I forgot to update, this one should
work: Discord https://discord.com/invite/X4JWnZnxPb
—
Reply to this email directly, view it on GitHub
https://github.com/joaomdmoura/crewAI/issues/209#issuecomment-1924236487,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A777DEXDE3XNQEJYXEIUMKTYRUIY3AVCNFSM6AAAAABCW6DTOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGIZTMNBYG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Still no joy   ### Enable to accept invite


Add license to setup.cfg.

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   16.48%   16.48%
=======================================
  Files          49       49
  Lines        2336     2336
  Branches      255      255
=======================================
  Hits          385      385
  Misses       1931     1931
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818f008...fc1fe55. Read the comment docs.


Try using background when backgroundColor is null

This PR enables using background widget for the 1st render frame, when backgroundColor is not set. It allows to implement a smoother transition between native mobile Splash screen and Flutter application UI.
Use case: both native Splash screen and application UI background uses gradient instead of a solid color fill.
Related to https://github.com/Codelessly/ResponsiveFramework/commit/c55ab5c50ff0deeec2fc633d19a159a8f0e394eb, https://github.com/Codelessly/ResponsiveFramework/commit/38888021e01ba987d18d48ab16cba8b3cb148294 and https://github.com/Codelessly/ResponsiveFramework/issues/39

Thank you for the PR and the test 😄
Let me test and get this published today 🤞 🚀

Thanks again for the PR, will get around to testing soon!

Looking good, merged!

Published in v0.1.6!


Adds my fork url to the start of the url

I get 'https://github.com/garvankeeley/firefox-ios
https://github.com/mozilla-mobile/firefox-ios/blob/f09af843f5490f58211a3b71d4ac874e92c26b39/Client/Frontend/UserContent/UserScripts/MainFrame/AtDocumentEnd/FindInPage.js%23L66-L66'
when this would be the working URL:
'https://github.com/mozilla-mobile/firefox-ios/blob/f09af843f5490f58211a3b71d4ac874e92c26b39/Client/Frontend/UserContent/UserScripts/MainFrame/AtDocumentEnd/FindInPage.js%23L66-L66'
With one other strange problem, the encoded # as  %23 doesn't but work # does, which I think might be a Firefox bug, because the URL encoding looks fine to me.
This tool is awesome BTW! I don't mind quickly editing the URL to work, it is still way faster than the fully manual method.

I just add a tail -1 after the fetch+awk step to grab my upstream remote.


Updates to Filter Analytics

Updates to Filter Analytics to only send values on form submission. Also, modified the category to be Page Interaction.
Changes

Modifed cfgov/unprocessed/js/modules/Analytics.js to add function which returned a dataLayer option.
Modified cfgov/unprocessed/js/organisms/FilterableListControls.js to update analytics workflow.

Testing

Visit the Blog page, enter in some criteria via the filter. The page should function as normal.

Review

@@kelleyholden
@cfpb/cfgov-frontends
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Tested blog page filtering and it works 👍

Can this be merged?


Memory leak on iOS

Following up on the closed issue https://github.com/react-native-community/react-native-netinfo/issues/325
This does seem to be an issue with memory leaks, which occur on app start.
Simple reproduction is init a new RN app ad add
React.useEffect(() => {
    const unsubscribe = NetInfo.addEventListener(() => {});
    return () => unsubscribe();
  }, []);

Environment
System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz
    Memory: 1.20 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.16.2 - ~/.nvm/versions/node/v12.16.2/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.4 - ~/.nvm/versions/node/v12.16.2/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /Users/oliverwinter/.rvm/gems/ruby-2.6.1/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>14223
    Xcode: 12.0.1/12A7300 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_242 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Platforms
Memory leaks were found in iOS on device iPhone 11 pro 14.0.1
Versions

"@react-native-community/netinfo": "5.9.7",
Description

Reproducible Demo
add effect in new app and profile on device to see leaks on app start

I can confirm issue also exists when using the useNetInfo hook
const connected = useNetInfo();

Have this problem too.

Have this problem too.

I am also seeing this as of version 6.0.0

Anyone have a PR to fix it? That would help

I'm not sure I'm reading this correctly, but:
ios/RNCNetInfo.m
- (instancetype)init
{
  self = [super init];
  if (self) {
    _connectionStateWatcher = [[RNCConnectionStateWatcher alloc] initWithDelegate:self];
  }
  return self;
}

That's the only place the identifier _connectionStateWatcher appears in the library, and I don't find anything relevant-looking outside the library in a Google search. Is this thing being used, and does it need teardown code after use? Or should it not be set in the first place?

@mikehardy finally got some time to look into this and it is noted in the README, but still sets folks up for failure as most RN devs would expect more setup steps for native code or for it to be build into the library.
That being the link here to the Discussion section of the deprecated CNCopyCurrentNetworkInfo.  I was about to put in a PR but not sure if it's appropriate as CNCopyCurrentNetworkInfo has other possibilities where it should work based off of that.  My PR being to ensure we have location permissions to avoid the memory leak that not having them apparently causes.
What would be your advice on how to proceed or can you tag someone that can help out?  I/someone could:

Make the docs more explicit (you must get location permission, etc, here's how).  The current copy requires a lot of a project outside of this library & imo it'd be better self contained as much as possible.  Also, I didn't even look at the writeup on the SSID prop and still got a memory leak from it.
I could put in the following change in the image.  This would fix probably the biggest cases of this, but in its current iteration cause others.
Put in the PR & see how we could enhance.  CNCopyCurrentNetworkInfo is deprecated for iOS 13+ & this library needs to implement the fetchCurrentWithCompletionHandler and again the following code probably isn't complete.  Notably it takes a network state change after permissions are set on first run to then get SSID and the other possibilities for CNCopyCurrentNetworkInfo to function properly.

@mikehardy finally got some time to look into this and it is noted in the README, but still sets folks up for failure...

I didn't directly say this, but I profiled with and with out the above code and could directly see an effect on the memory leak.

@matt-oakes ☝?  With the pettiness shown here I am trying to make sure I'm not being ignored...

Not sure about pettiness, I do my best to just state facts and I'm sorry if you feel my response is petty - not the intention, with regard to ignored, I've simply been really really busy and haven't had time. I've got this one queued though, a memory leak if demonstrated is a really big deal and I'd love to integrate any solution you've found

This response is taking longer because it now contains real work which requires real work to process :sweat_smile: - however, with the real work you've done I think it contains all the information required for anyone to verify it, which is a force multiplier in open source, whereas the initial fuzz-busting of "this doesn't have the info" is something I try to do really quickly just to make sure issues / reports meet minimum standards

...if demonstrated is a really big deal...

The leak was demonstrated by the initial writeup.  You can see that CNCopyCurrentNetworkInfo is producing the leak & that it is from RNCNetInfo.

...I'd love to integrate any solution you've found

Do you have any input for the above writeup?  I can just put in the PR & let it ride there if that'd be more useful.  Clearly the library is not following the requirements for CNCopyCurrentNetworkInfo & putting that on the user.  There are many resources online talking about this specifically causing leaks.

...with regard to ignored...

Apologies, with the speed and attitude of other replies I thought of the eventuality that you were simply going "ugh... just put in a PR, why are you commenting 🙄" or something of the like.  Facts & how they are presented are not without meaning to others despite your intentions and I only have that to judge you from.

All fair, my presentation is certainly brief
I am not thinking "ugh just put in a PR", but I am thinking in general for all the repos I manage "please please someone just put in a PR and the associated testing across the compatibility matrix we support and documentation + release notes as needed so this is solved"
The absence of a PR means that work needs to be done and it all just takes time unfortunately

:tada: This issue has been resolved in version 7.1.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Replace map with forEach

As it seems the desired behaviour is to just iterate through all elements, then consider using forEach or a for-of loop instead.

thanks!


Doesn't re-run actions when reducer is hot-reloaded

When a reducer is hot-reloaded in order to see the result of the change I have to send some kind of dummy action in order for devtools to re-run all actions with the new changes.

This doesn't happen in the examples, so please provide a project reproducing the problem.


Improve transaction state management for custom networks

Description
This development only affects the mobile app since the extension has its own Transaction Controller
Improvement on how we process transaction state for custom networks (e.g. BSC) by updating the Transaction Controller. The extension currently has a Transaction State Controller to handle user scenarios, something we lack.
Use Cases

On transaction history we're currently using the gas values that the user sent the transaction with, but in many cases the actual gas spent was less so we are showing misleading information.
Wrong transaction state: Showing failed transaction, when the tx was successful.
Transactions get stuck in the "Submitted" status.

I have some concerns about Infura rate limit:

How do we handle this at app and/or controllers level?
Which is the current rate limit?
Extension and mobile share the same project ID?

Should the polling interval be updated? We are using 5 secs intervals but according to Infura's docs it should be 15 secs.

Don't poll Infura in a tight loop. New blocks come roughly every 15 seconds, so requesting new data at a faster rate usually doesn't make sense. Consider using eth_subscribe to be notified when new blocks are available.

this.defaultConfig = {
    interval: 5000,
    txHistoryLimit: 40,
};

Extension and mobile share the same project ID?

Each project uses a separate project ID. The project IDs don't  have a rate limit - it's rate limited by IP instead.

Should the polling interval be updated? We are using 5 secs intervals but according to Infura's docs it should be 15 secs.

On the extension we poll for new blocks using eth-block-tracker rather than polling for the status of every single transaction in a loop. It's far cheaper to check for a new block than it is to check for the status of a transaction (especially if there are many pending at once, which may not be possible on mobile right now but is commonplace on the extension). So that might be worth considering here as well.
We poll on the extension every 10 seconds at the moment, but 15 seems like a good choice as well.


Allow creating the VM with utmctl

Hey!
There currently exists a workaround to create the VM following these steps: https://blog.vkhitrin.com/creating-a-utm-virtual-machine-from-cli/ but it's very very cumbersome.
Would it be possible to extend the utmctl and add subcommand create which would take the ISO file and few flags?
I'm most interested in Linux virtualization with the Enable Rosetta (x86_64 Emulation) option at this case because it's the best way to cross-compile x86_64-linux from Apple silicon machines at the moment.

+1 for this feature request.
Given the amount of configuration needed for VM. It would be better to split this into utmctl vm create to create VM instance and then utmctl vm edit to edit config details.
Side note: May I know why are you referring to such a hard , convoluted and complex route to create VM using cli, when a simple recommended way exists.
The approach in the blog you shared, uses

uuidgen
PlistBuddy
swift
hdiutil

You can do the same using Apple Script and single osa command.
Check out my Packer plugin scripts where I create and configure VM with simple script

Create VM script
Configure VM script

Side note: May I know why are you referring to such a hard , convoluted and complex route to create VM using cli, when a simple recommended way exists.

This was the only way I was aware. The applescript you linked was much more cleaner indeed 👍


Some Meal Boli imported as Carb Corrections

Since #11, carb records retrieved from diasend are treated as carb corrections, if they are not preceeded by a bolus record.
The issue here is that due to the polling loop, the result set retrieved from diasend in one run might include the carbs, but not the preceeding bolus (which also would mean the previous run contained the bolus but not the carbs). In essence we then end up with a Meal bolus without carbs and a carb correction (without bolus).
One way to mitigate this would be to decouple the polling loop for CGM values from the polling loop for treatments and wait for a carb record if a bolus with programmed_meal is received.

The polling loop right now, only checks the glucose values. It always starts requesting data from diasend starting at the last received glucose value. Since the treatments (carbs or boli) can come after that last glucose value (but still within the api response), we might process those events doubled.

This is the opposite problem of #7. Either we get the bolus record for a meal but the carbs are missing in the API response or the carbs are there but the bolus is not. This can happen if the data is requested exactly between the two records (since bolus record and corresponding carbs are usually ~1 minute apart).
If the bridge would keep bolus records in some kind of queue in case no carb record has been delivered yet, it could combine that record with the next iteration. so that we don't get a Meal Bolus and a Carb Correction.
Additionally, currently we take the time of the meal bolus for the respective treatment within nightscout. And based on that time, we start querying for the next records on diasend (i.e. the next api response will start 1ms after the bolus treatment). Within those next records, we'll then again get the carb correction record and since it comes standalone (no preceeding meal bolus), it will be imported (again!) into nightscout. So an easy fix would already be to ensure the carb record is not included again in the next api response by beginning the next api response after the end of the current one (and not after the last bolus / glucose value)

addressed by #13


Zone interpolation function

function to generate a zone from the world seeds

look into polynomial interpolation of 5 points


Hot Reloading in Existing Server

Is this a bug report?
No, this is question. I have a scenario where in my development environment I'd like to utilize hot reloading, but I need to do so in a local web server that is already up and running. Due to the nature of the app I can't run the react code in an isolated web server.
Is it be possible to do so? Up until now I have been running the build command, but that requires manual steps and is not ideal.

You can do it the other way around: run the React server, and use the proxy feature (documented in the User Guide) to proxy API requests to your server. Other ways of doing this are not currently supported.


Allow image turning with arrow keys

allow users to use keyboard arrow keys to control image turning like pixiv

LGTM


feat: Validation for JSON models

Description
Merges the main branch into the modular models feature branch.
It then fixes an issue that arose due to an addition in the modular models work where we threw early, when realistically we probably shouldn't have, and a related issue to that where if we do not have a symbol (i.e. missing schema) then when we are calculating/finding line and column numbers the findIndex/search functions could return -1 and we would then have 0 based line numbers, or NaN when we have attempted to add onto these values.
References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Some minor lint issues in go and js


img-responsive and Firefox 39.0

Firefox cannot handle properly .img-responsive class for the thumbnails, it ignores the default max-width property and stretches out the image within the .thumbnail container if the image is wider than the container itself. Default settings for the .img-responsive class:
.img-responsive(@display: block) {
  display: @display;
  max-width: 100%; // Part 1: Set a maximum relative to the parent
  height: auto; // Part 2: Scale the height according to the width, otherwise you get stretching
}

This class is inherited by .thumbnail class for all the images:
.thumbnail {
  ...
  > img,
  a > img {
    &:extend(.img-responsive);
    ...
}

I'm using sample code from http://getbootstrap.com/components/#thumbnails to display the thumbnails.
I've tried to set "width: 100%" to the .img-responsive and it works fine, until I've figured it out all the images not within the .thumbnail class container are stretched out.
The solution that works for Firefox for Windows and Android is to add "width: 100%" to the:
.thumbnail {
  ...
  > img,
  a > img {
    &:extend(.img-responsive);
    width: 100%;
    ...
}

@PELock can you post a JSBin demonstrating the problem and state what operating system you are using. I don't see any issues on Firefox 39 at the section you mentioned.

Odd, I just ran into this. A large image in the grid wasn't resized until I added width: 100%.
Firefox 42.0a2 (2015-08-24) developer edition.

@lookfirst Screenshot?

@cvrebert
FF with width: 100%: http://take.ms/eBtka
FF without width 100%: http://take.ms/dxiQ6 (broken)
Chrome (without width 100%): http://take.ms/clkL7

BS 3.3.5

@lookfirst We need a JS Bin or other simplified live example of the problem in order to be able to investigate further.


archive templates

i am trying to make the blade vie tpl files as easy to use as possible for designers. I really like the way that the controller allows us to use a variable to call a function, and trait work really well for partials. however i could do with a bit of guidance on how to use the archive comtrollers/views, like archive.php or even archive-news_article.php or even index.php.i
so far i have this -
src/controllers/archive.php
public function posts(){
    global $posts;
    $posts2 = null;
    $x = 0;
    foreach ($posts as $p){
        $post_excerpt = substr(strip_tags($p->post_content, '

'), 0, 250);
        $post_excerpt .= '' . '...read more';
        $p->post_excerpt = $post_excerpt;
        $posts2[$x] = (array) $p;
        $x++;
    }
    return (array) $posts2;
}

archive.blade.php
@foreach($posts as $post)
@include ('partials.content-'.($post->post_type !== 'post' ? $post->post_type : get_post_format()), $post)
@endforeach
i am passing the $post value to the include partial statement
in content-program.blade.php to get the custom excerpt, i have to use
{!! $post['post_excerpt'] !!}
i would like to use
{!! $post_excerpt !!}
how can i do this with a function post_excerpt to the variable returns each post excerpt in a loop for the partial template?
thanks

Disclaimer: I do not use this controller yet but I've been following it and will try it on my next project.
However I started using Sage with Blade recently and I took a similar approach as this plugin. I'll try explain how I did it by modifying your code. Maybe it can help you. And I will follow this thread for the "real" answer and hopefully learn about this plugin :)
In my opinion you shouldn't render any HTML in the controller.
src/controllers/the-post.php
add_action('the_post', function ($post_object) {
  if (!is_admin())
  {
    if (in_array(true, array(
      is_archive(),
    )))
    {
      $ID = $post_object->ID;
      $post_type = $post_object->post_type;

      $postData = setup_post_data($ID);

      sage('blade')->share('postData', $postData);
    }
  }
});

src/data/post-data.php
function setup_post_data($ID = 0)
{
  if (!$ID) return false;

  $postData = array();

  $post_type = get_post_type($ID);
  $postData['ID'] = $ID;
  $postData['post_excerpt'] = substr(strip_tags(get_post_field('the_content', $ID), '

'), 0, 250);
  $postData['permalink'] = get_permalink($ID);

  ...
  whatever more you need. Post type specific stuff.. custom fields... etc.
  ...

  return $postData;
}

Rendering
templates/archive.blade.php
@extends('layouts.base')

@section('content')
  @while (have_posts())
          @php(the_post())
          @include ('partials/archive-post')
  @endwhile
@endsection

extract in PHP takes every key in array and makes available as variable. I use this to set href to value of permalink. I didn't understand how you want to display the excerpt but $post_excerpt is available aswell since it's key of $postData array.
templates/partials/archive-post.blade.php
@if (isset($postData) && $postData)
  @php(extract($postData))

     ...read more

@endif

Sorry if this is off-topic to this plugin but I'm very excited after using blade templates with Sage and WordPress and is eager to learn more and try this plugin :)
Good luck!

@jajouka79 there are a few ways to accomplish this, I'm going to set up your use case locally and then will respond in full once I've tested.

If, all you are trying to do, is modify the excerpt, I would recommend you rather use a filter for the function https://codex.wordpress.org/Plugin_API/Filter_Reference/get_the_excerpt as per normal.
You could then just use archive.blade.php like this, for each post.
@while (have_posts()) @php(the_post())
    @php(the_excerpt())
@endwhile

No need for a controller method then.
If you would like to stick with your approach, by modifying the $post objects, you could use the following, returning the post data as an object (like WordPress does by default)
sec/controllers/Archive.php
public function posts()
{
    global $posts;
    foreach ($posts as $post) {
        $post->excerpt = substr(strip_tags($post->post_content, '

'), 0, 250) . '' . '...read more';
        $results[] = (object) $post;
    }
    return $results;
}

templates/archive.blade.php
@foreach($posts as $post)
{!! $post->excerpt !!}
@endforeach

Hey @jajouka79 @slackday
So I've updated Controller to 1.0.2 which I think addresses this use case much better.
You can now use public static function and reference from within the Blade template.
src/controllers/Archive.php
<?php

namespace App;

use Sober\Controller\Controller;

class Archive extends Controller
{
    public static function excerpt()
    {
       // you can handle computations within the function and return a value
        return get_post()->post_excerpt;
    }
}

templates/archive.php
@extends('layouts.base')

@section('content')
  @while (have_posts()) @php(the_post())
    {{ \App\Archive::excerpt() }}
  @endwhile
@endsection

Cool this is very clean! Good job

im not sure i explained myself clearly, i want a single word command for designers to use. excerpt was a bad example to use, it could be $authors_age. i already have $post['authors_age'] working. in the content partial, i wanted $authors_age to work

@jajouka79 the method name becomes the variable name.  You would need to then have a separate method for $authors_age.  I would recommend making the array an object and then simply using $post->authors_age

ive done this, i know that i need method authors_age(), I have tried this in the archive.php in a trait, i have tried passing variables to it, and I have tried passing the post data through from archive.blade.php in the include to content.blade.php, I can't get it to work

@jajouka79 I'll need to see the actual code to replicate.  Is it on GitHub?

there's no code to show other than whats in my original post. i have tried lots of code but nothing that works. in single and page templates designers can easily use a variable that calls the corresponding method e.g. $coach_age. but when they get to the list templates like archive.php or archive-coach.php they have to use $post->coach_age. if you have 10 designers all at different levels of ability it would be a lot easier and more consistent if they didn't have to do this. they would work only on the partials only so the content-blade.php partial (which shows the teaser on lost templates), I would like them to be able to use $coach_age.

@jajouka79, easiest is to go with @slackday recommendation.
Controller;
public function posts()
{
    global $posts;
    foreach ($posts as $post) {
        $post->post_excerpt = substr(strip_tags($post->post_content, '

'), 0, 250) . '' . '...read more';
        $results[] = (array) $post;
    }
    return $results;
}

Template;
@foreach($posts as $post)
    @php(extract($post))
    {!! $post_excerpt !!}
  @endforeach

You could also use $post->coach_age in single.php by modifying the $post object in the Single controller.
I think your use case may be out of scope for this plugin, as in a way, this relates more to the way WordPress handles loops.
If you're only giving designers access to the partials, the above method does work.
@foreach($posts as $post)
    @php(extract($post))
    @include ('partials.content-'.(get_post_type() !== 'post' ? get_post_type() : get_post_format()))
  @endforeach

You could now access $post_excerpt within the partial.

    @forelse($posts as $post)
        @php(extract($post))
        @php (extract($post['post_meta']))
        @include ('partials.content-'.(get_post_type() !== 'post' ? get_post_type() : get_post_format()))

    @empty

            {{ __('Sorry, no results were found.', 'sage') }}

    @endforelse

this makes the variables available in the partial, thanks

i have a lot of traits that work great for single / page templates, for eg, featured images, post classes, post meta. however i can't get them to work with archive templates. is there a way to pass a post id to the traits so i can use them with lists?

@jajouka79 you could use static functions within the trait.  I think that will be the only way to pass on the post id.


Allow user to change background of GUI

For example, transparent.

Download
https://www.mediafire.com/file/jc5ws0hujgycrp5/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Dark theme - color of text in threadTitle is black which makes it almost unreadable

Hi guys, there is a small issue with dark theme.
Text in thread title is black and because of it it's hard to read it :)
Html code snippet:
<span class="_3oh-" data-reactid=".<IP_ADDRESS>.$threadTitle.0.0">
<span data-reactid=".<IP_ADDRESS>.$threadTitle.0.0.0">User Name

This is fixed in the latest beta.
Please see https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/458


Add session contents for 05: Contributing to Unikraft

This PR contains the content for session 05.
The main task of this session is porting a new simple library to Unikraft: kdtree.

Having different instances of the Unikraft working directory for each work item seems to be prone to build errors in my case. I think it would be best to just include the basic files specific to the library only and the ones for app-kdtree. This applies for sol/ as well, I think it is better to just have a libs/ containing only kdtree and an apps/ containing only app-kdtree. The participant will know that $UK_WORKDIR is by default in ~/.unikraft/ from the first session. Maybe just inform them where to place the modified library/app sources instead.


Add header nav to whoweare, fixup i18n issues

Addresses https://github.com/findthemasks/findthemasks/issues/610

Refactored top nav rendering to its own module
i18n is actually not functioning on the "Who we are" page currently due to some outdated paths, fixed that up
Added navigation back to home page from "Who we are" by making the FTM span clickable.

@ywyw thanks for splitting these files apart! This will be super helpful. I just fixed a few errors and will merge

Thank you @ywyw !! Always great work from you --- ah. Nate just merged. Yay!
We have several new subpages which will all require this logic! Thank you for separating and fixing


Incorrect deleted status for asset holding

Summary
The API call /v2/accounts/FLUFMFGK4DTSTU4JROQQOJZXIBMALAVS2XEEQXLFYZRSUEVVQ5HSQXGM4Q on a MainNet Indexer 2.3.3 yields the following:
{
  "account": {
    "address": "FLUFMFGK4DTSTU4JROQQOJZXIBMALAVS2XEEQXLFYZRSUEVVQ5HSQXGM4Q",
    ...
    "assets": [
      ...
      {
        "amount": 0,
        "asset-id": 144871850,
        "creator": "",
        "deleted": false,
        "is-frozen": false,
        "opted-in-at-round": 12421358,
        "opted-out-at-round": 12424246
      },
      ...
    ],
    ...
}

The asset 144871850 was created by FLUFMFGK4DTSTU4JROQQOJZXIBMALAVS2XEEQXLFYZRSUEVVQ5HSQXGM4Q and subsequently deleted, so I would expected deleted to be true (and for the asset to not show up at all unless include-all is enabled).
I suspect there's something special about this specific account/asset, since the account WSJHNPJ6YCLX5K4GUMQ4ISPK3ABMS3AL3F6CSVQTCUI5F4I65PWEMCWT3M on TestNet also has an asset that is created and deleted, but indexer correctly reports its status.
Scope/Requirements
This should be investigated further.
Urgency/Relative Priority
Indexer is reporting an incorrect value.

@algojohnlee can we check this out if the newest indexer release (2.3.4) fixes this? We can close if so.

Yes, this will be fixed with the 2.3.4 release.


Cannot assign Blue effect with swift

i want to convert this line
[[MZFormSheetBackgroundWindow appearance] setBackgroundBlurEffect:YES];
[[MZFormSheetBackgroundWindow appearance] setBlurRadius:5.0];
[[MZFormSheetBackgroundWindow appearance] setBackgroundColor:[UIColor clearColor]];
to
MZFormSheetBackgroundWindow.appearance().setBackgroundBlurEffect();
but i got
'AnyObject' does not have a member named 'setBackgroundBlurEffect()'

MZFormSheetPresentationController was rewritten and build on iOS 8 API. You can still use MZFormSheetController if you want to support iOS5 >, but if you have deployment target set to iOS8 i recommed you to use MZFormSheetPresentationController. It don't use any tricky hacks to present form sheet as a UIWindow, it use native modalPresentationStyle UIModalPresentationOverFullScreen.


Allow whitelisting of a module/subpath

Hi, I have a use case:
// This module is whitelisted in a config
import 'some_module'

// This one won't be whitelisted and needs
// to be added explicitly to the whitelist
import 'some_module/subpath/to/some_file'

Is there some way to resolve this issue?

Thanks!
Do you think that adding glob/regex support to the whitelist will suffice?

Yeah, I think so, thank you!

Added support for regex in the whitelist, so you can define:
externals: [nodeExternals({
  whitelist: [/^some_module/]
})]

And it will white-list some_module and all some_module/subpaths from being bundled.
Let me know how that works for you.


feat: remove numtide devshell

github.com/numtide/devshell eliminates a lot of environmental variables that pkgs.mkShell creates in favor of constructing them from scratch, in addition providing a few helpers for creating commands and envs.
However, with removing this devshell helper we don't need to reconstruct more difficult environments such as those for macOS, as nixpkgs has greatly improved its darwin environments upstream and they work well with pkgs.mkShell (even using nix develop --ignore-environment). In addition, we don't need to use the abstracted way of doing the commands/envs that this extra dependency provides.
Checklist

[x] Commit sequence broadly makes sense and commits have useful messages.
[ ] New tests are added if needed and existing tests are updated.
[ ] Relevant logging and metrics added
[x] CI passes. See note on CI.
[ ] Any changes are noted in the changelog.md for affected crate
[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG Partner Chains developers to do this
for you.

LGTM but seems to be a conflict

Doesn't it?

Correct. I will revisit more useful discoverability but I don't think anyone relies on this right now.


Support for local M3U playlist http streams

Hi, trying out MA and it works great.
One question though, will local m3u with http streams be supported at some point? I have a premium DI.fm account and get a pls/m3u from them with premium streaming-links. MA finds the m3u, but its empty.

I moved this request to the discussions, thanks for filing.


koboldcpp: fix metal support

This PR adds the ggml-metal-merged.metal file into $out/bin when compiled with metal support - without this file accessible, attempting to load koboldcpp on aarch64-darwin with metal support fails
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 350307

x86_64-darwin

:white_check_mark: 1 package built:

koboldcpp

aarch64-darwin

:white_check_mark: 1 package built:

koboldcpp


Volume function doesnt work in VSX-824

Nor on vsx-1021k
But on/off works

I dont have a google home, so never tested that integration.  I assume there is just a needed modification to the device handler, Ill look into it.  Otherwise, can you get me the smartthings live log when you try to invoke that command?

Here's my live logs for on/off in Smartthings, the only commands Smartthings sees.
I can post live log of Smartthings volume control using app. if you like:
d0e5b1f8-f789-4c5c-80bb-e6c579b9f723  9:56:23 AM: debug update, request: params: [appId:d0e5b1f8-f789-4c5c-80bb-e6c579b9f723, param1:vsxreceiver, param2:5ca7d9dc-77ce-485b-a9ac-f54949b6a572, param3:power, param4:off, action:[GET:executeSmartAppGet, POST:executeSmartAppPost, PUT:executeSmartAppPut, DELETE:executeSmartAppDelete, OPTIONS:executeSmartAppOptions], controller:smartAppApi, id:5ca7d9dc-77ce-485b-a9ac-f54949b6a572, command:power, state:off], devices: [5ca7d9dc-77ce-485b-a9ac-f54949b6a572]
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:23 AM: debug update state, request: attribute: status state: paused
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:23 AM: debug update state, request: attribute: switch state: off
d0e5b1f8-f789-4c5c-80bb-e6c579b9f723  9:56:16 AM: debug update, request: params: [appId:d0e5b1f8-f789-4c5c-80bb-e6c579b9f723, param1:vsxreceiver, param2:5ca7d9dc-77ce-485b-a9ac-f54949b6a572, param3:power, param4:on, action:[GET:executeSmartAppGet, POST:executeSmartAppPost, PUT:executeSmartAppPut, DELETE:executeSmartAppDelete, OPTIONS:executeSmartAppOptions], controller:smartAppApi, id:5ca7d9dc-77ce-485b-a9ac-f54949b6a572, command:power, state:on], devices: [5ca7d9dc-77ce-485b-a9ac-f54949b6a572]
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:16 AM: debug update state, request: attribute: switch state: on
97c0a121-da18-4984-9f81-b07e3d002027  9:56:14 AM: debug Outgoing: [requestId:9163152330468395638, payload:[commands:[[ids:[5ca7d9dc-77ce-485b-a9ac-f54949b6a572], status:PENDING]]]]
97c0a121-da18-4984-9f81-b07e3d002027  9:56:14 AM: debug Turn on Pioneer Receiver
97c0a121-da18-4984-9f81-b07e3d002027  9:56:14 AM: debug Turn Pioneer Receiver on
97c0a121-da18-4984-9f81-b07e3d002027  9:56:14 AM: debug handleExecute()
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:14 AM: debug GET /pioneervsxcontrol/main/power/on&apiserverurl=https%3A%2F%2Fgraph.api.smartthings.com%3A443%2Fapi%2Fsmartapps%2Finstallations HTTP/1.1
Accept: /
User-Agent: Linux UPnP/1.0 SmartThings
HOST: C0A80108:1FA6
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:14 AM: debug 999
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:14 AM: debug convertIPtoHex:8102
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:14 AM: debug convertIPtoHex:<IP_ADDRESS>
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:14 AM: debug Request:'power/on'
5ca7d9dc-77ce-485b-a9ac-f54949b6a572  9:56:14 AM: debug turning on

after re-doing the whole process, volume button works.. Closing issue


Add a table_exists helper function for ClickHouse migrations

Good First Issue: Many migrations here re-implement the functionality to check if a table exists in ClickHouse. We can abstract that as a helper function and use that repeatedly across migrations.


Recommend homogenous nodes

It's somewhat common knowledge, internally, that CockroachDB does better when nodes are running across homogenous machines. We should document this recommendation, why and to what extent it's important, and the drawbacks of heterogeneous machines.

honestly, we should probably do some testing on the impact of heterogeneity on performance... we're going to have some in multi-cloud deployments.  But 100% agree we should recommend that the nodes be as similar as possible.

As a simple rule of thumb, a heterogenous N-node cluster can be expected to perform as if it were N copies of its slowest node. It's possible to exceed this with careful use of zone configs to ensure that hot data is constrained to the faster nodes, but this is basically uncharted territory.


update_reverseproxy_conf does not handle '%' in entry value correctly

In the playbook snippet below we try to set the request-log-format to a string that contains non-alphanumerical characters such as '{' '%':
- role: update_reverseproxy_conf
      update_reverseproxy_conf_reverseproxy_id: "{{ reverseproxy_instance_name }}"
      update_reverseproxy_conf_entries:
        - stanza_id: "logging"
          entry_id: "request-log-format"
          value_id: "TS:%{%Y-%m-%dT%H:%M:%S}t C:%a I:%A U:%{AZN_CRED_PRINCIPAL_NAME}C AL:%{AUTHENTICATION_LEVEL}C SI:%{tagvalue_session_index}C T:%d M:%m ST:%s B:%B F:%F URL:%U"

The error is
template error while templating string: Encountered unknown tag 'Y'.. String: TS:%{%Y-%m-%dT%H:%M:%S}t C:%a I:%A U:%{AZN_CRED_PRINCIPAL_NAME}C AL:%{AUTHENTICATION_LEVEL}C SI:%{tagvalue_session_index}C T:%d M:%m ST:%s B:%B F:%F URL:%U"

We have tried different ways to escape the string, none of them seems to work.
I was able to make it work with '!unsafe' directive when make the API call directly:
- name: update logging format
  isam:
      appliance: "{{ ISAM_M1_INTERFACE }}"
      password: "{{ ISAM_admin_pw }}"
      action: ibmsecurity.isam.web.reverse_proxy.configuration.entry.add
      isamapi:
          reverseproxy_id: "{{reverseproxy_id}}"
          stanza_id: "logging"
          entries: [[ 'request-log-format', !unsafe 'TS:%{%Y-%m-%dT%H:%M:%S}t C:%a I:%A U:%{AZN_CRED_PRINCIPAL_NAME}C AL:%{AUTHENTICATION_LEVEL}C SI:%{tagvalue_session_index}C T:%d M:%m ST:%s B:%B F:%F URL:%U' ]]

Note: the above API calls entry.add, not entry.update, it takes different input - JSON array entries vs entry_id and value_id
However, we were not able to use the roles to add/update/set the value with these special characters.

Python code works properly, looks like ansible tries to process the variable. Best is to use "!unsafe" directive.

Python code updated to encode URI for updating reverse proxy config files. Issues with Ansible parsing best handled by "!UNSAFE" directive.


Revert [Explicit Module Builds] Serialize the inter-module dependenc…  … …y graph as incremental build state"

It is causing Swift CI failures on earlyswiftdriver.

@swift-ci test

Thanks for being proactive on this one.


New package: Microsoft.Office.SubjectInterfacePackages version 16.0.16507.43425

Pull request has been created with komac v2.2.1 :rocket:
Resolves: https://github.com/microsoft/winget-pkgs/issues/152520
Microsoft Reviewers: Open in CodeFlow

Hi @vikingnope,
This package has an unusual install flow:

Portable exe is actually installer file - running it prompts for license agreement:

Then an installer location:

The installer switch /? gave:

After that installer completes, the installed EXE has a dependency:

The outer install is okay currently. The /quiet switch performs the nested install without user interaction (/passive leaves a messagebox to click "OK"). And the nested installer needs a Custom switch with /extract:C:\path\to\extraction\location, or the installer will silently fail (or maybe install to an unknown location?)

Should this have a different or more clear PackageIdentifier? My brain expands the acronym "SIP" into "Session Initiation Protocol" so I keep thinking this is a VOIP function for MS Office.

This package has an unusual install flow:

It's also worth noting that this package doesn't write any ARP Entries, so WinGet won't be able to determine if it is installed.

And the nested installer needs a Custom switch with /extract:C:\path\to\extraction\location

The InstallLocation switch could be added and InstallLocationRequired: true can be set in the manifest

Automatic Validation ended with:

Executable C:\WinGetInstallerRoot\Microsoft.Office.SubjectInterfacePackages\offclearsig.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean Dependency on Microsoft.VCRedist.2015+.x64 (or .x86).
(Automated response - build 880.)

I think it was the wrong package, I think it should be correct now.

@stephengillie, can you recheck this please?

This is unchanged.

This updated manifest doesn't seem to install the dependency.


🐛 Bug Report:

👟 Reproduction steps
Just create a new account in Signup
👍 Expected behavior
Signing up should go through with new credentials
👎 Actual Behavior
Getting error:

🎲 Appwrite version
Different version (specify in environment)
💻 Operating system
Linux
🧱 Your Environment
This is the demo app
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

I'm getting cors issues on localhost, not sure if that's related.
or URL constructor: localhost/api/v1/account is not a valid URL.

I'm getting cors issues on localhost, not sure if that's related. or URL constructor: localhost/api/v1/account is not a valid URL. Any clues how to resolve?

Haven't retested again myself yet.

i got the same issue

@jofftiquez, is this still a problem? It looks like the code has been updated to pass a userId:
https://github.com/appwrite/demo-todo-with-vue/blob/1b8f2d13b9ed591801405cda4a9acb7ab9a6c2f9/src/api/index.js#L21

@jofftiquez, is this still a problem? It looks like the code has been updated to pass a userId:
https://github.com/appwrite/demo-todo-with-vue/blob/1b8f2d13b9ed591801405cda4a9acb7ab9a6c2f9/src/api/index.js#L21

Hello, sorry but I haven't tested it myself again.

@jofftiquez is it okay if I close this and you can open a new issue if you're still running into this problem?

Sure thing! @stnguyen90


test-branch/execute-job/wrong-commit-sha-on-pr/a49c0668-ec48-489e-aa92-c78028dc35cc

PR for testing 302afff22947e194eb98614362575bb28fe85c65

/canonical/self-hosted-runners/run-workflows 744e7b1cdbb875bb6f86ab7ec27006440ac814fc


log to stdout for containers

FEATURE REQUEST:
Currently all logs go to file /var/log/anchore.
This does not play well in the container world (Kubernetes and co), where it is expected that containers log to stdout.
This also means containers cannot be run as Read/Only mode.
Could a flag be added to log to stdout/stderr ?

Hi @dadux,
Anchore does echo the engine service logs to stdout/stderr as well as writes to file in the container at /var/log/anchore.
With regard to running containers in Read/Only mode, Anchore services write pidfiles, use temporary space for a variety of operations including layer scanning as to not bloat the local disk with image pulls, etc.
Can you share a little more information regarding the issues you're seeing running Anchore in your environment?


Add and edit commit in the same page.

The add and edit option should be available in the same page as the blog and need not be redirected to a new pagev for the same.

Can I work on this issue?

Cool

@thebishaldeb  it is working fine now.
I can edit comments also.
It's not showing any error.


[5.2] New method: SessionStore::increment

Several stores in the framework offer a method increment,
as a convenient helper method for get/set.
This change implements an increment method in the session store,
to ease the tracking of a state into a session.
For example you can:
        $redirectsCount = Session::increment('auth.redirects');
        if ($redirectsCount < 3) {
            // Retry to authenticate user to an external service.
        }

This target 5.2 as it's a minor feature, fully backwards compatible.

Thanks. Please revert the file permission change though.

You're welcome. PR updated to reset file permission change.

Do we want to add a decrement method before people start asking? :smile:

Indeed, other classes have both increment and decrement, I'm updating the
PR.


Add cc_grpc_library for route_guide example

Fixes #29611

@markdroth

@yashykt could you please add labels to start checks please.

ERROR: com.google.devtools.build.lib.skyframe.ArtifactConflictFinder$ConflictException: com.google.devtools.build.lib.actions.MutableActionGraph$ActionConflictException: for examples/protos/route_guide.pb.h, previous action: action 'Generating C++ proto_library //examples/protos:route_guide_proto', attempted action: action 'Generating C++ proto_library //examples/protos:_route_guide_only'

Looks like the targets are conflicting now

If there's nothing else we can do here, should we close this?


Add warnings info and missing notification

@jgrosseo

Thanks! I made few suggestions. You can simply accept them on github and then we can merge

Hi, thanks for the suggestions, I accepted them. :)


Wrong service name prevents service startup

Hi,
Tested on Windows 2019, the service name is named OpenSSHd not 'sshd' as mentioned in the 'Initial Configuration of SSH Server' section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18a5a4e5-2604-23c2-1374-68a6974170bc
Version Independent ID: f93809cc-eb5e-6b9b-ed58-c8811a8ee21f
Content: Installation of OpenSSH For Windows
Content Source: WindowsServerDocs/administration/OpenSSH/OpenSSH_Install_FirstUse.md
GitHub Login: @maertendMSFT

false report.


Updated tags in v2.0.0 causes replacement of Transit Gateway and its route tables

Upgrading STNO from v1.0.0 to v2.0.0 causes a replacement of Transit Gateway and its route tables due to changes in the tags, as documented here
This also caused duplicate Transit Gateway and Route tables due to the Retain policy.

@david-prado Thanks for bringing this to our attention. We have not seen this behavior in our testing. It would be great if you could open a support case via the console to allow us to obtain and review the logs. Thanks.

I have opened a support case with instructions to contact you so you can look at the logs. Thanks

@david-prado Was your issue resolved?

I am facing a similar issue in our customer environment which is preventing us from promoting v2.0.0 to production. Anyone found a workaround for this? @david-prado

We just update the v2.0.0 template with same tags as previous version. That prevents the replacement

I am facing a similar issue in our customer environment which is preventing us from promoting v2.0.0 to production. Anyone found a workaround for this? @david-prado

We just updated the v2.0.0 template with same tags as previous version. That prevents the replacement


Implement brightness control

This implements .setBrightness(), .getBrightness(), and makes .syncLed() adjust the brightness accordingly.
This is needed to address keyboardio/Kaleidoscope#775, and is a pre-requisite of keyboardio/Kaleidoscope#785. See the latter why this is pushed down to this far.

Hmm... there's also .setAllLEDsTo and .setOneLedTo which would need updating to use brightness control. But those are never called from Kaleidoscope... should I update them nevertheless?

Having looked at what .setAllLEDsTo and .setOneLEDTo do, I believe they should be removed. They immediately send the data to the LED controller, and updates the affected LEDs immediately. That's not something we want to do in Kaleidoscope, we want to update them all at the same time, in a well controlled manner (syncLeds()).
As such, these two methods aren't going to be used by Kaleidoscope, so instead of changing them to support brightness, I'll just remove them instead.

Ow. Removing those methods broke the examples... I really don't think we should have those two methods, so will update the examples, I guess.

they are still part of the API. It’s worth noting that the model 01 LED controllers have a separate global brightness control. I bet the raise does too.

On Jan 4, 2020, at 9:22 AM, Gergely Nagy<EMAIL_ADDRESS>wrote:

Hmm... there's also .setAllLEDsTo and .setOneLedTo which would need updating to use brightness control. But those are never called from Kaleidoscope... should I update them nevertheless?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Oh. That's good to know. I'll redo this (and keyboardio/Kaleidoscope#785) based on that, then.
Thanks!

Checked the Model01 LED controllers, and while they DO have an API to control brightness, there are a number of limitations:

There's no readBrightness implemented on the ATTiny side, so we have to keep track of brightness ourselves.
Brightness itself is limited to 32 levels, and the brightness curve is noticably worse than doing the brightness adjustment ourselves with 255 (gamma corrected) levels.

Due to these, I opted to not use the controller-supplied brightness controls, but roll our own. Added a comment about to the code.


Please remove shebang from main.py

Please remove shebang from main.py. It makes no sense there:

the file is not executable, hence the shebang does nothing
even if it was executable, nobody executes this by going to terminal and running the file, it is a Python module
the purpose of this file is to allow executing python -m tcolorpy which does not require a shebang

for details see https://bugzilla.redhat.com/show_bug.cgi?id=2058411#c8

Fixed by #3


Student/Teacher or Pair Programming mode

It'd be really cool to have a Student/Teacher or Pair-Programming mode.
Here are the several modes of multi-user editing.:
Single Cursor Mode
This is a mode where both see the same buffer and their cursors are linked.  Only one can type at the same time.  The scrolling in the buffer should be the same.  Suitable for simpler pair programming.
Double Cursor Mode
This has two cursors.  Similar to google docs.  Each user controls a cursor and can edit independently.  Suitable for advanced pair programming.
"Talking Stick" Mode
This is similar to Single Cursor except that only one person can edit at a time.  The other can still move around the buffer to read other parts.  There needs to be a button to snap back to the scroll position of the editor, though.  Suitable for teaching.

This would be pretty awesome.


Add nominee: Platform for Real-time Impact and Situation Monitoring

Automatic addition of a new nominee submitted through the online form available at https://digitalpublicgoods.net/submission

@nathanbaleeta This looks good to me


JKBMS SerailBattery many "Unknown" in parameters

Describe the problem
When reviewing the connected JKBMS via SerialBattery
i noticed the following fields reported as unknown:

Switch - Unknown
State - Unknown
Relay state - Unknown
Alarm State - Unknown
Under Diagnostics (it is listed actually twice with different sub-menus)
Alarm -Unknown
Main Switch - Unknown
Heater  - Unknown
Internal Fan - Unknown
I understand that some of this is because data is not provided by the BMS but i care the most about the Alarm State

I presume the alarm state should be known as under Alarms we have OK for everything,

so AlarmState should be "OK"

Also there is a lot of parameters that look out of place like "air temperature", "Starter Voltage" etc. Can some one please elaborate on these?

Driver version
0.14.3
Venus OS device type
Raspberry Pi
Venus OS version
v3.0
BMS type
JKBMS / Heltec BMS
Cell count
4Cell multiple batteries
Connection type
Serial USB adapter to RS485
Config file
original

Relevant log output
can provide what is needed

Any other information that may be helpful
No response

Thats already fixed in the next version. You can try the nightly to solve hat.

@mr-manuel i did update to this version:

still looses the name after reboot

See https://github.com/Louisvdw/dbus-serialbattery/issues/100


API: projects -> environments

Update v2-beta that renames project to environment and then fix everything that breaks.

Are we really ever going to do this?


Windows scaling also scales mouse-rs locations

I was going mad at how the pointer location was inaccurate before I figured this out: windows scaling options also scales the mouse location when using move_to().

Despite my monitor being 1920x1080, move_to() is also scaled by 125%, meaning I reach the bottom right corner of the screen at move_to(1536, 864)
I realize this project hasn't been updated in a year but this is probably unintentional and I hope someone can get around to fixing it.
Worth noting it's not a huge deal if you know the current scale, but the problem is if I'm giving the program to someone else.
let mouse = Mouse::new();
let loc_x = (f64::from(INTENDED_X) / 1.25).floor() as i32; // Assuming you're at 125% scale.
let loc_y = (f64::from(INTENDED_Y) / 1.25).floor() as i32; // Not 100% accurate because it has to be i32, so I have to floor or get average.
mouse.move_to(loc_x, loc_y);

I'm not surehttps://docs.microsoft.com/en-us/windows/win32/api/shellscalingapi/nf-shellscalingapi-getscalefactorformonitor is possibly a solution, adding a loc * scalefactor could do the job


fix fix txn insert case

Proposed changes
the txn insert case wait for schema change for the specific job state, not for job done.

run buildall

run p0


TTL (Time to Live) is not working as expected, not be able set expire time.

Description
Hi, I am trying to put expire time while setting value to the key using set method like below.
redisCluster.set([key], [data], [expire time]) and my cluster set is like this.
Redis.createCluster({
         rootNodes: [
             {
                 url: `redis://${hostname}:7008`
             }
         ],
         defaults: {
             password: '#pass#'
         },
         useReplicas: true,
     })

For ex: I am setting one key pair values to redis like key --> Demo value --> demo_value with expire time as 60 sec. After inserting, I am able to view the key values in redis terminal by using GET Demo commend. It return value as demo_value . But trying with TTL Demo commend it returns (integer) -1. It seems like time expiration is not set to the key.
Node.js Version
12.22.12
Redis Server Version
5.0.8
Node Redis Version
4.0.6
Platform
No response
Logs
No response

I got solved this by using this syntax redisCluster.set([key], [data], { EX: [time second]}) , Thanks


[FIRESTICK] There was a problem parsing the package.

I tried installing the apk on firestick but it says
There was a problem parsing the package.

I don't own a firestick so i'm unable to test it.
However looking it up, it seems only FireOS 8 on the Fire TV Stick 4K and Fire TV Stick 4K Max, built on top of Android 11, is the only supported Android version for this app.
If your Firestick isn't running FireOS 8 based on Android 11, there is nothing i can do.
I may support more android versions in the future, but right now i depend on some features not present in earlier versions of Android.


Init only after dom loaded

The first thing I tried was something like:
<!doctype html>
<script src='awesomplete.js'></script>
<input class=awesomplete data-list='blah, blablah, blablablah, blargh'>

This didn't work, though, because awesomplete needed the DOM to be loaded when it initializes.
This PR makes it wait until the DOM has been loaded, so you can put the awesomplete.js directly into <head> and it will work just as well as if you put it at the end of <body>.
The technique is basically what jQuery does (https://github.com/addyosmani/jquery.parts/blob/master/jquery.documentReady.js), except that it might not work for historical browsers (didn't test on IE either).

Merged, thanks!


popover connected

will need this for a use case

@gdostie this is just an example, you can popover any component or element you want


Consolidate Rust and AssemblyScript examples

Currently Rust and AssemblyScript examples use slightly different contracts and package.json files. This means that it's hard to make various flags orthogonal (e.g. have Rust example with React) and multiplies the number of templates we need to maintain to support such combinations.
I propose following changes:

make contracts use the same API (and so web parts completely compatible)
move differences in build scripts out of package.json

Then we can easily re-combine different backend contracts (Rust and AS) with different frontends (vanilla, React, etc) and so reduce number of templates that need to be maintained.

Also right now for AS example we only have integration tests in JS, but for Rust example – only unit tests in Rust.
Makes sense to have both type of tests for both languages. My understanding is that @willemneal is already working on as-pect support. So we should use that for AS unit tests.
We can use same JS integration tests for both languages once we have fully matching contract API.

Asc examples only have a view function. We should add a change function as well as part of this effort.

We also need to add an example of returning a user defined struct to rust.

https://github.com/nearprotocol/create-near-app/pull/94

We need to generate readme, package, and a few other things from template. Current WIP proposal is here https://github.com/nearprotocol/create-near-app/pull/100

We decided to punt on readme generation for now. Can we close this issue @vgrichina ?

@janedegtiareva do I understand correctly that this part is done:

make contracts use the same API (and so web parts completely compatible)

but this one isn't:

move differences in build scripts out of package.json

?
I think @chadoh was thinking regarding using GitHub repos as templates for create-near-app as well. If it's the direction we are going – makes sense to close this and replace by another tracking issue to use GH repos as templates.

@vgrichina  Yes, that's the correct understanding of the current state. The web parts are compatible, the only diffs are in the build scripts (+ readme files)


[1.7.10] Fix dupe bug with chemical washer

https://www.youtube.com/watch?v=i86989eh4Kc&feature=youtu.be

1.7 is dead

So you are using your personal opinion to refuse a bug fix for a older edition?
Seems non logical.

@thiakil Might be best to just pull it in then, if its dead then what is the harm?


Specify a font for italicized elements

I would like to use Fira Mono as a general font for the code but Operator Mono for the italicized elements. Is there a way to do this? Can I create an override in my user settings?

The theme is font agnostic, and it depends on the editor you are using if this is possible. As far as I know it isn't possible to specify a font in a tmTheme file.


Support custom host /proc path in config

What type of PR is this?
/kind feature
What this PR does / why we need it:
We now support setting the host proc path for nested setups like kind.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Added `hostProcVolumePath` option to spod to define a custom `/proc` volume on the host.

Codecov Report

Merging #788 (8b98df2) into main (81644f3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   53.50%   53.47%   -0.03%
==========================================
  Files          42       42
  Lines        4170     4172       +2
==========================================
  Hits         2231     2231
- Misses       1872     1874       +2
  Partials       67       67

Had to rebase to fix the CI.

/test pull-security-profiles-operator-test-e2e

/test pull-security-profiles-operator-test-e2e

/test pull-security-profiles-operator-test-e2e

/override pull-security-profiles-operator-test-e2e


Asset download count

Not sure if possible, but in the migrations I do not see a field for asset download count? I see the +1/-1 votes but a download count would be a nice to have if feasible.

Download counts would require us to modify the download URLs so we redirect to the final download path. I'm not sure if it's worth the added complexity.


Update Dataflow Development Container Version

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand:

[ ] What the pull request does
[ ] Why it does it
[ ] How it does it
[ ] Why this approach

[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Dataflow PostCommit

Run Dataflow ValidatesRunner

SUCCESS
--none--

run dataflow validatesRunner

R: @huygaa11 @jasonkuster


[WIP] Replace referer checking with javascript prologue

add a line to throw an exception before each javascript returned to prevent JSONP request access
remove referer checking

Comments and review most welcome.
Ping @matthewd, @kbrock, @mansam, @dclarizio

+1
This is way better then referrer checking. While referrer checking may be good enough today, it may not be tomorrow. Time to time someone finds a way to make standard browser spoof referrer. The proposed approach should hold better.

The assumption made here is that we do not have any more destructive actions accessible through GET requests any more. Because such actions would be accessible through JSONP after this change.
I am pretty sure we have actions that reveal sensitive stuff (such as the CSRF token) on GET requests and this approach should prevent those from being gained by an attacker through JSONP, because of the throw call.

Rebased again.

Wondering about app/controllers/application_controller/filter.rb:851 (empty render :update doesn't technically need it but...)
Also.. app/controllers/chargeback_controller.rb:168 - that one is probably a mistake and should have javascript_prologue?

OK, looks good from my POV, the only remaining place I'm not sure about is a render :js => '' in x_settings_changed - but that method is apparently never used, so.. :)

Did some testing in the UI, including directly accessing pages via URL.  Failing test is not related, merging.


Bumped versions in rebar.config and boss.app.src

Hi there,
I fixed #561 as well as #556. For #556 I would argue that the line in the rebar.config should be kept. In my opinion this makes it easier to share your project with others as they can just check your code out and run rebar. Especially if you put the deps folder into .gitignore like I do.

merged.
Regarding CB as an app dependency. Line could be kept, but commented by default. I will open poll and mailing list to check community opinion