connectTimeout and socketTimeout are not configurable via the jdbc connection string

We are setting the connectTimeout and socketTimeout values for our mysql data source via query parameters on the connection string as such:
mysql://<IP_ADDRESS>/db?connectTimeout=10&socketTimeout=300

If we add this to a crate jdbc connection string these values get parsed as part of the port on the last node.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27274988-connecttimeout-and-sockettimeout-are-not-configurable-via-the-jdbc-connection-string?utm_campaign=plugin&utm_content=tracker%2F2398677&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2398677&utm_medium=issues&utm_source=github).

Hi, thanks for bringing this to our attention - this should not happen and we will take care of it. I'll update once it's done!
Thanks and all the best, Claus

Hi, we have fixed this issue and added the ability to configure timeouts via URL parameters to our backlog. The fix will be in the new release.
Cheers, Claus

Ok, so the big bug, the failure to parse is fixed, but the timeouts will be ignored now, correct? A good step forward, but being able to set socket timeouts will help a lot when dealing with outages and network issues. Without the ability to set timeouts we're just asking for a bad socket to hang either a request or the entire connection pool depending on the circumstances.

yes @reversefold, as mentioned by @celaus we decided to release a quick fix now. we are still working on the full implementation.

Just confirming, thanks.


Pass more information (file absolute path) into outputPath function so we can generate dynamic path

For now, only the url is passed into the outputPath (https://github.com/webpack-contrib/file-loader/blob/master/src/index.js#L49). When I use relative URL in CSS, the image context is lost in outputPath function. It'd be better if you pass the absolute file path (https://github.com/webpack-contrib/file-loader/blob/master/src/index.js#L30), we can use this info to return more dynamic path.

Feel free to send a PR for discussion

Food for thought, the use of absolute paths in loaders is generally more trouble than it's worth.

@d3viant0ne Thanks for your advice, I do not use the absolute path as an output, I just use the path information to generate dynamic relative output

This is the PR: https://github.com/webpack-contrib/file-loader/pull/222
In addition to pass the full path, I mad one more change: Do not override the output path if user have set it. From my point of view, if the outputPath is not set, we can generate one depends on the url. But if user set it, we should use it.

Declined. Ref: https://github.com/webpack-contrib/file-loader/pull/222

Of sorry, my mistake

Declined. Ref: https://github.com/webpack-contrib/file-loader/pull/222#pullrequestreview-73595350


Replace all uses of promiseExec with promiseExecFile

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>resolves https://github.com/lensapp/lens-security/issues/7

Probably not related to current PR, but found that we need to refresh helm chart after go from Preferences page. Right now, it might show stale repos and charts in list. If you click them, you got an app crash:
https://user-images.githubusercontent.com/9607060/146362541-6362f41f-caaa-4f3c-af38-32783539b316.mov

Probably not related to current PR, but found that we need to refresh helm chart after go from Preferences page. Right now, it might show stale repos and charts in list. If you click them, you got an app crash:
https://user-images.githubusercontent.com/9607060/146362541-6362f41f-caaa-4f3c-af38-32783539b316.mov

I will investigate since I didn't think that this was possible before this PR

@aleksfront That also currently exists in master so I don't think we should fix it in this security PR.


glfwSwapBuffers Hangs On Wayland When The Window Is Invisible

Expected Behavior
glfwSwapBuffers never hangs, if there aren't any events, it should return almost immediately.
Actual Behavior
When the window is visible, glfwSwapBuffers works fine, but when it's invisible (doesn't even have to be minimized), glfwSwapBuffers hangs.
Steps To Reproduce
Apply this patch and run the gears example, notice how it stops printing polling debug messages when it's invisible.
--- a/examples/gears.c
+++ b/examples/gears.c
@@ -339,6 +339,7 @@ int main(int argc, char *argv[])
     init();

     // Main loop
+    int i = 0;
     while( !glfwWindowShouldClose(window) )
     {
         // Draw gears
@@ -349,6 +350,7 @@ int main(int argc, char *argv[])

         // Swap buffers
         glfwSwapBuffers(window);
+        fprintf(stderr, "polling %i\n", i++);
         glfwPollEvents();
     }

System Information
Ubuntu 22.04 Wayland

After further testing, this seems to be glfwSwapBuffers, not glfwPollEvents. Still hangs though.

And even further testing reveals that this isn't even related to the Wayland windowing code, but also occurs on X11 windows as long as you're using XWayland. It also seems to affect other GL calls like glClear. Is this even GLFW's fault?

Looks like SDL had a similar issue: https://github.com/libsdl-org/SDL/issues/4335

After more research, this just seems to be a Wayland problem.

This should no longer be the case since 094aa6d3c721397825cb1095c156353463ecafb5.


JavaExec.main not settable in doFirst

I have my own "run" task (allprojects):
task("run", JavaExec::class) {
doFirst {
main = "defaultClassName"
}
}
I set "main" in "doFirst" because I want to "override" it using "doLast" in some subprojects.
Using gradle-6.4-rc1 (and also gradle-6.4-20200418230023+0000) I get:
"The value for task 'run' property 'mainClass' is final and cannot be changed any further."
This worked fine with gradle 6.3 and earlier.

@wolfseifert what you describe is expected as the main field is now backend by a property for lazy configuration.
You should treat the error as a problem with your build script that Gradle now detects.
main should not be set in a doFirst or doLast task action. It is meant to be set during task configuration. (Setting in doLast also has no effect normally, as the actual running already executed before that.)
Sou you should set it like this:
tasks.create<JavaExec>("run") {
   main = "defaultClassName"
}

For the "overriding" you can now use the new property mainClass (instead of main) and set a convention.
// In your task creation code
tasks.create<JavaExec>("run") {
   mainClass.convention("defaultClassName") // convention will be used if the property is not set
}

//...

// In your more specific code where you want to 'override' the convention
tasks.named<JavaExec>("run") {
   mainClass.set("myConcreteClassName")
}

Ok, main should be set during configuration.
But should I use
tasks.create<JavaExec>("run") {
   mainClass.convention("defaultClassName")
}
tasks.named<JavaExec>("run") {
   mainClass.set("myConcreteClassName")
}

or the more concise
tasks.create<JavaExec>("run") {
   main = "defaultClassName"
}
tasks.named<JavaExec>("run") {
   main = "myConcreteClassName"
}

Both seem to work. The second one looks more appealing.

You should use the firs mainClass.set(...) as the other will be deprecated soon.
I know that the syntax switch from = to set can feel "not so nice". But in the future you'll be able to do all configuration using the set(...) API and have much less issues with configuration timing (see:  documentation on lazy configuration).

@jjohannes, why is the assignment operator way (mainClass = ...) going to get deprecated? Where is it documented? mainClass.set(...) feels fine for Kotlin, but Groovy is more about conciseness, the assignment operator fits the language well there, as we don't call getters or setters in the conventional way in that language. The property API seems to break that design intent of the language. Plus, Gradle was all about look DLS-like in the build scripts. Now we're losing that aspect too. E.g. we don't even remove the optional parentheses from the set calls. Same for ListPoperty, where assignment never worked at all.

Sorry, deleted my comment, the original ticket was about Kotlin.


Show Prism warnings in diagnostics

We currently show Prism errors as diagnostics, but we don't do the same for warnings. We should definitely surface warnings as diagnostics too since they provide valuable information about the code.

Hello @vinistock 👋 I would be happy to help on this.
Prism warnings should be merged with Rubocop diagnostics, if it's present? They are often duplicate but seems legit to have both 🤔
WDYT?

I think it should be fine to merge with RuboCop diagnostics. In fact, if RuboCop gets support for Prism as the backend (which I understand is the desired goal), then it doesn't even make sense for RuboCop to have these rules. They should come from the parser.


Simple repeater in relationship presents as [object Object]

Package
filament/filament
Package Version
v3.1.21
Laravel Version
v10.37.3
Livewire Version
v3.3.0
PHP Version
PHP 8.2.13
Problem description
Using a simple repeater in a relationship layout component shows [object Object] instead of the text for each item in the array. This does not happen if the field is located on the model itself (left), only if it's nested in a relationship (right).

The issue is similar, but does not appear to be the same as #8874
Expected behavior
The text from the array element should be displayed.
Steps to reproduce
Create a simple repeater within a nested relationship layout component:
// Works correctly
Forms\Components\Repeater::make('phone_numbers')
    ->simple(
        TextInput::make('phone_number')
            ->required(),
    ),

// Presents filled lines as [object Object]
Forms\Components\Group::make()
    ->relationship('address')
    ->schema([
        Forms\Components\Repeater::make('lines')
            ->simple(
                TextInput::make('line')
                    ->required(),
            ),
    ]),

Reproduction repository
https://github.com/mdpoulter/filament-issue-repeater
Relevant log output
No response

@danharrin Just a heads up that this seems to be broken again in the latest release. It looks like it may have been caused by #10537 (which seems to have fixed parts of the other issue I created #10536 😄 ).
I haven't created a new reproduction repo, but can if you would like.

Uh oh, yes please if you could create a reproduction repo

unless the existing one works for the new issue as well? just confirm if that is the case

I've created the reproduction for this here: https://github.com/mdpoulter/filament-issue/tree/repeater

Thanks for your patience. #10537 seems to have simplified the situation and I was able to fix the problem much easier in #10764


Only pass TILEDB_REST_TOKEN to test_cloud during CI

We don't set TILEDB_REST_TOKEN directly in the CI environment. Instead we use an extra environment variable TILEDB_CLOUD_HELPER_VAR and only use it during test_cloud testing.

Only pass TILEDB_REST_TOKEN to test_cloud and Notebook tests during CI


Failed to bring up Control Plane: Failed to verify healthcheck

What kind of request is this (question/bug/enhancement/feature request): Bug
Steps to reproduce (least amount of steps as possible): Set up 3 nodes (VMs) for running k8s cluster and 4th node for running RKE and kubectl commands. Then run ./rke up --config ./rancher-cluster.yml
Result: FATA[0514] [controlPlane] Failed to bring up Control Plane: Failed to verify healthcheck: Failed to check https://localhost:6443/healthz for service [kube-apiserver] on host [<IP_ADDRESS>]: Get https://localhost:6443/healthz: EOF, log: I0507 07:05:51.188445       1 plugins.go:161] Loaded 6 validating admission controller(s) successfully in the following order: LimitRanger,ServiceAccount,Priority,PersistentVolumeClaimResize,ValidatingAdmissionWebhook,ResourceQuota.
Other details that may be helpful: Trying to set up k8s HA cluster using RKE. Earlier, i was facing this issue. Now i am stuck with the health check issue.
Environment information
Using RKE release v0.1.18
# kubectl get nodes
The connection to the server <IP_ADDRESS>:6443 was refused - did you specify the right host or port?

All 4 VMs have same OS
cat /etc/*release

CentOS Linux release 7.6.1810 (Core)
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

CentOS Linux release 7.6.1810 (Core)
CentOS Linux release 7.6.1810 (Core))

# uname -a
Linux mybox 3.10.0-693.17.1.el7.x86_64 #1 SMP Thu Jan 25 20:13:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Installation option (single install/HA): Trying HA install with 3 VMs for k8s and 4th one for kubectl and RKE.

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): On-prem VMs
Machine type (cloud/VM/metal) and specifications (CPU/memory): VMs

# top
top - 13:09:26 up 51 min,  1 user,  load average: 0.53, 0.55, 0.50
Tasks: 126 total,   1 running, 125 sleeping,   0 stopped,   0 zombie
%Cpu0  :  8.4 us,  1.3 sy,  0.0 ni, 89.9 id,  0.0 wa,  0.0 hi,  0.3 si,  0.0 st
%Cpu1  : 10.2 us,  1.4 sy,  0.0 ni, 87.5 id,  0.0 wa,  0.0 hi,  1.0 si,  0.0 st
%Cpu2  :  8.1 us,  1.4 sy,  0.0 ni, 90.5 id,  0.0 wa,  0.0 hi,  0.0 si,  0.0 st
%Cpu3  :  9.4 us,  1.7 sy,  0.0 ni, 88.9 id,  0.0 wa,  0.0 hi,  0.0 si,  0.0 st
KiB Mem : 16266748 total, 13782844 free,   368796 used,  2115108 buff/cache
KiB Swap:        0 total,        0 free,        0 used. 15449600 avail Mem

# free -g
              total        used        free      shared  buff/cache   available
Mem:             15           0          13           0           2          14
Swap:             0           0           0

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Unable to connect to the server: net/http: TLS handshake timeout

Docker version (use docker version): Docker version on all 4 nodes:

docker version

Client:
 Version:           18.09.5
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        e8ff056
 Built:             Thu Apr 11 04:43:34 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.5
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.8
  Git commit:       e8ff056
  Built:            Thu Apr 11 04:13:40 2019
  OS/Arch:          linux/amd64
  Experimental:     false

Before posting this, i also checked similar issues here and i tried deleting nodes twice using the following commands but to no avail:
docker rm -f $(docker ps -qa) && docker rmi -f $(docker images -q) && docker volume rm $(docker volume ls -q) && rm -rf /etc/ceph \
       /etc/cni \
       /etc/kubernetes \
       /opt/cni \
       /opt/rke \
       /run/secrets/kubernetes.io \
       /run/calico \
       /run/flannel \
       /var/lib/calico \
       /var/lib/etcd \
       /var/lib/cni \
       /var/lib/kubelet \
       /var/lib/rancher/rke/log \
       /var/log/containers \
       /var/log/pods \
       /var/run/calico

Also, on the node (<IP_ADDRESS>) where health check is failing, output of docker ps -a is as stated under:
# docker ps -a
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS                      PORTS               NAMES
ec79035243f7        rancher/hyperkube:v1.13.5-rancher1   "/opt/rke-tools/entr…"   33 minutes ago      Up 7 seconds                                    kube-apiserver
581e749a1a1e        rancher/rke-tools:v0.1.16            "/bin/bash"              33 minutes ago      Created                                         service-sidekick
c985098e8904        rancher/rke-tools:v0.1.16            "/opt/rke-tools/rke-…"   33 minutes ago      Up 33 minutes                                   etcd-rolling-snapshots
5cd6f57377e8        rancher/coreos-etcd:v3.2.24          "/usr/local/bin/etcd…"   33 minutes ago      Up 33 minutes                                   etcd
e10c8b1611e3        rancher/rke-tools:v0.1.16            "/bin/bash"              37 minutes ago      Exited (0) 37 minutes ago                       cert-fetcher
467c3d23d4b1        rancher/rke-tools:v0.1.16            "/bin/bash"              37 minutes ago      Exited (0) 37 minutes ago                       cluster-state-deployer

kube-apiserver container on this instance is restarting continuously.
Any help will be appreciated.

When i checked the kube-apiserver logs, i see the following error:
F0507 08:24:06.420707       1 storage_decorator.go:57] Unable to create storage backend: config (&{etcd3 /registry [https://<IP_ADDRESS>:2379 https://<IP_ADDRESS>:2379 https://<IP_ADDRESS>:2379] /etc/kubernetes/ssl/kube-node-key.pem /etc/kubernetes/ssl/kube-node.pem /etc/kubernetes/ssl/kube-ca.pem true 0xc000beccf0 <nil> 5m0s 1m0s}), err (context deadline exceeded)
Then i checked the etcd logs and it's filled with these messages:
2019-05-07 08:32:25.934818 I | etcdmain: rejected connection from "<IP_ADDRESS>:43334" (error "remote error: tls: bad certificate", ServerName "")
2019-05-07 08:32:25.976974 I | etcdmain: rejected connection from "<IP_ADDRESS>:47536" (error "remote error: tls: bad certificate", ServerName "")
2019-05-07 08:32:25.985286 I | etcdmain: rejected connection from "<IP_ADDRESS>:43338" (error "remote error: tls: bad certificate", ServerName "")
2019-05-07 08:32:26.017834 I | etcdmain: rejected connection from "<IP_ADDRESS>:47538" (error "remote error: tls: bad certificate", ServerName "")

In one of the certificate related link, i noticed that time could be an issue. So when i checked the time on the server where i was running RKE and kubectl, i noticed that it's time was different from other 3 nodes (controlplane,etcd,worker).
Another thing was that though i cleaned up all three nodes, i did not clean up RKE/kubectl /etc/kubernetes directory. Not sure whether cleanup of /etc/kubernetes directory on the server having RKE/kubectl was necessary. Can anyone kindly confirm this?
After i performed the above two steps, i was successfully able to run ./rke up --config ./rancher-cluster.yml command.

Cleaning up nodes is described on https://rancher.com/docs/rancher/v2.x/en/cluster-admin/cleaning-cluster-nodes/#cleaning-a-node-manually and exploring date/time differences is tracked in https://github.com/rancher/rke/issues/1123


Using pseudoclasses in overriding styles

I'm, trying to override ::before and ::after -pseudo-classes but failing to do so. Following this documentation (https://material-ui.com/guides/api/#css-classes):
const styles = {
  root: {
    color: green[600],
    '&$checked': {
      color: green[500],
    },
  },
  checked: {},
};

with:
var style = {
      top: 'auto',
      left: 'auto',
      right: 'auto',
      margin: 0,
      maxWidth: 600,
      width: '110%',
      height: 64,
      '&$after': {
        backgroundColor: 'inherit',
      },
    }'

    return (
      <Provider>
        <div>
          <AppBar id='AppBar' style={style}>
            {menu}
          </AppBar>
        </div>
      </Provider>
    )`

But the pseudo-css does not appear for some reason?
In here (https://stackoverflow.com/questions/47024404/how-to-use-pseudo-selectors-in-material-ui) it is said to use:
'&:hover':
but that does not work either...
What am I doing wrong?

[ ] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

Context

Your Environment

Tech
Version

Material-UI
v1.?.?

React

browser

etc

&::after

@oliviertassinari When trying to configure global overrides in a theme, pseudo-classes dont seem to be applied correctly. Can you confirm that this is the correct way to have a FilledTextfiled use a different backgroundColor when being in focus:
const theme = createMuiTheme({
    ...
    overrides: {
      MuiCssBaseline: {
        "@global": {
          ...
        }
      },
      MuiFilledInput: {
        root: {
          backgroundColor: "rgba(255, 255, 255, 0.5)",
          "&:focused": {
            backgroundColor: "rgba(255, 255, 255, 0.95)"
          }
        }
      },
    }
  })
);

I can confirm backgroundColor is correctly being overriden, but the focused pseudo-class is not.
Thanks!

@Sewdn I would recommend to look at the injected CSS. Make sure the changes are in the CSSOM as well as you get the correct specificity and target the right element. Otherwise, you could ask on StackOverflow.


[Endpoints] Change size of protocol + [Nexpose] consolidation of protocols

@valentijnscholten, rebased and db_mig file moved

tests failed but not because of my changes


best_practices: link @lindig curated practices

These are in use in XenServer and are very thorough and well written, I think they should appear in the ocamlverse as well

Merged!


feat: implement lowering from ast to air

This PR implements the rest of the changes related to the modules implementation started in #297. Specifically, this PR implements the translation pass from the AST to AIR, cleans up the air-ir crate, updates the tests, and updates the downstream codegen/winterfell and air-script crates.
This PR, being the last in the chain started by #297, can be retargeted to next and merged to merge all of the modularity-related PRs:

#297
#304
#305
#306
#307
#308
#309
#310

Otherwise, each of the PRs above must be retargeted+merged starting with #297. Since all of those PRs do not independently compile until this one, I'd recommend conducting your review in each PR, then when we're done with review, closing all but this one and retargeting it against next, rebasing against any recent changes, and merging when ready.

NOTE: Due to commits in other PRs, we'll want to merge individual PRs into the bitwalker/modules branch (i.e. #297), and then merge that PR at the end, rather than merging this PR, otherwise it requires a bunch of rebasing to keep the branches clean and that's not really worth it IMO. I'll stay on top of that though as PRs get merged.


Refactor for Error Mesaage class use

Made following changes:
Moved all the methods which are related to creating error message to ErrorBuilder class.
Used Error Message object as a parameter for createErrorDescription.
Some minor nits.

Not a full review, but, eyeballing it, it looks fine to me, except the PR title/commit message has a typo: "Mesaage".

Not a full review, but, eyeballing it, it looks fine to me, except the PR title/commit message has a typo: "Mesaage".

Oops! 😅

Hey @msridhar , do you have any unaddressed comments on this PR? I glanced at it and the refactor makes sense to me, given all tests pass, maybe worth merging it before #291 ? And releasing 0.7.0 with both?

Hey @msridhar , do you have any unaddressed comments on this PR? I glanced at it and the refactor makes sense to me, given all tests pass, maybe worth merging it before #291 ? And releasing 0.7.0 with both?

Sounds good


[FeatureRequest] Sort dashboards by name

By accident I deleted my "main" dashboard. Now I have my debug dashboard as default. Would it be possible to rearrange the order order sort them by name?

@cimba007 this fix is available in SNAPSHOT version.


topicListScreen: Remove connectPreserveOnBackOption from connect params.

Why this is removed? Because it was acting over smartly. This was
added to save redundant re-renders which were caused by nav state
change on pushing/popping route. But what if topics got fetched while
navigation is in a state of isTransitioning. It will ignore that
event and will not get re-rendered.
Also topicListScreen is not depended on the nav state, so even if
cur.nav.routes.length < prev.nav.routes.length

is removed then also there is no problem. As the prop supllied to
topicListScreen will not change and shouldComponentUpdate (as
PureComonent is used) will return false and save re-render.
Instead of using connectPreserveOnBackOption, we should make our
selector not to listen to nav state change (#2810). Which is a better
alternative for connectPreserveOnBackOption.
Fix: #2808
Next will go through all other instances where
connectPreserveOnBackOption is used and check whether it is really
required or not.

(This shouldn't be merged until #2810 is in, right? Because until then it triggers a bug.)

Hmm, but #2808 is a nastier bug. So I guess it's best not to block on that.

As discussed here:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/react-navigation.20v2
we should completely remove the connectPreserveOnBackOption function.
From my testing, we should remove it in the nav bars too, at least, which leaves only AccountDetailsScreen (we use that in 6 places currently)
I will first do a PR removing the getCanGoBack usage and then none of the selectors would be nav state dependent.

Merged -- thanks @jainkuniya !
It seems we all agree we should remove that value completely; great. :smile: I summarized our recent discussions and conclusions in a jsdoc on it, pushed as feff4bd17.


Additional search groups

What does this implement/fix? Explain your changes.
Adding some missing search groups.
We are still a bit unhappy about the H ones as it would be nice if they could use the implicit hydrogens. We couldn't find an efficient way to do that, but we have been asked multiple times.

@ricrogz @ptosco @bp-kelley
I think this PR mostly looks good, but since it results in a change in behavior I wanted to check with you on one point to see if you have strong objections.
Current behavior: if you want to include a generic group like ARY or AOX in a mol block, you have to include it as an S-Group.
Behavior after this PR: you can include ARY or AOX as atom labels, so this becomes a legal mol block:

  Mrv2211<PHONE_NUMBER>2D

  0  0  0     0  0            999 V3000
M  V30 BEGIN CTAB
M  V30 COUNTS 2 1 0 0 0
M  V30 BEGIN ATOM
M  V30 1 C -6.5833 1.9167 0 0
M  V30 2 ARY -5.2497 2.6867 0 0
M  V30 END ATOM
M  V30 BEGIN BOND
M  V30 1 1 1 2
M  V30 END BOND
M  V30 END CTAB
M  END

I think this is fine, and it certainly makes interoperability with chemical sketchers like marvin and ketcher easier.
Any objections to this change?

Any objections to this change?

I have no objections.

Any objections to this change?

No objections either, although I haven't used the generic groups. I think @rachelnwalker has, so maybe she think of something :)


PHP: add custom logger

Add the ability to specify a custom location to emit grpc logs to, in the grpc PECL extension.
Here's a few lines to be added to your php.ini file:
grpc.grpc_verbosity=debug
grpc.grpc_trace=all,-timer_check
grpc.log_filename=/var/log/grpc.log

Tested in CLI, Apache and php-fpm/Nginx.
I was trying to use the php_stream_open_wrapper, php_stream_write and php_stream_close APIs but somehow got a memory leak that I couldn't figure out. So I end up going back to fopen, fprintf and fclose.
One thing that wasn't addressed are file rotations / putting a cap on size of the log files.

Hi @stanley-cheung are we waiting on a reviewer for approval?

@veblush can you please review this as you suggest I use gpr_set_log_function?  Thanks!

Fixes #20974


Enhancing RichText control (label)

Q
A

Bug fix?
[ ]

New feature?
[x]

New sample?
[ ]

Related issues?
mentioned in #1375

What's in this Pull Request?

adding new properties (id, label, onRenderLabel)
replacing deprecated events
fixing empty / undefined HTML rendered class attribute
updating control's documentation
updating testing webpart

Thank you @michaelmaillot for the changes!


TagHelperDiscovery results should flow via LSP method call

In order to make the system work faster and more consistently, discovered tag helpers/components should flow to the remainder of the Razor system using a call like LSP rather than relying exclusively on file read/write.

https://github.com/dotnet/razor/issues/10547
https://github.com/dotnet/razor/issues/10548

Work has been done and shipped.


header information

If we can update the "header" information displayed on each page to match the miro board, that would be great. It currently isn't quite accurate (e.g., the "voluntary transitioning to mandatory" isn't an option anymore:

So if we can update it to include these fields (nothing about status), that would be great:

On it now.  Train wifi a little flakey but we're getting there :sunglasses:


process.chdir is not available in workers

Describe the bug
if you're testing node utilities, maybe ones that help interact with the file system, and you need to call chdir, there is no way to test that behavior because all tests run in node workers, which aren't allowed to call process.chdir
Reproduction
it('repro', () => {
  process.chdir('anywhere')
}

raises:
TypeError: process.chdir() is not supported in workers

Is there a way to opt certain tests to not run in a worker?
otherwise I'd need to test anything that uses chdir, in mocha or something.
System Info
System:
    OS: Linux 5.11 Ubuntu 21.04 (Hirsute Hippo)
    CPU: (6) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
    Memory: 7.69 GB / 16.18 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 16.13.2 - ~/.volta/tools/image/node/16.13.2/bin/node
    Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn
    npm: 7.24.2 - ~/Development/NullVoxPopuli/ember-apply/node_modules/.bin/npm
  Browsers:
    Chrome: 97.0.4692.71
    Firefox: 96.0

### Used Package Manager

yarn

### Validations

- [X] Follow our [Code of Conduct](https://github.com/vitest-dev/vitest/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitest-dev/vitest/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://vitest.dev/guide).
- [X] Check that there isn't [already an issue](https://github.com/vitest-dev/vitest/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitest-dev/vitest/discussions) or join our [Discord Chat Server](https://chat.vitest.dev).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

Then you might want to mock it, or use --threads to disable workers.

@antfu Would it be a good idea to have a comment that disables workers just for one file?

mocking isn't really an option because I need to do more file operations (not in my repo, but in external monorepos).
I'll have to tried --threads :thinking:

It is --threads=false or --no-threads`

aight, I'm happy with that -- things seem to be moving along now :D


PR for issue 632 - Refactor && DRY new user creation method

Refactor of email_processor#create_user to use user#register. Now user#register is also using the previous existent user#signup_guest.
@scott although refactor doesn't require tests, this refactor has no tests at all!
The refactor won't have any problems though, because semantically is the same thing. However I think it would the better to open an issue to create tests specially for user::register since it's a very meaningful method.

#632

Hi @scott ! Why this issue hasn't been merged yet?

To be honest I have not had a chance to fully review it yet.  I think there might be a couple other places were this could be used.


Call @actions/core setOutput with created tag

👋 @bcoe! Following up on this Twitter conversation. It'd be rad if this action called @actions/core's setOutput method, to use the tag that was created in the next actions in a workflow. I'm not sure where that's exposed, but if you can point me to it, happy to open a PR. It'd look something like this:
const release = ReleasePRFactory.build(...)
await release.run()

// Assuming it's exposed on `ReleasePRFactory.tag_name`:
core.setOutput('tag_name', release.tag_name)

This would pair nicely with build-and-tag-action's tag_name input!

@JasonEtco I don't think it does so yet, but we could make this line:
https://github.com/bcoe/release-please-action/blob/master/index.js#L20

Return the tag of a release, if one is created?

Nice, thanks for that @bcoe. I think this would also require an upstream change to googleapis/release-please, specifically here:
https://github.com/googleapis/release-please/blob/42e5bc6b8654afd4ce41e4c81333e1cf3bce75a5/src/github-release.ts#L81-L86
GitHubRelease#createRelease doesn't return or otherwise expose the generated release, or the tag (ex: we could get it from the release PR over here). I can open those two PRs (one there, one here) if you'd like! They'd be pretty simple:
class GitHubRelease {
  async createRelease() {
    // ...
-      await this.gh.createRelease(
+      const release = await this.gh.createRelease(
        this.packageName,
        gitHubReleasePR.version,
        gitHubReleasePR.sha,
        latestReleaseNotes
      );
   // ...
+  return release
}

- await gr.createRelease()
+ const release = await gr.createRelease()
+ core.setOutput('tag_name', release.tag_name)

@JasonEtco bumped into a couple issues and had to rollback:

unfortunately need all the contents of the dist/ folder.
release please currently looks at the sha of the last tag released to determine what commits have landed since the last release, since build-and-tag-actions forces a new sha this causes issues with the algorithm (I'm looking at changing this behavior to instead use the sha of the release that was last merged).


Add dev container to CI

Added matrix with latest and dev tags
Disabled fail-fast for now

Closes #270

@Liklainy I just updated the fetch_configlet to hopefully address the exit code issue. Please update your master branch and then issue-270 onto master. Let's see if that fixes that

@Liklainy Can you update the Install dependencies step to use pub upgrade only when building for dev?

Since dart 2.10 we have the new unified dart tool, so instead if using pub upgrade we should be using dart pub upgrade
See: https://medium.com/dartlang/announcing-dart-2-10-350823952bd5

Added 2.10 tag
Changed CI to use dart tool
Changed fail-fast: false to continue-on-error only for dev tag
So now only if dev job failed, workflow will continued and will be shown as successfull
But it's not like that in every place, for example in commit it shows ❌, there is an issue actions/toolkit#399 which asks allow-failure implementation or fixing continue-on-error to behave like allow-failure

@Stargator, dev with upgrade is successfully passed
I'm not sure that upgrade should be in CI, with it we wouldn't see the need to upgrade packages for dev
Removed upgrade in next commit to test continue-on-error, will add it back if it's needed
Should I squash commits?

@Liklainy and @devkabiir I ran `dart pub outdated --mode=null-safety and got the following result.
This was after upgrading the test and yaml packages to their null safe versions.

Given this result and that I had to manually change the sdk version constraint to sdk: '>=2.12.0-0 <3.0.0' just to properly use the dev version makes me believe there's no way we can resolve errors with Dart dev until more packages migrate.
Additionally, I had to set the versioning for the test and yaml packages above their latest versions in order to upgrade to their null safe versions.
  test: '>=1.15.8 <2.0.0'
  yaml: '>=2.3.0 <4.0.0'

So for the sake of a stable CI process, for now, I recommend dropping dev. That way we won't always have something failing. @devkabiir what do you think?

So for the sake of a stable CI process, for now, I recommend dropping dev. That way we won't always have something failing. @devkabiir what do you think?

I agree.

For me, that means we keep the matrix setup and can even keep the 2.10 and latest tags if @devkabiir wants. So we at least have it setup to add dev when we can.

Keep the matrix setup with only 2.10 tag since the latest is redundant at this point and as evident by https://groups.google.com/a/dartlang.org/g/misc/c/GMHD6LOLJ1I/m/2hPXC5muAwAJ,
There won't be a Dart 2.11 so when 2.12 comes we will have to do migration. Keeping the matrix setup with only 2.10 allows for stable CI as well as prepares for next CI update.

@Liklainy  I appreciate your patience and continued efforts towards this PR very much. 🚀

Current changes in this PR:

Only 2.10 tag

dev and latest dropped

matrix setup with fail-fast disabled for future tags

matrix for fast adding next tags when everyhing is ready
fail-fast to allow all tags to run without cancelling in the middle when another one is failed, to see clearly when anything is working in one version and failing in another

Using dart tool in CI


fix: metrics server extra args

The extra args for metrics server are set on multiple levels (defaults, custom app, derived) which resulted in incorrect configuration. This PR fixes this.

Have not tested it on Linode, but syntactically looks good.


❓ Question: lay person's doubts

🙋♂ Question
I don't understand anything about programming and/or codes, tools like that.  However, I decided to try, but I'm having problems.

My first question is: how do I make the url public?  for example, I don't want a "localhost" because I want to upload files to demonstrate some suggested feature for developers of a project here on Github.
Another problem I'm facing is that when creating an account, I can't log in again, when I click the "sign in" button nothing happens.

As I said, I don't understand programming, I just wanted an alternative to imgur to host videos and photos to demonstrate something, so if anyone can help me or if it's not possible, I would like to know another alternative.

Hey
The first question isn't really related to Pingvin Share because exposing a service to the internet is the same for every service. Maybe this Reddit thread can help you.
Regarding your second question, this is not expected :/ Could you share a screen recording?

Hey The first question isn't really related to Pingvin Share because exposing a service to the internet is the same for every service. Maybe this Reddit thread can help you.

So, Pingvin Share is just sharing between devices connected to the same network?

Regarding your second question, this is not expected :/ Could you share a screen recording?

Apparently, it worked again, maybe it was some configuration I made.  But thanks anyway!

So, Pingvin Share is just sharing between devices connected to the same network?

It can be, but no. Think of it this way. accessing a site/webpage needs a specific port number along with the computers IP address or host name. (for internal its usually done by <IP_ADDRESS>:8080) where the <IP_ADDRESS> is the computers IP address where the website is running and :8080 is the port that website is using on that computer.
Your router, a gateway to the outside world blocks this port from being seen for security reasons. if you want to using a website (like pingvin) you need to go into the router settings (generally a setting tab called "WAN") in this look for "port forwarding" you put in the port number and the IP address you want it to go to.
When you forward a port you are saying "if someone uses my homes IP address (randomly assigned by your internet provider, lets say <IP_ADDRESS>) and port 8080 i want the router to forward that traffic to this specific computer. this mean it would go <IP_ADDRESS>:8080 -> <IP_ADDRESS>:8080 -> website
I hope that helps.

Got it, thanks for the help!

Thanks @dnielso5 for the help


[ENH] Source Sdk bindings (for Tier0 Msg support)

Console.SetOut

[x] Tier0.Msg c# bindings

[ ] is Tier0.Msg thread safe?

[ ] test Tier0.Msg

@SupinePandora43 Can you find original Source headers for the SDK or some kind of documentation for us?

https://developer.valvesoftware.com/wiki/Developer_Console_Control

@AaronJThompson What do you think?

now it doesn't conflict between game sides https://github.com/SupinePandora43/GmodDotNet/commit/004c6f406df3f23a23b50b58842d69b0ceb6f3db

Tier0 Msg can be in the core due to Console.SetOut. However, any other source SDK bindings, Tier 0 or otherwise, must go in extensions to avoid scope creep on the core.

ok


Add 'Handwritten function' to NOP-ignored lines

Here is an example of a function I was seeing in SOTN. When counting the number of NOP instructions to inject, the "Handwritten function" at the top was being included in the count. I added that as another case which will get skipped. This fixed this particular issue. I'm still not getting a successful build, but now it's making it farther after fixing this sticking point :)

Thanks for this!


captain subparsers

is this needed?
subparsers.required = True # https://bugs.python.org/issue9253#msg186387

I added it in bounce and just added it to the new cli stuff in pout, but it doesn't look like captain has it when it does subcommands.
I think the flow should be, if you have a main command, then subparsers.required should be set to False because if you didn't include a subcommand main() would be run, but if there is no main then subparsers.required should be set to True because it would be required

the current state of the art on how I want subparsers and help to be displayed is in pout's __main__.py file, it prints a description and help for --help both before and after the subcommand and prints an ok abbreviated error message when no subcommand is given


Ensure deployment base path exists taking a long time

I have an odd issue. Not sure if anyone else has seen something similar. But I added timings to each task, and notice that the task ensure deployment base path exists is taking over 4 minutes to process.
Any ideas on why that could be? Seems like it is not doing anything special besides:
- name: ANSISTRANO | Ensure deployment base path exists
  file:
    state: directory
    path: "{{ ansistrano_deploy_to }}"

playbook run:
TASK [setup] *******************************************************************
Tuesday 13 September 2016  11:32:33 -0400 (0:00:00.235)       0:00:00.235 *****
ok: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : ANSISTRANO | Check BC for early adopters] ***
Tuesday 13 September 2016  11:32:35 -0400 (0:00:01.719)       0:00:01.954 *****
skipping: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : include] ***************************
Tuesday 13 September 2016  11:32:35 -0400 (0:00:00.066)       0:00:02.021 *****
included: /home/ansible/ansible-playbooks/ansistrano-custom-tasks/my-before-setup-tasks.yml for web-magento-97f4

TASK [carlosbuenosvinos.ansistrano-deploy : Ensures composer home directory exists] ***
Tuesday 13 September 2016  11:32:35 -0400 (0:00:00.343)       0:00:02.365 *****
ok: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : auth.json] *************************
Tuesday 13 September 2016  11:32:36 -0400 (0:00:00.973)       0:00:03.339 *****
ok: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : Ensures main directory exists] *****
Tuesday 13 September 2016  11:32:41 -0400 (0:00:04.229)       0:00:07.568 *****
changed: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : ANSISTRANO | Ensure deployment base path exists] ***
Tuesday 13 September 2016  11:37:10 -0400 (0:04:29.884)       0:04:37.453 *****
ok: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : ANSISTRANO | Set releases path] ****
Tuesday 13 September 2016  11:37:12 -0400 (0:00:01.158)       0:04:38.612 *****
changed: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : ANSISTRANO | Ensure releases folder exists] ***
Tuesday 13 September 2016  11:37:13 -0400 (0:00:01.051)       0:04:39.663 *****
ok: [web-magento-97f4]

TASK [carlosbuenosvinos.ansistrano-deploy : ANSISTRANO | Set shared path] ******
Tuesday 13 September 2016  11:37:14 -0400 (0:00:00.925)       0:04:40.588 *****
changed: [web-magento-97f4]

Ansible is sometimes slow at these things, there is not much we can do about it sadly :(

Hi again, I somehow read 4 seconds and not... 4 minutes! WOW
Not sure about your where your server is hosted but if this is taking so long it could be either a Python / Ansible problem, some disk partition issue or even worse a hardware issue
Have you checked your disks, etc? As you have seen, the step is not doing anything special

i checked my code, and it was an issue in a pre task file i had setup.
I was using the file module to create a directory and I had a recurse=yes argument in there. Once I removed that argument, it is working fine.
Thanks!


A function to clear particle‘s emission mask

Godot version:
master
Issue description:
can't find a function or a way to clear particle‘s emission mask,

There's a property in ParticlesMaterial called emission_point_texture. Setting it to null is pretty much clearing the emission mask, isn't it?

Closing as per above comment (and no reply).


contract data variables overwritten in build/app.js

truffle init uses the MetaCoin example to build the environments/development/build/app.js file with this line at the bottom:
Pudding.load([ConvertLib, MetaCoin], window);

The problem is that ConvertLib and MetaCoin are both created with the MetaCoin contract_data variable because it is declared after the contract_data associated with ConvertLib, but in the same scope (and so overwrites it).
This can be fixed by putting a closure around the ether-pudding class template:

// Factory "morphs" into a Pudding class.
// The reasoning is that calling load in each context
// is cumbersome.

(function() {

  var contract_data = {
    abi: {{ABI}},
    binary: "{{BINARY}}",
    unlinked_binary: "{{UNLINKED_BINARY}}",
    address: "{{ADDRESS}}",
    generated_with: "{{PUDDING_VERSION}}",
    contract_name: "{{NAME}}"
  };

  .....

  if (typeof module != "undefined" && typeof module.exports != "undefined") {
    module.exports = Contract;
  } else {
    // There will only be one version of Pudding in the browser,
    // and we can use that.
    window.{{NAME}} = Contract;
  }

})();

Great catch. This will require a change in Pudding. Not entirely sure how this sat unfound for so long.
Should have fix soon.

Should be fixed in https://github.com/ConsenSys/truffle/commit/01d0cea2e0d97410afcdb9a20a0dbcae190557c2. Can you pull from master and give it a shot?

After the changes, on my machine:

@cdetrio I'm going to mark this as closed. Let me know if you still see the issue!


Visuals of the plugin

Hi!
From reading it looks like something we might be interested in! But would it be possible to show some images of the fronted aspects to get a more visual grasp of the plugin and its possibilities?
Br Bandgren

@Bandgren : Thanks for reporting this. Yes, we will do another release this week to add the images of the frontend aspects of the plugin. Will let you know once done over this thread

@shanthisagar-dhanya-kumar-db that sounds perfect! Thank you!

@Bandgren : I have added the image now.

Images are added


NBGL usage improvment

Hello @chris124567, just wanted to let you known that now there is a force_page_start parameter https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_nbgl/include/nbgl_content.h#L108 that can be used to do what you need to do here:
https://github.com/SiaFoundation/app-sia-x/blob/master/src/calcTxnHash_nbgl.c
That should allow you to use nbgl_useCaseStaticReview (with the callback: https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_nbgl/include/nbgl_content.h#L126) instead of nbgl_useCaseRegularReview which is not recommended.

I started implementing this, but I realized If we were to do this we would have to store the full formatted data in memory to actually create the array of nbgl_contentTagValue_t pairs that you pass to nbgl_useCaseStaticReview.  Currently we only store the encoded data all together in the txn_elem_t array and use bin2dec/cur2dec in fmtTxnElem to create human readable representations as needed.  If we had to decode everything upfront we would need more memory (probably 2-3x) and mean we have to lower MAX_ELEMS to ensure everything can fit.  So the app would lose support for some large transactions.


TOC links to practice problems

The links in the table of contents for the practice problems in each chapter instead link to the last section heading, instead of to the exercises. (This is typically a page or two before where it should link to.)

Figured it out. A /phantomsection in the stylesheet is the solution. (I'm currently making a number of changes and will push 2.0, including this fix, soon.)


[WIP] Copy locale/manageiq.pot to locale/en/manageiq.po (English locale only)

via git checkout a468cb9 -- locale/manageiq.pot
cp locale/manageiq.pot locale/en/manageiq.po
This PR (English only) will attempt to recreate the following pull requests, by first demonstrating the https://github.com/ManageIQ/manageiq/pull/21779 will detect the previous failures that led to the revert of these changes:
https://github.com/ManageIQ/manageiq/pull/21769
https://github.com/ManageIQ/manageiq-providers-ibm_cic/pull/9
These PRs were split here for the English part.  https://github.com/ManageIQ/manageiq/pull/21784 contains the other locales.
TODO:

[ ] Ibm Cic rename -> IBM CIC commit from https://github.com/ManageIQ/manageiq/pull/21788 is included... will rebase once that is merged
[x] Demonstrate the original a468cb9 change to commit the po file as the template leads to a test failure
[ ] Fix it

This pull request just says that we hacked this one key.
Lets just update the pot file.
Seems we should be more focused on the future process which will be converting the manageiq.pot to en/manageiq.po

@jrafanie I also expected this to be changed in the pot file.  Was that done in the other Pr and this is just copying over English?

Right, so I don't know what the process should be for this part.  I don't know how to generate the rake local:update_all again now to try to match up what was generated in https://github.com/ManageIQ/manageiq/pull/21769.
The intention was to split the English vs. non-English so I went with the pot file at a468cb9.  Then, I was going to copy it to the po file, recreate the error with invalid header fields, and then fix them.
I'll have to think about this.

My suggestion is to fix just this one message manually and then, in a future PR, generate the locale/manageiq.pot file via rake locale:update_all along with its English counterpart - locale/en/manageiq.po

My suggestion is to fix just this one message manually (so that it can be backported to Najdorf) and then, in a future PR, generate the locale/manageiq.pot file via rake locale:update_all along with its English counterpart - locale/en/manageiq.po

Do the English po/pot need to generated "close" to the same point in time as the translations?
Either way, I can split off the CIC rename into a separate PR.

Either way, I can split off the CIC rename into a separate PR.

Maybe that is a good idea to make the intent clearer

  1) I18n msgfmt on locale/en/manageiq.po succeeds
     Failure/Error: expect(result.success?).to be_truthy, "msgfmt failed with the following errors:\n\n#{result.error.indent(2)}"

       msgfmt failed with the following errors:

         msgfmt: locale/en/manageiq.po: warning: PO file header fuzzy
                                        warning: older versions of msgfmt will give an error on this
         locale/en/manageiq.po:8: invalid nplurals value
         locale/en/manageiq.po:8: warning: header field 'Last-Translator' still has the initial default value
         locale/en/manageiq.po:8: warning: header field 'Language-Team' still has the initial default value
         locale/en/manageiq.po:8: warning: header field 'Language' still has the initial default value
         msgfmt: found 2 fatal errors
     # ./spec/i18n/msgfmt_spec.rb:14:in `block (3 levels) in <top (required)>'

  2) locale_name all languages have properly set locale_name
     Failure/Error: expect(locale_name).not_to eq('locale_name')

       expected: value != "locale_name"
            got: "locale_name"

       (compared using ==)
     # ./spec/i18n/locale_name_spec.rb:6:in `block (4 levels) in <top (required)>'
     # ./spec/i18n/locale_name_spec.rb:4:in `block (3 levels) in <top (required)>'
     # ./spec/i18n/locale_name_spec.rb:3:in `each'
     # ./spec/i18n/locale_name_spec.rb:3:in `block (2 levels) in <top (required)>'

These are the local and github action failures before I push the fix to the headers 👆

One second... I'm dropping "the Ibm Cic rename commit" as we it won't be merged ahead of time since it's a cleanup type thing on top of the main translation updates.

[x] Fix it

Finished in 9 minutes 12 seconds (files took 36.3 seconds to load)
11839 examples, 0 failures, 4 pending

Looks good.  unWIP when ready

Backported to najdorf via https://github.com/ManageIQ/manageiq/pull/21875


Can't keep connection two services with network cni rancher

Rancher versions:
rancher/server: 1.6.3
rancher/agent:
Hi team,
I have 2 services A and B. Service A connect to service B via socket connection(IPsec rancher network). But It connection can't keep in 5min. Before I used rancher/server:1.1.4 is not fail in this case.
Please help or give me a advice.
Thanks.

Thanks for your report!
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
If you think we should keep this issue open, please let me know.


Need a good way to build a great design

Although I got good at judging design (and designers) I haven't lately had time to do the design myself, so I need a good systemmatic way of do a great design here.

https://lawsofux.com/

This should come to the rescue: https://websim.ai/
If I'm lucky it deals with all the design implementation nonsense for me.

It'd be cool if on top of the traditional leaderboard the 1st, 2nd and 3rd would be in a podium, something like this:

Let's also attempt some first principles thinking here. What's really the point of this? Design must follow function. During my previous works on Bitcoin wallets and other projects the function was clear. I have been always building tools. But this is a game, not a tool. It's new territory for me. What's the point of this game? To get as many people to play as many possible.
It can be achieved by 1. optimizing the onboarding process and 2. making the game as fun as possible.
Everything start by joining the game, so shall I. This gives me the primary purpose of the landing page: to maximize the number of visitors joining the game. So.. How do I do that?

Let's make it as a personal lerning journey.

read the Laws of UX book carefully
memorize the Laws of UX
design website with websim

After the website design is done, go through it and check for each law and make modifications.


Add Aqara Climate Sensor W100

This device has a Temperature Sensor(0x0302), a Humidity Sensor(0x0307), and 3 Generic Switchs(0x000F).
Check all that apply
Type of Change

[X] WWST Certification Request

If this is your first time contributing code:

[ ] I have reviewed the README.md file
[ ] I have reviewed the CODE_OF_CONDUCT.md file
[ ] I have signed the CLA

[X] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com

[ ] Bug fix
[X] New feature
[ ] Refactor

Checklist

[X] I have performed a self-review of my code
[X] I have commented my code in hard-to-understand areas
[X] I have verified my changes by testing with a device or have communicated a plan for testing
[X] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change
As the first type of device with buttons in the sensor device, button feature is added to the sensor EdgeDriver
Summary of Completed Tests
Successful test for Plugin UI and Dashboard update according to the change of sensor or button operation

Since the matter-switch driver is the most complete and vast of our drivers, I believe it would be more prudent to include new humidity and temperature support in matter-switch rather than including the whole array of switch logic in matter-sensor.


the auto pagination and pagination doesn't work properly when i render views dynamically

Which OS ?android
Version
Which versions are you using:

react-native-swiper v? @1.5.13
react-native v0.?.?0.55.4

Expected behaviour
work normally when views are rendered dynamically by map
Actual behaviour
the auto pagination and  pagination index (dots) doesn't work properly when i render views dynamically. despite i specified key property
    <View style={{ height: 150, marginTop: 11, margin: 11 }}>
                <Swiper style={styles.wrapper} showsButtons={false} autoplay={true} activeDotColor='white'>
                    {this.state.SliderResults.map((data, key) => {

                        return (

                            <View key={key} style={{ flex: 1, backgroundColor: 'red' }}>
                                <ImageBackground source={{ uri: data.img }} style={{ height: 200, width: null, flex: 1, paddingBottom: 25 }}>
                                    <View style={{ flex: 1, justifyContent: 'flex-end', paddingRight: 20 }}>
                                        <Text style={styles.text} >{data.title}</Text>
                                        <TouchableHighlight style={{ height: 50, width: 150, alignSelf: 'flex-end', borderRadius: 2 }}>
                                            <LinearGradient colors={['#EF7D2F', '#C8191A']}>
                                                <Text style={{ fontFamily: 'IRANSans', color: 'white', alignSelf: 'center', fontSize: 14 }}>menu</Text>
                                            </LinearGradient>
                                        </TouchableHighlight>
                                    </View>
                                </ImageBackground>
                            </View>
                        );
                    })}
                </Swiper>
            </View>

auto play pagination is working just one time!!!! and dot index is not set correct
...
when i use some static state  like
this.setState({
             items: [
               { title: 'Hello Swiper'},
               { title: 'Beautiful'},
               { title: 'And simple'}
             ]
          })

every thing works ... but when i set state from fetched data, auto play doesn't work

so i think this is some thing like a bug but this solution worked for meeee

I tried what described in #701 but the autoplay still doesn't work :/


Add sparse union-find, fix union_find.hh, and add a test for union-find.

Thank you!  I am merging your PL to the dev branch for now.  Will merge dev to master once we are close to the next release.


[Bug] Revisit Lootrandomisers

Describe the bug
Found a stack of 0 copper ingots in a heavily collapsed chest in a basement ruin.
Expected behavior
Not be 0 xD.
Which Vintage-Story Version are you using:
v1.17.3
Additional context
Comment on modDB from Hexedian.

This is a vanilla issue which can result in a 0 copper ingot stack

I reported it to the devs and im going to replace it with a custom randomiser.

Got fixed with 1.17.5


Report differing file names

Thanks for making this library, it's really useful! The only complaint I have is that my typical use case is to make one single test which iterates over all the files in a directory and checks some operation on them, so currently it's a bit difficult to tell which file is the culprit when that test fails. This PR modifies your two default differs so they print the filename.

Thanks for the PR and sorry for the slow reply! I'm traveling abroad with
no laptop until Sep 8, but I'll merge this as soon as I'm back if it looks
good!
On Wed, Aug 7, 2024, 18:42 Sam Estep @.***> wrote:

Thanks for making this library, it's really useful! The only complaint I
have is that my typical use case is to make one single test which iterates
over all the files in a directory and checks some operation on them, so
currently it's a bit difficult to tell which file is the culprit when that
test fails. This PR modifies your two default differs so they print the
filename.
You can view, comment on, or merge this pull request online at:
https://github.com/calder/rust-goldenfile/pull/10
Commit Summary

a8d1e81
https://github.com/calder/rust-goldenfile/pull/10/commits/a8d1e811f1c139d5e706ad9a91148609950774b3
Report differing file names

File Changes
(1 file https://github.com/calder/rust-goldenfile/pull/10/files)

M src/differs.rs
https://github.com/calder/rust-goldenfile/pull/10/files#diff-0bca8a1ae6e5da5720a9d1f71c89e0050ebfe5a93ce8cf6ad9b92256bea0b117
(4)

Patch Links:

https://github.com/calder/rust-goldenfile/pull/10.patch
https://github.com/calder/rust-goldenfile/pull/10.diff

—
Reply to this email directly, view it on GitHub
https://github.com/calder/rust-goldenfile/pull/10, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMX7QC5YZ4NJL27IBRVIDZQJFAHAVCNFSM6AAAAABMEZC65KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TGOJQGUYDMMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Looks great, merged and published 1.7.2 (and 1.7.3 with updated dependencies). Thanks for the contribution!

Thanks so much @calder, I'm updating my projects to use the latest version! Also by the way, I was a bit curious why you published version 1.7.3 after updating Cargo.lock, instead of just leaving it at version 1.7.2; as far as I can tell, Cargo.lock is only used for local development or when someone installs a binary crate via cargo install --locked, but I don't think the latter applies in this case.

However, this determinism can give a false sense of security because Cargo.lock does not affect the consumers of your package, only Cargo.toml does that. For example:

cargo install will select the latest dependencies unless --locked is passed in.
New dependencies, like those added with cargo add, will be locked to the latest version

Ah thanks, you're totally right!


Intellisense for functions signatures

When I use a built in function and press ctrl+space inside the parenthesis, I expect to be able to subsequently ctrl+space my way through to argument completion. However, I'm only given an error about the number of arguments, not their name or type

Desired functionality does semi-arise when I specify correct number of arguments, at which type checking kicks in. However, I still have no idea what the parameter names are.

Desired Functionality
Ctrl + space carries me to completion without needing to refer to any documentation online.

Dup of #284


feat: make func schema if config updated

Changes
🎁 integrates new schema generator into core build targets
Invokes schema generation on make when:

config.go modified
after a make clean

Also includes an explicit target for the exact file as well via make schema/func_yaml-schema.json
/kind enhancement

/approve


[fix] update resnet ckpt url

Thank you for your contribution to the MindCV repo.
Before submitting this PR, please make sure:

[x] You have read the Contributing Guidelines on pull requests
[x] Your code builds clean without any errors or warnings
[x] You are using approved terminology
[ ] You have added unit tests

Motivation
update resnet ckpt url
(Write your motivation for proposed changes here.)
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
#539
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

Hi, may I ask what content in the ckpt is changed after changing the url? Because it affects the downstream task, and the pretrain weight depends on the original one. Much thanks!

The new url has higher accuracy and conforms to the accuracy display on read  @zhtmike


Error building DAWN-2018-02-14 on macOS

the script mentioned in the doc ./eosio_build.sh didn't exist under the tag
try using build.sh darwin or build manually, will finally failed at the step configure, the message is

-- Git commit revision: bcb5bf75
-- Found bsoncxx headers: /usr/local/include/bsoncxx/v_noabi
-- Found bsoncxx library: EOS_LIBBSONCXX-NOTFOUND
-- Found mongocxx headers: /usr/local/include/mongocxx/v_noabi;/usr/local/include/bsoncxx/v_noabi
-- Found mongocxx library: EOS_LIBMONGOCXX-NOTFOUND
-- Found Doxygen: /usr/local/bin/doxygen (found version "1.8.14") found components:  doxygen dot
-- Doxygen found.  Contract documentation will be generated.
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
EOS_LIBBSONCXX
    linked by target "db_plugin" in directory /Users/x/x/x/eos/plugins/db_plugin
EOS_LIBMONGOCXX
    linked by target "db_plugin" in directory /Users/x/x/x/eos/plugins/db_plugin

any ideas on how to build it successfully from macOS ? thanks

for those not familiar with cmake, appending:
-DEOS_LIBBSONCXX=/usr/local/lib/libbsoncxx.dylib -DEOS_LIBMONGOCXX=/usr/local/lib/libmongocxx.dylib

I have got the same problem,Could someone fix it ?

I have got the same problem on Ubuntu  branch DAWN-2018-02-14
-- Configuring AppBase on Linux
CMake Error at libraries/appbase/CMakeLists.txt:59 (install):
install TARGETS given no ARCHIVE DESTINATION for static library target
"appbase".
  Contract documentation will not be generated.
-- Configuring incomplete, errors occurred!
See also "/home/liao/eos/build/CMakeFiles/CMakeOutput.log"

@arrui try adding there options to cmake
-DEOS_LIBBSONCXX=/usr/local/lib/libbsoncxx.dylib -DEOS_LIBMONGOCXX=/usr/local/lib/libmongocxx.dylib

@hsx-ljg it's not the same issue.
you are missing DOXYGEN instead of MONGO driver, please install doxygen and retry

install TARGETS given no ARCHIVE DESTINATION for static library target

This error is due to you needing to update you git submodules
$ git submodule init
$ git submodule update

I've solved this error by change CMakeList.txt file.
This error is duplicate with this:
https://github.com/EOSIO/eos/issues/1601

brew install gcc


PatristicDistanceMatrix

Hi,
I have a script that uses PatristicDistanceMatrix. I found it does not work on 4.1 and I looked and it says legacy: will soon be deprecated. I tried using patristic_distance but since I use the whole tree this was much slower.
Jim

As the deprecation message should have indicated, you can use the PhylogeneticDistanceMatrix instead:  http://dendropy.org/primer/phylogenetic_distances.html

Thanks. That works.
On 03/21/2016 04:43 PM, Jeet Sukumaran wrote:

As the deprecation message should have indicated, you can use the
|PhylogeneticDistanceMatrix| instead:
http://dendropy.org/primer/phylogenetic_distances.html
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/jeetsukumaran/DendroPy/issues/45#issuecomment-199471903

--
James B. White
Cary, NC
919-380-9615
http://whitecodingandmaps.com


bug: "Failed to fetch filter key extractor tables" causing compaction task to fail until restarting meta node

Describe the bug
We see these message flooding the compactor log and compaction tasks keeps failing until meta node restart
"Failed to fetch filter key extractor tables [{35157}. [[35157]] may be removed by meta-service. "

Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
1.5.1
Additional context
No response

It happened once before. I suspect there is a code path that a failed/cancelled stream job doesn't notify hummock manager.

duplicate of #15144

May be related: https://github.com/risingwavelabs/risingwave/pull/15355. Do we know whether this issue can occur without https://github.com/risingwavelabs/risingwave/pull/15355? cc @zwang28

There have been quite some changes between v1.5.1 when this issue occurred, and latest v1.7.
I'll look into it in v1.7.


Initial revert on conformation page

Part of the story, the rest is changing the loginpage on gitlab.

LGTM


[updatecli] Update jenkins-wiki-exporter docker tag version to v1.10.3

Changelog
Release published on the 2020-08-23 19:16:47 +0000 UTC at the url https://github.com/jenkins-infra/jenkins-wiki-exporter/releases/tag/v1.10.3

Switch to the new buildDockerAndPublishImage so it can run on infra.ci.jenkins.io (#129) @halkeye

📦 Dependency updates

Bump talkback from 2.2.0 to 2.2.1 (#122) @dependabot
Bump @sentry/node from 5.20.1 to 5.21.1 (#130) @dependabot
Bump np from 6.3.2 to 6.4.0 (#128) @dependabot
Bump jest from 26.2.2 to 26.4.0 (#131) @dependabot
Bump eslint from 7.6.0 to 7.7.0 (#132) @dependabot
Bump node from 14.7.0 to 14.8.0 (#133) @dependabot
Bump archiver from 4.0.1 to 5.0.0 (#123) @dependabot

Reports
Source:
	✔  (githubRelease)

Condition:
	✔  Docker Image Published on Registry(dockerImage)

Remark
This pull request was automatically created using olblak/updatecli.
Please report any issues with this tool here

Yay! okay, so reading the code for updatecli
It needs the dockerhub tag to match the github release. This matches what is done on infra.ci.jenkins.io, so \o/ 🎉


a question on to_switch_off = [32, 16, 8]

I have a qusetions on list to_switch_off = [32, 16, 8]. the element in to_switch_off is 32，16，8，can you tell me the
reason? It representative FASTgres𝑐𝑜𝑎𝑟𝑠，FASTgres𝑡𝑎𝑏𝑙，FASTgres𝑓𝑖𝑛𝑒  ？If not，can you tell me why？

Hey there, thanks for interest in our project! With to_switch_off you probably mean the list generate_labels.py script. This script is used to build the necessary labels for FASTgres to be trained upon. to_switch_off  specifically, is an option that allows us to restrict to three hints only, which can be used to generate labels on a coarser level.
This script is not related to the presented approaches of coarse, table, and fine. These components are reflected in query.py and context_heuristic.py, even though we tested only on the finest approach fine using the implementation provided in query.py.

Tanks for you reponse，it is  a great project !  If i want ，i can replace 32，16，8，into the other three bumbers ,such as 1，2,3？

The hint representation follows one hot encoding. When you consider six hints, each hint has the binary form, e.g., [0, 1, 0, 0, 0, 0]. So each hint has a decimal representation that corresponds to 2^i, e.g., [1, 0, 0, 0, 0, 0] -> 2^0 = 1 and so on. You can change those numbers to any exponent of 2^i where i is between 0 and 5. The available options are thus: 1, 2, 4, 8, 16, 32.
Something like 3 does not work, because it is [1, 1, 0, 0, 0, 0] which is a set of hints rather than just one hint. For labeling, we specify only hints to consider. The algorithm tries each combination of the chosen hints.
For this example, you can also choose more or less than three values. If you choose all six hints, this is similar to no restriction at all. If you choose something like: 1, 32 -> only two hints are considered. Thus the search space for each query is 4 combinations.
I hope this helps!


Colors of HTML tag content in JSX

The color of content of HTML tags differ between .html files and .js files when using JSX
HTML:

JSX:

I solved this by adding this block of code in my settings.json:
"editor.tokenColorCustomizations": {
  "[JetBrains Darcula Theme]": {
    "textMateRules": [
      {
        "scope": ["meta.jsx.children"],
        "settings": {
          "foreground": "#A9B7C6"
        }
      }
    ]
  }
},

I think it would be nice to have this by default in the theme. I didn't want to make a PR yet because I don't know if you have some standard in your theme file, but if you point me a direction I'll gladly do it. :)

Thanks,
fixed and it will be included in the next update.


I crashed the server with invalid input.

I think I crashed the server.  Try this repro:

Make a new user account  Put an invalid phone number, I put 999
Click on your user profile on the top right to add skills to your profile
at the bottom of the page add three skills using the + button
try to submit.  It should prompt you with all the info that is invalid
Click reload button at the top of the browser
Crash

This was a report of some of the testing that was happening around Tuesday night. We don't know that this is what actually caused the infinite loops, but I asked him to enter the issue in the event that it helps troubleshoot the skills related infinite loop that we created with some bit of Data Tuesday night.

@wadewachs I just tried to reproduce this locally and could not. When I hit the submit button, I was was prompted to fill in the info that was missing.

This was a report of one of the things that was going on Tuesday night around the time we crashed the server. It is possible this is a red herring, and not the actual cause. I had Jonathan report this as an issue in the event it helped track things down. If following the steps doesn't create the infinite loop failure, feel free to close this issue.

Thx @mgmccarthy for verifying.  I gave the db that causes the infinite loop to @misterjames as we don't know the cause but was pretty sure it wasn't this specifically/alone


README.md: Note about OS versions and hardware

On some hardware, you won't be allowed to download older OS versions. Noting this and that you can work around this by downloading on older hardware.

Thanks for this clarification! I'll merge it then clean it up a little for easier reading.

Cool, no problem!


[WIP] Adding Cloud Pipelines

do not merge this is a draft pull request!
This PR will encompass early work to add Google Cloud Pipelines to Snakemake. Specifically this means that:

the user selects --google-life-sciences provider (boolean) when running snakemake
GOOGLE_APPLICATION_CREDENTIALS and GOOGLE_PROJECT should be exported
a content hash named tarball of the working directory is uploaded to Google Storage
the worker uses a custom image to download and extract the working directory, and then run the script for the step in question.
the storage tarballs are deleted after the workflow completes, only if the user hasn't specified a flag to keep the cache.

We have several technical questions that still need answering, which I'll summarize here:

upload of environment variables vs. secrets
another method to discover application credentials and project (without exporting the envar)
how to provide an entrypoint + command with && (we've tried almost all variations of this and the second command seems to run outside of the container, or the entire thing is parsed together and the result is command not found.
privileged containers OR custom addition of permissions (to allow running Singularity)
difference between action and resource environment
it would be cool if Google provided a function to choose a machine type based on these criteria, seems like it would be a common thing to need!

A few notes for some choices I made for the implementation:

As discussed in our meeting, I was able to use the Google Discovery Build function against the manifest endpoint to create a client.
regions is another variable that could be derived from some call to the API (to get a default region) but most likely the requester for storage objects would want to choose a region that is closest to the objects, which might not be where he or she is. The default regions are all zones in the US, which I chose based on guessing that the majority of Snakemake / GCP users are in the US. This might be entirely wrong, or a bad default.
the machine type is selected based on comparing the requested memory and cores to those available, and first eliminating the ones that are too small, and then choosing the smallest of those remaining. If the user provides a machine type prefix, we further filter down the choices to that.
Google Storage (for public objects) often has a 503 error (yesterday it popped up several times for me in testing) and if this happens again it might be a separate issue that the GS remote should look into handling - for most Google Cloud API stuffs retrying is essential.
speaking of retrying - the functions here are run by a client function I wrote to retry three times, and only then error. This is because BrokenPipeError (and other random failures) are common enough to warrant it.

I suspect this will fail linting and I'll push again with fixes :)

@johanneskoester this is a little confusing with black, because I installed the exact version that is run in the test suites, and there seems to be a difference in result. Here is what I'm doing locally:
$ black --check snakemake tests/*.py
All done! ✨ 🍰 ✨
51 files would be left unchanged.
$ black --version
black, version 19.3b0

Note that the version is the same installed there. I also tried installing with conda in case it made a difference (it didn't). What am I missing?

That's so weird! The black formatting passed this time. I don't think I made any changes to that file. Must be ghosties.

@vsoch did you select a draft PR? I still have a merge button here and the icon is green instead of grey in the list.

oops I just totally forgot :/ Merging is still blocked so is it okay? I'll add WIP to the heading so others know.

Yeah, no problem ;-).

xref #91

Updates to the PR:
Environment variables cannot be secrets
Andrew confirmed that since the underlying service is Google Compute Engine, we can't take advantage of secrets as we can with kubernetes. We should generally keep on top of this, and perhaps later brainstorm if other way could be used to allow for secrets. I'll add this to a little TODO list that I'll share in the project space after.
Pipeline vs Action environment
I asked about the difference between Action / overall pipeline environment, and it's the case that every pipeline environment is passed to each action, and then an action can have it's own environment. Since we are defining actions per step for snakemake, it makes most sense to just add the environment variables that are needed there. I don't see a compelling use case here for using a pipeline environment instead. The one interesting detail is that an action cannot delete a pipeline environment, so I suspect pipeline environments would be appropriate if there is some service running a user workflow (and the user workflow shouldn't be allowed to mess with some parent environment). It doesn't seem hugely important here, but we can keep it in mind if the need arises.
Machine Types
Andrew pointed me to the compute engine API to get machine types that we can use instead of hard coding a list. The machineType list endpoint requires a specific zone, and the Life Sciences API allows the user to request a region, which is one or more zones (and would need to be derived from the region).
So to make this work, it comes down to:

taking the user requested regions, and then using the compute engine api (zones endpoint) to derive zones available for the requested regions
deriving the machineTypes for those zones
taking the set that is shared between all of them (otherwise we risk an error of getting an instance type not provided in a zone.)

I added a user debug statement that says "Hey if you want more selection, then you need to select fewer regions." I think this approach is ok, and better than having the user select a zone, because the pipelines API expects a region, and if we derive a region from a user zone (e.g., user selects us-east1-a and we derive region us-east1 for the API) then we could hit an issue if the API allocates the instance to us-east1-b with some instance type only supported in us-east1-a. Anyhoo, I've deleted the custom function to derive the machineType, and it's now totally programmatic based on what the compute engine API says is available.
Singularity
We probably won't get Singularity working any time soon:

Privileged Containers: I don’t believe those are exposed in the API, and not sure if there’s a plan to.

I'm waiting on answers about the CMD/entrypoint but I'll update again when I hear!

@johanneskoester a test failed for test_remote which I don't think is related to the PR here, is this a one off error because of GitHub actions (and I should ignore and it can be re-run) or some issue that I can address in the PR here?

I'm not sure about this Sonar addition - these failures didn't show up for the other pushes. :/

@johanneskoester I'm not sure how to address the remaining "code smells" and security checks, they don't seem like terrible issues but the tool seems to think so.

@johanneskoester test_issue635 is failing in testing, it's not associated with this PR.

woo my code isn't as smelly! :tada: I suspect the test will still fail, let me know if this is something related to the PR here.

@johanneskoester I accidentally ran black to format all the files in test - it's not necessary (and won't hurt) but just wanted to let you know when you see they have been changed.

@johanneskoester the merge from master broke the branch, I'm going to see if I can fix it.

@johanneskoester it's failing again with the merge with master, totally unrelated to my PR. I don't know how to address that so I'm going to leave it be. How are things being merged into master that don't pass?

Note that error is still with respect to aws credentials:

Run aws-actions/configure-aws-credentials@v1
##[error]Input required and not supplied: aws-access-key-id
##[error]Node run failed with exit code 1

Hmm, there seems to be a larger issue that extra arguments (e.g., --skip-cleanup-scripts) aren't passed to the executor. Looking at CPUExecutor and ClusterExecutor, there is repeated code to add these arguments to self.exec_job. I'm out of steam today but want to test this interactively tomorrow and I'll update the PR here with a solution (and hopefully resolve this new bug that just popped up!)

I rebased with master, and there is some newly introduced error that isn't finding a singularity container to use (which looks like it was defined for the workflow?)
Traceback (most recent call last):
  File "/home/vanessa/snakemake-work/snakemake/snakemake/__init__.py", line 680, in snakemake
    keepincomplete=keep_incomplete,
  File "/home/vanessa/snakemake-work/snakemake/snakemake/workflow.py", line 895, in execute
    success = scheduler.schedule()
  File "/home/vanessa/snakemake-work/snakemake/snakemake/scheduler.py", line 408, in schedule
    self.run(job)
  File "/home/vanessa/snakemake-work/snakemake/snakemake/scheduler.py", line 427, in run
    error_callback=self._error,
  File "/home/vanessa/snakemake-work/snakemake/snakemake/executors.py", line 2763, in run
    if job.needs_singularity and self.workflow.use_singularity:
  File "/home/vanessa/snakemake-work/snakemake/snakemake/jobs.py", line 307, in needs_singularity
    return self.container_img is not None
  File "/home/vanessa/snakemake-work/snakemake/snakemake/jobs.py", line 316, in container_img
    return self.dag.container_imgs[self.container_img_url]
KeyError: 'docker://continuumio/miniconda3'

The change was made here https://github.com/snakemake/snakemake/commit/f7041f963d0219eb07c558a6ebb708a1cf9ea7bb#diff-c923148fbfa18c64d8a76ab68afd7b79R390 @johanneskoester please advise.

Thanks for reporting. Issue found, fix is on the way.

Woot! This sounds good to me :)

phew, the SonarCloud errors were alarming - like missing urllib3 import, and a spelling error... dinosaur screams

okay, I've just added support for GPUs, along with documentation to show the user how to add nvidia_gpu or just gpu to get the requested GPUs. I used the following Snakefile (the one in the current test_google_lifesciences folder) modified to ask for GPU:
import os

# This test file is taken from Kubernetes - both use Google Cloud
from snakemake.remote.GS import RemoteProvider as GSRemoteProvider
GS = GSRemoteProvider()

rule all:
    input:
        "landsat-data.txt.bz2"

rule copy:
    input:
        GS.remote("gcp-public-data-landsat/LC08/01/001/003/LC08_L1GT_001003_20170430_20170501_01_RT/LC08_L1GT_001003_20170430_20170501_01_RT_MTL.txt")
    output:
        "landsat-data.txt"
    resources:
        mem_mb=100,nvidia_gpu=1
    run:
        # we could test volume size like this but it is currently unclear what f1-micro instances provide as boot disk size
        #stats = os.statvfs('.')
        #volume_gib = stats.f_bsize * stats.f_blocks / 1.074e9
        #assert volume_gib > 90
        shell("cp {input} {output}")

rule pack:
    input:
        "landsat-data.txt"
    output:
        "landsat-data.txt.bz2"
    conda:
        "env.yml"
    log:
        "logs/pack.log"
    shell:
        "bzip2 -c {input} > {output}; echo successful > {log}"

And then ran the test locally, here is the full output:
Building DAG of jobs...
Unable to retrieve additional files from git. This is not a git repository.
bucket=snakemake-testing
subdir=gpu
locations-available:
asia-northeast1
asia-southeast1
europe-west2
europe-west4
northamerica-northeast1
us
us-central1
us-west2
regions=['us-east1', 'us-west1', 'us-central1']
location=projects/snakemake-testing/locations/us-central1
container=snakemake/snakemake:v5.11.1
Using shell: /bin/bash
Provided cores:<PHONE_NUMBER>854775807
Rules claiming more threads will be scaled down.
Job counts:
	count	jobs
	1	all
	1	copy
	1	pack
	3
Resources before job selection: {'_cores':<PHONE_NUMBER>854775807, '_nodes': 1}
Ready jobs (1):
	copy
Selected jobs (1):
	copy
Resources after job selection: {'_cores':<PHONE_NUMBER>854775806, '_nodes': 0}

[Wed Apr  8 13:58:57 2020]
rule copy:
    input: gcp-public-data-landsat/LC08/01/001/003/LC08_L1GT_001003_20170430_20170501_01_RT/LC08_L1GT_001003_20170430_20170501_01_RT_MTL.txt
    output: snakemake-testing/gpu/landsat-data.txt
    jobid: 2
    resources: mem_mb=100, nvidia_gpu=1

build-package=source/cache/snakeworkdir-a560de7ca9adbabb53bdc4f2d878fe6fd1e3862bd7654e2b753af22d64952301.tar.gz
found resource request for 1 GPUs.
Using shell: /bin/bash
Provided cores: 2
Rules claiming more threads will be scaled down.
Job counts:
	count	jobs
	1	copy
	1

[Wed Apr  8 20:06:33 2020]
rule copy:
    input: gcp-public-data-landsat/LC08/01/001/003/LC08_L1GT_001003_20170430_20170501_01_RT/LC08_L1GT_001003_20170430_20170501_01_RT_MTL.txt
    output: snakemake-testing/gpu/landsat-data.txt
    jobid: 0
    resources: mem_mb=100, disk_mb=128000, nvidia_gpu=1

Downloading from remote: gcp-public-data-landsat/LC08/01/001/003/LC08_L1GT_001003_20170430_20170501_01_RT/LC08_L1GT_001003_20170430_20170501_01_RT_MTL.txt
Finished download.
Uploading to remote: snakemake-testing/gpu/landsat-data.txt
Finished upload.
[Wed Apr  8 20:06:33 2020]
Finished job 0.
1 of 1 steps (100%) done
Complete log: /workdir/.snakemake/log/2020-04-08T200632.429349.snakemake.log
Started running "snakejob-copy-2"
Stopped pulling "snakemake/snakemake:v5.11.1"
Started pulling "snakemake/snakemake:v5.11.1"
Worker "google-pipelines-worker-86c1515f7609c9d3024589b1eb709769" assigned in "us-central1-c"
[Wed Apr  8 14:06:39 2020]
Finished job 2.
1 of 3 steps (33%) done
Resources before job selection: {'_cores':<PHONE_NUMBER>854775807, '_nodes': 1}
Ready jobs (1):
	pack
Selected jobs (1):
	pack
Resources after job selection: {'_cores':<PHONE_NUMBER>854775806, '_nodes': 0}

[Wed Apr  8 14:06:39 2020]
rule pack:
    input: snakemake-testing/gpu/landsat-data.txt
    output: snakemake-testing/gpu/landsat-data.txt.bz2
    log: snakemake-testing/gpu/logs/pack.log
    jobid: 1

build-package=source/cache/snakeworkdir-4df7b55bc6e4cc04b671c896185c6119c593d78e0a2638f29b81bb6c712905b1.tar.gz
found 23 machine types across regions ['us-east1', 'us-west1', 'us-central1'] before filtering to increase selection, define fewer regions
Selected machine type n1-highmem-4:4 vCPUs, 26 GB RAM
Get status with:
gcloud config set project snakemake-testing
gcloud beta lifesciences operations describe<PHONE_NUMBER>141407592
gcloud beta lifesciences operations list
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Checking status for operation<PHONE_NUMBER>141407592
Worker released
Stopped running "snakejob-pack-1": ad.py’ saved [1246/1246]

Building DAG of jobs...
Creating conda environment env.yml...
Downloading and installing remote packages.
Environment for env.yml created (location: .snakemake/conda/0a062b8f)
Using shell: /bin/bash
Provided cores: 4
Rules claiming more threads will be scaled down.
Job counts:
	count	jobs
	1	pack
	1

[Wed Apr  8 20:08:39 2020]
rule pack:
    input: snakemake-testing/gpu/landsat-data.txt
    output: snakemake-testing/gpu/landsat-data.txt.bz2
    log: snakemake-testing/gpu/logs/pack.log
    jobid: 0
    resources: mem_mb=15360, disk_mb=128000

Downloading from remote: snakemake-testing/gpu/landsat-data.txt
Finished download.
Activating conda environment: /workdir/.snakemake/conda/0a062b8f
Uploading to remote: snakemake-testing/gpu/logs/pack.log
Finished upload.
Uploading to remote: snakemake-testing/gpu/landsat-data.txt.bz2
Finished upload.
[Wed Apr  8 20:08:42 2020]
Finished job 0.
1 of 1 steps (100%) done
Complete log: /workdir/.snakemake/log/2020-04-08T200810.279853.snakemake.log
Started running "snakejob-pack-1"
Stopped pulling "snakemake/snakemake:v5.11.1"
Started pulling "snakemake/snakemake:v5.11.1"
Worker "google-pipelines-worker-586b436d4afc893eb5411d03e7b639bd" assigned in "us-west1-b"
[Wed Apr  8 14:08:50 2020]
Finished job 1.
2 of 3 steps (67%) done
Resources before job selection: {'_cores':<PHONE_NUMBER>854775807, '_nodes': 1}
Ready jobs (1):
	all
Selected jobs (1):
	all
Resources after job selection: {'_cores':<PHONE_NUMBER>854775806, '_nodes': 0}

[Wed Apr  8 14:08:50 2020]
localrule all:
    input: snakemake-testing/gpu/landsat-data.txt.bz2
    jobid: 0

Downloading from remote: snakemake-testing/gpu/landsat-data.txt.bz2
Finished download.
[Wed Apr  8 14:08:51 2020]
Finished job 0.
3 of 3 steps (100%) done
Requested to save workflow sources, skipping cleanup.
Complete log: /tmp/snakemake-rbeot8k5/.snakemake

While testing, I made sure that the workers generated had GPUs:

@johanneskoester I'm not sure about this error (for another test)
-- Docs: https://docs.pytest.org/en/latest/warnings.html
=========================== short test summary info ============================
FAILED tests/tests.py::test_issue916 - AssertionError: expected successful ex...
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
= 1 failed, 150 passed, 10 skipped, 2 xpassed, 8 warnings in 400.61s (0:06:40) =
##[error]Process completed with exit code 1.

Works fine in master though.

cc #4mmvtk.

okay we're good! :tada: There is still the issue if the user puts some path for the Snakefile outside of the working directory - which then seems to derive other (non relative) paths that will break for a build package. Since this use case is rare, and we have to preserve a relative context, I'm going to push a check that will ensure the user does not make this mistake:
WorkflowError:
All source files must be present in the working directory, /tmp/snakemake-90q8a1_i to be uploaded to a build package that respects relative paths, but /home/vanessa/Desktop/Code/snakemake/snakemake/tests/test_google_lifesciences/env.yml was found outside of this directory. Please set your working directory accordingly, and the path of your Snakefile to be relative to it.
unlocking

Testing locally now, will update PR soon.

PR #329 introduces string resources. Please see the example in the PR for how I would like people to specify the gpu_model.

Thanks @johanneskoester ! I'll give this an update when we have feedback if we want to use machine or machine_type (I used machine, but I think @joonjeong suggested machine_type and it seems like it is more specific and might be another option, in case we need to add other machine_ prefix things in the future.

Just kidding! This is all set - the string variables are shown to be in quotes now: https://github.com/snakemake/snakemake/pull/90/commits/14148b5e02ba3690d44e02de95a789670adfc27d

So, this failed_precondition line still seems to be superflous to me. People can always get the full detail with describe, can't they? @moschetti is there any information in the returned error dict that we cannot get from the describe command?

@johanneskoester I agree with you - this message is typically that it exited with error code 1 and I haven't found it useful for debugging. I'm going to change to debug.

@johanneskoester once we rename the files and put them under an executors folder, it will almost be impossible to do any updates from master. So I think we should only do this at the very end, absolutely when everything else is good and we are ready for merge otherwise.

@johanneskoester I'll want to ask for your suggestions for how to reduce "cognitive complexity" of functions - I made them modular at a level I thought made sense, and most of the length for the ones flagged is due to really long WorkflowError messages. I'm happy to refactor in any way you think is better.

Not sure what is going on with the build container image step, but it's been going for over 2 hours.

That issue is resolved now.

@johanneskoester I'll want to ask for your suggestions for how to reduce "cognitive complexity" of functions - I made them modular at a level I thought made sense, and most of the length for the ones flagged is due to really long WorkflowError messages. I'm happy to refactor in any way you think is better.

I have looked at them again, and I think they are indeed ok to remain like this. Sorry for the noise.

GCloud credentials are now in place. I think you should be able to activate your test case here. In line with the kubernetes and tibanna tests, please move your test case in a separate file tests/test_google_life_sciences.py which shall be called in a separate job step.

@johanneskoester what is the name of the envar secret - did you just call it GOOGLE_APPLICATION_CREDENTIALS? I'm adding the step in main.yml now, should be able to push to test as soon as I know that name!

E.g., this is what I'd guess, let me know if I'm off
    env:
      AWS_AVAILABLE: ${{ secrets.AWS_ACCESS_KEY_ID }}
      GCP_AVAILABLE: ${{ secrets.GCP_SA_KEY }}
      GOOGLE_APPLICATION_CREDENTIALS: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }}

Dearest sonarcloud - you've had a change of heart! Because before you said my code was smelly. Maybe it's good smelly now :)

@johanneskoester the test did not run still - I can't see settings/secrets so I'll need your guidance about what needs to be checked.

You are on a fork. github does not expose secrets to forks.

Let us go on in PR #384


DB dump for dev - truncate instead of drop tables

Dropping the tables and then using them in local dev environment causes problems (for example when dropping a column of a specific table - just like we did in this pr - alembic upgrade head does not work locally)
Hence - instead of dropping tables when dumping the DB - perhaps it's possible to dump and then truncate the relevant user tables (and only then make it available after truncating so no one can see the users data?)

see related comment: https://github.com/hasadna/anyway/pull/1991#pullrequestreview-793729124

@OriHoch do you need anything from us to perform this ticket?
@BarVolunteering is the final list of tables known? Perhaps add it also here?

Tables list:
users
roles
locationsubscribers
users_to_roles
users_to_organizations
organization

no, I don't need anything

we cannot truncate the tables because the dump is performed on prod db
The solution I'm trying to implement is to have 2 dump files: one same as today without the tables, another one with only the schemas of the missing tables.

done, opened PRs: #2013, #2014


Conclusion

Insert a meme/image that represents your team's excitement and enthusiasm for Game of Learners
@Hezekiah-Elisha

On it.


Could not load file or assembly 'Microsoft.IdentityModel.Tokens, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.

Adding System.IdentityModel.Tokens.Jwt (5.4.0) nuget package in .NetStandard 2.0 class library project. Referencing this class library in ASP.NET API .NETFramework 4.7.2 I got an error:
Could not load file or assembly 'Microsoft.IdentityModel.Tokens, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.
I have to mention no problem in ASP.NET Core API, I just got the error in .NETFramework API.
And the code throw the error:
public ClaimsPrincipal ValidateSignedToken(string rawJwtToken)
{
    var validationParameters = GetTokenValidationParameters();
    var securityTokenHandler = new JwtSecurityTokenHandler();

    var claimPrincipal = securityTokenHandler.ValidateToken(rawJwtToken, validationParameters, out _);
    return claimPrincipal;
}

I add netstandard2.0;net461 in the csproj file. and solved

This is not a proper fix, took me some time to track it down.
Proper will be to adjust/expand project nuspect to cover 4.7 dependencies