Pressing esc with a selection, should clear the selection but keep the selected item

Testing #119118
Currently, pressing esc with a selection, clear it (👍) but it also resets the selected item so it looks like there is no selected item

Duplicate of https://github.com/microsoft/vscode/issues/118835 , which @joaomoreno already puts in April milestone.


feat(perf): adds SCU to FeaturePage (in lieu of PureComponent)

companion to #811
the FeaturePage component class slipped through the cracks of #811, since it used to be a functional component when pr was opened... however, since this page doesn't really fit the bill for PureComponent either (it's totally static) we can just add a shouldComponentUpdate that returns false
includes a little comment with explanation :)

Coverage decreased (-0.4%) to 98.77% when pulling cdc5973050f1073234fda8496d55432542e31e8c on justingreenberg:patch-2 into a6ea1ded0196bbe0ecb237f3c7656815c10d71a7 on mxstbr:dev.

Coverage decreased (-0.4%) to 98.77% when pulling cdc5973050f1073234fda8496d55432542e31e8c on justingreenberg:patch-2 into a6ea1ded0196bbe0ecb237f3c7656815c10d71a7 on mxstbr:dev.

That's a great idea @justingreenberg, love it!


Error when loading webpack-hot-client from a package that brings it in

Operating System: Windows 10 64-bit
Node Version: 8.11.3
yarn Version: 1.8.0
webpack Version: 4.16.0
webpack-hot-client Version: 4.1.1

Expected Behavior
Webpack-Hot-Client loads as usual.
Actual Behavior
ERROR in multi webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e react-hot-loader/patch ./app/entrypoints/client
Module not found: Error: Can't resolve 'webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e' in '[FULL PROJECT PATH]'
 @ multi webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e react-hot-loader/patch ./app/entrypoints/client app[0]

ERROR in multi webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e react-hot-loader/patch [NODE_MODULES_PATH]/app/entrypoints/clientTests
Module not found: Error: Can't resolve 'webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e' in '[FULL PROJECT PATH]'
 @ multi webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e react-hot-loader/patch ../apps-client-packages/app/entrypoints/clientTests tests[0]

ERROR in multi webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e react-hot-loader/patch ./app/entrypoints/angularJs
Module not found: Error: Can't resolve 'webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e' in '[FULL PROJECT PATH]'
 @ multi webpack-hot-client/client?4fabb837-9d08-4ee3-a3c2-5a114dfd758e react-hot-loader/patch ./app/entrypoints/angularJs angularJs[0]

I receive this error probably because the app I'm in brings in another package which itself has webpack-hot-client pulled in. It's looking in ./app instead of app. None of these files are in the relative root of the config file ./. For whatever reason, this works in the package, but not when the package is running from node_modules/.
Outputting the entrypoint paths, I'm seeing this:
client [FULL PROJECT PATH]\app\entrypoints\client
clientTests [NODE_MODULES PATH]\app\entrypoints\clientTests
angularJs [FULL PROJECT PATH]\app\entrypoints\angularJs

I don't exactly know what's going on here.
Code
index.js
require('app-module-path/register')
require('package-in-node-modules')

Package's index.js
require('app-module-path/register')
require('scripts/runWebpack')()

Package's Webpack config
  entry: {
    app: [
      'react-hot-loader/patch',
      '[FULL PROJECT PATH]\app\entrypoints\client',
    ],
    tests: [
      'react-hot-loader/patch',
      '[NODE_MODULES PATH]\app\entrypoints\clientTests',
    ],
    angularJs: [
      'react-hot-loader/patch',
      '[FULL PROJECT PATH]\app\entrypoints\angularJs',
   ],
  },

How Do We Reproduce?
Create an npm package that contains the webpack code and run that code from an app that uses that npm package. That's how I'm doing it at least. Seems to be the only difference between the two.

You win the prize for most issues on this repo in a day 🎉  I'm not sure what the prize will be, but I'll come up with something nice.
On a non-silly note, we've got a fair amount of tests and this module is used by webpack-serve fairly successfully but a few thousand daily users. I'm not saying that there isn't the possibility of issues with the module, but you seem to be running into quite a few that haven't previously been an issue. In getting this to work, you're reporting bug issues, but what you're looking for is support in getting this running in your environment - and that's something we don't provide here. There's an issue type explaining some support vectors that you can give a try as well.
We'll leave this open for discussion for a few weeks, but I would encourage you to try and find the source of an issue you run into, before opening an issue on the repo. Not bad vibes meant; using the issues as a message board for help isn't something we're down with, and why we point folks towards the Gitter and StackOverflow.


EdDSA fails to decrypt JWTs

Describe the bug
No matter which key format I use, I cannot use EdDSA to decode JWTs.
Error Stacks
ValueError: ('Could not deserialize key data. The data may be in an incorrect format, the provided password may be incorrect, it may be encrypted with an unsupported algorithm, or it may be an unsupported key type (e.g. EC curves with explicit parameters).', [<OpenSSLError(code=503841036, lib=60, reason=524556, reason_text=unsupported)>])

To Reproduce
Generate a JWT key using EdDSA and then attempt to decode it
Expected behavior
The key to decode
Environment:

OS: Fedora Linux 40 x86_64
Python Version: Python 3.12.4
Authlib Version: 1.3.1

Additional context
It seems to work fine in JoseRFC, but many projects still rely on authlib and both should still work.

Did https://jose.authlib.org/en/ work for you?

Yes


issue-1 Better path for calling python script

Pull request questions
Which issue does this address
ISSUE-1

#1


Add trusted query param. to incoming-transfers endpoint

Summary
This resolves #1206 by adding the trusted query param. from the history endpoint to the incoming-transfers one. The associated logic has been moved fromTransactionsHistoryMapper['mapTransfers'] into a new TransferMapper['mapTransfers'] method that accepts an onlyTrusted argument.
Changes

A trusted query param to TransactionsController['getIncomingTransfers']
Move trust-related filtering from TransactionsHistoryMapper['mapTransfers'] to TransferMapper['mapTransfers']
Migrate all usage of TransferMapper['mapTransfer'] to TransferMapper['mapTransfers']
Add/updated associated tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 18 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.719%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
6091

Relevant Lines:
6289

💛  - Coveralls


feat: Add support for custom root CA subject

Hi, first of all, thanks for creating minica! Finally a solution that doesn't make my head explode because of cryptic openssl commands.
I added the feature to declare a custom subject for the root CA by providing a JSON file with the necessary fields.
There's still an issue I don't know how to fix: The result looks like OU=,O=Frederic Hemberger,POSTALCODE=,STREET=,L=,ST=,C=DE if not all fields exist in the JSON file. Unfortunately, this gives me a parsing error on macOS because of the empty fields. Is there a way in Go to map only existing fields to avoid this?
I don't have much experience with Go, so I hope the code changes are not too far off.

Hi, first of all, thanks for creating minica! Finally a solution that doesn't make my head explode because of cryptic openssl commands.

 Thanks for the kind words, and sorry it's taken a while to get back to you.

I added the feature to declare a custom subject for the root CA by providing a JSON file with the necessary fields.

My goal with minica is to keep it radically simple. Right now it generates a random subject CN, as you've probably seen. Customizing the subject beyond that doesn't add compatibility, standards compliance, or features as far as I know, so my inclination is to not incorporate that into the main program. Please let me know if I'm wrong in that evaluation.
However, minica will load any file named minica.pem in the current directory, so you can definitely create your own self-signed root with another program (or, indeed, with a forked and modified copy of minica).

There's still an issue I don't know how to fix: The result looks like OU=,O=Frederic Hemberger,POSTALCODE=,STREET=,L=,ST=,C=DE if not all fields exist in the JSON file. Unfortunately, this gives me a parsing error on macOS because of the empty fields. Is there a way in Go to map only existing fields to avoid this?

You are unconditionally setting these fields to a one-element slice which sometimes contains an empty string:

  PostalCode:         []string{subject.PostalCode},

If you want the PostalCode field (for example) to be empty, you need to set it to nil, or possible an empty slice.

Thanks for your feedback, it helped a lot!
Closing.


[Question]: How to see the intermediate step in the response synthesis

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
After retrieving the most similar nodes to my query over my index, I want to inspect the intermediate steps in the response synthesis ( What context is used for each LLM call, and what is the associated answer generated, especially for the refined response mode), so that I can better understand how it works and why I don't have a final good result. Is it possible ?
Thanks in advance for your help !

You can enable logging for every llm input and output
import llama_index.core

llama_index.core.set_global_handler("simple")

You can enable logging for every llm input and output
import llama_index.core

llama_index.core.set_global_handler("simple")

Sorry, I'm not that familiar with logging. So after enabling logging info for llm how can I print them to the console ?


Reproducible builds for Android APK

Hello, Danny here from WalletScrutiny, I'm currently trying to reproducible build the Android app.
I've taken the Dockerfile build approach to emulate as much as possible the original build process.
I would love to have your feedback:
# Use the latest official Flutter Docker image as the base image.
# This image comes with Dart, Flutter, and fvm pre-installed.
FROM cirrusci/flutter:latest

# Set the working directory in the Docker container
WORKDIR /app

# Clone the necessary repositories with the specific branches as mentioned
# Note: You may need to adjust the following git clone commands according to your actual requirements.
RUN git clone -b pset_stable https://github.com/sideswap-io/gdk.git && \
    git clone https://github.com/AquaWalletIO/rust-elements-wrapper.git

# Install dependencies for Android development, including Cmake and NDK.
# Note: This step assumes that sdkmanager is available. You might need to adjust paths and versions accordingly.
RUN yes | sdkmanager --licenses && \
    sdkmanager --install "ndk;21.4.7075529" "cmake;<IP_ADDRESS>88404"

# Assuming the app's source code is in the current directory, copy it into the container.
# Ensure that .dockerignore is set up to exclude unnecessary files.
COPY . .

# Set the correct Flutter version for the project using fvm.
RUN fvm use

# Run the make setup command as specified. This will require having a Makefile at your app's root.
# Ensure the Makefile is properly configured to run without user interaction.
RUN make setup

# Add a custom script or command to build the app. This is a placeholder for whatever build steps are needed.
# For example, to build an APK:
RUN fvm flutter build apk

# To keep the container running and allow for debugging, interactive sessions, or further commands.
CMD ["sleep", "infinity"]

Hello, have not tested building it inside docker, but it should work.
Looking through the log, it looks like the commands are correct. Are you running into problems? Getting errors?
On a side note - we are working on reproducible builds + fdroid right now and should be available soon.

How is it going? I was poked to look into aqua reproducibility, too and wonder if there's any updated claims to reproducibility or if I should just try and see?

Trying without docker

Did you run make setup ?

https://github.com/AquaWallet/aqua-wallet/blob/main/DEVELOPMENT.md

Yes, and yes.
I tried again: https://pastebin.com/q4hAssUY

This was the result of an error on our part where we were not copying over some files to the public repo in the last update. This has been fixed. Could you do a git pull and try again?

This was the result of an error on our part where we were not copying over some files to the public repo. This has been fixed. Could you do a git pull and try again?

Will try again today.

The problem seems to be this:
 CMake Error at /usr/share/cmake-3.22/Modules/CMakeTestCCompiler.cmake:69 (message):
    The C compiler

      "/opt/android-sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang"

    is not able to compile a simple test program.

    It fails with the following output:

      Change Dir: /home/dannybuntu/work/builds/aqua-wallet/android/app/.cxx/Debug/414y3k4a/arm64-v8a/CMakeFiles/CMakeTmp

      Run Build Command(s):/opt/android-sdk/cmake/<IP_ADDRESS>88404/bin/ninja cmTC_23129 && [1/2] Building C object CMakeFiles/cmTC_23129.dir/testCCompiler.c.o
      [2/2] Linking C executable cmTC_23129
      FAILED: cmTC_23129
      : && /opt/android-sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang --target=aarch64-none-linux-android27 --sysroot=/opt/android-sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/sysroot -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions  -O2 -g -DNDEBUG -Wl,--build-id=sha1 -Wl,--no-rosegment -Wl,--fatal-warnings -Qunused-arguments -Wl,--no-undefined  -Wl,--gc-sections -B/snap/flutter/current/usr/lib/gcc/x86_64-linux-gnu/9 -B/snap/flutter/current/usr/lib/x86_64-linux-gnu -B/snap/flutter/current/lib/x86_64-linux-gnu -B/snap/flutter/current/usr/lib/ -L/snap/flutter/current/usr/lib/gcc/x86_64-linux-gnu/9 -L/snap/flutter/current/usr/lib/x86_64-linux-gnu -L/snap/flutter/current/lib/x86_64-linux-gnu -L/snap/flutter/current/usr/lib/ -lblkid -lgcrypt -llzma -llz4 -lgpg-error -luuid -lpthread -ldl -lepoxy -lfontconfig -B/snap/flutter/current/usr/lib/gcc/x86_64-linux-gnu/9 -B/snap/flutter/current/usr/lib/x86_64-linux-gnu -B/snap/flutter/current/lib/x86_64-linux-gnu -B/snap/flutter/current/usr/lib/ -L/snap/flutter/current/usr/lib/gcc/x86_64-linux-gnu/9 -L/snap/flutter/current/usr/lib/x86_64-linux-gnu -L/snap/flutter/current/lib/x86_64-linux-gnu -L/snap/flutter/current/usr/lib/ -lblkid -lgcrypt -llzma -llz4 -lgpg-error -luuid -lpthread -ldl -lepoxy -lfontconfig CMakeFiles/cmTC_23129.dir/testCCompiler.c.o -o cmTC_23129  -latomic -lm && :
      ld: error: --fix-cortex-a53-843419 is only supported on AArch64 targets
      clang: error: linker command failed with exit code 1 (use -v to see invocation)
      ninja: build stopped: subcommand failed.

Can you upgrade the NDK version to 25. and see if it fixes the problem?
sdk-manager --install "ndk;25.2.9519653"

Installed NDK 25.2.9519653,
and edited local.properties
$ fvm flutter run
Using hardware rendering with device sdk gphone x86. If you notice graphics artifacts, consider enabling software rendering with "--enable-software-rendering".
Launching lib/main.dart on sdk gphone x86 in debug mode...
[Aqua] Store file: /home/dannybuntu/work/builds/aqua-wallet/android/android_keys/keystore.jks
[CXX1104] NDK from ndk.dir at /opt/android-sdk/ndk/25.2.9519653 had version [25.2.9519653] which disagrees with android.ndkVersion [23.1.7779620]
[CXX1104] NDK from ndk.dir at /opt/android-sdk/ndk/25.2.9519653 had version [25.2.9519653] which disagrees with android.ndkVersion [23.1.7779620]
[CXX1104] NDK from ndk.dir at /opt/android-sdk/ndk/25.2.9519653 had version [25.2.9519653] which disagrees with android.ndkVersion [23.1.7779620]

FAILURE: Build failed with an exception.

* Where:
Build file '/home/dannybuntu/work/builds/aqua-wallet/android/build.gradle' line: 26

* What went wrong:
A problem occurred evaluating root project 'android'.
> A problem occurred configuring project ':app'.
   > com.android.builder.errors.EvalIssueException: [CXX1104] NDK from ndk.dir at /opt/android-sdk/ndk/25.2.9519653 had version [25.2.9519653] which disagrees with android.ndkVersion [23.1.7779620]

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s
Running Gradle task 'assembleDebug'...                           2,370ms
Exception: Gradle task assembleDebug failed with exit code 1

Arite. Please wait a week or so while we get the fdroid build out and we can provide better instructions for building on a linux.
Right now, all our developers are using mac for the builds and it looks like there are some quirks with building on ubuntu.

Where can we track fdroid progress? I see no issue or branch for this here or there

This is just tracked internally right now. We will have more updates in the coming week with the "Bravo" release that is waiting for AppStore approval right now.

Our attempt for the f-droid build https://gitlab.com/aquawallet/fdroiddata/-/pipelines
Its a work in progress; as you can see the build is failing right not. If you have any input, let us know :-)

I had a look but I don't see any logs or details. Have a link to what failed? I'm not familiar with the gitlab pipelines.

logs are here https://gitlab.com/aquawallet/fdroiddata/-/jobs/6700129652
seems like (some?) flutter dependencies are not being picked up.

Great. I thought it was just me...

Any updates?

Tried to create a dockerfile with the provided instruction,
# Use a base image with Nix installed
FROM nixos/nix:2.16.1

# Install necessary packages
RUN nix-env -iA nixpkgs.bash nixpkgs.git nixpkgs.curl nixpkgs.flutter

# Set the working directory
WORKDIR /app

# Clone the Aqua Wallet repository
RUN git clone https://github.com/AquaWallet/aqua-wallet.git .

# Install bash to make sure it is available
RUN nix-env -iA nixpkgs.bash

# Set up the environment using Nix
RUN nix develop --experimental-features 'nix-command flakes' --command /bin/bash -c \
    "make setup"

# Run the shell to ensure dependencies are set up correctly
RUN nix develop --experimental-features 'nix-command flakes' --command /bin/bash -c \
    "make shell"

# Build the APK
RUN nix develop --experimental-features 'nix-command flakes' --command /bin/bash -c \
    "flutter build apk --release"

# Copy the generated APK to the specified location on the host machine
RUN mkdir -p /home/keraliss/projects/walletScrutiny_build/aqua && \
    cp build/app/outputs/flutter-apk/app-release.apk /home/keraliss/projects/walletScrutiny_build/aqua/

# Final command (if necessary)
CMD ["bash"]

RUN mkdir -p /aqua/apk && \
    cp build/app/outputs/flutter-apk/app-release.apk /aqua/apk

But kept constantly getting error regarding /bn/bash/ and was unable to resolve. You can find my detailed review here
Would highly appreciate if you can let us know how you guys build the apk, so we can replicate the same steps!

im facing this issue
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':webview_flutter_android'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

 If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.
Get more help at https://help.gradle.org.

BUILD FAILED in 3s
Error: Gradle task assembleDebug failed with exit code 1

@aquawallet-admin so the project is not avaible in ubuntu? I am facing similar errors. Its only avaible in macOS?


Update akka-http-cors to 1.1.1

Updates ch.megard:akka-http-cors from 1.0.0 to 1.1.1.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.megard", artifactId = "akka-http-cors" } ]

labels: library-update, semver-minor

Need to make sure that new relic supports everything that is used in this version of akka-http (since I think this relies on a newer version of akka-http potentially).

Need to make sure that new relic supports everything that is used in this version of akka-http (since I think this relies on a newer version of akka-http potentially).

Superseded by #711.


Add a basic GHA CI that downloads all versions of the JDKs

I will follow this up with a more rigorous test that verifies the installed JDK version.

I don't quite understand why the GHA are not running on this PR.

It ran on my fork https://github.com/vasilmkd/jdk-index/runs/3686568856?check_suite_focus=true.

Here's a GHA run where I intentionally broke the index: https://github.com/vasilmkd/jdk-index/actions/runs/1265569197.

And the run after the revert: https://github.com/vasilmkd/jdk-index/actions/runs/1265575243.

Yeah, I don't have any other ideas, I tried pushing new commits, force pushing, nothing worked.

I will go ahead and merge this and report the outcome.

GitHub Actions picked up the merge and here is the run https://github.com/typelevel/jdk-index/actions/runs/1266066685.
Must have been an issue on their part previously.


[FEAT] Nested resources

I have an API endpoint that goes like: /api/admin/stores/:store_id/employees/:id
Where :store_id and :id can both be an integer.
I would like to be able to create nested resources like this (for example: Employees resources that belongs to a specific Store).
I don't know if this is possible with the current multi-level menu, I've checked the documentation but it doesn't include the :store_id part in the URL, nor in the hooks (useList, etc) API requests.
Does anyone know how to implement this feature with the current version of refine? Or is it impossible right now?
My suggestion would be to approach this with a React Context, storing the selected :store_id (from a Select input, for example), and passing as a parameter to the resource, but I'm guessing the only way to do this is by creating a Custom Page and implement the API request with axios or something.
I'm using these dependencies in my package.json (basically refine + react + typescript + antd), and I've deleted my yarn.lock and reinstalled just now, so I could get the most recent version (right now in my yarn.lock has "@pankod/refine-core" "^3.14.0"):
"dependencies": {
    "@testing-library/jest-dom": "^5.12.0",
    "@testing-library/react": "^11.2.6",
    "@testing-library/user-event": "^12.8.3",
    "@types/jest": "^26.0.23",
    "@types/node": "^12.20.10",
    "@types/react": "^17.0.4",
    "@types/react-dom": "^17.0.3",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-scripts": "^5.0.0",
    "typescript": "^4.2.4",
    "web-vitals": "^1.1.1",
    "@pankod/refine-core": "^3.1.0",
    "@pankod/refine-react-router-v6": "^3.3.0",
    "@pankod/refine-antd": "^3.1.0",
    "@craco/craco": "^6.1.2",
    "craco-less": "^2.0.0",
    "@pankod/refine-simple-rest": "^3.1.0",
    "react-markdown": "^6.0.1",
    "react-mde": "^11.1.0",
    "i18next": "^20.1.0",
    "react-i18next": "^11.8.11",
    "i18next-browser-languagedetector": "^6.1.1",
    "i18next-xhr-backend": "^3.2.2"
  },

Hey @eliasfeijo 👋,
Actually the nested resource is only used for UI (example Sider component). All hooks like useForm, useTable, useCreate take "resource" parameter. You can use "resource" parameter like API path.
example;
useTable({
resource: 'api/admin/stores/{STORE_ID}/employees/{ID}'
});
I hope it was useful for you 🚀

Thank you @omeraplak!!! I've succeeded in making the nested resource API call using the resource parameter of useTable, just as you've suggested. I've implemented an AppContext that stores the :store_id when the user select from a list, and then I use the :store_id in a custom page that calls the nested API resource.
I was confused before because I thought that I needed the URL in the same format (in the admin application), like in the API (/stores/:store_id/employees/:id). But that is unnecessary in the frontend, I ended up creating a Custom Page with a simple route /employees in the end.
I don't know if it makes sense to put this kind of logic inside the library itself, so I guess it's the frontend developer's job to implement the code manually with refine and react. I don't really see any other solution for this issue, but I might be wrong, so I'm open to suggestions.
Probably there's a better pattern to do the same thing that I did, so I won't close the issue right now, because maybe someone could propose a better solution than my own. But feel free to close the issue if you think there's no point on keeping this conversation going. =)

Our general approach is not to spend too much energy on problems that can be solved with existing APIs without too much effort. Maybe we should create a FAQ page to include such questions and their answers! Thank you so much! ❤

useTable

Can you please give example of how to utilize resource: 'api/admin/stores/{STORE_ID}/employees/{ID}'?
If I have dynamic STORE_ID and ID then where to get them from?

useTable
@omeraplak
Can you please give example of how to utilize resource: 'api/admin/stores/{STORE_ID}/employees/{ID}'?
If I have dynamic STORE_ID and ID then where to get them from?
Im using DataGrid from @mui/x-data-grid

Hey,
If you are using URL parameters for your dynamic parameters, you can use the useParsed hook. https://refine.dev/docs/routing/hooks/use-parsed/#params

useTable
@omeraplak
Can you please give example of how to utilize resource: 'api/admin/stores/{STORE_ID}/employees/{ID}'?
If I have dynamic STORE_ID and ID then where to get them from?
Im using DataGrid from @mui/x-data-grid

Hey, If you are using URL parameters for your dynamic parameters, you can use the useParsed hook. https://refine.dev/docs/routing/hooks/use-parsed/#params

Hey, thanks for the quick reply
(In general I haven't found any example of how to setup nested resources, especially with nested list/edit pages)
my problem is with nested resources
For example edit nested resource on save redirects from
api/admin/stores/{some_store_id}/employees/{some_employee_id}/edit
to
api/admin/stores/{some_employee_id}/employees/{some_employee_id}
Also if I have nested resource with list page then I don't have back button or breadcrumb as it treats this resource employees as standalone
api/admin/stores/{some_employee_id}/employees?pageSize=25&current=1
my <Refine resources= /> setup
[                 {                   name: 'stores',                   list: '/stores',                   show: '/stores/:id',                   edit: '/stores/:id/edit',                 }, {                   name: 'employees',                   list: '/stores/:id/employees',                   show: '/stores/:id/employees/:id',                   edit: '/stores/:id/employees/:id/edit',                   meta: {                     dataProviderName: 'employees',                     hide: true,                   },                 }]

Hey @omeraplak, is it worth to create separate issue?

Hey @rners01, the issue is when you define your routes in resource definitions you used /:id for defining both of the variables/parameters which should not be the same. You may want to replace the first /:id to something like /:storeId and provide storeId value in your meta properties or it will still be propagated if there's already a parameter defined in your router params as storeId.
Check out the docs I'm sharing below to have a better understanding how nested routes and navigation work with Refine. Feel free to open up a new issue if you encounter any bugs or errors about this.
Defining nested routes with multiple parameters: https://refine.dev/docs/guides-concepts/multi-tenancy/#configuring-multi-tenant-routes
Using meta to provide route parameters: https://refine.dev/docs/ui-integrations/ant-design/components/buttons/show-button/#meta
Passing meta when using useNavigation hook: https://refine.dev/docs/routing/hooks/use-navigation/#return-values-1
Using meta when using useGo hook: https://refine.dev/docs/routing/hooks/use-go/#with-resource
When composing routes/navigation, Refine will look for the provided meta value, the meta value from the resource definition and also the params from the router and if any of these provide the required parameter Refine will use it when handling navigation and route matching.


Error executing vim.schedule lua callback: ...l/share/nvim/plugged/lspsaga.nvim/lua/lspsaga/window.lua:123: attempt to index loca l 'config' (a nil value)

`Error executing vim.schedule lua callback: ...l/share/nvim/plugged/lspsaga.nvim/lua/lspsaga/window.lua:123: attempt to index loca
l 'config' (a nil value)
stack traceback:
...l/share/nvim/plugged/lspsaga.nvim/lua/lspsaga/window.lua:123: in function 'create_win_with_border'
...al/share/nvim/plugged/lspsaga.nvim/lua/lspsaga/hover.lua:84: in function 'open_floating_preview'
...al/share/nvim/plugged/lspsaga.nvim/lua/lspsaga/hover.lua:174: in function 'handler'
...ion/nvim/nvim-linux64/share/nvim/runtime/lua/vim/lsp.lua:1383: in function ''
vim/_editor.lua: in function <vim/_editor.lua:0>`
Hi.
When I try hover function ( default keybind as "K" ) , I've got this error.
Anyone know to fix?

—
Reply to this email directly, view it on GitHub
https://github.com/glepnir/lspsaga.nvim/issues/745#issuecomment-1426420147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJT5NWYOOQ3J7WZOAWRYZHLWW26BZANCNFSM6AAAAAAUBSOD6M
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update the version numbers of unofficial projects

Skeleton on Sass and LESS are now at version 2.0.4 rather than 2.0.1

@psyked  I just forked it to keep Skeleton alive. There are 48 outstanding PRs and none of the files have been updated in 2 years.
Please feel free to come to mine and do a PR. I'm going to start maintaining it and looking for people to help me too. Are you interested? If not, just ping me your PR and I'll test and push it out within 48 hours.
Take care @psyked


removed exceptions in mainwindow

Coverage remained the same at 92.143% when pulling c63390ac9e5f5eca6893e010c19a0c35bd72cc78 on ALim95:removedexception into 695dfe6babe25be921e49e329d47ead7e87a65ef on CS2103AUG2017-T15-B4:master.


chore: add Node.js 10

Thanks! Looks like it ran clean! Can you update the commit message to match the formatting from when we added to new major versions and run the minor version, please?

Thanks! Looks like it ran clean! Can you update the commit message to match the formatting from when we added to new major versions and run the minor version, please?

Sorry but I do not fully understand what you mean.

So we don't prefix any commits with "chore:" and introducing a new major version we call out in the commit message specially. Also should be "10.1" in travis instead of just "10" so we don't automatically pick up new minor versions until we can test them :+1:

So we don't prefix any commits with "chore:"

You do not have / use any commitlint? It eases many things.
How should the commit message look like? In sentence form?

So we don't prefix any commits with "chore:" and introducing a new major version we call out in the commit message specially.

It is just CI and does not affect anyony.

I can just make the commit :+1: it would take less time. You can always just have looked at the commit history to have seen it.

It is just CI and does not affect anyony.

It breaks my scripts that generate the history.md file based on commit messages.

Sorry but I could still rebase and merge.

It breaks my scripts that generate the history.md file based on commit messages.

I was not aware of this. Is this a custom script?

Mh, ok =(

Also you could have pushed to my branch.

But at that point, I can just push to master?

Whatever. The collaboration could have been better.


Delete package.json's scripts.android key when ejecting w/ ExpoKit

@terribleben

Also delete react-native-scripts dev dependency in eject w/ ExpoKit.


FIX: TIFF should use multiple mode.

Acquisition mode should have been multiple. This was a bug.
To be safe, ophyd enables the TIFF plugin on configure and disables on deconfigure.
AutoSave must be on.

@stuwilkins Looking at this again, shouldn't the enable/disable logic live a lot higher in the class tree?

No, this can be quite specific. I would prefer to keep it as a per plugin need.
S
From: Thomas A Caswell <notifications<EMAIL_ADDRESS>Reply-To: NSLS-II/ophyd <reply<EMAIL_ADDRESS>Date: Friday, April 10, 2015 at 6:34 PM
To: NSLS-II/ophyd <ophyd<EMAIL_ADDRESS>Cc: Stuart Wilkins <swilkins<EMAIL_ADDRESS>Subject: Re: [ophyd] FIX: TIFF should use multiple mode. (#111)
@stuwilkinshttps://github.com/stuwilkins Looking at this again, shouldn't the enable/disable logic live a lot higher in the class tree?
—
Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/ophyd/pull/111#issuecomment-91709238.


are there any good tutorials for coding in lua?

Describe your problem here.
i need help with porting a mod and i dont want to get all the code from someone and i dont know how to use lua
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

I found that Lua's own website was pretty good: https://www.lua.org/pil/contents.html#P1
As for video tutorials, there's this one: https://www.youtube.com/watch?v=iMacxZQMPXs
And for Psych Engine specific lua stuff, just check their wiki

thanks

I found that Lua's own website was pretty good: https://www.lua.org/pil/contents.html#P1 As for video tutorials, there's this one: https://www.youtube.com/watch?v=iMacxZQMPXs And for Psych Engine specific lua stuff, just check their wiki

also do you have the custom event template? i am trying to make one

function onEvent(n, v1,v2)
if name == 'eventname' then
makeLuaText('funnitext', v1, 0, 300, 400)
setObjectCamera('funnitext', 'hud')
addLuaText('funnitext')
if v1 == nil then
setTextString('funnitext', 'nothing is here')
end
end

end
idk

function onEvent(n, v1,v2) if name == 'eventname' then makeLuaText('funnitext', v1, 0, 300, 400) setObjectCamera('funnitext', 'hud') addLuaText('funnitext') if v1 == nil then setTextString('funnitext', 'nothing is here') end
end

end
idk

Ok thanks i will try making a event


Add import-spacing rule

This PR adds import-spacing rule which enforces proper spacing in import declarations.
This is implementation of https://github.com/palantir/tslint/issues/1584
PR checklist

[x] New feature, bugfix, or enhancement

[x] Includes tests

[x] Documentation update

I don't see any failures in the output but my tests are failing. Can you help?

@mohsen1 I'm unable to create PR to your fork.
You can find changes that allowed me to fix test in commit https://github.com/palantir/tslint/commit/f37c74dc84e0cf136e266936e3b7cefeae413fc5

@IllusionMH thanks for looking into it.
What nil means in there?

~nil means that the error starts there but has zero width. In this case, it probably means that the error indicates that it starts after the last character of the line (where the line break character would be I suppose). In general it's nicer to avoid outputting errors like this if possible.

@mohsen1 ~nil is described in lines.ts
In this case error starts on next character after } (in second case) and this character is line break - which doesn't have length and can't be marked with regular ~.

@JKillian I think this is a valid use case

@mohsen1 thanks!

@mohsen1 thanks!

The banning of line breaks in import statements is problematic here. We need to prescribe a way to make this rule play nicely with max-line-length out of the box. Right now we don't have an option for the line length rule to skip import statements (https://github.com/palantir/tslint/issues/1872#issuecomment-267085885). IMO I would prefer to keep the max-line-length rule in effect for import statements and allow multiline import statements in the default TSLint config.
import {
    RuleWalker,
    RuleFailure,
    ...
} from "tslint";

It does allow line breaks in destructuring import clause. although it won't let a very long module specifier like this:
import * as veryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongName from './very-very-very-very-very-very-very-very-very-long-name';

But a line break might not solve the issue if the specifier itself is longer than max lenght.

Ah, cool, sorry I missed that. This implementation looks reasonable then.


Switch Deconstruct to Use find_entities_filtered Based on Extractor Collision Mask

https://github.com/Xcone/factorio_pump/blob/b6ee33509d6b27f030dc106cf684c80b9504c6a0/mod/constructor.lua#L84
This would be helpful when using modded mining drills that have non-default collision masks, in particular Tiberium Spikes from https://mods.factorio.com/mod/Factorio-Tiberium
I can submit this as a pull request if you accept those

Taking the collision mask into account sounds like a good improvement.
I do accept pull requests (within reason, ofc).

Did a quick test on vulcanus. Seems rubble still gets deconstructed as it was. So I am satisfied with the the change you offered.
I did not test with the tiberium mod. I assume you already did that as you knew the change to make? If not, you can do so now, as I uploaded 2.1.3 to the mod portal that contains your change.
Always nice to improve on mod compatibility, without doing "specials". Thank you for the improvement. 👍

Tested locally to confirm that fix worked for Tiberium before submitting pull request.
I had introduced cliffs with limited collision to our oil-deposit-like resources to give players the ability to deconstruct them with special cliff explosives, but because of this the deconstruction order for PUMP was destroying the resources before placing the custom pumpjacks.


Improve readability in code

Let's Improve readability in code changing space in Text by leading.

Closed by cd9aad8.


A One-Line Bug That Could be Easily Fixed

Hi,
First, thanks a lot for this library!
Recently I found a bug in this line of your code:
https://github.com/cybertronai/autograd-hacks/blob/2c2e494cbf7a0240199cd767f3179477f25f4e23/autograd_hacks.py#L165
The bug makes the code not compatible with non-default padding and stride in Conv2d.
Hence, this should be corrected to
A = torch.nn.functional.unfold(A, layer.kernel_size,padding=layer.padding,stride=layer.stride)
Best regards,
Haoxiang

I found this issue is already posted by another user.
https://github.com/cybertronai/autograd-hacks/issues/3


Privacy manifest file for iOS is missing

To ensure a smooth app update and avoid App Store rejection, kindly consider adding a privacy manifest to your library. This helps developers reflect data collection practices in our own manifests.
Apple documentation.

Why do you need a privacy manifest for a library that simply renders text?

Oops! you are right, I posted this issue in the wrong repo! Sorry for the confusion..


Add NewVolumeManagerReconstruction feature gate

Add docs for NewVolumeManagerReconstruction feature gate. This feature should be invisible to users - kubelet does the same thing as before, only in a different order at the startup. It's behind a feature gate to allow opt-out in case it's buggy.
KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3756-volume-reconstruction
Enhancement issue: https://github.com/kubernetes/enhancements/issues/3756

Please also review release-note in https://github.com/kubernetes/kubernetes/pull/115268, that's the other place where we warn that any issues with kubelet startup could be caused by this feature.

/retitle Add docs for VolumeManager reconstruction after kubelet restart

/sig storage

/approve
from docs side.


Support Newtonsoft Attributes

It could be helpful if this library could support attributes from Newtonsoft such as
[JsonProperty(Required = Required.Always)]
[JsonConverter(typeof(TopicNameConverter))]

Furthermore it could be nice if converters could be added while adding the JSON file.
public static IWebHost BuildWebHost(string[] args) =>
    WebHost.CreateDefaultBuilder(args)
        .UseKestrel()
        .UseContentRoot(Directory.GetCurrentDirectory())
        .ConfigureAppConfiguration((hostingContext, config) =>
        {
            var env = hostingContext.HostingEnvironment;
            config.AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
                .AddJsonConverter(new JsonConverter());
            config.AddEnvironmentVariables();
        })
        .UseStartup<Startup>()
        .Build();

This would help people to map complex types with a parameterized constructor. Furthermore it is possible to make fields required such an error would be thrown while binding, should the settings file not contain the required field.

comment in this pull request will answer to this question https://github.com/aspnet/Configuration/pull/789

I don't see them discuss the option of adding JsonConverters, or am I missing something?

i mean about json property. For converter i guess it should be implemented the same way


Renovate: tweak branch names to avoid automerge disabling

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.28%. Comparing base (44459c9) to head (cc98d60).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #497    +/-   ##
========================================
  Coverage   22.28%   22.28%
========================================
  Files          95       95
  Lines        3595     3595
  Branches      590      604    +14
========================================
  Hits          801      801
+ Misses       2793     2647   -146
- Partials        1      147   +146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Clean up the clustering module

Proposed changes

I fixed flake8 linting in the module and added it to the continuous integrations
I added a test for the cython implementation of the ADP clustering
I added an empty module to test the implementation of DP clustering (@alexdepremia before closing this PR it would be great if you could add basic tests for DP clustering in that module).

I also found a strange behaviour of the ADP clustering on the simple 2-gaussian dataset saved in the  test folder: essentially using the default PAk estimator and Z = 1.65 the code runs forever. @alexdepremia once again, do have a clue on why this is happening?
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works

Codecov Report

Merging #33 (39a8902) into main (ff8670f) will increase coverage by 0.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   30.21%   31.15%   +0.93%
==========================================
  Files          15       15
  Lines        2840     2841       +1
==========================================
+ Hits          858      885      +27
+ Misses       1982     1956      -26

Impacted Files
Coverage Δ

dadapy/clustering.py
66.66% <100.00%> (+8.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8670f...39a8902. Read the comment docs.

@alexdepremia I think there is a problem with the tests you added. They take forever to run with the GitHub actions and never finish. Do they run correctly on your local machine?

@AldoGl, they worked in my local machine...

@alexdepremia the problem could be the following: if you changed cython code you need to re-generate the c-extension using
cython cython_code.pyx
and then you should commit the generated c-code. Might this be the problem?

@alexdepremia the problem could be the following: if you changed cython code you need to re-generate the c-extension using
cython cython_code.pyx
and then you should commit the generated c-code. Might this be the problem?

Yes, It Is for sure a problem

You need to "force-stage" the c-file since by default they are ignored by git (they are in the .gitignore)


General Cleanup

Describe the issue (if no issue has been made)
Cleanup for multiple thing:
GLFW_INCLUDE_NONE was defined only for Windows, though it isn't a Windows exclusive issue. - Moved to global defines.
Includes should match the case of files included. In this cast the GLFW directory is all uppercase. - Modified to fit directory name.
__debugbreak is an Windows exclusive function. Wrapped it with an appropriate ifdef statement.
In 'OpenGLContext.cpp' the header file GL/GL.h isn't used, but yet is included. - Removed.

I believe some of theses things have already been fixed in #82


Fix missing titan histogram metrics (#7943)

cherry-pick #7943 to release-4.0

What problem does this PR solve?
Fix missing titan histogram metrics.
What is changed and how it works?
The related code is removed by mistake when resolving conflicts in https://github.com/tikv/tikv/pull/6328, so add it back.
Related changes

Need to cherry-pick to the release branch

Check List

Manual test (add detailed scripts or steps below)

Release note

Fix missing titan histogram metrics

/run-integration-tests

/make release

/release

/merge

/merge

/merge

/merge


Add contribution guide

Either add a dedicated CONTRIBUTING.md file (e.g., https://contributing.md/how-to-build-contributing-md/), or --- probably easier --- add a brief "Contributing" section to the README.md that includes the following (pulled directly from JOSS guidelines):

"clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support"

(Part of JOSS review https://github.com/openjournals/joss-reviews/issues/6027)

v1.5.0: a dedicated CONTRIBUTING.md and  CODE_OF_CONDUCT.md were added.


(bug 431) fix sort with custom template. Modified inline demo

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#431
What is the new behavior?
sort with custom header template works
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Thanks!


KeyError: 'up', when setting spin='up'

Dear developers,
When I want to plot one spin channel, I got KeyError: 'up'.

KeyError                                  Traceback (most recent call last)
 in
10          spin='up',
11          ymin=-1, ymax=1,
---> 12         width=a,height=b)
13 #for i in range(72):
14 #    plt.plot(X[i,:], Y[i,:],linewidth=2.0,c='b')
~/.local/lib/python3.6/site-packages/sumo/cli/bandplot.py in bandplot(filenames, code, prefix, directory, vbm_cbm_marker, projection_selection, mode, interpolate_factor, circle_size, dos_file, cart_coords, scissor, ylabel, dos_label, elements, lm_orbitals, atoms, spin, total_only, plot_total, legend_cutoff, gaussian, height, width, ymin, ymax, colours, yscale, style, no_base_style, image_format, dpi, plt, fonts)
311             plt=plt, dos_plotter=dos_plotter, dos_options=dos_opts,
312             dos_label=dos_label, fonts=fonts, style=style,
--> 313             no_base_style=no_base_style, spin=spin)
314
315     if save_files:
~/.local/lib/python3.6/site-packages/sumo/plotting/init.py in wrapper(fonts, style, no_base_style, *args, **kwargs)
59
60             matplotlib.pyplot.style.use(list_style)
---> 61             return get_plot(*args, **kwargs)
62
63         return wrapper
~/.local/lib/python3.6/site-packages/sumo/plotting/bs_plotter.py in get_plot(self, zero_to_efermi, ymin, ymax, width, height, vbm_cbm_marker, ylabel, dpi, plt, plot_dos_legend, dos_plotter, dos_options, dos_label, dos_aspect, aspect, fonts, style, no_base_style, spin)
164
165         elif spin is not None:
--> 166             is_vb = self._bs.bands[spin] <= self._bs.get_vbm()['energy']
167         elif self._bs.is_spin_polarized or self._bs.is_metal():
168             is_vb = [True]
KeyError: 'up'

@kavanase can you look into this?

Dear @zrqustc,
Thank you for raising this issue and attaching your error log.
It seems that the spin argument being passed to bs_plotter.py is not being correctly parsed and converted to a pymatgen Spin.up object. From your error log, it appears you are using the sumo Python API functions rather than the command line, and this is what leads to the error.
From inspection of the code and your error log, I can see that the string_to_spin conversion function (which converts the input --spin flag to a pymatgen Spin object) is only applied to the cli  argument parser, and so does not convert your spin argument when directly using the bandplot function. This is a minor bug which I will fix now.
Thanks again for raising this issue!

Okay, Thanks for your reply.
Best,
Ruiqi
On Tue, Mar 10, 2020 at 8:02 AM Seán Kavanagh<EMAIL_ADDRESS>wrote:

Dear @zrqustc https://github.com/zrqustc,
Thank you for raising this issue and attaching your error log.
It seems that the spin argument being passed to bs_plotter.py is not
being correctly parsed and converted to a pymatgen Spin.up object. From
your error log, it appears you are using the sumo Python API functions
rather than the command line, and this is what leads to the error.
From inspection of the code and your error log, I can see that the
string_to_spin conversion function (which converts the input --spin flag
to a pymatgen Spin object) is only applied to the cli argument parser,
and so does not convert your spin argument when directly using the
bandplot function. This is a minor bug which I will fix now.
Thanks again for raising this issue!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGEVW3IJYWYSX2DTHOLRGY26PA5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLJ2UA#issuecomment-597073232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGDBFTNSX2CSUMQV6F3RGY26PANCNFSM4LDMG2OQ
.

This issue should now be fixed in master. Can you try pulling the latest changes in from GitHub and testing again?

Sure, I am going to test now and give you feedback.
Best,
Ruiqi
On Tue, Mar 10, 2020 at 12:00 PM Alex Ganose<EMAIL_ADDRESS>wrote:

This issue should now be fixed in master. Can you try pulling the latest
changes in from GitHub and testing again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGA2OSBLEXJFTOB2LZDRGZW2ZA5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOMIQTI#issuecomment-597198925,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGAJEETXLERMBLPCSCLRGZW2ZANCNFSM4LDMG2OQ
.

Got a new TypeError.
See the following:

TypeError                                 Traceback (most recent call last)
 in
10          spin='up',
11          ymin=-1, ymax=1,
---> 12         width=a,height=b)
13 #for i in range(72):
14 #    plt.plot(X[i,:], Y[i,:],linewidth=2.0,c='b')
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/cli/bandplot.py in bandplot(filenames, code, prefix, directory, vbm_cbm_marker, projection_selection, mode, interpolate_factor, circle_size, dos_file, cart_coords, scissor, ylabel, dos_label, elements, lm_orbitals, atoms, spin, total_only, plot_total, legend_cutoff, gaussian, height, width, ymin, ymax, colours, yscale, style, no_base_style, image_format, dpi, plt, fonts)
312             plt=plt, dos_plotter=dos_plotter, dos_options=dos_opts,
313             dos_label=dos_label, fonts=fonts, style=style,
--> 314             no_base_style=no_base_style, spin=spin)
315
316     if save_files:
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/plotting/init.py in wrapper(fonts, style, no_base_style, *args, **kwargs)
59
60             matplotlib.pyplot.style.use(list_style)
---> 61             return get_plot(*args, **kwargs)
62
63         return wrapper
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/plotting/bs_plotter.py in get_plot(self, zero_to_efermi, ymin, ymax, width, height, vbm_cbm_marker, ylabel, dpi, plt, plot_dos_legend, dos_plotter, dos_options, dos_label, dos_aspect, aspect, fonts, style, no_base_style, spin)
164
165         elif spin is not None:
--> 166             is_vb = self._bs.bands[spin] <= self._bs.get_vbm()['energy']
167         elif self._bs.is_spin_polarized or self._bs.is_metal():
168             is_vb = [True]
TypeError: '<=' not supported between instances of 'float' and 'NoneType'

Dear @zrqustc,
Thank you for the quick feedback. From the TypeError, it is suggesting that the issue is now coming from self._bs.get_vbm()['energy'] being NoneType, rather than from self._bs.bands[spin], which is a float type as expected. Is your system semiconducting (does it have a well-defined VBM)?

Thanks.  My system is metal, not a semiconductor.
On Tue, Mar 10, 2020 at 2:18 PM Seán Kavanagh<EMAIL_ADDRESS>wrote:

Dear @zrqustc https://github.com/zrqustc,
Thank you for the quick feedback. From the TypeError, it is suggesting
that the issue is now coming from self._bs.get_vbm()['energy'] being
NoneType, rather than from self._bs.bands[spin], which is a float type as
expected. Is your system semiconducting (does it have a well-defined VBM)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGBS3JNJAV6JV5GKTILRG2G7PA5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOMY54Y#issuecomment-597266163,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGGOH54QOD5A43MFRGDRG2G7PANCNFSM4LDMG2OQ
.

Thanks for the quick reply. The issue is as I expected, the spin-selection functionality of sumo has been set up to work with semiconducting systems and is currently incompatible with metallic systems. I will update now to include spin-selection capability for metallic systems. Thanks for your patience!

I will submit a fix now.

Great! Thanks for the update.
On Tue, Mar 10, 2020 at 2:26 PM Seán Kavanagh<EMAIL_ADDRESS>wrote:

Thanks for the quick reply. The issue is as I expected, the spin-selection
functionality of sumo has been set up to work with semiconducting systems
and is currently incompatible with metallic systems. I will update now to
include spin-selection capability for metallic systems. Thanks for your
patience!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGASBKQJB3VZK2FTFEDRG2H63A5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOMZ4DY#issuecomment-597270031,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGAC2ZRYGHAZUTGAGQ3RG2H63ANCNFSM4LDMG2OQ
.

Ok, I pushed fixes in 027496ccbb811c2da57c162ae2dbed8c76a8ee5e and 0488ce8d4c537aaf10330d0ae8d14619142c299a
Can you please try again and let me know.

Sure. I am testing now and give you feedback later.
On Tue, Mar 10, 2020 at 2:54 PM Alex Ganose<EMAIL_ADDRESS>wrote:

Ok, I pushed fixes in 027496c
https://github.com/SMTG-UCL/sumo/commit/027496ccbb811c2da57c162ae2dbed8c76a8ee5e
and 0488ce8
https://github.com/SMTG-UCL/sumo/commit/0488ce8d4c537aaf10330d0ae8d14619142c299a
Can you please try again and let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGAJ74OHRRZN3CFWRLDRG2LIXA5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOM5APQ#issuecomment-597282878,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGA2SMY5WNHQLNSVJPDRG2LIXANCNFSM4LDMG2OQ
.

Thanks, Alex.
I have tested the code. If I don't use the projection mode, everything is
fine.
But, when I use the projection mode, it will give this error;
---------------------------------------------------------------------------KeyError
Traceback (most recent call
last) in      10
spin='down',     11          ymin=-1, ymax=1,---> 12
width=a,height=b)     13 #for i in range(72):     14 #
plt.plot(X[i,:], Y[i,:],linewidth=2.0,c='b')
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/cli/bandplot.py
in bandplot(filenames, code, prefix, directory, vbm_cbm_marker,
projection_selection, mode, interpolate_factor, circle_size, dos_file,
cart_coords, scissor, ylabel, dos_label, elements, lm_orbitals, atoms,
spin, total_only, plot_total, legend_cutoff, gaussian, height, width,
ymin, ymax, colours, yscale, style, no_base_style, image_format, dpi,
plt, fonts)    305             plt=plt, dos_plotter=dos_plotter,
dos_options=dos_opts,    306             dos_label=dos_label,
fonts=fonts, style=style,--> 307
no_base_style=no_base_style, spin=spin)    308     else:    309
plt = plotter.get_plot(
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/plotting/init.py
in wrapper(fonts, style, no_base_style, *args, **kwargs)     59
60             matplotlib.pyplot.style.use(list_style)---> 61
return get_plot(*args, **kwargs)     62      63         return
wrapper
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/plotting/bs_plotter.py
in get_projected_plot(self, selection, mode, interpolate_factor,
circle_size, projection_cutoff, zero_to_efermi, ymin, ymax, width,
height, vbm_cbm_marker, ylabel, dpi, plt, dos_plotter, dos_options,
dos_label, plot_dos_legend, dos_aspect, aspect, fonts, style,
no_base_style, spin)    389     390         proj =
get_projections_by_branches(self._bs, selection,--> 391
normalise='select')    392     393
nd is branch index
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/electronic_structure/bandstructure.py
in get_projections_by_branches(bs, selection, normalise)     70
"""     71     spins = bs.bands.keys()---> 72     projections =
get_projections(bs, selection, normalise=normalise)     73      74
branches = []
~/repos/miniconda3/lib/python3.6/site-packages/sumo-1.4.0-py3.6.egg/sumo/electronic_structure/bandstructure.py
in get_projections(bs, selection, normalise)    179         proj =
dict(zip(spins, [np.zeros((nbands, nkpts))] * len(spins)))    180
for spin, orbital in it.product(spins, orbitals):--> 181
proj[spin] += dict_proj[element][orbital][spin]    182     183
if normalise == 'select':
KeyError: <Spin.up: 1>
On Tue, Mar 10, 2020 at 3:02 PM 张瑞奇<EMAIL_ADDRESS>wrote:

Sure. I am testing now and give you feedback later.
On Tue, Mar 10, 2020 at 2:54 PM Alex Ganose<EMAIL_ADDRESS>wrote:

Ok, I pushed fixes in 027496c
https://github.com/SMTG-UCL/sumo/commit/027496ccbb811c2da57c162ae2dbed8c76a8ee5e
and 0488ce8
https://github.com/SMTG-UCL/sumo/commit/0488ce8d4c537aaf10330d0ae8d14619142c299a
Can you please try again and let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGAJ74OHRRZN3CFWRLDRG2LIXA5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOM5APQ#issuecomment-597282878,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGA2SMY5WNHQLNSVJPDRG2LIXANCNFSM4LDMG2OQ
.

Can you copy and paste the code you are running when you get this error?
Can you also check that your VASP calculation definitely has band structure projections?

Let me test one more example. Maybe it is my mistake.
On Tue, Mar 10, 2020 at 4:25 PM Alex Ganose<EMAIL_ADDRESS>wrote:

Can you copy and paste the code you are running when you get this error?
Can you also check that your VASP calculation definitely has band
structure projections?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGGD7WHXV5NPUNUE6MTRG2V3JA5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONHLWA#issuecomment-597325272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGCS46LV2727FWBCO6LRG2V3JANCNFSM4LDMG2OQ
.

Thanks Alex.
All the issues are fixed now.
It is my mistake, the first example I test doesn't run normally.
Thanks again for your help.
Best regards,
Ruiqi
On Tue, Mar 10, 2020 at 4:31 PM 张瑞奇<EMAIL_ADDRESS>wrote:

Let me test one more example. Maybe it is my mistake.
On Tue, Mar 10, 2020 at 4:25 PM Alex Ganose<EMAIL_ADDRESS>wrote:

Can you copy and paste the code you are running when you get this error?
Can you also check that your VASP calculation definitely has band
structure projections?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/94?email_source=notifications&email_token=AD4XHGGD7WHXV5NPUNUE6MTRG2V3JA5CNFSM4LDMG2O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONHLWA#issuecomment-597325272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4XHGCS46LV2727FWBCO6LRG2V3JANCNFSM4LDMG2OQ
.

Great! Thanks for the bug report.


Virus and where to find msi?

First, my antivirus keeps deleting server.exe, so I cant use it.
Second, I cant find the msi install file you mention in the description

It seems like some antiviruses flag python executables created using pyinstaller as viruses. According to this https://stackoverflow.com/questions/55907339/how-to-prevent-exe-created-by-pyinstaller-from-being-deleted-by-antivirus seems like a lot of people have issues with false positives. You could try overriding or whitelisting this specific file in your antivirus settings or running the python script by cloning the git repo.
Sorry but I forgot to update the description but the latest version no longer includes an installer.

Ok, thanks I will try that.


isDeactivated could not reactived timely

Version
3.2.26
Reproduction link
github.com
Steps to reproduce
provide two ways.
first: with vue-router@next
click 'To Test2'
click 'To Test1'
click 'To Tesr2'
second: without vue-router
click 'show Test4'
click 'show Test3'
click 'show Test4'
What is expected?
first: with vue-router@next
click 'To Test2' // console Test1 isDeactivated true
click 'To Test1' // console Test1 isDeactivated false \nTest2 isDeactivated true
click 'To Tesr2' // console Test1 isDeactivated true \nTest2 isDeactivated false
second: without vue-router
click 'show Test4'
click 'show Test3' // console Test3 isDeactivated false
click 'show Test4' // console Test4 isDeactivated false
What is actually happening?
first: with vue-router@next
click 'To Test2' // console Test1 isDeactivated false
click 'To Test1' // console Test1 isDeactivated true \nTest2 isDeactivated false
click 'To Tesr2' // console Test1 isDeactivated false \nTest2 isDeactivated true
second: without vue-router
click 'show Test4'
click 'show Test3' // console Test3 isDeactivated true
click 'show Test4' // console Test4 isDeactivated true

Actually, when add nextTick, it will show correctly, it may caused by keep-alive which post last queue

I don't see this why this should be seen as a bug. You should not be relying on

internal APIs like instance.deactivated
assumptions about timing in Vue's asynchronous update process that are not documented.

You should rather be using onActivated/onDeactivated to react to when an instance is actually being (de-)activated


Add logic to detect missing comma token in array parsing

Closes #1114
Adds a conditional arg to add better error handling when array elements are missing a comma. This may fall under the "parse don't validate" category, but it's a start. Welcoming any feedback on how to approach this otherwise, or happy to close if the current behavior is expected.

Maybe something like this?
...
    #[error("expected {0}, found {1}")]
    #[diagnostic(code("Qsc.Parse.MultiToken"))]
    MultiToken(MultiToken<2>, TokenKind, #[label] Span)
...

#[derive(Clone, Copy, Debug, Diagnostic, Eq, Error, PartialEq)]
/// supports expecting up to N tokens
pub struct MultiToken<const N: usize> {
    tokens: [TokenKind; N],
}

impl<const N: usize> std::fmt::Display for MultiToken<N> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        use std::fmt::Write;
        let mut buf = String::new();
        let len = N;
        for ix in 0..len {
            let token = self.tokens[ix];
            if ix == len - 1 {
                write!(buf, "or {}", token)?;
            } else if ix == 0 {
                write!(buf, "{}", token)?;
            } else {
                write!(buf, ", {}", token)?;
            }
        }
        write!(f, "{}", buf)
    }
}

Was trying to find a way to keep it dynamic, but was running into the Copy trait constraint. Is there a way to do this that is dynamic? The problem I can see with this impl would be the use cases where there are a different number of expected TokenKinds for any one use case, how would we handle those cases? Maybe by making the expected type &'static str, then creating a to_err_msg method that matches on self could work, and that could return a const. It's not elegant but it would be somewhat more dynamic than restricting the list of TokenKinds to a static number. Just thinking out loud here, feel free to correct me if this is just better off as a static list that gets formatted by the error impl.

Feel free to reopen if you pick this up again.

Thanks, it's been a rough couple of weeks.


Fix Bug in rure_captures_len

It looks like at some point in the past the captures were refactored
from being a vector of start and end positions into a list of location
structures. The C API still had a conversion of the lenght which
corrected for the captures being twice the length of the number of
captures.
This updates the length calculation in rure.rs to return the
correct length, and adds an assertion to the test case.

How embarrassing! Thank you for the fox and the test.
I'm on mobile so it's hard to tell, but it looks like the C code is formatted differently from other C code in the same file. Could you make the formatting consistent? (And please also squash. :-)) Thanks!

Tabs vs spaces I guess. Will fix up.
On Sun, 14 May 2017 at 12:57, Andrew Gallant<EMAIL_ADDRESS>wrote:

How embarrassing! Thank you for the fox and the test.
I'm on mobile so it's hard to tell, but it looks like the C code is
formatted differently from other C code in the same file. Could you make
the formatting consistent? (And please also squash. :-)) Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/regex/pull/365#issuecomment-301307370, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA9TcR_Lzyu805iTAZcAKrk2uUDGHldRks5r5uwbgaJpZM4NaWUR
.

Awesome, thank you! @bors r+

:pushpin: Commit 4ed2fed has been approved by BurntSushi

:hourglass: Testing commit 4ed2fed with merge 68bc958...

:sunny: Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing 68bc95882474abcfb6f709afc0949c8f913164f7 to master...

\o/


Create Author Guide styles

Fix #132
Test URLs:

Before: https://main--airlessco--hlxsites.hlx.page/drafts/author-guide
After: https://feat-author-guide--airlessco--hlxsites.hlx.page/drafts/author-guide

CLS is shot because the Author Guide css is only loaded if it's the author guide page, lazily. And that causes issues.


Add dashes to bosh-lite example director name

A director name with spaces will break the config server, if you happen
to want to deploy that. It doesn't seem like the name of this director
is used elsewhere, so we can just add dashes.
Signed-off-by: Jesse Malone<EMAIL_ADDRESS>

Agreed and thanks! But duplicate of the-very-recent-#392, so we can continue discussion on there :)


MDX component support

it appears that MDX components are not currently supported

note the <Callout> mdx component is used in cadence anti patterns with the text "This anti-pattern has been addressed with [FLIP #703]…" https://github.com/onflow/cadence/blame/5a06fec82b4ab90d3fd770abb6b75ab56f2b51cd/docs/anti-patterns.mdx#L185
visit https://flow-docs-staging.fly.dev/cadence/anti-patterns
note that the component isn't shown, and the "This anti-pattern has been addressed" text is not present

Reopened by #372


Revised (in)equality operator articles

Snippets are moved to the samples repo: dotnet/samples#512

closing and reopening to build with new snippets

Thanks @pkulikov
This looks great. I'll :shipit: as soon as the build finishes.


storage is not deleted when deleting component

PVC is not deleted when deleting component

$ odo storage create backend --path=/data --size=1G
Added storage backend to backend

$ oc get pvc
NAME              STATUS    VOLUME    CAPACITY   ACCESSMODES   STORAGECLASS   AGE
backend-pvc       Bound     pv0031    100Gi      RWO,ROX,RWX                  14s
backend-s2idata   Bound     pv0090    100Gi      RWO,ROX,RWX                  4m

$ odo storage list
The component 'backend' has the following storage attached -
- backend - 1G

$ odo delete backend
Are you sure you want to delete backend from counter? [y/N] y
Component backend from application counter has been deleted
No default component has been set

$ oc get pvc
No resources found.

@kadel pvc gets deleted when we delete component

ah, you are right, it looks like it got already fixed

Closing this issue since it is fixed now


Shopify Cart API & Wishlist

use the new Storefront Cart API instead of Checkout (available only under unstable api version at the moment)
implement Wishlist  (Since Cart API has no limitations, managed to add Wishlist functionality by creating another parallel cart used just to store items for the Wishlist and storing that id into a cookie same as cart). Since there is no need for customer when creating Wishlist this way, i allowed the add to Wishlist without requiring authentification if wishlistForGuests is set to true in commerce config.

Example: https://commerce-klkfzby0b-cond0r.vercel.app

One thing worth noting on using the new Shopify Cart API for Wishlist is that they wouldn't necessarily persist indefinitely:

Unused and abandoned carts are auto-expired by Shopify.

Source: https://shopify.dev/custom-storefronts/cart#considerations

Most of times i ever used a Wishlist, was to browse a catalog, and when i see something i like (directly from the grid list) to click that heart icon quickly and add into a temporary cart that i can use later to filter and decide what to add to cart at the end of my site session.  Otherwise, i have to open a new tab with items i like, or click & go to each product i like, click add to cart, and then go back to a list that maybe i have to scroll down to go where i was before, or click "load more" again when i have a large catalog. I think this UX is better (even if that cart expires in two weeks or a month) than consider as a Wishlist, something that i have to login to use it & have indefinitely (where in Shopify there is no such thing at the moment).

It's an interesting take on a 'wishlist', but I feel like this is a bit of a anti-pattern as I feel this project is an offering of what the Provider offers out of the box and as Shopify does not offer Wishlist functionality out of the box that this shouldn't be included as it gives the impression to people not used to Shopify in thinking that Wishlist functionality is standard when it isn't and will likely come into unexpected issues like the example that @juanferreras provided.
Also I think end-user expectations of a Wishlist would offer more features such as public/private lists, social sharing options, multiple wishlists etc.


fix(TDI-38228): tSalesforceInput query not in order when using dynamic fields

Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
For salesforce Input dynamic field with manual query doesn't return the field order based on the manual soql fields order.
What is the new behavior?
Fix the dynamic fields order for input component with manual query.
Does this PR introduce a breaking change?

[x] No

Pull request test result: success :star:


Enhanced enum support

Right now, you support string array as an enum:
// Enum-like type and definition example.
type Gender = 'male' | 'female';
const Genders = {
  MALE: 'male' as Gender,
  FEMALE: 'female' as Gender,
};

@prop({ enum: Object.values(Genders) })
gender?: Gender;

However we have string enum support in TS now. It would be nice if the decorator function accept also the object type as the enum value and get the string values using Object.values(object) inside:
// true enum type
enum Gender {
  MALE = 'male',
  FEMALE = 'female',
};

@prop({ enum: Gender })
gender?: Gender;

So the signature of the BasePropOptions would be enum?: string[]|object; and you can in runtime check if Array.isArray(enum) to behave like now or convert enum object to values.

I can make a PR if you want 😉

Hello! Yes, when I saw the new string enums I wanted to make this but currently don't have enough time for it. A PR would be awesome indeed!


update msa and dynamic toll functions

Just approved the dynamic tolling changes. TO DO: @ychtw the MSA logic still needs to be refactored to reflect what we discussed today. Please create another PR for that.


akka-http tracing

Is it possible to use this library for akka-http tracing?

It doesn't support akka-http for now, but I would like to support it in the future!


Microchip: MEC172X: DTS: Fix symcr binding

The MEC172X Cryptographic memory is an 8K block that starts at address 0x40108000 according to the latest datasheet.

@jvasanth1 could be anoer case of wrong documentation?  MEC172X DS seems pretty clear its 8K at 0x40108ther case of wrong documentation?  MEC172X DS seems pretty clear its 8K at 0x40108000, vs the MEC15XX 22K at 0x40100000

@jvasanth1 please take a look

symcr is not cryptographic memory but AES-HASH with Crypto registers (0x4010_000 – 0x4010_003F)

symcr is not cryptographic memory but base of Crypto HW => AES-HASH with Crypto registers is at (0x4010_000 – 0x4010_003F)

that's not how it's described in the documentation.  the documentation describes a crypto SRAM interface to the ROM-embedded crypto engine.  so it would seem that they are software registers implemented via shared SRAM?
in any case, the MEC15xx, MEC170x show the region as 24K region at 0x4010_0000, but the MEC172x shows an 8K region at 0x4010_8000

@jvasanth1 please revisit

We are in the process of updating the documentation; will inform soon.


Transaction error in Trustwallet

i got this error when i am doing transaction using trustwallet extension but same code is worked on metamask,conbase and its also work on trustwallet mobile app and dapps browser

//( ) //

i got this error when i am doing transaction using trustwallet extension but same code is worked on metamask,conbase and its also work on trustwallet mobile app and dapps browser

Hello @amit-atr958
Thanks for posting the issue.
Has your issue been escalated by a support member already,
please reach out via TrustWallet DApps Support Ticket Requests. where you can talk to official live chat support with the ticket ID KIB12463 for immediately swift assistance and guidelines .
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.
Best regards

Hello @amit-atr958
Since it works on other platforms like MetaMask and Coinbase, it might be an issue specific to the Trust Wallet extension. I'll have to refer you to the official support live chat with the ticket ID TRT07638
Please see the link below to our dedicated support line:
Trustwallet Network DApps Support Ticket Requests.
Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.


[feature] url_encode & url_decode

It's good to have url_encode and url_decode function that translates a string into application/x-www-form-urlencoded format.
Examples:
https://docs.databricks.com/sql/language-manual/functions/url_encode.html
https://docs.databricks.com/sql/language-manual/functions/url_decode.html
https://trino.io/docs/current/functions/url.html?highlight=url_encode#url_encode
https://trino.io/docs/current/functions/url.html?highlight=url_encode#url_decode
url_encode
syntax
url_encode(str)

input
string expression
output
string
examples
SELECT url_encode('https://docs.starrocks.io/en-us/latest/quick_start/Deploy');
https%3A%2F%2Fdocs.starrocks.io%2Fen-us%2Flatest%2Fquick_start%2FDeploy

url_decode
syntax
url_decode(str)

input
string expression
output
string
examples
SELECT url_decode(https%3A%2F%2Fdocs.starrocks.io%2Fen-us%2Flatest%2Fquick_start%2FDeploy');
https://docs.starrocks.io/en-us/latest/quick_start/Deploy

@wangsimo0 assgin to me plz

@xuzifu666 Hi, how about the progress?

@xuzifu666 Hi, how about the progress?

hi，pr would submit in this week，no problem currently @ucasfl

@xuzifu666 Hi, how about the progress?

hi，pr would submit in this week，now in testing, no problem currently @ucasfl

Good, we need this UDF in our user scenario, if you meet any problem, I can collaborate with you.

@xuzifu666 Hi, how about the progress?

hi，pr would submit in this week，now in testing, no problem currently @ucasfl

Good, we need this UDF in our user scenario, if you meet any problem, I can collaborate with you.

ok，this pr would be implemented soon~ @ucasfl


fix(pegboard): fix clients connected without active workflow

Fixes RVT-4458

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1655  👈 (View in Graphite)
#1654
#1653
#1652
#1651
#1648
#1647
#1646
#1645
#1644
#1642
#1643
main

How to use the Graphite Merge Queue
Add the label merge-queue to this PR to add it to the merge queue.
You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.


python3Packages.etebase: 0.31.6 -> 0.31.7, fix build with Python 3.12

Description of changes

update to 0.31.7 for patches to apply
add patch updating cpython to 0.7.2 to fix build with Python 3.12
add patch updating flapigen to 0.6.1 to remove git dependency from Cargo.lock

Update to 0.31.7 and flapigen patch are needed to not vendor full Cargo.lock or big (200+ lines) patch.
Changelog 0.31.6 -> 0.31.7:
https://github.com/etesync/etebase-py/compare/v0.31.6...v0.31.7
## Version 0.31.7
* Bump etebase dependency to latest

Fixes #328382 (build of etesync-dav that depends on python312Packages.etebase)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 329671 run on x86_64-linux 1

6 packages failed to build:

etesync-dav
etesync-dav.dist
python311Packages.etebase
python311Packages.etebase.dist
python312Packages.etebase
python312Packages.etebase.dist

Result of nixpkgs-review pr 329671 run on x86_64-linux 1

6 packages built:

etesync-dav
etesync-dav.dist
python311Packages.etebase
python311Packages.etebase.dist
python312Packages.etebase
python312Packages.etebase.dist

fixes https://hydra.nixos.org/build/265238637