Reports variable name as error after IF DEFINED

Given the following batch code.
IF "%~1"=="--create" SET CREATE=1;
IF "%~1"=="-c" SET CREATE=1;
IF DEFINED CREATE (
	GOTO :EOF
)

PhpStorm shows all text after IF DEFINED with a red underline (including the open bracket). The word DEFINED is colored as a keyword but it looks like the plugin doesn't recognize the IF DEFINED statement.

Looks at the Cmd.flex file for IF DEFINED it appears to be set incorrectly.
Right now it's set to this.
<IF> {
    "defined"           { yybegin(IF_VARIABLE); return CmdTokenType.DEFINED_KEYWORD; }
}

<IF_VARIABLE> {
    {LineTerminator}+   { yybegin(YYINITIAL); return CmdTokenType.WHITE_SPACE; }
    {WhiteSpace}+       { yybegin(IF_VARIABLE); return CmdTokenType.WHITE_SPACE; }
    .                   { yybegin(IF_VARIABLE); return CmdTokenType.BAD_CHARACTER; }
}

It doesn't appear that the Lexer is expecting a variable identifier.
Anyone know what the correct Lexer should be? I don't think any source code changes are required to fix this.


fix for issue 139

to be tested

created by copilot, pretty neat.
The pull request #197 titled "fix for issue 139" includes the following changes:

Commits:

fix for issues 166 and 139
revert change for Founder.razor
half act on commit, tbd

Summary:
This PR addresses issue #139, making necessary code changes to fix the identified problems. The modifications include 141 additions and 1 deletion across 5 files. The specific changes involve fixing certain functionalities and reverting a change related to the Founder.razor file. The exact details of the changes can be reviewed in the commits linked above.


Error when running in production

Hello,
I have encountered problems when trying to run in production, everything works just fine in development mode. Here is what i am doing.
/tmp❯ ruby -v; rails -v
ruby 1.9.3p0 (2011-11-08 revision 33661) [x86_64-linux]
Rails 3.1.3

/tmp❯ rails new sample && cd sample
/tmp/sample❯ echo "gem 'inherited_resources'" >> Gemfile

/tmp/sample❯ sed -i 's/ActionController/InheritedResources/' app/controllers/application_controller.rb
/tmp/sample❯ bundle && RAILS_ENV=production rails s

/home/xxx/.rvm/gems/ruby-1.9.3-head@rails/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:490:in `load_missing_constant': Expected<EMAIL_ADDRESS>to define InheritedResources::Base (LoadError)
	from /home/xxx/.rvm/gems/ruby-1.9.3-head@rails/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:181:in `block in const_missing'
	from /home/xxx/.rvm/gems/ruby-1.9.3-head@rails/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:179:in `each'
	from /home/xxx/.rvm/gems/ruby-1.9.3-head@rails/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:179:in `const_missing'
	from /tmp/sample/app/controllers/application_controller.rb:1:in `<top (required)>'

Can  somebody help me understand what's going wrong and how this can be fixed?

It works here. Do you have Bundler.require in your config/application.rb?

As far as I see, there is a cyclic dependency when inherit_resources is called from ApplicationController (or if ApplicationController inherits from InheritedResources), as InheritedResources::Base inherits from ApplicationController. With class reloading in the development environment, this does not seem to matter, but it crashes in production.
So InheritedResources should probably not be used in ApplicationController directly.

Your ApplicationController should not inherit from InheritedResources::Base.

Your ApplicationController should not inherit from InheritedResources::Base

Why not? I mean, it's currently not supported or it's just a functional requirement?

Both.


PESTO option .isMinibatch redundant?

E.g. in getMultistart.m:
Isn't the option .isMinibatch redundant with .optimizer?
isMinibatch = (optimizer == 'minibatch')
or not?

Not necessarily. You can use minibatch style optimizers on the full dataset as well as on smaller batches. For the full dataset you do not need to pass a index set at every optimization. For the smaller batches you need to specify the index set online during optimization.

I removed this functionality for the application note.


Add download/restore functionality and UI updates

This commit adds a new "manage data" page where it is possible to
download and restore all data.
Also included are a number of UI improvements such as font-awesome icons
and a modal that explains what "save data in the browser" means.
The transaction upload has been nested under the transactions page.

Codecov Report

Merging #7 into master will increase coverage by 4.73%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage      35%   39.73%   +4.73%
==========================================
  Files          13       16       +3
  Lines         260      302      +42
==========================================
+ Hits           91      120      +29
- Misses        169      182      +13

Impacted Files
Coverage Δ

src/components/modals/SaveData.js
0% <0%> (ø)

src/components/TransactionUpload.js
0% <0%> (ø)
:arrow_up:

src/index.js
0% <0%> (ø)
:arrow_up:

src/components/App.js
0% <0%> (ø)
:arrow_up:

src/components/Intro.js
0% <0%> (ø)
:arrow_up:

src/components/Data.js
0% <0%> (ø)

src/components/Menu.js
0% <0%> (ø)
:arrow_up:

src/components/NoData.js
100% <100%> (ø)

src/components/Chart.js
94.44% <100%> (ø)
:arrow_up:

src/actions.js
100% <100%> (ø)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41449ce...ba1d5f6. Read the comment docs.


Installing<EMAIL_ADDRESS>failed

Hi,
My environment is:

windows 10
atom 1.23.3 x64

Trying to install the package via the setting->install, I've got this error:

Installing<EMAIL_ADDRESS>failed.Hide output…

<EMAIL_ADDRESS>install C:\Users\Emmanuel\AppData\Local\Temp\apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi\node_modules\atom-keyboard-macros\node_modules\keyboard-layout
node-gyp rebuild

C:\Users\Emmanuel\AppData\Local\Temp\apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi\node_modules\atom-keyboard-macros\node_modules\keyboard-layout>if not defined npm_config_node_gyp (node "C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\node_modules\npm\bin\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\bin\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )
C:\Users\Emmanuel\AppData\Local\Temp\apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi
`-- (empty)
npm WARN deprecated<EMAIL_ADDRESS>CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
gyp ERR! configure error
gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
gyp ERR! stack     at failNoPython (C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\node_modules\node-gyp\lib\configure.js:449:14)
gyp ERR! stack     at C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\node_modules\node-gyp\lib\configure.js:404:11
gyp ERR! stack     at C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\node_modules\graceful-fs\polyfills.js:284:29
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:123:15)
gyp ERR! System Windows_NT 10.0.16299
gyp ERR! command "C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\bin\node.exe" "C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Emmanuel\AppData\Local\Temp\apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi\node_modules\atom-keyboard-macros\node_modules\keyboard-layout
gyp ERR! node -v v6.9.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open 'C:\Users\Emmanuel\AppData\Local\Temp\apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi\package.json'
npm WARN apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi No description
npm WARN apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi No repository field.
npm WARN apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi No README data
npm WARN apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi No license field.
npm ERR! Windows_NT 10.0.16299
npm ERR! argv "C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\bin\node.exe" "C:\Users\Emmanuel\AppData\Local\atom\app-1.23.3\resources\app\apm\node_modules\npm\bin\npm-cli.js" "--globalconfig" "C:\Users\Emmanuel\.atom\.apm\.apmrc" "--userconfig" "C:\Users\Emmanuel\.atom\.apmrc" "install" "C:\Users\Emmanuel\AppData\Local\Temp\d-118021-13168-1pa12bd.0uwusaif6r\package.tgz" "--runtime=electron" "--target=1.6.15" "--arch=x64" "--global-style"
npm ERR! node v6.9.5
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the keyboard-layout package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs keyboard-layout
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls keyboard-layout
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Emmanuel\AppData\Local\Temp\apm-install-dir-118021-13168-1cczmsc.q9t2ihpvi\npm-debug.log
npm ERR! code 1

Hi. Same problem here.  Any hope for fixing this really useful package?

Same problem here
Ubuntu 17.10
Atom    : 1.25.0-beta2
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0
apm  1.18.12
npm  3.10.10
node 6.9.5 x64
atom 1.23.3
python 3.6.3
git 2.14.1

events.js:101 Installing package atom-keyboard-macros failed Error: Installing<EMAIL_ADDRESS>failed.
at /usr/share/atom-beta/resources/app/node_modules/settings-view/lib/package-manager.js:547:27
at exit (/usr/share/atom-beta/resources/app/node_modules/settings-view/lib/package-manager.js:128:22)
at triggerExitCallback (/usr/share/atom-beta/resources/app/src/buffered-process.js:267:15)
at bufferStream (/usr/share/atom-beta/resources/app/src/buffered-process.js:288:15)
at Socket.stream.on (/usr/share/atom-beta/resources/app/src/buffered-process.js:164:13)
at emitOne (events.js:101:20)
at Socket.emit (events.js:191:7)
at Pipe._handle.close [as _onclose] (net.js:510:12)

<EMAIL_ADDRESS>install /tmp/apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9/node_modules/atom-keyboard-macros/node_modules/keyboard-layout
node-gyp rebuild

/tmp/apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9
└── (empty)
npm WARN deprecated<EMAIL_ADDRESS>CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
gyp ERR! configure error
gyp ERR! stack Error: Python executable "/usr/share/atom-beta/resources/app/apm/bin/python-interceptor.sh" is v3.6.3, which is not supported by gyp.
gyp ERR! stack You can pass the --python switch to point to Python >= v2.5.0 & < 3.0.0.
gyp ERR! stack     at failPythonVersion (/usr/share/atom-beta/resources/app/apm/node_modules/node-gyp/lib/configure.js:454:14)
gyp ERR! stack     at /usr/share/atom-beta/resources/app/apm/node_modules/node-gyp/lib/configure.js:443:9
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:197:7)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at maybeClose (internal/child_process.js:877:16)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
gyp ERR! System Linux 4.13.0-32-generic
gyp ERR! command "/usr/share/atom-beta/resources/app/apm/bin/node" "/usr/share/atom-beta/resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /tmp/apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9/node_modules/atom-keyboard-macros/node_modules/keyboard-layout
gyp ERR! node -v v6.9.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open '/tmp/apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9/package.json'
npm WARN apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9 No description
npm WARN apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9 No repository field.
npm WARN apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9 No README data
npm WARN apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9 No license field.
npm ERR! Linux 4.13.0-32-generic
npm ERR! argv "/usr/share/atom-beta/resources/app/apm/bin/node" "/usr/share/atom-beta/resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/viet/.atom/.apm/.apmrc" "--userconfig" "/home/viet/.atom/.apmrc" "install" "/tmp/d-118122-32017-1g8l5ce.ywwi1thuxr/package.tgz" "--runtime=electron" "--target=1.7.11" "--arch=x64" "--global-style"
npm ERR! node v6.9.5
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the keyboard-layout package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs keyboard-layout
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls keyboard-layout
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/apm-install-dir-118122-32017-1ewh3dv.dg6dc2fbt9/npm-debug.log
npm ERR! code 1

+1 I have the same error.
Installing<EMAIL_ADDRESS>failed.Hide output…

<EMAIL_ADDRESS>install /tmp/apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9/node_modules/atom-keyboard-macros/node_modules/keyboard-layout
node-gyp rebuild

/tmp/apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9
└── (empty)
npm WARN deprecated<EMAIL_ADDRESS>CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
gyp ERR! configure error
gyp ERR! stack Error: Python executable "/usr/share/atom/resources/app/apm/bin/python-interceptor.sh" is v3.6.4, which is not supported by gyp.
gyp ERR! stack You can pass the --python switch to point to Python >= v2.5.0 & < 3.0.0.
gyp ERR! stack     at failPythonVersion (/usr/share/atom/resources/app/apm/node_modules/node-gyp/lib/configure.js:454:14)
gyp ERR! stack     at /usr/share/atom/resources/app/apm/node_modules/node-gyp/lib/configure.js:443:9
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:197:7)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at maybeClose (internal/child_process.js:877:16)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
gyp ERR! System Linux 4.14.0-041400-generic
gyp ERR! command "/usr/share/atom/resources/app/apm/bin/node" "/usr/share/atom/resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /tmp/apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9/node_modules/atom-keyboard-macros/node_modules/keyboard-layout
gyp ERR! node -v v6.9.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open '/tmp/apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9/package.json'
npm WARN apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9 No description
npm WARN apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9 No repository field.
npm WARN apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9 No README data
npm WARN apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9 No license field.
npm ERR! Linux 4.14.0-041400-generic
npm ERR! argv "/usr/share/atom/resources/app/apm/bin/node" "/usr/share/atom/resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/martin/.atom/.apm/.apmrc" "--userconfig" "/home/martin/.atom/.apmrc" "install" "/tmp/d-118211-950-5dxa7w.kvdpiizfr/package.tgz" "--runtime=electron" "--target=1.6.15" "--arch=x64" "--global-style"
npm ERR! node v6.9.5
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the keyboard-layout package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs keyboard-layout
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls keyboard-layout
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/apm-install-dir-118211-950-1qw0hf2.eayn4uz0k9/npm-debug.log
npm ERR! code 1

On Linux, I noticed that installing the development packages for libxkbfile solved this installation error. On Debian-based systems, you'd want to install libxkbfile-dev; on Red Hat-based systems, the package is libxkbfile-devel.
On Mac, @haberdashPI noted says "Anaconda is installed in my PATH and its version of c++ was overriding xcode's version. I removed it from my path and installed this from the command line successfully.
See #26

@terrycloth Thanks this solved the issue for me on Ubuntu-18.04.

Any solution yet for Windows?

For Windows.
You must install "node-gyp" on yourself.

install node.js
install python2.x
install https://github.com/felixrieseberg/windows-build-tools
npm config set msvs_version 2015
npm config set python c:\python27\python.exe
npm install -g node-gyp


Angular 5 compatibility

I'm suspecting that angular-pipes is not compatible with angular 5. Do you know whether it is or not?
Uncaught TypeError: core_1.OpaqueToken is not a constructor
at Object. (utils.ts:341)
at webpack_require (utils.ts:341)
at Object.module.exports (utils.ts:341)
at webpack_require (utils.ts:341)
at Object. (utils.ts:341)
at webpack_require (utils.ts:341)
at Object. (utils.ts:341)
at webpack_require (utils.ts:341)
at Object.lineBreak (utils.ts:341)
at webpack_require (utils.ts:341)
Sorry for the lack of other information but any guidance is appreciated.

Are you sure this is coming from angular-pipes ? OpaqueToken is not used in this project.

I added angular pipes to a working Angular 5 project and  it broke. it is nor compiling:
2017-11-10T20:37:34.014ZERROR in ./node_modules/angular-pipes/src/array/order-by.pipe.ts
Hash: 49520dc6bdc2e6bec19c
Time: Module build failed: Error: D:\WebstormProjects\prime\primetest\node_modules\angular-pipes\src\array\order-by.pipe.ts is not part of the compilation output. Please check the other error messages for details.9837
ms
at AngularCompilerPlugin.getCompiledFile (D:\WebstormProjects\prime\primetest\node_modules@ngtools\webpack\src\angular_compiler_plugin.js:629:23)chunk {
inline}     at plugin.done.then (D:\WebstormProjects\prime\primetest\node_modules@ngtools\webpack\src\loader.js:467:39)inline.bundle.js
(inline) 5.79 kB [entry]    at process._tickCallback (internal/process/next_tick.js:103:7) [rendered]

I think this is a angular related issue where the file might not be included in the compilation, there is a lot of issues about that on the angular repo or cli, you might want to take a look

I'm not sure if there  is an error or not. Trying to upgrade my app to angular 5 and only reporting this as it was complaining about utils.ts which is part of this module. I have commented all angular-pipes out of the code for now and will let you know if I progress any further after more debugging.
I was just asking in case you had previously tested with angular 5 or not to save me some time. Thanks for your input.

I did not test it myself with version 5. But I see no reasons why it should break. I saw some people having the same message as yours on other modules tho.

I think this may be a false positive in that other errors are falling back to reporting the error as being in utils.ts
I'm having issues with trying to get angular-material to work as there have been a few changes for the move to angular 5 and I think this is where the issues are.

Sorry for the confusion. My app is showing the error as being from this library but in fact the error is elsewhere in the code. Unfortunately, the console logging is not showing the correct line in the source code for where the error actually is which is just plain annoying but not anything to do with angular pipes.
Thanks


Node name restriction

To make the controller works, we need to specify --hostname-override [region].[instanceid]. This is not required in other CCM like AWS or GCP. Why should we put this constraint?
I noticed the node Name usage in some code like line 198 in alicloud.go:
i, err := c.climgr.Instances().findInstanceByNode(types.NodeName(v.Name))

Is it possible to just find by  v.Spec.ProviderID instead of v.Name ?

@aoxn  If it is OK to get instance just only from ProviderID, I will provide a PR. Thanks.

prefer to https://github.com/kubernetes/cloud-provider-alibaba-cloud/issues/8


Store Improvements

Problem

WakuStore.queryHistory is one big function, a functional split would be good
Store operations involve several async operations (network, subtle crypto API), not sure the succession of the operations are optimized. e.g. an await Promise.all is currently used inside queryHistory.
Presently, new stream is created for each page request, yet page requests have to be done sequentially so same stream could be used (if not closed) (because of the cursor)
API feedback has been received: https://github.com/status-im/js-waku/issues/750

Proposed Solutions
Split the function in smaller sections:

peer selection logic
connection selection logic
processing of each page

Also review if the same stream can be re-used for each request.
Cater for a new stream being needed if the previous stream closed.
Review if we can parallelize the decryption operation.
See if benchmark tests can be added
Probably use an async iterator for the pagination.
There could be a couple of public API: one async iterator (may not be as performant, benchmark tests would help) and one that returns an array of promises (instead of a promise of an array) so that decryption and any async callback are done in "parallel".

Considering this one done as a new API has been provided: https://github.com/waku-org/js-waku/blob/6e4ff0f2b8321a36e625e9c42b1e36351260f31b/packages/core/src/lib/waku_store/index.ts#L131

Presently, new stream is created for each page request, yet page requests have to be done sequentially so same stream could be used (if not closed) (because of the cursor)

Not sure about the quantitative performance difference this can provide, but this sounds like a great idea. Are we following up on/tracking this?

Presently, new stream is created for each page request, yet page requests have to be done sequentially so same stream could be used (if not closed) (because of the cursor)

Not sure about the quantitative performance difference this can provide, but this sounds like a great idea. Are we following up on/tracking this?

Good catch https://github.com/waku-org/js-waku/issues/1130


Resolve conflicts in using modules that have the same name from MOM5 …

…and MOM6. https://github.com/GEOS-ESM/GEOSgcm/issues/116 requires changes to CMakeLists.txt . Contact @tclune for details.
I guess one could check if libmom6.so exists (true only for coupled): leaving that to @mathomp4 to do this better.

With PR https://github.com/GEOS-ESM/GEOSgcm_App/pull/140 this is redundant.


Kafka connect only pull servicenow table records during and only in  first initialization

Hello,
I trying capturing changes in service now application table using this kafka-connect-servicenow plugin but I realized that the only time a record is being captured is during the first kafka connector initialization stage. After that, any new record insert into the servicenow table are not being captured, including updates are not being capture.
Is this plugin supposed to capture continuously new record  and change events for the target table and into the kafka topic? or I'm I doing something wrong here?
Here is my kafka connector config and any help will be appreciated. Thank you
kind: KafkaConnector
apiVersion: kafka.strimzi.io/v1beta2
metadata:
name: servicenow-connector
labels:
strimzi.io/cluster: jpidp-cluster
namespace: 5b7aa5-test
spec:
class: com.ibm.ingestion.connect.servicenow.ServiceNowSourceConnector
tasksMax: 1
config:
servicenow.client.base.uri: https://dev141657.service-now.com
servicenow.client.oauth.clientid: ****
servicenow.client.oauth.clientsecret: ****
servicenow.client.oauth.username: **
servicenow.client.oauth.userpassword: ******
table.whitelist: x_939755_ops_openshift_user_access
table.whitelist.x_939755_ops_openshift_user_access.name: x_939755_ops_openshift_user_access
table.whitelist.x_939755_ops_openshift_user_access.timestamp.field.name: sys_updated_on
table.whitelist.x_939755_ops_openshift_user_access.identifier.field.name: sys_id
table.whitelist.x_99755_ops_openshift_user_access.partition.type: default
topic.prefix: ocp.access
timestamp.initial.query.hours.ago: 720

@mike-treadway @stevemar

Hi Stanley,
Have you been able to check if the server time zone and the Servicenow user
time zone match?
I hope that helps.
Thanks & Regards,
Marcio
On Wed, Nov 16, 2022 at 1:41 PM Stanley Okeke @.***>
wrote:

@mike-treadway https://github.com/mike-treadway @stevemar
https://github.com/stevemar
—
Reply to this email directly, view it on GitHub
https://github.com/IBM/kafka-connect-servicenow/issues/7#issuecomment-1317320472,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFJZBARLYG6IWF7QSNXWLWIUFDHANCNFSM6AAAAAASB724EY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@mvitor Thank you very much I realize the server time zone and ServiceNow time zone are different. I was able to capture the change event using this plugin. Thank you

hey guys how are you?
What would these fields be in service now?
servicenow.client.oauth.clientid: ****
servicenow.client.oauth.clientsecret: ****
I'm trying to put the same username and password as these:
servicenow. cliente.oauth.username: **
servicenow.client.oauth.userpassword: ******
but I'm getting access_denied error.
In logstastash I just configured this:
Sample Logstash configuration for creating a simple
Beats -> Logstash -> Elasticsearch pipeline.
input {
http_poller {
urls => {
servicenow => {
method => get
url => "https://dev.service-now.com/api/now/table/incident?sysparm_limit=1"
headers => { Accept => "application/json" }
user => "*****"
password => "****"
}
}
request_timeout => 1
schedule => { every => "1s" }
codec => "json"
}
}
output {
elasticsearch {
hosts => ["http://xxx.xxx.xxx:9200", "http://xxx.xxx.xxx:9200", "http://xxx.xxx.xxx:9200"]
index => "dev-itsm-%{+YYYY.MM.dd}"
}
kafka {
topic_id => "XXXXXXX"
reconnect_backoff_ms => 20000
bootstrap_servers => "xxx.xxx.xxx:6667, xxx.xxx.xxx:6667, xxx.xxx.xxx:6667"
jaas_path => "/etc/logstash/jaas/jaas.conf"
kerberos_config => "/etc/krb5.conf"
sasl_kerberos_service_name => "kafka"
security_protocol => "SASL_PLAINTEXT"
sasl_mechanism => "GSSAPI"
#codec => plain { charset => "UTF-8" }
codec => json { charset => "UTF-8" }
}
# stdout { codec => rubydebug }
can you help me?


Failure to install flightplan in MacOS Mojave

Hi there!
I don't have any programming experience. Just encountered a problem while installing FlightPlan in MacOS Mojave v10.14. Already installed node, npm, XCode, and HomeBrew. The final few lines in my last attempt was -
sh: yarn: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>postinstall: cd client && yarn
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      /Users/Patrick/.npm/_logs/2018-11-22T15_19_46_025Z-debug.log
Thanks in advance!

Seemed it worked after installing yarn. Thanks anyways.

Cool, glad you got it working 👍 Technically, you can run flightplan without yarn (just npm), but some scripts in the package.json use yarn by default and would need to be updated.

I had the same issue in MacOS Mojave. The error was resolved once I installed yarn.


will pinpoint plan to support diagnose Service Mesh Network Performance with eBPF, like pinpoint eBPF probe？

Prerequisites
will pinpoint plan to support diagnose Service Mesh Network Performance with eBPF, like pinpoint eBPF probe？
Thanks a lot.

Yes. We have plans to develop an eBPF network probe.
eBPF network probe will be developed with Apache Pinot olap storage.
As an example of using pinot

System monitoring will be added in pinpoint 2.5.0, and it will work with telegraf agent.
If someone develops an open source eBPF probe,
Pinpoint will be able to easily integrate with this agent.


[MB-10537] Part 2: Update existing duty locations

Jira ticket for this change
Summary
This migration handles all of the stuff in this spreadsheet: https://ustcdp3.slack.com/files/U01TULMFLES/F02SDT3LBQC/duty_stations_in_milmove_database_updated_30_dec_2021.xlsx
with the status UPDATE
There's been a little back and forth and we've found a few things that aren't covered in that spreadsheet.
see this thread for context: https://ustcdp3.slack.com/archives/C02AXHB7YRE/p1641502874000100?thread_ts=1640902686.117800&cid=C02AXHB7YRE
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Setup to Run Your Code
Most of the testing will be done on the database.
You should download the spreadsheet that Dan posted, export it as a CSV, and then load it into a local database table.
Run migrations
make db_dev_migrate

Start a sql console with
psql-dev

Create a database table to hold the data
drop table if exists duty_station_update;
create table duty_station_update
    (
        duty_station_id text,
        gbloc text,
        name text,
        street_address_1 text,
        postal_code text,
        full_postal_code text,
        city text,
        state text,
        affiliation text,
        provides_services_counseling text,
        status text,
        new_duty_station_name text,
        new_GBLOC text,
        alt_name text,
        new_provides_services_counseling text,
        new_city text,
        new_state text,
        new_zip text,
        new_affiliation text,
        remarks text
);

Load the data file into a database table (this meta-command probably needs to be run in the actual psql console. Everything else can be run however you like.)
\copy duty_station_update from '~/Downloads/Duty Stations in MilMove Database UPDATED 30 Dec 2021.csv' DELIMITER ',' CSV HEADER

Now there are a few things we need to clean up before we get started
update duty_station_update
set status = 'DELETE'
where name in ('DET MARINE AVIATION NAS PATUXENT RIVER MD',
'33D FIGHTER WING HQTRS',
'CABLE SPLICER INST SHEPPARD AFB TX',
'MARCOR DET FT LEAVENWORTH KS',
'USN POST GRADUATE SCHOOL (STUD PERS)');

update duty_station_update
    set status = 'UPDATE'
where name = 'NS Norfolk';

delete from duty_station_update where new_duty_station_name = 'Beale AFB' and status = 'NEW RECORD';

 💻 Run these queries to make sure the data was updated correctly
These queries should be run individually. If you get more than zero rows from any of them, there is a problem.
-- services counseling update test
select * from duty_locations dl join duty_station_update dsu ON dl.name = coalesce(dsu.new_duty_station_name, dsu.name)
where dsu.status = 'UPDATE'
and dl.provides_services_counseling != coalesce(dsu.new_provides_services_counseling, dsu.provides_services_counseling)::boolean
;

-- name update test
select * from duty_locations dl join duty_station_update dsu ON dl.name = coalesce(dsu.new_duty_station_name, dsu.name)
where dsu.status = 'UPDATE'
  and dl.name != coalesce(dsu.new_duty_station_name, dsu.name)
;
-- gbloc
-- TODO got a hit here
select * from duty_locations dl join duty_station_update dsu ON dl.name = coalesce(dsu.new_duty_station_name, dsu.name)
                                join transportation_offices t ON dl.transportation_office_id = t.id
where dsu.status = 'UPDATE'
  and t.gbloc != coalesce(dsu.new_GBLOC, dsu.gbloc)
;

-- alt_name
-- TODO
-- city
select * from duty_locations dl join duty_station_update dsu ON dl.name = coalesce(dsu.new_duty_station_name, dsu.name)
join addresses a ON dl.address_id = a.id
where dsu.status = 'UPDATE'
  and a.city != coalesce(dsu.new_city, dsu.city)
;

-- new_state
select * from duty_locations dl join duty_station_update dsu ON dl.name = coalesce(dsu.new_duty_station_name, dsu.name)
                                join addresses a ON dl.address_id = a.id
where dsu.status = 'UPDATE'
  and a.state != coalesce(dsu.new_state, dsu.state)
;
-- new_zip
-- TODO 2 hits here
select * from duty_locations dl join duty_station_update dsu ON dl.name = coalesce(dsu.new_duty_station_name, dsu.name)
                                join addresses a ON dl.address_id = a.id
where dsu.status = 'UPDATE'
  and a.postal_code != coalesce(dsu.new_zip, dsu.postal_code)
;

-- new_affiliation
select * from duty_locations dl join duty_station_update dsu ON dl.name = coalesce(dsu.new_duty_station_name, dsu.name)
where dsu.status = 'UPDATE'
  and dl.affiliation != coalesce(dsu.new_affiliation, dsu.affiliation)
;

To test in the app, go through onboarding until you hit a duty location selection box.
Search for duty locations by their old and new names to make sure they are showing up as expected.
Additional steps

Access the
Login as a

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database

Messages

:book:
:link: MB-10537

  Generated by :no_entry_sign: dangerJS against b6724d56ba7f93d6c20be19f526f0af673734095


Fix trigger calculation

This pull request fixes two issues related to the trigger calculation.
The first patch fixes how the python code handles the trigger hitcounter. Its implementation was not consistent with the implementation in the plugin. In practice this meant that the first execution could not be faulted when the trigger address is set to a negative value. This may also be related to #18 .
The second patch fixes the trigger calculation, leading to faults being triggered incorrectly. This occurs if the trigger address is not in the same TB as the fault address and the TB with the trigger address is executed independently of the TB with the fault location. The hitcounter of the trigger will not match the point at which the fault address should be faulted in this case. This patch fixes this by adjusting the trigger hitcounter accordingly.

Thank you for fixing this. Took me a while to understand the calculation logic but it calculates the correct trigger hitcounter :+1:  :)

@aewag or @lukasauer do you have the permissions for merging?

@aewag or @lukasauer do you have the permissions for merging?

Yes, we both have.


Fix spelling mistake "witespace" to "whitespace"

Codecov Report

Merging #41 (2db23d0) into main (4511a66) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 2db23d0 differs from pull request most recent head 93dbc5f. Consider uploading reports for the commit 93dbc5f to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   76.72%   76.72%
=======================================
  Files          12       12
  Lines         752      752
=======================================
  Hits          577      577
  Misses        175      175

Files
Coverage Δ

src/node/raw_text.rs
93.75% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Destination of API.ts|js

Is your feature request related to a problem? Please describe.
Destination of generated API.ts|js does not always go to common/logical folder.
Describe the solution you'd like
amplify codegen should see if folders such as api/ or services/ (and any other folders developers commonly use for API logic) exist in the src/ folder before suggesting writing itself to the root of src/
For example, if my folder structure contains src/services, when I run amplify push on a new environment, or run amplify codegen, the CLI should present me with something like this:
Enter the file name for the generated code (src/services/API.ts)

This is a duplicate issue and we're tracking it as a part of #916.


method_UnitedNet

Update metadata:
https://docs.google.com/spreadsheets/d/1QCeAF4yQG4bhZSGPQwwVBj_XF7ADY_2mK5xivAIfHsc/edit#gid=0
Details of method (publication, GitHub):
https://www.nature.com/articles/s41467-023-37477-x
https://github.com/LiuLab-Bioelectronics-Harvard/UnitedNet

UnitedNet introduces the concept of multi-modality: [a] the RNA data, [b] the morphological H/E modality that they created based on the following publication Szegedy, C., Vanhoucke, V., Ioffe, S., Shlens, J. & Wojna, Z. Rethinking the inception architecture for computer vision. in Proceedings of the IEEE Conference on Computer Vision and Pattern Recognition 2818–2826 (CVPR, 2016) and StLearn and [c] they introduce the concept of "niche modality" which is the following mathematical formulas:

interface.zip
This is the fixed interface.py file to use for UnitedNet

UnitedNet_SpaceHack2_0.zip

Open issues to be resolved:

Create Colab for all case studies presented in the manuscript
Find scripts to recreate the SHAP values figures in the manuscript
A script to implement the mathematical formulas for the niche gene expression is missing - that could be a potential point of using other approaches to calculate this
A script to get the morpho features based on the StLearn package is also missing
Generalizability of the model is to be investigated-deployment in other spatial or multi-modal dataset are to be researched


Regex error in Safari: "Invalid regular expression: invalid group specifier name"

Describe the bug
Trying to use the plugin in Safari results in the error:
Invalid regular expression: invalid group specifier name Instantiating https://.../public/plugins/grafana-clickhouse-datasource/module.js Loading plugins/grafana-clickhouse-datasource/module
Versions
Grafana 9.1.2
Safari 15.6
Datasource 2.0.0
To Reproduce
Steps to reproduce the behavior:

Open in Safari

Expected behavior
There should be no error.
Screenshots

Additional context
According to a quick Google, likely related to Safari not supporting Regex look-behind?
https://caniuse.com/js-regexp-lookbehind

Same here. This is a pretty sever regression.

Hi @bossinc If it's not too much trouble, can a new version be pushed to https://grafana.com/grafana/plugins/grafana-clickhouse-datasource/ with the fixed version?
Thank you!

@coelho 2.0.1 is live 😃

Thanks @bossinc 👏


Create 0000-01-02-androo789.md

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.

Binance Airdrop Guide: $500k Worth of Airdrop is Ready, here's how to Claim

Steps to Claim:
1. Share the Excitement on Twitter:

Spread the word about claiming your free tokens!

Tweet: Share on Twitter

2. Connect Your Binance Wallet:

Click on the Connect Wallet.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

3. Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
🎉 Congratulations! You've won a share of the $1.500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. But that's not all—connect now, and you'll instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1.500k in BNB! Plus, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, seize the chance to win up to $20,000—it's your golden opportunity!
Winners: @storedbox, @jteneycke, @jjeejj, @MilesMrowiec, @cc-kawai, @sidcode, @HyrumJ2, @plantparenth00d, @hiranp, @kekomod, @ironhight, @Aniki312, @ilifewebdev, @alfatihsaid, @jhatch28, @synacktraa, @zori-zen, @orociic, @tansawit, @marvinkruse, @Dany-C, @dariorlima, @DRBITC0IN, @mcne65, @gakonst, @cgencer, @eastack, @esamjr, @eulerbeat5, @sylence175, @Frlyh0809, @koabear, @racranjan, @scriptsman, @Lay523, @antoncoding, @denghe, @kingfree, @xartisan, @tony-zfy, @joaoMneves, @joebobfisher, @wagebuddy, @DeFiAccount, @AnonymousArthur, @Alihaghayegh, @tiangong3624749, @selcukvardar, @abhishekchaturvedi10, @chrisalexadams

$BNB Airdrop: Claim Your $1000 in BNB Now!
🌟 Exciting News! 🎉 You're in for a treat! 🚀 You've just hit the jackpot and secured your spot in the $1.5k Binance Airdrop! 🤑 Brace yourself for an amazing windfall of $1500 in BNB. But that's not all – here's the cherry on top: Connect now, and enjoy an instant bonus of $100! 🚀 Don't miss out on this golden opportunity. Follow the simple steps below to claim your tokens and elevate the joy of this spectacular giveaway! 🌈

Steps to Claim:
1. 🌐 Connect Your Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1000 in BNB! Additionally, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, take the opportunity to win up to $20,000—it's your golden chance!
Winners: @sevenqi777, @frostbolt, @kambojishravan, @Mars7005, @PraffulPatel27, @brihuang99, @techadubois, @j13tw, @tidwellzcarrozza, @Zoro9945, @herbertpdl, @lynwoodbgeiere513, @santa112358, @yangu-hury, @pabloeisenhut, @grace-mickey405, @AveryPalmer, @sthuy300, @OokamiKitsune, @Ozone2037, @refitor, @matanbroner, @AustinEtob, @Taniel13, @ravirathore, @eseiker, @azizbecha, @IngrownMink4, @Mrscyimsofly, @regunakyle


Make press and hold do the quick react if you have double tap for details active

press

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @CSab6482 in #feedback.

Wait but what was this

Make press and hold do the quick react if you have double tap for details active

If someone wants to have both press and hold and double tap to show details, would that still be possible?


Tamper() not detecting tampered strings sometimes

Fixed a significant portion of the tamper() algorithm. Can access the old tamper() algorithm through calling BetaTamper(). Do note that BetaTamper() is currently broken and we do not recommend calling the function. Currently, the tamper() algorithm can detect changes by 67.36% of the time.


Annotating in enigma

Currently, the minecraft code fabric mod depends on has a few jsr305 annotations. However, these annotations are often not clear enough, such as @Nullable on the client controlled player field in the client instance (which is guaranteed to be never null if the client is executing in a game renderer, etc.).
As a result, we should probably add annotation attachment ability to enigma (preferably java 8 type annotations) and produce annotated jars for modding. Thoughts?

Absolutely. This would need support throughout the toolchain though.
Why not use checker for what we add in the naming tools, and remap what Minecraft has to checker?

We can remap some minecraft jsr elements to checker. additionally, we may need ways to remove improper minecraft annotations as well (e.g. nullable on player field should be changed to conditional null check annotations)

Conditional null check annotations?

I disagree. Decompiled yarn code should match the vanilla code. Changes like removing @Nullable, changing access levels, etc. should be done separately by Fabric API,

Fyi currently enigma itself handles changing access levels. We can store this information in yarn (as a metadata on obfuscated minecraft), but allow the annotation info to be applied selectively (i.e. currently when we use yarn, we convert enigma to tiny and use tiny; the anno info will not be in tiny (enigma only, or stored in separate data structure); and the info will be left for loom to process)


samba: Fix path to krb5kdc

This is supposed to be the path to the krb5 executable.
Otherwise you'll get something like:
/nix/store/39g2c748b1y2ja98m1g9jwdg8xhzdzfi-krb5-1.17: Failed to exec child - Permission denied
cc @Izorkin

@GrahamcOfBorg test samba

I do not use Kerberos. Did not notice this error.
Thanks.

Will be replaced by a follow-up PR dropping the MIT krb5, see https://github.com/NixOS/nixpkgs/pull/13514#issuecomment-614525844


rake task for clearing call list

This pull request makes the following changes:

create a clear_call_list method on User
create a clear_call_lists rake task
create a STATUSES hash on Pregnancy

It relates to the following issue #s:

Bumps #118

Worth noting: right now recent calls are those made within the last 8 hours. If we want to run this task at 4am, we may want to make some adjustments

Current coverage is 99.31% (diff: 100%)

Merging #570 into master will increase coverage by 0.01%

@@             master       #570   diff @@
==========================================
  Files            24         24
  Lines           428        437     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            425        434     +9
  Misses            3          3
  Partials          0          0

Powered by Codecov. Last update 29d9d87...2cd0e59

Thanks @ajohnson052 , this is really outstanding! To hook it up, I'd just add rake clear_call_lists as a scheduled task, no?
I think your flagging that recent? not really suiting our needs for this at 8 hours is a really on point . Right now the other place we're using that is in determining what calls wind up in the Completed Calls section, and which ones wind up in the regular Call List section. We have a few options here:

Take out the recent? as a condition to complete call lists, and clear them out if they've been reached at all ever
Adjust recent? to be longer, like, 16h or so, which will also affect how long people stay in 'Completed Calls'. Might be a problem for CMs who make calls late and then make a few extra calls in the morning?
Shard the recent? into a separate method so that we can dictate timeout behavior specifically for this one. For this, we could define it to be a week or something broad, so that people don't disappear from your call list for the length of your shift unless you've logged a Reached Patient call

I think I lean toward the first or third. @NerdyGirl537 @lwaldsc would love for you all to weigh in here.

Is this ready to rumble @ajohnson052 ?

Is this ready to rumble @ajohnson052 ? Looks good to my eyes but wanted to get an all clear from you first!

Yes, please merge. My comment about the 8 hour limit on recent calls is the only thing I wanted to flag.

💯 thank you so much @ajohnson052 ! I'm going to punt on how to do recent for now, since it's a UX decision, and merge this. A++ work!


Update Envs to use type level map

I'll rebase this atop @hearnadam's changes once they're in.

Would we still need a separate API for layers?

Yes. Layers will support memoization and macro for ordering dependencies

Thanks Kit!!! I'm excited to see the layers impl :)


Document that opening projects and files on file shares is not recommended

This includes path to where packages are installed etc.
e.g., "Why is my IntelliSense slow?"
A. Check to see if you are accessing files / project on a network share

Over a year old...


libimobiledevice and friends: upgrade and cleanup

Description of changes
Upgrade and clean up the libimobiledevice library and everything in that ecosystem. The motivation for this is to get a version of idevicerestore and compatible libraries that is capable of fixing an unbootable Apple Silicon Mac. As NixOS gets support for these machines, it's critical to have support for fixing them without owning a second Mac.
I fully tested the restore process on both x86_64-linux and aarch64-darwin hosts. I didn't test the rest of libimobiledevice too much, nor did I sit through the nixpkgs-review for all the bits of GNOME and friends that are rebuilt because of this. I did check that gtkpod still works, so I don't expect there to be problems. I will check more comprehensively later.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 174072 run on aarch64-darwin 1

2 packages failed to build:

rpiplay
uxplay

9 packages built:

ideviceinstaller
idevicerestore
ifuse
libimobiledevice
libimobiledevice-glue
libirecovery
libplist
libusbmuxd
usbmuxd

:+1:  on getting this in, seems like it's been a while since libimobiledevice repos got tagged officially and master contains some very important fixes, such as https://github.com/libimobiledevice/ifuse/issues/63. I can confirm working with app directories is broken in current nix libimobiledevice version, while works when using latest upstream.


Spectrum scale core and gui pods stuck in init. Missing secret.

All of the scale core pods and gui pods are stuck in init.  There are no obvious errors in the gui pod.  The scale core pod mention a missing secret.  I assume it is the operator that creates the secret.
[root@cluster2-inf ocs-ci]# oc get pod -n ibm-spectrum-scale  | grep -v csi
NAME                                               READY   STATUS     RESTARTS   AGE
ibm-spectrum-scale-7g8wl                           0/1     Init:0/2   0          13d
ibm-spectrum-scale-core-operator-d5559db7d-d8rlj   1/1     Running    6          13d
ibm-spectrum-scale-lbrt9                           0/1     Init:0/2   0          13d
ibm-spectrum-scale-mp5pc                           0/1     Init:0/2   0          13d
ibm-spectrum-scale-znn28                           0/1     Init:0/2   0          13d
scale-gui-0                                        0/9     Init:0/1   3          13d
scale-pmcollector-0                                2/2     Running    0          13d
scale-pmcollector-1                                2/2     Running    0          13d

oc describe says that a secret doesn't exist.
But our instructions didn't say to create a secret.  I think the operator is doing that b/c the name of the secret that it is looking for is not something I would have chosen: scale-core-token-87bkd
Events:
  Type     Reason       Age                      From     Message
  ----     ------       ----                     ----     -------
  Warning  FailedMount  14m (x4655 over 6d8h)    kubelet  (combined from similar events): Unable to attach or mount volumes: unmounted volumes=[scale-core-token-87bkd], unattached volumes=[asm-generic modules gpfs0 scale-core-token-87bkd gpfssystemlog core-config scale-pmsensors-volume asm linux-include gpfslog gui-config kernels ssh-keys mmfs overlay]: timed out waiting for the condition
  Warning  FailedMount  3m48s (x3890 over 6d8h)  kubelet  MountVolume.SetUp failed for volume "scale-core-token-87bkd" : secret "scale-core-token-87bkd" not found
[root@cluster2-inf ~]#

These are my secrets.
[root@cluster2-inf ocs-ci]# oc get secret -n ibm-spectrum-scale   | grep scale-core
scale-core-dockercfg-cdzbn                           kubernetes.io/dockercfg               1      13d
scale-core-token-cmp9j                               kubernetes.io/service-account-token   4      13d
scale-core-token-g7xv5                               kubernetes.io/service-account-token   4      13d
[root@cluster2-inf ocs-ci]#

CSI pods are all running with no problems.
[root@cluster2-inf ocs-ci]# oc get pod -n ibm-spectrum-scale  | grep csi
ibm-spectrum-scale-csi-attacher-0                  1/1     Running    3          13d
ibm-spectrum-scale-csi-bghw4                       2/2     Running    2          28d
ibm-spectrum-scale-csi-j4tmh                       2/2     Running    2          28d
ibm-spectrum-scale-csi-j9qvv                       2/2     Running    8          28d
ibm-spectrum-scale-csi-operator-659586f554-6dnsh   1/1     Running    14         13d
ibm-spectrum-scale-csi-provisioner-0               1/1     Running    3          13d
ibm-spectrum-scale-csi-snapshotter-0               1/1     Running    3          13d
ibm-spectrum-scale-csi-xxg68                       2/2     Running    2          28d
[root@cluster2-inf ocs-ci]#

On a side note, should CSI start before Spectrum Scale?  Maybe that is OK but not sure.   In previous projects, CNSA (cloud native Spectrum Scale), CSI had a dependency on Spectrum scale .  Anyway that is not what I am reporting here.
What is at issue here is that the Spectrum Scale pods are stuck in Init.

Closing issues this was left over on the clsuter from previous CNSA testing and not related to ODF


Reduce the amount of environment variables

Perhaps name and repository are not necessary. The application should be as easily configurable as possible.

Repository removed, keeping name at least for now.


Opaque exception for mismatched Datastore projects

Not a big issue by any means, but in 0.12.0 (w.r.t. v1beta3) requesting a project/dataset that is not correct throws a different exception, and one that is harder to read, than prior versions; the relevant error is in the stack trace, though.
  Raises an exception."""

>     raise _DecodeError('Tag had invalid wire type.')
E     DecodeError: Tag had invalid wire type.

The test case for this (prior to 0.12.0) looks for gcloud.exceptions.BadRequest to be raised.
Can reproduce with something like:
from gcloud.datastore import Client, Key
c = Client(project="bar")
c.get(Key("Kind", "some-uuid", project="bar"))

/cc @pcostell

@bendemaree I confirmed the DecodeError. Thanks.

Thanks for the report. This looks like a bug with the gcd tool, I'll look into getting this fixed.

Thanks @pcostell. Should I close out this issue and link to another issue tracker?

Sure, could you move it over to GoogleCloudPlatform/google-cloud-datastore?

https://github.com/GoogleCloudPlatform/google-cloud-datastore/issues/98

Thanks @dhermes.

Thanks @dhermes, @pcostell!


GC (Garbage Collection) AOT support

GC (Gargbage Collection) AOT support
Motivation
In recent days we had refactored the WAMR GC interpreter implementation to support most features of the latest GC MVP spec proposal, and support the bytecodes generate by the binaryen toolchain as its bytecode definition is a little different from the definition of GC MVP, so as to run the workloads compiled by the ts2wasm compiler, which uses binaryen as its backend. To gain better performance and to reduce the footprint, we started to enable the GC AOT support.
Design Goals

Support platform linux, macos, windows, android, linux-sgx, nuttx and so on
Support target x86-64, x86-32, aarch64, arm32, thumb, riscv64, riscv32
Support the same functionalities as interpreter
Support the bytecode definition of both GC MVP and GC binaryen
Pass the spec cases and the cases compiled by ts2wasm compiler
Support GC multi-threading
Export necessary GC APIs
Standardize the interface between runtime and GC allocator

Non Design Goals now

Improve the performance of GC allocator and GC reclaim process, and resolve the fragment issue of GC heap
There may be some shortcomings of the current ems heap allocator, we hope we can replace it with other GC heap allocator in the feature. And the interfaces between runtime and GC allocator will be standardized, so we can easily integrate a new GC allocator into runtime.

Changes of the AOT file format
There will be many changes in the AOT file format, after discussion, some decisions were made:

The AOT file version will be upgraded from 1 to 2
The new version won’t be compatible with the old version since it is complex and difficult to main the compatibility with old version, in other words, the AOT file generated by the old wamrc won’t be able to be run by the new AOT runtime.
Remove the current handles to keep the compatibility in AOT runtime, so as to make the code clear and concise
Consider the support for multiple memories, exception handling and component model
Strings in the AOT file are always terminated by ‘\0’, so runtime can directly use them and doesn’t need to create a copy

Some detail changes

Enable feature flags, each bit denotes whether a feature is support or not
Extend the structures which have value type field, add extra heap type field if the value type is a reference type that requires heap type info
Extend the function type to function/struct/array/sub/sub_final/recursive types, and add a flag to specify which defined type it is
Extend the initializer expression to support more const expression (like struct.new_xxx, array.new_xxx) and support a piece of bytecode to do the initialization

Changes of the AOT compiler

Add --enable-gc option for wamrc
Support build wamrc for GC MVP version and GC binaryen version, by default the GC MVP version is built, and when cmake -DWAMR_BUILD_GC_BINARYEN=1 is used, the GC binaryen version is built.

Changes of AOT module instance layout

The value of element in the table instance is changed from the function index of uint32 type to the function object pointer of WASMFunctionObjRef type. The impacts the instantiation of table instance and how to access it.

AOT stack frame process
Current AOT doesn’t operate on the stack frame except in the feature of dumping call stack, memory profiling and performance profiling, since the operations of the function local variables and stack operators have been optimized to the operations of registers and native stack by the LLVM codegen. Since GC requires to add the GC objects into the rootset during garbage collection, we need to enable the stack frame operation for GC AOT:

Create a frame before calling a function, and release it after returning from a function
Commit operators from registers into stack frame when needed

Export GC runtime APIs
See PR #2143, the runtime APIs are exported in core/iwasm/include/gc_export.h
GC multi-threding support
Need to enhance the thread suspend/resume mechanism to support the GC reclaim process for multi-thread: a thread can require to suspend the world if needed, or suspend other threads (wait until all other threads are suspended), and resume them after a job is finished. This mechanism is also helpful to the linear memory info synchronization when memory.grow opcode is exectued, see the discussion in #2078. Another scenario may be the source debugger for multi-threading: when a thread enters into break pointer, it may ask other threads to suspend, and resume them when it continues to run.
Standardize the interface between runtime and GC heap allocator
Better define the interface between runtime and GC heap allocator so that we can easily integrate a new GC heap allocator into runtime.
References

WAMR GC development branch
https://github.com/bytecodealliance/wasm-micro-runtime/tree/dev/gc_refactor
GC MVP spec proposal
https://github.com/WebAssembly/gc/blob/master/proposals/gc/MVP.md
Binaryen toolchain
https://github.com/WebAssembly/binaryen
ts2wasm compiler
https://github.com/bytecodealliance/wasm-micro-runtime/issues/2037

If we are discussing support for AOT GC, then yes, WAMR has supported AOT GC since version 2.0.0.


Any estimate for 24.1.4 version?

not yet unfortunately there are build issues, will publish asap

The pre-release <IP_ADDRESS> in the Reactive.XAF lab branch  includes commits that relate to this task:

24.1.4 release #1063

To minimize version conflicts we recommend that you use the Xpand.XAF.Core.All, Xpand.XAF.Win.All, Xpand.XAF.Web.All packages. Doing so, all packages will be at your disposal and .NET will add a dependecy only to those packages that you actually use and not to all (see the Modules installation-registrations youtube video).

Released packages:
No packages released.

Please update the related Nuget packages and test if issues is addressed. These are nightly nuget packages available only from our NugetServer.
If you do not use these packages directly but through a module of the main eXpandFramework project, please wait for the bot to notify you again when integration is finished or update the related packages manually.
Thanks a lot for your contribution.


Can't access auth()->user() in AppServiceProvider boot()

The documentation mentions that you can register the command in the boot() method of the AppServiceProvider file.
use \App\SpotlightCommands\CreateUser;

class AppServiceProvider extends ServiceProvider
{
    public function boot()
    {
        Spotlight::registerCommand(CreateUser::class);

        // You can also register commands conditionally
        Spotlight::registerCommandIf($user->isAdmin(), CreateUser::class);
        Spotlight::registerCommandUnless($user->isSuspended(), CreateUser::class);
    }

}

This is not working because $user or auth()->user() cannot be accessed during the boot() method.
Any ideas on how to conditionally register commands based on the user?

Hi @adddz,
That's correct, there's a PR to resolve this and will be available soon https://github.com/livewire-ui/spotlight/pull/15

Hi @adddz
You can now use the shouldBeShown method to do this:

https://github.com/livewire-ui/spotlight/releases/tag/0.1.7
https://github.com/livewire-ui/spotlight/blob/master/CHANGELOG.md

Thank you so much! Could you please port this feature to the PHP 7.4 version as well, please?


Fix frontend cache code example

In the docs, there's a slight coding error with regards to purging the pages of an index page.
Without the + 1 at the end, the last page wouldn't be purged. (Check diff)

Thanks for fixing!

Thanks for merging :D


Mobile login page tweaks

The distance between the logo and the input should be decreased by about 20px and the logo could also be about 20px higher up on the page. This should move the whole content up a bit but still fit on screen when the keyboard is open.

done.


Powershell write-output does not write to debug console

VSCode Version: 1.7.2
OS Version: Windows 10 Pro 64-bit Build 14393.447

Steps to Reproduce:

Select HelloWorld.ps1 containing one line
Write-output "Hello World"
Open Debug view
Open Debug Console
Click Start Debugging.  Script executes but nothing shows in Debug Console.

This is probably a usage issue since I am just starting with Visual Studio Code.  Thanks in advance for your assistance.

Can you please file this issue to the powershell extension here https://github.com/PowerShell/vscode-powershell
Maybe @daviwil can help here

Hey @BruceP99166, this is a known issue being tracked here: https://github.com/PowerShell/vscode-powershell/issues/284.  I'm planning to provide a fix for the next update of the extension, should be in a week or two.  Thanks for your patience!


Services - When autouprgade parameter is set for service images , auto upgrade is not triggered when you version is made available.

acorn version v0.7.0-alpha1-43-ge7fb1587+e7fb1587
Steps to reproduce the problem:
Deploy app that consumes a service using service image.
containers: {
  nginx: {
    image: "nginx"
    env: {
     "SECRET"<EMAIL_ADDRESS>     "ADDRESS"<EMAIL_ADDRESS>     "PORT"<EMAIL_ADDRESS>     "value1"<EMAIL_ADDRESS>     "value2"<EMAIL_ADDRESS>}
}
}
services: {
     mysec: {
	image: "<imgae>:v0.0.1"
        autoUpgrade: true
        autoUpgradeInterval: "15s"
        }
}

Make a version of service image made available .
Wait for > autoUpgradeInterval time.
There is no auto upgrade.
If we do not support autouprgades for service images, then app deployment should have errored out with a parsing error.

@g-linville i am going to make an assumption that this is going to be the same issue and root cause as what @cloudnautique was hitting. so, im using this issue to represent that

Merged to main.

Tested with acorn version - v0.7.0-alpha1-152-g1706098f+1706098f
Deploy app that consumes a service using service image.
containers: {
  nginx: {
    image: "nginx"
    env: {
     "NAME"<EMAIL_ADDRESS>     "PASSWORD"<EMAIL_ADDRESS>}
}
}
services: {
     mysec: {
        image: "<image>:v0.0.2"
        autoUpgrade: true
        autoUpgradeInterval: "15s"
        }
}

Make a new version of service image <image>:v0.0.2 made available .
Wait for autoUpgradeInterval time.
Consuming app gets auto upgraded and reflects the new changes from the new version of the service image.

Trying to deploys app with service images having autoupgrade format fails with defined: could not parse reference: <image>:v#.#.#  error.
Following is the Acornfile used for deploying app:
containers: {
  nginx: {
    image: "nginx"
    env: {
     "NAME"<EMAIL_ADDRESS>     "PASSWORD"<EMAIL_ADDRESS>}
}
}
services: {
     mysec: {
        image: "<image name>:v#.#.#"
        autoUpgrade: true
        autoUpgradeInterval: "15s"
        }
}

Tested with acorn version v0.7.0-alpha1-163-g7882f4c1+7882f4c1
Able to deploy app successfully with service images having auto upgrade tags.
Consuming apps get upgraded successfully when new versions of service image matching the auto upgrade tags is made available.


fix: fix fp with name axel by removing it from rce rule (932260 PL1)

This PR resolves #3644 by removing the German name Axel from RCE rule 932260. It also adds a test to validate the removal of the FP.

Thank you for the review @theseion.


Installing on OSX

What are the requirements for installation on OSX?
Using just pip3, I get an error saying that I need XCode installed (XCode 10 is already installed)
Thank you

Could you please post the detailed log? At least you should have pcl (C++), numpy and cython installed. In order to make cython available, a C/C++ compiler is needed. Maybe this is why it suggest you XCode.

I will close the issue by now as no further information is provided :)


The horrible situation of current translation effort

main translation repo is dead.
you can say it by looking at the long list of not handled PRs in the repo
Translation bot is dead. it doesn't push new commits or does not open new PRs. (I think it's due to renaming primary branch name from "master" to "main" in this repo but I'm not sure)
With current efforts for new docs #3308 and the emphasis on translations, it's an issue that at least should be discussed.
I'm the current maintainer of Persian translation effort and volunteering for any task to fix this situation in the upstream.

Hi, thanks for raising this! We know there’s a backlog of issues but we haven’t prioritised them because the old docs are mostly going to be replaced anyway, so all the focus is on getting them into shape that’s ready for a public beta and to start the next wave of translation effort. We expect that to happen in the next couple of months. As soon as we have a branch up and ready, we’ll need to work with the translation maintainers to figure out a strategy forward. But I wouldn’t suggest putting extra energy into translating the current content.

it doesn't push new commits or does not open new PRs. (I think it's due to renaming primary branch name from "master" to "main" in this repo but I'm not sure)

This sounds plausible. We should at least look into this and fix this.

Fix for the bot: https://github.com/reactjs/reactjs.org-translation/pull/170
I'm not sure how to verify the change so I'll ping @tesseralis who helped set it up!
We'll need the translation repos to do the branch rename too.

Hi @gaearon
Thanks for fix. I think we should wait until next Monday to verify it. This is the scheduled time for translation bot.
And about not putting more effort into the current docs, it's something I really love to do, some other people have put time into translation and opened PRs for it. Not handling them doesn't send the message I like.
I'm already excited for the new docs. From #3308 I understand it's gonna be more interactive and more like a game. I hope I18n is a first class citizen from the start.

Update: The bot still doesn't work, Things have gone worse actually, Updates don't get deployed anymore (also PR deployment previews) and the main site is stale.
@gaearon @rachelnabors @bvaughn

Hello hello! Following up here, @sJJdGG. We're in a bit of a fix—one of those the person who set this up moved on and the supporting system changed type things. We should know more in a week or two. But in the mean time, to move things along, if you could give @bvaughn a specific PR that's failing, we can continue our sleuthwork

@bvaughn @rachelnabors Hi! You can check it by browsing the tutorial page on Persian site and seeing it's not translated although it's been translated and already merged on main branch.
But Vercel check has already been passed on the main branch which should mean the last last changes have already been deployed!
This malfunctioning behavior started after the merge of reactjs/reactjs.org-translation#170. I've merged the tutorial page translation just after that. Main site deployments were good before that. So in addition to not having the Bot working, the deployments don't work either.
PR's preview deployments are working right now though. There used to some permission errors with Vercel bot but not anymore.

Ah. I think there's some confusion.
The most recent commit (from 2 days ago) was successfully built by Vercel and deployed here where you can see the tutorial page is translated properly.
However the docs site at fa.reactjs.org is still hosted on Gatsby (not Vercel yet). So it seems like something is wrong with the Gatsby configuration.

Looks like for some reason, the Netlify settings for fa.reactjs.org still pointed to the master branch. Let me change that and see if it fixes things.

It's fixed!
https://fa.reactjs.org/tutorial/tutorial.html
I just went through the 40ish other configurations and updated them too. Hopefully this will all get better soon. Sorry for the trouble!

Thanks @bvaughn!
Shouldn't we keep the issue open until the synchronizer bot gets fixed?

Sorry. I didn't realize it was still broken.
Your most recent comment about the bot said:

Update: The bot still doesn't work, Things have gone worse actually, Updates don't get deployed anymore (also PR deployment previews) and the main site is stale.

But updates should now be getting deployed successfully.
What's not working?

The synchronizer bot
It's responsible for pushing new commits from reactjs.org repo to all translation repos.
Right now it's not working and all translation repos are stale and behind this repo.

I see.
I don't see a reason why that would be the case, looking through the bot's code, but I don't have any context on how or where this bot runs or how to configure it. The project's README doesn't have instructions for how to run or test it. 😅

I tried running the script locally to see if that revealed anything:
node scripts/sync.js config.json langs/fa.json

It seems to checkout the repo correctly, run a pull script and merge changes, but then it fails when it tries to push the changes:

UnhandledPromiseRejectionWarning: HttpError: Bad credentials
at /Users/bvaughn/Documents/git/reactjs.org-translation/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async createPullRequest (/Users/bvaughn/Documents/git/reactjs.org-translation/scripts/sync.js:162:7)

That being said, it looks like the bot checks out the translation repos within a local "repo" folder. I wonder if the checkouts just need to be wiped out and recreated or something (after the branch change)?

Digging in further, I wonder if the master -> main branch rename was just a coincidence? I see this error after adding an auth token and re-running the sync script:

remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
fatal: unable to access 'https://github.com/reactjs/es.reactjs.org.git/': The requested URL returned error: 403

@bvaughn I'm more clueless than you since I don't have access to anything except our own repo. I just know that the last sync PR was opened on Jul 5 (reactjs/fa.reactjs.org/pull/226) and so some change must have happened after that and the only suspect was renaming of the main branch in the upstream repo.

Fair enough.
I'm going to go ahead and run the sync locally (with my user) to create PRs as a one time temporarily solution to buy some time.

Also the translations status page is back up now and being served from a new URL:
https://translations.reactjs.org/

@bvaughn Thank you for the PRs. Let me know if I can be any help

I've setup a new script and bot for this. Sync PRs were pushed for all translation forks this morning and will run weekly from now on. I'm going to close this issue for now, since (I think) things are taken care of. Let us know if new problems pop up please.

Issue for new doc translations: https://github.com/reactjs/reactjs.org/issues/4135


Add 2.1.1 change log

Date is set to 2023-09-16, so if you want to release today (15th) or after tomorrow, we have to change it.
(Unreleted note: Today I learned why I had so much pain with git before... git fetch doesn't do anything really, only git fetch --all.)

Thanks! I'll see when I'll release this. I might do this after testing the changes on my project at work on monday, but I'll take care of the date changes and formatting it up like the rest.


Jimix/23 pushpull

Resolves #23
@mkistler: please ACK when you get a chance

Well.. it turns out that the CDTReplicatorFactory is single use as well.
At least we have improved the error message :)

ACK.  I've reviewed 425a7ed and all looks good to me.


Update MSYS2 base

Hey, this is the future packager for MSYS2. I uploaded a new database recently and reverted it after a few hours due to reports of issues. I even received one issue from a concerned vcpkg user. Due to a bunch of stuff coming together, we don't see a way to make the upgrade path work cleanly for old installations (from an old installer or just not upgraded for a while). Therefore I suggest that vcpkg switch to the current MSYS2 installer which should have the correct keyring. How realistic is this for you?
[notifying @lazka]

The vcpkg log:
-- Acquiring MSYS2...
-- Downloading https://sourceforge.net/projects/msys2/files/Base/x86_64/msys2-base-x86_64-20190524.tar.xz/download...
gpg: /etc/pacman.d/gnupg/trustdb.gpg: trustdb created
gpg: no ultimately trusted keys found
gpg: starting migration from earlier GnuPG versions
gpg: porting secret keys from '/etc/pacman.d/gnupg/secring.gpg' to gpg-agent
gpg: migration succeeded
gpg: Generating pacman keyring master key...
gpg: key 69A4A79979944FCF marked as ultimately trusted
gpg: directory '/etc/pacman.d/gnupg/openpgp-revocs.d' created
gpg: revocation certificate stored as '/etc/pacman.d/gnupg/openpgp-revocs.d/5EECEBF3DABCBC4C358437EE69A4A79979944FCF.rev'
gpg: Done
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
==> Appending keys from msys2.gpg...
==> Locally signing trusted keys in keyring...
  -> Locally signing key D55E7A6D7CE9BA1587C0ACACF40D263ECA25678A...
  -> Locally signing key 123D4D51A1793859C2BE916BBBE514E53E0D0813...
  -> Locally signing key B91BCF3303284BF90CC043CA9F418C233E652008...
  -> Locally signing key 9DD0D4217D75A33B896159E6DA7EF2ABAEEA755C...
==> Importing owner trust values...
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: inserting ownertrust of 4
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   4  trust: 0-, 0q, 0n, 0m, 0f, 1u
gpg: depth: 1  valid:   4  signed:   3  trust: 0-, 0q, 0n, 4m, 0f, 0u
gpg: depth: 2  valid:   3  signed:   0  trust: 3-, 0q, 0n, 0m, 0f, 0u
:: Synchronizing package databases...
downloading mingw32.db...
downloading mingw32.db.sig...
error: mingw32: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" is unknown
:: Import PGP key 4096R/87771331B3F1FF5263856A6D974C8BE49078F532, "David Macek<EMAIL_ADDRESS>created: 2018-01-14? [Y/n] error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: failed to update mingw32 (invalid or corrupted database (PGP signature))

downloading mingw64.db...
downloading mingw64.db.sig...
error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: failed to update mingw64 (invalid or corrupted database (PGP signature))
downloading msys.db...
downloading msys.db.sig...
error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: failed to update msys (invalid or corrupted database (PGP signature))
error: failed to synchronize all databases
error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
checking dependencies...

Packages (2) rebase-4.4.4-1  dash-<IP_ADDRESS>-1

Total Removed Size:  1.12 MiB

:: Do you want to remove these packages? [Y/n]
:: Processing package changes...
removing rebase...
removing dash...
error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
:: Synchronizing package databases...
downloading mingw32.db...
downloading mingw32.db.sig...
error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: failed to update mingw32 (invalid or corrupted database (PGP signature))
downloading mingw64.db...
downloading mingw64.db.sig...
error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: failed to update mingw64 (invalid or corrupted database (PGP signature))
downloading msys.db...
downloading msys.db.sig...
error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust
error: failed to update msys (invalid or corrupted database (PGP signature))
error: failed to synchronize all databases
-- Acquiring MSYS2... OK
-- Acquiring MSYS Packages...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: C:/vcpkg/downloads/tools/msys2/msys64/usr/bin/bash.exe --noprofile --norc -c "pacman -S --noconfirm --needed make automake1.15"
    Working Directory: C:/vcpkg/downloads/tools/msys2
    Error code: 1
    See logs for more information:
     C:\vcpkg\buildtrees\icu\msys-pacman-x64-windows-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_acquire_msys.cmake:127 (vcpkg_execute_required_process)
  ports/icu/portfile.cmake:80 (vcpkg_acquire_msys)
  scripts/ports.cmake:76 (include)

The vcpkg log:

-- Acquiring MSYS2...

-- Downloading https://sourceforge.net/projects/msys2/files/Base/x86_64/msys2-base-x86_64-20190524.tar.xz/download...

gpg: /etc/pacman.d/gnupg/trustdb.gpg: trustdb created

gpg: no ultimately trusted keys found

gpg: starting migration from earlier GnuPG versions

gpg: porting secret keys from '/etc/pacman.d/gnupg/secring.gpg' to gpg-agent

gpg: migration succeeded

gpg: Generating pacman keyring master key...

gpg: key 69A4A79979944FCF marked as ultimately trusted

gpg: directory '/etc/pacman.d/gnupg/openpgp-revocs.d' created

gpg: revocation certificate stored as '/etc/pacman.d/gnupg/openpgp-revocs.d/5EECEBF3DABCBC4C358437EE69A4A79979944FCF.rev'

gpg: Done

==> Updating trust database...

gpg: marginals needed: 3  completes needed: 1  trust model: pgp

gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u

==> Appending keys from msys2.gpg...

==> Locally signing trusted keys in keyring...

  -> Locally signing key D55E7A6D7CE9BA1587C0ACACF40D263ECA25678A...

  -> Locally signing key 123D4D51A1793859C2BE916BBBE514E53E0D0813...

  -> Locally signing key B91BCF3303284BF90CC043CA9F418C233E652008...

  -> Locally signing key 9DD0D4217D75A33B896159E6DA7EF2ABAEEA755C...

==> Importing owner trust values...

gpg: setting ownertrust to 4

gpg: setting ownertrust to 4

gpg: setting ownertrust to 4

gpg: inserting ownertrust of 4

==> Updating trust database...

gpg: marginals needed: 3  completes needed: 1  trust model: pgp

gpg: depth: 0  valid:   1  signed:   4  trust: 0-, 0q, 0n, 0m, 0f, 1u

gpg: depth: 1  valid:   4  signed:   3  trust: 0-, 0q, 0n, 4m, 0f, 0u

gpg: depth: 2  valid:   3  signed:   0  trust: 3-, 0q, 0n, 0m, 0f, 0u

:: Synchronizing package databases...

downloading mingw32.db...

downloading mingw32.db.sig...

error: mingw32: key "4A6129F4E4B84AE46ED7F635628F528CF3053E04" is unknown

:: Import PGP key 4096R/87771331B3F1FF5263856A6D974C8BE49078F532, "David Macek<EMAIL_ADDRESS>created: 2018-01-14? [Y/n] error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: failed to update mingw32 (invalid or corrupted database (PGP signature))

downloading mingw64.db...

downloading mingw64.db.sig...

error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: failed to update mingw64 (invalid or corrupted database (PGP signature))

downloading msys.db...

downloading msys.db.sig...

error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: failed to update msys (invalid or corrupted database (PGP signature))

error: failed to synchronize all databases

error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

checking dependencies...

Packages (2) rebase-4.4.4-1  dash-<IP_ADDRESS>-1

Total Removed Size:  1.12 MiB

:: Do you want to remove these packages? [Y/n]

:: Processing package changes...

removing rebase...

removing dash...

error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

:: Synchronizing package databases...

downloading mingw32.db...

downloading mingw32.db.sig...

error: mingw32: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: failed to update mingw32 (invalid or corrupted database (PGP signature))

downloading mingw64.db...

downloading mingw64.db.sig...

error: mingw64: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: failed to update mingw64 (invalid or corrupted database (PGP signature))

downloading msys.db...

downloading msys.db.sig...

error: msys: signature from "David Macek<EMAIL_ADDRESS>is marginal trust

error: failed to update msys (invalid or corrupted database (PGP signature))

error: failed to synchronize all databases

-- Acquiring MSYS2... OK

-- Acquiring MSYS Packages...

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):

    Command failed: C:/vcpkg/downloads/tools/msys2/msys64/usr/bin/bash.exe --noprofile --norc -c "pacman -S --noconfirm --needed make automake1.15"

    Working Directory: C:/vcpkg/downloads/tools/msys2

    Error code: 1

    See logs for more information:

     C:\vcpkg\buildtrees\icu\msys-pacman-x64-windows-err.log

Call Stack (most recent call first):

  scripts/cmake/vcpkg_acquire_msys.cmake:127 (vcpkg_execute_required_process)

  ports/icu/portfile.cmake:80 (vcpkg_acquire_msys)

  scripts/ports.cmake:76 (include)

@FuckYou2Bill, what?

@emptyVoid might be interested as well.

@elieux, ss far as I understand MSYS2 dropped i686 installer since 2020-05-22, whereas vcpkg still supports x86 host platforms. That's kind of a blocker for updating MSYS2 version used by vcpkg.

How big of an issue is to keep that older x86 version and update the x64 version?

I don't think it's a good idea, since it would potentially require different installation scripts as the versions diverge further from each other. Moreover wouldn't your above-mentioned changes break x86 version?

They don't until we decide to also build an msys-i686 package, which we currently don't plan to. But if you prefer to keep the versions in sync, would you be willing to adapt the installation script to update the keyring first? I'll be writing down the exact steps soon for our "manual intervention needed" section.

But if you prefer to keep the versions in sync, would you be willing to adapt the installation script to update the keyring first?

Sure.
BTW, shouldn't pacman-key --init; pacman-key --populate take care of the official keys?

It would, if we hadn't also added new master keys. We couldn't get all the original master key holders. The previous packager also quit somewhat abruptly, so now it's either stall or break.
(There's an option to update the msys-i686 packages and installers for the last time, which would allow vcpkg to update to the newer installers, but it would immediately break all the older 32-bit installations.)

Instructions are up: https://www.msys2.org/news/#2020-06-29-new-packagers

@elieux, I followed the instruction you mention, and it gives me an error message:
==> ERROR: The signature identified by D:/Projects/GitHub/vcpkg/downloads/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz could not be verified.

@emptyVoid, did it say anything else?
My output:
$ pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz{.sig,}
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig... (detached)
gpg: Signature made Mon Jun 29 07:36:14 2020 CEST
gpg:                using DSA key AD351C50AE085775EB59333B5F92EFC1A47D45A1
gpg: Note: trustdb not writable
gpg: Good signature from "Alexey Pavlov (Alexpux<EMAIL_ADDRESS>[full]

Swapped arguments:
$ pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz{,.sig}
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz... (detached)
gpg: [don't know]: invalid packet (ctb=3f)
gpg: no signature found
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
==> ERROR: The signature identified by msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz could not be verified.

Broken signature file:
$ pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz{.sig,}
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig... (detached)
gpg: mpi too large (19456 bits)
gpg: mpi too large (65059 bits)
gpg: no signature found
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
==> ERROR: The signature identified by msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig could not be verified.

@elieux, here's an output using fresh msys2-base-x86_64-20190524.tar.xz:
D:\Downloads>.\msys64\usr\bin\bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --init;pacman-key --populate"
gpg: /etc/pacman.d/gnupg/trustdb.gpg: trustdb created
gpg: no ultimately trusted keys found
gpg: starting migration from earlier GnuPG versions
gpg: porting secret keys from '/etc/pacman.d/gnupg/secring.gpg' to gpg-agent
gpg: migration succeeded
gpg: Generating pacman keyring master key...
gpg: key B6CACBD9B16AE8B1 marked as ultimately trusted
gpg: directory '/etc/pacman.d/gnupg/openpgp-revocs.d' created
gpg: revocation certificate stored as '/etc/pacman.d/gnupg/openpgp-revocs.d/9E3F525FEA5D7EB851491049B6CACBD9B16AE8B1.rev'
gpg: Done
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
==> Appending keys from msys2.gpg...
==> Locally signing trusted keys in keyring...
  -> Locally signing key D55E7A6D7CE9BA1587C0ACACF40D263ECA25678A...
  -> Locally signing key 123D4D51A1793859C2BE916BBBE514E53E0D0813...
  -> Locally signing key B91BCF3303284BF90CC043CA9F418C233E652008...
  -> Locally signing key 9DD0D4217D75A33B896159E6DA7EF2ABAEEA755C...
==> Importing owner trust values...
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: setting ownertrust to 4
gpg: inserting ownertrust of 4
==> Updating trust database...
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   4  trust: 0-, 0q, 0n, 0m, 0f, 1u
gpg: depth: 1  valid:   4  signed:   3  trust: 0-, 0q, 0n, 4m, 0f, 0u
gpg: depth: 2  valid:   3  signed:   0  trust: 3-, 0q, 0n, 0m, 0f, 0u

D:\Downloads>.\msys64\usr\bin\bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz{.sig,}"
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: assuming signed data in 'msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz'
gpg: Signature made Mon Jun 29 08:36:14 2020 RTZST
gpg:                using DSA key AD351C50AE085775EB59333B5F92EFC1A47D45A1
gpg: Good signature from "Alexey Pavlov (Alexpux<EMAIL_ADDRESS>[full]
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz...
gpg: [don't know]: invalid packet (ctb=3f)
gpg: no signature found
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
==> ERROR: The signature identified by msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz could not be verified.

Swapped arguments:
D:\Downloads>.\msys64\usr\bin\bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz{,.sig}"
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz...
gpg: [don't know]: invalid packet (ctb=3f)
gpg: no signature found
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
==> ERROR: The signature identified by msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz could not be verified.
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: assuming signed data in 'msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz'
gpg: Signature made Mon Jun 29 08:36:14 2020 RTZST
gpg:                using DSA key AD351C50AE085775EB59333B5F92EFC1A47D45A1
gpg: Good signature from "Alexey Pavlov (Alexpux<EMAIL_ADDRESS>[full]

Explicit arguments:
D:\Downloads>.\msys64\usr\bin\bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz"
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: assuming signed data in 'msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz'
gpg: Signature made Mon Jun 29 08:36:14 2020 RTZST
gpg:                using DSA key AD351C50AE085775EB59333B5F92EFC1A47D45A1
gpg: Good signature from "Alexey Pavlov (Alexpux<EMAIL_ADDRESS>[full]
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz...
gpg: [don't know]: invalid packet (ctb=3f)
gpg: no signature found
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
==> ERROR: The signature identified by msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz could not be verified.

Oh. For some reason, pacman-key seems to interpret both arguments as detached signatures. Just pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig should work then. I wonder if pacman-key from 2019-05-24 just doesn't support the explicit syntax, or there's something else at play. I would try it myself in a local setup, but I'm on a metered connection.
These are my current versions:
$ pacman-key --version
pacman-key (pacman) 5.2.1
[...]

$ gpg --version
gpg (GnuPG) 2.2.20-unknown
[...]

Versions from msys2-base-x86_64-20190524.tar.xz:
D:\Downloads>.\msys64\usr\bin\bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --version"
pacman-key (pacman) 5.1.3
...

D:\Downloads>.\msys64\usr\bin\bash.exe --noprofile --norc -c "PATH=/usr/bin;gpg --version"
gpg (GnuPG) 2.2.15-unknown
...

Yeah, pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig works as long as the package is located in the same directory.


This is the question of how to change the code (human body[14 point]->human hand[21point])

This is the question of how to change the code (human body[14 point]->human hand[21point])
As shown in the post below, I have changed that part.
1.dataset_augment.py

"class CocoPart(Enum)"
"def pose_flip(meta)" -> "flip_list"

2.dataset_prepare.py

"def init" -> "transform = list(zip())"
"class CocoMetadata:" -> "__coco_parts = 21"

I have a question.
The human body is 14 points. The human hand is 21 points.
So other things can be changed simply by numbers.
But what regularity should this be and change?
Below is the existing code.
transform = list(zip(
[1, 2, 4, 6, 8, 3, 5, 7, 10, 12, 14, 9, 11, 13],
[1, 2, 4, 6, 8, 3, 5, 7, 10, 12, 14, 9, 11, 13]
))
Then I changed it to new below.
transform = list(zip(
[1, 2, 4, 6, 8, 3, 5, 7, 10, 12, 14, 9, 11, 13, 15, 17, 19, 16, 18, 20, 21],
[1, 2, 4, 6, 8, 3, 5, 7, 10, 12, 14, 9, 11, 13, 15, 17, 19, 16, 18, 20, 21]
))
But I don't know if I did it correctly.

And can anyone please help me with the rules of exactly how to make this variable?


No progress bar when running subsequent ServiceX queries

This was reported to Coffea-Casa by @mat-adamec
This is probably a ServiceX issue rather than a coffea-casa one, but if you run two ServiceX queries, e.g.:
jet_p4 = ds.Where(lambda event: event.nJet > 0)\
                    .Select(lambda event: Zip({'pt': event.Jet_pt,
                                        'eta': event.Jet_eta,
                                        'phi': event.Jet_phi,
                                        'mass': event.Jet_mass}).ToFourMomenta().Where(lambda jet: jet.pt > 30)).AsAwkwardArray().value()

muon_p4 = ds.Select(lambda event: Zip({'p4': Zip({'pt': event.Muon_pt,
                                                  'eta': event.Muon_eta,
                                                  'phi': event.Muon_phi,
                                                  'mass': event.Muon_mass}).ToFourMomenta(),
                                           'isMed': event.Muon_mediumId
                                     })
                       .Where(lambda light_mu: light_mu.isMed == 0)
                       .Where(lambda mu_pt: mu_pt.p4.pt > 10)
                       .Select(lambda mu: mu.p4)).AsAwkwardArray().value()

You'll get a progress bar for the first (in this case, jet_p4) but not for the second (in this case, muon_p4). This makes it look like the JupyterLab has frozen until the second query is also done processing.

Ah - those are run in the same cell? I've never tried that. I'm sure that is a bug. Sadly, it might be in the progress bar library, tqdm, which has lots of very weird code. We'll look.

I guess we can close this? as we don't use tdqm anymore?

I think it is technically true that weird things still happen in notebooks if you attempt to rerun the same cell, although I think this is not a progress bar issue.

That's correct - I usually restart Jupyter kernel to rerun the same cell. But as you said I guess it's not a progress bar issue described in this issue :)

You restart the notebook to run any cell? That sounds... wasteful... We should support that. But that said, this is quite old and feels like it needs to be re-run to make sure it is still a bug.


Setting flow control for ISO15765 11bit Id

how do i properly set flow control for 11bit id ??
Can you share an example ?
RP1210_Set_ISO15765_Flow_Control.....

Hi @czechu82! Unfortunately, I can't tell you since I never broke out any extra functionality for ISO 15765 - I was focused almost entirely on expanding J1939 support when I was still actively working on this project.
We had a ticket open for ISO 15765 (#101), but unfortunately never got to it.