Implement func array_pop_front

Which issue does this PR close?

Closes #6996 .
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb @jayzhan211  hi! this PR is ready for review now! : )

@Veeupup Would you like to try rewriting array_pop_front / back with MutableArrayData? I think it will be much easier to understand than the current slice! and list_slice! macros.

@Veeupup Would you like to try rewriting array_pop_front / back with MutableArrayData? I think it will be much easier to understand than the current slice! and list_slice! macros.

yeah, agree with you.. to understand what slice! macro does cost me some time..
but this macro has been used for some other functions and for now implementation with slice! maybe the simplest way to do with it?

@Veeupup Would you like to try rewriting array_pop_front / back with MutableArrayData? I think it will be much easier to understand than the current slice! and list_slice! macros.

yeah, agree with you.. to understand what slice! macro does cost me some time..
but this macro has been used for some other functions and for now implementation with slice! maybe the simplest way to do with it?

If you also spend much time on slice!, it is a good reason for us to improve on this.

Thanks @Veeupup Please more tests with nulls and empty arrays, please try to think up any possible case to prevent bug to flow in.
And since new built in function gets introduced we need to get this documented in scalar_functions.md and expressions.md

very thanks for your advice! docs have been added!
and the test for empty and NULL has already added, and you can check empty array test and NULL value test.


Correct for antenna effect somehow

So I finally got everything setup. And Im also getting unexpected results
I've got rooms and two floors. I have espresense nodes over two floor.
Now for testing, I just focused on a single floor.
Initially I saw the devices in the wrong places, thinking this was due to the number of sensors, I then change the second floor nodes so they are on first floor but higher. However this made no difference.

Looking at the ipad, espresnese itself thinks it is connected to the frontroom sensor, but this isnt even showing as one of the three for the mapping sensors for companion.
What occurred to me was I have brick walls, and this will be impacting the distance. So maybe when we draw walls we need to provide a correction factor due to the wall, some manual value we can derive from testing.
And using the sensors over the many floors, will also be handy as people who dont have concrete floors will be able to take advantage of the 3 dimensions for mapping.
But myAnd using the sensors over the many floors, will also be handy as people who dont have concrete floors will be able to take advantage of the 3 dimensions for mapping. overwhelming view is that ESPresense companion is starting to look like a viable option to give a position in a room, but it clearly needs tweaking.
Originally posted by @rhamblen in https://github.com/ESPresense/ESPresense-companion/issues/94#issuecomment-1623369195

Question that comes to mind (relating to my own setup) would be if walls are 'included' in the calculation and iterative absorption etc.?
I would have to create appropriate screenshots but I have a somewhat likewise issue; 3 floors and a fair number of sensors. Complicating factor is I have 3 sensors downstairs (on 3 different ESP boards), two upstairs (same ESP) and 2 in the attic (different ESPs). So device (or antenna) correction would be in play, but the floor walls are standardized (7cm) 'aerated concrete' (for lack of better translation) while the floors are 'reinforced concrete' (20cm).
What puzzled me is that a device about 2m away from the sensor in the bedroom actually shows about 1.47m in the dashboard (all others are above 3m indicated correctly) - it still would device that the attic device was the winner. That defied my understanding of the logic. Same seemed to happen with other devices above/below - but would have presumed the 'most devices' would win, but I had something shown 'downstairs' even though downstairs had 3 devices and upstairs 5 ...
I've read up in the meantime and mean to place the sensors 'further out' in the corners (with one in the middle) as suggested by the documentation, though that requires some readjustment of sockets/placement. Question would be if it helps understanding this issue (and my connection/relation to it) if I would attempt to place 3 sensors bottom and 3 sensors attic and one 'as central' as possible. (Unfortunately I won't be able to fully place 4 corners in the attic, I might be able to do so on the ground floor. I did not play around with the rssi@1m yet - and as said, the different esp's might be a complicating factor. (Used one atom m5, 2 esp32-s3-mini's and some older 'regular' esp32's).

This paper has a floor classifier that could be a big improvement: https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=8792196

Should not be closed, right?

Should it?

I still have the same questions but it seems there's really no interest in sorting things out.

Hopefully @DTTerastar is just busy with IRL issues and can continue the presence project soon?

Might still be relevant?

definitely still relevant

Any updates on this @DTTerastar? I continue to have issues like you listed in your original post in my two story home.


Update dependency com.revenuecat.purchases:purchases-hybrid-common to v10.8.0

This PR contains the following updates:

Package
Type
Update
Change

com.revenuecat.purchases:purchases-hybrid-common
dependencies
minor
10.7.0 -> 10.8.0

Release Notes

RevenueCat/purchases-hybrid-common (com.revenuecat.purchases:purchases-hybrid-common)
v10.8.0
Compare Source
Dependency Updates

[AUTOMATIC] iOS 4.41.2 => 4.42.0 Android 7.10.1 => 7.11.0 (#826) via RevenueCat Git Bot (@RCGitBot)
Bump lefthook from 1.6.11 to 1.6.14 (#824) via dependabot[bot] (@dependabot[bot])
Bump lefthook from 1.6.10 to 1.6.11 (#816) via dependabot[bot] (@dependabot[bot])
Bump rexml from 3.2.6 to 3.2.8 (#820) via dependabot[bot] (@dependabot[bot])

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Closed to let renovate reopen under a different user.


Implement Circle CI -> Discord Webhook

To implement Circle CI -> Discord webhook, you can look at the Travis CI script for reference:
https://raw.github.com/DiscordHooks/travis-ci-discord-webhook/master/send.sh
Circle CI docs: https://circleci.com/docs/2.0/

Implemented it as https://github.com/DiscordHooks/circle-ci-discord-webhook/pull/4 since we where migrating from TravisCI to CircleCI: https://github.com/diasurgical/devilution/blob/master/.circleci/are-we-d1-yet.sh

@AJenbo have you tested if it's working? I don't have any of my devops process set up with Circle, so if you've tested it, I'll merge it.

Yes

Yeah, that'd be nice.


The submittion question

Hi，thanks for your great work.
I encountered an issue when trying to submit test submission file to the leaderboard. I received the following error message: "Error: The provided trajectory moves from 6673e7995dcc444eb18cf01845cf2915 to 7606ea285d5e4a9280220c1d823fdb80 but the navigation graph contains no edge between these viewpoints. Please ensure the provided navigation trajectories are valid so that the trajectory length can be accurately calculated."
Could you please advise on how to resolve this issue?
I appreciate your response.
Thank you！！！

We've never been in this situation. Where did the JSON file you submitted to the leaderboard come from? Is it submitted to the R2R benchmark? Is the format correct? You'll need to carefully check the submitted JSON file generation process.

Hi，
I have already solved this issue.
Thank you for your help！

Happy to see that :)


SEMI: recommendation api

the entrypoint is ```recommend_for_method'''

@acheshkov made the changes you suggested, please check


HDFS connector + parquet format, fails to find native libs.

Looks like https://github.com/xerial/snappy-java/issues/181
i.e. using:
"format.class": "io.confluent.connect.hdfs.parquet.ParquetFormat",
with hdfs fails, apparently due to the base alpine image.
I switched the image from alpine to https://github.com/frol/docker-alpine-glibc, and it worked.
I also put snappy-java into the connect-extra-jars dir, so it's possible I've mis-diagnosed this.

Thanks for the report! I've missed this issue which extends to other parts of the image (e.g you can't use console producer with snappy).
I just added glibc to fast-data-dev so I hope the issue is fixed for you (I only tested with the console producer).
Funny thing is we already use glibc in the Lenses branch(es) of fast-data-dev due to the exact same issue as well as java rocksdb support (also C++ code and needs glibc).
Thanks again!


'Placeholder' is not exported from 'semantic-ui-react`

import {Placeholder} from 'semantic-ui-react' is giving me the error 'Placeholder' is not exported from 'semantic-ui-react'.
version: "semantic-ui-react": "^0.82.5",

Updated the version to 0.88.1. Issue resolved.


*: remove dependency on github.com/prometheus/prometheus

We depend on the Prometheus repository only for the github.com/prometheus/prometheus/pkg/labels package and from this package, we use only the Matcher struct.
Knowing that this code hasn't evolved for years now, it seems safe and simpler to duplicate it in AlertManager rather than the heavy dependency we have right now (see #2008). In addition Prometheus has an indirect dependency on github.com/hashicorp/memberlist and many other Hashicorp libs which can cause version changes whenever we need to bump github.com/prometheus/prometheus.

Once we unify the two labels packages, we might want to kick this to common.

Once we unify the two labels packages, we might want to kick this to common.

I thought we were going away from common.


Using circuits as models for other circuits

I'm trying to build a hierarchical circuit that uses a subcircuit as a model.
Something like:
top_circuit:
instances: {- model
- sub_circuit}
If I naively try to add a circuit as a model I get the following error message: AttributeError: 'function' object has no attribute 'items'
Here is a minimum (non-)working example:

import sax
import numpy as np

def ring(length=200.0, coupling=0.1, prop_loss=0.1, neff=1.4, ng=1.4, wl0=1.5, wl=1.5):

    ring_sax, _ = sax.circuit(
        netlist={
            "instances": {
                "dc": {"component": "coupler", "settings": {"coupling": coupling}},
                "top": {
                    "component": "straight",
                    "settings": {
                        "length": length,
                        "loss": prop_loss,
                        "neff": neff,
                        "ng": ng,
                        "wl0": wl0,
                        "wl": wl,
                    },
                },
            },
            "connections": {
                "dc,out1": "top,in0",
                "top,out0": "dc,in1",
            },
            "ports": {
                "in0": "dc,in0",
                "out0": "dc,out0",
            },
        },
        models={
            "coupler": sax.models.coupler,
            "straight": sax.models.straight,
        },
    )

    return ring_sax

def ring_test(ring_length=10.0, ring_prop_loss=1.0, ring_coupling=0.001, neff=1.4, ng=1.4, wl0=1.3, wl=1.3):

    r_model, _ = sax.circuit(
        netlist={
            "instances": {
                "wg": {
                    "component": "straight",
                    "settings": {
                        "length": 100.0,
                        "loss": 0.1,
                        "neff": neff,
                        "ng": ng,
                        "wl0": wl0,
                        "wl": wl,}
                },
                "ring_ps": {
                    "component": "ring",
                    "settings": {
                        "length": ring_length,
                        "coupling": ring_coupling,
                        "prop_loss": ring_prop_loss,
                        "neff": neff,
                        "ng": ng,
                        "wl0": wl0,
                        "wl": wl,}
                },
            },
            "connections": {
                "wg,out0":"ring_ps,in0",
            },
            "ports": {
                "in0":"wg,in0",
                "out0":"ring_ps,out0",
            },
        },
        models={
            "straight": sax.models.straight,
            "ring": ring,
        },

    )

    return r_model

wl = np.linspace(1.265, 1.285, 1000)
ring_circuit = ring_test(wl=wl)
ring_circuit()

If in the models dictionary I do "ring": ring(),, then there's no error but the results are not correct (it acts as if there were no ring).
Am I missing something?
Thank you!

i believe
models={
            "straight": sax.models.straight,
            "ring": ring,
        },

is correct
but you should
    return ring_sax()

(note added parentheses)
at the end of your ring() function definition

I just tried and it still does not work. It does not result in an error but it acts as if there was no ring element in the circuit.

Hi @mdecea , sax.circuit returns a function (which returns an S-matrix), not an S-matrix itself! You can leave out the wrapping functions to make it work:
ring, _ = sax.circuit(
    netlist={
        "instances": {
            "dc": "coupler",
            "top": "straight",
        },
        "connections": {
            "dc,out1": "top,in0",
            "top,out0": "dc,in1",
        },
        "ports": {
            "in0": "dc,in0",
            "out0": "dc,out0",
        },
    },
    models={
        "coupler": sax.models.coupler,
        "straight": sax.models.straight,
    },
)
ring_test, _ = sax.circuit(
    netlist={
        "instances": {
            "wg": "straight",
            "ring_ps": "ring",
        },
        "connections": {
            "wg,out0": "ring_ps,in0",
        },
        "ports": {
            "in0": "wg,in0",
            "out0": "ring_ps,out0",
        },
    },
    models={
        "straight": sax.models.straight,
        "ring": ring,
    },
)

wl = np.linspace(1.265, 1.285, 1000)
ring_test()

{('out0', 'out0'): Array(0.+0.j, dtype=complex64),
 ('out0', 'in0'): Array(0.7785834+0.5514743j, dtype=complex64),
 ('in0', 'out0'): Array(0.7785834+0.5514743j, dtype=complex64),
 ('in0', 'in0'): Array(0.+0.j, dtype=complex64)}

If you really want or need to wrap the resulting circuit functions in a new model function, it's best (for jax-related performance reasons) to leave the creation of the circuit outside the new model function. Something like this would work:
_ring, _ = sax.circuit(
    netlist={
        "instances": {
            "dc": "coupler",
            "top": "straight",
        },
        "connections": {
            "dc,out1": "top,in0",
            "top,out0": "dc,in1",
        },
        "ports": {
            "in0": "dc,in0",
            "out0": "dc,out0",
        },
    },
    models={
        "coupler": sax.models.coupler,
        "straight": sax.models.straight,
    },
)

def ring(length=200.0, coupling=0.1, prop_loss=0.1, neff=1.4, ng=1.4, wl0=1.5, wl=1.5):
    return _ring(
        dc={"coupling": coupling},
        top={
            "length": length,
            "loss": prop_loss,
            "neff": neff,
            "ng": ng,
            "wl0": wl0,
            "wl": wl,
        },
    )

_ring_test, _ = sax.circuit(
    netlist={
        "instances": {
            "wg": "straight",
            "ring_ps": "ring",
        },
        "connections": {
            "wg,out0": "ring_ps,in0",
        },
        "ports": {
            "in0": "wg,in0",
            "out0": "ring_ps,out0",
        },
    },
    models={
        "straight": sax.models.straight,
        "ring": ring,
    },
)

def ring_test(
    ring_length=10.0,
    ring_prop_loss=1.0,
    ring_coupling=0.001,
    neff=1.4,
    ng=1.4,
    wl0=1.3,
    wl=1.3,
):
    return _ring_test(
        wg={"length": 100.0, "loss": 0.1, "neff": neff, "ng": ng, "wl0": wl0, "wl": wl},
        ring_ps={
            "length": ring_length,
            "coupling": ring_coupling,
            "prop_loss": ring_prop_loss,
            "neff": neff,
            "ng": ng,
            "wl0": wl0,
            "wl": wl,
        },
    )

{('out0', 'out0'): Array(0.+0.j, dtype=complex64),
 ('out0', 'in0'): Array(-0.11200467-0.29557914j, dtype=complex64),
 ('in0', 'out0'): Array(-0.11200467-0.29557914j, dtype=complex64),
 ('in0', 'in0'): Array(0.+0.j, dtype=complex64)}

The reason you can provide settings to the netlist on the creation of the circuit is usually just to set defaults. If you want to make it parametrizable, the approach in my second example is advised as it keeps the resulting model function nice and pure
Let me know if you have any more questions.

Thanks a lot for the detailed answer @flaport ! I think I got it


Upgrade pulumi-terraform-bridge to v3.59.0

This PR was generated via $ upgrade-provider pulumi/pulumi-aiven --kind bridge.

Upgrading pulumi-terraform-bridge from v3.57.0 to v3.59.0.

I assume Luke's check is not required here since we're not updating upstream at all, this is just a routine dependency update. Thanks!


Restricted containers

I've broken each change into it's own commit that explains the change. I made some changes to the main plugin as well:

Added a logger.
Changed the resource costs from 50 to 10 for the barrels to match Vanilla container costs and DynamicStoragePiles.
Changed how BuildPieces are created in the Awake() method to reduce extra lines of code and avoid having to manually write out what the allowable items are for every single barrel.

You'll need to adjust your csproj file to include the "RestrictContainers.cs" file. I had to edit the csproj file quite a bit to get it running on my machine and I don't want to push that to yours.
You'll also need to build this and confirm it's working as intended on your machine since ILRepack keeps throwing a fit on my machine.

Awesome


jobsub_lite should use tokens for authentication to RCDS frontend webserver

jobsub_lite should use tokens for authentication to RCDS frontend webserver.  This needs to wait until the RCDS service has tokens enabled.  Then we can test this.

Duplicated by #31 which has more detail.  Closing this one.


JavaScript UWP development from Visual Studio 2019 not supported

JavaScript UWP development from Visual Studio 2019 not supported. Can't open created visual studio project by cordova. JavaScript UWP development does not support any more by visual studio... pls. reply.

See #327


[Compaction] Integrate with Daft parquet reader to efficiently read subset of columns

This tracks work involved to read parquet files using Daft parquet reader. Currently, we are waiting on three feature requests:

https://github.com/Eventual-Inc/Daft/issues/1217
https://github.com/Eventual-Inc/Daft/issues/1216
https://github.com/Eventual-Inc/Daft/issues/1215
https://github.com/Eventual-Inc/Daft/issues/1218

All issues listed are closed.


Set up everything

This PR sets up svelte, defines the initial landing page + layout, and set up the github action to auto-publish to github pages.
Resolves #7

I don't know how to actually get workflows to run when they aren't on main branch yet so YOLO!!!!!!!!!!!!!!!!


Flood fill

Yeah, it'll be really slow. But people want it.

For anyone who's paying attention, I have a nice implementation of this, but I haven't decided if I want to open source it.

Very late to this, but is this still in the works? I'd potentially be interested in paying for an implementation if it's available.

I put it up at drawplz.com if you want to try it out. I'll email you.

Actually, I can't find your email address, so you email me. :-)

@irskep I would like to use this fill bucket functionality please help me.

I used to sell this on binpress (now shut down) but it's been so long I don't mind making it available for free with no support. https://github.com/irskep/literallycanvas-pro-tools
Here are the files you care about: https://github.com/irskep/literallycanvas-pro-tools/tree/master/src/tools

If someone wanted to open a PR to integrate these tools into the main library I would merge it.

@irskep Thanks a lot.

Hello, may I ask how to put the spray bucket function into the demo version?


Fix having to update service worker cache name on every release

I have:

Started using Vite for ease of use
Installed a plugin for automatically generating a service worker (vite-plugin-pwa)
Updated the app to use methods that are exposed by the vite-plugin-pwa

Oh, I've made a wrong merge commit message


Black screen after "Connect" Galaxy S8

When I press connect it's turn to black screen .
But, when open mirror mode on steam vr it's still tracking where i'm looking.

Please tell me following information.

Version of ALVR client/server
OS version of PC
Graphic card model

And if you can, please upload the output of adb logcat.

I'm using v2.2.1-alpha for server.
and tested both 2.1.5 and 2.1.4 on client side.
Windows 10 with GTX1060 6gb.
how to get adb log?

This usually happens because of packet loss. Check your packet loss on the server during streaming

how to check if something wrong with packet loss?

on the server tab there is packet loss info. also you need client 2.2 for newer servers

2.1.5 and 2.1.4 on client side.

That's too bad! v2.2.1-alpha is only compatible for client v2.2.0-alpha.
And I forgot to show error about it! Sorry.

Install v2.2.0-alpha client by adb or use v2.1.5 server.

oh.... you have the links to 2.2 client? I only seen 2.1.5 client.

here. https://github.com/polygraphene/ALVRClient/releases
But you need osig file and adb to install. You cannot install 2.2.0 on Store.
I recommend to use 2.1.5 server.

That's alright I found it. one more thing what the different between ARCore version and normal?

Thank you. it's working now!


feat: Enable gmail integration to work with Drag-app popup view

:star2: What does this PR do?
Enables support for popup email view that drag-app uses.

@tcrammond Can someone please look at this? It would be very useful addition for us


ReferenceError: BroadcastChannel is not defined thrown when running Jest tests after upgrade to v2.6.0

After upgrading msw from version 2.5.2 to version 2.6.0, when I run my Jest unit tests I get a "ReferenceError: BroadcastChannel is not defined " thrown for each test.

Prerequisites
I confirm my issue is not in the opened issues
I confirm the Frequently Asked Questions didn't contain the answer to my issue
Environment check
I'm using the latest msw version
I'm using Node.js version 18 or higher
Node.js version
20.11.0
Reproduction steps
Change the msw version to 2.6.0 reinstall and yarn start to see the difference.
Current behavior
After running Jest unit tests the following error is raised:
FAIL  src/routes/router.test.tsx
● Test suite failed to run
ReferenceError: BroadcastChannel is not defined

> 1 | import { graphql, http } from 'msw';

Reproduced on msw version 2.6.0
Expected behavior
Jest unit tests to run without error
Package.json
"dependencies": {
"@reduxjs/toolkit": "^2.3.0",
"axios": "^1.7.7",
"buffer": "^6.0.3",
"classnames": "^2.5.1",
"crypto-browserify": "^3.12.1",
"lodash": "^4.17.21",
"moment": "^2.30.1",
"platform": "^1.3.6",
"process": "^0.11.10",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-is": "^18.3.1",
"react-redux": "^9.1.2",
"react-router-bootstrap": "^0.26.3",
"react-router-dom": "^6.27.0",
"stream-browserify": "^3.0.0",
"styled-components": "^6.1.13",
"url": "^0.11.4",
"use-local-storage": "^3.0.0",
"uuid": "^11.0.2",
"vm-browserify": "^1.1.2",
"web-vitals": "^4.2.4"
},
"devDependencies": {
"@babel/core": "^7.26.0",
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@babel/plugin-syntax-flow": "^7.26.0",
"@babel/plugin-transform-react-jsx": "^7.25.9",
"@babel/preset-typescript": "^7.26.0",
"@faker-js/faker": "^9.1.0",
"@mswjs/data": "0.15.0",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.6.2",
"@testing-library/react": "^16.0.1",
"@testing-library/user-event": "^14.5.2",
"@types/jest": "^29.5.14",
"@types/jest-axe": "^3.5.9",
"@types/lodash": "^4.17.13",
"@types/node": "^22.8.4",
"@types/platform": "^1.3.6",
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/react-is": "^18.3.0",
"@types/react-router-bootstrap": "^0.26.6",
"@types/styled-components": "^5.1.34",
"@types/uuid": "^10.0.0",
"@typescript-eslint/eslint-plugin": "^8.12.2",
"@typescript-eslint/parser": "^8.12.2",
"eslint": "^8.57.1",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-jest": "^28.8.3",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-react": "^7.37.2",
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-unused-imports": "^4.1.4",
"faker": "^6.6.6",
"history": "^5.3.0",
"jest": "^29.7.0",
"jest-axe": "^9.0.0",
"jest-environment-jsdom": "^29.7.0",
"jest-fetch-mock": "^3.0.3",
"msw": "^2.6.0",
"prettier": "^3.3.3",
"react-app-rewired": "^2.2.1",
"react-scripts": "^5.0.1",
"ts-jest": "^29.2.5",
"ts-node": "^10.9.2",
"typescript": "5.6.3",
"undici": "^6.20.1"
},

Hi. Thanks for reporting this.
The global BroadcastChannel property exists in Node.js since version 18. I can also confirm it's defined on the version you reported the issue:
Type ".help" for more information.
> BroadcastChannel
[class BroadcastChannel extends EventTarget]

The error you are sharing means that your test environment (likely JSDOM) is removing that global from you. Don't use such test environments, they undermine your entire testing effort.

Hi @kettanaito, thank you for the fast response to the issue, you are correct, my test environment is JSDOM, so I will look at changing it.
Thanks again.

@vonny29 you can use https://github.com/mswjs/jest-fixed-jsdom to workaround the issue.

Thank you @kettanaito for letting me know, I will look into it and make the change.

@vonny29 you can use https://github.com/mswjs/jest-fixed-jsdom to workaround the issue.

the documentation should include that info, thanks @kettanaito
https://mswjs.io/docs/integrations/react-native/


ol.source.VectorTile ignores custom tilegrid for projection

If i pass custom tile grid to ol.source.VectorTile, it is not saved to this.tileGrids_ and therefore it is ignored by ol.source.VectorTile.prototype.getTileGridForProjection.
It is necessary to save it to tileGrids_ in ol.source.VectorTile constructor.
See #7200

The problem is not the tile grid, but the tile grid's extent, which is not respected when source tiles are loaded. I have created #7206 with a fix.


infer fails running clang command

Hi, I'm trying to run infer on an objective-c file (infer -- clang -c AFNetworkReachabilityManager.m) but it gives me an error :
Capturing in make/cc mode...
AFNetworkReachabilityManager.m:195:5: error: cannot create __weak reference in file using manual reference counting
__weak __typeof(self)weakSelf = self;
^
1 error generated.
Error: the following clang command did not run successfully:
'/usr/local/Cellar/infer/0.10.0/lib/infer/facebook-clang-plugins/clang/install/bin/clang'<EMAIL_ADDRESS>Uncaught exception:
(Unix.Exit_or_signal (Exit_non_zero 1))
Raised at file "src/error.ml", line 7, characters 20-30
Called from file "backend/infer.ml", line 455, characters 2-21
But If I run only clang (clang -c AFNetworkReachabilityManager.m) it gives me the report:
AFNetworkReachabilityManager.m:170:1: warning: method possibly missing a
[super dealloc] call [-Wobjc-missing-super-calls]
}
^
AFNetworkReachabilityManager.m:195:5: error: cannot create __weak reference in file
using manual reference counting
__weak __typeof(self)weakSelf = self;
^
1 warning and 1 error generated.

You have to give infer a working compilation command. You get a similar clang error in both cases (with and without infer). You may need to pass more flags to clang to compile your ObjC file.

That particular error may be because you need to add the flag -fobjc-arc. But yes, check that the clang command compiles first, then try it with Infer.

Yes, you're right. Thank you! :) Yesterday, I dove through the flags (clang --help | grep -i objc) for a while and solved the issue.


process is not defined

Hi, when using with my node.js app I'm getting process is not defined. Are you sure you wanted to use the process flags? That is used in server development not for client. For now, I set that variable manually

We do indeed intentionally use process.env.  With React apps is it common place to use process.env.NODE_ENV in the code for environment based feature flipping.
React itself uses this same approach, having its source code littered with process.env.NODE_ENV checks. See their docs for suggested ways to ensure it is set properly.


build iOS playlist view

[x] implement playlist view
[x] limit context menu functions to simple ones
[x] launch/play on youtube app only (implement player later)

done in #421


Q: why selectively quote commands?

Hi Roman, just a quick question I have from reading your zsh code: I see that you sometimes quote commands and their args, i.e. 'builtin' 'source' .... instead of builtin source .... I assume the reason is to avoid alias expansion in case someone defined a builtin alias?
If so, why is that done in some places but not others? Example from this repo:
https://github.com/romkatv/you-the-champ/blob/e5cc7e296d00ffb983779d2a92780bc5fcb2debc/you-the-champ.zsh#L10-L14
In line 10, you use quotes, but not in line 14, which got me curious.
Thanks for all your great work.
P.S: it seems that in zsh you can define a builtin function and then you're unable to use the "original" builtin command, for example the following prints hijacked:
zsh --norcs -c "builtin() { echo 'hijacked' }; 'builtin' source"

I didn't find a way to avoid this behavior and tell zsh to only use the "original" builtin.

Great discussion in here. Thanks @infokiller for raising the interesting questions and @romkatv for the explanations.


initial jekyll skeleton with student collection

Base jekyll skeleton.
The only extra thing i did was add a student collection to _config.yaml and put in an example markdown file of what a student item would look like at _students/colby_dehart.md

resolves #1


File.onDidRename throws error instead of calling callback function

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
File.onDidRename throws error instead of calling callback function
The handle(4) returned by watching <file-path> is the same with an already watched path(<file-oldPath>)

Steps to Reproduce

consider following

const file = new File(atom.project.resolvePath('./some-file'))
file.onDidRename(() => {
    // do something onDidRename
})
file.onDidDelete(() => {
   // do something onDidDelete
})

rename file in Atom and error mentioned above is thrown and callback is never called

rename file in file system mv ./some-file ./_some-file and onDidDelete is called instead onDidRename

using atom.project.onDidChangeFiles has correctly ev.action = renamed

atom.project.onDidChangeFiles(ev => {
  for (const e of ev) {
    if (e.path === file || e.oldPath === file) {
      // e.action = 'renamed'
      break
    }
  }
})

Expected behavior: that onDidRename callback is called
Actual behavior: throws error mentioned above
Reproduces how often: 100%
Versions
atom --version
Atom    : 1.22.1
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

apm  1.18.8
npm  3.10.10
node 6.9.5 x64
python 2.7.14
git 2.14.3

4.14.5-300.fc27.x86_64

We're working on improving our file-system watching and notification systems. You can track progress in https://github.com/atom/atom/pull/16124.

@lee-dohm thanks will take a look


Customize CSS class name

Some projects follow some rules to writing CSS class names, like PascalCase, camelCase, snake_case or kebab-case.
But when using this framework I cannot customize the class name (eg: grid-spaceBetween)
I want to customize the class name and use grid-spaceBetween, grid-space-between, or whatever

This should be completely possible by changing the SCSS variables to whatever you would like and compiling.

@TheKidCoder,
Thank you. I noticed that I can change these vars in gridlex-vars.scss file
$gl-gridName:   grid !default;
$gl-colName:   col !default;
$gl-attributeName: class !default;


Chat history

Not sure if this is already suggested but i searched "history" on the issues page and nothing really showed up.

And by chat history i mean a tab with all your chats

I'm going to implement this one today :)
Features

generate a short title for each chat after the first exchange (maybe update after each one?)

Stage 1 - Without user accounts or DB.
Does not save chats over server restart

save all used session ids in browsers local storage
get chat history from server
set session id

Stage 2 - With object dump

save thing, but server dumps the session / history map on exit and loads it on start

Stage 3 - With database

way more secure than object dumps

Stage 4 - With user accounts

allows sync over different devices

Ooooooo sounds great!


Correctly preserve methods with a null argument

This PR also includes a significant refactoring to unite the code that's used for inferring parameter types from arguments. Previously, we had three copies of it (only one of which has been modified by @LoiNguyenCS's recent PRs) - one for method call expressions, another for object creation expressions, and a third for explicit constructor invocations. Now all these locations call into the same routine (derived from the method call code), so fixes in one location will apply to all three.

Note: I did not intentionally fix cf-691, but apparently the changes in this PR do that, too :)

This PR is great. Is it ready for review?

This PR is great. Is it ready for review?

Yes, definitely! Sorry, I created it as a draft PR by accident.


Require at least one unhidden file to deposit an item

An item should be required to have at least one unhidden file to be deposited. The user should be able to save the item as a draft without an unhidden file.
See this item I was able to deposit with a single, hidden file: https://sul-h2-stage.stanford.edu/works/145

Note: implementing this basically means "no citation only objects via H2".  Amy will verify.

Note: implementing this basically means "no citation only objects via H2".  Amy will verify.

After discussion with Hannah and Andrew, we will support citation only, though when we have the ability to restrict specific functionality to workgroups, we will likely want to restrict this to SUL staff or some such in the future. Closing this ticket.

After discussion with Hannah and Andrew, we will support citation only, though when we have the ability to restrict specific functionality to workgroups, we will likely want to restrict this to SUL staff or some such in the future. Closing this ticket.


Prepare 2.0.0 release

What does this PR do?
Updates versions and changelog ahead of the 2.0 release.
cc @borda

let's wait on #17029, #17039, #17038
and also PR for hpu and ipu


fix: automation model validation errors

Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
"path" -> "folderPath"

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

@raych1  here are the outstanding errors (I only fixed those ones mentioned in the commit message), just FYI, here are the still failing rules:
oav validate-example specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/job.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/job.json:

 error :
operationId: Job_GetOutput
scenario: Get Job Output
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - file
    - string
  message: Expected type file but found type string
  path: ''
  jsonPath: ''

 error :
operationId: Job_GetRunbookContent
scenario: Get Job Runbook Content
source: response
responseCode: '200'
severity: 1
code: INVALID_CONTENT_TYPE
details:
  code: INVALID_CONTENT_TYPE
  message: >-
    Invalid Content-Type (text/powershell).  These are supported:
    application/json
  path: ''
  jsonPath: ''

 error :
operationId: Job_GetRunbookContent
scenario: Get Job Runbook Content
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - file
    - string
  message: Expected type file but found type string
  path: ''
  jsonPath: ''

oav validate-example specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json:

 error :
operationId: SoftwareUpdateConfigurations_Create
scenario: Create software update configuration
source: request
responseCode: ALL
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - object
    - array
  message: Expected type object but found type array
  path: properties/updateConfiguration/targets/azureQueries/0/tagSettings/tags
  title: '#/definitions/TagSettingsProperties/properties/tags'
  description: Dictionary of tags with its list of values.
  jsonPath: '$.properties.updateConfiguration.targets.azureQueries[0].tagSettings.tags'
  position:
    line: 835
    column: 17
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - nonAzureComputerNames
  message: 'Additional properties not allowed: nonAzureComputerNames'
  path: value/0/properties/updateConfiguration/nonAzureComputerNames
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurations.json
  jsonPath: '$.value[0].properties.updateConfiguration.nonAzureComputerNames'
  similarPaths:
    - value/1/properties/updateConfiguration/nonAzureComputerNames
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.nonAzureComputerNames'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - targets
  message: 'Additional properties not allowed: targets'
  path: value/0/properties/updateConfiguration/targets
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurations.json
  jsonPath: '$.value[0].properties.updateConfiguration.targets'
  similarPaths:
    - value/1/properties/updateConfiguration/targets
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.targets'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - linux
  message: 'Additional properties not allowed: linux'
  path: value/0/properties/updateConfiguration/linux
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurations.json
  jsonPath: '$.value[0].properties.updateConfiguration.linux'
  similarPaths:
    - value/1/properties/updateConfiguration/linux
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.linux'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - windows
  message: 'Additional properties not allowed: windows'
  path: value/0/properties/updateConfiguration/windows
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurations.json
  jsonPath: '$.value[0].properties.updateConfiguration.windows'
  similarPaths:
    - value/1/properties/updateConfiguration/windows
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.windows'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - operatingSystem
  message: 'Additional properties not allowed: operatingSystem'
  path: value/0/properties/updateConfiguration/operatingSystem
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurations.json
  jsonPath: '$.value[0].properties.updateConfiguration.operatingSystem'
  similarPaths:
    - value/1/properties/updateConfiguration/operatingSystem
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.operatingSystem'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - tasks
  message: 'Additional properties not allowed: tasks'
  path: value/0/properties/tasks
  title: '#/definitions/softwareUpdateConfigurationCollectionItemProperties'
  description: Software update configuration collection item properties.
  position:
    line: 723
    column: 60
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurations.json
  jsonPath: '$.value[0].properties.tasks'
  similarPaths:
    - value/1/properties/tasks
  similarJsonPaths:
    - '$.value[1].properties.tasks'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations Targeting a specific azure virtual machine
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - nonAzureComputerNames
  message: 'Additional properties not allowed: nonAzureComputerNames'
  path: value/0/properties/updateConfiguration/nonAzureComputerNames
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurationsByVm.json
  jsonPath: '$.value[0].properties.updateConfiguration.nonAzureComputerNames'
  similarPaths:
    - value/1/properties/updateConfiguration/nonAzureComputerNames
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.nonAzureComputerNames'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations Targeting a specific azure virtual machine
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - linux
  message: 'Additional properties not allowed: linux'
  path: value/0/properties/updateConfiguration/linux
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurationsByVm.json
  jsonPath: '$.value[0].properties.updateConfiguration.linux'
  similarPaths:
    - value/1/properties/updateConfiguration/linux
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.linux'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations Targeting a specific azure virtual machine
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - windows
  message: 'Additional properties not allowed: windows'
  path: value/0/properties/updateConfiguration/windows
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurationsByVm.json
  jsonPath: '$.value[0].properties.updateConfiguration.windows'
  similarPaths:
    - value/1/properties/updateConfiguration/windows
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.windows'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations Targeting a specific azure virtual machine
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - operatingSystem
  message: 'Additional properties not allowed: operatingSystem'
  path: value/0/properties/updateConfiguration/operatingSystem
  title: '#/definitions/collectionItemUpdateConfiguration'
  description: >-
    object returned when requesting a collection of software update
    configuration
  position:
    line: 705
    column: 42
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurationsByVm.json
  jsonPath: '$.value[0].properties.updateConfiguration.operatingSystem'
  similarPaths:
    - value/1/properties/updateConfiguration/operatingSystem
  similarJsonPaths:
    - '$.value[1].properties.updateConfiguration.operatingSystem'

 error :
operationId: SoftwareUpdateConfigurations_List
scenario: List software update configurations Targeting a specific azure virtual machine
source: response
responseCode: '200'
severity: 0
code: OBJECT_ADDITIONAL_PROPERTIES
details:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - tasks
  message: 'Additional properties not allowed: tasks'
  path: value/0/properties/tasks
  title: '#/definitions/softwareUpdateConfigurationCollectionItemProperties'
  description: Software update configuration collection item properties.
  position:
    line: 723
    column: 60
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json
  directives: {}
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/listSoftwareUpdateConfigurationsByVm.json
  jsonPath: '$.value[0].properties.tasks'
  similarPaths:
    - value/1/properties/tasks
  similarJsonPaths:
    - '$.value[1].properties.tasks'

This one seems like a bug, because a Delete probably shouldn't be returning anything
oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/connection.json -pValidating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/connection.json:

 error :
operationId: Connection_Delete
scenario: Delete an existing connection
source: response
responseCode: '200'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "200" for operation "Connection_Delete" has no response
    body provided in the example, however the response does have a "schema"
    defined in the swagger spec.
  position:
    line: 40
    column: 17
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/connection.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1connections~1{connectionName}/delete
  directives: {}
  level: error

oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/connectionType.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/connectionType.json:

 error :
operationId: ConnectionType_CreateOrUpdate
scenario: Create or update connection type
source: response
responseCode: '409'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "409" for operation "ConnectionType_CreateOrUpdate" has
    no response body provided in the example, however the response does have a
    "schema" defined in the swagger spec.
  position:
    line: 140
    column: 14
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/connectionType.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1connectionTypes~1{connectionTypeName}/put
  directives: {}
  level: error

oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/dscConfiguration.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/dscConfiguration.json:

 error :
operationId: DscConfiguration_GetContent
scenario: Get DSC Configuration content
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - file
    - string
  message: Expected type file but found type string
  path: ''
  jsonPath: ''

oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/dscNode.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/dscNode.json:

 error :
operationId: DscNode_Delete
scenario: Delete a DSC Node
source: response
responseCode: '200'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "200" for operation "DscNode_Delete" has no response
    body provided in the example, however the response does have a "schema"
    defined in the swagger spec.
  position:
    line: 139
    column: 17
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/dscNode.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1nodes~1{nodeId}/delete
  directives: {}
  level: error

oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/job.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/job.json:

 error :
operationId: Job_GetOutput
scenario: Get Job
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  message: Expected type file but found type object
  path: ''
  jsonPath: ''

Some missing response bodies in the examples
oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/runbook.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/runbook.json:

 error :
operationId: RunbookDraft_GetContent
scenario: Get runbook draft content
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - file
    - string
  message: Expected type file but found type string
  path: ''
  jsonPath: ''

 error :
operationId: RunbookDraft_ReplaceContent
scenario: Create or update runbook draft
source: response
responseCode: '200'
severity: 0
code: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
details:
  code: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
  id: OAV111
  message: >-
    Following response status codes "200" for operation
    "RunbookDraft_ReplaceContent" were present in the swagger spec, however they
    were not present in x-ms-examples. Please provide them.
  position:
    line: 93
    column: 14
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/runbook.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1runbooks~1{runbookName}~1draft~1content/put
  directives: {}
  level: error

 error :
operationId: RunbookDraft_UndoEdit
scenario: Undo draft edit to last known published state
source: response
responseCode: '200'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "200" for operation "RunbookDraft_UndoEdit" has no
    response body provided in the example, however the response does have a
    "schema" defined in the swagger spec.
  position:
    line: 276
    column: 15
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/runbook.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1runbooks~1{runbookName}~1draft~1undoEdit/post
  directives: {}
  level: error

 error :
operationId: Runbook_GetContent
scenario: Get runbook content
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - file
    - string
  message: Expected type file but found type string
  path: ''
  jsonPath: ''

oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/watcher.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/watcher.json:

 error :
operationId: Watcher_CreateOrUpdate
scenario: Create or update watcher
source: request
responseCode: ALL
severity: 0
code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
details:
  code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
  params:
    - creationTime
    - '2016-11-01T04:22:47.7333333-07:00'
  message: >-
    ReadOnly property `"creationTime": "2016-11-01T04:22:47.7333333-07:00"`,
    cannot be sent in the request.
  path: properties/creationTime
  title: '#/definitions/WatcherProperties/properties/creationTime'
  description: Gets or sets the creation time.
  jsonPath: $.properties.creationTime
  position:
    line: 464
    column: 25
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/watcher.json
  directives: {}

 error :
operationId: Watcher_CreateOrUpdate
scenario: Create or update watcher
source: request
responseCode: ALL
severity: 0
code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
details:
  code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
  params:
    - lastModifiedTime
    - '2016-11-01T04:22:47.7333333-07:00'
  message: >-
    ReadOnly property `"lastModifiedTime": "2016-11-01T04:22:47.7333333-07:00"`,
    cannot be sent in the request.
  path: properties/lastModifiedTime
  title: '#/definitions/WatcherProperties/properties/lastModifiedTime'
  description: Gets or sets the last modified time.
  jsonPath: $.properties.lastModifiedTime
  position:
    line: 471
    column: 29
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/watcher.json
  directives: {}

 error :
operationId: Watcher_CreateOrUpdate
scenario: Create or update watcher
source: request
responseCode: ALL
severity: 0
code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
details:
  code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
  params:
    - name
    - MyTestWatcher
  message: 'ReadOnly property `"name": "MyTestWatcher"`, cannot be sent in the request.'
  path: name
  title: '#/definitions/Resource/properties/name'
  description: The name of the resource
  jsonPath: $.name
  position:
    line: 50
    column: 17
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/common/v1/definitions.json
  directives: {}

oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json:

 error :
operationId: DscNode_Delete
scenario: Delete a DSC Node
source: response
responseCode: '200'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "200" for operation "DscNode_Delete" has no response
    body provided in the example, however the response does have a "schema"
    defined in the swagger spec.
  position:
    line: 140
    column: 17
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1nodes~1{nodeId}/delete
  directives: {}
  level: error

oav validate-example specification/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/runbook.json -p
Validating "examples" and "x-ms-examples" in  specification/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/runbook.json:

 error :
operationId: RunbookDraft_GetContent
scenario: Get runbook draft content
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - file
    - string
  message: Expected type file but found type string
  path: ''
  jsonPath: ''

 error :
operationId: RunbookDraft_ReplaceContent
scenario: Create or update runbook draft
source: response
responseCode: '200'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "200" for operation "RunbookDraft_ReplaceContent" has no
    response body provided in the example, however the response does have a
    "schema" defined in the swagger spec.
  position:
    line: 93
    column: 14
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/runbook.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1runbooks~1{runbookName}~1draft~1content/put
  directives: {}
  level: error

 error :
operationId: RunbookDraft_ReplaceContent
scenario: Create or update runbook draft
source: response
responseCode: '202'
severity: 0
code: RESPONSE_SCHEMA_NOT_IN_SPEC
details:
  code: RESPONSE_SCHEMA_NOT_IN_SPEC
  id: OAV113
  message: >-
    Response statusCode "202" for operation "RunbookDraft_ReplaceContent" has
    response body provided in the example, however the response does not have a
    "schema" defined in the swagger spec.
  position:
    line: 93
    column: 14
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/runbook.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1runbooks~1{runbookName}~1draft~1content/put
  directives: {}
  level: error

 error :
operationId: RunbookDraft_UndoEdit
scenario: Undo draft edit to last known published state
source: response
responseCode: '200'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "200" for operation "RunbookDraft_UndoEdit" has no
    response body provided in the example, however the response does have a
    "schema" defined in the swagger spec.
  position:
    line: 276
    column: 15
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/runbook.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1runbooks~1{runbookName}~1draft~1undoEdit/post
  directives: {}
  level: error

 error :
operationId: Runbook_GetContent
scenario: Get runbook content
source: response
responseCode: '200'
severity: 0
code: INVALID_TYPE
details:
  code: INVALID_TYPE
  params:
    - file
    - string
  message: Expected type file but found type string
  path: ''
  jsonPath: ''

 error :
operationId: Runbook_Update
scenario: Update runbook
source: response
responseCode: '200'
severity: 0
code: RESPONSE_BODY_NOT_IN_EXAMPLE
details:
  code: RESPONSE_BODY_NOT_IN_EXAMPLE
  id: OAV130
  message: >-
    Response statusCode "200" for operation "Runbook_Update" has no response
    body provided in the example, however the response does have a "schema"
    defined in the swagger spec.
  position:
    line: 501
    column: 16
  url: >-
    specification/automation/resource-manager/Microsoft.Automation/stable/2018-06-30/runbook.json
  title: >-
    #/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Automation~1automationAccounts~1{automationAccountName}~1runbooks~1{runbookName}/patch
  directives: {}
  level: error

Thanks @nschonni , there're a few invalid_type errors. Do you know how cause this?

I think Swagger 2 or the current x-ms-example stuff doesn't have a good way to represent file responses in an example.

@nschonni , can we use this PR and add more commits to fix other errors?

Sure if you want. The "allow edits from maintainers" checkbox is on

Sorry, what I meant is will you continue to fix other errors along with this PR?

Ah, no I don't think I can fix any of those other ones. EX: removing the response schema from the deletes would probably be a breaking change, and it could be correct. Also adding the response I'd need to know what they'd look like.
Probably better to spin up issues for those so the service owner can take a look

I see, comes back to this PR. What's the reason changing path to folderPath?

The property is "folderPath" in the spec rather than "path" https://github.com/Azure/azure-rest-api-specs/blob/f496662b0ae0e90c01fe63a2ff493581fb72c9c4/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/sourceControl.json#L341-L344
Could be a spec error, and I can undo it if you want


HttpClient usage

Possible issue with OpenAIClient HttpClient
Overview
If OpenAIClient is not used as singleton it might run into issues with HttpClient like socket exhaustion etc.
To Reproduce
Create transient or request scope OpenAIClient with ctor defaults, which then creates and disposes (Http)Client in the same scope.
https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines#pooled-connections
Question
Is OpenAIClient intended to be used as singleton only? Is it threadsafe?
If not, alternatives might be using HttpClientFactory or make internal HttpClient Client { get; private set; } static?
A workaround could be though to implement a factory that creates HttpClient externally and passes it to OpenAIClient factory created instance.

no it is not intended to be used as a singleton, which imho is a code smell practice that inexperienced devs use.
it is designed this was intentionally as OpenAI for Azure forces devs to have to create a new client for each model respectively (frustrating I know)
In either case, unless a provable bug case with proper repro steps can be provided, I am going to close this issue.


⚠ BCR Bot has degraded performance

In d4612a9, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1191 ms

Resolved: BCR Bot performance has improved in 4777be2.


Synthesis failed for Google.Cloud.DocumentAI.V1Beta2

Hello! Autosynth couldn't regenerate Google.Cloud.DocumentAI.V1Beta2. :broken_heart:
Please investigate and fix this issue within 5 business days.  While it remains broken,
this library cannot be updated with changes to the Google.Cloud.DocumentAI.V1Beta2 API, and the library grows
stale.
See https://github.com/googleapis/synthtool/blob/master/autosynth/TroubleShooting.md
for trouble shooting tips.
Here's the output from running synth.py:
2021-03-19 22:43:32,050 autosynth [INFO] > logs will be written to: /tmpfs/src/logs/Google.Cloud.DocumentAI.V1Beta2
2021-03-19 22:43:32,540 autosynth [DEBUG] > Running: git config --global core.excludesfile /home/kbuilder/.autosynth-gitignore
2021-03-19 22:43:32,544 autosynth [DEBUG] > Running: git config user.name yoshi-automation
2021-03-19 22:43:32,548 autosynth [DEBUG] > Running: git config user.email<EMAIL_ADDRESS>2021-03-19 22:43:32,552 autosynth [DEBUG] > Running: git config push.default simple
2021-03-19 22:43:32,555 autosynth [DEBUG] > Running: git branch -f autosynth-Google.Cloud.DocumentAI.V1Beta2
2021-03-19 22:43:32,559 autosynth [DEBUG] > Running: git checkout autosynth-Google.Cloud.DocumentAI.V1Beta2
Switched to branch 'autosynth-Google.Cloud.DocumentAI.V1Beta2'
2021-03-19 22:43:32,762 autosynth [DEBUG] > Running: git rev-parse --show-toplevel
2021-03-19 22:43:32,769 autosynth [DEBUG] > Running: git log -1 --pretty=%H
2021-03-19 22:43:32,773 autosynth [DEBUG] > Running: git remote get-url origin
2021-03-19 22:43:32,808 synthtool [ERROR] > Failed executing git checkout master:

error: Your local changes to the following files would be overwritten by checkout:
	google/cloud/dialogflow/v2/answer_record.proto
	google/cloud/dialogflow/v2/conversation.proto
	google/cloud/dialogflow/v2/conversation_profile.proto
	google/cloud/dialogflow/v2/participant.proto
Please commit your changes or stash them before you switch branches.
Aborting

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 312, in _inner_main
    git_source.enumerate_versions(sources, pathlib.Path(temp_dir))
  File "/tmpfs/src/github/synthtool/autosynth/git_source.py", line 202, in enumerate_versions
    source_versions = enumerate_versions_for_source(git_source, temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/git_source.py", line 166, in enumerate_versions_for_source
    local_repo_dir = str(synthtool_git.clone(remote))
  File "/tmpfs/src/github/synthtool/synthtool/sources/git.py", line 85, in clone
    shell.run(["git", "checkout", "master"], cwd=str(dest), check=True)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'checkout', 'master']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


test different metadata strategies in CI

Any reason why you've removed the test for ownership of _local documents @willholley ?

oops - no. Fixing now...

+1


About section typo?

In README.md it says "provides a decouled gateway" -- I'm assuming this was supposed to say decoupled?

You can issue a PR by clicking the below when browsing the file:

I already have:
https://github.com/hassio-addons/addon-zwave-js-ui/pull/420


net: ieee802154: Remove old cc2520 AUTO_ACK assignments

CONFIG_IEEE802154_CC2520_AUTO_ACK started out as
CONFIG_TI_CC2520_AUTO_ACK, which was removed in commit 6b43821f206b
("net: Remove legacy Contiki based uIP stack"). The assignments were
later renamed in commit 573774a9bf2d ("drivers/net/ieee802154: Change
configuration prefix").
Remove them.
Signed-off-by: Ulf Magnusson<EMAIL_ADDRESS>

Codecov Report

Merging #7920 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7920   +/-   ##
=======================================
  Coverage   55.03%   55.03%
=======================================
  Files         483      483
  Lines       53966    53966
  Branches    10490    10490
=======================================
  Hits        29698    29698
  Misses      19992    19992
  Partials     4276     4276

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f245ef2...df04749. Read the comment docs.


FEAT: Proper calculation of roi_height

We need a nicer function to calculate roi_height.

Basic implementation here: https://github.com/DeMarcoLab/fibsem/pull/24
Could be made more precise if need be.


Add a top-level Makefile so verify scripts can be called easily

For now go-build.sh and verify-golint.sh remain disabled as they are broken at HEAD.
Removed travis config as it's not longer used.
This PR is used to add those checks to Prow (see: https://github.com/kubernetes/test-infra/pull/17516)
/assign @wojtek-t
/assign @mm4tt
/ref https://github.com/kubernetes/perf-tests/issues/552

I've just checked and golint doesn't work at HEAD:
verify/verify-golint.sh
go/build: go list k8s.io/perf-tests/benchmark/cmd: exit status 1
go: finding k8s.io/perf-tests latest
go: finding github.com/golang/glog latest
go: finding github.com/dgryski/go-onlinestats latest
go: finding k8s.io/contrib latest
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0
...

I am leaving it disable for now and I'll dig into that later this week.

/lgtm
/approve


Window widgets are positioned incorrectly in document-based application when showing sheets

When using INAppStoreWindow in a document based application on 10.11 the window theme widgets are positioned incorrectly briefly when showing a sheet. I tracked down the cause of the issue and unfortunately the only place to hook into NSWindow to correct the behavior is in -(void)_updateCollectionBehavior. So the fix I have in place looks like this:
-(void)_updateCollectionBehavior
{
[super _updateCollectionBehavior];
[self _layoutTrafficLightsAndContent];
}
Of course, the problem here is that the method is private and therefore may cause problems with App Store applications.

This issue does bring up a common problem with INAppStoreWindow; that being the wack-a-mole style fixes when Apple decides to add yet another way of adjusting the widget positions. I have thought this could be done cleaner within INAppStoreWindow and an idea I had was to simply observe the frame changes on the close/zoom/minimize buttons using the NSViewFrameDidChangeNotification. From within the notification handler, you'd then unregister / move the buttons / re-register for notifications. This would require a bit of work to refactor the existing implementation, but I feel like it might less error prone as AppKit moves forward.

@wadeco That's a good idea. I'll keep this open to track progress in making that fix. I can look into it when I have some time, or I'm also happy to review a PR that implements it.


Swapped out Vegeta img for more accurate GIF

Saturday morning PR here. I feel like this GIF more accurately depicts what the Vegeta library is all about!

Ahah, thanks but no thanks :-) Too distracting.


AttributeError: 'tuple' object has no attribute 'groupby

When I create a DataFrame:
df = dataframe.from_pandas(
    pd.DataFrame({"x": range(10), "y": ["a"] * 5 + ["b"] * 5, "z": 1}), 5)

And try to set index: with the same number of partitions
df.set_index("x", divisions=[0, 2, 4, 6, 8, 10], sorted=True).groupby("y").count().compute()

it works as expected. But if number of partitions differs:
df.set_index("x", divisions=[0, 2, 5, 8, 10, 12, 14], sorted=True).groupby("y").count().compute()

I get confusing exception shown below:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-205-e8ff0304bc2c> in <module>()
----> 1 df.set_index("x", divisions=[0, 2, 5, 8, 10, 12, 14], sorted=True).groupby("y").count().compute()

/path/to/python3.6/site-packages/dask/base.py in compute(self, **kwargs)
     92             Extra keywords to forward to the scheduler ``get`` function.
     93         """
---> 94         (result,) = compute(self, traverse=False, **kwargs)
     95         return result
     96

/path/to/python3.6/site-packages/dask/base.py in compute(*args, **kwargs)
    199     dsk = collections_to_dsk(variables, optimize_graph, **kwargs)
    200     keys = [var._keys() for var in variables]
--> 201     results = get(dsk, keys, **kwargs)
    202
    203     results_iter = iter(results)

/path/to/python3.6/site-packages/dask/threaded.py in get(dsk, result, cache, num_workers, **kwargs)
     74     results = get_async(pool.apply_async, len(pool._pool), dsk, result,
     75                         cache=cache, get_id=_thread_get_id,
---> 76                         **kwargs)
     77
     78     # Cleanup pools associated to dead threads

/path/to/python3.6/site-packages/dask/async.py in get_async(apply_async, num_workers, dsk, result, cache, get_id, raise_on_exception, rerun_exceptions_locally, callbacks, dumps, loads, **kwargs)
    498                     _execute_task(task, data)  # Re-execute locally
    499                 else:
--> 500                     raise(remote_exception(res, tb))
    501             state['cache'][key] = res
    502             finish_task(dsk, key, state, results, keyorder.get)

AttributeError: 'tuple' object has no attribute 'groupby'

Traceback
---------
  File "/path/to/python3.6/site-packages/dask/async.py", line 266, in execute_task
    result = _execute_task(task, data)
  File "/path/to/python3.6/site-packages/dask/async.py", line 247, in _execute_task
    return func(*args2)
  File "/path/to/python3.6/site-packages/dask/compatibility.py", line 47, in apply
    return func(*args, **kwargs)
  File "/path/to/python3.6/site-packages/dask/dataframe/groupby.py", line 175, in _apply_chunk
    g = _groupby_raise_unaligned(df, by=index)
  File "/path/to/python3.6/site-packages/dask/dataframe/groupby.py", line 133, in _groupby_raise_unaligned
    return df.groupby(**kwargs)

Versions

Python                     3.6.0
pandas                    0.19.2
dask                        0.14.0

Replicated.  Thanks for the excellent bug report @LostInOverflow .
I'm actually looking at shuffling / groupbys / set_index now, so this is good timing.

Digging into this now.  It looks like this is only an issue in the sorted=True case.  In this case it looks like we are defining the divisions= keyword somewhat differently, which is causing some confusion.
When using sorted=True we state that we know that the data is already sorted by the new index.  In these cases we can also state the known values of those divisions along the index using the divisions= keyword.  This is an entirely different meaning from how we usually use the divisions= keyword (which is usually "this is what I want my divisions to look like").  This double meaning of the same keyword is obviously an issue.
Short term @LostInOverflow you probably want this:
df.set_index('x', sorted=True).repartition(divisions=...)

Thank you so much @mrocklin!


Implemented hierarchical view (under a flag) for find references.

I implemented https://github.com/microsoft/vscode/issues/81187 myself.
To make it less confusing I put it under a flag: "references.treeView", which is false by default.
See the screenshot with how it looks like in the attachment.

@mjbvz May I ask you to take a look at it? @jrieken who seems to be an owner of this project is on a vacation now.

I wanted to create unit tests, but found out that webpack is used. Also, we don't want to ship them, with the extension. So, I decided not to work on them.

@solomatov Thanks for the PR! I'd prefer to wait until @jrieken is back though so that he can review the changes and provide feedback

@mjbvz Ok. Let's wait then.
Also, may be you can help me with unit tests? Is there an example of idiomatic unit test setup for vs-code plugins? I know, you use mocha, but is there any canonical example to take a look at?

I added test for model, since the behavior became quite complicated.

Hm, this is very similar but also different to what the SCM viewlet is now offering (see attached screen recording below). Tho, SCM does support "compression", e.g folders with single entries are rendered as single row (see "foo/bar/bazz" and "js/lib").

The SCM viewlet has access to more powerful API/utils that can be reused when rendering resources (see ResourceTree)
I think the better approach would be somehow reuse that resource tree logic in the tree view API so that we have to maintain less code and so that tree showing resources look and feel alike.
/cc @joaomoreno @alexr00

@jrieken That would be a perfect solution to the problem which my PR solves. Do you have plans to expose this API to extensions?

No plan at the moment, but I've created an issue and added it to the backlog: https://github.com/microsoft/vscode/issues/81757

@alexr00 If you need help with this, I can help doing this. I just know that the team is really concerned about API surface area, and having a special tree for resources might make it wider. Do you think it's possible to do it in the same way as normal tree is exposed to extensions?

Closing it, since the probability of merging it is very low.

@solomatov I'll need to take a look at how it's done for SCM and see how we can generalize this.


[Llama] Online rotary embedding

This PR supports Llama2 with the online rotary embedding computation and removes the dependency on the cached cos/sin values, so that no matter how much the max-seq-len of the newly built libraries is, the prebuilt weights can be used without issues (hopefully).
Tested q4f16_1 on RTX 4090 and observed no performance regression.

cc @CharlieFRuan, please validate this PR for various max_sequence_length settings, thanks!

Verified that this PR solves the max_sequence_length issue mentioned in PR https://github.com/mlc-ai/mlc-llm/pull/891.
Tested to use Llama 2's compiled model library to run WizardMath's weights:

Llama 2 compiled with max_position_embeddings=4096; WizardMath with max_position_embeddings=2048
Llama 2 w/ 2048, WizardMath w/ 2048
Llama 2 w/ 2048, WizardMath w/ 4096


Error while building ScrollView.

Environment

Tesseract Version: Version 4.0
Commit Number:
Platform: Ubuntu 16.04.
After running
make ScrollView.jar
I get the following error
./com/google/scrollview/ui/SVImageHandler.java:19: error: package javax.xml.bind is not visible import javax.xml.bind.DatatypeConverter;               ^ (package javax.xml.bind is declared in module java.xml.bind, which is not in the module graph)
It seems that in Java 9 this module has been deprecated which is most probably causing this error. I have looked online but can't find a way around this. I am not a Java expert so I don't know what's the possible solution to this.

But this is definitely something that should be looked into and other deprecated packages as well.

I encountered  the same problem in Mac OS High Sierra 10.13

It seems that using JDK 8 can solve this problem. @MehulBhardwaj91

Facing same in java 10

@toxic-0518 : Since this was optional, I went ahead with the training without it. Didn't try it with JDK 8.
@shanalikhan : I would recommend going ahead with training without it.

Can somebody familiar with java make it work on various Java  version (8-10)?

I think that scrollview should be disabled by default.

well it is build just on user request e.g. user want it. But build seems to work only on old java. So we need to modernize it as we did with cpp code.

it is build just on user request e.g. user want it.

./configure --help

...
--enable-graphics       enable graphics (ScrollView) (default)
--disable-graphics      disable graphics (ScrollView)
--enable-embedded       enable embedded build (default=no)
--disable-openmp        do not use OpenMP
--enable-opencl         enable opencl build (default=no)
--enable-visibility     enable experimental build with fvisibility
(default=no)
--enable-multiple-libraries
enable multiple libraries (default=no)
--disable-tessdata-prefix
don't set TESSDATA-PREFIX during compile
--enable-debug          turn on debugging (default=no)

of course, changing the default will not solve the problem, but I still thing we should change it, because scrollview is not necessary for most users.

[Zdenko, please read my above comment]
https://www.google.com/search?client=firefox-b&ei=1OGvW4O_NsWXkwXysYOgDA&q=package+javax.xml.bind+is+not+visible+import+javax.xml.bind.DatatypeConverter
https://www.logicbig.com/tutorials/core-java-tutorial/modules/root-modules.html
https://github.com/contiki-os/contiki/issues/2214https://stackoverflow.com/questions/43574426/how-to-resolve-java-lang-noclassdeffounderror-javax-xml-bind-jaxbexception-in-j

Okay :-)

Attached is the fix, which is to download the required jaxb-api-2.3.1.jar. The files should be placed into java folder, replacing the existing ones.
java.zip

Thanks nguyenq!

I tested it with java-1_8_0-openjdk and it worked for me.

Please update the wiki.
https://github.com/tesseract-ocr/tesseract/wiki/ViewerDebugging

done


Is it possible to teleoperate with the remote instead of hand tracking?

Hi,
We are teleoperating a Franka Panda robot with just a gripper. We have found that the gripper actuation (clicking the thumb and pinky together) is unreliable and causes the hand position to shift in the process. This makes grasping objects very difficult.
It it possible to teleoperate with the Meta Quest remote and use a button for actuating the gripper? This would give us better position tracking and easier gripper actuation.
If not, could you recommend any other codebase/stack that does this?
Thanks,
Jeremiah

If you want to use remote, it should work. The key of this task is to find the position and rotation information of the remote, for which you need to refer to the documentation.
However, it is possible to control the gripper actuation with thumb and Index finger without exerting a strong influence on the position of the hands.
If you can provide the tasks you want to accomplish and the situations you cannot tolerate, it will be easier for me to help you.

I see. In order to implement this change, we would have to change the Unity code and the .apk file right?

"However, it is possible to control the gripper actuation with thumb and Index finger without exerting a strong influence on the position of the hands."

Unfortunately, we found this to be false. Everytime we try to actuate the the gripper with our fingers, the hand position shifts. We tried the thumb and index finger, but the fingers are too close and we get false positives on them touching.

Hi, would you be able to provide some guidelines on how to edit the Unity package and compile it into a new .apk file?


perf: Avoid string copying during JSON parsing

This submission implements a performance optimization for JSON parsing by avoiding the copying of strings into byte arrays.

Could you please also paste your benchmark result for the hack package.

Could you please also paste your benchmark result for the hack package.

Could you please also paste your benchmark result for the hack package.

Amazing improvement! Are there any risks? Additionally, is it better to rename the package 'hack'? How do you like to move it to cast package, which already have functions of type conversions.

@ngjaying
Since Go strings are immutable, the byte arrays must be immutable.
func main() {
	str := "abc"
	a := string2bytes(str)
	fmt.Println("len:", len(a))
	fmt.Println("cap:", cap(a))
	fmt.Println(a)
	a[0] = 'd'
	fmt.Println(a)
	fmt.Println(str)
}

func string2bytes(str string) []byte {
	return unsafe.Slice(unsafe.StringData(str), len(str))
}
// output:
// len: 3
// cap: 3
// [97 98 99]

// segment fault at a[0] = 'd'

it can be used if the byte array is read-only

@ngjaying
Because len=cap, the append operation will expand the byte array, so the append operation is safe.
func main() {
	str := "abc"
	a := string2bytes(str)
	fmt.Println("len:", len(a))
	fmt.Println("cap:", cap(a))
	fmt.Println(a)
	fmt.Printf("address of bytes before append : %x\n", (*reflect.SliceHeader)(unsafe.Pointer(&a)).Data)
	a = append(a, 'e')
	fmt.Printf("address of bytes after  append : %x\n", (*reflect.SliceHeader)(unsafe.Pointer(&a)).Data)
	a[0] = 'd'
	fmt.Printf("address of bytes after  change : %x\n", (*reflect.SliceHeader)(unsafe.Pointer(&a)).Data)
	fmt.Println(len(a))
	fmt.Println(cap(a))
	fmt.Println(a)
	fmt.Println(str)
}

func string2bytes(str string) []byte {
	return unsafe.Slice(unsafe.StringData(str), len(str))
}

//output
//len: 3
//cap: 3
//[97 98 99]
//address of bytes before append : ca7ea5
//address of bytes after  append : c00001c0f8
//address of bytes after  change : c00001c0f8
//4
//8
//[100 98 99 101]
//abc

Thank you!


Release Google.Cloud.DocumentAI.V1 version 3.15.0

Changes in this release:
New features

A new message FoundationModelTuningOptions is added (commit 409c062)
A new field foundation_model_tuning_options is added to message .google.cloud.documentai.v1.TrainProcessorVersionRequest (commit 409c062)

Documentation improvements

Updated comments (commit 409c062)

Created release for Google.Cloud.DocumentAI.V1-3.15.0


Added the link to another JSX alternative

Added sowing-machine link.

This library doesn't seem particularly maintained or popular, so I have to push back and reject this. Thank you for your PR!


[Github] Interactive bug template (yml) for docs-issue

📝 Provide a description of the new feature
We should add an interactive template (yml) for docs issues and ask the following informations:

Where do you missing something or find an incorrect information?
What do you find?
What would you expect? / What is missing?

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@htcfreek, we're crawling into the bug template.  I know we still need to port the rest.  Just like Terminal, we're testing the waters on them.  Not doing all of them at once was very intentional

Added Status-Blocked label until we are fine with doing this.

Make sure to add the "OOBE / Welcome to Powertoys" area. Right now, I want to issue a bug for it, but it's not in the list.

@Jay-o-Way
This is not the correct issue for your comment. - Please remove it.
And we already work on a pr that adds this.

This isn't blocked, i just want to see how people are reacting to the new templates.  The meaning of that tag is pretty important and I don't think this meets that.
If we wanted to, we could do this work right now.

https://github.com/microsoft/PowerToys/issues/new?assignees=&labels=Issue-Docs%2CTriage-Needed&template=documentation-issue.yml


Add functions and types for building and rendering closure trees

These functions and data types have been very useful when needing to visualize and debug the GHC heap object representation of Haskell expressions. For e.g., it's been useful for finding thunks in instances of cardano-ledger data types which we keep in-memory such as ChainValidationState.

LGTM! Not sure we need the IOHK module headers, though, the comments are probably enough and the rest of the info is in the cabal file!

Thanks, I've removed them.


Know Bugs/Small Features

List of small tasks to be done before release:

[x] Bug which sometimes screws up network upon "Graph Subnet"
[x] Upper threshold for max visible neighbors option
[x] Check table buttons for null input and handle appropriately
[x] Change from 'isPoly' to check whether it is term data or custom data
[x] Update behavior with options update button on  wrong graph
[x] Revamp system to find local degree on graph
[x] Toggle for graph style on any data
[x] Instead of pulling all edges upon new addition, just get new ones and add them
[x] Make sure anything doesn't fail without annotations, aliases, and/or and ontology terms in cob object
[x] GWS Enrichment
[x] GO Enrichment
[x] Check Browser compatibility (Firefox, chrome, and edge?)
[x] SNP Parent Attributes should work
[x] Find another species for cob to check species independence (make sure cob can be run easily)
[ ] Tooltips on table buttons for help
[ ] Breadcrumbs on table tabs when empty
[ ] Figure out way to elegantly explain gene word search

Done or moved to separate issue


Remove deprecated methods/parameters from algorithms and opflow

Summary
Algorithms and Opflow are new in Terra so remove any deprecated method or method parameters.
Fixes #5776
Details and comments

Do we need to change Grover here - #5680 has refactored Grover the deprecated code does not exist there I believe - just wondering since merging this with this update may create a bunch of conflicts that need resolving that we could avoid.

Changes to Grover were reverted as they are being done in PR #5680


add hooks

Pull Request Overview
This pull request adds a mechanism for downstream developer specifiable hooks, that hopefully is zero cost when unused.
Testing Strategy
This pull request was tested by a custom benchmark to assess performance impact.
TODO or Help Wanted
This pull request still needs more benchmarks, and feedback on the proposed API.
Formatting

[x] Ran cargo fmt
[x] Ran cargo check
[x] Ran cargo build

Github Issue
This pull request closes #11
Author
Signed-off-by: wucke13<EMAIL_ADDRESS>

The API proposed looks good. It might be just accidental, but you also pushed the requirements onto this branch.


Node.child should be named Node.first_child ?

I think Node.child should be named Node.first_child, as the access to the last child is named Node.last_child.
BTW, I am surprised that there is no children property.

We have .iter(). Does it do what you would expect?

I agree about Node.child to be renamed in Node.first_child because I haven't seen any Node.childs or Node.children so I was expecting Node.child to do that. But it doesn't, it's only the first child and sometime the first child even doesn't work.
I was not expecting Node.iter() to act like what would be a Node.children. I was expecting Node.iter() to "Iterate over nodes on the current level" (what is written in the documentation) meaning I was expecting it to iterate over the rest of nodes that are on the same level than the node I am on, not children of the node.
Because of that I have tried to do Node.child.iter() to iterate over children and it was my last best guess until I found this report.
I think that :

the current behavior of Node.iter() should become a Node.children() (and say in the documentation that it "iterate over children of the current node", not saying Iterate "on the current level").
Node.child should be renamed Node.first_child and say that it "Return the first child node" instead of "Return the child node"
and bugs with using the two dedicated function instead of .iter() needs to be fixed : getting the first child and last child seems buggy when using those function when those child are in a separated line in the html than the start or end of the current node (see issue 114).


Add Silent login of user

Implemented possibility to Sign in already existing user without UI interactions

@Pujolsluis

Hey @RomaRudyak ,
The v1.0.15-beta is now available in Nuget gallery, test it out and give us your feedback 💪


make test is broken

I did a make clean which broke make test.
The problem appears to be related to pylenium webdriver manager. It cannot find the default chrome driver. I thought that was handled automatically these days.
Chrome version
% /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version
Google Chrome 104.0.5112.79

This originally failed because i had an older version of chrome, after updating it worked.
from selenium import webdriver
>>> from selenium.webdriver.chrome.service import Service as ChromiumService
>>> from webdriver_manager.chrome import ChromeDriverManager
>>> from webdriver_manager.core.utils import ChromeType
>>> driver = webdriver.Chrome(service=ChromiumService(ChromeDriverManager(chrome_type=ChromeType.CHROMIUM).install()))

Fixed.
The root cause was a change to webdriver_manager in 3.7.1 which broke pylenium.
The fix was to downgrade the webdriver_manager version to 3.7.0.


[Backport 2.x] [Refactor] Requests to use MediaType instead of XContentType (#6218)

Backport 1f4cdd2f75ca5e98bd81f3226566d263ec00455c from #6218.

Codecov Report

Merging #6433 (ad09bbe) into 2.x (47a3aba) will decrease coverage by 0.04%.
The diff coverage is 50.94%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #6433      +/-   ##
============================================
- Coverage     70.40%   70.37%   -0.04%
- Complexity    59222    59253      +31
============================================
  Files          4798     4798
  Lines        284215   284302      +87
  Branches      41317    41321       +4
============================================
- Hits         200100   200068      -32
- Misses        67417    67446      +29
- Partials      16698    16788      +90

Impacted Files
Coverage Δ

.../java/org/opensearch/common/xcontent/XContent.java
100.00% <ø> (ø)

...rg/opensearch/common/xcontent/XContentFactory.java
64.15% <ø> (ø)

.../opensearch/common/xcontent/XContentGenerator.java
73.33% <ø> (+6.66%)
:arrow_up:

...a/org/opensearch/common/xcontent/XContentType.java
100.00% <ø> (ø)

.../opensearch/common/xcontent/cbor/CborXContent.java
80.00% <ø> (ø)

.../opensearch/common/xcontent/json/JsonXContent.java
100.00% <ø> (ø)

...pensearch/common/xcontent/smile/SmileXContent.java
87.50% <ø> (ø)

.../opensearch/common/xcontent/yaml/YamlXContent.java
84.61% <ø> (ø)

...ction/admin/indices/create/CreateIndexRequest.java
64.51% <0.00%> (-8.92%)
:arrow_down:

...g/opensearch/action/ingest/PutPipelineRequest.java
67.74% <0.00%> (-19.76%)
:arrow_down:

... and 507 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.