Question: Reason of a specific line calling the irq handler manually

https://github.com/jostlowe/Pico-DMX/blob/10d37a4fd0fbdc0a47721df9fc639654024404e9/src/DmxInput.cpp#L157 calls dmxinput_dma_handler(); directly and I don't really understand why.
I mean, of course, the write address of the DMA channel has not been set and this happens in the IRQ handler. But I don't understand why/how this works. At this line, the state machine is not yet running, it's only enabled in the line below. So, this DMA channel will NOT trigger any interrupts. That means that inside the IRQ handler, the DMA channel's bit in the INTS-register will not be set. So, when the IRQ handler is called in line 157, it will loop through all DMA channels (https://github.com/jostlowe/Pico-DMX/blob/10d37a4fd0fbdc0a47721df9fc639654024404e9/src/DmxInput.cpp#L104) and handle only those with their INTS-bits set (https://github.com/jostlowe/Pico-DMX/blob/10d37a4fd0fbdc0a47721df9fc639654024404e9/src/DmxInput.cpp#L105). So, in my eyes, calling the IRQ handler manually doesn't make sense.
In one of my branches of my fork, I've replaced the call by those four lines:
https://github.com/kripton/Pico-DMX/commit/a5ec3a373fbf2714c5ac3ed0a23cf37e32b22aad#diff-42a9a8ae12afd6562fa620becac01e3c263d29fd4cbcd832a35abbca6cd76fa6R184
and it seems to work now.
Any explanation on why it works in the examples?
By the way, great library, thanks for making it! I'm currently coding a USB->DMX interface that outputs 16 universes and does Wireless DMX in addition (using optional nRF24 modules) (and has an integrated web server and speaks ArtNet and sACN): https://github.com/kripton/rp2040-dongle/tree/rewrite. I planned to do DMX input as well (so it could also do RDM if direction switching (DMX output to DMX input) doesn't take too long). However, I didn't have any real solution to do DMX inputs using the PIOs. I'm really happy I found your library and DMX input was working today for the very first time! :smiley:
By the way, schematics for the modular interface is at https://github.com/kripton/rp2040-dongle/tree/kripton-hardware/hardware (Kicad) and some renderings are here: https://github.com/OpenLightingProject/rp2040-dongle/discussions/1#discussioncomment-519937

Hi, @kripton and thanks for the nice feedback! It's nice to see that the library is used for something useful :) The dongle you're making looks really interesting. I've been meaning to make something similiar, but haven gotten around to ordering the PCBs. I'll definetly dig through your code looking for inspiration :)
@BollaBerg was previously looking at adding RDM support to the library if that might be of interest to you

@functionpointer, it seems these lines came from one of your pull requests :) Maybe you can clarify why the handler is explicitly called here?

I think it was to set the write address. You are right about the interrupt bit not being set tough. Now I wonder if we lose all data before the first DMA interrupt

Is it a quick fix, or would it require a larger rewrite to fix this? Do you have a chance to take a look at it?

Quick fix. Also in real use cases you won't even notice one missing frame right after boot.

Current state of the code sounds like a deadlock to me: The interrupt handler is called manually but doesn't do anything since the INTS bit is not set. And the DMA channel's write address is only set in the IRQ handler, so it probably won't be set anywhere. I wouldn't know why the DMA's IRQ would fire if no write address has been set. So I wonder why the code in the current state works at all.
Missing a single (the first) frame is not a problem in most "normal" situations where all DMX frames have the start code 0. When talking about RDM, things look different. If you lose the one frame (device replies to controller) you (as the controller) asked for before, this is a problem.
Quick fix proposal is here: https://github.com/jostlowe/Pico-DMX/compare/main...kripton:kripton-multipleFixes
Basically do parts of what is done in the IRQ handler in the async_read function: Reset the state machine, clear its FIFOs, set the DMA's write address and trigger it.
It could be that we could do with less code in read_async (since there is the call to dma_channel_configure and the one to dma_channel_set_write_addr that might be combined). However, this code makes the DMX input work for me :)

Yeah not sure...i kind of suspect it writes it somewhere random and we are lucky it doesnt destroy everything.
Looks like a good fix to me. The real pro gamer move would be to test it with two rpi picos. Get one to output exactly one DMX frame and see if the other one captures it.

The real pro gamer move would be to test it with two rpi picos. Get one to output exactly one DMX frame and see if the other one captures it.

Good idea, I'll do that in the upcoming days. I also have an Arduino-based "RDM responder" that might work quite well for such a test.

Test done, looking quite promising:

Explanation:
D3 of logic analyzer screenshot is DMX data generated by the "device under test" (the one running the DmxInput-code of this library) just to see that its alive.
D0 is the DMX data that is being fed into to the device under test by another Pico board.
D1 is not used, D2 is the most interesting one: I've modified the DmxInput IRQ handler to pull a GPIO high when entering the IRQ handler and pulling it low when exiting the IRQ handler. As you can see, it triggers reliably in every DMX packet incoming. The position where it triggers also looks good, I've asked read_async to capture only the first 10 channels.
The code of Pico-DMX is https://github.com/kripton/Pico-DMX/commit/57165002135d15162f6e765e50cef0eab6517ae4 plus the minimal changes to have the GPIO high while in the IRQ handler.
Side story: At first, I asked read_async to read 512 channels. Effect was that the GPIO was pulled HIGH only at the beginning of every DMX frame received. Will be investigated but that story's on another page ;)

Edit: Hm, this is the picture I actually wanted:

Fantastic! Now i am curious, how bad is the current master really?


Universal group not working with DLNA/uPNP player provider on WiiM Pro Plus devices, or Marantz devices

What version of Music Assistant has the issue?
2.0.7
What version of the Home Assistant Integration have you got installed?
2024.6.2
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
No sound plays on a group of WiiM Pro plus using DLNA, even though they play individually
How to reproduce

add the DLNA/uPNP provider
add the Universal group player
create a group player of 2 devices. I chose "downstairs bedroom" and "downstairs bath"
select the group player
select an album
click play
not a peep

If you select an individual DLNA player, and repeat steps 5-6, it plays fine. This includes the 2 DLNA devices that are part of the group.
Music Providers
Qobuz
FS
Plex
(I played a triplacate album)
Player Providers
DLNA
Universal Group Player
Full log output
log.txt
Additional information
No response
What version of Home Assistant Core are your running
2024.6.2
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Windows

Wiim Pro Plus support Airplay. Use that to group the players. As per the docs "UGP is on best-effort basis and might not work correctly with all player models or give unexpected results. For best results use standalone or syncgroup playback"

OzGav,
The existence of a workaround for one brand devices doesn't negate the existence of an issue, even if the component is best effort.. Especially if it is also the case with other devices.
I also linked two Marantz receivers with DLNA and UGP, and got no sound either. A workaround exists in that case as well, since these Marantz support Airplay - but not Chromecast.
However, some players truly will only support DLNA/UPNP for input, and not Chromecast or Airplay. This the case for JRiver Media Center, and I believe also for Kodi. I have instances of those, also.
In the case of JRiver as a DLNA player, something is broken between MA and JRiver, even with a single JRiver player. That's also on my list to file an issue - has been for a few days.
I just haven't tried to use Kodi as a DLNA player, and I currently only ave one instance of it - Libreelec on a Pi3B, used mainly to play 3D movies, and not typically audio, but it can.
Grouping with can involve a mix of devices. Since USG only supports grouping devices of the same family, the intersection of the devices may be limited, or even an empty set. But there are cases where it is useful to group a mix of WiiM, Marantz, Kodi and JRiver; and if any of the last two are grouped, the only common protocol is DLNA .
I believe DLNA with USG may be generally broken, but it would take a dev to look at the logs - I can provide some with more device types.

Marcel was talking about removing the Universal Group all together because of these types of issues. The sentence I quoted was the current compromise. As some people are using it successfully the functionality has been retained. However, there is no capacity to put any effort into this when you can use other solutions which do work.
DLNA is a hot mess of a protocol because it is poorly implemented from a standardisation point of view and thus there are often issues (although that has died down of late so Marcel must have patched the majority of problems)
Kodi supports Airplay which is what I use.

Ozgav,
Thanks for the background. I would like to see which DLNA / UGP issues have been fixed. Any info on which DLNA devices have been successfully grouped with UGP would be helpful. And perhaps a list of them in the doc for UGP and or DLNA player providers.
Re: Kodi, I didn't know that it t had support for Airplay. it looks like there are some significant limitations with it as an Airplay sink, but those may not apply to the MA case. https://kodi.wiki/view/AirPlay
Since Chromecast devices have native group support, they don't need UGP.
Airplay devices have native grouping in MA, so they don't need UGP either.
DLNA.UPNP doesn't have native grouping, so this would seem like the most useful case for UGP.
It's unfortunate that the protocol has this type of issues.
FYI, WiiM managed to implement grouping of their own devices over DLNA . It's setup using their smartphone app. It works with JRiver MC which only supports DLNA. The main drawbacks are that you can't name the group - it takes the name of the first device, and the other ones (individual) disappear as targets. And also, it only works for WiiM's own devices - you can't add a Marantz, JRiver MC or Kodi to the WiiM groups. exposed as DLNA. I wish UGP worked better with DLNA since there is no to limited native DLNA grouping.
Is the UGP useful for the other player providers ? I have only tried Airplay, Chromecast and DLNA/UPNP. Sonos probably has native grouping. Perhaps I should try the HA MediaPlayers provider next and see if UGP works.

Wiim devices are based on Linkplay chips and they use DLNA under the hood but with their own extensions. Exactly what Sonos does (which is also dlan under the hood). I think we should put some effort in adding support for Linkplay devices because that means that folks can use native grouping for all devices with Linkplay chips (which are actually more than you think). There is a task for that on the backlog but as with all stuff.. I only have 24 hours in a day :-)
But that said; We should still make sure that UGP either works in some way (or limit it to players that can work with it) OR scratch it. I will do another round of investigating but from what I remember is that UGP + DLNA is a hot mess.
I kind of kept the provider in the codebase because some folks do have it working for their needs and I hoped someone would step in and help contribute the fixes. Guess I need to keep dreaming ;-)
I have spotted a few more error reports about DLNA.
What would maybe be helpful is that we can tag/label these provider related issues so I can quickly skim through the issue reports and combine them all at once.

Please advise if there is any improvement with beta 30.

I will do so once I am home and able to verify. I have been traveling.

I just confirmed that a DLNA player within a Universal group works. (2.3.0 beta 34)

@madbrain76 please confirm this has been fixed

This will be closed soon unless there is still an issue

Sorry for the delay. Yes, this is fixed. While trying to verify the fix, I ran into another issue. If the only 2 player providers enabled are DLNA and Playergroup, the "Add group player" button does not show up. I'm not sure if this is new or not.

Yes new. It is probably intentional but the fact that universal is in there has been overlooked.


OSLogWriter not compiling on macOS

There is an unnecessary preprocessor condition surrounding the OSLogWriter declaration that prevents it from being compiled on macOS.
Is there any meaning behind this? I'd like to know why this has been done this way (cc @cnoon)
PR is #19

Thanks for pointing this out @Infinisil and my apologies for not getting back to you sooner. The reason it was compiled out was that it didn't work in Xcode 8.0. The os_log functionality wasn't fully implemented on macOS in Swift.
I'm going to close this issue out. Please redirect all future comments to #19.


[BUG] Each child in a list should have a unique "key" prop.

Description
This issue is showed when the application is started for development.
Screenshots

Any additional information?
This issue could be fixed by adding an additional prop: key to the element.
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

@Jay-Karia where should we add the key prop?

@Jay-Karia .

@rupali-codes, this error occurred due to missing key under ul elem, so there should be an li elem without key prop.
Still figuring this out, will let you know soon.

https://github.com/rupali-codes/LinksHub/blob/ffb79acfddbf62317c8d398637abda99cf84f00c/pages/index.tsx#L336-L337
I think the issue is caused to due to this code.
We can swap Line 337 and Line 336

I think I got it.
We just had to remove React Fragment: <></> from renderLinks() in the Headers page.


New Error Handler with backtrace and symbol support

This PR aims to install a new error handler from the MD Debugger project to SGDK. The old error handler is still preserved for compatibility and is available by setting LEGACY_ERROR_HANDLER to 1 in config.h.
It also enhances symbol.txt files by adding source-line information (file path and line number for every symbol, where applicable).
Overview

Displays debug symbols from the source code with "debug" build profile, displays raw offsets only with "release" profile.
Symbols are attached to the end of ROM in custom compressed format by the new bin\convsym.exe utility.
More readable exception screens with formatting and a few built-in debuggers:

Press B to display backtrace;
Press A to display address register info (decoding address register values as symbols, if applicable);
Press C or Start to return to the main exception screen.

New error handler with "debug" profile

Backtrace in action
SGDK API changes

Freed about 88 bytes in RAM by removing busErrorCB, addressErrorCB and other error callbacks as well as registerState and other global variables used by the old error handler;
Removed all legacy error handler functions from sys.c (unless LEGACY_ERROR_HANDLER flag is set);
Modified boot/sega.s to include the new error handler as a pre-compiled blob;
Added bin/convsym.exe utility version 2.12 (compiled from https://github.com/vladikcomper/md-modules/tree/master/utils/convsym) to convert symbols for the MD Debugger;
Modified makefile.gen to add new injectSymbolsInROM target for "debug" build profile, so debug symbols are only injected in debug ROMs.
Symbol injection is performed by convsym.exe after building the ROM: it appends symbols to the end of the ROM and injects symbol data pointer at the offset of MDDBG_SymbolDataPtr variable defined in sega.s (barebones linking).
symbol.txt enhancement: modify makefile.gen to compile object files with -g flag to include source-line information, invoke nm with -l flag to dump this information.

Error handler implementation details

Error handler was designed to be stand-alone and portable. It aims to support all major 68K assemblers (now GNU As as well), so it comes as a pre-compiled blob with minimal bindings;
It doesn't require any memory, everything is placed on the stack, memory consumption is small (survives with 128 byte stack);
Supports symbol tables in my custom DEB2 format (generated by convsym.exe); format is optimized for fast searching (faster than O(log n)), symbol data is compressed;
Flexible console engine with buffered IO and automatic line breaks (long lines won't be cut off).

How to test
You can apply the following patch to sample/game/sonic (my favourite game):
diff --git a/sample/game/sonic/src/main.c b/sample/game/sonic/src/main.c
index 0ea29d42..3d5128b1 100644
--- a/sample/game/sonic/src/main.c
+++ b/sample/game/sonic/src/main.c
@@ -134,6 +135,8 @@ static void joyEvent(u16 joy, u16 changed, u16 state)
     {
         paused = !paused;
         HUD_setVisibility(paused);
+
+        asm("illegal");
     }

You should now see it crash when pressing Start. You should see crash offset as joEvent+XXX with "debug" build profile.
Compatibility

Existing SGDK projects must update their local boot/sega.s.
You must rebuild SGDK library if LEGACY_ERROR_HANDLER is disabled.

@Stephane-D Thanks a lot for reviewing it quickly and liking my debugger in the first place :)
I made a few updates following your feedback:

ConvSym's base source code is included (I didn't include test suite though, it'd be an overkill: I extensively test symbol conversion against listings of huge projects and disassemblies, that's millions lines of codes, so my tests are over 70 MiB :slightly_smiling_face:)
I split everything error vector related from boot/sega.s to error_a.s in the library itself. And it's much cleaner and easier to maintain now, this was definitely the right move.

One tiny thing: Codacy freaked about about ConvSym's source code (mostly unusual Markdown syntax, haha), so I think it's better to add ./tools/convsym to ignored files in Codacy settings.


Get the position of ecctrl on each Frame

I am trying to implement a proximity kind of thing, where a character is about to reache near some 3D mesh or node at that particular time, the audio starts playing while comparing the distance between character and that particular node.
How can i get the position at each particular frame of the ecctrl controller?

Give ecctrl a ref, and track it's translation: ecctrlRef.current.translation()

I tried using the ref, but it returns the translation value only once, when it is mounted into the scene. I need the value of translation on each frame for comparison.

Did you put it in the useFrame loop?

yes, obviously!

Here is my code snippet.
`useEffect(() => {
console.log("Connecting", controllerRef?.current?.translation());
console.log("Connecting City", cityRef?.current?.position);
}, [controllerRef, cityRef, controllerRef?.current, cityRef?.current])`

<KeyboardControls map={keyboardMap}>                             <Controller                                 maxVelLimit={5}                                 camMaxDis={-5}                                 camMinDis={-5}                                 mode="FixedCamera"                                 camCollision={false}                                 autoBalance={true}                                 enabledRotations={[false, true, false]}                                 ref={controllerRef}                             >                                 <RigidBody                                     ref={cubeRef}                                     colliders="hull"                                     restitution={0.01}                                     friction={1}                                     position={[0, 0, 0]}                                     onCollisionEnter={handleCollision}                                     type="fixed"                                 >                                     <Character                                         modelPath="../assets/glbs/character.glb"                                         scale={0.01}                                         position={[0, -1.5, 0]}                                     />                                 </RigidBody>                             </Controller>                         </KeyboardControls>

You need useFrame:
 useFrame(() => {
    if (ecctrlRef.current ) {
      console.log(ecctrlRef.current.translation());
    }
  });

Apply the ref to your ecctrl tag: <Ecctrl ref={ecctrlRef}>

Thanks, this worked for me.

Thank you for your support.


west_wrapper.bat is deleted during Debug Manager, Apply and Debug steps.

Using v1.2.4 of the plugin I noticed the following behavior:
After I built or pristine built a project I see that in build// folder I see the west_wrapper.bat. Then I call the Debug Manager, configure the gdb and debugserver (currently using openocd). When I want to debug, starts to rebuild everything and at the end is missing west_wrapper.bat. It fails in the moment when the cortexdebug is popping up.
The console output looks like this.
1: (70) LaunchOptions{"name":"Zephyr Workbench Debug","type":"cppdbg","request":"launch","cwd":"E:\\w\\easy6\\easy-ws\\wired_uart_out","preLaunchTask":"West Build","program":"E:\\w\\easy6\\easy-ws\\wired_uart_out\\build\\samd21_xpro\\zephyr\\zephyr.elf","args":[],"stopAtEntry":true,"svdPath":"e:\\w\\easy6\\svd\\ATSAMD21J18A.svd","environment":[],"externalConsole":false,"serverLaunchTimeout":10000,"filterStderr":true,"filterStdout":true,"serverStarted":"halted due to debug-request, current mode: Thread","MIMode":"gdb","miDebuggerPath":"c:\\Users\\Tibor\\zephyr-sdk-0.16.8\\arm-zephyr-eabi\\bin\\arm-zephyr-eabi-gdb.exe","debugServerPath":"E:\\w\\easy6\\easy-ws\\wired_uart_out/build/samd21_xpro/west_wrapper.bat","debugServerArgs":"debugserver --build-dir E:\\w\\easy6\\easy-ws\\wired_uart_out/build/samd21_xpro --runner openocd --config openocd.cfg --config E:\\w\\easy6\\easy-ws\\wired_uart_out/build/samd21_xpro/gdb.cfg ","setupCommands":[{"text":"-environment-cd E:\\w\\easy6\\easy-ws\\wired_uart_out\\\\build\\\\samd21_xpro\\\\zephyr"},{"text":"-target-select remote localhost:3333","description":"connect to target","ignoreFailures":false},{"text":"-file-exec-and-symbols zephyr.elf","description":"load file","ignoreFailures":false},{"text":"-interpreter-exec console \"monitor reset\"","ignoreFailures":false},{"text":"-target-download","description":"flash target","ignoreFailures":false},{"text":"set breakpoint pending on","description":"Set pending","ignoreFailures":false},{"text":"tbreak main","description":"Set a breakpoint at main","ignoreFailures":true}],"logging":{"moduleLoad":true,"trace":true,"engineLogging":true,"programOutput":true,"exceptions":true},"__configurationTarget":6,"configSource":"workspaceFolder","debugType":"debug","__sessionId":"e03d7295-50ee-47cb-acc6-ccfac3917559"}
1: (115) Starting: "E:\w\easy6\easy-ws\wired_uart_out/build/samd21_xpro/west_wrapper.bat" debugserver --build-dir E:\w\easy6\easy-ws\wired_uart_out/build/samd21_xpro --runner openocd --config openocd.cfg --config E:\w\easy6\easy-ws\wired_uart_out/build/samd21_xpro/gdb.cfg

This wired_uart_out app basically is a copy of the hello_world.
I tried multiple combinations. For example, when I create new app from hello_world sample, when was just created I can debug. Then I clean the build directory, change the board, built with that, than clean again, switch back to the samd21_xpro board, and than build and configure the Debug Manager again and fails.
Then I just copied the original hello_world and renamed to wired_uart_out. That fails from the first attempt.
I tried to delete build folder, including .vscode folder and redo. Still the same.
But sometimes, not so often still works.

The west_wrapper.bat is only generated in the build directory when you click on Apply or Debug from the Debug Manager. If the project requires pristine built, it will remove items from the build directory and the wrapper as well... We may need to generate the wrapper out of the build directory to avoid that or find a way to generate the file after rebuild.

I already noticed that build will delete the wrapper, therefore I always applied the debug manager configuration.
I recorded a video how it happens. You will see two issues in the video.
1 - If an app sits in the workspace folder and has no build folder, nor .vscode folder, when I import the app, I have to do it twice.
2 - The wrapper is deleted while in Debug Manager I press Apply and Debug. Apply is creating the wrapper, then debug somehow is triggering the rebuild, which deletes the wrapper.
the recorded video is on youtube, by clicking here
Note, that the video was recorded by OBS with window capture feature, therefore the popup windows during import and the final error window are not visible. The final error is in the console and is trying to tell us that the debug wrapper is missing, which is true.

Continuing...
Now I compared the content between the application folder which fails and which doesn't fail to debug.
In .vscode/compile_commands.json I see a difference. The version which works still points to zephyr/samples/hello_world folder, despite I created the application with folder location filled to be in the top folder of my workspace. Means that, the copy of the app was made into the top folder, but the compile_commands.json still points back to the original place from where it was copied.
Then when I delete the .vscode folder, this compile_commands.json which has these paths to the original location is deleted. When I re-import the app, the compile_commands.json is recreated with the correct content. Unfortunately, the Debug Monitor, Apply and Debug in this case somehow triggers the rebuild, which zaps the debug wrapper.bat
To be able to fix, first one must fix the application creation process, to not sneak in the original path from where it was copied. Then, I expect that the Debug Manager, Apply and Debug steps uniformely will fail with any of your applications. Similarily when we just delete .vcode from the app and we would like to re-import again.

I already noticed that build will delete the wrapper, therefore I always applied the debug manager configuration. I recorded a video to show you how it happens. You will see two issues in the video.
1 - If an app sits in the workspace folder and has no build folder, nor .vscode folder, when I import the app, I have to do it twice.

I find out that the function to check if the workspace folder is an app (by checking tasks) is called before VS Code had finished parsing newly created .vscode which causes the missing app in the view. The solution is to refresh the view only after .vscode/tasks.json changes are detected by VS Code.

2 - The wrapper is deleted while in Debug Manager I press Apply and Debug. Apply is creating the wrapper, then debug somehow is triggering the rebuild, which deletes the wrapper.

The wrapper will be generated in <app>/build/.debug/<board_identifier> instead of <app>/build/<board_identifier>. The rebuild won't affect the files generated by Zephyr Workbench anymore.

the recorded video is on youtube, by clicking here
Note, that the video was recorded by OBS with window capture feature, therefore the popup windows during import and the final error window are not visible. The final error is in the console and is trying to tell us that the debug wrapper is missing, which is true.
One more note: If I import the same hello_world app, by leaving in the original zephyr/samples folder, the above issue doesn't happen. To reproduce, you have two options (practically the same):

You must copy the hello_world folder into the top folder of the workspace,

Or an already installed hello_world app (using the Create New Zephyr Application button, and specifying the project location to be the top folder), then removing from workspace and deleting build and .vscode folder. Similarily with situations when we first create or copy a clean app.

The fix is published in the version 1.2.5


Error

Traceback (most recent call last):
File "/home/thinhnlfx18071/NS-LOOKUP/nslookup.py", line 75, in
loop()
File "/home/thinhnlfx18071/NS-LOOKUP/nslookup.py", line 18, in loop
head = pyfiglet.figlet_format("NS-Lookup")
NameError: name 'pyfiglet' is not defined

This means you just installed terms
I'll fix this soon and I'll get back to you
Thanks for the feedback

im using termux btw

I've fixed it
Now open termux and type the following command
rm -r -f NS-LOOKUP
This will delete the current repository, then install it again

thanks dude works now!


Migration of data on IM updates

When changes are made to the IM tables, it should be updated without affecting existing data. We will use alter scrips and maintain versions for the changes so that we could also do a possible rollback.
Suggested tools:

Flywaydb
Liquibase

Note that even thoughh we use SQL to formulate the IM, we are not running a system. The priority is to keep the IM as readable as possible, so versioning will be out of scope for the foreseeable future.


doc: release_process: drop the paragraph about release freeze

Drop the stable API paragraph mentioning API and feature freeze for multiple release. This hasn't been done or considered for as long as I remember and I don't think any developer really wants this.

...unless I'm misinterpreting the meaning of it.

I was also just reading that and wondered the same thing 😅

Sounds like this should go through the Process WG right?

btw, this was followed for LTS2 and for LTS3 we might now have had any controversial changes coming last minute (well, aparat from hwmv2 where some kind of 'exception' was made).

Sounds like this should go through the Process WG right?

sure, but what exactly are you proposing? Removing this guideline/rule basically means anyone can rewrite the zephyr kernel and how it works 2 days before LTS feature freeze and having some of the most basic APIs/ and the core of OS ship in a completeley unstable stable state, and it should be "okay".  Is this what you want?

Removing this guideline/rule basically means anyone can rewrite the zephyr kernel and how it works 2 days before LTS feature freeze and having some of the most basic APIs/ and the core of OS ship in a completeley unstable stable state, and it should be "okay". Is this what you want?

The text mention freezing the API for two releases and kernel for one so the way I read it this would have prevented any stable API change from 3.5 and any kernel feature from 3.6, is that correct or am I misinterpreting it? It just does not seems like something we do.

It is my understanding, that if these had been followed for v3.6.0, lots of the proposed changes should have been postponed (and even HWMv2 shouldn't have gone in now).

beside hwmv2, which originally was supposed to follow this (in the original schedule from 2022) what stable kernel, base os did we break or completely overhaul?

beside hwmv2, which originally was supposed to follow this (in the original schedule from 2022) what stable kernel, base os did we break or completely overhaul?

One of the paragraphs says:

All stable APIs need to be frozen 2 releases before an LTS. APIs can be extended with additional features, but the core implementation is not modified. This is valid for the following subsystems for example:

Device Drivers (i2c.h, spi.h)…
Kernel (k_*):
OS services (logging,debugging, ..)
DTS: API and bindings stability
Kconfig

As I read that, it basically means that our migration guides for v3.5.0 and v3.6.0 (2 releases before an LTS) should have been empty except for changes to unstable/experimental APIs? All other APIs should have been frozen except for API extensions.

From the process meeting (@nashif @fabiobaltieri and @kartben) the conseus seems to be that this could use some rewording while keeping the idea of blocking core changes in the last two releases as a guideline. I'll look into reworking this PR into a rewording.

can we move this out of the process working group project area or move it to done or something? Just trying to clean up the project area


Moonlight

Mod name
Moonlight
Curseforge link
No response
Other links
https://github.com/Gregor0410/SeedQueue
What it does
Mod that offsets stronghold generation to a separate thread to increase the loading speed of Minecraft worlds.
It performs much better with starlight mod #21 and chunk mod #161
Why should it be in the modpack
It makes loading much faster loading with chunk mod
Why shouldn't it be in the modpack
No CF, Need to build no release
Categories
Performance optimization, Fixes a bug/makes another mod work
Additional details
https://gist.github.com/alkyaly/02830c560d15256855bc529e1e232e88#gistcomment-3940624

Abandoned mod.


Edit Item

Allow the user to edit items.

First commit: https://github.com/johneastman/todo/commit/de8ebf69c5efb0aa8c6b5402305661d7149f1c83

Update logic complete: https://github.com/johneastman/todo/commit/4c22fcb127ebac688043dca9a8021bfd2e456aa3


yaml stringify is different from deno fmt

Is your feature request related to a problem? Please describe.

Using @std/yaml stringify and deno fmt on the file afterwards the file is reformatted.
This should not happen. stringify should output the same format or allow for the same format to be configured.
Currently, this involves the quotes style (' vs ") where @std/yaml uses ' while deno fmt uses ".
There is no StringifyOptions to configure this behaviour and there is no way to call deno fmt from code? (Or is there?)
Describe the solution you'd like

Ideally @std/yaml stringify should output YAML which is already in the format expected by deno fmt. Being able to configure @std/yaml would also be helpful.
Describe alternatives you've considered

Being able to use deno fmt from code like Deno.fmt(…).

deno fmt uses "

Not if you set the singleQuote option to true 😉

there is no way to call deno fmt from code

There is, as long as you don't mind running it against a file on disk (not a string/buffer in memory) and as long as you're able to run your code with --allow-run permissions:
await new Deno.Command(Deno.execPath(), { args: ['fmt', filePath] }).spawn().output()

deno fmt uses "

Not if you set the singleQuote option to true 😉

Changing that option would also change the code. And I would prefer less complex config, ideally defaults.
For now I went with excluding yaml in the deno.jsonc as they are generated by @std/yaml. But in the long run I shouldn’t need this, therefore this issue.


refactor storage and logging to prep for mac cache

Currently, MSAL Cache Storage is one file with some "if platform / do logic" for each platform.  There is also the assumption that each platform will have one file / blob.  This may not be true as there may be cases where we split into more than one file or we don't save to a file at all.
So to prep for ensuring we do "TheRightThing(tm)" on each platform and that action is clear, I've made MsalCacheStorage into an abstract class which has a static Create to check the platform and return the appropriate sub-class implementation.
I've also updated the trace logging to add TraceSourceLogger to remove the need to have the "/* id */ 0" call in each of the calls to TraceSource.LogEvent which cleans up readability a bit.
The goal of this PR is that it just restructures/moves code but does not add/remove any functionality from the current execution.  Any actual functional changes will come in follow up pull requests.

@henrik-me : do we want to merge this?

No

@henrik-me - Could you pleasse re-review this?


Enable use of static locally-bundled files from WebView

Set up a build subsystem allowing static assets to be pushed to the bundled app for use in the WebView, and enable their use from the WebView itself.
Although only static assets are currently supported, there is a place marked out in the build scripts for future build-time generation of these assets.
Note that the last two commits in this PR are not really part of the above; they're instead an example and a test, transforming some of the existing dynamically-injected-but-otherwise-static CSS into a static file.

Temporarily withdrawn while I track down an unrewritten resource. (When a message is starred or unstarred, the resulting reload tries to load a remote resource locally.)

... and upon investigation, that seems to be just the new effect of an existing attempt to load untransformed URLs, rather than a completely new bug. Reactivating!

I've just merged the first 5 of the 11 commits in this branch, as:
bfb15d794 Xcode project: update with new version
e6b193607 webview build: add new script `tools/build-webview`
690731545 webview build: call new script from Gradle
63fe17925 gradle: Add comment-pointers to commits fixing related issues
5ca2fbd2b webview build: call new script from Xcode

Thanks! You've also sent a version of the 6th as #3644, which I expect I'll merge shortly.

Ready for (re-)review.
(If you've looked at the version from three days ago, the only difference between that and this is a typo fix.)

This push does not (yet?) include the refactoring commits mentioned above.
Also, GitHub won't let me respond to the URL/path comment chain... which is probably for the best, honestly. The important thing is that I've adjusted the comments in that area, and hopefully in a constructive manner!

Also, GitHub won't let me respond to the URL/path comment chain

FFR on some other issue where you'd like to do so (no need to do so here, it's a long comment-chain and the branch is the place where edits ultimately matter): I think sometimes when a reply-comment is part of a review, it lacks a reply box where it appears as part of the review. Like here:

but at the same time it also appears upthread underneath the OP comment it's a reply to, and it has a reply box there:

GitHub. shrug
So that's what I'm seeing for that comment. Does that match what you see?

Thanks for the updates! This looks good. I think what I'd like to do next with this is:

I'll go ahead and merge it. (After a filter-branch with tools/generate-webview-js -- that's the bit that's failing in CI.)
Then I'll take a stab at the URL-related refactorings we've discussed above.

That'll let us swap places on this code, since it's been for a few weeks in a mode of you writing and me reviewing. I'll get to try to apply and serialize the things I learned yesterday from studying the spec and docs, which is probably most efficient by me writing and you reviewing; and it'll help you be done and move on to the next phase.

The comment on assetsPath makes much more sense to me now, thanks. :slightly_smiling_face: I think a more apropos name to go with that description would be like assetsPathUrl -- something that identifies that it's in the form of a URL, not directly as a path. But the comment helps a lot, and it's not like this is a name in a broad API that has a bunch of callsites scattered all over, which would make the name much higher-stakes. So I'm happy merging, and possibly tweaking in followup.
It's also still quite mysterious what this is interpreted relative to when it's a relative URL, on iOS. But as I found in https://github.com/zulip/zulip-mobile/pull/3636#discussion_r340343686 , that mystery seems to go all the way down through the WebKit API into the Apple secrecy-bubble. I may try turning that PR comment into one in the tree and/or a commit message.

(After a filter-branch with tools/generate-webview-js -- that's the bit that's failing in CI.)

FTR the command was:
git filter-branch --tree-filter tools/generate-webview-js @{u}..master
That's something that should be more automated, has never been quite annoying enough to automate further... but one of the side benefits of having tools/build-webview is that it should be pretty easy to automate that away soon!

It's also still quite mysterious what this is interpreted relative to when it's a relative URL, on iOS. But as I found in #3636 (comment) , that mystery seems to go all the way down through the WebKit API into the Apple secrecy-bubble. I may try turning that PR comment into one in the tree and/or a commit message.

Done, as 067a5e356. Please take a look!
(Because this is entirely in a comment, as I said recently elsewhere about docs I think it's best to handle it with primarily post-commit review.)

The comment on assetsPath makes much more sense to me now, thanks.  I think a more apropos name to go with that description would be like assetsPathUrl [...]

Works for me.

It's also still quite mysterious what this is interpreted relative to when it's a relative URL, on iOS. But as I found in #3636 (comment) , that mystery seems to go all the way down through the WebKit API into the Apple secrecy-bubble. I may try turning that PR comment into one in the tree and/or a commit message.

Done, as 067a5e3. Please take a look!
(Because this is entirely in a comment, as I said recently elsewhere about docs I think it's best to handle it with primarily post-commit review.)

This appears to be evidence against that proposition. :upside_down_face: I'll have a revision along shortly for review.


Improved the user interface of the signup page

Description
I updated the UI of the signup and footer components. This fixes #34. react-hook-form was used to implement form validation.
#34
How Has This Been Tested?
The code ran on local machine and functioned well.
Screenshots (if applicable, else remove this line / section)

Checklist:

[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas
[ x] I have added necessary inline code documentation
[ ] I have added tests that prove my fix is effective and that this feature works
[ ] New and existing unit tests pass locally with my changes

Merging conflict has been resolved to fix #34


feat: add new template functions

Add a template function, listMostPopularPost, that lists a specified number of your most popular blog posts (in this case, with visits as the ranking field); Add the template function getStatisticsData to get the statistics of the blog

Thanks!


Why placemarkFromCoordinates return a list since I'm providing only one coordinate? And why doesn't the plugin require a maps api key?

💬 Questions and Help
Basically what the title says.
placemarkFromCoordinates require only one coordinate, why does it return a List<Placemark> with multiple Placemarks?
Also, usually geocoding plugins ask for a google maps api key so it can avoid the systems restrictions. Would be great to have this option.
And last, is this project still being supported? Because I see a lot of old open issues with no replies and it concerns me if the devs are still working on this project.
Best regards

It was the behavior of Google Geocoding API will return a list of place around provided coordinate, from Google Geocoder.
Yes sure, I hope there is option to pass google API to control metric/billing by ourselves

This is precisely my concern, my company provided Google Maps API key for extensive use so it makes sense to give us the option to use our API key.

Hi @dpedrinha,
First of all apologies for the belated reply. This plugin is still being supported however due to company restrictions we were not able to spend the amount of time necessary to go through all issue. Recent reorganisations allow us to structurally spend time on our open-source projects and thus allowing us to work through the issue backlog.
To answer your questions:

Since the Apple and Google APIs cannot always guarantee an exact address for the supplied coordinates a list of nearby addresses is returned. It is up to the consuming parties to filter out the best result. More details can be found in the respective native documentation (Apple, Android).
The Geocoder plugin is a simple wrapper around the native CLGeocoder (on iOS) and Geocoder (on Android) SDKs. These SDKs are supplied along side the operating system and are free to use (given certain restrictions in the form of rate limitation). These SDKs are available on all Android and iOS devices and offer limited functionality. We have thought about adapting other SDKs (e.g. payed Google Maps, HERE or MapBox), however those services already offer their own Flutter SDKs with much more functionality. Since people are paying for certain services, they'd most likely want to have access to all features and not the limited subset the Geocoding plugin offers. Also we cannot guarantee support for third party premium products.


Rescue publishing api consumer rake tasks to prevent sigterm errors b…

…eing raised
As discussed with @MatMoore, this PR includes no tests due to the fact that there is no good way to test this functionality, and any test written to do so would just be testing the ruby rescue method.

 (1) Fix: SignalException: SIGTERM


JRuby 9000 compatibility (warning printed on start)

After installing JRuby <IP_ADDRESS> and gem installing trinidad, the following error is printed to console during Trinidad start:
Deploying from /home/josh/hello_world as /
Initializing ProtocolHandler ["http-bio-<IP_ADDRESS>-3000"]
could not resolve compat version from '2.2.2' will use default
java.lang.IllegalArgumentException: No enum constant org.jruby.CompatVersion.RUBY2_2
	at java.lang.Enum.valueOf(Enum.java:236)
	at org.jruby.rack.DefaultRackConfig.getCompatVersion(DefaultRackConfig.java:87)
	at org.jruby.rack.DefaultRackApplicationFactory.initRuntimeConfig(DefaultRackApplicationFactory.java:306)
	at org.jruby.rack.DefaultRackApplicationFactory.createRuntimeConfig(DefaultRackApplicationFactory.java:252)
	at org.jruby.rack.DefaultRackApplicationFactory.init(DefaultRackApplicationFactory.java:87)
	at org.jruby.rack.RackApplicationFactoryDecorator.doInit(RackApplicationFactoryDecorator.java:112)
	at org.jruby.rack.PoolingRackApplicationFactory.doInit(PoolingRackApplicationFactory.java:111)
	at org.jruby.rack.RackApplicationFactoryDecorator.init(RackApplicationFactoryDecorator.java:100)
	at org.jruby.rack.RackServletContextListener.contextInitialized(RackServletContextListener.java:50)
	at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4994)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5492)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1575)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1565)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Although the error is displayed, a simple "hello world" Rack app seems to function normally.

@kares: I looked into JRuby internals... it seems to list CompatVersions up to 2.1.
If trinidad boots and it can't find the appropriate CompatVersion it says "using default". In that case, is trinidad set to 2.2 compat mode? And if so, do we need to log this exception? Despite the warning trinidad appears to function normally with a small test app + JRuby 9000. Another possibility would be forcing compat to 2.1 if it's undefined, although I don't know if that's the proper thing to do.

as noted already, this should be fixed on master: https://github.com/trinidad/trinidad/commit/e6cd3418f9f38426f0fc1062e7e4983d0a35eeb5

This exact issue affected me on a new rails app generated from scratch today.


Revert "Feature/logo"

We are reverting this pull request due to an unintentional self-merge. We will redo the pull request to allow team members to review the pull request first.


Test_terminal_getwinpos fails when terminal is large

Describe the bug
Test Test_terminal_getwinpos() fails when terminal has many columns (>= 203 columns).
To Reproduce

Use a large terminal with >= 203 columns. You may need to reduce font size to be able to have a terminal with enough columns.
I can reproduce the ticket with for example with terminal that has 58 lines & 203 columns.
The bug does not happen with a terminal size of 58 lines & 202 columns.
I think that bug happens when number of columns is >= 203.

Run:

$ cd vim/src/testdir
$ make test_terminal
...snip...
Executed 78 tests
1 FAILED:
Found errors in Test_terminal_getwinpos():
function RunTheTest[40]..Test_terminal_getwinpos line 25: Expected range 1 - 999, but got 1246

Expected behavior
All tests should succeed.
Environment

vim-8.1.1140
OS: xubuntu 18.04.2 (up-to-date), x86_64
Terminal: at least xterm(330) or MATE terminal (1.20.0) & console without X.

Dominique wrote:

Describe the bug
Test Test_terminal_getwinpos() fails when terminal has many columns (>= 203 columns).
To Reproduce

Use a large terminal with >= 203 columns. You may need to reduce font size to be able to have a terminal with enough columns.
I can reproduce the ticket with for example with terminal that has 58 lines & 203 columns.
The bug does not happen with a terminal size of 58 lines & 202 columns.
I think that bug happens when number of columns is >= 203.

Run:

$ cd vim/src/testdir
$ make test_terminal
...snip...
Executed 78 tests
1 FAILED:
Found errors in Test_terminal_getwinpos():
function RunTheTest[40]..Test_terminal_getwinpos line 25: Expected range 1 - 999, but got 1246

Expected behavior
All tests should succeed.
Environment

vim-8.1.1140
OS: xubuntu 18.04.2 (up-to-date), x86_64
Terminal: at least xterm(330) or MATE terminal (1.20.0) & console without X.

That rough value of 1000 was clearly not a good idea.
I'll calculate it more accurately.
--
Google is kind of like Dr. Who's Tardis; it's weirder on the
inside than on the outside...
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


fix web python.md

Anyone else need review?

@00Kai0 Anyone else need review? Or I can merge it (mind the breaking changes report)?


Test OpenSeadragon and Mirador to make sure CORS configuration is not necessary

Coming out of a discussion over at #1294 between me and @seth-shaw-unlv, we should test OpenSeadragon in a variety of client/server IP address combinations to make sure that we don't need to configure Drupal's CORS settings. I have been seeing some inconsistent behaviors testing Islandora on my home network using 192.168. addresses and public IP addresses. The OpenSeadragon github issue queue has lots of references to CORS so I suspect that we'll need to document something around this.
CORS is, apparently, not documented anywhere on the d.o. website yet the options exist in sites/default/default.services.yml, which must be adjusted and then copied to sites/default/services.yml, and then cache cleared.

We should test Mirador too when https://github.com/Islandora/islandora_defaults/pull/10 gets merged (or even prior to that).

Some useful examples at https://www.drupal.org/node/2715637.

Bumping into this now with ISLE and openseadragon.  It's totally a thing.

Just to circle back to this one.  We solved this in ISLE with Traefik (the front end proxy to the whole stack).  TL;DR even though they're separate containers/servers, if you expose cantaloupe and matomo as sub-paths off the main site, there's no CORS.  E.g. if your Drupal is at http://example.org, cantaloupe is at http://example.org/cantaloupe and matomo is at http://example.org/matomo.  Otherwise, yes, you gotta set up CORS and it's a PITA.

I think we can close this one.  Feel free to re-open if neccessary.


Unable to create workspace.

Windows 10
Installed plugin, Cross-Platform Command-Line (TF), JDK, accepted tf eula, added JAVA_HOME and TF_HOME system variables. Signed in to vsts. Can choose a project from list.
When i click create workspace, popups window with a status of creating workspace, then i get error:
KEY_TF_BAD_EXIT_CODE
com.microsoft.alm.plugin.external.exceptions.ToolBadExitCodeException: KEY_TF_BAD_EXIT_CODE
at com.microsoft.alm.plugin.external.tools.TfTool.throwBadExitCode(TfTool.java:86)
at com.microsoft.alm.plugin.external.commands.Command$1.completed(Command.java:135)
at com.microsoft.alm.plugin.external.ToolRunner$ProcessWaiter.run(ToolRunner.java:239)
On another machine (Windows server 2012 r2) when i do same steps, window with a status of creating workspace displays a few seconds, then closes and nothing happens.
Same steps on Windows 7 - works very good.

Thanks Hirr0 for reporting this issue. We are aware of some problems creating the workspace. We hope to have some fixes out very soon.

@Hirr0 - Hi, we have pushed out a new update with some fixes in this area. Please take a look and let us if the problem is not fixed. The newest release is v1.107.1. You should be able to update it within the IDE.
Thanks for helping us track down these problems!
Jason

I've tried to checkout with different directory names, it didn't help.

Hi Hirr0,
I am sorry to hear that the newest version of the plugin didn't fix your issues. Can you share your logs here? You can find out more about sharing your logs here: http://java.visualstudio.com/Docs/tools/intelliJ#_frequently-asked-questions-faq
Thanks,
Jason

Windows 7, Android Studio 2.1.2
everything looks good, the plugin finds my server and I login to the server, but when I choose my repository and click on "Create Workspace" it freezes.

Confirmed freezing for Windows 10, Android Studio 2.2.2. (Technically not "freezing", I can still move the window, but no progress happens and I can't click anything inside the window anymore.)

@dertuxmalwieder - Thanks for the confirmation. We hope to get a repro for this problem so that we can address it. Could you provide your Android Studio logs?
Thanks,
Jason

Sure thing. Seems like it's just "WAITING" like forever while creating new threadDumps every five seconds.
I'd appreciate it if you deleted the attachment after evaluating. Too many personal data. :-)
logs.zip

2016-11-08 16:28:52,967 [  35182]   INFO - n.context.ServerContextManager - validateTfvcUrl: failed to get collection info

Could be relevant here. The last line before the dumps. For some reason connection works only before that.

@dertuxmalwieder - I downloaded the file and removed the file link. Thanks for providing that. If you want to increase the memory for Android Studio you can follow these steps:
If your logs have a lot of “High memory usage (free 88 of 1246 MB)” statements, you may want to increase the amount of memory available to Android Studio.

Go to Help->Custom VM Options…
Create a custom VM options file when prompted
And add 2 lines with the values you want (the default max is 1280):
-Xms1280m
-Xmx4096m

I am looking at the logs now and will hopefully find something we can use to repro and fix the issue.
Thanks,
Jason

This machine is not too new, I'm happy that Android Studio works at all :-). A higher memory usage would probably be disturbing. (Especially since I'm not the only developer of this project and the other one has a number of VMs open most of the time.) But thank you, we'll discuss that.
Let me know if I can help you further.

FYI: Still broken in the latest update.

@dertuxmalwieder - Unfortunately, the logs only showed a "Service not available" error. Nothing more can really be determined. If possible could you try using the IP address of the server instead of the name? Something like http://<IP_ADDRESS>:8080/tfs
And make sure you can reach the same url thru the browser on that machine.
Are you using an http proxy? We have a known issue with proxies.
Thanks,
Jason

Yes, I'm behind an intranet proxy, but Android Studio actually uses it...?

With verison 1.111.1 it works. Only one nuance: In JetBrains Rider - works out of the box, but in IntelliJ or WebStorm i have to change java -Xmx2048M to java -Xmx512M in tf.cmd file . Can't understand why, because i have 16GB memory on my machine and half of it is free.
Close please, if it's needed. thank you.

Thanks for validating the fix and letting me know about the difference between Rider/IntelliJ/WebStorm. I will look into that and see if I can figure out why the memory would need to be changed.

Hello. This problem still exists.


[WIP] Inconsistency fixes for ZIPs 226 and 227

ZIP 226 and 227 review: Overall comments

[x] Better draw the relationship between ZIP 226 and 227: Avoid to force the reader to bounce from 226 to 227 and back. Try to keep the relation between both ZIPs as linear as possible and define key common terms in 227, then refer to 227 from 226 (instead of defining things in both and bouncing from one to another)

227 is the predecessor of 226
226 builds in 227

[ ] Use consistent capitalization when referring to terms defined in the TERMINOLOGY

[x] Change e.g.: to e.g.

[ ] Make sure orders are all consistent when using tuples: some arguments orders are inconsistent.

[x] block chain -> blockchain (everywhere)

[x] Fixed in 226
[x] Fixed in 227

[x] Be consistent with indices over summations.

These are missing in many cases: Always specify them explicitly, that removes potential ambiguity and flag potential errors.
Use the \sum_{i=1}^n notation instead of \sum_{\forall i \in S} which is heavier and not consistent with the Zcash specs that use the \sum_{i=1}^{n} notation.

[x] Shouldn't we use the notations for the group operations defined in <IP_ADDRESS> of the Specs instead of sums everywhere?

[ ] Some \forall are unnecessary and can safely be removed to simplify notations

[ ] Be consistent in the order in which subscripts an hyperscripts are used. e.g. t_{i}^{n} and t^{n}_{i} are equivalent but inconsistent. It's better to have a systematic approach and e.g. always define the subscript first t_{i}^{n}

TODO: Check if we can use latex macros in rst files, this will standardize notations and save a lot of typos.
ZIP 226

Page 3:

[x] Orchard.Output must probably be NoteCommit^{Orchard}.Output
[x] cm^{OrchardZSA} is that the same as cm_{ZSA}? Fixed in #16

[x] Broken itemize in Backward compatibility section
[x] inconsistent notations for AssetBase. As per ZIP-227 an assetID maps to an AssetBase denoted AssetBase^{protocol}_{assetID}, the upper and subscripts are missing many times. To fix.

[x] If the notation is too heavy, we can define AssetBase^{protocol} as an alias of AssetBase^{protocol}_{assetID} and also define AssetBase as an alias of AssetBase^{protocol}_{assetID} when the protocol is clear from context, e.g. in ZIPs 226 and 227, it is clear that the protocol that is built upon is Orchard, so it may be worth and clear enough to say that AssetBase = AssetBase^{Orchard}_{assetID} when the notations become too heavy (e.g. when assetBase needs to be used in a subscript or "exponent"). - DONE in ZIP227

[x] Page6: in the definition of cv^{net}, the input order to the ValueCommit function isn't consistent compared to bvk in Burn Mechanism section. Use convention: v first, AssetBase second (everywhere)

[x] Fixed the tuple order in assetBurn to be consistent with the argument order of ValueCommit

[x] Page13: in bvk equality, assetBurn is defined a set (not a vector btw), so we sum over the set. Then do I get it properly that j is the index related to the the set assetBurn? What's the cardinality of this set? (n should correspond to the number of action descriptions with value commitment cv^{net}). I don't get the rcv_{i,j} notation don't we miss a term in the sum over assetBurn? Isn't it smthg like \sum_{j=1}^{|assetBurn|} cv_{j} ValueCommit ....? where |S| is the set cardinality.

ZIP 227 - EDIT: All changes related to ZIP 227 have been moved in a separate PR (https://github.com/QED-it/zips/pull/20)

[x] Page 1: No need for self reference in abstract (i.e. [6] refers to the actual current ZIP)
[x] Page 5: Should purpose be purpose'?

See: https://qed-it.github.io/zips/zip-0032.html#orchard-key-path
Since the ' indicates that BIP hardened derivation is used: https://github.com/bitcoin/bips/blob/master/bip-0043.mediawiki#purpose
Was the ' omitted deliberately here? Edit: I can see the ' was added on the constant 227' a few lines below. It's unclear and error prone IMHO to have m/purpose/coin_type'/account'. We should probably use all ' at the same place instead of spreading them over different lines.

[x] Page 7/8: The Size and Bytes columns are inconsistent. Stick to Bytes or Size (in bytes) and make sure only numbers are in the column (remove bytes suffix in column entries)
[x] Consolidate most of the terminology section in ZIP227.

I have created https://github.com/QED-it/zips/pull/79 to address updates to the use of capitalization for terminology like MUST etc. The other action points seem to have been addressed in subsequent updates, so I am closing this PR for now.


UnicodeDecode Error

Hi,
Got below error while reading the training data:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x92 in position 80: invalid start byte
Tried all the ways, but could not read the file,
Finally converted the file from tsv to txt , and could read it( but I feel this is a workaround rather than a solution)
Got similar error while reading the glove file.
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 2438: character maps to
Please provide help on this.
Regards,
Pooja

I believe I run into this error at some point, but I forgot how I fixed it.

I run into the same issue after 2 year and solved it with the help from this link.
https://stackoverflow.com/a/18172249
In summary, use pd.read_csv('file', encoding = "ISO-8859-1")


install-oneagent container breaks non-root policy

Describe the bug
We're deploying istio-cni that comes with the following pod security context:
securityContext:
  fsGroup: 2000
  runAsGroup: 3000
  runAsNonRoot: true
  runAsUser: 1000
  seccompProfile:
    type: RuntimeDefault

Dynatrace injects the install-oneagent container with the following container security context:
securityContext:
  allowPrivilegeEscalation: false
  capabilities:
    drop:
    - ALL
  privileged: false
  readOnlyRootFilesystem: true
  runAsGroup: 0
  runAsUser: 0

It should also have runAsNonRoot: false so that we don't see the following error:
message: 'container''s runAsUser breaks non-root policy (pod: "istio-cni-node-ghjgn_istio-system(c7fa6210-a40f-40d9-b838-67aae08fa039)", container: install-oneagent)'

To Reproduce
Steps to reproduce the behavior:

Create a pod with above pod and security context

Expected behavior
Dynatrace injection should work with runAsNonRoot pods. Maybe the injected security context could simply be customized via the helm chart.
Additional context
K8s: v1.24.13
Istio: 1.17.2

Hi, what operator version are you running? We usually add the RunAsNonRoot: true if the base container, in that case the istio-cni also runs as nonRoot. (runAsUser != 0 and runAsGroup != 0)

We're using dynatrace operator v0.11.2. The base container of istio-cni runs with
securityContext:
  privileged: false
  runAsGroup: 0
  runAsNonRoot: false
  runAsUser: 0

Could you also attach the securityContext, that ends up on your install-oneagent container, which breaks the policy? Thanks!

It's the one I posted in the first comment
securityContext:
  allowPrivilegeEscalation: false
  capabilities:
    drop:
    - ALL
  privileged: false
  readOnlyRootFilesystem: true
  runAsGroup: 0
  runAsUser: 0

We might need to look deeper into this, however a quick fix would be to remove the runAsNonRoot: true from the base securityContext in the Pod, if every container specifies its own runAsNonRoot anyway. If that is not possible I am not sure if there is any workaround i can provide for now.
securityContext:   fsGroup: 2000   runAsGroup: 3000   runAsNonRoot: true <--- remove this   runAsUser: 1000   seccompProfile:     type: RuntimeDefault
However you can reach out to our support Dynatrace ONE rather than Github. This helps would help us to coordinate this issue with our Support aswell as to track it in a more official way.


Submit validation with nested promises

This used to work perfect in v5 but it is our last sticky point with our migration to v6.
The code below works for the success case but not for the error case.  We want two outcomes.  The first is the resolve the promise after initializePatron promise is fulfilled.  The second is to reject that promise when there is an error case.  How can we do this is v6?
    handleSubmit = (data) => {
        return new Promise(resolve => {
            this.props.login(data.email, data.password, data.remember)
                .then((response) => {
                    this.props.initializePatron()
                        .then(() => {
                            this.props.loginSuccess(response)
                            this.props.onSuccess()
                            resolve()
                        })
                })
                .catch((response) => {
                    throw new SubmissionError({ _error: response })
                })
        })
    }

I am not sure if there is more to your example. If there isn't, try rejecting the promise, instead of throwing the error:
  handleSubmit = (data) => {
        return new Promise((resolve, reject) => {
            this.props.login(data.email, data.password, data.remember)
                .then((response) => {
                    this.props.initializePatron()
                        .then(() => {
                            this.props.loginSuccess(response)
                            this.props.onSuccess()
                            resolve()
                        })
                })
                .catch((response) => {
                   reject(new SubmissionError({ _error: response }))
                })
        })
    }

In case you still have problems, please open a formal bug report.
Otherwise, please ask at StackOverflow.

In case you still have problems, please open a formal bug report.
Otherwise, please ask at StackOverflow.


[FLINK-24158][runtime] Remove useless collector in LimitOperator

Signed-off-by: TennyZhuang<EMAIL_ADDRESS>
What is the purpose of the change
Clean code in LimitOperator
Brief change log

Remove useless collector in LimitOperator

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
No

I’ve fixed it


Aws Chalice Packaging problem

Please note
I'm using aws chalice and the requirements could not be installed
$ chalice package packaged/
Creating deployment package.
Traceback (most recent call last):
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\cli\__init__.py", line 512, in main
    return cli(obj={})
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\click\core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\click\core.py", line 717, in main
    rv = self.invoke(ctx)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\click\core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\click\core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\click\core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\click\decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\cli\__init__.py", line 441, in package
    packager.package_app(config, out, stage)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\package.py", line 919, in package_app
    config, chalice_stage_name)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\package.py", line 82, in construct_resources
    self._build_stage.execute(config, resources)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\deployer.py", line 995, in execute
    step.handle(config, resource)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\deployer.py", line 851, in handle
    handler(config, resource)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\deployer.py", line 878, in handle_deploymentpackage
    config.project_dir, config.lambda_python_version)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\packager.py", line 94, in create_deployment_package
    abi, requirements_filepath, site_packages_dir)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\packager.py", line 506, in build_site_packages
    abi, tempdir, requirements_filepath)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\packager.py", line 369, in _download_dependencies
    requirements_filename, directory)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\packager.py", line 327, in _download_all_dependencies
    self._pip.download_all_dependencies(requirements_filename, directory)
  File "c:\users\cybord\appdata\local\programs\python\python37-32\lib\site-packages\chalice\deploy\packager.py", line 739, in download_all_dependencies
    error = err.decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfc in position 1397: invalid start byte

Expected behavior and actual behavior.
The installatino should perform without any errors
Steps to reproduce the problem.

Operating system
Tried On Both Mac OS X & Windows
Shapely version and provenance
shapely==1.6.4.post2

The error is from chalice, not from shapely. See https://github.com/aws/chalice/blob/master/chalice/deploy/packager.py#L767. I recommend catching that exception and inspecting err to find the problem.
This ticket may be relevant: https://github.com/aws/chalice/issues/1285.


Why Price[Energy] is not a Quantity?

Hi,
I was going to code a TimeSeries class for the Energy domain enforcing that values in the timeseries must be of type [A <: Quantity[A]]. So far so good but then I tried to create a TimeSeries of Price[Energy] and it happens that a Ratio is not a quantity. Digging deeper I see other "Ratio" quantities like Velocity having its own non-derived types.
Is this something by design or something that could be improved in current implementation? Should I create an EnergyPrice type like the one in Velocity? Is it something maybe related to https://github.com/garyKeorkunian/squants/issues/127 ?
Regards.

Hi,
It's true Price is not treated as a quantity but a ratio between Money (a quantity) and other Quantities); and that other ratios are are treated as quantities.
My thinking around these semtantics was that Price is not an "amount" of something.  That is, it's not really a quantity.  I can have an amount of money, and I can have an amount of energy, but I can't have an amount of price.  Other ratios do meet this criteria:  I can have an amount of energy, an amount of time and an amount of power (the ratio of the former 2).
Of course, the real question is why are you trying to use a unified type.  If you are simply looking to ensure everything in the timeseries is the same type, a simple TimeSeries[A] should solve the problem.
If you need to perform a polymorphic operation on the underlying members of the timeseries - and therefore looking for a method that works on both classes - the problem would be better solved with a type class.  You may already be familiar with that concept, but here's a primer:
// define an interface for the operations you want to perform on time series members
trait TimeSeriesMemberOps[A] {
def someOp(a: A, ...)
}
// Ensure your time series class requires a parameter type with an available type class
class TimeSeriesA(implicit val tsops: TimeSeriesMembersOps) {
def someMethod() = tsops.someOp( // pass in a member of series  )
}
// Define Impl's for each type you want to put in the series
class QuantityTimeSeriesOps extends TimeSeriesMemberOps[Quantity[]] {
def someOp(a: Quantity[]) = // define operation for Quantities
}
class PriceTimeSeriesOps extends TimeSeriesMemberOps[Price[]] {
def someOp(q: Price[]) = // define opeations for Prices
}
This is the better choice for implementing polymorphic operations on types that are not part of the same type hierarchy.

The reason for the unified type was convenience. When serializing the timeseries to Json we were trying to avoid the per point unit of measurement verbosity and instead serialize Doubles and tag the whole time series from the unit of the Quantity. We've considered type classes but since our need was serialization, we've created specialized serializers, one when the type is a Quantity and several ones when the type isn't.
Besides the philosophical discussion whether a Price is a Quantity or not (for us it is because is the amount of money that flows to our system in that timeseries per unit of Energy), I could imagine other magnitudes that could benefit for the Ratio being a Quantity, for instance some physical constants like gravity, concentrations or the like.


Refactor UpdateRole and add display names to invite-related responses

Summary
The following PR includes a few updates on the user management implementation.
The changes that are introduced are:

Moved the invite update logic to happen under the UpdateRole handler instead of being part of the AssignRole handler
Added a few display names based on the FE feedback
Reflected these changes on the CLI
Refactored the part of create/deleting an invitation to ensure proper behaviour
Added a protection so minder discards processing the invite if the user tries to accept an invite for a role he already has and another one where we delete his current role assignment and accept the new one ensuring he should have only one assignment per project.
Fixed the missing invite code in ListRoleAssignments and a bug where the Sponsor field was empty
Updated the minder role grant list command to also print current invitations along with current role assignments
Removed the checks for flags.IDPResolver

Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Locally.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 52.497% (-0.2%) from 52.736%
when pulling 7808543d44bc22aca8bd184d7b22511fbdd0b56f on user-fixes
into ef45f63d1d948c347337eba8f186f5e5283f37f8 on main.

coverage: 52.492% (-0.2%) from 52.736%
when pulling 60711c5e8bdd2ef82916bd664035a7a293e88f9f on user-fixes
into b5398b905cadcb3998b8a44ce651915d45911245 on main.

coverage: 52.492% (-0.2%) from 52.736%
when pulling 1d54fdcfdf96692ac991451fba69eb8ac2c4a382 on user-fixes
into b5398b905cadcb3998b8a44ce651915d45911245 on main.

coverage: 52.479% (-0.3%) from 52.746%
when pulling 8cda230570079522cb8b4d3b26219b015df35a80 on user-fixes
into 66c47f5e86ad108acf27505a27e114d3191b28df on main.

coverage: 52.465% (-0.3%) from 52.746%
when pulling 8cda230570079522cb8b4d3b26219b015df35a80 on user-fixes
into 66c47f5e86ad108acf27505a27e114d3191b28df on main.


[explore v2] saving a slice from /explore/table/ throws 500

Is this the same bug as the one addressed in https://github.com/airbnb/superset/pull/2065?

Indeed, thanks @silashundt


Is it possible to specify that some tags ONLY render with SSR

I have an isomorphic application that makes use of GTM + Helmet for my analytics needs.
I've been though the other issues logged on here, and found one other that is somewhat similar,  but not exactly the same.
The issue is regarding that if I move the server renderer hooks to, say, from the head to the body.
EG, let's look at no-script:

      ${helmet.noscript.toString()}

ultimately once the react server-side code has loaded, the no-script tag is duplicated:

     Clientside

     Serverside

My question is thus:
For things like GTM, I think this could be super useful, is there any way in the API that someone can specify that an element within helmet ONLY renders using the SSR/Client renderer?

How about something like:

        {typeof window !== 'undefined' && helmet.noscript.toString()}


Initial sort order doesn't work in table components

Steps to reproduce

Open CarBrowserTable.tsx editor
Set defaultSortOrder property of DataTable component to { manufacturer: 'ASC' }
Open http://localhost:3000/carBrowserTable

AR
Table shows unsorted items
ER
Table shows items sorted by manufacturer in ascending order

@SvyatovetsD Please add the GraphQL request to the ticket: does it contain the sort order?


Numpad Insert key does not switch between Insert and Replace modes in the script editor

Godot version
3.4.2
System information
Editor Ubuntu 20.04
Issue description
Nothing major just that while trying to see if the editor had support for the insert key I noticed that the Numpad insert key does not work regardless of whether or not the num lock is on. Whereas the insert key that is to the right of F12 works fine.
Steps to reproduce
Just press the key while using the code editor.
Minimal reproduction project
No response

Related to https://github.com/godotengine/godot/issues/38991.

What is insert on the keypad? The current godot keys enum does not have such a key.

At least on X11 none of the keypad function keys seem supported, numlock is basically handled as always on:
        { XK_KP_0, Key::KP_0 },
        { XK_KP_1, Key::KP_1 },
        { XK_KP_2, Key::KP_2 },
        { XK_KP_3, Key::KP_3 },
        { XK_KP_4, Key::KP_4 },
        { XK_KP_5, Key::KP_5 },
        { XK_KP_6, Key::KP_6 },
        { XK_KP_7, Key::KP_7 },
        { XK_KP_8, Key::KP_8 },
        { XK_KP_9, Key::KP_9 },
        // same but with numlock
        { XK_KP_Insert, Key::KP_0 },
        { XK_KP_End, Key::KP_1 },
        { XK_KP_Down, Key::KP_2 },
        { XK_KP_Page_Down, Key::KP_3 },
        { XK_KP_Left, Key::KP_4 },
        { XK_KP_Begin, Key::KP_5 },
        { XK_KP_Right, Key::KP_6 },
        { XK_KP_Home, Key::KP_7 },
        { XK_KP_Up, Key::KP_8 },
        { XK_KP_Page_Up, Key::KP_9 },

Indeed, just tested with https://www.nirsoft.net/utils/keyboard_state_view.html, numpad insert just comes through as VK_INSERT on Windows.
Also the easy test - pressing KP_0 with numlock off does toggle the script editor insert mode in 4.0 master.

So this might just be a Linux implementation bug then? We could change the XK_KP_<Function> mappings to map like their non-KP versions (e.g. XK_Insert which maps to Key::INSERT)

I can't test on Linux, but yes, it appears to be relevant to that platform only (although I can't test Mac either)

Fixed by #66773.


chore: remove all references to linking

Description
With the API update from machine -> nodeclaim, the karpenter provider removed the linking controller completely.
How was this change tested?

gc tests still behaving correctly
e2e suites (running in the PR)
scale up/scale down works correctly

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[X] No

Release Note

https://github.com/kubernetes-sigs/karpenter/blob/main/pkg/controllers/nodeclaim/lifecycle/launch.go#L59 looks like we dont support launchign nodeclaims with linking anymore in karpenter core so I am all for this change.
Do you know what version of karpneter core it was removed? Was it v0.33 or v0.32?

https://github.com/kubernetes-sigs/karpenter/blob/main/pkg/controllers/nodeclaim/lifecycle/launch.go#L59 looks like we dont support launchign nodeclaims with linking anymore in karpenter core so I am all for this change.
Do you know what version of karpenter core it was removed? Was it v0.33 or v0.32?

@Bryce-Soghigian I'm looping back to this now + rebased from main. I feel fairly confident we don't need it. However, I still can't find the exact reason why the karpenter aws provider decided to remove this. They claimed it had to do w/ removing machineutils in karpenter-core, but I'm not entirely clear why that would have made linking unnecessary.
The two relevant PRs seem to be:

https://github.com/kubernetes-sigs/karpenter/pull/658
https://github.com/kubernetes-sigs/karpenter/pull/648

And they were both in v0.33.0

https://github.com/kubernetes-sigs/karpenter/blob/main/pkg/controllers/nodeclaim/lifecycle/launch.go#L59 looks like we dont support launchign nodeclaims with linking anymore in karpenter core so I am all for this change.
Do you know what version of karpenter core it was removed? Was it v0.33 or v0.32?

@Bryce-Soghigian I'm looping back to this now + rebased from main. I feel fairly confident we don't need it. However, I still can't find the exact reason why the karpenter aws provider decided to remove this. They claimed it had to do w/ removing machineutils in karpenter-core, but I'm not entirely clear why that would have made linking unnecessary.
The two relevant PRs seem to be:

chore: remove v1alpha5 utils kubernetes-sigs/karpenter#658
chore: remove v1alpha5 from lifecycle/consistency/garbage collection kubernetes-sigs/karpenter#648

And they were both in v0.33.0

@jackfrancis  can you provide any insight here before we merge this?

The way I see it, linking is/was about Karpenter adopting instances that it did not provision, potentially useful for migrating existing clusters to Karpenter (or maybe incompatible Karpenter versions). Removing this means either that these scenarios are considered less important, or they (possibly in some cases) did not actually work well, or the implementation itself was lacking (e.g. the separation between cloud provider and core responsibilities was not clean enough) - and could be revisited in the future. @jonathan-innis, any insight on this?
In any case, lets remove it and revisit later, if needed, together with required core changes.

the karpenter provider removed the linking controller completely

I think if we want to talk about Karpenter re-owning existing nodes, we can start a design discussion about this or open an issue on kubernetes-sigs/karpenter to talk about the ramifications of doing this, but the stance up to this point has been to just ask users to deprovision old instances and let Karpenter launch new ones, rather than having to reason about the edge behavior that might happen if we tag and re-own an instance that was launched by a different system.


Voronoi game of life submission

Voronoi game of life showcase submission

Ah, whoops, I think this was already merged in #1622, can you confirm?

Hey, yes, the only difference is this one goes directly to a demo. If it is OK, I prefer this one. But it's OK anyway. Thank you.

Hey, yes, the only difference is this one goes directly to a demo. If it is OK, I prefer this one. But it's OK anyway. Thank you.

Ah, that makes sense! Since I already merged #1622, would you like to adjust this branch (or open a new pull request) that changes the link in the file that is now in main?

Hey, yes, the only difference is this one goes directly to a demo. If it is OK, I prefer this one. But it's OK anyway. Thank you.

Ah, that makes sense! Since I already merged #1622, would you like to adjust this branch (or open a new pull request) that changes the link in the file that is now in main?
Thanks, I will open a pull request that updates the link.

@okg21 Hope you don't mind, I opened a PR to close this issue. See #1665


fix: remove request.url usage in templates

request.url is a handy tool to reach for to get the current URL, but it depends heavily on the configuration of the application. This can return the incorrect URL or incorrect scheme when used behind a proxy, for instance.
Instead of going the route of implementing middleware or other config settings to correct it, this change takes advantage of default browser behavior. An empty URL used for href or action is automatically filled with the full URL from the browser's context. This also allows relative URLs from the current location, including URLs that require query params (these can include other Jinja variables so long as we use the urlencode filter for safety).

Thank you for the PR.
I think we should either have this or https://github.com/aminalaee/sqladmin/pull/557
which fix it in different ways.

#557 does seem like the right direction, actually. I'm seeing through the tests there are a lot other spots where this change wouldn't work out.


[How to change the CVRTW environment so that it can be trained and tested on the Solomon dataset]

Motivation
I used the python run.py experiment=routing/am-cvrptw env.num_loc=10 command to run the results under the default generated dataset, as follows:

I looked at you at rl4co/envs/routing
Regarding the specific implementation of the CVRTW environment in /cvrptw.py, I want to modify the code in it to train the cases in the Solomon dataset, so as to make a comparison with the experiments in other papers.
I tried to modify the solomon=true in the load_data, is the dataset generated at this time the solomon dataset or the dataset generated by default?

Because there is no intermediate process results and visualization means to generate the dataset, I don't know how to tell the difference.

Hi there, thanks for pointing this out, it is one of our priorities we would like to solve.
In the current version:
In the base RL4COLitModule here (the class controlling how training is done) you can see that the dataset is collected from the environment itself. This can be achieved by setting the train file to a file containing instances of the Solomon dataset, which will override the default data generation under the generate_data function.
We are in the process of making a separate DataGenerator function and we will prioritize this since we agree it is a very useful feature to have!
CC: @ngastzepeda
PS: Note that the training is done via batches for the VRPs (e.g. [512, 100] where batch_size is 512 and num_loc is 100) so if you want different instance size in the same batch you would need to do some padding.

Ok, thanks for the answer, looking forward to the version after rl4co. I have another question, I noticed that the setting in the CVRTW environment is max_loc=150, max_time=480, and does not scale to [0,1] random sampling node coordinates, and the paper mentions that RL4CO is consistent with the 2019 Kool et al. generated dataset.

I tried to set scale:bool=true and then the training result is as follows:

I would like to do more experiments with python run.py experiment=routing/am-cvrptw env.num_loc=20,30 to compare with other papers.

In Kool et al. 2019 they did not do CVRP-TW, so we are using custom settings.
We noticed that several papers have different ways to generate instances, and that can cause confusion (for this reason, we should standardize this soon!).
We recommend you to override the generate_data function in CVRP-TW such that the generated instances are similar to the papers you are comparing to for fairness of comparison. Feel free to suggest / contribute to RL4CO if you find better settings :)

Ok, thanks for the answer, I also downloaded some olomon dataset examples offline, but I don't know how. There are no good ideas on how to override the generate_data function in CVRTW, thank you again for your answer, and I'll take a look at the other papers.

How to override:
You can create your custom CustomCVRPTWEnv(CVRPTWEnv) and modify that generate_data method:
class CustomCVRPTWEnv(CVRPTWEnv):
  name = "cvrptw"
  [...]
  def generate_data(...):
     [your functions here!]

And then call that environment instead!

Okay, I'll give it a try

We made quite a few API changes. Now, you may pass a generator to the environments which may include data from the Solomon dataset!
For example:
from rl4co.envs.routing import CVRPTWEnv, CVRPTWGenerator

generator = CVRPTWGenerator(num_loc=50)
env = CVRPTWEnv()

You may create a new Generator class following this example


ARROW-7865: [R] Test builds on latest Linux versions

This adds a nightly job that tests on debian bullseye (11). We already test on Ubuntu bionic (what rocker/r-ubuntu provides)

@github-actions crossbow submit test-r-rocker-r-base-latest

Nightly build failure will be resolved by #6596. Merging.


v2: partially substitute hyper for reqwest and work around Satellite registry

Fixes #44
Partially fixes #89.
Closes #90.

@lucab comments addressed and tests fixed if the status goes green ;-)

@lucab
I can't reproduce the test freezes locally. Any idea what's different on Travis?

@steveeJ not really, but I'm fine with disabling them for now to get this PR through.


Long term stats' not available for garmin connect sensors sensors

Hi,
In trying to configure a Statistics Graph Card for the Garmin Connect sleep sensors, I discovered that it (along with the other Garmin Connect sensors) are not configured correctly for statistics tracking.  The documentation for the Statistics Graph Card includes a statement that points to what needs to be done ...

"If your sensor doesn’t work with statistics, check this."

The document at that link points to the solution in this developer document:

Long-term Statistics

@mrsnyds you can use the sensor for long time graphs now, let me know if this is still an issue.

Thanks for looking into this.  I can now see the sensors in the pick list if I scroll through it (see first attached), but just typing the beginning of the sensor entity name, like for the entity in the first picture, "sensor.ac..." should scroll right to the item as well, but it does not (see second attached).
Initially I thought the fix did not work, since I just tried to type the entity name and did not find it, but then I tried just looking through the list and I could find it.   So I can use the card now, but I'm wondering if you could find a fix for this second UI thing?

This is a Home Assistant thing, you search for sensor friendly name, not entities So type 'Ac..' for Active...


CC-BY-NC 4.0 License

Dear researchers hope you're well and thanks for your wonderful work on ConViT. I quite enjoyed reading the paper and wasn't aware that self-attention could also express a convolutional layer [1].
Would love to get this model as part of TIMM, but as you can see in the discussion here, Ross tells me we need to wait for an unrestrictive license.
Just wondering if that's something in the works? Is there some time in the near future that we're going to move towards an Apache license? Why do we have a non-commercial license here, please?

Dear Aman,
Thank you so much for you for your positive feedback.
The license has just been updated to Apache 2.0, so you should be good to go.
Best,
Stéphane


[ MB-9033 ] Update footer to match updates in USWDS 2.13.0

Jira ticket for this change
Summary
In this PR, it's outlined what the changes were for the social images in
the footer. Read more here: https://github.com/uswds/uswds/pull/4430
Setup to Run Your Code

💻 You will need to use two separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 2
Start the Go server locally.
make server_run

Additional steps

Access the Customer app
Look at the footer
Ensure there are social icons for Twitter and Facebook in the footer

📸  Screenshot(s)

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-9033

  Generated by :no_entry_sign: dangerJS against 9de9c16ec58f899e3bfa873af412fd8920f1288b


Unexplained, sudden failure in the github workflows

Out of nowhere, errors have started appearing with the github workflows. This seems to be related to some kind of combination of Python and Numpy version. I am still iterating to find a solution

The solution was to switch Python version to github's latest python-versions (3.8.15) at this time


dropDown.show() doesnt show any dropdown

Hello
I have an app with multiscreen structure. i am using dropdown on both screens. it works in first screen perfectly but not working in second screen. also when i try to capture tuple returned on .show() method it returns nil for second screen but returns perfect tuple in first screen...what can be the issue in this case?

same problem. any update?

check if your data source is loaded with proper data. In my case i somehow missed loading the data in datasource array.

I have the same issue. Data source is set in viewDidLoad() and is not changing in runtime.

I found the cause of the issue in my side. In project was used UIView extension:
extension UIView {
    func show() {
        if isHidden {


Option to disable escaping

I want show hightligted results.
In this case backend send html.
But you auto escape html and it not work as i want.
How i can show html in anchor and label ?

Hi @errogaht
Thanks for giving me an issue. Now you can shape the child as you want. Check it out~
https://github.com/BosNaufal/vue2-autocomplete#onshouldrenderchild-function
Commit > https://github.com/BosNaufal/vue2-autocomplete/commit/de5f87d11969acf118893cbee043767b9a8d1a0b


SQL Agent Extension actually still in preview?

This page still marks the agent as being in preview.... I don't believe that's the case anymore (but I can't quote an authoritative source)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbdd7165-e41d-4643-67b8-04a1fa83a21d
Version Independent ID: 82da58fe-125e-1870-1935-34f5a8b536f4
Content: SQL Server Agent extension - Azure Data Studio
Content Source: docs/azure-data-studio/sql-server-agent-extension.md
Product: sql
Technology: azure-data-studio
GitHub Login: @yualan
Microsoft Alias: alayu

@CHDAFNI-MSFT -- Chase, thank you for your feedback.
@yualan -- Alan, please look into this issue #4183.
cc @MightyPen as a writer

@CHDAFNI-MSFT Hello, this feature is still in preview.    Don't feel bad, I would have guess it was no longer in preview too!
Closing this Issue #4183 now.
cc: @yualan @WilliamAntonRohm


Add a way to customize header filing for ClientHeaderParam

relates to https://github.com/quarkusio/quarkus/issues/10249

The failing job's error seems to be:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on project resteasy-integration-tests-spring-unit: Unable to generate classpath: org.apache.maven.artifact.resolver.ArtifactResolutionException: Unable to get dependency information for org.apache.maven.surefire:surefire-junit47:jar:2.22.0: Failed to retrieve POM for org.apache.maven.surefire:surefire-junit47:jar:2.22.0: Failure to transfer org.apache.maven.surefire:surefire-junit47:pom:2.22.0 from https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced. Original error: Could not transfer artifact org.apache.maven.surefire:surefire-junit47:pom:2.22.0 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit47/2.22.0/surefire-junit47-2.22.0.pom

I will do some small change to retrigger the checks

@rsearls @ronsigal any chance you could take a look at it soon?
Are there any releases planned in the near future that this could go in?

@michalszynkiewicz , we'll be reviewing this soon, sorry for the delay. Would you mind creating a jira at https://issues.redhat.com/projects/RESTEASY . As for the release this could go in, I'd say 4.6.0.Final, which I'd like yo see before the end of the summer.

@asoldano I created an issue, please let me know if the description is too cryptic

Thanks @michalszynkiewicz . As a preliminary review, I'm wondering if you could add some testing coverage. Moreover, is the addition worth any mention in the resteasy userguide?

@asoldano @rsearls I'll add some tests. Do you think I could pull out another module from the mp rest client module, sth like mp rest client base, that would not contain the default implementation? The default impl causes warnings in newer java versions.

I added a test. I also pulled out most of MP Rest Client to a separate module, so that vendors don't have to have the default header filling classes on the classpath if they want to provide a different impl.
I didn't update the docs though. From what I see, they are rather user focused. This modification is meant to be used by vendors

The one job that failed, failed with
Could not transfer artifact org.apache.maven.surefire:surefire-junit47:pom:2.22.0 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit47/2.22.0/surefire-junit47-2.22.0.pom

@michalszynkiewicz , I've resolved the conflicts and merged this on master, see https://github.com/resteasy/Resteasy/commit/c4a1715c8b389d5ec202a35f47370053c4dc27c1
Thanks

Why is this PR not merged?

@yuhaibohotmail I checked 4.5.8 too and it's not there.
@asoldano should I create a pull request targetting 4.5 for it?


Added CodeClimate badge

Hey @mauro-oto @schmierkov,
This PR adds the Codeclimate badge to the repo.
Please check it out.
Thanks!

Awesome! Thanks :+1:


Future: make sure we support eic field

Right now we don't support an eic field as we haven't been collecting it. However i think it's important to recognize all of the work a EiC does (even on presubmissions). As such once we update the templates (this will be over time) we should also make sure our model supports an eic field. that field will be a list of people potentially similar to the maintainer field.

this was implemented via #174 closing


Fix list-all-secrets command

Addresses #14

Awesome! With a test and everything! I'd say +1, but I think +1e6 is more appropriate. Amazing work, thanks so much!


Quick SEO fix - account-abstraction landing page

📝 Changed routes:

/account-abstraction

(view full size)

Commit 1d818fa107eb0147a8b03b377d86ff811825f33e (https://thirdweb-jby4r4e5x.thirdweb-preview.com).