DraggableScrollableSheet from showModalBottomSheet snaps to unspecified extent

Steps to Reproduce

Paste the code from the sample below under MaterialApp's home property
Run the app and press the bugs button
A draggable scrollable sheet will appear.

Actual results:
Sometimes, when you want to dismiss the bottom scrollable sheet by dragging, it will stick to the bottom instead of disappearing, even though there are only 2 snap sizes specified (0.8 and 1.0):
https://user-images.githubusercontent.com/54116985/205342166-894b8341-3f44-4620-8990-3ba1ed2a7df2.mov
Expected results:
Proper dismiss behavior should be implemented.

Code sample
import 'package:flutter/material.dart';

class TestScreen extends StatelessWidget {
  const TestScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showModalBottomSheet(
              enableDrag: true,
              useSafeArea: true,
              clipBehavior: Clip.hardEdge,
              shape: const RoundedRectangleBorder(
                borderRadius: BorderRadius.only(
                  topLeft: Radius.circular(20),
                  topRight: Radius.circular(20),
                ),
              ),
              context: context,
              isScrollControlled: true,
              builder: (context) {
                return DraggableScrollableSheet(
                  expand: false,
                  initialChildSize: 0.8,
                  snap: true,
                  snapSizes: const [0.8, 1.0],
                  builder: (context, scrollController) {
                    return CustomScrollView(
                      controller: scrollController,
                      physics: const ClampingScrollPhysics(),
                      slivers: [
                        SliverPersistentHeader(
                          delegate: TestSliverAppBar(),
                          pinned: true,
                        ),
                        SliverList(
                          delegate: SliverChildBuilderDelegate(
                            (_, index) => ListTile(
                              title: Text("Index: $index"),
                            ),
                            childCount: 50,
                          ),
                        )
                      ],
                    );
                  },
                );
              },
            );
          },
          child: const Text(
            'bugs',
          ),
        ),
      ),
    );
  }
}

class TestSliverAppBar extends SliverPersistentHeaderDelegate {
  @override
  Widget build(
      BuildContext context, double shrinkOffset, bool overlapsContent) {
    return Container(
      color: Colors.pink,
    );
  }

  @override
  double get maxExtent => 100;

  @override
  double get minExtent => 50;

  @override
  bool shouldRebuild(covariant SliverPersistentHeaderDelegate oldDelegate) =>
      true;
}

Logs
[!] Flutter (Channel master, 3.6.0-14.0.pre.2, on macOS 12.6 21G115 darwin-arm64, locale ru-RU)
    • Flutter version 3.6.0-14.0.pre.2 on channel master at /Users/gidrokolbaska/Developer/flutter
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/2.16.0/libexec/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/gidrokolbaska/Developer/flutter. Consider adding
      /Users/gidrokolbaska/Developer/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7572ce907f (35 hours ago), 2022-12-01 01:07:29 -0500
    • Engine revision 51356bf895
    • Dart version 2.19.0 (build 2.19.0-444.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to
      perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/gidrokolbaska/Library/Android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (3 available)
    • iPhone 12 (mobile) • 070B14C3-C297-4A54-A136-A502B61105DF • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)    • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 108.0.5359.71

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Hello, @Piinks! This is the 2nd part of the issue #116427

It looks like this is unexpected behavior based on the provided snapSizes. I wonder if the Scaffold bottom sheet dismissal handling is interfering with the draggable scrollable sheet's gestures.

It looks like this is unexpected behavior based on the provided snapSizes. I wonder if the Scaffold bottom sheet dismissal handling is interfering with the draggable scrollable sheet's gestures.

yes, that's what I thought as well, but it's was still worth creating an issue for that because it might be that I'm just using DraggableScrollableSheet in conjunction with showModalBottomSheet incorrectly

Any progress here? this prevents us from calling DraggableScrolllableSheet via showModalBottomSheet...

As a partial diagnosis: I think the point where it sticks at is the minChildSize. By default that's 0.25, which is what we see in the repro video.
(I haven't looked closer to understand how that causes this behavior.)

The minChildSize and maxChildSize are implicitly included in snap sizes even if you do not specify explicitly, that's why there is snap at minChildSize. However the real issue is when you fling it to close, it briefly stops at minChildSize before closing which gives a bad UX, @xu-baolin might have a clue

I've written a dirty workaround to have it look good on the UI side of things. Hope that helps
https://github.com/flutter/flutter/issues/36283#issuecomment-1573062032


Extra joins in the schema for apostrophe-pieces-widgets should work without extra code

The current implementation does not call schemas.join at all. Instead, it should call schemas.join with a subset of the schema that excludes _pieces.

cc @grdunn

I just came across this as a problem as well while trying to set a link to the piece's index page even if there aren't pieces to display (no upcoming events in apos-events-widgets in this case).

This was fixed in 2.61.0.


Fixing Miscellaneous Structure and Policy Issues

This PR fixes #140 , #288 , #297 .

Update the version for InteropCC and fabric-node-sdk.


AUR package

I found an AUR package, and added that to https://numbat.dev/doc/cli-installation.html#installation
Also added installation instructions to the README.

@archisman-panigrahi thanks for this PR
@joajfreitas Thank you for creating a package! Would it be possible to package this under the name "numbat", not under "numbat-bin"? This project is divided into multiple crates and "numbat" is the basic library while "numbat-bin" provides the binary. However, note that the binary is called numbat. And the Arch packaging guidelines suggest:

When packaging Rust projects, the package name should almost always be the same as the name of the generated binary.

(https://wiki.archlinux.org/title/Rust_package_guidelines)

Would it be possible to package this under the name "numbat", not under "numbat-bin"?

As per AUR convention, PKGBUILDs which unpack a compiled binary (e.g. from GitHub releases), are named package-bin, and PKGBUILDs which download the source corresponding to a particular release and compile from it are named package (and PKGBUILDs which download the latest git code (not the latest released version) and compile it are called package-git.
This particular AUR just downloads the released binary from https://github.com/sharkdp/numbat/releases/tag/v1.6.1 and unpacks it. So the name numbat-bin is appropriate. However, anyone can still create another AUR package that will download the source and compile it, and it can be called numbat.

As @archisman-panigrahi mentioned, typically AUR packages that download and install a binary are suffixed with -bin.

Packages that use prebuilt deliverables, when the sources are available, must use the -bin suffix. An exception to this is with Java. The AUR should not contain the binary tarball created by makepkg, nor should it contain the filelist.

From: https://wiki.archlinux.org/title/AUR_submission_guidelines#Rules_of_submission
I will gladly create a numbat package that builds the numbat crate and installs the resulting binaries.

Done: https://aur.archlinux.org/packages/numbat

As per AUR convention, PKGBUILDs which unpack a compiled binary (e.g. from GitHub releases), are named package-bin, and PKGBUILDs which download the source corresponding to a particular release and compile from it are named package (also, PKGBUILDs which download the latest git code (not the latest released version) and compile it are called package-git).

Oh, of course! Sorry, I was completely confused. I mixed up numbat-bin and numbat-cli..

Done: https://aur.archlinux.org/packages/numbat

Thank you very much!

I added the new AUR package to the docs. However, since the numbat AUR requires downloading rust and several dependencies (hundreds of megabytes) to compile the crate (also it takes a while to compile), I still suggested x86_64 users to use the numbat-bin AUR.

I am done. Feel free to suggest changes/merge.


Offline Interactive development environment

Something similar to code academy that can be integrated to the swag system. Should be usable offline and synchronized to the online swag system whenever possible. It should be able to produce xAPI statements as well.

This issue was moved to tunapanda/wp-swag#5


Use serde_bytes for meta_struct

Otherwise meta_struct will be serialized as an array of integers instead of a byte string, breaking the expected representation.
Appsec is trying to use it, but breaking when using the sidecar trace sender.

Codecov Report
Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (d351d66) to head (3ae1507).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   70.58%   70.58%
=======================================
  Files         206      206
  Lines       28129    28129
=======================================
  Hits        19856    19856
  Misses       8273     8273

Components
Coverage Δ

crashtracker
16.52% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
50.00% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
86.43% <ø> (ø)

ddcommon-ffi
75.29% <ø> (ø)

ddtelemetry
58.95% <ø> (ø)

ipc
84.13% <ø> (ø)

profiling
78.78% <ø> (ø)

profiling-ffi
58.64% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
35.42% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
71.14% <ø> (ø)

trace-normalization
98.24% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
69.83% <0.00%> (-7.33%)
:arrow_down:

trace-utils
91.63% <ø> (+0.59%)
:arrow_up:


Create a github actions workflow that builds and pushes to a public oci registry

Fixed in : https://github.com/Guidewire/fern-reporter/pull/7/


I used it to pull items with unavailability by icmp ping, I hope I helped

select
h.name
, i.location_lat as latitude
, i.location_lon as longitude
, t.value
FROM
host_inventory i
inner join hosts h on i.hostid=h.hostid
inner join items it on it.hostid = i.hostid
inner join functions f on f.itemid = it.itemid
inner join triggers t on t.triggerid = f.triggerid

where  i.location_lon!=''
and it.itemid in (select  max(ite.itemid) from items ite
                   where ite.itemid = it.itemid)
group by
h.name
, h.available
, i.location_lat
, i.location_lon
, i.site_country

Great job!


Impeller not applying shadow color to emojis

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Run the provided example on stable / master channel with impeller enabled then run it with --no-enable-impeller to reproduce the difference.
Reproducible on iOS and MacOS as well.
Expected results
The emoji shadow and the text shadow are both fully blue.
Actual results
The emoji shadow is not blue while the text shadow is blue.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MaterialApp(
    home: Scaffold(
      body: Center(
        child: Text(
          '🫶 ABC',
          style: TextStyle(
            fontSize: 75,
            shadows: [
              Shadow(
                color: Colors.blue,
                offset: Offset(-42, -42),
                blurRadius: 5,
              ),
            ],
          ),
        ),
      ),
    ),
  ));
}

Screenshots or Video

Screenshots / Video demonstration

SKIA
IMPELLER

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.16.0, on macOS 14.1.1 23B2082 darwin-arm64, locale en-US)

[✓] Flutter (Channel master, 3.17.0-12.0.pre.40, on macOS 14.1.1 23B2082 darwin-arm64, locale en-US)

Master channel hash : 2a8eedf084359ed49e041d0dfd180d15dda3a1b1

Reproducible using the code sample provided above.
Tested on macOS, android, iOS,  and it reproduced on all platforms with impeller.

SKIA
IMPELLER

flutter doctor -v
[✓] Flutter (Channel stable, 3.16.0, on macOS 14.1.1 23B81 darwin-arm64, locale en-GB)
    • Flutter version 3.16.0 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db7ef5bf9f (7 days ago), 2023-11-15 11:25:44 -0800
    • Engine revision 74d16627b9
    • Dart version 3.2.0
    • DevTools version 2.28.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0-rc1
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode-15.0.0-Release.Candidate.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 76.3.4
    • Dart plugin version 232.10072.19

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (4 available)
    • Pixel 7 (mobile) • 28291FDH2001SA            • android-arm64  • Android 14 (API 34)
    • Nexus (mobile)   • 00008020-001875E83A38002E • ios            • iOS 17.1.1 21B91
    • macOS (desktop)  • macos                     • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
    • Chrome (web)     • chrome                    • web-javascript • Google Chrome 119.0.6045.159
    ! Error: Browsing on the local area network for Dean’s iPad. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.17.0-13.0.pre, on macOS 14.1.1 23B81 darwin-arm64, locale en-GB)
    • Flutter version 3.17.0-13.0.pre on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b6ef78e955 (29 hours ago), 2023-11-20 23:37:25 -0500
    • Engine revision 70b1c73412
    • Dart version 3.3.0 (build 3.3.0-152.0.dev)
    • DevTools version 2.30.0-dev.4
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0-rc1
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode-15.0.0-Release.Candidate.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 76.3.4
    • Dart plugin version 232.10072.19

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (4 available)
    • Pixel 7 (mobile) • 28291FDH2001SA            • android-arm64  • Android 14 (API 34)
    • Nexus (mobile)   • 00008020-001875E83A38002E • ios            • iOS 17.1.1 21B91
    • macOS (desktop)  • macos                     • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
    • Chrome (web)     • chrome                    • web-javascript • Google Chrome 119.0.6045.159
    ! Error: Browsing on the local area network for Dean’s iPad. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

This mght be an easy fix if we're dropping the color on the ground.


electrum

how to use electrum using that liabrary is not clear.how to run this laibrary.Descrie usage of that liabrary anyone for electrum

I take it you've looked at the examples named electrum...? It would help if you explained what you were trying to do first of all!


sqlcipher command line decryption failed

I use sqlite-jdbc to encrypt a database,then I use sqlcipher which I compile to decrytion the database.But failed,please help me,thank you very much.

this is my code:
public static void createTable(){
try {
con=getCon();
Statement stat=con.createStatement();
stat.execute("pragma key='key'");
int b = stat.executeUpdate("create table tbl_smu_alarm_event(" +
"id integer primary key autoincrement," +
"alarm_in_code character varying(32) not null," +
"alarm_type character varying(32) not null," +
"alarm_extparam character varying(2048)," +
"alarm_desc character varying(256)," +
"alarm_occur_time timestamp," +
"alarm_end_time character varying(20)," +
"alarm_reported_time character varying(20)," +
"alarm_associateid integer," +
"alarm_occur_number integer," +
"alarm_status smallint not null," +
"identify_id character varying(32) not null," +
"operator integer," +
"operator_login_name character varying(20)," +
"operator_domain_code character varying(32)," +
"operate_time character varying(20)," +
"operate_info character varying(256)," +
"operate_complex character varying(64)," +
"source        numeric(1) default 0 not null," +
"alarm_level_id numeric(1)," +
"is_red_alarm  numeric(1)," +
"file_id    character varying(128)," +
"file_ex_id     character varying(128)," +
"suspect_task_id    BIGINT," +
"intelli_task_id    BIGINT," +
"alarm_match  numeric(1)" +
");");

The issue is a bit unclear. Can you clarify ?

I used the jdbc to encrypt a database test.db,then I use sqlcipher client to decrytion  test.db(pragma key='key'),but it throws file is not a database.
This is my encrypt  code
public static void createTable(){
try {
con=getCon();
Statement stat=con.createStatement();
stat.execute("pragma key='key'");
int b = stat.executeUpdate("create table tbl_smu_alarm_event(" +
"id integer primary key autoincrement," +
"alarm_in_code character varying(32) not null"
");");

You should have a look at the specific parameters that are applied by default on both sides (in the jdbc connector and in the sqlcipher client)
The page that gives all available parameters for the jdbc connector is here https://github.com/Willena/sqlite-jdbc-crypt#aes-256-bit-cbc---sha1sha256sha512-hmac-sqlcipher
You will need to change the java code to add the different parameters, if everything is the same on both side then both tool will be able to open the file.

Closing issue due to inactivity. Feel free to reopen if necessary.


Add ZeroTier One 1.0.3

Fulfilling #11249, a request for a cask for ZeroTier One.

Could you explain the commented code?

Yes, I can: lazy committing after I yanked code from 'gpgtools' and neglected to commit the removal of those comments. Very sorry. I've removed it and pushed.

There’s some trailing whitespace that needs to be removed.

Added newline at the end of the file and remove spurious whitespace.

You added an empty line, instead of the required newline. It was fine as it was.

Sorry. I promise I'm taking notes.

Nothing to apologise for. Your turnaround time for fixes is great. Just notices something else, though, apologies.
Seeing as url doesn’t point to a specific version, this cask should use version :latest and sha256 :no_check. See an example.

Just want to be useful. I really love the work everyone's done with caskroom and want to give back.
Adjustments made and pushed.

Looking great. Thank you.


[spirv] Add initial I64 emulation pass

The pass is conditionally enabled when the SPIR-V target does not declare I64 capabilities. The `demote-i64-to-i32' needs to be disabled for Wide Integer Emulation (WIE) to have any i64 ops to emulate. These default will be changed once the WIE implementation is robust enough.
Locally, I tested this by changing the demote-i64-to-i32 default to false and all tests passed.
This PR relies on an llvm-project branch with some cherry-picked changes.

Another thing is that cherry-picking upstream commits should happen in its own pull request (so it's easier for integration folks to know and easier to revert if there are issues)

Not hard requirement though. And there are cases we need to fix iree to make it compile/pass. So use your judgement. :)

Thanks for the feedback, @antiagainst! Addressed comments and added new LIT test. PTAL.

Another thing is that cherry-picking upstream commits should happen in its own pull request (so it's easier for integration folks to know and easier to revert if there are issues)

Not hard requirement though. And there are cases we need to fix iree to make it compile/pass. So use your judgement. :)

I was hoping these cherry-picked commits will propagate to the submodule by the time this PR is ready to land. If the next integrate does not pick them, I'll follow your suggestion.

Ping


Make release

script to generate release of pREST

Current coverage is 87.67% (diff: 100%)

Merging #92 into master will not change coverage

@@             master        #92   diff @@
==========================================
  Files             8          8
  Lines           803        803
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            704        704
  Misses           66         66
  Partials         33         33

Powered by Codecov. Last update 5bd9377...f3a8fda


Issue 2644: Tasks can be run several times under certain conditions (WIP)

Description
Wrote an additional check in worker.py after all dependencies of the task were validated,
this should prevent the situation when the real status of the task was changed to DONE,
but the worker sends PENDING to the scheduler.
Motivation and Context
There may be a situation when a worker has stale state of a task and this leads to duplicate runs.

For the specific example see the corresponding issue: https://github.com/spotify/luigi/issues/2644
Have you tested this? If so, how?
There is a test provided in the PR, it fails with the current implementation and PR resolves it.

@Tarrasch thank you very much for starting reviewing this PR! :+1:
I attached a picture describing the problem that I'm facing: if worker A finishes the task right before worker B sends tasks status, we have duplicate runs. Please take a look and let me know if it's clear.
I have a working case described in the issue: https://github.com/spotify/luigi/issues/2644, if you need any other details please let me know. I suspect these guys faced the same problem: https://groups.google.com/forum/#!topic/luigi-user/YCEQIEz0jLo
After discovering this issue I think it has somewhat deeper roots. This PR will resolve most of the problem cases, but the race condition will still exist, even with the only one task:

worker A runs some task
worker B starts the same task and checks it's output does not exist
worker A finishes task right after that
workers A and B send status to the scheduler, worker A appears to be the first one - status DONE
then worker B - status PENDING
worker B asks for more work - runs the task for the second time

I think to completely resolve this issue there must be something like "timestamp of status check" to be sent to scheduler along with the status itself. And scheduler should resolve what to do if the status timestamp is older than the one it has in it's state. Just my thoughts.

@Tarrasch, can you please take a look at the changes I submitted? This is just the draft of an idea how this issue can be resolved with the help of distrust period.
At the moment, I don't see any way to "rerun" the check of the task status without rewriting a big part of the basic logic regarding the interaction between workers and the scheduler. So I chose to keep the task that was DONE very recently in the same state.
E. g., let's take a look at the code that sends the task metadata to the scheduler:
https://github.com/spotify/luigi/blob/3701c68d7f31c543f6f871ed141a7ba170fd9e8c/luigi/worker.py#L561-L583
If I'm not wrong, it does not assume anything wrong may happen during self._scheduler.add_task, it even writes the record to the task history earlier than add_task itself was called. The interaction happens only from a worker to the scheduler at this point, not vice verca. So we cannot ask the worker here "wait, then retry sending the same task with the updated status again" here without significant code changes.
In the other hand, once we send the task in PENDING state, the scheduler treats is as the one that can be given to the worker unless we change the task's status on-the-fly. Maybe we could rerun check when a worker asks for work, but then we'll have to detect which of the tasks need this "status recheck" and which don't need it.
Actually, I'm not a big fan of the approach selected, but the main goal for me was to reduce the impact of these changes.
Please let me know if you have any thoughts regarding this!

@Tarrasch @honnix @dlstadther psst, guys, probably you forgot about this one

@Tarrasch thank you for the thorough review again!
I've rebased + followed your recommendations to improve the readability of the tests.
Please let me know if we need any other changes here.

many thanks @GoodDok et al for this work, I'm afraid that I'm also having this issue :P Hope it gets merged soon!

Hi there, @Tarrasch @honnix @dlstadther,
Just wanted to let you know that I'm still here once you are ready to review my final changes.
Seems like I'm not the only one who has faced this issue.

It looks like @Tarrasch already approved the changes. I'll give him a little to re-confirm, otherwise i'll merge

My approval still stands. Sorry for being away for so long and not merging your rebase. I or any another maintainer may merge this once you rebase. Sorry!

@dlstadther @Tarrasch guys, I've rebased the branch, please feel free to merge :)


MIG blogs + scenario links

[Enter feedback here]
Could we expand how we are pointing to the relevant blog posts (esp. with newer features like multi-stage disposition)? and the scenario based demos?
https://techcommunity.microsoft.com/t5/security-compliance-and-identity/bg-p/MicrosoftSecurityandCompliance/label-name/Microsoft Information Governance
https://techcommunity.microsoft.com/t5/security-compliance-and-identity/bg-p/MicrosoftSecurityandCompliance/label-name/Microsoft Information Governance
Document Details
⚠ *Do not edit this section. It is required for tracking
Page Path: https://microsoft.github.io/ComplianceCxE/resources/mig/

@nanoonan538 I don't understand the request/question - can you clarify

Closing no response


Fetching _User directly if I have the session from client

Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

[x] You've met the prerequisites.

[x] You're running the latest version of Parse Server.

[x] You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Environment Setup
Steps to reproduce
I used to call Parse Server to fetch the user object from the server via:
api.parse.com/1/users/me and passing sessionToken from client.
If I have the parse-server inside my own server and I want to use the call directly now. How do I go about doing this?
Logs/Trace

I am using my own session


CEv1+remove juicy-composition

Migrate to CE v1, Remove juicy-composition wrapper from light DOM
https://github.com/Starcounter/starcounter-include/issues/39
https://github.com/Starcounter/starcounter-include/issues/42
Drop feature to automatically create slot elements and slot attributes.
https://github.com/Starcounter/RebelsLounge/issues/107
https://github.com/Starcounter/starcounter-include/issues/32
Add default slot if there is no composition, for specific ones it should come from server (merged html)
https://github.com/Juicy/juicy-composition/issues/4
related
https://github.com/Starcounter/RebelsLounge/issues/106
https://github.com/Starcounter/starcounter-include/issues/26
https://github.com/Starcounter/RebelsLounge/issues/78

:warning: this is a breaking change!: selectors like starcounter-include>juicy-composition>* needs to be updated to starcounter-include>*

I'd put it on SysUpgrade to test carefully.

This is needed to make migration to V1 easier.

Can we add a warning for explicit slot="..." attributes that do not have a matching <slot name="..."> element?

Something like:
var out = "\n";
document.querySelectorAll("[slot]").forEach((elem)=>{
    var name =elem.getAttribute("slot");
    var matching = elem.parentNode.shadowRoot.querySelector("slot[name='"+name+"']")
    if (!matching) {
        out += `        <slot name="${name}"></slot>\n`;
    }
});
console.warn("Seems that you forgot the following slot elements in your declarative-shadow-dom", out);

Can we add a warning for explicit slot="..." attributes that do not have a matching <slot name="..."> element?

I would not do so for the same reason we removed the feature of automatic creation of those. It's expensive to do it in runtime (with Polymer's dom-bind it's always async mutation)

Also I imagine plenty of use cases, when that's desired not to have <slot> for matched element.

The above snippet saved me hours of work, so I would like it to be available for everyone. If not in starcounter-include then in starcounter-debug-aid perhaps?

:+1: for new tab in s-d-a

I don't mean a tab, I mean something that pukes with warnings in Chrome Dev tools :P

but when?
s-d-a is loaded only when needed

We will test it more extensively as a PR to Starcounter, now I'd like to release a new version

Found one problem: In Firefox and Chrome, the results list on the PaginationPage is not rendered. Tested with the branch add-declarative-shadow-dom

There isn't any commit in that branch after the moment your message was sent and I can't reproduce the problem (works ok in both Chrome and Firefox).

For reference, I use this helper to upgrade an existing app:
setInterval(function() {
    var out = "\n";
    document.querySelectorAll("[slot]").forEach((elem) => {
        if (elem.skip) return;
        var name = elem.getAttribute("slot");
        if (!elem.parentNode.shadowRoot) {
            console.warn("This element's parent does not have a Shadow Root, so why setting a slot on it?", elem);
            elem.skip = true;
            return;
        }
        var matching = elem.parentNode.shadowRoot.querySelector(`slot[name='${name}']`);
        if (!matching) {
            out += `        <slot name="${name}"></slot>\n`;
            elem.skip = true;
        }
    });
    if (out.length > 2) {
        console.warn("Seems that you forgot the following slot elements in your declarative-shadow-dom", out);
    }
}, 500);

This is nice. I tested it and I it doesn't seem that, at least on Chrome, matching will ever by falsy.

Regarding the above script, strange that it didn't work for you. For me it produced all the <slot>s used in https://github.com/StarcounterApps/KitchenSink/pull/158, to it was definitely working to some extent.

There isn't any commit in that branch after the moment your message was sent and I can't reproduce the problem (works ok in both Chrome and Firefox).

It is still reproducible. I have made an issue: https://github.com/Starcounter/starcounter-include/issues/49

Regarding the above script, strange that it didn't work for you. For me it produced all the s used in StarcounterApps/KitchenSink#158, to it was definitely working to some extent.

That worked for me too.
I was talking about matching variable.
Did you had a case in which it got to console.warn("Seems that you forgot the following slot elements in your declarative-shadow-dom", out); ?

I tested it and it doesn't seem that, at least on Chrome, matching will ever by falsy.
Here is an example: StarcounterApps/KitchenSink@0faf5bf .
Sorry for missing this when I made the review.


[staging-20.09] perlPackages: bulk update

https://github.com/NixOS/nixpkgs/pull/97098 rebased to staging-20.09

LGTM
@NixOS/nixos-release-managers ok to merge into staging-20.09?

my only concern is causing regressions in packages that have already been stabilized. One of the points of ZHF is to gradually stabilize the package set.
That being said, if you did want to fix any regressions that exist on the staging-20.09 branch, then I'm fine with merging this.

my only concern is causing regressions in packages that have already been stabilized. One of the points of ZHF is to gradually stabilize the package set.
That being said, if you did want to fix any regressions that exist on the staging-20.09 branch, then I'm fine with merging this.

Sorry for the late response: This PR does fix issues with Appperlbrew, AppSqitch, LaTeXML introduced with perl-5.32.0, but is mainly version bumps and cleanups.
I'm happy to work on fixing any regressions that pop up if you're comfortable merging, or we can backports fixes for broken packages to 20.09 leaving out the version updates.

@stigtsp @volth Please check hydra on nixpkgs/staging-20.09 for regressions.


Mouse cursor grabbing

I just started experimenting with mouse cursor grabbing in Glutin (X11 only so far). I would like to implement this feature (eventually for FPS-like camera controls), but I am unsure about how low-level/high-level it should be.
There are essentially two components:

Grabbing the input events from the cursor and confining its motion to the current window. (This is fairly straightforward.)
Resetting the cursor's position to the center of the window, whenever it moves.

Now, one could either fully integrate the above functionality into Glutin and maybe generate some events about the relative mouse motion, since the absolute position is not useful any more. (This is what Piston does, apparently.)
It is also possible to only expose the low-level functionality (setting the cursor position, input grabbing) in the API and leave it up to user code to implement this.
Oh, and one should also think about how that integrates with Glium, since 3D graphics is the most common application of this.
Implementation
Mouse grabbing:

[x] X11: #227
[x] Win32: Mouse Capture
[ ] OS/X

Set mouse cursor position:

…

I'm in favor of providing set_mouse_position and letting the user write set_mouse_position(window.get_position() + window.get_outer_size() / 2). Glutin is low-level and shouldn't be aware of concepts like "FPS camera".

Oh, and one should also think about how that integrates with Glium, since 3D graphics is the most common application of this.

I don't want glium to influence the design choices of glutin. Glium should adapt to glutin, not the contrary.

I urgently need some way to either get raw mouse deltas (there's an API for this on Windows) or, failing that, control the cursor (and hide it).

Mouse grabbing on OSX seems to require Core Graphics via CGAssociateMouseAndMouseCursorPosition (used by both SDL2  and GLFW) but rust-core-graphics doesn't seem to implement it yet.

I urgently need some way to either get raw mouse deltas (there's an API for this on Windows) or, failing that, control the cursor (and hide it).

Sorry for necroposting but if anyone else is trying to do it you need to use device events instead of window events!
like this:
    *control_flow = ControlFlow::Poll;
        match event {
            // ...
            // NEW!
            Event::DeviceEvent {
                event: DeviceEvent::MouseMotion{ delta, },
                .. // We're not using device_id currently
            } => if state.mouse_pressed {
                state.camera_controller.process_mouse(delta.0, delta.1)
            }
            ```


Framework for version differences as the expansion draws near

With the advent of the Factorio DLC expansion coming out later next year, there is highly likely to be a difference in blueprint string format for Factorio version 2.0, as well as for versions of the game with and without the expansion. Just based on the current few FFFs that they've released, a number of obvious changes from Factorio 1.x are already present:

New entities, items, recipes of all types
Quality items: how will blueprints request a legendary assembler? Will there be quality ranges for entities in blueprint strings?
Big electric pole range increased from 30 to 32
Blueprint ghosts can now be put on ghost tiles, presumably also including ghost concrete and similar
A rework of wire connections (perhaps in blueprint string format as well) and an increase in the number of power pole connections (at least 8, perhaps more or perhaps even configurable dependent on entity)
Red and Green circuit wires becoming abstract items instead of traditional recipes
Equipment ghosts (for spidertrons, and perhaps more)
New keys and parameters for rocket silos, likely with blueprint string counterparts

This exposes a more overall problem with Draftsman, in which Draftsman is only really designed to create/validate the latest version of Factorio's blueprint string... but this becomes difficult to maintain when there are now 2 latest versions. This issues a number of questions: how should Draftsman handle a blueprint string from with the expansion contents when loading in a configuration that doesn't have the expansion, and vice-versa? How even is Factorio itself going to remedy these distinctions between game versions? Is the  factorio-data git repo going to handle having two similar but distinct versions of the game?
Ideally Draftsman should implement a versioning system that could create and validate valid blueprint strings for the detected Factorio version and configuration. Presumably, this also means that the user might want to be able to manually specify a version of Factorio to create blueprint strings for, which currently would require modifying the factorio-data submodule included with the module in order to probably work. Currently, this is only circumstantially possible (and not easily or straightforward to boot), and only true for versions of Factorio greater than 1.0; previous versions are not supported.
Doing this would not only allow for the expansion to be accepted seamlessly when it releases, but also opens up the possibility to read old blueprint strings from older versions of Factorio. This would probably be less prioritized than the expansion, but these could be worked on as desired as PRs from interested parties, provided a straightforward solution is already in place.

In addition:

Circuit controlled assemblers (dear lord)

Enable disable + condition
Set recipe
Read ingredients
Read recipe finished + control signal(?)
Read working + control signal(?)

Flipping assembling machines of all types (dear lord)
Parameterized blueprints (bruh)
Train interrupts being part of schedules now
Train option "use destination train stop color"
RGB lamp color options
Removal of filter inserter and having filters be intrinsic to all Inserters
Swapping of nomenclature between Stack inserters and Bulk inserters

I have only used Draftsman to create vanilla game blueprints, but I would like the ability to create ones specific to the expansion pack, in addition to targeting the new base game.
So as a consumer of Draftsman, I think the most Draftsman-like & Pythonic way of handling game data would be:

default to the latest base game version
allow the user to specifically switch to any mod or expansion pack
only validate blueprints based on the user-given version(s): in other words, when importing a v1 blueprint into a v2 process, only validate with v2 rules (presumably on usage or export of the blueprint).

Having the usage of Draftsman require something like a set_engine_version() call on instantiation to tell Draftsman what game & mod data to load, and throwing an error if the user doesn't have the required data, feels like a clean way to handle the different versions.  And while it would be nice to switch in code to a different base game version (vs. getting a different branch of Draftsman), I think that would be better done only if people express a want and are willing to dig in & submit PRs.
So yes, I think versioning Draftsman's behavior is the way to go.

Currently, Draftsman isn't versioned alongside Factorio; previous versions of Draftsman point to previous versions of Factorio, but going back to previous versions of Draftsman to work with game data from previous versions would sacrifice any modern improvements to the module which is undesirable. It would be nice to have the most modern, stable version of Draftsman be backwards compatible with previous versions of the game without having to downgrade Draftsman itself.
For static game data, I think the best option moving forward is to add a argument to draftsman-update which allows you to specify the version of Factorio you want, e.g:
draftsman-update --factorio-version 1.1.50

... which would pull the commit with that tag from Wube's github and update the submodule inside Draftsman, and then update the configuration so that the data is reflected when you use the module. This requires write access to the Draftsman installation, but Draftsman already requires this when running draftsman-update.
The other half would be making Draftsman handle it's configuration much more flexibly than currently. For example, Linked belts and containers didn't exist prior to Factorio 1.0.20 or so; and since those items are expected to exist in Draftsman currently, setting Factorio to a version prior to that will cause Draftsman to error. (This particular issue has been fixed on 2.0, but I'm not quite done there yet.)

Adding the --factorio-version option sounds like a good path forward.
I was about to ask for a way to check the current version of game data (ala Python's sys.version_info), but I see that's already available in draftsman.data.mods.mod_list.  So if Draftsman can be updated to handle some backward-compatibility in base game behavior, like the linked belts & containers, I think that would put it in a good position with all the changes coming out.

@tephyr In addition to querying draftsman.data.mods.mod_list (which essentially has the base game version as kind of a technicality due to the way Factorio treats it's base version as a mod), you can also use draftsman.__factorio_version_info__, similar to how other python modules will label their versions:
>>> import draftsman
>>> draftsman.__version__
'1.1.0'
>>> draftsman.__version_info__
(1, 1, 0)
>>> draftsman.__factorio_version__
'<IP_ADDRESS>'
>>> draftsman.__factorio_version_info__
(1, 1, 88, 0)

This value is updated with draftsman-update as well.

As of now, --factorio-version is now a command line argument on 2.0:
~ > draftsman-update --no-mods --factorio-version 1.1.100 --verbose
Current Factorio version: 1.1.107
Different Factorio version requested (1.1.107) -> (1.1.100)
Changed to Factorio version 1.1.100

Reading mods from: D:\SourceCode\repos\Python\factorio-draftsman\draftsman\factorio-mods

Discovering mods...

...

In addition to all specific version tags >= 1.0.0, the command also reserves the phrase "latest", which will default to the latest tag available.


Workspace - Invited member becomes hidden if the email address contains "+"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Log in with an expensifail account
Create a workspace
Invite a few members with "+" in the email address

Expected Result:
I should be able to see the email address
Actual Result:
Invited member becomes hidden if the email address contains "+"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/605147b3-8d65-4b6d-8ef7-f7aaabf64c18
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01af9d008b533b0fbd
Upwork Job ID:<PHONE_NUMBER>075328512
Last Price Increase: 2024-04-05

@puneetlath  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Seems like it's most likely a back-end issue. I'll investigate next week.

I'm not able to reproduce this. I'm going to close, but @lanitochka17 please reopen if you're still able to reproduce.


feat(impl):[TRI-1569] container scan last image in docker hub

More like this:
name: don't bring me on the palm
on:
  workflow_dispatch: # Trigger manually
  push:
  pull_request:
jobs:
  build:
    name: Build
    runs-on: ubuntu-20.04
    permissions:
      actions: read
      contents: read
      security-events: write
    steps:
      - name: Checkout code
        uses: actions/checkout@v3

      - name: Run Trivy vulnerability scanner
        uses: aquasecurity/trivy-action@master
        with:
          image-ref: 'tractusx/irs-api:latest'
          format: 'sarif'
          output: 'trivy-results.sarif'

      - run: cat trivy-results.sarif

      - name: Upload Trivy scan results to GitHub Security tab
        uses: github/codeql-action/upload-sarif@v2
        with:
          sarif_file: 'trivy-results.sarif'


vacuum.start service 'RoombaVacuum' object has no attribute 'async_start'

Home Assistant release with the issue:
0.92.0
Last working Home Assistant release (if known):
0.91.4
Operating environment (Hass.io/Docker/Windows/etc.):
Docker
Component/platform:
https://www.home-assistant.io/components/roomba/
Description of problem:
Cannot control vacuum
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
vacuum:
  - platform: roomba
    host: !secret roomba_ip
    username: !secret roomba_blid
    password: !secret roomba_pass

Traceback (if applicable):
Thu Apr 25 2019 11:08:48 GMT-0400 (Eastern Daylight Time)
'RoombaVacuum' object has no attribute 'async_start'
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/websocket_api/commands.py", line 121, in handle_call_service
    connection.context(msg))
  File "/usr/src/app/homeassistant/core.py", line 1138, in async_call
    self._execute_service(handler, service_call))
  File "/usr/src/app/homeassistant/core.py", line 1160, in _execute_service
    await handler.func(service_call)
  File "/usr/src/app/homeassistant/helpers/entity_component.py", line 194, in handle_service
    required_features
  File "/usr/src/app/homeassistant/helpers/service.py", line 316, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/app/homeassistant/helpers/service.py", line 336, in _handle_service_platform_call
    await getattr(entity, func)(**data)
AttributeError: 'RoombaVacuum' object has no attribute 'async_start'

Additional information:

roomba does not support vacuum.start you must use vacuum.turn_on
https://www.home-assistant.io/components/vacuum#service-vacuumturn_on

My mistake, everything looks good now thank you!


enable docker builds

This PR will enable Docker builds for all topics.
The big elephant in the room is the size of the Docker images. A few tutorials are simply to big to bundle everything in one image.
data managers
With CVMFS support inside the images we don't need to strictly run the data_managers anymore, which helps a lot, so the current PR will not run data_managers anymore. For the time being I think we should clean-up data_managers.yaml and remove all reference data that is in the CVMFS. Then only bundle the data_managers into the container that are not yet in CVMFS.
tools
We are working on a way to distribute also tool dependencies via CMVFS,  just to be prepared for the future currently it seems to work.
I needed to remove a few tools (GATK based) that are not updated since years and had no conda package.
The following should now be the default for all tool.yaml files. The templates were updated accordingly.
install_resolver_dependencies: true
install_tool_dependencies: false

data libraries
Most of your data_libraries.yaml files are just paceholders, which is odd and should be fixed in a follow-up PR. However, not all topics do need data, so we might want to remove this from the tests.
I hacked up a small script to merged all data_libraries.yaml files from one topic, so that we avoid redundancy and deliver a clean data library to our users.
Images that at least compile atm:

https://quay.io/repository/galaxy/epigenetics-training
https://quay.io/repository/galaxy/introduction-training
https://quay.io/repository/galaxy/metagenomics-training
https://quay.io/repository/galaxy/sequence-analysis-training
[ ] https://quay.io/repository/galaxy/proteomics-training (has a deactivated broken workflow)

To debug:

[ ] https://quay.io/repository/galaxy/transcriptomics-training (workflow broken?)
[ ] https://quay.io/repository/galaxy/variant-analysis-training
[ ] https://quay.io/repository/galaxy/chip-seq-training

No image needed:

dev
train the trainer

@bebatut @shiltemann its at least a start. 3 containers does not build yet for several reasons. e.g. broken workflows. However, it will add a bunch of containers to the other topics so its better than master I think.
I will try to work on this over Xmas.


Always reuse transaction

I don't see any cases where we have to create a new transaction instead of reusing the transaction in context. So:

Combine WithTx and AutoTx to WithTx, and it always reuses the transaction if it exists;
Make TxContext reuses the transaction if it exists, and it will return halfCommitter when reusing.
halfCommitter implements Committer, but it does nothing when committing, so it's possible to close a reused transaction early, but impossible to commit it early.
Remove ErrAlreadyInTransaction, I don't see any errors.Is(err, db.ErrAlreadyInTransaction), and we don't need it any longer.

After this, we can refactor db.TxContext(db.DefaultContext) to db.TxContext(ctx) safely. I know it's better to use db.WithTx, but for refactoring, I don't think so, it will cause lots of lines to change because an anonymous function is required.

Codecov Report

Merging #22362 (e759b13) into main (d42b52f) will increase coverage by 48.13%.
The diff coverage is 87.87%.

@@            Coverage Diff            @@
##           main   #22362       +/-   ##
=========================================
+ Coverage      0   48.13%   +48.13%
=========================================
  Files         0     1046     +1046
  Lines         0   142384   +142384
=========================================
+ Hits          0    68535    +68535
- Misses        0    65667    +65667
- Partials      0     8182     +8182

Impacted Files
Coverage Δ

models/db/error.go
32.14% <ø> (ø)

models/issues/issue.go
52.41% <0.00%> (ø)

models/project/project.go
35.23% <0.00%> (ø)

models/db/context.go
68.37% <92.00%> (ø)

models/activities/notification.go
62.16% <100.00%> (ø)

models/repo/collaboration.go
49.47% <100.00%> (ø)

models/repo_transfer.go
43.46% <100.00%> (ø)

modules/notification/ui/ui.go
60.11% <100.00%> (ø)

modules/repository/collaborator.go
68.42% <100.00%> (ø)

services/issue/comments.go
60.43% <100.00%> (ø)

... and 1046 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Bridge] Codegen Flow interfaces from RCTBridgeModules

This should be mostly automatable via static analysis with the exception of constantsToExport but it'd be useful to have a partial type interface anyway.

Another thought: this would be helpful as documentation e.g. to easily be able to see what methods UIManager supports without reading the .m file.

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/bridge-codegen-flow-interfaces-from-rctbridgemodules
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
bugfixes as the core team is focused on performance.


Use new api versions

From @tamalsaha on June 21, 2017 15:46
In Kube 1.6,

Deployments changed from extensions/v1beta1 to apps/v1beta1.

Copied from original issue: kubedb/cli#67

From @annismckenzie on July 28, 2017 12:33
In K8s 1.7 TPR is now deprecated – see https://coreos.com/blog/custom-resource-kubernetes-v17.

Yeah!. We are planning to release the next version with CRD support.


Doxxed icon description change

thay note bằng: At least one of the team members’ identity is verified
from the current note due to the word "his" is sexist

Please review @mitchdoan


mjs modules aren't compatible with react-create-app

This looks to be related to issue #14, but running a React application with mobx-sync results in import errors. Even the most basic example results in the error:
Can't import the named export '__assign' from non EcmaScript module (only default export is available)
I can see from issue #14 that the suggested fix is a webpack change, however with react-create-app this would require ejecting the configuration to try and tweak the webpack settings, which I would like to avoid since it isn't reversible.  Is there a way that I can rebuild the mobx-sync package to be ECMAScript compatible, or otherwise reference it in a way that the module shaker will understand?

.mjs file is treated as strict EcmaScript Module in webpack(and Node.js), and its specification disallowed to use import to import a Non-EcmaScript Module, so, .mjs files cannot import any CommonJS modules, such as tslib, it is standard.
So, in actually, we cannot use EcmaScript Module syntax in Node.js, even if we provide --experimental-modules option to allow it, because we cannot use any packages in node_modules, all of them is not standard. Except for we import .mjs file in node_modules directly, such as import { inject } from 'mobx-sync/lib/inject'.
But webpack use EcmaScript Module to Tree-Shaking, it treat .js file as Non-strict EcmaScript Module, which is called javascript/auto, (and standard EcmaScript Module is called javascript/esm, .mjs is treated as it default).
This creates a conflict: Node.js cannot use EcmaScript Module, but webpack want to use EcmaScript Module. So, powerful community invented something for npm packages: build two different version's code into two different directory(such as esm and cjs) from source code before publish it to npm, and add a field module to point to esm, and main to cjs in package.json. And then, Node.js will use cjs version's code because it use CommonJS, webpack will use esm version's code because it APPROVES module field.
Please note module in package.json is not a standard, it is out of expediency. This will lead a new problem(in philosophical): deno's author ry thinks index.js is a bad design, and I agree it absolutely! You cannot see any other language (except for Python) suggest you to compose your exports into one index file! So, EcmaScript Module does not resolve index.js automatically, it is CommonJS's standard(or Node.js). If you want to import an EcmaScript Module, you must import a file explicitly, as you see it in p2 upon.
If we agree it(do not resolve index.js), and want ours npm package supports to works in both Node.js and webpack, we cannot use two directory to separate the two version's code, because its path is different.
I agree it, and do it and promoted it to my company. We use one single directory(lib) to hold two different version's code, the different version's code file ends with different extension: .js and .mjs.
And this is the reason lead to the problem.
In general, I don't know why webpack treat .mjs as strict esm internally when it resolves modules as commonjs, it is incompatible. And I don't know why create-react-app resolved .mjs, but does not set its type(see https://github.com/facebook/create-react-app/blob/e59e0920f3/packages/react-scripts/config/paths.js#L50-L51).

Two ways to resolve this problem:

eject your create-react-app, (I experienced create-react-app just now, it is awesome except for disallow you to customize webpack config!)
wait for all the npm packages upgrade to EcmaScript Module

After a bit of tinkering I did get it to work. It is resolving the mjs files for mobx-sync, however from there the references to mobx & tslib seem to be ignoring the fact it should be looking at ES6 modules and is loading the .js flavours rather than the es6 ones. To work around the issue I removed the .js files from mobx and tslib and put copies of the es6 flavours in their place. There was one misleading bug left that it was complaining about .index() though that was due to a typo in my code with a comma. :{   I've raised an issue with react-create-app/react-script as they had been doing some pondering and back & forth around mjs files and it looks like it should be supported, but seems to still have issues. (Oh the joys of trying to bring standards to JavaScript! :)    So in the end I have been able to get it running, though one remaining small question: When wired up with localForge the persistence is persisting to Local Storage on Chrome rather than IndexDB which was expected. I've been replacing Redux /w MobX and the redux persistence /w localForge went to an IndexDB store by default. Just curious if this is configurable?

You can try timarney/react-app-rewired to customize your webpack config without ejecting.


Handle undefined identifier in asset aggregation

This bug caused an issue while migrating dandiset 000025 in production. While trying to save the migrated dandiset, this error ocurred:
Migrating 000025/draft
[17:11:02] ERROR    Error calculating assetsSummary
                    Traceback (most recent call last):
                      File "/app/dandiapi/api/models/version.py", line 228, in _populate_metadata
                        summary = aggregate_assets_summary(
                      File "/app/.heroku/python/lib/python3.8/site-packages/dandischema/metadata.py", line 321, in aggregate_assets_summary
                        _add_asset_to_stats(meta, stats)
                      File "/app/.heroku/python/lib/python3.8/site-packages/dandischema/metadata.py", line 294, in _add_asset_to_stats
                        if value["identifier"] not in stats["subjects"]:
                    KeyError: 'identifier'

Apparently some asset does not have an identifier defined, which the code expected.

i have pinged @bendichter about this dandiset. it seems to presently violate our assumptions.


Not passing one of the test

Hi there. I am on WSL2 Ubuntu 20.04 with PG 12.6. And after installation, I found that the test named '08_plplgsql' failed.
Test output:

The diff result:

BTW. It seems like the behavior is not right...

I don't know what's wrong on your installation but in a similar system I can not reproduce the issue your are facing.
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.2 LTS"

$ make installcheck
/usr/lib/postgresql/12/lib/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --bindir='/usr/lib/postgresql/12/bin'    --inputdir=test --dbname=contrib_regression 00_init 01_oncommitdelete 02_oncommitpreserve 03_createontruncate 04_rename 05_useindex 06_createas 07_createlike 08_plplgsql 09_transaction 10_foreignkey 11_after_error
(using postmaster on Unix socket, default port)
============== dropping database "contrib_regression" ==============
DROP DATABASE
============== creating database "contrib_regression" ==============
CREATE DATABASE
ALTER DATABASE
============== running regression test queries        ==============
test 00_init                      ... ok           95 ms
test 01_oncommitdelete            ... ok           85 ms
test 02_oncommitpreserve          ... ok           73 ms
test 03_createontruncate          ... ok           89 ms
test 04_rename                    ... ok          119 ms
test 05_useindex                  ... ok           97 ms
test 06_createas                  ... ok           65 ms
test 07_createlike                ... ok           93 ms
test 08_plplgsql                  ... ok           98 ms
test 09_transaction               ... ok           93 ms
test 10_foreignkey                ... ok           40 ms
test 11_after_error               ... ok           76 ms

======================
 All 12 tests passed.
======================

Maybe check that you have version 2.2 of pgtt installed.

Yeah pgtt 2.2 has been installed.
I run the test again, and now everying is fine. (I have run the test several times after installation, but all of them have failed)
Don't know why it's working now... I have done nothing.
BTW, thanks for your answer and the great work of pgtt.


fix: no retry ValidationException

Signed-off-by: BobDu<EMAIL_ADDRESS>Issue #, if available:
related: #101
Description of changes:
ValidationException is a can not retry. But the ValidationError http status code is 400
https://docs.aws.amazon.com/timestream/latest/developerguide/CommonErrors.html#:~:text=Status Code%3A 400-,ValidationError,-The input fails
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Ideally validation exception should not be retried can you provide us the scenario you ran where you saw this behaviour?


Drop -Wno-unused-function on Clang, find out about actually unused functions, silence false positives.

The annoying part is that clang doesn't track taking the address of functions as uses, so that's the common cause to all the false positives. Still easy enough to silence with unused-attributes and hopefully the lines of code diff makes it worth it.

I think we'll have to figure out something better for the runtime side as just because we don't use something in whatever is being compiled doesn't mean that a user of our library won't use it - for example IREE_VM_DECLARE_TYPE_ADAPTERS declares a bunch of methods users are allowed to use and that we use some ourselves and not others is incidental. Noting things unused that may actually be used also hurts readability as someone coming across a function marked unused will think it is dead code we're keeping around vs just being something on a code path that isn't hit in their particular configuration. With the number of runtime configuration points this will lead to errors with anyone compiling with different features enabled than we have since our build coverage is so low.
Is there more control over this flag we can have? I do like removing actually dead code but I suspect we'll have to turn this off for the runtime if it really needs .h changes. I'll probably end up reverting some of these changes but would like to keep the flag on for the runtime if we can have more nuance with it so suggestions are welcome as how to best use it in a way that is more appropriate for library use.

It breaks macos build. There are unused functions in below three files:

runtime/src/iree/hal/drivers/metal/direct_allocator.m -- iree_hal_metal_allocator_const_cast
runtime/src/iree/hal/drivers/metal/direct_command_buffer.m -- iree_hal_metal_command_segment_list_push_front
runtime/src/iree/hal/drivers/metal/metal_driver.m -- iree_hal_metal_driver_const_cast

Should delete them or revert the flag?

@hanhanW thanks for catching this (I'll be away this afternoon).
Can you just re-introduce the flag in that directory?
Can do that conditionally on CLANG_OR_GCC like I did in this PR in iree_c_module.cmake:
  iree_select_compiler_opts(_NO_WARN_ON_UNUSED_FUNCTION
    CLANG_OR_GCC
      "-Wno-unused-function"
  )

This is just going to happen more - I think we should scope the flag to only the compiler.

we also had real positives in runtime/...

generally my finer-grained tool to deal with false positives has been IREE_ATTRIBUTE_UNUSED in c code ... but i dont know if it will work in .m files.

over 5 years most of the positives were in e2e-matmul test ;)
I'm ok with this flag being used occasionally with a human behind it judging the validity/usefulness, but it's not good (as configured, if it can even be changed) for runtime library code. Adding IREE_ATTRIBUTE_UNUSED blindly isn't good (as noted above - half the additions weren't actually unused code, and that's confusing).
Love cleanup, but it really isn't critical vs the fragility of it in the runtime.

OK, started a revert at https://github.com/openxla/iree/pull/15483.  Feel free to merge it while i'm away this afternoon.  Then I'll do a 2nd pass here selectively applying only the removal of true positives.

Take two: #15502


Validation Error Activity Date Missing Date

The file produced by Aidstream for Child Hope UK - https://www.aidstream.org/files/xml/childhopeuk-et.xml is currently reporting an error via the IATI Validator
Element 'activity-date': The attribute 'iso-date' is required but missing
It appears that the actual date for activity-date is missing. Please can you investigate?

Same as https://github.com/younginnovations/aidstream/issues/135#issuecomment-167989277


Unable to delete last BelongsToMany relation in BREAD

Laravel Version: 5.5.28
Voyager Version: 1.0.12
PHP Version: 7.0.23
Database Driver & Version: Server version: 5.7.18-16 Percona Server (GPL), Release 16, Revision d7301f8

Description:
Bug. It is impossible to delete last BelongsToMany relation between objects using BREAD.
The one row in pivot table always stay.
Steps To Reproduce:

Create table Items ( id, name, created_at, updated_at)
Create table tags (id, name, created_at, updated_at)
Create pivot table  item_tags (item_id, tag_id)
Create BREAD for Items
Create BelongsToMany relation in items BREAD
Add one  item and  add tag to that item
Edit item and try to delete tag

Voyager shows a Sucess result, but - the tag was not remove.

Same issue with manyToMany and pivot_table
Can't delete all tags in fields. When you same with 0 tag pivot_table don't update.

Same issue. Can not delete the last pivot record.

Laravel Version: v5.6.28
Voyager Version: v1.1.3
PHP Version: 7.1.8
Database Driver & Version: PostgreSQL 9.2.23

Fixed in #3016.
Merged into 1.x


Add patch reverting CCCL PR 211.

Description
Something is going wrong in thrust::copy, so I am adding a patch to revert https://github.com/NVIDIA/cccl/pull/211. This will fix the failing tests for https://github.com/rapidsai/cuspatial/pull/1315.
This is where it's failing, with thrust::copy:
https://github.com/rapidsai/cuspatial/blob/8e8fa0689339c0288746b01a8af66fb599f5c770/cpp/tests/range/multipolygon_range_test.cu#L800
CI log: https://github.com/rapidsai/cuspatial/actions/runs/7229405991/job/19700477218?pr=1315#step:7:3280
[ RUN      ] MultipolygonRangeOneTest/1.OneMultipolygonRange
unknown file: Failure
C++ exception with description "__copy:: D->D: failed: cudaErrorInvalidValue: invalid argument" thrown in the test body.

[  FAILED  ] MultipolygonRangeOneTest/1.OneMultipolygonRange, where TypeParam = double (0 ms)

I traced it down to this CCCL PR - note that thrust::transform(..., thrust::identity{}) works, but the new thrust::copy code path in https://github.com/NVIDIA/cccl/pull/211 that calls cudaMemcpyAsync doesn't work for some reason. I was not able to identify the exact reason why that PR causes the failure. Patching this out will unblock RAPIDS and let us migrate forward with CCCL 2.2.0.
This helps with #502.
Checklist

[x] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The cmake-format.json is up to date with these changes.
[ ] I have added new files under rapids-cmake/

[ ] I have added include guards (include_guard(GLOBAL))
[ ] I have added the associated docs/ rst file and update the api.rst

/merge


Replace SimpleElastix with ITKElastix?

The SimpleElastix library built on SimpleITK provides an object-oriented interface to accessing the Elastix registration library. We have built our own binaries (Python wheels) of SimpleElastix since official binaries are not currently available on PyPi because of a naming conflict with SimpleITK. ITKElastix is an alternative programmable interface to Elastix based on SimpleElastix but not SimpleITK. It appears to perform similar functionality and is available on PyPi.
As far as I can tell, the advantages of SimpleElastix are:

We have already built custom binaries
Already integrated into MagellanMapper
We also use some SimpleITK functionality available through SimpleElastix

Pros for switching to ITKElastix:

Project appears to be more active currently
Binaries available on PyPi, which brings MagellanMapper one step closer to a simple Pip install
Based on SimpleElastix, so migration may not be difficult

Opening this issue to any discussion about the advantages of either library for MagellanMapper.

SimpleElastix is apparently in the process of being merged into SimpleITK:
https://groups.google.com/g/elastix-imageregistration/c/LUWEm0I5OFY/m/M_nussWqAAAJ

SimpleElastix was merged into SimpleITK. Once these changes are released on PyPi, we'll switch over the vanilla SimpleITK.


DuckDB fails with OutOfMemoryException

duckdb.duckdb.OutOfMemoryException: Out of Memory Error: Failed to allocate block of 2048 bytes (bad allocation)

Run: https://github.com/coiled/benchmarks/actions/runs/8373390651/job/22926339489#step:11:195
This error pops up from time to time even though memory doesn't look that bad. See also https://github.com/coiled/benchmarks/issues/1387#issuecomment-1942069967.

FYI, this appears to be an open issue: https://github.com/duckdb/duckdb/issues/9880


FetchError: request to https://home.cielowigle.com/home/index failed

I run these:
cd /homebridge/node_modules/homebridge-smartcielo/node_modules/node-smartcielo

node index.js -u<EMAIL_ADDRESS>-p password -i <IP_ADDRESS> --verbose

This is the result I get.
Connecting...
(node:9795) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(Use `node --trace-warnings ...` to show where the warning was created)

Communication Error: FetchError: request to https://home.cielowigle.com/home/index failed, reason: connect ECONNREFUSED <IP_ADDRESS>:8888
    at ClientRequest.<anonymous> (/homebridge/node_modules/homebridge-smartcielo/node_modules/node-fetch/lib/index.js:1461:11)
    at ClientRequest.emit (events.js:375:28)
    at onerror (/homebridge/node_modules/homebridge-smartcielo/node_modules/agent-base/dist/src/index.js:117:21)
    at callbackError (/homebridge/node_modules/homebridge-smartcielo/node_modules/agent-base/dist/src/index.js:136:17)
    at processTicksAndRejections (internal/process/task_queues.js:95:5) {
  type: 'system',
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED'
}

Issue #10  seems related

Closing per https://github.com/nicholasrobinson/node-smartcielo/issues/19


Fast switching between tab bars causing creating new tab instead of restoring previous one

Hi,
I found a bug related to navigation. I have an application with bottom nav bar. When i navigate between them using :
navigator.resetRoot(HomeNavTab2, saveState = true, restoreState = true)
everything works fine - the state of each tab is being restored. However, when I rapidly switch between the tabs (akin to "spamming"), the expected state restoration does not occur. Instead, a new screen is generated each time."

Can you link a sample we could reproduce this on? A test would be ideal but even just a sample app that we could manually try. Otherwise there's not much for us to go on here

@ZacSweers sure, here is the repo:
https://github.com/mkowol-n/SlackNavIssue
And i will attach video:
Uploading Screen_Recording_20240314_200910_SlackNavIssue.mp4…

Is this possibly related to #1312? i.e. debouncing issues


New feature: change months

Pull Request related to https://github.com/chemerisuk/better-dateinput-polyfill/issues/8
It's a Pull Request to check if what I'm doing is OK and accepted by @chemerisuk.
There are to many possible improvements, but I need some @chemerisuk comments.
Por example: I'm using display: none to hide the month view instead of visible: hidden.
I'll wait for the changes request from @chemerisuk and fix and add them to this PR.

Coverage decreased (-7.12%) to 76.67% when pulling 8d1ac10c327b3f66fbac5ad6c21ad8d9167d6ceb on BrodaNoel:new-feature-change-months into 78a3ad2a116cde1c343c0147dd305c536e170b41 on chemerisuk:master.

Coverage decreased (-5.45%) to 78.33% when pulling 9d1948a5dc7ee67eed4139e40608e2e53b7c8144 on BrodaNoel:new-feature-change-months into 78a3ad2a116cde1c343c0147dd305c536e170b41 on chemerisuk:master.

If you want, I could add all the necessary commets to understand what I'm doing.

@BrodaNoel sorry, I can't merge your PR. There are too many issues, and I don't have time to comment all of them...


thread 'main' panicked at 'called Option::unwrap() on a None value'

Yes, I am aware that there was an issue like this already submitted.
No, the person who submitted the issue did not provide a solution before closing it.
 $ ./dyn-wallpaper-linux "Denver" ~/Pictures/Wallpapers/dynamic_wallpaper/mojave_dynamic/

thread 'main' panicked at 'called Option::unwrap() on a None value', libcore/option.rs:355:21
note: Run with RUST_BACKTRACE=1 for a backtrace.

Hi there.
I tried downloading all the images from https://files.rb.gd/mojave_dynamic.zip and unzipped them into ~/Pictures/mojave. It actually works for me:
$ ./dyn-wallpaper-linux "Denver" ~/Pictures/mojave/
16 images found in /home/antonio/Pictures/mojave/
Output file: "/tmp/dyn_wallpaper.jpg"
Selected city: Denver
Now: 2020-03-24 10:55:45.140390260 UTC

can you make sure you have the 16 images in ~/Pictures/Wallpapers/dynamic_wallpaper/mojave_dynamic/?
cheers

I also realized that I did not mention in the README that dyn-wallpaper uses "feh" by default to change the wallpaper.
If you are using Gnome as your DE you should run instead:
./dyn-wallpaper-linux "Rome" ~/Pictures/mojave "gsettings set org.gnome.desktop.background picture-uri {path}"

you can customize the command being executed for changing the wallpaper like that.

Okay, yes I am using GNOME... I will try that :)

If someone stumbles upon this I just wanted to add that the same error occurs if you don't delete the MACOSX folder.


LightNER Datasets not k-shot per entity

MIT RESTAURANT does not have 10-shot per entity
for example Location has 23 named entities, for other named entities I see this problem as well and for other datasets.

Hi,
First, there are usually multiple entities in a sentence, it's hard to sample precision k-shot data, so we control the total number of samples. The distribution of entity tags in the sample results is the same as the complete original data. The Mit-Restaurant dataset contains most 'location' entity tags, so the sample result as same. Second, note that DeepKE is an open toolkit for knowledge base population, we provide some data for example and you can sample data by yourself. Last, we will update more balanced k-shot data for examples.
Thank you!


Prepare release 3.1.8

Codecov Report

Merging #5104 (88dd08e) into master (3f948aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5104   +/-   ##
=======================================
  Coverage   95.86%   95.86%
=======================================
  Files         674      674
  Lines       66923    66923
=======================================
  Hits        64157    64157
  Misses       2766     2766

Flag
Coverage Δ

servertests
36.79% <ø> (ø)

unittests
95.80% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f948aa...88dd08e. Read the comment docs.


Fix typo

What changes are proposed in this pull request?
fixed typo
Why are the changes needed?
endComitIdx -> endCommitIdx
Does this PR introduce any user facing changes?
NO

alluxio-bot, merge this please


save fine resolution budget to zarr

The folder of netCDFs is inconvenient to analyze
This PR adjusts the fine resolution budget coarse-graining workflow to save to
zarr instead using Spencer's new xpartitioner project.
Requirement changes:

add xpartitioner as a subtree

[ ] Tests added

These commits should be cherry-picked to xpartition: f32b30f bdee2c4 d841e8f

Here's some proof this works: https://console.cloud.google.com/dataflow/jobs/us-central1/2021-04-26_14_29_56-14056168565622424951?project=vcm-ml

@spencerkclark I kind of ditched on the history attribute since it was actually non-trivial to implement. I hadn't thought about metadata consolidation. This seems like it should be handled on the xpartition side.


 I changed the permissions for contributors (as I am a member, too) but not for project and project collection admin. Seems like the permissions for contributors are higher than for project admin. Neither my boss as PCA nor me as PA have access to the wiki anymore.
edit: now my boss gave me both, Project Administrator and Project Collection Administrator, but nothing changed. Still not have permissions on wiki

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c86f5178-e331-f45e-b60a-f0f3955f7a08
Version Independent ID: 8a0882a7-8f48-32bb-c741-12976b428c38
Content: Manage permissions for READMEs and wiki pages in Azure DevOps - Azure DevOps
Content Source: docs/project/wiki/manage-readme-wiki-permissions.md
Product: devops
Technology: devops-collab
GitHub Login: @chcomley
Microsoft Alias: chcomley

@matthiasburger  We're sorry your experiencing issues.
This is likely deals with account permissions in which case a member of the product team is needed to assist, our apologies for the inconvenience.
Please move the issue to the Azure DevOps forum for further escalation.

Thanks you @msebolt  , I asked for help in the forum: https://developercommunity.visualstudio.com/content/problem/759418/shut-out-from-wiki.html - hope we can edit our wiki soon 😆

@msebolt I removed "contributors" from my groups and had to remove contributos as parent of other groups and it worked.. still bit confusing why denying for contributors is higher than allowing for project administrator

@matthiasburger Glad you figured it out and thank you for providing the solution.


 Heavily inspired from a badly designed website.

ok iguess


Update README.md

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I'm not sure if this works in a PR or if it's only for issues but: @conda-forge-admin, please add user @ioanaif

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

@vgvassilev you should be able to merge #6 to give @ioanaif access to this repo
Also see the bots comment about creating PRs from forks: https://github.com/conda-forge/clad-feedstock/pull/5#issuecomment-966931797

@chrisburr ah, okay, let's close this now.


Bucket.upload not returning api response.

Environment details

OS: Linux
Node.js version: 8
@google-cloud/storage version: 1.6

Steps to reproduce
const response = await bucket.upload('/tmp/myfile', { destination: '/some/path' });

response[0] is the file object
response[1] isn't defined, I was expecting an apiResponse object
Looks like it should return:
https://github.com/googleapis/nodejs-storage/blob/master/src/bucket.js#L2028
https://cloud.google.com/nodejs/docs/reference/storage/1.6.x/Bucket#upload

Thanks for pointing this out. It looks like we are falsely stating we'll return an API response argument, when we certainly don't. We should return the metadata as the apiResponse argument.
For a workaround in the meantime, you can read the returned File object's metadata property, which will be the same thing.

Thanks for the workaround!

I am not getting any response and image is also not getting uploaded to bucket.
bucket.upload(localFilePath, {
            destination: 'images1/',
            uploadType: "media",
            metadata: {
              contentType: 'image/jpg',
            }
          })
          .then((data) => {
            console.log("Asdasdasdasdas");
              const file4 = data[0];})


Add start of a change log

We should probably also have a release checklist to remind us to update this!

LGTM


Add sparkly

The resource itself: https://github.com/Tubular/sparkly

PR alone LGTM. Regarding the project I would like to get some response to https://github.com/Tubular/sparkly/issues/29 first. @eliasah?

I agree with @zero323 on this

Actually response is there. Please be free to ask if you need enything else. Is "Spark 2.x support" a must-have requirement to be a part of the list ? I found nothing about that in README.md and contributing.md either.
Thank you for the review and your work on the list :)

@veelenga It is not about must-have, more about common sense. It has been almost half a year since 2.0 release and ability to follow Spark development cycle is a good sign that project, especially relatively small one, hasn't stalled. Sadly, this is a common issue in the Spark ecosystem, and in hindsight we should have anticipate that.
So what I am trying to avoid is adding a project I am not familiar with and haven't used in practice just to put in on to-remove list (this one tends to grow faster than the awesome part) and I don't mean to offend anyone here :)

@zero323 ok, i understand. Thank you for explanation.

@zero323 so, what are the requirements to become a part of the list?

@drudim Following the contribution guidelines and some informal consensus between team members (this means me and @eliasah).
I cannot speak for Eli, but if I am not familiar with a project,  it is important for me to be able to take it for a test run. It is curated list after all. This means that:

Code has to look good enough for me to trust it in my own environment ( ✔).
I have to be interested in the functionality (✔).
It cannot depend on legacy environment (like JDK 7, Scala 2.10 or Python 2.x) ( ✔) or Spark version I haven't used for a while (1.x) (✘).

If these criteria are not satisfied I usually trust Eli's judgment and experience with a given project. I recognize these are highly  subjective criteria, but as someone told me lately, open source project allows expressing opinions through forks.

Unfortunately, like mentioned by @zero323, adding dead project doesn't help anyone. Some needs to be tested and other deprecated. The whole idea of the list is to get something curated which actual people can use.

@drudim awesome aside, do you have any TODO list for 2.0?

@zero323 I am integrating Spark 2.x to our infrastructure right now and going to switch to sparkly from the next week. We don't want to distribute sparkly unless at least one of our internal services is ported to the release candidate. I will let you know as soon as PR for Spark 2.x is ready.
Thank you guys for taking care of the list!

@veelenga @drudim @skliarpawlo I had some time to play with the project and I think we can merge this PR. I you make me regret that I know where to find you 😈

:D Thank you!

@zero323 support of spark 2.x is coming. I have successfully migrated one of our internal service to Spark 2.x this week using https://github.com/Tubular/sparkly/pull/35 I guess in a week or two, we will be ready to distribute it on PyPi.


Integrates custom UI panel for reviewing mission information

this PR also takes the notification functionality from applyCfgLoadout and moves it to a unique function with a "showNotification" param (phx_fnc_briefingGear). When loadout is actually assigned, the code will populate the "My Starting Loadout" diary entry with data. The command is subsequently run again but without notification, so the diary entry will display the expanded ACE medical items instead of the unprocessed FAKs. It could also be run subsequently to display updated information based on the current state of the player's inventory.
This data is also updated in the data array that the mission info panel uses, to ensure parity.
The panel itself is ready for wider testing/deployment, relying on an addon update to add the CBA keybind init that calls the function (phx_ui_fnc_missionInfoPanel), default Ctrl-J.


Disallow empty cbId value to pass through

Issue
If a cbId attribute existed on a node, but was an empty value (e.g. user cleared it; I'm looking at you @LiborBatek ) then it would magically pass validation but break in collecting looks.
Solution
Do not allow empty values to pass through.
Testing notes

Create a model
Save scene
go to the cbId attribute in attribute editor, and clear the value (make it an empty string)
Publish the model.

The model should be invalidated and the id be regenerated.

Regenerate action works too but Select Invalid action does not select anything and inform user in script editor that no entities have been found....

Ah, great testing @LiborBatek - this would've actually already been broken BEFORE this PR. Fixed now. ❤

I would like to also propose to change the naming of Regenerate UUIDs as its refering something else and already caused some confusion to users...but that could be probably separate PR??

Yes, separate issue please - so we can also discuss why and what would be better.


Android 7 Meizu M5 Note the application freezes and then closes

Expected Behavior
After the user selects a picture, he returns to the application and it does not freeze
Actual Behavior
After the user selects a picture, he returns to the application and aplications begin to freezes and then closes. This happens even if I don’t display selected image in ImageView
Steps to Reproduce the Problem

User selected Image
After onActivityResult aplications begin to freezes and then closes

Specifications

Image Picker Version: 2.0.0'
Android OS: 7
Phone: Meizy M5 Note

Hello everyone. In general, I found that the hang on this phone model ceases to occur if you remove the line // .includeVideo (true). I wanted to use this library for both pictures and videos.

@Strikelon is there any log or stacktrace?

Closing this due inactivity


Message Bot to contact Support Team

Will be using Twak.to api for making the bot

Hey, I looked into twak.to API, only JS API is available there. How can I implement it in flutter

Hey, I looked into twak.to API, only JS API is available there. How can I implement it in flutter

@Imadarshsri
Check this out
https://pub.dev/documentation/flutter_tawk/latest/

@Imadarshsri
Check this out
https://pub.dev/documentation/flutter_tawk/latest/

@jaisadana1999...Thanks,  I will see it..start working on this

@jaisadana1999...Thanks,  I will see it..start working on this

Great go ahead @Imadarshsri

Great go ahead @Imadarshsri


Sweep: Create folder projects and include the bot_ConversationalRetrievalChain.py file

Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Feature request:
Create a projects folder in the root folder of the repo.
Include the file bot_ConversationalRetrievalChain.txt which is a Python script.
Create a proper documentation of the script and generate a critic of it and propose improvements.
bot_ConversationalRetrievalChain.txt

Checklist

[X] Create projects/bot_ConversationalRetrievalChain/bot_ConversationalRetrievalChain.py ✓ https://github.com/gpilleux/langchain/commit/db5bf38bfcbf3e9df7c6a72bae081c961d247c9b Edit
[X] Running GitHub Actions for projects/bot_ConversationalRetrievalChain/bot_ConversationalRetrievalChain.py ✓  Edit
[X] Create projects/bot_ConversationalRetrievalChain/README.md ✓ https://github.com/gpilleux/langchain/commit/0873cd6b92883116877c95fe7be62f2a95033e2f Edit
[X] Running GitHub Actions for projects/bot_ConversationalRetrievalChain/README.md ✓  Edit

You actually need to implemente the following script in here.
bot_ConversationalRetrievalChain.txt


Added wharf-core configs

Added wharf-core/pkg/config loading
Changed to use Config throughout instead of env vars
Added backward compatability with previous environment variables

I expected a default config file to be committed to the repo with the defaults set. Its much simpler to change a config than to invent one that conforms to a set standard where description is scarce.

I thought the reference documentation would be enough, as the types are heavily commented there.
What I like with it being in Go code instead of YAML is that we get compile time safety. I find a YAML file hard to maintain as it easily gets outdated if we're not careful, while the config.go file won't let the tests run if they fail to compile.
A markdown or YAML generator would actually be the best. Something that generates the YAML and environment variable names for each setting, as well as the potential default values. Similar to how we generate our https://github.com/iver-wharf/wharf-helm/blob/master/charts/wharf-helm/README.md file

I expected a default config file to be committed to the repo with the defaults set. Its much simpler to change a config than to invent one that conforms to a set standard where description is scarce.

I thought the reference documentation would be enough, as the types are heavily commented there.
What I like with it being in Go code instead of YAML is that we get compile time safety. I find a YAML file hard to maintain as it easily gets outdated if we're not careful, while the config.go file won't let the tests run if they fail to compile.
A markdown or YAML generator would actually be the best. Something that generates the YAML and environment variable names for each setting, as well as the potential default values. Similar to how we generate our https://github.com/iver-wharf/wharf-helm/blob/master/charts/wharf-helm/README.md file

Im still not sure how this gets delivered but i make some assumptions to demonstrate the problem im foreseeing.
Assuming

the plan to deliver this is through our quay hosted images
the quay hosted images contain compiled code in the form of binaries
this config file is contained inside the binary file
Then:
Changes to this file seems practically impossible. To change this config you would then have to
download the code
create your own image build steps for the new settings
host to your own container registry
write your own helm charts
This seems to void the value of our quay images and helm charts.

I would want a config file to be accessible such that a settings change is as simple as a container file bind top override the config file. Yaml or json config would accmplish this goal much better IMO.

Im still not sure how this gets delivered but i make some assumptions to demonstrate the problem im foreseeing.
Assuming

the plan to deliver this is through our quay hosted images
the quay hosted images contain compiled code in the form of binaries
this config file is contained inside the binary file

Then:
Changes to this file seems practically impossible. To change this config you would then have to

download the code
create your own image build steps for the new settings
host to your own container registry
write your own helm charts

This seems to void the value of our quay images and helm charts.
I would want a config file to be accessible such that a settings change is as simple as a container file bind top override the config file. Yaml or json config would accmplish this goal much better IMO.

If it's the config settings for the user that you're worried about then I'm happy to tell you that for a user to add their configs they have some options, as can be seen here:
https://github.com/iver-wharf/wharf-api/blob/70661e4fe6f63dbdacf0378e0b8fb6d4b4deb500/config.go#L350-L358
First, it uses the hardcoded DefaultConfig from the config.go file as a base, and then it merges all the other config file sources on top of that, one of which is wharf-api-config.yml in the current working directory, but also if they supply WHARF_CONFIG environment variable then that file path is also loaded.
If for say someone hosts Wharf in Kubernetes, then they could mount a ConfigMap object into the container with the wharf-api binary, and then configure Wharf via a secondary resource instead of relying on environment variables.
Changing the default values should not be something the user is expected to do. I agree with you on that part.
Would also like to direct you to these comments:
https://github.com/iver-wharf/wharf-api/blob/70661e4fe6f63dbdacf0378e0b8fb6d4b4deb500/config.go#L11-L30
The link in the README.md file, i.e. this:
https://github.com/iver-wharf/wharf-api/blob/70661e4fe6f63dbdacf0378e0b8fb6d4b4deb500/README.md#L22-L27
Links to that same comment, but rendered over at pkg.go.dev