Create remote dashboard

Hey!!
I've been working on automate the creation of team dashboards through Hygieia API, calling the POST /dashboard/remoteCreate API.
I can successfully run and create the team dashboard on swagger. However, when I run the same curl code on my cmd, I get the following unauthorized message:

"status":401,"error":"Unauthorized","message":"Full authentication is required to access this resource","path":"/api/dashboard/remoteCreate"

The curl command is the following:
curl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '{   "metaData": {     "applicationName": "String new application",     "componentName": "String new application",     "owner": {       "authType": "STANDARD",       "username": "admin"     },     "template": "testing",     "title": "dash new application",     "type": "team"   } }' 'http://localhost:9080/api/dashboard/remoteCreate?api_key=$apiKey'
Have anyone faced the same problem? Did I forget to include some information?

@caiohcl - you need to create an api token for yourself. Log in as admin, then go your admin settings. Then click Generate API tokens > New. Enter the username you want to use then set your expiration date to an acceptable future date, click Create. Write you token down as you will not be able to see it again. Now take that token and insert it into this command: echo 'PasswordIsAuthToken:{"apiKey":"<api-token-you-created>"} | base64. Save the output.
Now when you issue create dashboard requests you need to set two headers. apiUser and Authorization. apiUser is the user you create and Authorization will be apiToken <base64 encoded result>.

@matthewbeasley , it worked! Thank you!!!

Hi caiohcl
could you please provide the whole working curl command. so that it will be useful for me.

Hey @alekya123
Following the curl command I've been using. It creates a brand new team dashboard, adding Build, Deploy, Code Quality (sonar), Jira and Bitbucket widgets.
curl -X POST --header 'Content-Type: application/json' --header 'apiUser: <apiUser>' --header 'Authorization: apiToken <apiToken>'  --header 'Accept: application/json' -d '{   "buildEntries": [     {       "description": "<jenkins_job_name>",       "niceName":"<niceName>",       "options": {          "instanceUrl": "<build_url>",          "jobName": "<jenkins_job_name>",          "jobUrl": "<jenkins_job_url>"          },       "pushed": false,       "toolName": "Hudson"     }   ],   "deploymentEntries":[   {     "description": "<application_name>",     "niceName": "<niceName>",     "pushed": true,     "toolName": "Jenkins",     "options": {     	"applicationName": "<application_name>",         "instanceUrl": "<deploy_url>"     }   }   ],   "staticCodeEntries":[     {       "description": "<sonar_project_Name>",       "pushed": false,       "options":{       	"projectName": "<sonar_project_Name>",         "instanceUrl":"<sonar_url>"         },       "toolName":"Sonar"     }   ],   "codeRepoEntries": [     {       "description": "Hygieia-dashboard",       "options": {          "password": "<pwd>",          "userID": "<user>",          "url": "<code_repo_url>",          "branch": "<branch_name>"        },       "pushed": false,       "toolName": "Bitbucket"     }   ],  "featureEntries": [   {      "toolName":"Jira",      "description": "<jiraProjectName>",      "pushed": false,      "options":{      	"teamName": "<$jiraTeamName"'",         "featureTool":"Jira",         "projectId":"<projectID>",         "teamId":"<teamId>",         "projectName" : "'"$jiraProjectName"'",         "estimateMetricType":"count",         "listType":"issues",         "sprintType":"kanban",         "showStatus" : {            "kanban" : true, 	   "scrum" : false         }      }   }   ],   "metaData": {     "applicationName": "'"$dashTitle"'",     "componentName": "'"$dashTitle"'",     "owner": {       "authType": "STANDARD",       "username": "admin"     },     "template": "<template_name>",     "title": "'"$dashTitle"'",     "type": "team"   } }' echo $hygieiaURL':9080/api/dashboard/remoteCreate'

@matthewbeasley , it worked! Thank you!!!

@caiohcl - i tried doing

echo 'PasswordIsAuthToken:{"apiKey":""}' | base64
and
echo '{"apiKey":""}' | base64
Both the above fail at 'attemptAuthentication' method with the below exception:-

PFA the values passed in the request and the 401 response i get...

what am i missing? Please let me know.

 Then, go to Settings -> Generate ApiTokens -> New. Save the apiUser you created and the apiKey generated.
After that, open your CLI and run the following command:
echo 'PasswordIsAuthToken:{"apiKey":"<key generated>"}' | base64
*replace  to the apiKey you just got in the previous step.
This command will generate two lines, something like this:

Join them, and use the result as apiToken. Your Rest API call should be something like this:
curl -X POST --header 'Content-Type: application/json' --header 'apiUser: <apiUser>' --header 'Authorization: apiToken <UGFzc3dvcmRJc0F1dGhUb2tlbjp7ImFwaUtleSI6IkZtNi9jMUxPTkl3QndnUndRR0t1dVN6cGFMOGxyVnRiIn0K>'  --header 'Accept: application/json'
*replace  to the apiUser you have set in the first step.
You should be authorized now. Let me know if you face any other issue.

hello, I am trying to use the above Authorization token for github webhook. There is no option to set it up within in github webhook setup interface. Is there a way to set it up please?

@hammad-bbc github webhook does not require web token. However it needs webHook.gitHub.userAgent=GitHub-Hookshot and
webHook.gitHub.githubEnterpriseHosts[0]=<give your enterprise host name>properties added to api properties

@rvema thanks for your reply. our url is www.github.com/[companyname]. Should we just use this url as value for webHook.gitHub.githubEnterpriseHosts[0] ?

@hammad-bbc just github.com should be enough

@caiohcl @matthewbeasley @rvema,
Currently, I'm able to create a dashboard, but no widgets.  I found the activeWidgets attribute is empty after the remoteCreate API finishes.  Do you think that adding the activeWidgets in DashboardMetaData would be the right approach to fix this problem?
Thanks.

@caiohcl @matthewbeasley @rvema,
Currently, I'm able to create a dashboard, but no widgets.  I found the activeWidgets attribute is empty after the remoteCreate API finishes.  Do you think that adding the activeWidgets in DashboardMetaData would be the right approach to fix this problem?
Thanks.


Could not find a declaration file for module 'svelte-carousel'

I'm using the SvelteKit workaround:

I'm also using TypeScript.
Here, I'm getting the following error:
Could not find a declaration file for module 'svelte-carousel'. '/home/lena/bespinian/bespinian.io-svelte/node_modules/svelte-carousel/src/main.js' implicitly has an 'any' type.
      Try `npm i --save-dev @types/svelte-carousel` if it exists or add a new declaration (.d.ts) file containing `declare module 'svelte-carousel';`

npm i --save-dev @types/svelte-carousel doesn't work because that package doesn't exist.
I'm not sure if the problem is related to the SvelteKit workaround or if this package is generally not typed (correctly) for TypeScript.
My current workaround for this issue is to add declare module 'svelte-carousel'; to src/app.d.ts. However, it feels like I shouldn't need to do that, if this package was typed correctly.
Furthermore, it would be very helpful to have typings for the Carousel class and its options. Currently, I'm just typing it as SvelteComponent explicitly.

Hey! So this got me started and now I've built what I think is a correct representation of the types involved.

declare module 'svelte-carousel' {
	import { SvelteComponentTyped } from 'svelte';

	interface CarouselProps {
		arrows?: boolean = true; //Enables next/prev arrows
		infinite?: boolean = true; //Infinite looping
		initialPageIndex?: number = 0; //Page to start on
		duration?: number = 500; //Transition duration (ms)
		autoplay?: boolean = false; //Enables autoplay of pages
		autoplayDuration?: number = 3000; // Autoplay change interval (ms)
		autoplayDirection?: 'next' | 'prev' = 'next'; // Autoplay change direction (next or prev)
		pauseOnFocus?: boolean = false; //	Pauses on focus (for touchable devices - tap the carousel to toggle the autoplay, for non-touchable devices - hover over the carousel to pause the autoplay)
		autoplayProgressVisible?: boolean = false; //Shows autoplay duration progress indicator
		dots?: boolean = true; //	Current indicator dots
		timingFunction?: string = 'ease-in-out'; //CSS animation timing function
		swiping?: boolean = true; //	swiping
		particlesToShow?: number = 1; // Number elements to show
		particlesToScroll?: number = 1; //Number of elements to scroll
	}

	interface PageChangeEvent {
		detail: number;
	}

	interface CarouselEvents {
		pageChange: (event: PageChangeEvent) => void;
	}

	interface CarouselSlots {
		prev: string;
		next: string;
		dots: string;
		default: string;
	}

	export default class Carousel
		extends SvelteComponentTyped<CarouselProps, CarouselEvents, CarouselSlots> {
		goTo: (index: number, options?: { animated?: boolean }) => void;
		goToPrev: (options?: { animated?: boolean }) => void;
		goToNext: (options?: { animated?: boolean }) => void;
	}
}

Hope this helps someone or can get built in!

Would be great to get types added to this package! Thank you for sharing the declaration, helped a lot! 👍
I noticed that the above declaration is missing a few things. It's possible to expose let:showNextPage on the component. I'm not sure how to correctly type that, but instead went with the bind:this={carousel} approach and carousel.goToNext to avoid it.

<Carousel let:showPrevPage let:showNextPage>

Hi, you can write the CarouselSlots interface like this to type the slot props:
interface CarouselSlots {
  prev: string;
  next: string;
  dots: string;
  default: {
    showPrevPage: () => void;
    showNextPage: () => void;
    showPage: (index: number) => void;
    currentPageIndex: number;
    ...
  };
}

I'm having a heck of a time with this.... where does the type declaration go??

I'm having a heck of a time with this.... where does the type declaration go??

I just put it into the src directory.
By the way it should be:
interface CarouselEvents { 	pageChange: PageChangeEvent; }
Otherwise Typescript will complain when accessing event.detail

Thanks!  I've just had red squiggly lines for two weeks but since it works fine I don't complain XD

I have optimised the types a little. These also include the individual properties provided in each slot, as well as the default slot. Using CustomEvent for the pageChange event and promises for the returned functions for the reference variable.
Create this file under src/types/svelte-carousel.d.ts.
declare module 'svelte-carousel' {
	import type { SvelteComponentTyped } from 'svelte';

	interface CarouselProps {
		/**
		 * Enables next/prev arrows
		 */
		arrows?: boolean = true;
		/**
		 * Infinite looping
		 */
		infinite?: boolean = true;
		/**
		 * Page to start on
		 */
		initialPageIndex?: number = 0;
		/**
		 * Transition duration (ms)
		 */
		duration?: number = 500;
		/**
		 * Enables autoplay of pages
		 */
		autoplay?: boolean = false;
		/**
		 *  Autoplay change interval (ms)
		 */
		autoplayDuration?: number = 3000;
		/**
		 *  Autoplay change direction (next or prev)
		 */
		autoplayDirection?: 'next' | 'prev' = 'next';
		/**
		 * 	Pauses on focus (for touchable devices - tap the carousel to toggle the autoplay, for non-touchable devices - hover over the carousel to pause the autoplay)
		 */
		pauseOnFocus?: boolean = false;
		/**
		 * Shows autoplay duration progress indicator
		 */
		autoplayProgressVisible?: boolean = false;
		/**
		 * 	Current indicator dots
		 */
		dots?: boolean = true;
		/**
		 * CSS animation timing function
		 */
		timingFunction?: string = 'ease-in-out';
		/**
		 * 	swiping
		 */
		swiping?: boolean = true;
		/**
		 *  Number elements to show
		 */
		particlesToShow?: number = 1;
		/**
		 * Number of elements to scroll
		 */
		particlesToScroll?: number = 1;
	}

	interface CarouselEvents {
		pageChange: CustomEvent<number>;
	}

	interface CarouselSlots {
		prev: {
			showPrevPage: () => void;
		};
		next: {
			showNextPage: () => void;
		};
		dots: {
			showPage: (pageIndex: number) => void;
			currentPageIndex: number;
			pagesCount: number;
		};
		default: {
			showPrevPage: () => void;
			showNextPage: () => void;
			currentPageIndex: number;
			pagesCount: number;
			showPage: (pageIndex: number) => void;
			loaded: number[];
		};
	}

	export default class Carousel extends SvelteComponentTyped<
		CarouselProps,
		CarouselEvents,
		CarouselSlots
	> {
		goTo(pageIndex: number, options?: { animated?: boolean }): Promise<void>;
		goToPrev(options?: { animated?: boolean }): Promise<void>;
		goToNext(options?: { animated?: boolean }): Promise<void>;
	}
}

As for the Sveltekit support, I simply wrapped in browser as per the documentation

{#if browser}
	<Carousel>

yo 0

yo 1

yo 2

			{#each Array(pagesCount) as _, pageIndex (pageIndex)}
				<button on:click={() => showPage(pageIndex)}>{pageIndex}</button>
			{/each}

	</Carousel>
{/if}

Anybody had any luck when trying to test files using jest that import Carousel?
I receive the error
SyntaxError: Cannot use import statement outside a module


TODO

NOTE: it would be greatly appreciated if you'd help with these!

[ ] Docs
[ ] CMake support
[ ] Examples

Hello @otidev I am participating Hacktoberfest I would like to investigate this issue. Particularly for CMake support


sdk: Set chainId for tx payload when sending

[x] set chainId when sending transaction based on method passed in chain parameter (ie send on HopBridge) or chain property on class instance (ie Token, AMM)

Ready for review


Request For decimals

@antennaio
Thanks for the wonderful plugin :) i really love it.
i am just using your plugin in one of my free plugin.
i just wanted to know its possible to set decimals rating. as my plugin requires decimals rating.
if not can you just give me a patch code for it ?
But i really love your work :)
Thanks
varun s

Hi @technofreaky
I considered partial ratings in the past, but decided to keep this plugin rather simple. The good thing is that there are other alternatives that provide this kind of functionality if you look on GitHub.

@antennaio .. i know.. i am very thank full to you.. i have just made a plugin for woocommerce with your script.
http://codecanyon.net/item/advanced-product-reviews-for-woocommerce/14323430
If you provide half star / decimal star rating it would nice.. you can even give me the code which supports it.. or no issues. and 1000 of thanks for your hardwork. in this rating system


Cannot see the query params for a GET request

In what area(s)?

/area runtime
/area operator
/area placement
What version of Dapr?

0.5.0
0.6.0

Expected Behavior

I build two services (service A and service B) on NodeJs and Express. I also have one front-end app. I hope I can send the data from front-end app to service A via GET request. Service A makes a call to Service B. From service B, I can see the query params for a GET request and response to service A.
Actual Behavior

I cannot see the query params for a GET request from service B.

Note: I can see the data from the body for a POST request from service B

Steps to Reproduce the Problem

Environment: Minikube or EKS with Ingress is enabled
Build two services with NodeJs and Express
Send the query params via GET to service A as following: /?type=ad&page=1

I can see the query params: req.query.type: ad, req.query.page=1

From the service A, makes a http/gRPC call meant for Service B

I cannot see the query params: req.query.type: undefined, req.query.page=undefined

/cc @youngbupark @Haishi2016

@sau-lanvy We are redesigning the service invocation building block and will incorporate your feedback.

@msfussell That is great! Thanks.

@sau-lanvy This should be fixed with 0.7.0. Please let us know and reopen the issue if your scenario isn't working with 0.7.0 release.

@amanbha Thank you. I will check this with 0.7.0 release.

It works well as following the example when callers calls http invoke api:
http://localhost:3500/v1.0/invoke/<app_id>/method/<method>?query1=value1&query2=value2


chore: release main

:robot: I have created a release beep boop
fiber: 1.2.14
1.2.14 (2024-01-14)
Bug Fixes

handle updates from children components (ce86e63)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/pavophilip/react-shader-fiber/releases/tag/fiber-v1.2.14 :sunflower:


build: Upgrade tools to latest versions

build: Upgrade tools to latest versions
build: Upgrade pre-commit hooks to latest

@dependabot rebase


Users want Ambassador to be able to route gRPC services.

This should Just Work in Envoy, but Ambassador may need to know more than it does about gRPC.

need a way to specify that gRPC is active
interop testing
multiple-Ambassador testing

The only thing that Ambassador should need for this is a bit of mapping config for whether to enforce HTTP/1.1 or HTTP/2.

Done as of v0.10.0 https://github.com/datawire/ambassador/commit/f4ba9ab4ef8296689721d9582e83ceeceb07c2f7


Implement clickable area support

Lemonbar supports mouse actions (left button, middle button, right button, scroll up and scroll down) on a block. This feature should be supported by succade in one form or another.

Implemented as of a39864f; although there might be a bug there somewhere.


Compile Android Studio project sample on Windows

This pull request will add bat commands to compile sample project on Windows.
Also build.bat will stop because the Main.hx is not created from bind and respectively haxe build.hxml can't compile.
At the moment after compilation with hxcpp ( using compile-android.bat ) the file libMain-debug.so is not created ( maybe because ARMV5 is not supported anymore ?)

Nice, thanks for this PR!
Indeed, I think we can remove ARMV5 completely now


bugfix for pow and tpow for non-inplace operations

Same problem as https://github.com/torch/cutorch/issues/110 but for pow and tpow.

Thanks


Unable to build schema using buildSchema

My schema end point returns this string
"Directs the executor to include this field or fragment only when the if argument is true"
directive @include(
"Included when true."
if: Boolean!
) on FIELD | FRAGMENT_SPREAD | INLINE_FRAGMENT
"Directs the executor to skip this field or fragment when the if 'argument is true."
directive @skip(
"Skipped when true."
if: Boolean!
) on FIELD | FRAGMENT_SPREAD | INLINE_FRAGMENT
"Marks the field or enum value as deprecated"
directive @deprecated(
"The reason for the deprecation"
reason: String = "No longer supported"
) on FIELD_DEFINITION | ENUM_VALUE
union streamItem = Ad | Content | EditorialPackage | EntityCard
.
.
.
.
when trying to build schema object using
const buildSchema  = require('graphql').buildSchema; const schema = buildSchema(schemaString);
i am getting this error
{ GraphQLError: Syntax Error GraphQL request (5:1) Unexpected String "Directs the executor to include this field or fragment only when the ifargument is true" 4:  5: "Directs the executor to include this field or fragment only when the if argument is true"    ^ 6: directive @include(     at syntaxError (/node_modules/graphql/error/syntaxError.js:31:15)     at unexpected (/node_modules/graphql/language/parser.js:996:33)     at parseDefinition (/node_modules/graphql/language/parser.js:155:9)     at parseDocument (node_modules/graphql/language/parser.js:109:22)     at parse (/node_modules/graphql/language/parser.js:46:10)     at buildSchema (/node_modules/graphql/utilities/buildASTSchema.js:469:43)     at getRequest.then (/src/schema.js:42:32)     at <anonymous>     at process._tickCallback (internal/process/next_tick.js:188:7)   message: 'Syntax Error GraphQL request (5:1) Unexpected String "Directs the executor to include this field or fragment only when theifargument is true"\n\n4: \n5: "Directs the executor to include this field or fragment only when theif` argument is true"\n   ^\n6: directive @include(\n',
locations: [ { line: 5, column: 1 } ],
path: undefined }
`
this is my package json
`
"dependencies": {
"env": "0.0.2",
"express": "4.17.1",
"express-graphql": "0.9.0",
"graphql": "14.6.0",
"path": "0.12.7"
},
Are comments invalid for directives or is there a bug with buildSchema

looks like comment in schema changed from # to ", hence buildSchema is breaking. is there a fix for this ?

hello @schandrasekhar ! this is the graphiql repo, i think you want https://graphql/graphql-js
that said, your issue is that you need to triple quote the comment blocks:
"""my comment"""
type MyType {
	"""inline comment"""
	field: String
}


fix: remove llama-index-legacy dependency in llama-index-core

Description
Follow-up on discussion in #16974. Thanks @masci
Removing the mention to llama-index-legacy which has side effects like requiring tenacity<0.9.0
Let me know if there is anything else to change.
I assume the corresponding lock files are generated automatically on merge Seems like test are failing so pushed the updated poetry.lock
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

[ ] I added new unit tests to cover this change
[x] I believe this change is already covered by existing unit tests

Suggested Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

@Digma any way you can give me push permissions to this branch/repo? I'd like to update the docs pages the mention or use llama-index-legacy


Automated cherry pick of #5596

Cherry pick of #5596 on release-1.46.
/cc  @enahum

/release-note-none


[Snyk] Security upgrade python from 3.5 to 3.13.0b2

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

base/python/python3.5/Dockerfile

We recommend upgrading to python:3.13.0b2, as this image has only 205 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
  829

Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
  829

Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
  829

Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
  829

Resource Exhaustion SNYK-DEBIAN10-NGHTTP2-5953390
  829

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

Checkmarx One – Scan Summary & Details – 5eec7162-a390-4a16-bfce-44b9344b98ed
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Path_Traversal
/base/oracle-java/utils/list-versions.py: [57](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-37afd0e889ad77461594715e6b47a761//base/oracle-java/utils/list-versions.py# L57)
Attack Vector

Fixed Issues

Severity
Issue
Source File / Package

Client_DOM_XSS
/electron/CVE-2018-15685/src/index.html: [17](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-37afd0e889ad77461594715e6b47a761//electron/CVE-2018-15685/src/index.html# L17)

Client_Potential_XSS
/electron/CVE-2018-15685/src/index.html: [17](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-37afd0e889ad77461594715e6b47a761//electron/CVE-2018-15685/src/index.html# L17)

Path_Traversal
/python/PIL-CVE-2017-8291/app.py: [37](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-37afd0e889ad77461594715e6b47a761//python/PIL-CVE-2017-8291/app.py# L37)

Path_Traversal
/base/oracle-java/utils/list-versions.py: [57](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-37afd0e889ad77461594715e6b47a761//base/oracle-java/utils/list-versions.py# L57)


APIView Comments not showing up

APIView comments are not showing up on some azure-rest-api-spec pull requests.
https://github.com/Azure/azure-rest-api-specs-pr/pull/12890
Might be related to https://github.com/Azure/azure-sdk-tools/issues/5377

This was due to failure in evenhubs partition and was resolved by restarting.


⚠ Bofrost.fr has degraded performance

In 4d1ad3f, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1434 ms

Resolved: Bofrost.fr performance has improved in 835db7f.


Update build-powertoys-ci.yml

Increasing out timeout + trying to add in better parallelism

Looks like this ran CI in 44 minutes! 🥇

Yes but others without the parallelism line did as well
At a minimum we increases the timeout


Disabled symbol_presence test on NonStop due to different nm format.

CLA: trivial
Fixes #12996
Signed-off-by: Randall S. Becker<EMAIL_ADDRESS>

@levitte this should be ready to go

@levitte this should be ready to go

Yeah, it just needed a second approval, and @paulidale delivered it 9 hours ago.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to master, thanks for the contribution.


plan: compute all inner joins in memory if they fit

Fixes #577
Because we do not have a way to estimate the cost of each side of
a join, it is really difficult to know when we can compute one in
memory. But not doing so, causes inner joins to be painfully slow,
as one of the branches is iterated multiple times.
This PR addresses this by ensuring that if the right branch of the
inner join fits in memory, it will be computed in memory even if
the in-memory mode has not been activated by the user.
An user can set the maximum threshold of memory the gitbase server
can use before considering the joins should not be performed in
memory using the MAX_MEMORY_INNER_JOIN environment variable or
the max_memory_joins session variable specifying the number of
bytes. The default value for this is the half of the available
physical memory on the operating system.
Because previously we had two iterators: innerJoinIter and
innerJoinMemoryIter, and now innerJoinIter must be able to do
the join in memory, innerJoinMemoryIter has been removed and
innerJoinIter replaced with a version that can work with three
modes:

unknownMode we don't know yet how to perform the join, so keep
iterating until we can find out. By the end of the first full pass
over the right branch unknownMode will either switch to
multipassMode or memoryMode.
memoryMode which computes the rest of the join in memory. The
iterator can have this mode before starting iterating if the user
activated the in memory join via session or environment vars, in
which case it will load all the right side on memory before doing
any further iteration. Instead, if the iterator started in
unknownMode and switched to this mode, it's guaranteed to already
have loaded all the right side. From that point on, they work in
exactly the same way.
multipassMode, which was the previous default mode. Iterate the
right side of the join for each row in the left side. More expensive,
but less memory consuming. The iterator can not start in this mode,
and can only be switched to it from unknownMode in case the
memory used by the gitbase server exceeds the maximum amount of memory
either set by the user or by default.

Signed-off-by: Miguel Molina<EMAIL_ADDRESS>

Fixed

Shall we merge this? @ajnavarro


win10不兼容

安装信息：
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>浏览器信息：
Uncaught ReferenceError: quillEditor is not defined
at Object.install (eval at  (build.js:2526), :12:35)
at Function.Vue.use (eval at  (build.js:1058), :3433:22)
at eval (eval at  (build.js:1986), :38:15)
at Object. (build.js:1986)
at webpack_require (build.js:556)
at fn (build.js:87)
at Object. (build.js:588)
at webpack_require (build.js:556)
at build.js:579
at build.js:582
有解决办法吗？

win 10 还有个问题， 在win 10 上 无法直接输入中文

@erbing 能否提供下问题重现的运行环境，浏览器型号版本、浏览器是否使用插件...


Not running on Mac OS X 10.9.4

Hey, thanks for sharing the module! I wanted to try it out in my project, but when trying to run it after the installation get the following error:
$ sass-watch
/usr/local/bin/sass-watch: line 1: syntax error near unexpected token `('
/usr/local/bin/sass-watch: line 1: `var chokidar = require('chokidar')'

Where would the output of that go?


Fixing influxdb-client go example

Problem
Example given was writing random integers.
Pull Request
This pull request writes colors and shapes instead of random integers.

@nrshrivatsan -- this change doesn't compile. You can check the logs here:
https://circle-artifacts.com/gh/influxdb/influxdb/6734/artifacts/0/tmp/circle-artifacts.dKFMHsM/test_logs.txt

No more changes, closing.


Error Ollama + Langchain + Google Colab + ngrok

When I use the combination: Ollama + Langchain + Google Colab + ngrok.  I get an error
(The models are downloaded, I can see them in Ollama list)
llm = Ollama(
    model="run deepseek-coder:6.7b",  base_url="https://e12b-35-231-226-171.ngrok.io/")
responce = llm.predict('What do you know about Falco?')

Output exceeds the [size limit](command:workbench.action.openSettings?%5B%22notebook.output.textLineLimit%22%5D). Open the full output data [in a text editor](command:workbench.action.openLargeOutput?5f7f2031-a63a-42c0-ac20-ccc8d53de6b2)---------------------------------------------------------------------------
JSONDecodeError                           Traceback (most recent call last)
File [~/miniconda3/envs/llm/lib/python3.11/site-packages/requests/models.py:971](https://file+.vscode-resource.vscode-cdn.net/home/serhiy/Scalarr/llm/%20RAG/~/miniconda3/envs/llm/lib/python3.11/site-packages/requests/models.py:971), in Response.json(self, **kwargs)
    970 try:
--> 971     return complexjson.loads(self.text, **kwargs)
    972 except JSONDecodeError as e:
    973     # Catch JSON-related errors and raise as requests.JSONDecodeError
    974     # This aliases json.JSONDecodeError and simplejson.JSONDecodeError

File [~/miniconda3/envs/llm/lib/python3.11/site-packages/simplejson/__init__.py:514](https://file+.vscode-resource.vscode-cdn.net/home/serhiy/Scalarr/llm/%20RAG/~/miniconda3/envs/llm/lib/python3.11/site-packages/simplejson/__init__.py:514), in loads(s, encoding, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, use_decimal, allow_nan, **kw)
    510 if (cls is None and encoding is None and object_hook is None and
    511         parse_int is None and parse_float is None and
    512         parse_constant is None and object_pairs_hook is None
    513         and not use_decimal and not allow_nan and not kw):
--> 514     return _default_decoder.decode(s)
    515 if cls is None:

File [~/miniconda3/envs/llm/lib/python3.11/site-packages/simplejson/decoder.py:389](https://file+.vscode-resource.vscode-cdn.net/home/serhiy/Scalarr/llm/%20RAG/~/miniconda3/envs/llm/lib/python3.11/site-packages/simplejson/decoder.py:389), in JSONDecoder.decode(self, s, _w, _PY3)
    388 if end != len(s):
--> 389     raise JSONDecodeError("Extra data", s, end, len(s))
    390 return obj

JSONDecodeError: Extra data: line 1 column 5 - line 1 column 19 (char 4 - 18)

During handling of the above exception, another exception occurred:
...
    973     # Catch JSON-related errors and raise as requests.JSONDecodeError
    974     # This aliases json.JSONDecodeError and simplejson.JSONDecodeError
--> 975     raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)

JSONDecodeError: Extra data: line 1 column 5 (char 4)

If I run from the terminal Ollama + Google Colab + ngrok, everything works with google colab and ngrok. Also, if I change the Python script to local base_url:
llm = Ollama(
    model="run deepseek-coder:6.7b",  base_url="http://localhost:11434")
responce = llm.predict('What do you know about Falco?')

everything works  Ollama + Langchain.
Only the combination Ollama + Langchain + Google Colab + ngrok does not work

If I run from the terminal Ollama + Google Colab + ngrok, everything works with google colab and ngrok.

This suggests there's some issue with langchain when using the ngrok host. Perhaps you can follow up in the langchain repo?

@mxyng  I asked https://github.com/langchain-ai/langchain/issues/14810 but nothing happens and the problem remains

@SerhiyProtsenko are you still running into issues with this with the latest version of Ollama, and updating the model via an ollama pull? Just wanted to make sure it's not already fixed on either end.
(Closing for now, but let me know if you are still running into problems) Sorry about this.


Fix bug in crosslink processing

Part of the eth2 interop cleanup.
Fixes a bug due to not respecting the mutability found in the spec definition of process_crosslinks.
Crosslinks that can be accepted earlier should be favored over crosslinks that can be accepted later during a single epoch processing.
Cute Animal Picture

Note for other potential reviewers: The function get_winning_crosslink_and_attesting_indices, which is hidden in this PR, consumes the intermediate status of state.current_crosslinks in the loop.


Fix getting started documentation

The getting started docs still mention the Makefile and are not coherent without it.

Some of this work has been covered by a community PR but a docs review is still in order.

I think the steps here will be to create a complete default infrastructure and document it, step by step, without using the internal tooling at all.
For bonus credit, do it with GCP/GKE, and for no standard infrastructures... like adding a new VPC or cluster.


bug: gutter icon does not display

I have not been able to figure this out. PRs welcome.

I was getting two icons for a while, one of the comment line, one on the line immediately below that the comment pointed to. Now, I don't get any gutter icons. I had the original Line Note installed, but not enabled. So, I played around with installing and uninstalling these two plug ins to ensure that there was no overlap. Uninstalling Line Note Plus did not remove the Line Note Plus folder, so I manually deleted it. Now, I don't see any gutter icons in Line Note Plus. Probaby not related.


Speed up prepare_ml_data.py

Detailed Description
After the "big new design", prepare_ml_data.py takes about 12 seconds per satellite batch.  That's too slow.  But, fear not, there are plenty of ways to speed it up!
After prepare_ml_data.py finishes with sun, topographic, and GSP (which all zoom past), leonardo really isn't being pushed very hard when it's only doing satellite and nwp:

Possible Implementation

[x] Write pre-prepared batches to leonardo's new 4 TB SSD
[x]  check that create batch is still using ThreadPoolExecutor to load examples in parallel
[x] #325
[x] #456
[x] #311
[ ] #475
[ ] Use smaller dtypes for NWP and Satellite Zarrs (see #61).  Although satellite data is already 10-bit-per-channel, so reducing to 8-bit won't speed things up that much.
[ ] If needs be, bring back the idea of creating a batch by loading, say, 16 time slices off disk, and sampling 2 geographical regions of interest from each time slice to produce 32 examples per batch (i.e. halving the amount of data that needs to be loaded from disk per batch).  This definitely speeds up loading but reduces randomness.  This is how the code did it before "the big new redesign".... here's the commit where it was mostly removed: https://github.com/openclimatefix/nowcasting_dataset/pull/307/commits/f896a5e647d024a92505efcdf78ef957e2e6823a#L103 in nwp_data_source.get_batch())
[x] #305
[ ] #304  (but only bother with this if 305 is not sufficient)

perhaps worth saying this is done for now?

yeah, good idea


Add logs section

What does this PR do?
Add logs to riak
Motivation
Additional Notes
Review checklist (to be filled by reviewers)

[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] Feature or bugfix must have tests
[ ] Git history must be clean
[ ] If PR adds a configuration option, it must be added to the configuration file.

@coignetp sorry for the inconvenience, we downgraded the hugo version of the doc to fix this issue. you can put the language prettifier back on :)


Segmentation fault when increase blocks' number

When I increase blocks' number,I met a Segmentation fault,following are the gdb debugging information.
Can anyone share any ideas?
Thanks you all!
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffd46403700 (LWP 37256)]
0x000000000041e83c in multiverso::Aggregator::StartThread() ()
(gdb) bt
#0  0x000000000041e83c in multiverso::Aggregator::StartThread() ()
#1  0x00007ffff7708970 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2  0x00007ffff7965064 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#3  0x00007ffff6e7862d in clone () from /lib/x86_64-linux-gnu/libc.so.6

I also met the same problem, do you solve it?


pip-compile does not find extras

Pip-compile does not find dj_rest_auth extras. (pip install -r requirements.in works as expected.)
Environment Versions

OS Type: Linux
Python version: $ python -V 3.11.5
pip version: $ pip --version: 23.2.1
pip-tools version: $ pip-compile --version 7.3.0

Steps to replicate
echo "dj_rest_auth[with_social]" > requirements.in
pip-compile --strip-extras --allow-unsafe --no-config

WARNING: dj-rest-auth 5.0.1 does not provide the extra 'with_social'

Expected result
requirements.txt contains django-allauth.
Actual result
There is no django-allauth in requirements.txt

pip>22 also does not find with_social extra. It seems pip now expects normalized extra name- with-social

if that's the case then you should either open an issue with pip or close this since it would be working as intended. This tool uses pip itself and will mimic that behavior.

Yea, I know. Just forgot to close.

did you find a solution?

I replaced with_social with with-social myself in requirements.in


Update Composer dependencies (2021-09-21-00-15)

Visual regression test passed!
View the visual regression test report


fix(ci): Use actions/setup-node to seed auth token in .npmrc

While yarn doesn't seem to look at an environment variable for authentication, it does look at ~/.npmrc and the setup-node action reads an auth token from the NODE_AUTH_TOKEN environment variable:
https://github.com/actions/setup-node/blob/59e61b89511ed136a0b17773f07c349fa5c01e8b/src/authutil.ts#L46-L48
All of which is to say this should work now.
I think.
:fingers_crossed:

Has to be merged before it can run, so here's goes something


TypeError: tuple indices must be integers, not str

Resolved it in the latest version...
Do "pip install --upgrade song",
It was occurring due to old version of Beautifulsoup installed on your pc.
Now I have mentioned in the setup file,which version is needed for my script


Failed to connect to selenium. Attempts left: 115   connect ECONNREFUSED ::1:4444

Hi,
I am encountering following issue Failed to connect to selenium. Attempts left: 115 connect ECONNREFUSED ::1:4444, when using botium-connector-webdriverio.
Chromedriver version is - 116.0.5845.141
The package json looks like this
"devDependencies": {
"@wdio/sauce-service": "^6.3.6",
"allure-mocha": "^2.0.0-beta.7",
"botium-bindings": "^2.0.33",
"botium-connector-echo": "0.0.8",
"botium-connector-webdriverio": "^0.3.29",
"botium-core": "^1.9.6",
"chai": "^4.2.0",
"minimist": "^1.2.5",
"mocha": "^8.0.1",
"properties-reader": "^2.0.0"
},
"dependencies": {
"selenium-standalone": "^6.24.0",
}
Please can you provide suggestions how I might resolve the issue. Thanks.

Closing this issue, as I was able to resolve it. thanks.


New logo/icon proposal

Good day sir. I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before I begin my design. Hoping for your positive feedback. Thanks

Perfect, you can continue with this.
If you do this, if you want it will be listed in the Acknowledgements section.


Support for multiple compose files (single project)

It would be great if there was support for multiple compose files, i.e.
$ docker-compose -f file1.yml -f file2.yml CMD

Without this it's unfortunately not usable by anyone who uses docker-compose with extending compose files.
This could be by adding a command Docker: Select Additional Compose File, for example.
Awesome package though, one less reason to leave Atom! :+1:

Yes, I had to rewrite my compose files because I didn't implemented this feature.
It's already on my todo ;)

Update your docker package to 0.7.0 and you'll see the "docker:add-compose-file" command ;)

Amazing - thank you! Great package.


manifest v3

Hello,
I noticed that your repo is not currently compatible with Manifest v3.  Would it be possible for you to consider making repo compatible with Manifest v3?
I hope to hear from you soon.

some instruction on how to make it output : "manifest_version": 3, ?


Running into an issue with the connectOrCreate operation. The following query should create an entity for a Winery, and assign a Tag to it.

Originally posted by @RoaldSchuring in https://github.com/prisma/prisma-client-js/issues/336#issuecomment-653785179
Running into an issue with the connectOrCreate operation. The following query should create an entity for a Winery, and assign a Tag to it.
mutation createwinery {
  createOneWinery(
    data: {
      name: "Winery X",
      author: { connect: { email<EMAIL_ADDRESS>} },
      tag: {
        create: {
          tagName: {
            connectOrCreate: {
              where: { name: "Tag 1" }
              create: {
                name: "Tag 1",
                author: { connect: { email<EMAIL_ADDRESS>} }
              }
            }
          }
          author: { connect: { email<EMAIL_ADDRESS>} }
        }
      }
    }
  ) {
    name
    author {
      name
    }
    tag {
      tagName {
        name
      }
    }
  }
}

I get the error message in the image below
.

When I replace the connectOrCreate operation with a regular create the query runs as expected, without error.

Can you share your schema @RoaldSchuring or the relevant part of it? That would make it a lot easier to reproduce this.
Can you possible also run with  DEBUG=* and attach its output as well please?

Thanks for the quick response! Absolutely. Here's are the Tag, TagWinery and Winery tables from the schema.
model Tag {
  id          String     @default(uuid()) @id
  name        String     @unique
  createdAt   DateTime   @default(now())
  author      User       @relation(fields: [authorId], references: [id])
  authorId    String
  tagWinery   TagWinery[]
  tagWineBottle TagWineBottle[]
  tagVineyard   TagVineyard[]
}

model TagWinery {
  id          String      @default(uuid()) @id
  tagName     Tag         @relation(fields: [tagId], references: [id])
  tagId       String
  winery      Winery      @relation(fields: [wineryId], references: [id])
  wineryId    String
  createdAt   DateTime    @default(now())
  author      User        @relation(fields: [authorId], references: [id])
  authorId    String
}

model Winery {
  id                  String              @default(uuid()) @id
  wineryAccountId     String? /// the Stripe account ID of the winery
  name                String              @unique
  createdAt           DateTime            @default(now())
  author              User                @relation(fields: [authorId], references: [id])
  authorId            String
  address             Address?            @relation(fields: [addressId], references: [id])
  addressId           String?
  contactEmail        String? /// the email address of our contact
  contactPhoneNumber  String? /// the telephone number of our contact
  purchaseOrderEmail  String? /// the email address of the winery representative who will receive confirmation of order
  phoneticSpelling    String? /// the phonetic pronounciation/spelling of the winery's name
  wineBottle          WineBottle[]
  owner               Person[]            @relation("WineryOwner")
  specializesIn       String? /// a few words to describe what this winery is known for
  tagline             String? /// a one-sentence description of the winery to show below the winery name
  description         String? /// a description of the winery's story
  descriptionShort    String? /// the short-form description of the winery's story
  tag                 TagWinery[]
  socialMediaHandle   SocialMediaHandle[]
  website             String?
  winemaker           WinemakerAtWinery[]
  annualProductionCases Int? /// the total number of cases the winery produces, per year
}

And here is the error message after running with DEBUG

I can reproduce this. Here is a reproduction without nexus: https://github.com/harshit-test-org/prisma-client-issue-764

Update for release planning: this needs more immersion in the query engine internals, I haven't had time to tackle it for 2.4.0.

Just looking at the query: This can't succeed. If you don't have an author to connect to, the query will always fail.
Specifically, these lines can't work if the author doesn't exist: author: { connect: { email<EMAIL_ADDRESS>} }, because as opposed to connectOrCreate, connect assumes that the record to connect exists.

Not sure if it helps but I also ran into this when trying out connectOrCreate. I was curious what SQL ran but nothing stood out to me in the below:
2020-08-12 10:53:34.630 PDT [70026] LOG:  statement: BEGIN
2020-08-12 10:53:34.631 PDT [70026] LOG:  execute s163: SELECT "public"."Item"."id" FROM "public"."Item" WHERE "public"."Item"."id" = $1 OFFSET $2
2020-08-12 10:53:34.631 PDT [70026] DETAIL:  parameters: $1 = 'ckdro9ym80000dSetvcs5iir7', $2 = '0'
2020-08-12 10:53:34.631 PDT [70026] LOG:  execute s13: SELECT "public"."Log"."id" FROM "public"."Log" WHERE "public"."Log"."id" = $1 OFFSET $2
2020-08-12 10:53:34.631 PDT [70026] DETAIL:  parameters: $1 = '2020.8.12-cEBicXCDIHgG9Sw8uvACwN0ss', $2 = '0'
2020-08-12 10:53:34.632 PDT [70026] LOG:  execute s15: SELECT "public"."User"."id" FROM "public"."User" WHERE "public"."User"."id" = $1 OFFSET $2
2020-08-12 10:53:34.632 PDT [70026] DETAIL:  parameters: $1 = 'cEBicXCDIHgG9Sw8uvACwN0ss', $2 = '0'
2020-08-12 10:53:34.632 PDT [70026] LOG:  execute s15: SELECT "public"."User"."id" FROM "public"."User" WHERE "public"."User"."id" = $1 OFFSET $2
2020-08-12 10:53:34.632 PDT [70026] DETAIL:  parameters: $1 = 'cEBicXCDIHgG9Sw8uvACwN0ss', $2 = '0'
2020-08-12 10:53:34.632 PDT [70026] LOG:  statement: ROLLBACK

My upsert effectively looked like this:
 const upsertArgs = {
    id: itemId,
    creator: { connect: { id: userId } },
    owner: { connect: { id: userId } },
    ...(logId
      ? {
          log: {
            connectOrCreate: {
              where: { id: logId },
              create: {
                id: logId,
                owner: { connect: { id: userId } },
                date: date,
              },
            },
          },
        }
      : {}),
  }
  return await db.item.upsert({
    where: { id: itemId },
    create: upsertArgs,
    update: upsertArgs
  })

I confirmed that userId and logId were both in the db already and were valid.

Another possible duplicate case with a reproduction: https://github.com/prisma/prisma/issues/3612#issuecomment-692712726

Confirmed duplicate of https://github.com/prisma/prisma/issues/3612


support for observables in svg

using observables as children inside svg does currently not work.
Cycle provides it's own h() replacing the one of virtual-dom for function for generating vnodes.
The svg() function is just a wrapper that delegates to h() but cycle does not redefine svg and just reexports the definition of virtual-dom. Problem is that the original svg() function still calls the original virtual-dom h() function instead of the one defined by cycle.
This causes an UnexpectedVirtualElement when calling
svg('svg', Observable.just(svg('g')))

I propose to redefine svg() inside cycle to make use of cycle's h().

This works for me as a fix:
https://gist.github.com/laszlokorte/f7b52f40d508be5d4027

Good catch!

I would create a PR containing the code above plus a test case if you like but I am not sure if this is the way you want to handle this or if you prefer another solution to reduce code duplication between cycle and virtual-dom

I think you should make a PR with your solution. Optimization and refactoring can always be done. I feel there’s a need to fix these bugs so Cycle Nested can be shipped.

Ok I will to a PR later the day.

Cycle Nested wouldn't be blocked from release because of a bug like this (we can always fix bugs after CN is released). What's important for Cycle Nested while it's a release candidate is to try using nested dataflow components and isolate() in order to discover potential show-stopper bugs.

This is solved in v8.0.0-rc7. Reopen issue if it persists.


Calculator not calculating correctly when using more than a single digit after decimal point

Microsoft PowerToys version
0.68.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
PowerToys Run
Steps to reproduce
When multiplying a number by another with a single digit (i.e. 0.3) after the decimal point all works ok, but when trying to multiply by a smaller number (i.e. 0.003) all zeroes after the decimal point are ignored and the results shown is as if a single trailing digit number was used.

✔ Expected Behavior
To calculate small floating point numbers i.e. 0.0004
❌ Actual Behavior
The zeroes after the decimal point are ignored and the number is converted to 0.4
Other Software
No response

Linking #2265. @crutkas @jaimecbernardo @htcfreek we need a fix for this asap. Don't want any buildings crashing down because PowerToys is responsible for bad calculations, or anything like that...

@Jay-o-Way , perhaps we should make the "Use English (United States) number format for input" the default, since it seems that's how people expect it? 🤔

@jaimecbernardo it's not about the decimal character. There is a fault in the Mages which converts the fractional part into a number and the leading zero's get trimmed off.

@jaimecbernardo it's not about the decimal character. There is a fault in the Mages which converts the fractional part into a number and the leading zero's get trimmed off.

@jay-o-way
Is there an existing issue on the mages repo? If not we should open one that they can fix the bug.

@jaimecbernardo and @htcfreek - we have been discussing this exact issue literally for years now. My commment above (blaming Mages engine) wasn't correct. See, Jaime, you explicitly mentioned the cause in #12375 (july 2021)

Every 0 after the dot on my comma-decimal system configurations seems to be ignored.
1.449*51.0000006 gives the same result (74,7684).
Even 1.0000449*51.0000006 gives the same result (74,7684).

I see that we're also translating the numbers between cultures 🤔 May be this is where the issue is.

I can confirm. Basically we're trying to translate numbers between cultures but then removing leading zeroes...

At the time I thought it was a bug in the engine. Now as I tried it again trying to prevent wrong inputs being sent to the engine I noticed that we're doing some number culture translation, and that's where this comes from. In this translation numbers like 59.06 are seen as two different numbers when . is not the decimal separator. So the numbers 59 and 06 are translated individually and replaced in the query, meaning 59.6 is passed to the engine.

/dup https://github.com/microsoft/PowerToys/issues/2265


Cache caller info

By introducing a cache of caller PC (program counter) to logContext, we
can avoid calling runtime.FuncForPC for each log message. This function
in the runtime package performs a linear search over each function
linked in to the executable, and is thus slow.

Does anybody have time to review these pull requests?

@lwithers I'll go through it over the weekend. Sorry for delay.

No problem at all; and thank you very much for the response.


Fix the theme color of the page

This PR fixes the theme color of the page to make it consistent with the new color palette used by the chat app.

we're losing the dark mode color - will it be ok in both situations or are we not doing dark mode elsewhere?

We’re using the same shade of orange for both light and dark mode in the new theme, so there’s no need to make the distinction.


Instructions to clone repo link is incorrect

The instructions README step says to clone the repo (not the CODE section) do this:
git clone https://github.com/oculus-samples/Unity-Cryptic-Cabinet.git
But it should be this: (without Hyphen)
git clone https://github.com/oculus-samples/Unity-CrypticCabinet.git

Thanks for the report! This has been fixed in b6dc4efc95a65d76049b8f8fb5a339c64116f2d3 :)


[VS Code] Starting collaboration session: NTLM authentication is not possible with default credentials on this platform.

Error:
Starting collaboration session: NTLM authentication is not possible with default credentials on this platform.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
1.0.45

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.33.0

platformName
MacOS

platformVersion
17.7.0

Hey @ytomimoto , your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

Closing due to age. Please re-activate if you have repro steps and/or logs we can use to address the issue.


[Editor] Fix return of EditorTranslationParserPlugin._get_comments

Method used passed arguments as return data which does not work with extensions, switched to using a Dictionary return. This might work in extensions after fixing typed array copying, but unsure, and I think this return format is safer in any case to use, and is the standard in most of the virtual methods like this (also any binding for this will have to use const_cast as the resulting methods will pass as const TypedArray<String> &)
Follow-up to:

https://github.com/godotengine/godot/pull/98099

See also:

https://github.com/godotengine/godot/pull/92175

To illustrate the issue, this is the signature of the related _parse_file method, which is being fixed in the related PR:
        virtual void _parse_file(const String &p_path, const TypedArray<String> &p_msgids, const TypedArray<Array> &p_msgids_context_plural);

Haven't generated the headers for the current state but _get_comments will have the same signature and you need to const_cast those arguments, which is very unintuitive and fragile

I'm not familiar with the GDExtension issue, but it looks good to me as long as _get_comments() is consistent with _parse_file() (so I would prefer #92175 to be merged or at least approved first). However, I have a question:

If we decide to break _parse_file() compatibility, maybe it makes sense to combine _parse_file() and _get_comments() into a single method that returns a table (Array[PackedStringArray], Array[Array], or Array[Dictionary]) with the columns msgid, msgctxt, msgid_plural, and comment? The required column would be msgid, the others can be left blank. I don't think it makes sense to separate msgids and msgids_context_plural as it is now, because it's all a single table under the hood anyway.
If we want to maintain maximum compatibility, we could add a _parse_file_ext() method and deprecate _parse_file(). This is more related to #92175, as _get_comments() did not appear in any stable release.

That makes sense, will test some alternatives for deprecation and update as needed
I'm not familiar enough with the code here to say if merging the two methods into one is feasible, but if it is might merging the two, dropping _get_comments and deprecating _parse_file, work?
The new method could be _parse_file_and_comments or something, would be less obscure to have as a replacement maybe

I don't know how it works in C# though so confirming how the current methods work or don't work for plugins made in C# would be good

I haven't tested personally but since Arrays in C# are reference types I imagine they may work. https://github.com/godotengine/godot/pull/99195 uses the method so, assuming the PR works, it would prove that the method works in C#.
Also, how is the GDExtension validation not complaining about breaking compatibility? Does it not check virtual methods?

Also, how is the GDExtension validation not complaining about breaking compatibility? Does it not check virtual methods?

EditorTranslationParserPlugin._get_comments() is not in 4.3 stable. Only #92175 breaks compatibility, this PR can be considered as a non-breaking part of #92175.

I'm not familiar enough with the code here to say if merging the two methods into one is feasible, but if it is might merging the two, dropping _get_comments and deprecating _parse_file, work?
The new method could be _parse_file_and_comments or something, would be less obscure to have as a replacement maybe
That way we could possibly detect if _parse_file_and_comments or what we call it is bound, and otherwise call the outdated one

I guess it depends on how we handle other cases in #92175. Yes, the fact that it seems to work in GDScript and C# is an argument for deprecation instead of removal/replacement. However, I don't think EditorTranslationParserPlugin is used very often, so breaking compatibility there is more acceptable than with core APIs like Object, Node, etc.

I'll see about some options today for this and #92175

Will try investigate this properly this week


Let okbuckDebug, okbuckRelease create really debug and release BUCK config

Since v0.4.0, OkBuck will generate multi-product flavor BUCK configs, each combination of product flavor and build variant has its BUCK config.
That's all of it, no more additional support will be added.


With Existing Project instructions - server.js missing ?

This has really great potential, thanks for all the work putting it together!
The How to use Rekit-Studio with an existing project mentions Rekit npm scripts being resident in server.js with the names

startDevServer
buildDevDll
startStudioServer
startBuildServer

After using
npm Rekit create --clean my-clean-app
I can't find either server.js or the noted scripts anywhere, including in ./node_modules/rekit/
Are the instructions just out of date or am i missing something?
Thanks for you help!

Solved... rather than be literal (long day) I engaged brain and tracked down the scripts actually in use, cleverly hidden in the 'Scripts' folder.

Yeah.. Sorry for the confusion. The project boilerplate was updated to Create React App after the article. So I should have updated it.


Make Unplug\get_post also return previous and next post

Would be nice if Unplug\get_post could optionally return the previous and next posts for post navigation.

And it should also take the desired order into consideration.


[HIGH][$250] Send invoice - Category is missing in confirmation page but it is present in invoice view

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.68-0
Reproducible in staging?: Yes
Reproducible in production?: No (New feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:
Action Performed:
Pre condition:Create a new workspace and use to send Invoice

Go to staging.new.expensify.com
Go to FAB > Send invoice.
Enter amount and select a participant.
Note that "Category" is not present in the confirmation page.
Create the invoice.
Click on the preview in workspace chat.

Expected Result:
"Category" row should be present in the confirmation page if it is present in the invoice details page.
Actual Result:
"Category" row is not present in the confirmation page when it is present in the invoice details page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/6edfd22c-ecbe-4cf2-b55d-d8e9f97cf5fe

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017a0bd1ec84ee8690
Upwork Job ID:<PHONE_NUMBER>425930240
Last Price Increase: 2024-08-07
Automatic offers:

Pujan92 | Reviewer | 0
gijoe0295 | Contributor | 0

Issue OwnerCurrent Issue Owner: @Pujan92

We think this bug might be related to #wave-collect - Release 1

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Does not appear to be a serious deploy blocker to me and can be addressable by external contributors 👍

Given this is core functionality for anyone with a workspace, I'm marking it as CRITICAL as it might be needed in the demos.

@Pujan92 This is a high-priority one. Once you get proposals, can you make sure to accelerate review to get this picked up? Thank you!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistency in the 'Category' field when creating and editing 'Send Invoice'
What is the root cause of that problem?
When we send 'Send Invoice' to a user, the 'category' field appears in the 'MoneyRequestView'
What changes do you think we should make in order to solve the problem?
With this we must 'remove' the 'category' field from 'MoneyRequestView' if it is not isPolicyExpenseChat. Something like:
    const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(report);

Instead of the current one:
https://github.com/Expensify/App/blob/54d971a5a2a1155544a5e5d15b2e0103a82e8b75/src/components/ReportActionItem/MoneyRequestView.tsx#L168
What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistency in the display of the "Category" field when creating and viewing Send invoice request.
What is the root cause of that problem?
Currently, the "Category" field may appear when viewing an invoice (in the MoneyRequestView) even though it does not reflect an actual policy expense.
Root cause lies in the conditional logic determining when to display the "Category" field. The current implementation seems to be based on ReportUtils.isReportInGroupPolicy(report):
https://github.com/Expensify/App/blob/54d971a5a2a1155544a5e5d15b2e0103a82e8b75/src/components/ReportActionItem/MoneyRequestView.tsx#L168
This condition may need refinement to accurately filter out non-policy expenses.
What changes do you think we should make in order to solve the problem?
I propose we modify the logic controlling the "Category" field's visibility within the MoneyRequestView. Specifically, we can introduce the following change:
const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(report);

This refined condition will ensure that the "Category" field is displayed only when the invoice truly represents a policy expense.

@cristipaval @danielrvidal Needs confirmation regarding the expected result, Categories should be displayed for the non-policy expense chat invoices or not? Bcoz we usually show it for the policyExpenseChat only.
I am more towards @brunovjk's proposal where they suggested using the consistent condition in both places and in this case, it won't show categories in MoneyRequestView as the rootParent Report isn't of type policyExpenseChat.

In invoice confirmation step, we used a "optimistic" report, thus it is {} causing isPolicyExpenseChat to be false:

@gijoe0295 wondering why the issue is not there for the submit expense.

confirmation regarding the expected result, Categories should be displayed for the non-policy expense chat invoices or not?

I wonder the same.
I think the problem here is about inconsistency:
https://github.com/Expensify/App/blob/573d9893ae2a8e6e4ebe64088cb2fbf62ce81804/src/components/ReportActionItem/MoneyRequestView.tsx#L168
https://github.com/Expensify/App/blob/573d9893ae2a8e6e4ebe64088cb2fbf62ce81804/src/pages/iou/request/step/IOURequestStepConfirmation.tsx#L137
We need to align this. Change variable name if necessary, add/remove useMemo if necessary, ... .

Makes sense @gijoe0295. Your solution seems to work where we need to use policy.id in case the report is not available. Still, I am tagging @VickyStash to get their input on any other straightforward alternative.

confirmation regarding the expected result, Categories should be displayed for the non-policy expense chat invoices or not?

Exactly.

I think the problem here is about inconsistency
https://github.com/Expensify/App/blob/99017956d92998f3e301d6a4124669a9e5e44d93/src/components/ReportActionItem/MoneyRequestView.tsx#L168
https://github.com/Expensify/App/blob/99017956d92998f3e301d6a4124669a9e5e44d93/src/pages/iou/request/step/IOURequestStepConfirmation.tsx#L137

@Pujan92 the expected behavior is that the individual sending the invoice would see the category field as the invoice is owned by their workspace. But the individual receiving the invoice should not. Does that make sense? Let me know if I can answer anything else.

Thanks @danielrvidal.
We can proceed with @gijoe0295's proposal as their solution will fix the issue. cc: @cristipaval
🎀👀🎀 C+ reviewed

Proposal
Updated
Standardize how we handle isPolicyExpenseChat across both creating and viewing reports, ensuring consistent behavior throughout.

@Pujan92 I was updating my proposal, can you give me some feedback there? Thank you very much.

@gijoe0295 can you make sure to prioritize this one tomorrow? We need this to be fixed asap so if it could be deployed to staging tomorrow that would be best. Thank you!

@gijoe0295 will you raise a PR soon or facing any issues?

Thanks :)

However, seems like the BE currently does not support these params in SendInvoice API. I tried to enable and set those fields in the FE, the payload was correct but SendInvoice just returned empty for those fields.

@cristipaval Can you plz confirm whether the SendInvoice API is accepting these extra params(category, tax, ..) or not?

Ah, Ok. As all those fields appear when isPolicyExpenseChat is true we need to apply this logic to all components.
Better if you share the payload here which @cristipaval can check and confirm with the backend.

The tag, taxRate, and taxCode parameters can be left blank. These are parameters that we display in the UI of NewDot.

Got it. Yeah, we will want to provide the ability for users who create an invoice to add and edit tags and taxes rates when they become available in the product. So I agree with your approach.

Sorry to clarify, we shouldn't wait for the changes in BE. We should temporarily disable the fields mentioned. We can re-enable them when they become available.

Sorry to clarify, we shouldn't wait for the changes in BE. We should temporarily disable the fields mentioned. We can re-enable them when they become available.

@cristipaval @davidcardoza As @gijoe0295 mentioned here, in case we disable those fields(tag, tax) then it may show the RBR(violation) to the user if any of them is mandatory and user can't fix that due to we are hiding/disabling those fields.
If we can't put this on hold till the backend changes then the option which looks more feasible to me is

Hide these fields in the Confirmation screen of the Send invoice flow
In the money request view show these fields and let user update as that API works

Let us know your thoughts to proceed

If we can't put this on hold till the backend changes then the option which looks more feasible to me is

Hide these fields in the Confirmation screen of the Send invoice flow
In the money request view show these fields and let user update as that API works

This approach makes sense. Once the fields become available in the product, we will include them in this send invoice workflow and stop hiding them. However, our immediate priority is to perfect the invoice flow to meet our internal deadline. For now, let's hide these fields in the confirmation screen for the send invoice flow. In the money request view, however, we will display the fields.

Thanks @davidcardoza for the confirmation.
@cristipaval PR is ready for your review.

@gijoe0295 could you please quickly reopen a PR?

Payment summary
@Pujan92 Reviewer $250 - paid ✔ - please complete the checklist :)
@gijoe0295 Contributor $250 - paid ✔

Making this one Weekly, because @Pujan92 is ooo

@Pujan92 looks like you're back, hope you had a good holiday! Could you please complete the checklist when you get the chance?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/40015
[X] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: - https://github.com/Expensify/App/pull/40015#issuecomment-2149902531
[X] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[X] [@Pujan92] Determine if we should create a regression test for this bug. Yes
[X] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Press FAB and select the Send invoice option
Select any participant and a Collect workspace with categories enabled
Verify in the confirmation screen that the Category menu shows and you can select a category

Thanks!

Reopening this issue as this is reproducible again:

CC @sonialiap @davidcardoza

@davidcardoza could you please update the criticality of this one?

Not overdue, Melv. We just reopened this one.

friendly bump, @davidcardoza

Moved this issue criticality to HIGH

Added Help Wanted label on it to get proposals again on it.

@Pujan92 could you please review the proposed solution?

const isPolicyExpenseChat = iouType === CONST.IOU.TYPE.INVOICE || participants?.some((participant) => participant.isPolicyExpenseChat;

@gijoe0295 Instead of considering the type invoice report for isPolicyExpenseChat, how about if we bypass the isPolicyExpenseChat check for the shouldShowCategories?
(isTypeInvoice || isPolicyExpenseChat)
https://github.com/Expensify/App/blob/9f1faaf8813ad874c5bf93dea4e985fd84160390/src/components/MoneyRequestConfirmationList.tsx#L251

Cool, I suggested that because currently isPolicyExpenseChat logic varies in different places.
@cristipaval we can proceed with @gijoe0295.
🎀👀🎀 C+ reviewed

Thanks @sonialiap! @gijoe0295, you're good to go 🚀

@sakluger I'm OOO Aug 19-30, adding leave buddy.
Status: waiting for build

The automation didn't kick in so I will pretend to be melvin 🤖
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.22-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/47474

If no regressions arise, payment will be issued on 2024-08-27. :confetti_ball:
For reference, here are some details about the assignees on this issue:

@Pujan92 requires payment through Upwork: Offer link
@gijoe0295 requires payment through Upwork: Offer link

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@Pujan92] Determine if we should create a regression test for this bug.
[ ] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I'm going to be offline Aug 27-29 so I'm going to assign another BZ member to handle payment.

@Pujan92 can you take care of the checklist here? Thanks!

@greg-schroeder I completed this earlier here for the issue and it remains same. Let me know if I need to post the same here again.

@Pujan92 Oops, sorry, I missed that! I was just picking this up for Sasha so I am catching up here. :)
That's fine, no need to go again

Just a moment, here -- @Pujan92 perhaps you can help explain. It seems this was completed back in May/June, but the issue re-surfaced and the same two folks were involved as Contributor/C+.
Was this a regression, or was an entirely new solution required? Why was this project basically re-done a couple of months later? Perhaps a quick explanation would be helpful for me

@greg-schroeder Our earlier PR changes were partially modified in this PR to fix issue https://github.com/Expensify/App/issues/41931, due to that the issue re-surfaced again. Now while checking I can see that deployblocker was somewhat connected to regression from our PR but we didn't notify and weren't aware of that. So when this issue occurred again we opened it for the external contributors to put proposals.

Hmm, okay. That is a bit tricky.
Let's get a few more eyes on this. Hey @cristipaval - do you mind weighing in on this one? Do you view it as a regression or a separate issue with a unique solution?

@greg-schroeder back from OOO so can take this back, feel free to stay on or unassign yourself

@cristipaval bumping Greg's question here https://github.com/Expensify/App/issues/41281#issuecomment-2311601852 regarding whether you think this is a recession or a separate issue with a unique solution?

Cristi is on parental leave. I'm going to review this tomorrow to see if we can close without his input

Apologies, I must have accidentally closed the tab and lost the issue. Thanks for the ping

@youssef-lr could you help assess whether there was a regression here? Christi is on parental leave and I'm getting lost in the code.
This issue here was solved with PR 41723, then your PR 41945 changed the solution, this caused the issue to resurface and the GH issue was reopened. A new PR, 47474 was pushed and needs payment. The resurfaced issue was not flagged as a regression. Comment from the C+. Do you think there was a regression caused by https://github.com/Expensify/App/pull/41723/ ?

This is ready for payment, we just need to figure out whether there was a regression. @youssef-lr bumping my question from above in hopes that you can help https://github.com/Expensify/App/issues/41281#issuecomment-2352739869

It looks like it was a regression indeed @sonialiap

Thanks for checking, Youssef!
@Pujan92 @gijoe0295 because this latest PR was a fix for a regression on this issue, it does not qualify for additional payment. Had this been caught within the regression period then the payment would have been decreased but since it popped up a month later, you received full payment for the first fix and nothing needs to happen at this point. Thank you for quickly addressing the regression!


Links broken in left nav bar

Under references in the left nav bar, the links for Python, Node.js, and Go are broken.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 726adac9-1848-01a6-9586-842c81f820f7
Version Independent ID: 249db438-8c95-8e69-f69e-8e48fcd0b359
Content: Azure Services that support managed identities - Azure AD
Content Source: articles/active-directory/managed-identities-azure-resources/services-support-managed-identities.md
Service: active-directory
Sub-service: msi
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@Sheeler thanks! I'm assigning this to the author as I don't have write access to the side panel.

Fixed.
#please-close


Fix for Keras 2.1 : num_class is now num_classes for DirectoryIterator

Hello Antoine,
thank you for sending the PR. I think I will be able to merge it by the end of this week and update the README, as I am re-testing all the notebooks with Keras 2.1 and the latest versions of the backend engines.

Hi,
Forgot to mention that there is a fix currently waiting in Keras and it will also be needed in order to be able to use Keras 2.1 and Theano 1.0
https://github.com/fchollet/keras/commit/e0d9fcb91ad4cd8d993c3225cda508a30b3095b9
Currently this fix is needed in order to be able to use the first lesson with the last versions of Theano and Keras.
I've not looked into the others notebooks for now :-)

Thanks for letting me know. In this case I think it makes sense for me to postpone the review activity until after the Keras fix is released.

I agree

I believe it has been released now.

I plan to release a revision of the notebooks for Keras 2.1 in January. Thanks for your interest.


Selecting data points doesn't work anymore in ncp 0.2.1

Hi Laura @lazigu, hi all,
I was just excited about the new version and tested it. Unfortunately, selecting data points in the plot doesn't work anymore. :-(
Here is what I did:

Install napari, napari-clusters-plotter, napari-segment-blobs-and-things-with-membranes, napari-pyclesperanto-assistant
I opened File > open examles > clesperanto > blobs (from ImageJ)
I segmented it using Tools > Segmentation / labeling > Voronoi Otsu Labeling (nsbatwm) using paramerters spot_sigma=4 and outline_sigma=2.
I measured the properties of these blobs using napari-clusters-plotterMeasure now (with neighborhood data)
I started the plotter from the menu Tools > Measurement > Plot Measurements (ncp) and selected area versus mean intensity as shown in this video:

https://user-images.githubusercontent.com/12660498/147076112-9108ec36-8de1-4265-b76b-5d8830cc0bd1.mp4
As you can see, the selection of data points doesn't work anymore. Let me know if there is anything I can do to help fixing it. :-)
Best,
Robert

Update: It was my fault! :-)
It does work in the current napari release 0.4.12, but it does not work in the current development branch (napari-0.4.13.dev139+g3069f2dc). Thus, forget what I said. We just need to check everything carefully when the next napari release is in sight.
Happy Holidays!
Robert

Hi Robert @haesleinhuepf ,
Ahh thanks a lot! Scared me for a second that this new release is with such a major bug even though I thought I tested it thoroughly :D
We will keep it in mind for the next napari release then!
Happy holidays to you too!
Laura

Sorry for the scaring second :-)

No worries! Let me know if there are any other bugs that I might have missed :)

I'm reopening this issue because it doesn't work in napari 0.4.13rc1, which was just published. I think we still have some days until napari 0.4.13 releases. Hence, not super urgent. But we should dig into this... :-)
Try it out using
pip install napari==0.4.13rc1

@lazigu @Cryaaa @zoccoler

Thanks a lot for letting me know, Robert @haesleinhuepf.
I will get to work on it today or tomorrow.


Could you release the checkpoint of reward models?

Could you kindly release the checkpoint of the reward models trained for ultrafeedback and helpsteer? That would be great help to our evaluation. Thank you!

Thanks for the interest -- I made some modification to the standard huggingface sequence classifier. Let me see how to push it to HuggingFace so users can easily run it.
I will ping you here once it's done.

Hi @srzer,
I just released the reward model at https://huggingface.co/Haoxiang-Wang/RewardModel-Mistral-7B-for-DPA-v1
It has 10-dimensional output, corresponding to the following attributes from HelpSteer and UltraFeedback
['helpsteer-helpfulness', 'helpsteer-correctness', 'helpsteer-coherence', 'helpsteer-complexity', 'helpsteer-verbosity', 'ultrafeedback-overall_score', "ultrafeedback-instruction_following", "ultrafeedback-truthfulness", "ultrafeedback-honesty",                              "ultrafeedback-helpfulness"]
Here is a sample code that you can try
from transformers import AutoModelForSequenceClassification,AutoTokenizer
import torch
device = 'cuda:2'
path = "Haoxiang-Wang/RewardModel-Mistral-7B-for-DPA-v1"
rm = AutoModelForSequenceClassification.from_pretrained(path, trust_remote_code=True).to(device)
tokenizer = AutoTokenizer.from_pretrained(path)

input_template = "[INST] You must read the following conversation carefully and rate the assistant's response from score 0-100 in these aspects: helpfulness, correctness, coherence, honesty, complexity, verbosity\n\nUser: {prompt}\n\nAssistant: {response} [/INST]"

# Use a sample from HelpSteer validation set
prompt = 'What are some synonyms for the word "beautiful"?'
response = "Nicely, Beautifully, Handsome, Stunning, Wonderful, Gorgeous, Pretty, Stunning, Elegant"

model_inputs = tokenizer(input_template.format(prompt=prompt, response=response), return_tensors="pt").to(device)
with torch.no_grad():
    score = rm(**model_inputs).logits.squeeze().cpu().float().numpy()

print(score)
# [68.99269  69.62718  76.23071  33.48785  35.853596 63.833366 55.58917 68.7175 59.552124 46.465595]

# Convert from our scale (0-100) to HelpSteer scale (0-4)
helpsteer_rewards_pred = (score[:5]-10)/20
print(helpsteer_rewards_pred)
# [2.9496346 2.981359  3.3115356 1.1743925 1.2926798]
# The actual rewards from the HelpSteer dataset for this sample are [3,3,4,2,2]

I will update the README later and add a demo jupyter notebook. Let me know if you encounter any issue when using this reward model!

Great! I will try it later


v15.0.0 global refactoring

[Current coverage][cc-pull] is 99.45%

Merging [#352][cc-pull] into [master][cc-base-branch] will increase coverage by +0.26%

File .../Model/CellModel.php was modified. more

Misses -1
Partials 0
Hits +1

@@             master       #352   diff @@
==========================================
  Files            24         24
  Lines           366        365     -1
  Methods          77         77
  Messages          0          0
  Branches          0          0
==========================================
  Hits            363        363
+ Misses            3          2     -1
  Partials          0          0

Powered by Codecov. Last updated by [8577c97...7a2a429][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/8577c97419b274388315e203039e41daf4f5db3e...7a2a42950e0e64106a0fa9380c66c2333b77cdf5
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/352?src=pr


Certain python errors cause the code to just freeze

(Reported at https://developercommunity.visualstudio.com/content/problem/109407/certain-python-errors-cause-the-code-to-just-freez.html)
When debugging python code, some errors (most recently an undefined variable) result in python just freezing. The debugger shows it as still running, but nothing is happening. If I run the code by choosing "Starty without debugging" I'll see the exception message.

I'm trying to repro by working on bugs that require writing Python instead of C#, but I don't like my odds already.

I wonder if this is the same as #2707 (reported by the same user). Might just have to close it as not-enough-info (again).

There is not enough information for us to work on this issue. Please let us know if you have a piece of code that reproduces reliably on more than one machine so we can try and track it down from that.


implement recaptcha

As in the title. This PR Introduce a Google reCAPTCHA Into the Create New Item form. This small, partial solution is one minimal layer to try to prevent bots from using the demo site but without having the sketchy and cumbersome signup/login solution that the original site had, which deterred visitors from easily accessing the site.

implement recaptcha
refactor the React component
update readme
introduce a changelog to the project
I also added prettier to vsc so there is some (intended) autoformatting (like using single quotes, which is not the default prettier setting but it should be)

this isn't deployed currently b/c: https://github.com/rkraeher/inventory-tracker/issues/14


Compress/bundle data not working

The functionality to bundle data to a tar or zip archive is currently not possible. When trying to do this via the Compress/bundle data tab an error message saying that there is not enough space (rootResc selected) on the resource is displayed (see screenshot).

I believe lack of space reporting is no longer an issue, but I still don't think an archive is made.

Extracting larger files (350GB was tested) resulted on an error similar to that seen in Issue #8.  This is likely the same error and related to an iRODS/PRC bug.  If the functionality is otherwise acceptable, I think this issue is resolved.


⚠ Bofrost.nl has degraded performance

In 0ea51db, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 7283 ms

Resolved: Bofrost.nl performance has improved in 8cc8b23 after 9 minutes.


adopt polygon.io changes

Is your feature request related to a problem? Please describe.
Polygon.io discontinue direct integration w/ Alpaca,
Describe the solution you'd like
need to switch to using Polygon.io SDK, when using Polygon.io.
Additional context
Add any other context or screenshots about the feature request here.

will be released as major version 1.0

released to master pending documentation and further tests prior to release as 0.1.0

version 0.1.00 release!


fix: race condition on Controller.Satisfied

This PR is a proposal to add mutex.Lock on Controller.Satisfied to solve a race condition that can arise when two goroutines are involved in checking whether mock conditions have been satisfied.
The use case is illustrated in the sample/concurrent package - what I'm hoping to accomplish is where the test scenario contains one goroutine that runs indefinitely that calls mocked functions, I would like to use Satisfied as one of the conditions to trigger test assertions.
Tests added in sample/concurrent fails data race check without this change:
$ go test -race go.uber.org/mock/sample/concurrent
==================
WARNING: DATA RACE
Read at 0x00c000156350 by goroutine 9:
  go.uber.org/mock/gomock.(*Call).satisfied()
      /Users/dave/work/src/mock/gomock/call.go:307 +0x204
  go.uber.org/mock/gomock.callSet.Satisfied()
      /Users/dave/work/src/mock/gomock/callset.go:157 +0x247
  go.uber.org/mock/gomock.(*Controller).Satisfied()
      /Users/dave/work/src/mock/gomock/controller.go:249 +0x244
  go.uber.org/mock/sample/concurrent.waitForMocks()
      /Users/dave/work/src/mock/sample/concurrent/concurrent_test.go:35 +0x247
  go.uber.org/mock/sample/concurrent.TestCancelWhenMocksSatisfied()
      /Users/dave/work/src/mock/sample/concurrent/concurrent_test.go:85 +0x33b
  testing.tRunner()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1629 +0x47

Previous write at 0x00c000156350 by goroutine 10:
  go.uber.org/mock/gomock.(*Call).call()
      /Users/dave/work/src/mock/gomock/call.go:433 +0x611
  go.uber.org/mock/gomock.(*Controller).Call.func1()
      /Users/dave/work/src/mock/gomock/controller.go:220 +0x5d6
  go.uber.org/mock/gomock.(*Controller).Call()
      /Users/dave/work/src/mock/gomock/controller.go:225 +0xcd
  go.uber.org/mock/sample/concurrent/mock.(*MockMath).Sum()
      /Users/dave/work/src/mock/sample/concurrent/mock/concurrent_mock.go:43 +0x16d
  go.uber.org/mock/sample/concurrent.TestCancelWhenMocksSatisfied.func1()
      /Users/dave/work/src/mock/sample/concurrent/concurrent_test.go:76 +0x4c

Goroutine 9 (running) created at:
  testing.(*T).Run()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1629 +0x805
  testing.runTests.func1()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:2036 +0x8d
  testing.tRunner()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1576 +0x216
  testing.runTests()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:2034 +0x87c
  testing.(*M).Run()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1906 +0xb44
  main.main()
      _testmain.go:51 +0x2e9

Goroutine 10 (running) created at:
  go.uber.org/mock/sample/concurrent.TestCancelWhenMocksSatisfied()
      /Users/dave/work/src/mock/sample/concurrent/concurrent_test.go:74 +0x324
  testing.tRunner()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /usr/local/Cellar/go/1.20.3/libexec/src/testing/testing.go:1629 +0x47
==================

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@sywhang any chance we could cut a new release containing this fix / several others in the main branch? I see an issue to fix release actions: https://github.com/uber-go/mock/issues/88, if that is a blocker I'm happy to help if you can provide a description of what you're looking for? Thanks!


RxMoya handle error and result

I want to have a result observable and an error observable that I can bind to a UI component for an API call.
The following code is in a ViewModel. I have to subscribe the provider inside a flatMap. So, I can bind the result/error BehaviorRelay to the View.
Is this the correct way?
self.dummy = Observable.combineLatest(Para1, Para2){a, b in
            return (a, b)
            }.flatMap{ (arg) -> Observable<TargetType> in

                let (startDateStr, endDateStr) = arg
                return Observable.just(ATarget)

            }.flatMap{ [unowned self](target) -> Observable<Void> in

                self.provider.rx.request(target as! PurchaseTarget)
                    .subscribe{ event in
                        switch event {
                        case .success(let response):

// Give the data to a BehaviorRelay
                            self.result.accept(purchaseModel)

                        case .error(let error):

// Give the data to a BehaviorRelay
                            self.errors.accept(Error)
                        }
                    }.disposed(by: self.rx.disposeBag)

                return Observable.just()
        }

And then subscribe this dummy observable
self.dummy.subscribe(onNext:{ _ in}).disposed(by: self.rx.disposeBag)

Hi @ZZHHAANNGG
I like to "map" errors as a state, so I probably would do something like this
enum ViewState {
    case purchased(model: PurshadedModel)
    case purchaseFailed(error: Error)
}

Observable.combineLatest(Para1, Para2) {a, b in
    return (a, b)
}.flatMap { (arg) -> Observable<Response> in
    let (startDateStr, endDateStr) = arg
    let target = ATarget() //Creates Moya target type
    self.provider.rx.request(target)
}.map { response -> ViewState
    let model = // map response into PurshadedModel
    return ViewState.purchased(model)
}.catchError { error -> Observable<ViewState> in
    return ViewState.purchaseFailed(error)
}.subscribe(onNext { viewState in
    //Binds viewState which can be a purchased or an error into the view
}).disposed(by: bag)

but if you still want to use the BehaviorRelay, I would recommend something like this
Observable.combineLatest(Para1, Para2){a, b in
    return (a, b)
}.flatMap{ (arg) -> Observable<TargetType> in

    let (startDateStr, endDateStr) = arg
    return Observable.just(ATarget)

}.flatMap{ [unowned self](target) -> Observable<Response> in
    return self.provider.rx.request(target as! PurchaseTarget)
}.subscribe{ event in
    switch event {
    case .success(let response):
// Give the data to a BehaviorRelay
        self.result.accept(purchaseModel)

    case .error(let error):

// Give the data to a BehaviorRelay
        self.errors.accept(Error)
    }
}.disposed(by: self.rx.disposeBag)

// now you can subscribe into self.result and self.errors

Note that I didn't test this code in Xcode.

Hi @pietrocaselani
Your approach is more elegant to handle the errors from the Provider. The reason why I need to subscribe the provider is when the provider returns an error, seems like the stream is terminated. So I do not know whether I can use map for the response and the catchError for the error.

"is when the provider returns an error, seems like the stream is terminated"

This is the correct and expected behavior. If any unhandled error occurs in the stream, the stream is terminated. And I believe the same will happen if you "publish" an error to the subject, so that is why I recommended to handle and map an error a view state.

@ZZHHAANNGG  any updates?
Otherwise, since this is a duplicate issue (see here), we probably should close this issue too!

@pietrocaselani  I like your approach better. I was trying to use your approach below. But, I had an issue, if I use two BehaviorReply to separate the data and errors, then I can bind those data to either a UITableview or a UILabel.  For example,
ViewModel.tableviewBehaviorReply.bind(View.tableview...)
ViewModel.errorBehaviorReply.bind(View.errorLabel...)

However, if I wrap the actual data and error in an enum, seems like I have no way to use binding to a UITableView in View.  With that being said, I have to subscribe this Observable,  and extract the data or error and manually set to either a component or a error label. How would you do in this case?
Observable.combineLatest(Para1, Para2) {a, b in
    return (a, b)
}.flatMap { (arg) -> Observable<Response> in
    let (startDateStr, endDateStr) = arg
    let target = ATarget() //Creates Moya target type
    self.provider.rx.request(target)
}.map { response -> ViewState
    let model = // map response into PurshadedModel
    return ViewState.purchased(model)
}.catchError { error -> Observable<ViewState> in
    return ViewState.purchaseFailed(error)
}.subscribe(onNext { viewState in
    //Binds viewState which can be a purchased or an error into the view
}).disposed(by: bag)