Angular Material CDK scrolling - Display a million items is not working...

How to Reproduce:

Take the first example from https://material.angular.io/cdk/scrolling/examples open it in stackblitz an display 1 Mio instaed of 100,000
Scroll down to the end. The last item displayed is 213,043

Cause:

Maximum height of single Elements in Browsers

Possible Solution:

Use more than one element inside the ViewPort to render Items

Hi @Hopfenspirger,
It is showing all 100,000 records.

Was there ever a solution found to this? I'm encountering the same issue & my dataset involves elements with >1M.

This is actually a navigator limitation(values), i cant see a easy way to solve this, maybe if you create constants with the height limit per browser we can do some handling. But what would it be? any ideas @crisbeto @mmalerba

I looked into this at one point and its pretty tricky. IIRC its not just height that breaks down, but scrollTop as well. Even if I used multiple elements for the spacer, I couldn't figure out a good method of figuring out where the user was scrolled to

I played with the the example in stackblitz. I changed the itemSize to 1 and removed appendOnly. It's a temporary fix. https://stackblitz.com/edit/angular-eb1m1s?file=src/app/cdk-virtual-scroll-append-only-example.ts. I'll dig deeper and see if I can figure out what might be the underlying problem.

Idk, the limitation continue, change de size array de 10kk to 50kk and u can see what happening, the last item will be "Item #33554133" the exact chrome height limitation. And also this virtualization is kinda weird, if u set de itemSize to 1px the item-list should 1px as well, but actually have 50px so the virtualization is rendering 50x more than necessary.

 It seems to be ok here.

Try with 50kk instead of 10kk, another way to check something is wrong and open the count inspector what is rendered "document.getElementsByClassName("example-item").length", the result will be 400 items 50x more than correct , which should be 8 items.


Colorize and simplify status output

I got a bit annoyed by the current status output.

While it sort of works, it's not too nice to look at and a little annoying to read and understand.
So I reworked it with a human user in mind. The terminal output should not be parsed by machines; that's what we have the JSON output for. That said, we might introduce a third output in the future that is closer to the old output which allows for easier grepping.
The new summary is more compact:

The error output also got a revamp and is closer to the the output of ripgrep now:

Let me know what you think. Also a code review would be great. 😊

It is about the summary only, right?
Actually, while this is a question of personal taste, I like the multi-line summary more: I see the numbers much quicker in it compared to the one-liner and e.g. the excludes are IMHO an important value when I look at the summary at all (during testing and debugging mostly, else the red/failed URLs are all I'm interested in).

Actually, while this is a question of personal taste, I like the multi-line summary more: I see the numbers much quicker in it compared to the one-liner

It's true that once you get used to it, the old status output was easily readable. However we might be biased because we've been using the tool for quite a while. 😆
What I don't like is that lychee is pretty much the only cli tool that uses dashes as separators for the headline.

the excludes are IMHO an important value when I look at the summary at all

That didn't change, no? We still show the number of excludes (if any).
Overall I'd say the proposed output is better for newcomers and "casual" users. We could print more info (including the detailed summary) by increasing the verbosity level.

That didn't change, no? We still show the number of excludes (if any).

Ah sorry, you're right, I think I expected a "0 Excluded" in the last image, but in the one above it is pretty clear 👍.
About one-line vs multi-line: Having <icon> <text> <count> in a single line makes everything pretty clear to me that these three are related to the same info on first view and one knows where to look at for icon text and count on the other lines. Having everything in one line for me makes it more difficult to find and associate these three elements for each info. Could be biased but I look at a lot of different command line outputs throughout the day and less lines usually don't make things better for the human reader, at least not for me 😉.
But this is not a blocker at all from my end. As said, usually you want the failed inputs and URLs, that's all, and those are listed pretty clear. And whether it takes a microsecond longer or shorter for me to verify whether URI numbers are as expected doesn't really matter. Just as you asked for feedback and stated that "it's not too nice to look at and a little annoying to read and understand", for me it isn't/wasn't annoying to look at or hard to understand.
Hard to get feedback from newcomers or generally more users on GitHub, that would indeed help for such visual format decisions which are either affected by accustoming or individuality 🤔.

Compact format (default)

Detailed format (--format=detailed)
This one is similar to our old format.

Markdown format (--format=markdown)

This one is really useful for error reporting on Github such as through lychee-action. Here's the rendered version:

@MichaIng I've added --format=detailed to keep supporting the old format.
Apart from that, I'd say the change is ready to ship if there are no objections.

Also just realized that you're trending on Github @MichaIng. 😄

Oh, --format=detailed wasn't necessary just for me, but many thanks for implementing it 🙂. --format=markdown is pretty welcome for everyone who creates GitHub issues from the result 👍.

Also just realized that you're trending on Github @MichaIng. 😄

Nice, I didn't see that one, thanks for sharing. Especially the "POPULAR REPO: DietPi" makes me proud 👏.


chore: correct shell syntax in aws nightly teardown

Fixes nightly aws teardown logic.

[x] Well-formatted commit messages
[x] Rebased/mergeable
[x] Tests pass

This LGTM. From the successful run it looks like we could delete multiple IDs in a single call, which could be a nice optimization in the future

If I understand you correctly, this is already occurring -- any instances with a Name tag bearing a date equal to or lesser (earlier) than "yesterday" will be terminated.

If I understand you correctly, this is already occurring -- any instances with a Name tag bearing a date equal to or lesser (earlier) than "yesterday" will be terminated.

The end result is the same, but the implementation details don't match. The current script invokes the ec2 terminate-instances command once per VM. We could refactor into a single call like:
aws ec2 terminate-instances --instance-ids <id1> <id2> ...

Because --instance-ids supports multiple args.
It probably won't matter or be noticeable unless we reach a point where we're trying to delete a very large number of VMs, so I think this is good to go as-is.

Ah, I see. I do like that. I leave as-is, but I have plans to refine perftests in general and will add this to the list


return 400 when error came from Joi

returning 500 from a validation for an API request does not make sense. instead we should return 400

https://github.com/vandium-io/vandium-node/pull/32/commits/a4760eff3a53b124cf20c9d4f04633402feaa0fa#diff-a06118553824189de7a34ee654aace3aR20
         if( result.error ) {

-            throw result.error;
+            throw { statusCode: 400, name: result.error.name, message: result.error };

should you be setting the error message as the error object?😐
shoutout to: @richardhyatt 🎅🏿

I've reverted the code back to the original state and moved the setting of statusCode to 400 to the event handler that processes api gateway events.

Now merged into the 4.x release if you would like to verify that it works as intended. Thanks

@richardhyatt I'll try it out soon and let you know if it works

It works👍🏿👍🏽👍🏻👩🏿👩🏽👩🏻🙆🏿🙆🏽🙆🏻
Here is video evidence🎥✅


feat: port the startup script to cloudinit

As users might would like to provide their own startup script instead (see #41), we should move the commands that we execute in the startup script to cloudinit.
This would not break any existing functionality (running a chown on the new GCE persistent disk mount) and allows a user to bring its own startup script.

Closed in #74


[FEAT] Remove shadowing variable redefinitions

Describe your feature
Selene goes wild due to lots of 'shadowing variable'
Implementation Details
You could silence selene, however keeping track of what is already defined shouldn't be too hard in Codegen

This is similar to #22 in that it resolves issues with linters. This is low priority and the easiest solution is to disable linters with a comment, which we'll do in 0.3.

We've gone ahead and silenced the linters in 0.3.1. Please note that I'll keep this issue open to remove shadowing down the line - but as @jackdotink mentioned it is low priority.

The actual bug of zap shadowing should've been fixed in 0.6.3. If that doesn't make selene happy please just reopen this issue.


democracy page bricked if proposal state changes

If the state of proposals changes while on the democracy page, closing and opening again will load forever
reproduce:

open democracy page
change proposal state (i.e. bump into approved or superseded)
close democracy page
open democracy page: spinner forever
close democracy page
enable developer mode and trigger state invalidation
open democracy: works!

killing the app after 4 and opening again resolves the issue as well

Hmm, this is surprising, I will double-check, but the democracy page shouldn't know any state and be completely fresh after closing and re-opening.


Save Position of Bunkers

Mods: RHS
The Bunkers loose their position after loading persistend savegame

yes, it is a known bug, but the reason for this is still unknown

Barbolani77, first off. Great GREAT script. We LOVE your stuff.
You ever check out inidbi2 for saving variables instead of the namespace?


Consider react-slingshot case

Fixes #2

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          30     31    +1
  Branches        3      4    +1
=====================================
+ Hits           30     31    +1

Impacted Files
Coverage Δ

src/utils.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641bc77...f9abeed. Read the comment docs.


Element id (e.g. creator_id, mapping_tool_version):
(Must be lower case and contain only letters and underscores.)
curation_rule

Value data type (e.g. URI, URL, text, xsd:boolean):
EntityReference (URI/CURIE)

Description
See #150 for wider context.
A curation rule is a (potentially) complex condition executed by a human curator that led to the establishment of a mapping. Curation rules often involve complex domain-specific considerations, which are hard to capture in an automated fashion.
Constraints

Should only be recorded in conjunction with mapping_justification: HumanCurated.
Should be recorded with a term from a controlled vocabulary

Examples
https://github.com/mapping-commons/disease-mappings/issues/16

Has this element been implemented? Will it be available in 1.0?

Unfortunately this was not planned for 1.0, but 1.1. Can you outline why you would need it more quickly? What use case are you thinking of using it for?

Hi! No hurry.
We'll discuss this point next week around D2KAB project's use cases and come back to you with further elements. We'll see in particular if values from a controlled vocabulary would fit, not quite sure...

We have been curating some examples for these, but I don't think the vocabulary should be standardised - there is a wide space of curation rules, and many can get very specific for any given ontology. Here we are discussing some very concrete examples: https://github.com/mapping-commons/disease-mappings/issues/16

What is the status of curation_rule in the current SSSOM specification? As far as I can see, it has not been introduced in the model. Is there any plan for this?

I am not 100% convinced by the statement "Should only be recorded in conjunction with mapping_justification: HumanCurated."
Wouldn't rules be relevant with e.g. semapv:BackgroundKnowledgeBasedMatching or semapv:LogicalReasoning?

Hi,
our curation rules are short texts. For now, they look like this :
Rule 3 is about abiotic stress and tolerance of the plant to metal toxicity.
metal + toxicity (WTO) <-> metal + tolerance  (CO321)

Example:
Aluminium toxicity (WTO:0000450) <-> Aluminium tolerance (CO_321:0000079)

or this one, that has subrules :
Rule 1 is about biotic stresses. WTO defines general trait classes of response to pests and disease for WTO. CO_321 defines traits about the observable degree of affection. The observation may be done on the whole plant, or a subpart of it.
We consider that the user of the information retrieval function, given a pathogen or a disease, would like to retrieve all data, independently of the way the affection is observed. As a consequence, the retrieval terms score, incidence, severity, response, index, coefficent, progress curve and resistance are considered as similar.

1.1 Score
resistance + ’name of disease’ (WTO) <-> ’name of disease’ + score (CO321)

Example from CO_321 : Septoria score on leaf  (CO_321:1010036)
And from WTO : resistance to Septoria Leaf Blotch (WTO:0000554)

The score is a direct measure on the plant. It is usually a discret number between 0 an 6 or 10.

In short term, I'd like to use the "curation_rule" element and find the best way to publish the rules. For now I see two possibilities :

Record the rules in a document that would go with the mapping dataset and reference the rules in the SSSOM representation using the codes (eg 1.1 or 2 in my examples above)
Publish each rule as a RDF resource (= nanopublication?) and reference it with its URI in the SSSOM representation of our mappings. But what would be the type for these resources? Maybe SEMAPV could provide a definition of a "MappingRule" class?

Thank you for your comments @saubin78 - I am in a deadline mode atm, but will get to this soon!

This is still top of my list @saubin78 - sorry about the delay.


Help, how do I enable CORS on the new TRPC endpoint?

It has recently changed, and now doesn't have NextRequest or NextResponse.
import { fetchRequestHandler } from "@trpc/server/adapters/fetch";

import { appRouter, createTRPCContext } from "@kdx/api";

export const runtime = "nodejs";

// export API handler
const handler = (req: Request) =>
  fetchRequestHandler({
    endpoint: "/api/trpc",
    router: appRouter,
    req,
    createContext: () => createTRPCContext(),
  });

export { handler as GET, handler as POST };

import { fetchRequestHandler } from "@trpc/server/adapters/fetch";

import { appRouter, createTRPCContext } from "@kdx/api";

const handler = async (req: Request) => {
  const response = await fetchRequestHandler({
    endpoint: "/api/trpc/edge",
    router: edgeRouter,
    req: req,
    createContext: () => createTRPCContext({ req }),
    onError: ({ error, path }) => {
      console.log("Error in tRPC handler (edge)", path);
      console.error(error);
      console.error(error.cause ?? "No cause");
    },
  });

  // configure cors
  response.headers.set("access-control-allow-origin", "*");
  response.headers.set("access-control-allow-headers", "*");
  response.headers.set("access-control-allow-methods", "*");
  response.headers.set("access-control-allow-credentials", "true");

  return response;
};

export { handler as GET, handler as POST };

import { fetchRequestHandler } from "@trpc/server/adapters/fetch";

import { appRouter, createTRPCContext } from "@kdx/api";

const handler = async (req: Request) => {
  const response = await fetchRequestHandler({
    endpoint: "/api/trpc/edge",
    router: edgeRouter,
    req: req,
    createContext: () => createTRPCContext({ req }),
    onError: ({ error, path }) => {
      console.log("Error in tRPC handler (edge)", path);
      console.error(error);
      console.error(error.cause ?? "No cause");
    },
  });

  // configure cors
  response.headers.set("access-control-allow-origin", "*");
  response.headers.set("access-control-allow-headers", "*");
  response.headers.set("access-control-allow-methods", "*");
  response.headers.set("access-control-allow-credentials", "true");

  return response;
};

export { handler as GET, handler as POST };

That was fast! Thank you <3

I still keep getting this error:
Access to fetch at 'http://localhost:3000/api/trpc/post.all?batch=1&input=%7B%220%22%3A%7B%22json%22%3Anull%2C%22meta%22%3A%7B%22values%22%3A%5B%22undefined%22%5D%7D%7D%7D' from origin 'http://localhost:3001' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
I tried to add
if (req.method === "OPTIONS") {
    const responseHeaders = {
      "Access-Control-Allow-Origin": "*", // Allow requests from any origin
      "Access-Control-Allow-Methods": "*", // Allow all HTTP methods
      "Access-Control-Allow-Headers": "*", // Allow all headers
      "Access-Control-Allow-Credentials": "true", // Allow credentials
    };

    return new Response(null, {
      headers: responseHeaders,
    });
  }

but no luck :/

UPDATE: I fixed it! I had to add
if (req.method === "OPTIONS") {
    const responseHeaders = {
      "Access-Control-Allow-Origin": "*", // Allow requests from any origin
      "Access-Control-Allow-Methods": "*", // Allow all HTTP methods
      "Access-Control-Allow-Headers": "*", // Allow all headers
      "Access-Control-Allow-Credentials": "true", // Allow credentials
    };

    return new Response(null, {
      headers: responseHeaders,
    });
  }

as I said, but then I also had to add to the exports:
 export { handler as GET, handler as POST, handler as OPTIONS };. Feel a little dumb for not noticing I had to export it as OPTIONS as well, if I am also doing if (req.method === "OPTIONS")

Here's my finished code:
import { fetchRequestHandler } from "@trpc/server/adapters/fetch";

import { appRouter, createTRPCContext } from "@kdx/api";

export const runtime = "nodejs";

// export API handler
const handler = async (req: Request) => {
  if (req.method === "OPTIONS") {
    const responseHeaders = {
      "Access-Control-Allow-Origin": "*", // Allow requests from any origin
      "Access-Control-Allow-Methods": "*", // Allow all HTTP methods
      "Access-Control-Allow-Headers": "*", // Allow all headers
      "Access-Control-Allow-Credentials": "true", // Allow credentials
    };

    return new Response(null, {
      headers: responseHeaders,
      status: 204,
    });
  }

  const response = await fetchRequestHandler({
    endpoint: "/api/trpc",
    router: appRouter,
    req,
    createContext: () => createTRPCContext(),
  });
  // configure cors
  response.headers.set("access-control-allow-origin", "*");
  response.headers.set("access-control-allow-headers", "*");
  response.headers.set("access-control-allow-methods", "*");
  response.headers.set("access-control-allow-credentials", "true");

  return response;
};

export { handler as GET, handler as POST, handler as OPTIONS };

Ah sorry, forgot about the OPTIONS request, here's what I did:
import { fetchRequestHandler } from "@trpc/server/adapters/fetch";

import { appRouter, createTRPCContext } from "@acme/api";

export const runtime = "nodejs";

function setCorsHeaders(res: Response) {
  res.headers.set("Access-Control-Allow-Origin", "*");
  res.headers.set("Access-Control-Request-Method", "*");
  res.headers.set("Access-Control-Allow-Methods", "OPTIONS, GET, POST");
  res.headers.set("Access-Control-Allow-Headers", "*");
}

async function handler(req: Request) {
  const response = await fetchRequestHandler({
    endpoint: "/api/trpc",
    router: appRouter,
    req,
    createContext: () => createTRPCContext(),
  });

  // set CORS headers
  setCorsHeaders(response);

  return response;
}

export { handler as GET, handler as POST };

export function OPTIONS() {
  const response = new Response(null, {
    status: 204,
  });
  setCorsHeaders(response);

  return response;
}

Ah sorry, forgot about the OPTIONS request, here's what I did:

import { fetchRequestHandler } from "@trpc/server/adapters/fetch";

import { appRouter, createTRPCContext } from "@acme/api";

export const runtime = "nodejs";

function setCorsHeaders(res: Response) {

  res.headers.set("Access-Control-Allow-Origin", "*");

  res.headers.set("Access-Control-Request-Method", "*");

  res.headers.set("Access-Control-Allow-Methods", "OPTIONS, GET, POST");

  res.headers.set("Access-Control-Allow-Headers", "*");

}

export function OPTIONS() {

  const response = new Response(null, {

    status: 204,

  });

  setCorsHeaders(response);

  return response;

}

async function handler(req: Request) {

  const response = await fetchRequestHandler({

    endpoint: "/api/trpc",

    router: appRouter,

    req,

    createContext: () => createTRPCContext(),

  });

  // set CORS headers

  setCorsHeaders(response);

  return response;

}

export { handler as GET, handler as POST };

Also don't forget export { handler as GET, handler as POST, handler as OPTIONS };

Also don't forget export { handler as GET, handler as POST, handler as OPTIONS };

I am exporting a standalone function OPTIONS instead. No need to run the entire tRPC handler for the OPTIONS request

Oh sorry, I didn't realize it was inside another function. This is better.

Hi,
It is a bad practice to allow access to your backend with a wildcard *. It exposes you to attacks such as CSRF.

Your users' cookies could be sent (and accepted) from another website, potentially from a hacker.
You must specify which origin you allow specifically.
You can find more information in this article.
@juliusmarminge It would be better to remove the CORS headers by default. In this case, the Same-Origin will be applied. It means only the same origin will be able to call the backend.
For example:

toto.fr => toto.fr/api ✅ (the call will work)
toto.fr => api.toto.fr ❌ (the call won't work)
hacker.fr => backend.fr ❌
hacker.fr => toto.fr ❌


CORSFilter.java: allow port 9000 for interop with react HMR

We enabled react hot module replacement (https://github.com/code-dot-org/code-dot-org/pull/56882), which uses the react devserver. This proxies requests from port 9000 to port 3000, which means the browser's origin will be port 9000. This means we expect to see valid requests to Javabuilder originating from port 9000.
This PR updates the CORSFilter's ALLOWED_ORIGINS.

So I did the easy part just to get the ball rolling, but now the hard part: how do I test this? 🙈

Not sure if these are 100% up to date, but are you able to get local javabuilder running using these instructions?
https://github.com/code-dot-org/javabuilder/blob/main/org-code-javabuilder/README.md#setup-your-project

Actually, I'm confused b/c the Slack discussion is talking about a deployed Javabuilder instance, and dev/ code (I thought?) was for local Javabuilder...probably totally missing something though, been a while since I've thought about Javabuilder...

I'm confused enough that I'm not 100% sure if I'm confused or not... Its not 100% clear to me, but I think the slack discussion was talking about a local instance.
Testing instructions from molly
Molly slacked me these instructions on testing, but I haven't done it yet:

instructions for testing Javabuilder changes are here: https://github.com/code-dot-org/javabuilder?tab=readme-ov-file#deploying-a-dev-instance. Just noticed the link in the readme has a typo, the link in step 3 should be https://github.com/code-dot-org/javabuilder/tree/main/cicd#deploying-a-development-environment

easiest way to test it's working once you have things set up:
Go to http://localhost-studio.code.org:3000/s/allthethings/lessons/44/levels/2 with a levelbuilder account (or a verified teacher account, or student of a verified teacher)
Press run
See if it runs in the console
You can make sure it's talking to your instance by looking at the network tab, there should be a websocket request to your dev instance rather than javabuilder-test.code.org


Disable operator upgrade test

The upgrade test targets the latest image from upstream which does work correctly with the current operator logic. In the future this test should be modified to test upgrades between releases.

/lgtm

/approved

/approve


[Help] Swift 5.1 Property Wrapper:  Expressed

Consider of SE-0258
@Expressed("id") var id:String = UUID().string

Help Wanted

Expressed Maybe not a proper name, help wanted.
Still working on tests, don't know how to test for a property wrapper, Equable?
Edit README and Documentation.

I think this is a good idea but this needs more work. I'm also not sure we need the extra insert methods.


Cannot find end-of-document symbol () in tokenizer

Following #19, I was able to download the correct files and tried to run OPT-2.7b. I tried the following command to boot the API:
python -m metaseq_cli.interactive_hosted

However, I ran into the following problem when trying to run the API:
2-05-31 23:29:16 | INFO | metaseq_cli.interactive | Local checkpoint copy already exists, skipping copy
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/conda/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/toolkit/opt/metaseq/metaseq_cli/interactive_hosted.py", line 298, in <module>
    cli_main()
  File "/home/toolkit/opt/metaseq/metaseq_cli/interactive_hosted.py", line 294, in cli_main
    dist_utils.call_main(cfg, worker_main, namespace_args=args)
  File "/home/toolkit/opt/metaseq/metaseq/distributed/utils.py", line 263, in call_main
    return main(cfg, **kwargs)
  File "/home/toolkit/opt/metaseq/metaseq_cli/interactive_hosted.py", line 156, in worker_main
    models = generator.load_model()  # noqa: F841
  File "/home/toolkit/opt/metaseq/metaseq/hub_utils.py", line 471, in load_model
    task = tasks.setup_task(self.cfg.task)
  File "/home/toolkit/opt/metaseq/metaseq/tasks/__init__.py", line 46, in setup_task
    return task.setup_task(cfg, **kwargs)
  File "/home/toolkit/opt/metaseq/metaseq/tasks/language_modeling.py", line 188, in setup_task
    return cls(args)
  File "/home/toolkit/opt/metaseq/metaseq/tasks/language_modeling.py", line 156, in __init__
    args.end_of_document_symbol
AssertionError: Cannot find end-of-document symbol (</s>) in tokenizer

@hunterlang have you run into this issue?

I just ran the md5sum on the files and got this:
$ md5sum gpt2*
75a37753dd7a28a2c5df80c28bf06e4e  gpt2-merges.txt
d9f1a1235d1390093ade7a7e05d11190  gpt2-vocab.json

However, it wasn't what I expected: https://github.com/facebookresearch/metaseq/issues/81#issuecomment-1122617595

Thank you @Skyy93 .
@stephenroller @hunterlang Would it be possible to edit #19's issue body with the correct link? This will save from hours of debugging for those that find the gpt2-vocab.json from #19


[BugFix] fix the mem leak of MysqlResultWriter

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Fail to open fragment d7feedb4-3652-11ed-a0b3-00163e0d9975: Cancelled: Cancelled BufferControlBlock::add_batch

the fetch_data is not delete when add_batch failed
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

Why

the fetch_data is not deleted when add_batch failed


Fix drive time possibly being zero after last fast charging event

Last drive will always be a minimum of one time step long

This fixed the error for the scenario in which it was found


Revise the module build dependency

Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

Rollbacked the module dependency from the maven repo to the dependent projects.
Added git commit hash info into the submodule built jar.

Fixes Issue # . N/A
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):

[ ] Bug fix.
[ ] New feature.
[x] Enhancement.
[ ] Unit test.
[ ] Breaking change (a fix or feature that causes existing functionality to not work as expected).
[ ] Requires documentation update.

Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification
Insert x into the following checkboxes to confirm (eg. [x]):

[ ] I have self-reviewed my own code and conformed to the style guidelines of this project.
[ ] New and existing tests pass locally with my changes.
[ ] I have added tests for my fix or feature.
[ ] I have made appropriate changes to the corresponding documentation.
[ ] My code generates no new warnings.
[ ] Any dependent changes have been made.

The change looks fine to me -- just wondering why we had to change it back?

Cause I think we will pull the lib from the maven until we decide to push these libraries to the public (now the libraries are still in the staging).


⚠ Bofrost.be has degraded performance

In 6eb7123, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 815 ms

Resolved: Bofrost.be performance has improved in 93fd2f3.


[IOCONNECTOR] Use the JobType of the WorkerPool to simplify the inter…

…face.

https://jenkins.code.rdkcentral.com/job/github-triggered/1130/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1152/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1161/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1162/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1164/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1240/ started


Run flake8 against the source, with a very generous ignore list

In order to keep this diff small, this ignores every warning we currently have, rather than fixing them.
This is enough to prevent the style drifting further from flake8 unnoticed.
Future patches can aim to cut down the warnings at a file-by-file basis.
CI is set up so that if linting fails, no tests are run see here

LGTM can be ignored, the new alert is just an existing alert that moved line (and is a false positive)


az aks create fails, apparently due to Service Principal propagation / race

Looks related to this issue: https://github.com/Azure/azure-cli/issues/9585
But, while that issue is still outstanding, this doc should provide new users with a sure-to-work sequence.
Output:
bash-3.2$ az aks create -g kubeRG --name myCluster --node-vm-size Basic_A0 --generate-ssh-keys
Finished service principal creation[##################################]  100.0000%Operation failed with status: 'Bad Request'. Details: The credentials in ServicePrincipalProfile were invalid. Please see https://aka.ms/aks-sp-help for more details. (Details: adal: Refresh request failed. Status Code = '400'. Response body: {"error":"unauthorized_client","error_description":"AADSTS700016: Application with identifier 'REDACTED' was not found in the directory 'REDACTED'. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You may have sent your authentication request to the wrong tenant.\r\nTrace ID: b2f562e5-c5b8-4b11-841a-0a8660bb0f00\r\nCorrelation ID: 022d785f-9ad3-4d64-9c1d-48f4a47d0318\r\nTimestamp: 2020-04-11 18:26:24Z","error_codes":[700016],"timestamp":"2020-04-11 18:26:24Z","trace_id":"b2f562e5-c5b8-4b11-841a-0a8660bb0f00","correlation_id":"022d785f-9ad3-4d64-9c1d-48f4a47d0318","error_uri":"https://login.microsoftonline.com/error?code=700016"})

I only have one Azure subscription, and heading into this tutorial I confirmed that I had no other resources of any type.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6115d555-45a1-6539-4af6-fbc20a99f008
Version Independent ID: 21f80c83-ba10-9b7e-c54f-51a9c140517c
Content: Quickstart: Deploy an Azure Kubernetes Service cluster - Azure Kubernetes Service
Content Source: articles/aks/kubernetes-walkthrough.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@sayotte Thanks for the feedback. We are investigating the issue and will update you shortly.

@sayotte this issue is fixed.
Whats the version of Azure cli which you are using?
Can you try with the latest azure cli or with cloudshell

Pretty sure this is with the latest version:
bash-3.2$ az version
This command is in preview. It may be changed/removed in a future release.
{
  "azure-cli": "2.3.1",
  "azure-cli-command-modules-nspkg": "2.0.3",
  "azure-cli-core": "2.3.1",
  "azure-cli-nspkg": "3.0.4",
  "azure-cli-telemetry": "1.0.4",
  "extensions": {}
}

ok. Lets involve azure support now.  Since we have the correlation id, Support can identify the issue well.
Please send your subscription id to this email id<EMAIL_ADDRESS>we will enable a one time free support ticket to get this resolved.
If that turns out to be a bug, we can file one in azure cli repo.
while sending the email include this issue url in the email body and issue description in the subject

Please send an email as requested.
I will close this out for now. If you need additional help please open a new issue.
Once we receive your email, we will enable the support ticket for you.
Once your issue is resolved, post the resolution here.
If the resolution needs doc update, then open a new issue by referring to this one


Added an upgrade mode to getstorybook

Issue: You need to apply codemod and update your package.json to upgrade to v3
What I did
Added a mode to getstorybook[1] that picks up when it is run in an pre-v3 project and updates all package references in package.json and using the codemod.
[1] Should we rename the command to storybook [install] now as well?
How to test
Grab a 2.0 project, run getstorybook (after npm link-ing of course). It should have correctly updated all references to the packages in both package.json and JS files.

I've tested this on a CRA project on OSX. It would be great if we could test it on:
(A) React Native
(B) Windows (does getstorybook work on windows?)

You may need to npm install inside the cli sir?

@tmeasday bootstrap already does the install? Even when I manually install inside the clr, I still get the same error.

Hmm, I think the culprit is this line: https://github.com/storybooks/storybook/blob/master/lib/codemod/package.json#L15 which does something a bit weird. (Fill me in @ndelangen? It seems weird/broken to have the compiled behaviour/file locations be different from the uncompiled ones)
I'm not sure why but for some combination of commands it actually didn't move the file from the dist/transforms directory.
I can update the PR to remove that weirdness, but let's find out why it's there first.

@tmeasday I suspect it was just to make this upgrade instruction shorter for users:
./node_modules/.bin/jscodeshift -t<EMAIL_ADDRESS>. --ignore-pattern "node_modules|dist"

Ok, I'll make the change now and @ndelangen can approve that specific change.

FTR I think this worked for @shilman, he needs to approve the review now I guess.


Add artifact to Full CI build

This doesn't fix the full build mentioned in the meeting today but does add the log with the error to the artifact list.

Codecov Report

Merging #890 (8babefa) into develop (799013c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #890   +/-   ##
========================================
  Coverage    94.75%   94.75%
========================================
  Files          153      153
  Lines        10756    10756
========================================
  Hits         10192    10192
  Misses         564      564

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add map "Europa"

About the PR

Adds the map "Europa" to game the without being in map pool for testing and other things. No image because i don't know if a map render would even work with planetmos. I believe there are many other issues with the map, but i don't know how to fix them since the biggest issues are still here.
TODO:

Make air outside station mildly toxic (and.. COLD)
Fix FTLing, especially salvage shuttle
How will nukies work??? (My idea is either hardcoded spawns or randomized based on distance to center)
Have the gas miners not flood the planet with whatever gas is infinitely created.
Fix the snow textures not bleeding into the station tiles with the small enclosures
(for myself) Add ruins and other structures, along with ores.

P.S. Emisse please add and setup the TEG to the designated TEG location for me now :)

europa from fish game wow

NUH UH i just was looking at ice moon names and europa felt right

yay indoor/outdoor soon?

mhh snow land finally need to make snowman

this is a planet map?

yes this is a planet map, its being merged to the repo for testing, it will not be in rotation until planet map bugs are sorted

is there a test with map prototype ids hardcoded in? lmao

will be interesting to see how you fix the FTL issue, infact, doing so may open up the path to the drop pod for nukies

I was literally just asking in the cartography channel if anyone had attempted to port Icebox from /tg/ over to ss14. Hooray!

when merge? @Emisse

add the map to the test to fix the test

Needs https://github.com/space-wizards/space-station-14/pull/20104


Reduce amount of white space in panel Relations to Other Signs (Detail view)

Whether there is one or multiple or no related sign specified, there is always unnecessary white space at the bottom; please make more condense, like in the other panels.
ah, in fact this holds for all panels (Morphology, Relations to Foreign Signs) where relations can be specified, so please alter everywhere.

Fixed. (Pushed to github master.)


[terra-form-input] Required inputs do not announce correctly on VoiceOver Safari

Bug Report
Description

Input fields do not appropriately announce labels when set to required. The issues appears to be related to inserting the required asterisk in front of the label.
Steps to Reproduce

(In Safari) Navigate to https://engineering.cerner.com/terra-ui/components/terra-form-input/form-input/input-field
Activate VoiceOver
Navigate to the required input field example
Observe the label text is not announced. It announces "star and one more item", where the label is the "one more item"

Additional Context / Screenshots

Attaching the text output of VoiceOver Safari for one of the terra-ui examples. Notice that label is not announced. VoiceOver announces "star and one more item" instead of the label.

Expected Behavior

Required input fields should appropriately announce labels on mobile Safari when using VoiceOver
Possible Solution

The issue appears to happen because of the dom markup:

*

  Required Input Field

Potentially hiding the div containing the asterisk from screen readers would resolve the issue.

The Field implementation here is what is causing the issue:
https://github.com/cerner/terra-core/blob/f03e926e522c5d7f9655f4f28bcee149fbbd1237/packages/terra-form-field/src/Field.jsx#L181-L191
As @StephenEsser reported, it creates a basic structure for visual users only:

*

  Field Label

And needs to be updated to generate:

*

   Required
   Field Label

The changes will mimic the same as how the Fieldset Legends are created for 'RadioField', 'CheckboxField', and 'DateInputField', (which technically are fieldsets and legends, not true a label, but are displayed to users like they are a standard form input "field" question, so they will have very similar markup, though not exact).
https://github.com/cerner/terra-core/blob/f03e926e522c5d7f9655f4f28bcee149fbbd1237/packages/terra-form-radio/src/RadioField.jsx#L115-L134

@pranav300 - upon looking at this further, I am thinking that we also need to update our approach with the Error-Icon to follow a similar approach as the changes for the asterisks.
Writing up details on how we should restructure to also be aria-hidden with Visually hidden text and will edit this comment.


Add SMK Wikrama Bogor to lib/domains/id/sch

@arfnnhh First stage of verification passed, official domain is smkwikrama.sch.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Magento 2

Hi,
Does this library work with Magento 2? If so, what steps must I take to set-up Magento 2?

No. Magento 2 has a much bigger REST API and this library would have to be rewritten entirely to address this. I've briefly looked into how it could be done, but don't have any plans yet

Do you have a commercial product that does work on M2.3?


vis result wrong

hi Thank you for your work！
I want to get visual results with the command:
python ./tools/misc/visualize_results.py configs/bevfusion/bevf_tf_4x8_6e_nusc.py --result ./work_dirs/bevfusion_tf.pkl --show-dir ./visresult
but i get a error with this command. Can you help me to see what is the reason? Thanks
`(bevfusion) ub@1:~/workspace/code/github/BEVFusion-main$ python ./tools/misc/visualize_results.py configs/bevfusion/bevf_tf_4x8_6e_nusc.py --result ./work_dirs/bevfusion_tf.pkl --show-dir ./visresult
Traceback (most recent call last):
File "/home/ub/anaconda3/envs/bevfusion/lib/python3.8/site-packages/mmcv/utils/registry.py", line 69, in build_from_cfg
return obj_cls(**args)
TypeError: init() got an unexpected keyword argument 'num_views'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "./tools/misc/visualize_results.py", line 43, in
main()
File "./tools/misc/visualize_results.py", line 31, in main
dataset = build_dataset(cfg.data.test)
File "/home/ub/mmdetection3d/mmdet3d/datasets/builder.py", line 44, in build_dataset
dataset = build_from_cfg(cfg, DATASETS, default_args)
File "/home/ub/anaconda3/envs/bevfusion/lib/python3.8/site-packages/mmcv/utils/registry.py", line 72, in build_from_cfg
raise type(e)(f'{obj_cls.name}: {e}')
TypeError: NuScenesDataset: init() got an unexpected keyword argument 'num_views`

Can you tell me how to generate .pkl format, the format I generate is .pth，thanks


Long 'del' statement not split into multiple lines

Operating system: Windows 10
Python version: 3.6.6
Black version: 18.9b0
Does also happen on master: yes
In an __init__ file, I have the following:
from .business_day_convention import BusinessDayConvention
from .date_generation_rule import DateGenerationRule
from .schedule import Schedule
from .schedule_context import ScheduleContext
from .period import Period
from .time_unit import TimeUnit
from .frequency import Frequency

del business_day_convention, date_generation_rule, schedule, schedule_context, period, time_unit, frequency

I expect the final del statement to be split on multiple lines (like imports) but it is not
Expected output:
from .business_day_convention import BusinessDayConvention
from .date_generation_rule import DateGenerationRule
from .schedule import Schedule
from .schedule_context import ScheduleContext
from .period import Period
from .time_unit import TimeUnit
from .frequency import Frequency

del (
    business_day_convention,
    date_generation_rule,
    schedule,
    schedule_context,
    period,
    time_unit,
    frequency,
)

Thanks for the report, we'll fix it.

Relatedly, we also don't appear to split up import a, b, c, d if it is too long.

... which makes sense because import (a, b) is a syntax error. The del change is tricky because we'd change the AST:
In [326]: def d(s): return ast.dump(ast.parse(s))

In [333]: d("del a, b")
Out[333]: "Module(body=[Delete(targets=[Name(id='a', ctx=Del()), Name(id='b', ctx=Del())])])"

In [334]: d("del (a, b)")
Out[334]: "Module(body=[Delete(targets=[Tuple(elts=[Name(id='a', ctx=Del()), Name(id='b', ctx=Del())], ctx=Del())])])"

The two statements do produce the same bytecode, but the AST change makes it so that inserting parens in del statements will break our AST safety check.

Relatedly, we also don't appear to split up import a, b, c, d if it is too long.

You can split into multiple import statements
import a
import b
import c
...

If you find a long del or other sort of expression you can't wrap, might I suggest black issues a warning ?


TI TIVA TM4C JTAG

Hello,
I'm trying to reflash TI MSP432P401R builtin XDS 110 JTAG programmer firmware, which was broken during the update and doesn't enter DFU mode.
TI suggest to use JTAG (seems this is the only possible way). As I don't have any TI XDS JTAG programmer, I'm trying to do the same with some other JTAG hardware.
I didn't achieve any success with Altera Byte Blaster neither with ST-Link v2, so I'm trying to do this with DirtyJtag+openocd(patched). It can detect the CPU, but then failed during initialization with error:
Error: 103 214 bitq.c:308 bitq_execute_queue(): missing data from bitq interface.
Do you have any idea what to check/change?
openocd configuration file, inspired by board/ti_ek-tm4c1294xl.cfg
#
# TM4C1294NCPDT Chip
#
# Author :
# Version :
#
source [find interface/dirtyjtag.cfg]
# transport select jtag

set WORKAREASIZE 0x8000
set CHIPNAME tm4c1294ncpdt
source [find target/stellaris.cfg]

Full openocd debug log attached.
Thank you!
openocd.txt

Hi @froloffw7,
I haven't been very active on the OpenOCD driver. I had a brief look but I can't figure what's going wrong.
@phdussud do you have any advice or things they should try? Thanks :)

Hello,
I looked at the log. I believe that the error comes from a lack of response from the TI chip, or a bug in the openocd driver or in the  dirtyjtag firmware. Are you using dirtyJtag V2?
This is going to be hard to debug. A similar debug session works with a STM2F4xx chip but that does not help you any. Sorry!
The only thing I can suggest is to use a Logic Analyzer to spy on the Jtag interface and see if the exchange right before the error message makes sense. Alternatively, you can try an older version of the dirtyJtag support of openocd here
https://sourceforge.net/u/phdussud/openocd/


Enable PythonOps.PrintException on basic console builds

This change makes IronPython 3 buildable without FEATURE_FULL_CONSOLE (except for IronPythonConsole and IronPythonWindow). Such a build behaves properly in LinqPad without a need for stdio redirecting (i.e. like IronPython 2).

Thanks!


/learn link is broken which is present in README

Describe the bug
On the readme, in the Getting Started section there is a hyperlink to https://renative.org/learn which results in page not found.
To Reproduce
Steps to reproduce the behavior:

Open the link https://renative.org/learn

Expected behavior
A proper page shoould open
Screenshots or copy&paste

Desktop (please complete the following information):

N/A

Additional context
Since this is the first link on Readme, this should point to proper page.

fixed by 61e61768f0d59da01825d1d02fa23c7d4d475f75


Doesn't seem to work after a gulp.dest()

Any reason why this works fine before but not after a gilp.dest()?
gulp.src(filePath)
      .pipe(gulp.dest(targetPath))
      .pipe($.htmlSrc({ selector: 'img'}))
      .pipe($.tap(function(file){
        console.log('IMG',file);
        return file;
      }));
  });

nothing consoles out.
However..
gulp.src(filePath)
      .pipe($.tap(function(file){
        console.log('IN',file);
        return file;
      }))
      .pipe(gulp.dest(targetPath))
      .pipe($.tap(function(file){
        console.log('OUT',file);
        return file;
      }))
      .pipe($.htmlSrc({ selector: 'img'}))
      .pipe($.tap(function(file){
        console.log('IMG',file);
        return file;

The IN and OUT consoles look like the exact same output.

Without looking into it, I think you need something afterwards that starts
the stream - like if you had another gulp.dest() afterwards, I think it
would work.  There's probably a gulp plugin that does it without needing to
output it somewhere.
On the other hand,  maybe there's something we can do to start the stream
in this plugin.
On Sat, 2 Apr 2016, 15:47 iDVB<EMAIL_ADDRESS>wrote:

Any reason why this works fine before but not after a gilp.dest()?
gulp.src(filePath)
.pipe(gulp.dest(targetPath))
.pipe($.htmlSrc({ selector: 'img'}))
.pipe($.tap(function(file){
console.log('IMG',file);
return file;
}));
});
nothing consoles out.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/bruderstein/gulp-html-src/issues/9


Remove enquireLinkSender.join() during session.close() because this p…

Remove enquireLinkSender.join() during session.close() because this prevents normal closing of session and sessions hangs when smpp server is restarted

The message_id in the deliver_sm_resp PDU is always NULL, according to the SMPP 3.4 and 5.0 specs. What is the use case to have if filled ?

I will look into the session closing issue and see what the cause is.

By default the new field is null, you need to set manually it to have
message id in deliver_sm_resp
The use case is:
OpenMind SMPP server send me deliver_sm via SMPP session (Not submit_sm)
I process it (send via another transport - push, viber, etc) and
send delivery_report when processing finished.
SMPP Server automatically match this deliver_sm_resp and delivery_report by
combination
messageId in deliver_sm_resp and RECEIPTED_MESSAGE_ID in TLV tag of
delivery_report
On Wed, Aug 19, 2015 at 5:51 PM, Pim Moerenhout<EMAIL_ADDRESS>wrote:

The message_id in the deliver_sm_resp PDU is always NULL, according to the
SMPP 3.4 and 5.0 specs. What is the use case to have if filled ?
—
Reply to this email directly or view it on GitHub
https://github.com/opentelecoms-org/jsmpp/pull/10#issuecomment-132625695
.

--
Best regards, Mykola Pavluchynskyi

Are you sure about removing the enquireLinkSender.join()? Check this pull request I created 6.nov 2014 to fix a problem with the SMPP code to deadlock: https://github.com/TomasAndersen/jsmpp/commit/c2d53fe99a40c74d2875574097b2fd14d1eec250
That time I moved all code up in the AbstractSession class to avoid handling in both SMPPSession.close and AbstractSession.close.
Regards,
Tomas

BTW. I have no problems with the API now. If the remote side (SMSC) or the network goes down, the SMPP API is dying gracefully and both threads stop properly. I have created a watchdog outside the API which kicks it alive again.

Hi Tomas,
I also don’t have problems with the join(). I want to see if I can reproduce the problem mentioned by Mykola, but I was not able to do. Before I want to change anything there, I want to understand the problem...
Pim

On 31 aug. 2015, at 08:19, Tomas Andersen<EMAIL_ADDRESS>wrote:
BTW. I have no problems with the API now. If the remote side (SMSC) or the network goes down, the SMPP API is dying gracefully and both threads stop properly. I have created a watchdog outside the API which kicks it alive again.
—
Reply to this email directly or view it on GitHub https://github.com/opentelecoms-org/jsmpp/pull/10#issuecomment-136277955.


--delete-local-data is deprecated; we should switch to --delete-emptydir-data

Slack thread for context.
kubergrunt eks deploy supports a --delete-local-data flag, but it looks like that has been deprecated:
Flag --delete-local-data has been deprecated, This option is deprecated and will be deleted. Use --delete-emptydir-data.

Looks like we need to switch to --delete-emptydir-data.

cc @autero1


There is no way to mention Alt text  for bot icon in Microsoft teams

We own the Azure boards app for teams.
In the manifest file, there is no option to mention an alt text for our app icon. As a result a speech tool is not reading the icon out loud.
This is an accessibility bug.
In the below screenshot, the red exclamation marks are for reference.

@sushmita-m - We are looking into this I will get back to you soon.

@sushmita-m - We are able to repro that issue , We have raised bug for the same and concerned team is looking into it. We will inform you once we get any update.

@sayali-MSFT   Do we have any update on the same?

@v-anvashist-Currently we don’t have ETA or Update on this thread.
We will update this thread once the bug is fixed.

@v-anvashist @sushmita-m -Issue is Resolved.
Microsoft Teams Version <IP_ADDRESS>73 (64-bit).
Could you please check and confirm the same.
https://github.com/MicrosoftDocs/msteams-docs/assets/93527375/673da22f-cc90-41bb-8ecd-b84d37fb60d8


missing license

Is there a license file for this project ?

Thanks for the heads up! Added a LICENSE file.


Go/No go decision for instantiate to bounds as implemented

We have an initial implementation of the proposed instantiate to bounds semantics, as discussed here:  https://github.com/dart-lang/sdk/issues/27526 .
The language team needs to make a final decision about whether the impact of these changes is reasonable.  I have CLs prepared to address most of the changes required to internal code.  I will follow up on several issues with the language team.
Subsequently I will follow up here with a decision, either to:

roll back the initial implementation and revisit for next release
relax the restriction to the minimum that we are sure that we want
roll forward with the implementation and land all of the CLs to fix internal code

cc @kevmoo @mit-mit @floitschG @munificent @eernstg @lrhn

We will relax the restriction slightly as described here: https://github.com/dart-lang/sdk/issues/28580
Otherwise we're ok with the impacts of this change.


Focus/OnClick bug fix

-Fixed small bug which was giving :focus precedence over onClick, thus closing the dropdown before firing change functions

onClick is now replaced by onMouseDown

I've added onPointerDown to my branch here: https://github.com/airswap/airswap-web/pull/582 So this one can be closed.


Added code for matrix multiplication

What type of PR is this? (check all applicable)

[ ] 🚀 Added Name
[ ] ✨ Feature
[Yes ] 🌟 stared the repo
[ ] 🐛 Grammatical Error
[Yes ] 📝 Documentation Update
[ ] 🚩 Other

Description
This code can be modified to extend to matrices of any order for multiplication
Add Link of GitHub Profile
https://github.com/shinozaki1595

Ye

[ ] its a checkmark, dont write anything in this box, just click on this above you will know what it is.... this feature provides by github markdown by default.


conversion error from hg19 to hg38 in pyliftover

chainfile = 'hg19ToHg38.over.chain.gz'

from pyliftover import LiftOver
lo = LiftOver(chainfile)
lo.convert_coordinate('chr22', 42526579)
[('chr22_KI270928v1_alt', 52918, '+', 15145)]
lo.convert_coordinate('chr22', 42526580)
[('chr22', 42130578, '+',<PHONE_NUMBER>)]

Blelow was the result of UCSC liftOver tool.
chr22_KI270928v1_alt	52918	52919
The result of UCSC liftOver tool was right and pyliftover gets wrong.
please fix this, Thanks

Please note that Pyliftover uses 0-based indexing while the liftover tool is 1-based. So far all reported perceived mismatches were related to this aspect.

The input file of UCSC liftOver tool is bed file with 0-based indexing. The position of "chr22:42526580" is 0-based indexing.
The result of pyliftover is different from the result of  UCSC liftOver tool.

If I input the zero-based chr22 42526579 42526579 into the web LiftOver I obtain
chr22_KI270928v1_alt	52918	52918	chr22:42526580-42526579	1
This seems to match what you report getting from pyliftover.
Similarly, the result of converting chr22 42526580 42526580 by the web tool is reported to me as:
chr22	42130578	42130578	chr22:42526581-42526580	1
This, again, seems to match what you obtained in the Python version.
If I input chr22	42130578	42130579, which I presume you did, I get chr22_KI270928v1_alt 52918 52919, which seems to indicate that liftOver is treating the right interval endpoint as exclusive (i.e. it just converted chr22:[42130578, 42130579) to the single position that 42130578 mapped to.
This hypothesis seems to be consistent with what we get if we query chr22	42130578	42130580, assuming we request conversion of [42130578, 42130580), i.e. [42130578, 42130579]. At this point liftOver reports a split in new error message, which indeed matches what we saw when converting two positions individually (one maps to chr22_KI.., another to chr22).
We get the same error if we try the 1-based format (that must be inclusive of both endpoints): chr22:42526580-42526581 reports a Split in new error message.
Hope this helps.


feat!: replace getter and setter callables and remove rack specific propagators

When looking over #564 earlier this week, I realized that we do not have a general way to iterate over a carrier's keys. We haven't missed this, because before the Jaeger propagator we didn't have this need. When we originally implemented the propagation API, the getters and setters passed to inject and extract were specified as functions. The spec has since evolved to recommend that they be implemented as objects, especially the getter, with get and keysmethods. The setter is less useful, but not useless, and has a set method.
Below are links to the spec for more details

getter
setter

I started off experimenting with a TextMapGetter and a RackEnvGetter and found that the getter abstraction is pretty useful. The RackEnvGetter provides functionality to access keys in a carrier agnostic way. So, we can use it to lookup traceparent instead of HTTP_TRACEPARENT for example. With this abstraction, I was able to remove all of the Rack specific injectors and extractors, as I continued the refactor, I was able to remove the http and text distinction from the top level propagation object. Now, OpenTelemetry.propagation.extract will extract using a TextMapGetter by default. If you want to extract from a Rack environment you'd use OpenTelemetry.propagation.extract(env, Context.current, Propagation.rack_env_getter). It's a little more to type, but it's only used a few places. This makes the Ruby context API much closer to the spec and less of a special snowflake.
Summary the changes, this PR:

Introduces two Getters, with get and keys methods

TextMapGetter
RackEnvGetter

Introduces a TextMapSetter with a set method
Removes all rack specific injectors and extractors

This simplifies, but also adds some breaking changes to the configurator

Removes the http and text paths from OpenTelemetry.propagation. You go directly to inject or extract now (e.g. OpenTelemetry.propagation.inject(...)

Updated relevant call sites in instrumentation and examples

This is a pretty big change, but I think it is a good improvement in terms of usability and spec compliance. I also think this will help smooth over some things in the Jaeger propagator PR (#564).

Overall, this is a good change. Since this removes the Rack-specific extractors, maybe we should go a step further and remove the separation of injectors and extractors, and instead unify them in the Propagator. One thing we have not implemented yet is the Fields operation, which becomes much simpler when we have a B3 Single propagator and a B3 Multi propagator rather than the Propagator initialized with an injector and an extractor.

Overall, this is a good change. Since this removes the Rack-specific extractors, maybe we should go a step further and remove the separation of injectors and extractors, and instead unify them in the Propagator. One thing we have not implemented yet is the Fields operation, which becomes much simpler when we have a B3 Single propagator and a B3 Multi propagator rather than the Propagator initialized with an injector and an extractor.

We can discuss this, but I'd recommend handling it as a separate PR. When we originally implemented the context prop system the specification had injectors and extractors as separate concerns. Ours are still separate in part because of this, but also because there are some advantages to this design. Namely, an app can have asymmetric formats for inject and extract, also, the order of injection and extraction can be controlled. It might turn out that these advantages are only theoretical and not actually useful in practice. We can still implement fields with separate injectors and extractors, although, I agree it'd be easier for combined propagators. I will be completely honest in that I don't understand the fields use case, and I know that is completely broken for propagators that use header-per-key semantics for baggage (such as Jaeger).

I'd recommend handling it as a separate PR.

👍

I 👍 this, but I'd like to get #592 merged and a new release cut before we merge this (that's an important bug fix for 0.13.0).


Images don't get recognised as such

Hi there,
maybe you can help me out on this one:
I copy (via terminal or php, tried both) a chunk of folders and md-files (representing some blog posts) into my user/pages/blog/ directory in Grav.
As expected the pages are available just fine afterwards. Except the images. every blog post has its own images in his folder - but they don't get recognised as images, it seems.
In the Admin panel they just have the "JPG" text as thumbnail. when using them in markdown no image gets output, but just the (alt)-Text as a <p> tag. opening the images via browser shows them normally.
if I upload a new image via admin panel this new image works just fine and be used as expected.
I suspect that the "externally added" pictures are missing something that helps Grav to determine their type and how to use them - sadly I am at a loss here what this could be. my tries of debugging so far have been fruitless, pretty new to Grav.
cheers and many thanks!

Hi Andy,
thanks for reaching out!
I have added a working example (uploaded normally via Grav admin).
blogpost.zip
For further clarification (if needed):
how a working and not working image get displayed in Grav admin:

and how they render as html:

Are you talking about being broken only the thumbnail in the Page media field?
They actually all show up fine for me:

And they all render fine on frontend and in preview.  I'm not seeing anything broken.

Even deleting the image and re-uploading it looks fine:

ooff, that's a bummer. sounds to me like I have a problem with the deployment environment. good for you, nothing to do here. bad for me. yikes.
thanks for your time and fast response, I think we can close this here :/


x/tools: add 1.23 and tip builders with GODEBUG=gotypesalias=1

See #68796 and #68797 for some background on missing test coverage with GODEBUG=gotypesalias=1.
Until x/tools has a go.mod file that says 1.23 (not until at least 1.24 is released), it will lack test coverage of GODEBUG=gotypesalias=1. @timothy-king had added go1.21 and go1.22 builders with GODEBUG=gotypesalias=1; we need them for 1.23 and tip as well.
@timothy-king @dmitshur would you mind adding these as well? CC @adonovan

Related Issues and Documentation

x/build: catch problems in x/ repos gated by module go directive version sooner #67791

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

These builders were recently updated in CL 601177 to stop existing after 1.22 based on the idea that 1.23 and later already default to GODEBUG=gotypesalias=1. I'll refine that to keep them around for 1.23 and 1.24 as well.

Thanks very much @dmitshur! Would it be possible to add the tip builder to the default presubmit tryset as well?

See #68796 and #68797 for some background on missing test coverage with GODEBUG=gotypesalias=1.
Until x/tools has a go.mod file that says 1.23 (not until at least 1.24 is released), it will lack test coverage of GODEBUG=gotypesalias=1. @timothy-king had added go1.21 and go1.22 builders with GODEBUG=gotypesalias=1; we need them for 1.23 and tip as well.
@timothy-king @dmitshur would you mind adding these as well? CC @adonovan


falco-probe module reported as having invalid module format on Ubuntu 16.04

I have the linux headers installed and it correctly detects the kernel version. I see that it tries to build the kernel module but can't create the extras directory, so then it tries to get a precompiled one, but then the module that it downloads is in the wrong format.
root@labs:/etc# docker run -i -t --name falco --privileged -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro -v /boot:/host/boot:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro sysdig/falco
* Setting up /usr/src links from host
* Unloading falco-probe, if present
rmmod: ERROR: Module falco_probe is not currently loaded
* Running dkms install for falco

Kernel preparation unnecessary for this kernel.  Skipping...

Building module:
cleaning build area...
make -j6 KERNELRELEASE=4.4.0-116-generic -C /lib/modules/4.4.0-116-generic/build M=/var/lib/dkms/falco/0.9.0/build...
cleaning build area...

DKMS: build completed.

falco-probe.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/4.4.0-116-generic/kernel/extra/
mkdir: cannot create directory '/lib/modules/4.4.0-116-generic/kernel/extra': Read-only file system
cp: cannot create regular file '/lib/modules/4.4.0-116-generic/kernel/extra/falco-probe.ko': No such file or directory

depmod...

DKMS: install completed.
* Trying to load a dkms falco-probe, if present
* Trying to load a system falco-probe, if present
* Trying to find precompiled falco-probe for 4.4.0-116-generic
Found kernel config at /host/boot/config-4.4.0-116-generic
* Trying to download precompiled module from https://s3.amazonaws.com/download.draios.com/stable/sysdig-probe-binaries/falco-probe-0.9.0-x86_64-4.4.0-116-generic-844c262ad06554a45f6d1d87e99d626d.ko
Download succeeded, loading module
insmod: ERROR: could not insert module /root/.sysdig/falco-probe-0.9.0-x86_64-4.4.0-116-generic-844c262ad06554a45f6d1d87e99d626d.ko: Invalid module format
Tue Mar  6 19:59:10 2018: Falco initialized with configuration file /etc/falco/falco.yaml
Tue Mar  6 19:59:10 2018: Parsed rules from file /etc/falco/falco_rules.yaml
Tue Mar  6 19:59:10 2018: Parsed rules from file /etc/falco/falco_rules.local.yaml
Tue Mar  6 19:59:10 2018: Unable to load the driver. Exiting.
Tue Mar  6 19:59:10 2018: Runtime error: error opening device /host/dev/falco0. Make sure you have root credentials and that the falco-probe module is loaded.. Exiting.

Let me know what additional information I can provide.

Can you please try sysdig/falco:dev image? dev image should have the fix for this bug

cool. that does work.

I tried to download the dev version, but can't create the extras directory.
sudo dpkg -l | grep linux-headers - $ (uname -r)
git clone -b dev https://github.com/draios/falco.git
kubectl create -f falco / examples / k8s-using-daemonset / k8s-with-rbac / falco-account.yaml
mkdir falco-config
cp falco / falco.yaml falco-config /
cp falco / rules / falco_rules. * falco-config /
kubectl create configmap falco-config --from-file = falco-config
kubectl create -f falco / examples / k8s-using-daemonset / k8s-with-rbac / falco-daemonset-configmap.yaml

oscar@ub-nodo0-sbd:~$ kubectl logs falco-lzxtb
* Setting up /usr/src links from host
* Unloading falco-probe, if present
rmmod: ERROR: Module falco_probe is not currently loaded
* Running dkms install for falco

Kernel preparation unnecessary for this kernel.  Skipping...

Building module:
cleaning build area...
make -j2 KERNELRELEASE=4.4.0-127-generic -C /lib/modules/4.4.0-127-generic/build M=/var/lib/dkms/falco/0.10.0/build.....
cleaning build area...

DKMS: build completed.

falco-probe.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/4.4.0-127-generic/kernel/extra/
mkdir: cannot create directory '/lib/modules/4.4.0-127-generic/kernel/extra': Read-only file system
cp: cannot create regular file '/lib/modules/4.4.0-127-generic/kernel/extra/falco-probe.ko': No such file or directory

depmod....

DKMS: install completed.
* Trying to load a dkms falco-probe, if present
falco-probe found and loaded in dkms
Sat Jun  9 06:37:11 2018: Falco initialized with configuration file /etc/falco/falco.yaml
Sat Jun  9 06:37:11 2018: Loading rules from file /etc/falco/falco_rules.yaml:
Sat Jun  9 06:37:11 2018: Loading rules from file /etc/falco/falco_rules.local.yaml:

all help is welcome!

Thank you very much for the answer

Hello guys,
I have a similar problem as @openshiftninja has before - I am trying to use latest EKS nodes for my k8s cluster and falco give me an error for "permission denied" when module is about to install:
* Setting up /usr/src links from host
* Unloading falco-probe, if present
* Running dkms install for falco
Error! echo
Your kernel headers for kernel 4.14.106-97.85.amzn2.x86_64 cannot be found at
/lib/modules/4.14.106-97.85.amzn2.x86_64/build or /lib/modules/4.14.106-97.85.amzn2.x86_64/source.
* Running dkms build failed, couldn't find /var/lib/dkms/falco/0.15.0/build/make.log
* Trying to load a system falco-probe, if present
* Trying to find precompiled falco-probe for 4.14.106-97.85.amzn2.x86_64
Found kernel config at /host/boot/config-4.14.106-97.85.amzn2.x86_64
* Trying to download precompiled module from https://s3.amazonaws.com/download.draios.com/stable/sysdig-probe-binaries/falco-probe-0.15.0-x86_64-4.14.106-97.85.amzn2.x86_64-a7281d2454de7f0821a9f5b26148085e.ko
Download succeeded, loading module
insmod: ERROR: could not insert module /root/.sysdig/falco-probe-0.15.0-x86_64-4.14.106-97.85.amzn2.x86_64-a7281d2454de7f0821a9f5b26148085e.ko: Permission denied
Sat May 25 19:08:12 2019: Falco initialized with configuration file /etc/falco/falco.yaml
Sat May 25 19:08:12 2019: Configured rules filenames:
Sat May 25 19:08:12 2019:    /etc/falco/falco_rules.yaml
Sat May 25 19:08:12 2019:    /etc/falco/falco_rules.local.yaml
Sat May 25 19:08:12 2019:    /etc/falco/rules-php-fpm.yaml
Sat May 25 19:08:12 2019: Loading rules from file /etc/falco/falco_rules.yaml:
Sat May 25 19:08:12 2019: Loading rules from file /etc/falco/falco_rules.local.yaml:
Sat May 25 19:08:12 2019: Loading rules from file /etc/falco/rules-php-fpm.yaml:
Sat May 25 19:08:13 2019: Unable to load the driver. Exiting.
Sat May 25 19:08:13 2019: Runtime error: error opening device /host/dev/falco0. Make sure you have root credentials and that the falco-probe module is loaded.. Exiting.

I tried suggestion to use dev image (sysdig/falco:dev) but with it I couldn't download precompiled module from s3 bucket. You can see it in log snippet bellow:
* Unloading falco-probe, if present
* Running dkms install for falco
Error! echo
Your kernel headers for kernel 4.14.106-97.85.amzn2.x86_64 cannot be found at
/lib/modules/4.14.106-97.85.amzn2.x86_64/build or /lib/modules/4.14.106-97.85.amzn2.x86_64/source.
* Running dkms build failed, couldn't find /var/lib/dkms/falco/0.1.2611dev/build/make.log
* Trying to load a system falco-probe, if present
* Trying to find precompiled falco-probe for 4.14.106-97.85.amzn2.x86_64
Found kernel config at /host/boot/config-4.14.106-97.85.amzn2.x86_64
* Trying to download precompiled module from https://s3.amazonaws.com/download.draios.com/stable/sysdig-probe-binaries/falco-probe-0.1.2611dev-x86_64-4.14.106-97.85.amzn2.x86_64-a7281d2454de7f0821a9f5b26148085e.ko
Download failed, consider compiling your own falco-probe and loading it or getting in touch with the sysdig community
Sat May 25 19:06:51 2019: Falco initialized with configuration file /etc/falco/falco.yaml
Sat May 25 19:06:51 2019: Configured rules filenames:
Sat May 25 19:06:51 2019:    /etc/falco/falco_rules.yaml
Sat May 25 19:06:51 2019:    /etc/falco/falco_rules.local.yaml
Sat May 25 19:06:51 2019:    /etc/falco/rules-php-fpm.yaml
Sat May 25 19:06:51 2019: Loading rules from file /etc/falco/falco_rules.yaml:
Sat May 25 19:06:51 2019: Loading rules from file /etc/falco/falco_rules.local.yaml:
Sat May 25 19:06:51 2019: Loading rules from file /etc/falco/rules-php-fpm.yaml:
Sat May 25 19:06:51 2019: Unable to load the driver. Exiting.
Sat May 25 19:06:51 2019: Runtime error: error opening device /host/dev/falco0. Make sure you have root credentials and that the falco-probe module is loaded.. Exiting.```

Does anybody has an idea what I could try to do in this case? Thank you!


Remove analytics field from Securesign sample

Found one more example to it here: https://github.com/securesign/secure-sign-operator/blob/main/README.md?plain=1#L136
Only the readme but should probably be removed :)

Found one more example to it here: https://github.com/securesign/secure-sign-operator/blob/main/README.md?plain=1#L136
Only the readme but should probably be removed :)

README fixed


Add support for custom filter shaders

That would indeed be quite useful. However, I think a Java passthrough of the filter shader will have pretty bad performance (the filter shader can be called an awful lot of times), so I haven't done that until now. It might be useful anyway.

I gave it a try and it works better than expected. It's available in the current 0.4.16-SNAPSHOT release and in the dev branch.
Here is an example how to use it: PassThroughFilterShaderTest.
I tested the filter shader with 2000 colliding boxes and there is almost no difference in speed comapred to the native default filter shader.
A few notes:

Setting up the custom filter shader also requires using the filterShaderData field in PxSceneDesc which would be painful from Java. Therefore this is done via PxTopLevelFunctions.setupPassThroughFilterShader(sceneDesc, shader); instead of sceneDesc.setFilterShader(...);
The native filter shader callback has an additional output parameter pairFlags, which is difficult to emulate in Java. My solution is that the Java filter shader implementation has to call the method setOutputPairFlags(flags);
The Java filter shader method gets the filterData parameters as individual ints instead of PxFilterData objects. This makes the method signature a bit messy but access to the individual words does not require additional JNI interaction and therefore is much faster.
Also for performance, all flags are represented by primitive ints

Thanks! :D


Video series

Create a series of videos on topics like...

Install
Usage
Custom config files
Custom build tasks
Feri + Feri Extension
Speed tweaking

No longer desired.


Provide examples in both Scala and SQL

From @metasim on September 14, 2017 11:57
Use the Paradox "groups" feature to show examples in both SQL and Scala.
(To be extended to Python when we have that working.)
Copied from original issue: s22s/raster-frames#15

Currently focusing just on Python. Would like to add SQL section too, but lower in priority.


Snapcast file has no execute permissions

easy fix, but I cannot do it in browser

can be fixed momentarily with executing the following command within the folder
sudo chmod +x ./install-snapcast-client.sh


fix: when snapshot.hasError is true, text has not been initialized

PR Description
fix: when snapshot.hasError is true, text has not been initialized.

Related Issues

Related Issue #
Closes #

Checklist

[x] I have gone through the contributing guide
[x] I have run the tests (flutter test) and all tests are passing

Added/updated tests?
We encourage you to add relevant test cases.

[ ] Yes
[ ] No, and this is why: please replace this line with details on why tests have not been included

Thanks for the fix @carlos19960601 🚀


chore(codesandbox): add card-section-carousel CSB example

Description
This adds a Codesandbox example for the card-section-carousel component.
Changelog
New

card-section-carousel web components Codesandbox example

Thanks @kennylam !
Can you also add integration tests at /packages/web-components/tests/e2e/cypress/integration/?

Can you also add integration tests

Doh, good catch!


spawn a process to download atxs hinted by a server

Motivation
This backports https://github.com/spacemeshos/go-spacemesh/pull/5377 for v1.2 of the go-spacemesh node.
Changes

see https://github.com/spacemeshos/go-spacemesh/pull/5377

Test Plan

existing tests pass
works on testnet-10

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

i fixed some comments in the original change. i suggest to close this pr, i will handle backport once that change is merged

Original PR was updated and will be backported after merge.


Little improvements

+Deleted commented code
+Inproved performance with enhanced for in GDXFacebookGraphRequest

Hi jmarcher thanks for your PR. I try to keep changes only in the snapshot branch and then merge with master branch on release. May I ask you to create same PR for the snapshot branch?

Done :+1:


DR-475 ODS Comparator Tool

Description

Context

Type of changes

[ ] Refactoring (non-breaking change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] I am familiar with the contributing guidelines
[ ] I have followed the code style of the project
[ ] I have added tests to cover my changes
[ ] I have updated the documentation accordingly
[ ] This PR is a result of pair or mob programming

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[ ] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Can't comment against the file in the file view but do we need to persist  the binary file infrastructure/stacks/support_tools/misc/init.zip to the repo ? Or is the product  of a scripted build process


SageMaker ResourceLimitExceeded

Hi, I have a limit of 8 ml.g5.12xlarge instances, and although I set Tuner.n_workers = 5 I still got a ResourceLimitExceeded error. Is there a way to make sure that jobs are fully stopped when using SageMakerBackend before launching new ones?
Also, when using RemoteLauncher, in situations where the management instance does error out (for example due to ResourceLimitExceeded), is there a way to make sure the management instance sends a stop signal to all tuning jobs before exiting? Maybe something like:
try:
    # manage tuning jobs
except:
   # raise error
finally:
   # stop any trials still running

Regarding your first point, I agree that it would be good to have this functionality as an option (it should probably be an option as I would assume most of the time users does not want to wait the instance to be released as it can take several minutes).
Regarding the second point, this behavior should already be implemented as the tuner should stop all jobs before exciting even when an error occur, see [here].

I agree that the first point would allow users to better anticipate how large of a limit they need to request and the maximum number of workers they can use. I'm using 4/8 of my limit currently to make sure I don't hit a resource error.
Ah okay I must not have realized that stop signal was being sent, thanks!

Hi David, we may be able to do something about this.
The issue is that once the scheduler returns STOP, a trial is marked as stopped (which is the right thing to do, because the scheduler assumes that), but then of course it may take some time for the backend to really get the resource back.
I think it would be hard for the Tuner to figure out every time how many resources (for new trials) are really available. But given that the backend's start_trial (or, more precisely, _schedule) returns a status whether the new trial could really be scheduled, I think it is not hard to work out a clean solution. This would include a suitable timeout if a user really does not have the required quotas, so that certain trials new get started.

@geoalgo
I can work on a solution for this one. This would allow the backend's start_trial to signal that the requested trial cannot be scheduled right now. The Tuner would then have a mechanism to try again in the next round. However, if a trial cannot be scheduled after some timeout, we'd then throw an exception.

Hi David, but then we'd have to signal to the scheduler that the requested trial has not been started. Right now, schedulers assume that once suggest is called, a trial is started.
My feeling is this can be tested by mocking the backend.
In the end, asking users to set n_workers to much lower than their limit, just because of the brief stopping overhead, is not really good.

Hi David, but then we'd have to signal to the scheduler that the requested trial has not been started. Right now, schedulers assume that once suggest is called, a trial is started.

True, but we have the callback on_trial_error that is intended for this type of situations.

In the end, asking users to set n_workers to much lower than their limit, just because of the brief stopping overhead, is not really good.

To be clear, this is not the alternative I am proposing (which is to just have an option to not propagate capacity exception and let the tuner continue in such situations).

I looked more into this:

Calling on_trial_error is not the right thing to do, this marks the corresponding config as invalid, and the scheduler should avoid nearby configs in the future. Our situation is not an error, just the job cannot be scheduled right now
The scheduler registers the config as pending already when it is returned by suggest. This is important to make batch suggestions work, where suggest is called B times in a row

My proposal is just to decouple suggest calls (which may be done even if there are no resources right now, due to stopping being delayed) from scheduling the corresponding trials. If a trial for a certain suggested config cannot be started right now, you preferentially try next time. My feeling is this is cleaner than discarding the suggestion (which the scheduler has already committed to -- pending, register trial as running).

NOTE: Also requested by Jessie Luk

This request is related to another issue with the SageMaker backend, namely I sometimes get ThrottlingError's when the backend tries to start too many SM training jobs very close in time. This happens when n_workers = 16, or when several experiments are started at the same time. It happens just when the very first batch of n_workers jobs are started together.
But if we ran synchronous schedulers with SM backend, it would probably also happen.
We simply need a feature for the backend to re-try starting a trial.

The ThrottlingError issue is resolved with #342.
It is not clear (to me) whether this fix (changing the boto3 retry policy) would also help against the ResourceLimitExceeded issue here.
In general, I think that just retrying for a while will not really help when the situation blocking jobs to be started remains in place for a while (say, minutes).
In such a case, it would be better for the backend to log the request in a list and return (non blocking), and when asked to do the next thing, try again to work off the list.

This issue remains a problem due to long stop times for SM training jobs. This will likely be overcome, for our use case here, by SageMaker warmpooling, which we will support shortly. For this reason, I am closing this issue for now, but we are aware of this, and our goal is to make sure that you can use just as many workers with the SageMaker back-end as you have quotas to run.

Reopening, since I think I have a fix for this one.

This is solved by #389


Profile image doesn't update after clicking a "Recommended Post"

Browser: Firefox 56, Chromium 62
Operating system: Linux Mint 18

But I suppose this applies to all setups.

This should have been fixed in #1045

Closing this, please re-open if this issue still persists


Strong-name sign the assembly

Would it be possible to strong-name sign the WebAPIContrib.Core assembly that's published to NuGet.org?  Our team has a requirement that all assemblies in our product, including dependencies, must be strong-name signed.

Our team has a requirement that all assemblies in our product, including dependencies, must be strong-name signed.

Why would you have such a requirement? 🤔

that's the hill I might die on 😊


So when is this going to get updated for 1.17?

There's currently a 1.17 branch, but the latest commit doesn't compile, I'll fix that once I get to it and make a release.
There is no set release date.

Check the latest release


Manage version of maven-shade-plugin via pluginManagement

Fixes #11

This looks good to me, but there is a conflict on the branch


Wrong SVG rendering

Hi, the following SVG rendering is not right.
Result:

Expected Result:

SVG in GIMP:

color.svg.zip
Thanks

Thanks for reporting the bug!
Is this sample SVG generated by some program or is it handwritten?
I found that it specifies arc in path and it combines 3 of its parameters which are large-arc-flag, sweep-flag, x to a string 100, so it is large-arc-flag=1, sweep-flag=0, x=0 and svgdom parser does not like that, it expects spaces between the numbers, like 1 0 0. It does not look like it is according to the svg spec, but for example Firefox renders the image correctly. So I'll try to fix it in svgdom as well.

The bug is fixed in svgdom version 0.3.25.
Please test and close the bug.

Thanks for the quick fix!
The file has been generated using SVG optimize.


cant download from http://akoam.com/ - ERROR: Unsupported

Have latest version
youtube-dl==2016.12.20
got below error:
DownloadError: ERROR: Unsupported URL: http://akoam.com/video/85536/170782
Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.12.20. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[ ] I've verified and I assure that I'm running youtube-dl 2016.12.20

Before submitting an issue make sure you have:

[ ] At least skimmed through README and most notably FAQ and BUGS sections
[ ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.12.20
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

http://akoam.com/video/85536/170782 is now dead (404 not found). Any new examples?

From what I can see most of the content in the site are copyrighted, youtube-dl does not support sites dedicated to copyright infringement.


Numerous bug fixes for musl and other images.

Provide qemu-runner that allows native or non-native for any architecture, and install qemu-user binaries for x86 musl images. In addition, create symlinks so dynamically-linked binaries can be run, including for C++, with musl images.
Adding qemu-user runners is also useful for running dynamically-linked x86 binaries, since otherwise they may be unable to find the linked musl libc, and we cannot install it in /lib or /usr/lib due to conflicts with the system.

This is a very preliminary draft (will need a CHANGELOG entry once it's more established), but it aims to do the following:

Allow musl images to run dynamically-linked binaries
Add qemu-user and native runners for all musl images (very handy for x86)
Provide a single script for symlinking all musl libc locations, to ensure it is found.

bors try

I've fixed the bug with CI trying to use qemu-system (It had previously hard-coded qemu-arm, so CROSS_RUNNER was being ignored) for armv7-unknown-linux-gnueabi, so this should be ready for review. All targets pass (well, armv7-unknown-linux-gnueabi should pass).

looks good!
Would it make sense to actually have MUSL_SYSROOT as an ENV instead of simply a build arg?

If so we should probably prefix it as CROSS_MUSL_SYSROOT, but absolutely.


Component  is missing template or render function.

Environment
The project works locally and is deployed online. Page refresh error

Reproduction
project-name.zip
Describe the bug
[root@localhost ~]# node /data/wwwroot/cangjingge/nuxt3/.output/server/index.mjs
Listening on http://[::]:3000
[Vue warn]: Component <Anonymous> is missing template or render function.
^Z
[1]+  已停止               node /data/wwwroot/cangjingge/nuxt3/.output/server/index.mjs
[root@localhost ~]# npm -v
8.19.4
[root@localhost server]# npm why vue
<EMAIL_ADDRESS>node_modules/vue
<EMAIL_ADDRESS>from the root project

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>  node_modules/vue
<EMAIL_ADDRESS>from the root project
<EMAIL_ADDRESS>  node_modules/.pnpm/vue-router<EMAIL_ADDRESS>    dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>    node_modules/.pnpm/vue-router<EMAIL_ADDRESS><EMAIL_ADDRESS>      node_modules/vue-router
<EMAIL_ADDRESS>from the root project
<EMAIL_ADDRESS>  node_modules/.pnpm/@vue+server-renderer<EMAIL_ADDRESS>    peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>    node_modules/.pnpm/@vue+server-renderer@3.4.3_vue@3.4.3/node_modules/@vue/server-renderer
<EMAIL_ADDRESS>      node_modules/@vue/server-renderer
<EMAIL_ADDRESS>from the root project
        dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>        node_modules/.pnpm/vue-router<EMAIL_ADDRESS><EMAIL_ADDRESS>          node_modules/vue-router
<EMAIL_ADDRESS>from the root project
<EMAIL_ADDRESS>      node_modules/.pnpm/vue@3.4.3/node_modules/@vue/server-renderer
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
<EMAIL_ADDRESS>dev
node_modules/.pnpm/vue-router<EMAIL_ADDRESS>  dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/.pnpm/vue-router<EMAIL_ADDRESS><EMAIL_ADDRESS>    node_modules/vue-router
<EMAIL_ADDRESS>from the root project

<EMAIL_ADDRESS>peer
node_modules/.pnpm/@vue+server-renderer<EMAIL_ADDRESS>  peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/.pnpm/@vue+server-renderer@3.4.3_vue@3.4.3/node_modules/@vue/server-renderer
<EMAIL_ADDRESS>    node_modules/@vue/server-renderer
<EMAIL_ADDRESS>from the root project
      dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>      node_modules/.pnpm/vue-router<EMAIL_ADDRESS><EMAIL_ADDRESS>        node_modules/vue-router
<EMAIL_ADDRESS>from the root project
<EMAIL_ADDRESS>    node_modules/.pnpm/vue@3.4.3/node_modules/@vue/server-renderer
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
Additional context
No response
Logs
No response
### Tasks

nginx configures forwarding
location ~ /purge(/.*) {
      proxy_cache_purge cache_one $host$request_uri$is_args$args;
  }

  location / {
      proxy_pass http://<IP_ADDRESS>:3000;
      proxy_set_header Host $host:$server_port;
      proxy_set_header X-Real-IP $remote_addr;
      proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
      proxy_set_header REMOTE-HOST $remote_addr;
      add_header X-Cache $upstream_cache_status;
      proxy_set_header X-Host $host:$server_port;
      proxy_set_header X-Scheme $scheme;
      proxy_connect_timeout 30s;
      proxy_read_timeout 86400s;
      proxy_send_timeout 30s;
      proxy_http_version 1.1;
      proxy_set_header Upgrade $http_upgrade;
      proxy_set_header Connection "upgrade";
  }

Can't reproduce the error 500 with the given project when running the production build.

@manniL
I get a similar error when I use nuxt 3.9.0, vue 3.4.3 and nuxt-swiper 2.0.0-0(https://github.com/cpreston321/nuxt-swiper)
Reproduction without vue 3.4.3:
https://github.com/jony1993/nuxt-template-or-render-function-missing/tree/without-vue-3.4.3
dev
Its working, I just get some hydration mismatch errors
production built:
working without any logs
Reproduction with vue 3.4.3
https://github.com/jony1993/nuxt-template-or-render-function-missing/tree/main
dev
I get hydration mismatch errors and following:
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
[Vue warn]: Failed to resolve component: swiper-slide
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
[Vue warn]: Non-function value encountered for default slot. Prefer function slots for better performance.
[Vue warn]: Component <Anonymous> is missing template or render function.

even when I have following in the nuxt config:
  vue: {
    compilerOptions: {
      isCustomElement: tag => tag.includes('-')
    }
  }

production built:
500 Server error

@manniL
Seems to be fixed (at least for me) for vue version v3.4.5

The node version is inconsistent. 16 is of an earlier version. 【 _fetch is not a function】
The page data is null

@PdxLook Thanks for this. I was getting the _fetch is a not a function error and was having trouble tracking down why. It was because I had two different versions of Node installed locally and on production.

I had the same problem using nvm and PM2. I changed the version using nvm, but the PM2 still used the old one. Fixed it with pm2 unstartup and pm2 startup according to PM2 docs.

@braitsch  As long as I can help you

@PdxLook Can you please confirm that you still have this issue with the latest Nuxt and Vue version?


Fix common extension api bundling

We cannot export common extension api through @k8slens/core/common because it shares state with main & renderer.
Fixes regression from #7058 .

Closing because #7095 seems to be better fix.