Surge abilities, special abilities and passive abilities in deployment cards

Hi, would you be open to adding at least surge abilities to deployment cards? I'm writing a skirmish calculator (something like: Han vs Vader go run a monte carlo simulation of 5000 attacks). It would benefit from having at least surge abilities into the data model. I will then take into account passives and special abilities too.  If you want I can help with the job of adding such information in your model. I believe it's pointless to make my own data model and then aggregate it with your at runtime using same IDs. Let me know! Thanks!

@valeriodigregorio I have no issue with you helping out.
In fact, quite the contrary, I would love some help.
Just raise a PR for any contribution you would like to make.
Before you dive deep into the code, lets agree on a data structure that is flexible and extendable.
Deployment cards are not the only thing using surges for bonuses and it would be good to have all those things use the same structure. The same goes for passive and special abilities.
What do you suggest doing? What data structure would make sense for your project?

@lvisintini I believe implementation should happen incrementally as I reckon it will require a big effort. My idea at the moment is the following, in example ID 22 is Chewie (this is the JSON I currently integrate to your for debugging purpose):
 {
   "id": 22,
   "defense_pool": ["black", "white"],
   "attack_type": "ranged",
   "attack_pool": ["blue", "red", "yellow"],
   "abilities": [
     {
       "type": "surge",
       "requirements": {"surge": 1},
       "effects": {"damage": 2}
     },
     {
       "type": "surge",
       "requirements": {"surge": 1},
       "effects": {"stun": 1}
     },
     {
       "type": "surge",
       "requirements": {"surge": 1},
       "effects": {"accuracy": 2}
     },
     {
       "type": "special",
       "name": "Slam",
       "description": "Choose 1 adjacent hostile figure and roll 1 red die. That figure suffers <damage> equal to the <damage> results. Then if it is a small figure, you may push it 1 space."
     },
     {
       "type": "passive",
       "name": "Protector",
       "description": "While a friendly figure is defending, and you are adjacent to the targeted space, apply +1 <block> to the defense results. Limit 1 \"Protector\" ability used per attack."
     }
   ]
 },

Basically:

Attack type
Attack pool
Defense pool
Surge abilities (full implementation)
Special abilities (only name+description)
Passive abilities (only name+description)

Abilities names and descriptions can be taken with an automation from TabletopAdmiral webpage JS source code.
One step further, we can describe special and passive abilities in a much deeper way. With reference to Chewie's Protector ability an example would be:
      {
        "type": "passive",
        "name": "Protector",
        "description": "While a friendly figure is defending, and you are adjacent to the targeted space, apply +1 <block> to the defense results. Limit 1 \"Protector\" ability used per attack.",
        "requirements": {
          "time": {
            "target": ["self"],
            "trigger": ["while_defending"]
          },
          "range": {
            "target": ["targeted_space"],
            "distance_min": 1,
            "distance_max": 1
          }
        },
        "effects": {
          "target": ["friendly", "defender"],
          "block": 1
        },
        "limitation": {
          "per_attack" : 1
        }
      }

However this is too much for what I need to do, but it's a description of the wider vision I have on the topic. I believe an event-driven AI could be actually able to take actual game decisions using such detailed model. But let's keep this ideal... :) It's good to plan for smaller increments keeping in mind the big picture, though.

You have given this quite a lot of thought.
I agree with the incremental implementation so long as each step is complete in its implementation (no entries with missing data) and consistent across files.
I have a few comments...
I like the first implementation much better that the the second. Simple is better.
I would have the attack stats be more like:
          "attack": {
            "type": "ranged",
            "pool": ["blue", "red", "yellow"]
          }

as it is easier to set "attack": null for all the deployment cards that do not have an attack attribute (like skirmish upgrades)
I would adapt things like  {"stun": 1} to something like  {"effect": "stun", "amount": 1} as it is very difficult to tests for consistency across all entries if you have variable property names for JSON objects.
The resulting JSON schema adaptations will remain easy as well
I don't have a proposed structure myself at the moment. Sorry.
The second more-complex implementation of special abilities is perhaps a bit too much.
There is a few deployment cards there that will share the same special abilities, and any updates in one of them should be mirrored in all the deployment cards that have the same ability.
Here you could make the case that you would want to compile all special abilities into their own data file and reference them by name (or id) in order to make the whole thing DRY
Then, you would have to have an structure for special abilities that is common to all special abilities, something that will likely going to be to difficult to implement, read and maintain.
Perhaps the best approach is to keep the implementation of the special ability outside the data set.
You could map the special ability name to the function or method that handles the behaviour in your project.
That way the special ability is referenced in the dataset, the details of the implementation existing in the individual projects that use the dataset.
mmmm.. I need to think a bit more about this but right now I'm in the office.
At any rate, I would imagine that Cannonical names and adding the missing command cards take precedence over this for the moment.


Retrieve all images in catalog during conversion

Kind of change

[x] Bug fix
[x] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement

Description
What is the goal of this pull request?
DRAFT PR, WIP
Offer users the option to obtain images from the assets catalog.
However, it only works when calling load()+getContent(), and unlike in Asciidoctor Ruby, we cannot call convert because it fails (see comment).
How does it achieve that?
Exposes the images properties from the catalog.
However, this PR is not done yet untill:

[ ] Fix using convert to obtain the Document instance
[ ] Fix catalog not being available when using custom converters (see failing test WhenReadingImagesFromCatalogAssetFromConverter) :point_right: I think that fixing the first issue should fix this.
[ ] Docs

Are there any alternative ways to implement this?
WIP
Are there any implications of this pull request? Anything a user must know?
Not
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1166
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc

Is that what you mean with "it fails"?

Yes, haven't had time to check yet. I assume there's some error in the bindings that should not be very complicated :crossed_fingers:

I see we explicitly check the return type and just insert null https://github.com/asciidoctor/asciidoctorj/blob/0240f02d54268bc484d6da210d0803c0156578e0/asciidoctorj-core/src/main/java/org/asciidoctor/jruby/internal/JRubyAsciidoctor.java#L310.
And going back into the git history I could not find a real reason for it, seems to come from initial versions and it has been preserved. Could be that we considered returning Document odd when the Java AST was not well defined.
I think the best is to align with Asciidoctor Ruby and we should not take decisions that limit functionality.
I have changed that, and furthermore seeing the code now I see why convert may return the dynamic Interface instead of a proper String. I'll open a separated issue for that.

I can't recall if this has always been the case, or whether I changed it to this to avoid the problems with the wrappers generated by JRuby.
At least for AsciidoctorJ 3.0 we could check if the expected class is an AST class, and in that case try to apply the NodeConverter.

At least for AsciidoctorJ 3.0 we could check if the expected class is an AST class, and in that case try to apply the NodeConverter.

That's my idea, adaptReturn takes care of it for now in a simple way. In another PR we can improve and create some fancy Java class ReturnTypeAdapterVisitorPattern.
But for now, it gets the job done.
I just updated the changelog, nothing else to add or change from me.

anything else to improve? 👀

Sorry for being behind a bit, I'll check it over the weekend.

Thanks! Looks good to me.

Thanks!


upgrade to latest dependencies (#1110)

bumping knative.dev/pkg 80c511a...708dc1c:

708dc1c Update community files (# 2443)
062ca30 upgrade to latest dependencies (# 2433)
4fcbc1b Update actions (# 2434)
bumping knative.dev/hack cf8cbc0...e178598:
e178598 Update community files (# 157)
bumping knative.dev/eventing 2a69eec...cbf1b08:
cbf1b08 Switch to at least 1 event in new trigger filters e2e featurset (# 6193)
354a69f Set TerminationGracePeriodSecond for wathola-sender to 300 seconds (# 6192)
3939dc6 :lipstick: Adding missing k8s labels to the post install manifests (# 6184)
74cebc5 Rename new trigger filters sql field to cesql (# 6148)
792f56d Update dependencies (# 6173)

Signed-off-by: Knative Automation<EMAIL_ADDRESS>

OCF Webhook is merging this PR


Merge release 2.2 -> master

Manual merge replacing automated PR
cc @natemcmaster

Yeah those failures are not new, vsts is the EF time out issue.  I'm not sure exactly why travis is failing in one instance, but it was failing in the other PRs as well.

We should really get to the bottom of this. From @smitpatel's last comment on https://github.com/aspnet/EntityFrameworkCore/issues/12842, it appears that EF's async tests can deadlock. Is Identity doing a bunch of async queries in EF?

Yeah tons of async queries


New marshal

Amongst other things, this includes

Pure marshal functions
An unchecked version of fromJSRef (fromJSRefUnchecked)
To/FromJSString are made a subtypes of To/FromJSRef.

I think this pull request became stale. The change do not seem compatible with the current codebase.

I think all the changes in this were all made in the move to new-base.


[FLINK-7508][kinesis] switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode

What is the purpose of the change
KinesisProducerLibrary (KPL) 0.10.x had been using a One-New-Thread-Per-Request model for all requests sent to AWS Kinesis, which is very expensive.
0.12.4 introduced a new ThreadingMode - Pooled, which will use a thread pool. This hugely improves KPL's performance and reduces consumed resources. By default, KPL still uses per-request mode. We should explicitly switch FlinkKinesisProducer's KPL threading mode to 'Pooled'.
This work depends on FLINK-7366 and FLINK-7508
Benchmarking I did:

Environment: Running a Flink hourly-sliding windowing job on 18-node EMR cluster with R4.2xlarge instances. Each hourly-sliding window in the Flink job generates about 21million UserRecords, which means that we generated a test load of 21million UserRecords at the first minute of each hour.
Criteria: Test KPL throughput per minute. Since the default RecordTTL for KPL is 30 sec, we can be sure that either all UserRecords are sent by KPL within a minute, or we will see UserRecord expiration errors.
One-New-Thread-Per-Request model: max throughput is about 2million UserRecords per min; it doesn't go beyond that because CPU utilization goes to 100%, everything stopped working and that Flink job crashed.
Thread-Pool model with pool size of 10: it sends out 21million UserRecords within 30 sec without any UserRecord expiration errors. The average peak CPU utilization is about 20% - 30%. So 21million UserRecords/min is not the max throughput of thread-pool model. We didn't go any further because 1) this throughput is already a couple times more than what we really need, and 2) we don't have a quick way of increasing the test load

Thus, I propose switching FlinkKinesisProducer to Thread-Pool mode.
Brief change log

switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode
update docs

Verifying this change
This change added tests and can be verified as follows:

added unit tests in flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java

Does this pull request potentially affect one of the following parts:
Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@tzulitai Hi Gordon, can you please take a look at this PR?

@tzulitai Thanks, Gordon! I watched your presentation on "managing state of Flink", and you did a great job explaining all details.
I added an option for PER_REQUEST model since it doesn't hurt anything.
This PR is for 1.4. There's another PR here I think need to be merged to both 1.4 and 1.3.x

Thanks :)
LGTM! Merging this ..

@tzulitai Thank you!


Error setting watches. Result: -33: This request is serviced by a module of DCGM that is not currently loaded

hello, I am using p100 gpu, and there is a problem that more than 1000 features(1002,1003,1004,1005....) are not work with this error code

Error setting watches. Result: -33: This request is serviced by a module of DCGM that is not currently loaded

Features less than 1000(e.g. 82,83....)  work fine
p100 is using an AC1 instance of IBM CLOUD (ubuntu18.04,cuda11.4,python3.7)
dcgm was downloaded with the following command.

wget https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/cuda-keyring_1.0-1_all.deb
sudo dpkg -i cuda-keyring_1.0-1_all.deb
sudo add-apt-repository "deb http://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/ /"
sudo apt-get update && sudo apt-get install -y datacenter-gpu-manager
sudo systemctl --now enable nvidia-dcgm

When I type dcgmi in the terminal I get:

@mintchocohoco,
The DCP metrics (1001...) are supported starting from Turing architecture. Pascal is not supported.
For some metrics (1013,1014) you would need at least an Ampere GA100 chip.

thank you so much!
I also tried on A100 gpu, and the result values of 1002,1003,1004,1005,1007 features are all 0. Maybe the A100 gpu doesn't support it?


Environment promote command

Is your feature request related to a problem? Please describe.
Being able to run deployEnvironmentPromote mutations
Describe the solution you'd like
lagoon promote -p <project> -s <source> -d <dest>

Closed in #74


EXTRA_OPTIONS should append instead of prepend to the existing JVM options

Currently the EXTRA_OPTIONS could be overridden by an existing JVM option, for example, -Xdump:java:events=vmstop is specified at EXTRA_OPTIONS, and the actual JVM command is -Xdump:java:events=vmstop ... -Xdump:system:none  ....  The option supplied has no effect.
The EXTRA_OPTIONS should append instead of prepend to the existing JVM options.
FYI @llxia

@annaibm could you take a look at this issue? Thanks

Please check where EXTRA_OPTIONS is contrustured and used. For example:
https://github.com/search?q=repo%3Aadoptium%2Faqa-tests system%3Anone&type=code

The issue in openjdk did not get resolved yet.

Thanks @annaibm's verification. In openjdk test, https://github.com/adoptium/aqa-tests/blob/2ea383b607d7c1bbb18c67ad3d11fd5e77bbe0a0/openjdk/openjdk.mk#L177 , EXTRA_OPTIONS is appended.

This issue is resolved.

Thank you @annaibm @llxia


Proposal: Better SchemaPiece options

Describe the proposal
Since SGv1, in the PR #255 from Komada, we had the first implementation of SchemaPiece being able to store more than a single value of the same type (instead of being type array, from the former configuration system).
However, this system is extremely old and should be renamed and refactored into something much better, in this proposal, I'll use SchemaPiece#multiValue as a placeholder for a better name.
What does SchemaPiece#multiValue do compared to SchemaPiece#array? The current name limits the options, the values may be contained inside an array or not, but, what if I want to use Set or Map? The current system does not allow it, but multiValue will.
Implementation
There are multiple ways to achieve this, but I'll present two in this proposal:
ValueController
This is more versatile, it allows custom types and moves some of the heavy work from SG to them, it also allows users to implement their own ValueController, for example, one being Collection extending Map and so on. Compatibility with string for simplicity in SchemaFolderAddOptions is accepted with a later resolve.
Said ValueController would implement basic methods such as create, clone, add, remove and modify and they could be stored in GatewayDriver together with the available key types.

Internal Resolving
This is less customizable and more hardcoded, plus makes SettingGateway's internals much heavier. These methods would be integrated in a different file (similar to a util) for later usage.

In both options, you'll be able to do
SchemaFolder#add('tags', { type: 'string', multiValue: 'Map' });

And the new values will be stored in the Map. However, some of the multiValue may not be able to be directly configurable, so they'll have the same behavior as type: 'any': sets SchemaPiece#configurable to false.

This proposal is not merging on #179 but in a later one.

The example of using set in this is completely useless because Array already removes/adds by default, which is the equivalent to using new Set().
As for map you have issues:

what should you do about storing discord.js structures
what about non-discord.js structures that don't have a id value (storing a complete json is going to get pretty overkill as the map increases in size

Not quite. Set#has() is faster than most methods for Array. And there can never be two entries with the same value (like in Array) but it benefits on how easy it is to use. SettingGateway would buy an instance of Set instead of Array when the key requires a Set.
That's an issue for ValueController, not for the proposal itself, although that can be handled, it's up to the developer to not do such practises.
In case of Map, it's unaffected. Why? Because one simple fact: I cannot store hashed collections (Map/WeakMap/Set/WeakSet) into a database, I need to convert them to array first.

For example, the following Map instance:
Map { '224236171838881792' => { colour: 'red', animal: 'dog' } }

Is stored into a JSON db as:
[
    ['224236171838881792', { colour: 'red', animal: 'dog' }]
]

Then if you pass the array above into new Map(), you'll get the first map. And it does not have a property of id, instead, it's mapped by a key that serves as id.

Why can't you just do an object instead of map then
{
  '224236171838881792': { somedata }
}

Because that requires the iteration of an object's keys with Object.keys() which performance is 27 times lower than iterating an array by index. Building so many Configuration instances and needing to run Object.keys in one or more keys in every single one of them may result on a slow startup.
Outside performance, it's a pain for TypeScript users to handle that, and it's also an antipattern, it should not be made.

TypeScript has no bearing on this conversation. realistically this is only going to be used by Javascript users.
It's already going to be taxing on performance and startup for having to iterate over the parsed array to create the map.
It's also going to create a new interface that will be more ambiguous compared to the other ones
<Config>.someObjectKey["Object"]
<Config>.someArrayKey[0]
<Config>.someString -->

It's not taxing on performance if the array is empty, which it's the case for the 50% of cases. new Map() doesn't iterate the array if it's empty. Unlike your idea of an object, that needs to run an expensive function (which filters ~7 built-in properties of Object, so it always has keys to iterate).
Not to mention that when you add/remove a property from an object, you are rebuilding it from scratch, so, it's an incredibly bad idea, and remember that we have discussed about this in Komada 0.20.0 development. This behavior does not happen in a Map as it's a collection of key/value designed to have a variable amount of entries, which objects aren't (due to their nature of immutability).
What you're proposing is much more taxing than my proposal in both CPU and RAM, as well as it contains antipatterns that seriously affect the performance in V8, it's all based on program optimization.


Make setup script work with private forks/local repos

ATM the tpu setup scripts assume we're cloning the main github of levanter. To facilitate development of other models etc., we should do something different.
Possibilities:

scp the current levanter checkout
git clone the current  levanter checkout on the remotes and checking out HEAD (presumably a shallow clone?)
git clone the upstream

for reproducibility, i would lean towards (2), maybe with a warning if HEAD is dirty.
cc @Ivan-Zhou

this is actually fixed


Add device and base class usage to Deepsvdd

All Submissions Basics:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?
[ ] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
[ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

[ ] Have you created a .py in ~/pyod/models/?
[ ] Have you created a _example.py in ~/examples/?
[ ] Have you created a test_.py in ~/pyod/test/?
[ ] Have you lint your code locally prior to submission?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

9 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 95.68%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
9678

Relevant Lines:
10115

💛  - Coveralls


Sync APIs should support HTTP request cancellation

During the Azure Core HTTP pipeline tech talk, there was a proposal to add the ability to cancel a HTTP request from sync clients. For users of Async clients, a request can be canceled by unsubscribing from the publisher to cancel the request but sync APIs don't have the ability to cancel a request.

Closing this one, we're not going to implement this for sync API.


consumer group and route relation?

If I route the messages based on message body, what happens to default consumer groups? both consumer group and route works together?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f233412c-4242-e9a6-e09d-c5b07775dd00
Version Independent ID: 3a940d2c-77bb-b8ff-8864-9fc6ef16c122
Content: Configure message routing with Azure IoT Hub (.NET)
Content Source: articles/iot-hub/tutorial-routing.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

@kudlatiger Thank you for the valuable feedback,we are investigating the issue.

The consumer group can be used by the Azure Stream Analytics when retrieving the data. It has nothing to do with the routing itself, and is optional.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Recaptcha v2 and v3 not working in Android webview

I have recaptcha included in sign in (v3) and sign up (v2) pages.
It works went using the website directly via browsers. But when building the android app using webview, recaptcha does work.
Message: Could not connect to reCAPTCHA service. Please check your internet connection and reload to get reCAPTCHA challenge.
The website is https://jobman.uk.tempcloudsite.com/account/signup
The app source file is https://github.com/josiahking/tabrisjs-webview-demo

Hi, am still looking for solution to this.

Hello!
I'm using Cordova (with Vue as the main framework) with ReCaptcha v3, have disabled the domain validation (origin check), still, getting the error Error for site owner. Invalid domain for site key. This happens only in native apps, works fine in mobile browsers.
Anyone faced this, kindly help...
Thank you.

Hello!
I'm using Cordova (with Vue as the main framework) with ReCaptcha v3, have disabled the domain validation (origin check), still, getting the error Error for site owner. Invalid domain for site key. This happens only in native apps, works fine in mobile browsers.
Anyone faced this, kindly help...
Thank you.

I am facing the same issue. Is there any solution ?
Basically captcha does not return any verify token.

Did anyone manage to get any workaround?

Running into issues with Android and reCAPTCHA v3 as well. Anyone have any updates?

Hi, this worked for me.
Do not change the user agent of WebView. The default one will work perfectly. I implemented WebView in my this app (https://play.google.com/store/apps/details?id=com.androidbull.incognitobrowser.lite) and it worked perfectly fine.
Even if you change the user agent, you set the latest android version there. Like this
"Mozilla/5.0 (Linux; U; Android 11; de-de; GT-I8190 Build/JZO54K) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30"
Hope it helps

use dimension 100% in webview

At me it worked if I set UserAgent as this:
mWebView.getSettings().setUserAgentString("Android");


Remove MidnightBSD from classifiers

It's not an official classifier :)

This affects #292
CC @jdufresne

This affects #292
CC @jdufresne

Thanks for the ping. I removed it in the related PR too.


[Suggestion] Use wormholes and like news in non-boss lanes on x00 levels

This isn't my original idea, but someone suggested using like news and wormholes in a lane other than the boss lane. Like news only refresh the current lane; if you're not in the boss lane, nukes won't get refreshed. Of course, people could just switch to the like new lane, but that requires more work for the troll.

pls read previous issues


IGNITE-9541 Add the comparison for two general statistics "RunAll" for master in the date interval

I've applied PR locally and tried it on existing DB. The result is a failure by not found build
 'Exception UncheckedIOException: java.io.FileNotFoundException: Service https://ci.ignite.apache.org/app/rest/latest/builds/id:1362502 returned not found error.Responding with error, status code: 404 (Not Found).
Details: jetbrains.buildServer.server.rest.errors.NotFoundException: No build found by id '1362502'.
Could not find the entity requested. Check the reference is correct and the user has permissions to access the entity.

It is quite normal TC Bot has reference to build, but TC don't have it (history in the bot is longer that in TC), so it is up to bot correctly handle absent REST requests.


Healthcheck is logging errors to access disk in thumbor-nginx

Special case that is not necessary to do failover:
nginx_1 | 2016/02/08 10:02:39 [error] 7#7: *8 open() "/data/result_storage/v2/he/al/healthcheck" failed (2: No such file or directory)

Fixed here: https://github.com/APSL/docker-thumbor/commit/237fa0e08788572155c749c8e99a16fd06b366c5


Allow to split an editor by dragging down like Visual Studio

hi, vscode has publish the split editor in group for lots of months. https://code.visualstudio.com/updates/v1_61#_split-an-editor-without-creating-a-new-group
but It 's hard to use beacuse it is obscure.
please impove the entrance of useage:

add right click menu in minimap. 👍  FYI: https://github.com/microsoft/vscode/issues/148131
LIKE VS2022, WE CAN drap to split and drap back to unsplit

https://github.com/microsoft/vscode/issues/142840

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


fix(dropdown): truncate the header and content

Truncates the text content and header for DropdownItem by supplying appropriate props to ListItem.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


[FR/RFC] Extensions that don't have windows opened for them

I'm attempting to create an extension for edgy.nvim, to save the layout state and reopen windows using edgy views' open function / command via string.dump and loadstring. The problem is that edgy, and plugins such as sidebars, create their own windows so when they are opened by the extension, a window is created in the layout and the extension creates its own window. This leaves blank / extra windows in the layout after loading.
It would be nice to have extensions that are able to save state of individual windows, but not open new windows when the session is loaded so that the extension can create its own window. It is currently possible to get this behavior by manually closing the original window in load_win, but that leads to some janky behavior and flicker.
I'd be interested in contributing a PR for this, but figured I'd open an issue to discuss it first.

I'm not sure how much sense it makes to try to make an extension for edgy, since all that plugin is doing is placing windows. Wouldn't it make more sense to create extensions for the plugins that own those windows? It doesn't seem like saving and loading a window layout should have anything to do with edgy. I don't personally use edgy though, so I might be missing something here.
As for saving/loading state of individual windows, this is the intended behavior for load_win. The problem is that the only way for us to restore the same window layout is to do a bunch of manual split/vsplit calls to create the layout, then go window-by-window and restore the contents of each. If a plugin supports opening/restoring in a targeted window, then it works great (e.g. aerial).
If the plugin doesn't support that (e.g. the quickfix extension), then we have to do some "open a new window and close the original" hacks. I would be interested if you have any ideas for how to avoid these kinds of hacks, but AFAICT the only way to do that would be to make PRs upstream to these sidebar plugins to add an API to open them in a pre-existing window.

I'm not sure how much sense it makes to try to make an extension for edgy,

The reason why I think an extension for edgy is a good idea is that it provides a unified interface for functions to open a particular view/filetype, and the data for a window can be retrieved with edgy.get_win(winid) which makes saving the layout state easy and allows supporting a wide range of plugins all at once. The only data that really needs to be saved is the filetype, and the dumped bytecode for the open function.

As for saving/loading state of individual windows, this is the intended behavior for load_win

Yeah, it definitely makes things more difficult if plugins don't support that, which unfortunately many don't.

I would be interested if you have any ideas for how to avoid these kinds of hacks

I'm not sure, but would it be reasonable to save some windows separately in a list of "detached" windows, and essentially ignore them in the layout? Then, when a session is loaded these can be restored after the main layout is setup. That way the layout can be reconstructed and then the plugins that manage their own layout can do so without breaking things. This may lead to some nondeterminism for plugins that don't always attach to the edge of the screen, so it would pretty much entirely be for sidebar-type plugins (and maybe floating windows? not sure if they're supported atm).

So you're saying that edgy effectively provides this "open plugin in window" API for any plugin? If that's the case then that definitely sounds interesting. We could use that as some sort of a "fallback" extension if there is no specific extension configured for a window.

I'm not sure, but would it be reasonable to save some windows separately in a list of "detached" windows, and essentially ignore them in the layout?

I don't think this will work in all cases. If a window it a botright split or topleft vsplit or similar, then maybe it could work. But it requires a lot of special case code and doesn't handle cases like below where we would want to restore sidebar A
┌───────────┌─────────────┐
│           │             │
│           │             │
│  file1    │  file2      │
│           │             │
│           │             │
┌───────────┌───┐─────────┘
│           │   │         │
│  file3    │ A │ file4   │
│           │   │         │
│           │   │         │
└───────────└───┘─────────┘

I'm not keen to make the window restore logic more complex, but doubly so if it doesn't even handle general cases.

and maybe floating windows? not sure if they're supported atm

Floating windows are not supported. I don't think they're worth supporting, as it would be a decent amount of work and most of the time their contents are ephemeral and don't need to be saved.

Another issue I ran into with my extension is that when using :q when focusing the "main" buffer (whatever file I'm editing), nvim quits and the only layout restored is the sidebar window.

No easy fix for this, I'm afraid.  It saves what you tell it to save, so if you call save when there's just a sidebar window open, it does what you tell it. You could try putting some logic in BufHidden or similar to catch when you're closing the last "main" buffer and will only have a sidebar left, and save at that point while also keeping track of it so you can avoid saving when vim exits. But fundamentally you'll either have to do something like :qa or you'll have to "look ahead" and detect when your sidebar plugin will quit vim in the future, and save before that happens.

So you're saying that edgy effectively provides this "open plugin in window" API for any plugin?

It's part of the config so users would have to add their own open functions, but yes.
The open function (or vim command) can be retrieved easily, we can just ignore windows without open functions. My is_win_supported function looks something like this:
local win = require("edgy").get_win(winid)
return win and win.view.open

But it requires a lot of special case code and doesn't handle cases like below where we would want to restore sidebar A ... I'm not keen to make the window restore logic more complex, but doubly so if it doesn't even handle general cases.

That definitely makes sense. You're right, in retrospect that wouldn't be a very good solution. Maybe a better solution would be saving the entire edgy state in the extension using on_save and restoring with on_post_load? That way no windows will be created and no changes would be needed. I'll try that out and update here.

Floating windows are not supported. I don't think they're worth supporting, as it would be a decent amount of work and most of the time their contents are ephemeral and don't need to be saved.

I agree, definitely not necessary. I don't think it's worth any extra code but if development of some other feature made it work then that wouldn't be a bad thing.

You could try putting some logic in BufHidden or similar to catch when you're closing the last "main" buffer and will only have a sidebar left

That's what I was thinking, but have opted for just using :qa. I just disabled the feature that closes edgy windows automatically, so I have to use :qa.  With that setting enabled, saving a session with only an edgy window open will lock the session into a "loop" where nvim quits as soon as it's opened because edgy sees there are no other windows and tries to quit immediately. Disabling the feature ensures this will never happen. The lookahead idea is interesting though, I may try that. Maybe a WinClosed autocmd that loops through other windows and saves the session if it finds only edgy windows would work, and I could remove my VimLeavePre autocmd.

I don't think there's actually any change needed after discussing this, if I just save state that's not specific to a window in the layout then it seems to work fine, as long as I use :qa.
Thanks for your input! I'll link my edgy extension when it's more complete. I would be happy to submit it as a PR if you want, or I can just keep it in my config :)

Edgy extension works pretty well as long as :qa is used. I'm attempting to figure out the lookahead to allow :q to be used as well.
Restoring DAP UI:
https://github.com/stevearc/resession.nvim/assets/38540736/0c49648a-6c1a-4a61-808e-2be4c486045f
Restoring ToggleTerm terminal and Trouble diagnostics:
https://github.com/stevearc/resession.nvim/assets/38540736/e5be9481-0a3b-483d-95e3-ece27d4296ab

Ahhh interesting. This does seem like a neat extension! I'd be interested in bringing this upstream to either edgy or resession.
There a few things I'd want to hammer out first. Not all of these need to be fixed, but there should at least be some conscious decisions made.

It only works for the current tabpage
We need some way to make sure it doesn't conflict with existing extensions (i.e. aerial has a specific extension, so it should be managed by that even if there is an edgy config for it)
Seems like disabling the animation didn't work (from the ToggleTerm + Trouble video)
The second arg to vim.notify should be vim.log.levels.WARN

Awesome, sounds good!

It only works for the current tabpage

Good to know, since I've only tested with tab-scoped sessions. Definitely should work with multiple tabpages, that may be doable by saving tabpage number with each window so it can be reopened in the appropriate tab, or ignored if the tab is not reopened?

Seems like disabling the animation didn't work (from the ToggleTerm + Trouble video)

Yeah, still ironing that out, but I believe that animation was from mini.animate and focus.nvim and the edgy.nvim animation is actually disabled here. I've since added a toggle of focus.nvim to my edgy config (not to the extension itself) and it seems much smoother.

The second arg to vim.notify should be vim.log.levels.WARN

For sure, I'll make that change. I've never been sure which it's supposed to be as I see people using both strings and vim.log.levels and both seem to work haha.

Also, I have since gotten :q to work via a (somewhat hacky) QuitPre autocmd:
vim.api.nvim_create_autocmd("QuitPre", {
  group = au,
  callback = function()
    resession.save("last", { notify = false })
    local wins = vim.api.nvim_tabpage_list_wins(0)
    local nwins = #wins
    -- Check if there are normal (non-edgy & non-float) windows in the layout
    if has_normal_win(wins) then
      local name = vim.fs.basename(vim.fn.getcwd(-1) --[[@as string]])
      resession.save_tab(name, { notify = false })
      -- Check if we're closing the only remaining normal window
      -- hacky fix because sometimes this can freeze (not sure why)
      if last_win_closing(wins, nwins) then
        vim.api.nvim_exec2("qa!", {})
      end
    end
  end,
})

Definitely should work with multiple tabpages

I agree. It will probably work if you just iterate over the tabpages when you save & restore, but will just need to double check that it works

the edgy.nvim animation is actually disabled here

cool, that seems fine then

I see people using both strings and vim.log.levels and both seem to work

The default implementation uses vim.log.levels
https://github.com/neovim/neovim/blob/e46f5aab895f333d23d6adf490e13177c8d3c1d8/runtime/lua/vim/_editor.lua#L595-L603
But nvim-notify accepts either
https://github.com/rcarriga/nvim-notify/blob/e4a2022f4fec2d5ebc79afa612f96d8b11c627b3/lua/notify/service/notification.lua#L22-L24

Not sure about this one yet, but maybe extensions could be configured with a priority?

I think a priority would work. Seems like a pretty reasonable solution to me

cool, that seems fine then

Actually not sure that's fully working, I'm still figuring it out but it may depend on whether edgy is loaded before resession or not. Current implementation is usually smooth but every now and then you can see the plugin windows open before edgy "takes control" of them.

But nvim-notify accepts either

Gotcha, that's why both are working for me. Good to know, I'll always use vim.log in the future. Thanks!

I think a priority would work. Seems like a pretty reasonable solution to me

Cool, sounds good. I'll start working on a PR for this soon :)

I'm not sure there's a way to get the tab number of the currently saving session, so that may need some special handling

I think nvim_list_tabpages returns them in order, so if you iterate over them you get the tabnr, tabpage.

Yes, but the current tabpage may not always be the currently saving tabpage, and on_save is not passed the tabnr of the currently saving session. So not sure how I'd determine which of those results should be saved. Non-scoped sessions should be all good though. I'll try to come up with a way to handle this.

Edgy extension now works with multiple tabpages:
https://github.com/stevearc/resession.nvim/assets/38540736/ae14e185-e824-461d-ae25-d0338e45ad16


[Java] Container with most water

Please assign this issue to me.

okay, go ahead by forking the repo and make a PR

Can you help me with it ,AS  i am new ,So cant able find with the "[ Java ] Container with most water "  As i cant see in  the code panel . Plz do help me

You have to create the directory on your own and commit the files.
Go through the contribution guidelines for more clarity.

Can you assign this issue to me .

PR merged, issue resolved


Which CHIRP version?

Hi. I cannot get this to work with the new version of CHIRP. According to egzumer, the egzumer driver is now included in CHIRP but I'm getting "Firmware 'F4HWN v2.2' is not supported."
The F4HWN mod seems to work with egzumer's own CHIRP build.
Any thoughts what might be going on there?
Thanks.

Hi
You can find a special nice version here
and have some help to use it.
Best regard
Boris

Indeed, this is the one which works for me. Thank you.
HOWEVER, the question is: given that CHIRP and egzumer both say that the egzumer driver is included in CHIRP now, I wonder why CHIRP doesn't work with the F4HWN mod?

Some function work with Egzumer, but haven't full function.
And Chirp use signature version to detect if driver is correct (eg 2.0 and 2.5).
F4HWN make many mods

Je crois que CHIRP effectue des certaine validations et que le driver effectue également les autres.
J'ai remarqué que je ne peux pas non plus utiliser le nouveau CHIRP avec un egzumer "normale", puisque je ne suis pas autorisé (par CHIRP, j'imagine) a entrer des fréquences de bande de 11m.

Hi,
My firmware is experimental. As long as my firmware continues to evolve, you'll need to use the dedicated driver. If, and only if, my firmware stabilizes and becomes widely used (like Egzumer's), Chirp may choose to add it natively. But we're a long way from that.
Now, note that using a dedicated driver is not complicated. It's just a little effort.
73'
Armel F4HWN.

I'm perfectly happy and comfortable to continue to use egzumer's driver. It's no chore at all. I'll also be continuing to use your firmware, as I really like the way it is shaping up.
I don't fully grasp the connections between the versions and their drivers. I present the following as facts:

It's not clear that your users still need to use egzumer's driver.
It's not clear why, even though egzumer's sriver IS now included in CHIRP, it still doesn't work.

I wonder if uptake of your build might be larger if folk weren't upset and put off my CHIRP telling them it doesn't work?
Hope this is helpful.


[Intel MKL]Requantization op perchannel support

Requantization_Perchannel_op

Adding two new hidden operators to support requantization to be performed perchannel and provided the mkl implementations for the same.
 1. requantize_per_channel_op
 2. requantization_range_per_channel_op

Provided Unit test to test the implementation logic of both these above mentioned ops.

Looks like the other author that @googlebot has a CLA problem with is me. Manually setting CLA to yes then.

@penpornk haven't completed it! will ping you late this evening or tomorrow and confirm edits. :)

@nammbash Got it. Please take your time. :) And don't worry about the CLA. I have a feeling google bot will do this a lot. I'll just change it again after we are done with the PR.

https://github.com/tensorflow/tensorflow/pull/25203#discussion_r252807962
good suggestion. Learnt something new today thank you!
although it is reduction(max : out_min_max) and worked only with the max function and not without it! Changes done.

@penpornk changes done!
side note again: there is another PR that needs to go in related to perchannel. (#25506)

@nammbash gentle ping to  check test failures.

@rthadur Interesting!

some of these are not related to CPU. (Like the GPU CC) . Correct me if I am wrong.
the test //tensorflow/tools/api/tests:api_compatibility_test passes in c++. Is there a python version of the same test? Let me check into that

@rthadur @penpornk
Interesting findings on the build server failures. per your issue-comment: https://github.com/tensorflow/tensorflow/pull/25203#issuecomment-461208892
I am ignoring the following failures as it does not pertain to my PR:
GPU CC
GPU python 3
MacOS
Windows Bazel GPU

The pertaining ones then is this
Ubuntu python2
google build server error as displayed by web link points to the test:
tensorflow/tools/api/tests:api_compatibility_test

and hints problem to be in the pbtxt apis of RequantizePerchannel. RequantizeRnagePerchannel and requantize.

Findings when I run it locally

Bazeltest  succeeds if I use "bazel test" directly.

bazel --output_base=../google_fail test tensorflow/tools/api/tests:api_compatibility_test

if I build it separately and then run it as the log online seems to indicate

bazel --output_base=../google_fail build tensorflow/tools/api/tests:api_compatibility_test
then
a. bazel-bin/tensorflow/tools/api/tests/api_compatibility_test --update_goldens True (success)
b. bazel-bin/tensorflow/tools/api/tests/api_compatibility_test  (Failed)

yet the failure seems to not have any mention of perchannel or requantize ops.

Analysis Conclusion:(see findings below)
1.  I believe that google build server is having some issues,
or
2. maybe with this specific run
or
3. bazel bug??! Internal bazel build is different than what I have locally?? locally
I am using bazel version: 0.19.2 running on Ubuntu xfce: 4.12

Hence I believe the failures are not related to the PR and related to bazel itself? correct me if this seems not the case in any of your internal testing.

@nammbash You are right about other failures are unrelated. The API one is indeed because of this PR.
I forgot about updating the API golden files. Sorry! Basically, when you add any new API pbtxt, you need to add an entry to the golden files too. I believe running the test with --update_golden modifies the necessary goldenfiles (e.g., tensorflow/tools/api/golden/v1/tensorflow.raw_ops.pbtxt, ensorflow/tools/api/golden/v2/tensorflow.raw_ops.pbtxt, etc) for you.
For example, see how the golden files are modified in https://github.com/tensorflow/tensorflow/commit/de87e628e6d89382783ea948c21fa66b182d69d3. (You shouldn't modify it yourself. Let the test modify them and add the changes to the PR.)

@penpornk modifications done and committed. Please review and merge.
@rthadur  FYI
Action:
build test separately and then run
bazel --output_base=../test_folder build tensorflow/tools/api/tests:api_compatibility_test
bazel-bin/tensorflow/tools/api/tests/api_compatibility_test  (Failed)

but

bazel-bin/tensorflow/tools/api/tests/api_compatibility_test --update_goldens True
Fails and updated the files

bazel --output_base=../test_folder build tensorflow/tools/api/tests:api_compatibility_test
bazel-bin/tensorflow/tools/api/tests/api_compatibility_test  (Success)

<EMAIL_ADDRESS>

@nammbash Hmm. This is weird. The golden files aren't related to your PR. (But the test passed without your PR.) I'll ask someone who actually knows more about them. Will get back to you soon.

@penpornk
:) Exactly my point from my comments yesterday: https://github.com/tensorflow/tensorflow/pull/25203#issuecomment-461262408.
thank you for the internal reviews!

@nammbash So @annarev told me we actually don't need to modify the golden files at all since the visibility is hidden. The mismatch on your part might be the estimator version mismatch. But then I'm not sure why our Kokoro test failed on your PR and not on the current repo. Could you please try syncing your local copy? (Also, please drop the last commit changing the golden files.) Sorry for the inconvenience!

@nammbash I'm looking at the test results from last night. The differences were actually the entries for your ops (RequantizationPerChannel and RequantizationRangePerChannel). That's why I thought they needed to be added to the golden files. Now there two questions: why did you see different results, and why did the test try to add your 'hidden' ops to the golden files.
E0207 07:22:46.303906<PHONE_NUMBER>10112 api_compatibility_test.py:216] TensorFlow API backwards compatibility test
This test ensures all changes to the public API of TensorFlow are intended.
If this test fails, it means a change has been made to the public API. Backwards
incompatible changes are not allowed. You can run the test as follows to update
test goldens and package them with your change.
    $ bazel build tensorflow/tools/api/tests:api_compatibility_test
    $ bazel-bin/tensorflow/tools/api/tests/api_compatibility_test \
          --update_goldens True
You will need an API approval to make changes to the public TensorFlow API. This
includes additions to the API.
E0207 07:22:46.304153<PHONE_NUMBER>10112 api_compatibility_test.py:217] 1 differences found between API and golden.
Issue 1	: None :
---
+++
@@ -2645,10 +2645,18 @@
     argspec: "args=[\'input\', \'input_min\', \'input_max\'], varargs=None, keywords=None, defaults=None"
   }
   member_method {
+    name: "RequantizationRangePerChannel"
+    argspec: "args=[\'input\', \'input_min\', \'input_max\', \'clip_value_max\'], varargs=None, keywords=None, defaults=None"
+  }
+  member_method {
     name: "Requantize"
     argspec: "args=[\'input\', \'input_min\', \'input_max\', \'requested_output_min\', \'requested_output_max\', \'out_type\'], varargs=None, keywords=None, defaults=None"
   }
   member_method {
+    name: "RequantizePerChannel"
+    argspec: "args=[\'input\', \'input_min\', \'input_max\', \'requested_output_min\', \'requested_output_max\', \'out_type\'], varargs=None, keywords=None, defaults=None"
+  }
+  member_method {
     name: "Reshape"
     argspec: "args=[\'tensor\', \'shape\'], varargs=None, keywords=None, defaults=None"
   }

@penpornk I was confused last afternoon on this question too. hence the question is there a build server/ specific run error.
Interestingly  bazel test passes but bazel build and then running test fails! Why?
bazel --output_base=../test_folder test tensorflow/tools/api/tests:api_compatibility_test passes.

@penpornk
Status Quo: https://github.com/tensorflow/tensorflow/pull/25203#issuecomment-461573084
Q1: why did you see different results
A1: No more after the merge with master from yesterday. I see the same error.
Q2: why did the test try to add your 'hidden' ops to the golden files
This is confusing. test fails and investigating. Not sure why hidden is doing this. Yet still the changes made by the golden file is for the estimators and not my op. but the test passes after these changes? Is the problem even related! Weird!

To add to @penpornk reply, there is this RFC for exporting all ops to the raw_ops namespace:
https://github.com/tensorflow/community/blob/master/rfcs/20181225-tf-raw-ops.md
This seems to include hidden ops as well. @alextp  would know more.
Also, to be more specific, --only_test_core_api=True needs to be passed in to api_compatibility_test when updating goldens. This flag is passed automatically when running test with "bazel test", but not when running it for golden update.

Anna, should we update the error message in the test to instruct people to
pass it when updating goldens?
On Thu, Feb 7, 2019 at 3:26 PM annarev<EMAIL_ADDRESS>wrote:

To add to @penpornk https://github.com/penpornk reply, there is this
RFC for exporting all ops to the raw_ops namespace:
https://github.com/tensorflow/community/blob/master/rfcs/20181225-tf-raw-ops.md
This seems to include hidden ops as well. @alextp
https://github.com/alextp would know more.
Also, to be more specific, --only_test_core_api=True needs to be passed in
to api_compatibility_test when updating goldens. This flag is passed
automatically when running test with "bazel test", but not when running it
for golden update.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/25203#issuecomment-461632527,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxcnOkmT6QfQhTfmMiMp6Wfpbytviks5vLLYwgaJpZM4aTxMo
.

--

Alex

And yes, the raw_ops namespace includes hidden ops. Feel free to bypass API
review for it, though.
On Thu, Feb 7, 2019 at 4:14 PM Alexandre Passos<EMAIL_ADDRESS>wrote:

Anna, should we update the error message in the test to instruct people to
pass it when updating goldens?
On Thu, Feb 7, 2019 at 3:26 PM annarev<EMAIL_ADDRESS>wrote:

To add to @penpornk https://github.com/penpornk reply, there is this
RFC for exporting all ops to the raw_ops namespace:
https://github.com/tensorflow/community/blob/master/rfcs/20181225-tf-raw-ops.md
This seems to include hidden ops as well. @alextp
https://github.com/alextp would know more.
Also, to be more specific, --only_test_core_api=True needs to be passed
in to api_compatibility_test when updating goldens. This flag is passed
automatically when running test with "bazel test", but not when running it
for golden update.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/25203#issuecomment-461632527,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxcnOkmT6QfQhTfmMiMp6Wfpbytviks5vLLYwgaJpZM4aTxMo
.

--

Alex

--

Alex

@alextp I think we could just change the default value, so that passing this flag is not required.

@penpornk and @annarev thank you for the comments.
Looks like that was a massive overhaul change with the new API and seems like I was the first to get caught trying the new method amidst @alextp changes! :)
What was done:

Added the 2 new ops in file tensorflow/tools/api/golden/v2/tensorflow.raw_ops.pbtxt
Looks like alphabetical order matters too. (So some automated method to add them / generate them would be beneficial in future)
Ran the test:
bazel --output_base=../test test --cache_test_results=no tensorflow/tools/api/tests:api_compatibility_test
Success.
Separate passes only with the flag as mentioned.
bazel --output_base=../test build --cache_test_results=no tensorflow/tools/api/tests:api_compatibility_test
bazel-bin/tensorflow/tools/api/tests/api_compatibility_test --only_test_core_api=True

@penpornk and @annarev and @alextp thank you all for the help!
Suggestions:
It is confusing to have two tests for api.(whcih shoudl i worry about?)
a. tensorflow/tools/api/tests:api_compatibility_test
and
b.tensorflow/core/api_def/api_test

Yes some error message on what needs to be done pointing at the api file would be helpful, including mention of alphabetical order(maybe)!

@nammbash the two tests are different and both important:
a. tensorflow/tools/api/tests:api_compatibility_test: compares TensorFlow Python public API to golden files. It is important for checking backwards compatibility and monitoring API changes.
b. tensorflow/core/api_def/api_test: checks consistency of api_def_OpName.pbtxt files specifically. For e.g. it checks that all registered ops should have api_def_OpName.pbtxt file. These .pbtxt files are used for all language APIs, so this is not specific to Python unlike api_compatibility_test.

We should definitely look at improving error messages. Ideally, golden files should be updated automatically when running api_compatibility_test with --update_goldens=True. But I can see that at times this approach could hit issues (for e.g. in this case, you needed to pass additional flag).

@rthadur I think the failures are all not related to my PR?

@penpornk  thank you!
FYI
tags = ["no_mac"],  # TODO(penporn): Re-enable the test on MacOS.

please re run the tests.

@rthadur Who pulls and merges this PR?

@rthadur can you please merge this PR?(making sure it is in before any new conflicts) thank you! :)

Sure. We are looking into this. As "rthadur" is off, i'll be taking this.

@nammbash Our internal test says the v1 golden file should be updated as well. Sorry that this wasn't reflected in our external tests. Did you see any changes to tensorflow/tools/api/golden/v1/tensorflow.raw_ops.pbtxt when you updated the golden files? If so, please include it. If not, we need to figure out why.

@penpornk I updated tensorflow/tools/api/golden/v1/tensorflow.raw_ops.pbtxt manually!
Didn't know there was a flag to do this?
--only_test_core_api=True --wil not modify anything.
are you expecting --update_goldens=True to do something?

@nammbash Are you able to generate the changes to tensorflow/tools/api/golden/v1/tensorflow.raw_ops.pbtxt? If not, here is the diff. I guess we can modify it directly this time. (Line number might be slightly different.)
@@ -2645,10 +2645,18 @@
     argspec: "args=[\'input\', \'input_min\', \'input_max\'], varargs=None, keywords=None, defaults=None"
   }
   member_method {
+    name: "RequantizationRangePerChannel"
+    argspec: "args=[\'input\', \'input_min\', \'input_max\', \'clip_value_max\'], varargs=None, keywords=None, defaults=None"
+  }
+  member_method {
     name: "Requantize"
     argspec: "args=[\'input\', \'input_min\', \'input_max\', \'requested_output_min\', \'requested_output_max\', \'out_type\'], varargs=None, keywords=None, defaults=None"
   }
   member_method {
+    name: "RequantizePerChannel"
+    argspec: "args=[\'input\', \'input_min\', \'input_max\', \'requested_output_min\', \'requested_output_max\', \'out_type\'], varargs=None, keywords=None, defaults=None"
+  }
+  member_method {
     name: "Reshape"
     argspec: "args=[\'tensor\', \'shape\'], varargs=None, keywords=None, defaults=None"
   }

@nammbash  Please sign the CLA in order to proceed with merging.

@hgadig He already signed the CLA. The bot detected his CLA and assigned CLA: yes since the beginning of the PR. Even the message right now says the bot found the CLA for @nammbash. What makes the bot assign CLA: no is because some of the commits are his accepting my online one-line suggestions (GitHub's new feature). For those commits, the author's emails that GitHub automatically used are<EMAIL_ADDRESS>and<EMAIL_ADDRESS>which is not recognized by the googlebot.
Googlebot wants us to verify that all the coauthors in this PR have signed the CLA. There are only two people contributing to this PR: @nammbash and I. So I think we are fine. :)

A quick note that I'm not setting CLA to yes yet until we are done with all the changes (since googlebot will keep setting it to no).

@penpornk Sorry was in a meeting and hence the delay! Thank you for the code suggestions again, appreciate it!
https://github.com/tensorflow/tensorflow/pull/25203#issuecomment-461952804 Here I meant to say v1 in the bottom comment file. Sorry about that confusion.(edited it)
Clearly there is difference between what google expect from these automation scripts and test flags and what I am experiencing locally. feels like I am beta testing the changes . :)
Anyways here is what I am experiencing from the latest master as available to external customers. Hoping it will identify the bug/process automation misses that can help google.

bazel test when I use the "test" option passes

bazel --output_base=../test2 test --cache_test_results=no //tensorflow/tools/api/tests:api_compatibility_test

Yet! bazel build + tests run separately have different behaviors

bazel --output_base=../test2 build --cache_test_results=no //tensorflow/tools/api/tests:api_compatibility_test

then
trial 1. Failure. No changes to any Files!
bazel-bin/tensorflow/tools/api/tests/api_compatibility_test
trial 2.  Success (as it skipped 3 tests IMO) No changes in files
bazel-bin/tensorflow/tools/api/tests/api_compatibility_test --only_test_core_api=True

trial 3.   Success (as it skipped 3 tests IMO) No changes in files
``
bazel-bin/tensorflow/tools/api/tests/api_compatibility_test --only_test_core_api=True --update_goldens=True
trial 4. Success (as it skipped 3 tests IMO) - But 4 file changes(3 new and 1 addition)

bazel-bin/tensorflow/tools/api/tests/api_compatibility_test --update_goldens=True
files changed are as below:
(modified 3)
modified:   tensorflow/tools/api/golden/v2/tensorflow.estimator.-mode-keys.pbtxt
modified:   tensorflow/tools/api/golden/v2/tensorflow.estimator.experimental.pbtxt
modified:   tensorflow/tools/api/golden/v2/tensorflow.estimator.pbtxt
(added 1)
tensorflow/tools/api/golden/v2/tensorflow.estimator.inputs.pbtxt
Note: If I build with these changes in trial 4 , Trial 1 will pass
**NOTE: None of this Modifies the tensorflow/tools/api/golden/v1/tensorflow.raw_ops.pbtxt or it similar v2 part.**

Yesterday I changed the v2 manually. ( tensorflow/tools/api/golden/v2/tensorflow.raw_ops.pbtxt )
Now I changed v1 manually ( tensorflow/tools/api/golden/v2/tensorflow.raw_ops.pbtxt)

Question: Do you want me to push all changes(modified files from Trial 4 above?)

@penpornk @annarev thank you! Let me know if anything else is required from me to push this PR!

@hgadig the 1 failure: Ubuntu Python3 PIP — Internal CI build failed  is not related to my changes in this PR. Let me know if anything else is required my side to merge this PR!

@nammbash Your had changes been pulled in. We are having troubles with internal tests again, but I don't think they are related to your PR. I'll let you know if we need more changes here. Sorry for the inconvenience!

It's finally merged! Thank everyone so much for the efforts, @nammbash, @rthadur, @annarev, @alextp, and @hgadig!


Create stories for "Review Filing"

One of the next features we will build is the ability for a filer to review a filing. As an initial step, we need to map out what stories are needed to deliver this functionality. The goal is to create stories for this feature so that they are "Prepared" for backlog refinement on 11/25.
At a high level, the stories need to offer the filer a way to:

Get to the "Review Filing" page
Review the relevant content of their filing
Know what actions they can perform on the review filing page (e.g., print, share, contact support, etc)

Potential user stories
Get to "Review Filing"

As a filer, I want to know how I can review my filing, so that ...

"Review Filing" Page
Content

As a filer, I want to see the details of my filing, so that I can ...

Actions

As a filer, I want to print/save my filing information, so that I can keep a copy on my computer/in my files.
As a filer, I want to share my filing information, so that I can share this information with colleagues.
As a filer, I want to be able to contact support, so that I can ask them questions about my filing.


fix: fixing a bug with fetch in Cloudflare Workers

fix #90

Hi @snilan. Thanks for creating this PR. I'm not sure I understand what problem this is solving or how this solves it. Could you please share more context?

Hi Matt, it was an issue with the this being overidden by the API, but I saw your PR documenting how to override fetch and that works perfectly so this PR can be closed. Thanks!


library name/electron-rebuild

Hi, thanks for sharing this. It helped me a lot. Just wanted to let you know of a few problems I had. One, this command didn't work:
./node_modules/.bin/electron-rebuild
because electron-rebuild is not actually part of the project. You must have had it installed globally? I had to add electron-rebuild to the project myself. The command is also a little different on Windows:
.\node_modules\.bin\electron-rebuild.cmd
Second, on line 69 of index.html the library name is wrong. It says "libfibonacci". It should just be "fibonacci".

Nice catch and I'm glad it was helpful to you. I probably won't fix it. This was more of an experiment to see how electron and native code work together.


Bump to Polkadot-sdk 1.6.0.

Refer to master ticket.
To perform the upgrade of Pendulum to Polkadot release 1.6.0 we need to update this repository to polkadot-sdk release v1.6.0.

Hey team! Please add your planning poker estimate with Zenhub @b-yap @ebma @gianfra-t @TorstenStueber


Enable source to support puppet file server

Hello,
Not all servers that I manage have access to internet so it would be useful for the module to get the keys from the puppet file server, such as follow:
    rpmkey { "442DF0F8":
        ensure => present,
        source => 'puppet:///modules/rpmkey/RPM-GPG-KEY-PGDG-94',
    }
}

As a workaround, I store the keys in a temporary folder on the client, and source it locally:
$puppet_tmp=/somewhere/to/store/tmp/files
class rpmkey_postgresql_94 {
    file { "RPM-GPG-KEY-PGDG-94":
        ensure => file,
        path => "$puppet_tmp/rpm-gpg/RPM-GPG-KEY-PGDG-94",
        source => 'puppet:///modules/rpmkey/RPM-GPG-KEY-PGDG-94',
    }

    rpmkey { "442DF0F8":
        ensure => present,
        source => "$puppet_tmp/rpm-gpg/RPM-GPG-KEY-PGDG-94",
    }
}

And thank you for work.
Thank you
Thomas

I tried to implement that today and did a few successful tests. The code can be found here: https://github.com/stschulte/puppet-rpmkey/tree/source_puppet_fileserver
It would be great if you could do some tests and let me know if it works like you expected. Basically it works like this now:

if source is an absolute path, use it directly for rpm --import
if source is a file:// resource, convert the source to a local path and use this for rpm --import
if source is a puppet:// URL and puppet runs locally (via puppet apply), get the local path to the file and use that path for rpm --import
if source is a puppet:// URL and puppet runs as an agent, query the content from the fileserver and write the content to a temporary file and use the path to the temporary file for rpm --import
if source is anything else (e.g. a http:// link) pass it directly to rpm --import and hope rpm can handle it directly.

I'm not sure if its the changes for #6 which created these errors but it seems that with a Puppet Client agent version 3.3.1 (we tested with this version) we got errors with the RPMkey provider that was unable to use the ruby function "Puppet::Network::HTTP::API::V1.indirection2uri(req)"
I am not entirely sure when it is added to Puppet but the module works well with our nodes running 3.7.5.

Hi Stefan,
I'm sorry for the delay, I finally got around to testing it, and it works great:
root@puppet-client ~# puppet agent --test
Warning: Local environment: "production" doesn't match server specified node environment "test", switching agent to "test".
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for puppet-client.example.net
Info: Applying configuration version '1442008291'
Notice: /Stage[main]/Rpmkey_test_gpg_key/Rpmkey[3CBXXXXX]/ensure: created
Notice: Finished catalog run in 2.33 seconds
root@puppet-client ~# puppet -V
3.8.1
root@puppet-client ~# cat /etc/redhat-release
CentOS release 6.7 (Final)
root@puppet-client ~# uname -a
Linux puppet-client.example.net 2.6.32-573.el6.x86_64 #1 SMP Thu Jul 23 15:44:03 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Thanks
Thomas

@stschulte
Thanks for your work on this module!
Is there any appetite to merge these "source" changes into master and eventually upload to puppet forge?

@OrangeCrush the problem here is that this is basically a rip-off the code I found for the file resource with two problems

I am not exactly sure which utility functions count as "stable" and which are counted as "internal". I suspect it is the latter and as such it is hard to write code that works on all puppet versions I want to support (2.7, 3.x, 4.x)
When I originally wrote the POC, I tried to find some spec tests I could adapt to be able to verify it works on all version. Unfortunately I did not find anything useable.

Since I want to ship a module that works on the versions I claim to support, and I consider the problem itself to be a minor one (you can resort to an additional file resource and place your keys on a server that is accessable via http) I do not plan to merge the code.
One possiblity though is to mark this feature explicitly as "experimental". But not breaking anyones code is really important for me.

@stschulte
I did end up implementing a solution using the file resource + http server approach.  Thanks again for the module!

Would you please put in a pull request so that this can be slipstreamed into the master branch?  Also, an update a PuppetForge would be great!  I use this functionality (source=>"puppet:///") and when I moved to a new puppet master the functionality was gone because it's not in MASTER.

Would you please slipstream the source_puppet_fileserver into the master and update the Puppet forge?


Make hyper::Error public and expose underlying Kind

Is your feature request related to a problem? Please describe.
It seems like a Rust anti-pattern to expose the underlying cause of an error by implementing many methods on hyper::Error. We also don't have a easy way to expose metadata related to each error. For example, with Kind::Listen we could potentially be more transparent about the underlying TCP listener error, instead of having a generic "operation failed" message. Also, things like:
type Cause = Box<dyn StdError + Send + Sync>;

are hard to understand and don't give the user a simple and matchable interface for understanding what went wrong.
Describe the solution you'd like
Somehow making Kind public so that it can be matched on and error handling can be simplified. This would probably require some refactoring of all those types (why does ErrorImpl need to exist?).
(I'd be happy to do this)
Describe alternatives you've considered
Leaving it the way it is: this leaves error handling difficult and not future-compatible.
Additional context
None given

This is more a user-facing refactor (does that exist?) than a feature or bug-fix. This seemed the most matching template.

While many do open up their error types as a giant enum, I'm of the opinion that that is a mistake. It prevents internal refactoring of how the error type is stored, and makes tight coupling of the library with its dependencies (and their versions). That is much less forwards-compatible.
We do hope to find a medium between a giant enum and the is_blah methods, tracked in #2845.


Cleanup travis and reduce the amount cached

The Minimum Rustc Version jobs were hanging due to taking too long to extract the cache. It appears that the overall cache size was over 14GB. This PR reduces the amount of files cached in order to attempt to relieve this issue, down to 1.2GB. Travis will now only cache the built binaries for dependencies we build ourselves, and only cache the sccache directory, instead of the target directory. These changes show significant speedups for the longer-running jobs (10% on average, but 50% on the Minimum Rustc job).

Coverage remained the same at 71.152% when pulling da8ba4d91d4f7fb283f392fddbe110e367ca1278 on shssoichiro:travis-round2 into 07ca598c2f91a83ade17050c2e3a5abc12635375 on xiph:master.


chore: Fix the mlmd grpc server in build workflow

Description of your changes:
Fix the MLMD gRPC server image in the github actions, build workflow.
Checklist:

[X] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

/lgtm
/approve


Update basic-writing-and-formatting-syntax.md.freeanjeel

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Hello

freeanjel


arch/risc-v: Add missing DMB to mtimer / setmtimecmp

The memory mapped mtimecmp lives in I/O space so must add barrier
to make sure the value sticks. Otherwise a new IRQ might fire
at once.
Summary
Impact
Testing

let's ignore CI error fixed by https://github.com/apache/incubator-nuttx/pull/6055


mypy gazpacho/get.py:35: error

Describe the bug
Error when running mypy gazpacho
Error
This is the error:
max@mbp gazpacho % mypy gazpacho
gazpacho/get.py:35: error: Argument 1 to "update" of "dict" has incompatible type "Optional[Dict[str, Any]]"; expected "Mapping[str, str]"
Found 1 error in 1 file (checked 4 source files)

Expected behavior
No errors 🙈
Environment:

OS: macOS
Version: 1.1.1-beta

Can I have a go at this?


More Robust Implementation of slice

Currently, only one of the two operations: ds.sel(lon = slice(X0, X1)) and ds.sel(lon = slice(X1, X0)) works; the other will give a data array (or dataset) with zero values. This can be a difficulty when working with different data sets which have different indexing methods.
It would be great to have slice implemented, at least in the context of sel, to check whether the index of ds is increasing or decreasing, and then take the min and max of X0 and X1 accordingly.

While it seems a good idea at first (I've fallen into this as well), I'm not sure this would be a good idea. Look at pandas for example:
In [1]: import pandas as pd

In [2]: ts = pd.Series([1, 2, 3, 4,])

In [3]: ts[1:3]
Out[3]:
1    2
2    3
dtype: int64

In [4]: ts[3:1]
Out[4]: Series([], dtype: int64)

I don't think one would like the last statement to return something else than an empty series.

Definitely a fair point, but would it be possible to add an argument to either slice or sel (probably slice) which defaults to False? For example, ds.sel(lon = slice(X0, X1, both_ways = True) would implement this behavior, but both_ways defaults to False.

I agree that this is somewhat surprising, but as @fmaussion points out this slicing behavior is consistent with pandas (and Python more generally, nothing that range(5)[3:1] is empty).
slice is a Python built-in, so we can't adjust it. What we could potentially do is add a new keyboard argument to .sel() (or add a new indexing method entirely).

Definitely want to leave it up to you guys but agree that putting it in slice probably doesn't make sense. Adding something to .sel() would be  a cool feature in the spirit of projects like Aospy, which try to minimize the amount code re-writing necessary for carrying out simple analysis on different datasets which are often organized in subtly different ways. Of course, it's pretty easy for users to implement this ourselves if we really need. Thanks for considering!

Closing in favour of #1613 which has more discussion.


[linux] flutter doctor: ✗ Unable to find bundled Java version. (WORKAROUND)

Steps to Reproduce

sudo snap install flutter --classic
Download android-studio-2<IP_ADDRESS>-linux.tar.gz
tar xzf ~/Downloads/android-studio-2<IP_ADDRESS>-linux.tar.gz
cd android-studio/
bin/studio.sh
More Actions -> SDK Manager
SDK Tools
Check box next to Android SDK Command-line Tools (Latest)
Press OK
Quit Android Studio
Make sure that JAVA_HOME refers to the jbr directory in ./android-studio
Make sure that java is resolved in ./android-studio/jbr/bin
flutter doctor

Cause
The Android Studio 2<IP_ADDRESS> package bundles the JRE in the jbr directory, flutter (stable) code path for LINUX looks for it in jre.
https://github.com/flutter/flutter/blob/7048ed95a5ad3e43d697e0c397464193991fc230/packages/flutter_tools/lib/src/android/android_studio.dart#L451
Workaround
Create a symlink from jbr to jre:
ln -s jbr/ jre

Hi @ameuret, this was initially reported in https://github.com/flutter/flutter/issues/106674 and has since been fixed on the master channel. See https://github.com/flutter/flutter/pull/120107
I'll be closing this since this has been fixed on the master channel.
If you do experience this issue on the master channel, kindly leave a comment below and I will reopen this.
Thank you


Uncommented code in Monitor that retrieved TServer active compactions

Code was commented out in the Monitor that called
TabletClientHandler.getActiveCompactions. This method was removed when major compactions were removed from the tserver, then restored in #3827 because we still need to report minor compaction stats to the monitor.

Do the charts and endpoints for the compactions numbers work now?

Do the charts and endpoints for the compactions numbers work now?

Not sure. The entire monitor is one big todo in the elasticity branch. We have not spent much (if any) time on keeping it working because we don't know how it will work if we have to go to multiple managers. Multiple managers may be required to scale out the tablet management operations that have been moved from the TabletServer to the Manager.
I see a couple of options for the Monitor if we have to go to multiple Managers:

Modify the Monitor to communicate with multiple managers
Remove all of the Monitor specific code and turn the Monitor into a metric sink
Remove the Monitor and tell users to use tools that do the job better - we could still provide a reference implementation in the form of some Grafana dashboards that users can import into their deployment. If they decide to use something else, then they can figure out it for themselves from our example.


Add unlisted events

Is this like a flag that makes it unlisted? Is it visible with a link? Or only visible if you're an admin? Both?


Free Code Camp 4th Test case is Not passing in Your Project || { error: 'invalid url' }

If you pass an invalid URL that doesn't follow the valid http://www.example.com format, the JSON response will contain { error: 'invalid url' }

Thanks for the issue reporting. Earlier all the test cases were passing.
Now I have modified the project according to my need and managed the invalid URL validation in the front-end part.

I took help of your project but still i could not understand why the 4th
test case ia not passing
On Tue, 3 Jan 2023, 21:48 Dhananjay Thomble, @.***>
wrote:

Thanks for the issue reporting. Earlier all the test cases were passing.
Now I have modified the project according to my need and managed the
invalid URL validation in the front-end part.
—
Reply to this email directly, view it on GitHub
https://github.com/DhananjayThomble/NodeJS-URL-Shortener-Microservice/issues/2#issuecomment-1369959605,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APMJG5K35A6FDIHEE4AD5L3WQRGLVANCNFSM6AAAAAATP232DA
.
You are receiving this because you authored the thread.Message ID:
<DhananjayThomble/NodeJS-URL-Shortener-Microservice/issues/2/1369959605@
github.com>

I took help of your project but still i could not understand why the 4th test case ia not passing
…
On Tue, 3 Jan 2023, 21:48 Dhananjay Thomble, @.***> wrote: Thanks for the issue reporting. Earlier all the test cases were passing. Now I have modified the project according to my need and managed the invalid URL validation in the front-end part. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/APMJG5K35A6FDIHEE4AD5L3WQRGLVANCNFSM6AAAAAATP232DA . You are receiving this because you authored the thread.Message ID: <DhananjayThomble/NodeJS-URL-Shortener-Microservice/issues/2/1369959605@ github.com>

This is no longer the freecodecamp project. I have changed almost all of the project structure. If you want help then you can refer to my earlier commit, It might be helpful to you.
https://github.com/DhananjayThomble/NodeJS-URL-Shortener-Microservice/commit/6a415375c923db2b3ef214bbf21a9ec4418a46da

Thanks for your support.
On Wed, 4 Jan 2023, 09:12 Dhananjay Thomble, @.***>
wrote:

I took help of your project but still i could not understand why the 4th
test case ia not passing
… <#m_780778161089891658_>
On Tue, 3 Jan 2023, 21:48 Dhananjay Thomble, @.***> wrote: Thanks for
the issue reporting. Earlier all the test cases were passing. Now I have
modified the project according to my need and managed the invalid URL
validation in the front-end part. — Reply to this email directly, view it
on GitHub <#2 (comment)
https://github.com/DhananjayThomble/NodeJS-URL-Shortener-Microservice/issues/2#issuecomment-1369959605>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APMJG5K35A6FDIHEE4AD5L3WQRGLVANCNFSM6AAAAAATP232DA
. You are receiving this because you authored the thread.Message ID: <
/issues/2
https://github.com/DhananjayThomble/NodeJS-URL-Shortener-Microservice/issues/2
/1369959605@ github.com>
This is no longer the freecodecamp project. I have changed almost all of
the project structure. If you want help then you can refer to my earlier
commit, It might be helpful to you.
6a41537
https://github.com/DhananjayThomble/NodeJS-URL-Shortener-Microservice/commit/6a415375c923db2b3ef214bbf21a9ec4418a46da
—
Reply to this email directly, view it on GitHub
https://github.com/DhananjayThomble/NodeJS-URL-Shortener-Microservice/issues/2#issuecomment-1370455058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APMJG5KHMB5BQLHJZ2GQVIDWQTWTXANCNFSM6AAAAAATP232DA
.
You are receiving this because you authored the thread.Message ID:
<DhananjayThomble/NodeJS-URL-Shortener-Microservice/issues/2/1370455058@
github.com>


chore: Adds seedfarmer --version

Issue #, if available:
Raised internally.
If a user wants to validate installation without running an explicit CLI command e.g. seedfarmer version:
seedfarmer.yaml is required in the path.
seedfarmer.errors.seedfarmer_errors.SeedFarmerException: The seedfarmer.yaml was not found at the root of your project. Please set it and rerun.

Description of changes:

Adds click CLI global option --version to allow package invoke entrypoint without running all validations.

Usage
> seedfarmer --version
seedfarmer, version 5.1.0.dev0

Additional Impact
This seems to also allow --help to execute without imports as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

One afterthought: maybe we should also change the seedfarmer version command to not require seedfarmer.yaml?

Yea that would be ideal, but a good amount more refactoring to do so, can discuss with @dgraeber


remove latest vespa.log if it is filling the disk too quickly

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@baldersheim please review
tested manually by running a system test and then turning on spam logging.  not sure if the limits here are reasonable (5 minutes to fill a log file, and filled to 110% of configured rotate limit).

@baldersheim PTAL


rotated text by CSS cannot be captured by html2canvas

I used css
.heading1 {
-moz-transform: rotate(270deg);
-webkit-transform: rotate(270deg) ;
-o-transform: rotate(270deg) ;
-ms-transform: rotate(270deg) ;
transform: rotate(270deg);
filter: progid:DXImageTransform.Microsoft.BasicImage(rotation=4);
}
to display a rotated headline for a chart. then i use html2cavas to 'screenshot' the page, this rotated text cannot be proper displayed.  It become a vertical text in which each letter is placed horizontally but aligned with each other vertically. and it looks ugly.

@MaitreyJukar wrap text content into a span does not work for me, sad

Does anyone find any solution for rotated divs screenshot?

workaround:
http://www.jjoe64.com/2015/10/html2canvas-and-css-transform-rotate.html

@jjoe64 https://github.com/niklasvh/html2canvas/issues/209#issuecomment-152904727

I'm displaying an infographic which contains images, charts and text. Since vertical text in the charts doesn't work, what I'm doing is using canvg to convert each of those charts (which are in c3 SVG) to a canvas, o even going one step further to convert said canvas to an image. This can be done recursively for any SVG group in the DOM.

How can i save div with CSS transform: perspective ?

How i can save div with CSS -webkit-mask-box-image: url(http://kz-c2.qiniudn.com/a.svg); ?

@zk7035 As each CSS property needs to be manually built to be supported, there are a number of properties that are not yet supported. (https://github.com/niklasvh/html2canvas#browser-compatibility)
Details: https://github.com/niklasvh/html2canvas/issues/246

Rotate worked form me but with a span I used one of the answers above. Here is what I did in my style I put a class
.vertical {
position: absolute;
left: -50px;
top: 0px;
width: 120px;
height: 20px;
font-size:12px;
color:#333;
transform: rotate(270deg);
}
the in my element a div position inline styled relative and whithin the div a span with class vertical.

Articulo No.

Hope it helps someone, saludos

i also face the problem of rotating the img


No Battery information for Xiaomi wirless cameras

No Battery information for Xiaomi wirless cameras
The data is available in xiaomi mi home app

Try master branch.

Try master branch.

Hi
Thanks for the reply.
I am new to this, can you please help me what master Branch means?


Split tox into code / lint checks

Its probably best to split code and linting tests. A linting check shouldn't necessarily fail a unit test.

:+1:


Gitlab OAuth SSO provider

Gitlab OAuth SSO provider (self hosted, not gitlab.com)
Hi,
It would be great if you could show me how to integrate my self hosted gitlab server's SSO OAuth provider into BookStack.
I'm not afraid of coding, and Will pull a copy down onto my dev box but I figured if you could point/show me where I need to modify or have this feature added I'd be very grateful.

Hi @MitchMaris, Sorry for my delayed response.
Adding new providers is fairly simply to do if you have some prior knowledge of the Laravel framework.
Laravel has a social login provider framework called 'Socialite' which makes adding new social provides quite quick. In fact, someone has already created a provider for GitLab.
The following page would be a good place to start:
http://socialiteproviders.github.io/providers/gitlab/
It has steps for installing into an application. There's going to be a few BookStack specific things as well but I'm happy to help if you take a crack at coding this.

sounds good. I'll setup a dev vm and pull the code. If it ends up working, maybe I'll make a push request. Thanks for the info!

Added in #691, Will be in the next release (v0.20).


Register 0.1.0

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/90358
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" c38df61a6e58fbea2883c6767cecff2ebe2b5985
git push origin v0.1.0


Comments

This passes the test in CTS. I haven't tested otherwise ...

This isn't totally correct. Consider
SHELL=echo
all:
	# hello

and
all:;echo $(#)

executed with env '#=1' bad --gmake gmake -f tests/b.mk.
Thank you for the interest in contributing :)


Refresh "/public/page-data"

Hi there,
I apologise if this a fairly newb question.  However I'm wondering how my site built on the platform will maintain correct stock info when it fluctuates (by variant).  I have tried pulling in variants and "availableForSale" data into the ProductCard graphql fragment as below:
export const query = graphql`
  fragment ProductCard on ShopifyProduct {
    id
    title
    slug: gatsbyPath(
      filePath: "/products/{ShopifyProduct.productType}/{ShopifyProduct.handle}"
    )
    images {
      id
      altText
      gatsbyImageData(aspectRatio: 1, width: 640)
    }
    priceRangeV2 {
      minVariantPrice {
        amount
        currencyCode
      }
    }
    vendor,
    variants {
      availableForSale
    }
  }
`

However this info doesn't seem to be updated when I then update the variants info on the Shopify site.  Do I need to deploy a cron job to continually refresh data within /public/page-data to make sure variants info is constantly up to date? i.e. this product is or isn't sold out.

I just realised that elsewhere in the code there's a client being used to pull live data.  I guess my task is to re-use this functionality somehow!

I managed to get the stock status by using the client object with the product listing component and looping through each product. Happy to share the code if anyone is interested.


Make all non-admin users in the p3 project into Barbican observers.

Promote Mark Boulton to p3 project admin (for appliance creation).

Thanks John


Cannot read properties of null (reading 'b')

ERR [uncaught exception in main]: Cannot read properties of null (reading 'b'): TypeError: Cannot read properties of null (reading 'b')
    at h (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:103:24182)
    at d.value (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:33:35781)
    at $.z (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:1913)
    at $.A (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:1983)
    at $.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:2199)
    at d.value (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:106:42564)
    at $.z (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:1913)
    at $.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:2130)
    at J.setReady (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:105:100714)
    at p.notifyReady (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:105:81450)
    at Object.call (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:42:5018)
    at I.s (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:40:5116)
    at I.q (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:40:4639)
    at d.value (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:40:4050)
    at $.z (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:1913)
    at $.A (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:1983)
    at $.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:2199)
    at d.value (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:33:35891)
    at $.z (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:1913)
    at $.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:2130)
    at d.value (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:33:36099)
    at $.z (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:1913)
    at $.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:35:2130)
    at me (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:33:38543)
    at IpcMainImpl.h (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:36:96476)
    at IpcMainImpl.emit (node:events:513:28)

Hi @bpasero, what are some verification steps for this issue?

Starting VS Code and not seeing this stack in the devtools console.


Failed to change user id to "root"

Original issue 203 created by william2003 on 2012-08-21T03:46:08.000Z:
What steps will reproduce the problem?

Install google-authenticator on Ubuntu host
Copy google-authenticator & pam_google_authenticator.so to ESXi 5.0 host
Generate token using google-authenticator which stores /.google-authenticator
Modify /etc/pam.d/system-auth

%PAM-1.0
auth       required     /lib/security/$ISA/pam_env.so
auth       required     /lib/security/$ISA/pam_access.so
auth       required     /lib/security/$ISA/pam_per_user.so  /etc/security/login.map
auth       required     /lib/security/$ISA/pam_google_authenticator.so secret=/.google-authenticator
account    required     /lib/security/$ISA/pam_per_user.so  /etc/security/login.map
session    required     /lib/security/$ISA/pam_per_user.so  /etc/security/login.map
password   include      passwd

Update /etc/ssh/sshd_config with ChallengeResponseAuthentication yes
Reload SSH /etc/init.d/SSH restart
Login

What is the expected output? What do you see instead?
Expecting system to accept password and prompt for code, but just keeps prompting for login
/var/log/syslog shows the following error message:
2012-08-21T03:40:00Z sshd(pam_google_authenticator)[1355443]: Failed to change user id to "root"
What version of the product are you using? On what operating system?
Latest version, trying this on VMware ESXi 5.0
Please provide any additional information below.

This issue was moved to google/google-authenticator-libpam#33


Send query to API search engine

Send query to backend (A.1 B.2).
We have a search handler at: https://github.com/QCDIS/NaaVRE/blob/notebook-search/jupyterlab_vre/handlers.py. Line: 196
We will need to extract it from the /handlers.py and create a  NotebookSearchHandler.py
Ideally, the PaaS will be handleing any "external" communications but for now, the extension will be sending the query to the "external" search engine.

Added env vars to get search API and tokens: https://github.com/QCDIS/NaaVRE/blob/cf578fe8b8c592cc4817fa8cc278242315c11740/jupyterlab_vre/notebook_search/handlers.py


Enhancements for the website design needed

The design for the website is in the initial phase of development. Do suggest changes if you have better ideas to further enhance the theme or the color palette. Check out the design here:
https://www.figma.com/file/zsYoyOajOsYONxlPdNLiSf/Women-in-Technology?node-id=2%3A1 (feel free to ask for edit access to the figma project if you are willing to work on the design)

I would like to work on this @umang-sinha @shikha-16.
Please do inform me if I have a deadline! Thank you.

I would like to work on this @umang-sinha @shikha-16.
Please do inform me if I have a deadline! Thank you.

Yes, website design is of the highest priority as of now. We would like it to be done by October 12, 9 PM IST.
Do join the discord server (given in the repo) for further discussion. You'll have to collaborate with @umang-sinha and possible other contributors in this task.
Thank you for choosing to contribute, and welcome to the community!

@bharati-21 please provide the email ID that is linked to your figma account so that I can provide you edit access for the design project. In case you don't have a figma account, I request you to make one.

Is there room for one more ? Interested in helping in any way with the website enhancements

Thank you @umang-sinha
My email ID<EMAIL_ADDRESS>

Also, please do provide any additional information I should know before starting the enhancement.
Thank you.

@bharati-21 I have provided you edit access to the figma project. You may begin working on the design.

@RafaelDavisH please provide the email ID linked with your figma account so I can provide you access to the figma project.

<EMAIL_ADDRESS>

@RafaelDavisH I have sent you an invite. Please accept it.

@bharati-21 please join the discord group. There is a meeting scheduled today at 3pm IST. The link is on discord. Please be there.

@shikha-16, yes. I will be there. Thank you!


Makeup secondary colors

Females have noticed the secondary makeup colors are not customizable in this menu. They say it appears the secondary color is defaulting to some shade of pink. Please consider adding secondary color to makeup options.

Hey @Senlar, could you attach some pics or videos replicating the error? Ty in advance!

Of course, here is what I was provided @franfdezmorales
https://medal.tv/games/gta-v/clips/k9vHb53VTxSgw/d1337u7NmDAE?invite=cr-MSxvamIsMjIxNjIwNzks
Pretty much the make up section doesn't have an option to change the secondary color, and for whatever reason it is defaulting to pink. I even friend changing my blush and lipstick color to see if maybe those would fix anything.

Fixed on #54, ty @YisusOnDev!