[question] always show torrent details tab (attribute)

Transmission version: 3.00 (Linuxserver Docker image)
Tr Web Control version: 1.6.1
Browser name & version：Firefox 80.0, Ubuntu 20.04.1
Problem description: How to always show the bottom area (called Attribute) with all the torrent details (Base)? Because it is hidden by default and when opened, it automatically hides when the cursor moves away. I don't want it to auto-hide and also want to keep it visible constantly. Is this possible?

click the right-top arrow to pin or unpin

Just click the pattern with the left mouse button.

That just drops it down again.. it's either automatically dropping (loss of focus) or if I click those arrows it drops again immediately.

Click it

I can make a video of my mouse cursor clicking on it if you need proof.
It's just poorly designed, not to offend the developers. But here is how it currently "works":
Situation: the section is hidden.
User: click on the blue bar.
Result: section is shown.
User: move cursor away.
Result: section automatically drops down.
User: Clicks on blue bar again.
Result: section is shown.
User: now carefully clicks on the arrow pointing down.
Result: section is hidden.
Situation: the section is hidden.
User: click exactly on the arrow.
Result: section is shown, does not automatically drop down.
Would you agree this is not intuitive at all? It's puzzling. You now have an arrow pointing up or down that CAN function as a pin, only when the section is hidden and the user clicks on the up arrow.
The pin should be visible on the blue bar (when the section is shown) and function as.. a pin.
Feel free to close if you disagree and will leave it as is. It could be a minor improvement that does make it easier for most people to understand.

The developer may consider that auto-hiding can free up more space and allow us to see more downloads.

My case is not against auto-hiding, that is fine and definitely useful!
My case is to change the well-hidden pinning feature :)
Hope the dev will read this as I have no other way to reach him.

when auto hide enabled:

show: click anywhere of the toolbar but not the switch button
hide: coursor move out of the attribute box

I agree. This is not intuitive at all. Please change the arrow icon to a pin icon.
Right now if the window is open, clicking the icon does not pin the window. Instead, it lowers the window. If the window is open, clicking the pin icon should keep it open when the mouse cursor is moved away. Clicking it again should make it so that when you move the mouse cursor away, the window drops down again as expected.

This is the native function of easyui, maybe we can consider replacing it with a new icon.


Allow hiding of the browser view on gene pages

At the SAB Kathy didn't want to see the inline browser view on the gene pages.
Maybe add a button to toggle JBrowse which would make it tidier while we work on adding the other options.
We should keep a link to the full browser.

I don't think we need to hide it. I don't think KAthy was so bothered about it being there, but something more informative for people interested in proteomes rather than genomes would be a nice alternative. So I don't think you need to do anything until we have a choice.

OK.  I thought I heard her say that she would rather not see it on the gene pages.

I think you are correct actualy, I think that is what she said. So a toggle would be good. Not urgent ..

I've added a show/hide button on the dev site for testing: http://dev.pombase.kmr.nz/gene/SPBC30D10.10c

Once that's done, how do you feel about making the JBrowse image wider?  I think the whitespace at the edges is unnecessary.  I think I was trying to make it look like the Ensembl PomBase.
So change this:

To this:

Although we eventually want it to look like:

The only issue I see with making the browser wider is that the structures are usually similar height to width aspect ratio so it would not work so well for structures once we change to the multi-view (especially when there are 4 options, pathway, protein viewer, sequence viewer, structure viewer).
I imagined that when we moved to the multi-viewer the image could be wider (to use up the real estate), but would also be deeper.
I also wondered if making the image deeper would also remove the need for the scroll bar ( it's more important to be able to see everything in the sequence window than to see  more surrounding context, or to have the image elongated widthways).

The only issue I see with making the browser wider is that the structures are usually similar height to width aspect ratio so it would not work so well for structures once we change to the multi-view

That's true, we'll have to change things again once we have the other widgets.

I also wondered if making the image deeper would also remove the need for the scroll bar

I think that would help.
But a wider image would help too because we can stretch out the image which will, on average, mean the two tracks need less vertical space.  So we can change this:

to this (using mcm4 as an extreme example):

Yes we can do this as a stop gap, as it will be a while before we have the other views.
Much better.

I've made JBrowse wider:

On the dev site, there's a hide/show button too:


Remove the emoji reaction when pressing on the added reaction

Details

Currently, when we press the added emoji reaction with a different skin tone, the reaction isn't removed. This PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/46387
PROPOSAL: https://github.com/Expensify/App/issues/46387#issuecomment-2254893749
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open any chat and send any message
Add an emoji reaction with a skin tone to the message from the context menu
Repeat step 2 but with a different skin tone
Verify the emoji is added alongside the previous emoji reaction
Now, change the skin tone again from the add reaction picker to a different one (different from step 2 and 3) but don't select any emoji
Press the added emoji reaction bubble
Verify the emoji reaction is removed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/6fd22373-375e-4138-aa37-7b3d1c09df56

Android: mWeb Chrome

https://github.com/user-attachments/assets/257816e5-9aaa-42a3-a8de-37fe61914b2b

iOS: Native

https://github.com/user-attachments/assets/9efe8104-2c7e-452a-9bf7-caee1f594a9e

iOS: mWeb Safari

https://github.com/user-attachments/assets/2d19ad1d-e7cc-401e-80bc-08b42081646f

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/9d07df49-5bab-4c3e-87cb-bc26de47bbe4

MacOS: Desktop

https://github.com/user-attachments/assets/2c8c8c43-b57c-41cc-8ec4-ca437559d644

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.26-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Anabaseios: The Twelfth Circle (Savage) (Phase 1) Aggro Distance

Instance/Zone Name: Anabaseios: The Twelfth Circle (Savage) (Phase 1)
Boss Name: Athena
BNpc ID: 12377
TerritoryType: 1154
Aggro Distance (to ring): 6y

Added.  Thanks again for the help!


Instruction mis-match

With my limited knowledge and experience with Elasticsearch for SIEM usage, I am looking forward to getting this set up to send the logs to Sentinel. Thank you for putting this together.  Going through the steps in:
https://github.com/noodlemctwoodle/pf-azure-sentinel/tree/main/Logstash-Configuration
There are some mismatches in the steps vs the actual file name for example Step 10:
Update firewall interfaces
Amend the 05-firewall.conf file
sudo nano /etc/logstash/conf.d/40-interfaces.conf
(there is no 40-interfaces.conf file recommended to download, it is now 20-interfaces.conf?)

I can understand that for sure.
We have a new Sentinel tenant up. I followed your tutorial, I can see logs arriving on my logstash host (sudo tcpdump -A -ni any port 5141 -vv), and logstash is enabled and started (systemctl status logstash.service returns the green active (running), output config 50 has been updated with my ID and Key, and the command was run to install the logstash connector (unknown how to test if this is installed / running properly.
I have waited quite some time, and running a query in Sentinel of just pfsense_logstash_CL  returns an error.  Going into the Advanced settings in the log analytics workspace does not show any sources, and the main page show nothing being ingested.
Any thoughts on how to troubleshoot why I am not getting logs in Sentinel?
Thank you.

Do you get any errors in
cat /var/log/logstash/logstash-plain.log

I do get errors in that log:
[2021-04-13T08:52:58,325][INFO ][logstash.runner          ] Log4j configuration path used is: /etc/logstash/log4j2.properties [2021-04-13T08:52:58,342][INFO ][logstash.runner          ] Starting Logstash {"logstash.version"=>"7.12.0", "jruby.version"=>"jruby <IP_ADDRESS> (2.5.7) 2020-08-03 9a89c94bcc OpenJDK 64-Bit Server VM 11.0.10+9 on 11.0.10+9 +indy +jit [linux-x86_64]"} [2021-04-13T08:52:59,955][INFO ][logstash.agent           ] Successfully started Logstash API endpoint {:port=>9600} [2021-04-13T08:53:00,275][ERROR][logstash.agent           ] Failed to execute action {:action=>LogStash::PipelineAction::Create/pipeline_id:main, :exception=>"LogStash::ConfigurationError", :message=>"Expected one of [ \\t\\r\\n], \"#\", \"input\", \"filter\", \"output\" at line 22, column 3 (byte 873) after ", :backtrace=>["/usr/share/logstash/logstash-core/lib/logstash/compiler.rb:32:in compile_imperative'", "org/logstash/execution/AbstractPipelineExt.java:184:in initialize'", "org/logstash/execution/JavaBasePipelineExt.java:69:in initialize'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:47:in initialize'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline_action/create.rb:52:in execute'", "/usr/share/logstash/logstash-core/lib/logstash/agent.rb:389:in block in converge_state'"]} [2021-04-13T08:53:00,410][INFO ][logstash.runner          ] Logstash shut down. [2021-04-13T08:53:00,425][FATAL][org.logstash.Logstash    ] Logstash stopped processing because of an error: (SystemExit) exit org.jruby.exceptions.SystemExit: (SystemExit) exit         at org.jruby.RubyKernel.exit(org/jruby/RubyKernel.java:747) ~[jruby-complete-<IP_ADDRESS>.jar:?]         at org.jruby.RubyKernel.exit(org/jruby/RubyKernel.java:710) ~[jruby-complete-<IP_ADDRESS>.jar:?]         at usr.share.logstash.lib.bootstrap.environment.<main>(/usr/share/logstash/lib/bootstrap/environment.rb:89) ~[?:?]

Ah you have a configuration error in one of the config files and Logstash is erroring out. That's why no logs are being sent to Sentinel.
I am away from my computer at the moment and viewing your log file on a mobile device is less than ideal. I'll jump on my PC this evening and take a look as well as update my documentation.
Apologies for the delay 😬

Fixed the documentation and added an additional step.

[2021-04-13T08:52:58,325][INFO ][logstash.runner ] Log4j configuration path used is: /etc/logstash/log4j2.properties
[2021-04-13T08:52:58,342][INFO ][logstash.runner ] Starting Logstash {"logstash.version"=>"7.12.0", "jruby.version"=>"jruby <IP_ADDRESS> (2.5.7) 2020-08-03 9a89c94bcc OpenJDK 64-Bit Server VM 11.0.10+9 on 11.0.10+9 +indy +jit [linux-x86_64]"}
[2021-04-13T08:52:59,955][INFO ][logstash.agent ] Successfully started Logstash API endpoint {:port=>9600}
[2021-04-13T08:53:00,275][ERROR][logstash.agent ] Failed to execute action {:action=>LogStash::PipelineAction::Create/pipeline_id:main, :exception=>"LogStash::ConfigurationError", :message=>"Expected one of [ \\t\\r\\n], \"#\", \"input\", \"filter\", \"output\" at line 22, column 3 (byte 873) after ", :backtrace=>["/usr/share/logstash/logstash-core/lib/logstash/compiler.rb:32:in compile_imperative'", "org/logstash/execution/AbstractPipelineExt.java:184:in initialize'", "org/logstash/execution/JavaBasePipelineExt.java:69:in initialize'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:47:in initialize'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline_action/create.rb:52:in execute'", "/usr/share/logstash/logstash-core/lib/logstash/agent.rb:389:in block in converge_state'"]}
[2021-04-13T08:53:00,410][INFO ][logstash.runner ] Logstash shut down.
[2021-04-13T08:53:00,425][FATAL][org.logstash.Logstash ] Logstash stopped processing because of an error: (SystemExit) exit org.jruby.exceptions.SystemExit: (SystemExit) exit at org.jruby.RubyKernel.exit(org/jruby/RubyKernel.java:747) ~[jruby-complete-<IP_ADDRESS>.jar:?] at org.jruby.RubyKernel.exit(org/jruby/RubyKernel.java:710) ~[jruby-complete-<IP_ADDRESS>.jar:?] at usr.share.logstash.lib.bootstrap.environment.<main>(/usr/share/logstash/lib/bootstrap/environment.rb:89) ~[?:?]

@brohan  I've reposted your formatted error log above, you have a configuration error which is causing Logstash to stop processing.
Are you able to share the configs for the following files

01-inputs.conf
20-interfaces.conf

If you don't want to post them publically, please feel free to mail them to me here<EMAIL_ADDRESS>I will be removing this email from this post after 24hrs for security reasons.
Many thanks.

Sent, thank you!

Perfect, I'll take a look shortly, I'll see if I can load them on my server.

Thank you again. Note that I am using port 5141 per the tutorial, which is the 2nd section on the inputs file, and that is what I tested with tcpdump command (per tutorial) if that make a difference.

Could be another typo problem 🤫
Please can you change to 5140, I'll change that in the docs.

Added additional steps to guide
Fixed ports mismatch in the docs 5140 | 5141
Correctly tagged all code blocks in guide
Added additional context around naming custom_table_name for Microsoft plugin and restrictions


UX: Design for dev command

Design the interface for the demo dev command.

[x] KitOps branded
[ ] Add info flyouts
[x] 768px min. screen size (Desktop only)
[x] What happens on even smaller screen sizes?
[x] Error messages
[ ] Content for (i) buttons
[x] 404

missing UI elements:

[x] Radio buttons
[x] Slider component

UI Elements
Radio buttons
Slider

Layouts

404 --> https://tailwindui.com/components/marketing/feedback/404-pages

We will not change the way error messages are displayed (as a pop-up) for now.

This tool is a desktop view only. Any view on a screen smaller than 768PX will be scaled down to fit the screen.


[FIX] SmartTemplateAnalyzer: Do not throw in case missing dependency is expected

In some cases it can be expected that SmartTemplateAnalyzer does not
have access to second-degree dependencies. In such cases, no error
should be thrown. Currently this causes misleading error logs, for
example in case of component preload generation for a Fiori Elements
project where no framework dependencies are available.
Resolves https://github.com/SAP/ui5-builder/issues/404

Coverage increased (+0.08%) to 91.424% when pulling b82187fcef14639eff8aed3d2192fc3bb203b86c on component-preload-ignore-missing-deps into d18a29ff242bb9bb688c801375d3b42cb13d14b0 on master.


fix: renamed report_id to thread_id in report a thread test

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #48425

I renamed a variable in the test code for the following test for the Anonymous Message Board project that is a part of the Information Security curriculum from report_id to thread_id so that the request made by the test contains the proper field name that is stated in the test description:

You can send a PUT request to /api/threads/{board} and pass along the thread_id. Returned will be the string reported. The reported value of the thread_id will be changed to true.

This change was made for the anonymous-message-board.md file contained in the information-security-projects directory for the english language directory in the curriculum/challenges directory.

Thanks for the PR; we are temporarily blocking this until someone has confirmed and moved the original issue out of triage.
In simple terms, we would need to wait for at least a couple more people to be involved in the conversation. This is standard practice.
You do not have to do anything just yet; we request your patience. Meanwhile, please feel free to work on something else if interested.
Happy coding.

@raisedadead thank you for letting me know! happy coding to you as well.

@StevanFreeborn You do not need to update the branch unless you are asked, or there is a merge conflict.

@raisedadead Oh my apologies! thank you for correcting me.

:sparkles: :sparkles: AWESOME! :sparkles: :sparkles:
LGTM.
Thanks for this pull request and for contributing to the codebase for the first time. We will be looking forward to more contributions in the future.
Happy contributing.


Delete nova service for a host after scaledown

https://bugzilla.redhat.com/show_bug.cgi?id=1339140

@miq-bot add_label darga/yes

I didn't run it, but looks good to me.

@tzumainn Please follow guidelines for adding BZ links in commit messages as described here
I have already changed the description of this PR to have a link to the BZ.

Ah, my mistake - thanks!

@tzumainn please add some tests.  Specifically, I'd like to make sure that the assumption that "scaledown" is the only update_stack operation that allows calling the post_scaledown_task.

@blomquisg Thanks for the feedback!  I've updated the PR; let me know if I didn't quite address your comments.


[Feature Request] Secure Sockets Transport Implementation

It would be useful to offer a secure Secure Sockets Transport Implementation. Quetel, UBlox and Sierra Wireless support TLS sockets, thereby allowing the use of certificates stored within the modem and reducing the MCU resources needed.

Hi adpjhu,
Thank you for your interest in FreeRTOS-Cellular-Interface.
To offload TLS to cellular modem, new APIs will be required.
We will discuss this feature. Once we have some update, I will reply to this issue.

@awsblake Would you have any idea when this feature will be ready?

Currently, we don't have enough resource to propose and implement this feature in the short time.
We add a help wanted label to this issue. Contribute from community can be great help to this project.

Hey!
At Stratio we're trying to use CellularInterface and offload TLS configuration to the modem (BG96).
Now... A few things we've noticed:

There's no way to tell the implementation wether to open a secure socket or a regular one.
There's no way to issue AT commands that require sending data to the modem (e.g. File upload AT+QFUPL)

Our proposal would be along the lines of:

Alter Cellular_SocketSetSockOpt to add support for a new SSL option whose value is the SSL context ID. This way the implementation would be notified of the need for a new SSL socket.

Add a new function to the CellularInterface API called Cellular_UploadFile(const uint8_t *pFilename, const uint8_t *pContent, const uint32_t size). This function would then be implemented by the community ports, probably using _Cellular_AtcmdDataSend.

WDYT? RFC

Hi diogosilva0307,

Alter Cellular_SocketSetSockOpt to add support for a new SSL option whose value is the SSL context ID. This way the implementation would be notified of the need for a new SSL socket.

New socket protocol type and socket opt can be added if it can help user to create their own secure socket API in the port. Please feedback your suggestion or raise a PR.

Add a new function to the CellularInterface API called Cellular_UploadFile(const uint8_t *pFilename, const uint8_t *pContent, const uint32_t size). This function would then be implemented by the community ports, probably using _Cellular_AtcmdDataSend.

AT+QFUPL is similar with socket send command and it is possible to use common layer API _Cellular_AtcmdDataSend to implement the Cellular_UploadFile function.
Thank you for your interest in cellular project. If you have problem implementing APIs, please feedback your question. We will discuss with you here.


Add a spigot version of the plugin.

I don't want to host bungeecord/velocity servers just to use raknetify.
I would want to have a spigot version of this plugin so I can just use it without using the mentioned software above.

really anoying


New callback for async generation

Added new callback option that will be called at each thumb generated. This allow users to have large videos and large number of thumbs without breaking the UI.

Closing the Pull request as it requires many changes and the commits are already merged from PR #7


New-Team : Error occurred while executing Code: Request_ResourceNotFound

I created an App Registration in Azure AD which uses certificate-based auth so I can run a Teams script as a scheduled task. I've given the app the highest permissions to read directory data, create group and teams. I can Get-Team and Set-Team, but when I run New-Team I get the following error:
PS C:> New-Team
cmdlet New-Team at command pipeline position 1
Supply values for the following parameters:
DisplayName: TestTeam
New-Team : Error occurred while executing
Code: Request_ResourceNotFound
Message: Resource '569ab4b2-80c3-4476-9d2e-34aa4d4d5f5e' does not exist or one of its queried reference-property objects are not present.
InnerError:
RequestId: 1f55a916-d0b3-4758-99c5-27946372fde0
DateTimeStamp: 2021-02-06T02:06:57
HttpStatusCode: Request_ResourceNotFound
At line:1 char:1
. + New-Team
. + ~~~~~~~~
. + CategoryInfo          : NotSpecified: (:) [New-Team], ApiException
. + FullyQualifiedErrorId : Microsoft.TeamsCmdlets.PowerShell.Custom.ErrorHandling.ApiException,Microsoft.TeamsCmdlets.PowerShell.Custom.NewTeam
PS C:>
This works fine if I use Connect-MicrosoftTeams, but I need the script to run as a Scheduled Task.

I discovered that you must assign the owner at the time the Team is created when using certificate-based authentication. This is not a requirement when using interactive login to Connect-MicrosoftTeams.
Please add this to the documentation and/or update the error message.

Hello @expta Jeff, how are you?
I could reproduce, I am adding a note to the documentation.
Thanks for reporting.


Correct error in function name for get_html_summary()

Fixes error where README.md incorrectly referred to html_summary() rather than get_html_summary() as the method for creating an HTML interrogation report.

@ekothe this is great, thanks for submitting this PR! The scope of the PR seems to include some work-in-progress stuff for the col_vals_in_set() function. I’m not sure if that was intended but it’s fine to keep adding commits to fix that.
Also, could you make the README change to the .Rmd version and then knit? (The .md version is the processed output of the pair.)
Thanks again!

Whoops! Sorry, didn't realise I was doing my WIP on col_vals_in_set() on the same branch. I'll roll back those changes (since they are not working anyway) and make changes to the .RMD

@rich-iannone the most recent commit should resolve the documentation issue without including the WIP for col_values_in_set.

@ekothe This is great, really appreciate!


to bring p. 1.12 (Inheritance) and p. 1.13 (Method Overloading) of this article in accordance with the latest EO version

We need to make sure that all code snippets in p. 1.12 (Inheritance) and p. 1.13 (Method Overloading) run successfully. And the description does not contradict the description in other articles: https://arxiv.org/pdf/2206.02585.pdf and https://arxiv.org/pdf/2111.13384.pdf

@includealex please, help us here

@includealex this is urgent, would be great if you put it to the highest priority

test:
[] > check
  [] > item
    memory 0 > p
    [] > price
      p > @
  [] > book
    item > i
    [] > tax
      (QQ.math.number (i.price)).as-float.times 0.1 > @
  assert-that > @
    book.tax
    $.equal-to TRUE

test:
[] > check
  [p] > item
    memory 0 > price
    [] > new
      price.write p > @
  [] > book
    [p] > new
      item p > @
      [] > tax
        times. > @
          as-float.
            QQ.math.number (^.price)
          0.1
  assert-that > @
    QQ.io.stdout
      QQ.txt.sprintf
        "%f"
        tax.
          book.new 42
    $.equal-to TRUE

test:
[] > check
  [] > dog
    [] > bark
      QQ.io.stdout "Bark!" > @
  [] > friend
    [] > listen
  [] > jack
    dog > d
    friend > f
    [] > listen
      seq > @
        d.bark
        QQ.io.stdout "listen!"
  assert-that > @
    jack.listen
    $.equal-to TRUE


The editor is slightly less responsive when set to "update only changes"

Godot 3.0 master, also 2.1.3
Windows 10 64 bits
I don't know wether this is fixable or not, but on Windows I always noticed a slightly better response time / better framerate when "update always" was checked on top-right. To the point I always checked it when taking videos. Now I see the option is going to be deprecated and default to "update changes", which finally convinced me to open this issue for the record.
I noticed this in many situations, for example scrolling the script editor, and took a video of it to show the difference: https://github.com/godotengine/godot/issues/10489#issuecomment-325166871
@toger5 didn't experience this on Mac, so it might be OS-specific.
I just tried to record a video of it in the 3D viewport but I was unable to reproduce the difference with OBS on a laptop which slows down FPS just enough, which is frustrating...
I retried with tweaked settings: http://zylannprods.fr/dl/godot/subtle_framerate_difference.mp4
(but the most measurable example is the script editor).
It feels like the editor reacts and redraws at 40..50 fps / drops frames, instead of 60 when I set "update changes", which is subtle, but noticeable.

Yeah, I've noticed this too. Setting the editor to "Update Changes" causes the framerate in the 3D viewport to drop from a solid 60fps to what feels like 30fps. I don't think it's subtle at all, this is definitely something that should be ironed out.
Tested on master 5f0d367, Linux Mint 18.2 Cinnamon x64, running on an NVIDIA Geforce 980 Ti with NVIDIA's drivers (version 375.66)

I can reproduce this as well (on Intel and NVIDIA graphics).

@toger5 my hardware is a "gaming" laptop with an very average graphics card^^ (nVidia 940M)

The same for me. Using a ThinkPad X230, i7-3520M, Intel HD 4000, Ubuntu 16.04.3 LTS, so it might not depend on the Hardware

I tested the fix:
It feels better, however still not as good as "update always". Things still have a bit of difficulty to "kick in" (for example scrolling the script editor) while it reacts faster and smoothly with "update always".

This is likely a bug in the text editor scrolling that should be fixed
On Fri, Nov 17, 2017 at 10:21 PM, Marc<EMAIL_ADDRESS>wrote:

I tested the fix:
It feels better, however still not as good as "update always". Things
still have a bit of difficulty to "kick in" (for example scrolling the
script editor) while it reacts faster and smoothly with "update always".
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/11030#issuecomment-345406874,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z26CfGwQ0wKv2BxbS9bJlJ38nShyfks5s3jEqgaJpZM4PPH7k
.

No, it is not. It's everywhere, I recorded two videos to show it :(

What about attempting something like https://github.com/godotengine/godot/commit/ca194033061b4b29fe00d8e9bddf2f0478b3c3f0 again, but with an higher sleep time like 8000 (125 FPS)?

@Calinou I tested with 8000 and it doesn't solve it. In fact, I wonder why this sleep time would be the problem, to me I would intuitively look for here https://github.com/godotengine/godot/blob/master/main/main.cpp#L1716

I've profiled this section to see how long it takes:
From https://github.com/godotengine/godot/blob/master/main/main.cpp#L1711
To https://github.com/godotengine/godot/blob/master/main/main.cpp#L1727
I waited. Then I started dragging stuff, without stopping. Then I stopped dragging and immediately paused the process to look at my prints. Here is the result:

Tested on another computer (powerful desktop one, GeForce GTX 750 Ti/PCIe/SSE2), and I can still feel the difference between two modes, and the kick-in lag is present too.
However... I noticed that if OBS is open and running on the same graphics card, this kick-in doesn't happen (luckily, when I recorded videos I linked above on my laptop, OBS apparently launched using the other less powerful card, which allowed me to record the lag. I tried launching OBS on the powerful graphics card and it wasn't able to record the lag because that lag doesn't exist if OBS is launched... d'oh!)

Now that I tested this on Windows and Linux, I can say that I'm fine with the current editor responsiveness; it's much better than it was a few months ago. 😃

@Calinou it still responds awfully on my laptop, and it worsens if the scene is busy or has a GIProbe

Update:
Using the nvidia-smi tool, I checked the Performance state of the graphics card while doing my repro steps, and I noticed it is stuck in state P8 when the editor is set to "Update changes".
If I start to move stuff around, it automatically goes to P0.
This performance state is associated with lower memory and GPU clock speed, which may cause lag.
I made a video to illustrate this but Internet is very slow so I will upload it later.

Good news:
One option of the nVidia control panel seems to fix the issue!
In french it says "Mode de gestion de l'alimentation" (english might be "power management" or something like that), and you have to set it to "Maximal performances".
There should be a way to set this per-program too, so you don't have to bump up your GPU globally by default.

I checked on a powerful desktop computer and the same situation happens, everything runs in P8 until something moves.
Maybe it is worth noting that, Unity3D also runs in P8 but is not having this issue at all, though...

I wanted to edit the first post but the Edit menu broke even if I restart Firefox, so:
I wrote a TL;DR to explain what is the root problem, and it looks like even Blender has been aware since 2016: https://developer.blender.org/T49758

Is this also the case for vulkan? if not we could wait until Vulcan is the default. (Donno how different the driver is when using gles3 vs vulkan)

@toger5 there is only one way to find out... :D

Some ideas on this, which may or may not be relevant (I have very little knowledge on how Godot currently does this, especially in terms of threads for editor and 3d / 2d window):
Using sleep in the main thread to limit FPS in the editor seems like it could be problematic. If the editor is running at e.g. 10fps, then (depending on how it works with the OS) you could be artificially putting a variable lag on your input, AND potentially limiting the continuous response time as you e.g. move around a mouse on a scrollbar. I don't know whether input overrides a sleep, I suspect not.
An alternative (at least for running the IDE in low processor mode at low frame rates) is to use OS timers. These are often very unreliable in terms of accuracy, however they have the advantage that they won't introduce any lag to input, so you can have low processor, but the moment you decide to e.g. rotate the 3d view, you get instant reponse again, best of both worlds.
Another idea is to set a 'last input time' every time you get input (keyboard mouse), and prevent doing any sleeping until there hasn't been any input for say, half a second. This would at least potentially make things like scrolling more responsive.
The other trick with heavy 3d / 2d scenes is to render them to a texture that is cached, and when changing UI items you don't always do a full render of the 3d / 2d window, so that UI responsiveness isn't linked to how heavy the scene is. (You can also do this vice versa.)

I have the same problem I think (win10, 144Hz display, GTX 2070 Super).
While focused the editor (and the open project window) both have a mouse framerate lag, as if switching to a lower framerate monitor. If I unfocus the editor (click on another window) the mouse visuals return to normal.
For me enabling "update continuously" made the editor put GPU in 80-90% load while unfocused, but while focused started working as normal with no mouse visuals problems and at lowload (5-15% load). Enabling "V-sync" in project settings as well as "update continuously" in the editor settings, makes it stutter free while focused and low load while onfocused. This does not include the open project window that still suffers the problem (probably since the settings are not loaded yet?).
This has solved it for me, but again I have a powerful computer enough for the continous updates, so it doesn't feel like this is how it should be. Also it feels as if the editor should be more limited when unfocused as opposed to focused.
I talked to @Calinou in discord and tried the build in #36052 but the results were identical (not working), except V-sync wasn't working yet.

This does not include the open project window that still suffers the problem (probably since the settings are not loaded yet?).

Projects don't use the low processor mode by default unless you enable it in the Project Settings.

What's the state of this in 4.0 with Vulkan? It seems latest master just continuously updates even when set not to but wasn't sure if that's intended or if I did something wrong.
Also, is @Calinou PR still going in for 3.2 and did it end up helping?

What's the state of this in 4.0 with Vulkan? It seems latest master just continuously updates even when set not to but wasn't sure if that's intended or if I did something wrong.

This is definitely not intended; low-processor mode hasn't been reimplemented yet in the master branch.

Also, is @Calinou PR still going in for 3.2 and did it end up helping?

It hasn't been merged yet, but it's still cherry-pickable into the 3.2 branch. (It's probably too late to merge it into 3.2.2 though.)

I'm interested in this issue for my own app which is using low processor mode not specifically the editor. What I don't quite understand is why is it that setting the low cpu more usec to 0 then yields high framerate when I have vsync enabled. Basically what I'm trying to achieve isn't so much the CPU reduction from the sleep but primarily the reduction to be gained from the RenderingServer check which only renders when there are changes. Is it possible to achieve that? Or is the issue precisely because we're not rendering then vsync isn't being applied? It seems if that's the case potentially having a way to still use the renderingserver to apply backpressure rather than the artificial sleep would make things fairly seamless but I am way out of my depth here.

Basically what I'm trying to achieve isn't so much the CPU reduction from the sleep but primarily the reduction to be gained from the RenderingServer check which only renders when there are changes. Is it possible to achieve that?

Yes, that can be done by setting the sleep duration to a very low time like you did.

Or is the issue precisely because we're not rendering then vsync isn't being applied?

V-Sync should still be applied when you enable low-processor mode. Godot enables V-Sync by default, and many graphics drivers enforce it (with no way for applications to disable it). This is often the case on mobile/web platforms.

setting the low cpu more usec to 0

Doesn't this mean Godot will then never sleep and consume max CPU instead?

That is indeed what I'm seeing. If v-sync was still applied then I wouldn't see my app running at 144fps when using the same settings as the editor (or even hitting as high as 500fps when going w/ a very low sleep) but instead I should see only 60fps since that's what my monitor supports. If vsync should still be the upper bound (meaning if sleep is 0 I should only see 60fps) then something is wrong there.
When I don't use low cpu mode then I do see the app running at 60fps so vsync does seem to work fine.
BTW I don't know how bad the responsiveness is for you @Zylann when using low cpu mode vs continous update. I can't say it's absolutely horrible but I'd describe it as going from something that feels like 60fps down to something that feels like 20ish fps. I'm going to test out @Calinou change maybe tonight and report whether I notice an improvement.

BTW I don't know how bad the responsiveness is for you @Zylann when using low cpu mode vs continous update. I can't say it's absolutely horrible but I'd describe it as going from something that feels like 60fps down to something that feels like 20ish fps.

This is pretty much what my PR should fix. It replaces the low processor mode's fixed delay for a delay that varies depending on the time spent in the last frame (like Force Fps in the Project Settings).

@Calinou It's night and day difference for me! My use case is a tree with a lot of visible nodes. The latest 3.2.2 beta during scrolling gets ~30fps on a high end desktop whereas your change never drops below 70fps. It's seems my frame is not ast enough to maintain 144fps but that's ok, at least your change has the dynamic component which still then does its best to maintain as high FPS as it can whereas current behavior just adds the fixed delay and makes things even worse.
No way we can get this merged for 3.2.2? Seems like a fairly straight forward change that primarily affects the editor.

@giulianob I don't know if Akien plans to release a fifth beta for 3.2.2, so it may be too late.


docs: add provider to the documentation

This PR

adds a section on the install page that lists the available providers
includes the readmes of the available providers

How to test

Install: https://deploy-preview-1027--polite-licorice-3db33c.netlify.app/installation/#flagd-providers-for-openfeature
Go: https://deploy-preview-1027--polite-licorice-3db33c.netlify.app/providers/go/
Java: https://deploy-preview-1027--polite-licorice-3db33c.netlify.app/providers/java/
Node.JS: https://deploy-preview-1027--polite-licorice-3db33c.netlify.app/providers/nodejs/
PHP: https://deploy-preview-1027--polite-licorice-3db33c.netlify.app/providers/php/
.NET: https://deploy-preview-1027--polite-licorice-3db33c.netlify.app/providers/dotnet/
Web: https://deploy-preview-1027--polite-licorice-3db33c.netlify.app/providers/web/

Web isn't working correctly. Looking into it.


Remove cutflow

It's still used heavily in protopipe, so we should keep it a while longer (but perhaps mark it as deprecated)

It's still used heavily in protopipe, so we should keep it a while longer (but perhaps mark it as deprecated). In a not too distant future version of protopipe, however, that code will be totally replaced by ctapipe-process, so after protopipe supports that we can remove CutFlow

Yes it is still used.
I see anyway the deprecation notice, so I don't think we should add anything more.
If it is not a problem to keep it (it is not incompatible with current data, isn't it?) we could make this a draft PR, remove the milestone, and as soon as protopipe is using ctapipe-process we can reopen it and merge.

@kosack You approved this now, but the situation hasn't really changed, has it?
What is the status of protopipe concerning cutflow? If we remove this here, this means either
a) protopipe has to replace cutflow with QualityQuery when upgrading to 0.16
b) protopipe needs to include cutflow back itself
c) protopipe cannot upgrade to 0.16


how to use the new parameter "access-log-status-filters" in influxdb.conf of influxdb 1.7.1

Proposal:
Current behavior:
with parameter access-log-status-filters like this:
access-log-status-filters = ["4xx", "5xx"]
then restart influxdb can't work, and logs are:
run: parse config: Near line 250 (last key parsed 'http.access-log-status-filters'): expected a comma or array terminator ']', but got 'x' instead
or
run: apply env config: status filter must be a digit that starts with 1-5 optionally followed by X characters
So, how to use access-log-status-filters correctly.
Requests may be closed if we're not actively planning to work on them.

I have been able to reproduce this issue.  We are investigating the cause.


Moving locking logic into storage base class.

Coverage decreased (-0.0009%) to 94.45%

ಠ_ಠ

This LGTM. Coverage drop doesn't seem to be an issue looking at the coveralls report.

FWIW, comparing (a + line_change) / (b + line_change) to a / b will no longer be an issue once a = b (i.e. 100% coverage, go #212!)

Cool. @nathanielmanistaatgoogle care to take a look?


feat: sentry integration

Resolves: https://github.com/truflation/truflation/issues/58

log: we need to put the Sentry on api-adapter repo, not the data framework.


Cleaned up menu, categories, and removed submit.html

Cleaned up menu, categories, and removed submit.html


[ddc] Add an API for the debugger to easily identify native JS objects and errors

The debugger (dwds) needs to

find if the type of the variable is not related to dart so the variable does not need to be displayed in the UI

note that we do want do display certain JS types such as JS arrays, maps, sets, bools, ints, etc.

find if the type of the variable corresponds to a JS error and needs to be mapped to dart stack trace.

Currently we rely on type names for identifying those, which was proven to be fragile in the past.
See the latest example in https://github.com/dart-lang/webdev/issues/1821
Suggestion:

define ddc runtime API, ie isNativeJavaScriptError(object) and isNativeJavaScriptObject(object).
we can evaluate expressions like require('dart_sdk').dart.isNativeJavaScriptError(object) to use them in the debugger.

@srujzs
We should add this API to the DDC runtime and have tests that break when we make changes to the JS interop   representations.

Would we still need this API if we start exposing JS types e.g. JSMap, JSObject, etc.? I think in the past this was fragile because we were relying on internal representations (Interceptors), and not external representations.
If I'm understanding this correctly, we'd like to tell if this is not a Dart type and also not one of several JS types. We also want to tell if a variable is a JS Error type.
I think this is doable with a combination of is checks and instanceof with the JS types.

@srujzs I think using JS types and instanceOf is more stable, as long as we never need to detect an internal type. Will all the current errors be direct instances of Error, or is there going to be a class hierarchy similar to what we have now?

@srujzs what needs to be done here to expose JS types?

Will all the current errors be direct instances of Error, or is there going to be a class hierarchy similar to what we have now?

Can you explain a bit more what you're looking for here? Like subtypes of Error? I'm not sure if we're going to introduce a JS type for Error (although we certainly could), so I'd like to make sure I understand all the use cases here.

what needs to be done here to expose JS types? Could adding a ddc runtime API be an easier (even if temporary) solution for now so we prevent dwds from breaking on such changes?

We have some JS types exposed via dart:js_interop, but they're very much in flux for the next few months, so I think adding an API to DDC is certainly reasonable in the meantime. I remember coming across this in the past too, so it's worth it to not break dwds.

FYI - I just came across this issue while investigating https://github.com/dart-lang/sdk/issues/52572. My current change to address that other issue is to remove the coupling between NativeError and Error in the DDC layer, doing this may affect some of the behavior in dwds because we are asking queries about JavaScript using the internal Dart types.
Exposing helpers in the DDC runtime seems like it may be the most robust way to improve this. Another option here is to directly identify native objects within JavaScript, but I get the impression it will not be as robust, since we do sometimes map native types to Dart types.

This is superseded by work in https://github.com/dart-lang/webdev/issues/1949


Does Pywhispercpp support batching and what gives if not?

See here...start thinking about true batching..  😉
https://github.com/shashikg/WhisperS2T/issues/33

@BBC-Esq, are you talking about batch decoding?
If whisper.cpp supports it, then I believe it will be supported here as well.

@BBC-Esq, are you talking about batch decoding? If whisper.cpp supports it, then I believe it will be supported here as well.

I think he means batch prepping?

cough

import os
from pywhispercpp.model import Model
import multiprocessing
from glob import glob

files = [f for f in glob("*") if os.path.isfile(f) and not f.endswith((".py"))]

def transcribeFile(file, queue):
    model = Model("base")
    segments = model.transcribe(file)
    queue.put([file, segments])

if __name__ == "__main__":
    queue = multiprocessing.Queue()
    processes = []
    for file in files:
        process = multiprocessing.Process(target=transcribeFile, args=(file, queue))
        processes.append(process)

    for process in processes:
        process.start()
        process.join()

    for transcriptions in queue.get():
        print(transcriptions)

@BBC-Esq @abdeladim-s here's some simple code to batch process with multiple independent whisper instances to ensure context is not maintained under any circumstances between whisper instances.

cough
import os
from pywhispercpp.model import Model
import multiprocessing
from glob import glob

files = [f for f in glob("*") if os.path.isfile(f) and not f.endswith((".py"))]

def transcribeFile(file, queue):
    model = Model("base")
    segments = model.transcribe(file)
    queue.put([file, segments])
    return True

if __name__ == "__main__":
    queue = multiprocessing.Queue()
    processes = []
    for file in files:
        process = multiprocessing.Process(target=transcribeFile, args=(file, queue))
        processes.append(process)

    for process in processes:
        process.start()

    for transcriptions in queue.get():
        print(transcriptions)

@BBC-Esq @abdeladim-s here's some simple code to batch process with multiple independent whisper instances to ensure context is not maintained under any circumstances between whisper instances.

Cleaned it up. Fixed it running in parallel.

cough
import os
from pywhispercpp.model import Model
import multiprocessing
from glob import glob

files = [f for f in glob("*") if os.path.isfile(f) and not f.endswith((".py"))]

def transcribeFile(file, queue):
    model = Model("base")
    segments = model.transcribe(file)
    queue.put([file, segments])
    return True

if __name__ == "__main__":
    queue = multiprocessing.Queue()
    processes = []
    for file in files:
        process = multiprocessing.Process(target=transcribeFile, args=(file, queue))
        processes.append(process)

    for process in processes:
        process.start()

    for transcriptions in iter(queue.get, None):
        print(transcriptions)

@BBC-Esq @abdeladim-s here's some simple code to batch process with multiple independent whisper instances to ensure context is not maintained under any circumstances between whisper instances.
~It doesn't do them in parallel as of now due to calling join, but that's fine. It's still batching it. I'll clean this up later.~
Cleaned it up. Fixed it running in parallel. And oh boy is it a CPU killer.

So a quick heads up, it is painfully slow to do this in parallel. Like dog slow and the more files you throw at it, the slower it gets. But this is just POC code. There's room for improvement such as batching based on file length, file size, core counts, etc.
I'll see if I can beat a few optimizations out of this.

import os
from pywhispercpp.model import Model
import multiprocessing
from glob import glob
import asyncio

files = [f for f in glob("*") if os.path.isfile(f) and not f.endswith((".py"))]

def transcribeFile(file, queue):
    model = Model("base")
    segments = model.transcribe(file)
    queue.put([file, segments])

if __name__ == "__main__":
    queue = multiprocessing.Queue()
    processes = []

    for file in files:
        process = multiprocessing.Process(target=transcribeFile, args=(file, queue))
        processes.append(process)
        process.start()

    for process in processes:
        process.join()

    while not queue.empty():
        print(queue.get())

This is where I am at. It can queue up lots of files to do in parallel. But there's no limits on how many, that needs improvement. I also need to make it accept adding new things to its queues.

If you're after serial batch transcriptions:

from pywhispercpp.model import Model
import os
from glob import glob

if __name__ == "__main__":
    files = [file for file in glob("*") if os.path.isfile(file) and not file.endswith((".py")) and not file.endswith((".cfg")) and not file.endswith(".txt")]

    for file in files:
        model = Model("base")
        segments = model.transcribe(file)

        with open(f"{file}-transcription.txt", "w") as f:
            for segment in segments:
                f.write(segment.text)

@UsernamesLame, That's multi-processing.
The scripts look work great :+1:

Unfortunately, as @abdeladim-s knows, I can't get pywhispercpp to even install correctly...

@UsernamesLame, That's multi-processing.
The scripts look work great :+1:

It's "batch" processing 😅

Unfortunately, as @abdeladim-s knows, I can't get pywhispercpp to even install correctly...

Dump logs. Let's get this working.

Logs dumped and now I'm flushing the toilet.  😉 jk  Won't have time today as I'm working on the benchmarking repo for a bit...need to get an appropriate dataset and then learn/use the jiwer library? lol


Bug: islandora_objects migration (migrate_7x_claw) lacks mapping for islandora:sp_pdf to field_model

The result is the default (which maps to islandora_models Binary) is applied.
To fix this, I would add a line here mapping islandora:sp_pdf to islandora_models term "Digital Document" (https://schema.org/DigitalDocument).
This code seems to imply that this is the correct field_model value for nodes with PDF media. (?)
I am happy to create a PR with this update if it's appropriate. Lemme know.

#925

PRs are always welcome, @kspurgin. Yes, "Digital Document" (https://schema.org/DigitalDocument) is the right one, although perhaps the tags migration is a bit more authoritative.


[Fix] fix Sequence import error

Motivation
to fix an import error with python 3.10 below
    from collections import Sequence
ImportError: cannot import name 'Sequence' from 'collections' (/usr/lib/python3.10/collections/__init__.py)

Modification
change the imported module following this line
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Congrats on getting your first PR merged into OpenMMLab! We are so grateful for your hard work and dedication to our community.
We'd like to invite you to join our Discord server to connect with other contributors, ask questions, and receive feedback. It's an awesome community that's welcoming and helpful, and we think you'll love it!
Join us now at https://discord.gg/qH9fysxPDW and let's continue making amazing things together!

Dear yukke42,
First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
As a valued contributor, we would also like to invite you to join our Special Interest Group (SIG) private channel, where you can share your experiences, ideas, and build connections with like-minded peers.
Join us ：https://discord.gg/raweFPmdzG
To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there!
Also，if you have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx，or scan the following QR code to join us. Please add "mmsig + Github ID" as a remark when adding friends：）
Best regards！ @yukke42


SqlAGDatabase: Corrected PsDscRunAsAccount to PsDscRunAsCredential

Task list

[ ] Added an entry under the Unreleased section in the CHANGELOG.md? Entry
should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md?
[x] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help?
[ ] Comment-based help added/updated?
[ ] Localization strings added/updated in all localization files as appropriate?
[ ] Examples appropriately added/updated?
[ ] Unit tests added/updated?
See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible)?
See DSC Resource Testing Guidelines.
[x] New/changed code adheres to
DSC Resource Style Guidelines
and Best Practices?

This change is

Codecov Report

Merging #1199 into dev will not change coverage.
The diff coverage is n/a.

 Merging as soon as the tests are passing.


Get code certificate to prevent Smartscreen notification

We get a smartscreen error because we don't have a (valid) code signing certificate (which isn't the same as a SSL certificate and a lot more expensive)

@dsplaisted
I saw your post on twitter. Any luck on this? How to continue?

This isn't really needed anymore for people that use the Windows Store version. The only place this impacts is the Chocolatey version.

I don't think this is needed for the Chocolatey version?

Technically, smart screen still could have an error/warning for running an untrusted binary. If it hasn't been an issue with choco, then we can close this. Just wasn't sure.

this is not needed anymore.


Unable to Add Description to new Drone Item

When creating an entirely new Drone Item entry, it is not possible to add a description long short or a GM note to the Item. The edit symbol does appear in the text field.  Details may be edited, but the description cannot be.

I cannot reproduce this. My steps to reproduce were:

Open drone sheet
Go to features tab
Add a new mod
Click mod edit button
On the mod's details tab, switch to short description tab
Click text edit button and enter a text
Hit save
Close drone mod item sheet
Re-open drone mod item sheet and check short description tab
See text I entered.

Are any of my steps different from yours?

I have retraced; it appears that the new drone item I had specified was a
"chassis" not an item. There are two options in the drop down when you
create the Drone item, apparently I had kept selecting "chassis". That
can't be described - probably because there is already a number of
items present on that drone, including s chassis.
The new item description, when specified to be an "item" and not a chassis,*
is* describable.
I have wasted your time. I apologize.
.Robert
On Tue, Apr 27, 2021 at 5:18 AM Deepflame @.***> wrote:

I cannot reproduce this. My steps to reproduce were:

Open drone sheet
Go to features tab
Add a new mod
Click mod edit button
On the mod's details tab, switch to short description tab
Click text edit button and enter a text
Hit save
Close drone mod item sheet
Re-open drone mod item sheet and check short description tab
See text I entered.

Are any of my steps different from yours?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wildj79/foundryvtt-starfinder/issues/380#issuecomment-827455072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATH2F44R5O4NZFEZH7EN6ALTKZ6OFANCNFSM43PGYQKQ
.

I would like to resurrect this issue, I find many item types are uneditable. However, it looks only like ones without a "sidebar" (the one that says "passive") are uneditable e.g themes, classes, archetypes. Feats are editable because they have a sidebar.
This explains the bug @fatigues65 experienced. The Drone chassis item doesn't have a sidebar.
It's also worth noting normally uneditable item types that have entries in the compendium are editable, sidebar or not.

Gotcha. It's not that they're uneditable, it's just that because the sidebar is missing the text box height is set to 0 making it very difficult to edit, which I suppose comes down to the same thing. :D Either way, I think I have already fixed this issue, I now ensure a height.


docker-compose.yml still contains an older NEST version

Describe the bug
docker-registry.ebrains.eu/nest/nest-simulator:3.4 is still loaded in the docker-compose.yml. The NEST images are now back on Dockerhub.
The current image can be found here:
nest/nest-simulator:3.6

The release v4.0 updates docker-compose.yml. It contains the latest NEST image.


0 added reads with GTDB database for all taxonomic units

Hi there,
Thanks for developing Struo2 and for releasing the GTDB kraken2 dbs prepared with struo2.
I'm using Kraken v2.1.1 and Bracken v2.8 on paired-end animal microbiome data and the struo2 GTDB_release207 kraken2 DB GTDB . The files I have under in my kraken2/bracken DB are as follows with matching md5sums to those in the mentioned DB repository.
-rw-rw-r--  1 ali  ali  287G dec 21 18:53 hash.k2d
-rw-rw-r--  1 ali  ali    64 dec 21 18:53 opts.k2d
-rw-rw-r--  1 ali  ali  9,8M dec 21 18:53 taxo.k2d
-rw-rw-r--  1 ali  ali    59 dec 21 18:53 database150mers.kmer_distrib
-rw-r--r--  1 ali  ali  578M dec 21 18:53 database150mers.kraken

When I run kraken2 and Bracken using this database, I don't get any added reads from Bracken. Any idea why this might be the case, e.g. could I be missing some required files/folders here, or a kraken2 or Bracken version issue?

Can you please share the log for the run?

@nick-youngblut , sure
(base) ali@NLTNRLNX0021:~/test_folder/test_taxonomic_profiling/local$ ~/packages/kraken2/build/kraken2 --threads 12 \
> --confidence 0 \
> --unclassified-out HAV1804-11-8-18_39-A_S8_unclassified_R#.fastq.gz \
> --output HAV1804-11-8-18_39-A_S8_kraken_output \
> --report HAV1804-11-8-18_39-A_S8_kraken_report.txt \
> --memory-mapping \
> --use-names \
> --db /ramdisk/ \
> --paired \
> --gzip-compressed \
> /home/ali/test_folder/test_taxonomic_profiling/local/cromwell-executions/shotgun_tax_classification/f8ca0b08-d81d-4130-8615-60a68ef6295c/call-kraken/shard-0/inputs/542559876/HAV1804-11-8-18_39-A_S8_L001_R1_001.fastq.gz /home/ali/test_folder/test_taxonomic_profiling/local/cromwell-executions/shotgun_tax_classification/f8ca0b08-d81d-4130-8615-60a68ef6295c/call-kraken/shard-0/inputs/542559876/HAV1804-11-8-18_39-A_S8_L001_R2_001.fastq.gz
Loading database information... done.
9599389 sequences (2882.08 Mbp) processed in 84.199s (6840.5 Kseq/m, 2053.77 Mbp/m).
  6580152 sequences classified (68.55%)
  3019237 sequences unclassified (31.45%)
(base) ali@NLTNRLNX0021:~/test_folder/test_taxonomic_profiling/local$ /home/ali/packages/Bracken-2.8/bracken \
> -i HAV1804-11-8-18_39-A_S8_kraken_report.txt \
> -d /ramdisk/ \
> -l S \
> -o HAV1804-11-8-18_39-A_S8_bracken_output_S-lvl.txt \
> -w HAV1804-11-8-18_39-A_S8_bracken_report_S-lvl \
> -r 150 \
> -t 100
 >> Checking for Valid Options...
 >> Running Bracken
      >> python src/est_abundance.py -i HAV1804-11-8-18_39-A_S8_kraken_report.txt -o HAV1804-11-8-18_39-A_S8_bracken_output_S-lvl.txt -k /ramdisk/database150mers.kmer_distrib -l S -t 100
PROGRAM START TIME: 12-22-2022 09:56:34
>> Checking report file: HAV1804-11-8-18_39-A_S8_kraken_report.txt
BRACKEN SUMMARY (Kraken report: HAV1804-11-8-18_39-A_S8_kraken_report.txt)
    >>> Threshold: 100
    >>> Number of species in sample: 51679
          >> Number of species with reads > threshold: 2155
          >> Number of species with reads < threshold: 49524
    >>> Total reads in sample: 9599389
          >> Total reads kept at species level (reads > threshold): 5371999
          >> Total reads discarded (species reads < threshold): 435116
          >> Reads distributed: 0
          >> Reads not distributed (eg. no species above threshold): 773037
          >> Unclassified reads: 3019237
BRACKEN OUTPUT PRODUCED: HAV1804-11-8-18_39-A_S8_bracken_output_S-lvl.txt
PROGRAM END TIME: 12-22-2022 09:56:36
  Bracken complete.

I don't see anything obvious in the logs that could explain your outcome. Do you get a different result when using the default kraken2 & bracken databases?

@nick-youngblut yes! Also, I do get added reads with Bracken when I use the struo1 database (with lower % of Kraken2-classified reads, of course).
Can you confirm that you get added reads with Bracken when you use the abovementioned database?


Transparency issues on model with WebGL 1

Project: https://playcanvas.com/editor/scene/1170592
WebGL 1: https://launch.playcanvas.com/1170592?webgl1=true&debug=true

WebGL 2: https://launch.playcanvas.com/1170592?debug=true

I'm not sure what the problem is exactly, but the material lambert4 has Alpha to Coverage ticked. This is not supported on WebGl1. When I untick the option, even webgl2 looks the same as webgl1. Is the project set up to take advantage of Alpha to Coverage? If it is, this cannot be used on WebGl1.

Closing because the difference was caused by alpha to coverage being enabled and we're stripping WebGL 1 support from the engine anyway.


Test boss

I'd like to assign a bounty to this issue.

/boss $20

15jokoandi/guide.cocoapod.org


Doesn't work with textareas

I tested it with <textarea> and it doesn't work. Works OOB with inputs even with a big datalist.

Yeah i just found that too.

Unfortunately, the chat bot CSS template I am using has a textarea instead of an input field...


add support for GCC 6.4.0

GCC 6.4.0 has one big advantage over 6.3.0: it is shipped as .tar.xz,
shaving 30 MB from its download size, and also considerably speeding
up the extraction process.
All patches are symlinks to the GCC 6.3.0 ones, except 0004-posix_memalign.diff
which was rebased to apply cleanly.
0014-ubsan-empty-string-fix.diff was removed, since it was upstreamed.

I merged this squashed with the commit message edited not to say it's using symlinks (since it's not after the squash).

thanks! https://github.com/richfelker/musl-cross-make/compare/5a84fa2cbb...2fef342276


Nil pointer dereference error with organisation

I've attempted to run this against my org from my mac laptop and from a linux container and get the same segmentation violation.
actions-usage  --org MYORG  --token-file ~/pat.txt  --days 1

2023/10/30 19:35:52 Fetching jobs for: run ID:<PHONE_NUMBER>, startedAt: 2023-10-30 19:27:54, conclusion:
2023/10/30 19:35:52 Fetching jobs for:<PHONE_NUMBER>, page 0
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x65a180]

goroutine 1 [running]:
main.main()
	/home/runner/work/actions-usage/actions-usage/main.go:238 +0x30e0

Hey @MattMencel which version are you using?

/set title: Nil pointer dereference error with organisation

Hi @alexellis, see below. It's the latest version.
> arkade get actions-usage
Downloading: actions-usage
2023/11/10 15:22:07 Looking up version for actions-usage
2023/11/10 15:22:07 Found: v0.1.0
...
# Test the binary:
/Users/matt.mencel/.arkade/bin/actions-usage

> ~/.arkade/bin/actions-usage  --org myorg  --token-file pat.txt  --days 1
Fetching last 1 days of data (created>=2023-11-09)
2023/11/10 15:21:20 Fetching repos myorg page 0
2023/11/10 15:21:21 Status: 200 Page 0, next page: 2
2023/11/10 15:21:21 Fetching repos myorg page 2
2023/11/10 15:21:21 Status: 200 Page 2, next page: 0
2023/11/10 15:21:21 Found: myorg/firstrepo
2023/11/10 15:21:21 Listing workflow runs for: myorg/firstrepo
2023/11/10 15:21:23 Listing workflow runs for: myorg/firstrepo
2023/11/10 15:21:26 Listing workflow runs for: myorg/firstrepo
2023/11/10 15:21:28 Listing workflow runs for: myorg/firstrepo
2023/11/10 15:21:32 Listing workflow runs for: myorg/firstrepo
2023/11/10 15:21:33 Found 454 workflow runs for myorg/server
2023/11/10 15:21:33 Fetching jobs for: run ID:<PHONE_NUMBER>, startedAt: 2023-11-10 21:07:11, conclusion:
2023/11/10 15:21:33 Fetching jobs for:<PHONE_NUMBER>, page 0
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x18 pc=0x10073b8a4]

goroutine 1 [running]:
main.main()
	/home/runner/work/actions-usage/actions-usage/main.go:254 +0x2984

Thanks for the info. Assuming you've now updated to the latest version, errors from that line are about matching on the latest version:
https://github.com/self-actuated/actions-usage/blob/master/main.go#L254C1-L255C1
Unfortunately, we can't reproduce the issue running against other open source or private organisations.
The only thing I can suggest is that we try to add some defensive coding around accessing variables that may be nil.
@Jasstkn @Shikachuu could you take a look and see what you think?

This release may show us the culprit repo  I know you're being secretive with your organisation name), but it may help show you what's different.
Either it's not being detected in your total list of repositories in the organisation, and therefore has no summary pre-populated, or it's a repo that was deleted, but has actions runs history. Let's see if we can find out.
https://github.com/self-actuated/actions-usage/releases/tag/v0.1.1

Glad to hear it 👍


Should Zvkt DIEL mandate cover immediate and register index values ?

follow-up of a discussion held during July 13th Task group meeting (with @kdockser , @mjosaarinen  and others)
Question: Should Zvkt DIEL mandate also cover immediate values and static value registers ?
Rephrasing:

Q1. Should  vop.vi vd, vs2, imm be forced to expose a latency which is independent from imm value ?
Q2. Should vop.vx vd, vs2, x0 latency be indistinguishable from vop.vx vd, vs2, x<i> (i != 0) when GPR[x] === 0 ?

Some reference from Zkt (https://github.com/rvkrypto/riscv-zkt-list/blob/main/zkt-list.adoc#some-notes-on-rationale)

Binary executables should not contain secrets in the instruction encodings (Kerckhoffs’s principle), so instruction timing may leak information about immediates, ordering of input registers, etc. There may be an exception to this in systems where a binary loader modifies the executable for purposes of relocation — and it is desirable to keep the execution location (PC) secret. This is why instructions such as LUI, AUIPC, and ADDI are on the list.

Q2 does not apply to x0 only, but this is where it may be the most interesting (as x0 is hard-wired to 0)
The register index value  cannot arguably be considered as part of the data so I would argue that Q2 as a pretty straightforward answer: the execution latency of an instruction under a DIEL mandate can still depend on the value of the indices of the registers used as source / destination.
Let us now consider the dependency on the immediate value:
Pros (for considering the value of the immediate as a data covered by the DIEL mandate):

Not introducing a distinction between the various operand types of an instruction

Cons:

The immediate value is part of the opcode (so different immediate values imply [as for the register indices] different instructions)
Removing this mandate does not affect security (an immediate value or a register index are never part of a secret and should never be)
Allowing more implementation freedom by not mandating extra constraints and allowing micro-architectures to optimize some specific cases as the implementer see fit without compromising the conformity to Zvkt

For the last point, I do not have strong examples. vwsll.vi vd, vs2, 0 or vwsll.vx vd, vs2, x0 could be an interesting thing to optimize for a micro-architecture, but it can be replaced by a vzext.vf2 although this require a different vlmul/vsew setting (as SEW is used for vwsll source and vzext.vf2 destination and similarly for LMUL: vwsll destination EMUL is 2*LMUL while it is LMUL for vzext.vf2).
Similarly vmv.v.i could also be optimized on a data dependent fashion (I assumed some immediates are more used than others but I did not check any codebase).

The spec had been updated to explicitly state that DIEL does not apply to constants specified in the instruction encoding such as immediate values and the zero register x0.


Fix run-android to execute app on all connected devices

*EDIT: *
This has been updated to simply fix the run-android command so that it runs on all connected devices instead of throwing an error.
Original PR description:
This adds a new command to the react-native CLI. When executed this command will install and successfully execute your app on all connected Android devices:
react-native run-android-all
Closes #5901
Note: I wasn't sure how to approach this API since it seems a bit like a flag, but I didn't see any other flags implemented in the cli so it seems like the current trend is to keep all commands to a single phrase. I am open to changing this if need be.

Looks good! I think it should be a flag, it would be nice to support specifying on which device to run on too. Actually shouldn't it run on all devices by default?
I had something like this in mind:
Run on all connected devices:
react-native run-android

Run on the devices specified as arguments:
react-native run-android nexus_5 nexus_4

It could also be a flag like --devices
This could also be ported to run-ios to select what device/simulator to run on.

Thanks for checking it out. I'm very new to RN so I tried to be as unassuming in this PR as possible. I appreciate any advice on the API from current users so as not to miss any use cases here.
Looking at it again, currently in master it appears that the app is actually being installed on all devices but only erroring when it actually tries running the app on multiple devices. That makes it a bit hard to know if the original intent was to have it run on all devices by default or if it was just supposed to run on one.
Either way is fine with me, but if we are just fixing a bug here then we could replace run-android's implementation with that of run-android-all. If instead we'd be implementing new, breaking functionality then I'd be more concerned.
If we are just bug fixing the existing run-android command with this change then we can more easily do as you suggested and implement a new feature which is a flag that allows for an additive / inclusive API.
I hadn't tried run-ios. I've just week running w/Xcode. I'll have to take a look.

Not sure if it is a bug or not but I doubt it will cause any issues. If we want to keep this PR simple you could simply replace run-android implementation with yours that runs it on all connected devices. Let's see if anyone has something to add :)

Ok! 👍🏽
On Fri, Feb 12, 2016 at 8:50 PM Janic Duplessis<EMAIL_ADDRESS>wrote:

Not sure if it is a bug or not but I doubt it will cause any issues. If we
want to keep this PR simple you could simply replace run-android
implementation with yours that runs it on all connected devices. Let's see
if anyone has something to add :)
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/pull/5902#issuecomment-183570033
.

IMHO It should run on all devices by default. Not sure how useful selective running is though.

Ok @janicduplessis thanks for your suggestions. I think I've made all of the style fixes you suggested. Just as a follow up, I received a reply in #5901, it appears that the intent of react-native run-android is to run on just one device. So, that gives us some clarity. Based on that response is seems that there is indeed a bug/odd behavior in the current implementation run-android that causes run-android to fail if you have multiple devices plugged in.
That means that we have 3 uses cases:

run-android Run the app on just one device. (but breaks if multiple are plugged in, status quo)
run-android-all Run the app on all connected devices. (implemented in my PR)
run-android-only nexus_6 nexus_7 droid_2 Run the app on only certain  connected devices. (unimplemented, but could be implemented pretty easily)

Again, my preference would be to get rid of the current implementation(1) and replace it with my implementation of run-android-all but I suppose that is out of the picture given @mkonicek's reply. So, let's shoot for just adding 2 and 3 to the cli.

@jimthedev

but I suppose that is out of the picture given @mkonicek's reply

I'm guess @mkonicek meant to say that it's the current behaviour, rather than running on all devices is not acceptable.
Personally I think running on all devices by default is more useful than failing of multiple devices connected.
About the CLI option, we were talking about replacing 'run-android' with 'run android'. So this should be a CLI parameter to the 'run-android' command rather than a new command.

@satya164 Ahh ok I see. Looks like it can be read multiple ways. Thanks for pointing that out. I think you're correct.
I refactor run-android to use my implementation. We can address the specific device flag as a separate feature once the command is swapped out to be run android.

@satya164 @janicduplessis Ok this should be ready.

LGTM

cc @mkonicek

@satya164 So was the review accepted or no?

Wow this is a pretty sweet idea! Have you checked if Gradle can do this? If not doing it yourself like this is good.
I have been extremely busy the last two days but will find time to review this. Thanks for the patience!

I think @satya164 wanted me to take a look too before merging this.

@mkonicek Ah yes I see that now. No rush on the review or merge. I just wanted to make sure the labels weren't messed up.
I haven't looked at gradle to see if it can do this but I've also never worked with gradle before.  Maybe this is a good chance to do that. Originally I had this set up in a separate bash script but wanted it to work cross-OS.  My gut is always to go with JS as a webdev but am certainly open to suggestions on where to start w/gradle if that's a better way to go.

This only starts the app on all connected devices, correct?
Note that 'run-android' does two things: push the app to the single connected device (search the code for installDebug) and start it.
I suggest you make 'run-android' do exactly what it does now but on multiple devices instead. This means installing and starting on multiple devices. Note that installing can be flaky / time out etc. So if installing on one device fails you can still continue with the others.
Overall, how often would you use this feature? If you only edit JS you only execute 'run-android' once and then reload JS on each device, correct? But still think it can be useful to start on all rather than throwing an error if multiple devices are connected.

Thanks for the PR @jimthedev. I quickly Googled "gradle install multiple devices" and "gradle install all devices" and doesn't look like it's supported by default.
Looks like the Android Studio can do that but not Gradle itself: http://stackoverflow.com/questions/25848152/gradle-android-studio-deploy-run-on-multiple-devices-parallel

Thanks for the feedback. I'm on mobile and will have to review your
suggestions more in detail on desktop. I just wanted to clear up that all
this does is run on multiple devices but oddly the previous code already
installed it on both devices, I did not make any changes to app installing.
The only thing that was erroring running on multiple devices. I'll confirm
this when I'm on desktop but wanted to get you some ASAP feedback. Thanks
again. More to come.
On Sun, Feb 21, 2016 at 5:17 PM Martin Konicek<EMAIL_ADDRESS>wrote:

Thanks for the PR @jimthedev https://github.com/jimthedev. I quickly
Googled "gradle install multiple devices" and "gradle install all devices"
and doesn't look like it's supported by default.
Looks like the Android Studio can do that but not Gradle itself:
http://stackoverflow.com/questions/25848152/gradle-android-studio-deploy-run-on-multiple-devices-parallel
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/pull/5902#issuecomment-186941779
.

Also, I run the commands daily since we lock devices up at night.
On Sun, Feb 21, 2016 at 5:34 PM<EMAIL_ADDRESS>wrote:

Thanks for the feedback. I'm on mobile and will have to review your
suggestions more in detail on desktop. I just wanted to clear up that all
this does is run on multiple devices but oddly the previous code already
installed it on both devices, I did not make any changes to app installing.
The only thing that was erroring running on multiple devices. I'll confirm
this when I'm on desktop but wanted to get you some ASAP feedback. Thanks
again. More to come.
On Sun, Feb 21, 2016 at 5:17 PM Martin Konicek<EMAIL_ADDRESS>wrote:

Thanks for the PR @jimthedev https://github.com/jimthedev. I quickly
Googled "gradle install multiple devices" and "gradle install all devices"
and doesn't look like it's supported by default.
Looks like the Android Studio can do that but not Gradle itself:
http://stackoverflow.com/questions/25848152/gradle-android-studio-deploy-run-on-multiple-devices-parallel
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/pull/5902#issuecomment-186941779
.

Ah the installDebug already does handle multiple devices? Good to know. No rush, take you time and thanks for working on this.

@mkonicek Ok I've taken up your suggestions and added flow returns in the areas you indicated. Also, if for any reason getDevices returns and empty array, we fallback to the previous method.

Awesome!

@facebook-github-bot shipit

Failed to merge because of a merge conflict in runAndroid.js. Please rebase.
Thanks for working on this!

@facebook-github-bot shipit

Failed internal integration tests, trying again to see if the failure is related:
@facebook-github-bot shipit

@facebook-github-bot shipit

Documentation still emphasizes that you should have only one device connected: https://facebook.github.io/react-native/docs/running-on-device.html#2-plug-in-your-device-via-usb


[6865] Set up structure for mapping hesa data

Context
We need to map from HESA data sent to the API to our internal Register data format. In order to do this, we should support receiving HESA attributes/values and then re-mapping them to our normal register data format to go through validation/processing.
This ticket lays the groundwork in introducing a new mapping class to take in the params, map and return a data shape which can go into our normal attributes/validation classes.
Changes proposed in this pull request

New Api::Hesa::MapTraineeAttributes to serve as a home for mapping additional hesa fields
Separate POST request spec to test hesa mapping logic
Introduces new hesa_data: true flag when sending hesa data in the api so they can be routed correctly

Guidance to review

Discussed offline. We're going to leave the PR as is based on what was understood at the time and card up a new ticket to make changes based on updated requirements.


@directives in css.customData generate validation warning

.vscode/settings.json
{
  "css.customData": ["./.vscode/custom.css-data.json"]
}

.vscode/custom.css-data.json
{
  "version": 1.1,
  "atDirectives": [
    { "name": "@value", "description": "Custom value" }
  ]
}

It shows up under code completion. It also shows the description on however. It however is still marked as Unknown at rule @valuecss(unknownAtRules).

👍


Implement semantic verification of fields length, traversal_time, stair_count, max_slope, min_width,

Is your feature request related to a problem? Please describe.
These numeric fields should be user configurable so that suspicious values can be reported.
Describe the solution you'd like

[ ] Add new Warning notice:

SuspiciousPathwayLengthNotice
SuspiciousPathwayTraversalTimeNotice
SuspiciousPathwayStairCountNotice
SuspiciousPathwayMaxSlopeNotice
SuspiciousPathwayMinWidthNotice

[ ] Add support to provide thresholds for these fields values via configuration file and/or command line

[ ] Determine default values for said thresholds

Closing, we're not implementing thresholds at this time

Closing, we're not implementing thresholds at this time


JsIterator interface apparently permits Java code to implement two methods with the same name

@JsType(isNative = true, name = "Iterator", namespace = JsPackage.GLOBAL)
public interface JsIterator<VALUE> {
  JsIIterableResult<VALUE> next();

  JsIIterableResult<VALUE> next(VALUE p0);
}

Attempting to implement this results in runtime confusion, as the Java type is attempting to export two different functions, both with the same name "next". Here from just wrapping a plain iterator - returning null for the next(val0), and roughly this code for the next() method:
JsIIterableResult<SomeObject> val = JsIIterableResult.create();
if (iterator.hasNext()) {
  val.setValue(iterator.next());
}
val.setDone(!iterator.hasNext());
return val;

cggl.MyIterator_classLit = createForClass('my.pack.age', 'MyIterator', 355);
mp.MyIterator = function MyIterator(val$iterator){
  this.val$iterator2 = val$iterator;
}
;
defineClass(356, 1, {}, mp.MyIterator);
_.next = function next_1(p0){
  return castTo(p0, 59) , null;
}
;
_.next = function next_0(){
  var val;
  val = jb.emptyObjectLiteral();
  ju.$hasNext_8(this.val$iterator2) && (val.value = ju.$next(this.val$iterator2));
  val.done = !ju.$hasNext_8(this.val$iterator2);
  return val;
}
;

It isn't clear how the developer can know that this cannot be implemented by their own Java (aside from the "try-it-and-fail" approach), in contrast with EventInit, JsIterableResult and other interfaces. It looks like perhaps several bugs coming together, but at least for elemental2, the next(val) method could be removed. It doesn't appear to be a part of the spec except in a "sure, I guess you could do that, but we're not defining it" sort of way https://www.ecma-international.org/ecma-262/6.0/#sec-iteration, suggesting that the specifying the type (or count) of the argument in the interface may not be necessarily correct.

Arguments may be passed to the next function but their interpretation and validity is dependent upon the target Iterator.

There is a way to implement it. Not sure where we documented that but I know we intended to document that at least :)
But before any of that, this something enforced by restriction checking and  should be a compile error so you should file a GWT bug (and maybe try to send a patch).

Hi @niloc132 Did you fill a GWT bug as suggested by @gkdn ?

Sorry, making my way through lots of old bugs that I haven't followed up on. I will file a bug against gwtproject/gwt about the restriction checker failing to enforce, and then someone can describe how one would get around this? Best I can come up with is making your own @JsFunction and casting to this one, but that seems silly.

So to implement it you need to choose one of the methods (the more general of the two) to implement in the subclass.
class MyJsIterator<X> implements JsIterator<X> {

   JsIterableResult<X> next(X p0) {
      if (p0 == null) {
          // here would be a call without the parameter (also when called with null)
     }
  }
}
```

When there are NATIVE overloads you can only implement one of the types in the subclass. You might have any number of native overloads as long as there is only one method with a body.

This is not a bug in elemental, but rather it is probably a bug in GWT. It should work fine in J2CL. If it does not work in J2CL file a bug there.

Sorry, meant to get this sent off last night, but I couldn't work out the actual failure in time - I had erroneously been making the implementation bind T as Object, which does not result in a failure. Now that I understand what is happening, I'll see if I can work out a fix this evening.
Thanks for the workaround @rluble!


How to fix this warning?

Change your project framework to version 4.5.
https://msdn.microsoft.com/en-us/library/bb772098(v=vs.90).aspx


warp

Hello, hope you doing great.
I've installed cloudflare warp for ipv6 successfuly and i've checked the changes and it is all good.
I have an issue with my phone, I usually use ssh tunneling or vless on my phone but the problem is that the clients like napsernet or others are not working with my cloudflare ipv6, instead they're working with ipv4.
I've prioritized ipv6 for wireguard and vps (op. 15 and 16 of script).
am i missing something here? how can i solve this?

Sorry I don‘t use WARP on iPhone.
Some solution :
1 Edit vless config  outbound and route rule to support  napsernet using WARP on VPS , then iPhone connect to VPS using vless
2 try use 21 , another WARP project .  https://github.com/fscarmen/warp


Revert "perf: set the log merge policy (#195)"

This reverts commit e2988db8673f11df0531b5df636378a1669525d9.
The change was unnecessary because the log merge policy is the default merge policy already.

Should we instead add docs for log merge upstream?