Az network vnet peering create fails with error: "KeyError: 'subscription'"

Describe the bug
When I try to run az network vnet peering create I get an error, see below.
To Reproduce

~/» az network vnet peering create -g resource -n test --vnet-name vnet1 --remote-vnet-id vnet2 --verbose --debug
Event: Cli.PreExecute []
Event: CommandParser.OnGlobalArgumentsCreate [<function on_global_arguments at 0x7f78969f9758>, <function on_global_arguments at 0x7f78960d09b0>, <function on_global_arguments at 0x7f78960e60c8>]
Event: CommandInvoker.OnPreCommandTableCreate [<function remove_logger_flags at 0x7f78969f97d0>]
Installed command modules ['acr', 'acs', 'advisor', 'ams', 'appservice', 'backup', 'batch', 'batchai', 'billing', 'botservice', 'cdn', 'cloud', 'cognitiveservices', 'configure', 'consumption', 'container', 'cosmosdb', 'dla', 'dls', 'dms', 'eventgrid', 'eventhubs', 'extension', 'feedback', 'find', 'interactive', 'iot', 'iotcentral', 'keyvault', 'lab', 'maps', 'monitor', 'network', 'policyinsights', 'profile', 'rdbms', 'redis', 'relay', 'reservations', 'resource', 'role', 'search', 'servicebus', 'servicefabric', 'sql', 'storage', 'vm']
Loaded module 'acr' in 0.003 seconds.
Loaded module 'acs' in 0.002 seconds.
Loaded module 'advisor' in 0.001 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'ams' in 0.005 seconds.
Loaded module 'appservice' in 0.006 seconds.
Loaded module 'backup' in 0.002 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'batch' in 0.015 seconds.
Loaded module 'batchai' in 0.003 seconds.
Loaded module 'billing' in 0.001 seconds.
Loaded module 'botservice' in 0.004 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'cdn' in 0.003 seconds.
Loaded module 'cloud' in 0.001 seconds.
Loaded module 'cognitiveservices' in 0.001 seconds.
Loaded module 'configure' in 0.000 seconds.
Loaded module 'consumption' in 0.007 seconds.
Loaded module 'container' in 0.001 seconds.
Loaded module 'cosmosdb' in 0.003 seconds.
Loaded module 'dla' in 0.004 seconds.
Loaded module 'dls' in 0.002 seconds.
Loaded module 'dms' in 0.002 seconds.
...
Loaded module 'servicebus' in 0.005 seconds.
Loaded module 'servicefabric' in 0.001 seconds.
Loaded module 'sql' in 0.006 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'storage' in 0.028 seconds.
Loaded module 'vm' in 0.013 seconds.
Loaded all modules in 0.196 seconds. (note: there's always an overhead with the first module loaded)
Extensions directory: '/home/user/.azure/cliextensions'
Event: CommandInvoker.OnPreCommandTableTruncate []
Event: CommandInvoker.OnPostCommandTableCreate [<function add_id_parameters at 0x7f7895e1ab18>, <function add_subscription_parameter at 0x7f7895e30848>]
Event: CommandInvoker.OnCommandTableLoaded []
Event: CommandInvoker.OnPreParseArgs [<function _documentdb_deprecate at 0x7f7895b11320>]
Event: CommandInvoker.OnPostParseArgs [<function handle_output_argument at 0x7f78960d0a28>, <function handle_query_parameter at 0x7f78960e6140>, <function parse_subscription_parameter at 0x7f7895e308c0>, <function handler at 0x7f7895a630
50>]
'subscription'
Traceback (most recent call last):
File "/usr/lib64/az/lib/python2.7/site-packages/knack/cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "/usr/lib64/az/lib/python2.7/site-packages/azure/cli/core/commands/init.py", line 369, in execute
six.reraise(*sys.exc_info())
File "/usr/lib64/az/lib/python2.7/site-packages/azure/cli/core/commands/init.py", line 343, in execute
result = cmd(params)
File "/usr/lib64/az/lib/python2.7/site-packages/azure/cli/core/commands/init.py", line 182, in call
return self.handler(*args, **kwargs)
File "/usr/lib64/az/lib/python2.7/site-packages/azure/cli/core/init.py", line 436, in default_command_handler
result = op(**command_args)
File "/usr/lib64/az/lib/python2.7/site-packages/azure/cli/command_modules/network/custom.py", line 2937, in create_vnet_peering
aux_subscription = parse_resource_id(remote_virtual_network)['subscription']
KeyError: 'subscription'
Suppress exception Return value is not string
telemetry.save : Save telemetry record of length 2454 in cache

Expected behavior
It should work. :)
Environment summary
Yum installed latest CLI version on Centos.

~/» az --version                                                                                azure-cli (2.0.45)
acr (2.1.4)
acs (2.3.2)
advisor (0.6.0)
ams (0.2.3)
appservice (0.2.3)
backup (1.2.1)
batch (3.3.3)
batchai (0.4.2)
billing (0.2.0)
botservice (0.1.0)
cdn (0.1.1)
cloud (2.1.0)
cognitiveservices (0.2.1)
command-modules-nspkg (2.0.2)
configure (2.0.18)
consumption (0.4.0)
container (0.3.3)
core (2.0.45)
cosmosdb (0.2.1)
dla (0.2.2)
dls (0.1.1)
dms (0.1.0)
eventgrid (0.2.0)
eventhubs (0.2.3)
extension (0.2.1)
feedback (2.1.4)
find (0.2.12)
interactive (0.3.28)
iot (0.3.1)
iotcentral (0.1.1)
keyvault (2.2.2)
lab (0.1.1)
maps (0.3.2)
monitor (0.2.3)
network (2.2.4)
nspkg (3.0.3)
policyinsights (0.1.0)
profile (2.1.1)
rdbms (0.3.1)
redis (0.3.2)
relay (0.1.1)
reservations (0.3.2)
resource (2.1.3)
role (2.1.4)
search (0.1.1)
servicebus (0.2.2)
servicefabric (0.1.2)
sql (2.1.3)
storage (2.2.1)
telemetry (1.0.0)
vm (2.2.2)
Python location '/usr/lib64/az/bin/python'
Extensions directory '/home/user/.azure/cliextensions'
Python (Linux) 2.7.5 (default, Jul 13 2018, 13:06:57)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
Legal docs and information: aka.ms/AzureCliLegal

I tried clearing out my ~./azure folder and also reinstalling the CLI tools.

Oh, actually I figured out half of it. --remote-vnet-id is expecting a full id path like /subscriptions/xxxx-xxx-xxxx-xxxx-xxxxxxx/resourceGroups/thing/providers/Microsoft.Network/virtualNetworks/name but it seems to crash the script if it doesn't get that.

@QuinnDamerell-MS Where can I find that full path? I don't see it anywhere

Found it, it's under "Properties" inside the vnet settings page. Here's a sample command that worked for me. Note that only the remote-vnet has to have the long path (not both vnets)
az network vnet peering create -g groupname -n newvnetname --vnet-name firstvnet --remote-vnet /subscriptions/223423-2342234-34-234-24/resourceGroups/YourResourceGroup/providers/Microsoft.Network/virtualNetworks/secondvnetname --allow-vnet-access --allow-forwarded-traffic --subscription subscriptionnameorid

@emirhosseini without going to the portal you can just run:
az network vnet show -g {rg} -n {name} --query "id"
Also, now the remote Vnet should not require an ID provided both vnets are in the same resource group and subscription.


Environment/Lookup: evaluations on d1 are not necessary

We always use d8 (as we always suppose degree 7 for the lookup constraints).

Aren't they used to compute each poly_d1?

They are not used to compute the quotient polynomial, therefore not required in the lookup environment.


IE11: side-nav last menu item disappears if height isn't big enough

How to reproduce:
Using IE11, go to http://materializecss.com/ and make the window height smaller, until it doesn't fit all the menu items anymore. The last item will be cut off without showing scrollbars. Only when the height doesn't accomodate the last TWO items, the scroll bar appears.
In the CSS for side-nav there is
height: calc(100% + 60px);
padding-bottom: 60px;

Why is there a bottom padding? What is it good for?
To fix the problem, we need this:
height: 100%;
padding-bottom: 0;

Apparently the 60px bottom padding prevents a bug on mobile, when the page is scrollable, because dragging down in the menu, scrolls the whole page, too (unlike on desktop) and therefore makes the address bar at the top disappear. So the viewport gets bigger and theres a gap of the height of the address bar (60px) at the bottom of the menu.
This problem could be prevented if the page did not scroll when dragging the menu.

Just a friendly reminder that this issue still exists. We have implemented the suggested fix by fabyeah above (removing padding-bottom), however it would be nice to avoid coding up exceptions.

+1 We have also problem with -moz-calc

+1 Same problem here


FIX: Fixed Documentation Issue #7750

An attempt to fix the issue #7750
It was labeled as a Documentation issue and in the winsorize function, according to the documentation if inclusive is True then the number of data being masked on each side should be rounded and if False, then it should be truncated. But the code in scipy/scipystats/mstats_basic.py did the reverse.
I believe the documentation is correct, so I changed the if condition to satisfy the documentation.

Thanks for the correction @xoviat . The fix would be considered wrong as it won't satisfy the tests in scipy/stats/tests/test_mstats_basic.py . Thus, it was classified under Documentation issue. So, I'll change the documentation and make a new Pull Request.


fix: correct orderBy default to DESC.

What kind of change does this PR introduce?

[x] bug fix
[ ] feature
[ ] docs
[ ] update

What is the current behavior?
According to official API docs, orderBy parameter is default DESC. But the orderBy in PageRequest class is ASC as default.
What is the new behavior?
Set DESC as default to orderBy.

Thanks for the fix, we will apply the fix in v1.1.0 release.


Update spaper star count

Update spaper star count

There were an issue with the preview deployment, which have been solved.
Can you rebase your branch ?


Building Native App

Hello, I was wondering if you could help me for the building part (Final App)
I'm trying to build the app with android studio and launching the app but it seem to be linked again with the localhost server . And show a red screen with error to communicate with server
Could we build the app with everything integrated in the app (Scene, Images) ?
Thanks for your help
Michael

Hi @Zirconiumirish,
Assuming you've already run our ./setup-ide.sh script for Android, we share the same release build instructions as React-Native, which can be found here:
http://facebook.github.io/react-native/releases/0.47/docs/signed-apk-android.html
If you wanted to build release through Android Studio instead, you would still need to run ./gradlew bundleGvrReleaseJsAndAssets or ./gradlew bundleOvrReleaseJsAndAssets depending on which build you want because that's how React-Native bundles the assets you use in JS.
Let us know if you run into any trouble with that!

Andy

Alright Thanks =)


[port 0.54] Respect canRetry from error thrown from token provider

Port https://github.com/microsoft/FluidFramework/pull/8971

Is this necessary? I mean, looks fine just trying to save work.

Do we need the change prior to next deployment?


patient location details added to the schema, and update patient func…

…tionality add to the patient conroller, in addtion to bug fix in the patient routes

patient merge


Display with wrong colors

Describe the bug
Last week, I had no trouble with Shadow. The client updated, and was not able to connect anymore to the remote server (R-0x7F error).
Checking the requirements on Ubuntu (I'm using 20.04) on https://help.shadow.tech/hc/en-gb/articles/360015561600-Hardware-Requirements-For-Using-Shadow, I saw the optionnal requirement of libva-glx2.
I've installed it and then managed to get connected.
But the image is now not usable anymore:

It was with Stable Shadow.AppImage. I then tried the ShadowBeta.AppImage, but I have the same issue.
System is up-to-date.
I've checked with an other PC on WIndows without issue, It could be a problem with my Ubuntu set-up, but it was functional last week before the update.
System

OS: Ubuntu
OS Version: 20.04
Environment: Gnome and i3 (checked with both)
Application: ShadowBeta.AppImage
Application Version: 4.16.6

Configuration

The user is in input group ? no, it wasn't needed until now
The environment uses Xorg ? I think so (with gnome and i3)
VA API detects H264 ? And H265 ? yes (check_driver.sh scripts reports no error)

To Reproduce
Steps to reproduce the behavior:
Logging to Shadow and see screen
Screenshots
added in the description
Additional context

check https://nicolasguilloux.github.io/blade-shadow-beta/issues#the-drirc-fix

thanks for the solution :pray: and sorry for opening a not relevant issue !


Python Twine Upload Authenticate problem when project contains space in name

Required Information
Question, Bug, or Feature?
Bug
Enter Task Name:  Python Twine Authenticate v0/v1
Environment
Azure Pipelines
Issue Description
Python Twine Upload Authenticate problem when project contains space in name
current pypirc file created is incompatible with twine.
twine splits index-servers on the space characters Azure project names with spaces result in trying to find
"project" and "name/feed"
I suggest an optional argument to manually set the section name for the index-servers in the .pypirc file
This can also be used with twine -r
[distutils]
index-servers = project name/feed
[project name/feed]
repository =
username =
password =
Task logs
python -m twine upload -r "example_feed" --config-file /home/vsts/work/_temp/twineAuthenticate/zMTT6I/.pypirc /home/vsts/work/1/s/dist/*
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/*********************************.sh
InvalidConfiguration: Missing 'example_feed' section from the configuration file
or not a complete URL in --repository-url.
Maybe you have an out-dated '/home/vsts/work/_temp/twineAuthenticate/zMTT6I/.pypirc' format?
more info: https://packaging.python.org/specifications/pypirc/
Troubleshooting
Example of .pypirc
at /home/vsts/work/_temp/twineAuthenticate//.pypirc
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/.sh
[distutils]
index-servers=project name/feed
[project name/feed]
repository=************
username=build
password=***
Error logs
[Insert error from the logs here for a quick overview]

relates to https://github.com/pypa/twine/pull/673


scipy.special: fix dependencies for _ellip_harm_2

Generating the source for _ellip_harm_2 requires the cython_special module to already be compiled. Add a dependency for this. Note that it now must be a custom target because generators do not support extra dependencies.
Fixes: #19167
Reference issue
Closes gh-19167
What does this implement/fix?
Fix dependencies for _ellip_harm_2 Cython generation.
Additional information

Cc: @rgommers

Well, one build succeeded here, so any other missing dependencies seem to be masked by available parallelism on the test machine (the only one that found the problem).

Thanks @mathstuf. This does fix the problem, but wouldn't this more minimal fix do?
diff --git a/scipy/special/meson.build b/scipy/special/meson.build
index e7e25aa54..900064410 100644
--- a/scipy/special/meson.build
+++ b/scipy/special/meson.build
@@ -318,12 +318,12 @@ cython_special_pxd = custom_target('_dummy_cython_special.pxd',
 uf_cython_gen = generator(cython,
   arguments : cython_args,
   output : '<EMAIL_ADDRESS>-  depends : [_cython_tree, _ufuncs_pxi_pxd_sources])
+  depends : [_cython_tree, _ufuncs_pxi_pxd_sources, cython_special_pxd])

 uf_cython_gen_cpp = generator(cython,
   arguments : cython_cplus_args,
   output : '<EMAIL_ADDRESS>-  depends : [_cython_tree, _ufuncs_pxi_pxd_sources])
+  depends : [_cython_tree, _ufuncs_pxi_pxd_sources, cython_special_pxd])

 py3.extension_module('_ufuncs',
   [

That's analogous to how it's already done in linalg/meson.build and optimize/meson.build. I just tested two builds, with -j64 and -j1, as well as only building _ellip_harm_2.so, and that is all happy.

That does look better. I think I had first tried that with cython_special and got told "no" because of it being a CustomTarget or something. I didn't go back and try it with the _pxd object.

In it goes. Thanks @mathstuf!


FontBureau profile for checks on proposed new variation axes

I have just had a nice videocall with Mirko (@bghryct) in which he told me he's interested in implementing FontBakery checks for the new variation axes proposed here:
https://variationsguide.typenetwork.com/
I believe that we can use the same strategy that we're using for the gf-axis-registry checks by employing textproto files for those axes. But I would place these new axes on a separate profile (Mirko suggested to call it the fontbureau profile). If these axes are added to the GFAxisRegistry in the future, it would then be super easy to migrate the textproto files into the googlefonts profile.

@bghryct, please post here the contents of a textproto file for at least one of the newly proposed axes. The structure of such textproto files can be seen here: https://github.com/google/fonts/tree/fa38f09d14b5c976a5b0c140cdfbc562023fc38e/axisregistry

# ytlc based on https://variationsguide.typenetwork.com/
tag: "ytlc"
display_name: "y transparent lowercase"
min_value: 0
max_value: 1000
default_value: 500
precision: 0
fallback {
  name: "Non ytlc"
  value: 0
}
fallback {
  name: "ytlc"
  value: 1
}
description:
  " assigns a “white” per mille value to each instance of the design space"
  " it is possible to think of this white space as the increase in counter"
  " forms accompanying the increase in the x-height of letter forms"
  " Imagine an h where the x-height increases but the ascender remains the same"
  " In static fonts, this change would occur in instances with per-mille values"
  " appended to their names. e.g. myfont-480.ttf"

I'm not sure if this is absolutely correct @felipesanches  as I don't fully understand the fallback value meanings, or what precision means for that matter.
Really appreciate you taking the time to walk me through fontbakery check writing this morning.

Check out these discussions about new custom axis registries; maybe they are of any help on the process, and you could participate also :)
https://github.com/google/fonts/issues/2846
https://github.com/google/fonts/pull/2853
https://github.com/google/fonts/issues/2888

@bghryct, can you provide the textproto files for all other proposed axes?

@bghryct, can you provide the textproto files for all other proposed axes?

@felipe @vv-monsalve
I will when I get a chance, I'm a bit busy with client work atm. Should be able to within the next week and a half.
Where should I include the textproto files?

@felipe @vv-monsalve
I will when I get a chance, I'm a bit busy with client work atm. Should be able to within the next week and a half.
Where should I include the textproto files?

you can send a PR adding them to this directory: Lib/fontbakery/data/. There are already some other textprotos in there.

you can send a PR adding them to this directory: Lib/fontbakery/data/. There are already some other textprotos in there.

@felipesanches
Sounds good

@felipesanches
Sounds good


Azure SQL and DTC?

Please confirm that Azure SQL Database supports Microsoft Distributed Transaction Coordinator (MS DTC).
In this article it also say Azure SQL supports DTC: Supporting Distributed Transactions
But here it say that Azure SQL does NOT support DTC: Feature comparison: Azure SQL Database versus SQL Server
And here it say:  "Since MSDTC is not available for Platform-as-a-Service application in Azure..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9134176c-f048-ad0d-ced6-99e8214350cb
Version Independent ID: df2f6e46-bd91-3018-a6b7-de6e283df9ab
Content: Performing Distributed Transactions - SQL Server
Content Source: docs/relational-databases/native-client/odbc/performing-transactions-distributed-transactions.md
Product: sql
Technology: native-client
GitHub Login: @MightyPen
Microsoft Alias: genemi

@sarvesh-s Hi Sarvesh,  Please, can you tell us about how DTC is or is not supported on Azure SQL Database, DW, versus SQL Server on-premises?
CC: @MightyPen

Azure SQL DB supports distributed transactions without using msdtc. Only .net surface area is supported using TransactionScope() from C# code. Native c++ odbc drivers or linked servers using t-sql or Jdbc drivers are not supported on Azure SQL DB service.

On premises SQL supports msdtc as-is.
DW does not support it.

https://docs.microsoft.com/en-us/sql/relational-databases/native-client-ole-db-transactions/supporting-distributed-transactions?view=sql-server-2017

https://docs.microsoft.com/en-us/sql/relational-databases/native-client/odbc/performing-transactions-distributed-transactions?view=sql-server-2017
@sarvesh-s The documentation does not agree with you

@Bartolomeus-649 This Issue 2107 is now fixed by Pull Request 10195 (in our private repo).
In general, before the PR 10195, the article spoke misleadingly about the relationship between MSDTC and Azure SQL Database.  The article implied that MSDTC applied to Azure SQL DB.
The article as revised by PR 10195 clarifies that distributed transactions can apply to Az SQL DB, just not by using MSDTC.
Thank you for submitting this issue.  Given PR 10195, it is time to close this issue, as fixed.
(The @ notification mechanism continues to work even after an issue is closed.)
@sarvesh-s Thank you very much for you informative and timely response.


README: drop "experimental"

rust-analyzer is not very experimental anymore, so let's drop that.
bors r+

changelog skip
(I guess?)


feat: add Capacitor 6 support

v3.0.0 was just released, and it supports Capacitor 6.
npm i<EMAIL_ADDRESS>
full changelog: https://github.com/jonz94/capacitor-image-picker/compare/v2.0.1...v3.0.0


[FE]: Propagate some properties to all children items

Description: (details of what and how should work)
Ex. "Production Release" update in FE should propagate to all US, DE and TA under it.
There may be more properties like that which should propagate as well
Additional Context & Ad Hoc Info:

Requested by PO
Assumes RVI can do more than GET

May be connected, but not dependent on or duplicate, to #34

This is doable with RVI terminal and too broad to consider for UI changes in any way.


refactor: Re-arrange code for readability

Some folder arrangement can help navigate and having an overview of the existing code, now that the codebase has been growing. This PR adds folders for

Client: protocols and impls to communicate to the backend endpoints
Producers: the offered Event Producers
Utils: smaller helper struct/extensions are collected here, these are likely not containing major protocols

This PR also introduces some better naming consistency throughout and smaller cleanups.
Final structure:

Will be tackled in a future PR


Add EMS Refresh worker for Kubernetes.

@abonas Please review.
I noticed we did not have the refresh workers in place for Kube so I added them.  I don't have an environment to test, so if you could, please do.  Simplest way to test is:

Run MIQ_SPARTAN=minimal:ems_inventory bundle exec rake evm:start
wait until workers start
tail the evm.log
Go into rails console
Run EmsRefresh.queue_refresh(EmsKubernetes.first)
Watch the log and see if the refresh goes through without any errors

cc @blomquisg @brandondunne We really need a setup in our lab.

:+1:

I tested locally with a "fake" record, and it works fine...obviously it doesn't actually refresh, but the workers start, monitor for work, and putting a refresh on the queue gets picked up and executed (and then fails as expected).

@Fryguy thanks a lot for this, I'll test it and let you know.
Couple of general questions:
What is the worker scope? Is there a new worker for each provider instance? (e.g. 2 k8s providers = 2 workers?) Will another provider type (another subclass of ems_container) need an additional worker as this one?

What is the worker scope? Is there a new worker for each provider instance? (e.g. 2 k8s providers = 2 workers?)

A separate instance of the worker will be run for each ems instance, so, yes, 2 k8s providers = 2 workers.  The way it works is via the PerEmsWorkerMixin, which is part of the base EmsRefreshWorker.  In there we check for all valid EMSes in the zone and from that determine the expected workers.  From there the evm server starts or stops the necessary workers to create the desired state.

Will another provider type (another subclass of ems_container) need an additional worker as this one?

I would create a new one, but I'm not 100% sure what would happen with both in place.  I don't think we've ever done subclassing of one EMS from another, so it's possible it might spin up duplicates, which we'll have to address.  Another reason to get that new class in sooner than later, so that we can't start working out any kinks.

@Fryguy @abellotti - this seems to work fine, at least I didn't see any errors - in the log is a message representative of a "worker" -
[----] I, [2015-03-10T08:44:03.469508 #10394:38be90]  INFO -- : MIQ(MiqQueue.put)        Message id: [164279],  id: [], Zone: [default], Role: [ems_inventory], Server: [], Ident: [ems_10], Target id: [], Instance id: [], Task id: [], Command: [EmsRefresh.refresh], Timeout: [7200], Priority: [100], State: [ready], Deliver On: [], Data: [], Args: [[["EmsKubernetes", 10]]]


Fix GH Actions Parameters and Improve Integration with BrowserStack

For details, please see the commit messages.

Actually, one thing. Can you change the type of your commits to chore as fix will make semantic-release cut a new release, which we probably don't want to do?
I've submitted https://github.com/jginsburgn/karma/pull/1. I'm not particularly sure how did John generate the token for Travis, but as far as I understand it should be PAT with the write access to https://github.com/karma-runner/karma-runner.github.com. I think that the default GitHub token can only write to this repo and will not work for the script.

@googlebot I consent.

Thanks. One last thing before I merge, I would prefer that the commit messages, which contain valuable information, do not get lost. So instead of squashing, I would fast forward for merging. Sounds good?

And, how are we going to know that the docs fix worked?

I guess we'll know for sure once the next release is made, but for now, you can try to do a similar thing to what the script does locally to confirm that the token actually allows to push to the repo
$ export DOCS_GITHUB_TOKEN=<token>
$ git clone<EMAIL_ADDRESS>$ cd karma-runner.github.com
$ git checkout -b tmp
$ touch test.txt
$ git add text.txt
$ git commit -m test
$ git push origin tmp
$ git push -d origin tmp

or something :)

It works!!!!!


Need to click the button instead of Card in Settings of Admin Dashboard

Describe the bug
We need to click the button(p tag) to open that setting, I can make the card clickable so that it is easy to navigate.
We can also add icons also in these cards like in the dashboard.

Please approve this, so that I can start working on this bug.

`husky > pre-commit (node v14.4.0)
/d/AA Work/GSoC/Community-Website/backend/node_modules/.bin/lint-staged: line 5: cygpath: command not found
internal/modules/cjs/loader.js:1032
throw err;
^
Error: Cannot find module 'D:\lint-staged\bin\lint-staged.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1029:15)
at Function.Module._load (internal/modules/cjs/loader.js:898:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
husky > pre-commit hook failed (add --no-verify to bypass)`
I am getting this error while committing the changes to my forked repo.
Please help me regarding this.

@Kajol-Kumari can you also look into this issue.

Hey @dhwaj1902 I am hoping to see you come up with a better UI than what we have now. If you are thinking of removing the button look. As the current UI is looking preety good to me.

@Kajol-Kumari  I have already changed the card in this pr.
Please review this pr.


Fix review suggestions for "Implementation for decimal.round with fractionDigits"

[ ] Add testscases for round functions with named arguments
[ ] Move testcases from Java to Ballerina

Fixed with https://github.com/ballerina-platform/ballerina-lang/pull/35758


Fix Inoreader's 'mark as unread' not working issue

Remove unnecessary parameters from the URL request made to Inoreader
to mark articles as 'read/unread', as these parameters are making the
requests invalid. Altough marking articles as read still works, marking
them as unread does not.
Fixes: #1109

Coverage decreased (-0.04%) to 57.607% when pulling bdd37108633aec6d21a9828e9cf494859d92f4f8 on JRuiBarros:master into 5e3fa256490a370a2f5c5cc5590f7e1a1fef3bbb on newsboat:master.


Loading PLOS paper previews fails

The PDF URL has changed.

Also, PLOS doesn't allow to show PDFs from their server in an iframe any more. The solution is that PDFs are now first downloaded to the local server and then served to the client from there.


break with ChefDK 0.13.21

Hi,
I'm using the ChefDK version 0.13.21, I installed this gem with chef gem install knife-solo, and then I bumped to this issue.

/opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/specification.rb:2288:in raise_if_conflicts': Unable to activate knife-solo-0.5.1, because net-ssh-3.1.1 conflicts with net-ssh (< 3.0, ~> 2.7) (Gem::ConflictError)     from /opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/specification.rb:1408:inactivate'
from /opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems.rb:200:in rescue in try_activate'     from /opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems.rb:193:intry_activate'
from /opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:126:in rescue in require'     from /opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:40:inrequire'
from /Users/cduong/.chefdk/gem/ruby/2.1.0/gems/knife-solo-0.5.1/lib/chef/knife/cook.rb:1:in <top (required)>'     from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:100:inload'
from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:100:in block in load_commands'     from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:100:ineach'
from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:100:in load_commands'     from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:110:inload_command'
from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:124:in command_class_from'     from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife.rb:153:insubcommand_class_from'
from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife.rb:214:in run'     from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/application/knife.rb:148:inrun'
from /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/bin/knife:25:in <top (required)>'     from /opt/chefdk/bin/knife:51:inload'

Even though I have  gem net-ssh with 2 versions (3.1.1, 2.9.4), but knife is still using the later one. I don't know how to force the 2.9.4 for ChefDK gem set.

chef gem list | grep ssh
net-ssh (3.1.1, 2.9.4)
net-ssh-gateway (1.2.0)
net-ssh-multi (1.2.1)

The next release should fix this.
I've been struggling to get the integration suite updated and green for the
release though.
In the mean time downgrading chefdk or using knife-solo master are the
recommended workarounds.
On Friday, 20 May 2016, chrisd<EMAIL_ADDRESS>wrote:

Hi,
I'm using the ChefDK version 0.13.21, I installed this gem with chef
gem install knife-solo, and then I bumped to this issue.
/opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/specification.rb:2288:in
raise_if_conflicts': Unable to activate knife-solo-0.5.1, because
net-ssh-3.1.1 conflicts with net-ssh (< 3.0, ~> 2.7) (Gem::ConflictError)
from
/opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/specification.rb:1408:in
activate'
from /opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems.rb:200:in rescue
in try_activate'
from /opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems.rb:193:in
try_activate'
from
/opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:126:in
rescue in require'
from
/opt/chefdk/embedded/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:40:in
require'
from
/Users/cduong/.chefdk/gem/ruby/2.1.0/gems/knife-solo-0.5.1/lib/chef/knife/cook.rb:1:in
<top (required)>'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:100:in
load'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb
💯in block in load_commands'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:100:in
each'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb
💯in load_commands'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:110:in
load_command'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife/core/subcommand_loader.rb:124:in
command_class_from'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife.rb:153:in
subcommand_class_from'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/knife.rb:214:in
run'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/lib/chef/application/knife.rb:148:in
run'
from
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.9.41/bin/knife:25:in <top
(required)>'
from /opt/chefdk/bin/knife:51:inload'
Even though I have gem net-ssh with 2 versions (3.1.1, 2.9.4), but knife
is still using the later one. I don't know how to force the 2.9.4 for
ChefDK gem set.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/matschaffer/knife-solo/issues/488

--
-Mat
matschaffer.com

Installing knife-solo 0.7.0pre works for me:
chef gem install knife-solo -v "0.7.0pre"

Thanks for reporting @git-ong - still need to get a proper release out but I'll close this ticket for now.


Sentinels can destroy items in item frames

The output of command /version on my server is: This server is running Tuinity version git-Tuinity-"cc34294" (MC: 1.16.4) (Implementing API version 1.16.4-R0.1-SNAPSHOT)
The output of command /version citizens on my server is: Citizens version 2.0.27-SNAPSHOT (build 2191)
The output of command /version sentinel on my server is: Sentinel version 2.2.0-SNAPSHOT (build 377)
A pastebin.com link to my (full!) Sentinel/config.yml file is: https://pastebin.com/raw/SKGYZFsF

Saves: https://pastebin.com/raw/Z3zwaVgR
My Sentinels are able to destroy items in item frames with their arrows, if using a bow.

I'm fairly surprised that it took so long for somebody to have this happen (or, I guess: to notice it happening).
Fixed for build 379+ https://ci.citizensnpcs.co/job/Sentinel/
All non-living entities are now undamageable by Sentinel attacks including projectiles.

Great support as always. Thanks for being out there!


Update scaleover plugin due to cli change

@krujos can you please update the created and updated fields to fit the ISO 8601 date/time format. It should look like:
created: 2015-05-27T00:00:00Z
updated: 2016-05-14T00:00:00Z

Updated in latest commit. Thanks!


ceph: implement resizing

Closes #3760.
Signed-off-by: Christian Brauner<EMAIL_ADDRESS>

Can we add a test for this similar to what we do for LVM?b

@stgraber, test added.


IsLive not updating on external login ,also no logic on logout making islive as false.

[JSInvokable]
public async Task ConfirmExternal(string provider, string userName, string name, string accessToken)
{
var user = await CreateUserWithExternalProvider(provider, userName, name, accessToken);
await TokenProvider.Login(user);
// var res=UserManager.UpdateIsLive(userId: user.Id,  true); //this is missing
NavigationManager.NavigateTo(NavigationManager.Uri, true);
Logger.LogInformation("{@UserName:l} has successfully logged in", userName);
}

Thank you for pointing this out. Regarding the isLive field, we've stopped using it. We are now determining user online status via SignalR, rather than through login and logout actions. So, the absence of the related logic aligns with our current design.


i18n: update uk translation

Hi, I come with new strings)
Can you add search by tags in favorites?

Hi, I come with new strings)

Thanks!

Can you add search by tags in favorites?

Feel free to open a new issues or pull request ☕


Add topic on building component libraries

We should have a topic around the new component library template that shows how to build, package, and share libraries of components.
See https://blogs.msdn.microsoft.com/webdev/2018/04/17/blazor-0-2-0-release-now-available/ for some existing content.

Changing this from a tutorial to a topic. Might be good to have a tutorial at some point as well, but I'd like a normal topic first.

@stimms Sounds great! I would just use the content in the Blazor Class Library (blazorlib) template. It already contains a component and shows how you can include static assets.
Here's a brain dump of what I would expect to see in this doc:

Components are just .NET types and component libraries are just normal .NET assemblies
Create component libraries using the Blazor Class Library template (dotnet new blazorlib)
Component libraries can include static assets, like JS, CSS, images, etc.
Packaging component libraries and sharing via NuGet
Consuming component libraries (add package, use temporary @addTagHelpers workaround)

Component libraries can include static assets, like JS, CSS, images, etc.

👍

@stimms If you have any questions on the topic+sample setup for the repo, feel free to ping me.


Vendorize libiconv on macOS

After a long struggle with lots of wrong turns, I think this is how we fix things.
The root problem
On macOS 13 (or 14; I've lost track now), the system version of libiconv switched from the GNU implementation to the FreeBSD implementation. There are API incompatibilities between the two; this presents a problem for superstring, which previously was happy to rely on the ambient libiconv.dylib already present on the default library load path.
When I first noticed this problem back in January, I didn't investigate the root cause; it wasn't affecting our binaries yet because we were pinned to older macOS versions in CI. I just knew that I could fix it locally (i.e., when running from source via ATOM_DEV_RESOURCE_PATH) by installing Homebrew's version of libiconv and making sure its paths were present in my LDFLAGS and CPPFLAGS environment variables.
So when CirrusCI automatically upgraded our macOS images and our Apple Silicon builds started failing with the same iconv errors, I figured the solution was the same. We modified the CI job to run brew install libiconv, modify LDFLAGS and CPPFLAGS, and proceed as usual. That was enough to get Pulsar to compile, so we thought the job was done.
The second problem
Except we hadn't solved anything. We'd gotten Pulsar to compile by telling it about a dynamic library that was present on the CI machine; but all that did was lead Pulsar to assume that that library would be present on everyone's machine. So we ended up producing a version of Pulsar that would refuse to run unless you had libiconv present at /opt/local/opt/libiconv. (That isn't even the standard brew --prefix, so a local Homebrew installation of libiconv would still probably fail this test.)
The fix
A day's worth of flailing ensued, interrupted by occasional research. The most fruitful results were this blog post (which summarized the dilemma rather well and hinted at the eventual solution), followed by this blog post (exposing me to this strange install_name_tool utility and its ability to resolve relative paths).
Then, the breakthrough: searching GitHub for ways that other libraries use binding.gyp and install_name_tool. (That search query isn't working right now, so I'm glad it was working last night.)
Here's the short version:

When you build a dylib file, it is tagged with an ID that also happens to be a path on disk. This is the install name of the library. This is how macOS disambiguates various versions/copies of the same dynamic library.
If you try to “borrow” a copy of a dylib from a known location, you will confuse the binary that relies on it. It will complain that it can't find the library.
You can mess with DYLD_LIBRARY_PATH to get around this, but the better way to do it is to use install_name_tool to point that binary to a different install name (and thus a different path on disk).
You can also use install_name_tool to tag a dylib with a different ID.
Years ago, it used to be the case that an install name had to be an absolute path on disk; this made it hard for applications to bundle their own dynamic libraries unless they mandated that they be run from the /Applications folder. Luckily, Apple added a few magic tokens that made it possible to define library locations relative to the things that request them.

So our first task is to vendorize libiconv. We were already doing this for Windows; now we're doing it for macOS as well.
Since the vendored files we need are platform-specific, we can copy the files we need from the user's Homebrew installation or from a path that the user provides via an environment variable. We do this as a pre-compile task on macOS only.
In our case, the thing that needs libiconv.dylib is the built superstring.node module. So as a post-compile task, we make sure that the module we just built knows where to find our vendorized copy of libiconv.dylib. The @loader_path magic token is what tells it to search relative to itself.
This should get superstring working on macOS again — not just compiling but also running in a self-contained manner. I've been testing this by temporarily moving the Homebrew version of libiconv to a different place on my local machine just to confirm it doesn't confuse superstring. And the effects of install_name_tool seem to survive a trip through electron-rebuild, so this isn't even something that the pulsar repo needs to be aware of.
How we proceed
I'm fine with landing this however we want to. We can land it on master and tag a new release; we can land it on a branch; doesn't matter much. In the short term, the goal is to be able to modify Pulsar’s package.json to point superstring to a tag/SHA on our repo instead of a version number on NPM. If we do that — and modify the resolutions so that text-buffer uses that same copy for its superstring dependency — then everything should work, and we'll be able to build Apple Silicon binaries again on macOS.
(The same problem would've eventually struck us on the Intel Mac side, too. This way we get out ahead of it.)
Testing
For sanity's sake, I'd love your help testing this no matter which platform you're on. If you're on Windows or Linux, it'd be great to know for sure that I haven't broken anything (though CI should help there).
Any macOS users can try the steps below. If you're on an Intel Mac… well, so am I, but it'd still be good to have another data point. If you're on Apple Silicon, I'm especially interested in your experience.

Check out this PR.
In the project root, run npm run build:node.
If you don't have a Homebrew installation of libiconv, the script should halt the build and tell you why.
Once you do have a Homebrew installation of libiconv (brew install libiconv), the script should copy its files into its vendor/libiconv directory and build against them.
When it's done:

cd build/Release
otool -L superstring.node
The output should contain the following<EMAIL_ADDRESS>(compatibility version 9.0.0, current version 9.1.0)

cd ../../vendor/libiconv/lib
ls -l
Verify that libiconv.2.dylib is present.

It'd certainly be nice to get CI working on macOS, but that's a pre-existing issue and is probably less urgent than our need to get binaries building again.

Just realized that I've probably vendorized some things that would need to be built on a per-platform basis. We could get around this by continuing to rely on the presence of Homebrew libiconv, but running some sort of pre-build action that finds said Homebrew installation, copies the files to where we want them to be, then runs install_name_tool to rename the library file.
I'll look at the Homebrew recipe and try to understand it a bit better. We could vendorize libiconv in unbuilt form and then build it ourselves for the target platform, but then we're basically doing Homebrew's job, except worse.

I did a test PR on the pulsar repo with the superstring dependency changed to point to the head of this PR. I was able to produce seemingly working builds for both Intel Mac and Apple Silicon.
I tested the Intel Mac binary and it worked fine; I say “seemingly” here because CI produces an unsigned build for PRs. I have no reason to doubt that code signing would work.
@meadowsys is our guinea pig for Apple Silicon builds, so I'll update when I hear back from them. I did notice this in the CirrusCI build logs…
warning: changes being made to the file will invalidate the code signature in: /opt/homebrew/opt/libiconv/lib/libiconv.2.dylib

…and I believe it would've happened when we used install_name_tool to change that .dylib’s install name. If this ends up causing problems, I think I could manage to work around this and make that step unnecessary.
But then the code signing of the app itself appeared to work properly, so I'm hoping that's all we need. The post-build Playwright smoke tests also ran smoothly.

I can vouch that, on my macOS machine (macOS Catalina 10.15.7, intel x86_64 processor), the steps under the Testing section of the PR text above worked as the instructions said they should.
As for getting CI working, I've got a couple of commits here to make a bit of progress on that: https://github.com/DeeDeeG/superstring/commits/472c6db1c05879cad9600a357fda1a2082bdf056

I addressed some feedback on Discord by making sure we copy libiconv’s license file and README to the vendor/libiconv directory.
@meadowsys reported on Discord that the Apple Silicon binary works fine, which… was a bit surprising to me? I was pretty sure it was going to complain about the code signature on libiconv.2.dylib — so sure that I had started to adopt a different approach to avoid changing that library's install name. I won't mess with that we've got if it's working, but I will check that approach into the repo just in case we need it in the future.

Anyway, here's how we could proceed:

Optionally wait for macOS CI jobs to start working (@DeeDeeG, that decision is up to you)
Land this PR
Tag a new version
Optionally publish this version on NPM as @pulsar-edit/superstring or something (don't think we've ever done this before, but it'd be nice to have our forked code be available on NPM for a handful of reasons)
Open a PR pointing Pulsar's package.json to the new version of superstring, either on NPM or on GitHub
Do some sanity testing on the binary artifacts of that new PR
Land that PR

At that point, it'd be great to use this whole ordeal as an excuse to revisit #9 and #10 — neither of which is crucial in the short-term, but both of which would be nice to address. I think it's a good idea to start inching closer to the parts of Pulsar that make us nervous: superstring, other native modules formerly owned by the Atom team, and finally text-buffer.

Closing in favor of #15.


Better default layout for horizontal.

For a default cake app there is a lot of space wasted through way too big forms.
And the brake point should be "sm" not "md" IMO.
I also think horizontal should probably be the default.
But with "options" coming to globally activate this, there is probably no reason to change this.

@dereuromark do you think I should leave this as is in master for 0.2 since they are modifiable in 0.3 and would be considered a BC if merged into current release?

I would leave it as is since customizing it will be possible in 0.3

I agree with @ADmad

Ok, thanks for confirming guys! Closing then.


Change mac build target from deprecated to new

Signed-off-by: Cervenka Dusan<EMAIL_ADDRESS>Pull request
Choose Correct

[X] bug
[X] feature

Describe the pull request

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

OS:
eRPC Version:

Steps you didn't forgot to do

[ ] I checked if other PR isn't solving this issue.
[ ] I read Contribution details and did appropriate actions.
[ ] PR code is tested.
[ ] PR code is formatted.
[ ] Allow edits from maintainers pull request option is set (recommended).

Additional context

We will need this in future. But it looks like it is not working for now (so keeping it open):

Thank you for the effort!


Filter out types returned to only ComputationalTool and Dataset

Within the NIAID Data Ecosystem API, add a custom QueryBuilder to filter out any records where @type is not Dataset or ComputationalTool.  This will be the equivalent of running this query by default on every single query, before the user-specified query is run.
NOTE: we should ensure that all Software or SoftwareSourceCode types are converted to ComputationalTool within the individual crawling scripts.
Examples:
https://github.com/data2health/resource-discovery-api/blob/main/web/pipeline.py
https://github.com/biothings/mygene.info/blob/master/src/web/pipeline/build.py
https://docs.biothings.io/en/latest/tutorial/web.html

Other examples: https://github.com/SmartAPI/smartAPI/blob/0.10.x/src/pipeline.py


Add transaction info to the Block struct

To support https://github.com/0xPolygonMiden/miden-node/issues/371, we need to modify the Block struct. Specifically, we need to make sure that information about which transactions updated a specific account is contained within the block.
One way to do it is to add something like transactions field to the BlockAccountUpdate struct. Specifically, this struct could look like so:
pub struct BlockAccountUpdate {
    account_id: AccountId,
    new_state_hash: Digest,
    details: AccountUpdateDetails,
    transactions: Vec<TransactionId>,
}

The reason for using Vec to keep track of transactions is that an account could be updated multiple times within a block and we need to keep track of all relevant transactions.
Another approach is to refactor the Block struct more radically so that it looks something like this:
pub struct Block {
    header: BlockHeader,
    batches: Vec<TransactionBatch>,
    proof: ExecutionProof,
}

pub type TransactionBatch = Vec<VerifiedTransaction>;

pub struct VerifiedTransaction {
    id: TransactionId,
    account_update: TxAccountUpdate,
    input_notes: InputNotes<Nullifier>,
    output_notes: OutputNotes,
}

Here, VerifiedTransaction is basically the same as the ProvenTransaction but without the proof and block_ref fields.
The benefit of this approach is that we retain all publicly available info about the transactions which went into the block. The downside is that the block becomes "heavier" because we keep info about "ephemeral" transactions. I am not yet sure which approach is better.
Effect on the BlockHeader
Regardless of the approach taken, we need to make sure that the BlockHeader structs contains a commitment to the transaction info. Specifically, given a block we need to make sure that a set of transactions mentioned in the block is consistent with the information in the block header.
For the first approach, this could be accomplished by changing batch_root to tx_hash which would be computed as a sequential hash of (transaction_id, account_id) tuples:
tx_hash = hash(transaction_id_0, account_id_0, ..., transaction_id_n, account_id_n)

This way, we'd be able to confirm that:

No extra transactions were added added to BlockAccountUpdates and no transactions were omitted from them.
Transactions were mapped to the accounts correctly.

For the second approach, we'd also rename batch_root into tx_hash, but now we'd only need to hash transaction IDs:
tx_hash = hash(transaction_id_0, ..., transaction_id_n)

This is sufficient because the VerifiedTransaction struct contains enough info to re-compute transaction_id based on other account update info and note commitments.
One potentially tricky aspect here would be to derive the note tree from the set of verified transactions. But I think if we assume that the output notes are inserted into the note tree in the order in which they appear in the list of transactions, and account for notes which were both created and consumed in the same batch, it should be doable.

Closed by #734.


Bug: Prompt not working for required options in ZOD commands

When building a new command and using the new ZOD approach, I noticed that CLI doesn't prompt the user for required options, it just instantly throws an error.
Example: the first command is built with ZOD, the 2nd isn't. In both commands, environmentName is a required option.

aaaj this is a huge drawback. and a huge shame I did not notice it before 🤦♂
I say we need to fix it up properly before progressing with further usage of ZOD.
Thanks @milanholemans for finding this in an early stage 👍

I had a quick look at zod and I think we can go about it in two ways:

Extend each required field with .default(func) where func is our prompt for value when one is missing. This is easy but labor intensive and repetitive
Change the logic of zod parsing so that it catches parsing error due to missing required values, prompts for value, adds to args object and tries parsing again until it either succeeds or the user cancels it. This is not as efficient but allows us to implement the prompting logic in one place without bothering the schemas with it


chapter 2 spelling mistake fixed

There was a spelling mistake! I will contribute further more!!!

sook my dook


now scale instance made 2 times more instance

When I run command    now scale  https://mysite.now.sh 1 3,
it scaled  min: 2, max: 6.
However, in readme, it says that
when we run command like npx now scale  https://mysite.now.sh 2 15,
it scaled min: 2, max: 15.
Is the readme wrong?

Thank you so much for the effort you have put into this issue! 😊
However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now.
You can read more about our biggest release yet here: https://zeit.co/blog/now-2


#expect doesn't expect that there may be a sub-expression that has try on the right side of binary operator.

Description
Although we can't put try on the right side of ==, the right expression can contain a sub-expression that has try:
func nonThrowingFunc() -> Int { 0 }
func throwingFunc() throws -> Int { 0 }
func anotherNonThrowingFunc(_ integer: Int) -> Int { integer }

print(nonThrowingFunc() == try throwingFunc()) // ❌ error: 'try' cannot appear to the right of a non-assignment operator
print(nonThrowingFunc() == anotherNonThrowingFunc(try throwingFunc())) // ✅ OK

However, #expect seems not to expect that there may be a try sub-expression on the right side of ==:
import Testing

struct Foo: Equatable {
  init() {}
  init(_ integer: Int) {}
}

@Test func myTest() throws {
  #expect(try #require(Int("0")) == 0) // ✅ OK
  #expect((Foo() == Foo(try #require(Int("0")))) == true) // ✅ OK
  #expect(Foo() == Foo(try #require(Int("0")))) // ❌ error: call can throw, but it is executed in a non-throwing autoclosure
}

Expanded function named __checkBinaryOperation doesn't have an @autoclosure that throws.
Expected behavior
No error at compile time.
Actual behavior
Described above.
Steps to reproduce
Try to compile the code above.
swift-testing version/commit hash
Testing Library Version: 94 (arm64e-apple-macos13.0)
Swift & OS version (output of swift --version ; uname -a)
swift-driver version: 1.115 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.10 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx15.0
Darwin yockow.local 24.0.0 Darwin Kernel Version 24.0.0: Tue Sep 24 23:39:07 PDT 2024; root:xnu-11215.1.12~1/RELEASE_ARM64_T6000 arm64

From syntax alone, we cannot tell try is needed here.

Duplicate of #162

Oh hold on. We should be opting out here. I misread—reopening.

Tracked internally as rdar://138605320.


Cannot install vcpkg in Windows10

Gigabyte@DESKTOP-UC7PUJO MINGW64 /vcpkg (master)
$ bootstrap-vcpkg.bat
bash: bootstrap-vcpkg.bat: command not found

I cannot run this .bat in git bash, maybe I miss setting some configuration in environment variable?

Assuming they treat this similar to the Linux environment you need to prefix the call with ./ to signify the local directory as most UNIX environments don't add the cwd to the path. Whereas dos environments this is the standard! So try ./bootstrap-vcpkg.bat

Here's the relevant section of the docs.
On Linux you need to use ./boostrap-vcpkg.sh
To get started:

git clone https://github.com/Microsoft/vcpkg.git
cd vcpkg

PS> .\bootstrap-vcpkg.bat
Linux:~/$ ./bootstrap-vcpkg.sh


Added SourceLocation to inherited chunks \ tag helpers

Updated CompilationResult to support compilation failures from multiple
files.
Fixes #2321

Ties into Diagnostics changes - https://github.com/aspnet/Diagnostics/pull/123 and Razor changes - https://github.com/aspnet/Razor/pull/357. The error page from Helios already supports multiple error files.

:shipit:

:shipit:


cargo gets tuck at Resolving dependency graph... under some conditions

In my case that happens when adding the "actix" crate to an existing projects that is a Servo embedder (so it's not that easy to update some deps).
Here's the current Cargo.lock, and the updated Cargo.toml. The only change is the additional actix dependency.
Cargo_files.zip

cc @alexcrichton who knows the context we discussed on irc.

Thank you so much for the bug report! I am doing a lot of work on this kind of problem. I have added it to my list of things to try and solve. Anything you or @alexcrichton can add on the context and how to reproduce would be appreciated.

These are the Cargo files from https://github.com/fabricedesre/servonk
To reproduce, uncomment actix in the Cargo.toml and run cargo fetch.

testing with master I get
>MyProjects\cargo\target\debug\cargo fetch -Z no-index-update
error: failed to select a version for `serde_json`.
    ... required by package `skeptic v0.13.0`
    ... which is depended on by `actix v0.3.4`
    ... which is depended on by `actix_derive v0.1.0`
    ... which is depended on by `actix v0.4.2`
    ... which is depended on by `servonk v0.1.0 (file:///C:/Users/.../issues5182)`
versions that meet the requirements `^1.0.3` are: 1.0.11, 1.0.10, 1.0.9, 1.0.8, 1.0.7, 1.0.6, 1.0.5, 1.0.4, 1.0.3

all possible versions conflict with previously selected packages.

  previously selected package `serde_json v1.0.2`
    ... which is depended on by `script v0.0.1 (https://github.com/fabricedesre/servo?branch=gonk#063e5f3e)`
    ... which is depended on by `layout_thread v0.0.1 (https://github.com/fabricedesre/servo?branch=gonk#063e5f3e)`
    ... which is depended on by `libservo v0.0.1 (https://github.com/fabricedesre/servo?branch=gonk#063e5f3e)`
    ... which is depended on by `servonk v0.1.0 (file:///C:/Users/.../issues5182)`

failed to select a version for `serde_json` which could resolve this conflict

Looks like some of the recent changes stop the hang!

Indeed! I managed to update everything with a few back and forth... ie, removing actix, doing the serde_json update, and adding it back. Not ideal, but that will do for now :)


response.sendFile

If I use response.sendFile("/file") I get the following error:

[NODE] Error
[NODE]     at NotFoundError.HttpError [as constructor] (/app/src/http-error/HttpError.ts:19:22)
[NODE]     at new NotFoundError (/app/src/http-error/NotFoundError.ts:10:9)
[NODE]     at ExpressDriver.handleSuccess (/app/src/driver/express/ExpressDriver.ts:286:35)
[NODE]     at /app/src/RoutingControllers.ts:161:45
[NODE]     at propagateAslWrapper (/app/node_modules/async-listener/index.js:468:23)
[NODE]     at /app/node_modules/async-listener/glue.js:188:31
[NODE]     at /app/node_modules/async-listener/index.js:505:70
[NODE]     at /app/node_modules/async-listener/glue.js:188:31
[NODE]     at
[NODE] Error: Can't set headers after they are sent.
[NODE]     at SendStream.headersAlreadySent (/app/node_modules/send/index.js:402:13)
[NODE]     at SendStream.send (/app/node_modules/send/index.js:625:10)
[NODE]     at onstat (/app/node_modules/send/index.js:737:10)
[NODE]     at /app/node_modules/async-listener/glue.js:188:31
[NODE]     at FSReqWrap.oncomplete (fs.js:153:5)

The file exists and is readable

Try to use return response.sendFile("/file")

You have to wait for #286.

If I use this code
 public async getImage(@Res() response: express.Response, @Params() params) {
        try {
            let filePath = path.join(path.normalize(ImagesFolder), params.path);
            response.type("jpg").send();
        } catch (err) {

        }
    }

I get the error

[NODE] Error: Can't set headers after they are sent.
[NODE]     at validateHeader (_http_outgoing.js:489:11)
[NODE]     at ServerResponse.setHeader (_http_outgoing.js:496:3)
[NODE]     at ServerResponse.header (/app/node_modules/express/lib/response.js:730:10)
[NODE]     at ServerResponse.send (/app/node_modules/express/lib/response.js:170:12)
[NODE]     at ServerResponse.json (/app/node_modules/express/lib/response.js:256:15)
[NODE]     at ExpressDriver.handleError (/src/driver/express/ExpressDriver.ts:348:26)
[NODE]     at /src/RoutingControllers.ts:129:32
[NODE]     at propagateAslWrapper (/app/node_modules/async-listener/index.js:468:23)
[NODE]     at /app/node_modules/async-listener/glue.js:188:31
[NODE]     at proxyWrapper (/app/node_modules/async-listener/index.js:477:29)
[NODE]     at /app/node_modules/async-listener/index.js:505:70
[NODE]     at /app/node_modules/async-listener/glue.js:188:31

Is this also caused by the issue that gets fixed in #286?

Yes, routing-controllers is trying to send the response even if you already send it using res object.

Is there a ETA for this PR?

@NoNameProvided and @pleerock have to review this PR, then it will be released with other merged PRs.
For now you can compile the npm package by yourself.

@19majkel94 can it be closed now?

I've updated to<EMAIL_ADDRESS> and this is my code:
 @Get('/File/:name')
  async GetFile(@Req() request: Request, @Res() response: Response) {
    let filePath = path.join(__dirname, '../public', request.params.name);
    console.log('File: ', filePath);
    return response.sendFile(filePath);
  }

I get error at NotFoundError.HttpError [as constructor]  ...

You need to return response, not void, which is the result of calling sendFile.
    sendFile(path: string): void;
    sendFile(path: string, options: any): void;
    sendFile(path: string, fn: Errback): void;
    sendFile(path: string, options: any, fn: Errback): void;

so how can solve it

@Get('/File/:name')
async GetFile(@Req() request: Request, @Res() response: Response) {
    let filePath = path.join(__dirname, '../public', request.params.name);
    console.log('File: ', filePath);
    response.sendFile(filePath);
    return response;
}

@19majkel94 I use your code,but it do not work, the framework still try to callback my CustomErrorHandler, which is implements ExpressErrorMiddlewareInterface。so I use Response.headersSent in my CustomErrorHandler to judge whether the Response has been sent. the code look like this;
`@Middleware({ type: 'after' })
export class CustomErrorHandler implements ExpressErrorMiddlewareInterface {
error(error: any, req: Request, res: Response) {
if (res.headersSent) return;
res.status(500);
res.json({
status: 'fail',
error: error.message
});
}
}
@Middleware({ type: 'after' })
export class CustomNotFoundHandler implements ExpressMiddlewareInterface {
use(req: Request, res: Response) {
if (res.headersSent) return;
res.status(404);
res.json({
status: 'fail',
error: 'Not Found'
});
}
}`

@19majkel94  I use your code,but it do not work, the framework still try to callback my CustomErrorHandler, which is implements ExpressErrorMiddlewareInterface。so I use Response.headersSent in my CustomErrorHandler to judge whether the Response has been sent. the code look like this;
`export class CustomErrorHandler implements ExpressErrorMiddlewareInterface {
error(error: any, req: Request, res: Response) {
// if (res.statusCode === 200) return;
if (res.headersSent) return;
res.status(500);
res.json({
status: 'fail',
error: error.message
});
}
}
@Middleware({ type: 'after' })
export class CustomNotFoundHandler implements ExpressMiddlewareInterface {
use(req: Request, res: Response) {
// if (res.statusCode === 200) return;
if (res.headersSent) return;
res.status(404);
res.json({
status: 'fail',
error: 'Not Found'
});
}
}
`

so how can solve it

I don't know what "it" is, please open new issue and describe your problem with code samples.

@aasailan sendFile basically opens a stream. You should await on it and return response only then.
@Controller()
export class ServeSPAController {

  @Get('*')
  public async serveSpa (@Res() res: Response): Promise<any> {
    const fileName = path.resolve(__dirname, '../../../..', staticPath, 'index.html')
    await promisify<string, void>(res.sendFile.bind(res))(fileName)
    return res
  }
}

It would be better to promisify the prototype of Response but I'm not sure how to do that in this case

@keenondrums Right, I was just showing and example of returning response object, not a working solution 😉
For cases like serving spa's index.html it's better to use serve-static rather than custom routes with sendFile.

@19majkel94 you can't use only serve static. You have to match every route besides your api routes to index html. I combine them to serve other static files like js with static middleware and add serveSpa route to serve index.html

sendFile is not for serving SPA index.html. If you really can't use webpack-dev-server/nginx, please don't reinvent the wheel:
https://github.com/bripkens/connect-history-api-fallback/tree/master/examples/static-files-and-index-rewrite
Just register the history with static after create/use ExpressServer call, so all not matched routes can be handled.

@19majkel94 works lie a charmm. Thnx for the info!

#376 solved the problem and we have to return response (not return ;)to avoid the double return problem: ' Can't set headers after they are sent '.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Robots.txt everytime is overwritten

Details

Project URL: http://lectureswww.readthedocs.io/robots.txt

Expected Result
I want to add my own robots.txt file through html_extra_path
Actual Result
I get always:
User-agent: *
Disallow: /builds/

Closing this one in favor of #3161


istioctl collateral --bash -o ~/completions cmd fails

for 'Windows Subsystem for Linux' the cmd 'istioctl collateral --bash -o ~/completions' fails with error
'Error: unable to output bash completion file: open /home/tim/completions/istioctl.bash: no such file or directory'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 68b5d00d-529b-a8be-47bf-773c967f0e72
Version Independent ID: 0cf044ef-b26f-a8fa-213f-1e3fffaf53d6
Content: Install Istio in Azure Kubernetes Service (AKS)
Content Source: articles/aks/istio-install.md
Service: container-service
GitHub Login: @paulbouwer
Microsoft Alias: pabouwer

Thanks for the feedback! We are currently investigating and will update you shortly.

@paulbouwer can you take a look at this?

As this PR has merged, @MicahMcKittrick-MSFT #please-close


Y24-275 - As PM (Adrianne L) I would like to 3 controls to be introduced when creating the RVI Cherrypick plate so that we can ensure the quality of the pipeline.

User story
As PM (Adrianne L) I would like to 3 controls to be introduced when creating the RVI Cherrypick plate so that we can ensure the quality of the pipeline.
Who are the primary contacts for this story
AL ST
Who is the nominated tester for UAT
TBD
Acceptance criteria
Are there specific controls (positive or negative) that need be added?
Will this be in random location or is there a fixed location/s ?
To be considered successful the solution must allow:

[ ] add a list of acceptance criteria here
[ ] ...

Additional context
Add any other context or screenshots about the feature request here.

Further email from Ya-Lin:

After liaising with SSR, we believe the easiest way to achieve our goal is adding a template to the “Control Plate” menu for CP submission under Automatic layout (see pic attached) to automatically assign controls to H10, H11, and H12 wells.
Please kindly let us know whether this sounds like a plan and if yes what the possible timeline of implementing this change would be.

I think this is correct, that all we need to do is to add a new entry into the Control Plate drop down. It looks like it automatically adds the controls onto each destination plate, and randomises the location.

Testing SS cherrypicking using:

a 96-well stock plate
Plate Template 'H12 empty'
Control Plate 'Heron A1+ H12-'

Typical layout is shown below.

Control locations are 'randomised' on the first (full) destination plate
They are added at the end of the second (partially filled) plate
They can be in the same row
In 10 submissions, they did not appear in the same column (need to check in code if this is enforced)
H12 was left empty as per template

Looking into whether we can use the Plate Template dropdown to put controls in fixed positions.
TL;DR
Looks to me like Plate Templates can only be used to leave wells empty - not to populate wells with specific samples.
Further information
See initialize_already_occupied_wells_from and add_any_wells_from_template_or_partial in CherrypickTask::PickTarget::Base (pick_target.rb).
A Plate Template is a Labware with sti_type PlateTemplate. Most existing Plate Templates in the UAT environment have a small number of wells, which contain no aliquots or samples e.g. H12 empty has one well, H12, which does not contain an aliquot or sample. There is at least one Plate Template in the UAT environment which has samples in it (QcReportersV1) - not sure what this is used for. It does not transfer the samples across when cherrypicking, it just leaves them empty.

Options for meeting the RVI cherrypicking requirement:

Modify existing control randomisation behaviour to disallow multiple controls in the same column (would affect other users of cherrypicking, but that might not be a problem).
Modify control randomisation to include column constraint - but as an option, so as not to change behaviour for other users.
Add a way to add controls into fixed locations.

Answers to above questions from Ya-Lin (email):

Both ways you’ve proposed sound good to me. There’s no preference from the project requirement. Which one PSD can get done quicker would be our choice I believe 😊

Regarding the partial plate, as currently we only put full plates into pipeline, this shouldn’t cause any concern. When partial plates are to be picked, we don’t usually add controls yet. Instead, we’ll set up another cherrypicking to combine partial plates into a full plate and add the controls at this step before putting the plate into pipeline.

Output - https://github.com/sanger/sequencescape/issues/4333


[Wrangler] Add back partial v1beta1 apiext CRD support in order to support upgrades

Wrangler CRDs should be able to generate a v1beta1 version of themselves for clean upgrades from Kubernetes <= 1.15.x clusters.
v1beta1 to v1 apiext PR: https://github.com/rancher/wrangler/pull/154
Solution will likely include a single method for the CRD object that creates a v1beta1 CRD.

Support has been added since https://github.com/rancher/wrangler/pull/172 was merged.


Use more specific class names when adding to host element

Summary
In some components, class names are added to the host element. This can lead to problems as some of the class names are quite generic eg "icon", "dark", "light", "link". If consumers have styles in their global css such as
.icon{
  width: 50px;
height: 50px;
}

Then that styling is applied to our components.
💬 Description
The class names applied on the host elements for our components should be more specific eg "ic-icon", "ic-dark", "ic-light", "ic-link" etc
a list of components affected (this should be validated)

ic-checkbox-group
ic-classification-banner
ic-data-entity
ic-link
ic-navigation-button
ic-popover-menu
ic-radio-group
ic-radio-option
ic-text-field
ic-tooltip

💰 Use value
Would make consumers lives easier as our components would not change their styling if they have clashing class names
📝 Acceptance Criteria
Given
When
Then

May have breaking changes


x/tools/gopls: watch replace targets

What version of Go are you using (go version)?

$ go version
go version go1.14.7 darwin/amd64

# gopls version
golang.org/x/tools/gopls 0.4.4
<EMAIL_ADDRESS>h1:8djGYsaZ0ByP0vaXg4T+mnyfDcHpWKSZ+tpQSGv9ahk=

VS Code version v1.47.3
vscode-go v0.16.1
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/segev/Library/Caches/go-build"
GOENV="/Users/segev/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/segev/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.7/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.7/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b_/c6yh0ksn63d1yy192x2p9f4c0000gn/T/go-build425202633=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Open VS Code with vscode-go installed and gopls enabled: code foo bar
Add replace github.com/segevfiner/bar => ../bar to module foo's go.mod.
Add to module foo as main.go:package main

func main() {

}

Add to module bar as bar1.go:package bar

func Bar1() {

}

Try to add foo.Bar1() to foo's main.go, it would work and also auto complete it. (Might need to manually add the import statement)
Add to module bar as bar2.go:package bar

func Bar2() {

}

Try to add foo.Bar2() to foo's main.go, it would not autocomplete and will fail to compile until you restart the language server.

What did you expect to see?
Adding new files to replaced packages should work seamlessly, auto-completing, compiling correctly, without requiring a restart of the language server.
What did you see instead?
It fails to auto-complete, compile etc. (While working correctly with go build) until you restart the language server.

This is actually a known issue which should be resolved at master (https://golang.org/cl/245327).
If you're interested, you can give it a try by downloading master (`GO111MODULE=on go get golang.org/x/tools/gopls@master golang.org/x/tools@master).

Trying with (Installed using the provided command):
golang.org/x/tools/gopls master
<EMAIL_ADDRESS>h1:mOy1nNJGN9EIh6lz32XSu+nRN/eQCz6pUy3bNyvpGBc=

It's even worse, it's now not finding the module replaced module at all, complaining with:
could not import github.com/segevfiner/bar (no package for import github.com/segevfiner/bar)

While go build works correctly.

gopls -rpc.trace -v check foo.go

2020/08/12 18:46:50 Info:2020/08/12 18:46:50 Build info----------
golang.org/x/tools/gopls master
<EMAIL_ADDRESS>h1:mOy1nNJGN9EIh6lz32XSu+nRN/eQCz6pUy3bNyvpGBc=
<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
<EMAIL_ADDRESS>h1:/QaMHBdZ26BB3SSst0Iwl10Epc+xhTquomWX0oZEB6w=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
<EMAIL_ADDRESS>h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=
<EMAIL_ADDRESS>h1:8Kg+JssU1jBZs8GIrL5pl4nVyaqyyhdmHAR4D1zGErg=
<EMAIL_ADDRESS>h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
<EMAIL_ADDRESS>h1:UoveltGrhghAA7ePc+e+QYDHXrBps2PqFZiHkGR/xK8=
<EMAIL_ADDRESS>h1:gi7cb8HTDZ6q8VqsUpkdoFi3vxwHMneQ6+Q5Ap5hjPE=
<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=
Go info
go version go1.14.7 darwin/amd64
2020/08/12 18:46:50 Info:2020/08/12 18:46:50 go env for /Users/segev/junk/gopls-issue2/foo
(root /Users/segev/junk/gopls-issue2/foo)
(valid build configuration = true)
(build flags: [])
GOMOD=/Users/segev/junk/gopls-issue2/foo/go.mod
GONOPROXY=github.com/OceanCodes
GOPRIVATE=github.com/OceanCodes
GOPROXY=https://proxy.golang.org,direct
GOROOT=/usr/local/Cellar/go/1.14.7/libexec
GO111MODULE=
GOMODCACHE=
GOFLAGS=
GOSUMDB=sum.golang.org
GOCACHE=/Users/segev/Library/Caches/go-build
GONOSUMDB=github.com/OceanCodes
GOPATH=/Users/segev/go
GOINSECURE=
2020/08/12 18:46:50 Info:2020/08/12 18:46:50 go/packages.Load
snapshot=0
directory=/Users/segev/junk/gopls-issue2/foo
query=[./... builtin]
packages=2

Log

[Trace - 18:52:57.669 PM] Sending request 'initialize - (0)'.
Params: {"processId":75662,"clientInfo":{"name":"vscode","version":"1.47.3"},"rootPath":"/Users/segev/junk/gopls-issue2","rootUri":"file:///Users/segev/junk/gopls-issue2","capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","rename","delete"],"failureHandling":"textOnlyTransactional"},"didChangeConfiguration":{"dynamicRegistration":true},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"executeCommand":{"dynamicRegistration":true},"configuration":true,"workspaceFolders":true},"textDocument":{"publishDiagnostics":{"relatedInformation":true,"versionSupport":false,"tagSupport":{"valueSet":[1,2]}},"synchronization":{"dynamicRegistration":true,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":true,"contextSupport":true,"completionItem":{"snippetSupport":true,"commitCharactersSupport":true,"documentationFormat":["markdown","plaintext"],"deprecatedSupport":true,"preselectSupport":true,"tagSupport":{"valueSet":[1]}},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]}},"hover":{"dynamicRegistration":true,"contentFormat":["markdown","plaintext"]},"signatureHelp":{"dynamicRegistration":true,"signatureInformation":{"documentationFormat":["markdown","plaintext"],"parameterInformation":{"labelOffsetSupport":true}},"contextSupport":true},"definition":{"dynamicRegistration":true,"linkSupport":true},"references":{"dynamicRegistration":true},"documentHighlight":{"dynamicRegistration":true},"documentSymbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"hierarchicalDocumentSymbolSupport":true},"codeAction":{"dynamicRegistration":true,"isPreferredSupport":true,"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"codeLens":{"dynamicRegistration":true},"formatting":{"dynamicRegistration":true},"rangeFormatting":{"dynamicRegistration":true},"onTypeFormatting":{"dynamicRegistration":true},"rename":{"dynamicRegistration":true,"prepareSupport":true},"documentLink":{"dynamicRegistration":true,"tooltipSupport":true},"typeDefinition":{"dynamicRegistration":true,"linkSupport":true},"implementation":{"dynamicRegistration":true,"linkSupport":true},"colorProvider":{"dynamicRegistration":true},"foldingRange":{"dynamicRegistration":true,"rangeLimit":5000,"lineFoldingOnly":true},"declaration":{"dynamicRegistration":true,"linkSupport":true},"selectionRange":{"dynamicRegistration":true}},"window":{"workDoneProgress":true}},"initializationOptions":{},"trace":"off","workspaceFolders":[{"uri":"file:///Users/segev/junk/gopls-issue2","name":"gopls-issue2"}]}
[Trace - 18:52:57.685 PM] Received response 'initialize - (0)' in 16ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["quickfix","refactor.extract","refactor.rewrite","source.fixAll","source.organizeImports"]},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":""},"renameProvider":{"prepareProvider":true},"foldingRangeProvider":true,"executeCommandProvider":{"commands":["generate","fill_struct","regenerate_cgo","test","tidy","undeclared_name","upgrade_dependency","vendor","extract_variable","extract_function","gc_details"]},"callHierarchyProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"Build info\n----------\ngolang.org/x/tools/gopls master\n<EMAIL_ADDRESS>h1:mOy1nNJGN9EIh6lz32XSu+nRN/eQCz6pUy3bNyvpGBc=\n<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=\n<EMAIL_ADDRESS>h1:/QaMHBdZ26BB3SSst0Iwl10Epc+xhTquomWX0oZEB6w=\n<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=\n<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=\n<EMAIL_ADDRESS>h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=\n<EMAIL_ADDRESS>h1:8Kg+JssU1jBZs8GIrL5pl4nVyaqyyhdmHAR4D1zGErg=\n<EMAIL_ADDRESS>h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=\n<EMAIL_ADDRESS>h1:UoveltGrhghAA7ePc+e+QYDHXrBps2PqFZiHkGR/xK8=\n<EMAIL_ADDRESS>h1:gi7cb8HTDZ6q8VqsUpkdoFi3vxwHMneQ6+Q5Ap5hjPE=\n<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=\n\nGo info\n-------\ngo version go1.14.7 darwin/amd64\n\n"}}
[Trace - 18:52:57.718 PM] Sending notification 'initialized'.
Params: {}
[Trace - 18:52:57.719 PM] Sending notification 'textDocument/didOpen'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go","languageId":"go","version":1,"text":"package main\n\nimport "github.com/segevfiner/bar"\n\nfunc main() {\n\tbar.Bar1()\n\tbar.Bar2()\n}\n"}}
[Trace - 18:52:57.738 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:57 Build info\n----------\ngolang.org/x/tools/gopls master\n<EMAIL_ADDRESS>h1:mOy1nNJGN9EIh6lz32XSu+nRN/eQCz6pUy3bNyvpGBc=\n<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=\n<EMAIL_ADDRESS>h1:/QaMHBdZ26BB3SSst0Iwl10Epc+xhTquomWX0oZEB6w=\n<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=\n<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=\n<EMAIL_ADDRESS>h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=\n<EMAIL_ADDRESS>h1:8Kg+JssU1jBZs8GIrL5pl4nVyaqyyhdmHAR4D1zGErg=\n<EMAIL_ADDRESS>h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=\n<EMAIL_ADDRESS>h1:UoveltGrhghAA7ePc+e+QYDHXrBps2PqFZiHkGR/xK8=\n<EMAIL_ADDRESS>h1:gi7cb8HTDZ6q8VqsUpkdoFi3vxwHMneQ6+Q5Ap5hjPE=\n<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=\n\nGo info\n-------\ngo version go1.14.7 darwin/amd64\n\n\n"}
[Trace - 18:52:57.739 PM] Received request 'workspace/configuration - (1)'.
Params: {"items":[{"scopeUri":"file:///Users/segev/junk/gopls-issue2","section":"gopls"},{"scopeUri":"file:///Users/segev/junk/gopls-issue2","section":"gopls-gopls-issue2"}]}
[Info  - 6:52:57 PM] 2020/08/12 18:52:57 Build info
golang.org/x/tools/gopls master
<EMAIL_ADDRESS>h1:mOy1nNJGN9EIh6lz32XSu+nRN/eQCz6pUy3bNyvpGBc=
<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
<EMAIL_ADDRESS>h1:/QaMHBdZ26BB3SSst0Iwl10Epc+xhTquomWX0oZEB6w=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
<EMAIL_ADDRESS>h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=
<EMAIL_ADDRESS>h1:8Kg+JssU1jBZs8GIrL5pl4nVyaqyyhdmHAR4D1zGErg=
<EMAIL_ADDRESS>h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
<EMAIL_ADDRESS>h1:UoveltGrhghAA7ePc+e+QYDHXrBps2PqFZiHkGR/xK8=
<EMAIL_ADDRESS>h1:gi7cb8HTDZ6q8VqsUpkdoFi3vxwHMneQ6+Q5Ap5hjPE=
<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=
Go info
go version go1.14.7 darwin/amd64
[Trace - 18:52:57.768 PM] Sending request 'textDocument/documentSymbol - (1)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:57.768 PM] Sending request 'textDocument/documentLink - (2)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:57.794 PM] Sending response 'workspace/configuration - (1)' in 54ms.
Result: [null,null]
[Trace - 18:52:57.820 PM] Sending notification '$/cancelRequest'.
Params: {"id":1}
[Trace - 18:52:57.820 PM] Sending request 'textDocument/documentSymbol - (3)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:57.836 PM] Received request 'client/registerCapability - (2)'.
Params: {"registrations":[{"id":"workspace/didChangeWatchedFiles-0","method":"workspace/didChangeWatchedFiles","registerOptions":{"watchers":[{"globPattern":"file:///Users/segev/junk/gopls-issue2/**/*.{go,mod,sum}","kind":7}]}}]}
[Trace - 18:52:57.836 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:57 go env for /Users/segev/junk/gopls-issue2\n(root /Users/segev/junk/gopls-issue2)\n(valid build configuration = false)\n(build flags: [])\nGOFLAGS=\nGOINSECURE=\nGOPRIVATE=github.com/OceanCodes\nGOCACHE=/Users/segev/Library/Caches/go-build\nGOROOT=/usr/local/Cellar/go/1.14.7/libexec\nGO111MODULE=\nGOMODCACHE=\nGONOPROXY=github.com/OceanCodes\nGOMOD=\nGOPROXY=https://proxy.golang.org,direct\nGONOSUMDB=github.com/OceanCodes\nGOPATH=/Users/segev/go\nGOSUMDB=sum.golang.org\n\n"}
[Trace - 18:52:57.877 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:57 go/packages.Load\n\tsnapshot=0\n\tdirectory=/Users/segev/junk/gopls-issue2\n\tquery=[./ builtin]\n\tpackages=2\n"}
[Trace - 18:52:57.917 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:57 go/packages.Load\n\tsnapshot=0\n\tdirectory=/Users/segev/junk/gopls-issue2\n\tquery=[./]\n\tpackages=1\n"}
[Trace - 18:52:57.969 PM] Sending response 'client/registerCapability - (2)' in 132ms.
Result:
[Trace - 18:52:57.969 PM] Received request 'client/registerCapability - (3)'.
Params: {"registrations":[{"id":"workspace/didChangeConfiguration","method":"workspace/didChangeConfiguration"},{"id":"workspace/didChangeWorkspaceFolders","method":"workspace/didChangeWorkspaceFolders"}]}
[Info  - 6:52:57 PM] 2020/08/12 18:52:57 go env for /Users/segev/junk/gopls-issue2
(root /Users/segev/junk/gopls-issue2)
(valid build configuration = false)
(build flags: [])
GOFLAGS=
GOINSECURE=
GOPRIVATE=github.com/OceanCodes
GOCACHE=/Users/segev/Library/Caches/go-build
GOROOT=/usr/local/Cellar/go/1.14.7/libexec
GO111MODULE=
GOMODCACHE=
GONOPROXY=github.com/OceanCodes
GOMOD=
GOPROXY=https://proxy.golang.org,direct
GONOSUMDB=github.com/OceanCodes
GOPATH=/Users/segev/go
GOSUMDB=sum.golang.org
[Trace - 18:52:57.972 PM] Sending notification '$/cancelRequest'.
Params: {"id":3}
[Trace - 18:52:57.972 PM] Sending request 'textDocument/documentSymbol - (4)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:57.973 PM] Sending request 'textDocument/foldingRange - (5)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Info  - 6:52:57 PM] 2020/08/12 18:52:57 go/packages.Load
snapshot=0
directory=/Users/segev/junk/gopls-issue2
query=[./ builtin]
packages=2
[Info  - 6:52:57 PM] 2020/08/12 18:52:57 go/packages.Load
snapshot=0
directory=/Users/segev/junk/gopls-issue2
query=[./]
packages=1
[Trace - 18:52:57.987 PM] Sending response 'client/registerCapability - (3)' in 17ms.
Result:
[Error - Received] 18:52:57.988 PM #1 JSON RPC cancelled
[Trace - 18:52:58.007 PM] Sending request 'textDocument/codeLens - (6)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:58.041 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:58 go/packages.Load\n\tsnapshot=1\n\tdirectory=/Users/segev/junk/gopls-issue2\n\tquery=[./]\n\tpackages=1\n"}
[Info  - 6:52:58 PM] 2020/08/12 18:52:58 go/packages.Load
snapshot=1
directory=/Users/segev/junk/gopls-issue2
query=[./]
packages=1
[Trace - 18:52:58.167 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:58 go/packages.Load\n\tsnapshot=1\n\tpackage_path="command-line-arguments"\n\tfiles=[/Users/segev/junk/gopls-issue2/foo/main.go]\n"}
[Trace - 18:52:58.167 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:58 go/packages.Load\n\tsnapshot=1\n\tdirectory=/Users/segev/junk/gopls-issue2\n\tquery=[file=/Users/segev/junk/gopls-issue2/foo/main.go]\n\tpackages=1\n"}
[Info  - 6:52:58 PM] 2020/08/12 18:52:58 go/packages.Load
snapshot=1
package_path="command-line-arguments"
files=[/Users/segev/junk/gopls-issue2/foo/main.go]
[Trace - 18:52:58.167 PM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2020/08/12 18:52:58 no dep handle: no metadata for github.com/segevfiner/bar\n\tpackage="github.com/segevfiner/bar"\n"}
[Info  - 6:52:58 PM] 2020/08/12 18:52:58 go/packages.Load
snapshot=1
directory=/Users/segev/junk/gopls-issue2
query=[file=/Users/segev/junk/gopls-issue2/foo/main.go]
packages=1
[Error - 6:52:58 PM] 2020/08/12 18:52:58 no dep handle: no metadata for github.com/segevfiner/bar
package="github.com/segevfiner/bar"
[Trace - 18:52:58.168 PM] Received response 'textDocument/documentLink - (2)' in 399ms.
Result: [{"range":{"start":{"line":2,"character":8},"end":{"line":2,"character":33}},"target":"https://pkg.go.dev/github.com/segevfiner/bar"}]
[Error - Received] 18:52:58.168 PM #3 JSON RPC cancelled
[Trace - 18:52:58.169 PM] Received response 'textDocument/documentSymbol - (4)' in 196ms.
Result: [{"name":"main","detail":"()","kind":12,"range":{"start":{"line":4,"character":0},"end":{"line":7,"character":1}},"selectionRange":{"start":{"line":4,"character":5},"end":{"line":4,"character":9}}}]
[Trace - 18:52:58.169 PM] Received response 'textDocument/foldingRange - (5)' in 195ms.
Result: [{"startLine":4,"startCharacter":13,"endLine":6,"endCharacter":11}]
[Trace - 18:52:58.169 PM] Received response 'textDocument/codeLens - (6)' in 161ms.
Result: null
[Trace - 18:52:58.206 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:58 go/packages.Load\n\tsnapshot=1\n\tpackage_path="command-line-arguments"\n\tfiles=[/Users/segev/junk/gopls-issue2/foo/main.go]\n"}
[Trace - 18:52:58.206 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/08/12 18:52:58 go/packages.Load\n\tsnapshot=1\n\tdirectory=/Users/segev/junk/gopls-issue2\n\tquery=[file=/Users/segev/junk/gopls-issue2/foo/main.go]\n\tpackages=1\n"}
[Trace - 18:52:58.207 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go","version":1,"diagnostics":[{"range":{"start":{"line":2,"character":7},"end":{"line":2,"character":34}},"severity":1,"source":"compiler","message":"could not import github.com/segevfiner/bar (no package for import github.com/segevfiner/bar)"}]}
[Info  - 6:52:58 PM] 2020/08/12 18:52:58 go/packages.Load
snapshot=1
package_path="command-line-arguments"
files=[/Users/segev/junk/gopls-issue2/foo/main.go]
[Info  - 6:52:58 PM] 2020/08/12 18:52:58 go/packages.Load
snapshot=1
directory=/Users/segev/junk/gopls-issue2
query=[file=/Users/segev/junk/gopls-issue2/foo/main.go]
packages=1
[Trace - 18:52:59.448 PM] Sending request 'textDocument/documentSymbol - (7)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:59.448 PM] Received response 'textDocument/documentSymbol - (7)' in 0ms.
Result: [{"name":"main","detail":"()","kind":12,"range":{"start":{"line":4,"character":0},"end":{"line":7,"character":1}},"selectionRange":{"start":{"line":4,"character":5},"end":{"line":4,"character":9}}}]
[Trace - 18:52:59.495 PM] Sending request 'textDocument/documentLink - (8)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:59.495 PM] Received response 'textDocument/documentLink - (8)' in 0ms.
Result: [{"range":{"start":{"line":2,"character":8},"end":{"line":2,"character":33}},"target":"https://pkg.go.dev/github.com/segevfiner/bar"}]
[Trace - 18:52:59.701 PM] Sending request 'textDocument/codeLens - (9)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:59.701 PM] Received response 'textDocument/codeLens - (9)' in 0ms.
Result: null
[Trace - 18:52:59.703 PM] Sending request 'textDocument/codeLens - (10)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:59.703 PM] Received response 'textDocument/codeLens - (10)' in 0ms.
Result: null
[Trace - 18:52:59.707 PM] Sending request 'textDocument/codeLens - (11)'.
Params: {"textDocument":{"uri":"file:///Users/segev/junk/gopls-issue2/foo/main.go"}}
[Trace - 18:52:59.707 PM] Received response 'textDocument/codeLens - (11)' in 0ms.
Result: null

It looks like you're opening the /Users/segev/junk/gopls-issue2 folder as your workspace root, but the go.mod file is contained in /Users/segev/junk/gopls-issue2/foo. gopls at master still expects your module root to be the root of the workspace.

Oh wait... Dammit VS Code opened the folder instead of the workspace file in it... (Maybe I forgot to save the workspace file)
It looks like the problem still persists now that I opened the proejct under a workspace correctly.

To clarify, how are you adding the replace to your module? I'm not seeing any edits to the module in your log, and if you're doing it in a different editor, you may have actually picked up a file watching bug that was just fixed by https://golang.org/cl/247684 (it's not limited to Windows-specific, even though the CL title says so). I would suggest upgrading to the latest master as of a few minutes ago (GO111MODULE=on go get golang.org/x/tools/gopls@master golang.org/x/tools@master) - sorry about the inconvenience!

In that case, I already had the replace in, and just added a file with a new function to the replaced bar module.
Will try it later.

Thanks for the clarification. We can certainly add a regression test for that case.

Still happening with:
golang.org/x/tools/gopls master
<EMAIL_ADDRESS>h1:IFIrVpsHUpQrihC1kLyMEOjP71pIxfSzKBFR7Qj5Nx4=


Fix partial not being found with different inflector

I tried installing solid_errors on a spanish language project, it has inflection rules like:
ActiveSupport::Inflector.inflections do |inflect|
  inflect.plural /([aeiou])([A-Z]|_|$)/, '\1s\2'
  inflect.plural /([rlnd])([A-Z]|_|$)/, '\1es\2'
  inflect.plural /([aeiou])([A-Z]|_|$)([a-z]+)([rlnd])($)/, '\1s\2\3\4es\5'
  inflect.plural /([rlnd])([A-Z]|_|$)([a-z]+)([aeiou])($)/, '\1es\2\3\4s\5'
end

This causes the render of occurrences to look for the partial under the solid_errores path
This PR uses the full version of the render method

Released version 0.4.3 now with this improvement

Released version 0.4.3 now with this improvement

thanks for the quick release @fractaledmind