Remove EOL 18.09

After modifying the maintenance cycle, 18.09 should have 7 months of maintenance time, and its actual release date is November 2018.
Docker maintainers try to have an overlap with the "next" release for a month or so; to give people time to upgrade to the next release, and to know that there's no major regressions in the next release that could be a blocker for people to upgrade.
18.09.9 will likely be the last patch release for 18.09.x, after which it will reach EOL.

I agree, thanks for the PR!
Just to confirm, @thaJeztah this is accurate, right? We're not likely doing another 18.09.x?

The above is what I asked him before :smile:
Thank you  @thaJeztah

Hah, oops! :sweat_smile: :heart:
I also forgot that https://github.com/docker-library/official-images/pull/6580 hadn't even been opened yet, let alone merged, so I've got that build test running now. :sweat_smile:

It's a bit fast to remove immediately, but guess it doesn't hurt; so w.r.t. maintenance cycle and the magical "7 months";

releases are now every 6(ish) month(ish)
one month overlap between the new and previous release (*)
so, combined: 7 months

The "one month" overlap is a bit flexible, so perhaps better to describe the goal (using 18.09 and 19.03 as example here);

Do a new release (e.g. 19.03.0)
Give users a one month window to upgrade from the previous release (18.09.x) to the new one (19.03.0). The new release should® be all bright and shiny and unicorns 🦄 , and good to install at .0, but there might be some teething problems or regressions in (corner) cases that we didn't catch in testing, or some issues that weren't critical enough to delay the GA release, so some users might wait for the first .1 patch release
The "one month" is based on our frequency of doing patch releases, which is on a monthly base, so that one month effectively means; when the first (.1) patch release of the new release arrives.
Continue patching the previous release as usual (although we may be patching more selectively). The assumption here is that users won't upgrade to the 19.03.1 patch release on day one, and still want their existing 18.09.x install to be running smoothly while they prepare for upgrading (at least critical and security issues patched).
Patch some bugs in 19.03, watch for reports of regressions "in the wild", do a 19.03.1 release, and declare 18.09.x EOL

Now, the above is in the ideal situation. Reality doesn't always match that and, for example, when we released 19.03.0, we were finalizing a fix for an issue that was reported publicly, but turned out to be a security issue, so we had to do security releases (18.09.8 19.03.1)
Security releases should only contain the fix to patch the security issue at hand to minimise the risk of installing the security fix; including any other changes can increase the risk of regressions, which can lead to users delaying installing the fix. So 19.03.1 only had a fix for the security issue, but could still have other regressions since 18.09.x that may prevent users to upgrade to 19.03. Those (at least the most important ones) have been addressed in 19.03.2, so all users should now be able to upgrade to 19.03 and we can EOL 18.09.
I think we should be good here, but that said; it might be good to wait a short time (a week? slightly longer) to remove the previous release; we're all human (except for @GordonTheTurtle 🐢), so a hot fix could always be possible in the first few days after a release 😅

Thank you for your detailed explanation @thaJeztah :+1:
Maybe I am too anxious to upgrade to the new version as soon as possible. I will be more rigorous in this case, in the future.
In my actual situation, I usually perform continuous functional testing after the new version is released. Most nodes will be updated after verification.
However, there are a few nodes that are still on the 18.09.x version. As you know, maintaining multiple versions is not a good thing for consistency and maintenance costs. For these nodes, I can only upgrade it to 19.03 after 18.09.x EOL. :worried:
After the last discussion with you, I have been waiting for the release of 18.09.9. :smile: But maybe I didn’t understand your last reply so thoroughly.

Totally fair (as usual), thanks @thaJeztah :heart:
We'll wait to push this PR up to https://github.com/docker-library/official-images until next week so it's easier to revert and stays in the "Supported" list on the Hub.

Thanks!

... like maybe https://github.com/containerd/containerd/releases/tag/v1.2.9 for the gRPC CVE? :sweat_smile: :grimacing:

Quick search, see some related fixes https://github.com/moby/moby/pull/39798
and backport for 19.03 https://github.com/docker/engine/pull/340

... like maybe https://github.com/containerd/containerd/releases/tag/v1.2.9 for the gRPC CVE? 😅

The CVE isn't nice, but for containerd it's not a critical issue, because (at least in a standard setup) it's only exposing its gRPC API through a local socket


[animations] OpenContainer - Close using SliverAppBar's onStretchTrigger

I am trying to close the Animations' OpenContainer using the SliverAppBar's onStretchTrigger. This throws an exception.
Steps to Reproduce

import 'package:animations/animations.dart';

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: Scaffold(
        appBar: AppBar(),
        body: Padding(
          padding: const EdgeInsets.all(8.0),
          child: Column(
            crossAxisAlignment: CrossAxisAlignment.stretch,
            children: [
              OpenContainer(
                closedBuilder: (context, _) => Padding(
                  padding: const EdgeInsets.all(8.0),
                  child: Text('Container'),
                ),
                openBuilder: (context, _) => ContainerPage(),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

class ContainerPage extends StatelessWidget {
  const ContainerPage({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return CustomScrollView(
      physics: BouncingScrollPhysics(),
      slivers: [
        SliverAppBar(
          stretch: true,
          onStretchTrigger: () async {
            Navigator.of(context).pop();
          },
        ),
        SliverFillRemaining(),
      ],
    );
  }
}

Expected results:
Close the OpenContainer route.
Actual results:
Throws an exception due to failed assertion.

Logs

$ flutter run --verbose
[  +87 ms] executing: [/mnt/hdd/Development/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +21 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] bbfbf1770cca2da7c82e887e4e4af910034800b6
[        ] executing: [/mnt/hdd/Development/flutter/] git tag --contains HEAD
[ +148 ms] Exit code 0 from: git tag --contains HEAD
[   +1 ms] 1.20.2
[   +6 ms] executing: [/mnt/hdd/Development/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [/mnt/hdd/Development/flutter/] git ls-remote --get-url origin
[   +3 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +39 ms] executing: [/mnt/hdd/Development/flutter/] git rev-parse --abbrev-ref HEAD
[   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[  +28 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +10 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb devices -l
[  +30 ms] List of devices attached
           emulator-5554          device product:sdk_gphone_x86 model:Android_SDK_built_for_x86 device:generic_x86 transport_id:1
[   +7 ms] /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell getprop
[  +25 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +145 ms] Generating /home/tombursch/Desktop/bug/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +20 ms] ro.hardware = ranchu
[  +21 ms] Using hardware rendering with device Android SDK built for x86. If you notice graphics artifacts, consider enabling software rendering with "--enable-software-rendering".
[  +34 ms] Starting incremental build...
[   +3 ms] Initializing file store
[  +11 ms] Skipping target: gen_localizations
[   +7 ms] complete
[   +6 ms] Launching lib/main.dart on Android SDK built for x86 in debug mode...
[   +8 ms] /mnt/hdd/Development/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev /mnt/hdd/Development/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot --sdk-root /mnt/hdd/Development/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk/
--incremental --target=flutter --debugger-module-names -Ddart.developer.causal_async_stacks=true --output-dill /tmp/flutter_tools.ONNQEM/flutter_tool.HEUFWS/app.dill --packages .packages -Ddart.vm.profile=false -Ddart.vm.product=false
--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-scheme org-dartlang-root --initialize-from-dill build/cache.dill.track.dill
[  +16 ms] executing: /mnt/hdd/Development/android/sdk/build-tools/30.0.1/aapt dump xmltree /home/tombursch/Desktop/bug/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[   +6 ms] Exit code 0 from: /mnt/hdd/Development/android/sdk/build-tools/30.0.1/aapt dump xmltree /home/tombursch/Desktop/bug/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[        ] N: android=http://schemas.android.com/apk/res/android
             E: manifest (line=2)
               A: android:versionCode(0x0101021b)=(type 0x10)0x1
               A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0")
               A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c
               A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9")
               A: package="com.example.bug" (Raw: "com.example.bug")
               A: platformBuildVersionCode=(type 0x10)0x1c
               A: platformBuildVersionName=(type 0x10)0x9
               E: uses-sdk (line=7)
                 A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10
                 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c
               E: uses-permission (line=14)
                 A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET")
               E: application (line=22)
                 A: android:label(0x01010001)="bug" (Raw: "bug")
                 A: android:icon(0x01010002)=@0x7f080000
                 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication")
                 A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff
                 A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory")
                 E: activity (line=28)
                   A: android:theme(0x01010000)=@0x7f0a0000
                   A: android:name(0x01010003)="com.example.bug.MainActivity" (Raw: "com.example.bug.MainActivity")
                   A: android:launchMode(0x0101001d)=(type 0x10)0x1
                   A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4
                   A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10
                   A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff
                   E: meta-data (line=42)
                     A: android:name(0x01010003)="io.flutter.embedding.android.NormalTheme" (Raw: "io.flutter.embedding.android.NormalTheme")
                     A: android:resource(0x01010025)=@0x7f0a0001
                   E: meta-data (line=52)
                     A: android:name(0x01010003)="io.flutter.embedding.android.SplashScreenDrawable" (Raw: "io.flutter.embedding.android.SplashScreenDrawable")
                     A: android:resource(0x01010025)=@0x7f040000
                   E: intent-filter (line=56)
                     E: action (line=57)
                       A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
                     E: category (line=59)
                       A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
                 E: meta-data (line=66)
                   A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding")
                   A: android:value(0x01010024)=(type 0x10)0x2
[   +7 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell -x logcat -v time -t 1
[  +22 ms] Exit code 0 from: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell -x logcat -v time -t 1
[        ] --------- beginning of main
           08-18 21:28:49.046 E/GnssHAL_GnssInterface( 1790): gnssSvStatusCb: b: input svInfo.flags is 8
[        ] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell -x logcat -v time -t 1
[  +16 ms] Exit code 0 from: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell -x logcat -v time -t 1
[        ] --------- beginning of main
           08-18 21:28:49.046 E/GnssHAL_GnssInterface( 1790): gnssSvStatusCb: b: input svInfo.flags is 8
[   +9 ms] <- compile package:bug/main.dart
[   +9 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb version
[  +21 ms] Android Debug Bridge version 1.0.41
           Version 30.0.3-6597393
           Installed as /mnt/hdd/Development/android/sdk/platform-tools/adb
[   +2 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb start-server
[   +7 ms] Building APK
[  +16 ms] Running Gradle task 'assembleDebug'...
[   +1 ms] gradle.properties already sets `android.enableR8`
[   +1 ms] Using gradle from /home/tombursch/Desktop/bug/android/gradlew.
[        ] /home/tombursch/Desktop/bug/android/gradlew mode: 33277 rwxrwxr-x.
[   +7 ms] executing: /mnt/hdd/bin/android-studio/jre/bin/java -version
[  +51 ms] Exit code 0 from: /mnt/hdd/bin/android-studio/jre/bin/java -version
[        ] openjdk version "1.8.0_212-release"
           OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
           OpenJDK 64-Bit Server VM (build 25.212-b4-5784211, mixed mode)
[   +3 ms] executing: [/home/tombursch/Desktop/bug/android/] /home/tombursch/Desktop/bug/android/gradlew -Pverbose=true -Ptarget-platform=android-x86 -Ptarget=/home/tombursch/Desktop/bug/lib/main.dart -Ptrack-widget-creation=true -Pfilesystem-scheme=org-dartlang-root
assembleDebug
[+2872 ms] > Task :app:compileFlutterBuildDebug
[        ] [  +91 ms] executing: [/mnt/hdd/Development/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] [  +22 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] [        ] bbfbf1770cca2da7c82e887e4e4af910034800b6
[        ] [        ] executing: [/mnt/hdd/Development/flutter/] git tag --contains HEAD
[        ] [ +150 ms] Exit code 0 from: git tag --contains HEAD
[        ] [        ] 1.20.2
[        ] [   +6 ms] executing: [/mnt/hdd/Development/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[        ] [   +3 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] [        ] origin/stable
[        ] [        ] executing: [/mnt/hdd/Development/flutter/] git ls-remote --get-url origin
[        ] [   +2 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] [        ] https://github.com/flutter/flutter.git
[        ] [  +31 ms] executing: [/mnt/hdd/Development/flutter/] git rev-parse --abbrev-ref HEAD
[        ] [   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] [        ] stable
[        ] [  +22 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] [   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] [   +4 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] [  +63 ms] Initializing file store
[        ] [  +13 ms] Skipping target: gen_localizations
[        ] [   +5 ms] kernel_snapshot: Starting due to {}
[   +1 ms] [  +24 ms] /mnt/hdd/Development/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev /mnt/hdd/Development/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot --sdk-root
/mnt/hdd/Development/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk/ --target=flutter -Ddart.developer.causal_async_stacks=true -Ddart.vm.profile=false -Ddart.vm.product=false
--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --no-link-platform --packages /home/tombursch/Desktop/bug/.packages --output-dill
/home/tombursch/Desktop/bug/.dart_tool/flutter_build/c40bec4533331ab7592dfe30f1858608/app.dill --depfile /home/tombursch/Desktop/bug/.dart_tool/flutter_build/c40bec4533331ab7592dfe30f1858608/kernel_snapshot.d package:bug/main.dart
[+3979 ms] [+5255 ms] kernel_snapshot: Complete
[ +499 ms] [ +483 ms] debug_android_application: Starting due to {}
[ +100 ms] [ +172 ms] debug_android_application: Complete
[ +599 ms] [ +539 ms] Persisting file store
[        ] [   +6 ms] Done persisting file store
[        ] [   +6 ms] build succeeded.
[        ] [   +7 ms] "flutter assemble" took 6,592ms.
[        ] [   +2 ms] ensureAnalyticsSent: 0ms
[        ] [   +1 ms] Running shutdown hooks
[        ] [        ] Shutdown hooks complete
[        ] [        ] exiting with code 0
[  +99 ms] > Task :app:packLibsflutterBuildDebug UP-TO-DATE
[        ] > Task :app:preBuild UP-TO-DATE
[        ] > Task :app:preDebugBuild UP-TO-DATE
[        ] > Task :app:compileDebugAidl NO-SOURCE
[        ] > Task :app:checkDebugManifest UP-TO-DATE
[        ] > Task :app:compileDebugRenderscript NO-SOURCE
[        ] > Task :app:generateDebugBuildConfig UP-TO-DATE
[        ] > Task :app:cleanMergeDebugAssets
[        ] > Task :app:mergeDebugShaders UP-TO-DATE
[        ] > Task :app:compileDebugShaders UP-TO-DATE
[        ] > Task :app:generateDebugAssets UP-TO-DATE
[        ] > Task :app:mainApkListPersistenceDebug UP-TO-DATE
[        ] > Task :app:mergeDebugAssets
[ +198 ms] > Task :app:copyFlutterAssetsDebug
[        ] > Task :app:generateDebugResValues UP-TO-DATE
[        ] > Task :app:generateDebugResources UP-TO-DATE
[        ] > Task :app:mergeDebugResources UP-TO-DATE
[   +1 ms] > Task :app:createDebugCompatibleScreenManifests UP-TO-DATE
[        ] > Task :app:processDebugManifest UP-TO-DATE
[        ] > Task :app:processDebugResources UP-TO-DATE
[        ] > Task :app:compileDebugKotlin UP-TO-DATE
[        ] > Task :app:javaPreCompileDebug UP-TO-DATE
[        ] > Task :app:compileDebugJavaWithJavac UP-TO-DATE
[        ] > Task :app:compileDebugSources UP-TO-DATE
[        ] > Task :app:processDebugJavaRes NO-SOURCE
[        ] > Task :app:mergeDebugJavaResource UP-TO-DATE
[        ] > Task :app:checkDebugDuplicateClasses UP-TO-DATE
[        ] > Task :app:transformClassesWithDexBuilderForDebug UP-TO-DATE
[        ] > Task :app:desugarDebugFileDependencies UP-TO-DATE
[        ] > Task :app:mergeExtDexDebug UP-TO-DATE
[        ] > Task :app:mergeDexDebug UP-TO-DATE
[        ] > Task :app:validateSigningDebug UP-TO-DATE
[  +95 ms] > Task :app:signingConfigWriterDebug UP-TO-DATE
[        ] > Task :app:mergeDebugJniLibFolders UP-TO-DATE
[        ] > Task :app:mergeDebugNativeLibs UP-TO-DATE
[        ] > Task :app:stripDebugDebugSymbols UP-TO-DATE
[        ] Compatible side by side NDK version was not found.
[ +899 ms] > Task :app:packageDebug
[ +144 ms] > Task :app:assembleDebug
[        ] BUILD SUCCESSFUL in 9s
[        ] 31 actionable tasks: 6 executed, 25 up-to-date
[ +355 ms] Running Gradle task 'assembleDebug'... (completed in 9.9s)
[  +86 ms] calculateSha: LocalDirectory: '/home/tombursch/Desktop/bug/build/app/outputs/flutter-apk'/app.apk
[  +38 ms] calculateSha: reading file took 38us
[ +421 ms] calculateSha: computing sha took 421us
[   +4 ms] ✓ Built build/app/outputs/flutter-apk/app-debug.apk.
[   +2 ms] executing: /mnt/hdd/Development/android/sdk/build-tools/30.0.1/aapt dump xmltree /home/tombursch/Desktop/bug/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[   +4 ms] Exit code 0 from: /mnt/hdd/Development/android/sdk/build-tools/30.0.1/aapt dump xmltree /home/tombursch/Desktop/bug/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[        ] N: android=http://schemas.android.com/apk/res/android
             E: manifest (line=2)
               A: android:versionCode(0x0101021b)=(type 0x10)0x1
               A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0")
               A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c
               A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9")
               A: package="com.example.bug" (Raw: "com.example.bug")
               A: platformBuildVersionCode=(type 0x10)0x1c
               A: platformBuildVersionName=(type 0x10)0x9
               E: uses-sdk (line=7)
                 A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10
                 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c
               E: uses-permission (line=14)
                 A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET")
               E: application (line=22)
                 A: android:label(0x01010001)="bug" (Raw: "bug")
                 A: android:icon(0x01010002)=@0x7f080000
                 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication")
                 A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff
                 A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory")
                 E: activity (line=28)
                   A: android:theme(0x01010000)=@0x7f0a0000
                   A: android:name(0x01010003)="com.example.bug.MainActivity" (Raw: "com.example.bug.MainActivity")
                   A: android:launchMode(0x0101001d)=(type 0x10)0x1
                   A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4
                   A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10
                   A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff
                   E: meta-data (line=42)
                     A: android:name(0x01010003)="io.flutter.embedding.android.NormalTheme" (Raw: "io.flutter.embedding.android.NormalTheme")
                     A: android:resource(0x01010025)=@0x7f0a0001
                   E: meta-data (line=52)
                     A: android:name(0x01010003)="io.flutter.embedding.android.SplashScreenDrawable" (Raw: "io.flutter.embedding.android.SplashScreenDrawable")
                     A: android:resource(0x01010025)=@0x7f040000
                   E: intent-filter (line=56)
                     E: action (line=57)
                       A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
                     E: category (line=59)
                       A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
                 E: meta-data (line=66)
                   A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding")
                   A: android:value(0x01010024)=(type 0x10)0x2
[        ] Stopping app 'app.apk' on Android SDK built for x86.
[        ] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell am force-stop com.example.bug
[  +29 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell pm list packages com.example.bug
[  +21 ms] package:com.example.bug
[   +1 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell cat /data/local/tmp/sky.com.example.bug.sha1
[  +14 ms] 57a14c6140adf88e1d0e19c5eb5d1c5140f8c081
[        ] Installing APK.
[   +1 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb version
[   +4 ms] Android Debug Bridge version 1.0.41
           Version 30.0.3-6597393
           Installed as /mnt/hdd/Development/android/sdk/platform-tools/adb
[        ] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb start-server
[   +4 ms] Installing build/app/outputs/flutter-apk/app.apk...
[        ] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 install -t -r /home/tombursch/Desktop/bug/build/app/outputs/flutter-apk/app.apk
[ +568 ms] Performing Streamed Install
                    Success
[        ] Installing build/app/outputs/flutter-apk/app.apk... (completed in 0.6s)
[        ] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell echo -n d5a4cb21370243a0a2075b1231898dd79486874e > /data/local/tmp/sky.com.example.bug.sha1
[  +17 ms] Android SDK built for x86 startApp
[   +1 ms] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez enable-dart-profiling true --ez enable-checked-mode true --ez verify-entry-points
true com.example.bug/com.example.bug.MainActivity
[  +30 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.example.bug/.MainActivity (has extras) }
[        ] Waiting for observatory port to be available...
[+1168 ms] Observatory URL on device: http://<IP_ADDRESS>:38381/qsgiDCyMsvM=/
[        ] executing: /mnt/hdd/Development/android/sdk/platform-tools/adb -s emulator-5554 forward tcp:0 tcp:38381
[   +8 ms] 46725
[        ] Forwarded host port 46725 to device port 38381 for Observatory
[   +5 ms] Caching compiled dill
[  +30 ms] Connecting to service protocol: http://<IP_ADDRESS>:46725/qsgiDCyMsvM=/
[ +273 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:46725/qsgiDCyMsvM=/
[        ] Waiting for Android SDK built for x86 to report its views...
[   +8 ms] Waiting for Android SDK built for x86 to report its views... (completed in 7ms)
[   +9 ms] DevFS: Creating new filesystem on the device (null)
[  +28 ms] DevFS: Created new filesystem on the device (file:///data/user/0/com.example.bug/code_cache/bugLSERYO/bug/)
[   +2 ms] Updating assets
[  +62 ms] Syncing files to device Android SDK built for x86...
[   +1 ms] Scanning asset files
[   +1 ms] <- reset
[        ] Compiling dart to kernel with 0 updated files
[        ] <- recompile package:bug/main.dart fd7c7998-5fef-457c-bb0b-0f695d601108
[        ] <- fd7c7998-5fef-457c-bb0b-0f695d601108
[ +104 ms] Updating files
[ +134 ms] DevFS: Sync finished
[        ] Syncing files to device Android SDK built for x86... (completed in 242ms)
[        ] Synced 0.9MB.
[        ] <- accept
[   +5 ms] Connected to _flutterView/0xcd30cc10.
[   +1 ms] Flutter run key commands.
[   +1 ms] r Hot reload. 🔥🔥🔥
[        ] R Hot restart.
[        ] h Repeat this help message.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] An Observatory debugger and profiler on Android SDK built for x86 is available at: http://<IP_ADDRESS>:46725/qsgiDCyMsvM=/
[+6803 ms] E/flutter (28267): [ERROR:flutter/lib/ui/ui_dart_state.cc(166)] Unhandled Exception: 'package:flutter/src/rendering/box.dart': Failed assertion: line 1709 pos 13: 'debugDoingThisResize || debugDoingThisLayout ||
[        ] E/flutter (28267):               (RenderObject.debugActiveLayout == parent && _size._canBeUsedByParent)': RenderBox.size accessed beyond the scope of resize, layout, or permitted parent access. RenderBox can always access its own size, otherwise, the only object
that is allowed to read RenderBox.size is its parent, if they have said they will. It you hit this assert trying to access a child's size, pass "parentUsesSize: true" to that child's layout().
[        ] E/flutter (28267): #0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:46:39)
[        ] E/flutter (28267): #1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:36:5)
[        ] E/flutter (28267): #2      RenderBox.size.<anonymous closure> (package:flutter/src/rendering/box.dart:1709:13)
[        ] E/flutter (28267): #3      RenderBox.size (package:flutter/src/rendering/box.dart:1722:6)
[        ] E/flutter (28267): #4      _OpenContainerRoute._getSize (package:animations/src/open_container.dart:656:19)
[        ] E/flutter (28267): #5      _OpenContainerRoute._takeMeasurements (package:animations/src/open_container.dart:635:26)
[        ] E/flutter (28267): #6      _OpenContainerRoute.didPop (package:animations/src/open_container.dart:620:5)
[        ] E/flutter (28267): #7      _RouteEntry.pop (package:flutter/src/widgets/navigator.dart:2489:15)
[        ] E/flutter (28267): #8      NavigatorState.pop (package:flutter/src/widgets/navigator.dart:3800:13)
[        ] E/flutter (28267): #9      ContainerPage.build.<anonymous closure> (package:bug/openContainerBug.dart:41:35)
[        ] E/flutter (28267): #10     RenderSliverPersistentHeader.layoutChild (package:flutter/src/rendering/sliver_persistent_header.dart:196:44)
[        ] E/flutter (28267): #11     RenderSliverScrollingPersistentHeader.performLayout (package:flutter/src/rendering/sliver_persistent_header.dart:338:5)
[        ] E/flutter (28267): #12     RenderObject.layout (package:flutter/src/rendering/object.dart:1769:7)
[        ] E/flutter (28267): #13     RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:471:13)
[        ] E/flutter (28267): #14     RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1465:12)
[        ] E/flutter (28267): #15     RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1374:20)
[        ] E/flutter (28267): #16     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1632:7)
[        ] E/flutter (28267): #17     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:889:18)
[        ] E/flutter (28267): #18     RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:404:19)
[        ] E/flutter (28267): #19     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:867:13)
[        ] E/flutter (28267): #20     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:286:5)
[        ] E/flutter (28267): #21     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1117:15)
[        ] E/flutter (28267): #22     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1056:9)
[        ] E/flutter (28267): #23     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:972:5)
[        ] E/flutter (28267): #24     _rootRun (dart:async/zone.dart:1190:13)
[        ] E/flutter (28267): #25     _CustomZone.run (dart:async/zone.dart:1093:19)
[        ] E/flutter (28267): #26     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
[        ] E/flutter (28267): #27     _invoke (dart:ui/hooks.dart:253:10)
[        ] E/flutter (28267): #28     _drawFrame (dart:ui/hooks.dart:211:3)
[        ] E/flutter (28267):

$ flutter analyze
Analyzing bug...
No issues found! (ran in 1.3s)

$ flutter doctor -v
[✓] Flutter (Channel stable, 1.20.2, on Linux, locale en_US.UTF-8)
    • Flutter version 1.20.2 at /mnt/hdd/Development/flutter
    • Framework revision bbfbf1770c (5 days ago), 2020-08-13 08:33:09 -0700
    • Engine revision 9d5b21729f
    • Dart version 2.9.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /mnt/hdd/Development/android/sdk
    • Platform android-30, build-tools 30.0.1
    • ANDROID_HOME = /mnt/hdd/Development/android/sdk
    • Java binary at: /mnt/hdd/bin/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[!] Android Studio (version 3.6)
    • Android Studio at /mnt/hdd/bin/android-studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.48.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.13.2

[✓] Connected device (1 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86 • Android
      10 (API 29) (emulator)

! Doctor found issues in 1 category.

Hi @TomBursch
Can you please provide a complete sample code? The code provide is missing the OpenContainer class!
Tank you

Hi @pedromassangocode,
The OpenContainer class is part of the Animations package
Thanks

Able to reproduce this on latest master channel.

 Logs
Performing hot restart...
Syncing files to device iPhone 11 Pro Max...
Restarted application in 830ms.
[VERBOSE-2:ui_dart_state.cc(171)] Unhandled Exception: 'package:flutter/src/rendering/box.dart': Failed assertion: line 1720 pos 13: 'debugDoingThisResize || debugDoingThisLayout ||
              (RenderObject.debugActiveLayout == parent && _size._canBeUsedByParent)': RenderBox.size accessed beyond the scope of resize, layout, or permitted parent access. RenderBox can always access its own size, otherwise, the only object that is allowed to read RenderBox.size is its parent, if they have said they will. It you hit this assert trying to access a child's size, pass "parentUsesSize: true" to that child's layout().
#0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:46:39)
#1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:36:5)
#2      RenderBox.size.<anonymous closure> (package:flutter/src/rendering/box.dart:1720:13)
#3      RenderBox.size (package:flutter/src/rendering/box.dart:1733:6)
#4      _OpenContainerRoute._getSize (package:animations/src/open_container.dart<…>

 flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-10.0.pre.138, on Mac OS X 10.15.6 19G2021,
    locale en)
    • Flutter version 1.21.0-10.0.pre.138 at
      /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision 3562b3c0de (27 hours ago), 2020-08-18 01:46:02 -0400
    • Engine revision 02de4eb7ce
    • Dart version 2.10.0 (build 2.10.0-37.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.6397.47

[!] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API
      30) (emulator)
    • macOS (desktop)         • macos         • darwin-x64     • Mac OS X
      10.15.6 19G2021
    • Web Server (web)        • web-server    • web-javascript • Flutter Tools
    • Chrome (web)            • chrome        • web-javascript • Google Chrome
      84.0.4147.135

! Doctor found issues in 3 categories.

Still reproduces on the latest versions of flutter.

logs
Launching lib/main.dart on iPhone 14 Pro in debug mode...
Xcode build done.                                           33.6s
Connecting to VM Service at ws://<IP_ADDRESS>:64299/rN1geA4Q_N4=/ws
[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: 'package:flutter/src/rendering/box.dart': Failed assertion: line 2009 pos 13: 'debugDoingThisResize || debugDoingThisLayout || _computingThisDryLayout ||
              (RenderObject.debugActiveLayout == parent && size._canBeUsedByParent)': RenderBox.size accessed beyond the scope of resize, layout, or permitted parent access. RenderBox can always access its own size, otherwise, the only object that is allowed to read RenderBox.size is its parent, if they have said they will. It you hit this assert trying to access a child's size, pass "parentUsesSize: true" to that child's layout().
#0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)
#1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)
#2      RenderBox.size.<anonymous closure>
#3      RenderBox.size
#4      _OpenContainerRoute._getSize (package:ani<…>
Application finished.
Exited

updated sample
import 'package:animations/animations.dart';
import 'package:flutter/material.dart';

void  main(List<String> args) {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: Scaffold(
        appBar: AppBar(),
        body: Padding(
          padding: const EdgeInsets.all(8.0),
          child: Column(
            crossAxisAlignment: CrossAxisAlignment.stretch,
            children: [
              OpenContainer(
                closedBuilder: (context, _) => const Padding(
                  padding: EdgeInsets.all(8.0),
                  child: Text('Container'),
                ),
                openBuilder: (context, _) => const ContainerPage(),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

class ContainerPage extends StatelessWidget {
  const ContainerPage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return CustomScrollView(
      physics: const BouncingScrollPhysics(),
      slivers: [
        SliverAppBar(
          stretch: true,
          onStretchTrigger: () async {
            Navigator.of(context).pop();
          },
        ),
        const SliverFillRemaining(),
      ],
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.9, on macOS 13.0.1 22A400 darwin-arm, locale en-GB)
    • Flutter version 3.3.9 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (10 days ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.54.0

[✓] Connected device (3 available)
    • iPhone 14 Pro (mobile) • 4F72110C-F38B-4CF9-93C4-4D6042148D28 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.71

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

[!] Flutter (Channel master, 3.7.0-2.0.pre.9, on macOS 13.0.1 22A400 darwin-arm64, locale en-GB)
    • Flutter version 3.7.0-2.0.pre.9 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ce94230281 (9 hours ago), 2022-12-01 19:13:07 -0800
    • Engine revision 025aefc7af
    • Dart version 2.19.0 (build 2.19.0-444.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.54.0

[✓] Connected device (3 available)
    • iPhone 14 Pro (mobile) • 4F72110C-F38B-4CF9-93C4-4D6042148D28 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.71

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.


1.97.0

+ repository overview as main page
+ Generic possibility for changelog news
+ handling import of cyclic DDIC objects
! removed default for commit comment
! raise exception when no .abapgit.xml is found
* fix incorrect status of ignored files in repo view
* url validation fixes
* WDYN UI sort
* DSYS downport and changes
* SCP1 import order
* downport
* clear ICFSERVICE-ICFBITMAP
* W3MI record to transport
* general refactoring

No luck with the release tag:
Detecting version change ...
no version change detected, skipping tag creation (src/zif_abapgit_version.intf.abap unchanged)
i think a script that run before does another commit. and therefore the release tag script can't detect the change anymore


Define qos-traffic-management-api

Define the QoS/ traffic management API
This function applies Quality of Service (QoS) and traffic management configurations on the Platform HAL based on the provided network parameters.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.nithish seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

It looks to be License issue , CLosing this PR and raise new one


Camera: Add code to update View and Projection Matrices in update function

A user on the forums had recently found an issue when performing input while using an on-demand rendering loop.  The issue was that the onViewMatrixChangedObservable wasn't firing as a part of pointer input.  This behavior was present in previous versions.  It was determined that the Lazy Picking changes may have caused this change because the aforementioned observable only fires during getViewMatrix() calls.  Before the Lazy Picking implementation, this function was called as a part of the creation and assignment of the picking ray for a PickingInfo object.  Since this ray is only created when picking happens, a pointer event that doesn't require picking info won't ever get to the point where getViewMatrix is called.  Technically, these get functions should be called as a part of the camera's update function so the fix is to do just that.
Forum Link: https://forum.babylonjs.com/t/on-demand-rendering-solution-broken-since-5-29/36379/1
Issue Link: https://github.com/BabylonJS/Babylon.js/issues/13551

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13552/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13552/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13552/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13552/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13552/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13552/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13552/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13552/merge#BCU1XR#0

Are there any performance implications with this?
Should we add tests for this?

Are there any performance implications with this?
This shouldn't have any significant perf impacts.  Worst case scenario is that we have a couple more if statement evals during a frame's lifespan
Should we add tests for this?
I'm not sure that we can write tests any of the get*Matrix() calls but I am in the process of writing tests to verify that the observables are firing.


add ANI2x test against original implementation

Pull Request Summary
ANI2x test using original parameters to check for implementation correctness.
Key changes

[x] Refactor ANI2x implementaiton
[x] Bugfix for energy addition

Pull Request Checklist

[x] PR is ready for review

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.01%. Comparing base (88380ce) to head (b912a55).

Additional details and impacted files


AutoTracker Not Tracking in Windows

💻 Environment

Platform: Windows
OS Version: Unknown
Toggl Version: 7.4.252
🐞 Actual behavior
Autotracker function not detecting user actions, even after all proper setup steps have been followed
💯 Expected behavior
Autotracker "sees" user activity that fits trigger words and asks to track time
🔨 Steps to reproduce

Set up Autotracker
Attempt to use

📦 Additional info
User case

Probably fixed with 64-bit release


single borders should be non-rounded

border type single should be appear square by default, but as we can see in lua_signature_helper.lua, we are overriding this by a rounded single border. To make this more consistent with other nvim-lua plugins, as well as the internal border spec, this should be square. Users who want rounded corners for a single border can use the rounded option.

thanks, added rounded

This should be solved in latest


Passing the PartitionKey value for INSERT, UPDATE and DELETE statements

Hi @btnguyen2k, thank you very much for putting this driver together and it's awesome to see that it became and official Microsoft release!
I spent a bit of time looking at the code trying to understand what's the best way to integrate it as an additional SQL driver in Benthos so users can leverage the generic sql_* components together with CosmosDB. While I am able to get it to work (for basic queries at least), I bumped into a particularity of this driver related to how it extracts the value of the PartitionKey from the variadic args which get passed to sql.DB.Exec(), where it seems to mandate that this value gets passed as the last argument. For example, if I have this query INSERT INTO users (department, name, username, email) VALUES ($1, $2, $3, $4), where /department is the PartitionKey, then I have to call db.Exec("<query>", "some_department", "foobar", "foobar_user"<EMAIL_ADDRESS>"some_department"). This repetition of the PartitionKey value is awkward because the other SQL drivers I've used require that the number of args match the number of placeholders, which makes it easy to have higher level constructs without adding custom handling for each specific driver.
I don't have a good understanding of the constraints and, assuming it's not ideal (performance might be an issue) to query the server for the container PartitionKey (or Keys when the container uses hierarchical partition keys), I wonder if it would be possible to provide a hint in the query itself to describe which field(s) need to be passed in the x-ms-documentdb-partitionkey header and then have the driver pick them out automatically either from the sql.DB.Exec() args or directly from the parsed query if its static (doesn't have a placeholder for the PartitionKey(s)). It's a bit unclear why the server needs to receive this header in the first place as suggested in the answer here, but I suppose that's a different discussion.

Hi @mihaitodor,
Your feedback taken. In fact, I have been thinking of a good solution for this issue as well. However, no good solution has come yet. One solution is to query Cosmos DB server for table metadata in order to detect PK automatically, but it'll be a performance penalty. Also, it may incur extra cost as some RU is consumed.
Another approach that I am thinking is to provide a hint to the query using WITH clause, for example INSERT INTO users (department, name, username, email) VALUES ($1, $2, $3, $4) WITH pk=/department.
The solution will be in the next (maybe a couple) release once I finalize the solution.
Best regards,
Thanh

Thank you for the quick reply @btnguyen2k! That does help clarify things. I'd be happy with both of those options, since they'd be transparent from the perspective of Benthos. If you only provide the second approach, then the generic sql_insert that Benthos provides won't know how to construct the INSERT query automatically, so then I'd only enable it for the sql_raw components, where the users would have to always write the full query themselves, but that's not a huge issue.
No rush on this, so please take your time! Until then, I'm adding an input and output based on github.com/Azure/azure-sdk-for-go.

This has been implemented in v1.1.0.
Cheers,

@btnguyen2k Awesome job! It works great, at least for my initial experiments. Thank you very much!
I put together a Benthos PR to integrate both https://github.com/Azure/azure-sdk-for-go/sdk/data/azcosmos and this one. There will be some overlap in functionality, but I think this offers the most flexibility, especially since your driver already has some support for hierarchical partition keys and cross-partition queries. A new release is due soon, so hopefully it will make it into that.


Support holder mode and API

https://transmute-industries.github.io/vc-http-api/#/Holder

is configured based on profiles and is profile is selected based on path (similar to issuer).
profile must be configured to allow usage as holder.

note: similarly, for issuance APIs, a profile must be configured to allow usage as an issuer.

should also update BDD tests to use a Holder instance.

This has been implemented. Closing the issue.


QA/QC - Things to fix

Here is the running list of things to fix.
----- PLOTS to revisit by hand -----
(this is warnings from this script)

[ ] DUKE FOREST LOBLOLLY PINE_MANAGED LOBLOLLY PINE PLANTATION
[ ] BLANDY EXPERIMENTAL FARM_TEMPERATE DECIDUOUS FOREST. STAND ESTABLISHED AROUND 1914
[x] CAXIUANA~ NATIONAL FOREST RESERVE_TROPICAL EVERGREEN FOREST
[x] CAXIUANA~ NATIONAL FOREST RESERVE_TROPICAL EVERGREEN FOREST WITH DROUGHT TREATMENT
[x] CAXIUANA~ NATIONAL FOREST RESERVE_AGGRADING TROPICAL EVERGREEN FOREST
[x] CAXIUANA~ NATIONAL FOREST RESERVE_AGGRADING TROPICAL EVERGREEN FOREST. STAND ESTABLISHED AROUND 1960

----- MEASUREMENTS checks -----

[x] there are 0 measurement.ID that are repeated
[x] There are 0 measurements with no corresponding plot record
[x] There are 0 measurements with no corresponding site in SITES record
[x] There are 0 measurement records with undefined PFTs
[x] There are 0 measurement records with undefined varibale.name
[ ] There are 2 covariate_1 in measurements that are not defined in VARIABLES : "min.depth"  and "max.height"
[ ] There are 1 covariate_2 in measurements that are not defined in VARIABLES: "%C"
[x] There are 0 measurement records with no corresponding methodology record

----- SITES checks -----

[x] There are 0 sites with no corresponding plot record
[x] There are 0 sites with no corresponding history record
[x] There are 0 sites with no corresponding measurements record

----- HISTORY checks -----

[x] There are 0 history records with no corresponding measurements record
[x] There are 0 history records with no corresponding sites record
[ ] There are 3 history records with undefined disturbance category/type combinations
[x] There are 0 history records with no corresponding plot record

----- PLOTS checks -----

[x] There are 0 plots with no corresponding measurement record
[x] There are 0 plots with no corresponding history recordd
[x] There are 0 plots with no corresponding site record

----- HISTTYPE checks -----

[ ] There are hist.type in HISTTYPE that don't exist in HISTORY table (not a big deal)
[ ] There are hist.cat in HISTTYPE that don't exist in PLOTS table (not a big deal)

----- PFT checks -----

[ ] There are pftcode in PFT that don't exist in MEASUREMENTS table. ("2VW", "2GW", "2FORB", "2LTR", "2RF", "2RB") (not a big deal)

----- METHODOLOGY checks -----

[ ] There are method.ID in METHODOLOGY that don't exist in MEASUREMENTS table. (not big deal)
[ ] method.notes is not in METHODOLOGY table but is mentioned in METHODOLOGY_metadata

----- VARIABLES checks -----

[x] There variables not used in MEASUREMENTS table ("NPP_4_OM", "NPP_5_OM", "NPP_woody_OM", "NPP_litter_OM", "ANPP_litterfall_2_C", "BNPP_root.turnover_fine_OM", "R_het_deadwood", "R_het_ag_C",
"R_het_C). It is probably ok to leave them, but I am still mentioning in case records have been accidentally deleted.

----- ALLOMETRIES checks -----

[x] There allometric.equation not used in MEASUREMENTS table. (not a big deal)

-----  MEASUREMENT MEAN VALUE check against range in VARIABLES -----

[ ] There is 618 measurements falling out of variable range
[ ] There is 58 covariate_1 value(s) falling out of variable range
[ ]  There is 19 covariate_2 value(s) falling out of variable range
[ ] There is 87 value(s) from a variable that has no defined range (this is probably the first record for that variable)

---- DUPLICATE RECORDS ------

[ ] There are D.precedences to give manually (mostly SRDB data, but 2 records from GROA)

Most of these issues probably relate to the new data. @banburymorgan, could you please take a look first? I’ll review he ones you can’t solve.

@teixeirak, all the missing method.ID are for stand.density, and I am assuming method.ID is correctly NA there, right ? If yes, I'll adapt the check script to ignore this situation.

[ ] @teixeirak here are the hist.type not defined in HISTTYPE table:

hist.cat
hist.type

Management
Warming_soil

Management
Warming_air

No.disturbance
No major disturbance

Regrowth
Initiation of post-disturbance cohort (planted)

No.disturbance
NAC

@teixeirak and @beckybanbury,
I created this file (that you probably have to open in your web browser from your computer, after pulling) that shows records that are outside of the range of values previously calculated for each variable.
I haven't had a close look yet but I thought I would mention it to you right away so that you can let me know what you think and maybe check some of the records (red dots with measurement.ID mentioned)

This is helpful; thank you @ValentineHerr.
@beckybanbury, we do not need to review all of these records-- only the ones that are significant outliers.  I'll leave this to you, but please let me know if there are any you'd like me to look at.

-Warming was in there as Warming_X, with X indicating soil or air. I fixed it to make coding easier.
-There is a No.disturbance, "No severe disturbance". These should be the same. Let's replace "major" with "severe"
-Regrowth should be one of the following:
Regrowth(_prior) | Initiation of post-disturbance cohort   (planted or natural)
Regrowth(_prior) | Planted

How many No.disturbance 	NAC are there? That's not a current category, although I suppose its fine (other than messing up the code)

yes, correct

@teixeirak,
here are few things that need to be done or answered.
Note for myself: I created this list after importing SRDB data and updated all files and figures.

[ ] give D.precedence to record that have "NAC" there (SRDB data, pending on this issue)

[ ] replace NEP and NPP_litter to NEP_C and NPP_litter_C for SRDB. And Ideally, find out why it did not come with the "_C" in the first place... (@ValentineHerr)

[ ] define hist.type not defined in HISTTYPE table (might not be necessary, see below table)  (@teixeirak) :

hist.cat
hist.type

No.disturbance
No major disturbance

Regrowth
Initiation of post-disturbance cohort (planted)

Management
Warming

should "No major disturbance" be replaced by "No severe disturbance", which already exists ?

is "Initiation of post-disturbance cohort (planted)" a special case of "Initiation of post-disturbance cohort (planted or natural)" or should it have its own case ?

we have warming_air and warming_soil... I think all instances of Warming are from SRDB so maybe I can replace them all by warming_soil ?

[ ] some records are:

hist.cat
hist.type

No.disturbance
NAC

Should  "NAC" be replaced by "No severe disturbance" ? (@teixeirak)

[ ]  I dont't rememeber "Agriculture_generic" hist.type not being used in History before. Now it is coming out in the QA/QC. I might not have noticed it before bu do you know of any record with that history type that have been deleted? (@teixeirak )

[ ]  check range of records checking_range_of_records.html (see this comment) (@beckybanbury)

[ ] has method.notes been removed from methodology table intentionally ? (@teixeirak)

[ ] this figure  splits the data into tropical and extratropical. We do not have that column anymore. Can you remind me of the lat threshold to determine it again? (@teixeirak)

* [this figure ](https://github.com/forc-db/ForC/blob/master/figures/Histogram_of_Stand_age.png) splits the data into tropical and extratropical. We do not have that column anymore. Can you remind me of the lat threshold to determine it again? (@teixeirak)

23.5

* has method.notes been removed from methodology table intentionally ? (@teixeirak)

I'm confused... its there in the version I'm looking at. It has value NA for all SRDB records.

* I dont't rememeber "Agriculture_generic" hist.type not being used in History before. Now it is coming out in the QA/QC. I might not have noticed it before bu do you know of any record with that history type that have been deleted? (@teixeirak )

I believe we added this recently-- perhaps for GROA import?  You can leave it ehre.

* give D.precedence to record that have "NAC" there (SRDB data, pending on [this issue](https://github.com/forc-db/ForC_private/issues/18))

By, "there", do you mean in methodology? If so, please don't automatically assign precedence there; those should get manual review (for now).

should "No major disturbance" be replaced by "No severe disturbance", which already exists ?

YES

is "Initiation of post-disturbance cohort (planted)" a special case of "Initiation of post-disturbance cohort (planted or natural)" or should it have its own case ?

These are separate cases. The first indicates that we know the stand was planted. The second indicates that its ambiguous whether regen was natural or planted.

we have warming_air and warming_soil... I think all instances of Warming are from SRDB so maybe I can replace them all by warming_soil ?

In some cases it was ambiguous what type of warming was applied. I added the category "warming" to HISTTYPE

* give D.precedence to record that have "NAC" there (SRDB data, pending on [this issue](https://github.com/forc-db/ForC_private/issues/18))

By, "there", do you mean in methodology? If so, please don't automatically assign precedence there; those should get manual review (for now).

By "there" I mean in D.precedence. I just meant that we need to give D.precedence manually to some records, once we know how to rank the different methodologies coming from SRDB.

is "Initiation of post-disturbance cohort (planted)" a special case of "Initiation of post-disturbance cohort (planted or natural)" or should it have its own case ?

These are separate cases. The first indicates that we know the stand was planted. The second indicates that its ambiguous whether regen was natural or planted.

Ok so I'll add a category for "Initiation of post-disturbance cohort (planted)" to HISTTYPE

By "there" I mean in D.precedence. I just meant that we need to give D.precedence manually to some records, once we know how to rank the different methodologies coming from SRDB.

Okay, please incorporate Ben's feedback and let me know if there are any left for me to review.

Forgot to mention I updated the list in the first comment of this issue. all issues are gone except 3 covariate variable names, imported with GROA, that need to be defined. "%C", "min.depth" and "max.height".

There are also a few potential duplicate records that need to be resolved manually (mostly left over from SRDB import, and a couple that showed up with GROA, that I guess we missed).

@teixeirak, I think with one of your last update there is a disturbance ("cut") that got added in the data but not defined:

@teixeirak, I think with one of your last update there is a disturbance ("cut") that got added in the data but not defined:

Oh, shame on me! It just needs to be capitalized.

@teixeirak, a few things flagged in the QA/QC.

[ ] There are 2 covariate_1 in measurements that are not defined in VARIABLES : "min.depth" and "max.height"
[ ] There are 1 covariate_2 in measurements that are not defined in VARIABLES: "%C"
[ ] There are history records with undefined disturbance category/type combinations: cat = "Disturbance" type = "cut"
[ ]  measurement.ID 25308 has "NA" in mean

Also,

[ ]  I think it would be worth reviewing the values that are outside of range in this file. I'll update the range for the easy ones so maybe you can focus on the obvious issues.

@teixeirak,
I am working on updating ForC_simplified (should do a CI for that!) and here are the few more issues (besides the ones in comment above):

there seems to be a mispelling of Koiwai or Koiwa in the different tables
same with "Klimahaus Research Station" (duplicates in SITES table) but  "Klimhaus Research Station" is missing
there are a 4 citations missing in CITATIONS: "Grier_1977_opmc"       "NAC"                   "Bartholomew_1953_mniu" "CUEVAS_1991_aabo"

Here are a few screen shots that can help.

I resolved the issues and deleted the previous comment.
Only fixed the sites issues but there are 3 citations missing in CITATIONS: "Grier_1977_opmc", "Bartholomew_1953_mniu", "CUEVAS_1991_aabo" that probably @mawilliams99 can work on when there is time.
I don't think those citations were missing before... the citation.id in CITATIONS may have been changed so the solution may just be to update the ciation.id in MEASUREMENTS.

Thanks, @ValentineHerr !  I agree that a CI for this repo would be great, including the QA/QC checks that we have written and updating ForC simplified/ figures. It's definitely worthwhile to set up now if it won't take to much time, as that will make  this whole project easier.


Update gitmodules

Update .gitmodules to change git.apache.org by github.com/apache

I cannot update the Apache submodules anymore and I wonder if it's related to this pull request:
git submodule update --init third_party/httpd/src Submodule 'third_party/httpd/src' (https://github.com/apache/httpd.git) registered for path 'third_party/httpd/src' Cloning into 'third_party/httpd/src'... remote: Enumerating objects: 487867, done. remote: Total 487867 (delta 0), reused 0 (delta 0), pack-reused 487867 Receiving objects: 100% (487867/487867), 301.73 MiB | 8.57 MiB/s, done. Resolving deltas: 100% (406467/406467), done. fatal: reference is not a tree: 493b43719686d9667831da5d5e063fb8fcd8c604 Unable to checkout '493b43719686d9667831da5d5e063fb8fcd8c604' in submodule path 'third_party/httpd/src'
And it seems that this commit id that the submodule links to indeed does not exist in the apache httpd github repo...

Hmm, the last CI build log for master, which is this commit, didn't fail like that:
https://api.travis-ci.org/v3/job/591506645/log.txt
You can observe that it successfully pulled that commit. I just restarted the CI job to see if it reproduces there at this time. (https://travis-ci.org/apache/incubator-pagespeed-mod/builds/591506644)

Are the submodules still cached somehow in your Travis build?
So also when I freshly clone the apache httpd repo and search for the commit id, it seems it's not there:
´git clone https://github.com/apache/httpd.git
git branch --contains 493b43719686d9667831da5d5e063fb8fcd8c604
error: no such commit 493b43719686d9667831da5d5e063fb8fcd8c604´

This PR only changes .gitmodules urls. nothing else.
The error you have say is not a tree
fatal: reference is not a tree: 493b43719686d9667831da5d5e063fb8fcd8c604 Unable to checkout
but it is, as you can see here

error: no such commit 493b43719686d9667831da5d5e063fb8fcd8c604

I have it too.
With "git.apache.org" command "git submodule update --init --recursive" was OK
With "github.com/apache/" emmits this error
If I add --remote in addition, this error disappear, but another one come
fatal: Needed a single revision

It was fixed with:
git add third_party/httpd
git add third_party/httpd24
git submodule update --init --recursive --force


How to create a local dataset / images without captions

I have two questions that are not entirely clear to me.
I want to create a dataset locally from a folder of images and label them all myself manually. (or import a JSON file that I have or whatever) How do I go about doing that? I need to create a pandas dataframe and save it as a parquet file? There appears to be a load_from_disk function in datasets. The pokemon dataset has a text and an image column. I need to construct a new dataset like that and save it to disk so I can use it. Also I need to understand what the config file will then look like. Although this should be fairly simple, I have not succeeded at this yet. A simple hello world or example would really be useful.
Secondly I am wondering if captions are required or if it is possible to for example finetune on a big folder of paintings so that after training, the model behaves like it always had but every output from the model becomes in the style of those images.

You can create a folder with a jsonl file to define the captions and still use the hf dataset, see: https://huggingface.co/docs/datasets/image_dataset#generate-the-dataset-metadata-optional
Then you can just point the datset name to that folder and it should work.


Marker is causing 403 error.

Same problem as was with #signed_hotel_request

@dyatlov please, merge in

Thanks, merged


Feature request: Prohibit certain users from creating repositories

I would like to make my gogs installation public, and allow account registration so people can register to use the issue tracker, but I do not want people going around and creating repositories. I have not figured out a way to prevent new users from being able to create repositories, so for now I have disabled registration entirely.

Please follow on https://github.com/gogits/gogs/issues/1301


Add a check for number of threads

This idea comes from issue #14; tldr, machines with a small number of threads got hung up on the tree-sitter parser generations and installations.
Here's what I'm thinking
-- ~/.config/nvim/lua/plugins.lua

use {
  'nvim-treesitter/nvim-treesitter',
  event = 'BufRead',
  run = ':TSUpdate',
  config = function ()
    require'nvim-treesitter.configs'.setup {
      ensure_installed = 'maintained',
      -- Install languages synchronously; default is `false` (only applied to `ensure_installed`)
      sync_install = countCPUThreads() < 4,  -- a fancy function
      highlight = { enable = true },
      indent = { enable = false },
      autopairs = { enable = true }
    }
  end
}

The table that gets passed into the setup function accepts a key sync_install that holds a boolean value. If that value is true then it installs languages synchronously but this setting is only applied to ensure_installed. Otherwise the default is false and the languages are installed asynchronously.
I'm thinking I can pass an expression as the value for sync_install which when evaluated, will call a custom function that returns the number of threads on the CPU. I know there is a way to do this but I have no idea what it is. I'm guessing call an external command, use a luarock, or something in the lua standard library.

Removed the deprecated ensure_installed option and added the auto_install option which will install the parser for the filetype when entering the buffer if it is not already.
Closing this issue.


feat: Generate Idle Watermark if the source is idling

Explain what this PR does.

Generate the idle Watermark if the source is idling

Fixes #633
Example Pipeline to test the changes:
apiVersion: numaflow.numaproj.io/v1alpha1
kind: Pipeline
metadata:
  name: even-odd-sum
spec:
  watermark:
    idleSource:
      maxWait: 5s
      minIncrement: 5s
  vertices:
    - name: in
      scale:
        min: 2
      source:
        http: {}
    - name: atoi
      scale:
        min: 1
      udf:
        container:
          # Tell the input number is even or odd, see https://github.com/numaproj/numaflow-go/tree/main/pkg/mapper/examples/even_odd
          image: quay.io/numaio/numaflow-go/map-even-odd:v0.5.0
    - name: compute-sum
      udf:
        container:
          # compute the sum
          image: quay.io/numaio/numaflow-go/reduce-sum:v0.5.0
        groupBy:
          window:
            fixed:
              length: 60s
          keyed: true
          storage:
            persistentVolumeClaim:
              volumeSize: 10Gi
              accessMode: ReadWriteOnce
      partitions: 2
    - name: sink-log
      scale:
        min: 1
      sink:
        log: {}
  edges:
    - from: in
      to: atoi
    - from: atoi
      to: compute-sum
    - from: compute-sum
      to: sink-log

Note:
This will not work in below case:

In case of Kafka with 12 partition and 6 partition is assigned to one pod and rest 6 to another, now If only 3 of them is receiving the data out of 6 partition.

I put some comments. Please consider addressing #1385 (comment) . Or create a separate issue to track it. I believe there could be a better way of modularizing the idle source logics.

Created an issue to track it: https://github.com/numaproj/numaflow/issues/1396


Zoom to fit the selection

Hey @ariutta, quick question. Is it possible to make zoom fit the selection? Do you have any examples of this?

There is already a function to zoom on the dbl clicked area enabled with the parameter dblClickZoomEnabled: true
Is that what you're looking for ? Cause I don't think you can select the text in the SVG no ?
Or maybe you'd like to give a text as argument and have the SVG zoom into it ? Cause that's actually what I developed here, and even with a CSS transition zoom and animated svg morphology filter to highlight the text
https://www.homesmartmesh.com/docs/microcontrollers/nrf52/thread_sensortag/?svg=nrf52-sensor-tag&text=VEML6030

Hey @wassfila, what I wanted to do is to fit the zoom, by drawing an are with the mouse. Something like zoom to fit the selection.

I see, then actually you might have to collect the mouse down and mouse up yourself and then take it from there to identify the zoom center and ratio.
You might have to deal with inconsistent aspect ratio of the selection not matching that of the viewport, so you could arbitrarily stick to the width, height or average.
I'm not aware that the library can do that out of the box, but maybe others know more. Would collecting mouse down and mouse up be feasible for you, and would you want to add a drawing of darker or highlight of the selected area ? Cause that's slowly becoming a tool dev which probably was not the scope of this but would be a cool feature.

I will take a different route. Since you said it has to be used with a server I am going to find one to give it a try. Oh, I remember that in the past I was using this with a webserver created in python.