ES6 instructions

Hello + thanks for this!
Trying to plug it in my existing ES6 project i followed the ES6 instructions
after a lot of fiddling, i found this to be working:
import alert from 'vue-strap/src/Alert.vue'
however, by using the examples in the doc i got some errors:
import alert from 'vue-strap/src/alert' errors with Cannot find module 'vue-strap/src/alert' from '/Users/m/dev/php/proj/resources/assets/js/components'
and the other example in doc give another error:
import { alert } from 'vue-strap'; errors with 'import' and 'export' may appear only with 'sourceType: module' node_modules/vue-strap/src/utils/EventListener.js:29
and when attempting to use the dropdown component, not even the trick i mentioned above seems to work (also errors about EventListener.js:29)
so i guess this issue is about if the doc should be updated, or maybe i'm doing something wrong here.
using browserify with babel + vue 1.0 and the vue-strap 1.0.0 release

I'm having the same trouble, any help is welcome!

Update: i use the vueify component with browserify, and according to their docs, it transforms *.vue files and they will need to have extension specified in order to be ES6 imported properly. [1]
I know there is a different stack to build this with webpack, maybe there are differences?
Anyhow, so for browserify you must specify .vue in the import, like
import alert from 'vue-strap/src/Alert.vue'
1: https://github.com/vuejs/vueify

I have the same stack as you.
Still I cannot get the Dropdown to work. Were you able to do that?

@edgarnadal: i got it to work temporary by copying EventListener.js and Dropdown.vue to my project and made a tiny change to EventListener.js to look like this:```
export default {
/**
* Registers a DOM event listener to trigger during the bubble phase.
*
* @param {DOMEventTarget} target DOM element to register listener on.
* @param {string} eventType Event type, e.g. 'click' or 'mouseover'.
* @param {function} callback Callback function.
* @return {object} Object with a remove method.
*/
listen(target, eventType, callback) {
if (target.addEventListener) {
target.addEventListener(eventType, callback, false)
return {
remove() {
target.removeEventListener(eventType, callback, false)
}
}
} else if (target.attachEvent) {
target.attachEvent('on' + eventType, callback)
return {
remove() {
target.detachEvent('on' + eventType, callback)
}
}
}
}
}

its in branch "es6" here: https://github.com/martinlindhe/vue-strap/tree/es6

not at all sure about the "const" keyword in the exports thing there, or what is a proper fix, so i havent done a pull request with it yet. any pointers welcome

@martinlindhe: when i use your fork, I get this error.
ParseError: 'import' and 'export' may appear only with 'sourceType: module'
I didn't go further but I will.

So, I ended up doing it like this, using "vue-strap": "^1.0.0"
var VueStrap = require('vue-strap/dist/vue-strap.min.js')
var Dropdown = VueStrap.dropdown

export default {
    components: { Dropdown }
}```

I think this might have been an artifact of the main attribute in vue-strap's package.json file.
If you can try again with the latest v1.0.3 tag, I'd appreciate the feedback. Let me know if you need more help debugging this.

How do I download the 1.0.3 version? Not on npm yet.

babel the es2015 code
import alert from 'vue-strap/src/Alert.vue'

will get the es5 code
'use strict';

var _Alert = require('vue-strap/src/Alert.vue');

var _Alert2 = _interopRequireDefault(_Alert);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

However, require('vue-strap/src/Alert.vue') is a webpack feature that can require a .vue file.
Therefor, you should either use webpack with vue-loader or use import vueStrap from 'node_modules/vue-strap/dist/vue-strap.js'

I am also having es6 issues, when I include modal like this:
import alert from 'vue-strap/src/Modal.vue'

I am getting
Module parse failed: node_modules/vue-strap/src/utils/getScrollBarWidth.js Line 1: Unexpected token
You may need an appropriate loader to handle this file type.

and
Module parse failed: node_modules/vue-strap/src/utils/EventListener.js Line 29: Unexpected token
You may need an appropriate loader to handle this file type.

I am using webpack with vue-loader.
Seems like I need to configure another loader for these. For .js I have this in my webpack config:
        {
            test: /\.js$/,
            exclude: /node_modules|vue\/src|vue-router\/|vue-loader\/|vue-hot-reload-api\//,
            loader: 'babel'
        }

I think we need to update the documentation + README to better guide you. To include vue-strap in ES6 manner, the babel-loader has to be told to include node_modules/vue-strap/src/ as a valid target for babel loaded files (and even vue-loader'ed files).
In the mean time, I think you probably should consider using the import this way:
import alert from 'vue-strap'

Thanks for the answer!
When I import like this:
import modal from 'vue-strap'
console.log('modal', modal);

Result is the whole vue-strap object:
modal
Object {alert: Object, carousel: Object, slider: Object, accordion: Object, affix: Object…}

So using modal.modal actually works. I just wonder if that would leave me with lots of copies of vue-strap in the build js if I import in several components like this.
Would it be better to just require vue-strap global via commonJS:
VueStrap = require('vue-strap');

@dischinator: this issue is about ES6 support. commonJS/requireJS/AMD is all ES5 hacks because import is not available in ES5

@dischinator  Sorry, my mistake. The proper way would be this
import {alert as Alert} from 'vue-strap'
import {modal as Modal} from 'vue-strap'

export default {
  components: {
    Alert,
    Modal,
  }
};

I just wonder if that would leave me with lots of copies of vue-strap in the build js if I import it in several components like this.

Nope. It doesn't get copied. Babel/Webpack will know about vue-strap, and load that in once. After that it makes copies using require() internally.

@amanpatel thanks a lot and @martinlindhe sorry if I hijacked this issue.

I think the issue is related. I really need to update the README so avoid confusion. WIll do it soon.

For those of you who have no intention of using vueify ES6 or any of that noise, and are using browserify:
In your package.json:
{
  "browser": {
    "vue-strap": ""vue-strap/dist/vue-strap.min.js""
}

And in your client code:
var affix = require('vue-strap').affix;

I'm using Laravel Elixir with vueify and ES6, and I'm getting this error for every component in vue-strap even though I'm only importing Alert:
[09:31:38] gulp-notify: [Laravel Elixir] Browserify Failed!: Cannot find module '-!babel!./../node_modules/vue-loader/lib/selector.js?type=script&index=0!./Typeahead.vue' from '/home/vagrant/Projects/ReflexEngine/node_modules/vue-strap/dist'

Does vue-strap work with ES6 properly yet?

I also get a ParseError: 'import' and 'export' may appear only with 'sourceType: module' when trying to pull in Modal.vue with vueify & watchify. Seems like vueify can’t handle importing ES6 code that lives in a plain .js file: import getScrollBarWidth from './utils/EventListener.js'
The workaround that worked for me was renaming the util js files with a .vue extension and wrapping their content in <script> tags. So I ended up importing a .vue module which works:
import getScrollBarWidth from './utils/EventListener.js'
I know this is probably a bug in vueify but as long as it still exists it could be useful to convert those helper js files to .vue modules.

@mayakokits Tried, but no success.
I just cant recompile the plugin if i need a little change :(

Hi !
Here's what's working for me :
var Modal = require('vue-strap/dist/vue-strap.min').modal;

Maybe not the most ES6 way but at least it does the job.
Xavier

@XavRsl This works with ES6 too..
import {modal} from 'vue-strap/dist/vue-strap.min'

@TylerBre you can actually use the ES6 syntax once you set it up, as per your comments (thanks a lot for that, btw! :))
So instead of doing those silly require() statements once you've set it up in your package.json file, you can use import statements like we all should be doing, properly :)
For those reading, referring to this comment: https://github.com/yuche/vue-strap/issues/55#issuecomment-177370932

import {dropdown} from 'vue-strap'
dropdown, accordion are not working


Download/Upload configuration files?

Feature request
Hi  - having recently transferred my images between cards due to OS upgrade, it would be nice if we could upload & download configuration files. We can already download properties files, but no way to upload them (short of uploading a ZIP containing the file). Would it be possible to:
1 - Add a button to download the selected configuration (json) file
2 - On the upload page, add upload of config files (json and properties) in addition to images & shared.
Thanks,

Here ya go https://github.com/PiSCSI/piscsi/pull/1083

Looks good. Thanks!


[REQ] Add option to skip irrigation if OWM predicts rain in near future

Is your feature request related to a problem? Please describe.
Sometimes the smart irrigation will run just before it starts raining (or even while it is raining). This all depends on the time when the daily volume is calculated and when the automation is triggered obviously.
I guess the rain is still counted towards the next bucket calculation, but anyway, this seems like a waste of water to me.
Moreoever, this could be potentially damaging in case of very intense rain/storms, as the ground will already be "saturated" due to the automatic irrigation, which can lead to quicker flooding, etc.
Describe the solution you'd like
Add an option that allows to delay the irrigation in case of forecasted (heavy) precipitation to avoid unnecessary watering/flooding. For instance:

Check the predicted rainfall for the following hours (or X days ahead) using OWM
If the forecasted precipitations > current_bucket -> Skip irrigation

An other way to do this check would also to try to "predict" the next day bucket directly based on temperature and precipitation forecast. If the next day's bucket is enough to compensate day N and day N+1 water needs, then skip irrigation.
Describe alternatives you've considered
An alternative would be to add a conditional statement in the automation to check if any rain is forecasted or compare the scheduled bucket with the next day precipitation.

I don't see the point either. You can do this in the automation which is atually controlling the irrigation. Let's keep this component as clean as possible!

That makes sense, indeed. Thank you for the answer


gutentags: gutentags: ctags job failed, returned: 255

hi，
I am using gutentags in gvim in windows.
First i create a empty folder called “.project” in my dirctory.
Then when i open the file using gvim, i get the message "gutentags: gutentags: ctags job failed, returned: 255".
I am using univeral ctags and gtags fo windows. It looks like the gtags work correctly.

Hi! Is maybe ctags not in your PATH? Can you do :let g:gutentags_trace = 1 and report back on what it says in both Vim's messages and in the tags.log file left behind?

I meet the same problem in window 7 with Gvim 8.1, can you help to solve it? Thank you very much!

Thanks! What's in the .log file that's listed at the end of the command line in that first screenshot?
Alternatively, have you pulled the Gutentags code recently? The log gets sent back to Vim so that if you type :messages you'll also see that log info.

Here is the message.

大兄弟，我也遇到这个情况， 我是/plat/unix/文件夹中的 $CTAGS_EXE 不是GNU的ctags ，我直接 把 $CTAGS_EXE 这个变量 hard code换成ctags 执行的绝对路径，比如 /usr/bin/ctags

@coder2018cp The job output looks weird -- maybe unicode characters that are getting messed up by either Gutentags or Vim or something?
Copy the command line after the Running: 'C:\Users\....' and try to run it manually, from inside F:\study\net_study\game.io. That should let you troubleshoot what's wrong.

The bug is at /plat/win32/update_tags.cmd
when it is parsing "-t" option:
-t "C:\Users\zoumi.cache\tags\E--Program_Files_(x86)-Vim-tags"
it get the error.

You can see there is another bug:
In my case, tag file should be "C:\Users\zoumi.cache\tags\E--Program_Files_(x86)-Vim-\tags"
not
"C:\Users\zoumi.cache\tags\E--Program_Files_(x86)-Vim-tags"

I think this issue related to
-o "c:\program files (x86)..."
cant pass (x86)   to  ctags
I changed source code not using  "res\ctags_rever...options"

Any update on this? Can (x86) be escaped somehow?

I have the same problem. Is there any further solution to this problem?

I meet the same problem in window 7 with Gvim 8.1, can you help to solve it? Thank you very much!
The gunentags config in my vimrc is below

And, the ctags I use is universal-ctags.

我的问题跟你类似，我把vim安装目录和配置文件从program files目录移到了d:\tools目录下就完全好了，应该是不支持windows的带空格的目录名造成的。


Create a Fake/Virtual ChromeCast device

Hello guys,
Can the SDK help create a Fake/Virtual ChromeCast device ?
Because i need this feature to create a ChromeCast device proxy for my personal usage.
kind regards
Thomas

This is a client SDK so it's not going to support your needs out of the box.
You could build a server SDK based on this but it would be a lot of work


Fix a bug in atom-centered shape layout

Somehow this slipped through the cracks. Arrows (and any atom-centered shape)
were positioned at the origin rather than at the atomic sites.
Just to upset @rosecers I also included a few unrelated changes to avoid datafile bloat,
and to make her happy I added some extra comments to the shape code.

-_-


loggable - dont log if nothing changed

Hi,
ive integrated loggable like this:
gedmo_loggable:                 type: annotation                 prefix: Gedmo\Loggable\Entity                 dir: "%kernel.root_dir%/../vendor/gedmo/doctrine-extensions/lib/Gedmo/Loggable/Entity"                 alias: GedmoLoggable # (optional) it will default to the name set for the mapping                 is_bundle: false
When i update my entity it will be saved twice. Why? Because if have 2 flushes in my Controller. I need them. If i set $em->detach on my entity after first flush i will get only 1 Log entry. This is a big project and i have no time to correct every function. Is there a way to check if the versioned fields changed and only than save the log entry?
Second Problem, the entity was saved in log but i dont changed a @Gedmo\Versioned field. I only want to save in the log table if one of the versioned fields changed. Can this be configured?
Thanks in advance

Ok ive found the problem. Some of my entities have encrypted fields. I am using https://github.com/ambta/DoctrineEncryptBundle for the encryption. So when the logger gets the old and the new data, the old data is the encrypted string and the new data is the decrypted string. So i need to decrypt the old value. How can this be done in an custom Listener?

Ive fixed it. Ive removed the SoftDoctrineBundle and created my own LoggableListener which extends the GedmoListener. In this listener i am getting the encryptor and encrypt the new value to compare with the old encrypted value.
I hope someone will help this


Set preset volume on start

Hi there,
Awesome work btw and thank you for sharing this!
I would like to set a pre-set volume when the bot starts.
Can you guide me on what line can I add to main.js or config.js for this?
Thank you!!

Hello!
You can change pre-set volume with simple easy steps!
Goto commands -> music -> play.js and click Edit button(on github you can edit on your computer/server)
and after this line:
res.playlist ? queue.addTracks(res.tracks) : queue.addTrack(res.tracks[0]);

add this:
queue.setVolume(35);

Awesome! Thank you so much for helping me out! Thank you for sharing your awesome creation too this is a life saver! Quality is so much better too especially when playing music from a locally hosted server :D


Fix alias, maintain column sort order

This PR fixes a couple issues.
Aliasing was no longer working per this issue:
Fixes https://github.com/influxdb/influxdb/issues/3530
Also, we were not maintaining column select order in our results.  For example, if we issued select foo, bar from baz the column order in the return would be bar, foo, not foo, bar.  This is now corrected.

+1

+1


Use same fd for concurrent reads

What changes are proposed in this pull request?
Use same fd for concurrent reads in alluxio-fuse.
Why are the changes needed?
Fix #17025 .
Please check https://github.com/Alluxio/alluxio/issues/17025#issuecomment-1619726738 for details.
Does this PR introduce any user facing changes?
NO

@yyongycy @LuQQiu can you help review this?

Since the 3.0 is the new arch, is the original investigation still true? Or you had checked based on new code?

Since the 3.0 is the new arch, is the original investigation still true? Or you had checked based on new code?

I am not sure. I haven't tested the case based on the DORA architecture. It's ok to put this PR aside until testing it with the new arch.
@yyongycy Is there any potential risk to apply this PR to the master-2.x branch from your side? We are still using master-2.x and need some time to upgrade.

So you have a reference count, had you tried to see if the concurrent read would work?

So you have a reference count, had you tried to see if the concurrent read would work?

I have test it in #17025 and it works well, with much improved performance.


Using react-native-mock with storyshots will raise abnormal Error messages

 Issue by xareelee
Thursday Mar 16, 2017 at 02:00 GMT
Originally opened as https://github.com/storybooks/storyshots/issues/85

I'm developing React Native (RN) apps for iOS and Android.
I use storyshots/storybook to snapshot the vDOM(s) of RN components with specific props for UI tests.
However, Jest lacks the functionality to mimic RN events to test whether the buttons work correctly. Then I found airbnb's enzyme.
When I tested RN components with enzyme, I needed to install and set up react-native-mock. Then the issue happened:
Before I introduced react-native-mock to my project, I had an unsolved snapshot conflict.
  ● Storyshots › LoginMsg › entry

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot 1.

    - Snapshot
    + Received

    @@ -314,42 +314,49 @@
               />
             </View>
           </Modal>
           <View
             style={
    -          Object {
    -            "alignItems": "center",
    -            "backgroundColor": "#F7F7F7",
    -            "flex": 1,
    -            "justifyContent": "center",
    -          }
    +          Array [
    +            Object {
    +              "alignItems": "center",
    +              "backgroundColor": "#F7F7F7",
    +              "flex": 1,
    +            },
    +            Object {},
    +          ]
             }
           >

After I add react-native-mock, the test error became:
  ● Storyshots › LoginMsg › entry

    TypeError: _setter is not a function

      at Component.requestAnimationFrame (node_modules/react-timer-mixin/TimerMixin.js:16:14)
      at Component.componentDidMount (node_modules/react-native/Libraries/Components/TextInput/TextInput.js:567:6)
      at node_modules/react-test-renderer/lib/ReactCompositeComponent.js:265:25
      at measureLifeCyclePerf (node_modules/react-test-renderer/lib/ReactCompositeComponent.js:75:12)
      at node_modules/react-test-renderer/lib/ReactCompositeComponent.js:264:11
      at CallbackQueue.notifyAll (node_modules/react-test-renderer/lib/CallbackQueue.js:76:22)
      at ReactTestReconcileTransaction.close (node_modules/react-test-renderer/lib/ReactTestReconcileTransaction.js:36:26)
      at ReactTestReconcileTransaction.closeAll (node_modules/react-test-renderer/lib/Transaction.js:206:25)
      at ReactTestReconcileTransaction.perform (node_modules/react-test-renderer/lib/Transaction.js:153:16)
      at batchedMountComponentIntoNode (node_modules/react-test-renderer/lib/ReactTestMount.js:69:27)

I think react-native-mock changes the behavior of storyshots, and make it report conflict incorrectly.
I'll post this issue on both storyshots and react-native-mock.
#react-native-mock/issues/126

@xareelee thanks for reporting this. By the sounds of the linked issue, the problem is with react-native-mock and Jest. Did you find a workaround?
I'll close this as it doesn't sound like there is much we can do. Let me know if not.


feat(linting): add golangci-lint

A fast Go linters aggregator for Gophers.

There's also a golangci-lint LSP through Mason. Not sure if this is really needed?

@fredrikaverpil the golangci-lint-langserver provides full LSP support, which includes features like hover documentation and more.
Integrating golangci-lint via nvim-lint or none-ls is simpler, especially for basic linting needs.


feat: add new method to NodeRef

Adds a new method to NodeRef.
This PR also implements Default for NodeRef (as was suggested by clippy).
Additionally removes the old cx being used in the docs for create_node_ref, and fixed some indentation there too.

Looks good, thanks very much!


:boom: Client: Rename Channel.UpdateBy -> Channel.Update

Location
client/update.go
Problem
At some point we introduced Channel.UpdateBy as a safe method for updating a channel. The previous method Channel.Update exists but is rarely used. Having the two methods may cause confusion.
Proposal
Remove Channel.Update in favor of Channel.UpdateBy and rename Channel.UpdateBy to Channel.Update.

Relates to #155


ccx: Telemetry Driver

Create Telemetry Driver
Interface: LPUART4
Device: MAX3232MPWREP
Product Page
Datasheet

NuttX already has a serial driver. Should it be the wrapper for the serial driver? or can it just be the app?
What's the data format if any?


Set up CodeQL scanning

Sets up CodeQL scanning to detect security vulnerabilities and coding errors. See about code scanning for more info on CodeQL and Github code scanning.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: skirby1996:white_check_mark: calebmshafer:x: kaung001You have signed the CLA already but the status is still pending? Let us recheck it.

Closing and remaking in https://github.com/iTwin/itwinjs-core/pull/4328 due to some commits using an email not registered with our CLA tool.


The variable $privateEndpoint is not initialized.

[Enter feedback here]
I can't figure out how to initialize the variable $privateEndpoint in
$nic = Get-AzNetworkInterface -ResourceId $privateEndpoint.NetworkInterfaces[0].Id
during mount azure file share local.
Many thanks for your help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4387410-73b7-a07e-708c-eeac4e81397f
Version Independent ID: aaaab239-4acf-d9ea-c3a6-9abb0cdbb623
Content: Configure a Point-to-Site (P2S) VPN on Windows for use with Azure Files
Content Source: articles/storage/files/storage-files-configure-p2s-vpn-windows.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@AliManouchehri Thanks for the question. We are investigating the issue and will update you shortly.

@AliManouchehri  Firstly, apologies for the delay in responding here and any inconvenience this issue may have caused.
I have assigned the issue to the content author to investigate further and update the document as appropriate.

#assign:wmgries


Verifiable encryption decryption

This branch includes the verifiable encryption and decryption functionality. You can reproduce the minogrpc error by running this test.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Mahsa-Bastankhah:x: Mahsa BastankhahMahsa Bastankhah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I didn't mean to close this, I was hoping it would automatically move the PR to the master branch...


Add support for app updates

The app updates logic leverages Erebos' Timeline API, so it's a breaking change from the previous app installation data structure. Developers will need to publish their apps again in order to support updates.
Among the changes:

Updates Erebos to v0.7, as well as other dependencies that didn't have major changes
Some changes to the GraphQL schema to make types more strict
Refactoring of the apps management UX and some of the related components

@diogoperillo I'm merging it now so it doesn't get stale, let's make the necessary UI changes in a separate branch.


Branch/vf2 optimisations

Reference Issue

What does this implement/fix? Explain your changes.
Optimisations ahead of tomorrows talk. Undirected graphs so can use half the memory by only needing 2 rather than 4 terminal sets.
Any other comments?
WIP - More to come but need to figure out the boost calls to get neighbours.

Rather than do a PR for a simple change, I just edited the files directly.
The relevant calls to get iterators over neighbors or edges are:
boost::adjacent_vertices(at->getIdx(), d_graph) and boost::out_edges(at->getIdx(), d_graph);

Perfect thanks, boost::adjacent_vertices(at->getIdx(), d_graph) is what I needed

BTW what is the best way to run the tests? I tried make test but seems to get stuck on 19/98:
16/98 Test #16: graphmolcpTest .....................   Passed    0.02 sec
      Start 17: graphmolqueryTest
17/98 Test #17: graphmolqueryTest ..................   Passed    0.02 sec
      Start 18: graphmolMolOpsTest
18/98 Test #18: graphmolMolOpsTest .................   Passed    1.85 sec
      Start 19: graphmoltestCanon

It's odd that it would just stop. That particular test can take a while to run; are you sure it's just not done yet?
FWIW: I normally run the tests with ctest -j4 --output-on-failure

I just did some quick benchmarking of the code in your branch. I'm using some of the benchmarking code that's included with the RDKit for this, specifically tests 0, 4, and 7 from: $RDBASE/Regress/Scripts/new_timings.py

Test 0 reads in 50K molecules to be queried (so it shouldn't be affected here)
Test 4 runs HasSubstructMatch() with 823 fragments of molecules (constructed using a BRICS fragmentation of the pubchem screening molecules, more info in here: https://www.rdkit.org/UGM/2012/Landrum_RDKit_UGM.Fingerprints.Final.pptx.pdf)
Test 7 runs HasSubstructMatch() with 428 SMARTS patterns from a set Richard Lewis (at NIBR) curated quite a long time ago

When I run this on my machine for master I get:
  ....
| 2019.09.1dev1 | 8.5 | 0.0 | 33.1 | 0.0 | 102.1 |

For your branch with #define RDK_VF2_PRUNING:
 ...
| 2019.09.1dev1 | 8.4 | 0.0 | 29.6 | 0.0 | 94.5 |

and for your branch without #define RDK_VF2_PRUNING:
 ...
| 2019.09.1dev1 | 8.5 | 0.0 | 28.7 | 0.0 | 92.1 |

So the changes, in general, improve search speed by about 10%. Disabling pruning helps a bit.

Okay all done for now... Have broken things up so hopefully should be simple to follow be feel free to squash it all down.
In the end I removed the need for a template template by adding member functions that do the recursion. Also in the final commit I add a struct for the pair handling that simplifies the code. I was hesitant to do this as it's in the header file and this is really an internal detail. Feel free to leave the struct out but there shouldn't be much/any speed impact.
Let me know if you have any questions.
Hopefully see improvements clearer with a benchmark set, but actually do see a bit of improvement in testSubstructMatch.
Master:
$ time ./Code/GraphMol/Substruct/testSubstructMatch
...
real	0m0.439s
user	0m0.496s
sys	0m0.075s

PR:
$ time ./Code/GraphMol/Substruct/testSubstructMatch
...
real	0m0.297s
user	0m0.323s
sys	0m0.073s

Sorry didn't see the comment before I updated.. yeah about what I expected not a huge win from disabling pruning - only for some graphs.

Hmm.. I did run the tests locally but only have 98 when I run as don't build with python will update.

Updated timings, with pruning:
| 2019.09.1dev1 | 8.4 | 0.0 | 21.7 | 0.0 | 80.8 |

without pruning:
| 2019.09.1dev1 | 8.2 | 0.0 | 20.9 | 0.0 | 77.3 |

This is quite nicely faster than the older version. :-)

Unfortunately the new code can return symmetric results in a different order than what we previously were getting. This breaks a few of the tests. I will look through each of them and make sure that the new results are correct and then either submit a PR against yours or edit the files directly.

Ah okay, sorry yes was going to look at it today but that makes sense. I guess the assertions could be updated to first sort the permutations lexicographically. Will stay take a look as got the missing boost-python installed now.

@johnmay : I didn't completely understand that last comment, sorry. Are you planning further changes or should I go ahead and merge as-is?

Sorry, bit mad here as moving office this week! My intention was to look through the failures but you got most of them in your PR. It looks like there's one left in the Java again potentially to do with the different ordering but have not investigated yet.

Ah, I hadn't paid attention to the build results.
I just did a PR with an update to the Java tests.

@johnmay : I think this could be merged as-is, but it would be nicer if it returned the same matches as the older version (i.e. lower-indices are matched first in the symmetric case). Aside from the nice feature of not changing the output, this would make it easier to explain which result is returned first. Do you think it's a ton of work to make that change?

It is possible but more expensive for little gain, personally I wouldn't add it as it's similar to having the order of a SMILES string change the results.
Essentially you need to add a sort, you could do this afterwards (e.g. in the collector) but there is no guarantee it would be correct if the max results count has be reached. In which case the better option is to sort the neighbour list in the NextPair function.
IMHO the correct "fix" is downstream methods that should be considering the automorphisms need to consider the automorphisms.

I agree completely, but if it would have been easy to do without much of a performance penalty, it would have been nice to maintain consistency of results. Since it's not... we'll take the speed up!

Thanks @johnmay !


Test failure after adding transaction progress streaming

Describe the bug
In PR #3559 transaction progress streaming was added and seems to work in manual testing with pcli, however the PR unexpectedly introduced test failures in CI. I tried replicating them locally but was unable to.
I spent some time paring down the test suite in that PR and this is what I found:

The failing test is the transaction_sweep test
When only the transaction_sweep test is present in CI, the smoke tests pass, indicating an inter-test conflict
When the test_orders test is reintroduced alongside the transaction_sweep test, the failure begins to occur

Steps to resolve

[ ] Diagnose and fix the specific side effect causing failure between the two tests
[ ] Revert the test and debug logging changes made to #3559
[ ] Merge #3559

Additional Context

Failing test logs: https://pipelinesghubeus24.actions.githubusercontent.com/R2lw3E60pazr4YaDy7dN23NWI8as2DqxhqIHvScbTqcm1hgS7g/_apis/pipelines/1/runs/27225/signedlogcontent/2?urlExpires=2024-01-17T19%3A19%3A13.0627912Z&urlSigningMethod=HMACV1&urlSignature=uCKoTFDHx8nsLblf24S8PBWQIIWKwAdFih3qSzMIxDA%3D

I think the url is expired

Discussion udring sync: the two failing tests are swap and sweep. I've noticed when running locally that if I remove the sweep test entirely, then swap starts failing again. Odd. That's an interaction we need to explore further.
However, #3559 remaining unmerged is blocking web team progress, so I'm going to disable sweep for now, get 3559 to green, and then continue investigation after the core logic has landed.


Fix memory defects in http server tests

In this PR I'm fixing memory defects in http server tests. At the current time we should explicitly set timeout to avoid memory defects on client. I will continue investigation of possible memory defects in client.

Codecov Report

Merging #481 into master will increase coverage by 0.51%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   67.51%   68.02%   +0.51%
==========================================
  Files          49       50       +1
  Lines        6836     6840       +4
==========================================
+ Hits         4615     4653      +38
+ Misses       2221     2187      -34

Impacted Files
Coverage Δ

src/client/client.cc
83.33% <0%> (+3.21%)
:arrow_up:

include/pistache/common.h
100% <100%> (ø)

src/common/os.cc
54.72% <0%> (+0.67%)
:arrow_up:

include/pistache/async.h
90.25% <0%> (+1.39%)
:arrow_up:

src/common/net.cc
85.71% <0%> (+1.64%)
:arrow_up:

include/pistache/net.h
90% <0%> (+5%)
:arrow_up:

src/common/timer_pool.cc
91.89% <0%> (+18.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd8f70...2cd5416. Read the comment docs.

Why not put a default timeout in every request method instead of just the test case. This leak will occur when you repeat the same pattern try to get without being explicit and put a timeout in your request.


xlink:href filename#id renders as #id only

In IE 11, when using svgxuse.js I noticed that my xlink:href value in the source code is not the same as what renders in the DOM.

    <svg class="icon icon-palette"><use xlink:href="symbol-defs.svg#icon-palette"></use></svg>

turns out like this:

    <svg xmlns="http://www.w3.org/2000/svg" class="icon icon-paper-plane">
        <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-paper-plane" />
    </svg>

This is a problem if you are switching svg files dynamically. Without the full path, IE keep referencing the previous file. I run into this problem because we have icon sprite sheets for multiple sizes and #id points to multiple matches as I switch around sprite sheets.
I have:
icons.svg
/24/icons.svg
/48/icons.svg
All of them have the same set of icons (same id's) but the larger icons have more detail. if I swap the url in the xlink:href using JavaScript, I end up rendering the wrong svg because svgxuse.js trims everything but the #.

+1

Was this fixed?  The author of the PR above seems to have given up

This isn't inherently a bug this is how the library operates. It replaces the href because the svg is attached to the current body so it only needs the #id to reference it.
If you want to dynamically switch you will have to insert the whole path again. And then if it fails to load in IE11 the library will attach the new svg to the body again and change the href to only an #id again.


filesDownload throws when there is no file to download

When calling filesDownload for an inexistent file it throws the following exception:
VM23710:1 Uncaught DOMException: Failed to read the 'responseText' property from 'XMLHttpRequest': The value is only accessible if the object's 'responseType' is '' or 'text' (was 'blob')
    at Error (native)
    at eval (eval at evaluate (unknown source), <anonymous>:1:9)
    at Request.eval (eval at <anonymous> (http://localhost:8080/app.js?22121933094bd80a6063:13:100), <anonymous>:506:45)
    at Request.Emitter.emit (eval at <anonymous> (http://localhost:8080/app.js?22121933094bd80a6063:46:3874), <anonymous>:133:20)
    at XMLHttpRequest.xhr.onreadystatechange (eval at <anonymous> (http://localhost:8080/app.js?22121933094bd80a6063:13:100), <anonymous>:886:10)

From the stack trace, it look like the problem lies with the superagent lib used by dropbox.
Chrome 54, dropbox-2.4.0

Thanks for the report! We'll look into it.

@greg-db Hi Greg, is there any progress on this? The issue still exists with current dropbox js client. I haven't found a way to catch this error yet.

I don't have an update on this right now. We'll follow up here once I do.

Facing the same error.
The only workaround I've found so far is to make a filesGetMetadata request before every filesDownload. Only if filesGetMetada returns without an error, make a filesGetMetadata request.

Same issue. This prevents .catch from firing, meaning that anything short of what @adityabhaskar  suggested is rather unsafe.

Any ETA on a fix?

No, unfortunately I don't have an ETA on this right now. We'll follow up here once we have an update for you.

@greg-db do you have any updates?
This issue is so old ((
I am waiting so long...

@MsSterh No, unfortunately I don't have an update on this yet. We'll follow up here once we do.

Just to add some color to this, this may not just be a problem with the usage of superagent. I noticed that the response headers from the server have no metadata explaining why it failed.
Response headers:
Access-Control-Allow-Origin:*
Access-Control-Expose-Headers:Accept-Ranges, Content-Range, ETag, Dropbox-API-Result
Connection:keep-alive
Content-Type:application/json
Date:Tue, 26 Dec 2017 06:04:51 GMT
Server:nginx
Transfer-Encoding:chunked
X-Dropbox-Request-Id:ff8fb1c50c8f2184ad763892f256e8d4
X-Robots-Tag:noindex, nofollow, noimageindex

Thanks for the information @cliffspradlin! For reference, the status line does include the nested error as you mentioned, and the response body itself (not shown) also includes the error information as JSON.


If embedding policy requires systematic action names - find easy way to create features

@Ghostvv I think the current gist is that the embedding policy does require systematic action names, right?

Looking from the graphs, for small data it works better than keras even with binary featurizer, though it drastically benefit from systematic naming of actions

Ok, so what are the next steps here or do you want to close this?

I'd say perform experiments you suggested during my presentation. But I'd open source it first to see if anybody will use it. Maybe some more important issues will appear


Add checkstyle to CI

We should run checkstyle in CI to test that we follow the style guide in CS2103t.

Already in CI actually.


We need to be able to receive notifications after a reboot!

Description
Description of the feature or fix with link to the issue if existing
On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[ ] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Please attach screenshots showing the change if relevant
Checklist

[ ] I have updated mockServer
[ ] I've added analytics as relevent
[ ] I have run npm test
[ ] I have run npm run test:i18n

Out of scope and potential follow-up
Is there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

Inviting some opinions from the team: will this change fix our problems without introducing other problems for people on upgrade, e.g. if we end up requesting additional permissions and this causes friction / customer support impact?
It is my reading of the docs that "android.permission.RECEIVE_BOOT_COMPLETED" is considered a normal-level permission which no Android system would bother to prompt the user for (because the user cannot say no!).
See: https://developer.android.com/guide/topics/permissions/overview#normal-dangerous
And the reference list here: https://developer.android.com/reference/android/Manifest.permission

Put in review im good to try it

@the-kenneth I've done no build / no testing, except to verify that the existing app exhibits a failure to receive notifications after a restart (using the expo tester here https://expo.io/notifications against my personal expo token).  Is this something you would take over on my behalf?

I tested with this on and off and in both situations I was able to receive notifications after restarting even when not reopening the app. It did take a few mins sometimes to get them after a reset but they did all come through.


Add Academia International College

official domain: https://academiacollege.edu.np/

@bichitra-linux First stage of verification passed, official domain is academiacollege.edu.np as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@bichitra-linux Pull request merged. Thank you.


Spelling of inferable/inferrable

I searched the document for "inferrable" and had 25 matches (both "inferrable" and as a substring of "uninferrable").  Searching for "inferable" gives 33 matches (also for both terms).
For instance, table 3.1 has different spellings back-to-back:
8: Uninferable call;
9: Inferrable call;

It appears that both spellings may be correct but I suggest that just one be used for consistency and for searchability.

I noticed that also.
A web search seems to indicate that both can have either one or 2 "R"s; I didn't see a preference for one or the other. In the spec, I think the two words are consistent within themselves, at least.


version-history page has not updated

version-history page has not updated.
https://github.com/projectkudu/kudu/wiki/Version-history
That page is helpful for us. I'd like to update that.

Updated!


Is there any api for resizing webview?

This is amazing plugin and I try to make new UX for web browser vr. It will be really great if there is function for resizing it. But I can't find it. I don't know what I missed it.

Webview resizing is an unimplemented feature, but I would like to implement it in a future update.

Resize API added in latest commit
https://app.gitbook.com/o/BEOtLe2RJogUYj62ljWp/s/mRKt4CGSxyWYs97naGI6/documentation-en/scripting-api#resize


Customizable greeting screen

Issue
The GreetingScreen is currently rendered using Javascript, and the content is hardcoded into the client.
As a step to allow the client to be used by different realms, the content of the greeting screen should be extracted out into a separate HTML-file so that the web server may serve the file with different content based on realm.

Resolved in PR #208


eco drop - wrong supply displayed

Hi Viki. Same issue as yesterday with rapha nyc's drop:
Art card shows 256:

Correct would be 64:

Should be fixed imo

yes perfect thx


Swagger 2.0 reusable parameters supported?

Version 2.9.0.
Question.
Swagger 2.0 supports reusable parameters:
They are defined at top level:
"parameters": {
  "skipParam": {
    "name": "skip",
    "in": "query",
    "description": "number of items to skip",
    "required": true,
    "type": "integer",
    "format": "int32"
  },
  "limitParam": {
    "name": "limit",
    "in": "query",
    "description": "max records to return",
    "required": true,
    "type": "integer",
    "format": "int32"
  }
},

And they can be reused (referenced) in multiple operations:
  "paths": {
    "/pets/{id}": {
      "get": {
        "description": "Returns pets based on ID",
        "summary": "Find pets by ID",
        "operationId": "getPetsById",
        "parameters": [
          { "$ref": "#/parameters/skipParam" },
          { "$ref": "#/parameters/limitParam" }
        ],
      }
    }
  },

Since i have lot parameters reused for multiple operations, this feature would save a lot of repetition in documenting these common parameters.
Does springfox-swagger2 support this feature? If yes, how?
PS: I know springfox has feature Docket.globalOperationParameters but it duplicates parameters for each operation in resulting api-docs JSON, instead of using $ref. And it also cannot be used. Also, globalOperationParameters is unusable, if only several, but not all operations have the parameter.

Short answer is that this isnt supported, as it would go against goals of springfox project.
For more details, see question on stackoverflow that is commented on by @dilipkrish.
Closing the issue.

@smitalm Just to clarify, when you use request and response bodies, it is implicitly reused. For e.g. if you have an endpoint
Customer get(id)
void update(Customer)

It is implicitly reused in the schema. The reuse that isn't currently possible, that I can see some value in is reusing sets of scalar request params e.g. Paging parameters.
List<Customer> findCustomers(criteria, current, offset, pagesize)
List<Order> find0rders(criteria, current, offset, pagesize)

In anycase, since its generated by code it shouldn't matter, unless you want that level of reuse in client code generation.


Does OVN support DPDK?

In case of br-int has dpdk interfaces below:
    Bridge br-int
        fail_mode: secure
        datapath_type: netdev
        Port tunbond
            Interface tun0
                type: dpdk
                options: {dpdk-devargs="0000:1a:00.1", n_rxq="2"}
            Interface tun1
                type: dpdk
                options: {dpdk-devargs="0000:d8:00.1", n_rxq="2"}
        Port br-int
            Interface br-int
                type: internal

We need to configure to ovn-encap-ip in the external-ids option
ovs-vsctl set open . external-ids:ovn-encap-ip={IP ADDRESS}

However, the dpdk interface does not have an ip adress.
Is there any other command for configure overlay?

Since OVN is one layer above OVS, It should be transparent to OVN.
I think OVN does support DPDK.
I don't think there is any other way. ovn-controller expects external_ids:ovn-encap-ip to be configured.

Closing this issue. Please reopen if something needs to be done in OVN.
Thanks


Add selenium debug support.

We can use VNC to watch the end to end test process in real browser (firefox and chrome).
@martinpitt, could you please forward port 5901 and 5902 in selenium VM? Thanks.

[x] enable -debug containers on Cockpit selenium VM: https://github.com/cockpit-project/cockpit/pull/10191

could you please forward port 5901 and 5902 in selenium VM? Thanks.

This is not a property of the images, but you set this up in the testvm.VirtNetwork(0) call in welder's check-application. Something like testvm.VirtNetwork(0, forward={ "5901": 5900, "5902": 6900}). The key is the port in the VM, the value is the port number on the host. The actual port number is that base number plus some number to avoid conflicts (depending on how many tests run in parallel).

I now landed the selenium image changes to have the -debug variants. So this needs a rebase, and the above changes.

@martinpitt, updated based on your comments and some new thoughts. Could you please review it? Thanks.

@martinpitt, thanks for your feedback. Updated.


Missing image in section 1.3.2 data agreement spec

Please add this pic: images/data-agreements-ds-dus.png

Picture was missing. Uploaded the pic.


Issues with AUR pkgbuild and this repo

Hello
Issues with this repo:

No license specified, in the AUR pkgbuild is written GPL but that is what is written in the example
Binary package commited in a source repo 1 2
Could add tags/versions; then in the release page packages can be added

Issues with the pkgbuild

disguised -git (VCS) pkgbuild https://wiki.archlinux.org/title/VCS_package_guidelines, no fixed releases exist
Old faugus artefacts still present in the AUR git repo (faugus-launcher.py, etc)
Missing contact info
No correlation between pkgver= and source=(); missing pkgver() function
git is a makedepends=()
is not welcome to update the pkgbuild for every change in the source repo

You can find a revisioned pkgbuild here https://github.com/FabioLolix/AURFIX/blob/main/f/faugus-launcher-git/PKGBUILD
Git diff: https://github.com/FabioLolix/AURFIX/commit/16468473080debeec684d16d650e3bde0be5c44c

Thanks.

Old faugus artefacts still present in the AUR git repo (faugus-launcher.py, etc)
I've no idea how to remove them.


Rocket.Chat dialog.about.errorWhileLookingForUpdates when checking for updates

My Setup

Operating System: macOS 10.15.3

App Version: 2.17.3 + 2.17.5

Installation type: dmg

I have tested with the latest version (trying to update to latest version, so...)

I can simulate the issue easily

Description

Current Behavior
dialog.about.errorWhileLookingForUpdates
Expected Behavior
Should offer 2.17.5 update

Windows versions 2.17.3-2.17.5 has that same bug too.

Same problem with version 2.17.3 on Windows. I tested with two network connections, Wifi and RJ54. Without proxy.

For what it's worth update to 2.17.7 did show and execute as expected.Closing.

I don't know, but 2.17.7 show me the same error

[bugsnag] Loaded! Checking for update Error: Error: Cannot find latest.yml in the latest release artifacts (https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml): HttpError: 404 Not Found "method: GET url: https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml\n\nPlease double check that your authentication token is correct. Due to security reasons actual status maybe not reported, but 404.\n"Headers: {   "date": "Wed, 12 Feb 2020 04:03:38 GMT",   "content-type": "text/plain; charset=utf-8",   "transfer-encoding": "chunked",   "server": "GitHub.com",   "status": "404 Not Found",   "vary": "X-PJAX, Accept-Encoding, Accept",   "cache-control": "no-cache",   "set-cookie": [     "_gh_sess=OW9JN01OOGNiU0VVTUp0NUtzU1pZcVVkUzJHRXRoRXFES0Z0YlFheXJiaWpMUE9EVHpSa2MveU9mNU5EdDI3ZHlkSXBwMFRGV1FMYlBZSHk1aVczdnRJd0sxWDNTR2ppbHJ2QjZ2bG9abWhpMVFyWStMSFBFdDF1YnhtSWN0R09IUTlUT243Wml3VmRzOVRkb09yT3V1Y1JNalJZUURVdzdCTlZWem9PM2xCWmdjYjU2Nm96WnV1WW84dGxHTWhVZFRxYjRFbmg3Um5MemlkajVzeWV4L3FnK3c5bE1tMEVrSDc2cmlUR3R4R0FkbDRPQU1sRmUzbCtiSWVIRWRvKy0ta3pQQ1NNM0l1OXBsMG1QeFNBSHpRdz09--c2af9936bc7111955229d066e0f18a26bdd9be0a; path=/; secure; HttpOnly"   ],   "strict-transport-security": "max-age=31536000; includeSubdomains; preload",   "x-frame-options": "deny",   "x-content-type-options": "nosniff",   "x-xss-protection": "1; mode=block",   "expect-ct": "max-age=2592000, report-uri=\"https://api.github.com/_private/browser/errors\"",   "content-security-policy": "default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'",   "content-encoding": "gzip",   "x-github-request-id": "E572:1C881:15979C:21E89E:5E43791A" }     at createHttpError (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:84:10)     at ElectronHttpExecutor.handleResponse (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:168:14)     at ClientRequest.<anonymous> (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:134:16)     at ClientRequest.emit (events.js:203:13)     at ClientRequest.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2536:12)     at SimpleURLLoaderWrapper.emit (events.js:203:13)     at SimpleURLLoaderWrapper.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.topLevelDomainCallback (domain.js:131:23)     at newError (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\index.js:212:17)     at GitHubProvider.getLatestVersion (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\out\providers\GitHubProvider.js:134:50) Error: Cannot find latest.yml in the latest release artifacts (https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml): HttpError: 404 Not Found "method: GET url: https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml\n\nPlease double check that your authentication token is correct. Due to security reasons actual status maybe not reported, but 404.\n"Headers: {   "date": "Wed, 12 Feb 2020 04:03:38 GMT",   "content-type": "text/plain; charset=utf-8",   "transfer-encoding": "chunked",   "server": "GitHub.com",   "status": "404 Not Found",   "vary": "X-PJAX, Accept-Encoding, Accept",   "cache-control": "no-cache",   "set-cookie": [     "_gh_sess=OW9JN01OOGNiU0VVTUp0NUtzU1pZcVVkUzJHRXRoRXFES0Z0YlFheXJiaWpMUE9EVHpSa2MveU9mNU5EdDI3ZHlkSXBwMFRGV1FMYlBZSHk1aVczdnRJd0sxWDNTR2ppbHJ2QjZ2bG9abWhpMVFyWStMSFBFdDF1YnhtSWN0R09IUTlUT243Wml3VmRzOVRkb09yT3V1Y1JNalJZUURVdzdCTlZWem9PM2xCWmdjYjU2Nm96WnV1WW84dGxHTWhVZFRxYjRFbmg3Um5MemlkajVzeWV4L3FnK3c5bE1tMEVrSDc2cmlUR3R4R0FkbDRPQU1sRmUzbCtiSWVIRWRvKy0ta3pQQ1NNM0l1OXBsMG1QeFNBSHpRdz09--c2af9936bc7111955229d066e0f18a26bdd9be0a; path=/; secure; HttpOnly"   ],   "strict-transport-security": "max-age=31536000; includeSubdomains; preload",   "x-frame-options": "deny",   "x-content-type-options": "nosniff",   "x-xss-protection": "1; mode=block",   "expect-ct": "max-age=2592000, report-uri=\"https://api.github.com/_private/browser/errors\"",   "content-security-policy": "default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'",   "content-encoding": "gzip",   "x-github-request-id": "E572:1C881:15979C:21E89E:5E43791A" }     at createHttpError (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:84:10)     at ElectronHttpExecutor.handleResponse (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:168:14)     at ClientRequest.<anonymous> (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:134:16)     at ClientRequest.emit (events.js:203:13)     at ClientRequest.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2536:12)     at SimpleURLLoaderWrapper.emit (events.js:203:13)     at SimpleURLLoaderWrapper.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.topLevelDomainCallback (domain.js:131:23) Checking for update Error: Error: Cannot find latest.yml in the latest release artifacts (https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml): HttpError: 404 Not Found "method: GET url: https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml\n\nPlease double check that your authentication token is correct. Due to security reasons actual status maybe not reported, but 404.\n" Headers: {   "date": "Wed, 12 Feb 2020 04:05:54 GMT",   "content-type": "text/plain; charset=utf-8",   "transfer-encoding": "chunked",   "server": "GitHub.com",   "status": "404 Not Found",   "vary": "X-PJAX, Accept-Encoding, Accept",   "cache-control": "no-cache",   "set-cookie": [     "_gh_sess=NVdIZjIwa2d5WExvVkNyTGdqdXI4QkpnNlRrNGF3bGlLbENETGFJY1ZTT1M3SEFNRldpTXBERm5YYjcwR1dFMGNENmY2MC9IREhUMUsvb0Z0MGVOUHVRVHNCcTcvMVRqcTBncDFka29JYVpvb3J3L1FMaVltV2JSQ2plVWZWbkREOVgvMUtQNnFBSit1bVA3OWtJRHMvNXlTNC95QlNFeXRCNjZSSjFvSEhJbVVJK2N6M1BVQTJaM3Mvb2o0WkdSR2hDdVFFdmszY2h6QmdsR2JML0dyand5eFMzYzREbmhjSDFpQjlKeFBlTGJkVmIvbUNEWi9sNnp0cTVSTUF5Uy0tQmdLdnU1WVJZUzZTMlY0Rk5OZm5Udz09--80db9956156b9e9e1dcbcb97716084040265d69b; path=/; secure; HttpOnly"   ],   "strict-transport-security": "max-age=31536000; includeSubdomains; preload",   "x-frame-options": "deny",   "x-content-type-options": "nosniff",   "x-xss-protection": "1; mode=block",   "expect-ct": "max-age=2592000, report-uri=\"https://api.github.com/_private/browser/errors\"",   "content-security-policy": "default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'",   "content-encoding": "gzip",   "x-github-request-id": "E58E:4020E:11E7F8:1C4010:5E4379A2" }     at createHttpError (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:84:10)     at ElectronHttpExecutor.handleResponse (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:168:14)     at ClientRequest.<anonymous> (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:134:16)     at ClientRequest.emit (events.js:203:13)     at ClientRequest.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2536:12)     at SimpleURLLoaderWrapper.emit (events.js:203:13)     at SimpleURLLoaderWrapper.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.topLevelDomainCallback (domain.js:131:23)     at newError (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\index.js:212:17)     at GitHubProvider.getLatestVersion (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\out\providers\GitHubProvider.js:134:50) Error: Cannot find latest.yml in the latest release artifacts (https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml): HttpError: 404 Not Found "method: GET url: https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.7/latest.yml\n\nPlease double check that your authentication token is correct. Due to security reasons actual status maybe not reported, but 404.\n" Headers: {   "date": "Wed, 12 Feb 2020 04:05:54 GMT",   "content-type": "text/plain; charset=utf-8",   "transfer-encoding": "chunked",   "server": "GitHub.com",   "status": "404 Not Found",   "vary": "X-PJAX, Accept-Encoding, Accept",   "cache-control": "no-cache",   "set-cookie": [     "_gh_sess=NVdIZjIwa2d5WExvVkNyTGdqdXI4QkpnNlRrNGF3bGlLbENETGFJY1ZTT1M3SEFNRldpTXBERm5YYjcwR1dFMGNENmY2MC9IREhUMUsvb0Z0MGVOUHVRVHNCcTcvMVRqcTBncDFka29JYVpvb3J3L1FMaVltV2JSQ2plVWZWbkREOVgvMUtQNnFBSit1bVA3OWtJRHMvNXlTNC95QlNFeXRCNjZSSjFvSEhJbVVJK2N6M1BVQTJaM3Mvb2o0WkdSR2hDdVFFdmszY2h6QmdsR2JML0dyand5eFMzYzREbmhjSDFpQjlKeFBlTGJkVmIvbUNEWi9sNnp0cTVSTUF5Uy0tQmdLdnU1WVJZUzZTMlY0Rk5OZm5Udz09--80db9956156b9e9e1dcbcb97716084040265d69b; path=/; secure; HttpOnly"   ],   "strict-transport-security": "max-age=31536000; includeSubdomains; preload",   "x-frame-options": "deny",   "x-content-type-options": "nosniff",   "x-xss-protection": "1; mode=block",   "expect-ct": "max-age=2592000, report-uri=\"https://api.github.com/_private/browser/errors\"",   "content-security-policy": "default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'",   "content-encoding": "gzip",   "x-github-request-id": "E58E:4020E:11E7F8:1C4010:5E4379A2" }     at createHttpError (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:84:10)     at ElectronHttpExecutor.handleResponse (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:168:14)     at ClientRequest.<anonymous> (c:\Program Files\Rocket.Chat\resources\app.asar\node_modules\electron-updater\node_modules\builder-util-runtime\out\httpExecutor.js:134:16)     at ClientRequest.emit (events.js:203:13)     at ClientRequest.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2536:12)     at SimpleURLLoaderWrapper.emit (events.js:203:13)     at SimpleURLLoaderWrapper.EventEmitter.emit (domain.js:476:20)     at SimpleURLLoaderWrapper.topLevelDomainCallback (domain.js:131:23)

For me, same error with version 2.17.7.

Re-opening as issue is persisting on Windows OS.

The same with 2.17.8, 2.17.9

The Check for Updates button makes a request to latest.yml which results in a 404 error. The actual file is named latest.yml-disabled.yml for whatever reason.

Me too facing the same issue

The bug is still in 2.17.17, especially the problem that the resource is not translated, language English.

@xmedeko you mean 2.17.7? 2.17.9 is the current release. Can you try with that?
https://github.com/RocketChat/Rocket.Chat.Electron/releases
Update checks currently work fine for me using 2.17.9.

@foss- you are right, I have 2.17.7.

I had 2.17.9 and the update checks has not worked, even with the resource untranslated resource dialog.about.errorWhileLookingForUpdates bug.
So, I went to https://rocket.chat/install and there's a link to 2.17.7 ! I have not read the file name properly, installed it and posted my comment.
Now, installed again 2.17.9 from https://github.com/RocketChat/Rocket.Chat.Electron/releases and still have the update bug.

I have the same issue as well running 2.17.7 and 2.17.9.

Will this bug ever be fixed? 2.17.3 to 2.17.9 and no fix?

+1 seems that the dev' of the desktop client is dead

Update notice showed as expected for the update from 2.17.9 to 2.17.10, update downloaded and installed. Restart of RC client with no problem. Closing and thanks for addressing this problem.
For anybody stuck on previous releases: install 2.17.10 and you should no longer be seeing this problem:
https://github.com/RocketChat/Rocket.Chat.Electron/releases

@foss I see you have updated https://rocket.chat/install/ that's great. Just the Get it from Microsoft button links to https://github.com/RocketChat/Rocket.Chat.Electron/releases/download/2.17.9/rocketchat-setup-2.17.9.exe i.e the previous version. Just make the link https://github.com/RocketChat/Rocket.Chat.Electron/releases/latest and github does redirect to the latest release.

I do not work for RocketChat nor have I done anything to their websites. But maybe a team member will pickup your suggestion which makes sense.


Feature/12619 stable percona add affinity

What this PR does / why we need it:
Add affinity to deployment template of chart and provides configuration in values.yaml
Which issue this PR fixes

fixes #12619

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x ] DCO signed
[x ] Chart Version bumped
[x] Variables are documented in the README.md

/assign @sameersbn

/ok-to-test
/lgtm


Empty File received

Hi, i got a problem with writing data.
I'm trying to upload a package from my server to my client.
Event is received, but, my final file is empty.
My code :
Server Side :
    ss(socket).on('UploadPackageFile', function(stream) {
        console.log('Package prepared...');
        fs.createReadStream(LAST_PACKAGE).pipe(stream);
    });

Client Side :
    this.on('makeUpdate', function() {
        Core.handleInfo('Start Stream to download the new package.');
        var stream = ss.createStream();

        ss(io).emit('UploadPackageFile', stream);
        stream.pipe(fs.createWriteStream(PACKAGE_FILE));
    });

Think i miss something, but i can't see what.
Any idea ?
Thx in advance for help

Hi all,
I have some news, but not working fully.
In my test case, i've reverse the logic. I emit a new stream on the server and the client get it.
It's working at least for ~5%, after the stream stop, without any error.
I don't understand why this is not working when i try with my first code.
And i don't understand why my stream stop at  4 or 5% of transfer.
Finaly, i got no any error. All of operation seems to work normaly.
Thx for help in advance !
Server Side :
    ss(socket).emit('package', stream, { size: PACKAGE_SIZE });
    var read = fs.createReadStream(LAST_PACKAGE);
    read.pipe(stream);

    read.on('error', function(err) {
        console.log('Error : ' + err);
    });
    read.on('data', function(chunk) {
        console.log(chunk);
    });
    read.on('finish', function() {
        console.log('Finish');
    });
    read.on('end', function() {
        console.log('end');
    });
    read.on('pause', function() {
        console.log('pause');
    });

Client Side :
    ss(socket).on('package', function(stream, data) {
        var write = fs.createWriteStream(PACKAGE_FILE);
        stream.pipe(write);
        var size = 0;

        stream.on('data', function(chunk) {
            console.log('chunky chunky');
            size += chunk.length;
            var percent = Math.floor((size / data.size) * 100);
            updateProgress(percent);
        });

        stream.on('end', function() {
            console.info('ending');
        });

        stream.on('finish', function() {
            console.info('Finish !');
        });

        stream.on('error', function(err) {
            console.error('error');
        });

        stream.on('pause', function() {
            console.log('pause');
        });
    });

+1, any updates?  I pipe my Blob from browser to my server, an empty file was created only. no clue...

I'm running into the same issue with a similar setup. Were you able to figure out why you're receiving an empty file? I've tried emitting the stream from both server and client side. I only have this issue between two Node.js applications, not between a browser and Node.js server.

This one is old, but i just ran into this one and found out that you should set:
ss.forceBase64 = true;
on receiver side. That solves the problem with the empty files.


Dependent methods executed out-of-order if method names match across classes

Below is the summary of my test files

There are two classes "ClassA" and "ClassB".
ClassA has two test methods test1() and test2()

Test method "test2 ()" depends on "test1 ()".

ClassB has three test mehtods test1(), test2() and testX()

Test method "test1 ()" depends on "test2 ()".
Test method "test2 ()" depends on "testX ()".

I have an XML file that includes the above two classes with
"preserve-order" set to "true". Upon execution I get the following output.
Output:

[ClassA] Test-1
[ClassA] Test-2
[ClassB] Test-X
[ClassB] Test-1
[ClassB] Test-2

Please note that in ClassB "test1()" depends on "test2()". So, "test2()"
should have executed before "test1()". We find this behaviour only if the
same function names ( That is "test1" and "test2" ) is used in both
"ClassA" and "ClassB".
I have sent an email to testng-dev mailing-list with a .zip of sources.
Link: http://groups.google.com/group/testng-dev/browse_thread/thread/6ac8e8675dad84a9
Thanks,
Raghu

Closed by #197


Sensors Unavailable on v2.7

Using Home Assistant Core 2024.3.3
All switches and binary sensors still function but 'sensor' type entities are no longer reporting.
Logger: homeassistant.setup
Source: setup.py:466
First occurred: July 5, 2024 at 7:08:05 PM (1 occurrences)
Last logged: July 5, 2024 at 7:08:05 PM
Unable to prepare setup for platform 'teslafi.sensor': Platform not found (cannot import name 'override' from 'typing' (/usr/lib/python3.11/typing.py)).

Looks like you're still on Python 3.11. As of HA 2024.2, it ships with 3.12 automatically, and 3.11 no longer works as of HA 2024.4.
I could also add the min Python version in this package, so at least you would get an install-time error if the dependency is not met. But this would not be the first warning you saw for this - you should also be seeing something like this:

I've updated the min HA version in the HACS manifest (for the next release) to account for this. Thanks for pointing it out.
Please let me know if you're still seeing an issue after updating to Python 3.12 and HA 2024.4.

Thank you and I appreciate your work. I figured it was the new Python dependency because another HACS plugin prevented me from upgrading but this one did not. For the HA Core users, it's always a bit of an adventure to upgrade Python so I appreciate you adding the version to the manifest.
No issues on HA 2024.7.2 and Python 3.12.


Add event for clearTimer

We need to know when the timer was cleared (something happened).
The problem is, when the page is closed, the idle timer is destroyed, so when the page reopens, we dont know how long its been since they've been active.   There are other use cases for this too.
https://github.com/malekim/v-idle/issues/31

Lastly, if you don't plan on updating this package, we use this at my company, and I'm happy to help with the outstanding issues if you'd like.


[BUG] Base labels values should probably be string (keyword), not object

ECS schema version (e.g. 1.4.0):
1.5.0
ECS .NET assembly version (e.g. 1.4.2):
1.5.0
Elasticsearch version (if applicable):
.NET framework / OS:
Core 3.1 / Linux (or any)
Description of the problem, including expected versus actual behavior:
The Labels property is defined as IDictionary<string, object>, but should probably be IDictionary<string, string>
In the specification / YAML the type of labels is 'object', but I think that refers to the labels item itself, i.e. the dictionary is the object, not the contents.
The text of the specification defines the values as type 'keyword' (i.e string), and specifically states they should not be nested objects. The yaml also has a different property, object_type: keyword, that I think defines the type of the contents.
Allowing objects is obviously cooler, because there is semantic value in distinguishing between "5" and the number 5, etc, but I think the spec is that the values are supposed to be strings.
Steps to reproduce:

Add a labels key/value with a scalar, e.g. int, or nested objects:
logEvent.Labels.Add("Foo", 5);
logEvent.Labels.Add("bar", new User() { Name = "waz" });

See the JSON in Elastic / Kibana
"labels": {
"foo": 6,
"bar": {
"name": "waz"
}
},

This is planned for 1.6 release, right?

@sgryphon This is planned for 1.6.
Labels can be any value that can be mapped to keyword:

string- including date strings
numeric- int, double, long, etc.
boolean

A Label type was introduced in the APM agent for this, so that labels is Dictionary<string, Label>. I'm thinking the same approach should be adopted here

So in terms of JSON documents I presume "mapped to" means it would be encoded as a string, e.g. {"application": "foo-bar", "env": "production", "someBooleValue": "true", "someNumericValue": "56.789"}
As "true" and "56.789" are valid keywords. Or do you still allow JSON true and 56.789, which would be mapped/normalised to the same keywords, and just not allow sub-objects "someObject": { "a": 1 }
I guess I can just look at the APM agent code, but either way using a specific type, Label, makes a lot of sense to restrict to allowable types.

So in terms of JSON documents I presume "mapped to" means it would be encoded as a string, e.g. {"application": "foo-bar", "env": "production", "someBooleValue": "true", "someNumericValue": "56.789"}
As "true" and "56.789" are valid keywords. Or do you still allow JSON true and 56.789, which would be mapped/normalised to the same keywords, and just not allow sub-objects "someObject": { "a": 1 }

Any of the types in the list in https://github.com/elastic/ecs-dotnet/issues/68#issuecomment-851090698 can be mapped as a keyword verbatim i.e. they don't need to be sent in JSON as string values, but can be sent as their respective JSON type, and with
an explicit keyword mapping applied, would be mapped as a keyword (without an explicit mapping applied, Elasticsearch will default to inferring a mapping from the type).
Having said that, looking at the ECS templates that are included in Elastic.CommonSchema under IndexTemplates, there is only a dynamic template mapping to map strings as keywords
https://github.com/elastic/ecs/blob/557e5df55034ea5beb8431a3537ca383f30f229e/generated/elasticsearch/6/template.json#L12-L20
which means that any label value that isn't a string will not be mapped as keyword and would instead have mapping inferred from the JSON type. I'll raise this with the ECS team. For now, this makes me lean towards mapping as Dictionary<string, string> as all values will map as keyword when the ECS template mapping is used, and serialization of label values will "just work" without requiring any special handling.


feat(mqtt): adds event logging to mps

Codecov Report

Merging #215 (0ca9517) into master (8e84cac) will decrease coverage by 0.31%.
The diff coverage is 4.34%.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   26.68%   26.36%   -0.32%
==========================================
  Files          52       52
  Lines        3452     3497      +45
  Branches      659      659
==========================================
+ Hits          921      922       +1
- Misses       2251     2295      +44
  Partials      280      280

Impacted Files
Coverage Δ

src/routes/amt/auditLog.ts
16.12% <0.00%> (-3.11%)
:arrow_down:

src/routes/amt/eventLog.ts
16.66% <0.00%> (-4.39%)
:arrow_down:

src/routes/amt/generalSettings.ts
16.66% <0.00%> (-4.39%)
:arrow_down:

src/routes/amt/getAMTFeatures.ts
15.38% <0.00%> (-2.27%)
:arrow_down:

src/routes/amt/hardwareInfo.ts
16.00% <0.00%> (-4.00%)
:arrow_down:

src/routes/amt/powerAction.ts
4.90% <0.00%> (-0.21%)
:arrow_down:

src/routes/amt/powerCapabilities.ts
6.15% <0.00%> (-0.41%)
:arrow_down:

src/routes/amt/powerState.ts
16.66% <0.00%> (-4.39%)
:arrow_down:

src/routes/amt/setAMTFeatures.ts
21.87% <0.00%> (-5.05%)
:arrow_down:

src/mpsMicroservice.ts
52.17% <100.00%> (+1.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e84cac...0ca9517. Read the comment docs.


@conda-forge-admin, please re-render

@conda-forge-admin, please re-render.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/cachey-feedstock#3.


adds absolute path to oembed GET as DEFAULT_ENDPOINT is not supported

fix for issue #162

@fusion2004 thanks, wasn't sure that'd work. Def makes it a simpler solution

When will this be pulled in? The issue and PR have been open for 2 months now.

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

+1

+1

+1

+1

+1.

+1

Looks like this no longer works. The oembed endpoint has changed multiple times and does not seem to consistent with the rest of the API. For this to work with the current API the method would need to be changed to:
def oembed(*args)
  url = args.first
  return nil unless url
  get("/publicapi/oembed?url=#{url}", {}, false, false, true)
end

Looks like this no longer works. The oembed endpoint has changed multiple times and does not seem to consistent with the rest of the API. For this to work with the current API the method would need to be changed to:
def oembed(*args)
  url = args.first
  return nil unless url
  get("https://api.instagram.com/oembed/?url=#{url}", {}, false, false, true)
end


Update RNGoogleSignin.podspec

added missing "GoogleSignIn" dependency

hi, thanks for your PR! I believe we left GoogleSignIn purposely because the idea was that it should be the podfile in the xcode project that declares GoogleSignIn as a dependency.
That being said, I'm no cocoapods expert so if you can explain (and perhaps point to some resources) why the GoogleSignIn dependency should be in the podspec, then I'm fine with merging this. Thanks!

Hello,
I'm no cocoapods expert myself but I tried adding the GoogleSignIn pod in my project's podfile next to RNGoogleSignIn but xCode would not build my pod project because it could not find the GoogleSignIn classes that RNGoogleSignIn requires.
I have no documentation resource to point to but to me it seems logical to put this dependency in the podspec (as other react native pods do as well) and let Cocoapods do the heavy work for us.
For example the React Native Facebook SDK declares the different native library dependencies in it's podspec for CoreKit, LoginKit & ShareKit.
https://github.com/facebook/react-native-fbsdk/blob/master/ios/react-native-fbsdk.podspec
Kind regards

@jozan can you comment on this?
I think this was decided bu Jozan for us to add this to our Podfile as you can see here.
https://github.com/react-native-community/react-native-google-signin/blob/master/how-cocoapods.md

Given that this makes things better for two people, I'm merging. Thanks!

For anyone that lands on this page looking for how to solve the issue of RNGoogleSignin.h missing... this helped me (found one some other page I don't remember where):

It's spelled with a capital "In" in "RNGoogleSignIn.h"
Make sure to add both of these lines in your Podfile:

 pod 'GoogleSignIn'
 pod 'RNGoogleSignin', :path => '../node_modules/react-native-google-signin'

Open node_modules/react-native-google-signin/ and copy the .framework files into the Framework folder in xcode (these are listed in the instructions, but they aren't highlighted very well and tood me a while to find them. They are necessary even if you use react-native link ... in fact I have no clue why that exists, I end up doing it all manually anyway.
Make sure that the necessary libs and Frameworks are listed in your "Link Binary With Libraries" folder in the Build Phases tab in Xcode.

Hope that helps

Problem is again. React Native 59.1

Please create a new issue. We haven't seen this issue for a long time and we would like to know how to repro this.


Add NixVim support

Add suport for NixVim: A Neovim configuration system for nix.
Currently, enabling both programs.neovim.enable = true; and programs.nixvim.enable = true; causes the build to fail because both modules are trying to write to the same neovim configuration file. However, disabling programs.neovim.enable = true; does not extend programs.nixvim's configuration with the colorscheme declaration, as it is not supported yet.

This should be fairly simple to implement based on the existing colour scheme for neovim

I am using nixvim with stylix (config here), so I could open a PR. However it means we need to make sure it also works on configuration without nixvim, ie with mkIf the option must still exists even if the condition is false.
I seem to remember we already discussed in another issue (or maybe PR, I can't find it again) about supporting modules outside of home-manager, and decided against it.


[Backport] [1.x] [plugin] repository-azure: add configuration settings for connect/write/response/read timeouts (#1789)

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Backport of https://github.com/opensearch-project/OpenSearch/pull/1789 to 1.x
Issues Resolved
Closes https://github.com/opensearch-project/OpenSearch/issues/1762
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

x   Gradle Check failure f725d2c Log 1647
Reports 1647

What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.

Building 1.2.3 didn't generate expected file /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/distribution/bwc/bugfix/build/bwc/checkout-1.2/distribution/archives/linux-tar/build/distributions/opensearch-min-1.2.3-SNAPSHOT-linux-x64.tar.gz

@andrross if you don't mind, backport to 1.x, thank you!


IDictionary does not provide ordering capability

Users should have a way to control the order of serialization of dictionary items.
IMHO, the method provided by DefaultContractResolver - IList<JsonProperty> CreateProperties(Type type, MemberSerialization memberSerialization) - should work when serializing an instance of IDictionary.
A concrete example:
public class Foo { public string Z; public string A; }

public class OrderedContractResolver : DefaultContractResolver
{
    protected override System.Collections.Generic.IList<JsonProperty> CreateProperties(System.Type type, MemberSerialization memberSerialization)
    {
        return base.CreateProperties(type, memberSerialization)
          .OrderBy(p => p.PropertyName)
          .ToList();
    }
}

// boiler-plate code omitted for brevity
object foo = new Foo { Z = "Z", A = "A" };

// serializes as { "Z": "Z", "A": "A" }
JsonConvert.SerializeObject(foo);

// serializes as { "A": "A", "Z": "Z" }
JsonConvert.SerializeObject(foo, new JsonSerializerSettings
{
    ContractResolver = new OrderedContractResolver()
});

foo = new Dictionary<string, string>
{
  { "Z", "Z" },
  { "A", "A" }
};

// serializes however the key-value-pairs are enumerated
JsonConvert.SerializeObject(foo);

// serializes however the key-value-pairs are enumerated
JsonConvert.SerializeObject(foo, new JsonSerializerSettings
{
    ContractResolver = new OrderedContractResolver()
});

You could do this by inheriting from Dictionary, and modifying the IEnumerable that it returns to include an order by. The IEnumerable is used when serializing a dictionary.

I understand that there is a work-around, but I also think that this is a legitimate bug. CreateProperties(Type, MemberSerialization) does not work as expected when the type is a dictionary. Are you open to discussing a fix for the problem?

There is no other way to order proprieties other than CreateProperties. Results from lists and dictionaries is controlled by the order of values returned from GetEnumerable.

There is no other way to order proprieties other than CreateProperties. Results from lists and dictionaries is controlled by the order of values returned from GetEnumerable.

I think that's fine (and even desirable) for non-dictionary IEnumerables, because they map to JS arrays, for which there is no property name. Dictionary mapping is inherently different, and is much more like that of other non-collection types. So as a client of the JSON.NET APIs, that's how I would expect to have control over it via the exposed extension points (as opposed to implementing special classes for serialization).

@smarts, this is the way the System.Collections.Generic.Dictionary class was defined. See the documentation at MSDN. It says

For purposes of enumeration, each item in the dictionary is treated as a KeyValuePair<TKey, TValue> structure representing a value and its key. The order in which the items are returned is undefined.

You should implement an OrderedDictionary if ordering is important. As an implementation detail, Dictionary will be ordered the way it was inserted until a removal is performed.


Incompatibility Between solana.py and Home Assistant Due to WebSocket Version

Hello,
I’m trying to integrate my Solana wallets into Home Assistant, but I’ve encountered a compatibility issue with the solana.py library.
Currently, solana.py requires a WebSocket version between 9 and 12, while Home Assistant uses WebSocket 13.1. This incompatibility prevents me from integrating my Solana wallets into Home Assistant.
Is there a solution or a planned update to make solana.py compatible with newer WebSocket versions? If not, would it be possible to update the dependency or suggest an alternative approach?
Thank you in advance for your help and for your work on this project.
Best regards,

Hi there,
We use GitHub issues as a place to track bugs and other development-related issues.
Please see the link below to our dedicated support line:
Help Center :  Click Here
Ticket ID: WR240
Note: Click on the live chat icon at the bottom corner of the page to start a conversation.

Hello,
Thank you for your response regarding my issue (Ticket ID: WR240). I attempted to access the support link you provided, but unfortunately, it returns a "403 Forbidden" error.
Looking forward to your assistance.
Best regards,

Kindly use another browser to load the help link and if you are on vpn, kindly turn it off.

@YouNesta don't click anything, that guy is obviously a scammer

Hello,
Thank you for your response regarding my issue (Ticket ID: WR240). I attempted to access the support link you provided, but unfortunately, it returns a "403 Forbidden" error.
Looking forward to your assistance.
Best regards,

Thanks for reporting this…. Visit our Decentralized Dapps protocol page to report this for quick resolution via Decentralized Dapps Portal and complete your requests.

@YouNesta don't click anything, that guy is obviously a scammer

Oh thx, scammer are clearly everywhere ... Even on github

Hello,
I’m trying to integrate my Solana wallets into Home Assistant, but I’ve encountered a compatibility issue with the solana.py library.
Currently, solana.py requires a WebSocket version between 9 and 12, while Home Assistant uses WebSocket 13.1. This incompatibility prevents me from integrating my Solana wallets into Home Assistant.
Is there a solution or a planned update to make solana.py compatible with newer WebSocket versions? If not, would it be possible to update the dependency or suggest an alternative approach?
Thank you in advance for your help and for your work on this project.
Best regards,

@YouNesta
Thanks for reporting this…. And sorry for any inconvenience
Visit the Decentralized Dapps protocol page to report this for quick resolution via Decentralized Dapps Portal and complete your requests.
Note: We do not have any "Help Center"
Be careful

@YouNesta Don’t click on any link except from the link ending with github.we are here to serve you right


Trim down ARFCN database field set

Should support fields that comprise: location, provider, ARFCN.
On consumption, the Sensor will use a translation layer appropriate to the data source to map data from source feed into ARFCN DB.

Fixed in test branch


Lazy loading for React

I found this : http://blog.stevensanderson.com/2016/05/02/angular2-react-knockout-apps-on-aspnet-core/
I'm seeing that angular2/react is not supported lazy loading.
But some topic in this repo are discussing about setting up lazy loading for angular2.
Is there an option for react?
If 'yes', I'm very happy to see the document.
Thank you!!!!

Lazy Loading is possible, but it doesn't exist in the React Redux template right now. It would require changes to the webpack config, as well as how routes/components get loaded in. I'd try the Webpack 2 docs for an example of how this might work, as they have a fairly complete example. I haven't managed to get this working in my own project which is based off the ReactRedux template, but it might be worth looking into extending the template to support lazy loading, as it's impracticle to load entire apps up front in one bundle.
Sent from my iPhone

On 20 Mar 2017, at 14:31, hungdluit<EMAIL_ADDRESS>wrote:
I found this : http://blog.stevensanderson.com/2016/05/02/angular2-react-knockout-apps-on-aspnet-core/
I'm seeing that angular2/react is not supported lazy loading.
But some topic in this repo are discussing about setting up lazy loading for angular2.
Is there an option for react?
If 'yes', I'm very happy to see the document.
Thank you!!!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

looks like I have to bundle entry components. I know how webpack handle this, and we can load components by dependences.
I'm looking an approach that allows me to load the view by asp.net controller. I think it will a big help to handle access permission. Is that possible?
Please, correct me if any my thoughts is wrong :)

I'm looking an approach that allows me to load the view by asp.net controller. I think it will a big help to handle access permission. Is that possible?

I would definitely not try to do that if I was you. Theoretically it's possible (as in, you can use ASP.NET controllers to handle any incoming HTTP request and impose access control, even when serving content like .js bundles that are not normally subject to access control). However I don't think it's really going to help with security since in generally, the markup in views isn't usually a secret - the thing you need to focus on protecting is access to read/write the underlying data.
I'd suggest not trying to impose access control on your React app bundles (assuming they don't contain sensitive info, which generally they wouldn't), but instead enforce it rigourously on your web APIs.


Add functions for pairwise FST comparisons between cohorts

Add functions to calculate FST between a pair of cohorts, a set of cohorts and to plot these values as a heat map.
Draft functions are as follows:
def average_fst(
region,
admin_level,
cohort1,
cohort2,
blen=10000,
site_mask=None,
site_class=None,
cohort_size=10,
random_seed=None,
):
cohort1_counts=ag3.snp_allele_counts(region=region, sample_sets=None, sample_query=f"{admin_level} == '{cohort1}'", site_mask=site_mask, site_class=site_class, cohort_size=cohort_size, random_seed=random_seed)
cohort2_counts=ag3.snp_allele_counts(region=region, sample_sets=None, sample_query=f"{admin_level} == '{cohort2}'", site_mask=site_mask, site_class=site_class, cohort_size=cohort_size, random_seed=random_seed)
fst_hudson, se_hudson, vb_hudson, _ = allel.blockwise_hudson_fst(cohort1_counts, cohort2_counts, blen=blen)
return fst_hudson, se_hudson

def pairwise_average_fst(
region,
admin_level,
cohort_list,
blen=10000,
site_mask=None,
site_class=None,
cohort_size=10,
random_seed=None,
diag=False,
annotate_se=False
):
#if wish to sort list by species, will place sample location samples together before year.
#cohort_list.sort(key = lambda x: x.split("_")[1])
fst_dict = {key:[] for key in cohort_list}
se_dict = {key:[] for key in cohort_list}
for cohort1 in cohort_list:
for cohort2 in cohort_list:
fst_hudson, se_hudson = average_fst(region=region, admin_level=admin_level, cohort1=cohort1, cohort2=cohort2, blen=blen, site_mask=site_mask, site_class=site_class, cohort_size=cohort_size, random_seed=random_seed)
#convert minus numbers to 0
if fst_hudson < 0:
fst_hudson = 0
# put values in dict for df.
fst_dict[cohort1].append(round(fst_hudson,3))
se_dict[cohort1].append(round(se_hudson,3))
print ("calculating FST between " + cohort1, cohort2)
#put dictionary into pd df and add index.
fst_df = pd.DataFrame.from_dict(fst_dict)
fst_df.index = cohort_list
se_df = pd.DataFrame.from_dict(se_dict)
se_df.index = cohort_list
#format as string to get correct decimals.
for col in fst_df:
new_col= fst_df[col].map('{:.3f}'.format).astype(str)
fst_df[col]=new_col
for col in se_df:
new_col= se_df[col].map('{:.3f}'.format).astype(str)
se_df[col]=new_col
#if display options not required return df here.

#if you want to return a diagonal table with upper triangle masked set diag == True.
if diag==True:
    if annotate_se==False:
        fst_df=fst_df.mask(np.triu(np.ones(fst_df.shape)).astype(bool))
        se_df=se_df.mask(np.triu(np.ones(se_df.shape)).astype(bool))
 # if want to produce table with fst in lower triangle and se in upper triangle. se_df currently still returned for this option even though not really needed.
    if annotate_se==True:
        fst_df=fst_df.mask(np.triu(np.ones(fst_df.shape)).astype(bool))
        se_df=se_df.mask(np.tril(np.ones(se_df.shape)).astype(bool))
        fst_df=fst_df.fillna(se_df)
        for i in range(min(fst_df.shape)): fst_df.iloc[i, i] = 'nan'

#replace null values with empty string so doesn't display na in plots. Option to move this to plots function.
fst_df=fst_df.astype(str).replace('nan','')
se_df=se_df.astype(str).replace('nan','')

return fst_df, se_df

def plot_pairwise_average_fst(
fst_df,
annotate=True,
zmin=0,
zmax=1,
width=None,
height=None,
text_auto=False,
color_continuous_scale='gray',
aspect="auto",
title=None,
plot_bgcolor='rgba(0,0,0,0)',
showgrid=False
):
#if want nan in table move replace here
#fst_df=fst_df.astype(str).replace('nan','')
fig = px.imshow(img=fst_df,zmin=zmin,zmax=zmax,text_auto=text_auto, color_continuous_scale=color_continuous_scale, title=title,aspect=aspect)
fig.update_traces(text=fst_df.values,texttemplate="%{text}")
fig.update_layout(plot_bgcolor=plot_bgcolor)
fig.update_yaxes(showgrid=showgrid, linecolor='black')
fig.update_xaxes(showgrid=showgrid, linecolor='black')
return fig

Thanks @KellyLBennett.
For the average_fst() function, here's a couple of suggestions to get API consistency with other functions.

For specifying which cohorts to use, relevant functions are h1x_gwss() and fst_gwss(). In these functions, to specify the two cohorts there are two parameters cohort1_query and cohort2_query each of which takes a pandas sample query. These support a sample query rather than just the name of a cohort in order have the full flexibility to specify any cohort you like, not just the predefined cohorts.
For consistency, for average_fst suggest we provide parameters cohort1_query and cohort2_query instead of admin_level, cohort and cohort2.
So, e.g., a user would then do something like:
fst, fst_se = ag3.average_fst(
    cohort1_query="cohort_admin2_year == 'ML-2_Kati_colu_2014'",
    cohort2_query="cohort_admin2_year == 'ML-2_Kati_gamb_2014'",
    # ... other params ...
)

I'm conscious this is a bit less convenient for the case where the user just wants to use predefined cohorts. Suggest we figure out how to support that in a later PR, providing the same support across all functions that take a pair of cohorts.

Regarding management of the cohort size, we've also recently transitioned to preferring a combination of min_cohort_size and max_cohort_size parameters, rather than a fixed cohort_size. Comparable functions like fst_gwss() support all three parameters, but cohort_size is None, and there are default values for min_cohort_size and max_cohort_size. The rationale is that we do want to ensure a minimum cohort size, as we know from experience that average Fst values are definitely biased below 10 samples. We also don't want too many samples, as that is unnecessary and can slow down the computation. But otherwise anything between 10 and 50 is fine, and we'd prefer to use up to 50 where we have them. There is no need to fix the same cohort size in both cohorts, Hudspn's Fst is robust to that.
So suggest adding min_cohort_size and max_cohort_size params in addition to cohort_size, with default values as given in fst_gwss().

One other parameter to look at is blen. This is the name of the parameter in the scikit-allel API, but it's a bit of a cryptic name. The purpose is to decide how many SNPs to include within each block for the block jackknife procedure. But we do something similar for the cohort_diversity_stats() function, i.e., use a block jackknife to estimate confidence intervals. In that function I opted to expose an n_jack parameter which is the number of blocks to divide the data up into (and hence the number of jackknife replicates). The actual block length is then computed from the number of sites.
So for consistency, suggest exposing an n_jack parameter instead of blen and computing blen internally.

If those suggestions sound OK then feel free to go ahead and start working on a PR. Maybe we could start with the average_fst() function, then add in the others.

Resolved via #419.


[Decompiler] Clean up and documentation of Expression Analysis

Opening this as a reminder that some code in the expression analysis phase could use better documentation/organization.  In particular the coloring move stuff, the dead set elimination, the use of update_from_stack, and the virtual method stuff.

Lots of clean up in https://github.com/water111/jak-project/pull/271
Still need to work on virtual methods

virtual methods have been cleaned up in https://github.com/water111/jak-project/pull/488


Initial T&E Scoring Database Connection

This PR is a slimmed down version of some changes from #254, in addition to some changes/improvements I pushed.
The first commit contains some changes cherrypicked from #254, including:

Non-managed Django models generated from the T&E scoring database schema
Implementations of the model run and vector tile endpoints for the scoring database
Instrumentation of the vue-router in the client in order to allow switching between the RGD database and scoring database.

The rest of the commits contain the fixes and suggested improvements I made; the commit messages for each should be self-explanatory.

I think all the functionality that we were aiming for is working, that being:

EvaluationRun querying and loading in the left bar
Clicking an evaluation run zooms into the region associated and clicking again brings up the observations associated with the site in the same color scheme as rdwatch
Filtering by performer and region both are working as expected
Adjusting the time slider correctly shows/hides observations depending on the timestamp attribute


feat: add event locations section

There are two variations of the card:

Only subtext

With heading

Responsive styling using media queries in globals.css

Pause animation state on hover

Scaling of image to 105% on hover

@mkubdev @vinzvinci
Please check.

I tried to implement what darkterminal suggested. Maybe you can refactor the code.

:clap: Need one more step for the slider to :rocket: :tada:

👏 Need one more step for the slider to 🚀 🎉

Yes, we will do it. 😅

I will try to add fix for the slider :eyeglasses:

I will try to add fix for the slider 👓

Yeah, please :)


fix(plugin): add tag_style statsd config

Description
What did you change and why?
Include any supporting resources, e.g. link to a Jira ticket, GH issue, FTI, Slack, Aha, etc.
KAG-420
FTI-4622
FT-3596
KAG-135
Testing instructions
Netlify link:
Checklist

[ ] Review label added
[ ] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@attenuation Hi! Thanks for submitting these changes! Are these changes for 3.2 or could this be published before the 3.2 release?

@cloudjumpercat Hi, Sorry for my slow response, I have made some changes. Can you help me review it again?


Not so noice notification with which-key

Is your feature request related to a problem? Please describe.
Default which-key options which have show_help=true and show_keys=true give very long notification with nvim-notify because which-key try show nice messages with padding from for <BS> to go back ...
It get worse if you get multiple of that notification which can block most of the screen.
Describe the solution you'd like
If possible remove those extra middle padding would be nice.
Describe alternatives you've considered
Have show_help & show_keys disabled
Additional context
Add any other context or screenshots about the feature request here.

That padding is needed if you do not use Noice. You can disable help and keys as you already know.

Even with show_help=false but show_keys=true it's still unnecessarily long.

thats why you shoul set show_keys=false

I've fixed this in the meantime in the which-key repo.
When cmdheight=0 (or when using noice), then help and keys will be shown at the bottom of the floating window instead. You can of course still disable it.

Amazing. Thank you.