DRILL-8044: Update contrib/storage-hive copy of log4j Strings.java

DRILL-8044: Update contrib/storage-hive copy of log4j Strings.java
Relates to pjfanning/excel-streaming-reader#76. This is an alternate to https://github.com/apache/drill/pull/2374.
Description
https://github.com/apache/drill/blob/master/contrib/storage-hive/core/src/main/java/org/apache/logging/log4j/util/Strings.java is a copy of the real Log4j class but causes issues for Apache POI Excel code that relies on the latest Log4j code.)
Documentation
Shouldn't require doc change
Testing
unit tests

@vvysotskyi one of the travis-ci runs failed due a forked jvm running tests crashing - this happened before the module with the change was reached - is there anyway to get the tests rerun?

@pjfanning, since this change is required for updating poi and excel-streaming-reader, could you please update them here and ensure that the issue is resolved?
(Version update was reverted in this commit: https://github.com/apache/drill/commit/56ff6556b83ca0c3364592ade73d9e7436fcab44)
Also, please include the Apache Jira ticket into the commit message and update references in this PR.

I'll restart Travis CI tests now

@cgivre You reported the initial issue - would you be able to try this out with a POI 5.1.0 (and excel-streaming-reader 3.2.3)?

@pjfanning
Sure thing!  I'll build and report back this evening.  (I'm on ET in the US)

@vvysotskyi Will we know if this prevents Hive queries from functioning?

@cgivre, hive unit tests would catch such issues, changes in this PR doesn't look to break the Hive

@vvysotskyi
The reason I'm asking is that the Excel unit tests all worked for the Excel plugin, but it wasn't until I manually ran a query, things broke.  I don't have a Hive installation to manually test.

@cgivre, it means that excell tests should be improved to use that code path, also there might be some additional dependencies for a test scope, so tests path, but actually it didn't work.
No need to check Hive, it wouldn't be broken with these changes

@pjfanning, looks like POI has a hard dependency on log4j. Could you please add a dependency on log4j-to-slf4j to pom.xml to allow using that library?

@vvysotskyi made the log4j dependency change but the CI/CD build timed out when trying to get the pom - seems like an env issue at time of build

@vvysotskyi made the log4j dependency change but the CI/CD build timed out when trying to get the pom - seems like an env issue at time of build

There's a major google issue happening right now.   I'll restart the CI once everything finishes.  It looks like everything is passing.

@pjfanning @vvysotskyi
Thank you for all your work on this.  I restarted the CI, and assuming it passes this time, I'll merge later today.


The recommended /api/exit-preview is cached on Vercel and only works on the first visit

Versions

@prismicio/next: v0.1.3
next: v12.2.4
node: v16.15.0

Reproduction
https://github.com/prismicio-community/nextjs-starter-prismic-blog
Steps to reproduce
Note: When testing, ensure that caching is enabled in the browser (i.e. the "Disable cache" setting is unchecked) and that the DevTools is closed.

Deploy site to Vercel
Edit a page and preview on production
Exit the preview and verify Preview Mode is no longer active
Start a new preview
Exit the preview and verify Preview Mode is still active

What is expected?
Previews exit as many times as needed.
What is actually happening?
It only exits the first time. Any subsequent attempt is not exited. However, the Prismic preview token is removed and the request to /api/exit-preview is successful.
This happens because the endpoint returns a 200 status code. Vercel caches 200 GET requests at the Edge. To prevent the endpoint from being cached, a non-200 status code must be sent, or a non-GET request must be used.
More details are available here: https://vercel.com/docs/concepts/functions/serverless-functions/edge-caching

So you're thinking of a 205 perhaps? Seems like the exact use case 🤔

Yes, exactly. 205 sounds like a good option, better than requiring a POST request.

Fixed as of v0.1.4. For more details, see: #32.


Flaky test: RendersScriptTagsForGlobbedSrcResults

This test fails occasionally with the following error:
System.NullReferenceException : Object reference not set to an instance of an object.
   at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
   at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
   at Castle.DynamicProxy.Generators.BaseProxyGenerator.ObtainProxyType(CacheKey cacheKey, Func`3 factory)
   at Castle.DynamicProxy.ProxyGenerator.CreateClassProxy(Type classToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options, Object[] constructorArguments, IInterceptor[] interceptors)
   at Moq.Proxy.CastleProxyFactory.CreateProxy(Type mockType, ICallInterceptor interceptor, Type[] interfaces, Object[] arguments)
   at Moq.Mock`1.<InitializeInstance>b__20_0()
   at Moq.Mock`1.OnGetObject()
   at Moq.Mock`1.get_Object()
   at Microsoft.AspNetCore.Mvc.TagHelpers.ScriptTagHelperTest.MakeHostingEnvironment() in /_/test/Microsoft.AspNetCore.Mvc.TagHelpers.Test/ScriptTagHelperTest.cs:line 987
   at Microsoft.AspNetCore.Mvc.TagHelpers.ScriptTagHelperTest.RendersScriptTagsForGlobbedSrcResults() in /_/test/Microsoft.AspNetCore.Mvc.TagHelpers.Test/ScriptTagHelperTest.cs:line 617

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
CC @Eilon,@muratg,@mkArtakMSFT
This issue was made automatically. If there is a problem contact @ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

[ ] File a bug against the product (TODO: Link to other bug)
Is it possible to change the test to avoid the flakiness?

Yes? Go to the "Change the test!" section.
No?

[ ] Disable the test (TODO: Link to PR/commit)
[ ] Wait for other bug to be resolved
[ ] Wait for us to get build that has the fix
[ ] Re-enable our test (TODO: Link to PR/commit)
[ ] Close this bug

Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

Is there is a way to change our test to avoid this flakiness?

Yes? Change the test!

[ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
[ ] Run the test 100 times locally as a sanity check.
[ ] Close this bug

No?

[ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

According to the test history, this test has failed once in 6479 runs. TeamCity calls that success rate "100%". Are we investigating tests that are that reliable?

@dougbu yes, because this can cause "death by a thousand papercuts." If we have hundreds of tests that fail at that rate, that's not good enough.

:ok: @Eilon
Agree with @pranavkm that this failure appears to be completely w/in Castle.Core. The test failed when executing new Mock<IFileProvider>(), something MVC does in 10 other tests or test helpers. The MakeHostingEnvironment() method in this particular test class where that instantiation occurs is called from 19 tests in this class alone. None of the other tests failed in the single test run of interest.
Suggest we leave this open to track castleproject/Core#193. We're fairly far behind on Moq versions (at 4.7.49 with 4.9.0 the latest and 4.7.145 the latest of our minor version) and could upgrade to whichever Moq version picks up the castleproject/Core#193 fix. In the meantime, I'll test to see if Moq 4.9.0 brings along anything that breaks builds in the EF, KestrelHttpServer, Mvc, or Razor repos (hopefully that's a representative sample for this trial).

Saw a bit of unreliability in aspnet/KestrelHttpServer but nothing that didn't also reproduce on my machine without the Moq version bump. @halter73 also said most of the failures were familiar. So, no new failures there.
No failures at all in aspnet/EntityFrameworkCore, aspnet/Mvc or aspnet/Razor in their release/2.2 branches with the latest Moq (and therefore almost the latest Castle.Core).

Workarounds are fine for now. But, will leave this in Ready / blocked state until castleproject/Core#193 is resolved and moq/moq4 picks up the fix.

Configure_AddsPageViewLocationFormats_WithDefaultPagesRoot failed with about the same error on 2.2.
This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on 2.2:

PopulateFeature_ReturnsEmptyList_IfNoAssemblyPartsAreRegistered

This comment was made automatically. If there is a problem contact ryanbrandenburg.

Closing as the upgrade (aspnet/AspNetCore@904c9d3623) more than two weeks ago seems to have cleared all similar failures.


[TAB] Tabs content caching when custom tab navigate is required.

Select one ...  (check one with "x")
[ ] bug
[ ] feature request
[x] enhancement

Description
I have the following scenario - several clarity tabs one of which initially should be open based on a url parameter (after that clarity handles tab selection).
In order to achieve that I am using the *clrIfActive structural directive. The issue that I am having is when the user is switching between tabs the closed tab gets destroyed and when this tab is opened again is recreated once more.
I want to be able to set which tab should be initially opened and preserve closed tab's state because:

it will make transition between tabs more optimized performance wise (data won't be requested every time I reselect closed tab)
it will provide better UX  in my opinion since preserving the old tab's state won't actually lose any data (like selected value in a dropdown or grid). Note that switching between the tabs in my (real) case is not used for data comparison.

Reproduction of behavior
In this demo you can navigate between two tabs. The second tab contains state which will be lost after navigating out of it.
If such logic is can be implemented already I will appreciate your advice!
Thank you!

@Gesh4o: This looks like a duplicate of https://github.com/vmware/clarity/issues/2112. Please subscribe to #2112 for more information.
Closing this based on the above info. Please feel free to reopen the issue if you have more questions/feedback.


Can't create function: "Incorrect syntax near the keyword 'FUNCTION'."

Apologies if this is something really obvious, but I'm rather new to using Tiberius and SQLServer in general.
I can connect to a db fine and run fairly complex quieries. However, when I try to create a function I get the error.
Error: Server(
    TokenError {
        code: 156,
        state: 1,
        class: 15,
        message: "Incorrect syntax near the keyword 'FUNCTION'.",
        server: "DESKTOP-0B5FUJ6",
        procedure: "",
        line: 1
    }
)

This happens with any attempt to create a function or stored procedure. A minimal example of a function I've tried is:
CREATE FUNCTION dbo.ReturnNumber(@Number int) RETURNS int
AS
BEGIN
    RETURN @Number
END;

I could can create all the functions in SSMS, but would rather have them living in code so everything can be completely automated.
Thank you.

Not familiar with this project... just starting some research... are you doing the function creation as part of a larger script doing more calls to the database?  Another thing to note, is there are two call methods in some other SQL Server libraries, where one is query only and the other can do database operations as part of the call... don't know if this is a lower-level thing or not.

I have the same problem when creating functions/procedures.
Even simple procedures failed:
CREATE PROCEDURE dbo.select_test
AS
SELECT * FROM customers
;

I used Client::execute() for execution as it seemed to be best suited for creating procedures.
I tried to use Client::query() and it worked.
I don't really know TDS, so I can't say if this is a problem with tiberius or intended.

I have the same problem when creating functions/procedures. Even simple procedures failed:
CREATE PROCEDURE dbo.select_test
AS
SELECT * FROM customers
;

I used Client::execute() for execution as it seemed to be best suited for creating procedures.
I tried to use Client::simple_query() and it worked. I don't really know TDS, so I can't say if this is a problem with tiberius or intended.

That's really interesting. After posting the bug report I tried using SQLX to create a function and it worked as intended. Looks like I've probably misunderstood the crate and am using the wrong methods.

execute uses prepared statements, simple_query not. I think creating a procedure with the rpc statement does not work with SQL Server, but I'd like to be sure it is like that and this is not a bug...

Well, it's debatable. execute uses sp_executesql under the hood which seems to have trouble. For me this is a bug in MS SQL Server, but maybe they sell it as security feature.
Simple_query is the only method that does not use sp_executesql and therefore does not suffer from this behavior.


Add support for new chips

Add support for new chips: esp32c2, esp32h2, esp32c6.
Originally posted by @SergioGasquez in https://github.com/esp-rs/esp-idf-template/issues/121#issuecomment-1547416302

See #123 not sure if its that easy

Since not all chips support all the ESP-IDF versions we could:

Update the default ESP-IDF version to v5.0
If the user goes for non-default, update the list of ESP-IDF versions based on the chip to show only the supported version


@HxTrigger & @ResponseBody cannot work together (due to postHandle())

Hi -- firstly, great library -- thank you!
I have noticed an issue, however. I'm using a fairly typical Spring Boot + Thymeleaf setup, using Spring Boot 3.1.0-M1.
As an example:
    @HxTrigger("this-never-gets-set")
    @GetMapping("/cormac")
    @ResponseBody
    public String cormac(Model model, HttpServletResponse response) {
        response.setHeader("this-will", "work-okay");
        return "irrelevant";
    }

I am showing via code where I can set a header manually (i.e., this will work), but HxTrigger does NOT ultimately manage to set a header. It does try though (so that's fine), but, down the stack the header setting gets ignored because the request is actually committed already, and so the final response.setHeader(...) (after all the wrappers) doesn't ultimately get called. E.g., isCommitted() is true here in org.apache.catalina.connector.ResponseFacade's:
    @Override
    public void setHeader(String name, String value) {
        if (isCommitted()) {
            return;
        }

        response.setHeader(name, value);
    }

Ultimately, if you keep following this, you can see that the underlying Response.java's committed boolean is true.
HandlerInterceptorAdapters will not work with @ResponseBody and ResponseEntity methods because they are handled by StringHttpMessageConverter, which writes to and commits the response before postHandle(...) is ever called, which basically makes it impossible to change the response (although, it doesn't complain -- stuff just silently gets ignored).
I do notice you have a @ResponseBody test, but I think without a more realistic Spring context setup, you wouldn't see this issue in a what's basically unit test.
Check here, some people chatting about very similar issues:
https://github.com/spring-projects/spring-framework/issues/13864
https://stackoverflow.com/questions/48823794/spring-interceptor-doesnt-add-header-to-restcontroller-services
So, I think preHandle(...) is the way to go and your use-case (just checking for annotated methods) is pretty simple, so I don't see any downsides to it or any need to do this in postHandle(...).
Update: I opened a PR with the suggested change.

I'm curious how you are using @ResponseBody with HTMX. Or is this more just a general improvement of the library?

Not for anything useful, actually. Sometimes just to return a "" or void (same outcome). Without @ResponseBody, Thymeleaf assumes the response refers to a template name and goes looking for it.
But you could use it for practical purposes to just return a piece of text or even JSON, rather than have Thymeleaf involved at all; for certain cases. Of course you could use model attributes to get around all of this.
Besides that, there is a test in:
HtmxHandlerInterceptorTest
... which uses:
TestController
...implying it's supported/considered before:
    @GetMapping("/with-trigger")
    @HxTrigger("eventTriggered")
    @ResponseBody
    public String methodWithHxTrigger() {
        return "";
    }

As an alternative, you can try this:
 @GetMapping("/with-trigger")
    @HxTrigger("eventTriggered")
    @ResponseStatus(OK)
    public void methodWithHxTrigger() {

    }

So  use a void return type and add the @ResponseStatus annotation. According to the docs this should work:

A method with a void return type (or null return value) is considered to have fully handled the response if it also has a ServletResponse, an OutputStream argument, or an @ResponseStatus annotation.

Yep, that might cause HxTrigger to behave correctly -- but what if you do just want to return some text though -- which can be useful sometimes...?
I still think the PR is a proper and simple/safe fix: https://github.com/wimdeblauwe/htmx-spring-boot-thymeleaf/pull/43

This has been released in version 2.0.1. I am sorry it took so long to find the time to release this. Thank you for contributing this!

Cheers!


Correctly support UTF-8 charset

Try this code in place of current response.content code
await response.json(encoding="utf-8")

Added to v1.4.0


Try to fix 503

Several commits with efforts to improve our ingress backend reloading so much that causes connections to drop.
I still have an extra commit to add if this doesnt work.

glance-registry is also mentioned in playbooks/roles/deploy-osh/files/common-images-overrides.yml, could it be dropped as well? (it does not have any effect, but just for the cleanup)

This works, splitting everything as 2 of this patches are not needed anymore and the bump keystone to latest will change when the needed patches are merged upstream


updated xact (2.37)

Thank you for the contribution. It was merged directly as 7cf448cc17a25151020dcf6c5b2158693838710c to keep commit history cleaner. Your contribution is still credited to you.


Add NEON support for ARM64

This commit adds ARM64 NEON support, with approx a 5 to 10x performance improvement over the (non-accelerated) Golang version.
It exploits the PMULL/PMULL2 instructions followed by two reductions to reduce the results to 8-bit again. It processes 32-bytes per loop (so effectively processing 2 streams of 128-bit results/registers simultaneously).
It has been tested/developed on a Pine64 with an ARM Cortex-A53 1.2GHz (8 core), running Debian 8.0 Jessie and using Go 1.7.4.
benchmark                                old MB/s     new MB/s     speedup
BenchmarkGalois128K-8                     75.33        907.63      12.05x
BenchmarkGalois1M-8                       75.80        884.15      11.66x
BenchmarkGaloisXor128K-8                  52.04        768.83      14.77x
BenchmarkGaloisXor1M-8                    50.39        537.01      10.66x
BenchmarkEncode10x2x10000-8               45.33        301.92       6.66x
BenchmarkEncode100x20x10000-8             16.34        183.64      11.24x
BenchmarkEncode17x3x1M-8                 125.41       1266.14      10.10x
BenchmarkEncode5x2x1M-8                  189.41       1303.49       6.88x
BenchmarkEncode10x2x1M-8                 188.03       1738.44       9.25x
BenchmarkEncode10x4x1M-8                  95.60        838.76       8.77x
BenchmarkVerify10x2x10000-8               44.75        214.19       4.79x
BenchmarkVerify50x5x50000-8               71.77        631.63       8.80x
BenchmarkVerify10x2x1M-8                 175.76       1367.07       7.78x
BenchmarkVerify5x2x1M-8                  167.27        887.21       5.30x
BenchmarkVerify10x4x1M-8                  91.12        676.81       7.43x
BenchmarkReconstruct10x2x10000-8          31.15        157.72       5.06x
BenchmarkReconstruct50x5x50000-8          54.49        397.43       7.29x
BenchmarkReconstruct10x2x1M-8            138.70       1008.93       7.27x
BenchmarkReconstruct5x2x1M-8             139.12        691.56       4.97x
BenchmarkReconstruct10x4x1M-8             70.62        514.15       7.28x
BenchmarkReconstructData10x2x10000-8     141.13        890.05       6.31x
BenchmarkReconstructData50x5x50000-8     172.97       1145.23       6.62x
BenchmarkReconstructData10x2x1M-8        677.44       4371.71       6.45x
BenchmarkReconstructData5x2x1M-8         708.23       3251.83       4.59x
BenchmarkReconstructData10x4x1M-8        354.99       2099.50       5.91x

Below are the test results:
linaro@linaro-alip:~/go/src/github.com/klauspost/reedsolomon$ go test -v
=== RUN   TestAssociativity
--- PASS: TestAssociativity (2.31s)
=== RUN   TestIdentity
--- PASS: TestIdentity (0.00s)
=== RUN   TestInverse
--- PASS: TestInverse (0.00s)
=== RUN   TestCommutativity
--- PASS: TestCommutativity (0.00s)
=== RUN   TestDistributivity
--- PASS: TestDistributivity (1.38s)
=== RUN   TestExp
--- PASS: TestExp (0.02s)
=== RUN   TestGalois
--- PASS: TestGalois (0.00s)
=== RUN   TestNewInversionTree
--- PASS: TestNewInversionTree (0.00s)
=== RUN   TestGetInvertedMatrix
--- PASS: TestGetInvertedMatrix (0.00s)
=== RUN   TestInsertInvertedMatrix
--- PASS: TestInsertInvertedMatrix (0.00s)
=== RUN   TestDoubleInsertInvertedMatrix
--- PASS: TestDoubleInsertInvertedMatrix (0.00s)
=== RUN   TestNewMatrix
--- PASS: TestNewMatrix (0.00s)
=== RUN   TestMatrixIdentity
--- PASS: TestMatrixIdentity (0.00s)
=== RUN   TestMatrixMultiply
--- PASS: TestMatrixMultiply (0.00s)
=== RUN   TestMatrixInverse
--- PASS: TestMatrixInverse (0.00s)
=== RUN   TestBuildMatrixPAR1Singular
--- PASS: TestBuildMatrixPAR1Singular (0.00s)
	reedsolomon_test.go:99: matrix [[1, 0, 0, 0], [0, 1, 0, 0], [0, 0, 1, 0], [0, 0, 0, 1], [1, 1, 1, 1], [1, 2, 3, 4], [1, 4, 5, 16], [1, 8, 15, 64]] has singular sub-matrix [[0, 0, 0, 1], [1, 1, 1, 1], [1, 2, 3, 4], [1, 8, 15, 64]]
=== RUN   TestEncoding
--- PASS: TestEncoding (0.19s)
=== RUN   TestReconstruct
--- PASS: TestReconstruct (0.22s)
=== RUN   TestReconstructData
--- PASS: TestReconstructData (0.24s)
=== RUN   TestReconstructPAR1Singular
--- PASS: TestReconstructPAR1Singular (0.00s)
=== RUN   TestVerify
--- PASS: TestVerify (0.16s)
=== RUN   TestOneEncode
--- PASS: TestOneEncode (0.00s)
=== RUN   TestEncoderReconstruct
--- PASS: TestEncoderReconstruct (0.15s)
=== RUN   TestSplitJoin
--- PASS: TestSplitJoin (0.01s)
=== RUN   TestCodeSomeShards
--- PASS: TestCodeSomeShards (0.01s)
=== RUN   TestAllMatrices
--- SKIP: TestAllMatrices (0.00s)
	reedsolomon_test.go:1013: Skipping slow matrix check
=== RUN   TestNew
--- PASS: TestNew (3.17s)
=== RUN   TestStreamEncoding
--- PASS: TestStreamEncoding (4.91s)
=== RUN   TestStreamEncodingConcurrent
--- PASS: TestStreamEncodingConcurrent (4.64s)
=== RUN   TestStreamReconstruct
--- PASS: TestStreamReconstruct (5.34s)
=== RUN   TestStreamVerify
--- PASS: TestStreamVerify (6.04s)
=== RUN   TestStreamOneEncode
--- PASS: TestStreamOneEncode (0.03s)
=== RUN   TestStreamSplitJoin
--- PASS: TestStreamSplitJoin (0.01s)
=== RUN   TestNewStream
--- PASS: TestNewStream (0.42s)
=== RUN   ExampleEncoder
--- PASS: ExampleEncoder (0.01s)
=== RUN   ExampleEncoder_slicing
--- PASS: ExampleEncoder_slicing (0.01s)
=== RUN   ExampleEncoder_xor
--- PASS: ExampleEncoder_xor (0.00s)
=== RUN   ExampleStreamEncoder
--- PASS: ExampleStreamEncoder (0.02s)
PASS
ok  	github.com/klauspost/reedsolomon	29.428s

@fwessels - looks very good. Could you merge master or rebase to resolve the conflicts?

@klauspost I have resolved the conflicts and pushed them, for now the new sliceXor() function is still unoptimized but it may be nice as an exercise for anyone try try their hands on some NEON code...


"Name Filtering" option is removing necessary ASM labels

I don't know if this is exactly your problem, but godbolt's ASM for this example (https://rust.godbolt.org/z/_Wczb9) doesn't have the problem, so it might be.
Repro: https://play.rust-lang.org/?gist=f5e688bd60fb8de5018b31d4f05e7ab5&version=nightly&mode=release&edition=2015
.LBB6_9:
	lea	r14, [r13 - 1]
	lea	r15, [r12 + r14]
	lea	rdi, [r12 + r13]
	mov	ebx, 1
	mov	rsi, r15
	mov	rdx, rbx
	call	memcpy@PLT
	add	r13, rbx
	mov	rbx, r13
	sub	rbx, r14
	mov	rdx, rbp
	sub	rdx, r13
	lea	rdi, [r12 + r13]
	cmp	rdx, rbx
	ja	.LBB6_10
	mov	rsi, r15
	call	memcpy@PLT
	mov	rax, qword ptr [rsp]    # 8-byte Reload
	mov	qword ptr [rax + 16], rbp
	add	rsp, 8
	pop	rbx
	pop	r12
	pop	r13
	pop	r14
	pop	r15
	pop	rbp
	ret

Note the jump to LBB6_10, which is a label not in the output.
Turn off name filtering, and you get instead
.LBB6_9:
	lea	r14, [r13 - 1]
	lea	r15, [r12 + r14]
	lea	rdi, [r12 + r13]
	mov	ebx, 1
	.p2align	4, 0x90
.LBB6_10:                               # =>This Inner Loop Header: Depth=1
	mov	rsi, r15
	mov	rdx, rbx
	call	memcpy@PLT
	add	r13, rbx
	mov	rbx, r13
	sub	rbx, r14
	mov	rdx, rbp
	sub	rdx, r13
	lea	rdi, [r12 + r13]
	cmp	rdx, rbx
	ja	.LBB6_10
# %bb.11:
	mov	rsi, r15
	call	memcpy@PLT
	mov	rax, qword ptr [rsp]    # 8-byte Reload
	mov	qword ptr [rax + 16], rbp
	add	rsp, 8
	.cfi_def_cfa_offset 56
	pop	rbx
	.cfi_def_cfa_offset 48
	pop	r12
	.cfi_def_cfa_offset 40
	pop	r13
	.cfi_def_cfa_offset 32
	pop	r14
	.cfi_def_cfa_offset 24
	pop	r15
	.cfi_def_cfa_offset 16
	pop	rbp
	.cfi_def_cfa_offset 8
	ret

Which has the LBB6_10 label, as it should.
(Sorry for not reducing the repro.)

/cc @chandlore

Thanks @scottmcm!  Looks like this broke when LLVM comments assembly were added with #397 - the regex isn't expecting a '#' to be present in a line that declares a label.
I'll take a crack at it tonight.

when LLVM comments assembly were added

Oops.


Broken test: GroupBy_Composite_Select_Dto_Sum_Min_Key_flattened_Max_Avg et all

This test fails with the following error:
System.ArgumentOutOfRangeException : Length cannot be less than zero.
Parameter name: length
   at System.String.Substring(Int32 startIndex, Int32 length)
   at Microsoft.CSharp.RuntimeBinder.Syntax.NameTable.Add(String key, Int32 length)
   at Microsoft.CSharp.RuntimeBinder.Syntax.NameManager.Add(String key, Int32 length)
   at Microsoft.CSharp.RuntimeBinder.SymbolTable.GetName(Type type)
   at Microsoft.CSharp.RuntimeBinder.SymbolTable.LoadSymbolsFromType(Type originalType)
   at Microsoft.CSharp.RuntimeBinder.RuntimeBinder.GetArgumentType(ICSharpBinder p, CSharpArgumentInfo argInfo, Expression param, DynamicMetaObject arg, Int32 index)
   at Microsoft.CSharp.RuntimeBinder.RuntimeBinder.CreateArgumentArray(ICSharpBinder payload, Expression[] parameters, DynamicMetaObject[] args)
   at Microsoft.CSharp.RuntimeBinder.RuntimeBinder.BindCore(ICSharpBinder payload, Expression[] parameters, DynamicMetaObject[] args, DynamicMetaObject& deferredBinding)
   at Microsoft.CSharp.RuntimeBinder.RuntimeBinder.Bind(DynamicMetaObjectBinder payload, Expression[] parameters, DynamicMetaObject[] args, DynamicMetaObject& deferredBinding)
   at Microsoft.CSharp.RuntimeBinder.BinderHelper.Bind(DynamicMetaObjectBinder action, RuntimeBinder binder, DynamicMetaObject[] args, IEnumerable`1 arginfos, DynamicMetaObject onBindingError)
   at Microsoft.CSharp.RuntimeBinder.CSharpGetMemberBinder.FallbackGetMember(DynamicMetaObject target, DynamicMetaObject errorSuggestion)
   at System.Dynamic.DynamicMetaObject.BindGetMember(GetMemberBinder binder)
   at System.Dynamic.GetMemberBinder.Bind(DynamicMetaObject target, DynamicMetaObject[] args)
   at System.Dynamic.DynamicMetaObjectBinder.Bind(Object[] args, ReadOnlyCollection`1 parameters, LabelTarget returnLabel)
   at System.Runtime.CompilerServices.CallSiteBinder.BindCore[T](CallSite`1 site, Object[] args)
   at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
   at Microsoft.EntityFrameworkCore.Query.GroupByQueryTestBase`1.<>c.<GroupBy_Composite_Select_Dto_Sum_Min_Key_flattened_Max_Avg>b__45_1(Object e) in /_/src/EFCore.Specification.Tests/Query/GroupByQueryTestBase.cs:line 751
   at System.Linq.EnumerableSorter`2.ComputeKeys(TElement[] elements, Int32 count)
   at System.Linq.EnumerableSorter`1.ComputeMap(TElement[] elements, Int32 count)
   at System.Linq.EnumerableSorter`1.Sort(TElement[] elements, Int32 count)
   at System.Linq.OrderedEnumerable`1.ToList()
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Microsoft.EntityFrameworkCore.TestUtilities.TestHelpers.AssertResults[T](IList`1 expected, IList`1 actual, Func`2 elementSorter, Action`2 elementAsserter, Boolean verifyOrdered) in /_/src/EFCore.Specification.Tests/TestUtilities/TestHelpers.cs:line 278
   at Microsoft.EntityFrameworkCore.TestUtilities.QueryAsserter`1.<AssertQuery>d__11`1.MoveNext() in /_/src/EFCore.Specification.Tests/TestUtilities/QueryAsserter.cs:line 334
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

CC @ajcvickers.

Issue in corefx. Filed https://github.com/dotnet/corefx/issues/30955

@maumar please check that this doesn't happen anymore.

@maumar Maybe the same as dotnet/corefx#21689(aspnet/EntityFrameworkCore#8962), since it's fixed in netcoreapp2.0.3, but efcore2.1 still use 2.0.0 for test
https://github.com/aspnet/EntityFrameworkCore/blob/7a4539d4080163cce39f658248e7649d9b12d8a8/build/dependencies.props#L17

@yyjdelete - Possible. Though EF Core uses 2.0.0 only on release/2.1 branch. Other branches (release/2.2 & master) are using 2.0.9.
@natemcmaster - Is 2.0.0 version in release/2.1 is some magic of auto-roll-forward or just oversight?

Looks like oversight. Universe builds with and runs tests on 2.0.7. I'm assuming something in the automation didn't run on EF Core to update it's local copy of deps.props

Re-triage, based on comments here: https://github.com/dotnet/corefx/issues/30955


Is nuxt.js support Vue3

What problem does this feature solve?
In your document, I saw it support Vue 2. I m working on VueJs 3 and my project has a requirement to create a  Vuejs Application Without Node, WebPack, or Any Other Build Process using Vue, Router, Vuetify, and Axios.

This feature request is available on Nuxt community (#c10640)

Duplicate of https://github.com/nuxt/nuxt.js/issues/5708


Add typing library to pipfile packages and remove Pipfile.lock

The typing library is required for building docs.
Remove unecessary inclusion of Pipfile.lock file. Add it
to the ignore list so that it's not comitted in the future.

@evan-a-a Do you know the answer to the above question?

@amyblais d'oh, sorry, for some reason I thought you were the submitter of the PR. @evan-a-a sorry - just wondering if you can explain a bit more what the reason is for this change, thanks.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Hey @evan-a-a, thank you for your contribution!
Would you be open to sharing more about the changes here? In particular

is there a reason for not checking in the Pipfile.lock? In my experience the convention is generally to check it in to ensure all users have the same versions of all the libraries, but wondering if there's a particular reason why this is not desirable here?

Hey @evan-a-a,
I'm closing this PR due to inactivity. Still, thanks for your contribution :+1:


unicode character classes not recognized

../reflex/RE-flex/src/reflex -yy --unicode --header-file=lex.yy.hpp polybasic.l
polybasic.l:77: error: malformed regular expression or unsupported syntax
error at position 13
[\p{Letter}\p{MiscellaneousSymbols}\p{Emoticons}\p{SupplementalSymbolsandPictog
___invalid character class
similar problems with \p{Emoticons} \p{SupplementalSymbolsandPictographs} etc...
i specified %option unicode as well as --unicode on the command line.
what am i doing wrong?

looks like the forum mangled the error.  \p{MiscellaneousSymbols} is what's causing the problem here

aha, seems you need \p{IsMiscellaneousSymbols} to make it work.  the documentation should probably be updated to make this more clear.  it wasn't very intuitive for me as an experienced programmer but first time user of this software.

Ah, I think you're right about the unnecessary confusion. The block name is isBlockName but the table does not include the is part. Will fix that.

Online manual is updated.


Wrong week dates for 2017

Description of the Issue and Steps to Reproduce:
Start of / end of week is wrong for 2017 (using custom locale)
When using a locale where:

first day of week = 1 (monday)
first day of year = 1 (january 1st)

I expect week 1 of 2017 to start on 2016-12-26 (monday) and end on 2017-01-01.
In reality, week 1 of 2017 starts on 2017-01-02 and ends on 2017-01-08.
Code to reproduce:
moment.locale("test", {
    parentLocale: "en",
    week: {
        dow: 1,
        doy: 1
    }
});

moment().locale("test").set("week", 1).startOf("week") // should be 2016-12-26
moment().locale("test").set("week", 1).endOf("week") // should be 2017-01-01

This is either a bug or the documentation is wrong on how dow / doy works.
Environment:
Chrome 57 on Windows
Firefox 52 on Windows
Other information that may be helpful:

Time Zone: UTC +01:00 (DST)
Date: 2017-04-13 14:43

If you are reporting an issue, please run the following code in the environment you are using and include the output:
Thu Apr 13 2017 14:44:12 GMT+0200 (Romance Standard Time)
13/4/2017 14:44:12
-120
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
2.18.1

It's correct that the first week of 2017 starts on 2nd Jan.

The  first  calendar  week  of  a  year  is  that  one  which  includes  the  first  Thursday  of  that  year
See ISO 8601-2004 (part 2.2.10) for details

You're talking about isoWeek.
I'm talking about week, specifically with a locale where dow = 1 and doy = 1.

It looks like the documentation is inconsistent about the behavior of dow and doy:
http://momentjs.com/docs/#/i18n/changing-locale/:
    week : {
        dow : 1, // Monday is the first day of the week.
        doy : 4  // The week that contains Jan 4th is the first week of the year.
    }

http://momentjs.com/docs/#/i18n/locale-data/:
localeData.firstDayOfWeek();  // 0-6 (Sunday to Saturday)
localeData.firstDayOfYear();  // 0-15 this and the first day of week are used
                              // to determine which is the first week of the
                              // year. dow == 1 and doy == 4 means week starts
                              // Monday and first week that has Thursday is the
                              // first week of the year (but doy is NOT simply
                              // Thursday).

I don't think these two descriptions are equivalent.
@ichernev Do you know offhand what the intended behavior is?  I suspect the latter description is more accurate, but I don't know for sure.

We've been through this discussion before.  There's an open docs issue at moment/moment.js#279.

What about the wrong tests here?

A few lines of code answer a lot of questions:
// start-of-first-week - start-of-year
function firstWeekOffset(year, dow, doy) {
    var // first-week day -- which january is always in the first week (4 for iso, 1 for other)
        fwd = 7 + dow - doy,
        // first-week day local weekday -- which local weekday is fwd
        fwdlw = (7 + createUTCDate(year, 0, fwd).getUTCDay() - dow) % 7;

    return -fwdlw + fwd - 1;
}

Now, what the hell is dow and doy -- I don't know. Maybe for a major release we can fix this madness and have doy be the weekday that determines the first week, now it is just the 2 numbers that you put in the formula above.


Add unit ontology support in sheet editor

What it says on the tin. It was agreed to postpone this to a subsequent release, adding 0.10 as the milestone for now.

Enable editing units as ontology term references
Add a management command or a migration script to update existing unit references

There have been more questions about unit ontology support lately. The prioritization of this should be discussed.


Removed hardcoded url structures from RSS

This PR removes a bunch of unnecessary reliance on the hardcoded structure of what a tag or author URL looks like, which requires us to grab the configured routeKeywords and do a path join.
Instead, we now only have the assumption that paginated RSS pages will end with /pageNum/ and that we can replace this with just / safely.
refs #5091

This removes hardcoded config to generate feed urls
This means that RSS feeds work properly for custom channels
Remaining assumption is that paginated feeds will end /pageNum/
Added extra tests
768ea81

The atom:link now shows search parameters, not sure that can trouble rss readers.

Good catch 🎣  have added url parsing to only deal with the path.


spirv-fuzz: Fix to outliner

Adds an extra condition on when a region can be outlined to avoid the
case where a region ends with a loop head but such that the loop's
continue target is in the region.  (Outlining such a region would mean
that the loop mere is in the original function and the continue target
in the outlined function.)

Typo in PR description: "loop mere"?

Typo fixed, thanks.


"Loose" molecule index

The current molecule hash is effecitvely a identity check with the current fields:

Exact matches on "symbols", "multiplicity", "real", "fragments", "fragment_charges", and "fragment_multiplicities".
1.e-6 match on "mass"
1.e-4 match "charge"
1.e-8 match on "geometry"

This hash should be effectively a unique index allowing for a quick search of identical molecules. For more approximate searches that may return many molecules there have been several suggestions of new molecule hashes:

atom_count = "".join([sym + symbols.count(sym) for sym in set(symbols]) e.g., C6H6 for benzene. Very simple and possibly sieves queries down dramatically.
Similar to the current molecule_hash with a canonical symbol order, orientation, center of mass, and loose geometry match (~1e-2). This hash would allow quick identification of similar molecules.
SMILES - How do we obtain a "canonical" ordering that is deterministic.

Note that a hash search of a molecule is O(log(N)) while a direct comparison is O(N). As the database project expects on the order of O(1e8-9) molecules this difference is insurmountable.
New indices should be discussed and added on an as-needed basis.

Came across chemfp this weekend. unfortunately the free version doesn't have py3 support. The author is the fellow whose blog posts taught me how to do the hover-over-graph-to-get-molecule-img-popup for BFDb. Seemed potentially relevant.

Thanks, it looks interesting. Running a function on a query and every molecule in the database would be too expensive. We may be able to get by with a sieve + something like this, however.
On that note, we will probably bake something like cmiles in.

Sure. The cmiles definitely looks more tightly focused. At least the chemfp is recorded, and I've closed a browser tab. :-)


Remove unnecessary else

@hezhizhen thanks for opening this PR. Please read our CONTRIBUTING document here and here to get this PR approved. It also has failing tests because linting problems.

Sorry for replying late. I'll fix it later.

Implemented with #755.


Release 5.4.2 is Broken for Framework 4.8

https://github.com/dadhi/DryIoc/blob/fd09e1919150df8f4c928321b58678fe04dc7e29/src/DryIoc/Container.cs#L14370
This line doesn't compile in Framework 4.8 because is uses ">>>", Unsigned Right Shift Operator which has been introduced in C# 11.  Framework 4.8 supports C# Version 7.3.  Adding LangVersion preview to project configuration did not help.
Can you please fix this issue, perhaps by adding some sort of pragma directive.

Ok, will fix. thanks for notifying.

Thank you Dhadhi
For now, successfully built the file by replacing the offending line with -
factoryId = (int)((uint)factoryId >> 16);
Regards,

It has been in introduced in C# 11, a few months ago, back in March.


incompatbile use patterns for bl:interacts_with

There are two uses of bl:interacts_with:

Relational: ?x bl:interacts_with ?b

Example:
prefix owl: <http://www.w3.org/2002/07/owl#>
  prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
  prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
  prefix bl: <https://w3id.org/biolink/vocab/>
  SELECT ?p1 ?p ?p2 WHERE
  {
  ?p1 bl:interacts_with ?p2 .
  } LIMIT 10

Reified edge

Example:
prefix owl: <http://www.w3.org/2002/07/owl#>
  prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
  prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
  prefix bl: <https://w3id.org/biolink/vocab/>
  SELECT ?p1 ?p ?p2 WHERE
  {
  ?interaction bl:edge_label bl:interacts_with .
  ?interaction bl:object ?p1 .
  ?interaction bl:subject ?p2 .
  ?interaction bl:relation ?p .
  } LIMIT 10

This makes it very difficult to consistently query all interactions.. You should probably pick one way (probably the second) and stick with it..

I can see the same for bl:regulates and the reified version with obo:RO_0002211..

I don't think this is mistake - @deepakunni3 can you confirm?
If I understand correctly from the convo yesterday, this is a deliberate design decision resulting from the fact that when reifying edges, we keep the original edge too

We follow RDF reification standards (and thus RDF*), the spo edge must always be present regardless of whether an edge is reified or not.
I think the question is: should all edges be reified? RDF doesn't require this of course but it can be nice for consistency of queries. If we have the rule that each edge must have at least provide_by then this entails reification. This should be the case for all database ingests. We may want to inject for ontologies

So from an analysis standpoint, we can simply ignore all reified edges then? So if I find any:
?r bl:relation ?p;
     bl:object ?o;
     bl:subject ?s .

where there is no corresponding ?s ?p ?o . edge, it is a bug? (we have that case for example for a lot of the interactions).


Dev follow ups on keycloak

Follow up on: https://github.com/rancher/rancher/issues/30280
For light technical changes.

Follow up needed:
the keycloak token isn't being refreshed on timeout
(manually logged out & in)```

Closing this as it will be tested via the other 2 keycloak issues


Latest homebrew install of qt5 for MacOS is 5.15.15, and is not supported in spack-stack

Describe the bug
When installing spack-stack on MacOS Sonoma 14.4.1 using Homebrew, the latest release of qt5 for Homebrew is 5.15.15 as of October 2024. Any new user that does auto-updating of Homebrew packages might inadvertently upgrade qt5 to an unsupported/qualified version.
To Reproduce
Steps to reproduce the behavior:
Follow https://spack-stack.readthedocs.io/en/develop/NewSiteConfigs.html#macos making sure to run latest homebrew updates on packages.
Expected behavior
Either need to support 5.15.15 in the future, or update docs to provide steps to downgrade qt5 to 5.15.13.
System:
What system(s) are you running the code on?
MacOS only
Additional context
This is really only a documentation problem until qt 5.15.15 is qualified for spack-stack.

What is the problem with 5.15.15 ? I think any qt@5 will do.

You're right, I had a problem using the newest version of Apple clang which had problems with qt@5.


fix typo in README.md

Thanks for the effort @Ben-Hampson but I since this fix is already included in #12, which also fixes a language usage error, I think maintainer is best advised to merge that PR instead of this one...

Thanks for the PR @Ben-Hampson . As @reduxionist already pointed out, there was already a PR to address this, which I chose to merge. We are, however, happy to see your further contributions to Pynguin!


Typing switch into the terminal opens the moons selector

Typing switch into the terminal opens the moons selector, but typing switch <player> changes the currently targeted player.
This started happening after upgrading lategame, so I assume it's a bug here.

So:

Started a game
Went to the Terminal
typed switch
It prompted Switching radar cam view
typed switch <player>
It prompted Switched radar to player

Am I missing a step here? Because I can't seem to reproduce the behaviour you're describing.

I can't consistently reproduce it either. Either way, I don't think its a bug with LategameUprgades, just started happening when it was updated.

Hey @ofoxsmith, are you using Wesleys_Moons?


Getting Entity names into a list for DDL

I am working on a project using EFCore with CodeFirstapproach and I am stuck in an issue which is to get all entities or table names into a list and show them in a view as a DropDown List.

@nexawo This question is too vague. For example, at what point do you want to get all entities? From the built model?

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Understanding http auth for getting json

Hi,
I am trying to use the deployer to avoid cache problems in my microfronts.
I require to update the import-map.json there is some kind of security like username and password, but when I want to fetch it from my container (index.html) I don't want to use the http auth.
is there any configuration for the import-map-deployer to act this way?

now I understand the use of import-map-deployer


Add Update to ANTLR grammar

This PR is just some noisy prep-work. Add the Update grammar to ANTLR grammar, which was explicitly removed. The implementation only reports that SPARQL 1.1 Update is not supported. I did not add the rules related to named graphs in SparqlQleverVisitor.
In the spec the rules for Update and Construct+Query have no common root. I deviated from the grammar given in the spec by introducing unit as a common root.

@Qup42 might wanna add a pre-commit hook for clang-format.


cosmetics and grep fixed

sudo cosmetic and fixed grep failure - already discussed with Markus

Updates discussed and confirmed


SPARQL query request incorrectly adds trailing slash to endpoint URL

The url="" line in methods.py is adding a trailing slash to the endpoint URL, resulting in a 404 error for some queries (e.g., for a Fuseki server, http://localhost:3030/ogc-hosted/update works, but http://localhost:3030/ogc-hosted/update/ does not).
url=be_endpoint can be set as a workaround (although it seems a little redundant).

This also results in 500 errors when running CONSTRUCT. Can confirm that the workaround does indeed work.

Closed in https://github.com/RDFLib/prez/pull/127.


Efficiency improvements in cupyx.scipy.ndimage utilities

This PR changes the _get_output utility to initialize output arrays to empty rather than zeros for efficiency. This utility is used by all filtering, morphology and interpolation functions in ndimage.
It also removes the need for a copy in the _run_1d_filters utility when the number of filters is even. This utility is used by functions like gaussian_filter and uniform_filter to apply a 1d filter along each axis of an array in turn.
These two changes give improvements on the order of 5-10% in some cases I tested.
A separate _init_weights_dtype utility was added and used in a few of the separable filters to avoid unnecessary double precision computation for the sobel and prewitt filters. On my system this gives > 2x improvement for these because previously the integer valued kernels would get promoted to float64 even when the input was float32. I applied this utility to gaussian_filter and uniform_filter as well, but there the impact is much lower as the kernel values were already floating point and so were already being copied to a precision matching the input by _get_weights_dtype later on.

/test mini

/test mini

/test jenkins

/test jenkins


Any Readme file or guidelines to follow for the new HTK - Unity 5.5?

Hey, I've been using the previous version of HTK for a while and found my way across it quite well. I see that there have been major changes in 5.5 and my older projects dont work with the new HTK anymore. Is there any readme file/guidelines for migrating to use the new functionalities of 5.5?

Your best bet with the input changes are:

https://github.com/Microsoft/HoloToolkit-Unity/blob/master/Assets/HoloToolkit/Input/Tests/Scenes/InputTapTest.unity
https://github.com/Microsoft/HoloToolkit-Unity/blob/master/Assets/HoloToolkit/Input/Tests/Scenes/InputManagerTest.unity

Please let us know if you have any specific questions.

Unfortunately, I don't think anyone has taken the time to write a upgrade guide.
Any insight would be beneficial to anyone still trying to upgrade.

I could only find a handy website with a post that talks about basic implementation of the new 5.5
Hopefully someone finds some use of it
https://livierickson.com/blog/unity-5-5-and-the-holotoolkit-changes-in-input-when-developing-hololens-apps/

I think having upgrade guides is good.
https://github.com/Microsoft/MixedRealityToolkit-Unity/issues/882


Great work! Can we run the code on multi-host node?

I wonder if the code is based on PL. Is it possible that I run the code on two computers, each with 4GPUs? Something like
python -m torch.distributed.launch --nproc_per_node 4 --nnodes 2 --node_rank 0 --master_addr='xxx.xxx.xxx.xxx' --master_port='80' train.py
Looking forward to your reply.

It should be possible by setting devices=4, num_nodes=2 in the trainer:
https://github.com/kwea123/ngp_pl/blob/6b2a66928d032967551ab98d5cd84c7ef1b83c3d/train.py#L264-L274
See more options here
I have tested one node with multiple gpus, but didn't test multi-nodes. Please report if it works with multi-nodes, thank you.


feat: postgres specify search path

A few things left todo:

[ ] Fix some non-determinism with set_schema on the thread pool
[ ] Add tests which have more than one schema
[ ] Document the schema parameter in the integrations docs


write a custom message on the PR thread

Great library! great work!
We're using a merge bot Miro, which merges PRs that write a message miro merge on the PR thread (after CI passes).
I was wondering if it would be possible to config dependabot to write some custom message on the PR thread, apart from the original commit description.
Just to clarify, by PR thread I mean the same place where I give dependabot comands like @dependabot rebase

This would be quite useful for bors as well, which is widely used in the Rust ecosystem. For bors specifically, because it gates on CI passing on the staging branch rather than the PR itself, merging via bors can be semantically different from just "merge when green and up to date", because the staging branch can run different CI checks.

Now that we have dependabot/fetch-metadata you should be able to do that with a custom github action
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#common-dependabot-automations

Yep, exactly what @mwaddell wrote ☝.


Reporter shouldn't attempt to send anything if there are no metrics collected yet

If there are no metrics available yet, the reporter sends an empty document to elastic, which results in an HTTP error from elastic. The send should be bypassed if there's nothing to send yet.
The response from elastic is:
HTTP/1.1 400 Bad Request
{"error":"ElasticsearchParseException[Failed to derive xcontent]","status":400}

And my logs are littered with:
2015-12-11 17:24:09,336 ERROR Reporting returned code 400 Bad Request: {} [metrics-elasticsearch-reporter-thread-1] (org.elasticsearch.metrics.ElasticsearchReporter) [] - [/]

just did a release where this is included


Appstore billing usage end points

Add in usage/metered api end points for app store.
Description
There has been a few changes internally which is missing on here
Source: https://developer.xero.com/documentation/api/xero-app-store/metered-billing
Release Notes
Aligns more with the new metered billing feature
Screenshots (if appropriate):
Types of Changes

[ ] ~Bug fix (non-breaking change that fixes an issue)~
[x] New feature (non-breaking change that adds functionality)
[ ] ~Breaking change (fix or feature that would cause existing functionality to not work as expected)~

UsageRecord and UsageRecordsListItem differ?
They're different from the internal api atm, but I see why you'd ask the question.
@panzors any reason why we wouldn't consolidate them?

UsageRecord and UsageRecordsListItem differ?

They're different from the internal api atm, but I see why you'd ask the question. @panzors any reason why we wouldn't consolidate them?

PUT/POST responds with the pure entity/record
the GET (list) response was written with multiple subscriptionitem in mind so it needed additional information on the return as the URL parameters were rooted at subscription

UsageRecord and UsageRecordsListItem differ?

They're different from the internal api atm, but I see why you'd ask the question. @panzors any reason why we wouldn't consolidate them?

PUT/POST responds with the pure entity/record
PricePerUnit is the only difference there. I'm not sure why we didn't at the time.

So should these models be consolidated?

Thanks team, I've made some adjustments as per request internally and UsageRecordsListItem is now gone and merged into UsageRecord object
Sorry for the confusion


Source Code for Number of Subsequences of the form a^ib^ic^k i…

…n C++
Related Issue
Solved issue number: #562
Describe the changes you've made
Adding Source Code for Number of Subsequences of the form a^i b^j c^k in C++
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Language used for coding
C++
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have documented the code.
[x] New and existing unit tests pass locally with my changes.

Please review my code ;-)

Hey, your folder name should be the problem name on the practice section, which is "Count subsequences of type a^i, b^j, c^k". So just change your folder name from Number of subsequences of the form a^i b^j c^k to Count subsequences of type a^i, b^j, c^k


Final draft of wireframes

Complete final draft of RiskProfiler wireframes.

Closing as Phase 1 draft wireframes were completed.
https://github.com/OpenDRR/riskprofiler/tree/master/nrcan-wireframes-v3.0


AC1.1: Add an Account -- New Account Selection Screen

Top-Level Options given:

Add a new Account
Add a Service
Import a Wallet.

New Account options given:

Test Account
Checking Account,
Savings Account
Donation Account (directly accept donations),
Joint Account (Account with Friends and Family).

Services options given:

Swan Bitcoin (stack sats with Swan),
FastBitcoins.com (Use FastBitcoin Vouchers),
Whirlpool Account (powered by Samurai)

Import a Wallet options:

Watch Only (View a non-Hexa wallet as an account)
Full Import (Fully import and manage a non-Hexa wallet)

(🗒  Each account setup will have a very different flow)

new UX expected with 'Comming soon' and 'New'

@antuz123 I added some initial graying and disabling functionality as part of #2197. Should we tag this to a later release so we can circle back when the design is finished?

Let's see the UX, may not be very difficult to implement. We can take a call then @CypherPoet

-Verified this issue on dev app version 1.4.0(180)

-Joint Account (Account with Friends and Family).
This option is missing in New account options

Joint account is not available yet and will be available in a future release. We can close this issue.


Pool not working with Zcash 1.0.6

hi,
Pool not working with Zcash 1.0.6,
got payment issue first but then all the pool not respond to remote mining software.
thank's :-)
/root/z-nomp/node_modules/stratum-pool/lib/stratum.js:447
if (options.tlsOptions.enabled == true) {
^
TypeError: Cannot read property 'enabled' of undefined
at init (/root/z-nomp/node_modules/stratum-pool/lib/stratum.js:447:31)
at new StratumServer (/root/z-nomp/node_modules/stratum-pool/lib/stratum.js:476:7)
at StartStratumServer (/root/z-nomp/node_modules/stratum-pool/lib/pool.js:442:31)
at /root/z-nomp/node_modules/stratum-pool/lib/pool.js:55:25
at /root/z-nomp/node_modules/stratum-pool/lib/pool.js:91:13
at /root/z-nomp/node_modules/stratum-pool/lib/pool.js:579:25
at itemFinished (/root/z-nomp/node_modules/stratum-pool/lib/daemon.js:155:36)
at /root/z-nomp/node_modules/stratum-pool/lib/daemon.js:169:17
at parseJson (/root/z-nomp/node_modules/stratum-pool/lib/daemon.js:85:17)
at IncomingMessage. (/root/z-nomp/node_modules/stratum-pool/lib/daemon.js:95:17)
2017-02-18 15:43:43 [Master]    [PoolSpawner] Fork 2 died, spawning replacement worker...

can you remove your node_modules and do npm install?

Hi,
i try this, did not resolved the error,  getting the same error.

can you use a new config from the examples?

This should be fixed now. Please run the code below to update:
git pull
npm update
npm install

https://github.com/z-classic/node-stratum-pool/commit/c755863595fd630d55a6e4c8f4886b98468a978f

ok, thank you
when i do npm update i'm getting:
../src/equi/equi.c: In function 'isZero':
../src/equi/equi.c:78:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int i = 0; i < len; i++) {
^
CC(target) Release/obj.target/libequi/src/equi/endian.o
SOLINK(target) Release/obj.target/equi.so
COPY Release/equi.so
CXX(target) Release/obj.target/equihashverify/equihashverify.o
In file included from ../equihashverify.cc:8:0:
../src/equi/equi.h:22:13: warning: 'void digestInit(crypto_generichash_blake2b_state*, int, int)' declared 'static' but never defined [-Wunused-function]
static void digestInit(crypto_generichash_blake2b_state S, const int n, const
^
../src/equi/equi.h:24:13: warning: 'void expandArray(const unsigned char, size_t, unsigned char*, size_t, size_t, size_t)' declared 'static' but never defined [-Wunused-function]
static void expandArray(const unsigned char in, const size_t in_len,
^
../src/equi/equi.h:28:12: warning: 'int isZero(const uint8_t, size_t)' declared 'static' but never defined [-Wunused-function]
static int isZero(const uint8_t hash, size_t len);
^
../src/equi/equi.h:30:13: warning: 'void generateHash(crypto_generichash_blake2b_state, uint32_t, uint8_t*, size_t)' declared 'static' but never defined [-Wunused-function]
static void generateHash(crypto_generichash_blake2b_state *S, const uint32_t g,
^
SOLINK_MODULE(target) Release/obj.target/equihashverify.node
COPY Release/equihashverify.node
and when i start the pool - i'm geting:
/root/z-nomp/node_modules/bs58check/index.js:48
if (!payload) throw new Error('Invalid checksum')
^
Error: Invalid checksum
at Object.decode (/root/z-nomp/node_modules/bs58check/index.js:48:23)
at Object.fromBase58Check (/root/z-nomp/node_modules/bitcoinjs-lib-zcash/src/address.js:8:27)
at Object.exports.createGeneration (/root/z-nomp/node_modules/stratum-pool/lib/transactions.js:87:46)
at new BlockTemplate (/root/z-nomp/node_modules/stratum-pool/lib/bl

Almost there! That npm update error isn't anything to worry about.
To fix the invalid checksum error you'll need to make sure that all of the addresses are correct in your config file and have quotations around them. If you post your config file (with the passwords removed I can steer you in the right direction)

ok guys, thank you for all your help,
i delete all and reinstall it again and it's working now.
thank you for great work guys, i appreciate it :-)


Fix typo in helix::search::Channel

The field "tags_ids" is supposed to be "tag_ids" :)

awesome, thanks!
Going to file an issue of wrong docs
bors r+

You are welcome man :)


(fix) create SQL in data_project

I am using DATA_PROJECT_NAME instead of SQL_PROJECT_NAME since the latter is specific to my deployment repo and not included here. I also made sure the region matches DATA_REGION.

after thinking about this i realized this would break our deployments, where we have bigtable in the DATA_PROJECT_NAME but SQL instances in the PROJECT_NAME.  I think we have to think harder about how to support the different variations of where the SQL_SERVER is.  I think having the environment variable of POSTGRES_PROJECT=[DATA_PROJECT_NAME, or PROJECT_NAME] and using POSTGRES_PROJECT in all the templates would work.


The issue URL is not added to the message when Sentry is self-hosted

I've noticed that, in my discord server, the message does not embeds the URL of the issue.
I initially thought it was a missing feature; However, inspecting the sources, I've noticed this lines in message.js:
  const link = parser.getLink(event);
  if (
    link.startsWith('https://sentry.io') ||
    link.startsWith('http://sentry.io')
  ) {
    embed.setURL(parser.getLink(event));
  }

Check here: https://github.com/IanMitchell/sentrydiscord.dev/blob/main/lib/message.js#L32
Why is this clause there?
Is there some security reason?
If it's ok to remove this if statement, I can make a PR.

Hey! I added that because in some instances I was getting relative URLs, which Discord's API rejects. I'll update this to drop the sentry.io bit, thanks for the report!


polish locale

not tested because it doesn't compile at all

add it to the amethyst.ts
https://github.com/Geoxor/Amethyst/blob/v2/src/renderer/amethyst.ts#L26-L33


[RFC] Create a candidate list for deprecated feature removal

[RFC] Create a candidate list for deprecated feature removal
Today Kata containers has grown to have a lot of features and capabilities. Some of these capabilities are options which a user can choose from. These have evolved over time and newer capabilities have replaced older ones for the same feature. This results in code complexity without additional value. The goal of this issue to identify candidates for removal and leave just the ones that work best for a given hypervisor.
This also increases our validation burden.
This will also allows to default to an implementation for a given hypervisor.
For QEMU/NEMU:

Networking: Bridge mode, macvtap mode and tcmirror
- Eliminate Bridge mode as tcmirror replaces it
Storage: virtio-blk, virtio-scsi and virtio-mmio
- Eliminate virtio-blk (is there any need for it). It is simpler however.
VM to Host: vsock, virtio-serial
- Too early to eliminate virtio-serial but if our user base has newer kernels we can consider eliminating serial

I'm OK with removing most components above, except virtio-serial, @sameo and @bergwolf have done good summary.
When we're trying to remove these features, one more important question is:
Is there anyone using it? When we remove the feature, will it make someone angry?
Removing codes from current base can always bring risk of breaking something, I think a safe way to do this is, we mark the feature "deprecated" but still keep it in current code for two (or more) releases, print warnings when users are using it, then finally do real deletion when there's nobody jumps up to oppose the deletion.
So far I don't think we have many users, so if you want to delete some codes, do it ASAP before someone put it in real production :smile:

do it ASAP before someone put it in real production

@WeiZhang555 Agree, deprecate out-of-date features as soon as possible to prevent from confusing newcomers.

I tend to agree. The problem is we don't know if users are already relying on particular features in a production scenario.
"At some point", we're going to need to handle removing deprecated features more carefully: announce that "feature X"...

Will become deprecated in Kata version A.B.C.
Will be removed in Kata version A.${foo}.C.

We use semver across all Kata developed components. Conveniently the semver specification explains what we need to do to deprecate features:

https://semver.org/#how-should-i-handle-deprecating-functionality

This got me thinking about @WeiZhang555's https://github.com/kata-containers/runtime/pull/1227's "experimental feature" PR...

Feature type
Stable
When will it be removed from Kata?

experimental
no
could be removed at any time (or may become a standard feature)

deprecated
yes
at a definite time

Clearly, there is similarity there. So, we could potentially refactor the experimental feature once it lands to allow users to query which features are going to be removed at some future date:
$ kata-runtime kata-env | grep -i deprecated

Ideally, that output would show the following for deprecated features:

Feature name.
Feature description.
The semver (future) release version when the feature will be removed.
Maybe even the semver version when the feature was originally introduced?

Since the output of kata-env is machine readable, that could be quite useful for admins and the handling of deprecated features becomes self-documenting. We should still highlight features that will be deprecated at a future date when we make a release though:
$ kata-runtime kata-env | grep -i deprecated >> ./release-notes.txt

@jodh-intel Nice summary :handshake:

We still have dependency on virtio-serial, thanks!

@devimc @mcastelino @sboeuf @jodh-intel just have systemd or agent as init will simply our testing.

Related to systemd as init or not: https://github.com/kata-containers/documentation/wiki/Kata-images

I've noticed virtc doesn't seem to be working at the moment, and uses the hyperstart and cc implementations rather heavily. After talking with @sboeuf it may not be the best ROI to fix it. How would you all feel about including it as a candidate for removal?


Updated swagger file for PowerBI

Updated some text, added some enums, and added bold text.

LGTM - Thanks Kurlak!


When new release?

Issue description
Not actually an issue, but a question
First at all, Thank you for your work and this library. It's fantastic!
Last month you add new feature (#1743) I would love to use in my project.
When do you plan to publish via npm new realise that will include that feature?

Whenever @SebastianM gets back


Metasploit::Cache::Payload::Single::Class

MSP-12298
Pre-verification Steps

[ ] Merge #24

Verification Steps

[ ] rm Gemfile.lock
[ ] bundle install

Test coverage

[ ] rake cucumber spec coverage
[ ] VERIFY no failures
[ ] VERIFY 100% coverage

Documentation

[ ] rake yard
[ ] VERIFY only warns are the following:

[warn]: @param tag has unknown parameter name: module_instances
    in file `app/models/metasploit/cache/module/class.rb' near line 147
[warn]: @param tag has unknown parameter name: module_instance
    in file `app/models/metasploit/cache/module/instance.rb' near line 317
[warn]: @param tag has unknown parameter name: architecture_abbreviations
    in file `app/models/metasploit/cache/module/instance.rb' near line 336
[warn]: @param tag has unknown parameter name: architectured
    in file `app/models/metasploit/cache/module/instance.rb' near line 353
[warn]: @param tag has unknown parameter name: platforms
    in file `app/models/metasploit/cache/module/instance.rb' near line 367
[warn]: @param tag has unknown parameter name: platform_fully_qualified_names
    in file `app/models/metasploit/cache/module/instance.rb' near line 403
[warn]: @param tag has unknown parameter name: module_target
    in file `app/models/metasploit/cache/module/instance.rb' near line 420
[warn]: @param tag has unknown parameter name: module_instance
    in file `app/models/metasploit/cache/module/instance.rb' near line 434
[warn]: @param tag has unknown parameter name: module_target
    in file `app/models/metasploit/cache/module/instance.rb' near line 492

[ ] VERIFY no undocumented objects

Post-merge Steps
Perform these steps prior to pushing to master or the build will be broken on master.
Version

[ ] Edit lib/metasploit/cache/version.rb
[ ] Remove PRERELEASE and its comment as PRERELEASE is not defined on master.

Gem build

[ ] gem build *.gemspec
[ ] VERIFY the gem has no '.pre' version suffix.

RSpec

[ ] rake spec
[ ] VERIFY version examples pass without failures

Commit & Push

[ ] git commit -a
[ ] git push origin master

Coverage decreased (-0.09%) to 99.56% when pulling c8869d17a87ca58060448aa19a308afc68780a91 on feature/MSP-12298/payload-single-class into 44513d6b8e8d04d195e5bd236a7d8fa6adae4913 on master.

Coverage decreased (-0.11%) to 99.53% when pulling c8869d17a87ca58060448aa19a308afc68780a91 on feature/MSP-12298/payload-single-class into 44513d6b8e8d04d195e5bd236a7d8fa6adae4913 on master.

Coverage decreased (-0.11%) to 99.54% when pulling c3b26c22c7e87cae2a22c71a5d9707e698e77105 on feature/MSP-12298/payload-single-class into 44513d6b8e8d04d195e5bd236a7d8fa6adae4913 on master.

Coverage decreased (-0.11%) to 99.54% when pulling 28c3472d86285f54f500363058c4fb5072e7e168 on feature/MSP-12298/payload-single-class into 44513d6b8e8d04d195e5bd236a7d8fa6adae4913 on master.


Document testing

We used to have a test Mobile Commons campaign setup for the Yeah Science  staging campaign, but it seems that Mobile Commons campaign has ended (and Yeah Science is unpublished?)
The "Staging test reportback" mData pointed to http://dev-mdata-responder.herokuapp.com/reportback/staging-test, which is the first I've seen of this URL. Sounds like ideally we should point a Mobile Commons campaign and its mData to our new staging URL: https://ds-mdata-responder-staging.herokuapp.com/ to update production with our official 1.0.0 release.
Looking to document how and where to test, refs #527

Looks like the staging server will cost us an extra $7 - I don't have access to set it to the Free dyno, but not sure if that would affect testing. My guess is posting to the staging server would just start it up and take a while to get to the tester..

https://github.com/DoSomething/ServerConfig/wiki/4.1-Gambit-Staging


Script(s) to generate contexts and swift output files

Create a bunch of scripts to:

Generate context plist files based on fixtures.
Generate output files based on templates and contexts.

THe first item is implemented in https://github.com/SwiftGen/SwiftGen/issues/286.

Isn't that already closed?


Tests Fail on Initial Clone

Describe the bug
Building DependencyCheck using the listed instructions results in a test failure:
[ERROR] Failures:
[ERROR]   RubyBundleAuditAnalyzerIT.testAnalysis:128
[ERROR] Errors:
[ERROR]   RubyBundleAuditAnalyzerIT.testAddCriticalityToVulnerability:159 ArrayIndexOutOfBounds
[INFO]
[ERROR] Tests run: 67, Failures: 1, Errors: 1, Skipped: 2

A quick glance at DependencyCheck/core/src/test/java/org/owasp/dependencycheck/analyzer/RubyBundleAuditAnalyzerIT.java seems to point to an issue with dependency parsing in the test Gemfile.lock files.
Version of dependency-check used

On macOS 10.15.7.
I'm at commit 3adf3e4fa77473ef6c8ba8cd35b41d9a3457c528.
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
openjdk version "1.8.0_265"
dotnet 3.1.405
go version go1.15 darwin/amd64
bundler-audit <IP_ADDRESS>
yarn 1.22.10

Log file
https://gist.github.com/Will-Low/2f4709d49eb6269521c9c50ca259e057
To Reproduce

Go to cloned DependencyCheck repo
Run mvn -s settings.xml install

Expected behavior
Tests should be passing.

Do you have the documented pre-reqs installed?  https://github.com/jeremylong/DependencyCheck#development-prerequisites

Yes. All prereqs are installed and version information is included above.

My guess is that somehow the path is not being sent to the JVM correctly - so it can't find bundle audit. There is property for the path: https://github.com/jeremylong/DependencyCheck/blob/084806ee5be3824be00e2971b537dfbf2fba2979/utils/src/main/java/org/owasp/dependencycheck/utils/Settings.java#L536
So you can try setting JAVA_OPTS=-Danalyzer.bundle.audit.path=path/to/bundle-audit


Dynamic ellipsis in slider cards

Fix dynamic ellipsis in slider cards
🔗 Test URLs:

Before: https://main--caesars--hlxsites.hlx.page/caesars-palace/
After: https://authoring-slider-cards--caesars--hlxsites.hlx.page/caesars-palace/

📝 Description:

Dynamic ellipsis in slider cards
Increase size card for extended text so more text fits and doesn't get cut off
Changes authoring experience to author only the text, short text is done dynamically

Note: To get the correct ellipsis text, this PR will need a fix that is in https://github.com/hlxsites/caesars/pull/112 (in the meantime the text is NaN).


Multiple widgets in a single form

Hi, currently it seems like this doesn't support having multiple date fields in one form.  For some reason the Javascript/Bootstrap bugs out.  Any ideas?

I found my problem.  I mistook the id parameter for a timezone id.  Making sure that they had unique id's did the trick.


Comply to oslo_config 6.0.0+

The MultiConfigParser was removed from oslo_config 6.0.0
and beyond. This patch enables the apic-ml2-driver package
to support both pre-6.0.0 and post-6.0.0 oslo_config installations.

Updated patch, addressing reviewer comments.


Convert Escapers to Kotlin Multiplatform

Depends on

[ ] #43
[ ] #44

I've found an alternative library instead https://github.com/ethauvin/urlencoder/ which is much more suitable for Kotlin Multiplatform. I'll make a new PR.


Enforce predefined set of allowed provided container deps.

FYI: @bratseth, @hmusum, @aressem

FYI: Versions from the parent pom will be used in a later PR.


Introduce Field & DataSet to eliminate sub-trainers & sub-testers

Field, Instance & DataSet
dataset.py defines DataSet, which is a list of Instances.
instance.py defines Instance, which is a single example and contains multiple Fields.
field.py defines Field, which is the elementary data type or representation.
TextField defines a list of strings. LabelField defines single interger or string.
You can add extra fields to support more complex data.
Each field

has a field name
has a is_target boolean argument to specify whether it is Y or not (X) in training.
has a to_tensor method to define how this field data is transformed into tensors

dataset.py defines a function to make DataSet from a list.
def create_dataset_from_lists(str_lists: list, word_vocab: dict, has_target: bool = False, label_vocab: dict = None) --> DataSet:

Example: https://github.com/fastnlp/fastNLP/blob/ad044ef4c76c2c52da6e732a67ff2001e7a677d5/test/core/test_tester.py#L15
https://github.com/fastnlp/fastNLP/blob/ad044ef4c76c2c52da6e732a67ff2001e7a677d5/test/core/test_trainer.py#L14
Batch
batch.py defines Batch, an iterable wrapper of DataSet.
Sampling and padding is applied insides.
Iteration over a Batch object returns two dict, batch_x and batch_y.
The key of the dict is the field name. The value is the corresponding batch tensor.
data_iterator = Batch(data_set, batch_size=8, sampler=RandomSampler(), use_cuda=False)
for batch_x, batch_y in data_iterator:
   batch_x["word_seq"]  # torch.LongTensor
   batch_y["label"]  # torch.LongTensor

how to get the pre-paded (origin) length of the sequence
Batch will keep a record of the origin length of a field before padding.
It returns the origin lengths with a string key created by appending "_origin_len" before the field name.
For example,  batch_x["word_seq_origin_len"]  # torch.LongTensor.
Why origin length is tensor rather than a list of int ?
Because the sequence labeling model's forward() has added an extra arguemnt seq_len to represent the origin lengths (The creation of sequence masks is moved into the model, which needs seq_len.). And tensorboardX requires arguemnts passed to forward() to be nothing but tensor.
One Trainer, Many Tasks
In previous design, different trainers are responsible for different tasks.
After introducing Fields & DataSet, different tasks are represented by different DataSet structures, which is the way Fields organize.
Therefore, all methods in SeqLabelTrainer and  ClassificationTrainer are removed. They are just an empty sub-class to deprecate, and will throw an warning information when used.
So are those in Testers and Predictor.
self._task for trainers, testers, and predictors
However, trainers still need task information to know which fields are network inputs among batch_x.
This is because

we don't know which task is going to do when preprocessing and making DataSet.
not all fields in batch_x are needed as network input. Some may be unused, such as seq_len in text classification.
in tester, different tasks require different evaluation methods and metrics.
in predictor, different tasks require different pre-process and post-process.

Trainer & Tester have a required arguement (raise error if not provided, NO default value) self._task to specify which task is going to perform.
if self._task == "seq_label":
    y = network(x["word_seq"], x["word_seq_origin_len"])
elif self._task == "text_classify":
    y = network(x["word_seq"])

How to add your task ?

design a pytorch model, with forward method.
choose fields or create new fields to describe your data set.
modify preprocessor's run method: how to process your strings
modify preprocessor's convert_to_dataset method: how to convert into DataSet object
add task-specific operations in Trainer, Tester, and Predictor. Where self._task appears, where there are modification.
run and debug.

Future Works

optimize Preprocessor: make it a callable object, customized processing function as argument
more unit tests on core/
eliminate self._task ?
merge kezhen's code about build_dict

I can first accept it and then check.

continuous integration fails due to the use of command line argument parser in test_seq_label.py.
just delete the parser


[BUG] Librarians do not sell Unbreaking as Intended

Aged Version: 2.1.2

Attempted to find Unbreaking in Creative mode, with 10 villagers.
Was not successful in my attempts to find such enchant being sold.

For now i will leave unbreaking to the wandering traders.
May come back to this idea in the future


SPAdes: mark broken

SPAdes: mark broken
Broken at 2024-01-20 for x86_64-linux, as:

error: 'uint32_t' does not name a type

Tracking issue: https://github.com/NixOS/nixpkgs/issues/282372
CC @bzizou

Possibly a GCC 13 regression? Something like env.NIX_CFLAGS_COMPILE = "-include cstdint" might help?

Possibly a GCC 13 regression? Something like env.NIX_CFLAGS_COMPILE = "-include cstdint" might help?

Thanks. It works.


Bad developer experience to package/distribute Edge WebExtension

Hi,
I don't really know how to contact Edge developers officially so I'd like to explain my pains somewhere.
Developing a WebExtension in Edge with dev flag enabled and sideloading works fine (at least for the few API's I'm using), but the documentation/packaging/distribution part is really confusing.
I understand that you limit the publication of Edge extensions to only a few companies for now (including Pocket/Evernote/Adblock etc...). My company has an extension very similar to Pocket/Evernote and we'd like to distribute it in an easy way. We don't care if it's on the Windows store, we don't want to maintain a list of users allowed to download this extension, we don't want to ask users to enable dev features + sideload + confirm that they still want the extension to run on every Edge startup.
So I think I'm in a quite common usecase, yet I don't know how to distribute my extension in a correct way. I am able to generate an unsigned .appx with ManifoldJS by using commands of the documentation, but I'm unable to upload it to the store due to not being allowed to use the type "com.microsoft.edge.extension" (probably on purpose).
If this documentation is only limited to the very few developers (from Pocket/Evernote) allowed to publish the extension, why are you publishing it publicly like if it was targeting everybody? If it actually targets everybody then is there any appropriate way to distribute an Edge extension, when publishing to store is forbidden, LOB distribution seems unappropriate, and sideloading would be very bad UX?
Another thing: I noticed I am able to doubleclick on my extension .appx unfortunatly it's unsigned so Windows10 refuses to install the appx. I tried using the ManifoldJS -S option to sign the generated package but got an error:

The CloudAppX service returned an error - Not Found (404): Cannot POST /v3/buildsigned

This -S option is not even mentionned in Edge extension packaging doc, which references outdated doc pages using deprecated MakeCert.exe. Even if I finally succeed to sign my .appx I still have no idea what this will bring me because it's not mentionned anywhere if distributing .appx to users directly is a correct way to distribute Edge extension (I suspect it will be considered as sideloading: fail)
Also not sure why, the generated manifest does not automatically reference the logos that we already setup inside the WebExtension, instead of generating new default logos in the Assets folder

Hi @slorber  thanks for reaching out and providing this great data.  I'm adding @am385 to the issue who works directly with the Edge Extensions.  He can point you in the right direction.

Hi and thanks @boyofgreen
I've noticed these 2 Edge extensions which probably didn't get permission from Microsoft to publish to the store.

FBPurity: http://www.fbpurity.com/install.htm
Tweeten: http://tweeten.xyz/edge/

Yet they still try to do like me and distribute their extensions by using sideloading, but this seems very bad for user experience to enable dev features + confirming extension usage on restart.

Also this PCWorld link mentions that it's possible to publish our extension to the windows store in beta, but the extension wouldn't be "searchable" and the user would need the extension link directly. Our company is perfectly fine with such distribution system, because people in our case would always create an account on our website first, and extension requires a login/password anyway.
So, how can I distribute my extension in beta like stated in this article?
Is this PCWorld article saying the truth? Because the extension doc does not mention this distribution system, and I can indeed see the TemperMonkey extension mentionned in the article being listed on this page so it actually may be officially allowed to publish to the store...
Also want to add that yesterday I successfully signed my .appx but then double clicking on it was still refused because breaking the certificate chain. I suspect this is due to having used a self-signed certificate (like it's actually advised in doc I've found). It would be cool for me to host an installable .appx on my own CDN and distribute it this way, as long as users can double click on it to install the Edge extension.
Thanks in advance

As my extension code is really simple (just loads an iframe in current page), I try as a last resort to get approved faster with support. Just wondering the reasons why approving so few extensions at this time, is it to be able to ensure extension quality, and make sure new extension APIs are working fine before approving extensions using them? Because in my case the APIs usage is so low and common that I guess it could get approved.
browser.browserAction.onClicked.addListener(function onActionButtonClicked(tab) {
    browser.tabs.executeScript({file: "/clipper.js"});
});


Not following link when peek

Description of the new feature / enhancement
When peeking a .lnk file whose target is, for instance, a batch file (.bat), the Peek won't show content of the target file^1 , but a an icon with file info only^2 .
Scenario when this would be used?
To peek the target file of a link
Supporting information
No response

A lnk file is actually a file like any other. The request is understandable, but it would mean a design change request. Opinion @SamChaps ?


Quiz exercises: Remove Hazelcast for live quizzes

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[ ] I strictly followed the server coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[ ] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[ ] I documented the Java code using JavaDoc style.

Client

[ ] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[ ] I strictly followed the client coding and design guidelines.
[ ] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Motivation and Context

Description

Steps for Testing

Prerequisites:

1 Instructor
2 Students
1 Programming Exercise with Complaints enabled

Log in to Artemis
Navigate to Course Administration
...

Exam Mode Testing

Prerequisites:

1 Instructor
2 Students
1 Exam with a Programming Exercise

Log in to Artemis
Participate in the exam as a student
Make sure that the UI of the programming exercise in the exam mode stays unchanged. You can use the exam mode documentation as reference.
...

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

@coderabbitai What happened with your review?

@coderabbitai review this PR please

Hey, when trying to test on TS5, my quizzes got stuck in "currently participating". I created a quiz in my test course, started and participated in it, and then the quiz never ended despite the time having run out. I'm not sure what causes this, but doing the same on TS2 for example worked fine. Can someone confirm whether this works for them or if this is intentional/known?

The config of TS5 is somehow not working 100% correctly. The Hazelcast cluster is not building up. I suggest we test on other test servers

@florian-glombik

The import of exams with quizzes does not work properly (follow up) ❌

That's interesting - your exam quiz has a start and a due date. Did you click "Start quiz" on the exam quiz at any point? That seems to produce this state. (I wonder why this option is even available for exam quizzes since it should all be handled by the exam mode🤔 )
I was able to reproduce this on TS2, so I don't think it's caused by this PR.

Create a quiz exercise in an exam exercise group
Click on the title of the exercise
Click "Start quiz"
Try to import the exam. You will get the error message.

https://github.com/ls1intum/Artemis/pull/8703#issuecomment-2155691580
@pzdr7 Sorry, I should have described the steps to reproduce better!

Did you click "Start quiz" on the exam quiz at any point?

Indeed, that is the case, for some reason I was not able to evaluate the quiz before using the Start Quiz button and waiting until the "started Quiz" time was over

#8703 (comment)
@pzdr7 Sorry, I should have described the steps to reproduce better!

Did you click "Start quiz" on the exam quiz at any point?

Indeed, that is the case, for some reason I was not able to evaluate the quiz before using the Start Quiz button and waiting until the "started Quiz" time was over. I used the button after the quiz was over.

I think I was able to reproduce the "Evaluate quizzes" behavior on TS2. There's a grace period after the exam (180s) during which the quizzes cannot be evaluated.

https://github.com/ls1intum/Artemis/pull/8703#issuecomment-2156007996
I have no documented it in an issue: Exam mode: Quiz exercise in unexpected state when started manually #8767 @pzdr7


A "Reset" button that set default values for all fields in the form.

I think we decide not to implement reset button for now.


[site] improve mobile and tablet layout

Follow up to #545 - to improve the promo landing page.
@itowlson pointed out the layout looks  odd on an iPad, so adjustments to the @media-queries CSS are needed.
Will add them asap once I have bandwidth.

This seems pretty cool, I wonder if we ever had this implemented and release, since its old, I thought I will go through bunch of issues and see if there is anything we can do, fyi to @squillace , @itowlson and @lstocchi for any reference around this, thank you so much all.


Bump etcd versions for 1.18 - 1.21

Description of changes:

Bumped etcd version for 1-18 - 1-21

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/unhold


Dedicated Server Build Support for Linux and Windows

Add support for Linux and Windows Dedicated Server

https://github.com/superunitybuild/buildtool/issues/83

I tried adding this PR, but the build server version does not run in headless mode and the UNITY_SERVER directive is not being hit. Am I doing something wrong ?


Allow user to preempt Theano import via environment variable

Fuel is supposed to be Theano-independent. This seemed to be causing somebody trouble on the mailing list so maybe we should just provide a short circuit.

This ticket should now essentially be "diagnose mysterious test failures on #365 and rescue the commits therein".


Overflow in tf.raw_ops.DenseBincount when the value of size is too large.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.15
Custom code
No
OS platform and distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
When the value of size is close to the maximum value for the dtype, an integer overflow error will occur in following multiplication calculations.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1HOwF3BTWBrP2y9hpnFD9STu86vG7PrFX?usp=sharing

Relevant log output
Non-OK-status: InitDims(dim_sizes) status: INVALID_ARGUMENT: Encountered overflow when multiplying 3 with<PHONE_NUMBER>268123892, result: -1
Aborted (core dumped)

Hi @xl1043237213 ,
Thanks for reporting. I have reproduced the reported check fail and attached screenshot below.

Hi @xl1043237213, I have tried to implement the bincount using the Jax API and observed the similar result as DenseBincount. I have tried using the small int size because I don't have enough memory to use the large size. please refer to this gist. Thank You.


Add gnomAD allele frequencies for WGS workflows

Title says it all. See the tumor-only workflow for reusable subworkflows.

By default, VEP does not include all the gnomAD AF data for whole genome regions (just has exome AFs). There is a workaround to get the whole genome data described here: https://useast.ensembl.org/info/docs/tools/vep/script/vep_example.html#gnomad
jwalker says "We have the WGS data downloaded that could be used instead. There are a few parts to that:

get the VCF fixed for b38 much like the exome was
update the WGS ProcessingProfile to use the WGS gnomAD VCF
The annotated VCF tag is gnomADe, it's not configurable yet. The plan was to implement gnomADg if/when the time came."

@apaul7 I know you did a bunch of work on incorporating gnomAD data - Is there more to do here, or can this be closed?

This issue can be closed. I added the VEP custom annotation type allowing users to customize what annotations they would like to use. like in the example wgs yaml:
vep_custom_annotations:
- method: 'exact'
  force_report_coordinates: true
  annotation:
    file:
      class: File
      path: exome_workflow/chr17_test_gnomADe.vcf.gz
      secondaryFiles: [{class: File, path: exome_workflow/chr17_test_gnomADe.vcf.gz.tbi}]
    data_format: 'vcf'
    name: 'gnomADe'
    vcf_fields: ['AF','AF_AFR','AF_AMR','AF_ASJ','AF_EAS','AF_FIN','AF_NFE','AF_OTH','AF_SAS']
    gnomad_filter: true
    check_existing: true


Remove utility_id_eia from generators_eia860 & ownership_eia860

It turns out that the value of utility_id_eia associated with an EIA generator is entirely determined by which plant the generator is part of -- i.e. all plants have a single operator.
gens_eia860 = pd.read_sql("generators_eia860", pudl_engine)
gens_eia860.groupby(["report_date", "plant_id_eia"]).utility_id_eia.nunique().value_counts()

1    155554
0       667
Name: utility_id_eia, dtype: int64

This means that keeping the utility_id_eia column in the generators_eia860 and ownership_eia860 tables is redundant, and poorly normalized. It should be dropped during the harvesting process and removed from the table definitions. However this isn't currently possible within the ye olde harvesting process, so it will need to wait until after we switch to the new one.

@knordback This issue is adjacent to the changes you made recently on the #509 branch.


issue #332 generated Spring Boot Quickstarter code does not compile l…

…ocally

I close this PR. The build should realy fail if nexus properties are not defined correctly.
However, in this case the build should print some helpfull error messages. I will implement them in https://github.com/opendevstack/ods-project-quickstarters/issues/330


add pgmq-js Javascript (NodeJs) Community client library

Hello pgmq Community,
I hope you are doing well.
I've developed a NodeJs client library with most of pgmq features (Here's a list of the currently supported features).
This PR mentions the client under the Community Client Libraries section.
I would greatly appreciate your feedback and suggestions.
Thank you for your efforts 🙌🏽.
Best regards,

Awesome, thank you!


First time adding a favorite symbol to map draws unknown symbol

Environment:
ArcGIS Pro 2.2 Daily
MilSymbol Editor Build 4 (6/14/2018)
Steps to Reproduce:

Start ArcGIS Pro
Create a new Map Project
Launch Military Symbol Editor
Go to Favorites Tab
Click Import
Import SampleFavorites.json.txt file attached to this issue (remove .txt extension and keep just .json)
Click on Favorite
Click on Pro Map if not visibile
Click on Add to Map Button
Add-In Disabled Form should prompt you to add the Military Overlay Schema
After Military Overlay Schema is added you should be able to add symbol to the map
Note, if you try to add the symbol without clicking on any other symbol first, it will draw an unknown symbol.

If you click on any other symbol from the Military Symbol Editor Pane, and then click back to your original symbol, it will draw fine.

SampleFavorites.json.txt
Other variations:
I can also reproduce this behavior by immediately after importing a Favorites JSON file, not selecting any symbol, and clicking Add to Map.  Any symbol drawn will be of type "unknown".
If you click "Delete" and delete a symbol from your favorites list, you can still click "Add to Map", it will then allow you to add an unknown symbol on your map.

This can be fixed by not enabling the add to map until something is selected in the find or favorites category.

Adding to the current Sprint in hopes that it is an easy fix.

Very closely related to #243 and also indirectly related to #241

Hopefully addressed in PR #244
I did try to address issue that when

User starts with new Pro project
User selects favorite
Clicks Add to Map
Schema gets added
Click on Map
The previously selected favorite is not the symbol added to the map (unknown symbol or affiliation)

But I didn't explore all of the import favorites scenarios - so there may still be some issues there when combined with a new schema-less project.

testing with our latest build.

My testing did not include the changes @csmoore made in PR 244 since it was never reviewed and merged. Doing that now.

Changes were reviewed and merged. Kicked off a new MSE add-in build.

After PR 244, I verified Unknown symbols cannot be added to a map after importing the JSON file. However, I am still able to add Unknown symbols after deleting an item from the Favorties list:

The issue at hand is that when you do not have a item selected in the favorites tab the button reverts back to the last item in the search window.
The expected behavior is the button is not available when their is not an item in the favorites tab.

With MSE build 11 on 2.2 final this is fixed