Make it more clear how to submit feedback

Current pain point: It's not clear for users unfamiliar with GitHub how to make feature requests or ask questions (the Github link leads to the front page for the AMP Start repo; the Slack link directs you to a Google form)
Strawman proposal: From the GitHub module on the ampstart.com home page, add a direct link to make a feature request (inline link for the text "request a feature")
@spacedino @camelburrito  WDYT?

Adding to this, Stackoverflow requires karma, so many of us are unable to post for help. We'd like to see some examples of forms and how to make them actually work. There are plenty of examples of HMTL forms, but there is nothing about action-xhr and possible PHP or other endpoints to work with. Nothing for regular forms works with AMP that I've tried. And I am trying, but what you have going on here is nothing for beginners, all for developers. It'd take one of you wizards about 5 mins to post something that thousands of us could use to successfully submit AMP forms.

This doesn't work and I don't know why:
`<?php
$myemail =<EMAIL_ADDRESS>if (!empty($_POST)) {
header("access-control-allow-credentials:true");
header("access-control-allow-headers:Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token");
header("access-control-allow-methods:POST, GET, OPTIONS");
header("access-control-allow-origin:".$_SERVER['HTTP_ORIGIN']);
header("access-control-expose-headers:AMP-Access-Control-Allow-Source-Origin");
header("amp-access-control-allow-source-origin:https://".$_SERVER['HTTP_HOST']);
header("Content-Type: application/json");
$name = $_POST['name'];
$email_address = $_POST['email'];
$message = $_POST['message'];
header("Content-Type: application/json");
$email_subject = "Contact form submission: $name";
$email_body = "You have received a new message. ".
" Here are the details:\n Name: $name \n Email: $email_address \n Message \n $message";
$headers = "From: $myemail\n";
$headers .= "Reply-To: $email_address";

mail($to,$email_subject,$email_body,$headers);
header('Location: thank-you.html');

}
?>
`


[Suggestion] DNS over TCP (at cost of disabling .onion access)

DNS over TCP is supported by Linux since 2015-05-07: https://web.archive.org/web/20150518063349/http://man7.org:80/linux/man-pages/man5/resolv.conf.5.html
All that is needed is TCP support by the resolver. I tested many of this list: https://www.publicdns.xyz/
^^ ~ 95% of them work well with TCP, it wasn't the same 5 years ago as most DNS servers didn't support TCP DNS.
I was having trouble with that annoying "Google captcha" when browsing with Firefox in orjail, and after tests with some DNS servers I realized that DNS resolvers were the cause, perhaps because Tor changes the resolvers often in the middle of some accesses. The most stable DNS resolvers I found are anycast.censurfridns.dk (<IP_ADDRESS> | 2001:67c:28a4::) and unicast.censurfridns.dk (<IP_ADDRESS> | 2a01:3a0:53:53::), I didn't got any error.
The trick is easy, /etc/resolv.conf (or /etc/netns/namespace/resolv.conf) should be:
options use-vc
nameserver <some_server>
Testing with orjail:
sudo orjail -s
sudo echo -e "options use-vc \nnameserver <IP_ADDRESS> \n" > /etc/resolv.conf
dig +tcp github.com | grep 'SERVER:'
curl ifconfig.me
^^ Works well, and should be the same with any transparent proxy as long as TCP port 53 is unblocked by the upstream server. The only disadvantage is that .onion sites will be not reachable with this scheme.

(at cost of disabling .onion access)

Perhaps as an option the one thing or the other?

I found interesting in allowing user to choose the DNS server, I have had problems to bypass captchas with my slow connection, the Uncensored DNS seems to fix that.
An option to allow users to choose their DNS servers, even if disabling the normal Tor DNSPort and hidden services would be useful.


Documentation: add huawei product user

Cherry-picking https://github.com/coreos/etcd/pull/7427.
Some diffs just cleans up trailing whitespace.

LGTM

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9afe4e8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #7469   +/-   ##
========================================
  Coverage          ?   70.4%
========================================
  Files             ?     244
  Lines             ?   21437
  Branches          ?       0
========================================
  Hits              ?   15093
  Misses            ?    5206
  Partials          ?    1138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afe4e8...0a9e2fe. Read the comment docs.


when edit replication rule ,existing endpoint info should not be editable

when edit replication rule, if is not add a new endpoint, endpoint should not be editable

Fixed.


Debug symbols for the libclang nuget package?

First of all, thank you for including a NuGet libclang package as part of your work on this project. I don't know the common practices for native NuGet packages, but could that package include debugging symbols? Alternately, could the symbols for that build be published to the Microsoft Symbol Server?
This would be helpful in three contexts:

Generically debugging code by being able to step across the boundary into the libclang code.
Debugging the occasional libclang parser crashes that we've been seeing.
Analyzing the performance of our application (via ETW trace).

I believe the only other option we have is to instead build our own copy of libclang and ignore the NuGet package. If there's another choice here, I'd be happy to hear that as well.
Thanks,
Daniel Jennings
Valve

Actually, this is moot because I misremembered which libclang.dll I'm actually using - I'm using the one that ships with VS2019, not the one that ships via NuGet.


UI Improvement Donate Book Page

🛠 Fixes Issue
Resolved #687
👨💻 Changes proposed
Improvement of User Interface of Donate Books page
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
NA
📷 Screenshots

@A-Spiral-Forge nice work!


Why the patchsize can't be Multiples of 10?

Error Code when patchsize=10 :
Q[angle,strength,coherence,pixeltype] += ATA
ValueError: operands could not be broadcast together with shapes (100,100) (121,121) (100,100)
Can't undestand why, anyone could help me ?

The project does not allow you to change the defined parameter in this stage, unexpected error may occur! (Unless you know exactly what you're doing) But if you want to change the patchsize for experimental purpose, change it to some odd number (patchsize=9 may be a better number in this case).
P.S. The patchsize indicates the operating area of a target pixel, so the target pixel should sit at the center of the patch. As a result, the patchsize will be an odd number.

Thanks for your answer!


Test TPC-H correctness on more scale factors

~For some reason, Q15 at SF 100 and 100 is off. The DuckDB result appears to be empty, which I assume to be wrong.~ The problem with Q15 has been fixed by #1454.

Something is still off in Q15: It fails with 2385908.0563 != 2385908.056300.


Available on npm?

I have seen the package.json but could not find it on npmjs.com
Is there any chance to make this downloadable through npm?

Yes, I'm going to register next published stable 2.0.0 version to the npm and the bower.
I hope you wait for releasing next.

I've registered this package to the npm and the bower. And the package name was changed to the "jq-timeline". We can install since using npm i jq-timeline.


There is slot of 5 min gap in time picker suppose i want to select 22 min there is no option. is there any availability ??

when i select time suppose i wan to select 22 min there is option for selecting time for 5 , 10 , 15 , 20 ,25 and same through is there any option to select manual time or selecting from time picker.

With this fork: https://github.com/beenote/angular-material-datetimepicker
minute-steps="1"


Broken link

[Enter feedback here]
at the bottom of the page there is redirection to an article called "Create ingress nginx controller with public static IP address"
that points to https://docs.microsoft.com/en-us/azure/aks/ingress-static-ip
this article does not exists

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7179d4ae-db6e-7f7c-a855-db0e0475dae9
Version Independent ID: 1a6fa0e8-e175-ae4d-a9d6-d170255a598e
Content: Use static IP with load balancer - Azure Kubernetes Service
Content Source: articles/aks/static-ip.md
Service: container-service
GitHub Login: @zr-msft
Microsoft Alias: zarhoads

@tshaiman Thank you for bringing this to our attention!  We are reviewing the link and will get back to you shortly.

Link details
It looks like the link in question is under Next steps:

You can also create an ingress controller with a static public IP address.

Link address:
https://docs.microsoft.com/en-us/azure/aks/ingress-static-ip
Resulting destination URL:
https://docs.microsoft.com/en-us/azure/aks/ingress-tls
Link update
Create an ingress controller and Use TLS with an ingress controller are the two documents remaining under Ingress/Use ingress-nginx.  It looks like this section (ingress) was updated less than a month ago and Use a static public IP address is now part of the redirect URL, Use TLS with an ingress controller on Azure Kubernetes Service (AKS).
Summary
It looks like everything is where it should be after a recent update.  Use a static public IP address is now under Ingress controller configuration options in the redirect URL:
https://docs.microsoft.com/en-us/azure/aks/ingress-tls?tabs=azure-cli#use-a-static-public-ip-address

amazing ! well done guys


Enable additional operations to be registered on a store via store properties

This would allow additional operations to be added to a the AccumuloStore without having to extend the AccumuloStore class just to register more operations.

Merged into develop


Update Composer dependencies (2021-11-18-00-11)

Visual regression test passed!
View the visual regression test report


Add DI support for twill Block getData method

Hello, I have been trying to use Twill Block, and extend it like it's documented in https://twillcms.com/docs/block-editor/rendering-blocks.html#content-modifying-block-data, though no method supports DI. This change would allow to use DI in getData() method.
Regarding the changes Laravel itself likes to do things like that, ex. https://github.com/laravel/framework/blob/10.x/src/Illuminate/Mail/Mailable.php#L1612-L1614
Also had a discussion on Discord to create this PR

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Afting I was about to merge this but I'm concerned about the example provided in the docs needing a correction if we remove the getData method implementation in the Block parent class:
public function getData(array $data, \A17\Twill\Models\Block $block): array
{
    $data = parent::getData($data, $block);
    // ...
}

parent::getData() wouldn't work anymore, and it is almost certain that developers using this feature are currently using it by pasting the example from the docs. Can we keep it while benefiting from DI in the method override?


Sliders can go into the negatives and go above the normal default limit.

I don't know if this is a bug or a feature but it's really annoying. If it is a feature is there a way to toggle/turn it off? It works on any slider in video, audio, and even mouse settings.

This is due to the mod slyde. If you don't like it, you can remove the mod.

Thank you :)


SAK-29153 invalidate permissions in a site

right on.... you want us to test?

Updated as a stray import found its way in!

LGTM

Steve if you can merge that would be great...


ruff_benchmark: open all tomllib files in the red-knot benchmark

Summary
I noticed that the red-knot benchmark was reporting different diagnostics on tomllib than red-knot did if you just ran red-knot from the CLI on the tomllib copied-and-pasted into an empty directory locally. Specifically, the following diagnostic was not being reported by the red-knot benchmark, but was being reported if you just ran red-knot locally:
/src/tomllib/__init__.py:10:30: Name '__name__' used when not defined.

After some investigation, I realised that the culprit was this line here:
https://github.com/astral-sh/ruff/blob/2a36b47f1395284d32ae2015e6c626f242922224/crates/ruff_benchmark/benches/red_knot.rs#L76
"Opening" the tomllib/_parser.py file means that red-knot will only check _parser.py and files that _parser.py depends on. _parser.py doesn't depend on __init__.py, so __init__.py isn't being checked at all by the red-knot benchmark currently. This PR therefore changes the benchmark so that all tomllib files are "opened", and thus all tomllib files are checked.
The first commit in this PR should have no impact on behaviour: it's just some refactoring I did so that I could see more clearly which files were being downloaded by the benchmark and copied into the tomllib directory used by the benchmark.
Test Plan
cargo bench -p ruff_benchmark -- red_knot

I'm okay with this change but What's the motivation for checking all files? Or why is it important for the benchmark to check all files?


Allow an empty string to be specified when using the Groovy string matcher

When using the string matcher with a non-null value you expect to see that example value in the Pact file. This is not the case with an empty string, a generated value would be present in the Pact instead. My pull request addresses this situation.
Before my change Matchers.string() was equivalent to Matchers.string(''). Now it is possible to use an empty string as an example value.
This change also makes the matcher's behaviour consistent with the equivalent Java matcher (PactDslJsonBody#stringType(...)).

Thanks for the PR


Azs2.0.0

Docs Build status updates of commit 3b6f1ea:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/azure-docs-powershell, working directory: W:\caex-s, target branch: master, target branch commit: 18128bcfc2812123d3f6ebf47717577775b11540, source commit: 3b6f1eafb6b5925da739c255f278f14e2084e6e4.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix typo 'kubermentes'

Learn Build status updates of commit 2b06257:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/machine-learning/how-to-deploy-online-endpoints.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Error when edit value of node

var res = new JefNode(filter).filter(function(node) {
   if (node.has('text'))
       node.value.text = "abc";
});

Got error :     "message": "Cannot read property 'path' of undefined",

It occurs when I set value type is ObjectID.
I will debug more.

Hello I have some business right now but i ll take a look on sunday. Just
let me know if you find more.
Liviu
On Thu, Jul 23, 2015, 11:04 nvcken<EMAIL_ADDRESS>wrote:

It occurs when I set value type is ObjectID.
I will debug more.
—
Reply to this email directly or view it on GitHub
https://github.com/gliviu/json-easy-filter/issues/1#issuecomment-124014529
.

The problem is most probably that you change the structure of the json object during filtering operation. This is not supported because json-easy-filter keeps an internal representation of the wrapped object. Following code will cause this exception:
var obj = {
s1 : 'v1',
o2 : {
text : 'v2'
}
};
var root = new JefNode(obj);
var res = root.filter(function(node) {
if (node.has('text')){
node.value.text = {x:'y'};
}
});
Solution - remember nodes that have to be changed and update them later:
var root = new JefNode(obj);
var modif = [];
var res = root.filter(function(node) {
if (node.has('text')){
modif.push({parent: node.value, newVal: {x:'y'}})
}
});
for (var i = 0; i < modif.length; i++) {
var elem = modif[i];
elem.parent.text = elem.newVal;
}

ok, thanks


[Mod] [Asked again] Radial Engine for spacecraft

Mod name: Radial Engine for spacecraft
Author(s): Kevin4D
License:  configs: MIT, assets: All Rights Reserved
Homepage: https://forum.kerbalspaceprogram.com/index.php?/topic/192553-19x-radial-engine-for-spacecraft-tgol-group/
Download: https://spacedock.info/mod/668

The mod author has approved the upload to CKAN: https://forum.kerbalspaceprogram.com/index.php?/topic/192553-19x-radial-engine-for-spacecraft-tgol-group/&do=findComment&comment=3840052
Replaces https://github.com/KSP-CKAN/NetKAN/issues/7952

Thanks for persisting! Since the author approves, I decided to try editing the entry on SpaceDock in order to check the "add to CKAN" checkbox, which created #8103 and will ensure fast indexing of new releases.


Escape Sequences in Strings

Challenge Escape Sequences in Strings has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

var myStr = "FirstLine/n//SecondLine///rThirdLine"; // Change this line

 I can't run my code, please help! What's wrong with my browser or with my code

@imanaibolat, I checked your code. But your code is incorrect.
GitHub Issues are for reporting bugs on the website only
Please use the HelpJavaScript chat room for getting challenge related help.
Happy Coding..

Escape sequences are written with backslashes not forward slashes.


All scripts are stuck when ran

The debugging feature doesn't seem to work for me - when I press F9 on any script, I can see the debugging session start but none of my code is actually ran - for example even a one liner MsgBox doesn't do anything regardless of how many breakpoints I try to set.
My config is the default and latest v1 AHK path which I checked and it's correct. I don't get any error messages.
Example when I press F9, I can restart and kill the script but I can't pause it (it's already doing nothing so it makes sense):

I just want to note that I can run the script normally and see the '1' popup when I double click on the file.

Maybe the debug port is used, update to 2.2.1 and try again.

I have a similar issue, downgrading to 2.1.5 resolved the issue with nothing actually launching. But it cannot handle files with a space in the name on that version :P

also confirming the issue on 2.2.1, launching the debug session activates a color change and VS code window changes. But none of the code is run from the open editor.

You  are right. I got it. Have any other feature suggestions? @BanditTech


Referring to snapshot release repo in pom.xml file may cause issues in IntelliJ

See discussion here: https://www.eclipse.org/lists/rdf4j-dev/msg01815.html

I am not 100% sure but this seems to be causing problems on the command line. I am getting very strange test failures when running mvn verify, in particular in the SHACL tests.

@hmottestad out of curiosity did commenting this out actually fix the problem you were having in IntelliJ?

Assuming that we keep this change in place, a possible workaround for myself and for others who wish to still use the Sonatype snapshot repo is to create a settings.xml file in ~/.m2/ with the following contents:
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
	<profiles>
		<profile>
			<id>sonatype-snapshots</id>
			<activation>
				<activeByDefault>true</activeByDefault>
			</activation>
			<repositories>
				<repository>
					<releases>
						<enabled>false</enabled>
					</releases>
					<snapshots>
						<enabled>true</enabled>
					</snapshots>
					<id>oss-sonatype-snapshots</id>
					<url>https://oss.sonatype.org/content/repositories/snapshots</url>
				</repository>
			</repositories>
		</profile>
	</profiles>
</settings>

Alternatively, we actually stick this profile in the project root pom, so that this works out of the box for most users, and then those people who have problems with this can choose to deactivate the profile (no idea how that works in IntelliJ but I assume it has an option for that).

I'm not 100% sure. I ended up making some changes to the maven settings in IntelliJ and since then I haven't seen the issue.
I can try to uncomment the snapshot repo again and see if that breaks IntelliJ.
Btw. What sort of issues are you getting? I kinda feel that if we are getting issues building or testing the code because we can't download a snapshot build, then there is something funky going on under the hood.

Oh I think it's more that I tend to rely on not having to build the entire project myself. With the snapshot repo it just grabs the latest nightly build, and I can concentrate on the specific thing I'm fixing.
Let's put it back in, but as a profile, so you can choose to disable it locally.


ember TypeError: (0 , _component.classNameBindings) is not a function (^3.0.0-rc.5)

Output from ember bootstrap:info:
ember-bootstrap: ^3.0.0-rc.5 -> 3.0.0-rc.5
ember-cli: ~3.11.0 -> 3.11.0
bootstrap: ^4.3.1 -> 4.3.1
bootstrap-sass: n/a
ember-cli-sass: ^9.0.0 -> 9.0.1
ember-cli-less: n/a
Bower packages:
bootstrap: n/a
bootstrap-sass: n/a
ember-bootstrap configuration:
bootstrapVersion: 4
importBootstrapCSS: false
importBootstrapTheme: false
importBootstrapFont: false
whitelist: undefined

application/template.hbs
<BsNav @type="pills" as |nav|>

</BsNav>

edit: ^3.0.0-rc.1 did worked
console-consumer.js:12 ember TypeError: (0 , _component.classNameBindings) is not a function
    at Module.callback (https://localhost:4201/assets/vendor.js:163435:173)
    at Module.exports (https://localhost:4201/assets/vendor.js:111:32)
    at Module._reify (https://localhost:4201/assets/vendor.js:148:59)
    at Module.reify (https://localhost:4201/assets/vendor.js:135:27)
    at Module.exports (https://localhost:4201/assets/vendor.js:109:10)
    at Module._reify (https://localhost:4201/assets/vendor.js:148:59)
    at Module.reify (https://localhost:4201/assets/vendor.js:135:27)
    at Module.exports (https://localhost:4201/assets/vendor.js:109:10)
    at requireModule (https://localhost:4201/assets/vendor.js:32:18)
    at Class._extractDefaultExport (https://localhost:4201/assets/vendor.js:206118:20)
    at Class.resolveOther (https://localhost:4201/assets/vendor.js:205795:32)
    at Class.resolve (https://localhost:4201/assets/vendor.js:205855:25)
    at resolve (https://localhost:4201/assets/vendor.js:18260:36)
    at Registry.resolve (https://localhost:4201/assets/vendor.js:17800:21)
    at Registry.resolve (https://localhost:4201/assets/vendor.js:17803:33)
    at factoryFor (https://localhost:4201/assets/vendor.js:17360:38)
    at Container.factoryFor (https://localhost:4201/assets/vendor.js:17275:14)
    at Class.factoryFor (https://localhost:4201/assets/vendor.js:45758:33)
    at Class.componentFor [as _super] (https://localhost:4201/assets/vendor.js:49783:20)
    at Class.componentFor (https://localhost:4201/assets/vendor.js:178858:28)
    at Class.superWrapper [as componentFor] (https://localhost:4201/assets/vendor.js:49075:22)
    at lookupComponentPair (https://localhost:4201/assets/vendor.js:51650:37)
    at lookupComponent (https://localhost:4201/assets/vendor.js:51670:12)
    at RuntimeResolver._lookupComponentDefinition (https://localhost:4201/assets/vendor.js:29419:38)
    at RuntimeResolver.lookupComponentHandle (https://localhost:4201/assets/vendor.js:29193:37)
    at CompileTimeLookup.lookupComponentDefinition (https://localhost:4201/assets/vendor.js:25833:28)
    at LazyCompiler.resolveLayoutForTag (https://localhost:4201/assets/vendor.js:61663:29)
    at https://localhost:4201/assets/vendor.js:60836:28
    at Compilers.compile (https://localhost:4201/assets/vendor.js:60750:7)
    at compile (https://localhost:4201/assets/vendor.js:61443:17)
    at LazyCompiler.add (https://localhost:4201/assets/vendor.js:61637:14)
    at CompilableProgram.compile (https://localhost:4201/assets/vendor.js:61401:44)
    at OutletComponentManager.getLayout (https://localhost:4201/assets/vendor.js:24031:24)
    at Object.evaluate (https://localhost:4201/assets/vendor.js:66405:24)
    at AppendOpcodes.evaluate (https://localhost:4201/assets/vendor.js:64794:19)
    at LowLevelVM.evaluateSyscall (https://localhost:4201/assets/vendor.js:68007:22)
    at LowLevelVM.evaluateInner (https://localhost:4201/assets/vendor.js:67953:14)
    at LowLevelVM.evaluateOuter (https://localhost:4201/assets/vendor.js:67945:14)
    at VM.next (https://localhost:4201/assets/vendor.js:70011:20)
    at TemplateIteratorImpl.next (https://localhost:4201/assets/vendor.js:70047:22)
    at RootState.render (https://localhost:4201/assets/vendor.js:25071:37)
    at TransactionRunner.runInTransaction (https://localhost:4201/assets/vendor.js:31409:35)
    at runInTransaction (https://localhost:4201/assets/vendor.js:31544:74)
    at InteractiveRenderer._renderRoots (https://localhost:4201/assets/vendor.js:25367:78)
    at InteractiveRenderer._renderRootsTransaction (https://localhost:4201/assets/vendor.js:25404:14)
    at InteractiveRenderer._renderRoot (https://localhost:4201/assets/vendor.js:25324:12)
    at InteractiveRenderer._appendDefinition (https://localhost:4201/assets/vendor.js:25240:12)
    at InteractiveRenderer.appendOutletView (https://localhost:4201/assets/vendor.js:25226:12)
    at invokeWithOnError (https://localhost:4201/assets/vendor.js:71332:18)
    at Queue.flush (https://localhost:4201/assets/vendor.js:71212:13)
    at DeferredActionQueues.flush (https://localhost:4201/assets/vendor.js:71409:21)
    at Backburner._end (https://localhost:4201/assets/vendor.js:71943:34)
    at Backburner.end (https://localhost:4201/assets/vendor.js:71693:12)
    at Backburner._run (https://localhost:4201/assets/vendor.js:71998:16)
    at Backburner._join (https://localhost:4201/assets/vendor.js:71972:21)
    at Backburner.join (https://localhost:4201/assets/vendor.js:71743:19)
    at join (https://localhost:4201/assets/vendor.js:59267:23)
    at HTMLDocument.<anonymous> (https://localhost:4201/assets/vendor.js:59362:25)
    at mightThrow (https://localhost:4201/assets/vendor.js:9710:29)
    at process (https://localhost:4201/assets/vendor.js:9778:12)

I'm unable to reproduce using a newly created project. Are you able to reproduce in a CodeSandbox or add more detailed steps for reproduction?

yarn why ember-decorators told me I had one version. Updating ember-best-language got rid of it.
Also got rid of some other unused stuff with help of dependency linting (thx!).
And I went from ember-cli 3.11 to 3.12...
Now 3.0.0-rc.5 works 🎉
Interestingly the only 'conflict' shown by dependency listing now comes from ember-bootstrap... 😆
ember-angle-bracket-invocation-polyfill
Allowed: (any single version)
Found: 2.0.2, 1.3.1
lab-plhw
└─┬ ember-bootstrap
  ├──<EMAIL_ADDRESS>  └─┬ ember-popper
    └──<EMAIL_ADDRESS>
Thanks!

@basz Seems like you are on an old version of ember-popper subdependency. Try another yarn upgrade ember-bootstrap to fix it. Double-check that you haven't pinned that subdependency using yarn resolutions. You should use<EMAIL_ADDRESS>which depends on<EMAIL_ADDRESS>

except only ember bootstrap uses it if i get this right...
➜  hf-app-lab git:(upgrade/emberjs) ✗ yarn why ember-popper

yarn why v1.17.3
[1/4] 🤔  Why do we have the module "ember-popper"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#lab-plhw#ember-bootstrap" depends on it
   - Hoisted from "_project_#lab-plhw#ember-bootstrap#ember-popper"
info Disk size without dependencies: "1.39MB"
info Disk size with unique dependencies: "7.47MB"
info Disk size with transitive dependencies: "55.68MB"
info Number of shared dependencies: 133
✨  Done in 1.97s.

I just hit this error after upgrading EmberJS to 3.13 and ember-bootstrap to 3.0.0-rc6.
➜  nv-k8s-ui git:(develop) ✗ yarn why ember-popper
yarn why v1.17.3
[1/4] 🤔  Why do we have the module "ember-popper"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "ember-bootstrap" depends on it
   - Hoisted from "ember-bootstrap#ember-popper"

After some more digging, I found the problem:
➜  nv-k8s-ui git:(develop) ✗ yarn why ember-decorators
yarn why v1.17.3
[1/4] 🤔  Why do we have the module "ember-decorators"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "ember-yeti-table" depends on it
   - Hoisted from "ember-yeti-table#ember-decorators"
info Disk size without dependencies: "648KB"
info Disk size with unique dependencies: "2.12MB"
info Disk size with transitive dependencies: "58.2MB"
info Number of shared dependencies: 128
=> Found<EMAIL_ADDRESS>info This module exists because "ember-bootstrap" depends on it.
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "1.04MB"
info Disk size with transitive dependencies: "57.2MB"
info Number of shared dependencies: 125

I removed yeti-table and the problem is fixed.


International Datasets

This issue is to discuss how to detail with more international datasets. Should they be included in their own call out location? Or classified with the other topic datasets?
Examples:

https://www.emodnet-humanactivities.eu/view-data.php#

For right now, we are just accepting we are keeping our scope to generally applicable built environment/planning resources, but our repo is centered on North American Planning. If we need to change our name or structure to include broader resources we can reopen this issue to continue the discussion.


Egress metric

Can you provide and example of how  external client would egress traffic to Azure storage? This
"The amount of egress data. This number includes egress from an external client into Azure Storage as well as egress within Azure. As a result, this number does not reflect billable egress. " does not make sense to me.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63c3effd-7cc3-f021-358a-adeaf59a0a69
Version Independent ID: 36381f6b-f57b-95a2-67cd-80bffcee238c
Content: Azure Storage metrics in Azure Monitor
Content Source: articles/storage/common/storage-metrics-in-azure-monitor.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

@Chai-NED Thank you for your feedback! We will review and provide an update as appropriate.

@Chai-NED Firstly, apologies for the delay in responding here and any inconvenience this issue may have caused. Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

Thanks @Chai-NED. This was a typo in the docs. I've fixed this typo and the fix should appear live by tomorrow morning. Egress is data leaving the account either to an application or to other Azure service consumers. Thanks again for point this out.

#please-close


Adapting driver to RA and DEC axis guiding through PHD2

Is it possible to use this driver to control RA and DEC axis using 2828BYJ-48 motor with a ULN2003 controller?

Excuse me, I just saw this opened issue and for sure it might be irrelevant at the moment, but want to close the loop anyway. There are several points that make this driver as well as the hardware not suitable for the RA and DEC axis guiding:

The 2828BYJ-48 motor has too low torque to move the mount with the telescope. Even for the focuser device, I believe it works for me almost at the maximum of its capabilities. It's better to use NEMA17 motors with, for instance, TMC drivers.
I'm afraid it's not possible to use this driver as-is - it's specifically written for controlling the focuser device. For controlling RA/DEC axis we need to implement another ASCOM interface - ITelescopeV3 - which provides a specific set of methods for telescope control. One day I've found this repo which can be used as an example.


wip: Add targeted repair

Repair part of #225
Depends on #240 (which must be merged first). @khaes-kth I've implemented this to use violation IDs on the form <rule-key>:<filepath>:<line-nr>. All of that information is available to the miner, so that's the minimum we need to implement targeted repair. The miner is however missing a convenience method in RuleViolation, see the code comments.
We can discuss this further at the meeting.

This is on hold until #245 is fixed, the test failure in CI is related

I will replace this with a new PR.


Turn is_inside into deprecation errors

This is part 1 of the cleanup. Mostly just tests. It will also let us clean up a bunch of code in _container_entrypoint.py but I'll do that separately.

@prbot approve

@aksh-at and @freider have raised some valid concern with this but supporting is_inside has caused me a large amount of pain and I don't think it's worth it. Removing it will help us simplify a lot of the code and get rid of stub assignments. We can revisit this in the future and discuss other potential approaches that could also work.


Remote connection isn't really closed

Hi,
when I close remote connection (i disconnect anche close panel) and local Project Folder, i find a bug if I open a new Local Project (without FTP connection settings).
When i save a new file in my new project, old connection start and this file is automatically uploaded by ftp connection of previous project on previous remote server project folder.
If i quit Atom before and open a new Project Folder this bug there isn't.
bye!

Should be fixed in the latest release


Support no_std

I'm writing a library that needs to be tested inside no_std environments.
Since tracing, and tracing-subscriber do not inherently require std, it would be convenient to be able to use this crate to do so.
I've made some trivial changes, like importing alloc::{string::String, vec::Vec}, but the more important change is that I've switched std::env::var_os with core::option_env, which resolves an optional environment variable at compile time. I'm fine feature gating the std::env::var_os call behind an std feature if that is more acceptable for you.
Some things to consider:

You may want to enable std_instead_of_alloc to identify types up front that can be easily used without std
You may want an std flag to enable more features available via std that are not required for the base crate to work.

Thanks for all your work; I really enjoy this crate!
—Tait

Thanks for the pull request. For my understanding, what would be the motivation for running in a no_std environment?
I get why a "production" crate wants to be no_std compatible, but this is a development crate, specifically designed to be used as a dev-dependency. I fail to see why one would want to have the associated constraints when running tests.

I understand this is meant as a dev-dep. The tests need to be able to be run on the target machine, not just on any machine.

So you'd compile for the target, which doesn't have a Rust std environment, set the environment variables during compilation, copy the resulting binaries over, and then run the test? Is that the envisioned workflow?
I guess that seems like something we could conceivably support. And what is the intention of this pull request? Clearly it is not in any state to be merged. Are you asking for input? Do you want me to finish it?

So you'd compile for the target, which doesn't have a Rust std environment, set the environment variables during compilation, copy the resulting binaries over, and then run the test? Is that the envisioned workflow?

Yes.

Clearly it is not in any state to be merged.

Just missing a few clippy/fmt issues. Trivial fixup in the next few hours and it should be ready to go! :)

Looks like the clippy lint is failing on your main. Not sure exactly when this is from, but this is not due to a change in my PR.

Looks like the clippy lint is failing on your main. Not sure exactly when this is from, but this is not due to a change in my PR.

Probably due to a new Rust release. Will fix it up.

but we just use tracing-subscriber and env_logger as they are (i.e., with std enabled unconditionally). How is that going to satisfy your workflow?

tracing_subscriber has an std feature that you disable by default already, no problems there!
env_logger sort of fundamentally requires std; I have now made log depend on the std feature.
Since I only use trace this is no issue for me. Test added for trace

but we just use tracing-subscriber and env_logger as they are (i.e., with std enabled unconditionally). How is that going to satisfy your workflow?

tracing_subscriber has an std feature that you disable by default already, no problems there!

It works because env-filter enables std. Hence, there is an std environment available anyway. Then, what's the point of making this crate support a no_std environment if other dependencies are free to use std?

It's not uncommon that no_std crates want their test suites to run in no_std as well. Convincing maintainers to switch to using #![cfg_attr(not(test), no_std)] instead may or may not be possible and poses at the very least a papercut to adoption. Is it truly necessary for test-log to enable the env-filter feature or can it work without it?

It is what is evaluating RUST_LOG, so it seems pretty crucial to me.


cli+vscode+app: Support submodules

Hi!
I would like to "fix:" the dependency version to a certain commit to prevent unexpected abaplint pipeline failing when dependent projects are changed.
For that purpose I would like to use  a native git submodules  feature and refer to a local path in abapgit config file instead of the URL.
The only thing we need to add is  submodules: recursive for checkout action.
Thanks!

👍
I'll probably also add sha/tag/branch in the dependencies configuration, https://github.com/abaplint/abaplint/issues/941


Jesse: Watch openim.io

Jesse requests the watch of the watch_keyword openim\.io. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

openim\.io has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


Update package version

4.1.0-alpha.11 (2024-02-26)
Features

supports pre annotations (#429) (2f731ad)

:tada: This PR is included in version 4.1.0-alpha.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.5-alpha.2 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:


Fix for script as in the branch

Can you explain what was the issue? I applied the sed command to the source module file, you apply it to the destination ones. What difference is there?

The removal of loads is to an empty source directory and should be applied to the final lua modules in the destination directory.

Oh I see, I should have applied it to ${old_src_dir}. I am happy with your fix, however, if we apply it to the source dir we only execute sed once.


Inherit Styles from the Body 2nd Exercise

2nd Exercise in Inheritance of Body Styling seems to have a Bug. I followed the exercise to the tee.
Body Background begins with a color of black from exercise 1 in this section.
Instructions state to add an:
Hello World
 which I did below the closing  tag.
Then it states to change the Body Style background-color to green.
Then add a font-family: Monospace; style to the body css
The color of the
Hello World
 text remains black/dark gray.
And, press to test and it says it failed. I did a reset of the code and made sure to execute the directives i the order give and
Hello World
 text remained black/dark gray and it said the exercise didn't pass.
Challenge Name

https://www.freecodecamp.com/challenges/inherit-styles-from-the-body-element#?solution=

Hello World

Screenshot

it also remained gray after I placed the style rule for font-family: Monospace;

@lumenotti This should do it

Hello World

@Deadpool37 please don't share answers in the issues threads. @lumenotti please consider clicking the Help button and getting feedback on your code from other campers in the chat room.

Thank you.  But, I think the instructions could have
been a little better.
On Fri, Sep 30, 2016, 4:19 AM Ananay<EMAIL_ADDRESS>wrote:

@lumenotti https://github.com/lumenotti This should do it

Hello World
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/10996#issuecomment-250686677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFG8fgweIa747TGSRwCNQ74CCFOaBvdmks5qvMYBgaJpZM4KKvTx
.

--
Sent From Lynn's Mobile

I'm open to suggestions, but the error here was a confusion between background-color and color, the latter of which is what the instructions say to use.

Thank you. Yes I missed the nuance of that instruction and stupidly kept
changing the color on the backgroun-color rule when I actully new better.
Suggestions are fine by me. I do like learning the hard way. It last
longer. :)
On Fri, Sep 30, 2016 at 12:30 PM, Dylan<EMAIL_ADDRESS>wrote:

I'm open to suggestions, but the error here was a confusion between
background-color and color, the latter of which is what the instructions
say to use.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/10996#issuecomment-250789673,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFG8ftNoFpXvg01RioUH7j2Xx5Yns4eMks5qvTkLgaJpZM4KKvTx
.

Є
30 вер. 2016 08:32, користувач "LG"<EMAIL_ADDRESS>написав:

2nd Exercise in Inheritance of Body Styling seems to have a Bug. I
followed the exercise to the tee.
Body Background begins with a color of black from exercise 1 in this
section.
Instructions state to add an:
Hello World
which I did below the closing tag.
Then it states to change the Body ℃эхх℃ nn ёт-ёёёzё toхххх greenn.z ёёхё!
хэ
Then add a font-family: Monospace; style to the body css
The color of the
Hello World
text remains black/dark gray.
And, press to test and it says it failed. I did a reset of the code and
made sure to execute the directives i the order give and
Hello World
text remained black/dark gray and it said the exercise didn't pass.
Challenge Name

https://www.freecodecamp.com/challenges/inherit-styles-from-the-body-element#?solution=


Restarting ballistics misses a frame

This might be the cause of #5339

Moving this out to beyond m3 since it doesn't currently fit our priorities, but it is something we will fix in due course. Please let us know if this is a priority for you and you can't work around it.


Add support for tested task group @glazunov996

Resolves Nested Subgroups https://github.com/astronomer/dag-factory/issues/119 issue
Original PR: https://github.com/astronomer/dag-factory/pull/141

Codecov Report
Attention: Patch coverage is 83.72093% with 7 lines in your changes missing coverage. Please review.

Project coverage is 93.12%. Comparing base (841c5ff) to head (3374986).

Files with missing lines
Patch %
Lines

dagfactory/dagbuilder.py
83.72%
7 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   93.95%   93.12%   -0.83%
==========================================
  Files           8        8
  Lines         645      669      +24
==========================================
+ Hits          606      623      +17
- Misses         39       46       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


BasicScore and TextField for Kiwi.HUD.Widget do not have default color.

I can understand TextField not having default style but I assumed that the score widget would have a built in style. Or at least a default color.

Looked into adding a default to the TextField and ScoreWidgets but decided not to.
The reason is that if we do assign a default color then any external selector that users could set wouldn't be (easily) settable due to selector specificity.
Also currently it will inherit the default color of its parent, which is probably fine in most cases as it would most likely be black. (The example repo is unique case where the default color white matches the default background color of the document).
On another line of thought, I do think that users being able to set default styles upon creation of the widget should be explored though and will keep this in-mind for future.


Won't recognize path to python interpreter

Issue Type: Bug
I just installed VS code on Windows, but I can't get anything to run becasue I keep getting an error saying my Python path is invalid. I have tried manually changing the path to the correct folder. I have also tried reinstalling Python (specifically Python 3.10). I belive the path should be C:\Users\<username>\AppData\Local\Programs\Python\Python310 , as this is where Python 3.10 downloads to on Windows (I have checked this is where it should be).  Is the issue that there is no .exe file in the Python310 folder? Python 3.10 installation does not create one.
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
AMD PRO A8-8600B R6, 10 Compute Cores 4C+6G     (4 x 1597)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
6.92GB (1.35GB free)

Process Argv
--crash-reporter-id 5ee6b582-0b58-4628-b5b3-0e6871c6f734

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

python
ms-
2021.12.1559732655

vscode-pylance
ms-
2022.1.1

jupyter
ms-
2021.11.1001550889

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30425749
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30384385
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dsc:30424895
pythonvs932:30410667
vscop804cf:30404767
vscop940:30404999
vsrem710cf:30416617
vsbas813:30426126
vsic-wlc-tsjs:30426436

/extPython


pip install watch_recognition/ isn't working

I have tried to install the package and it didn't work.
It gave me this error: ERROR: Invalid requirement: 'watch_recognition/'

It's been a while, maybe there was something wrong in the commands at that point in time:
Try running the makefile command dev-install which does the following:
pip install -r dev-requirements.txt && pip install -e ./watch_recognition


CurseForge mark on Command Macros compitable with 1.19.2

Hello, please put a note on CurseForge that it is compatible with 1.19.2, I need it for the Modpack.

1.6.0-1.19.X was released with 1.19.1/1.19.2 support.


fix: wildcard relations should observe constraints (#603)

This PR resolves #603.
Type of PR:

[x] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Documentation
[ ] Other, please describe:

Breaking changes:

[x] No
[ ] Yes

Details
Wildcard relation loading invokes withAll immediately but does not observe any constraint(s) that may exist. This PR passes on any constraint(s) to the invokable and resolves as a bugfix.
Moreover, this means the withAll query method can observe constraints. Since this was not previously possible, it can be classified as a new feature.
Furthermore, the documentation has been updated to include an example of how constraints can be applied to both withAll and wildcard relation queries.

Wonderful thanks! Yea it's tough to say whether this is bug fix or feature addition 😅  But either way, it looks great! Thanks!


more flexibility in happi configuration

Current behavior expects database in one location only. This is likely a good default, but respecting environment variables is probably a good idea.

Eh... I'm gonna say "as needed"


Align enum generated with 'end'

type
  Align* {.size: sizeof(cint), pure.} = enum
    fill = 0
    start = 1
    `end` = 2
    center = 3
    baseline = 4

Is there any reason that end is a string?

This is of course not a problem, just funny, the end is highlighted in a different color.

PS Also idk why but autosuggest cant complete values of any enams, so every time I open it via goto to see the possible values in the generated bindings.(

end is a nim keyword, so it has to be stropped, thats why its highlighted differently.


Last synced just now does not update

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/41045
PROPOSAL: https://github.com/Expensify/App/issues/41045#issuecomment-2078591424
Tests

Connect to QBO
Observe the "Last synced just now" text
Wait for several mins
Come back
Verify that the text changed correctly

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Connect to QBO
Observe the "Last synced just now" text
Wait for several mins
Come back
Verify that the text changed correctly

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@aldo-expensify @mountiny @Ollyws
Here's the data returned from BE. The date format is not correct, it should be 024-04-26 08:55:57

I don't look incorrect to me, isn't that an ISO data string? We want to avoid changes in the backend that would cause problems with OldDot

@tienifr the route is incorrect, there should not be expensify.com.dev for you. Did you have this set up working before?

@tienifr Just manually update the domain part to dev.new.expensify.com:8082

@tienifr Requested one change and lint is failing

@Ollyws

until the page is refreshed. So it's no longer fixing the issue.

This is not right though. It should change with each re-render or change of the last sync value that comes in through pusher.
So if user navigated away in the app and comes back to the accounting page, they will see different time.
Essentially the only flow the setInterval would be fixing is that admin will sync the connection and remains on the page for a while and the value will not update on its own. I think however this is pre-optimization and admins will not really hang on that page waiting for the text to update, they can navigate away and back to see the timestamp update.
So I think we can move ahead @Ollyws can you complete the review please?

@mountiny @hayata-suenaga @tienifr let's change this over to the QBO free branch and merge it

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Additional file Windows path

Hi,
iam having problem to sync files on windows. I documentation is just an example of Linux path so i tried it like this
"syncSettings.additionalFiles": ["C:\\Users\\Username\\.ssh\\config"]
but it does crate file named C and its empty. Does this feature works on Windows or its just syntax wrong?
Thanks

Yes, there is an issue with static paths like C:\\Users\\Username\\.ssh\\config. The filename of the backup should be c--Users-Username-.ssh-config but the : isn't replaced.
But anyway, you should can use "syncSettings.additionalFiles": ["~/.ssh/config"] which will work even if you username is different.

Now it works. Thanks


Create osrs-clan-notifications

plugin to capture clan notifications and send then to a web api

Would Dink fulfill your use case? It's also built to facilitate custom handling beyond discord. (disclosure: i'm a maintainer of dink)

Hey @ividrine, tried to reach out on discord, but not sure if I have the right username, so just leaving my comments here:

This is specifically for capturing clan notifications rather than individual user achievements.

I'm not sure I follow; doesn't your plugin also only trigger on the local player's achievements? Dink also uses some clan events, and is often used by clan discords (or custom event handling servers).

One of the big things we wanted this for was to get notifications for clan coffer deposits / withdraws. Let me know if you think there is a workaround for this using Dink

If coffer notifications would allow Dink to satisfy your use case, we can add that as a new notifier in the plugin! If so, feel free to create a PR or issue on the repo (& I'll get to it shortly)

After giving it some thought I think it makes the most sense to use Dink for my use case. Even though clan only notifications would be neat, I think its a very niche thing most people probably aren't concerned with and since its an already well maintained project I'd rather just add contributions there where I can. Thanks again @iProdigy


[Bug]

What happened?
Registering a crafting recipe does not work
Steps to reproduce
add crafting recipe and it will not work
i even imported the recipe from the mineflow examples and still it did not work
Crash dump
No response
Plugin Version
2.8.0
Server Version
4.2.2
PHP Version
8.0.13
Server OS
linux

Only players who joined the server after the recipe was registered can craft it. So you should use the event trigger When the server start to register recipes before any players join.

I think he means that when u craft the recipe, it does not work.
When u craft the recipe you get the result, but after a few seconds the result goes away and you get the input back

I did use when the server start and it still doesn’t work

Ah, I got it. Can you send me screenshots or an exported file of the recipe?

Hi. The recipe is the exact one from your tutorial I downloaded it from the MineflowExamples and imported it to my server.


Support for inserting documents in collections without ObjectId?

Hello, I'd like to say this library is amazing and I'd like to see support for setting up my own id or disable inserting ObjectId when inserting documents. Looking online I saw MongoDB use to support setting the "_id" field to false which wouldn't create an object id when specified.
Could you possibly add support for this? I'm making an API for a game and do not want the "_id" field for my responses to the client, I'd like to use my own field if possible.
Thank you so much.

Hi @IvesAwadi , thanks for the kind words. 😊  And sorry for late reply, I was on vacation. 🏖
From my understanding, the _id field is mandatory in MongoDB when inserting document. Can you provide some example code?

Inserting without using ObjectId is already supported though. Just add _id with your own unique key when inserting document.
from montydb import MontyClient

col = MontyClient(":memory:").db.test   # In-memory database.
col.insert_one({"_id": 1, "value": 5})  # A simple custom id, an integer.
cur = col.find({"_id": 1})
print(next(cur))
# {'_id': 1, 'value': 5}

Thank you so much for the response, what I was looking for was a way to exclude the "_id" field when sending back the client the response as that's what I use. I was able to just set the "id" field, and then project the _id field to false when retrieving a document. I believe I found this on stackoverflow somewhere.
def find_profile(id: str):
    profile = profiles.find_one({"id": id}, {"_id": False})
    return profile


adds devEngines

This adds documentation for the devEngines feat.
https://github.com/npm/cli/pull/7766

Looks good so far.  We'll probably want to wait till the cli PR lands so we are sure of when it actually applies.

this needed to be added in the cli because package.json doc is pulled in from there


Separate CreatePage into CreatePlace and CreateGuide and add parent_node_id to pages

I am glad PagePage no longer exists

I did savour it to the fullest during its short existence.


www.centurylink.com

It's a Tier 1 ISP. This shouldn't be blocked.

Clearly some old weird false positive. Removed.


Remove “Design only” tag from Treemap illustration and fix link

https://www.carbondesignsystem.com/data-visualization/chart-types#part-to-whole
It should link directly to Treemap —> https://www.carbondesignsystem.com/data-visualization/advanced-charts/#tree-maps

FYI @jeanservaas

@theiliad @joshblack Can we address the removal of the “design only” tag. The live demo and code is now present/available.

Hey, this should've been closed with my PR #2223

I see it removed now. I must have needed to clear cache. 👍


Fix segfault in cvodes_dns

This currently does a find and replace for libsundials_cvode -> libsundials_cvodes (and the same with IDA). Attempting to modify the generator by simply removing CVODE in favor of CVODE gave me nothing for the library signature in all function calls.
This turns the tests in cvodes_dns from segfaults into just incorrect results, I suspect there's a missing Sundials function call. I'll have to dive quite a bit deeper and learn the library to figure out why the result is incorrect/garbage.

@ChrisRackauckas I'm not experienced enough to know exactly what function calls are missing here, but we get a CV_NLS_INIT_FAIL = -13 error on call to CVode. I assume we need something like CVodeSetNonLinearSolver in there?

I did a quick modification to the generator code so new code will do this.

@ChrisRackauckas I'm not experienced enough to know exactly what function calls are missing here, but we get a CV_NLS_INIT_FAIL = -13 error on call to CVode. I assume we need something like CVodeSetNonLinearSolver and CVodeSetLinearSolver in there (I think the NLsolver needs the linear solver available, at least according to comments in the C code)?

Yeah, the example is really old because we couldn't get it to not segfault 😅. It's probably on Sundials 3 or 4.


#17126 broke the platform-serverless-vercel/vercel-cli ecosystem tests

[x] we should understand why that's the case
[x] revert the PR and gradually add back the openssl improvements we intended, by monitoring the ecosystem-tests

Vercel uses two different systems (one for building the serverless function, one for executing it) with different libssl versions available. The only compatible version between the two is openssl-1.0.x.
We had attempted to prefer the newest versions available of libssl (as using a total order helps reducing ambiguity, and newer versions are safer to use), but we reverted that change due to Vercel.

platforms-serverless-vercel (vercel-cli, binary/library, ubuntu-20.04) are still failing at the moment.
@jkomyno Is this tracked somewhere else?

@Jolg42
https://github.com/prisma/ecosystem-tests/pull/3373


Self intersecting polygons returned

Consider the following output:

created by:
import numpy as np
from buildingboundary import trace_boundary
xarray=[125213.792,125213.511,125213.213,125212.895,125213.387,125212.801,125212.161,125209.805666667,125211.831,125210.097333333,125209.805666667,125211.341,125211.341,125211.216,125210.967,125210.92,125210.699,125210.542,125210.382,125210.331,125210.328,125210.178,125210.023,125210.021,125210.097333333,125214.458,125214.076,125213.474,125214.515,125214.684,125215.343,125215.057,125214.752,125214.442,125214.123,125215.237,125214.952,125214.654,125214.366,125213.725,125215.259,125214.954,125214.651,125214.366,125214.068,125213.436,125213.153,125214.535,125214.248,125213.35,125213.035,125214.089]
yarray=[480380.365,480380.343,480380.32,480380.296,480379.967,480379.922,480379.873,480378.319666667,480379.393,480378.027333333,480378.027333333,480379.941,480379.656,480379.347,480379.782,480379.324,480379.943,480380.726,480379.704,480379.992,480379.278,480380.774,480379.751,480379.255,480378.319666667,480383.325,480382.919,480382.872,480382.854,480382.387,480381.908,480381.885,480381.861,480381.838,480381.812,480381.506,480381.484,480381.46,480381.438,480381.389,480381.056,480381.032,480381.007,480380.986,480380.963,480380.914,480380.892,480380.679,480380.657,480380.587,480380.563,480380.388]
points = np.array((xarray, yarray)).T
trace_boundary(points,
 max_error=0.26,
 merge_angle=0.4,
 k=5,
 alpha=0.5,
 min_area=2,
 max_merge_distance=0.6,
 max_error_invalid=0.35,
 inflate=True)

Should be improved by dc58b43, but in very rare cases the resulting vertices might still make an invalid polygon. So if that is the case it will now return the bounding box (00831fd).


Include JavaScript in Maven Jar?

Would you be open to including the JavaScript source in Maven distributions? It would be quite useful for those of us using both the Java and JavaScript versions.

Hi Dom,
Thanks for coming up with this suggestion.
At this point in time we have only C++ and Java source in Maven Distributions . At this point this feature request is infeasible.
Thanks
Padmaksha


Implement PR from #2531

@sylvanr  Implement PR from #2531 as discussed.

2 hours on it, current state: finding best practices for csv rows to our defined data object. Using this also to consider the bulk updating rather than adding each element separately.

implementation complete, need feedback/discussion on how to approach duplicate currency entries.
For example:
For USD, we have
1951-01, USD, Micronesia
1951-01, USD, Panama
1951-01, USD, Timor-leste
1951-01, USD, United States


arrayFilter support

Basing on docs about new mongo 3.6 feature - $[]:

https://docs.mongodb.com/manual/reference/operator/update/positional-all/#up._S_[]

I wrote mongo update query:
db.users.update({_id:"iPCLJQAD7i9Lrvs4p"},{$set:{"profile.stock.$[currency].address": 4000}},{arrayFilters: [{"currency.code":"ETH"}]})

It works great in mongo shell console, but using js:
Meteor.users._collection.rawCollection().update({_id: "iPCLJQAD7i9Lrvs4p"},{$set:{"profile.stock.$[c].address": 4000}},{arrayFilters: [{"c.code": 'ETH'}]}

I have got error.
MongoError: No array filter found for identifier 'c' in path 'profile.stock.$[c].address'
I20180215-18:05:57.745(1)?     at Function.MongoError.create (/home/daniel/.meteor/packages/npm-mongo/.<IP_ADDRESS>gs2ze4.93eul++os+web.browser+web.cordova/npm/node_modules/mongodb-core/lib/error.js:31:11)
I20180215-18:05:57.745(1)?     at toError (/home/daniel/.meteor/packages/npm-mongo/.<IP_ADDRESS>gs2ze4.93eul++os+web.browser+web.cordova/npm/node_modules/mongodb/lib/utils.js:139:22)
I20180215-18:05:57.745(1)?     at /home/daniel/.meteor/packages/npm-mongo/.<IP_ADDRESS>gs2ze4.93eul++os+web.browser+web.cordova/npm/node_modules/mongodb/lib/collection.js:1059:67
I20180215-18:05:57.746(1)?     at /home/daniel/.meteor/packages/npm-mongo/.<IP_ADDRESS>gs2ze4.93eul++os+web.browser+web.cordova/npm/node_modules/mongodb-core/lib/connection/pool.js:469:18
I20180215-18:05:57.746(1)?     at _combinedTickCallback (internal/process/next_tick.js:131:7)
I20180215-18:05:57.746(1)?     at process._tickDomainCallback (internal/process/next_tick.js:218:9)
I20180215-18:05:57.746(1)?      name: 'MongoError',
I20180215-18:05:57.746(1)?      message: 'No array filter found for identifier \'c\' in path \'profile.stock.$[c].address\'',
I20180215-18:05:57.746(1)?      driver: true,
I20180215-18:05:57.747(1)?      index: 0,
I20180215-18:05:57.747(1)?      code: 2,
I20180215-18:05:57.747(1)?      errmsg: 'No array filter found for identifier \'c\' in path \'profile.stock.$[c].address\''

Is arrayFilters option supported as option in Mongo update query in this library?

I found article about this:

http://thecodebarbarian.com/a-nodejs-perspective-on-mongodb-36-array-filters.html

It looks like rather Meteor problem with update of his packages than mongojs problem.

Using array filters with Node.js requires versions >= 3.0.0 of the MongoDB Node.js driver or >= 5.0.0 of mongoose in addition to v3.6 of the MongoDB server. Earlier versions of the MongoDB (2.x) and mongoose (4.x) do not support array filters.


Thumbnails from Session not rendered

When loading uploads (images) from session, every image appears as shown in the image below.

When adding a timeout around the drawThumbnail() function call in react-fine-uploader everything seems to be fine.
setTimeout(() => this.props.uploader.methods.drawThumbnail(...), 200)
It seems that drawThumbnail tries to access the thumbnailUrl even before it is there.
Is this a bug in react-fine-uploader or am I missing something?
Thanks :-)
#update (my code)
import React, { Component } from 'react'
import cookie from 'react-cookie'
import Gallery from 'react-fine-uploader'
import FineUploaderTraditional from 'fine-uploader-wrappers'
import 'react-fine-uploader/gallery/gallery.css'

const authToken = cookie.load('angelAppToken')
const uploader = new FineUploaderTraditional({
  options: {
    session: {
      endpoint: 'http://localhost:9091/api/rest/uploads',
      customHeaders: {
        'authorization': `Bearer ${authToken}`
      },
      params: {
        angelOrderId: 4083,
        tags: ['unwashed']
      }
    },
    debug: true,
    request: {
      endpoint: 'http://localhost:9091/api/rest/uploads',
      params: {
        angelOrderId: 4083,
        tag: ['unwashed']
      },
      customHeaders: {
        'authorization': `Bearer ${authToken}`
      }
    },
    retry: {
      enableAuto: true
    }
  }
})

export class Images extends Component {
  render() {
    return (
      <Gallery uploader={ uploader } />
    )
  }
}

export default Images

http://localhost:9091/api/rest/uploads returns an array like
[
  {
    "name":"058.jpg",
    "size":834793,
    "thumbnailUrl":"someUrl",
    "uuid":259,
    "deleteFileEndpoint":"someUrl",
    "deleteFileParams":""
  }
]

the setTimeout i made for debugging was in the react-fine-uploader node module

Please show all of your code so this can be easily reproduced/investigated.

When adding a timeout around the drawThumbnail() function call

Did you make this change locally, in the <Thumbnail /> component?

confirmed - this will have to be fixed before 1.0.0. if you're able to fix and open up a PR, please do let me know. otherwise, i'll get to this when i have a chance.

Upon closer inspection, this is somewhat of a "bug" in Fine Uploader itself. The thumbnail URL is not stored with the file until a few lines after the file is added to the internal store and the UPLOAD_SUCCESSFUL status change event is fired. So, wrapping drawThumbnail in a setTimeout of even 1 ms is sufficient to workaround this particular issue. However, this seems like a kludge, and it probably makes sense to "fix" this in Fine Uploader by ensuring the totality of the canned file record is processed before the UPLOAD_SUCCESSFUL status change event is broadcast.

Fixed in React Fine Uploader v1.0.0-rc2. Can you confirm that this fixes the issue for you? Please read the release notes for this version first at https://github.com/FineUploader/react-fine-uploader/releases/tag/1.0.0-rc2. There is a breaking change.

Thank you this release fixed the issue!


Trouble with const generic

Hello @Licenser!
Thank you for sharing your excellent work.
I'm delighted to see that this crate shaves off about half the run time when parsing a huge binary file into structs, then into JSON.
As a novice programmer in general, I'm quite stuck by the below error.
When you have time, could you please help?
Code to reproduce:
use std::io::Cursor;
use binrw::BinRead;
use simd_json_derive::Serialize;

pub fn funk(bytes: &[u8]) -> String {
    String::from_utf8(Vec::from(bytes)).unwrap()
}

#[derive(Debug, PartialEq, BinRead, Serialize)]
pub struct EString<const N: usize>(
    #[br(map = |bytes: [u8; N]| funk(&bytes))]
    String
);

#[derive(Debug, PartialEq, BinRead, Serialize)]
#[br(big)]
pub struct Header {
    len: u16,
    _field: [u8; 12],
    // want: EString<4>,
    want: u32,
}

fn main() {

    let rec = vec![0x01, 0xB0, 0x00, 0x00, 0x1e, 0x0e, 0x00, 0x37, 0x93, 0xfa, 0x01, 0x21,
                   0x23, 0x0f, 0xe2, 0xf0, 0xe6, 0xf1];

    let value = Header::read(&mut Cursor::new(rec)).unwrap();
    // value.json_string().unwrap()
    println!("\n{}", value.json_string().unwrap());
}

Happy output:
When the EString struct is commented out, and when Header.want of u32 is used instead of EString<4>.
{"len":432,"_field":[0,0,30,14,0,55,147,250,1,33,35,15],"want":3807438577}
Sad output:
error: unexpected `const` parameter declaration
  --> src/main.rs:10:20
   |
10 | pub struct EString<const N: usize>(
   |                    ^^^^^^^^^^^^^^ expected a `const` expression, not a parameter declaration

error: proc-macro derive produced unparsable tokens
 --> src/main.rs:9:37
  |
9 | #[derive(Debug, PartialEq, BinRead, Serialize)]
  |                                     ^^^^^^^^^

error[E0207]: the const parameter `N` is not constrained by the impl trait, self type, or predicates
  --> src/main.rs:10:20
   |
10 | pub struct EString<const N: usize>(
   |                    ^^^^^^^^^^^^^^ unconstrained const parameter
   |
   = note: expressions using a const parameter must map each value to a distinct output value
   = note: proving the result of expressions other than the parameter are unique is not supported

error: aborting due to 3 previous errors

Heya,
sorry for the late reply. Const generics are not implemented in the derive but the EString is fairly simple you can implement Serialize like this:
impl<const N: usize> Serialize for EString<N> {
    fn json_write<W>(&self, writer: &mut W) -> simd_json_derive::Result
    where
        W: std::io::Write,
    {
        self.0.json_write(writer)
    }
}```

Adding it to the derive, while not impossible I think, might be a bit tricky and I don't have tons of time at the moment :(

Thanks for getting back!
While I'm excited at the prospect of having a workaround for this, I'm getting the same error as before 😕.
They are EBCDIC bytes, but can be considered "always right".
Can't figure out what's wrong with them in this example though..

This is the whole code that compiles for me, but the inout seems to be invalid as the  funk function crashes:
use binrw::BinRead;
use simd_json_derive::Serialize;
use std::io::Cursor;

pub fn funk(bytes: &[u8]) -> String {
    String::from_utf8(Vec::from(bytes)).unwrap()
}

#[derive(Debug, PartialEq, BinRead)]
pub struct EString<const N: usize>(#[br(map = |bytes: [u8; N]| funk(&bytes))] String);

impl<const N: usize> Serialize for EString<N> {
    fn json_write<W>(&self, writer: &mut W) -> simd_json_derive::Result
    where
        W: std::io::Write,
    {
        self.0.json_write(writer)
    }
}

#[derive(Debug, PartialEq, BinRead, Serialize)]
#[br(big)]
pub struct Header {
    len: u16,
    _field: [u8; 12],
    want: EString<4>,
    // want: u32,
}

fn main() {
    let rec = vec![
        0x01, 0xB0, 0x00, 0x00, 0x1e, 0x0e, 0x00, 0x37, 0x93, 0xfa, 0x01, 0x21, 0x23, 0x0f, 0xe2,
        0xf0, 0xe6, 0xf1,
    ];

    let value = Header::read(&mut Cursor::new(rec)).unwrap();
    dbg!(&value);
    // value.json_string().unwrap()
    println!("\n{}", value.json_string().unwrap());
}

nice glad we got that working and it's really cool to hear this could cut the execution time in half :D

Now for a dumb question - say I have loads of these -
impl Serialize for CustomField {
Can I do something like - impl Serialize for CustomField1, CustomField2 { to avoid repetition... if they're all just unit structs where I want to print out the String?

if they're all the same do they need to be different sturcts?

I'm invoking different map functions on them though:
#[derive(Debug, PartialEq, BinRead)]
pub struct CustomType1 (
    #[br(map = yyyyddd)]
    String,
);

#[derive(Debug, PartialEq, BinRead)]
pub struct CustomType2(
    #[br(map = hhmmss)]
    String
);

... and in the main Header struct, they end up like this:
    tme: CustomType1,
    dte: CustomType2,

... so the below is repetitive:
impl Serialize for CustomType1 {
    fn json_write<W>(&self, writer: &mut W) -> simd_json_derive::Result
        where
            W: std::io::Write,
    {
        self.0.json_write(writer)
    }
}

impl Serialize for CustomType2 {
    fn json_write<W>(&self, writer: &mut W) -> simd_json_derive::Result
        where
            W: std::io::Write,
    {
        self.0.json_write(writer)
    }
}

Ah I see, one way to deal with that is making a macro for it something like (the syntax might be slightly off):
macro_rules! string_type {
    ( $x:ident ) => {
      impl Serialize for $x {
          fn json_write<W>(&self, writer: &mut W) -> simd_json_derive::Result
              where
                  W: std::io::Write,
          {
              self.0.json_write(writer)
          }
      }
    };
}
string_type!(CustomType1);
string_type!(CustomType2);

If I implement a wrapper struct like this:
pub struct CustomStuff {
    #[br(map=funk1)
    tme: Custom1,
    #[br(map=funk2)
    dte: Custom2,
}

and then in Header can I refer to them as
    tme: CustomStuff.Custom1,
    dte: CustomStuff.Custom2,

so I can
impl Serialize for CustomStuff {
    fn json_write<W>(&self, writer: &mut W) -> simd_json_derive::Result
        where
            W: std::io::Write,
    {
        self.tme.0.json_write(writer)
    }
}

... note that it has to have tme.0, dte.0 etc

that would be something that needs flattening and be implemented in the upper level, so you'd either need to hand roll the entire serializer to not use the wrapper

Can't say I understand fully but I'm glad the macro you've shared works.
Thanks again for your excellent, excellent work with Rust in general (incl. tremor).

Thank you :)! I'll rename the issue if you don't mind to better capture that support or const generics would be nice.

Const generics are not implemented in the derive but the EString is fairly simple you can implement Serialize like this:
impl<const N: usize> Serialize for EString<N> {
    fn json_write<W>(&self, writer: &mut W) -> simd_json_derive::Result
    where
        W: std::io::Write,
    {
        self.0.json_write(writer)
    }
}

Adding it to the derive, while not impossible I think, might be a bit tricky and I don't have tons of time at the moment :(

@Licenser Similar to the Serialize impl in this comment, I attempted to impl for a unit struct with a field that uses const generic like so:
pub struct OString<const L: usize>(
    #[br(map = fenk)]
    String<L>
);

... where String type is from the heapless crate.
And when I try to impl, it says Only traits defined in the current crate can be implemented for arbitrary types [E0117].
So... I think this comment is still relevant to this new issue name (const generic support).
This one, I can't work around though :(
PS: Another item in the wishlist - Serialize impl for types from the speedate crate. Can I open another issue for this one, if you will get time to spare, at least sometime this year? :)


upgrade to ember-cli 0.1.9

@sandersonet for you. After this is merged you'll want to:

rm -rf node_modules tmp bower_components
npm install
bower install

Include https://github.com/quaertym/ember-cli-dependency-checker, the dependency checker that I mentioned.

Awesome!


RadzenDataGrid Grouping really slow first time

Describe the bug
When the web app has launched and grouping is attempted, it can take tens of seconds on the first attempt. Subsequent attempts finish without delay. The time it takes depends on the number of references in the project.
To Reproduce

Create a fully interactive Blazor app with lots of dependencies, e.g.

  <ItemGroup>
    <PackageReference Include="AutoMapper" Version="13.0.1" />
    <PackageReference Include="CsvHelper" Version="31.0.4" />
    <PackageReference Include="Dapper" Version="2.1.35" />
    <PackageReference Include="FluentValidation" Version="11.9.1" />
    <PackageReference Include="Hangfire" Version="1.8.12" />
    <PackageReference Include="Humanizer" Version="2.14.1" />
    <PackageReference Include="IdentityServer4" Version="4.1.2" />
    <PackageReference Include="MediatR" Version="12.2.0" />
    <PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.4" />
    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
    <PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
    <PackageReference Include="Moq" Version="4.20.70" />
    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
    <PackageReference Include="NLog" Version="5.2.8" />
    <PackageReference Include="NUnit" Version="4.1.0" />
    <PackageReference Include="Polly" Version="8.3.1" />
    <PackageReference Include="Radzen.Blazor" Version="4.30.2" />
    <PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.4" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.4" />
    <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="8.0.2" />
    <PackageReference Include="Reinforced.Typings" Version="1.6.3" />
    <PackageReference Include="NPOI" Version="2.7.0" />
    <PackageReference Include="Serilog" Version="3.1.1" />
    <PackageReference Include="Swashbuckle.AspNetCore" Version="6.5.0" />
  </ItemGroup>

Create a component

@page "/"

<h1>@counter</h1>

<RadzenDataGrid Data=@data AllowGrouping>
    <Columns>
        <RadzenDataGridColumn Title="GROUP" Property=@nameof(ItemType.Group) />
        <RadzenDataGridColumn Title="PROP1" Property=@nameof(ItemType.Prop1) />
        <RadzenDataGridColumn Title="PROP2" Property=@nameof(ItemType.Prop2) />
    </Columns>
</RadzenDataGrid>

@code {

    class ItemType
    {
        public string Group { get; set; }
        public string Prop1 { get; set; }
        public DateTime Prop2 { get; set; }
    }

    ItemType[] data;
    int counter;

    protected override void OnInitialized()
    {
        data = Enumerable.Range(0, 50)
            .Select(v => new ItemType { Group = $"g{v/5}", Prop1 = $"p{v}", Prop2 = DateTime.UtcNow.AddHours(1) })
            .ToArray();

        Task.Run(async () =>
        {
            while (true)
            {
                counter++;
                await InvokeAsync(StateHasChanged);
                await Task.Delay(250);
            }
        });
    }
}

Launch, attempt grouping, need to wait several seconds for the grouping to finish.

If you use VS debugger and retry this several times, make sure you remove bin folder between attempts.
Expected behavior
Grouping should be immediate.
Additional context & Workaround
This happens because System.Linq.Dynamic.Core by default loads all referenced assemblies to app domain: https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/6d0acaa48d38befca79ea07af9749e2874e075cc/src/System.Linq.Dynamic.Core/DefaultAssemblyHelper.cs#L49
The default behavior can be avoided statically like this:
// Change the methods if you need any dynamic linq custom types somewhere in your app.
class MyCustomTypeProvider : IDynamicLinkCustomTypeProvider
{
    static readonly HashSet<Type> empty = [];
    public HashSet<Type> GetCustomTypes() => empty;
    public Dictionary<Type, List<MethodInfo>> GetExtensionMethods() => throw new NotSupportedException();
    public Type ResolveType(string typeName) => throw new NotSupportedException();
    public Type ResolveTypeBySimpleName(string simpleTypeName) => throw new NotSupportedException();
}

System.Linq.Dynamic.Core.ParsingConfig.Default.CustomTypeProvider = new MyCustomTypeProvider();

With this workaround grouping is immediate.
System.Linq.Dynamic.Core has overloads for providing a ParsingConfig as a parameter (e.g. .Where(parsingConfig, "...")), so Radzen could use those to avoid having to set the provider globally.

Can you point us to some example where we can replicate this slowness? Works pretty fast in my opinion even on this demo with a lot of records: https://blazor.radzen.com/datagrid-performance


New version: Coulter v0.3.0

Registering package: Coulter
Repository: https://github.com/tlnagy/Coulter.jl
Created by: @tlnagy
Version: v0.3.0
Commit: edee0459810ea262e36a211959bbda79b24897ed
Reviewed by: @tlnagy
Reference: https://github.com/tlnagy/Coulter.jl/commit/edee0459810ea262e36a211959bbda79b24897ed#commitcomment-131313049
Description: Interfacing with Beckman-Coulter Multisizer/Z2 Coulter Counter files (.#=Z2, etc) in Julia

This is a little bizarre to me because Dates is in the stdlib and is doesn't even have a version listed in Pkg.status:
(Coulter) pkg> st
Project Coulter v0.3.0
Status `~/.julia/dev/Coulter/Project.toml`
  [864edb3b] DataStructures v0.18.15
  [31c24e10] Distributions v0.25.102
  [5789e2e9] FileIO v1.16.1
  [5ab0869b] KernelDensity v0.6.7
  [2913bbd2] StatsBase v0.34.2
  [ade2ca70] Dates

How should I proceed?


backup: update crds

Longhorn/longhorn#5189
Signed-off-by: Derek Su<EMAIL_ADDRESS>

BTW, should we provide per-volume backup concurrent threads?

BTW, should we provide per-volume backup concurrent threads?

Do you mean set the number of concurrent threads for each backup from a volume? If yes, it seems not quite meaningful or too granular, because I thought it should be a thread pool for all backup operations.

It is sometimes useful if users want to controller which volume can run faster and which one can run slower.
We can improve it another ticket if users have feedbacks.

If yes, it seems not quite meaningful or too granular, because I thought it should be a thread pool for all backup operations.
For current implementation, the concurrent limit means how many worker threads per backup.

It is sometimes useful if users want to controller which volume can run faster and which one can run slower. We can improve it another ticket if users have feedbacks.

Sounds fair and good to me :+1:

cc @innobead


"Understanding Mathax Performance" Outdated?

I have a performance problem with a page with many large MathJax blocks in it (extremely slow initial rendering of the blocks).
Before I start digging into whether anything can be improved, is this wiki page on the performance still an accurate representation of the current issues: https://github.com/mathjax/MathJax/wiki/Understanding-mathjax-performance (it seems to be quite old)

Don't start digging here.
We're currently working on v3 which will be a complete overhaul of MathJax internals. The repository is at https://github.com/mathjax/mathjax-v3
But also have a look at https://github.com/mathjax/MathJax-node for server-side rendering.


[Android]IndexOutOfBounds when using DashPattern

When you set the BorderMarkup DashPattern to anythink other then 0 when using Android a  Java.Lang.ArrayIndexOutOfBoundsException is thrown.

DashPattern is meant to be set to at least two values, seperated by a comma.
e.g. "10,4" would mean that the dash is 10 units wide and the space in between them is 4 units wide.
Setting it to a single value will indeed throw an error (because it won't work with a single value anyway), which I'm adding a check for.

Ahh all right. Thank you very much fpr the quick reply. :)

As a small edit. I would suggest setting the DashPattern with only one number would result that the dash length and the spacing are the value set in the DashPattern. On iOS this seams to work already.

This should be fixed in the current beta if you want to verify.

So I've taken a look it works just fine now. 👍
If you'd like I can create a quick pull request for the documentations, so that users know that they can set the dash gap aswell if they'd like to.
Only one thing that seamed a litle of, though it doesn't bug me, when I was using the Android version the dash gap was very small. I don't know why. Just wanted to let you know.

@BaseCrusher Thanks for the kind words, appreciate it. I'll happily take a docs PR :) I didn't even know that was possible for Wiki, so you learn something new every day. There is definitely a visual difference between Android and iOS for the dashes, but I haven't found the magic formula that makes the look in sync yet.
Regarding sponsoring, I don't quite know what people typically set up for that. I have the GH sponsors thing here, I have a Twitch stream where I guess one can throw bits at me. Other than that I don't know what people use these days. If you have suggestions I'll gladly take em.

Closing this since the original problem was solved.

@sthewissen I realized that I'm not able to do PR's to the wiki. So Im posting it here.
##Using Dash Pattern
The dash pattern takes two arguements. The first one is for the dash length and the second one for the dash gap. Setting only the first parameter results in the dash length and the dash gap to have the same value.

Thanks, I'll add a paragraph for it!


non zero depreciated fix

To fix non zero deprecation warning. Decreases time of execution of frcnn, keypoint_rcnn etc models significantly on account of the time taken by warning.

Hi,
Thanks for the PR!
There are a few issues with torchvision CI, let me try to fix it and then get back to you, some of the errors are unrelated to your PR

Yes, absolutely I was a little concerned it might be a code bug. Well, thanks for the clarification!

Hum, looks like torchscript and ONNX might not support the as_tuple keyword in nonzero.
I think a potentially better fix is to replace torch.nonzero(tensor) with tensor.nonzero(), as it fixes the deprecated overload issue, although this sounds a bit weird. cc @gchanan is this expected that torch.nonzero(tensor) raises a warning but but tensor.nonzero() doesn't, with message
/Users/fmassa/anaconda3/bin/ipython:1: UserWarning: This overload of nonzero is deprecated:
	nonzero(Tensor input, *, Tensor out)
Consider using one of the following signatures instead:
	nonzero(Tensor input, *, bool as_tuple) (Triggered internally at  /Users/distiller/project/conda/conda-bld/pytorch_1592377720291/work/torch/csrc/utils/python_arg_parser.cpp:761.)
  #!/Users/fmassa/anaconda3/bin/python

cc @eellison and @neginraoof FYI about torchscript and ONNX apparent limitations on nonzero

So, according to @gchanan, the difference between torch.nonzero(tensor) and tensor.nonzero() is a bug.
This means that merging this PR is currently blocked by torchscript and ONNX changes.

@eellison just proposed to use torch.where(condition) instead of torch.nonzero(condition, as_tuple=True), this should fix the torchscript issues (let's hope ONNX will support it)

Yes, completely agree with @gchanan tensor.nonzero surprising doesn't throw an error. I'll try replacing it with torch.where. However, I'm not so sure how to verify if ONNX will support it? Maybe trying to export it once would help?

@java-abhinav07 if ONNX tests pass with the change, then it torch.where is supported :-)

Great, I'll commit new changes by tomorrow!

#1916 Facing this issue locally as well, could you give some insight into why this is happening @fmassa , possibly version mismatch (I'm using a cpu device)?
Heres the environment information:
PyTorch version: 1.5.0
Is debug build: No
CUDA used to build PyTorch: 10.2

OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
CMake version: version 3.10.2

Python version: 3.6
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA

Versions of relevant libraries:
[pip3] numpy==1.18.1
[pip3] torch==1.5.0
[conda] Could not collect```

@java-abhinav07 looks like ONNX doesn't support torch.where as you pointed out, so it doesn't look like there is anything we can do as of now, and we won't be able to merge this PR until this issue with ONNX is fixed in PyTorch. cc @neginraoof could you look into adding support for this overload of torch.where to ONNX?
Also, @java-abhinav07 why did you use torch.stack(torch.where( instead of just torch.where? Using stack adds unnecessary overhead, and you can just use the same implementation as before with indexing, right?.

@fmassa no solely using torch.where doesn't solve the issue for multi-dimensional tensors. torch.where outputs a tuple of tensors identifying non zero values at indices of each column dimension. Those tensors need to be stacked together to replicate the functionality of torch.nonzero with as_tuple=False.
>>> t = torch.tensor([[1, 2], [3, 4]])
>>> torch.nonzero(t).squeeze(1)
/pytorch/torch/csrc/utils/python_arg_parser.cpp:756: UserWarning: This overload of nonzero is deprecated:
	nonzero(Tensor input, *, Tensor out)
Consider using one of the following signatures instead:
	nonzero(Tensor input, *, bool as_tuple)
tensor([[0, 0],
        [0, 1],
        [1, 0],
        [1, 1]])
>>> torch.where(t>0)
(tensor([0, 0, 1, 1]), tensor([0, 1, 0, 1]))

@java-abhinav07 most usages of nonzero() are on a 1d tensor, and we use just after a .squeeze(1) to remove the added dimension. This means that most of the time, this stack is not necessary.
In [2]: a = torch.rand(10)

In [3]: a
Out[3]:
tensor([0.4069, 0.6907, 0.0880, 0.4860, 0.0721, 0.3742, 0.2973, 0.7450, 0.3434,
        0.9473])

In [4]: (a > 0.5).nonzero()
Out[4]:
tensor([[1],
        [7],
        [9]])

In [5]: (a > 0.5).nonzero().squeeze(1)
Out[5]: tensor([1, 7, 9])

In [6]: torch.where(a > 0.5)[0]
Out[6]: tensor([1, 7, 9])

@fmassa I see, yes if we are using a 1D tensor for subsequent nonzero computations then there is no need for stack. If we are sure it's always a 1D tensor then I'll rectify to simply torch.where(tensor>0)[0] however, I believe it makes sense to probably do tensor.size() and make sure it indeed is 1D since the code won't throw any error if we use the method you suggested by simply taking dim 0 nonzero indices.

@java-abhinav07 sorry for the delay in replying.
Most places are sure to have a 1d tensor all the time, I think there is only one occurence that this is not the case I think.
But given that ONNX doesn't support this overload yet, we can't merge this PR for now unfortunately

As you mentioned, ONNX export is missing for std::vector<Tensor> where(const Tensor & condition)
But there's also another problem with ONNX export after this change. The issue is that ONNX Greater does not have support for bool input). Currently exporter does not take care of the required input type casts for this op, and this results in a failure when running the exported model code in ONNX Runtime.
Export of where op is possible using a combination of NonZero and Unbind ops.
We need to fix both issues to be able to fix Faster_RCNN tests with there updates.

We can wait for ONNX support to be fixed, or open another PR later (@fmassa feel free to close the pr accordingly). @neginraoof if opening an onnx export issue helps we could create one. Either way, yeah, it makes sense, understood!

I'm going to send out a PR for export of where op and necessary export fixes.
I'll follow up on this thread.

PR to address export issue: https://github.com/pytorch/pytorch/pull/41544

Subsumed by https://github.com/pytorch/vision/pull/2705. Thanks for all the work @java-abhinav07 !


    # TODO Pickle the cutoff lists of thresholds/TPR/FPR/Sens/Spec so that ROC plots can be generated on the fly

Background

[x] Consider putting all roc/pr metrics in TSM.metrics

in the AdvancedSupervisedModelTrainer._trainer() method, we could calculate the cutoff lists for TPR + FPR and Sensitivity + Specificity so that ROC plots can be generated after the fact. This would keep the TSM smaller since it would not need the test labels and predictions stored inside.
Potential problems

ROC/PR curves are only for binary classification. Given that we want to work in multi-class support soon, this would lead to added logic.
The current solution of pickling test_set_predictions, test_set_class_labels, test_set_actual should allow multi-class evaluation like confusion matrices as is.

After prototyping, a hybrid solution was found. All ROC/PR metrics (including cutoff thresholds) are calculated and a TSM is initialized with them in it. The TSM also includes the y_test, y_predictions, and y_probabilities for now until multiclass is added to the tools.