Import and export aren't recognized

FYI, I am using vue-brunch in a Phoenix context. I have copied my .vue files to web/static/js and the plugin finds and compile them.
I initially had an issue with the babel configuration, but I copied it from the source repo where I found the .vue file.
{
  "presets": [
    ["latest", {
      "es2015": { "modules": false }
    }]
  ]
}

It then complains that import and export aren't valid tokens: Uncaught SyntaxError: Unexpected token export which points at the .vue file's main statement:
<script>
export default {
  data: () => { ... },
  ...
};
</script>

I tried to set modules to commonjs but then it complains about not being able to find some vueify module:
Uncaught Error: Cannot find module 'vueify/lib/insert-css' from 'web/static/js/SvgVueR.vue'

amd and systemjs have similar issues.
Any idea what might go wrong?

Can you setup a repo demonstrating this issue and i will look into it.

You can find a simplified Phoenix project that reproduces the issue there:
https://github.com/gballet/phoenix_vue_brunch_issue

This gentleman has found a workaround when setting commonjs in the .babelrc file.
https://gist.github.com/jlauemoeller/d53ddd028387cd139c31bf2282dd12f4
Basically, the idea is to not use vuefiy/lib/insert-css which is causing the problem.
I'm still wondering why I have to go with commonjs in Phoenix when export-style statement seem to work in a standalone brunch project?

@gballet Did you sort this out? I seem to be having the same issue... I can use commonjs format, but I'd like to use es2015.

Can confirm I'm getting the same issue. Can't seem to get this working with Vue 2.0, and es2015 modules.

@brandonparsons nope, haven't been able to use es2015 modules. Just out of curiosity, are you using a Phoenix application or a standalone brunch app?

@gballet Through Phoenix, so figure we're having the same issues :)
I got it kind of working - it required that I bundle the full version of Vue (i.e. not just the runtime). Adds a bit to the bundle size, but at least it works.

@brandonparsons @gballet are you using Phoenix 1.2? The default version of brunch in 1.2 is old, I suggest upgrading to the latest version. That solved many of the issues I've had with vue-brunch.

@imetallica I just ran mix deps.update to upgrade to phoenix 1.2.3 (the latest according to mix hex.outdated at this time) and the problem is still here. I ran npm update just to be sure and it's not changing anything.

@brandonparsons from what I understand, the export statement should be transpiled.  Phoenix doesn't have anything to do with NPM.

@gballet also, you need something like this
plugins: {
    ...
    vue: {
      extractCSS: true,
      out: '../priv/static/css/components.css'
    }
    ...
}

@nblackburn @brandonparsons I have managed to solve the problem. It seems that the issue is with using babel-preset-latest instead of babel-preset-es2015. Both have the same version, 6.24.0.
Also, the .babelrc needs to be updated to reflect that change, from:

{
  "presets": [
    ["latest", {
      "es2015": { "modules": false }
    }]
  ]
}

to:
{
  "presets": ["es2015"]
}

Could you please confirm that this solves the problem on your end, so that I can close the issue?
Also, @imetallica thanks for your help.

@gballet Glad you got it sorted in the end, i am unable to confirm this fixes the issue so will have to take your word for it on this occasion.
I will wait for @brandonparsons first and if they are happy then this can be closed.

@gballet How did you not use babel-preset-latest? It is a dependency of babel-brunch @ 6.1.1.

@gballet I've tried blowing everything away, and even installing babel-brunch from the Github master (they have replaced babel-preset-latest with babel-preset-env).
I still get the following error unless I tell brunch to use the full version of vue (not runtime only):
[Vue warn]: You are using the runtime-only build of Vue where the template compiler is not available. Either pre-compile the templates into render functions, or use the compiler-included build.  (found in <Root>). It doesn't appear to be properly compiling the single-file vue component (I have a test component set to render on the page).
Here is my package.json:
{
  // .....
  "dependencies": {
    // .......
    "phoenix": "file:../../../deps/phoenix",
    "phoenix_html": "file:../../../deps/phoenix_html",
    "vue": "^2.2.6"
  },
  "devDependencies": {
    // .....
    "babel-brunch": "github:babel/babel-brunch#c42c598076dcdd44f5dbe3c310f78e06e992c6e1",
    "babel-core": "^6.24.0",
    "babel-preset-es2015": "^6.24.0",
    "brunch": "^2.10.9",
    "uglify-js-brunch": "^2.10.0",
    "vue-brunch": "^2.0.1"
  }
}

I have to add the following to brunch-config.js to get it to work:
    aliases: {
      "vue": "vue/dist/vue.common.js"
    }

I sorted out the problem.
Everything was working fine. The issue was that when I was bootstrapping the Vue instance on my test page, I was using the el option in the Vue constructor.  This apparently uses template compilation. If you want to use the runtime-only version of Vue, you have to bootstrap your root component using a render function.
This issue can be closed.

@nblackburn actually can you update the README to the changes that need to be done if you want to use the vue.common.js, so you can create single file components and export the css from these components.
The changes are the following
plugins: {
    vue: {
      extractCSS: true,
      out: '../priv/static/css/components.css'
    }
},
npm: {
  aliases: {
    "vue": "vue/dist/vue.common.js"
  }
}

@imetallica I will update the README with instructions on extracting CSS but using the correct build of Vue dependent on the use case is out of scope for this project.


Warn on unnecessary rerenders

Hmm... trying to figure out if this is an annoying message or not. Haven't vetted enough projects to know if this is common place. What drew your attention to this?

I was using a resource to store and update an object, but that was triggering an update on all fields on an object (and I would imagine there might be a similar issue with signals in beginner's code). I realize that this could be annoying if intentional though

I was also wondering what this looks like on common projects so I tried it on the playground and there were no warnings, but that isn't a perfect test


Rebrand to urllib3000

Thanks for the reply. If you plan to advertise this project beyond your own use we would appreciate not using the "urllib3.future" name and our logo so as not to cause confusion about association with the urllib3 project.

Originally posted by @sethmlarson in https://github.com/jawah/urllib3.future/issues/46#issuecomment-1834381354
I must say i was a bit confused with the project name, looked like directly related to the original urllib3
Possible names

urllib3000
urllib300
urllib4
httpxlib
n...

Me too! urllib3 and urllib2, and urllib got me confused a lot at first.
We get used to.
The name proposed does make fix this. It's already used and depended on, can't change for now.

looked like directly related to the original urllib3

now you know. it's not.

You need to rebrand. Closing issues does not change reality.

You need to rebrand.

I don't.

You need to rebrand.

I don't.

Right, amateurs don't.


SUM files update

Hi, please can you update the sum files with new versions of ogg?
https://ftp.osuosl.org/pub/xiph/releases/ogg/  ← MD5SUMS is missing the latest release
Thanks in advance.

Thanks for the report. That's deliberate. the MD5SUM and SHA1SUM files are no longer useful for verifying package integrity and shouldn't be used. I've left them in the archive for historical reference.
If it's causing problems for you I can remove the files, but for any verification you should be using SHA512SUMS or SHA256SUMS.

Ok, thanks for the explanation. No needed to remove these files, we are relying on SHA256SUMS in our codebase now :+1:


Add hasmukh96's file

Added a branch
Added code into the new branch
Creating a new pull req

nothin

nothin


(libreoffice) AU; reduced chocolateyInstall; ketarin removed; nuspec updated

I reduced install because I don't think version checking mechanism ever executes as the version in registry is different then the one reported remotelly (5.2.2. vs <IP_ADDRESS>) and that is probably the same for other versions.
So please take a look and compare with old version.
I am not sure about comment on the first line either:
Important: The contents of this file – the `libreoffice` and
`libreoffice-oldstable` install scripts – **must** be identical.

@ferventcoder , @gep13 , PING


Require ibmapm on first initialisaton of appmetrics.

This code change is just like Howard's change https://github.com/hhellyer/appmetrics/commit/de7a636da225cd896fdaa8b1a4c7facd074647f9.
As we have create a new npm package ibmapm-embed, the ibmapm-embed has removed the appmetrics from package.json, and add a attach function. So change the require to "ibmapm-embed".

Codecov Report

Merging #523 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
+ Coverage   58.52%   58.67%   +0.14%
==========================================
  Files          48       48
  Lines        2944     2945       +1
==========================================
+ Hits         1723     1728       +5
+ Misses       1221     1217       -4

Impacted Files
Coverage Δ

index.js
75.13% <100%> (+0.13%)
:arrow_up:

probes/http-outbound-probe.js
94.36% <0%> (+2.81%)
:arrow_up:

probes/https-outbound-probe.js
94.36% <0%> (+2.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1d929...b74d2e2. Read the comment docs.

This looks ok from the appmetrics side although I'm not sure why global.Appmetrics = module.exports; gets moved to the bottom? It is assigning the same object so I don't think that should be needed.
I understand that the agreement is that ibm-apm will do nothing and have zero impact unless it finds a certain environment variable set, however I see that loggers are set up and it attempts to open files (see console output below from our test suite) and I don't think this is quite right.  Looking at https://github.com/IBM-APM/node-ibmapm-embed/blob/master/index.js I would expect to see a check and return right near the top of the file, even before most of the require statements.
    [2018-03-21 03:42:04.076] [INFO] knj_log - KNJ_LOG_LEVEL is not set or not set correctly through environment variables.
    [2018-03-21 03:42:04.080] [INFO] knj_log - The program set default log level to INFO.
    [2018-03-21 03:42:04.379] [INFO] util.js - ENOENT: no such file or directory, open '/home/travis/build/RuntimeTools/appmetrics/tests/probes//package.json'
    [2018-03-21 03:42:04.379] [INFO] util.js - ENOENT: no such file or directory, open '/home/travis/build/RuntimeTools/appmetrics/tests//package.json'
    [2018-03-21 03:42:04.380] [INFO] BAMPlugin.js -  VCAP_APPLICATION env variable is not found.

@sjanuary
I have clean the DC code, to remove some unnecessary logic and logs, and updated the npm package also. You can have a review again.
The Node.js DC cannot return just by checking a environment, except  "process.env.NODEJS_DC_DISABLE" or "process.env.ITCAM_DC_ENABLED" is set. We have such logic in the "https://github.com/IBM-APM/node-ibmapm-embed/blob/master/index.js" now.
The DC need to check whether the APM's server URL is set or not.  Most time the DC will return directly, if there is no APM URL is set, the DC will not start. But in the ICp case, the user can set the APM URL by mount a kubernetes secrets, the DC will polling the user's secret( mount into the container)  by every minute.  You can refer to https://github.com/IBM-APM/node-ibmapm-embed/blob/master/lib/ibm_apm_restclient/lib/plugins/BAMPlugin.js .

if (k8sutil.isICP() && !process.env.IBAM_INGRESS_URL) {
intervalObjSec = setInterval(pollMountSecret, 60000);
intervalObjSec.unref();
}

I would like to confirm the expected behaviour here and how we expect the code to work.  Because we will be requiring you, we need to make sure that in all the environments where BAMDC is not running, the impact of calling your code is as minimal as possible.  This is why we want your code to return straight away, without setting up logs, variables or anything else that is not required if BAMDC is not going to be used.   Can you have the environment checks for {process.env.NODEJS_DC_DISABLE" or "process.env.ITCAM_DC_ENABLED} as the very first thing your code does and then return ?

@tobespc I have moved the env checking to the top of index.js, and check it into git repo. will update to npm  server once the review finished. Thanks.

ok, @sjanuary and myself and some more concerns.   How are those values going to be set in the default case.  The default case would be that neither of those values are set and this would mean you would not return to us.  We would need the behaviour to be always return UNLESS the values were enabled by BAM.  Any environment variables could be used but we have to assume that the default case is users are not using BAM and have not set any env variables to say "do not use BAM"

@tobespc as you know I have 2 weeks vacation coming up after today so someone else may need to merge this but what I am looking for before merging is to see no APM output in the tests (currently we see the 5 lines I quoted above e.g. https://travis-ci.org/RuntimeTools/appmetrics/jobs/356180510).  This will help us confirm that APM is exiting immediately as well as inspecting https://github.com/IBM-APM/node-ibmapm-embed/blob/master/index.js. Once the new ibmapm-embed package has been published we can manually request a rerun of the Travis build for this PR to see the results, they won't run automatically unless the content of the PR changes.
I was also looking for the line global.Appmetrics = module.exports; to not be moved, I don't think moving it makes any functional difference so it would make sense to leave it as it is unless I'm missing something.  This may be overly picky but I think the code is easier to read to leave it straight after the else statement.
@shiyanf Will ibmapm-embed conform to semver (https://semver.org/)?  So no breaking changes in minor and patch releases?

@tobespc @sjanuary

I rollbacked the global.Appmetrics = module.exports; change.  The node.js DC conform to semver, there is no breaking changes in minor and patch releases.

@tobespc @sjanuary About the node.js DC's behavior in default case. As I commented before, the node.js DC will check if a APM server URL is set, not by checking a environment variable. Unless the node.js DC find APM server URL, otherwise the Node.js DC will not start at all.
It is not a good idea to enable/disable Node.js DC by set a environment. Actually even the user require node.js dc directly, they only need to update package.json and 'app.js'.

@tobespc @sjanuary APM node.js DC has some usability design:

Pulling a file (in Kub environment, it can be a mounted ConfigMap/Secret) to get the APM server connection info.
Auto-discover the APM server connection info.

These design allow the customers get their deployed application monitored by APM automatically without re-start the application, or switch to a new APM server.
Your suggestion of "set env variables to say "use BAM" or "do not use BAM"" will "kill" this usability design, because the user has to re-start/re-deploy their app anyway to switch the env variable for enable/disable.
To have the benefit of APM usability design, I think we have 2 options:

Keep the "pulling" and "auto-disvocer" logic in APM node.js DC. APM node.js DC will be always enabled. While APM node.js will keep minimal load ("pulling", "auto-disvocer" logic) before detecting valid APM server connection info.
Move the APM server connection info "pulling" and "auto-disvocer" logic to appmetrics, appmetrics can enable/disable the APM node.js DC base on if valid APM server connection info discovered.

I prefer option 1), which requires less code changes and test. Do you agree?

When we originally discussed enabling APM the late enablement option in kubernetes didn't come up.
I can see why you are keen for the late enablement inside kubernetes, I'm not sure how much overhead there will be to regularly checking whether the secret you use has been added. However I think there may be a bigger problem - appmetrics can only instrument npm's as they are required. If APM starts appmetrics well after application startup then we won't instrument that code and won't be monitoring correctly. Not restarting the application when enabling appmetrics may mean you lose data, depending on what you are using this may be a major problem.
Appmetrics is designed to be required before any npm's that need to be monitored:
https://github.com/RuntimeTools/appmetrics#modifying-your-application-to-use-appmetrics
Users requiring appmetrics too late is one of the number one causes of issues when using appmetrics. Looking at  it closely the code in node-ibmapm-embed is likely to be requiring too many things before it loads appmetrics (if it wasn't already loaded).
Restarting an application to enable appmetrics monitoring is a requirement, I think the late enablement option is likely to result in you receiving incomplete data and the user seeing strange behaviour. The environment variable option is probably better as late enabling appmetrics (via APM or otherwise) isn't supported.

@hhellyer the node-ibmapm-embed is only used for the appmetrics, this one cannot be used in the user's app by 'require('ibmapm-embed')'. To use this node-ibmapm-embed, the user just need to add 'require('appmetrics')' in the app.  So when the node-ibmapm-embed is required the appmetrics should be loaded already.

@qiyaod @shiyanf could you please point us to the code responsible for both the "pulling" and "autodiscovery" routes to enabling APM so that we can better understand what is happening and what the overhead will be?  I agree that it makes sense to keep the code in APM but we would like to understand the impact on appmetrics.  I also think that making it as minimal as possible should mean no logging output, not because this is a performance issue but because it could be confusing to appmetrics users who are not using APM.

@sjanuary In the https://github.com/IBM-APM/node-ibmapm-embed/blob/master/lib/ibm_apm_restclient/lib/plugins/BAMPlugin.js , the function pollMountSecret will be invoked every minute.
    if (k8sutil.isICP() && !process.env.IBAM_INGRESS_URL) {
        intervalObjSec = setInterval(pollMountSecret, 60000);
        intervalObjSec.unref();
    }

And in the function poollMountSecret, once a server url is setted, a boolean initialized  is set true also. Then a event bam_initialized will be emitted,
function emitEvent() {
    if (initialized) {
        logger.debug('Emit bam_initialized event. count = ', count, initialized);
        ready_event.emit('bam_initialized');
        if (count > 10) {
            clearInterval(intervalObj);
        }
        count++;
    }
}

And the event will trigger the function startDC() in the https://github.com/IBM-APM/node-ibmapm-embed/blob/master/index.js , then the DC is started.

@shiyanf can you provide the log of the "no APM" scenario, let's make sure if no APM is setting the log is not confusing to the appmetrics users who are not using APM.

If there is no APM server, the Node.js DC will not dump any log to console and file.
D:\projectdoc\node.js\testware\acmeair-nodejs>node app.js
[Tue Apr 17 15:23:25 2018] com.ibm.diagnostics.healthcenter.loader INFO: Node Application Metrics <IP_ADDRESS>804171520 (Agent Core 3.2.6)
[2018-04-17 15:23:26.497] [INFO] app - host:port==localhost:9080
[2018-04-17 15:23:26.499] [INFO] app - db type==mongo
[2018-04-17 15:23:26.553] [INFO] routes - Use dataaccess:../dataaccess/mongo/index.js
[2018-04-17 15:23:26.821] [INFO] dataaccess/mongo - mongo: "mongodb://<IP_ADDRESS>:27017/"
[2018-04-17 15:23:28.138] [INFO] app - Initialized database connections
[2018-04-17 15:23:28.143] [INFO] app - Express server listening on port 9080
[2018-04-17 15:23:28.565] [INFO] dataaccess/mongo - ensureIndex:null:customerId_1
[2018-04-17 15:23:28.566] [INFO] dataaccess/mongo - ensureIndex:null:originPort_1_destPort_2
[2018-04-17 15:23:28.568] [INFO] dataaccess/mongo - ensureIndex:null:flightSegmentId_1_scheduledDepartureTime_2

logs now look clean

@sjanuary so your concerns on "APM impact and log message" are addressed, correct? When will you merge the code, then we can verify and close this? This has been quite a while, let's get it close soon and move on.

@stalleyj should we do a quick performance/memory footprint comparison before merging this?

@qiyaod Can you provide some details on the performance impact please.  I know this has been going on for a long time but we have to consider some of the other places that appmetrics is deployed.  For example, Node-Red ship with us and we have done a lot of work to make sure our footprint in terms of disk space and cpu are as minimal as possible.  What I would like to know is what is the disk footprint of installing appmetrics with your code now included?   I'm going to assume for now that we would have no additional cpu overhead if running in an environment where bam is not available.  So this would mean the only impact to existing appmetrics users would be disk usage as additional packages are now going to be installed.
If you could provide this information asap, we can then look to close this issue out providing the increase is acceptable

@tobespc This is the performance test for Appmetrics and Appmetrics with Node.js DC disabled.

For disk footprint, because there are some duplicated opensource lib in ibmapm and appmetrics, and ibmapm seems require a more lower version, then it will be smaller than what appmetrics require. e.g. the following highlight, semver in ibmapm integrated is much more smaller than semver in pure appmetrics:

@tobespc I think @shiyanf means the APM Node.js DC is enabled but no APM server is set, so Node.js DC just keep polling the APM server settings, not collecting and sending data.

@tobespc In the table, "pure" is the baseline that means APM DC is disabled completely, "integrate" means APM DC is enabled but no APM server is discovered.

@tobespc BTW, the "responsetime" is in ms.

@sjanuary it requires half an hour to run one round, and we test 4 rounds for each(pure appmetrics and integrated appmetrics) it requires at least 4hours not counting the operation between rounds. To test 10 round is too large work and we really don't have more time to do it.
Good news is: recheck our raw data, we found 2 test data are not very reasonable, after we delete them and do recalculate, we found the resptime downgrade become 0.81%.

From this screen shot, the "delta" is what we do recalculate, the table with frame is the original calculation.
Also, as resptime is in a "ms" unit, the value is already very small, so every little environment wave, we shake it to 2% or larger. the following screenshot will show that the test result between each round is also big. and our test result basically within the margin of error.

To make sure the test result, we delete the "shake" one and recalculate the downgrade to 0.81%

@sjanuary in summary: 1) The response time is in "ms", any small environment variation will be magnified by percentage number. 2) From Yue several  rounds of testing, even the "pure" (appmetrics only without APM node.js DC), the response time variation can be up to 2.54%. 3) So we think in the original report the 2% is in acceptable variation scope. Any further concern?

I've spoken to Toby this morning and we've agreed that the slight difference between response time measurements aren't an issue for merging. Going to pull this in now.

@sjanuary Thanks for your great help! Could you please tell me when this code change can be published to https://www.npmjs.com/package/appmetrics ?

@shiyanf You're welcome, thanks for making all the changes we requested. We'd like to get this released soon but there are some internal build machine issues currently which are blocking us.  We are discussing alternative options and we will let you know as soon as we are in a position to release.

@sjanuary did you fix your build machine issues and have a latest appmetrics release for verification?

We're working on it, should be sometime this week.

@sjanuary @tobespc any progress on this? Thanks!

we have pushed back to you on legal requirements.  There is an email chain sent by Sian that details the packages that APM are using that we don't yet have clearance for

@qiyaod the build is ready but as Toby said we are waiting for a reply to the email I sent to you last week about dependencies. We should take that discussion offline.

@sjanuary our PM is looking at the Pedigree Review and sent you a mail already. So the new build will be publish to NPM after that closed, correct?

@qiyaod now published to NPM


Latest idl

What changed?
Get latest idl

Why?

How did you test it?

Potential risks

Coverage decreased (-0.05%) to 61.456% when pulling 33c3ddce7f9b92f6ad721e2d5bc7ee5a685f287b on latest_idl into 955f41ced4f3ce11a30f0fcd7069b6d609876a79 on master.

Coverage decreased (-0.05%) to 61.456% when pulling 33c3ddce7f9b92f6ad721e2d5bc7ee5a685f287b on latest_idl into 955f41ced4f3ce11a30f0fcd7069b6d609876a79 on master.


Unfortunately app closed !!!

When i call this code
try {       this.imagePicker.getPictures({maximumImagesCount: 5}).then((results) => {         for (let i = 0; i < results.length; i++) {           try {             let result = results[i];           } catch (e) {             break;           }         }       }, (err) => {       });     } catch(e){     }
then app will be unfortunately closed.
I also tired remove plugin and add plugin link: https://ionicframework.com/docs/native/image-picker/
Is there any solutions?
Thanks in advance
-Anand

in /platforms/android/project.properties remove all other com.android.support:support and com.android.support:appcompat and leave the latest ones. as:
cordova.system.library.9=com.android.support:support-v13:26.+
cordova.system.library.7=com.android.support:appcompat-v7:26.+

Hi @jalescardoso
Thank you for your reply. Kindly share your  /platforms/android/project.properties code...

your project.properties should look like this:
target=android-26
android.library.reference.1=CordovaLib

cordova.gradle.include.1=com.synconset.imagepicker/starter-ignorelinterrors.gradle
cordova.gradle.include.2=com.synconset.imagepicker/starter-androidtarget.gradle

cordova.system.library.3=com.android.support:appcompat-v7:25.+
cordova.system.library.4=com.android.support:support-v4:+
cordova.gradle.include.3=phonegap-plugin-barcodescanner/starter-barcodescanner.gradle

@jalescardoso am tired but same error, app will be closed unexpectedly but its working fine in IONIC VIEW app.
I'm confused why this happen...

@AnandKumar2610 The application conflicts with the various version of com.android.support:appcompat and com.android.support:support and some plugins have unexpected behaviors. so I advise leaving only the latest version of these libraries.

@jalescardoso i am not updated any latest libraries. Actually its working fine while i using ionic 2, in few days ago i updated to ionic 3 so reason is ionic 3 is not supported in this plugin ?
then why its runs fine in IONIC VIEW app?

@AnandKumar2610 you may need to update every application.

@jalescardoso I skipped this plugin 'Image Picker', now am using camera plugin its working fine for pick a image..
Code: https://ionicframework.com/docs/native/camera/
Thank you..

I own an application in production that works perfectly:
https://play.google.com/store/apps/details?id=com.valorsoft.aluguelapp

hi @jalescardoso
I found the actual error plz find below...
06:53:37 E AndroidRuntime : FATAL EXCEPTION: main 06:53:37 E AndroidRuntime : Process: io.ionic.starter, PID: 7436 06:53:37 E AndroidRuntime : java.lang.NoSuchMethodError: No static method getScreenWidthDp(Landroid/content/res/Resources;)I in class Landroid/support/v4/content/res/ConfigurationHelper; or its super classes (declaration of 'android.support.v4.content.res.ConfigurationHelper' appears in /data/app/io.ionic.starter-1/base.apk) 06:53:37 E AndroidRuntime : at android.support.v7.view.ActionBarPolicy.getMaxActionButtons(ActionBarPolicy.java:57) 06:53:37 E AndroidRuntime : at android.support.v7.widget.ActionMenuPresenter.initForMenu(ActionMenuPresenter.java:108) 06:53:37 E AndroidRuntime : at android.support.v7.view.menu.MenuBuilder.addMenuPresenter(MenuBuilder.java:264) 06:53:37 E AndroidRuntime : at android.support.v7.widget.Toolbar.setMenu(Toolbar.java:569) 06:53:37 E AndroidRuntime : at android.support.v7.widget.ToolbarWidgetWrapper.setMenu(ToolbarWidgetWrapper.java:369) 06:53:37 E AndroidRuntime : at android.support.v7.widget.ActionBarOverlayLayout.setMenu(ActionBarOverlayLayout.java:714) 06:53:37 E AndroidRuntime : at android.support.v7.app.AppCompatDelegateImplV9.preparePanel(AppCompatDelegateImplV9.java:1362) 06:53:37 E AndroidRuntime : at android.support.v7.app.AppCompatDelegateImplV9.doInvalidatePanelMenu(AppCompatDelegateImplV9.java:1648) 06:53:37 E AndroidRuntime : at android.support.v7.app.AppCompatDelegateImplV9$1.run(AppCompatDelegateImplV9.java:140) 06:53:37 E AndroidRuntime : at android.os.Handler.handleCallback(Handler.java:739) 06:53:37 E AndroidRuntime : at android.os.Handler.dispatchMessage(Handler.java:95) 06:53:37 E AndroidRuntime : at android.os.Looper.loop(Looper.java:135) 06:53:37 E AndroidRuntime : at android.app.ActivityThread.main(ActivityThread.java:5343) 06:53:37 E AndroidRuntime : at java.lang.reflect.Method.invoke(Native Method) 06:53:37 E AndroidRuntime : at java.lang.reflect.Method.invoke(Method.java:372) 06:53:37 E AndroidRuntime : at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:905) 06:53:37 E AndroidRuntime : at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:700)
In Android mobiles, how can i fix this issue?

hi @AnandKumar2610 did you fix this issue? I noticed that this plugin causes the Android app to crash randomly when selecting images from gallery.

@Mr-Anonymous fixed that issue. Try this solution.
https://github.com/Telerik-Verified-Plugins/ImagePicker/issues/90#issuecomment-352025341

Thank you @AnandKumar2610 for getting back to me.
So you are now using the forked version from shaik305? Is that working fine for ios 11 and Android latest versions?
I am just a little reluctant to use a fork that is edited by an individual cuz I cant see what changes were done when compared to the main repo and also any new changes in the main repo may not necessary be updated in these individual fork. So I am concerned on that.
Also, I started using this plugin since the  wymsee/cordova-imagePicker is not maintained and has a lot of issues. But it appears even this Telerik-Verified-Plugins/ImagePicker plugin has not been maintained or updated for a long time now. Now that ios 11 and Android 8 is out, I dont know how long this or the shaik305's forked version will continue to work before my users will start having issues. As it is a v popular plugin that a lot of hybrid app will need, what do app developers do? Are they still using this unmaintained plugins? Is there another reliable alternative for this plugin?
Thanks again for your reply.

@Mr-Anonymous I have tested that plugin in Android 8.0 it's working fine but i don't know about IOS devices. In features we need to maintain or upgrade our app's that only solution.

Just an update on this. I have moved over to the Media Picker plugin which I feel works really good and it also looks very good in Android. Here is the link if its helps:
https://github.com/dmcBig/cordova-plugin-mediaPicker
I didnt have these issues in the Media Picker plugin, the ones I was facing with this Telerik Image Picker plugin. So I feel it is a very good alternative.

@Mr-Anonymous Are you using the https://github.com/dmcBig/cordova-plugin-mediaPicker in an ionic project? I couldn't find any Ionic-native library which provides a support for mediaPicker. How do you use it in your components/pages? (I am using Ionic 4)


[Bug] wire_<struct> should #[derive(Default)] for nested structs without a Box

Describe the bug
wire_<struct> should #[derive(Default)], because I'm getting errors after bridge_generated.rs is generated. These errors are from structs that use other structs that get passed as an argument to an api function.
These errors get solved when I #[derive(Debug)] for these types as the compiler suggests.
I reproduced it on this branche.
Just run just test-pure and you'll get a rust compiler error.
error[E0277]: the trait bound `wire_Part: Default` is not satisfied
    --> src/bridge_generated.rs:1932:21
     |
1932 |             part_0: Default::default(),
     |                     ^^^^^^^^^^^^^^^^ the trait `Default` is not implemented for `wire_Part`
     |
help: consider annotating `wire_Part` with `#[derive(Default)]`
     |
801  | #[derive(Default)]
     |

Codegen logs with RUST_LOG=debug environment variable
Was too long to post

To Reproduce
Clone my repo and check out the derive-default-bug branch.
Expected behavior
Should compile just fine (I think?)
Generated binding code
Can see for yourself on branch provided

OS
macOS
Version of flutter_rust_bridge_codegen
1.34.2
Flutter info
[✓] Flutter (Channel stable, 3.0.2, on macOS 12.4 21F79 darwin-arm, locale nl-NL)
    • Flutter version 3.0.2 at /Users/wouter/Dev/Flutter/flutter_tools
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cd41fdd495 (12 days ago), 2022-06-08 09:52:13 -0700
    • Engine revision f15f824b57
    • Dart version 2.17.3
    • DevTools version 2.12.2

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[!] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 68.1.4
    • Dart plugin version 221.5787.37

[✓] VS Code (version 1.68.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 102.0.5005.115

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.

Version of clang++
Apple clang version 13.1.6 (clang-13<IP_ADDRESS>)
Version of ffigen
5.0.1
Additional context
No response

Correction: when I derive Default it says some api2wire functions related to the nested struct are found in Dart.
When I change the generator to always add #[derive(Default)] it results in problems with *mut T pointers that don't have a default.
Any thoughts on this?

The error code
// Bug while generating bridge code for this:
pub struct Part {
    value_0: u64,
    value_1: u64,
}

pub struct Whole {
    part_0: Part,
    part_1: Part,
}

pub fn use_whole(whole: Whole) {}

maybe because we do not support having a field of struct without box. In other words:
struct A {b: B}

is not supported.
You should use
struct A {b: Box<B>}

Feel free to make a PR! I guess there are two workarounds/solutions:
a. Output some errors when the frb codegen faces such conditions, instead of blindly generate it and let the user be confused
b. Enhance the codegen, such that it really allows such non-boxed struct fields.

maybe because we do not support having a field of struct without box.
Ah that makes sense...

I'll see what I can do, but this probably going to take a little longer, since i'll need to understand more of the code now.

Take your time :) Feel free to ask questions

:+1: same here I always forget to Box my nested struct and face this issue very often lol

Yes I do see a lot of issues raised in this repo b/c this. So at least a PR generating a hard error (panic) about this would be quite helpful


Labs Inventory / manifest interaction

How will labs interact with the manifests now? Will we at all?
Will we be able to view what’s “in -transit” like we do now?
Do we have to include every sample we have in-house with a current status (column D) (“in progress” vs. “completed”?)
--If these reports are “per COA” we would never have an ‘in progress’, once we finish the tests and send the .csv file, everything would be completed.
Do labs have to upload an inventory file with uncompleted samples we have received onsite?  And if so, also an ‘inventory adjustment’ file when we use some of the sample for testing?  Or when we destroy/discard leftover samples?

Will NOT be able to view what's "in-transit"


non-default VPC

#1. Will this work with non-default VPC?
will like to use custom VPC i created
#2. Can i use an already created EFS volume?
instead of allowing EBS to create one for me?

Hi babatun,
1- Custom VPC will work as long as you configure your environment to launch instances in the custom VPC. You can use a configuration file like this one when you create your environment, use the VPC options on the eb create command.
2- You can mount an existing file system in the same VPC by removing the efs-create.config file from your the .ebextensions directory and adding the ID of your existing file system to efs-mount.config
option_settings:
  aws:elasticbeanstalk:application:environment:
    EFS_VOLUME_ID: '`{"Ref" : "FileSystem"}`'

Replace the ref with your file system ID like this:
option_settings:
  aws:elasticbeanstalk:application:environment:
    EFS_VOLUME_ID: fs-e7605f4e

Thanks,
-Michael

@mwunderl
1- Custom VPC will work as long as you configure your environment to launch instances in the custom VPC. **You can use a configuration file like this one when you create your environment**, _use the VPC options on the eb create command_.

Is that AND or an OR?
do i need to use that configuration file AND use the VPC options in eb create command or its ither OR?

@mwunderl
never mind
i just used the option available with eb create .. and it worked like a champ

Found this helpful. URL has moved if someone needs it: https://raw.githubusercontent.com/awslabs/elastic-beanstalk-docs/master/configuration-files/aws-provided/environment-configuration/vpc-custom-loadbalanced.config


Could you please provide the classifier used for training interfacegan directions?

Hi @yuval-alaluf ,thank you for the excellent work!
I am a student researching on interfacegan-like methods for face editing. I have trained my own 'age direction' and tried the one from anycostgan, neither of them produce baby faces as the age direction provided here. So I wonder what classifier you use for training the directions? Is it trained by yourself or is it the classifier from anycostgan ? Thank you!

If the age classifier is trained by yourself, please let me know how you trained it. Thank you!

We used the age classifier that I used in another one of my works (see the SAM repo here).
The age classifier is based on the DEX age classifier and fine-tuned on the FFHQ dataset. More details are provided in the SAM paper.
The classifier itself can be downloaded from the SAM paper.

Thank you for your reply!


defmt-test: Modify attributes in place and handle #[cfg]

Closes (?) https://github.com/knurling-rs/defmt/issues/381 (but doesn't add #[ignore] support)
This changes the defmt-test macro to retain the ItemFns and selectively delete defmt-test-specific attributes from them. The result is that the code is now simpler and arbitrary Rust attributes can be attached to tests. Doing so with #[ignore] gives the expected "unused attribute" warning.

bors r+


Bug #4 -- controls don't work

Describe the bug
I switched the div elements with JavaScript styles to images, but now the controls don't work.
To Reproduce
Steps to reproduce the behavior:

Go to '<IP_ADDRESS>/object/'
See error

Expected behavior
I expected the images to move around like the divs used to. This is the JS (here's the HTML).
/cc @elijahparker

It might be best just to wrap the img tag in a div, since img has less options than div.

I already tried that but I'll try again.

If I do that this is the result.
/cc @elijahparker

Same JS, different HTML (use the first links for JS and HTML).

Another option is to go back to just the div like you had before, but make the image the background image in css (and set the div to the right size for the image)

It didn't work. Now they are invisible.

Never mind. I need to specify the height too.

They just won't move still.

Specifying position: absolute; in the CSS worked! (c608ab1419ef89982638ee684fcadad8ef6bf31b).


AWS - Direct schedule handing

Handles cloudwatch events directly as scheduled events

Closing until we have a better versioning/release strategy between the CLI and membrane.


ttl time reflecting incorrectly in Jobs creation(rounds to previous hour instead of next hour)

I'm submitting a ...

bug report

Traffic Control components affected ...

Documentation
Traffic Ops

Current behavior:
As per the documentation,
These durations can be combined e.g. 2h45m specifies a TTL of two hours and forty-five minutes - however note that durations are always rounded up to the nearest hour so that e.g. 121m becomes three hours.
121m should round to the next hour(3) the end time should be 2021-10-09 06:52:11. But it rounds to the previous hour. (2) and the end time is 2021-10-09 05:52:11`
Expected behavior:
ttl hours should rounded up to the nearest hour.
Minimal reproduction of the problems with instructions:
POST /api/3.0/jobs
Host: trafficportal.infra.ciab.test
Content-Type: application/json
Transfer-Encoding: chunked

{
    "deliveryService": "testds1112",
    "assetUrl": "http://abc.test/.",
    "startTime": "2021-10-09 03:52:11",
    "regex": "/.",
    "ttl": "121m"
}

Response:
{"alerts": [{
	"text": "Invalidation request created for http://abc.test/.*, start:2021-10-09 03:52:11 +0000 UTC end 2021-10-09 05:52:11 +0000 UTC",
	"level": "success"
}]}

@dmohan001c - isn't 2021-10-09 03:52:11 + 121m = 2021-10-09 05:53:11?  not 2021-10-09 06:52:11 as you mentioned?

TTL is in hours only. Currently, he's saying 2021-10-09 03:52:11 + 121m = 2021-10-09 05:53:11 gets rounded down to 2021-10-09 05:52:11 but the docs say it should be rounding up, which would result in 2021-10-09 06:52:11

I see. ORT can only handle TTL in hours, therefore it is converted to hours. Did not know that....

@dmohan001c - isn't 2021-10-09 03:52:11 + 121m = 2021-10-09 05:53:11? not 2021-10-09 06:52:11 as you mentioned?

whatever @ocket8888  told is correct

I guess the current workaround is to define TTL in hours, not minutes and not hours and minutes....


[e2e]: container schedule main continue-on-error slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6515170306
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Trigger: schedule
Branch: main
Date: Sat Oct 14 03:06:03 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6521587853
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.schedule.main.continue-on-error.slsa3.yml
Trigger: schedule
Branch: main
Date: Sun Oct 15 03:02:09 UTC 2023
Tests are passing now. Closing this issue.


Comment removed between type name and =

pub type Export /*: Bound */ = S1;

This is one where I think a comment is justified; today we do not enforce such bounds (i.e. the compiler does not check that the right-hand side of a type definition actually conforms to such a bound), and the compiler actually errors if you try to include it (because we don't want people to mistakenly think that such bounds are enforced).
But the comment here serves a useful purpose (about the intent, that we intend for this type definition to conform to the bound).
Originally posted by @pnkfelix in https://github.com/rust-lang/rustfmt/issues/2781#issuecomment-629384358

For anyone interested in working on this, here are some of the relevant sections of the code:
rewrite_type
https://github.com/rust-lang/rustfmt/blob/2927e89b5194ecc887d61249eed9739ff1c3a3d5/src/formatting/items.rs#L1591-L1599
The dropping of the comment happens here on this line when the current formatting result is mashed together with the assignment operator. The individual elements of the item (the visibility, ident, generics, generic bounds, etc.) are formatted independently and then combined, but the comment is dropped because there's no checking for comments within the spans between. In this particular case that happens to be the span between the item's ident and the assignment operator, though more generally this would be the span between the assignment operator on the hi and the lo would be the end of the rightmost item element present
https://github.com/rust-lang/rustfmt/blob/2927e89b5194ecc887d61249eed9739ff1c3a3d5/src/formatting/items.rs#L1650
Note that the full span of the item can be found in the corresponding match arm in visitor.rs, which is needed for finding this between span before the assignment operator
https://github.com/rust-lang/rustfmt/blob/2927e89b5194ecc887d61249eed9739ff1c3a3d5/src/formatting/visitor.rs#L599-L611


Handle engines for pandas.read_excel

With the update to pandas 2.2.0 (Documentation) the read_excel function fails with the openpyxl engine.
Pandas have added a new engine calamine which can be up to 5x faster than openpyxl.
I think we should take that, but pandas versions smaller than that should also work with our programm
A possible solution would be checking the used pandas version and decide from that which engine to use.
`from distutils.version import LooseVersion
if LooseVersion(pd.__version) > LooseVersion(2.2.0):
    engine = 'calamine'
else:
    engine = 'openpyxl`

@mknaranja what's your opinion on that?

Sounds like a good solution.


Added Localization features.

Fixed closeup bug and added new tags.
Localization is now available.
Added spanish edition.

Now, no need to publish different forks with different languages.
Also, I have published your extension on Chrome Web Store here but if you want i will remove it https://chrome.google.com/webstore/detail/show-facebook-computer-vi/nngkfhekinofeclkcgddmdjgamakijjb

Where can I find the Zh-TW?

@hearsilent if you are talking about language then it can be added subsequently with this merge very easily.

I guess the usage of chrome.i18n will break Firefox Nightly support

Here is the Firefox i18n API : https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/i18n
I think you have to change chrome.i18n.getMessage() by browser.i18n.getMessage()

@ageitgey should i resolve conflicts because you are not responding to this PR.

I do not think i18n API is the correct way to do this, as browser locale needn’t match the Facebook one. Detecting the Facebook locale directly would be better.
As for the way to do it, I see Locale_en_GB as one of the classes of the body element, though I also have Facebook translations enabled so it might be artefact of that. Could anyone else verify it? Following snippet will look up the class:
Array.from(document.body.classList).find(cls => cls.match(/^Locale_/))

Also, TAG_PREFIX and separators should be considered.

@guillaume-ro-fr browser.i189n.getmessage() is not working in chrome.


Refs and the DOM

Translation of Refs and the DOM

#1

@rodynenko fix the recently requested changes please 👋

@klymenkoo, I have fixed requested changes.

@klymenkoo thanks for review


fix(tag):  the popup box is wrong position

…e is click

Types of changes

[ ] New feature
[x] Bug fix
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Performance improvement
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context

Solution

How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Tag
The popup box is in the wrong position when Tag and Popconfirm are used together
Tag 和  Popconfirm 组合使用的时候弹出框位置不对
Close: #436

Checklist:

[ ] Test suite passes (npm run test)
[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

Trigger onClick 方法里边的 e.preventDefault() 是不是只需要作用下 click 上, 需要你们在 review 下哈

针对 issue 里的场景可能可以， 但没法解决外部参数控制这个节点是否被渲染的场景吧

这个场景可以用别的组件来组合实现
所以这个 pr 意义不大
我关掉了🐶


bpf: egressgw: don't install allow-all policy in to-netdev tests

This was probably copy&pasted from the bpf_lxc tests. But to-netdev doesn't have any egress-policy hook, so we don't need to explicitly allow the test traffic.

/test


NavRail: finetune time travel handling

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

17 of 17 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 99.693%

Totals

Change from base Build<PHONE_NUMBER>0:
0.01%

Covered Lines:
13410

Relevant Lines:
13411

💛  - Coveralls


fix(jellyfish-crypto): explicitly convert uncompressed sub array into buffer

What this PR does / why we need it:
For some reason on other application builds (like LW), Keccak is throwing an error about the data type.
Which issue(s) does this PR fixes?:

Fixes DFC-182
Additional comments?:

Closing this PR as changes have been added to this PR: https://github.com/BirthdayResearch/jellyfishsdk/pull/2133


chore: update github actions for rn

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
[ ] Did you follow the contribution guidelines?

PR-Codex overview
This PR focuses on improving the build process for an account kit library by integrating Turbo for better task management and caching, particularly for Android builds. It updates scripts and configurations to enhance efficiency and streamline dependency management.
Detailed summary

Updated package.json to use yarn turbo run build:android.
Added caching for yarn dependencies in .github/actions/setup-node/action.yml.
Created a new turbo.json file for managing build tasks.
Removed redundant build:android and build:ios definitions from turbo.json.
Introduced a new GitHub Actions workflow for building Android with Turbo caching.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1144  👈
#1134
#1132
#1131
#1130
#1129
#1128
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


python312Packages.tencentcloud-sdk-python: 3.0.1265 -> 3.0.1266

Diff: https://github.com/TencentCloud/tencentcloud-sdk-python/compare/refs/tags/3.0.1265...3.0.1266
Changelog: https://github.com/TencentCloud/tencentcloud-sdk-python/blob/3.0.1266/CHANGELOG.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356123

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.tencentcloud-sdk-python
python311Packages.tencentcloud-sdk-python.dist
python312Packages.tencentcloud-sdk-python
python312Packages.tencentcloud-sdk-python.dist


Fix First() failure when $(BuildGraphOf) is set

still must build entire Universe locally before using $(BuildGraphOf)

@natemcmaster's more familiar with this code. Assigning it to him. Looks good to me though.

@dougbu what are the exact command line parameters you're trying to use? This fix suppresses an error, but I want to know what leads to it.

@natemcmaster .\build.cmd /p:CompileOnly=true /p:ShallowClone=true /p:BuildGraphOf=Mvc for example. I had edited Repositories.props before running that but had done nothing else.
The specific problem I'm working around is that GraphBuilder returns a graph missing most of what's in the Repositories collection in the case above. Actually, this happens in almost any case involving a non-empty $(BuildGraphOf) value.

3f8b319


Can not use mongo ObjectId.

I want to save my search result from mongo into Lokijs (as cache). My document uses the ObjectId, i.e. _id.  When I tried to find them with ObjectId('string') in Lokijs, I got the following error. But when I check my Lokijs data, I did see the ObjectId was stored there.
Unhandled rejection TypeError: fun is not a function
at Resultset.find (/Users/qiulang/Project/customer_service/node_modules/lokijs/src/lokijs.js:3205:19)
at LokiEventEmitter.Collection.findOne (/Users/qiulang/Project/customer_service/node_modules/lokijs/src/lokijs.js:5907:33)

Can you please post the query of the find method call?

        mongoDB.find('user').then(function(users){
            _.each(users,function(e){
                var data = e._doc;
                data.id = data._id.toString();// this is the kludge solution I used now
                lokiDB.insert(data);
            });
            var id = ObjectId("595c837597e60c5d2403a1f1");
            var result = lokiDB.findOne({id:"595c837597e60c5d2403a1f1"});
            //Then crash with the error
            result = lokiDB.findOne({_id:id});
        });

Can you tell me what console.log(typeof id) would log?

console.log(typeof id) of course shows "object" because ObjectId is bson object? What were you trying to find ?

so if your 'working' version you are passing string literal "595c837597e60c5d2403a1f1"?
and in your crashing version you are passing id var which is object?
can you extract convert the object instance to that string literal (possibly toString it like you did on insert) ?

I am reporting an issue (in my opinion) because I hope loki can support ObjectId. But I can't figure ou t your point here.

My only point was a simple but not obvious one (sorry was in a rush).  My point was just that comparing (different) object instances doesn't work with pure javascript :
var obj1 = { a:1, b:2 };
var obj2 = { a:1, b:2 };
console.log(a === b); // logs 'false'
console.log(a == b); // logs 'false'

So mongo object id are likely prototyped objects that override toString() to give you that simple, portable hex string.
So, will your objects ever find their way to mongo (where mongo will need them in expected format) and do you save your loki database or just use in-memory?
When lokijs serializes, it will do a JSON.stringify on your objects and when it reloads them, they will have lost their prototype unless you implement a custom inflater to recreate them properly.
If just in-memory, you might try :
result = lokiDB.findOne({ _id: { $aeq, id.toString() }});

So when you don't include an 'op' in your find objects, the implicit operation is $eq which in lokijs is 'strict' equality.  In the above i am using 'abstract equality op' which is similar to ==.  Since _id is prototyped object but id.toString() is type 'string', javascript should coerce _id to string and perform its abstract equality successfully.
If persistence is involved and you don't expect to pass back to mongo, you may want to query against properties on that object using dot notation so that it will work not only before you save but after as well. If you are going that route, i can provide more options.

I guess my complaint is more about the crash. If I don't use $aeq, no result is expected but the crash is not.

Yes, we might be able to provide a more meaningful error but object on right hand side of filter object expression usually means subexpression.  Maybe the object's 'constructor' property could be used.
Just out of curiosity, what is the value of :
console.log(data._id.constructor.name);

If it's a meaningful name we could possibly fallback to toString() in certain cases.

“ObjectID”  actually I am always confused the difference between ObjectId & ObjectID

It would seem there is none.  So the mongo-client driver requires the 'bson' npm package which defines ObjectID here.  Then it aliases ObjectId to it on line 69.  They also override both toString() and toJSON() methods to invoke and return toHexString() which gives your 24byte hex string.
So in loki you may insert a (mongo retrieved) doc which has _id field as a prototyped ObjectID class in memory, but when we save it the toJSON will convert it to 24 char hex string.   If you need to persist loki db and reinstance those properties as ObjectID you could use custom inflator and pass the hex string to ObjectID constructor.

I finally figured out the reason for the crash. It is because I use mongoose and the result is actually a mongoose object which caused the crash. When I use lean option to return the plain javascript object, no crash then (of course without $aeq, not result then).

Sorry my mistake, with the lean option, still crash. I planned to just delete mine previous comment. But maybe you have noticed it so I am adding this new comment


exclude linting from coverage

Testing if it works with Istanbul and Travis

Coverage remained the same at 89.128% when pulling 753dac19d46142dd72110f37ac405273157a282a on nebulon42:coverage into 13c5b8775146de5060ad28c23afff5cfa80b6e6e on mapbox:master.


Median of two sorted arrays

🚀 Feature
Median of two sorted arrays
Have you read the Contributing Guidelines on Pull Requests?
YES.
Motivation
Its a hard problem based on the data structure Arrays and involved a good understanding of algorithms as well.
Pitch
Its a hard problem based on the data structure Arrays and involved a good understanding of algorithms as well.

/assign


Add an Example for TaskFolder.DeleteTask Method

Please add an example for TaskFolder.DeleteTask Method.
TODO (optional): Describe a specific scenario you would like to see addressed.
Help Topic: https://dahall.github.io/TaskScheduler/html/M_Microsoft_Win32_TaskScheduler_TaskFolder_DeleteTask.htm

See wiki


Corrected github link

The link to your project on Github was wrong. (DoubleTopaz instead of TopazDouble)
The same is true for the file Aminet readme file "TopazDouble.readme" which is not on Github.

Thanks! Silly oversight :)

Thanks! Silly oversight :)


Tooling updates

@alexdor it works in localhost but the tests failed. Is that expected?

Netlify has cached the node_modules directory, that's why the test breaks. I don't have access to clear the cache, so I'm waiting for @bacharakis to do it


Flipper BFFB microSD [also GPS and BLE glichy] is not recognised/unavailable!

On the "Big F**king Flipper Board" is a microSD slot wich is currently not working/recognised with the Ghost ESP firmware. I tested this with a lot of different SD cards and also different formats but it still wont upload anything from the web ui. The GPS and BLE is also sadly glichy and wont work sometimes. I think this is caused because for the BFFB the only firmware is "esp_generic" so it would be great to have the BFFB officially supported. That would be pretty awesome because a lot of people got that thing and it has a lot of features combined. I also saw you guys are currently working on a wifi pineapple detector/deauther wich is pretty cool! Keep up the great work!

i do not have the BFFB to test with however if you would like to make changes / add support yourself considering this is open source feel free to make a PR with the code changes for review
If this changes in the future and i end up getting a BFFB i will reopen this issue


[$1000] Keyboard’s Caps button blink when textfield focus changed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open mobile app on iOS
navigate to settings > profile > display name
tap into First Name so that the keyboard pulls up
then tap into Last Name (keyboard should stay up)
tap between FN and LN a few times

Expected Result:
Keyboard shouldn’t blink when focus is changed. (Confirmed by testing that the keyboard doesn't blink when a similar action is taken on other iOS apps)
Actual Result:
Keyboard blinks when focus is changed.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native - iPhone 11  ( I was able to reproduce on my iPhone X once only)
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/228618900-e45e13bc-3a8e-4fc8-a915-de0f24f70e74.MP4
Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680036558448869
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ae90ccdfa2dded8a
Upwork Job ID:<PHONE_NUMBER>466801152
Last Price Increase: 2023-04-04

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

I can't reproduce with Browserstack, I think it's too slow to notice a blinking. I'm not seeing this behavior on my Android device. Seeing if someone with an ios device can help me test https://expensify.slack.com/archives/C01SKUP7QR0/p1680609850680069

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Current assignee @yuwenmemon is eligible for the External assigner, not assigning anyone new.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The caps lock indicator key on the soft keyboard rapidly blinks when switching between the First Name and Last Name text input fields on the page for editing a user's Display Name.
What is the root cause of that problem?
The soft keyboard state appears to be briefly reset while switching between the input fields. Due to the default keyboardType behaviour for text inputs in React Native, the Caps lock key is initially activated, because the text input just gained focus. However, once the system recognises that it's right after the first character in the text input, the Caps lock key is deactivated.
What changes do you think we should make in order to solve the problem?
Setting the keyboardType for the First Name and Last Name text inputs to name-phone-pad fixes the problem. I have tested and verified this to be working properly. Since the property is iOS only, it would not have an effect on the Android soft keyboard.
The changes will be in the file: https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/DisplayNamePage.js#L98-L115
Reference: https://reactnative.dev/docs/textinput#keyboardtype
What alternative solutions did you explore?
None.

@akinwale Thanks for the proposal.
Can you please help us understand your proposal.

Due to the default keyboardType behaviour for text inputs in React Native, the Caps lock key is initially activated, because the text input just gained focus.

It sounds reasonable but can you please include some reference for your above statement.

Setting the keyboardType for the First Name and Last Name text inputs to name-phone-pad fixes the problem.

What other behaviors will be different from existing keyboard? Will it still capitalize the first character?

@sobitneupane Thank you for your response.

It sounds reasonable but can you please include some reference for your above statement.
This is an educated guess based on the behaviour that I observed while testing. I don't have a reference for this. It certainly has to do with the capitalisation state after a text input gains focus.

What other behaviors will be different from existing keyboard? Will it still capitalize the first character?
The only behavioural change for this value based on the UIKit reference documentation is that it will not support auto-capitalisation.
Taking this into consideration, it will not capitalise the first character. However, instead of changing keyboardType to name-phone-pad, we can set the autoCapitalize property to words which equally solves the issue. Just tested and this will certainly prevent the caps lock from flickering. I will update my proposal to reflect this.

Thanks for the update @akinwale.
I like your proposal of using autoCapitalize="words". It solves the issue and it makes sense to autocapitalize each word of a name.
🎀👀🎀 C+ reviewed
cc: @yuwenmemon

@yuwenmemon
I have applied to the job on Upwork. I will have a PR ready within the next 30 minutes.

Wait, @sobitneupane what makes you think we want to support auto-capitalization? I don't think we want to neccesarily enforce this on a name field. For instance, many dutch names start with a lowercase letter (Sofie de Vreese is an example, who is an employee at Expensify). Apologies for not following the conversation closer but I would prefer @akinwale's original proposal, not the alternative solution.

@yuwenmemon With the original proposal, even the first character won't autocapitalize(Existing behavior is first character autocapitalize). If that' okay, we can go with the original proposal.

Ah, you're saying auto capitalized on the keyboard?

Ah, you're saying auto capitalized on the keyboard?

Yes.

Ah nevermind me, I had misunderstood! Approved!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.97-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17079

If no regressions arise, payment will be issued on 2023-04-17. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@sobitneupane / @yuwenmemon] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@sobitneupane / @yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@sobitneupane / @yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@sonialiap] Determine if we should create a regression test for this bug.
[ ] [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@sobitneupane @sonialiap @yuwenmemon Not sure who exactly to ping as this is my first issue, but is there anything left to do on this issue? Payment was due yesterday, but I haven't received payment yet nor have I been selected for the Upwork job.

Regression Test Proposal

Open the mobile app on iOS
Navigate to Settings > Profile > Display name
Tap into the First name field so that the soft keyboard pulls up
Tap into the Last name (keyboard should stay up)
Type some letters in First name field and Last name field
Switch between the First name and Last name fields by tapping repeatedly (at least 3 or more times) between the fields.
Verify that the Caps Lock indicator on the soft keyboard doesn't keep changing its state

Do we agree 👍 or 👎

Jumping in to help with payments while @sonialiap is OOO.
Assigned issue: Apr 7 3:28am (GMT+13)
PR merged: Apr 8th 6:44am (GMT+13)
This one qualifies for a speed bonus! I've sent contracts to @akinwale, @sobitneupane and @DinalJivani

@kadiealexander Accepted the offer.

@kadiealexander
Accepted the offer.

Thanks @kadiealexander for handling the payments while I was OOO!
@sobitneupane just one small change, since this test isn't about typing letters in the fields but about switching between them I suggest moving Type some letters in First name field and Last name field up in the step list, like so:

Open the mobile app on iOS
Navigate to Settings > Profile > Display name
Make sure both the First name and Last name fields have some characters entered
Tap into the First name field so that the soft keyboard pulls up
Tap into the Last name (keyboard should stay up)
Switch between the First name and Last name fields by tapping repeatedly (at least 3 or more times) between the fields.
Verify that the Caps Lock indicator on the soft keyboard doesn't keep changing its state

Regression test - https://github.com/Expensify/Expensify/issues/278021


Support Rack::Sendfile middleware

Hello.
I've added support of Rack::Sendfile middleware. Before this fix Rack::Sendfile does not apply strategy of adding X-Accel-Redirect (or X-Sendfile) header, because Grape returns simple Rack::Response which doesn't respond to to_path method. So I've implemented simple SendfileReponse class which responds to to_path.

Interesting. Lets start with these:

The test should use Rack::Sendfile, otherwise it's just expecting some contract to be fulfilled.
Fix build, add to CHANGELOG.

Hi! Sorry, for long response.
I wrote test spec/grape/middleware/formatter_spec.rb:286 because condition with Grape::Util::FileResponse wasn't covered. Additionaly, as I understood, I should write some integration test with using Rake::Sendfile middleware, right?

Yes, please and thank you @lfidnl. I am glad this gets cleaned up and tested.

@dblock, I've added test, update CHANGELOG and fix build. I hope, I done everything well :)

Tests are good. See my above note on README, squash commits please.

I think we must rewrite Grape's api for serving file like in Rails framework:
get '/file' do
  file '/path/to/file'
end

file method will create "file streamer" object and if Rack::Sendfile middleware turns on, it will works throurg middleware, otherwise it will stream file through Grape.
It will simplify using of Grape.
Lets close this pull request and create a new issue, or I'll try to provide propose with Pull Request.

:+1: on extending file to take a path

README updated

Merged, thanks.


Is "moment" & "moment.utc" is same?

In browser console of https://momentjs.com/, when I run moment().diff(moment.utc(), 'milliseconds'), I get 0 as output.
Does that mean moment() & moment.utc() is same? Or what is the actual difference?

@mudivili See https://momentjs.com/docs/#/parsing/utc/.

See the Please Read section of
https://momentjs.com/docs/#/parsing/


When changing note from recurring to not recurring the recurring data is not deleted

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports and didn't find any similar reports.

Expected Behavior
Should remove recurring data or set flag
Current behaviour
keeps the data about it being a recurring event. events dont get shown in the calendar. when selected again it says recurring data is set to the former value. The front matter data doesnt change at all.
JavaScript console output
No response
Steps to reproduce
make recurring event. change it not to be recurring. click on it again.
Calendar information
idk
Which Operating Systems are you using?

[ ] macOS
[ ] Windows
[X] Linux
[ ] Android
[ ] iOS

Obsidian Version
1.3.7
Full Calendar Plugin Version
0.10.7
Checks

[ ] I have tried it with all other plugins disabled and the error still occurs.

Possible solution
No response
Comments
No response

Experiencing this as well on Windows


Update mockito-scala-scalatest to 1.16.12

Updates org.mockito:mockito-scala-scalatest from 1.16.2 to 1.16.12.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mockito", artifactId = "mockito-scala-scalatest" } ]

labels: test-library-update, semver-patch

Superseded by #2056.

Superseded by #2056.


[Bug]Fuel slots for Auto crafter block doesn't work

Minecraft version & Mod Version:
1.12.2&1.12.2-1.14.6
Single player or Server:
Both
Describe problem (what you were doing / what happened):
Fuel slots for auto crafter block doesn't work:

Crash log (if any):
None

Should work in latest https://minecraft.curseforge.com/projects/cyclic/files/2550423


[Bug]: cannot start any of the Passkeys registrations when authenticating on behalf of a service user

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[X] I have joined the ZITADEL chat

Environment
ZITADEL Cloud
Version
v2.55.1
Database
PostgreSQL
Database Version
No response
Describe the problem caused by this bug
Similar to https://github.com/zitadel/zitadel/issues/7463 and discussed in https://discord.com/channels/927474939156643850/1206634195607363676/1252249863467438120.
When implementing a custom UI one needs to provide a UI for setting up MFA. Within the context of a custom UI we are in server-side code authenticating on behalf of the service user for all of our custom UI actions as per the Integrate docs. However, when trying to start an Passkey registration for a user via any of the registration APIs (e.g. http://ZITADEL_URL/v2beta/users/:userId/passkeys) the following error is returned alongside a 403 Forbidden status:
{
    "code": 7,
    "message": "Request user not equal to authenticated user (AUTH-Bohd2)",
    "details": [
        {
            "@type": "type.googleapis.com/zitadel.v1.ErrorDetail",
            "id": "AUTH-Bohd2",
            "message": "Request user not equal to authenticated user"
        }
    ]
}

What I'm expecting to happen: The request succeeds as I'm a service user with admin permissions.
To reproduce
Send a POST request to v2beta/users/:userId/passkeys with Bearer token belonging to an admin service user.
Screenshots
No response
Expected behavior
The request succeeds as I'm a service user with admin permissions.
Operating System
No response
Relevant Configuration
No response
Additional Context
No response

I dont know if your final user has an access token in this stage. however, you can use the authenticated user access token to realize this call, i had the same problem, and that way I solved it.

Douplicate of #7944 , including comments which solve the problem.
I will clsoe this issue, please refer to the other issue for a solution.


client override HTTP & TCP settings

Describe the feature request
I noticed there is some work going on to merge service destination rules with namespace level & global level destination rules, to solve default http & tcp setting problems. (#30066 Thanks!!) We also have a similar request that is to handle client side override of the settings.
If a service sets the connect timeout to be 200ms, by defining a destination rule in its own namespace, this may apply to most of its clients, but it is also quite common that some clients want to override this value. Currently, if a client wants to do so, it needs to define a destination rule for that service in the client namespace. However, since the client does not know how the service configures its subsets (also the subsets might be changing), the client can not configure the destination rule properly. For this, I think we can merge the destination rule defined in the client namespace with the destination rule defined in the server namespace similar to how we do the merge with global rule?
However, another problem is that, in most our use cases, the client only knows a virtual service hostname (it knows it’s calling foo.foo.svc.cluster.local). Virtual service foo might be backed by different destinations (foo.foo.svc.cluster.local virtual service routes to foo-1.foo.svc.cluster.local and foo-2.foo.svc.cluster.local real destinations) and the client does not need to know that. So in our case, it does not make sense for the client to override the settings in DestinationRule (it does not know the existence of the real destinations foo-1 & foo-2), instead we should allow the client to override it in VirtualService (with host foo.foo.svc.cluster.local). So in this reasoning, I think it makes more sense to consolidate the settings into virtual service. Thoughts?
Describe alternatives you've considered
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

tagging @GregHanson who is working on this area, what do you think?


Migrate API, Core and Test utils from TestNG to jUnit

There has already been a lot of discussion on this, so I decided it would be good for me to check out the branch, take a closer look at the code, and run the tests. I discovered that running tests individually does not work. My apologies if that has already been noted and if I just missed that. @ppalaga can you update the PR so that running tests individually works again?

Sorry for the inconvenience, yes it is on my TODO. I hope I'll be able to do it on Monday.

@jsanda, @tsegismont I simplified the Junit setup in 8ab70db , however, when running a single test from Eclipse, I am getting InvalidQueryException: Keyspace 'rhq' does not exist which probably has to do with src/main/script/schema.groovy that is run by maven but not by the IDE. Any ideas or other comments?

In MetricsTestUtils.getKeyspace, make the default rhqtest. That will be consistent with what the maven build uses and should resolve you problem.

@jsanda yes, thanks that helped. In b21a37a2aa1adbcf441411c17d6b67ab19ebaf37 I squashed all my commits together and rebased on top of the recent master. Any other comments?

Looks good to me. In another PR we can try to factor out the class rule code.

factor out the class rule code
@tsegismont what do you dislike about how it is now?

Le 07/01/2015 11:11, Peter Palaga a écrit :

factor out the class rule code
@tsegismont https://github.com/tsegismont what do you dislike about
how it is now?

Maybe it could be a bit shorter. It's fine as it is now. The purpose of
this PR was to move to jUnit. Maybe in another PR we can get close to
what Achilles provides (short rule definitions with a builder API).

@tsegismont OK, no problem with that (and I do not plan to be active).

I realize that the purpose of this PR was to move to JUnit. The code now looks very similar to what a TestNG solution would look like. To be honest, I am still concerned about whether or not JUnit provides feature parity with TestNG for things like grouping testing, dependent tests, and ordering tests. Maybe JUnit does, and I am just not aware. While the decision has been made (for reasons not entirely clear to me) to migrate to JUnit, maybe we need to revisit that decision if JUnit does not adequately provide features/functionality that are really useful for integration tests like these.

grouping testing, dependent tests, and ordering tests

@jsanda , do we need that?

migrate to JUnit, maybe we need to revisit that decision

<EMAIL_ADDRESS>is probably the proper place. It would be nice if the discussion is over (and this PR either rejected or merged) before the rename.

I'd like to merge this PR considering that there is a consensus on the junit way not being:

more/less verbose
easier/harder to understand

A junit/testng debate has no rational ending but I'm not entitled to close it.

Please do not merge this PR. I will send an email today to this dev list. The discussion in this PR has been insightful particularly that it has not convinced me that JUnit provides feature parity with TestNG for integration testing. If that turns out to be the case, then I want to push back on completely migrating to JUnit.

@jsanda  Please post your position on the dev list so that we can come closer to a resolution.

Hi Peter. Sorry for the delayed response. The number of integration tests is going to steadily increase, and I still have concerns about losing some of the functionality we become accustomed to using with TestNG. For now, I want to stick with TestNG for the integration tests.

@jsanda sorry I have missed your post last week. Could you please post a short summary of your TestNG pros and jUnit cons to hawkular-dev list? Preferring JUnit rather then TestNG is the present convention. It would be fair to revert it as transparently as possible, i.e. inform others and give them a chance to discuss.

Closing since this has been further discussed on the hawkular-dev mailing list.

OK, John, I am giving up with this particular PR. But would you please try to answer the questions I asked on the list? I am especially interested on your view on the status of jUnit in Metrics. Is it banned altogether?


Extend close nodes list by right amount

When a k-bucket does not contain enough close nodes, the
DHT will look into neighbouring k-buckets in order to entend
the list of returned nodes.
However, the list should not be extended beyond its maximum size.
Signed-off-by: Antonio Quartulli<EMAIL_ADDRESS>

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger

Added https://github.com/lbryio/lbry/commit/e89f3db31bb576dd3915fece38434279c8e2037b
This makes sure the result has at most min(count, k) items. Otherwise the length-checking logic could result in extension of the results for both the lower and higher buckets, whether or not enough results had already been found.


Amend typo, request.is() return null|fasle|string.

Modifying the test for null from == to === to make sure it must be null.

Current coverage is 100% (diff: 100%)

Merging #864 into v2.x will not change coverage

@@           v2.x   #864   diff @@
==================================
  Files         4      4
  Lines       418    418
  Methods      80     80
  Messages      0      0
  Branches    100    100
==================================
  Hits        418    418
  Misses        0      0
  Partials      0      0

Powered by Codecov. Last update e3ccdac...8c66146

+1


auro-icon: @latest call does not resolve to latest /icons repository

Describe the bug
After implementing the new elite and boarding icons, 404s were returned for this component.
https://github.com/AlaskaAirlines/auro-icon/blob/master/src/auro-icon.js#L114
seems to be the issue.
To Reproduce
Steps to reproduce the behavior:
Implement in-flight/boarding as an
Expected behavior
The icon renders
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: os x
Browser chrome
Version latest

Additional context
https://github.com/AlaskaAirlines/auro-icon/blob/master/src/auro-icon.js#L114 @latest appears to be broken here

@gusnaughton using the following code in the demo site

  <auro-icon category="in-flight" name="boarding"></auro-icon>

   <auro-icon category="in-flight" name="elite"></auro-icon>

I get ...

The SVGs are available.


Type-limits warnings when building for ARM32

Use case: Implementing Azure Blob Storage on IoT Edge with C++ on ARM32 device, which is now supported using other languages such as Python, Node.
Issue: Trying to build on a 32-bit platform results in warnings due to assumptions about char size (I realize this code hasn't been tested on 32-bit officially):
/app/azure-storage-cpplite/src/blob/blob_client_wrapper.cpp: In member function 'void azure::storage_lite::blob_client_wrapper::upload_file_to_blob(const string&, const string&, std::__cxx11::string, const std::vector<std::pair<std::__cxx11::basic_string, std::__cxx11::basic_string > >&, size_t)':
/app/azure-storage-cpplite/src/blob/blob_client_wrapper.cpp:421:25: error: comparison is always false due to limited range of data type [-Werror=type-limits]
if(fileSize > MAX_BLOB_SIZE)
^
/app/azure-storage-cpplite/src/blob/blob_client_wrapper.cpp:429:25: error: comparison is always false due to limited range of data type [-Werror=type-limits]
if(fileSize > (50000 * MIN_UPLOAD_CHUNK_SIZE))
^
cc1plus: all warnings being treated as errors

off_t is 32bit on ARM32, off64_t should work.
But I think off_t is part of POSIX standard, which our sdk should stay clear of, as a cross-platform project.
Anyway, blob_client_wrapper is not recommended to use, please use blob_client as possible as you can.

Thanks, I can avoid blob_client_wrapper. This is more clear with the new sample code added recently.
It looks like off_t does the right thing which is to restrict fileSize to the range of whatever system you're on. Defining the macros as long long is more the problem. If they were defined as long I think they should be interpreted as 32bit on a 32bit system and 64bit on a 64bit system. But then you couldn't hard code MAX_BLOB_SIZE...


allow lifetimes other than static

This pr adds support for non-static futures. I'd like some feedback about naming: Ideally we'd keep FfiFuture as the static variant for backwards compatibility and because it's probably more commonly used than the non-static variants

I can only imagine some API like fn write(s: *mut c_char) -> FfiFuture<'?, ()> may introduce lifetime bounds. But it's not easy to write correct bounds here, since the input lifetime is erased by pointer *mut. In such case, we still need to transmute out lifetime to make it 'static and carefully manage itt.

My use case for this is something like this:
extern "C" fn foo<'a>(bar: &'a Bar<'a>) -> FfiFuture<'a, Box<Quz<'a>>>;

(note that to the consumer of this api &Bar and Box<Quz> are just some opaque pointers, but I'd still like to use lifetimes to make the ownership and lifetime situation clear to me)
If I really wanted to I could transmute to 'static and back, but since using FfiFuture with non-static lifetimes can work just fine, I tried adding support for it.

BTW: StaticFfiFuture<T> is really not shorter than FfiFuture<'static, T>.

I'm not happy with the names, thats why I asked for feedback. Perhaps FfiFuture<T> and BorrowingFfiFuture<'a, T> are better?

Perhaps FfiFuture and BorrowingFfiFuture<'a, T> are better?

I prefer this. And we can have type FfiFuture<T> = BorrowingFfiFuture<'static, T>;.
Not sure if into_ffi would run into issue in this case.

Thanks!


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3932

Questions ?
Please refer to the Backport tool documentation


Incorrect accuracy for ImageNet pretrain model

In the documentation, it says resnet50 has the error rate of 23.85, that is, the accuracy of 76.15. However, after running the test script here, I get the accuracy of 76.13.
Other models are not tested. But obviously, there are inconsistencies here.

I've just re-run this model using the reference scripts and I indeed got the same results as you, 76.13. I've tried running with and without benchmark mode in cudnn, as well as without cudnn, and all gave the same result.
The question now is if this was a small typo when @colesbury added the numbers in https://github.com/pytorch/vision/pull/94, or if there are some small numerical differences between the implementation somewhere that affects the results?
cc @soumith

This has been fixed in https://github.com/pytorch/vision/pull/3360


Adding custom validators support

Hi,
My name is Lionel and I'm working at a french firm called Polyconseil. I found your yamale library the other day, and it is really well made. Yamale could be very useful for our new YAML configuration architecture. I took the liberty to make this pull request to add a feature we need : the ability to add some custom validators to the default yamale validators. I used a pretty simple "date" validator for testing purpose, but we have other custom format we would like to validate, which can not be added to the default validators because they are not so standard. I hope I'll have the opportunity to make some other PRs in the near future to help and improve this nice tool.
Kind Regards

Hey Lionel, I'm the creator/primary maintainer for this project. I'm on vacation right now, but I took a look at your changes and I like your approach. I'll be back in the office tomorrow and dig a little deeper. We use this library for several fundamental parts of our infrastructure so I have to be careful with any changes.
Cheers!

Hi blopker, no problem, there is no urgency on our side, we'll just use our fork for now ;-) Keep me up to date !

OK, I checked out your changes and moved some stuff around: https://github.com/23andMe/Yamale/commit/8110e6136bf7adc9f7718bf6b18e913d036dec08
The main change was to allow the TestCase class to use custom validators. Also, you should never use a mutable objects (lists, dicts) as a default args in Python. Unless you are doing some recursion tricks it usually ends up confusing you later :)

Thanks for the merge ! Good point on the mutable default, too, I concur :-) I hope to be able to contribute some more soon.


Update Reflex and Reflex-Chakra versions

This pull request updates the Reflex and Reflex Chakra dependencies to version 0.6.2 in the requirements.txt file. It also enhances the StepStatus component in the stepper.py file by adding descriptive comments for the active, complete, and incomplete properties. The tag attribute for StepStatus has been moved to the top of the class definition for consistency.

#25  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @elviskahoro and the rest of your teammates on  Graphite

It seems reflex-chakra is broken on reflex>=0.6.0 though, will need to put up a fix for that


MacOS version has been ported

Hello Canopas team,
I ported the code to MacOS/Appkit over the weekend, project is on the zip bellow:
rich-editor-swiftui-main-3.zip

On this code:
import Foundation

public class RichEditorState: ObservableObject {
    private var adapter: EditorAdapter = DefaultAdapter()

    @Published internal var editableText: NSMutableAttributedString

Xcode prints this, when trying to apply rich text:
Publishing changes from within view updates is not allowed, this will cause undefined behavior.
Then rich text doesn't get applied, and you need to click on underwrite and then it works.
Please let me know what you guys think, and if you could help solve this issue.
Next steps would be.

undo manager
Color
Font

Cheers

Nice work, can you create a PR @alelordelo ?

Not sure how to do PRs with projects that have local SPM packages….
but you can open the zip and push I guess?

On 12 Aug 2024, at 05:01, Faolain @.***> wrote:
Nice work, can you create a PR @alelordelo https://github.com/alelordelo ?
—
Reply to this email directly, view it on GitHub https://github.com/canopas/rich-editor-swiftui/issues/44#issuecomment-2283036118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHDNT7HNHZNLBYQNHTXHWLZRAQPFAVCNFSM6AAAAABMACCPSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTGAZTMMJRHA.
You are receiving this because you were mentioned.

We have ported macOS and other platforms as well with last PR