Change blacklisted -> denied for inclusivity

The word blacklist isn't a very inclusive term. I think that denylist is a much better term to use, and besides, it's more descriptive for what we're doing to the API key.
This PR involves a DB migration and also has everything to do with our authentication, so please give it a solid review. To run the migration locally, you should be able to run make migrate. Let me know if this doesn't work, because we'll want to fix that command. And of course, let me know if you run into any issues.
Testing:

Get your API key with the /apikey endpoint
Use the API key to successfully add a resource with POST /resources
Use the API key to successfully update a resource with PUT /resources
Deny your API key using docker-compose run resources-api flask apikey deny <email address> (can also pass in API key instead of email address)
Ensure you can't get your API key from the /apikey endpoint after it's been put on the denylist
Ensure you can't make a POST or PUT request to the /resources endpoint with your denied API key
Reactivate your API key using docker-compose run resources-api flask apikey reactivate <email address> (can also pass in API key instead of email address)
Get your API key again and make sure you're allowed to make POST requests again.

@jamesfitzer I can't add you as a reviewer until you accept the invite to collaborate, but would you mind also taking a look when you get a chance?

I’ve accepted twice now . Something isn’t working
Will look at this Monday
Get Outlook for iOShttps://aka.ms/o0ukef

From: Aaron Suarez<EMAIL_ADDRESS>Sent: Saturday, July 4, 2020 2:48:26 PM
To: OperationCode/resources_api<EMAIL_ADDRESS>Cc: James Fitzer<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [OperationCode/resources_api] Change blacklisted -> denied for inclusivity (#342)
@jamesfitzerhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjamesfitzer&data=04|01||8b15b8c775284d6225ba08d8205337f7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637294889273380872|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=d1xWrKKvuUJcMhhbpRydM7MMr67HlrSOGi0gvF%2FRFSI%3D&reserved=0 I can't add you as a reviewer until you accept the invite to collaborate, but would you mind also taking a look when you get a chance?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOperationCode%2Fresources_api%2Fpull%2F342%23issuecomment-653804330&data=04|01||8b15b8c775284d6225ba08d8205337f7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637294889273390868|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=hzX5EnxTFh799EbFigUUA%2Fum0bt%2B81PeAqauuOtG21o%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGB66UF3JUADQ4VNOMARDSTRZ6BQVANCNFSM4OQQ6WLA&data=04|01||8b15b8c775284d6225ba08d8205337f7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637294889273400871|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=uJLR76H6lvl05GfoSJbXFykcZ0vpaP0rJdXiuac6JXs%3D&reserved=0.

Ok should be good now

Reviews were dismissed because I had to rebase to get back up to date with main but the content of the PR is the same. Just need an approval and merge 👍


Severity is vague - please correct

I received an email from my customer today indicating the top of this page never defines which severity level is critical.   0 or 4?     I found other blogs that show 0 is Critical.    Can we just say that here.   Map them all 0,1,2,3,4.
Sev 0 = Critical
Sev 1 = Error
Sev 2 = Warning
Sev 3 = Informational
Sev 4 = Verbose

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3eff5cd-b885-2e94-2ea6-3f60154123df
Version Independent ID: ec1862a7-fa36-1ac4-fe68-011ed39c16f3
Content: Overview of alerting and notification monitoring in Azure
Content Source: articles/azure-monitor/platform/alerts-overview.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @rboucher
Microsoft Alias: robb

@stdistef Thanks for the comment. We are actively investigating on the issue and will get back to you shortly with an update.

@stdistef Verified and updated document as required. Thanks.


repeat expt 1 using pre-trained models from Geirhos et al 2019

to test whether result holds even when models are optimized for shape bias over textural bias
https://github.com/rgeirhos/texture-vs-shape

specifically alexnet + VGG16 models.
Will need to add functionality to searchnets to load checkpoints


Add a note about using the collection in addLayer

see discussion in #3681

Sounds good to me.

Great! /cc @probins


Database throws exception on error

Option to throw exception insted print the error

In addition to #4189, display_error() is only used when 'db_debug' is enabled.


Creating a forced download link

This might be a super basic question but it's late and I'm stumped. I'm using Refile to serve up audio files uploaded by musicians:
class Song < ActiveRecord::Base
  attachment :audio_file
end

I'm also storing the _filename _size _content_type rows in my songs table
I want to create a link so that when someone clicks it, it automatically downloads. Currently, I can get it to open streaming via attachment_url, but not the equivalent of "save target as". I'm not sure how to serve this out from the controller in a send_file, either.
#View
  <%= link_to "download", attachment_url(song, :audio_file, filename: song.audio_file_filename)%>  #opens up an mp3 player
  <%= link_to "controller download ", user_album_song_download_path(current_user, @album, song) %>

#controller - not sure what to do here, either
  def download
    send_file Refile.attachment_url(@song, :audio_file), type: @song.audio_file_content_type, disposition: :attachment
  end

Where am I going wrong, and is this in the documentation anywhere?

It seems wise to make the disposition :inline by default but make it an option we can pass in to the Sinatra app.
https://github.com/elabs/refile/blob/master/lib/refile/app.rb#L99

:+1:  your branch is working! thanks @excid3

Hey all, just checking in on this issue. I just saw #119 and @jnicklas' comment on it. Is anyone already working on this? I'd be happy to tackle it if @jnicklas is happy with that solution, or has another in mind.

When I try to do the same I received the message "
ActionController::MissingFile at /attachments/download
Cannot read file http://<IP_ADDRESS>:3000/attachments/5766873402ffbc33fba841ec36eed1bd399b4641/store/d7f124d05a7abf06ae40cf43d317f6dff8c6417dd80d0896f1e98f055990/200x200tmdg.jpg"
but If I open that URL in a new tab I can see the file

Finally I resolved it... in this way...
file = Refile.store.get(@attachment.profile_image_id).download
send_file file, filename: @attachment.profile_image_filename, type: @attachment.profile_image_content_type, disposition: :attachment

@matiasmasca thanks - your solution worked well for me! :+1:

@matiasmasca, Trying to understand how to provide direct download links with latest refile version. Is this still applicable? Can you maybe expand your solution to help us less developed learners?

Is the recommended workaround still to send the file in a custom controller action?

Closed by #561.


sortedTokenBytes doesn't seem necessary

Thank you for your efforts. I found that in the NewCoreBPE function, the result of the following code does not seem to be used anywhere,
        sortedTokenBytes := make([][]byte, 0, len(encoder))
	for k := range encoder {
		sortedTokenBytes = append(sortedTokenBytes, []byte(k))
	}
	sort.Slice(sortedTokenBytes, func(i, j int) bool {
		return bytes.Compare(sortedTokenBytes[i], sortedTokenBytes[j]) < 0
	})

	return &CoreBPE{
		......
		sortedTokenBytes:     sortedTokenBytes,
	}, nil

but this sorting operation seems to be very expensive. Is there any consideration here?

Yes, this code currently is not necessary.
This variable is mainly used when multi-threaded encoding is needed, but this feature has not been implemented yet.


Windows 10 support

Suggested new feature or improvement
Complete the needed work for Windows 10 support.
Namely coverage on the upgrade Windows 10 to 11 scenario
Scenario
No response
Additional details
No response

There is some information on this in #905


What is the best practice to handle capitalisation across different languages?

Hi, maintainers of this library, currently I am doing something like
function capitalize(s) {
  return s.charAt(0).toLocaleUpperCase() + s.slice(1);
}

I18n.t('createSuccessful', {
   subject: capitalize(${I18n.t('resource')}),
})

The translation file looks something like this
{
   "createSuccessful": "{{subject}} created successfully",
   "resource": "resource"
}

I am wonder if it is language safe to do something like this?
Is there a prescribed way to handle capitalisation using this library?

Capitalisation is language specific (e.g. English has it, Chinese and Japanese don't have it)
So I really have no idea how to perform capitalisation "safely"
This library won't include capitalisation function since it's a bit out of scope


Output class names in original casing rather than lowercased

See #42 for output example

Fixed in https://github.com/etsy/phan/commit/16b54d01217e19965eb293b455d5df1ccacb2c46


Error with gradle 4.4 and Android Studio 3.1

Very good library, but when upgrading to gradle 4.4 with android studio 3.1, the project stops compiling with an error which says as follows:
Cannot create variant 'android-lint' after configuration ':nexusdialog:debugRuntimeElements' has been resolved
Please Help

Fixed in f43a6a0794


Add check to seekTo so that the time is among loadedTimeRanges

Previously if seekTo was called before the time in question was loaded, this broke the player so that the playableDuration and the currentTime were wrong in onProgress event. Also, if seekTo was called again, this didn't do anything.
This commit fixes this by making sure the time is among loadedTimeRanges. If not, onSeek callback is called with success: false.
Additionally, success parameter is also added to succeeding onSeek callback.

Guys, any chance of having this merged? Or is there a problem with this?

@alizbazar
Thank you for the detailed write-up. Looking at the code in detail, it doesn't feel like the right approach. My understanding is that loadedTimeRanges contains the portions of the video that are buffered. By checking against that, you're only verifying whether the position you want to seek to is buffered, not whether it's seekable. Any position within the seekableDuration should be seekable regardless of if it's buffered - if you seek to it, it will begin buffering then play.
Perhaps there is some other issue at play here. What do I need to do reproduce the issue you are encountering? I tried both streaming and large local videos and the whole video was seekable without issue, so I'm not able to troubleshoot and investigate this.

@alizbazar I'm going to close this for the reasons shown above. If the issue with the currentTime and playableDuration still exist, please provide an example and I'll look into it.


Edit Module and FunctionalComponent in web interface

One should be able to add, delete, and edit Module and FunctionalComponent members of a ModuleDefinition, in order to do things like define and correct a media recipe or the design of a sample.

im gonna disagree with the premise of this one. synbiohub isn't the place to do this. but will keep it open for sbh3 to return to if we want this capability


Strange bug

Hi!
Every method has such error:
Generated IL:
Action of type Cpp2IL.Core.Analysis.Actions.ARM64.Arm64ReturnAction at (0xAC1620) is corrupt (Return value has a type of System.Int64, expecting an object of type Shared.Entities.InventoryItem) and cannot be created as IL. Aborting here.
and in generated dll only 'return null' on every method.
https://anonfiles.com/t0b8b637y1/test_zip

I doubt every single method has the same issue, and regardless, Arm64 support is still very limited. The return null thing is probably down to you not enabling saving of generated IL to the DLL file as described in the readme.


pointsample

When compare the predition_mask with gt_mask, i find you used the pointsample() to align their size, do you think it harms the learning performance? Have you ever tried other methods or the pointsample() is always used for detr's-like model?

Sorry, we didn't ablate its neceesarity. However, you can refer to the original mask2former paper, it seems the pointsample would not downgrade the performance.

oh! Well! Thanks!


feat: \dddot and \ddddot support

What is the previous behavior before this PR?
\dddot and \dddot were not supported, and requested in #2744
What is the new behavior after this PR?
Fixes #2744, though italic correction is off.  Example:
x+\dddot x + \ddddot y + y

KaTeX rendering:

LaTeX rendering:

It looks much worse for a letter A.
Also missing are tests. Is this worth a screenshot test? Maybe, for texcmp purposes?

I think the rendering is about as good as we can expect to get.
The PR needs documentation updates. For the accent table in supported.md, I suggest modifying the bottom few rows as follows:
|$\dot{a}$ `\dot{a}` |$\overleftrightarrow{AB}$ `\overleftrightarrow{AB}`  |$\overbrace{AB}$ `\overbrace{AB}`
|$\ddot{a}$ `\ddot{a}`  |$\underleftrightarrow{AB}$ `\underleftrightarrow{AB}`|$\underbrace{AB}$ `\underbrace{AB}`
|$\dddot{a}$ `\dddot{a}`|$\overline{AB}$ `\overline{AB}` |$\overlinesegment{AB}$ `\overlinesegment{AB}`
|$\ddddot{a}$ `\ddddot{a}`|$\underline{AB}$ `\underline{AB}`  |$\underlinesegment{AB}$ `\underlinesegment{AB}`
|$\grave{a}$ `\grave{a}`|$\widecheck{ac}$ `\widecheck{ac}`  |$\underbar{X}$ `\underbar{X}`
|$\hat{\theta}$ `\hat{\theta}`|$\widehat{ac}$ `\widehat{ac}`||

support_table.md should also be updated. It's pretty straightforward.
With those qualifications, I am ready to (belatedly) approve this.


feat: #30 - WIP add config commands

closes #30

Added the shape of the cog, but none of the actual implementation yet.


Uncomment HTML challange is no working

Challenge Uncomment HTML has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

Hello World

CatPhotoApp

Hello Paragraph

-->

@Mariocard
Thanks for reporting this. But your code is incorrect.
GitHub Issues are for reporting bugs on the website only.
Please use the Help chat room for getting challenge related help.
Happy Coding!


Get rid of Windows vmci_client build warnings

The Windows cl compiler leaves the following log while building the vmci_client DLL using the common Linux/Windows C code. It'd be good to get rid of the same.
vmci_client.c(143): warning C4133: 'function': incompatible types - from 'FILE *' to 'const char *const '
vmci_client.c(227): warning C4133: 'function': incompatible types - from 'uint32_t *' to 'const char *'
vmci_client.c(233): warning C4133: 'function': incompatible types - from 'uint32_t *' to 'const char *'
vmci_client.c(248): warning C4133: 'function': incompatible types - from 'uint32_t *' to 'char *'
vmci_client.c(262): warning C4133: 'function': incompatible types - from 'uint32_t *' to 'char *'
vmci_client.c(251): warning C4477: 'snprintf' : format string '%d' requires an argument of type 'int', but variadic argument 2 has type 'std::size_t'
vmci_client.c(251): note: consider using '%zd' in the format string

/cc @pshahzeb

This is neither correctness, nor customer facing.

This is neither correctness, nor customer facing.

Agree!


Work around FStarLang/FStar#1651

If you are running with OTHERFLAGS="--admit_smt_queries true", F* will still record empty hints, a known issue. This attempts to work around it to limit the amount of frustration related to hint churn, the need to reset and checkout hints when pulling, etc.

I have an F* PR fixing 1651: https://github.com/FStarLang/FStar/pull/1944

Better wait until @aseemr FStar PR is merged?

Ah great, thanks Aseem! This renders this PR moot.

I will merge that PR once things have settled a bit on Everest, and Nik and Guido had a chance to look at the changes, thanks!


nuxt/i18n + sidease/nuxt-auth wipes out all types from the config file

Environment

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, auth, modules, runtimeConfig
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-js6xqk?file=composables%2FuseThing.ts
Describe the bug
Bear with me for this one, I'm not sure which module is to blame here, but the combo of these two modules removes all type definitions from the runtime config.
You can see, in the composable, that .foo is no longer typed when both modules are enabled.
When I disable either of these modules, types generate correctly.
Bug report on sidebase/nuxt-auth: https://github.com/sidebase/nuxt-auth/issues/737
Additional context
No response
Logs
No response

Downgrading i18n to 8.1.1 fixes the issue, so I'm fairly sure the problem is with this module.
I'l lsee which version exactly introduced the issue, probably 8.3.0

It's unclear why downgrading to an older version works, I haven't tested this or looked into that. It seems like the types break due the nuxt-auth module not augmenting the runtime config types in the same way as we do, I've opened https://github.com/sidebase/nuxt-auth/pull/738 that will resolve this on their end.
We can keep this issue open in case other users experience the same thing and close it when the PR has been merged and released.

Thanks Bobbie I appreciate it!

Closing this issue as https://github.com/sidebase/nuxt-auth/pull/738 has been merged and included in   https://github.com/sidebase/nuxt-auth/releases/tag/0.8.0-alpha.1!


Unicode escapes only accept upper case hex digits

For the input:
foo = " \uf04b "

I was receiving a puzzling error:
invalid hex escape character in string: `f`

TOML is specified as ABNF:
escape-seq-char =/ %x75 4HEXDIG ; uXXXX                U+XXXX
escape-seq-char =/ %x55 8HEXDIG ; UXXXXXXXX            U+XXXXXXXX

HEXDIG = DIGIT / "A" / "B" / "C" / "D" / "E" / "F"

According to RFC 5234:

ABNF strings are case insensitive and the character set for these
 strings is US-ASCII.

Hence:
    rulename = "abc"

and:
    rulename = "aBc"

will match "abc", "Abc", "aBc", "abC", "ABc", "aBC", "AbC", and
"ABC".

So, \uf04b and \uF04B really should mean the same thing.

Want to send a PR to the upstream ABNF?

IMO, the upstream ABNF is totally fine, the implementation here is just wrong. "A" in ABNF means 'a' or 'A'.

Er oops sorry, yes indeed! In that case a PR sounds great!


Start dataset download with datalad and github action integration

Rewrite test using datlad to retrieve files from gin
use github actions that replace circleci (test neo.io)
use pytest

Hello @samuelgarcia! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file neo/test/rawiotest/common_rawio_test.py:

Line 24:1: E265 block comment should start with '# '
Line 25:36: E114 indentation is not a multiple of four (comment)
Line 25:36: E116 unexpected indentation (comment)
Line 25:36: E265 block comment should start with '# '
Line 34:1: E265 block comment should start with '# '
Line 52:1: W293 blank line contains whitespace
Line 63:1: W293 blank line contains whitespace
Line 67:9: E265 block comment should start with '# '
Line 68:9: E265 block comment should start with '# '
Line 70:5: E265 block comment should start with '# '
Line 71:9: E265 block comment should start with '# '
Line 72:9: E265 block comment should start with '# '
Line 74:9: E265 block comment should start with '# '
Line 75:9: E265 block comment should start with '# '
Line 76:9: E265 block comment should start with '# '
Line 77:9: E265 block comment should start with '# '
Line 79:5: E265 block comment should start with '# '
Line 80:9: E265 block comment should start with '# '
Line 81:9: E265 block comment should start with '# '
Line 82:9: E265 block comment should start with '# '
Line 84:9: E265 block comment should start with '# '
Line 86:9: E265 block comment should start with '# '
Line 87:13: E265 block comment should start with '# '
Line 89:9: E265 block comment should start with '# '
Line 90:9: E265 block comment should start with '# '
Line 91:13: E265 block comment should start with '# '
Line 92:13: E265 block comment should start with '# '
Line 93:32: E114 indentation is not a multiple of four (comment)
Line 93:32: E116 unexpected indentation (comment)
Line 93:32: E265 block comment should start with '# '
Line 94:9: E265 block comment should start with '# '
Line 95:13: E265 block comment should start with '# '
Line 97:5: E265 block comment should start with '# '
Line 99:5: E265 block comment should start with '# '
Line 100:9: E265 block comment should start with '# '
Line 101:9: E265 block comment should start with '# '
Line 102:9: E265 block comment should start with '# '
Line 103:9: E265 block comment should start with '# '
Line 105:5: E265 block comment should start with '# '
Line 106:9: E265 block comment should start with '# '
Line 107:9: E265 block comment should start with '# '
Line 108:9: E265 block comment should start with '# '
Line 109:9: E265 block comment should start with '# '
Line 110:1: W293 blank line contains whitespace
Line 113:1: W293 blank line contains whitespace
Line 120:1: W293 blank line contains whitespace
Line 130:100: E501 line too long (118 > 99 characters)

In the file neo/test/rawiotest/test_blackrockrawio.py:

Line 31:9: E116 unexpected indentation (comment)
Line 31:9: E265 block comment should start with '# '
Line 32:9: E116 unexpected indentation (comment)
Line 32:9: E265 block comment should start with '# '
Line 33:9: E116 unexpected indentation (comment)
Line 33:9: E265 block comment should start with '# '
Line 34:9: E116 unexpected indentation (comment)
Line 34:9: E265 block comment should start with '# '
Line 35:9: E116 unexpected indentation (comment)
Line 35:9: E265 block comment should start with '# '
Line 36:9: E116 unexpected indentation (comment)
Line 36:9: E265 block comment should start with '# '
Line 37:9: E116 unexpected indentation (comment)
Line 37:9: E265 block comment should start with '# '
Line 38:9: E116 unexpected indentation (comment)
Line 38:9: E265 block comment should start with '# '
Line 39:9: E116 unexpected indentation (comment)
Line 39:9: E265 block comment should start with '# '
Line 40:9: E116 unexpected indentation (comment)
Line 40:9: E265 block comment should start with '# '

In the file neo/test/rawiotest/tools.py:

Line 25:1: E265 block comment should start with '# '
Line 26:5: E265 block comment should start with '# '
Line 27:5: E265 block comment should start with '# '
Line 28:5: E265 block comment should start with '# '
Line 29:5: E265 block comment should start with '# '
Line 30:5: E265 block comment should start with '# '
Line 31:9: E116 unexpected indentation (comment)
Line 31:9: E265 block comment should start with '# '
Line 32:13: E116 unexpected indentation (comment)
Line 32:13: E265 block comment should start with '# '
Line 33:9: E116 unexpected indentation (comment)
Line 33:9: E265 block comment should start with '# '
Line 35:5: E265 block comment should start with '# '
Line 36:5: E265 block comment should start with '# '
Line 37:9: E116 unexpected indentation (comment)
Line 37:9: E265 block comment should start with '# '
Line 38:13: E116 unexpected indentation (comment)
Line 38:13: E265 block comment should start with '# '
Line 39:9: E116 unexpected indentation (comment)
Line 39:9: E265 block comment should start with '# '
Line 42:1: E265 block comment should start with '# '
Line 43:5: E265 block comment should start with '# '
Line 44:5: E265 block comment should start with '# '
Line 46:5: E265 block comment should start with '# '
Line 48:5: E265 block comment should start with '# '
Line 50:5: E265 block comment should start with '# '
Line 51:5: E265 block comment should start with '# '
Line 52:5: E265 block comment should start with '# '
Line 53:5: E265 block comment should start with '# '
Line 54:9: E116 unexpected indentation (comment)
Line 54:9: E265 block comment should start with '# '
Line 55:13: E116 unexpected indentation (comment)
Line 55:13: E265 block comment should start with '# '
Line 56:9: E116 unexpected indentation (comment)
Line 56:9: E265 block comment should start with '# '
Line 58:5: E265 block comment should start with '# '
Line 59:5: E265 block comment should start with '# '
Line 61:5: E265 block comment should start with '# '
Line 62:9: E116 unexpected indentation (comment)
Line 62:9: E265 block comment should start with '# '
Line 63:9: E116 unexpected indentation (comment)
Line 63:9: E265 block comment should start with '# '
Line 64:9: E116 unexpected indentation (comment)
Line 64:9: E265 block comment should start with '# '
Line 65:13: E116 unexpected indentation (comment)
Line 65:13: E265 block comment should start with '# '
Line 68:1: E265 block comment should start with '# '
Line 69:5: E265 block comment should start with '# '
Line 70:5: E265 block comment should start with '# '
Line 72:5: E265 block comment should start with '# '
Line 73:5: E265 block comment should start with '# '
Line 74:5: E265 block comment should start with '# '
Line 75:5: E265 block comment should start with '# '
Line 76:5: E265 block comment should start with '# '
Line 77:5: E265 block comment should start with '# '
Line 78:9: E116 unexpected indentation (comment)
Line 78:9: E265 block comment should start with '# '
Line 79:34: E114 indentation is not a multiple of four (comment)
Line 79:34: E116 unexpected indentation (comment)
Line 79:34: E265 block comment should start with '# '
Line 81:5: E265 block comment should start with '# '
Line 82:9: E116 unexpected indentation (comment)
Line 82:9: E265 block comment should start with '# '
Line 83:5: E265 block comment should start with '# '
Line 84:5: E265 block comment should start with '# '
Line 85:9: E116 unexpected indentation (comment)
Line 85:9: E265 block comment should start with '# '
Line 86:5: E265 block comment should start with '# '

In the file neo/test/utils/test_datasets.py:

Line 5:1: E302 expected 2 blank lines, found 1
Line 8:17: E126 continuation line over-indented for hanging indent

In the file neo/utils/__init__.py:

Line 8:70: W292 no newline at end of file

In the file neo/utils/datasets.py:

Line 10:1: E722 do not use bare 'except'
Line 21:1: E302 expected 2 blank lines, found 1
Line 25:1: E302 expected 2 blank lines, found 1
Line 28:1: W293 blank line contains whitespace
Line 31:1: W293 blank line contains whitespace
Line 33:1: W293 blank line contains whitespace
Line 38:1: W293 blank line contains whitespace
Line 58:1: W293 blank line contains whitespace
Line 68:100: E501 line too long (122 > 99 characters)
Line 75:1: W293 blank line contains whitespace
Line 81:1: W391 blank line at end of file


DateTimeValidator: Parameter to discard milli-/microseconds

The DateTimeValidator accepts times with milli- and microseconds (e.g. 2021-12-31T12:34:56.123456).
There should be an optional boolean parameter discard_milliseconds (defaults to False) to discard them. This would mean that the validator still would accept the same input strings, but the resulting datetime would always have microseconds=0 if the option is set.
Implementation would be pretty easy: If set, apply .replace(microseconds=0) to the output datetime.
Parameter name
I would opt for discard_milliseconds rather than discard_microseconds even though datetimes only have a microseconds attribute (e.g. "12:34:56.123" would result in a datetime with microseconds=123000). I think naming the parameter discard_milliseconds is still more intuitive, because discard_microseconds could imply that it ONLY discards actual microseconds and leaves whole milliseconds intact.
Other parameters
There could of course be more options, e.g. discarding only the microseconds, or even discarding full seconds. I would argue that these would be rare special cases, though, which can easily be implemented by the user with a derived DateTimeValidator if needed. So I'd leave it with the discard_milliseconds option.
Breaking changes
As long as the default for this option is False, there will be no breaking changes.

Solved in #79.


repo: Release 1.23.1

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest

/retest

When will this make it into DockerHub? I just tried running:
amd64 Host
$ docker run --rm -it docker.io/envoyproxy/envoy:v1.23.1
Unable to find image 'envoyproxy/envoy:v1.23.1' locally
docker: Error response from daemon: manifest for envoyproxy/envoy:v1.23.1 not found: manifest unknown: manifest unknown.
See 'docker run --help'.

I guess this is expected.
arm64 Host
$ uname -a
Linux arm64-oracle 5.15.0-1016-oracle #20-Ubuntu SMP Mon Aug 8 07:08:08 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
$ docker run --rm -it docker.io/envoyproxy/envoy:v1.23.0
/docker-entrypoint.sh: 29: exec: su-exec: Exec format error
$ docker run --rm -it docker.io/envoyproxy/envoy:v1.23.
Unable to find image 'envoyproxy/envoy:v1.23.1' locally
docker: Error response from daemon: manifest for envoyproxy/envoy:v1.23.1 not found: manifest unknown: manifest unknown.
See 'docker run --help'.

its published now

Thanks.


Having trouble with authorization flow [windows]

I'm trying to reproduce some of the functions I have working on MacOS, but I'm getting the following error:
[2023-09-07T22:35:01Z WARN  rust_tdlib::client::worker] error received and possibly cannot be handled because of empty state receiver for client 1: Error { extra: Some("9317c4f9-99e0-499f-98e4-7eb076969d4f"), client_id: Some(1), code: 400, message: "Valid api_id must be provided. Can be obtained at https://my.telegram.org" }

Seems like the tdlib_params aren't being set properly, because when I set the verbosity level to 3, I see the following tdlib_params being sent:
[ 3][t 5][1694126101.514971256][Td.cpp:2966][#1][!Td][&td_requests]     Receive request 2: setTdlibParameters {
  use_test_dc = false
  database_directory = ""
  files_directory = ""
  database_encryption_key = bytes [0] { }
  use_file_database = false
  use_chat_info_database = false
  use_message_database = false
  use_secret_chats = false
  api_id = 0
  api_hash = ""
  system_language_code = ""
  device_model = ""
  system_version = ""
  application_version = ""
  enable_storage_optimizer = false
  ignore_file_names = false
}

Here's the code I'm using (essentially the same as on docs.rs):
    let mut worker = Worker::builder().build().unwrap();
    let waiter = worker.start();
    let tdlib_params = TdlibParameters::builder().api_id(var("API_ID").unwrap().parse::<i32>().unwrap()).api_hash(var("API_HASH").unwrap()).build();
    let client = rust_tdlib::client::Client::builder().with_tdlib_parameters(tdlib_params).build().unwrap();

    log::info!("Client {:#?}", client);

    log::info!("Worker {:#?}", worker);

    let client = worker.bind_client(client).await.unwrap();
    let me = client.get_me(GetMe::builder().build()).await.unwrap();
    println!("{:?}", me);

I've checked that the environmental variables are set and retrieved correctly.

Perhaps it's an issue with my build of tdlib?
[ 3][t 5][1694126101.512905836][Td.cpp:4060][#1][!Td][&td_requests]     Sending update: updateOption {
  name = "version"
  value = optionValueString {
    value = "1.8.17"
  }
}

I'm not familiar with windows development. What if instead of passing it from environment variables you try to specify those parameters explicitly hardcoded in your code?

Just tried it hard-coded. Same issue.
Looks like others have fixed it in the Python version by reverting it to 1.8.0?
https://github.com/tdlib/td/issues/2285

I'd say yes the reason is that. Especially because the lib currently supports only 1.8.0 :)
I can provide support for a newer one, but I'm on vacation now and this is the first time in my life when I'm on vacation without laptop))
So I can dive into it not earlier than in a couple of weeks

Hey hey, no rush! Hopefully reverting the build will help!
I'll update this issue if it works!
Thanks as always for your speedy responses!

Works when I build the 1.8.0 version of TDLib!
Closing!


build: latest a5

v11.2.4 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


Provisioning VMs onto PVE platform for building k8s cluster

Summary
Provide an overview...
Description
Add more context to describe the changes
Details

[ ] some project details

References

Link #

Checks

[ ] Already tested changes in staging environment

Notes

Some awesome notes

I will be introducing pre-commit in a second


Add new samples isbn-image-format and number-piechart

Q
A

Bug fix?
no

New sample?
yes

Related issues?

What's in this Pull Request?
Add new samples: isbn-image-format and number-piechart.

Great work on these, thx Aaron.


Add prompt for device ID in tests [#359]

Prefers the env var; prompts if it doesn't exist.
Allows 'mac' to be given to use Mobileclient.FROM_MAC_ADDRESS.

looks good to me. thanks!


feat: apply react-toast

react-toast
react toast is a pattern that provides users with brief, fleeting messages about status and events in a system or application.
why use React toast

user experience
accessibility

"A concise and intuitive way to communicate about application status and interactions."

Hey, I would love to add it

@imjaglan  hi! Would you like to contribute to the project?

Yeah

Wow great! The places where react-toast is needed in this project are the post writing page and post editing page.
Currently, when a user writes or edits a post, the page is just moved.
At this time, simply displaying a success message will help UX.
If you think there are more places where react-toast is needed, please let me know. @imjaglan

Do i have to setup the backend ass well?, I've added all the env's but there app is not working properly. I've created the ToastProvider component if you can tell me the location of the file i can even add it directly.

The backend is a bit complicated to set up. Therefore, it is recommended to use a proxy.

Set up the server’s API with Proxy

next.config.json

  rewrites: async () => {
    return [
      {
        source: "/api/:path*",
        destination: "https://api.mztrees.com/api/:path*",
      },
    ];
  },

Remove baseUrl from the file currently using fetch and use it as /api/...

src/lib/client.ts (in get / post / patch /delete)

export const fetchClient = {
...
const response = await fetch(this.baseUrl.concat(url), {
-> const response = await fetch(url, {
...
}

src/app/write/page.tsx
src/app/write/edit/[id]/page.tsx

 await fetch(`${baseUrl}/api/items/urls`, {
 -> await fetch(`/api/items/urls`, {

Call the API directly from the server component.

src/app/items/[id]/page.tsx

const itemData = await getItem(parseInt(id));
-> const res = await fetch(`https://api.mztrees.com/api/items/${id}`);
  const itemData = await res.json();

Currently, the login part does not work smoothly in development mode. So you need to comment out "checkIsLoggedIn" and test it.

src/app/write/layout.tsx

  const isLoggedIn = await checkIsLoggedIn();
  if (!isLoggedIn) {
    return redirect(`/login?next=/write`);
  }
  ->
    // const isLoggedIn = await checkIsLoggedIn();
  // if (!isLoggedIn) {
  //   return redirect(`/login?next=/write`);
  // }

The location of the files to add is as follows:

src/app/write/intro/page.tsx > in onSubmit
src/app/write/edit/[id]/intro/page.tsx > in onSubmit

thank you


Error quadratic absolute

Fixes #1103
As some updated happened in other branch, this error no longer exists. So I made this pull request to recover the skipped test for quadratic absolute optimization.

Closing since we'll only support linear_absolute going forward.


Sitescraper request tamilrage

Hey Bro please add http://tamilrage.com , http://tamiltv.online/ , http://www.tamildbox.net
Einthusan addons not working. can you add the sites too please?
Thank you!

Einthusan 1.3.9 is working fine. If it is not working for you raise a issue in Einthusan github.
tamildbox is part of tamilgun scraper, so no need to add it.
Will take a look at other two

tamiltv.online is just loading ads on top of thoptv to show the stream. DD already has thoptv, so no point adding tamiltv.online
tamilrage.com is using cloudflare ddos protection. DD doesnt have the functionality to scrape such sites yet. Will take time to do it.

Ok Thanks Bro ;)


Apply performance enhancments to WorldWind 0.9.0

[x] Network request throttling
[x] Better management of volatile GPU resources
[x] Increase size of tile matrix caches

Added WorldWindFixes and modified EnhancedWmsLayer.  WorldWindFixes is used and applied by main.js.
See commits 924f01728 and dab0475b


feature: unit tests

Hello Team :wave:
All widgets are now available for preview at: https://devfest23.netlify.app


Create Nshalati Mboweni

Hi, it looks like you're learning how GitHub works. That's ok, but please don't open pull requests in other people's projects unless you have something specific to contribute to that project. Your blank pull request is not useful to us and creates unnecessary noise by sending notifications to everyone maintaining and following the github/fetch project.
Instead, you can try features like creating Issues and Pull Requests in your own project that you can create using the “New repository” menu item in the main navigation of the site. Thank you!


formatInputTooShort not working

formatInputTooShort property is not working.
minimumInputLength: 3,
formatInputTooShort: function(term: string, minLength: number) {
        console.log(term);
        console.log(minLength);
        return "Test";
}

The point is that even the console is showing nothing so it is not triggered.

I think the problem is that in Select2 4 the property is no called like that anymore.
https://github.com/select2/select2/releases/tag/4.0.0-beta.1
But using the new options does not work either.

Right, I do not work either.
Is there any other way to modify this message?
Thank you.