[Feature Request] move fmt

🚀 Feature Request
Move formatter. move fmt, just like how cargo fmt formats rust code.
Motivation
Useful in enforcing consistent coding style.

@awelc Does move-analyzer plan to support the textDocument/formatting PSL protocol, and starcoin-ide also wants to integrate this function?

I've been meddling with Move ASTs in my Move-to-TypeScript transpiler. I can probably do a formatter myself. Do you guys know where I could get a grant to speed things up? We're not raising yet so any bit of cash would help.

@Manahip You can participate in https://github.com/starcoinorg/startrek organized by starcoin, there will be bonuses after graduation.

@Manahip I found a project that has implemented move-fmt, repository: https://github.com/victoryang00/move-fmt

@LemonHX Do you know the author?

The move-fmt project is for Move IR, an older (and simpler) instance of Move.

The move-fmt project is for Move IR, an older (and simpler) instance of Move.

The move-fmt project uses pest parsing to get the AST, and then does the formatting. If the move grammar he configured is older, we can update the grammar file https://github.com/victoryang00/move-fmt/blob/master/src/grammar.pest

The move fmt could use the internal move parser to get the ast and do the formatting
https://github.com/move-language/move/blob/main/language/move-compiler/src/parser/mod.rs#L29-L132 .
In that case, move fmt could be consistent with the compiler even if there are some updates.

The move fmt could use the internal move parser to get the ast and do the formatting https://github.com/move-language/move/blob/main/language/move-compiler/src/parser/mod.rs#L29-L132 .
In that case, move fmt could be consistent with the compiler even if there are some updates.

this is a good idea.

this is a good idea.

I want to give this idea a try and get myself into it now.
After we get the ast, the move fmt could do something similar like rustfmt
https://github.com/rust-lang/rustfmt/blob/2403f827bf1e427a04ce45c88a64cbebe91041d7/src/rewrite.rs#L16-L19 .
We could define the Rewrite trait for each ast type.

I consulted the original author of https://github.com/victoryang00/move-fmt, he is willing to donate this project to the Move community, I think we can continue to iterate this project, and then apply for transfer to https: //github.com/move-language.
Work that can now move forward includes:

Replace the AST parser with the move official one
Add Rust API to facilitate other project calls
Refer to rust-fmt-rfcs to determine move fmt-rfcs

I am not sure if starting with the existing formatter is the best idea. Not only using "official" Move parser would result in a different AST which would require modifying pretty much all the AST traversal code, but also from looking at the existing prototype, the formatter is a bit too simplistic - in particular it does not seem to be taking the text width into consideration at all when constructing the output.
If we want a tool that  would be used by the generations of Move programmers to come, we need something at the same quality level as gofmt or rustfmt. There is a really good article about difficulties of writing a good auto-formatter, and handling line-breaks to accommodate max text width emerges as one of the more difficult problems. Admittedly, the article talks about auto-formatting Dart and doing this for Move may (should?) be simpler, but I am not convinced that adding the required logic to the existing codebase (along with all the refactorings that would be required to accommodate a different parsing infrastructure) is going to be simpler than writing the code from scratch.

comments which need to be preserved (this excludes e.g. using the current parser, which throws comments away even before the lexer is run)

Indeed, existing parser would have to be extended/modified. Arguably using it is still a preferred solution (e.g., for maintenance purposes) over building parsing infrastructure from scratch, though.

I put together what can be done:

Modify the official Move parser to keep comments in the AST
Refer to rust-fmt-rfcs to determine move fmt-rfcs
Design move-fmt code architecture
Initialize the move-fmt project in the language directory

The comments could be retrieved from MatchedFileCommentMap. It is explained in https://github.com/move-language/move/blob/main/language/move-compiler/src/parser/lexer.rs#L346-L349  although I am not quite sure whether it works in the correct way.
Anyway, I agree that the best way is to refactor the parser to include comments in the AST.

Refer to rust-fmt-rfcs to determine move fmt-rfcs

rust-fmt-rfcs has been iterated after several years already. I think we could decide some basic initial requirements(features) of the formatters and write a very first prototype of the formatter. These initial requirements should benefit the move-fmt code architecture. Then move-fmt should be published and we could go forward to move-fmt-rfcs based on the user feedback.

I think We better use the already implemented formatter https://github.com/pontem-network/intellij-move/issues/88.

I wonder Is  there any progress on this issue.

@awelc
Implementing a language formatter with less work.
Implementing a formatter for programming language always with a lot of work.
A formatter just print a AST to a string.
first of all a language AST always has a lot of variant data structure.
like move expression.
pub enum Exp_ {
    Value(Value),
    // move(x)
    Move(Var),
    // copy(x)
    Copy(Var),
    // [m::]n[<t1, .., tn>]
    Name(NameAccessChain, Option<Vec<Type>>),

    // f(earg,*)
    // f!(earg,*)
    Call(NameAccessChain, bool, Option<Vec<Type>>, Spanned<Vec<Exp>>),

    // tn {f1: e1, ... , f_n: e_n }
    Pack(NameAccessChain, Option<Vec<Type>>, Vec<(Field, Exp)>),

    // vector [ e1, ..., e_n ]
    // vector<t> [e1, ..., en ]
    Vector(
        /* name loc */ Loc,
        Option<Vec<Type>>,
        Spanned<Vec<Exp>>,
    ),

    // if (eb) et else ef
    IfElse(Box<Exp>, Box<Exp>, Option<Box<Exp>>),
    // while (eb) eloop
    While(Box<Exp>, Box<Exp>),
    // loop eloop
    Loop(Box<Exp>),

    // { seq }
    Block(Sequence),
    // fun (x1, ..., xn) e
    Lambda(BindList, Box<Exp>), // spec only
    // forall/exists x1 : e1, ..., xn [{ t1, .., tk } *] [where cond]: en.
    Quant(
        QuantKind,
        BindWithRangeList,
        Vec<Vec<Exp>>,
        Option<Box<Exp>>,
        Box<Exp>,
    ), // spec only
    // (e1, ..., en)
    ExpList(Vec<Exp>),
    // ()
    Unit,

    ...
}

This is just Expression variants.
There are also Function,Module,Struct,etc.
Implement a formatter you have to deal all the data structure.
Another complex thing about formatter is Comments.
Most programming language support two forms of comments.

Line comment       // This a is comment.
Block comment     /*  This a is comment. */

The tricky part is Block comment.
Block comment can write anywhere in source code.
In order to keep user's comments you have to keep comments in AST like below.
    // f(earg,*)
    // f!(earg,*)
    Call(NameAccessChain,
        Vec<Comment> , // keep in AST.
        bool, Option<Vec<Type>>, Spanned<Vec<Exp>>),

This will make things below ugly.

AST Definition.
Parse AST.
All routine that accept AST.

In general We need keep a Vec<Comment> in every AST structure.
Is there a way to slove this puzzle.
TokenTree solution
The key idea about this post to simplfy AST to far more simpler tree type which I call it TokenTree.
function(a) {
    if (a) {
        return 1
    } else {
        return 2
    }
}

TokenTree mainly contains two category.

SimpleToken in previous code snippet,if,return,a are SimpleToken.
Nested in previous code snippet, paired () and paired {} will form a Nested Token.

So a source program may represents like this.
pub enum TokenTree {
    SimpleToken {
        content: String,
        pos: u32,  // start position of file buffer.
    },
    Nested {
        elements: Vec<TokenTree>,
        kind: NestKind,
    },
}

pub type AST = Vec<TokenTree>;

Instead of dealing a lot data structure we simple the puzzle to dump Vec<TokenTree>.
TokenTree is just another very simple version of AST.
TokenTree is very easy to parse,simple as.
...
if(tok == Tok::LParent){ // current token is `(`
    parse_nested(Tok::LParent);
}
...

Right now verything looks fine.
But There are some token can be both SimpleToken and Nested.
Typical for a language support type parameter like Vec<X>.
A Token < can be type parameter sign or mathematic less than.
This can be solved by consult the AST before parse TokenTree.
Because we are writting a formatter for exist programming language.
It is always easy for us to get the real AST.
We can traval the AST the decide < is either a SimpleToken or Nested.
how to generate base on TokenTree.
Vec<TokenTree> is a tree type, It is very easy to decide how many ident,etc.
And comment can pour into result base on the pos relate to SimpleToken.pos.

As far as I know one of the main problems with full-fledged auto-formatting is deciding where and how to split lines when they get too long. I don't think a choice of a particular representation is going to help here much...
More generally, hopefully we will eventually get to writing the auto-formatter but at least on my side, this is not going to happen sooner than in a few (or several rather) months.

I just want to bring up a few ideas on this topic now since I have done some work on the formatter before although none is merged.
@awelc You are right that line splitting is a very difficult point and @tnowacki shared a post about the difficulty line splitting with. I also want to share it here for those who are interested.
However, the current main blocker for the formatter is not line splitting but having a syntax tree that is lossless or full fidelity!!. I don't think we have been in the trouble of line spliting yet. The particular representation proposed by @yuyang-ok is trying to solve the current blocker(a syntax tree that is lossless).
The reason to have another representation on the ast is that the comments are ignored in the current syntax tree which is also mentioned in @yuyang-ok comments.
There is another way to have a formatter without having another full fidelity syntax tree, though. The solution is to look back at the original source code checking whether there is some comments every time we check on ast based on the pos. This could be a solution although I haven't tried at all. But this solution have some limitation on formatting and bad performance.
I think @yuyang-ok makes a very good point. I just want to extend the content here with something in my mind.
It would be great to introduce a red-green tree which is also used by the rust-analyzer. I would just drop rust-analyser doc link which talks a  lot about the red-green tree and the things we could do with it. Some  of the ideas are aligned wtih @yuyang-ok idea but it is more. We could manipulate the token trees directly on the formatter to genreate new formatted codes.

@awelc @zsluedem I think I want give the TokenTree a try.

@awelc @zsluedem I think I want give the TokenTree a try.

On our side we normally prefer re-using (and modifying if necessary) the existing tool chain rather than building a new one (which I think is what the TokenTree proposal involves) to avoid additional maintenance effort and difficulties related to the language (and existing toolchain) evolution. This does not have to necessarily stop you from pursuing the TokenTree idea, and we are happy to see external contributions to the ecosystem, but I also wanted to clarify our own position on this.

@awelc Ok, thanks . TokenTree will not modify the current tool chain at all.

@wrwg any updates on this?

Yes: Aptos foundation registry grant project is in the testing phase, should be released in Q1.

@wrwg excellent, thanks for the update. Is the repo open source at the moment, or perhaps in alpha? I'd be glad to try it out and start working it into our repo CI/CD


Protect ORT from errors caused by missing data in TO.

If a required file is not configured with a location parameter, ORT is
still attempting to process it, despite the fact that there is no file
name to process. This displays lots of errors that don't clearly
indicate what is happening or to which file it is happening. This error
message documents the problematic file and prevents its processing so
that things can continue, just without that file.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1314/
Test PASSed.

Usually (always?) this error means that there is a config file that is referenced by a plugin in remap.config, so feels to me that these config file really do need to be audited, and the ORT run should bail if it can't properly do this audit.

Right, I thought about that. Right now, the behaviour is to barf out perl errors and forge ahead ON ERROR RESUME NEXT–style. At the moment, the effect is to just not process that config file, which is likely to cause serious errors if that file is required for anything important. I worry, however, that the lack of error handling could cause more serious errors in the future. One could easily imagine a scenario where a directory is being configured instead of a file and we chown ats:ats $config_dir/*. If $config_dir is empty, that could cause all manner of trouble executing as root. In any case, barfing errors and continuing isn't great.
I considered having ORT bail entirely. The problem here is that it's already accomplished some of its work before it discovers the error. And all the rest of the work can still be safely accomplished. Sure, you might wind up with ATS refusing to start because it's missing foobaz.lua which is required for a specific plugin. But then at least the file reported as missing is the one that isn't properly configured. If we just bail when we see the ill-configured file, we run the risk fo ATS refusing to start because it doesn't have goobaz.lua, which is properly configured but would have been handled right after foobaz.lua.
In practice, I've also observed that this error isn't always as fatal as you might guess. A config file will be added for a new plugin on a new Delivery Service, but the DS won't be assigned to anything important until it's been tested. But the config file will be part of the profile for lots of things. During this (sometimes lengthy) period, there can be a misconfigured config file in the profile that isn't actually damaging production traffic.
I guess the ideal scenario is that ORT parses through all the files it needs and ensures that it has all the data before it starts any work at all, and refuses to do anything unless everything is copasetic. That's a great feature and someone should write it. :) This, however, makes the code just a little bit safer and the error message considerably easier to understand.


Sprite can't be added to LableAtlas when render type is canvas, version is cocos2d-js 3.2

We'll test this issue late, Thanks @tqxie .

Yes, it is a design flaws. Because LabelAtlas always remove all children and add the new label children in its children array at calling setString.
So if you add your node to LabelAtlas object, it will be removed when calling setString.
Please add your node and the labelAtlas in a root node.
Sorry for reply late.
David


Turbolinks 5 not working with Bootstrap-checkbox-radio-switch.js

Hello,
I fixed this by including in the html properties of the links the 'data-method'=>'get'  or the method: :get for the link_to rails tags. The result was disabling turbolinks for that links..
I am not good in Javascript and Jquery.
I don't know how to modify this js file so that it loads with turbolinks.. I do not see any $(document).ready() statement or similar.
The problem is connected to that file not loading when I change page with turbolinks. I set breakpoints and tested both scenario so I am sure.
This is the visual result, with turbolinks:

Without turbolinks:

I attach the js file, but my question is mostly about this lines:
!function ($) {
}(window.jQuery);

!function ($) {
    var Radio = function (element, options) {
           this.init(element, options);
          }
}(window.jQuery);

Any help appreciated
Thanks a lot
Fabrizio
bootstrap-checkbox-radio-switch.txt

I do not see any $(document).ready() statement or similar.

On line 100 and 242, there is the "shorthand" version of $(document).ready():
$(function () { … })

On line 100:
$(function () {
  $('[data-toggle="checkbox"]').each(function () {
    var $checkbox = $(this);
    $checkbox.checkbox();
  });
});

and on 242:
$(function () {
  $('[data-toggle="radio"]').each(function () {
    var $radio = $(this);
    $radio.radio();
  });
});

Duplicating this setup in a turbolinks:load event should hopefully fix your problem. For example, include the following in your main JavaScript bundle:
$(document).on('turbolinks:load', function () {
  $('[data-toggle="checkbox"]').each(function () {
    var $checkbox = $(this);
    $checkbox.checkbox();
  });

  $('[data-toggle="radio"]').each(function () {
    var $radio = $(this);
    $radio.radio();
  });
})

The plugin seems to make sure that calling the the plugin more than once on the same element doesn't duplicate the behaviour (Lines 57-72 and 201-216), so hopefully there shouldn't be any side-effects from the library calling it on $(document).ready, and you calling it on turbolinks:load.

Thanks a lot !
Amazing this solved the issue. I had also some issues with bootstrap tooltips, but I fixed them the following post. I just write this as a note in case somebody in the future will have similar issues.
[(http://stackoverflow.com/questions/20129970/bootstrap-tooltip-in-ruby-on-rails#20130191)]
Your advice was very helpful, I will look deeper in this code in the future to make it more compatible with Turbolinks 5.
Unluckly I do not have much JS Experience, but now I will learn.
Thanks a lot
Fabrizio Bertoglio

@fabriziobertoglio1987 can this issue be closed now?

@domchristie yes. thanks a lot. Sorry. I am experiencing problems getting github notifications.

Still it is not clear to me why many libraries break with Turbolinks 5 and where to find information on how to fix this problems.

Some libraries assume that pages are loaded in the traditional way rather than via JavaScript. This means they are designed to run when the page is initially loaded. Turbolinks loads pages through JavaScript and so in order to use the library's code, you will often need to call their functions manually on turbolinks:load.
It's also worth noting that libraries often expect pages to be fully unloaded. This is not the case with Turbolinks as it caches the state of the page as you left it. So to prevent your library code from running more than once and causing duplication issues, it is often a good idea to teardown (or destroy) the effects of the plugin on turbolinks:before-cache.
So to summarise, if you must use plugins, looks for those that you can manually initialise as well as teardown. Initialise on turbolinks:load and destroy on turbolinks:before-cache.
If you have further issues, ask question on StackOverflow and tag it with 'turbolinks'. Hope that helps :)


RootDockingPanel Only Supports JFrame

Would be good to abstract RootDockingPanel more to allow JFrame and JDialog and possibly other container types.

A quick experiment changing JFrame to Window in almost all of Modern Docking says yes this is possible. There are a lot of spots that need fixing for positioning. convertPointToScreen is very picky about what component you use, it has to be the right one to get the right position.

Everything has been changing to Window where it makes sense. Docking in JDialog is experimentally supported now.


[sitemapCheck] handle sitemap living on GitHub

sitemapCheck currently throws an error trying to access a sitemap that is stored on GitHub

example problem url: https://raw.githubusercontent.com/BeBOP-OBON/odis-interface/main/sitemap.xml

likely reason is that validation fails as the header content-type of that page is text/plain, whereas application/xml is expected
exact error message is ERROR reading sitemap XML

(related to https://github.com/BeBOP-OBON/odis-interface/issues/1 )

This was caught by @fils, the issue was that the sitemap had an empty first line.  Closing.


Show snippet message for unnamed sources

Fixes #38

haha cargo fmt to the rescue 😅

yay thanks :D


Change validation to fit the situation that some knapsacks are not used

When some knapsacks are not used, the last check in "Ensure solution validity" may cause ValueError('Solution not valid'). #13

Hi, thanks for finding this bug and taking the initiative to create a pull request! I bumped up the version, and will merge to master.


doc stack v2

@Nexucis I believe this is what you mean here
pip install -r requirements.txt
mkdocs serve -a "localhost:8000"

By looking at the files, yes I mean that. Thank you.
I tried to run the website and it seems I am missing something because when I tried the command I got that:
mkdocs serve -a "localhost:8000"

Error: MkDocs encountered an error parsing the configuration file: while constructing a Python object
cannot find module 'material.extensions.emoji' (No module named 'material')
  in "/Users/ahusson/workspace/go/src/perses/website/mkdocs.yml", line 37, column 20

Probably I have an issue with my environment

but no idea what it is, rerunning the command to install the packages it tells me all requirements are satisfied.
 pip3 install -r requirements.txt --break-system-packages --user
Requirement already satisfied: mkdocs-multirepo-plugin in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from -r requirements.txt (line 1)) (0.8.3)
Requirement already satisfied: mkdocs-material==9.5.34 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from -r requirements.txt (line 2)) (9.5.34)
Requirement already satisfied: mike==2.1.3 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from -r requirements.txt (line 3)) (2.1.3)
Requirement already satisfied: babel~=2.10 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2.16.0)
Requirement already satisfied: colorama~=0.4 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (0.4.6)
Requirement already satisfied: jinja2~=3.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (3.1.4)
Requirement already satisfied: markdown~=3.2 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (3.7)
Requirement already satisfied: mkdocs-material-extensions~=1.3 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (1.3.1)
Requirement already satisfied: mkdocs~=1.6 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (1.6.1)
Requirement already satisfied: paginate~=0.5 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (0.5.7)
Requirement already satisfied: pygments~=2.16 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2.18.0)
Requirement already satisfied: pymdown-extensions~=10.2 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (10.9)
Requirement already satisfied: regex>=2022.4 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2024.9.11)
Requirement already satisfied: requests~=2.26 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2.32.3)
Requirement already satisfied: importlib-metadata in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mike==2.1.3->-r requirements.txt (line 3)) (8.5.0)
Requirement already satisfied: importlib-resources in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mike==2.1.3->-r requirements.txt (line 3)) (6.4.5)
Requirement already satisfied: pyparsing>=3.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mike==2.1.3->-r requirements.txt (line 3)) (3.1.4)
Requirement already satisfied: pyyaml>=5.1 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mike==2.1.3->-r requirements.txt (line 3)) (6.0.2)
Requirement already satisfied: pyyaml-env-tag in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mike==2.1.3->-r requirements.txt (line 3)) (0.1)
Requirement already satisfied: verspec in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mike==2.1.3->-r requirements.txt (line 3)) (0.1.0)
Requirement already satisfied: dacite<2.0.0,>=1.8.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-multirepo-plugin->-r requirements.txt (line 1)) (1.8.1)
Requirement already satisfied: python-slugify in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-multirepo-plugin->-r requirements.txt (line 1)) (8.0.4)
Requirement already satisfied: typing-inspect<0.9.0,>=0.8.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-multirepo-plugin->-r requirements.txt (line 1)) (0.8.0)
Requirement already satisfied: MarkupSafe>=2.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from jinja2~=3.0->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2.1.5)
Requirement already satisfied: click>=7.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (8.1.7)
Requirement already satisfied: ghp-import>=1.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2.1.0)
Requirement already satisfied: mergedeep>=1.3.4 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (1.3.4)
Requirement already satisfied: mkdocs-get-deps>=0.2.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (0.2.0)
Requirement already satisfied: packaging>=20.5 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (24.1)
Requirement already satisfied: pathspec>=0.11.1 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (0.12.1)
Requirement already satisfied: watchdog>=2.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (5.0.2)
Requirement already satisfied: charset-normalizer<4,>=2 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from requests~=2.26->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (3.3.2)
Requirement already satisfied: idna<4,>=2.5 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from requests~=2.26->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (3.9)
Requirement already satisfied: urllib3<3,>=1.21.1 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from requests~=2.26->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2.2.3)
Requirement already satisfied: certifi>=2017.4.17 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from requests~=2.26->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2024.8.30)
Requirement already satisfied: mypy-extensions>=0.3.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from typing-inspect<0.9.0,>=0.8.0->mkdocs-multirepo-plugin->-r requirements.txt (line 1)) (1.0.0)
Requirement already satisfied: typing-extensions>=3.7.4 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from typing-inspect<0.9.0,>=0.8.0->mkdocs-multirepo-plugin->-r requirements.txt (line 1)) (4.12.2)
Requirement already satisfied: zipp>=3.20 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from importlib-metadata->mike==2.1.3->-r requirements.txt (line 3)) (3.20.2)
Requirement already satisfied: text-unidecode>=1.3 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from python-slugify->mkdocs-multirepo-plugin->-r requirements.txt (line 1)) (1.3)
Requirement already satisfied: python-dateutil>=2.8.1 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from ghp-import>=1.0->mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (2.9.0.post0)
Requirement already satisfied: platformdirs>=2.2.0 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from mkdocs-get-deps>=0.2.0->mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (4.3.3)
Requirement already satisfied: six>=1.5 in /Users/ahusson/Library/Python/3.12/lib/python/site-packages (from python-dateutil>=2.8.1->ghp-import>=1.0->mkdocs~=1.6->mkdocs-material==9.5.34->-r requirements.txt (line 2)) (1.16.0)

Also I am on a Mac M2 and I had to add a couple of flags because otherwise it didn't want to add the packages ...

I've now got all the menu links transferred. I don't understand why you can't build. I'm running on an M2 Mac too.

awesome, thank you @agardnerIT !
Yeah no idea why, I will try again today. I would like to run it before merging it to at leat giving good feedback

ok I finally managed to make it works.
Looks awesome for a start ! I will merge it and will probably make some PRs to improve a bit what I am seeing.
Thanks !

As a passer by, excited about this :) Is there a place a new design can be previewed?

hey @gmile, thank you !
Unfortunately no there is no particular preview, excepting running the website locally. For a new design I think @agardnerIT have some ideas but other all it depends mainly on people and their imagination :).

I think I got mixed up the concepts of "new design" and... "new stack" which is what this PR is about 🙈
So the stack is changing to mkdocs and it can easily be ran locally now, but there won't be any new website design for now? I guess I understand now, thanks for clarifying 🙇


Please put example code in sub directory

Hi, thanks for the great work.  When I initially saw your codebase, I thought this was a React Native bridge module, but then came to understand it was a JS-only package.  This is because I saw the android and ios directories.  Also I was confused at index.ios.js and index.android.js files.
Typically in a RN library you put example code in a sub directory called Example or whatever.  This will eliminate any confusion.  If you need help, let me know and I'll create a PR for it

Thanks!

But sub directory can't import superior directory's file. Any idea? PR is welcome!


Exception while save file

Issue summary
Exception while save file

Exception 'TypeError' with message 'Return value of League\Csv\StreamIterator::getCurrentLine() must be of the type string, boolean returned'
in /vendor/league/csv/src/StreamIterator.php:219
System informations
League\Csv - ^9.0@dev
PHP - PHP 7.0.15-0ubuntu<IP_ADDRESS> (cli) ( NTS )
OS Platform - UBUNTU 16.04
Standalone code, or other way to reproduce the problem
<?php

$writer = Writer::createFromPath('path/to/csv', 'w+');
$writer->insertOne(['title1', 'title2', 'title3']);
$writer->insertOne(['row1', 'row1', 'row2']);
$writer->output();

Expected result
Created file without exceptions
Actual result
Created file with exception

@yupe Thanks for the reported bug... as I'm still working on v9 this will be fix in the next commit.
As a side note in your example you have created a CSV file with the w open mode flag and then used the ouput method on it. This is not recommended because the method will reset the CSV document pointer and anything written will be truncated as per w expected usage. This is true in v8 as well. An alternative would be to use w+ instead, for instance.

The bug fix has landed on the master branch I'll close this issue.


FTDI  USB device detected but ftdi_sio driver not loaded

Windows Version
Microsoft Windows [version 10.0.22621.1848]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Debian GNU/Linux 12 (bookworm)
Other Software
usbipd-win  4.1.0+52.Branch.master.Sha.b0b7589d2dc4481b1af481787d6d773f46d0758
Repro Steps
FTDI USB Serial Device (TTL-232RG) connected , Shared and Attached

Expected Behavior
New USB device detected by Linux Kernel,
FTD driver loaded
/dev/ttyUSB0 node device created
Following lines expected in kernel messages:
(Older version of WSL)
Mar  4 14:33:36 GOR-LAP-27 kernel: vhci_hcd vhci_hcd.0: pdev(0) rhport(0) sockfd(3)
Mar  4 14:33:36 GOR-LAP-27 kernel: vhci_hcd vhci_hcd.0: devid(458754) speed(2) speed_str(full-speed)
Mar  4 14:33:36 GOR-LAP-27 kernel: vhci_hcd vhci_hcd.0: Device attached
Mar  4 14:33:37 GOR-LAP-27 kernel: vhci_hcd: vhci_device speed not set
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: new full-speed USB device number 4 using vhci_hcd
Mar  4 14:33:37 GOR-LAP-27 kernel: vhci_hcd: vhci_device speed not set
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: SetAddress Request (4) to port 0
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: New USB device found, idVendor=0403, idProduct=6001, bcdDevice= 6.00
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: Product: TTL232RG-VREG3V3
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: Manufacturer: FTDI
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: SerialNumber: FT4M5QPB
Mar  4 14:33:37 GOR-LAP-27 kernel: ftdi_sio 1-1:1.0: FTDI USB Serial Device converter detected
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: Detected FT232RL
Mar  4 14:33:37 GOR-LAP-27 kernel: usb 1-1: FTDI USB Serial Device converter now attached to ttyUSB0
Actual Behavior
Current lines observed in kernel messages
[  517.212711] vhci_hcd vhci_hcd.0: pdev(0) rhport(0) sockfd(3)
[  517.214455] vhci_hcd vhci_hcd.0: devid(458753) speed(2) speed_str(full-speed)
[  517.215864] vhci_hcd vhci_hcd.0: Device attached
[  517.496755] vhci_hcd: vhci_device speed not set
[  517.566815] usb 1-1: new full-speed USB device number 2 using vhci_hcd
[  517.647031] vhci_hcd: vhci_device speed not set
[  517.716812] usb 1-1: SetAddress Request (2) to port 0
[  517.760078] usb 1-1: New USB device found, idVendor=0403, idProduct=6001, bcdDevice= 6.00
[  517.761869] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  517.762593] usb 1-1: Product: TTL232RG-VREG3V3
[  517.763071] usb 1-1: Manufacturer: FTDI
[  517.763387] usb 1-1: SerialNumber: FT4M5QPB
@paudenard@GOR-LAP-27:/var/log$
Diagnostic Logs
lsusb output:

According to /proc/config.gz  , Kernel has been built with FTDI_SIO Options

Kernel Object present in /usr/lib/modules

I am running into the same issue with the same hardware.
The only difference is the distro - Ubuntu 22.04.4 LTS.
@Broussailles Do you have the linux kernel you were using on March 4th?

For some reason my 5.15 kernel had ftdi_sio as a module rather than a builtin.
And it seems that is the official build config for 5.15 https://github.com/microsoft/WSL2-Linux-Kernel/blob/linux-msft-wsl-5.15.y/arch/x86/configs/config-wsl#L2769C1-L2770C1
CONFIG_USB_SERIAL_FTDI_SIO=m

But 6.1 fixes that already
https://github.com/microsoft/WSL2-Linux-Kernel/blob/linux-msft-wsl-6.1.y/arch/x86/configs/config-wsl#L2858C1-L2858C27
CONFIG_USB_SERIAL_FTDI_SIO=y

Detailed walk through of my steps, including a probably unnecessary --set-val on the FTDI driver documented here:
https://www.ralf-lang.de/2024/04/02/run-ftdi-usb-devices-on-windows-10-11-wsl2/
git clone https://github.com/microsoft/WSL2-Linux-Kernel.git --depth=1 -b linux-msft-wsl-6.1.y
sudo apt update
sudo apt -y install build-essential flex bison libssl-dev libelf-dev bc
sudo apt -y install python3 pahole
cd WSL2-Linux-Kernel
## This line turns the FTDI driver from disabled or module to builtin
./scripts/config --file Microsoft/config-wsl --set-val CONFIG_USB_SERIAL_FTDI_SIO y
make -j$(nproc) KCONFIG_CONFIG=Microsoft/config-wsl
sudo make modules_install headers_install
## Use another target directory if you don't want the kernel in the root of C:\
cp arch/x86/boot/bzImage /mnt/c/bzImage-6.1
```


Absence of verify api for csharp language and error received when tried with csharp anyway

Absence of verify api for csharp language on the tutorial page is deep. it is available for only python.
When i go ahead and call verifyfacetoface in csharp, it returns badresult
Microsoft.Azure.CognitiveServices.Vision.Face.Models.APIErrorException: Operation returned an invalid status code 'BadRequest'
at Microsoft.Azure.CognitiveServices.Vision.Face.FaceOperations.DetectWithUrlWithHttpMessagesAsync(String url, Nullable1 returnFaceId, Nullable1 returnFaceLandmarks, IList1 returnFaceAttributes, String recognitionModel, Nullable1 returnRecognitionModel, String detectionModel, Dictionary2 customHeaders, CancellationToken cancellationToken)    at Microsoft.Azure.CognitiveServices.Vision.Face.FaceOperationsExtensions.DetectWithUrlAsync(IFaceOperations operations, String url, Nullable1 returnFaceId, Nullable1 returnFaceLandmarks, IList1 returnFaceAttributes, String recognitionModel, Nullable1 returnRecognitionModel, String detectionModel, CancellationToken cancellationToken)    at ReadAttributesFromFacialImage.FaceValidation.DetectFaceRecognize(IFaceClient faceClient, String url, String recognition_model) in /Users/xxxxx/Projects/ReadTextFromImageConsole/ReadAttributesFromFacialImage/FaceValidation.cs:line 251    at ReadAttributesFromFacialImage.FaceValidation.FindSimilarFaces(List1 targetImageURLs, String sourceImageURLs) in /Users/xxxxx/Projects/ReadTextFromImageConsole/ReadAttributesFromFacialImage/FaceValidation.cs:line 117

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24f2953b-2900-322d-dbfd-a53846e75940
Version Independent ID: 25af9875-58cf-69d5-478d-08fb888d12dc
Content: Quickstart: Use the Face client library - Azure Cognitive Services
Content Source: articles/cognitive-services/Face/QuickStarts/client-libraries.md
Service: cognitive-services
Sub-service: face-api
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@technololy Thanks for the question. We are investigating the issue and will update you shortly.

@technololy Thanks for the question. We are investigating the issue and will update you shortly.

After almost 6 hours, I was able to play around several methods around the documentation and achieved my aim.
WIll close this now. Kindly look into updating the doc/specified methods on the doc


Disruption of Drag-and-Drop Feature During Notero Sync

Describe the issue
During the syncing process of Notero, the drag-and-drop functionality in Zotero becomes blocked, disrupting my workflow. As I heavily rely on drag-and-drop to assign tags or move documents within collections, this interruption significantly hampers my efficiency.
To Reproduce
Steps to reproduce the behaviour:

Add a tag by drag-and-drop or move document in a collection where Notero sync is enabled
Wait for Notero to stop syncing
Repeat step 1.
Step wait for the repeat of step 2. to finish
Again, for all the files you need to move or tags you need to add.

Expected behavior
Non-blocking dragging of file when Notero is syncing
Screenshots

The screenshot shows Notero's small pop-up in the bottom-right corner of the Zotero window. During its display, drag-and-drop operations are inhibited, causing inconvenience.
Additional context

Windows 10 Pro 22H2
Zotero 6.0.30
Notero 0.5.13

Thanks for reporting this, @nicolnt. I'm able to reproduce the behavior on macOS 14.2.1 in both Zotero 6.0.30 and Zotero 7.0.0-beta.56.
It's quite noticeable while trying to perform drag-and-drop operations, and I've also noticed that most UI interactions seem to be negatively impacted while a sync is in progress.
Upon some initial exploration, it looks like the UI impact occurs while Notero is performing operations to update Zotero items after each is saved to Notion. I imagine this is because these operations are happening on the main thread that's also used for UI updates.
I'll dig into this and see if I can come up with a fix.

I'm discussing this with other Zotero developers on the mailing list. I don't have a solution yet, but I've at least narrowed down the cause to the code that generates item citations.
While absolutely not ideal, a way to work around the issue is by removing anything related to citations. Specifically, this means you'd have to:

Delete the Full Citation and In-Text Citation properties from your Notion database (if you have them)
In the Notero preferences, change the Notion Page Title setting to either Item Title, Item Short Title, or Item Citation Key (if you have Better BibTeX installed)

@nicolnt, I think I've hopefully fixed (or at least improved) this in version 0.6.2.
The issue is indeed caused by the generation of citations, and it seems to be an issue that Zotero also suffers from when using its Quick Copy functionality—see this Zotero forum post.
It turns out that some citation styles cause more of a performance impact than others, and the APA style seems to be especially bad. Unfortunately, Notero used the APA style to generate author-date page titles, but that's no longer the case in v0.6.2.
There will still be a performance impact if using the Full Citation and In-Text Citation properties in combination with certain Quick Copy formats, but since the problem exists in Zotero itself, I don't know that I can easily fix it.
Please let me know if you're still having performance issues!


Fix a grammar issue in CyberRT_Python_API.md

Fix a tiny grammar issue here : )

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


iOS: App not opening after we select the image/video only a dialog screen

I followed the documentation, but on iOS, it only displays a dialog screen with a textfield and the selected media. How can I open the app directly after selecting the media?
Thanks

same


Adopt new Travis CI container infrastructure

Should speed up the builds a bit.
http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/
Signed-off-by: Chris Aniszczyk<EMAIL_ADDRESS>

Coverage remained the same when pulling 157c829538102149167d0b3911e150015edec196 on new-travisci-infra into a85f6b985fbbcfba60d2869c9a51d2588d1726ea on master.


Fix default display data

Problem
Agents that have 0 subpoints get assigned a default display_type of SPHERE_GROUP rather than SPHERE.
Solution
Added a check for 0 subpoints in AgentData._default_display_type_for_agent().
Type of change

Bug fix (non-breaking change which fixes an issue)

Change summary:

only set default DISPLAY_TYPE to something other than SPHERE if n_subpoints > 0
added a test case where a sphere agent doesn't have display data specified so uses the default

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.13 :tada:

Comparison is base (455f3ca) 92.08% compared to head (6f62390) 92.21%.

:exclamation: Current head 6f62390 differs from pull request most recent head 0a817c0. Consider uploading reports for the commit 0a817c0 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   92.08%   92.21%   +0.13%
==========================================
  Files         101      101
  Lines        4394     4394
==========================================
+ Hits         4046     4052       +6
+ Misses        348      342       -6

Impacted Files
Coverage Δ

simulariumio/tests/conftest.py
100.00% <ø> (ø)

simulariumio/data_objects/agent_data.py
91.53% <100.00%> (+2.30%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


docs: add info about required commercetools scopes

Description
Add documentation about required commercetools scopes
Closes #141
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing
Created new commercetools API client with limited scopes (test-dd), updated envs on GCP (vsf-extension) and created a mollie order (ord_z1m5w4) through commercetools.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have updated the documentation where necessary
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works/doesn't break everything
[ ] Existing tests pass locally with my changes

Once https://github.com/mollie/commercetools/pull/160 is merged, view_customers should be added to required scope


redesign: cannot output this

I was trying the redesign branch, with this:
syntax test = function (ctx) {
  return #`this`;
}
test

Expected output: this. Actual output: undefined.

Actually, I just realized this is just the correct behavior of the babel backend. Sweet defaults to expanding a module and top-level this in a module is undefined as per the spec.
I just added a --no-babel flag to sjs if you don't want the babel backend to run.

Hm, interesting, thank you for clarifying.
I suppose I may have been misinterpreting how things work -- I'd been under the impression #this would just kind of count as a literal string of code not due to have its contents (except ${} interpolation) interpreted until run-time. If it is just resolved based on context, then fair enough though, that's admittedly just as good.
I'm interested in the babel interop, since it's hard not to use it if only for import. I tried forking the webpack loader after noticing the existing one didn't play nice with the redesign yet, but if you've already explored using sweet/babel together, I'd be glad to learn more about how you've been approaching this. I think the docs were still devoid of babel mentions so far; I imagine others may be curious as well..

I'd been under the impression #`this`  would just kind of count as a literal string of code

You have the right impression. The test macro expands to this just fine but then babel transforms the fully expanded source this to undefined. The same things happens if you run the following program through sweet:
this // transformed by babel to undefined

I think the docs were still devoid of babel mentions so far

Yep, on my list to write up. There's definitely some open questions there still. I'll open an issue once I write it up to get some feedback.


Cant send Mail Reason: "Smtp.ConnectAsync timeout" using OnlyOffice Mail Server

Hi I am using the OnlyOffice Mail server and getting some Problems sending Mail. The Error states
Reason: "Smtp.ConnectAsync timeout"
I checked the troubleshooting Guide but I dont know how to check the smtp server for its status as it is the OnlyOffice Mail server. Docker Container seems to run normally.
Do you know how to solve this issue?

Hello @dev-nm If you use Ubuntu 20.04 as host machine - you need to disable ufw firewall.


e2e, persistent-ip: Add primary-UDN tests

What this PR does / why we need it:
Since the same test portfolio is run for both secondary/primary UDN, we could either copy the entire tests for primary UDN (making a lot of duplicate code), OR try to join them. This PR is choosing the latter, joining both options (secondary and primary UDNs) to the same test suite.
The main change between the two is the way both tests retrieve the IPs from the VMI:
For secondary: retrieve the IPs from the VMI.Status
For primary UDN: retrieve the IPs from the pod's network-status annotation (this may change in future iterations).
This PR:

primes the e2e/persistentips_test.go for introduction of the primary-udn test cases.
adds the primary-udn test cases

With this change, we now cover ipam-extentions operation on VMI/VMs using primary-UDN.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

@qinqon I eventually did not parametize the generateVM function, as it also needs the nad.Name which is not static (randomized)... so this is the only place where we use If(role ==...). I can live with that, tell me what you think though.

Change: Address @qinqon + @maiqueb reviews

@RamLavi I would like to remove the other "if role == secondary" from the test by exposing the VMI build functios to the test struct, I know we say we were not going to do so, but it do not feel right, what do you think ?

@RamLavi I would like to remove the other "if role == secondary" from the test by exposing the VMI build functios to the test struct, I know we say we were not going to do so, but it do not feel right, what do you think ?

I'm game, I'll create a NewVMI function with options..

@RamLavi I would like to remove the other "if role == secondary" from the test by exposing the VMI build functios to the test struct, I know we say we were not going to do so, but it do not feel right, what do you think ?

DONE

/lgtm

Change: Fixed reviews. @maiqueb PTAL

Change: fixed dco issue

/hold cancel


Define CRDs for HTTPAPI and Quota spec and distribute to proxies

create corresponding CRD for HTTPAPISpec, HTTPAPISpecBinding, QuotaSpec, and QuotaSpecBinding (see https://github.com/istio/api/blob/master/mixer/v1/config/client/api_spec.proto)

add corresponding validation code for new model types

update istioConfigStore to select HTTPAPISpec and QuotaSpec config associated with destination service instances using the corresponding HTTPAPISpec and QuotaSpec bindings.

distribute the HTTPAPI and Quota spec to proxy as part of mixerclient filter configuration.

@ayj: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

That that this is a continuation of https://github.com/istio/old_pilot_repo/pull/1644 which was rebased from istio/pilot onto istio/istio.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5f164e756a43813e3238554b14b103ca223ac56f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
eea3d9c8d3750936444da258dfb16ee30998e208
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7fcdf2a337d33514f6c0c7c01e531b6605fd312d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
cee5d292c23faf01aa8236ac24633ae2017d5d8f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Agreed 100% on consistent codegen for our api-machinery. cc @gjwestlife


display viz mappings: equal parts RFC and PR

The jams.display submodule rocks but I've had to override the VIZ_MAPPING symbol table to use it with different namespaces, e.g. tag_open. I've taken the liberty of adding that one here, and alphabetizing the symbol table so we can add to it with some kind of convention going forward.
but!
this might be indicative of something we want to fix in general, and I'm curious to kick it around (here, I guess?). Should a namespace JSON file also specify how it should be visualized? seems like adding this info in two places is a design smell.
also: happy to move this to an issue first.

I've taken the liberty of adding that one here, and alphabetizing the symbol table so we can add to it with some kind of convention going forward.

I don't think it should be alphabetically or lexically ordered.  The choice of OrderedDict was intentional, and meant to reflect priority and specificity of the different annotation viz functions when multiple matches are possible. For instance, basically everything is convertible to tag_open, but you wouldn't want to use that viz for things where more precise displays are possible.
I agree that this is not well documented though, so we should improve on that.

(ping @ejhumphrey)  any thoughts on above?

@ejhumphrey can we close this one?

Reupping this one again: @ejhumphrey can you revert the ordering changes (with a comment to indicate that order reflects precedence of namespace coercion)?  Otherwise, I think tag_open should be a low-priority viz, so its placement at the end is fine.

Chatted with @ejhumphrey out of band.  We'll close this out and reopen as a new PR just with the added viz link.


Revert "[3.x] Spellcheck as part of CI"

Reverts predis/predis#1354.

@chayim @vladvildanov: Let's stick to PR reviews before merging them.


Scheduler statistics

This adds realtime statistics to the scheduler tasks:

execution time
average execution time
variance of execution time
maximum execution time
delay
average delay
variance of delay
maximum delay

The code is not compiling, could you fix that?

When Travis build issue is solved, you can merge the pull request, good job @jlecoeur!


Replace print with logger.log

Short Description:
Replaced the print function with the logger.log func.
@OpenPoGo/maintainers

:-1: We should replace print function everywhere if we are going to do this.
(venv) wchill@1337BookPro $ grep -rnw -e 'print' pokemongo_bot
pokemongo_bot/__init__.py:117:                        # print('need a rest')
pokemongo_bot/__init__.py:157:        # print('Response dictionary: \n\r{}'.format(json.dumps(response_dict, indent=2)))
pokemongo_bot/__init__.py:204:        print(inventory_req)
pokemongo_bot/__init__.py:235:                    print('[x] Transferring #{} ({}) with CP {}'.format(id, pokemon_name, group_cp[x]))
pokemongo_bot/__init__.py:376:                # print('item {}'.format(item))
pokemongo_bot/__init__.py:398:                # print('item {}'.format(item))
pokemongo_bot/cell_workers/pokemon_catch_worker.py:59:                                print total_IV
pokemongo_bot/cell_workers/pokemon_catch_worker.py:77:                                # print 'use Poke Ball'
pokemongo_bot/cell_workers/pokemon_catch_worker.py:82:                                    print('Great Ball stock is low... saving for pokemon with cp greater than 300')
pokemongo_bot/cell_workers/pokemon_catch_worker.py:84:                                    # print 'use Great Ball'
pokemongo_bot/cell_workers/pokemon_catch_worker.py:89:                                    print('Ultra Ball stock is low... saving for pokemon with cp greater than 700')
pokemongo_bot/cell_workers/pokemon_catch_worker.py:91:                                    # print 'use Utra Ball'
pokemongo_bot/cell_workers/seen_fort_worker.py:31:        # print('[#] Found fort {} at distance {}m'.format(fortID, dist))
pokemongo_bot/cell_workers/seen_fort_worker.py:144:        print x
pokemongo_bot/cell_workers/utils.py:100:    print(u'\033[92m' + message.decode('utf-8') + '\033[0m')
pokemongo_bot/cell_workers/utils.py:104:    print(u'\033[93m' + message.decode('utf-8') + '\033[0m')
pokemongo_bot/cell_workers/utils.py:108:    print(u'\033[91m' + message.decode('utf-8') + '\033[0m')
pokemongo_bot/logger.py:18:        print('[' + time.strftime("%Y-%m-%d %H:%M:%S") + '] ' + string)
pokemongo_bot/logger.py:20:        print(u'\033[' + colorHex[color] + time.strftime("%Y-%m-%d %H:%M:%S") + ' ' + string.decode('utf-8') + '\033[0m')
pokemongo_bot/stepper.py:57:                print('[#] {}'.format(position))
pokemongo_bot/stepper.py:131:                    # print(map_cells)
pokemongo_bot/stepper.py:132:                    # print( s2sphere.from_token(x['s2_cell_id']) )


Timeline Only Shows Events that are Specified in 24h Time

Describe the bug
When I specify an event in the day planner, if I don't put it into 24h time, it doesn't show up on the timeline
To Reproduce
Steps to reproduce the behavior:

Create an event from 14:00 - 15:00; notice that it shows up correctly
Create an event from 2:00 - 3:00 (same time as step 1, just 12h); notice that it doesn't show up

Expected behavior
It shows up the same as it does with 24h time
Screenshots

Additional context
The other plugins I have installed are Dataview, Iconize, and Tag Wrangler. I have also checked and made sure that all installed plugins and obsidian are on the latest version.

Another side effect of this bug that I just found is that when you have the "Default Timestamp Format" set to "hh:mm" (12h time) and you reorder an event on the timeline, it will change the markdown to be 12h as well, and therefore it will disappear from the timeline.

In my experience, it's not disappearing from the timeline, rather appearing at the AM time. E.g. an event set for 2PM will show up at 2AM.

This isn't a bug. It's more like a limitation of this time format: 2:00 is ambiguous if you don't add am/pm to it. So you should follow the advice above:

Change the time format to "hh:mmA" INSTEAD of "hh:mm" and the AM/PM part will be correctly parsed.


Update alert to common protocol

Fixes #7953

Please help review,thanks @paulidale

@paulidale This MR matched #15864 with the base updated ,Hope could be reviewed,thanks.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This pull request is ready to merge

Merged - thanks @KanPlus for this contribution, @paulidale for the other approval,
and also @richsalz and @levitte for the discussion on #7953.

Merged - thanks @KanPlus for this contribution, @paulidale for the other approval, and also @richsalz and @levitte for the discussion on #7953.

This confused me for long time, thanks for the discussion and the review.

Nice changes. Sorry that final approval took rather long.

Thank you.


Migrate remove pods violating node taints to plugin with 860

Rebasing https://github.com/kubernetes-sigs/descheduler/pull/860 and https://github.com/kubernetes-sigs/descheduler/pull/861
/hold
Testing PR. Not intended to be merged.

Closing as https://github.com/kubernetes-sigs/descheduler/pull/857 merged.


Persist Zino device state to disk

Device state should be persisted to a disk file on set intervals (and later, on demand). This state should be loaded from disk whenever the daemon starts up as well. Same as #21, just with device state instead of event state.

ATM there is both event state and device state, and these exist as global variables in zino.state  There is potentially other state items that are keyed on things like IP addresses as well (e.g. the mapping from IP addresses to routers).
The best course of action might actually be to create some sort of ZinoState class (using PyDantic) to hold all the items we want to serialize/deserialize to/from disk.


Rename labels for upgrade sections.

I showed the site to 2 different people that know very little about Decred and one of the immediate observations was that PoW and PoS are confusing.  It was also not clear that the sections were referring to upgrading.  Both of these can be improved by renaming the labels as follows:

Fixed in recent commit


fix(ibm-combo-box): show list of new items that match current search

removed setTimeout from updateList method inside the dropdown list component which was delaying the execution of the closeDropdown method inside the combo box component until after the openDropdown method was called
updated combo box component to filter dropdown list items by the current search string when new items are passed into the combo box component
updated dropdown component to run code inside the Angular zone to force a change detection cycle to take place rather than calling tick method on the application reference as the tick call was throwing an error after the change to the dropdown list was introduced

Closes carbon-design-system/carbon-components-angular#2426

I have read the DCO document and I hereby sign the DCO.


F3 syscfg / comp / opamp

split stm32f3 syscfg_comp_opamp into 3 separate devices, syscfg, comp and opamp to match the datasheet and fix all registers that need to be fixed.

There's a few bits where we could use the new _split etc but on the whole I think best to just get it merged first.


Update Syncthing to 0.12.2

Thank you for the contribution. It was merged directly as 45670a6aacf400773376c2279e17d1c7440be585 to keep commit history cleaner. Your contribution is still credited to you.


Fix connectivity checking

If default route loses connectivity, all DNS requests will fail. Connectivity checking for new connections will also fail even if they have access to Internet. So custom domain name resolving bound to checked interface is added

Новый код написан, а тестами не покрыт, покрытие connection_manager упало до 93.80%.


Projection

I look this morning into this problem and find, that Mapsui isn't clear about transformations, projections and CRS.
If I'm correct (which could be wrong) than Mapsui uses internally EGSP:3857 as coordinat system. This should be set in Map.CRS by default and readonly. Than each layer could have its own projection at Layer.CRS. That's ok. To transform coordinates from layer to map, there should be an entry in Map.Transformation for each possible CRS in Layers or Layer.Transformation should be capable of converting between Layer.CRS and "EGSP:3857". This should be checked in Layers.Add. If there isn't a transformation, the layer shouldn't be added to Layers. If layer doesn't need any transformation (Layer.CRS is "EGSP:3857"), identity transformation should be added. Up to now, Map.CRS is copied to Layer.CRS when adding the layer (see Map.cs, line 245: LayersLayerAdded). This isn't correct and should be removed
It should be decided, if results of events like clicks and so on and other functions should be converted into the projection, the layer that contains them, has or if the user should do this.

Sorry for not being very response lately. Even today I still don't have time to look into this, but a brief reaction.
Mapsui has no specific internal coordinate system. The data in a layer is always in some coordinate system however. Take for instance the OpenStreetMap layer that is used in many samples. It's data is in SphericalMercator (EPSG:3857). The data is just shown 'as is' in the Map and as a consequence the Map is in EPSG:3857.
Mapsui has no mechanism to project from the coordinate system of the Layers to the Map. So all Layers should be in the same coordinate system.
Mapsui has a mechanism to project from a Provider to a Layer. So if you have data in another projection you should put that data in a provider and

define the CRS of that provider,
define the CRS of the map
Add Transformation to the map
(the the ProjectionSample).

In general I like the mechanism described above. What I don't like about this mechanism is that the Map's CRS/Transformation needs to be copied to the layer. Perhaps this information should be provided by a general data fetcher.
Also there may be some points at which this logic is not correctly implemented. I think it now works correctly for the Layer.Envelop but there might be similar points where we miss out on project. The RasterizingLayer for instance fails when it needs to reproject.

Perhaps we should have a BaseLayer, which is the Layer for the main map. This sets the projection for the whole map. All othere layers must provide a transformation from/to their projection to the projection of this base map. If not, they aren't added.

Projection should be improved after we start using NTS.


docs(configuration): fix a misspelled output.sourcePrefix's description.

as-is
sourcePrefix: "\t"
// prefix module sources in bundle for better readablitity

to-be
sourcePrefix: "\t"
// prefix module sources in bundle for better readability

Yeah, it's a typo. Thanks for fixing it.

Yeah, it's a typo. Thanks for fixing it.


Refactor and new feature

Refactor vertical move handler
Add restart feature by pressing "r" button

Hi @mahdiarn, thanks for making this PR. Sorry it's taken me so long to check it out, I haven't had access to a Mac quite a while. I'll take a look at this now and get back to you.

Hi @mahdiarn, I've finally got round to reviewing this PR. Unfortunately, I can see little benefit in your refactor; it, if anything, makes the code harder to read than before.
Sticking arbitrary parts of the code into functions with no arguments, which are called only once, means that if I were to want to make or review changes in that part of the code, I would have to track them down by following the function call breadcrumbs you've left for me, instead of intuitively finding them in the place they run. I would see benefit to such a refactor if you were to use it as an opportunity to reorganise the layout of the codebase, perhaps clearly separating the handlers you've created into a separate file, allowing for the easy viewing and editing of the code contained within, as opposed to the currently presented random assortment of functions strewn across GameScene.swift (I do think that such a change is overkill here though, it just serves as an example). Additionally, the handlers don't need 'handle' in their names - it's implied, and the function names already contain verbs e.g. restartGame instead of handleRestartGame.
I'd be more than happy to accept this PR if you sort out the refactored functions, as restart functionality is something I need to add, as per issue #13. I would suggest that perhaps comments would be a suitable way of indicating the function of the code blocks you've singled out, rather than individual functions.
I understand that not all of my original codebase follows this guideline, but that's because I never considered that other people would see it. It's my aim to slowly move this project away from spaghetti, so that others like you can contribute and pick up my (plentiful) slack. I really appreciate the time and effort you've put into this PR, and hopefully the changes I've outlined can help get it merged quickly.

Closing due to inactivity.


Local development environment

Running virtual machine in the cloud just to test the change in the playbook is time consuming.
Better way is to test changes locally before applying them to master branch. There are two possible ways of doing this:

vagrant with VirtualBox & Ansible provisioners
vagrant with Docker & Ansible provisioners

Both options use Ubuntu images similar to those used in the cloud.
The second option is faster and require less resources.
Does this project use some kind of local testing already?
The workflow will look like:

Make a change to a playbook
vagrant up runs Docker container and applies playbook to this container
Check the result (manually for now, run integration tests in the future)
vagrant down tears down the container
Commit the change (pre-commit hook runs linter and syntax checks)

Unfortunately we don't have auto-tests yet for different node types, but at least automatic node setup in a container and running playbook would be great


Opt out of gradle module metadata

Module metadata is currently used based on versions.locks information, however this makes it impossible to roll back dependency versions with GCV in cases where repositories have circular dependencies.
==COMMIT_MSG==
Opt out of gradle module metadata to resolve issues with error-prone dependency versions
==COMMIT_MSG==

Released 1.11.0


Genotype a VCF

Genotype a VCF against a multicolour graph. Much of the work has already been done in ctx_geno.c.

Now done as part of McCortex pipeline.


Increase time when file is sent for download

I have some time to write you a problem of qbitcontroller in all version until now. If the qbicontroller is not use for a while(not open) when I click on a torrent file to sent it for download, the app time for open and authetificate is bigger than the sent file time. I mean I click on torrent the qbittcontroller open (but not authetificate)and imediatly the file is sent for download. Then qbittorrencontroller authentificate, but the torrent file is not in download list.Then I must exit the app and click again on torrent file and send it to dowload. Second time allways work because the app is running in the background and is loged in.
My sugestion is to increase the time when the file is sent for download , because sometime when the app starts the time is longer than the time of file beeing sent.

Done!


Publish for 0.18

Could you publish this package for Elm 0.18? Or @evancz's repo.
$ elm --version
0.18.0
$ elm-package install elm-lang/regex
Error: Could not find any packages named elm-lang/regex.
$ elm-package install evancz/regex
Error: Could not find any packages named evancz/regex.

I'm looking for a function String -> Maybe Regex and found this repo from https://github.com/elm-lang/core/issues/722 after the core Regex.regex let me down. I'm very new to Elm so forgive me if this is a misguided request.

I tried to work around this issue for the time being by vendoring this regex project into my repo using this method. But then ran into a snag where it conflicted with the 0.18 Regex package. If there was a way to simply import as Regex2 that would work. Next step is renaming all the occurrences of Regex with Regex2 in my local copy. So this is another case for https://github.com/elm-lang/elm-compiler/issues/1625.

Hey, sorry you are running into trouble along these lines. These cases is part of what motivated the new API! But this package is slated to come out with 0.19 due to a confluence of other factors. One thing you could do in the meantime is override what new RegExp means in the context where you run Elm. Perhaps like this:
(function() {
function RegExp(str, settings) {
    try {
        return new window.RegExp(str, settings);
    } catch(e) {
        return /.^/;
    }
}
// elm program
}())

Obviously this is not ideal at all, but coordinating an Elm release is quite tricky, and I think something like the code shown here may be the best thing viable until the release is possible.


Delete gopath-test taskrun example / YAML test

Changes
This example doesn't demonstrate much, and it's the longest-running YAML
test at about 3-5 minutes. It was copied over from knative/build days
and hasn't seen many updates since.
The example clones github.com/tektoncd/pipeline into a targetPath within
$GOPATH and runs go test ./... on it, which is what takes so long.
If we decide this example is worth keeping around, we should probably at
least change the repo to something smaller and quicker to test, or
change go test to just go build to save time.
Submitter Checklist

[y] Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
[y] Commit messages follow commit message best practices

As long as we have other tests using targetPath which I think we do!
/lgtm
/meow space

im going to have to start finding my own space cats


add 2 items to events page

youth camp june 18-25
Mother's Day @ Lifestone May 13

Is there any more info about Mother's Day?


Template Question & Attachment Issue

Hey,
So at first is it possible to change the html theme/template?
I would like to improve it and customize it.
Second I'm experiencing a little problem with attachments.
https://prnt.sc/FnpjdIlzOYr9
And the url that it goes to
https://prnt.sc/JMMAbJudUmDh
Not sure what the issue is here. Or why it is acting up like this.
-Wolf

Can you show the full error shown in the 2nd image?
Also make sure you are running the latest version of discord.js

Yes,
This is the error
https://prnt.sc/yysDeSWhesYf

the original message/image was deleted, therefore, discord deleted it from their servers.
if you need the images saved with the transcript, check out the saveImages option.

Ah alright. Thanks. I totally forgot you had options, my bad.


Node: Fix logic of has/get_node_and_resource and document it

Also document NodePath.

While attempting to document Node.has/get_node_and_resource, I found that its behavior is quite unintuitive, as the has method would basically always return true for a valid NodePath (even when not pointing to a valid resource), while the get method would only return the designated resource when using a trailing colon or accessing a property of that resource.
I did some extensive tests and I now have a behavior which seems to match what one would expect (and what I thus documented). It looks like the weird distinction between resource and property in NodePath has been mostly lifted by @bojidar-bg in 0cf9597758f3af3afc951d0bf02dee1aeb9a6daf, so I think this should work fine now.
I haven't tested complex animations extensively to make sure that they are still parsed as they should though.
Test project
Node-get_node_and_resource.zip
extends Node2D

export (Dictionary) var my_dict = { "key1": load("res://icon.png") }

# Called when the node enters the scene tree for the first time.
func _ready():

	# Invalid node
	print("WrongName")
	print(has_node_and_resource("WrongName"))
	print(get_node_and_resource("WrongName"))
	print("WrongName:size")
	print(has_node_and_resource("WrongName:size"))
	print(get_node_and_resource("WrongName:size"))

	# Non-resource in valid node
	print("Area2D:gravity_vec")
	print(has_node_and_resource("Area2D:gravity_vec"))
	print(get_node_and_resource("Area2D:gravity_vec"))
	print("Area2D:gravity_vec:y")
	print(has_node_and_resource("Area2D:gravity_vec:y"))
	print(get_node_and_resource("Area2D:gravity_vec:y"))

	# Valid resource in valid node
	print("Area2D/CollisionShape2D:shape")
	print(has_node_and_resource("Area2D/CollisionShape2D:shape"))
	print(get_node_and_resource("Area2D/CollisionShape2D:shape"))
	print("Area2D/CollisionShape2D:shape:extents")
	print(has_node_and_resource("Area2D/CollisionShape2D:shape:extents"))
	print(get_node_and_resource("Area2D/CollisionShape2D:shape:extents"))
	print("Area2D/CollisionShape2D:shape:extents:x")
	print(has_node_and_resource("Area2D/CollisionShape2D:shape:extents:x"))
	print(get_node_and_resource("Area2D/CollisionShape2D:shape:extents:x"))

	# Valid nested resource in other resource's custom script
	print("Area2D/CollisionShape2D:shape:my_texture")
	print(has_node_and_resource("Area2D/CollisionShape2D:shape:my_texture"))
	print(get_node_and_resource("Area2D/CollisionShape2D:shape:my_texture"))
	print("Area2D/CollisionShape2D:shape:my_texture:load_path")
	print(has_node_and_resource("Area2D/CollisionShape2D:shape:my_texture:load_path"))
	print(get_node_and_resource("Area2D/CollisionShape2D:shape:my_texture:load_path"))
	print("Area2D/CollisionShape2D:shape:my_texture:wrong_subname")
	print(has_node_and_resource("Area2D/CollisionShape2D:shape:my_texture:wrong_subname"))
	print(get_node_and_resource("Area2D/CollisionShape2D:shape:my_texture:wrong_subname"))

	# Dictionary with resource key (not supported)
	print(".:my_dict")
	print(has_node_and_resource(".:my_dict"))
	print(get_node_and_resource(".:my_dict"))
	print(".:my_dict.key1")
	print(has_node_and_resource(".:my_dict.key1"))
	print(get_node_and_resource(".:my_dict.key1"))

	# Property of Node type, doesn't count as resource (as expected)
	owner = get_tree().get_root()
	print(".:owner")
	print(has_node_and_resource(".:owner"))
	print(get_node_and_resource(".:owner"))

Before this PR
WrongName
False
ERROR: get_node: Node not found: WrongName
   At: scene/main/node.cpp:1382.
[Null, Null, ]
WrongName:size
False
ERROR: get_node: Node not found: WrongName:size
   At: scene/main/node.cpp:1382.
[Null, Null, ]
Area2D:gravity_vec
True
[[Area2D:1134], Null, :gravity_vec]
Area2D:gravity_vec:y
True
[[Area2D:1134], Null, :gravity_vec:y]
Area2D/CollisionShape2D:shape
True
[[CollisionShape2D:1135], Null, :shape]
Area2D/CollisionShape2D:shape:extents
True
[[CollisionShape2D:1135], [RectangleShape2D:1127], :extents]
Area2D/CollisionShape2D:shape:extents:x
True
[[CollisionShape2D:1135], [RectangleShape2D:1127], :extents:x]
Area2D/CollisionShape2D:shape:my_texture
True
[[CollisionShape2D:1135], [RectangleShape2D:1127], :my_texture]
Area2D/CollisionShape2D:shape:my_texture:load_path
False
[[CollisionShape2D:1135], [RectangleShape2D:1127], :my_texture:load_path]
Area2D/CollisionShape2D:shape:my_texture:wrong_subname
False
[[CollisionShape2D:1135], [RectangleShape2D:1127], :my_texture:wrong_subname]
.:my_dict
True
[[Node2D:1130], Null, :my_dict]
.:my_dict.key1
True
[[Node2D:1130], Null, :my_dict.key1]
.:owner
True
[[Node2D:1130], Null, :owner]

After this PR
WrongName
False
ERROR: get_node: Node not found: WrongName
   At: scene/main/node.cpp:1396.
[Null, Null, ]
WrongName:size
False
ERROR: get_node: Node not found: WrongName:size
   At: scene/main/node.cpp:1396.
[Null, Null, ]
Area2D:gravity_vec
False
[[Area2D:1160], Null, :gravity_vec]
Area2D:gravity_vec:y
False
[[Area2D:1160], Null, :gravity_vec:y]
Area2D/CollisionShape2D:shape
True
[[CollisionShape2D:1161], [RectangleShape2D:1156], ]
Area2D/CollisionShape2D:shape:extents
True
[[CollisionShape2D:1161], [RectangleShape2D:1156], :extents]
Area2D/CollisionShape2D:shape:extents:x
True
[[CollisionShape2D:1161], [RectangleShape2D:1156], :extents:x]
Area2D/CollisionShape2D:shape:my_texture
True
[[CollisionShape2D:1161], [RectangleShape2D:1156], :my_texture]
Area2D/CollisionShape2D:shape:my_texture:load_path
True
[[CollisionShape2D:1161], [RectangleShape2D:1156], :my_texture:load_path]
Area2D/CollisionShape2D:shape:my_texture:wrong_subname
True
[[CollisionShape2D:1161], [RectangleShape2D:1156], :my_texture:wrong_subname]
{key1:[StreamTexture:1152]}
.:my_dict
False
[[Node2D:1159], Null, :my_dict]
.:my_dict.key1
False
[[Node2D:1159], Null, :my_dict.key1]
.:owner
False
[[Node2D:1159], Null, :owner]

Some of the documentation changes can be cherry-picked, but not the logic changes.

Cherry-picked for 3.1.2. (Only the NodePath.xml changes.)


R client

Currently only supported from the master branch of swagger codegen. See the created project here: https://github.com/graphhopper/directions-api-clients/tree/master/r
Will close here when the official swagger codegen release is reported to be usable.

Can someone help me on how to install the graphhopper in R.
I get the following error : Error: Could not find package root. when I tried the "library(devtools)
install(".")"
I want to plot routes of multiple nodes starting from an origin through several destinations and ending in the same origin.
Thanks\

@Anyaoha you may also check/test crazycapivara/graphhopper-r.


Added MASES.EntityFrameworkCore.KNet: a provider based on Apache Kafka

This PR adds MASES.EntityFrameworkCore.KNet in the list of available providers. This provider aims to use Apache Kafka as back-end of any application based on Entity Framework Core.
Moreover the provider adds some extra features at zero cost like events and distributed cache.

Hi @roji, @ajcvickers, @AndriySvyryd I'm not able to directly set a reviewer and I found your names as reviewers in some PRs.

Thanks!


check default generator for windows

Generator Ninja does not support platform specification but platform -A x64 was specified. when trying to build ollama.

I believe this should be resolved by #2885 but there might be some additional minor adjustments necessary.

Should be fixed by #2885


melos run starknet:setup display ERROR log for cargo install

Describe the bug
Logs from cargo install are logged as ERROR when running melos run starknet:setup
To Reproduce
Steps to reproduce the behavior:

melos run starknet:setup
In console log lines from cargo install are logged as ERROR

Expected behavior
cargo install output shall not be logged as ERROR

Root cause of this issue is cargo install logging on stderr and melos assuming stderr output is error only


Random user client side crashing on Tekkit 2 Server

Forge Version
<IP_ADDRESS>60
Galacticraft Version
4.0.3-Tekkit-2-Build
Log or Crash Report
This is listed from another ticket I am with on Tekkit 2: https://github.com/xJon/Tekkit-2/issues/69
"So a day of testing with lots of ideas and going through many things, we have found some culprits to the issue
Player models are spawned multiple times and classed as "Unknown" which causes the crashes, such as the one provided by a player: Retry entities: 3 total; [EntityLatchedRenderer['unknown'/2101909, l='MpServer', x=-1.76, y=64.00, z=0.48], EntityLatchedRenderer['unknown'/2106662, l='MpServer', x=-142.67, y=67.00, z=486.75], GCEntityOtherPlayerMP['blikakis'/40366, l='MpServer', x=-142.67, y=67.00, z=486.75]]
We located the entity and could not remove it, though a reload of the server will clear all these entities, we tested to see about unloading and reloading of chunks when these happen, to which yes, when a chunk is reloaded and this missing entity is detected it will cause a crash.
I have attempted to load in many cleanup tools to stop the crashes, a plugin called CatLagClear managed to help but this cleaned up the server every 10 mins, not exactly the best because I have to use a plugin loader called Sponge so this makes me instantly in the fault as it is not what you originally made for the server, but I am trying many ideas.
So something is causing these creations of entities when players disconnect from the server and well clients are not cleaning up the players, this is theoretically what I see causing the issue but cannot pinpoint the crashes just yet, we will keep looking into this to find the issue, we are also removing and adding mods on clients to help."
We have already tested disabling "enableLatchedRendererSpawn" in "ichunutil.cfg" but no luck, xJon suggested it could be "GCEntitiyOtherPlayerMP"?
Tekkit 2 Crashes with logs, collected a lot!
Had others crash, their logs are:
https://mclo.gs/5BGP1dn
https://mclo.gs/OcWwrYn
https://mclo.gs/SPCcMOh
https://mclo.gs/3p4ZQzO
https://mclo.gs/m5ZWy3p
https://mclo.gs/1tVR0yG
https://mclo.gs/a4b3kUi
https://mclo.gs/2CcTLCz
https://mclo.gs/FjIEff9
https://mclo.gs/Ly0y7U9
https://mclo.gs/Mra84MR
https://mclo.gs/27jidA0
My logs:
https://mclo.gs/bx97kWM
https://mclo.gs/yD2d4Lv
https://mclo.gs/yWzcKC8
https://mclo.gs/FlrXYdn
Reproduction steps

Do this
Do that
Crash/Bug
...
Join a Tekkit 2 server, have around 20 players
Play for over a week continiously and slowly overtime as players went around planets it started happening
It just crashes at random times, though the same or similar errors occur, I cannot explain it fully but if you wish to join the server to experience it yourself you may.

Can we check if the issue here is still present with the latest release?


No system proxy detection on MacOS

On MacOS 10.13.6 with Mattermost 4.2.0, system proxy settings are not taken into account when using "auto proxy discovery" option in MacOS network settings. Not sure if it's a bug or if I am doing something wrong.
I could use the --proxy-pac-url=<URL> option, but I would prefer to use directly system settings.
Thanks.
Guillaume

Opened a ticket here for tracking: https://mattermost.atlassian.net/browse/MM-14462.

@yuya-oc any thoughts on this?

Hi @guillaumesamson, do you know if this applies only to macOS? Does it work on Windows/Linux?

Hi @guillaumesamson. I setup Squid (via SquidMan) on OSX, and manually configured the Web Proxy and Secure Web Proxy accordingly. I confirmed that the desktop app connects through the proxy successfully, and when the proxy is stopped, it fails with ERR_PROXY_CONNECTION_FAILED.
It seems that the desktop app honours the system proxy settings. If the Auto Proxy Discovery is not working for you, I'm inclined to think it's a setup issue. If you can provide additional details on what's going wrong in your case and how the desktop app is at fault, we'd be happy to help investigate further!


Image upload not fully working

Sometimes an image uploads successfully but once you try to access it it fails

There seem to be many issues with uploading multiple images on wagtail. I have opened a support ticket here https://groups.google.com/forum/#!topic/wagtail/-27E0iEvmcs
I did update the version of wagtail which at least makes sure the image is uploaded despite hanging once the image is uploaded. We also moved from heroku to DO which gives us more flexibility on managing the webserver.

Seems the issue was to do with my old static files. I run collectstatic again and I can now upload large images (Largest tested was 7Mb)


changefeed status don't become error when broker unavaible

What did you do?

Creating a changefeed with kafka sink
Run workload for 1 hour
Stop broker and zookeeper

What did you expect to see?
Changefeed status becomes to error and report error msg.
What did you see instead?
After 10+ hours, changefeed status is still normal, only cdc.log has error msg.
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)
5.3.0

Upstream TiKV version (execute tikv-server --version):
(paste TiKV version here)
5.3.0

TiCDC version (execute cdc version):
(paste TiCDC version here)
5.3.0

This issue has been fixed by this pr.

Yes, it can be closed.


Remove<EMAIL_ADDRESS>

Related: https://github.com/OnsenUI/OnsenUI/issues/2674

@emccorson
I removed 2.10.9 tag from this repo, and it was successfully removed in JS/CSS Component dialog 👍

If more action is needed, please inform me. Thank you.


yarn v2 support

[ ] The repository it-self
[ ] textlint packages (I do not confirm the support)

#989


syntax error in sudoers file

I get a syntax error at the end of the line of scripting addition when editing the sudoers.d/yabaifile. Can't figure out why. Any advice?

maybe trailing whitespace

that is what i thought but there is no white-spacing at the end. Weird.

There should be a newline after it.

@ChristianBingman thanks for your response. There is no new line. I tried both Vim and NeoVIm for editing but same issue. How did you fix it?
This is the file. ( I added txt extension to be able to upload it into github.)
yabai.txt

yaay! I was able to fix it. I deleted the sudoers.d folder and yabai file. Then I created the folder (mkdir) and yabai file (sudo visudo) with Vim in MacOS default terminal app and it worked. I was using alacritty so not sure what caused the issue.


feat(MeasureTheory/Function): Uniform tightness of functions in Lp

Also includes a logical renaming of the finite measure version in UniformIntegrable.lean.
To be subsumed by #9163, which contains the actual proofs.

Just to clarify, how self contained should this PR be (given that it should be subsumed by #9163)? I could just remove anything not directly pertaining to the UnifTight definition, including the formalization of the statement of the general Vitali Convergence Theorem (it's sorry-ed here because the proof takes up all of #9163).

It should be self-contained and only pertain to uniform tightness

OK, I've made the PR as much self contained as I think it makes sense.

Can you merge master to reduce the diff?

Can you merge master to reduce the diff?

Done. The build is marked as failed because of a linter complaint, which I'm not sure what to do about.
Also, I was undecided about choosing a proof for unifTight_iff_real. Please have a look.

The build is marked as failed because of a linter complaint, which I'm not sure what to do about.

You need to run lake exe lint_style --update

I was undecided about choosing a proof for unifTight_iff_real.

I like the second one better. Also note that you can(/should?) incorporate the exact into the refine.

The build is marked as failed because of a linter complaint, which I'm not sure what to do about.

You need to run lake exe lint_style --update

That reproduces the same error locally, I think. Anyway the linter seems to be suggesting splitting MeasureTheory/Integral/Lebesgue.lean because it has grown too large. This patch adds about 50 lines to that file, which could potentially be moved elsewhere, but the file would still remain large. If a similar amount of code would be added to it on another occasion, the same error would come up. Perhaps it requires some higher level decisions about potentially splitting the file in a fine grained way. I don't feel qualified to decide that.

@grunweg, what are we doing wrong? Shouldn't lake exe lint_style --update update the lint style file?

@grunweg, what are we doing wrong? Shouldn't lake exe lint_style --update update the lint style file?

That is implemented in #14697, which needs to be reviewed :-) Right now, the --update option does not quite do that yet. (I'm silently changing the behaviour of --update in that PR, on the grounds that the current behaviour is not what you want.)

@igorkhavkine, can you run scripts/update-style-exceptions.sh

That last commit was unexpected... I just pushed a fix to the style exceptions file.

Thanks!
bors merge


MSWebdriver ignores currently installed version of Edge and fetches the latest available binary.

I am already working on a PR to fix this, but submitting this here in case anyone runs into this issue.
Microsoft recently released a new webdriver version 6.17134 for Edge 17.17134. If you are using this gem to launch an older version, say 16.16299, Selenium will fail to launch the browser with this error:
#<Errno::ECONNREFUSED: Failed to open TCP connection to localhost:17556 (No connection could be made because the target machine actively refused it. - connect(2) for "localhost" port 17556)>

This is because v3.3.0 of this gem is downloading the latest version and ignoring the installed version of Edge.  The fix is to download the webdriver version that matches the installed version of Edge. I'll submit a PR to fix this.
Workaround: Download the binary manually and or upgrade your Edge version.

Submitted PR #15 to fix this.

PR #15 merged


Memory problems after BN1.1 -> BN 4.1 -> BN1.2

The helper scripts constantly run out of memory after I went the route in the subject.
Example:
`RUNTIME ERROR
faction-manager.js@home (PID - 1491)
Args: ["--verbose", "false"]
Run command returned no pid (command likely failed to run).
Command: let result="";try{result=JSON.stringify(
ns.getOwnedAugmentations(true)
);}catch(err){result = "ERROR: " + (typeof err === 'string' ? err : err.message || JSON.stringify(err))}
const f="/Temp/player-augs-purchased.txt"; if(ns.read(f)!==result) await ns.write(f,result,'w')
Temp Script: /Temp/player-augs-purchased.txt.js
Ensure you have sufficient free RAM to run this temporary script.
stack:
autoRetry@home/helpers.js:290:51`
Also, progress at start of the new BN seems really slow - what could I do better?

This is expected behaviour. You'll see almost all SF4 scripts spit out a warning at start if you only have 4.1. I suggest you dont use them until youve upgraded home RAM to 256 and run daemon with  --reserve-ram 256, or flume out and do BN 4 2 more times.

For advice on what to do at the start of a new BN to speed things along I recommend discussing in the game Discord. I find autopilot.js takes care of it plenty fast, as long as you have enough SF4 levels.


CUDA error: out of memory when synchronize between processes on refexp at evaluation stage

Hi,
Thanks for your great work.
I met the OOM error at the evaluation stage after first epoch pretraining. The log is
Test: Total time: 0:01:42 (0.2476 s / it)
Averaged stats: loss: 113.5333 (96.1866)  loss_bbox: 0.5625 (0.5173)  loss_bbox_0: 0.6505 (0.5977)  loss_bbox_1: 0.5762 (0.5255)  loss_bbox_2: 0.5703 (0.5273)  loss_bbox_3: 0.5712 (0.5109)  loss_bbox_4: 0.5651 (0.5138)  loss_ce: 11.5826 (9.1250)  loss_ce_0: 11.4480 (9.4460)  loss_ce_1: 11.7980 (9.5058)  loss_ce_2: 11.8104 (9.4749)  loss_ce_3: 11.6550 (9.2512)  loss_ce_4: 11.5774 (9.0949)  loss_contrastive_align: 6.1482 (5.6187)  loss_contrastive_align_0: 6.1950 (5.8909)  loss_contrastive_align_1: 6.1946 (5.7864)  loss_contrastive_align_2: 6.1133 (5.7674)  loss_contrastive_align_3: 6.1261 (5.6713)  loss_contrastive_align_4: 6.0199 (5.5644)  loss_giou: 0.4890 (0.4578)  loss_giou_0: 0.5642 (0.5090)  loss_giou_1: 0.5024 (0.4579)  loss_giou_2: 0.4965 (0.4619)  loss_giou_3: 0.5086 (0.4525)  loss_giou_4: 0.4900 (0.4579)  cardinality_error_unscaled: 8.3906 (4.8554)  cardinality_error_0_unscaled: 6.5000 (4.3573)  cardinality_error_1_unscaled: 9.4062 (5.9682)  cardinality_error_2_unscaled: 10.3125 (6.3725)  cardinality_error_3_unscaled: 9.2969 (5.2416)  cardinality_error_4_unscaled: 8.8281 (5.0047)  loss_bbox_unscaled: 0.1125 (0.1035)  loss_bbox_0_unscaled: 0.1301 (0.1195)  loss_bbox_1_unscaled: 0.1152 (0.1051)  loss_bbox_2_unscaled: 0.1141 (0.1055)  loss_bbox_3_unscaled: 0.1142 (0.1022)  loss_bbox_4_unscaled: 0.1130 (0.1028)  loss_ce_unscaled: 11.5826 (9.1250)  loss_ce_0_unscaled: 11.4480 (9.4460)  loss_ce_1_unscaled: 11.7980 (9.5058)  loss_ce_2_unscaled: 11.8104 (9.4749)  loss_ce_3_unscaled: 11.6550 (9.2512)  loss_ce_4_unscaled: 11.5774 (9.0949)  loss_contrastive_align_unscaled: 6.1482 (5.6187)  loss_contrastive_align_0_unscaled: 6.1950 (5.8909)  loss_contrastive_align_1_unscaled: 6.1946 (5.7864)  loss_contrastive_align_2_unscaled: 6.1133 (5.7674)  loss_contrastive_align_3_unscaled: 6.1261 (5.6713)  loss_contrastive_align_4_unscaled: 6.0199 (5.5644)  loss_giou_unscaled: 0.2445 (0.2289)  loss_giou_0_unscaled: 0.2821 (0.2545)  loss_giou_1_unscaled: 0.2512 (0.2289)  loss_giou_2_unscaled: 0.2483 (0.2309)  loss_giou_3_unscaled: 0.2543 (0.2263)  loss_giou_4_unscaled: 0.2450 (0.2289)
gathering on cpu
gathering on cpu
gathering on cpu
Traceback (most recent call last):
  File \"main.py\", line 655, in <module>
    main(args)
  File \"main.py\", line 598, in main
    curr_test_stats = evaluate(
  File \"/usr/local/lib/python3.8/site-packages/torch/autograd/grad_mode.py\", line 26, in decorate_context
    return func(*args, **kwargs)
  File \"/worksapce/mdetr/trainer/engine.py\", line 230, in evaluate
    evaluator.synchronize_between_processes()
  File \"/worksapce/mdetr/trainer/datasets/refexp.py\", line 38, in synchronize_between_processes
    all_predictions = dist.all_gather(self.predictions)
  File \"/worksapce/mdetr/trainer/util/dist.py\", line 86, in all_gather
    obj = torch.load(buffer)
  File \"/usr/local/lib/python3.8/site-packages/torch/serialization.py\", line 594, in load
    return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
  File \"/usr/local/lib/python3.8/site-packages/torch/serialization.py\", line 853, in _load
    result = unpickler.load()
  File \"/usr/local/lib/python3.8/site-packages/torch/serialization.py\", line 845, in persistent_load
    load_tensor(data_type, size, key, _maybe_decode_ascii(location))
  File \"/usr/local/lib/python3.8/site-packages/torch/serialization.py\", line 834, in load_tensor
    loaded_storages[key] = restore_location(storage, location)
  File \"/usr/local/lib/python3.8/site-packages/torch/serialization.py\", line 175, in default_restore_location
    result = fn(storage, location)
  File \"/usr/local/lib/python3.8/site-packages/torch/serialization.py\", line 157, in _cuda_deserialize
    return obj.cuda(device)
  File \"/usr/local/lib/python3.8/site-packages/torch/_utils.py\", line 79, in _cuda
    return new_type(self.size()).copy_(self, non_blocking)
  File \"/usr/local/lib/python3.8/site-packages/torch/cuda/__init__.py\", line 462, in _lazy_new
    return super(_CudaBase, cls).__new__(cls, *args, **kwargs)
RuntimeError: CUDA error: out of memory

I use 32G V100 GPUs, with 2 samples per GPU following default settings.
I also set CUBLAS_WORKSPACE_CONFIG=:4096:8 MDETR_CPU_REDUCE=1.

Kindly ping @alcinos @ashkamath
I found a similar issue https://github.com/ashkamath/mdetr/issues/40.
Any help would be much appriciated. Please let me know if you need further information.

Did you try the solution in #40, namely

Try setting the env variable "MDETR_CPU_REDUCE" to "1", this should help with memory during reduce

Hi, @alcinos
Thanks for your reply.
As mentioned above, I have set CUBLAS_WORKSPACE_CONFIG=:4096:8 MDETR_CPU_REDUCE=1.

Appologies, I missed that.
I’m a bit puzzled why this is happening for you. Maybe you can try forcing the predictions to cpu at the end of the postprocessors
Specifically, after this assert, https://github.com/ashkamath/mdetr/blob/0b747b99e2995c3c429f1391cb8e6104eaec7f21/models/postprocessors.py#L150
move scores, labels and boxes to cpu.
Hope this helps

@alcinos Thanks.
I'll try it.

Hi, @alcinos
I found a related bug and pull a request https://github.com/ashkamath/mdetr/pull/42.
Please have a check.
Thanks.

Suffered the same bug. How was it resolved? Thank you!

Hi, @linhuixiao ,
I solved this problem with this https://github.com/ashkamath/mdetr/pull/42

@ShoufaChen  Thank your very much for your reply!!  I just have not got the meaning, in issue #42 , "Use map_location=device solves this issue." mean set 'map_location' in the main function --resume load? or else where? or just as bash environment variable.  If in --resume load, how to set when train a model from no checkpoint? the two method I try are all fail when use 6 GPU on RTX3090 (24 GB mem) and batsize set 4.