Why was the Eloquent model events unit testing issue (#1181) locked but never fixed?

After spending hours of time trying to track down a frustrating issue with unit testing where my model events were not being called after the first unit test, I eventually found that this is a long-known Laravel bug that affects many developers: https://github.com/laravel/framework/issues/1181
This is a significant issue that affects all developers that want to use unit testing to test models that use events defined in the boot() method (as recommended by the Laravel documentation).
There was a lot of discussion from other people who encountered the same issue through 2013 and 2014. There are lots of hacks mentioned that can be used as temporary work-arounds, but no real fix for the root problem in Laravel. The discussion was ongoing with more people running into the same issue. But the issue was closed in September, apparently without the bug ever actually being fixed. There continues to be more duplicates of the bug being submitted by other developers who have run into the same issue.
Does anyone know if this issue will ever be fixed or why the bug was closed without being resolved?  I  tried contacting the developer who locked the bug, but he didn't respond.

I just noticed this was closed but without a reason given.  Was this eventually fixed or better explained in the docs?  I haven't tested it since Laravel 5 was released, so I don't know if Laravel 5 addressed it, but it would be good to document the resolution to it here in case other people come across this page when having the issue.
(In response to crynobone's comment, I don't personally have enough familiarity with the inner workings of this part of Laravel to create a pull request to fix this issue.)


ci please

make diff work on origin = fork
Add debug job to workflow

https://github.com/rust-embedded/svd2rust/pull/796#issuecomment-1876760018

wow. I even will not try to understand what are you doing.


Multiscale modeling and high time scale MD simulation using TorchMD

We want to see an allosteric conformational change in our complex for a 10 to 15  millisecond time scale frame. We have plans to make the system hybrid. Water and membrane will have a coarse grain, protein-ligand binding site area will be atomistic, but the rest of the protein will have a coarse grain. We want to predict the force field for this kind of system and then run the whole system for 10–15 milliseconds.
is it possible using TorchMD or we need something different?

And how do you train the force field?
On Wed, Mar 13, 2024, 07:10 Raul @.***> wrote:

Depending on the force field and the complexity of your system you might
have more luck trying this out in OpenMM. You can use the TorchMD-Net
neural network potentials as force fields in there via OpenMM-Torch:
https://github.com/openmm/openmm-torch
https://torchmd-net.readthedocs.io/en/latest/models.html#integration-with-md-packages
—
Reply to this email directly, view it on GitHub
https://github.com/torchmd/torchmd/issues/66#issuecomment-1993639386,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3KUOQX57IOIP3PMXSX6TTYX7UUNAVCNFSM6AAAAABETFVWWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJTGYZTSMZYGY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Ok, Thank you for your advice. For Practice, I am trying to do the same thing as the tutorial but with a small protein of mine. Can you please explain what is "coords_npz = 'data/chignolin_ca_coords.npy' & forces_npz = 'data/chignolin_ca_forces.npy" this two numpy array files, and how I can generate it? my guess is for "chignolin_ca_coords.npy" can be converted from .dcd file(for example any dcd file generated after 10ns normal amber simulation". But how to get chignolin_ca_forces.npy one. Please guide me.


Warn message update

Made the warn message more detailed so people can fastly locate the problem.

Seems I created the branch at a wrong commit...I wanted to sperate the two commits into 2 PR.Anything I can do to remedy it?Or just merge one of them.

Regarding the change to the block handler warn message:
A block missing a handler is not always a vanilla block entity.
Regarding the change to the command log message:
It seems unnecessary. The logger is in the command class (created with a reference), so the log message either already includes the class name (indicating it is referring to a command), or can be configured that way.


Ageing Pages report causes KeyError due to deleted user

Issue Summary
When rendering the Ageing Pages report, if a page in the query set was most recently published by a user that has subsequently been deleted, a KeyError is thrown, displaying an error page to the user.
Traceback:
Internal Server Error: /admin/reports/aging-pages/
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/views/decorators/cache.py", line 62, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/code/wagtail/wagtail/admin/urls/__init__.py", line 165, in wrapper
    return view_func(request, *args, **kwargs)
  File "/code/wagtail/wagtail/admin/auth.py", line 182, in decorated_view
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/views/generic/base.py", line 84, in view
    return self.dispatch(request, *args, **kwargs)
  File "/code/wagtail/wagtail/admin/views/generic/permissions.py", line 36, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/views/generic/base.py", line 119, in dispatch
    return handler(request, *args, **kwargs)
  File "/code/wagtail/wagtail/admin/views/reports/base.py", line 30, in get
    context["object_list"] = self.decorate_paginated_queryset(
  File "/code/wagtail/wagtail/admin/views/reports/aging_pages.py", line 71, in decorate_paginated_queryset
    page.last_published_by_user = username_mapping[page.last_published_by]
KeyError: 4

Encountered on 3.0.3, duplicated on 4.0.4.
It is caused by the dict lookup in this function
Steps to Reproduce
From a working Wagtail application, e.g. bakerydemo:

As an admin user, create an additional user with editing permissions
Log out, log back in as that new user
Edit and publish a page
Confirm it appears in the ageing pages report, attributed to your new user
Log out, log back in as admin
Delete the newly created user
Visit the ageing pages report

Suggested solution: check for the existence of the user in the username_mapping dict, and render the string "(user not found)" instead of the username - or "user {id} (deleted)" like the page history view - if the user's id is not in the dict.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.8.12
Django version: 4.0.8
Wagtail version: 4.0.4
Browser version: Firefox 106

I can confirm this issue is present in 4.0.4 following an upgrade of an existing client site.
Internal Server Error: /admin/reports/aging-pages/
Traceback (most recent call last):
  File "/venv/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/venv/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/venv/lib/python3.8/site-packages/django/views/decorators/cache.py", line 44, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/venv/lib/python3.8/site-packages/wagtail/admin/urls/__init__.py", line 165, in wrapper
    return view_func(request, *args, **kwargs)
  File "/venv/lib/python3.8/site-packages/wagtail/admin/auth.py", line 182, in decorated_view
    response = view_func(request, *args, **kwargs)
  File "/venv/lib/python3.8/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/venv/lib/python3.8/site-packages/wagtail/admin/views/generic/permissions.py", line 36, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/venv/lib/python3.8/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/venv/lib/python3.8/site-packages/wagtail/admin/views/reports/base.py", line 30, in get
    context["object_list"] = self.decorate_paginated_queryset(
  File "/venv/lib/python3.8/site-packages/wagtail/admin/views/reports/aging_pages.py", line 71, in decorate_paginated_queryset
    page.last_published_by_user = username_mapping[page.last_published_by]
KeyError: 8

I have no user with the ID 8
Python version: 3.8.15
Django version: 3.2.16
Wagtail version: 4.0.4

Fixed in #9531.


Update gomplate template for tfplan changes

What's new:

Add lines to  terraform.tfplan.gotmpl template  and main.mk  so it can now show:

short sha of commit (with url to commit)
who made this commit(with url to person's github page)
name of the  commit that generated this Terraform changes message

How it works:
Work in two modes:

in local mode - it generates usual tfplan.md that can be found in your env directory
in CI/CD it (with collaboration of workflow) gets environment variables and outputs tfplan.md with sha, user and name of commit

Testing done:

 Add ability to show commit id and commit message in the Terraform Plan PR comment


SenLin Liu's Curriculum Vitae

SenLin Liu's Curriculum Vitae.pdf

It looks like you are attempting to push a change to the template repository, for help with deploying your own website please start a new thread in the discussions.


Cluster-autoscaler: build k8s scheduler node info structure based on kubectl drain

kubernetes/kubernetes#24404
It would be nice if :
https://github.com/kubernetes/kubernetes/pull/24929
https://github.com/kubernetes/kubernetes/pull/24923
were merged before this PR (although it is not a super hard requirement, we can update godeps again once they are merged).
cc: @piosz @fgrzadkowski

LGTM


Refactor branch list using src-d/go-git and add GetRefs function

GetRefs will be needed to implement Refs API
Add src-d/go-git dependency and refactored GetBranches to use this lib.
Old using git command:
BenchmarkRepository_GetBranches-4           1000           1505930 ns/op
New using src-d/go-git:
BenchmarkRepository_GetBranches-4          10000            150774 ns/op

Codecov Report

Merging #133 into master will decrease coverage by 1.26%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   33.54%   32.27%   -1.27%
==========================================
  Files          25       27       +2
  Lines        1407     1738     +331
==========================================
+ Hits          472      561      +89
- Misses        862     1098     +236
- Partials       73       79       +6

Impacted Files
Coverage Δ

ref.go
0% <0%> (ø)

repo_branch.go
12.32% <58.33%> (+12.32%)
:arrow_up:

repo_ref.go
65.38% <65.38%> (ø)

tree.go
68.42% <0%> (-6.58%)
:arrow_down:

signature.go
64% <0%> (-6%)
:arrow_down:

repo_tree.go
35.71% <0%> (-5.96%)
:arrow_down:

sha1.go
42.1% <0%> (-4.96%)
:arrow_down:

tree_blob.go
40.54% <0%> (-4.63%)
:arrow_down:

commit_info.go
63.92% <0%> (-4.08%)
:arrow_down:

git.go
27.27% <0%> (-3.29%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3afe30...d9cf899. Read the comment docs.

@lafriks the benchmark is for a bare git repository?

@lunny yes

It seems we only have a bare repo on testdata

@lunny is that a problem?

I prefer pure go library than git command. But for performance measure, I think a bare repo maybe not a good example.

We store all git repos as bare server-side so that is measurement most important for gitea case


Hang on write when using esp-wifi in the same crate

I attempted to make an OTA flasher for esp32 using esp-wifi and esp-storage.
Using only esp-storage, I'm able to read the partition table and I'm able to write the "otadata" partition and make it boot another partition.
However, as soon as I add esp-wifi as dependency, the embedded storage write seems to hang. This happens even if I don't call any function from esp-wifi, i just add the dependency and the necessary .cargo/config changes for it to compile.
I already tried bumping hal versions in esp-storage and adapting main for the &mut peripheral_clocks_control change. This crate works with new hal, but the issue persists. As soon as esp-wifi is added as dependency, write hangs. Very strange.
Any ideas what might be going on or what I might try?

If only adding the dependency is causing this, then it's very odd. If you actually initialize esp-wifi in your code it makes sense.
There is https://github.com/bjoernQ/esp32c3-ota-experiment which is for ESP32-C3 but I just pushed the esp32 branch.
On ESP32 this library needs to run our own version of the flash functions from RAM with flash detached. esp-wifi contains a scheduler which when it triggers runs code from flash which is not good when the flash is detached.
In my example it seems to work because it's using an unreleased version of esp-storage which by defaults uses the critical-section feature (to avoid any interrupts while flash is detached). My code is using a quite old version of esp-hal and esp-wifi - if there were any changes making it not work anymore, we need to find the problematic commit
I just tested it again and it seems I can't get esptool.py to generate a valid image but the flashing seems to work fine

After some trial and error, i have got it working and I have concluded the following:
lto=false
and
lto="off"

are not the same.
The first is actually "thin local lto" which is the default for the release profile. The latter turns off lto entirely and causes write to hang on esp32. I used the latter because of a recommendation from esp-wifi:
[profile.release]
# Explicitly disable LTO which the Xtensa codegen backend has issues
lto = "off"

Now I guess I'll investigate what happens to esp-wifi when thin local lto is enabled. Maybe it has improved since issues about it were opened.

Here are some findings with different lto settings and what works and what does not on esp32:
opt-level = 3 # important. esp-storage claims opt-level must be 2 or 3.
lto = "fat" # everything seems to work: storage write and esp-wifi

opt-level = 3 # important. esp-storage claims opt-level must be 2 or 3.
lto = "thin" # everything seems to work: storage write and esp-wifi

opt-level = 3 # important. esp-storage claims opt-level must be 2 or 3.
# NOTE THAT false MEANS THAT "thin-local" LTO IS ACTUALLY ENABLED!
lto = false # everything seems to work: storage write and esp-wifi

opt-level = 3 # important. esp-storage claims opt-level must be 2 or 3.
lto = "off" # BROKEN. esp-storage write hangs.

rustc +esp --version
rustc 1.70.0-nightly (f112def22 2023-05-31) (<IP_ADDRESS>)

Thanks for the analysis of the effects of different lto settings (cc @MabezDev)

Has this been resolved then? because it still happens to me even with the suggested changes. So what am I doing wrong?

I missed this ping, sorry folks! This should be fixed for all single core chips, hence why @bjoernQ's ESP32-C3 based project above works.
For multi core, the whole world gets a bit more complicated. Neither core can access flash whilst writing to it, if you do all kinds of mayhem will ensue. To ensure the other core doesn't read the flash there needs to be some kind of software solution to say to the other core, "hey, stop until I say go". You also might not want to stop the other core at all, the other core can still run provided it doesn't refill the cache when trying to execute, so any code already in the cache, in RAM or ROM can be executed freely.
So, in short, writing to flash in multicore systems is only possible when:

The second core isn't running
The second core is only running code already in the cache, RAM, or ROM

The only example I know of writing to flash on the esp32s3 is @bugadani's card-io-fw, and nor-fs. We don't have a generic solution for that yet. Might be some more interesting info in https://github.com/esp-rs/esp-storage/issues/26 too.

Has this been resolved then? because it still happens to me even with the suggested changes. So, what am I doing wrong?

Does your application do anything on the second core? As @MabezDev said for multi core just disabling interrupts is not enough. There was a PR addressing this by simply halting the other core when accessing the flash: https://github.com/esp-rs/esp-storage/pull/29
In my tests back then it worked but I never heard back from the user who created the original issue so it never got merged
If you are only using one core it should work.
Does the example in this repository work for you?


[Documentation] Could a complete example be added, how to run firefox with sound on youtube please?

Could a complete example be added, how to run firefox with sound on youtube please?
This would help me I think. I already modified security.sandbox.content.write_path_whitelist in about:config but I am not sure what else to do ... should I do "apulse firefox"? Would this then work for youtube audio?
Perhaps this would be helpful for more people in general.
I tried to do "apulse firefox" and it is starting but when trying to play audio in the videos I get:
[apulse] [error] do_connect_pcm: can't get initial hw parameters for playback device "default". Error code 1 (Operation not permitted)
[apulse] [error] do_connect_pcm: failed to open ALSA device. Apulse does no resampling or format conversion, leaving that task to ALSA plugins. Ensure that selected device is capable of playing a particular sample format at a particular rate. They have to be supported by either hardware directly, or by "plug" and "dmix" ALSA plugins which will perform required conversions on CPU.
[apulse] [error] do_connect_pcm: can't get initial hw parameters for playback device "default". Error code 1 (Operation not permitted)
[apulse] [error] do_connect_pcm: failed to open ALSA device. Apulse does no resampling or format conversion, leaving that task to ALSA plugins. Ensure that selected device is capable of playing a particular sample format at a particular rate. They have to be supported by either hardware directly, or by "plug" and "dmix" ALSA plugins which will perform required conversions on CPU.
And I am not sure what to do...
Thanks for reading!

For me what solved the issue was adding /dev/snd/controlC0,/dev/snd/pcmC0D0p to security.sandbox.content.write_path_whitelist in about:config and I also did sudo chmod 0777 /dev/snd/* just in case but I'm not sure if that was necessary.

@shevegen

I already modified security.sandbox.content.write_path_whitelist in about:config

Just to be sure: you need to add /dev/snd/ there. It's important to keep / at the end. It says Firefox that the directory /dev/snd and all files in it should be added to the white list.

should I do "apulse firefox"?

Yep. That should be enough.

@hishamhm

adding /dev/snd/controlC0,/dev/snd/pcmC0D0p to security.sandbox.content.write_path_whitelist

If code that parses the string in Firefox sees trailing /, the path is added to the whitelist as a directory:

https://dxr.mozilla.org/mozilla-central/source/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp#249
https://dxr.mozilla.org/mozilla-central/source/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp#326
https://dxr.mozilla.org/mozilla-central/source/security/sandbox/linux/broker/SandboxBroker.cpp#278

sudo chmod 0777 /dev/snd/* just in case

Should not be necessary. As far as I understand either user is in audio group, and then they have rights to read-write to those files. Or there is Policykit running, which adds required permissions (ACLs) on the go.

I tried both adding /dev/snd/ to security.sandbox.content.write_path_whitelist and changing the permissions of /dev/snd/*.  Neither worked.  But eh, without installing pulseaudio, at least I can still watch Netflix through Pipelight, with audio and everything (until Mozilla rips out plugins, that is).

"security.sandbox.content.level" reduced to 2 and security.sandbox.content.write_path_whitelist set to "/dev/snd/" works. Maybe the level 3 features of "security.sandbox.content.level" got added recently. I did my tests with Firefox 57 beta. The difference between level 2 and 3 are "Read access to most of the filesystem". Source: https://wiki.mozilla.org/Security/Sandbox
So maybe "security.sandbox.content.read_path_whitelist" would also need some entries if level 3 is activated. I've already tried adding /dev/snd/ and it wasn't enough.

Sandbox code in Firefox has logging capabilities. If you set environment variable MOZ_SANDBOX_LOGGING=1 before starting Firefox, it will print what system call it tries to make, and what are forbidden. May help debugging.

After updating to Firefox 57, could no longer play audio, on e.g. mynoise.net.
Problem was solved after adding '/dev/snd/' to security.sandbox.content.write_path_whitelist, with no other changes. Thanks!


is there any way to stop event propagation with event delegation on?

Is there any way to stop event propagation with event delegation in iterative sections on?

Propagation should be stoppable via the usual means (stopPropagation, returning false). If it doesn't work, then it might be a bug.
Note that for delegated handlers, your event will have already bubbled from the target element (the actual element clicked) to the delegate element (the element holding the event handler). Stopping propagation from a delegate handler will only stop it from the delegate element upwards.

I've fiddled around a little bit:
https://jsfiddle.net/lejared/t0ydn94e/41/
stopPropagation doesn't work at all with event delegation on.
return false will stop event propagation within the iterative section but the event will still be fired outside.
When event delegation is disabled everything works as expected.

I've done some more Testing:
https://jsfiddle.net/lejared/t0ydn94e/47/
It seems like returning false within an iterative section with event delegation on also suppresses native js events for all nested elements, which are commonly used in decorators, thus making them stop working.
This is unexpected too and does not match the behavior of regular event propagation, when delegated events are turned off.


Add new functions (wherefrom and settings) to OS X module

These functions have been handy in my environment, so I thought I'd share with a larger audience.

New function 'wherefrom' sets the OSX metadata in file(s) for Finder to
show where the file was downloaded from
New function 'settings' updates the Terminal window with a different settings
configuration, e.g. to quickly change the window theme.
Fix a missing local variable in the 'tab' function

wherefrom data is found in an SQLite database; see osx-ls-download-history.
settings may be too generic? Any conflicts? I have prefixed other osx-specific functions.

Thanks for responding to the PR.
The proposed wherefrom function let's me tell Finder where a file came from. For example, My Firefox.dmg that I just downloaded is from https://download-installer.cdn.mozilla.net/pub/firefox/releases/43.0.4/mac/en-US/Firefox 43.0.4.dmg, ls-download-history and Finder both report that address. However, OSX doesn't let me change that value to something sane, like http://firefox.com. Worse, when I open the disk image and install the application I've lost the information on where that file came from. So, wherefrom can be used to tell Finder where /Applications/Firefox.app was originally downloaded from.
Now it's pretty obvious where firefox was downloaded from, but imagining other scenarios this quickly becomes a handy tool. Eg. where did I get this font from, where did this script originally come from, where did this desktop photo come from, or where did on our corporate wiki did this document from, etc.
Second, regarding settings as a function name. The name is derived from the applescript function name used for changing terminal options. The GUI uses 'profile' instead, but that clashes with bash profile concepts. I am not familiar with any tools that use settings as a name. While I fear 'osx-settings' implies a very different purpose. I'd entertain changing the name to 'terminal-settings' and adding an alias named 'ts'.

"settings" appears to be a terminal launcher, so maybe just osx-terminal would be more accurate. I'm also not sure about wherefrom... it just seems a bit too specialized.

Not sure about the "downloaded from". Why do you care? I mean for software, especially that ones which are modifying operating system resources, it might be worth... but Mac OS (not sure since which versions) is trying to verify downloaded Mac OS applications on its own.

However, I think that the terminal settings are valuable.

Having some distance I agree that 'settings' is too general of a name. I have no objection with 'osx-terminal'.
My actual use case for the downloaded from tool is to add metadata to images, and documents that I've downloaded. Sometimes the actual download link shown in Finder is a lengthy amazon S3 link, whereas I will change it to the site that I actually obtained it from. In other cases the download is a zip and the document itself looses the download location.
In the year plus that I've created this it hasn't had any feedback, so if it isn't generally useful to this audience then I'm fine with the pull request being declined.
For what it's worth I use settings daily as a tool to quickly show that I'm ssh into a different host by using a different window style. While I rarely use wherefrom these days as most docs that I download are now cloud hosted (e.g. google docs) so my personal need for that has declined.


Handle realm close in did_change callbacks

Bindings could close Realm in the notify callbacks.

@tgoyne java is using did_change() for Realm notifications, so it would be quite important to handle the close case with all did_change() called. The problem is this requires to change
    TransactLogObserver(BindingContext* context, SharedGroup& sg, Func&& func,
                        _impl::NotifierPackage& notifiers, bool validate=true)

to take a SharedRealm instead of SharedGroup. Otherwise the sg might become an invalid reference when the Realm gets closed. Is it an acceptable change or there are some other ideas to handle this case?

The transaction log functions are used in places where the SharedGroup is not owned by a Realm. An awkward option would be to instead pass in a const ref to the unique_ptr<SharedGroup> and check that that's non-null all over the place.

@tgoyne PR updated

Java only exposes did_change() and collection callback to end users. So to make this PR simpler, it only handles the did_change().
Will it be a problem if user holding multiple collection notification tokens and close the Realm in the first collection change callback?
The test case table change information / modifications to untracked tables are ignored fails, but I cannot figure out why. It doesn't seem that any changes could cause that? Would you please kindly help to take a look? thanks.

@tgoyne updated, please help to review again. thanks


Add a command for upgrading a project's kobweb version

Maybe kobweb upgrade (which would automatically query GitHub for the latest version) or kobweb upgrade 1.2.3 if you wanted to specify it explicitly.
When run, this would find your project's gradle/libs.version.toml file and automatically update the versions of Kobweb and Compose.
If the user doesn't have a gradle/libs.version.toml file, or if they have one but it's missing kobweb, we could report a warning that we were not able to upgrade.
Note: This might be a dangerous command. Upgrading Compose is a delicate operation -- lots of other things may depend on it.
However, it would be pretty useful for new users who just want to keep their kobweb version up to date. And it would be nice for me to send out a message every time a new version comes out to ask users to just run kobweb upgrade

Note that we may also want to avoid confusion between upgrading the kobweb CLI itself (discussed more here) vs the kobweb library versions. It's possible we'd need a different command name than kobweb upgrade, as that is usually used for upgrading the CLI binary itself (e.g. brew upgrade)

This is not going to be the job of the CLI, it's too complex.
However, it could be worth adding this feature to the Kobweb Gradle plugin.


Cannot dynamically hide Action icons

Take the following code, which is mostly based on the Bookstore example:
tabris.create('Action', {
	title: 'Settings',
	image: {
		src: 'https://raw.githubusercontent.com/eclipsesource/tabris-js/master/examples/bookstore/images/action_settings.png',
		scale: 3
	}
}).on('select', function() {
	this.visible = false;
	this.opacity = 0;
	this.enabled = false;
	tabris.create('Page', {
		title: 'Settings'
	}).open();
});

This places a settings icon in the top right corner of the application.  When clicked, it will open an empty page with a title Settings and a back button next to the page title.  The Settings icon is still visible, and clickable.  If the user taps the settings icon from within the settings page, another Settings page will be created on the stack forcing the user to hit a back button twice (and they'll see the first settings page, which will have all the widets in the state they were in when the page was created, which may differ from how they were left on the second settings page).  Of course this can be fixed by creating the Settings page outside the select handler function, but the icon will still remain visible.
Given that a Settings page usually acts as a modal page, the settings (and other) Action icons should not be visible from the settings page.  Setting visible nor opacity nor enabled has any effect on the Action button.  However this should not always be the case as actions are not used exclusively to open modal pages.

D'oh, I forgot the properties aren't "watched" and need to notify the appropriate handlers by using the set function.
This snippet works:
tabris.create('Action', {
	title: 'Settings',
	image: {
		src: 'https://raw.githubusercontent.com/eclipsesource/tabris-js/master/examples/bookstore/images/action_settings.png',
		scale: 3
	}
}).on('select', function(action) {
	action.set('visible', false);
	tabris.create('Page', {
		title: 'Settings'
	}).open().append(
		tabris.create('TextView', {
			text: 'This is the settings page!'
		})
	).on('dispose', function() {
		action.set('visible', true);
	});
});

I'm on the fence about having to manage this inside the action's select function; I'd rather see a new property as part of the creation process that will take care of it for me.  Mostly I don't like it because the only good place to re-enable the icon is in the Action's Page's dispose handler (disappear could also work).
Will leave open to get some feedback on this idea.

I think Actions should have a Page property as well and then let the tabris framework handle everything. that said, I use tabris.ui.on("change:activePage") to manage this all manually and decide which Actions should be visible, it works pretty well and allows you to build your Page structure normally

An Action could kick off a Cordova plugin, so I don't think they should necessarily have a Page associated with them.  But you also bring up a valid point in that different pages might have different Actions, so having an Action manage its own visibility would be just as complicated as having the Page (or some other manager) watch them.


[do-not-merge] [terra-form-select] - Accessibility Updates

Summary

These changes enable select options to be visible to screen readers

Additional Details
Resolves #1769
Deployment: https://terra-core-deployed-pr-1770.herokuapp.com/
Thanks for contributing to Terra.
@cerner/terra

Closing this issue until the ideal screen behavior is determined.


Anonymous can be replaced with lambda

What is the purpose of the change
Anonymous can be replaced with lambda
Brief changelog
Anonymous can be replaced with lambda
Verifying this change
Anonymous can be replaced with lambda
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.006%) to 51.231% when pulling 91a1343f88efab3956b858a821cc333a1d8b5df9 on thenx-wei:develop into fac30c3596d5577cd80a52af9ad89a0839016137 on apache:develop.

This pull request seems to have no major effect, so I will close it. In addition, plz create an issue before submitting a pull request next time.


support for defining relationship lookups in the submission forms

This is the implementation corresponding to https://github.com/DSpace/Rest7Contract/pull/64
Some examples from the output of /rest/api/config/submissionforms
      "fields" : [ {
          "input" : { },
          "label" : "Journal",
          "mandatory" : false,
          "repeatable" : false,
          "hints" : "Select the journal related to this volume.",
          "selectableRelationships" : [ {
            "relationshipType" : "isVolumeOfJournal",
            "filter" : "creativework.publisher:somepublishername",
            "searchConfiguration" : "periodicalConfiguration"
          } ],
          "languageCodes" : [ ]
        } ]
      },
      {
        "fields" : [ {
          "input" : {
            "type" : "name"
          },
          "label" : "Author",
          "mandatory" : true,
          "repeatable" : true,
          "mandatoryMessage" : "At least one author (plain text or relationship) is required",
          "hints" : "Add an author",
          "selectableRelationships" : [ {
            "relationshipType" : "isAuthorOfPublication",
            "filter" : null,
            "searchConfiguration" : "personConfiguration"
          } ],
          "selectableMetadata" : [ {
            "metadata" : "dc.contributor.author",
            "label" : null,
            "authority" : null,
            "closed" : false
          } ],
          "languageCodes" : [ ]
        } ]
      }

@benbosman and @Raf-atmire : Just a note that this needs rebasing after #2459 was merged.  The dspace-spring-rest folder/webapp no longer exists, and all files have moved to dspace-server-webapp.

If I'm not mistaken, all feedback has been processed now.
We did notice there was a copy/paste error in the rest contract, which was implemented according to that error. It has been corrected in https://github.com/DSpace/Rest7Contract/pull/69 and in the latest commit

Thanks @AlexanderS for your review
At the moment the changes are limited to only the new features, and not to changes to the existing metadata parts. I'd prefer to keep the PRs small

@AlexanderS from your latest feedback, is there anything you consider should still be updated?
For every property which is authorized to be used, I think it's important to also know what the implications are in the UI.
I can't find the documentation on the new properties from the submission, those docs may help in identifying what's still useful


Removed unsupported ElevationGrid color fields

Fixes #116.

test me

Build Passed :ok_hand:
You can safely merge 'fix-remove-unsupported-elevationgrid-color-fields' into 'develop'.

👍

Sorry to arrive late, but this modification would deserve a ChangeLog entree.


[Mention The Feature]: Hover animation

Is your feature request related to a problem? Please describe.
It will make the website more fascinating and interesting to use
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

please this to me i would like to add this feature


Custom Syntax Highlighting

Is there a way to customise which specific words in the textarea are colored/highlighted based on a custom regex function or similar? I saw the issue regarding the prism plugins but am unclear on how to implement a custom function with these that is not language related.
For example being able to detect words that start with # and color them blue.
Thanks

@emmajane1313
https://github.com/uiwjs/react-textarea-code-editor/blob/8154d1b4e36ae1d7e09654aec2f2e5df58261ead/src/style/index.less#L3-L63


Fix rspec tests

All tests are currently failing in Travis due to STRICT_VARIABLES. Fixed by configuring missing mocked facts.
Also fixes Docker tag in fixtures

Thanks a lot!


[rebrand] design QA

Just a couple of items first, wasn't sure what Savannah meant for everything will need to clarify


Extend architecture test to ARM

fnm/functions/__fnm_version_download.fish
      case Linux
            set -l arch (uname -m)

            if test "$arch" = "x86_64"
                set arch x64
            else if test "$arch" = "armv6"
                set arch armv6
            else if test "$arch" = "armv7"
                set arch armv7
            else if test "$arch" = "armv8"
                set arch armv8
            else
                set arch x86
            end

            set file "node-v$v-linux-$arch.tar.gz"

For using on the raspberry pi (armv7)
node foundation supports armv6 armv7 armv8
I'll make a pull request if no one with more experience jumps on board

Please do send a PR :)

Well I used fisherman/nvm which worked flawlessly so /shrug

Haha okay.


add UK address data source

@benman1 I don't understand this pull-request. It contains slightly modified US parsing rules which are not good for UK. Closing it


Riscv disassembler support

capstone v0.9 released recently support RISC-V already.

 error: failed to download from `https://crates.io/api/v1/crates/syn/1.0.72/download`

Caused by:
  [55] Failed sending data to the peer (Connection died, tried 5 times before giving up)

The CI failure is spurious.


Can't extract from FluxNetworks Flux Points

LaserIO version
1.2.0
Minecraft Version
1.18.2
Forge Version
40.1.31
Modpack & Version
ATM7 - 0.4.13
Do you have optifine installed?
No
Describe the issue
LaserIO won't extract power from Flux Points, also the point doesn't render the small connection anchors it usually does towards consumers. FluxNetworks tends to intelligently try to determine consumers which I guess fails here. It doesn't matter if the Laser Node or the Flux Point are placed first. I did not test inserting into Flux Plugs.
Steps to reproduce

place Laser Node
put Energy Card set to extract in one side
place Flux Point on that side of the Laser Node
see Laser but no connection

Step 1+2 and 3 can be reversed with the same result.
Using a Flux Cell from Thermal as intermediary makes the system work.
Expected behaviour
FE Connection between both blocks and transfer of energy.
Screenshots

Log files
No response
Additional information
No response

Similar issue to : #53
Will need to add support for this kind of thing. I'll add it as an augmentation.

This should be fixed by https://github.com/Direwolf20-MC/LaserIO/commit/728b3bcf07b3db6b6c477b46eeccb23c57a514e0
I'll release v1.3.1 shortly to include this commit.
Let me know if not :D


Added proper get/setValue methods to TextArea

I expirienced some problems with TextArea editors.
The value weren't set at each render process.
I added a get/setValue method on TextAreas and the problem seems to be solved.

Can you update the tests as well? I theory this was tested and passed - so obviously if it wasn't working there's an issue with the tests.

Yep if you can add a test or even just describe the steps you need to take to reproduce that would be great


Add an option to choose browser version from array

Can you please add an option to choose a browser version from an array of options

Hey man, I see this case is still open, I have forked the repo and am ready to contribute to implement this feature. Would you still like that?

Hey @iamdual , I see this case is still open, I have forked the repo and am ready to contribute to implement this feature. Can I go ahead?

Feel free to make the changes if you'd like.
I also had plans to make some related changes about this, but I haven't had the time to look into all of them yet. So far, I've only implemented the "weighted versions" feature, but it still needs to be tested.


server: ignore channel error in tests

What problem does this PR solve?
Issue Number: close #9221
What's Changed:
raft client will retry implicitly, so in tests, it's possible that the
test thread exits while raft client still tries to send messages, which
will result in panic. This PR solves the problem by just ignoring
the error.
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note

No release note.

/run-all-tests


added unit test cases for pagination

Fixes
Fixes #401.
Description
written unit test cases for pagination class and for pagination in case of the API call

@prikshit-1103 I'll close this, but if you want to resume it at any time, please feel free to send another PR.


Ability to access Cookies and LocalStorage

Since we are able to access query params by use State.get_query_params() method in #244 , I am wondering to have access to Cookies and LocalStorage.
Cookies and LocalStorage object's behavior are like a Python dict object. Take Cookies as an example, to set a new cookie:
State.cookies["foo"] = "bar"

Set cookie with expire time:
State.cookies.set(key="foo", value="bar", expire_at=datetime.now() + timedelta(days=1))

http-only param is not supported because we need to use Javascript to do all the actions.
To get a value ( return value is a Cookie object ):
State.cookies["foo"]  # Cookie(key="foo", value="bar", expire_time=...)
State.cookies["foo"].value  # "bar"
State.cookies.get("some-key-which-not-exist", "Not Found")  # "Not Found"

Clear all Cookies:
State.cookies.clear()

I would laso like to have this feature. Right now I have fully working register and login buy the state token is in session storage which is not safe.
Wouldn't be easier to store session token in cookie in the first place?

This would be so useful. I have a website that uses Azure AD authentication via the msal python library. because I can't delete the cookie that get's set when a user logs in, they can't really log out. This means users have to use incognito mode when they use my website on a public computer.

We still need a way to read the cookies and local storage


engine.ShowError not available anymore?

In the documentation (https://github.com/coscms/xorm/blob/master/docs/QuickStart.md > Section 1: Create ORM Engine > 1.Logs)
I saw that there was/is an engine.ShowError = true. However the ShowError is not an attribute / method anymore. Also I don't find it anywhere in the code.
Did this dissapear? If so, why? And could you bring it back?
Other than that, really enjoying the library. Big kudos :)!

Yes, we have upgrade the usage. This is not compitable with old version. The document is too old that I will update it later. Now you have to engine.SetLogger() and set the log level. You can use your favorite logger to do that since core.ILogger is an interface.

Hi @lunny , thanks for the fast answer!
I just tried engine.SetLogger(xorm.NewSimpleLogger3(os.Stdout, "[db]", log.Ldate|log.Lmicroseconds|log.LUTC, core.LOG_ERR))
However this does not show errors for queries that failed (e.g. when incorrect column name). How can I solve this?

Engine.ShowSQL(true) will record SQL into logger as info log level

Hi Lunny, it seems we are talking about something different.
I want to show the Postgresql errors as they occur without having to _, err := db.Insert(), fmt.Println(err) for example.
I played a bit with Engine.ShowSQL(true) and with different core.loglevels . From the moment I put core.LOG_INFO I see all the queries being executed but still no messages for failed queries.
So the ideal scenario for me is.

only show SQL for queries that failed
show the Postgresql error message as well

Can I achieve that with the logger? and if not, how do you suggest to go about?

@pjmuller if Postgresql return en error, xorm will return the error via err on _, err := db.Insert() so you have to show the error yourself.
You can show the last SQL via session.LastSQL() after you execute Find, Insert and etc.

Hi @lunny , thanks for the session.LastSQL() info.
Do you see a way to hook into that error? So that I don't have to do always do _, err := ...
Writing a wrapper is hard without forking the project (as I can't extend the Engine type). Would loved to have solved this with a logger or alike. Any ideas?

I'm afraid there is no the hook to do that. And currently I have no idea about how to add a hook satisfied with this.


Bug: minor styling bug when using sliding pane's rotated headers

🏴☠

This should now be addressed in Version 1.3.0.


Bundle webpack/ts configuration to npm package

We should bundle "best-practice" webpack/typescript config to our npm package.

I think this can be included in the generator template, I linked this issue to https://github.com/lensapp/lens/issues/1296

The "best practice" webpack config is now bundled in the generator template, https://github.com/lensapp/generator-lens-ext/tree/main/generators/app/templates/ext-ts
There is no need to include in our npm?

I will close this as was included in the commits to master already https://github.com/lensapp/generator-lens-ext/tree/main/generators/app/templates/ext-ts


Windows Installation Issue

Hi again! Sorry to bug you. I was compiling a module against Windows 64-bit with Python 3.6, 3.7, and 3.8 on AppVeyor that includes deflate. Deflate appeared to successfully install, but was not found as a module. Here's my output:
uild started
git clone -q --branch=main https://github.com/seung-lab/mapbuffer.git C:\projects\mapbuffer
git checkout -qf 8d71424c63cb13c9babbdf307ff2d2ca6e1e4d31
Running Install scripts
%PYTHON%\python.exe -m pip install wheel
Collecting wheel
  Downloading https://files.pythonhosted.org/packages/c9/0b/e0fd299d93cd9331657f415085a4956422959897b333e3791dde40bd711d/wheel-0.36.1-py2.py3-none-any.whl
Installing collected packages: wheel
  WARNING: The script wheel.exe is installed in 'C:\Python38-x64\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed wheel-0.36.1
WARNING: You are using pip version 19.3.1; however, version 20.3.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
%PYTHON%\python.exe -m pip install -r requirements.txt -r requirements_dev.txt
Collecting brotli
  Downloading https://files.pythonhosted.org/packages/63/29/1b104b5915e61d9f7443889657d93937b7e0b33b331609b82693547934a0/Brotli-1.0.9-cp38-cp38-win_amd64.whl (365kB)
Collecting deflate>=0.2.0
  Downloading https://files.pythonhosted.org/packages/c2/42/49d6f7eecca4768e045b5bf25c8b7f650ffd88b5c0d927c5833161c496c2/deflate-0.2.0-cp38-cp38-win_amd64.whl
Collecting numpy
  Downloading https://files.pythonhosted.org/packages/40/db/5060f18b0116f00ee73f8365efc9c95bd5496946290b0e7c97b6ee89dffe/numpy-1.19.4-cp38-cp38-win_amd64.whl (13.0MB)
Collecting tqdm
  Downloading https://files.pythonhosted.org/packages/8a/54/115f0c28a61d56674c3a5e05c46d6c3523ad196e1dcd3e2d8b119026df36/tqdm-4.54.1-py2.py3-none-any.whl (69kB)
Collecting zstandard
  Downloading https://files.pythonhosted.org/packages/1d/60/888086d0239520c087da33ca2a2f1c185b24ce1d882ba68abbd8787c7884/zstandard-0.14.1-cp38-cp38-win_amd64.whl (551kB)
Collecting pytest
  Downloading https://files.pythonhosted.org/packages/b1/ee/53945d50284906adb1e613fabf2e1b8b25926e8676854bb25b93564c0ce7/pytest-6.1.2-py3-none-any.whl (272kB)
Collecting cffi>=1.11
  Downloading https://files.pythonhosted.org/packages/f6/d4/bf5516922cc914174a936e7094d5f136ee4178b3509069dd3da8e3040a1a/cffi-1.14.4-cp38-cp38-win_amd64.whl (179kB)
Collecting attrs>=17.4.0
  Downloading https://files.pythonhosted.org/packages/c3/aa/cb45262569fcc047bf070b5de61813724d6726db83259222cd7b4c79821a/attrs-20.3.0-py2.py3-none-any.whl (49kB)
Collecting iniconfig
  Downloading https://files.pythonhosted.org/packages/9b/dd/b3c12c6d707058fa947864b67f0c4e0c39ef8610988d7baea9578f3c48f3/iniconfig-1.1.1-py2.py3-none-any.whl
Collecting toml
  Downloading https://files.pythonhosted.org/packages/44/6f/7120676b6d73228c96e17f1f794d8ab046fc910d781c8d151120c3f1569e/toml-0.10.2-py2.py3-none-any.whl
Collecting packaging
  Downloading https://files.pythonhosted.org/packages/28/87/8edcf555adaf60d053ead881bc056079e29319b643ca710339ce84413136/packaging-20.7-py2.py3-none-any.whl
Collecting colorama; sys_platform == "win32"
  Downloading https://files.pythonhosted.org/packages/44/98/5b86278fbbf250d239ae0ecb724f8572af1c91f4a11edf4d36a206189440/colorama-0.4.4-py2.py3-none-any.whl
Collecting atomicwrites>=1.0; sys_platform == "win32"
  Downloading https://files.pythonhosted.org/packages/2c/a0/da5f49008ec6e9a658dbf5d7310a4debd397bce0b4db03cf8a410066bb87/atomicwrites-1.4.0-py2.py3-none-any.whl
Collecting py>=1.8.2
  Downloading https://files.pythonhosted.org/packages/68/0f/41a43535b52a81e4f29e420a151032d26f08b62206840c48d14b70e53376/py-1.9.0-py2.py3-none-any.whl (99kB)
Collecting pluggy<1.0,>=0.12
  Downloading https://files.pythonhosted.org/packages/a0/28/85c7aa31b80d150b772fbe4a229487bc6644da9ccb7e427dd8cc60cb8a62/pluggy-0.13.1-py2.py3-none-any.whl
Collecting pycparser
  Downloading https://files.pythonhosted.org/packages/ae/e7/d9c3a176ca4b02024debf82342dab36efadfc5776f9c8db077e8f6e71821/pycparser-2.20-py2.py3-none-any.whl (112kB)
Collecting pyparsing>=2.0.2
  Downloading https://files.pythonhosted.org/packages/8a/bb/488841f56197b13700afd5658fc279a2025a39e22449b7cf29864669b15d/pyparsing-2.4.7-py2.py3-none-any.whl (67kB)
Installing collected packages: brotli, deflate, numpy, tqdm, pycparser, cffi, zstandard, attrs, iniconfig, toml, pyparsing, packaging, colorama, atomicwrites, py, pluggy, pytest
  WARNING: The script f2py.exe is installed in 'C:\Python38-x64\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The script tqdm.exe is installed in 'C:\Python38-x64\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The scripts py.test.exe and pytest.exe are installed in 'C:\Python38-x64\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed atomicwrites-1.4.0 attrs-20.3.0 brotli-1.0.9 cffi-1.14.4 colorama-0.4.4 deflate-0.2.0 iniconfig-1.1.1 numpy-1.19.4 packaging-20.7 pluggy-0.13.1 py-1.9.0 pycparser-2.20 pyparsing-2.4.7 pytest-6.1.2 toml-0.10.2 tqdm-4.54.1 zstandard-0.14.1
WARNING: You are using pip version 19.3.1; however, version 20.3.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
%PYTHON%\python.exe -m pip install -e .
Obtaining file:///C:/projects/mapbuffer
Requirement already satisfied: brotli in c:\python38-x64\lib\site-packages (from mapbuffer==0.2.1.dev5) (1.0.9)
Requirement already satisfied: deflate>=0.2.0 in c:\python38-x64\lib\site-packages (from mapbuffer==0.2.1.dev5) (0.2.0)
Requirement already satisfied: numpy in c:\python38-x64\lib\site-packages (from mapbuffer==0.2.1.dev5) (1.19.4)
Requirement already satisfied: tqdm in c:\python38-x64\lib\site-packages (from mapbuffer==0.2.1.dev5) (4.54.1)
Requirement already satisfied: zstandard in c:\python38-x64\lib\site-packages (from mapbuffer==0.2.1.dev5) (0.14.1)
Requirement already satisfied: cffi>=1.11 in c:\python38-x64\lib\site-packages (from zstandard->mapbuffer==0.2.1.dev5) (1.14.4)
Requirement already satisfied: pycparser in c:\python38-x64\lib\site-packages (from cffi>=1.11->zstandard->mapbuffer==0.2.1.dev5) (2.20)
Installing collected packages: mapbuffer
  Found existing installation: mapbuffer 0.2.1.dev5
    Can't uninstall 'mapbuffer'. No files were found to uninstall.
  Running setup.py develop for mapbuffer
Successfully installed mapbuffer
WARNING: You are using pip version 19.3.1; however, version 20.3.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
%PYTHON%\python.exe -m pytest -v -x automated_test.py
============================= test session starts =============================
platform win32 -- Python 3.8.0, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- C:\Python38-x64\python.exe
cachedir: .pytest_cache
rootdir: C:\projects\mapbuffer
collecting ... collected 0 items / 1 error
=================================== ERRORS ====================================
_____________________ ERROR collecting automated_test.py ______________________
ImportError while importing test module 'C:\projects\mapbuffer\automated_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
C:\Python38-x64\lib\importlib\__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
automated_test.py:3: in <module>
    from mapbuffer import MapBuffer, HEADER_LENGTH
mapbuffer\__init__.py:30: in <module>
    from .mapbuffer import MapBuffer, HEADER_LENGTH, MAGIC_NUMBERS, FORMAT_VERSION
mapbuffer\mapbuffer.py:3: in <module>
    from . import compression
mapbuffer\compression.py:5: in <module>
    import deflate
E   ModuleNotFoundError: No module named 'deflate'
=========================== short test summary info ===========================
ERROR automated_test.py

Thanks again for deflate! It's a really great module. ^_^
My code is located here if you'd like to look: https://github.com/seung-lab/mapbuffer
I don't have access to a Windows machine so I'm not sure what else I can do.
Will

Thanks for the report. I'm guessing that maybe Windows builds the library with a different suffix (not .a) and isn't being included in the package. Should probably be an easy conditional platform.system() == "Windows" in setup.py, but I don't know for sure until I can get a Windows system set up to try it.
I do have a Windows machine laying around (in pieces), so I could theoretically make this happen, but it might be easier to fiddle/guess and use GItHub actions until something works.

Can you give the Windows wheels from the artifacts here a try? I don't know why I was trying so hard to use libdeflate's build system instead of letting distutils/setuptools just compile it.

I optimistically released 0.3 to PyPI, with Windows wheels that I've built and run on an actual Windows machine. Let me know if you still have any trouble.

That seems to work for my build system!


docs(readme): fix small typo to add missing "is" in Versions section

Description: fix typo in Versions In This Repository section: from "This all of the current" to "This is all of the current"
Related issue (if exists):

Coverage increased (+0.2%) to 96.951% when pulling 3b9266a67693823afe96d4da4cae73ec9d781023 on jordan-sf:patch-1 into a5ff2c29a59649fc95a35639cefafb6afdac5167 on ReactiveX:master.


#Ft create product

What does this PR do?
allows a farmer to creates farm product or upload farm product if they are verified and must be a farmer
Description of Task to be completed?
list the things you did to complete this project

[x] create a table for farm product
[x] create controller
[x] add farm product

How should this be manually tested?
Tell us how other people can test out this your feature to see if it's working as expected.

[x] checkout to the branch or clone the branch
[x]  run npm i
[x] start server
[x] load postman and make a post request to /api/v1/product/createFarmProduct

Any background context you want to provide?
N/A
Screenshots

Nice work here.. we need to speed up


Fix quotes in shebang help

Replaces single quotes with backticks in the help for shebang, consistent with other help.
The single quotes cause issues with zsh completion, as they are placed in single quoted strings.
Closes #695.

@crater2150 thank you for your contribution, PR should be merged once CI is green.


Better: Ensure JSON example are valid JSON.

I tried to send a carousel and I was getting a parse error after copy/paste the example from the doc.
I did a quick review of structured message examples and fixed those which are not valid JSON

LGTM


fix(builder): Use unicode-aware truncation for label-maxlen

This should fix the remaining problems in issue #393, since I missed a spot in the last PR.

Thanks


docs: Update direct routing policy limitations

This change is

test-me-please

test-docs-please

test-docs-please

test-docs-please

Coverage increased (+0.01%) to 44.094% when pulling 38c21d96a363f815133c121e34a517c36c6660ad on joestringer:submit/fix-direct-routing-docs-policy into 1233b1fa85eb1429dc3448d230eaef52016b7ef0 on cilium:master.

@joestringer Setting need-backport/1.5, as this would reduce some confusion for v1.5 users: https://cilium.slack.com/archives/C53TG4J4R/p1566477425192100?thread_ts=1566438387.191500&cid=C53TG4J4R (via #9035).


Project menu quibbles

Between the Console pane popup menu and the Project Browser popup menu there are inconsistencies in the use of ... following the menu item.  As I understand, "..." implies a further selection, that does not include a confirmation dialog.
On console,

[x] Load, Unload, Pull from Git, Push to Git, Write should remove the ...

On project browser,

[x] Pull from Git, Push to Git, Changes, and Write should remove the ...

On other related menus:

[x] Find Class should be on the Jadeite menu, and not on the project and package menus, since it does not find within the project or package.

[ ] add package is on the package menu, which is weird since it's a project operation... I think it should be on the project menu.

[x] the "save" in the Save Package ... on the package menu doesn't make sense.  You could renamed to Write Package perhaps (still a no-op), or just remove it.

[ ] The package menu > Unload Package similarly is confusing... it could be renamed to Remove Package (still a no-op), as a placeholder.

add package is on the package menu, which is weird since it's a project operation... I think it should be on the project menu.
@LisaAlmarode I don't disagree with you, however I'd like to leave it on the package menu for three reasons.

One - Project & Package are similar names and I think it would be possibly misread as Add Project.
Add Package & Unload Package are nicely symmetric.
The package menu does package things.

My vesting in this interest is very small so I could be persuaded to move it nonetheless.

Since it's not implemented anyway, changing package unload doesn't matter.

[ ] However, the add package thing... the symmetry is entirely grammatic, functionally they are very different; you don't have a package yet, when you go to add one.  I think package menu operations should be things that you do to a specific package.
Most of the project operations are things you do with a specific project.  Something you do to a specific project is add a new package to it.
If you are likely to get confused between package and project, then you are going to have lots of issues with Jadeite...

[ ] This is why I also disagree with find class on the package menu since it finds a class anywhere, NOT just within the package.  You probably just missed fixing this since I hid it within the earlier sentence.

Fixed in 3.0.36.


Handle EACCES errors when saving an editor

Perhaps put a message in the status bar or somewhere else, but catch it either way.

This has better error messages in the latest version


Document Delete Workflow

The design doc details how Envoy Gateway (EG) translates Gateway API objects into Envoy configuration and infrastructure. However, the document does not detail how EG handles the opposite workflow. What happens when a user deletes the Gateway API objects are deleted?
This doc will be used to collaborate on the deletion workflow details.

@envoyproxy/gateway-maintainers I completed the first draft of the doc. PTAL and provide comments in the doc as needed.


adjust spacing

[ ] could we move the start screen (dots & headline) a bit further up? Currently it can easily be cut on smaller window sizes

[x] reduce spacing (see mockup)

[x] generally, align the spacing. I emphasized the spacing with red boxes next to the mockup

[x] reduce spacing for the founding members. 12px-8px (see mockup)

could we move the start screen (dots & headline) a bit further up? Currently it can easily be cut on smaller window sizes

@chrifro we can't move the dots up unless we reduce the trajectory of the dots i.e at the start the top two dots are aligned at the very top right below the nav. Should I try changing the trajectory(I don't think that would look good)?

Alternatively, we could reduce the size of the dots more on mobile + also the spacing between the dots and the headline.

reducing this space from t0 48px would not work without changing the trajectory? We should keep the change as simple as possible

If not, I like your suggestion of reducing the spacing between the dots and the headline, It could be around 48-56px

@chrifro I have made this Pr to adjust it as you suggested https://github.com/gitpod-io/devx-community/pull/67


Update README in swift-3.0-beta5 branch

Hi,
could you please update README.md in swift-3.0-beta5 branch how to use SwiftCLI for Swift 3.0? I'm trying to build my swift 3.0 app, but with standard package configuration I'm getting tons of error during swift build for SwiftCLI package.
Thank you.

Thanks for the suggestion, done in 274f14abafe760df7a0d1b515f0733a60ec9cbac. Changing the dependency in Package.swift to look like this should be enough:
.Package(url: "https://github.com/jakeheis/SwiftCLI", Version(1, 3, 0, prereleaseIdentifiers: ["beta"]))


No dependancy on adutils?

Would it be possible to cut the cord with adultils so to speak? I don't really need or want the stuff adultils offers, but would like to try ench.. I've installed it once and edited out all the dependancy, but wouldn't it be better to have it more loosely coupled? Just I thought..

why do you want this? if it’s because there is an issue with installing the dependencies automatically, this is solved ;)
i already implemented the fix in my automoli app today and got positive feedback from testers. i will implement this in my other apps tomorrow.
if that’s not the case, why do you want it to be removed? 🤔

v0.6.0 fixes the dependency problems (hopefully on every possible setup...)


Adding additional HTML to content leads to wrong Markdown-parsing

Problem
As I described in the pagekit-forum (https://pagekit-forum.org/forum/thread/23-adding-html-to-a-view-makes-content-invalid/) I'm having trouble adding HTML to a view by using a plugin that does the following:
public function onContentPlugins( ContentEvent $event )
{
	$content = $event->getContent();
	$html = "
test
 ";
	$event->setContent($buttons . $content);
}

The result is that the markdown-formatted structure is not displayed correctly as you can see here:

Technical Details

Pagekit version: 1.0.11
Webserver: Apache 2.4
Database: SQLite
PHP Version: 7.1.2

This is related to how ATX headers in Markdown are parsed: The # must be at the beginning of the line. As you write your content in the same line by just prepending it, the markdown is correctly not parsed. The same applies if you write something like
a # Heading
directly in the editor (also here on GitHub). So I would conclude that this is no bug in the parser, but you must ensure that you have a linebreak after your content if you prepend it to the normal text.


Improve dependencies processing to only include modules once

It appears that if a module includes another module, that module gets processed twice.  This may be OK, since it's unlikely there will be multiple versions of the same module, but we should probably keep track of which modules we've already processed so we can skip them in the future (i.e. first defined wins).  This may also highlight issues with dependencies if we run into a situation where the same dependency is defined more than once (which is only really a problem if the repositories are different, e.g. different git refs).

In addition, I think we need to make sure dependencies are processed in order.  I'm not sure if this ties in with "required" modules or not, but I think we need to consider ensuring that for a module including/installing/requiring another module that the included/installed/required module is processed first.

We should also probably try to detect circles in dependency graph to not process it Infinite loop.

I don't think this is still relevant after 3.0 was released with the different approach to processing/installing modules. I'm going to close this one.


How do I delete a registered route?

Describe the Question
How do I delete a registered route?
Hertz version:
0.7.1

Deleting routes is not supported cc @Duslia

I've seen gateways that just register the 404 handler route and then do simple route matching and handler reloading themselves.

Is it an idl-generated route?

Hertz loads routes provided by external modules (e.g. WASM), external modules update routes, there will be conflicts, hope to delete the old route, register a new route

I modified the routergroup.go and tree.go implementation and I don't know if I need this pr.
Specific references: https://gitee.com/gpress/hertz/commit/2e614725e31ca7491627270ce8f88b83cde0488b

Hertz was not originally designed to consider dynamic registration and deletion of routes, which requires locking to ensure. If dynamic routing is needed, one can use NoRoute and then implement the route matching method themselves.

Ok, thank you very much


Do you plan to add version recognition?

Some devices can see the firmware and release version information in the front desk according to the features or in the back panel of the login, but it is still a large workload and needs to be collected. If you have ideas, I will fork some fingerprint information in the future. In short, it is a good project.

Hey there,
thank you so much for showing interest in the tool and opening this issue. You have made a great point about the version recognition and I believe this is something which we can definitely do as part of Genzai V2. Ideally we can create a version extraction regex for products currently part of signatures.json file and I could modify the json structure to even accommodate those regexes. Then its all about extracting them within the tool and displaying it as part of output. Writing the code for parsing the regexes from the db and extracting the versions will be pretty straightforward, its just that we will have to manually write the regexes for these products which can be a little time taking.
I will be travelling to Singapore and Dubai in the next couple of weeks to present Genzai and BucketLoot so once I am back we can plan this out better and get set cracking 🚀


Checkboxes generated from GitHub Issue Forms and selected on form submission are not detected as selected

Reason being is GitHub Issue Form generates the checkbox markdown with - [X], as in, uppercase X, and the code only looks for lowercase: https://github.com/issue-ops/parser/blob/main/src/format.ts#L68-L70

Well that was silly of me to leave in there...I'm writing a fix now! Also apologies for waiting so long to reply to this one. I wasn't subscribed to get notifications for this repo!


Suggestion / Potential Enhancement -  Blockfrost Pools Load address's once For Assets & Dexs

Suggestion - Is it possible that we could potentially add an option to get all the pools addresses for say 5 assets (MIN,AGIX,INDY etc for DEX's Minswap, Sundaeswap etc first, so our consuming application can re-use this data going forwards with potentially a get poolById going forwards for price querying per asset. This could help reduce requests to blockfrost if this is achievable and could potentially reduce the likelihood for autobans/rate limiting when calling out to get all the pools and filtering again.
Would be good to hear thoughts on this! If it is achievable or not :)

That's a good idea! Are you thinking maybe adding a function in the fetch request like getPoolByAddress(poolAddress: string)? Or maybe a function to get the latest pool state - getLatestPoolState(pool: LIquidityPool)

That's a good idea! Are you thinking maybe adding a function in the fetch request like getPoolByAddress(poolAddress: string)? Or maybe a function to get the latest pool state - getLatestPoolState(pool: LIquidityPool)

Yeah was thinking exactly that. Something that can get the pool details on demand if required but only for the pool required. :)

Wanted to share some testing I did on this, with loading the pools as a one off application load and incorporating  a custom Blockfrost SDK data provider for the data access to enforce default Blockfrost rate limiting I could see the pools returning with an average of 2-4 minutes whilst rate limited.
I then attempted querying them going forwards on demand when required with the ones I stored by the address, with a refresh pool state method mechanism to get the latest prices, although the price information was not accurate. This did bring down the query time from 2-4 minutes on average, to results every 8 seconds.


the maven vulns source is use snyk/vulnerabilitydb ?

the maven vulns source is use snyk/vulnerabilitydb ?

You can find data sources here.
https://github.com/aquasecurity/trivy#data-sources


BackgroundCopyJobCollection enumeration throws E_ACCESSDENIED

Vanara.PInvoke.BITS System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
   at Vanara.PInvoke.BITS.IBackgroundCopyJob.SetNotifyInterface(IBackgroundCopyCallback pNotifyInterface)
   at Vanara.IO.BackgroundCopyJob..ctor(IBackgroundCopyJob ijob)
   at Vanara.IO.BackgroundCopyJobCollection.Enumerator.get_Current()

https://github.com/dahall/Vanara/blob/77f8ca176e9424d845a3abfff82d97d1ee81b7d8/BITS/BackgroundCopyJob.cs#L132
if user token is Administrator, but not elevated it can see NT SYSTEM jobs (job.OwnerIsElevated) but not allowed to call SetNotifyInterface.
https://docs.microsoft.com/en-us/windows/win32/api/bits3_0/nf-bits3_0-ibackgroundcopyjob4-getownerelevationstate#remarks

Note that if the job was created with an elevated token, all subsequent updates to the job must be done with an elevated token.

How have you reproduced this? Is this a job you created using one tool while elevated and then you're using this library while not elevated to access it?

Second question: Since you cannot internally elevate a process, would an acceptable response be to provide a BackgroundCopyJob instance that is readonly and which doesn't support events?

some part of windows update created this

You probably can reproduce this with psexec and bitsadmin.
I think you should call SetNotifyInterface only after user actually subscribed to any event, so user can handle exception

I just pushed an updated using your 2nd suggestion. Please test packages available via AppVeyor (see home page for details) and let me know if this addresses your issue.

I went through your comments (thank you) and made some changes and asked you some questions there. Here are the questions so you don't have to wade through the code. Let me know your thoughts.

On the constructor: This will throw if on a Windows version before IBackgroundCopyJob4 where OwnerIsElevated got introduced. I agree with your point about exceptions during debug. I'll look at a way to remove and simplify. There wasn't an obvious way without a ton more code to check OS version, admin rights, admin elevation, etc. Any thoughts on doing this simply? Are you suggesting we just let the exception get thrown when subscribing to events?
Calling Complete is done in case Complete has not been called and the job was transferred. What scenario do you envision would be complicated by doing this during disposal?

Yes, just let it propagate. It have quite obvious message attached

Vanara.PInvoke.BITS System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
   at Vanara.PInvoke.BITS.IBackgroundCopyJob.SetNotifyInterface(IBackgroundCopyCallback pNotifyInterface)

BackgroundCopyJob is a handle to real job managed by BITS. When closing file handle I don't expect any action, same goes here. One of BITS features is job persistence beyond process lifetime, but .net guidelines insist on disposing every IDisposable.

I like your point on #2 of job persistence. I'll remove the auto-Complete code and document the change.
I'll remove the code from the constructor then. I think I'll wrap the exception and put in a little more info so it is really obvious why access is denied.
Thanks for all your help.

Also Complete may throw for variety of reasons and throwing in dispose is a bad idea

I just committed those changes. Sorry for all the bugs. I appreciate your help in finding and squashing them.

AutoCompleteOnSuccess property is also not persisted. Add notice about it in documentation.

See also https://github.com/dahall/Vanara/issues/311#issuecomment-1237552348 (for https://github.com/dahall/Vanara/commit/77f8ca176e9424d845a3abfff82d97d1ee81b7d8#diff-447817cf86df18256de9c8b3e0e78afd27d6c9a878e9d8a0bd34efaa915e023fR38)
and https://github.com/dahall/Vanara/commit/74bbe0f933cd27011c328f136ae952b53e97b03b#r84756352

Addressed your last items in commit

hmm, I'm sorry, but there is one more case.
move NotifyFlags = 0; inside if (m_notifier is not null (it calls m_ijob.SetNotifyFlags(value) in setter)
And could you make this constructor public?

Seems like it used for command line notification too, so you should not override it with 0.

That last one opens a can of worms. Making NotifyFlags public means some complex checking to ensure that if events are set or if that command line is set, then flags should or should not be set based on a variety of combinations.

I ended up deprecating NotifyProgram in lieu of two methods that handle the flags. Exposing the flags became very messy due to the interdependencies. Please take a look and let me know your thoughts.

SetNotifyInterface/SetNotifyFlags are intrusive and machine wide, so we can assume there is only one instance of BackgroundCopyJob. You can just read notifyFlags in ctor and restore this state in Dispose. (Problem we are solving that user set e.g. completion only notify flag for cmdline, subscribed to Error event and exited program -- cmd should not be called for error, but still would for complete)

I agree. I think I've dealt with the challenges you mention, but I used progNotify field to grab values in ctor. I don't restore them in Dispose since it can throw exceptions to set those values (as we've discussed) and since it would only work if the job is not complete. NotifyFlags is ignored by the native interface unless SetNotifyInterface or SetNotifyCmdLine is called anyway so it doesn't matter what the persisted value is when constructed. Unless you're seeing something I'm not, I think this is ready to close. Let me know.

oh I missed a word
user subscribes and unsubscribes to Error and Completed (so NotifyFlags is now 0 and cmd is not called)

I usually unsub from all events cause sometimes it's hard to tell would subscriber outlive event source or not.


Does this gem has any issue with Hotwire?

I add all the require configuration and still couldn't get things working. Clicking on the social buttons only refresh the page.

@Gregory280 Same problem, all links are set to href="#".


Feature/back strafing steps

Overview
In a game world or VR world its normal to have uneven planes and borders. Current teleport pointer does n't allow climbing steps when doing back strafe or its not block the movement if there is collider in the back. This pull request has one implementation to solve this issue, which checks whether there is flat plane exist so the user can back strafe or its just wont do the move if there is no plane or slope. Kindly check this pull and let me know if there is a better way to handle this.
Changes

Fixes: # back strafing on slopes and steps

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.
If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.
As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

/azp run

This looks related to #6706

Heads up, moving development into https://github.com/microsoft/MixedRealityToolkit-Unity/pull/9697 so that we can close on this issue this week!

Closing with the merge of https://github.com/microsoft/MixedRealityToolkit-Unity/pull/9697


🛍 Shopify Order Status: Pilot

Summary

Simplify the post order injection project by using javascript liquid parser to preview change on post order screen in real time
Using liquidJS to parse Order (mock) data, make it easier to test the liquid condition and data

Follow SO post

The post-order page will be served via proxy to modify the injection in real time

Reference
N/A

20 03 2023

So far running yarn run ... did not start the project, there is some issue on terminal related to gatsby, should have a look deeper

23-03-2023

At this point, mock data for the order shop checkout and common global variables has been created and used to test against the liquid editor
Should focus on the UI for now:

Split the editors into 2 columns
Extend body of the document wider
Make the parsed liquid box shorter, and support expand using modal


Adds Kerberos Buildpack RFC

Summary

Readable
Exploration
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

WG 11-15-2022: [RM] do we want to use extensions? Not sure about when they will be available on CNB

Due to the lengthy timelines we discussed at WG around being able to use extensions, I think we should proceed with this proposal so we can support this use case sooner rather than later.


Cluster Meta-Queries

This issue is for tracking the overall status of meta-queries for clustering. A tick means the command has been manually tested on a local cluster.
A green tick means it works, or that there was an issue which has been resolved, a grey tick means there is an outstanding issue.

Command
Checked
Issue?
Checked

CREATE CONTINUOUS QUERY
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5574

SHOW CONTINUOUS QUERY
:white_check_mark:

DROP CONTINUOUS QUERY
:white_check_mark:

SHOW DATABASES
:white_check_mark:

CREATE DATABASE
:white_check_mark:

DROP DATABASE
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5612

SHOW FIELD KEYS
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5579

GRANT
:white_check_mark:

SHOW GRANTS
:white_check_mark:

INSERT
:ballot_box_with_check:
https://github.com/influxdata/influxdb/issues/5610

SHOW MEASUREMENTS
:white_check_mark:

DROP MEASUREMENTS
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5518

SET PASSWORD
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5532

ALTER RETENTION POLICY
:white_check_mark:

CREATE RETENTION POLICY
:white_check_mark:

DROP RETENTION POLICY
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5653

SHOW RETENTION POLICIES
:white_check_mark:

REVOKE

SHOW SERIES
:ballot_box_with_check:
https://github.com/influxdata/influxdb/issues/5580

DROP SERIES
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5518

SHOW SHARDS
:white_check_mark:

SHOW SHARD GROUPS
:white_check_mark:

CREATE SUBSCRIPTION
:white_check_mark:

DROP SUBSCRIPTION
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5590

SHOW SUBSCRIPTIONS
:white_check_mark:

SHOW TAG KEYS
:white_check_mark:
https://github.com/influxdata/influxdb/issues/5591

SHOW TAG VALUES
:ballot_box_with_check:
https://github.com/influxdata/influxdb/issues/5593

SHOW USERS
:white_check_mark:

CREATE USER
:white_check_mark:

DROP USER
:white_check_mark:

cc @e-dard @joelegasse

SHOW TAG KEYS now works as mentioned in #5591.

SHOW FIELD KEYS now works as of #5815.


[Documentation] Fix example on how to send params in URL on POST

When doing a POST request, we should use URLEncoding.queryString instead of URLEncoding.default (as explained by @sunshinejr in #1119)

Codecov Report

Merging #1120 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   76.51%   76.51%
=======================================
  Files          22       22
  Lines         728      728
=======================================
  Hits          557      557
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5106077...7d44a7c. Read the comment docs.


GoodSwap should show in wallet menu

Link should point to https://goodswap.xyz/
@drptiago please add tracker event

https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-💵?node-id=2939%3A74995&t=wS130kFq08JgN6nt-1

@johnsmith-gooddollar @patpedrosa
Let's follow the current pattern and call this:
GOTO_GOODSWAP

@johnsmith-gooddollar the button is shown. the redirects works properly

@patpedrosa Done, released to PROD:
https://github.com/GoodDollar/GoodDAPP/commit/585d1e6b7a80893f6dc2277291f0c5baed7a858d
https://github.com/GoodDollar/GoodDAPP/commit/d0e298a5bb4f5b185f13f838680cb5a8a398b3dd

The icon doesnt show on Android

@sirpy
probably this one would fix it: https://github.com/GoodDollar/GoodDAPP/commit/1ab68b9ffe644207b728345ecd35570996e88cb3#diff-6040be760a33c1261d537866a827dca69f73281ac00e83cff561c7ae280d0d2d
need to re check once hot fixed android app will be released to PROD

@vldkhh need to re-test


"Allow service to interact with desktop" install option is missing

Services run as LocalSystem can optionally interact with the desktop (see Interactive Services).
This is currently not supported by Topshelf.
Because the command line option --interactive is already used to prompt the user for credentials, I propose that we add an additional switch like --localsysteminteract or --localsystemdesktop that can be used instead of --localsystem, if desktop interaction is necessary.

If possible, I would also like to see this configured via the HostFactory. It would make sense to add a parameter bool localSystemInteract = false to the HostConfigurator.RunAsLocalSystem method.

I am closing all issues that haven't seen any activity. You're welcome to submit a PR to resolve the issue or provide more information.


Cluster icon not disappearing on mobile browsers

When clicking on a cluster and zooming in, the round cluster icon will not disappear. This behaviour happens only on mobile browsers and not desktop. Tested on android browser, chrome android and opera android

Is this a dupe of #529?

I don't know if this is the same problem I'm having but zooming in mobile browsers (at least Chrome for Android and Safari in iOS) often leaves clusters visible even they should disappear. I debugged a little and saw this:
_moveEnd starts
MarkerCluster _recursivelyRemoveChildrenFromMap zoomLevel: 11
MarkerCluster _recursivelyAddChildrenToMap zoomLevel: 10
_moveEnd ends
_zoomEnd starts
_mergeSplitClusters
_mergeSplitClusters Zoom out, merge
_noAnimation _animationZoomOut previousZoomLevel: 11, newZoomLevel: 9
MarkerCluster _recursivelyRemoveChildrenFromMap zoomLevel: 11
MarkerCluster _recursivelyAddChildrenToMap zoomLevel: 9
_mergeSplitClusters ends
_zoomEnd ends
So, I think that first the zooming starts from level 11 but when in level 10, we receive a move event. In the move event we remove clusters from level 11 and add them back to level 10. Afterwards the zoom event ends in level 9. Now we try to remove clusters from level 11 but they are not there as they were added to level 10.
I was able to get rid of this problem by changing line
this._topClusterLevel._recursivelyAddChildrenToMap(null, Math.round(this._map._zoom), newBounds);
from _moveEnd()
to:
this._topClusterLevel._recursivelyAddChildrenToMap(null, Math.round(this._zoom), newBounds);
Of course I'm not sure what kind of problems that might cause.

Closing as dupe of #529


Refactor request hooks

Changes:

use the RequestFilterRuleInit class from the testcafe-hammerhead module
refactor request hooks initialization

The tests are green

all tasks are green (except travis.test-functional-local-headless-chrome)  https://travis-ci.com/github/testcafe-build-bot/testcafe/jobs/493353855
the travis.test-functional-local-headless-chrome task is green https://travis-ci.com/github/testcafe-build-bot/testcafe/jobs/493353855