Add the option to generate annular spectra with cross-ARFs

I realised that I never really documented this enhancement.
Currently sets of annular spectra have 'normal' ARFs generated for each spectrum of each annulus, without regard for PSF effects that can cause the scattering of photons of different energies from one annulus to another (bar the default annulus widths in XGA which are meant to help avoid PSF problems).
There is a more sophisticated treatment, built into arfgen, called cross-ARFs; this uses a detector map and a model of the PSF to calculate ARF corrections for PSF effects - though at the cost of compute time.
The option (though not the requirement) to use cross-arfs will be included in XGA (it's very simple to do).

I have deleted the original efforts I made on this issue, and I am starting again.

It is taking a very long time to run each at the moment, far too long to actually be practical to use at the scale we need (even with many cores) - I suspect this is because the det map I'm passing to arfgen at the moment is quite finely binned (I'm just using an existing one from a spectral generation run.
I need to make the detmap use in cross_arfs more robust, but also allow the user to make choices about the binning (both for this and for general spectral generation). Also the default needs to be coarser binning because this is intolerably slow.

My default detmap generation uses a binsize of 100, this must be increased for the default behaviour I think.
I will also add a specific common (internal) function that generates the commands for the detmap generation - this is because there is a whole process to determine which camera to use, because ideally you'll use a different camera to the one your calculating areas for (chip gaps are different), and it would be sloppy to just copy-paste that into the cross_arfs function (not that I haven't been sloppy before...)

Using native Xmm binning is way way too many bins. Probably in both energy and pixel space. But I suspect this is energy/PHA space?
Megan
On May 9, 2023, at 4:40 PM, David Turner @.***> wrote:

My default detmap generation uses a binsize of 100, this must be increased for the default behaviour I think.
I will also add a specific common (internal) function that generates the commands for the detmap generation - this is because there is a whole process to determine which camera to use, because ideally you'll use a different camera to the one your calculating areas for (chip gaps are different), and it would be sloppy to just copy-paste that into the cross_arfs function (not that I haven't been sloppy before...)
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/DavidT3/XGA/issues/917*issuecomment-1540259396__;Iw!!HXCxUKc!xR2vy0FQFbjLnJokq7xGyrRQ1_2iD4PnrTAIAjcMWgmBy0RpkA8D1KCGLGIa7O66rQnrMArjjxZwPmGgnP3DBpiRhQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ASKK4P54XGED2HTLXKVATGDXFJJMRANCNFSM6AAAAAATZWCFXA__;!!HXCxUKc!xR2vy0FQFbjLnJokq7xGyrRQ1_2iD4PnrTAIAjcMWgmBy0RpkA8D1KCGLGIa7O66rQnrMArjjxZwPmGgnP1HmrE42Q$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

This refers to the spatial binning for detector maps used in arf generation - I wasn’t using native binning (I think my computer would explode if I did that for arf generation) - the previous XGA default was a bin size of 100, the new default is 200 which I think is more reasonable.
Spectra generated by XGA are re-binned to achieve a minimum number counts/SN set by the user.
I’m making more progress with this crack at cross-arfs than last time, I found an unintended behaviour in my AnnularSpectra class this time around which was causing all the issues I had last time.
Now my output folders are filling up with 100s of cross-arf files :D
On 9 May 2023, at 13:02, astrophysics-megan<EMAIL_ADDRESS>wrote:
Using native Xmm binning is way way too many bins. Probably in both energy and pixel space. But I suspect this is energy/PHA space?
Megan
On May 9, 2023, at 4:40 PM, David Turner @.***> wrote:

My default detmap generation uses a binsize of 100, this must be increased for the default behaviour I think.
I will also add a specific common (internal) function that generates the commands for the detmap generation - this is because there is a whole process to determine which camera to use, because ideally you'll use a different camera to the one your calculating areas for (chip gaps are different), and it would be sloppy to just copy-paste that into the cross_arfs function (not that I haven't been sloppy before...)
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/DavidT3/XGA/issues/917*issuecomment-1540259396__;Iw!!HXCxUKc!xR2vy0FQFbjLnJokq7xGyrRQ1_2iD4PnrTAIAjcMWgmBy0RpkA8D1KCGLGIa7O66rQnrMArjjxZwPmGgnP3DBpiRhQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ASKK4P54XGED2HTLXKVATGDXFJJMRANCNFSM6AAAAAATZWCFXA__;!!HXCxUKc!xR2vy0FQFbjLnJokq7xGyrRQ1_2iD4PnrTAIAjcMWgmBy0RpkA8D1KCGLGIa7O66rQnrMArjjxZwPmGgnP1HmrE42Q$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/DavidT3/XGA/issues/917*issuecomment-1540543693__;Iw!!HXCxUKc!zUJ3UrYeHMKxpXt3fB_RxIV97h9Qhmu43Kaa2KEgYKgGudDB4_MxbAf478Xpapd91nquutC0Rsjf6TMxytiQdUMFlg$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEHMFK7U4MEKZTVPLJKRZE3XFJ2AZANCNFSM6AAAAAATZWCFXA__;!!HXCxUKc!zUJ3UrYeHMKxpXt3fB_RxIV97h9Qhmu43Kaa2KEgYKgGudDB4_MxbAf478Xpapd91nquutC0Rsjf6TMxytjPFo_LUg$.
You are receiving this because you were assigned.Message ID: @.***>
--
Dr David Turner (he/him)
Research Associate - Michigan State University Astronomy Group
GitHub - https://github.com/DavidT3
—
If I am sending emails outside of standard working hours, I may be working flexibly. Please be assured that I do not expect a response outside of your own working hours.

Note to self, need to make sure cross-arfs are read back in from the disk when a source/sample is re-declared and allowed to load already generated products. Currently they have to be regenerated each time, which is obviously daft.

Doing a manual practise of cross-arf XSPEC fitting, will update comment with lessons learned:

The 'diag' responses used by examples are unitary matrices for residual SP models
When adding more rmf and arfs to a spectrum group resp must be set first, then arf - makes sense in retrospect
Example doesn't ever use a 'source number' more than once, though from what I can glean from XSPEC's docs source number are on a per-spectrum basis. Admittedly the XSPEC docs aren't explicit about that, but we'll see.

I think I've got a handle on this now - I used XGA to generate annular spectra and all the ancillary gubbins that go with it, as well as cross-arfs, and grabbed the paths and implemented an XSPEC manually with cross-contribution accounted for. The annular spectra have been generated for A907, the radial boundaries were pulled from thin air, and have no particular physical meaning (0-180-330-500 kpc, three annuli). 180kpc translates to ~65arcsec for A907, so really could have chosen better for a test of this but oh well.
A907 has three observations, but for the manual test I just used<PHONE_NUMBER>, all three instruments, so each annulus has three spectra. Used a consttbabsapec model, frozen nH, redshift, metallicity - each annulus has kT and norm linked across the three spectra, the constant for each is not linked, though the constant for the 'first' spectrum in each annulus is frozen at 1.
Cross-contribution is taken into account with setting up a consttbabsapec model for each annulus's contribution to each other annulus (on an instrument by instrument level); i.e. there are 12 cross talk models for the three annuli with three spectra each.
The same setup,  but without the cross contribution models, was used for a comparison fit (left is with cross arfs, right is without):

So it is certainly having something of an effect. Also attaching the xcm files for my future reference, as now I need to start the much harder task of implementing this generally in XGA, and the practise scripts are not a part of XGA.
no_crossarf_comp.txt
practise_crossarf.txt

Given I can now easily generate and store cross-arfs, I will round off the current dev branch (feat/crossARFGenerationAndStorage), and start a new branch related to the fitting process.

Note to self, need to make sure cross-arfs are read back in from the disk when a source/sample is re-declared and allowed to load already generated products. Currently they have to be regenerated each time, which is obviously daft.

This note to self didn't help very much, I forgot to implement this before merging the generation and storage branch - I will make sure to do it in this fitting branch that I'm working on now.

Actually the model setup (for the other annulus contributions) isn't quite right yet, as the constants are just set to one. Really I need to ensure that each cross-arf model component is linked to its specific model parameters from the 'original' model.

Parameter linking has gone wonky for some reason - when I was testing with more annuli etc the fits are failing with nonsensical parameter values (some which are way higher than the allowed values). Then when I look at the model setup this is what I see:

The linking is happening between the complete wrong parameters, so no wonder I have mad parameter values and everything is breaking!

The cross-arf files are not being saved with the names I intended - the detector map information isn't in there for instance.
Some of the XSPEC script names being generated are longer than the file system character limit (we've been here before) so time for another inventory file system I guess. I am considering this a triage effort until I add a proper backend database to keep track of everything, I think it would definitely be better than this.


refactor(alert): remove redundant matRipple usage

In the Alert Actions component the MatRipple directive was added redundantly in the component. Since MatRipple is already imported and used as a directive, it need to be included in hostDirectives of AlertActionDirective. This commit removes the redundant usage, improving code clarity.

Please delete spaces in array, make like this: hostDirectives: [MatRipple]

Sorry, my code editor did this 😑


RI workshop notebook ready for testing

Collapsed the getting started components into a singular notebook with better images and a rendering system for showcasing the impact of interactions on recommendations.
The data frame rendering changes should be ported into the other notebooks as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yifeim can you comment here?


_mod entity: should it be kept, dissolved, transformed, or embraced?

_mod was introduced and is used primarily to disambiguate different _defacemasks.  So, to a degree, it encapsulates the semantic that some, but not all, _suffixes correspond to MRI modalities (really)  as a summarized in a comment to #58.

#58

It is only present only when there is a _defacemask and only for anat/, while in effect most of the time corresponding to those suffixes "implicitly" where suffix does correspond to "contrast" (not modality really).

Samples from openneuro
$> for ds in ds*; do f=$(find $ds -iname *_mod-* | head -n 1); [ -z "$f" ] && continue; echo "$f"; done
ds000113/sub-01/ses-forrestgump/anat/sub-01_ses-forrestgump_acq-mag_mod-veno_defacemask.nii.gz
ds000224/sub-MSC01/ses-struct01/anat/sub-MSC01_ses-struct01_run-01_mod-T1w_defacemask.nii.gz
ds000233/sub-rid000001/anat/sub-rid000001_mod-T1w_defacemask.nii.gz
ds001297/sub-01/anat/sub-01_acq-filt_mod-T1w_defacemask.nii.gz
ds002718/sub-002/anat/sub-002_mod-T1w_defacemask.nii.gz
ds003645/sub-002/anat/sub-002_mod-T1w_defacemask.nii.gz
ds004192/sub-01/ses-localizer1/anat/sub-01_ses-localizer1_acq-prescannormalized_rec-pydeface_mod-T1w_defacemask.nii.gz
ds004712/sub-03286/ses-NOT1ACH001/anat/sub-03286_ses-NOT1ACH001_mod-T1w_defacemask.nii.gz

Also there is

#55

where the point of having _mod is coming up.  And as we are planing to proceed with

#54

if we get an entity _mod which actually corresponds to modality (mri, eeg, ...) not just mere contrast, it somewhat makes it then explicit and consistent to then "embrace" that entity and use it consistently to disambiguate all files, not just _defacemasks.
Note: if to be kept just for the sake of disambiguation of some _suffix2 (e.g. _defacemask) among different _suffixes (e.g. _T1w and _T2w) as it is  now, yet another use is _events.tsv files which came up in the context of

https://github.com/bids-standard/bids-specification/pull/1440

relates to this old issue:
https://github.com/bids-standard/bids-specification/issues/625


if there a simple config to remove these fold numbers

I know this is maybe a duplicate question https://github.com/kevinhwang91/nvim-ufo/issues/4 , but after upgrading to the latest version, this config doesn't work now:

vim config:
vim.o.foldcolumn = "1" -- '0' is not bad
vim.o.foldlevel = 99 -- Using ufo provider need a large value, feel free to decrease the value
vim.o.foldlevelstart = 99
vim.o.foldenable = true
vim.o.fillchars = [[eob: ,fold: ,foldopen:,foldsep: ,foldclose:]]

Yes, supply builtin.foldfunc to the segments table:
local builtin = require("statuscol.builtin")
require("statuscol").setup({
	relculright = true,
	segments = {
		{ text = { "%s" }, click = "v:lua.ScSa" },
		{ text = { builtin.lnumfunc }, click = "v:lua.ScLa", },
		{ text = { " ", builtin.foldfunc, " " }, click = "v:lua.ScFa" },
}

I guess information about the builtin functions is missing from the readme.

It seems like the expand icon clicks do not work.
I mean, whatever + or -, click them both will fold, not expand.

Fixed...

Thanks for the quick fix; no more issues now.


Balance our infra to give Forge Frontend more machines

Right now Forge Fe only has 1 machine allocated to it. This is causing a bottle neck on their development.
@nvukobratTT How many additional machines will ease the constrain?
@tapspatel How many machines can we afford to allocate to the FE side of things?
I know we looked into pooling which seemed non-trivial, however I wonder if there is a way to make this easier in the future / understand how our infra utilization is going.

@nsmithtt @tapspatel During this sprint, we plan to focus on E2E tests mostly for higher robustness. Therefore, we'll require more silicon CI machines than one.
What are the plans for MLIR testing? Do you have some estimates of the required workflow?
From the FFE perspective, it'll be good to have:

2 build runners - in the next few weeks 4 more folks will join FFE, so it'll be good to have those faster builders
2 more n150 runners - in the upcoming week or two, we're starting with robust op testing (e.g. testing added with many different variations and attributes e2e). This is mostly to error out FFE, MLIR, and TTNN/Metal bugs sooner rather than later, and plan accordingly for patching (especially focusing on the tt-nn side here).
Regarding n300, as multi-chip is still WIP, there is no need to have them on FFE as well

By the above points, it'll be good to balance things out a bit. Do you think that is possible?

After discussing this, we go with:
51/49 split in favor of forge-fe for the cases where we have an odd number of machines
tt-mlir
builder-1
builder-2
n150-1
n150-2
n150-3
n300-1
n300-2
tt-forge-fe
builder-3
builder-4
builder-5
n150-4
n150-5
n150-6
n300-3
n300-4
n300-5

Thanks! Will those appear here once added?

Yes. There are new VMs here as well so I need to setup docker, drivers, huge pages, etc first. Once this is done they will show as active runners.

Yes. There are new VMs here as well so I need to setup docker, drivers, huge pages, etc first. Once this is done they will show as active runners.

Sounds good! Thanks for pushing this further @vmilosevic 💪


Memory Leak when AC has no keys..

I fall in the same place twice...

@hxsnow10 Please provide a sample program.

@hxsnow10 Thank you!


Implement support for Exception tracking

When using Azure Application Insights, implement support for tracking exceptions

This feature was add with v0.0.4 thanks to @jt000


QUfitting outputs

The current QUfitting outputs are not very good. There should be json/dat key-value files with all the results saved in a clear form.

+1 on this! I'll note that on my local version I also save out the chains and labels objects to analyse the posterior distributions of fitted parameters. Currently these are lost at the end of execution

I found there is a file named ".txt" in QU-fitting outputs, which is treated as a hidden file. Is it normal?

@ShinsukeIdeguchi I tried to track down the source of this file. It seems to be created by the pymultinest Analyzer class.  The description of the file is:

"[root].txt
Compatable with getdist with 2+nPar columns. Columns have
sample probability, -2*loglikehood, samples. Sample
probability is the sample prior mass multiplied by its
likelihood & normalized by the evidence."

It's not clear to me if this is something the user would be interested in looking at? If so, some small modifications could be made to the code to make the file more visible.

Fixed this years ago and never closed the issue...


Workflow.retry that takes a function to decide if retry is needed

Is your feature request related to a problem? Please describe.
Workflow.retry RetryOptions.doNotRetry is a list of strings. So any exception is converted to a string before matching. In many scenarios, the retry is based on a specific information in a specific exception down the chain or even on some other information within the workflow body.
Describe the solution you'd like
An API that takes a function (or lambda) that can execute random user provided logic to decide if retry is needed.
Additional context
This only works for retries from the workflow code. The service side retries have to rely on string matching in the current architecture. An activity already can decide itself that the error is not retryable by throwing an non-retryable ApplicationFailure.

@niegus We typically don't provide ETAs for feature requests. Contributions are welcomed, this is a great starter feature.

How do you envision this feature? Workflow.retry retries based on the expiration parameter, plus the maximum attempts configured in the RetryOptions, always if the exception is not set in the list of doNotRetry exceptions.
If there is a new function/lambda to decide if the retry is need, how it would work with the current behavior? Taking precedence over them? Validate on the creation of the RetryOption so there can not be contradictions between the "retryOn" and "doNotRetry" ?

I think to have it consistent, it should be doNotRetryPedicate" and retry doesn't happen if doNotRetryPedicate(ex) || ex.getErrorType in retryOptions.getDoNotRetry().
But I'm getting back the comment about great starter issue.
I thought about a bit different place in the system (workflow method exceptions and failures).
Workflow.retry works with persisted side effects and it may get tricky.

@Spikhalskiy This feature request comes from this thread: https://community.temporal.io/t/temporal-queue-activities/3095/8 to retry in certain cases, doNotRetryPredicate() could do the trick, but it would require to write negative code 😅
Eg.
doNotRetryPredicate(ex -> !(ex.getCause() instanceof TimeoutFailure &&
               ((TimeoutFailure) ex.getCause()).getTimeoutType() == TimeoutType.TIMEOUT_TYPE_SCHEDULE_TO_START))

IMHO (as a customer of this lib) it would be easier:
retryOnPredicate(ex -> ex.getCause() instanceof TimeoutFailure &&
               ((TimeoutFailure) ex.getCause()).getTimeoutType() == TimeoutType.TIMEOUT_TYPE_SCHEDULE_TO_START)

WDYT? Would that make sense?


Karpenter does not respect volume-attach-limit set for EBS volumes.

Version

Karpenter Version: v0.27.0

Kubernetes Version: v1.24.10
Expected Behavior
Hello. We run Karpenter on EKS and limit the attacheble EBS volumes by setting --volume-attach-limit on the ebs-csi-node.
I would expect Karpenter to create new node, if existing nodes hit the limit already attached EBS volumes.
Actual Behavior
After the limit of attacheble EBS volumes over all nodes is hit, the PODs are stuck in pending state. No new nodes are created. All PODs show the same event:
0/5 nodes are available: 2 node(s) had untolerated taint {CriticalAddonsOnly: true}, 3 node(s) exceed max volume count. preemption: 0/5 nodes are available: 2 Preemption is not helpful for scheduling, 3 No preemption victims found for incoming pod.

Steps to Reproduce the Problem
On a test Cluster set --volume-attach-limit=5 on the ebs-csi-node. 3 Nodes available to run the following deployment with 20 replicas. I expect to get at least 1 additional node to run the entire workload.
apiVersion: apps/v1
kind: Deployment
metadata:
  name: echoserver
  namespace: default
spec:
  replicas: 20
  selector:
    matchLabels:
      app: echoserver
  template:
    metadata:
      labels:
        app: echoserver
    spec:
      containers:
        - image: ealen/echo-server:latest
          imagePullPolicy: IfNotPresent
          name: echoserver
          ports:
            - name: http
              containerPort: 8080
          env:
            - name: PORT
              value: '8080'
          resources:
            requests:
              memory: 64Mi
              cpu: 10m
            limits:
              memory: 128Mi
              cpu: 40m
          securityContext:
            runAsNonRoot: true
            runAsUser: 101
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: false
            capabilities:
              drop:
                - ALL
            seccompProfile:
              type: RuntimeDefault
          volumeMounts:
          - mountPath: "/scratch"
            name: scratch-volume
      securityContext:
        fsGroup: 101
      volumes:
        - name: scratch-volume
          ephemeral:
            volumeClaimTemplate:
              metadata:
                labels:
                  type: my-test-volume
              spec:
                accessModes: [ "ReadWriteOnce" ]
                resources:
                  requests:
                    storage: 3Gi

Here you can see the limitation by the ebs driver does work:
kubectl get nodes -o json | jq '.items[] | {"nodeName": .metadata.name, "volumesInUse": .status.volumesInUse | length, "volumesAttached": .status.volumesAttached | length }'
{
  "nodeName": "ip-xx-xx-xx-xx.eu-central-1.compute.internal",
  "volumesInUse": 5,
  "volumesAttached": 5
}
{
  "nodeName": "ip-xx-xx-xx-xx.eu-central-1.compute.internal",
  "volumesInUse": 5,
  "volumesAttached": 5
}
{
  "nodeName": "ip-xx-xx-xx-xx.eu-central-1.compute.internal",
  "volumesInUse": 5,
  "volumesAttached": 5
}

Also here:
k get csinode ip-xx-xx-xx-xx.eu-central-1.compute.internal -o yaml
apiVersion: storage.k8s.io/v1
kind: CSINode
metadata:
  ...
spec:
  drivers:
  - allocatable:
      count: 5
    name: ebs.csi.aws.com
    nodeID: i-xxxxxxxxxxxx
    topologyKeys:
    - topology.ebs.csi.aws.com/zone

Resource Specs and Logs
There is literally nothing in the carpenter controller logs after deployment was applied.
Provisioner spec:
apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: default
spec:
  consolidation:
    enabled: true
  kubeletConfiguration:
    clusterDNS:
      - xxxxxx
    maxPods: 110
  limits:
    resources:
      cpu: 1k
  providerRef:
    name: private-node
  requirements:
    - key: karpenter.sh/capacity-type
      operator: In
      values:
        - spot
        - on-demand
    - key: kubernetes.io/arch
      operator: In
      values:
        - amd64
    - key: karpenter.k8s.aws/instance-hypervisor
      operator: In
      values:
        - nitro
    - key: karpenter.k8s.aws/instance-cpu
      operator: Gt
      values:
        - '3'
    - key: karpenter.k8s.aws/instance-cpu
      operator: Lt
      values:
        - '129'
    - key: kubernetes.io/os
      operator: In
      values:
        - linux
    - key: karpenter.k8s.aws/instance-category
      operator: In
      values:
        - c
        - m
        - r
    - key: karpenter.k8s.aws/instance-generation
      operator: Gt
      values:
        - '2'
  startupTaints:
    - effect: NoExecute
      key: node.cilium.io/agent-not-ready
      value: 'true'
  ttlSecondsUntilExpired: 604800
  weight: 95

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

https://github.com/aws/karpenter/issues/1888
@tzneal would this help in this regard?

Can you share your default StorageClass that is associated with the PVC that you are provisioning for this deployment

This looks to be a potential duplicate of https://github.com/aws/karpenter-core/issues/260. Can you confirm if you might be hitting the edge case that is described here

Can you share your default StorageClass that is associated with the PVC that you are provisioning for this deployment

k get storageclasses.storage.k8s.io
NAME               PROVISIONER             RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE ebs-sc (default)   ebs.csi.aws.com         Delete          WaitForFirstConsumer   true                   13h gp2                kubernetes.io/aws-ebs   Delete          WaitForFirstConsumer   false                  13h

Can you share the events from the pods that aren't scheduling?

Can you share the events from the pods that aren't scheduling? Ideally, want to see if Karpenter thinks that the pods should schedule on your current set of nodes

0/5 nodes are available: 2 node(s) had untolerated taint {CriticalAddonsOnly: true}, 3 node(s) exceed max volume count. preemption: 0/5 nodes are available: 2 Preemption is not helpful for scheduling, 3 No preemption victims found for incoming pod. @jonathan-innis

@ajaykumarmandapati Can you share the full StorageClasses, PersistentVolumes, and the PVCs that are associated with the pods that don't schedule?

 Also, getting the full output -o yaml from nodes that Karpenter scheduled for these PVs would be good as well. You can attach them as files in your response if they get too long.

output-yaml.zip
I've attached them 👍🏾

Can you share the full output of CSINodes as well?

@jonathan-innis Please find the attachments requested.
final-output.zip

If there are no logs, have you tried restarting the karpenter pods? Also, could you enable debug logs on your logging if you haven't already? It's difficult to debug this issue or figure out what's going on without the logs here.
I'm not able to repro issue when I deploy a similar configuration on my cluster running the same version of Karpenter.

Hi @jonathan-innis Even enabling the debug didin't show anything. There are just no logs after createing the Deployment. We also double checked everything to make sure nothing else disturb the tests. An interesting thing also was, that you mentioned to run your test as a statefulSet. This is different from us. And yes, it worked finally with the statefulSet!
So the problem must be somewhere in the deployment spec for the volumes:
...
    volumes:
      - name: scratch-volume
        ephemeral:
          volumeClaimTemplate:
            metadata:
              labels:
                type: my-test-volume
            spec:
              accessModes: [ "ReadWriteOnce" ]
              resources:
                requests:
                  storage: 3Gi

Is it the type ephemeral with a volumeClaimTemplate? Kubernetes wise it is correct and creates PVCs and PVs.

@sdomme Yep, you're right. This problem is specific to volumeClaimTemplates that exist in the ephemeral storage volume bucket for pods. It looks like we aren't discovering the default StorageClass name when using the default StorageClass. Can you try to specify the storageClassName as a workaround for now and see if that fixes your issue?

@jonathan-innis Cool.  It helped indeed to set the storageClassName. Looking forward to have the fix generally available.
Many thanks. 👍🏻


Quantization support

How to use 8bit quantized models? Can I run GGML/GGUF models?

Any examples?

parser.add_argument("--mode", type=str, default=[], nargs='+',
                    help="Model mode: [int8kv] [int8weight | int4weight]")

As for the model file format, we have not tested GGML/GGUF up to now. What is the motivation to use these formats?

Will GPTQ be supported?

@XHPlus There's a lot of open source models on HuggingFace driven by https://huggingface.co/TheBloke. Many people in the open source community use those quantized models on TGI / vLLM.

parser.add_argument("--mode", type=str, default=[], nargs='+',
                    help="Model mode: [int8kv] [int8weight | int4weight]")

Using this option with Llama2-13B gives this error:
_get_exception_class.<locals>.Derived: 'LlamaTransformerLayerWeightQuantized' object has no attribute 'quantize_weight'
I tried both  --mode int8kv int4weight and  --mode int8kv int4weight
Any suggestions how to fix this?


AWS ElasticSearch

Is it possible to use AWS Elasticsearch? If it is possible, what is the configuration needed?

It should be possible in theory. You can try changing the configs here: https://github.com/linkedin/datahub/blob/master/gms/factories/src/main/java/com/linkedin/common/factory/RestHighLevelClientFactory.java

Note that we're using 5.6.8 of the client API, which could cause issues. If you do get this working, please document what steps you had to take, if any weren't straight forward. That way we can either add a patch to make it easier in the future, or the very least add some documentation. Thanks!

Let's concentrate the discussion in this issue: https://github.com/linkedin/datahub/issues/1722


First PATCH request after garbage PATCH request fails too

Some PATCH requests with syntax errors apparently bring the server into a state where the next (unrelated) PATCH request fails too. I suspect this is because the parser is reused but it hadn't been reset properly after the parse error?
To reproduce:
curl -X PUT -d'<#this> <#is> <#wrong> .' -H 'Content-Type: text/turtle' http://localhost:3000/some/resource.ttl

curl -X PATCH -d'DELETE DATA { <#something> <#completely> <#different> . } garbage' -H 'Content-Type: application/sparql-update' http://localhost:3000/some/unrelated/resource.ttl

curl -X PATCH -d'DELETE DATA { <#this> <#is> <#wrong> . }' -H 'Content-Type: application/sparql-update' http://localhost:3000/some/resource.ttl
echo First attempt after unrelated parse error:
curl http://localhost:3000/some/resource.ttl
echo

curl -X PATCH -d'DELETE DATA { <#this> <#is> <#wrong> . }' -H 'Content-Type: application/sparql-update' http://localhost:3000/some/resource.ttl
echo Second attempt after unrelated parse error:
curl http://localhost:3000/some/resource.ttl
echo
echo Done.

Expected output:
[...]
First attempt after unrelated parse error:

Second attempt after unrelated parse error:

Done.

Actual output:
[...]
First attempt after unrelated parse error:
<#this> <#is> <#wrong>.

Second attempt after unrelated parse error:

Done.

Did some small tests, on the first correct PATCH attempt, the translate function of the SparqlAlgebra.js library is called with { baseIRI: http://localhost:3000/some/resource.ttl }, but the output is
{
  "type": "deleteinsert",
  "delete": [
    {
      "termType": "Quad",
      "value": "",
      "subject": {
        "termType": "NamedNode",
        "value": "http://localhost:3000/some/unrelated/resource.ttl#this"
      },
      "predicate": {
        "termType": "NamedNode",
        "value": "http://localhost:3000/some/unrelated/resource.ttl#is"
      },
      "object": {
        "termType": "NamedNode",
        "value": "http://localhost:3000/some/unrelated/resource.ttl#wrong"
      },
      "graph": {
        "termType": "DefaultGraph",
        "value": ""
      },
      "type": "pattern"
    }
  ]
}

So the wrong previous baseIRI seems to be cached there after a parsing failure. Will have to be investigated there.

Solved in 55fddf8e6068ade3d5f021b3ab2f69dcfe483c46


Cursor theme doesn't work

After the restoring system, cursor is not set, it's still adwaita

Dat wa not a bug, dat was problem on VM side


New (binary) release?

I would be interested in kubeaudit, but the latest release is from November 2017. Do you have plans to have a new release cut in the near future and providing the binary to download?

@hjacobs Soon we would release a new binary but for the time being if you don't mind building from source using go install or something?

Thanks!


Jump to the error line by clicking on the line vscode (python, interactive window)

Discussed in https://github.com/microsoft/vscode-jupyter/discussions/10390

Originally posted by zhaoguangyuan123 June 10, 2022
Same as the question in the link:
https://github.com/microsoft/vscode/issues/117783
I want to jump to the error Line by clicking the line on the output of the interactive window, but I find it is dark and I am not able to click.
Is this caused by extension error?
if so, how can i solve the issue?

this should already work today.
ill transfer this to the issue.
please could you provide the following information:

version of python
are you connected to a remote or local kernel?
output from the Jupyter output panel (use the command Jupyter : Sow Output)

The version of 'ipython' is critical to see why this isn't working. If the version is less than 8.0, then it's not supported.

Sorry for my late reply. Below is the information:
version of python
Python 3.8.5
are you connected to a remote or local kernel?
local kernel on MAC
output from the Jupyter output panel (use the command Jupyter : Sow Output)
version of 'ipython'
7.22

The version of 'ipython' is critical to see why this isn't working. If the version is less than 8.0, then it's not supported.

Thanks a lot, it works when I upgrade Ipython from 7.22 to 8.4.
Best
Guangyuan


[English] modify the content  in database_as_a_service.md

The origin text in database_as_a_service.md is:

Database-as-a-Service (DBaaS) is a service managed by a cloud operator (public or private) that supports applications without requiring the application team to perform traditional database administration functions.

The cloud  actually links to cloud_computing doc.
Do we need to update cloud  to  cloud computing ?

I think the "cloud" suits perfectly well for this Explanation instead of "cloud computing"  grammatically.

Hi @Submarinee
Thank you for the suggestion ! :)
I am one of the maintainers of this repo. I think most of people can understand the context with cloud without complete words cloud computing.
So, I hope to close this issue if you agree with it.

Thanks for all your comments. I agree with you.


Step Function Data Science SDK example not deploying model endpoint properly

Hi @shunjd,
This is the sample noteboook I'm executing:
https://github.com/awslabs/amazon-sagemaker-examples/blob/346811d27ba9e1cd6a3db94a90f584b951f7aa33/step-functions-data-science-sdk/training_pipeline_pytorch_mnist/training_pipeline_pytorch_mnist.ipynb
The Training Pipeline is not deploying the model endpoint. CloudWatch logs show the following errors:
FileNotFoundError: [Errno 2] No such file or directory: 'nginx': 'nginx'
and
Traceback (most recent call last):
  File "/opt/conda/bin/serve", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.6/site-packages/sagemaker_containers/cli/serve.py", line 19, in main
    server.start(env.ServingEnv().framework_module)
  File "/opt/conda/lib/python3.6/site-packages/sagemaker_containers/_server.py", line 82, in start
    nginx = subprocess.Popen(["nginx", "-c", nginx_config_file])
  File "/opt/conda/lib/python3.6/subprocess.py", line 709, in __init__
    restore_signals, start_new_session)
  File "/opt/conda/lib/python3.6/subprocess.py", line 1344, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)

Any suggestions? Thanks!

The Step Function workflow shows actually as successful, but the endpoint creation failed.

@shunjd i'm also having this issue.  any update?

Hi @cfregly @antje, thanks for reporting the issue, we are investigating it with the SageMaker team.

Hi @shunjd, I'm also having the same issue, any updates?

Hi @Bjarten, we are still waiting for the SageMaker team to respond, I will update the ticket once they have finished their investigation.


Auto-detach kernel driver (Fix #22)

Hi Sebastian,
Unfortunately with your latest changes in master, cherryrgb_cli crashes here (will file a separate Issue for that tommorow).
Therefore my fix for #22 is NOT against master, but against the tag 0.2.3

Thanks, good find! Did not realize the kernel driver is responsible for handling the special keys..
I am curious, as this never occured to me: How is a PR towards master, not based off current HEAD gonna be merged?
Other than rebasing it of course...
What am I missing?

Those crashes should be fixed with latest master.. but out of scope for this PR anyways.

In that case, I will make another PR against master...

No worries, I can just rebase here. I was honestly wondering about the way to merge a PR against non-HEAD tho, how it is expected to deal with. Does it tell the maintainer "I only tested and can verify a working state until this tag" ?

No worries, I can just rebase here. I was honestly wondering about the way to merge a PR against non-HEAD tho, how it is expected to deal with. Does it tell the maintainer "I only tested and can verify a working state until this tag" ?


Update 3rdparty 20161027

update rapidjson and msgpack

Coverage remained the same at 84.996% when pulling 45f752a27a222cb8b60feb9931d9d8ae661754c4 on hendrik-cliqz:update-3rdparty-20161027 into b8e57e6207244cc570e0d7d3970015aa1faf4254 on cliqz-oss:master.


CI: focal jobs are failing

eg. https://github.com/yamt/toywasm/actions/runs/11444226145/job/31838737183?pr=265
E: Unable to locate package clang-13
E: Unable to locate package lld-13

https://launchpad.net/ubuntu/focal/amd64/clang-13
Removed from disk on 2024-10-07.
Removal requested on 2024-10-07.
Deleted on 2024-10-07 by [Timo Aaltonen](https://launchpad.net/~tjaalton)

the sru won't be finalized, will remove instead


Don't work Blame

Hi
I try to view "Blame" view by URL like this http://localhost/Bonobo.Git.Server/Repository/test2/15488199c3d84c78ce2b380df696d577e1b7d151/Blame/error404.txt
But last condition in this line returns true https://github.com/jakubgarfield/Bonobo-Git-Server/blob/master/Bonobo.Git.Server/RepositoryBrowser.cs#L156 ((commit[path].Target as Blob).IsBinary)
As result:

But I expect to see something like this: https://github.com/SanSYS/test/blame/15488199c3d84c78ce2b380df696d577e1b7d151/error404.txt

Commit da2c80058bfc7f25665a84affdf07ffdbe692036 from @igoryok-zp resolves problem


Register variable which can be used later in a playbook to test if ru…

…les where changed.

Thanks for your PR, @haad. Please could you explain for what exactly you want to use the variable later in the playbook?

To be able to detect a change. In which case i have to reboot server to
apply new settings.
On Jan 30, 2017 12:21 AM, "Jiri Tyr"<EMAIL_ADDRESS>wrote:

Thanks for your PR, @haad https://github.com/haad. Please could you
explain for what exactly you want to use the variable later in the playbook?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jtyr/ansible-udev_rename_netiface/pull/1#issuecomment-275954863,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEIzslAJr0ywpQ9PSHSvJtT_oH1GwTRks5rXR71gaJpZM4Lw7xd
.

Merged. Thanks for your PR.


validate_on_init or pydantic_run_validation still doesn't work

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
I tried to set above class variable or validate_on_init to False, but dataclass still call method "pydantic_validate_values" I want to initialize pydantic dataclass with field values with different field type. but it always throws pydantic error. something similar to BaseConfig.construct.
Sample code - all fails with
pydantic.error_wrappers.ValidationError: 1 validation error for MySQLConfig
port
value is not a valid list (type=type_error.list)
Example Code
@dataclass()
class MySQLConfig:
    driver: Dict[str, str] = field(default_factory=dict)
    port: List[str] = field(default_factory=list)
    password: int = MISSING
    user: str = MISSING
    new_test: Optional[int] = 2

    @validator("user")
    @classmethod
    def validate_supported_host(cls, user: str, values, **kwargs):
      if user in ["alex", "le"]:
          raise ValueError(f"'user' can only be [alex, le] got: {user}")
      return user

config = MySQLConfig(driver={"test":"omry"}, port="13", password=3, validate_on_init=False)
config = MySQLConfig(driver={"test":"omry"}, port="13", password=3, __pydantic_run_validation__=False)
config = MySQLConfig(driver={"test":"omry"}, port="13", password=3, validate_on_init=False).__pydantic_run_validation__=False

Python, Pydantic & OS Version
pydantic version: 1.10.2
pydantic compiled: True
install path: /home/runner/VainSuperficialEmulators/venv/lib/python3.8/site-packages/pydantic
               python version: 3.8.12 (default, Aug 30 2021, 16:42:10)  [GCC 10.3.0]
                     platform: Linux-5.15.0-1017-gcp-x86_64-with
optional deps. installed: ['typing-extensions']

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[X] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[x] Function validation decorator
[ ] Generic Models
[x] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Settings Management
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

@samuelcolvin @PrettyWood Can you help take a look. my project depends on this

@PrettyWood
The error is below -
pydantic.error_wrappers.ValidationError: 1 validation error for MySQLConfig
port
value is not a valid list (type=type_error.list)

when I am trying to pass list instead of string for port. the error comes from pydantic and that is why I was tryin to use validate_on_init or pydantic_run_validation to avoid this pydantic validation errors.
Can you help me finding a way to avoid pydantic validation errors when we pass different field type value? this works with stdlib dataclasses?


[vim] implement g0 g$ g

commands for go line start/end for wrapped mode were missing

Thank you for implementing this! I hope this propagates soon to @obsidianmd and overleaf :)


[HOLD for payment 2023-10-16] [$500] propTypes warning - policy is marked as required in MoneyRequestHeader

Note this one is maybe just holding on the TS migration since we are deprecating propTypes IIRC cc @hayata-suenaga
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d965fee45c4003a6
Upwork Job ID:<PHONE_NUMBER>663089664
Last Price Increase: 2023-09-08

@marcaaron We're still requiring propTypes in JavaScript files. If there is an issue with what is specified in propTypes and the actual type being passed to a prop, we should keep fixing those errors 🙇
Having correct propTypes will also aid TypeScript migration process as migration engineers can rely on propTypes when defining TypeScript types.

After made a quick analysis to the related files, here's what I found and my proposed solution:
Component Tree
How the policy is used in the context of this issue:
ReportScreen.js -> MoneyRequestHeader -> HeaderWithBackButton -> AvatarWithDisplayName

policy object is defined and first supplied in <ReportScreen/>

const policy = policies[`${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`];

<MoneyRequestHeader/> and <HeaderWithBackButton/> is only passing down the props
Actual usage of policy object is in <AvatarWithDisplayName/> component

propTypes Inconsistencies
There is propTypes inconsistencies amongs components:

Here is the propTypes policy in <MoneyRequestHeader/>:

/** The policy which the report is tied to */
policy: PropTypes.shape({
    /** Name of the policy */
    name: PropTypes.string,
}).isRequired,

Here is the propTypes policy in <HeaderWithBackButton/>:

/** The report's policy, if we're showing the details for a report and need info about it for AvatarWithDisplay */
policy: PropTypes.shape({
    /** Name of the policy */
    name: PropTypes.string,
}),

Here is the propTypes policy in <AvatarWithDisplayName/>:

/** The policy which the user has access to and which the report is tied to */
policy: PropTypes.shape({
    /** Name of the policy */
    name: PropTypes.string,
}),

As we can see from above codes, <MoneyRequestHeader/> marks policy as required, but <HeaderWithBackButton/> and <AvatarWithDisplayName/> is treating it as optional props.
Proposed Solution
Mark policy object as optional
If policy is actually not a required in the runtime usage, then the solution is simply remove isRequired mark  in the <MoneyRequestHeader/> propTypes.policy.
This change will also fixes the propTypes inconsistencies amongs different components in the Component Tree I mentioned above.
Supporting evidence
If we are looking into the actual use of policy object in <AvatarWithDisplayName/> it is supplied to ReportUtils.getIcons, and if we open the method signature, it looks like this:
function getIcons(report, personalDetails, defaultIcon = null, isPayer = false, defaultName = '', defaultAccountID = -1, policy = undefined) {
  // the code
}

As we can see, policy here is supplied with default value of undefined, which means it is actually an optional parameter. So it makes sense to also mark propTypes.policy as optional.
Beyond The Problem in This Component Tree
The original problem on this github issue should be solved with the proposed solution above.
Here I just want to make an additional comments with regards to policy object usage in general.
More propTypes inconsistencies
In src/pages/home/ReportScreen.js policies propTypes is an array shape of policy shape that have property of name and type :
policies: PropTypes.objectOf(
    PropTypes.shape({
        /** The policy name */
        name: PropTypes.string,

        /** The type of the policy */
        type: PropTypes.string,
    }),
),

Meanwhile, in src/pages/home/report/ReportActionsView.js propTypes policy is defined as below:
policy: PropTypes.shape({
    /** The name of the policy */
    name: PropTypes.string,

    /** The URL for the policy avatar */
    avatar: PropTypes.string,
})

It has avatar property.
So far we have 3 different shape of the same policy object.

with name property only (in <MoneyRequestHeader/>, <HeaderWithBackButton/> and <AvatarWithDisplayName/>)
with name and type as in src/pages/home/ReportScreen.js
with name and avatar as in src/pages/home/report/ReportActionsView.js

If you are about to migrate to typescript, you will need to unify the Policy type / interface and shares this accross component, this will make consistent.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/muhammada1457

During component transitions, we must prevent it from moving to the next component before the policy prop data arrives.
Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01f0c399b94f4fb448

@sobitneupane have you had a chance to review the proposals that have come in?

Thanks for proposal everyone. If policy is an optional prop, it is better to remove isRequired and add a default value for it. Proposal from @azamuddin looks good to me.
🎀 👀 🎀 C+ reviewed

@tienifr I don't think your proposal is substantially different from the one selected. I think adding default value goes along with removing isRequired.

@tienifr It's the same change in a different file. I think that would have been caught and addressed in PR review if it also has the same console error.
If @puneetlath doesn't think otherwise, I would suggest going with https://github.com/Expensify/App/issues/26991#issuecomment-1718903800

I agree with going with @azamuddin's proposal here. It seems sufficiently thorough to me for the situation. Thanks for your proposals everyone!

@azamuddin When can we expect a pull request from you?

We assigned it to @azamuddin Melvin!
@azamuddin ETA for a PR?

@azamuddin I've sent you an offer on Upwork.
For the issue you're seeing, I'm not quite sure I understand. Can you explain further? Or better yet, raise it in the #expensify-open-source channel and tag @sobitneupane and I? Thanks!

Thanks @puneetlath, I have accepted the offer on Upwork.
I run the app locally on web and ios platform, I still couldn't reproduce the issue since my account has "policy" data just fine thus the warning never appear.
I need to ask how to reproduce the issue, but I could not join #expensify-open-source https://expensify.slack.com/archives/C01GTK53T8Q because my email is not a member, could you help me to be able to join the slack? my email is<EMAIL_ADDRESS>

Hmm, interesting. So you're saying that you're no longer able to reproduce the issue?
@sobitneupane are you able to?

I was able to reproduce the issue.

@puneetlath I meant I didn't know how to reproduce it because there's no information in this GH issue (previously I just read the codebase to formulate the proposal)
But after you invited me to Slack, I read the message on how to reproduce it and I did reproduce it and make sure the issue is solved (https://expensify.slack.com/archives/C049HHMV9SM/p1693657079886579)
Already made PR here https://github.com/Expensify/App/pull/28213

Ah ok, great!

PAYMENTS FOR OCT 16

@azamuddin (Contributor) - [$500 - no bonus]
@sobitneupane (Reviewer) 🚫 Upwork payment (please request manually in Expensify Chat)

@sobitneupane can you complete the checklist above?

@azamuddin payment made and contract ended - thank you! 🎉

@sobitneupane can you complete the checklist above prior to requesting payment in Expensify Chat

Last action needed here:
@sobitneupane  completes the checklist
Payment for:
@sobitneupane (Reviewer) [$500 - no bonus] 🚫 Upwork payment (please request manually in Expensify Chat)

@sobitneupane can you complete the checklist above?

@abekkala Sorry for the delay. I was OOO. I will try to get it done in the weekend.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/22484

[ ]  [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/22484/files#r1375904116

[ ]  [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

It is an edge case and appears only for deleted workspace. It is quite difficult to catch such issues.

[ ]  [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[ ]  [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

https://github.com/Expensify/App/issues/26991#issuecomment-1772790978
Requested payment on newDot.

closing this as payment is handled in newdot and has already been requested

$500 payment approved for @sobitneupane based on this comment.


Cilium and jenkins entity definition checkins

This PR is part of the onboarding of new Curated Experiences for Cilium and Jenkins. This effort is a partnership between newrelic and Kinect-Consulting.
Relevant information
Describe what you have done and any details that you think are relevant or that you might want to discuss with us.
Checklist

[ yes] I've read the guidelines and understand the acceptance criteria.
[yes ] The value of the attribute marked as identifier will be unique and valid.
[yes] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


output/svg.js contains a circular dependency when compiling using rollup.js

When I try to compile the CommonJS files in mathjax-full/js I am usually successful except in the case of mathjax-full/js/output/svg.js.
I put together a node project here that you can test out by checking out, npm installing, opening a node shell, and running
const demo = require('./rollup-mathjax-demo.js');
demo('mathjax-full/js/output/svg.js, 'svg');

You end up with the following errors:
Circular dependency: node_modules/mathjax-full/js/output/svg.js -> node_modules/mathjax-full/js/output/svg/WrapperFactory.js -> node_modules/mathjax-full/js/output/svg/Wrappers.js -> node_modules/mathjax-full/js/output/svg/Wrapper.js -> rollup-mathjax-demo/node_modules/mathjax-full/js/output/svg.js?commonjs-proxy -> node_modules/mathjax-full/js/output/svg.js
(node:96533) UnhandledPromiseRejectionWarning: Error: '__moduleExports' is not exported by node_modules/mathjax-full/js/output/svg.js, imported by rollup-mathjax-demo/node_modules/mathjax-full/js/output/svg.js?commonjs-proxy

It is true that js/output/svg/Wrapper.js does import a string from js/output/svg.js, which seems to be the source the problem with Rollup.  Rollup is probably being too conservative, here.  See this issue for some related discussion.
In this case, it would be possible to move the strings to a separate file that is imported into both svg.js and Wrapper.js and I think that would resolve the issue.
In the meantime, if you are willing to recompile the js files, you could edit ts/output/svg/Wrapper.ts to include the XLINKNS string directly rather than importing it, and then
cd node_modules/mathjax-full
npm install
npm run compile
cd ../..

to make the change.
Or if you would rather you could probably edit the Wrapper.js file to change line 43 from
var svg_js_1 = require("../svg.js");

to
XLINKNS = 'http://www.w3.org/1999/xlink';

and then remove svg_js_1. from line 236 making it
this.adaptor.setAttribute(use, 'href', id, XLINKNS);

and that should also do it.

I'm marking this a feature request (to separate out the strings).


Geometry Editor Plugin

Similar to how http://geojson.io/ and Mapbox studio expose a geometry editor. It would be great having an Android plugin to achieve this for end-users more easily on Android (versus having to roll their own version).
This plugin would take care of visualising selection and generating the final geometry.

Two Mapbox demo app examples that could help in some way with this plugin if this plugin is ever worked on:
https://github.com/mapbox/mapbox-android-demo/pull/983
https://github.com/mapbox/mapbox-android-demo/pull/868

Please guide me how to turn [my project](plugin-draw #1146) into a plugin. Does anyone participate in this? Let me know if this is really necessary.


LightmapGI does not take into account the alpha channel of texture

Godot version
4.0.1 RC1
System information
Windows 10
Issue description

Without baked light

Baked Light
Steps to reproduce
Create a new MeshInstance3D, add a texture with an alpha channel to it, in the material settings, set the alpha scissors . Create LightmapGI and bake the light
Minimal reproduction project
N/A

@ONION-777 Please upload a minimal reproduction project to make this easier to troubleshoot.

@ONION-777 Please upload a minimal reproduction project to make this easier to troubleshoot.

Baking light.zip

Closing in favor of https://github.com/godotengine/godot/issues/77590, which contains both Godot 3 and 4 MRPs for easier comparison.


Is there any function like step() in box2d engine?

It's Matter.Engine.update(ENGINE, 1000/60) :+1:


Add a E2E smoke test to confirm the scan works

This PR creates a E2E smoke test which will:

Create a kind cluster.
Deploy the security-scan.
Wait for the Daemonset to be created.
Output the CIS Benchmark results (or errors during the process).

A timeout of 10 minutes has been set, in case the process gets stuck for some reason.

@pjbgf could you please resolve the conflicts? Then we can reviewing it.
cc: @andypitcher @JonCrowther

@rayandas we resolved the conflicts, PTAL.

@JonCrowther Could you please review this?

Just as a heads up, this makes a similar change to this PR:
https://github.com/rancher/security-scan/pull/107

@JonCrowther nice shout, added that to the PR details.

Is there anything hold us back from merging this?

Relates to https://github.com/rancher/cis-operator/issues/151.

Relates to https://github.com/rancher/rancher/issues/40914.


Enderman block-place

enderman can place blocks inside of claims
used gddebug and no event flags listed for them placing blocks
tested on spigot and paper

Provide exact versions and link to gddebug with no filter.

git-Paper-282 (MC: 1.16.4)
GD 1.5.4-DEV4
gddebug
the enderman can place a block inside of the claim that it picked up from outside the claim
block-break for grass_block its it picking up the block doesn't show any block-place when it puts it down


"Create a Pull Request" view should be instantly available for interaction

Following up on discussion in https://github.com/microsoft/vscode-pull-request-github/issues/5399, it would be great if create PR view could be instantly available for interaction, ie editing PR name & description, and create PR buttons. (I wouldn't mind if it errored out because of upstream issues (eg I'm blocked from sending PRs) because it would happen rarely)
cc @jrieken @joaomoreno

A new setting value will skip the work we do to provide a title and description if you want it to be faster: "githubPullRequests.pullRequestDescription": "none".

Verified with "githubPullRequests.pullRequestDescription": "none".


Does support the Kerberos based authentication?

Does support the connectivity to kafka cluster if it kerberosized?

yes, but the support is limited, at least based on my experience
related to issue #333
try setting handshake-first=true under sasl
and noverify=true for tls
no such support for zookeeper servers though

I'm also interested in keytab authentication... any update please ?

Didn't ever see an update here. So, can Burrow auth using SASL_PLAINTEXT + Keytab ?
Thanks much!

As far as I know, no... but sarama (which is used by Burrow does): since version 1.2.3 (Add kerberos support (https://github.com/Shopify/sarama/pull/1366))
It seems that the options needs to be exposed :1st_place_medal:
https://github.com/Shopify/sarama/pull/1366/files#diff-b4bda758a2aef091432646c354b4dc59R532
Apparently, this has to be done here: https://github.com/linkedin/Burrow/blob/334be9125dcb3d0b5cddbee3f69cb956419d5a9e/core/internal/helpers/sarama.go#L118
Best,
Jerome


Remove oct/bin floating point literals

Closes #12667
Closes #12662

I think this warrants a dedicated error message, like Rust's "octal float literal is not supported"


fix(bufferCount): set default value for skip argument, do not emit em…

…pty buffer at the end.
Found while try to write micro perf test for bufferCount, when bufferCount does not have explicit skip argument (startBufferEvery parameter) it only emits very first buffer element then completes observable. This PR aligns bufferCount behaves as same as current bufferWithCount (https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/bufferwithcount.md) by set default skip argument to size of buffer if it's not specified.

Good catch. I suspect we'll be finding lots of bugs like this as we convert tests over to use the Virtual Time Scheduler and expand testing to cover more scenarios.

Thanks @kwonoj!


I want to run the server in the BackGround and i want to stop the server when the testing is completed

hi, did you find any solution?


Add min/max support

(see title)

Ah actually, hold off on reviewing, realized this isn't actually complete yet.

Looked great @pratiksha  merged!


Want to add REVERSE ARRAY or REVERSE STRING in C++

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Given an array, the task is to reverse the array.
Examples →
Input  : arr[] = {34, 12, 23}
Output : arr[] = {23, 12, 34}
Input :  arr[] = {1, 2, 3, 4, 5, 6}
Output : arr[] = {6, 5, 4, 3, 2, 1}
We will be discussing a simple approach to reverse the array in-place. In place means, we will not be using some auxiliary space.
To reverse an array, we will use the concept of swapping. Swapping is a term used for interchanging the values at two different locations with each other.
OPTIMIZED SOLUTION
Time Complexity: O(n)
Space Complexity: O(1)

Please Assign this issue to me @Kumar-laxmi ... I want to contribute this

Please Assign this issue to me @Kumar-laxmi . I want to contribute this in ( Python, C++, C, Java)

@Kumar-laxmi Sir Kindly assign this issue to me I would like to contribute to it and come up with most optimized solution.

Can you Assign this to me i can solve this problem in the c  cpp and python

I can do this by applying two pointers approach where two pointers will be pointing to start and end element of the array respectively and then swapping will be done of starting and ending element.
Then the start pointer will be incremented and end pointer will be decremented. This procedure will be followed until start is smaller than end pointer.
Kindly assign me this issue I can implement this.


typescript-vue-apollo lazy operations

Is your feature request related to a problem? Please describe.
Currently, there is only a generation with useQuery but sometimes you maybe want to have also useLazyQuery
Describe the solution you'd like
Add an additional generation for a lazy variant

Duplicate https://github.com/dotansimha/graphql-code-generator/pull/7340


EAV Organization Needs Table

The current model of modeling needs of an organization is done with a needs column in the Organizations table on Postgres. This doesn't work great when you want to have subsets or more complex matching. We should instead:
CREATE TABLE organization_needs(
    organization_id int PRIMARY KEY NOT NULL,
    need string NOT NULL
);

And we should also drop the needs column from the Organizations table. This means we'll also need to touch up the data insertion script, and the add-organization[s] endpoints to instead insert into this new table.

https://github.com/jbyman/covid-hackathon/pull/56

Done!


SessionToken creation error: class MediaSessionCompat not found

Media3 Version
1.0.0-beta03
Devices that reproduce the issue

Samsung Galaxy A5 2017 (Android 8)

Devices that do not reproduce the issue
No response
Reproducible in the demo app?
No
Reproduction steps

Follow the official tutorial
Override the onStart method to create a SessionToken with

SessionToken sessionToken = new SessionToken(
   this,
   new ComponentName(this, PlaybackService.class)
);

Build the app

Expected result
The app should build normally
Actual result
Build fails with:
        SessionToken sessionToken = new SessionToken(
                                    ^
  class file for android.support.v4.media.session.MediaSessionCompat not found

Media
Not applicable
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Hi @davide99,
Have you tried to clear and rebuild your project on Android Studio?
If the problem is still there after rebuilding, could you please attach your minimum reproducible sample project here or zipped up and sent it to<EMAIL_ADDRESS>using a subject in the format "Issue #1234", where "#1234" should be replaced with your issue number. Please also update this issue to indicate you’ve done this.

Yep, already tried to clear and rebuild.
This is a minimum reproducible sample StegoRadioMinimal.zip.
Thank you

Thanks for reporting - after a bit of investigation it seems this:

Only reproduces in Java and not Kotlin, so our initial attempts to repro using our session demo (in Kotlin) app didn't work (thanks for the sample app, that helped)
Is due to media3-session depending on androidx.media (i.e. 'media1') as an implementation and not api dependency and there being two two-arg SessionToken constructors, one public (that doesn't use 'media1' types) and the other package-private (that does use 'media1' types) [1]. This should be OK (because we're not actually using media1 types in our public API) but it looks like this is an unfortunate interaction between gradle dependency management and javac behaviour when there are overloads with the same arity: https://stackoverflow.com/questions/65424898/gradle-implementation-dependency-isnt-compile-with-correct-code

By chance we've actually removed the 2-arg package-private constructor that uses the media1 type in https://github.com/androidx/media/commit/2fd4aac310787d1a57207b5142a0ab08d5e1a2a5 - so this problem is actually already fixed on the main branch - and the fix will be included in the next release.
For now you can work around this problem by adding the following line to the deps in your build.gradle file:
compileOnly 'androidx.media:media:1.6.0'

[1]

Public constructor: public SessionToken(Context context, ComponentName serviceComponent)
Package-private: SessionToken(Context context, MediaSessionCompat.Token compatToken)


fix SliverReorderableList not work on Android platform bug

Fixes https://github.com/flutter/flutter/issues/103404
Was introduced by https://github.com/flutter/flutter/pull/97971

This should release with #97971 CC @jonahwilliams

Thanks @xu-baolin !


No Test Found

Using Windows 10 & VS Code v1.64.2 (user setup)
Install Microsoft's official Playwright extension v0.2.1
Add Playwright to project with Ctrl-Shift-P and typing install playwright
Click on the Testing Icon on the Activity bar to open Playwright extension pane
No tests are found
No green play buttons to run isolated tests in the test file

have same issue
playwright extention v0.0.9 - have all

v0.2.1 - there is nothing

@alexneo2003 Which version of @playwright/test are you using? having a repro would be helpful to dig into that.

@alexneo2003 Which version of @playwright/test are you using? having a repro would be helpful to dig into that.

using latest playwright package (1.19.1)
VSCode - version 1.64
OS - macOS 12.2.1
i'm create sample project

disable all extentions at VSCode
install latest playwright extention - 0.2.1
run npm init playwright
with 0.2.1 version - working

at my own project
with 0.0.9 version - working
with 0.2.1 version - not working
sorry but i'm cant make repro
maybe i'm can make some debug with extention - say me how

Only enabled extension is playwright test for vs code

Extension version 0.2.1
use the command pallet to install playwright (currently installs v.1.19.2

No green arrows to run isolated tests

No tests found

Let me know if this reproduction steps from a blank folder on Windows 10 aren't clear.

Same error on this side, additionally we already have installed the playwright test package but looks like the extension dont recognize that and we have to do and install again from vscode
Playwright version: 1.19.1
VSCode - version 1.64
OS - macOS 10.15.7
Playwright extension: 0.2.2

Not error found

Not extension detected

When is installed from Microsoft is getting this error from the terminal:

@sergioariveros could you do npm --version and node --version?

Sure, these are the results:
npm --version = 6.14.13
node --version = v14.17.0

@sergioariveros what is your project folder / file structure?

I was on Node 14 and thought maybe that could be the issue.
I updated to Node 16  and the extension is still in broken state. Here are my versions

The extension still does not work.

I do notice in the about page my VS Code install lists Node v.14 how do I change the VS Code electron app to use Node 16?

@pavelfeldman is as follows:

Sure, these are the results: npm --version = 6.14.13 node --version = v14.17.0

We published a new version which includes better error reporting with matching line numbers.
Could you try executing the following? npm init playwright@latest -- --quiet --browser=chromium?

Hi, sorry for the delay, same errors:

@sergioariveros very helpful, thank you! The fix for this one went live a few minutes ago. (It was not compatible with NPM 6).

So I tested again, now is not generating that error regarding to the installation, thanks for that!
In the other hand, is still present the other issue, so let me show you what I am seeing now that maybe help you to get some insights, I did the installation and that creates a new playwright.config.ts ignoring that i already have config.ts, curious thing is that those examples tests that the installation autogenerate e2e\example.spec.ts are being recognized but not my tests that I have in tests folder

Weird, because thats the thing I already have Playwright installed and is not recongnizing my test even when I rename the config file:

But if I do an additional install from VSCode console, automatically recognize the tests:

So everytime I enter to VSCode I will have to do the same otherwise is not recognizing the tests

Is this plugin compatible with the test that are written with Gherkin? I added it, but it seems that doesn't support cucumber and doesn't find the tests. Or can it be planned as a feature?

Was seeing this issue until I added testsDir to playwright config. Then I removed testsDir from my config and restarted VSCode and extension finds tests despite the removal of the testsDir key from the config. Under either condition the spec files I have in my test dir are found but the plug-in cannot see nor execute any of the tests inside them.
I'm using a ts style playwright config file and<EMAIL_ADDRESS>with Node v17.7.1. I presume the issue has something to do with the experimental loader and transition to ESM. But that's just a hunch. Will try this extension in the future perhaps when some of these wrinkles have been ironed out.

Was seeing this issue until I added testsDir to playwright config. Then I removed testsDir from my config and restarted VSCode and extension finds test files despite the removal of the testsDir key from the config. Under either condition the spec files I have in my test dir are found but the plug-in cannot see nor execute any of the tests inside them.
I'm using a ts style playwright config file and<EMAIL_ADDRESS>with Node v17.7.1. I presume the issue has something to do with the experimental loader and transition to ESM. But that's just a hunch. Will try this extension in the future perhaps when some of these wrinkles have been ironed out.

I have the same problem now. And it used to work. Not sure what broke it. Tried all the steps in this topic, to no avail.
Playwright itself runs fine, fortunately. But I do miss the ease 'run this one test' button.

I found there's another case, which leads to this No Test Found issue.
When there's some error in the implementation, the plugin simply can't find the test without any message, this could be confused sometimes. Especially, when I try to import libs from some other files, and some exceptions thrown from there.

I found there's another case, which leads to this No Test Found issue.
When there's some error in the implementation, the plugin simply can't find the test without any message, this could be confused sometimes. Especially, when I try to import libs from some other files, and some exceptions thrown from there.

I have similar issue on Linux (Ubuntu 20.04 NEON KDE), but in my case Testing Bar acting like I dont have Playwright extension installed, even though its there and it can run "Install Playwright" (v. v0.2.5). I tried to change Node versions with NVM to 12.22.7 and 16.15.1, but to no avail. Tried removing and adding different test folders in config file, like it was discussed in here but it didnt work as well. Does anyone know what might be the issue in here?

I think we need some log messages...

I just ran "npm install -D @playwright/test" and the tests showed up for me.

My issue, When enable dotenv line and save. "No test have been found".

I'm experiencing similar issues as above with VSCode. Tests run via CLI just fine, but the Microsoft Playwright Runner cannot find my tests. I'm using Playwright within another codebase but this has worked in the past before. I have Project folder with it's own package.json and src files. Then within that folder there is a folder housing all my Playwright stuff with it's own package.json to go with it. So like:
-Project
-automation
--tests
--playwright.config.ts
--package.json
--etc
-src
-package.json
-etc

Getting the same error " on Mac with all the latest versions. Test Run via CLI just fine. Any solution ?

Hello,
I have the same issue now.
I can run only if test has only
test.describe.only

I just wanted to comment something I did that seemed to help:
I use NVM and I would periodically get an error message that my shell was too slow to start up. When I would see this message I would not see my tests via the Playwright extension. So I added this to my zshrc:
[[ -s “$NVM_DIR/nvm.sh” ]] && source “$NVM_DIR/nvm.sh” --no-use
#[ -s “$NVM_DIR/nvm.sh” ] && \. “$NVM_DIR/nvm.sh”  # This loads `nvm`
#[ -s “$NVM_DIR/bash_completion” ] && \. “$NVM_DIR/bash_completion”  # This loads nvm bash_completion```

After Mac restart, never saw the error again and my tests constantly show up now. So idk.

I have the same situation. The extension is unable to find any tests in my project.
My tests located at <>
Here is my config:
{
  testDir: "src/tests",
  testMatch: /.*(test)\.(ts)/,
  forbidOnly: !!process.env.CI,
  timeout: 300000,
  workers: 2,
  expect: { timeout: 10000 },
  reporter: [["dot"], ["html", { open: "never" }]],
  globalSetup: "./src/hooks/setup.ts",
  use: {
    headless: true,
    screenshot: "only-on-failure",
    trace: process.env.TRACE ? "on" : "on-first-retry",
    actionTimeout: 10000,
    baseURL: process.env.HOST_FRONTEND,
  },
};

I also face the same issue now. I get this error from vs code, but the package already exists and nothing changes even if I install it again 🤷♂

Playwright test version: 1.25.0
Extension version: v0.2.8
VS Code version: 1.70.0
Node version: 16.14.2
OS: MacOS 12.5

I have the same problem on macOS. Everything is up to date even though the extension returns a message about no tests. I have checked on several different projects and the same thing everywhere. Strangely enough on another Windows computer it works fine. Maybe there is some specific configuration on macOS that causes this?

Same issue for me on MacOS - However, for a time ~2 months ago, the extension was working fine (and I LOVED it). I unfortunately cannot pinpoint the exact point in time in where the extension stopped working. I tried down-grading a few versions and no luck.
Playwright test version: 1.25.0
Extension version: v0.2.9
VS Code version: 1.70.2
Node version: 16.14.2
OS: MacOS 12.2.1


i found a very strange bug

I found a very strange bug. When using node-powershell in an electron app, changing the window size will block the loop.
It’s very easy to reproduce this bug.
In the main process:
const {app, BrowserWindow, ipcMain} = require('electron')
const Shell = require('node-powershell')

const test = async () => {
  for (let index = 0; index < 1000; index++) {
    const ps = new Shell({
      executionPolicy: 'Bypass',
      noProfile: true
    })
    ps.addCommand(`echo ${index}`)
    try {
      const result = await ps.invoke()
      console.log('im result: %s', result)
    } catch (err) {
      console.log('err', err)
    } finally {
      await ps.dispose()
    }
    console.log('im index: %s', index)
  }
}
setTimeout(() => {
  test()
}, 2000)

I also created a repository to make it easier for you to reproduce it:
https://github.com/FloatingShuYin/electron-quick-start-node-powershell
Bug reproduction
Click on the Hello World title
Then change the window size
Then you will see that the expected loop is blocked
Does anyone know what happened?

This is really more of an electron question.
In an electron app main.js and renderer.js are run as different processes.
The main process is responsible for creating and managing BrowserWindow instances and various application events.  A subset of Electron APIs (see graphic below) are available in the main process, as well as all node.js modules. The docs state: “The basic rule is: if a module is GUI or low-level system related, then it should be only available in the main process.” (Note that GUI here means native GUI, not HTML based UI rendered by Chromium).
If you put your node-powershell code inside of renderer.js then it will not be interrupted by the processing happening on the main thread.  I have a basic example here.

@BenjaminMichael Awesome! Thank you for your answer, it really is as you said.
i moved the code to the rendering process and it worked as expected.
And your answer gives me a deeper understanding of how electron works.
Thank you very much for your answer again.
i will close this issue.


SQLite Database Ecnryption

I would like to ask if I can encrypt/decrypt SQLite Database using OpenSSL 1.1.1 and which is the most efficient way to do it?
Thanks

In the past, when I worked for a different company, SQLCipher was usually recommended for encrypting SQLite databases. IIRC it used OpenSSL to perform the actual encryption/decryption.

Thanks for response.
Is there a page that describes in details how I can compile SQLCipher for platform x86?


Plugin occupation too high

https://timings.spigotmc.org/?url=oyemonudub

You're running spigot it seems. Not even paper.
Chunk loading under paper is done much better and doesn't lag the server.
There is no way for BetterRTP to fix your server version.


docs/olm-integration: fix example Go code for OLM < 0.17

Description of the change:

docs/olm-integration/generation.md: fix example Go code to get webhooks working with OLM < 0.17

Motivation for the change: see https://github.com/kubernetes-sigs/controller-runtime/pull/1500
/kind documentation
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

This is waiting on stable c-r v0.9.0 to be released and supported by plugins.
/hold

Blocked by #4977


refine CLI help messages

Make them more suggestive
Signed-off-by: Changwei Ge<EMAIL_ADDRESS>

Others, LGTM

Codecov Report
Base: 28.30% // Head: 28.25% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (557de39) compared to base (89aa69e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   28.30%   28.25%   -0.06%
==========================================
  Files          37       37
  Lines        3674     3667       -7
==========================================
- Hits         1040     1036       -4
+ Misses       2514     2510       -4
- Partials      120      121       +1

Impacted Files
Coverage Δ

cmd/containerd-nydus-grpc/pkg/command/flags.go
100.00% <100.00%> (ø)

config/global.go
35.55% <0.00%> (-3.47%)
:arrow_down:

config/config.go
19.29% <0.00%> (+1.11%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Moving config validation code to subpackage

This is part of the cleanup of pkg/config. Planning on moving everything here to subpackages.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
282d4522ac43bcfebd24e7e1397d3befa15a38ef
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
282d4522ac43bcfebd24e7e1397d3befa15a38ef
link
/test integ-new-install-k8s-presubmit-tests-master

istio-pilot-multicluster-e2e-master
282d4522ac43bcfebd24e7e1397d3befa15a38ef
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Layout Creation Improvements and Refactoring

This PR completely rewrites the layout creation, both the functional part as well as the configuration dialog.
In more detail:

A separate LayoutCreationSpecification class that handles the specification data to be passed to a separate LayoutCreator that uses the specification to create a layout.
The layout dialog binds its element's values to a LayoutCreationSpecification to separate model from view and ensure updates in both directions
The functionality for dialog validation, updates and layout creation is highly simplified by reducing redundant logic and streamlining the specification process.
Manual selection between landscape and portrait mode is removed, as it can be inferred from the specified data.
Dialog initialization is stable even if required printers are not available.

Contributes to #1.


kernel dies when scraping more than 100 000 tweets

Dear all,
I do not really know whether this problem can be solved somehow. My kernel dies whenever I try to scrape more than 100 000 tweets at a time. The problem is, that for my research project in university I need to analyze about 2.2 mio. tweets. Does anybody have suggestions how I can sort this issue out besides buying a new computer :)? Or could any body tell me what the limiting factor is?
Thanks a lot!!

Sorry for the late response. A quick workaround is to run multiple queries setting different -bd and -ed (begin/end date) parameters and do independent runs. twitterscraper is not memory efficient. If you have more questions, please reopen or start a new issue.


Add handler for topojson

https://github.com/mbostock/topojson

Work on this is subsumed in Weights Abstraction.

same question here as #316?


[BACKLOG-40921] update mockito for plugins in pentaho-kettle (some, n…

…ot all)
Changes made for:
connected-to-repository
drools
export-repository
ftp-delete
ftps
get-file-sftp
get-file-with-ftp
google-analytics
gp-bulk-loader
mail-job
monet-db-bulk-loader
msg-box-info
pentaho-googledrive-vfs
put-file-sftp
sftpput
terafast-bulk-loader

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 19m 50s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
plugins,plugins/connected-to-repository/impl,plugins/drools/core,plugins/export-repository/impl,plugins/ftp-delete/impl,plugins/ftps/impl,plugins/get-file-sftp/impl,plugins/get-file-with-ftp/impl,plugins/google-analytics/core,plugins/mail-job/impl,plugins/monet-db-bulk-loader/impl,plugins/msg-box-info/impl,plugins/pentaho-googledrive-vfs/core,plugins/put-file-sftp/impl,plugins/sftpput/ui,plugins/terafast-bulk-loader/impl

:ok_hand: All tests passed!
Tests run: 63, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message


Question: Custom tiles generation and serving

Hello guys
I know this is not exactly the place to post this but i am at a loss. It is true I am quit new at mapping but i have really searched quite a lot before coming to you.
I want to create a website that people will be able to upload an image and this will made into tiles and then served to them so they can use leaflet to build up their own custom maps
My question is. Is there a RESTful of otherwise API Service that I can send images to be rendered into tiles and then host them? If not is there a place I could host them (I already have a script to go from JPG -> Tiles structure (folders/images)
I would really appreciate the help or just pointing me somewhere I could read.

You want to look at the plugins for non-map layers, which point to several services (http://leafletjs.com/plugins.html#non-map-base-layers) ; at MapTiler (https://github.com/calvinchengx/maptiler) and at gdal2tiles (https://github.com/pramsey/gdal2tilesp, http://www.gdal.org/gdal2tiles.html)
It might not be exactly what you're looking, but it should be enough to give you a few ideas.


HL7 ORC Mapping for OML messages

This PR adds mapping to the HL7 ORC field for the OML message type.
Test Steps:

./gradlew primeCLI --args='fhirdata --output-format HL7 --input-file "./src/test/resources/fhirengine/engine/lab_order_no_observations.fhir"  -s "./metadata/hl7_mapping/receivers/Flexion/TILabOrder.yml"'
Check to see that the HL7 message has the ORC field. Subfields to look for are ORC-2 and ORC-21, the rest were already mapped by RS.

Changes

Added mapping for ORC-2 and ORC-21 in prime-router/metadata/hl7_mapping/OML_O21/base/service-request-order.yml

Checklist
Testing

[x] Tested locally
[x] Integration test

Linked Issues
Create Outbound OML ORC Segment

This is the input file we used for testing: input.txt


[#117515045] Use points-at to find tags pointing to HEAD

#117515045 Fix the Build : Tags
What
We found the following problem in tag-release:

The git resource ALWAYS clone the full repo, downloading all latest tags
Then it checks-out the required ref, tag or commit
But when promoting a tag, tag-release.sh queries for all the tags that
CONTAIN the current HEAD, so any new tag in new commits in master
will match and their version promoted.

The solution is simply query for the tags to point-at the current HEAD
Note that we were checking if the current commit was already included in any other previous tag with the destination prefix to avoid tagging twice. In this check we also use --contains, but it should be --points-at.
Note we are not checking if the destination tag already exists, it just fails on creation..
Detailed issue
In more detail, in our case the error was the following race condition.

Tag staging-0.0.30 was created after a successful deployment of CI
Staging started working with tag staging-0.0.30
CI got immediatelly triggered due other new commits.
CI finished before staging did, creating a tag called staging-0.0.31
Staging, which was triggered with tag staging-0.0.030
finished the tests just after, but the "tag_release" job
queried all the tags containing the HEAD commit it took the
latest: staging-0.0.31, creating the tag prod-0.0.31
Staging was triggered again, this time for the tag staging-0.0.31
When staging finished, it tried to do another tag-release for prod,
based on the current tag in staging, so prod-0.0.31. But it failed
because the tag was already there.

How to test it
I provided this Docker file to test the case:
cat <<"EOF"
FROM governmentpaas/git-ssh

WORKDIR /tmp
ENV GIT_PUSH=false

RUN mkdir -p /tmp/git-keys && cd  /tmp/git-keys  && \
    ssh-keygen -f git-key -N '' && \
    tar -cvzf git-keys.tar.gz git-key git-key.pub

ADD ./concourse/scripts/tag-release.sh /tmp/

RUN echo "When working on a git repo with two tags in one commit" && \
    mkdir -p /tmp/paas-cf && \
    cd /tmp/paas-cf && \
    git init && \
    git commit --allow-empty -m "First commit" && \
    git tag previous-0.0.1 && \
    git tag previous-0.0.2 && \
    echo "When and other tag in a later commit" && \
    git commit --allow-empty -m "Second commit" && \
    git tag previous-0.0.3

RUN echo "When I checkout the version previous-0.0.2" && \
    cd /tmp/paas-cf && \
    git checkout HEAD^1 && \
    echo "And tag the next-* release" && \
    cd /tmp && \
    /tmp/tag-release.sh next- testaccount testenv 'previous-*' && \
    echo "It tags with next-0.0.2" && \
    cd /tmp/paas-cf && \
    LATEST_NEXT_TAG=$(git tag -l next-* --sort version:refname | tail -n1) && \
    echo "LATEST_NEXT_TAG=$LATEST_NEXT_TAG" && \
    test "$LATEST_NEXT_TAG" == "next-0.0.2"

RUN echo "When I retry to tag again and it is already tagged" && \
    echo "It does not fail" && \
    cd /tmp && \
    /tmp/tag-release.sh next- testaccount testenv 'previous-*' && \
    echo "and keeps the old tag next-0.0.2" && \
    cd /tmp/paas-cf && \
    LATEST_NEXT_TAG=$(git tag -l next-* --sort version:refname | tail -n1) && \
    echo "LATEST_NEXT_TAG=$LATEST_NEXT_TAG" && \
    test $LATEST_NEXT_TAG == next-0.0.2
EOF

Run docker build --force-rm=true --no-cache=true . to run the tests. It should complete with the current commit.
To test the fail scenario, simply checkout master and run again
Who?
Anyone but @keymon

LGTM, the before/after test works as expected, and the description in the commit message now means that I fully understand what happened. Thanks :+1:


Implement semantic-release

https://semantic-release.gitbook.io/semantic-release
https://www.conventionalcommits.org/en/v1.0.0/#summary

Looking into this, I’ve decided not to enforce conventional commits or semantic versioning for now. While I value standards, these aren’t (yet) widely adopted in comparable python projects. My concern is that they add unnecessary overhead for a young repo and create headaches for contributors unfamiliar with them.
For now, I prefer having more control over what gets published and in which version to align with our initial milestones. Having said that, I will start using conventional commits as I do think it will boost the efficiency of managing releases.
I’ll revisit this once we’ve bumped a few versions and automation becomes more critical.


Add Capitole du Libre 2024 (Toulouse, France)

Add edition 2024 of Capitole du Libre in Toulouse, France

@mesrenyamedogbe This PR is ready to be reviewed and merged :D

Thanks for contributing!


Add support for "echo to attached terminal"

It could be good/useful to add support on the VDP to echo out characters to the "terminal", i.e. to a computer attached via the VDP's USB port.  This USB connection is used for debug output, and also is now always attempted to be enabled for ZDI support too
We could consider using VDU 2 and VDU 3 to enable and disable this connection - effectively from the z80 side's perspective treating the terminal as a "printer".  We could then treat VDU codes sent to the VDP in a manner similar to how an Acorn machine interpreted things with respect to printer handling, echoing thru those characters to the "printer" that it wasn't interpreting as commands.

it's a good idea.


rabbitmq: 3.6.15 -> 3.7.4

Motivation for this change
The 3.6 release branch will soon be deprecated / not receive any updates
anymore.
The changelog of the initial 3.7.0 release can be found on GitHub [1].
[1] https://github.com/rabbitmq/rabbitmq-server/releases/tag/v3.7.0
cc @Profpatsch
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg test rabbitmq

Success on x86_64-linux (full log)
Attempted: tests.rabbitmq
Partial log (click to expand)
one: exit status 1
syncing
one: running command: sync
one: exit status 0
test script finished in 19.68s
cleaning up
killing one (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/g6b1ji0rcab1ygnadp5g41zb087vga2j-vm-test-run-rabbitmq

Failure on aarch64-linux (full log)
Attempted: tests.rabbitmq
Partial log (click to expand)
cannot build derivation '/nix/store/m6s9q319rjj9qqxriphn2hnhzz98swvr-system-units.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/lsw7mmxypsni87s66vfazrbc1za2zj0d-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cxa0kvg647xc70r42g74k5wycb02a30h-etc.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/q20c1a40mdvzwrl71fx88s3618mvqxkk-nixos-system-one-18.09.git.c01e4a4.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/vkld5v9vfvn6hqlh5ih4sd3jmmc1qx5m-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wzxxmcg7mhs59p8jpprjvga4zzrzk26x-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nhkl1rw8zyvhgvm8cdxj8h3k16879f2r-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/w57dx5d92b05ws79ydw6wha9nrmckv2q-nixos-test-driver-rabbitmq.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pjr2mg65k3gcb3fbjf3yhdq7wyn36i0i-vm-test-run-rabbitmq.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pjr2mg65k3gcb3fbjf3yhdq7wyn36i0i-vm-test-run-rabbitmq.drv' failed

I’m sorry, this is a duplicate of https://github.com/NixOS/nixpkgs/pull/34265.
Also see https://groups.google.com/forum/#!msg/rabbitmq-users/kXkI-f3pgEw/UFowJIK4BQAJ, it makes sense to keep 3.6 around a while longer still.


[SMALLFIX] Add user in OpenUfsBlockOptions

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15700/
Test PASSed.

Merged build finished. Test PASSed.


Expanding Power Apps PAL page to be Power * + CI

Adding more to the Power Apps PAL documentation including product specific information, to make it relevant to both the Advanced Specialization and the new Partner Incentives

@theresapalmer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bandersmsft for visibility!

#label:"aq-pr-triaged"

@ktoliver Sorry, this PR was meant to be against the private repo.

Even better! Thanks for the info.


Not able to enable announcement feature

I am following this test announcement features but I don't see announcement is getting populated at FE UI.

https://github.com/amundsen-io/amundsenfrontendlibrary/blob/master/docs/examples/announcement_client.md
Step#1 Update setup.py at amundsen/amundsenfrontendlibrary/setup.py

Step#2 installed SQLAlchemy
python_venv/amundsenfrontendlibrary/bin/python -m pip install SQLAlchemy==1.3.17
Step#3 ran setup.py
python_venv/amundsenfrontendlibrary/bin/python setup.py install

I have also set this feature at config-custom.ts and restarted UI again, but still I am not able to see announcement at FE UI.
https://www.amundsen.io/amundsen/frontend/docs/application_config/

I have kept announcements.enabled in place of announcements.enable because in config level, it is mentioned as enabled.
https://github.com/amundsen-io/amundsenfrontendlibrary/blob/master/amundsen_application/static/js/config/config-types.ts

We can close this issue as after keeping announcements.enabled=true it is working but we should update documentation  https://www.amundsen.io/amundsen/frontend/docs/application_config/


feat: files screen

Fixes #74

I'm currently working on GistsScreen as well, so router.dart and github.dart includes portions for that(not completed yet). I should've done that on a separate branch :/. Should I add a commit to comment the gists portion out?
I'll open a pr asap for GistsScreen
I had to use the Card widget in files_item.dart as ExpansionTile required a parent that is a material widget. Container didn't work.

This is how it looks:

Since this screen is only for viewing file changes, perhaps we could add a button to view in the browser? For someone who wants to get the full features of the GitHub web version, e.g. submit a review.

Or use the share module to open the system share panel, which has open in the browser included.

Open in browser does not seem to appear in the share sheet. Should I use url_launcher instead?

https://github.com/git-touch/git-touch/blob/0063e99bbcfef81fbe0e0388289ceb40afeab40d/lib/screens/gh_repo.dart#L89-L105

Sorry the first commit, action url was incomplete