Configuration with name 'default' not found.

Hi,
When I try to run app by 'react-native run-android' I get this err:
A problem occurred configuring project ':app'.
Cannot evaluate module react-native-fetch-blob : Configuration with name 'default' not found.
Also I follow installation guide you provided. Please help me figure out with this issue.
Kind regards

Hi @Arkanine , this looks like the package not linked. I think I need more information to figure out what's the root cause. What doest your settings.gralde looks like ?
If you're using Android Studio, the project structure should looks like this

My structure something different and looks this way:

Also you can see settings.gralde

@Arkanine , could you check if react-native-fetch-blob exists in your project's node_modules folder ? Looks like the project could not be found in that location.

Yea, react-native-fetch-blob exists in node_modules folder

@Arkanine , I've done some tests on new 0.26~0.29 environments, unfortunately I could not reproduce this issue, the module installed properly. What's the version of your react-native ?
Perhaps you can try remove the package and reinstall it  ?

Ok, I'll try to reinstall it.
React-native 0.25.1

@Arkanine , I've somehow reproduced the problem ! I removed react-native-fetch-blob from Project Structure and click the - button. Then I click the + button import a Gradle project, the error occurs.

And I fix the problem simply remove the react-native-fetch-blob dependency from Project Structure -> Dependencies (select react-native-fetch-blob) and click -

After remove the dependency, sync the project again.

Besides, after removing the dependency from Project Setting, make sure the following lines exists in settings.gradle.
include ':react-native-fetch-blob'
project(':react-native-fetch-blob').projectDir = new File(rootProject.projectDir,' ../node_modules/react-native-fetch-blob/android')

@wkh237 I'm just reinstalled module.
npm install --save react-native-fetch-blob
rnpm link
All required lines exists in  settings.gradle/MainActivity.java/build.graddle
But for now I'm run in to this issue:

Please try adding this line to build.gradle (Module:app), see if it works
dependencies {
    compile fileTree(include: ['*.jar'], dir: 'libs')
    compile 'com.android.support:appcompat-v7:23.0.1'
    compile 'com.facebook.react:react-native:+'
+   compile 'com.squareup.okhttp3:okhttp:3.4.1'
}

The same((

Can you see react-native-fetch-blob project in the file tree now? If you can, add
compile 'com.squareup.okhttp3:okhttp:3.4.1'

To build.gradle(Module:react-native-fetch-blob)  dependencies block.

Thanks @wkh237!
For now module works fine.

Phew! So great to hear that!! I think the package missed OkHttp dependency after we change Network module to OkHttp, I will fixe it and publish a new version : )

I am having the same error, using react-native 0.27. Here is my settings.gradle file:

The error I am getting is:
* What went wrong:
A problem occurred configuring project ':app'.
> Cannot evaluate module react-native-fetch-blob : Configuration with name 'default' not found.

Hi @cubbuk , This error usually means that the path in settings.gradle point to a folder that does not contains a build.gradle file, could you please see if the relative folder is correct ?

This is the path all my other projects are residing on. And when I check node_modules folder the library is there, and the build.gradle file is residing at the pointed directory. Have any idea?

@cubbuk I think this problem might related to Gradle, could you tell me what's your gradle version ?

It is 1.5, I see that this library uses 2.0. Could it be because of it?

@cubbuk it might be the problem, could you try changing the build.gradle as I mentioned above and see if that works?  Thank you 😭

I made it same with the library, but the problem still occurs, any other ideas =(

Okay .. perhaps we need more logs .. try gradlew.bat --debug clean buildPlugin and there will be some detailed error message.

Here is the result, couldn't figure out anything specific?
Evaluating project ':react-native-fetch-blob' using build file '/home/mehmet/_development/Projects/my_app/android/ ../node_modules/react-native-fetch-blob/android/build.gradle'.
17:27:59.246 [DEBUG] [org.gradle.configuration.project.BuildScriptProcessor] Timing: Running the build script took 0.001 secs
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter]
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter] FAILURE: Build failed with an exception.
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter]
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter] * What went wrong:
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter] A problem occurred configuring project ':app'.
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter] > Cannot evaluate module react-native-fetch-blob : Configuration with name 'default' not found.
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter]
17:27:59.248 [ERROR] [org.gradle.BuildExceptionReporter] * Exception is:
17:27:59.249 [ERROR] [org.gradle.BuildExceptionReporter] org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':app'.
17:27:59.249 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:79)
17:27:59.249 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.configuration.project.LifecycleProjectEvaluator.notifyAfterEvaluate(LifecycleProjectEvaluator.java:74)
17:27:59.249 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.configuration.project.LifecycleProjectEvaluator.evaluate(LifecycleProjectEvaluator.java:61)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.project.AbstractProject.evaluate(AbstractProject.java:510)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.project.AbstractProject.evaluate(AbstractProject.java:90)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.execution.TaskPathProjectEvaluator.configureHierarchy(TaskPathProjectEvaluator.java:47)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.configuration.DefaultBuildConfigurer.configure(DefaultBuildConfigurer.java:35)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.initialization.DefaultGradleLauncher$2.run(DefaultGradleLauncher.java:125)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.Factories$1.create(Factories.java:22)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:52)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:122)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.initialization.DefaultGradleLauncher.access$200(DefaultGradleLauncher.java:32)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:99)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:93)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:62)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:93)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:82)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.exec.InProcessBuildActionExecuter$DefaultBuildController.run(InProcessBuildActionExecuter.java:94)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:43)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:28)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:78)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:48)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:52)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.250 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:37)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.util.Swapper.swap(Swapper.java:38)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.health.DaemonHealthTracker.execute(DaemonHealthTracker.java:47)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:66)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.health.HintGCAfterBuild.execute(HintGCAfterBuild.java:41)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:246)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter] Caused by: org.gradle.api.UnknownProjectException: Cannot evaluate module react-native-fetch-blob : Configuration with name 'default' not found.
17:27:59.251 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.DependencyManager.ensureConfigured(DependencyManager.java:728)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.DependencyManager.resolveDependencyForConfig(DependencyManager.java:240)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.DependencyManager.resolveDependencies(DependencyManager.java:139)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.TaskManager.resolveDependencies(TaskManager.java:350)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager$9.call(VariantManager.java:597)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager$9.call(VariantManager.java:594)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:55)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:47)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.profile.SpanRecorders.record(SpanRecorders.java:51)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager.createVariantData(VariantManager.java:593)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager.createVariantDataForProductFlavors(VariantManager.java:750)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager.populateVariantDataList(VariantManager.java:459)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager$1.call(VariantManager.java:263)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager$1.call(VariantManager.java:260)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:55)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:47)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.VariantManager.createAndroidTasks(VariantManager.java:259)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.BasePlugin$12.call(BasePlugin.java:651)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.BasePlugin$12.call(BasePlugin.java:648)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:55)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:47)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.BasePlugin.createAndroidTasks(BasePlugin.java:647)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.BasePlugin$10$1.call(BasePlugin.java:566)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.BasePlugin$10$1.call(BasePlugin.java:563)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:55)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.builder.profile.ThreadRecorder$1.record(ThreadRecorder.java:47)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.BasePlugin$10.execute(BasePlugin.java:562)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.BasePlugin$10.execute(BasePlugin.java:559)
17:27:59.252 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.event.BroadcastDispatch$ActionInvocationHandler.dispatch(BroadcastDispatch.java:93)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.event.BroadcastDispatch$ActionInvocationHandler.dispatch(BroadcastDispatch.java:82)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:44)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.event.BroadcastDispatch.dispatch(BroadcastDispatch.java:79)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.internal.event.BroadcastDispatch.dispatch(BroadcastDispatch.java:30)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at com.sun.proxy.$Proxy11.afterEvaluate(Unknown Source)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.configuration.project.LifecycleProjectEvaluator.notifyAfterEvaluate(LifecycleProjectEvaluator.java:67)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        ... 52 more
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter] Caused by: org.gradle.api.artifacts.UnknownConfigurationException: Configuration with name 'default' not found.
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.artifacts.configurations.DefaultConfigurationContainer.createNotFoundException(DefaultConfigurationContainer.java:88)
17:27:59.253 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.DefaultNamedDomainObjectCollection.getByName(DefaultNamedDomainObjectCollection.java:210)
17:27:59.254 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.artifacts.configurations.DefaultConfigurationContainer.getByName(DefaultConfigurationContainer.java:78)
17:27:59.254 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.artifacts.configurations.DefaultConfigurationContainer.getByName(DefaultConfigurationContainer.java:36)
17:27:59.254 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.artifacts.dependencies.DefaultProjectDependency.getProjectConfiguration(DefaultProjectDependency.java:69)
17:27:59.254 [ERROR] [org.gradle.BuildExceptionReporter]        at org.gradle.api.internal.artifacts.dependencies.DefaultProjectDependency_Decorated.getProjectConfiguration(Unknown Source)
17:27:59.254 [ERROR] [org.gradle.BuildExceptionReporter]        at com.android.build.gradle.internal.DependencyManager.ensureConfigured(DependencyManager.java:726)
17:27:59.254 [ERROR] [org.gradle.BuildExceptionReporter]        ... 87 more
17:27:59.254 [ERROR] [org.gradle.BuildExceptionReporter]
17:27:59.254 [LIFECYCLE] [org.gradle.BuildResultLogger]
17:27:59.254 [LIFECYCLE] [org.gradle.BuildResultLogger] BUILD FAILED
17:27:59.254 [LIFECYCLE] [org.gradle.BuildResultLogger]

I have no idea about this now, I'll use my ubuntu box try to reproduce this problem ..

Thanks a lot, my main problem is that I am trying to upload videos and I can upload video files on the phone if they are around 5 MB, but for videos larger than 10 MB I am getting a File Descriptor closed error, and trying to find a solution for this. I hope this library will help me achieve that. Thanks again.

No problem, I'll try to figure out what's going on.

@cubbuk By the way , did you try to open the project by Android Studio ? If you have Android Studio, you might try the step above.

I applied what you told and worked on Android Studio, removed the dependency then manually added again to settings file and I achieved running the project; however this time I am getting undefined is not an object RNFetchBlob.DocumentDir...' error. I checked issue #51 but as I am using react 0.27 I couldn't figure out what to do, I have new RNFetchBlobPackage()` in getPackages() too. Any idea?

Hi @cubbuk , that looks like RNFetchBlob not got linked, RNFetchBlob is undefined. Does the react-native-fetch-blob project correctly loaded ? That should look like this.

@cubbuk , I somehow figured out the problem might caused by the project's react-native version. Because we're using OkHttp3 in 0.7.0 and react-native use OkHttp2 in pre 0.27 versions, it we manually add OkHttp3 dependency that will result in app crash or build failed. You may need to try  upgrading your application by command
$ react-native upgrade

and install latest react-native-fetch-blob which I published today.
$ npm install --save react-native-fetch-blob
$ rnpm link

sometimes rnpm add duplicate new RNFetchBlobPackage() in MainApplication.java, be sure it doesn't. Also, you have to remove the OkHttp dependencies you added in build.gralde files. After thing got finished,  try if it works now, Thank you !

@wkh237 thanks for detailed explanation, but after react-native upgrade command I am still getting the error:
> Cannot evaluate module react-native-fetch-blob : Configuration with name 'default' not found.
One thing I noticed is I am using other libraries too and when I check them from Android Studio, the location they are located at is under node_modules directory of my application, whereas for this library it is looking under android directory and it creating directory named "../node_modules` which seems wrong. You can see it from the screenshot:

And here is my settings.gradle content:

Does that make any sense to you?
Btw thanks a lot for the effort anyway, really appreciated.

＠cubbuk , I've noticed that there's an extra white space before RNFetchBlob path " ../node_modules/" does it make difference if you remove it?

@wkh237 it worked, I didn't even need to any upgrade at all, the reason was the typo =)
Thanks a lot, I will try out uploading from camera roll and so on now.

Great ! Well, In order to find the root cause of this problem, I've tested this module on many environments and also changed the rnpm link script.  I'm think that except 0.27, most of versions should work fine on 0.7.5 now.

I was able to run it with 0.27.2 after upgrading react-native scripts. Thanks for the help =)

You're welcome =)

RN 0.30 with react-native-fetch-blob ^0.8.2, I also had a white space before " ../node_modules/" in my settings.gradle file. After removing, I can run react-native run-android without problem.


[Help Wanted] SimpleITK 1.x Java libs for mac

Currently only Windows Java libs are available for download for the latest 1.0.1 on http://www.simpleitk.org/SimpleITK/resources/software.html. The last mac lib was provided for the 0.9.1 in 2015. Is there any technical reason for mac libs not being generated anymore?
I've just built the 1.1.0.dev2774 and building it by my own was ok-ish, but I'm wondering if there might be any issues afterwards. Any ideas?

Yeah, that's probably an oversight.  I just built and tested the latest version on Mac/Java and it was fine.  I'll let @blowekamp know when he gets back from vacation next week.

I believe the proper way for packaging for Java would be to target Maven. We are in need of a packager who can help with packaging for Maven to ensure compatibility with their conventions.


500s in gateway logs after enabling sidecars in authorino & limitador, and STRICT PeerAuthentication

After doing a make local-setup locally, then following https://docs.kuadrant.io/dev/kuadrant-operator/doc/user-guides/secure-protect-connect/, I got to the point of a working AuthPolicy & RatelimitPolicy.
I then enabled mtls (via sidecar injection) in authorino and limitador in an attempt to have encrypted traffic from envoy to/from the kuadrant components.
Here's the cmds I ran.
kubectl -n kuadrant-system patch deployment authorino \
  -p '{"spec":{"template":{"metadata":{"labels":{"sidecar.istio.io/inject":"true"}}}}}'

kubectl -n kuadrant-system patch deployment limitador-limitador \
  -p '{"spec":{"template":{"metadata":{"labels":{"sidecar.istio.io/inject":"true"}}}}}'

kubectl apply -f - <<EOF
apiVersion: security.istio.io/v1
kind: PeerAuthentication
metadata:
  name: default
  namespace: kuadrant-system
spec:
  mtls:
    mode: STRICT
EOF

However, after enabling this, all responses are now 500s.
I bumped up the log level to debug in the gateway, using this cmd:
kubectl exec $(kubectl -n kuadrant-system get po -l istio.io/gateway-name=api-gateway -o name
pod/api-gateway-istio-649dc76fc-nklds) -n kuadrant-system -- curl -X POST http://localhost:15000/logging?level=debug

Here's a snippet of logs
https://gist.github.com/david-martin/90104685603ecab49aad45cf595d2c92
Here's the Pod spec & config_dump of the gateway
https://gist.github.com/david-martin/43fdbbede84df3b156609081a9b6387f
Discussion on slack at https://kubernetes.slack.com/archives/C05J0D0V525/p1732621388340329
At this time it's unclear if the issue is with the envoy filter configuration that kuadrant manages, or something else.

I was able to get it working locally with some patching of the envoyfilters, though this isn't a viable solution as the filters are maintained by the kuadrant-operator.
I added this to both thekuadrant-auth-service &  kuadrant-ratelimit-service envoyfilters:
          transport_socket:
            name: envoy.transport_sockets.tls
            typed_config:
              '@type': type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext
              common_tls_context:
                tls_certificate_sds_secret_configs:
                - name: default
                  sds_config:
                    api_config_source:
                      api_type: GRPC
                      grpc_services:
                      - envoy_grpc:
                          cluster_name: sds-grpc

From chat on slack, this may not be validating certificates as well, so something may be missing.
From @guicassolato

For mTLS, I think you need both, the tls_certificates* stanza and the validation_context* one

https://istio.io/latest/docs/ops/configuration/traffic-management/tls-configuration/#outbound

Also, quote from @eguzki

One of the issues with this is that for adding mtls client config, you need to use gateway provider APIs to do that (either Istio or EnvoyGateway). Kuadrant does not own (manage) the gateways. And today this is still under developement. EnvoyGateway has a slightly more flexible way of doing that. But we need to explore the way to provide certificates for the mtls use cases.

Our use case is not common. This is not about setting up backend connections. This is about setting up some comm's between wasm module and some service


Create new weekly task class

It will be pretty similar to the existing one, but will use a different bunch of notifiers (the NotificationListener currently is related to PacktFreeOffer and we need a different one).

Save this for a different patch. Is it really needed?


flutter create test should be disallowed

We can't actually create a project named "test" because that name conflicts with package:test, which we depend upon.  Several people have hit this mysterious error when creating projects.  We should catch this case in the tool, probably by refusing to use that name and explaining why.

/cc @devoncarew

Oh yeah, good catch.

We should probably catch all the packages we depend on.
(Yet another reason to reduce our dependencies...)


fix: not copy parent dir when path contains dot

Signed-off-by: zhangyue<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
when path contains dot, such as test/. , we should not copy the test dir into dst, we just need to copy the file& dir under test/ into dst.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
added.
Ⅳ. Describe how to verify it
wait for CI.
Ⅴ. Special notes for reviews
None.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhangyue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


AzureStudio does not display with powershell win32_product

Azure Data Studio Version:1.37.0
OS Version:Windows 11, Windows Server 2019, Windows Server 2022

Steps to Reproduce:

Install SSMS 18.x, azure data studio is automatically installed.
2.Review the registry guid {6591F69E-6588-4980-81ED-C8FCBD7EC4B8}_is1 which shows that it is for Azure Data Studio

Open a powershell get-wmiobject -class win32_product | where-object -Property name -like "azure"

If you do the same thing get-wmiobject -class win32_product | where-object -Property name -like "sql server management studio" all the SQL Server management studio items are displayed.

Does this issue occur when all extensions are disabled?: Yes/No

Due to the security issue with 1.37.0 we were looking to use powershell to find it on the machine and uninstall it via the win32_product and we discovered that it does not display in powershell. msexec or uninstall string work but if you try and use powershell to see if it exists via the win32_product command it doesnt display when trying to list the applications.


Trim empty space in path string

Minor issue, but a trailing space accidentally left in the path string will cause the get logs command to fail without explanation.
`$ aerolab logs get --name 'testcluster' --path '/tmp/collect_info_20240802_194533.tgz ' --destination '-'
2024/08/02 19:49:23 +0000 Running logs.get
2024/08/02 19:49:27 +0000 log cat error: Process exited with status 1
-=-=-=-=- [ExitCode] 1 -=-=-=-=-
exit status 1
-=-=-=-=- [END] -=-=-=-=-`

Fixed


Change Languegue, error

:lady_beetle: Describe the bug
I change de languague to Portugues Brasil then click in Account, show error.
:computer: Components impacted
ntfy.sh
:bulb: Screenshots and/or logs
RangeError: Incorrect locale information provided
at log (https://ntfy.sh/static/media/index-9e24212a.js:320:286)
at w (https://ntfy.sh/static/media/index-9e24212a.js:41237:391)
at w (https://ntfy.sh/static/media/index-9e24212a.js:40450:391)
at isMounted (https://ntfy.sh/static/media/index-9e24212a.js:19518:38)
at callback (https://ntfy.sh/static/media/index-9e24212a.js:44027:40)
at callback (https://ntfy.sh/static/media/index-9e24212a.js:39763:40)
at callback (https://ntfy.sh/static/media/index-9e24212a.js:39691:40)
at callback (https://ntfy.sh/static/media/index-9e24212a.js:39545:40)
RangeError: Incorrect locale information provided
at at Eue (https://ntfy.sh/static/media/index-9e24212a.js:391:39667)
at     at div
at     at div
at     at https://ntfy.sh/static/media/index-9e24212a.js:55:6185
at     at https://ntfy.sh/static/media/index-9e24212a.js:135:63751
at     at div
at     at https://ntfy.sh/static/media/index-9e24212a.js:55:6185
at     at https://ntfy.sh/static/media/index-9e24212a.js:61:41169
at     at https://ntfy.sh/static/media/index-9e24212a.js:55:6185
at     at https://ntfy.sh/static/media/index-9e24212a.js:135:61152
at     at Pue (https://ntfy.sh/static/media/index-9e24212a.js:391:38890)
at     at div
at     at https://ntfy.sh/static/media/index-9e24212a.js:55:6185
at     at https://ntfy.sh/static/media/index-9e24212a.js:61:22350
at     at div
at     at https://ntfy.sh/static/media/index-9e24212a.js:55:6185
at     at https://ntfy.sh/static/media/index-9e24212a.js:61:20669
at     at yue
at     at oK (https://ntfy.sh/static/media/index-9e24212a.js:240:3933)
at     at pK (https://ntfy.sh/static/media/index-9e24212a.js:240:6226)
at     at main
at     at https://ntfy.sh/static/media/index-9e24212a.js:55:6185
at     at https://ntfy.sh/static/media/index-9e24212a.js:61:13098
at     at Rde (https://ntfy.sh/static/media/index-9e24212a.js:409:15094)
at     at div
at     at https://ntfy.sh/static/media/index-9e24212a.js:55:6185
at     at https://ntfy.sh/static/media/index-9e24212a.js:61:13098
at     at Ode (https://ntfy.sh/static/media/index-9e24212a.js:409:13968)
at     at oK (https://ntfy.sh/static/media/index-9e24212a.js:240:3933)
at     at gK (https://ntfy.sh/static/media/index-9e24212a.js:240:6851)
at     at Cce (https://ntfy.sh/static/media/index-9e24212a.js:372:5834)
at     at i (https://ntfy.sh/static/media/index-9e24212a.js:250:3140)
at     at GN (https://ntfy.sh/static/media/index-9e24212a.js:61:18729)
at     at YN (https://ntfy.sh/static/media/index-9e24212a.js:61:19114)
at     at D3 (https://ntfy.sh/static/media/index-9e24212a.js:61:29727)
at     at fK (https://ntfy.sh/static/media/index-9e24212a.js:240:6285)
at     at _K (https://ntfy.sh/static/media/index-9e24212a.js:249:744)
at     at Pde (https://ntfy.sh/static/media/index-9e24212a.js:409:12627)
at     at Suspense
at     at Ade (https://ntfy.sh/static/media/index-9e24212a.js:409:12872)
:crystal_ball: Additional context
I back to English and ok

I believe this should be fixed by #922; will be shipped with the next release.


Create a product

As a user
I need the ability to create new products on the website
So that I can let others see our newly released goods.
Details & Assumptions:

POST http://[our domain]/product
Json:

{
id: "xxxxx",
name: "Orange",
description: "description of the food",
amount: "3",
status: "200"
}

Acceptance Criteria:
Given there is no expected product on the database yet
When the user submits the create product request,
Then it would return the json I have defined.

Under criteria, I added the "Given" situation

@wenjialu @BillChen666 @iswhr @mt4456 I suggest to correct status from status code to enumeration type (status_bad, status_good, status_great). For example, the status for a product "apple" is "status_good".


Enable subdirectory creation for students and set limits based on required files

Right now if you have:

required files is enabled in subdirectories (enabled in #4903)
"only required files" is enabled
subdirectories are not created in starter files OR if a student deletes a subdirectory

then students will not be able to create new subdirectories and will subsequently not be able to submit required files.
We should:

allow students to create subdirectories thought the UI.
if there are required files, students can create subdirectories that are required to fulfill the required files (ie. if sub1/sub2/test.py is required then students can create sub1/ and sub1/sub2)
if there are required files, the code checks the content of an expanded zip file, not the zip file itself for the required files.

Closed in #5763.


Package-lock and yarn lock file needs to be removed from the project

Have written a description on closed PR 👍


krb5: Depends on bison for Linuxbrew

brew gist-logs: https://gist.github.com/anonymous/e1b9d43a1386298d012b57b96b14d5e3
Manifested by:
/usr/bin/gcc-4.8 -DHAVE_CONFIG_H  -I../../include -I../../include -I. -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE -isystem/home/linuxbrew/.linuxbrew/include -Os -w -pipe -march=native -Wall -Wcast-align -Wshadow -Wmissing-prototypes -Wno-format-zero-length -Woverflow -Wstrict-overflow -Wmissing-format-attribute -Wmissing-prototypes -Wreturn-type -Wmissing-braces -Wparentheses -Wswitch -Wunused-function -Wunused-label -Wunused-variable -Wunused-value -Wunknown-pragmas -Wsign-compare -Werror=uninitialized -Werror=pointer-arith -Werror=declaration-after-statement -Werror-implicit-function-declaration -pthread -c ss_wrapper.c
yacc  getdate.y
make[2]: yacc: Command not found
make[2]: *** [getdate.c] Error 127
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/tmp/krb5-20160517-2322-123f1q2/krb5-1.14/src/kadmin/cli'
make[1]: *** [all-recurse] Error 1
make[1]: Leaving directory `/tmp/krb5-20160517-2322-123f1q2/krb5-1.14/src/kadmin'
make: *** [all-recurse] Error 1

Merged in https://github.com/Homebrew/homebrew-dupes/commit/c3bf13407c90418971b10010169161a5d7fa3c38. Thank you for your contribution to Homebrew @DoomHammer; we appreciate it! :smiley_cat:


Python compatible?

Hi. Is it possible to use Python sockets to contact with C side that uses dyad?

Yes — If you build and run the echo server example, the following python script could be used on the same machine to connect to it:
import socket

s = socket.socket()
s.connect(("localhost", 8000))

s.send("Hello world\n")

print(s.recv(100))

You can write methods in c that are wrapped using the CPython API, therefore you can call those methods straight in python.


Fraction values in spike rule

While playing with spike rule I have faced problems while trying to use field_value with a fractional value (especially when value is less than 1). It seems that add_data assumes that the value provided is an integer:
      (...)
            if self.field_value is not None:
                count = lookup_es_key(event, self.field_value)
                if count is not None:
                    try:
                        count = int(count)
                    except ValueError:
                        elastalert_logger.warn('{} is not a number: {}'.format(self.field_value, count))
                    else:
                        self.handle_event(event, count, qk)
            else:
                self.handle_event(event, 1, qk)

Is there any reason integer is used here instead of for example float? I've made a quick test and it seems to work fine with float().

+1


Migrate to bundle format

Migrate to bundle format for the current release of Service Telemetry Operator.
The 1.1.0 directory remains for now as we'll migrate the repository to that shortly. We
need to release a bundle of our current release so we can migrate to the new CatalogSource
without changing artifacts, and then do an Operator upgrade from there.

 Migrate Operators to bundle packaging format and distribution


test(connlib): assert on expected ICMP handshakes

Currently, we assert on the actual IP packet that gets sent between client and gateway in the tunnel test. This does not work with DNS resources because - unless we model how connlib assigns IPs for DNS resources - we don't know what the destination IP of the resource is that we are about to ping.
From an applications PoV, it doesn't matter, what the IP is. Thus, it is better to write an assertion closer to what the application expects:

A received ICMP reply should come from the IP that we pinged.
The ICMP packet emitted on the gateway should target the actual IP of the DNS resource.

Extracted out of #5083.

Draft because it is stacked but ready for review.


[FIX] 'attr' event does not use copy of old value

When firing an 'attr' event from a script, use a copy of the 'old' value e.g. for vectors and colors
Fixes https://github.com/playcanvas/editor/issues/222

It should try to avoid allocations, by pre-allocating types of value, and only copying of value in it. It is ok if old value lifetime is guaranteed only during a callback.

I totally get your point, @Maksims, but if this is just behavior we document and expect developers to read it, we might be disappointed. I bet some developers will store off the value and use it again later. 😞

I totally get your point, @Maksims, but if this is just behavior we document and expect developers to read it, we might be disappointed. I bet some developers will store off the value and use it again later. 😞

It's true. Many functions in our engine already follow such path of not allowing to reuse or modify things. Like getPosition returns vector that should not be modified by developer and is subject to change later.
WebXR APIs (actual browser APIs) follow similar rules as well, where things are only actual during sync call to them, but not outside of tick or callback.
It is a question of sacrificing performance for everyone, or ask some to follow the rules if they don't.

I can totally see Max's point here. This would have been a major problem is Vec2/3/4 and Color classes still allocated a Float32Array. But they're very lightweight constructors now. Let's just merge for now and if it because a problem with GC, we can revisit. I'm just glad the bug is fixed.

I can totally see Max's point here. This would have been a major problem is Vec2/3/4 and Color classes still allocated a Float32Array. But they're very lightweight constructors now. Let's just merge for now and if it because a problem with GC, we can revisit. I'm just glad the bug is fixed.

Ok, if we going to clone stuff, then can we first check if there is any event subscribtion so that we don't allocate if there is not event to be fired.

Ok, if we going to clone stuff, then can we first check if there is any event subscribtion so that we don't allocate if there is not event to be fired.

Good point. What do you think @vkalpias?

Good point. What do you think @vkalpias?

Good point. What do you think @vkalpias?

https://github.com/playcanvas/engine/pull/2677

Good point. What do you think @vkalpias?

https://github.com/playcanvas/engine/pull/2677


introduce object orientation

Examine where it makes sense to convert the functions into classes that generate objects.
Split code into different files if needed.

Ideas for classes and functions
Classes

Recipe: A recipe (that's going to be a meal) and the method to generate one, with the following components:

a name
a source
a method to generate one from lines of text in the input file -> string, stored in appropriate data structure

MenuItem: An entry plus method to generate one, with the following components:

date string
recipe output
method of generation
can MenuItem include the functionality of the recipe class?
alternative: store Recipes in a dictionary, with date string as key

Functions

config
nextMonday (determine start date)
seasonal
read sources (just once!) & save in appropriate data structure
Menu generation (generates an appropriate data structure with MenuItems)
menu printing (generates output in desired format)


Add Advantech interfaces

Company Info

Company name: Advantech
Company website: https://www.advantech.com/
GitHub presence: https://github.com/ADVANTECH-Corp/

IoT Plug and Play Device Info

Product website: https://edm.advantech.com/edm/c8cd1e7d-e1ae-4621-86c9-78a168629eb4/eDM_AIR-020/index.html
Product website: https://www.advantech.com/products/880a61e5-3fed-41f3-bf53-8be2410c0f19/epc-r7200/mod_79c021b3-a480-41f6-9dbb-b440b06d6d5f

Model Submission Goals

Device certification

Code Owners & Reserved Names

@jahuang0824

Hi @jahuang0824,
Can you ask @paul53huang to confirm this submission? He is the owner of the Advantech namespace.

hi @rido-min
paul53huang has resigned from Advantech and the IoT PnP tasks are transfer to me.
How can I change the owner of the Advantech namespace?
Thanks.


Implement fixed size transform interpolation buffer.

While using the TransformInterpolationBuffer in private code I noticed
that it seems to be incomplete. Neither does it have a buffer size
limit, nor does it "remove the oldest transform if the buffer size limit
is exceeded" as stated in the header.
The changes don't break compatibility with existing code:
unless explicitly set, the buffer size is unlimited.

I do have a use case for that in an internal package that uses libcartographer. Besides that, it could be also useful for others.


Added TheBus API

TheBus is Honolulu's public transportation system.
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Hi @RyanLi98 , thanks for the PR. Please remove "API" from the description, since everything here is an API.


App 1144: Fixing RobotPartLogs Request/Response var numbers

@stevebriskin @edaniels -- the gRPC field numbers was overwritten & merged incorrectly when doing a rebase. Is it possible to overwrite the lint test? Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.

Version
1.15.0
Installation Type
Official SaaS Service
Service Name
Doc(DongTai-Doc)
Describe the details of the bug and the steps to reproduce it
目前我是1.14版本，使用k8s部署的，想要升级到最新版本1.15，但是升级完之后会报错，server对应的容器也起不来，我看数据库文件最多到1.13，这该怎么升级呢？

Additional Information
No response
Logs
No response

Please execute python manage.py migrate in any server container


Migrate to vscode-test #315

Closes #315
What problem did you solve?
Unit tests were not working. This PR migrates unit tests to vscode-test. Now unit tests work again.
BUT, they only work from the command line. I could not get them to work from within VS Code. So, I have removed the 'Run Tests' option within VS Code for now. I would like to restore it at some point, but this PR at least gives us a way of running tests (which should also work in Continuous Integration).
How can I check this pull request?
In terminal, in vscode-R directory:
npm run test

The first time, it will take a while because it needs to download VS Code.
Eventually, observe output ending in:

    ✓ Selecting multi-line bracket with pipe
    ✓ Selecting shorter RStudio comparison

  22 passing (143ms)

Exit code:   0
Done

If this doesn't work, it may be necessary to run npm install first.

lintr CI test is failing but during the installation phase. Maybe some package repo is offline. I will try running it again later.

Thanks for the nice work! This works for me now.
I'm wondering if this only works under desktop environment?
Another thing is that it'll create a folder .vscode-test that is not ignored? Should we ignore this folder?

Thanks for testing again! Good point about .vscode-test - I've added it to .gitignore.

I'm wondering if this only works under desktop environment?

Do you mean, whether it would work in a container for CI? I think it would, although there would be some more dependencies.

I make some changes to main.yaml for github actions according to https://github.com/renkun-ken/vscode-R/tree/migrate-vscode-test, and it works nicely now: https://github.com/renkun-ken/vscode-R/runs/658838903?check_suite_focus=true.
I'm not sure if there's a good way to incorporate my changes to main.yaml? Maybe I send a PR from my fork to your fork? Not sure about this.

Just saw #318. I'll file a separate PR for this once this PR is merged.

Nice! Looks like I created an issue just as you solved it :smile:
This PR is set to allow edits from maintainers, so you may be able to push directly to this branch. Or, doing a separate PR after is fine too.

Just pushed to your branch and the tests look good.
LGTM now.

Great! Thank you for adding the commits and reviewing.
The lintr installation is still failing but this PR doesn't change any R files anyway, so I'm going to go ahead and merge.


Fix interaction between CircularPrioritizedTraces and NStepBatchSampler

Fixes issue where dispatch on Circular Trajectories was not working for certain samplers, this I believe has been causing CI for https://github.com/JuliaReinforcementLearning/ReinforcementLearning.jl/pull/921 to fail as type dispatch fails to match :priority and :key keys

@HenriDeh now running into an issue where sampleable_inds is length(x) + 2 of the trace length, but it should be length(x) + 1), any ideas why?

@HenriDeh Merged this as it only adds tests and fixes functionality.

Hi @jeremiahpslewis, sorry I was on vacations. I'll catch up when I resume work on Monday.

@HenriDeh I figured as much. Hope you had a great trip!


Repeated Keyword Argument In Sites Extension

Command
mg sites site list --site-id ENTER_ID
Stacktrace
The command failed with an unexpected error. Here is the traceback:
'SitesSiteOperations' object has no attribute 'list_sites'
Traceback (most recent call last):
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 660, in execute
    raise ex
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 728, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 721, in _run_job
    six.reraise(*sys.exc_info())
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/six.py", line 703, in reraise
    raise value
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 694, in _run_job
    result = cmd_copy(params)
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 331, in __call__
    return self.handler(*args, **kwargs)
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/azure/cli/core/__init__.py", line 811, in default_command_handler
    return op(**command_args)
  File "/Users/jobala/.local/share/virtualenvs/msgraph-cli-experiment-PdxeK3ZY/lib/python3.9/site-packages/azext_sites/generated/custom.py", line 275, in sites_site_list
    return client.list_sites(site_id=site_id,
AttributeError: 'SitesSiteOperations' object has no attribute 'list_sites'

need to change operationid in openapi.
follow up in az: shall check clientfactory when grouping operations


feat: Add custom save action (close #565, #165)

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description
Provide a way to custom download action.
Please see the example "example01-includeUi.html" for usage.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@lja1018 conflicts resolved
Please take a look

@haiduong87
I'm sorry for the late reply.
I will review the PR.


Default image url

I'm setting the options directly on the directive, this way:
<img class="gravatar" ng-show="app.user.email" gravatar-src="app.user.email" gravatar-size="30" gravatar-default="http%3A%2F%2Fwww.gravatar.com%2Favatar%2F205e460b479e2e5b48aec07710c08d50">

and I'm getting this error:
GET http://i2.wp.com/http%3A%2F%2Fwww.gravatar.com%2Favatar%2F205e460b479e2e5b48aec07710c08d50 400 (Bad Request)

I don't know where the "http://i2.wp.com/" came from...

Hey! Looks strange. Could you provide any other configuration options that are using? like default options. The i2 stuff seems to related to Photon

I'm not setting any options other than those that are on the directive.

I have the same issue. Can you help me?

Sure. Just post a jsfiddle here that reproduces the problem and I'll have a look

Strangely, jsfiddle working properly. Maybe this is due to the fact that my site is running on localhost. I'll check on the server.

Interesting. Does the same thing happen if you use the alias lvh.me (domain that points to <IP_ADDRESS>, useful when testing subdomains locally)?

Now it works, because I set the default value 'identicon'. The problem occurs only if you specify the wrong links. For example: gravatar-default="http://placehold.it/350x150" works fine, but gravatar-default="http://google.com/" returns an error GET http://i1.wp.com/https//www.google.com/ 504 (Gateway Timeout). Maybe the problem with headers (Content-Type, etc.)?
Thanks.

Right! So the "problem" is that gravatar most likely redirects to to this URL if the default image URL doesn't return an image.
$ curl -I http://www.gravatar.com/avatar/46ab5c60ced85b09c35fd31a510206ee\?default\=http://google.com/
HTTP/1.1 302 Found
Accept-Ranges: bytes
Cache-Control: max-age=300
Content-Type: text/html; charset=utf-8
Date: Wed, 10 Jun 2015 23:06:46 GMT
Expires: Wed, 10 Jun 2015 23:11:46 GMT
Last-Modified: Wed, 11 Jan 1984 08:00:00 GMT
Link: <http://www.gravatar.com/avatar/46ab5c60ced85b09c35fd31a510206ee?default=http://google.com/>; rel="canonical"
Location: http://i1.wp.com/google.com/

I'm gonna close this issue now, if you don't mind


Fix a typo in appointment booking link for marriages in Romania

We were provided with an incorrect booking link first. This fixes it.
@chrisroos unfortunately this is rather urgent so you'll need to rebase your conversion work once this is merged :|

Budapest <-> Bucharest. A pretty significant typo!
I assume there's no regression test coverage for this which is why the test artefacts haven't changed...?

I assume there's no regression test coverage for this which is why the test artefacts haven't changed...?

That's correct

LGTM :+1:


Build issue

Running into build issues with Raigad. Build fails while executing test cases present in TestElasticsearchConfig. Does your test cases require Cassandra host to be up at the time of build? I am running elasticsearch 1.4 on ubuntu.
Here is the stack trace>>
com.netflix.raigad.resources.TestElasticsearchConfig > getNodes_handlesUnknownHostException FAILED
java.lang.IllegalStateException at TestElasticsearchConfig.java:80
31 tests completed, 1 failed
:raigad:test FAILED
FAILURE: Build failed with an exception.

@santokhsingh , I have updated the Wiki (Setup page) with updated information and also added new Configuration Properties page. Let me know if this helps.
Thanks,
Sagar


fix: exclude 'master' rule when preceded by '/'

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open a GitHub issue as a bug/feature request before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #428 🦕

I recommend using a custom config instead of changing the initial defaults.  https://github.com/jpoehnelt/in-solidarity-bot/blob/main/docs/README.md


Add headers to app routes IPC

Force merging. This PR is failing on #3521, and #3521 is failing on this PR.


CMOS-156: Update add cluster form for CB7 and make Prometheus/CBMM optional

Good point - yeah, tested it, though this is slightly difficult to screenshot:

Good point - yeah, tested it, though this is slightly difficult to screenshot:

What are the defaults? Both ticked?

Yep, default is both enabled, and the buttons are only disabled if neither is.


lib: don't close reader inside ReadStream

When aci.NewCompressedReader was changed to return a ReadCloser, we
changed the code in ReadStream to close it and then wrapped it with a
NopCloser. That was obviously wrong although it didn't seem to have any
effect.
Let's return the ReadCloser directly instead.

yikes. Great catch.


Extensions

Hi,
First of all, awesome library - thankyou!!
I know this was opened on #89.
The extensions field IS part of the standard (albeit as an optional field), see https://github.com/graphql/graphql-spec/blob/main/spec/Section%207%20--%20Response.md , and (as #89 quoted) "would be easy to implement - maybe as an Option<serde_json::Value>". I think it DOES need to be an Option<serde_json::Value>
I'm trying to introduce a rate throttle on a Shopify Graphql based workflow which uses the extensions field to show associated costs of calls.
I'm trying to figure out the best way to do this with the existing code (may a trait on the Response?), but I'm a bit of a Rust newbie.
Or is there any plan to add this field directly any time soon?
Many Thanks,
Tony

I think adding extensions to this type would be the way to go.


build: prefer -InstallTo over custom CMake options

Re-use the existing -InstallTo option over the CMAKE_INSTALL_PREFIX CMake parameter for building the targets. This cleans up the options usage to use that mechanism. The intention is to minimise the custom parameters to CMake in favour of a standard option handling.

@swift-ci please test

@swift-ci please test macOS platform

@swift-ci please build toolchain Windows platform


Expose send to simplify dry-run -> fix -> send workflow

Pull Request Test Coverage Report for Build #79

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build #74:
0.0%

Covered Lines:
296

Relevant Lines:
296

💛  - Coveralls

Pull Request Test Coverage Report for Build #79

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build #74:
0.0%

Covered Lines:
296

Relevant Lines:
296

💛  - Coveralls

Did exposing the send method completely address the issue for you?

Did exposing the send method completely address the issue for you?


Update 01_basename_social_dropdown.md

What changed? Why?
The corrected word is "component."
Notes to reviewers

How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Update renderscript task to also handle renderscript-v8 support library

Reimplemented renderscript task to use new RenderscriptProcessor tool.
Added handling for renderscript support library, and proper renderscript targetApi parameter (defaults to min sdk version, and can be changed in project.properties, as described here: https://code.google.com/p/android/issues/detail?id=40487).
Also added generated jni libs to packageAar (only libs from current project and renderscript, no transitive dependencies).
I've been using newer syntax for tasks: val renderscriptTaskDef = Def.task { instead of map, is that a problem?
In general: is there any specific reason why you keep using <<= with map?
What do you think about refactoring with new syntax and splitting stuff into smaller files (for example : renderscriptKeys, renderscriptTasks, etc.)?

using the old syntax is a by-product of old sbt 0.12 support, it will change as stuff gets touched there.
as for major refactorings and splitting stuff up, it won't happen for a while yet

Rebased with current master, added small fix for duplicate buildTools usage.

So, everything's looking pretty good, last question is the value of rsDebug is there a desire that it should be non-debug when producing a debug build?

does it make sense to default to debug when building debug and non-debug when building release?

I would expect `rsDebug := apkbuildDebug.value()

If the above is always true, and a user would not want to deviate from this, do we want to keep a separate rsDebug at all?

My expectation is to either remove, or set rsDebug to the current build type by default.

Actually this parameter is rather unsafe, default ant build files (included in sdk) don't use it at all. I've seen some comment in code (don't remember where) that it's broken, at least in some versions.
So setting it to apkbuildDebug is not good choice, we can completely remove it and default to false.

Ok, rsDebug has been removed.

@zbsz so, when using renderscript without support-mode enabled, I get src/main/res/raw/bc{32,64}/ created. This causes subsequent builds to fail unless I manually rm those directories first. Do you know what the cause might be?
If I use rsSupportMode, the problem goes away (and I guess is the recommended mode of operation in any case).

Renderscript compilation has changed in platform tools 21, but my changes don't support that.
Previous versions don't generate this bc{32,64} directories.
Easiest work around is changing rsTargetApi to some lower value, by default it is set to minSdkVersion.


Push to alternative registry than Docker Hub

Docker hub has very limiting rate-limits, please consider pushing to another registry.

Thanks for the issue, i already was thinking about this & guess we'll switch to ghcr, as it seems as one of the "cooles" registries currently. But first i want to work on the CI pipeline in general.
So this will be after or while working on 16

Yea, we'll switch soon[tm] https://blog.alexellis.io/docker-is-deleting-open-source-images/


Enforce minimum required version of NGINX for version for external dns

@giantswarm/team-batman , is this sth the app metadata features can help with?
As an engineer (whether GS or customer) doing a workload cluster upgrade, I want to be warned when a successful cluster upgrade requires me to do sth with an optional app (in this case, nginx), so that I don’t have to remember to upgrade NGINX manually or risk causing downtime.
From @glitchcrab : It would be great to be able to enforce a min. required version of nginx for that version of external dns.
Currently relevant for:

External DNS v2.0.0+ requires NGINX v1.14.0 (see readme)
AWS v14.0.0 (slack in product-managedapps)
Azure v14.1.1 (slack in team-celestial)

Call w @piontec Wed, 03. Mar 2021

this is dependency management.
Don't want to do NGINX-specific hacky thingy
Until it's not burning for customers, will keep it in hold?


(PUP-9240) Properly handle incomplete SMF services

jenkins please test this on solaris10-64a,solaris11-64a,solaris114-32a

CLA signed by all contributors.

jenkins please test this on solaris10-64a,solaris11-64a,solaris114-32a

Pushed up an update -- https://jenkins-platform.delivery.puppetlabs.net/job/platform_puppet-agent-extra_puppet-agent-integration-suite_pr/811/ is the passing acceptance test job.


How to get params from a parent state in 1.0.0 Beta 3

Hi,
I'm trying out now the latest version 1.0.0 Beta 3 and I must say is awesome and more powerful. However I'm stuck now trying to refactor a breadcrumb component. The breadcrumb component takes the current state (child) and extracts the current params, and it does the same for all the parents up to the root state in order to construct a Map<state, params> so the breadcrumb contains everything needed to navigate to a certain state with the correct params when the user clicks on it.
Now in the 1.0.0 Beta 3 I can't find a way to get the actual value of the params. It seems I need to do something like this:
// get current state own params (the same can be done with the parents via 'parent')
let stateParams: Param[] =  $state.$current.parameters({inherit:false}));
// then somehow filter only the state's own params and look them up in the $state.params
let params: StateParams = $state.params.
// but $state.params gets the current values (from the child)

But this would only work for the current state, how can I do the same for the parent states? What if the parent state has paramX = "hey" and the child overrides paramX = "hello", how can I get the "hey" value from the parent?
I'm afraid the docs are not clear enough...

first off, I should mention that overriding parameters is (paramX defined in parent and child state) is not supported, and the behavior is undefined.  This is because most of the ui-router api uses an object of key/value pairs to provide parameter values.  I wish I could allow it, but it would demand some major API changes.

To get the transition params object, use Transition.params().  This returns all the transition parameters, but not organized by state.

To get the parameter values for each PathNode (in the activated state), use the Transition.treeChanges() function.  From there it's trivial to get the parameter values:
var path = $transition$.treeChanges().to; // an array of `PathNode` for the `to` state.
var tuples = path.map(pathnode => [pathnode.state.name, pathnode.paramValues]);
var map = tuples.reduce((acc, [name, values]) => (acc[name] = values, acc), {});


Feature request - Additional query options

The following additional query options would be very welcome:

Query only the latest available data point of some measure
Grafana Alerting with OSI-Soft PI data sources
Grafana Dashboard Variables > type query > OSI-Soft PI datasource > query data and use for example the latest available data point as a dashboard variable. For example, query the latest latitude/longitude from some GPS device and use the coordinates in another query as a variable in an embedded Windy text panel for a weather forecast at the latest received position.

Done in v3.1.0
Won't be fixed. Must use backend plugin with Go
To be done. At the moment this can be done with AF attribute value.

Done in v3.1.0
Won't be fixed. Must use backend plugin with Go
At the moment this can be done with AF attribute value.

Thanks coderReview 🙏


Make 3D touch a shortcut for long press on comments

We should do this everywhere we don't have 3D touch but do have a long press gesture. Just a nice ergonomic thing.

Done, now it's a gesture setting!


[FEA] Implement shuffle optimization when AQE is enabled

Is your feature request related to a problem? Please describe.
Once we merge https://github.com/NVIDIA/spark-rapids/pull/462 we will lose the optimization of wrapping a GpuShuffleExchangeExec in a GpuCoalesceBatches, which we have when AQE is off.
We should explore ways to re-enable this, even though we are not seeing a performance degredation from the TPCxBB benchmarks. It is possible that other AQE optimizations are offseting the impact of this.
Describe the solution you'd like
We have to return something that implements ShuffleExchangeLike when AQE creates new shuffle query stages, so we can't return GpuCoalesceBatchesExec.
We could potentially create some kind of wrapper for GpuCoalesceBatchesExec(GpuShuffleExchangeExec) that implements ShuffleExchangeLike. Another option would be to build the coalesce functionality directly into GpuShuffleExchangeExec.
Describe alternatives you've considered
None.
Additional context
None.

Note that when we use compression for shuffle we will likely rely on GpuColaesceBatches to batch-decompress a set of compressed ColumnarBatch.   See #487 for details.

After spending time studying the code today, I now understand that when we have GpuCoalesceBatches(GpuShuffleExchangeExec()), what this translates to at execution time is that GpuCoalesceBatches is really wrapping ShuffledBatchRDD which reads the output from the map-side shuffle operation.
The current AQE PR does something very similar because it creates GpuCoalesceBatches(GpuCustomShuffleReader()) which also just wraps ShuffledBatchRDD.
This means we did not lose any optimization after all, so I don't think anything actually needs to happen with this issue.


-g parameter not taken into account in custom report command line

when typing the command line "NMONVisualizer_2018-04-10.jar com.ibm.nmon.ReportGenerator -g1 myfile.nmon", the CPU.png generate does not display the graph as 1 point each second.
Current behavior : -g1 plot graphics the same as if it was not passed in parameter
Expected behavior : -g1 plot graphics with granularity as 1point each second

Are you using the latest version (2019-04-06)? There was a bug fix for this issue in that release.
You should see the granularity value in stdout with this version: Using granularity of 1s.

Oh my bad, I was using older version. It is working fine with version 2019-04-06. Thank you for your assistance


Reanimated update fixes

In order to update to Reanimated 3.4.2, we needed to perform some typing chores

Pull this into the 4.4.7-discord-1 instead of master. That's the branch our current package hash is based off of


compile error when using cmake with ubuntu

the compile error does not occur when using a fresh Debian.
the error is not there when using the makefile
[ 93%] Building CXX object CMakeFiles/tests.dir/src/datagrams/s7k/S7kParser.cpp.o
In file included from /usr/include/signal.h:328,
                 from /home/pat/MBES-lib/test/catch.hpp:7937,
                 from /home/pat/MBES-lib/test/main.cpp:2:
/home/pat/MBES-lib/test/catch.hpp:10717:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’
10717 |     static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;
      |                                                          ^~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/bits/sigstksz.h:24,
                 from /usr/include/signal.h:328,
                 from /home/pat/MBES-lib/test/catch.hpp:7937,
                 from /home/pat/MBES-lib/test/main.cpp:2:
/usr/include/unistd.h:640:17: note: ‘long int sysconf(int)’ declared here
  640 | extern long int sysconf (int __name) __THROW;
      |                 ^~~~~~~
In file included from /home/pat/MBES-lib/test/main.cpp:2:
/home/pat/MBES-lib/test/catch.hpp:10776:45: error: size of array ‘altStackMem’ is not an integral constant-expression
10776 |     char FatalConditionHandler::altStackMem[sigStackSize] = {};
      |                                             ^~~~~~~~~~~~
[ 94%] Building CXX object CMakeFiles/tests.dir/src/datagrams/kongsberg/KongsbergParser.cpp.o
[ 95%] Building CXX object CMakeFiles/tests.dir/src/datagrams/xtf/XtfParser.cpp.o
[ 96%] Building CXX object CMakeFiles/tests.dir/src/utils/NmeaUtils.cpp.o
[ 97%] Building CXX object CMakeFiles/tests.dir/src/utils/StringUtils.cpp.o
[ 98%] Building CXX object CMakeFiles/tests.dir/src/sidescan/SidescanPing.cpp.o
make[2]: *** [CMakeFiles/tests.dir/build.make:76: CMakeFiles/tests.dir/test/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:307: CMakeFiles/tests.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

error does not occur on Ubuntu 20.04
it only occurs on Ubuntu22.04
also in ubuntu 22.04 we dont have to specify in the cmake file to use c++17


Consistent labeling for Operator metric Services

Current labeling for Operator Metric Services

kuadrant-operator-metrics - control-plane=controller-manager
authorino-operator-metrics - control-plane=authorino-operator
limitador-operator-metrics - control-plane=controller-manager
dns-operator-controller-manager-metrics-service - control-plane=dns-operator-controller-manager

Proposed Change
To achieve consistency in the labeling of Operator metric services, I propose aligning the labels according to the pattern implemented by the authorino-operator, or by a new common pattern.
Two potential approaches:

Change label value to reflect correct service
kuadrant-operator-metrics - control-plane=kuadrant-operator
authorino-operator-metrics - control-plane=authorino-operator
limitador-operator-metrics - control-plane=limitador-operator
dns-operator-metrics - control-plane=dns-operator

Change both key and value
kuadrant-operator-metrics - component=kuadrant-operator
authorino-operator-metrics - component=authorino-operator
limitador-operator-metrics - component=limitador-operator
dns-operator-metrics - component=dns-operator

When labels are changed, please also update the ServiceMonitors as needed to ensure they target the correct Services.
See https://github.com/Kuadrant/kuadrant-operator/pull/953#discussion_r1814655693 for related discussion on this.


feature: support send authentication msg

Signed-off-by: slievrly<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
feature: support send authentication msg
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2825 into develop will decrease coverage by 0.14%.
The diff coverage is 30.00%.

@@              Coverage Diff              @@
##             develop    #2825      +/-   ##
=============================================
- Coverage      50.22%   50.07%   -0.15%
- Complexity      2952     2959       +7
=============================================
  Files            588      589       +1
  Lines          18922    18939      +17
  Branches        2282     2242      -40
=============================================
- Hits            9503     9484      -19
- Misses          8476     8487      +11
- Partials         943      968      +25

Impacted Files
Coverage Δ
Complexity Δ

...ava/io/seata/core/constants/ConfigurationKeys.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

tm/src/main/java/io/seata/tm/TMClient.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...ta/spring/annotation/GlobalTransactionScanner.java
49.51% <20.00%> (-2.01%)
17.00 <0.00> (ø)

...java/io/seata/core/protocol/RegisterTMRequest.java
47.36% <25.00%> (-15.14%)
4.00 <1.00> (+1.00)
:arrow_down:

...main/java/io/seata/core/rpc/netty/TmRpcClient.java
59.52% <33.33%> (-11.67%)
13.00 <4.00> (+3.00)
:arrow_down:

...ain/java/io/seata/core/auth/DefaultAuthSigner.java
50.00% <50.00%> (ø)
1.00 <1.00> (?)

...o/seata/core/protocol/AbstractIdentifyRequest.java
70.00% <100.00%> (+20.00%)
5.00 <1.00> (+2.00)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

... and 30 more

Codecov Report

Merging #2825 into develop will decrease coverage by 0.52%.
The diff coverage is 36.84%.


more efficiently combine inline chain rule lookups

Currently we generate a new lookup in cases where we could reuse the existing one.
There is currently a test case (disabled in CI) that checks this (bug514.fea).

fixed in #208


Unable to setup goadmin

Description : Unable to setup the goadmin. Could any one provide me the steps to setup goadmin.
When i am trying to run go install github.com/GoAdminGroup/go-admin/adm command i am getting below error.
cannot find package "github.com/GoAdminGroup/go-admin/adm" in any of: c:\go\src\github.com\GoAdminGroup\go-admin\adm (from $GOROOT) C:\Users\krish\go\src\github.com\GoAdminGroup\go-admin\adm (from $GOPATH)
Can anyone help me in setting up the application. Attached the screenshot below. Also when i try to import the postgressql provided we are getting errors in the copy command .

Example code [If you have any code info]
Others [screenshots or other info]

@krishnathokala Try to download it directly here, https://github.com/GoAdminGroup/go-admin/releases


Documentation did not deploy; may need a new DOCUMENTER_KEY

Fixed by adding new DOCUMENTER_KEY. Not sure why old one disappeared. Followed these instructions:
https://m3g.github.io/JuliaNotes.jl/stable/publish_docs/
import DocumenterTools
DocumenterTools.genkeys()

Note: must call second key "DOCUMENTER_KEY"


refactor(material/schematics): fix some typos and add JSDoc

@Splaktar needs rebase

@mmalerba done.


Windows 10 Fall Creators Update

Hi! GitWrap does not support last version of windows 10 =\

Hi and thanks for the report. Could you please elaborate on the issue? I'm not on a Windows system these days so I have not had the chance to do much testing on the Fall Creators Update.

Thanks. I will update my Windows VM and give it a go.

Hello again.
I've done some testing on the Fall Creators update and everything seems to work fine so far. I'll test with Android Studio tonight and see if that makes a difference. Are you sure you havent moved GitWrap.exe? The error message seemingly indicates it cant even find the executable.

Update: Tested with Android Studio and I'm seeing the same thing. Not yet sure if it's a bug with IDEA, Windows 10 fall creators update or GitWrap.

So I can rule out IDEA as older versions of Android Studio exhibits the same behavior. So this is obviously a WSL issue. I'll file a bug report.

Confirmed: It's a WSL issue. See here for more details.
TLDR: It's a known issue in WSL which has been fixed in the latest insider builds. I haven't been able to work around the issue so for now there's not much I can do.

I can confirm that GitWrap works fine with the latest version of Windows 10. Closing this. Please open a new issue if you're still having problems.


Fix settings.gradle

Fix rootProject.name setup.

Thanks, @jmaister. Actually, this template is completely broken because it's not yet migrated to AsyncAPI 2.0 and the new parser. I could merge this PR but the Java Spring needs to be completely rebuilt from the ground up. I'd be happy if you want to do it but just merging this PR would not change much. Hope you understand. And thanks again for your time!


Event graph not using filters

Describe the Bug
As you can see on the pictures I have defined a filter, and event list is returned correctly, but the graph just shows all the events present in the given time range without filtering out those not matching the filter.

Database
PostgreSQL
Relevant log output
No response
Which Umami version are you using? (if relevant)
2.11.2
Which browser are you using? (if relevant)
Chrome
How are you deploying your application? (if relevant)
Vercel

Fixed in v2.11.3.


[FileDialog] Rework option controls.

Fixes https://github.com/godotengine/godot/issues/95079

Replaces GridContainter with nested BoxContainers.
Replaces CheckBox with CheckButton to ensure check element is on the same side as OptionButton in multiple choice options.

Is the choice of CheckButton over a CheckBox the correct choice for export with debug?
Isn’t Toggle switches (CheckButton) usually used for settings that take immediate effect and should not require the user to click Save or Submit to apply the new state?
Also an example from Microsoft https://learn.microsoft.com/en-us/windows/apps/design/controls/toggles#choosing-between-toggle-switch-and-check-box

Yes, I agree a CheckBox makes more sense than a CheckButton here. I can't think of any use cases for a CheckButton in the FileDialog option controls, as none of them are expected to have an immediate effect.


When used keyboard interruption with Ctrl-c, called traceback by python.

When used keyboard interruption with Ctrl-c, called traceback by python like following error.
I think daedoman needs exception handler.

upa-san
how do you think about this?
Is there some suggestion?

~/C/deadman ❯❯❯ ./deadman deadman.conf
Traceback (most recent call last):
File "./deadman", line 593, in
curses.wrapper (main)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/curses/wrapper.py", line 43, in wrapper
return func(stdscr, _args, *_kwds)
File "./deadman", line 558, in main
deadman.main ()
File "./deadman", line 478, in main
time.sleep (PING_ALLTARGET_INTERVAL)
KeyboardInterrupt
~/C/deadman ❯❯❯ ./deadman deadman.conf
Traceback (most recent call last):
File "./deadman", line 593, in
curses.wrapper (main)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/curses/wrapper.py", line 43, in wrapper
return func(stdscr, _args, *_kwds)
File "./deadman", line 558, in main
deadman.main ()
File "./deadman", line 471, in main
target.send ()
File "./deadman", line 85, in send
res = self.ping.send ()
File "./deadman", line 186, in send
result = commands.getoutput (pingcmd)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/commands.py", line 50, in getoutput
return getstatusoutput(cmd)[1]
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/commands.py", line 60, in getstatusoutput
text = pipe.read()
KeyboardInterrupt

I completely agree with you. It's due to my lazy work. I will implement it during this two weeks (Interop shownet hot stage starts today).

Have a fun with code and networking!!!

One year has passed, at last, I added just an exception handler https://github.com/upa/deadman/commit/ba2e3fe592c9f83d1501f4af0ab0b8f0254b5ead !


What hybrid key concepts should be supported?

Followup to https://github.com/open-quantum-safe/oqs-provider/pull/268#discussion_r1342092145: This is to review all code for proper use of "numkeys" struct for hybrid keys

Reminder: change "classical_pkey" and "evp_info" structs to arrays if a majority votes for more classic keys in #284

Closing due to no feedback/interest for other hybrid key concepts expressed.


Staggered setup

The main issue is that currently, and as expected, with staggered object, some fields have different size (1 point less/more in the staggered direction)
We need to add an extra one point to the halo so that all fields have same size and we don't have OOB. For some reason it doesn't break now as I think the smallest extent is inferred, however it means the last point is not computed for some fields.

thinking again about this, is it really true that we have OOB? don't we just have one extra unused point in staggered Functions ?

I think this can be closed.

For some reason it doesn't break now as I think the smallest extent is inferred, however it means the last point is not computed for some fields.

any comments about this?

@mloubout I suspect this can be closed now?

Yes, closing


[WIP] Add supervised learning tutorial

[X] Data
[X] Model
[ ] Inference
[ ] Criticism

I am trying to port this tutorial.
@cpfiffer can you please tell me if I am in right direction? :smile:

I was just sitting down to look at this, would you still like me to?

As a side note, we currently have a linear regression tutorial here.

@cpfiffer I was unable to understand how can I get a batch of scalar valued normals (similar to this). So, I have decided to study julia and all the essential packages thoroughly first and then resuming writing this tutorial.


Does Not Work 7/28/21

Updated to most recent version, still does not function.

same here Error: Promised response from onMessage listener went out of scope after the download log

else if (jstext.indexOf("drawImplementation:function(t){var r=v") >= 0) {
                console.log("inject6:" + src);
                jstext = jstext.split("drawImplementation:function(t){var r=v").join("drawImplementation:function(t){window.drawhook(this);var r=v");
            }

epic games now owns Sketchfab, that extra code might be whats causing issues (whatever they added to the code)

use RegExp for Injection, hope it works longer


[Enhancement] Merge multiply blocks into one io reuqest in CacheInputStream

Why I'm doing:
In the past, CacheInputStream will split one io request into multiple io requests(each io request size is equal to one block size). It will occur high IOPS when the io range is not setted in SharedBuffer.
What I'm doing:
TODO
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

Can you describe a little bit about io coalesce strategy?

LGTM.

@Mergify backport branch-3.2 branch-3.1


PropertyFieldCollectionData - disableItemDeletion doesn't hide X icon when true

Category

[ ] Enhancement
[X] Bug
[ ] Question

Version
1.14.0
Expected / Desired Behavior / Question
When disableItemDeletion option is set to true, the X for deleting a row would be hidden instead of disabled.
Observed Behavior
disableItemDeletion set to true and the X icon is visible but disable. This causes confusion for end user as they don't understand that the icon is just disabled. Currently it just does nothing when set to disable.

Steps to Reproduce
Set disableItemDeletion:true in creating of PropertyFieldCollectionData.

@malcom1120 this could be a good enhancement. Thanks for the feedback. Will put it on the list for the next release.

Thanks.


~_test-output/tests.html is not being produced?

Just cloned the source today and tried to run the tests; "npm test" and i'm not getting the ~_test-output/tests.html. Initially i was using Ubuntu 16.04. I tried it in Windows 10 also and the same thing. I also tried to run the e2e tests and i do get a "protractor-results.txt" file

Ah. Sorry. We had to drop support for the HTML-Reporter which doesn't seem to work any more. I was disappointed.
I just now updated the README to remove mention of it.


Added Fetal Health Detection

Fixes: #184
The model is build using

Logistic Regression
Decision Tree
Random Forest
Gradient Boosting

And the highest accuracy score of 95.77% using Random Forest.

Hi @TAHIR0110 Kindly merge this PR

@abckhush merged!


HELP

We have an issue with our google voice kit led light button. Why isn't the Led Light button of the google voice kit not working or cutting on even after programming and hacking? We have replaced the voice kit once already and bought a new raspberry.

Duplicate of https://github.com/google/aiyprojects-raspbian/issues/670

We have an issue with our google voice kit led light button. Why isn't the Led Light button of the google voice kit not working or cutting on even after programming and hacking? We have replaced the voice kit once already and bought a new raspberry.


C++ generics with elaborated type specifiers fail to parse

The following: TypeParser.createFrom("Array<struct Node>", true) will create a generic type with a type parameter of type "structNode". This seems to happen here, because of some reason this function here will remove all the whitespace within the generic block. Therefore, the type parser cannot correctly identity the struct as an elaborated type specifier (which is normally ignored). However, simply removing the function also does not work since then it is parsed as seperate typeblocks and things really start to go wrong :(
https://github.com/Fraunhofer-AISEC/cpg/blob/3f3542015dd6c989b8f8274b89478dfe67922126/src/main/java/de/fraunhofer/aisec/cpg/graph/type/TypeParser.java#L261-L300

The TypeParser needs to remove the spaces from the generics, as spaces are used to split up the type string later on. Am I right assuming that the correct generic would be an ObjectType with the Name "Node" instead of "structNode". Would it therefore be sufficient to ignore elaborated types in the generics and just remove the keyword?

Simple answer: yes
More complicated answer: If I read https://en.cppreference.com/w/cpp/language/type correctly, a type that just references a type, that is just declared but never defined, i.e. using struct Node without having a struct Node {} definition beforehand would actually be an incomplete type, but I am not sure if we want to follow the standard this strictly. I guess for us it is more efficient to say that this is an object type.

I agree. For our purposes it is probably more convenient to abstract from the standard, and just make use of the IncompleteType, when there is no other possibility to represent a type in a differeny way. In this case an ObjectType would be expected.


Use parent strategy when building associations

This PR makes associations be created using the same strategy as their parent. i.e. if a Post has a User association and we build a Post, we should build a User as well - not create it.
Background
The source of this behaviour seems to go back to this gist.
There's a bit of discussion on #64 and #66, but then it seems to fall off the map a bit when the option to explicitly name a strategy is added.
Motivation
The main project I'm on at the moment has a fairly deep association chain. We use build_stubbed where possible, but find that we need to duplicate a lot of setup because after(:build) traits don't run with build_stubbed. At times, we're hitting the DB 5 times for associated creates for a single insert.
When looking into why we were hitting into the DB at all when building factories, I came across a number of other blog posts and pull requests of confused people. This does seem like confusing behaviour to most and the particular use case in the gist seems arguably incorrect - Post should probably validate user is present, and if it really does want to validate user_id then the factory should either set that or use create explicitly.
Results
I've struggled to find public codebases using factory girl a lot - please point me to any if you know of them.
Pending that info, I've tried this on private projects and have seen non-js suites drop by ~ 60% with no changes or failures.
Summary
So.... the situation seems to be:
Cons:

This might break things for people relying on (arguably) broken validates_presence_of foreign_key tests

Pros:

This should speed things up for people using build and associations
This makes the build association behaviour much less surprising

All those changes are pretty hard to quantify, so I totally understand if it's not a change you think it worth the risk. No harm in raising the discussion though, right? :-) Thanks for reading!

on quick scan, :+1: like a bunch. I am really for any and all work that simplifies the effort it takes to reduce hits to the DB.

This would be an immense improvement!
Currently, I end up explicitly changing the strategy to :build_stubbed for every association. However, the few times I actually :create the parent model, it often want the association to use :create as well. This change would allow me to remove the explicit strategies for most factories and rely on the default behaviour.
If there's anything I can do to help this getting merged, please tell me.

@bradx3 thanks for bringing this up - it's been on my mind for a while, and I'm often confused as to why we'd gone down the path of there being differences anyway (specifically, build will create associations).
@jferris do you recall what the context was, or if there were any specs that accurately captured the issues we'd seen and are trying to prevent, to see if AR has changed in such a manner that it's now not applicable?

Assigning an unsaved object to an association has some pitfalls in ActiveRecord. One of the most common was having validations like validates_presence_of :user_id; an unsaved object won't have a foreign key, so it ends up being invalid.
I think we'd need to double check our integration tests to figure out if we have coverage for all these scenarios. Alternatively, you could make the change and try it out in a few apps. I wouldn't be surprised if you saw some issues.

If it turns out to be a breaking change (somewhat likely) then I'd suggest making this behaviour a configurable option in a minor release, and the default behaviour in the next major version bump.

I'm really interested in having this change made available.  I didn't test for the functionality of your changes, but did verify on a private project (fork factory_girl master + cherry-pick the commit in this PR, my Gemfile pointing to local repo) that 100% of my suite (~1300 examples, not all using factory_girl of course) was passing properly with the changes included.
Our reason is the fairly simple one mentioned by Brad in the original filing: we do a fair bit of testing using factory_girl and are seeing a good number of cases where "build" ends up "creating" a lot of objects in the background, solely due to the relations defined in the factories.  This in turn slows down tests overall since they're hitting the database way more than they need to.
One caveat is that ActiveRecord relations often trigger a save just by the way that making the association functions.  See one list (not mine) here: https://gist.github.com/demisx/9896113  Even with these changes, I believe that "build" can still create some objects in the DB.

@jferris there's been a few changes to the acceptance test behaviour in this PR. Are there any other integration tests you're thinking of that I can check? Are they not in this project maybe?
Re: the validates_presence_of :user_id risk - I still see that as the symptom of an incorrect factory. If your model really needs to check :user_id rather than :user, shouldn't the factory be setting user_id explicitly?
Regardless of the correct/incorrect way to deal with that particular case, it does seem like a problem that will come up. Is there interest in the suggestion of:

Adding a configurable option, and possibly
Removing the option next major release?

@bradx3 I like the idea of adding an option for the transition. We did that before and I feel like it worked out well.
It would be cool to pair this option with something that makes it easier to get an ID if you need one.

It would be cool to pair this option with something that makes it easier to get an ID if you need one.

Just a humble request: can we consider that as a completely separate issue, so as not to slow this PR down? :grin:

Sounds fair @lime. I'll dig around in the repo for some examples of user-set options and implement that first.
Unfortunately my next two weeks are crazy, so that might not be until later this month. I'm sorry I've let this PR drag on for so long, but I guess it's more a nice-to-have than a must-have, so a bit of extra time to make sure we get it right doens't seem too bad. :grimacing: :

You're the one doing the work here @bradx3, I don't mean to rush you at all. :)
I was referring to the rest of us, that we shouldn't bloat the PR with feature requests that only add to your workload.

Hey folks. I've had a play with adding an option to keep the old behaviour (create on built associations), but i'm not really happy with the implementation - I've basically had to add a "create_all_associations" boolean onto the FactoryGirl.configuration object. That's doesn't feel right to me at all, but it's the best I've got :-( I've looked through history and can't find anything similar. Does anybody have any ideas or links for sample implementations?
The only "option" I can see is to explain the change in the changelog/readme - it's still possible and easy for users to set a create strategy manually (see example below) so maybe explaining that is sufficient?
association(:user, strategy: :create)

@bradx3 I think the PR you've got is actually pretty close - and adding a configuration option (as a boolean) seems totally reasonable to me. Once this is merged, we can cut a minor release, leaving the existing behavior, and allowing people to opt into it building instead of creating to see how it goes. If the consensus is that the new behavior makes sense, we can add a deprecation warning, and once 5.0 is shipped, flip the behavior (defaulting to the parent build strategy instead of :create). Thoughts?

Sounds perfect to me! :+1:

Thanks for the feedback @joshuaclayton @lime. I've added a FactoryGirl.use_parent_strategy option. Thoughts?

Any progress here? Just a kind reminder, guys :)

I'm not able to push this PR forward any more, so I think the best thing might be to close it.
Obviously the code will be there for anybody else to grab and take forward, but I think "closed" is probably the most accurate for this PR at this point.