Add global indicator based on Pusher status

Show if we are currently connected to Pusher in order to correctly set the expectations of the user for what functionality will work.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Web Version of SuperAGI

A web version of SuperAGI should be deployed, removing the dependency from Docker.

This is now live at app.superagi.com. Closing this issue.


Typing Updates

This is only type annotations and the addition of a couple of docstrings.
This is split 1/3 of #83 .

Blocks https://github.com/raspberrypi/picamera2/pull/346

Looks good, but could you target this at the next branch as well, please? Thanks!


new test for generated html files

The problem
When all the html files have been generated, all the ... should point to valid targets.
Currently, this does not happen because of bugs in the current tool-chain, particularly htmlify.
Although, it is also possible to test whether each link in the source Pod6 file, namely each L< > is valid, this does not guarantee that the final html file generated to render the Pod6 source has correct links. In fact, currently, the html files contain approximately 120 incorrect links.
Solution provided
A test file verify-generated-html-link.t goes through each html file in the html directory, finds each <a link and then verifies if the link exists (a) against a live static file server defined in P6_DOC_TEST_SERVER or (b) against the html files in the html directory.
The test uses 16 threads, and TAP syntax errors may occur when tests are returned in a different order.

See #1433

When I run this locally with no args, it runs about a 100 tests (104, 105, 91, then 97), hangs for a bit, then ends reporting a few failures.

Also, fails https://raw.githubusercontent.com/perl6/mu/master/misc/camelia.txt, but that is responding with content.

We are finally developing a minimal set of documents for testing in a separate repo as part of Google Summer of Code. Thanks a lot.


blob config documentation improvements

@ecobost writes
https://docs.datajoint.io/python/admin/5-blob-config.html quick
feedback on the docs of storage, I think it looks good. I would add
a quick one-line explanation of what S3 is adn also I would change
the location of the examples to be /net/djblobs rather than
/net/djblobs/myschema because a folder with the name of the schema
will be created inside djblobs/ anyway so adding the myschema folder
creates too much nesting

https://docs.datajoint.io/python/manipulation/4-Transactions.html another minor addendum. I think the line "The sequence make include data queries and manipulations." should be "The sequence may include data queries and manipulations."


Add Coverity Scan

Integrate project to Coverity Scan: https://scan.coverity.com/projects/leokolln-cppaikit

Script changes submitted on b693ab095b151299cb02892f9f52b17901c8b16a.
Must create branch coverity_scan and test if it is working.


Main Exception local variable 'driver' referenced before assignment

Hey there,
I was unable to use the executable for MacOS nor Windows, so I decided to check out the repo and see if I were able to make it work from there.
I followed everything in the instructions and was able to launch chromium and authenticate, but when it's time to start scraping, it fails with this error:
Main Exception local variable 'driver' referenced before assignment
I did the same for both Windows and MacOS. Same result. Can launch the driver, can login with chromium, then this error happens.

I found the issue. Or better, I found where the error is happening and why it isn't actually showing what the problem is.
In educative_scraper.py you have from line 938:
except Exception as e:
        driver.quit()
        print("Exception, Driver exited", e)
        raise Exception(e)

I think driver.quit() for some reasons prevents the error from being shown here.
If you put it after the print statement, you can see the actual error from that page.
My problem is the lack of text file. The instructions aren't clear, so I ended up putting the link directly in there instead of the link to the file.

@sachamorgese To scrap manually, run chromedriver.py and then educative_scraper.py
Make sure that you have extracted the Chrome-binaries provided in releases for respective OS.
Since you were able to authenticate your account, so I assume the chrome binaries are correctly placed.
Next you have to create a simple text file ".txt" and paste the link of the first topic in a course (displaed in README.md).
You can also provide a number before the link to specify the starting index of the topics. (Helps for resume feature, if scraper stops for some reason then you can just copy/paste the index URL from log.txt to continue scraping from where it was left previously)
Next you have to generate a config, where you have to specify the path to text file and the save directory path.
Then authenticate your educative account
Then start scraping.
Recommended - You headless = True for scraping, And don't run multiple scrapers as it may cause captcha issues.


Is it possible to send pkill process before running test ?

Hello
I would like to know if it's possible to send a !pkill 'myprocess' before running rspec_command. I'm using rerun and test loop at every files changes. When I want to run different test I have to jump to iterm, ctrl+c and then I can restart the test from macvim.
For the moment I only have
" Rspec.vim run command
let g:rspec_command = "clear && rerun --dir app,spec,config bin/rspec -b -p "**/*.{rb,js,jbuilder,coffee,css,scss,sass,erb,html,haml,ru,yml,slim,md}" ' {spec}"
let g:rspec_runner = "os_x_iterm"

It seems I have to stop the rerun process. If I do :!pkill -f rerun it's kill properly the process. But if I do let g:rspec_command = "!pkill -f rerun && clear && rbr {spec}" I get
Error detected while processing function RunCurrentSpecFile[4]..<SNR>40_RunSpecs:
line    3:
E34: No previous command

Thanks in advance.
Benoit

Try: let g:rspec_command = "pkill -f rerun && clear && rbr {spec}" without the !.

Thanks @gylaz
The command is sent to the iterm window but not executed.

I think it's more related to rerun than vim-rspec. I close it for now and will dig into stop properly rerun from vim.


Screen to gif is "remembering" a shape that it shouldn't

So, basically, I edited one of the images in the editor to include a shape, but applied the image accidentally before rotating it correctly. As a result, I used "ctrl + z" to undo the action. Navigating back to that image, the shape was successfully removed, but whenever I go to re-add the correct image, the old image which was placed incorrectly re-appears. See the video at the below link to see the issue replicated:
https://www.dropbox.com/s/121uhzo3zgij9xa/Untitled.mp4?dl=0

As a workaround, you can select the shape with the "select" tool and remove it with a right-click.

As a workaround, you can select the shape with the "select" tool and remove it with a right-click.

That is one way.  Another (that I used) involved saving the project and closing and relaunching the application.


lowercase all files

resolves #109

Thanks @bitschmidty . I've squashed your change into the first commit and rebased on master.

Rebased on master. I think we should merge this before any other open PRs to avoid further rebases.
@bitschmidty - are you able to quickly rereview?


Add Barton Peveril College

Website: https://barton-peveril.ac.uk

@lewisdrake28 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Rename UniMemoize#atLeast to forFixedDuration

Fixes #743

@siewp can you please amend + force-push your commit by replacing:
refactor: Rename UniMemoize#atLeast to forFixedDuration

with:
refactor: rename UniMemoize#atLeast to forFixedDuration

@jponge Done.


HOW TO RETRAIN USING SNAPSHOT ：）

Hi， @Orpine ,
Now I'm training a very large dataset using the amazing rfcn network. Because the iterate time is 1500k,    it may break sometime, so I want to know how to retraining the network using snapshot?
I try to add --snapshot output/resnet101_rfcn_ohem_iter_1000000.solverstate , but it doesn't work.
can you help me ? anybody help?

Hi,
I suggest you use our new implementation https://github.com/msracver/Deformable-ConvNets. It supports multi-GPU training and could easily use snapshot to resume training.

@Orpine ok, I will try, and thank you for your suggestion .


[/trust] Cannot trust players who aren't online

Describe the bug
You can only /trust players who are online (in titan and orion)
To Reproduce
Steps to reproduce the behavior:

Go to Titan or Orion
Make claim
/trust [online player]
See them trusted
/trust [offline player]
"Player [offline player] is not found."
See error

Expected behavior
You should be able to trust people who are offline
Username:
FarDiamond3049
Server name (all applicable):
Titan, Orion
Logs:
Where needed, please find your logs with the method down below. Make sure to include the file, or better yet, use a site like https://pastebin.com/ to add it to the ticket without copy pasting all the contents of the file.
For the Minecraft Launcher : C:\Users\USER\AppData\Roaming.minecraft\logs
For the Technic Launcher: C:\Users\USER\AppData\Roaming.technic\modpacks\pixelmon-reforged\logs
For the ATLauncher: C:\Users\USER\AppData\Roaming\ATLauncher\Instances\PixelmonCraft\logs
For the Twitch Launcher: C:\Users\USER\Documents\Curse\Minecraft\Instances\PACK\logs
Additional context
Add any other context about the problem here.

this is a griefdefender issue, something we can't fix


key phrase extraction in NLTK

Do we have key phrase extraction in NLTK?

You can use NLTK's association metrics for doing keyword analysis. For example, this finds the keywords associated with the "romance" section of the Brown corpus as measured by likelihood ratio:
from nltk import FreqDist, collocations
from nltk.corpus import brown

bigram_measures = collocations.BigramAssocMeasures()

romance = FreqDist(w.lower() for w in brown.words(categories='romance') if w.isalpha())
freq = FreqDist(w.lower() for w in brown.words() if w.isalpha())

key = FreqDist()
for w in romance:
    key[w] = bigram_measures.likelihood_ratio(romance[w], (freq[w], romance.N()), freq.N())

for k,v in key.most_common(10):
    print(f'{k:10s} {v:9.3f}')

And the output is:
she         1163.325
i            995.961
her          930.528
you          513.149
of           501.891
is           463.386
had          421.615
he           411.000
the          347.632
said         300.811

no option in NLTK for Key Phrases


Mouse wheel

Will there be mouse wheel (scroll up and down) support?

You should be able to by doing:
robot.scrollMouse(x number, y number)

It actually doesn't work >.<

Not much, but in same case the PageUp,PageDown and the Arrow buttons can be alternatives!

实际上scrollMouse已失效，在win它没有任何反应


OpenAPI specification for backend

Is your feature request related to a problem? Please describe.
Some customers would like to use only the backend part of IA and bring their own frontend. Also there is a requirement for APIM integration.
Describe the solution you'd like
OpenAPI (Swagger) specification for the chat endpoint and other endpoints, in a same way like at the enrichmentweb app.

@torokzs, you can find in our vNext-Dev branch the recent PR #416 that will add Swagger documentation to our webapp backend services. This will be coming in a future release.

Resolved with latest release v1.1


Update CONTRIBUTING.md

#971
Fixed a few typos.

Thanks @rucha0702 for your contribution.
BTW as mentioned precisely on this page 😉, PR should be send to the dev branch only.
Could you send your PR to the dev branch instead of the master branch?


Create playlist based on tags

I just wanted to make sure that you know about the playlist feature. Starting a playlist will cycle dashboards at a set interval. Kinda nifty for tv monitors in the office or a booth at conferences. You can start a playlist by going to a specific url ex http://play.grafana.org/playlists/play/1

I saw that feature, but there was no request to use it yet.
I will make use of it if needed for our project.

I'm closing this for now. We're not planning dashboards playlists atm.


Adding OWASP Dependency Check job

Also:
Adding test for Owasp Dependency Check job
Fixing https://github.com/Accenture/adop-cartridge-java/issues/33
Improving .gitignore
This PR is dependent on the docker image created by this PR:
https://github.com/Accenture/adop-jenkins/pull/25
being tagged and consumed by an updated:
https://github.com/Accenture/adop-docker-compose/blob/master/docker-compose.yml

Hi @kramos , excellent additional to the pipeline! I've found that "Publishes OWASP dependency check results" supported by JobDSL by default, so not need to make configure fallback block there, you can reduce source code there and make it more convenient.

Good find @anton-kasperovich I replaced the publisher XML with DSL and tested it.
Thanks for the tip on searching the DSL plugin source code for DSL support, e.g. https://github.com/jenkinsci/job-dsl-plugin/search?utf8=✓&q=dependencyCheck

Here is a PR for the Jenkins update:
https://github.com/Accenture/adop-docker-compose/pull/178 :)

Tested this in a vanilla latest ADOP and

the new OWASP_Dependency_Check job worked (currently finding some JavaScript as well as Java vulnerabilities)!
all the other jobs worked
all three environments worked (post being created and deployed to)

OWASP_Dependency_Check tested and working with and without setting threshold.

is there any outstanding issue preventing us from merging this? it would be great to have in Java cartridge by default.


C++ Bond should build with MSVC /W4 and no global suppressions

Many consumers of C++ Bond have requirements to build with MSVC at /W4 with no global warnings suppressed. We need to make it easier for them to consume Bond by cleaning up the Bond libraries and generated code such that it builds at /W4 without any global suppressions. The current warning.h file is too broad to meet these needs.
Additionally, we need to investigate whether it is feasible to get Bond to build without _SCL_SECURE_NO_WARNINGS and _CRT_SECURE_NO_WARNINGS  defined.

This was implemented in the 5.3.0 release for MSVC 2015 and 2017. There are no current plans to make Bond /W4 warning-clean on MSVC 2013.


[Question]: about translating into natural language sentences

Describe your problem
How to translate pdf's table into natural language sentences by using deepdoc(TSR/pdf_parser)?

Let html=False.


Error getting node in setEtcdStatusCondition

Proposed Changes

Fixing a bug in setEtcdStatusCondition

Types of Changes

Bugfix

Verification

Testing

Linked Issues

https://github.com/k3s-io/k3s/issues/9048

User-Facing Change

Further Comments

I don't think this is the correct place to fix this. It looks like the node passed in here is coming from:
https://github.com/k3s-io/k3s/blob/60724764328c02a4695bb098556f6901b843c47b/pkg/etcd/etcd.go#L1089-L1094
Did you mean to break when a matching node is found, and error out afterwards if no node is set?
Also, its probably not a good idea to set node as a side-effect of iteration; I would probably do something like
			var node *v1.Node
			for _, n := range nodes {
				if strings.HasPrefix(member.Name, n.Name+"-") {
					node = n
					break
				}
			}
			if node == nil {
				continue
			}
			nodeIsMember[node.Name] = true

I totally agree with not setting node as a side-effect
The error was this one here, that is why the node == nil in setEtcdStatusCondition
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]: time="2024-01-10T18:24:43Z" level=warning msg="Failed to list nodes with etcd role: runtime core not ready"
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]: panic: runtime error: invalid memory address or nil pointer dereference
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x1a0 pc=0x46cbad6]
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]: goroutine 424 [running]:
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]: github.com/k3s-io/k3s/pkg/etcd.(*ETCD).setEtcdStatusCondition(0xc0007dc5b0?, 0x0, {0x6fae970, 0xc00d105040?}, {0xc003ac3240?, 0x19}, {0x5fee1fd, 0x5}, {0x0, 0x0})
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]:         /go/src/github.com/k3s-io/k3s/pkg/etcd/etcd.go:1249 +0x216
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]: github.com/k3s-io/k3s/pkg/etcd.(*ETCD).manageLearners(0xc0009314f0, {0x6f3ed90, 0xc00094ebe0})
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]:         /go/src/github.com/k3s-io/k3s/pkg/etcd/etcd.go:1115 +0x82c
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]: created by github.com/k3s-io/k3s/pkg/etcd.(*ETCD).Start in goroutine 1
Jan 10 18:24:43 ip-172-31-26-129 k3s[1669]:         /go/src/github.com/k3s-io/k3s/pkg/etcd/etcd.go:421 +0x125
Jan 10 18:24:43 ip-172-31-26-129 systemd[1]: k3s.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Jan 10 18:24:43 ip-172-31-26-129 systemd[1]: k3s.service: Failed with result 'exit-code'.
Jan 10 18:24:43 ip-172-31-26-129 systemd[1]: Failed to start Lightweight Kubernetes.

right, the problem is you can make it through that for _, node = range nodes loop without finding a matching node. If it's not found then you should just break there, instead of calling into set the status and returning an error from that - right?
That would indicate that there's an etcd node with no matching Kubernetes node, which seems like a different problem entirely.

right, the problem is that we are somehow making it through that for _, node = range nodes loop without finding a matching node. If it's not found then you should just break there, instead of calling into set the status and returning an error from that - right?
That would indicate that there's an etcd node with no matching Kubernetes node, which seems like a different problem entirely.

In a case where we only have etcd nodes, do you think that a continue like this, could impact?
if node == nil {
     continue
}

No, the problem is that we're just logging a warning instead of returning or retrying here:
https://github.com/k3s-io/k3s/blob/60724764328c02a4695bb098556f6901b843c47b/pkg/etcd/etcd.go#L1075-L1078
You then continue on to try to find nodes for each of the cluster members, with an empty node list.


Add pure verification method

The verifyProof() method currently does a little more that just proof verification - it store the nullifier in the contract (to prevent verifyProof being called again with same proof).
But there could be use cases where one would want to simply verify the proof - maybe even offchain, and also verify multiple time. Currently this is possible by calling the Verifier contract directly, but the caller would need to get group merkleRoot (and other data ) by calling Semaphore contract first. Additionally they will need to check if the proof was computed using an old merkleRoot themselves (which is already implemented in verifyProof).
We can add another method that does only verification without doing any state changes (saving the nullifier). In fact, this method could be called verifyProof, and the current verifyProof could be something like validateProof() (like validating a ticket which could be done only once).

I think this makes a lot sense 👍🏽

Oh right, sorry. I remember we creating it, but couldn't find it when I searched yesterday.


Add flags for options on scraping metrics

This PR adds 4 flags to the PushProx client to allow it to scrape metrics in various settings:

--use-localhost: Use <IP_ADDRESS> to scrape metrics instead of FQDN
--token-path: Uses an OAuth 2.0 Bearer token found in this filepath to make scrape requests
--insecure-skip-verify: Disable SSL security checks for client
--allow-port: Restricts the proxy to only being allowed to scrape the given port

~Dependent on PR (first two commits): https://github.com/rancher/PushProx/pull/1~

Although we should still support the insecureSkipVerify flag for any custom exporters, ideally this shouldn't be something that Rancher is reliant on in order to scrape metrics from Kubernetes components (as used in rancher-monitoring at the moment). Opened up an issue https://github.com/rancher/dev-charts/issues/64 in order to address this.


Fix Confidence with a None value

Indicator confidence without a value causes an error when elevating to STIX 2.1: AttributeError: 'NoneType' object has no attribute 'verbose'.
Example code to reproduce:
from cybox.core import Observable
from cybox.objects.address_object import Address
from stix.core import STIXPackage
from stix.common.confidence import Confidence
from stix.indicator import Indicator
from stix2elevator import elevate
from stix2elevator.options import initialize_options, set_option_value

initialize_options()
set_option_value('spec_version', '2.1')
pkg = STIXPackage()
addr = Address('<IP_ADDRESS>', Address.CAT_IPV4)
addr.condition = "Equals"
ind = Indicator(title='Address Indicator')
ind.add_indicator_type('IP Watchlist')
ind.add_observable(Observable(addr))
ind.confidence = Confidence()
pkg.add(ind)
elevate(pkg)

STIX 1.2 XML:
<stix:STIX_Package
	xmlns:AddressObj="http://cybox.mitre.org/objects#AddressObject-2"
	xmlns:stixVocabs="http://stix.mitre.org/default_vocabularies-1"
	xmlns:cyboxCommon="http://cybox.mitre.org/common-2"
	xmlns:stix="http://stix.mitre.org/stix-1"
	xmlns:stixCommon="http://stix.mitre.org/common-1"
	xmlns:indicator="http://stix.mitre.org/Indicator-2"
	xmlns:cybox="http://cybox.mitre.org/cybox-2"
	xmlns:example="http://example.com"
	xmlns:xlink="http://www.w3.org/1999/xlink"
	xmlns:ds="http://www.w3.org/2000/09/xmldsig#"
	xmlns:xs="http://www.w3.org/2001/XMLSchema"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	 id="example:Package-0b2ef582-73b5-43a0-9b03-b35f1b50c721" version="1.2">
    <stix:Indicators>
        <stix:Indicator id="example:indicator-40b8255b-89de-45d0-bef5-cb773106107e" timestamp="2020-03-12T15:29:21.946247+00:00" xsi:type='indicator:IndicatorType'>
            <indicator:Title>Address Indicator</indicator:Title>
            <indicator:Type xsi:type="stixVocabs:IndicatorTypeVocab-1.1">IP Watchlist</indicator:Type>
            <indicator:Observable id="example:Observable-6fb27c5d-1901-450e-a2cc-8167348cfa51">
                <cybox:Object id="example:Address-5a793cde-ad91-428f-8aac-1af91f8bc2ff">
                    <cybox:Properties xsi:type="AddressObj:AddressObjectType" category="ipv4-addr">
                        <AddressObj:Address_Value condition="Equals"><IP_ADDRESS></AddressObj:Address_Value>
                    </cybox:Properties>
                </cybox:Object>
            </indicator:Observable>
            <indicator:Confidence timestamp="2020-03-12T15:29:21.947499+00:00"/>
        </stix:Indicator>
    </stix:Indicators>
</stix:STIX_Package>

It is a useful check, but why not put it at the beginning of the method?
I don't think the location matters as much as the check happening. This seemed like the most logical place since isinstance(None, object) is always True. Adding the check at the top would probably add at least another warning, which seems superfluous in this case.

I was actually thinking there would be no warning if the confidence object didn't contain a value.
Its just poorly specified STIX 1.x - which is usually not warned about.
Maybe the test for None should be in convert_confidence?

I would think that you would want the check as close as possible to the issue. This guards against the possibility of the function being called elsewhere with bad data. In a hypothetical future situation, let's say you have convert_confidence_2_1() and convert_confidence_2_2(). Then you have to have the check in 2 places instead of 1.
But with that said, if you really want it in convert_confidence, that is where I'll put it.
On a side note, the line that calls convert_confidence (https://github.com/oasis-open/cti-stix-elevator/blob/master/stix2elevator/convert_stix.py#L652) passes the built-in Python id function and not some object ID.

@nschwane you are correct, its indeed passing the python built-in id which is not correct. Now, I think the area you referenced (https://github.com/oasis-open/cti-stix-elevator/blob/master/stix2elevator/convert_stix.py#L652) is the preferable place to make the fix to prevent the method from being called with bad data.

@nschwane - good catch!
Please make the changes for the bad confidence data.  I will fix the 'id' issue

@rpiazza @emmanvg, the requested changes have been made.

Codecov Report

Merging #199 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   69.74%   69.72%   -0.02%
==========================================
  Files          18       18
  Lines        5338     5338
==========================================
- Hits         3723     3722       -1
- Misses       1615     1616       +1

Impacted Files
Coverage Δ

stix2elevator/convert_stix.py
74.56% <100%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ef30a...9604ed5. Read the comment docs.


Incorrect generated type for vim.fn.expand()

expand() has the signature expand({string} [, {nosuf} [, {list}]]), where list is a boolean representing whether the output should be a list. Currently it seems that the type generator operates based on parameter names, and assumes this list parameter is of type list, which is incorrect.
The generator doesn't currently support manual overrides, which I think this would probably need.
generated definition:
--- @param list any[]
function vim.fn.expand(expr, nosuf, list) end

Function signature actually does not have much impact on the use, most people will read the documentation to get the meaning of the parameters. Avoiding these problems is a lot of work, and I don't really want to spend time modifying the data, so, pr welcome:)


Update commands to use the new option sets functionality for validating options

Define the list of commands where we could use the new option sets validation functionality. Once we have the list of commands to update, we can divide the work.

@waldekmastykarz is this issue tagged with help wanted by accident? Seems a bit strange to have both needs design and help wanted labels applied.

The idea behind this tagging was to solicit help for defining the body of work: which commands need to be updated, what updates are needed, etc, so help with spec, before we move to implementation.


Fix bad ffspec, adlfs imports

This is complicated but, adlfs <= 0.7 requires fsspec <= 0.9. Otherwise it tries to import things that arn't there and breaks our CI/CD. See the closed issue for more details.
close #53

This is a quick fix for CI/CD so I'm going to merge this without review.
Feel free to remove those pinned package versions in the future, as long as things (like CI/CD) continue to work.


Mock ClientRequest instead of request

As pointed out by @indexzero here:

All it takes is one smart-ass library author (or ancient library) to use http.createClient or instantiate http.ClientRequest directly. This circumvents nock.

This is now working:
https://github.com/pgte/nock/commit/3354aa57d621ab19aa257a78da864544eeb089c8#L1R908


.travis:fix up TestSpanStatRaceCondition failure

Improper use of the WaitGroup API caused goroutine
to execute out of order, which could be the cause of goroutine panic
Signed-off-by: Jianlin Lv<EMAIL_ADDRESS>Fixes: #12574

Coverage increased (+0.002%) to 37.184% when pulling 0ef087b0e72b540afbd310ca4889a576c124fecf on Jianlin-lv:pr-fix-spanstat-issue into 6783d327e6db9e0329716fbc9d4e81ad23b1ac0c on cilium:master.

I just noticed that TestSpanStatSecondsRaceCondition() suffers from the same issue.
@Jianlin-lv Would you mind fixing this one as well?

Done,
I did not notice this issue, Sorry

I just noticed that TestSpanStatSecondsRaceCondition() suffers from the same issue.
@Jianlin-lv Would you mind fixing this one as well?

Done,
I did not notice this issue, Sorry

No problem! Would you mind squashing the 2 commits into 1 though? They essentially fix the same problem.

I just noticed that TestSpanStatSecondsRaceCondition() suffers from the same issue.
@Jianlin-lv Would you mind fixing this one as well?

Done,
I did not notice this issue, Sorry

No problem! Would you mind squashing the 2 commits into 1 though? They essentially fix the same problem.

Done

No need to run the full test suite as this is a fix for the non-privileged unit tests that are run by travis.


nsc-events-nextjs_8_392_change-password-sign-out

Resolves #392
This PR fixes the bug where the user successfully changing their password redirects them to the sign-in page, but they are still logged in. Now, changing your password should sign you out, so that you can log in with your new password.
Recreate the bug:

While logged in, head to the Change Password page (auth/change-password)
Enter previous password and new password and confirm
You should be redirected to the Sign-in page, but in the Navbar, it shows "Sign out", proving that you are still signed in

I'm not sure why, but I'm getting this problem
NSC.Events.Mozilla.Firefox.2024-06-13.01-29-44.mp4
The password change is failing whether using a user, admin, or creator account.

I'm also getting this error.


New version: JLD2 v0.4.4

Registering package: JLD2
Repository: https://github.com/JuliaIO/JLD2.jl
Created by: @JonasIsensee
Version: v0.4.4
Commit: 56c5ac7531ca74404b1b0159419cbfcf6f777cd2
Reviewed by: @JonasIsensee
Reference: https://github.com/JuliaIO/JLD2.jl/commit/56c5ac7531ca74404b1b0159419cbfcf6f777cd2#commitcomment-49962768

@JonasIsensee please see the message above.  Once you fix the automerge issues you can register again the new revision without changing the version number and this pull request will be automatically updated.
[noblock]

@JonasIsensee please see the message above. Once you fix the automerge issues you can register again the new revision without changing the version number and this pull request will be automatically updated.
[noblock]

Thanks, @giordano
CompatHelper had also complained already.
Should be fixed now.
[noblock]


In regards to Contributions

Hey there,
I saw you guys recently started working on a Python port of PoB. I'd be highly interested to contribute in this undertaking.

Pull requests are welcome! This project is in its very early stages, so there are plenty of opportunities to contribute.

Is there a developer discord, mail list, skype group or any other platform you guys use for syncing up?
Greetings,
sVr

@svrNinety @kmoulins  there is an official discord server which can be found in PoBC's github page
https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/master/CONTRIBUTING.md

Ty @washa3. Closed Issue.


New package: Douglass v0.2.0

Registering package: Douglass
Repository: https://github.com/jmboehm/Douglass.jl
Created by: @jmboehm
Version: v0.2.0
Commit: 09cd0bb63f7cfe72a03c0981bd67a2340f385153
Reviewed by: @jmboehm
Reference: https://github.com/jmboehm/Douglass.jl/issues/10

Let's close this. I'll set the version number to 0.0.1 and try to auto-merge.


Lucia branch: ERROR: Failed to produce a Cloudflare Pages build from the project. The route /oauth/[provider] was not configured to run with the Edge Runtime

When I run the CF-deploy GH action https://github.com/timothymiller/t4-app/blob/325b5e58a39bf9cd4019db6273ad6ce62889cf2d/.github/workflows/next.yml#L46
I get this error:

⚡ Completed bunx vercel build.
⚡ ERROR: Failed to produce a Cloudflare Pages build from the project.
⚡
⚡     The following routes were not configured to run with the Edge Runtime:
⚡       - /oauth/[provider]
⚡
⚡     Please make sure that all your non-static routes export the following edge runtime route segment config:
⚡       export const runtime = 'edge';
⚡
⚡     You can read more about the Edge Runtime on the Next.js documentation:
⚡       https://nextjs.org/docs/app/building-your-application/rendering/edge-and-nodejs-runtimes

Any idea why? It didn't happen when I tried deploying the master branch a month ago..

It seems to work when I add export const runtime = 'experimental-edge'; to apps/next/pages/oauth/[provider].tsx.
Is this really necessary / is this the right solution?
Why did it work without it for you before? (I.e. why didn't you have this issue so far when deploying the lucia branch?)

I've been trying to track this issue down this past week.
Does it work when you set the runtime to 'experimental-edge'?

The long term solution is going to be moving this server side code to an API endpoint, outside of next.js

Does it work when you set the runtime to 'experimental-edge'?

Yes

Sorry about this. I recently added this apple oauth form handler and apparently never tested deploying to cloudflare. I must have only been running it locally.
I added some comments to the code to explain what it is doing there. Apple will POST form data to the redirect URI when scopes have been requested. https://developer.apple.com/documentation/sign_in_with_apple/request_an_authorization_to_the_sign_in_with_apple_server

Does it work when you set the runtime to 'experimental-edge'?

Yes (like I wrote above in my reply).
I'm just not sure if I should set the runtime to 'experimental-edge' only for this route or for all (in apps/next/next.config.js)..

Do you have a deployed example we can test?
When I've deployed this with experimental-edge set, I receive this error server side:
"Error: Some functionality, such as asynchronous I/O, timeouts, and generating random values, can only be performed while handling a request."

Does it work when you set the runtime to 'experimental-edge'?

Yes (like I wrote above in my reply).
I'm just not sure if I should set the runtime to 'experimental-edge' only for this route or for all (in apps/next/next.config.js)..

Do you have a deployed example we can test?
When I've deployed this with experimental-edge set, I receive this error server side: "Error: Some functionality, such as asynchronous I/O, timeouts, and generating random values, can only be performed while handling a request."

I literally just appended export const runtime = 'experimental-edge'; at the bottom of apps/next/pages/oauth/[provider].tsx.
(I didn't change the config in apps/next/next.config.js.)
Where do you see this server-side error btw? :)

When signing in with Apple, the redirect will take you to /oauth/apple with some query params. It's on this route that the client displays "internal server error", and if you check the cloudflare logs, you will see the above error.
After I removed the Tamagui provider and components from the route, the getServerSideProps call was able to complete.

Btw, I'm a big fan of your work on rust bindings for webview 😃

Ah. I didn't setup any oauth providers yet, I only tested with email auth so far.
(And with that, Looking at the log stream under Real-time Logs I only see successful responses.)

Email works well. Lmk how signing in with apple works for you.
If someone else can reproduce this error, I'll do a PR for moving the oauth provider logic to an api route.

Running in the iOS simulator on my #136 branch, I get
email<EMAIL_ADDRESS>email_verified: "true"

in the parsed ID token payload. For the use case of the current simple auth, that is enough. So maybe implementing the apple form_post handler isn't that important.

Cool! So maybe we can do it entirely client side?

I like the idea of handling it in middleware and returning the value as a cookie that can be deleted once processed client side


[Bug] Unable to find template "../build/symbol/icons-sprite.svg"

Describe the bug
Unable to find template "../build/symbol/icons-sprite.svg" (looked into: /var/www/html/src/bb-themes/admin_default/html) in "layout_login.html.twig" at line 24.
To Reproduce
Steps to reproduce the behavior:

Perform a fresh install using Docker.
Open browser to access "https://example.com/bb-admin"
See error

Expected behavior
Expect normal access to the admin page.
Desktop :

OS: Ubuntu Server 18.04
Browser: Edge 103.0.1264.77
Version: 62aacea

@abevol - seems like there's a problem with Gulp. Did you use our install script? Can you post the full build logs here?

@evrifaessa  Did you mean "make all"?
root@proud-echo-1:~/docker/fossbilling# make all
chmod +x ./bin/install.sh
./bin/install.sh
FOSSBilling installer v0.0.1
----------------------------------------------------
Welcome to the FOSSBilling installer for Linux. This script will guide you through the installation of FOSSBilling.
We will utilize Docker Compose in this script. If you want to install FOSSBilling manually, please refer to the documentation.
----------------------------------------------------
Working directory: /root/docker/fossbilling
----------------------------------------------------
No arguments supplied. Continuing with the installation as default.
----------------------------------------------------
Creating the configuration file...
Created the configuration file.
----------------------------------------------------
Changing folder permissions...
Folder permissions changed.
Building themes...
  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>this package is now deprecated
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>This SVGO version is no longer supported. Upgrade to v2.x.x.
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.

added 792 packages, and audited 793 packages in 46s

61 packages are looking for funding
  run `npm fund` for details

16 vulnerabilities (13 high, 3 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
npm notice
npm notice New minor version of npm available! 8.15.0 -> 8.16.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.16.0
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice
/usr/bin/env: ‘node’: No such file or directory
Successfully built the themes.
----------------------------------------------------
Starting FOSSBilling with a full rebuild...

Configuring for:
PHP Api Version:         20200930
Zend Module Api No:      20200930
Zend Extension Api No:   420200930
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for a sed that does not truncate output... /bin/sed
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for cc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking how to run the C preprocessor... cc -E
checking for icc... no
checking for suncc... no
checking for system library directory... lib
checking if compiler supports -Wl,-rpath,... yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking for PHP prefix... /usr/local
checking for PHP includes... -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib
checking for PHP extension directory... /usr/local/lib/php/extensions/no-debug-non-zts-20200930
checking for PHP installed headers prefix... /usr/local/include/php
checking if debug is enabled... no
checking if zts is enabled... no
checking for gawk... no
checking for nawk... nawk
checking if nawk is broken... no
checking for MySQL support for PDO... yes, shared
checking for the location of libz... no
checking for MySQL UNIX socket location...
checking for PDO includes... /usr/local/include/php/ext
checking for a sed that does not truncate output... /bin/sed
checking for ld used by cc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognize dependent libraries... pass_all
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking the maximum length of command line arguments... 1572864
checking command to parse /usr/bin/nm -B output from cc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if cc supports -fno-rtti -fno-exceptions... no
checking for cc option to produce PIC... -fPIC
checking if cc PIC flag -fPIC works... yes
checking if cc static flag -static works... yes
checking if cc supports -c -o file.o... yes
checking whether the cc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no

creating libtool
appending configuration tag "CXX" to libtool
configure: patching config.h.in
configure: creating ./config.status
config.status: creating config.h
/bin/bash /usr/src/php/ext/pdo_mysql/libtool --mode=compile cc -I. -I/usr/src/php/ext/pdo_mysql -I/usr/src/php/ext/pdo_mysql/include -I/usr/src/php/ext/pdo_mysql/main -I/usr/src/php/ext/pdo_mysql -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64   -I/usr/local/include/php/ext -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -c /usr/src/php/ext/pdo_mysql/pdo_mysql.c -o pdo_mysql.lo
mkdir .libs
 cc -I. -I/usr/src/php/ext/pdo_mysql -I/usr/src/php/ext/pdo_mysql/include -I/usr/src/php/ext/pdo_mysql/main -I/usr/src/php/ext/pdo_mysql -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include/php/ext -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -c /usr/src/php/ext/pdo_mysql/pdo_mysql.c  -fPIC -DPIC -o .libs/pdo_mysql.o
/bin/bash /usr/src/php/ext/pdo_mysql/libtool --mode=compile cc -I. -I/usr/src/php/ext/pdo_mysql -I/usr/src/php/ext/pdo_mysql/include -I/usr/src/php/ext/pdo_mysql/main -I/usr/src/php/ext/pdo_mysql -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64   -I/usr/local/include/php/ext -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -c /usr/src/php/ext/pdo_mysql/mysql_driver.c -o mysql_driver.lo
 cc -I. -I/usr/src/php/ext/pdo_mysql -I/usr/src/php/ext/pdo_mysql/include -I/usr/src/php/ext/pdo_mysql/main -I/usr/src/php/ext/pdo_mysql -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include/php/ext -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -c /usr/src/php/ext/pdo_mysql/mysql_driver.c  -fPIC -DPIC -o .libs/mysql_driver.o
/bin/bash /usr/src/php/ext/pdo_mysql/libtool --mode=compile cc -I. -I/usr/src/php/ext/pdo_mysql -I/usr/src/php/ext/pdo_mysql/include -I/usr/src/php/ext/pdo_mysql/main -I/usr/src/php/ext/pdo_mysql -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64   -I/usr/local/include/php/ext -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -c /usr/src/php/ext/pdo_mysql/mysql_statement.c -o mysql_statement.lo
 cc -I. -I/usr/src/php/ext/pdo_mysql -I/usr/src/php/ext/pdo_mysql/include -I/usr/src/php/ext/pdo_mysql/main -I/usr/src/php/ext/pdo_mysql -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include/php/ext -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -c /usr/src/php/ext/pdo_mysql/mysql_statement.c  -fPIC -DPIC -o .libs/mysql_statement.o
/bin/bash /usr/src/php/ext/pdo_mysql/libtool --mode=link cc -shared -I/usr/src/php/ext/pdo_mysql/include -I/usr/src/php/ext/pdo_mysql/main -I/usr/src/php/ext/pdo_mysql -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -Wl,-O1 -pie  -o pdo_mysql.la -export-dynamic -avoid-version -prefer-pic -module -rpath /usr/src/php/ext/pdo_mysql/modules  pdo_mysql.lo mysql_driver.lo mysql_statement.lo
cc -shared  .libs/pdo_mysql.o .libs/mysql_driver.o .libs/mysql_statement.o   -Wl,-O1 -Wl,-soname -Wl,pdo_mysql.so -o .libs/pdo_mysql.so
creating pdo_mysql.la
(cd .libs && rm -f pdo_mysql.la && ln -s ../pdo_mysql.la pdo_mysql.la)
/bin/bash /usr/src/php/ext/pdo_mysql/libtool --mode=install cp ./pdo_mysql.la /usr/src/php/ext/pdo_mysql/modules
cp ./.libs/pdo_mysql.so /usr/src/php/ext/pdo_mysql/modules/pdo_mysql.so
cp ./.libs/pdo_mysql.lai /usr/src/php/ext/pdo_mysql/modules/pdo_mysql.la
PATH="$PATH:/sbin" ldconfig -n /usr/src/php/ext/pdo_mysql/modules
----------------------------------------------------------------------
Libraries have been installed in:
   /usr/src/php/ext/pdo_mysql/modules

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
     during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
     during linking
   - use the `-Wl,--rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------

Build complete.

Creating fossbilling_php_1 ...
Creating fossbilling_mariadb_1
Creating fossbilling_php_1 ... done
Creating fossbilling_web_1 ...
Creating fossbilling_web_1 ... done
Successfully rebuilt.
----------------------------------------------------
Waking up the container...
fossbilling_php_1 is up-to-date
fossbilling_mariadb_1 is up-to-date
fossbilling_web_1 is up-to-date
----------------------------------------------------
Running the preparation script...
Production content
Connecting to database root@mariadb/fossbilling
Waiting for the database container to go up (29)
Dropping database fossbilling
Creating database fossbilling
Connecting to fossbilling database with user root
Create SQL database structure from file /sql/structure.sql
Import content to database from file /sql/content.sql
Finished the prepration
----------------------------------------------------
Installing Composer dependencies...

Package operations: 27 installs, 0 updates, 0 removals
  - Downloading symfony/polyfill-mbstring (v1.26.0)
  - Downloading docnet/tfpdf (v2.2.3)
  - Downloading psr/log (3.0.0)
  - Downloading filp/whoops (2.14.5)
  - Downloading composer/ca-bundle (1.3.3)
  - Downloading maxmind/web-service-common (v0.9.0)
  - Downloading maxmind-db/reader (v1.11.0)
  - Downloading geoip2/geoip2 (v2.13.0)
  - Downloading symfony/deprecation-contracts (v3.0.2)
  - Downloading psr/http-message (1.0.1)
  - Downloading psr/http-client (1.0.1)
  - Downloading ralouphie/getallheaders (3.0.3)
  - Downloading psr/http-factory (1.0.1)
  - Downloading guzzlehttp/psr7 (2.4.0)
  - Downloading guzzlehttp/promises (1.5.1)
  - Downloading guzzlehttp/guzzle (7.4.5)
  - Downloading michelf/php-markdown (1.9.1)
  - Downloading mustangostang/spyc (0.6.3)
  - Downloading symfony/polyfill-ctype (v1.26.0)
  - Downloading phpmailer/phpmailer (v6.6.3)
  - Downloading psr/container (2.0.2)
  - Downloading pimple/pimple (v3.5.0)
  - Downloading stripe/stripe-php (v7.128.0)
  - Downloading symfony/translation-contracts (v3.0.2)
  - Downloading symfony/translation (v6.0.11)
  - Downloading twig/twig (v3.4.1)
  - Downloading symfony/twig-bridge (v6.0.11)
  - Installing symfony/polyfill-mbstring (v1.26.0): Extracting archive
  - Installing docnet/tfpdf (v2.2.3): Extracting archive
  - Installing psr/log (3.0.0): Extracting archive
  - Installing filp/whoops (2.14.5): Extracting archive
  - Installing composer/ca-bundle (1.3.3): Extracting archive
  - Installing maxmind/web-service-common (v0.9.0): Extracting archive
  - Installing maxmind-db/reader (v1.11.0): Extracting archive
  - Installing geoip2/geoip2 (v2.13.0): Extracting archive
  - Installing symfony/deprecation-contracts (v3.0.2): Extracting archive
  - Installing psr/http-message (1.0.1): Extracting archive
  - Installing psr/http-client (1.0.1): Extracting archive
  - Installing ralouphie/getallheaders (3.0.3): Extracting archive
  - Installing psr/http-factory (1.0.1): Extracting archive
  - Installing guzzlehttp/psr7 (2.4.0): Extracting archive
  - Installing guzzlehttp/promises (1.5.1): Extracting archive
  - Installing guzzlehttp/guzzle (7.4.5): Extracting archive
  - Installing michelf/php-markdown (1.9.1): Extracting archive
  - Installing mustangostang/spyc (0.6.3): Extracting archive
  - Installing symfony/polyfill-ctype (v1.26.0): Extracting archive
  - Installing phpmailer/phpmailer (v6.6.3): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing pimple/pimple (v3.5.0): Extracting archive
  - Installing stripe/stripe-php (v7.128.0): Extracting archive
  - Installing symfony/translation-contracts (v3.0.2): Extracting archive
  - Installing symfony/translation (v6.0.11): Extracting archive
  - Installing twig/twig (v3.4.1): Extracting archive
  - Installing symfony/twig-bridge (v6.0.11): Extracting archive
Generating autoload files
13 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Successfully installed the Composer dependencies.
----------------------------------------------------
Removing installation leftovers...
Successfully removed ./src/install/.
----------------------------------------------------
Installation complete.
To create your administrator account, please visit the following URL: http://localhost/bb-admin
----------------------------------------------------
FOSSBilling needs funding! We're working hard to maintain FOSSBilling in the long run. If you'd like to support us, please consider donating to our project. We'd really appreciate it! See https://github.com/sponsors/FOSSBilling for more information.
You can also join the FOSSBilling Discord server at https://fossbilling.org/discord.

npm notice
/usr/bin/env: ‘node’: No such file or directory```

For some reason Node.js wasn't available in the container, so Gulp wasn't successfully ran. I'll check that when I go home.

npm notice
/usr/bin/env: ‘node’: No such file or directory

For some reason Node.js wasn't available in the container, so Gulp wasn't successfully ran. I'll check that when I go home.

Ok, thanks.

You can also manually run gulp for the time being.

Is this still valid?

Closing, I've heard no further reports of this issue with the docker image so it should be resolved.


v0.3.0 - command failed at update..

ilovegym@testbroker:/opt/iobroker$ iob update
Used repository: beta
Adapter    "admin"        : 6.17.7   , installed 6.17.3 [Updatable]
Adapter    "javascript"   : 8.3.1    , installed 8.3.0  [Updatable]
Controller "js-controller": 5.0.19   , installed 5.0.19
Adapter    "puppeteer"    : 0.3.0    , installed 0.2.8  [Updatable]
ilovegym@testbroker:/opt/iobroker$ iob upgrade
This upgrade of "puppeteer" will introduce the following changes:
-> 0.3.0:
allowed to specify additional arguments for the puppeteer process
updated puppeteer dependency
Would you like to upgrade puppeteer from @0.2.8 to @0.3.0 now? [(y)es, (n)o]: y
Update puppeteer from @0.2.8 to @0.3.0
NPM version: 10.5.0
Installing<EMAIL_ADDRESS>(System call)
npm ERR! code 1
npm ERR! path /opt/iobroker/node_modules/puppeteer
npm ERR! command failed
npm ERR! command sh -c node install.mjs
npm ERR! Error: ERROR: Failed to set up chrome-headless-shell v125.0.6422.60! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
npm ERR!     at file:///opt/iobroker/node_modules/puppeteer/lib/esm/puppeteer/node/install.js:84:27
npm ERR!     at async Promise.all (index 1)
npm ERR!     at async downloadBrowser (file:///opt/iobroker/node_modules/puppeteer/lib/esm/puppeteer/node/install.js:90:9) {
npm ERR!   [cause]: [Error: ENOSPC: no space left on device, write] {
npm ERR!     errno: -28,
npm ERR!     code: 'ENOSPC',
npm ERR!     syscall: 'write'
npm ERR!   }
npm ERR! }
npm ERR! A complete log of this run can be found in: /home/iobroker/.npm/_logs/2024-05-20T07_53_59_180Z-debug-0.log
host.testbroker Cannot install<EMAIL_ADDRESS>1
ilovegym@testbroker:/opt/iobroker$
Your current setup is:
/usr/bin/nodejs         v18.20.2
/usr/bin/node           v18.20.2
/usr/bin/npm            10.5.0
/usr/bin/npx            10.5.0
/usr/bin/corepack       0.25.2

argh.. no space left on drive.. shit.. sorry. closed.


doesn't start when editing TSX files

Thanks for this great package :-)
It seems to work great when I'm editing  CSS or HTML, but I can't get it to work in my react/typescript components.
I'm assuming this has something to do with syntax/languageId defintions, but I can't figure out what it is.
Thanks in advance!
I'm on ST4 build 4121

As always, the solution presents itself the moment I open an issue ..😄
This is what I needed to add to my config:
{
  "languageId": "typescriptreact",
  "scopes": ["source.tsx"],
  "syntaxes": [
    "Packages/JavaScript/TSX.sublime-syntax",
    ],
},

Should I perhaps open a PR for this?

I'll have a look. I've probably regressed this when changing the lsp_utils dependency. The actual fix should be a bit different but feel free to use yours.

Awesome, thanks a lot!

Strange that the existing config didn't work
https://github.com/sublimelsp/LSP-tailwindcss/blob/c75ac235cbb4107133808464bf1b81bd6d7929f3/LSP-tailwindcss.sublime-settings#L62

There is some code in LSP that handles the ST3-style configuration but it's not as robust as the code we had in lsp_utils and only works based on syntaxes in this case - https://github.com/sublimelsp/LSP/blob/7a9b8a64ef470de2f3c655626d44741a8105c186/plugin/core/types.py#L883-L890
And since the syntaxes defined here don't match ST4, it doesn't work.


Appcenter push: dynamic navigation based on custom data

Hi everyone, I'm wondering if I could get some help using AppCenter push in my Xamarin Forms app that targets Android & iOS.
Essentially, I've followed the instructions and I'm able to see the push notifications in my testing on Android.  I understand that there are different behaviors between foreground and background notifications and have stepped through via the debugger when the PushNotificationReceived event happens..
The issue I'm having is I cannot find a reliable way to isolate when a user is entering the app because they tapped on a notification when the app is not loaded.
In my App.xaml.cs, I have the following:
protected override async void OnInitialized()
        {

            InitializeComponent();
            Push.PushNotificationReceived += Push_PushNotificationReceived;

            AppCenter.Start("ios={ios ID}" +
                  "uwp={Your UWP App secret here};" +
                  "android={android ID}",
                  typeof(Analytics), typeof(Crashes), typeof(Push));

            await NavigationService.NavigateAsync("Splash"); // this is my splash screen that shows

        }

private async void Push_PushNotificationReceived(object sender, PushNotificationReceivedEventArgs e)
        {
            if (e.CustomData != null)
            {
                if (e.CustomData.ContainsKey("roundId"))
                {
                    string roundId = e.CustomData["roundId"];
                   //I want to navigate directly to this UI
                    await NavigationService.NavigateAsync($"IconNavigationPage/HomeView/Round?roundId={roundId}");
                }
            }
        }

So, as you can see, under normal circumstances, the app will load the Splash view which does some loading, and redirects to a home view.  When the notification is received and the user has the app running in the background, on Android, it's working fine.  I changed my launch mode to SingleTop and added the following to my MainActivity.cs
protected override void OnNewIntent(Android.Content.Intent intent)
        {
            base.OnNewIntent(intent);
            Push.CheckLaunchedFromNotification(this, intent);
        }

The issue is, when the app is not running in the background, and I tap the notification, the Splash screen navigation call is called, then my navigation call in the PushNotificationReceived event.  This essentially causes the app to load the UI that is defined in the event, for a second, then Splash UI redirects happen.   This is due to the fact that OnInitialize() gets ran when the app is loaded from the Tap of the notification, when the app is not running in the background.
I have experimented in trying to implement the PushNotificationReceived event handler in the Android MainActivity.cs file, and I do see that this fires before the same PushNotificationReceived event handlers in the Shared project.   Unfortunately it runs after the call to the LoadApplication, so my shared project's OnInitialize() gets fired first (which has that navigation call to Splash)
I guess what I'm looking for is some guidance, or maybe a point to a tutorial, on how I can accomplish notifying the Shared project's OnInitialize not to do the standard navigation to Splash, but rather do the navigation necessary for the Push Notification instead.  I've search high and low, but all of tutorials / docs simply do a debug write to console proving that that the custom data that was passed is there, which I too can see, I cannot find anything that handles real-world use cases of a viable workflow to control navigation based on the tap of a notification.
Any help or guidance would be greatly appreciated.
Thank-you in advance.

@SharbelWired I've asked the team to take a look at providing a recommendation.

@SharbelWired Please, try next to resolve situation:

Try to set LaunchMode to SingleTask and see if it does required changes.

I was unable to find event OnInitialized in activity or app lifecycles. Can you please try OnCreate event instead of the OnInitialized?

Other way to accomplish task is to keep state somewhere in app, for example add some static property into App.xaml.cs like next:
static public bool KeepPage { get; set; } = false;
set it to true inside OnNewIntent, check it in OnInitialized and set back to false after:
 ```protected void Push_PushNotificationReceived(Object sender, PushNotificationReceivedEventArgs e)
 {
 	//...
     if (!KeepPage) {
         //...
 		await NavigationService.NavigateAsync($"IconNavigationPage/HomeView/Round?roundId={roundId}");
 		//...
         KeepPage = false;
     }
 }```

@jwargo   I was able to do something similar to your suggestion in your item 3, but unfortunately the public variable in app.xaml.cs is set after the initial redirect.  I was able to use it a little later in the initial redirect to trap the redirect to the home UI.  It's not exactly ideal, but it'll work for now...

@SharbelWired that was @v-fekalu who suggested that.

@SharbelWired OK if I close this?

Yes, it can be closed @jwargo


Error on /slack/oauth_redirect using expressReceiver

Description
Hi, I'm getting this error when my app redirects to slack/oauth_redirect. I've looked at #1335 but I can't tell if its the same problem. The URLs are all https ones. I recently started using expressReceiver in order to be able to accept post requests from an external source. However, I may be using it incorrectly and thinking all wrong. Any help would be appreciated. Thank you.
[ERROR]  OAuth:InstallProvider:0 Error: The state parameter is not for this browser session.
    at new InvalidStateError (/Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/oauth/dist/errors.js:65:47)
    at InstallProvider.<anonymous> (/Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/oauth/dist/install-provider.js:498:39)
    at step (/Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/oauth/dist/install-provider.js:44:23)
    at Object.next (/Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/oauth/dist/install-provider.js:25:53)
    at /Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/oauth/dist/install-provider.js:19:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/oauth/dist/install-provider.js:15:12)
    at InstallProvider.handleCallback (/Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/oauth/dist/install-provider.js:462:16)
    at /Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/@slack/bolt/dist/receivers/ExpressReceiver.js:166:42
    at Layer.handle [as handle_request] (/Users/shakauser/Desktop/shaka-slack-bot/slack-app/node_modules/express/lib/router/layer.js:95:5) {
  code: 'slack_oauth_invalid_state'

const receiver = new ExpressReceiver({
  token: process.env.SLACK_BOT_TOKEN,
  appToken: process.env.SLACK_APP_TOKEN,
  port: process.env.PORT || 3030,
  signingSecret: process.env.SLACK_SIGNING_SECRET,
  clientId: process.env.SLACK_CLIENT_ID,
  clientSecret: process.env.SLACK_CLIENT_SECRET,
  stateSecret: 'some-shaka-state-secret',
  scopes: scopes,
  installationStore: {
    storeInstallation: async (installation) => {
      // change the line below so it saves to your database
      if (installation.isEnterpriseInstall && installation.enterprise !== undefined) {
        // support for org wide app installation
        return await database.set(installation.enterprise.id, installation);
      }
      if (installation.team !== undefined) {
        // single team app installation
        return await database.set(installation.team.id, installation);
      }
      throw new Error('Failed saving installation data to installationStore');
    },
    fetchInstallation: async (installQuery) => {
      // change the line below so it fetches from your database
      if (installQuery.isEnterpriseInstall && installQuery.enterpriseId !== undefined) {
        // org wide app installation lookup
        return await database.get(installQuery.enterpriseId);
      }
      if (installQuery.teamId !== undefined) {
        // single team app installation lookup
        return await database.get(installQuery.teamId);
      }
      throw new Error('Failed fetching installation');
    },
    deleteInstallation: async (installQuery) => {
      // change the line below so it deletes from your database
      if (installQuery.isEnterpriseInstall && installQuery.enterpriseId !== undefined) {
        // org wide app installation deletion
        return await database.delete(installQuery.enterpriseId);
      }
      if (installQuery.teamId !== undefined) {
        // single team app installation deletion
        return await database.delete(installQuery.teamId);
      }
      throw new Error('Failed to delete installation');
    },
  },
  installerOptions: {
    // If this is true, /slack/install redirects installers to the Slack authorize URL
    // without rendering the web page with "Add to Slack" button.
    // This flag is available in @slack/bolt v3.7 or higher
    directInstall: true,
  }
});

receiver.router.use(express.json());
receiver.router.use(cors());

const app = new App({
  receiver,
  logLevel: LogLevel.DEBUG,
});

receiver.router.get('/', (req, res) => {
  res.writeHead(200);
  res.end('Home Page!');
});

receiver.router.post('/shaka-events', (req, res) => {
  res.json(req.body);
  console.log(req.body);
});

What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Hi @julishaka, thanks for writing in. I've checked whether your app works for me and it works without any issues.
Since your /slack/oauth_redirect browser access has the state parameter in its query string, you should start the OAuth flow from /slack/install. The only possible causes that I think of are:

Your app failed to set cookies when redirecting the installing user from /slack/install for some reason
You've visited the /slack/oauth_redirect more than once (reloading the page etc.)
You've run multiple OAuth flows in the same web browser at a time

I would suggest checking the details of HTTP request / response during your OAuth flow. You can check those information using your web browser's inspector and curl https://{your public domain}/slack/install -v. I hope you will figure the cause out soon!

Hi @seratch, thank you for the quick response. Do you know of any reasons why the app wouldn't set cookies? I'm not sure what to look for when checking the details of HTTP request / response.
But I haven't visited /slack/oauth_redirect directly multiple times. I always start the OAuth flow from /slack/install. I don't think I've run multiple OAuth flows in the same browser at a time. If I did, the would the error go away just by closing tabs?
Thank you

I'm not sure what to look for when checking the details of HTTP request / response.
You can verify the set-cookie headers in the /slack/install response and cookie header in the /slack/oauth_redirect request are valid.

Also, do you use the latest versions of @slack/bolt and @slack/oauth for sure<EMAIL_ADDRESS>~ 2.5.1 had a bug on setting cookies logic: https://github.com/slackapi/node-slack-sdk/pull/1485

I'm not suite sure what you mean by valid. This is what I see. Also, yes @slack/bolt version 3.9.0 and @slack/oauth version 2.5.4
slack/install:

/slack/oauth_redirect:

@julishaka Thanks for sharing the details. The cause must be the old version of bolt that you are using. Please upgrade to 3.11.0 or newer. The latest version as of today is 3.12.1.

Oh my goodness that fixed it. Thank you so much for taking the time to help me!

Glad to hear that! Let me close this issue now


1.11.2 Cannot craft Compressed Obsidian

Issue description: http://wiki.aidancbrady.com/wiki/Compressed_Obsidian Not Possible.
Steps to reproduce:

https://cdn.discordapp.com/attachments/329036220422160384/329036293671616522/ScreenHunter_876_Jun._26_18.08.jpg
https://cdn.discordapp.com/attachments/329036220422160384/329036316782100482/ScreenHunter_877_Jun._26_18.08.jpg
Nothing Happens-- stuck cannot progress to make other things in the mod. D:

Version (make sure you are on the latest version before reporting):
Forge: 2315 Multiplayer Server
Mekanism: 309
Other relevant version:

That looks a lot like obsidian dust, not refined obsidian dust.
You need to put obsidian dust, together with some diamonds in the left slot in a metallurgic infuser.
You'll get refined obsidian dust out of it, which you can put in an enrichment chamber to make compressed obsidian.

Yup that was it thanks
Sent from my iPhone

On Jun 27, 2017, at 7:28 AM, Tom E<EMAIL_ADDRESS>wrote:
That looks a lot like obsidian dust, not refined obsidian dust.
You need to put obsidian dust, together with some diamonds in the left slot in a metallurgic infuser.
You'll get refined obsidian dust out of it, which you can put in an enrichment chamber to make compressed obsidian.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


fix: fix monolith welcome message

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1413  👈 (View in Graphite)
#1407
#1406
#1405
#1403
#1402
#1401
#1400
#1399
#1396
#1395
#1394
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


[bug] content_harvest task didn't run for a mapped task, but the mapped task's status is marked as a success

Expected
When a mapped task does not run, the status should be marked as failed, and represented by a red square.
What's happening
When a mapped task does not run, the status displays as a success, and is represented by a green square. This occurred during a run on March 23rd.
Example from March 23

[ ] 27143, mapped task 749 - link to content_harvest grid 749

Switch to the "details" tab, and you will see the green success indicator
Run ID: manual__2024-03-05T21:18:43+00:00
Mapper: omeka.nothumb
content_harvest mapped page permalink: 749

What concerns me is that I only found this issue by randomly clicking around in the content_harvest mapped pages. Since 27143 is so large, with 1,020 mapped tasks, the task is prone to stop running several times along the way. I've been selecting "Clear task" > choosing the "Only Failed" option, then re-running the tasks to run only failed tasks.
*** Reading remote log from Cloudwatch log_group: airflow-pad-airflow-mwaa-Task log_stream: dag_id=harvest_collection/run_id=manual__2024-03-05T21_18_43+00_00/task_id=content_harvesting.content_harvest/map_index=749/attempt=2.log.
[2024-03-06, 02:44:27 UTC] {{taskinstance.py:1093}} INFO - Dependencies not met for <TaskInstance: harvest_collection.content_harvesting.content_harvest manual__2024-03-05T21:18:43+00:00 map_index=749 [success]>, dependency 'Task Instance State' FAILED: Task is in the 'success' state.
[2024-03-06, 02:44:27 UTC] {{local_task_job_runner.py:154}} INFO - Task is not able to be run
[2024-03-06, 02:54:42 UTC] {{taskinstance.py:1093}} INFO - Dependencies not met for <TaskInstance: harvest_collection.content_harvesting.content_harvest manual__2024-03-05T21:18:43+00:00 map_index=749 [success]>, dependency 'Task Instance State' FAILED: Task is in the 'success' state.
[2024-03-06, 02:54:42 UTC] {{local_task_job_runner.py:154}} INFO - Task is not able to be run

@christinklez It looks like the task that failed was content_harvest task 749. The content_harvest row in the grid view is displaying a red square as it should. Maybe I'm misunderstanding the problem. Let me know if you want to hop on zoom to clarify!

@christinklez Oh nvm, I see what you mean! I was looking the wrong grid!

@christinklez I think there may be some confusion around the way Airflow handles running tasks. It will sometimes retry mapped tasks that have already been run (due to the parent task running for a very long time) and then report that it couldn't run them because they've already been run and have succeeded. For example, here's an excerpt from the message you linked to:
dependency 'Task Instance State' FAILED: Task is in the 'success' state.
It's very confusing, but I think Airflow is simply saying that that it won't run the task because it's already succeeded. And indeed the first attempt has succeeded.
Does that make sense and match your experience of things?
Also, when you say that "the task is prone to stop running several times along the way", what do mean you mean exactly? What do you see in the logs?

Thanks @barbarahui! It's a bit tricky for me to figure out when a "failed" task has previously "succeeded," but I will watch out for that!
By "the task is prone to stop running several times along the way," -- this tends to happen with larger collections that have many task pages. Usually during the map_page or content_harvest task.
Sometime while it's running a batch of map_page or content_harvest task pages, it will stop running and turn red. It will have failed on a particular page (but it gets tricky to find the particular page). The entire job will then stop. Once stopped, I can retry the "failed tasks" only, and it will retry only the red task pages.
Here's an example:

Run ID: manual__2024-03-27T00:02:50+00:00
During content_harvest mapped page 8

Link to airflow grid
Permalink to log

In this example, you can see there were two attempts. The first attempt error'd out and failed (along with other pages that failed). Later, when the entire content_harvest job failed, I clicked on the content_harvest job (and not a specific task page) and clicked "Clear" > "Only Failed" to rerun the failed pages. The second attempt was successful.

@christinklez To clarify re figuring out when a "failed" task has previously "succeeded": what I mean is that the task has never actually failed! That's why the task is marked with a green square. The message you're seeing from Airflow means that the conditions for rerunning the task were not met, so it didn't rerun the task. So it's correct that the task is marked with a green square as being successful. I don't think you need to watch out for these. You can rely on the red squares.

@christinklez Re long-running tasks stopping, I think Airflow is running into a timeout limit and killing the workers at that time. I'll investigate what we can do to increase that limit so that you don't run into this.

Likely fixed via #856


[SPARK-13931] Resolve stage hanging up problem in a particular case

What changes were proposed in this pull request?
When function 'executorLost' is invoked in class 'TaskSetManager', it's significant to judge whether variable 'isZombie' is set to true.
This pull request fixes the following hang:

Open speculation switch in the application.
Run this app and suppose last task of shuffleMapStage 1 finishes. Let's get the record straight, from the eyes of DAG, this stage really finishes, and from the eyes of TaskSetManager, variable 'isZombie' is set to true, but variable runningTasksSet isn't empty because of speculation.
Suddenly, executor 3 is lost. TaskScheduler receiving this signal, invokes all executorLost functions of rootPool's taskSetManagers. DAG receiving this signal, removes all this executor's outputLocs.
TaskSetManager adds all this executor's tasks to pendingTasks and tells DAG they will be resubmitted (Attention: possibly not on time).
DAG starts to submit a new waitingStage, let's say shuffleMapStage 2, and going to find that shuffleMapStage 1 is its missing parent because some outputLocs are removed due to executor lost. Then DAG submits shuffleMapStage 1 again.
DAG still receives Task 'Resubmitted' signal from old taskSetManager, and increases the number of pendingTasks of shuffleMapStage 1 each time. However, old taskSetManager won't resolve new task to submit because its variable 'isZombie' is set to true.
Finally shuffleMapStage 1 never finishes in DAG together with all stages depending on it.

How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
It's quite difficult to construct test cases.

Can one of the admins verify this patch?

@mccheah @kayousterhout do you have an opinion on this? you might be familiar with this method

@mccheah @kayousterhout Could you please take a look at this for me? Thank you in advance.

Can we not wrap this in a unit test in TaskSetManagerSuite?

+1 on @mcchea's request to write a unit test for this in TaskSetManagerSuite.
Also, can you change the PR description to say something like:
This pull request fixes the following hang:

@mccheah @kayousterhout  OK, I'll add a logging line. But it's quite difficult to construct a reproduction of the case. I can add a test symbolically, but without effect. Do you have suggestions for me?
It's no problem to change the PR description.I'll change it.

I think you can write a test that's similar to this one: https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala#L639
You can make a test with a one-task task set, and like the above task set, you can set things up so the task set's task gets speculatively executed.  Then, after finishing one copy of the task (so the task set will be marked as a zombie), you can call executorLost() on the TaskSetManager, and then check that the DAGScheduler's executorLost function gets called in the right way.  It looks like you'll need to some better mocking of the DAGScheduler than what's currently done in that test; it may be easier to create a DAGScheduler mock than to use the FakeDAGScheduler / FakeTaskScheduler that already exist in that test.

Is the unit test ok? Thanks.  @mccheah @kayousterhout

ok to test

Test build #54450 has started for PR 11760 at commit a1eb0f9.

Test build #54450 has finished for PR 11760 at commit a1eb0f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54450/
Test PASSed.

@kayousterhout Sorry to bother you again.  What should I do then?

Sorry for letting this hang for so long.  @GavinGavinNo1 do you have time to work on this, and if so, can you bring it up to date with master? Then I can review it again.

@GavinGavinNo1 if you don't have time to work on this PR, can you close it?

@kayousterhout Sorry that I tried before but internet connection is poor in my company and then I forget. I'll work on it back home today or  tomorrow.  Thank you for caring for this PR.

Great thanks!

@kayousterhout I got some problem with git conflict. So I create a new branch and a new pull request. You may refer to https://github.com/apache/spark/pull/16855. And I close this pull request for the time being. Thanks!


Sample request contents do not load in graph explorer

Describe the bug
When I click on any of the sample requests , it contents do not load
To Reproduce
Steps to reproduce the behavior:

Open Graph API explorer https://developer.microsoft.com/en-us/graph/graph-explorer
Sign in with your @microsoft account
search for the create group API and click on it
You will get this eternal loading indicator

Expected behavior
See a sample of the request contents
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 11 Enterprise 22H2
Browser Chrome Version 115.0.5790.110 (Official Build) (64-bit)

Hey @ashaabansoliman. Do you still experience this issue when you reload the page?
I can't reproduce it on my end:

Hey @ashaabansoliman. Try again. Everything should be okay now.


data shape, loading custom data, possible lookahead

Hi,
I am trying to test on my own datasets which are multivariate time series. I load the data into a Dataframe and then create the slices for train validate and test, just mimicking the existing code.
There is a point where my  n x m data, where m is the number of features, or covariate time series, is expanded to 1 x n x m. The comments in your code say "number of instances x timestamps x features". What is instances in this context?
I am worried that my results are perhaps too good to be true and I am trying to make sure I understand where lookahead might be.

"instance" means "sample". The difference between instances and features is that instances generally come from the same distribution. For example, for stock market, n_instance is the number of stocks, and n_features is the number of features (e.g. open, high, low, close, volume). For traffic flow, n_instance can be the number of roads, and n_features is the number of features collected on the road.
For a multivariate time series whose data shape is "n_variables x n_timestamps", the input shape may be either "1 x n_timestamps x n_variables" or "n_variables x n_timestamps x 1". It depends on whether these variables are features or samples.

Thank you for the clarification. I had not read the recent papers using contrastive loss, I am catching up. This is good work, thank you.


More than just profile information

Hello there 👋
The library works like a charm to retrieve information about the profile general info, thanks!!
I was wondering if I could also use it to get the latest posts of a person that I follow or that has a public profile.
Or maybe, if it's easier, the posts related to a certain hashtag, pointing this kind of URL: https://www.linkedin.com/feed/hashtag/crypto/
Thank you 😊

Sure, it's related to #25 , you can create a template like this and I can do the rest of the work :smile: , thank you for collaborating.

Thanks man, I'm gonna look into it in my free time :)
I'll let you know

Closing due to lack of feedback


Support GHC 8.8

This is blocked on:

[x] https://github.com/timbod7/haskell-chart/pull/186

BTW is this the right repo at all?
https://github.com/bgamari/criterion-compare/blob/2f869b1375bae2192c502b753080aeeb3c5a560d/criterion-compare.cabal#L38-L40
says otherwise…

Thanks for your comments @phadej! I updated the bounds. The diagrams ecosystem still needs updating so I've tried building with --allow-newer. cassava failed to build then:
Building library for cassava-<IP_ADDRESS>..

src/Data/Csv/Conversion.hs:26:3: error:
     error: #error **INVARIANT BROKEN** Detected invalid combination of `text-short` and `bytestring` versions. Please verify the `pre-bytestring-0.10-4` flag-logic in the .cabal file wasn't elided.
     # error **INVARIANT BROKEN** Detected invalid combination of `text-short` and `bytestring` versions. Please verify the `pre-bytestring-0.10-4` flag-logic in the .cabal file wasn't elided.
       ^
   |
26 | # error **INVARIANT BROKEN** Detected invalid combination of `text-short` and `bytestring` versions. Please verify the `pre-bytestring-0.10-4` flag-logic in the .cabal file wasn't elided.
   |   ^

src/Data/Csv/Conversion.hs:100:0: error:
     warning: "MIN_VERSION_text_short" is not defined [-Wundef]
     #if MIN_VERSION_text_short(0,1,0)
     ^
    |
100 | #if MIN_VERSION_text_short(0,1,0)
    | ^

src/Data/Csv/Conversion.hs:100:0: error:
     error: missing binary operator before token "("
    |
100 | #if MIN_VERSION_text_short(0,1,0)
    | ^

src/Data/Csv/Conversion.hs:1031:0: error:
     warning: "MIN_VERSION_text_short" is not defined [-Wundef]
     #if MIN_VERSION_text_short(0,1,0)
     ^
     |
1031 | #if MIN_VERSION_text_short(0,1,0)
     | ^

src/Data/Csv/Conversion.hs:1031:0: error:
     error: missing binary operator before token "("
     |
1031 | #if MIN_VERSION_text_short(0,1,0)
     | ^

src/Data/Csv/Conversion.hs:1:1: error:
    `cc' failed in phase `C pre-processor'. (Exit code: 1)
  |
1 | {-# LANGUAGE
  | ^

Not sure what that's about…

don't use blunt --allow-newer. Use more specific --allow-newer=base or better --allow-newer=diagrams-lib:base. If you relax all bounds, it's unlikely anything will work.

Use more specific --allow-newer=base

Thanks, that worked! I somehow hadn't been aware of this syntax – it's great! :)


#184752110 user can search a product

What does this PR do?
Description of Task to be completed?
user can search a product by name, price or by category
How should this be manually tested?
-Clone the repository using git clone link
-Install node packages that the application depends on: npm install
-Create a .env file in the root directory and add all environment variables required to run the application. The required variables are listed in the .env.example file available in root directory of the application.
-Start the application development server: npm run dev

standard user can search product by name, price or category                                                                                - seller user can search product by name, price or category                                                                                - admin user can search product by name, price or category

Any background context you want to provide?

standard user can search product by name, price or category                                                                                - seller user can search product by name, price or category                                                                                - admin user can search product by name, price or category

What are the relevant pivotal tracker/Trello stories?

#184752110:

Great job searching for products from different points.


introduce library-friendly kafka config

Providing filepaths is not convenient when one wants to use kminion as a library and already have the certs in memory.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@weeco an alternative approach I like after sleeping on this would be to have both filepaths and bytes inside the same tls_config and using validation to prevent both being set... let me know what you like more

🤦♀


Number Input component bug

Detailed description

Describe in detail the issue you're having.

Facing UI issue with NumberInput component. We upgraded the package to   "version": "9.57.0", to meet PUP. And now we see: up & down arrows are not properly aligned with the field box.

Is this a feature request (new component, new icon), a bug, or a general issue?

General issue/Bug.

Is this issue related to a specific component?

Yes, NumberInput component.

What did you expect to happen? What happened instead? What would you like to see changed?

We like to see arrows properly aligned with field.

What browser are you working in?

Mozilla and Chrome.

What version of the Carbon Design System are you using?

9.57.0

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

We are releasing our F5 micro-service by 12/5/2018.

Steps to reproduce the issue

No steps.

Additional information

Screenshots:

On Mozilla:

On Chrome:

Hey @vidhi11 you can quickly fix this by using hideLabel prop in NumberInput component, I still think this is a bug though and I will work on a PR for it.

@lekterable yes, hideLabel prop did fix this. Thanks for quick fix.


No .gem file published with release 14.0.0

We recently tried to install the current latest version of this gem (14.0.0) in our project.
It appears that this release is incomplete, as our app's deployment was unable to vendor the gem correctly - resulting in the following error when attempting to load the gem:
LoadError: cannot load such file -- /app/vendor/bundle/ruby/2.7.0/gems/google-ads-googleads-14.0.0/lib/google/ads/google_ads.rb

Peculiarly, you will see that the .gem file is not included in release 14.0.0, whereas it is included in previous releases (eg: 13.0.0).
Rolling back the gem to versions prior to 14.0.0 has fixed this issue for us - so the issue does seem to be isolated to just this version.

I confirm, this is also broken in Docker.
cannot load such file -- google/ads/google_ads
Version 13 works.

The v14.0.0 release has been updated to include the gem.
RubyGems and bundler is the recommend way to install the gem.

Faceing the same issue with v15.0.0 (https://rubygems.org/gems/google-ads-googleads)
Any fixes for this?
require "google/ads/google_ads" Traceback (most recent call last):         2: from (irb):1         1: from (irb):2:in rescue in irb_binding'
LoadError (cannot load such file -- google/ads/google_ads)`

The gem is attached to the GitHub release and is uploaded to RubyGems so it must be some issue with how you're installing it on your side.
We recommend using bundler, which would pull automatically from RubyGems once you get it set up.

@mcloonan
On further digging figured out, it's a permission issue. The main file doesn't have the required executable permission, and hence there is an error when it's being required. I am using bundler for installing the gem, but seems like it's not setting the right permissions.
ls -la vendor/bundle/ruby/2.7.0/gems/google-ads-googleads-15.0.0/lib/google/ads/google_ads/google_ads_client.rb
-rw-r----- 1 root root 9665 Dec 29 14:40 vendor/bundle/ruby/2.7.0/gems/google-ads-googleads-15.0.0/lib/google/ads/google_ads/google_ads_client.rb

Manually setting these permissions fixes the issue, but this isn't the ideal way.
The same issue has been reported with another gem - https://github.com/googleads/google-api-ads-ruby/issues/89

@mcloonan On further digging figured out, it's a permission issue. The main file doesn't have the required executable permission, and hence there is an error when it's being required. I am using bundler for installing the gem, but seems like it's not setting the right permissions.
ls -la vendor/bundle/ruby/2.7.0/gems/google-ads-googleads-15.0.0/lib/google/ads/google_ads/google_ads_client.rb
-rw-r----- 1 root root 9665 Dec 29 14:40 vendor/bundle/ruby/2.7.0/gems/google-ads-googleads-15.0.0/lib/google/ads/google_ads/google_ads_client.rb

Manually setting these permissions fixes the issue, but this isn't the ideal way. The same issue has been reported with another gem - googleads/google-api-ads-ruby#89

To correct - there are no read permissions which have to be explicitly defined after installing the gem

Thanks for the extra info. We'll take a look at this.

Please give v16.0.0 a try. Read permissions are now added when building the gem.

Closing for now. Please re-open if there are any further permission issues.


Prefer mapping annotations on Target instead of Source

My use-case is that I need to translate our core entities to many api versions.  Building annotations on the source doesn't facilitate this.  They need to be on the target.  For now, I will lazily process custom annotations on my target dtos into dozer api configuration.  Would prefer that you support annotations on target in future.  Thanks!

@sfrancolla ; is this still an issue?

This was four years ago. I built a work-around at the time. I don't code much anymore.
If I remember correctly, the work-around was to build a pretty low-level filter or interceptor in Spring to analyze the url and dynamically set the mapping on each request right before the Dozer mapping. Since the three possible target DTOs essentially mirror the signature of the source entity but with varying scope of desired methods to be serialized, it all just worked.
It was a complex bit of code but solid once it was complete.


PXSHM: use external information instead of +nodesize runtime argument

Original issue: https://charm.cs.illinois.edu/redmine/issues/420

No body.

Original date: 2014-03-03 17:26:18

pxshm needs to be debugged before we can make it a default, or integrate it with smp.  My explorations have revealed the following issues:

net-linux-x86_64-pxshm builds (--with-production) hang in megatest when run with +nodesize 4, on newer platforms (like prudence and my charmworks laptop).  Runs fine on older machines like intellect.
netlrts never absorbed pxshm properly.  Currently netlrts-pxshm fails to compile.
The definitions for the fence operations are weird (looks like cross pollination poisoning from xpmem implementation) in that they aren't consistent with the definitions in machine-smp.c by taking two parameters that are always set to 0.

in a pxshm-smp build you can just nuke the definitions in machine-pxshm.c to rely on smp, but megatest will hang even if nodesize is unset, so more work remains to achieve compatibility.

If you enable PXSHM_LOCK and add -lpthread to replace those highly suspect fence operations the bug goes away.  Locking seems to perform about as well as the fence scehem for pingpong on newer platforms, not sure about older platforms.  Haven't studied other benchmarks.

Need to unweird the pxshm fence implementation and analyze it for its correctness failing.
I'm inclined to switch to locking to future proof the implementation against the idiosyncracies of architecture specific fence semantics, but the situation requires more study.

Original date: 2015-04-14 20:59:40

A few notes since the last updates:

As discussed in a core meeting recently, the fix for this should be much easier to add in charmrun or other machine-layer startup code that knows and uses the rank-node mapping than later on. I've CC'ed Ralf because he's been working on charmrun a fair bit lately, and adding a "ranks on this host" count should be pretty easy.
netlrts-darwin-x86_64-pxshm seems to compile and run just fine, with small changes to remove 'inline' declarations on some functions that might be clang quirks.

Original date: 2015-04-30 18:25:35

Ralf has this working for net & netlrts via charmrun, and so verbs will be straightforward as well.
GNI needs an implementation, which should be a matter of munging the right data from PMI.
MPI is probably irrelevant, since when we're running on MPI, it should take care of communicating efficiently between processes, by whatever mechanism. The only instance of mpi-*/conv-mach-pxshm I see is on mpi-darwin-x86_64 that was copied from net-darwin-x86_64. I'll delete that.

Original date: 2015-05-13 18:23:41

All but the GNI implementation have been tested and merged.


Copilot - No message is shown when trying to add the owner as copilot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Login to an Expensifail account
Go to settings > security > add Copilot
Write the email you used to login

Expected Result:
You can not add your own email as a Copilot message is shown
Actual Result:
No message is shown when trying to add the owner as copilot
Workaround:
Unknown
Platforms:

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/57e71ffe-6fd4-4aa6-a0ed-03218a568d86

View all open jobs on GitHub

@youssef-lr @joekaufmanexpensify not a blocker.
this is behind a beta. kindly assign me because I'm working on copilot project

Sounds good! LMK if there's anything I can do to help.

@rushatgabhane correct me if I'm wrong here but I don't think we need to hire anyone for this issue, is that right?

correct, this will be handled as part of the copilot project by @rushatgabhane

Sounds good. TY!

@rushatgabhane is there an ETA for a PR here?

PR in review


Uncaught TypeError: this.items[a].remove is not a function

Calling destroy() on a Glide instance results in Uncaught TypeError: this.items[a].remove is not a function

There isn't any problems with .destroy() api method inside examples/destroy.html.
Could you tell more about where this issue appears?

I'm using Glide.js in an Ember app where I've built out a component around the library. The issue that I'm running into is that Ember has extended JS object and array prototypes, so when you use a for-in loop to iterate over the items and call .remove() over each one of them, it's also doing it on other properties (including ones that don't have a .remove method.
The gist of my error is in this StackOverflow thread: http://stackoverflow.com/questions/500504/why-is-using-for-in-with-array-iteration-such-a-bad-idea
// Somewhere deep in your JavaScript library...
Array.prototype.foo = 1;

// Now you have no idea what the below code will do.
var a = [1,2,3,4,5];
for (var x in a){
    // Now foo is a part of EVERY array and
    // will show up here as a value of 'x'.
}

Good. Thanks.