return internal error code, if failed

Description
in case mbedtls_aes_crypt_ecb failed, return an error from other modes
calling it
Resolves #1092
Status
READY
Requires Backporting
Yes
Which branch?
mbedtls-2.1
mbedtls-1.3
Migrations
NO
Todos

[ ] Tests
[ ] Documentation
[x] Changelog updated
[ ] Backported

Hi @andresag01 @hanno-arm Thank you for your comments. I agree we should change other files as well

Hi @andresag01 @hanno-arm I modified according to your comments
Note that there are still locations where we don't check ther return code:
> grep -rIn "mbedtls_aes_crypt_\(ecb\|cbc\|ctr\)" ./library/*
./library/aes.c:1308:                mbedtls_aes_crypt_ecb( &ctx, v, buf, buf );
./library/aes.c:1324:                mbedtls_aes_crypt_ecb( &ctx, v, buf, buf );
./library/aes.c:1365:                mbedtls_aes_crypt_cbc( &ctx, v, 16, iv, buf, buf );
./library/aes.c:1384:                mbedtls_aes_crypt_cbc( &ctx, v, 16, iv, buf, buf );
./library/aes.c:1489:            mbedtls_aes_crypt_ctr( &ctx, len, &offset, nonce_counter, stream_block,
./library/aes.c:1506:            mbedtls_aes_crypt_ctr( &ctx, len, &offset, nonce_counter, stream_block,
./library/pem.c:195:    mbedtls_aes_crypt_cbc( &aes_ctx, MBEDTLS_AES_DECRYPT, buflen,

In aes.c these are in the selftest, which is already addressed in #964 and I prefer to avoid the conflicts
In pem.c , the call is in static void pem_aes_decrypt() , which we may consider changing its return value as well, but I think this should be done in a different PR

I fixed the ChangeLog
@andresag01 @hanno-arm please approve

@RonEld: Now that I recall, the return value for the PEM functions has been fixed in a separate PR. Please refer to https://github.com/ARMmbed/mbedtls/pull/828

@andresag01 I addressed your comments. Please approve

@andresag01 Thanks for your comments. I missed that part.
Please review

I have added brackets as your comment.
Please approve

Hi @hanno-arm I fixed according to your comment
Please review

@RonEld - Could you please rebase to remove the conflicts? We'll then need to arrange approvals again.

@sbutcher-arm I have rebased and fixed errors after rebase
@andresag01 @hanno-arm Please review

@andresag01 I have addressed your comments, please review

@sbutcher-arm I addressed your comments
cc @andresag01

I have rebased to add all the new features that enhanced AES, such as OFB

After rebase, there isn't any new calls to mbedtls_aes_crypt_ecb() without checking return code.
cc @Patater

@Patater I addressed your comment

@andresag01 I believe I addressed your comments.
Please review

@Patater I addressed your comments

@andresag01 - Can you please re-review this?

@Patater I optimized the code according to https://github.com/ARMmbed/mbedtls/pull/1096#discussion_r222622800
I also changed the return value to 0 in ctr_drbg to ake it clearer.
In addition, I modified the xts code as it was introduced after the original PR was written. Please look carefully at the xts code, as I am not entirely sure about it, specifically in the leftover part,

@Patater I addressed your comments

@RonEld - I'm afraid the PR needs rework. Could you please rebase it?

Almost ready for merge, just waiting for the 2.7 backport to be approved.

Both backports have been fully reviewed and approved, so removing the "needs backports" label"
cc @Patater

Unfortunately, there are now merge conflicts. I think I independently rediscovered the issue in ctr_drbg. The aes part is still relevant.

Superseded by https://github.com/ARMmbed/mbedtls/pull/4760 for the AES result checks.
Tracked internally for the missing zeroizations.
Already done independently for the CTR_DRBG fixes.


[SPARK-6219] [Build] Check that Python code compiles

This PR expands the Python lint checks so that they check for obvious compilation errors in our Python code.
This PR also bumps up the version of pep8. It ignores new types of checks introduced by that version bump while fixing problems missed by the older version of pep8 we were using.

Test build #28375 has started for   PR 4941 at commit 75e31d8.

This patch merges cleanly.

cc @JoshRosen @davies

Test build #28375 has finished for   PR 4941 at commit 75e31d8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28375/
Test PASSed.

LGTM.  I'm going to let Jenkins retest this again and will merge once tests pass.

Jenkins, retest this please.

Test build #28880 has started for   PR 4941 at commit 75e31d8.

This patch merges cleanly.

LGTM

Test build #28880 has finished for   PR 4941 at commit 75e31d8.

This patch passes all tests.

This patch merges cleanly.

This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28880/
Test PASSed.


is there a way to mark post as draft

thank you for the wonderful theme. I am trying it out for a new blog i am trying to put up. I was wondering if there is way to mark post as draft?
Also is there a way to have a minimized repo? e.g. i think docs folder has everything that is required to run the blog, but we need to keep the full repo to be able to run npm docs:build
please pardon my knowledge of nodejs, vuejs and vuepress. i have very basic idea of how these work.
Many thanks

I also had this need, and what I did was to create a private repo for my drafts. From there you can elaborate any kind of strategy to push these to the actual production content.

I also had this need, and what I did was to create a private repo for my drafts. From there you can elaborate any kind of strategy to push these to the actual production content.


Redundant login and password reading from vault

The login and password for instagram are read from the vault even when there is a session and it is possible to log in with it

done https://github.com/obervinov/pyinstabot-downloader/pull/7/commits/05924241321d197e7be0d11c1b7caa6e04a7f3cc


First PR! (includes an ERD)

Added a very simple ERD.
The project is going to be fairly simple to start - a user will add a transaction that has a type (high level - groceries, eating out, housing), and also a location in the case we want to query how many times we ate at Chipotle in a given time period. The transaction will also have the date to allow for time queries.

Love being able to geotag the location. Would be really cool to visualize
spending on a map to see trends and rank businesses 👍. Is Yelp's API
easier than Google's?
On Mon, Jun 5, 2017 at 12:27 PM, Delaine Wendling<EMAIL_ADDRESS>wrote:

@delainewendling commented on this pull request.
What do you think of using an API (like Yelp) to allow users to add a
location to the transaction. For example, if the user is adding a
transaction they could be given an input box to type in where the
transaction took place. As they are typing, results from the API would show
up that match the characters they have typed so far. They would select an
option from the options that show up. Then, once the location is selected
we can capture the text and/or yelp id. If we do not already have that
location saved in the transaction location table we can add it. You may
have already thought of that, just wanted to throw it out there!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/delainewendling/budget-tracker/pull/1#pullrequestreview-42103018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM3JiLcDY57dWhbz_9deVhnTHNingzWWks5sBDptgaJpZM4NwJxe
.

--
Kyle Ducharme
m.<PHONE_NUMBER>
w. kyleducharme.com
p. dribbble.com/kducharme

while I think it would be cool, I am not sure how useful that info would be. Maybe I am completely missing the boat on this one, though!

HA I literally used the exact same example with Meg about chipotle
differences
On Wed, Jun 7, 2017 at 4:30 PM, Delaine Wendling<EMAIL_ADDRESS>wrote:

@delainewendling commented on this pull request.
Oh I like the geotagging ability. I haven't used Yelp's API so I'm not
sure. I think it would be useful so that we don't depend on the user to
type in the location. Hopefully this avoids having Chipotle, chipotle,
Chipolte, etc as different locations in the database.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/delainewendling/budget-tracker/pull/1#pullrequestreview-42740295,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM3JiFJQ_VsD-XxbETmwfPbqOXioK2Mwks5sBxZugaJpZM4NwJxe
.

--
Kyle Ducharme
m.<PHONE_NUMBER>
w. kyleducharme.com
p. dribbble.com/kducharme


Unable to increase video quality

Can someone help me with it, video quality is very low &  file size is low (< 250 kb)
Here is my code
  const file = fs.createWriteStream(`./videos/vid-${new Date().getMilliseconds()}.webm`);
  const browser = await launch({
    executablePath: "C:/Program Files/Google/Chrome/Application/chrome.exe",
    args: ["--autoplay-policy=no-user-gesture-required"],
    defaultViewport: {
      width: 1536,
      height: 703,
    },
    headless: "new",
  });

  const page = await browser.newPage();
  await page.goto("http://localhost:3000?capture=true");
  const stream = await getStream(page, {
    audio: true,
    video: true,
    // bitsPerSecond: 100000000,
    videoConstraints: {
      mandatory: {
        width: 1536,
        height: 703,
        frameRate: 60,
        facingMode: "environment",
        advanced: [{ width: 1920, height: 1280 }, { aspectRatio: 1.333 }],
      },
    },
  });
  const element = await page.waitForSelector(".playBtn");

  element?.click();
  stream.pipe(file);
  setTimeout(async () => {
    await stream.destroy();
    file.close();
    console.log("finished");

    await browser.close();
    (await wss).close();
  }, 1000 * 10);
}

Same problem.
Is this a bug or somewhere setting problem?

Same issue, Anyone have any fixes ?

Try passing your constraints directly in video rather than videoConstraints. Just like in getUserMedia (which this ultimately uses).


Issue with k8s.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/

The GPG key has been unavailable for at least 24 hours.
curl -I https://packages.cloud.google.com/apt/doc/apt-key.gpg
% curl -I https://packages.cloud.google.com/apt/doc/apt-key.gpg
HTTP/1.1 500 Internal Server Error
Content-Length: 1461
Content-Security-Policy: object-src 'none'; script-src 'nonce-DroCm2g3TsMSkVfOUAWziJSwzxU=' 'unsafe-inline'; base-uri 'none'; report-uri https://csp.withgoogle.com/csp/rapture/
Content-Type: text/html; charset=utf-8
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0
Date: Tue, 30 Jun 2020 15:07:52 GMT
Alt-Svc: h3-27=":443"; ma=2592000,h3-25=":443"; ma=2592000,h3-T050=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"

possibly related to?
https://github.com/kubernetes/release/issues/1007
please comment on that ticket.
/sig release
this is not a k/webiste, problem so if the key is completely gone just open a new ticket in k/release.

/close


Move period inside quotations in managing-your-personal-access-tokens#personal-access-tokens-classic

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#personal-access-tokens-classic
What part(s) of the article would you like to see updated?

...see "Endpoints available for fine-grained personal access tokens".

Move period inside quotation marks to maintain consistency with other docs (and style guide)
Additional information
No response

Hey @nguyenalex836, created the PR linked above which should close the issue, let me know if you have any feedback! :)


Document how to use Kueue for Deployments

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Documents how to use Kueue for Deployments
Which issue(s) this PR fixes:

Fixes #2677
Special notes for your reviewer:
https://deploy-preview-2698--kubernetes-sigs-kueue.netlify.app/docs/tasks/run/deployment/
Does this PR introduce a user-facing change?

Documentation on how to use Kueue for Deployments is added

cc @tenzen-y @dgrove-oss
for other pairs of eyes, I believe this is just the beginning of the "serving" support in Kueue, so some rough edges might be polished in follow up PRs.

I think we can merge as are comments are addressed. We can follow up with improvements later.
/lgtm

Thanks!
/cherry-pick website


fixes yammer messaging. closes #2557

There were two problems:

you have to specify an additional parameter to the body when using the new Yammer. The company feed is read only and the api can't post a message there anymore
we passed the "body" parameter to specify a body in the payload. For a reason this is no more valid and we have to use the "data" parameter instead

Just as a side note:
I took the latest version of the CLI. I do not have a 100% coverage on my Win 10 machine and an error in a CLI test

As for the issue with testing, I wonder if it's not related to your local settings that create different assumptions than what the tests have been built with.

You are right regarding the local settings. This might be the problem

Merged manually. Thank you! 👏


feat: trufflehog workgflow added

Description
trufflehog workflow added to as per https://eclipse-tractusx.github.io/docs/release/trg-8/trg-8-03
Why
To comply with https://eclipse-tractusx.github.io/docs/release/trg-8/trg-8-03
Issue Link
#105
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[ ] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[X] Copyright and license header are present on all affected files

The build is failing because the real did:web is currently down and not resolving. I've opened an issue for this matter. We can close this task and open an issue for the same.

Merging this PR as a failing test is not related to these changes and issue created in a respective project


Inconsistent router states when navigating during any Page Activation.

Updated version of https://github.com/aurelia/framework/issues/276
I've tested this on a Mac - Firefox and Chrome.
Having subscribed to the  aurelia-router events router:navigation:processing router:navigation:success and router:navigation:complete, and listening to it's states i understood that the flow into a Route goes like this.
RouterProcessing -> Page canActivate -> Page activate -> RouterSuccess -> RouterComplete.-> Page canDeactivate -> Page deactivate -> RouterProcessing -> SecondPage canActivate ... and so on.
Every event from the router receives a Param with the fragment that is in progress or completed except when pressing the back button in the browser during a delayed Promise in the canActivate of some page, in this case, there's no processing listed in the router events to the returning page, the returning page does show up though and the activation steps of it do happen, the Router events finish with a router:navigation:complete giving a fragment of the first page as parameter, not the one i returned to, and displaying the correct page.
Here i list the states i'm experiencing in both scenarios, the second showing the router avoiding the processing of the back flow, (both pages are plain pages).
Normal Flow - (Starting in Page0 and navigating to Page1)
Router:: routerProcessing fragment /page1
Page0:: canDeactivate
Page1:: canActivate? takes 3 sec
Page0:: deactivate
Page1:: activate
Router:: routerSuccess fragment /page1 Router.History.Fragment /page1
Router:: Complete fragment /page1
(pressed back in the browser to page0)
Router:: routerProcessing fragment /page0
Page1:: canDeactivate
Page0:: canActivate
Page1:: deactivate
Page0:: activate
Router:: routerSuccess fragment /page0 Router.Historty.Fragment /page0
Router:: Complete fragment /page0
Page0 displays
Inconsistent Flow - (Starting in Page0 and navigating to Page1)
Router::  routerProcessing fragment /page1
Page0::  canDeactivate?
Page1::  canActivate? takes 3 sec (pressed back in the browser to page0)
Page0::  deactivate
Page1::  activate
Page1::  canDeactivate
Page0:   canActivate
Page1::  deactivate
Page0:   activate
Router:: routerSuccess fragment /page1 Router.History.Fragment /page0
Router:: Complete fragment /page1
Page0 displays

@bryanrsmith any comments on this case?

I think this is the same issue as #177, but I haven't had time to look at it.

Closing as duplicate.


Add cuSPARSELt v0.2.0

https://docs.nvidia.com/cuda/cusparselt/release_notes.html#cusparselt-v0-2-0

I'll add the support for aarch64+CUDA 11 when working on this.


Cannot retreive the list of specimens wihtout identifiers

Steps to reproduce the bug
Cannot retreive the list of specimens wihtout identifiers

https://sfg.taxonworks.org/tasks/collection_objects/filter?per=500&page=1&identifiers=false

Screenshot

Expected behavior
No response
Additional Screenshots
No response
Environment
Production
Sandbox Used
No response
Version
No response
Browser Used
chrome

Right, we hit this earlier.  This is because all CollectionObjects now have GUIDs (ugh).
We'll refine the query to be "No CatalogNumber", or allow the user to choose the type of identifier.


No way to re-enable Auto-Completion items documentation.

There was a box that came out next to the auto-completion list, showing the documentation of the item you had selected.

I just pressed the X button in the corner, and it disappeared, ok, but I can't make it appear again, It's for every extension and language. I can't find any setting to change it, I tried a lot of settings, and also, reinstalled VSCode erasing user data, there is no way to get it back.

VSCode Version: 1.46.1
OS Version: Windows 10

Steps to Reproduce:

Close the Documentation box by clicking the X symbol at the corner.

Does this issue occur when all extensions are disabled?: Yes

Finally found how to fix it, it was not a bug, but it has to be more intuitive, and it seemed strange to me that deleting all the VSCode files it remained the same.


Icon request: Roblox

URL of the site or app (required): https://www.roblox.com/
Logo resources for the icon (optional, but recommended):

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/Roblox.svg
❓ How to add icon(s) to Aegis?


Scrollbars appearing when using select inside a accordion

Hi all,
I'm using the following code:
<kor-accordion label="Add Command" expanded>
  <kor-input label="position" type="select" [value]="position" (value-changed)="position = $event.target.value">
    <kor-menu-item label="creation/name"></kor-menu-item>
    <kor-menu-item label="creation/entities/a/name"></kor-menu-item>
    <kor-menu-item label="creation/screens/a/name"></kor-menu-item>
    <kor-menu-item label="creation/entities/b/name"></kor-menu-item>
    <kor-menu-item label="creation/screens/b/name"></kor-menu-item>
  </kor-input>
  <kor-input label="value" [value]="value" (value-changed)="value = $event.target.value"></kor-input>
  <kor-button slot="footer" label="Add" (click)="addCommand($event)"></kor-button>
</kor-accordion>

and when the select is closed, it all looks fine:

However, if I open the select, it expands beyond the accordion that creates scrollbars.... Not very nice.

I guess the selection list should be above the rest.

@gcollin I was able to reproduce and just pushed a fix in release 1.0.10, please take a look and let me know if anything is still not as expected


Update the doc of adding AAD B2C

Fixes #388

@michaelqi793 I'm closing this and recreating it in the internal repo at MicrosoftDocs/azure-dev-docs-pr#1861. Please use the internal repo for future PRs so we can get additional validation and previews. Thanks!


266 - Strategic AI Priorities

This is the first pass of strategic AI priorities.
As written, the AI will choose 2-4 strategic priorities every 15-24 turns, out of a possible 3 types that have been implemented (in practice, this means it will never choose 4).  For details on the concept, see the extensive comments included in this branch, or this Wiki page.
The design is meant to be extensible, with a common interface for StrategicPriority implementations, and PriorityAggregator standing in as a class that in the future would find all registered StrategicPriority implementations and make them available to StrategicPriorityArbitrator, which uses the common interface to allow AI players to select their priorities.
Future work will also be required to persist strategic priorities in saves.  See my "Discussions" post about Newtonsoft as a JSON API that will get us that feature with no per-implementation work.  I think that is the best bang-for-our-buck given that writing custom converters would tax our most in-demand resource (coding) a fair amount, and the only significant tradeoff is that Newtonsoft is not as fast as Microsoft's built-in version.
Finally, note that right now all the priorities are used for is printing out to the console information about which one is chosen.  I plan to start using them in my next change set, about the AI choosing what to build in its cities in a more dynamic, informed fashion.
Closes #266

It's been 16 days, so I resolved the conflicts with Development, did a self-review, and am going to merge.  I have too much stuff in progress and want to rebase my latest changes, which will be easier if Development is current.


Update LICENSE

Kindly claim the Issue before sending the Pull Request. Else PR won't be merged. Just go to Issues and comment claimed before anyone else.

Good work @SomeNerdNamedSteve . Welcome to the Open-Source community.


New boto3 client usage in 2.7.6 throws error

After updating Luigi to 2.7.6 my tasks that use the luigi.contrib.s3 module crash with a failing call to boto3. Looking at the release notes I found that the release included the switch from the old botocore to boto3 client.
I updated boto3 and botocore to latest version but still got the following error
Traceback (most recent call last):
  File "/opt/conda/lib/python3.6/site-packages/luigi/contrib/s3.py", line 157, in s3
    **options)
  File "/opt/conda/lib/python3.6/site-packages/boto3/__init__.py", line 100, in resource
    return _get_default_session().resource(*args, **kwargs)
TypeError: resource() got an unexpected keyword argument 'host'

Apparently boto3 removed the deprecated "host" parameter in some of the newer releases and hence the error. Is there a missing dependency link for the specific boto3 version or is my environment just misconfigured?
For now downgrading to Luigi 2.7.5 solved my problems.
Thanks :)

Thanks for reporting @robin-weiss-sm
I'm not familiar with boto2's host kwarg. Is this a boto3 improvement you'd like to PR? It would be a much appreciated patch :)

I had the same problem, and I think its not an environment error but rather the code error.
Removing the host kwarg from
s3.S3Client()
made the codes work for me.

@HyunTruth Boto3 is expected to have some conflicts with Boto(2) kwargs.
While I did not use the boto kwarg host, I know there must be a boto3 alternative. For now, we may need to include host in the deprecated args checker

@dlstadther Okay, I'll try to look through the boto3 alternative of kwargs. If not found, then I'll at least try to PR this issue for deprecated_args_checker

@dlstadther The most recent version of botocore seems to use region_name for kwarg instead of host. I'll elaborate further on it

Thanks for investigating, @HyunTruth ! Feel free to PR anything you may find helpful in resolving this and providing guidance to others who encounter this issue :)

@dlstadther added s3client check for deprecated host keyword and raise error with the details #2493 PR to address this issue

Resolved by #2493


tone up

"Now, the specifics of the next part are not really relevant. However, they can show you how easy it can be to deal with data in R, so follow along if you want to."  in https://nickhaf.github.io/r_tutorial/qmd/getting_started/the_big_picture.html#some-additional-summary-statistics
I wouldn't say it's not relevant or tone this part down by saying 'if you want to' - it is very useful ?

'so download it from here in case you want to follow along.'
in https://nickhaf.github.io/r_tutorial/qmd/getting_started/the_big_picture.html#load-data
I would say 'to follow along' instead

'As already mentioned, the specifics of these functions are not really relevant for now,' in https://nickhaf.github.io/r_tutorial/qmd/getting_started/the_big_picture.html#some-additional-summary-statistics
I'm not sure what you mean by 'the specifics'
do you mean to say 'At the moment we only want to get an idea what R can do, we will go into the details of these functions if following parts of the tutorial' ? or something like that?

'also plot it in the end, if you follow the whole workshop.' in https://nickhaf.github.io/r_tutorial/qmd/getting_started/data_sets.html
do we offer different points of entries or do they have to go through it linearly as this build ups on each other? are the sections independents? if not, then I would remove '  if you follow the whole workshop '


Merge readthedoc website into wiki

Copy everything from Turing's readthedoc website to wiki
Disable/delete read the Turing's readthedoc website.

Closed by https://github.com/yebai/Turing.jl/pull/321 (remove doc folder) and https://github.com/yebai/Turing.jl/commit/d4707f342c644028781d4daa216aa63f04a83643 (remove doc badge)

@xukai92  Could we also disable/delete the website - http://turingjl.readthedocs.io/


Option to disable ssl_verify_peer

This allows the user to set ssl_verify_peer to false.
This can be required when running with a self signed cert

Failed due to:
spec/docker_spec.rb:101  Line is >80 characters (86)
Perhaps an idea to exclude spec files?

@tlunter could you take a look at this if you have the time? thanks!

@electrical Sure thing.  Feel free to up --style-measure in .cane to 100.  80 feels a bit limited and that line reads fine to me. Is ssl_verify_peer set to true by default because of scheme: 'https' unless set to false explicitly?

Hi, sorry for the delay in response.
I don't validate yet if ssl is enabled first to see if ssl_verify_peer makes sense since it has no impact when ssl is not enabled.
I'll change the style-measure to 100.
Thanks!

@tlunter PR updated. If this could be merged and released it would help users with boot2docker allot using beaker. Thanks!

@electrical released in v1.21.0. thanks!

Very much appreciated :)


add nextjs template

Current dependencies on/for this PR:

main

PR #1   👈

PR #2

PR #3

PR #4

This stack of pull requests is managed by Graphite.


update golang net to 0.33 to satisfy security alerts

What type of PR is this?
/kind bug

What this PR does / why we need it:
https://pkg.go.dev/vuln/GO-2024-3333
Update golang/net
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

curious why was this not triggered by dependent bot?

/lgtm
/approve

curious why was this not triggered by dependent bot?

I don't think dependabot updates transitive dependencies. I think the real fix would be a patch in client-go.


[Compute] Add optional parameter --EdgeZone to support extended locations

Resource Provider

Compute
Description of Feature or Work Requested

Add an “--EdgeZone” parameter for below cmds
Note: the underlying ARM property is called “extended locations”, and is intended to cover several types of extended locations including EdgeZone, among others. We do not want to directly reflect this into the cmdlets (by say, having --ExtendedLocationType and --ExtendedLocationName parameters). Instead, for cmdlets reflecting resources that can be created in edge zones, we prefer to offer a simple --EdgeZone parameter (this infers the extended location type, and the value is the extended location name).
Add optional parameter --EdgeZone to the following Az.Compute cmdlets:
az vm image
az vm image list-offers
az vm image list-skus
az disk
az image create
az snapshot create
az vm create
az vmss create

Add optional parameters "--ResourceType" & "--EdgeZone":
az vm list-skus

Autocomplete support:
When --EdgeZone is used, tab completion should pull edgezones supported for the main region.
Minimum API Version Required

2020-06-01
Swagger Link

https://github.com/Azure/azure-rest-api-specs/blob/compute-2020-12/specification/compute/resource-manager/Microsoft.Compute/stable/2020-12-01/compute.json
Powershell FR: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/776
Target Date

December 2020

Compute

@viananth I noticed that the swagger change has not been merged to master branch? When will it be merged? Azure CLI can't release this until swagger change is merged to master branch.

@viananth

@viananth

@viananth I noticed that the swagger change has not been merged to master branch? When will it be merged? Azure CLI can't release this feature until swagger change is merged to master branch.

@qwordy The feature branch for the swagger change is scheduled to be merged on 12th of Jan.
https://github.com/Azure/azure-rest-api-specs/tree/compute-2020-12

@viananth I noticed that the swagger change has not been merged to master branch? When will it be merged? Azure CLI can't release this feature until swagger change is merged to master branch.

@qwordy The feature branch for the swagger change is scheduled to be merged on 12th of Jan.
https://github.com/Azure/azure-rest-api-specs/tree/compute-2020-12

az vm list-skus , swagger is not ready. Others are finished.


Expose digestmod to allow custom selection of hash function

preserving original behavior which uses hmac defaults.

Changes Unknown when pulling 30ebebab658a8178cba489f87fc7123c8ee570f2 on eyalfink:patch-1 into ** on google:master**.

I've signed it

Changes Unknown when pulling 86bb60bc8ab7dbd6a369446e2d3c07f6612a3b8f on eyalfink:patch-1 into ** on google:master**.

Please squash commits - this change is simple enough that there's no need for it to be in two commits.

Also please add test coverage.

@eyalfink friendly ping. do you still want this to be merged?
You may ignore the request to squash commits, as github has that built-in now, but we do need test coverage.

@eyalfink another friendly ping. I'll close this PR in a few days if I don't hear from you.


Bring scalar definitions into schema and allow overriding

Description
This PR removes the global scalar registry in favour of a registry per schema. It also adds a new function to the Schema get_scalar that allows you to override the built in scalars with a custom implementation.
Types of Changes

[ ] Core
[ ] Bugfix
[x] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Fixes #1028 and #1061

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release improves how we deal with custom scalars. Instead of being global
they are now scoped to the schema. This allows you to have multiple schemas in
the same project with differnet scalars.
Also you can now override the built in scalars with your own custom
implementation. Out of the box Strawberry provides you with custom scalars for
common Python types like datetime and Decimal. If you require a custom
implementation of one of these built in scalars you can how subclass the
Schema class and override the get_scalar function to return your own custom
implementation:
from datetime import datetime, timezone
import strawberry

EpocDateTime = strawberry.scalar(
    datetime,
    serialize=lambda value: int(value.timestamp()),
    parse_value=lambda value: datetime.fromtimestamp(int(value), timezone.utc),
)

class MySchema(strawberry.Schema):
    def get_scalar(self, scalar):
        if scalar == datetime:
            return EpocDateTime
        return super().get_scalar(scalar)

@strawberry.type
class Query:
    @strawberry.field
    def current_time(self) -> datetime:
        return datetime.now()

schema = MySchema(Query)
result = schema.execute_sync("{ currentTime }")
assert result.data == {"currentTime":<PHONE_NUMBER>}

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to Jonathan Kim for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@patrick91 @BryceBeagle this PR is ready for review again.

This looks ready to go me 😊 @jkimbo can you add a TWEET.md file, or shall I do it :D

@patrick91 done!


Tag component does not have a style prop

I would expect to be able to apply styles via the style prop, like I can with the Button component

This should be fixed in v3.5.1.


Bug - Warning error when load the home page for the first time

Describe the bug
When load the home page for the first time, warning error appear in the console
To Reproduce
Steps to reproduce the behavior:

Pull the latest commit from master branch
Run npm run dev
Open http://localhost:3000 on the browser
See error in the console

Expected behavior
Warning errors should not appear
Screenshots

Can you help on this @arispati ?

I'll try it @mazipan , I'll also fix some wrong word and layout then. 🚀


countedAudience of Service

CountedAudiences for PublicationEvents and for Campaigns are static results for completed activities.
For Service, it might be different: Services are not Events (nor limited in time).
What number should be in the count? From the beginning?, the last year? per day?
And also for published on-demand content we need to count consumptions right from the beginning of the publication. I think we need a count-per-time structure to collect counts over time. Furthermore, very often the number of consumption events is calculated per time unit and per audience (eg. 15000 views of a Youtube-Video between 16:00 and 17:00 on Oct 11 in the targeted audience group of 14 to 19 year old). the count-per-time structure should therefore point to an Audience.
What do you think?

So we need to connect Audience to startDateTime and endDateTime for the counting and start and end of timecode for segments of the media published?

I don't think we need to count views of segments. And I don't think we should extend Audience with startDateTime and endDateTime. It is not the Audience that starts and ends, it's the counting of ConsumptionEvents.
How about a class "ConsumptionCount", that holds the number of consumptions from startDateTime to endDateTime and references an EditorialObject and an Audience? This would represent one data point in the measurement of the reach of an eg. a Youtube Video.

Good morning! How about instead of "ConsumptionCount", would a better name be for example "ConsumptionEvent" or "ConsumptionStatistics" --- because perhaps "Count" is not all statistics and information we want to collect from the Consumption, but much more?

I am not opposed to the term ConsumptionStatistic (still prefer ConsumptionCount), but I fear that @kimviljanen's expectations on putting statistical information into the class does not match my proposal. I see the ConsumptionCount as one single data point. Very many of them exist and can be aggregated to create statistical statements. This aggregation can be performed along time (per minute, per hour, per day,  in total ...), along an Audience (14-19 year old, 20-29 year old, over 60, ...). We should not try to represent all possible statistical calculations, but flexible data points. That is why I think it is sufficient ot count the ConsumptionEvents.

I don't think we need to count views of segments. And I don't think we should extend Audience with startDateTime and endDateTime. It is not the Audience that starts and ends, it's the counting of ConsumptionEvents.
How about a class "ConsumptionCount", that holds the number of consumptions from startDateTime to endDateTime and references an EditorialObject and an Audience? This would represent one data point in the measurement of the reach of an eg. a Youtube Video.

An audience is a collection of Consumption. We have the Resonance event in the middle, and at the same time, we can divide the audience into different age groups we can divide them on time as well. An on-demand offering will have this many viers this week and this many viers that week.

An audience is a collection of Consumption.

I model this as the class "T-Audience".
I'd rather define : An audience is a group of potential consumers.
I model this as the class "J-Audience".
Compare the two options in the following (simplified) sketch:

My observations:

T-Audience:

start/end attributes bind each instance of T-Audience to one instance of PublicationEvent
every PublicationEvent requires its own T-Audience instance(s)
T-Audience repeats averageAge in every instance (although the same consumers with the same averageAge might be members of T-Audience)

J-Audience:

only ConsumptionCount refers to PublicationEvent, not J-Audience
J-Audience can be described and instantiated independently of PublicationEvents
instances of J-Audience can be reused, reflecting existing schemas of potential consumers: e.g. ARD has a „Mediennutzertypologie“, that could be represented as a list of J-Audience instances. The list can be reused in different use cases like offering development, consumption measurement etc.

I definitely prefer the J-Audience model. What do you think?

If you by T-Audience mean #213 I must regrettably so say that you have the dissanvantage to be wrong about your statements and usage of the proposed Audience class.

T-Audience:
start/end attributes bind each instance of T-Audience to one instance of PublicationEvent

No.
Firstly: The range of start and end, as the proposal, very clearly declare, is:
:start max 1 :TimelinePoint
They bind to a timeline expressed by a timecode, and this may, not must, be used to describe how the audience count changes throughout the programme. This is a relatively advanced usage, but not more advanced than Facebook and Youtube, which provide this kind of statistics for all their material.
If more course statistics are demanded, the timeline information can be omitted, and the count will be related to one or more publication events. Yes, one or more.
Secondly:
It is the
ebuccdm:hasConsumptionStatistics only ebuccdm:Audience
is the reference between the PublicationEvent and Audience, not the timeline. There are no restrictions on how many publicationEvents that can refer to the same Audience
The direction of the arrow is not significant.
Simple graph theory: Given node A and B with the edge c there will always be an inverse c' that covers the relationship between node B and C.
In this way can, the hasConsumptionStatistics be used for collecting data about more than one publication event.

every PublicationEvent requires its own T-Audience instance(s)

No, not at all. This is not what the graph model describes.

T-Audience repeats averageAge in every instance (although the same consumers with the same averageAge might be members of T-Audience)

The audience class have no averageAge. The audience class have, on the other hand, the possibility of dividing an audience into different slices on different properties such as age, gender, social standing, etc. The latter is expressed as skos concepts, like the "Mediennutzertypologie".
It seems that the ebuccdm:includesAudience only ebuccdm:Audience or the equivalent hasMemberAudience has been overlooked.
If ones have a particular statistics divided on different slices, this can be easily described with the structure ones may
build with the self relations on the audience class.

For the second group of bullet points, there are no concepts that can't be expressed by the proposal.

Can we close this issue?


Makefile: Fix Semaphore CI failing because of CRI-O tests

Because we get Semaphore CI hanging sometimes when trying to build everything from a "make localintegration" for the testing of CRI-O, this patch only calls into the test itself, without the need for rebuilding everything.

lgtm


goog.addDependency should add support for absolute roots

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=302

This issue is being closed as a preparation step before archiving the repository.  See the README for more detail.


Empty Angular 2 tab on Developer Tools tab in Chrome

Not 100% sure if this is a bug. I installed the latest build from http://rangle.github.io/batarangle-io/ (0.0.2) and tried it on a simple hello world Angular 2 app. All I am getting is an empty window as below.

I have Angular Beta.14 + webpack in development mode. Am I missing anything here?
I reloaded my app after Batarangle installation. I also noticed that the Extension's icon from Chrome is greyed out.
Thanks,

@ixsander There were some issues with build generated using CI if you download the latest one which is from http://batarangle.io/download.html?new which is batarangle-494.crx and install that you should be good.

ya. That fixed my problem. Should I just use your link going forward for new builds?
Thanks!


feat: support regex in matchers

Description
WIP

This pull request addresses the issue described here: #3366

In this pull request, I have added support for Regex text/label/testID matching in Detox.

For features/enhancements:

[x] I have added/updated the relevant references in the documentation files.

For API changes:

[x] I have made the necessary changes in the types index file.

Upon quick review, I must say that this is a masterpiece. Great work! 🙌🏼 👑
I might have some minor comments but it's quite there, I'll do another round later today / tomorrow

Upon quick review, I must say that this is a masterpiece. Great work! 🙌🏼 👑 I might have some minor comments but it's quite there, I'll do another round later today / tomorrow

@asafkorem Sounds great! Looking forward to the comments, fixing and merging! 🥳

Again, great work!! I'm super excited with this! Just a few small tweaks and we can ship it :shipit:

I've added the fixes, also modified matchers.md slightly to have a separate section on regex matching (since it is relevant for multiple matchers) and added links to it from the supported methods. 🥼

Again, great work!! I'm super excited with this! Just a few small tweaks and we can ship it :shipit:

I've added the fixes, also modified matchers.md slightly to have a separate section on regex matching (since it is relevant for multiple matchers) and added links to it from the supported methods. 🥼

GG!

Released with v20.11.0 🎉
Thanks again @andrius-girdzius!


Can you make batchexecutor.exe folder aware

Currently the --cdmFileSystem parameter is not folder aware. I cannot pass cdm/folder. Can you please make it so I can?
In my implementation I create folders with the date and runtime guid to track.
cdm/20220307T164544-d8b2bbbd-5407-4a59-9cac-c7c95bad0061
But I have to pass 'cdm' in the pipeline and let \RunAdfCustomActivity.ps1 put the cdm.json files in the root, then have Copy operations to copy/move them into the folder.

Hi Terribly,
Do you mean when you use BatchExecutor.exe to transform data, it will throw exception if cdmFileSystem container doesn't exist?
You can use use BatchExecutor.exe to generate-schema firstly, this will initialize and create the cdm folder, then to transform-data with exported FHIR ndjdon files. You can refer content in \RunAdfCustomActivity.ps1 for those 2 operations.

No, I mean that if the Azure Blob Storage location that I want the results of generate-schema to go to is cdm\20220307T164544-d8b2bbbd-5407-4a59-9cac-c7c95bad0061 it will not work currently. It is only container aware, not folder aware. Thus you can only output the results to the blob container, not a blob path.

Currently we don't have plan to support specifying folder as the target to generate CDM metadata and CDM data.
Thanks for you suggestion, will consider this in future updates.


Montagna di Marzo (entire batch)

Inscriptions from Montagna di Marzo (86 in total)
Issues:

encoding aphaeretic verb within the onomastic formula (cf. e.g. ISic020745)?
how to encode 'italic' onomastic formula (cf. e.g. ISic020745)
there are 41 records of inscriptions mentioned in publications but still unpublished (no text, just basic information)[we need to see Mussinano's archive at the Soprintendenza di Agrigento]

woo hoo!


[RFC] Image Generation Dataset

Overview
This is an RFC regarding how we should support datasets for finetuning text-conditioned image generation models.
A basic data pipeline for this would be:

Load the JSON/CSV/TSV/Parquet/LMDB/etc. file containing the image paths/urls and captions
For each pair:

load/download the image
resize the image and optionally randomly augment it (horizontal flip, etc.) and normalize it
optionally randomly augment the caption (rearrange caption parts, etc.)
tokenize the caption using the model's tokenizer

collate into a batch

At a broad level, this fits well into our current TorchTune data ecosystem (except we wouldn't use the "list of Message objects" abstraction, which would change how we interact with the model's tokenizer).
In TorchTune, a simple version would look something like this:
dataset:
    _component_: torchtune.datasets.img_caption_dataset
    path: ~/my_dataset/data.tsv
    img_transform:
        resize: [256, 256]
        center_crop: true
        horizontal_flip: 0.5
    caption_transform:
        drop: 0.05
        shuffle_parts: 0.1
tokenizer:
    _component_: torchtune.models.flux.FluxTransform
    clip_tokenizer_path: ...
    t5_tokenizer_path: ...
    t5_max_seq_len: 256

def img_caption_dataset(
    model_transform: Transform,
    *,
    path: str,
    img_transform: Config,
    caption_transform: Config,
):
    """Builder for an image caption dataset."""
    data = _load_img_text_dataset(path)
    img_transform = _build_torchvision_transforms(img_transform)
    caption_transform = _CaptionTransform(caption_transform)
    return ImgTextDataset(
        data,
        img_transform=img_transform,
        text_tranform=caption_transform,
        model_transform=model_transform,
    )

def _load_img_text_dataset(path):
    if '.' not in path:
        return datasets.load_dataset(path, ...)

    path = Path(path).expanduser().resolve()
    if path.suffix == ".tsv":
        data = []
        with open(path, "r") as f:
            for line in f:
                img_path_or_url, text = [x.strip() for x in line.split("\t")]
                data.append((img_path_or_url, text))
        return data

    elif path.suffix == "...":
        ...

def _build_torchvision_transforms(cfg):
    """
    Create a series of torchvision transforms
    (resize, crop, flip, etc.)
    """
    ...

class _CaptionTransform:
    """
    Callable that randomly augments image captions with comma-separated parts
    (shuffle parts, randomly drop entire caption, etc.)
    (or does nothing if disabled)
    """

    def __init__(self, cfg): ...

    def __call__(self, caption: str) -> str: ...

class ImgTextDataset(torch.utils.data.Dataset):
    def __init__(self, data, img_transform, text_transform, model_transform):
        self._data = data
        self._img_transform = img_transform
        self._text_transform = text_transform
        self._model_transform = model_transform

    def __len__(self):
        return len(self._data)

    def __getitem__(self, idx):
        img_path_or_url, text = self._data[idx]
        img = (
            Image.open(BytesIO(requests.get(img_path_or_url).content))
            if img_path_or_url.startswith(("http://", "https://", "ftp://", "ftps://"))
            else Image.open(img_path_or_url)
        )
        img = self._img_transform(img)
        text = self._text_transform(text)
        data_dict = self._model_transform(img, text)
        return data_dict

class FluxTransform(Transform):
    def __init__(self, clip_tokenizer_path, t5_tokenizer_path, t5_max_seq_len):
        ...

    def __call__(self, img, text):
        return {
            'img': (img / 127.5) - 1.0,
            'clip_text_tokens': self._clip_tokenizer(text),
            't5_text_tokens': self._t5_tokenizer(text),
        }

TODO: Collate
We'll need to generalize our collate functions such that they can handle data outside of the tokens-and-labels format they currently expect. I will update this section after I've looked into this.
Caching/Preprocessing
From what I've seen online, some people finetune image generators on massive datasets, but most people just finetune on very small personal datasets, often 5-100 images. So we should probably add support for various caching/preprocessing options that increase disk/mem usage in order to achieve faster iterations. Some ideas for optional configurations:

cache up to N images in each data worker so they don't have to load them fresh from disk each epoch (this probably isnt an actual bottleneck tho)
in the extreme case of like <10 images, we could even just keep the whole dataset on each GPU so we don't have to transfer them each step
in the case of a web dataset, save up to N downloaded images to local storage for the next epoch
provide a script that would run before training that preprocesses the outputs of frozen parts of the model (text tokens, image autoencoder embeddings) and saves them to disk so that we don't have to recompute every epoch

tokenization would be negligible but I bet preprocessing the Flux image encoding would save a lot of time and GPU memory
this could also be done on the fly, i.e. caching instead of preprocessing. During the first epoch, save the intermediate values to disk and reuse them in all the next epochs. But this makes the code much more complicated.

But we should evaluate whether each of these is worth it:

how much performance gain would you actually get? and under what circumstances?
how much would it complicate the code and the configs?

Dataset Creation
Should we include scripts/utilities for creating the captions?  So we could help them turn that folder into a dataset by using some model to automatically caption them. We could even provide our own models for this by distilling the image captioning capabilities of Llama3.2V-90B into several smaller Llama3.2V models, and let the user pick the one that fits on their device.
We'll also want to support adding words/phrases to the caption that tell the model to generate in the style of this dataset. For example, if I'm finetuning a model on images of myself, I'll want to include something like "a photo of cpelletier" in the caption so that the model learns to associate "cpelletier" with my face. This could be supported at the dataset creation step (i.e. the identifiers are put into the caption data itself, which is simpler), or at the text transform step (i.e. the identifier is specified in the text transform config like 'add "in the style of cpelletier" to the end of each caption', which is a bit more complex but nice that you don't have to change the dataset if you want to experiment with different identifiers).
User Experience

Regarding loading the TSV/Parquet/whatever data file, should we just rely on huggingface's load_dataset like we currently do in SFTDataset? It keeps the code simpler, but it makes the user leave torchtune and go read the huggingface docs, which is overkill if they just have some simple JSON file we could easily load ourselves.
In addition to absolute image paths in the data file, we should probably support image paths relative to the dataset folder, because it would be super annoying if you had to regenerate your data file any time to move the dataset to a new location.
There's currently some potentially unnecessary fields in the config. For example with Flux models, the model determines the image size and the T5 tokenizer sequence length. Is it better to pass this information to the image transform and model transform, respectively? Which complicates the code but lowers the chance of user error. Or is it better to have the user define these values in the dataset config and tokenizer config, respectively? Which puts the burden on the user to match what the model expects.
Should we add scripts/utilities for inspecting the dataset? It's nice to see a preview of what a batch looks like, especially when you're messing around with color jitter and other hard-to-configure image augmentations.

Other

Naming of the image-text dataset builders/classes? Maybe the more verbose image_caption_dataset_for_image_generation is better to make it clear that this is NOT for something like finetuning a VLM to do image captioning (although maybe it could be generalized to the point where it can also do lists of Message objects and therefore can be used for whatever purpose).
Support multiple captions per image? I can imagine people wanting to generate multiple captions for their images, and randomly selecting one at a time during training to prevent overfitting. It's kinda a caption augmentation but it's unique for each caption so it would have to be supported at the data level.

Saw this RFC and want to pen down some of my thoughts as I'm also building some fine-tuning pipeline for Flux.

"preprocessing the Flux image encoding would save a lot of time and GPU memory" - I assume this refer to FLUX autoencoder to encode image from pixel space to latent space. Actually FLUX autoencoder is small (compared to the rest - only 168MB in BF16) and fast, so caching it is not quite necessary.
The more problematic one is T5 embeddings. T5 encoder (xxl variant) alone is huge - 9.5GB in BF16. So T5 embedding is a good candidate for pre-computation. But the problem is T5 embedding is huge - with size (512,4096) for each prompt, it would be 4MB in BF16. It should be fine for small datasets, but not quite scalable (though SD3 paper mentions they cache all T5 embeddings :laughing:)
Regarding generate caption with an LLM, I do find that it's easier (and better quality) to just use an online service that accepts image inputs. Won't mention competitor name here :sweat_smile:, but some of them provide good free-tier with API access.
"Support multiple captions per image?" - For local datasets, we can just add extra rows (different prompts but same path to image). For streaming datasets, then yes we probably need to handle a row with multiple prompts (and 1 image).
(This will be much harder) Resolution/aspect-ratio bucketing for datasets with diverse resolution/aspect ratio. For different aspect ratios, random crop is not ideal since it can truncate important parts of an image. For different resolutions, we don't want to enlarge small images (since it will be low quality/blurry), or make large images smaller (since we lose out the ability to learn high resolution)


Write script to harvest mappings between cross-species dendrogram and species specific dendrograms

SPEC (STATUS DRAFT):

Take all cell_set_preferred_alias(es) from cross-species taxonomy.
In singles-species taxonomies, match these strings to the contents of the cell_set_aligned_alias column and if not found to one of the terms in the contents of  cell_set_additional_alias column (multiple terms in these columns are separated by a |)
Use the matches to generate a robot template generating subclassOf relationships between the cell types corresponding to each node: 'species specific' subClassOf 'cross species'

@jeremymiller - please review.   We were a bit confused when we first looked at this, but it seems like we need to use 'cell_set_additional_alias' to map leaf nodes between cross-species taxonomy and single species, aligned_alias is reserved for mappings between more abstract classes.  Is this correct?

This is correct.  Cross species "type X" term in cell_set_preferred_alias can be considered a parent of single species "type x" term found in cell_set_additional_alias.
For cell_set_aligned_aligned alias, any node in any taxonomy with that tag should be considered a child or equivalence class of the more generic aligned alias term.  For example, likely every taxonomy will have a "Glutamateric neuron" cell set, which all will be considered glutamatergic neurons (however you decide to code that).

@shawntanzk  - cherry pick some examples for mockups - using the mapping as described above.
Mockups needed for breakout on ontology review + breakout on uses - showing up as cross-species parent class in cell-type card.

For implementation of cross-species taxonomy:

Build cross species taxonomy from https://github.com/obophenotype/brain_data_standards_ontologies/blob/single_dosdp_template/src/dendrograms/nomenclature_table_CCN202002270.csv
cell_set_aligned_alias from mouse/human/marmoset should be subclass_of same name from cell_set_aligned_alias in cross-species
cell_set_preferred_alias in cross species should be matched with cell_set_additional_alias in mouse/human/marmoset, and mouse/human/marmoset should also be subclass_of same name in cross species (this might at times duplicate mappings in aligned alias)

Initial version of the cross-species ontology is at: https://github.com/obophenotype/brain_data_standards_ontologies/blob/cross_species/bdscratch-full.owl

done and looks good


Immediately closes when opening a connection

Hello there,
First kudos for this package - makes websockets much less painful in expressjs.
I'm having a bit of trouble making a connect to the socket. I start the server with:
app = require('express-ws')(express()).app;
then set up the route like so
  app.ws('/ws/route', function (ws, req) {
    console.info("connected");
    ws.on('message', function (msg) {
      ws.send(msg);
    })
  });

but testing this with
var test = new WebSocket("ws://localhost:3000/ws/route");test.onerror = function () {console.error("error");};test.onclose = function () {console.info("close");};
yields "close" in the console. Is there something obvious that I'm doing wrong?

I had this problem today, it turned out to be my catchall error handler that I included at the bottom of the app.use callback stack after the route declarations. My problem was the signature:
app.use(function(req, res, next) {

Should have been:
app.use(function(err, req, res, next) {

Actually, that's not quite right. I'm checking for req.upgrade in the 404 handler now.

Was this by any chance happening with iOS device?

Having the same issue, any fix for this?


browserstack-app-live-upload 1.0.0

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

It should be noted that this step is different from the browserstack-upload step.  browserstack-upload uses the app-automate Browserstack endpoint.
This step, browserstack-app-live-upload, uses Browserstack's app-live endpoint.

honestly I would first wait for deprecation of
https://github.com/marcelkalveram/bitrise-step-browserstack-upload
and add support for upload of both app-live and app-automate at once, allowing extra configuration as we..

@guness The app-automate api supports a lot more features than the app-live api. There isn't feature parity between the two endpoints. The endpoints have different purposes one is to run automated testing and the other is to be loaded onto devices for user testing.

@guness The app-automate api supports a lot more features than the app-live api. There isn't feature parity between the two endpoints. The endpoints have different purposes one is to run automated testing and the other is to be loaded onto devices for user testing.

Ah, I was only about app-upload part. additionally only custom_id parameter exists. you can check necessary changes:
https://github.com/marcelkalveram/bitrise-step-browserstack-upload/pull/4

am checking source code:
are you sure about
  echo "Please provide the location of your GoogleService-Info.plist"
  exit 1
fi```

also I am not sure about these escapes:
if [ -z "$apk_ipa_filepath" ]; then
  echo "Please provide the path for the IPA or APK that you wish to upload."
  echo "For IPA it is usually \$BITRISE_IPA_PATH"
  echo "For APK it is usually \$BITRISE_APK_PATH"
  exit 1
fi

@guness In answer to your two comments.

are you sure about
if [ -z "$browserstack_access_key" ]; then
  echo "Please provide the location of your GoogleService-Info.plist"
  exit 1
fi

You are correct, that is wrong. I have updated the the step.sh so that the correct echo is provided.  You can see it working as expected now in the screenshot below:

also I am not sure about these escapes:
if [ -z "$apk_ipa_filepath" ]; then
  echo "Please provide the path for the IPA or APK that you wish to upload."
  echo "For IPA it is usually \$BITRISE_IPA_PATH"
  echo "For APK it is usually \$BITRISE_APK_PATH"
  exit 1
fi

The escapes work as expected

Found the PR ok, thanks for the fixes. @trapacska pls merge.


fix(ipfs-coord): Updating to v6.6.7

:tada: This PR is included in version 1.9.0 :tada:
Your semantic-release bot :package::rocket:


You'll need to enable ASS override for it to work...
I guess I'll replace it with scale then.


Remove existing extensions/i18n/tmp directory during pre-build process

Is your suggestion related to an experience ? Please describe.
During the pre-build process of identity-apps a tmp directory is created under apps/console/src/extensions/i18n to store the final meta file after adding the extensions namespace. After this pre-build the meta file is copied from this tmp folder to console/build/resources/i18n. Currently, in the pre-build script the meta file is added to tmp directory if the directory already exists or else a new directory is created. This leads to multiple meta files being added to tmp folder and getting copied to build if i18n files change during development processes, causing issues during rendering pages in development server.
Describe the improvement
Check if the tmp folder already exists during pre-build process. If it exists delete the existing one and create a new one and then generate the meta file inside this directory. This makes sure only the latest meta file is stored inside tmp directory and gets subsequently copied to build.

Addressed with:

https://github.com/wso2/identity-apps/pull/5839


mysql query plan analyzer

closes https://github.com/staabm/phpstan-dba/issues/315

pilot PR in https://github.com/composer/packagist/pull/1304/


model training

Hello, I have reviewed your paper and code, and I feel that you have done a great job. Could you please share your training code? I would like to see the details of your model training. Thank you.

Thank you for your interest! We will release our training code soon, may be in the next 2 weeks.

感谢您的关注！我们将很快发布我们的训练代码，可能在未来 2 周内发布。

Thank you very much, I will be patient and wait.

Training code and guide have been released.


chore: update env section of bug issue template

nest under details; include backticks

I wonder if we should do the same ticks for the reproduction step, but not hidden under details.


Fix sign out button when big font used

Description:
When big font size is used sign out button is truncated.
In this case show button on next row when text doesn't fit.

QA passed


CHANGELOG

Hi!
It would be nice to have changelog that follow this http://keepachangelog.com/en/0.3.0/
Makes it easier for update/upgrade decision
Thanks

@epinault.
Indeed a good idea! +1 from me.

+1 on this

We've now merged @elenatanasoiu 's contribution, https://github.com/zendesk/zendesk_api_client_rb/pull/339


Annotating licks into bouts

segments licks into bouts based on a threshold of the interlick interval

currently ignores whether the licks are left/right
Sets the threshold as 700ms, which is simply what I used in a previous project

updates plot_session_scroller to color licks by the lick bout
updates plots to take nwb-like objects
annotates which lick triggered a reward, and whether the lick bout was a rewarded or unrewarded bout
[x] merge dependency: https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-data-utils/pull/39
[ ] merge dependency: https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-data-utils/pull/40
[x] fix import dependency issue
[x] add unit tests for new code

Add lick annotations to session scroller
from aind_dynamic_foraging_data_utils import nwb_utils as nu
from aind_dynamic_foraging_basic_analysis.plot import plot_foraging_session as pfs

nwb = nu.load_nwb_from_filename(<filepath>)
nwb.fip_df = nu.create_fib_df(nwb, tidy=True)
pfs.plot_session_scroller(nwb, plot_bouts=True)

Compute FIP PSTH aligned to rewarded and unrewarded goCues
from aind_dynamic_foraging_data_utils import nwb_utils as nu
from aind_dynamic_foraging_basic_analysis.plot import plot_fip as pf

nwb = nu.load_nwb_from_filename(<filepath>)
nwb.df_trials = nu.create_df_trials(nwb)
rewarded_go_cues = nwb.df_trials.query('reward == 1')['goCue_start_time_absolute'].values
unrewarded_go_cues = nwb.df_trials.query('reward == 0')['goCue_start_time_absolute'].values
pf.plot_fip_psth_compare_alignments(nwb, {'rewarded goCue':rewarded_go_cues,'unrewarded goCue':unrewarded_go_cues}, 'G_1_preprocessed', censor=True)

Compute FIP PSTH aligned to rewarded and unrewarded lick bout starts
from aind_dynamic_foraging_data_utils import nwb_utils as nu
from aind_dynamic_foraging_basic_analysis.licks import annotation as a
from aind_dynamic_foraging_basic_analysis.plot import plot_fip as pf

nwb = nu.load_nwb_from_filename(<filepath>)
nwb.df_licks = a.annotate_rewards(nwb)
rewarded_bout_start = nwb.df_licks.query('bout_start & bout_rewarded').timestamps.values
unrewarded_bout_start = nwb.df_licks.query('bout_start & (not bout_rewarded)').timestamps.values
pf.plot_fip_psth_compare_alignments(nwb, {'rewarded bout start':rewarded_bout_start,'unrewarded bout start':unrewarded_bout_start}, 'G_1_preprocessed', censor=True)

@rachelstephlee @hanhou This is ready for review

Compute FIP PSTH aligned to rewarded and unrewarded lick bout starts

Haven't checked the code, but a quick question: are bouts independent of trials? In other words, if there are more than one bouts in a trial, all bouts from the second on are considered as "unrewarded bouts" (red circles below)?

We may also need to align PSTH to the first bout after the go cue (essentially the "choice lick").

Compute FIP PSTH aligned to rewarded and unrewarded lick bout starts

Haven't checked the code, but a quick question: are bouts independent of trials? In other words, if there are more than one bouts in a trial, all bouts from the second on are considered as "unrewarded bouts" (red circles below)?

We may also need to align PSTH to the first bout after the go cue (essentially the "choice lick").

The concept of a bout here is not connected to a trial. In the example snippet you highlighted the light green bout is rewarded, and all the other bouts are unrewarded.
We could add another annotation of bouts as "first after a go cue" (or whatever we want to call it).

@hanhou I went ahead and added a function annotate_cue_response that annotates licks and bouts whether they were the first lick/bout after a go cue

from aind_dynamic_foraging_data_utils import nwb_utils as nu
from aind_dynamic_foraging_basic_analysis.licks import annotation as a
from aind_dynamic_foraging_basic_analysis.plot import plot_fip as pf

nwb = nu.load_nwb_from_filename(<filepath>)
nwb.df_events = nu.create_events_df(nwb)
nwb.df_licks = a.annotate_rewards(nwb)
nwb.df_licks = a.annotate_cue_response(nwb)
rewarded_response_bout_start = nwb.df_licks.query('bout_start & bout_rewarded & bout_cue_response').timestamps.values
unrewarded_response_bout_start = nwb.df_licks.query('bout_start & (not bout_rewarded) & bout_cue_response').timestamps.values
pf.plot_fip_psth_compare_alignments(nwb, {'rewarded response bout start':rewarded_response_bout_start,'unrewarded response bout start':unrewarded_response_bout_start}, 'G_1_preprocessed', censor=True)


Character counter not updated in IE8 and IE9

Hello!
Sorry, if this is a duplicated issue, but I couldn't find it.
When I enter some text in textbox or textarea and then delete some chars using backspace key then character counter is not updated in Internet Explorer 8 and 9 - character count doesn't decrease, but stays the same. If I re-select the textbox then it shows correct symbol count.
I'm using bootstrap-maxlength.js v 1.5.7
Thank you!

Hi, I am sorry but this plugin doesn't support IE8 or 9.
To get old IE support you should use versions prior to 1.6 only.
Thanks.


param===1.11.0 breaks panel 0.10.2+

I get this when running import panel as pn
    import panel as pn
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/panel/__init__.py:3: in <module>
    from . import layout # noqa
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/panel/layout/__init__.py:1: in <module>
    from .accordion import Accordion # noqa
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/panel/layout/accordion.py:5: in <module>
    from .base import NamedListPanel
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/panel/layout/base.py:15: in <module>
    from ..reactive import Reactive
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/panel/reactive.py:23: in <module>
    from .viewable import Layoutable, Renderable, Viewable
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/panel/viewable.py:37: in <module>
    class Layoutable(param.Parameterized):
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/panel/viewable.py:61: in Layoutable
    CSS classes to apply to the layout.""")
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/param/__init__.py:1390: in __init__
    self._validate(default)
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/param/__init__.py:1398: in _validate
    self._validate_bounds(val, self.bounds)
../../../.pyenv/versions/modeling/lib/python3.7/site-packages/param/__init__.py:1406: in _validate_bounds
    l = len(val)
E   TypeError: object of type 'NoneType' has no len()

Revertin to Param 1.10.1 fixes it.

Sorry about that! I'll push a new Param release shortly.

Param 1.11.1 is now available on the pyviz channel.


Documentation update and casper association branding

Cleaning up bad links and replacing old CasperLabs branding.

bors r+


When open modal window (by Bootstrap 3) that contains [.col--] elements then they are look abnormal.

Example (open in the browser IE7): http://demo.bekliev.ru/_ie/
When window of browser is resizing (when the modal window is visible) then the column blocks become visible.
I think: if show a hidden element (it happens only with Bootstrap modals), that contains [.col-xs|sm|md|lg-*] elements then their width will be 0 pixels.
A long time I was trying to fix this problem, but I can't fix it.
And I used next solution by Damien Alexandre (from 2013/10/09): https://github.com/Schepp/box-sizing-polyfill/issues/36#issuecomment-25981808, but it didn't help me.

If you don't know Russian language - please, translate it with Google Translator.

Уже не нужно...


Powershell task AzurePowerShell@5 fails on Microsoft Hosted Agents windows-2019

Description
Since this morning powershell scripts have failed with: A parameter cannot be found that matches parameter name ***
This only happens on Microsoft hosted agents and have worked prior to this morning. Successful builds from yesterday have been rerun and ends with same failure.
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[X] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
image version: 20210907.4
Is it regression?
image version: 20210903.7
Expected behavior
Parameters to be resolved and resource to be created
Actual behavior
Throws an error stating that the parameter can not be found even though it worked with same commit the day before.
Repro steps
Create a powershell function and call it later on:
function testBehaviour([string]$test , [string]$test2 ){write-host "will not work cause of $test or $test2"}
testBehaviour "firstparameter" "secondparameter"

Hey, @ITSTord
Could you provide logs?

Task version
Yaml
Error screen

Yes,
Task version : AzurePowerShell@5
`parameters:
azureSubscription: ""
env: ""
jobs:

deployment: Infrastructure
displayName: Creating Infrastructure for ${{ parameters.env }}
pool:
vmImage: "windows-latest"
workspace:
clean: all
environment: ${{ parameters.env }}
strategy:
runOnce:
deploy:
steps:
    - checkout: self
      path: core

    - checkout: templates
      path: templates

    - task: AzurePowerShell@5
      condition: and(succeeded(), or(eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceVersionMessage'], 'preview:')))
      displayName: "Create KeyVault and ResourceGroup in env: ${{ parameters.env }}"
      inputs:
        azureSubscription: ${{ parameters.azureSubscription }}
        ScriptPath: "../core/Infrastructure/deploy.ps1"
        ScriptArguments: "-environment ${{ parameters.env }} -templateFileAP ../templates/AKV/accessPolicy.json"
        azurePowerShellVersion: LatestVersion`

@ITSTord,
How do  you pass kvname param to the deploy.ps1 script?
E.g. output:
 steps:
- task: AzurePowerShell@5
  displayName: 'Azure PowerShell script: FilePath'
  inputs:
    azureSubscription: 'sub'
    ScriptPath: deploy.ps1
    ScriptArguments: '-environment env_test -templateFileAP ../templates/AKV/accessPolicy.json'
    azurePowerShellVersion: LatestVersion

We have multiple other different scripts throwing exceptions on not found parameter as well. So this is just one example.

This is just one example, we have multiple scripts throwing the same exception regarding parameters after the agent image version where bumped.

@ITSTord,
I can't reproduce. Looks like the issue in the script and not related to the task itself.
param(
    $environment,
    $templateFileAP
)

function CreateKeyVault([string]$kvname, [string]$rg, [string]$loc, [string]$tag, [string]$sp) {
    Write-Host $PsBoundParameters
}

Write-Host "`$environment: $environment, `$templateFileAP: $templateFileAP"
CreateKeyVault "kvname" "rg" "loc" "tag" "sp"

Fair point that you can't reproduce. But the exact same commit ran fine on previous image version. Ill try to further debug it and come back with some more information.

@ITSTord ,
I couldn't find find alias kvname for New-AzResourceGroupDeployment which you use in the script at line 14. Could you check it?
PS > (Get-Command New-AzResourceGroupDeployment).Parameters.GetEnumerator() | % {$_.Value.Aliases}
DeploymentName
AzContext
AzureRmContext
AzureCredential
vb
db
ea
wa
infa
ev
wv
iv
ov
ob
pv
wi
cf

the templatefile specified (accessPolicy.json) have kvname as a parameter. But it works on all images except windows-2019.

@ITSTord , Are you sure that kvname param exists?

yes, and as i've said it ran fine on previous versions of windows-2019. Stopped working yesterday, no changes to the code. I run it fine on windows-2022/ ubuntu-latest. So if it did not exist in the templatefile it would fail for all agent images.

We are seeing the same issue in an AzurePowerShell@4 task (deploying an arm template)
Just started failing yesterday morning when 20210907.4 is used (if a retry gets 20210903.7, it succeeds).
Friday, September 10, 2021 1:08:41 PM
An error occurred:
A parameter cannot be found that matches parameter name 'keyVaultName'.
use existing connection was true and disconnect will be ignored
##[warning]A parameter cannot be found that matches parameter name 'and'.
##[error]A parameter cannot be found that matches parameter name 'keyVaultName'.

yes, and as i've said it ran fine on previous versions of windows-2019. Stopped working this morning, no changes to the code. I run it fine on windows-2022/ ubuntu-latest. So if it did not exist in the templatefile it would fail for all agent images.

The same error on local machine:
PS > New-AzResourceGroupDeployment -TemplateFile .\template.json -kvname "abc" -sp $sp -ResourceGroupName test
New-AzResourceGroupDeployment : A parameter cannot be found that matches parameter name 'kvname'.

Looks like the known issue with New-AzResourceGroupDeployment cmdlet - https://github.com/Azure/azure-powershell/issues/15841
Try to set Azure PowerShell version to 6.3.0

setting psversion to 6.3.0 solved it. Thank you

Using an inline script in Azure PowerShell v4/5

@mattnpvm , please set Az at least version 6.3.0 in the task.

@mattnpvm , please set Az at least version 6.3.0 in the task.

How do I do that if 6.3 isn't installed on the Microsoft hosted agent?

@mattnpvm , It will be downloaded at runtime.

Does the task cache downloaded Az modules properly or would it be better to use an older version for performance?

Does the task cache downloaded Az modules properly or would it be better to use an older version for performance?

It takes 3-5s to install a new version to the cache and works quite good.

Are files downloaded by task into $env:SystemDrive + "\Modules" or "/usr/share" folder cached between multiple jobs?

Are files downloaded by task into $env:SystemDrive + "\Modules" or "/usr/share" folder cached between multiple jobs?
@jikuja,

Windows:
Extracting archive: C:\Modules\az_6.3.0.zip
Import-Module -Name C:\Modules\az_6.3.0\Az.Accounts\2.5.2\Az.Accounts.psd1 -Global

Ubuntu:
Saved!
Az version 6.3.0 not avaiable locally on the agent. Downloading dynamically.
Import-Module -Name /usr/share/az_6.3.0/Az.Accounts/2.5.2/Az.Accounts.psd1 -Global

The new Windows Server images with Az 6.4.0 on board have been deployed.

We have the same issue on our private agent, but in our case we have already installed azure powershell 6.4.0. Even when specifying a different preferredAzurePowerShellVersion the warning still appears

We have the same issue on our private agent, but in our case we have already installed azure powershell 6.4.0. Even when specifying a different preferredAzurePowerShellVersion the warning still appears

Could you please show Get-Module Az.Resources -ListAvailable ?

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     4.3.1      Az.Resources                        {Get-AzProviderOperation, Remove-AzRoleAssignment, Get-AzR...
Script     3.4.1      Az.Resources                        {Get-AzProviderOperation, Remove-AzRoleAssignment, Get-AzR...
Script     3.1.1      Az.Resources                        {Get-AzProviderOperation, Remove-AzRoleAssignment, Get-AzR...
Script     2.5.1      Az.Resources                        {Get-AzProviderOperation, Remove-AzRoleAssignment, Get-AzR...
Script     2.3.0      Az.Resources                        {Get-AzProviderOperation, Remove-AzRoleAssignment, Get-AzR...

Yes that seems to fix the issue. Thanks @al-cheb

Is it possible that this failure occurs on PowerShell tasks as well?
Starting: Generate Changelog with PowerShell
==============================================================================
Task         : PowerShell
Description  : Run a PowerShell script on Linux, macOS, or Windows
Version      : 2.194.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\a\_temp\88ee244f-88c6-4858-90d6-4fe42e998d32.ps1'"
Generating Changelog
D:\a\1\s\AdbApp\generate_changelog.ps1 : A parameter cannot be found that matches parameter name 'cdgitfolder'.
At D:\a\_temp\88ee244f-88c6-4858-90d6-4fe42e998d32.ps1:6 char:34
+ AdbApp\generate_changelog.ps1 -cdgitfolder AdbApp -branch "main ...
+                                  ~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [generate_changelog.ps1], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : NamedParameterNotFound,generate_changelog.ps1

##[error]PowerShell exited with code '1'.
Finishing: Generate Changelog with PowerShell

I can execute the powershell script locally with the same parameters without any problems. It looks like the maximum parameters I can use within azure pipelines are two.
Agent name: 'Azure Pipelines 2'
Agent machine name: 'fv-az182-808'
Current agent version: '2.194.0'
Operating System
Microsoft Windows Server 2019
10.0.17763
Datacenter
Virtual Environment
Environment: windows-2019
Version: 20211102.4
Included Software: https://github.com/actions/virtual-environments/blob/win19/20211102.4/images/win/Windows2019-Readme.md
Image Release: https://github.com/actions/virtual-environments/releases/tag/win19%2F20211102.4
Virtual Environment Provisioner
<IP_ADDRESS>-master-20211022-1
Current image version: '20211102.4'
Agent running as: 'VssAdministrator'
Prepare build directory.
Set build variables.
Download all required tasks.
Downloading task: CmdLine (2.182.0)
Downloading task: PowerShell (2.194.0)

@mfe- , Could you please provide the script and how do you pass parameters to it?

@al-cheb I just tried to create a public repository where the issue occurs, but it looks like it's not reproduceable anymore. Maybe I have overlooked something.  If I find something I'll let you know. Thanks


⚠ Samsung has degraded performance

In 9d03388, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2252 ms

Resolved: Samsung performance has improved in d296f9c.


improve libp2p helper memory usage by caching peers in codanet.Helper to use in getRandomPeers

Thank you for contributing to Mina! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.
Explain your changes here

based on profiling, the codanet.Helper.getRandomPeers() function used nearly 1/4 the total allocated memory by the libp2p helper, specifically the Peerstore().Peers()  function
improve libp2p helper memory usage by caching peers in codanet.Helper to use in getRandomPeers
created a go func to call Peerstore().Peers() every minute, instead of calling everytime a new peer is connected in CodaConnectionManager.Connected()

Explain how you tested your changes here.
Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Closes #0000
Closes #0000

!ci-build-me

!ci-build-me

This is stale. Tracking in issue #14849. Closing.


[crypto] EdDSA remove small group R check

Motivation
With regards to malleability, we want to defend against a third party (other than the signer) trying to modify the signature payload. Briefly, an EdDSA signature is a tuple (s, R), so there are three ways to modify the signature, either by altering s or R or both. However, the R part is hashed during signing and verification (to compute h = H(ENC(R) || ENC(A) || M)), and thus a third party cannot modify R without being detected.
This PR removes the check that R lies on a small group.
Ensuring that s < order of the EC group is important and remains as part of our malleability guarantees.
Note that the signer could always pick a small order R, but actually she will harm herself if she does so. We are currently interested about malleability issues in which a third party (not the signer) tries to modify the signature.
Have you read the Contributing Guidelines on pull requests?
YES
Test Plan
Test against invalid s values only.
Related Issues
#601

@bors-libra  +r


[Refactor][UI Next]Reconstructing the Log Component

Purpose of the pull request
Please refer to the main issue #9537.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #9574 (389fefe) into dev (a5bbf78) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9574      +/-   ##
============================================
- Coverage     39.98%   39.94%   -0.04%
+ Complexity     4432     4431       -1
============================================
  Files           831      831
  Lines         33314    33328      +14
  Branches       3677     3680       +3
============================================
- Hits          13320    13313       -7
- Misses        18766    18787      +21
  Partials       1228     1228

Impacted Files
Coverage Δ

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
48.21% <0.00%> (-8.04%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...cheduler/api/service/impl/ExecutorServiceImpl.java
40.88% <0.00%> (-1.09%)
:arrow_down:

.../org/apache/dolphinscheduler/api/enums/Status.java
100.00% <0.00%> (ø)

...er/server/master/runner/WorkflowExecuteThread.java
8.21% <0.00%> (ø)

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (ø)

...ce/api/datasource/AbstractDataSourceProcessor.java
65.21% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5bbf78...389fefe. Read the comment docs.


Taxonomy for Industrial Asset's Q&A

Describe the proposed contribution to the taxonomy
We study existing compositional skill and find a big gap for industrial assets. We have a extensive expertise in contributing the taxonomy for industrial assets and Q&A around it.
Here is a simple example:

How to read above tiny taxonomy for compositional skills: Industrial assets have many components and these component fails over a time and that can be detected using various sensor data. We have many nodes to be added progressively.
The attempt is to harmonize the development of taxonomy for Industrial applications specially Industry 4.0.
Input given at the prompt
The fine tune model will be better aligned with end user need for Industrial applications to answer what, where when and how for an asset lifecycle. and reduce a burden of maintaining an in-sample example for building an application.

Revisiting this now that it's been 5 months!

I believe this isn't relevant anymore due to the organization we have of the taxonomy via the Dewey decimal system. We have standardized on that.
However, if you chose to do this for your own private taxonomy, there would be nothing stopping you.


Update Mixer FAQ answer.

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

let's get this in ?


mamba install -c conda-forge moab doesn't install pymoab

I am trying to install parastell on a rhel7 machine. I followed the installation instructions given in the README but I got the error that pymoab is not recognized. I tried to install specific versions and builds too but none of them are installing pymoab although they are installing moab package without any issue. Then I built moab myself with pymoab from source and I was able to get pymoab in the parastell_env I created. But when I tried to run ExampleScript.py it was complaining that it needed module sklearn and imp. I tried to install importlib but it is not compatible with python 3.12 which is also mentioned in this post.
Could you please give me the updated installation instructions?

I just posted a yml file for my currently working conda environment on #37 , it might work for you, sorry about the install issues

Addressed in solution to Issue #37


Rename the default branch of this repo to main

This is a tracking FR that can be closed when the default branch of this repo is renamed from master to main. For more context, see https://github.com/ampproject/amphtml/issues/32195 and this plan.
I'm not sure what other changes need to go in to amphtml or amp-github-apps in order to let the bundle-size check continue to work. Happy to make any changes you think are needed.
/cc @danielrozenberg for visibility and guidance on how to proceed.

Done.


[5.3] Add --path option support for artisan migrate:rollback

Added the --path command option to the RollbackCommand to support rolling back commands that may have been executed with the --path option in the MigrateCommand. This especially needed for multitenant db migrations where tenant database migrations are typically stored in a tenant subfolder of the migrations directory.

This won't work in my opinion. You may be providing the path, but it would still load all the migrations path.

I have tested this change and it indeed works with 5.3.x as the Illuminate\Database\Console\Migrations\BaseCommand respects the path option (if present) in the getMigrationPaths method. With this change in place, when I run migrate:rollback and specify a --path=database/migrations/tenant option it only attempts to rollback the migrations in the tenant subfolder and doesn't attempt to rollback the migrations in the main migrations folder.
Let me know if you have any questions.

My bad mate. I just checked it works.

Also doesn't work --path option in migrate:refresh and migrate:reset

@afigienas looks like the RefreshCommand has the path option but the ResetCommand doesn't.

@anderly but looks like $path variable are not sent to rollback or reset command.
https://github.com/laravel/framework/blob/5.3/src/Illuminate/Database/Console/Migrations/RefreshCommand.php

        if ($step > 0) {
            $this->call('migrate:rollback', [
                '--database' => $database, '--force' => $force, '--step' => $step,
            ]);
        } else {
            $this->call('migrate:reset', [
                '--database' => $database, '--force' => $force,
            ]);
        }

it is used only in
  $this->call('migrate', [
            '--database' => $database,
            '--force' => $force,
            '--path' => $path,
        ]);

so the error comes in "clear DB" step

@afigienas oh, you're right! I only saw that the path option was defined.
Ok, so looks like the RefreshCommand and ResetCommand should respect and send the --path option when fired as well for this to be a complete patch.

Updated RefreshCommand and ResetCommand, updated tests and squashed commits. Should be ready to go.


How to add streamer?

How can I add myself and others to the directory?

Oh!!! I've just noticed that this is not women of jamstack...!!
Let me know your twitch username and I'll add you to the contentful database 😅

Basically it all works by adding a twitch username to Contentful. You can also provide a YouTube link, Twitter link and website link.
The site isn't completely big free right now and is prone to being a bit weird, and it's on my list to fix at some point...

Although... you stream on YouTube don't you? We don't currently have support for showing the same data for people who don't stream on Twitch I'm afraid.
I think I need to go back to the drawing board with this site and completely rewrite it in the same way I am building women of jamstack.
I have a lot of functionality to show when people are online/offline and update the stream thumbnail etc. But maybe it's not necessarily and in making things simpler it would open up the directory for people who stream elsewhere.

You could keep the functionality for the twitchers and then add it for YouTubers after the fact. I have done quite a bit with the YouTubeAPI and could see if I could figure it out. I plan to add similar functionality to my own site anyways.