Misc: Mobile UI

Summary
The current UI isn't very good on mobile devices. We should start thinking about how we can improve it.
Possible solutions
There are two paths we could go down:

Create an entirely separate UI for mobile devices
Make modifications to the current UI so that it adjusts better to fit smaller screens

I'm keen to hear people's opinions on which route they think is best. There are definitely pros and cons to each one. If we create an entirely new UI, it will break a lot of the code in src/web/ which is currently tightly coupled to the existing DOM. However, modifying the current UI to work better on mobile could result in messy code if it isn't done well. This could be a good time to start building index.html in a more modular fashion so that the code becomes easier to maintain.
If anyone wants to mock up some designs for what a mobile UI could look like, please go ahead. The focus should be on simplicity.

I support one responsive UI. The main issue when designing for smaller mobiles (i.e. iPhones, such as the SE, in portrait mode) is that the space is very limited. As I see it, there are four main* elements to the CyberChef page, defined as:

Operations Bar
Recipe List
Input
Output
*There are additionally auxiliary elements, such as the options, support, and download buttons.

Cramming the 4 main elements into one screen is difficult. The commonsense solution would seem to be to separate them out into pairs of two - however, recipe theoretically needs to be seen with both operations and with output (for making a recipe and then stepping through it purposes). Therefore, I would propose a design with a fixed bar at the top showing options and support, a fixed bar on the bottom showing download and latest release, and then a 4-row stacked column, stacked in the following order:

Operations

Recipe

Output

Input

I'm not an amazingly talented developer, but I'm competent, I'm willing, and I've got free time. If y'all can think of any conflicts, I'd be glad to hear what you think of the proposed design. I'll send up a visual template of the design I'm proposing this weekend. No guarantees on speed with this, but seeing as the issue has been untouched for ~2 years, I don't foresee that being a problem.

@Cal-Hagner I'd maybe change the order of Output and Input.
Would be interested in seeing a visual template!

Notes:

There is a third possible screen configuration --> Recipe & Output (for walkthroughs of recipes
The addition of a scroll-bar to recipe will need to be handled (should be minor changes from current configuration
Overflow-y of both recipe and operations will need to be handled
Options and support will remain fixed at top of page, & download and build info at bottom
-- Build info shortened to “Last build: _ days ago – v_”
Options page will also need proper resizing

Notice: As I begin to work from my fork of CyberChef, I may need some assistance with figuring out how to view my edits in my fork in the GitHub page at https://cal-hagner.github.io/CyberChef. I'm familiar with front-end, it's just GitHub I don't understand. 🙃
Happy holidays!

bump

Heya CC,
I've been working a little on this and so far I've landed on the following mobile UI layout:

A few choices I made and why:

I'd like to make Operations search a dropdown when tabbed, laying on top.
Recipe, Input and Output are currently set to 15vh - 20vh - 20vh with overflow-y: scroll. As I'm in the really early stages still, I haven't tested in on my mobile device to experience if this is comfortable or not. I would probably want to cover the full height of the screen so there will not be a whitespace anymore between Output and Bake.
The 'notice' in the top banner would not be displayed on mobile, or perhaps moved all the way to the bottom if it is required to be displayed. What do you think?
I removed the text for Options, About / Support in the top banner to save space. I think the icons alone are straightforward enough.

There is still a lot of work to do but if someone would want to give early feedback / requests so I can incorporate that, that would be super appreciated :)

Some UX demos:
https://user-images.githubusercontent.com/40611703/232438268-73137e0f-a937-4e71-ad61-aa76db0a7631.mov

the dropdown has a fixed height and lays on top so the underlying content / layout doesn't jump around
the dropdown is scrollable

https://user-images.githubusercontent.com/40611703/232436893-d0197b33-017a-4a4e-a749-f5c61b712359.mov

categories opens when search has no value
search-results opens when there is value in search
the selected recipes are listed in a scrollable panel so content / layout doesn't jump around

A few TODOS / notes :

I need to figure out what best to do with input[type="search"] close icon that appears on input value ( Bootstrap ). Preferably, it should only clear the input but keep the dropdown open or I'd get rid of it.
There is not enough visual feedback when double clicking an operation. I haven't looked into why much yet but I will get to that.

https://user-images.githubusercontent.com/40611703/233046862-b651c1a8-561e-44a8-8ea9-3c2bfa43314a.mov

Desktop layout restored & some issues resolved that caused some lingering layout inconsistencies.

On window widths < breakpoint, where we cannot see the operations lists and the recipe panel at the same time:

a checkmark gets added on double clicking or double tapping an operation ( to be removed once recipe gets deleted from list )
drag events are no longer possible, except in the 'edit favourites' modal where favs can still be rearranged as desired
popovers are disabled
the check icons are not displayed on desktop view, as the UI remains the same as the current UI ( but could opt to leave it on desktop view as well )

This leaves the following issue:

how will a user on mobile add an operation to their favourites ( now that they cannot drag to 'favs' category anymore )?
Possible solutions:

add a star icon ( outlined ) to the operation that will be filled when tapped, and added to favourites
long press, then allow drag and drop to the favourites category

to complete the cut off commit message above: "add 'add favourite' capability for mobile UI

On mobile, I found that scrolling through the operations and the drag and drop of an operation to the favourites category was very finicky.

I have added outlined star icons to the start of the operation row
a user may press it to add it to the favourites list
the star icon then fills in to indicate it is a favourited operation
the favourites category dropdown opens as per current behaviour
note that it is not a toggle, removing a favourite must still happen the same way as per current behaviour ( through the modal )

I also added the capability to maximise recipe, input and output panes on mobile UI:
Maxed panes
Recipe

user may edit ingredients here as normal
double tap to delete one ingredient
change order by pressing on an ingredient with a delay of 200ms: there is some visual feedback when the ingredient is grabbed and the order can be changed as normal

All of the above can also be done outside of the maximised pane, but the pane is just rather small and it's not comfortable to do so ( hence the maximised pane view )
Input

for more comfortable UX

Output

to comfortably view the output

On desktop, everything remains as normal. Only the output pane is able to be maximised.

I have updated the controls component to 50px tall on mobile. 70px ( previous ) was taking up a lot of space that can be used more efficiently.
Please note the chef icon has been removed on mobile view.
Please note the 'Auto bake' text has been shortened to just 'Auto' ( as the controls component is already in the context of 'baking' ) to save space and reduce resizing complexity.
On desktop the controls height is 70px as per usual. The icon is also visible as normal.

Just a quick demo for the smallest possible screen before the layout would jump into mobile UI mode:

This would be a width of 768px.
Everything looks normal ( albeit cramped, but that is expected ) and all buttons etc. can be pressed, no weird overflows. Optionally, we could decide to set the breakpoint higher of course.

PR opened here :)


Add List.takeIf

Add this function to https://github.com/circuithub/elm-list-extra/ instead?

I'm closing this. Could be taken up at https://github.com/circuithub/elm-list-extra/.


f3d: 1.1.0 -> 1.1.1

Motivation for this change
Routine update.  Repository migrated to Github.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146785 run on x86_64-linux 1

1 package built:

f3d

Result of nixpkgs-review pr 146785 run on x86_64-darwin 1

1 package built:

f3d


feat: implement filtering of terminal tokens

In order to decrease token usage, we have implemented some basic filtering of non-useful input from the terminal, so that it is not passed the the API.
This feature has a checkbox in the Settings view so that a user may enable or disable it.
We have seen good results in decreasing token usage.
There are also some boilerplate documentation files that slipped in there.

Thank you for taking the time to open this PR @tapvt 🙏
Note to reviewers: we'll need to clean up the documentation in this branch, but let's work with the contributor as much of his ideas in as possible (particularly the regex patterns he's found are good filters)


add browser name; refine preferred codec

Looks good. can you also add a yarn changeset comment describing the change? it'll make generating a changelog easier
Done


Use font-awesome as an npm module, not a file in the repository

This isn't 2005.

Also, I've used this module, react-fontawesome to manage FA classes. Doesn't include the CSS though

@victorporof @jsantell what about this http://gorangajic.github.io/react-icons/


LongField is not supported, yet.

Hi , i try to use and the serializer with longfield and go this error:
repr(...) failed: KeyError: u"class 'mongoengine.fields.LongField' is not supported, yet.

This issue will be addressed on weekend, sorry for late response

:+1:

Yeaah.. so.. wuzzup?

Do you have a fix for having LongField.

fixed in trunk


Mapping Issue w/ IO Consoles

Description
The overwatch and ship security consoles in the IO room on the second floor is unreachable without standing on the desk.
Reproduction
Attempt to use either console while seated behind the desk.
Screenshots

Additional context
N/A

#2393

This has the same issue as the Alpha overwatch computer, wall mount doesn't work if the entity is on top of two walls, will try to fix when I add IOs


[SPARK-20343][BUILD] Force Avro 1.7.7 in sbt build to resolve build failure in SBT Hadoop 2.6 master on Jenkins

What changes were proposed in this pull request?
This PR proposes to force Avro's version to 1.7.7 in core to resolve the build failure as below:
[error] /home/jenkins/workspace/spark-master-test-sbt-hadoop-2.6/core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala:123: value createDatumWriter is not a member of org.apache.avro.generic.GenericData
[error]     writerCache.getOrElseUpdate(schema, GenericData.get.createDatumWriter(schema))
[error]

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.6/2770/consoleFull
Note that this is a hack and should be removed in the future.
How was this patch tested?
I only tested this actually overrides the dependency.
I tried many ways but I was unable to reproduce this in my local. Sean also tried the way I did but he was also unable to reproduce this.
Please refer the comments in https://github.com/apache/spark/pull/17477#issuecomment-294094092

Test build #75837 has started for PR 17651 at commit 56c1eba.

(I will cc someone after I got a Jenkins pass).

Test build #75837 has finished for PR 17651 at commit 56c1eba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75837/
Test PASSed.

perhaps have a reference in pom.xml to this so they both change together the next time?

Yea, pom was the first try and it was kind if a failed. Please check out the discussion in https://github.com/apache/spark/pull/17642

I left a uesless comment and removed it back (I misunderstood). Yes, I will add a small comment.

cc @srowen, could you check if it makes sense to you?

Test build #75843 has started for PR 17651 at commit 0031804.

Test build #75843 has finished for PR 17651 at commit 0031804.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75843/
Test PASSed.

I'd be interested to know if this resolves the issue, and the only real way is to merge it. It's not wrong, but it is hacky. That said I don't have a better idea at the moment.

Yes... I hope anyone is able to reproduce this by the steps I did - https://github.com/apache/spark/pull/17477#issuecomment-294094092 or confirm I did this wrong.
I am fine with leaving this open for some days more and see if there is anyone who at least confirm this fxies the issue or has a better idea.

FWIW, I at least checked this overrides the dependency (after manually mismatching the versions between pom and sbt) if I haven't done something wrong.

Merged to master to see what it does for the SBT 2.6 build

hm.. sorry, it seems not working with this too ...
[error] /home/jenkins/workspace/spark-master-test-sbt-hadoop-2.6/core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala:123: value createDatumWriter is not a member of org.apache.avro.generic.GenericData
[error]     writerCache.getOrElseUpdate(schema, GenericData.get.createDatumWriter(schema))
[error]

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.6/lastBuild/

I will open a PR to revert this.

Hm. In addition to that, am I right that it works to just not try to build scaladoc in SBT? That may be the best we can do in the short term

Yes, I think it only fails to build scaladoc in SBT.  However, what do you think about disabling unidoc build only in that machine via environment variables?
I assume we are checking AMPLAB_JENKINS_BUILD_TOOL and AMPLAB_JENKINS_BUILD_PROFILE here https://github.com/apache/spark/blob/master/dev/run-tests.py#L519-L520
Assuming from the logs, it seems environment variables are as below:

spark-master-test-maven-hadoop-2.6 - https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.6/lastBuild/consoleFull

JAVA_HOME=/usr/java/jdk1.8.0_60
JAVA_7_HOME=/usr/java/jdk1.7.0_79
HADOOP_PROFILE=hadoop-2.6
HADOOP_VERSION=
SPARK_BRANCH=master
AMPLAB_JENKINS="true"

spark-master-test-maven-hadoop-2.7 - https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.7/lastBuild/consoleFull

JAVA_HOME=/usr/java/jdk1.8.0_60
JAVA_7_HOME=/usr/java/jdk1.7.0_79
HADOOP_PROFILE=hadoop-2.7
HADOOP_VERSION=
SPARK_BRANCH=master
AMPLAB_JENKINS="true"

spark-master-test-sbt-hadoop-2.6 (this one is being failed) - https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.6/lastBuild/consoleFull

JAVA_HOME=/usr/java/jdk1.8.0_60
JAVA_7_HOME=/usr/java/jdk1.7.0_79
SPARK_BRANCH=master
AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.6
AMPLAB_JENKINS="true"

spark-master-test-sbt-hadoop-2.7 - https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-2.7/lastBuild/consoleFull

JAVA_HOME=/usr/java/jdk1.8.0_60
JAVA_7_HOME=/usr/java/jdk1.7.0_79
SPARK_BRANCH=master
AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.7
AMPLAB_JENKINS="true"

PR builder - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75843/consoleFull

JENKINS_MASTER_HOSTNAME=amp-jenkins-master
JAVA_HOME=/usr/java/jdk1.8.0_60
JAVA_7_HOME=/usr/java/jdk1.7.0_79

So, probably, I could just add a if-else via AMPLAB_JENKINS_BUILD_TOOL and AMPLAB_JENKINS_BUILD_PROFILE as a band-aid fix.

Or, do you maybe know an easy way to exclude Scaladoc? I just searched a bit but I could not find a short and clean way. Up to my knowledge, I should add a weird logics in SparkBuild.scala to make it working fine locally and fix jekyll build but not working in some environments.

I see, so only disable scaladoc generation for the SBT + 2.6 build? that sounds even better. I don't know much about SBT I'm afraid. If it's complex, maybe best to punt right now. But yes that seems better if possible.

Oh.. actually, I meant little bit different I guess. I meant disabling sbt unidoc if both AMPLAB_JENKINS_BUILD_TOOL and AMPLAB_JENKINS_BUILD_PROFILE are set to hafoop-2.6 and sbt. So, this will not be skipped unless someone set two variables to the environment variables (and I hope this is only the case in that machine) if I understood correctly.
Probably, let me turn the revert PR to suggest this (I guess it might be okay). I will cc you after looking into this more and then push some commits.


Odd results for tick labels when plotting dendrogram

Since this seems to be a known limitation, this might be a duplicate of #22. On the other hand, as mentioned in #288, some support for text labels seems to have been added on master, and for the plot I was toying with, I am seeing labels when using the current HEAD, but the results turn out a bit odd; so I thought I’d post this in case it’s an edge case you’d want to know about.
The following will generate an example plot:
import numpy
from scipy.cluster.hierarchy import dendrogram, linkage

feature_vectors = [(1,), (2,), (5,)]
clusters = linkage(feature_vectors)
_ = dendrogram(clusters, labels=["a", "b", "c"])

Now, mpld3 HEAD will show the labels, but they will all be set to (c,a,b).
Vanilla matplotlib:

mpld3:

Thanks for making mpld3!

Hi – thanks for the report! Yes, going beyond tick labels is a sticking point in the current implementation. I hope it will be fixed some day.


fix(VulnerableCode): Handle invalid URLs in references

There are some packages for which VulnerableCode returns vulnerabilities with URL references that cannot be converted to URIs, since they contain invalid characters. In such cases, no meaningful advisor result was generated. Prevent this by handling exceptions when converting to URIs.

There are some packages for which VulnerableCode returns vulnerabilities with URL references that cannot be converted to URIs, since they contain invalid characters

Please also report this to https://github.com/nexB/vulnerablecode/issues if not already done so.

Please also report this to https://github.com/nexB/vulnerablecode/issues if not already done so.

Created this issue: https://github.com/nexB/vulnerablecode/issues/1173


Crash during entry into System OFF from an i2c device driver shutdown actions

Describe the bug
I'm trying to enter System OFF mode using the power manager, i.e.
    struct pm_state_info off_state {
        PM_STATE_SOFT_OFF, 0, 0
    };

    pm_state_force(0u, &off_state);
    k_msleep(1000);

Instead of getting into system off, the device reboots. After attaching a debugger it looks like an assert is getting triggered during sensor Power manager shutdown actions. (These are happening from the idle thread which the assert is not happy about).
zephyr_crash_stack.txt
Please also mention any information which could help others to understand the problem you're facing:

Using zephyr v3.3.0
Using a Xiao BLE board with an I2C sensor (BMP388) attached.
CONFIG_ASSERT is enabled and CONFIG_PM_DEVICE
Problem does not happen when the sensor is not configured in the device tree.

To Reproduce
Judging by the stack trace, it should be possible to reproduce this with any board that has an I2C device that implements power management and issues some i2c transactions during shutdown. In my case it is happening regularly and if I disable the sensor System Off happens without an issue.
Expected behavior
The i2c device should go to low power mode and system off should be entered.
Impact
Unable to perform System Off which is critical for my application.
Logs and console output
I think the stack trace should be sufficient, but I can provide more info if needed.
Environment (please complete the following information):

OS: Linux
Toolchain  Zephyr workspace application
Commit SHA or Version used https://github.com/zephyrproject-rtos/zephyr/tree/zephyr-v3.3.0

Additional context
Add any other context that could be relevant to your issue, such as pin setting,
target configuration, ...

This is not a problem related to the nRF platform but to the device power management in general. The crash occurs because the sensor driver needs to send a control value to the sensor over the I2C bus to put it to sleep. This involves waiting on a semaphore for the transaction to complete. And that is not allowed in the idle thread from which pm_system_suspend() and in consequence pm_suspend_devices() is called. Similar problem can occur for any driver that needs to perform some communication etc. (and wait for its completion) in order to suspend the handled device. And I don't see an easy solution for this. It seems that suspending of devices needs to be reworked a bit.
@nashif  @ceolin @gmarull Could you comment on that, advise something?

Thanks @gmarull. Closing this issue, but ideally we'd improve the documentation so that the use case is well-documented and other users do not fall into this issue.


Clickhouse SQL generation for datatypes.

The SQL generated by the parser does not work inside Clickhouse. The problem is in datatypes, which are case sensitive in Clickhouse. I suggest generating a Clickhouse version for datatypes. This will still work for other databases where datatypes are not case sensitive (like postgres) and will also work for Clickhouse. Interesting enough some datatypes are also not case sensitive in Clickhouse, but the ones which are case sensitive, are converted in the PR.

Hi @iffyio. What do you mean by both styles? Camel case as in Clickhouse and uppercase notations? Currently in the code both of this styles are kind of mixed. I agree with you, it would be best to support both styles. In this PR I suggested to change only those which affect Clickhouse SQL generation.
Basically the styles were mixed before and are also mixed after the PR :). The problem with supporting two styles, is the complication. We need to introduce dialects not for just parsing but also for generating the SQL string. I am not that good at the knowledge of the codebase, so I cannot tell will it be complicated or not to implement. But my current proposal fixes the problem for the database which has case sensitive types (Clickhouse) and does not brake compatability (cases were mixed before and also after).

Ah yeah by both styles I mean that, today when displaying sql, the parser always uses upper case e.g. FLOAT64. While the changes in this PR updates that behavior such that for some types it now uses camel case Float64 - which I expect will break a lot of tests (and worse may be undesirable for other dialects). The changes aren't specific to clickhouse, Float64 for example is used by BigQuery.
I agree that it will be quite invasive to make this behavior configurable. On the other hand, I fear that using camel case for some types vs upper case for others will be quite haphazard (especially if Clickhouse isn't alone with this requirement).
Currently I'm not sure what a good way to approach this issue is actually :thinking:

@iffyio This looks like a job for the Dialect trait. Or for a new trait, e.g. Formatter.


Update ServiceRequest (Michaela Ziegler, ahdis ag)

Adaption to the usage of the CH Core ServiceRequest profile as parent in CH ORF
Adaption to the changes in the CS/VS ServiceRequest Category: https://github.com/hl7ch/ch-epr-term/issues/41

CH Core ServiceRequest is already used as parent via CH ORF
Adaption to CS/VS ServiceRequest Category is on hold, till it is updated in CH Term, see comment

added in changelog


TOP catched an error - BlockRenderHelper

Hi McJty,
I'm assembling and testing a pack at the moment and noticed an error popping up: NoClassDefFoundError: mcjty/immcraft/rendering/BlockRenderHelper
Full error is here, along with a full mod list: http://pastebin.com/TrzPTRv0
Also: The correct English is "TOP caught an error". (If that was deliberate, please ignore this line! :-)
immcraft-1.10-1.1.8
mcjtylib-1.10-2.2.0
theoneprobe-1.10-1.3.3
Cheers!

That's a bug in Immersive Craft. Please report this to the author of... oh wait, that's me.
I'll check it out :-)


Typo

invariannt culture.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06a17d5d-5f6e-d6bc-324b-af411a42ccb8
Version Independent ID: f58588d7-70f6-aa32-5c6d-ac3e7d72d87c
Content: .NET Core Application Deployment
Content Source: docs/core/deploying/index.md
Product: dotnet-core
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

Thanks for your feedback @Number5isAlive. Would you like to submit a pull request with the fix?
Check this guide for a quick explanation on how to do this: https://docs.microsoft.com/en-us/contribute/#quick-edits-to-existing-documents

label for link: https://docs.microsoft.com/en-us/dotnet/core/deploying/index
Current:  invariannt culture.
Proposed: invariant culture.

change looks correct.

I've opened the pull request for you: https://github.com/dotnet/docs/pull/7654


Change Associated Meta To Accept Any JSON/BSON metadata

The current structure for meta is Map<String, String>. This was done due to a protobuf limitation of key/value only and no handling for generic objects. This needs to be changed to accept a byte[] so that a bson document with proper types can be stored.

the protobuf will take a byte array
the java client will take a MongoDB document object and encode as byte array
the rest client will take a Json

Fixed in version 1.2


Update kafka example for DCOS 1.11

Change output of the command dcos package install kafka (update version)
Update image to DCOS 1.11 cluster image
Modify the image in the example: wurstmeister/kafka:<IP_ADDRESS> -> mesosphere/kafka-client:latest (<!> Warning: I only update the image for 1.11 but the 1.10 does not work currently due to the same image problem).
Adding a Clean kafka-client section.
Update kafka example root README.md

Great work, thank you! Would you be interested in submitting an update to the 1.10 example to modify the image in the example so it's pointing to the working one?


Zotero Citation Key Doesn't Match Keys in .bib File

[X] I have verified in the Zotero addons screen that I have the latest release of BBT (https://github.com/retorquere/zotero-better-bibtex/releases/latest) and Zotero installed
[X] I am posting a single question, bug or feature request
[X] I have included a descriptive subject of the problem
[X] I am available for follow-up questions and testing
[X] If I am posting an export or key-generation related bug report, I have included an error-report by right-clicking the problematic reference and submitting an BBT error report

Exporting references
I'm exporting BibTeX, and here is my report ID: RG4A6VSG-euc
My problem:
In preferences, I've set my citation key to: [auth:lower][year]
In Zotero, in the citation key column, the citation keys match the above format (e.g. "baicker2007").
However, in the .bib file, citation keys are in the following format: [auth:lower][shorttitle][year]
I have already tried/checked the following:
(1) I double-checked that I am exporting my collection as "Better BibTeX" (the "export notes" and "keep updated" boxes are checked--and only those boxes--if that helps).
(2) I have refreshed my citation keys for all references in my exported collection.
The only other thread online where I found someone with this problem (https://forums.zotero.org/discussion/50328/bug-in-citation-key-mismatch-with-bib-collection-export), they had export to "BibTeX" instead of BBT, and making the change fixed their problem -- but since I'm already exporting as BBT, I'm unsure what to do.
Any help is appreciated.

I'm not sure what the original scenario was; RG4A6VSG contains no indication of an attempt at key refresh, just a few things:

Changing the key format does not change existing keys; if you want to change keys after the pattern change, you need to select them and right-click "Refresh"
Bib files do not update automatically unless you have selected auto-export, and here too, changing the pattern won't cause an auto-export to be triggered, but a refresh will.

In the 2nd description,, step (1) + (2) will force a change to to the citation keys, so it's explainable that keys would change and auto-exports would be triggered.

So after the refresh, the auto-export kicked off (expected), but then what didn't work as expected?

Yes, to my knowledge, that is what appears to have happened. I would open the just-updated file and compare the citekey in the .bib file to the citekey in Zotero (in the citekey column), and the two would not match -- the former including the short title in the citekey and the latter not.

Can you reproduce this problem? If so I can make a build that logs more.

Unfortunately, I'm not sure how to reproduce the problem since I've already fixed it. What I can tell you, in case this is helpful, is some details before the problem occurred:
(1) The collection I exported existed before I installed the BBT add-on;
(2) In the process of learning how to use BBT, I exported the collection a few times using the wrong output (and I hadn't changed the citekey default pattern yet);
(3) However, I can confirm, that when I discovered the problem I was having:

I had no other "automatic export" .bib files to update; I had deleted the "bad" .bib files, so I only had my correctly exported .bib file in Better BibTeX format; and
I changed the citekey pattern BEFORE exporting my collection.

doesn't matter
also doesn't matter
doesn't matter and

doesn't matter
wouldn't affect anything. Auto-export is just regular export but triggered by changes, and changing the pattern only affects references that are changed from that point on

If it is replicable at your end, changing the pattern (e.g. by adding a . at the end) and refreshing the references should kick off auto-export but the updated auto-export would not have the . at the end. That seems to describe the situation you had in the initial description. Otherwise I really don't know.

Assuming fixed.

While my citation key formatting is [auth:lower][veryshorttitle:lower][year] and it is working perfectly both in Zotero UI and while using BBT "Better BibLaTeX" export option.
However the BBT "Better BibTeX" export option will generate the previous citation key formatting (the one before the one set actually). Weird doesn't it ?
Example, I played a bit with different key formatting:

[auth:lower][veryshorttitle:lower][year] + refresh all key
[auth:lower]_[veryshorttitle:lower]_x[year] + refresh all key. Result: better biblatex "barachant_riemannian_x2013", better bibtex "barachant_riemannian_2013"
[auth:lower][veryshorttitle:lower][year] + refresh all key. Result: better biblatex "barachant_riemannian_2013", better bibtex "barachant_riemannian_x2013"

How can be even possible? Am I the only one experiencing this issue ?

Please open a new issue. Since we never found what was the problem of #1030, I can't assume they're the same problem.


upgrade version to 1.9.0

What's the purpose of this PR
upgrade version to 1.9.0
Which issue(s) this PR fixes:
Brief changelog
upgrade version to 1.9.0
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Read the Contributing Guide before making this pull request.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[ ] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

Codecov Report

Merging #3876 (6a0d33f) into master (2781147) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3876   +/-   ##
=========================================
  Coverage     50.14%   50.14%
  Complexity     2464     2464
=========================================
  Files           483      483
  Lines         14919    14919
  Branches       1519     1519
=========================================
  Hits           7481     7481
  Misses         6910     6910
  Partials        528      528

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2781147...6a0d33f. Read the comment docs.


avenue datasets

Hi, thanks for your work, i am wondering could you share the avenue test dataset which you used for this project please<EMAIL_ADDRESS>or google driver. Thank you.

Hi, thanks for your work, i am wondering could you share the avenue test dataset which you used for this project please<EMAIL_ADDRESS>or google driver. Thank you.

Hi, thanks for your interest!
You can download the Avenue dataset here: http://www.cse.cuhk.edu.hk/leojia/projects/detectabnormal/dataset.html


Missing part of Mysql implementation

Asking for feedback :-)

Seems pretty good to me.
How about make the SchemaName, TableName and QuotedIdentifier() members of IBatchRunner?
I think this would improve the design of new runners to be consistent with yours.

I don't think so. The runner only features operational methods, so that the same instance of runner can be reused for more queries and is thread safe. If we make TableName member of IBatchRunner that means two threads (possibly on different connections) cannot run a batch statement together.
Also, QuoteIdentifier was private because each implementation knows its way to quote. Maybe Oracle does not quote table/column identifiers.
Makes sense? We might move to chat


FormattedText is generated without proper spacing

Describe the bug
The generated text for Myriad Pro Light Bold Italic has weird spacing.
Desktop (please complete the following information):

OS: Windows 10
Version CardMaker <IP_ADDRESS> A2

Screenshots

I was unable to reproduce exactly the same problem with the Access denied turning into Accessdenied (mashed together almost).
Couple of thoughts:

What is the @[HR,1] doing? (or does it play no role?)
When viewing the FormattedText in CardMaker are you at 1.00 zoom? Anything other than 1.00 zoom can look a little funny as the .NET renderer can run into imperfections.
What type of reference are you using? Maybe there's a bug with the quotes in that field or something strange.
One hack you can use is the push tag-- Example: Access<push=20>denied

HR is adding an image -- the horizontal line above the "ACCESS" text.
Here it is on 1.00. It does look a bit better, though a little close still. Also changed the quotes to standard " and it's the same.

This is what it's referencing:

@[HR] is just a shortcut to include an inline image with a standard size:
HR,

<ac></ac>

I'm going to be considering/testing an alternative approach to measuring text that may help. Not sure if it will work out though!

In the new alpha release you can change the measure method.
Change this via Tools > Settings... > String Measure Method (MeasureStringGenericTypoGraphic is the new one)
https://github.com/nhmkdev/cardmaker/releases/tag/v.<IP_ADDRESS>-unstable.v.a3
I am a little concerned because I was never able reproduce the really bad spacing you were seeing but this should look a bit better.

Nice! Thanks for that!


'Checkout and rebase to parent' actually hard resets to parent

Bug description

Please create a local copy of the following branch which is out of sync with develop.
Slide in this branch under develop.
checkout another branch.
right click on your local copy of reset-bug-instead-of-rebase in the machete tab and choose Checkout and Sync to parent by rebase.
if there are conflicts, please resolve them by using git add conflict\file\address and git rebase --continue in the Terminal.
After the successful rebase, please take a look at the log: The commit history is the exact same as the develop. In other words, rebase has behaved the same as git reset --hard develop on the reset-bug-instead-of-rebase branch.

It is already verified that git rebase develop on the same commit history, behaves correctly with no problem.

for me the following appeared after step 4

So this is indeed a bug. What happens when you press cancel? does it recover your pre-rebase commit history?

no change to the history happens to this step. the rebase would make the changes.

ok, it's good that at least by cancelling you can prevent the reset.

Hmmm so for clarity...

for me the following appeared after step 4

So this is indeed a bug.

Does it mean that for you @vzmerr, such warning dialog (it's from git4idea btw, not ours) does NOT appear? 🤔

Bump ☝🏻

Bump ☝🏻

it does.

Hmmm okay... so given that the user is warned about exactly what's gonna happen... can we consider the issue closed?

Assuming that can be closed


Microsoft.NetworkCloud 2024-06-01-preview for public

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Private azure-rest-api-specs-pr related PRs:
This version (2024-06-01-preview):
https://github.com/Azure/azure-rest-api-specs-pr/pull/18537
Intermediate private preview versions:
(2024-05-01-preview):
https://github.com/Azure/azure-rest-api-specs-pr/pull/18113
(2024-03-01-preview):
https://github.com/Azure/azure-rest-api-specs-pr/pull/17224
(2023-12-01-preview):
https://github.com/Azure/azure-rest-api-specs-pr/pull/16516,
https://github.com/Azure/azure-rest-api-specs-pr/pull/16856,
https://github.com/Azure/azure-rest-api-specs-pr/pull/17104

/azp run

/azp run

      "final-state-schema": "#/definitions/OperationStatusResult",

the version present here is the same as common types in v5 and is present in the previous apiversion.
Why not keep the same  ?
Same in other places where it change from previous api version.

Refers to: specification/networkcloud/resource-manager/Microsoft.NetworkCloud/preview/2024-06-01-preview/networkcloud.json:758 in 41af73d. [](commit_id = 41af73df7a7627aa100c4f618c11a72989bc4bcd, deletion_comment = False)

      "description": "The remaining appliance-based storage in GB available for workload use. Measured in gibibytes.",

this is GiB right? . property name having GB will be confusing to Customers as name is suggesting its in gigabytes.
Same in other places where gibibytes are being expected, but the name has GB in it .

Refers to: specification/networkcloud/resource-manager/Microsoft.NetworkCloud/preview/2024-06-01-preview/networkcloud.json:8215 in 41af73d. [](commit_id = 41af73df7a7627aa100c4f618c11a72989bc4bcd, deletion_comment = False)

present here is the same as common types in v5 and is present in the previous apiversion.

The version here includes additional properties that are not present on the common version, and shifts all async operations to use the extended version.  Because of SDK/CLI build considerations, and the need to expose the new properties, the common version is insufficient.  Please see discussion on the private repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/18537

      "description": "The remaining appliance-based storage in GB available for workload use. Measured in gibibytes.",

this is GiB right? . property name having GB will be confusing to Customers as name is suggesting its in gigabytes.
Same in other places where gibibytes are being expected, but the name has GB in it .
Refers to: specification/networkcloud/resource-manager/Microsoft.NetworkCloud/preview/2024-06-01-preview/networkcloud.json:8215 in 41af73d. [](commit_id = 41af73d, deletion_comment = False)

This change was made along the way in our private api changes. The use of the description to be specific is the compromise that we made, to minimize the breaking change.
Prior approved PRs for reference:
Microsoft.NetworkCloud 2024-06-01-preview by bryan-strassner · Pull Request #18537 · Azure/azure-rest-api-specs-pr (github.com)
Microsoft.NetworkCloud 2024-05-01-preview version by bryan-strassner · Pull Request #18113 · Azure/azure-rest-api-specs-pr (github.com)
[Microsoft.NetworkCloud] 2024-03-01-preview by bryan-strassner · Pull Request #17224 · Azure/azure-rest-api-specs-pr (github.com)
Microsoft.NetworkCloud introduction of 2023-12-01-preview API changes by bryan-strassner · Pull Request #16516 · Azure/azure-rest-api-specs-pr (github.com)
Microsoft.NetworkCloud 2023-10-01-preview API Introduction by bryan-strassner · Pull Request #14822 · Azure/azure-rest-api-specs-pr (github.com)

This approved PR is being held for merging until software releases are in place to properly support it ~ 2024-08-20

/azp run


[proposal] Use illuminate/http instead of the Guzzle client

This package looks promising to implement API SDKs.
I was thinking about testing requests with this package - would make sense to use illuminate/http as it can be mocked internally without having to re-write mocks within this package.
Http::fake([
    'https://forge.laravel.com/*' => Http::response(['foo' => 'bar'], 200, $headers),
]);

$request = new GetForgeServerRequest(serverId: '123456');

$response = $request->send();
$data = $response->json();

I might as well submit a PR to make this change, but that would leave a lot of changes (perhaps). 🤔

Thanks for the suggestion, but I don't want Saloon to use the Http facade as  I was going to add the same testing functionality in the sammyjo20/saloon-laravel package using the service container. I really like how illuminate/http works for testing. In fact I will aim to build it exactly the same way, but only for the Laravel package of Saloon.

I already have a plan in my head on how I'm going to do it. The service container is super powerful - so when you call Saloon::fake() it will queue requests and then I'll use a custom Guzzle handler which checks if there are any queues responses not yet fulfilled and it will return them instead.

I'm going to close this issue then. I'll be happy to give feedback during the development. I'm already planning to use it for some packages at @renoki-co


Possible locale next/prev button custom text bug?

Example - https://codepen.io/TincanPipPip/pen/f42dc4a71fba9dd153c553b721847f38?editors=0010
I'm not sure if this is just because I'm using an SVG as the custom text, but when doing this, only the area around the svg is clickable, the svg element itself isn't so the next/prev month event isn't fired.
Cheers
Harry

Hi,
I guess svg has not been used for these buttons before.
You can add this css, then the whole button will be clickable.
button.lightpick__previous-action > svg,
button.lightpick__next-action > svg {
    pointer-events: none;
}

Hiya,
Yeah I went a different route (but that's a really good idea), isn't a deal breaker, just wondered if it was a bug or not
Cheers
Harry


Update kustomization.yaml files to support Kustomize 5.x

Kustomize has deprecated a number of elements (such as bases), in version 5.x and higher there are lots of deprecation warning messages. However they have provided a mechanism to upgrade these kustomization.yaml files using: kustomize edit fix --vars
In this PR the following steps were performed:

Run the upgrade:

find . -type f -name kustomization.yaml -exec bash -c 'FN="{}"; cd "${FN%kustomization.yaml}"; kustomize edit fix --vars; cd -' \;

Fix the yaml linting (tabs and spaces):

Resolves #208 and #209

It would also be preferrable if the formatting didn't remove the extra space between the sections.  It isn't a common convention in most YAML but it is pretty common with kustomize.  It can make a huge difference in readability.

It would also be preferrable if the formatting didn't remove the extra space between the sections. It isn't a common convention in most YAML but it is pretty common with kustomize. It can make a huge difference in readability.

I'm going to redo with the following yamlfmt options to see if I can preserve the line breaks:
mkdir $HOME/.config/yamlfmt/ && touch $HOME/.config/yamlfmt/.yamlfmt

tee -a $HOME/.config/yamlfmt/.yamlfmt << END
formatter:
  type: basic
  indent: 2
  include_document_start: true
  line_ending: lf
  retain_line_breaks: true
  disallow_anchors: false
  max_line_length: 0
  scan_folded_as_literal: false
END

Yamlfmt docs: https://github.com/google/yamlfmt/blob/main/docs/config.md#basic-formatter

I know I'm coming to this a little late... but why don't we script the creation of the catalog from the source of truth instead of manually creating entries?
See #213

Thank you very much, @carlmes for this. Let's move forward with this.

@codekow The idea of a script is great. Thanks for that contribution. I've reviewed your PR; merging this one created merge conflict on yours, please rebase and address outstanding comments.
@carlmes I made a quick check throughout the repo, and it seems we still have some outstanding items to resolve https://github.com/redhat-cop/gitops-catalog/issues/208 and https://github.com/redhat-cop/gitops-catalog/issues/209
Would you like to tackle them as a continuation effort of this PR?
Thanks


[backport] Add APIs for creating NumPy arrays backed by pinned memory

Backport of #4870

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit fe98d91b7951d762a5c54bb331544c3e65d6e16f, target branch v9) succeeded!


ERR_SSL_PROTOCOL_ERROR - On-demand TLS

(Are you asking for help with using Caddy? Please use our forum instead: https://forum.caddyserver.com. If you are filing a bug report, please answer the following questions. If your issue is not a bug report, you do not need to use this template. Either way, please consider donating if we've helped you. Thanks!)
1. What version of Caddy are you running (caddy -version)?
Caddy 0.9.3
2. What are you trying to do?
Add the vhost "*.mysite.com" with on-demand tls set up
3. What is your entire Caddyfile?
#pi3.myddns.me {
#	root firstsite/
#	ext .html .htm .php
#}

*.raspbi.tk:https {
	tls {
		max_certs 1024
	}
	errors {
		404 error_pages/404.html
	}
}

assets.raspbi.tk:https {
	root raspbi_assets/
	ext .html .htm .php
	errors {
		404 ../error_pages/404.html
	}
}

raspbi.tk:https {
	root homepage/
	fastcgi / <IP_ADDRESS>:900 php
	ext .html .htm .php
	errors {
		404 ../error_pages/404.html
	}
}

firstsite.raspbi.tk:https {
	root firstsite/
	fastcgi / <IP_ADDRESS>:9000 php
	ext .html .htm .php
	errors {
		404 ../error_pages/404.html
	}
}

status.raspbi.tk:https {
	root status/
	fastcgi / <IP_ADDRESS>:9000 php
	ext .html .htm .php
	errors {
		404 ../error_pages/404.html
	}
}

php.raspbi.tk:https {
	root phptest/
	fastcgi / <IP_ADDRESS>:9000 php
	ext .html .htm .php
	errors {
		404 ../error_pages/404.html
	}
}

4.
In my home folder ther's a folder called "web_server"
from a terminal in that directory: sudo ./caddy
I think it's worth mentioning that I'm with optus and they block port 80.
5. What did you expect to see?
The 404 error page when I went to any subdomain that wasn't set up.
6. What did you see instead (give full error messages and/or log)?
Some browsers just took a while to load eventually and said there was a problem. Others took a while to load and eventually gave the error "ERR_SSL_PROTOCOL_ERROR" (Screenshot from chrome here)
7. How can someone who is starting from scratch reproduce this behavior as minimally as possible?
Maybe try making a * entry in your dns settings and the creating a *.yoursite.com vhost with on-demand tls

If port 80 is blocked, then Caddy won't be able to obtain certificates when it uses the HTTP challenge, resulting in protocol errors (because there is no cert available to send to the client). You'll have to open port 80.

I set the port to 443 on each vhost first to get the certificate, that way it only tries port 443. After, when I have got the certificate, I change it to https. It works. So I tried changing *.raspbi.tk:https to *.raspbi.tk:443. It didn't work. I tried changing ALL vhosts to port 443, because that's what they should be on anyway. it sill isn't working.

The choice of challenge is random, so your experiments were just lucky. ;)

Oh, I didn't relize. is there any way to specify wich challenge to use?

There isn't... unless you use the DNS challenge. Mostly because there hasn't been a need. Websites generally have access to ports 80 and 443. I guess we could look into adding this feature, however... I'm not sure how it would work and keep it congruent with the dns challenge configuration. In other words:
tls {
    challenges http tls-sni
}

(specifying both is the same as the default) doesn't apply to the dns challenge because there's a separate dns subdirective for that. I kind of hate having special cases...

I don't quite understand. How would I use the DNS challenge?


Txn Label - Auto override

App version: v0.1.92
There are 2 wallets: Pikachu and Vegeta.

Create a receive address in Vegeta. Let's call it VAddr1
Send sats from Pikachu to VAddr1 and label the Txn 'TxPSend1'
In Vegeta, set the txn label as 'TxVRcv1'

Wallets looks as below:

NowSend sats again from Pikachu to VAddr1 and label the Txn 'TxPSend2'

In Vegeta, set the txn label as 'TxVRcv2'
5.1 Before labeling

5.2 Immediately after labeling

5.3 After a refresh

The label 'TxVRcv2' overrides the label 'TxVRcv1' of the first transaction.

Current behaviour of labeling:
Tx will inherit the address label. (we should make it so that if tx label is set, do not inherit from the address)
If address label is not set, it will inherit tx label, other wise changes in tx label will not affect address label.

Needs review. We have made some fixes to label inheritance.


Interpolate All option

Add a toggle to the interpolate button so that all gaps in a track can be filled at once rather than scrolling to the individual gaps to fill in one at a time.

So if you had a box moving from the bottom left to the upper right, hitting this button (or maybe a combination of keyboard buttons) would take all of the frames in between and create a keyframe at the interpolated spot?

I am more talking about when doing annotation editing on previously
generated tracks that have lots of gaps.
On Fri, Dec 15, 2023 at 12:22 PM Bryon Lewis @.***>
wrote:

So if you had a box moving from the bottom left to the upper right,
hitting this button (or maybe a combination of keyboard buttons) would take
all of the frames in between and create a keyframe at the interpolated spot?
—
Reply to this email directly, view it on GitHub
https://github.com/Kitware/dive/issues/1394#issuecomment-1858310148, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AVYLKB63YP7YV3DAGBGU4F3YJSIOLAVCNFSM6AAAAABATMF5I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGMYTAMJUHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Log-likelihood doubt

Hi,
I have some doubts on the likelihood estimation performed by the function def get_logprob2(self, x, means, variances): at line 77 in mbcd.py file.
From the comment at line 76 the variable log_prob should have [num_networks, batch_size] size but the result of line 77 is a scalar. The following lines(80) assume that the result is a matrix,
76    ## [ num_networks, batch_size ]
77    log_prob = -1/2 * (k*np.log(2*np.pi) + np.log(variance).sum(-1) + (np.power(x-mean, 2)/variance).sum(-1))  # [1,]
78
79    ## [ batch_size ]
80    prob = np.exp(log_prob).sum(axis=0)
81
82    ## [ batch_size ]
83    log_prob = np.log(prob + 1e-8)  # Avoid log of zero

Is that a problem?
Furthermore, I want to ask you some clarification about the var_mean formulas at line 85 and 86.
In the code there are two formulas which leads to different results.
85    var_mean = np.var(means, axis=0).max(axis=-1)
86    var_mean = np.linalg.norm(np.std(means, axis=0), axis=-1)

Which of the two is the right one to use?
Thank you in advance

Hi,
Sorry for the confusion, these comments came from the method _get_log_prob of file models/fake_env.py, which operates over batches of transitions.
This get_logprob2 method operates over only the current experience transition (batch_size = 1), so it is correct that the outputs are scalars. Ps: the .sum(axis=0) in line 80 is actually doing nothing here.
Regarding var_mean, these are different uncertainty estimation methods. The one used in the paper is the uncommented one.
var_mean = np.linalg.norm(np.std(means, axis=0), axis=-1)
This is computing the standard deviation of the ensemble predicitions (i.e. how different/disagreeing are the predictions of each ensemble member) over each state dimension, and then computind the norm of this vector.

Thank you very very much for the answer


Update README.md to match solution

The readme is missing the line:
<div class="centered">

as well as the indentation that are present in the code editor solution.
this can cause a slight confusion while following the tutorial

thank you!


dependency (?) error (lodash/lang/isString)

I've done npm install react-color --save - it saved react-color version ^1.3.4 (based on package.json). Then, when I try to build my app with browserify (via gulp) it fails with following error message:

events.js:72
throw er; // Unhandled 'error' event
^
Error: Cannot find module 'lodash/lang/isString' from '/home/[...]/node_modules/react-color/modules/react-material-design/lib/components'
at /home/[...]/node_modules/browserify/node_modules/resolve/lib/async.js:46:17
at process (/home/[...]/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)
at ondir (/home/[...]/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)
at load (/home/[...]/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
at onex (/home/[...]/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
at /home/[...]/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
at Object.oncomplete (fs.js:107:15)

Software versions:

browserify - 11.0.1
gulp - 3.9.0
npm - 2.14.12
node - 0.10.25

This error is because I am using the lodash babel plugin. I am in the process of reverting it.

This has been fixed in<EMAIL_ADDRESS>


Add an option to serve index.html for the homepage

This adds a setting to automatically serve the homepage at the root url of the domain from an index.html file.
It adds the SFP_HANDLE_HOMEPAGE thats defaults to False to not interfere with the current behavior.

Hi @synw, thank you for the work you've done here. I appreciate it, and I'm sorry to take so very long in giving you feedback.
I really don't want to change the name of the package for this project. Additionally, even tho there have been not commits in a while, this project is far from dead. It's in use in many places, and still works well.
I'm happy to pull your edits to allow serving index.html files, but I'll do so without changing the project name.

Hi. I changed the name after some time because of the lack of response, so I decided to maintain my own fork that's why. I can pr with just the index modification if you want. If this module is maintained I don't need a fork.
I also made the doc a little more simple. Would you be interested by this?

Sure, I'd also consider any changes to the docs, as well.

I'm closing this as the requested feature (ability to use an index.html template) has been added in #8.


evm_transition_tool: Add execution-specs, ethereum-spec-evm

Brings back support of using ethereum-spec-evm transition tool to fill tests.

Seems to work nice in combo with #204.

Added doc. It's a bit hidden under "execution-spec-tests/library/evm_transition_tool/#evm_transition_tool.ExecSpecsTransitionTool", but at least we can point people to it, if need be.


Add remote_static_key to noise state machine artifact

Why is the remote_static_key optional?

Since it is not present in all possible handshake patterns

Could you merge this and make a new release?


Upgrade Soundcloud to V2 & new event-bus detection

New Soundcloud event-bus detection cycles through webpack modules to find the module with the correct functions instead of relying on the module number which will change each time they recompile the module. Also upgrade to V2 with getTrackArt  and getUniqueId methods included.
Should replace PR #645 (tried to fork that PR but couldn't).
ref #643

Much better :+1:

Scrobbling is perfectly fine. We even gained track art!
I got 2 console logs :
starter.js:52 Web Scrobbler: Connector.playerSelector is empty. The current connector is expected to manually detect state changes
starter.js:14 starter already loaded

They might be normal tought.
@david-sabata What's the use of those?

@AltarBeastiful The first notice is more for developer reasons to indicate that the connector is using a non-conventional route of binding audio events. Normally it would be binding to the 'player' and watching for modifications but in this instance @Paszt has bound to the SC event bus.
The second notice  is because of the controller has already been started. Perhaps this is something we can avoid doing? @Paszt opinions?

@inverse: I don't have a great understanding of the web-scrobbler core js, but I've just traced back the error.  It originates with the chrome.tabs.onUpdated event.  According to the docs, a tab status can be loading and complete.
I don't think it's anything in the connector but instead something different about soundcloud's website.

Great job, thanks!

:+1:


Target profile page rewrite: Create Bibliography detail views

Use Cases

As a user of the Platform, I want to see a list of publications from PubMed that have been text mined for my target of interest.

As a user of the Platform, I want to explore the underlying graph of the different terms and concepts that are connected and related to my target of interest so that I can access more relevant publications.

As a user of the Platform, I want a visual cue to know what terms and concepts I have selected as I browse the knowledge graph built from text mining PubMed abstracts.

As a user of the Platform, I want to see the abstract of a specific publication along with the terms and concepts that have been mined from the abstract.

As a user of the Platform, I want to see articles that are similar to one that I am interested in or already familiar with.

As a user of the Platform, I want to have a link to view the full-text of a given article.

Detail Views
View when user first loads detail view

Full-size version
View when user has clicked one of the buttons to filter the list by a specific term

Full-size version
View when user has clicked the + Show abstract button

Full-size version
View when a user has clicked the + Show similar articles button

Full-size version
Design and Interaction Notes

For the detail view description, please use the following text:

Scientific literature on GENE-SYMBOL. The list of publications is generated by text mining PubMed abstracts with Natural Language Processing (NLP).

Please copy the existing functionality offered in the Platform: showing 10 publications when the detail view first loads; including a dropdown to allow users to filter papers by various concepts/terms/entities; and providing buttons with individual terms that users can toggle as they explore the underlying knowledge graph built by LINK.

Please colour the concept/term buttons in Open Targets Purple - #7b196a. When a user has selected a term, please colour the button white and the font and close button in Open Targets Purple - #7b196a.
Please also include a button at the bottom of the list of publications to allow the user to load more publications - please colour this button in Open Targets Purple - #7b196a with white font.

When a user clicks the + Show abstract button, please change the text of the button to - Hide abstract, please show the abstract of that paper, and please highlight the Gene, Disease, Drug, and Target and disease terms and concepts similar to how it is currently done in the Platform.

For this implementation, please update the colours to keep in line with the Open Targets brand palette:

Concept/Term/Entity
Outline colour
Background colour

Gene
#BC8CB5
#E3D1E2

Drug
#9CCCA6
#D8EDDC

Disease
#E7B1A0
#F3E1D9

Target and disease
#82B0CA
#D0DDEB

*Note: these colours are not ideal from an accessibility standpoint; however, the colours and overall functionality of this detail view have been marked for review pending further clarification of long-term development and support for LINK.

When a user clicks the + Show similar articles button, please change the text of the button to - Hide similar articles and please show the list of similar publications. Within the list, please hyperlink the title of the publication to EuropePMC and please colour the link in Open Targets Blue - #3489ca. Also, please bold the year of the publication.

Design Assets

Full-size mockups
Open Targets brand palette colour codes

This is done pending PR approval/merging


Update icons not shown anymore in GUI

After updating from 1.17 to latest (1.17.1-4) the update icons in the GUI.
This is shown now:

For this device with this state:

So now it is now possible to update from GUI.

Maybe try 1.18.1-1 and see how that behaves.


Short circuit IsNativeAddress for Chakra.dll functions when OOP

In case all code is not in prereserved code segment or on platforms where prereserved code segment is not available, stack walking requires RPC for each frame to check if an address is JIT code.
If an address is in Chakra, we know it isn't JIT code. A large majority of functions on the stack at any time are interpreter frames, so by checking this we dramatically reduce the frequency of these calls.
Improves Octane CodeLoad perf by 20% on ARM, bringing it back to par with in-proc perf.

:shipit:


fix: 5789 - catching database exceptions not supposed to happen

What

Due to approximate app versions using database version numbers back and forth, there are database incoherences in some app install.
That PR is a fix that prevents the app from crashing at startup.

Fixes bug(s)
Fixes: #5789

Codecov Report
Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 7.07%. Comparing base (4d9c7fc) to head (aaf3a05).
Report is 427 commits behind head on develop.

Files with missing lines
Patch %
Lines

...ages/smooth_app/lib/database/dao_osm_location.dart
0.00%
9 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5799      +/-   ##
==========================================
- Coverage     9.54%   7.07%   -2.48%
==========================================
  Files          325     411      +86
  Lines        16411   22243    +5832
==========================================
+ Hits          1567    1574       +7
- Misses       14844   20669    +5825

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you @g123k for your review!

Seems OK, but I wonder if we shoudn't add a reminder to remove this code in a few weeks, when new versions will be released

It doesn't hurt to have ugly code now and then, especially with non ambiguous comments.


Added logging to batch file.

Main changes:
Added logging to batch file.
Minor changes:
Added 1s timeout between verification.

Script will now output everything in log files. New log file after every device verification for easier overview.
Unique names for each log file based on date, time and amount of log files.

Hi Julian,
Really appreciate your continued work and improvements on this!  All great additions.  I uploaded a radio firmware version.  Would you mind also writing in some checks for this and running an update.  This should occur after the application and boot loader are verified just to be sure.
As long as we are in there too, it seems like people are running the script with their dongle connected.  I think that this is causing the HWID to report back 0.  It is pretty easy to detect dongles because their serial numbers do not begin with LHR.
I can approve this PR and then if you wanted to look into this?  It's ok to say no too, just seems like you are enjoying the development as well.
-Luke


DSF - Message Delete

If for some reason, the bot caches the a message to the DB and then deletes the message since it's a non-merch call, an Unknown Discord Message Error throws. The bot handles this but still looks in the DB to fetch the message ID but it is not found, since it is deleted.
To Do:

[x] On message deletion, check if that message ID is stored in the DB. If so, remove that entry.
[x] Same happens for @Merch Calls and other messages. In catch, remove from DB if can't find.

Fixed in #32
close #31


Fix: Module not defined while running tests

Description:

Tests are failing with error: Module not defined
Error coming from: https://github.com/Real-Dev-Squad/website-www/pull/611 which was merged before.

Screenshots:

Please refer this for help:
https://stackoverflow.com/questions/64914701/jest-module-not-defined

Please assign this to me, I would like to work on this


Release testing 1.9.0

Tested on commit ecc26309d37946dbd975a914dcff5b0dacf6d858
General

[x] Onboarding

[x] Import account flow works
[x] Creating account flow works

[x] Qr-Scan from home page:

[x] Scanning Contact navigates to contact and importing contact works
[x] Scanning Invoice navigates to send flow and send works:

[x] with invoice amount
[x] without invoice amount

[x] Send flow:

[x] manual flow works
[x] scanning invoice flow works:

[x] with invoice amount
[x] without invoice amount

[x] Contact Page:

[x] Adding contact manually works
[x] Add contact with contact qr-code works
[x] Add contact with invoice qr-code works
[x] Endorsing newcomer works
[x] Endorsing newcomer with reputable works

[x] Profile Page

[x] Add account works:

[x] With import account flow
[x] With create account flow

[x] Removing all accounts works

[x] Changing communities works.

Meetup Flow
This needs two bootstrappers on a rococo test community, and preferably three smartphones to streamline the process.

[x] Registering 2 bootstrappers and 1 newbie and performing meetup works. (This needs the rococo single councillor account to call next phase.)
[x] Claiming rewards works

[x]  early rewards payout in attesting phase
[x] regular rewards payout in next registering phase

[x] Registering 2 bootstrappers and a reputable and performing meetup works. (This needs the rococo single councillor account to call next phase.)

This occurred during testing, but then it suddenly disappeared again: #969


Cross Platform Primitive Types with Generics

Source/destination types
public class TestClass<T>
{
    public int A { get; set; }
    public T B { get; set; }
}

Source/destination JSON
With UWP/.NetCore:
{
    "$type": "AppTest.MainPage+TestClass`1[[System.Int32, System.Private.CoreLib]], AppTest",
    "A": 1,
    "B": 2
}

With .NET Framework
{
    "$type": "AppTest.MainPage+TestClass`1[[System.Int32, mscorlib]], AppTest",
    "A": 1,
    "B": 2
}

Expected behavior
Successful deserialization. Or the suggested fix of serializing primitives without the assembly name:
{
    "$type": "AppTest.MainPage+TestClass`1[[System.Int32]], AppTest",
    "A": 1,
    "B": 2
}

Actual behavior
Runtime Exception:

Newtonsoft.Json.JsonSerializationException: 'Error resolving type specified in JSON 'ConsoleApp3.Program+TestClass`1[[System.Int32, mscorlib]], ConsoleApp3'. Path '$type', line 1, position 81.'

Steps to reproduce

Serialize class with TypeNameHandling (Tested with TypeNameHandling.Objects)

 string serialized = JsonConvert.SerializeObject(a, new JsonSerializerSettings() { TypeNameHandling = TypeNameHandling.Objects});

Deserialize json file on a different .Net system
a. That is, .NETFramework if UWP/.NETCore, and vice versa.

object deserialized = JsonConvert.DeserializeObject(serialized, new JsonSerializerSettings() { TypeNameHandling = TypeNameHandling.Objects });

Stumbling on this issue porting my projects from NetFramework to Net5.
I'm surprised this is not a more high profile issue since this is probably happening to many people since the existence of NetCore. Any project using json serialization for messages between micro-services using different framework will encounter this on basic primitive types. #1378 offers a workaround, but it's not perfect, and also requires old NetFramework services to be updated to support the inverse (netcore to netframework).
Since the issue haven't moved since 2019, should I assume it's not in the plan to offer a transparent fix officially?

This repo is (almost) dead. Use System.Text.Json instead. It makes no sense for MS to improve this serializer.

As much as System.Text.Json is a nice initiative and faster and easier to use for basic projects, it is still missing many features so the switch can't be done "as is" for many project. Notably polymorphic deserialization (TypeNameHandling) as mentioned in this issue. Or PopulateObject(), or some other custom converters that needs to be implemented differently.

Yes, there is no parity in features yet. But at least with the appearance of net5 there are more green checkmarks in the second column - https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to?pivots=dotnet-5-0#table-of-differences-between-newtonsoftjson-and-systemtextjson

Yeah this issue is definitely going to be seen more and more when porting apps to .NET 5.
I'll share our temporary but not ideal solution was removing all instances of , System.Private.CoreLib and , mscorlib in the serialized text. If you want you could even check for levels of [[ ]] brackets.

I don't know what the status of JSON.net is, but I'd imagine it stay around as System.Text.Json gains more functionality, probably years. But feels weird debating whenever or not JSON.net will stay around in this issue thread.

@Dunge This issue occurred when serializing on .NET 5 and then deserializing on .NET Framework 4?

The value in $type is written and read by ISerializationBinder. You could write your own one to resolve these name values.
Alternatively you could wrap the default one (DefaultSerializationBinder) and do something hacky like a string replace on the type name. For example, replace mscorlib with System.Private.CoreLib.

potential workaround?
    AppDomain.CurrentDomain.AssemblyResolve += (sender, args) =>
    {
        if (args.Name == "System.Private.CoreLib")
        {
            return typeof(int).Assembly;
        }

        return null;
    };

@danebou Yes. Somehow, .NET Framework4 serialized strings with mscorlib can deserialize without issue in a .NET5 project, but not the inverse.
@SimonCropp This seems to be working for me. In any case, it's much simpler and cleaner than @arthurvaverko-kaltura workaround in #1378.
In my situation, the System.Private.CoreLib string would not appear on primitive (int, string). It would appear in generics as the issue mention, but also on types like List when TypeNameHandling = TypeNameHandling.All is specified.

@Dunge yeah we confirmed and rolled out the AssemblyResolve workaround

That's a far better solution. I'll close out my PR.

@danebou i didnt consider my suggestion a "fix", just a workaround. My preference would be that this scenario was supported OOTB

Ah gotcha. Yeah, I'm in favor of OOTB too. It at least seems like a cleaner solution. However, it might bring unexpected behavior to the user.

I'm not sure. I'm hesitant to hardcode behavior on assembly names. If it isn't automatically supported, at the very least the workaround should be added to the documentation.

@JamesNK is previously worked ootb, should it instead  be considered a bug in dotnet?

An alternative solution is to leave the assembly type name off when serializing.

I'll close out this issue. The workaround SimonCropp suggested is great.


RTL UI Support

Changing language to RTL lang did not change  to  RTL Layout  .

Hello
This library just handles the changing the app language without restart the app, you need to handle right to left by yourself, like adding localize files and other things.


Use of file_name and file_location [REPLACEMENT ISSUE]

The original issue
Id: 18
Title: Use of file_name and file_location

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @kbubnicki on Aug 28, 2020, 14:21
The file_location can be a path to a file within a data package or remote URL and does not have to end with a filename i.e. the example https://trapper.org/storage/resource/media/259024/file/ is correct as this is a proper/accessible URL (this particular one is fake of course).
file_name I would keep as this is just a very basic property and it is critically needed when the remote URL does not contain a file name (but it is still fully correct URL).
Then we can consider splitting file_location into file_path and file_url. Maybe this makes sense as you can potentially provide both (i.e. you have your file locally in a data package but it is also accessible online). @all ?

In GitLab by @peterdesmet on Aug 28, 2020, 14:27
Can you elaborate on:

[file_name] is critically needed when the remote URL does not contain a file name

Why is file_name so important?
Also pinging @yliefting: does the user absolutely need to know the name of the file? Or is the path and/or url to access it (which often but not always contain the file name) enough?

In GitLab by @kbubnicki on Aug 28, 2020, 14:46
You are right: file_name it is not critically needed when thinking about an enduser working with data (doing analysis, merging datasets etc).
It can be useful for importing data into different platforms. At least, I am sure it is important for importing the existing classifications into TRAPPER (as deployment_id and file_name give a unique combination in our case). But this is software specific and we can adapt TRAPPER (also see my comment in #10 ;).
In conclusion it is handy but not critical, you are right. It can be removed potentially.

In GitLab by @peterdesmet on Aug 28, 2020, 15:07
If useful, we can keep file_name around as a non-required term... but maybe we should see how far we get with just removing it.

In GitLab by @peterdesmet on Aug 28, 2020, 15:11
Regarding path and url:
If we look at the data package (resource) specs as a guidance, (data) files are referred to by the property path (https://specs.frictionlessdata.io/data-resource/#path-data-in-files) which is of the form url-or-path. In old examples, one could use path OR url (not both): https://frictionlessdata.io/data-package/#resources, but it seems url has been deprecated in favour of path which can either be local or http.
One issue with using path and url for files is that you have to define that ONE OF BOTH is required and that both are allowed to be populated. Note sure how to encode that in the schema.

In GitLab by @yliefting on Aug 28, 2020, 15:34
I don't think the filename is absolutely required as long as there is a unique identifier and path to it. That can be a local path or URL, depending on the purpose of the exported data package: analysis (URL) or archival (relative path in package).

In GitLab by @peterdesmet on Aug 28, 2020, 15:38
Ok, so @yliefting you would only include one term for path/url, i.e. not supporting the sharing of a local path AND url? That definitely makes it easier to define, I was just wondering if there is a use case for sharing both?

In GitLab by @yliefting on Aug 28, 2020, 15:46
Yes, I would make this dependent on whether or not the assets are part of the package. IF there are no assets, you expect to see an URL and if they are in the package you expect a local path. Having both is ok, but a package with assets meant for archival means the original URL's will most likely stop working at some point. Otherwise you would not archive the data in a repository.

In GitLab by @peterdesmet on Aug 28, 2020, 15:56
Ok, I'm curious about @kbubnicki take on this, but it does make things easier and is in line with data package. I would name the field path or file_path then.

In GitLab by @kbubnicki on Aug 28, 2020, 16:53
Ok! I am fine with one term for path/url which is context-dependent (originally file_location was supposed to work exactly the same way). But what about keeping file_name as an optional field (for url case)?

In GitLab by @peterdesmet on Aug 29, 2020, 15:27
If it helps certain use cases, then I have no objection adding file_name as an optional term. We would have to indicate clearly to the user that the full path to the file should be in file_path, and that it is not file_path + file_name = full path.

In GitLab by @peterdesmet on Aug 31, 2020, 17:19
mentioned in commit b172b07589fa560eb9245be3007fea3badb3c6db

In GitLab by @peterdesmet on Aug 31, 2020, 17:26
mentioned in merge request !4

In GitLab by @peterdesmet on Sep 2, 2020, 15:22
Consensus is:

file_path: full path to file as a url-or-path (required term). This is an OR situation: either a local path (e.g. archived package) or a full URL (hosted images).
file_name: convenience term with name of file (optional term)

In GitLab by @kbubnicki on Sep 3, 2020, 00:41
mentioned in commit 1cf8d960d276ce21e6b3f2f75e918b241f04545d

In GitLab by @kbubnicki on Sep 3, 2020, 00:46
mentioned in merge request !9

In GitLab by @peterdesmet on Sep 4, 2020, 13:33
Implemented in !9.


update minikube startup instruction

minikube enables RBAC by default as of v0.26.0; hence,
it is not needed to add the extra-config override
See https://github.com/kubernetes-incubator/service-catalog/pull/2365/files/9b5f7c1ebd632b040482013a42c662bd245802e1
Signed-off-by: Shawn Zhou<EMAIL_ADDRESS>
What this PR does / why we need it:
It helps users getting minikube running correctly for testing cert-manager builds.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

Thanks for this 😄
/ok-to-test
/lgtm
/approve


Add Windows Support

Windows works well with this node module, unless it comes to the issue of not finding the file, not even in the root.
https://github.com/christkv/require_optional/blob/c11c4ec54c29d9f5b8a335db379a4670ceeb6cfb/index.js#L16
This line checks if the loop has arrived at the root of the filesystem and stops there, BUT it checks if it's the root of a LINUX Filesystem, if it's a Windows filesystem it loops forever and doesn't stop.
A fix to this problem would be using a path.parse on the location, and then comparing the location with the root location of the parsed location.

Seems like there is a fork already for this


Clean up and better example

This simplifies the file structure and updates the processing examples from the ISCN4 queued data.
Thoughts?

Changes seem sensible.


Document the best way how to install the plugin

Is this plugin working?
What's the recommended way of installing the plugin with a Mattermost Docker installation?
Or do you maybe even have an example compose file or Ansible role that can be used?
PS: I guess it would also make sense to add it to the Mattermost marketplace, doesn't it?

Hi @alexanderadam. Unfortunately the plugin has not yet reached a usable state and the development is currently on hold for an undetermined duration of time. You are welcome to fork it and turn in into something useful though ☺


Minor Formatting Changes

…be as they'll break compatibility)

Codecov Report

Merging #38 into master will decrease coverage by 0.02%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   21.83%   21.81%   -0.03%
==========================================
  Files          67       67
  Lines        3558     3558
==========================================
- Hits          777      776       -1
- Misses       2712     2713       +1
  Partials       69       69

Impacted Files
Coverage Δ

server/storage/bdb/entitlement.go
43.96% <ø> (ø)
:arrow_up:

server/web/server.go
20.72% <ø> (ø)
:arrow_up:

shared/types.go
73.52% <ø> (ø)
:arrow_up:

server/web/file_management_task.go
0% <ø> (ø)
:arrow_up:

shared/hashcat_types.go
100% <ø> (ø)
:arrow_up:

server/web/task_management_delete.go
0% <0%> (ø)
:arrow_up:

server/storage/bdb/storage.go
60.86% <100%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71bd3e4...deb82da. Read the comment docs.


Memory problem in using LazyFrames

Hi~
I am trying atari_wrappers.py in other place and I checked the usage in deepq.py and replay_buffer.py.
https://github.com/openai/baselines/blob/3301089b48c42b87b396e246ea3f56fa4bfc9678/baselines/deepq/deepq.py#L279-L284
https://github.com/openai/baselines/blob/3301089b48c42b87b396e246ea3f56fa4bfc9678/baselines/deepq/replay_buffer.py#L36-L41
It seems the memory(RAM) will still increase fast when I use LazyFrames.
Does it need to make a deep copy on the Lazyframes object before convert it to the numpy array? Or the replay buffer will store the LazyFrames whose self._out has been concatenating several numpy arrays. (more RAM)
https://github.com/openai/baselines/blob/3301089b48c42b87b396e246ea3f56fa4bfc9678/baselines/common/atari_wrappers.py#L208-L212
Like this:
action = act(np.array(copy.deepcopy(obs))[None], update_eps=update_eps, **kwargs)[0]

and
obses_t.append(np.array(copy.deepcopy(obs_t), copy=False))
obses_tp1.append(np.array(copy.deepcopy(obs_tp1), copy=False))

I would also like to know the answer to this if anyone knows?

I think it can simply solve by just using out instead of self._out if you don't really need it.


Dimension unit tests

A set of unit tests that test most of the API.
Also 2 fixes for dimension proxy in plaid-utilities.

These tests will never be able to run in Jenkins. Where to put them?


update to make operating system independent

-Update various paths to use Path.DirectorySeparatorChar
-Update various calls to ffmpeg.exe and ffprobe.exe to only use .exe if on windows
-Update various calls to ffmpeg.exe and ffprobe.exe to only add target "x86" or "x64" when running within windows
--Added comments to readme for test results for mac and ubuntu and their versions of ffmpeg used in testing

Published: https://www.nuget.org/packages/FFMpegCore/1.0.8


Prefixes on success/error/info messages or not?

Should we use prefixes on success/error/info messages, like Core and Essentials does, or should we make the plugin as similar to Bukkit's WorldEdit as possible, and use the current pink and red messages? What do you think?

Well, I'm trying to make it look as much as the bukkit version of WorldEdit so that people have a familiar feeling when using it, so I want the pink/red messages.
Also, I really don't like the succes/error/info messages, and I still have no idea why we even implemented it.

Okay, thank you for the answer and explanation.
What is wrong with the success/error/info messages? Is it the style, are they unnecessary, or something else?

I think the prefixes really clutter up the screen, and since MCServer has so many things to configure not many people will notice that you can disable the prefixes.
I think a simple SendMessage function was enough. If you make the color red, then it's already obvious for me that something is wrong. And if a plugin developper really wants to create those prefixes then it's really easy to create them for yourself by just adding this somewhere in the source file:
function cPlayer:SendMessageFatal(a_Message) self:SendMessage(cChatColor.Rose .. "[INFO]" .. cChatColor.White .. a_Message) end
-- other functions..


[Chip] When used as Popover trigger, focus not returned upon closing

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

If you use a Chip as the trigger for a Popover (e.g. in place of Button in the Simple Popover demo), then focus is not correctly placed on the Chip when you close the Popover. Or, more accurately, it would seem that focus is first placed on the Chip and then it is immediately lost (placed on body).
Expected Behavior 🤔

Focus should be correctly placed on the triggering Chip upon closing a Popover. In other words, Chip should behave the same as Button, in this regard.
Steps to Reproduce 🕹

Sandbox: https://codesandbox.io/s/material-demo-forked-8q981?file=/demo.tsx
Notes on Sandbox:
Created by forking sandbox for https://material-ui.com/components/popover/#simple-popover.
Only changes:

Change Button to Chip

Change HTMLButtonElement to HTMLDivElement

Add onFocus and onBlur props to the trigger (Chip) and Popover, to log each event

Steps:

Open sandbox
Open console of sandbox env
Focus Chip

Note console logs Chip focus

Press Enter to open Popover

Note console logs Chip blur, then Popover focus

Press Esc to close Popover

Note that the console logs in this order:

Popover blur
Chip focus
Chip blur ⬅   this is the issue; it shouldn't happen

Context 🔦

Given that both Chip (when "clickable") and Button both render a ButtonBase, which seems to handle all focus-related concerns, I'm not sure why the behavior is different.
If there is a userland workaround (perhaps using ButtonBase's action?), that would be acceptable.
Or, if you can point me toward what needs fixed, I'm happy to submit a PR.
Your Environment 🌎
Confirmed issue in latest Chrome, Chrome Canary, Firefox, and Safari on MacOS.

`npx @material-ui/envinfo`
  System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 86.40 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.19.2 - ~/.yarn/bin/yarn
    npm: 6.14.11 - ~/.nvm/versions/node/v14.16.0/bin/npm
  Managers:
    Homebrew: 2.7.5 - /usr/local/bin/brew
    pip3: 20.3.3 - /usr/local/bin/pip3
    RubyGems: <IP_ADDRESS> - /usr/bin/gem
  Utilities:
    Make: 3.81 - /usr/bin/make
    GCC: 10.14. - /usr/bin/gcc
    Git: 2.30.0 - /usr/local/bin/git
    Clang: 1<IP_ADDRESS> - /usr/bin/clang
    Subversion: 1.10.3 - /usr/bin/svn
  Servers:
    Apache: 2.4.34 - /usr/sbin/apachectl
  Virtualization:
    Docker: 20.10.2 - /usr/local/bin/docker
    VirtualBox: 6.0.14 - /usr/local/bin/vboxmanage
  IDEs:
    Emacs: 22.1.1 - /usr/bin/emacs
    Nano: 2.0.6 - /usr/bin/nano
    VSCode: 1.53.2 - /usr/local/bin/code
    Vim: 8.0 - /usr/bin/vim
    Xcode: /undefined - /usr/bin/xcodebuild
  Languages:
    Bash: 3.2.57 - /bin/bash
    Perl: 5.18.4 - /usr/bin/perl
    PHP: 7.1.33 - /usr/bin/php
    Python: 2.7.16 - /usr/bin/python
    Python3: 3.9.1 - /usr/local/bin/python3
    Ruby: 2.3.7 - /usr/bin/ruby
  Databases:
    SQLite: 3.24.0 - /usr/bin/sqlite3
  Browsers:
    Chrome: 88.0.4324.192
    Chrome Canary: 91.0.4435.0
    Firefox: 85.0.2
    Firefox Developer Edition: 74.0
    Safari: 14.0.3
  Monorepos:
    Yarn Workspaces: 1.19.2
    Lerna: 3.22.1

I have simplified the reproduction and upgraded it to the latest version (v5.0.0-alpha.26): https://codesandbox.io/s/material-demo-forked-zcssl?file=/demo.tsx. I can reproduce

Reduce to just using Modal+Chip. Probably an issue with the TrapFocus since focus is shortly returned to the Chip on exit:
https://user-images.githubusercontent.com/12292047/125447523-d2bb9323-0588-484d-abf3-03a9e5a788c3.mp4
-- https://codesandbox.io/s/chip-trapfocus-wzhfl?file=/demo.tsx

This was fixed in Material UI version 6 in #41578 as a breaking change. Checkout the migration guide: https://mui.com/material-ui/migration/upgrade-to-v6/#chip.


Export MeteorReduxActionName

Hi @zhongqf.
First of all, I'd like to say that this package is a life saver for me.
I don't know this is a correct way to do, but it works for me
import {
  ADD_TODO,
  REMOVE_TODO,
  COMPLETE_TODO,
  SET_TODOS
} from './../actions/todos';

import { Todos } from 'app/collections'
import { bindReactiveData } from 'meteoredux'

// Meteor actions (either via collections or methods) usually don't change UI state
// so it's normal to return previous state on most actions
function todos(state: Array = [], action: Object) {
  console.log('action', action.type);
  switch (action.type) {
  case ADD_TODO:
    Todos.insert({text: action.text, checked: false})
    return state

  case REMOVE_TODO:
    Todos.remove({_id: action.todo_id})
    return state

  case COMPLETE_TODO:
    Todos.update({_id: action.todo_id})
    return state

  case '@@METEORREDUX/CHANGED':
    return Todos.find({}).fetch()

  default:
    return state
  }
}

export default bindReactiveData(todos, () => {
  return Todos.find({}).fetch()
})

I'm using @@METEORREDUX/CHANGED to prevent unregistered actions triggering a fetch() and then a render() in components. I believe it would be better to export that name so I don't need to care about future changes.
Thanks

@tungv Thank you for using this package and sorry for the late reply.
I do not really understand why you need @@METEORREDUX/CHANGED to be exposed.
Do you want to prevent state changes only when the @@METEORREDUX/CHANGED action be fired?
But in your code above, every Todos.insert or Todos.remove will cause a @@METEORREDUX/CHANGED action to be fired.


Sync doc with kubectl help message

@pwittrock Not sure how the new style docs works /v1.5. Please tell me what to do with it.

/assign @pwittrock

Closing because it should targeted release-1.6 branch. Opened #2947.


Fix filter for getting product exports

1. Why is this change necessary?
Comparing the sales channel id for product export should be point on the selected storefront sales channel id instead.
2. What does this change do, exactly?
The current filter on the salesChannelId is not useful.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9493
Please use this issue to track the state of your pull request.

Hey @acris-cp,
thank you for your contribution! 💙
We've just merged your changes! :-)


HNSW and NSW do not return number of neighbours I need

Hello,
I'm trying to find large amount of neighbours for my data:
hnsw = nmslib.init(method = 'hnsw', space = 'angulardist')
hnsw.addDataPointBatch(train_features) # train_features 49950 х 322
hnsw.createIndex()

k = 1000

features_len = []
for i in range(test_features.shape[0]): # test_features 50 x 322
    features, distance = hnsw.knnQuery(test_features[i], k=k)
    features_len.append(len(features))
print(features_len)

Out:
[233, 210, 163, 204, 291, 202, 82, 208, 248, 166, 223, 261, 205, 225, 273, 218, 244, 184, 256, 230, 149, 260, 198, 292, 180, 294, 246, 234, 251, 273, 237, 271, 190, 217, 264, 241, 272, 251, 245, 213, 123, 123, 230, 143, 243, 230, 173, 228, 176, 238]

But I need 1000 neighbours!
Same thing happens using sw-graph. How can I fix it?

Hi @adtsvetkov I think currently it's not possible to meaningfully enforce that the number of candidates is always k.

Hm. I thought it is enforced in nmslib. I'd suggest to check if the data has duplicates, which might make algorithms fail.

@yurymalkov good suggestion, thank you. Yes, usually, there's little reason why we will get < K results. However, getting exactly K isn't enforced. It seems to be relatively easy to support this feature. However, I wouldn't do it right now, b/c it might have a performance impact (though with a perfect implementation it shouldn't). Also for this kind of data, bruteforce search could be fast enough.
I am closing this issue, it's a duplicate of #172. I will hopefully fix this someday, but not immediately.


Added additional key/value pair to UserExperience, "calendarDeferralUnit"

Resolves #481
In the higher education space a less aggressive approach is sometimes needed when it comes to update compliance. This is due mainly in part to years of culture in which many organizations had a very light touch approach to managing devices. The change proposed in this pull request would allow a greater flexibility with Nudge's user experience.
The current implementation of Nudge allows users in the "Regular Window Time" to bypass the approachingWindowTime and end up in the imminentWindowTime, because of this limitation, some organizations, mine own included, do not use the "Regular Window Time" at all and instead start our "Nudges" in the approachingWindowTime.
This pull request is meant to remedy this behavior.

I've changed the key to calendarDeferralUnit. It is no longer a bool but instead a string which takes "approachingWindowTime" or "imminentWindowTime" as inputs. Any other strings given to it will assume imminent.
This should allow me to be more flexible with this code should we ever add more window times (or remove them).


Investigate timing of BBCW

Seems like the timing for BBC World Service TV might be off... need to check the video for known timestamps and realign/re-encode if necessary.

As a side note, I think there's 15 minutes missing from the 24-hour encode of this channel as well.


The app is in a constant state of loading on the main menu where you view the anime you want to watch. Please fix, thank you.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Fixed Thank you for reporting the issue.


App Crash

The app crashes when the camera sensor is not available

Thanks, I've reproduced a crash with a device  without a camera and found where it goes wrong. Will do the fixes this weekend.