[SPARK-11425] Improve Hybrid aggregation

After aggregation, the dataset could be smaller than inputs, so it's better to do hash based aggregation for all inputs, then using sort based aggregation to merge them.

Merged build triggered.

Merged build started.

Test build #44698 has started for PR 9383 at commit 5707f5b.

Test build #44698 has finished for PR 9383 at commit 5707f5b.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44698/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44700 has started for PR 9383 at commit 764f540.

Test build #44700 has finished for PR 9383 at commit 764f540.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44700/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44708 has started for PR 9383 at commit 55c47ed.

Test build #44708 has finished for PR 9383 at commit 55c47ed.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44708/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44710 has started for PR 9383 at commit 752c8e7.

Test build #44710 has finished for PR 9383 at commit 752c8e7.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44710/
Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #44714 has started for PR 9383 at commit 0512f1e.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44712/
Test FAILed.

Test build #44714 has finished for PR 9383 at commit 0512f1e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44714/
Test FAILed.

Besides, as we discussed in #9067, should we add a configuration for turning on/off this feature? This feature may not always have performance gain.

Currently, the old one is broken, I'd to remove that one. The new should be as fast as the old one in worst case, I think we don't need a configuration for this.

Merged build triggered.

Merged build started.

Test build #44728 has started for PR 9383 at commit 28f84e1.

Test build #44728 has finished for PR 9383 at commit 28f84e1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44728/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44730 has started for PR 9383 at commit 6fde4d5.

Test build #44730 has finished for PR 9383 at commit 6fde4d5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44730/
Test FAILed.

After some benchmark, realized that using hashcode as prefix in timsort will cause regression in timsort and snappy compression (especially for aggregation after join, the order of records will become random). I will revert that part.
benchmark code:
sqlContext.setConf("spark.sql.shuffle.partitions", "1")
N = 1<<25
M = 1<<20
df = sqlContext.range(N).selectExpr("id", "repeat(id, 2) as s")
df.show()
df2 = df.select(df.id.alias('id2'), df.s.alias('s2'))
j = df.join(df2, df.id==df2.id2).groupBy(df.s).max("id", "id2")
n = j.count()

Another interesting finding is that Snappy will slowdown the spilling by 50% of end-to-end time, LZ4 will be faster than Snappy, but still 10% slower than not-compressed. Should we use false as the default value for spark.shuffle.spill.compress?(PS: tested on Mac with SSD, it may not be true on HD)

Merged build triggered.

Merged build started.

Test build #44820 has started for PR 9383 at commit 53dbdf2.

Test build #44820 has finished for PR 9383 at commit 53dbdf2.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44820/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44823 has started for PR 9383 at commit 2e341f5.

Merged build triggered.

Merged build started.

Test build #44830 has started for PR 9383 at commit 3864095.

Test build #44823 has finished for PR 9383 at commit 2e341f5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44823/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #1970 has started for PR 9383 at commit df44fc6.

Test build #44834 has started for PR 9383 at commit df44fc6.

Test build #44830 has finished for PR 9383 at commit 3864095.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44830/
Test FAILed.

Merged build finished. Test FAILed.

Test build #1970 has finished for PR 9383 at commit df44fc6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

ping @yhuai @JoshRosen

Test build #44834 has finished for PR 9383 at commit df44fc6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44834/
Test PASSed.

Currently, the old one is broken, I'd to remove that one.

@davies, are you referring to the old Aggregate1 interface or the old implementation of sort fallback here?

@davies, the block comment at the top of TungstenAggregationIterator is now out-of-date; do you mind updating it to reflect the new behavior?

@JoshRosen I meant the old implementation of switching, it's broken in master (not 1.5 branch), had not figured out the root cause.

Do you remember what the symptoms were? Just curious.

@JoshRosen When the grouping key is StringType, but no column in buffer, then got:
java.lang.UnsupportedOperationException
	at org.apache.spark.sql.catalyst.expressions.UnsafeRow.update(UnsafeRow.java:193)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificMutableProjection.apply(generated.java:40)
	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator.switchToSortBasedAggregation(TungstenAggregationIterator.scala:643)
	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator.processInputs(TungstenAggregationIterator.scala:517)
	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator.start(TungstenAggregationIterator.scala:779)
	at org.apache.spark.sql.execution.aggregate.TungstenAggregate$$anonfun$doExecute$1.org$apache$spark$sql$execution$aggregate$TungstenAggregate$$anonfun$$executePartition$1(TungstenAggregate.scala:128)
	at org.apache.spark.sql.execution.aggregate.TungstenAggregate$$anonfun$doExecute$1$$anonfun$3.apply(TungstenAggregate.scala:137)
	at org.apache.spark.sql.execution.aggregate.TungstenAggregate$$anonfun$doExecute$1$$anonfun$3.apply(TungstenAggregate.scala:137)
	at org.apache.spark.rdd.MapPartitionsWithPreparationRDD.compute(MapPartitionsWithPreparationRDD.scala:64)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:300)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:264)
	at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:300)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:264)
	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:73)
	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:41)
	at org.apache.spark.scheduler.Task.run(Task.scala:88)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:214)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)
15/10/28 23:25:08 DEBUG TaskSchedulerImpl: parentName: , name: TaskSet_3, runningTasks: 0

@JoshRosen @davies has a case to reproduce that problem

@davies: in the stacktrace that you posted, it looks like it's failing when trying to update a string column when extracting a partial aggregate result from an input row. What's confusing to me, though, is the fact that a string column in a partial aggregate result buffer should have prevented TungstenAggregate from being planned in the first place (see TungstenAggregate.supportsAggregate()). Do you think that there might be an input attribute binding error that's causing this (i.e. we mistakenly treat grouping columns as belonging to the partial aggregate result)?

I do think that the change in this patch makes sense, but I'd like to really get to the bottom of why the old code malfunctioned.

This failure could be reproduce by
sqlContext.range(N).selectExpr("id", "repeat(id, 20) as s").groupBy("s").max("id").count()

Maybe related to this
https://github.com/apache/spark/pull/9038/files#diff-b83a65c9afcef83e053ecc0afecba1a4R633

@JoshRosen The cause is that if the buffer is an empty one (e.g. we do not have agg function or all agg functions do not use any buffer slot), the initialInputBufferOffset is still 0 and when the key is a string, the following code will trigger the exception. Unfortunately, our test only use int columns as the key columns.
newMutableProjection(
  originalInputAttributes.drop(initialInputBufferOffset),
  originalInputAttributes)()

Maybe sqlContext.range(100000).selectExpr("id", "repeat(id, 20) as s").groupBy("s").agg($"s") is a better case.

What do you think about adding a dedicated regression test for that one case as part of a separate PR? I'll try that now.

Will add that into this PR, working on it.

I filed https://issues.apache.org/jira/browse/SPARK-11486 to describe the String aggregation bug.

Merged build triggered.

Merged build started.

Test build #44959 has started for PR 9383 at commit 6f3bb15.

@davies, @yhuai: I tried taking two sample regression test queries that you listed here and putting them into AggregationQuerySuite, which should automatically trigger spilling after a small number of records, but I wasn't able to reproduce the exception here. How did you get this to fail?
I want to make sure that the regression test that we add is actually capable of failing prior to this change.

So, you tried TungstenAggregationQueryWithControlledFallbackSuite and it did not fail?

I tried with master, it did failed with the sam exception:

[info] *** 1 TEST FAILED ***
[error] Failed: Total 6, Failed 1, Errors 0, Passed 5
[error] Failed tests:
[error] 	org.apache.spark.sql.hive.execution.TungstenAggregationQueryWithControlledFallbackSuite

There was a problem in my test-selection regex... trying again.

Yep, confirmed and reproduced. If we just wanted to address that bug, we could do something like #9447, but I think the broader set of changes here are a good idea.

Test build #44959 has finished for PR 9383 at commit 6f3bb15.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44959/
Test FAILed.

test this please

Merged build triggered.

Merged build started.

Test build #44972 has started for PR 9383 at commit 6f3bb15.

Test build #44972 has finished for PR 9383 at commit 6f3bb15.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44972/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #44997 has started for PR 9383 at commit fc5e052.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

@JoshRosen @yhuai pushed a refactor on this (reduce possibility of full GC by re-use the array in map), please take another look.

Test build #45001 has started for PR 9383 at commit 1c0c6c3.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45000/
Test FAILed.

Test build #44997 has finished for PR 9383 at commit fc5e052.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44997/
Test PASSed.

Merged build finished. Test PASSed.

Test build #45001 has finished for PR 9383 at commit 1c0c6c3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45001/
Test FAILed.

Test build #1978 has started for PR 9383 at commit 1c0c6c3.

Test build #1978 has finished for PR 9383 at commit 1c0c6c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #45062 has started for PR 9383 at commit 10d7169.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45060/
Test FAILed.

test this please

Test build #45062 has finished for PR 9383 at commit 10d7169.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45062/
Test FAILed.

Merged build triggered.

Merged build started.

LGTM pending jenkins.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45064/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #45078 has started for PR 9383 at commit b1f8a99.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45077/
Test FAILed.

Test build #45078 has finished for PR 9383 at commit b1f8a99.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45078/
Test PASSed.

Merging into master, thanks!


Network Loading Control API (hls.js) equivalent for Shaka Player

Have you read the Tutorials?
Y
Have you read the FAQ and checked for duplicate open issues?
Y
What version of Shaka Player are you using?
4.3.2
Please ask your question
Is there an equivalent to the Network Loading Control API found in hls.js with Shaka Player, see https://github.com/video-dev/hls.js/blob/master/docs/API.md#network-loading-control-api.
Basically we would like to implement a stop download on pause feature. Is there already an equivalent for this in Shaka Player? If yes what is the method that needs to be called?
Thanks

We don't have something exactly like that.  Instead, our loading is governed by the buffering configs:  https://shaka-player-demo.appspot.com/docs/api/tutorial-network-and-buffering-config.html
When bufferingGoal is met, we stop loading segments.  If it's not met, we load another segment.
So if you pause playback, we will continue buffering until the bufferingGoal setting is satisfied, then stop automatically.
Does this answer your question?

Thanks for your answer.We will work with this for the time being.


[10.x] Fix typo in signed URL tampering tests

In PR https://github.com/laravel/framework/pull/44254, @vr00 found a typo in some tests but it looks like no PR to update this was performed.
This PR updates tempered => tampered in the context of tampering with a signed URL, ensuring that it's no longer valid after being tampered with.
Let me know if I should retarget this.

Thanks!


Tsan is unhappy with engine::io::Socket

Running socket benchmarks (--benchmark_filter='socket*') produces this tsan output
socket_tsan.txt
Is it FP or is some bug actually lurking?

There also is this line here, although not related to Socket


HADOOP-17380 ITestS3AContractSeek.teardown closes FS before superclas…

Inside ITestS3AContractSeek the filesystem was getting closed before the
tests can execute their teardown method leading to the output log being
spammed with IOException messages.
Moving the order of operations around in ITestS3AContractSeek.teardown
so that teardown happens before closing the filesystem.
HADOOP-17380

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 35s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m  7s

trunk passed

+1 :green_heart:
shadedclient
14m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m 31s

the patch passed

+1 :green_heart:
shadedclient
17m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  8s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

80m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3012/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3012

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6bba494c21ba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b6d841e609d38b6460436e7466c2445aeb7be1a3

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3012/1/testReport/

Max. process+thread count
590 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3012/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks. Looks good.
Usual due diligence q: s3 endpoint and maven test options?

Of course! Tested with eu-west-1 and mvn -Dparallel-tests -DtestsThreadCount=8 clean verify without s3guard

Issue fixed in https://github.com/apache/hadoop/pull/2807

must have found and fixed it as I went along. never mind


Hi， a quesition about how to improve the accuracy about the model

Hello, now I can use my own images to make a SVM model,and then try to use this model to classify some test images, well I think the probability of every test image is not too bad(if I use 10 images per class to train a SVM model, I can get about 0.7 probability)
So are there some ideas to improve the SVM model's result or maybe another algorithm is better than SVM?
Any answer is so helpful to me
Looking forward your reply sincerely
Thx

You should implement multi-gpu, multi-machine yourself. Just a advice, TensorPack is a good way.


Should mark v0.2.15 as major update

Because of the root font-size changed, will may affect REM based design. People need to be notified.

Also when is v0.2.16 coming out? I feel like there should be a hotfix cause I need the margin mixins to work. (See https://github.com/picturepan2/spectre/commit/e1889c840e060b51e4b551a3e30f142ce4b9ec2b). It's a pretty big bug.

Today or tomorrow. I am adding some other fixes to it. Thank you.
Yan Zhu

From: Mitchell Huang<EMAIL_ADDRESS>Sent: Saturday, August 19, 2017 9:10:16 AM
To: picturepan2/spectre
Cc: Subscribed
Subject: Re: [picturepan2/spectre] Should mark v0.2.15 as major update (#257)
Also when is v0.2.16 coming out? I feel like there should be a hotfix cause I need the margin mixins to work. (See e1889c8https://github.com/picturepan2/spectre/commit/e1889c840e060b51e4b551a3e30f142ce4b9ec2b). It's a pretty big bug.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/picturepan2/spectre/issues/257#issuecomment-323490571, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAHtsWFwtMr09w8IP9BhAaTVaSx_TO3Xks5sZjX3gaJpZM4O7bO2.

@ostoc Is it better to upgrade to 0.3.x branch?

@picturepan2 from my experience the new REM is not compatible with old version, and I spend few hours to change my all REM in the whole project. I am up for 0.3.x branch :)

@ostoc Sorry for that. I learn a lesson from this update.
Do you think there is a way to upgrade this kind of core things without making any trouble to others? Any better place for publishing the important change?

I am making the next release: v0.3.1.

@huangbong v0.3.1 is released https://github.com/picturepan2/spectre/releases/tag/v0.3.1. The utilities bug has been fixed.

@picturepan2 awesome! thanks! can you publish to npm?  Appreciate the fast turnaround!

@huangbong Publishing. The bad network connection in Starbucks.

@huangbong Done.

@picturepan2 FYI, the builds on cdnjs don't have the margin fix in. It's still padding. https://cdnjs.com/libraries/spectre.css

Hi @picturepan2

Any better place for publishing the important change?

What about keep a changelog? ;)
BTW, great job. Thanks a lot.

@dgdavid Thank you. I will look on that soon.

The dist/spectre.css file needs regenerating to include the margin/padding utility fix

@jooldesign Trying to fix it again.

@jooldesign Successfully updated with v0.3.2.


CSS regex pattern matching fixes

Since there hasn't been a response in a while going to close this out


Namadillo: Querying all validators

We've moved to query all validators in order to simplify randomization, filters, etc. This PR only changes the endpoint used for it.

Closing this PR without merging in favor of #929


list known board and complete it

Add a feature to list known board (once it is used, it is registered)  and complete it on the command line.
Maybe lium dut info will also be able to add its board name to this boad list. But mostly, the name passed to the --board option will be added if the command succeeded.

Add a board.cache under .lium and update it if a command which gets --board option succeeded.

cros query boards


Added frontend route for new submission, added API endpoint for metad…

Added front end page for submitting a new post
Added API endpoint for scraping URL data
Added API endpoint for submitting new post

TODO:

Use real wallet address; I had a problem with this, I got an error when I tried to use currentProfile, because you guys are familiar with this code maybe you can see what I what doing wrong? See screenshot.

Screenshots:
Submit page

Submit page (error)

Submit page with preview

New submission

So it seems like this is a bug based on how we had the profile set up
previously + adding SIWE. When the profile was merged with the homepage and
the user connected their wallet, the profile component would go through the
process of adding the profile to the store. I have a feeling that because
the profile is a separate page now, that value isn't being filled unless
the user visits the profile page, which would explain why referencing
currentProfile on the submit page isn't working.
On Tue, Mar 8, 2022 at 3:10 PM Mike @.***> wrote:

@.**** commented on this pull request.
In packages/app/pages/submission/new.tsx
https://github.com/CabinDAO/dao-camp/pull/49#discussion_r822029614:

const NewSubmission = () => {

return new submission page;

const router = useRouter();
const { currentProfile } = useStore();

const [error, setError] = useState('');
// TODO: Use real wallet address
const [postData, setPostData] = useState({
_id: '',
title: '',
domainText: '',
url: '',
// postedBy: currentProfile.walletAddress,

I'm signed in with Metamask, so I think it should be available? In any
case, a user has to be logged in to view the submission page so I think we
can assume it's there?
—
Reply to this email directly, view it on GitHub
https://github.com/CabinDAO/dao-camp/pull/49#discussion_r822029614, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ2VCPSMNEBSE62ANB345HDU66XZNANCNFSM5QGUYBMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Project names allow seperators

micro:bit-support:4086
Makecode allows you to use a ',' seperator in the name of your project (project settings). The resulting .hex file that is downloaded cannot then be flashed to the micro:bit. Could the the use of a separator be prevented in the project name, fixed in the download or can users be advised of this in documentation?

If this is not fixed in alpha. Please reopen in pxt-microbit.

I have kept a tracking bug to validate: https://github.com/Microsoft/pxt-microbit/issues/906


Missing files

Hello. Thank you very much for your code. I had errors when run your code
python bus_operation.py
File "/home/osboxes/Desktop/SUMO_SpeedAdviosry_on_TSP/modules/OBUObject.py", line 3, in
import thesis.PhaseObject as PhaseObject
ModuleNotFoundError: No module named 'thesis'

Hello, super thanks for your report!
The error is caused by attempting to import a deprecated module.
I have fixed this. Now, "bus_operation.py" should run normally. Give it a try!


fix: objectContaining typing

closes https://github.com/vitest-dev/vitest/issues/3052

Sorry, I forgot to disable my formatter, should be better now


[CHORE]: Add all-contributors

: )

@all-contributors add @AllanRegush ideas

@all-contributors add @RascalTwo bug

@all-contributors add @Vyvy-vi design doc maintenance review

@all-contributors add @all-contributors docs

@all-contributors add @sayand0122 for ideas

@all-contributors add @nhcarrigan ideas docs

Nick's ISSUE set was used here as I found it fitting : )

@all-contributors add @MattIPv4 ideas

@all-contributors add @all-contributors docs

@all-contributors add @all-contributors docs

@all-contributors add @all-contributors docs

@all-contributors add @all-contributors docs

Psst - you don't have to keep a global issue open for this. You can ping all contributors to add someone on the PR/issue they opened :)

Psst - you don't have to keep a global issue open for this. You can ping all contributors to add someone on the PR/issue they opened :)

(I kept this open to add contributors for ideas, but I think I'll add them with a new issue or something) :+1:

(I kept this open to add contributors for ideas, but I think I'll add them with a new issue or something) :+1:

Or encourage them to share their ideas as an issue/feature-request - that way you keep the discussion tied to your repository

Or encourage them to share their ideas as an issue/feature-request - that way you keep the discussion tied to your repository


UnquotedServicePath.md

Hi Nickvourd,
I'm Ethan and i'm trying to run your troubleshooting to install the UnquotedServicePath.md --> https://github.com/nickvourd/Windows-Local-Privilege-Escalation-Cookbook/blob/master/Notes/UnquotedServicePath.md
but when i want to START the service i got this message:

any idea why?
Thanks for your support on this topic.

Hello man, Sorry for the delay. I need to check this.

Hello I think the reason that you are using Windows 11, try to use it on Windows 10


Probes failed when basic_auth is enabled

Version
2.0.1
Problem
Defining basic_auth config will fail liveness and readiness probes. Pods will keep getting killed.
Reproduction
Deploy with custom values file:
~ values.yaml ~
...
http:
  basic_auth:
    enabled: true
    username: <username>
    password_hash: <password_hash>

Liveness and readiness probes will fail with status code 401 (Unauthorized)
Notes
The probes probably need to check if http.basic_auth is configured and set <probe>.httpGet.httpHeaders accordingly.
Alternatively, the probes can be exposed to values.yaml so they can be customized.

Sounds like a good idea just exposing the probes directly in the values.yaml. I'll get a PR together to add this


Inline-Validation in Forms

🛠 Fixes Issue:
🛠 Fixes Issue #161 [FEATURE] Real-time validation in login and signup forms
closes #161
Discord username
Alfiya Siddique#0459
📷 Sample Output Video
https://github.com/Fenrir-04/Algo-Media/assets/86224794/ce4909e3-0022-4f3b-a730-4bfddd210561
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.
[x] I am a participant of GSSOC23

Request:
Please add gssoc labels on my current and merged PR #165

Hello @Fenrir-04
Please review this PR!

Hey @Fenrir-04 , please add gssoc23 labels. Otherwise, it is not counted.


feat: add delete account settings item

Description
As the title.
Test plan
An example flow is here - copy is outdated in this video.
Example of failure to revoke:
https://github.com/valora-inc/wallet/assets/20150449/6aab8db4-0e9d-46a5-9c06-ac512c76b2b2
Related issues
n/a
Backwards compatibility
Y

Two small things.
First the copy for the descriptions of reset and delete is very similar, should the delete copy include a mention of unlinking the phone number.
Second the modal served after completing the account delete references reset which could be confusing to users.

Duplicate descriptions
Reset Modal (After Delete Account)

Two small things. First the copy for the descriptions of reset and delete is very similar, should the delete copy include a mention of unlinking the phone number.
Second the modal served after completing the account delete references reset which could be confusing to users.
Duplicate descriptions	Reset Modal (After Delete Account)

hey @MuckT TY for the feedback!
the copy on the buttons is what was last suggested in slack - this is a new button label that we can also ship over the air updates for if there is a better suggestion. i do mention the unlinking of phone number in the bottom sheet that is launched on button press. i think that we shouldn't block this feature on this button copy.
the modal text is an interesting point, we can either create a new modal and separate the copy or continue to share the copy across the reset and delete flows. i want to limit the scope of this feature because of the time sensitivity (i had a look into making a new warning and there's navigation state that is shared in many places since the backup flow is involved, and those changes make this PR much harder to review and test). so i had a go at making the copy more sharable, not sure if i nailed it. i suggest shipping over the air copy that can be shared across the 2 flows, unless someone has a better suggestion now? i've been asking chatgpt all morning but i'm not really happy with any of the suggestions 😅


Feature Suggestion

If possible, adding the ability to modify how many pokemon are needed for bingo, so you could create a like 5x5 bingo card or smaller if you'd like.

Done in latest version


add Ukrainian language

Thanks for the PR. I'm on the road now, but will try to look at it in a few days!


If Multiple Language requested...

If I change from default English into other language, Siri will still use the accent of English, can you recommend a way to setup so that if I change Siri to French or Mandarin, maybe it will also change the Siri speaker?

the hint message? you mean. it just for hint, and don't impact the response, no other use, you can modify it youself.

You can check my shortcut, It kinda solve this issue.
You don't need the petey application, just check the secondary shortcut and look how it is looked in the main shortuct. #109


Add dndDraggingSourceCopyMove to source element

It would be nice to have a custom css class added to the source element similar to dndDraggingSource but dependent on whether the element is moved or copied. This way it would be possible to hide the source element when it is moved and show it when it is copied.
I currently achieve this behaviour by using dnd-dragstart="dragStart(event)" and dnd-dragend="dragEnd(event)" with these functions
dragStart = function($event) {
	if ($event.dataTransfer.effectAllowed === 'copy' ||
	($event.dataTransfer.effectAllowed === 'copyMove' && $event.ctrlKey)) {
		$($event.target).addClass('copy');
	}
};

dragEnd = function($event) {
	$($event.target).removeClass('copy');
};

but it would simplify things when the directive could already do this.

This is not possible because the drop effect is only determined when you drop the element and unknown during dragstart. Also, when the user presses/releases the Ctrl key the source element would have to change, which above all is probably not the best user experience.


Different results of radius_graph() when input in different data type

🐛 Bug
Different results of radius_graph() when input in different data type (i.e., long and double)
To Reproduce
Steps to reproduce the behavior:
data = Data()
batch_size = 2
num_nodes = 4
x_dis = torch.arange(batch_size*num_nodes).view(batch_size*num_nodes,-1)
batch = torch.arange(batch_size).view(-1,1).repeat(1,num_nodes).view(-1)
from torch_geometric.nn import radius_graph
rg = radius_graph(x_dis, 1, batch)
print(rg)

Expected behavior
tensor([[1, 0, 2, 1, 3, 2, 5, 4, 6, 5, 7, 6],         [0, 1, 1, 2, 2, 3, 4, 5, 5, 6, 6, 7]])
but I got
tensor([], size=(2, 0), dtype=torch.int64)
If I change the data type of  x_dis to double, the output is as expected
Environment

OS: Ubuntu 16.04.6
Python version: 3.6.1
PyTorch version: 1.5.1
CUDA/cuDNN version: 10.1
GCC version: 7.3.0

That looks like an issue with nanoflann which we use for computing the ball query. nanoflann finds the output indices via dist < radius and casts the radius to an integer. I'm not sure if it is fixable though. I feel like it is a lot safer to just do not use integer values when computing distances.


Less than N resources returned in paged dataset when searching with _count=N

Describe the bug
When performing certain queries with _count=1000 and more than 1000 records matching the search criteria, less than 1000 records are returned.

The number of records returned per page is variable, but is generally between 900 and 1000 records.
When paging over the dataset, the full set of records is returned. Records are not being dropped or excluded - this bug is not critical, just annoying :)

We would like to understand (and report) this behaviour, as this does not match our expectations.
FHIR Version?
R4
Data provider?
CosmosDB
To Reproduce
(this example uses Procedure and Observation resources, but this has been observed with other searches as well)
Steps to reproduce the behavior:

Load several hundred Procedure resources into the FHIR database. In the below example from one of our test datasets, len(procedures)=552.
For each procedure resource, load several Observation resources. In this example, the reference is held in the .partOf element. In our example, len(observations)=41071.
Search for all observations, with _count=1000 and part-of=<procedure_ids> (join all the Procedure id elements with the , (OR) search separator). NB: The POST /Observation/_search endpoint must be used as a GET URL would be too long.
Check the number of returned resources. We regularly see less than 1000 resources. (If 1000, page through the dataset and check the contents of all response Bundles).

Expected behavior
If >=N resources exist on the server that satisfy a query with _count=N, we expect N resources to be returned in each page of a paged dataset.
Actual behavior
Less than 1000 resources are regularly seen. Here is a (sanitised) python script with the output from the example above. The internal FhirServerConnection class isn't doing anything "clever" with FHIR here - it is a wrapper for auth, paging, proxy and retrying http requests. If required I can remove it and provide an alternative script.... but it's a little useless without this source data anyway!
# open-source libraries
import requests
from fhir.resources.bundle import Bundle
from fhir.resources.encounter import Encounter
from fhir.resources.observation import Observation
from fhir.resources.procedure import Procedure

# utility classes used internally
# I have added a debug statement in FhirServerConnection to log the number of returned resources per query, see output
from fhir_connector.fhir_server_connection import FhirServerConnection
from fhir_connector.auth_providers import AccessKeyAuthProvider

FHIR_API_BASE_URL = "censored"
ACCESS_KEY = "censored"
FHIR_SERVER_PROXIES = {}  # censored

fhir_server_connection = FhirServerConnection(
    fhir_server_address=FHIR_API_BASE_URL,
    fhir_server_auth_provider=AccessKeyAuthProvider(access_key=ACCESS_KEY),  # handles auth, please ignore :)
    user_agent="foo/1.2.3",
    fhir_server_proxies=FHIR_SERVER_PROXIES
)

###########
# Data model for this example
#
# Encounter
#   └─ 1:1 ─ Procedure
#              └─ 1:0..N ─ Observation
###########

###########
# examples using our library, see output below
encounters = fhir_server_connection.get_resources(
    resource_type=Encounter.get_resource_type(),
    search_parameters={}  # get me everything!
)
print(f"{len(encounters)=}")  # 552 encounters found

procedures = fhir_server_connection.get_resources(
    resource_type=Procedure.get_resource_type(),
    search_parameters={
        "encounter": ','.join([encounter.id for encounter in encounters])
    },
    http_method="POST"  # required due to query length (exceeds URL length limit)
)
print(f"{len(procedures)=}") # 552 procedures found (expected behaviour)

observations = fhir_server_connection.get_resources(
    resource_type=Observation.get_resource_type(),
    search_parameters={
        "part-of": ','.join([procedure.id for procedure in procedures])
    },
    http_method="POST"  # required due to query length (exceeds URL length limit)
)
print(f"{len(observations)=}")  # 41071 Observations found

###########
# example using requests library
observation_search_response = requests.post(
    f"{FHIR_API_BASE_URL}/Observation/_search",
    headers={"Authorization": f"Access-Key {ACCESS_KEY}"},
    data={
        "_count": 1000,
        "part-of": ','.join([procedure.id for procedure in procedures])
    },
    proxies=FHIR_SERVER_PROXIES
)

observation_bundle = Bundle.parse_raw(observation_search_response.text)
print(f"{len(observation_bundle.entry)=}")  # almost always less than 1000

Search bundle contains 552 resources!
len(encounters)=552
Search bundle contains 552 resources!
len(procedures)=552
Search bundle contains 976 resources!
Search bundle contains 995 resources!
Search bundle contains 950 resources!
Search bundle contains 999 resources!
Search bundle contains 985 resources!
Search bundle contains 989 resources!
Search bundle contains 929 resources!
Search bundle contains 941 resources!
Search bundle contains 950 resources!
Search bundle contains 961 resources!
Search bundle contains 937 resources!
Search bundle contains 936 resources!
Search bundle contains 939 resources!
Search bundle contains 964 resources!
Search bundle contains 965 resources!
Search bundle contains 933 resources!
Search bundle contains 959 resources!
Search bundle contains 947 resources!
Search bundle contains 933 resources!
Search bundle contains 937 resources!
Search bundle contains 972 resources!
Search bundle contains 932 resources!
Search bundle contains 968 resources!
Search bundle contains 947 resources!
Search bundle contains 956 resources!
Search bundle contains 951 resources!
Search bundle contains 947 resources!
Search bundle contains 951 resources!
Search bundle contains 965 resources!
Search bundle contains 955 resources!
Search bundle contains 948 resources!
Search bundle contains 952 resources!
Search bundle contains 947 resources!
Search bundle contains 935 resources!
Search bundle contains 931 resources!
Search bundle contains 978 resources!
Search bundle contains 978 resources!
Search bundle contains 921 resources!
Search bundle contains 936 resources!
Search bundle contains 921 resources!
Search bundle contains 953 resources!
Search bundle contains 919 resources!
Search bundle contains 936 resources!
Search bundle contains 147 resources!
len(observations)=41071
len(observation_bundle.entry)=962

AB#95813

Hi @moloneyd-draeger, this behavior is expected in when Cosmos starts using more than one physical partition. Once this happens we start getting results from each individual partition, so there is no longer a guarantee of exactly 1000 (unless a single partition returned this, or add up to this coincidentally when aggregating from multiple).
The behavior we have in place (for Cosmos) is to attempt to return no less than 0.5 * _count and no more than _count. The FHIR Spec is more worded around servers never returning more than the limit so we've added strategies with the sequential and fan-out queries to ensure this.

Closing the issue, as question is answered above.
Please let us know if you have additional questions


⚠ ClamAV has degraded performance

In e44d0fd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 56 ms

Resolved: ClamAV performance has improved in 35544e5.


docs: remove non-existent utils variable in rspack config

Summary
remove non-existent utils variable in rspack config
Related Links

Checklist

[ ] Tests updated (or not required).
[x ] Documentation updated (or not required).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Change the content of the "fishing-seasonality" config files

@jhpoelen As you know, I am currently preparing a README file, where I am detailing the parameters generated by the bridge and those not generated by the bridge. In that README file, I am explaining that the "fishing" folder contains fishing seasonalities for focal functional groups; and that fishing seasonalities are not estimated by the bridge between FishBase/SeaLifeBase and OSMOSE and should be entered by the user.
Therefore, I think that it would be better not to provide any value of fishing seasonality in the "fishing-seasonality" config files provided in the "fishing" folder. For example, the cells B2 to B13 of the CSV file attached here should be empty.
fishing-seasonality-Amberjacks.xlsx
Could you please make sure that this is implemented in the API?

This is now implemented. Therefore, I am closing the present issue today.


Payment Methods Component

I'm creating this issue to let chime in if this should be an atom/molecule or organism and if it should be implemented on faststore or on base.store.
The Payment Methods is a list of accepted payment methods a store has.
Figma link | Pull Request

I think this component should be in the store. Because he's a simple div, but keep in the faststore if the flag prop is an array of strings and the user can choice what the flags should display instead of importing the flag icon.

About what @emersonlaurentino said, I think the idea is that the developer should be able put anything as "flags": an icon, a string, a link....

But we want the user to put anything? because the use case we need is only the image/icon, so we can give that.

About what @emersonlaurentino said, I think the idea is that the developer should be able put anything as "flags": an icon, a string, a link....

But we want the user to put anything? because the use case we need is only the image/icon, so we can give that.

The use case is only image/icon, but if the developer wants to use it another way, I don't see why we shouldn't allow it. What do you think?
Anyway, It's a simple component, if most of us agrees it should be in base store, I'm ok with that too.

closing because we decided to classify it as molecule https://github.com/vtex/faststore/pull/1024


Add NEWS/Changelog file to summarise key changes between versions

We should add a NEWS/Changelog file to summarise key changes between versions and each PR addressing an issue should add a line or two so we grow this file “organically” and then have it ready for new version release.
@XingerTang and @AprilYUZhang what is the Python way of doing this?

maybe slap can help us, but I haven't use it.

@gregorgorjanc I haven't used Python-specific changelog files before. Maybe we can add a rst file for it, this is how the read the docs write their change logs, so it can be easily integrated into the documentation.

RST or MD would work just well https://github.com/tskit-dev/msprime/blob/main/CHANGELOG.md

https://github.com/vweevers/common-changelog#12-guiding-principles gives a style guide for changelogs, and https://alphaos.app/blog/github-changelog-tools gives some Github changelog generators


InheritanceIndexer uses property in SQL

I have questions regarding https://github.com/shopware/platform/blob/8405e4aa394e5a4eea255026660bf55ea4ad76bf/src/Core/Framework/DataAbstractionLayer/Indexing/Indexer/InheritanceIndexer.php#L241-L251
The property name is always the php field name in the entity classes. So why is this part of an SQL query?
How did I find this one? I added a custom FkField using an extension to a shopware entity definition and tried to write the FkField in the extension via the administration. Saving was successful but the subscribed indexers failed as they generate malicious SQL. I am unsure whether it is correct to just use #field# instead of #property#. Why is the code like this? Please explain the intended behavior.

Hi @JoshuaBehrens,
if you add an inherited to one association to the product we need a table column with the property name of the to one association. We need this for a high-performance selection and filtering of the data.
You can find the documentation for inherited associations here: https://docs.shopware.com/en/shopware-platform-dev-en/internals/core/data-abstraction-layer/data-inheritance

Thanks @OliverSkroblin for the answer. I do get why it increases performance as less joins are needed, but I don't get why there has to be a mixture of a php property name that is re-used in SQL. Can one somehow change the SQL column name? This breaks the layout for databases that every column has to be lower snake case. That is seriously not a bummer but it breaks the layout and I am up to know what intentions are behind that.

We can change that the columns are written in CamelCase to snake case. I opened a ticket for it.

Hello,
thank you for creating this issue.
I have opened a ticket on our Issue Tracker for you. See the ticket link: https://issues.shopware.com/issues/NEXT-5100
Please use this ticket to track the state of your issue.


JNG-3902 Fix timestamp asstring

JNG-3902  Timestamp.asString() produces wrong output

JNG-3902 Fix timestamp asstring

Duplicate of https://github.com/BlackBeltTechnology/mapper/pull/61


[ BUG ] Tooltip issues with react-native-reanimated 3.10.0

Tooltip exiting produces an error on web.
domUtils.js:109 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at child.onanimationend (...)

I tracked the source of the problem which seems to be react-native-reanimated version 3.10.0, but I'm not familiar with the inner workings of it.
For now I've wrapped the Animated.View component as shown below. Regardless of the bug and its impact on other components, maybe it's the way it should be handled since web animations are handled by css in the first place?
const AnimatedView = React.forwardRef<ViewRef, ViewProps>((props, ref) => {
  return Platform.OS === 'web' ? (
    <View ref={ref} {...props} />
  ) : (
    <Animated.View entering={FadeIn} exiting={FadeOut} ref={ref} {...props} />
  );
});

AnimatedView.displayName = 'AnimatedView';

const TooltipContent = React.forwardRef<
  React.ElementRef<typeof TooltipPrimitive.Content>,
  React.ComponentPropsWithoutRef<typeof TooltipPrimitive.Content> & { portalHost?: string }
>(({ className, sideOffset = 4, portalHost, ...props }, ref) => (
  <TooltipPrimitive.Portal hostName={portalHost}>
    <TooltipPrimitive.Overlay style={Platform.OS !== 'web' ? StyleSheet.absoluteFill : undefined}>
      <AnimatedView>
        <TextClassContext.Provider value="text-sm native:text-base text-primary-foreground">
          <TooltipPrimitive.Content
            ref={ref}
            sideOffset={sideOffset}
            className={cn(
              'z-50 overflow-hidden rounded-md border border-border bg-primary px-3 py-1.5 shadow-lg shadow-foreground/20 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 web:animate-in web:fade-in-0 web:zoom-in-95',
              className
            )}
            {...props}
          />
        </TextClassContext.Provider>
      </AnimatedView>
    </TooltipPrimitive.Overlay>
  </TooltipPrimitive.Portal>
));
TooltipContent.displayName = TooltipPrimitive.Content.displayName;

@vktrl Thanks for contributing!
If you wanted to see the changes in react-native-reusables, you can see it here: https://github.com/mrzachnugent/react-native-reusables/issues/145


issue with ESM module linking

Describe the bug
Certain times the build works fine and others it does not. I believe it's an issue with the module resolution in the dist folder of a dependency.
Reproduction
https://github.com/down-the-whole/intro
Should be decently easy to replicate in here.

git clone
git submodule update --init --recursive
node bin/build-all-modules.js
yarn install
yarn dev

System Info

required vite version: 1.0.0-rc.3
required Operating System: macOS 10.15.6 (19G73)
required Node version: v12.18.3

Logs (Optional if provided reproduction)
Uncaught (in promise) TypeError: n.__ is not a function
    at g (index.js:351)
    at Array.forEach (<anonymous>)
    at n.__r (index.js:37)
    at options.__r (preact-use-gesture.js:3)
    at T (index.js:191)
    at component.js:126
    at Array.some (<anonymous>)
    at m (component.js:215)

Looks to be a problem with preact linkage?
Is there a Vite cache somewhere from esbuild or Rollup that is not flushing properly?

I have a look with this, but I get error like this. It caused by imported preact twice. You can remove node_modules inside preact-use-gesture.
Uncaught TypeError: Cannot read property '__H' of undefined
    at v$2 (index.abb6408b.js:formatted:903)
    at p$3 (index.abb6408b.js:formatted:915)
    at m$3 (index.abb6408b.js:formatted:912)
    at useGesture (index.abb6408b.js:formatted:3370)
    at useSimpleDraggable (index.abb6408b.js:formatted:3512)
    at d.WordMagnet [as constructor] (index.abb6408b.js:formatted:3564)
    at d.L [as render] (index.abb6408b.js:formatted:347)
    at T (index.abb6408b.js:formatted:245)
    at g (index.abb6408b.js:formatted:110)
    at j (index.abb6408b.js:formatted:313)


Diffs are not split but linear

What I'm getting:

$ git config --global --get core.pager
git-split-diffs --color | less -RFX

What I expected:

Old Content on left side and new on right side.

See https://github.com/banga/git-split-diffs#narrow-terminals. We revert to unified diffs if your terminal is too narrow. You can prevent this by setting min-line-width to 0.


Any ideas on using hookFor?

This generator is nice.  I'd like to include it in my generator (https://github.com/Hypercubed/generator-commander).  I can use the hookFor and peerDependencies to run generator-license from generator-commander but it will ask again for the author name (that I am pulling from github) and license.  Is there a way to skip these prompts when using hookFor?  One option is to accept an author name and license from the command line arguments in generator-license.
This seams line a common potential use for generator-license. Any ideas?

Hey, this is still an issue today.
This is because the code is doing simple truthy checks !this.options.foo. The issue is that a user might already have provided an empty value in a previous generator.
I think it'd be better if we did checks for this.options.foo == null, so we'd know if we've just been passed an empty value.

is it fixed after merged #20?


[BUG] Warnings raised by pandas

Describe the bug
Warnings raised by pandas when call groupby.agg:
/home/admin/kaisheng.hks/mars/mars/dataframe/groupby/aggregation.py:741: FutureWarning: Indexing with multiple keys (implicitly converted to a tuple of keys) will be deprecated, use a list instead.
  grouped = grouped[selection]

This behavior is consistent with pandas, df.groupby()['a', 'b'] will have warnings, instead, df.groupby()[['a', 'b']] should be used, thus close this issue.


Bungeecord - Latest builds - Permission data could not be loaded

Hello, i am having issues with bungeecord edition of the plugin.
Using latest builds
bungeeCord: build #1250
LuckPerms: Build bungeecord-3.2.60
Issue:
With fresh install, plugin prints out message "permission data could not be loaded. please try later"
No changes in plugin files at all.
No errors at all.

Bungee log - https://gist.github.com/LazosPlaying/9dfc7d42051fb5bcf3d02c1647a892ba
Bungeecord config - https://gist.github.com/LazosPlaying/ec9e2d8d73c5434d10948cebd7e8cf8f
LuckPerms config (default) - https://gist.github.com/LazosPlaying/82d446ef2dfa5b56ae7307939e8e1b79

Is LuckPerms installed on your backend server as well?

It is. On every server.

Check the consoles of your backend servers.
If you're being kicked with that error, it's not BungeeCord.

Not being kicked.
Only getting the message in chat.
And it is confirmed it is bungee-side, because the rank that i should have there, it is not set. And my playerdata is not valid (when checking thru console)

Ok, can you actually post a log file where you connect? In the one you posted above, players never actually join.

│2017-07-31 23:31:24 | [LP] - UUID: 6d4a1e9f-d849-476e-bdaa-42ffabe17d2e
│2017-07-31 23:31:24 | [LP] - Status: Offline                                                                                ││
│2017-07-31 23:31:24 | [LP] - Primary Group: default                                                                         ││
│2017-07-31 23:31:24 | [LP] - Counts:                                                                                ││
│2017-07-31 23:31:24 | [LP] -    Permissions: 2                                                                              ││
│2017-07-31 23:31:24 | [LP] -    Temporary Permissions: 0                                                                    ││
│2017-07-31 23:31:24 | [LP] -    Prefixes: 0                                                                                ││
│2017-07-31 23:31:24 | [LP] -    Suffixes: 0                                                                                ││
│2017-07-31 23:31:24 | [LP] -    Meta: 0                                                                                ││
│2017-07-31 23:31:24 | [LP] - Parent Groups:                                                                                ││
│2017-07-31 23:31:24 | [LP] -    > default                                                                                ││
│2017-07-31 23:31:24 | [LP] - Cached Data:                                                                                ││
│2017-07-31 23:31:24 | [LP] -    Has contextual data: false                                                                  ││
│2017-07-31 23:31:24 | [LP] -    Current Contexts: None                                                                      ││
│2017-07-31 23:31:24 | [LP] -    Current Prefix: None                                                                        ││
│2017-07-31 23:31:24 | [LP] -    Current Suffix: None```

Also detecting me as offline

Ok, can you post a log file where you actually connect? In the one you posted above, players never actually join.

https://gist.github.com/LazosPlaying/7ec5837b710a4bfb10b04a197140b322

no errors at all, or any output that would mention issues.

This is totally default config, without anything modified.

Is your proxy running in offline mode?
The uuid shown in the command output shows a valid Mojang UUID. (6d4a1e9f-d849-476e-bdaa-42ffabe17d2e), which would indicate you have some plugin messing with UUIDs.

Yes correct it is Offline mode (as it is visible in the config file i also included)

I have the same problem

LuckPerms loads it's data at LOW priority, and stores it against a players uuid.
https://github.com/lucko/LuckPerms/blob/master/bungee/src/main/java/me/lucko/luckperms/bungee/BungeeListener.java#L59
FastLogin then (sometimes) changes this UUID after LuckPerms has loaded its data.
https://github.com/games647/FastLogin/blob/master/bungee/src/main/java/com/github/games647/fastlogin/bungee/listener/PlayerConnectionListener.java#L81
FastLogin should be changing this data before events are even being called. You're going to have to expect incompatibilities when plugins forcefully change data which other plugins depend on.
This is a FastLogin issue, report it to them.

Aright thank you for the info :)

Just want to say that the issue has been fixed.
@jahpe @lucko
https://github.com/games647/FastLogin/issues/167


run CI before running deployment for all branches

@donrestarone , Just for confirmation, is this the requirement:

Run test case on pull request
Run test case first and deploy on push/merge

@Pralish this should not happen, where CI is failing but a deployment is happening (!!!!)


Fix a bug where an EndpointGroup is not copied to a derived client.

Motivation:
When a new client is derived from an existing client using Clients.newDerivedClient(), all options should be copied to the new client and the original EndpointGroup should be reserved. It seems to have already been considered by newDerivedBuilder() but there is one API missing. https://github.com/line/armeria/blob/81ac954d41ee8420898ba298f9d0a766c3d37b71/core/src/main/java/com/linecorp/armeria/client/Clients.java#L317-L319
The following API called builder instead of newDerivedBuilder.
https://github.com/line/armeria/blob/81ac954d41ee8420898ba298f9d0a766c3d37b71/core/src/main/java/com/linecorp/armeria/client/Clients.java#L303-L306
As a consequence, a derived client tries to send a request to armeria-group-.
https://github.com/line/armeria/blob/81ac954d41ee8420898ba298f9d0a766c3d37b71/core/src/main/java/com/linecorp/armeria/client/DefaultClientBuilderParams.java#L92-L92
Modifications:

Fixed newDerivedClient(T, Function) to call newDerivedBuilder()

Result:
EndpointGroup is now correctly copied to a newly derived client.

Thanks for fixing this! 😄


adding filter options to the open violations tab

Summary
It would be nice to have filter options in the open violations tab. Especially when you have a lot of accounts/open violations.
Desired Behaviour

option to filter on a (sub)account

option to filter on a specific condition/policy name

filter on incident and grouping warnings/criticals that belong to one incident

This is doable - I'll add this in the next release


small updates to flare id format

From yyyymmddhhmmss to yyyymmddhhmm, following the discussion on Oct 15.

If this flare_id naming is decided, I will change all products' names to be "yyyymmddhhmm". We had the format yyyymmddhhmm00 before.

Yes!
Sent from my iPhone
On Wed, Oct 16, 2024 at 11:25 AM Xingyao Chen @.***>
wrote:

If this flare_id naming is decided, I will change all products' names to
be "yyyymmddhhmm". We had the format yyyymmddhhmm00 before. — Reply to this
email directly, view it on GitHub, or unsubscribe. You are receiving this
because you
If this flare_id naming is decided, I will change all products' names to
be "yyyymmddhhmm". We had the format yyyymmddhhmm00 before.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/ovro-eovsa/eovsapy/pull/13*issuecomment-2417165133__;Iw!!DLa72PTfQgg!IxDoZf4AOhNqkJlxykbGiUqvMCh3RNDYRB3IGeo1fgrnYm2VJb-ywS46zWxIsuho3U830E81_J5fMOg3Y5ZWUrRR$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB5MZJQRUGWDKJ6JAEMMAPDZ32AM3AVCNFSM6AAAAABQAHSSP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGE3DKMJTGM__;!!DLa72PTfQgg!IxDoZf4AOhNqkJlxykbGiUqvMCh3RNDYRB3IGeo1fgrnYm2VJb-ywS46zWxIsuho3U830E81_J5fMOg3YyzIK2gv$
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


unenv-nightly versioning is problematic

Environment
unenv-nightly
Reproduction
pnpm info unenv-nightly versions
Describe the bug
the unenv-nightly@latest flip flops between patch and minor version bumps
For example after https://github.com/unjs/unenv/actions/runs/9323911293/job/25668071381, the @latest was set to 1.10:
[info] Bumping npm package version from `1.9.0` to `1.10.0-1717187105.3931166` (minor)

But subsequently when another fix was released in https://github.com/unjs/unenv/actions/runs/9324677049/job/25670351927 the @latest became 1.9.x:
[info] Bumping npm package version from `1.9.0` to `1.9.1-1717191795.bd5ba19` (patch)

Ideally all releases from main target 1.10 or even 2.0 release train regardless of their semantic commit message.
Additionally, it would be great to make the timestamp in the version tag human readable. Perhaps:<PHONE_NUMBER>22.
Additional context
No response
Logs
No response

ah i think we need to clone git in CI (default is 1 and therefore change log id based on last commit)

awesome! thanks

@pi0 could you please also adjust the timestamp format as suggested above?

~> https://github.com/unjs/changelogen/issues/195


[Question]: Page width

What happened?
I checked ModelSettingsPage page and I found this piece of code:
 protected function getForms(): array
    {
        return [
            'form' => $this->form(
                $this->makeForm()
                    ->statePath('data')
                    ->columns(2)
                    ->inlineLabel($this->hasInlineLabels()),
            ),
        ];
    }

Why did you set columns to 2? how can we update it to fit the page width ?
How to reproduce the bug

Package Version
1.0.1
PHP Version
8.2
Laravel Version
10.x
Which operating systems does with happen with?
Linux
Notes
No response

I just implemented this the way the core team did for the "Spatie Settings" package.
I think of it as a sensible default but am of course open for discussion.
If you have a field inside the form it spans 1 column by default:
public function form(Form $form): Form
{
    return $form
        ->schema([
            Forms\Components\TextInput::make('test'),
        ]);
}

Now if you want to make it occupy the whole page, you can just add ->columnSpan(2) to it.
public function form(Form $form): Form
{
    return $form
        ->schema([
            Forms\Components\TextInput::make('test')
                ->columnSpan(2),
        ]);
}

You can then also add a Layout around it which spans 2 columns and offers a single column to the children.
Let me know if this solves your issue :)


[VZ] SemVer conventions

This is to ensure we're all on the same page w/r/t Capital Framework hygiene.

What happens when a CF component increments its patch version? (e.g. cf-buttons going from 1.0.0 to 1.0.1)?

The master component (this repo) doesn't increment anything because the caret notation in bower.json ensures the latest version of the component (up to and excluding new major versions) will be installed.

What happens when a CF component increments its minor version? (e.g. cf-buttons going from 1.0.1 to 1.1.0)?

The master component doesn't increment anything because the caret notation in bower.json ensures the latest version of the component (up to and excluding new major versions) will be installed.

What happens when a CF component increments its major version? (e.g. cf-buttons going from 1.1.0 to 2.0.0)?

The master component increments its major version (e.g. 1.1.5 -> 2.0.0) because there are breaking changes downstream.

What happens when CF gets a new component? (e.g. https://github.com/cfpb/capital-framework/issues/167)

The master component increments its minor version (e.g. 1.1.5 -> 1.2.0) because new, backwards-compatible changes have been introduced. The new component should be added as a dep to bower.json with caret notation (e.g. cf-tooltip: ^0.1.0). The new component itself should remain 0.x.x until it exits beta. Once it exits beta, see below.
Note: It is acceptable for components in beta to introduce breaking changes when incrementing their minor version (e.g. 0.2.0 to 0.3.0). Beta components should be considered experimental until they reach 1.x.x, at which point their API is frozen.

What happens when a CF component exits beta (going from 0.x.x to 1.x.x)? (e.g. cf-tooltip going from 0.6.0 to 1.0.0)?

The master component's bower.json is updated (e.g. cf-tooltip: ^1.0.0) and the master component increments its minor version because the update to bower.json is a backwards-compatible change.

What happens when CF removes a component?

The master component should increment its minor version (e.g. 1.1.5 -> 1.2.0) because new, backwards-compatible changes have been introduced. The new component should be removed from bower.json.

When should the patch version of the master repo be incremented?

When you do something inconsequential to this repo, like change instructions in the readme, move something around in package.json, etc.
Feedback greatly appreciated @cfpb/front-end-team-admin

I think this sounds great, but I'd just suggest making this into a table and adding it to CONTRIBUTING.md for reference.

Relevant: https://github.com/semantic-release/semantic-release

I'm now realizing this will be an incredibly important issue once we have everything in one repo and are relying on auto-publishing scripts. Gonna codify it for CFv2.

After writing the code to implement this, I think the symbiosis introduced by Voltrazord changes this versioning strategy. Now that the components are stored inside of the master capital-framework repo, a non-breaking change to cf-whatever is also a non-breaking change to capital-framework since its the same codebase.
I think it makes our versioning less complicated: when a component increments its major/minor/patch version, the master component increments the same version.

@contolini As a baseline rule, I like that. My only concern is that I don't think I'd want capital-framework to automatically get a new version/release immediately when a component is updated. There may be times when we want to batch updates to multiple components together in one release of the complete framework.

@Scotchester Can you provide an example of when we'd want to do that? If there's new code entering master, I'd feel obligated to increment capital-framework's version number.

The recent changes to headings would be a good example. It required changes to core plus three different components.

In that situation I envision a WIP pull request being opened and it not
being merged into master until all three components have been updated.
They'd all enter master at once and CF gets bumped appropriately.
On Monday, December 7, 2015, Jimmy Wilson<EMAIL_ADDRESS>wrote:

The recent changes to headings would be a good example. It required
changes to core plus three different components.
—
Reply to this email directly or view it on GitHub
https://github.com/cfpb/capital-framework/issues/179#issuecomment-162668672
.

--
Chris

Oh yeah, guess that makes sense. I'm convinced :+1:

It'd also be fine if the components were updated one-by-one but every time
an updated component entered master I'd expect a CF bump.
Chris
On Tue, Dec 8, 2015 at 5:58 PM, Jimmy Wilson<EMAIL_ADDRESS>wrote:

Oh yeah, guess that makes sense. I'm convinced [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/cfpb/capital-framework/issues/179#issuecomment-163048179
.

I believe this is closed now that Voltrazord is done. Feel free to re-open if I missed something.


bug(Datepicker): DatepickerFilter is not behaving if using a getter for the filter

Reproduction
Use StackBlitz to reproduce your issue:
https://stackblitz.com/edit/components-issue-zahr8d?file=src/app/example-component.html
Steps to reproduce:

Use a getter as the filter in code (see stackblitz)
Open dialog menu for the Datepicker
Attempt to click one of the non greyed-out options.

Expected Behavior
Possible to select any date valid (as per the date filter)
Actual Behavior
Impossible to pick a date that is not filtered out.
Environment

Angular: 11.2
CDK/Material: 11.2
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

Extra notes
The same code was working previously with version 9 of angular

Duplicate of https://github.com/angular/components/issues/21929.


HDDS-3821. Disable Ozone SPNEGO should not fall back to hadoop.http.a…

…uthentication configuration.
What changes were proposed in this pull request?
When ozone http kerberos is disabled, ensure the authentication filter does not fallback to configuration from hadoop.http.authentication.*
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3821
How was this patch tested?
Acceptance test and Manual test when ozone http kerberos is disabled but  hadoop.http.authentication.* is enabled.

org.apache.hadoop.ozone.client.rpc.Test2WayCommitInRatis seems to be flaky. Pass in the first commit but not the second one.

@xiaoyuyao Thanks for working on this and @dineshchitlangia for reviewing it!

This should be removed. Thanks @adoroszlai
On Wed, Jul 15, 2020 at 5:40 AM Doroszlai, Attila<EMAIL_ADDRESS>wrote:

@adoroszlai commented on this pull request.
In hadoop-ozone/integration-test/src/test/resources/log4j.properties
https://github.com/apache/hadoop-ozone/pull/1101#discussion_r455019812:

+log4j.logger.org.apache.ratis.grpc.server.GrpcLogAppender=DEBUG
+log4j.logger.org.apache.ratis.server.impl.RaftServerImpl=DEBUG

Hi @xiaoyuyao https://github.com/xiaoyuyao,
Were these Ratis log levels intentionally set to DEBUG in the final
commit, or is it a leftover that should have been removed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/hadoop-ozone/pull/1101#pullrequestreview-448912144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVWRUHCRB3AMJLBUVLX7H3R3WPU5ANCNFSM4ODFYWVA
.

This should be removed.

Thanks for the confirmation.  Created HDDS-3967 for this.  Will submit PR soon.


Release v0.12.0

(PR #179, 2021-01-13) rtc: Add data models for "cesión"
(PR #181, 2021-01-14) rtc.data_models: Clean up configuration leftovers from tests
(PR #180, 2021-01-15) rtc: Add data models and parser for AECs

Codecov Report

Merging #184 (7ac197d) into master (ba55f4e) will increase coverage by 3.21%.
The diff coverage is 90.18%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   77.62%   80.83%   +3.21%
==========================================
  Files          28       30       +2
  Lines        1908     2505     +597
  Branches      319      377      +58
==========================================
+ Hits         1481     2025     +544
- Misses        280      306      +26
- Partials      147      174      +27

Impacted Files
Coverage Δ

cl_sii/rtc/parse_aec.py
89.74% <89.74%> (ø)

cl_sii/rtc/data_models_aec.py
90.38% <90.38%> (ø)

cl_sii/rtc/data_models.py
91.16% <90.43%> (-1.49%)
:arrow_down:

cl_sii/rtc/data_models_cesiones_periodo.py
56.25% <100.00%> (+1.20%)
:arrow_up:

cl_sii/dte/data_models.py
67.83% <0.00%> (+3.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba55f4e...7ac197d. Read the comment docs.

Codecov Report

Merging #184 (7ac197d) into master (ba55f4e) will increase coverage by 3.21%.
The diff coverage is 90.18%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   77.62%   80.83%   +3.21%
==========================================
  Files          28       30       +2
  Lines        1908     2505     +597
  Branches      319      377      +58
==========================================
+ Hits         1481     2025     +544
- Misses        280      306      +26
- Partials      147      174      +27

Impacted Files
Coverage Δ

cl_sii/rtc/parse_aec.py
89.74% <89.74%> (ø)

cl_sii/rtc/data_models_aec.py
90.38% <90.38%> (ø)

cl_sii/rtc/data_models.py
91.16% <90.43%> (-1.49%)
:arrow_down:

cl_sii/rtc/data_models_cesiones_periodo.py
56.25% <100.00%> (+1.20%)
:arrow_up:

cl_sii/dte/data_models.py
67.83% <0.00%> (+3.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba55f4e...7ac197d. Read the comment docs.


No output from running cells after installation on Windows

I installed on Windows using the instructions in the README file. Everything appears fine, except running cells produces no output; e.g. if I open a new notebook, create a code cell with the code print('here'), and click the "run the selected cells and advance" button, the curser advances but no output is produced. Should I try re-installing?

Reinstallation might be worth trying. Would you mind filling in the bug report template?

Hmm.. reinstalling doesn't help.  Any other suggestions? I will fill out a bug report template.

Closing this on in favour of #386 which now has a lot of useful information. Thank you!


Logstash codec for TCP: json_lines

I had problems using the TCP connector. Long messages didn’t arrive (unparseable JSON), many short messages in a short time span didn’t either (unparseable JSON, again).
The documentation here says to use the codec json. I have found that I had to use json_lines instead (with logstash 1.4.1).

Fixed.


Fix missing word in doc/guide/events.rst

Small fix to the docs.

Maintainer merge checklist

[ ] Title is descriptive/clear for inclusion in release notes.
[ ] Applied a Component: xxx label.
[ ] Applied the api-deprecation or api-break label.
[ ] Applied the release-highlight label to be highlighted in release notes.
[ ] Added to the milestone version it was merged into.
[ ] Unittests are included in PR.
[ ] Properly documented, including versionadded, versionchanged as needed.

@outdooracorn thanks


BP-1871 Add new logo for Tinka

do we have alternatives to using fixed sizes such as N px? so that is can fit and behave properly on responsive layouts and so on?

Yes, I think we can do this in the future with a set of new logos with same sizes like we did on woocommerce and some changes to css. Currently all icons are with fixed sizes.

changing all logo sizes is not in the scope of this ticket, we will look into better designs in the future


#3458 isUnmodifiable assertion for Iterator instances

Check List:

Fixes: #3458
Unit tests: YES
Javadoc with a code example (on API only): YES
PR meets the contributing guidelines

Following the contributing guidelines will make it easier for us to review and accept your PR.
What was done
I can only check if an iterator is unmodifiable by calling remove() and checking if the iterator throws UnsupportedOperationException. However not all unmodifiable iterators behave like that, see my comment in the ticket.
That's why I check explicitly for Collections$EmptyIterator  and Collections$EmptyListIterator.
cc @scordio

@scordio I've squashed my changes. I think I can only struggle if the target branch is changed, and I might need assistance. Just afraid to mess with Git 🫤

This is now merged. Thanks for your first contribution, @dehasi!


NuGetSdkResolver fails to import the Sdk when running for the first time

Steps to reproduce
Project file
<Project>
  <Sdk Import="My.Custom.Sdk" Version="0.1.2" />

</Project>

Command line
msbuild /bl

Expected  behavior
Restore the right version of the required Sdk on build and proceed with the implicitly imported sdk inside the project
Actual behavior

Execution: Restores the Sdk & fails the build:

a.proj : error : C:\Program Files\dotnet\sdk\2.1.4\Sdks\My.Custom.Sdk\Sdk not found. Check that a recent enough .NET Core SDK is installed and/or increase the version specified in global.json.
a.proj : error MSB4236: The SDK 'My.Custom.Sdk' specified could not be found.

Execution: Runs without errors

Environment data
msbuild /version output:
Microsoft (R) Build Engine version <IP_ADDRESS>344 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.
<IP_ADDRESS>344
OS info:
Windows Server 2012 r2
If applicable, version of the tool that invokes MSBuild (Visual Studio, dotnet CLI, etc):
direct MSBuild.exe call

We got some more information on this. We were able to fix it by using the exact same capitalization in the package id.
Now the question is: Aren't PackageReferences supposed to be resolved case insensitively?

I think this is a duplicate of https://github.com/NuGet/Home/issues/7817 (which is resolved)

Thanks for pointing that out, @japj!

Duplicate of #NuGet/Home#7817


Building error

Error :
[ 70%] Building CXX object CMakeFiles/tdcore.dir/td/telegram/StickersManager.cpp.o /home/v/tdlight/td/telegram/StickersManager.cpp:8858:112: error: member reference base type 'vector<td::StickerSetId> [3]' is not a structure or union   output.push_back("\"featured_sticker_set_ids_\":"); output.push_back(std::to_string(featured_sticker_set_ids_.size()));                                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ 1 error generated. make[2]: *** [CMakeFiles/tdcore.dir/build.make:2260: CMakeFiles/tdcore.dir/td/telegram/StickersManager.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:464: CMakeFiles/tdcore.dir/all] Error 2 make: *** [Makefile:141: all] Error 2
if change git repo to origin repo of td, then build is completed

I'll fix it tomorrow, thanks


feat: add command builtins

hilbish itself doesnt provide a lot of builtins. the sh interpreter does add a few but the common important ones are not there.
on windows, a lot of the commands available on a linux system are not available (for hopefully obvious reasons), so there is no ls or cat, etc. hilbish should implement them in some capacity to have a closer and similar experience on all platforms (mainly windows)
this includes: ls, clear, cat, etc.

hi, i can do this?

I don't know what the procedure is to collaborate on a project so I'll ask

i really just need suggestions for the commands to add since i already have a branch for the commands (its just called builtins) and if you are gonna pr, do them to the branch

ok, i don't have suggestions but i can look
i saw that don't have ls and cat, will i do ok?

sure


[TO-PR] [Chores] Privacy Report Submission.

name: Chores
ratings:
locationTracking: 1
dataRetention: 1
userControl: 1
darkPatterns: 1
crossSiteTracking: 1
summary: "/privacy-report-card/details/Chores"
reference: "https://chores-561a7.web.app/login"
category: "privacy-report-detail"
contibutors: Bryan Obieyisi<EMAIL_ADDRESS>Chores's Privacy Policy - Summary

They collect hella data. Privacy? Forget it....

This issue was automatically created from an API call.


Working builds

Using https://developer.github.com/v3/repos/statuses/ to wrap the build running in bamboo + commit vendor

The commits here don't fully make sense to me =) I'll try to do vendor + everything else locally to see the picture better.


⚠ Bofrost.de has degraded performance

In 2f4844e, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2055 ms

Resolved: Bofrost.de performance has improved in 3b0c17e after 20 minutes.


Publish RFC :: 0001-working-in-the-open.md

Summary | Résumé
Initial attempt at publishing a 'Working in the Open' strategy, while also putting into place RFC's as a way to drive discussion of upcoming features / changes.
Help requested | Aide requise
[x] Translation before publishing would be ideal.
Reviewer checklist | Liste de vérification du réviseur
This is a suggested checklist of questions reviewers might ask during their review | Voici une suggestion de liste de vérification comprenant des questions que les réviseurs pourraient poser pendant leur examen :

[x ] Does this meet a user need? | Est-ce que ça répond à un besoin utilisateur?
[ ] Is it translated between both offical languages? | Est-ce dans les deux langues officielles?

Who is going to participate to this? And what exactly is being attempted first?

Thanks @EliseKa for the quick turnaround on translation. Merging as is.

Hey @LeCanardQuoi

Who is going to participate to this?

This is written with 'we' referring to the Covid Alert teams here at the Canadian Digital Service.

And what exactly is being attempted first?

I'd refer you back to the RFC as written, it's an attempt at getting more of our work, outside of just the development, more into the open.

Also, if I understand this correctly, no more enhancement request issues are allowed (from the public or core users)???

That is not the intent, it's more to help the teams focus on their inflight tasks in their individual repositories, while creating a more central place for outside collaborators to raise ideas, questions and to start discussions.

The process of managing new reqs (entered via these ERs) remains unclear and opaque imo, i.e. no traceability on decision making which is what I was mainly seeking as part of a "stronger response plan" from the Covid Alert app.

I hope this and future work helps to clear this up for you and others. We'll be publishing the 'Product Decision Framwork' shortly, which should answer some of your questions.
Stay tuned!

Closes his own PR. What a champ! 🥇


"Groșii Țibleșului" is listed in the drop-down menu

Description:
"Groșii Țibleșului" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Groșii Țibleșului" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Groșii Țibleșului, MARAMUREȘ (Groșii Țibleșului)" and "Comuna Groșii Țibleșului, MARAMUREȘ".


the inner product should work for row as well as column vectors

This means that there should be a row vector type or with present types to allow indiscriminately column vectors or row or column matrices to be the arguments of dot.

Is it OK to close this? There is no distinction between column and row vectors, apart from display.

Before we do this can I sum up.
All vectors are column vectors. There are no row vector types.
The inner or dot product as well as the crossproduct only work for vectors.
An nx1 matrix is not a vector. For example, cannot be used in dot or cross products. However a vector can be considered as an nx1 matrix for the purposes of matrix multiplication i.e. as a point being transformed by a linear map and also as the transpose of an nx1 vector produces a 1x n matrix, not a vector. So changes type.
So you can do \var{transpose(vector(a,b,c))*vector(d,e,f)}
Transpose of a m x n matrix is a n x m matrix.
So beware, transpose(transpose(vector)) is not the original vector, it is a matrix.
There is a row vector display type, of the form (a,b,c) this is for convenience for displaying vectors via the rowVector rule or elements in some coordinate space.

From: Christian Perfect<EMAIL_ADDRESS>Sent: 28 November 2011 14:39
To: Bill Foster
Subject: Re: [Numbas] the inner product should work for row as well as column vectors (#94)
Is it OK to close this? There is no distinction between column and row vectors, apart from display.

Reply to this email directly or view it on GitHub:
https://github.com/numbas/Numbas/issues/94#issuecomment-2897516


Github actions test case

Apparently,  tests are passing in travis ci but failing in github actions, could be one or multiple reasons of it, nice to dive into to find underneath cause of failing.
Check : https://github.com/aau-network-security/haaukins/runs/588806660

Github actions acts weird, it sometimes passes the test cases and sometimes now, check this out ; https://github.com/aau-network-security/haaukins/actions


Add Node union

Add a new Node union that is an enum over all node types. This can be useful when implementing methods that can operate on any node. For example, Ruff's formatter has (roughly) the API format(node: AnyNode) -> String
I haven't figured out the full requirements yet, and I don't know yet if we'll need both the owned and reference versions:
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
enum Node {
	IfStmt(ast::IfStmt),
	ConstantExpr(ast::ConstantExpr),
	...
}

#[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, is_macro)]
enum NodeRef<'a> {
	IfStmt(&'a ast::IfStmt),
	ConstantExpr(&'a ast::ConstantExpr)
	...
}

Note: An alternative naming more in line with Path and PathBuf would be to name the types NodeBuf (owned) and Node (reference)

The enums should have the following basic methods:

if_stmt(self) -> Option<ast::IfStmt>
as_if_stmt(&self) -> Option<&ast::IfStmt>
const is_if_stmt(&self) -> bool

Node could also implement AsRef that returns a NodeRef
I may have time to work on this sometime soon but I wanted to put this up for discussion first to get feedback.

Is it not covered by Node trait?
If you need a concrete type of union, it will not be covered. If you need only a common method interface, it will be enough.

Does it need to include all of the nodes, not the top level nodes? I think the top level ast.AST node in Python matches to Rust

pub enum AST {
    Stmt(ast::Stmt),
    Expr(ast::Expr),
    ...
}

Then IfStmt and ConstantExpr will be under each variant.  Do you need to flatten all the nodes?

Is it not covered by Node trait?
In our use case, we need to call the formatting function for the specific node variant, extract all fields and then perform the formatting. We could implement this with the node trait in a suboptimal way if it has a downcast_ref(type) -> Option<T> method that downcasts the node to the given type. However, this would require that Ruff calls downcast_ref for every possible type until it finds the right type. Having an enum would allow us to implement this static-dispatch to the right node.

Does it need to include all of the nodes, not the top level nodes? I think the top level ast.AST node in Python matches to Rust

I haven't thought about it much but we can probably do either and both approaches have pros and cons:

top-level: Fewer variants to handle per level.
flat:

Easier to get to a specific node without nested matches (you can use as_constant_expr directly
Should be smaller because we avoid nested enums.

What do you mean by top level? Do you mean the 'Stmt' and Expr (ond others) enums or something else?
We can also add this to ruff_python_ast first and upstream it when we've figured out the api and you believe that this would be useful for RustPython too

In ast module of python, nodes directly inheriting AST. (= T.__base__ == ast.AST)  This is the full list.

Mod
Stmt
Expr
ExprContext
Boolop
Operator
Unaryop
Cmpop
Comprehension
Excepthandler
Arguments
Arg
Keyword
Alias
Withitem
MatchCase
Pattern
TypeIgnore


X

[اكتب ملاحظاتك هنا]

تفاصيل المستند
⚠ تجنب تحرير هذا القسم. مطلوب لـ docs.microsoft.com ➟ ربط مشكلة GitHub.

ID: 6c12f877-77a9-0593-a539-2b011f9f83cd
Version Independent ID: 0d600bc9-7ec1-27f5-5d27-a5d22e2e8629
Content: Tutorial - Create and publish a product in Azure API Management
Content Source: articles/api-management/api-management-howto-add-products.md
Service: api-management
GitHub Login: @mikebudzynski
Microsoft Alias: apimpm

@XZ07 Can you provide more details on the issue that you are facing on this document.

@XZ07 Just following up here to see if you are facing any document issues.

@XZ07 As there was no response. We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Change priority of getting deviceName for Device class

Priority value for deviceName of Device class will be capabilities.deviceName.
If there are no capabilities.deviceName in configuration, we take deviceName capability from driver capabilities

verified on client's side,fixed


Improve warning language

A few small changes along the way to try and improve the language of (mostly) TLS warnings thrown by Keylime.

This only needs one review! @lukehinds maybe? :slightly_smiling_face:

This only needs one review! @lukehinds maybe? :slightly_smiling_face:


operators camel-k (1.6.1)

Signed-off-by: nicolaferraro<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@nicolaferraro can you fix https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/383#issuecomment-953325689 ?

@nicolaferraro can you fix #383 (comment) ?

Thanks, added

/merge possible

/merge possible

/merge possible

@nicolaferraro maybe you can have a look at doc here and add yourself to reviewer list and then your PR can be merged automatically and you don't have to wait for us to set authorized_changes label for you.

@nicolaferraro maybe you can have a look at doc here and add yourself to reviewer list and then your PR can be merged automatically and you don't have to wait for us to set authorized_changes label for you.

Cool, thanks!