closed #246

Title #246
Issue No. :246
Code Stack :
Close #246
I'm a GSSOC-EXT contributor

@nafri-dev resolve conflicts


Lint

Is it really no code if it doesn't pass markdownlint???
Really just trying to make that contribs page with no effort.

+0 −6 - looking good 👍

Any chance this is going to get merged in and released soon? I need it for a work project.

@klamping I think the maintainer has gone MIA.  Perhaps it is time we start our own distribution?

@tedmiston yeah, it's been about 3 days, so definitely an abandoned project. I'll fork this repo and commit this single change, then not make or accept a single change after that. Seems like the right thing to do.


[core] when use from-timestamp read data from snapshot, if time < earliestSnapshot time , no data return (#3904)

…liestSnapshot time , no data return (#3904)

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

Can you add unit test and solve test failure?

Can you add unit test and solve test failure?

ok,i will resolve it,thks @JingsongLi

in #3904 ,method org.apache.paimon.utils.SnapshotManager#earlierOrEqualTimeMills ,if earliestSnapShot.timeMillis() > timestampMills , will return earliestSnapShot. it will lead to  earliestSnapShot excluded when use incremental-between-timestamp. i had fix it ,please take a look,thks @JingsongLi


Turn off function name warnings for methods implemented in external interfaces

I'm implementing as interface defined in an external package.
Unfortunately the names in the external package interface don't conform to golint standards.
Could golint work out that I'm implementing a method in an interface in an external package and not warn about it?
Example
External library with well established (non golint friendly) method name.
package external

type Authenticator interface {
	CdnUrl() string
}

My code which I can change, but I can't ever get rid of the golint message
package mypackage

import "external"

type auth struct {
}

// golint gives the warning "func CdnUrl should be CdnURL" here
// which this package can't do anything about
func (a *auth) CdnUrl() string {
	return ""
}

// Check the interfaces are satisfied
var _ external.Authenticator = (*auth)(nil)

In general it can't, sorry.

That's what I thought you'd say!
Thanks for looking into it.
Nick


Notification Test

Not an issue. Just test if I can receive notification when any issures are created.

Well. Test is Ok.


Add GetNetIndex function to utils

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

19 of 23 (82.61%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 75.247%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/utils/utils.go
19
23
82.61%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2134

Relevant Lines:
2836

💛  - Coveralls

@adrianchiris @e0ne can you please review this one?

yep we didn't use this one at the end for the sriov operator so I will close this PR.
we can re-open if it will be needed in the future


fixed Remove import React from react

Describe your changes
Removed the React imports from /components and /pages except in the cases described.
Link to issue

Closes #231
Checklist before requesting a review

[✅] I have performed a self-review of my code.
[✅] Followed the repository's Contributing Guidelines.
[✅] I ran the app and tested it locally to verify that it works as expected.
[✅] I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
and it shows no errors.

Hi @ThePlugJumbo can you comment on the issue too so you can be assigned?


ability to disable instrumentation in ThreadPoolTaskExecutor

We have a spring-boot application (spring-boot-starter-parent-2.0.0.RELEASE) using spring-cloud-starter-zipkin for writing "spans" to zipkin.
We use spring-integration too (through spring-boot-starter-integration) and we have added an integration flow with a PollableChannel to be used within a poller:
@Bean
public PollableChannel pollableChannel() {
    return new QueueChannel(100);
}

@Bean
@ServiceActivator(poller = @Poller(taskExecutor="batchTaskExecutor"),
                  inputChannel= "pollableChannel")
public MyHandler myHandler() {
    return new MyHandler();
}

Since adding this configuration, we are having an "asynch" span every second. I raised a question in stackoverflow -> https://stackoverflow.com/questions/51438273/zipkin-asynch-span-every-second. So after investigating the issue, it turned out the span comes from the ThreadPoolTaskExecutor that the @Poller uses to check if there are new items.
I've made an improvement to disable instrumentation of ThreadPoolTaskExecutor based on the name of the executor. You can use spring.sleuth.async.ignoredBeans to configure a list of executors without instrumentation.
For instance, in the previous example:
spring:
  sleuth:
    async:
      ignoredBeans: batchTaskExecutor

@jalogar Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@jalogar Thank you for signing the Contributor License Agreement!

The build is broken due to breaking checkstyle rules. Have you built the project locally?

I've fix them locally. I'll push the changes together with the unit test

Congrats on your first contribution @jalogar !

Hello @marcingrzejszczak , would it be possible to add this commit to the 2.0.x branch?
Regards,
Jesús

Yeah, why not. Feel free to send a pr. Also please update the documentation.

In the docs please put a short example. like...
By default, any tasks started with a scheduler starts a new trace. This is to help understand the root cause of distributed work. Some polling loops do not create distributed work, and can cause "junk traces" in search results. To prevent an executor from starting new traces, set blah.blah. For example, you can disable creating spans for spring integration pollers by excluding the bean name: `batchTaskExecutor`

I'm ok with this, though not sure if this will lead to another change later.. ex batchTaskExecutor, but only exclude poller tasks :D


[Integration support question] [CSS] Text not aligned: "No new message" etc

Hi,
I use Isso (your Docker) with Ghostblog and Liebling theme.
Some text is not aligned, CSS don't apply to it.

https://upandclear.org/on-la-refait/
Here's my client conf

Problem is as I use Docker I don't want to edit files in it (this text seems to be useless to me anyway). Any advice?

I am guessing you want to apply styles to the
 element that displays "No comments so far" in French?
The selector #isso-thread > h4 should be all you need. I see you hid the element with an inline style definition as such:

You could simply do the following:
#isso-thread > h4 {
    text-align: center;
    color: blue;
    /* ... */
}

Or are you trying to make the
 element align horizontally with the post box below it?
Then you should wrap the whole isso area inside a container which is 68em wide.
(See isso.css, the common width for .isso-postbox is 68em)
Alternatively, you could do the following:
section.isso-thread {
    max-width: 68em !important;
    margin: 0 auto;
}

(!important shouldn't be needed since section.isso-thread is already more specific than just .isso-thread, thus taking precedence over definition in vendored isso.css)
Please note that this isn't really a bug for the issue tracker, rather a misunderstanding of how to write CSS on your part.
Closing as such, but feel free to re-open if this somehow really is a bug in isso which you would like addressed, ideally with a corresponding PR.

Hi,
Yeah was talking about "Aucun commentaire pour l'instant". This should be centered by default. Thus I already hide it using code injections as you say

Isso includes a CSS option that centers the comment block, so it seemed logical to me that this text should be too since it depends on it and is almost stuck to it.
Nevermind, thanks for the good work anyway.

For future reference, we've enabled GitHub Discussions (over here) to have a more suitable place for these kinds of questions/requests.
Feel free to try it out!


what's the difference between the two modes.

I have this sample main.html.

        <title>Hello</title>

Hello World!

I placed a bin\windows\x32\scapp.exe in the same directory of main.html, If I double click scapp.exe, the demo app is shown, and the title bar is opaque, when I tried to execute scapp.exe main.html like run-calculator-sciter.bat does, then About ScApp is shown and when I choose to open main.html, the demo app is shown with title bar some transparency.

Also I have noticed the height of title bar of bin\windows\x32\scapp.exe is bigger then sciter-sdk\bin.win\x32\scapp.exe.

Up until recently bin\windows\x32\scapp.exe was using window-frame=extended that means caption and window chrome was defined in HTML/CSS - may differ from system one.
I've switched back to window-frame=standard recently.


Metadata with empty value is dropped.

Describe the bug
The protocol definition states that metadata values may be left out: "[...] The value MAY be empty. In these cases, the space, which would normally separate the key and the value, MAY be left out."
However it seems that tusd is dropping such metadata without a value.
To Reproduce
Steps to reproduce the behavior:

Upload a file to the tus.io demo server (I assume the demo server is using tusd(?), and the same behavior is observable if I start tusd locally.)

$ aiotus-upload http://master.tus.io/files test.bin --metadata is_confidential --metadata key=value
http://master.tus.io/files/0117a6f71...

The captured HTTP traffic of the upload creation is shown below. Note that the Upload-Metadata header contains three metadata items with a value ("filename", "mime_type", and "key") and one item without a key ("is_confidential").
POST /files HTTP/1.1
Host: master.tus.io
Tus-Resumable: 1.0.0
Upload-Length: 10
Upload-Metadata: filename dGVzdC5iaW4=, mime_type YXBwbGljYXRpb24vb2N0ZXQtc3RyZWFt, is_confidential, key dmFsdWU=
Accept: */*
Accept-Encoding: gzip, deflate
User-Agent: Python/3.8 aiohttp/3.6.2
Content-Length: 0
Content-Type: application/octet-stream

HTTP/1.1 201 Created
Server: openresty/<IP_ADDRESS>
Date: Tue, 16 Jun 2020 21:42:23 GMT
Content-Length: 0
Connection: keep-alive
Location: http://master.tus.io/files/0117a6f71a8c855138d548e7ef93d385+T.VAZpfSSs5WK19jNGy1eOugruRLoPNVGy4wNKJ8ud9HdCVxUXgBwH23xc0fIGslUvg7jnlpEckxKusOG.LJTSCiH2iJqlV9zW.0kECchfXLxjpkGChE4yQlwqaUvwD9
Tus-Resumable: 1.0.0
X-Content-Type-Options: nosniff

...

When asking the server for the metadata, the item without a value is not included in the response:

$ aiotus-metadata http://master.tus.io/files/0117a6f71...
key: value
mime_type: application/octet-stream
filename: test.bin

HTTP traffic:
HEAD /files/0117a6f71a8c855138d548e7ef93d385+T.VAZpfSSs5WK19jNGy1eOugruRLoPNVGy4wNKJ8ud9HdCVxUXgBwH23xc0fIGslUvg7jnlpEckxKusOG.LJTSCiH2iJqlV9zW.0kECchfXLxjpkGChE4yQlwqaUvwD9 HTTP/1.1
Host: master.tus.io
Tus-Resumable: 1.0.0
Accept: */*
Accept-Encoding: gzip, deflate
User-Agent: Python/3.8 aiohttp/3.6.2

HTTP/1.1 200 OK
Server: openresty/<IP_ADDRESS>
Date: Tue, 16 Jun 2020 22:02:13 GMT
Connection: keep-alive
Cache-Control: no-store
Tus-Resumable: 1.0.0
Upload-Length: 10
Upload-Metadata: key dmFsdWU=,mime_type YXBwbGljYXRpb24vb2N0ZXQtc3RyZWFt,filename dGVzdC5iaW4=
Upload-Offset: 10
X-Content-Type-Options: nosniff

When testing this with a tusd server running locally, it can be seen that the metadata item without the value is not stored in the .info file, while the other items are:

[...] "MetaData":{"filename":"test.bin","key":"value","mime_type":"application/octet-stream"} [...]

Expected behavior
The server should store and return metadata without values.
Setup details
Please provide following details, if applicable to your situation:

Operating System: Linux
Used tusd version: Whatever version is running on master.tus.io, or v1.3.0 locally
Used tusd data storage: master.tus.io: ?, locally: Disk storage
Used tusd configuration: None
Used tus client library: aiotus, "dev" branch that allows the demo CLI tool to upload metadata without values

Thank you very much for the detailed report! You are correct in that tusd requires a value to be present, which is also mentioned in the code: https://github.com/tus/tusd/blob/c822a3afb1fcd644b161ecda8454c40236f4d8ad/pkg/handler/unrouted_handler.go#L1123-L1126
I am happy to accept a PR for a fix if you are interested :)

The linked merge request maps empty metadata values to empty strings. With this change tusd also stores and returns the metadata keys without values.
Small nitpick: It is still not possible to distinguish the case where the value is completely omitted (Upload-Metadata: key) from the case where the value is an empty string in the beginning and also after base64-encoding it (Upload-Metadata: key , note the space at the end of the header), in both cases the same result would be returned when asking for the metadata later. To make this distinction possible the type used to store the metadata would have to be changed from map[string]string to map[string]*string. I tried this but had several problems:

Changing the type would result in big changes in various places throughout the code of tusd.
map[string]string is also used in the protobuf file for GRPC.
Not all data stores support this. For example, S3 uses map[string]*string and would probably allow it, while GCS also uses map[string]string and does not allow to omit values completely.

Apologies for the delay in my side! I will have a look at your PR in the next few days.

Fixed in #400.


Load cluster information from a user’s kubeconfig

This PR enables you to load cluster information from a user's kubeconfig. When kubeConfigContext is present in the cluster config the KubernetesClientProvider will load the kubernetes config from
the kubeconfig file in the default location. kubeConfigFile can optionally be provided to load config from a different location.
This change enables the full use of all kube config options to access the cluster. The impetus for this change is that I want to be able to use the aws-iam-authenticator to authenticate access with my clusters.
This PR is a proof of concept so that I can get feedback on whether the approach is correct. Once that has been validated I will work to bring it up to spec.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

@mclarke47 do you wanna take a look at this too if you have any ideas here?

Will try to review today!

An alternative way to approach this would be to create a new Cluster provider implementation that takes a kubeconfig location and loads it in using the kubernetes library

@keattang are you still interested in fixing up this PR with @mclarke47's comments?

why was this closed? are there any plans to add support for the kubeconfig file?

@mingfang this was closed because of inactivity - is it something you want to pick up and contribute instead? I don't think you'll be able to recycle the code in here as it wasn't DCO signed, but you could have a go at implementing this with @mclarke47's feedback?

I'm in the middle of building a new KubernetesClustersSupplier and I just realized that the Kubernetes API Server calls are being made by the Backstage Frontend.
Is that true?
If true then that's a show stopper for me.
The clusters that I manage are all on-prem and the firewall forbidden accessing the API Server.


PR #1167 broke OCIO version detection

In PR #1167, alterations to OpenColorABI.h.in removed a defined symbol  OCIO_VERSION in favor of  OCIO_VERSION_STR (which did not exist before).
This breaks other projects that depend on OpenColorIO and expect this symbol to be present. Among other problems, this means that if somebody had a FindOpenColorIO.cmake that looked for OCIO_VERSION to determine the version number, now that fails. If it switches to looking for OCIO_VERSION_STR, then it will fail if it encounters OCIO 1.x. Probably detecting the version in this way is how people enable/disable code paths that allow them to support 1.x or 2.x depending on what it finds, and in this chicken and egg problem, it doesn't know which to look for if it doesn't know which version it's dealing with. It could try to look for BOTH, but that's ugly and in any case it doesn't solve the problem of existing software breaking as soon as it encounters OCIO 2.x.
I would recommend restoring OCIO_VERSION, even if you keep it undocumented and treat it as a deprecated synonym for OCIO_VERSION_STR, so that people depending on the old symbol don't have their builds broken.

Good catch.


Examples in pyadditive v0.17.0 not working

@pkrull-ansys Thank you very much for you hints. Now I am able to correctly run the examples/00_additive_single_bead.py. However, using material = additive.material("316L") , machine.scan_speed = 1, and machine.laser_power = 195 I got zero values in all Melt Pool Dimensions, see plot below:

Originally posted by @maxcarrat90 in https://github.com/ansys/pyadditive/discussions/256#discussioncomment-8472900

@maxcarrat90 This is what I'm seeing using pyadditive v0.17.0 and Ansys 24.1 when running 00_additive_single_bead.py and changing the following values
material = additive.material("316L")
machine.scan_speed = 1  # m/s
machine.laser_power = 195  # W
single-bead-316l-1-195

Were any other edits made to the python file? Line 120 converts from meters to microns. Did it get changed by chance? What does df.head() show (line 145)? Do you see only zeros or nan's for the values?

@pkrull-ansys I have cloned the latest pyadditive version and reinstalled everything to be sure that the python's script are all clean. I attach the melt_pool.csv file and here is what I get on the Python
Console at the end of the simulation:
C:\Users\Massimo\anaconda3\envs\pyAnsys\python.exe "C:\Program Files\ANSYS Inc\PyAnsys\PyAdditive\pyadditive-0.17\examples\00_additive_single_bead.py"
user data path: C:\Users\Massimo\AppData\Local\Ansys Inc\pyadditive
Client 0.18.dev5, API version: 1.5.0
ServerConnectionStatus(connected=True, channel_str='<IP_ADDRESS>:64708', metadata={'Version': '24.1.0-2', 'API version': '1.4.1'})
2024-02-16 09:00:53 Connected to <IP_ADDRESS>:64708
AdditiveMachine
laser_power: 195 W
scan_speed: 1.0 m/s
heater_temperature: 80 °C
layer_thickness: 5e-05 m
beam_diameter: 0.0001 m
starting_layer_angle: 57 °
layer_rotation_angle: 67 °
hatch_spacing: 0.0001 m
slicing_stripe_width: 0.01 m

Single input
Single bead simulation: 100%|██████████| 100/100 [01:24<00:00,  1.19it/s]

Process finished with exit code 0

melt_pool.csv

@maxcarrat90 I'm a bit baffled. I've duplicated your configuration and run the example.
(.venv) 08:35 AM pyadditive $ python examples/00_additive_single_bead.py
2024-02-16 08:36:01 Connected to <IP_ADDRESS>:59008
user data path: C:\Users\pkrull\AppData\Local\Ansys Inc\pyadditive
Client 0.18.dev5, API version: 1.5.0
ServerConnectionStatus(connected=True, channel_str='<IP_ADDRESS>:59008', metadata={'API version': '1.4.1', 'Version': '24.1.0-2'})
AdditiveMachine
laser_power: 195 W
scan_speed: 1.0 m/s
heater_temperature: 80 °C
layer_thickness: 5e-05 m
beam_diameter: 0.0001 m
starting_layer_angle: 57 °
layer_rotation_angle: 67 °
hatch_spacing: 0.0001 m
slicing_stripe_width: 0.01 m

Single input
Single bead simulation: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 100/100 [00:43<00:00,  2.29it/s]

Here are the melt pool statistics I get.
melt_pool.csv
Questions:

Do you get zero values with 316L when using a higher laser power and slower scan speed, say 700 W and 0.5 m/s?
Do you get non-zero values for IN718 using laser power = 195 and scan speed = 1 m/s?

@pkrull-ansys Thanks for your help! Regarding your questions:

File "C:\Program Files\ANSYS Inc\PyAnsys\PyAdditive\pyadditive-0.17\examples\00_additive_single_bead.py", line 108, in
raise Exception(summary.message)
Exception: Exception: INVALID STATE: The melt pool has become too wide and deep to produce valid results (current width = 825.000000 microns, current depth = 1200.000000 microns). We recommend you reduce the energy input by reducing Laser Power and/or increasing Scan Speed.
2024-02-16 18:14:44 Uncaught exception
Traceback (most recent call last):
File "C:\Program Files\ANSYS Inc\PyAnsys\PyAdditive\pyadditive-0.17\examples\00_additive_single_bead.py", line 108, in
raise Exception(summary.message)
Exception: Exception: INVALID STATE: The melt pool has become too wide and deep to produce valid results (current width = 825.000000 microns, current depth = 1200.000000 microns). We recommend you reduce the energy input by reducing Laser Power and/or increasing Scan Speed.

@maxcarrat90 The server seems to be misinterpreting the parameters sent to it. On the host where the server is running, what locale is used? More specifically, what's the default character used for the decimal point? The server should account for different locales but this hasn't received much testing yet.

@pkrull-ansys here what I get checking locale on the powershell:
(pyAnsys) PS C:\Program Files\ANSYS Inc\PyAnsys\PyAdditive> Get-WinSystemLocale

LCID             Name             DisplayName
----             ----             -----------
1033             en-US            Inglese (Stati Uniti)

(pyAnsys) PS C:\Program Files\ANSYS Inc\PyAnsys\PyAdditive>

@maxcarrat90 It looks like your host is set up for Italian. Is that correct?
In %TMP%/additive there should be some folders containing a thermal-input.json file. Delete everything under the additive folder then rerun one of your simulations. Find the thermal-input.json file then compare the values under MachineData to what you used when defining the simulation.

@pkrull-ansys Thank you very much for you support! The issue is now fixed. Now, I would like to run a parametric study using a user defined material and laser beam shape (multi-mode). Would this be possible?

@maxcarrat90 User defined materials are supported. Shaped lasers are not yet supported.
For user defined materials, the pyadditive documentation is a little light and refers you to documentation for our legacy application. Let me know if you need help and I'll answer your questions or put you in touch with someone who can.
PyAdditive examples

https://additive.docs.pyansys.com/version/stable/examples/gallery_examples/04_using_a_custom_material.html#sphx-glr-examples-gallery-examples-04-using-a-custom-material-py
https://additive.docs.pyansys.com/version/stable/examples/gallery_examples/10_advanced_custom_material_tuning.html#sphx-glr-examples-gallery-examples-10-advanced-custom-material-tuning-py

Custom material further information

https://ansyshelp.ansys.com/account/secured?returnurl=/Views/Secured/corp/v241/en/add_print/add_UserDefMatl.html
https://ansyshelp.ansys.com/account/secured?returnurl=/Views/Secured/corp/v241/en/add_beta/add_science_BETA_material_tuning_tool.html

@pkrull-ansys Thank you for the links!
Would it be possible to contribute in developing shaped laser functions? I need this feature within a research project framework and I can work on its implementation.

@maxcarrat90 Unfortunately, I think it would likely be used in our thermal solver, which is not open source. We do have a shaped laser feature in our backlog. If you can write up a feature request as an issue for pyadditive, I can see if what we intend meets your needs or whether we can modify it to meet your needs.


Document versioning prefix exclusion

Summary
We added a feature a little while back that allows exclusion of prefixes from versioning. This primarily helps Spark/Hadoop or similar workloads that do a lot of PUT/GET/DELETEs on a single file namespace - with versioning this results in a build-up of versions that can slow down listing over time.
the mc version enable ALIAS/BUCKET --excluded-prefixes "prefix,[prefix,...]" argument adds this from the commandline. The MinIO Console may also have prefix exclusion.
There are a few quirks:

this doesn't work (or shouldn't work) on a bucket with object locking enabled
Adding or removing prefixes requires specifying the entire set of excluded prefixes. using mc version info --json lets you pull down the current list of excluded prefixes
Wildcard matching matters. "/foo" will only match the prefix ALIAS/BUCKET/foo/*. Needs testing

@ravindk89 I'll pick up this one

Thus it is yours

The same commit that added --excluded-prefixes also created --exclude-folders, invoked like so:
mc version enable --exclude-folders local/test-bucket

It prevents versioning of anything whose name ends in /, so basically folders. @krisis gave me a lot of detail on both, I'm testing --exclude-folders so I can doc it as well.


[CHORE] Encapsulate mods and call by object

The purpose of this change is to bundle atomic mods into a single JS file and source that file in the KES headers, rather than making 40+ requests. As a side effect, it simplifies the function entry logic and cleans up the auto masthead.
To be changed

[ ] Refactor all mods in mod directory such that they are encapsulated with an outer function. All internal functions must be private
[x] Refactor KES generation script to concatenate mod contents into an object with qualified key names

Mod dirname, file basename, and key name must be identical (key name is inherited from basename)
Check for namespace collisions when approving PRs (could be automated)

[ ] Refactor function entry logic to interpolate stringwise mod names from manifest:

let mod = json[i].entrypoint
funcObj[mod](bool)

To be removed

[ ]  ESLint global exports from KES masthead
[ ] Legacy funcObj from KES masthead
[ ] Should mod authors manually insert the entrypoint key, or should this be automated?

To be added

[ ] Add concatenated functions file to @requires headers

TODO

[ ] Integration test refactored mods in the context of KES at runtime
[ ] Update docs re: API changes

This issue has implications for #253 (and as a side effect, ameliorates the headroom issue from #252), https://github.com/Pamasich/kbin-kes/issues/63, and https://github.com/Pamasich/kbin-kes/issues/64

I do have one more question in regards to refactoring the mods. I currently have a documentation comment on the entrypoint function or class (if I used one) of my mods.
Like this example from the one I just submitted:
/**
 * This mod aims to fix a current kbin issue.
 * On some views, like All Content, the pagination is broken. The arrows behave like they're on
 * the first page, regardless of which they're actually on. This mod is meant to fix the issue
 * by manually rewriting the arrows to work correctly.
 *
 * @param {Boolean} isActive Whether the mod has been turned on
 */
function fixPaginationArrows (isActive) {

Do I need to move those inside the function if I want to keep them? Or does it not matter?

I was just testing it slightly, and don't think it would have any adverse implications, since anything commented out is just going to get added in verbatim into the concatenated file and ignored:
const funcObj = {
    hide-reputation:

    // ==UserScript==
    // @name         kbin Vote Hider
    // @namespace    https://github.com/aclist
    // @version      0.2
    // @description  Hide upvotes, downvotes, and karma
    // @author       artillect
    // @match        https://kbin.social/*
    // @license      MIT
    // ==/UserScript==

    function hideReputation (toggle) {
        if (toggle) {
            $('#sidebar > section.section.user-info > ul > li:nth-child(2)').hide();
            document.styleSheets[0].addRule('.user-popover ul li:nth-of-type(2)','display:none')
        } else {
            $('#sidebar > section.section.user-info > ul > li:nth-child(2)').show();
            document.styleSheets[0].addRule('.user-popover ul li:nth-of-type(2)','display:initial')
        }
    }

    hide-sidebar:

    function hideSidebar (toggle) {

        const obj = {
            sidebar: '#sidebar',
            mags: '#sidebar > .related-magazines',
            users: '#sidebar > .active-users',
            posts: '#sidebar > .posts',
            threads: '#sidebar > .entries',
            instance: '#sidebar > .kbin-promo',
            intro: '.sidebar-options > .intro'
        }

        const settings = getModSettings('hide-sidebar');

        const keys = Object.keys(obj);

        if (toggle) {
            for (let i = 0; i< keys.length; i++) {
                let key = keys[i]
                if (settings[key]) {
                    $(obj[key]).hide();
                } else {
                    $(obj[key]).show();
                }
            }
        } else {
            for (let i = 0; i< keys.length; i++) {
                let key = keys[i]
                $(obj[key]).show();
            }
        }
    }
 }

As for whether this pollutes the file, I don't think so. Concatenation should be agnostic about the contents of those mods and doesn't need to scrub comments or other markup.

After flattening all of the mod directories to underscores (hyphens weren't working in identifiers in the object-of-functions), it seems to be working on the branch https://github.com/aclist/kbin-kes/tree/patch/func-obj. I also updated the manifest and func.js generators accordingly. I did have to make one change to the alt-content-access mod in order for it to comply: https://github.com/aclist/kbin-kes/commit/5735831468117ea5130e9b1d581f1920ca024941. I know this looks a bit weird, but it works.

I noticed that this change seems to ignore mod settings in localStorage when using the testing branch version on kbin.social, with everything reverted to the default state of OFF. Was it always the case that mod settings are local to a particular branch version? When I use the stable version of KES on the main branch, it loads local mod settings correctly. Or did this patch inadvertently change something about how localStorage namespaces are used by mods?

Was it always the case that mod settings are local to a particular branch version?

No. I have KES installed twice (once the stable version and once my own testing version from my tests branch).  I then turned it on and switched back to the one I was originally using. It was on there too.
So this seems to be a new issue.

Ah, it's because I renamed the entrypoint keys to match the directory names, whereas the old localStorage uses the original entrypoints defined in the manifest. Will have to think about whether to go back to the legacy names or whether there should be a migration function to update the localStorage.

This should be fixed in https://github.com/aclist/kbin-kes/commit/cd558f7b5cad8990cd0bd491bf2b0fd4ae67f8b9; I made a mapping from legacy localStorage names to the new versions, and this will perform a check before initializing the mods. If an old settings stub is found, it gets removed and updated with the new key name, and if it was previously set to on, that setting is inherited.
This should ensure that migrating from the old to new names is transparent to the user and happens one time, after which time they are on the new names.
Eventually, we can drop this logic, but this would break people carrying over very old backup files and trying to restore them at some later date, unaware of this change. Will probably have to issue an advisory after release warning users to backup their settings file again to reflect the new structure.

Closing as resolved


Apply casing to artifact.xml example

@mairaw per https://github.com/dotnet/sdk/pull/1487 :tada: :balloon:

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Does this work on the current version @guardrex?
/cc @eerhardt @nguerrera

Since comparisons are case insensitive, I think the file will work either way. However, a file produced today will not look like this. Even the spacing that @dasmulli fixed will be messed up. U could sit on this, of course, if they get it into 2.0.1. Otherwise, let me know if u prefer to just have a tracking issue for later, and I convert this into an issue.

So the docs should show the current behavior. I haven't personally tested this yet to see the results. If this is not how the files are generated today, we should log an issue for vnext.

@mairaw The prob I had was that the current output has even bad spacing ... remember? "super embarrassing" lol ... so I corrected the spacing but I left the package names in lowercase. The current example in the topic is a hybrid of reality and @dasMulli fixing it. I split the difference! :grinning:
To make it look like the actual version, it should look like this (baaaaad spacing) ...
<StoreArtifacts>
   <Package Id="castle.core"  Version ="4.1.0"/>
   <Package Id="moq"  Version ="4.7.63"/>
   <Package Id="newtonsoft.json"  Version ="10.0.3"/>
</StoreArtifacts>

Problem now tho is that I just  tried to repro this locally and hit a big :boom:. AFAICT the dotnet store command is broken with the 2.0.1 servicing release. I'll try dropping back to 2.0.0 to see if I can get it to work and get back to u.

So should we just make it clear this is not the auto-generated version but the good version to use? Thanks for investigating this. I can look at this later.

When a dev does a ...
dotnet publish --manifest manifest.xml

or via the project file ...
<PropertyGroup>
  <TargetManifestFiles>manifest.xml</TargetManifestFiles>
</PropertyGroup>

In theory (of course! lol), it won't matter and the file will work either way. It just looks bad that the file formatting is all goofy.
The more immediate prob tho is that I can't even get the instructions from the topic to work at all. I'm investigating now to see if I can get 2.0.0 CLI to work.

@mairaw :cry: broken. I'll open an issue and see what they say, but it worked with preview 2.0 and it :boom: now. It doesn't error out. It just hangs after ...

Property reassignment: $(GenerateNuspecDependsOn)="Build;_LoadPackInputItems; _WalkEachTargetPerFramework; _GetPackageFiles; " (previous value: "_LoadPackInputItems; _WalkEachTargetPerFramework; _GetPackageFiles; ") at C:\Program Files\dotnet\sdk\2.0.0\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets (43,5)

@mairaw kk let's see what they say ... https://github.com/dotnet/cli/issues/7481

@mairaw I propose both patch updates are closed at https://github.com/dotnet/docs/pull/2949#issuecomment-323596514 in favor of a proper set of fixes. If u want to go that way, just say the magic words .... :sparkles: Make It Happen!:tm: :sparkles: :grinning:

Does this work on the current version ?

dotnet publish --manifest supports any valid XML whitespace and the case of the Package Id is case insensitive.
We have tests that use the normal casing:
https://github.com/dotnet/cli/blob/master/TestAssets/TestProjects/FluentProfile/FluentFilterProfile.xml
https://github.com/dotnet/cli/blob/master/TestAssets/TestProjects/NewtonsoftProfile/NewtonsoftFilterProfile.xml
<StoreArtifacts>
    <Package Id="Newtonsoft.Json" Version ="9.0.1"/>
</StoreArtifacts>

So if it works, this should be good to merge, right @guardrex?

I think showing the nice looking 2.1 version of the file is best. However if a dev inspects an artifacts.xml today, they'll see the nasty version.
Could mark this for 2.1 and wait, but that begs the question if in addition to the lowercase package names should the file shown in the topic also get the foul whitespace ..  I mean make it look exactly like the tooling produces it today ... warts and all. :frog:

@DamianEdwards what do you think? Should we show in the runtime store topic the current behavior or wait until the issue is solved?
@guardrex And what it is about the foul whitespace? Does the topic work as-is now?

This is what it looks like until 2.1 ...
<StoreArtifacts>
   <Package Id="castle.core"  Version ="4.1.0"/>
   <Package Id="moq"  Version ="4.7.63"/>
   <Package Id="newtonsoft.json"  Version ="10.0.3"/>
</StoreArtifacts>

Lower-case package names (which work, of course) and foul spacing around the "Version" attributes (also works).
However, it's rather ugly imo and thus kind'a nasty to show to people. I felt it was so ugly that I made a compromise with myself ... left the lower-case package names but fixed the spacing when I wrote the topic.
This PR seeks to fix the lower-case package names. That's really a 2.1 fix ... but ... but ... the foul spacing is really a 2.1 fix, too.

Got it. Thanks for explaining to me @guardrex. So, I think people can get confused when the output doesn't match what they're doing. My vote (even if it's ugly ATM) would be to wait until fix is done.

kk ... I'm just glad it'll be fixed. It's confusing to show package names cased all over the place then not in the file. Might leave a dev wondering, "Do they have to be lower-case for the file to work?"
I can patch the current topic and make it the Janet Jackson nasty file layout :smile: if you want ... let me know. Later at 2.1, I can come back for a 🌹 file beautification 🌷 pass.

What do you have against Janet Jackson? 😄
Let's see if @DamianEdwards has a different opinion on this. And I thought the current version already showed the nasty layout. when you wrote, did you beautify it a bit?

Beautified just a bit ...
It's the "Ms. Jackson" version right now. I couldn't stand that spacing. It gave me nightmares. :ghost:

@mairaw I just put in https://github.com/dotnet/docs/pull/3268 ... I'll come back at 2.1 and fix it up. Do you want to close here and take https://github.com/dotnet/docs/pull/3268 for now?


The tensor selector UI in multi-tensor space view is glitchy

At the very least, it requires more item_spacing.

Superseded by  #6387


Websocket get not working

I'm having a strange issue when using the websocket, when the below is in the console, everything works:
  |>
\___/

sails.io.js:200  `io.socket` connected successfully.
(for help, see: http://sailsjs.org/#!documentation/reference/BrowserSDK/BrowserSDK.html)

But if not nothing happens, you can view this happening here: http://ngsnipp.com/

We need to see how your configuration is set up in the code. What version of sails and sails.io are you using?

M issue was that I had upgraded to v0.11.0 but my sails.io wasn't the latest.
Please close this issue, sorry!


Same description for two nullable contexts

Two modes in https://docs.microsoft.com/en-us/dotnet/csharp/nullable-references#nullable-contexts have the same functional description in the sub-bullets:

annotations: The nullable annotation context is enabled. The nullable warning context is disabled.

Variables of a reference type are oblivious. All nullability warnings are disabled.

disable: The nullable annotation context is disabled. The nullable warning context is disabled.

Variables of a reference type are oblivious, just like earlier versions of C#. All nullability warnings are disabled.

Should the sub-bullet for annotations: be:

Variables of a reference type, string for example, are non-nullable. All nullability warnings are disabled.

?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a690704d-da32-dca7-ea3e-66b84fb1d00d
Version Independent ID: 11f314de-dd3a-362e-b2bb-d0a2133cfc7b
Content: Nullable reference types
Content Source: docs/csharp/nullable-references.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@reisenberger Thanks for spotting this.  Your analysis is correct; the fix is the updated text in the description of this issue.
I've added the "up for grabs" label, if you want to submit a PR for this issue.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1073

Questions ?
Please refer to the Backport tool documentation


cannot override applied classes

If I enter the following in the index.svelte file:
<button class="btn-red text-green-400">
  Click me
(from index.svelte, components layer)
</button>

The .btn-red clases are not applied, the text-green-400 overrides them all.
On the other hand, if I do the same on the app.postcss file it works as expected.
Complete example:

<button class="btn-red text-green-400">
  Click me

</button>

<button class="btn-indigo text-green-400">
  Click me

</button>

/* app.postcss */
@tailwind base;
@tailwind components;
@tailwind utilities;

@layer components {
  .btn-indigo {
    @apply py-2 px-4 bg-indigo-500 text-white font-semibold rounded-lg shadow-md hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-indigo-400 focus:ring-opacity-75;
  }
}

output:

Don't wrap it in a components layer -- you're already in a component file!

yes, that's the first thing I tried, I asked at SO and was told that I have to inlude it in a components layer:

This is a property of CSS, not tailwind. The specificity of your selector is greater than that of tailwinds utility classes. You can use the @layer directive to fix this by defining your class

from tailwind docs:

Tailwind will automatically move any CSS within a @layer directive to the same place as the corresponding @tailwind rule, so you don't have to worry as much about authoring your CSS in a specific order to avoid specificity issues.

from SO question
If I don't include it in a components layer I can't override the settings.
here's the example:

<button class="btn-red text-green-400">
	Click me

</button>

<button class="btn-indigo text-green-400">
	Click me

</button>

<button class="btn-blue text-green-400">
	Click me

</button>

and the output

The only way I could make it work is from app.postcss inside a components layer. I guess it should work the same from a component.

Last I checked, Svelte style encapsulation adds an extra class to .btn-red (something along the lines of .btn-red.s-d12a3e) that causes "component classes" to have higher specificity than an @layer directive can solve.
Additionally, it's possible there are purge issues (I only tested in JIT) because @layer causes the rules inside it to be subject to purging; they should be preserved though because the paths are included...).

I tried to debug a little bit the issue
Apperantly the clases generated from the index.svelte componente go to a .svelte/output/client/_app/assets/pages/index.svelte-e3097bc8.css frile like this:

.btn-blue.svelte-kwltzd {
	--tw-bg-opacity: 1;
	background-color: rgba(59, 130, 246, var(--tw-bg-opacity))
}

.btn-blue.svelte-kwltzd:hover {
	--tw-bg-opacity: 1;
	background-color: rgba(29, 78, 216, var(--tw-bg-opacity))
}
[...]
.btn-red.svelte-kwltzd {
	--tw-bg-opacity: 1;
	background-color: rgba(239, 68, 68, var(--tw-bg-opacity))
}

.btn-red.svelte-kwltzd:hover {
	--tw-bg-opacity: 1;
	background-color: rgba(185, 28, 28, var(--tw-bg-opacity))
}
[...]

And the cases from app.postcss goes to `.svelte/output/client/_app/assets/pages/$layout.svelte-d9921e96.css'
right after several css reset settings and before several classes that seem to be tailwind utilities
[...]
img,
video {
	height: auto;
	max-width: 100%
}

.btn-indigo {
	--tw-bg-opacity: 1;
	background-color: rgba(99, 102, 241, var(--tw-bg-opacity))
}

.btn-indigo:hover {
	--tw-bg-opacity: 1;
	background-color: rgba(67, 56, 202, var(--tw-bg-opacity))
}
[..]

.btn-indigo {
	--tw-text-opacity: 1;
	color: rgba(255, 255, 255, var(--tw-text-opacity))
}

.bg-red-500 {
	--tw-bg-opacity: 1;
	background-color: rgba(239, 68, 68, var(--tw-bg-opacity))
}

.bg-blue-500 {
	--tw-bg-opacity: 1;
	background-color: rgba(59, 130, 246, var(--tw-bg-opacity))
}

.hover\:bg-red-700:hover {
	--tw-bg-opacity: 1;
	background-color: rgba(185, 28, 28, var(--tw-bg-opacity))
}

I'm trying to understand why it works from the app.postcss file and not from the component, to see how it could be fixed

Svelte component styles are not added to the global stylesheet.

right after several css reset settings and before several classes that seem to be tailwind utilities
Correct, that's because the component layer is between the base layer (where the resets are) and the utilities layer.

Well, I guess Svelte' scoping css system is somehow messing with tailwind apply directive.
I don't know how to debug it, but all of the sudden I can't apply a class created with apply from app.postcss in the components (or base layer). It used to work but all of the sudden it stopped working.
It makes extracting common clases with @apply a trial an error process, where you have to just try what works and what doesn't

For example, right now I get:
✓ 45 modules transformed.
[vite-plugin-svelte] /home/sas/devel/apps/glas-it/apps/89transfers/src/89transfers-fe/src/lib/components/RatingStars.svelte:17:5: The `mb-p1` class does not exist. If `mb-p1` is a custom class, make sure it is defined within a `@layer` directive.
file: /home/sas/devel/apps/glas-it/apps/89transfers/src/89transfers-fe/src/lib/components/RatingStars.svelte
> /home/sas/devel/apps/glas-it/apps/89transfers/src/89transfers-fe/src/lib/components/RatingStars.svelte:17:5: The `mb-p1` class does not exist. If `mb-p1` is a custom class, make sure it is defined within a `@layer` directive.
CssSyntaxError: /home/sas/devel/apps/glas-it/apps/89transfers/src/89transfers-fe/src/lib/components/RatingStars.svelte:17:5: The `mb-p1` class does not exist. If `mb-p1` is a custom class, make sure it is defined within a `@layer` directive.

even thought I have this in my app.postcss
@layer components {

  /* mobile type scale */
  .mb-h1 {
    font-size: 2.5rem;                  /* 40px */
    line-height: 3.625rem;              /* 58px */
    @apply font-serif font-bold
  }
[...]

It works ok on dev, and on production, I only get this error when building with a  export const prerender = true;
I'll try the same without jit, to see if that's the problem

Well, I guess Svelte' scoping css system is somehow messing with tailwind apply directive.
I don't know how to debug it, but all of the sudden I can't apply a class created with apply from app.postcss in the components (or base layer). It used to work but all of the sudden it stopped working.
It makes extracting common clases with @apply a trial an error process, where you have to just try what works and what doesn't

I don't think that's an all of the sudden thing because it should've never worked. Stylesheets are processed independently, so the style blocks in Svelte files have no knowledge of app.postcss. Instead, use Tailwind plugins to add extracted components (i.e. created with @apply) you want available everywhere.
But design-wise it doesn't make sense to do this because you already have Svelte component files for deduplicating markup and behavior in addition to style.

By the way, thanks for your interest to the project and reporting your comments and findings here! It's really helpful both to me and people reading it (even if how Svelte, SvelteKit, and Vite work is out of my control or if I sound impatient).


Maps are not displayed in configured order/with configured display names

My worlds are configured the following way in config/pl3xmap/config.yml:
<snip beginning of file with commented config options>
  world:
    enabled: true
    render:
      renderers:
        basic: overworld_basic
        night: overworld_night
        biomes: overworld_biomes
        inhabited: inhabited
        flowermap: flowermap
    ui:
      display-name: Overworld
      order: 0
  world_nether:
    render:
      renderers:
        basic: nether_basic
        night: nether_night
        biomes: nether_biomes
        inhabited: inhabited
      skylight: 0
    ui:
      display-name: The Nether
      order: 1
  world_the_end:
    render:
      renderers:
        basic: the_end_basic
        night: the_end_night
        biomes: the_end_biomes
        inhabited: inhabited
      skylight: 0
    ui:
      display-name: The End
      order: 2

In the browser, this is how the maps are displayed:

the_end is displayed above the_nether but its order field is greater than that of the_nether.
The configured display names are not used in the UI either.

I just noticed that my config includes a flowermap for the overworld which the web client also doesn't display as an available option.

Your config is using the default Bukkit names for the worlds. Your worlds are actually named what you see, like minecraft:overworld. So these are what you need to use as your worlds in the config.
  minecraft:overworld:
    enabled: true
    render:
      renderers:
        basic: overworld_basic
        night: overworld_night
        biomes: overworld_biomes
        inhabited: inhabited
        flowermap: flowermap
    ui:
      display-name: Overworld
      order: 0
  minecraft:the_nether:
    render:
      renderers:
        basic: nether_basic
        night: nether_night
        biomes: nether_biomes
        inhabited: inhabited
      skylight: 0
    ui:
      display-name: The Nether
      order: 1
  minecraft:the_end:
    render:
      renderers:
        basic: the_end_basic
        night: the_end_night
        biomes: the_end_biomes
        inhabited: inhabited
      skylight: 0
    ui:
      display-name: The End
      order: 2

I'll leave this open as a reminder that I still need to find a clean way to automate this depending on the platform being used.

Oh, that works perfectly, thanks :)

I assumed that the generated config would use the correct names, but it apparently did not. This all happened on fabric.

I'll leave this open as a reminder that I still need to find a clean way to automate this depending on the platform being used.

Starting with build 428 the world names in the config will be correctly named in the config according to the platform you are running \o/


Search By memo

Hello, it is possible to search for transactions by "memo"?
 client.getTransactions(req.query.address, 0).then(r => {});

Hello, it is possible to search for transactions by "memo"?
 client.getTransactions(req.query.address, 0).then(r => {});

There is no index based on memo yet


fixed typos and  grammatical errors

Also corrected the sentence construction in the main paragraphs and notes @xelizondo @dsk-2015

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions


Add link to GitHub repo in footer of documentation (or some flag top right to contribute to documentation)

Explore the following Sphinx plugin:
https://pypi.python.org/pypi/sphinxcontrib-srclinks

All of our builds have "Edit in GitHub" links now, just like Read The Docs website.


During Pause stop video display on media monitor

Hi Anthony,
A feature request for a sign language congregation. Sometimes they play videos, but need to pause in between. Is there a way to stop the video display, so that it  switches back to jwlibrary or the signlanguage app easily , as no output is send to the mediamonitor.
Maybe this could be an optional setting
Thanks,

Hi. Thanks for your feedback. Please would you describe exactly what the requirement is? Tell me what you click and what happens - just as though the software actually works as you want it to.

Anthony,
When you click on pause during video. The media monitor is not occupied(as if the video has ended) and jwlibrary comes back up.
Thanks,

@sewru It seems to me that this is niche requirement and one that has a suitable work-around (alt-tab as described above). I am closing now. Sorry I won't be working on this request but I don't have time to implement all the good ideas! Thanks for your feedback.


chore: typing part 1

Started introducing typing in the library.

discover.py
security.py

Codecov Report
Attention: Patch coverage is 66.03774% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 4.13%. Comparing base (c8bc516) to head (e2be518).
Report is 1 commits behind head on main.

Files
Patch %
Lines

midealocal/security.py
77.77%
10 Missing :warning:

midealocal/discover.py
0.00%
8 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #26      +/-   ##
========================================
+ Coverage   4.10%   4.13%   +0.02%
========================================
  Files         77      77
  Lines       6571    6577       +6
========================================
+ Hits         270     272       +2
- Misses      6301    6305       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dirty count for provider native keys + cleanup

When the internal key of a provider native EVP_PKEY is modified, the dirty count wasn't updated, which might lead to diverse exports in the export cache not being properly replaced, and operations being performed with earlier (incorrect) versions of the key.
This is very simply fixed by having EVP_PKEY_set_params() update the dirty count.  Other than that, we make sure that EVP_PKEY_set_params() is used, rather than direct calls to evp_keymgmt_set_params().
I took the opportunity to do a little more cleanup.

Making this WIP for the moment, there are a few more spots to clean up

This is now completed as far as I can grep.  The CIs will determine if I forgot something, but this is otherwise ready for final review

I had forgotten to modify evp_keymgmt_util_export_to_provider() to actually handle the dirty count for provider native origin keys.  Fixup added.
I also rebased to a more recent master, to integrate with the recently merged locking additions.

This pull request is ready to merge

Merged to master.


golangci-lint: 1.55.2 -> 1.56.1

Description of changes
This pr should close https://github.com/NixOS/nixpkgs/pull/287010.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Just pushed this commit to my PR #287010 to have the hash and history cleaned up.


Add retryable AOSS HTTP response

Description
Add retryable AOSS http response.
Please check the linked issue.
For AOSS, retry if status code is 400 and error message contains "resource_already_exists_exception"
Related Issues

#950

Tests
WIP
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This approach tries to parse http response and would retry based on content of response. This really shouldn't be done as for majority of SUCCESS case, the response could be huge (for SELECT queries).
Need to find another way to retry only the update mapping request. Ideally AOSS should return 409 for this error so we can just use the http status code for retry.

Shall we backport to 0.6? Is 0.6.1 the next release?

yes

rebased for the sbt error in CI
there's one new commit before that: https://github.com/opensearch-project/opensearch-spark/pull/951/commits/1942b80fa2fd865cd826be8c8c4e4ec187e72dee


geo replication private endpoint

Hi,
I have recently faced an issue with setting up geo replication with private endpoint. The documented method only works if dynamic IP address for the nic is configured and also if a private endpoint has not been created. If a private endpoint has been pre created and attached to the ACR the geo replication will fail. This step needs to be highlighted in the troubleshooting steps. If you want to retain a static IP address this has to be set during the deployment.

@dpatel124
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

@dpatel124
It would be great if you could add a link to the documentation you are following for these steps so that we can assist you more effectively!

@dpatel124
Thank you for your feedback!
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.

Hi,
It is raise the document is not accurate with our finding. We've worked
with support who were attempting to assist us but I managed to fix the
issue myself . whilst reading the doc and i know the solution I've posted
is not documented so I thought it would help to spread our findings. If
this is not correct then I'm happy for the case to close.
On Tue, 6 Feb 2024, 07:00 AjayBathini-MSFT, @.***>
wrote:

@dpatel124 https://github.com/dpatel124
Thank you for your feedback!
Since this issue isn't directly related to improving our docs, and to gain
a better understanding of your issue, I'd recommend working closer with our
support team via an [Azure support request] (
https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request).
Or you can leverage our Q&A forum by posting your issue there so our
community, and MVPs can further assist you in troubleshooting this issue or
finding potential workarounds.
[Teams Q&A forum] (
https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html)
for technical questions about the configuration and administration of
Microsoft Teams on Windows.
[Microsoft Teams Community forum] (
https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1
)
Thank you for your time and patience throughout this issue.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/119443#issuecomment-1928896145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASID4KLQVEGJTYRB5IQERKLYSHIJ3AVCNFSM6AAAAABCWI5NK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYHA4TMMJUGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@dpatel124
Thanks for your contribution. Please add your ideas in below link, so our production team can review it and update the same.
Ideas · Community (azure.com)


Hotfix to update Closing Form PDF

Updated the PDF.  There was a problem with the page number in the previous one.

@cfarm @virginiacc Please review

this looks good


Added className to components

Resolves #309
Impact: minor
Type: feature
Component
Added className property to all applicable components.
Testing

Pass className when using components in this library.

🚀 Preview deployed
Built with commit 36add4e541a204ff8ac687f01ffadcfb2e504e90
https://deploy-preview-322--stoic-hodgkin-c0179e.netlify.com

:tada: This PR is included in version 0.44.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Needs Discussion] Options For Helping Salvage Monotony

Information/Previous Discussion
The discord user SpectralSpices has brought up a feeling of monotony when it comes to salvage currently due to the weighting of salvage wrecks being morso to randomly generated asteroids. This issue is to discuss ways we could potentially relieve that, or if its a non-issue.
Proposed Solutions

Rebalance the weighting/chances of wrecks. Currently, to my understanding, its weighted to be more so for asteroids due to balancing. This is probably the worst of the options, at least in my opinion.

Adding additional magnet options/magnet type. Salvagers could change the magnet (Likely through a verb) to set it to only pull in specific wreck types (Currently only debris and asteroids), but this would drastically increase the cooldown of the magnet as well as potentially a timer to bring in the wreck. The original both debris and asteroid option would remain. The cooldown extension would purely be for balancing,

So, the question is now the following:
Is this even an issue to begin with, how much of the community this monotonous feeling when doing salvage?
If its an issue, which option are we going to assume is best to implement to fix it, is there a third or fourth option?

I've been thinking a lot about this over the past week. Salvage is probably my favourite role alongside detective, and adding some more flavour to the role has the potential to add some good things, maybe even allow other departments to have some more involvement.
Salvage does have a tendency to drag a bit, especially if you're running solo and only realistically able to do magnet runs. For teams focusing on expeditions, there's always more loot, but there's not necessarily much that the station NEEDS when cargo is rich, you've got cloning etc.
For me, just going on the expedition and exploring is where most of the fun lies for me.
Overall, I feel like salvage does have even more potential to become monotonous with the shift times we can expect to see in this fork.
I agree that point 1 is not a good option.
With regards to point two:
How about an advanced salvage magnet, locked behind sci research (tier 2?)? It would have its own board so can be built in situ, and could have the ability to attune to particular types of salvage. Want roids? Attune it to roids and the chance of getting a roid is now significantly higher and vice versa for station debris.
Perhaps it could be an upgradable machine. Upgrades could influence:

Increased hold time.
Higher chance of rare debris (good for endgame salvaging).

The main tradeoff being that the cooldown would be higher than the regular magnet, and this cannot be reduced. However, this feels like a fair trade-off for the ability to choose debris and have more time on it.
Obviously there would need to be some way of preventing multiple magents from being used, as that could easily be powergamed.
Another thought I'd had was some kinda expansion to being marooned on the expedition planet.
Right now it's just 'vwoop, you're gone' and that's it. Salvage is of course meant to be high risk, and it should stay that way, but maybe we could consider an emergency beacon or emergency teleport of sorts for salvagers.
Again, sci research locked, requires a fuel of sorts to charge it (it shouldn't be something cheap) and it's a machine installed on The Reclaimer that teleports any alive salvagers that aren't on board onto the ship when the expedition timer runs out, and teleports any dead ones at the moment of death. Cost could be per salvager.
Could be too powerful, possibly. I don't want to take the risk out of the job, because the risk is what makes it so much fun. Might be nice to have a bit of insurance for when things go REALLY wrong, however, so the department isn't just...empty.
Little bit of a brain dump, but these are my thoughts so far.

It seems like this is partially upstream as well as the extended roundtimers for here. I think I have a couple ideas of what we could do to help with this, and I'll probably throw them in a design document or another issue once people are done discussing here, we'll see.

Agree. The increased exped time is such an enormous breath of fresh air. As a frequent salvor, it's so nice to be able to have time to just explore the planet and rp with the team instead of rushing to grab as much as possible.

I think this is what I'm leaning towards, its what I was thinking with point 2, just put in some clearer words. I think an increased hold time upgrade might be a bit weird, but not impossible. An additional trade-off that I strongly recommend would be increasing the cooldown in-between uses if you are pulling in a specific type of debris. I agree here, for the most part.

Oh yeah, increasing the cooldown is a must. Would be too powerful otherwise.

The simple way to do this would be to give magnets a global cooldown. Use one and it causes both to be on cooldown. Use one that has a higher cooldown? It applies to both.

Agree. Simplest and best way.

A guaranteed teleport seems a bit strong and the timer on expeditions should still be an active threat. I wouldn't be opposed to a research that allows salvagers a beacon, like you said, that for a limited time will allow shuttles to return to that expedition planet. Though this should probably be a pretty expensive research. A teleporter doesn't make a whole lot of sense to me, personally. I'm open to a lot, I'd just like to make sure expedition timers are still an active threat.

Maybe we could add an implant that when you die it activates and starts beeping for a few moments? Could be useful to help track down dead/downed salvagers. Once it gets used, or the person is revived, a new one has to be implanted.
Yeah, the teleporting idea felt a bit strong, but I thought I'd just throw it out there.
An emergency beacon would be a simpler and more roleplayable option. Here's a bit of a step by step method on how I envision it working:

Salvor dies on the expedition/timer runs out, emergency beacon is activated.
Reclaimer flies back and relays the alert in supply comms when it arrives in local space. Expedition planet remains open, maximum of 5-10 mins to allow for travel time and to give someone a chance to recover the body before it rots.
Remaining salvors mount a rescue, could also be a good role for a paramedic to get involved in.
Fly back, find the guy, retrieve them.
Warning on timer running out. If anyone is on the planet when the beacon expires, they suffer the same consequences.
Salvor needs a new beacon implant.


Adjust Blog Card Height in a Grid Layout Setting

The height of the Card can be made to cover/adjust up full height of the section compared to other cards.


Adding Unit Testing and Fixing errors

Codecov Report

Merging #11 into master will increase coverage by 2.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   17.13%   19.85%   +2.71%
==========================================
  Files          27       27
  Lines        1879     1879
==========================================
+ Hits          322      373      +51
+ Misses       1468     1404      -64
- Partials       89      102      +13

Impacted Files
Coverage Δ

flasharray/hgroup.go
54.83% <0%> (+54.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d209d12...bc9de6c. Read the comment docs.


Update to ElasticSearch 2.1

Update version of elasticsearch to avoid java.lang.NoSuchFieldError: LUCENE_5_3_1 when using elasticsearch 2.1.0.

Is this PR compatible with es2.0?

I'm running ES 2.1.1 and still getting this error when trying to open a TransportClient. Is there any workaround?

@lucidfrontier45 sorry for my late response. I'm actually can't assure complete backward compatibility but normally it is since ES encure backward compatibility on project (these update only consists to fetch the last version of the jars)
@thealy I think that the second commit may fix your issue but I can't test since I'm using the ES2.1 and I can't upgrade / downgrade easily and rapidly.
The last update works with ES2.1.

@thealy
Do you use normal jar or assembled fat jar? The latter contains elasticsearch-2.0.jar and may be incompatible with newer elasticsearch. The former one does not contains elasticsearch library jar and should be work with any version of elasticserach as long as the API is same.
If you are to use the former one, be sure that the elasticsearch lib dir (/usr/share/elasticsearch/lib or somewhere) is added to flume-ng's classpath.
BTW, since flume's development seems slowed down, I switched to logstash. If you haven't used it, you can try it.


[ASAN] Fix some address problems detected by ASAN

It's better to add some descriptor for this pull request.

It's better to add some descriptor for this pull request.

Done


Coffee-script now a local dependency

This commit pulls in @pmuellr's #96 / #97 code and adds some small changes.  command.coffee renamed to cli.coffee to make it more obvious that you can 'coffee cli.coffee' to run the command line with your globally installed coffee-script if you wanted.  Also removed some complexity from server/express/bin/server, it works the same now as it did before I believe, but let me know if I'm missing something important about having absolute paths in the require.
As a side note, I need a new name for server/express/bin/server, let me know if anyone has any good ideas, i'm leaning towards sfw-express, but i'm not totally sold.

This looks good, thx for updating the doc as well.
Note that you included a "drive-by" fix for server/Wikiduino/ReadMe.md, in commit 6bf16f9 .  No problem for me, but not sure how "clean" you're trying to keep your commits/pulls.

Hmm, yeah, we've had a lot of turbulent stuff like that, it seems to be ok, but if you've got a better work flow that doesn't leave those artifact merge commits i'd be glad to hear about it.

On Sun, Jan 15, 2012 at 20:16, Nick Niemeir <
<EMAIL_ADDRESS>
wrote:

Hmm, yeah, we've had a lot of turbulent stuff like that, it seems to be
ok, but if you've got a better work flow that doesn't leave those artifact
merge commits i'd be glad to hear about it.

Not a problem at all; I do these kind of "drive-by" fixes all the time for
my own projects, but I've also worked on some projects that like to keep
their commit histories squeaky clean.
--
Patrick Mueller
http://muellerware.org

For our edification only: what would have been a good way to handle these commits and end up with a squeaky clean history. (My own understanding is limited to pull --rebase before pushing. I gather there has been more going on here.)

Nick is looking to rename "server/express/bin/server". Is there a problem with that name? The name "sfw-express" seems to encode information already present in the path to the file.

Something about the redundancy strikes me as off, maybe.  I was thinking it could be more descriptive, but that's a good point that the path really does describe it just fine :)

Typically, to keep things squeaky clean, I create a new branch for everything that I want lumped together.  Only make changes in that branch for things you want lumped together.  For example, for every "bug" I work on, I create a new branch called issue-17 (where 17 is the bug number).  Do all my work in that branch, when I'm done, go to the "master" branch (or whatever), and do a "git merge issue-17", then push to GitHub, then pull request.
For a days-long sort of fix, I'd work out of issue-17 and push it to my GitHub fork every night, then when I'm done merge it into master and do the pull request.  I think if you're working out of a fork, merging to master probably isn't even needed (or desired) in most cases; just leave your work in your issue-17 branch and issue the pull request from there.
You can work on multiple bugs/new features simultaneously this way.  Sort of loosely based on a development flow that I've used in the past: http://nvie.com/posts/a-successful-git-branching-model/
One nice thing about this is, if you start making changes for issue-17 but you've forgotten to create the branch, you can create the branch then, and all the non-committed changes go with you.  That is if you were starting from a clean branch already.
I'm less familiar with "fixing" a set of commits in a branch using --rebase, et al.  I try to keep it from getting to that point :-)  If I had to, I'd go look at one of the online Git books like http://book.git-scm.com/
In the end, doing "drive by" fixes like this isn't really a big issue, I don't think.  Sometimes it's too much work to be squeaky clean, when all you really need to do is be pretty clean.  I wouldn't try to "fix" the commit with rebases unless you're familiar with the processes.  OTOH, good opportunity to get familar with the processes.

For the server renaming, I've opened issue #99.


Update Website with new Hacktoberfest 2022 details

Project available in repository_web page folder in root.

Hello Sir,
I have gone through the repository and As Beginner I Want To Contribute For Hacktoberfest 2022 . I humbly wait for you to assign the task to me.

Hi @Mustafa-Azad025 ,
Thanks for your interest in this project, you can create any issue of your choice or select to contribute in any of the existing issue by commenting on the issue to get it assigned to you.

hey. i am very new to git and interested in your project. I am just wondering were can I find the to tweek the website :)

@Ep1c-paav https://github.com/pranjay-poddar/Dev-Geeks/tree/main/Repository_web_page

I have gone through the project and I'll like to contribute, assign to me


Add/Edit Taint on node pool should not be available until "taintSupport": true capability is set on the cluster

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Have an rke cluster- AWS - 1 etcd, 1 control plane and 1 worker node. in v2.2.8
Upgrade to rancher master latest - 4c7e3263a - commit id.

Expected Result:
On Edit Cluster --> Taint on the node pool should NOT be available until "taintSupport": true is set on the cluster.
Actual Result:
On Edit Cluster --> Taint is available.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.2.8 to master-head
Installation option (single install/HA): single

If you edit the taints on node pool, it will not take effect until you add a new node or edit field for the cluster.
So our RKE workloads will be updated and they will still work.

Reopening the issue because of this issue -- https://github.com/rancher/rancher/issues/22670, which is going to get addresses.
Hence the user should NOT be allowed to add taints on Edit Cluster -- Node Pool.

Verified with an upgrade from 2.2.8 to master-head - commit id: ``
Steps:

Have an rke cluster- AWS - 1 etcd, 1 control plane and 1 worker node. in v2.2.8
Upgrade to rancher master-head latest
On Edit Cluster --> Taint on the node pool is NOT available; "taintSupport": true  is not set on the cluster
Edit cluster, change number of hours for the recurring snapshot, and click on Save.
"taintSupport": true is seen on the cluster after it comes up Active.
On Edit Cluster --> Taint on the node pool is available now.


Support copying commit hash from commit list

I wanted to revert the latest commit in the PR, my first thought to use the extension was to go to the commit list and right click to copy the commit hash:

Closing, this was added with https://github.com/microsoft/vscode-pull-request-github/pull/879


doc: update README.rst

Fix for misspelled example path for espressif wifi_apsta_mode

@Bajec you can force push to this PR with updated commit message.


Use overloads or generics instead of return with |

for example in compute.pyi
def mean -> lib.DoubleScalar | lib.Decimal128Scalar: ...

def exp-> lib.FloatArray | lib.DoubleArray: ...

etc.

I put a tiny dent in this with https://github.com/zen-xu/pyarrow-stubs/pull/105

I prodded at pyarrow compute functions to try to make a in/out tree of their functions and came up with this. The first file is the script and the second is the json output (so you don't have to run the first).
About the results
The first key is the name of the pyarrow compute function. Within each of those the keys are keys of output types. For one parameter functions, the value is the list of input types that result in that output. For two parameter functions the value is a 3 element list. The first two elements are the first two paramters' types respectively. The third element is a bool indicating if the second parameter was a scalar (False is array).
I'm assuming that all one parameter functions can take a Scalar or Array and that two parameter functions take only an Array as the first parameter. (As I type that, I'm less happy with that assumption than when I did the code)
About the process
I originally just used a basic try except for every attempted function call but on some of the two parameter functions it would crash the kernel so I had to hack up the multiprocessing approach so that it would crash the kernel of a separate process and could keep running. The one parameter functions finished in about a second but adding in the two parameter functions made it take over 10 minutes.


Bump Prism dependency

Fixes a compilation error that was preventing us from releasing an update to the gem.

(should we release as v0.1.3?)

Let's re-generate the RBIs in case there are typechecking errors. I think we should be good to ship the new version.


Vue production build

When setting up a vue production app without a staging app we run into the following issue:
vue-cli-service: not found
Vue CLI Service is and is meant to be a dev dependency from what I can tell, but with npm_config_production set to true in production, this causes the frontend app to not build.
I'm assuming that we haven't run into this bug before (as far as I'm aware) because we typically set up staging first and then production and we promote to production which doesn't require a rebuild of the frontend app.
However, I'm labelling this as an issue because we should be able to deploy our apps just for production as needed. My current workaround has been to just set npm_config_production=false in production which is not ideal.
A couple of approaches I tried:

Setting vue-cli-service as a dependency. Caused a chain of other packages to need to be dependencies and we really don't want them to beSetting vue-cli-service as a dependency. Caused a chain of other packages to need to be dependencies and we really don't want them to be
Removing the build command in package.json. Caused (unsurprisingly perhaps) the frontend to just not build/not build in the right folder. Not sure which one yet. Needs looking into further. I feel like removing the vue-cli-service dependency for the build would be the solution here

When we've looked at this before, we've concluded that setting NPM_CONFIG_PRODUCTION=false is safe in the prod environment. This enables Heroku to install devDependencies, but will still create a 'production' build, because NODE_ENV is set to 'production'.
https://thinknimble.slack.com/archives/G03GBBRC3/p1637266147072900?thread_ts=1637259568.071700&cid=G03GBBRC3

Before closing this I'd like to take a minute to understand the issue (or the symptom of a possible issue we are seeing).
Safety aside, we'd want to avoid the production build being bulkier than it needs to be (especially if we are install dev dependencies like Cypress...which is large)

Does our migration to vite make a difference (or solve) this issue ?


[IT-1621] Enable aws guard duty on all accounts

Run the AWS guardduty service on all accounts and have them
report back to the guardduty hub (logcentral).

Should #322 be resolved first?

good observation @DiepThach however we can do either one first.


Unable to Open Fits Lightcurve Files

I get this error
KeyError: "Key 'SAP_QUALITY' does not exist."
when trying to read in a lightcurve .fits file using the path initialization, i.e.
lc = KeplerLightCurveFile('my_lightcurve.fits')

I can't reproduce this using a random Kepler light curve file from MAST.   How did you create my_lightcurve.fits?

@barentsen  I used lightcurve's to_fits() function!

After opening my .fits file with astropy, it looks like lightcurve's to_fits() function only saved [('TIME', '>f8'), ('FLUX', '>f4'), ('FLUX_ERR', '>f4'), ('CADENCENO', '>i4')] in my BinTableHDU.


Lighting Glitch

Issue description:
The more blocks are adjacent to the disk drive or the disk manipulator, the darker they get. As soon as at least 4 sides are covered, both RS blocks appear almost completely black.
Steps to reproduce:

Place disk drive / disk manipulator
Attach blocks on 3 or more sides

Version:

Minecraft: 1.10.2
Forge: <IP_ADDRESS>0
Refined Storage: 1.2.3

Does this issue occur on a server? - Yes
Screenshot:
http://i.imgur.com/q0Hs1op.png

This seems to appear because smooth lighting is on.

optifine issue


Timezone Support & Several Other Fixes

Adds support for timezones so will set time properly.  Also included several other fixes that were previously mentioned to make setting time in calendar invite function properly.

There have been a ton of changes recently and this no longer merges properly.  If the merge is fixed, I'll be happy to merge this in.

This pull request can be accepted instead of #43; this fixes that issue. I don't think it's possible to add this functionality without merge conflicts; the few breaking changes are necessary and also improvements wrt to time zone updates.

If someone gets this mergeable, I'll merge it.

I attempted--I did a pull of the most recent and applied these changes and got the same results.
I believe this file (independently) incorporates the changes that were made during the merges last week (the big one being the change from getMinutes() to getSeconds().
Obviously this PR should be tested, but I believe the way to merge these changes to is take this file over the existing ics.js file.

Yeah, the last commit to that repo was in 2015 (honestly, I forgot I made this project).  It either needs to be updated with more current code, or the timezone stuff needs to be re-implemented in a fresh branch.

Let me just say--thank you for making this, it made my life much easier in developing a tool that in turn sped up routine tasks for more than 200 people.
What of this isn't compatible? It seems to be just changing the start date  from new Date() to the new Date() with timezone offsets , and the changingn DATE to DATE-TIME at the end. This shouldn't affect the RRULE stuff that was added from Connorbode's branch.
Am I missing something?


Fix for detecting OS and architecture

Updated the detecting of the OS and architecture using $env:OS and [Environment]::Is64BitOperatingSystem.
Tested on virtualised Windows 11, host is MacOS (Silicon M1).

We'll use #626 which seems to fix the issue in a way that's compatible with Windows PowerShell and PowerShell Core. We appreciate your help


print meaningful error msg for patch creation.

part of: https://github.com/istio/istio/issues/18318

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e_operator
93e381c77730ef18ee00ea6d9fa5442b9e73cf90
link
/test e2e_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #464


Write registry contract

What was wrong?
Vyper Registry contract - following ERC-1319
Including the registry.v.py contract in /contracts/ for now, with plans to yank it out or move it to /tests/ later
@fubuloubu @jacqueswww @davesque Would love some feedback on the contract / testing. It's still a WIP as there is plenty of room for improvements
some concerns:

Right now max # of packages/releases allowed per registry = 128 (number is irrelevant, but i'm still looking for a way to improve this - variable length arrays are not possible, correct?)
docs nonexistent, but coming soon

CI won't pass until https://github.com/ethereum/pytest-ethereum/pull/11 is merged and released
Cute Animal Picture

@fubuloubu @pipermerriam made the suggested changes, ci won't pass until https://github.com/ethereum/pytest-ethereum/pull/11 is merged/released
mostly added a mechanism to allow getting all releases for a package, it seems to work alright, but not sure if there's a better way to achieve that goal? open to any/all suggestions for improvement

Why does twig need ethereum/pytest-ethereum#11? Not sure I understand why the log class helps twig do it's job?

So this is now compliant with ERC1319?


Data download website error

I try to download the data by clicking the link in README, but it both goes to "Page unavailable". Are there any other ways to download?

我也想要一份

Maybe try porxy?


Task - Matrix hub - delete button needed

Delete button needed for each matrix.
Expected behavior.

Click delete button. A confirmation where you type "Delete" is required (the same functionality which we use when we Clone object)
Warning popup, "The matrix will be delete, but all characters, OTUs and scores will be preserved"
Delete all Rows and Columns from the matrix (The Characters and OTUs are not deleted).
Delete the matrix.

This won't work properly until the models are fixed.  Please do not attempt to implement.

Removing blockers since the matrix can simply be renamed and or ignored for now with no damage.  Adding to priority tracker.

Please add the warning with the text box on_delete
Click delete button. A confirmation where you type "Delete" is required (the same functionality which we use when we Clone object)
This is a complicated delete behavior. I want to make sure that the matrix is not deleted by mistake. I would like to see a two step warning like other places we have in critical places.

In the radial we likely need all/nothing two step deletes.


not initialized properly.

This error has occurred again. Every time the project is reopened, the plugin prompts this error

Can you follow the instructions here and see if the automation tests works?
https://slowburn.dev/dataconfig/Integration.html#validate-integration

I've managed to reproduce the errors locally. I'll take a look why this is happening but it seems DataConfig features should be working just fine.
If it's concerning you on integration you can only integrate DataConfigCore for now since the error coming from extra and tests.
See https://slowburn.dev/dataconfig/Integration.html#integrate-dataconfigcore-module

Hi! I've just pushed 1.7.3 which should've fixed this issue.
Can you try get it and see if it fixes your problem?

Thank you for your hard work on this plugin. I will try the latest version tomorrow


feat(hackathon): enforce unique names for API tokens

Description
See title
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
In the UI, create a first token with a given name (here, "Test"), then try to create a second token with the same name.
This should display an error.

Then display the token list and check only the first token is there.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Did you test the upgrade -> rollback -> upgrade again scenario on a cluster?
On the rollback the data would remain and you would be able to create duplicate names again and the 2nd upgrade should re-run the migration  and work.  But since the unique constraint will remain on the table after the initial upgrade, I think we should exercise that scenario if you already have not.


Will not import transactions from .qmtf file (renamed to .qif)

Hello, Quiffen looks great!  I have a large Quicken for Mac file exported as .qmtf.  When I parse this into quiffen, I get all of the accounts, but no transactions.

Upon debugging, the transaction parsing isn't working for various differences in the file I exported from what Quiffen is expecting.  I'll collect the differences and get back to you.  Thanks.

Awesome, thanks. I'll try to expand support for QMTF files once you do!

Hi @wkcwells, did you ever have any luck with this? I'd like to add support for QMTF files if I can

I'm closing this issue. Please feel free to re-open it if you have files you can provide.


New CMake CUDA tools, better cross platform support

The CUDA support in CMake has been much improved since 3.18 and now the architectures can easily be set and cuBLAS easily included. Previously including cuBLAS was kind of hacky and it seemed to give some people trouble (myself included). With standard support in CMake now, this should improve consistency for people.
I updated the cmake files to use this, this requires cmake 3.18 or higher.

I'll have a look at it. Will test also with some older CUDA versions (which I still have installed).

It appears I messed up and accidentally included some of my edits to files other than the cmakelists.txt files in this branch. You can just ignore the three *.sh files (those are part of the #93 pull request).

I cannot review this feature request before the next release of the software. I basically run your branch on Windows and I got problems (cublas_static.lib not existing or some compile flags mismatch). It's probably solvable, but I don't have the time for it. I will review it later.

@ironictoo and @jkfindeisen - it would probably facilitate testing to set up an automated build using github actions. I've started this process and have successfully gotten both Windows and Linux builds working: see this job's artifacts. I created a draft Pull Request for this.

This has been updated with all the recent CMake changes discussed with @superchromix and @jimkring . Brief summary

Switch from deprecated find_package(Cuda) to supported language CUDA
Switch from deprecated find_package(PythonInterp) to supported find_package(Python)
Switch from deprecated MSVC static link find/replace strings to supported PROPERTY MSVC_RUNTIME_LIBRARY
Set CXX standard to 20, and CUDA standard to 17 (latest supported)
CUBLAS linking is much simpler and same for all platforms
added create package script for linux (including .deb generation)

This fixes all the build action errors that have come up recently, you can see them all for a wide variety of platforms and versions here.
We could probably still remove a lot of the old architectures (they trigger warnings that they are deprecated) and the stuff about MSVC 12 and 14, but I didn't have any reason to change that so left it in for now.