Directory must be open before using remove (3.2.3 rc1)

Godot version:
3.2.3 rc1
OS/device including version:
macOS 10.15.5
Issue description:
As of 3.2.3 rc1 you must open a directory before using remove.  Prior to 3.2.3 rc1 you didn't have to open up a directory to delete it, which makes sense.  If you are attempting to delete a directory, then you probably don't care if it doesn't exist.  If you did, you' d check for it first.  The new functionality might be the "right" way but I would argue it is a breaking change and shouldn't be introduced in a patch.
Steps to reproduce:
Assuming a directory user://foo exists and it is empty.
var d = Directory.new()
d.remove('user://foo') # this causes error, the directory is not removed.  this works in 3.2.2

Minimal reproduction project:
See code. Should be enough.

The new behavior is correct, the previous one was quite dangerous. Directory auto-opens res:// when it's instantiated, so if you did:
var dir = Directory.new()
dir.remove("test")

It would remove the res://test folder, and this is unexpected for many users as the implementation detail of Directory starting in res:// by default is not known to all.
If you want to delete a folder in e.g. user://, you should open user:// (and thus have the Directory configured for access to the user:// filesystem), and then you can remove anything you want in user://.

See #40146.

That is probably a bigger issue than not deleting a directory (at least old me thought so per  #24149).
Is there any documentation on how the new Directory object should work?  It seems a little inconsistent.
For example, should remove fail if the open call failed?  It currently does not.  This works:
# Assuming a directory user://foo exists and it is empty.
var d = Directory.new()
var result = d.open('res://does_not_exist/') # returns 31
d.remove('user://foo') # does not cause error

Here's some other questions.  Sorry if this has been discussed elswhere.  Should a Directory instance:

be able to remove the directory it opened?
be able to remove paths that are not sub-paths of what it opened (i.e. opening res:// but deleting from user://)?
require a valid open call before performing any actions?
what happens when whatever you have opened with open becomes invalid?

@bitwes yeah I've stumbled upon this while using Gut, see also #40234.

CC @nathanfranke

As akien said this is pretty much intended https://github.com/godotengine/godot/issues/40763#issuecomment-664471666

# Assuming a directory user://foo exists and it is empty.
var d = Directory.new()
var result = d.open('res://does_not_exist/') # returns 31
d.remove('user://foo') # does not cause error

This is definitely not intended so this should be fixed

I'm not going to be at my workspace for a while, so someone else can make a PR (Junior Job?)
Yup, just some overlooked code. This needs to be changed to
if (!alt || err != OK) {

https://github.com/godotengine/godot/blob/210ccb3a7552659e6ba1b69ed3c744d0af370eac/core/bind/core_bind.cpp#L1615
Alternatively we could add another if statement lower down

There appears to be a lot of edge cases with the new changes to Directory.  Maybe, with all these additional requirements, the Directory object should be deprecated and a new one should be created that has the more complicated behavior.  This would allow for the introduction of more consistent but breaking changes.

The new behavior isn't complicated, just different, and the behavior was intended by the start. All I did was fix the error condition.

Well as it breaks compat, I think it might be best for 3.2 to revert to the previous state (all methods can be used without opening a directory manually, even if it's confusing as a directory is open by default), and redesign the Directory API for 4.0 (which is starting to show its age and non-optimal design).
On the other hand, there should be better handling of bad input when trying to remove non-existing paths.

IMO fix up the current directory stuff for 3.2 and redesign it for 4.0

The new behavior isn't complicated, just different, and the behavior was intended by the start. All I did was fix the error condition.
Your PR isn't complicated, but the repercussions of it are.  Should a Directory instance:

be able to remove the directory it opened?
be able to remove paths that are not sub-paths of what it opened (i.e. opening res://foo but deleting from res://bar)?
what happens when whatever you have opened with open becomes invalid?  For example you open res://foo in one Directory object, then delete res://foo in another Directory object.  The first no longer is "open" to a valid directory.
Should each operation that requires a call to open verify that the path is still valid before each action?

@bitwes I don't think that's really in the scope of this issue though. Those edge cases should have been considered when this system was designed in the first place.
We can add checks to make Directory more safe to use (for example if you delete something outside of Godot) but that would be against Akien's proposal to just revert these changes for 3.2.
IMO:

Keep the changes we have so far since the old behaviour can be dangerous (see #40146)
Ignore the edge cases until 4.0. It doesn't matter what happens as long as it is the same as it was before.
Test the current system thoroughly before 3.2.3 is released and make sure it is expected behaviour.
Redesign the File/Directory workflow for 4.0

Test the current system thoroughly before 3.2.3 is released and make sure it is expected behaviour.

3.2.3 is meant to be released this week, so we don't have much time.
So I'm more for preserving compatibility in 3.2.3, and we can take the time to make things work well for 3.2.4, possibly with a slight compat breakage if it really makes sense - but as it stands while the compat breakage does prevent a dangerous case, it's unclear whether the current API is really a good improvement.

Fixed by #40803 for now. Let's see how to handle the various issues that remain with Directory to make it safer and without better input validation.


Needs to be less aggressive about picking reviewers

We shouldn't always @-mention the whole team :)
We should probably:

randomly select one reviewer
and maybe keep the rest of the list, but remove the @ from the non-selected reviewers

Or maybe it should just never @-mention anyone? Leave it to the PR author to manually assign a reviewer.

@cramforce got it

i prefer that latter


Move common Summon vars into common section

Somewhere between Summon v0.6.6 and Summon v0.8.0 it became a requirement
that Summon vars must either be in a specific environment or in a common
section when using Summon environments.
This commit updates the secrets.yml for this project so that it conforms with this new
standard, to facilitate bumping the Summon version in our pipelines.

@sgnn7 had to change the common section to kubernetes for GKE and update the Jenkinsfile


Animated icons addition

Is your feature request related to a problem? Please describe.
Animated icons addition
Describe the solution you'd like
Animated icons addition
Additional context

What kind of icons, do you wanna add in Damini ? Please be a little specific ?


HTML-only page downloads modules imported in +onRenderClient in the browser

Description
The HTML-only page downloads all imports in +onRenderClient. (React and lodash in the reproduction)
Reproduction:
https://stackblitz.com/github/nitedani/vike-bug-html234?file=pages%2Findex%2F%2BPage.jsx
The example says:

This page has zero browser-side JavaScript. (In development, Vite's HMR client is loaded.)

Expected:
Only the Vike runtime is downloaded

Using this page config solves the issue. React and lodash are no longer downloaded. The built page entry will become an empty .js file, and the empty file is downloaded.:
export default {
  clientRouting: false,
  meta: {
    Page: {
      env: {
        server: true,
        client: false,
      },
    },
    onRenderClient: {
      env: { client: false }, <---
    }
  }
} satisfies Config

This config doesn't work as expected. onRenderClient is bundled and downloaded, but not called on the client.:
export default {
  clientRouting: false,
  meta: {
    Page: {
      env: {
        server: true,
        client: false,
      },
    },
    onRenderClient: {
      env: { client: true }, <---
    }
  }
} satisfies Config

Questions:
Why is onRenderClient not called using the config above?
What is the expected default behavior for the following config? Currently, it behaves the same like the config above. It bundles onRenderClient, even though it's not called in the browser.
export default {
  clientRouting: false,
  meta: {
    Page: {
      env: {
        server: true,
        client: false,
      },
    }
  }
} satisfies Config

The issue was a regression that added preload tags to HTML-only pages which doesn't make sense since no script is exectued. It's fixed now and I added tests to the CI.

Ideas

I agree Vike could be smarter / more flexible. Although I think the fix is fine as I don't foresee a use case that'd need Vike to be more clever around this. Closing but feel free to disagree.


Update opencompetition.md

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

I have updated the description (and hope that you can see this message)


better error message

The error message can be better. e.g., for the YAML below
~                              | 24       source:
~                              | 25         repoURL: https://somerepo
~                              | 26         targetRevision: main
~                              | 27         path: ./
~                              | 28         helm:
~                              | 29           releaseName: plt
~                              | 30           valueFiles:
~                              | 31             - overrides/values.yaml # default
~                              | 32             - overrides/{{region}}/{{env}}/values.yaml # per env override
~                              | 33           parameters: # values that can be inferred from appset
~                              | 34             - name: "consul.global.datacenter"
~                              | 35               value: {{region}}-{{env}}

kubeconform tells me something is wrong, but ain't tell me what is wrong.
failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: line 34: did not find expected key

I fixed it by extra double quotes around the literals. This code snippet is from an ArgoCD application set, I cannot find a  way to render it locally without ArgoCD, so I have to pass it to kubeconform. ;-)

Yes, I figured it out, but, is it possible to print a better error message by any chance?

sure!
It's an open-source project, so you or someone from the community is more than welcome to contribute a PR

Hi @DanielYWoo , it looks like the error comes from the Go YAML parser Kubeconform uses https://github.com/kubernetes-sigs/yaml  (the one Kubernetes uses too, I believe) which relies on https://github.com/go-yaml/yaml  - which throws this error.  A nicer error would be good, but it requires fixing a number of external dependencies which falls a bit outside of the time I can allocate to this project. Sorry :(


Fix helm chart image tag default value

What this PR does / why we need it:
The image tag values weren't updated since v0.4.5. As a result, if the user does not explicitly overwrite the image tag version in helm values, the old version of Feast is still going to be installed.
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

/lgtm

/approve


Ledger routines return boolean status codes but also throw

https://github.com/bpfkorea/agora/blob/1af3731d063a8b52f1e114a4b31e5ac65ad70869/source/agora/node/Ledger.d#L207
And also:
https://github.com/bpfkorea/agora/blob/1af3731d063a8b52f1e114a4b31e5ac65ad70869/source/agora/node/Ledger.d#L268-L269
Here the assert might not get triggered because saveBlock is not nothrow.
All of this has to be fixed.

This has been mostly fixed, there might be one or two inconsistencies left in other classes but not in the mentioned methods.


wirelink:egpPos(n,v2) works incorrectly when used on egpLine()

Basicly when one tries to use egpPos(number index, vector2 pos) on an egpLine, it moves the starting end of the line instead of the whole thing
Steps to reproduce the behavior:
Link your egp v3 hud to your e2
Put wirelink:egpLine(number index, vector2 pos1, vector2 pos2) in your if first statement
Next put wirelink:egpPos(number index, vector2 pos) under it
upload and exit
Expected behavior
Expected line to move to said position
Screenshots
Code screenshot

Expected behavior screenshot

Result screenshot

If this gets fixed, wirelink:egpPos(n,v2,v2) should be added for moving both ends separately

Fixed in #2646


Recursion and hashing in Python

I will add the code for recursion and hashing in Python.

Hi! Please assign this issue to me under GSSOC.

I would like to contribute to the above problem in java as I am a participant of GSSOC'21. Kindly assign this to me.


Import and Process DART data queries

Hey Kevin,
I put together a new function to download DART tag observation data and to process into a proc_ch data frame.  It seems to work well for LGR fish, and it could maybe be tweaked some for PRA.  I also edited a few other functions to remove the join by comments in the R console.
Let me know what you think.  Ryan

I think this should work seamlessly


Default avatar is visible when using a transparent gravatar image

Not really a big issue, but when you have a partially transparent gravatar img parts of the fallback avatar are visible:

Merged in 20e8aab


wrong number of parallel threads when number of elements is relatively small compared to degree of parallelism

hi!
thanks a lot for peach, i think it's a great way to parallelize things, but there's a bug when the number of elements to be looped is less than 2*threads:
#!/usr/bin/env ruby

require 'peach'

@max_threads=10
@elements=19

exports = Array.new
puts "start"

$i = 0;
$num = @elements;

while $i < $num  do
    exports.push($i)
   $i +=1;
end

puts "array initialized"

def do_export(num)
    print " |export #{num} "
    %x(sleep 5)
end

puts "max_threads: #{@max_threads}"

exports.peach(@max_threads) do |export|
    do_export(export)
end

this code will execute 19 threads instead of 10.

see #11


Having trouble with global triggers

I've registered the recognizer with the bot, and added a couple of global listeners for help and cancel. Help uses a request_help intent, while the cancel uses regEx. The regEx will register inside both dialogs and prompts.
The intent however won't register inside dialogs, unless it's the root dialog.
const {recognizer} = require('./src/helpers/witRecognizer');

/*
* Steps for setting up the botbuilder connection and server
*/

// Wit.ai recognizer, input blir sendt hit for å tolke intent.
bot.recognizer(recognizer);

//Dialog for hilsninger
bot.dialog('greet_dialog', dialogs.greet).triggerAction({
    matches: 'greet', onSelectAction: (session, args) => {
        session.beginDialog(args.action, args);
    }
});

// Dialog for å etterspørre en oppskrift.
bot.dialog("request_recipe_dialog", dialogs.requestRecipe).triggerAction({
    matches: 'request_recipe',
});
// Dialog for å etterspørre en spesifikk oppskrift
bot.dialog('specific_recipe_dialog', dialogs.specificRecipe);

// Global lytter for hjelp
bot.beginDialogAction('help_action', '/help_dialog', {matches: 'help'});

// Global lytter for å avbryte en samtale
bot.endConversationAction('cancelAction', "Avbrutt", {
    matches: /^cancel|avbryt|exit|restart|start på nytt$/i
});

// Dialog for hjelp med bot'en
bot.dialog('/help_dialog', dialogs.help);

I don't think there's an issue with the botbuilder-wit module.
In your code you're matching an intent named 'help'. But you also mentioned an intent named 'request_help'. Perhaps you made a mistake in you code. If that doesn't work, I would suggest to do some debugging and find out what code is executed when the bot receives the 'help' message.

It was a regEx earlier, forgot to change it all they way to request_help.
the line bot.beginDialogAction('help_action', 'help_dialog', {matches: 'request_help'});
Should it not trigger when I'm inside other dialogs? I am pretty sure I've made some mistake somewhere, but I'm not able to see it. While inside the request_recipe_dialog if it catches any other intent, it stops working and announces ..BotBuilder:prompt-text - WARN: Prompt - no intent handler found for request_help
Is this something you're familiar with? If no, I'll continue my search.  I'm not using the IntentDialog class.

I think I found the bug in your code. When you invoke bot.dialog('/help_dialog', dialogs.help); it registers the help dialog with the id string /help_dialog. So, referring to it as help_dialog explains the warning message ...WARN: Prompt - no intent handler found for request_help.

How do you reference the help dialog? Is it with help_dialog or /help_dialog. It should be the exact same string that was used to register the dialog with the bot, in this case /help_dialog. But in your previous comment you mention bot.beginDialogAction('help_action', 'help_dialog', {matches: 'request_help'});. This could explain the warning message. If that does not help, then you might find more clues in the bot's log statements.

that is an oversight on my part. I've changed all the dialog paths to constants, so I'm sure they're exactly alike.

The dialog paths and ID's are not the same.
The statement bot.dialog('/help_dialog', dialogs.help); creates the id /help_dialog which starts whatever dialog is referenced as the second argument. When using bot.beginDialogAction, the second argument should exactly match the dialog id.

Yes, that's what I was supposed to say. This is how it looks with the constants.
bot.beginDialogAction('help_action', DIALOGS.REQUEST_HELP, {matches: INTENTS.REQUEST_HELP}); bot.dialog(DIALOGS.REQUEST_HELP, dialogs.help);

You could also try to simplify things by removing the global help_action and register the help dialog with bot.dialog(DIALOGS.REQUEST_HELP, dialogs.help).triggerAction({ matches: /^help/i });. According to the docs, the default behavior is to interrupt any existing dialog by clearing the stack and starting the dialog at the root of the stack.
As an aside. It looks like the warning message is generated by a function named invokeIntent => https://github.com/Microsoft/BotBuilder/blob/master/Node/core/src/dialogs/Prompt.ts#L397
Setting a breakpoint at the top of the function and then step through it could give further insight as to what is happening under the hood.
Other than that, I'm out of ideas.

Alright, thanks alot. I was hoping it would work with intent, rathen than a regEx. I'll try the breakpoint as well.

It seems the intent handler within the prompt isn't aware of any intents other than BotBuilder.ResponseIntent. Are you aware if it's possible to register other intents for it to catch?

After further investigation I figured out how to customize the prompt to match with my intents. I'm not sure if it's the best solution, but it works.


Add a rule for defaultdict(default_factory=list)

Kwargs in the defaultdict constructor are forwarded to the dict constructor, so this creates a defaultdict with {"default_factory": list}. Since this is a valid call, type checkers may or may not catch this (and even when they catch it, the error might be a little confusing). ruff could lint this specific situation and mention use of collections.defaultdict(list) instead.

Seems like a good rule.

@hauntsaninja You should also open the issue in the flake8-bugbear repo, they may be interested in it.

I can take this.

@hauntsaninja did you use 'list' as an example or I assume this applies to any callable? I tried default_factory with mypy 1.7.1 and it truly seems to be confused with different input types (list, int, dict, lambda, ...).

As an example! :-) Like I said, type checkers can't catch the call itself since it's valid. They may be able to surface an issue later because they'll infer a different type for the defaultdict.

Added in https://github.com/astral-sh/ruff/pull/9651, thanks @mikeleppane!


ci: add testTimeout of 10 seconds

master is currently failing

@arboleya I'm wondering if this is even the root cause, I'm noticing that a bash script is reporting that forc and fuel-core are not found, could that be related? @Torres-ssf

Looks like https://github.com/FuelLabs/fuels-ts/pull/2175 has addressed this issue


Update RULES.md

@lionel-nj In the future, let's add a short description to each of these issues, even if it's planned to be short-lived, so we have a record of why something is done. Ideally this would have had a "The current docs ...., and therefore we need to update them by ...." sentence.

Just seeing this comment now @barbeau - yes, will do! Thanks :)


MudStepper PreventStepChange  being called twice

When CompleteStep or SkipStep are executed the function PreventStepChange is called twice, once as the code enters in the function and again because it is called from SetActiveIndex. I am not sure what the best solution is but calling the same method twice I think should be avoided?
https://github.com/CodeBeamOrg/CodeBeam.MudExtensions/blob/b525a008c2c450d7e5894c1067292c138d2fa1d1/CodeBeam.MudExtensions/Components/Stepper/MudStepper.razor.cs#L213
https://github.com/CodeBeamOrg/CodeBeam.MudExtensions/blob/b525a008c2c450d7e5894c1067292c138d2fa1d1/CodeBeam.MudExtensions/Components/Stepper/MudStepper.razor.cs#L168

What if we add a method parameter like protected async Task SetActiveIndex(int count, bool firstCompleted = false, bool skipPreventProcess = false)?

That works! I am testing it out still with my async needs but I think you will want to add that!.

The biggest missing thing is we still doesn't have the test project that. And of course we can add this.

I have some code for you to review from my fork soon. I ended placing a MudForm in the MudStep for valid. That might not be the best case but it keeps the client code leaner and then it can take advantage of the MudForm Validate / IsValid.  Maybe an OnChange with EventArgs is the best approach like found in the Telerik Wizard Control:  https://demos.telerik.com/blazor-ui/wizard/overview

#24 should fix this. I will make a release today. Please check if it is working :)

Looks good.


F5 LTM 10.x and 11.x compatible?

Hello,
Before posting more issues about this plugin I would ask if it's possible running the plugin on v10.x or v11.x version? I have found several problems when connecting to my F5 LTM v10.x and v11.x appliances. As far as I could have tried through all my F5 appliances I got the next issues: java.lang.NullPointerException, GeneralEngineSSL Error (I posted an issue about this error a day ago), HTTP 404 error code exception and HTTP 401 error code exception:

Fortunately the plugin works well through all my F5 LTM v12.x appliances!!!

I'm glad it's working well for your 12.x appliances.  Yes, as the README states (and as you've discovered), the plugin Only supports TMOS versions 12.1 and later.  For iAppLX and iControl LX support, you'll need 13.1 or later.  This is simply because the F5 Eclipse plugin leverages API's which only exist in those versions of TMOS.


Documentation has a broken link

A sample nodeconfig file for server version 3.x.x (>= beta4) can be seen at https://github.com/SeleniumHQ/selenium/blob/master/java/server/src/org/openqa/grid/common/defaults/DefaultNodeWebDriver.json
"https://github.com/SeleniumHQ/selenium/blob/master/java/server/src/org/openqa/grid/common/defaults/DefaultNodeWebDriver.json" <- is broken, where can we find the default node web driver for the newest verion?

Hi @jariah-holsapple,
What is the url where you see this?

https://github.com/SeleniumHQ/selenium/wiki/Grid2#configuring-the-nodes-by-json


Help in creating tar archive for webdataset using tarfile python package

Hello,
Could someone help me with what the equivalent to (from your docs) -
$ tar --sort=name -cf dataset.tar dataset/

would be using the tarfile Python package. The above command is able to collate the files with a common basename into one group with a common key. It seems to me that this is taken care of by the --sort=name param.
I am trying to create a similar tar archive using the tarfile python package. This is the code that I'm using so far -
     with tarfile.open(archive_path, "w") as tar:
         tar.add(dataset_path, arcname=os.path.basename(dataset_path))

But this doesn't group the files with a common basename into one key, as is required by webdataset to process a sample.
(I've already tried Webdataset's TarWriter, but with a large dataset like the one I'm using, my system runs out of memory when I create a tar archive using TarWriter)
Any help is appreciated, thanks!

First, we don't know of any memory leaks in the TarWriter class, and it has been used to create tar files that are terabytes large. It would be helpful if you could track down the source of the memory leak in your application; my guess it is somewhere other than TarWriter, but if there is a memory leak in it, we would like to fix it. You may find a Python memory profiler helpful, something like objgraph, PySizer, or Heapy.
Another option you have is to use the tarp create command here. On its standard input, it takes a list of files and it produces a tar archive as an output; unlike the tar -F - command, you can specify both a source file name and the name in the archive. For example, to create an image classification WebDataset, you create a text file containing lines of the form:
image00001.txt text:9824"
image00001.png file:./data/c9824/img1.png
image00002.txt text:121
image00002.png file:./data/c121/img17.png
...

Note that you can specify both inline data (text: prefix) and data coming from a file or program (file: or pipe:) prefix.

Thanks for the help. I'll re-examine the memory issue.
I figured out the tarfile code - I was initially trying to archive the directory directly.
Adding to the archive file by file worked as I wanted it to.
with tarfile.open(archive_path, "w:gz") as tar:
        for file in sorted(os.listdir(dataset_path)):
            tar.add(os.path.join(dataset_path, file))


Print encode progress in one line instead of one line per encoded frame

As the title says, it would be better if VVenC were to print its progress in a single line like all other encoders do (x264, x265, vpxenc, etc) instead of just printing new ones one after another.

While I guess your request is valid, did you try playing around with verbosity settings?
Per default one line will be printed per second of encoded input. I'm sure this could be made into incremental progress within a single line with a simple sed script.
You and everyone else is invited to take on this issue, though.

@adamjw24 I did play around with the verbosity setting for a bit yeah.


Use pip3 to pull docker-compose

Otherwise we get an old version of docker-compose that doesn't understand the format of our docker-compose.yml files.
Note that this pull request also includes a script for toggling prevent_destroy globally.  This is useful in development environments.

Should be good now.  Thanks for catching that @dav3r!


Eliminate unreachable blocks in a function:

remove blocks that are not reachable from the entry point, nor are the merge block or continue target for any reachable loop header or selection header.
(From original #673)

See note in AggressiveDCE:

// Note: This function does not delete useless control structures. All
// existing control structures will remain. This can leave not-insignificant
// sequences of ultimately useless code.
// TODO(): Remove useless control constructs.

Eliminating unreachable blocks seems to be quite complementary.  For example, if code inside an unreachable block stores to a module-scope variable, then eliminating that block before running AggressiveDCE could allow AggressiveDCE to eliminate more code.   Also, it may be profitable to eliminate unreachable blocks after AggressiveDCE.

I've started working on this.

Fixed with #810.


unknown command "import"

As per docs at:
https://jenkins-x.io/v3/develop/reference/jx/secret/import/
But I get the error:
Error: unknown command "import" for "jx-secret"

import command was removed some time back, will regenerate the docs soon.


runtime/pprof tests fail for go1.2beta2

Compiling go1.5beta2 (cc8f5441980a8c2f9e6c8ec3222985ed488e76ba) fails with the following errors during the tests.
--- FAIL: TestTraceStress (1.67s)
	trace_test.go:226: failed to parse trace: bogus scanning end (offset 892575, time 28614703)
--- FAIL: TestTraceStressStartStop (0.73s)
	trace_test.go:365: failed to parse trace: EvFrequency contains invalid frequency -60703235145 at offset 0x222
--- FAIL: TestTraceFutileWakeup (0.07s)
	trace_test.go:433: failed to parse trace: g 186 is not waiting before unpark (offset 481, time 550)
FAIL
FAIL	runtime/pprof	9.153s

When I ran ./all.bash a second time, it only had a single error:
--- FAIL: TestTraceStressStartStop (0.42s)
	trace_test.go:365: failed to parse trace: bogus scanning end (offset 108133, time 135001278)
FAIL
FAIL	runtime/pprof	9.094s

The third time was different also:
--- FAIL: TestTraceStress (1.55s)
	trace_test.go:226: failed to parse trace: g 5 is not waiting during syscall exit (offset 802828, time 368)
FAIL
FAIL	runtime/pprof	8.248s

go1.4 version: go version go1.4.2 linux/amd64
kernel version: 3.16.0-43-generic #58-Ubuntu SMP
cpu: i7-5820K
There are no other errors during the build.
I'll continue to use go1.5beta2 and update this issue if I bump into trouble, but it looks like it's just runtime/pprof that has a problem. Please let me know when more information or tests are required.

Dup of #10512

Whoops, sorry :cake:


fix: only set vim colorscheme for default colorscheme

:tada: This PR is included in version 2.4.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ACS Doesn't Support Move

@raveeram,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@raveeram : Thanks for your contribution to the Azure documentation! The author, @tfitzmac, has been notified to review your proposed change.

@raveeram - thanks for making this change.

#sign-off


Create-An-Admin Page Functionally Working.

@Diddleslip:
• Confirmed in the API that new admins are being created
• Further work on this component would be useful for confirmation of new admin, general CSS etc, but let's merge this for now and create a new branch named after the component to continue work


fix deprecated url

it's not on high priority, merge when you have a chance. thanks

Thanks @0xF4D3C0D3!


Make use of unpkg.com instead of wzrd.in

There is an option described in docs to use the package via wzrd.in.
I've just noticed that service responds with 502 code.
Will it be fine to make pull request to replace usage of wzrd.in with unpkg.com (ex-npmcdn)?
BTW, they seem to be fine with using their URLs in production so it might become recommended way to use uuid in browser.

Yup, looks like wzrd.in is down.
Unpkg looks like a pretty amateur effort.  I don't mean that in a derogatory sense - only that it's one person's "best effort" solution, with no real SLA.  Recommending that as a production-level solution seems optimistic.  But I'm fine switching to that until someone recommends a better option.

Indeed, you are right, unpkg is not suited for production use as they clearly state on their website.
Unfortunately, there is another issue, which holds me back from making a pull request with suggested earlier edits: services like unpkg don't provide any ways to bundle CommonJS modules into components usable from browser out of the box (they don't bundle CommonJS into AMD or something and instead rely on package maintainers to provide npm package with prebuilt lib sources).
I checked issues and it seems that there is no goal to provide uuid npm package in a bundled state. Feel free to close this issue if I am right, otherwise I can take a look and try to make some prebulish npm script in order to make published npm packages consisting of bundled sources version as well.

I checked issues and it seems that there is no goal to provide uuid npm package in a bundled state. Feel free to close this issue if I am right

Correct, there is no desire to do this because packaged state means different things to different people.
The goal with putting wzrd.in on the readme was less about production and more to give folks a way to download a prebuilt version for use in their projects. If you aren't going to install and bundle this module with your deployment, then the next reliable thing is to copy the bundled code into your project and reference it from there.

sticking with wzrd.in for now.

https://wzrd.in/standalone/uuid/v4@latest
doesn't work

Seems like https://cdnjs.com/ is the go-to resource for this sort of thing these days.   Would love to switch over to that, but uuid doesn't seem to be a supported library yet.  Anyone want to tackle that?

Another alternative is www.jsdelivr.com which does tout "Built for production" since they use multiple CDN providers.
List of files from npm: https://cdn.jsdelivr.net/npm/uuid/
Direct link to a file<EMAIL_ADDRESS>They even have a badge with stats for your package

I will handle this, give me a few moments to fork and submit a PR

PR submitted https://github.com/kelektiv/node-uuid/pull/293

See https://github.com/kelektiv/node-uuid/issues/302#issuecomment-524827935 for an alternative that works as of today (but may cease to work in the future just like wzrd.in since it also seems to be rather a pet project than a professional service that you should be relying on).


manifest: bump hal_nxp revision

this revision contains an usb fix that allows
tests/subsys/usb/device/usb.device to pass on lpcxpresso55s69_cpu0.
see https://github.com/zephyrproject-rtos/hal_nxp/pull/315 for more information.

Thanks for the fix. Can you please update west.yml

Thanks for the fix. Can you please update west.yml

done!

@danieldegrasse : done.


Dedicated clusters to define their own k8up backup schedule

A customer has requested that all projects on their dedicated cluster are backed up on a set schedule that differs from the defaults.
Default schedule:
• 7 daily backups
• 6 weekly backups
Desired schedule:
• 7 daily backups
• 4 weekly backups
• 12 monthly backups

I think this would be best implemented in the build controller: https://github.com/amazeeio/lagoon-kbd
as we overall are moving cluster level settings into the build controller.
Can you create a sister ticket in the build controller to track this?

done

Closed by #2721


Merge Mapping Overrides

@bitner Not sure if that's how you want this to be fixed (sets are probably more appropriate here)

Coverage decreased (-0.1%) to 97.222% when pulling b6040b0d95d0d858294551a4bb973b4d8b412d3f on fix_override_file into 7aa16a8484e2af4501ff8f41f344adf96d5910dc on master.

tested locally - no longer seeing the incorrect mappings issue


add a code_of_conduct.md

add a code_of_conduct.md file which is a basic need for this repo

https://github.com/yashvardhan-kukreja/whatsupstream/blob/master/docs/developer-guide.md

Hi Ayush! I'd like to add and update the code_of_conduct for this repo. Can you please assign it to me?

It's done! Kindly go through it.


A first pass to creating validation for configuration yaml files

Will be addressed by https://github.com/chanzuckerberg/cryoet-data-portal-backend/pull/129


Add config property to JobSpec

Add config property to JobSpec so we can override some services setting on a job basis.
@KevGoDev | @mlefebvre

lgtm


memory leak in compressor code

Hi! The compressor code is very nice but it has a memory leak.
In memory.c and optimize.c multiple time malloc() is called but the memory is never freed. This causes a memory leak. Could you please provide a "freezx02memory()" function or the like which does the cleanup? This would make it easier to integrate the compressor in other software.
Thanks!

I added a new struct to keep track of allocations, see https://github.com/dmsc/zx02/commit/86b493c6cb7f0109268e7c53379a649ae0c2e833 , but in case of memory errors the compressor calls "exit()", so no memory is freed.
To properly use this in a library, it should better handle error cases, and probably signal the compression status in a better way.


Astro frontmatter support

The ability to define noCite and CSL in frontmatter is handy. Currently, it is not directly possible to utilise this feature in Astro, as the way to access the frontmatter is via file.data.astro.frontmatter and not file.data.frontmatter property. One could overcome this with wrappers, but appending the property into the plugin or maybe even including a dedicated option to add custom properties for noCite and CSL would be beneficial.

Thanks, I can see that the plugin would not work as intended as the wrong field is being parsed for astro. Will fix it next day or 2.

Added support to parse astro frontmatter and with @halafy-ds fix for noCite, it should work as intended now. Try out v2.2.0!


[Snyk] Security upgrade requests from 2.31.0 to 2.32.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

vendor/github.com/urfave/cli/v2/mkdocs-requirements.txt

⚠ Warning
mkdocs-material 8.5.11 requires requests, which is not installed.

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

566/1000  Why? Recently disclosed, Has a fix available, CVSS 5.6
Always-Incorrect Control Flow Implementation SNYK-PYTHON-REQUESTS-6928867
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Note: This is a default PR template raised by Snyk. Find out more about how you can customise Snyk PRs in our documentation.
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Checkmarx One – Scan Summary & Details – 67a582b6-fa5c-4fdc-a4d4-79a23310efa4
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2023-45288
Go-golang.org/x/net-v0.7.0
Vulnerable Package

CVE-2024-24786
Go-google.golang.org/protobuf-v1.28.1
Vulnerable Package

Passwords And Secrets - Generic Password
/Alibaba_Nacos_Default_password.json: [56](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Alibaba_Nacos_Default_password.json# L56)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/showdoc-default-password.json: [12](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/showdoc-default-password.json# L12)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Alibaba Nacos 控制台默认弱口令.json: [28](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Alibaba Nacos 控制台默认弱口令.json# L28)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Wayos AC集中管理系统默认弱口令  CNVD-2021-00876.json: [28](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Wayos AC集中管理系统默认弱口令  CNVD-2021-00876.json# L28)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/D-Link AC集中管理系统默认弱口令.json: [28](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/D-Link AC集中管理系统默认弱口令.json# L28)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/mallgard.json: [26](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/mallgard.json# L26)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Alibaba_Nacos_Default_password.json: [29](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Alibaba_Nacos_Default_password.json# L29)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/zabbix-default-password.json: [12](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/zabbix/zabbix-default-password.json# L12)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Alibaba Nacos 控制台默认弱口令.json: [54](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Alibaba Nacos 控制台默认弱口令.json# L54)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Wayos_AC_Centralized_management_system_Default_weak_password.json: [28](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Wayos_AC_Centralized_management_system_Default_weak_password.json# L28)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Mallgard_Firewall_Default_Login_CNVD_2020_73282.json: [34](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Mallgard_Firewall_Default_Login_CNVD_2020_73282.json# L34)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/D-Link_AC_management_system_Default_Password.json: [32](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/D-Link_AC_management_system_Default_Password.json# L32)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Wayos_AC_Centralized_management_system_Default_Password_CNVD_2021_00876.json: [34](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Wayos_AC_Centralized_management_system_Default_Password_CNVD_2021_00876.json# L34)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Datang_AC_Default_Password.json: [30](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Datang_AC_Default_Password.json# L30)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/SDWAN_smart_gateway_weak_password.json: [26](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/SDWAN_smart_gateway_weak_password.json# L26)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/ZhongXinJingDun_Default_administrator_password.json: [65](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/ZhongXinJingDun_Default_administrator_password.json# L65)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/WAVLINK_WN535G3_POST_XSS_CVE_2022_30489.json: [67](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/WAVLINK_WN535G3_POST_XSS_CVE_2022_30489.json# L67)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/datang-ac-default-password-cnvd-2021-04128.json: [12](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/datang-ac-default-password-cnvd-2021-04128.json# L12)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/XXL_JOB_Default_Login.json: [34](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/XXL_JOB_Default_Login.json# L34)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/浪潮tscev4命令执行.json: [12](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/浪潮tscev4命令执行.json# L12)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/XXL-JOB 任务调度中心 后台默认弱口令.json: [26](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/XXL-JOB 任务调度中心 后台默认弱口令.json# L26)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/ZhongXinJingDun_Information_Security_Management_System_Default_Login.json: [69](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/ZhongXinJingDun_Information_Security_Management_System_Default_Login.json# L69)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/localFinger.json: [10596](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//pkg/fingerprint/dicts/localFinger.json# L10596)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/WAVLINK_WN535G3_POST_XSS_CVE_2022_30489.json: [32](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/WAVLINK_WN535G3_POST_XSS_CVE_2022_30489.json# L32)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/panabit-gateway-default-password.json: [12](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/panabit-gateway-default-password.json# L12)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/XXL_JOB_Default_password.json: [28](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/XXL_JOB_Default_password.json# L28)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/alibaba-nacos-v1-auth-bypass.json: [10](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/alibaba/alibaba-nacos-v1-auth-bypass.json# L10)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/Hsmedia_Hgateway_Default_account.json: [28](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Hsmedia_Hgateway_Default_account.json# L28)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/SDWAN_Smart_Gateway_Default_Password.json: [32](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/SDWAN_Smart_Gateway_Default_Password.json# L32)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Token
/shtermQiZhi_Fortress_Arbitrary_User_Login.json: [22](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/shtermQiZhi_Fortress_Arbitrary_User_Login.json# L22)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Token
/齐治堡垒机任意用户登录.json: [10](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/齐治堡垒机任意用户登录.json# L10)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Token
/H3C SecParh堡垒机任意用户登录.json: [11](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//config/poc/h3c/H3C SecParh堡垒机任意用户登录.json# L11)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Token
/cve_2022_1388_goby.json: [73](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/cve_2022_1388_goby.json# L73)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Token
/Shterm_QiZhi_Fortress_Unauthorized_Access_CNVD_2019_27717.json: [28](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/Shterm_QiZhi_Fortress_Unauthorized_Access_CNVD_2019_27717.json# L28)
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Token
/cve_2022_1388_goby.json: [35](https://github.com/TheRedHatter/scan4all/blob/snyk-fix-8974bb950ac1c41b42b27edab26c88b6//lib/goby/goby_pocs/cve_2022_1388_goby.json# L35)
Query to find passwords and secrets in infrastructure code.


Cannot log in anymore

Dear @Quacky2200,
Do you have any idea how I can solve this problem?

Please see this temporary fix

Thank you!
If I understand correctly, then the fix involves changes the program code, correct?
Well, nevermind then. I will wait until the problem can be fixed without a temporary fix. :-)

Thank you!
Does that mean that this software is going to be further developed despite the previous announcement to discontinue it?

Sadly not, it was just something I had done mid-week and thought it'd be good for anyone who might want to use it.
Personally, I don't think Spotify have the intent to allow everyone to play music everywhere (browsers and other players) since most people will use their app which they will continue to privatise. It was much better when they had their libspotify library to embed into music apps but they have basically deprecated the whole library in favour of a limited API and the need of an API key. Their reason for not releasing another up-to-date library is because they only think of the 2-5% which try to rip their music, whereas the others who want to use their service; continue to get disadvantaged.

What a sad development. :-(


how to retrieve related items

I can't find a function that returns related items based on user's buying trends.

do you mean following?
raccoon.recommendFor('chrisId', 10);


Update the error message after removing the extension file folder from %USERPROFILE%.vscode\extensions

OS: Win10
Build Version: 20191128.1
VS Code Version: 1.10.1 (user setup)
Regression: Not a Regression
Repro Steps:

Install Cosmos DB Extension in VS Code --> Make sure the Cosmos DB Explorer displays well.
Delete the extension file folder from the %USERPROFILE%.vscode\extensions.
Check the Cosmos DB Explorer.

Expect:
Pop up a clear message to tell the users that the current extension file folder has been removed.
Actual:
Pop up a notification "false==true".

The error should go away if you reload VS Code. We can't do anything from our extension since it was literally deleted in step 2. Fun find, though!


Python 3.4.2 doesn't build on OS X 10.10 Yosemite

Complains about missing pyexpat.

I could not reproduce this.

I needed the CFLAG to install 3.4.2 and 2.7.9 but not 3.4.3


Account API for Smart Contract Developers

There are currently 6 API categories in EOS Docs Roadmap for Smart Contract Developer's Reference, which are:

Account API
Console API
Database API
Math API
Message API
Token API

Referencing to current contract library code found inside contracts/eoslib directory, we can do the following mapping:

Account API
Console API -> print.h and print.hpp
Database API -> db.h and db.hpp
Math API -> math.h and math.hpp
Message API -> message.h and message.hpp
Token API -> token.hpp

However, I can't find any file that corresponds to Account API in contracts/eoslib. Does it mean that Account API have not been implemented yet by now? Or could it be that Account API doesn't exist and it just a line of error added to the list? Clarification on this case is really appreciated. Thanks!

@bytemaster is there an answer to this?

Account API may not be implemented it would provide access to:

an account's permission tables
an account's balance (provided it is in scope)
other information available to native code

I would say that the documentation at this point should simply describe the type of information that will be available and an "TODO" sign.

Closing as we moved this to STAT-49 Github Issue #638


Add a copy to clipboard button to the Terraform code snippets

It would be very useful to implement a copy to clipboard button in the Terraform code snippets.

To be released in v0.1.12


Package includes USD SDK assets (C++ files) that cause exported iOS builds to fail

We are using this package in one of our projects that also has to build to an iOS app. When we build the exported Xcode project, the build fails on several .cpp files included in the package's Plugins directory that seem to be from the Pixar SDK and that contain non-valid C++ and references to Boost:

These assets don't seem to actually be necessary at runtime, so our solution is to exclude them from the Xcode build process with the EXCLUDED_SOURCE_FILE_NAMES build setting. We're doing this automatically with a build postprocessor in our Unity project:
#if UNITY_IOS
using System.IO;
using UnityEditor.Build;
using UnityEditor.Build.Reporting;
using UnityEditor.iOS.Xcode;
using UnityEngine;

namespace OurProject.Editor
{
  class iOSBuildPostProcessor : IPostprocessBuildWithReport
  {
    public int callbackOrder => 0;

    public void OnPostprocessBuild(BuildReport report)
    {
      var xcodeProjectFile = Path.Combine(report.summary.outputPath, "Unity-iPhone.xcodeproj/project.pbxproj");
      PBXProject pbxProject = new PBXProject();
      pbxProject.ReadFromFile(xcodeProjectFile);

      // Exclude .cpp files from USD package's Plugins directory from the build.
      Debug.Log("Excluding USD package Plugins files from Xcode build...");

      var excludeUsdCppFilesKey = "EXCLUDED_SOURCE_FILE_NAMES";
      var excludeUsdCppFilesValue = "$(SRCROOT)/Libraries/com.unity.formats.usd/Runtime/Plugins/x86_64/usd/usd/resources/codegenTemplates/*";

#if UNITY_2019_3_OR_NEWER
      pbxProject.SetBuildProperty(pbxProject.GetUnityMainTargetGuid(), excludeUsdCppFilesKey, excludeUsdCppFilesValue);
      pbxProject.SetBuildProperty(pbxProject.GetUnityFrameworkTargetGuid(), excludeUsdCppFilesKey, excludeUsdCppFilesValue);
#else
      pbxProject.SetBuildProperty(pbxProject.TargetGuidByName(PBXProject.GetUnityTargetName(), excludeUsdCppFilesKey, excludeUsdCppFilesValue);
#endif

      File.WriteAllText(xcodeProjectFile, pbxProject.WriteToString());
    }
  }
}
#endif

Could this be addressed in the package itself so we (and presumably others) don't need to handle it at the project level?
Unity version: 2019.4.21f
com.unity.formats.usd version: 2.0.0-exp.1

Thanks for the report @riemaeker
Those files are used by the usdGenSchema executable to build new custom USD schemas. In the current state they are useless so we should either:

get rid of the /usd/resources/codegenTemplates folder
provide the executable to go with it and update the OnPostprocessBuild method accordingly to avoid build issues.

A fix for this issue has landed in dev and will be available in the 3.0.0 release coming next week.
https://github.com/Unity-Technologies/usd-unity-sdk/pull/245

Can you use this package to export xcode projects? Why did I get an error


Output renders on new lines

What:
Code cell.results.output is now an array. As new stdout messages are received from the server, they're pushed into that cell's output array. The code cell's CellResults component maps over the array to produce an array of  components.

Why:
Render incoming stdout on newlines.
Next Steps:
Currently we map over cell.results.output every time an "output" message is received. Could be more efficient hold , , and  components in  state. Then, we could append to an array of  components rather than mapping a new array with every "output" message.

Sweet screenshot!

Looks like we're outputting 3 return values here instead of 1 ?


Migrate repo to SDP

Merging repo build changes to migrate content to Docs next-gen reference pipeline

Docs Build status updates of commit 14b3040:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit bab3cfd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[HOLD for payment 2023-10-09] [$500] Dev: Web - Unnecessary two back icons in #Room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on FAB icon and select Send message option
Go to  #Room tab

Expected Result:
It should show only one back icon
Actual Result:
Two back icons in #Room
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: Dev <IP_ADDRESS>
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/bd28bcf4-8792-4462-bab5-3a2c4021667a
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694840257162789
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ce9ae2774c7e1dd5
Upwork Job ID:<PHONE_NUMBER>242104832
Last Price Increase: 2023-09-16
Automatic offers:

c3024 | Contributor | 26809665
gadhiyamanan | Reporter | 26809666

Please re-state the problem that we are trying to solve in this issue.
Not found page when selecting room in RHP in send message option of FAB shows another back button.
What is the root cause of that problem?
There is a back button for the RHP as a whole for send message and here
App/src/pages/workspace/WorkspaceNewRoomPage.js
Line 147 in [76c1559](https://github.com/Expensify/App/commit/76c1559fb3fbee1d07c8f210b522b63edd03920e)

 <FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>

we are showing another back button again.
What changes do you think we should make in order to solve the problem?
We should add shouldShowBackButton={false} here
[App/src/pages/workspace/WorkspaceNewRoomPage.js](https://github.com/Expensify/App/blob/76c1559fb3fbee1d07c8f210b522b63edd03920e/src/pages/workspace/WorkspaceNewRoomPage.js#L147
Line 147 in 76c1559
>  <FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>
I think instead of a generic error we can show
title as emptyWorkspace.title from en.ts and show no subtitleKey.
Keep title as it is and show subtitleKey as emptyWorkspace.title
Use linkKey as emptyWorkspace.title and give corresponding onLinkPress for creating workspace.
What alternative solutions did you explore? (Optional)

@eVoloshchak what do you think of the above proposals?

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/23486
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23486/files#r1355533015
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, additional discussion isn't needed
Determine if we should create a regression test for this bug.
This is a small visual bug that didn't prevent user from using the app, so regression tests isn't necessary

Awaiting a payment summary to issue payment.

@gadhiyamanan reporter $50 - paid ✔
@c3024 fix + bonus = $750 - paid ✔
@eVoloshchak review + bonus = $750 - in NewDot

$750 payment approved for @eVoloshchak based on summary above.


Adds a new "Resist" button beneath saving throws that have been

failed by an NPC so long as that NPC has remaining legendary resistances. If a save has been resisted, it is displayed as a successful roll and an indicator is displayed beneath.

Closes #4863

The saving throw itself is the attempt to resist the effect. Can I suggest labeling the button "Legendary Resistance" to be more clear what it is meant to do?


permissions for new maintainer to upload cucumber-slack-notifier plugin

https://github.com/jenkinsci/cucumber-slack-notifier-plugin
@garethjevans

Description

Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory at least once

Maintainer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[x] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
There are IRC Bot commands for it

Hi @garethjevans
I need this to perform the plugin release of v0.9.0 as the current plublished 0.8.3 is 4 years old and is not working

Hi @slide  could you please approve this? The plugin is nearly abandoned by Gareth that's why I became maintainer and I do need to update the published version to match the latest working version in GitHub.


PDF generation is done in band

This is a potential DOS vector.

[ ] Move generation to background process

Thanks @dan-palmer


unable to build on windows

after following steps in README.md, arrived at this error when trying to build
error: linking with `rust-lld.exe` failed: exit code: 1

...
/* omitted long list of paths */
...

  = note: rust-lld: error: undefined symbol: IID_ICodecAPI
          >>> referenced by C:\Users\Moruph\vcpkg\buildtrees\ffmpeg\src\n4.4.1-9dd22c1484.clean\libavcodec\mfenc.c:1068
          >>>               avcodec.lib(mfenc.o):(mf_init)

          rust-lld: error: undefined symbol: IID_IMFMediaEventGenerator
          >>> referenced by C:\Users\Moruph\vcpkg\buildtrees\ffmpeg\src\n4.4.1-9dd22c1484.clean\libavcodec\mfenc.c:996
          >>>               avcodec.lib(mfenc.o):(mf_unlock_async)

          rust-lld: error: undefined symbol: IID_IMFTransform
          >>> referenced by C:\Users\Moruph\vcpkg\buildtrees\ffmpeg\src\n4.4.1-9dd22c1484.clean\libavcodec\mf_utils.c:633
          >>>               avcodec.lib(mf_utils.o):($LN56)

warning: `small-player` (bin "small-player") generated 22 warnings
error: could not compile `small-player` due to previous error; 22 warnings emitted

Hi,  you can get the lastest code, try again~ it should is ok.

it works now but i have to change the fonts
2022-11-16T03:14:37.084552Z  INFO small_player::resources::fonts: FontFamily::Proportional:
2022-11-16T03:14:37.084656Z  INFO small_player::resources::fonts:       chinese
thread 'main' panicked at 'Failed to find replacement characters '◻' or '?'', C:\Users\Moruph\.cargo\registry\src\github.com-1ecc6299db9ec823\epaint-0.19.0\src\text\font.rs:258:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2022-11-16T03:14:37.100038Z  INFO small_player::services::player::player: Player Dropped
error: process didn't exit successfully: `target\debug\small-player.exe` (exit code: 101)

it works now but i have to change the fonts
2022-11-16T03:14:37.084552Z  INFO small_player::resources::fonts: FontFamily::Proportional:
2022-11-16T03:14:37.084656Z  INFO small_player::resources::fonts:       chinese
thread 'main' panicked at 'Failed to find replacement characters '◻' or '?'', C:\Users\Moruph\.cargo\registry\src\github.com-1ecc6299db9ec823\epaint-0.19.0\src\text\font.rs:258:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2022-11-16T03:14:37.100038Z  INFO small_player::services::player::player: Player Dropped
error: process didn't exit successfully: `target\debug\small-player.exe` (exit code: 101)

Can you show your code?


migrations改用佇setup產生json

Coverage decreased (-62.9%) to 28.708% when pulling b4f38876c3e64d412143026ec9ce7e0827593808 on migrations改用json載入 into ceb1ba7ca4ee689fd8fd20b3c3444394213985e3 on master.

Coverage decreased (-27.5%) to 64.115% when pulling 8bb867fff3d7e6695cdf8f26f8059caf23010cf8 on migrations改用json載入 into ceb1ba7ca4ee689fd8fd20b3c3444394213985e3 on master.

Coverage decreased (-27.5%) to 64.115% when pulling 8bb867fff3d7e6695cdf8f26f8059caf23010cf8 on migrations改用json載入 into ceb1ba7ca4ee689fd8fd20b3c3444394213985e3 on master.

Coverage decreased (-27.5%) to 64.115% when pulling 8bb867fff3d7e6695cdf8f26f8059caf23010cf8 on migrations改用json載入 into ceb1ba7ca4ee689fd8fd20b3c3444394213985e3 on master.

Coverage decreased (-27.4%) to 64.251% when pulling b28c986c8cb8eedaf356472d9656f7fcf4cd9b31 on migrations改用json載入 into ceb1ba7ca4ee689fd8fd20b3c3444394213985e3 on master.


tsinterpret for multivariate time series regression?

Motivation. and
Describe the solution you'd like
similar functionality as is available for time series classification, should be available for time series regression

@alitirmizi23 hello! have you found a way to do this?

Hi @dyhan316  and @alitirmizi23,
Unfortunatly, this is not possible with the current methods in TSInterpret. There is literature on how to do this for Regression. However for now they are not implemented here. (So far I did not have the time).  I still left the issue open, as it is a relevant addition and I plan on adding some algorithms when time allows it.
If you are interested, I can point you to some relevant Literature.
Also feel free to contribute :)

Hi @JHoelli,
I would also be interested in such a feature. I would like to build an XAI TCN model for univariate TS regression, so I would love to have read to Literature you mentioned.

Hi @AlexisTabin,
i started a summary repository for the topic "(Post-Hoc) Explainability for time series" here with a subsection for regression / forecating. Fell free to look through the sources and linked github repos or add things if you feel something is missing.
My best guess would be trying Dynamask (github, paper).
I hope that helps.


Downgrade Cython to 0.26.1 for builds

Until #5390/#5406 fixes the stuff for the newest stable version of Cython we need to use the previous version (it won't compile) otherwise we can't really run the tests.

It's ok, just make sure to switch it back. It always uses the latest Cython to act as a canary.


fix discord link

Coverage remained the same at 91.925% when pulling 1c1b466ff6c9f57016c2b8ff1728501b42d45f27 on hamdiallam-discord into 4903388da40529c2227e426af2d8c9b4c79a0fcc on master.


stm32: Remove OptionalPin

The idea behind OptionalPin has a few problems:

you need to impl the signal traits for NoPin which is a bit weird https://github.com/embassy-rs/embassy/blob/master/embassy-stm32/src/dcmi.rs#L413-L416
you can pass any combination of set/unset pins, which needs checking at runtime  https://github.com/embassy-rs/embassy/blob/master/embassy-stm32/src/dcmi.rs#L130

The replacement is to do multiple new constructors for each combination of pins you want to take.

bors r_

bors r+


User research

This issue will track and document user research to provide more context.

HN thread containing post-survey discussion and feedback
https://news.ycombinator.com/item?id=34390585

HN thread containing post-survey discussion and feedback
https://news.ycombinator.com/item?id=34390585

Some feedback
(1)

There are four things [someone] need in a package manager.

Setup the environment on a virgin OS. ( Eliminates complicated readme)
Maintaining version dependencies ( some are outside pip and internal c modules)
Deploying with pyarmor and pyinstaller.
Occasionally needing to build binaries for c module projects in all supported python versions and operating systems.
I just happened to see this and didn't realize poetry even existed until now!
(I've also just learned rust and I think it's ruined me for a lot of other languages)

(2)

I went from pip to poetry a while back, and my experience is mostly fine after settings things up. What I would look at:

Easy way to start a project (poetry does that fairly well with poetry init, although you do have to create the venv afterwards)
Easy way to create a new venv, integration with pyenv / managing multiple Python versions is a huge plus. Poetry is not that intuitive for this. I usually set things with Pyenv and then do a poetry shell (this is only after I changed the configuration to make poetry create envs with a default .venv name (the dot is import because it keeps the venv at the top), within the project folder. Poetry's default is terrible (random long name, outside the project)
Easy way to manage the dependencies: Poetry is incredibly slow (sometimes 10-20 seconds to install/remove a package), the way to add extras in poetry is terrible (pip was way better with pip install abc[xyz]. Poetry needs the --extra, not nice. Poetry silently updates packages (this is not very cool imo): if you add a new package and there's been a new bugfix release x.x.01, if your dependency is only set on x.x, poetry will automatically update. This is fine, but I would rather do it manually.
Poetry dev option is nice, much like npm/yarn, some that was missing in pip, nice to keep
Poetry visuals are... ok. In one way is fine, but it also exposes a lot of Raw python exceptions which don't really make sense to me (like package not found) if you try to remove a package that doesn't exist
Poetry is extremely rigid. some minor conflicts tend to be ok, specially on dev dependencies (this happened a lot in a project with FastAPI, Click and Black) i don't remember which, but Poetry wouldn't let me install black because a conflict of some other package wanting some other click version. Actually it works, so I'm fine with the conflict, poetry just won't let me install it. so I always install black wi
th pip.
Poetry is not that smart monitoring the environment. Again I won't remember the situation exactly, but quite a few times I have a venv that is different from the pyproject/.lock file. I now this sounds obvious when I just mentioned using pip, but the former case was literally the only time I changes an environment without poetry, and fairly often I find myself rebuilding the venv because something is weird.
I value integration with other forms of dependency managed (eg requirements.txt) so exporting the dependencies to a requirements (with/without dev dependencies) is needed, for me this is relevant mainly when using Dockerfiles)
Good docs: Poetry's docs are nice.
PS: I've never used Hatch, so can't compare.

Tagging #128 and closing since this will just become a hanging issue. I can document this somewhere else.


[SPARK-45263][CORE][TESTS] Make EventLoggingListenerSuite independent from spark.eventLog.compress conf

What changes were proposed in this pull request?
This is a test-only PR to make EventLoggingListenerSuite independent from spark.eventLog.compress conf's default value.
Why are the changes needed?
Currently, EventLoggingListenerSuite test code has an assumption that the default value of spark.eventLog.compress is false.
https://github.com/apache/spark/blob/892fdc532696e703b353c4758320d69162fffe8c/core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala#L178
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs. Since we only clarify the assumption, the test suite should pass like the following.
[info] EventLoggingListenerSuite:
[info] - Basic event logging with compression (837 milliseconds)
[info] - End-to-end event logging (2 seconds, 99 milliseconds)
[info] - End-to-end event logging with compression (6 seconds, 966 milliseconds)
[info] - Event logging with password redaction (8 milliseconds)
[info] - Spark-33504 sensitive attributes redaction in properties (15 milliseconds)
[info] - Executor metrics update (32 milliseconds)
[info] - SPARK-31764: isBarrier should be logged in event log (262 milliseconds)
[info] Run completed in 11 seconds, 242 milliseconds.
[info] Total number of tests run: 7
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 7, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 18 s, completed Sep 21, 2023, 2:34:50 PM

Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this test-only PR, please, @viirya ?

Thank you!

I merged this test-only PR after manual testing.


Only Puma working?

Currently trying to make use of your code by testing the examples. All works fine for the Puma but when using the Orion or creating my own 6dof robot I get issues.
Essentially with the Orion or my 6DOF, I have to leave the DH parameters at 0 for the STL files to construct something that looks like a robot:

The problem with this is when I rotate link 2 by 90 deg the link rotates about the wrong axis:

With the correct DH parameters the default robot position looks like:

Any help with this would be appreciated! Not sure if this project has gone stale or not :/

Orion5 doesn't work anymore there is some issue with stl files i think

Does that mean that Robopy is currently only fit to model the Puma560 as my examples are based of a custom model not the Orion5?


Solve the latest version can not be used

Solve the latest version can not be used
The latest version has no effect after clicking. After debugging, this modification is fine.

Thank you for your contribution, I've published a full fix for the latest Terminus version.


Use XML Scheme to have valid xml

http://www.sitemaps.org/protocol.html
Use the xml scheme to have valid xml for http://www.validome.org/xml/validate/
Like
 <urlset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

     xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd"

     xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"

     xmlns:example="http://www.example.com/schemas/example_schema">

and
 <sitemapindex xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

     xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/siteindex.xsd"

     xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">

Thanks for raising this, going to work on this for the next release (which is coming soon, sorry it took so long to integrate).

Thanks this would be great :+1:

Worked on this on the develop (v4) branch you can see here https://github.com/ThePixelDeveloper/Sitemap-v2/tree/develop
I'll have a release prepared for the end of the week if all goes well.


This page should be revised

The Important sections are out of date.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c7f272b-4ea7-a285-4a9f-e67583a664e0
Version Independent ID: 54ac0c3d-a2b5-6001-1581-167dd87a80c0
Content: Self-service deployment overview - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/deployment/infrastructure-stack.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @rashmansur
Microsoft Alias: rashmim

BUG 583270 created to track.


Program not detecting video/audio track

I'm having this problem with multiple different files. They're all .mkv using the Codec h264 - MPEG-4 AVC. To conserve space, the files refer to separate files that would otherwise be repeated in every video. That said, I have other files that do all these things and load fine.
Here is a link to one of the files displaying the problem.
An image showing the codec, though I don't think it's relevant.

The problem with these files isn't the ordered chapters (though that's also an issue (#35) but it manifests in a different way), I believe it's an instance of the "too many tracks" issue.
I haven't posted about it on this tracker yet, but I have posted it on the FFMS2 issue tracker, where I believe the issue lies.
See FFMS/ffms2#185.


How do I CMake install a library from vcpkg

Hi, I recently started using vcpkg and it's all been great. However I'm not sure the best or correct way to install a library I am using from vcpkg.
For instance I used to build pugxml in my own code base which was built using a hand crafted CMakeLists.txt. Part of that CMakeLists.txt was a CMake install command to install the DLL that was built. I install the DLL into the same tree as all the other DLL's that get built to avoid having to mess around with runtime PATH settings.
So now I use pugixml from vcpkg which builds fine, however how should I replace the "install". I am no longer building the library to I have no CMake target, also it's not clear for any given package what things I should install for runtime. At the moment I am hard coding paths an library names in my install which seems wrong.
So is there a standard way to do this?

Hi @davidhunter22, thanks for reporting this issue!
You can use command .\vcpkg integrate install then add -DCMAKE_TOOLCHAIN_FILE=VCPKG_PATH\\scripts\\buildsystems\\vcpkg.cmake to your project configuration.
See documentation.
Thanks.

No, this wasn't a question about to use a vcpkg I can do that fine as I mentioned with pugixml. This is about how I call CMake install in my own project to install a library, say pugixml.dll, from the vcpkg tree to wherever I am installing the rest of my project.

See https://github.com/microsoft/vcpkg/issues/13797#issuecomment-700605701

Please track this issue in #14203.
Thanks.

Please track this issue in #14203.
Thanks.


[config:generate] Add override for drush_version

Possibly provide a default value based on the drupal_version variable if set.


Take a GraphQL::Schema as input?

I'd like to build docs in the same Ruby process where the GraphQL::Schema is. Would you accept an API that takes input from an in-memory source? Maybe
result_hash = MySchema.execute(GraphQL::Introspection::INTROSPECTION_QUERY)
GraphQLDocs.build(introspection_result: result_hash)

or
GraphQLDocs.build(schema: MySchema)

For now, I'm writing to an intermediate file:
    res = ResourcesSchema.execute(GraphQL::Introspection::INTROSPECTION_QUERY)
    File.write("./__GraphQL", JSON.dump(res))
    GraphQLDocs.build(path: "./__GraphQL")

Yes, absolutely! introspection_result as a key name is fine by me.


Surprising behavior with Thread.sleep() in a synchronized method

I have just started trying out recent versions of TeaVM, running some tests of threading and synchronization.  I have a test which runs several threads in parallel, all calling a synchronized method printing messages.  The first batch of threads do not pause at all.  The second batch of threads uses sleep() to pause between messages.
Surprisingly (at least to me), the second batch does not print out all of the messages.  At some point sleep() does not return.  Is there a better way to pause threads in TeaVM?
This is the class in question.
public class Client {

  public static void main(String[] args) {
    startThreads(false);
    startThreads(true);
  }

  public static void startThreads(boolean sleep) {
    for (int i = 0; i < 2; i++) {
      final int id = i;
      new Thread(() -> {
        printMessages(id, sleep);
      }).start();
    }
  }

  public synchronized static void printMessages(int id, boolean sleep) {
    for (int j = 0; j < 2; j++) {
      System.out.println((sleep ? "sleep on  " : "sleep off ") + id + ": " + j + "  @" + System.currentTimeMillis());
      if (sleep) {
        try {
          System.out.println("sleep starting...");

Thank you!

@ScraM-Team what backend do you mean? JavaScript?

Yes, JavaScript backend.


roslisp_common: 0.2.10-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository roslisp_common to 0.2.10-0:

upstream repository: https://github.com/ros/roslisp_common.git
release repository: https://github.com/ros-gbp/roslisp_common-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.26
previous version for package: 0.2.9-0

ROS Jade has been EOLed. We don't run any infrastructure anymore to build new Debian packages.

Oh, sorry, should pay more attention to the release messages on discourse, my bad.

No problem. That is what we have Travis for :wink:


Add test input API

After training, there should be test input. Input test (u, i) pairs and output scores.

If each cluster has full size user, item matrices, in training period, it would take some positive items in other cluster as negative samples, which may degradate the metrics. (it corresponds to our settings so that the interaction in each cluster do not affect another cluster)

solved in https://github.com/nmrenyi/ReChorus/commit/49c75b8875f774d88e40e73d5120522757a7bbb8


feat(frontend): Derived store to find pending transactions

Motivation
We want to display a warning messange and disable the send form if the modal is for bitcoin and the user has pending transactions.
The bitcoin addresses are unique. Therefore, I wanted to take advantage of that instead of checking selected networks or tokens.
The idea is to create a derived store creator that will return true, false or "loading" depending on the address and whether the bitcoin addresses have been loaded:

Return true when the address is a bitcoin address and the pending transactions array is not empty.
Return "loading" if the addresses or the pending transactions are not loaded. This is trickier because we also need to check the testnets. If testnets are not enabled, then the addresses for testnet and regtest won't be loaded.
Return false if the pending transactions are present and empty.

NOTE: The code for the store is still under further improvement. I wrote a first implementation, then I want to add unit tests and then refactor to make it cleaner.
This derived store will be used in IcSendForm:
let hasPendingTransactionsStore: Readable<boolean | "loading">;
$: hasPendingTransactionsStore = initHasPendingTransactionsStore(source);

//...

{#if $hasPendingTransactionsStore}
  <WarningMessage>{...}</>

Changes

Tests

@peterpeterparker @AntonioVentilii-DFINITY please review
This is still in Draft, but I want to confirm the approach before I write the tests and spend time improving the code.

The pending transactions won't be fetched in a web worker? If there are, you can compute what you need there without arming the UI.

The pending transactions won't be fetched in a web worker? If there are, you can compute what you need there without arming the UI.

Pending transactions don't need to be pulled regularly. That's why I don't think it makes sense to put them in a web worker.
Even if they are loaded in a web worker, they can still go into the store I merged in #2635 , right?
Then the component will read from this derived store and render the warning message or not.

Pending transactions don't need to be pulled regularly.

Are you sure? If I go to my Bitcoin wallet XYZ and send BTC to my Oisy Wallet, does this result in a "Pending Transaction"?

Pending transactions don't need to be pulled regularly.

Are you sure? If I go to my Bitcoin wallet XYZ and send BTC to my Oisy Wallet, does this result in a "Pending Transaction"?

Good question, I see the confusion. These are "sent" pending transactions. This is the only moment where we would disable sending.
Shall I rename the store "pendingTransactionsStore" to "btcPendingSentTransactionsStore"?

Ah, sorry for the confusion. Maybe yes, let's rename the store even if verbose.

Shall I do it after this PR? In this PR? Or in another PR and then fix the merge conflicts in this PR?

Shall I do it after this PR? In this PR? Or in another PR and then fix the merge conflicts in this PR?

No strong opinion. Your call.

Shall I do it after this PR? In this PR? Or in another PR and then fix the merge conflicts in this PR?

No strong opinion. Your call.

I'll refactor both stores in an upcoming PR after this one is merged.

@peterpeterparker ready for another review


Use a new MariaDB connection object for every api request

Checklist

[X] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated.
[X] Changelog entry has been written

Moved the sqlClient constructor inside of the Apollo server and express middlewares so that a new connection will be generated for every request. Putting it in the Apollo Server and passing it to resolvers via context means the connection will be shared when multiple resolvers need to be called to fulfill one request.
90% of the code changes are just adding sqlClient to the resolvers and auto-formatting changes. The magic happens in apolloServer.js and authMiddleware.js
Changelog Entry

Improvement - Each API request will generate a new MariaDB connection (#920)
Closing issues
closes #920

Seeing a lot of error messages now about too many connections:

api_1                            | error:  message=Too many connections, stack=Error: Too many connections, code=1040

It looks like connections must explicitly be closed, combined with a new connection for every request makes sense that it runs out. Just looking at the docs for apollo server I can't see any way to close the connection after a request has been "finished." Will have to dig into code or ask SO or somewhere.

Found an undocumented plugin system in apollo server that can listen to request pipeline events. I no longer get connection errors, and tests are green.


Production readiness

Hi, I briefly checked this out and it looks like just what I was thinking to build myself. I got it working in a Vue project, sort of, but I noticed you said it's just a thrown-together project. Do you have plans to continue working on it or was it just a little project?

Yes this project was thrown together but the internal code works well enough for now.
I definitely have plans to work on it and one thing I want to improve is to make it easier to use with a bundler of your choice.
I'm still figuring that part out. Once that's done, i think it will be a pretty easy to plug it into your setup (including production)

Yeah? Cool, well if there's anything I can do to help, let me know.
In the meantime, if you could help me actually get it setup, that would be great. I've got my Vue.config file setup to customize the webpack config like so:
const HtmlWebpackPlugin = require('html-webpack-plugin');
const { emitCSS } = require('catom/dist/css');

module.exports = {
  configureWebpack: {
    plugins: [
      new HtmlWebpackPlugin({
        templateParameters: async function templateParametersGenerator(
          compilation,
          assets,
          assetTags,
          options
        ) {
          const css = emitCSS();
          return {
            compilation: compilation,
            webpackConfig: compilation.options,
            htmlWebpackPlugin: {
              tags: assetTags,
              files: assets,
              options: Object.assign(options, {
                css,
              }),
            },
          };
        },
      }),
    ],
  },
};

In my code I've got

const styledButton = css({
  color: '#ff0000',
  borderRadius: '5px',
  padding: '4px',
});
console.dir(styledButton);

Which prints out styledButton______6da32 styledButton_____quva1q styledButton______2rlxtj. I think that's sort of right, but Im not getting the stylesheet linked up.

you have to inject it in your index.html file

Is it possible for you to share your project?

Cant share my project, but I got a simple example up on Codesandbox https://codesandbox.io/s/priceless-thunder-s177l?file=/src/App.vue

You'll have to add the babel plugin too

Like this? https://codesandbox.io/s/priceless-thunder-s177l?file=/babel.config.js
Still getting the error "Catom is in compile mode! Are you sure you ran your webpack transform correctly?"
But I found that it may be due to this file https://github.com/Hydrophobefireman/catom/blob/master/index.ts
Vue.js has a devmode runtime which may be the issue. While catom might still work if it's only run at build time. Or something like that?

as of now catom is a babel plugin , which means it should be running along with everything else that babel does.
I'm not too familiar with vue cli but maybe your babel.config.js file isn't being imported?

I'm pretty sure that it is, as that is how the Vue CLI configures things to work. Sorry, I didnt mean to drag you into a rabbit hole. Thanks for looking into it, and I hope I can sort it out, but I dont want to take up too much of your time on it.

that's alright, I'll try test it on my machine instead of code sandbox

Makes sense to try. I got the same errors on my end if that helps at all.

Yeah? Cool, well if there's anything I can do to help, let me know.
In the meantime, if you could help me actually get it setup, that would be great. I've got my Vue.config file setup to customize the webpack config like so:
const HtmlWebpackPlugin = require('html-webpack-plugin');
const { emitCSS } = require('catom/dist/css');

module.exports = {
  configureWebpack: {
    plugins: [
      new HtmlWebpackPlugin({
        templateParameters: async function templateParametersGenerator(
          compilation,
          assets,
          assetTags,
          options
        ) {
          const css = emitCSS();
          return {
            compilation: compilation,
            webpackConfig: compilation.options,
            htmlWebpackPlugin: {
              tags: assetTags,
              files: assets,
              options: Object.assign(options, {
                css,
              }),
            },
          };
        },
      }),
    ],
  },
};

In my code I've got

const styledButton = css({
  color: '#ff0000',
  borderRadius: '5px',
  padding: '4px',
});
console.dir(styledButton);

Which prints out styledButton______6da32 styledButton_____quva1q styledButton______2rlxtj. I think that's sort of right, but Im not getting the stylesheet linked up.

catom was working as expected.
What changed from then and now?

Oh, based on the examples in the readme, I was expecting class names that looked more like quva1q
And the thing that's not actually working is getting the CSS generated. The classes were being output just fine, but I wasn't getting any styles.

That's a prod mod thing in dev mode it generates that along with the variable
you need to edit the public index.html file for that and u inject the styles yourself

Right. Which was your comment above

But this was not working for me. Anyway, I think this is sort of the kind of rabbit hole I didnt want to take you down. So it's fine if we don't get the issue sorted today.

Hey, I think i figured it out
Vue.config.js
const { emitCSS } = require("catom/dist/css");

module.exports = {
  chainWebpack: (config) => {
    config.plugin("html").tap((args) => {
      args[0].css = emitCSS; // DO NOT CALL IT HERE
      return args;
    });
  },
};

and  somewhere in your public/index.html

OK, this is a lot closer. Works in dev mode, but not on build (npm run build). When I have some free time, I want to dig into the code and see if I can figure out how it all works.

Sure.

vue create catom-vue
npm i catom
Modify vue.config.js, babel.config.js, and public/index.html.
Add catom styles to App.vue

With that setup, the npm run dev command works and shows the styles from catom, but on npm run build no CSS is generated for the build (I deleted all other styles).
Looks like there is an empty <link href="/js/app.337cf251.js" rel="preload" as="script"><link href="/js/chunk-vendors.e17dfa99.js" rel="preload" as="script">We're sorry but catom-vue doesn't work properly without JavaScript enabled. Please enable it to continue.

The result is whatever I put in App.vue, but without the styles.

okay I know this one.
It's an issue with catom and bundler caching
one temporary fix is to remove node_modules/.cache before running serve and build
or adding the rm command to your your package.json
till i fix this from my end that is.

Oh ok. That's interesting. I'll take a look at that fix. Thanks.

Thanks for that, I'm just glad someone else is finding this project useful.
Lmk if you hit any other issues while working on it


Bugfix

I create new module and set plugin to store. But this plugin doesnt call when I update the store.
export const Wishlist = createModule({
  key: KEY,
  store: {
    modules: [{key: KEY, module}],
    plugin
  },
  afterRegistration
})

Please do update the changelog before merge

Please do update the changelog before merge

Could you help me? I must update CHANGELOG.md file and section Fixed?

yes, please

Done.

Thanks @serzilo ! :)

Related to #3238


Replace MRB_NO_DIRECT_THREADING with MRB_NO_THREADED_CODE

The "Token Threading" technique is correct at now, but the future is uncertain, so the abstraction level is raised.

I am not sure how proposed wording is better. Could you explain?

:black_cat: My only source of information is https://ja.wikipedia.org/wiki/スレッデッドコード, which may be suspect.

The current implementation is based on "Token threading".
"Direct threading" is not "Token threading".
"Token threading" is not "Direct threading".
"Threaded code" includes "Token threading", "Direct threading", "Huffman threading" and etc..

I fixed the conflicts and rebased.

I understand the wording (and I am sure it's valid, since Prof. Ertl mentioned). But since we see “switch threading” in the reference, so if used precisely, the term threaded code itself is meaningless. Let me think about it for a while.

Oh, "Switch threading".
Hmmm, I'll leave this PR open for now, but switch to draft.

How about MRB_USE_SWITCH_THREADING?
Or is MRB_USE_VM_SWITCH_DISPATCH more understandable?

I prefer the term "switch dispatch" to "switch threading", for not using direct goto.

Thanks for your comment.
Replaced with MRB_USE_VM_SWITCH_DISPATCH.
And DIRECT_THREADED has been merged into MRB_USE_VM_SWITCH_DISPATCH.
So, please note that #ifdef and #ifndef have been replaced by the reverse.


verify-elf: ERROR: ./usr/lib64/liburing.so.2.4: undefined symbol: memset

We have our build system lint (verify-elf) reporting error for liburing.so binary for v2.4 on aarch64 (only, on x86_64 there's no problem):
verify-elf: ERROR: ./usr/lib64/liburing.so.2.4: undefined symbol: memset

builder@aarch64:~/RPM/BUILD/liburing-2.4$ ldd ./src/liburing-ffi.so.2.4
        statically linked
builder@aarch64:~/RPM/BUILD/liburing-2.4$ nm -D ./src/liburing-ffi.so.2.4
0000000000000000 A LIBURING_2.4
0000000000006344 T __io_uring_buf_ring_cq_advance@@LIBURING_2.4
...
0000000000004150 T io_uring_wait_cqe_timeout@@LIBURING_2.4
0000000000004080 T io_uring_wait_cqes@@LIBURING_2.4
                 U memset

Perhaps, something is linked incorrectly or memset is defined incorrectly.

Perhaps, something is linked incorrectly or memset is defined incorrectly.

Since commit db5403e ("nolibc: Do not define memset() function in liburing"),
liburing no longer has a function called memset(). I changed it to
__uring_memset() because it conflicted with the memset() function
from libc.
I'm not sure what's going on with aarch64 here. Need more clue...

Yeah that's funky, I see the same on aarch64 here:
axboe@m1max ~/gi/liburing (master)> nm -D src/liburing-ffi.so.2.4 | grep " U " 0.013s
                 U memset

And botched that for !nolibc... Not batting 1000 this morning, hopefully current git is sane.

Thanks much! [Btw, you have typo in commit message s/aarc64/aarch64/]

Yep I will write an announcement, but deferred it since I wanted to make sure we didn't have a silly issue. Which turned out to be a good thing! You don't really get good coverage before it's tagged, which is a bit of a problem.


Improve combat

Fleeing gives the monster one last attack
Not always immediately spawn a new monster after winning a battle

Requested merging: Combat improvements flee attack of opportunity #69


Register form - wrong working request in username (Windows)

Testing was done on: Windows 7
Arizen version: 0.1.0-beta
Register form doesn't work properly. At first it is necessary to write a username with at least four letters. The requsted is highlighted by red color. See picture bellow.

But if it is written only 1 letter, the statement has been changed to green to indicate that the username is correct. See picture bellow.

fixed in 3ea11557d4a8de739c15fe27cd5fc7f4dda3c096