pkg/achx: properly set RDFI info according to debit/credit

Also, set a config option for adding Addenda05 records with batches.

Codecov Report

Merging #492 into master will decrease coverage by 8.11%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   56.48%   48.37%   -8.12%
==========================================
  Files          70       71       +1
  Lines        2645     2669      +24
==========================================
- Hits         1494     1291     -203
- Misses        903     1164     +261
+ Partials      248      214      -34

Impacted Files
Coverage Δ

pkg/achx/files.go
84.61% <ø> (ø)

pkg/config/odfi.go
36.66% <ø> (ø)

pkg/transfers/fundflow/first_party.go
64.51% <0.00%> (-2.16%)
:arrow_down:

pkg/achx/ppd.go
54.43% <33.33%> (-30.19%)
:arrow_down:

pkg/achx/batch.go
60.86% <100.00%> (ø)

pkg/upload/sftp.go
15.05% <0.00%> (-54.31%)
:arrow_down:

pkg/database/mysql.go
11.11% <0.00%> (-51.12%)
:arrow_down:

pkg/customers/client.go
8.00% <0.00%> (-51.00%)
:arrow_down:

pkg/config/admin/routes.go
77.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bfcfbf...98f6e9e. Read the comment docs.


JavaScript Client

What's does the "client" imply ? Read but not write ? Something else ?

In this context, it implies a 'remote' server is required to do anything substantial. Akin to js-http-client.


Pricing google maps

Hi guys,
I am a little lost in the google maps pricing if I use this plugin.
If I do not use search but only:
Place multiple pointers on the map
Move the map dynamically
And use the button locate me
How much would it cost?
Would it be free or is it an advanced use?
Thanks,

Ok I found. It's free unlimited. We are on sdk android api


Test coverage across languages for Text Analytics

Consider doing this before GA : https://microsoft-my.sharepoint.com/personal/iscai_microsoft_com/Documents/TA test coverage.xlsx

I thought we had some time, but GA'ing soon!


Master build to test latest features

Hi,
Where can I get Master build to test latest features ?
Thanks.

You can build it from source code.


Questions about  reading & writing log to file

I made my application logs to file, it working just fine but I have several questions:
First
What do I do with this text file? I mean when you try to read it in a normal text reader like Notepad++ or Vs Code you will se some 'ESC' or color chars thats not working. Is there any extensions kinda thing (that I searched but couldn't found) that reads that ansi color and changes the line's color acourding to it? Is there a way to convert those 'ESC' and '[0m' (end of line I guess) chars to something else automaticly.
Log file view

Second
Can I log the systems/flutter's logs to the same file too? If there will be an other error like widget cant fit to the screen or something, the flutter it self would log it to the console but the file output wont contain it. Also in release mode how to log these logs to the file.
Note: I know this is most likely a stackoverflow question but im asking here bc maybe someone tryed to log the system logs to this package before. If there is no other solution than logging to seperate file you can ignore this question.

Thank you for your answer @Bungeefan, I really love this answer. I will notify you if I can find something useful about ansi colors, for now the file is readable so it will do it.
About why I dont want to change PrettyPrinter is that I wrote a Decorator for the FileOutput that both outputs to a file and the console. So I wanted that colors on my console.
Here is what I have as the output, if you want to check:
import 'package:logger/logger.dart';

class FileOutputDecorator extends FileOutput {
  FileOutputDecorator({
    required super.file,
    super.encoding,
    super.overrideExisting,
    this.outputConsole = false,
  });

  bool outputConsole;

  @override
  void output(OutputEvent event) {
    super.output(event);

    if (outputConsole) {
      for (var element in event.lines) {
        // ignore: avoid_print
        print(element);
      }
    }
  }
}

And Im using it like
FileOutputDecorator? logOutput;
// initializing logOutput here (if fails its null)
output: logOutput ?? ConsoleOutput(),

Again thank you for the answer, I guess thats should resolve my questions.

There is a VS Code extention for both editing & previewing the ANSI coded file. Extensions ID: iliazeus.vscode-ansi work fine for me now.
In case anyone else wants to do the same thing what I do.

Does file-writer uses write-buffering? If yes, how to flush buffer to file?

Hi @kostov, the FileOutput uses an IOSink to write its output, which AFAIK can be buffered (depending on the implementation/platform).
In general, you are able to call flush() on an IOSink, however, there is currently no way to manually flush the internal IOSink in the logger, except when closing it via close().

@Bungeefan, thank you,
will try to close() it before send log-file, then re-create.

will try to close() it before send log-file, then re-create.

returned to the project, made it as proposed -- works fine

will try to close() it before send log-file, then re-create.

returned to the project, made it as proposed -- works fine

Im sending my log files to the server on a feedback case too. Never considered that I need to call close command. I tought the FileOutput automaticly flushes to the file. Did you test it without close comand ? Is there any lost on the logs ?

Sry about the title misunderstanding btw. This issue was for my questions. May need to carry this to an other issue

Did you test it without close comand ?

No (I'm lazy :). But after fix all logs became fine, and before was not...

I tought the FileOutput automaticly flushes to the file.

I'm afraid this is not effective. I think all file operations (in common case) should be buffered.


Light bulb support for tsx files

System information

OS: Windows 10
TypeScript Hero version: 0.10.1
VSCode version: 1.7.1

Description
Awesome extension, helped me a lot during my last huge code refactoring.
Very useful when you have moved bunch of files and then it is very boring to manually type all new imports.
While it worked flawlessly for .ts files I do not see any bulb for .tsx files.
If that is the issue please fix it.
Steps to reproduce
Go to .tsx file and remove all imports. Then put cursor on some red reference and try to get a light bulb action.

Hey @megaboich
Seems like the registering of the code action provider missed tsx :-)
Will have a look into it


Vue 3 , setup script , watcher , ReferenceError: getItems is not defined

Vue version
3
Link to minimal reproduction
https://play.vuejs.org/#eNqNUj1PwzAQ/SsnLw1S1A5shSIB6gADIEAsmCE4l+I2sa2z3Vaq8t+5OG0KEqrwZN87v/fuYyeunRuvI4qpuPSKtAvgMUR3JY1unKUAOyCsctgUQX1BCxXZBkb8YySNNMoaH8CRdR5mUGKlDT51r2wnDfBpbIn1W1FHnML74+cSVcjhITafSB+5NO3ZRUczmegw8mBX0iSdLDuD2VXPOz5S5JCpSJSwxK+rQ2Qvt8BwF7DxWccL0LJCzhXopsFSF4FNBIoIg+wzVkhoFM6JLE2H/6A9GBv2FZX/spUzgOujuV9eTtnomzhIz6CX2bUJvZz0c+GJiFwEz9mVXoyX3hoeWlKSQtnG6Rrp0QXNbFJMDx2Roqhru7lPsU6Vu97H1Req1R/xpd92MSmeCD3SGqUYsFAQ++zh+csDbvk+gNyRWHP2CfAZva1j57FPu4mmZNs/8pLbu7R62ixe/Xwb0PhDUZ3RNNiULwXv4e2J0o92z8fnh4UQ7TdYf/w2
Steps to reproduce

Create SFC component
In setup script create watcher for modelValue with immediate: true
after the watcher define method getItems
set modelValue to false and check in watcher if true
after that set modelvalue to true
everithing is ok
on step 4 set modelvalue to true
you get error : ReferenceError: getItems is not defined

What is expected?
same behavior and no errors
What is actually happening?
in the first case there is no error , on second case there is reference error
System Info
No response
Any additional comments?
No response

This is expected behavior. An immediate watcher executes... immediately, which means it calls getItems before it is declared.
Either move const getItems = ... before the watcher or use function getItems() { ... } which hoists the function declaration.


[shuffle] txn devapi can take version|hash

Motivation
Matching the Dev API v1, add the ability to get a txn by a version number to the TS api.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Manual QA

/land


Problem in a multiple library repo: can't inter-depend on each other

Type of Issue
[x] Bug Report
[ ] Feature Request

Description
If I create a repo made of two libraries for which one depends on the other I can't figure out how to package the one that depends on the other. I get the error shown below.
How To Reproduce
I have a repo setup here. The libraries are in the packages folder. Note that ng-date-utils depends on ng-utils. But I get this error trying to package ng-date-utils.
cuervomovil:au-ng ken$ node_modules/.bin/ng-packagr -p packages/ng-date-utils/ng-package.json
Building Angular library
Generating bundle for @animalus/ng-date-utils
Cleaning bundle build directory
Processing assets
Running ngc

BUILD ERROR
Error at /Users/ken/dev/animalus/au-ng/packages/ng-date-utils/.ng_pkg_build/@animalus-ng-date-utils/ts/src/dateUtils.service.ts:10:27: Cannot find module '../../ng-utils/public_api'.
Error at /Users/ken/dev/animalus/au-ng/packages/ng-date-utils/.ng_pkg_build/@animalus-ng-date-utils/ts/src/module.ts:4:23: Cannot find module '../../ng-utils/public_api'.
Error at /Users/ken/dev/animalus/au-ng/packages/ng-date-utils/.ng_pkg_build/@animalus-ng-date-utils/ts/ng-date-utils.ts:7:45: Cannot find module '../ng-utils/public_api'.
Error: Error at /Users/ken/dev/animalus/au-ng/packages/ng-date-utils/.ng_pkg_build/@animalus-ng-date-utils/ts/src/dateUtils.service.ts:10:27: Cannot find module '../../ng-utils/public_api'.
Error at /Users/ken/dev/animalus/au-ng/packages/ng-date-utils/.ng_pkg_build/@animalus-ng-date-utils/ts/src/module.ts:4:23: Cannot find module '../../ng-utils/public_api'.
Error at /Users/ken/dev/animalus/au-ng/packages/ng-date-utils/.ng_pkg_build/@animalus-ng-date-utils/ts/ng-date-utils.ts:7:45: Cannot find module '../ng-utils/public_api'.
    at new UserError (/Users/ken/dev/animalus/au-ng/node_modules/ng-packagr/node_modules/@angular/tsc-wrapped/src/tsc.js:27:28)
    at check (/Users/ken/dev/animalus/au-ng/node_modules/ng-packagr/node_modules/@angular/tsc-wrapped/src/tsc.js:93:15)
    at Tsc.typeCheck (/Users/ken/dev/animalus/au-ng/node_modules/ng-packagr/node_modules/@angular/tsc-wrapped/src/tsc.js:173:9)
    at /Users/ken/dev/animalus/au-ng/node_modules/ng-packagr/node_modules/@angular/tsc-wrapped/src/main.js:122:23
    at <anonymous>

Expected Behaviour
please describe what behaviour or result you expected
Version Information
ng-packagr: v1.x.y
node: v8.x.y
@angular: v4.x.y
rxjs:
zone.js:

please include any version information that might be relevant, e.g. other third-party libraries

@crowmagnumb you need to use npm link or yarn link. you also need to make sure to package them in the correct order. so for example.
ng-packagr -p packages/lib-a
npm link packages/lib-a/dist
ng-packagr -p packages/lib-b

Thank you! It doesn't work exactly like that. I had to do both parts of the linking process. In your nomenclature...
cd packages/lib-a/dist
yarn link
cd ../../..
yarn link lib-a

...which for my repo was solved with the following scripts in the package.json...
    "build:utils": "ng-packagr -p packages/ng-utils/package.json && cd packages/ng-utils && yarn link && cd ../.. && yarn link @animalus/ng-utils",
    "build:date-utils": "ng-packagr -p packages/ng-date-utils/package.json",
    "build": "yarn run build:utils && yarn run build:date-utils"

I also found out the hard way (in that it took me a while to find out why it wasn't working) that you can't mix npm link and yarn link commands as they use different global directories to store the links in!
Thanks!

This is back to not working again with updated code. :( The repo linked to above fails on the building of the dependent repo with the following message ...
Cannot find module '@animalus/ng-utils'.

Any help would be greatly appreciated as this is critical to me going forward with this library system.  :)

OK, my bad. Sorry. You know how you set up automation, then come to rely on it, and then not really pay attention to it because well it's all automated right? Well, I just did that. I had automated the linking of the package after building, but then I later moved the location of where the package gets built to but did not update the linking code. So it kept linking to the old place and I didn't notice. Sorry, this still works. Closing again....

These kinda happens!

Hi guys is possible avoid the use of link?
i find out a plugin for rollup that could avoid this thing:
https://www.npmjs.com/package/rollup-plugin-paths
but I am not sure if there is a way to include plugin in ng-packagr

This can be achieved without linking the packages, as described in https://github.com/dherges/ng-packagr/issues/256

@mezoistvan are there any examples of this new functionality in use? I can't seem to find any.. I am trying to accomplish the same type of structure as Angular Material:
// Can import everything from the root:
import { FooModule, BarModule, BazModule } from '@my/lib';

// OR from individual entry points:
// FooModule imports BazModule
import { FooModule } from '@my/lib/foo';
// BarModule imports FooModule & BazModule
import { BarModule } from '@my/lib/bar';

The issue I'm having is during the build, modules can't be found. When BarModule imports other entrypoints, do I use relative paths (./../foo/module.ts) or 'library' paths (@my/lib/foo)?

Using the programmatic API, we are able to package the libraries in order, and during the packaging we are able to use the already packaged libraries. Something like:
await ngPackagr()
    .project('/usr/local/lib-1/package.json')
    .withTsConfig(customTsConfig)
    .build();

await ngPackagr()
    .project('/usr/local/lib-2-that-depends-on-lib-1/package.json')
    .withTsConfig(customTsConfig)
    .build();

@mezoistvan where should I put the snippet you show here?

@mezoistvan awesome that the API opens up the possibility for dependencies for a multi-library repo.
How would this work for Secondary Entry Points, it seems like an overkill to have to suddenly add a full package.json for each entry point. NPM also doesn't allow the name property to be like @angular/material/button.
Would be great if we can make Secondary Entry Points depend on each other. If there is already a way, would love to know how I could achieve this...
Thanks in advance!

@fetis This issue is closed. It works fine now.

@crowmagnumb I have this issue with new Angular v6. Shall I create the new one?

I suppose. Do you have a repo that recreates it?


Updated get_system_username() to handle OSError raised in Python 3.13.

Trac ticket number

N/A
Branch description
The createsuperuser management command raises OSError when a username isn't found in the system while using Python 3.13.
getpass.getuser() in Python 3.13 catches ImportError and KeyError the same way Django does, but raises OSError instead: https://github.com/python/cpython/commit/99a73c3465a45fe57cac01a917fc50e0743b5964
Reproduction steps
Run bash in a python:3.13 docker container to mount a directory owned by the local user to get a writable directory:
docker run --rm -it -u 1000:1000 -e HOME=/home/user -v $PWD:/home/user python:3.13 bash

Install Django:
pip install --user django

Create a project and run migration:
mkdir -p ~/djtest
~/.local/bin/django-admin startproject djtest /home/user/djtest
~/djtest/manage.py migrate

Create superuser:
~/djtest/manage.py createsuperuser

Exception output:
Traceback (most recent call last):
  File "/usr/local/lib/python3.13/getpass.py", line 173, in getuser
    return pwd.getpwuid(os.getuid())[0]
           ~~~~~~~~~~~~^^^^^^^^^^^^^
KeyError: 'getpwuid(): uid not found: 1000'

The above exception was the direct cause of the following exception:

...
  File "/usr/local/lib/python3.13/getpass.py", line 175, in getuser
    raise OSError('No username set in the environment') from e
OSError: No username set in the environment

Checklist

[X] This PR targets the main branch.
[X] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[ ] I have checked the "Has patch" ticket flag in the Trac system.
[ ] I have added or updated relevant tests.
[ ] I have added or updated relevant docs, including release notes if applicable.
[ ] I have attached screenshots in both light and dark modes for any UI changes.

@tweekmonster Thanks :+1: I've created ticket-35942 based on your report. Can you add release notes to the 5.1.4.txt.


Implement Object.defineProperty instead of Bridge.get

Once implemented, post a follow-up in this forum thread.
Expected
Demo.App.something = 1;

Actual
Bridge.get(Demo.App).something = 1;

Steps To Reproduce
public class App
{
    static int something;

    public static void Main()
    {
        App.something = 1;
    }
}

Live Bridge sample:
http://live.bridge.net/#b2f59e0776a60a15946e

IE8 support might be dropped because of its poor implementation of Object.defineProperty and an acceptable shim may not be available.
Possible work-arounds include:

https://github.com/inexorabletash/polyfill/blob/master/es5.js#L71

If IE8 is dropped, we need to update the list of supported browsers:
http://bridge.net/download/#release-notes
Also, Microsoft has dropped support of IE8 as of Jan 12, 2016. Actually they dropped support for IE8, IE9 and IE10 all at once. More:
https://www.microsoft.com/en-ca/WindowsForBusiness/End-of-IE-support
jQuery 2 only supports IE9+

Actually, Microsoft dropped support for all versions of IE except whatever version is the latest on each supported version of Windows. See: https://support.microsoft.com/gp/Microsoft-Internet-Explorer

I'd like to add that possible drop of IE8 support is going to unleash improvements to be done in Bridge getting rid of IE8 support hacks and also releasing resources to be used for new features development.

I think this is a good idea, I would release a final "IE8 compatible" version with all the fixes that you can.

Hi @SamuelEnglard,
Thank you for the feedback. We have decided to drop IE8 support - #1115.
So, let's consider 1.11 as a final IE8 compatible version.

The Object.defineProperty functionality has been implemented in Bridge 16.0. Please see Issue #1229.


Update TestPushToCentralRegistryUnauthorized to match updated hub

The error message was changed from "unauthorized: access to the
requested resource is not authorized" to "unauthorized: authentication
required".
Signed-off-by: Kenfe-Mickael Laventure<EMAIL_ADDRESS>--

LGTM
ping @aaronlehmann

LGTM

LGTM

This is passing already:
23:49:12 PASS: docker_cli_push_test.go:649: DockerSuite.TestPushToCentralRegistryUnauthorized	1.996s

@mlaventure - this looks to be breaking TP4 on all runs. Can you fix or revert please? @tiborvass

Yes, it looks like they reverted their update since; it breaks all CI not just windows.


🚀 Upgrade Python Version from 3.8 to 3.11 in Tirith

Python 3.8 is reaching its End of Life (EOL) in October, meaning it will no longer receive security updates or patches. To ensure the Tirith project remains secure, up-to-date, and takes advantage of the latest Python features and performance improvements, we need to upgrade the Python version used in the project from 3.8 to 3.11.
Tasks:
Update Pipenv Configuration:

Change the python_version field from 3.8 to 3.11 in the Pipfile.
Verify that all dependencies are compatible with Python 3.11.

I would like to work on this, Can you assign me..

Sure @Denish3436 assigned


[Docs] Mention how to skip subsets of exceptions in errorpages.rst

It appears that skipping subsets of exceptions in a generic error handler has been a major point of confusion; there are at least three open issues related to this: #2778, #2841, #2984.
This PR documents the workaround without modifying current behavior (whether 3XX should be captured seems to be a point of contention in the aforementioned issues).

Thanks for working on this. #2984 was fixed, so the specific behavior being demonstrated here is no longer an issue. I'm working on #2778, and will contribute some docs explaining those cases.


Undefined properties causing errors during mount

I'm not entirely sure how to summarise this issue but I've seen it a few times and I can't work out what I'm doing wrong. What seems to be happening, is that at some point during the mounting process, all the content of the component being mounted becomes undefined, which immediately causes any computed properties that rely on other data (props, for example) to fail.
To give an example, I have a bootstrap component that either renders a single button, or a dropdown button depending on the length of an actions array, which is a property. This is a simple computed property:
computed: {
  isSingleAction() {
    return this.actions.length === 1
  }
}

If I run console.log(this.actions) before this computed property, then I get 2 outputs: one which is the expected property that I'm passing in with propsData ([ { routeName: [Getter/Setter], label: [Getter/Setter] } ]) and then a moment later I see an undefined output. That undefined output immediately causes a stack trace when it tries to figure out length of an undefined value.
Does anyone have any idea why I might be seeing this?
The mount itself is really simple:
const globalActionsWrapper = mount(GlobalActions, {
  propsData: {
    actions: [
      { routeName: "foo", label: "Foo" }
    ]
  }
})

I'll figure out a good way to reproduce this. To work around it, adding v-if="actions" to the component's top level element prevents any undefined weirdness.

I'm going to close this, because I think it's more to do with my misunderstanding of the component lifecycle than a testing bug.

@robcresswell How did you solve the problem? I have the same problem, but for me it works in every context, but not the test. If I remove my code within "created" or "mounted" it works in test, but the functionality is broken.


DeleteBehavior.Restrict - exception isn't thrown in case of an inconsistent state on SaveChanges

From the description of DeleteBehavior.Restrict:
For entities being tracked by the Microsoft.EntityFrameworkCore.DbContext, the
values of foreign key properties in dependent entities are not changed. This
can result in an inconsistent graph of entities where the values of foreign key
properties do not match the relationships in the graph. If a property remains
in this state when Microsoft.EntityFrameworkCore.DbContext.SaveChanges is called,
then an exception will be thrown.

When I try to reproduce this, the SaveChanges sends a "delete" SQL command to the DB, and the DB throws an exception. EF doesn't throw its own exception before sending the command to the DB. So, the claim then an exception will be thrown is only correct if the DB is actually configured to throw an exception in this case.
Is this working as intended, i.e. EF is counting on the DB to throw an exception? Either way works fine for me, but I want to make sure.

The database. And yes, if the database is not setup with FK constraints, then it won't throw, and you'll have corrupted data.


A user should be able to fetch related published data

Issue Name
A user should be able to fetch related published data
Summary
A user should be able to fetch top 5 related published datasets.
And top 5 downloaded datasets (requires metrics)
A new endpoint is required that returns matching datasets
Steps to Reproduce
Current Behaviour
Expected Behaviour
Extra Details
Here you should include details about the system (if it is unique) and possible information about a fix (feel free to link to code where relevant). Screenshots/GIFs are also fine here.

Closed due to inactivity


Where is the SKU documentation?

Nowhere in the Key Vault documentation that I've seen explains the distinction between standard and premium SKUs. I can find the information from third parties, but it's utterly bizarre that MSFT makes no effort to explain it.
You should hire external folks with no attachment to the services to review these docs; they're generally very unhelpful.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f4325bb-f9f3-568d-6565-2e72ee3adbbd
Version Independent ID: 9054f791-a5a8-81e3-1e58-de866407242e
Content: Azure Key Vault Overview - Azure Key Vault
Content Source: articles/key-vault/general/overview.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@LukeCarrier Thanks for your question. We are checking on this and will respond to you soon.

@LukeCarrier, I apologize for the inconvenience caused. The Overview page do miss out on explaining the SKUs available for Key Vault. But you an find the SKU details on our official docs too. Please find them below:
https://azure.microsoft.com/en-in/pricing/details/key-vault/
Each Azure Service has a Product overview page that has a dedicated tab called pricing that lists the SKUs and the comparision.
Hope this helps.
We are closing this thread for now. Do let us know if any more queries around this so that we can re-open this thread for you again.

It’s disappointing that the ticket has been closed without even considering navigation changes.
Never mind, it’s your product and your customer experience.

@LukeCarrier, Please dont take this in a wrong way. I have already taken your feedback and I have already started an internal thread with the author regarding the same so that we can collate the SKU details in the overview page itself, so that in future customers doesnt face the same issue. I have reopened this thread again.

@souravmishra-msft it's frustrating, especially as someone that's tried to raise PRs against these docs in the past and was stonewalled for months until the change was no longer relevant because someone decided to just copy a bunch of irrelevant Windows documentation over the top of the page, to see issues get closed without the issue being addressed.
The documentation is difficult to navigate and search, and a lot of the content  assumes far too much prior knowledge. Instead of closing issues that raise problems like this without a resolution, it would be nice for there to be a discussion about possible improvements like almost every other project on GitHub.
This is representative of our experience with Azure as a whole -- a half-baked platform with a ton of bugs where defects just get lost in the system. If you don't want to improve, don't waste my time by soliciting feedback in the first place.


India

Team to review branch updates

HTML and CSS complete, FUSE.js installed, Handlebars templates finished


Failures on [vm] Fix deoptimization environment of AssertAssignable

There are new test failures on [vm] Fix deoptimization environment of AssertAssignable.
The tests
vm/dart_2/regress_45207_test RuntimeError (expected Pass)

are failing on configurations
dartk-optcounter-linux-release-ia32

That's a new regression test introduced in cd104ae.
/cc @mkustermann

vm/dart_2/regress_45207_test is currently passing on all configurations.


Dev branch fails with TF r1.4

ubuntu 16.04, python3.5, cuda9.0, cudnn7.0 nccl2, follow the installation and all is fine.
python3 -m basic.cli --mode train --noload --debug
fails..first on _linear
solution per issue 41
from tensorflow.contrib.rnn.python.ops.rnn_cell import _Linear
then there is a problem with flags. R1.4 handles argument parsing differently and adding components to config causes errors in the flag parsing as they are not declared as flags
and then change the call in the nn.py…but then I hit
File "/home/levinth/bi-att-flow/basic/cli.py", line 112, in
tf.app.run()
File "/home/levinth/tf_r1.4_c9_mpi_py3/tensorflow/python/platform/app.py", line 124, in run
_sys.exit(main(argv))
File "/home/levinth/bi-att-flow/basic/cli.py", line 107, in main
config.out_dir = os.path.join(config.out_base_dir, config.model_name, str(config.run_id).zfill(2))
File "/home/levinth/tf_r1.4_c9_mpi_py3/tensorflow/python/platform/flags.py", line 88, in setattr
return self.dict['__wrapped'].setattr(name, value)
File "/home/levinth/tf_r1.4_c9_mpi_py3/absl/flags/_flagvalues.py", line 496, in setattr
return self._set_unknown_flag(name, value)
File "/home/levinth/tf_r1.4_c9_mpi_py3/absl/flags/_flagvalues.py", line 374, in _set_unknown_flag
raise _exceptions.UnrecognizedFlagError(name, value)
absl.flags._exceptions.UnrecognizedFlagError: Unknown command line flag 'out_dir'
ultimately I added a lot of flags but was not sure what to do when a matrix was added to config.
After adding all these…
#flags added for R1.4?
flags.DEFINE_string("out_dir", "out", "out dir [out]")
flags.DEFINE_string("save_dir", "save", "save dir [save]")
flags.DEFINE_string("log_dir", "log", "log dir [log]")
flags.DEFINE_string("eval_dir", "eval", "eval dir [eval]")
flags.DEFINE_string("answer_dir", "answer", "answer dir [answer]")
flags.DEFINE_integer("max_num_sents", 0, "max_num_sents")
flags.DEFINE_integer("max_sent_size", 0, "max_sent_size")
flags.DEFINE_integer("max_ques_size", 0, "max_ques_size")
flags.DEFINE_integer("max_word_size", 0, "max_word_size")
flags.DEFINE_integer("max_para_size", 0, "max_para_size")
flags.DEFINE_integer("char_vocab_size", 0, "char_vocab_size")
flags.DEFINE_integer("word_emb_size", 0, "word_emb_size")
flags.DEFINE_integer("word_vocab_size", 0, "word_vocab_size")
I hit the issue that emb_mat is not a flag
emb_mat = np.array([idx2vec_dict[idx] if idx in idx2vec_dict
                    else np.random.multivariate_normal(np.zeros(config.word_emb_size), np.eye(config.word_emb_size))
                    for idx in range(config.word_vocab_size)])
config.emb_mat = emb_mat

Has there been any update on this issue? I'm trying to run train this (multi-GPU) on a DGX-1 (8xV100), this requires CUDA 9, which requires TF1.4.

Same issue here as well.

Andreas
When you ran this on R1.7..what did you do about _linear imported into
my/tensorflow/nn.py
there are 2 versions in
tensorflow/tensorflow/contrib/rnn/python/ops/rnn_cell.py
and one in
tensorflow/tensorflow/contrib/rnn/python/ops/core_rnn_cell.py
and none in any file in tensorflow/tensorflow/python/ops/
or did I miss something
On Mon, Apr 16, 2018 at 11:24 AM, Andreas Klintberg <
<EMAIL_ADDRESS>wrote:

Got it to run on TF 1.7 and Python 3.6 someone might think its helpful:
#89 https://github.com/allenai/bi-att-flow/pull/89 (dev branch pull
request)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-381702190,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuT0WazL1rkuG5NDPaZ-M1ed7eiJQWks5tpOHegaJpZM4RU7Ny
.

If I understand your question, no TF does not expose the _linear function anymore https://github.com/tensorflow/tensorflow/issues/561 .
Basically I actually added the linear functions and appropriate imports into the my/tensorflow/nn.py but you are right, the _linear is still available in TF 1.7 (in contrib) https://github.com/tensorflow/tensorflow/blob/1d76d3e7c7eecddee960c20c9896ccc43d7ccd5c/tensorflow/contrib/rnn/python/ops/core_rnn_cell.py so I guess a better solution is probably to just import that instead :)

is that the right one?
On Tue, Apr 17, 2018 at 11:31 AM, Andreas Klintberg <
<EMAIL_ADDRESS>wrote:

If I understand your question, no TF does not expose the _linear function
anymore tensorflow/tensorflow#561
https://github.com/tensorflow/tensorflow/issues/561 .
Basically I actually added the linear functions and appropriate imports
into the my/tensorflow/nn.py but you are right, the _linear is still
available in TF 1.7 (in contrib) https://github.com/tensorflow/
tensorflow/blob/1d76d3e7c7eecddee960c20c9896cc
c43d7ccd5c/tensorflow/contrib/rnn/python/ops/core_rnn_cell.py so I guess
a better solution is probably to just import that instead :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-382096071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuTxLGuAginw32VXo6wHRCQJE3OtGWks5tpjUOgaJpZM4RU7Ny
.

using the _linear in core_rnn_cell gets the imports to work..
but then I hit the original error in
https://github.com/allenai/bi-att-flow/issues/69
caused by
def main(_):
config = flags.FLAGS
config.out_dir = os.path.join(config.out_base_dir, config.model_name,

str(config.run_id).zfill(2))
upset that out_dir is not defined in flags..
how did you work around that issue?
d
On Tue, Apr 17, 2018 at 11:31 AM, Andreas Klintberg <
<EMAIL_ADDRESS>wrote:

If I understand your question, no TF does not expose the _linear function
anymore tensorflow/tensorflow#561
https://github.com/tensorflow/tensorflow/issues/561 .
Basically I actually added the linear functions and appropriate imports
into the my/tensorflow/nn.py but you are right, the _linear is still
available in TF 1.7 (in contrib) https://github.com/tensorflow/
tensorflow/blob/1d76d3e7c7eecddee960c20c9896cc
c43d7ccd5c/tensorflow/contrib/rnn/python/ops/core_rnn_cell.py so I guess
a better solution is probably to just import that instead :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-382096071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuTxLGuAginw32VXo6wHRCQJE3OtGWks5tpjUOgaJpZM4RU7Ny
.

Disclaimer: I'm just a happy hacker.
However looking at the code now the contrib package, only contains one implementation of the _linear from core_rnn_cell.py, so there is probably just one.
As to the "FLAGS" issue, all my changes is reflected here https://github.com/allenai/bi-att-flow/pull/89/files
But in summary added all missing Flags definition you initially did, but also added the flags.DEFINE_integer("emb_mat", 0, "embedding matrix") However, the default value 0 for the emb_mat is probably not correct :/ so I'm still hoping someone could comment on the value for that.
I trained on a train and dev set I created myself and got around 80% F1 score which seems plausible so  it doesn't seem to mess up anything major. I will try to do a training on the SQuAD set as well for comparison.

This is one of the only good question answer public source bases, so it is
an important component for the benchmark suite a lot of people (myself
included) are discussing.
Getting something that can be easily downloaded and run out of the box is
extremely important..
I wonder if it might be a good idea if you forked off the dev branch and
then applied your patches so we had something that could be run?
On Tue, Apr 17, 2018 at 1:10 PM, Andreas Klintberg<EMAIL_ADDRESS>
wrote:

Disclaimer: I'm just a happy hacker.
However looking at the code now the contrib package, only contains one
implementation of the _linear from core_rnn_cell.py, so there is probably
just one.
As to the "FLAGS" issue, all my changes is reflected here
https://github.com/allenai/bi-att-flow/pull/89/files
But in summary added all missing Flags definition you initially did, but
also added the flags.DEFINE_integer("emb_mat", 0, "embedding matrix")
However, the default value 0 for the emb_mat is probably not correct :/ so
I'm still hoping someone could comment on the value for that.
I trained on a train and dev set I created myself and got around 80% F1
score which seems plausible so it doesn't seem to mess up anything major. I
will try to do a training on the SQuAD set as well for comparison.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-382126153,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuT9XXQp2IXm5S8sLyKlycto6ejvg7ks5tpkxQgaJpZM4RU7Ny
.

yeah, I will try to run it this week and compare to the old repo results.
I forked and commited here https://github.com/klintan/bi-att-flow/tree/dev , let me know if you try it out and if you have any problems.

hey are you in linked in or some other way to email you?
are you interested in helping define a DNN benchmark suite?
d
On Tue, Apr 17, 2018 at 1:28 PM, Andreas Klintberg<EMAIL_ADDRESS>
wrote:

yeah, I will try to run it this week and compare to the old repo results.
I forked and commited here https://github.com/klintan/bi-att-flow/tree/dev
, let me know if you try it out and if you have any problems.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-382130958,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuT1uyvz1DYQm9zvUSsXnY_73X7Hziks5tplBQgaJpZM4RU7Ny
.

Andreas
One more question..
using your forked distro (out of the box)
python -m basic.cli
fails as it looks for out/basic/00/shared.json which does not exist
on the other hand
python -m basic.cli --mode train --noload --debug
seems to run
num params: 2695851
2018-04-17 14:58:16.177176: I
tensorflow/core/common_runtime/gpu/gpu_device.cc:1344] Found device 0 with
properties:
name: Tesla V100-PCIE-16GB major: 7 minor: 0 memoryClockRate(GHz): 1.38
pciBusID: 0000:04:00.0
totalMemory: 15.77GiB freeMemory: 15.35GiB
2018-04-17 14:58:16.177214: I
tensorflow/core/common_runtime/gpu/gpu_device.cc:1423] Adding visible gpu
devices: 0
2018-04-17 14:58:16.420130: I
tensorflow/core/common_runtime/gpu/gpu_device.cc:911] Device interconnect
StreamExecutor with strength 1 edge matrix:
2018-04-17 14:58:16.420176: I
tensorflow/core/common_runtime/gpu/gpu_device.cc:917]      0
2018-04-17 14:58:16.420182: I
tensorflow/core/common_runtime/gpu/gpu_device.cc:930] 0:   N
2018-04-17 14:58:16.420490: I
tensorflow/core/common_runtime/gpu/gpu_device.cc:1041] Created TensorFlow
device (/job:localhost/replica:0/task:0/device:GPU:0 with 14868 MB memory)
-> physical GPU (device: 0, name: Tesla V100-PCIE-16GB, pci bus id:
0000:04:00.0, compute capability: 7.0)
100%|\u2588       | 2/2 [00:28<00:00, 14.66s/it]
where was shared.json supposed to come from??
d
On Tue, Apr 17, 2018 at 1:29 PM, David Levinthal<EMAIL_ADDRESS>
wrote:

hey are you in linked in or some other way to email you?
are you interested in helping define a DNN benchmark suite?
d
On Tue, Apr 17, 2018 at 1:28 PM, Andreas Klintberg <
<EMAIL_ADDRESS>wrote:

yeah, I will try to run it this week and compare to the old repo results.
I forked and commited here https://github.com/klintan/bi-
att-flow/tree/dev , let me know if you try it out and if you have any
problems.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-382130958,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuT1uyvz1DYQm9zvUSsXnY_73X7Hziks5tplBQgaJpZM4RU7Ny
.

hi, I have been getting this when i run your branch of the code:
raise _exceptions.UnrecognizedFlagError(name, value)
absl.flags._exceptions.UnrecognizedFlagError: Unknown command line flag 'new_emb_mat'
What can i do to fix it

what branch are you running and what version of TF?
the error you mention is part of the original error report
On Sat, Apr 21, 2018 at 11:10 AM, slothie26<EMAIL_ADDRESS>wrote:

hi, I have been getting this when i run your branch of the code:
raise _exceptions.UnrecognizedFlagError(name, value)
absl.flags._exceptions.UnrecognizedFlagError: Unknown command line flag
'new_emb_mat'
What can i do to fix it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-383317468,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuT0eSSgyyZtfXHgJs8qyQBKYfLGhpks5tq3X_gaJpZM4RU7Ny
.

@slothie26 seems you edited you original question, however I think it might be if you try to use multiple gpus as mentioned here https://github.com/allenai/bi-att-flow/issues/54
If you restrict to one GPU it should work.

I was able to fix my original problem by including a flag define line in the cli. But I again got the ExponentialMovingAvergaeError which I cant seem to get rid off. i have tried so many versions of the project. I currently ran https://github.com/klintan/bi-att-flow/tree/dev using TensorFlow 1.7
I am not sending the number of GPUS.It is default set as 1. But the error still occurs. It would be great if you can help me with this..
Sharing the complete Error Report:
Loading saved model from save/37/save
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1327, in _do_call
return fn(*args)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1312, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1420, in _call_tf_sessionrun
status, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/framework/errors_impl.py", line 516, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: Tensor name "emb/char/conv/xx/conv1d_5/bias/ExponentialMovingAverage" not found in checkpoint files save/37/save
[[Node: save_1/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_INT32, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save_1/Const_0_0, save_1/RestoreV2/tensor_names, save_1/RestoreV2/shape_and_slices)]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 129, in
tf.app.run()
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 126, in run
_sys.exit(main(argv))
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 126, in main
m(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 29, in main
_forward(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 200, in _forward
graph_handler.initialize(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 25, in initialize
self._load(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 54, in _load
saver.restore(sess, save_path)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1775, in restore
{self.saver_def.filename_tensor_name: save_path})
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 905, in run
run_metadata_ptr)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1140, in _run
feed_dict_tensor, options, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1321, in _do_run
run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1340, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Tensor name "emb/char/conv/xx/conv1d_5/bias/ExponentialMovingAverage" not found in checkpoint files save/37/save
[[Node: save_1/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_INT32, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save_1/Const_0_0, save_1/RestoreV2/tensor_names, save_1/RestoreV2/shape_and_slices)]]
Caused by op 'save_1/RestoreV2', defined at:
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 129, in
tf.app.run()
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 126, in run
_sys.exit(main(argv))
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 126, in main
m(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 29, in main
_forward(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 200, in _forward
graph_handler.initialize(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 25, in initialize
self._load(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 42, in load
saver = tf.train.Saver(vars, max_to_keep=config.max_to_keep)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1311, in init
self.build()
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1320, in build
self._build(self._filename, build_save=True, build_restore=True)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1357, in _build
build_save=build_save, build_restore=build_restore)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 809, in _build_internal
restore_sequentially, reshape)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 448, in _AddRestoreOps
restore_sequentially)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 860, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/ops/gen_io_ops.py", line 1458, in restore_v2
shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3290, in create_op
op_def=op_def)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1654, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
NotFoundError (see above for traceback): Tensor name "emb/char/conv/xx/conv1d_5/bias/ExponentialMovingAverage" not found in checkpoint files save/37/save
[[Node: save_1/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_INT32, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save_1/Const_0_0, save_1/RestoreV2/tensor_names, save_1/RestoreV2/shape_and_slices)]]

@slothie26 are you running this command:
python -m basic.cli --mode train --noload --len_opt --cluster
?

No, I am trying to run the pretrained vectors. Running this command:
basic/run_single.sh $HOME/data/squad/dev-v1.1.json single.json

are you running this with an MKL build of TF?
https://github.com/allenai/bi-att-flow/issues/66
There seem to be a bunch of old issues about ExponentialMovingAverage
associated with reading the checkpoint file.
Both Andreas and I have been able to run this on single Nvidia GPUs without
modification on R1.7 (I build TF from source with a checkout to force R1.7)
What cuda/cudnn libraries and what OS are you using?
This really should be a separate issue
d
On Sat, Apr 21, 2018 at 9:13 PM, slothie26<EMAIL_ADDRESS>wrote:

I was able to fix my original problem by including a flag define line in
the cli. But I again got the ExponentialMovingAvergaeError which I cant
seem to get rid off. i have tried so many versions of the project. I
currently ran https://github.com/klintan/bi-att-flow/tree/dev using
TensorFlow 1.7
I am not sending the number of GPUS.It is default set as 1. But the error
still occurs. It would be great if you can help me with this..
Sharing the complete Error Report:
Loading saved model from save/37/save
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/client/session.py", line 1327,
in _do_call
return fn(*args)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/client/session.py", line 1312,
in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/client/session.py", line 1420,
in _call_tf_sessionrun
status, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/framework/errors_impl.py", line
516, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: Tensor name
"emb/char/conv/xx/conv1d_5/bias/ExponentialMovingAverage" not found in
checkpoint files save/37/save
[[Node: save_1/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT,
DT_FLOAT, DT_INT32, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT],
_device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save_1/Const_0_0,
save_1/RestoreV2/tensor_names, save_1/RestoreV2/shape_and_slices)]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py",
line 193, in _run_module_as_main
"main", mod_spec)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py",
line 85, in _run_code
exec(code, run_globals)
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 129, in
tf.app.run()
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/platform/app.py", line 126, in
run
_sys.exit(main(argv))
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 126, in main
m(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 29, in main
_forward(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 200, in _forward
graph_handler.initialize(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 25, in
initialize
self._load(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 54, in
_load
saver.restore(sess, save_path)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/training/saver.py", line 1775,
in restore
{self.saver_def.filename_tensor_name: save_path})
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/client/session.py", line 905,
in run
run_metadata_ptr)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/client/session.py", line 1140,
in _run
feed_dict_tensor, options, run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/client/session.py", line 1321,
in _do_run
run_metadata)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/client/session.py", line 1340,
in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Tensor name
"emb/char/conv/xx/conv1d_5/bias/ExponentialMovingAverage" not found in
checkpoint files save/37/save
[[Node: save_1/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT,
DT_FLOAT, DT_INT32, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT],
_device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save_1/Const_0_0,
save_1/RestoreV2/tensor_names, save_1/RestoreV2/shape_and_slices)]]
Caused by op 'save_1/RestoreV2', defined at:
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py",
line 193, in _run_module_as_main
"main", mod_spec)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py",
line 85, in _run_code
exec(code, run_globals)
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 129, in
tf.app.run()
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/platform/app.py", line 126, in
run
_sys.exit(main(argv))
File "/Users/vmalik2/bi-att-flow-dev/basic/cli.py", line 126, in main
m(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 29, in main
_forward(config)
File "/Users/vmalik2/bi-att-flow-dev/basic/main.py", line 200, in _forward
graph_handler.initialize(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 25, in
initialize
self._load(sess)
File "/Users/vmalik2/bi-att-flow-dev/basic/graph_handler.py", line 42, in
load saver = tf.train.Saver(vars, max_to_keep=config.max_to_keep)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/training/saver.py", line 1311,
in init
self.build()
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/training/saver.py", line 1320,
in build
self._build(self._filename, build_save=True, build_restore=True)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/training/saver.py", line 1357,
in _build
build_save=build_save, build_restore=build_restore)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/training/saver.py", line 809,
in _build_internal
restore_sequentially, reshape)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/training/saver.py", line 448,
in _AddRestoreOps
restore_sequentially)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/training/saver.py", line 860,
in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/ops/gen_io_ops.py", line 1458,
in restore_v2
shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/framework/op_def_library.py",
line 787, in _apply_op_helper
op_def=op_def)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/framework/ops.py", line 3290,
in create_op
op_def=op_def)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/
python3.6/site-packages/tensorflow/python/framework/ops.py", line 1654,
in init
self._traceback = self._graph._extract_stack() # pylint:
disable=protected-access
NotFoundError (see above for traceback): Tensor name
"emb/char/conv/xx/conv1d_5/bias/ExponentialMovingAverage" not found in
checkpoint files save/37/save
[[Node: save_1/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT,
DT_FLOAT, DT_INT32, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT],
_device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save_1/Const_0_0,
save_1/RestoreV2/tensor_names, save_1/RestoreV2/shape_and_slices)]]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/allenai/bi-att-flow/issues/69#issuecomment-383354076,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIUuT316hsR6-CgShw8-V4mqrdhflRNNks5trANygaJpZM4RU7Ny
.

Add a matrix to flags is really confusing. Can we just remove this flag?


I'm not able to build an image with TCP enabled

Description of the issue
Hi, I've tried enabling the TCP options in the OpenThreadConfig.h header file to test the TCP client application, but my image fails to build. It appears that a linking issue occurs in respect to the function definitions in tcp_api.cpp are missing from the final build. I've tried working backwards by checking the function definitions for the udp_api, but I haven't been able to figure out why those are included but tcp isn't. Is there something I'm missing?
Steps to reproduce the issue
1. Enable OPENTHREAD_CONFIG_TCP_ENABLE in OpenThreadConfig.h in lighting application.
2. Run build script.

Device type(s) and network topology
N/A
Note: I'm using release_1.0.0
Proposed solution(s)
No response
SMG version
release_0.4.0
Protocol(s)
Openthread
Hardware platform(s)
MG24 Explorer Kit, BRD4186C
Development platform(s)
No response
Captured data or logs
[20/27] arm-none-eabi-g++ -T../../../examples/lighting-app/efr32/third_party/connectedhomeip/examples/platform/efr32/ldscripts/efr32mg24.ld -march=armv8-m.main+dsp -mcpu=cortex-m33 -mabi=aapcs -mfpu=fpv5-sp-d16 -mfloat-abi=hard -mthumb -Og --specs=nosys.specs --specs=nano.specs -Werror -Wl,--fatal-warnings -fdiagnostics-color -Wl,--gc-sections -Wl,--wrap=malloc -Wl,--wrap=free -Wl,--wrap=realloc -Wl,--wrap=calloc -Wl,--wrap=MemoryAlloc -Wl,--wrap=_malloc_r -Wl,--wrap=_realloc_r -Wl,--wrap=_free_r -Wl,--wrap=_calloc_r -Wl,-Map,./chip-efr32-lighting-example.out.map @./chip-efr32-lighting-example.out.rsp -o ./chip-efr32-lighting-example.out
FAILED: chip-efr32-lighting-example.out chip-efr32-lighting-example.out.map
arm-none-eabi-g++ -T../../../examples/lighting-app/efr32/third_party/connectedhomeip/examples/platform/efr32/ldscripts/efr32mg24.ld -march=armv8-m.main+dsp -mcpu=cortex-m33 -mabi=aapcs -mfpu=fpv5-sp-d16 -mfloat-abi=hard -mthumb -Og --specs=nosys.specs --specs=nano.specs -Werror -Wl,--fatal-warnings -fdiagnostics-color -Wl,--gc-sections -Wl,--wrap=malloc -Wl,--wrap=free -Wl,--wrap=realloc -Wl,--wrap=calloc -Wl,--wrap=MemoryAlloc -Wl,--wrap=_malloc_r -Wl,--wrap=_realloc_r -Wl,--wrap=_free_r -Wl,--wrap=_calloc_r -Wl,-Map,./chip-efr32-lighting-example.out.map @./chip-efr32-lighting-example.out.rsp -o ./chip-efr32-lighting-example.out
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessInit(ot::Utils::CmdLineParser::Arg*)': /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:111: undefined reference to otTcpEndpointInitialize'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:122: undefined reference to otTcpListenerInitialize' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:125: undefined reference to otTcpEndpointDeinitialize'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessDeinit(ot::Utils::CmdLineParser::Arg*)': /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:145: undefined reference to otTcpEndpointDeinitialize'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:148: undefined reference to otTcpListenerDeinitialize' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessBind(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:169: undefined reference to otTcpBind' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessConnect(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:186: undefined reference to otTcpConnect' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessSend(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:208: undefined reference to otTcpSendByReference' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessBenchmark(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:248: undefined reference to otTcpSendByReference' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessSendEnd(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:268: undefined reference to otTcpSendEndOfStream' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessAbort(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:281: undefined reference to otTcpAbort' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessStopListening(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:313: undefined reference to otTcpStopListening' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::ProcessListen(ot::Utils::CmdLineParser::Arg*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:299: undefined reference to otTcpStopListening' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:300: undefined reference to otTcpListen'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpEstablishedCallback(otTcpEndpoint*)': /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:337: undefined reference to otTcpEndpointGetContext'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpSendDone(otTcpEndpoint*, otLinkedBuffer*)': /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:401: undefined reference to otTcpSendByReference'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpSendDoneCallback(otTcpEndpoint*, otLinkedBuffer*)': /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:342: undefined reference to otTcpEndpointGetContext'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpReceiveAvailable(otTcpEndpoint*, unsigned int, bool, unsigned int)': /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:433: undefined reference to otTcpReceiveByReference'
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:441: undefined reference to otTcpCommitReceive' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpReceiveAvailableCallback(otTcpEndpoint*, unsigned int, bool, unsigned int)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:350: undefined reference to otTcpEndpointGetContext' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpDisconnectedCallback(otTcpEndpoint*, otTcpDisconnectedReason)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:356: undefined reference to otTcpEndpointGetContext' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpAcceptReadyCallback(otTcpListener*, otSockAddr const*, otTcpEndpoint**)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:363: undefined reference to otTcpListenerGetContext' /media/lecontr1/Extension/workspace/silabs-v.1.0/matter/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/ot-efr32-cert.cli_tcp.cpp.o: in function ot::Cli::TcpExample::HandleTcpAcceptDoneCallback(otTcpListener*, otTcpEndpoint*, otSockAddr const*)':
/media/lecontr1/Extension/workspace/silabs-v.1.0/matter/out/lighting-app/BRD4186C/../../../examples/lighting-app/efr32/third_party/connectedhomeip/third_party/openthread/ot-efr32/openthread/src/cli/cli_tcp.cpp:371: undefined reference to `otTcpListenerGetContext'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Is there any way we can update the static libraries from OpenThread to include TCP? It seems like they only include the UDP library at the moment.

Hi @lecontr2 ,
Please note that TCP in Matter over Thread is currently not supported, hence why it is unavailable when you try to compile it into your project.
You can see this example here, where a stub API is all that exists.
Sincerely,


Dynamic Groups dont work for some players

Dynamic Groups still doesn't work for all players, even after respawn.

will be fixed with v0.9.0


Automatically create a pdf with simple rasterplots of all configs in a batch run

Can you elaborate? should this be shown in GUI? or it's a CxSystem feature that saves the PDF in the same folder of output data?

No need to show it in GUI, just create a PDF in the same output folder.


Feature/remove and load inv action

Description
Added the ability to remove and load a container, as a way to reset it.
This can be useful in cases where a container breaks in a way that can be fixed by removing it, then reloading it.
Also added the ability to add InventoryAction plugins by placing them in openpype/plugins/inventory.
Testing notes:

Merge or cherry-pick this into main production branch.
Open any asset with containers in the manage.
Right click on the container that should be reset and select Extra actions -> Remove and load.

Can @Tilix4 be added to reviewers please?

Did not test the plug-in, but code looks good to me.
Only thing I'm wondering if we'd want to play with ordering or coloring the action in such a way that it might not take precedence over other actions we might consider more important. Like should this have order = 99 set maybe?

That's a good idea. The color is the default, so the icon in the mange window appears as an orange cogwheel, which is consistent with the rest of the UI and will follow any change to the default value. Do you think it needs a specific color or does that seem fine to you?

It looks like this now:

I don't have problem with it.

Agree. Looks fine for now!


Always create runtime package if not using devel component

Header-only libraries don't have a runtime component, unless the devel component isn't being used (e.g. on Windows). If the devel component isn't being used, then the runtime component should always be packaged.

rocRAND is correct, AFAIK? It fixes rocPRIM, rocThrust, and hipCUB.


FltGetFileNameInformation: STATUS_FLT_INVALID_NAME_REQUEST and file system callbacks

FltGetFileNameInformation always returns STATUS_FLT_INVALID_NAME_REQUEST in post-operation callback routine for IRP_MJ_ACQUIRE_FOR_SECTION_SYNCHRONIZATION.
STATUS_FLT_INVALID_NAME_REQUEST is always returned (pre-/post- handlers) for other file system callbacks:

IRP_MJ_RELEASE_FOR_SECTION_SYNCHRONIZATION
IRP_MJ_ACQUIRE_FOR_MOD_WRITE
IRP_MJ_RELEASE_FOR_MOD_WRITE
IRP_MJ_ACQUIRE_FOR_CC_FLUSH
IRP_MJ_RELEASE_FOR_CC_FLUSH

This is described in FltGetFileNameInformationUnsafe, but not here.

… following types of circumstances, where querying the file system for name information can cause deadlocks:
…

In a preoperation callback routine (PFLT_PRE_OPERATION_CALLBACK) or a postoperation callback routine (PFLT_POST_OPERATION_CALLBACK) for any of the following operations:

IRP_MJ_ACQUIRE_FOR_CC_FLUSH
IRP_MJ_ACQUIRE_FOR_MOD_WRITE
IRP_MJ_RELEASE_FOR_CC_FLUSH
IRP_MJ_RELEASE_FOR_MOD_WRITE
IRP_MJ_RELEASE_FOR_SECTION_SYNCHRONIZATION

In a postoperation callback routine for IRP_MJ_ACQUIRE_FOR_SECTION_SYNCHRONIZATION.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82c69953-3606-33d2-1c71-fa25b72a82da
Version Independent ID: 67b78c7c-0fdc-ab17-d7d7-53a6b3eaded0
Content: FltGetFileNameInformation function
Content Source: wdk-ddi-src/content/fltkernel/nf-fltkernel-fltgetfilenameinformation.md
Product: windows-hardware
GitHub Login: @windows-driver-content
Microsoft Alias: windowsdriverdev

This is expected.  Acquire_for*  causes the FSD to set the IoTopLevelIrp and this is one of the things that causes FltGetFileNameInformation to complain.
Grabbing the name in pre and passing it as the context is your best bet.  Also the release works the other way around.
Finally - this sort of question is often better asked in here

(ignore me, I was warbling, you knew this - it wasn't a question, it was an observation).  I've deleted my unhelpful comment
I'd assume that CacheFlush does the same, FWIW

I just wanted this case (post-IRP_MJ_ACQUIRE_FOR_SECTION_SYNCHRONIZATION) to be described (like FltGetFileNameInformationUnsafe)

@kITerE , thanks for reporting this missing info! I have updated the page to include it.


Consider alpine/busybox base image

https://registry.hub.docker.com/_/alpine/
Though I'm not sure how much will actually be saved once Python2.7, build tools and libssl dependencies are installed, it might be worth considering.

:+1:

@tracker1 https://github.com/oren/alpine-node - only 22 MB

Perhaps run this binary against the test suite to make sure it passes?

@jbergstroem automated tests of our docker images is def on my roadmap. Just haven't had time. I'll open an issue for it though.

Just saying that the alpine stuff is pretty much bleeding edge (that alpine-node seems to pull the latest available from alpine). If this ends up being our recommended solution, it'd be great to back that statement up. Btw, I'm also really like the suggested approach of minimising the container size as long as we're very comfortable with the toolchain that leads us there.

@oren thanks, had considered doing the same... added issue suggesting the addition of pre-requisites for gyp...
@jbergstroem cool, I'd thought about just seeing which version was in apm and how well up to date the alpine image would be myself, hadn't taken the time.  Agreed on minimizing the size... even though it's not too bad, ubuntu and debian images are a bit bigger and if we can start off small, it is a great thing.

yup. tiny images are nice. Here is nginx in 6 MB - https://github.com/oren/alpine-nginx

100% agree with the direction this is going. I'll be glad to tackle this, but it might be a few weeks before I'm at a point where I can explore this area (my backlog is pretty long right now). If someone wants to kick off exploring this in the form of a PR to a new branch (maybe alpine?) we can start iterating on the idea. Thoughts?

( //CC: @pesho @Starefossen @hmalphettes @jlmitch5)

I also like this, and would welcome a PR adding it as a tag in this repo (possible tags: alpine, micro, or something else?)

IMO "alpine" would be the most self-descriptive tag :smile:

would welcome a PR adding it as a tag in this repo

A few points, before anyone starts working on such a PR:

The image shouldn't rely on an external package repository (as @oren's image does). A possible exception is, if this repository is also managed by the (at this point hypothetical) Docker WG, but that would be a pretty major change requiring further discussion.
The image should properly verify during build the GPG signatures of the downloaded binaries (assuming they are used at all), like the other variants do. I doubt the Alpine base image includes GnuPG, so it may need to be added, this increasing the image size (unless GnuPG is deleted before a layer is committed, of course).
The image should fit the current build process, so that version updates won't be complicated. The helper scripts would have to be updated.

If it's not possible to satisfy the above, I think the Alpine image should remain separate.

The source of the iojs package build is here: https://github.com/alpinelinux/aports/blob/master/testing/iojs/APKBUILD
The image 'alpine:edge' does not contain gnupg indeed; Note that gnupg is available as a supported package.

If we go down this route dont we need to provide the rest of the images: "iojs:alpine-slim", "iojs:alpine", "iojs:alpine-onbuild" ?
Starting from @oren's Dockerfile I have been testing Alpine to run some modules with native dependencies. @oren's image is a fine alternative to iojs:slim.
We would need a second fatter alpine image with the build tools to support this situation:
RUN apk update && \
  apk add --update iojs make g++ git gnupg python bash && rm -rf /var/cache/apk/*

That image weighs 203 MB to be compared with the 700 MB of the debian based iojs image.

What about having 2 images: 22 MB image for situations where native modules are not needed, and 700 MB for the other case.

@oren at the moment there are 3 images based off debian jessie

iojs:slim (just runtime no support for native dependencies) - 193 MB
iojs (with build tools) - 700 MB
iojs:onbuild (build tools and some extras for installing and running an app) - 700 MB

@oren could you specify the content of the 2 images you have in mind?

Good thing to have in mind: alpine runs on musl (at least when I last checked). Has anyone run the iojs test suite on such a docker image yet?

Both _mjones from #alpine-linux and myself run the test suite.
_mjones
environment
alpine edge on kvm full virtualisation.
results
7 tests fail, 828 tests pass. It looks like the failures are deliberate behaviour of musl libc (it doesn't support asserts). He will investigate it later.
Details here: http://paste.ubuntu.com/10710805/
Mine
environment
ubuntu + docker. Steps to reprouce my setup: https://github.com/oren/test-iojs-docker-alpine
results
I was not able to run the tests.
When I run make I get: http://paste.ubuntu.com/10710714
@hmalphettes you are correct about the number of images needed. It should match whatever we currently have.

@hmalphettes given the binary capable version is about the same size as the current slim, I'd say that's pretty nice.

@tracker1 agreed: it is very nice.

I second @pesho's comment on verifying binaries in order for this to become an official io.js image under the :alpine tag :smile:

:+1: on verification, and I would still like to see #46 be a prerequisite to shipping this if it gets that far.

Update: I am able to run the tests and get 4 errors. To reproduce it follow https://github.com/oren/test-iojs-docker-alpine
make -C out BUILDTYPE=Release V=1
make[1]: Entering directory '/tmp/iojs-v1.6.3/out'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/tmp/iojs-v1.6.3/out'
ln -fs out/Release/iojs iojs
/usr/bin/python tools/test.py --mode=release message parallel sequential -J
Path: parallel/test-cluster-http-pipe
events.js:141
      throw er; // Unhandled 'error' event
            ^
Error: read EACCES
    at exports._errnoException (util.js:749:11)
    at Pipe.onread (net.js:538:26)

assert.js:88
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at process.<anonymous> (/tmp/iojs-v1.6.3/test/parallel/test-cluster-http-pipe.js:22:5)
    at emitOne (events.js:82:20)
    at process.emit (events.js:166:7)
    at process.exit (node.js:659:17)
    at Worker.<anonymous> (/tmp/iojs-v1.6.3/test/parallel/test-cluster-http-pipe.js:19:13)
    at emitTwo (events.js:87:13)
    at Worker.emit (events.js:169:7)
    at ChildProcess.<anonymous> (cluster.js:351:14)
    at ChildProcess.g (events.js:257:16)
    at emitTwo (events.js:87:13)
Command: out/Release/iojs /tmp/iojs-v1.6.3/test/parallel/test-cluster-http-pipe.js
Path: parallel/test-http-client-pipe-end
events.js:141
      throw er; // Unhandled 'error' event
            ^
Error: read EACCES
    at exports._errnoException (util.js:749:11)
    at Pipe.onread (net.js:538:26)
Command: out/Release/iojs /tmp/iojs-v1.6.3/test/parallel/test-http-client-pipe-end.js
Path: parallel/test-http-client-response-domain
assert.js:88
  throw new assert.AssertionError({
        ^
AssertionError: 'should be caught by domain' == 'read EACCES'
    at Domain.<anonymous> (/tmp/iojs-v1.6.3/test/parallel/test-http-client-response-domain.js:29:12)
    at emitOne (events.js:77:13)
    at Domain.emit (events.js:166:7)
    at ClientRequest.emit (events.js:139:14)
    at Socket.socketErrorListener (_http_client.js:254:9)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:166:7)
    at net.js:438:14
    at process._tickDomainCallback (node.js:366:13)
Command: out/Release/iojs /tmp/iojs-v1.6.3/test/parallel/test-http-client-response-domain.js
Path: parallel/test-http-unix-socket
Error: read EACCES
    at exports._errnoException (util.js:749:11)
    at Pipe.onread (net.js:538:26)
assert.js:88
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at process.<anonymous> (/tmp/iojs-v1.6.3/test/parallel/test-http-unix-socket.js:63:10)
    at emitOne (events.js:82:20)
    at process.emit (events.js:166:7)
    at process.exit (node.js:659:17)
    at ClientRequest.<anonymous> (/tmp/iojs-v1.6.3/test/parallel/test-http-unix-socket.js:55:13)
    at emitOne (events.js:77:13)
    at ClientRequest.emit (events.js:166:7)
    at Socket.socketErrorListener (_http_client.js:254:9)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:166:7)
Command: out/Release/iojs /tmp/iojs-v1.6.3/test/parallel/test-http-unix-socket.js
Path: parallel/test-module-loading-error
util.debug: Use console.error instead
DEBUG: load test-module-loading-error.js

assert.js:88
  throw new assert.AssertionError({
        ^
AssertionError: -1 != -1
    at Object.<anonymous> (/tmp/iojs-v1.6.3/test/parallel/test-module-loading-error.js:22:10)
    at Module._compile (module.js:410:26)
    at Object.Module._extensions..js (module.js:428:10)
    at Module.load (module.js:335:32)
    at Function.Module._load (module.js:290:12)
    at Function.Module.runMain (module.js:451:10)
    at startup (node.js:123:18)
    at node.js:867:3
Command: out/Release/iojs /tmp/iojs-v1.6.3/test/parallel/test-module-loading-error.js
Makefile:76: recipe for target 'test' failed

FWIW, I've been using io.js on my Alpine Docker image for a while now (only 24.6 MB!) – there are only two failing tests on my stack, due to assumptions in the tests themselves.
One test (test-module-loading-error.js) is loading an already-built native linux module, which I assume is built with glibc because it fails with "Exec format error" – native modules work fine on Alpine if they're compiled using musl (which npm/node-gyp will do during an npm install) – so I think the test scope here is too narrow. The test shouldn't just check for linux, but also for glibc – and perhaps have another option for musl-based linux distros.
The other test (test-setproctitle.js) is failing because it's trying to run ps with a -p command line, which isn't supported on the Alpine version of ps – so I'd argue that the test should be changed with that in mind.
So apart from those minor test issues, it runs fine. You can check it out here:
https://registry.hub.docker.com/u/mhart/alpine-iojs/

:+1:

Sorry for jumping in mid-stream here and not fully groking the entirety of this thread but I think @jbergstroem's point about testing needs to be expanded on: when @iojs/docker is considering releasing images based on specific platforms like this it would be great if we could take a more coordinated approach to the issue of platform support. If you go ahead and push an Alpine Linux based image while this distro is not part of our CI suite for io.js you're creating a gap in our understanding of what it means for it to be supported.
I'd suggest that if you're set on doing this then @iojs/docker and @iojs/build find some way to integrate testing into regular CI such that we can be clearer about it being a supported platform, both in the current state of io.js and as it evolves over time. I don't know enough (anything?) about this distro so can't suggest a way forward but would love to help explore this. Perhaps something like build-containers for this if it's a container-focused distro?

@rvagg I can commit to having a CI figured out for the iojs docker images by end of June.

In this presentation redbeard makes the case that we should build our iojs/nodejs containers from scratch instead of relying on a general purpose distro: https://www.youtube.com/watch?v=gMpldbcMHuI

Yes, or we can take this approach by @rmg.

@hmalphettes Highly interesting talk, thanks for the link :-)!
Basically, I agree with you, but… I think the solution can not be that every developer who wants to run Node.js using Docker has to build her or his own container. We need a really small and reliable official base image. Of course, this can be built using the techniques shown in the video, but it should be done once, not over and over again, shouldn't it?

@Starefossen good point: build-container and runtime-container.
For my daily work I use the full iojs for builds and then copy the application and its node_modules into iojs-slim for the runtime.
Those techniques add-up: the smaller the runtime container iojs provides and the smaller my application's runtime container will be.
@goloroden yes agreed. What I understood from the talk is that nodejs/iojs team here provides a "built from scratch" set of images. Downstream users of those images add their application: just like what we do today.
I thought it was interesting to bring in the fact that we can choose buildroot or something else as an alternative to alpine linux if it helps.
For example we can choose gcc with buildroot if alpinelinux's musl libc is problematic.

@Starefossen and friends: if we want to build iojs on the top of alpinelinux would this type of Dockerfile be acceptable: https://github.com/mhart/alpine-node/blob/master/Dockerfile?

@hmalphettes @mhart is actually involved in this thread ;-)
https://github.com/nodejs/docker-iojs/issues/44#issuecomment-95969892
The blocker is testing which is being talked about in these threads:

https://github.com/nodejs/docker-iojs/issues/46
https://github.com/nodejs/docker-iojs/issues/77

Once we get testing figured out, we can take it to the @nodejs/build team to get signed off on it being a supported platform as rvagg said in: https://github.com/nodejs/docker-iojs/issues/44#issuecomment-96114656

Yeah, so FWIW we've been running the Uniqlo US Mobile site on alpine-iojs in production for at least 6 months now with no problems (on 2.5.0 atm, haven't moved to 3.0.0 yet)
I'm more than happy for ppl to use the image and/or the Dockerfile for whatever they'd like (and the license in the project should cover that).
I try to keep it up to date as soon as new node/io.js releases come out, but given its current lack of automated testing, etc, it's probably not a good candidate to be officially sanctioned in any way. At least, as it stands right now.

@Starefossen thanks for the mention :-)
writes a long comment, reads thread, deletes comment because everything had already been said
:+1:

Thanks for the image
Something is not right with compiled modules, for example (runtime,  npm install seems ok except few warnings):
Error: Error loading shared library /usr/src/app/node_modules/twelve/node_modules/bson/build/Release/bson.node: Exec format error]

@mkrn did you mean to post that as a new issue? Or is it related to this discussion about using alpine linux as a base image?

Nevermind please @rmg   I think node_modules were copying from my machine until i've added them to .dockerignore
Thanks for the image!

@mhart installing procps adds support for ps -p as suggested by @oren here: https://github.com/oren/test-iojs-docker-alpine/commit/72f6f35a3e69483584de2651a251ae0d88d7e099
There are 3 failing tests for v5.0.0:

test-module-loading-error.js fails as reported above already. The error message is Exec format error which makes sense for an invalid node life. Note that if we compile it with --fully-static then we get the error message: Dynamic loading not supported
test-net-better-error-messages-port-hostname.js returns an EAI_AGAIN instead of the expected ENOTFOUND. I am not enough of an expert to declare how critical that is.
The last one only happened when executing via the Dockerfile. It does not happen when I execute the tests on an interactive shell. Maybe that is in fact expected behavior?

/node-v5.0.0/test/parallel/test-stdout-close-unref.js:8
process.stdin._handle.close();
                     ^
TypeError: Cannot read property 'close' of undefined

@hmalphettes Were you able to solve Dynamic loading not supported? I am using a node package running process.dlopen() that is throwing this error on an Alpine container.

@polarathene that probably means you're using a statically compiled node.js binary? Which Alpine container (and tag) are you using?

@mhart I'm using smebberson/alpine-nodejs from this repo. They have a base alpine image and several examples extending it, once I get this working without errors I'll be using the docker images that include consul from the repo.
You're correct about them using a static compiled node.js binary I think, here is the Dockerfile for the image I'm using. How would I go about fixing this, and is there any drawbacks involved? If it's just compile time perhaps I could send a PR for a variant or replacement of the current Dockerfile.

Yep, they're definitely statically compiling: https://github.com/smebberson/docker-alpine/blob/master/alpine-nodejs/Dockerfile#L9
You could use another image that doesn't statically compile. I have a bunch of them over here: https://github.com/mhart/alpine-node
So you could use mhart/alpine-node:6 or mhart/alpine-node:5 or mhart/alpine-node:4 or whatever you'd like.
Or if you want to continue using the image you're currently using, you could just remove the --fully-static flag and build it yourself.

I've created an issue on their repo letting them know about it, until then I'll give your images a go :)
Thanks for the help, I looked into advantages/disadvantages of using dynamic linking instead of a static linking here, any idea if performance/memory is affected much with Node when built with dynamic linking?


chore: rename makeAuthRequest to makeAuthRequestToken

Description

fixes #1419

Codecov Report

Merging #1442 (8efd993) into master (3a1df3c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
+ Coverage   63.76%   63.79%   +0.02%
==========================================
  Files         116      116
  Lines        8500     8506       +6
  Branches     1895     1895
==========================================
+ Hits         5420     5426       +6
  Misses       2823     2823
  Partials      257      257

Impacted Files
Coverage Δ

packages/auth/src/index.ts
100.00% <100.00%> (ø)

packages/auth/src/messages.ts
83.09% <100.00%> (+0.24%)
:arrow_up:

packages/auth/src/userSession.ts
54.10% <100.00%> (+0.31%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


404 at /en/latest/use/ambassador_pattern_linking/

URL: /en/latest/use/ambassador_pattern_linking/

I can't find any link like that in the Docker docs. The closest I can find is: https://docs.docker.com/engine/admin/ambassador_pattern_linking/
Please post the page where you saw the link that failed for you.

Closing due to lack of info.


very slow opening file after updated atom

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed: https://github.com/icetee/remote-ftp/issues

Description
Before atom update:
immediately open file
After atom update:
more than 30sec
already try other ftp server/other pc/reinstall atom / remote-ftp
Steps to Reproduce
https://cl.ly/5bba633f9459
Versions
Atom    : 1.39.1
Electron: 3.1.10
Chrome  : 66.0.3359.181
Node    : 10.2.0

Same observation here.
Already checked other FTP-Settings and Server-Settings. The issue startet with the atom update to 1.39.1

Are you using Linux?
https://github.com/atom/atom/releases/tag/v1.39.1

I was reproduced on windows

Are you using Linux?

I'm running atom on Windows 10 - FTP-Servers are all Linux (Ubuntu/Debian).

Are you using Linux?
https://github.com/atom/atom/releases/tag/v1.39.1

windows 10
I try reinstall old atom version.
It work perfectly

@david43 Which version are you on now? v1.39.0?

@david43 Which version are you on now? v1.39.0?

1.38.2

Same symptoms.
OS : windows 10
ATOM : 1.39.1
FTP Servers : Linux
VSCODE is being used temporarily because of this symptom.
Thank U.

Same here on macOS

On mac OS Mojave also opens files via FTP for a very long time - it is not possible to work! ((
ATOM : 1.39.1

Same observation, the lag is due to downloading the file from FTP and not the opener itself.
MacOS Mojave, Latest Atom

same problem on Atom:V1.39.1
Windows 10
FTP Server : Linux

Same problem, started from Atom 1.39.0
OS: Windows 10

For me same too after update to atom 1.39.1

Same problem after updating to Atom 1.39.1
OS: MacOS Mojave

Anything we casn do to help with that bug?

Temporary exit from the situation: connect via SFTP.
Windows 10
Atom 1.39.1

Just updated to Atom 1.4.0 on Mac and it's still the same.
It must be something that's changed since 1.3.8

If you can use SFTP it works perfectly, for me on Mac.
Just lost the logs in atom.

Has anyone found a solution for this problem?

problem on Atom: v1.40.1
MacOS Mojave 10.14.6(18G87)
FTP Server : Linux
"SFTP" work perfectly same version

A very long download opening FTP files.
Reinstalling the atom and the plugin did not help. In version atom 1.38.2, everything works well. The problem is in version 1.40.1.
ubuntu 19.04
atom 1.40.1 x 64

Weird thing is, while having this issue in Atom I am exploring VScode with SFTP extension and i get the same results! Also slow when trying to open files just like in Atom

same here. take ages to load a file from remote ftp.
1.40.1 x64
macOS 10.13.6
works fine with atom 1.38.2 again (thanks for the info!).

OS: Ubuntu 19.10
Atom: 1.40.1
FTP Server: Linux
Upload works instantly (fast as expected).
Download works fast too (watch the folders) but the closing of the transfer/connection takes ages. The file only gets shown once the transfer is done and the connection is closed.

Same here:
Ubuntu 19.04
Atom 1.41.0
remote-ftp 2.2.2
Very long opening files
...
Also tried to use ftp-remote-edit plugin and it works fine as expected.
...
Downgrading to 1.38

I think resolved the new remote-ftp version (v2.2.3). Can you check?

Works for me now.
remote-ftp: 2.2.3
OS: Ubuntu 19.10
Atom: 1.42.0

I confirm: works fine now.