LSP: publishDiagnostics call resets data

Test sample:
class Hello
    def something(x)

    end
end

def main
    puts Helo.new
end

Protocol trace:
From IDE:
{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///home/user/RubymineProjects/untitled57/test.rb","languageId":"ruby","version":157,"text":"class Hello\n    def something(x)\n\n    end\nend\n\ndef main\n    puts Helo.new\nend"}}}

From server:
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/user/RubymineProjects/untitled57/test.rb","diagnostics":[{"range":{"start":{"line":7,"character":9},"end":{"line":7,"character":13}},"severity":1,"code":5002,"message":"Unable to resolve constant `Helo`","relatedInformation":[{"location":{"uri":"https://github.com/sorbet/sorbet/tree/master/rbi/stdlib/gem.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":10}}},"message":"Did you mean: `Gem`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/master/rbi/core/file.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":15}}},"message":"Did you mean: `File`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/master/rbi/core/hash.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":19}}},"message":"Did you mean: `Hash`?"},{"location":{"uri":"https://srb.help/5002","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]}]}}

{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/user/RubymineProjects/untitled57/test.rb","diagnostics":[]}}

The second request resets diagnostic data in the client.
server was built from tonight's master

Hi Alexandr, can you share the entire trace?
AFAIK Sorbet never sends to replies for the same file for a single didOpen call thus this seems surprising for me. We also don't observe this issue with VSCode

You can also observe the complete LSP log in browser console in https://sorbet.run/
Here is a complete log for this snippet, with my annotations in #
# initialization handshake
client.ts:166 Read: {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"rootPath":null,"rootUri":null,"capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true},"didChangeConfiguration":{"dynamicRegistration":true},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"executeCommand":{"dynamicRegistration":true},"workspaceFolders":true},"textDocument":{"publishDiagnostics":{"relatedInformation":true},"synchronization":{"dynamicRegistration":true,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":true,"contextSupport":true,"completionItem":{"snippetSupport":true,"commitCharactersSupport":true,"documentationFormat":["markdown","plaintext"],"deprecatedSupport":true,"preselectSupport":true},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]}},"hover":{"dynamicRegistration":true,"contentFormat":["markdown","plaintext"]},"signatureHelp":{"dynamicRegistration":true,"signatureInformation":{"documentationFormat":["markdown","plaintext"]}},"definition":{"dynamicRegistration":true},"references":{"dynamicRegistration":true},"documentHighlight":{"dynamicRegistration":true},"documentSymbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"hierarchicalDocumentSymbolSupport":true},"codeAction":{"dynamicRegistration":true,"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"codeLens":{"dynamicRegistration":true},"formatting":{"dynamicRegistration":true},"rangeFormatting":{"dynamicRegistration":true},"onTypeFormatting":{"dynamicRegistration":true},"rename":{"dynamicRegistration":true},"documentLink":{"dynamicRegistration":true},"typeDefinition":{"dynamicRegistration":true},"implementation":{"dynamicRegistration":true},"colorProvider":{"dynamicRegistration":true},"foldingRange":{"dynamicRegistration":true,"rangeLimit":5000,"lineFoldingOnly":true}}},"trace":"off","workspaceFolders":null}}
client.ts:161 Write: {"jsonrpc":"2.0","id":0,"requestMethod":"initialize","result":{"capabilities":{"textDocumentSync":1,"hoverProvider":true,"completionProvider":{"triggerCharacters":["."]},"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"referencesProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true}}}
client.ts:166 Read: {"jsonrpc":"2.0","method":"initialized","params":{}}
# default snippet in https://sorbet.run/
client.ts:166 Read: {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"inmemory://model/default","languageId":"ruby","version":1,"text":"# typed: true\nclass A\n  extend T::Sig\n\n  sig {params(x: Integer).returns(String)}\n  def bar(x)\n    x.to_s\n  end\nend\n\ndef main\n  A.new.barr(91)   # error: Typo!\n  A.new.bar(\"91\")  # error: Type mismatch!\nend"}}}
client.ts:161 Write: {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"inmemory://model/default","diagnostics":[{"range":{"start":{"line":11,"character":2},"end":{"line":11,"character":16}},"severity":1,"code":7003,"message":"Method `barr` does not exist on `A`","relatedInformation":[{"location":{"uri":"inmemory://model/default","range":{"start":{"line":5,"character":2},"end":{"line":5,"character":12}}},"message":"Did you mean: `A#bar`?"},{"location":{"uri":"https://srb.help/7003","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]},{"range":{"start":{"line":12,"character":2},"end":{"line":12,"character":17}},"severity":1,"code":7002,"message":"Expected `Integer` but found `String(\"91\")` for argument `x`","relatedInformation":[{"location":{"uri":"inmemory://model/default","range":{"start":{"line":4,"character":14},"end":{"line":4,"character":15}}},"message":"Method `A#bar` has specified `x` as `Integer`"},{"location":{"uri":"inmemory://model/default","range":{"start":{"line":12,"character":12},"end":{"line":12,"character":16}}},"message":"Got String(\"91\") originating from:"},{"location":{"uri":"https://srb.help/7002","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]}]}}
# My mouse travels around in order to paste your example from buffer
client.ts:166 Read: {"jsonrpc":"2.0","id":1,"method":"textDocument/hover","params":{"textDocument":{"uri":"inmemory://model/default"},"position":{"line":10,"character":1}}}
client.ts:161 Write: {"jsonrpc":"2.0","id":1,"requestMethod":"textDocument/hover","result":{"contents":{"kind":"markdown","value":"```ruby\nsig {returns(T.untyped)}\n```"}}}
# I actually paste the example from this issue
client.ts:166 Read: {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"inmemory://model/default","version":2},"contentChanges":[{"text":"# typed: true\nclass Hello\n    def something(x)\n\n    end\nend\n\ndef main\n    puts Helo.new\nend"}]}}
client.ts:161 Write: {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"inmemory://model/default","diagnostics":[{"range":{"start":{"line":8,"character":9},"end":{"line":8,"character":13}},"severity":1,"code":5002,"message":"Unable to resolve constant `Helo`","relatedInformation":[{"location":{"uri":"https://github.com/sorbet/sorbet/tree/beecfbcc014c33282ea65f03a61fbb74535a5435/rbi/stdlib/gem.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":10}}},"message":"Did you mean: `Gem`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/beecfbcc014c33282ea65f03a61fbb74535a5435/rbi/core/file.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":15}}},"message":"Did you mean: `File`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/beecfbcc014c33282ea65f03a61fbb74535a5435/rbi/core/hash.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":19}}},"message":"Did you mean: `Hash`?"},{"location":{"uri":"https://srb.help/5002","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]}]}}

As you see, there is no second textDocument/publishDiagnostics from Sorbet. In order to trigger a second one, there has to be a request from client.

Is it possible to start an lsp server with protocol logging?
Here is the full trace I can see in my logs:
{"jsonrpc":"2.0","id":"1","method":"initialize","params":{"processId":null,"rootPath":"/home/user/RubymineProjects/untitled57","rootUri":"file:///home/user/RubymineProjects/untitled57","capabilities":{"workspace":{"applyEdit":false,"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","delete","rename"],"failureHandling":"transactional"},"didChangeConfiguration":{"dynamicRegistration":false},"didChangeWatchedFiles":{"dynamicRegistration":false},"symbol":{"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"dynamicRegistration":false},"executeCommand":{"dynamicRegistration":false},"workspaceFolders":true,"configuration":false},"textDocument":{"synchronization":{"willSave":false,"willSaveWaitUntil":false,"didSave":false,"dynamicRegistration":true},"completion":{"completionItem":{"snippetSupport":false,"commitCharactersSupport":false,"documentationFormat":["plaintext"],"deprecatedSupport":false,"preselectSupport":false},"completionItemKind":{},"dynamicRegistration":true},"hover":{"contentFormat":["plaintext"],"dynamicRegistration":false},"signatureHelp":{"signatureInformation":{"documentationFormat":["plaintext"],"parameterInformation":{"labelOffsetSupport":false}},"dynamicRegistration":false},"references":{"dynamicRegistration":false},"documentHighlight":{"dynamicRegistration":false},"documentSymbol":{"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"hierarchicalDocumentSymbolSupport":false,"dynamicRegistration":false},"formatting":{"dynamicRegistration":false},"rangeFormatting":{"dynamicRegistration":false},"onTypeFormatting":{"dynamicRegistration":false},"declaration":{"linkSupport":false,"dynamicRegistration":false},"definition":{"linkSupport":false,"dynamicRegistration":false},"typeDefinition":{"linkSupport":false,"dynamicRegistration":false},"implementation":{"linkSupport":false,"dynamicRegistration":false},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","source","source.organizeImports","refactor.rewrite"]}},"dynamicRegistration":false},"codeLens":{"dynamicRegistration":false},"documentLink":{"dynamicRegistration":false},"colorProvider":{"dynamicRegistration":false},"rename":{"prepareSupport":false,"dynamicRegistration":false},"publishDiagnostics":{"relatedInformation":false},"foldingRange":{"rangeLimit":2147483647,"lineFoldingOnly":false,"dynamicRegistration":false}}}}}

{"jsonrpc":"2.0","id":"1","requestMethod":"initialize","result":{"capabilities":{"textDocumentSync":1,"hoverProvider":true,"completionProvider":{"triggerCharacters":["."]},"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"referencesProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true}}}

{"jsonrpc":"2.0","method":"initialized","params":{}}

{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///home/user/RubymineProjects/untitled57/test.rb","languageId":"ruby","version":157,"text":"class Hello\n    def something(x)\n\n    end\nend\n\ndef main\n    puts Helo.new\nend"}}}

{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/user/RubymineProjects/untitled57/test.rb","diagnostics":[{"range":{"start":{"line":7,"character":9},"end":{"line":7,"character":13}},"severity":1,"code":5002,"message":"Unable to resolve constant `Helo`","relatedInformation":[{"location":{"uri":"https://github.com/sorbet/sorbet/tree/master/rbi/stdlib/gem.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":10}}},"message":"Did you mean: `Gem`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/master/rbi/core/file.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":15}}},"message":"Did you mean: `File`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/master/rbi/core/hash.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":19}}},"message":"Did you mean: `Hash`?"},{"location":{"uri":"https://srb.help/5002","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]}]}}

{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/user/RubymineProjects/untitled57/test.rb","diagnostics":[]}}

Additionally, i've changed document (changed Helo to Hello) and didn't get new diagnostics
{"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"version":231,"uri":"file:///home/user/RubymineProjects/untitled57/test.rb"},"contentChanges":[{"range":{"start":{"line":7,"character":12},"end":{"line":7,"character":12}},"rangeLength":0,"text":"class Hello\n    def something(x)\n\n    end\nend\n\ndef main\n    puts Hello.new\nend\n\n\n"}]}}

And nothing from server side.
here is the command used to run:
sorbet --lsp --dir /home/user/RubymineProjects/untitled57 --disable-watchman --enable-all-experimental-lsp-features --silence-dev-message
Btw, why do I need to provide a dir when starting server? Shouldn't root be set up with initialization?

Is it possible to start an lsp server with protocol logging?

pass -vv for verbose

Btw, why do I need to provide a dir when starting server? Shouldn't root be set up with initialization?

No good reason externally. Stripe runs Sorbet on a different machine from one that runs IDE and they talk over network.

@hurricup The file you're opening is not typed, so Sorbet won't report errors.
See on Sorbet.run:
class Hello
    def something(x)

    end
end

def main
    puts Helo.new
end

I suspect what's happening is the following:

When Sorbet initializes, it reads the contents of /home/user/RubymineProjects/untitled57, which contains a test.rb with # typed: true. It discovers a type error, and reports it to the editor.
Sorbet processes the didOpen, which lacks the type sigil, and the file no longer has errors.

I don't believe this is a bug, so I'm closing this thread. Feel free to reopen if I'm wrong!

Actually, I'm reopening; I realized that CLI Sorbet reports errors, so my hunch was incorrect. 🤦♂

Adding # typed: false fixes the issue, but we should probably treat the file as if it's implicitly # typed: false:

I see. I'll try this tomorrow. Thanks

Is missing of diagnostic on document change the same story?

@jvilk-stripe I'm still unable to reproduce. if you open
https://sorbet.run/#class Hello
    def something(x)

    end
end

def main
    puts Helo.new
end
there's a single textDocument/publishDiagnostics
AFAIK there's no code between LSP and normal pass that could have treated this file differently.
Are you sure your story is what is happening?

Adding # typed: false fixes the issue, but we should probably treat the file as if it's implicitly # typed: false.

This is what Sorbet does by default and has been doing since introduction of typed sigils

@DarkDimius Look at your link again. CLI reports the error (on right), LSP (on left) does not. There's no squiggle.
There's a difference in behavior between what LSP does during initialization (when it first reads the files from disk) and what it does to process changes (when didOpen happens). During initialization, LSP reports the same error as the CLI. Once didOpen happens, though, it no longer reports errors for the file.

Is missing of diagnostic on document change the same story?

Yes, it's the same issue. During initialization (when Sorbet reads things from disk), it reports the error. But once it's open in the editor, it stops reporting the error.
It all comes down to the missing typed sigil. This is a bug in Sorbet that we should fix.

@jvilk-stripe

@DarkDimius Look at your link again. CLI reports the error (on right), LSP (on left) does not. There's no squiggle.

There's a difference in behavior between what LSP does during initialization (when it first reads the files from disk) and what it does to process changes (when didOpen happens). During initialization, LSP reports the same error as the CLI. Once didOpen happens, though, it no longer reports errors for the file.

I think we disagree.
This is specifically a quirk of sorbet.run. It actually runs sorbet twice. Once by running LSP, once, by running with -e
https://github.com/sorbet/sorbet/blob/7bbc8c652d4c1ea044d01d59778beea3a5627fb1/emscripten/main.cc#L16
Note that we force -e to typed: true if it doesn't have a sigil:
https://github.com/sorbet/sorbet/blob/7bbc8c652d4c1ea044d01d59778beea3a5627fb1/main/realmain.cc#L393-L396

During initialization, LSP reports the same error as the CLI.

AFAIK this isn't true, see above & message log from communication

IRL'd with @jvilk-stripe and indeed, there's a bug. He was right. I think we have both effects, we have the fact that sorbet.run forces stuff into typed: true mode for right pane and we have a bug.
[T12476287][2019-07-03T11:39:25.554276] Read: {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"textDocument":{"colorProvider":null,"completion":{"completionItem":{"snippetSupport":false}},"signatureHelp":{"signatureInformation":{"parameterInformation":{"labelOffsetSupport":true}}}},"workspace":{"applyEdit":true,"didChangeWatchedFiles":{"dynamicRegistration":true}}},"initializationOptions":{"cacheDirectory":"/tmp/cquery","completion":{"filterAndSort":false}},"processId":70687,"rootPath":"/Users/dmitry/.empty","rootUri":"file:///Users/dmitry/.empty","trace":"off"},"id":1}
[T12476275][2019-07-03T11:39:25.557297] Write: {"jsonrpc":"2.0","id":1,"requestMethod":"initialize","result":{"capabilities":{"textDocumentSync":1,"hoverProvider":true,"completionProvider":{"triggerCharacters":["."]},"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"referencesProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true}}}
[T12476287][2019-07-03T11:39:25.559594] Read: {"jsonrpc":"2.0","method":"initialized","params":{}}
[T12476287][2019-07-03T11:39:25.561689] Read: {"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"initializationOptions":{"cacheDirectory":"/tmp/cquery","completion":{"filterAndSort":false}}}}}
[T12476287][2019-07-03T11:39:25.564715] Read: {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"ruby","text":"# typed: true\n\n1 + \"s\"\n","uri":"file:///Users/dmitry/.empty/a.rb","version":0}}}
[T12476275][2019-07-03T11:39:25.629629] Write: {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///Users/dmitry/.empty/a.rb","diagnostics":[{"range":{"start":{"line":2,"character":0},"end":{"line":2,"character":7}},"severity":1,"code":7002,"message":"Expected `Integer` but found `String(\"s\")` for argument `arg0`","relatedInformation":[{"location":{"uri":"https://github.com/sorbet/sorbet/tree/1beae38af163add1e13e897e4771727a0a40c338/rbi/core/integer.rbi#L104","range":{"start":{"line":103,"character":8},"end":{"line":103,"character":12}}},"message":"Method `Integer#+` has specified `arg0` as `Integer`"},{"location":{"uri":"file:///Users/dmitry/.empty/a.rb","range":{"start":{"line":2,"character":4},"end":{"line":2,"character":7}}},"message":"Got String(\"s\") originating from:"},{"location":{"uri":"https://srb.help/7002","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]}]}}
[T12476275][2019-07-03T11:39:25.629673] Write: {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///Users/dmitry/.empty/foo.rb","diagnostics":[{"range":{"start":{"line":7,"character":9},"end":{"line":7,"character":13}},"severity":1,"code":5002,"message":"Unable to resolve constant `Helo`","relatedInformation":[{"location":{"uri":"https://github.com/sorbet/sorbet/tree/1beae38af163add1e13e897e4771727a0a40c338/rbi/stdlib/gem.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":10}}},"message":"Did you mean: `Gem`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/1beae38af163add1e13e897e4771727a0a40c338/rbi/core/file.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":15}}},"message":"Did you mean: `File`?"},{"location":{"uri":"https://github.com/sorbet/sorbet/tree/1beae38af163add1e13e897e4771727a0a40c338/rbi/core/hash.rbi#L3","range":{"start":{"line":2,"character":0},"end":{"line":2,"character":19}}},"message":"Did you mean: `Hash`?"},{"location":{"uri":"https://srb.help/5002","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]}]}}
[T12476275][2019-07-03T11:39:25.631184] Write: {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///Users/dmitry/.empty/a.rb","diagnostics":[{"range":{"start":{"line":2,"character":0},"end":{"line":2,"character":7}},"severity":1,"code":7002,"message":"Expected `Integer` but found `String(\"s\")` for argument `arg0`","relatedInformation":[{"location":{"uri":"https://github.com/sorbet/sorbet/tree/1beae38af163add1e13e897e4771727a0a40c338/rbi/core/integer.rbi#L104","range":{"start":{"line":103,"character":8},"end":{"line":103,"character":12}}},"message":"Method `Integer#+` has specified `arg0` as `Integer`"},{"location":{"uri":"file:///Users/dmitry/.empty/a.rb","range":{"start":{"line":2,"character":4},"end":{"line":2,"character":7}}},"message":"Got String(\"s\") originating from:"},{"location":{"uri":"https://srb.help/7002","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"message":"Click for more information on this error."}]}]}}
[T12476287][2019-07-03T11:40:57.507089] Read: {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"ruby","text":"class Hello\n    def something(x)\n\n    end\nend\n\ndef main\n    puts Helo.new\nend\n","uri":"file:///Users/dmitry/.empty/foo.rb","version":0}}}
[T12476275][2019-07-03T11:40:57.508242] Write: {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///Users/dmitry/.empty/foo.rb","diagnostics":[]}}


[otbn] Wrong version of register used for range checks in bn.lid

Example code:
.section .text
  addi     x21, x0, 0
  bn.lid   x21, 0(x21++)
  ecall

.section .data
  .word 0
  .word 0
  .word 0
  .word 0
  .word 0
  .word 0
  .word 0
  .word 0

Note that x21 is used as both a source and a destination. The code that checks whether x21 is in range as the name of a register is checking the value after it's been incremented by 32, so flags this as an illegal instruction.
Attached is a simple directory with Makefile that lets you generate the same example. Unzip it in the top of the OpenTitan folder, build the Verilator sim with fusesoc --cores-root=. run --target=sim --setup --build lowrisc:ip:otbn_top_sim, then make -C indirect-bug test.
indirect-bug.zip
@GregAC: I think this is probably triggered by the fix for #7579: presumably we need to flop rf_indirect_err in otbn_controller for load/store instructions?

estimate 2

This turned out to be a bit trickier than first thought. It's not just about the timing of when to check the error but the timing of the read for the indirect destination register index. Architecturally both should be read before any activity occurs so in this scenario the newly incremented x21 shouldn't be the indirect destination register, the old version should be used (the same as used for the base address).
So I've introduced a flop that holds the read value from the first cycle of the instruction. This also partially backtracks what I did for #7579, now both register reads always occur on the first cycle. I've checked the #7579 behaviour again and I believe everything now works correctly :)


CLI: Store cluster information in Rancher as a cache

What kind of request is this (question/bug/enhancement/feature request):
Feature
Desired Result:
A customer is having issues with cluster listings with Rancher cli taking a long time. This is due to them managing a large number of clusters all around the world. Some of these clusters have very high latency and take 2 seconds on their own to return data.
In cases like this it may be beneficial to store a cached version of this data on the local Rancher cluster to pull from for basic queries to reduce command completion time.  Perhaps something like a --live flag could be used not use the cache.

Are calls being made to a cluster one at a time? If so, maybe making parallel calls would speed up the overall process. Caching may introduce consistency issues.

@dnoland1 I believe that they are being made one at a time, in which case they would benefit greatly from them being done concurrently. In this case that should decrease the run time of their script from 30ish seconds down to less than 3.

@bentastic27 do we know how many a) clusters b) nodes c) average nodes per cluster the user has? Per @gitlawr we don't fetch clusters one by one, but we do fetch nodes on per cluster basis to figure out the node count for each cluster. Ideally we should reproduce the problem with the exact number of clusters/nodes the user has. We can set the RANCHER_CLIENT_DEBUG=true env var to get more logging as well.

The per cluster call to get node count can be avoided for all clusters except Imported cluster. Since rke, gke, eks and aks all have the current node count somewhere in the cluster spec and we get the spec of each cluster from the first and only call done to fetch clusters.
For rkeConfig the field Nodes is an array, we can use its length as node count.
And for gke, eks and aks, there are fields under the genericEngineConfig which reflect node count.
Unless we expect these fields to keep changing? Also from the earlier comments, making the calls to list each cluster in parallel will help


[Bug]: Latest version of @ledgerhq/hw-app-eth has breaking changes

Impacted Library name
@ledgerhq/hw-app-eth
Impacted Library version
6.34.0
Describe the bug
We have a hardhat-ledger plugin in our monorepo, and we also have a CI workflow that tries to build and run our tests with the latest versions of all our dependencies.
The latest version of the eth app library broke this workflow because, as far as I can tell, it has some breaking changes (at the very least the isEIP712Message was removed from the exports; there might be others).
For now we fixed this by pinning the version we depend on. But, assuming you are following semver, I think this was a mistake.
Expected behavior
A new minor version shouldn't include breaking changes.
Additional context
No response

Also have the issue of missing functions in EVM-tools while hw-app-eth thinks they should be there
example : sortObjectAlphabetically is removed but not exported in evm
removed here https://github.com/LedgerHQ/ledger-live/pull/3924/files#diff-0014e583278c639b19797bb7a95d5ae400802e7f91bb8d44544fd66c7e9fa62f
the pr @pcaversaccio talks about.

Sorry about that guys, no breaking change per se in the new release, just a bundling/releasing problem with the new evm-tools lib.
PR https://github.com/LedgerHQ/ledger-live/pull/4090 is fixing this, a new patch should come soon without the issue 🙏

just a bundling/releasing problem with the new evm-tools lib

Glad to know it was just that, thanks for the update! I'll re-enable the ^ dependency range after this is fixed then.

Hi Guys!
I installed only two package and my node v is 18
"@ledgerhq/cryptoassets": "^7.0.0",
"@ledgerhq/hw-transport-webusb": "^6.27.7",
But it throws same error
Module not found: Can't resolve '@ledgerhq/evm-tools/message/EIP712/index'
Can you tell me how to resolve this and which version I will install for this two package?

Can you all please try with @ledgerhq/hw-app-eth in version 6.34.1 and let me know if it fixes your issues ?

I used 6.34.1 v but now this error throws

@lvndry for me the latest release has fixed the missing dependency issue. To my surprise a dependency on @ledgerhq/live-network was introduced. I didn't expect @ledgerhq/hw-app-eth to open remote connections. Was that intended?

@svarcoder Do you still have the issue ?
Yes. Now the issue is resolved.


BUGFIX: add file close at the end of program

Can one of the admins verify this patch?

add to whitelist


Add custom solidity error string for modulus by 0

Similar to divide by 0, solidity raises INVALID when attempting % 0. Should be straightforward to implement.

Also missing - SMOD and SDIV


⚠ Bofrost.at has degraded performance

In b77e252, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1348 ms

Resolved: Bofrost.at performance has improved in f8456a1.


[Anomaly Detector] Fix missing types in package

Types file was generated with an incorrect name template.d.ts so it was not included in the package. Renaming it to ai-anomaly-detector.d.ts will match the entry in package.files and will include it in the package.
Also:

Fixing some leftover template strings in the samples package
Enable linter when building
Fix linting errors

Fixed: https://github.com/Azure/azure-sdk-for-js/issues/11336


Test case creation

Added tests for url check;
Added test for navigation check.

Known issues:

Navigation header doesn't work with Safari (investigation in progress);
Not all screenshots are displayed on screener.io dashboard.

@OleksandrYuzhnyi I made a number of updates to some files. It's not in a resolved state and I'm not sure if this fixes the issue. However, I was able to get to a state that connects a lot of the dots. When I ran the suite of tests only on the combination that I specified, I got a bunch of errors from the tests. Looks like locator related for a lot of them. That makes sense because the test wasn't able to finish, hence, there was never a visual snapshot. Here are the errors that I'm getting from different tests. You could probably pull down this branch and try it yourself.

------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-4] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-4] Session ID: d87d3133e18a4338bcdb9ea8b05b3c7c
[chrome 97.0.4692.71 windows #0-4]
[chrome 97.0.4692.71 windows #0-4] » /test/specs/urlCheck/hongKongRegion.spec.js
[chrome 97.0.4692.71 windows #0-4] Hong Kong region url check
[chrome 97.0.4692.71 windows #0-4]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-4]
[chrome 97.0.4692.71 windows #0-4] 1 failing (26.8s)
[chrome 97.0.4692.71 windows #0-4]
[chrome 97.0.4692.71 windows #0-4] 1) Hong Kong region url check HomePage check
[chrome 97.0.4692.71 windows #0-4] Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-4] Error: Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-4]     at Object.implicitWait [as default] (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
[chrome 97.0.4692.71 windows #0-4]     at async Element.elementErrorHandlerCallbackFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/middlewares.js:20:29)
[chrome 97.0.4692.71 windows #0-4]     at async Element.wrapCommandFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/@wdio/utils/build/shim.js:106:29)
[chrome 97.0.4692.71 windows #0-4]     at async HomePage.makeScreenShot (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/pageObject/page.js:17:9)
[chrome 97.0.4692.71 windows #0-4]     at async Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/hongKongRegion.spec.js:12:9)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-8] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-8] Session ID: 2e6ecad039ab44a1bfbe0fe5eda1bd1b
[chrome 97.0.4692.71 windows #0-8]
[chrome 97.0.4692.71 windows #0-8] » /test/specs/urlCheck/unitedKingdomRegion.spec.js
[chrome 97.0.4692.71 windows #0-8] United Kingdom region url check
[chrome 97.0.4692.71 windows #0-8]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-8]
[chrome 97.0.4692.71 windows #0-8] 1 failing (25.3s)
[chrome 97.0.4692.71 windows #0-8]
[chrome 97.0.4692.71 windows #0-8] 1) United Kingdom region url check HomePage check
[chrome 97.0.4692.71 windows #0-8] Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-8] Error: Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-8]     at Object.implicitWait [as default] (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
[chrome 97.0.4692.71 windows #0-8]     at async Element.elementErrorHandlerCallbackFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/middlewares.js:20:29)
[chrome 97.0.4692.71 windows #0-8]     at async Element.wrapCommandFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/@wdio/utils/build/shim.js:106:29)
[chrome 97.0.4692.71 windows #0-8]     at async HomePage.makeScreenShot (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/pageObject/page.js:17:9)
[chrome 97.0.4692.71 windows #0-8]     at async Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/unitedKingdomRegion.spec.js:12:9)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-6] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-6] Session ID: 58a4fb8a4fa04a7291dfdd88ffb26a2d
[chrome 97.0.4692.71 windows #0-6]
[chrome 97.0.4692.71 windows #0-6] » /test/specs/urlCheck/koreaRegion.spec.js
[chrome 97.0.4692.71 windows #0-6] Korea region url check
[chrome 97.0.4692.71 windows #0-6]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-6]
[chrome 97.0.4692.71 windows #0-6] 1 failing (26.7s)
[chrome 97.0.4692.71 windows #0-6]
[chrome 97.0.4692.71 windows #0-6] 1) Korea region url check HomePage check
[chrome 97.0.4692.71 windows #0-6] Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-6] Error: Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-6]     at Object.implicitWait [as default] (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
[chrome 97.0.4692.71 windows #0-6]     at async Element.elementErrorHandlerCallbackFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/middlewares.js:20:29)
[chrome 97.0.4692.71 windows #0-6]     at async Element.wrapCommandFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/@wdio/utils/build/shim.js:106:29)
[chrome 97.0.4692.71 windows #0-6]     at async HomePage.makeScreenShot (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/pageObject/page.js:17:9)
[chrome 97.0.4692.71 windows #0-6]     at async Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/koreaRegion.spec.js:12:9)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-1] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-1] Session ID: 2e20b522e842461faca5855c1d3eb886
[chrome 97.0.4692.71 windows #0-1]
[chrome 97.0.4692.71 windows #0-1] » /test/specs/urlCheck/deutschlandRegion.spec.js
[chrome 97.0.4692.71 windows #0-1] Deutschland region url check
[chrome 97.0.4692.71 windows #0-1]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-1]
[chrome 97.0.4692.71 windows #0-1] 1 failing (24.8s)
[chrome 97.0.4692.71 windows #0-1]
[chrome 97.0.4692.71 windows #0-1] 1) Deutschland region url check HomePage check
[chrome 97.0.4692.71 windows #0-1] Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-1] Error: Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-1]     at Object.implicitWait [as default] (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
[chrome 97.0.4692.71 windows #0-1]     at async Element.elementErrorHandlerCallbackFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/middlewares.js:20:29)
[chrome 97.0.4692.71 windows #0-1]     at async Element.wrapCommandFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/@wdio/utils/build/shim.js:106:29)
[chrome 97.0.4692.71 windows #0-1]     at async HomePage.makeScreenShot (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/pageObject/page.js:17:9)
[chrome 97.0.4692.71 windows #0-1]     at async Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/deutschlandRegion.spec.js:12:9)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-5] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-5] Session ID: be8dfd26d6fd496a820b42286d0b29ae
[chrome 97.0.4692.71 windows #0-5]
[chrome 97.0.4692.71 windows #0-5] » /test/specs/urlCheck/japanRegion.spec.js
[chrome 97.0.4692.71 windows #0-5] Japan region url check
[chrome 97.0.4692.71 windows #0-5]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-5]
[chrome 97.0.4692.71 windows #0-5] 1 failing (27s)
[chrome 97.0.4692.71 windows #0-5]
[chrome 97.0.4692.71 windows #0-5] 1) Japan region url check HomePage check
[chrome 97.0.4692.71 windows #0-5] Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-5] Error: Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-5]     at Object.implicitWait [as default] (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
[chrome 97.0.4692.71 windows #0-5]     at async Element.elementErrorHandlerCallbackFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/middlewares.js:20:29)
[chrome 97.0.4692.71 windows #0-5]     at async Element.wrapCommandFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/@wdio/utils/build/shim.js:106:29)
[chrome 97.0.4692.71 windows #0-5]     at async HomePage.makeScreenShot (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/pageObject/page.js:17:9)
[chrome 97.0.4692.71 windows #0-5]     at async Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/japanRegion.spec.js:12:9)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-2] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-2] Session ID: 8732428eb05f4d97bdc8c7b51f8e21a8
[chrome 97.0.4692.71 windows #0-2]
[chrome 97.0.4692.71 windows #0-2] » /test/specs/urlCheck/europeRegion.spec.js
[chrome 97.0.4692.71 windows #0-2] Europe region url check
[chrome 97.0.4692.71 windows #0-2]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-2]
[chrome 97.0.4692.71 windows #0-2] 1 failing (38.9s)
[chrome 97.0.4692.71 windows #0-2]
[chrome 97.0.4692.71 windows #0-2] 1) Europe region url check HomePage check
[chrome 97.0.4692.71 windows #0-2] Can't call scrollIntoView on element with selector "//a[@class="minicart-link"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-2] Error: Can't call scrollIntoView on element with selector "//a[@class="minicart-link"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-2]     at Object.implicitWait [as default] (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
[chrome 97.0.4692.71 windows #0-2]     at async Element.elementErrorHandlerCallbackFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/middlewares.js:20:29)
[chrome 97.0.4692.71 windows #0-2]     at async Element.wrapCommandFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/@wdio/utils/build/shim.js:106:29)
[chrome 97.0.4692.71 windows #0-2]     at async HomePage.makeScreenShot (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/pageObject/page.js:19:9)
[chrome 97.0.4692.71 windows #0-2]     at async Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/europeRegion.spec.js:12:9)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-3] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-3] Session ID: e57ff6c1a5954801b7bdc6007b35bd29
[chrome 97.0.4692.71 windows #0-3]
[chrome 97.0.4692.71 windows #0-3] » /test/specs/urlCheck/franceRegion.spec.js
[chrome 97.0.4692.71 windows #0-3] France region url check
[chrome 97.0.4692.71 windows #0-3]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-3]
[chrome 97.0.4692.71 windows #0-3] 1 failing (24.2s)
[chrome 97.0.4692.71 windows #0-3]
[chrome 97.0.4692.71 windows #0-3] 1) France region url check HomePage check
[chrome 97.0.4692.71 windows #0-3] Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-3] Error: Can't call scrollIntoView on element with selector "//a[text()="Terms of Use"]" because element wasn't found
[chrome 97.0.4692.71 windows #0-3]     at Object.implicitWait [as default] (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
[chrome 97.0.4692.71 windows #0-3]     at async Element.elementErrorHandlerCallbackFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/webdriverio/build/middlewares.js:20:29)
[chrome 97.0.4692.71 windows #0-3]     at async Element.wrapCommandFn (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/node_modules/@wdio/utils/build/shim.js:106:29)
[chrome 97.0.4692.71 windows #0-3]     at async HomePage.makeScreenShot (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/pageObject/page.js:17:9)
[chrome 97.0.4692.71 windows #0-3]     at async Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/franceRegion.spec.js:12:9)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-7] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-7] Session ID: a27fd4dfb44e4e4c8f02b7d0ca261caf
[chrome 97.0.4692.71 windows #0-7]
[chrome 97.0.4692.71 windows #0-7] » /test/specs/urlCheck/newZelandRegion.spec.js
[chrome 97.0.4692.71 windows #0-7] New Zeland region url check
[chrome 97.0.4692.71 windows #0-7]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-7]
[chrome 97.0.4692.71 windows #0-7] 1 failing (1m 34s)
[chrome 97.0.4692.71 windows #0-7]
[chrome 97.0.4692.71 windows #0-7] 1) New Zeland region url check HomePage check
[chrome 97.0.4692.71 windows #0-7] Cannot read property 'ok' of undefined
[chrome 97.0.4692.71 windows #0-7] TypeError: Cannot read property 'ok' of undefined
[chrome 97.0.4692.71 windows #0-7]     at Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/newZelandRegion.spec.js:14:16)
[chrome 97.0.4692.71 windows #0-7]     at processTicksAndRejections (internal/process/task_queues.js:95:5)
------------------------------------------------------------------
[chrome 97.0.4692.71 windows #0-0] Running: chrome (v97.0.4692.71) on windows
[chrome 97.0.4692.71 windows #0-0] Session ID: a34eb12495db44b08ac045052fdd1a67
[chrome 97.0.4692.71 windows #0-0]
[chrome 97.0.4692.71 windows #0-0] » /test/specs/urlCheck/australiaRegion.spec.js
[chrome 97.0.4692.71 windows #0-0] Australia region url check
[chrome 97.0.4692.71 windows #0-0]    ✖ HomePage check
[chrome 97.0.4692.71 windows #0-0]
[chrome 97.0.4692.71 windows #0-0] 1 failing (1m 32.1s)
[chrome 97.0.4692.71 windows #0-0]
[chrome 97.0.4692.71 windows #0-0] 1) Australia region url check HomePage check
[chrome 97.0.4692.71 windows #0-0] Cannot read property 'ok' of undefined
[chrome 97.0.4692.71 windows #0-0] TypeError: Cannot read property 'ok' of undefined
[chrome 97.0.4692.71 windows #0-0]     at Context.<anonymous> (/Users/nikolay/source/js/automation-best-practices/testing-for-charity/my-react-app/test/specs/urlCheck/australiaRegion.spec.js:14:12)
[chrome 97.0.4692.71 windows #0-0]     at processTicksAndRejections (internal/process/task_queues.js:95:5)

@OleksandrYuzhnyi after some investigation, i found a number of issues. Please see my updated code. I'll send you a video of my feedback. We need to:

Make the code work correctly first and foremost. The visual layout in Screener is very important here.
Then think about optimizations.
This line will scroll all the way to the bottom of a page, I think hehe

@nadvolod thank you for the review. I found it extremely helpful. Please check my last changes to the code.
I was able to get 3 screenshots for 5 regions

Unfortunately tests for some regions (korea, japan) are not stable and I am currently working on them.

@nadvolod I have updated and made code little bit cleaner than it was. Please try it on your environment.

@OleksandrYuzhnyi everything worked. I moved over the code into a separate folder for the customer. Feel free to try on your end to make sure it works.
https://github.com/saucelabs-training/automation-best-practices/tree/main/visual-demo


Sending Midi Messages

Is there a way to broadcast/send a midi message to "all" devices? Without sending it to a predefined one?
For example, a midi keyboard doesn't have to tell to whom it sending it's midi, its up to the program (DAW) or another device to pick it up.
DAWs for example doesn't show up as a midi devices even if it can recieve MIDI messages.
DAWs also can listen to "All midi Inputs".
I am trying to remote control my daw from my app but since it doesn't show up as a device I cant find a way to send messages to it.
It's no problem if I for example use my Midi Keayboard. I can let the DAW recieve from that keyboard or just recieve from all midi, it works both ways.
Am I missing something, or can I only communicate with devices that can be found?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 323778d3-4ab7-46d3-3117-3492769bd73b
Version Independent ID: 500c30fe-261f-94d3-a143-f4d1915c7777
Content: Windows.Devices.Midi Namespace - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.devices.midi.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: stevewhims
Microsoft Alias: stwhi

Hi, @MatsEx, thanks for reaching out with this question. This feels not so much like feedback specifically about the documentation, but rather like a question about the product. You got here by clicking Send feedback about > This page. If instead you click Send feedback about > This product, then you'll be taken to the Windows developer feedback site (more info about that below).
Here are all of the developer support resources, for completeness.

The Windows developer feedback site is the right place to lobby for a change, a feature, or to make a suggestion.
For community assistance with development questions, there are our forums, and StackOverflow.
The Windows developer support site explains other support options.
The Visual Studio developer community is available, and responsive. The former User Voice feature is now there on the Suggest a feature tab, if you want to lobby for a change, a feature, or to make a suggestion.
For developer issues, or suspected product bugs, there's Microsoft Support; a support engineer will look at the repro and see whether the issue is a Microsoft product bug, or something else. If it's a bug with a Microsoft product then the ticket will be free of charge.

If you receive assistance via any support resource, and you believe that information would help us improve the docs, then please come back and let us know. But I'll go ahead and close this issue for the reasons given.
Thanks!
Steve

Ah, sorry! My mistake!
Thanks for the feedback!


setErrors fails without any response if second parameter is array.

Reproduction
https://formkit.com/playground?fkv=latest&fileTab=Playground.vue&css-framework=genesis&files=jc[('name!'Playground.vue'~editX!'<script+setupDBESMYmpXt8ar9suppXtejfrom+URL8{https%3A%2F%2Fcdn...}3Ba8well+a8secondary+playgrounjfile8{.%2FOthxFile.vue}.33functiozZ{data%2C+node}+(336if+{data.uV9'%3A%3D%3D+"fXmkit4life"}+(0node.setErrXs{06BArg+1Y8fXm-wid9xrXs06["Thx9wa8azxrXYzthi8fXm"]%2C06BArg+2Y8field-specific+xrXs06[]0}36)+els9(0alxt{"Great%2CJar9registxed"}36)3)3NscriptD3<templateD<_+typeQfXm7+%40submitQZ7>06<_066nameQuVe7066labelQUVe7066helpQWhat+uV9wouldJlike%3F7066validationQrequired|length%3A5706%2F>0N_DNtemplateD3<styl9scopedD%2F*3Thi8fil9suppXt8TailwinjCSS.+33IfJneejvanilla+CSSYt+cazgo+hxe.3*%2F3NstyleD'~added!true)]03663\n6\t7\'8s+9e+B%2F%2F+D>3J+you+N<%2FQ%3D7VsxnamXorY+iZsubmitHandlx_FXmKitjd+xerzn+zxj_ZYXVQNJDB987630_
Describe the bug
If pass to setErrors second parameter as array, then it does not set any errors, and does not throw any error.
node.setErrors(
			// Arg 1 is form-wide errors
			['There was an error in this form'],
			// Arg 2 is field-specific errors
			[]
		)

Environment
• OS: wsl+node<EMAIL_ADDRESS>• Browser chrome/any
• Version<EMAIL_ADDRESS>

Problem is, that if you set general form error in first parameter(in correct way), and second as array, then it's also not shown. This is inconsistent. It should throw an error, or at least work correctly with general error.

Sure, maybe we can throw a warning or something when you are in development mode.


Update README.md

committed the changes , please could you merge my pr?

just could you merge my PR please , after reviewing.

As per you require changes are made , kindly merge my pr

I have done the changes , please could you merge it with the label of jwoc

see now is it ok?

now is it ok?
could you check please?

could you merge my PR?

as per your instructions , changes are made now merge my pr

@Code1705 Can you reopen this PR idk but it somehow got closed ?

As you told I opened the new issue as update readme , now you can label it under Jwoc and assign me.


userland: fix installed-vs-shipped in multilib builds

Be aware that whole userland repo is marked as ancient and deprecated: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848 and explicitly says:
"If you are using code from here you should rethink your solution."
But even if your build is using vc4graphics in MACHINE_FEATURES to avoid most of userland, this issue with multilib was preventing do_install:append to actually remove those libraries provided by lib32-mesa when building lib32-userland (e.g. to provide virtual/libomxil or as dependency of raspidmx or runtime dependency of omxplayer).

Our builds are using vc4graphics and normally don't use lib32-userland.
I've verified that for no-multilib builds there is no change in userland packages (other than CMakeLists.txt files in userland-dev):
diff -rq tmp-glibc/work/cortexa72-oe-linux/userland/20230419.*/packages-split
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_audio/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/hel
lo_pi/hello_audio/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_dispmanx/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/
hello_pi/hello_dispmanx/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_encode/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/he
llo_pi/hello_encode/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_font/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/hell
o_pi/hello_font/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_jpeg/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/hell
o_pi/hello_jpeg/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_teapot/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/he
llo_pi/hello_teapot/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_tiger/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/hel
lo_pi/hello_tiger/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_triangle/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/
hello_pi/hello_triangle/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_triangle2/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src
/hello_pi/hello_triangle2/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_video/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/hel
lo_pi/hello_video/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_videocube/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src
/hello_pi/hello_videocube/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_wayland/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/h
ello_pi/hello_wayland/CMakeLists.txt differ
Files tmp-glibc/work/cortexa72-oe-linux/userland/20230419.after/packages-split/userland-dev/usr/src/hello_pi/hello_world/CMakeLists.txt and tmp-glibc/work/cortexa72-oe-linux/userland/20230419.before/packages-split/userland-dev/usr/src/hel
lo_pi/hello_world/CMakeLists.txt differ

$ buildhistory-diff -p buildhistory
$ buildhistory-diff -p buildhistory -a
packages/cortexa72-oe-linux/userland: SRC_URI changed from "git://github.com/raspberrypi/userland.git;protocol=https;branch=master file://0001-mmal-Do-not-use-Werror.patch file://0001-Allow-applications-to-set-next-resource-handle.patch f
ile://0002-wayland-Add-support-for-the-Wayland-winsys.patch file://0003-wayland-Add-Wayland-example.patch file://0004-wayland-egl-Add-bcm_host-to-dependencies.patch file://0005-interface-remove-faulty-assert-to-make-weston-happy-.patch fi
le://0006-zero-out-wl-buffers-in-egl_surface_free.patch file://0007-initialize-front-back-wayland-buffers.patch file://0008-Remove-RPC_FLUSH.patch file://0009-fix-cmake-dependency-race.patch file://0010-Fix-for-framerate-with-nested-compo
sition.patch file://0011-build-shared-library-for-vchostif.patch file://0012-implement-buffer-wrapping-interface-for-dispmanx.patch file://0013-Implement-triple-buffering-for-wayland.patch file://0014-GLES2-gl2ext.h-Define-GL_R8_EXT-and-G
L_RG8_EXT.patch file://0015-EGL-glplatform.h-define-EGL_CAST.patch file://0016-Allow-multiple-wayland-compositor-state-data-per-pro.patch file://0017-khronos-backport-typedef-for-EGL_EXT_image_dma_buf_i.patch file://0018-Add-EGL_IMG_conte
xt_priority-related-defines.patch file://0019-libfdt-Undefine-__wordsize-if-already-defined.patch file://0020-openmaxil-add-pkg-config-file.patch file://0021-cmake-Disable-format-overflow-warning-as-error.patch file://0022-all-host_applic
ations-remove-non-existent-projects.patch file://0023-hello_pi-optionally-build-wayland-specific-app.patch file://0024-userland-Sync-needed-defines-for-weston-build.patch" to "git://github.com/raspberrypi/userland.git;protocol=https;branc
h=master file://0001-mmal-Do-not-use-Werror.patch file://0001-Allow-applications-to-set-next-resource-handle.patch file://0002-wayland-Add-support-for-the-Wayland-winsys.patch file://0003-wayland-Add-Wayland-example.patch file://0004-wayl
and-egl-Add-bcm_host-to-dependencies.patch file://0005-interface-remove-faulty-assert-to-make-weston-happy-.patch file://0006-zero-out-wl-buffers-in-egl_surface_free.patch file://0007-initialize-front-back-wayland-buffers.patch file://000
8-Remove-RPC_FLUSH.patch file://0009-fix-cmake-dependency-race.patch file://0010-Fix-for-framerate-with-nested-composition.patch file://0011-build-shared-library-for-vchostif.patch file://0012-implement-buffer-wrapping-interface-for-dispm
anx.patch file://0013-Implement-triple-buffering-for-wayland.patch file://0014-GLES2-gl2ext.h-Define-GL_R8_EXT-and-GL_RG8_EXT.patch file://0015-EGL-glplatform.h-define-EGL_CAST.patch file://0016-Allow-multiple-wayland-compositor-state-dat
a-per-pro.patch file://0017-khronos-backport-typedef-for-EGL_EXT_image_dma_buf_i.patch file://0018-Add-EGL_IMG_context_priority-related-defines.patch file://0019-libfdt-Undefine-__wordsize-if-already-defined.patch file://0020-openmaxil-ad
d-pkg-config-file.patch file://0021-cmake-Disable-format-overflow-warning-as-error.patch file://0022-all-host_applications-remove-non-existent-projects.patch file://0023-hello_pi-optionally-build-wayland-specific-app.patch file://0024-use
rland-Sync-needed-defines-for-weston-build.patch file://0025-CMakeLists.txt-.pc-respect-CMAKE_INSTALL_LIBDIR.patch"
packages/cortexa72-oe-linux/userland/userland-dbg: PKGR changed from r0.0 to r0.1
packages/cortexa72-oe-linux/userland/userland-dev: PKGSIZE changed from 34988595 to 34988855 (+0%)
packages/cortexa72-oe-linux/userland/userland-dev: PKGR changed from r0.0 to r0.1
packages/cortexa72-oe-linux/userland/userland-doc: PKGR changed from r0.0 to r0.1
packages/cortexa72-oe-linux/userland/userland-lic: PKGR changed from r0.0 to r0.1
packages/cortexa72-oe-linux/userland/userland-locale: PKGR changed from r0.0 to r0.1
packages/cortexa72-oe-linux/userland/userland-src: PKGR changed from r0.0 to r0.1
packages/cortexa72-oe-linux/userland/userland-staticdev: PKGR changed from r0.0 to r0.1
packages/cortexa72-oe-linux/userland/userland: PKGR changed from r0.0 to r0.1

And without vc4graphics:
MACHINE_FEATURES:remove:rpi = "vc4graphics"
this is the diff with and without vc4graphics
$ buildhistory-diff -p buildhistory
Changes to packages/cortexa72-oe-linux/userland (sysroot):
  /sysroot-providers/virtual_egl was added
  /sysroot-providers/virtual_libgles2 was added
  /usr/include/EGL was added
  /usr/include/EGL/eglext_android.h was added
  /usr/include/EGL/eglext_brcm.h was added
  /usr/include/EGL/eglext.h was added
  /usr/include/EGL/eglext_nvidia.h was added
  /usr/include/EGL/egl.h was added
  /usr/include/EGL/eglplatform.h was added
  /usr/include/GLES was added
  /usr/include/GLES2 was added
  /usr/include/GLES2/gl2ext.h was added
  /usr/include/GLES2/gl2.h was added
  /usr/include/GLES2/gl2platform.h was added
  /usr/include/GLES/glext.h was added
  /usr/include/GLES/gl.h was added
  /usr/include/GLES/glplatform.h was added
  /usr/include/KHR was added
  /usr/include/KHR/khrplatform.h was added
  /usr/lib/pkgconfig/egl.pc was added
  /usr/lib/pkgconfig/glesv2.pc was added
  /usr/lib/pkgconfig/vg.pc was added
packages/cortexa72-oe-linux/userland/userland-dev: FILELIST: added "/usr/include/GLES/glplatform.h /usr/include/EGL/eglplatform.h /usr/lib/pkgconfig/glesv2.pc /usr/include/EGL/eglext.h /usr/include/GLES/gl.h /usr/include/GLES2/gl2platform
.h /usr/lib/pkgconfig/vg.pc /usr/include/GLES/glext.h /usr/include/EGL/eglext_nvidia.h /usr/include/EGL/eglext_android.h /usr/include/EGL/eglext_brcm.h /usr/include/GLES2/gl2ext.h /usr/include/GLES2/gl2.h /usr/include/KHR/khrplatform.h /u
sr/lib/pkgconfig/egl.pc /usr/include/EGL/egl.h"
packages/cortexa72-oe-linux/userland/userland-dev: RRECOMMENDS: removed "libegl-mesa-dev"
packages/cortexa72-oe-linux/userland/userland: RPROVIDES: added "libegl1 libegl libglesv2-2 egl libgles2"
packages/cortexa72-oe-linux/userland/userland: RDEPENDS: removed "libegl-mesa"
Changes to packages/cortexa72-oe-linux/wayland (sysroot):
  /usr/lib/libwayland-egl.so.1.22.0 was removed
  /usr/lib/libwayland-egl.so.1 was removed
  /usr/lib/libwayland-egl.so was removed
  /usr/lib/pkgconfig/wayland-egl.pc was removed
packages/cortexa72-oe-linux/wayland/wayland-dev: FILELIST: removed "/usr/lib/libwayland-egl.so /usr/lib/pkgconfig/wayland-egl.pc"
packages/cortexa72-oe-linux/wayland/wayland: FILELIST: removed "/usr/lib/libwayland-egl.so.1.22.0 /usr/lib/libwayland-egl.so.1"
packages/cortexa72-oe-linux/wayland/wayland: PKGSIZE changed from 497698 to 430226 (-14%)

and this change doesn't have any impact again:
OE raspberrypi4-64@ /OE/build/oe-core $ buildhistory-diff -p buildhistory
OE raspberrypi4-64@ /OE/build/oe-core $ buildhistory-diff -p buildhistory -a
packages/cortexa72-oe-linux/userland: SRC_URI changed from "git://github.com/raspberrypi/userland.git;protocol=https;branch=master file://0001-mmal-Do-not-use-Werror.patch file://0001-Allow-applications-to-set-next-resource-handle.patch f
ile://0002-wayland-Add-support-for-the-Wayland-winsys.patch file://0003-wayland-Add-Wayland-example.patch file://0004-wayland-egl-Add-bcm_host-to-dependencies.patch file://0005-interface-remove-faulty-assert-to-make-weston-happy-.patch fi
le://0006-zero-out-wl-buffers-in-egl_surface_free.patch file://0007-initialize-front-back-wayland-buffers.patch file://0008-Remove-RPC_FLUSH.patch file://0009-fix-cmake-dependency-race.patch file://0010-Fix-for-framerate-with-nested-compo
sition.patch file://0011-build-shared-library-for-vchostif.patch file://0012-implement-buffer-wrapping-interface-for-dispmanx.patch file://0013-Implement-triple-buffering-for-wayland.patch file://0014-GLES2-gl2ext.h-Define-GL_R8_EXT-and-G
L_RG8_EXT.patch file://0015-EGL-glplatform.h-define-EGL_CAST.patch file://0016-Allow-multiple-wayland-compositor-state-data-per-pro.patch file://0017-khronos-backport-typedef-for-EGL_EXT_image_dma_buf_i.patch file://0018-Add-EGL_IMG_conte
xt_priority-related-defines.patch file://0019-libfdt-Undefine-__wordsize-if-already-defined.patch file://0020-openmaxil-add-pkg-config-file.patch file://0021-cmake-Disable-format-overflow-warning-as-error.patch file://0022-all-host_applic
ations-remove-non-existent-projects.patch file://0023-hello_pi-optionally-build-wayland-specific-app.patch file://0024-userland-Sync-needed-defines-for-weston-build.patch" to "git://github.com/raspberrypi/userland.git;protocol=https;branc
h=master file://0001-mmal-Do-not-use-Werror.patch file://0001-Allow-applications-to-set-next-resource-handle.patch file://0002-wayland-Add-support-for-the-Wayland-winsys.patch file://0003-wayland-Add-Wayland-example.patch file://0004-wayl
and-egl-Add-bcm_host-to-dependencies.patch file://0005-interface-remove-faulty-assert-to-make-weston-happy-.patch file://0006-zero-out-wl-buffers-in-egl_surface_free.patch file://0007-initialize-front-back-wayland-buffers.patch file://000
8-Remove-RPC_FLUSH.patch file://0009-fix-cmake-dependency-race.patch file://0010-Fix-for-framerate-with-nested-composition.patch file://0011-build-shared-library-for-vchostif.patch file://0012-implement-buffer-wrapping-interface-for-dispm
anx.patch file://0013-Implement-triple-buffering-for-wayland.patch file://0014-GLES2-gl2ext.h-Define-GL_R8_EXT-and-GL_RG8_EXT.patch file://0015-EGL-glplatform.h-define-EGL_CAST.patch file://0016-Allow-multiple-wayland-compositor-state-dat
a-per-pro.patch file://0017-khronos-backport-typedef-for-EGL_EXT_image_dma_buf_i.patch file://0018-Add-EGL_IMG_context_priority-related-defines.patch file://0019-libfdt-Undefine-__wordsize-if-already-defined.patch file://0020-openmaxil-ad
d-pkg-config-file.patch file://0021-cmake-Disable-format-overflow-warning-as-error.patch file://0022-all-host_applications-remove-non-existent-projects.patch file://0023-hello_pi-optionally-build-wayland-specific-app.patch file://0024-use
rland-Sync-needed-defines-for-weston-build.patch file://0025-CMakeLists.txt-.pc-respect-CMAKE_INSTALL_LIBDIR.patch"
packages/cortexa72-oe-linux/userland/userland-dbg: PKGR changed from r0.2 to r0.3
packages/cortexa72-oe-linux/userland/userland-dev: PKGR changed from r0.2 to r0.3
packages/cortexa72-oe-linux/userland/userland-dev: PKGSIZE changed from 35228360 to 35228620 (+0%)
packages/cortexa72-oe-linux/userland/userland-doc: PKGR changed from r0.2 to r0.3
packages/cortexa72-oe-linux/userland/userland-lic: PKGR changed from r0.2 to r0.3
packages/cortexa72-oe-linux/userland/userland-locale: PKGR changed from r0.2 to r0.3
packages/cortexa72-oe-linux/userland/userland-src: PKGR changed from r0.2 to r0.3
packages/cortexa72-oe-linux/userland/userland-staticdev: PKGR changed from r0.2 to r0.3
packages/cortexa72-oe-linux/userland/userland: PKGR changed from r0.2 to r0.3

So the only change is for multilib (or other non-standard libdir builds) where it caused installed-vs-shipped QA issue before and kept all libraries (when building with vc4graphics) and now it works correctly (or at least as well as non-multilib case does).

And yes, we should start considering completely dropping userland.


[ENTSWM-771] - CVE-2020-6950 jsf-impl: Mojarra: Path traversal via ei…

ENTSWM-771 - CVE-2020-6950 jsf-impl: Mojarra: Path traversal via either the loc parameter or the con parameter, incomplete fix of CVE-2018-14371 [thorntail-2]
EAP Issue: https://issues.redhat.com/browse/ENTSWM-771

Hi @adamecp -- thanks for the test!
Can you file a WFLY JIRA and reference it in the commit message and PR title instead of ENTSWM?  ENTSWM is not meaningful to WildFly community and I believe it's not a public JIRA project.
@fjuma please review

@bstansberry , @fjuma Ok. I changed ENTSWM-771 to WFLY-13439


Leaving Water before BUH R1T vs AFTER BUH R2T - CoP calculation descrepency

On the main page "how to calculate CoP, it is stated in the formula to use Leaving Water before BUH R1T (as that is a common sensor across Daikin models it would seem)

If we are to use sensors rather than a heat meter, we should all understand constraints and limitations of the sensors and their locations.
However, for those with the backup heater (BUH), and even if not actively used, we are seeing a large temperature drop on the sensor after this stage:
"Leaving Water after BUH R2T"
Below shows schematic of the EDLA 9-16 models with a BUH (Backup Heater) highlighted in red:

Below shows schematic of the EDLA 9-16 models without the BUH:

There is a discussion (link below) over on OpenEnergyMonitor where someone with a MID billing grade heat meter is suggesting the R1T sensor is not appropriate for use in CoP calculations, and that R2T more closely matches their heat meter values, which is extremely useful information for this project and anyone using it.
What does this mean for those without a BUH? Can R1T be reliably used concerning accuracy?
https://community.openenergymonitor.org/t/daikin-9kw-ashp-application-discussion/24848/101?u=stephen_crown
Is anyone else aware of why there is such a large temperature drop (0.8 -14% to 1.8C - 25% drop) have been seen between stages, which feels "off" given the heat loss that would infer.
E.g.
14% of minimum output on the EDLA9-16 units appears to be ~4-4.6kW - and that is then a heat loss outside within the unit of ~640W...
14% of output at design temperature is say 9kW, and the heat loss outside within the unit is a staggering ~1.26kW...
Example of a period where the difference is 0.8C (~14% difference in heating power at the time)

Example of last 2 hours delta between R1T and R2T which as you can see varies a lot:

Photo below captured during Octopus Energy Services installation shows large amount of large diameter pipework exposed without insulation:

Forgot to add an example:

Well, really interesting. I've created COP template sensors for R1T and for R2T, so I'm going to follow the both numbers.

👍 I also have seen this, and switched my own code to R2T, disapointed im not actually getting a cop of 8.9 lol. As the old saying goes, "if it seems to good to be true, its probably a duck" - something like that anyway. 4.8 Cop is okay too I suppose. 👍

Using R2T results in about 10% lower COP for me. It's just rough math here, I need to create a template sensor as % of difference I think...

I expect that R1T Is very close to the heat exchanger and will be picking up on the emitted heat from that and this hotter than the water inside it. The controller probably uses that to check the heat exchanger is working outputting heat normally and will kick in the backup heater if required and allowed by settings.
And probably not a reliable source of data for cop.
Mine is 2.5° off R2T.

While I agree that R1T looks too good to be true for use in COP calculations, I tend to see R1T being used to match the leaving water temperature set point:

I’m going to start logging flow and return inside my property, as I think my system is delivering a wider flow-return delta than I’ve requested.

Interesting. I think I saw someone on forum put a request into Daikin, so wonder what they said about it.

That could have been my post. I’ve heard nothing significant from Daikin regarding the various temperature probes.

Interesting. I think I saw someone on forum put a request into Daikin, so wonder what they said about it.

Here is a screenshot of the Daikin response to Matt's question on this point:

See here for the Daikin response to Matt:
https://community.openenergymonitor.org/t/daikin-9kw-ashp-application-discussion/24848/193?u=stephen_crown
I will also add, that models without a BUH, the R1T sensor is actually int he same position as ours with a BUH.

I've made a "COP template sensor" using R1T oraz second one using R2T temperatures. Than I've made a sensor with difference between these two COPs.
My LT EHVH DA6V (8kW) has a BUH (4+2kW) and the diff between COPs like like that:

As you can see COP R2T is a little but higher than COP R1T :) The average diff is about 0.4°C, maybe 0.5°C. The percentage diff is about 10%:

I use ESPAlthera software from 2021.12.06 with def a little bit tuned, but the essential sensors are:
LabelDef PROGMEM labelDefs[] = {
	{0x21,0,105,2,-1,"INV primary current (A)"},
	{0x21,4,101,2,-1,"Voltage (N-phase) (V)"},
	{0x61,8,105,2,1,"Inlet water temp.(R4T)"},
	{0x61,2,105,2,1,"Leaving water temp. before BUH (R1T)"},
	{0x61,4,105,2,1,"Leaving water temp. after BUH (R2T)"},
	{0x62,9,105,2,-1,"Flow sensor (l/min)"},
}

Is COP diff really that small (~10%) for my HP model or should I update ESPAltherma software because of some bugs fixed? :)

I have an EDLA09D3V3 with BUH, and I had a significant discrepancy between R1T and R2T, of around 2C, and R2T and R4T of 1.5C. However, after I told Daikin support about this, I had an engineer visit and remove a link on the tape heater power block X7M 5-7. The tape heaters E11H and E12H, on the plate heat exchanger outlet and inlet respectively, which had previously been on whenever the circulation pump was running, stayed off, as they should according to the service manual! The R1T, R2T and R4T readings are now within 0.1C of each other. So it's worth checking this - there is a technical service bulletin on it apparently.


GH-39359: [CI][C++] Remove MinGW MINGW32 C++ job

Rationale for this change
MSYS2 stopped providing MINGW32 packages:

https://github.com/msys2/MINGW-packages/pull/19517
https://github.com/msys2/MINGW-packages/commit/f68162d5827fce41e7c2d4eb65cab6fcd8b9dd60

What changes are included in this PR?
Remove the job.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Closes: #39359

@kou maybe there should be a "Yes" in "Are there any user-facing changes?" telling users that Arrow doesn't support MINGW32 anymore because MSYS2 dropped support.

I think that Apache Arrow C++ will be buildable with 32bit MinGW-w64 after this because it seems that R package still uses 32bit MinGW-w64. For example: https://github.com/apache/arrow/blob/cf44793204d88e0156669af102ff65f180a6b003/ci/scripts/r_windows_build.sh#L34
This is just MSYS2 package. And MSYS2 package isn't maintained by us. Upstream is https://github.com/msys2/MINGW-packages . (Our CI job is just for detecting a problem before we release a new version. It's for smooth post release tasks.)
So I think that this is a MSYS2 user-facing change but not an Apache Arrow C++ user-facing change.


Error Can't Find Module node_modules\react-native\node_modules\react-native\scripts\generate-specs-cli.js'

Description
Error: Cannot find module 'C:\Users\...\.....\...\...\...\...\node_modules\react-native\node_modules\react-native\scripts\generate-specs-cli.js'     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)     at Function.Module._load (node:internal/modules/cjs/loader:778:27)     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)     at node:internal/main/run_main_module:17:47 {   code: 'MODULE_NOT_FOUND',   requireStack: [] }
I found this error after upgrading to RN 0.68 when build with npx react-native run-android. I can't find this generate-specs-cli.js in node_modules. Some can help me?
Version
0.68.0
Output of npx react-native info
System:
OS: Windows 10 10.0.16299
CPU: (4) x64 Intel(R) Core(TM) i3 CPU       M 370  @ 2.40GHz
Memory: 637.88 MB / 5.68 GB
Binaries:
Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.14.16 - ~\AppData\Roaming\npm\npm.CMD
Watchman: 4.9.0 - C:\Users\Administrator.DESKTOP-OJLOEQN\AppData\Local\watchman\watchman.EXE
SDKs:
Android SDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Version     2<IP_ADDRESS> AI-211.7628.21.2111.8193401
Visual Studio: 16.8.30907.101 (Visual Studio Community 2019)
Languages:
Java: <IP_ADDRESS> - C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot\bin\javac.EXE
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: ^0.68.0 => 0.68.0
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
--
Snack, code example, screenshot, or link to a repository

Hello @rabihiawaludin, I would like to help you with this issue by starting a conversation around it.
You mentioned in description that this issue appeared after upgrading to RN 0.68. Let me clarify few things:

from which RN version did you upgrade?
which steps did you take to upgrade? And related question - have you used RN upgrade helper?
did you install dependencies (e.g. yarn install) after the upgrade?
have you tried cleaning cache? E.g. xcode, gradlew, node - there are different options depending on your project setup.

This might be helpful to trace any missed steps during the upgrade. Also this information will provide better understanding for anyone willing to help.

Hi @vanja1993.

I upgraded from 0.63.4
I use https://reactnative.dev/docs/next/new-architecture-app-intro for step to upgrade, and RN Upgrade Helper too
I use npm install after upgrade and
I use, gradle / gradlew clean and react-native start --reset-cache for cleaning cache

Execution failed for task ':app:generateCodegenArtifactsFromSchema'.

Hi @vanja1993 , I have followed the upgrade steps from RN Upgrade Helper, but there is an error like this
'java.lang.String com.android.utils.FileUtils.relativePossiblyNonExistingPath(java.io.File, java.io.File)'

I have done with this issue, but my apps crash when apps launching frm build, and show error:
 com.facebook.react.uimanager.IllegalViewOperationException: Trying to attach a ReactRootView with an explicit id already set to [1]. React Native uses the id field to track react tags and will overwrite this field. If that is fine, explicitly overwrite the id field to View.NO_ID.


App Crashed [Update Readme]

I am using below intent code and getting force close.
Source Code

Intent intent = new Intent(mActivity, ImagePickerActivity.class);
    intent.putExtra(ImagePicker.EXTRA_FOLDER_MODE, true);
    intent.putExtra(ImagePicker.EXTRA_MODE, ImagePicker.MODE_SINGLE);
    intent.putExtra(ImagePicker.EXTRA_LIMIT, 1);
    intent.putExtra(ImagePicker.EXTRA_SHOW_CAMERA, true);
    intent.putExtra(ImagePicker.EXTRA_FOLDER_TITLE, "Album");
    intent.putExtra(ImagePicker.EXTRA_IMAGE_TITLE, "Tap to select images");
    intent.putExtra(ImagePicker.EXTRA_IMAGE_DIRECTORY, "Camera");
    intent.putExtra(ImagePicker.EXTRA_RETURN_AFTER_FIRST, true); //default is false

    startActivityForResult(intent, 1234);

Output

E/AndroidRuntime: FATAL EXCEPTION: main
java.lang.NoClassDefFoundError: com.bumptech.glide.Glide
at com.esafirm.imagepicker.adapter.FolderPickerAdapter.onBindViewHolder(FolderPickerAdapter.java:46)
at com.esafirm.imagepicker.adapter.FolderPickerAdapter.onBindViewHolder(FolderPickerAdapter.java:21)
at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:6067)

@pinvisible have you tried adding @aar as prefix in your gradle declaration?

Yes. I have used below code.
compile 'com.github.esafirm.android-image-picker:imagepicker:1.3.3@aar'
// for experimental rx picker
compile 'com.github.esafirm.android-image-picker:rximagepicker:1.3.3@aar'

Same issure

Hi sorry for the really late answer. You can add Glide to your build.gradle
  compile 'com.github.bumptech.glide:glide:3.7.0'

IDK why it's not included in the first place

It helps. Dev, please update readme and include Glide.

@maxxx Done 👍


add Scalactic

this is good to have in general, but also Akka depends on it now (in a
part of Akka we aren't currently building, hopefully will be soon)

already green in several recent test runs

fyi @bvenners


@conda-forge-admin,please add bot automerge

@conda-forge-admin,please add bot automerge

[ ] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/point_cloud_utils-feedstock#19.


Static Images Example Fails

The static Images example fails silently. The dev console on Firefox reports

"Security Error: The operation is insecure" -  quagga.min.js:9:0
Unknown property '-moz-box-shadow'.  Declaration dropped.

On google chrome (version 41) I get..

"Uncaught SecurityError: Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The canvas has been tainted by cross-origin data."
The value "device-width;" for key "width" is invalid, and has been ignored.
Error parsing a meta element's content: ';' is not a valid key-value pair separator. Please use ',' instead.

It seems to be related to running the examples locally (as well as my own code) because
the examples themselves work fine when running them from the browser here on github.
I'm working on an independent project for my employer in retail as a tech demo that could save us a significant amount of money in employee labor for an otherwise irritating and expensive (albeit simple) everyday task. I'm not a full time programmer but I'd gladly toss a twenty your way via paypal or what-have-you, if someone can fix this. Thanks.

This error is most probably caused by running the code directly from the file-system. Due to security-constrains on the canvas-object, it somehow does not allow certain operations when executing code directly from file:///. Try serving the code through a webserver like apache/nxing/ngrok and check if it still fails.

Confirmed. Fails running from ZWAMP. Still getting the same error as before. "Invalid Argument."

But Invalid Argument is not the same error as before, or is it? This error is also caused if the images have really odd dimensions. Have you changed anything on the code side? Or the images?

It's just been too quiet...

@BastardCode thanks for considering QuaggaJS. Have you had success getting the examples to run in your environment?


Firebase preload headers are incorrect for custom or parameterized routes

Do you want to request a feature or report a bug?
Bug.
What is the current behaviour?
The generated firebase.json config uses incorrect route paths for custom or parameterized routes, when generating the HTTP link preload headers. It assumes the route's path is the same as the filename of the route, which it often isn't.
In my situation, I have a group route, which is inside preact-router's Router as <GroupPage path="/groups/:groupId" />, but the firebase.json file contains:
      {
        "source": "/group",
        "headers": [
          {
            "key": "Link",
            "value": "</bundle.86b8e.js>; rel=preload; as=script, </style.785b8.css>; rel=preload; as=style, </route-group.chunk.c23fb.js>; rel=preload; as=script"
          }
        ]
      }

If the current behaviour is a bug, please provide the steps to reproduce.
Generate a firebase.json for a route that's implemented using a path and filename that differ.
What is the expected behaviour?
Ideally, preact-cli would inspect the paths being used in the Router component and generate from those. But that seems quite difficult and might enforce a dependency on supported routers. A simpler approach might be to read a preload mappings file that's kept in sync with the Router mappings, or to inspect a special comment in each route file, that's also kept in sync.
I think a custom preload mappings file would be my preferred approach, as it would allow for explicit custom mappings. For example, my app requires authentication, so I'd like to always preload the login route from the home page, because 90% of visits will require it. I'm imagining something like a preload-mappings.json containing:
{
  "/": ["login", "home"],
  "/groups/*": ["group"],
  "/groups/*/topics/*": ["topic", "group"]
}

I'd be happy to have a go at a PR for this, but I'd like to sanity check this approach before I do the work! The same issue applies with the the preact-cli-plugin-netlify plugin.

I didn't know that's a thing. I'll raise a PR to fix this

Btw what version are u using?

@lukeed @developit can u point me to the place where is this generated?

@prateekbh I’m using 2.2.1.

I should also say that the push-manifest.json exhibits the same problem.

yep this problem still remain I guess

Well this is a bit complicated, I dont know a good way of mentioning this in push-manifest or firebase.json


Inability to use the input method on Ubuntu 17.10

VSCode Version: Code 1.19.1 (0759f77bb8d86658bc935a10a64f6182c5a1eeba, 2017-12-19T09:41:01.414Z)
OS Version: Linux x64 4.13.0-32-generic
Extensions: none

Can not type Chinese on ubuntu 17.10, and other software is OK.
i tried use IBUS and fcitx all both not work!

I found the reason, is to run the snap version, switch to another version successfully.
However, my installation is to use the official website to download the package, it looks the same name after installation! ! !
This is also a problem, snap version can not use the input method.

@junhwong do you mean the vscode snap doesn't work with IMEs? I'll merge this into https://github.com/Microsoft/vscode/issues/5458
FYI @flexiondotorg


Added Russian Localization

first version. later will correct the shortcomings.
and I will try to add missing translation strings in the code.

@DimOkGamer Note that I converted the file to use Unix line endings instead of DOS ones, so make sure to use the new file in git when working again on the translation.
Also, can you check if your PO editor has an option to configure the line wrap? Currently we're wrapping at 80 characters, but I think your editor wraps at 78 chars, so when I synced with the source template it produced more diff than necessary: 8a70c6e


About persistent link for memcached cache

if (class_exists('Memcached', FALSE))
{
$this->_memcached = new Memcached('127_0_0_1');
}
==============
I think we need add "persistent_id" at there.
excuse my english.

You'd need to elaborate more on that ...


How to settle this test case?

Summary
Instead of printing the same strings as shown in the screenshot below, the first test case prints out a very long string as shown in the command prompt screenshot. does anyone know how to resolve this? my return type for snd, rcv and acv is of the child class(es) that inherit from Host or Term.
Screenshots (if any):

Hello, for this you have to consider what you are passing into your snd() method. For the second test case, you are passing in a Host that has yet to make any connection and therefore, after the >--snd-->, you only have transmit1 >--rcv-->.
For the first test case, you are passing in a Host that has already established a connection with other terminals. But the connection path between pager1 and transmit1 should not be captured when we are trying establish a connection between pager2 and transmit1. (i.e. pager1 >--snd--> transmit1 >--rcv--> pager1 >--ack--> transmit1, we should just be having trasmit1)
So you can think of what you need to pass into the next constructor after the snd() method is called. But note that ultimately h1 should still contain information about which Terminals it has connected to for the broadcast() method
Hope this helps!

Hi,
I guess a quick way to settle this is to print the id/name of the Host instead of the entire thing. Note that you might need to violate the tell-don't-ask principle.
Hope this helps!

@timotius-jason Hello jason, but if we just print the id of Host, then wouldn't the string output of p1.snd(r1).rcv().ack() be incorrect>

@zandratay what I'm trying to say is, instead of using the host.toString() method in your print statement, you can use the host's id.
For example, in your case, it prints
pager2 >--snd--> **pager1 >--snd--> transmit1 >--rcv--> pager1 >--ack--> transmit1** >--rcv--> pager2 >--ack--> transmit1
If we use the host id to replace the bold part, we should be able to get
pager2 >--snd--> **transmit1** >--rcv--> pager2 >--ack--> transmit1


Avoid the breaking change introduced in #22

#22 introduced a breaking change because, under no-default-features, ConcurrentQueue<T> no longer implemented UnwindSafe because it was exclusive to libstd prior to 1.56. This PR adds autocfg to detect whether or not we are running in Rust 1.56. If we are, it uses UnwindSafe from libcore. Otherwise, disabling the std feature has no effect.
My only concern is that this PR may introduce a footgun for users of old compilers.

Hmm, considering that concurrent-queue is not used as a public dependency of other smol-rs crates, I think a new breaking release itself is fine...

If the breaking change isn't an issue, then there's no real reason to merge this.


gomod for volsync https://github.com/backube/volsync/tree/release-0.7

Volsync 0.7.0 got released https://github.com/backube/volsync/releases/tag/v0.7.0


FSharpSymbol do not carry information about enum fields

For example, for System.System.Text.RegularExpressions.RegexOptions:

FSharpFields is used to create custom tooltips in MonoDevelop (and I'm trying to port it to VS Code at the moment) https://github.com/mono/monodevelop/blob/8b17d75ff2dc26c5aa1a6246f6a2ce7d4f65e3be/main/external/fsharpbinding/MonoDevelop.FSharpBinding/FSharpSymbolHelper.fs#L681-L689
As FSharpFields are empty, both MonoDevelop and Code show the following tooltip:

Currently we use FSharpCheckFileResults.GetToolTipTextAlternate https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/vs/service.fs#L1909 and it does show enum fields properly:

Thanks, you're right this information should be provided

This is specific to non F# enums is works fine for those defined in F#

Found them.

ILTycon.Fields also has them, I'll see if I can patch this up.

I cannot reproduce in current VFT master:

I think I fixed this a few weeks back, perhaps I forgot to tag it in the PR.
On 29 April 2017 at 16:14, Vasily Kirichenko<EMAIL_ADDRESS>wrote:

Closed #658 https://github.com/fsharp/FSharp.Compiler.Service/issues/658
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fsharp/FSharp.Compiler.Service/issues/658#event-1063167531,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj7yuhnCvLegnrws5H3g_MuvfJDSn_Iks5r01PjgaJpZM4Kd33_
.


Micro_ros_arduino on esp32

Hello guys! I'm currently working on a project using an ESP32 board with arduino as component. I would like to use this library to implement ROS2 in my project but I'm having some troubles, and I don kow if it is posible to do what I want. Has anybody tried before to include this library as component and make it work?
Thanks in advance!

Hello @Joelmaca9, if you want to add micro-ROS to ESP32 IDF as a component better use this other repo: https://github.com/micro-ROS/micro_ros_espidf_component


Using custom fonts

Do you have any plan for extending your library to use custom fonts like FontAwesomeKit library? Right now it is quite limited for fontawesome only
Thanks!

Yes. I just haven't had the time.


select server send buf pointer mistake

in function on_peer_ready_send from file : select-server.c
fd_status_t on_peer_ready_send(int sockfd) {
  assert(sockfd < MAXFDs);
  peer_state_t* peerstate = &global_state[sockfd];

  if (peerstate->sendptr >= peerstate->sendbuf_end) {
    // Nothing to send.
    return fd_status_RW;
  }
  int sendlen = peerstate->sendbuf_end - peerstate->sendptr;
  int nsent = send(sockfd, peerstate->sendbuf, sendlen, 0);
  // ...
  if (nsent < sendlen) {
    peerstate->sendptr += nsent;
    return fd_status_W;
  } else {
    // Everything was sent successfully; reset the send queue.
    peerstate->sendptr = 0;
    peerstate->sendbuf_end = 0;
   // ...
  }
}

I think this line:
int nsent = send(sockfd, peerstate->sendbuf, sendlen, 0);

shoule be:
int nsent = send(sockfd, peerstate->sendbuf+peerstate->sendptr, sendlen, 0);

Thank you! Fixed it in the code and will fix in the blog post too


I would like to become a Zephyr contributor

Nomination
I would like to become a Zephyr contributor!
GitHub User
Provide the following information about the GitHub user:

Rico Ganahl
@dariis
bytesatwork AG, https://github.com/bytesatwork/

Supporting Documents

#35093
#41625
#44444
#53044
#54594

+1

CC @MaureenHelm @carlescufi

https://github.com/zephyrproject-rtos/zephyr/invitations


bubbleprof links the trace instead of moving it

This is from running in a Docker container with -v /tmp:/tmp and running clinic --collect-only --dest /tmp:

@jasnell - I saw some issues reported on Docker, does this relate to anything you reported?

we could use something like the move-file module instead of fs.rename, it should avoid the cross-device issue.

Seems like some sort of race condition? Later that same day I didn't have a problem with it working. 🤷♂

Using fs.rename() with docker containers is notoriously tricky and flaky. Using a file copy may be more reliable.


[#12386] Added series.typeNames values values to english lang.

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

Adds missing series.typeNames values to english translation
Fixed issues

#12386

Details
Before: What was the problem?

Translations for series.typeNames were missing.

After: How is it fixed in this PR?

Translations added

Usage
Are there any API changes?

[ ] The API has been changed.

Related test cases or examples to use the new APIs
NA.
Others
Merging options

[ ] Please squash the commits into a single one when merge.

Other information

@BrianGilbert Thanks, but you don't have to add dist/ files to this commit.

@susiwen8 ah, thanks, I've updated the PR without them.