Unexpected behaviour in implicit binding

Laravel Version: 5.5.0 and 5.4.35 (I've tested with both versions)
PHP Version: 7.1.7 (Homestead)
Database Driver & Version: MySQL (Homestead)

Description:
Implicit binding resolution isn't working the same way in 2 almost identical scenarios (see the steps to reproduce).
I understand that the resolution shouldn't consider the URL itself but only the type-hinted method parameter.
Steps To Reproduce:
First, create a new Laravel app and 2 very similar tables:
laravel new app

php artisan make:migration create_grupocategoria_table --create=grupocategorias
php artisan make:migration create_funcionario_table --create=funcionarios

php artisan migrate

Then, insert 1 row in each table manually. And yes, to be simple, the tables have only id, created_at and updated_at columns.
Now, create 2 controllers and say 'yes' to create the related model.
php artisan make:controller GrupocategoriaController --resource --model=Grupocategoria
php artisan make:controller FuncionarioController --resource --model=Funcionario

In GrupocategoriaController.php, add 'return $grupocategoria;' in 'show' method (line 49).
In FuncionarioController.php, add 'return $funcionario;' in 'show' method (line 49).
In web.php, add:
Route::resource('funcionarios',     'FuncionarioController');
Route::resource('funcionario',     'FuncionarioController');
Route::resource('grupocategorias', 'GrupocategoriaController');
Route::resource('grupocategoria', 'GrupocategoriaController');
Route::resource('aaaaaaaaaaa',     'FuncionarioController');

Now try to access the following URLs:

http://homestead.app/funcionarios/1
http://homestead.app/funcionario/1
http://homestead.app/grupocategorias/1
http://homestead.app/grupocategoria/1
http://homestead.app/aaaaaaaaaaa/1

You'll notice that the last 2 URL return an empty array but all the 3 others return the right model.
Why it is doing the implicit binding or not depending on the URL?

How are you accepting the parameter in the controller?

The same way Laravel generated it....
public function show(Grupocategoria $grupocategoria)
{
    return $grupocategoria;
}

I followed the steps with a brand new 5.5 install and am able to reproduce the issue.

Good! Thanks for your reply!
Why it does need to match the route segment? Shouldn't it be more flexible if it needs to match only the type-hinted variable?

I'm guessing that the order route segments does not have to match the order of the action parameters, and they are instead matched by name. It makes sense that I could move things around in my routes without having to rewrite controller code. Or I could be guessing wrong.

@rodrigopedra It needs to match the variable name because the controllers have automatic resolution. which means laravel needs to know which model to bind. :)

The need to match the variable name is ok, it makes all the sense. What I couldn't understand is why it also needs to match the route segment.

Please tag the correct rodrigo when answering to this thread. The opener was @rodrigoroma not me.

I just ran into I think the same issue, I have a controller route that has a three different routes
Route::get('admin/event_type/{event_type}/event/{event}', 'EventController@show')->name('show_event_from_event_type');
Route::get('admin/event/{event}', 'EventController@show')->name('show_event');
Route::get('admin/event_template/{event_template}/event/{event}', 'EventController@show')->name('show_event_from_event_template');

The controller's signature is
public function show(Event $event, EventType $event_type = NULL, EventTemplate $event_template = NULL)

The project was Laravel 5.4.28, and when trying to upgrade to 5.5 I am getting parameters passed in the wrong order.  I code-dived and found the behavior was changed in this commit: https://github.com/laravel/framework/commit/6553e3371d228da5c6f1c0422327ffd19ffa183b
Not sure the best way to work around it other than to build new controller methods with the three different signatures.

My bad, that was not the commit that broke this, and I am not having this issue in 5.4.35 as the OP describes, so my issue is different.

Found my issue, at least, it was because I had a default value in my controller signature.

This is because of the way the ResourceRegistrar will singularize the parameter names: https://github.com/laravel/framework/blob/e294f05894610d5c5451db56aff37dfa371789bd/src/Illuminate/Routing/ResourceRegistrar.php#L345
You can disable this by setting the $singularParameters static parameter but it's undocumented I believe.
If you btw do a php artisan route:list you can see all the routes and their parameter names.


Add example using preconditioning.

Hey, I'm using a Newton-GMRES-algorithm for implicitly solving of large ODEs, based on Diffrax/Optimistix/Lineax – a pretty awesome set of libraries!
Right now I'm trying to figure out, how to create a Jacobi-preconditioner (or a more advanced one) for matrix-free computations. Using lx.diagonal(...) materializes the Jacobian and therefore is not possible for a vector of length ~500,000. Do you have any idea how to solve this problem?

This depends on the kind of operator you have. A tridiagonal linear operator, for example, can get the diagonal without further materialization!
However it's a classic (sad) fact in autodifferentiation that accessing the diagonal of a Jacobian requires computing the whole Jacobian.
You'll probably need to find a different approach for your problem.

Hey @patrick-kidger, awesome package! It would be indeed very nice to have an example using preconditioning.
Is there any project such as AlgebraicMultigrid.jl or pyamg running in JAX?
Otherwise, I could suggest an example using pyamg.multigrid for solving a Poisson 2D system, see e.g. here.

I don't thnk so! I'd be very happy to take a PR adding an example of this nature :)

Ok. Should this go into docs/examples/preconditioning.ipynb or similar? Are we happy to have a dependency on pyamg?

Yup, exactly there.
I think it'd be best to avoid a dependency on pyamg if at all possible.


Use super parameters in templates

https://github.com/flutter/flutter/issues/100575
To be submitted after:

https://github.com/flutter/flutter/pull/100905
https://github.com/flutter/flutter/pull/101074

It looks like this pull request may not have tests.

There are tests in place to validate that apps generated from these templates built and are analyzer error free. Those are still passing.

test-exempt: code refactor with no semantic change


Update parameter specification for macro signatures

Issue #, if available:
Partial fix of #304
Description of changes:
Updates grammar and examples to change macro signatures from [ (name type), ...] to (type::name ...).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PR says this is partial fix of #304; can you clarify what's remaining?

Sure. #304 says:

Update signatures to not include types or s-expressions around variables.

I didn't get rid of any types. I did get rid of the s-expressions around each parameter.


Not supported Georgian

Hello, why is there no Georgian language?

Hi, sorry for missing the Georgian language. The supported language list was generated about 1 year ago, it may be missing this language at that time. I'll regenerate a new list soon and release a new version. Thanks!

Released v2.3.0 on npm.


Differentiate two "Taxon detected" terms

Remove a clash with the other "Taxon detected".
change: "Taxon detected by microbiology test" and "Taxon detected by sequence match"?
Apply also to "Fungus detected" etc. I guess.
@zhengj2007

I will check the clinEpi. May need to use different labels. I mean how we name them in the terminologies not in the VEuPathDB ontology.

@wbazant These are currently place holder terms but we want to make these ontology terms. Please provide initial definitions for the taxon detected by sequence match terms (including subclasses like fungus detected).

@cstoeckert
how about:
Taxon detected: whether a method based on sequence match that was applied to reads coming from a sequencing assay of the sample has detected a taxon.
Fungus detected: whether a method based on sequence match that was applied to reads coming from a sequencing assay of the sample has detected a fungus.

label: taxon detected by sequence match
ontology parent: data item
definition: A data item that indicates whether a method based on sequence match that was applied to reads coming from a sequencing assay of the sample has detected a taxon.
definition source: MicrobiomeDB

label: fungal taxon detected by sequence match
ontology parent: taxon detected by sequence match
definition: A taxon detected by sequence match that indicates whether a fungal taxon was detected.
definition source: MicrobiomeDB
@wbazant please let us know if this and the above "taxon detected by sequence match" is OK and we will create them.

@cstoeckert
I've thought for a while what a difference between detecting a fungus vs. detecting a fungal taxon is, and whether a taxon is even something you can detect rather than only being something you can read about in a book. EDAM:Taxon is a child of EDAM:Organism name, and the definition makes it clear that a taxon is a name of a group - "The name of a group of organisms belonging to the same taxonomic rank." but  NCIT:Organism lists "Taxon" as a synonym. OBI:Organism does not have a synonym Taxon, but OBI:Organism has a synonym Taxon.
If you think that's a distinction worth keeping then maybe we could have "Organism detected by sequence match" and "Fungus detected by sequence match" ? Otherwise, the current version is okay too. Whatever goes in, could it also go in with the term from https://github.com/VEuPathDB-ontology/VEuPathDB-ontology/issues/246 ?

Great point @wbazant ! This is where ontological realism can be useful. What is actually being detected? If talking about a sequence match (data aligning with other data), then initially at least, it is not an actual fungus that was detected but rather a sequence with characteristics of a fungal sequence. An individual organism exists independent of sequence matching so it doesn't seem right to say there is a class of organisms whose nature may change based on the parameters of the match.
To clarify then the definition of "taxon detected by sequence match" might be improved to say: A data item that indicates whether a method applied to data coming from a sequencing assay of the sample has detected matching sequences associated with organisms of a particular taxonomic grouping. We might improve the label to be "Sequence match for a taxonomic grouping"
By extension, a "Sequence match for a fungal taxonomic grouping" would be: A sequence match by taxonomic grouping that indicates whether a sequence with characteristics of a fungal sequence was detected.

Hm, the method does actually try to detect a taxon! Each taxon is represented through a few sequences of marker genes, and different pieces of evidence are weighed up against each other on the level of whole taxa. The results aren't a list of sequences like in a BLAST match, but names of taxa.
How about this definition: A data item that indicates whether a method applied to data coming from a sequencing assay of the sample has detected a taxon through identifying sequences associated with organisms of a particular taxonomic grouping.
I wouldn't want the label changed to "Sequence match for a taxonomic grouping" - wouldn't it make people expect to see the match itself?

I'm OK with this one: A data item that indicates whether a method applied to data coming from a sequencing assay of the sample has detected a taxon through identifying sequences associated with organisms of a particular taxonomic grouping.
Also with keeping the 'taxon detected by sequence match' label where taxon is understood not be the organism but the name of a taxonomic grouping.

Great! This label + definition, and the current 'Taxon detected' getting changed to 'Taxon detected by microbiology test', would be a great resolution of this NTR.

@wbazant I've assigned these IRIs:
EUPATH:0009269 'normalized number of taxon-specific sequence matches'
EUPATH:0009270 'taxon detected by sequence match'
EUPATH:0009271 'fungal taxon detected by sequence match'

Also change labels accordingly:
animal taxon detected by sequence match
plant taxon detected by sequence match
protist taxon detected by sequence match

EUPATH:0009269 'normalized number of taxon-specific sequence matches' for issue #246
EUPATH:0009267 'taxon detected by sequence match' (reuse IRI)
EUPATH:0009268 'fungal taxon detected by sequence match' (reuse IRI)

The labels have been changed in microbiomedb.owl but still need to add to the VEuPathDB ontology


re-implement question

Hi,
Thanks to the author's great work, recently I would like to port your implementation into Keras, since I am not familiar with Pytorch.
Unfortunately, I have some issues when I finish the porting. For the standard baseline, the top1 acc I got is poor can only reach round 66%. I am using the ID loss + triplet hard loss. I also went through michuanhaohao's keras-reid repo.
If anyone can have a quick look and give any suggestions will be highly appreciated.
https://github.com/laihaotao/reid
Thanks!

solved by myself, anyway thanks


CI: Switch Jenkins jobs from Bionic to Focal

Working towards #219

This change is

Jenkins PR build: https://drake-jenkins.csail.mit.edu/job/RobotLocomotion/job/drake-external-examples/view/change-requests/job/PR-222/

I think a total purge of Bionic is correct.  I'll review the non-ROS parts of this.
+@EricCousineau-TRI for review of the ament- and catkin-related changes, please.


Bluetooth: host: direction: Add public API to set CTE TX params for adv.

Add HCI command: HCI_LE_Set_Connectionless_CTE_Transmit_Parameters.
Add public API function to run the command from application level.

Requested changes applied.
Also fixed similar issue in hci_df_set_cl_cte_tx_params.

Because no host code owner has reviewed the PR I've added two things:

DF initialization (separate commit in PR)
Checking if DF related features are supported by controller (change commits that provide HCI command wrapper function and public API)

@joakimtoe @jhedberg could you do a review?

@jhedberg @joerchan @Vudentz @carlescufi @cvinayak could you do a review?

@jhedberg @Vudentz could you do a review?  Your approval is missing.


Test visual output - grab browser screenshot (also on CI)

We should have tests to validate visual output of widgets and apps. These should be runnable both locally and on Travis. We'd want to be able to run the tests for each browser that we support. On CI it might be ok to do only FF, but would be nice to do all.
General options:

Selenium webdriver is sort of what flexx.webruntime does, but with more control. First time I tried it did not catch FF. Needs exes to be on PATH. Easy support for grabbing screenshots. For chrome it needs a chromedriver.
PhantomJS is a webkit-based headless browser.
I can make a webkit browser with high control via PyQt.
On Linux (and maybe also OSX) I can grab a screenshot from any process that I have the pid of using imagemagix. This could be a good quick way to allow testing on browsers locally.
On Windows I can do the same (via ctypes).

CI options:

Travis comes with FF installed and xvfb.
Appveyor probably has IE.
Chrome?
Saucelabs is a service where you can test all OS/browser combos (also mobile). Free for OSS. Can be linked to Travis CI. (pip install from repo to get py3k compat). Uses Selenium to remotely run the VM (run from Travis).
There is also browserstack.com (free for OSS)
applitools allows visual testing (semi-automated)

Eventually we'd want to test for several browsers in CI using saucelabs. For the short term, we should aim for a solution that can be run locally and also on Travis.
Approach:

In the main repo we have a directory with .py files that each describe a static app
These apps are exported to HTML and published via a git repo. The commit is tagged to make it corresponding to the commit of the main repo.
We run browser tests on these apps, and compare the results with images in yet another repo. If not on Travis, the system will prompt the user if a new app is present or if a comparison fails. The user can then mark the result as good or bad. Once a good image is present for each app, the images-repo is committed, and tagged with the same commit-id.

Note that we added some for of live test in #94. No screen captures, but still an actual connection with a browser, and some communication between the two.

I am feeling less interested in applying many visual tests, for two main reasons:

You'd be testing how a certain app looks. So if Phosphor changes its CSS a bit, or if we do in Flexx, we need to fix the test, update screenshots etc. In other words, these tests are likely a pain to maintain.
You'd only be testing how a certain app looks statically; the test does not even say that much.

Therefore, I think that the visual tests should be a small test suite, which draws a few layouts with widgets in different colors, so that we can verify on a range of browsers whether the basic layout elements (HBox, HPanel, Splitter, DockPanel) work. Also no screenshots, just test that the amount of e.g. red in the image makes sense.


AsyncEvent hangs forever

Hi Stream,
I am playing with your code and I found something strange. I created an HelloWorldVerticle that returns "Hello, World!" to every call; if I call it using the asyncEvent() function you provided it hangs forever; here a unit test that reproduces it, testAsync() works as expected but the testSync() freezes:
@RunWith(VertxUnitRunner::class)
class HelloWorldTest {

    private val vertx: Vertx = Vertx.vertx()

    @Before
    fun setUp(context: TestContext) {
        vertx.deployVerticle(HelloWorldVerticle::class.java!!.getName(), context.asyncAssertSuccess())
    }

    @After
    fun tearDown(context: TestContext) {
        vertx.close(context.asyncAssertSuccess())
    }

    @Test
    fun testAsync(context: TestContext) {
        val atc = context.async()
        vertx.createHttpClient().getNow(8080, "localhost", "/") { response ->
            response.handler { body ->
                context.assertTrue(body.toString().equals("Hello, World!"))
                atc.complete()
            }
        }
    }

    @Test
    fun testSync(context: TestContext) = runBlocking<Unit> {
        val atc = context.async()

        attachVertxToCoroutine(vertx)

        val response = asyncEvent<HttpClientResponse> {
                vertx.createHttpClient().getNow(8080, "localhost", "/") { it }
        }.await()

        response.handler { body ->
            context.assertTrue(body.toString().equals("Hello, World!"))
            atc.complete()
        }

    }

}

Hi
I have not yet run your code in my laptop, i guess the reason it coroutine's Context is wrong.
replace fun testSync(context: TestContext) = runBlocking<Unit> with
fun testSync(context:TestContext) = runVertxCoroutine { }

Hi
I tried but it fails with:
java.lang.IllegalArgumentException: Do not in the vertx context

Hi ufoscout
I have found problem that parameter of Handler should be passed to the getNow instead of  Block.
@Test
  fun testSync(context: TestContext) {
    val atc = context.async()

    attachVertxToCoroutine(vertx)

    runVertxCoroutine {
      val response = asyncEvent<HttpClientResponse> { vertx.createHttpClient().getNow(8080, "localhost", "/", it) }.await()
      response.handler { body ->
        context.assertTrue(body.toString().equals("Hello, World!"))
        atc.complete()
      }
    }
  }

Hi @stream1984
I don't understand your point. I executed your version of the test and it hangs exactly as mine.

Hi @ufoscout
The testSync can work in my laptop.
May i have your code again?

@ufoscout
I have make test to master you can pull it, and try it again in your env.
feedback is welcome.


fix: /etc/fstab adjustment condition

Don't look for compress=zstd as user may want to set this. Instead, set a flag so filesystem options are set on first boot instead.

Great improvement, thanks!


Update admin ui with ui changes along with frontier sdk.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.539%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5921

Relevant Lines:
14254

💛  - Coveralls


Vue methods not highlighting

This plugin wont highlight methods in .vue files. It's a pain to work like this. Unable to quickly find the methods. It should highlight like on VS Code. Javascript/Babel use in there

It works for me with latest ST version.


Disable logging by default.

Fixes https://github.com/go-redis/redis/issues/250#issuecomment-205871962


"Report a Vulnerability" link goes to 404 page on GitHub

Description:
In the page:
https://github.com/placemark/placemark/security
There is a link with the title "Report a Vulnerability"
When clicked on it brings you to a 404 page on Github
https://github.com/placemark/placemark/security/advisories/new
I notice there is no public Green "New Draft Security Advisory" button available as well
I am logged in with my normal Github account

Should be accessible now - apparently GitHub's reporting UI is private by default.

Perfect, works as expected. Closing issue!


Fix crash when running recipe from env var

os.getenvb requires the key to be bytes. A nice 1 character fix.
Fixes #383

Skipping review as this is a very localised change that fixes a known issues, my reviewers are all away, and it makes rebasing the other PRs much easier.


Describe inputs context in contexts page

Why:
Closes #11007

What's being changed:

Contexts page will describe inputs context introduced by reusable workflows feature.
Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Triage job failed but the failure doesn't seem related to changes by this PR:
Action triggered by PullRequest #11009
This project is configured at the repo level. Repo Owner:github, repo name:docs project #1
Attempting to create a card in column 11007039, for an issue with the corresponding id #754552642
#ERROR# HttpError: Resource not accessible by integration


Potential Data Race Identified in MatrixTransposeKernel

Potential Data Race Identified in MatrixTransposeKernel
Description:
My team and I have been working on a verification project for CUDA kernels called faial. faial has reported a potential data-race in mindspore/ccsrc/plugin/device/gpu/kernel/cuda_impl/cuda_ops/matrix_transpose_impl.cu on line 34.
output[b_stride + c * row + r] = input[pos];
       ^^^^^^^^^^^^^^^^^^^^^^

Our tool reports potential data-races unless we introduce some pre-conditions on kernel parameters col and row:

Parameter col must be positive: col > 0
Parameter row must be positive: row > 0
Parameters row and col must be equal: row == col

Do these conditions match your expectations?
We can submit a pull-request that adds the following pre-condition to your kernels. Would that be a welcome addition?
   if (col <= 0 || row <= 0 || row != col) {
     return;
   }

do you have pr url? we will review your pr ASAP

Here is the link to the pull request. https://github.com/mindspore-ai/mindspore/pull/266


feat!: Split create method into create and createById

Change
Split the create method on the FirefuelCollection into create and createById methods.
Reason
Sometimes I forget to pass in the DocumentId when creating a Document and an id gets auto-generated for me
Benefits

Semantic usage
No optional values to forget / not know is there

Solved by https://github.com/SupposedlySam/firefuel/commit/56aa3168e8cde77095665f318ea8c9ba268e9d24


Flow On-Chain Analytics Dashboard

Grant category
Developer service
Description
Similar to Dune. A general analytics tool for Flow blockchain.
Problem statement
Dune does not support Flow blockchain yet, and there is no other tool that provides similar services for Flow blockchain.
Proposed solution

Build a data warehouse that stores chain state
Build a platform where everyone could do some analysis on Flow blockchain activities

Impact

Everyone would be able to easily do some analysis on Flow blockchain.

Milestones and funding

Milestone
Deliverables
Timeline
Risks
USD requested

1 - Data Analysis P1; Initial Setup
Determine what data should be collected and how the data is preferred to be visualized by surveying the community; Setup the domain and the landing page
1 week
May need some support from Flow Team
3000

2 - Data Analysis P2
Determine the best way to collect/index data
1 week
May need to consult Flow Team and set up an access node
3000

3 - Data Storage
Determine the suitable table structure
2 weeks
Time
3000

4 - Job Implementation
Build up cloud infrastructure; Implement the corresponding ETL jobs and data pipeline
4 weeks
Time
30000

5 - Standalone Historical Event Indexer Opensourced
Refine the indexer job and make it opensource
1 week
Time
2000

6 - Visualization Tool Set up
Configure SuperSet
3 weeks
May need to tweak SuperSet a bit; may involve some visual desgin work
20000

7 - Integration Test
Dashboard being connected to data warehouse
1 week

3000

8 - Pre-build some dashboards
A few dashboards can be seen
1 week
Some bugs may pop out and some rework maybe needed
3000

9 - Open for testing
Platform are ready to be tested; bounty program is released
2 weeks
May encounter performance issue thus need to scale up the infra
6000

10 - Documentation
Docmentation is ready
1 week

3000

11 - Maintainence
Maintain Cloud Service; Support
3 months

18000

Team

Name
Role
Bio
Contact

Guisong Fu
Data Architect/Engineer
CTO of SoulMade; muti-year experience as Data Architect
<EMAIL_ADDRESS>

SkyOne
Senior Flow Blockchain Developer
Founder of 7DayReFundNFT; core developer of SoulMade
<EMAIL_ADDRESS>

Milestone completion

[x] Data Analysis (P1+P2)
[x] Data Storage
[x] Job Implementation
[ ] Standalone Historical Event Indexer Opensourced
[ ] Visualization Tool Set up
[ ] Integration Test
[ ] Pre-build some dashboards
[ ] Open for testing
[ ] Documentation
[ ] Maintenance

thanks for the submission @Guisong-Fu! we'll review this application soon

@Guisong-Fu we were just chatting about this and we want to see how you're thinking about using an existing indexing service for flow (as opposed to building your own in milestones 2-4). Currently, there's: flowscan, graffle, bitquery and flip side.
Maybe, you could explore with these team if they could offer access to their data warehouse? If not, we suggest you refine your application to account for the projected maintenance cost (given that the data collection will be large).

Hi @alxflw , thanks a lot for your suggestion!
We do have thought about collaborating with other teams as well. But according to our knowledge and experience, we may still have to set up our own indexer. It's mainly because that if we want to have complete data to analyse, we would need to index all the historical events by crawling all the available blocks, and none of the existing services seems to have done such kind of job, so we have to do it by ourselves. And we had done some tests, it seems that it won't be much more complicated to index the events from the newly coming blocks on our own compared with reading data from for example Flowscan's database and parse data from there. But indeed, maintaining the entire data collection pipeline maybe very costly. I have adjusted our application! Thanks for pointing it out!
We have already kicked off this project. And we just learned that for different ranges of blocks, we have to use different access node~ 😄  We will try to crawl all the blocks and extract all the data related to TopShot, and launch the bare bone platform so users could use to build dashboards for TopShot in the up coming weeks. What a milestone TopShot has achieved! 1 billion sales! 👍   I know many have been long for some more thorough analysis on Topshot. It would be fantastic if we could help!
We can always have a call at any time and have a deeper discussion. 😃

Hi @alxflw , we have developed a proof of concept. Please let me know if you would like to try our prototype and have a further discussion. 😃

Hey @Guisong-Fu, would love to check it out. You can find me on Discord: alx-flw.find#6198.
One thing that is coming up quite frequently is the need to index the state. I was wondering if you could build your indexer as a standalone opensource project, so other developers could re-use/improve it. Happy to chat more!

Hi @Guisong-Fu, thanks for the demo. We have a few follow up questions:

It would be great if the indexing project could a standalone opensource project that any other developer could use for their own need. Do you think you could refine the milestone to account for that? Essentially, milestone 1-4 would lead up to that deliverable

Can you confirm that SuperSet can be set up in a way that allows anyone without an account to access a shared dashboard? We'd consider this viz UI "public infrastructure" for Flow, so it should have the least friction for anyone to view

Could you extend milestone 1 to include surveying the community to see what data and visualization needs they have?

Could you specify the time you'd be able to maintain the project in milestone 10? I'd suggest we start with 3/6 months. Follow up grants for maintenance are possible.

Hi @alxflw , thanks a lot for all the great suggestions! 😄  We now have updated the proposal accordingly!

We have add this "opening up the indexer job as a standalone opensource project" as milestone 5, as it will take a bit refinement work. The idea is that everyone could use this repo as a template so to crawl/index the target events. We are also thinking about setting up a central place(e.g. a shared cloud storage) where users could upload/download the scanned data for other use cases. We can take this as our next step.

Yes, it can be open to the public audience(anonymous users, users who do not login) if the dashboard builders want so. Authentication and authorisation are two big topics and we didn't have time to take them in for our demo. But it can definitely can work in whatever ways we want.

Sure. And the idea is that everyone can build the dashboard in whatever ways they want, so we probably do not need to worry too much about how the data should be visualised. But sure, we can build some dashboards in the ways that community would like to see as examples.

Thanks for pointing it out! We now have set to 3 months. The main cost would be coming from the cloud infrastructure, according to our rough estimation, the infra would be around 1,500 USD per month. But it may go up if there are more needs.

Fantastic, thanks for the updates and confirmations!
WRT 2: It was pointed out to me that there was pre-existing work done on the indexing. Maybe you could see how that would impact your milestone 5? If the projects below already cover what is needed for indexing, maybe you could use them directly?

https://github.com/rayvin-flow/flow-scanner
https://github.com/rayvin-flow/flow-scanner-lib

wonderful, that makes a lot of sense! thanks for clarifying

Hi @alxflw , any update on this grant? 🙂  Thanks!

hi @Guisong-Fu, this proposal was just accepted! 🚀
I'll follow up with you with next steps on discord.

Hi, just dropping in here to spread some awareness - I just found this developer request in Flow's year-end grant summary and list of requests. It's mentioned that there are no tools like Dune that support Flow yet, but we actually do at Flipside. We have the complete chain indexed back to mainnet launch, with curated tables for easy blockchain querying and analysis.
You can see the tables by trying out our query editor at: flipside.new
Here are some recent dashboards to give you a gist of the analysis possible:

Flow NFT explorer: https://app.flipsidecrypto.com/dashboard/6ty6DJ
NFL All Day Deep Dive: https://app.flipsidecrypto.com/dashboard/nfl-all-day-round-3-digging-deeper-tuZIEV

Regarding the milestone steps, Flipside has completed every single one. This is not a request for grant, just wanted to make you aware that we've been working on this

@flipsidejack I just tried your app yesterday, I can honestly say, I am beyond amazed.

Given the time since this has been submitted I'm closing this down, half the milestones haven't been completed and it seems like work likely stopped or the need is no longer relevant. Please reach out to me if you think this was a mistake or you'd like to share what you're working on now and explore potential opportunities<EMAIL_ADDRESS>


state: Implement ability to request account balance info from Celestia Core node

Implement the ability for a Celestia light or full node to request account information from a Celestia Core node via gRPC for the purposes of submitting a transaction.
Optional: implement SubmitTx throttling for DoS protection for the trusted Celestia Core node.

Related to #265


Memory-aware autoscaling for worker nodes

Added support in autoscaling worker nodes according to memory utilization metric.

Superseded by #239


Customize folding using different source

Feature description
Would be great to provide an API and allow the binding of different folding expressions.  One scenario is a very large (auto-generated) code (100k ~ 200k LOC per file) I am using.
Describe the solution you'd like
e.g.
if filetype = 'go' then
  if  filesize < 6M then
   api.nvim_win_set_option(current_window, 'foldexpr', 'ufo#foldexpr()')
  elseif  filesize < 10M then
   api.nvim_win_set_option(current_window, 'foldexpr', 'tsfold#foldexpr()')
  else
   api.nvim_win_set_option(current_window, 'foldexpr', 'tsfold#foldexpr()')
  end
end
if filetype = 'lua' then
  api.nvim_win_set_option(current_window, 'foldexpr', 'treesitter#foldexpr()')
end

Additional context
No response

keep your other fold expr and use provider_selector to disable ufo when you want.
https://github.com/kevinhwang91/nvim-ufo/blob/a11c899ae12cc66b2d7f1c7bc99c506a5db113eb/doc/example.lua#L3-L18

well, I find the disable is not really working for me
  -- only enable for following filetypes
  local whitelist = {
    ["gotmpl"] = "indent",
    ["python"] = "lsp",
    ["html"] = "indent",
  }
  require("ufo").setup({
    fold_virt_text_handler = handler,
    provider_selector = function(bufnr, filetype)
      if whitelist[filetype] then
        return whitelist[filetype]
      end
      return ""  -- everything not listed in whitelist should be disabled
    end,
  })

When I edit lua code, ufo still enabled.

can't reproduce.
Run UfoInspect, will output:
Buffer: 19
Fold Status: start
Main provider:
Selected provider: nil

From the screen shot, I think ufo is disabled in config but not disable when I press `za/zm`

If selected provider is set after the foldingRanges come back, make sure the folds are applied by ufo.
No idea why your remap za/zm will make ufo request folding. Make sure that your foldmethod value is expected. The window opt will be inherent as unexpected.
You can enable debug mode by UFO_LOG=debug nvim and tail log tail -f ~/.cache/nvim/ufo.log

Do you mean disable virtual text? I can't see any data returned by providers from the log and your image.

The setup :    fold_virt_text_handler = handler,
But if ufo is not enabled, will virtual_text enable?

no selector ufo still enables virtual text. need detach. use UfoDetach and reset your foldtext option.
If a buffer is detached,  ufo does nothing for the buffer (only for the detached buffer).
Disable will disable all features.

ok, that make sense.


Question to Training routine for adversarial loss

Hi,
I have a question regarding the training of the GAN and namely I wonder why you don't call the optimizer from the generator as well as from the discriminator with zero_grad() at the beginning of the for loop and only call discriminator.zero_grad() and generator.zero_grad() respectively ? Unfortunately I'm still quite new to Pytorch and have always used Tensorflow before and could imagine that it amounts to the same thing ?
Further, I also wonder why, for example, you don't do something like G.train(False) and D.train(True) when updating the discriminator and vice versa ?
I hope you can answer my questions and I remain with kind regards
Niklas

You need to clear the gradient information of the previous iteration during each training, so use zero_grad().
Because the .detach() function is already used, there is no need to set the .train(False) variable.

Hi Lornatang,
thanks for the information

I just saw that over all always so far that deleting the gradients went via optimzer.zero_grad() and not via model.zero_grad(). So I was a bit confused. So can I assume that optimzer.zero_grad() and model.zeor_grad() have the same effect ?

Yes you're right

If you only have one model, they are equivalent

okay thanks :D, but here I have two models or ?

They are separate

Exactly, that's what I thought. Again another question: Is d_loss_sr -> backward(), d_loss_hr -> backward() equivalent to d_loss = d_loss_hr +d_loss_sr -> d_loss.backward

No.~ See GAN paper

Thank you very much for your quick help


[Feature Request] Docker support

A Docker image with cron built-in that works in a similar fashion as the GitHub Action, with the security benefit of being able to run it on your own hardware.

I have this running in a container, but cron running on the host machine.
https://github.com/bsyk/cloudflare-gateway-pihole-scripts/blob/auto/refresh.sh


no custom labels for custom forms?

I've quickly added support for the label tag in packages/nova-forms/lib/NovaForm.jsx
by replacing this:
const intlFieldName = this.context.intl.formatMessage({id:this.props.collection._name+"."+fieldName}); field.label = (typeof this.props.labelFunction === "function") ? this.props.labelFunction(intlFieldName) : intlFieldName;
with this:
if (!fieldSchema.label) { 	const intlFieldName = this.context.intl.formatMessage({id: this.props.collection._name+"."+fieldName}); 	field.label = (typeof this.props.labelFunction === "function") ? this.props.labelFunction(intlFieldName) : intlFieldName; } else 	field.label = fieldSchema.label;

I thought it would be confusing to have two ways to set labels (via react-intl and label). So I'm not sure we really need label?


Example to use the library in a browser

I noticed in the README that you use fs.readFileSync() which is a Node function.
How would that work in a browser?
Do you have a working example that can run in a browser?

Did you find a solution to your problem?
I'm looking for a way to use hunspell in the browser, but can't seem to find anything.

I'm also wondering if it is possible/ what sollution was found for this

bump

I solved this by creating a .json with the serialized dictionary in Node by doing something like this.
`let Spellchecker = require('hunspell-spellchecker')
let fs = require('fs')
let spell = new Spellchecker()
let dict = spell.parse({
aff: fs.readFileSync("./typo/dictionaries/sv_SE.aff"),
dic: fs.readFileSync("./typo/dictionaries/sv_SE.dic")
})
fs.writeFileSync("dict.json", JSON.stringify(dict))`
I then load the json file and parse it in the browser.
Seems to work well so far.

I see now that the issue is pretty old.
I had the same problem and forked it.


Can the hosted docker container also be built do support ARM please?

Basically the title, my server is running on ARM so would really love if it could be built with support for it, as currently rust complains as it was compiled for amd64

@WarlaxZ I just released a version for both platforms. Let me know how it goes!


Tracy calling InitThread() trigger error

Importing ztracy and calling InitThread causes following error:
$ zig build -Dztracy-enable=true run-game-of-life
.\deps\zig-gamedev\libs\ztracy\src\ztracy.zig:321:10: error: container '.ztracy.cimport:242:15' has no member called '___tracy_init_thread'
        c.___tracy_init_thread();
         ^

Seem like the library works otherwise so maybe this function has been renamed?

Could not find any mention of it in the release notes at the release page, but it seems like this function has indeed been removed


python312Packages.whitenoise: 6.6.0 -> 6.7.0

Diff: https://github.com/evansd/whitenoise/compare/refs/tags/6.6.0...6.7.0
Changelog: https://github.com/evansd/whitenoise/blob/6.7.0/docs/changelog.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 332063 run on x86_64-linux 1

3 packages failed to build:

pretalx
pretalx.dist
pretalx.static

11 packages built:

healthchecks
paperless-ngx
python311Packages.flask-common
python311Packages.flask-common.dist
python311Packages.whitenoise
python311Packages.whitenoise.dist
python312Packages.flask-common
python312Packages.flask-common.dist
python312Packages.whitenoise
python312Packages.whitenoise.dist
tandoor-recipes

Result of nixpkgs-review pr 332063 run on x86_64-linux 1

14 packages built:

healthchecks
paperless-ngx
pretalx
pretalx.dist
pretalx.static
python311Packages.flask-common
python311Packages.flask-common.dist
python311Packages.whitenoise
python311Packages.whitenoise.dist
python312Packages.flask-common
python312Packages.flask-common.dist
python312Packages.whitenoise
python312Packages.whitenoise.dist
tandoor-recipes


Character stats are too low after omnicite

Describe the bug
After using omnicite, a characters stats are not the maximum. Consider halloween odetta:
Expected max stats (per wiki):

Actual max stats:

On branch
develop live 27/12/2022
To Reproduce
Steps to reproduce the behavior:

Use omnicite on 4* character

Expected behavior
Max stats correct
Additional context
Looks like we're missing the last 70MC bonus

Stats still appear to be incorrect

Probably fixed by #87


Feature: Supports definePreset async

Clear and concise description of the problem
async definePreset can be help default developers dynamically introduce dependencies.
The actual place of use is here
and the dynamic import is here
Suggested solution
I tried to handle this asynchronous behavior in the resolvePreset phase, but it ended up pointing to the constructor of a class, so it was unsuccessful. I was thinking about whether to synchronize this behavior directly in the definePreset phase.
Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the README.md of using the package.
[ ] Already used the Interactive Docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Maybe We should be await it in the plugin and not in unocss.
Emmm. But It's that can be a feature in future?

Complete in #4268


is the filter very sensitatve to background noise?

Yuxin, thanks for the great work. I'm using your package and has been worked out the online conversation mode based on you gui version. The only problem I have is the filter seems doesn't work well.
If I turn off the filter, it runs normally but it can not recognize out when nobody is speaking. It works good though when I keep talking. But If I turn on the filtering, it will filter out all the recorded content and regarded it is nobody even when I keep talking. So I wondering if the filter is too sensitivate to the background noise?
Or if there is any trick to make it work good?

What I did now is I will recorde the background noise first, then I will talk. Not matter do the enroll or do the online converstation.

The filter is meant to filter out the noise and silence, but its parameters may not work well under different noise environment.
Recording the background noise and letting the filter model know about the noise may help sometimes.

thanks! yes, it works better after tuning the parameter. In addition, I need to record the background noise right before I do the testing each time, right？ Seems not work well if I use previous background noise .

I'm not sure about that. But if noise is changing over time it'll be better to record noise more often.


Manually set media_path in MySQL console, afterwards [ErrorException] unserialize(): Error at offset 0 of 28 bytes on php artisan koel:sync

Because attempting to sync from web GUI results in Unknown error, I tried to sync koel using the console. However, when attempting to run php artisan koel:sync on the command line, the command complains that media_path is not set and terminates.
Knowing just enough MySQL to get into trouble, I attempted to set the media_path value manually in the MySQL console. I went to the settings table in the koel database, and set the value of media_path to '/home/koel/Music/'.
Unfortunately, that didn't solve the issue, and I think I broke something else. Perhaps it was not in the right data format? Now, when attempting to run 'php artisan koel:sync', the following output begets:

  [ErrorException]
  unserialize(): Error at offset 0 of 28 bytes

I definitely think I messed up the data format. @phanan How can I fix this? What would be the MySQL command that I can use to set the path properly in the correct data format? 😸
Many thanks!
P.S: Is there a command line option for specifying the media_path on sync? I looked through the docs, and the .env file, but didn't find any 😢

Update - I found an earlier (working) version of the koel database, and it appears the format is like this:
+------------+------------------------------------------------+
| key        | value                                          |
+------------+------------------------------------------------+
| media_path | s:38:"/home/koel/Music"; |
+------------+------------------------------------------------+

Here's the comparison between the working MySQL database entry, and the nonfunctional one:
Working
mysql> describe settings;
+-------+--------------+------+-----+---------+-------+
| Field | Type         | Null | Key | Default | Extra |
+-------+--------------+------+-----+---------+-------+
| key   | varchar(255) | NO   | PRI | NULL    |       |
| value | text         | NO   |     | NULL    |       |
+-------+--------------+------+-----+---------+-------+
2 rows in set (0.00 sec)

Broken (my current version)
mysql> describe settings;
+-------+--------------+------+-----+---------+-------+
| Field | Type         | Null | Key | Default | Extra |
+-------+--------------+------+-----+---------+-------+
| key   | varchar(191) | NO   | PRI | NULL    |       |
| value | text         | NO   |     | NULL    |       |
+-------+--------------+------+-----+---------+-------+
2 rows in set (0.00 sec)

I definitely think the problem is in the varchar(191 value, but I have no idea how to fix it 😭

For your interest, s:38 means a string with 38 characters. See https://stackoverflow.com/a/14298662.
Don't modify the database directly. For now though, you can empty the value and then try again via the admin panel.

Thank you. I fixed the database by recreating it and running php artisan koel:init, but once again the original error holds. Attempting to scan /home/koel/music/ results in Unknown Error. I can't find anything relevant in Nginx's error.log, and attempting to sync from the console results in the same media_path problem that lead me into this mess.

Nevermind. I just invoked chmod -R 777 /home/koel and it works now. I'll lock down the permissions later.


Enable to show selecting rects when having keyboard input modifier

PickerNode needs showing selecting rects when having keyboard input modifier.

Fix minor bug in gmshio cmakelist


FormatException: Unexpected character (at character 1)

FormatException: Unexpected character (at character 1)
I got this error after calling a 404 status code expected API.
To Reproduce
Steps to reproduce the behavior:

Call this API https://fakestoreapi.com/productsk using dio

Expected behavior
It must show a 404 error in the console not stuck in the interceptor.
Screenshots

Version:

Flutter Version: 3.7.11
OS: Android
Chucker Flutter Version:  1.5.0

@navneet-singh-github Thank you for fixing this issue. I have merged your PR and latest changes would be available on pub.dev under 1.5.1.
As a gesture of appreciation, I have added you in README.md 👏.

Thankyou 😀


Feat: Add depandabot

Describe the feature
Proposal: DependaBot Integration for GitHub
Description: The DependaBot Integration for GitHub is a powerful tool that automates dependency management within GitHub repositories. It keeps project dependencies up to date by continuously monitoring for new releases and automatically creating pull requests to update outdated dependencies. This ensures repositories stay secure, stable, and aligned with the latest improvements in the open-source ecosystem.
Features:

Automated Dependency Updates: DependaBot scans the project's dependencies, identifies outdated versions, and automatically creates pull requests with updated dependency versions.
Continuous Monitoring: DependaBot continuously monitors dependency repositories, promptly detecting new releases and notifying repository maintainers.
Customizable Update Policies: Repository maintainers can define their own update policies, specifying how frequently and to what extent dependencies should be updated.
Version Constraint Management: DependaBot respects version constraints defined in project configuration files (e.g., package.json or requirements.txt), ensuring compatibility while upgrading dependencies.
Detailed Reports and Insights: DependaBot provides comprehensive reports and insights on dependency updates, including release notes, changelogs, and compatibility information.

By integrating DependaBot into GitHub repositories, development teams can significantly streamline their dependency management process, reduce security risks, and maintain a well-maintained and up-to-date project.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

@MonalikaPatnaik thanks for giving me a chance i'll add a bot quickly


Do not pull dotnet updates from internal feed.

PR Summary
We've been getting an error in our GitHub actions because we are attempting to update dotnet from an internal feed but the url to do so is not configured. We should not be pulling from an internal feed.

PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

The -bnot test failed again 😦

cannot convert the "ns_9c3a4441a0e243e2b1e3e1b274e881a6.E_sbyte" value of type "System.String" to type "System.Type".

Re-running the test.


Bump contour to 1.14.0

/kind enhancement
This patch bumps contour version to 0.14.0.
/cc @dprotaso

/retest

It's unclear why kind e2e tests don't appear in the checks

it's running here: https://github.com/knative-sandbox/net-contour/actions/runs/726251451

there we go


fix operation name regex

The cases without a prefix   space didn't work with the previous regex. This fixes that and adds those as test cases.


baremetal: fix forget init lockman pkg

这个 PR 实现什么功能/修复什么问题:

是否需要 backport 到之前的 release 分支:

3.2
/cc @wanyaoqi
/area baremetal

Codecov Report

Merging #6578 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6578      +/-   ##
==========================================
- Coverage    7.17%    7.16%   -0.02%
==========================================
  Files         647      647
  Lines      109213   109213
==========================================
- Hits         7831     7820      -11
- Misses     100782   100794      +12
+ Partials      600      599       -1

Flag
Coverage Δ

#aFlag
7.16% <ø> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/cloudcommon/cronman/cronman.go
48.83% <0.00%> (-5.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b859eea...8ebabd6. Read the comment docs.

/lgtm
/approve


make crate compile- and testable when offline

removed dependency that could not resolved when offline because it is
never downloaded because there is already a newer version of the same
package

ack


Injecting command including pipe "|"

I have an issue where the BIGSSH node will not accurately inject a command payload (from an external node) when a pipe ("|") is used to process the output of the initial command. All simple/single commands work fine when injected.
Example: "whois xxx.xxx.xxx.xxx | grep netname"
IF I enter the command into the BIGSSH node directly it outputs correctly, however if inject a command to the node as an argument, it fails. I particularly need to inject this from outside BIGSSH due to the IP address not being static.
Grateful for assistance. Thanks in advance.

Hello, I've made a special version of bigssh for you :-)
I'll now be possible to send a json value as a payload and set the command to a template string
I'm having dinner right now, will publish after !

Published.

You legend!! Thanks so much for spending the time on it (and the nodes in general). I'm about to head to work, but will try test tonight 👍

Time for movie before night here, you'll tell me if it's ok
Have a nice workday!

Thanks! Dumb question, however there is no update in the Node-RED palettes for BIGSSH. Do i need to do a manual NPM install?

my pleasure, I used to npm update to get the latest. I've published it, should work

One last question, are you able to share the flow pictured above so i can learn how the bigline and bigstatus nodes function?

Just done :-)

You are amazing. I shall mark this issue as closed 👍


code CLI ignores controlUrl

When installing an extensions with code --install-extension, users can freely install extensions which are malicious, which is not possible from the UI.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.69.1
OS Version: macOS 13

Steps to Reproduce:

Change your product.json's controlUrl to this gist.
Open a terminal inside of VS Code
Execute code --install-extension ms-python.python

Expected behavior
The CLI either refuses to install these extensions or warns the user.
Actual behavior
➜  ~ code --install-extension ms-python.python
Installing extensions...
Installing extension 'ms-python.python'...
(node:35176) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Electron --trace-deprecation ...` to show where the warning was created)
Extension 'ms-python.python' v2022.10.0 was successfully installed.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Can you please let me know which extension you are trying to install that is malicious and VS Code allows it from CLI?

@sandy081 that would be any extension list that I tried and exists in the Marketplace, for example JacobeanResearchandDevelopmentLLC.vscode-scxml-preview installs just fine although not allowing me to install via the UI


remove proxy default route handler name

Issues associated with this PR
fix #2307
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

@fibbery perfer static initializing from my side, it could be simplier and simplier is better.

I think this way is also ok,  what do you think

Hello, @fibbery . As @doujiang24 said, perfer static initializing

done

Hello, @fibbery . How about renaming this PR to allow custom proxy default route handler name?

Maybe it's a question of my expression, this PR is LGTM, what I want to confirm is if there is a better name that reflects what this PR does?
Because as we can see, after the PR changes, it doesn't remove anything, it just allows setting a variable with higher priority to override the default name when adding.


Relax criteria

We don't have 1000 results per topic, which could affect recall.
cat results/topics2017-pmid.trec_results | cut -c1-2 | sort | uniq -c | sort -n
Relax must criteria so that more docs are retrieved. Possibly related to #89.

Actual counts:
   7 13
  16 15
  19 29
  49 14
  51 24
 121 28
 134 11
 248 16
 288 3
 292 1
 336 20
 598 12
 767 6
 822 18
1000 10
1000 17
1000 19
1000 2
1000 21
1000 22
1000 23
1000 25
1000 26
1000 27
1000 30
1000 4
1000 5
1000 7
1000 8
1000 9

Changing must queries to should with boost 2 worsened results from 0.7693 to 0,5672.
A synonym API (#85) could be used instead.


Mathjax right-click menu is obstructed by cells

Environment data

VS Code version: 1.63.2
Jupyter Extension version (available under the Extensions sidebar): v2021.11.1001550889
Python Extension version (available under the Extensions sidebar): v2022.0.1814523869
OS (Windows | Mac | Linux distro) and version: linux (debian sid)
Python and/or Anaconda version: conda 4.11.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Jupyter server running: Local

Steps to reproduce

Lauch an interactive jupyter interpreter.
Print something that would render as mathjax.
Run some command so that it would show in the panel right below the cell with mathjax.
Right-click the mathjax.

Expected behaviour
Should show its right-click menu, superimposing it over the jupyter cell below so that the full right-click menu is visible and clickable.
Actual behaviour
The right-click menu is rendered below the jupyter cell, thus making a big chunk of it invisible and unclickable.

Copyable code:
from sympy import symbols, exp
a = symbols("a")
x = symbols("x")
b = 1/ (1 + exp(-1 / exp(x)))
b

On my platform, it can't even be right clicked and show the MathJax menu:
Version: 1.64.2
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:00:58.347Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.3.0

@rebornix assigning to you as this was assigned to me when this was transferred.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


revert osd_fsid zapping in shrink osd

This requires ceph-volume zap by osd_fsid feature that isn't available in ceph prior to 12.2.11.
RHCS 3.2z2 will ship with ceph luminous 12.2.8 so shrink-osd is broken.
Since these commits introduced a regression for 3.2z2 we should revert them and introduce them back for RHCS 3.3 once 3.2z2 is GA.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1702311

jenkins test luminous-centos-non_container-shrink_osds

jenkins test luminous-centos-container-shrink_osds

jenkins test luminous-centos-non_container-shrink_osd

jenkins test luminous-centos-container-shrink_osd


Chinese API need to be updated

CreateDynamicSecret V2
https://github.com/Azure99/GenshinPlayerQuery/issues/20#issuecomment-913179474
API Path Change
https://github.com/Azure99/GenshinPlayerQuery/issues/20#issuecomment-913167967

https://github.com/thesadru/genshin.py/issues/8


[Bug Fix] Fixing double expression

Fixed #332 by removing duplicate ADD_SELECTABLE_UNIT in selectable_units.cpp.

此bug已在 #316 中解决

Yeah, it has been solve previously


No module file found

Hi Sir.
there is no module in dist folder even i have extracted the zipped folder.
Please help thanks

Recompile from sources?

It is in the dist folder.
You can also install via gittio:
gittio install yy.tidialogs


Computed Fields not properly included

Prerequisites

[x] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[x] Checked that your issue isn't already filed.
[x] Checked if no PR was submitted that fixes this problem.

Versions

PHP version: 7.2
Laravel version: 5.7.15
Nova version: 1.2.0
Package version: 1.1.1

Description
Computed fields are only included for certain resources, but not others. Haven't been able to determine why.
Steps to Reproduce
Example:

In Nova: https://dsc.cloud/sparkdev/Screen-Shot-2018-12-17-11-22-20.32
In Excel: https://dsc.cloud/sparkdev/Screen-Shot-2018-12-17-11-23-36.26

Expected behavior:
All the field values to be added into the export.
Actual behavior:
Computed fields not properly added into the export.
Additional Information
This seems to happen when there's pagination involved (exporting about 200 items)

Will do, thanks @patrickbrouwers !

Seems to be working with 1.1.2, thank you!


All https outbound traffic fails with SSL self-signed certificate error

Summary
My single node microk8s instance suddenly lost outbound connectivity - all outbound https traffic from pods seems to be redirected to the internal ingress controller and fails.
The host server itself is still working as expected and can access the same https endpoints without any issues.
From within a pod:
root@testpod:/# curl www.google.com

<title>404 Not Found</title>

404 Not Found

nginx

root@testpod:/# openssl s_client -showcerts -connect www.google.com:443
CONNECTED(00000003)
depth=0 O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate
verify error:num=18:self signed certificate
verify return:1
depth=0 O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate
verify return:1
---
Certificate chain
 0 s:O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate
   i:O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate
-----BEGIN CERTIFICATE-----
MIIDbzCCAlegAwIBAgIQfVmeS+o1GJDB8p5mO4PeqjANBgkqhkiG9w0BAQsFADBL
...<shortened for brevity>...
i+CAFosgizPTJ5MMYbEp5yeeJg==
-----END CERTIFICATE-----
---
Server certificate
subject=O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate

issuer=O = Acme Co, CN = Kubernetes Ingress Controller Fake Certificate

---
No client certificate CA names sent
Peer signing digest: SHA256
Peer signature type: RSA-PSS
Server Temp Key: X25519, 253 bits
---
SSL handshake has read 1443 bytes and written 386 bytes
Verification error: self signed certificate

I am running the latest stable MicroK8s v1.27.1 revision 5250 on a Ubuntu 20.04 LTS VM.
I have tried a microk8s reset which did not fix the issue.
microk8s status
microk8s is running
high-availability: no
  datastore master nodes: <IP_ADDRESS>:19001
  datastore standby nodes: none
addons:
  enabled:
    dns                  # (core) CoreDNS
    ha-cluster           # (core) Configure high availability on the current node
    ingress              # (core) Ingress controller for external access

I have done no configuration changes so it is super baffling, I have no idea what's caused this. Can you please help me troubleshoot and fix this somehow?
Introspection Report
inspection-report-20230517_185709.tar.gz

Resolved.
For anyone who comes across this, the issue was DNS ("it's always DNS"). Pods suddenly started inheriting my internal search domain in their /etc/resolv.conf file, which caused the internal k8s DNS resolver to return stuff like "www.google.com.lan.internaldomain.com" to the pods instead of forwarding the query to the DNS server that I set in coredns.
I'm still not sure what actually caused this, leading theory is that it was caused by this change to coredns behaviour https://github.com/canonical/microk8s-core-addons/pull/111
and it only broke my cluster today when snap decided to update microk8s? not sure.
I had set --resolv-conf=/etc/resolv.conf in /var/snap/microk8s/current/args/kubelet many many microk8s releases ago to make DNS work back then. To fix it today I had to set --resolv-conf="", this prevented the internal domain from being added to resolv.conf files in pods and fixed the behaviour I was seeing.


fix: Incorrect handling of date/time claims

Fixes #490
The current implementation treats date/time claims (i.e. iat, nbf, exp) as integers. This is contrary to the spec
https://tools.ietf.org/html/rfc7519#section-2 which states that "non-integer values can be represented".
Fix converts iat, nbf, exp and auth_time claim representations to double

Hi @RussKie, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

I've reinstated the "internals" back

@RussKie I am concerned about back-compat on this

What exactly is the concern?

This is clearly a breaking change (both binary and source), so this should/must wait until the next major version.

@PinpointTownes thanks for chiming in. @RussKie yes this is clearly breaking as users will have runtime  and compile time errors.
 What is the impact to customers of not returning a double? Will an attack occur?

@brentschmaltz this aligns MS's implementation with the spec
For more details please refer to the original bug description https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/490

It's important to note that this bug could be fixed without changing the public API, which would allow fixing it immediately without having to wait until the next major release (and you could even backport it to IM 4.5).
Short-term fix: treat exp/nbf/iat/auth_time internally as double values, but keep exposing them as int (add a tiny check to ensure it doesn't overflow).
Long-term fix: update the public API to expose long (to prevent the year 2038 bug) or decimal/double if you think it's worth supporting decimal values.

What is the best way to go forward?

@RussKie @PinpointTownes the short term fix would work and would be non breaking. We could also, truncate before converting to int.  2038 is a long way away.

@PinpointTownes @RussKie we truncated to int as suggested.


Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerA…

This reverts commit efee92bf02b55bee86848a9d0d291de58cb8412a.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

did efee92b introduce a regression? If so is this fix needed a cherry-pick into upcoming 2.60.0 release?

did efee92b introduce a regression? If so is this fix needed a cherry-pick into upcoming 2.60.0 release?

In some situations, yes, so yes please. can you cherry-pick (want a regression bug?)
Specific cause:
Spanner has a max number of 400 sessions in a session pool, where a session is used for a read or a write operation.
When using streaming pipelines on Dataflow with a high degree of parallelisation, where each work item can be reading from and writing to spanner, Dataflow will have up to 300 threads per worker, which potentially means 300 simultaneous read sessions, and 300 simultaneous downstream writes.
In some scenarios, this can lead to session pool exhaustion, followed by a worker failing due to this flag.

thanks. could you please open a cherry-pick PR, that is checkout release-2.60.0 branch, run git cherry-pick bcd785f, and open a PR with release-2.60.0 as the base branch, similar to #32663

thanks. could you please open a cherry-pick PR, that is checkout release-2.60.0 branch, run git cherry-pick bcd785f, and open a PR with release-2.60.0 as the base branch, similar to #32663

Done: #32702


Change labels for affiliations to reflect possibilities

Story
When I start adding the affiliations in a record, the labels cover the scope.

The label "UGent author" does not make sense with the info "external author" underneath
Right now, "UGent affiliations" does not cover the scope, as external affiliations will be in there at some point as well.

Screenshots

To be reworked


Compiled Dotnet files are missing a definition

Hello, I am using the UA-ModelCompiler in the attempt to create a prototype OPC UA Server using NodeSet2 files from the UA-Nodeset repository. I am trying to compile the NodeSets using the following command:
.\Opc.Ua.ModelCompiler.exe compile-nodesets
  -input C:\Repos\TestSoftware\OpcUaServer\NodeSets\
  -o2 C:\Repos\TestSoftware\OpcUaServer\NodeSets\Generated\
  -uri http://opcfoundation.org/UA/Machinery/
  -uri http://opcfoundation.org/UA/IA/
  -uri http://opcfoundation.org/UA/DI/
  -uri http://opcfoundation.org/UA/MachineTool/

The resulting files look good at first sight, however upon compilation I am getting the following issue:
CS0117	'BrowseNames' does not contain a definition for 'MachineryBuildingBlocks'
OpcUaServer C:\Repos\TestSoftware\OpcUaServer\NodeSets\Generated\MachineTool\UAModel.MachineTool.Classes.cs	6181

This result was testet with both the current master branch a366dea aswell as the 2.3.0 release tag.
Thanks for the help in Advance.

This is a known issue that requires an update to the Machinery nodeset.
PLease manually add the missing constant.

Allright thanks.


Handle ART Duplicate

Problem
The VisibleImpact database may have more than one patient_id associated with an ART number. When this happens a MultiplePatientsException is thrown in the lib/utils/VisibleImpactUtils.dart/_getPatientIdVisibleImpact method (which matches ART numbers to patient_ids on VisibleImpact). This means that it is not possible to

fetch viral loads
upload participant characteristics
upload notification preferences
change PE's phone number (which is just a re-upload of all notification preferences for all participants)

Solution
Try to find the right participant by matching birth_date, sex, mobile_phone (the variables are also returned by the GET /patient endpoint of the VisibleImpact API). If the conflict can still not be resolved this way inform the user via notification (flushbar and/or required action) so that they can take further action such as informing the study supervisor or the data clerk to update the entry on the database.
Optional: Show an interface to the user where they are presented with the list of duplicates and can then select the right one to resolve the conflict.
Resources

VisibleImpact API documentation

Solution: display errror message, and show on SwitchToolBox that there is a discrepancy.

Also only match by birth_date and gender.


How to contribute

Hi, sorry if I put these question here.
Do you accept any contribution? if you do, I can work on the Docs for a start. 😊

Hey @rachmadideni! Yes, absolutely - docs are a great place to start. Also, if you run into any issues or are unclear about how anything works, please let me know. Thank you so much for your help 🙏


11470

11470
General requirements

Information in the workshop is adequate and updated
Code is correct and working
Links are correct
Make sure you enter the help email link in your manifest.json
Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR

[Y] All filenames are lower case (including folders, images, files, etc.)
[Y] Filenames are descriptive
[Y] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
[Y] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
[ N] Image references in markdown contain an alternate text

@ecchol - In preparation for Oracle CloudWorld there is a GitHub freeze in place. We will only accept emergency PRs upon sending an email to<EMAIL_ADDRESS>including justification. If this is not urgent, please close this PR and create a new PR after the Oracle Cloudworld event.

Hello Kamryn ,
This is an urgent matter regarding the upcoming Hands-On Lab (HOL) sessions scheduled for September 18th and 20th. We have encountered an unexpected situation where a code freeze has been implemented on the workshop lab, preventing us from making further changes.
Given that we have been actively working on setting up the lab for the past month and have the HOL sessions just around the corner, we find ourselves in a challenging position. The successful completion of these sessions is of utmost importance, and we are reaching out for your assistance to ensure that the lab is published and ready in time.
We understand the constraints surrounding the code freeze, and we greatly appreciate your consideration of our predicament. If there is any possible way for us to receive guidance or support in publishing the lab despite the freeze, it would tremendously alleviate our current situation.
The HOL sessions on September 18th and 20th are crucial for our objectives, and we are committed to delivering a seamless experience to all participants. Your help in this matter would contribute significantly to the overall success of the workshop.
Thank you for your understanding and support during this time-sensitive situation. We look forward to your response.
Thanks
Rahul

From: Kamryn Vinson @.>
Sent: Monday, August 28, 2023 11:08 PM
To: oracle-livelabs/oci-migration @.>
Cc: Rahul Burnwal @.>; Mention @.>
Subject: [External] : Re: [oracle-livelabs/oci-migration] 11470 (PR #37)
@eccholhttps://urldefense.com/v3/__https:/github.com/ecchol__;!!ACWV5N9M2RV99hQ!OcdOJuoSBHheT4sKs-NQs5VJNbPERExb9XjaStQUy4xbX_Dbvctk-Pk3pWH7TtzwTqmXOGNlFmrRNTGRpwIl93HXtmI$ - In preparation for Oracle CloudWorld there is a GitHub freeze in place. We will only accept emergency PRs upon sending an email to<EMAIL_ADDRESS>including justification. If this is not urgent, please close this PR and create a new PR after the Oracle Cloudworld event.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/oracle-livelabs/oci-migration/pull/37*issuecomment-1696084736__;Iw!!ACWV5N9M2RV99hQ!OcdOJuoSBHheT4sKs-NQs5VJNbPERExb9XjaStQUy4xbX_Dbvctk-Pk3pWH7TtzwTqmXOGNlFmrRNTGRpwIlRavi4CY$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A7ADGQD76JQGGQ65ZHQNVTLXXTJQDANCNFSM6AAAAAA4BRKKUA__;!!ACWV5N9M2RV99hQ!OcdOJuoSBHheT4sKs-NQs5VJNbPERExb9XjaStQUy4xbX_Dbvctk-Pk3pWH7TtzwTqmXOGNlFmrRNTGRpwIlJwUyd-8$.
You are receiving this because you were mentioned.Message ID: @.***>

automatically closed


Update baseURL in example

The base url is incorrect in the example, it requires a prefix

I believe this failure is unrelated to my change?

No, thank you for a great project @timostamm :)


compress of UglifyJsPlugin cannot work

when i wirte as the following , the UglifyJsPlugin will remain stagnant with nothing to show. But i change to wirte with new webpack.optimize.UglifyJsPlugin() and i will work well. Is it a bug ?
var uglyPlugin = new webpack.optimize.UglifyJsPlugin({
compress: {
warnings: false
}
});

Hard to see anything obviously wrong. Could you reopen at Stack Overflow with more details?


feature 299 update login with tonomy

Update the Integration test so that it shows this flow

https://github.com/Tonomy-Foundation/Tonomy-ID-SDK/issues/300 this task have to update integration test

:tada: This PR is included in version 0.16.0-development.1 :tada:
The release is available on:

npm package (@development dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Rake task that adds JSON ELM to MAT packages.

bonnie:cql:add_json_to_package task takes a MAT package zip and builds a new one in the same directory that has the JSON ELM added. It handles the odd situations of older packages without clause level annotations by replacing the XML ELM with stuff from the translation service.
Pull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1156
[x] JIRA ticket links to this PR
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced. N/A
[x] Tests are included and test edge cases (N/A, This is a utility rake task that would be immensely burdensome to write tests for.)
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Code coverage has not gone down and all code touched or added is covered.

See front-end testing instructions for getting coverage for front-end tests
In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here: This is a utility rake task that would be immensely burdensome to write tests for.
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

[x] Automated regression test(s) pass N/A, doesn't change calculation code.

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA test links: N/A
[x] Justification for using JIRA tests: N/A
[x] JIRA tests have been added to sprint N/A, but this was used to update JIRA tests.

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA tests have been run and pass
[ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA tests have been run and pass
[ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree

Updated branch and made it so replacing the XML ELM is the default operation.


Integrate "Copy Link Button / Copy Frame or Page URL" extension to ArcWTF

So I finally experienced Arc when the devs at The Browser Company opened access to older processors. The "copy current URL" button seems like a nice feature to have, and luckily there's an extension for that on Firefox Add-Ons page!
Copy Link Button / Copy Frame or Page URL

[ ] find URL icon that matches the URL icon Arc uses (most likely a Fluent Design icon like what they did on the Library & New Tab button)
[ ] edit the SVG code so it supported Firefox icon theming
[ ] Integrate it into ArcWTF on the userchrome.css
[ ] Edit the "Customize Toolbar..." configuration on README

Will do it in September

I saw it issue and I wanna to help, so here are the first two steps, the rest a little later

I saw it issue and I wanted to help, so here are the first two steps, the rest a little later
copy-link icons.zip

Thank you for helping @NikitaTurbo!
Though I choose to use default Link icon from Fluent, instead of Fluent-ifying the extension icon.
And turns out edge-frfox already have it covered after all 😅 I'm reeeally sorry. Will do it now.


Workaround for *Server/*Client suffixes on RHEL

On RHEL machines, the $releasever yum/dnf variable may have a Server or Client suffix. Our .repo files use $releasever to switch between repositories for CentOS/RHEL 7 and 8, but (currently) don't have separate repositories for Client/Server variants.
This patch updates the repository URLs and hard-codes the release-version as a workaround; we should probably upload packages to multiple locations, or add redirects.
Addresses https://github.com/docker/for-linux/issues/1111

@silvin-lubecki @StefanScherer PTAL

/cc @tiborvass

Updated; PTAL

Thanks @thaJeztah SGTM.
How could we test this?
I tried it in a Vagrant box, in a fresh rhel7/8 machine in Azure, but got different errors. Probably because I'm not registered.
Now I was trying this ubi container image.
I have your install.sh on my local machine in the current directory:
$ docker run -it -v $(pwd):/rhel -w /rhel registry.access.redhat.com/ubi8/ubi:8.1 bash
[root@120fab24aa5c rhel]# subscription-manager register
Registering to: subscription.rhsm.redhat.com:443/subscription
Username: stefan.scherer
Password:
Password:
sh install.shThe system has been registered with ID: 6089510d-f1a9-459f-8053-207ae7004bce
The registered system name is: 120fab24aa5c
[root@120fab24aa5c rhel]# sh install.sh
# Executing docker install script, commit:
+ sh -c 'yum install -y -q yum-utils'
+ sh -c 'yum-config-manager --add-repo https://download.docker.com/linux/rhel/docker-ce.repo'
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
Adding repo from: https://download.docker.com/linux/rhel/docker-ce.repo
+ adjust_repo_releasever 8.1
+ case $1 in
+ releasever=8
+ for channel in "stable" "test" "nightly"
+ sh -c yum-config-manager '--setopt=docker-ce-stable.baseurl=https://download.docker.com/linux/centos/8/$basearch/stable' --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ sh -c yum-config-manager '--setopt=docker-ce-stable-debuginfo.baseurl=https://download.docker.com/linux/centos/8/debug-$basearch/stable' --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ sh -c yum-config-manager --setopt=docker-ce-stable-source.baseurl=https://download.docker.com/linux/centos/8/source/stable --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ for channel in "stable" "test" "nightly"
+ sh -c yum-config-manager '--setopt=docker-ce-test.baseurl=https://download.docker.com/linux/centos/8/$basearch/test' --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ sh -c yum-config-manager '--setopt=docker-ce-test-debuginfo.baseurl=https://download.docker.com/linux/centos/8/debug-$basearch/test' --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ sh -c yum-config-manager --setopt=docker-ce-test-source.baseurl=https://download.docker.com/linux/centos/8/source/test --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ for channel in "stable" "test" "nightly"
+ sh -c yum-config-manager '--setopt=docker-ce-nightly.baseurl=https://download.docker.com/linux/centos/8/$basearch/nightly' --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ sh -c yum-config-manager '--setopt=docker-ce-nightly-debuginfo.baseurl=https://download.docker.com/linux/centos/8/debug-$basearch/nightly' --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ sh -c yum-config-manager --setopt=docker-ce-nightly-source.baseurl=https://download.docker.com/linux/centos/8/source/nightly --save
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
+ '[' stable '!=' stable ']'
+ sh -c 'yum makecache'
Updating Subscription Management repositories.
This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.
Docker CE Stable - x86_64                                                                                520  B/s | 381  B     00:00
Errors during downloading metadata for repository 'docker-ce-stable':
  - Status code: 404 for https://download.docker.com/linux/rhel/7/x86_64/stable/repodata/repomd.xml (IP: <IP_ADDRESS>)
Error: Failed to download metadata for repo 'docker-ce-stable': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
[root@120fab24aa5c rhel]#

At least from what I see it still sometimes uses rhel instead of centos. 🤔

Ah, hm. I guess because we added s390x RHEL builds, it now also adds the RHEL repo, which complicates things a bit, because before (I think) we selected the CentOS package repo for RHEL.
Will have to fix that, otherwise s390x
will be broken.

closing as this should be fixed https://github.com/docker/for-linux/issues/1111#issuecomment-820381106


[data request] Add column "Performance burst" enabled/disabled

Hi,
Some EC2 instances provide baseline performance only on a limited timerange.
For instance T-type instances do not provide 1 vCore = 1 logical core (or HyperThread) because AWS use their "CPU burst" method to manage overcommitment.
https://www.slideshare.net/AmazonWebServices/deep-dive-on-amazon-ec2
Regarding storage, there is also some kind of "EBS burst" corresponding to the the star in the doc https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSOptimized.html
* These instance types can support maximum performance for 30 minutes at least once every 24 hours.
Would it please be possible to add this column as it can severely affect EC2 performance ?
NB: Thanks for your tool
Regards
JL

Thanks for the suggestion!
I think we already mention that information for the burstable instance types.
If you think it isn't enough please consider creating a PR with a proposed change and we'll gladly consider it.


kpromo pr will ignore all images unless specifying all flags

What happened:
When running kpromo to pr changes to manifests of new images, the pr subcommand will ignore the images.
What you expected to happen:
This command should notice the secified tags and include the images in the modified manifests.
kpromo pr --fork=puerco --interactive=true --tag="v1.21.12,v1.21.13-rc.0"

How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
If you run it specifying all flags, the PR goes through as expected:
kpromo pr --fork=puerco --interactive=true --tag="v1.21.12,v1.21.13-rc.0"  --reviewers="" --image="" --digests=""

Environment:
kpromo v3.4.1

/help
@kubernetes-sigs/release-engineering anyone wants to pick this up?

/assign
Let me take a dig.


Yii 4.0.1 - Editable in grid on bringing in data via ajax load not working.

I have a editable grid with columns that can be changed with a popup editable. On default load of data in the grid i can edit the data and the striped underline will show.
When there is no data by default and you bring data into the grid there is a solid blue line and you cant click the value to edit it in the editable popup.
I remember this being an issue that was fixed in an older version when you had to re-register the javascript.
Thanks

Has this been actioned on? quite an annoying bug. thanks

@lisps  @kongoon  @marsuboss  @rlucian Hi Guys, sorry to bother but im not sure how i can temporarily fix this problem. It happens when a grid is populated from no data to have some data and then the grid having the edible feature enabled. Im not sure if its a quick fix and i do understand you are very busy but any assistance would be grateful. Thanks alot

@hijarian  Hi Mark, was this ticket #954 that recently closed?

@jackkitley I think #954 and #949 (this ticket) are not related. However, you can check out latest master, containing the changes from PR #954 and see for yourself whether the editable correctly instantiates when the grid is being filled with data. If it's not, then this ticket is not closed.


Add support for Telegram 2FA password and handling flood-related errors

Great job!
One thing - password_label text should be shorter (15 characters long) in order not to shift Entry boxes, but it is not obvious. I will fix this line and add a necessary comment in the next commit.


How access the etc directory?

How can I make /opt/couchdb/etc accessible from outside of the docker container? I tried
/usr/bin/docker run ... -v /etc/couchdb_docker:/opt/couchdb/etc

with the two files local.ini and vm.args inside of the host directory. This doesn't work because CouchDB seems to need also a (self-created) default.ini at this place. I created such a file and then it works. But I suppose a better solution should be exist.
...Rolf

As of 2.0-rc4 you can and should put your custom config files in couchdb/etc/local.d
docker run ... -v /etc/couchdb_docker:/opt/couchdb/etc/local.d

That way default.ini doesn't get overwritten. Let me know if this solves your problem.

You say: That way default.ini doesn't get overwritten. This is true. But docker doesn't start, because  default.ini does not exist in the mounted host directory (unless I put it in). See the other issue ("Permissions problem #65"). This is a "chicken or egg dilemma" ;-)


feat(wip): add gnuplot_merit.go draft

Basically the same as #4, but in a golang file.

Looks amazing !  Do tell me when it's OK to merge !


[GOBBLIN-934] bug fix and refactor for handling new job  scheduling

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-934

Description

[x] Here are some details about my PR, including screenshots (if applicable):
scheduling job logic is broken in PathAlterationListenerAdaptorForMonitor

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: bug fix & refactor

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2785 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #2785      +/-   ##
============================================
+ Coverage     45.32%   45.34%   +0.01%
  Complexity     8858     8858
============================================
  Files          1894     1894
  Lines         70874    70855      -19
  Branches       7794     7792       -2
============================================
+ Hits          32123    32127       +4
+ Misses        35788    35763      -25
- Partials       2963     2965       +2

Impacted Files
Coverage Δ
Complexity Δ

...duler/PathAlterationListenerAdaptorForMonitor.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...lin/util/filesystem/FileSystemInstrumentation.java
85.71% <0%> (-7.15%)
3% <0%> (ø)

.../org/apache/gobblin/metrics/RootMetricContext.java
78.12% <0%> (-1.57%)
15% <0%> (-1%)

.../apache/gobblin/runtime/api/JobExecutionState.java
80.37% <0%> (+0.93%)
24% <0%> (ø)
:arrow_down:

...lin/restli/throttling/ZookeeperLeaderElection.java
72.22% <0%> (+2.22%)
13% <0%> (ø)
:arrow_down:

...in/java/org/apache/gobblin/cluster/HelixUtils.java
35.51% <0%> (+2.8%)
12% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e4f9a...1904728. Read the comment docs.