[Bug] 2 settings that need to be set at every restart (skin and destination folder)

Current Behavior
hi
everytime my container is restarted the skin need to be changed again.
and everytime i add a new file to be downloaded it keep using the $folder/ strategy instead of the $folder/ that i usually use, so i have to manually change every file that i add.
everything else i working as intended.
also i have externalised the /config file to a folder on my physical computer so every parameters should be saved.
Also i tried to shut the container, changed the skin manually in the config file but when it's started the default skin is loaded and the config file as been changed.
thanks
Expected Behavior
No response
Steps To Reproduce
No response
Environment

OS: Ubuntu desktop
OS version: 22.04.3 LTS
CPU: Intel(R) Core(TM) i7-8700 CPU
Docker version: 24.0.5
Device model:
Browser/OS: lastest firefox

Container creation
docker run -d
--name=jdownloader
--net=container:vpn-main
--ip <IP_ADDRESS>
-e TZ=America/New_York
-v /partage/jdownloader/config:/config:rw
-v /partage/DL/DDL:/output:rw
-v /partage/DL/Watch:/watch:rw
--restart=unless-stopped
--label=com.centurylinklabs.watchtower.enable=false
jlesage/jdownloader-2
Container log
[init        ] container is starting...
[cont-env    ] loading container environment variables...
[cont-env    ] APP_NAME: loading...
[cont-env    ] DISPLAY: executing...
[cont-env    ] DISPLAY: terminated successfully.
[cont-env    ] DISPLAY: loading...
[cont-env    ] DOCKER_IMAGE_PLATFORM: loading...
[cont-env    ] DOCKER_IMAGE_VERSION: loading...
[cont-env    ] GTK2_RC_FILES: executing...
[cont-env    ] GTK2_RC_FILES: terminated successfully.
[cont-env    ] GTK2_RC_FILES: loading...
[cont-env    ] GTK_THEME: executing...
[cont-env    ] GTK_THEME: terminated successfully.
[cont-env    ] GTK_THEME: loading...
[cont-env    ] HOME: loading...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: executing...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: terminated successfully.
[cont-env    ] INSTALL_PACKAGES_INTERNAL: loading...
[cont-env    ] QT_STYLE_OVERRIDE: executing...
[cont-env    ] QT_STYLE_OVERRIDE: terminated successfully.
[cont-env    ] QT_STYLE_OVERRIDE: loading...
[cont-env    ] TAKE_CONFIG_OWNERSHIP: loading...
[cont-env    ] XDG_CACHE_HOME: loading...
[cont-env    ] XDG_CONFIG_HOME: loading...
[cont-env    ] XDG_DATA_HOME: loading...
[cont-env    ] XDG_RUNTIME_DIR: loading...
[cont-env    ] XDG_STATE_HOME: loading...
[cont-env    ] container environment variables initialized.
[cont-secrets] loading container secrets...
[cont-secrets] container secrets loaded.
[cont-init   ] executing container initialization scripts...
[cont-init   ] 10-certs.sh: executing...
[cont-init   ] 10-certs.sh: terminated successfully.
[cont-init   ] 10-check-app-niceness.sh: executing...
[cont-init   ] 10-check-app-niceness.sh: terminated successfully.
[cont-init   ] 10-cjk-font.sh: executing...
[cont-init   ] 10-cjk-font.sh: terminated successfully.
[cont-init   ] 10-clean-logmonitor-states.sh: executing...
[cont-init   ] 10-clean-logmonitor-states.sh: terminated successfully.
[cont-init   ] 10-clean-tmp-dir.sh: executing...
[cont-init   ] 10-clean-tmp-dir.sh: terminated successfully.
[cont-init   ] 10-fontconfig-cache-dir.sh: executing...
[cont-init   ] 10-fontconfig-cache-dir.sh: terminated successfully.
[cont-init   ] 10-init-users.sh: executing...
[cont-init   ] 10-init-users.sh: terminated successfully.
[cont-init   ] 10-nginx.sh: executing...
[cont-init   ] 10-nginx.sh: terminated successfully.
[cont-init   ] 10-openbox.sh: executing...
[cont-init   ] 10-openbox.sh: terminated successfully.
[cont-init   ] 10-set-tmp-dir-perms.sh: executing...
[cont-init   ] 10-set-tmp-dir-perms.sh: terminated successfully.
[cont-init   ] 10-vnc-password.sh: executing...
[cont-init   ] 10-vnc-password.sh: terminated successfully.
[cont-init   ] 10-web-data.sh: executing...
[cont-init   ] 10-web-data.sh: terminated successfully.
[cont-init   ] 10-x11-unix.sh: executing...
[cont-init   ] 10-x11-unix.sh: terminated successfully.
[cont-init   ] 10-xdg-runtime-dir.sh: executing...
[cont-init   ] 10-xdg-runtime-dir.sh: terminated successfully.
[cont-init   ] 15-install-pkgs.sh: executing...
[cont-init   ] 15-install-pkgs.sh: terminated successfully.
[cont-init   ] 55-jdownloader2.sh: executing...
[cont-init   ] 55-jdownloader2.sh: terminated successfully.
[cont-init   ] 85-take-config-ownership.sh: executing...
[cont-init   ] 85-take-config-ownership.sh: terminated successfully.
[cont-init   ] 89-info.sh: executing...
    ╭――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╮
    │                                                                      │
    │ Application:           JDownloader 2                                 │
    │ Application Version:   n/a                                           │
    │ Docker Image Version:  23.06.1                                       │
    │ Docker Image Platform: linux/amd64                                   │
    │                                                                      │
    ╰――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╯
[cont-init   ] 89-info.sh: terminated successfully.
[cont-init   ] all container initialization scripts executed.
[init        ] giving control to process supervisor.
[supervisor  ] loading services...
[supervisor  ] loading service 'default'...
[supervisor  ] loading service 'logmonitor'...
[supervisor  ] service 'logmonitor' is disabled.
[supervisor  ] loading service 'logrotate'...
[supervisor  ] loading service 'app'...
[supervisor  ] loading service 'gui'...
[supervisor  ] loading service 'openbox'...
[supervisor  ] loading service 'xvnc'...
[supervisor  ] loading service 'nginx'...
[supervisor  ] loading service 'certsmonitor'...
[supervisor  ] service 'certsmonitor' is disabled.
[supervisor  ] all services loaded.
[supervisor  ] starting services...
[supervisor  ] starting service 'xvnc'...
[xvnc        ] Xvnc TigerVNC 1.13.1 - built May 16 2023 17:43:49
[xvnc        ] Copyright (C) 1999-2022 TigerVNC Team and many others (see README.rst)
[xvnc        ] See https://www.tigervnc.org for information on TigerVNC.
[xvnc        ] Underlying X server release 12014000
[xvnc        ] Wed Sep  6 19:19:36 2023
[xvnc        ]  vncext:      VNC extension running!
[xvnc        ]  vncext:      Listening for VNC connections on /tmp/vnc.sock (mode 0660)
[xvnc        ]  vncext:      Listening for VNC connections on all interface(s), port 5900
[xvnc        ]  vncext:      created VNC server for screen 0
[supervisor  ] starting service 'openbox'...
[supervisor  ] starting service 'nginx'...
[nginx       ] Listening for HTTP connections on port 5800.
[supervisor  ] starting service 'app'...
[supervisor  ] all services started.
[xvnc        ] Wed Sep  6 19:20:09 2023
[xvnc        ]  Connections: accepted: /tmp/vnc.sock
[xvnc        ]  SConnection: Client needs protocol version 3.8
[xvnc        ]  SConnection: Client requests security type None(1)
[xvnc        ]  VNCSConnST:  Server default pixel format depth 24 (32bpp) little-endian rgb888
[xvnc        ]  VNCSConnST:  Client pixel format depth 24 (32bpp) little-endian bgr888
[xvnc        ] Wed Sep  6 19:20:10 2023
[xvnc        ]  ComparingUpdateTracker: 0 pixels in / 0 pixels out
[xvnc        ]  ComparingUpdateTracker: (1:-nan ratio)
[xvnc        ] Wed Sep  6 19:20:44 2023
[xvnc        ]  ComparingUpdateTracker: 319.922 kpixels in / 228.448 kpixels out
[xvnc        ]  ComparingUpdateTracker: (1:1.40041 ratio)
[supervisor  ] SIGTERM received, shutting down...
[supervisor  ] stopping service 'app'...
[supervisor  ] stopping service 'nginx'...
[xvnc        ] Wed Sep  6 19:29:56 2023
[xvnc        ]  VNCSConnST:  closing /tmp/vnc.sock: Clean disconnection
[xvnc        ]  EncodeManager: Framebuffer updates: 1767
[xvnc        ]  EncodeManager:   Tight:
[xvnc        ]  EncodeManager:     Solid: 834 rects, 18.2097 Mpixels
[xvnc        ]  EncodeManager:            13.0312 KiB (1:5459.29 ratio)
[xvnc        ]  EncodeManager:     Bitmap RLE: 290 rects, 149.521 kpixels
[xvnc        ]  EncodeManager:                 9.04199 KiB (1:64.9707 ratio)
[xvnc        ]  EncodeManager:     Indexed RLE: 1.683 krects, 2.7347 Mpixels
[xvnc        ]  EncodeManager:                  288.024 KiB (1:37.157 ratio)
[xvnc        ]  EncodeManager:   Tight (JPEG):
[xvnc        ]  EncodeManager:     Full Colour: 2.027 krects, 10.0686 Mpixels
[xvnc        ]  EncodeManager:                  7.24422 MiB (1:5.3052 ratio)
[xvnc        ]  EncodeManager:   Total: 4.834 krects, 31.1626 Mpixels
[xvnc        ]  EncodeManager:          7.54705 MiB (1:15.7586 ratio)
[xvnc        ]  Connections: closed: /tmp/vnc.sock
[xvnc        ]  ComparingUpdateTracker: 111.356 Mpixels in / 20.3502 Mpixels out
[xvnc        ]  ComparingUpdateTracker: (1:5.47199 ratio)
[supervisor  ] service 'nginx' exited (with status 0).
[supervisor  ] stopping service 'openbox'...
[supervisor  ] service 'openbox' exited (with status 0).
[supervisor  ] stopping service 'xvnc'...
[xvnc        ] Wed Sep  6 19:29:57 2023
[xvnc        ]  ComparingUpdateTracker: 0 pixels in / 0 pixels out
[xvnc        ]  ComparingUpdateTracker: (1:-nan ratio)
[supervisor  ] service 'xvnc' exited (with status 0).
[supervisor  ] service 'app' exited (with status 0).
[finish      ] executing container finish scripts...
[finish      ] all container finish scripts executed.
[init        ] container is starting...
[cont-env    ] loading container environment variables...
[cont-env    ] APP_NAME: loading...
[cont-env    ] DISPLAY: executing...
[cont-env    ] DISPLAY: terminated successfully.
[cont-env    ] DISPLAY: loading...
[cont-env    ] DOCKER_IMAGE_PLATFORM: loading...
[cont-env    ] DOCKER_IMAGE_VERSION: loading...
[cont-env    ] GTK2_RC_FILES: executing...
[cont-env    ] GTK2_RC_FILES: terminated successfully.
[cont-env    ] GTK2_RC_FILES: loading...
[cont-env    ] GTK_THEME: executing...
[cont-env    ] GTK_THEME: terminated successfully.
[cont-env    ] GTK_THEME: loading...
[cont-env    ] HOME: loading...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: executing...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: terminated successfully.
[cont-env    ] INSTALL_PACKAGES_INTERNAL: loading...
[cont-env    ] QT_STYLE_OVERRIDE: executing...
[cont-env    ] QT_STYLE_OVERRIDE: terminated successfully.
[cont-env    ] QT_STYLE_OVERRIDE: loading...
[cont-env    ] TAKE_CONFIG_OWNERSHIP: loading...
[cont-env    ] XDG_CACHE_HOME: loading...
[cont-env    ] XDG_CONFIG_HOME: loading...
[cont-env    ] XDG_DATA_HOME: loading...
[cont-env    ] XDG_RUNTIME_DIR: loading...
[cont-env    ] XDG_STATE_HOME: loading...
[cont-env    ] container environment variables initialized.
[cont-secrets] loading container secrets...
[cont-secrets] container secrets loaded.
[cont-init   ] executing container initialization scripts...
[cont-init   ] 10-certs.sh: executing...
[cont-init   ] 10-certs.sh: terminated successfully.
[cont-init   ] 10-check-app-niceness.sh: executing...
[cont-init   ] 10-check-app-niceness.sh: terminated successfully.
[cont-init   ] 10-cjk-font.sh: executing...
[cont-init   ] 10-cjk-font.sh: terminated successfully.
[cont-init   ] 10-clean-logmonitor-states.sh: executing...
[cont-init   ] 10-clean-logmonitor-states.sh: terminated successfully.
[cont-init   ] 10-clean-tmp-dir.sh: executing...
[cont-init   ] 10-clean-tmp-dir.sh: terminated successfully.
[cont-init   ] 10-fontconfig-cache-dir.sh: executing...
[cont-init   ] 10-fontconfig-cache-dir.sh: terminated successfully.
[cont-init   ] 10-init-users.sh: executing...
[cont-init   ] 10-init-users.sh: terminated successfully.
[cont-init   ] 10-nginx.sh: executing...
[cont-init   ] 10-nginx.sh: terminated successfully.
[cont-init   ] 10-openbox.sh: executing...
[cont-init   ] 10-openbox.sh: terminated successfully.
[cont-init   ] 10-set-tmp-dir-perms.sh: executing...
[cont-init   ] 10-set-tmp-dir-perms.sh: terminated successfully.
[cont-init   ] 10-vnc-password.sh: executing...
[cont-init   ] 10-vnc-password.sh: terminated successfully.
[cont-init   ] 10-web-data.sh: executing...
[cont-init   ] 10-web-data.sh: terminated successfully.
[cont-init   ] 10-x11-unix.sh: executing...
[cont-init   ] 10-x11-unix.sh: terminated successfully.
[cont-init   ] 10-xdg-runtime-dir.sh: executing...
[cont-init   ] 10-xdg-runtime-dir.sh: terminated successfully.
[cont-init   ] 15-install-pkgs.sh: executing...
[cont-init   ] 15-install-pkgs.sh: terminated successfully.
[cont-init   ] 55-jdownloader2.sh: executing...
[cont-init   ] 55-jdownloader2.sh: terminated successfully.
[cont-init   ] 85-take-config-ownership.sh: executing...
[cont-init   ] 85-take-config-ownership.sh: terminated successfully.
[cont-init   ] 89-info.sh: executing...
    ╭――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╮
    │                                                                      │
    │ Application:           JDownloader 2                                 │
    │ Application Version:   n/a                                           │
    │ Docker Image Version:  23.06.1                                       │
    │ Docker Image Platform: linux/amd64                                   │
    │                                                                      │
    ╰――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╯
[cont-init   ] 89-info.sh: terminated successfully.
[cont-init   ] all container initialization scripts executed.
[init        ] giving control to process supervisor.
[supervisor  ] loading services...
[supervisor  ] loading service 'default'...
[supervisor  ] loading service 'logmonitor'...
[supervisor  ] service 'logmonitor' is disabled.
[supervisor  ] loading service 'logrotate'...
[supervisor  ] loading service 'app'...
[supervisor  ] loading service 'gui'...
[supervisor  ] loading service 'openbox'...
[supervisor  ] loading service 'xvnc'...
[supervisor  ] loading service 'nginx'...
[supervisor  ] loading service 'certsmonitor'...
[supervisor  ] service 'certsmonitor' is disabled.
[supervisor  ] all services loaded.
[supervisor  ] starting services...
[supervisor  ] starting service 'xvnc'...
[xvnc        ] Xvnc TigerVNC 1.13.1 - built May 16 2023 17:43:49
[xvnc        ] Copyright (C) 1999-2022 TigerVNC Team and many others (see README.rst)
[xvnc        ] See https://www.tigervnc.org for information on TigerVNC.
[xvnc        ] Underlying X server release 12014000
[xvnc        ] Wed Sep  6 19:29:58 2023
[xvnc        ]  vncext:      VNC extension running!
[xvnc        ]  vncext:      Listening for VNC connections on /tmp/vnc.sock (mode 0660)
[xvnc        ]  vncext:      Listening for VNC connections on all interface(s), port 5900
[xvnc        ]  vncext:      created VNC server for screen 0
[supervisor  ] starting service 'openbox'...
[supervisor  ] starting service 'nginx'...
[nginx       ] Listening for HTTP connections on port 5800.
[supervisor  ] starting service 'app'...
[supervisor  ] all services started.
[xvnc        ] Wed Sep  6 19:30:13 2023
[xvnc        ]  Connections: accepted: /tmp/vnc.sock
[xvnc        ]  SConnection: Client needs protocol version 3.8
[xvnc        ]  SConnection: Client requests security type None(1)
[xvnc        ]  VNCSConnST:  Server default pixel format depth 24 (32bpp) little-endian rgb888
[xvnc        ]  VNCSConnST:  Client pixel format depth 24 (32bpp) little-endian bgr888
[xvnc        ]  ComparingUpdateTracker: 0 pixels in / 0 pixels out
[xvnc        ]  ComparingUpdateTracker: (1:-nan ratio)

Container inspect
[
    {
        "Id": "e14d67dd7cb4e2769a28e0f4ab04602987f0314cdd9e7ce4f07ef027ff4b6a09",
        "Created": "2023-09-06T23:19:34.753237534Z",
        "Path": "/init",
        "Args": [],
        "State": {
            "Status": "running",
            "Running": true,
            "Paused": false,
            "Restarting": false,
            "OOMKilled": false,
            "Dead": false,
            "Pid": 22366,
            "ExitCode": 0,
            "Error": "",
            "StartedAt": "2023-09-06T23:29:57.410680646Z",
            "FinishedAt": "2023-09-06T23:29:57.281049799Z"
        },
        "Image": "sha256:f1b3bf3b57dbbee30e3cee81973c818d3bda5606c69086dff0fbc879d16b8bad",
        "ResolvConfPath": "/var/lib/docker/containers/b73c51c683fc84b253a4ddf15dec52f904591e20526b6a64b7ffadf2d479a338/resolv.conf",
        "HostnamePath": "/var/lib/docker/containers/b73c51c683fc84b253a4ddf15dec52f904591e20526b6a64b7ffadf2d479a338/hostname",
        "HostsPath": "/var/lib/docker/containers/b73c51c683fc84b253a4ddf15dec52f904591e20526b6a64b7ffadf2d479a338/hosts",
        "LogPath": "/var/lib/docker/containers/e14d67dd7cb4e2769a28e0f4ab04602987f0314cdd9e7ce4f07ef027ff4b6a09/e14d67dd7cb4e2769a28e0f4ab04602987f0314cdd9e7ce4f07ef027ff4b6a09-json.log",
        "Name": "/jdownloader",
        "RestartCount": 0,
        "Driver": "overlay2",
        "Platform": "linux",
        "MountLabel": "",
        "ProcessLabel": "",
        "AppArmorProfile": "docker-default",
        "ExecIDs": null,
        "HostConfig": {
            "Binds": [
                "/partage/jdownloader/config:/config:rw",
                "/partage/DL/DDL:/output:rw",
                "/partage/DL/Watch:/watch:rw"
            ],
            "ContainerIDFile": "",
            "LogConfig": {
                "Type": "json-file",
                "Config": {}
            },
            "NetworkMode": "container:b73c51c683fc84b253a4ddf15dec52f904591e20526b6a64b7ffadf2d479a338",
            "PortBindings": {},
            "RestartPolicy": {
                "Name": "unless-stopped",
                "MaximumRetryCount": 0
            },
            "AutoRemove": false,
            "VolumeDriver": "",
            "VolumesFrom": null,
            "ConsoleSize": [
                50,
                80
            ],
            "CapAdd": null,
            "CapDrop": null,
            "CgroupnsMode": "private",
            "Dns": [],
            "DnsOptions": [],
            "DnsSearch": [],
            "ExtraHosts": null,
            "GroupAdd": null,
            "IpcMode": "private",
            "Cgroup": "",
            "Links": null,
            "OomScoreAdj": 0,
            "PidMode": "",
            "Privileged": false,
            "PublishAllPorts": false,
            "ReadonlyRootfs": false,
            "SecurityOpt": null,
            "UTSMode": "",
            "UsernsMode": "",
            "ShmSize": 67108864,
            "Runtime": "runc",
            "Isolation": "",
            "CpuShares": 0,
            "Memory": 0,
            "NanoCpus": 0,
            "CgroupParent": "",
            "BlkioWeight": 0,
            "BlkioWeightDevice": [],
            "BlkioDeviceReadBps": [],
            "BlkioDeviceWriteBps": [],
            "BlkioDeviceReadIOps": [],
            "BlkioDeviceWriteIOps": [],
            "CpuPeriod": 0,
            "CpuQuota": 0,
            "CpuRealtimePeriod": 0,
            "CpuRealtimeRuntime": 0,
            "CpusetCpus": "",
            "CpusetMems": "",
            "Devices": [],
            "DeviceCgroupRules": null,
            "DeviceRequests": null,
            "MemoryReservation": 0,
            "MemorySwap": 0,
            "MemorySwappiness": null,
            "OomKillDisable": null,
            "PidsLimit": null,
            "Ulimits": null,
            "CpuCount": 0,
            "CpuPercent": 0,
            "IOMaximumIOps": 0,
            "IOMaximumBandwidth": 0,
            "MaskedPaths": [
                "/proc/asound",
                "/proc/acpi",
                "/proc/kcore",
                "/proc/keys",
                "/proc/latency_stats",
                "/proc/timer_list",
                "/proc/timer_stats",
                "/proc/sched_debug",
                "/proc/scsi",
                "/sys/firmware"
            ],
            "ReadonlyPaths": [
                "/proc/bus",
                "/proc/fs",
                "/proc/irq",
                "/proc/sys",
                "/proc/sysrq-trigger"
            ]
        },
        "GraphDriver": {
            "Data": {
                "LowerDir": "/var/lib/docker/overlay2/6e54e7aa446907a3d7bb3a03404d9f58c2a0887b5ac173497071be0171c3504b-init/diff:/var/lib/docker/overlay2/f661455587a64f43035764fb9441a8d24d5f0bad0a6241797393541de626cdae/diff:/var/lib/docker/overlay2/29351532e14970aa0cd9041cd79b37e36c48e53da789b91eb5ccedb4e0090625/diff:/var/lib/docker/overlay2/a650f26a7ac59cfc0edc88d6b0bbbaa9d66765779e1f24b29783ab842d948780/diff:/var/lib/docker/overlay2/5e94d663a860ac475c307b8c0db141446915846f9fae4d12b297cccfce3c05a3/diff:/var/lib/docker/overlay2/ad5ec6a889746bf921321753b4c5aa8b9b923385379e613147b1f6f64770d22f/diff:/var/lib/docker/overlay2/d8f509a492bc4418f43d70dcbd1433775a6ea98ede4303ce69648641a0d0ebdc/diff:/var/lib/docker/overlay2/b38b8ffdd6d57057d21cf4a63b1254202d12a16a584fd904c9dc14813f9bd3ac/diff:/var/lib/docker/overlay2/217dc8bca772e420781fe6fdf779fcbaff6e8d43fc87c93d1bf03543f7a76325/diff:/var/lib/docker/overlay2/1d36e91972e54ae29de75c59d4f0365a2111e5556d8f176d4f57851b2fb25ebc/diff:/var/lib/docker/overlay2/a6fbb95f125c3712254a277e26d489de5ddb9f6d74458108b19109aaf42df0fe/diff:/var/lib/docker/overlay2/8614fd352392eb2bedc466960cf95c0aee31cc81153bc0496d55ae6bb7ab9b29/diff:/var/lib/docker/overlay2/d112d6ef8f58a74d4efc1d82a31cc8fa8f4865a81989688259c9b151955a3810/diff:/var/lib/docker/overlay2/8524cd095d6e2ad4a895cc3dd8049b173178d4b00ea2fddb16319da55d27cab3/diff:/var/lib/docker/overlay2/2bfab6ab4f5e3294c8e63f481a6fad790ceca900b77c6e150e2772e4e82c8a8a/diff:/var/lib/docker/overlay2/9d79e541078f59b170a3a6849a642429cc2768dfbe1287d1e91cb17e9617cb84/diff:/var/lib/docker/overlay2/83c8986754e0f5055bc18c33fd5f6c7adbfdcfb9aff73f1f9766a39de00fd2ec/diff:/var/lib/docker/overlay2/31f1ce86890c6794bbbf2637f1f84ac9ac6b779781f8972036b74de670f24813/diff:/var/lib/docker/overlay2/cac662eae028c6f949f2994a3e893a22adaad92e47212bdbf42daa58d3194224/diff:/var/lib/docker/overlay2/d7015a3b6f81880c9b01604fe332622522355135243debee5294f50271606be8/diff:/var/lib/docker/overlay2/22f7895304fc03f1cf8c27a429e4b1da3355ec7acce64bf4e05f12911f703ea8/diff:/var/lib/docker/overlay2/4421669c8931410d2b70bacae6b850a05bb39e2f61305db82c99005c9a2ae44c/diff:/var/lib/docker/overlay2/c26421f301a7baa5c3bff40519b3c965d48ec7d78e3865b05e8cd2815aa5b431/diff:/var/lib/docker/overlay2/868cc896ff4c473d784492f33b4e1b6f1be6ce6ce0b224f394188815f7ef60ab/diff:/var/lib/docker/overlay2/000e80f1ab8edffa2d2b7527b17f24e0b4006d6088fe8da54960c2752aaf9ff3/diff:/var/lib/docker/overlay2/486b0c4f22796e347602cb5c91350fda083875ba445fd2abca946accb18fbdef/diff:/var/lib/docker/overlay2/f378a53bee663e34e846c12bc4c460b2e4097200ce23d30aa5cf0c6a8e932e04/diff:/var/lib/docker/overlay2/eb898616f3c74e0eaff1d14d578e4646fb266c913e4eb96e30dafd3f5f0d242d/diff:/var/lib/docker/overlay2/e79effe98866f503250f3a26419ab8608823c6815cb15fe353ed33552a880e3a/diff:/var/lib/docker/overlay2/bee9dea8ec965c847c0f1b5f6841d92b9da3677b2373a339f93b5b4b3395d9c6/diff:/var/lib/docker/overlay2/a9bf6dd682ea3d607563278fc0ba503eb56a7bfe59fd17c32ecfcfc49129bbfc/diff:/var/lib/docker/overlay2/26872b9ce75750606274d2e1797fb1c1c8589de674ed80aac131be953a405f43/diff:/var/lib/docker/overlay2/fcdf8fb037a91c93ff70dcd1465cc49b0f851fa3873e860a726c8abc1e252a3d/diff:/var/lib/docker/overlay2/edd8655da11110f622c0b943d644cf1abdd707c4c36cb359cfb31a760072a6df/diff:/var/lib/docker/overlay2/5e8df128f746bf407aeb9436544bf4c229a73c9bfeed014890dd7921f9dd7e9b/diff",
                "MergedDir": "/var/lib/docker/overlay2/6e54e7aa446907a3d7bb3a03404d9f58c2a0887b5ac173497071be0171c3504b/merged",
                "UpperDir": "/var/lib/docker/overlay2/6e54e7aa446907a3d7bb3a03404d9f58c2a0887b5ac173497071be0171c3504b/diff",
                "WorkDir": "/var/lib/docker/overlay2/6e54e7aa446907a3d7bb3a03404d9f58c2a0887b5ac173497071be0171c3504b/work"
            },
            "Name": "overlay2"
        },
        "Mounts": [
            {
                "Type": "bind",
                "Source": "/partage/DL/Watch",
                "Destination": "/watch",
                "Mode": "rw",
                "RW": true,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/partage/jdownloader/config",
                "Destination": "/config",
                "Mode": "rw",
                "RW": true,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/partage/DL/DDL",
                "Destination": "/output",
                "Mode": "rw",
                "RW": true,
                "Propagation": "rprivate"
            }
        ],
        "Config": {
            "Hostname": "b73c51c683fc",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "ExposedPorts": {
                "3129/tcp": {},
                "5800/tcp": {},
                "5900/tcp": {}
            },
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "TZ=America/New_York",
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/base/sbin:/opt/base/bin",
                "ENV=/root/.docker_rc",
                "USER_ID=1000",
                "GROUP_ID=1000",
                "SUP_GROUP_IDS=",
                "UMASK=0022",
                "LANG=en_US.UTF-8",
                "KEEP_APP_RUNNING=0",
                "APP_NICENESS=0",
                "INSTALL_PACKAGES=",
                "CONTAINER_DEBUG=0",
                "DISPLAY_WIDTH=1920",
                "DISPLAY_HEIGHT=1080",
                "DARK_MODE=0",
                "SECURE_CONNECTION=0",
                "SECURE_CONNECTION_VNC_METHOD=SSL",
                "SECURE_CONNECTION_CERTS_CHECK_INTERVAL=60",
                "WEB_LISTENING_PORT=5800",
                "VNC_LISTENING_PORT=5900",
                "VNC_PASSWORD=",
                "ENABLE_CJK_FONT=0"
            ],
            "Cmd": [
                "/init"
            ],
            "Image": "jlesage/jdownloader-2",
            "Volumes": {
                "/config": {},
                "/output": {}
            },
            "WorkingDir": "/tmp",
            "Entrypoint": null,
            "OnBuild": null,
            "Labels": {
                "com.centurylinklabs.watchtower.enable": "false",
                "org.label-schema.description": "Docker container for JDownloader 2",
                "org.label-schema.name": "jdownloader-2",
                "org.label-schema.schema-version": "1.0",
                "org.label-schema.vcs-url": "https://github.com/jlesage/docker-jdownloader-2",
                "org.label-schema.version": "23.06.1"
            }
        },
        "NetworkSettings": {
            "Bridge": "",
            "SandboxID": "",
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "Ports": {},
            "SandboxKey": "",
            "SecondaryIPAddresses": null,
            "SecondaryIPv6Addresses": null,
            "EndpointID": "",
            "Gateway": "",
            "GlobalIPv6Address": "",
            "GlobalIPv6PrefixLen": 0,
            "IPAddress": "",
            "IPPrefixLen": 0,
            "IPv6Gateway": "",
            "MacAddress": "",
            "Networks": {}
        }
    }
]

Anything else?
No response

everytime i add a new file to be downloaded it keep using the $folder/ strategy instead of the $folder/ that i usually use

Not sure what you are talking about.  Could you provide more detail about the setting you are talking about ?

Also i tried to shut the container, changed the skin manually in the config file but when it's started the default skin is loaded and the config file as been changed.

Could you share what setting you are changing ?

the output folder i am changing is this one
https://www.dropbox.com/scl/fi/ey7a10mrtz7ng112atqs7/output-settings.JPG?rlkey=d1z4a5410k6d41zn4q0nijc0p&dl=0
but no matter what i do, when i add a new download it show this
https://www.dropbox.com/scl/fi/jd1bhodcelqbctf8hg75e/output-1.JPG?rlkey=lrzs1uc5ar2t89ekude6b91ee&dl=0
about the skin, i tried to change this parameter in the advanced settings
https://www.dropbox.com/scl/fi/jsjaz1kdgop3p33fbf2vx/skin.jpg?rlkey=2t48lq9c21hk7qtdjvuf0ov3h&dl=0
i tried to change it in the config file "org.jdownloader.settings.GraphicalUserInterfaceSettings.json"
but it always end up the same way

the output folder i am changing is this one https://www.dropbox.com/scl/fi/ey7a10mrtz7ng112atqs7/output-settings.JPG?rlkey=d1z4a5410k6d41zn4q0nijc0p&dl=0 but no matter what i do, when i add a new download it show this https://www.dropbox.com/scl/fi/jd1bhodcelqbctf8hg75e/output-1.JPG?rlkey=lrzs1uc5ar2t89ekude6b91ee&dl=0

So you a trying to set something else then /output ?

about the skin, i tried to change this parameter in the advanced settings https://www.dropbox.com/scl/fi/jsjaz1kdgop3p33fbf2vx/skin.jpg?rlkey=2t48lq9c21hk7qtdjvuf0ov3h&dl=0 i tried to change it in the config file "org.jdownloader.settings.GraphicalUserInterfaceSettings.json" but it always end up the same way

Which value are you trying to set ?
This is not reflected in the information you provided, but are you sure that the DARK_MODE environment variable is not set to 1?  If dark mode is enabled, the theme is forced.

i want all my files to /output but everytime it goes to /output/, i have to manually change the destination for every packets
for the skin i'm trying to activate the FLATLAF_DRACULA skin, so i tried to change the "DEFAULT" value that is originally in the config file to "FLATLAF_DRACULA" as it is shown everytime i change it manually.
i never tried the dark_mode and i cant try it right now, but i ll do it later today to check

i want all my files to /output but everytime it goes to /output/, i have to manually change the destination for every packets

When adding a new file to download, JDownloader will always use the /output/<jd:packagename> destination format by default.  I don't think this is related to the fact that setting is lost after a restart.  Each time I add a file, the default format is used (even without restarting the container).

that s because the settings is not changed
i used to have jdownloader directly on my computer and when i changed the default folder it kept the settings
i could add 3 different files from different providers and they were put together in a folder called "miscellaneous files" and directly programmed to be downloaded to my ".....\download" without the jd:packagename

I think this answer is what you are looking for: https://board.jdownloader.org/showpost.php?p=457998&postcount=16

This is not the same thing as the setting mentioned in the link.
It's under Packagizer, rule 2.

nice it work great now :)
thanks for your time and your work


Mosaic Tile Server Should Not Require User ID

The mosaic tile server endpoint requires a user ID. The user ID is used to find the scene in S3 that is pre-tiled; however, this only works if all scenes for a mosaic are from the same user.
This was fine to get the server working, but is an optimization we will need to remove and not require since in most cases a mosaic will be made up of scenes from many users.

Currently there the user ID is being used in the ingest path for scenes. However there is nothing that ties the two entities in the database. The most useful outcome is to actually store the S3 URI of ingested scenes in the Scenes table.
Until that happens I am going to start hard coding user id as rf_airflow-user

That sounds good, that's my fault when I manually created it


[HUDI-3912] Fix lose data when rollback in flink async compact

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
Currently when rollback a compact action it just revert the request instant to inflight
But in CompactionCommitSink it keep the preview compact event when rollback
It will cause commit too fast before all next real compact events come and use wrong fileId
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

cc @danny0405

Thanks for the contribution @wxplovecc , i have left some minor comments.

Thanks for the contribution @wxplovecc , i have left some minor comments.

done


Task - type material - new record

I have a student, who does not have administrative privileges. Every time he opens a "Type material" task from Edit taxon name page. He has a pop up message "You have to sign as an administrator". Besides this message, everything seams to work correct.

The only step is to open the the page?
Nothing more is clicked on or added?
The student can still change data?

Opening the page is triggering the pop up.
No other clicking.
It seams does not affect data editing process.
And I cannot replicate this with my data editing privileges.

@proceps can you replicate this in sandbox?

Backend issue, probably already fixed. Reopen if not


How to Use NlogViewer in Nlog 5.0 with Fluent Configuration API , Better with MVVM pattern

As NLog Update to Nlog 5.0, How to use  Fluent Configuration API to binding NlogViewer ?
like this way:
NLog.LogManager.Setup().LoadConfiguration(builder => {
   builder.ForLogger().FilterMinLevel(LogLevel.Info).WriteToConsole();
   builder.ForLogger().FilterMinLevel(LogLevel.Debug).WriteToFile(fileName: "file.txt");
});

You can create a NLog target-instance, and assign the wanted properties:
NLog.LogManager.Setup().LoadConfiguration(builder => {
   builder.ForLogger().FilterMinLevel(LogLevel.Debug).WriteToTarget(new NLogViewerTarget { Address = "udp://localhost:4000" });
});

Notice that NLogViewerTarget uses a non-standard Log4J XML output, and it is recommended to instead use ChainsawTarget
See also: https://github.com/NLog/NLog/wiki/Fluent-Configuration-API

Thank you, and how to bing NlogViewer in wpf userControl ?
<Grid>
    <nlog:NlogViewer x:Name="logCtrl" TimeWidth="AUTO" LoggerNameWidth="0" LevelWidth="auto" ExceptionWidth="auto" MessageWidth="auto" ScrollViewer.VerticalScrollBarVisibility="Auto" />
</Grid>

No idea. It is not part of this NLog-repo
Maybe try Stackoverflow or look at existing  examples.
Sent from my Galaxy
-------- Original message --------
From: dongfengxin @.>
Date: 22/12/2022 10:22 (GMT+01:00)
To: NLog/NLog @.>
Cc: Rolf Kristensen @.>, Comment @.>
Subject: Re: [NLog/NLog] How to Use NlogViewer in Nlog 5.0 with Fluent Configuration API , Better with MVVM pattern (Issue #5132)
Thank you, and how to bing NlogViewer in wpf userControl ?

—
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/5132#issuecomment-1362602864, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HBALNQOUPDOQKYTY43WOQMUDANCNFSM6AAAAAATER4BWU.
You are receiving this because you commented.Message ID: @.***>

Sorry about the confusion. Now I understand you are looking for advice with the NlogViewer WPF-Control.
The NLogViewer-nuget-package comes with its own target, which you can setup like this:
NLog.LogManager.Setup().LoadConfiguration(builder => {
   builder.ForLogger().FilterMinLevel(LogLevel.Debug).WriteTo(new NlogViewer.NlogViewerTarget());
});

But I don't know anything about now to integrate the nlog:NlogViewer-control. Think StackOverflow or self-study will be the best approach.

@dongfengxin Maybe https://github.com/dojo90/NLogViewer is a better alternative ?

Closing question, since not for this NLog-repo. Probably better to try StackOverflow.com or self-study.


[BEAM-1149] SimpleDoFnRunner observes window if SideInputReader is nonempty

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @amitsela
This is a quick fix. There is some redundancy with PushbackSideInputDoFnRunner.
Confirmed that the following run - which is only run on postcommit - fails on master and succeeds with this PR:
mvn --batch-mode --errors verify -pl runners/spark \
    -Prunnable-on-service-tests -Plocal-runnable-on-service-tests \
    -D test=ParDoTest \
    -D mdep.analyze.skip=true \
    -D failIfNoTests=false \
    -D forkCount=0 \
    -D runnableOnServicePipelineOptions='[
      "--runner=TestSparkRunner",
      "--streaming=false",
      "--enableSparkMetricSinks=false"
    ]'

LGTM.


Core: Add support for extracting select values in to variables

select top 1 @var = t.col
from table t

Should be a runtime error if not all select items are assignments. Ie one cannot mix select items and assignment items
Should not yield any result set
In case of multiple rows returned, use the last Tuples value as assignment values

Closed by 892a212e87402deb09149a33dab5e66cc9ea702a


Canarybank-new Azure: Create domain and TLS certificates

Acceptance:
https://canarybank-azure.hexademo.org


Update how-to-bootstrap-an-edge-kubernetes-cluster.md

I just deleted repeated phrases
Signed-off-by: 85humberto<EMAIL_ADDRESS>

I just deleted repeated phrases
Signed-off-by: 85humberto<EMAIL_ADDRESS>


Zone tooltips float outside map frame when zooming in

When viewing a continent's map and hovering over a zone, tooltip info is placed in the bottom left corner of the map frame. However, when zoomed in, this tooltip moves with the inner scrolling frame, causing it to extend outside of the main map frame.
https://github.com/user-attachments/assets/6088a008-7d8b-44b7-b259-7523418910da

Looks like this is an interaction with the LevelRange-Turtle mod, so not really a bug with Magnify. Sorry.


Can't build on linux, compile errors

Hi,
I cant get compiled this package under linux, I got a bunch of errors, mostly these:
Compiling Swift Module 'SeeURL' (6 sources)
/swift/Mailer/Packages/SeeURL-1.0.0/Sources/SeeURL/cURL.swift:167:2: error: unknown attribute 'asmname'
@asmname("curl_easy_setopt") public func curl_easy_setopt(curl: cURL.Handler, option: cURL.Option, param: UnsafePointer<UInt8>) -> CURLcode
^
/swift/Mailer/Packages/SeeURL-1.0.0/Sources/SeeURL/cURL.swift:167:9: error: expected declaration
@asmname("curl_easy_setopt") public func curl_easy_setopt(curl: cURL.Handler, option: cURL.Option, param: UnsafePointer<UInt8>) -> CURLcode
    ^
/swift/Mailer/Packages/SeeURL-1.0.0/Sources/SeeURL/HTTPClient.swift:11:12: error: missing required modules: 'CJSONC', 'CStatfs', 'CUUID'
 import SwiftFoundation
       ^

My swift version is the latest:
# swift --version
Swift version 2.2-dev (LLVM 3ebdbb2c7e, Clang f66c5bb67b, Swift 42591f7cba)
Target: x86_64-unknown-linux-gnu

What should I do to make it working?

so.. Yeah, this stopped working on Swift 2.2. The issue is that important cURL functions, are macros, so the @asmname("symbol_name") could find hidden (or private) functions. Right now I don't see any solution to this issue. Maybe a simple C header file would suffice?

Added a Swift compatibility header. Since the helper functions are inlined, no need to compile separate library.


Unable to load the app

App gives this error when trying to build the project.

I tried with the same instructions earlier but it still throws errors with the latest npm and node versions.

Therefore suggestions from #113 is seems to be not working for the latest npm and node versions.


chore(v5-connect-endpoint): update example with v5 connect endpoint

Current coverage is 28.65% (diff: 100%)

Merging #6 into development will decrease coverage by 0.53%

@@           development         #6   diff @@
=============================================
  Files                2          2
  Lines              161        164     +3
  Methods              0         31    +31
  Messages             0          0
  Branches            11         14     +3
=============================================
  Hits                47         47
- Misses             114        117     +3
  Partials             0          0

Powered by Codecov. Last update dfa8d44...0092859


Installation problem: 'google' module not found

when import cirq, it pull "google" module not found? can you give me some hints how to deal with this?

Short answer: run pip install -r requirements.txt
I ran into this message also when I tried to run some of the scripts intended for development, but with only the regular (non-dev) setup instructions completed.
Incidentally, the link to "development environment" on that page is broken, which is issue #850. I missed the dev setup instructions because of this, which is probably also what happened with @ywlds above.
I don't remember what sequence of commands I ran to get the error, but basically I just tried running something, and whatever missing module it complained about, I installed it. Eventually, I got the "module google not found" message and was unable to proceed further. I then realised that there was actually an additional page for dev setup. Running pip install -r requirements.txt fixed the problem.

I should link to the working development setup doc.
This issue can probably be closed, unless those instructions don't fix this problem for you.

Closing as we think this was the problem.  Please reopen if following the development setup doc doesn't work.


Add first spec draft

If it’s not checked in, then the default branch can’t host GitHub pages (which is how the proposal template does it).

OK, sorry, I don't want to argue about the right way to do CI (some other projects use a different branch, but that can be annoying to set up), but I think we need the HostEnsureCanCompileStrings call, and this will be good to land.

Let's not check in index.html, since that should instead be built by CI.

I was just following the template instructions 😭

Works in Safari
I still can’t drag or click buttons in Firefox (83), there are errors in the console.
In all three browsers: The shaded area doesn’t rotate when I click rotate (and also the selected are changes aspect ratio when I rotate. In the image below I selected ~a square).

Let's not check in index.html, since that should instead be built by CI.

I was just following the template instructions sob

Please, carry on, sorry for my confusing comment.


Optional citations

resolves #820
Description

We simply replace citations with empty strings when it is disabled and allow normal flow when enabled,
User Impact

In the "Advanced" tab when an assistant bot type is selected, the user will see a new "citations enabled" setting.
Demo

Docs

I'll update once merged

Codecov Report
Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

apps/service_providers/llm_service/runnables.py
87.50%
1 Missing :warning:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


Objects within Schema

I want to do the following (regular Mongoose):
let personSchema = new mongoose.Schema({
  id: String,
  address: {
    street: String,
    streetnumber: Number,
  }
});

With Typegoose:
class Person extends Typegoose {
  @prop()
  id: string;

 @prop()
  address: {
    street: string;
    streetnumber: number;
  }
});

But it says: Object is not a primitive type nor a Typegoose schema (Not extending it).
If i do like described in the readme(creating a seperate class for address) Typegoose would create a new schema and a seperate document for address and that is not what i want to do.

Hello, thanks for your interest in Typegoose. Yes I'm afraid currently sub schemas are supported only. This is an already requested feature so it is on the list.

@szokodiakos I'm afraid you won't be able to do that. Typescript reflection is very limited and the only way to have sub documents is by defining sub schemas using classes.

Any estimation for this? Is this complicated and do you have time for this enhancement?

@MickL Sorry I don't have the time for research and implementation right now. Currently I'm just trying to fix critical issues, and review other folks PRs.
@19majkel94 that is bad news, then maybe there isn't a viable solution currently at all. 😞

@MickL there's a workaround that i just found.
You could create a class for your address and use it in person.

@MickL there's a workaround that i just found.
You could create a class for your address and use it in person.
All you have to do, is cast it to an object while setting it before saving.
Here's an example:
class Address {
  public street: string
  public streetnumber: number
}

class Person extends Typegoose {
  @prop()
  id: string;

 @prop()
  address: Address
});

export let PersonModel = new Person().getModelForClass(Address)

// Here the code before saving

const person = new PersonModel()
const address = new Address()
address.street = "some street"
address.streetnumber = 42
person.address = Object.assign({}, address)

No need to cast it back to Address when loading, the only trick is the Object.assign({}, address) which creates an object containing the fields in address.
Hope that helps you!

This issue should be closed? The work around is to add a new class and use that class as type. Another option is the use object (works with latest typegoose)

What if I have a Ref in a nested object? For example, I have an Environment model:
class EnvironmentModel extends Typegoose {
  @prop()
  name: string;
  //... other properties below
}

and then I have an Organization model that references that Environment model in a nested object. The desired schema is:
const OrganizationSchema = new mongoose.Schema({
  name: { type: String, required: true, index: { unique: true } },
  suborganizations: [{ type: mongoose.Schema.Types.ObjectId, ref: 'Organization' }],
  settings: {
    environments: [{ type: mongoose.Schema.Types.ObjectId, ref: 'Environment' }]
  }
} // exported with mongoose.model('Organization', OrganizationSchema)

I've tried the following:
class OrgSettings {
  environment: Ref<EnvironmentModel>[]
}

class OrganizationModel extends Typegoose {
  @prop({required: true, index: true, unique: true })
  name: string;

  @arrayProp({ itemsRef: OrganizationModel })
  suborganizations: Ref<OrganizationModel>[];

  @prop()
  settings: OrgSettings
}

This doesn't appear to work and I'm curious if I'm misunderstanding something.

Anyone come up with a good solution for the problem mentioned above?

This seems to work in version 6.0.0

@Ben305 this can be closed because this should work in 5.9.0+


avoid overwrite in reading screen for win32_rand

Thanks to Jo Hornsby for reporting this.
[extended tests]

Hmm, hold on, what's up with the CIs?

Yup, broken.  (I no longer have a windows machine).  I'll put the WIP label on.

Okay, this now builds and passes.  It contains code that the Jo suggested.  I am not sure it is right, but according to my reading of the MSDN docs, it is at least not (very) wrong.  Can someone with Win32 API experience comment on this, maybe @dot-asm ?

The commit message is misleading because no cast can affect the outcome. The essence of the modification is to ensure that colour table is not generated, isn't it?

Red cross from Travis seems unrelated (it seems "crashed" before compiler ran). BTW, [extended tests] are meaningful only in master branch. Released branches run all tests unconditionally. Now I'm not sure of protocol here. Are approval granted based on code modification alone, or would it be appropriate to insist on modified commit message? Modification is simple and compact, so no harm in squashing commits in the process ;-)

A reviewer can ask for comment/commit changes just as well as they can ask for other changes.  In this case, I totally agree with you, the PR morphed over time.  I pushed an updated squashed commit which I think addresses the issue.

Thanks for your help, @dot-asm.  Merged to 1.0.2.


The default current-directory is / on mac when launched from the dock

current-directory get .
"/"

When launched from the terminal as ./factor -run=listener:
IN: scratchpad current-directory get .
"/Users/erg/factor"

When launched from the terminal from the bundle executable:
erg@jobim ~/factor $ [master*] ./Factor.app/Contents/MacOS/factor
IN: scratchpad current-directory get .
"/Users/erg/factor"

Not a bug necessarily, revisit later maybe.


How to specify the start end dates shown in chart

Even if the chart ranges from 10/1 - 10/5 for example, the gantt chart automatically seems to add days before and afterward. Is there a way to adjust it?

draw_resize_handles()- checkout this method update_bar methods called here

Is there a documentation somewhere to look up these methods?

Is there a documentation somewhere to look up these methods?

Date padding is intentional.


Add styles to set height on mounting node

Feature Request
Description
A common issue people have come across with getting started with the terra-application-layout is that the mount node height is set to auto by default. This is a default style browsers set for divs.
Usually the mount node looks something like

. This pattern of using

 is influenced by the official reactjs docs on rendering an element into the dom. It's also used in create-react-app.
Proposed updated
I propose we add a style for #root in terra-base to set the mount node to height: var(--terra-base-root-height, 100%);. This would allow us to handle this use-case people run into by default in our base styles. I'd make the height a variable as some teams want the ability to use height: auto; I believe for dynamically sized iframe pagelet concerns.

Talked about this in scrum. There was concern raised about styling things outside of what we render/control with react components. Planning to close this issue.


Fix possessive adjective in hooks2 "time traveller obsessed with finding his/her descendant"

Simplify gender attribution and reduce duplication Removed "medusa" table and inline it in race instead, change stats attribution to medusa to compensate for default female stats modifications.
Closes #2
I looked as hard as I could and couldn't find other "gender" inconsistencies other than that one

This change is

It's fine if Medusa are shorter, after all they were human or elf females that got cursed to become medusas, so it makes sense that they'd have the same height.


Cron schedule expression DOES NOT support conditionals

I have azure function which we need run only on first working day of the month or first monday of the month for which I was planning to use cron expression like so
0 0 12 1-7 *  * [ "$(date '+\%a')" == "Mon" ]
But looks like it's not supported , can you please confirm?
References:
https://superuser.com/questions/428807/run-a-cron-job-on-the-first-monday-of-every-month
https://www.switchplane.com/editorial/2009/how-to-run-a-cron-job-on-the-first-weekday-of-the-month/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5527c3b-a5da-c73d-66c2-20d96003ff7c
Version Independent ID: 42154c7b-b0e0-26db-79bc-3f1673c48e40
Content: Timer trigger for Azure Functions
Content Source: articles/azure-functions/functions-bindings-timer.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@prabhushrikant The expression you are using is actually part of the command that runs (crontab runs) rather than the cron expression itself.

Cron Expression
Command

0   12  1-7 *   *
[ "$(date '+%a')" = "Mon" ] && echo "It's Monday"

So, this won't work here.
Like what the command does, you could simply validate the current datetime in your function and return without processing when not required. But this would still cause your function to run every day.
A better approach would be to use a Logic App with a Recurrence Trigger that calls your function. Your function would have to be a HTTP function for the Logic App to call it.

@prabhushrikant Just following up here... Hope my previous comment clears things up.

@prabhushrikant Hope my previous comment clears things up.
Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Feature Request: Have ConnectionString property use backward compatible keywords without spaces

Is your feature request related to a problem? Please describe.
Connection strings returned from the SqlConnectionStringBuilder are not always compatible with System.Data.SqlClient connection strings, even when they are using features supported by both. This is because the Microsoft.Data.SqlClient  connection string introduced new aliases that are not supported by the System.Data.SqlClient connection string, such as Application Intent= instead of ApplicationIntent= (notice the space). There are many other keywords updated to include spaces that System.Data.SqlClient does not support.
This problem likely won't affect most apps, however, there are some scenarios where it will. For us, it affected our service-discovery service that other applications talk to in order to get the connection string they should use. Some of those other applications are still using System.Data.SqlClient, and thus the connection string returned by our service-discovery service was now invalid for those apps; they were receiving connection strings with Application Intent=ReadOnly in them instead of ApplicationIntent=ReadOnly, which is unsupported in System.Data.SqlClient.
When trying to use a Microsoft.Data.SqlClient connection string in an app connecting using System.Data.SqlClient, we received the following error:
Keyword not supported: 'application intent'

Describe the solution you'd like
It would be good if the SqlConnectionStringBuilder's .ConnectionString property used the backward compatible keywords, where applicable. For example, instead of returning a connection string with Application Intent= or Multi Subnet Failover= in it, it used ApplicationIntent= and MultiSubnetFailover= instead.
Describe alternatives you've considered
For now we've updated our service-discovery service to manually sanitize the connection string to use the backward compatible keywords, rather than just returning back the SqlConnectionStringBuilder.ConnectionString directly.
For this repo, if you choose to leave things as-is, we should at least add some documentation for this backward incompatibility.
Additional context
The new connection string format is a breaking change from System.Data.SqlClient. This seems like an easy way to restore backward compatibility.

I've created the above PR to mention the backward incompatibility in the docs for now, but it would still be nice to have it use the backward compatible keywords by default.

@David-Engel Looking for your input on this.


Error Provisioning

Keybase GUI Version: 4.5.0-20190919040131+93e889ab01
Please help me get this loaded onto my computer. It keeps saying that there is an error provisioning. I have no idea what that means and how to fix it. Just a total roadblock. Please advise.

I also got this in the iOS app. I’m on an iPhone se, iOS 12.2. Happened when I reinstalled Keybase after having offloaded it.

Upgrade app
On Wed, Feb 26, 2020 at 7:30 PM Mike Eng<EMAIL_ADDRESS>wrote:

I also got this in the iOS app. I’m on an iPhone se, iOS 12.2. Happened
when I reinstalled Keybase after having offloaded it.
[image: D4CB91D5-301B-4CE6-801A-C30546B1659A]
https://user-images.githubusercontent.com/2223603/75400849-6b9a4100-58ce-11ea-8f25-19185e7575ad.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/20250?email_source=notifications&email_token=ADS4PX6VUXETEIZDYWZ25B3RE4CSPA5CNFSM4I7G7DP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCNUOA#issuecomment-591714872,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADS4PX6BG7VZLIUGTFDQIY3RE4CSPANCNFSM4I7G7DPQ
.


Make use of the option "output-filename" in mediabackup command

Implements the option output-filename in the mediabackup command.

Coverage decreased (-38.9%) to 56.984% when pulling 279f3095d41c71848a8b095a90dfda93d553c8b2 on kapz:mediabackup-patch-filename into a2ec00ccce4399646dd7432e0e731e005affc4bb on django-dbbackup:master.

Coverage decreased (-0.2%) to 95.674% when pulling 54706e7c5c9bb31e26a7daca5ee30fc26556f2dd on kapz:mediabackup-patch-filename into a2ec00ccce4399646dd7432e0e731e005affc4bb on django-dbbackup:master.

Hello @kapz
Really sorry for my latency
Could you add unit tests to ensure your PR ?

I'm closing this PR as it is severely out of date. If you want to see this I suggest that you open up a new PR.


Added ca-certificates

Could you please add ca-certificates as it would be necessary to relay to any every service behind tls (eg. AWS SES)

Aha sure no problem, thanks!


Why there is no marker clustering feature? It is important one right?

Thanks for stopping by to let us know something could be better!

PLEASE READ
If you have a support contract with Google, please create an issue in the support console. This will ensure a timely response.
Discover additional support services for the Google Maps Platform, including developer communities, technical guidance, and expert support at the Google Maps Platform support resources page.
If your bug or feature request is not related to this particular library, please visit the Google Maps Platform issue trackers.
Check for answers on StackOverflow with the google-maps tag.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@sajithlaldev Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

Support Console - If you have a support contract.
Discord - chat with other developers
StackOverflow - use the google-maps tag
Google Maps Platform issue trackers

This is an automated message, feel free to ignore.


Convert find_upstream to rust style && refactor build_request

find_upstream: convert the function signature more rust-native. And remove bool return value is_vip,  it is unnecessary since we only use it in the case for to upstream remote proxy(waypoint), no matter the original target is endpoint or vip,  we could just use the original target.
build_request: no significant logical change, only refactor the match arm blocks and remove unnecessarily clone.

@PlatformLC: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PlatformLC: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
8bc6a8eb0f66016fde9544fee7cabc7a71e2d075
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Googlebot doesn't get Object.assign polyfilled

I ran into this issue that my React app wasn't being rendered by Googlebot. By using Fetch as Google, I tracked it down to Object.assign not being available in Googlebot, even though I'm using the following polyfill:
https://cdn.polyfill.io/v2/polyfill.min.js?features=default

I tested this with the following code:

At what point do you stop working, Google?

{Object.assign && 'We have object.assign! :)'}
{!Object.assign && 'No object.assign available! :('}

Which renders the following in Fetch as Google:

Note that the left says "No object.assign available! :(".

I'm going to fix this for myself by polyfilling it in my own code, so it's not a critical issue for me but I'm sure others might encounter the same issue.

This can be solved in a few ways:

include unknown=polyfill in your querystring to polyfill.io

unknown=polyfill makes polyfill.io return all polyfills if it doesn't know what browser the client is. Here is the explanation from our documentation:

What to do when the user agent is not recognised. Set to polyfill to return default polyfill variants of all qualifying features, ignore to return nothing. Use caution when setting this argument to 'polyfill' on large feature sets, since huge polyfill bundles may cause crashes or lockups in extremely old or underpowered user agents. Defaults to ignore.

Wait on https://github.com/Financial-Times/polyfill-service/issues/107 to be completed.

@MartijnHols we'd also be delighted if you would consider helping us to improve our browser targeting. We prepared a document to help people get started if they want to correct browser targeting configuration:
https://polyfill.io/v2/docs/contributing/common-scenarios#adding-browsers

Currently we don't support Googlebot as a browser family.  We still recommend using the unknown=polyfill config parameter if you want to polyfill for search crawlers.  We would welcome any efforts to either add and maintain a googlebot browser family, or create aliases to the appropriate versions of chrome or webkit. However, I'm aware that Google doesn't publicly disclose which browser engine version is used by Googlebot, so it is kinda hard to do that.

We need intl support for googlebot. We receive javascript errors that it's missing.
@triblondon Can you estimate the effort needed to support bots? Just user agent regex?

Googlebot uses Chrome 41
https://developers.google.com/search/docs/guides/rendering

@williamoliveira We alias Googlebot to Chrome 41 :-) -- https://github.com/Financial-Times/polyfill-service/blob/master/packages/polyfill-library/lib/UA.js#L145


Create and Open VI label in Clone VI dialog should be changed to Clone and Open VI to match first button.

In the Clone VI dialog there is an inconsistency in the button labeling. In the first button the label is: "Clone VI", so it seems proper for the second button to be labeled: "Clone and Open VI".

As a secondary note: The tip strips on both buttons are wrong and state: "Create class". The tip strip should either be fixed or removed.

Thanks for that now, I've fixed this and will do another build this week.
Uploaded a new build yesterday with most lots of new UI changes and changes in the Rename VI, to handle interfaces better

BTW, found that the tip strip was wrong in al dialogs, that is also now fixed


Adds a link and summary of Administrator's Guide

Summarize the change in the pull request title
Add's a helpful link to the very useful and little known administrator's guide to this document about the same sorts of troubleshooting.  Later on, one might decide to merge the docs somehow, but this at least links the material for today's consumption.
🎃 🎃
Fixes #Issue_Number (if necessary)
Related to #1782

@1RedOne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @1RedOne for the contribution! Sorry for the slow response, I was out of the office for a few days. I'm also checking with someone that's been doing some work in this area. Stay tuned...

Hi @1RedOne, I hate to do this, but I'm going to decline this change. 😢
The reason, and the good news, is that with work that's in progress that KB should be irrelevant. So stay tuned for more updates in this area soon! 😉

No worries.
On Wed, Oct 16, 2019, 3:05 PM Aaron Czechowski<EMAIL_ADDRESS>wrote:

Closed #1918 https://github.com/MicrosoftDocs/SCCMdocs/pull/1918.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/SCCMdocs/pull/1918?email_source=notifications&email_token=AAJQTCSZVT2NEVRDMW6RUBDQO5QW5A5CNFSM4I6V3YQ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUIGUY5A#event-2718780532,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJQTCV6UNVA4TL4KZ74ET3QO5QW5ANCNFSM4I6V3YQQ
.


update Purchase request manager

update Purchase request manager

Coverage decreased (-0.01%) to 77.323% when pulling 552c6024e945e5347be2bba8ef981a90d499d13a on adityahenanda:dev into 2b57d7ba38ba135d6d8cec32f1adb13b7e42f35b on danliris:dev.


SB: Create e2e SKR test for all new service bindings capabilities

Subtask of the EPIC: https://github.com/kyma-project/kyma-environment-broker/issues/284
AC

[x] 1) one e2e SKR test calling KEB APis

[x] 1.1) https://github.com/kyma-project/kyma-environment-broker/issues/1239, PR#1244
[x] 1.2) add GET and DELETE test for TOKEN+REQUEST and GARDENER (they must fail if GET has dummy response, and when DSELETE TOKEN_REQUEST previous kubeconfig must NOT work, and for GARDENER it must still work)
https://github.com/kyma-project/kyma-environment-broker/pull/1249
[x] 1.3) test validation for expiration_seconds with less than 10 min, and more than 2h. Must fail and check validation message.  https://github.com/kyma-project/kyma-environment-broker/pull/1261
[x] 1.4) Create 11 bidings, 11th must fail with proper validation message https://github.com/kyma-project/kyma-environment-broker/pull/1283

[ ] 2) new type of e2e test (could be written in go, special for Mr Wojciech).

[ ] 2.1) Setup: We have prepared subacout on staging with Provisioing Service instance and binding,
[ ] 2.2) Setup: Kyma entitlement added for example to AWS plan
[ ] 2.3) New test, where provisioning API creates Kyma cluster + Service Bindings, we can still use KCP CLI tech users to validate some things, or show why it failed. Use the SB kubeconfig and reach Kyma instance.

Part 2 about provisioning api was moved to #1341


Always use maxiter = 2

This PR changes maxiter to 2 for all cases, so that we disentangle the alg prescription from the problem

bors r+

bors r-

bors r+


use worker-rpc library for inter-process communication

Over in #231, you suggested

I wonder if there's a way to tweak the checker to expose the checker purely for the purposes of testing... That could be potentially useful - it wouldn't need to be something we exposed always; we could have a "test" mode or something... Ideas!

To do that I need a way to do some inter-process communication that does not interfere with the given inter-process communication.
This PR adds worker-rpc so we can send different types of messages between the processes. Also, as it has a nice interface around promises, it acutally makes some existing code more readable.
As it did not want this to be swept under the rug by the myriad of other commits in #231, I created a separate PR for this so you can review it (I will continue using this in #231 as well, though)

Okay, everything should be addressed - could you take a second look? :)

Looks really interesting!
Though all the CI seem to be failing with a compilation error of: Error: Cannot find module '../../lib/WorkResult'
Can you fix please?

Oh, I should have added that info: @DirtyHairy is actually a colleague of mine - as far as I know it's not maintained because it does what it needs to and there were no changes requested or required in the last few years.
We are actively using it in some customer projects and as far as I know he is using it heavily for web worker communication in his atari emulator ( https://github.com/6502ts/6502.ts ), so from my point of view I'd say it is quite mature.
As for the failing tests - I'll take a look at that tomorrow in the evening. Guess there were still tests using WorkResult.ts, even though the code did not reference it - and as I had a compiled version still sitting in the lib folder, my local tests did not fail.

What @phryneas says: both worker-rpc and microevent.ts (on which it depends) are maintained; they just don't have required much maintenance since I published them 😏

Okay, there was actually a test for WorkResult, which was made obsolete by this PR. Now tests are actually running.
Tests are now failing for webpack 2 and 3, I'm on that.

This test suite is great :) I had missed to migrate one RPC call - now everything should be good :)

Great! Question: does https://www.npmjs.com/package/@phryneas/experimental-fork-ts-checker-webpack-plugin use worker-rpc?

Yes, but the version before the fix of yesterday, so the current build will not work on webpack 2/3.
I can merge it over and create a new build this evening.

That'd be awesome - thanks so much! I'm going to switch over my build at work to use this and see how it goes.
I'm very much a believer in dogfooding 😉

It would be great to get a release out with this in. @piotr-oles do you want to make that happen?

Yes, please release if you want to :)

Is there a way to do it without raising another PR to update the package.json... I'm guessing not?

I will create PR with semantic-release integration to make releasing and versioning fully automatic :)

Nice! 😊❤
Should I push out v1.0.3 in the meantime or would you rather I leave that so you can test your new mechanism?

Please release v1.0.3 - I don't want to block you. I will release RC versions on beta channel to test it.

Should be out shortly https://github.com/Realytics/fork-ts-checker-webpack-plugin/releases/tag/v1.0.3
cc @phryneas


'Aws::Http::HttpClient::MakeRequest': Deprecated

Platform/OS: Win7
Compiler: MSVC2017
Including aws/core/http/windows/WinHttpSyncHttpClient.h (to deal with #453) causes compiler to emit:
1>c:\vcpkg\installed\x64-windows\include\aws\core\http\windows\winsynchttpclient.h(51): warning C4996: 'Aws::Http::HttpClient::MakeRequest': Deprecated: in favor of MakeRequest(const std::shared_ptr<HttpRequest>&, ...).
1>c:\vcpkg\installed\x64-windows\include\aws\core\http\httpclient.h(54): note: see declaration of 'Aws::Http::HttpClient::MakeRequest'

Any advice on how to deal with this (without resorting to #pragma warning(disable: 4996))?

https://github.com/aws/aws-sdk-cpp/blob/09b65deba03cfbef9a1e5d5986aa4de71bc03cd8/aws-cpp-sdk-core/include/aws/core/http/HttpClient.h#L53
Basically, just like what the documentation said, you can pass the MakeRequest with a shared pointer of request to avoid this warning.
But for your use case, are you still using the hacky way to provide a client certificate?

@wps132230, nowhere in my code I call MakeRequest. In fact, simply including that header causes warning to be generated.

But for your use case, are you still using the hacky way to provide a client certificate?

Yes, I still have to rely on a hack (preprocessor-driven substitution of private with protected) to be able to ask server to not validate client certificate.

That warning message should have been suppressed.
https://github.com/aws/aws-sdk-cpp/blob/09b65deba03cfbef9a1e5d5986aa4de71bc03cd8/aws-cpp-sdk-core/include/aws/core/Core_EXPORTS.h#L50
What version of SDK are you using?

Update my last response: it just suppressed in SDK's code. You can define AWS_DISABLE_DEPRECATION before include that header to suppress it in your code.

@singku aren't it supposed to use previous branch? (I am compiling in C++17 mode)
#elif defined (__cplusplus) && __cplusplus > 201103L // standard attributes are available since C++14
    #define AWS_DEPRECATED(msg) [[deprecated(msg)]]

It is weird that I need to define AWS_DISABLE_DEPRECATION in my code even though I don't use any of the deprectaed declarations...

It's a pure virtual function in HttpClient class but marked as deprecated purposely (It's not safe but we don't want to break some of the users who still inherit it by simply remove it). And WinSyncHttpClient has to implement it, that's the dilemma. And we disabled it in SDK's code to avoid the warning.

Got it. Thank you


Changes to Demographics and Health section and Data page

This is a draft PR that makes 15+ small demographics-and-health related text changes. I'm keeping this in draft mode until the demographics.shp file has been updated with the margin-of-error → confidence interval changes, the API has been updated accordingly in its demographics_updates branch, and NCR has been updated to handle the new field names, etc., as needed in this branch.

@cstephen The ACS data that is currently in the tool is actually from years 2018-2022 (we must have missed updating this citation) and so I think the citation on the data page needs to read "2018-2022" even if we don't update the ACS data


SI causes constant CPU and IO load of "services.exe"

Hello.
When SI is run on a relatively fresh installation of Windows 11 Pro 23H2 it causes constant CPU and IO load of "services.exe". As soon as SI is closed the load vanishes.

Change the setting EnableServiceNonPoll to 1 and or EnableServiceNonPollNotify to 1

Thanks. This makes services.exe only cause load on SI startup and then drop down.
What do these two flags/options do exactly, do I miss any functionality then?

What do these two flags/options do exactly

The CPU usage from services.exe isn't normally an issue but every so often someone does have the issue. Services.exe decides to disable the services database caching and enumerates the windows object directory (winobj) hundreds of times a second,
These options disable/enable service notification subscriptions but they require +700 registrations (2 per service) and they disable UI feedback for kernel drivers, so you won't know when kernel drivers start/stop.

do I miss any functionality then?

The services tab has an isssue but if you don't notice then it's not an issue 😄

After settings the options there still is a short CPU load spike for services.exe every 5 seconds.


tf.function runs correctly in eager mode, but breaks in graph mode

System information
= check python ===================================================
python version: 3.8.10
python branch:
python build version: ('default', 'Jun  2 2021 10:49:15')
python compiler version: GCC 9.4.0
python implementation: CPython
== check os platform ===============================================
== are we in docker =============================================
Yes
== compiler =====================================================
c++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
== check pips ===================================================
numpy                         1.19.5
protobuf                      3.17.3
tensorflow                    2.5.0+nv
tensorflow-addons             0.13.1
tensorflow-datasets           3.2.1
tensorflow-dot-based-interact 0.0.1
tensorflow-estimator          2.5.0
tensorflow-metadata           1.1.0
== check for virtualenv =========================================
False
== tensorflow import ============================================
tf.version.VERSION = 2.5.0
tf.version.GIT_VERSION = unknown
tf.version.COMPILER_VERSION = 9.3.0
== env ==========================================================
LD_LIBRARY_PATH /usr/local/cuda/compat/lib.real:/usr/local/cuda/extras/CUPTI/lib64:/usr/local/cuda/compat/lib:/usr/local/nvidia/lib:/usr/local/nvidia/lib64
DYLD_LIBRARY_PATH is unset
== cuda libs  ===================================================
/usr/local/cuda-11.4/targets/x86_64-linux/lib/libcudart.so.11.4.43
/usr/local/cuda-11.4/targets/x86_64-linux/lib/libcudart_static.a
== tensorflow installed from info ==================
Name: tensorflow
Version: 2.5.0+nv
Summary: TensorFlow is an open source machine learning framework for everyone.
Home-page: https://www.tensorflow.org/
Author-email<EMAIL_ADDRESS>License: Apache 2.0
Location: /usr/local/lib/python3.8/dist-packages
Required-by: tensorflow-dot-based-interact, nvtx-plugins
== python version  ==============================================
(major, minor, micro, releaselevel, serial)
(3, 8, 10, 'final', 0)
== bazel version  ===============================================
Build label: 3.7.2
Build time: Thu Dec 17 16:57:23 2020<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>
Describe the problem
When doing perf analysis of Tensorflow2 models, we want to breakdown the training flow into separate phases: forward, loss, backward, weight_update etc. The main idea to do the time breakdown is to run the flow in overall eager mode, but each phase is wrapped in tf.function API, so to run the phase in graph mode. We have an issue that a tf.function can run correctly under eager mode, but breaks in graph mode.
I created a minimum tests to reproduce the issue pasted below.
in the direct test, we want to run optimizer.minimize in graph mode by wrapping with tf.function, when running the tf.function in eager mode throught setting tf.config.experimental_run_functions_eagerly(True), it works.
But fails with if running the graph mode with below error:
Traceback (most recent call last):
File "direct_test.py", line 119, in
dummy_model.fit(dummy_data_generator,steps_per_epoch = 100)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/keras/engine/training.py", line 1183, in fit
tmp_logs = self.train_function(iterator)
File "direct_test.py", line 59, in train_function
return step_function(self, iterator)
File "direct_test.py", line 49, in step_function
outputs = model.distribute_strategy.run(run_step, args=(data,))
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/distribute/distribute_lib.py", line 1285, in run
return self._extended.call_for_each_replica(fn, args=args, kwargs=kwargs)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/distribute/distribute_lib.py", line 2833, in call_for_each_replica
return self._call_for_each_replica(fn, args, kwargs)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/distribute/distribute_lib.py", line 3608, in _call_for_each_replica
return fn(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/autograph/impl/api.py", line 597, in wrapper
return func(*args, **kwargs)
File "direct_test.py", line 41, in run_step
outputs = model.train_step(data)
File "direct_test.py", line 88, in train_step
self.optimizer.minimize(loss, self.trainable_variables, tape=tape)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/def_function.py", line 889, in call
result = self._call(*args, **kwds)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/def_function.py", line 933, in _call
self._initialize(args, kwds, add_initializers_to=initializers)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/def_function.py", line 763, in _initialize
self._stateful_fn._get_concrete_function_internal_garbage_collected(  # pylint: disable=protected-access
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/function.py", line 3050, in _get_concrete_function_internal_garbage_collected
graph_function, _ = self._maybe_define_function(args, kwargs)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/function.py", line 3444, in _maybe_define_function
graph_function = self._create_graph_function(args, kwargs)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/function.py", line 3279, in _create_graph_function
func_graph_module.func_graph_from_py_func(
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/framework/func_graph.py", line 999, in func_graph_from_py_func
func_outputs = python_func(*func_args, **func_kwargs)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/def_function.py", line 672, in wrapped_fn
out = weak_wrapped_fn().wrapped(*args, **kwds)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/framework/func_graph.py", line 986, in wrapper
raise e.ag_error_metadata.to_exception(e)
ValueError: in user code:
/usr/local/lib/python3.8/dist-packages/tensorflow/python/keras/optimizer_v2/optimizer_v2.py:530 minimize  *
    return self.apply_gradients(grads_and_vars, name=name)
/usr/local/lib/python3.8/dist-packages/tensorflow/python/keras/optimizer_v2/optimizer_v2.py:630 apply_gradients  **
    grads_and_vars = optimizer_utils.filter_empty_gradients(grads_and_vars)
/usr/local/lib/python3.8/dist-packages/tensorflow/python/keras/optimizer_v2/utils.py:75 filter_empty_gradients
    raise ValueError("No gradients provided for any variable: %s." %

ValueError: No gradients provided for any variable: ['training_model/dense/kernel:0', 'training_model/dense/bias:0'].

2021-07-15 03:29:43.999375: W tensorflow/core/kernels/data/generator_dataset_op.cc:107] Error occurred when finalizing GeneratorDataset iterator: Failed precondition: Python interpreter state is not initialized. The process may be terminated.
[[{{node PyFunc}}]]
Source code / logs
direct_test.txt

Can you check the code again please.
The code provided throws an error in line 49 outputs = model.distribute_strategy.run(run_step, args=(data,))
ValueError: No gradients provided for any variable: ['training_model/dense/kernel:0', 'training_model/dense/bias:0'].

@old-school-kid This issue is as expected, and it is why we filing the issue in this thread.
if un-comment the code in line 20 to run the tf.function with eager mode:
tf.config.experimental_run_functions_eagerly(True)
the test will pass without reporting the issue.

@shawnwang18 In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!


The terminal scrolls too much on a mouse wheel

Version: 1.42.0-insider (user setup)
Commit: 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1
OS: Windows_NT ia32 10.0.18362
@Tyriar This is a top pain point for me.
When using the terminal, oftentimes I need to scroll up to see some older output. When working on my macbook and using the touchpad, this works great. But when using my Windows desktop with a physical mouse which has a physical mouse wheel, one flick of the mouse wheel scrolls more than one terminal page. It scrolls so much that 10 lines of the terminal are entirely skipped.
To reproduce, execute the following:
for (let i = 0; i < 100; i++) {
    console.log(`LINE ${i + 1}`);
}

plug a mouse with a mouse wheel on Windows
do one mouse wheel flick: (note how lines 80-88 are not rendered at all)

@alexdima what do you have editor.mouseWheelScrollSensitivity set to?

@alexdima use terminal.integrated.mouseWheelScrollSensitivity and terminal.integrated.fastScrollSensitivity to configure the terminal specifically now.

@Tyriar I just got vscode insiders for this, but it says "Unknown configuration setting" when I add "terminal.integrated.mouseWheelScrollSensitivity": 0.5 to the settings.json. The scrolling behavior doesn't change. Am I doing something wrong?

@StormFalcon32 there likely won't be a new Insiders build until the 6th due to the holidays.

@Tyriar ah thank you


Add MediumEditor reference to the component for external use

I have tried to add a custom button and could not find a way to get access to MediumEditor itself. Sorted the issue by adding the reference to the VueMediumEditor object.
Just sharing my solution, let me know if there is a better way to reslve this.

Thank you for your contribution.
I like this solution. Good job. Can you explain what happens for either true or false in the reuseMediumEditorInstance prop? This must be compatible. If it is, i will not hesitate to merge :)
Right now I am working on fixing up all the issues, want to publish a new version tonight, but I am running into major issues with regard to the customElement option.

This is the the reference to the MediumEditor class, not the particular instance, should cause no issues.

Thank you very much. I will push a compiled version for you in a few minutes so that you can use the latest one :)

Great, thanks :)

You should now be able to install the latest version using npm i -S franzskuffka/vue-medium-editor#1b23b3e2ea6d9cb46984bf5d9ac2b294f116d04e
Please let me know if it works for you now.

Yeah, all works now :)
Thanks


Code actions on save settings should be over writable by language ID

Otherwise it is very hard to enable / disable code action on save for different languages. To enable this add a overridable: true to the settings configuration here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/codeActions/common/configuration.ts#L48 and here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/codeActions/common/configuration.ts#L37
@mjbvz I can do the changes if you agree to this.

Yes, I think this was just an oversight


Edited UserGuide on the add, undo and find

Updated the UG but left the saving and edit

#73 is still needed

Coverage increased (+0.06%) to 91.046% when pulling b4b26a1db4d94e767521e96fabd2e4831b400bda on Update_UserGuide_1 into 1e783510afaf5e1f279744d23c2856a736c00714 on master.


Scrollbar is flickering in Chrome browser

Scrollbar is constantly flickering around AutoSizer (SmartList) component.
Only affects Chromium- browsers.

The issue is in the AutoSizer component and can easily be fixed.
More info: https://github.com/bvaughn/react-virtualized/issues/773#issuecomment-351131634

I've fixed this in production, but it still await legit fixing through our workflow.


Use the name registry to enforce unique app names

Is there a related GitHub Issue?
#314
What is this change about?
Make the app webhook that prevents app name duplication more robust by using the name registry rather than listing apps. The name registry implements locking based on lease objects.
Does this PR introduce a breaking change?
No
Acceptance Steps
Tests are green (less flaky)
Tag your pair, your PM, and/or team
@cloudfoundry/cf-k8s

I didn't realize we had test flakiness due to this issue -- thought it was still mostly theoretical. 🤔  Makes sense to use the lease approach for Apps for now since App name uniqueness in a space is almost as important as Org/Space name uniqueness.
For context though, we're planning on doing an explore to investigate using Open Policy Agent Gatekeeper for resources where we want other forms of cross-resource validation more generally.
https://github.com/cloudfoundry/cf-k8s-controllers/issues/383
cc @matt-royal who wrote that explore / is also thinking about this

Yep, the tests for name uniqueness were falling after a low number of retries.
I don't think OPA would be able to enforce name uniqueness for the same reason the original validating webhook couldn't. If two processes attempt to create the same named app, and the webhooks each invoke OPA before k8s has created either app resource, both creates will be allowed as OPA can only checks for uniqueness within the existing set of app names which won't yet include the new name.
That webhook really needs to take a global lock and check for name uniqueness in a list that is always correct and complete when viewed with the lock. And the cheap way to do that is with k8s' built-in namespace/name uniqueness enforcement using a separate resource with no side effects like Lease.


SpaceGame example fails to run with compiler error

Eventually you encounter this:
error[E0308]: mismatched types
    --> /home/XXXXXXX/git/general/pax/examples/src/space-game/.pax/pkg/pax-cartridge/src/lib.rs:1496:44
     |
1496 | ...                   cp.transform = resolved_property
     |                       ------------   ^^^^^^^^^^^^^^^^^ expected `Property<Option<Transform2D>>`, found `Property<Transform2D>`
     |                       |
     |                       expected due to the type of this binding

Which appears to be in generated code?

It appears the code gen for transform is wrong? Here is a snippet including the generated code for Rotate from above
                   "rotate" => {
                        let resolved_property: Property<pax_engine::api::Rotation> = match value.clone() {
                            ValueDefinition::LiteralValue(lv) => {
                                let val = from_pax_try_coerce::<pax_engine::api::Rotation>(&lv.raw_value)
                                    .map_err(|e| format!("failed to read {}: {}", &lv.raw_value, e)).unwrap();
                                Property::new_with_name(val, &lv.raw_value)
                            },
                            ValueDefinition::Expression(token, info) | ValueDefinition::Identifier(token,info) =>
                            {
                                if let Some(info) = info {
                                    let mut dependents = vec![];
                                    for dependency in &info.dependencies {
                                        if let Some(p) = stack_frame.resolve_symbol_as_erased_property(dependency) {
                                            dependents.push(p);
                                        } else {
                                            panic!("Failed to resolve symbol {}", dependency);
                                        }
                                    }
                                    let cloned_stack = stack_frame.clone();
                                    let cloned_table = table.clone();
                                    Property::computed_with_name(move || {
                                        let new_value_wrapped: PaxAny = cloned_table.compute_vtable_value(&cloned_stack, info.vtable_id.clone());
                                        let coerced = new_value_wrapped.try_coerce::<pax_engine::api::Rotation>().unwrap();
                                        coerced
                                    }, &dependents, &token.raw_value)
                                } else {
                                    unreachable!("No info for expression")
                                }
                            },
                            _ => unreachable!("Invalid value definition for rotate")
                        };

                            cp.rotate = Some(resolved_property)

                    },

                    "transform" => {
                        let resolved_property: Property<pax_engine::api::Transform2D> = match value.clone() {
                            ValueDefinition::LiteralValue(lv) => {
                                let val = from_pax_try_coerce::<pax_engine::api::Transform2D>(&lv.raw_value)
                                    .map_err(|e| format!("failed to read {}: {}", &lv.raw_value, e)).unwrap();
                                Property::new_with_name(val, &lv.raw_value)
                            },
                            ValueDefinition::Expression(token, info) | ValueDefinition::Identifier(token,info) =>
                            {
                                if let Some(info) = info {
                                    let mut dependents = vec![];
                                    for dependency in &info.dependencies {
                                        if let Some(p) = stack_frame.resolve_symbol_as_erased_property(dependency) {
                                            dependents.push(p);
                                        } else {
                                            panic!("Failed to resolve symbol {}", dependency);
                                        }
                                    }
                                    let cloned_stack = stack_frame.clone();
                                    let cloned_table = table.clone();
                                    Property::computed_with_name(move || {
                                        let new_value_wrapped: PaxAny = cloned_table.compute_vtable_value(&cloned_stack, info.vtable_id.clone());
                                        let coerced = new_value_wrapped.try_coerce::<pax_engine::api::Transform2D>().unwrap();
                                        coerced
                                    }, &dependents, &token.raw_value)
                                } else {
                                    unreachable!("No info for expression")
                                }
                            },
                            _ => unreachable!("Invalid value definition for transform")
                        };

                            cp.transform = resolved_property

                    },

PR coming soon

See answer on the other issue :)

There still seems to be a bug though
Line 376 of catridge_generation/mod.rs transform is flagged as not-optional
impl CommonProperty {
    pub fn get_common_properties() -> Vec<String> {
        COMMON_PROPERTIES.iter().map(|e| e.to_string()).collect()
    }

    pub fn get_property_types() -> Vec<(String, String)> {
        COMMON_PROPERTIES_TYPE
            .iter()
            .map(|(c, t)| (c.to_string(), t.to_string()))
            .collect()
    }

    pub fn get_as_common_property() -> Vec<CommonProperty> {
        let mut common_properties = Vec::new();
        for (name, property_type) in CommonProperty::get_property_types() {
            common_properties.push(CommonProperty {
                name: name.clone(),
                property_type: TypeId::build_singleton(&property_type, None),
                is_optional: (name != "transform" && name != "width" && name != "height"), // <-- implied not optional
            });
        }
        common_properties
    }
}

But in CommonProperties, its wrapped in Option

pub struct CommonProperties {
    pub id: Property<Option<String>>,
    pub x: Property<Option<Size>>,
    pub y: Property<Option<Size>>,
    pub scale_x: Property<Option<Size>>,
    pub scale_y: Property<Option<Size>>,
    pub skew_x: Property<Option<f64>>,
    pub skew_y: Property<Option<f64>>,
    pub rotate: Property<Option<Rotation>>,
    pub anchor_x: Property<Option<Size>>,
    pub anchor_y: Property<Option<Size>>,
    pub transform: Property<Option<Transform2D>>, // <-- optional
    pub width: Property<Option<Size>>,
    pub height: Property<Option<Size>>,
}

It seems weird these two are split, you now have to keep them in sync.

You are right that definitely seems like something that should be cleaned up, the optional flag on common properties might not be needed anymore :)
I can't seem to reproduce the error you are getting however, what commit are you on and what version of the pax-cli are you using?

pax-cli from cargo install pax-cli
0.15.1
I am checking out and building from master ( 9852153f303d1f69c2f1eccec9fdedfe54d4e819 )however, so it may be a mismatch there.

Looks like 0.15.2 just got tagged
I could try that.

Space game Cargo.toml has the following:
[package]
name = "space-game"
version = "0.14.1"
edition = "2021"
default-run = "run"

[dependencies]
pax-engine = { version = "0.15.1", path = ".pax/pkg/pax-engine" }
pax-std = { version = "0.15.1", path = ".pax/pkg/pax-std" }
pax-compiler = { version = "0.15.1", optional = true , path = ".pax/pkg/pax-compiler" }
pax-manifest = { version = "0.15.1", optional = true , path = ".pax/pkg/pax-manifest" }
serde_json = {version = "1.0.95", optional = true}
rand = {version = "0.8.5"}
getrandom = { version = "0.2.14", features = ["js"] }

[[bin]]
name = "parser"
path = "src/lib.rs"
required-features = ["parser"]

[[bin]]
name = "run"
path = "bin/run.rs"

[features]
parser = ["pax-std/parser", "pax-engine/parser", "dep:serde_json", "dep:pax-compiler", "dep:pax-manifest"]

I'll make the change and see if it works for me. But I don't know why it's working for you.

did you pull the lastest master as well? :)

that should have update the Cargo.toml to refer to 0.15.2

Your MR just landed after I started this.

Still fails for me

Oh wait, do I need to rebuild the pax-cli from local source? One sec

I'll see if I can figure out what could be different, I'll let you know if I find something!

If you're on the commit tagged 0.15.2 you shouldn't have to if you have the 0.15.2 version of the cli

upgraded to pax-cli 0.15.2
I now get:
examples/src/space-game on  master [?] is 📦 v0.14.1 via 🦀 v1.75.0
❯ pax-cli clean -p space-game
🧹 Cleaning cached & temporary files...
The application panicked (crashed).
Message:  Failed to read Cargo.toml: Os { code: 2, kind: NotFound, message: "No such file or directory" }
Location: /home/danieljoyce/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pax-compiler-0.15.2/src/helpers.rs:116

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

Join the discord server and we can chat if you'd like, might be easier: https://discord.gg/ycuWj6T7

Okay, well it seems to work with 0.15.2.

The big difference is now rotate and transform in the generated code are no longer wrapped in Some() unlike the snippet above.
👍🏻

Even if it works I do agree there's some parts that can be cleaned up here, I'll file it as an internal ticket!

It looks like perhaps before it was Option, but now its Property.
All of the common properties in the generated examples/src/space-game/space-game/.pax/pkg/pax-chassis-common/src/lib.rs now agree. None of them are wrapped in Some anymore.

Yes exactly! Should have kept master and lastest release in sync, thanks for pointing out it was not!
I'll close this :)