HBASE-23658 Fix flaky TestSnapshotFromMaster

What is the test used for? It is named "testAsyncSnapshotWillNotBlockSnapshotHFileCleaner" but where is the HFileCleaner?

What is the test used for? It is named "testAsyncSnapshotWillNotBlockSnapshotHFileCleaner" but where is the HFileCleaner?

Introduced by HBASE-21582. SnapshotManager#cleanupSentinels not runed and it will keep one snapshot handler. Then the HFileCleaner will not run too as there are snapshot is taking.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m  4s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

+0 :ok:
spotbugs
4m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 28s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  2s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

-1 :x:
checkstyle
1m 19s
hbase-server: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 50s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 36s
the patch passed

+1 :green_heart:
findbugs
4m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
161m 32s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

220m 58s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/998

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 2f8ded0e5a04 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-998/out/precommit/personality/provided.sh

git revision
master / 5a7c9443e9

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/1/testReport/

Max. process+thread count
5278 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 30s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
checkstyle
1m 20s
master passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

+0 :ok:
spotbugs
4m 27s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 26s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
checkstyle
1m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m  5s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 36s
the patch passed

+1 :green_heart:
findbugs
4m 29s
the patch passed

_ Other Tests _

-1 :x:
unit
162m 54s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

222m  1s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestMultiSlaveReplication

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/998

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d4e3d55af4b0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-998/out/precommit/personality/provided.sh

git revision
master / 5a7c9443e9

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/2/testReport/

Max. process+thread count
5231 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 33s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
shadedjars
4m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

+0 :ok:
spotbugs
4m 24s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 23s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 50s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 36s
the patch passed

+1 :green_heart:
findbugs
4m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
171m  2s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

233m 50s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/998

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ae06b0990606 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-998/out/precommit/personality/provided.sh

git revision
master / 66d1258aa3

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/3/testReport/

Max. process+thread count
5488 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-998/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Batch action bar appearing on Neo fields on entry revisions

Bug Description
When viewing an entry revision, batch action bars will be initialised for Neo fields, despite not being particularly useful in that context.
Matrix fields appear to be unaffected.
Steps to reproduce

View an entry revision with a non-empty Neo field

Expected behaviour
Batch action bars should not be initialised for revisions.
Batch Actions version
1.1.0
Craft CMS version
4.3.10

Fixed in 1.2.0.


33% Regression in 90th percentile build time

skiaperf
https://flutter-flutter-perf.skia.org/e/?begin=1683647236&end=1683755014&keys=Xcadf541561768bef74423e97ec64bb7e&selected=commit%3D34774%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253D90th_percentile_frame_build_time_millis%252Ctest%253Dios_picture_cache_complexity_scoring_perf__timeline_summary%252C&xbaroffset=34774
introduced in roll
https://github.com/flutter/flutter/pull/126360
likely cause
https://github.com/flutter/engine/pull/41834

cc @jonahwilliams the author of https://github.com/flutter/engine/pull/41834

There is a similar regression in ios_picture_cache_complexity_scoring_perf__timeline_summary:90th_percentile_frame_build_time_millis as well.  That likely the same cause.
https://flutter-flutter-perf.skia.org/e/?begin=1683647236&end=1683755014&keys=Xcadf541561768bef74423e97ec64bb7e&num_commits=50&request_type=1&xbaroffset=34774

From Triage: We tried to reproduce this but could not. The commit in question only modifies raster workloads. Zooming out a bit on trend, it seems it is environment related. There have been instances in the past where the current levels were consistently observed.
Closing as WAI but good to keep an eye out on this test for more noise in the future.


global attribute with styled-jsx/css import does not work with Jest

Do you want to request a feature or report a bug?
Report a bug.
What is the current behavior?
Running tests with jest on a component that imports its global styles from an external css template literal fails with the following:
    ReferenceError: styles is not defined

styles refers to import name of the external module than exports a css template.

If the current behavior is a bug, please provide the steps to reproduce and possibly a minimal demo or testcase in the form of a Next.js app, CodeSandbox URL or similar

Create a brand new React application with latest create-react-app and eject it.

npx create-react-app@next --scripts-version=2.0.0-next.3e165448 styled-jsx-jest
cd styled-jsx-jest
npm run eject

Install styled-jsx.

npm i styled-jsx

Configure Babel to use styled-jsx/babel by adding the following to package.json

  "babel": {
    "presets": [
      "react-app"
    ],
    "plugins": [
      "styled-jsx/babel"
    ]
  }

Delete src/App.css and create a new src/App.styles.js file with the following contents:

import css from 'styled-jsx/css';

export default css`
  .App {
    text-align: center;
  }

  .App-logo {
    animation: App-logo-spin infinite 20s linear;
    height: 40vmin;
  }

  .App-header {
    background-color: #282c34;
    min-height: 100vh;
    display: flex;
    flex-direction: column;
    align-items: center;
    justify-content: center;
    font-size: calc(10px + 2vmin);
    color: white;
  }

  .App-link {
    color: #61dafb;
  }

  @keyframes App-logo-spin {
    from {
      transform: rotate(0deg);
    }
    to {
      transform: rotate(360deg);
    }
  }
`

Make src/App.js use the recently created styles by importing App.styles.js and using

    );
  }
}

export default App;

Run the application and its tests and verify that everything works ok.

# Start app
npm start

# ...run tests
npm test

This is the crucial step. Add the global attribute to

Run tests again. They will fail.

 FAIL  src/App.test.js
  ✕ renders without crashing (10ms)

  ● renders without crashing

    ReferenceError: styles is not defined

       6 |   render() {
       7 |     return (
    >  8 |

       9 |
      10 |
      11 |

      at App.render (src/App.js:8:7)

What is the expected behavior?
Tests run normally and pass.
Environment (include versions)

OS: macOS High Sierra 10.13.5
Browser: N/A
styled-jsx (version): 2.2.7

Did this work in previous versions?
Unsure. Tried it with 2.2.7 and 2.2.5 (same result).

@nfantone does CRA support custom .babelrc?

I am having this same issue with 2.2.6.

hey folks can you try with<EMAIL_ADDRESS>this issue might be solved in the new version

@giuseppeg Yep, having the same issue when using<EMAIL_ADDRESS>with babel-jest.

You folks should mock styled-jsx/css. It is not necessary to compile styles with styled-jsx and test them.

since v3.1.0 we also support this https://github.com/zeit/styled-jsx#rendering-in-tests


Tag generation makes build fail when a file is deleted

When deleting a file while developing, the build always fails because the meson script generating tags uses git to list files.
Also happens when moving a file.

My vote is to remove tag generation.

Actually @agx did the implementation so maybe he's using it and will fix it.

On Fri, Mar 23, 2018 at 01:14:37AM +0000, Tony Crisci wrote:

Actually @agx did the implementation so maybe he's using it and will fix it.
I'll have a look.

Does freebsd have '-f' - is so we can use that instead

Oh, I see it has. PR forthcoming.


Support numeric public key ids for actions

closes #1835

@gmlewis thanks for reviewing. I've made the suggested changes

Thank you, @wesleimp .
Merging.


ENH: stats: add 'alternative' parameter to ansari

Reference issue
Closes gh-688
Addresses gh-12506
Superseded gh-5012
What does this implement/fix?
Ansari-Bradley test was missing the alternative parameter. As I don't have access to the book used for the implementation in SciPy, I have referred to another source ([3]_) and tried to port the logic to SciPy. To confirm that the new implementation is correct, a large and comprehensive test suite has been added with intuitive tests as well as tests comparing SciPy's result with that of R. Moreover, I have attempted to write a perspicuous explanation of the new parameter. An example elucidating the alternative parameter has also been added to the documentation suite.
Additional information
A (stalled) PR gh-5012 has been proposed a long time ago but the implementation is wrong. It also doesn't document or test the new parameters. I hope this serves as an improvement over gh-5012.

Merged master for the documentation build failures to go away.

Nit: if possible, prefer rebase+force-push to merging master (keeps git history cleaner for future bisections)

@ev-br on PRs reviewed by me, that is not done until the end because of the broken history. This will be squash-merged anyway.

please continue to merge master mid-development and consider rebasing just before merge (with warning so i can backup the original branch to see that nothing changed) if the history can be cleaned up, otherwise we'll squash merge .

Sure!

I think I have addressed all your remaining comments @mdhaber. Please tell me if I have missed anything.

@tupui ...and another!

Thanks @tupui for the review. I have made all the changes you asked for. Looks good now?

I will let @mdhaber merge as he was more involved here and may have a final say.

OK now I am definitive 😅 LGTM for real.

@mdhaber Yes 🙌 I've followed from further but LGTM too. Thanks.

I've followed from further (last changes) but LGTM too

That's fine, since it doesn't affect the behavior of the code right now. I would only ask you to get into the weeds with us if we want to add the method='exact' (again) before actually implementing the null distribution considering ties.
+2 positive reviews, so merging. Thanks @tirthasheshpatel, @tupui!

False alarm. I think we just never updated the examples after the new default_rng seed was implemented.

Thanks for addressing the documentation failures @mdhaber. All green now!

Thanks again @tirthasheshpatel @tupui!


Revert "Add Header and Cleanup (#38)"

This reverts commit ed2d2826b82b7dc59b6faf108cac75226d32bdb0.
Reverting this PR due to test failures from code restructuring. Test failures that were established included overwirte/append writing to Master.
Lets resubmit this as smaller PRs separately for Headers, Tooling changes and Code Restructuring, i.e. 1 feature is 1 PR.

@cchighman  as FYI.  Reverting due to issue in master. Lets submit as separate PRs please.
@rajmera3  @arvindshmicrosoft  take note


ActionView::Template::Error in Communication::Website::IndirectObject::SyncWithGitJob@elephant

Error in Osuny
ActionView::Template::Error in Communication::Website::IndirectObject::SyncWithGitJob@elephant
undefined method `+' for false
View on Bugsnag
Stacktrace
app/models/communication/block/with_heading_ranks.rb:27 - heading_rank_base
app/models/communication/block/with_heading_ranks.rb:17 - heading_rank_children
app/views/admin/communication/blocks/_static.html.erb:14 - _app_views_admin_communication_blocks__static_html_erb___2130194638417292976_224800
app/views/admin/communication/contents/_static.html.erb:11 - block in _app_views_admin_communication_contents__static_html_erb___1697236805731657362_224620
app/views/admin/communication/contents/_static.html.erb:10 - _app_views_admin_communication_contents__static_html_erb___1697236805731657362_224620
app/views/admin/communication/websites/posts/static.html.erb:35 - _app_views_admin_communication_websites_posts_static_html_erb___4289328364404573928_244020
app/services/static.rb:30 - render
app/models/communication/website/git_file.rb:66 - to_s
app/services/git/analyzer.rb:49 - computed_sha
app/services/git/analyzer.rb:24 - should_update?
app/services/git/repository.rb:89 - block in sync_git_files
app/services/git/repository.rb:84 - each
app/services/git/repository.rb:84 - sync_git_files
app/services/git/repository.rb:26 - sync!
app/models/communication/website/with_git_repository.rb:42 - sync_indirect_object_with_git
app/jobs/communication/website/indirect_object/sync_with_git_job.rb:4 - execute
app/jobs/communication/website/base_job.rb:29 - perform

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
ActionView::Template::Error in Communication::Website::IndirectObject::SyncWithGitJob@elephant


[zh] sync patch-releases.md

Sync with en.
content/zh-cn/releases/patch-releases.md

Preview: https://deploy-preview-37899--kubernetes-io-main-staging.netlify.app/zh-cn/releases/patch-releases/

/lgtm

/approve


Fix CGo callback

It is not allowed to let C directly call Go functions, wrapper functions must be made. If it worked before, that was probably by accident.
Fixes #1

Sorry that I didn't reply sooner.
First: Thanks for the Pull request!
Well, it worked before (go1.1, i think), apparently cgo changed.
And it doesn't build for me, it seems the librsync API changed. Doesn't build with librsync1.0.0, which is the only version my distro offers. I'll look into this (might take some time).

Thank you for looking into it!
I expected it wouldn't work on version 1.0 as I had dug a bit into it as part of this fix, but my disto (Debian 8) only has version 0.9.7 or so.
The issue is that there was a security issue fixed in librsync in version 1.0.0. The 'strong' hash was only 8 bytes (64bit) long. The fact it was a very insecure hash (md4) didn't even matter a lot anymore at that size. As part of the fix, the constant for the default hash size has been removed and the hash changed to blake2b (which is not much slower but is cryptographically secure).
In a personal project I'm using 32 bytes (256bit) blake2b, which seems like a good default to me.
I am willing to fix librsync 1.0.0 compatibility if needed, but that'll take a few days. My other system has Debian testing with the new librsync, so I can test the changes.

Go 1.6 breaks cgo, again (they say for the last time).
I have written a workaround that should fix the issue. It doesn't fully fix it, though, it panics when I try to use it with my own code.
The repository is here:
https://github.com/aykevl/golibrsync/tree/fix-newer-versions
This is still not a fix for librsync 1.0.0 compatibility (turns out Debian stretch still uses the old version).

I have fixed librsync 1.0.0 compatibility. I have tested against both 0.9.7 (jessie, stretch) and 1.0.0 (experimental).
The API had to change a little bit or it would get cluttered, but updating is very simple and it's easier to change the API in the future without breaking compatibility.
The new code is in the same branch. Should I make a new pull request for that?

Looks great! I like the API changes and it seems to work great with 1.0.0. Merging right now. Thank you very much!
I'd like to include you in the copyright file or a contibutors file, if you are okay with that?

:D
Yes, I'd like to be included in the contributors/license file.

Okay, I added a CONTRIBUTORS file (commit bd612bb624). If you don't like something about your entry there, feel free to send a pull request with the changes.


Fixed link

Changed the old Codeplex link to the new repository at GitHub.
Fixes #600

@sebagomez,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

I see. I thought you would have just made the change in the old PR, because it's still open. Let me get that one closed and I'll come back and look at this one.

#sign-off It's okay to go ahead and merge this change.
@sebagomez Thank you for your contribution.


Search packages by tags

As of now, packages have some tags assigned to them, but those have just informative purpose, and thus not very useful.
I would like to have ability to search packages with specific tag(s).
For instance, see intx package below:

It has tag #biginteger - I would like to click on it and see other packages that implement extended precision arithmetic (now it is just inactive element on page).
More even, if I now enter "biginteger" in search box, I won't find even intx iself.

Being about to select "all" would be super useful because the tags are super inconsistent and have no structure.
Taking testing libraries, I want to generically search for them to get an idea of what exists... however not all of them have "test" in the name and there are 2 dozen + tags that need to be Manually selected

Another example where there is more then one page

It would also be great to sort the tags like dee2db1cbaa6c9e56086e9b758c1bf93da50fb30 :)


Don't log known programmes again

Makes programme role assignment in database optional. In case it's not filled, no role is assigned, but there is no message logged. Prevents known programme, such as "Informatika" (common for all FIT students)
Solves #151.

Needs to be tested prior to merge

unknown assignment is logged
known assignment, non-null is not logged, and is assigned
known assignment, null, is not logged, and nothing is assigned


Fix Min/Max Kelvin color temp attribute for Google

Max Kelvin is actually Min Mireds and vice-versa. K = 1000000 / mireds
Description:
When the refactor for google_assistant and some additional color_util changes were done, there was an oversight in the reported Kelvin attribute for Google Assistant. The maximum kelvin is actually the minimum mireds and vice-versa. This caused the color temperature for white to skew towards super warm when utilizing Google Assistant. This PR fixes this.
Related issue (if applicable): fixes #14364
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

@balloob Since you wrote the refactor, you might be the best person to review this?

Thanks!

In my Home Assistant / Google Assistant setup, the color temperature still seems to be reversed.  i.e. asking Google to set the lights to "daylight" or "soft white" results in warm/soft white, whereas asking it to set the lights to "candlelight" results in cool white.  I'm using 0.76.2.

@duffrecords You should probably open an issue as merged PR's aren't a method of support. However please try unlinking and relinking the skill. Had to do that for this change to take effect


ReadOnlySpan should implement IReadOnlyList

I would love to use ReadOnlySpan in a project I'm working on as it would simplify a lot of code, however in order for it to be useful for us it would need to implement IReadOnlyList, as that is how all of our data is passed around. This should be a minimal amount of work, as the interface only mandates an indexer and a Count property, and both of those already have been implemented.

Span<T> will be a stack only type. See https://github.com/dotnet/corefxlab/blob/master/docs/Span.md.
In practice it means it won't be possible cast it to an interface (as this boxes and so puts the instance on the heap). Maybe Memory<T> could implement some interfaces, but I would have to first understand what code you were hoping to simplify with Span?

Essentially we're constructing a list of objects in C++ code and then accessing this list on the C# side. Since we don't want to duplicate all of these objects (as the lists can be quite large and memory consumption is a concern) we've created a type that acts similarly to the unsafe constructor on Span to access the items without duplicating them and handle type safety. There are some other lists we create on the C# side, and so to make consumption of our API simpler we just expose everything as an IReadOnlyList (since users shouldn't be modifying what we expose as well).

Interesting.
Initially I thought Memory<T> is the type you could use, but I am not sure we want to implement the interface on Memory either. I will think about yous scenario though once the design of Memory<T> gets clarified a bit more.

Changing title to ReadOnlyMemory. Spans won't be able to implement any interface. Memory type will be able to. We need to decide if we want to do it.

That'd work fine for us as long as there's a constructor that takes a pointer and a count and I can use it to index into it like an array. The reason I initially looked at ReadOnlySpan was because of its public unsafe ReadOnlySpan(void* ptr, int length) constructor. I don't see a similar constructor on ReadOnlyMemory?

OwnedNativeMemory can be created out of ptr and len, and then used as follows:
https://github.com/dotnet/corefxlab/blob/master/tests/System.Buffers.Experimental.Tests/MemoryTests.cs#L47

That would be perfect then. Thanks for keeping us in mind!

@ahsonkhan, can you triage this issue? I would like to remove all System.Memory issues from corfxlab. thanks.

Moving this issue to the corefx repo for future consideration and tracking
https://github.com/dotnet/corefx/issues/28282


IGAPP-1315: Adjust toolbar

Please check:

the design where the toolbar should be shown and which items
check that the items are working

Note:

Feedback adjustments and social media sharing will be done in different tasks
Toolbar is missing in designs for local news. for tunews list (infinite scrolling) there is no toolbar.

Sorry to nitpick but I found a few more small issues:

The toolbar is quickly rendered very much on top on desktop before being pushed down and therefore quickly flickers behind the "local information" icon. Observable by switching back and forth between news and local information tabs  (or between the local and tünews news tabs) and looking at the local information icon.
I can still reproduce the toolbar being pushed down on mobile after the content was loaded.
The bottom border color of the last item in the pois list shadows the divider of the toolbar on desktop which looks a little weird, see screenshot. Maybe we can also just use the same border color for the pois list?

Feel free to ignore any or all of those issues and/or create an issue for them, it looks quite amazing!

@steffenkleinle i fixed all the issues

by using useLayoutEffect
checking isLoading for mobile
just relies that you have to restart yarn start to use updated theme colors


[Doc Improvement][Update build your first message extension app using javascript SBS guide]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-gs-msgext.yml
91
45
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 90c86b3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-new-app1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-project.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-msgext.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-gs-msgext.yml
90
47
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit baca78e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-new-app1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/enter-project-name.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/folder-structure-mex-app.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/new-window-notification.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-browse.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-default-location.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-language-tab.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-msgext.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-gs-msgext.yml
90
47
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit c101cc6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-new-app1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/enter-project-name.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/folder-structure-mex-app.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/new-window-notification.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-browse.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-default-location.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-language-tab.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-msgext.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-gs-msgext.yml
90
47
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f47355f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-new-app1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/enter-project-name.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/folder-structure-mex-app.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/new-window-notification.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-browse.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-default-location.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-language-tab.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-msgext.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-gs-msgext.yml
90
47
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 96c5d29:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-new-app1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/create-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/enter-project-name.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/folder-structure-mex-app.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/new-window-notification.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-browse.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-default-location.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-msgext/select-language-tab.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-msgext.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Empty modal

I'm submitting a ...
[x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Modal has no content/modal template doesn't render
No console errors

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal

This component is wired into a number of other components and is being reused all over the site. Make a minimal recreation on plunkr isn't possible. This is the component at its most basic. The modal opens, but there is no content. Nothing inside. If I open dev tools and "edit as html" there is conent in the modal.
The defaultOverlay is set in my app component template.
Basic functionality, I need the component, if active, allow a click event. Hence the renderer.listen()
However, the template in the modal alert doesn't render, and gives me an empty template.
YES I HAVE BOOTSTRAP STYLE IN MY INDEX.HTML
export class EquipmentComponent{
    @Input() isActive: boolean;
    @Input() equipment: any;
    @Input() width: number;
    height: number;
    name: string;
    equipmentImg : any;
    transferData: Object;
    constructor(
        private el: ElementRef,
        private rend: Renderer,
        private vcRef: ViewContainerRef,
        overlay: Overlay,
        public modal: Modal){

    }
    ngOnInit() {
        this.name = this.equipment.name;
        this.equipmentImg = this.equipment.imgUrl;
        this.height = this.equipment.height * 12;
        console.log(this.isActive);

        //data transfers on drop
        this.transferData = {
            e: this.equipment,
            w: this.width
        }
        if(this.isActive){
            this.rend.listen(this.el.nativeElement, 'click', () => {
                this.openConfig();
            })
        }
    }
    openConfig(){
          this.modal.alert().size('lg').showClose(true).title('A simple Alert style modal window')
        .body(`

Alert is a classic (title/body/footer) 1 button modal window that
            does not block.

            Configuration:

Non blocking (click anywhere outside to dismiss)

Size large

Dismissed with default keyboard key (ESC)

Close wth button click

HTML content

`)
        .open();
    }

}

What is the expected behavior?

I just want the basic demo template to render, but i'm getting an empty modal.

Please tell us about your environment:

Angular 2.0.0 official
Electron

I can't really figure out what happens without examples.
Do you get any console error?
The body is TEXT only, not HTML, do you get the text inside?

I'll close this stale issue, please re-open with a comment if it still an issue.

Same issue for me as well.
I simply copied your example from here:
https://github.com/shlomiassaf/angular2-modal/blob/master/src/demo/app/bootstrap-demo/bootstrap-demo-page/custom-modal-sample.ts
And the usage from here:
https://github.com/shlomiassaf/angular2-modal/blob/88bcadaedd22277cf7b6dd55dcb3e48ed10589fb/src/demo/app/bootstrap-demo/bootstrap-demo-page/bootstrap-demo-page.ts
So there are no errors in compilation and the Modal seams to load but it is empty, i.e. template isn't rendering.

@ronenmiller Did you solved it? Same issue for me

Yes, you only need to configure the modal in the main app component. Then in every other module just use it when getting the public instance via the constructor.

@ronenmiller , can you give some more details please ? I have tyhe same problem, Sometimes I got this empty modal and I couldn't figure out why it is not rendering. Thank you

Instantiate Overlay from 'angular2-modal' in the constructor of the component and set the defaultViewContainer of it as a ViewContainerRef object
`import { Overlay } from 'angular2-modal';
import { ViewContainerRef } from '@angular/core';

constructor(overlay:Overlay,vcRef: ViewContainerRef){
overlay.defaultViewContainer=vcRef;
}`


SV seat error

Not sure how to replicate this, ive seen this error happen a 70+ times on serverside over the last weeks.
addons/acf-3/lua/entities/acf_seat_alias/init.lua:106 - Tried to use a NULL entity!
1.  <unknown> - [C]:-1
 2.  GetModel - [C]:-1
  3.  <unknown> - addons/acf-3/lua/entities/acf_seat_alias/init.lua:106

Locals
SelfTbl = {
  Enable = Function [
  acf-3/lua/entities/acf_base_simple/init.lua:11
]
  PhysicsUpdate = Function [
  gamemodes/base/entities/entities/base_anim.lua:33
]
  Base = "acf_base_simple"
  ApplyDupeInfo = Function [
  wire/lua/entities/base_wire_entity.lua:461
]
  PrintName = "Simple ACF Base Entity"
}
self    = Entity [1767][acf_seat_alias]

Looks like this was probably fixed in https://github.com/ACF-Team/ACF-3/commit/5088e6cbead22b6d8d3c9c9addd3fba8f9e2c421, so once that commit gets pushed to the main branch this issue can be closed


feat(build): clean build folder before rebuilding all targets

Cleans the "Build" directory before rebuilding all targets.
Normally, the expectation is that:

building one or specific set of targets - do not clear
building all targets - rimraf (clear) the build directory before building

Resolves the edge cases described in linked issue.
This improves the readability of the build logic by separating custom rollup plugins into reusable units.  Moving them into the "utils" folder and out of the root of the project.
Fixes: #5588
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Anytime, send through anything you need done.
I want to explore reusing those plugins.  I have a build change in mind, this will make it easier to review.


Precedence order when setting app release

When working with the Symfony SDK I noticed that the app version set in composer.json as below is prioritised over the SENTRT_RELEASE environment variable set in .env file.
{
    "type": "project",
    "license": "proprietary",
    "version": "1.58.1",
    "minimum-stability": "stable",
}

The precedence order according to my tests was:

Release set in config/packages/sentry.yaml
“Version” tag added to composer.json
SENTRY_RELEASE environment variable set in .env

Because only the environment variable and sentry.yaml options are documented, I would expect these two to take precedence over all other automatically detected releases. Is this intended behaviour?
I’m using:
Sentry Symfony SDK v4.2.9
Composer v2.0.9
Symfony v5.4.8
PHP v7.4.29

Is this intended behaviour?

To be honest, I think we didn't think about this behaviour at all. What's happening is that since the sentry.options.release default value is taken from PrettyVersions::getRootPackageVersion()->getPrettyVersion(), if the version field in the composer.json is available then that value is the one used and no fallback to the env var happens. If you forcefully set the option to %env(SENTRY_RELEASE), it should work. I think that this behaviour may be better documented indeed, and the proper repo to report this is getsentry/sentry-docs

@kamilogorek do you think that it would make sense to prefer the environment variable to the version stored in the composer.json? I think that the same question may apply on projects built with the NodeJS SDK, so maybe a decision was already laid out in the past on the expected behaviour

For sentry-cli we use this ordering (from the highest priority):

Arguments passed directly to the command, eg sentry-cli --auth-token=foo
Env vars, SENTRY_AUTH_TOKEN=bar
Dotfiles
Config files

So yes, I'd prefer env-vars over composer.json


Camping Healers out of LOS

When doing a boss fight where I positioned with healers out of LOS to avoid AoEs, I noticed that they immediately put themselves in LOS before casting heals.
I think this is part of the doAssist routine, when i commented out the assist.checkLOS() they would heal without moving into LOS.  What would be the best way to avoid having a cleric hit that?  Maybe just set their assist min to 101?
function assist.doAssist(reset_timers, returnAfterAnnounce)
    local assistMobID = assist.getAssistSpawnIncludeManual()
    if assistMobID == 0 then return false end
    if assist.checkMATargetSwitch(assistMobID) then
        if assist.targetAssistSpawn(assistMobID) then
            assist.setAndAnnounceNewAssistTarget(assistMobID, reset_timers)
            if returnAfterAnnounce then return true end
        end
    end
    if state.assistMobID == 0 then return false end
    if not state.medding or not config.get('MEDCOMBAT') then
        if class:isAbilityEnabled('USEMELEE') then
            assist.getCombatPosition()
            if state.assistMobID and state.assistMobID > 0 and not mq.TLO.Me.Combat() and class.beforeEngage then
                logger.debug(logger.flags.routines.assist, "beforeengage")
                class:beforeEngage()
            end
            assist.engage()
        else
            --assist.checkLOS()
        end
    end
    assist.sendPet()
    return true
end

might be easiest to just put them into manual mode? or you could cheat and do a /rootme
they try to get los because even healers still tend to have some debuff or nuke or something in their lineup somewhere.

Ah ok Manual mode should work, didn't realize that would let them keep healing.  Will give that a go next time thanks


Support Python 3.6

Can you support Python3.6 ?
I tested on my machine (Python 3.6) that working fine.

Thank you!


Standardize naming convention of phar files in releases

It would be easier to move support for phpcs and phpcbf in setup-php to this repository if the naming of the phar files in the releases follows a convention across all releases.
Currently, the files in the latest release 3.8.0 do not have version numbers, while the files in the older releases do.

@shivammathur Yes, I was wondering about that and still meant to contact you about what would make it easier to support (well, I was about to contact you at the beginning of December, when I saw you had already made a commit for the repo address change, so I wasn't sure it was still needed 😉).
For the record: when I recreated the releases for the 2.0 - 3.7.2 versions (which were released before I took over the repo), I uploaded the PHAR files to those releases with file names including the version number (mostly for my own sanity while recreating the releases).
More than anything, I wanted to make sure that the releases would be available and available in a predictable location.
PHAR files for releases, including new releases like the 3.8.0 release, are available in the following places with the following naming conventions:

Type
Location
Available releases
Naming Convention

Permalink to latest release
https://phars.phpcodesniffer.com
latest only
No version number, phpcs.phar and phpcbf.phar

PHIVE release location
https://phars.phpcodesniffer.com/phars
3.2.0 -  latest
With version number, phpcs-3.8.0.phar etc

GitHub release page
https://github.com/PHPCSStandards/PHP_CodeSniffer/releases
2.0.0 - latest
2.0.0 - 3.7.2 with version nr, 3.8.0 and later without

The reason I did not include the version number in the GH release uploads for the 3.8.0 release was to allow for another type of permalink, which would again always get the latest release: https://github.com/USER/PROJECT/releases/latest/download/package.phar.
This means that https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/latest/download/phpcs.phar and https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/latest/download/phpcbf.phar also work to always get the latest release.
Uploading the PHAR files on new releases (only) with version numbers in the filenames would block the use of those GH native permalinks.
I am perfectly happy to upload both with and without version number to GH releases, but I can also imagine that one of the other download locations may suit the needs of setup-php just as well ?
Let me know what your thoughts and I'm happy to accommodate.

Note to self: might also be a good idea to add the above table to the installation page in the Wiki.

Hi @jrfnl
For the next release, unless you upload versioned files to 3.8.0, it would mean that till 3.7.2 we have versioned ones, and 3.8.0, and afterward we have unversioned ones.
In terms of implementation in setup-php, if the latest release has versioned files then it would have to get the version first to download the file. Files without versions in the latest release are good as they can be directly downloaded using the latest URL scheme of GitHub releases.
So I prefer unversioned files as well, but as you mentioned maintaining versioned ones was easier. I would leave the decision to you, it would help if it is consistent across releases. Uploading both types of files to all releases would also work and make it consistent if it is not too much work. In my experience using gh release for this helps.

For the next release, unless you upload versioned files to 3.8.0, it would mean that till 3.7.2 we have versioned ones, and 3.8.0, and afterward we have unversioned ones.

Correct (for the GH releases download location).

Files without versions in the latest release are good as they can be directly downloaded using the latest URL scheme of GitHub releases.

Well, that was my intention to use going forward.

So I prefer unversioned files as well, but as you mentioned maintaining versioned ones was easier.

I'm not saying versioned ones is easier, it only was for uploading the historic files.
And no, I have no intention of updating the old releases to add unversioned files as well, as it would mean copying four files for each release to a temp location, renaming them there to be unversioned, then uploading to the right release and deleting the local copies, rinse & repeat 56 times. I have better things to do with my time.

Yes, I understand.
Can we add the versioned ones to 3.8.0 and new releases moving forward, that would also work.

Uploading both types of files to all releases would also work and make it consistent if it is not too much work. In my experience using gh release for this helps.

@shivammathur I've spend some time now getting GH CLI setup and scripting this out.
All releases in this repo now have both the versioned as well as the unversioned PHAR files, and where applicable the versioned and unversioned ASC files (PHPCS 3.2.0+) as well.
I'm tempted to remove the versioned versions of the files now and make it all consistent by always just and only having the unversioned PHAR and ASC files as assets for a release.
Having 4 duplicate files for each release is a bit irksome.
What do you think @shivammathur ?

@jrfnl
Thanks for working on this.
Yes, versioned ones are not required since we have the unversioned ones now.

Okidoki. All done now. All releases on GitHub now only contain unversioned assets.
I will add a mention of this to the changelog.

Updated download location table
PHAR files for releases, including new releases like the 3.8.0 release, are available in the following places with the following naming conventions:

Type
Location
Available releases
Naming Convention

Permalink to latest release
https://phars.phpcodesniffer.com
latest only
No version number, phpcs.phar and phpcbf.phar

PHIVE release location
https://phars.phpcodesniffer.com/phars
3.2.0 -  latest
With version number, phpcs-3.8.0.phar etc

GitHub release page
https://github.com/PHPCSStandards/PHP_CodeSniffer/releases
2.0.0 - latest
No version number, phpcs.phar and phpcbf.phar


update ci workflows to run weekly

Should be the same PR as for pytket-aqt

Can we maybe think about activating auto merge here, too?

Can we maybe think about activating auto merge here, too?

Not a big fan of automerge personally.

Can we maybe think about activating auto merge here, too?

Not a big fan of automerge personally. But if you like we can.

I have only started using them for already discussed PRs like this one on the other repos, maybe this is a useful case?


fix: add ref to AccordionItem #3498

Closes #3498
📝 Description
Fix issue where AccordionItem ref is not properly implemented, add typescript typing
⛳ Current behavior (updates)
AccordionItem does not currently support ref.
🚀 New behavior
AccordionItem now implements ref.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information

Summary by CodeRabbit

New Features

Enhanced the AccordionItem component to support ref forwarding, improving focus management and interactivity.

Tests

Added a new test case to verify the correct forwarding of refs in the AccordionItem, increasing test coverage and reliability.

please include changeset

oops, done!


Don't turn undefined symbols into an error

Clang does not seem to link to libasan when creating shared libraries.
Fixes: #8735
[extended tests]

So it seems #8537 introduces that -z defs things, and travis has been failing since.

At least for the msan case it seems we can't resolve this. It does not have a shared library we can link to, and the static library is not build using -fPIC and the name of that library depends on the architecture.

Hmm, what's up with Travis?

Also, how did the asan and msan stuff work before we ensured modules wouldn't be built without unresolved symbols?

The tests failing on travis already existed, this PR doesn't change that. Note that I've enabled extended tests. This fixes 3 of the 5 broken builds.
asan, ubsan and msan work just the same way as before we used that -z defs, by linking their library in the executable, not the shared library.
I'm not sure why this z defs was added. Did the provider pick up symbols from libcrypto.so, or did it also fail just at some later place?

asan, ubsan and msan work just the same way as before we used that -z defs, by linking their library in the executable, not the shared library.

Then it sounds like the problem lies there, that our shared libraries should be linked with the *san stuff when that's used.

I'm not sure why this z defs was added. Did the provider pick up symbols from libcrypto.so, or did it also fail just at some later place?

Most importantly, the FIPS provider module shouldn't pick up stuff that the application is linked with by accident. That completely defeats the purpose of it being self contained. We extended that to all modules, with the thought that for any external symbol, they should be explicitly linked with the needed libraries, not piggy-back on whatever the application is linked with (which is a recipe for failure anyway, since you can't be sure that the application is linked with all the module needs)

asan, ubsan and msan work just the same way as before we used that -z defs, by linking their library in the executable, not the shared library.

Then it sounds like the problem lies there, that our shared libraries should be linked with the *san stuff when that's used.

Like pointed out above, I can fix that for asan and ubsan, not for msan.

https://clang.llvm.org/docs/MemorySanitizer.html confirms that one should not combine -z defs with msan. So that essentially means that we should not use that flag specifically when msan is enabled. Removing -z defs unconditionally is counter-productive, though.

If you have an other suggestion, feel free to open an other PR.

I will look tomorrow. Way too late tonight


how to run train.ipynb?

Hi, Avinash Paliwal
I try to use 'Jupyter notebook' to open train.ipynb, but Jupyter notebook says "Unreadable Notebook: F:\Super-SloMo-master\train.ipynb NotJSONError('Notebook does not appear to be JSON: '{\n "nbformat": 4,\n "nbformat_minor"...',)"
Is this a bug or there is other method to run train.ipynb ?

@avinashpaliwal  hello avinash how do i run the train.ipynb in conda environment...i know for python we use python filename.py and then enter ,,,so it runs

Hi @eng100200 if you have downloaded the anaconda UI application, you can launch the JupyterLab or Notebook
or run the command from project directory:
jupyter notebook

or
jupyter lab

Then you can open the train.ipynb file in jupyter.

Thanks Avinash Paliwal, and happy new year.
However, I mean Avinash Paliwal that i still want to use python command prompt and want to run ipynb file. then how can i do it?

@avinashpaliwal please reply

@eng100200  I have added the train.py script. You can now train from terminal.

@avinashpaliwal  Thanks

@avinashpaliwal your train net use UNET,right, so it can be used for mobile devices?


Move some of README into the official docs

Can we move some of the README stuff into the official docs in deis/workflow?

Mainly, we need that configuration stuff to go in the appropriate subsection of the documentation. Not in the main installation section. That's already getting way too long.

Can we move some of the README stuff into the official docs in deis/workflow?

We can, but it re-raises the recurring question of how to effectively manage documentation for a component that is reusable on its own as well as relevant docs for the same component within the context of the broader platform.
If these docs move, we impair anyone wanting to use this without workflow.  If we copy them, we create a maintenance burden for ourselves.
I'm at a loss.

The most crucial bits of router documentation as it relates to workflow have been adapted and added to the workflow docs.  Closing.


Support random boolean value

Changes:

Create the Faker::Boolean class to generate random boolean values.
An optional parameter true_ratio for changing the true/false distribution.

@sibevin What's wrong with using plain [true, false].sample?

Here is why I want a Faker::Boolean:

For readability: Using Faker::Boolean means this value is for the faking purpose, but with [true, false].sample, it's not so observable what it's really for.
For encapsulation: There are many ways to implement the random boolean generation. If you are working with a big team, you cannot guarantee everyone implement it with the same way as yours. On the other hand, if someday we have a requirement which need to change all random boolean to be true for some reasons, we can just change the Faker::Boolean implementation.
For extensibility: With Faker::Boolean, you can control how to generate the boolean value, just like the true_ratio option.

Why when Faker::Boolean.boolean return false - i had error: Validation failed: Fieldname auth can't be blank?


fix: handle zero-dimensional tensor

This commit fixes the following bug:
When the number of frames in a video is batch_size + 1 (e.g. batch_size = 32, and the video has 65 frames), the last frame is processed separately as an image_batch. The returned aesthetic_scores.dim() == 0, which leads to an error in torch.cat(aesthetic_scores_list, dim=0) with the message: RuntimeError: zero-dimensional tensor (at position 2) cannot be concatenated.

I also stumbled upon this bug,
I fixed it by adding dim=1 argument to the squeeze method

I met this error two. I has fixed the bug by adding        if aesthetic_scores_list[-1].dim() == 0:             aesthetic_scores_list[-1] = aesthetic_scores_list[-1].unsqueeze(0)         before aesthetic_scores = torch.cat(aesthetic_scores_list, dim=0)

Similar to #85


Question regarding pyuca in Spyder 6.0.0a3

With version 6.0.0a3 Spyder introduced a new dependency on pyuca (https://github.com/spyder-ide/spyder/commit/77ff71b564812c4529cb67d551eef4f791d76b6e). I'm one of the package maintainers of Spyder in Fedora. Since we are required to package all dependencies seperately, I submitted pyuca as a new package for Fedora.
It turns out that in the current release, dating back to September 2017, the license situation wrt to the Unicode license(s) is unclear. I'm trying to get clarification internally as well as from the pyuca developer(s). However, the last commit to pyuca was made in October 2019.
So, we have a release from more than six years ago and a commit from more than four years ago. That raised my eyebrow, wondering why make Spyder dependent on a module that appears to be no longer under active development / maintenance?
If pyuca turns out to be not permissible in Fedora, that would make things very complicated keeping Spyder up to date downstream. I'd appreciate any thoughts on the matter.

That raised my eyebrow, wondering why make Spyder dependent on a module that appears to be no longer under active development / maintenance?

That module is quite simple: it allows to sort Unicode strings. That's why it probably doesn't require updates and additional maintenance. But I reviewed how it works and it doesn't its job as expected. And we need something like that in Spyder because we support languages such as Chinese, Japanese and Russian, so we want to provide a UI that makes sense for users in those languages.

If pyuca turns out to be not permissible in Fedora, that would make things very complicated keeping Spyder up to date downstream. I'd appreciate any thoughts on the matter.

I understand, but that was the only pure Python package I could find for this. Others require heavy compiled dependencies.

Thanks for the explanation. I was mainly checking to be sure the effort I'm putting into getting pyuca into Fedora is not in vain. Since 6.0.0a3 is still a pre-release, it wouldn't have surprised me, if that was some kind of "let's try that".
I'll close the issue and focus on getting pyuca cleared.


Edge TPU program not working

Thanks for the great tutorial. I followed instructions in "Section 1 - How to Set Up and Run TensorFlow Lite Object Detection Models on the Raspberry Pi" and got it working without any problems.
However, in "Section 2 - Run Edge TPU Object Detection Models on the Raspberry Pi Using the Coral USB Accelerator", got the following error when running the demo script:
(tflite1-env) pi@raspberrypi:~/tflite1 $ python3 TFLite_detection_webcam.py --modeldir=Sample_TFLite_model --edgetpu
INFO: Initialized TensorFlow Lite runtime.
/home/pi/tflite1/Sample_TFLite_model/edgetpu.tflite
Traceback (most recent call last):
File "TFLite_detection_webcam.py", line 140, in
interpreter.allocate_tensors()
File "/home/pi/tflite1/tflite1-env/lib/python3.7/site-packages/tensorflow_core/lite/python/interpreter.py", line 244, in allocate_tensors
return self._interpreter.AllocateTensors()
File "/home/pi/tflite1/tflite1-env/lib/python3.7/site-packages/tensorflow_core/lite/python/interpreter_wrapper/tensorflow_wrap_interpreter_wrapper.py", line 106, in AllocateTensors
return _tensorflow_wrap_interpreter_wrapper.InterpreterWrapper_AllocateTensors(self)
RuntimeError: Internal: Unsupported data type in custom op handler: 0Node number 2 (EdgeTpuDelegateForCustomOp) failed to prepare.
Is it possible that this is related to recent update as noted here?
https://github.com/google-coral/edgetpu/issues/44#issuecomment-579787546
There appears to be a fix:
https://github.com/google-coral/edgetpu/issues/44#issuecomment-579905056
I followed the fix but this did not solve the problem.
Thank you so much again.
My system info:
(tflite1-env) pi@raspberrypi:~/tflite1 $ sudo dpkg -l | grep edge
ii  libedgetpu1-std:armhf                13.0                                armhf        Support library for Edge TPU
(tflite1-env) pi@raspberrypi:~/tflite1 $ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

Thanks for the amazing tutorial.
I have the same issue when running the command python3 TFLite_detection_webcam.py --modeldir=Sample_TFLite_model --edgetpu
then the following error appears:
/home/pi/tflite1/Sample_TFLite_model/edgetpu.tflite
Traceback (most recent call last):
File "TFLite_detection_webcam.py", line 140, in
interpreter.allocate_tensors()
File "/home/pi/tflite1/tflite1-env/lib/python3.7/site-packages/tensorflow_core/lite/python/interpreter.py", line 244, in allocate_tensors
return self._interpreter.AllocateTensors()
File "/home/pi/tflite1/tflite1-env/lib/python3.7/site-packages/tensorflow_core/lite/python/interpreter_wrapper/tensorflow_wrap_interpreter_wrapper.py", line 106, in AllocateTensors
return _tensorflow_wrap_interpreter_wrapper.InterpreterWrapper_AllocateTensors(self)
RuntimeError: Internal: Unsupported data type in custom op handler: 6488064Node number 2 (EdgeTpuDelegateForCustomOp) failed to prepare.

Same issue here, it seems to be a compatibility problem after a recent update to the Coral TPU, has anyone encountered the solution?

UPDATE:
The source of the problem is with the libedgetpu library that updated to version 13 recently and this requires tfensorflow 2.1 which is still not available for raspberry pi (as to why they would release a version of libedgetpu that isn't backwards compatible is beyond me).
Now to make things worse, the people behind libedgetpu's library stupidly only allow you to install the latest version. The way I solved this is by going through a third party repository and downloaded libedgetpu 12.1 from them and installed that instead, and now is working again. Here is the command for you:
wget https://packages.cloud.google.com/apt/pool/libedgetpu1-std_12-1_armhf_99b783b7a9ec7879e010727c92ee92d96f2e6f16d0999099ea05e61fef23d297.deb pip3 install libedgetpu1-std_12-1_armhf_99b783b7a9ec7879e010727c92ee92d96f2e6f16d0999099ea05e61fef23d297.deb

@neftaliw Thank you very much for the information!
I was able to get the edgetpu script running now using older version of libedgetpu  from https://coral.ai/software/  link [(https://dl.google.com/coral/edgetpu_api/edgetpu_runtime_20190920.tar.gz)]
(Your script did not work for me for some reason).
Hopefully these incompatibilities will be sorted out soon.
Thanks so much again.

I fixed it after adding 'from tflite_runtime.interpreter import Interpreter' the following code in TFLite_detection_webcam.py .
This is mentioned in (https://github.com/EdjeElectronics/TensorFlow-Lite-Object-Detection-on-Android-and-Raspberry-Pi/issues/20)
if use_TPU:
from tflite_runtime.interpreter import Interpreter
interpreter = Interpreter(model_path=PATH_TO_CKPT,
experimental_delegates=[load_delegate('libedgetpu.so.1.0')])
print(PATH_TO_CKPT)

These solutions didn't work for me, but I got It working with this with mod from @neftaliw code:
wget https://packages.cloud.google.com/apt/pool/libedgetpu1-std_12-1_armhf_99b783b7a9ec7879e010727c92ee92d96f2e6f16d0999099ea05e61fef23d297.deb
sudo dpkg -i libedgetpu1-std_12-1_armhf_99b783b7a9ec7879e010727c92ee92d96f2e6f16d0999099ea05e61fef23d297.deb
Then I got the libedgetpu1-max working by these commands (I think it's running on max):
wget https://packages.cloud.google.com/apt/pool/libedgetpu1-max_12-1_armhf_bc9b8954aadd2c89d579afc1cfdba3bd3842aa88332ae8ce885699a78f41ca26.deb
sudo dpkg -r libedgetpu1-std
sudo dpkg --purge libedgetpu1-std
I'm not sure if the above command is necessary.
sudo dpkg -i libedgetpu1-max_12-1_armhf_bc9b8954aadd2c89d579afc1cfdba3bd3842aa88332ae8ce885699a78f41ca26.deb
System: RasPi4, 4 GB with Raspbian GNU/Linux 10 (buster) running on latest update.

@killinen Thanks. It works for me.
(running on max)
wget https://packages.cloud.google.com/apt/pool/libedgetpu1-max_12-1_armhf_bc9b8954aadd2c89d579afc1cfdba3bd3842aa88332ae8ce885699a78f41ca26.deb
sudo dpkg -i libedgetpu1-max_12-1_armhf_bc9b8954aadd2c89d579afc1cfdba3bd3842aa88332ae8ce885699a78f41ca26.deb
System: RasPi4, 4 GB with Raspbian GNU/Linux 10 (buster) running on latest update.

@killinen Also thank you. The tips above works for me. @EdjeElectronics thank you for the wonderfully written tutorial. It just needs to be updated to reflect the changes here. Otherwise everyone that tries this now will get the same error above when adding the --edgetpu option.

Thank you everyone for your work on this issue! I will work on testing and implementing the solutions you've discovered.

This error can be resolved by using tflite_runtime v2.1 rather than tflite_runtime v2.0. I changed the get_pi_requirements.sh file to automatically download v2.1 rather than v2.0, so people should no longer run in to this error if they're following my guide from scratch.
If you do run in to this error, you can resolve it by uninstalling your existing version of TensorFlow, and installing tflite_runtime v2.1 instead.
If you're running Raspbian Stretch (which is likely if you're using a Raspberry Pi 3), issue:
pip3 uninstall tensorflow
pip3 install https://dl.google.com/coral/python/tflite_runtime-2.1.0.post1-cp35-cp35m-linux_armv7l.whl

If you're running Raspbian Buster (which is likely if you're using a Raspberry Pi 4), issue:
pip3 uninstall tensorflow
pip3 install https://dl.google.com/coral/python/tflite_runtime-2.1.0.post1-cp37-cp37m-linux_armv7l.whl


Review current Wiki content

https://docs.google.com/spreadsheets/d/1nfRiQobOgwO7O1JSBsZXAiIYBZtCoF4oSRLoe-FHmGE/edit#gid=0

Reviewed with Jarrod (NF); they'll move most content to the new Founders Hub.


3d incomplete

3d will not be finished in this example of functional pascal.
This is a WONFIX.
3d environments get hellish quickly with TnL, Rendered textures, camera angles, collision detection, meshes...
I will provide a working example- thru SceneGraphGL or CastleEngine or similar...but I dont know what you want to do- and you have to understand the OpenGL isnt half-assed, but rather OPEN in many ways. Those devs know even less of what you want.
All of your shaders are your code- not mine, and can be proprietary. Game development takes teams, storyboarding, yada yada yada -and time.  By the time you push out a game- its time to revamp the engine. Ive done this twice already because the code is beyond hell-and-back dated, incomplete, or inaccurate.
Now add OpenGL changing over time- code that used to work- DOESNT NOW. I cant fix the universe- I can only say where the code should work - but doesnt. Fixing GL code requires Intermediate college algebra to fix- and Im not a mathematician.

Borlands API stopped short of this - and stuck to 2d only. I will master most of that for you- point you in right direction, and say good luck. I may toss out some OGL screensavers, tho.


Add a benchmark framework

Raft Engine is in hot develop. It changes every day. So a benchmark framework can help us find performance degradations.

pick up this issue

Closing via #84


docs(operators): add documentation for pairwise

Closes: https://github.com/ReactiveX/rxjs-docs/issues/68

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   74.78%   74.78%
=======================================
  Files           9        9
  Lines         119      119
  Branches        6        6
=======================================
  Hits           89       89
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce8d6f...72def81. Read the comment docs.

For me it looks good. Is it ok to give an approval, or should this be made by "core contributors"?

@JWO719 You can also approve it.

@sumitarora - can you rebase, also can you please fix single quotes.


Implemented skip to content on docs web site

Adding a link at the top of each page that goes directly to the main content:
reference: http://www.w3.org/TR/2012/NOTE-WCAG20-TECHS-20120103/G1

Sadly, we can’t accept this PR because the anchors are used on other subpages for different purposes (see components pages for example).
Also, can you explain your motivation? Is there any page where you have to scroll to get to the content? Or did you intend this to be something like a "Back to Top" button?

angular material docs already supported skip to content link.

I don’t have that button anywhere on https://material.angularjs.org

Pressing the tab button twice, You can see on  https://material.angularjs.org.

Ah, so this is an accessibility feature. Didn’t have any context on this.
As I said, we can’t accept this PR as it would break other pages in the current setup. But we’ll keep this in mind when reworking the components page and might incorporate something similar. Thanks for your work!

ok. This reference is helpful for you.
https://github.com/insanehong/material-design-lite/commit/5e145fee7fc34a086dfa24d4b57c040bf4620553
Also, When to be make to support  skip to content link , you must use with tabindex.

I pushed new commit for this PR that is doesn't break components page and other pages in the current setup.
If You can going to pass this PR, I don't care :D


Raspiblitz 1.3 runs with errors even after several reboots

I have been running a well working Raspiblitz 1.1 since March 2019 on a Raspberry Pi 3+.
This has been a great experience and the node has been very stable and both routed, sent and received many transactions.
As soon as I upgraded to Raspiblitz 1.3 though, the node has not been able to run for more than half an hour or so at a time. When SSL-ing in again after an hour or so, I get the warning that the node is "running with errors".  I first thought it was due to overheating, so I removed the screen from the node setup and the running temperature now stays around 60 C which I believe should be fine.
I also ran the hardware test and no issues were discovered through that.
I attach the debug log here. Please let me know if you have any thoughts on what I can do to get the node up and running again.
I have a number of channels open , but of course 0 of them are active at the moment. And it seems that my node does not have time - or doesnt succeed for any other reason - to re-activate them when I re-boot the node. The nr of active channels stays at 0 until the node fails again.
Many thanks for support!
Here is the full debug log:
https://termbin.com/ttlc

Hi, the problem seems to be with lnd.
Sometimes when there is a big version jump the migration process can have issues, although I did not see this error before:
2019-10-09 19:51:35.252 [ERR] LTND: Unable to start server: unable to fetch node: 02a4ff88f99ec4491b108f5d19d1bf2ea855342f1e646115187218c4e9b83bcefa, unable to find node

You could try to reflash your SDcard to trigger the restore process again which has a chance to solve this problem.
You can make a full backup of your lnd directory first by running:
/home/admin/config.scripts/lnd.rescue.sh backup
Let us know here how it goes. If the same error persists it might be worth to ask in the LND Developer Slack: https://app.slack.com/client/T6AK88MGV/ or https://github.com/lightningnetwork/lnd/issues before progressing to any of the recovery processes: https://github.com/rootzoll/raspiblitz/blob/master/FAQ.md#how-can-i-recover-my-coins-from-a-failing-raspiblitz .

Thank you for taking the time to look into this and answering!
I tried your advice to reflash the SDcard from scratch - I even downloaded the Raspiblitz v 1.3 image again. It worked just as well as last time flashing the SD card and rebooting the system, it synced fully both bitcoin and lightning .  But then when running the system, still none of my open channels are connected.  And after an hour or so, when SSL:ing in again the wallet was locked , which to me means that the wallet has been closed due to some error. Since this behaviour I never saw with the version 1.1, which always worked perfectly. Now i tried again, and again the wallet was locked.
The node is running now, but still failing to liven up any of the channels.  this is my debug log as of now:
https://termbin.com/zxac
Is there any reason not to erase the entire harddrive and then use the LND seed word to set up the node again from scratch? I'm just thinking that that might be easier than trying to find the issue on the Developer Slack and then fixing it.. Or would resetting the entire setup lead to loss of funds or other properties of the node that i should keep?  Not sure if I should actually close all channels and remove all funds before doing that. The annoying part would be to pay all the non-cooperative closing fees, which im not sure if i can actually control myself to only set 1 sat per byte.
thank you for further advice! I am no expert as you notice, but I find the raspberry / LND testing out quite fun from time to time, and the Raspiblitz is a cool packaged way of doing it during the times when it works! (most of the time so far) :)

I just let it run with error until now due to no time to tinker, and the current debug log can now be found here.
Please let me know if you have any advice as to what my next step should be. I still have some sats both on the onchain wallet and in the open channels of the node. Many thanks!
https://termbin.com/jhve

@nanguapie your lnd is still stuck below the block 600000 with the same error.
Not sure why this is, my best guess is database corruption.
Restoring your wallet on a new setup is probably your best bet. You will need:

the seed - for your onchain funds - and
Static Channel Backup (SCB - channel.backup) - for the offchain (channel) funds
your channels with online peers will be force closed and returned onchain.

Read this about the channel backup: https://github.com/rootzoll/raspiblitz/blob/master/README.md#backup-for-on-chain---channel-funds
Run:
./98repairMenu.sh
Make a backup of your LND directory.

Run again:
./98repairMenu.sh
and reset your LND.
From there you can either:

attempt to recover from the rescue file (unlikely to work if the problem is database corruption) or if it fails:
recover from seed + SCB (will force close the channels).

@openoms , thank you very much for taking the time and guiding me with restoring the node! The method you described worked fine, I recovered from seed + SCB and thus force closed the channels. And now the node is stable, finally correctly upgraded to Raspiblitz version 1.3!
I have a couple of reflections though and one final question regarding the channel management - there may be lessons here to learn for next time:

I had 15 channels open when the failed upgrade happened, and I didn't work on fixing it for a few weeks. This may have led to changes happening on the channels without my node's knowledge and thus I may have been punished by losing all funds in some channels.

As of now, I have got approximately half of my funds that were previously in channels now on the on-chain wallet due to what you call above the SCB "force closing" of the channels.  I don't believe actually what happened was a true "force close", since now that I look in the RTL (Ride the Lightning) interface, I can see that there are only 6 channels listed which are all under "Pending" -> "Waiting Close Channels(6)".  My point is that they are not under "Pending Force Closing Channels(0)"

If these closes eventually become successful (should they be successful after 144 blocks, or is the standard setting more?) then I might get more of the channel funds back, which I of course hope for. If not, I guess that they were donated to the friendly channel managers on the other side...

Also, this whole manoeuvre of course incurred 15 on-chain fees for closing the channels. Was there any way in which I could have affected the fee level of those closings? When you close a channel manually you can choose 1 satoshi per byte and just wait a few hours/days/weeks until the mempool is more or less empty, which would be fine in this case.  But now I have no idea what I paid for the channel closings.  This I believe is an improvement area for LND to make on-chain fees more transparent and easy to manage in all different scenarios.  Fees should be a highly prioritized area and if fees start to rise again, there is a risk for a lot of user annoyment if by "automation" users suddenly pay really hurtful fee levels for tasks such as closing channels which is not time critical at all.

Please let me know if you think that is worth reporting as issue to LND and I can do it in that case.
Thanks again for all support!

You can.see what you paid for the closing transactions by looking at the UTXO you received back in.a block explorer.
You would need to look up the tx fee of the incoming transactions to the addresses where your coins are.

Cool, thank you.  That is of course interesting to know what was paid for the closing of the channels, I will have a look.
My question was more regarding the future though, if it's possible to actually choose when force closing channels? I know that it's possible in the command line interface when closing cooperatively, but perhaps not for the force closes.

Just FYI @openoms ,  I see on the transactions that I paid between 18 and 20 sats/vByte for the force close transactions.  Clearly more than I would have for this type of non-urgent transaction, but not at all brutal. It would be great if it was possible to manually change that when force closing.  My restoration of the channel backup file seem however to have pushed the channel partner to force close from their side (in my RTL it says "REMOTE_FORCE_CLOSE" , so I guess I couldn't have affected this fee level anyway, although the channel partner possibly could have.

These fees are automatically set by LND according to the current state of the mempool and AFAIK cannot be manually set. This is to make sure that there is no race condition to have an old state confirmed earlier by the other peer and make possible to cheat. This is why the commit fee and channel balances are seemingly changing when the mempool is filled.

Aha, very good to know, thank you @openoms.


I've thought about this more and I'm not sure if removing autocomplete is enough.  There's always the chance that someone will modify the input when the parenthesis are already there.
for example:
os.rmdir('C:\\importantDirectory\\directoryToDeleteA')
# user wants dir B instead, will backspace A out

The user wants to delete directory B instead, so he backspaces dirA out, but if he hesitates too long in typing dir B the program will run and delete importantDirectory instead.
os.rmdir('C:\\importantDirectory') # user thinks of name of dir B to type
# but AREPL has already noticed delay and ran program!

Why anyone would think it's a good idea to irreversibly delete files in a live editor is beyond me, but one of the rules of software is that users will find a way.
Reopening untill I think of some kind of fix for this.

It might be possible to have the python evaluator run under a special user account constrained only to use a certain folder.

doing something for this issue is import for #64, because as far as I am aware there is no easy to way to conditionally disable auto bracket-completion in VScode.

It might be possible to have the python evaluator run under a special user account constrained only to use a certain folder.

Possible, but would require admin permission, and I don't want to require that.
https://bytes.com/topic/python/answers/682502-how-create-new-user-windows-platform-using-python
http://timgolden.me.uk/python/win32_how_do_i/create-a-local-group-with-a-new-user.html

pip install pypiwin32 --user

import win32net
import win32netcon

USER = "user"
GROUP = "group"

# Create a new user with minimum privs.

user_info = dict (
  name = USER,
  password = "Passw0rd",
  priv = win32netcon.USER_PRIV_USER,
  home_dir = None,
  comment = None,
  flags = win32netcon.UF_SCRIPT,
  script_path = None
)

win32net.NetUserAdd (None, 1, user_info)

This results in "pywintypes.error: (5, 'NetUserAdd', 'Access is denied.')" - I'm guessing that only admins can create users.

I could avoid this issue (or more accurately, put it off) by only doing the live execution for gui applications in my typescript extension.  This has the beenefit of making the extension a lot easier to develop


[BUG] Issue with GoogleFonts usage when running flutter test

Describe the bug
With the GoogleFonts.xxxTextTheme(Theme.of(context).textTheme)) usage throws an error when executing inside test suite
To Reproduce
Steps to reproduce the behaviour:

Use Google fonts as GoogleFonts.xxxTextTheme(Theme.of(context).textTheme)) inside a widget for use fonts
Write a testWidget to test the widget that uses GoogleFonts
Run the test
See an error in the console as:

Error: google_fonts was unable to load font MajorMonoDisplay-Regular because the following exception occurred:
Exception: Failed to load font with url: https://fonts.gstatic.com/s/a/9901077f5681d4ec7e01e0ebe4bd61ba47669c64a7aedea472cd94fe1175751b.ttf

Expected behaviour
The test should pass without error or there should be a way to mock GoogleFonts usage
Smartphone (please complete the following information if applicable):

Flutter wdigetTest
Version  google_fonts: 1.1.1

This turns out that we need to provide adequate resources in the assets folder to get rid of the error message. Even though with the error message prints on every test that execute GoogleFonts library it won't fail the test with an exception. therefore it is up to the developer decision.
More info: https://stackoverflow.com/questions/65196647/write-flutter-widget-tests-that-uses-googlefonts/65197260#65197260


update new catalog info

New catalog setup on el8+ has new incoming dir.
Also removed old and older catalog scripts.
TODO(?): lots of (old?) flight_data mc_scripts with old hardcoded catalog dirs. May also be duplicate efforts. Catalog has a cron job to collect those data files from catalog.eol.ucar.edu which are configured for display in catalog-maps.

ping @topher800 @tthomas88

Regarding hercules: we just took the steam lab computer and changed the AIRCRAFT variable (i.e. not a clean install).  So I am sure there was stuff left over from Gordon and I working through the podman cross-builds.
Regarding git push: we know this is an issue, we try to commit from laptops.  But in the field, that is not always possible.  As of yesterday, we are switching our checkouts to ssh from https.  This will allow us to use ssh keys for pushing and remove the credentials stored on the server.  We will probably leave the eolJenkins RO credentials for cloning and pulling the private repos (or we need a work flow for that).

After working on the github w/ ssh key instead of https, we realize we don't even need the eolJenkins key at all.  We think all is good.


Property name case mismatch in web app section 11

The case of 'photoURL' property is incorrect in the example code.
https://github.com/firebase/friendlychat/blob/master/web/scripts/main.js#L141.js
This results in profile placeholder image to be shown instead of the user's profile pic

It seems to actually be correct. Perhaps your user's account simply does not have a profile Pic setup?

I'll close but feel free to re-open if you still have issues.


Constraint update Error

Info
Value

Platform
ios 13.0

SnapKit Version
5.0.1

Issue Description  ==> See The Code
    var sizeConstrain:Constraint? = nil
    var edgesConstrain:Constraint? = nil

    testView1.snp.makeConstraints { (make) in
            self.edgesConstrain = make.edges.equalToSuperview().inset(UIEdgeInsets(top: 10, left: 10, bottom: 10, right: 10)).constraint
   }

    testView2.snp.makeConstraints { (make) in
            self.sizeConstrain = make.size.equalTo(CGSize(width: 200, height: 200)).constraint
   }

override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) {
        //This success
        self.edgesConstrain?.update(inset: UIEdgeInsets(top: 50, left: 50, bottom: 50, right: 50))

       /** This fail
       error Message：
      Cannot invoke 'update' with an argument list of type '(inset: CGSize)'

      if use 'self.sizeConstrain?.update(offset: 100)'  is success
      But I want to set the width and height to different values
      */
       self.sizeConstrain?.update(inset: CGSize(width: 100, height: 300))
}

How to solve?

I know Constraint contain [ LayoutConstraint ] array, so should
        self.sizeConstrain?.layoutConstraints.first?.constant = 100
        self.sizeConstrain?.layoutConstraints.last?.constant = 300

Hey @benlue1992 I don't think you need to keep the references to the constraints if you want to update them. I think this should work fine
testView2.snp.updateConstraints { $0.size.equalTo(size) }

Or
testView2.snp.remakeConstraints { $0.size.equalTo(size) }

@martinpucik
oh, thank you very much.

@benlue1992 I’m glad it worked for you!
Should we close this issue then?
//cc @robertjpayne


Calendar Component for Vaadin 8 - Change Month Title when selecting next month date

In Calendar Component for Vaadin 8 in Calendar Add on,  Is there any upcoming feature to navigate Next Month Or  Last Month and by selecting date of September month then Month label changes accordingly?

Version 2.0-Beta2

Okay Thanks, Surely I'll take look at 2.0-Beta2.


Correct self_check label in label_image example

military uniform is the 654th label in inceptionV3 package. As said in README: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/label_image/README.md#to-buildinstallrun

Can one of the admins verify this patch?

@tensorflow-jenkins test this please


virt-launcher: decrease timeout for http get when detecting Istio

What this PR does / why we need it:
The 10 second timeout is too long and may cause the launcher to
not terminate for longer than necessary.
Shortening the timeout to 2 seconds for http get requests, which
should be more than enough.
With this change, in the worst case scenario, the detection would
take at most 8 seconds (4*2) plus a few ms for jitter.
Signed-off-by: Radim Hrazdil<EMAIL_ADDRESS>Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

https://bugzilla.redhat.com/show_bug.cgi?id=2017255

Special notes for your reviewer:
Release note:
-->
Shorten timeout for Istio proxy detection

/approve

/cherry-pick release-0.44


net-mgmt/telegraf: Fix 'Round Interval' setting not working

See: https://github.com/opnsense/plugins/issues/1437

Done :)

As i start to use the telegraf plugin on more and more of my OPNsense instances i came up with some additional improvments (Log File, Debug/Silent setting).
Should i append this changes to this PR or start a new one?

You can add them here too and rename subject

Done :)

merged, thanks! ❤


Review file system permissions on HIVE in the context of Bridges 2

Moved to the IEC Systems Team board


Is it commercially available?

Is it commercially available?

license information is clearly marked in the repository: https://github.com/vladmandic/human/blob/main/LICENSE


Rendering issues with e.g. boxen

There are rendering issues with the output of e.g. the boxen library. Looks like the line height currently is too big.

I'm having the same problem with blessed library. Any news on this or any tip on how to solve the issue ? tried with --padding but no success. Also, do you know if it's possible to change the font-family? thanks!


[vcpkg-fixup-pkgconfig] Remove REQUIRED to avoid failure to find pkg-config from failing the package build.

Line 285 clearly indicates that missing pkg-config is not intended to cause a build failure, however adding REQUIRED makes it a hard error. This PR removes REQUIRED to correctly implement the code's intention.
+@Neumann-A for review

See #12569


PostgresException: 23505: duplicate key value violates unique constraint "PK_Core_User"

After running the app with data seeding on PostgreSQL , when you register a new account on system, you will got an error related to "duplicate key value violates unique constraint PK_{Core_User}".
And this error is also occurs when you add a new entry of the entity that did seed data, ex: Address.
It seems a issue on Npgsql.EntityFrameworkCore.PostgreSQL like https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/367
Considering workaround on this.

@thanhtdvn Is the problem still happen now?


Update index.html

Overview
TL;DR

Questions
<If relevant, write a list of questions that you would like to discuss related to the changes that you have made.>
Next Steps
<If incomplete, create a task list of items that are still being worked on within the Pull Request.>
Review
<If complete, or ready for :eyes:, use @mentions for quick questions, specific feedback, and progress updates.>

Hello @0ishan0! Could you please describe this change, and why you are implementing it?

বাংলা is a language, and বাঙালি are the people who speak the language. That is the reason why I changed the word.

বাংলা is a language, and বাঙালি are the people who speak the language. That is the reason why I changed the word.

👍 Awesome. Thank you for the context, and for implementing this change, @0ishan0. 😊


iOS 13.3 "request desktop website" feature conflicts with download/install availability

Appcenter's install page is attempting to determine if a mobile browser is in use or not in order to make available the download and installation functionality.
If a user has turned on "request desktop website" in Safari as an option, this blocks any downloading and installing on the appcenter website.
iOS 13.3 has turned this feature on by default on iPads.
Thus anyone who upgrades to iOS 13.3 will suddenly find they can no longer install off of the appcenter website and there is no clear path for them to figure it out.
You will need to adjust to this new fact of life by a better check for mobile Safari than what you're using (good luck since Apple seems to be intentionally obfuscating it).

I'm also having this issue and would love for this to be resolved!
To add to this: the "request desktop website" setting also makes it impossible to register an iPad in a user's device list. The button does show up on iPad, but nothing happens when tapping it. In the console I can see that the server responds with:
{     "code": "bad_request",     "message": "User agent is undefined or invalid." }
So I suspect that the problem is the same.

Any progress on this issue?
All our devices have been migrated to 13.3 and it is becoming a support nightmare to advise users to download another web browser and copy-paste the install URL.

I think a have this same issue, install button is not visible, and when i expand an older release, install button shows up for 0.5 second and then disappears again.
I'm having this issue too https://github.com/microsoft/appcenter/issues/615, I always get prompted to install profile
iPhone 8
iOS 13.4

Thanks for the follow up. I will share an update in few days. The team is currently looking into it.

Install button is visible when using chrome


Add dependabot.yml to keep dependencies current

we used to have one of these... i know because i resolved an ancient issue opened by dependabot...
why not bring it back?


[view] fix edge routing for rectangular nodes

Try it in the class diagram example: It behaves pretty strangely.

https://github.com/TypeFox/sprotty/pull/126

merged


FirebaseUI-Android: Why not translate network error message ?

Select language Romanian
Start FirebaseUI-Android
Text is correct translate on screen

Here screenshot:

I turn off network (e.g. WiFi)
Enter phone number and press next
Show error message on English

Here screenshot:

Why this error message is not translated?

@lmdic thanks for reporting this, I am going to close this and move discussion to #901 which is basically the same issue.  We need to never return errors directly from the server.