Fix name of emby media player

Breaking change

Proposed change

Small fix for the below mentioned issue. Emby integration tries to create an entity with the following entity_id media_player.emby__pyemby__homeassistant.
This fails since words should only be separated by one _.
Now the following entity_id is created successfully media_player.emby_pyemby_homeassistant.
Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
media_player:
  - platform: emby
    host: YOUR_IP_ADDRESS
    api_key: YOUR_API_KEY

Additional information

This PR fixes or closes issue: fixes #32146
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[x] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

The person who reported that issue is having an invalid entity in their entity registry. That can no longer happen and this PR won't fix the error.
I still think we should merge this PR and drop the client name, as that's an implementation detail.

The client name was originally added to make the entity description as unique as possible.  You can change the device name within emby but not the client name (androidtv, roku, etc) so it made it easy to distinguish your devices.
That being said, I don't have a problem with removing it, but it would make this a breaking change since entity names will change for all emby media players.

The person who reported that issue is having an invalid entity in their entity registry.

Curious do we have any documentation on how to delete an invalid entity in the entity registry?

@mezz64 this is not a breaking change because the entity has a unique ID, so it will only impact the entity ID of new entities.

@mezz64 this is not a breaking change because the entity has a unique ID, so it will only impact the entity ID of new entities.

Thanks for the refresher.  I completely forgot that entity registry rules all now.


Unable to renew the certificate: Unsupported EC key

I just started with default configuration where I have added the certificate with (default) rsa2048 algorithm but I got this error.
It looks like the account file is using EC type that is not supported?
$ target/release/acmed -f --log-stderr --log-level trace -c test.toml
[2019-11-14T17:01:10Z INFO  acmed::config] Loading configuration file: test.toml
[2019-11-14T17:01:10Z TRACE acmed::certificate] crt-1: Testing file path: /tmp/acc/eHh4.priv-key.pem
[2019-11-14T17:01:10Z TRACE acmed::certificate] crt-1: Writing file "/tmp/acc/eHh4.pub-key.pem"
[2019-11-14T17:01:10Z TRACE acmed::certificate] crt-1: Writing file "/tmp/acc/eHh4.priv-key.pem"
[2019-11-14T17:01:10Z INFO  acmed::certificate] crt-1: Account xxx created.
[2019-11-14T17:01:10Z TRACE acmed::certificate] crt-1: Testing file path: /tmp/certs/hello.xxx.net_rsa2048.pk.pem
[2019-11-14T17:01:10Z DEBUG acmed::certificate] crt-1: certificate does not exist: requesting one
[2019-11-14T17:01:10Z DEBUG acmed::certificate] crt-1: GET: https://acme-staging-v02.api.letsencrypt.org/directory
[2019-11-14T17:01:11Z DEBUG acmed::certificate] crt-1: HEAD: https://acme-staging-v02.api.letsencrypt.org/acme/new-nonce
[2019-11-14T17:01:12Z TRACE acmed::certificate] crt-1: New nonce: 0001V2hQXxOcbr6ly8PN0IpUdfSiV8F6_OFScmN1cOp0b3E
[2019-11-14T17:01:12Z TRACE acmed::certificate] crt-1: Reading file "/tmp/acc/eHh4.priv-key.pem"
[2019-11-14T17:01:12Z WARN  acmed::certificate] crt-1: Unable to renew the certificate: Unsupported EC key

I have tried this on two systems, one with OpenSSL 1.0.2k-fips  26 Jan 2017 and other that has LibreSSL 2.9.2 with same result.
$ target/release/acmed --version
ACMEd 0.6.1 x86_64-unknown-linux-gnu

Compiled with:
  LibreSSL 2.9.2
  http_req 0.5.3

My configuration:
[global]
accounts_directory = "/tmp/acc"
certificates_directory = "/tmp/certs"

[[rate-limit]]
name = "LE min"
number = 20
period = "1s"

[[endpoint]]
name = "letsencrypt v2 staging"
url = "https://acme-staging-v02.api.letsencrypt.org/directory"
rate_limits = ["LE min"]
tos_agreed = true

[[account]]
name = "xxx"
email =<EMAIL_ADDRESS>
[[certificate]]
account = "xxx"
endpoint = "letsencrypt v2 staging"
domains = [{ challenge = "dns-01", dns = "hello.xxx.net" }]
hooks = []

Looks like I am getting None from $key.ec_key()?.group().curve_name().

This is very strange. It seems that OpenSSL/LibreSSL is able to create the account's EC key pair but then doesn't recognize it, which makes no sense. I just pushed a patch that displays a more precise error message. Can you build the master branch and then re-run it with the trace log-level please?

So I get None from .curve_name() so I added extra debugging and got this:
warn!("id: {:?}, ec_key: {:?}, group: {:?}", $key.id(), $key.ec_key(), $key.ec_key()?.group().curve_name());

Will result in: id: Id(408), ec_key: Ok(EcKey), group: None
If I return KeyType::EcdsaP256 in the None => branch I get this to work OK.

So I got it all working with LibreSSL on my PC but on my server with OpenSSL 1.0.2k I am getting this error:
[2019-11-15T17:04:48Z WARN  acmed::certificate] crt-1: Unable to renew the certificate: error:10074065:elliptic curve routines:EC_POINT_get_affine_coordinates_GFp:incompatible objects:ec_lib.c:892:

OpenSSL EC_POINT_get_affine_coordinates_GFp can fail if point in not in compact encoding: https://github.com/openssl/openssl/blob/54a0d4ceb28d53f5b00a27fc5ca8ff8f0ddf9036/crypto/ec/ec_lib.c#L838

OK, the problem is that you are saving the PKey object and not the EcKey to pem file.
The difference is that PKey does not know which group the EC was from, only all the parameter it needs to know about the final curve:
$ openssl ec -in /tmp/acc/eHh4.priv-key.pem -text
read EC key
Private-Key: (256 bit)
priv:
    00:cc:9d:95:81:68:4b:e1:40:71:a6:b4:cd:27:8c:
    68:4c:38:b1:98:4a:11:8e:5d:c0:b5:b7:9f:f2:75:
    2d:98:e7
pub:
    04:2f:bd:12:f1:c4:96:32:dd:15:f7:00:06:66:56:
    3f:52:cf:b6:ad:34:99:23:52:13:1c:59:a9:5e:53:
    b1:49:af:35:59:1a:68:01:b9:8e:23:b9:31:1c:d7:
    9c:96:3d:ab:c9:e7:dd:47:20:ab:36:86:64:a5:f9:
    74:2f:df:aa:a9
Field Type: prime-field
Prime:
    00:ff:ff:ff:ff:00:00:00:01:00:00:00:00:00:00:
    00:00:00:00:00:00:ff:ff:ff:ff:ff:ff:ff:ff:ff:
    ff:ff:ff
A:
    00:ff:ff:ff:ff:00:00:00:01:00:00:00:00:00:00:
    00:00:00:00:00:00:ff:ff:ff:ff:ff:ff:ff:ff:ff:
    ff:ff:fc
B:
    5a:c6:35:d8:aa:3a:93:e7:b3:eb:bd:55:76:98:86:
    bc:65:1d:06:b0:cc:53:b0:f6:3b:ce:3c:3e:27:d2:
    60:4b
Generator (uncompressed):
    04:6b:17:d1:f2:e1:2c:42:47:f8:bc:e6:e5:63:a4:
    40:f2:77:03:7d:81:2d:eb:33:a0:f4:a1:39:45:d8:
    98:c2:96:4f:e3:42:e2:fe:1a:7f:9b:8e:e7:eb:4a:
    7c:0f:9e:16:2b:ce:33:57:6b:31:5e:ce:cb:b6:40:
    68:37:bf:51:f5
Order:
    00:ff:ff:ff:ff:00:00:00:00:ff:ff:ff:ff:ff:ff:
    ff:ff:bc:e6:fa:ad:a7:17:9e:84:f3:b9:ca:c2:fc:
    63:25:51
Cofactor:  1 (0x1)
Seed:
    c4:9d:36:08:86:e7:04:93:6a:66:78:e1:13:9d:26:
    b7:81:9f:7e:90
writing EC key
-----BEGIN EC PRIVATE KEY-----
MIIBaAIBAQQgzJ2VgWhL4UBxprTNJ4xoTDixmEoRjl3Atbef8nUtmOeggfowgfcC
AQEwLAYHKoZIzj0BAQIhAP////8AAAABAAAAAAAAAAAAAAAA////////////////
MFsEIP////8AAAABAAAAAAAAAAAAAAAA///////////////8BCBaxjXYqjqT57Pr
vVV2mIa8ZR0GsMxTsPY7zjw+J9JgSwMVAMSdNgiG5wSTamZ44ROdJreBn36QBEEE
axfR8uEsQkf4vOblY6RA8ncDfYEt6zOg9KE5RdiYwpZP40Li/hp/m47n60p8D54W
K84zV2sxXs7LtkBoN79R9QIhAP////8AAAAA//////////+85vqtpxeehPO5ysL8
YyVRAgEBoUQDQgAEL70S8cSWMt0V9wAGZlY/Us+2rTSZI1ITHFmpXlOxSa81WRpo
AbmOI7kxHNeclj2ryefdRyCrNoZkpfl0L9+qqQ==
-----END EC PRIVATE KEY-----

If I generate the key with OpenSSL I get it in the format that has the curve group and point:
openssl ecparam -name prime256v1 -genkey -noout -out my.key.pem
$ openssl ec -in my.key.pem -text
read EC key
Private-Key: (256 bit)
priv:
    00:f1:9e:3d:87:45:6c:90:4b:3a:31:02:d5:dd:2e:
    71:3f:5c:ad:4d:c9:20:f6:14:80:e9:e2:51:8b:da:
    3e:64:9f
pub:
    04:10:30:e4:3b:f4:38:16:a3:52:76:e5:a7:22:a2:
    a5:63:6f:ea:fe:d5:cd:08:6f:f9:9a:06:a3:73:e0:
    aa:9d:f3:59:23:cb:f9:85:ca:3c:92:cc:30:31:17:
    8f:66:0a:e8:92:44:66:06:64:21:b9:19:4c:8c:7c:
    53:54:2d:9d:9d
ASN1 OID: prime256v1
NIST CURVE: P-256
writing EC key
-----BEGIN EC PRIVATE KEY-----
MHcCAQEEIPGePYdFbJBLOjEC1d0ucT9crU3JIPYUgOniUYvaPmSfoAoGCCqGSM49
AwEHoUQDQgAEEDDkO/Q4FqNSduWnIqKlY2/q/tXNCG/5mgajc+CqnfNZI8v5hco8
kswwMRePZgrokkRmBmQhuRlMjHxTVC2dnQ==
-----END EC PRIVATE KEY-----

Generated key like this will load fine and acmed will be able to function correctly.
On the side note apparently LibreSSL does not need curve_name to get affine_coordinates while OpenSSL does.

OK, the problem is that you are saving the PKey object and not the EcKey to pem file.
The difference is that PKey does not know which group the EC was from, only all the parameter it needs to know about the final curve:
$ openssl ec -in /tmp/acc/eHh4.priv-key.pem -text
read EC key
Private-Key: (256 bit)
priv:
    00:cc:9d:95:81:68:4b:e1:40:71:a6:b4:cd:27:8c:
    68:4c:38:b1:98:4a:11:8e:5d:c0:b5:b7:9f:f2:75:
    2d:98:e7
pub:
    04:2f:bd:12:f1:c4:96:32:dd:15:f7:00:06:66:56:
    3f:52:cf:b6:ad:34:99:23:52:13:1c:59:a9:5e:53:
    b1:49:af:35:59:1a:68:01:b9:8e:23:b9:31:1c:d7:
    9c:96:3d:ab:c9:e7:dd:47:20:ab:36:86:64:a5:f9:
    74:2f:df:aa:a9
Field Type: prime-field
Prime:
    00:ff:ff:ff:ff:00:00:00:01:00:00:00:00:00:00:
    00:00:00:00:00:00:ff:ff:ff:ff:ff:ff:ff:ff:ff:
    ff:ff:ff
A:
    00:ff:ff:ff:ff:00:00:00:01:00:00:00:00:00:00:
    00:00:00:00:00:00:ff:ff:ff:ff:ff:ff:ff:ff:ff:
    ff:ff:fc
B:
    5a:c6:35:d8:aa:3a:93:e7:b3:eb:bd:55:76:98:86:
    bc:65:1d:06:b0:cc:53:b0:f6:3b:ce:3c:3e:27:d2:
    60:4b
Generator (uncompressed):
    04:6b:17:d1:f2:e1:2c:42:47:f8:bc:e6:e5:63:a4:
    40:f2:77:03:7d:81:2d:eb:33:a0:f4:a1:39:45:d8:
    98:c2:96:4f:e3:42:e2:fe:1a:7f:9b:8e:e7:eb:4a:
    7c:0f:9e:16:2b:ce:33:57:6b:31:5e:ce:cb:b6:40:
    68:37:bf:51:f5
Order:
    00:ff:ff:ff:ff:00:00:00:00:ff:ff:ff:ff:ff:ff:
    ff:ff:bc:e6:fa:ad:a7:17:9e:84:f3:b9:ca:c2:fc:
    63:25:51
Cofactor:  1 (0x1)
Seed:
    c4:9d:36:08:86:e7:04:93:6a:66:78:e1:13:9d:26:
    b7:81:9f:7e:90
writing EC key
-----BEGIN EC PRIVATE KEY-----
MIIBaAIBAQQgzJ2VgWhL4UBxprTNJ4xoTDixmEoRjl3Atbef8nUtmOeggfowgfcC
AQEwLAYHKoZIzj0BAQIhAP////8AAAABAAAAAAAAAAAAAAAA////////////////
MFsEIP////8AAAABAAAAAAAAAAAAAAAA///////////////8BCBaxjXYqjqT57Pr
vVV2mIa8ZR0GsMxTsPY7zjw+J9JgSwMVAMSdNgiG5wSTamZ44ROdJreBn36QBEEE
axfR8uEsQkf4vOblY6RA8ncDfYEt6zOg9KE5RdiYwpZP40Li/hp/m47n60p8D54W
K84zV2sxXs7LtkBoN79R9QIhAP////8AAAAA//////////+85vqtpxeehPO5ysL8
YyVRAgEBoUQDQgAEL70S8cSWMt0V9wAGZlY/Us+2rTSZI1ITHFmpXlOxSa81WRpo
AbmOI7kxHNeclj2ryefdRyCrNoZkpfl0L9+qqQ==
-----END EC PRIVATE KEY-----

If I generate the key with OpenSSL I get it in the format that has the curve group and point:
openssl ecparam -name prime256v1 -genkey -noout -out my.key.pem
$ openssl ec -in my.key.pem -text
read EC key
Private-Key: (256 bit)
priv:
    00:f1:9e:3d:87:45:6c:90:4b:3a:31:02:d5:dd:2e:
    71:3f:5c:ad:4d:c9:20:f6:14:80:e9:e2:51:8b:da:
    3e:64:9f
pub:
    04:10:30:e4:3b:f4:38:16:a3:52:76:e5:a7:22:a2:
    a5:63:6f:ea:fe:d5:cd:08:6f:f9:9a:06:a3:73:e0:
    aa:9d:f3:59:23:cb:f9:85:ca:3c:92:cc:30:31:17:
    8f:66:0a:e8:92:44:66:06:64:21:b9:19:4c:8c:7c:
    53:54:2d:9d:9d
ASN1 OID: prime256v1
NIST CURVE: P-256
writing EC key
-----BEGIN EC PRIVATE KEY-----
MHcCAQEEIPGePYdFbJBLOjEC1d0ucT9crU3JIPYUgOniUYvaPmSfoAoGCCqGSM49
AwEHoUQDQgAEEDDkO/Q4FqNSduWnIqKlY2/q/tXNCG/5mgajc+CqnfNZI8v5hco8
kswwMRePZgrokkRmBmQhuRlMjHxTVC2dnQ==
-----END EC PRIVATE KEY-----

Generated key like this will load fine and acmed will be able to function correctly.
On the side note apparently LibreSSL does not need curve_name to get affine_coordinates while OpenSSL does.

Your last message gave me the key to the solution. Between OpenSSL 1.0 and 1.1 there has been a change in the PEM format generated by the PEM_write_bio_PKCS8PrivateKey function (1.0.2 manual, 1.1.0 manual, look for PEM_write_bio_PKCS8PrivateKey()). As you can see, which is confirmed by your example, 1.0 uses a legacy format (called "traditional") which includes all of the curve's parameters whereas 1.1 only stores the curve's identifier.
Obviously, 1.1 can transparently handles both formats, but 1.0 only accepts the legacy one. You compiled ACMEd against 1.0, this is why it generates every key in the legacy format and cannot handle the newer key you manually generated with a higher version.
Also, this legacy format is obviously the reason why no NID is returned when calling .curve_name() (the curve itself is stored instead of its identifier), hence your first issue. Because there is nothing I can do about it, I think the solution is to explicitly require OpenSSL 1.1 (and maybe an equivalent for LibreSSL).

The difference is in defaults of EcGroup between versions as described on:
https://docs.rs/openssl/0.10.25/openssl/ec/struct.EcGroupRef.html#method.set_asn1_flag
So to get this working it should be sufficient to add this line:
group.set_asn1_flag(Asn1Flag::NAMED_CURVE);

Let me try it out and if this works I will send a PR.


Test

Type: Missing
Summary:
Test
Details:
Test
Resolution:
Test
Affected definitions:

chrome-devtools-frontend 1.0.440939

You can review the change introduced to the full definition at ClearlyDefined.


Support for mochai, chai, sinon

Please provide us with the following information:

OS?

Windows 10

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here: 1.0.0-beta.15

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

The log given by the failure.

Normally this include a stack trace and some more information.

Mention any other details that might be useful.

Is it possible to add support for testing with mocha chai and sinon?

Thanks! We'll be in touch soon.

We use karma, so you should be able to use whatever karma uses. You'll have to configure karma.conf.js yourself though.


Doesn't Work in Laravel 5.6

Expected behaviour
Used code from two different sources:
Sandbox:
https://uxsolutions.github.io/bootstrap-datepicker/?markup=input&format=&weekStart=&startDate=&endDate=&startView=0&minViewMode=0&maxViewMode=4&todayBtn=false&clearBtn=false&language=en&orientation=auto&multidate=&multidateSeparator=&keyboardNavigation=on&forceParse=on#sandbox
And from the docs:
https://bootstrap-datepicker.readthedocs.io/en/stable/
Side note. It was confusing, because one used an id, which was not explicitly described (Sandbox)
The other uses a class, which is explicitly shown in the code (Docs).
Actual behaviour
Nothing happens when I click the input field using either sample code.
Bootstrap is loaded and Jquery is loaded as well.
Datepicker version used
1.7.1
Installed using "composer require eternicode/bootstrap-datepicker" as instructed on the packaging page, followed by the yarn instructions.

Same problem,
i think bootstrap V4.0.0 is not supported


Need to pluralize multiple words in a string

0/no files include "cake" in their names.
1 file includes "cake" in its name.
2 files include "cake" in their names.
This could be written with multiple calls to pluralize but I think a template based string function would be better.
'[number/no] [pl:file] [!pl:includes] "cake" in [pl:its/their] [pl:name]'
Language.makePlural(
'[number] [pl:file] [!pl:includes] “cake” in [pl:its/their] [pl:name]'
, value
)
I need this for an application so will write one. If you want to include in your library let me know. Suggestions for alternate token/syntax welcome.

I don't think this is suitable for this library. If you can write the template upfront, you would know the plurals already and you really shouldn't be using this library. You should just be writing switches in your template that selects a or b depending on count.


improve dataset build workflow

resolves #12
follow-up to PR #19
changes

finish adding CBBR build in centralized build workflow
add PLUTO build to centralized build workflow
remove the "is a minor release build" input to PLUTO build

by using the version set in version.env to infer whether it's a major or minor release

ensure changes to the centralized github action files (build.yml, tests.yml) trigger the Template Datasets tests
add dev container extension for formatting yaml files

tests

pluto build w/o exporting

One postmortem note - saw you were using this, and devdb archiving does too, saw this warning on my job

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

You mind if I update and get in my devdb PR? Seems minor and straightforward

@fvankrieken go for it! here's the only example so far where I've made the change


Upgrade websocket request when header present, otherwise do not reject

The current websocket support appears to offer two choices:

When route is configured with use_websocket:true upgrade if header is present, otherwise reject
The spec doesn't say what the behavior is when use_websocket:false; are requests with the upgrade header rejected or is the header ignored and the request forwarded over http?

The behavior of Cloud Foundry's current edge proxy is:

If the upgrade header is present, we initiate a TCP connection to the backend
If the upgrade header is not present, we forward an HTTP request
There is no user control of whether upgrade header is rejected or accepted
Apps are responsible for rejecting connections/requests based on whether they require TCP or HTTP requests

In order to transition from our current edge proxy to Envoy without downtime for upstream applications, we must continue supporting websockets on all routes without breaking apps that don't support them.
Could we change the semantics of this boolean to:

when use_websocket:true upgrade if header is present, otherwise forward request over http
when use_websocket:false keep current behavior

I'll need this also, eventually.  If eventually arrives and it isn't done yet, I can help on this, but I don't have time to do it right now.

@mattklein123 By adding the label help_wanted does that mean you approve of the proposed semantic change?

Hi, sorry for the delay (missed this in the millions of notifications that GH sends me every day). Will comment in detail on the rationale for choosing the connection rejection behavior in an hour.

@rshriram if you need the current behavior, I'd say we should move the setting to a tri-state: required, allowed, and prohibited (possibly with better names than that).

Sadly, I cannot recall why we decided to have the strict mode. But I am in favor of removing the restriction as it simplifies configuration overall (in Istio) and perhaps elsewhere as well.

Hooray! Thank you, @rshriram!0

Heya! The current docs for v1.5.0 or latest seem to say that this change is no longer valid (https://www.envoyproxy.io/docs/envoy/v1.5.0/api-v2/rds.proto.html#routeaction under 'use_websocket'). The doc changes in #1792 seem to be no longer present. Is that a miss during repo changes or has this change been reverted?
I do get an error upstream connect error or disconnect/reset before headers with use_websocket: true against a http endpoint.

The error is PBKAC, but the doc issue seems real.

@yuvipanda please do a doc PR and fix!


kr-server-update

Korean server support
I've added Korean server support things, but it's not working. I don't know why.
DebugLog is not logged.
(/echo DEBUG FFLEC)
Chat logs are not logged in plugin log.
Anyone knows why?
I tried
AddLineToLog(log);
right after
https://github.com/RuinIv/FFLogsEasyCheck/blob/3a609886f172fd1b50ab5c34069ffeb4bc78ca15/PartyMonitor.cs#L179
but chat logs are not logged
My bad, I was doing it with Intl version of FFXIV Parsing Plugin, which doesn't work with KR-v5.11
Clear log button
I've added clear log button.

ServerDropdown.SelectedIndex == 0
does not means "dropdown is not selected". Index 0 is the first element.

Since FFLog character info page is different between International one and Korean one, need to separate or make some change to parsing webpage.
https://www.fflogs.com/character/jp/typhon/whopper dragon
https://www.fflogs.com/character/KR/Chocobo/갈리스피

I've made temporary popup box for Korean server since previous making popup box codes broke the other functions.
0cc5796

document.QuerySelector(".zone-all-star-box:nth-child(2) .zone-bar-big-rank")?.TextContent;
document.QuerySelector(".zone-all-star-box:nth-child(2) .zone-bar-rank")?.TextContent;

is not working well.
This returns empty String ("")
document.querySelector(".zone-all-star-box:nth-child(2) .zone-bar-big-rank").textContent is working fine with javascript though.
https://ko.fflogs.com/character/KR/Chocobo/갈리스피

IHtmlDocument document = parser.Parse(response);
does not get full HTML from fflog.
There are more HTML DOMs inside div.raids-table-container

but document parsed here (this project) does not have inner DOMs.

This should be

Expansion All Stars

Points
94.55

1  / 6

Rank
19665

Points
89.42

1  / 4

Rank
10104

Points
413.17

4  / 4

Rank
7661

Ah... those information have to be parsed from other url.

It'd better merge this now and find out way to support Korean fflogs on popup later.

By the way, I can't figure out what broke character encoding or line endings.
It's UTF-8, CRLF on my file, but Github says all lines from PartyMonitor.cs were modified.


Fix opam constraint on digestif

API changed in 0.6 and 0.7 doesn't link. I'll forward this to opam-repository later

Thanks!


The process cannot access the file '/tmp/***' because it is being used by another process

it sometimes appears
https://travis-ci.org/AElfProject/AElf/builds/507692055?utm_source=github_status&utm_medium=notification
Calculating coverage result...
/home/travis/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error : The process cannot access the file '/tmp/AElf.Sdk.CSharp_054f2d30-72e4-44f2-899f-cd0fd4e69951' because it is being used by another process. [/home/travis/build/AElfProject/AElf/AElf.Contracts.Consensus.DPoS.Tests/AElf.Contracts.Consensus.DPoS.Tests.csproj]
/home/travis/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at System.IO.FileStream.Init(FileMode mode, FileShare share) [/home/travis/build/AElfProject/AElf/AElf.Contracts.Consensus.DPoS.Tests/AElf.Contracts.Consensus.DPoS.Tests.csproj]
/home/travis/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [/home/travis/build/AElfProject/AElf/AElf.Contracts.Consensus.DPoS.Tests/AElf.Contracts.Consensus.DPoS.Tests.csproj]
/home/travis/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at Coverlet.Core.Coverage.CalculateCoverage() in /Users/toni/Workspace/coverlet/src/coverlet.core/Coverage.cs:line 224 [/home/travis/build/AElfProject/AElf/AElf.Contracts.Consensus.DPoS.Tests/AElf.Contracts.Consensus.DPoS.Tests.csproj]
/home/travis/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at Coverlet.Core.Coverage.GetCoverageResult() in /Users/toni/Workspace/coverlet/src/coverlet.core/Coverage.cs:line 107 [/home/travis/build/AElfProject/AElf/AElf.Contracts.Consensus.DPoS.Tests/AElf.Contracts.Consensus.DPoS.Tests.csproj]
/home/travis/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at Coverlet.MSbuild.Tasks.CoverageResultTask.Execute() in /Users/toni/Workspace/coverlet/src/coverlet.msbuild.tasks/CoverageResultTask.cs:line 67 [/home/travis/build/AElfProject/AElf/AElf.Contracts.Consensus.DPoS.Tests/AElf.Contracts.Consensus.DPoS.Tests.csproj]

This seems like a transient file access error. Can you try it again?

yes it was transient，but very often
bash scripts/test.sh
not only in CI，but also in local dev machine
we use osx to dev，and CI was in unbuntu
发自我的 iPhone

在 2019年3月21日，05:17，Toni Solarin-Sodara<EMAIL_ADDRESS>写道：
This seems like a transient file access error. Can you try it again?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I have pretty the same issue but with a .pdb file hard to find.
The code run like @loning on a macOS machine.
/Users/cedrichulin/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error : One or more errors occurred. (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) (Could not find file '/var/folders/79/s60z7zw52sg7zgz8_nm_5b9r0000gn/T/xunit.runner.reporters.netcoreapp10_12bc01ee-dd5e-4cfb-921e-8e4875de1d11.pdb'.) [/Users/cedrichulin/Documents/Vsts/GildedRose-Refactoring-Kata/GildedRose/GildedRose.csproj]
/Users/cedrichulin/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at Coverlet.Core.RetryHelper.Do[T](Func`1 action, Func`1 backoffStrategy, Int32 maxAttemptCount) in /Users/toni/Workspace/coverlet/src/coverlet.core/Helpers/RetryHelper.cs:line 58 [/Users/cedrichulin/Documents/Vsts/GildedRose-Refactoring-Kata/GildedRose/GildedRose.csproj]
/Users/cedrichulin/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at Coverlet.Core.RetryHelper.Retry(Action action, Func`1 backoffStrategy, Int32 maxAttemptCount) in /Users/toni/Workspace/coverlet/src/coverlet.core/Helpers/RetryHelper.cs:line 27 [/Users/cedrichulin/Documents/Vsts/GildedRose-Refactoring-Kata/GildedRose/GildedRose.csproj]
/Users/cedrichulin/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at Coverlet.Core.Coverage.GetCoverageResult() in /Users/toni/Workspace/coverlet/src/coverlet.core/Coverage.cs:line 108 [/Users/cedrichulin/Documents/Vsts/GildedRose-Refactoring-Kata/GildedRose/GildedRose.csproj]
/Users/cedrichulin/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error :    at Coverlet.MSbuild.Tasks.CoverageResultTask.Execute() in /Users/toni/Workspace/coverlet/src/coverlet.msbuild.tasks/CoverageResultTask.cs:line 67 [/Users/cedrichulin/Documents/Vsts/GildedRose-Refactoring-Kata/GildedRose/GildedRose.csproj]

@loning are you experiencing issue again or we can close this?

I have downgrade to 2.5.1，not test any more
Marco Rossignoli<EMAIL_ADDRESS>周六01:47写道：

@loning https://github.com/loning are you experiencing issue again or
we can close this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tonerdo/coverlet/issues/371?email_source=notifications&email_token=AAMFED5J7PEHVLLS5C62WRLP2PKSHA5CNFSM4G7EDOJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXQD7I#issuecomment-502202877,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMFED2EAS2WRDOVOAPOGJTP2PKSHANCNFSM4G7EDOJA
.

--
Regards & Best wishes,
Loning
Blog: http://loning.cnblogs.com http://loning.cnblogs.com

Seem a problem with concurrent msbuild test runs, you could also try with https://github.com/tonerdo/coverlet/issues/491#issuecomment-514429285 that slow down test but could work.

Close for stale, feel free to re-open if needed!


Who are the stakeholders involved in the dormant users process

User Need
As a Operations Engineering Team
I want to document who the users/stakeholders of the process are
so that we how who we might need to speak to,  so we can better under their needs, and so we can better understand any touch points in the process.
Value
Knowing who your users/stakeholders are will help you better understand the process we are trying to improve. We will know who to consult with, and or
Functional Requirements:

Create a user/stakeholder map

Acceptance Criteria:

We have a detailed map of our users/stakeholders
We understand why these people or groups are users/stakeholders

Notes:

Document created
https://drive.google.com/file/d/1L2-Kx_TFTAcXj5gfRuGp4Shc7gL3LewU/view?usp=drive_link

Comments and suggestions here
https://mojdt.slack.com/archives/CPVD6398C/p1711449067621879


API v4 update

Yes we could pass an invalid data center id but we'll get different error
message, i.e., Resource does not exist instead of Attribute 'location' is required. In GET negative test cases we're covering the error Resource does not exist. @edevenport, what do you think?
On Fri, Jun 30, 2017 at 4:02 PM, alibazlamit<EMAIL_ADDRESS>wrote:

@alibazlamit commented on this pull request.
In tests/test_image.py
https://github.com/StackPointCloud/profitbricks-sdk-python/pull/11#discussion_r125046104
:

@@ -34,20 +35,45 @@ def test_get_image(self):

     self.assertEqual(image['type'], 'image')
     self.assertEqual(image['id'], self.image['id'])

   assertRegex(self, image['id'], self.resource['uuid_match'])

   self.assertGreater(len(image['properties']['name']), 0)

   self.assertIsNone(image['properties']['description'])

   self.assertGreater(image['properties']['size'], 0)

   self.assertNotEquals(image['properties']['name'], "")

test_image.py:42: DeprecationWarning: Please use assertNotEqual instead.
self.assertNotEquals(image['properties']['name'], "")
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StackPointCloud/profitbricks-sdk-python/pull/11#pullrequestreview-47398858,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJAERq9nrlL7VDYUJ-udOihjOgPFmA4ks5sJP_jgaJpZM4OKBBc
.


docs: add Jon Church as triager

I have read and understood the project's Contributing guide.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the below orgs:
jshttp
pillarjs
express

Roles added and merged in bf66b8ba


Enhance About us section [Gssoc'23]

Is your feature request related to a problem? Please describe.
I would like to make about us section more attractive.
So, I will make changes in ui to make it more attractive.
Describe the solution you'd like.
Basically, I will change the ui here.
Describe alternatives you've considered.
Image in about us section is not looking good, so what I think is to adjust image at right of text.
Add any other context or screenshots about the feature request here.
No response

Hey, the same issue is already raised


Add Bright_Disputes.md proposal

Smart contract bounty application from Bright Inventions team for a dispute solving dApp - Bright Disputes.

Hi @0xMarkian, we had the Canary Dapp category in mind when preparing the proposal

Hi @0xMarkian, we had the Canary Dapp category in mind when preparing the proposal

Hey, I have a few more questions.
What are your future plans for this proposal? Do you plan to launch a business with this idea?
Also, could you elaborate on the ecosystem impact that this proposal will bring? Why do you think it's beneficial for ink!? how it can help other ink! projects or become a base for them?
In other words, we would like to avoid writing code for code purposes. And instead, have it used by at least 1 production company.

We've already started to develop a POC for private funding bounties mechanism, using WASM and IPFS. We see this as a potential showcase and next step for Bright Disputes.
Noticed this line in the additional info section. Could you elaborate more on the private funding bounties mechanism?

Hi @0xMarkian apologies for a late reply. I’ve been out of office for a few days.
Currently, we see BrightDisputes as a solution that could be easily incorporated in any of the existing/emerging systems that pair investors and creators.  We got the idea for BrightDipsutes when we were preparing a plan and POC for another system (that we called SubFunds) - the private bounties we mentioned in our proposal. For the last two years our team was developing and maintaining BrightTreasury - a web application that allows users to apply for and follow proposals, bounties and tips of the Polkadot and Kusama treasuries. Having this experience, we wanted to expand this idea and introduce a module not only based on the treasury but allowing private financing - a bit like Gitcoin, but based on an Ink! smartcontract. When planning this solution, we encountered an issue of solving potential disputes. We couldn’t find mature smart contract based solution implementing a dispute solving algorithm that would be suitable for us. We noticed that other similar products lacked dispute resolution and might benefit from a solution that could be incorporated within the system. This is the value that BrightDisputes can bring to the ecosystem on a wider scale.
When it comes to our own private bounties solution, we already built a Rust POC and we hope to get some funding in the future to create a full product as well, using BrightDisputes for dispute resolution.

thanks for the answer. Could you elaborate on what kind of traction BrightTreasury got?

I might have described this in an unclear way, sorry. BrightDisputes wouldn't be used in BrightTreasury. I mentioned it as a step that led us to an idea for privately funded bounties app and in consequence dispute resolution challenge. We would like to incorporate BrightDisputes in the private bounties app, SubFunds, that's now in its POC stage. However, at the moment we would like to focus on the dispute resolution module first as in our opinion it can, on its own, bring value to the community. A decentralised dispute resolution solution that would use ink and zk-snarks would be a new approach, that could potentially be adapted by other systems as well and present an alternative to the council based systems.

Hey, thanks for the reply! I can be totally missing something here, but could you elaborate once more on how exactly you think the disputes module will be bringing value to the community?  In that case, you should indicate a different category.

Can you describe a model use case for this solution? I have some comments and questions but don't know if they are relevant.

@0xMarkian you're probably right - we weren't sure which category would be most suitable for us. We ruled out infrastructure as what we want to do is not just one library - more like a solution + an extension to multiple libraries we want to use... That's why we were leaning towards technical showcase.
@mike1729 in our proposal we described the whole use case, along with a diagram, however we can add more details if needed. From a business case perspective, BrightDisputes is dedicated to support resolving disputes between a funder and a contractor, specifically in a job advertising platform. We designed BrightDisputes with our own WASM based job advertising platform (that we call SubFunds - we can also provide description of this system if needed), as we couldn't find a decentralised solution in substrate. We want to use zk-snarks for verification & cli to simplify the process.

In your application you describe a general system for handling disputes and my question is what type of disputes you want to settle with it. Can you provide us with an example containing:

what is disputed
who rises it
how judge and jury are picked.
Without some example to play around, it's hard for me to assess the merit of the whole system as in some scenarios picking a judge is natural and in some it may be hard (this is just one example).

Thanks for your application. I agree with Mike here. I would like to know who use this.

@mike1729  I’ve just updated our proposal to include a more detailed description of the dispute resolution flow, putting it in the context of  commissioning  a task through a job advertising platform. I hope that it explains in more detail the use case we see for BrightDisputes.
And to answer your questions specifically:

What is being disputed is an argument between a person who raised it and the object of the dispute
As BrightDisputes is meant to work in a context of another system, a job advertising platform in particular, every user can raise a dispute against anyone with whom she/he was connected through a job contract. For example Person A raises a dispute, claiming that a transaction between her and person B was not fulfilled.
We see the version presented in our proposal as a first iteration. This means that some approaches are simplified - this includes jury selection. We plan to select a board of juries for each case randomly from the pool of users that expressed their willingness to take part in dispute resolutions. When a user is picked as a jury for a particular case, she/he needs to confirm their readiness to take part. In next iteration we see a possibility to group the jury candidates into more specific domain oriented pools.
If needed, we’ll be happy to provide more details or maybe jump on a call to better explain any issues. We would also appreciate any feedback, should some adjustments be needed in our approach.

Thank you for the feedback @DoubleOTheven. We decided to leave the frontend part out as not to increase the budget too much, however we are open to adding it to the scope. We will prepare a proposition on how it might look like and adjust the milestones 👍

@0xMarkian job advertising portals based on blockchain (like Gitcoin) are popular among developers and creatives, however substrate smartcontract dApps are not widely used to build such systems yet. We started to build a job advertising platform ourselves and found that a lack of dispute resolution rooted in the ecosystem is a blocker. In our opinion, building an ink! based dispute resolution will contribute to wider adoption of ink! smartcontracts among teams developing systems that require dispute resolutions.
We believe that the future of dApps will be based on trust and privacy, which can only be achieved through zk-snarks technology. Currently, there are no dApps that would promote this technology. The value brought to the ink! community is to show that such applications can be created using smart contracts written in ink! and the AlephZero chain that supports zk-snarks.
As suggested by @DoubleOTheven, we plan to add a user interface as well which would allow users to use the main flow of dispute resolutions already, without rooting it in external systems.

thanks for the answer! I understand that this module can be potentially useful to those building such systems, however, I would still like to understand how you are planning to promote your module. We would like to avoid a dead code that isn't used by anyone.
also, could you name other real-world examples except for gitcoin? (better with links). It will help if you will be able to demonstrate the growing demand for such module.

@0xMarkian When it comes to the promotion of our solution, we plan to write an article and publish it on Bright Inventions blog and Medium account. Under the following link you can find our channels reach. Additionally, we might follow with a youtube video tutorial, also promoted through our channels.
As for the need for dispute resolution and development of gitcoin-like systems in Substrate, while researching the domain for own platform SubFunds we found three other teams developing similar systems:

DotPay - a payment platform, you can initiate open source tasks and paid with DOT tokens.
DotPuls (github) - a decentralised services marketplace, based on the substrate pallet. They have also notice the issue of disputes and plan to create decentralized court.
DotRewards (proposal) - aims to become a collaborative platform connecting funders with creatives. Solution was based on the Ink! smart contract.

@DoubleOTheven following your feedback, we discussed the UI part internally and prepared a proposition for the frontend part of BrightDisputes. I updated our application to include the UI focused milestone, example app screens as well as the new team members that would support the delivery of the frontend app. Should you have any comments or questions, we'll be more than happy to answer them.

Congratulations! We are thrilled to officially welcome you to the Ink!ubator program!! We can't wait to see the remarkable contributions you'll bring to the ecosystem.
In terms of the next steps, we are eagerly anticipating your first delivery, which is due in 1 months. When it’s ready, please create a PR here - https://github.com/use-inkubator/Grant-Milestone-Delivery
If you have any questions, concerns, or if you just want to brainstorm ideas, don't hesitate to reach out. We encourage you to utilize our Element channel for any inquiries - https://matrix.to/#/#sm-bounty-support:matrix.org
As you join the Ink!ubator family, please remember that you are not alone on this journey. We are here to support you every step of the way. We believe in your potential and we can't wait to see where this journey takes us all.
Congratulations once again and welcome aboard!


Add/remove spam cards by account

As a developer I should be able to know wich cards belongs to each account.
Acceptance criteria
1 - Test scenario 1: create multiple cards, add to a list and remove by account.
2- Test scenario 2: add spam cards to decision service with account id.


Updating the software (MW 1.3.0, PHP 8.1)

Hello, my hosting server was updated to PHP 8.1, so I went to update to the latest version of MW. But it keeps updating (15 minutes) and nothing happens (blank page on live page as well as in administration). Thanks for support

after 45 mins. still the same.. I think, I'll return to backup of previous MW version

After 1 hour, still the same, I think I'll get back to v1.2.21

I have the same issue using the stand-alone-updater on all previous versions.
It works, but I have to refresh/duplicate the tab in order for it to continue/try again.
But by doing so I also have to remove the downloaded and unpacked files manually otherwise my website doubles in size.

In my experience, Softaculous seems to be more reliable and offers to create a backup before you upgrade which you can rollback to if something goes wrong.
I keep testing out the SAU when it gets updated though to check out the improvements.

Hello, can you check if there is error in the file storage/logs/laravel.log
Also you can update manually by following this procedure https://github.com/microweber/microweber/blob/master/UPGRADING.md

Hi, thanks both for responses. Laravel.log was last modified almost a month ago. I refreshed and waited a bit more and update went done.
But 500 Server Error started to appear on admin sites. On laravel.log appeared this: "production.ERROR: file_exists(): File name is longer than the maximum allowed path length on this platform (4096): /home/html/XXXXX/mydomain.domainname/public_html/resources/views/<!DOCTYPE html> ... followed by html source.. "

returned from backup to MW 1.2.21

just to let you know.. Admin 500s fixed in 1.3.1, everything works fine, thanks for support


Set up auto registration of clients to Zabbix

Currently Zabbix registers with the clients. Therefore we need the IP of the Autopower device for monitoring. This means that Zabbix monitoring doesn't work behind a NAT and requires manual setup. We should probably switch to Active Zabbix agents: https://blog.zabbix.com/zabbix-agent-active-vs-passive/9207/
Alternative: Auto registration: https://www.zabbix.com/documentation/current/en/manual/discovery/auto_registration#secure_autoregistration

@romain-jacob I would need access to a device to implement this.

Works with device, needs testing in the wild.


Should we fix the order of sections?

The order of the ISA sections is defined to be arbitrary in the spec. The parser accepts some, but not all permutations. However, it appears that the fixing the order to

architectural_state
functions
instructions

would be sufficient in practice. Instructions use arch. state and functions, but cannot be referenced themselves.

Hmm, I'm not sure. Fixing this would put constraints on the writer of descriptions. But I agree that in practice one has a certain order. Logically I would opt for having state and function in arbitrary order followed by intructions.
We need to keep extensability in mind, e.g. to describe µArch details...

Closing this. I asked this out of fear that we would have to manually enumerate all permutations of the sections in the grammar, but turns out that there is a syntactic sugar for this in Xtext (-> #26).


Add main menu when you load up the game

Add a main menu with play, help, credits, and settings buttons.

Done


what does the excepList means in the extractDirectSyscalls() of containerProfiler.py？

What does the excepList = ["ld.so", "libc.so", "libdl.so", "libcrypt.so", "libnss_compat.so", "libnsl.so", "libnss_files.so", "libnss_nis.so", "libpthread.so", "libm.so", "libresolv.so", "librt.so", "libutil.so", "libnss_dns.so", "gosu"] means?  Does it means that the glibc.callgraph contains the callgraph of ld.so or libdl.so?

Yes! These libraries are installed with the glibc package and we expect them to be considered when we build the glibc callgraph. Please comment if you find any discrepancies.


Specifying alignment for compatibility with non-left aligned design e…

…lements
No card, just a simple update.

+1. For reporting, I think Larry wants us to link PRs to a github issue if there is no ticket.

Fixes #487

Thank you @cruzanmo


Add documentation on spack modules

A sub-bullet under "Adding a Specific System configuration"
Explain that if installed software does not have correct rpaths (e.g., it was installed by EasyBuild), it needs to be added as a spack external module, not just a spack external.
Point at Spack modules documentation.

https://spack.readthedocs.io/en/latest/packages_yaml.html#external-packages is the correct Spack documentation ref. If you search modules in the spack docs you'll get all results about Spack-generated modules which is a different issue.


Add asynchronous subscriptions, PublishError and shared lock mechanism

This fixes #27 and #28.

Codecov Report

Merging #34 (6de45cb) into master (cad0369) will decrease coverage by 0.11%.
The diff coverage is 81.37%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   78.18%   78.06%   -0.12%
==========================================
  Files          24       24
  Lines        2709     2813     +104
  Branches      367      399      +32
==========================================
+ Hits         2118     2196      +78
- Misses        523      543      +20
- Partials       68       74       +6

Impacted Files
Coverage Δ

shc/misc.py
81.25% <71.42%> (-2.66%)
:arrow_down:

shc/variables.py
94.50% <77.27%> (-4.25%)
:arrow_down:

shc/base.py
83.10% <81.60%> (-2.52%)
:arrow_down:

shc/timer.py
88.53% <81.81%> (-0.39%)
:arrow_down:

shc/expressions.py
84.68% <100.00%> (+0.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad0369...6de45cb. Read the comment docs.

This approach does not solve the synchronization issues between SHC and external stateful systems (like a KNX bus or an MQTT serve with attached devices that keep the last published value).
Thus, this PR is abandoned in favor of #36.


stats.distributions statistical power of test suite

In PR #2612 Ralf reduced the sample size in the test suite for the distributions.
Even reducing sample size to 100 didn't cause any failures.
Looking at the unittests in test_continuous_basic, mean, var and cdf are verified using statistical tests (t-test, a chisquare test and kstest).
If the sample size is small, then the power of these tests will be small also.
Since we use now fixed seeds in the unit tests, we will not see random failures.
My guess is that 500 observations is still a good sample size for general unit tests, but will be too small to detect smaller numerical errors. (like the two bugs I found in numpy.random with the kstest.)

@josef-pkt We went ahead and closed this with gh-15724, but I'd still appreciate your thoughts there in case we missed something.


Union with any produces unexpected result

TypeScript Version:  2.4.0
Code
declare function test(num: string): void;

let withString: number | string;
// Error: `Type 'number' is not assignable to type 'string'.`, as expected. withString might be a number, which does not have the necessary properties to act as a string.
test(withString);

let withAny: number | any;
// No error
test(withAny);

Expected behavior:
I expected the second case to give an error. withAny might only have the properties of a number.
Actual behavior:
withAny reduces to the type any, and so does not give an error.

This is working as intended. Since any is compatible with any type, the type any | number (which means any or number) is effectively the same as just any.

Should this be a compiler error under --noImplicitAny? Since any | T is, well, implicitly any.

Oh, is there same way to recover from the any case? Given a function which has multiple return types, like:
declare function apiCall(): string;
function pickOne() {
    if (Math.random() > 0.5) {
        return 5;
    } else {
        return apiCall();
    }
}
let x = pickOne();

It seems unfortunate to reduce the type to any when apiCall returns any, like in this case:
declare function apiCall(): any;

function pickOne() {
    if (Math.random() > 0.5) {
        return 5;
    } else {
        return apiCall();
    }
}

let x = pickOne();

In this case because some of the return values are typed it appears that accessing any property not inside of number should result in a type error. Even though it is unknown what apiCall returns (it could be anything), we know there are cases when we will only have a number.

It seems unfortunate to reduce the type to any when apiCall returns any

Do you have another suggestion?  any could be a string... it could be anything... the hint is in the name.  It isn't a reduction, it is a widening to all types, because the code said it could be any type.

Even though it is unknown what apiCall returns (it could be anything), we know there are cases when we will only have a number.

And, statistically, an equal number of cases where you could have anything. 😖
You can always re-narrow...
declare function apiCall(): any;
declare function stringsOnly(value: string): void;

function pickOne() {
    if (Math.random() > 0.5) {
        return 5;
    } else {
        return apiCall();
    }
}

let x = pickOne();

if (typeof x === 'number') {
  stringsOnly(x); // Argument of type 'number' is not assignable to parameter of type 'string'.
}

TypeScript is trying (and succeeding) at keeping you from writing dangerous code.

Oh, I guess I just found it odd because usually typescript only allows you to access members common to all parts of a union. For example in the string | number case you can only call .toString() and .valueOf(), but not  .toFixed().
But I see that treating any strictly would break backwards compatibility by forcing type narrowing when you have any types. Perhaps there could be a warning when an any is involved in a union? I have encountered cases when a stray any from an external .d.ts library propagates through my code, masking real type errors.
Researching more it looks like this may just be a rehash of https://github.com/Microsoft/TypeScript/issues/9999, so I will close.


:bug: dynamic is_public from selected sheet

The old fast-track is setting the Make dataset private field dynamically if the user selects the existing sheet. This is especially important for updating existing private datasets. Without this, we'd have to tick "private" every time when doing an update.
Unfortunately, streamlit doesn't support on_change in forms, so I had to put it outside the form using this hack. It's not very nice.
Alternative solutions:

select box with Auto, Public and Private (Auto would use existing sheet's visibility with public as default)
disable setting private / public for existing sheets (we might face the same issue with dynamic forms here)

Summary by CodeRabbit

Refactor

Improved form handling and user input processes in the application, including new placeholders for selections and settings adjustments.

Thanks for doing this, @Marigold.
This is particularly an annoying part of Streamlit I've encountered in other places, too. This is a well-established workaround at the moment.
I've tweaked some of the code to avoid running the first step without clicking the submit button. This happens if a user submits a dataset and then changes the state of an "out of the form" element (e.g. checks the "make dataset private" checkbox). This occurs because Streamlit re-executes the script every time there is a change in an element (elements within a form don't count), and then since the st.session_state.to_be_submitted is set to True, it just proceeds with submission.
To avoid this, I've added a reset_states call in the on_change parameter of the "out of the form elements" to ensure that st.session_state.to_be_submitted is set to False whenever the user changes the state of these elements.
Also, made sure to pass the formatting tests.


Threads improvements

Hello.
I know this is not so beautiful as previous commit, but I was losing my threads again.
With this improvement, it has been working in production in more than 10 hosts for a week without losing any thread. It looks like it simply works.
I'm afraid it is hard to understand, by checking all posibilities. Maybe I forgot something, so I asked one of my mates to double-check it with me. The good news are there is just one commit with related information.
Please, be free to ask me about any flow you may think about.
Thank you!

Have you tried to use the ConcurrentDictionary? It might help you remove some code
https://msdn.microsoft.com/en-us/library/ee378665(v=vs.110).aspx


Why use prev.inverse to calculate the delta transformation between the previous keyframe and new frame?

hi, @krisklau, @koide3
https://github.com/koide3/hdl_graph_slam/blob/master/include/hdl_graph_slam/keyframe_updater.hpp
In keyframe_updater.hpp: 43-45, ( prev_keypose.inverse() * pose).translation().norm() is used to calculate the  delta transformation between the previous keyframe and new frame.
    Eigen::Isometry3d delta = prev_keypose.inverse() * pose;      double dx = delta.translation().norm();      double da = std::acos(Eigen::Quaterniond(delta.linear()).w());
But why not just use (pose -  prev_keypose.inverse()).translation().norm() to calculate the dx?
Did I miss anything？

Maybe I have got the difference between this two method.
Yours represents delta_translation in base_link frame, and mine represents delta_translation in map frame.
Sorry to disturb you.


[ZEPPELIN-688] Giving an option to hide REPL output in Spark interpreter

What is this PR for?
When a user runs Spark interpreter, the result will come out with result number message like :
res0: Int = 250

Someone might want to print this REPL output with their result, but others may want to see the result only since sometimes this output is too verbose. So, I just want to give an option to hide this REPL output to those users.
The default value of zeppelin.spark.printREPLOutput is true. This status is as-is. Users can hide REPL output only when they changes this property true to false. In this case, they can check the result by specifying such as print(some_variable).
What type of PR is it?
Improvement
Todos

[x] - Add a property zeppelin.spark.printREPLOutput
[x] - Add Spark interpreter property table to docs/spark.md

What is the Jira issue?
ZEPPELIN-688
How should this be tested?
After applying this PR,

Create spark interpreter for this test and change zeppelin.spark.printREPLOutput property value true -> false
Create a notebook and bind interpreter what you made.
Write val a = 250 down and run this paragraph. Then you can check the any output is not shown although paragraph status is FINISHED (This is the result of this PR).
Run print(a) in the next paragraph. Then finally you can get a result 250.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? I added Spark interpreter property table to docs/spark.md.

@Leemoonsoo Thanks for your suggestion. I've just added a sentence as you said : )
Plus, I rebased since #760 and this PR both changed sparkInterpreter.java.

Thanks. it looks good to me!

Merge if there're no more discussions.

LGTM.


fix #8721,#9873: wrong type when computed return about this

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fix vuejs/vetur#1707, vuejs/vetur#1509, #8721, #9873
When computed return about this property,
The this type is wrong.

@ktsn I don't know this PR.
Is it the right solution?
I added the test about the question.
Please take a look.

@ktsn, aren't you going to merge this bugfix? You approved it in April but it's still not merged. This one affects Vetur and breaks intelisense so it seems quite important to me as VSCode + Vetur + Vue programmer.

Good evening, I'm wondering if someone forgot to merge this pull request, agree with @Yahohoo the intelisense is important for us, hoping someone merge it @ktsn or @yoyo930021

bump, @ktsn can you merge it?

This does not seem to fix https://github.com/vuejs/vetur/issues/1707
I'm testing with https://github.com/octref/veturpack. Manually writing the changes to node_modules/vue/types/options.d.ts doesn't fix the issue.

這似乎無法修復vuejs / vetur＃1707
我正在使用https://github.com/octref/veturpack進行測試。手動將更改寫入node_modules/vue/types/options.d.ts不解決此問題。

https://github.com/vuejs/vetur/issues/2131#issuecomment-680809788

bump, @ktsn can you merge it?

https://github.com/vuejs/vetur/issues/2131#issuecomment-680809788

This does not seem to fix vuejs/vetur#1707
I'm testing with https://github.com/octref/veturpack. Manually writing the changes to node_modules/vue/types/options.d.ts doesn't fix the issue.

https://github.com/vuejs/vetur/issues/2131#issuecomment-680809788

@yoyo930021 Great, now we have TS 4.0.2 in Vetur by default as well. Are you planning to send a new PR to vue?

@yoyo930021 Great, now we have TS 4.0.2 in Vetur by default as well. Are you planning to send a new PR to vue?

The problem is only work when typescript 3.9 up.
I don't know if we can accept this kind of PR?

Updating devDependency should be fine...I guess? /cc @yyx990803

I guess #11488 also can fix it.


SelectQueryCoordinator always gets the most recent ScrambleMetaSet

It gets ScrambleMetaSet from ScrambleMetaStore via its retrieve() method before running select queries.

Codecov Report

Merging #196 into master will increase coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   73.08%   73.33%   +0.26%
==========================================
  Files         141      141
  Lines        8333     8334       +1
  Branches     1325     1325
==========================================
+ Hits         6089     6111      +22
+ Misses       1886     1870      -16
+ Partials      358      353       -5

Impacted Files
Coverage Δ

...va/org/verdictdb/coordinator/ExecutionContext.java
87.7% <100%> (+0.1%)
:arrow_up:

.../core/scrambling/FastConvergeScramblingMethod.java
91.21% <0%> (+1.31%)
:arrow_up:

.../verdictdb/core/execplan/ExecutableNodeRunner.java
93.14% <0%> (+7.85%)
:arrow_up:

...ictdb/core/resulthandler/ExecutionTokenReader.java
72.73% <0%> (+9.1%)
:arrow_up:

...rg/verdictdb/core/execplan/ExecutionInfoToken.java
82.76% <0%> (+20.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f73b2...f10dc6d. Read the comment docs.

VerdictContext now has a ScrambleMetaSet which gets initialized upon its creation.


why nerf villager trade and iron golem farm? 为什么削弱村民交易和刷铁机？

They exist in vanilla, but it doesn't mean they're balanced. These two mechanics are op.
它们存在于原版，但并不意味着它们是平衡的。这两个机制太破坏平衡了。


gomruby.h: fix indentation to be 2-space consistent

it's about 50/50 in here. May be my fault, not entirely sure. I just use 2 space myself, and if 4 (which is what's in use everywhere else) is what is to be used, I can adapt this patch to 4; the goal is to get it cleaned up.

I really don't care as long as its consistent. :) Looks fine.

ty!


revert #1183

#1183 caused lots of controversy https://groups.google.com/d/msg/inaturalist/-JR7FgQWALQ/49ymGRk7AgAJ
Consensus was to revert it and create a separate forthcoming issue to add public and private positional_accuracies to ES and the API
This issue is to revert #1183

I won't type much now since I'm up with baby (potential crankiness) but for
the record let it be noted, about half the people who commented wanted it
rolled back and the other half wanted to keep it. The filter alone doesn't
really meet what I was hoping for here, though I still hope it is created.
Thanks.
On Tuesday, November 29, 2016, Scott Loarie<EMAIL_ADDRESS>wrote:

Closed #1206 https://github.com/inaturalist/inaturalist/issues/1206 via
21b273d
https://github.com/inaturalist/inaturalist/commit/21b273df4e978fb7a0ead9def591e2735700cb2d
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/inaturalist/inaturalist/issues/1206#event-874854328,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG1tk0ut-aefnmcjNJanvwbQmUhxlvFZks5rC-HjgaJpZM4K-r9G
.

--
Sent from Gmail Mobile

why won't the filter work for you your use-case?

Because it only works on one particular page not the core functionality of
the site (range maps, species lists, identotron, etc). When I am looking at
an observation to help with id the bad data contaminates the map that
appears there on the observation page.
I just don't think we should remove a feature because two or three people
don't like it, when others say they do see value in it.  If it's true that others don't care as much
about location than I do that's fine but I think it's worth hearing from a
few more people? The feature was literally deleted overnight and basically
because one user (Afro bats) didn't like it.
Can you at least make it so we can exclude the badly mapped data from
projects, please? It doesn't solve the problem but it's something.
On Tuesday, November 29, 2016, Scott Loarie<EMAIL_ADDRESS>wrote:

why won't the filter work for you your use-case?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/inaturalist/inaturalist/issues/1206#issuecomment-263514923,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG1tk6ATJP7ODBf5f0LdDVFz0DfeBGmMks5rC-tCgaJpZM4K-r9G
.

--
Sent from Gmail Mobile


[MuiThemeProvider] Forward the options when nested

Actually the MuiThemeProvider don't use the context to determine whether or not disableStylesGeneration
Closes #10175
The problem is that in the apollo case, the JSS is rendered twice on the server
The way to avoid this is to pass the disableStylesGeneration props to MuiThemeProvider
But, in some cases, the MuiThemeProvider can be rendered down in the app, so It require some additionnal logic from the user to make it render JSS once
This PR add a way to simply disable JSS rendering by setting the context to :
{
  muiThemeProviderOptions: {
    disableStylesGeneration: true
  }
}

The MuiThemeProvider then grab the value from the context if no disableStylesGeneration prop is passed
If this is a correct way of handle the case, I will commit on the PR a new Component
<DisableStyle disable:bool />
which toggle the context.muiThemeProviderOptions.disableStylesGeneration property according to the disable prop

If this is a correct way of handle the case, I will commit on the PR a new Component

which toggle the context.muiThemeProviderOptions.disableStylesGeneration property according to the disable prop

@Aetherall Thanks for the pull-request. I have added some test to prevent regressions in the future. I'm not very happy with the current state. In the future, maybe we could rename MuiThemeProvider to MuiProvider to illustrate that the component responsibilities have grown. We could make the theme property optional too.
But anyway. I don't think that we should push the story forward now. Let's wait for the new React Context to land and maybe for v1 to be released.

! [remote rejected]     context-aware-provide -> context-aware-provide (permission denied)

@Aetherall Can you allow us to push on your branch?

@Aetherall Thank you.

@oliviertassinari Thanks for the test and the cleanup !
And also, I thing adding a reference to MuiThemeProvider API in the server-side rendering guide would help new users
It took me so long to figure out why my classnames mismatches... Silly mistakes are so frustrating ><
Anyway Thanks for merging this !

And also, I thing adding a reference to MuiThemeProvider API in the server-side rendering guide would help new users

@Aetherall Yes, we could add a link from MuiThemeProvider in https://material-ui-next.com/guides/server-rendering/#handling-the-request to https://material-ui-next.com/api/mui-theme-provider/#muithemeprovider. Great idea 👍

I'm on the documentation thing.

Great ! And actually I'm experiencing classnames missmatches when using the material-ui-pickers in my project ... seems than classnames are not generated in client at all, can it be related to the need of our own jssProvider ?

@Aetherall Check your bundle, maybe you have two Material-UI version loaded. Yes, JssProvider can help.

Nope, just one version... It seems to be related to the use of IconButton...


feature wish: JSONPath

A simple query() function would be a fantastic addition.  Maybe it's totally out of scope for this project, but searching the issues didn't turn up any discussion, so maybe this issue is just a place to say it wont be done :)
Some related refs:
http://goessner.net/articles/JsonPath/
https://chromium.googlesource.com/external/mozc/+/master/src/net/jsonpath.cc
https://www.genivia.com/doc/xml-rpc-json/html/

Currently, only JSON Pointer is implemented. JSON Path sounds interesting, but I currently do not have the time to look into it.

I had another look at this. It seems doable, but also a lot of work. I shall postpone this ticket until after the 3.0.0 release.

No worries!  It'd definitely a lot of work.  Really cool of you to look at it tho, open source is awesome :)

Is there an agreed upon reference for JSON Path?

I think this is the first - http://goessner.net/articles/JsonPath/

This less of a specification, but rather a list of examples.
Furthermore:

XPath has a lot more to offer (Location pathes in not abbreviated syntax, operators and functions) than listed here.

I'm closing this for now in lieu of a proper specification of "JSONPath", see https://github.com/nlohmann/json/issues/343#issuecomment-270067634.

Hi, @nlohmann Would you consider supporting or accepting the PR of JSONPath?

Why not? Is there a proper specification now?

It is still not a standard, but we have "conventional" examples: https://github.com/freestrings/jsonpath/wiki/rust-examples
Including those implemented by RedisJSON.

I see. In any case, it would be best to implement this as free functions; that is, not to add any member functions, because the API is already pretty bloated. Do you think this is possible?

I haven't dig into the code details yet, and I don't quite understand what you mean by free functions.
But I think as a parsing path, under the premise that JSONPointer is already supported, it would be best if it can be automatically recognized as JSONPath or JSONPointer and successfully access the element.

I meant I'd rather have something like
json authors = json::selector(j, "$.store.book[*].author");

rather than
json authors = j.selector("$.store.book[*].author");

Oh, I think I agree with you, after all, json::parse is like this.

Now up to draft 6, progress tracked at https://datatracker.ietf.org/wg/jsonpath/about/ , standards track document due in November.

Is the JsonPath feature available now?

Hi.
@nlohmann :  Any news on this ?  :-)
(btw, I just came across this cool jsonpath online evaluator : JSONPath Online Evaluator by Kazuki Hamasaki for those who might be interested)
Thank you.

It's not on my todo list, but merge requests are welcome.


unexpected argument ‘configurationCommon’

$ NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs/archive/21a8239452adae3a4717772f4e490575586b2755.tar.gz nix-build
error: anonymous function at /nix/store/vi96434p25iamf88ddwprpb62yqdmxry-21a8239452adae3a4717772f4e490575586b2755.tar.gz/pkgs/development/haskell-modules/default.nix:1:1 called with unexpected argument ‘configurationCommon’, at /nix/store/vi96434p25iamf88ddwprpb62yqdmxry-21a8239452adae3a4717772f4e490575586b2755.tar.gz/lib/customisation.nix:56:12

After resolving https://github.com/input-output-hk/stack2nix/issues/48, I was able to generate a default.nix file. However, when I try to build, I get the above error.
Any ideas what may be going wrong?

Use newer nixpkgs version (nixpkgs master).


Retry infinity

Hello, would you consider adding an infinite retry decorator similar to the already existing retry?
I have written my own implementation and I'd like to add it to the package

Why not simply call with some large number?

Because by design I want it to be infinity and not arbitrarily large :)


fix: move bootstrap to appropriate level of the project

See deployed project at https://dfn-shaylan.herokuapp.com.
Try npm run heroku:deploy from this branch and see if you're able to deploy successfully.
You also have an error in seed.psql. When I ran npm run heroku:db:init I get the following error:
ERROR:  invalid input syntax for type integer: ""
CONTEXT:  COPY donation_event, line 1, column id: ""

Strange, I only have two entries in my donation event table and they both have integers within the id column. They are also serial primary keys therefore auto-generating. I'll look into it further with my mentor unless you have any idea what it could be.


Add project metadata to pyproject.toml

Adds project metadata to pyproject.toml, and removes setup.cfg.
Testing
Pip install from Git repo
python3.9 -m venv .venv
. .venv/bin/activate
pip install -U pip
pip install git+https://github.com/sethfischer/build123d.git@114-pyproject-toml

Development install
git clone https://github.com/sethfischer/build123d.git
cd build123d
python3.9 -m venv .venv
. .venv/bin/activate
pip install -U pip
python -m pip install -e .

Closes #114

Thanks for creating the pyproject.toml file, but I'm having trouble getting it to work.
python -m pip --no-cache-dir install -e .
Obtaining file:///home/roger/Documents/build123d
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Collecting OCP-stubs<EMAIL_ADDRESS>  Cloning https://github.com/CadQuery/OCP-stubs (to revision 7.6.3) to /tmp/pip-install-b7a_hvuh/ocp-stubs_a8cefe394c27462592381774ae17aee0
  Running command git clone --filter=blob:none --quiet https://github.com/CadQuery/OCP-stubs /tmp/pip-install-b7a_hvuh/ocp-stubs_a8cefe394c27462592381774ae17aee0
  Running command git checkout -q 24323f86ff87ac82902ef6ad34123b051bf207b1
  Resolved https://github.com/CadQuery/OCP-stubs to commit 24323f86ff87ac82902ef6ad34123b051bf207b1
  Preparing metadata (setup.py) ... done
Collecting anytree<3,>=2.8.0
  Downloading anytree-2.8.0-py2.py3-none-any.whl (41 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 41.7/41.7 kB 5.2 MB/s eta 0:00:00
Collecting typing-extensions<5,>=4.4.0
  Downloading typing_extensions-4.4.0-py3-none-any.whl (26 kB)
Collecting cadquery-ocp==7.6.3a0
  Downloading cadquery_ocp-7.6.3a0-cp38-cp38-manylinux_2_31_x86_64.whl (166.4 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 166.4/166.4 MB 14.3 MB/s eta 0:00:00
Collecting svgpathtools<2,>=1.5.1
  Downloading svgpathtools-1.5.1-py2.py3-none-any.whl (67 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 67.2/67.2 kB 15.9 MB/s eta 0:00:00
Collecting numpy<2,>=1.24.1
  Downloading numpy-1.24.1-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (17.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 17.3/17.3 MB 15.9 MB/s eta 0:00:00
ERROR: Package 'build123d' requires a different Python: 3.8.8 not in '>=3.9'

The error message is the same every time but it seems to fail at different points. In this try I've disabled caching and it still fails.  Any idea what is happening?

@gumyr I can replicate the error above by using a Python 3.8 environment:
# replicates ERROR: Package 'build123d' requires a different Python: 3.8.10 not in '>=3.9'
git clone https://github.com/gumyr/build123d.git py38
cd py38/
python3.8 -m venv .venv
. .venv/bin/activate
pip install -U pip
python3.8 -m pip --no-cache-dir install -e .

A Python 3.9 environment works as expected:
# works as expected
git clone https://github.com/gumyr/build123d.git py39
cd py39/
python3.9 -m venv .venv
. .venv/bin/activate
pip install -U pip
python3.9 -m pip --no-cache-dir install -e .

This is because pyproject.toml specifies the minimum version of Python as 3.9:
requires-python = ">=3.9"

This is the same as the intention of setup.cfg that pyproject.toml replaced:
[options]
package_dir =
    = src
packages = find:
python_requires = >=3.9

However, I did not test setup.cfg so I do not know if python_requires = >=3.9 was enforced. But this is correct according to the setup tools docs.

My bad!  I forgot to specify the python version when I created the test environment and it was 3.8.  I should have picked that up.  Thanks for the contribution!


Upgraded libraries (snakeyaml up to version 1.18), fix compilation errors

This PR contains an upgrade of some libraries, in particular Scala to the last 2.12.x version.

Did you test it out??, last time i tried to update the avro versioin to 1.8, i got a bunch of issues

Hi @roycem90,
There's no a test suite to run unfortunately.
Nevertheless I launched every config.yml I found under example/ and src/test/resources/ folders, and there are 2 tests that do not work, in both branches master and upgrade-dependencies (mine).

src/test/resources/avro.yml
src/test/resources/both.yml

which brings me to the conclusion that upgrade dependencies won't break existing code.
If you want, you can try to test both branches and compare them, as I did 😊
Thanks in advance and let me know 😉
Cheers.


Display client version in audit log

What changes are proposed in this pull request?
Displaying client version in audit log
Why are the changes needed?
This allows us to know the version of the client connected to alluxio.
Does this PR introduce any user facing changes?
Display client version information in the audit log like
2022-11-30 18:08:57,038 INFO AUDIT_LOG: succeeded=true	allowed=true	ugi=xxx,xxx(AUTH=SIMPLE)	ip=/xxx:52912	cmd=mkdirs	src=xxx	dst=null	perm=xxx:xxx:rwxrwxrwx	executionTimeUs=160770	clientVersion=xxx	proto=rpc

Also can you do some test? If tests are not this easy to write, at least provide a screenshot of the audit log from your alluxio cluster. thanks!

Added modified audit log format.

I feel adding another injector is a bit unnecessary. Like https://github.com/Alluxio/alluxio/pull/16586/files can you check if that version info can be added to ClientIpAddressInjector?

Modified the code according to today meeting. PTLA @jiacheliu3 @elega

@qian0817 Please resolve the merge conflict in JobMasterAuditContext.java
@jiacheliu3 is the code ready to be merged?

@qian0817 Thanks a lot for the improvements! Seems now the only blockers are:

Rebase master
Resolve the leftover small comments
And the PR is good to merge

alluxio-bot, merge this please


Update 08_using_compose.md

Yes, I am this anal

Proposed changes

Unreleased project version (optional)

Related issues (optional)

@CholoTook The update looks good. Could you update your commit message before we can merge this PR? Thanks.


discoverAllServicesAndCharacteristics stopped working with raw USB mode at version 0.4.3

I cannot discover services and characteristics while using the raw USB mode anymore. It worked (and still works) with version 0.4.2 though. These are the adapters I've tested this with (separately):
Bus 001 Device 006: ID 0a12:0001 Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode)
Bus 001 Device 008: ID 0a5c:21e8 Broadcom Corp. BCM20702A0 Bluetooth 4.0

@NPohl could you please provide some debug logs?

sudo DEBUG=* node <file>.js
sudo hcidump -t -x

This is probably related to https://github.com/sandeepmistry/noble/issues/372 as well. I'm trying to track it down, but haven't reproduced the issue locally yet.

Fixed via https://github.com/sandeepmistry/node-bluetooth-hci-socket/commit/25999ec523325e43d5d900a7ae8866607f56fd9b and which had been published to npm as v0.4.4.


I have imported the Library correctly, I just need to know what I need to type as 'import ...', can someone help me out with this?

I have imported the Library correctly, I just need to know what I need to type as 'import ...', can someone help me out with this?

You can use this website https://jitpack.io/#PlusHaze/TrayNotification/a8bfa597eb in order to import library in a maven or gradle project. Then it will automatically import what you want


[Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280

[x] Fixed #10280

Purpose of the pull request
In this pull request, I fixed the problem that the OSUtils.loadAverage method could not get the CPU information under Windows. In addition, I found that many test cases cannot run on the Windows system,  I think we should give some tips to developers in the official website documentation
Brief change log
Use com.sun.management.OperatingSystemMXBean#getProcessCpuLoad(); instead of java.lang.management.OperatingSystemMXBean#.getSystemLoadAverage(); to get cpu load information on windows
Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Hi @zhuangchong
PTAL,

Codecov Report

Merging #10281 (158b33b) into dev (7ac8ea4) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##                dev   #10281      +/-   ##
============================================
- Coverage     41.14%   41.14%   -0.01%
  Complexity     4759     4759
============================================
  Files           855      855
  Lines         34618    34621       +3
  Branches       3826     3827       +1
============================================
- Hits          14245    14244       -1
- Misses        18998    19001       +3
- Partials       1375     1376       +1

Impacted Files
Coverage Δ

.../apache/dolphinscheduler/common/utils/OSUtils.java
30.43% <16.66%> (-1.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac8ea4...158b33b. Read the comment docs.

I understand that there is no com.sun.* package in openJDK, and I'm not sure if oracle JDK has lineces issues.
@zhongjiajie Please help confirm.

yes, it has license issues
By the way, DS doesn't support running on Windows,  so these codes are not necessary

I understand that there is no com.sun.* package in openJDK, and I'm not sure if oracle JDK has lineces issues. @zhongjiajie Please help confirm.

yes, it has license issues By the way, DS doesn't support running on Windows, so these codes are not necessary

I understand that there is no com.sun.* package in openJDK, and I'm not sure if oracle JDK has lineces issues. @zhongjiajie Please help confirm.

Ok, since there is a certificate problem, I will close this pr. I have another question. I found that the system has been adapted to windows in many places. Maybe because some people develop on windows, is it necessary to make a special judgment in this test case?


feat(extension): credo

Current dependencies on/for this PR:

main

PR #163   👈

This comment was auto-generated by Graphite.


Setup cross-signing for existing users

If the user has not set up cross-signing yet, we need to ask them to do so.
The plan is to use:

[x] a banner
[x] security settings

This is will require to request account password (that would be great to think how to manage SSO as well).
Design will come soon at https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=5050%3A31796.
Those users will be invited to set up 4S in a second step in the same way new users are. This is described in #3293  and #3296 .

The banner has been implemented too.


Error while connecting mongo db

Hi All,
I am getting following error while connecting mongodb
exception={com.mongodb.MongoSocketReadException: Prematurely reached end of stream}}];
For additional info - We are using replica set,LDAP and it is behind ssl
Can you please suggest some solution. Thanks in advance.

Prasad

@prasadyash  check if this helps - https://github.com/capitalone/Hygieia/issues/1102
https://github.com/capitalone/Hygieia/issues/1218

@prasadyash  share error log

@prasadyash @nireeshT - closing this due to inactivity.


✨ Pinch to increase/decrease font size

Description
We can do pinch-to-zoom, but it has to be super smooth.
Perhaps we pinch and initially zoom during the gesture (not change the font size), then after the gesture ends, reset the zoom and adjust the font size to the same visual size when it was previously zoomed which would wrap the text as expected.
That would appear to the user like this:

Gesture (Pinch to zoom) starts
Gesture ends
Text immediately reflows to wrap

What actually happens:

Gesture (pinch-to-zoom) starts
Text view zoomed - remaining anchored to the left
Gesture ends
Zoom amount multiplier captured
Text view zoom restored
Font size is multiplied by the zoom amount multiplier previously captured
This gives the appearance of the text reflowing to wrap

This behavior can be seen when looking at the Find Navigator, doing a search, and resizing the navigator sidebar. Notice it doesn't reflow the text until releasing the mouse to commit the size.

Can someone assign this to me, I've got the basics of it working:
https://user-images.githubusercontent.com/128280019/232341472-5ff7357c-087f-41aa-872d-05a3bfd93825.mov


Addressed the credit card number issue

The credit card number for an order was being stored in the database, saved to the user record as well as payment methods and orders. In addition, the card number was also logged in clear text.
I added a mask at the API request point for a new order, so instead of<PHONE_NUMBER>111111 it is now XXXXXXXXXXXX1111. This is not an optimal solution, but is one step better than storing things in clear text.
Fixes #110

Ideally, this would show people how to securely deal with payments and eliminate credit card storage altogether, rather than masking payment details without facilitating implementation of a secure payment flow.
I'm ok with this for now, but it doesn't lead people in the right direction currently.

I did start down that route (removing CC storage) but I wanted to stay focused on the task at hand, which is triage for Build. Once we get this done, we can move on to a more ideal situation - but the CC bits are in the fabric of the application, meaning that the application requires a user to login, then we attach a payment method to them (which is CC rn), and that payment method ID is attached to the order. This is a weird way of doing eCommerce, but we can think on that when it's not on fire :D

This 2-step approach is fine to me. I see that CI is failing, eg the eShop.Ordering.FunctionalTests.OrderingApiTests.AddNewOrder test. Could you please fix the tests?
Any help you can provide in getting the payments flow up-to-scratch is much appreciated.

Thanks James - should have had a null check in there!

Looks like this has already been merged, but I'd like to see a comment added here as well that indicates why we're doing the masking and explicitly point out that this isn't the "solution" to this problem. In the interest of guiding people down the right path, we wouldn't want people to come to this code and just remove the masking and move on...


Trouble with moving a file into Sandbox

I have been having trouble all day trying to move an image to the sandbox, so far I get to the end but it has trouble constantly trying to direct it to the sandbox

@Beeplosion I'm about to help another student with a similar problem over Zoom. Want to join us right now in my office Zoom here?
https://psu.zoom.us/my/ebeshero

@Beeplosion Okay, let's see if I can walk you through this. Are you online now? Are you trying to use mv or cp to move the file? If you're stuck on that part, can you show me the commands your entering?
Are you at the position of the textEncoding-Hub on your local computer when you're tying to copy the file in?
Where is the source file located?

@Beeplosion Here's a shortcut: It is perfectly okay to drag and drop a file into the textEncoding-Hub/Sandbox using your file manager or Finder. There's no harm in that. Then go and open your Bash or Terminal to do that sequence:
git add .
git commit -m "your commit message here"
git push
At some point in there, either when you commit or push, you'll probably be prompted to enter your GitHub username and password, so do that carefully!

the tricky part is I seem to have done this but when I try to push the image in this pops up:
" git push
fatal: The current branch master has no upstream branch.
To push the current branch and set the remote as upstream, use
git push --set-upstream origin master

sorti@DESKTOP-O8NKM44 MINGW64 ~/Documents/GitHub/textEncoding-Hub/Sandbox (master)
$ git push --set-upstream origin master
fatal: 'C:/Users/sorti/Documents/Lillie.jpg' does not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists."

"$ git remote -v
origin  C:/Users/sorti/Documents/Lillie.jpg (fetch)
origin  C:/Users/sorti/Documents/Lillie.jpg (push)
"

I somehow made another sandbox within the sandbox

@Beeplosion Hmmm. This looks to me like you're trying to enter your git push from the wrong location!
You want to navigate to the textEncoding-Hub on your computer to do the git commands from there. It looks like your just up in your Documents directory!
So, here's what should happen. If you are trying to push Lillie.jpg to the Sandbox on the remote web repo that we share, you first need to save it to the Sandbox directory of textEncodingHub.
Its file location should be inside textEncoding-Hub/Sandbox
It looks to me like you're trying to push it from your Documents directory. Instead it should be here:
C:/Users/sorti/Documents/GitHub/textEncoding-Hub/Sandbox/Lillie.jpg

@Beeplosion Hmm. How did you get a Sandbox inside the Sandbox? We will probably need to undo that.

@Beeplosion Would it help to share your screen over a Zoom session right now? I think I can help you troubleshoot this.


Document RequestImageFileAsync method breaking change

Document the breaking change described at https://github.com/aspnet/Announcements/issues/451

@gewarren Thank you for catching that. Ready for your review again.


Update tutorial.md

changed http://localhost:3000/hello_world to http://localhost:5000/hello_world

This change is

Coverage remained the same at 99.329% when pulling db853d8c86584ede1307b682f67ab4fbbe7619cd on gurbraj:patch-1 into cb480977fcc01a2f9852ffb4bc51a701c19eee3b on shakacode:master.

see comment
thanks for the help!

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

docs/tutorial.md, line 80 at r1 (raw file):

and then run server with

export PORT=3000

docs/tutorial.md, line 87 at r1 (raw file):

Visit http://localhost:5000/hello_world and see your **React On Rails** app running!

see change above with exporting the port to the standard rails port.

Comments from Reviewable

Thanks @gurbraj!


Make RegexBuilder quantifiers follow option settings

This changes the RegexBuilder quantifiers to take an optional behavior, so that by default they can follow the current options setting. An explicitly provided behavior is always used.
This is how the regex syntax operator works:
let _ = /\w+/           // eager one-or-more operator
let _ = /\w+?/          // reluctant one-or-more operator
// (?U) toggles eager/reluctance
let _ = /(?U)\w+/       // reluctant one-or-more operator
let _ = /(?U)\w+?/      // eager one-or-more operator

In RegexBuilder regexes, we get support for (?U) via the reluctantQuantifiers() modifier method:
let _ = Regex {
    OneOrMore(.word)             // reluctant due to option method below
    OneOrMore(.word, .eagerly)   // eager due to explicit behavior parameter
}.reluctantQuantifiers()

@swift-ci Please test


refactor: disambiguate property constants across segments

Prerequisites

[x] I have read and understand the CONTRIBUTING guide
[x] I looked for duplicate issues before submitting this one

Description
When creating a new segment configuration options are specified as constants, like this for the "Exit" segment:
const (
	//DisplayExitCode shows or hides the error code
	DisplayExitCode Property = "display_exit_code"
	//AlwaysEnabled decides whether or not to always display the exitcode info
	AlwaysEnabled Property = "always_enabled"
	//ErrorColor specify a different foreground color for the error text when using always_show = true
	ErrorColor Property = "error_color"
)

The challenge is that since all the segments are in the same package, the constants defined here (AlwaysEnabled) which appear to be per-segment actually aren't. If I wanted a property for a different segment to have an always_enabled configuration option I'd have to either:

Name it something different, like MySegmentAlwaysEnabled; or
Use the constant defined by a different segment, which feels sort of odd.

Maybe that first option is fine, but it seems weird that some of the segments would need a prefix for their constants but there wouldn't be a convention across all the segments.
I'm not sure what the best solution to this is. Since Go doesn't have a notion of file-scoped variables or constant structs, I'd guess the options are:

Don't do anything, just fix it with name prefixes going forward.
Refactor all the segments to prefix their associated constants with the segment name (or some similar convention).
Put all the configuration constants in a single file. This would make it harder to see what each segment uses, but it'd also enable easier standardization of configuration properties across segments. You wouldn't get always_enabled vs enable_always or something because everyone would be using the same constant for the same intent.
Put each segment in a different Go package. This seems like it'd be more work but it might be nice to isolate the code and tests for an individual segment.

I didn't know what the preference here was so I figured I'd open an issue and ask. I'd be happy to PR an update if it sounds like some refactoring needs to be done. And if not, I'm glad I asked. 😄
Aside: Thanks for your patience and help with the issues and PRs I'm throwing your way. I'm pretty excited about this new OMP version and it's helping me bring up my Go skills.

For these I actually have properties set in properties.go. I already encountered this, so imho the best thing to do is to add it there once there's a proper case to reuse it cross segments, but still add them to each of the segment's docs when they're not used everywhere automatically (some are, via engine.go)

OK, cool. I noticed the node module has a display_version setting and I was going to look at a dotnet CLI segment that'd act in a similar fashion, so display_version might be a candidate here. I figured I'd ask what the situation was before doing the wrong thing. Thanks!


Improve amin/amax torch functions

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (97a2fc7) 100.00% compared to head (2f82a89) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #404   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines         1673      1679    +6
  Branches       176       176
=========================================
+ Hits          1673      1679    +6

Files Changed
Coverage Δ

src/redcat/tensorseq.py
100.00% <ø> (ø)

src/redcat/tensor.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


To go cdns sslkeys

Branched from #2365 - recommend merging that first.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1795/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1808/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1850/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1964/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2014/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2048/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2063/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2074/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2081/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2082/
Test PASSed.