Implements re-buildings and dependencies building.

Right now you need to manually compile Orchard.ContentTypes.Abstractions because it's not a module which can be compiled before (because of the modules loading order) and it's not compiled through the web app. Otherwise seems to works but needs to be refactored ...
Note: For infos, during my tests if i wanted to load the Orchard.Contents before, i needed to specify in the module.txt a dependency on Orchard.Contents. If i only specify Contents, as seen with some modules, it seems that it doesn't work.
Best

@sebastienros
Very very experimental but now dependencies are analyzed and compiled if needed. Need to be refactored and can be improved. E.g there is the double extensions loading and right now all dependencies are analyzed even if it's a library which is already part of the orchard.web project ...

So, the double extensions loading needs to be fixed.

And i'll detect which libraries are already part of the orchard.web project, i already do this in ExtensionLibraryService.

Note: for the Orchard.Contents dependency which doesn't work if you use the extension name Contents, it's because this name is not parsed in the manifest file. In ExtensionHarvester.ParseManifest() line 178, i can see that field[0].ToLowerInvariant() = "name" and NameSection = "name", but the switch / case doesn't work, manifest.Add(NameSection, field[1]) is not executed. This for the Orchard.Contents module, seems not to be the case for others, very weird!
Best

@Jetski5822 done, thanks.
Need to sleep now :)

@sebastienros
I've done some updates, e.g fixed the 2nd extensions loading by using ApplicationPartManager in place of IExtensionManager. For the last one i couldn't inject it directly through the constructor because of a circular dependency. I think it's because IExtensionManager injects extensions loaders, one loader injects IExtensionLibraryService which can't inject IExtensionManager.
just a note on the last commit above because it's a so weird issue on string parsing! In the Module.txt the name section was not correctly parsed for 2 modules Orchard.Contents and Orchard.Setup. This explains the issue with a dependency on Orchard.Contents by using its name.
I could fix it by re-creating the 2 manifest files. Maybe because of some non visible special characters. That said, in ExtensionHarvester.ParseManifest() here the tests i've done before on the field[0] variable:
// for Orchard.Contents & Orchard.Setup, on the name section line
// while debugging, i can see that field[0] = "Name", then

field[0].StartsWith("Name") // return true
field[0].EndsWith("Name") // return true
field[0].Contains("Name") // return true
field[0].Equals("Name") // but this one return false!

Very weird but that's why the following switch / case was not working.
Best

@sebastienros
In the last update:

csc.dll is embedded in orchard.web and copied on building as specified in project.json. So, right now, maybe with vs tools you still have to copy it manually, but it should work in the future.

csc.runtimeconfig.json is automatically generated at runtime, you no longer need to copy it.

Notes & todo:

There are still 2 conditions which don't trigger compilation on startup, if a file has been removed or added but with an old date because of a copy / paste (dotnet build use an incremental cache file).

See if it's worth to implement the above, i could re-use a response file which memorize all compilation IO between 2 startups, i've removed the generation of this file to minimize IO operations.

To adapt the code, see in parallel how Orchard 1 do things. Seems that some implementations can be done separately e.g files watching ... So, right now, i still focus on compilation and on startup.

After testing: refactoring, helpers / extensions ...

Best

@sebastienros
Just done the checking on added / deleted compile inputs since the last compilation (because we can't only rely on dates). I've re-integrated the compilation response file that i use as a cache.
There are many other things to do, file watching, populate probing folders, more loading coordination (e.g maybe with artifacts folders) ... But, only related to compilation, i think we have about what we need.
But, right now, only on a dev environment, because i don't know yet how it will behave e.g in a published context, how all paths will be resolved ...
I think it's good that you test it on your environment before there are too many things.
First i need to rebase and resolve conflicts, i'll do it asap.
Best.

See my previous comment and its update section

Added diagnostics messages (string list) returned from the csc compiler. Right now i only init a local variable for testing but we will be able to use it for logging.
var compiler = new CSharpExtensionCompiler();
var success = compiler.Compile(projectContext, "Debug");
var diagnostics = compiler.Diagnostics;

If success and no diagnostics => all is ok, info compilation succeeded.
If success and some diagnostics => compilation ok but some warnings.
If not succees => compilation failure with some errors in diagnostics.

on conpilation making error
{"The filename or extension is too long"}

Thanks for the infos.
But i can't repro, just re-tried by deleting all modules (which now include core modules) and themes bin folders before starting the app, and i had no issue.
Need to be followed, if you can grab more infos ...
Best.

@GVX111
So, i can't repro. The only change related to file path i've made is on the working directory of the csc command. This to specify the current project directory in place of always using the running web app directory. But seems to be useless on my side and maybe not so good. So, i just reverted this little change. Can you try it with this last update?
Best.

var result = RunCsc(allArgs.ToArray())
.WorkingDirectory(Directory.GetCurrentDirectory())
.OnErrorLine(line => OnOutputLine(line, context, Diagnostics))
.OnOutputLine(line => OnOutputLine(line, context, Diagnostics))
.Execute();
i have this but same error. :|

Sorry, i can't repro.
So, it seems that in your case there is a file with a too long path. Where do you see the error message? While debugging, in the new provided Diagnostics message list?
Try to put some breakpoints, e.g when running the csc command to see the allArgs collection. Much simpler, in each modules obj folder, a dotnet-compile-csc.rsp file is generated. See in this file if a too long path is present.
Best

text.txt
this is in .rsp

Ok, i think i understand your scenario.
Dynamic compilation is only intended to compile extensions. Right now extensions are projects which are harvested from Orchard.Web/Modules and Orchard.Web/Themes (others folders could be added but by code / config files).
Then a module / extension project can depend on another module / extension. It can also depend on another project library which is not an extension, but in this case this library need to be an ambient library. This means that this library need to be in the Orchard.Web project dependencies.
This is because ambient libraries are loaded naturally and extensions libraries are loaded dynamically. So, if a project is not an ambient library neither an extension, it's assemblies will not be loaded. So, a module / extension can't depend on it.
It seems this is your scenario because in your file i can see that we try to compile the src\Orchard.Site project which is not an ambient library (because not precompiled with the app) and which is not an extension (because not in the Modules / Themes folder).
Best.

Anyway i got the same issue when trying as planned to run in a published env. After dotnet publish (with an adapted project.json) all is in a publish subfolder of orchard.web/bin. So, i have long paths as:
"\"c:\\jtkech\\Orchard2\\src\\Orchard.Web\\bin\\Debug\\netstandardapp1.5\\publish\\Modules\\Orchard.ContentTypes.Abstractions\\bin\\Debug\\netstandard1.5\\Orchard.ContentTypes.Abstractions.dll\""
But i fixed it by passing to the csc compiler the dotnet-compile-csc.rsp file (as dotnet do) this in place of passing arguments as an array of string (seems to be limited this way).
@GVX111 thanks to have pointed out this issue, i'll update my PR soon.
Best.

@sebastienros
So, i've got something working under what i assume is a published context. I needed to deal with ambient orchard libraries which are not resolved by the project model api when project files are not there.
Because i still work on my local machine, nugets are resolved as before. Maybe, in a prod env, they will be naturally resolved from the web app folder, need to be investigated ...
Maybe good to give it a try as it is in your environment before there will be too many things.
Best.

@sebastienros here my last update to work in a published context.

When in a dev environment, when a package is used by a module but not by the web app, it is stored in the module/lib folder. Currently, this only happens for the Orchard.Logging.Console which uses Microsoft.Extensions.Logging.Console.dll.

When publishing the publishOptions specify to copy, among others, the Modules folder (include bin & lib folders, exclude obj folder ...), see project.json.

In a "published" context, when the path of a package is not resolved, we try to search in the web app root directory, then in the ./refs folder, then we fallback to the module/lib folder.

In a "published" context, when the path of an ambient orchard library is not resolved, we fallback to the web app root directory.

Best

@sebastienros

1st, without my PR, with the last master branch for some view i needed to comment out in 3 places the new //[Admin] attribute (not included in this PR).

I've seen that now an orchard library can be neither ambient nor an extension but used as a dependency by an extension. So i needed to also compile / load them, and also store them in the module probing folders (with other module specific packages). This to work in a published context.

I also seen that core modules are with others. Wow, now so many things to dynamically compile / load.
Best.

Testing now ... for the [Admin] issue it must be that you need to clean your repos and do a dotnet restore. The attribute is in a different assembly now.

1- Probing folders should be .gitignore'd
2- Shouldn't there be a single probing folder, like in O1?

@sebastienros
1- You're right.
2 - You're certainly right. Is it possible that 2 modules use the same package dll but not the same version?
There are so many things, i was also thinking about artifact loader, but here maybe better to change VStudio xproj files ...
Right now i want to see how it behaves for you and if it's worth to continue.
Best

@sebastienros
Regardless my PR, because the AdminAttribute (of type AdminFilter) inherit from ServiceFilterAttribute, as i understand AdminFilter need to be registered as a service.
Not sure it's a good fix, but to be able to go to the /orchard.themes/admin/index view, i needed to add the following to get it working, then i was at least redirected to the login view.
So, i've created this file Orchard.Admin/Module.cs (not sure it's the right place)
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection.Extensions;
using Orchard.DependencyInjection;

namespace Orchard.Admin
{
    public class Module : IModule
    {
        public Module()
        {
        }

        public void Configure(IServiceCollection serviceCollection)
        {
            serviceCollection.TryAddScoped<AdminFilter>();
        }
    }
}

Best.

@sebastienros

Use a single probing folder App_Data/Dependencies. Currently i store all extensions (this is not necessary) and all their dependencies which can be packages / orchard libraries / extensions.

Select the Debug / Release configuration based on the compilation options of the running assembly.

TODO: If no source files (or just test if no project json files), then don't compile, still try to load the extension, manage bin / probing folders ...

Best

@sebastienros

So, we know if an extension is ambient (maybe now avoided) then we do an ambient loading.

We know if project files are there and we compile if needed and we do a dynamic loading.

If no project files, we would need to do a precompiled loading. But here we still need to know the dependencies to load e.g from the probing folder. Here there are different strategies (see below).

TODO:

In place of trying to load with each loader, i think i need to do a loader coordinator.

For precompiled loading, define a way to know dependencies to load. One solution is to always have project.json and project.lock.json files in extension folders.

Another solution is to compile extensions with the preserve context option (the assembly will embed Project.lock.json infos) (we can force this option). Then we could use dependencyContext.

A last solution is to manage dependencies files but maybe better to let dotnet api do it for us.

I would opt to compile extensions with the preserve context option, then we don't rely on project json files for precompiled loading. But this produces bigger dlls, e.g 300 kb in place of 30 kb.
Best

So, i re-use different loaders which use related loading methods through the ExtensionLibraryService.

Ambient and dynamic loading done, need to implement precompiled loading.

Need refactoring to share code between loading methods.

Have you tried within Visual Studio ? Like changing a module, compiling from Vs ,then starting the site to ensure the change is taken into account?

I've tried all of this but only through vscode. I'll try it under vstudio.
Right now i write precompiled loading if there are no project files. E.g i have to resolve the module compilation output path without project files. This to see the dll in the module bin folder ...

@sebastienros

By doing this in O2, i begin to better understand what is done in O1.

With precompiled loading (here means no project files, so, anyway we can't compile), i see new scenarios, e.g when a dependent project needs to be compiled. Just seen it's not implemented in O1:
Logger.Information("Extension \"{0}\" will not be loaded as pre-compiled extension because       one or more referenced extension is dynamically compiled", extension.Id);

We could do this and it's naturally done because, normally, the dependent project is compiled before. But here maybe a problem of version ...

If 2 modules use the same package but not the same version, can we load both versions? If so, we still need module probing folders. Maybe i would need to check versions (not only names & dates).

If 2 versions are not allowed, a shared probing folder makes more sense. But in O1, when you delete the dependencies folder, it is re-created, even when published. This can be done because dlls also are in modules bin folders.

Then, not sure we need the shared probing folder we would need to maintain. In O1, seems to be used as a global "dependency context" for all extensions ... Maybe useful if we can say when published don't delete it but not sure.

Hope we don't still rely on some dotnet sdk assemblies, but if so i think we will be able to embed them.

Best.

@sebastienros just for infos

Ambient loading: Ok.

Dynamic loading: Ok for me, i've re-done some tests by updating projects / dependencies, deleting  outputs in binary / probing folders ... So seems ok for a dev environment.

Precompiled loading: I was assuming that a module is precompiled when there are no project files. Then, if precompiled with the preserveContext option, we can use dependencyContext on it.

Drawback: When you dyn compile a module with the preserveContext option, you can't have a dependency on a precompiled module which have no project files.

I think i'll revert back to lighter dlls without using this option. One solution i see is to always have project files. A precompiled module would be the one that doesn't have any source files (*.cs), only its output binaries and still its 2 project json files. Seems to work in my 1st tests on this.
Best.

I am wondering if we should have a requirement on what the output path should be. I had to change them all to point to the correct artifacts folder as they are in a subfolder and were copy-pasted. I will ask the VS Tools team.

@GVX111
Thanks for the feedback. I know vstudio tools use xproj but not tried it yet. But when we dyn compile we use the project model which uses project json files to e.g resolve output paths ..., so i was assuming it would be ok. Did you try with the last update?
Oh maybe because in your context, at runtime, some resolved paths point to artifacts that we can't access. So, next step, see what happens under the vstudio context, i'll try it asap.
@sebastienros
That said i began to add debug console message, cool to know when a dynamic compilation succeeded, was skipped because already compiled ... I'll post a screenhost.
Best

@jtkech u did awesome job. Yes i checked lastest and everything are ok but i think it need optimization because first compilation of dyn exts need much more time than i expected.

Crazy suggestion, do parallel compilation based on project dependencies ;)
@GVX111 please compare the time it takes on the command line, because even there it's very slow. Like 2-3 seconds per project.

@sebastienros
Just tried with vstudio tools, indeed @GVX111 was right about artifacts bin folders. Maybe i have some solutions (see my last comments on gitter), will try it asap.
Best

Just added a stopwatch to see dyn compilation time.

@GVX111 thanks for the suggestion but didn't tried yet to do any optimization. For compile time, maybe we are faster because we start only one process for csc.dll. I think we are slower to see if we need to compile, dotnet use some caching but at the workspace level, need to see again this area.

That said we have to know that, between 2 dyn compilations, we update probing folders, and, especially, we load the extension dependencies assemblies.

@sebastienros just seen your suggestion ;). Maybe doable, so, we have to check not to compile in parallel the same project, or 2 projects that have a shared dependency that need to be compiled and / or copied to a shared probing folder ...

Best.

@sebastienros @jtkech I thought about parallel but it will be difficult because maybe some Extensions will be dependency. Need Ordering extension. I don't know if @jtkech did already if extension referenced to another extension, referenced extension doesn't need again compilation. If it is already done need only order by dependency.

@sebastienros  for me from command line compilation need 3-4 seconds per project. it is very slow. I have ssd and HQ processor I don't think it is laptop requirement problem. It will be much more faster with parallel but first of all need ordering extensions.

@GVX111
We already recursively compile extensions, so, if an extension depends on another project it is compiled before. Note: In the compiler, just changed the way a precompiled project is detected. Now it's when there are no source files but still with project files (needed by the project model api).
Anyway in ApplicationBuilderExtensions the applicationPartManager is populated with AvailableFeatures() which, in ExtensionManager, uses .OrderByDependenciesAndPriorities. So, extension are already loaded / compiled in an order based on dependencies.
So, for parallel compilation, maybe we only need a specific locking system to prevent parallel compilation of the same project / dependency and / or storing the same assembly in the shared probing folder.
Best.

@sebastienros

Parallel compilation done, seems to work (can be easily reverted).

We already recursively compile according to dependencies. So just added a locking system based on the project name which is currently compiled.

A lock is alo used in 2 other places where we could potentially write the same file at the same time.

Under VS, to see compilation messages in the debug console, i use the IIS Express start command.

Best.

@jtkech did you see any perf difference with Parallel Compilation?

Awesome work so far man, left some notes, not sure if any of them are of use?

@Jetski5822
Thanks a lot for all your insights, no time right now, i'll update my PR according to them this night.

did you see any perf difference with Parallel Compilation?

No comparison, it's about 3 or 4 times faster.
Best.

@Jetski5822
Just done your suggested extension and i also use an existing dotnet extension i didn't see: ProjectName(). I think we will be able to find / create other ones, but maybe better to wait ...
So, in the existing folder Orchard.Environment.Extensions/Extensions/ i've created a new file ProjectModelExtensions.cs, this to put extensions related to the dotnet project model classes: LibraryExporter, ProjectContext ... But not sure it's the best place / name.
Best

@Jetski5822

Could this be parallelized? making 'references' as a ConcurrentDictionary

Just thinking about this suggestion. So, i think you mean to parallelize what we do in the foreach (var dependency in dependencies) loop (currently line 145). Notice that in this loop, when a dependency is a resolved library project, this is where we recursively call Compile() (currently line 162).
So, wow, each compilation, already called in parallel, could potentially call other compilations in parallel! Not sure how it could behave with the current locking system, but for sure i want to try it.
Best.

Notes

After my last dotnet restore, many packages support netstandard1.6 but not 1.5 (or lower). So they are not compatible with netcoreapp1.0 which doesn't support netstandard1.6 ...

Right now, for most of the dependencies in project.json files i target 1.0.0-rc2-final. This is not integrated in this PR, it was just to keep working. I'll see how i can get it working with latest bits ...

Last updates

Maybe due to the last packages updates but i've seen the case where we try to load an ambient assembly. I could fix it by using another collection to have a more complete list of ambient libraries.

Began to re-integrate some stuff around resource files generation. At this time, when resources are defined in a given module, resource files are generated and outputed in this module bin folder. Then not sure what i have to do with these files, will see ... If no resource defined, behave as before.

Best.

@Jetski5822
I got a solution that works with Core 1.0. Because i've done all the work on my branch, right now i put it here so you can review it. I don't understand how you could compile with core app 1.0, netstandard 1.6 and latest packages references because of some interfaces / classes / namespaces changes. Note that i've updated all my tools, dotnet core, sdk ... And i've used restore with no cache dotnet restore --no-cache.

See https://docs.asp.net/en/latest/migration/rc2-to-rtm.html about the AuthorizationHandler<TRequirement> change.

See https://github.com/aspnet/Mvc/blob/master/src/Microsoft.AspNetCore.Mvc.Core/Internal/MvcRouteHandler.cs, we can't use anymore new MvcRouteHandler() without any arguments. Now there is only one MvcRouteHandler() per app that you can request as a service. Note: but i've seen that you can have many MvcAttributeRouteHandler but right now not sure what we can do with this.

See https://github.com/aspnet/Mvc/blob/master/src/Microsoft.AspNetCore.Mvc.Core/ApplicationModels/ControllerModel.cs, the ControllerModel doesn't have anymore RouteConstraints, replaced with RouteValues which still means values that must be present.

HtmlString is not in the same namespace ...

So, most of the changes was simple but not sure for few of them, e.g about MvcRouteHandler, maybe here we need a deeper analyze. At least it couldn't work as it was and now it works for me (not tested with multi tenants) and you can review it.
Best.

Okay cool - So I would like to get this in to the main branch..... Whats left?

Last thing.... Update
$koreBuildZip="https://github.com/aspnet/KoreBuild/archive/1.0.0-rc2.zip"
to
$koreBuildZip="https://github.com/aspnet/KoreBuild/archive/1.0.0.zip"

@jtkech Good work!
@Jetski5822

Last thing.... Update
$koreBuildZip="https://github.com/aspnet/KoreBuild/archive/1.0.0-rc2.zip"
to
$koreBuildZip="https://github.com/aspnet/KoreBuild/archive/1.0.0.zip"

and dockerfile update to preview2

@alexbocharov Yup, @jtkech , if you make those changes and are happy that whats in the PR is GTG, knowing we can make changes after.... then lets pull it.

@Jetski5822 I can fix a new PR

@alexbocharov Okay, then we just need to know this is GTG and bam ill hit the button.... wake up @jtkech !!!

@Jetski5822
As said it was 1st to keep it working and regarding some of your good remarks e.g about MvcRouteHandler, indeed we need more investigation ... No time right now but i'll take a look this night.
But as you said we will be able to do some updates afterwards in another PR.
For the build.ps1 update, i remember i've done this at some point to update my tools. I could integrate it in my PR but can't do it immediately. But here also, maybe @alexbocharov can do it in another PR.
So for me it's GTG and it's as you want. For sure i plan some other updates for specific things but i will do other PRs. In fact, i think it's time to test this PR to see if it behaves as expected, there are already so many things on it and we can't yet see all possible scenarios ...
Best.

Okay, merged...


FIX gulp sass compile problem

We just need to have something in %alert, otherwise gulp won't compile the sass.

 Thanks for the PR. Merged.


HADOOP-17037 fix logical error in WordMedian.java

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 31s
trunk passed

+1 :green_heart:
compile
0m 27s
trunk passed

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 31s
trunk passed

+1 :green_heart:
shadedclient
14m 28s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 27s
trunk passed

+0 :ok:
spotbugs
0m 47s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 46s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 26s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

-0 :warning:
checkstyle
0m 16s
hadoop-mapreduce-project/hadoop-mapreduce-examples: The patch generated 12 new + 2 unchanged - 0 fixed = 14 total (was 2)

+1 :green_heart:
mvnsite
0m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 46s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

+1 :green_heart:
findbugs
0m 47s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 41s
hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

56m 14s

Reason
Tests

Failed junit tests
hadoop.examples.TestWordStats

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2011

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ad6170183cef 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0fe49036e55

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/1/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/1/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m 49s
trunk passed

+1 :green_heart:
compile
0m 26s
trunk passed

+1 :green_heart:
checkstyle
0m 21s
trunk passed

+1 :green_heart:
mvnsite
0m 31s
trunk passed

+1 :green_heart:
shadedclient
17m 36s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s
trunk passed

+0 :ok:
spotbugs
0m 49s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 47s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

-0 :warning:
checkstyle
0m 15s
hadoop-mapreduce-project/hadoop-mapreduce-examples: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)

+1 :green_heart:
mvnsite
0m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 12s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

+1 :green_heart:
findbugs
0m 47s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 43s
hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

66m 35s

Reason
Tests

Failed junit tests
hadoop.examples.TestWordStats

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2011

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ff619670a209 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d4e36409d40

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/2/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/2/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/2/testReport/

Max. process+thread count
422 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2011/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m 21s
trunk passed

+1 :green_heart:
compile
0m 28s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 29s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 19s
trunk passed

+1 :green_heart:
mvnsite
0m 27s
trunk passed

+1 :green_heart:
shadedclient
14m 14s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 26s
hadoop-mapreduce-examples in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 25s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
0m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 45s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 23s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 19s
the patch passed

-0 :warning:
checkstyle
0m 14s
hadoop-mapreduce-project/hadoop-mapreduce-examples: The patch generated 2 new + 16 unchanged - 0 fixed = 18 total (was 16)

+1 :green_heart:
mvnsite
0m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 56s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 19s
hadoop-mapreduce-examples in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 39s
hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

59m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2011/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2011

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9d121ab11a3e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2011/3/artifact/out/branch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-examples-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2011/3/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2011/3/artifact/out/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-examples-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2011/3/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2011/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


The navbar of bootstrap v4.0 shifts on opening a dropdown component.

Before opening an issue:

Search for duplicate or closed issues
Validate and lint any HTML to avoid common problems
Prepare a reduced test case for any bugs
Read the contributing guidelines

When asking general "how to" questions:

Please do not open an issue here
Instead, ask for help on StackOverflow, IRC, or Slack

When reporting a bug, include:

Operating system and version (Windows, Mac OS X, Android, iOS, Win10 Mobile)
Browser and version (Chrome, Firefox, Safari, IE, MS Edge, Opera 15+, Android Browser)
Reduced test cases and potential fixes using JS Bin

When suggesting a feature, include:

As much detail as possible for what we should add and why it's important to Bootstrap
Relevant links to prior art, screenshots, or live demos whenever possible

Hi @himanshukhosla123 I can't duplicate it, can you send more info please?

Hi @andresgalante  I couldn't figure out the problem in that dropdown , but whenever the dropdown-menu is visible/open , the navbar shifts by some space and when i closes the dropdown-menu its gets aligned back to the top . please try it on website to detect the bug as it is a huge version launch of bootstrap 4.x

I am trying it here https://getbootstrap.com/docs/4.0/components/dropdowns/ and I can't duplicate it.
What browser/OS ?

yes , when you mentioned what browser , then i tried it on my computer browser's , it works fine on firefox, edge , but it has an issue with google chrome -- 56.0.2924.87

Please provide your nav code
I've seen this if drop down-menu is not nested within the drop down. For example the dropdown-toggle isn't within the dropdown (such as it being outside the div for the drop down)
Not 100% based on your example where you're seeing the problem but basically make sure your toggle or dropdown itself is within the dropdown div.  if it's outside, it does cause that behaviour.
So it should be
(Nav)
(Navbar toggler)
(Navbar collapse)
And for drop downs for second level menu (as a part of nav), note the dropdown menu is within the dropdown div. a common mistake is to put it beside it which will cause that to happen.

                                    Main category

                                        Overview
                                        Second
                                        Third

This looks like the Chrome box-shadow problem with position: sticky on non-retina monitors. Nothing we can do here—I spent far too much time hacking solutions at GitHub for the same problem on our PRs. Closing out.


typo: begining -> beginning

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

project-rome-docs/msgraph-notifications/receiving-notifications/ios/api-reference/usernotifications/MCDUserNotificationReaderStartPosition.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add the the ability to set up and use load-out checklists.

I'm sure everyone here is familiar with the situation of forgetting something you usually take to a farming run, while killing wyverns, or doing some other task. Or having to think hard of what to take for your next farming trip.
What I propose is a load-out checklist that shows you what you're missing from previously saved load-outs.
For example, I want to create and use a load-out named "Wyvern Killing":

I'd equip or take the required items for my load-out.
RuneLite would let me "Save" the list of items I have equipped or in my inventory into a load-out I could name myself. In this case it would be "Wyvern Killing".
When I decide to use the load-out, all I'd have to do is left-click on the name of the load-out, and it would show a list of what I have and what I'm missing. Much like it does with clue scrolls. But I think it would be more convenient to put a large list like this in the sidebar of the client.

BONUS if it's possible to filter the bank to only show items in the load-out.

https://github.com/runelite/runelite/wiki/Bank-Tags


CB-9472 make authz mock tests runnable from one testsuite

See detailed description in the commit message.

Could we should redirect this to master, on 2.32 we can live with the 2 separate suits?

Commit message should be extended with a detailed description of what problem is solved with this commit

Could we should redirect this to master, on 2.32 we can live with the 2 separate suits?

yes

Commit message should be extended with a detailed description of what problem is solved with this commit

this is still a draft, but of course, i'll extend it

http://ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-real-ums-test/1603

http://ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-real-ums-test/1630/

http://ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-real-ums-test/1636/


Vulkan driver: vkQueueSubmit() serializer passes the same  over and over again without resetting it

vkResetFences() calls are not passed down to the driver, instead being replaced with wait-idle calls. This works most of the time, but I think there's at least one case that's been missed.
Consider an app which re-uses the same fence for vkQueueSubmit() calls. Before the second submission, it calls vkResetFences() to reset the fence. This invocation is removed by RenderDoc serializer. However, the same fence handle is later passed to vkQueueSubmit() call, which is against the following spec language:
Valid usage:

(..)

* fence must be unsignalled

Simple fix should work I think - just need to actually replay the vkResetFences(). It's not used for explicit waiting or anything but it's still passed into vkQueueSubmit.

Works for me! Thanks, Baldur :)


Getting "Undefined property: Laravel\Scout\Builder::$offset"

Getting "Undefined property: Laravel\\Scout\\Builder::$offset"
on line 73 in damiantw/laravel-scout-mysql-driver/src/Engines/MySQLEngine.php which reads:
if($this->builder->offset) {
This happens when i do: Child::search($q)->get();
Using PHP 7.0.8 in homestead

Thanks!


updated dependencies

i updated almost all the dependencies except for 3 i think. also the new dependencies generated problems with the public images. i also fixed those bugs transforming the images from static to dynamic.
This is a pull request!
Please use the following format for the title:
 _ < sprint 12 > _ < #559  > _
all this dependencies were updated:

Package              Current               Wanted        Latest       Location                    Depended by
@emotion/cache 11.11.0 11.13.1 11.13.1 node_modules/@emotion/cache nsc-events-nextjs
@emotion/react 11.11.3 11.13.3 11.13.3 node_modules/@emotion/react nsc-events-nextjs
@emotion/styled 11.11.0 11.13.0 11.13.0 node_modules/@emotion/styled nsc-events-nextjs
@mui/icons-material 5.15.5 5.15.5 6.1.2 node_modules/@mui/icons-material nsc-events-nextjs
@mui/lab 5.0.0-alpha.165 5.0.0-alpha.173 6.0.0-beta.10 node_modules/@mui/lab nsc-events-nextjs
@mui/material 5.15.19 5.16.7 6.1.2 node_modules/@mui/material nsc-events-nextjs
@mui/material-nextjs 5.15.9 5.16.6 6.1.2 node_modules/@mui/material-nextjs nsc-events-nextjs
@mui/utils 5.15.14 5.16.6 6.1.2 node_modules/@mui/utils nsc-events-nextjs
@mui/x-date-pickers 6.19.4 6.20.2 7.18.0 node_modules/@mui/x-date-pickers nsc-events-nextjs
@tanstack/react-query 5.17.15 5.17.15 5.59.0 node_modules/@tanstack/react-query nsc-events-nextjs
@testing-library/jest-dom 6.4.2 6.5.0 6.5.0 node_modules/@testing-library/jest-dom nsc-events-nextjs
@testing-library/react 15.0.2 15.0.7 16.0.1 node_modules/@testing-library/react nsc-events-nextjs
@types/bcrypt 5.0.0 5.0.2 5.0.2 node_modules/@types/bcrypt nsc-events-nextjs
@types/jest 29.5.3 29.5.3 29.5.13 node_modules/@types/jest nsc-events-nextjs
@types/node 20.3.1 20.3.1 22.7.4 node_modules/@types/node nsc-events-nextjs
@types/react 18.2.13 18.2.13 18.3.11 node_modules/@types/react nsc-events-nextjs
@types/react-datepicker 4.19.5 4.19.6 7.0.0 node_modules/@types/react-datepicker nsc-events-nextjs
@types/react-dom 18.2.6 18.2.6 18.3.0 node_modules/@types/react-dom nsc-events-nextjs
autoprefixer 10.4.14 10.4.14 10.4.20 node_modules/autoprefixer nsc-events-nextjs
bcrypt 5.1.0 5.1.1 5.1.1 node_modules/bcrypt nsc-events-nextjs
date-fns 2.25.0 2.30.0 4.1.0 node_modules/date-fns nsc-events-nextjs
eslint 8.43.0 8.43.0 9.11.1 node_modules/eslint nsc-events-nextjs
eslint-config-next 13.4.7 13.4.7 14.2.14 node_modules/eslint-config-next nsc-events-nextjs
eslint-plugin-testing-library 6.2.2 6.3.0 6.3.0 node_modules/eslint-plugin-testing-library nsc-events-nextjs
jest 29.6.1 29.7.0 29.7.0 node_modules/jest nsc-events-nextjs
mongoose 7.4.2 7.8.2 8.7.0 node_modules/mongoose nsc-events-nextjs
next 13.4.7 13.4.7 14.2.14 node_modules/next nsc-events-nextjs
next-auth 4.24.7 4.24.8 4.24.8 node_modules/next-auth nsc-events-nextjs
postcss 8.4.24 8.4.24 8.4.47 node_modules/postcss nsc-events-nextjs
react 18.2.0 18.2.0 18.3.1 node_modules/react nsc-events-nextjs
react-dom 18.2.0 18.2.0 18.3.1 node_modules/react-dom nsc-events-nextjs
react-icons 5.2.1 5.3.0 5.3.0 node_modules/react-icons nsc-events-nextjs
tailwindcss 3.3.2 3.3.2 3.4.13 node_modules/tailwindcss nsc-events-nextjs
ts-jest 29.1.0 29.1.0 29.2.5 node_modules/ts-jest nsc-events-nextjs
typescript 5.1.3 5.1.3 5.6.2 node_modules/typescript nsc-events-nextjs

the new update created problems with the public/image. that was also resolve in this pull request.

seems like many people had the same problem when some dependencies are updated. this is the problem the we have so far:
10s
Run npm run compile

<EMAIL_ADDRESS>compile
tsc

Error: components/Navbar.tsx(69,12): error TS2769: No overload matches this call.
Overload 1 of 2, '(props: { component: ElementType<any, keyof IntrinsicElements>; } & ListItemOwnProps & CommonProps & Omit<any, "components" | ... 15 more ... | "secondaryAction">): Element | null', gave the following error.
Property 'component' is missing in type '{ children: Element; button: true; }' but required in type '{ component: ElementType<any, keyof IntrinsicElements>; }'.
Overload 2 of 2, '(props: DefaultComponentProps<ListItemTypeMap<{}, "li">>): Element | null', gave the following error.
Type '{ children: Element; button: true; }' is not assignable to type 'IntrinsicAttributes & ListItemOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<LiHTMLAttributes, HTMLLIElement>, "ref"> & { ...; }, "components" | ... 15 more ... | "secondaryAction">'.
Property 'button' does not exist on type 'IntrinsicAttributes & ListItemOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<LiHTMLAttributes, HTMLLIElement>, "ref"> & { ...; }, "components" | ... 15 more ... | "secondaryAction">'.
Error: Process completed with exit code 2.
if anyone have any suggestion on how to fix this, would be very helpful.

seems like many people had the same problem when some dependencies are updated. this is the problem that we have so far:
10s Run npm run compile

<EMAIL_ADDRESS>compile
tsc

Error: components/Navbar.tsx(69,12): error TS2769: No overload matches this call. Overload 1 of 2, '(props: { component: ElementType<any, keyof IntrinsicElements>; } & ListItemOwnProps & CommonProps & Omit<any, "components" | ... 15 more ... | "secondaryAction">): Element | null', gave the following error. Property 'component' is missing in type '{ children: Element; button: true; }' but required in type '{ component: ElementType<any, keyof IntrinsicElements>; }'. Overload 2 of 2, '(props: DefaultComponentProps<ListItemTypeMap<{}, "li">>): Element | null', gave the following error. Type '{ children: Element; button: true; }' is not assignable to type 'IntrinsicAttributes & ListItemOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<LiHTMLAttributes, HTMLLIElement>, "ref"> & { ...; }, "components" | ... 15 more ... | "secondaryAction">'. Property 'button' does not exist on type 'IntrinsicAttributes & ListItemOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<LiHTMLAttributes, HTMLLIElement>, "ref"> & { ...; }, "components" | ... 15 more ... | "secondaryAction">'. Error: Process completed with exit code 2.
if anyone have any suggestion on how to fix this, would be very helpful.

Hey there! So these updates need to be done in conjunction with the people doing the research on CI/CD. The CI needs to also be updated at the same time. We will reach out to go over the desired outcome!

Great work on tackling this large set of dependency updates, including key packages like @emotion, @mui, next, and react. Keeping dependencies up to date is essential for maintaining security and compatibility, and it’s great to see that you resolved the issues with image handling that arose due to the updates. Transforming static images to dynamic was a smart approach to ensure the site continues to function smoothly with the new versions of these packages.
While reviewing the changes, I noticed an issue in the Navbar.tsx component where TypeScript is throwing errors related to prop handling in the ListItem component. It looks like the component={link} prop needs to be added, and the button prop might not be compatible here. This mismatch is likely due to the changes in the updated @mui package, which handles component props differently in newer versions.
For anyone looking to dive deeper into managing dependencies effectively, I recommend this useful guide on managing npm dependencies, which covers best practices for handling large updates like this.  Once the TypeScript issue is resolved, this PR should be ready to merge. Thanks for the updates!

I spent a few hours going over your code. Locally there are not issues, as the application ran and I got to log in and create events. After messing with some typescript types and reading into mateial ui's new update with props. I was able to get it past the compile locally.
Compiled:

Some changes I did locally:

But, it seems to be failing at the building now. I spent sometime searching online for the webpack error. It looks like a module is missing. I wonder if one these versions doesn't have the module it's looking for.
Failing at build:

We might have to look deeper into that module and see what version works best.

seems like many people had the same problem when some dependencies are updated. this is the problem that we have so far:
10s Run npm run compile

<EMAIL_ADDRESS>compile
tsc

Error: components/Navbar.tsx(69,12): error TS2769: No overload matches this call.
  Overload 1 of 2, '(props: { component: ElementType<any, keyof IntrinsicElements>; } & ListItemOwnProps & CommonProps & Omit<any, "components" | ... 15 more ... | "secondaryAction">): Element | null', gave the following error.
    Property 'component' is missing in type '{ children: Element; button: true; }' but required in type '{ component: ElementType<any, keyof IntrinsicElements>; }'.
  Overload 2 of 2, '(props: DefaultComponentProps<ListItemTypeMap<{}, "li">>): Element | null', gave the following error.
    Type '{ children: Element; button: true; }' is not assignable to type 'IntrinsicAttributes & ListItemOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<LiHTMLAttributes<HTMLLIElement>, HTMLLIElement>, "ref"> & { ...; }, "components" | ... 15 more ... | "secondaryAction">'.
      Property 'button' does not exist on type 'IntrinsicAttributes & ListItemOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<LiHTMLAttributes<HTMLLIElement>, HTMLLIElement>, "ref"> & { ...; }, "components" | ... 15 more ... | "secondaryAction">'.
Error: Process completed with exit code 2.

if anyone have any suggestion on how to fix this, would be very helpful.

A few things we need to take a look at regarding Material-UI:

<ListItem button> on Line 73 needs to be refactored as mentioned by @Bejarano03.

 is now depreciated but after doing some research we can switch it to  with some minor tweaks.

Found a thread that might be worth referencing https://github.com/mui/mui-x/issues/11454 for the date-fns/date-picker compatibility.

With the update I pushed, I believe all we really need is testing wherever x-date-pickers is beings used (one of the culprits for the failed CI) as well as the small navbar refactor as a result of a depreciated dependency feature.


运行报错

File "bot.py", line 4, in
from telebot import types
File "/usr/local/lib/python3.7/dist-packages/telebot/types.py", line 10, in
from telebot import util
File "/usr/local/lib/python3.7/dist-packages/telebot/util.py", line 141
def async():
^
SyntaxError: invalid syntax

pip3 install PyTelegramBotAPI==3.6.6 后好使了


MudPopover: Allow overriding properties and add scroll events

Description

Allow MudSelect and MudAutocomplete to pass Fixed and OverflowBehavior to the contained popover. Defaults are the same as before, just now it can be overridden if need be.
Additionally, add scroll events on connect for parents with scrollable containers
Resolves #8656
Resolves #10325
Resolves doc page where there is a floating component containing a popover by setting the AutoComplete to Fixed="true"
How Has This Been Tested?

Visual Tests
Type of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

My gif creator did not work well this time but see below
Problem

Fix

Example for 8656, There's another one I fixed but I lost the # while working.

What about merging these into a single parameter public DropDownBehavior DropdownBehavior { get; set; } with

public struct DropdownBehavior {
  public bool Fixed { get; set; }
  public OverflowBehavior OverflowBehavior { get; set; } = OverflowBehavior.FlipOnOpen;
}

Alternative names DropdownSettings, PopoverBehavior or PopoverSettings.
I think for this very specialized configuration preparing the settings object in@code and passing it is no big deal.
In addition to that the parameters intended for the popover are now intuitively named which is not the case when they are directly exposed in MudAutocomplete on their own. I when first seeing this I wasn't sure what <MudAutocomplete Fixed="true"> would mean.

I think for MudSelect there is potential for a future breaking change (i.e. v9) to move these placement properties into the new parameter as well.

Maybe then we can expand this example with the new options as well

Please name it DropDownSettings so we are not limited to behavioral settings.

Sorry for being a PITA, just think DropdownSettings would be best (no capitalization of Down)

Sorry for being a PITA, just think DropdownSettings would be best (no capitalization of Down)

Well I'll be a monkey's uncle! Give me 5.

and maybe 5 more, have to write unit tests

Let me know if you want any additional changes, I hear PopoverSettings is hot right now :)

LGTM, thanks for your patience ;). @ScarletKuro you may merge this if you agree with the changes.

The original problem that I initially reported on discord is fixed, but I see that in Edge if you open a very high inspector, this part is sticking out:

Is it something that is possible to fix? Should we just merge this problem for other PR?

LGTM, thanks for your patience ;). @ScarletKuro you may merge this if you agree with the changes.

The original problem that I initially reported on discord is fixed, but I see that in Edge if you open a very high inspector, this part is sticking out:  Is it something that is possible to fix? Should we just merge this PR and leave this problem for other PR?

I'm sure it is, probably related to appbar.razor which I had to change for the new properties so I don't see a problem with adding it to this PR. give me a few to confirm and I'll submit if I'm correct.

Actually no, it all appears to be working by design. I can only see the overlap if I zoom to 200% and browser zoom can be odd anyways. I can replicate on chrome if I zoom high enough (500%), Same with firefox (220%). Unless there is some other way to replicate.

Actually no, it all appears to be working by design. I can only see the overlap if I zoom to 200% and browser zoom can be odd anyways. I can replicate on chrome if I zoom high enough (500%), Same with firefox (220%). Unless there is some other way to replicate.

Hmm weird, I don't need to zoom anything. I have 2k monitor and all I have to do is to open inspector on like half of the screen size for it to stick out.
@danielchalmers should we bother about it?

@ScarletKuro it's an old issue #8657

@ScarletKuro it's an old issue #8657

Ok, lets merge then.


Trivially fetch student’s code from Code Vault into a new module

Not trivial: Copy onto skeleton module? Is this viable in practice?

Too much uncertainty when it comes to the contents of the file (multiple files in one, comments, etc.). One possibility is if the plugin makes the CodeVault submission, then the format is known to the plugin.

It seems unnecessarily difficult to merge arbitrary code vault submissions with the base code.

One possibility is if the plugin makes the CodeVault submission, then the format is known to the plugin.

This could be the way to go. Or, at least, it could work as long as code vault submission only had complete files.


Suggestion: Add the possibility to add any executable to be tracked as path sources

Hi,
I really like this tool. Came from your YT channel!
I am mainly using Double Commander (Version 1.1.20 gamma upwards) instead of Windows Explorer, because I like the old Norton Commander way of working with files.
Do you see a flexible way of adding it? Like for example, finding the target of the path panes and stuff to add it manually?
Thanks and best regards,
Kyo

I'm not sure if there's a way to make it universal, but I might be able to at least update the script to be more modular so it would be easier to add integrations for different sources to the part of the code that gathers the paths. Each file manager would have its own different way to get all the paths though I think.


GPA Calculator

Fixes Issue🛠

Closes #27
Description👨💻
Added GPA calculator.

Type of change📄

[] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

How this has been tested✅
Tested with dummy data.

Checklist✅

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have added demonstration in the form of GIF/video file
[X] I am an Open Source Contributor

Screenshots/GIF📷

Looks good, Merged!! Congrats on getting your PR merged to this repo under SWOC S4 🎉🎉 @kom-senapati


Add metrics endpoint

I'd like to scrape metrics about the internal runner-manager state. Specifically have it expose how many runners it's tracking in each of its runner groups.
This is useful because we've sometimes observed that AWS EC2 instances may get 'orphaned' meaning the runner-manager service has lost track of it and forgets to delete it. Monitoring these metrics would allow us to detect these 'orphaned' instances by alerting on when the number of EC2 machines != the tracked number of runners.
I propose using Prometheus instrumentation via the prometheus-client library. This will introduce a /metrics endpoint that is used for machine readable metrics.
Are there any objections to this approach?

No objections, it would be a very much welcome contribution.
Quick note about the orphan situation, we recently noticed that in our kubernetes manifests we made a mistake on the redis volume path which in result would not persist our data and create orphans every time redis would reboot. (if that's the method of deployment you are using, worth double checking).

I tried an implementation in #628 but I don't think that's the right approach. To get prometheus metrics, I'm now looking at something like dumping the Redis data as JSON using get_runners() upon request to /groups/{name}/list.
Then writing a custom prometheus exporter to consume that JSON and parse it into prometheus metrics.


Avoid GDScriptCache deadlocking the main thread

Fixes #53550
This issue is caused when the main thread is tries to load a GDScript file, but another thread is already inside GDScriptCache::get_full_script and is requiring use of the main thread (e.g. trying to preload materials before render server is started).
The GDScriptCache singleton should not be locked while executing script->reload(). It is not being modified at that point.

Superseded by #71797.


Make auto-detecting permitted next nodes the default behaviour

In #2368 & #2370, all occurrences of next_node with a block were converted to use the automatic detection of permitted next nodes instead of explicitly supplying them. So we can now make the code less verbose by making permitted: :auto the default arguments for next_node with a block.
Note that the old mechanism is still available, it's just no longer the default behaviour.
I've updated the documentation to reflect this change, noting that the old approach is now deprecated.
Expected changes
This is just a refactoring - there should be no changes in externally observable behaviour.

I'm going to rebase this against master to resolve the conflicts that have been introduced by recent changes in master and then force-push it.

Rebasing & force-pushing done. Conflicts resolved. Ready for review again.

Even though this code doesn't change the outward appearance of any page, it might be useful to add a before and after of what a next_node block looked(will look) like with this change.

I've edited the PR description to explain the internal changes to the flow DSL.

@erikse: Thanks for reviewing. I've addressed your comments. Are you happy for me to merge this?

Yep, this looks really good

Thanks. I'll get it rebased, force-pushed & merged.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.7 to before v5.14.15",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=63b2d4174c4ad1f40b48d7138e71bcb564c1fe03",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=149958ecd0627a9f1e9c678c25c665400054cd6a"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "63b2d4174c4ad1f40b48d7138e71bcb564c1fe03",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "149958ecd0627a9f1e9c678c25c665400054cd6a",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "userfaultfd: fix a race between writeprotect and exit_mmap()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.14.15 by commit 149958ecd0627a9f1e9c678c25c665400054cd6a, it was introduced in version v5.7 by commit 63b2d4174c4ad1f40b48d7138e71bcb564c1fe03. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002102


Migrate mwix collector (FD-IX) to a new VM

Received an email on March 3rd (to Teach) indicating we are expected to have been migrated to a new VM by then.

Well, this fell off my radar 6 mo. ago -- Email thread: "RE: FD-IX route views" is still waiting for response!


Fix livesearch in discopower

This PR contains the following changes:

Replace data['header'] with data['htmlinject']['htmlContentPost'] to load javascript scripts to templates
Fix undefined index error for idps_in_searchable_list_index
Add paths for jQuery
Add login_with key in discopower definitions
Move ribbon_text to config file

@olgabrani Could you please review this PR?

 Update vanilla theme for SSP v1.17+

LGTM


New consumer

Note: I should add better documentation.
This PR introduces a new type of consumer that is safer than the previous one.
Major improvements with the new consumer:

Every service has a dedicated dead queue. Messages are never lost, even after reaching the message retry limit.
Every service has a dedicated exchange that is connected to a remote exchange. Failures in one service can no longer affect other services attached to the same exchange.

A helpful diagram of the new consumer workflow:

Deprecation of the old consumer
The old consumer, Tackle.subscribe method, is deprecated in favour of Tackle.consume. The new Tackle.consume is a superset over the old mechanisms, but the rabbit_mq connections are set up differently.
Tackle.subscribe will be removed in version 1.0.
Note: I found it easier to write only integration tests, and skip unit tests. This is probably not the best practice.

Looks great to me 👏


Add a License

Could you add a license to your repository? I think your code is great and would like to use it as part of a project of my own. I want to make sure you are properly credited for the work.

I have know a little about licence and how to choose right one, can you help me?

Sure thing, although I am still learning a lot myself.
In general, your code is only viewable under the Github terms of service. Just putting the code out there does not make it truly open source. You need to add a license that will define the legal permissions to use/modify/distribute (or not) the code by others. To add a license to the repository, you simple create a file called LICENSE and copy in the full license you decide to use. Additionally, you can place an abbreviated version or reference to the license at the top of each source document, though depending on the project this may be overkill.
As for what license to choose, you have a lot of options. You can check out ChooseALicense for a great guide. I will talk about the two I have seen and used:
The most permissive is the MIT License which basically allows anyone to do anything so long as the original license is attached. It is also very simple so it is a good place to start.
The most common that I have seen is the GNU General Public License of which there are a couple versions. This is noticeably more complex so I will not try to explain it here. It does apply more restrictive conditions for using the code but that shouldn't be an issue in this case. Either one would work easily on this project.

Just added MIT :)


[Sandbox] heimdall

Application contact emails
<EMAIL_ADDRESS>Project Summary
Cloud-native authentication & authorization proxy
Project Description
The project helps orchestrating available authentication and authorization systems to streamline corresponding security requirements, providing secure defaults and simplifying the code base of the actual upstream services. It can be used to implement edge level authentication / access control architectures as well as a side car of the service it should protect.
Org repo URL (provide if all repos under the org are in scope of the application)
https://github.com/dadrus/heimdall
Project repo URL in scope of application
https://github.com/dadrus/heimdall
Additional repos in scope of the application
None
Website URL
https://dadrus.github.io/heimdall
Roadmap
https://github.com/dadrus/heimdall/milestones
Roadmap context
The priority is given by the requests from the community as well as by the requirements I see in the projects I'm involved into.
Contributing Guide
https://github.com/dadrus/heimdall/blob/main/CONTRIBUTING.md
Code of Conduct (CoC)
https://github.com/dadrus/heimdall/blob/main/CODE_OF_CONDUCT.md
Adopters
There are multiple organizations in Germany, Canada, Sweden and some other countries which use heimdall in production. However, I don't have any related links yet.
https://github.com/dadrus/heimdall/blob/main/ADOPTERS.md
Contributing or Sponsoring Org
No response
Maintainers file
Actually, that more or less only me
https://github.com/dadrus/heimdall/blob/main/MAINTAINERS.md
IP Policy

[X] If the project is accepted, I agree the project will follow the CNCF IP Policy

Trademark and accounts

[X] If the project is accepted, I agree to donate all project trademarks and accounts to the CNCF

Why CNCF?
In my opinion the project addresses a field, which is not yet covered. I think it is very helpful, can significantly contribute to the security of services using it and make addressing at least the field of authentication and authorization a bit simpler. Though, it is not reducing complexity in this regard, but making it better manageable. Contributing the project to CNCF could create a much stronger community around it, make it better and help much more projects solving corresponding challenges. At least this is my hope.
Benefit to the Landscape
There are no comparable projects in the CNCF landscape.
Cloud Native 'Fit'
Heimdall does not only implement a set of kube-native controllers and APIs for validation and management of corresponding rules (CRs), it goes beyond k8s as also described in the Cloud Native Integration section below. Therefore, I feel it fits the Cloud Native landscape pretty well.
Cloud Native 'Integration'
This project complements any authorization and authentication projects, like e.g  OPA and OpenFGA as well as any proxy supporting forward/external auth integration and converts those to a manageable API gateway, like e.g. Envoy Proxy, Contour, HAProxy and many more. But there are much more options. There are no dependencies to other projects.
You can find guided examples under https://dadrus.github.io/heimdall/v0.14.0-alpha/docs/getting_started/protect_an_app/ and https://dadrus.github.io/heimdall/v0.14.0-alpha/guides/authz/openfga/, as well as examples as code under https://github.com/dadrus/heimdall/tree/main/examples
Cloud Native Overlap
There are no overlaps.
Similar projects
N/A
Landscape
No
Business Product or Service to Project separation
There are many projects named heimdall out there and even companies. Currently, me and actually also the small community around the project are looking for another name, which would also reflect what the project does.
Project presentations
Not yet. I was working to update the available documentation first to make it more comprehensive. You can find the results by choosing the dev version from the drop down menu.
Indeed, I recommend taking the look at that version, which is going to be release within the next few weeks: https://dadrus.github.io/heimdall/dev/, with
https://dadrus.github.io/heimdall/dev/docs/getting_started/discover_heimdall/ being the entry point to the actual documentation of the upcoming version. It is much better structured and will give a very good overview about what the project addresses as well as the related concepts.
In the meantime the new version is released. If you just follow the Website URL (https://dadrus.github.io/heimdall), you'll be redirected to the new documentation.
Project champions
No response
Additional information
There is Ory Oathkeeper and also Authorino from RedHat (under the umbrella of the Kuadrant project) which are addressing the similar challenges.

@dadrus you mention overlap with Kaudrant sub-projects - have you considered speaking with the Kaudrant maintainers about merging Heimdall with Kaudrant?

Already did that without however receiving a feedback.

Hi @guicassolato. Sure. Will be glad to join and do the short presentation. 😀

That's awesome, @dadrus! Adding you to the agenda. Thank you so much!

not being limited to kubernetes deployments only and by supporting defaults, which are neither possible with Authorino

Forgot to reply on this. Indeed Authorino is for Kube only. If it runs outside of Kubernetes (not really a use case), it still expects to be connected to a cluster where to read its configs from.
As for defaults, there’s actually support in Authorino, including with fallback at multiple levels (based on the hostname wildcards.)
But I believe feature-wise the main difference with Heimdall is proxy mode, which Authorino does not offer.
Authorino integrates with several (if not all!) API gateways and L7 reverse proxies, just like Heimdall. It was thought for Envoy and gRPC, but has a second interface for more generic integrations. Also like Heimdall, Authorino can act as Validating Webhook service, with auto detection of AdmissionReview requests.

@dadrus I know this is short notice, but, TAG Network are working on the Heimdal project review to support your Sandbox application. I don't think you have presented to TAG Network yet. We do not want to delay your application, as we do fully support it but, I was wondering if you had time to demo Heimdal at the TAG Network meeting at 9PST on Thursday. I appreciate this is late notice and it does not affect your application but we have an opening and would love to chat with you if you had the time. If not we would love to have you present at a later date.

Hi @nicholasjackson. Thank you for reaching out to me. Indeed, I have never attended any of the TAG Network meetings yet, but would love to do a presentation.
Could you please share the meeting details with me?

Hey, apologies but I can’t directly link to the meeting on Thursday in the CNCF calendar, but our next meeting is
Thu Aug 8th 5:00pm - 5:55pm (BST). I appreciate this is short notice for this week, we meet every other Thursday the next meeting being the 22nd.
https://zoom.us/my/cncftagnetwork?pwd=RmpmZ3NFN09JUzFSOUI5bUh5TXVFUT09
https://www.cncf.io/calendar/
I am @nicj on the CNCF slack if you would prefer to ping me there.

TAG Contributor strategy has reviewed this project and found the following:

The contributor guide is simple, but pretty good for a one-person project
There is no written governance yet.  There is a security policy, although it needs work.
The roadmap is milestone-tagged issues, a practice which started for the current release.
There is one maintainer, the founder and submitter of the project.

This review is for the TOC’s information only.  Sandbox projects are not required to have full governance or contributor documentation.

I’d like to clarify/comment the third bullet point from the previous comment.
This practice has actually been in place from the beginning of the project. However, for the most recent release, I updated the CI workflows responsible for dependency management and release automation. These updates now allow for patch releases, incorporating updated dependencies and bug fixes, to be conducted concurrently with regular releases (you can see that based on the two pending release PRs under https://github.com/dadrus/heimdall/pulls).
This approach benefits users by providing them with updates and fixes without having to wait for the next planned (milestone-tagged) release. Additionally, it eliminates the need to shorten the scope of planned releases or expedite their creation to address urgent bug fixes or security updates.

@dadrus
Thank you so much for your application to the CNCF, at this time the TOC will not be moving the application to a vote.
We would like to see this project with more maturity, at least one additional maintainer, and increased interest and activity by the ecosystem. We have the following recommendations that may benefit the project:

socialization and awareness of this project with the OpenSSF: https://github.com/ossf
presentation and discussion of the project at TAG Security Note: Several TAG Security community members are also in OpenSSF, they may be able to direct you to the best aligned SIG in OpenSSF.

Hi CNCF TOC Team,
Thank you very much for taking the time to review my application. While I’m disappointed that the application won’t be moving forward to a vote at this time, I understand the importance of ensuring that the project is mature, well-maintained, and actively supported by the community and really appreciate the feedback and recommendations you’ve provided.
I’ll work on maturing the project and also connect with OpenSSF and TAG Security and potentially even with the TAG App groups as recommended.
Thanks again for your guidance—I’m committed to making the project stronger and more aligned with the community.
Cheers.


T265 crashes when used with D435 (Raspberry Pi, Ubuntu, Python)

Hi,
I am (trying to) use a the T265 and a D435 for a wheeled robotic project.
The code is written in Python (ver 2.7.15+) running on a Raspberry Pi 3+.
When i run the cameras using Real Sense Viewer al lis good.
When i run the code with one camera it works as expected.
But when i try to initialize both cameras at the same time the T265 crashes after a few seconds with this error message:
14:49:14.805 [1708] [E] Device-91A0: FW crashed - got error in interrupt endpoint thread function: status = -1 (LIBUSB_ERROR_IO), actual = 0
14:49:15.012 [1697] [E] Device-91A0: State [ACTIVE_STATE] got event [ON_ERROR] ==> [ERROR_STATE]
14:49:15.013 [1697] [E] Device-91A0: Entered state [ERROR_STATE]
Traceback (most recent call last):
File "camtest.py", line 30, in
frames = pipeline_1.wait_for_frames()
RuntimeError: Frame didn't arrived within 5000
If i comment out the code related to one of the cameras the code works just fine, but with both cameras enabled the T265 code crash.
This is the code i run:
-- Code --
import pyrealsense2 as rs
pipeline_1 = rs.pipeline()
config_1 = rs.config()
#config_1.enable_device('909212110600') #T265
config_1.enable_stream(rs.stream.pose)
pipeline_1.start(config_1)
pipeline_2 = rs.pipeline()
config_2 = rs.config()
config_2.enable_device('831612070347') #D435
config_2.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 30)
pipeline_2.start(config_2)
print('started')
while True:
frames = pipeline_1.wait_for_frames()
pose = frames.get_pose_frame()
if pose:
data = pose.get_pose_data()
pos = {'x': data.translation.x, 'y': data.translation.y, 'z': data.translation.z,'xr': data.rotation.x, 'yr':     data.rotation.y, 'zr': data.rotation.z, 'wr': data.rotation.w}
print(pos['x'])
frames2 = pipeline_2.wait_for_frames()
depth = frames2.get_depth_frame()
if depth:
dist = depth.get_distance(100, 250)
print('distance: ',dist)
-- End code --
Any help appreciated!

This question has been given a reply on the Intel Support forum's copy of it.   Thanks!
https://support.intelrealsense.com/hc/en-us/community/posts/360038053533/comments/360009991093

@Leijoma, this is working for me since #5213 was merged.  This should work when v2.32.0 is released.

@radfordi I have the opposite experience. See my comment here: https://github.com/IntelRealSense/librealsense/issues/3434#issuecomment-583477888. It is working with 2.31 and not working with 2.32. See also  #5614.

Hi,
I played now several days with the T265+ D435i + Raspberry Pi 4b + Raspbian buster arround. I tried several versions of librealsense (2.32.1, 2.31, 2.29) and all have issues.
The latest (2.32.1) is the "most stable" for me but the problem is that after a (right now it looks to me random) point in time the T265 does not deliver data anymore (poll_for_frame never returns anything after a certain while). Also tried to connect the sensor using a powered USB hub but this does not solve the problem.
My feeling is that when I start it for the first time after boot or a longer period of not using the PI it provides data for a longer time (several minutes). When it crashes and i restart it, then it stops working after a few seconds to 1 minute.
So could overheating be problem? I do not have active cooling with the PI?

Overheating on a USB device can be caused by a fault on a USB port or a bad USB cable.  It happens fast enough that the heat should manifest within the first few minutes of using a device.  Is the RealSense device's casing hot to the touch if you touch it within a few minutes of it starting, please?

I know put the T265 (only the T265 without the D435i) on usb and put the raspberry pi in front of a big fan. I seems that it works "longer" -> 10 minutes.
Without the cooling the PI gets definitly warm. CPU temp is shown close to 70 degrees. with the big fan in front of CPU temperature drops to 40 degrees.
Another hypothesis i stated now is that the T265 is standing still during the "long-term" test. And therefore it stops working. Right now it is moved together with fan :-) Lets see if this helps :D

Hmm.. no luck yet. So its running between 2 to 5 minutes. then it stops. Any other ideas?

I am not a programming specialist.  I wonder if there is a "memory leak" going on in the script though.  A memory leak is where a program continually consumes a computer's memory capacity as it runs instead of releasing memory when it has finished a task.  This can lead to a crash of the program.  If the memory stays consumed after the crash then the program might crash sooner on subsequent runs because there is even less memory available on the computer than the first time the program was run
https://stackoverflow.com/questions/2975831/is-leaked-memory-freed-up-when-the-program-exits.

Hey, thanks for this idea. But I supervised the memory consumption stays constant over time. so this is not the problem.
Maybe I should focus on another type of compute unit. Maybe something like this: https://www.intel.de/content/www/de/de/products/boards-kits/nuc/kits/nuc5cpyh.html
Has anyone experience with that? The only thing that this compute unit has to do is to grab images and poses and send them via wifi

NUCs are certainly very capable of being used with D435 and T265 on the same robot.  Intel have done so in a RealSense mobile robot seminar on YouTube in the link below   The part where D435 is introduced starts at 17 minutes 15 seconds into the video.
https://www.youtube.com/watch?v=62vm0_RZ1nU
Whilst there are other small compute units available, such as Intel's candy-bar sized Intel Compute Stick, I would not recommend them to be used with two RealSense devices at the same time due to power supply concerns.  A NUC or an Up Squared board (which has been shown to work with two RealSense devices) would be my primary recommendations.

Hey. Tried a bit around again. So I'm able at least to recover the T265. Meaning:
poll_for_frames -> if i get a certain time no data. stop pipeline. and restart pipeline. Its not a nice way but this works for me currently.
BTW: the issue only appears if both sensors are streaming data. If T265 is running alone, its working.

Are you distinguishing between the D435 and T265 using serial numbers, please?

Another user got around the problem of needing a serial number by instead programming query_devices to look for the first device with the name 'T265' in it.
https://github.com/IntelRealSense/librealsense/issues/3434#issuecomment-476290706

Hi @Leijoma ,
Will you be needing further help with this? If we don’t hear from you in 7 days, this issue will be closed.
Thanks


Fix #889 #899

For details please refer to each commit.
Mainly:

implemented customBadChars and added description in readme.md, may not work well with spaces
optimized methods to parse fanbox posts and the html template and the styles in it.

for the link and styles, the logic i wrote may be a little complicated? but it should be able to deal with such situations, even though no one would probably set the texts like this, but just in case:
original:

parsed:

for the link and styles, the logic i wrote may be a little complicated? but it should be able to deal with such situations, even though no one would probably set the texts like this, but just in case:
original:

parsed:

for the link and styles, the logic i wrote may be a little complicated? but it should be able to deal with such situations, even though no one would probably set the texts like this, but just in case:
original:

parsed:

for the link and styles, the logic i wrote may be a little complicated? but it should be able to deal with such situations, even though no one would probably set the texts like this, but just in case:
original:

parsed:

hmm.. i think i am gonna change the css styles a little more...

hmm.. i think i am gonna change the css styles a little more...

Now it should be like this:
original:

parsed:

Now it should be like this:
original:

parsed:

why all of a sudden all the test scripts are picking one me....?
i am gonna hit the gym and fix this later. please comment or anything.

why all of a sudden all the test scripts are picking one me....?
i am gonna hit the gym and fix this later. please comment or anything.

hmm. this is weird. i will pull a new one...

hmm. this is weird. i will pull a new one...


added a name

maybe we can expand this with the scope of the tensor like in TensorFlow for better interpretability of computational grah

I don't want this. The name of the tensor in models should just be the variable.


Switch order of disparity charts

Put the rate/100k on top of the share of cases vs. share of pop

Discussed in May 18 eng/pm sync


Adds a prompt for entering a PIN when a FIDO2 key is PIN protected

Description
Adds a prompt for entering a PIN when a FIDO2 key is PIN protected. It's currently rebased on another open PR which fixes compatibility with fido2 0.8.0 #232.
Related Issue
This resolves #240
Motivation and Context
Initially encountered a problem when Azure required setting a PIN for FIDO2 key use and then gimme-aws-creds stopped working because it is missing a prompt for PIN.
How Has This Been Tested?
Have verified that a PIN protected Yubikey 5Ci is workin.
Have verified that a PIN protected Yubikey 5 is working.
Have verified with another Yubikey 5Ci without a PIN set that you are not prompted for a PIN.
Did observe that if both a PIN protected and non-PIN protected key is plugged in to the computer at the same time, you will receive the PIN prompt as the client does not know whether you will need it.
Screenshots (if appropriate):
Using password from keyring for<EMAIL_ADDRESS>Multi-factor Authentication required.
webauthn: webauthn selected
Challenge with security keys ...
Please enter PIN:

Touch your authenticator device now...

Saving arn:aws:iam...

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Anyone able to take a look at this and #232?

Thank you so much. Such a long awaited function finally available.


[ENG-512] feat: connect write form to state

Summary

removes dummy data
connects write form state to context
refactors field state to use a useField hook.

demo with hydratedRevision data

steps

~UI write tab + form~
~refactor read state~
~add write state to context~
connect data to write state slice (in progress)
4a. connect hydratedRevision data
4b. connect config data
submit write state slice
add isModified / in progress state

added ticket: https://linear.app/ampersand/issue/ENG-587/feat-support-only-write-no-read


[Forwardport] UI for Feature Flags

Forwardport for rancher/rancher#23184

Available in latest2

rancher/rancher:master-head 781cd0f
ui: latest2

Feature flags tab is shown in Global Settings
Toggling feature flags enables/disables features appropriately
No bulk selection
Default settings view is Advanced Settings


Agents endpoints

Proposed changes:

[X] Rasa logic should work with agents (endpoints)

Status:

[X] ready for code review
[X] there are tests for the functionality
[ ] documentation updated
[ ] changelog updated

The idea behind this is to enhance how RASA handles multiple apps to be on par with services like api.ai. Indeed when you have a client sending a training request like this <IP_ADDRESS>:5000/train?name=agent_A you expect your agent (endpoint) to still be available for parsing requests and updated with the newly trained model once available. So models would be a way to version your agent:

agent_A

model_YYYYMMDD-HHMMSS (model actually in use)
model_YYYYMMDD-HHMMSS
model_YYYYMMDD-HHMMSS
...

agent_B

model_YYYYMMDD-HHMMSS
...

This was extracted from: https://github.com/RasaHQ/rasa_nlu/pull/426

@PHLF am I correct that you haven't made any changes to the flask endpoints yet? I was curious what it would look like to load a specific agent /parse?q=hello&agent=myagent? How about a specific model of a specific agent? /parse?q=hello&agent=myagent&model=mymodel?

You're right: I didn't do any api changes at the moment. I'd like the actual work to be reviewed first before introducing any breaking changes. And yes loading a specific model for your agent is something that would be great to introduce 😄

So without the ability to load a specific model, this would be a major breaking change for us. When we train a model we put it through an evaluation phase, only after the evaluation is done does a user in our system choose whether or not to activate it. The activation is done by maintain our own list of active models and simple routing request approprietly.
In the end we can hack it either way by just strictly interacting with agents as we have models. Just food for thought.
I'm swamped this week, but may get me or my team involved next week. Either way, we are watching with nervous anticipation.

You don't have to be nervous as my incentive is not to break anything but to remove the need of hacking things you mentioned. By the way it should be easy to extend the http api to request a specific model for a specific agent. Still this is just a PR with no guarantee to be integrated at all 😉

Do you have any suggestion regarding some http API changes: can I go for loading a specific model for a specific agent?

@PHLF sure that sounds very useful. The only thing we need then is a way for the API user to know which model currently is loaded for an agent.

And there might be threading issues, right? So you could have loaded the recent model within one thread and an older one in another thread, which sounds dangerous.

That should be part of the /status endpoint response.
I need to check that.

Checks are erroring: that's OK. That's still very much W.I.P. but at least it is advanced enough to allow you to give some feedback about the current code structure (among other things, I need to take care of multithreading issues).

TODO at this state:

Check if the infamous GIL is enough to prevent unsafe concurrent access to the agent_store (I have serious doubts about this one)
Write some more tests (parse request for specific agent/model)
Update the /status endpoint
Wait for some more comments ( @wrathagom , @tmbo ...)

Not sure if this is directly related or even if it's the right place to mention it, but loading models in different languages would be very useful. Right now I think config only supports one language

You're right in the sens that there is a language parameter in the config file and also in the models' metadata files. I'm pretty sure there is a technical reason behind this but this is confusing and it would be more logical for the language to be only set at the model level.
Beyond that, in the long-run maybe some parts of the models' metadata could be moved at the agent level by introducing a metadata file for this one.

@tmbo Most of the logic is now in place.

According to rasa_dm docs :

An Agent instance owns an interpreter, a policy and a domain

It almost looks like the same thing to me, except this is at the NLU level : would this PR really improve things for you? Any suggestion for a name? model / interpreter_delegate / handler

I was waiting for your comments 😃

I vote for 'projects' :)

Agent -> Projects ? Sounds a bit strange to me. What is the motivation behind such a name ?

So you might have multiple bots under development (say one restaurant bot and one customer service bot), and each has it's own training data and model. So the project would be e.g. 'restaurants', and you can always call /parse?project=restaurants and get the latest model

Fair enough. Let's do some renaming then.

I should change normalise_request_json in rasa_nlu\__init__.py, shouldn't I?

I think sensible behaviour would be to either specify a project (&rasa uses the latest) or specifying a specific model - @tmbo WDYT?

Yes, I agree, querying the latest is a sensible default. But being able to use a specific model is quite useful as well - should do both.

Querying a specific model for a specific project already works, but I'm not sure it works with the emulators as well.

sounds good. why wouldn't the emulation work? I think they are just post processing the pipeline result

My bad, it's not related to the emulators but to the way some parameters are normalized. Does this need further changes to also normalize a model parameter ?
    def normalise_request_json(self, data):
        # type: (Dict[Text, Any]) -> Dict[Text, Any]

        _data = {}
        _data["text"] = data["q"][0] if type(data["q"]) == list else data["q"]
        if not data.get("project"):
            _data["project"] = "default"
        elif type(data["project"]) == list:
            _data["project"] = data["project"][0]
        else:
            _data["project"] = data["project"]
        _data['time'] = data["time"] if "time" in data else None
        return _data

yes, that's right, the parameter needs to be added there.

I made some changes (readers-writer lock) to ease the development of further enhancements like an unload HTTP endpoint to delete unused models from memory.

@PHLF do you think we can get this merged today?

I have to update the docs, but I think this is technically ready.

@amn41 @tmbo @wrathagom I think this is technically OK. I did a first pass on the docs. Let me know what you think.

looks really good - you did a great job with this PR let's get the merged when the Travis build is finished. we'll tackle issues with the documentation along the way.

you did a great job with this PR

Only time will tell 😃
Next thing to add: an HTTP endpoint to unload models from memory. The server side logic is in place, it just requires a new endpoint and a new route handler in the datarouter.
Thanks Tom for your support.

Yes, you are right, I think that is another really good addition. But as I don't want to delay this PR any further (I know that you already needed to resolve a lot of merge conflicts 😉 ) I'd rather see them added separately.

:tada:


settings

Settings in general.
But most importantly the settings for notifications

the basic concept is working.
show banner needs implementation and led is not working somehow

notification settings are working now.


Fix Minor Formatting

@dulvinw for the moment, I feel like it is better to stick to using std:: and not use additional formatters. Didn't properly compile on Mac M2 with clang. Until we add CIs to check this kind of issues, shall we stick to the most basic things.
Also std:: usage is mostly encouraged and that is sort of a norm in most cases.


Separate the public & private scope from the existing "no scope" mechanism

Separate functions scope into public and private scope: public functions are the ones the users will call, vs private functions are for internal use.
_single_leading_underscore: weak “internal use” indicator.
E.g. from M import * does not import objects whose names start with an underscore.

This is done, by changing the codebase from function base to OOP paradigm


Path to private_user.h updated

Pierre, the path was wrong indeed. But I think the correct path should be src/deezer_wrapper/private/private_user.h, isn’t it?
Sent with GitHawk

Oh yeah you're right, it's: deezzy/src/deezer_wrapper/private/private_user.h

Pierre, could you please commit this update to your branch so that I can accept your pull request? thx

Hi @blackccpie , it's done

Ok @blackccpie , it should be fine now ^^.


Issue #3494 fixed

BUGS:
Issue: #3494
For things other than bugs:

Describe that thing in very short line, word limit is 200.
Otherwise use issue #id if the issue was filed as feature request.

@vishal-webkul
Images are not visible in compare list please check https://prnt.sc/tuy9os https://prnt.sc/tuy9vv

@vaishaliwebkul
Image issue fix please let me know if any issue remain

not working ..

working fine


Bug: Preview Markdown in Comment Reply broken

When adding a reply to a comment on a video the preview markdown button doesn't work

This was fixed a while back, forgot to close


[DOC]: Document Environment Variables

Can the documentation please be updated to incorporate a running list of environment variables that cleo reads and/or sets? I ran a simple python script (see below) to identify such variables and these would be as listed below:
ANSICON
TERM_PROGRAM
SHELL
COLORTERM
TERM

We will want to add FORCE_COLOR and NO_COLOR to this list as well once PR #343 is merged.

find_used_env_vars.py
import os
import re

def find_used_env_vars(filename):
    used_env_vars = set()

    with open(filename) as file:
        content = file.read()
        matches = re.findall(r'os\.environ\[[\'"]([A-Z_]+)[\'"]\]', content)
        used_env_vars.update(matches)

        matches = re.findall(r'os\.environ\.get\([\'"]([A-Z_]+)[\'"]\)', content)
        used_env_vars.update(matches)

        matches = re.findall(r'os\.getenv\([\'"]([A-Z_]+)[\'"]\)', content)
        used_env_vars.update(matches)

        matches = re.findall(r'os\.getenvb\([\'"]([A-Z_]+)[\'"]\)', content)
        used_env_vars.update(matches)

    return used_env_vars

def main():
    result = set()

    for root, _, files in os.walk('.'):
        for file in files:
            if file.endswith('.py'):
                file_path = os.path.join(root, file)
                result.update(find_used_env_vars(file_path))

    with open('output.txt', 'w') as output_file:
        for var in result:
            output_file.write(var + '\n')

if __name__ == "__main__":
    main()

I have added this to the list in #251 I'm going to close this to avoid duplication.