feat: add Toaster primitive for Soul

Adds the Toaster primitive that uses Sonner for toasts.
Customize Toaster.
Updated the docs to include this new primitive.
Add primitive to preview to enable use of toast in other components.

Demo
https://github.com/user-attachments/assets/635b1c8d-9862-4a69-b9f6-bd9905db4d34
Notes

[!IMPORTANT]
There is a divergence from the proposed designs in how we handle the close button:

Sonner has it on the corner since the toast can have an action on the right side of the toast.

The proposed designs has the close/dismiss button as an action:

I feel it may be important to retain the action prop api for Toast so I think it is a better implementation to keep the close button in the corner as it currently works from the box in Sonner, but I want to hear what @andrewreifman might have to say on this.
Another option is to have a custom toast function that does not accept actions.

@jorgemoya Don't love some of the styling at the moment. I would prefer to place an optional action button next to the close icon instead of using Sonner's corner version. In Figma, I created a ghost variant that we never applied to the codebase, as well as an "x-small" size option. I updated the Figma mockup to include this, as well as removing the left icon from all variants. This was something Monogram had in there initially that I kept, but I'm wondering if we should just remove the left icon to simplify it.
Let me know what you think.

@andrewreifman This works for me! I'll be updating the designs to match this.

Updated designs:

Was playing around with it and I think it looks pretty good. There doesn't seem to be any active state on the close buttons, though. @andrewreifman, can we get those states mocked up? The current mockups seem quite lacking in terms of interaction states

Was playing around with it and I think it looks pretty good. There doesn't seem to be any active state on the close buttons, though. @andrewreifman, can we get those states mocked up? The current mockups seem quite lacking in terms of interaction states

Ok, did one more round of design revisions. Here are some of the things I updated:

Modified some general styles on the alert like width and padding
Added a subtle border and drop shadow
Added a white variant that I think we could use as the default
Added subtext under the main message
Converted the optional button and close to use actual button component. For the button component, there is a ghost variant, as well as some size options that are not available in the current state of the code in VIBES. That will have to be updated as well. These buttons will have the states included.

@migueloller @jorgemoya Let me know if there is anything else missing in the mockups.

Was playing around with it and I think it looks pretty good. There doesn't seem to be any active state on the close buttons, though. @andrewreifman, can we get those states mocked up? The current mockups seem quite lacking in terms of interaction states

Ok, did one more round of design revisions. Here are some of the things I updated:

Modified some general styles on the alert like width and padding
Added a subtle border and drop shadow
Added a white variant that I think we could use as the default
Added subtext under the main message
Converted the optional button and close to use actual button component. For the button component, there is a ghost variant, as well as some size options that are not available in the current state of the code in VIBES. That will have to be updated as well. These buttons will have the states included.

@migueloller @jorgemoya Let me know if there is anything else missing in the mockups.

@andrewreifman, this looks great! I think what we're missing are the active and focus-visible states. The mockups seem to only include the hover states.

@andrewreifman, this looks great! I think what we're missing are the active and focus-visible states. The mockups seem to only include the hover states.

@migueloller We should be using the Button component for those actions. Do you feel like it's necessary to show that in this mockup when the Button Figma already includes those states? And do we need focus-visible states for the toasts themselves?
Also, hot take, but I don't like including active states for most components. I think it's unnecessary to include unless there's an accessibility reason I'm unaware of.

Hey @migueloller, I updated how this component is used to allow the use of our custom Alert primitives. Let me know what you think, I'm always open to reverting the latest change.

@andrewreifman, this looks great! I think what we're missing are the active and focus-visible states. The mockups seem to only include the hover states.

@migueloller We should be using the Button component for those actions. Do you feel like it's necessary to show that in this mockup when the Button Figma already includes those states? And do we need focus-visible states for the toasts themselves?
Also, hot take, but I don't like including active states for most components. I think it's unnecessary to include unless there's an accessibility reason I'm unaware of.

If we're reusing the Button component, then it's not necessary, no.
And I won't argue with you if you think active states aren't useful. I personally disagree as I think that UI should provide feedback on interaction but I'll delegate to you here

Will use vibes button component once this is merged https://github.com/makeswift/vibes/pull/364


ARROW-2195: [Plasma] Return auto-releasing buffers

On the C++ side, add a new PlasmaClient::GetAuto() method to return buffers that release
the corresponding object on destruction.
On the Python side, return such buffers in PlasmaClient.get_buffers().

This changes/adds some APIs on the CUDA side so will need reviewing from someone familiar with that code base.

@robertnishihara @pcmoritz @Wapaul1 Is one of you interested in reviewing this?

How do people feel about replacing the old Get and Create methods with new ones which return PlasmaBuffers, and make Release private (which means PlasmaBuffer needs to be friend of PlasmaClient). Given that 0.9 has just been released it might be the right time to do it.

I suppose that depends how you feel about breaking compatibility without notice :-)

Ok, let's do the following:

Deprecate the old Create and Get and Release

Make new ones with the following signature:

// sizes are already available through buffers, no need to store them separately
struct PlasmaObject {
  std::shared_ptr<Buffer> data;
  std::shared_ptr<Buffer> metadata;
  int device_num;
}

Status Get(const std::vector<ObjectID>& object_ids, int64_t timeout_ms, std::vector<PlasmaObject>* objects);

Status Create(const ObjectID& object_id, int64_t data_size, int64_t metadata_size, PlasmaObject* object);

(the metadata would be written to shared memory directly by the client instead of passing it in)

which are backed by PlasmaBuffers and don't need explicit release

I'm slightly uncomfortable that the two overloaded ones have different behavior and the same name, but going forward that seems to be the best solution (we should try to avoid having two rounds of deprecations).

@pcmoritz I would suggest tackling Create() in a separate PR, since there are additional complications in how it interacts with Seal() and Abort().

@pitrou I'm seeing https://issues.apache.org/jira/browse/ARROW-2448 when using this PR.
It seems like we need each client to keep track of the buffers that it produces and to invalidate them when the client disconnects (or something like that). cc @pcmoritz


ConsumeMessageOrderlyService  can use ReentrantLock

The ConsumeRequest class code is :
final Object objLock = messageQueueLock.fetchLockObject(this.messageQueue);
synchronized (objLock) {
......
}
it will block the  messageQueue and other messageQueue  to process
we can use ReentrantLock.tryLock()

ReentrantLock objLock = messageQueueLock.fetchLockObject(this.messageQueue);
if(objLock.tryLock())
{
.....
}else
{
ConsumeMessageOrderlyService.this.submitConsumeRequestLater(this.messageQueue,this.processQueu,10);
}

Other question is messageQueueLock class  should have "consumerGroupName" param

This is not Q & A channel, please read our issue template carefully.

I think it is a question,it has low operating efficiency


Text file export

Allow exporting system specs to a text file

Feature added here: https://github.com/Lion-Craft/Tinyinfo/pull/56


Schema for Collection Properties

The AI Ecosystem Extension has a Collection Property defined:
https://github.com/fiboa/ai-ecosystem-extension
There's no way yet to define Collection Properties in the fiboa schemas.
Currently the spec differentiates between Collection Properties and Feature Properties and Collection Properties could only be validated via STAC extensions right now (but STAC Collections are not required).
Related to: https://github.com/fiboa/specification/issues/13

The most elegant solution (and a potential solution for https://github.com/fiboa/specification/issues/13 ) seems to not distinguish between Collection Properties and Feature Properties. Whenever all values for a property are the same, the field can be moved up to Collection Properties if desired.
Validation would need to check whether it only exists in one place and then dynamically check whether something is in the Collection Properties or in the Feature Properties and act accordingly.

The license example would remove license from the collection level metadata in the "various" case. A property couldn't be both at the collection and feature level, i.e. that would be reported as invalid to avoid that issue.

Ah, ok - I hadn't made the leap that the license would be removed from collection level metadata and that a property couldn't be at both the collection and feature level. So the idea is that any property that has more than one value has to be represented at the feature level.
I was imagining that it could be nice in some cases to just be able to quickly look at the metadata at literally see 'license = vairous' instead of having to iterate through everything. Or to like know that every license is 'open'. Seems like we start to get into a desire for stac-style summaries.
I'm also wondering about things that may only make sense at the collection level. The one that comes to mind is the 'bounds' of a collection. I guess the temporal extent is similar. Are these 'special' the other way from your non-collection examples above (id, bbox, etc).

I am leaning towards this idea of making it so there is no difference between collection and feature level properties. Just hoping there's not lots of special cases we'll need to come up with. I tend to prefer to specify things at the 'right' level and not have things be so fluid, but it does seem like many people will combine fiboa datasets and thus 'push' many things that would be 'collection' level in a single dataset to be represented at the feature level when combined.
I do think it'd be good to 'stress test' the idea a little bit, to think through some of the 'merge' use cases where people are bringing different datasets together and make sure the properties would work right. This doesn't have to be super extensive, as we can also just change it again if it doesn't work.
One other semi-related thing to think through is using the same schemas when the geometry is just referenced instead of included. The biggest use case is time series data, like daily soil moisture or NDVI - having every date as a column off the geometry gets pretty onerous, but it'd be nice to have a defined way to talk about time series. But this probably deserves its own issue.

I am leaning towards this idea of making it so there is no difference between collection and feature level properties.

Agreed.
What do you mean with "fluid"? Feels like there might be a misunderstanding hiding here?

But this probably deserves its own issue.

Indeed.

Slides from today:

Schema for Collection Properties

No distinction between collection and „normal“ properties
Same schema and they can be used in both places
Provide fiboa_extensions per collection id

How to handle required fields (e.g. in merged datasets)

Provide stac_extensions per collection
All columns in Parquet nullable, don’t check nullable in datatypes, only check it in data validation
Validate per collection (or row)


Support JSON serialization with result model

RF 6.1 added support to serialize the execution model (robot.running.TestSuite) into JSON and back (#3902). This support should be extended to the result model (robot.result.TestSuite) as well. Supporting writing results directly to a JSON file as part of execution is out of the scope of this issue (we already have #3423 about that), but Rebot should be able to produce output.json files.
A precondition for this issue is cleaning up the result model a bit. That includes removing deprecated attributes (#4846), enhancing how keyword names are stored (#4884) and enhancing timestamp handling (#4258).

The ModelObject base class that both running and result objects use got to_json and from_json methods already in RF 6.1 when JSON serialization support was added to the running model (#3902). Supporting to_json and from_json with the result model had a precondition that the result model should be cleaned up a bit (see issues referenced from the description), and after that all result model objects just needed their own to_dict. @yanne has implemented them (relevant comment don't seem to be linked to this issue) and they were already part of RF 7.0 beta 1.
The commit referenced about adds JSON support to Rebot so that both of these usages work:
#  Convert output.xml to JSON:
rebot --output output.json output.xml

# Parse JSON output files:
rebot output.json

Notice that the created output.json file only contains information about the executed suite, no statistics or errors like output.xml files contain. We probably should change that in the future when we add support to write output.json as part of execution (#3423). Robot's own functions and tools processing output.json files will, however, continue to support also files with only suite information.
This functionality still needs to be documented in the User Guide, but otherwise this issue is ready.

The JSON data format has a separate section in the User Guide. A similar section would be nice for the JSON result format as well, but it would also be a bit odd because we don't have such a section for the XML result format. I think we can consider result formats such information that it isn't needed by normal users and thus doesn't need to be documented in the User Guide. We can add something later, but then we should document both XML and JSON formats.
How to use create and process JSON output files with Rebot obviously needs to be documented.


[EventGrid] Prepare for v3.0.0-beta.4 Release

Update version dependency on @azure/core-auth to 1.2.0 now that it has released.  We depend on some new surface area from this release.
Update CHANGELOG.md and version.

Looks good. Please go ahead and merge


Can vegeta output result file integrate with Grafana or Kibana

Question
I want to display vegeta test results in open source Data visualization dashboards such as Grafana/Kibana. How can I achieve this?

Use the JSON output report and ingest it into your system

@blakewatters  - thanks for the reply.
Without sending the JSON once the test is completed, are there any listener where we can directly ingest data to Grafana?

@blakewatters - Hope you are doing good.
Any update on this?

@dilshan5 You can use vegeta encode to output your test rest records into a file, and then you can use filebeat or logstash to import the file into ES. Finally, you can use kibana or Grafana to  analyze or display your data or analysis results.
So, I don't think it's necessary or urgent to develop the feature you mentioned above.

@tsenart It's suggested that corresponding URL of each output record is printed out in the final result file though.

I want to display vegeta test results in open source Data visualization dashboards such as Grafana/Kibana. How can I achieve this?

I'm not sure, there's probably a few different ways via vegeta encode, but nothing built-in.


Fix artifact URL generation.

When generating URLs with a FQDN including the initial dot '.', the URLs generated would include this in the request URL.
https://github.com/fluxcd/source-controller/blob/main/config/manager/deployment.yaml#L52

@bigkevmcd we use . to reduce the DNS queries, this is not bug but a feature.

@stefanprodan ahhh...because it's fully delineated from root...I get it :-)


Ignore e2e source at coverage

Changed

Updated depdendencies
Updated coverage to ignore e2e source code
Updated npmignore with e2e folder

Codecov Report

Merging #93 (9dedcd1) into master (5a80de9) will increase coverage by 27.31%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #93       +/-   ##
===========================================
+ Coverage   67.38%   94.69%   +27.31%
===========================================
  Files         110       74       -36
  Lines        1941     1094      -847
  Branches      206      133       -73
===========================================
- Hits         1308     1036      -272
+ Misses        626       56      -570
+ Partials        7        2        -5

Flag
Coverage Δ

cuaktask
92.72% <ø> (ø)

iocuak
94.41% <ø> (+38.19%)
:arrow_up:

porygon
97.88% <ø> (ø)

porygon-typeorm
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../getContainerModuleMetadataWithFactoryParameter.ts

...m/src/crud/adapter/typeorm/DeleteTypeOrmAdapter.ts

...utils/typeorm/findManyOptionsToFindOptionsWhere.ts

...Service/getTypeServiceWithConstructorParameters.ts

...m/src/crud/adapter/typeorm/UpdateTypeOrmAdapter.ts

.../crud/modules/iocuak/TypeOrmReadContainerModule.ts

.../e2e/definitions/container/containerDefinitions.ts

...erModuleWithTypeServiceAndValueServiceParameter.ts

...rud/modules/iocuak/TypeOrmUpdateContainerModule.ts

...ypeService/getTypeServiceWithNoBindingParameter.ts

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0a0e4...9dedcd1. Read the comment docs.


Signal improvements

Currently a lot of Signal code in OPHD has to manually pair up connect and disconnect calls when using Signal objects. This is potentially error prone, and if connect/disconnect calls are not properly paired up, it can result in a crash bug due to dangling object pointers and calling methods on already destructed objects.
One way to make this safer, is to create an RAII type object to handle the connection, perhaps called SignalConnection. Objects that need to register and respond to signals can own a SignalConnection object that establishes the connection, and automatically calls disconnect when it goes out of scope. That would allow objects that listen and respond to signals to easily tie signal connection to their own lifetime.

Another limitation of the current design, is giving access to a Signal object to add or remove event listeners also gives full access that allows emit to be called on the Signal object. It may be that add/remove access should be granted for event listeners, while emit is kept protected.
One way to achieve this, is to split the class into a base interface that supports adding and removing event listeners, and a derived objects that supports emit. The owner of the object can see the full interface, including emit, while a reference to the base interface can be given to clients that only includes the methods to add and remove event listeners.

We might also want to look into grouping related files into a folder.

The EventHandler.h header file has a lot of documentation in it attached to the using alises for the Signal source types. This documentation is partially copied in EventHandler.cpp and associated with the method to gain access to those signals. We should choose a single place for this information, and remove the duplicate. I propose moving the documentation detailed documentation to the .cpp file, and removing it from the .h file. If the documentation is that detailed, normally it's better to associate it with the source code, as it may relate to implementation details, and so should be updated when the source code is updated. Plus, if someone needs details on how a method works, the source file is the more logical place to look. The header file is usually more of a short overview of what is available.

The EventHandler.h file has a lot of using aliases for the signals. If we use the split off SignalSource interface for the return values, these aliases effectively become single use. That means we can inline the definitions, and remove them from the header.
As this relates to the above, it makes sense to first consolidate the documentation by moving it to the .cpp file, then inline and remove the using aliases.

Still need to implement the SignalConnection from the first message.
We might also want to still sort the code into its own folder. That is particularly true since that code is in its own nested namespace.

API additions are now complete.
One task left was to sort Signal related classes into a Signal/ folder. As part of that we may want to rename the Signals namespace to Signal, or perhaps just drop it entirely. It is part of the NAS2D namespace already. It's not likely we'll be adding other classes to the NAS2D namespace that will conflict with names in the NAS2D::Signal namespace. Plus, at this point, the customization and integration with the rest of the library puts in on par with other components that are simply sorted into their own folders without additional namespace nesting.
As part of the folder re-organization and namespace change, we may want to rename Connection to SignalConnection for clarity. That was the original suggested name, though felt a bit redundant when it was already nested within either the SignalSource class or the Signals namespace.
Changing the header paths is a breaking change. Downstream projects may have imported those headers directly, so path updates may be required in downstream projects. Same with namespace changes. As such, those changes should probably be handled in their own PR, and downstream projects updated soon afterwards.


Missing keyboard shortcut features from Sublime Text

I created an extension to port Sublime keybindings to VS Code keybindings. I made a list of all the key bindings that were missing analogous commands in VS Code.
Here is the list roughly ordered by importance. Please let me know about more I missed in the comments. If an extension exists with the functionality I added it in the far right column.

Close HTML tag
https://github.com/Microsoft/vscode/issues/14104
Close HTML/XML tag

ctrl+k ctrl+6
cmd+k cmd+6
Fold level 6
https://github.com/Microsoft/vscode/issues/14106
None

ctrl+k ctrl+7
cmd+k cmd+7
Fold level 7
https://github.com/Microsoft/vscode/issues/14106
None

ctrl+k ctrl+8
cmd+k cmd+8
Fold level 8
https://github.com/Microsoft/vscode/issues/14106
None

ctrl+k ctrl+9
cmd+k cmd+9
Fold level 9
https://github.com/Microsoft/vscode/issues/14106
None

alt+0
cmd+0
Select open tab index 9
https://github.com/Microsoft/vscode/issues/14095
None

Additionally, here are other actions that are not bound to a keyboard shortcut:

Action
Issue
Extension

Drag and drop selected text
https://github.com/Microsoft/vscode/issues/1046
None

Customize keybinding support in menus (see this comment https://github.com/Microsoft/vscode/issues/3776#issuecomment-260324787)
Customize keybinding support in viewlets (see this https://github.com/Microsoft/vscode/issues/4557)

Is super mapped to ctrl or alt? Surely they don't bind win+<num>

super is win or cmd

@waderyan just looked, I don't see any super in the default keybindings on Windows. Is the above the OSX version?

Yes. From the docs it looked like this was the case

(Hopefully) new VSCode convert here! One of my most used commands in sublime is shift + cmd + l which sublimes calls 'Split into Lines' (under "Selection" menu).
It creates a new cursor for each line of a given selection. Does this functionality exist in VSCode? I cannot see it in the list of missing bindings @waderyan compiled above, but I also cannot seem to find it in VSCode.

@JamesHenry not sure how I missed that one. Added now.

Great, thanks. Consider this my +1 :)

[     { "keys": ["ctrl+minus"], "command": "jump_back" }, //this command already exists in vscode as cursorUndo     { "keys": ["ctrl+shift+minus"], "command": "jump_forward" } //this one has yet to be added ]

@JamesHenry In vscode we can used:
cmd  + i and
option + shift + i

Ah, awesome thanks @yisibl!
Yeah, I have just made it my first ever shortcut override :D

By the way, VS Code not support cmd + j

It would be awesome if we have all these in vscode :+1:

@kabirbaidhya you can install the Sublime Keymap extension that @waderyan built right now. If you find any issues you can file them to the repo https://github.com/Microsoft/vscode-sublime-keybindings/issues

My #1 most used sublime shortcut is:
Ctrl + ⇧ + ↑	Move line/selection up
Ctrl + ⇧ + ↓	Move line/selection down
Any chance of adding these to the package?

I wrote an implementation of Join Lines and Transpose (and some other Sublime commands) which are more faithful to how Sublime implements them:
https://marketplace.visualstudio.com/items?itemName=Zarel.sublime-commands
I generally don't think it's a big deal to copy another editor's behavior exactly, but in this case, the main difference is that Sublime's behavior is less buggy. Specifically:

transpose crashes when some selections are empty and others aren't; sublime-commands transposes them as expected
transpose behaves weirdly when there are three or more selections; sublime-commands transposes them like Sublime Text
join-lines crashes when a cursor is on the last line, sublime-commands doesn't
join-lines doesn't join the last line of a multiline selection, sublime-commands does (matching Sublime Text's behavior)

If you agree that these are better, could you update the readme in https://github.com/Microsoft/vscode-sublime-keybindings and this issue to refer to those?

Also: Would you be opposed to pull requests adding these features directly into VS Code itself? These features are presumably broadly useful enough to be built-in to Sublime, and then we wouldn't need to install extensions to get access to them.

@nnur I have been itching for the same thing. Transpose sort of does it, but not the way we're used to.

:+1: to @Zarel's sublime-commands. The behavior for joining lines and adding cursors to selected lines are closer to Sublime Text's.

Please also add the crtl + click to add a new cursor.
BTW great work with the extension!

@claudio4 added!
To all - any thoughts on prioritizing the above table? I think join lines is high, followed by ctrl+click to add new cursor. From my experience, I really miss paste and indent. More feedback is appreciated. We have working through a couple of these on our iteration plan for this month.

@waderyan for #9415, we already have all support.

FWIW, the two main Sublime features I would terribly miss are:

The ability to quickly switch between projects (Project > Quick Switch Project)
Magically restoring my unsaved files when switching between projects or closing/reopening windows.

(But, of course, it is are more about missing functionality than just missing shortcuts.)

Hi, tell me please, i'm binding moving up and down on shortcuts (like alt+j, alt+k), in sublime i can moving up and down with this hotkeys when suggestion menu is open  (or another menu). Can i realize it in VS ?

@gkalpak I recommend checking out one of the project manager extensions for that, I use Git Project Manager personally.
Hot exit is coming in the next version, see #101

@Omen-X that is not currently supported, but I have added it to my list.

@Tyriar, awesome to see hot-exit making it into VSCode 👍 :dancing_men:
Git Project Manager is pretty nice actually, but I miss a more flexible "project" abstraction (mainly for multi-directory projects). Fortunately, it is on the roadmap (and I can leave without it for a while :smiley:).
#AboutToSwitch

:+1:, FYI @gkalpak multiple folder workspaces is tracked in https://github.com/Microsoft/vscode/issues/396

FYI there is a PR out to add functionality here - https://github.com/Microsoft/vscode/pull/15787

Can a shortcut be added to toggle case along with upper and lowercase, as this makes life easier to have just one shortcut to toggle case.
Which is what IDEA follows

@thekalinga that is in the PR mentioned above 👍

Hi,
I see only these two
Upper case	https://github.com/Microsoft/vscode/issues/14096	change case
Lower case	https://github.com/Microsoft/vscode/issues/14096
What I was asking is to have an action that can toggle. i.e if the shortcut is ctrl+t, this toggles the current case to uppercase by default, if you press it again, the selected text would be converted to lowercase.
Can u please confirm
Thanks

@thekalinga thanks for the clarification. Can you open a separate issue for that? This issue is specific to keyboard shortcuts in Sublime Text. Sublime Text has separate commands for upper and lower case.

Sure. I'll open one for that.
The reason why I added a comment here is because since upper & lower are getting implemented, it would be easy for contributors to make the change in one shot.
Thanks in anycase

@thekalinga makes sense. Thanks for your feedback!

Note that we closed on some of these issues for VS Code 1.8 release.

[x] Join lines
[x] Transpose
[x] Upper/Lower case
[x] Paste and format

Your join lines implementation doesn't work the same way Sublime does when text is selected, and neither does your transpose implementation. :( The join lines difference is minor, but are you open to pull requests changing Transpose?

@Zarel we are definitely open to pull requests. The reason that you are seeing differences is

Vim, Sublime Text and Atom all have Join Lines, they are not totally the same when dealing with leading/trailing spaces. If you see any other difference, feel free to change it or file an issue.
Sublime Text 3 and 2 are doing Transpose differently. Here we mimic Sublime Text 3.

If you'd like to file pull requests, please describe what kind of behavior in your new implementation and why you think it's better or more reasonable than the original one. Thanks!

@rebornix There still exists a Sublime Text 3 behavior VS Code doesn't mimic.
Sublime Text 3 will, if some selections aren't empty, transpose the selections, putting the contents of the first selection into the second, the second into the third, etc, and the last into the first.
For instance, if you have foo bar, and you select foo and bar and do a transpose, you will have bar foo.
The use-case is stuff like:
if (key === 'up') goUp();
if (key === 'down') goDown();

I can doubleclick on goUp, alt+doubleclick (or cmd+doubleclick in Sublime) on goDown, and then ctrl+t to get:
if (key === 'up') goDown();
if (key === 'down') goUp();

In general, being able to easily swap two variable or two literals is surprisingly useful. Without this, the swap is pretty annoying to do. Something like, double-click goUp, cmd+c, double-click goDown, left, cmd+v, shift+alt+right, cmd+c, click where goUp used to be (a much smaller click target than before), cmd+v. I'd often retype them rather than deal with that mess.
That's the behavior my plugin implements, and the behavior I'd like to pullreq.

@Zarel basically I like the idea. I did implement the word transposing at the beginning but since it requires more consideration about multi cursor mode so I didn't rush it in. We do have API for you to detect word boundary so it would be not difficult to add this feature, but like I said, multi cursor is kind of the monster. As you have already have implemented it in your extension, it would be awesome if you can contribute to the core.

Customize keybinding support in viewlets (see this #4557)

This is added for February.

How about ctrl +shift + d  for duplicating the current line?

On Windows, Sublime Text has a very useful "keybinding" to switch editor tabs with right mouse button+scroll wheel up/down. I wonder how difficult it would be to add support for this?
Seems related to #3130, however there's no mention of pure mouse keybindings.

I'd like to see ctrl + shift + v / cmd + shift + v to paste and ident

I'd like to see this:
Add other column(s) to selection by click & drag: Ctrl + Shift + RightMouseBtn. -> windows hotkey

ctrl+shift+up/down
https://www.jflh.ca/2016-07-10-move-lines-up-and-down-in-visual-studio-code
[
{
"key": "ctrl+shift+up",
"command": "editor.action.moveLinesUpAction",
"when": "editorTextFocus"
},
{
"key": "ctrl+shift+down",
"command": "editor.action.moveLinesDownAction",
"when": "editorTextFocus"
}
]

@RamyElkest those actually exist... they're Move Line Up and Move Line Down.

Ctrl-K/Ctrl-Y for yank on macOS.
Ctrl-K cuts to end of line
Ctrl-Y yanks it back
This is ideally separate from the normal cut&paste buffer i.e. Ctrl-K followed by Cmd-V will paste the last normally cut/copied text, not the Ctrl-K buffer which can only be retrieved by Ctrl-Y

Shift + Righ Mouse Click, this is very useful for editing multi-lines at the same time.

i really like sublime's ⌘+T that shows a Go To File... dialog... you then start typing characters in then dialog and files that contain those characters get listed... like a very fuzzy autocomplete
super useful for heavily-foldered projects (rails, react)

ctrl+shift+d with text selection : duplicateText
extension sublime-duplicate-text

The "duplicate selection" exists in vscode. It's called copy line down.

This is exactly what I'm talking about : duplicate selection, not the whole line ;-)

Sadly sublime-duplicate-text does only selection and if you have nothing selected, it doesn't do the whole line like Sublime would. :-1: :(

Is there a good way to replicate ST's layouts and their keyboard shortcuts in VSCode, even if it means using another plugin? (screenshot below of the options)

I can sorta use the split editor keyboard shortcut to constant split editors and go from 1 column to many, and I can use another keyboard shortcut to swap orientation, but there doesn't appear to be any way to create a shortcut like ST's cmd+alt+1 which would merge them all into a single column, which I use quite often.

One of my all time favorite sublime shortcuts which I greatly miss in VS Code...
Select all inside tags / Expand selection outwards
ctrl+, or ctrl+shift+a

What about to ctrl+up and ctrl+down (arrows) to increment / decrement selected numbers? How to achieve it?

Just got it: https://marketplace.visualstudio.com/items?itemName=nmsmith89.incrementor (it's necessary to set the keybindings provided in the page and reload).

@giovannipds that is an emmet function, and it's already on code. No need for additional plugins.

@elboletaire right, thank you! I must haven't noticed. But the plugin does some additional stuff like swapping true and false etc., which is also cool. Will let it installed anyway. =D

I'm missing these!
{ "keys": ["super+e"], "command": "slurp_find_string" },
{ "keys": ["super+shift+e"], "command": "slurp_replace_string" },

Is there a way to switch between Workspaces in Code just like SublimeText does with Projects? That's pretty needed... =(

I'm missing these!
{ "keys": ["super+e"], "command": "slurp_find_string" },
{ "keys": ["super+shift+e"], "command": "slurp_replace_string" },

super key, on VSCode is win (I'm using win10).
For instance, I did this code on keybinding.json:
{
        "key": "shift+win+l",
        "command": "editor.action.insertSnippet",
        "when": "editorTextFocus",
        "args": {
            "langId": "javascript",
            "name": "Print to console"
        }
    }

I hope this help someone.

You mean Cmd-Shift-Right Del?

You mean Cmd-Shift-Right Del?

I mean the possibility to assign that action to a simple shortcut like ctrl + k

See https://github.com/Microsoft/vscode/issues/25075

multi cursor select is NOT working. Before I wiped the drives and installed OS in both my machines,  the Sublime extension, the ONE thing I want and use the most is no longer working. A month ago, it worked. Now, not on either. I went over the posts above. I am obviously missing something. I'm running Mint 19 Tessa on both machines.
Any thoughts here? I LOVE VSC but without the multi cursor I'm back to Sublime. It's just not the same :(

Closing this aggregate issue as it is out of date
If you have any commands that you would find useful and that are still not supported by VS Code (or added by an existing marketplace extension) please open a new issue


How to model crash transitions ?

I want to model a serial action which can crash. Heres an example
fair action DoWork:
    if current_state == State.Start:
        lock_service.acquire_lock()
        do_something
        do_another_thing
        lock_service.release_lock()

it is ok to yield anywhere in this action, but if the action crashes I would like to cleanup some state and release the lock.
right now im using a work around where i make the action atomic and use something like
if MaybeFail():
   return

to place failures in between lines.

I was considering adding try-except-else-finally clause of python, or to support other types of flows where it can yield but never crash. but for most real examples, they were not required, so I didn't bother to add.
Can you let me know the exact case when you would need this? Based on the name lock_service, I assume, the lock is managed by a separate microservice/database.
In that case, no same-action cleanup solution would really work, when the model is translated into real code during development. The real solution would require a separate fair action to detect and cleanup.

Can you let me know the exact case when you would need this? Based on the name lock_service, I assume, the lock is managed by a separate microservice/database.

Yeah exactly. We have a process that acquires a lock from the lock service and then that process can die while holding the lock. In production we have a periodic health check that can detect that the process has died and then it performs some cleanup.
But i'm not sure how to model that detection.

This will depend on how much you would want to model and the what happens when the node is working and thinks it is still holding the lock, but the lock service thinks the node failed and released the lock for some other process to acquire.
In the real world, the implementation most likely will have a timeout on the lock so it will get released after the timeout, and the nodes acquiring it will send periodic heartbeats, the heartbeats acts as lease renewal of the lock. The heartbeat interval will be significantly shorter than the lock release timeout. Before each critical operation, it must check if it still holds the lock. (That is, the lock was last renewed less than the heartbeat interval)
Since the system you are modeling, you are not interested in how the locks renewal and leases are implemented, you don't need to model the heartbeats, renewal etc, all we need to know is if the node still holds the lock.
You can simply maintain a holds_lock boolean variable. Before each critical step, atomically check holds_lock and execute the step. A separate fair action Timeout to release the lock.
fair action DoWork:
    if current_state == State.Start:
        lock_service.acquire_lock()
        holds_lock = True
        do_something()
        do_another_thing()
        holds_lock = False
        lock_service.release_lock()

func do_something():
    atomic:
       if not holds_lock:
         pass # Just to ensure it marks this block as enabled
         return
       ....

func do_another_thing():
    # some steps
    atomic:
       if not holds_lock:
         pass
         return
       critical_section

      # more steps

fair action LockTimeout:
    holds_lock = False
    # calling lock_service.release_lock() is optional, that is an
    # implementation optimization than modeling for correctness.

Btw, the spec might be slightly simpler if lock_service.acquire_lock() returned a lock that you store as a state variable. The holds_lock will be within the lock record. But for now, start with whatever is the simplest

Thanks!, it's similar to what i've been doing with. I didn't realize that i need a pass to activate the block, but it makes sense it needs some statement execution to be enabled.
In my actual model there are several more lines and i'd like to model failing at any point, so it gets a bit tedious to check "holds_lock" everywhere. Implementing try/except makes sense to me, but maybe with different terminology. It's up to the author to think about if the model reflects reality ?.

In a real implementation, isn't the lock always checked (either explicitly to check if the lock hasn't timeout or implicitly where the individual operations have a much shorter timeout compared to the lock timeout) before any critical operation?


Markdown and new lines

Is your feature request related to a problem? Please describe.
It isn't, us bot devs would really like if we had part-Markdown support (bold, underline, strike through, italic) and \n new lines because none of that works now.
Describe the solution you'd like
Adding Markdown and \n support to DogeHouse chat
Describe alternatives you've considered
Making your own syntax for bold, italic etc.text
Additional context
If you send a message using a bot and \n is present, it just makes a space instead of a new line.

I don't think @benawad will go with \n, the other ones seem doable, @benawad ?

Why not newline?

Also half-duplicate #1564

@BronzW \n is horrible for a newline, we'll probably go with your recommendation of shift+enter
and the half-duplicate is very minor

Well not for bots maybe? It won't show \n, it will be converted by JavaScript. The thing is that dogehouse chat doesn't support that as I think it needs white-space: pre-wrap to be added to show new lines.

exactly

test

ofsho#3727


Training code release？

nice work， do you have  plan to release the training code?

@LeoXing1996 nice work， do you have plan to release the training code?

Yeah，nice work， do you have plan to release the training code? @zengyh1900 @JoshonSmith @lindahua @hellock

thank you for your interest. training code is here, https://github.com/open-mmlab/PIA/blob/main/train.py


Add a utility function to convert currency.

Current dependencies on/for this PR:

main

PR #10   👈

PR #11

This stack of pull requests is managed by Graphite.

Merge activity

Oct 30, 8:08 PM: Graphite rebased this pull request as part of a merge.


Graph Visualizer cannot be triggered from Graphs

ArangoDb 3.4 RC 1
The URL is always appended with {graph_name}_til/{graph_name}, but nothing happens.

Thank you very much. This issue has already been addressed and is fixed by now.


Warning AA0125 too draconian

No sure if you're interested in opinions like this one, but (unlike some of the other rules) I think this one could be useful if it were configurable or not quite so draconian.
Title
Really poor rule.
Description
The error as given below is not good
{
	"resource": "/c:/.../Customer_List.PageExt.al",
	"owner": "_generated_diagnostic_collection_name_#0",
	"code": "AA0215",
	"severity": 4,
	"message": "The file Customer_List.PageExt.al has an incorrect name. The valid name is CustomerList.PageExt.al.",
	"source": "AL",
	"startLineNumber": 1,
	"startColumn": 21,
	"endLineNumber": 1,
	"endColumn": 41
}

Reason for the rule
You are requiring that the file names be made less readable.
Bad code sample
        {
            "id": "AA0215",
            "action": "None",
            "justification": "Too dumb to exist"
        },

Good code sample
Good and bad practices for fixing the rule
I suggest either a method for specifying exactly the format allowed, or, perhaps, more reasonably accept files that match alphanumeric characters and ignore most other characters.
Remarks

Rule AA0125 does exactly what it was created for. According to the description of the rule "Follow the best practices for naming"
https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/analyzers/codecop-aa0215-followfilenameguide
The rule is part of the CodeCop. "CodeCop is an analyzer that enforces the official AL Coding Guidelines."
https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/analyzers/codecop
I would suggest leaving this rule unchanged.
If you do not want to follow the official guidelines you have to disable the rule as you did in your 'Bad code sample'.
If you still want to archive your file name pattern you could use the VS Code extension 'waldo's CRS AL Language Extension', for example.
Add

"CRS.FileNamePattern": "<ObjectName>.<ObjectTypeShortPascalCase>.al",
"CRS.FileNamePatternExtensions": "<ObjectName>.<ObjectTypeShort>Ext.al",
"CRS.FileNamePatternPageCustomizations": "<ObjectName>.<ObjectTypeShort>Cust.al",
"CRS.OnSaveAlFileAction": "Rename"

to your settings.json, and you are good to go. You have to name your objects accordingly, of course.

Indeed. I would like to follow the intent of the rules, ie: Improve readability etc etc. And Waldo's extension is definitely a sufficient substitute.
But, when formulating this exact rule Microsoft only asked what pieces should be included (eg: object numbers) not minutia like the exact formatting of the name "Upd. Disc.% on Contract" hence my suggestion.

Hello,
This Rule used to work for us but today with the AL vscode estension 5.0 for BC 16, it requires to name the file with the company affix. If you check the styleguide, the nameing example with a Prefix on it  omitt the prefix when naming the file. This case now gve you a wraning and i think it should not.

there's also suffix allowed in the naming conventions which isn't reflected in either the Warning AA0125 or the docs
https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/compliance/apptest-prefix-suffix
this rule has good intentions, but the execution could be improved

What about when you have more than 1 object on the same file? It's not possible? For me it's very useful. For example, a table with enum and its page.

@jpagessummar Microsoft are saying you should never do this.
Basically, if you have even a slightly larger than a trivial extension the "go-to XYZ" functions of the AL-extension get very, very, slow, so it's more effective to switch to the built in filename search of vscode. For this to work reasonably you have to name the files to match their contents. I know it would be nicer if Microsoft fixed the contextual searching in their AL extension, but I don't see them bothering to.

Thanks for reporting this issue. Sorry we haven’t completed it yet, but we’ve had to prioritize elsewhere. We’re planning to give the CodeCop engine and its rules an overhaul in a future major release. Thanks for your patience.
Going forward we will not track progress on CodeCop issues here on GitHub. Hence, we are closing this issue.


[bug]: shadcn website light/dark toggle broken

Describe the bug
I had the docs open then started using the theme toggle on the website to see what certain blocks/components would look like in dark mode. After that I set it back to light mode and stepped away. Then this video happened, please be warned it flashes very fast, so I am wrapping the link that way there is no chance it will auto-play when viewing this issue.
https://github.com/user-attachments/assets/757feda6-8c21-44f6-9f6b-854ec58a698a
Not sure if this is an issue with the site or something weird with next-themes but I figured I would make a bug report here to let you know regardless.
Affected component/components
None, this is the shadcn site
How to reproduce
Go to components page.
Toggle themes ~10 times
Leave on light mode
???
(this was all I did)
Codesandbox/StackBlitz link
No response
Logs
No response
System Info
Windows 10, Msft Edge

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

Has anyone been able to successfully reproduce this bug? Even when I use the same Windows 10 and Edge browser, I cannot replicate the bug.

@ejzeronimo
Is this bug easily reproducible on ejzeronimo’s computer? I tried about ten times but couldn’t reproduce it, so I’m curious about how frequently it occurs.


add error page

Coverage decreased (-0.2%) to 38.808% when pulling de809ceffa222e45cbd80029fbc0fed0863ff947 on 40huo:master into 69efcd20aad830f665d58c0200c1c64d8205d765 on wufeifei:master.

Python 3 的检测 binary 还有点问题，我再改一个 commit

Coverage increased (+0.1%) to 39.157% when pulling 0638b2623b03b4874b0919662375dc5671b807b5 on 40huo:master into 69efcd20aad830f665d58c0200c1c64d8205d765 on wufeifei:master.


printer-app sometimes crashes

Michael, the printer-app sometimes crashes.
I don't even know how to investigate this crash. It would be appropriate if you could give some investigation suggestion.
Describe the bug
printer-app sometimes crashes. There is no 100% reproduce steps.
To Reproduce
Steps to reproduce the behavior:

Install and run legacy-printer-app
Do some add/delete/modify operations
The printer-app crashes and show below message.

System Information:
OS: Ubuntu22.10
Browser: Firefix
Version: pappl-v1.4.x
case1:
$ sudo ./legacy-printer-app -o log-file=/var/log/printer-app/legacy.log -o log-level=debug server
legacy-printer-app: tpp.c:83: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= fifo_min_prio && new_prio <= fifo_max_prio)' failed.
Aborted

case2:
$ sudo ./legacy-printer-app -o log-file=/var/log/printer-app/legacy.log -o log-level=debug server
legacy-printer-app: pthread_mutex_lock.c:438: __pthread_mutex_lock_full: Assertion `e != ESRCH || !robust' failed.
Aborted

This is the backtrace for crashing case 3
....
[Thread 0x7fffcb7fe640 (LWP 115958) exited]
[New Thread 0x7fffcb7fe640 (LWP 115962)]
[Thread 0x7fffcb7fe640 (LWP 115962) exited]

The futex facility returned an unexpected error code.

Thread 2 "legacy-printer-app" received signal SIGABRT, Aborted.
[Switching to Thread 0x7ffff5a26640 (LWP 109993)]
__pthread_kill_implementation (no_tid=0, signo=6, threadid=140737314448960) at ./nptl/pthread_kill.c:44
44	./nptl/pthread_kill.c: No such file or directory.

(gdb) thread apply all bt

Thread 169 (Thread 0x7ffff4a24640 (LWP 113839) "libusb_event"):
#0  0x00007ffff7b6cdbf in __GI___poll (fds=0x7ffff4a23aa0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x00007ffff6ad24c2 in ?? () from /lib/x86_64-linux-gnu/libusb-1.0.so.0
#2  0x00007ffff7ae8ac3 in start_thread (arg=<optimised out>) at ./nptl/pthread_create.c:442
#3  0x00007ffff7b7aa40 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

Thread 2 (Thread 0x7ffff5a26640 (LWP 109993) "legacy-printer-app"):
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=140737314448960) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=140737314448960) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=140737314448960, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff7a96476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff7a7c7f3 in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff7add3dc in __libc_message (action=do_abort, fmt=0x7ffff7c2f7b1 "%s", fmt=0x7ffff7c2f7b1 "%s", action=do_abort) at ../sysdeps/posix/libc_fatal.c:155
#6  0x00007ffff7add6f0 in __GI___libc_fatal (message=message@entry=0x7ffff7c31d28 "The futex facility returned an unexpected error code.\n") at ../sysdeps/posix/libc_fatal.c:164
#7  0x00007ffff7ae51a6 in futex_fatal_error () at ../sysdeps/nptl/futex-internal.h:87
#8  __futex_lock_pi64 (futex_word=futex_word@entry=0x7ffff0006178, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at ./nptl/futex-internal.c:203
#9  0x00007ffff7aebc7f in __pthread_mutex_lock_full (mutex=0x7ffff0006178) at ./nptl/pthread_mutex_lock.c:429
#10 0x00007ffff7aebfb5 in ___pthread_mutex_lock (mutex=mutex@entry=0x7ffff0006178) at ./nptl/pthread_mutex_lock.c:86
#11 0x00007ffff7ca18df in pappl_dnssd_query_cb (rdata=<optimised out>, rdlen=<optimised out>, context=0x7ffff0006170, flags=<optimised out>, rrtype=<optimised out>, rrclass=<optimised out>, fullName=<optimised out>, event=<optimised out>, protocol=<optimised out>, interfaceIndex=<optimised out>, browser=<optimised out>) at device-network.c:742
#12 0x00007ffff713857c in avahi_record_browser_event () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#13 0x00007ffff7134286 in ?? () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#14 0x00007ffff75f86a5 in dbus_connection_dispatch () from /lib/x86_64-linux-gnu/libdbus-1.so.3
#15 0x00007ffff713ac74 in ?? () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#16 0x00007ffff7149c88 in avahi_simple_poll_dispatch () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#17 0x00007ffff7149f75 in avahi_simple_poll_loop () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#18 0x00007ffff714a04b in ?? () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#19 0x00007ffff7ae8ac3 in start_thread (arg=<optimised out>) at ./nptl/pthread_create.c:442
#20 0x00007ffff7b7aa40 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

Thread 1 (Thread 0x7ffff5a2d340 (LWP 109989) "legacy-printer-app"):
--Type <RET> for more, q to quit, c to continue without paging--
#0  0x00007ffff7b6cdbf in __GI___poll (fds=fds@entry=0x5555555ac69c, nfds=3, timeout=29969) at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x00007ffff7b8a6e2 in __poll_chk (fds=fds@entry=0x5555555ac69c, nfds=<optimised out>, timeout=<optimised out>, fdslen=fdslen@entry=256) at ./debug/poll_chk.c:27
#2  0x00007ffff7cc901b in poll (__timeout=<optimised out>, __nfds=<optimised out>, __fds=0x5555555ac69c) at /usr/include/x86_64-linux-gnu/bits/poll2.h:39
#3  papplSystemRun (system=system@entry=0x5555555ab9f0) at system.c:599
#4  0x00007ffff7cb0fe5 in _papplMainloopRunServer (base_name=base_name@entry=0x7fffffffe2d9 "legacy-printer-app", version=version@entry=0x55555556f0a8 "1.0", footer_html=footer_html@entry=0x0, num_drivers=num_drivers@entry=0, drivers=drivers@entry=0x0, autoadd_cb=autoadd_cb@entry=0x0, driver_cb=0x0, num_options=<optimised out>, options=0x7fffffff9d20, system_cb=0x5555555648c0 <_prSystemCB>, data=0x7fffffffbcf0) at mainloop-subcommands.c:806
#5  0x00007ffff7caec3f in papplMainloop (argc=argc@entry=2, argv=argv@entry=0x7fffffffdf28, version=0x55555556f0a8 "1.0", footer_html=footer_html@entry=0x0, num_drivers=num_drivers@entry=0, drivers=drivers@entry=0x0, autoadd_cb=0x0, driver_cb=0x0, subcmd_name=0x0, subcmd_cb=0x0, system_cb=0x5555555648c0 <_prSystemCB>, usage_cb=0x0, data=0x7fffffffbcf0) at mainloop.c:452
#6  0x000055555555b952 in prRetroFitPrinterApp (printer_app_config=printer_app_config@entry=0x7fffffffdd50, argc=argc@entry=2, argv=argv@entry=0x7fffffffdf28) at pappl-retrofit/pappl-retrofit.c:56
#7  0x000055555555b0df in main (argc=2, argv=0x7fffffffdf28) at legacy-printer-app.c:191

I will post the backtrace of case1 and case2 once I encounter them again.

Hmm, this looks like a locking issue in the DNS-SD code...

Might be related to #299.

Please re-test with the current 1.4.x branch.

Michael, the issue is not fixed. I used the current 1.4.x branch and the avahi-daemon is running.
The printer-app crashed again.
[Thread 0x7ffff5225640 (LWP 41619) exited]
legacy-printer-app: pthread_mutex_lock.c:438: __pthread_mutex_lock_full: Assertion `e != ESRCH || !robust' failed.

Thread 2 "legacy-printer-app" received signal SIGABRT, Aborted.
[Switching to Thread 0x7ffff5a26640 (LWP 39953)]
__pthread_kill_implementation (no_tid=0, signo=6, threadid=140737314448960) at ./nptl/pthread_kill.c:44
44	./nptl/pthread_kill.c: No such file or directory.
(gdb) bt
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=140737314448960) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=140737314448960) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=140737314448960, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff7a96476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff7a7c7f3 in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff7a7c71b in __assert_fail_base (fmt=0x7ffff7c31150 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7ffff7c2d5a3 "e != ESRCH || !robust",
    file=0x7ffff7c2d58e "pthread_mutex_lock.c", line=438, function=<optimised out>) at ./assert/assert.c:92
#6  0x00007ffff7a8de96 in __GI___assert_fail (assertion=assertion@entry=0x7ffff7c2d5a3 "e != ESRCH || !robust", file=file@entry=0x7ffff7c2d58e "pthread_mutex_lock.c", line=line@entry=438,
    function=function@entry=0x7ffff7c35840 <__PRETTY_FUNCTION__.1> "__pthread_mutex_lock_full") at ./assert/assert.c:101
#7  0x00007ffff7aebed1 in __pthread_mutex_lock_full (mutex=0x7ffff0000f78) at ./nptl/pthread_mutex_lock.c:438
#8  0x00007ffff7aebfb5 in ___pthread_mutex_lock (mutex=mutex@entry=0x7ffff0000f78) at ./nptl/pthread_mutex_lock.c:86
#9  0x00007ffff7ca18ec in pappl_dnssd_query_cb (rdata=<optimised out>, rdlen=<optimised out>, context=0x7ffff0000f70, flags=<optimised out>, rrtype=<optimised out>, rrclass=<optimised out>,
    fullName=<optimised out>, event=<optimised out>, protocol=<optimised out>, interfaceIndex=<optimised out>, browser=<optimised out>) at device-network.c:740
#10 0x00007ffff713857c in avahi_record_browser_event () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#11 0x00007ffff7134286 in ?? () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#12 0x00007ffff75f86a5 in dbus_connection_dispatch () from /lib/x86_64-linux-gnu/libdbus-1.so.3
#13 0x00007ffff713ac74 in ?? () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#14 0x00007ffff7149c88 in avahi_simple_poll_dispatch () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#15 0x00007ffff7149f75 in avahi_simple_poll_loop () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#16 0x00007ffff714a04b in ?? () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#17 0x00007ffff7ae8ac3 in start_thread (arg=<optimised out>) at ./nptl/pthread_create.c:442
#18 0x00007ffff7b7aa40 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

Once again
[Thread 0x7fffe7fff640 (LWP 194915) exited]
legacy-printer-app: tpp.c:83: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= fifo_min_prio && new_prio <= fifo_max_prio)' failed.

Thread 2 "legacy-printer-app" received signal SIGABRT, Aborted.
[Switching to Thread 0x7ffff59fb640 (LWP 191912)]
__pthread_kill_implementation (no_tid=0, signo=6, threadid=140737314272832) at ./nptl/pthread_kill.c:44
44	./nptl/pthread_kill.c: No such file or directory.
(gdb) bt
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=140737314272832) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=140737314272832) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=140737314272832, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff7a6b476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff7a517f3 in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff7a5171b in __assert_fail_base (fmt=0x7ffff7c06150 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n",
    assertion=0x7ffff7c06fc8 "new_prio == -1 || (new_prio >= fifo_min_prio && new_prio <= fifo_max_prio)", file=0x7ffff7c0261d "tpp.c", line=83, function=<optimised out>) at ./assert/assert.c:92
#6  0x00007ffff7a62e96 in __GI___assert_fail (assertion=assertion@entry=0x7ffff7c06fc8 "new_prio == -1 || (new_prio >= fifo_min_prio && new_prio <= fifo_max_prio)",
    file=file@entry=0x7ffff7c0261d "tpp.c", line=line@entry=83, function=function@entry=0x7ffff7c0a8c0 <__PRETTY_FUNCTION__.0> "__pthread_tpp_change_priority") at ./assert/assert.c:101
#7  0x00007ffff7ac6139 in __GI___pthread_tpp_change_priority (previous_prio=previous_prio@entry=-1, new_prio=new_prio@entry=7910) at ./nptl/tpp.c:83
#8  0x00007ffff7ac09cd in __pthread_mutex_lock_full (mutex=0x7ffff001e0a8) at ./nptl/pthread_mutex_lock.c:555
#9  0x00007ffff7c7a292 in pappl_dnssd_query_cb (browser=0x7ffff0054f60, interfaceIndex=2, protocol=1, event=AVAHI_BROWSER_NEW,
    fullName=0x7ffff0051f5c "Canon\\032iR-ADV\\032C3835\\032\\040cf\\05861\\05848\\041._pdl-datastream._tcp.local", rrclass=1, rrtype=16, rdata=0x7ffff0051fb4, rdlen=426,
    flags=AVAHI_LOOKUP_RESULT_MULTICAST, context=0x7ffff001e0a0) at device-network.c:740
#10 0x00007ffff710d57c in avahi_record_browser_event () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#11 0x00007ffff7109286 in ?? () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#12 0x00007ffff75cd6a5 in dbus_connection_dispatch () from /lib/x86_64-linux-gnu/libdbus-1.so.3
#13 0x00007ffff710fc74 in ?? () from /lib/x86_64-linux-gnu/libavahi-client.so.3
#14 0x00007ffff711ec88 in avahi_simple_poll_dispatch () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#15 0x00007ffff711ef75 in avahi_simple_poll_loop () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#16 0x00007ffff711f04b in ?? () from /lib/x86_64-linux-gnu/libavahi-common.so.3
#17 0x00007ffff7abdac3 in start_thread (arg=<optimised out>) at ./nptl/pthread_create.c:442
#18 0x00007ffff7b4fa40 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

Additional info: A usb printer is connected to the PC and ipp-usb is running.

I'm not sure what is going on here - the only function that calls pthread_mutex_lock/unlock is the query callback, and those calls are balanced, so this absolutely should not fail.
Can you try building PAPPL manually and then run:
testsuite/testpappl --list

to test the papplDeviceList API?

Step2:
Add more logs to output the device's initialization, lock, unlock and free.
In function `pappl_dnssd_get_device()'
 if ((device->fullName = strdup(fullName)) == NULL)
  {
    cupsArrayRemove(devices, device);
    return (NULL);
  }

#ifdef DEBUG
    fprintf(stderr, "[%p] TESS:pappl_dnssd_get_device:new device[%p],[%s]\n", (void *)pthread_self(), (void*)device, device->fullName);
#endif

In function pappl_dnssd_query_cb()
#ifdef DEBUG
if (device != NULL)
    fprintf(stderr, "[%p] TESS:pappl_dnssd_query_cb:lock device[%p],[%s]\n", (void *)pthread_self(), (void*)device, device->fullName);
#endif

// Save the make and model and IEEE-1284 device ID...
_pappl_pthread_mutex_lock(&device->mutex);
device->device_id = strdup(device_id);
device->make_and_model = strdup(ty);
_pappl_pthread_mutex_unlock(&device->mutex);

In function pappl_dnssd_free()
// Free all memory...
#ifdef DEBUG
    fprintf(stderr, "[%p] TESS:pappl_dnssd_free:free device[%p],[%s]\n", (void *)pthread_self(), (void*)d, d->fullName);
#endif

free(d->name);
free(d->domain);
free(d->fullName);
free(d->make_and_model);
free(d->device_id);
free(d->uuid);
_pappl_pthread_mutex_destory(&d->mutex);
free(d);

For normal/ok case, the output is as below, the procedure is [new device]->[lock/unlock device]->[free device]
Line 57533: [0x7febb45e1640] TESS:pappl_dnssd_get_device:new device[0x7febac038700],[Canon\032LBP151._pdl-datastream._tcp.local]
Line 57757: [0x7febb45e1640] TESS:pappl_dnssd_query_cb:lock device[0x7febac038700],[Canon\032LBP151._pdl-datastream._tcp.local]
Line 57758:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_lock ret=[0]
Line 57759:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_unlock ret=[0]
Line 57760: [0x7febb45e1640] TESS:pappl_dnssd_query_cb:lock device[0x7febac038700],[Canon\032LBP151._pdl-datastream._tcp.local]
Line 57761:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_lock ret=[0]
Line 57762:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_unlock ret=[0]
Line 57835: [0x7febb3de0640] TESS:pappl_dnssd_free:free device[0x7febac038700],[Canon\032LBP151._pdl-datastream._tcp.local]

For crash/NG case, the output is as below, and the procedure is [new device]->[free device]->[lock/unlock device]
Line 80801: [0x7febb45e1640] TESS:pappl_dnssd_get_device:new device[0x7febac040d20],[Canon\032\032\04088\058c4\0588c\041._pdl-datastream._tcp.local]
Line 80889: [0x7febb3de0640] TESS:pappl_dnssd_free:free device[0x7febac040d20],[Canon\032\032\04088\058c4\0588c\041._pdl-datastream._tcp.local]
Line 81071: [0x7febb45e1640] TESS:pappl_dnssd_query_cb:lock device[0x7febac040d20],[A���]
Line 81072:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_lock ret=[22]
Line 81073:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_unlock ret=[22]
Line 82742: [0x7febb45e1640] TESS:pappl_dnssd_query_cb:lock device[0x7febac040d20],[A���]
Line 82743:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_lock ret=[22]
Line 82744:0x7febb45e1640/pappl_dnssd_query_cb: pthread_mutex_unlock ret=[22]

It's difficult for me to investigate why the device is freed before lock/unlock, so please help.

Can you try building PAPPL manually and then run:
testsuite/testpappl --list

to test the papplDeviceList API?

The crash issue cannot be reproduced by using "testsuite/testpappl --list".

If I call the papplDeviceList() 100 times in the testpappl, then the issue can be reproduced.
else if (!strcmp(argv[i], "--list"))
{
      for (int i = 0; i < 100; i++)
      {
        sleep(10);
        papplDeviceList(PAPPL_DEVTYPE_ALL, device_list_cb, NULL, device_error_cb, NULL);
      }
      return (0);
}

Michael, from the current investigation, it seems the call to function avahi_service_browser_free() in the function pappl_dnssd_list() does not stop the browsing. I tried to investigate, but I'm not familiar with Avahi's interface, so I can't figure out any result.
Do you have any ideas? Could this be avahi bug?

Certainly could be. I'll see what I can figure out on my end now that I have an idea of how to reproduce.

OK, I've been trying to reproduce on Ubuntu 22.04 LTS without success. 23.10 has a slightly newer version of Avahi, so maybe there is a bug there?
@tillkamppeter Any idea what changes exist in Avahi between Ubuntu 22.04 and 23.10?

Hi, @alexpevzner, we may encounter a avahi bug. But I cannot figure out any result. Can you take a look?

After learning avahi interfaces and looking at how cups dnssd backend is implemented, I think this is not a bug of avahi, but a bug of pappl.
Reason
The function avahi_record_browser_new()  is called in the function pappl_dnssd_get_device(). But the record browser was never freed. So even the dnssd devices is freed, but the bowering isn't stopped.
Solution
After trying to make the following change, this crash issue cannot be reproduced.
(1) In the function pappl_dnssd_list()
_papplDNSSDLock();         ★ add
// Free memory and return...
cupsArrayDelete(devices);
_papplDNSSDUnlock();     ★ add

(2) In the function pappl_dnssd_free()
free(d->uuid);
if (d->ref)                                  ★ add
    avahi_record_browser_free(d->ref);        ★ add
_pappl_pthread_mutex_destory(&d->mutex);
free(d);

@michaelrsweet Please have a check.

[v1.4.x 3ac4dfd] Free DNS-SD query when freeing device (Issue #302)
[v1.4.x b05d62c] Lock/unlock around free for Avahi (Issue #302)
Needed to make the code conditional (mDNSReponder or Avahi), but this makes sense. I put the lock/unlock in the pappl_dnssd_free function, and only for Avahi since mDNSResponder doesn't need it.
PAPPL 2.0 won't need this change since the CUPS DNS-SD APIs (new in CUPS 2.5/3.0) take care of this automatically...


scapy error

Try to start with python3 simple_IMSI-catcher.py --sniff

Traceback (most recent call last):
File "/home/nukikal/IMSI-catcher/simple_IMSI-catcher.py", line 607, in
from scapy.all import sniff, UDP
File "/usr/local/lib/python3.9/dist-packages/scapy/all.py", line 16, in
from scapy.arch import *
File "/usr/local/lib/python3.9/dist-packages/scapy/arch/init.py", line 27, in
from scapy.arch.bpf.core import get_if_raw_addr
File "/usr/local/lib/python3.9/dist-packages/scapy/arch/bpf/core.py", line 30, in
LIBC = cdll.LoadLibrary(find_library("libc"))
File "/usr/lib/python3.9/ctypes/util.py", line 341, in find_library
_get_soname(_findLib_gcc(name)) or _get_soname(_findLib_ld(name))
File "/usr/lib/python3.9/ctypes/util.py", line 147, in _findLib_gcc
if not _is_elf(file):
File "/usr/lib/python3.9/ctypes/util.py", line 99, in _is_elf
with open(filename, 'br') as thefile:
FileNotFoundError: [Errno 2] No such file or directory: b'liblibc.a'

grgsm_livemon is running, scapy and scapy3 are installed

Same as #121
I suggest you to use an other version of python.
https://bbs.archlinux.org/viewtopic.php?id=261816

your suggestion is wrong.
 cdll.LoadLibrary(find_library("libc")) used to work in < python 3.9 by a mistake.
The correct code is to call with "lib" prefix:
ctypes.cdll.LoadLibrary(find_library("c"))
For more details, see the following https://bugs.python.org/issue42580
the bug is also fixed in the scapy-2.4.5 for sure.
Please remove your "python < 3.9" requirement in the main page.

I haven't, but i tried scapy with python 3.10. it works. So catcher should work too


Merge Feature/Extensions into Main

As the title suggests, we want to merge the feature/extensions branch into the main branch.

[Triage] This issue is meant to track progress of merging feature/extensions branch into the main branch.

This issue is an exploratory work of what the merge from the feature branch into main would look like. From this, we can estimate work needed to bring this to closure and plan for it (it might result in sub-issues/tasks)


Update OrderStateChangeEventListener.php

Return type is missing.
Method with always return array type. Just define return type as array in the method.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-16987
Please use this issue to track the state of your pull request.

Hi @RakeshJesadiya
thanks for your contribution


Prefer data type objects over character codes

Refs https://github.com/chainer/chainer/pull/4350

jenkins, test this please

LGTM!


Retrieve buffers for instance submission

Adds a new component to the HTTP solver that retrieves the ERC20 buffers available to the solver. This is useful to take advantage of a recent change to the Mip solver: the solution is checked in the solver for correctness and is not sent to the driver if it cannot be matched after considering the buffers.
For now the retrieved buffer is unused. Later, it will be included in the data sent to the various solvers.
Test Plan
Ignored unit tests:
$ export NODE_URL_RINKEBY=...
$ cargo test -- solver::http_solver::buffers --ignored --nocapture
running 2 tests
Buffers: {
    0xc7ad46e0b8a400bb3c915120d284aafba8fc4735: Ok(
<PHONE_NUMBER>5432915195333071331,
    ),
    0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee: Ok(
        9,
    ),
    0xc778417e063141139fce010982780140aa0cd5ab: Ok(
<PHONE_NUMBER>00631341,
    ),
    0xbadbadbadbadbadbadbadbadbadbadbadbadbadb: Err(
        Erc20(
            MethodError {
                signature: "balanceOf(address):(uint256)",
                inner: AbiDecode(
                    InvalidName(
                        "please ensure the contract and method you're calling exist! failed to decode empty bytes. if you're using jsonrpc this is likely due to jsonrpc returning `0x` in case contract or method don't exist",
                    ),
                ),
            },
        ),
    ),
}
test solver::http_solver::buffers::test::retrieves_buffers_on_rinkeby ... ok
test solver::http_solver::buffers::test::retrieving_buffers_not_affected_by_eth ... ok

Some changes from the previous reviews:

added unit tests
added logic to handle the eth address
directly hand over the error when retrieving the buffers


Automatically determine default container name when not given

Background
kubectl logs -n <namespace> <name> first tries to GET the pod resource requested, if it sees
there's only one container in it, it will then GET:
http://<api>/api/v1/namespaces/<namespace>/pods/<name>/log
Without any container=... query param. I believe it is expected that
the logs for the first (and only) container should simply be returned in that case.
When kubectl logs -n <namespace> <name> sees there's more than one
container, it will simply tell the user to choose a container and so
the next time the user runs kubectl logs with the container name the
query param will be correct.
Issue
static-kas works fine in the latter case, but breaks down in the first
case because it always expected there to be a container query param.
Solution
static-kas will now try to determine the default container name for the
pod's yaml in the absence of the container query param

Will write tests once you give me a green light for this

Try a pod with only one container, e.g. oc logs -n openshift-authentication-operator authentication-operator-<replicaset-id>-<pod-id> (against static-kas)

Though PR is still valid IMO

Ah okay, now I understand

Will write tests sometime later, it's slightly tricky due to limitations of the k8s http Request wrapper object

Will write tests sometime later, it's slightly tricky due to limitations of the k8s http Request wrapper object

Just using a standard http client against something like /api/v1/namespaces/$namespace/pods/$pod/log would also be fine

thanks!


Monitor XFS shutdown

Related kernel error messages are as below.
kernel: XFS (dm-4): Internal error xfs_iunlink_remove at line 2038 of file fs/xfs/xfs_inode.c.  Caller xfs_ifree+0x33/0x130 [xfs]
kernel: XFS (dm-4): Corruption detected. Unmount and run xfs_repair
kernel: XFS (dm-4): xfs_inactive_ifree: xfs_ifree returned error -117
kernel: XFS (dm-4): xfs_do_force_shutdown(0x1) called from line 1788 of file fs/xfs/xfs_inode.c.  Return address = 000000009d022bf1
kernel: XFS (dm-4): I/O Error Detected. Shutting down filesystem
kernel: XFS (dm-4): Please umount the filesystem and rectify the problem(s)

/ok-to-test

/retest-required

/retest

/remove-lifecycle stale
/lgtm

/remove-lifecycle stale

@wenjianhn,
Please rebase the PR


code is error when i am giving the path of audio file in real time transcription code

code is error when i am giving the path of audio file in real time transcription code.

This is not supported currently. You need to retrieve the audio stream from the audio file and make sure the correct encoding is selected in the live options.


tooling perf: range.DebugCode reading file without checks may have impact on ability to debug default fsi.exe session

I wonder if this is why I'm seeing "evaluating local variables..." in VS while debugging fsi.exe (the default session doesn't have a valid file name AFAIU):

It seems a bit smoother when working with FSharp.sln fsi.exe but not tried under trace / profiling, if someone with better hardware / tooling could give it a shot.
I'm stepping through the code I've highlighted there: https://github.com/Microsoft/visualfsharp/issues/6578#issuecomment-485181141
edit: we may want to introduce a "going to read this file" monad or something in the code to avoid this, if it would make any sense (can't author it, not sure if it fits compiler or desired idioms).

this is the visible side effect of this PR.

Thanks for this.


Add flag for no on screen display

Hides the "Seek 00:00:00 / hh:mm:ss" on screen text

Thanks for this, sorry about the delay. I've merged in #6 which should include this functionality.


[Bug]: sharePositionOrigin crash although a valid Rect is being used

Platform
iPadOS 17.6.1, macOS 18
Plugin
share_plus
Version
10.1.0
Flutter SDK
3.24.2
Steps to reproduce
I'm getting crash reports but I cannot reproduce it on my own. It works correctly on the iPad simulators. The sharePositionOrigin Rect that I am sending is within bounds (as you can see in the error messages) but the error happens nonetheless.
Here are some examples of errors:
MethodChannelShare.shareXFiles:
PlatformException(error, sharePositionOrigin: argument must be set, {{222, 739}, {300, 92}} must be non-zero and within coordinate space of source view: {{0, 0}, {1133, 744}}, null, null)
MethodChannelShare.shareFilesWithResult:
PlatformException(error, sharePositionOrigin: argument must be set, {{362, 701}, {300, 92}} must be non-zero and within coordinate space of source view: {{0, 0}, {1024, 768}}, null, null)
Code Sample
// This is how I am computing the sharePositionOrigin Rect

final RenderBox? box = context.findRenderObject() as RenderBox?;
final Rect sharePositionOrigin = box!.localToGlobal(Offset.zero) & box.size;

Logs
--

Flutter Doctor
[✓] Flutter (Channel stable, 3.24.2, on macOS 14.2.1 23C71 darwin-arm64, locale en-RO)
    • Flutter version 3.24.2 on channel stable at /Users/ka/dev/tools/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4cf269e36d (8 weeks ago), 2024-09-03 14:30:00 -0700
    • Engine revision a6bd3f1de1
    • Dart version 3.5.2
    • DevTools version 2.37.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/ka/Library/Android/sdk
    • Platform android-34, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)

[✓] VS Code (version 1.94.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

I think the problem is that 701 + 92 > 768, so CGRectContainsRect will return false and so throw the exception.

@miquelbeltran I was assuming the coordinates from the error log were the corners of the Rect.
Any suggestion for a better way to get a valid sharePositionOrigin? I'd prefer not to give a static Rect in the middle of the screen but a Rect close to the widget that was clicked.

I'd prefer not to give a static Rect in the middle of the screen but a Rect close to the widget that was clicked.

I think wrapping the target widget with a builder and obtaining the coordinates from the inmediate render object, just like the example project.

I think wrapping the target widget with a builder and obtaining the coordinates from the inmediate render object, just like the example project.

This is what I am currently doing (wrapping with a Builder) but I get the crash reports so it seems this approach does not work in all cases.

1024 x 768 (which was is reported as the controller.view in the iOS obj-c code) look like iPad mini & 2nd Gen iPads. Can you try your app on a simulator for those smaller devices?

@miquelbeltran I have managed to reproduce this by placing the share button in a scroll view at the edge of the screen.
I've updated the code that computes the sharePositionOrigin to fall back to a rectangle in the middle of the screen if the computed rectangle does not fit the available screen.
Rect sharePositionOrigin(BuildContext context) {
  final RenderBox? box = context.findRenderObject() as RenderBox?;
  final Rect candidatePositionOrigin =
      (box!.localToGlobal(Offset.zero) & box.size);
  final double width = MediaQuery.sizeOf(context).width;
  final double height = MediaQuery.sizeOf(context).height;
  if (candidatePositionOrigin.left >= 0 &&
      candidatePositionOrigin.right < width &&
      candidatePositionOrigin.top >= 0 &&
      candidatePositionOrigin.bottom < height) {
    return candidatePositionOrigin;
  } else {
    return Rect.fromCenter(
      center: Offset(width / 2, height / 2),
      width: 100,
      height: 100,
    );
  }
}


How change font-align?

Thank you very much for providing a great product.
My question is about font-align. I wanna change  location of date to left.
like this:

So, i tried editing custom css file.

Actually, i have fixed typo.(CS2 -> CX2, : -> ;)
but, it can not work. Could you please let me know how can i change date location?
For reference, I am a beginner in css.
And, in my case, all images of wiki are not visible. Could you please update so i can see it?

I have solved this my self.
.CX2 .slotHeader {
flex-direction: row;
}


Question: (Huggingface API) Classification Loss for transformers.LukeForEntitySpanClassification

In transformers.LukeForEntitySpanClassification, the loss is calculated from labels of shape (batch_size, entity_length) and in range [0, ..., config.num_labels - 1]. I did not see in the source code you masked out the loss for padded tokens, nor did you make a special label for padded tokens. So how do you deal with the loss of padded sequences?
Many thanks!

Hi @zhenbangt,
I believe this is an issue in the LukeForEntitySpanClassification head model. But please file an issue to the huggingface repository since this repository does not contain the corresponding code.


Tag v0.2.0 on GitHub

Assuming the 0.2.0 release to npm has been successful, a v0.2.0 should be created and pushed to GitHub.

thank you, done


Transcation to approve does not show minting price

When i click on the minting button the transaction to approve does not show the nft price. It only shows the fees to create token account.
Is it possible to show the price for minting in the transaction to approve?

+1

I think, this is a problem for the Phantom wallet.
And I think they correct this on the new beta. Like showing all transaction what will impact on your balance.


Make tortoise beacon weak coin up-to-date

Motivation

Tortoise beacon weak coin was outdated, so the code didn't even compile. This PR makes it work and adds improvements for it.
Changes

Fix compilation issues
Check VRF of incoming messages
Fix some bugs
Testing basic functionality
Fix unit tests
Add weak coin check to tortoise beacon system test

Test Plan

Unit tests, system tests, manual testing
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

some other things that can be improved:

no reason to store collection of proposals for each round, store only smallest
we have a map for activeRounds, but it is cleaned after each round has ended. we can store only one activeRound as value on WeakCoin

@dshulyak

who is allowed to send vrf proposals?

Everyone who participates in tortoise beacon and whose proposal passes threshold

where do we verify it?

https://github.com/spacemeshos/go-spacemesh/blob/fix/make-weak-coin-up-to-date/tortoisebeacon/weakcoin/handlers.go#L52

no reason to store collection of proposals for each round, store only smallest
we have a map for activeRounds, but it is cleaned after each round has ended. we can store only one activeRound as value on WeakCoin

Yes, I didn't make any optimizations yet before reviewing the code with research, because something may need to be changed after review. If this approach remains as it is, these optimizations need to be done

@nkryuchkov i was trying to figure out if that verification is implemented or not. it seems that https://github.com/spacemeshos/go-spacemesh/blob/77f6e2f5106606995e8a4e7cb23942f2c58b29e2/tortoisebeacon/weakcoin/handlers.go#L91 only verifies that the signature matches miner id (this is also can be improved, miner id can be recovered from signature).

@dshulyak
Yes, this is correct. Also, miner ID should be recovered from signature in tortoisebeacon. Moreover, a check that proposal passes the eligibility threshold needs to be added. Now only the sender checks it (https://github.com/spacemeshos/go-spacemesh/blob/fix/make-weak-coin-up-to-date/tortoisebeacon/weakcoin/weak_coin.go#L134), which is enough for quick testing but not enough for production.
There's a list of what needs to be done in weak coin, feel free to add your thoughts here: https://github.com/spacemeshos/SMIPS/issues/28#issuecomment-887092949

@dshulyak sure

bors merge

bors merge


Can I disable the stable label table?

Mission critical

At this time, users are not able to disable the stable label table.
Snorkel relies on the stable label table to be able to map stable labels to and from other label tables.

👏 👏 👏 👏 👏

#684

Prescience AND art, wrapped into one PR title. Can one nominate oneself the Nobel Prize?

Nevermind.


[FSSDK-9913] chore: update dependencies & fixes from testing

Summary

Update the JS SDK version to released 5.0.0
Corrected follow-on type update changes
Quality of life in dev container updates

Test plan

Unit tests should pass
FSC test should continue to pass
Completed manual user acceptance testing, consuming this branch into a React app

Issues

FSSDK-9913

Developer code review completed.


Partial Signed Transaction Serialisation Format

Will be generating all structs via Protobuf, future serialisation will also use protobuf hex


Update container version to beam-master-20200430

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Python PreCommit

LGTM. Thanks.


add maxSelectionSize to options

:+1: Thanks! Merging...

[Reverse quantum leap](Https://appveyor.com)


Add list of columns for find functions

Default: no select (select *)
With list of columns: select by columns

Reference: http://knexjs.org/#Builder-select

With v0.3.0 there is a before hook that can be used as escape hatch for this.


Multiple jRates in FireFox and Internet Explorer

I have a set up where I call multiple jRates through an Ajax request on the same page (10 to be exact), each is supposed to have a separate rating. The settings are dynamically created with a default value / read only etc. In Chrome there are no problems, every one has it's correct value. In Mozilla FireFox and Internet Explorer the following 9 jRates take the value from the 1st one, to which I can not override even if I hard code a number. I have tried everything from spacing out the divs to making them separate scripts, nothing is working. I am not sure why Google Chrome has no problem with this but the other two do, if this fails I will just have to use images, but I would like to resolve the issue.
There is also another jRate called WAY earlier in the script that has no problems at all, if that is any help. The 10 that are problematic are called one after the other, each within a respective span inside a paragraph tag. I am not sure if the consecutive calls are causing it to fail or if there is another underlying factor.
Thank you for your time.

Hey is it easy or hard to make this rating plugin work on a board like phpbb? In other words I'm looking to make it work for each seperate row like you did.

It is actually pretty easy, though the jRate function itself is a little touchy when i comes to multiple calls. For example, you cannot establish all rules such as size, color, etc. in one call. So each time you call the function, you have to establish this, which gets a little repetitive.  The calls themselves are located after a query has been made to the database, so all that is left to do is call the function like normal (through an echo) and plug in the variables where they need to be.

Prince why did you close this? You didn't provide an answer to the OP.

Though I am more than displeased that this was closed without either answering OR even a comment saying anything. After an entire morning of experimenting I have found the issue. My current versions of FireFox and IE are having trouble with the SVG's directly. Since the plugin creates each star via SVG you can see this is a problem. The two problematic browsers seem to have some sort of capacity, whatever the first coordinates / color is, it replicates that through each and every svg, hence why I am getting the wrong result. This is not a problem with jRate directly, it seems to be a browser issue. Though the method jRate uses to create the stars is the problem (though I don't blame them for that, this is on IE and FireFox).
I have no solution for this at this time, I am seeking alternatives.
FireFox: 38.0.5
IE: 11.0.21

@Krazyhawk1993 @master412160 Sorry, I thought that @Krazyhawk1993  got a solution. Can you provide a sample (jsfiddle, plunker or codepen) to work on?

I would but I have never used those, and after 20 mins couldn't get jRate to work at all in jsfiddle.

@Krazyhawk1993 .. you can share your sample code through jsfiddle or pastebin. If its not working also, we are fine. We will fix the code and let you know.

IE and firefox older version is not supporting svg. so, i am closing this issue. Let us know if you are facing any issue in latest browser version.


Update slack info & times on tutorials post

Added specific blocks of time for each tutorial. Removed Slack link since we'll be adding people after they register.

@vsoch if you have time to expedite, that would be great; but ok if not! the twitterverse is asking for these details :)

ok spaces are tweaked!

haha it just made the column smaller! But I still think this is easier to read since the second time isn't truncated. Let's ship it!

thank you very much

thank you! :t-rex: :avocado:


feat: Change ping module to danielzzz/node-ping

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
This PR changes the ping module from ping-lite to danielzzz/node-ping. This fixes the hard coded ping path and also makes implementing packet size easier.
Fixes #2126
Type of change
Please delete any options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings

Not sure if it is worth it, but it could be a good idea to convert ping-lite.js to the ES6 format for class deffinitions, i.e using the class keyword to keep it in line with the rest of the project.

Not sure if it is worth it, but it could be a good idea to convert ping-lite.js to the ES6 format

It will be beautiful and good. However, if it is just for Uptime Kuma, maybe it is not worth.
Just brainstorming, maybe you can make your own ping library which based on this code, Uptime Kuma and other projects would benefit from it. In addition to ES6 format, you could also add support for async/await etc.
Fyi, the current Uptime Kuma's ping-lite.js is a modified version of this:
https://github.com/ben-bradley/ping-lite

Just did a quick search for node ping modules. I did find this one https://github.com/danielzzz/node-ping that seems to support most things we need. Did you see this when creating the ping monitor? (just wondering in case there was a reason you didn't use it)

https://github.com/danielzzz/node-ping
Yes, as I remember that I tested it and it only returns isAlive, so I skipped this.

https://github.com/nospaceships/node-net-ping
This one is not using ping command, but it using raw-socket. It also means that native build tools are needed. It will be a disaster for non-Docker users.

Edit: Just read danielzzz/node-ping's README again, well, the callback result difference to the promise one... The callback result is always isAlive. The promise result is a result object.

In which case, I will work on implementing this module using the promise based implementation if that is OK with you.

Edit: Just read danielzzz/node-ping's README again, well, the callback result difference to the promise one... The callback result is always isAlive. The promise result is a result object.

In which case, I will work on implementing this module using the promise based implementation if that is OK with you.

Yes, looked that its platform handling, I think it has better handling and no hardcoded path. We can switch to it.

This should be ready for review / testing now

Tested and I changed some settings as previous (Timeout: 10s, 1 try), thanks.

Im not sure if this update is the culprit of a new problem after upgrade to 1.19.4, but after the upgrade, my monitors with ping are giving me false positives (down) almost every 10 minutes with the text: 1 packets transmited, 0 received, 100% packet loss, time 0ms, then 1 or 2 minutes later my monitors are backed up on uptime-kuma, im pretty sure that is a false positive. I have another uptime-kuma instance with older version and on that instance the same monitors do not present the problem

Im not sure if this update is the culprit of a new problem after upgrade to 1.19.4, but after the upgrade, my monitors with ping are giving me false positives (down) almost every 10 minutes with the text: 1 packets transmited, 0 received, 100% packet loss, time 0ms, then 1 or 2 minutes later my monitors are backed up on uptime-kuma, im pretty sure that is a false positive. I have another uptime-kuma instance with older version and on that instance the same monitors do not present the problem

I think it is unrelated, because it is eventually using your system's ping command.

1 packets transmited, 0 received, 100% packet loss

It was reported by ping command.

We could always add an option to alter how many packets are sent, a bit like the ping packet size pr


Request: Remove notification for LockMechanism

Is there a way to add a notification option for LockMechanism ?
Every time a request is sent to open a door it sends notifications to everyone, which is a bit frustrating.
It would be great to have this as an option. I've seen in the HomeKit doc that it is possible however I don't know if it's supported by homebridge.
At the moment I have the Lock set as a switch but that's not ideal.
I would do a PR but am not really familiar with HomeKit and homebridge. If someone can push me in the right direction (documentation wise) I would gladly do it.

At least in the latest version of iOS (17), you can mute notifications on a per-user basis. Open the lock's settings in the Home app and click on "Status and Notifications," then turn off Activity Notifications.
This is the only way that I personally know of to turn off notifications, and it unfortunately must be done by each user rather than globally.


Reformat yaml files and arrange them in dependency order

Please take a look at the commits individually and review them with "hide whitespace changes". The first commit renames files to match the dependency order.
Namespace > Cluster CRD > Namespaced CRD > Controller > Webhook
The second commit reformats the yaml files to follow yamllint rules.

Codecov Report

Merging #879 (25aebe8) into main (f695816) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #879   +/-   ##
=======================================
  Coverage   67.42%   67.42%
=======================================
  Files         115      115
  Lines        5231     5231
=======================================
  Hits         3527     3527
  Misses       1341     1341
  Partials      363      363

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f695816...25aebe8. Read the comment docs.

@samj1912 Would it be possible to update this PR?

Closing for now.


[Sept Sprint] Improve Blackjack

This is part of our September Spring to get the Go Track in shape. Please read the Overview issue for more details. This exercise is unclaimed. To claim it, please comment below.

Blackjack

[x] https://github.com/exercism/go/issues/1556
[x] https://github.com/exercism/go/issues/1558

I'll take this one too :)

@andrerfcsantos We've removed the comparison requirement, as we're moving that to Cars Assemble (see https://github.com/exercism/go/issues/1611). I hope you didn't lose any work. If you had already started, you might want to indicate in the just linked issue that you could add the comparison concept to Cars Assemble