got an error while applying resolvconf configuration for wt0 interface, error: exit status 99

Describe the problem
Netbird cannot configure resolvconf in some peers
these are some error logs
2024-01-09T16:59:07+01:00 ERRO client/internal/dns/server.go:282: got an error while applying resolvconf configuration for wt0 interface, error: exit status 99
2024-01-09T16:59:07+01:00 ERRO client/internal/dns/host_linux.go:99: got an error while checking systemd resolv conf mode, error: got an error getting property org.freedesktop.resolve1.Manager.ResolvConfMode: Unknown property or interface.
2024-01-09T16:59:07+01:00 WARN client/internal/wgproxy/factory_linux.go:15: failed to initialize ebpf proxy, fallback to user space proxy: field NbXdpProg: program nb_xdp_prog: map .rodata: map create: read- and write-only maps not supported (requires >= v5.2)

root@api-server:/etc/systemd/network# cat /var/log/netbird/client.log | grep error
2024-01-09T13:34:40+01:00 WARN client/server/server.go:122: failed login: rpc error: code = InvalidArgument desc = invalid setup-key or no sso information provided, err: invalid UUID length: 0
2024-01-09T13:34:41+01:00 ERRO client/internal/dns/host_linux.go:99: got an error while checking systemd resolv conf mode, error: got an error getting property org.freedesktop.resolve1.Manager.ResolvConfMode: Unknown property or interface.
2024-01-09T13:34:41+01:00 ERRO client/internal/dns/resolvconf_linux.go:47: got an error while removing resolvconf configuration for wt0 interface, error: exit status 99
2024-01-09T13:37:38+01:00 ERRO client/internal/dns/server.go:168: got an error while removing resolvconf configuration for wt0 interface, error: exit status 99
2024-01-09T13:38:27+01:00 WARN client/server/server.go:122: failed login: rpc error: code = InvalidArgument desc = invalid setup-key or no sso information provided, err: invalid UUID length: 0
2024-01-09T13:38:28+01:00 ERRO client/internal/dns/host_linux.go:99: got an error while checking systemd resolv conf mode, error: got an error getting property org.freedesktop.resolve1.Manager.ResolvConfMode: Unknown property or interface.
2024-01-09T13:38:28+01:00 ERRO client/internal/dns/resolvconf_linux.go:47: got an error while removing resolvconf configuration for wt0 interface, error: exit status 99

Expected behavior
when netbird successfully connect, it should be able to setup resolver to resolve other peers FQDNs
NetBird status -d output:
root@api-server:~# netbird status -d
Peers detail:
 nano-48433.eu-vpn.domain.ltd:
  NetBird IP: <IP_ADDRESS>
  Public key: xxIJaMBffN0PFfiCCATeEI+NpTQ7pRvKas+ApqjHlmE=
  Status: Connected
  -- detail --
  Connection type: P2P
  Direct: true
  ICE candidate (Local/Remote): host/prflx
  Last connection update: 2024-01-09 16:59:12

 nano-08266.eu-vpn.domain.ltd:
  NetBird IP: <IP_ADDRESS>
  Public key: uYXixcplxIBBC8navUpT0QHV1+1UeBaqSH7sJpYLr3s=
  Status: Connected
  -- detail --
  Connection type: P2P
  Direct: true
  ICE candidate (Local/Remote): host/prflx
  Last connection update: 2024-01-09 18:43:01

 dublin-office.eu-vpn.domain.ltd:
  NetBird IP: <IP_ADDRESS>
  Public key: 7LtFVno9xxLSUA+R79XaqSD7t5svM7XT7+OLFLl6SG0=
  Status: Connected
  -- detail --
  Connection type: P2P
  Direct: true
  ICE candidate (Local/Remote): srflx/prflx
  Last connection update: 2024-01-09 16:59:13

Daemon version: 0.25.3
CLI version: 0.25.3
Management: Connected to https://eu-vpn.domain.ltd:443
Signal: Connected to https://eu-vpn.domain.ltd:443
FQDN: api-server.eu-vpn.domain.ltd
NetBird IP: <IP_ADDRESS>/16
Interface type: Userspace
Peers count: 3/3 Connected

Screenshots

Connect netbird with setup keys

netbird status (connected)

/etc/resolv.conf doesn't contain DNS details like other peers

After proper restart (down => up or netbird service restart) I got resolv errors

2024-01-09T18:48:48+01:00 ERRO client/internal/dns/server.go:168: got an error while removing resolvconf configuration for wt0 interface, error: exit status 99
2024-01-09T18:48:48+01:00 INFO client/internal/engine.go:170: stopped Netbird Engine
2024-01-09T18:48:48+01:00 INFO client/internal/connect.go:205: stopped NetBird client
2024-01-09T18:48:54+01:00 INFO client/internal/connect.go:56: starting NetBird client version 0.25.3
2024-01-09T18:48:54+01:00 WARN client/internal/wgproxy/factory_linux.go:15: failed to initialize ebpf proxy, fallback to user space proxy: field NbXdpProg: program nb_xdp_prog: map .rodata: map create: read- and write-only maps not supported (requires >= v5.2)
2024-01-09T18:48:54+01:00 INFO iface/tun_usp_linux.go:33: using userspace bind mode
2024-01-09T18:48:54+01:00 INFO iface/tun_usp_linux.go:45: create tun interface
2024-01-09T18:48:54+01:00 WARN client/firewall/nftables/route_linux.go:69: table 'filter' not found for forward rules
2024-01-09T18:48:55+01:00 ERRO client/internal/dns/host_linux.go:99: got an error while checking systemd resolv conf mode, error: got an error getting property org.freedesktop.resolve1.Manager.ResolvConfMode: Unknown property or interface.
2024-01-09T18:48:55+01:00 INFO signal/client/grpc.go:157: connected to the Signal Service stream
2024-01-09T18:48:55+01:00 INFO client/internal/connect.go:191: Netbird engine started, my IP is: <IP_ADDRESS>/16
2024-01-09T18:48:55+01:00 INFO management/client/grpc.go:143: connected to the Management Service stream
2024-01-09T18:48:55+01:00 ERRO client/internal/dns/server.go:282: got an error while applying resolvconf configuration for wt0 interface, error: exit status 99
2024-01-09T18:48:55+01:00 INFO client/internal/acl/manager.go:52: ACL rules processed in: 26.329µs, total rules count: 2
2024-01-09T18:48:56+01:00 INFO client/internal/peer/conn.go:343: connected to peer xxIJaMBffN0PFfiCCATeEI+NpTQ7pRvKas+ApqjHlmE=, endpoint address: <IP_ADDRESS>:1961
2024-01-09T18:48:57+01:00 INFO client/internal/peer/conn.go:343: connected to peer uYXixcplxIBBC8navUpT0QHV1+1UeBaqSH7sJpYLr3s=, endpoint address: <IP_ADDRESS>:21197
2024-01-09T18:48:57+01:00 INFO client/internal/peer/conn.go:343: connected to peer 7LtFVno9xxLSUA+R79XaqSD7t5svM7XT7+OLFLl6SG0=, endpoint address: <IP_ADDRESS>:51820
2024-01-09T18:49:51+01:00 INFO client/internal/peer/conn.go:343: connected to peer uYXixcplxIBBC8navUpT0QHV1+1UeBaqSH7sJpYLr3s=, endpoint address: <IP_ADDRESS>:21197
2024-01-09T18:50:24+01:00 INFO client/internal/peer/conn.go:343: connected to peer uYXixcplxIBBC8navUpT0QHV1+1UeBaqSH7sJpYLr3s=, endpoint address: <IP_ADDRESS>:21197

cannot reach other connected peers via FQDN nor via IP

Additional context
I think there is a bug in netbird client not able to detect DNS resolver although:
System-resovled is active and running

resolvconf is installed and running

seen this issues in:

Netbird run with or without sudo / root

ERRO client/internal/dns/server.go:282: unable to configure DNS for this peer using resolvconf manager without a nameserver group with all domains configured

Hi !
I'm facing the same issue.
Did you found a solution ? Is there a way to manually configure the internal DNS to resolv netbird peers IP with their hostname ?

@rpellerej I didn't find a solution to this.
I have just dropped the server I was working on and used another one.


Add persistent LDAP layer

Before this, Hologram dialed LDAP once and if that connection died, it
would silently fail. This commit adds a new type that implements the
same interface but pings behind the scenes and reconnects if needed.
Fixes #53.

Ping @frangarciam, @zylad, or anyone else who's watching. Is there something I can do to make merging this easier?

I think both Fran and Dominik have left AdRoll, as did I in February. I sadly no longer have commit access to this repository and cannot do much to help here.
I've been a bit out of sorts lately, and haven't kept up with the pace of Hologram development; I've forked this repo to https://github.com/sanctuarygroup/hologram so that development can continue in that light and I can at least help there.
Can you please replicate this Pull Request there, and I'll provide commentary?

Aha, I hadn't realized that the project had moved! I'll move the PR over there this evening, thanks! There's another PR here that should probably be notified, and the issue tracker is disabled in the new location.

Nice catch, thank you. I've added the Issue Tracker there for you.

We're still supporting this at adroll.
@copumpkin why ping every time instead of reconnect on failure?

@walterking no real reason, and your way sounds better, thanks. I'll revise the PR to do that instead. Any other comments while I'm at it?

that was the only thing that stood out to me

@walterking sorry for the long delay, but I think I've addressed the point you made in this latest commit. Basically switched the logic from "unconditional ping -> potentially reconnect -> run operation" to "run operation -> potentially reconnect -> potentially retry operation". Tests still pass and it simplified things a bit (like all the Ping stuff is now gone).

The code looks good to me.  Just want to build/test to verify first

Looks good, thanks.  The build & tests passed.


Add tests for tooltips and docs for modules

@MikhailArkhipov Even a minimal description is helpful here (test class names, APIs, etc), in case someone else has to jump in and take this on (or is just browsing our issues to see what work is going on).

It works now


lib/util.py

Hey guys,
I really appreciate your code and implementation. I am trying to reconstruct the experiments. However, there is a library called 'zero' that is used in the util file that does not have the attributes used. I looked into the documentation and it doesn't exist there either. Do you know if this is a custom library or if it using a previous version? I also looked through the requirements.txt and 'zero' is not present there either. This is where it is used in the code:
lib/util.py:
22. import zero
49. class Timer(zero.Timer):
271. 'gpus': zero.hardware.get_gpus_info(),
Thanks in advance for your time.
Best regards

I think I solved the issue by looking at the delu library (https://github.com/Yura52/delu)
and changing line 22 above to import delu as zero to not have to change other things in the code. It seems to have worked.

I think I solved the issue by looking at the delu library (https://github.com/Yura52/delu) and changing line 22 above to import delu as zero to not have to change other things in the code. It seems to have worked.

It works for me! Tks!


[Windows][DX12] mandlebrot example crashes

After some seconds of execution, the examples crashes with the following log:
Traceback (most recent call last):
  File ".\test_compushady.py", line 74, in <module>
    swapchain.present(target)
  File "C:\Users\franc\AppData\Local\Programs\Python\Python38\lib\site-packages\compushady\__init__.py", line 202, in present
    self.handle.present(resource.handle, x, y)
Exception: unable to Present() Swapchain: Istanza del dispositivo GPU sospesa. Utilizzare GetDeviceRemovedReason per determinare l'azione appropriata.

ID3D12CommandQueue::ExecuteCommandLists: Command lists must be successfully closed before execution.
ID3D12Device::RemoveDevice: Device removal has been triggered for the following reason (DXGI_ERROR_INVALID_CALL: There is strong evidence that the application has performed an illegal or undefined operation, and such a condition could not be returned to the application cleanly through a return code).
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12CommandList::Dispatch: No pipeline state has been set in this command list.  The runtime will use a default no-op pipeline state.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12CommandQueue::ExecuteCommandLists: Command lists must be successfully closed before execution.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12GraphicsCommandList::*: This API cannot be called on a closed command list.
ID3D12CommandQueue::ExecuteCommandLists: Command lists must be successfully closed before execution.

It's a problem with Buffer.upload(), it's eating up all of your RAM and the program is just crashing.

@Jiloc @HenBOMB should be fixed in 0.17.2


How to visualize output files

hello,
thank you for sharing such a nice code in advance
it's working well in my laptop :-)
but when I got my output files which are line.txt, plane.txt
I just don't know how to visualize this file like a picture in README.md file

@bigdoods @tigerk0430  I suggest you show the results via a public software CloudCompare: https://www.danielgm.net/cc/ .

or with Ros and Rviz

or with Ros and Rviz

hello,  i am using the code to detect the 3d lines, could u please share your detailed method about how to visualize the result? thanks

hello,  i am using the code to detect the 3d lines, could u please share your detailed method about how to visualize the result? thanks

or with Ros and Rviz

hello,  i am using the code to detect the 3d lines, could u please share your detailed method about how to visualize the result? thanks

read the point from file and publish as ros topic, then use rviz to visualize

try this one #12


fix: missing service loader conf for the JsonMapperSupplier

Fixes #70

Hi! Which version of Kestra includes this fix? Thanks

This will be included in Kestra 0.15.2 which will be released very soon.


[GitHub Actions] How do I configure using .pr_agent.toml file?

Hello
I'm using GitHub actions PR-Agent. I would like to configure using .pr_agent.toml file but It did not work.
I think I created it correctly, so PR-Agent(GitHub Actions) doesn't support .pt_agent.toml config file or do We need to use PR-Agent Pro?
※ I have already merged this .pr_agent.toml file into master branch.
file name: this is root directory of my repo.

.pr_agent.toml
# PR-Agent の設定ファイル

[pr_reviewer]
extra_instructions = ""
enable_review_labels_security = false
enable_review_labels_effort = false
require_can_be_split_review = true
enable_auto_approval = true
maximal_review_effort = 1

.github/workflows/pr-agent-on-comment.yml
name: pr-agent-commented

on:
  issue_comment:
    types: [created, edited]

permissions:
  pull-requests: write
  issues: write

jobs:
  pr_agent:
    name: PR Agent
    runs-on: ubuntu-latest
    if: github.event.sender.type != 'Bot' &&
        github.event.issue.state == 'open' &&
        github.event.issue.pull_request != null &&
        startsWith(github.event.comment.body, '/')
    steps:
      - name: PR Agent actions step
        id: pr-agent
        uses: Codium-ai/pr-agent@eff6468651c8acce5ee15ff686e8b772fe386212
        env:
          OPENAI_KEY: ${{ secrets.OPENAI_KEY }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Hi here is logs when I run /review auto_approve.
I double-checked my .pr_agent.toml file but there is no problem, I think.
/usr/bin/docker run --name c660312885ff42fba1b19b5347d4b031_d01e2b --label 672523 --workdir /github/workspace --rm -e "OPENAI_KEY" -e "GITHUB_TOKEN" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/pr-agent/pr-agent":"/github/workspace" 672523:c660312885ff42fba1b19b5347d4b031
{"text": "Applying repo settings\n", "record": {"elapsed": {"repr": "0:00:01.2[6](https://github.com/psbss/pr-agent/actions/runs/8656504864/job/23737122816#step:3:7)6795", "seconds": 1.266795}, "exception": null, "extra": {}, "file": {"name": "github_action_runner.py", "path": "/app/pr_agent/servers/github_action_runner.py"}, "function": "run_action", "level": {"icon": "ℹ", "name": "INFO", "no": 20}, "line": 72, "message": "Applying repo settings", "module": "github_action_runner", "name": "__main__", "process": {"id": 7, "name": "MainProcess"}, "thread": {"id":<PHONE_NUMBER>97664, "name": "MainThread"}, "time": {"repr": "2024-04-12 03:23:13.453356+00:00", "timestamp":<PHONE_NUMBER>.453356}}}
{"text": "Auto approve flow PR: https://api.github.com/repos/psbss/pr-agent/pulls/4413 ...\n", "record": {"elapsed": {"repr": "0:00:04.242592", "seconds": 4.242592}, "exception": null, "extra": {"command": "review"}, "file": {"name": "pr_reviewer.py", "path": "/app/pr_agent/tools/pr_reviewer.py"}, "function": "run", "level": {"icon": "ℹ", "name": "INFO", "no": 20}, "line": 105, "message": "Auto approve flow PR: https://api.github.com/repos/psbss/pr-agent/pulls/4413 ...", "module": "pr_reviewer", "name": "pr_agent.tools.pr_reviewer", "process": {"id": [7](https://github.com/psbss/pr-agent/actions/runs/8656504864/job/23737122816#step:3:8), "name": "MainProcess"}, "thread": {"id":<PHONE_NUMBER>97664, "name": "MainThread"}, "time": {"repr": "2024-04-12 03:23:16.429153+00:00", "timestamp":<PHONE_NUMBER>.429153}}}
{"text": "Auto-approval option is disabled\n", "record": {"elapsed": {"repr": "0:00:04.243368", "seconds": 4.243368}, "exception": null, "extra": {"command": "review"}, "file": {"name": "pr_reviewer.py", "path": "/app/pr_agent/tools/pr_reviewer.py"}, "function": "auto_approve_logic", "level": {"icon": "ℹ", "name": "INFO", "no": 20}, "line": 421, "message": "Auto-approval option is disabled", "module": "pr_reviewer", "name": "pr_agent.tools.pr_reviewer", "process": {"id": 7, "name": "MainProcess"}, "thread": {"id": 1401[8](https://github.com/psbss/pr-agent/actions/runs/8656504864/job/23737122816#step:3:9)1854497664, "name": "MainThread"}, "time": {"repr": "2024-04-12 03:23:16.429929+00:00", "timestamp":<PHONE_NUMBER>.429929}}}

auto_approve specifically is not supported in github action since the github action bot doesn't have permission to approve PRs
The configuration file in general is supported in GitHub action.
I cannot debug your local hosting. That a downside of using such deployment.
Consider using PR-Agent Pro, where, along with other advantages, we are able to see logs and provide support
https://github.com/Codium-ai/codium-code-examples/pull/40#issuecomment-1948237942
https://github.com/Codium-ai/codium-code-examples/blob/main/.pr_agent.toml

Thank you so much for your quick response!
Okay I will discuss with our manager to be able to use the pro plan.


palm new-machine && palm-clone

Context
We are actually 2 steps away from palm being a complete instant-dev solution. think about it....
You start at Bluth's Bananastand co on a Monday. The onboarding box arrives with your brand new Mac/PC/Linux laptop, and a single post-it note on the box:
    Welcome to the team Pat! to get started (from the command line):
    1. pip install palmcli
    2. palm new-machine
    3. palm clone git@github:bluth-bananastand/banangrabber.git

    run `palm --help` if you have any questions.
    Please try to have jira issue NANA-123 done before lunch, it's a 1 point naming fix ;) Excited to have you aboard!

Is your feature request related to a problem? Please describe.
There are still a few manual steps outside palm. this eliminates them.
Describe the solution you'd like

Open up my brand new Mac, PC or Linux laptop.
Power it on
open the CLI, run palm new-machine
Now the magic:

palm checks the OS, checks for docker, and installs the correct docker (or at least opens the browser dialog to do so)
palm prompts you to select a git repo provider (github & bitbucket are good intial options)
palm (generates if needed and) installs your ssh key into your gh/bb account

palm announces that you are ready to begin work! now to get started:

cd into the directory you want your repos in
use the palm clone command to add the repo palm clone git@github.com:your-company/some-repo-with-palm.git

palm clones the repo like normal git
palm looks for a .env file and parses it for expected environment variables (i.e. BANANA=${BANANA}
for each found environment variable, it checks to see if that is already exported into your path.

if it is, palm announces it ("found environment variable BANANA, skipping")
at the end of the cycle, it prompts you with a list of envars it needs ("repo banana_grabber requires the following environment variables: BANANA_USERNAME, BANANA_API_KEY, BANANA_HOST. proceed? (y/n):")
palm then sets each variable for the os (so .zshrc or .bashrc for unix, win sys envs for windows)
bonus we could make it super easy to set a custom message with the envars message in the palm file, like "if you do not have a BANANA_USERNAME yet, contact core systems at<EMAIL_ADDRESS>and request one."

Describe alternatives you've considered
Manual documentation. which is fine. but not magic. This is amazing magic.
Additional context
This should be broken into implementation slices; each part has value on its own (ie palm new-machine and palm-clone)
Is there an existing feature request for this?

[x]  I have searched the existing issues

Neat idea, I especially like the ideas around palm new machine. However, there are some things we need to consider:

Running palm outside of an initialized git repo is not currently supported. Trying to do anything with Palm outside of a repo will raise an error due to checking for branch validation.
.env files should usually not be comitted to VCS, our pattern of using interpolation works in some cases, but not all. We should be careful about baking this pattern into palm as it could lead users down a dangerous path (having .env files committed to source control). Without .env management, palm clone just feels like an unnecessary alias to git clone.
without adding some new functionality, palm new-machine would be present in everyone's command list, always. Even though it's only useful on day 1. This feels a little messy to me.
Since palm is no longer internal to Palmetto, we would need to make any messaging around requesting access/credentials configurable.

Good points - some of them I was thinking about this weekend,

Running palm outside of an initialized git repo is not currently supported. Trying to do anything with Palm outside of a repo will raise an error due to checking for branch validation.
^^ hmm.. maybe new-machine doesn't use the standard palm interface? similar to how django-admin startproject mysite is only used initially, and  manage.py is the interface for every following command? that would also break us free of showing new-machine in the help because it would be a command for the attached mini-package palm-admin.

.env files should usually not be comitted to VCS, our pattern of using interpolation works in some cases, but not all. We should be careful about baking this pattern into palm as it could lead users down a dangerous path (having .env files committed to source control). Without .env management, palm clone just feels like an unnecessary alias to git clone.
^^ was thinking about this. maybe we encourage a good pattern by compiling from .env.template. If there is already an .env (for projects where all the variables are stored as envars and it is used as a readable index) we check to see if they are set and if not prompt to set them. For projects where there is NOT an .env we check to make sure it is not in source control (updating .gitignore if needed) prompt the user for each envar, set them, and generate the .env file.

without adding some new functionality, palm new-machine would be present in everyone's command list, always. Even though it's only useful on day 1. This feels a little messy to me.
^^ that palm-admin or whatever micro package could solve this maybe

Since palm is no longer internal to Palmetto, we would need to make any messaging around requesting access/credentials configurable.
^^ Oh yeah, I was thinking this should maybe be in the .palm/  directory as a configurable yaml or markdown file. So as the lead dev on a project you would build that out, maybe as a key/value pair for each envar

BANANASTAND_STITCH_API_KEY: |
    Stitch API Keys are managed by IT Services in the Toronto office.
    Contact them at<EMAIL_ADDRESS>to request an API key, version 2 or higher.

This literally becomes "tribal knowledge as code" for onboarding ;)

I think you and I were having similar thoughts about this over the weekend. I just did a spike of how I think this should work - take a look at spike/setup-machine - this solves My 1st and 3rd points
Essentially, I've added exception handling around running palm outside of a git repo. Then I'm using that exception to change the set of plugins we're loading commands from in that context - right now I just have a shell of setup_plugin to prove the functionality works.
Still not 100% sold on the .env thing. I get the value, and I think the point about .env.template is a good one, my concern is still that this is dangerous grounds from a security perspective. If we can come up with a solution that helps prevent credentials get committed, I'd get behind this. The idea of a /.palm/env_vars.yaml (or similar) is interesting, and could be a more useful replacement for .env.template
BANANASTAND_STITCH_API_KEY:
    default: ${BANANASTAND_STITCH_API_KEY}
    message: |
        Stitch API Keys are managed by IT Services in the Toronto office.
        Contact them at<EMAIL_ADDRESS>to request an API key, version 2 or higher.

Then, palm clone would read this, check for existing globally exported defaults, print the message if they aren't found, and create the .env (and make sure it's listed in .gitignore

Still not 100% sold on the .env thing. I get the value, and I think the point about .env.template is a good one, my concern is still that this is dangerous grounds from a security perspective. If we can come up with a solution that helps prevent credentials get committed, I'd get behind this. The idea of a /.palm/env_vars.yaml (or similar) is interesting, and could be a more useful replacement for .env.template

OOOH what if palm yells at you any time the .env file has a non-interpreted value in it? so for example I have a file .env-template:
BANANA_HOST=https://bananacompany.redshift.aws.com
BANANA_USER=${BANANA_USER}
BANANA_PASSWORD=${BANANA_PASSWORD}

when you run palm clone<EMAIL_ADDRESS>it clones the repo, then you get this prompt series:
cloning repo banana/bananarepo...
cloned.
preparing variables and secrets...
**WARNING!** environment variable BANANA_HOST is a plaintext variable, this could is very dangerous! Do you want  to proceed? (y/n):
>> y
setting plaintext envar BANANA_HOST...
set.

please enter a value for BANANA_USER (type `help!` if you are unsure of this value):
>> help!
BANANA_USER should be the username provided to you by the banana application team. If you need a username and do not have one, contact Tobias Fünke via email<EMAIL_ADDRESS>to have one assigned.

please enter a value for BANANA_USER (type `help!` if you are unsure of this value):
>> job_bluth
setting environment variable BANANA_USER...
set!

Congrats, bananarepo is ready to go! to get started, run palm --help from inside the repo.

re-thinking envs..
maybe we follow 2 paths. Ask the user if they have a provided env, if they do, drop it. if they do not, do the cycle above, and also ask if they should be set globally. this supports 2 patterns:

I-already-have-an-env is perfect for temporary, single app or untrusted users. for a contractor, they are simply sent the env file they will use in an email. quick and simple, the limitation is that you can't share envs across projects but that is probably not an issue for this use case.
help-me-build-an-env is perfect for onboarding permanent employees. it tells them where to go to get env values themselves, builds the env in a way that is shared across projects (setting system envars) so they can use the same creds across dozens of internal repos really easily. This requires more engagement with the business, which is actually ideal for this use case.


How do we customise the generated declaration files to emit complex typescript types that the compiler might not know what to do

When using DNT to generate declaration files for a TypeScript project, there is currently no straightforward way to customize the emitted types for complex scenarios where the TypeScript compiler might not have enough information to infer the correct types. We need a mechanism to specify custom typings to be included in the generated declaration files.
To address this limitation, it would be helpful if DNT allows developers to provide custom TypeScript type declarations that can be included in the generated declaration files. This way, developers can manually define the types for complex scenarios where the TypeScript compiler's inference may fall short.

There is a postBuild step where you can make any modifications as necessary:
await build({
  // ...etc...
  typeCheck: false,
  outDir: "./npm",
  postBuild() {
    // steps to run after building and before running the tests
    Deno.copyFileSync("LICENSE", "npm/LICENSE");
    Deno.copyFileSync("README.md", "npm/README.md");
  },
});


[Epic][E2e Streamlit]  Create Feed Overview streamlit page (expand lake/ + analytics/)

Motivation
As @KatunaNorbert recommended, we should have a clear E2E of what https://github.com/oceanprotocol/pdr-backend/issues/447 is working towards.
get_endpoint_statistics() has many feed_statistics that should be reported somewhere. To avoid adding this as a cli_module to then change it again, let's remove it for now.
This ticket is for revisiting this when creating the "Feed Overview" and "Feed Detail" pages found here: https://docs.google.com/presentation/d/18y_nfpc3e-dop5NtfIisgUkc-oPt8dft9WyAnqhSqZg/edit#slide=id.g28d2e627aad_0_0
This ticket should explain how to create the "Feed" tables inside the Lake, load them from parquet in Analytics, and render them into Streamlit.
At the end, we should have lake/ creating this data as it updates, and new  "streamlit-single-page-app" should simply consume this data to provide insights on Feeds.
DoD - Medallion Workflow + Streamlit requirements

[ ] Design tables, charts, and requirements for the Feed Overview + Feed Details pages
[ ] Define table requirements to service Feed Overview Page- gold_pdr_feeds_summary <feed, timeframe, source> final aggregated metrics to provide an overall summary: total_stake, total_payout, rolling_accuracy.
[ ] Define table requirements to service Feed Details Page - silver_pdr_feeds <feed, timeframe, source> per event aggregation to report time-series insights: {sum_staked, n_staked, sum_stake_revenue, sum_stake_slash, sum_df_rewards, sum_rose_rewards, rolling_accuracy, rolling_stake}
[ ] Build data-workflows for silver_pdr_feeds and gold_pdr_feeds_summary into ETL.
[ ] Create Feed Overview streamlit page
[ ] Add gold_summary as a table
[ ] Add silver time-series data as charts

Closing this ticket for now. Re-open when we're closer to it.


Revive runtime isolation + ITask Factory

Context
Revive PR: #217
Add ITask Factory to allow customization to ITask implementation and classloader override.
Checklist

[x] ./gradlew build compiles code correctly
[x] Added new tests where applicable
[x] ./gradlew test passes all tests
[x] Extended README or added javadocs where applicable

@sundargates For "SinkParameter" it's possible to move it to control-plane-core but its actual package name is being used in source jobs too and renaming it will create a large splash of changes. In this case I don't think it's worth much to only move it to core module without renaming it.


backport pull request #533 to 1-4-stable branch.

Pull Request Test Coverage Report for Build 1136

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 96.685%

Totals

Change from base Build 1132:
-0.02%

Covered Lines:
350

Relevant Lines:
362

💛  - Coveralls


Broken export to CodeSandbox

Release number or git hash: 4.0.0
Web browser version and OS: Chrome 87

Steps to reproduce

Open https://lineup.js.org/app_develop/#soccer
Export to example to CodeSandbox.io

Observed behavior
Error 1
DependencyNotFoundError
Could not find dependency: 'tslib' relative to '/node_modules/lineupjs/src/provider/ADataProvider.js'

If I follow the instructions and import tslib, I get the following error.
Error 2
TypeError
Cannot read property 'FLOAT_ASC' of undefined

...

  1 |
> 2 | import * as LineUpJS from "lineupjs";
  3 | import "lineupjs/build/LineUpJS.css";
  4 | import * as Papa from "papaparse";
  5 |

Switching the dependency to LineUp v4.1.1 shows the same error.

Expected behavior
The export should work without errors and show the demo.

the dev version of lineupjs (lineupjs@next) should have no problems anymore with circular imports

I still have the issue with the version 4.2.0-alpha.1 which is labelled as next on npmjs.
See https://codesandbox.io/s/lineup-boiler-plate-pktp1?file=/package.json


Added package target

Signed-off-by: Tomasz Rybicki<EMAIL_ADDRESS>

This PR partly depends on newest OCTF master


增量分布式导出emb,避免worker保存大emb内存爆炸

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.李旭 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


MAINT: replace black, flake8 and isort by ruff

Same approach as used in geopandas and pyogrio.
Didn't enble pydocstyle yet to keep the PR somewhat managable.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

27 of 28 (96.43%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 88.158%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shapely/affinity.py
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
2628

Relevant Lines:
2981

💛  - Coveralls


Adaptation for easy implementation in Jetpack Compose

I would like to know if it is possible to use the library with Jetpack Compose, or if you have any approach to facilitate the implementation, or to include an example using it with this new Android Kit, currently you have indicated:
private val scanCustomCode = registerForActivityResult(ScanCustomCode(), ::showSnackbar)
For Jetpack Compose it would probably look like this:
val result = remember { mutableStateOf<QRResult?>(null) }
val launcher = rememberLauncherForActivityResult(ScanCustomCode()) {
    result.value = it
}

Thank you very much in advance for your work with this library

Hi @Jeluchu, thanks for contacting me. Maybe I find time to set up a compose sample project, to test and show the Jetpack Compose integration. Then I could also update the Readme.
But did you search for the Activity Result API usage in Jetpack Compose? Since my library uses this standard API there should be no difference to other implementations:

https://stackoverflow.com/questions/64721218/jetpack-compose-launch-activityresultcontract-request-from-composable-function
https://stackoverflow.com/questions/67177271/how-to-handle-activity-onactivityresult-with-jetpack-compose

@G00fY2
Actually I have already implemented your library in my Compose project and it is more or less as I have indicated, I comment it in case you want to include it in the Readme.
At the top inside the Composable I get the result of the activity like this:
    val launcher = rememberLauncherForActivityResult(ScanCustomCode()) { qrResult ->

        val text = when (qrResult) {
            is QRResult.QRSuccess -> qrResult.content.rawValue
            QRResult.QRUserCanceled -> "User canceled"
            QRResult.QRMissingPermission -> "Missing permission"
            is QRResult.QRError -> "${qrResult.exception.javaClass.simpleName}: ${qrResult.exception.localizedMessage}"
        }

      { ... } // Code for result

    }

And then I have this other piece of code that I call when I want to open the QR reader, in ActivityResultLauncher<ScannerConfig> I pass it the launcher variable indicated in the code snippet above
    val qrReader: (ActivityResultLauncher<ScannerConfig>) -> Unit = { qrReaderActivityResult ->
        qrReaderActivityResult.launch(
            ScannerConfig.build {
                setBarcodeFormats(listOf(BarcodeFormat.FORMAT_QR_CODE))
                setOverlayStringRes(R.string.scannerQrshopper)
                setHapticSuccessFeedback(false)
                setShowTorchToggle(true)
                setUseFrontCamera(false)
            }
        )
    }

In compose, the way to get the results of the activities changes from what we were used to in the old XML activities, that's why rememberLauncherForActivityResult is now used.

Thanks for clarifying and sharing your solution. ❤
As I said, I will also try to set up a Compose Sample project in the future and than link it in the Readme.
Do you think it makes sense to keep the ticket open?

 Thanks to you for your work with this library, of course no problem, you can close it 😄


ReferenceError: outputFormats is not defined

jstransformer-textile/index.js:38:22

e7e4e1f hopefully fixes this. finally got around to updating it.


Make Rect2 EditorProperty obey the horizontal setting

Said setting being horizontal_vector3_editing, which affecting more properties than Vector3, probably should be renamed to something else.

Maybe rename it to horizontal_vector_types_editing?

Thanks!


DNS ML reading avro is missing a configuration value.

For reading avro I’ve been changing DPATH value to point to DPATH=${HUSER}/${DSOURCE}/hive/y=${YR}/m=${MH}/d=${DY}/  but for Flow ML to work this path needs to be DPATH=${HUSER}/${DSOURCE}/csv/y=${YR}/m=${MH}/d=${DY}/*.
Reading from avro it needs the hive path and no “” at the end but flows needs to read from csv and “” at the end.
I’ve been thinking on a solution for this like having 2 DPATH variables or replace the hive or csv in ML ops given the flow or dns parameter but I’d like to hear your suggestions.

@NathanSegerlind, @grantbabb, can you take a look please.

I think that the simplest solution is to add a "" to the scala code for flows -
System.getenv("DPATH")+""
It will have the lowest impact later when both data sources point at avro.

These characters seems to be control sequences for github's markup language...
however, I think Grant's suggestion is the simplest - a simple addition to DPATH with a comment explaining why puts us in the best position for preparing for flows using avro

doh
talked about it on the phone with Ricardo:
separating the two paths is the way to go... there is no reason why two different inputs should reside at the same exact location

Aha, I was looking at the end of the string.  Yes, the two config values make sense.
Be sure to update the installation instructions describing the config values.
In 1.1 we should remove the "csv" path.


Ignore queue exceptions in terminate workflow logic.

Failure to remove from queue during terminate wouldn't cause any side effects, and can be cleaned up in subsequent operations. However, queue exceptions are catched as blockers in terminateWorkflow logic, ignoring subsequent operations in terminate logic like canceling the tasks, starting the failure workflow etc.
This PR will catch and log the queue remove exceptions, and continue with terminate workflow logic.

Pull Request Test Coverage Report for Build 4520

5 of 6 (83.33%)  changed or added relevant lines in 1 file are covered.
13 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.07%) to 69.45%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
5
6
83.33%

Files with Coverage Reduction
New Missed Lines
%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
2
55.44%

postgres-persistence/src/main/java/com/netflix/conductor/dao/postgres/PostgresMetadataDAO.java
11
80.75%

Totals

Change from base Build 4501:
-0.07%

Covered Lines:
12769

Relevant Lines:
18386

💛  - Coveralls


Multiple lines in continuous view instead of one

pgload01g/test M # \dS+ user_activity
                      View "public.user_activity"
 Column  |           Type           | Modifiers | Storage | Description
---------+--------------------------+-----------+---------+-------------
 uid     | bigint                   |           | plain   |
 last_ts | timestamp with time zone |           | plain   |
View definition:
 SELECT uid,
    max(ts) AS last_ts
   FROM ONLY stream1
  GROUP BY uid;

pgload01g/test M # select * from user_activity where uid = 205000000;
    uid    |            last_ts
-----------+-------------------------------
 205000000 | 2015-08-24 10:30:31.626377+03
(1 row)

Time: 0.501 ms
pgload01g/test M # insert into stream1 (uid, ts, service, session_id) values (205000000, current_timestamp, 'mobile', md5(random()::text));
INSERT 0 1
Time: 0.412 ms
pgload01g/test M # select * from user_activity where uid = 205000000;
    uid    |            last_ts
-----------+-------------------------------
 205000000 | 2015-08-24 10:30:42.038358+03
 205000000 | 2015-08-24 10:30:31.626377+03
(2 rows)

Time: 0.455 ms
pgload01g/test M # insert into stream1 (uid, ts, service, session_id) values (205000000, current_timestamp, 'mobile', md5(random()::text));
INSERT 0 1
Time: 0.370 ms
pgload01g/test M # select * from user_activity where uid = 205000000;
    uid    |            last_ts
-----------+-------------------------------
 205000000 | 2015-08-24 10:30:45.970381+03
 205000000 | 2015-08-24 10:30:42.038358+03
 205000000 | 2015-08-24 10:30:31.626377+03
(3 rows)

Time: 0.481 ms
pgload01g/test M # select pipeline_version();
                                                                          pipeline_version
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
 PipelineDB 0.8.0 at revision bc8c4e3decbcc219689330987ea46ddb6b3edd34 on x86_64-unknown-linux-gnu, compiled by gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11), 64-bit
(1 row)

Time: 0.631 ms
pgload01g/test M #

It does not reproduce with all uids, only with some of them.
pgload01g/test M # \dS+ user_activity_mrel0
                          Table "public.user_activity_mrel0"
 Column  |           Type           | Modifiers | Storage | Stats target | Description
---------+--------------------------+-----------+---------+--------------+-------------
 uid     | bigint                   |           | plain   |              |
 last_ts | timestamp with time zone |           | plain   |              |
Indexes:
    "user_activity_mrel0_expr_idx" btree (hash_group(uid))
    "user_activity_mrel0_uid_idx" btree (uid)
Options: fillfactor=50

pgload01g/test M # select hash_group(205000000);
 hash_group
-------------
 -1404874472
(1 row)

Time: 0.302 ms
pgload01g/test M #

Could you also paste the stream definition here? I tried to repro by doing:
usmanm=# CREATE CONTINUOUS VIEW v AS  SELECT uid,
usmanm-#     max(ts) AS last_ts
usmanm-#    FROM ONLY stream1
usmanm-#   GROUP BY uid;

But couldn't.

create stream stream1 (uid bigint, ts timestamp with time zone, service text);
alter stream stream1 add session_id text;

I can't reproduce it with empty DB. Here is some stat if it may help:
pgload01g/test M # select count(distinct(uid)) from user_activity;
   count
-----------
 204810795
(1 row)

Time: 363296.393 ms
pgload01g/test M # select count(*) from user_activity;
   count
-----------
 220297232
(1 row)

Time: 23289.458 ms
pgload01g/test M # select uid, count(last_ts) as lines from user_activity group by uid having count(last_ts) > 1 order by lines desc;
    uid    | lines
-----------+-------
  54078382 |    16
 195539017 |    16
 114079064 |    15
 164790195 |    15
 176169213 |    15
  66719473 |    15
  57387406 |    15
  61799561 |    15
 173888040 |    15
  37888296 |    15
  86691851 |    15
 138404055 |    15
   1942831 |    15
 177300876 |    15
  62331919 |    15
  82849782 |    15
 105382054 |    15
 134841926 |    15
  34799074 |    15
 171374325 |    14
 114414405 |    14
  57553388 |    14
 166048369 |    14
 173773325 |    14
  45917469 |    14
 184170436 |    14
 181162923 |    14
  70169234 |    14
  70433494 |    14
  30192311 |    14
 111397339 |    14
   6862898 |    14
 186530504 |    14
  37306513 |    14
  22947113 |    14
 113558728 |    14
  64551533 |    14
   6910966 |    14
 104864919 |    14
 148353187 |    14
 104366766 |    14
<...>
Time: 254529.526 ms
pgload01g/test M #

This is weird, both the queries should report the same number of rows. I'm going to try and insert 200m unique uids into the stream and see if I can repro.

@dev1ant: I'm able to repro this behavior. Will get a fix out asap.

Issue is fixed on master now.

Thanks, I'll test it.


Consider to use Debian Salsa intead of Github

Do you consider to use debian salsa?
some insight from debian developer https://lists.debian.org/debian-user/2021/07/msg01069.html

See https://salsa.debian.org/linuxhw/TestCoverage/-/tree/main/Dist/Debian_11


Fix description of writeBits, rename CIP-123 operations

This is the larger change I alluded to in #864 . The main semantic difference is that writeBits is differently specified now, and some of the justification and descriptive text had to change in CIPs 122 and 123 to fit. Two of the CIP-123 operations also got renamed to match the names used to implement them. I also spotted a few more typoes as part of this process.
If there are any additional changes I have to make in light of this change, please let me know on review.

@kozross can you please close this and resubmit your changes from a branch forked from an updated master which introduces these changes by themselves, or includes just https://github.com/cardano-foundation/CIPs/pull/867/commits/8ca282d6a769b65cdd9343f185b42d04491e2bf0?  The first 3 commits in this PR are in the already merged https://github.com/cardano-foundation/CIPs/pull/864 and we need to keep our commit histories clean in this repository.

p.s. to https://github.com/cardano-foundation/CIPs/pull/867#issuecomment-2254853752 - @kozross @Ryun1 to avoid further review on this PR with redundant commits, I'm closing this & please let's continue the review in the resubmitted PR. 😎


created LaunchScreenActivity and inflated FrameLayout with Footer com…

task 12 created LaunchScreenActivity and inflated FrameLayout with Footer component

group_12340.web should have a name suggesting what the picture is displaying or where it is used, for example launcher_image.webp


[web] unclear text rendered when using CanvasKit

Steps to Reproduce

Run flutter create bug.
Update the files as follows: replace main.dart MyHomePage class

class MyHomePage extends StatelessWidget {
  MyHomePage({String title});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: ListView(
        children: [
          Text(
            'Sample Text', // rendered by DomCanvas
            style: TextStyle(fontSize: 24),
          ),
          Row(
            children: [
              Text('Sample Text', style: TextStyle(fontSize: 24)),  // rendered by BitmapCanvas
              SizedBox(
                width: 100,
                child: TextFormField(
                  maxLines: null,
                  style: TextStyle(fontSize: 24),
                ),
              )
            ],
          )
        ],
      ),
    );
  }
}

run

Expected results:
The drawing of the two Sample Text strings will look the same
Actual results:
Text that rendered by CanvasKit is unclear.

It was not output to the log, windows Display Scale Factor is 150%.

Logs
[  +94 ms] executing: [C:\tools\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +43 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] e682ec711a8c05fe78157595240b392de339fa32
[        ] executing: [C:\tools\flutter/] git tag --points-at HEAD
[  +28 ms] Exit code 0 from: git tag --points-at HEAD
[   +1 ms] executing: [C:\tools\flutter/] git describe --match *.*.* --first-parent --long --tags
[  +42 ms] Exit code 0 from: git describe --match *.*.* --first-parent --long --tags
[        ] 1.22.0-9.0.pre-109-ge682ec711
[   +7 ms] executing: [C:\tools\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +22 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/master
[        ] executing: [C:\tools\flutter/] git ls-remote --get-url origin
[  +20 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +45 ms] executing: [C:\tools\flutter/] git rev-parse --abbrev-ref HEAD
[  +20 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] master
[  +39 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +16 ms] executing: C:\Users\user\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +30 ms] List of devices attached
[   +4 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +46 ms] Multiple devices found:
[  +14 ms] Web Server (web) • web-server • web-javascript • Flutter Tools
[   +1 ms] Chrome (web)     • chrome     • web-javascript • Google Chrome 85.0.4183.83
[   +1 ms] [0]: Web Server (web-server)
[        ] [1]: Chrome (chrome)
[   +1 ms] Please choose one (To quit, press "q/Q")
[        ] :
[+2875 ms] 1
[ +120 ms] Generating C:\Users\user\Projects\test\bug\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +55 ms] Launching lib\main.dart on Chrome in debug mode...
[  +51 ms] Updating assets
[  +61 ms] Syncing files to device Chrome...
[  +28 ms] Generating C:\Users\user\Projects\test\bug\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +50 ms] <- reset
[   +4 ms] C:\tools\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev C:\tools\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root C:\tools\flutter\bin\cache\flutter_web_sdk/ --incremental --target=dartdevc --debugger-module-names
--experimental-emit-debug-metadata -Ddart.developer.causal_async_stacks=true --output-dill C:\Users\user\AppData\Local\Temp\flutter_tools.7c94f3e9\flutter_tool.ab6b3de2\app.dill --libraries-spec file:///C:/tools/flutter/bin/cache/flutter_web_sdk/libraries.json --packages
.packages -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-root
C:\Users\user\AppData\Local\Temp\flutter_tools.7c94f3e9\flutter_tools.d610cbf5 --filesystem-scheme org-dartlang-app --initialize-from-dill build\cache.dill.track.dill --platform file:///C:/tools/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill
[   +7 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[+7302 ms] Syncing files to device Chrome... (completed in 7,387ms, longer than expected)
[        ] Synced 26.7MB.
[        ] <- accept
[        ] Caching compiled dill
[ +133 ms] [CHROME]:
[   +1 ms] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:64307/devtools/browser/2f90d7c7-854c-4214-86f8-b2c1cc5c33e6
[+4695 ms] Debug service listening on ws://<IP_ADDRESS>:64336/Vci-kqmD2PM=

[ +198 ms] Debug service listening on ws://<IP_ADDRESS>:64336/Vci-kqmD2PM=
[   +1 ms] Warning: Flutter's support for web development is not stable yet and hasn't
[        ] been thoroughly tested in production environments.
[        ] For more information see https://flutter.dev/web
[        ]   To hot restart changes while running, press "r" or "R".
[        ] For a more detailed help message, press "h". To quit, press "q".

Analyzing bug...
No issues found! (ran in 1.4s)

[√] Flutter (Channel master, 1.22.0-10.0.pre.109, on Microsoft Windows [Version 10.0.19041.450], locale ja-JP)
    • Flutter version 1.22.0-10.0.pre.109 at C:\tools\flutter
    • Framework revision e682ec711a (7 hours ago), 2020-09-09 10:52:27 +0200
    • Engine revision d1d848e842
    • Dart version 2.10.0 (build 2.10.0-98.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\user\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[!] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.48.2)
    • VS Code at C:\Users\user\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.14.1

[√] Connected device (2 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 85.0.4183.83

! Doctor found issues in 2 categories.

Hi @mizuirot
I see there's an open issue addressing the case you described https://github.com/flutter/flutter/issues/62291.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Fix HOW-TO

Description

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.
Resolved or fixed issue:
Affirmation

[ ] My code follows the CONTRIBUTING.md guidelines

LGTM


Blog posts are not included in the Sitemap.xml

Hi there,
First of all, thank you for your awesome work.
Recently, I was wondering why my blog posts are not indexed in Google Search Console automatically, then I realized that the generated Sitemap.xml does not contain the blog posts I have written.
Is there any workaround for this issue?

Are you sure? I just checked it seems the blog posts are being included in the sitemap. For example check the demo site: https://alshedivat.github.io/al-folio/sitemap.xml


[MM-35441] Remove old cert, changes for building node modules

This PR removes the existing codesign cert for Windows (we have a new one in CircleCI), also made a change to upgrade node-gyp since the old version wasn't working on the Windows box.
NONE

/cherry-pick release-5.0

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/desktop
   38270fc..3ecdd3d  master      -> upstream/master
   f078403..e3d9902  release-5.0 -> upstream/release-5.0
 * [new tag]         v5.0.2      -> v5.0.2
 * [new tag]         v5.0.2-rc1  -> v5.0.2-rc1
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-desktop-#1863-upstream-release-5.0-1641307465
Switched to a new branch 'automated-cherry-pick-of-desktop-#1863-upstream-release-5.0-1641307465'
Branch 'automated-cherry-pick-of-desktop-#1863-upstream-release-5.0-1641307465' set up to track remote branch 'release-5.0' from 'upstream'.

+++ About to attempt cherry pick of PR #1863 with merge commit eab1f32a3568253e7adb09022b5bd6c8a8681708.

error: could not apply eab1f32... [MM-35441] Remove old cert, changes for building node modules (#1863)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU package-lock.json
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.


Incorrect feedback current scaling.

The mc_x::feedback_t::current() uses the incorrect current_per_lsb value.

Did you determine the correct current_per_lsb? If not, I can look this up.

it should be 0.01A/lsb i believe


Added detail to UserCreationForm

Adds details of fields / properties of UserCreationForm
Ticket https://code.djangoproject.com/ticket/27294#comment:1

What I'll do is cancel and make a fresh PR, this one looks a little squirrelly


chore(cdk-v2-import-fix): Fix the import statement for cdk v2 rewrite import utility to work

Issue #, if available:
Description of changes:
Fix the import statement for cdk v2 rewrite import utility to work
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
Commit ID: 205aeea426cc86d9a43a0c545d03bc3a51d755b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Add UPAM university.

@alexventuraio First stage of verification passed, official domain is upamozoc.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: http://descargas.upamozoc.edu.mx/Documentos_pagina/SERV_ESC/upam.pdf

upamozoc.edu.mx

First stage of verification passed, official domain is upamozoc.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: http://descargas.upamozoc.edu.mx/Documentos_pagina/SERV_ESC/upam.pdf

@philipto thanks for following up on this, that's right, so do you think I should include upamozoc.edu.mx in this repo?

@alexventuraio

do you think I should include upamozoc.edu.mx in this repo?

No, thank you.
Thank you for your patience while waiting for a review and processing your request. Pull request merged.

@alexventuraio

do you think I should include upamozoc.edu.mx in this repo?

No, thank you. Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Sweet, when do you think it should be ready to apply for students and teachers license? @philipto


fix: Fix the return value of Expression comparison

hey thanks for those quick fixes, that's really awesome.


Append !important to float right & left

To force element to float when you really want to apply these specific classes

@Leyka  Don’t use !important. You can solve making use of specificity.


Checking for Visual C++ occur fatal error

I installed Visual C++ 2010 in default paths, but run setup.python fail:

E:\project\build-virtualbox-in-windows\script>call build_vbox.bat
[+] Configure VirtualBox build setting
Shell inheritance test: OK
Source path: OK
Checking for kBuild...
Target architecture: amd64.
Host architecture: amd64.
Found kBuild: C:/VBoxBuild/VirtualBox/kBuild
Found kBuild binaries: C:/VBoxBuild/VirtualBox/kBuild/bin/win.amd64
Checking for Windows DDK v7.1...
Found Windows DDK v7.1: C:/WinDDK/7600.16385.1
Checking for Visual C++...
fatal error: PathAbs(C:\Program Files (x86)\Microsoft Visual Studio 10.0) attempted to return filename with problematic characters in it (C:\PROGRA~2\Microsoft Visual Studio 10.0). The tool/sdk referenced will probably need to be copied or reinstalled to a location without 'spaces', '$', ';' or '&' in the path name. (Unless it's a problem with this script of course...)

should I install in other path or any solution?

It seems that the error comes not from ours but from configure.vbs in your downloaded VirtualBox project. And the problematic logic exists, I guess by your log, in PathAbs function.
I've not seen this type of error before and I'm not sure why it does not work in your environment, but, yes, as you said it might be resolved if you install VS to the other location without 'spaces', '$', ';' or '&' .


Preserve whitespace when indenting code block

When indenting text in a code block, the indentation is reset when the cursor moves to the next line.
Observed result

Expected result
A code block should allow arbitrary indentation. E.g. two spaces, four spaces, tabs, etc.
Environment

Ubuntu 16.04
KDE Plasma 5.8
Firefox 49.0.2
Eve master(https://github.com/witheve/Eve/commit/3a3f9f90c4e5688eb039e8fcd0ec81efc8d82249)

That behavior will only happen if you are not in a code block. Are you
perhaps in an inline code instead? Since we adopted markdown as our
language we use the same terminology, but I do worry it may confuse people.
On Mon, Oct 31, 2016, 09:34 Brylie Christopher Oxley <
<EMAIL_ADDRESS>wrote:
When indenting text in a code block, the indentation is reset when the
cursor moves to the next line:
[image: peek 2016-10-31 15-32]
https://cloud.githubusercontent.com/assets/17307/19855884/7bdb9e80-9f7f-11e6-8bd7-6d890eadd920.gif
Expected result
A code block should allow arbitrary indentation. E.g. two spaces, four
spaces, tabs, etc.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/witheve/Eve/issues/498, or mute the thread
https://github.com/notifications/unsubscribe-auth/AATKDoEVVixcgbbzHc3d1Fxg7zLHA9DMks5q5e51gaJpZM4KlBA1
.

@joshuafcole we should rename it to something else. Calling it code in our context is really only going to be confusing.


[Boss Idea] Aoe viability boss {The Swarm}

This boss is to open players to ideas of not only using hard right-click carries to end or play the game with.  The boss also encourages the pick of high aoe damage heroes like lina, crystal maiden and earthshaker.
The boss starts using different abilities at different health threshold:
1st Ability(100% health): "spiderlings" with 1 health starts spawning from the boss. The "spiderlings" have zero collision box.
2nd Ability(90% health threshold): "spiderlings" start spawning from the side of the arena in small squads. They have 1 health. They crawl towards the players and attack them.  The "spiderlings " have zero collision box. Stop spawing from boss location.
3rd ability (60% health threshold): A swarm is lauched from the side from the arena damaging players if it hit. Do refer to weavers swarm for reference. It is possible that can be warning before it launches. The swarm have four different health box and will be destroyed once all four box are destroyed. Do refer to gyrocopter homing missile as reference ( the missile can be destroyed as it is flying, thats the important part). The swarm is not magic immune unlike the gyrocopter missile. Can be destroyed by magic damage. Each health bar is 1 hp.
4th ability (30% health threshold):
The boss summon flying bugs which are immune to all types of cleave including  Kunnka's. The bugs are still not immune to magic damage. Have relatively  reasonable amount of health.
That's all the abilities. Let me talk more why the boss have  such abilities and why players will be able to notice the viability of aoe heroes for this situation.  As "spiderlings" appear at the side of the arena, heroes have with cleave cannot just causally cleave the "spiderlings". The cleave will only fly towards the boss, as "spiderlings " will attack the back of the players. Thus players will have to make a decision to attack the boss or the "spiderlings". This is to make it harder for right-clickers like sven to deal with the situation. On the other hand, aoe heroes like lina will have a easier time because of the heavy aoe, additionally she also gain attack speed boost for doing so.
It is possible that player might just ignore the "spiderlings" till it is too late,  like undying tomestone zombies (till you realize is a problem). The "spiderlings" should be giving zero xp and gold or else its too op. Items like mithil hammer for range heroes may not hit the "spiderlings" because the it is on the boss ( the distance between the boss and the heroes should be high enough that the spiderlings around the hero cannot be hit, of course heroes like TA can benefit becuase of the low attack range). Thus mrithil hammer is useless too. Unless they make a desision to actually attack the "spiderlings".
The main purpose of the boss it to make players choose aoe carries or support to run for the game. Or else everyone is going to just pick pa and stuff and start one shoting everyone. The weakness of such hard carries is the fact that they cannot hit spiderlings" easily, thus I suggested this boss.
That being said, battlefury and such items can be picked up and I agree it is an option to deal with the boss but as I also mentioned earlier is not that easy as one thinks to use them effectively against the boss.
Suggestions: fourth ability can be done without. Should be a 20-30minute killable boss. Prevent radiance from being picked up and hard countering the spiderlings"  therefore making the boss a small fly in an ointment ( fly... bugs...get it? No?.. Ok). The boss can be captured after death, like Hots mercenary. Cause a wave of spiderlings to travel to the enemy side to bug them a little (pun intended).
Or run to when captured "spiderlings" run to the other side to attack neutral camp and deny themselves after that which slows down their farm.
Need not be spiderlings graphics, get creative ;) .
Thats all i have for this boss ;)

It is interesting to note that how subtle things like spawn location can greatly affect the boss fight. I only noticed it when I thought about it.

Another suggestion is that when bugs spawn  they run to the enemy side to kill the neutral creeps and then deny themselves. Slows down enemy farm.

I was riding on the mercenary idea in the second comment after the boss capture. No to be confused with the "spiderlings" during boss fight.

Edit: sry a mistake in a crucial sentence " The swarm is not magic immune unlike the gyrocopter missile" I put "...like the gyrocopter missile". Also, just to make it clear ability one is disabled when ability two is active.

@GrandShinobi there should be a small edit icon in the top right of all of your comments; I suggest you just correct them instead of apologizing :wink:

Oh ok thanks! Used the mobile version, didn't know they had that option :D

I quite like this one.


Can't build APK

When trying to get the APK compiling on NixOS, I get the following:
> cargo apk build
Using package `hello_world_android_egui` in `/home/ada/Projects/rs/hello_world_android_egui/Cargo.toml`
Warning: Environment variable ANDROID_SDK_ROOT is deprecated (https://developer.android.com/studio/command-line/variables#envar). It will be used until it is unset and replaced by ANDROID_HOME.
thread 'main' panicked at /build/cargo-apk-0.9.6-vendor.tar.gz/ndk-build/src/ndk.rs:89:14:
Failed to read source.properties: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is confusing to me, because there was no source.properties in the git repo, yet somehow apparently it worked before?
Out of desparation, I tried xbuild too (as suggested by cargo-apk's README.md) and it gives me:
> x build --arch arm64 --platform android
[1/3] Fetch precompiled artifacts
Error: No such file or directory (os error 2)

Figured it out. Now I'm getting another error about 'no platforms installed'. Closing.


fix: fix field().

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.6 seconds
load time: 499 seconds
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129161227_clickbench_pr_86548.html


LGTM is going to be shut down on 16th of December - please migrate to CodeQL

Blog post: https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/

@gicmo @croissanne do we even use LGTM.com? I see it enabled for osbuild and image-builder, but that's about everything I can find.

I enabled it for IB as I liked the static analysis on PRs; it does find issues sometimes. Time to migrate I guess!

Do OSBuild needs to migrate too ? Or just IB ?

I migrated ib, https://github.com/osbuild/image-builder/pull/485

Thanks, I'm closing the issue then.

This issue might still be relevant for the OSBuild repo. LGTM no longer works. If you want to keep scanning your repo, you should migrate to CodeQL. Please see: #1195


Add a message about the badge plugin

          1 Warning

:warning:
Please provide a changelog summary in the Pull Request description @ohayon

  Generated by :no_entry_sign: Danger

I don't believe we have talked to them, but they are also the ones that are managing the plugin as well 🔌

@ohayon My feeling is that it would make sense to ping them to let them know still :)


Account provisioning framework stepfunction fails at aft-account-provisioning-framework-account-metadata-ssm lambda

I am unable to complete the account vending process as account provisioning errors out. The account id xxxx... is my aft management account id while yyyyy... is the account id of the partially created new account.
I'm not sure what step I might have missed but I did grant AWSAFTExecution access to the AWS Control Tower account factory portfolio in AWS Service Catalog for the AFT management account so I know its not that.
{
  "Error": "ClientError",
  "Cause": "{\"errorMessage\":\"An error occurred (AccessDenied) when calling the AssumeRole operation:
   User: arn:aws:sts::xxxxxxxxxxxx:assumed-role/AWSAFTAdmin/AWSAFT-Session is not authorized to perform:
   sts:AssumeRole on resource: arn:aws:iam::yyyyyyyyyyyy:role/AWSAFTExecution\",\"errorType\":\"ClientError\",
   \"stackTrace\":[\"  File \\\"/var/task/aft_account_provisioning_framework_account_metadata_ssm.py\\\", line 87,
   in lambda_handler\\n    target_account_creds = utils.get_assume_role_credentials(\\n\",\"  File \\\"/opt/python/
   lib/python3.8/site-packages/aft_common/aft_utils.py\\\", line 247, in get_assume_role_credentials\\n
   assume_role_response = client.assume_role(**assume_role_params)\\n\",\"  File \\\"/opt/python/
   lib/python3.8/site-packages/botocore/client.py\\\", line 386, in _api_call\\n
   return self._make_api_call(operation_name, kwargs)\\n\",\"  File \\\"/opt/python/lib/python3.8/site-packages/
   botocore/client.py\\\", line 705, in _make_api_call\
   \n    raise error_class(parsed_response, operation_name)\\n\"]}"
}

I'm unsure how to proceed. Should I try to login to the new account even though the pipeline hasn't really been created yet? Or was it a session credentials timeout issue and I should try to rerun the step function with the same input?

The fix was to populate the remaining 3 repositories mentioned in step 3 in the post deployment steps. I had only populated the account request repo. After populating  the other 3 using the templates here, I then pushed a minor edit to the account request repo which triggered a second run.


Automated cherry pick of #1551: add without_user_meta filter

Cherry pick of #1551 on release/2.8.0.
#1551: add without_user_meta filter

/lgtm
/approve


Update regression tests/functions

lets merge first and
@changsiyao please change your scripts accordingly

OK, everything passed. I will merge this and fix mine scripts.


Revealing only when scrolling up

For some reason, the reveal effect only happens when I am scrolling up, am I doing something wrong or it's some issue with the last build?
Check this: http://raftelti.me/dest/

Hey @raftelti, see this comment, in my tests, your demo was fixed by applying:
html, body {
  height: 100%;
}

Thanks!


Signature verification

At the moment signatures of the digital covid certficate are not being verified. This is a security risk
It would be nice to have a js-function something like verifySignature(covidCertificate: string, publicKey: string): boolean
Following packages could be useful when solving this problem

x509_parser for working with PEM certificates
elliptic_curve for verifying the signature

I made a start on the signatures branch. First tests show that it is possible.


Syntax highlighting stumbles after a function call inside a JSX tag

With a buffer containing the following:
let a = (
    <b>
        { f() }
    </b>
);

let someVar = 20;
someFn(200);
// ...

For some reason, afer the closing parenthesis in f(), the syntax highlighter enters some weird mode, subsequently highlighting 'let' as an error token and failing to correctly highlight the following lines:

Changing f() to f solves the problem, as does adding any additional tokens before, in most cases:

I have no idea how Vim's syntax highlighting works internally, so I'm kind of lost here :(

I'm sorry but JSX is not supported.

Hi, @HerringtonDarkholme
Just to clarify, this means TSX/*.tsx file is not supported?

No, I won't support tsx.

Gotcha.
In that case, would you consider reverting this commit?
Or maybe use setfiletype instead as to not override other plugins that may handle it?

@hdra Thanks for the suggestion. I think it is a reasonable choice. I have removed tsx from filetype plugin.


update translations

pull from transifex

Some of the translations are updated. It's time to pull from Transifex again.

Will do after we get unit tests back up. It may take a while for them to show on the site though.


Suggestion: Avoid drill comissions

IMO, most players who have been playing for a while do not do drill commissions since we have too many of them anyway and are not in danger of running out.
It would be great if we can have an option in the config file and code to avoid doing drill commissions.
However, I appreciate this may be very tricky to implement, so feel free to close this issue out if so :p

But aren't there drill commissions with other rewards like oil or gold too? And the ones with only drills and exp as rewards generally pop out after you have finished the others, since they usually spawn first.

And they give larger amounts of experience iirc.


HDDS-5445 Wrong formatting of comments

https://issues.apache.org/jira/browse/HDDS-5445

Thanks @littleboy547 for working on this.
The license header is not for Javadoc (does not document the class or any other code construct). Thus it should start with /*, not /**. AuditMessage is already fine and should not be changed.
However, this problem affects several Java files (I found 1299). If you would like to address this, can you please fix them in one fell swoop? Creating a Jira issue and a PR for each of them would be tedious.

Thanks @littleboy547 for working on this.
The license header is not for Javadoc (does not document the class or any other code construct). Thus it should start with /*, not /**. AuditMessage is already fine and should not be changed.
However, this problem affects several Java files (I found 1299). If you would like to address this, can you please fix them in one fell swoop? Creating a Jira issue and a PR for each of them would be tedious.

Thank you for your reply, I will modify all the relevant files based on this jra, thanks!

I will modify all the relevant files

Thanks a lot.  There are quite some conflicts as your branch is 1214 commits behind apache:master.  Can you please update it?

Just wondering, is it possible to have a checkstyle or rat rule to enforce this? I suspect after this change new files will still sometimes be created using /** and we will be back to mixed comment types before long. Not a huge deal and certainly does not need to block this PR, just wondering if its feasible to add since I don't have a lot of experience in this area.

is it possible to have a checkstyle or rat rule to enforce this?

Yes:
<module name="InvalidJavadocPosition"/>

/pending need to resolve conflicts


Peer to peer code review.

Hi @AbdifatahYasin1
Good job so far!
There are some issues that you still need to work on.
(Highlights) Good Points: 💪

Good commit messages. :heavy_check_mark:
No linter errors. :heavy_check_mark:
Followed Github flow :heavy_check_mark:
Professional README file. :heavy_check_mark:
All features are working properly :heavy_check_mark:

Required Changes ♻
*Please fix the alignment of your Input tasks field and your list items.

Cheers and Happy coding!👏👏👏

thanks


openai version is not getting updated to a new one 'for some reason'.

This wont allow Lab 02 - get available model deploys will fail due to inconsistency

@gkaleta, can you please elaborate. The get models api has nothing to do with a deployment or its version, it is a rest-based API version that matters.


Lights normals inverted when full body tracking fix

the light directions and normal maps are working weird in many shaders when full body tracking fix is used.

THe fbt fix only moves a few bones around, so it don't make sense that normals would be effected by it. Are you sure that you didn't change anything else?

I simply mark this option and that happens, but if it's not active it works well


issues to fix on libuv master

Discovered in the process of working on https://github.com/libuv/libuv/pull/2649:

[x] The tests from #849 are failing on my machine due to a mistaken expectation on the reliability of IEEE floating point math on an x87
[x] (#3246) The #2492 tests need to be added to test/test-list.h
[x] The "remove support for FreeBSD < 10" PR needs to be repeated (#984)
[x] The switch from gnu89 to gnu99 PR needs to be repeated (in uv.gyp)
[ ] affinity tests on win10-vs2017-arm64 are broken
[x] (#3247) need to fix thread-affinity support on android:
r = sched_getaffinity(pthread_gettid_np(pthread_self()), sizeof(cpuset), &cpuset);
[ ] need to remove VS2013 from CI (https://github.com/libuv/libuv/pull/966)

I am going to call this list complete enough


recognizer have no 'addPhrase'

I wrote a recognizer project with js sdk, which can run perfectly. Now I want to rewrite it with Go sdk, but I find that some API are missing,
such as 'addPhrase',
Will it be added in the future?

Hi there,
Thanks for reaching out. Currently you are correct that it isn't supported in Go and I cannot give you a date when it will be supported, but I can confirm it is on our list of requested features.

Is there any update regarding this issue? If not then please share how can I add custom phrases for multiple languages because I have to add a phrase in around 25 languages. Currently, I have only one solution for it I have to create a custom model for each language.


What is the Python equivalent of your library or do you have a Python implementation?

I am trying to get this library s functionality to work inside Python. Do you have a Python version of this library or any plans to implement one? If not what do you think would be a Python equivalent?
Thank you for your time

Not sure if this would work for you: https://pypi.org/project/html-sanitizer/


Added 'fill selection' command to grid map editor

This commit adds a 'fill selection' command (shortcut: shift+f) to the
grid map editor, making it easier to block out large parts of grid maps.
The new command is equivalent to the existing 'clear selection' command
except that it fills the selection with the currently selected block
instead of the empty grid cell.

Some questions about it, would it not better to just fill the outside of the selection? making the inside also contain tiles seems kind of like missing the point.

i would also rename it to stroke selection or something like that, I also would have expected fill to be a bucket fill

There are many operations that could make sense for a grid/voxel-based editor, but I lack experience myself to see which ones would be the good one. Maybe @ol-smaug has some ideas based on his voxel edition experience?

I'm not sure how much help I can be right now since I'm still working out the same sort of things with my rewritten map editor and voxel editor, but I can see both a box/block mode (as in this commit) and a fill tool being useful. In both of my editors, I have a box mode for dragging and placing large areas of tiles/voxels at once, and plan to also include a separate fill tool to fill/replace existing areas (with a "contiguous" option to delimit which are affected). In general, I've been taking some inspiration from MagicaVoxel to determine which operations would be useful.


How to search for emails and permanently delete them?

Hi,
I was looking for ways to permanently delete emails after applying filters. Does the gem support it now?
I know delete! moves them to trash, but once an email is received with the same subject line the emails from trash are moved to their original folder again.
Thanks!

This issue was moved to gmailgem/gmail#87


[Question/Suggestion] Unified Utils

I see a lot of boilerplates for indent, puts-cmd, puts-step, etc. across may buildpack repos. Why not have a have these things in a separate repo called heroku-buildpack-utils and have them in environment (in the docker image) be default? Or some other means of utilizing the functions. This will:

Reduce the amount of boilerplates Buildpack authors write.
Will standardize these conventions of outputs.
Custom buildpack Docs can be improved.

Apologies for creating an Issue for this matter. Did not know if this the right way to ask developers. Just had to ask this somewhere.

We're working on it :)


Bugs when switching between sections using the .move() function.

This problem is closely related to issue #90 and is a way I tried to resolve the issue.
The codepen is similar to the two there, but tries to circumvent the issue by calling the .move() function to manually switch between sections when the links are clicked. Here is the pen: http://codepen.io/Adam0410/full/NNdGrb/.
The code is the same, but at the end of the javascript you can see a few jquery calls to .click on each of the buttons, and then running the scrollify move command to the relevant sections.
If you try using these buttons to transition between sections, you'll see most of the time that during the transition the first slide with the text on it will appear for a split second before the animation is done. This is the bug when switching between sections.
As with the previous issue, I have tested and this occurs when I view my local files normally in my browser (chrome) and is not a codepen only issue.

Fixed it by removing the # from href's in the  tags


Improve commands in the contributing docs

Split pip install -r requirements/dev.txt && pip install -e . into separate commands to make it work on Windows.
Add commands group for the command to build docs.

&& should work on Windows. I didn't split it up because I wanted contributors to treat it as one install command, not multiple steps that they could miss.

I think it's not working on PowerShell...Not sure if it's due to the version, will check it tomorrow. Maybe we could add a commands group here?

The pipe operators only supported in PowerShell 7.0+, and it's not supported in Windows PowerShell. So I think it's better to add a command group for it.

Just confirmed the following on Windows CMD:

pip install -r requirements/dev.txt && pip install -e . I don't want to add all this extra markup/explanation just for powershell, let's just leave that out unless someone runs into an issue.
make html works, you don't need to do .\make.bat.

make html not working on PowerShell... Ok, I will close this PR, then update related PRs to remove the explanation for make html.


Query_params can be too wide, returning unintended object.

Context - using state: present or state: absent with intersight_rest_api.py module (see main function)

if we are to use update_method: patch

If Query params is not existant or returns more than one item, the moid of the object that is picked up is the first of the list, not the object we might have wanted to modify. This leads to overriding the current config of a random resource (within resource_path), not the one intended.

if we are to use update_method: post and state:absent

if Query params is not existant or returns more than one item, the moid of the object that is picked up is the first of the list, not the object we might have wanted. This leads to deleting the a random resource (within the resource_path) that may be in usage.

Please enforce query param as mandatory, non-ambiguous for disruptive actions as patch/delete and enforce that only one item is returned when checking if an item already exists - mandating query to be granular enough.
See below code used to test on task: Create KVM Policy
- name: CreatePolicy
  hosts: all
  connection: local
  gather_facts: false
  collections:
    - cisco.intersight
  vars:
    api_info: &api_info
      api_private_key: "{{ api_private_key }}"
      api_key_id: "{{ api_key_id }}"
      api_uri: "{{ api_uri | default(omit) }}"
      validate_certs: "{{ validate_certs | default(omit) }}"
      #state: "{{ state | default(omit) }}"
    org_name: "{{ organization_name | default('default') }}"
  tasks:
    #Get parameters to run workflow
    - name: "Get Organization Moid"
      cisco.intersight.intersight_rest_api:
        <<: *api_info
        resource_path: /organization/Organizations
        query_params:
          $filter: "Name eq '{{ org_name }}'"
      register: org_resp
      delegate_to: localhost
    - name: "Print Organization"
      ansible.builtin.debug:
        msg: org_resp is  {{ org_resp.api_response.Moid }}
    - name: create KVM Policy
      cisco.intersight.intersight_rest_api:
        <<: *api_info
        resource_path: /kvm/Policies
        #query_params is MANDATORY as there's a risk to overwrite similar policies (first one returned) if query is not set.
        #Test parameters
        query_params:
          $filter: "Name eq '{{ inventory_hostname }}'"
        update_method: post
        state: absent
        #end of test parameters
        api_body: {
            "Organization": {
                "ObjectType": "organization.Organization",
                "Moid": "{{ org_resp.api_response.Moid }}"
            },
            "Name": "{{ inventory_hostname }}",
            "Tags": [],
            "Description": "this is an Ansible Generated Policy",
            "Enabled": true,
            "MaximumSessions": 2,
            "RemotePort": 2068,
            "EnableVideoEncryption": true,
            "EnableLocalServerVideo": true,
            "TunneledKvmEnabled": false
          }
      register: api_response
    - name: print API api_response
      ansible.builtin.debug:
        msg: api response is  {{ api_response }}

To avoid breaking existing playbooks, I've added a warning when multiple resources are returned from a query when return_list is False:
TASK [Get Policies]
[WARNING]: More than 1 resource found, returning the 1st one
--check mode can be used to check for the warnings ahead of any possible changes.  You can also set return_list to True to always get all results from a query to check for multiples.  Querying by full name and organization will return single results since names are unique within an org.


always error output: Ignoring redcarpet-3.5.0 because its extensions are not built. Try: gem pristine redcarpet --version 3.5.0

brew config output
Ignoring redcarpet-3.5.0 because its extensions are not built. Try: gem pristine redcarpet --version 3.5.0
HOMEBREW_VERSION: 3.0.1-93-g53d840c
ORIGIN: https://github.com/Homebrew/brew
HEAD: 53d840c969fbe7f7cc736f604a486753314aa218
Last commit: 10 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 703451fe242d959d029d867909ffd92f0d522ffd
Core tap last commit: 8 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.1s9VryR1ZM/org.macosforge.xquartz:0
HOMEBREW_EDITOR: /usr/local/bin/mate -w
HOMEBREW_MAKE_JOBS: 4
Homebrew Ruby: 2.6.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: quad-core 64-bit kabylake
Clang: 12.0 build 1200
Git: 2.30.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 10.15.7-x86_64
CLT: <IP_ADDRESS>.1.1610135815
Xcode: N/A
XQuartz: 2.7.11 => /opt/X11
brew doctor output
Ignoring redcarpet-3.5.0 because its extensions are not built. Try: gem pristine redcarpet --version 3.5.0
Your system is ready to brew.

[X] The brew doctor above contains no "Warning" lines.

What were you trying to do (and why)?
update or upgrade
What happened (include all command output)?
usually showing
: Ignoring redcarpet-3.5.0 because its extensions are not built. Try: gem pristine redcarpet --version 3.5.0
What did you expect to happen?
no output
Step-by-step reproduction instructions (by running brew commands)
brew doctor, brew update, brew upgrade...

You probably have something broken in ~/.gem/ruby/2.6.0. If you have<EMAIL_ADDRESS>installed then you can try uninstall that gem.

For further help, you can ask here: https://github.com/Homebrew/discussions/discussions

Thank you. That was solved.