No .gitmessage file found to write to

Git mob 0.2.2
Git 2.10.1.windows.1
Window 10
Node 8.11.1

Description
Changing author throws a error saying no such file or directory open and the .gitmessage file is not updated
Steps to Reproduce

Command git mob [author]
Unhandled error
Co-authors not updated

Expected behavior: .gitmessage file to be updated with co-authors
Actual behavior: .gitmessage file not updated with co-authors
Reproduces how often: 100% of the time

What the current working directory when the error occurs?

It is where the .git folder is

This test fails on my change for looking for the .gitmessage file.

Fixed in v0.2.3?

I can confirm it works fine. 👍


Adding @JsonProperty to all POJO fields

Hello everyone, because i am interested to convert from POJO to json and reverse, in order to save the json to a database,i would like to ask you if any of you, finds a good idea to include a @JsonProperty annotation to every field on the main POJOs of the project (Orderbook,LimitOrder,UserTrades etc). I am looking forward for your answers and suggestions.Thank you

you can serialize to JSON right now without adding @JsonProperty to any field so I don't see how that would help
only deserialization will have a problem with the fact that we use the builder pattern so if you want to do something in this area then making the builder (not the value object like CurrencyPair or Trade it self) usable by Jackson is the way to go

Hello @walec51 . You are right, the serialization is not a problem the JSON to POJO is. I  small Google search about deserialize builder pattern brought me this annotation (@JsonDeserialize(builder=ValueBuilder.class). Are you referring to something like this? Thanks for your answer.

yep, integration the builder with Jackson is the way to go


feat(NX-3318): coditionally display "Bids" or "Inquiries" on the Inbox.

This PR resolves NX-3318
coditionally display "Bids" or "Inquiries" on the Inbox
Description

https://user-images.githubusercontent.com/36475005/200625104-8266e5b3-0ed4-4d8b-8d20-d404259fc05a.mov
PR Checklist

[ ] I tested my changes on iOS / Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[ ] I hid my changes behind a feature flag.
[ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

So nice to this moving forward!! 🎉
CCing @MounirDhahri here for awareness

@jo-rs @lidimayra @MounirDhahri
Thank you all for reviewing and @gkartalis for coauthoring this.
We have now added tests, feel free to have another look 😊


Add sqlite support

All the tests already seem to run on sqlite, so there (in my mind) is no reason to not provide support for it.
The only change needed was to lower the delete chunk size.

Looks nice, thanks! Is 999 a magic number, though? Or is it documented somewhere in SQLite docs? Also I'd prefer turning it into a variable based on the database engine: $this->chunkSize = engine_is_sqlite ? 999 : 65535 of sort.

The 999 was based on that SQLite's default max expression tree (SQLITE_MAX_EXPR_DEPTH) is 1000. It was a little while ago I first did this on my own koel install, but I remember running into that limit and lowering it then.
I'll have a look at making the chunksize dependent on the database used :)

I had a go at making it DB type dependent, but I really don't get how to. Perhaps I'm just not used to the laravel way, but from that trait I can't call getConnection (since it should not be called statically) and I can't call it with $this since I'm not in a object context.
Without getting the connection I don't see how to infer the DB type?

A simple check of config('database.default') should suffice I believe.

Any hope of having this merged?
Maintaining the patch locally isn't fun :D

@jvoisin Not in this current state. Please refer to my feedback above. You're welcome to create another PR if @SahAssar isn't any more interested.

Sorry for the delay (like 2 years :D ), I think I got it fixed, but I don't really get the test failures. Could you point me to the direction to start? Nothing in my PR should have affected the authentication in any way.

@SahAssar indeed, the CI error is not related to your code. Retrying.

Can you rebase with master?

Codecov Report

Merging #599 into master will increase coverage by 0.1%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##             master     #599     +/-   ##
===========================================
+ Coverage     67.68%   67.78%   +0.1%
- Complexity      719      720      +1
===========================================
  Files           139      139
  Lines          1773     1763     -10
===========================================
- Hits           1200     1195      -5
+ Misses          573      568      -5

Impacted Files
Coverage Δ
Complexity Δ

app/Traits/SupportsDeleteWhereIDsNotIn.php
57.89% <50%> (+2.33%)
7 <0> (+1)
:arrow_up:

app/Services/YouTubeService.php
61.9% <0%> (-1.74%)
12% <0%> (ø)

app/Services/MediaSyncService.php
84.69% <0%> (-1.31%)
34% <0%> (ø)

app/Listeners/LoveTrackOnLastfm.php
90.9% <0%> (-0.76%)
5% <0%> (ø)

app/Listeners/UpdateLastfmNowPlaying.php
91.66% <0%> (-0.65%)
6% <0%> (ø)

app/Services/DownloadService.php
21.87% <0%> (+2.95%)
14% <0%> (ø)
:arrow_down:

app/Models/Rule.php
84% <0%> (+3.23%)
10% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c197d5...ae58d7a. Read the comment docs.

Thanks!


[FRANCE.TV] Why is this video playable but not downloadable

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.11.22
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

C:\video\TEST1>youtube-dl --proxy xxx.xxx.xxx.xxx:xxxx --all-subs --convert-subs srt --retries 20000 -o "3935.mp4" -v https://www.france.tv/france-3/plus-belle-la-vie/plus-belle-la-vie-saison-16/1105827-plus-belle-la-vie.html
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--proxy', 'xxx.xxx.xxx.xxx:xxxx', '--all-subs', '--convert-subs', 'srt', '--retries', '20000', '-o', '3935.mp4', '-v', 'https://www.france.tv/france-3/plus-belle-la-vie/plus-belle-la-vie-saison-16/1105827-plus-belle-la-vie.html']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.11.22
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.16299
[debug] exe versions: ffmpeg N-89508-g1f1207145a, ffprobe N-89508-g1f1207145a
[debug] Proxy map: {'http': 'xxx.xxx.xxx.xxx:xxxx', 'https': 'xxx.xxx.xxx.xxx:xxxx'}
[FranceTVSite] 1105827-plus-belle-la-vie: Downloading webpage
ERROR: Unable to download webpage: '' (caused by BadStatusLine("''",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpwnp2jh33\build\youtube_dl\extractor\common.py", line 627, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpwnp2jh33\build\youtube_dl\YoutubeDL.py", line 2237, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 464, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 482, in _open
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpwnp2jh33\build\youtube_dl\utils.py", line 2724, in https_open
  File "C:\Python\Python34\lib\urllib\request.py", line 1183, in do_open
  File "C:\Python\Python34\lib\http\client.py", line 1137, in request
  File "C:\Python\Python34\lib\http\client.py", line 1182, in _send_request
  File "C:\Python\Python34\lib\http\client.py", line 1133, in endheaders
  File "C:\Python\Python34\lib\http\client.py", line 963, in _send_output
  File "C:\Python\Python34\lib\http\client.py", line 898, in send
  File "C:\Python\Python34\lib\http\client.py", line 1279, in connect
  File "C:\Python\Python34\lib\http\client.py", line 874, in connect
  File "C:\Python\Python34\lib\http\client.py", line 852, in _tunnel
  File "C:\Python\Python34\lib\http\client.py", line 356, in _read_status

C:\video\TEST1>youtube-dl --proxy xxx.xxx.xxx.xxx:xxxx --all-subs --convert-subs srt --retries 20000 -o "3935.mp4" -v https://www.france.tv/france-3/plus-belle-la-vie/plus-belle-la-vie-saison-16/1105827-plus-belle-la-vie.html
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--proxy', 'xxx.xxx.xxx.xxx:xxxx', '--all-subs', '--convert-subs', 'srt', '--retries', '20000', '-o', '3935.mp4', '-v', 'https://www.france.tv/france-3/plus-belle-la-vie/plus-belle-la-vie-saison-16/1105827-plus-belle-la-vie.html']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.11.22
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.16299
[debug] exe versions: ffmpeg N-89508-g1f1207145a, ffprobe N-89508-g1f1207145a
[debug] Proxy map: {'https': 'xxx.xxx.xxx.xxx:xxxx', 'http': 'xxx.xxx.xxx.xxx:xxxx'}
[FranceTVSite] 1105827-plus-belle-la-vie: Downloading webpage
ERROR: Unable to download webpage: <urlopen error [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond> (caused by URLError(TimeoutError(10060, 'A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond', None, 10060, None),))
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpwnp2jh33\build\youtube_dl\extractor\common.py", line 627, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpwnp2jh33\build\youtube_dl\YoutubeDL.py", line 2237, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 464, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 482, in _open
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpwnp2jh33\build\youtube_dl\utils.py", line 2724, in https_open
  File "C:\Python\Python34\lib\urllib\request.py", line 1185, in do_open

Description

VIDEO URL: https://www.france.tv/france-3/plus-belle-la-vie/plus-belle-la-vie-saison-16/1105827-plus-belle-la-vie.html
In the verbose log above, I've tried to download the video with 2 different French proxies, but neither of them works for me... These proxies do work when it comes to each & every other geoblocked video on France.TV that I test with.
I've made sure the video is perfectly playable, please see the attached screenshots below:

Thank you in advance!
Jacob

You can't expect any reliability from free proxies.

@dstftw But I've used these proxies for ages and they never malfunctioned..!


How do I send JWT when creating a new connection for authentication?

The easy way:
Send authentication in connected event handler, it must be the first request on connection.
The hacking way:
I guess you can hack ActionCable.Consumer.constructor, ActionCable.Connection.contrusctor and ActionCable.Connection.open to add header options, and use it in WebSocket.

I looked at your cookie library (which you mentioned as depricated), and I did it the similar way, append my JWT to websocket protocols and parse it in the server.
[And today I updated the packages and found that rn-action-cable uses funcs from actioncable react :\ ]

The easy way:
Send authentication in connected event handler, it must be the first request on connection.
The hacking way:
I guess you can hack ActionCable.Consumer.constructor, ActionCable.Connection.contrusctor and ActionCable.Connection.open to add header options, and use it in WebSocket.

For the connection to get successfully established on my RoR server, I need to send jwt before getting connected i.e, in the request for websocket connection
And I didn't get the second one, did you mean something like adding to existing headers like protocols?

I looked at your cookie library (which you mentioned as depricated), and I did it the similar way, append my JWT to websocket protocols and parse it in the server.

Did it work?

And I didn't get the second one, did you mean something like adding to existing headers like protocols?

Yes, but I didn't test. And maybe has another way, put the JWT into query params of actioncable's url.  Like this: '/cable?jwt=MY_JWT'. I found an example at http://stackoverflow.com/questions/35501931/send-auth-token-for-authentification-to-actioncable, see the first reply.

Did it work?

Yes, it did, and I created a handy lib just like your cookie lib, and published the same on npm so I can use it just like other libs in my projects...
And reg /cable?token=1234, it could be vulnerable as it may end up in logs and system process information available to others that have access to the server -> more here
So ideally, it's better to encrypt the token when used in urls

Thanks for your sharing.

I have used "react-native-cookie" for setting cookies with token before connect. It works fine.

I have exactly the same use case here, a React Native app, using a JWT to authenticate with the API from my Rails app, and now I'm implementing ActionCable in order to get the realtime updates.
Like @zekedran I don't like to send the JWT in the WS URL so I followed the way he did it, passing the JWT in the protocols of the WebSocket and parsing the request.headers[:HTTP_SEC_WEBSOCKET_PROTOCOL] on the Rails side in order to retrieve the JWT.
That being said, I'm not using @zekedran's library as it seems to have copy of the actioncable while this library perfectly uses the official library.
Instead, what I did is to update the ActionCable.INTERNAL.protocols before to call the ActionCable.createConsumer() :
  // ...
  setupAndConnect() {
    ActionCable.INTERNAL.protocols.push(this.props.jwt)
    const cable = ActionCable.createConsumer(this.props.websocketUrl)
    cable.subscriptions.create(channelName, {
      // ...
    }
  }
  //..

Which does exactly the same as @zekedran's library.

@zedtux can you provide proper example for this?? Also when I just import ActionCable from this library gives me error TypeError: Cannot read property 'split' of undefined. Is this library outdated???

@maharjanaman of course this library is outdated ! As I stated in my comment, a copy of the original library has been imported. Since, newer versions was released, but no updated in this lib. That's the reason why I'm not using it.
What part are you missing that I should share here?

ActionCable is the library, which as the INTERNAL constant.

... unable to get the result.

What does that mean ?


Question about gradient flow during training

Hello. I had a question about your network's computational graph during backpropagation. Since you have return_info=True in your call to self.forward(), would that mean that for your self.training_step() that you are ultimately returning a dictionary called info that contains not only your loss (with which you want to optimize against) but also many other loss terms that also contain valid grad_fn properties?
https://github.com/arneschneuing/DiffSBDD/blob/ca2d2ad4451893ec405308134fdffbe94e298b64/lightning_modules.py#L319
I ask because Lightning is supposed to backpropagate using the loss term only. However, would you agree that it might be safer to explicitly detach all the other loss terms from the computational graph during training_step()?

Hi @amorehead, thanks for another good observation. I haven't had any issues so far but detaching the other variables might be safer indeed. I will consider it for future updates.
Thank you!


Additional Race Options

Some folks wanted additional options to disable hints/spoilers piecemeal without enabling the race option and disabling everything.
I also updated it so that when the race mode is enabled or the option to disable spoiler log is enabled, it actually fully disables location printing in the spoiler log.

It might be better to simply not activate the SpoilerModule entirely but I don't know if there's a good way to do that right now.

Yeah, not really. Because this is provided by the service provider (well, ServiceProviderServiceExtensions really), it's instantiated automatically when we retrieve all the modules. We could have some sort of method to check if it's valid or something and should be kept, but it would still be instantiated.


[test] Fix class_getImageName.swift on 32-bit iOS simulator

The deallocation order is important in these tests, so we need to take autorelease pools out of the equation.
rdar://problem/42178988

buildbot_incremental,tools=RA,stdlib=RDA,test=iOS,type=simulator
@swift-ci Please test with preset

@swift-ci Please smoke test

Oops.
preset=buildbot_incremental,tools=RA,stdlib=RDA,test=iOS,type=simulator
@swift-ci Please test macOS with preset

Oops.
preset=buildbot_incremental,tools=RA,stdlib=RDA,test=iOS,type=simulator
@swift-ci Please test with preset


[Bug]: Can't work on NVIM v0.10.0-dev-742+g12ccea596

Neovim version
No response
Language affected
No response
Query
No response
Strategy
No response
Description
I set up the plugin using following config but it didn't work.

local rainbow_delimiters = require 'rainbow-delimiters'

vim.g.rainbow_delimiters = {
    strategy = {
        [''] = rainbow_delimiters.strategy['global'],
        vim = rainbow_delimiters.strategy['local'],
    },
    query = {
        [''] = 'rainbow-delimiters',
        lua = 'rainbow-blocks',
    },
    highlight = {
        'RainbowDelimiterRed',
        'RainbowDelimiterYellow',
        'RainbowDelimiterBlue',
        'RainbowDelimiterOrange',
        'RainbowDelimiterGreen',
        'RainbowDelimiterViolet',
        'RainbowDelimiterCyan',
    },
}

Do I forget to config other thing like tree-sitter? Or is cause by my color theme: gruvbo?

Install it like any other Neovim plugin. You will need a Tree-sitter parser for each language you want to use rainbow delimiters with.

Sorry...I guess it cause by this...


3F files

Hello,
Is it possible to have the 3D files in .obj ?
Thanks

Hi, I don't have the possibility to export files as .obj

can you do .step ?

Added .step

Thanks a lot


Validation not work

I was trying to work through validation of the model but it was not working.
I used as seen in other incidents
$this->model->insert($data , true);
And even then it was being inserted when it was not available fields .
Checking the code line 209 saw no sense be FALSE the skip_validation for him to validate , to change this worked properly.
if ($skip_validation === FALSE)
{
    $data = $this->validate($data);
}

Excuse my English, because I am Brazilian and I used the google translator.

Sorry, my mistake was not properly use:
protected $skip_validation = FALSE;


Refactored HeadersDsl and added disable option for headers

Refactored the HeadersDsl to use HeadersConfigurer and its properties.

The individual header configurations are now applied directly to the fields of HeadersConfigurer.

Added a custom disable option for all headers where Spring Security allows custom deactivation.

Added tests that check the individual deactivation of headers.

Fixes #9

Hey @eleftherias,
although the pull request goes beyond the issue itself, I think the changes make sense in this context. Imo we can adopt large parts of the actual Spring Security Dsl methods and only change the way they are called. For example via delegated properties.
The changes unfortunately break the current pattern.

I get your point, but I'm not so sure about the current syntax for deactivating headers.
Lets take your example:
headers {
   frameOptions {
      disable()
      deny = true
   }
}

If you assume that the desired behavior works here, it would confuse me as a developer that parts of my code are simply ignored. Wouldn't the following syntax make more sense?
headers {
   frameOptions.disable()
}

or/and some sort of infix (maybe with an enum)
headers disable frameOptions

With this variant a further configuration is avoided and thus also confusion on the part of the developer. I know this is exactly the syntax of Spring Security, but I think it's the only one that makes sense. Then we would not have to use the get() method and are able to reuse the configuration objects from Spring Security.
I was just a little bothered by the fact that some things are kind of declared exactly the same way they are declared in the original Dsl. I couldn't help but try to reuse it.
However, that is only a suggestion. For all I care, we can also simply implement your variant.

@d-stoll
Regarding the get() method, there are other situations, aside from disable(), where the configuration options depend on each other.
One example that I can think of is sameOrigin and deny in the FrameOptionsDsl.
Therefore, I think it is useful to have a method that determines which configuration to apply after all the options have been specified.

Wouldn't the following syntax make more sense?

headers {
   frameOptions.disable()
}

I agree that this syntax is more clear.
How would you go about implementing this? It would be great if you submit an example of the source code implementing this syntax.

Fixed in 3b4f759386714f4a35593ec0705e8bca4aad5e7c.


troubleshoot test pipeline, recently failing

this PR started off as routine incrementing of a ci "action" but turned into something else when the pipelines failed for a separate reason. For reasons discovered later, tests/tests-jest-ts/tsconfig.json needed this change
{
- "extends": "ts-node/node16/tsconfig.json",
+ "extends"<EMAIL_ADDRESS>  "ts-node": {
    "transpileOnly": true
  },
  "compilerOptions": {
    "allowSyntheticDefaultImports": true,
    "module": "ESNext",
    "moduleResolution": "node"
  }
}

$ node --version
v21.2.0

tests do not fail here...

these seem related https://github.com/nodejs/node/issues/48207, https://github.com/LibreService/my_rime/issues/23

https://github.com/TypeStrong/ts-node/issues/2026#issuecomment-1605398810

[...] switch to Node.js 18 just to see the actual error.

In the node 18 environment, the error looks like this
> NODE_OPTIONS="--loader=ts-node/esm --loader=esmock" jest esmock.node-jest.test.ts

(node:3069) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
/home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/src/index.ts:859
    return new TSError(diagnosticText, diagnosticCodes, diagnostics);
           ^
TSError: ⨯ Unable to compile TypeScript:
error TS6053: File 'ts-node/node16/tsconfig.json' not found.

    at createTSError (/home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/src/index.ts:859:12)
    at reportTSError (/home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/src/index.ts:863:19)
    at createFromPreloadedConfig (/home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/src/index.ts:874:36)
    at create (/home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/src/index.ts:624:10)
    at register (/home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/src/index.ts:591:15)
    at Object.registerAndCreateEsmHooks (/home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/src/esm.ts:116:34)
    at file:///home/runner/work/esmock/esmock/tests/tests-jest-ts/node_modules/ts-node/esm.mjs:8:7
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25) {
  diagnosticCodes: [ 6053 ]
}

I did try troubleshooting this error a little bit but the solutions I tried failed and I was sure the error was the original source of the problem. I could try re-enabling the jest ts test and making changes there, but it would be a trial and error thing and I don't know if the issue can be resolved or how many "trials" it would take to find a solution

tests pass when tests-jest-ts are disabled... the error does not occur with other test folders where node-ts is used
    "test:DISABLEnode18-test-jest-ts": "cd tests-jest-ts && npm test",

feel free to reopen or revert for any reason.
this change seems safe to merge now, so merging


Zsh produces escape sequences as they were actual strings.

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]  10.0.19041.508]
Windows Terminal version (if applicable):  1.2.2381.0

Any other software?

Steps to reproduce

I'm using Ubuntu(WSL 2.0) and try to use zsh through bash.
Expected behavior
It works.

Actual behavior

I think there is another similar issue like this but I can not find it..

If you are thinking of issues #7091 and #6634 note that the output processing differs and that they aren't running on WSL.

If you are thinking of issues #7091 and #6634 note that the output processing differs and that they aren't running on WSL.

If you are thinking of issues #7091 and #6634 note that the output processing differs and that they aren't running on WSL.

This doesn't look like the stock zsh configuration. Can you share your zshrc?

Yes I'm using a custom zshrc and the PROMPT is here https://github.com/skyline75489/mydotfiles/blob/master/.zshrc#L41
This also happens with conhost. What interests me is that, in the OpenSUSE WSL distro which I mainly use, the issue does not exist. Be it zsh on bash, bash on bash, you name it. It all works. But in the Ubuntu WSL2 distro it collapses for some reason.
When I'm finished with the OSC things I'll see if I can find out why.

Now that I think about it, it may be just my zshrc is broken since it contains invisible characters. Maybe just a false alarm.

OK I can confirm it's a false alarm. Something happens to my local zshrc file. It no longer contains actual \e escape codes any more..

Weird!

Maybe it's just me doing some copy-paste thing that ruined the zshrc in the past but I didn't realize that. Never mind. Still a false alarm.

It's a lot easier to instead use the Z shell's built-in mechanisms for coloured prompts, e.g. %F{green}, %B, %b, and %K{254}.  One does not have to calculate or hardware any control sequences at all, and this problem does not occur.

@skyline75489  are you using zsh from Windows like git-bash or WSL2?

He was using WSL; his .zshrc was corrupted.


ci: support automatically release checksums and binaries

Resolve: https://github.com/fermyon/spin/issues/483
see: https://github.com/Xunzhuo/spin/releases/tag/v0.5.0
Signed-off-by: Xunzhuo<EMAIL_ADDRESS>

Thank you so much, @Xunzhuo!
Once you add your commit signature, this LGTM.
Thank you so much!

Thanks @vdice and @radu-matei, I am on a vacation, so my computer is away from me, I will update commit signature ASAP:)

No worries, enjoy your vacation!

Hey, @Xunzhuo, bump on the commit signature here.
Thanks again for your contribution!

@Xunzhuo you may need to force-push the signed commit, to re-trigger the check.  Can you give this a try?

You also need to sign with a GPG key — see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification
(git commit -S -s -m "")

Hi @Xunzhuo , sorry for all of the trouble here.  We are very close!  The recent merge commit is properly signed per the 'Verified' indicator:

Alas, the original commit still needs signing with a GPG key:

One way would be to rebase this branch and squash commits down to one, GPG-signed commit.  Do you think you might have a chance to do this?
We're excited to get this in and use it for the forthcoming release!  Thank you.

Hi @Xunzhuo , sorry for all of the trouble here. We are very close! The recent merge commit is properly signed per the 'Verified' indicator:
Alas, the original commit still needs signing with a GPG key:
One way would be to rebase this branch and squash commits down to one, GPG-signed commit. Do you think you might have a chance to do this?
We're excited to get this in and use it for the forthcoming release! Thank you.

Thanks @vdice, I did not use GPG before just using SSH. After configuring some steps, finally solved this:) Sorry for the delay.

I tested this again, see https://github.com/Xunzhuo/spin/releases/tag/v0.6.0, uploading artifacts is working well, but the automated release title is like that, should we fix this?

I tested this again, see https://github.com/Xunzhuo/spin/releases/tag/v0.6.0, uploading artifacts is working well, but the automated release title is like that, should we fix this? Or let release manager to manually edit this?

First, thanks for testing again.  Good question; I think for now we'll assume the release manager will manually edit the release.  I/we can look at further action configuration (or alternate actions) that might provide functionality to set the release title and, ideally, utilize GitHub's auto-generated release notes functionality.  Meanwhile, we're excited to bring in these excellent improvements!  Thanks again @Xunzhuo 🎉


Quickstart-revamp

Signed-off-by: Robert Fekete<EMAIL_ADDRESS>

Hi @pepov, I've modified the loki-nginx.md file so it now has tabs for the syslog-ng/fluentd code samples. Let me know if you like it that way, then I'll delete the syslog-ng quickstart skeleton
Changing a tab now changes tabs on the entire page, so the user doesn't have to click for each step.

After discussing it with @pepov it might be a good idea to add a command at the start / end of the guide which allows someone to try out Fluentd after syslog-ng (or vice-versa). Maybe something like this?
 kubectl delete namespace logging quickstart

It's not necessary to delete the namespaces, but it would be good to delete the resources we created, like the logging, flow and output resources. Kubernetes GC will take care of getting rid of all the dependent resources. The logging operator and the log generator can stay and we can direct the user back to the point where they had to create the logging resource.

Something like this? "If you have already completed this quickstart with a logging forwarder and want to try the other one on the same cluster, run the following command to delete the forwarder-specific resources:
...
"

perfect!

Thanks a lot for the review!
On Wed, Aug 23, 2023 at 1:20 PM Peter Wilcsinszky @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/kube-logging/kube-logging.github.io/pull/161#pullrequestreview-1591363181,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6AU3NPIXHRU33UMUY22MDXWXROHANCNFSM6AAAAAAZ5XCJA4
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


Remove c/winapi and rename some windows types

winapi.cr used old and outdated conventions regarding the windows porting effort. It is deleted, and the definitions in it which are used are moved to files corresponding to the windows header they are defined in.
Some windows types are also renamed to retain their capitalisation from Microsoft's headers.

Ping, this is a really tiny change that affects only windows, this should be simple to review.


Switch from fatal error to warning

Using fatal error is scaring users and creating multiple invalid issues. See #312 and #313 and I'm sure more to come...
See https://github.com/Glavin001/atom-beautify/blob/1dfac5bbab1a9d8fe77c8147c54a57b0de9ba084/src/beautify.coffee#L58-L59

Published to v0.26.5


Context sidebar struggles for very large objects

Current Behavior
When attempting to display very large objects in the context sidebar, the runtime seems to struggle (100% cpu usage and sometimes freezes)
Expected Behavior
While I don't expect to be able to view very large objects in the sidebar I would expect the Node-RED runtime to handle this more gracefully. For arrays it doesn't seem to be an issue as the array is cutoff at some point.
Steps To Reproduce
See attached flow.
Example flow
[{"id":"0dccdcd830997e99","type":"group","z":"aa4dd3f04c2a8de7","name":"1. generate very large object (wait for debug to print to confirm it's done)","style":{"label":true},"nodes":["47bc59b7809b8700","a71559dd2e51bcee","cf8e729dcfa39f3c"],"x":174,"y":159,"w":552,"h":82},{"id":"47bc59b7809b8700","type":"inject","z":"aa4dd3f04c2a8de7","g":"0dccdcd830997e99","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"[{\"id\":0,\"name\":\"Elijah\",\"city\":\"Austin\",\"age\":78,\"friends\":[{\"name\":\"Michelle\",\"hobbies\":[\"Watching Sports\",\"Reading\",\"Skiing & Snowboarding\"]},{\"name\":\"Robert\",\"hobbies\":[\"Traveling\",\"Video Games\"]}]},{\"id\":1,\"name\":\"Noah\",\"city\":\"Boston\",\"age\":97,\"friends\":[{\"name\":\"Oliver\",\"hobbies\":[\"Watching Sports\",\"Skiing & Snowboarding\",\"Collecting\"]},{\"name\":\"Olivia\",\"hobbies\":[\"Running\",\"Music\",\"Woodworking\"]},{\"name\":\"Robert\",\"hobbies\":[\"Woodworking\",\"Calligraphy\",\"Genealogy\"]},{\"name\":\"Ava\",\"hobbies\":[\"Walking\",\"Church Activities\"]},{\"name\":\"Michael\",\"hobbies\":[\"Music\",\"Church Activities\"]},{\"name\":\"Michael\",\"hobbies\":[\"Martial Arts\",\"Painting\",\"Jewelry Making\"]}]},{\"id\":2,\"name\":\"Evy\",\"city\":\"San Diego\",\"age\":48,\"friends\":[{\"name\":\"Joe\",\"hobbies\":[\"Reading\",\"Volunteer Work\"]},{\"name\":\"Joe\",\"hobbies\":[\"Genealogy\",\"Golf\"]},{\"name\":\"Oliver\",\"hobbies\":[\"Collecting\",\"Writing\",\"Bicycling\"]},{\"name\":\"Liam\",\"hobbies\":[\"Church Activities\",\"Jewelry Making\"]},{\"name\":\"Amelia\",\"hobbies\":[\"Calligraphy\",\"Dancing\"]}]},{\"id\":3,\"name\":\"Oliver\",\"city\":\"St. Louis\",\"age\":39,\"friends\":[{\"name\":\"Mateo\",\"hobbies\":[\"Watching Sports\",\"Gardening\"]},{\"name\":\"Nora\",\"hobbies\":[\"Traveling\",\"Team Sports\"]},{\"name\":\"Ava\",\"hobbies\":[\"Church Activities\",\"Running\"]},{\"name\":\"Amelia\",\"hobbies\":[\"Gardening\",\"Board Games\",\"Watching Sports\"]},{\"name\":\"Leo\",\"hobbies\":[\"Martial Arts\",\"Video Games\",\"Reading\"]}]},{\"id\":4,\"name\":\"Michael\",\"city\":\"St. Louis\",\"age\":95,\"friends\":[{\"name\":\"Mateo\",\"hobbies\":[\"Movie Watching\",\"Collecting\"]},{\"name\":\"Chris\",\"hobbies\":[\"Housework\",\"Bicycling\",\"Collecting\"]}]},{\"id\":5,\"name\":\"Michael\",\"city\":\"Portland\",\"age\":19,\"friends\":[{\"name\":\"Jack\",\"hobbies\":[\"Painting\",\"Television\"]},{\"name\":\"Oliver\",\"hobbies\":[\"Walking\",\"Watching Sports\",\"Movie Watching\"]},{\"name\":\"Charlotte\",\"hobbies\":[\"Podcasts\",\"Jewelry Making\"]},{\"name\":\"Elijah\",\"hobbies\":[\"Eating Out\",\"Painting\"]}]},{\"id\":6,\"name\":\"Lucas\",\"city\":\"Austin\",\"age\":76,\"friends\":[{\"name\":\"John\",\"hobbies\":[\"Genealogy\",\"Cooking\"]},{\"name\":\"John\",\"hobbies\":[\"Socializing\",\"Yoga\"]}]},{\"id\":7,\"name\":\"Michelle\",\"city\":\"San Antonio\",\"age\":25,\"friends\":[{\"name\":\"Jack\",\"hobbies\":[\"Music\",\"Golf\"]},{\"name\":\"Daniel\",\"hobbies\":[\"Socializing\",\"Housework\",\"Walking\"]},{\"name\":\"Robert\",\"hobbies\":[\"Collecting\",\"Walking\"]},{\"name\":\"Nora\",\"hobbies\":[\"Painting\",\"Church Activities\"]},{\"name\":\"Mia\",\"hobbies\":[\"Running\",\"Painting\"]}]},{\"id\":8,\"name\":\"Emily\",\"city\":\"Austin\",\"age\":61,\"friends\":[{\"name\":\"Nora\",\"hobbies\":[\"Bicycling\",\"Skiing & Snowboarding\",\"Watching Sports\"]},{\"name\":\"Ava\",\"hobbies\":[\"Writing\",\"Reading\",\"Collecting\"]},{\"name\":\"Amelia\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Daniel\",\"hobbies\":[\"Skiing & Snowboarding\",\"Martial Arts\",\"Writing\"]},{\"name\":\"Zoey\",\"hobbies\":[\"Board Games\",\"Tennis\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]},{\"id\":9,\"name\":\"Liam\",\"city\":\"New Orleans\",\"age\":33,\"friends\":[{\"name\":\"Chloe\",\"hobbies\":[\"Traveling\",\"Bicycling\",\"Shopping\"]},{\"name\":\"Evy\",\"hobbies\":[\"Eating Out\",\"Watching Sports\"]},{\"name\":\"Grace\",\"hobbies\":[\"Jewelry Making\",\"Yoga\",\"Podcasts\"]}]}]","payloadType":"json","x":270,"y":200,"wires":[["a71559dd2e51bcee"]]},{"id":"a71559dd2e51bcee","type":"function","z":"aa4dd3f04c2a8de7","g":"0dccdcd830997e99","name":"function 1","func":"const largeObject = {}\nfor (let i = 0 ; i < 100000 ; i++) {\n    largeObject[i] = RED.util.cloneMessage(msg.payload)\n}\nglobal.set('largeObject', largeObject )\nreturn msg","outputs":1,"timeout":0,"noerr":0,"initialize":"","finalize":"","libs":[],"x":420,"y":200,"wires":[["cf8e729dcfa39f3c"]]},{"id":"cf8e729dcfa39f3c","type":"debug","z":"aa4dd3f04c2a8de7","g":"0dccdcd830997e99","name":"debug 2","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":620,"y":200,"wires":[]},{"id":"be9bd31c68c1a669","type":"group","z":"aa4dd3f04c2a8de7","name":"2. print length to confirm we have everything","style":{"label":true},"nodes":["2f7df8e59f2c0485","db077b4a6111ffd5","8898b29a09f5a782"],"x":164,"y":279,"w":642,"h":82},{"id":"2f7df8e59f2c0485","type":"inject","z":"aa4dd3f04c2a8de7","g":"be9bd31c68c1a669","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":280,"y":320,"wires":[["8898b29a09f5a782"]]},{"id":"db077b4a6111ffd5","type":"debug","z":"aa4dd3f04c2a8de7","g":"be9bd31c68c1a669","name":"debug 1","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":700,"y":320,"wires":[]},{"id":"8898b29a09f5a782","type":"function","z":"aa4dd3f04c2a8de7","g":"be9bd31c68c1a669","name":"function 2","func":"const largeObject = global.get('largeObject')\nnode.warn(Object.keys(largeObject).length)\nreturn msg;","outputs":1,"timeout":0,"noerr":0,"initialize":"","finalize":"","libs":[],"x":480,"y":320,"wires":[["db077b4a6111ffd5"]]},{"id":"6e04e7ac605f4939","type":"group","z":"aa4dd3f04c2a8de7","name":"3. Confirm we can access individual entries","style":{"label":true},"nodes":["deeb6cb3657ae4c8","57876c04a4fa5d16","dbf59859b202c171"],"x":154,"y":399,"w":482,"h":122},{"id":"deeb6cb3657ae4c8","type":"inject","z":"aa4dd3f04c2a8de7","g":"6e04e7ac605f4939","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"largeObject[\"1000\"]","payloadType":"global","x":310,"y":440,"wires":[["57876c04a4fa5d16"]]},{"id":"57876c04a4fa5d16","type":"debug","z":"aa4dd3f04c2a8de7","g":"6e04e7ac605f4939","name":"debug 3","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":530,"y":440,"wires":[]},{"id":"dbf59859b202c171","type":"inject","z":"aa4dd3f04c2a8de7","g":"6e04e7ac605f4939","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"largeObject[\"10000\"]","payloadType":"global","x":320,"y":480,"wires":[["57876c04a4fa5d16"]]},{"id":"20e8b9c7f6dcc57b","type":"group","z":"aa4dd3f04c2a8de7","name":"4. Navigate to the context side bar and attempt reloading the Global section","style":{"label":true},"nodes":[],"x":154,"y":559,"w":483,"h":40}]

Environment

Node-RED version: 3.1.9
Node.js version: 18
npm version:
Platform/OS: Mac OS
Browser: Safari

So yeah, this is a problem...
 FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory

Need to look at how the API is returning the data and what options we have to slice it better. This is potentially breaking at the API level so need to consider how to proceed.

Thanks for having a look !


Make an OCurrent pipeline

This PR turns the simple build script into an OCurrent pipeline, this should allow it to be setup on a macOS machine and the schedule parameter can be set to 7 to have it rebuild and push images every week.

An example pipeline


small typo

Issue description
There is a small typo on the page:
It needs not exactly match a column name but should guide the user to the column to which it should be mapped.
The "s" at the end of "needs" is missing.
Feedback Type (Optional)
spelling or grammar
Page Title on SAP Help Portal (prefilled)
Create an "Operator and Values" Data Access Control
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/SAP_DATASPHERE/be5967d099974c69b77f4549425ca4c0/501594bf2afb4e49ab5ce254e35e3504.html?locale=en-US&q=data access control

Dear SAP Datasphere user
thank you for your feedback. We have corrected the documentation and it will be shown in wave 08
Best regards
Cindy for the UA Team

https://people.sap.com/MichaelWilking
From: sap-doc-bot[bot] @.>
Date: Thursday, 28. March 2024 at 15:11
To: SAP-docs/sap-datasphere @.>
Cc: Wilking, Michael @.>, Mention @.>
Subject: Re: [SAP-docs/sap-datasphere] small typo (Issue #41)
Sie erhalten nicht oft eine E-Mail von @.*** Erfahren Sie, warum dies wichtig isthttps://aka.ms/LearnAboutSenderIdentification
Thank you for your valuable feedback contribution, @michaelwzuz78https://github.com/michaelwzuz78! So that we can recognize your contribution in SAP Communityhttps://github.com/SAP-docs/contribution-guidelines/blob/main/docs/recognition.md, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:
https://people.sap.com/your-user-name
Thanks!
—
Reply to this email directly, view it on GitHubhttps://github.com/SAP-docs/sap-datasphere/issues/41#issuecomment-2025281270, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFM4FN5BHMBZQUY6QB7QM6DY2QQKVAVCNFSM6AAAAABFKLI4P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVGI4DCMRXGA.
You are receiving this because you were mentioned.Message ID: @.***>


Log error flooding

mavlinkrouter.sh[1342]: (endpoint.cpp:228) Different system_id message for endpoint 5: Current: 254 Read: 57

One per second

Flooding is a problem itself, but, this error itself needs to be treated: mavlink-router currently associates a single system_id with an endpoint, and clearly this assumption is not sound. That's why this warning is in place, after all.
@fnoop just for curiosity, do you know what are those system_id, 254 and 57?

Probably this is happening because a corrupted Mavlink message was read. So it will have a random msg_id then this line:
msg_entry = mavlink_get_msg_entry(msg_id);
will return null and no CRC check will not run.
Well at least this happens at AeroFC & AeroCompute board

This also sounds bad - we accept that mavlink_get_msg_entry(msg_id) returns NULL for the case of a legitimate unknown id, but corrupt messages take all the fun.

@edersondisouza I don't know what those system_ids are, but the assumption that there is a single system_id to an endpoint is incorrect, I think - mavlink is a routed protocol.  You can have any number of components connected to a system that can/will route between other components on other connections.  You might want to know about this maybe in a debug mode, but certainly not in default run mode.

@fnoop the key word here is "component". Yes we support multiple components in an endpoint. But we used the constrain of one system. Otherwise it would be like if you have 2 drones sharing the same link and using the same endpoint which is a very weird situation. There could be other cases... E.g. a gimbal with different systemid?
But I really think there's a bug somewhere, either on our end or on the flight stack since I get this message too running just the flight stack and nothing else.

@lucasdemarchi Yes in an ideal world, however systemid/componentid is poorly understood/used and you often have a wide variety of them running on a single vehicle!

yep... eventually we will end up to deal with it. But I want to know if it's a misbehaving part using the wrong systemid or there's any bug hidden that we are not handling correctly.

Fixed on master


DLS-9429: Exemptions for small producers editing is not working correctly

Need to look at improving unit tests for AddASmallProducerControllerSpec and AddASmallProducerViewSpec for EditMode


NOMRG: Test pyproject

fixes #122

Codecov Report

Merging #218 (b3da5b2) into main (f7fa260) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   85.79%   85.79%
=======================================
  Files          14       14
  Lines         929      929
  Branches      128      128
=======================================
  Hits          797      797
  Misses        101      101
  Partials       31       31

Flag
Coverage Δ

unittests
∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fa260...b3da5b2. Read the comment docs.

Closing as it is no longer a problem.
P.S Switch to pyproject.toml was made in #284


CSS Functions

It would be very nice to have support for CSS functions, at least the basic math functions on numeric types, e.g. min.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Some fixes for Russian translation

Fixed minor translation inaccuracies, now it sounds more natural and semantically correct, also unnecessary transliteration was removed

@jyyi1 @daniellacosse I believe we would have to load these changes to the Translation Console somehow, so they don't get overridden on next translation export.

@jyyi1 @daniellacosse I believe we would have to load these changes to the Translation Console somehow, so they don't get overridden on next translation export.

Sure, we can put a comment in our Translation request and let our translation team decide which one to take.


Missing commands in algokit & smart contracts folder missing as well.

timestamp: 2023-04-10T17:08:04+00:00
AlgoKit: 1.0.1
AlgoKit Python: 3.11.3 (main, Apr  7 2023, 19:25:52) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] (location: /Users/julienamorsandjong/.local/pipx/venvs/algokit)
OS: macOS-13.2.1-x86_64-i386-64bit
docker: Command not found!
Docker required to run algokit sandbox command; install via https://docs.docker.com/get-docker/
docker compose: Command not found!
git: 2.39.2
python: Command not found!
python3: 3.9.0 (location: /Library/Frameworks/Python.framework/Versions/3.9/bin/python3)
pipx: 1.2.0
poetry: 1.4.2
node: Command not found!
Node.js is required for some Node.js-based templates;
install via algokit bootstrap within project directory, or via:
https://nodejs.dev/en/learn/how-to-install-nodejs/
npm: Command not found!
brew: 4.0.11

I figured it out.


Increase clickable area link back to Collective after contribution

After making a contribution, you see this screen:

A few users have been unable to figure out how to get back to the Collective because you have to specifically click the name or logo on the card. I think the whole card should be a link to the Collective, as well as the name in text where it says "You are now supporting..." with clear formatting showing it's a link (i.e. underlined).

I will take it.

I will take it.

@ersachin3112 : Sure, feel free to let us know if you have any questions. 😄

I think we should do same thing for collective cards on /discover page as well.