discord.token was not found in the config

Describe the bug
it may not be reading my token not too sure why it isnt though
To Reproduce
token being longer then certain digits makes it not work
Expected behavior
a hopeful bot with a bunch of people screaming in my discord server
Screenshots

Additional context
where is says there isnt a token in the screenshot, there is.

Make sure there is a space between the : and the token/options. This is a common problem people don't often realize

@Unbeccable make it more clear on how to reproduce
i mean that doesn't give any info non the less . . .

@Unbeccable Show an example of your config but replace the fields like token and webhook with some random stuff just to show what your general config looks like.

Or rather keep the token and regenerate on the disocrd dev page

Having the same issue.
This is my config (replaced some characters and shortened the other id's but you get the point)
discord:   token: 0DY3MTI2OTM1MjEyMgkyNDU4.YPck4w.x1PvndgTg0frandomcharacters   server_id: 5819   owner_id: 1532

Can you change some numbers and send the whole file, I need to verify something

Can you change some numbers and send the whole file, I need to verify something

Idk how or if you can attach files on Github but I uploaded it on Mega
Mega download link

The file was not able to parse properly because of this
  crosschat:
    enabled: true

    # This channel ID must be in the specified server_id server
    channel_id:8671425

    # This webhook CAN be a different channel than channel_id but SHOULDN'T
    # If it is different messages will not be relayed in the same place
    webhook:https://discord.com/api/webhooks/8671erasedhere

The whole file has to be formatted properly with spaces after the :. Otherwise it wont be treated properly by the config parser. So add those spaces and it should work.

The file was not able to parse properly because of this
  crosschat:
    enabled: true

    # This channel ID must be in the specified server_id server
    channel_id:8671425

    # This webhook CAN be a different channel than channel_id but SHOULDN'T
    # If it is different messages will not be relayed in the same place
    webhook:https://discord.com/api/webhooks/8671erasedhere

The whole file has to be formatted properly with spaces after the :. Otherwise it wont be treated properly by the config parser. So add those spaces and it should work.

Omg I'm dumb I fixed it for the top id's but forgot to fix those. Thanks.

Aite while I'm here ill close this issue since I assume the @Unbeccable fixed it.


Support riscv64

Needs opencontainers/runc#3446, containerd/containerd#6882

LGTM error CI not related to the PR
by the way E: Unable to correct problems, you have held broken packages. starting to be quite recurrent, I guess  that there is some dead software sources in sources.list I will try to check this

there is not a related bug in the issuer tracker https://launchpad.net/ubuntu/+milestone/ubuntu-22.04. And not able to reproduce in my local.


E           ValueError: Unable to determine BigQuery dataset.

venv/lib/python3.10/site-packages/ibis_bigquery/__init__.py:169: ValueError

Should this exist in the main repo now that the bigquery backend has been ported back there?

This test does exist there, and master is passing so I don't think it's actually a problem.

I think you're right that this has been fixed in the main ibis repo. I've still got some projects using this package on ibis 3.x, so I'd like to keep this open to backport a fix if it's possible to do so from the ibis-bigquery package.

SGTM!

Re-opening just to double-check if this fix is needed in the ibis 4.x repo.


Ping ACK causes canzero firmware update to fail (version 0.3.2)

From the forum: https://forum.omzlo.com/forum/nocan/ping-ack-causes-canzero-firmware-update-to-fail-version-0-3-2
I think I reported a similar issue for the 0.2.6
** Sending <nocan-sys-bootloader-write node=1, func=22, param=1, len=4, data=6a8bfd26> **
2021/02/10 23:26:36 DEBUG++ SEND FRAME EXT@90341601 4: 6a 8b fd 26>
2021/02/10 23:26:36 DEBUG ** Received <nocan-sys-node-ping-ack node=1, func=9, param=0, len=0, data=> **
2021/02/10 23:26:36 WARNING Firmware upload failed: Final SYS_BOOTLOADER_WRITE failed for node 1 at address=0x0, Unexpected system message nocan-sys-node-ping-ack, while expecting nocan-sys-bootloader-write-ack.
2021/02/10 23:26:36 DEBUG++ Deleting client 3 (<IP_ADDRESS>:49925), closing channel and socket
2021/02/10 23:26:36 DEBUG ** Received <nocan-sys-bootloader-write-ack node=1, func=23, param=1, len=0, data=> **
2021/02/10 23:26:36 WARNING Message of type nocan-sys-bootloader-write-ack from node N1 (7a:9d:cc:40:9d:a3:f0:a7) was not processed

mikb wrote:
My workaround is to add a
ping-interval = 30000
to the config.
Presumably this will also periodically cause failures, just less frequently.

Oh. This is strange. Following your previous bug report, we disabled ping messages during firmware uploads. This shouldn't happen. I will check our test bench again to see if we made a mistake.

@mjbmikeb2 OK. I was able to reproduce and confirm this bug. A fix will be available soon.

This bug has been fixed in 0.3.3.


Member updates result in unsubscribing from archived newsletters

Issue Summary
Whenever a member is updated (email, tag, etc) and saved, we unsubscribe them from any archived newsletter.
We need to decide if it's appropriate to unsubscribe a member from an archived newsletter. This feels like the wrong way to go about this if we were actually interested in doing so.
Steps to Reproduce

Create a newsletter if you don't already have one.
Create a member. Make sure they're subscribed to the newsletter.
Archive the newsletter.
Update the member (add a tag). Hit Save.
Go to the Member Activity feed. You can also look at the archived newsletter and see that it has one fewer sub.

Ghost Version
5.36
Node.js Version
16.19.0
How did you install Ghost?
macOS
Database type
MySQL 5.7
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

The root issue is that we do not load archived newsletter subscriptions when reading member data (e.g. on the Member page), and then when we save that Member data, we end up removing any archived subscriptions as a result. Ultimately the trouble is here although depending on the solution we'd need to update the logic that brings us into that loop as well.
Suggestions would be:

Load and filter from display all archived newsletter subscriptions. It's plausible we'd want to toggle display of these at some point. This would allow us to already have that data when we call update.
Push all processing to the backend and always load newsletter subscriptions to ensure we don't clear out the archived subscriptions.

Checking with the team on preference.

@allouis Hey - would you mind weighing in here? I feel like I can make reasonable arguments for either, and this ultimately comes down to our best practices with APIs.

I think some of the problem here lies in the fact that our business logic and our persistence logic are way too closely tied together. In an ideal world we would move the members code in line with the architecture of tiers/offers/mentions etc... but we don't have appetite for that yet.
If/when we do get round to improving the members code, I suspect that we will want to be loading the newsletters for all reads.
@prschulz I think the answer here has to be informed by product 😸

Can a member be subscribed to an archived newsletter? It seems like yes from this issue - but mainly want to check terminology here - we might consider it a dormant subscription? And only include "active" subscriptions in the API.
Can a member subscribe to an archived newsletter?
Can a member unsubscribe from an archived newsletter?

The answers to these questions will help inform the API design and thus the solution to the problem 💃
The answer to 1. informs whether or not archived newsletters should be included in the API response for Members
Assuming the answers to 2 & 3 are "no" - I would try and encode those business rules in code in the backend, updating that loop where we generate the newsletters to subscribe/unsubscribe to/from

Load all newsletters for member
Compare the desired newsletters
Subscribe them to all the new newsletters which are not archived
Unsubscribe them from all the missing newsletters which are not archived.

This will closely match what the code will look like in the future when we eventually move the an entity/repository/clean architecture approach, as we'll have something like (psuedo code) - with the business rules explicitly defined ☺
class Member {
  subscribeToNewsletter(newsletter: Newsletter) {
    if (newsletter.archived) {
      return;
    }
    this.#newsletters.add(newsletter);
  }

  unsubscribeFromNewsletter(newsletter: Newsletter) {
    if (newsletter.archived) {
      return;
    }
    this.#newsletters.remove(newsletter);
  }

  updateNewsletters(newsletters: Newsletter[]) {
    // compare `newsletters` to `this.#newsletters` and subscribe/unsubscribe as necessary
  }
}

But unfortunately for now it will be hard to make it as explicit as this - but the approach remains the same!
If the answers to 2&3 are "yes" - then we need to reconsider the API, we will probably want to start including subscriptions to all newsletters (regardless of archived) in the API response

My understanding of current state is that:

Yes, members can be subscribed to archived newsletters.
No, members cannot unsubscribe from archived newsletters.
No, members cannot subscribe to archived newsletters.

Essentially, archived newsletters are 'frozen'. Given this, I don't know that it makes sense to expose them in the API unless we want to change 2/3, which would be a question for Peter. My expectation is that we just want to remove this confusing behavior and should likely just make the switch on the backend, where we can re-evaluate some of this behavior when we do the transition you mentioned.

Great okay! We got a nice solution then :)


ght stats ... command not complete

Bug report
The following command:
/ght stats july knative --users=maximilien --repos=client-contrib -o txt
should return all stats for user 'maximilien' in july in repo 'client-contrib' in the knative organization and displat in standard out.
Expected behavior
output
Steps to reproduce the problem
issue command
./ght version
./ght --version
GH Track v0.3

Python version
Python 3.8.2

/kind bug

Fixed in commit ece2b41f8b91dcb7d0bb54603baed38a5a1c07e8


fix(build): npm login with v5.4.0

npm v5.5.0 breaks pragmatic login. If the npm login fails, try installing v5.4.0 and login again

:tada: This PR is included in version 3.26.79 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Refactoring: IO and encode part

PR Checklist

[x] This comment contains a description of changes (with reason)
[x] Referenced issue is linked
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] Documentation in docs is updated

Description of changes

IO

read() has now a dataset_path arg, which can be used to name a downloaded directory/file
renamed some args to make clear that it can either read a single file or from a directory
removed unused parts of read()

Caching

added caching for multiple AnnData objects

fixed an issue that caused ehrapy to error, when trying to autodetect encodings but none were found

fixed an issue that causes obs to be deleted when readings from cache file

Technical details

Would also be good if you could look at:

https://github.com/theislab/ehrapy/blob/97a62f6a1e001fea29dee8722087c0edc86bedf1/ehrapy/api/preprocessing/encoding/_categoricals.py#L81 <- guess an artificial dataset can help for this.
https://github.com/theislab/ehrapy/blob/97a62f6a1e001fea29dee8722087c0edc86bedf1/ehrapy/api/preprocessing/encoding/_encode.py#L469
https://github.com/theislab/ehrapy/blob/97a62f6a1e001fea29dee8722087c0edc86bedf1/ehrapy/api/io/read.py#L67

Mostly done; just to want to glimpse over it tomorrow to get it ready for review.
More fixes and work than expected ;).

@Imipenem oh and fix the merge conflicts please


API to expose "current state"

Feature description
Hi!
I wondered if it would make sense to expose something similar to the message we get when we navigate the history of our qf window as something we could query for "status" (to have in a statusline or something like that).

I was looking at the code and I saw it was done in the moment, so I'm guessing this kind of information about the state may be a bit out of reach at the moment.
Describe the solution you'd like
I'm open to bounce ideas about what could make sense if you're open to it, but I'm guessing a starting point could be something like require("bqf").status() or something to that end
Additional context
No response

The status of
https://github.com/kevinhwang91/nvim-bqf/blob/8784eebf34371049b641646d00232c2603215297/lua/bqf/qfwin/handler.lua#L142-L147
you can use vim.fn.getqflist to get them.

Ohhh, for some reason I thought your plugin was keeping state, but I just saw that I can:
vim.fn.getqflist({ nr = '$' })  -- Get the number of quickfix pages
vim.fn.getqflist({ nr = 0, title = 0 })  -- Get the current page number and title (command)

Thank you for clarifying!


addevalplugins.js should generated #3707

task 'addevalplugins' has been added to the core project
copyVendorStuff.dependsOn addevalplugins
use gradle realclean for deletion generated file

:+1: but should wait for release


poly test does not return non-zero on error/failure with polylith-kaocha

I'm not sure how I didn't notice this before but clojure -M:poly test does not return non-zero on error/failure.
If I run poly test (thus bypassing polylith-kaocha) it does what I expect.

What if you run clojure -M:poly test but configure to use the default test runner in workspace.edn?

Just checked that now. I commented out the create-test-runner config and it returned non-zero on failure.

Thanks, I'll check that out.

Thanks, we've got a workaround in place for our CI so it's not super critical.

I hopefully fixed this, see https://github.com/imrekoszo/polylith-kaocha/commit/80a76185a6d3a58ec8553c56b47d349aaad3dc02
Feedback is appreciated

Confirmed fixed, thanks again.


Update _index.md

Fixed hyperlinks

@LundbergPaul Sorry for hijacking your PR.
The ref shortcode is useful for preventing broken internal links. It will resolve the content path and emit a warning or error if it's not found.


Move data files to folder per "Event"

Move all the .json files that define an event into a distinct folder, to be used per event created. The appsettings.json file will contain a setting that points to the event the application is currently working over, see example below.
"DataFolder": "ice10"

The draft work for this issue is in branch "issue_1".


Cant make a input required dynamically

Hi.
I need to create a component tath have inputs tath can be required depending on a condition but trying it i wasnt able to do it, i tried using [required]="var" but it always resolve the input as required.
In HTML5 doc it seems tath having requiered will always make it requireded if you put true or false.
Is there a way to make a input required dynamically?

Tried it today, worked like a charm! Thanks.
Shouldnt this be the way required works by default?

This should be the way things work. Making the change now, so it will be in 5.0

It does not work at dart version 2.1.0 and angular_forms 2.0.0
Dart VM version: 2.1.0 (Tue Nov 13 18:22:02 2018 +0100) on "windows_x64"
angular_forms 2.0.0
angular 5.0.0
Chrome


Refactor stripe checkout service

What:

Refactor stripe checkout service

Why:

To avoid some anti-patterns

@shalapatil please review later in the week when other priority work is done.

LGTM
@vipulnsward Is this tested locally? If not then @apoorv1316 can you please test this ?

Tested locally and its working fine!
@apoorv1316 Please test this on staging


Nginx resolver

nginx doesn't support /etc/hosts file as a resolver for the proxy_pass directive. Right now the resolver is set to the Google DNS service at <IP_ADDRESS> which requires an Internet connection to work.
The alternative is to install another dependency like dnsmasq which will simulate a DNS server on <IP_ADDRESS>, to be configured like:
echo -e "user=root\nno-resolv\nserver=<IP_ADDRESS>" >> /etc/dnsmasq.conf

With dnsmasq installed the resolver could point to <IP_ADDRESS> and it will read from /etc/hosts file, or fallback to <IP_ADDRESS>.
Whatever we decide to do, we need to change the way it currently works because it makes the Internet a dependency to Kong (!).

If Kong doesn't have internet, it cannot be installed anyways, it needs Internet for the Luarocks dependencies.
Secondly, if it doesn't have internet, why does it need to do DNS lookups? One should simply set the IP of his or her API.
Finally, isn't that an edge case that we should deal with later? Do we know yet if someone with an internal API that doesn't have access to internet will be using Kong?

Kong can be installed without internet through the packages. The rpm, deb etc distributions are not communicating with the Internet internally nor invoking Luarocks, Kong is bundled inside.
The only use case would be for internal environments that also have internal DNS server or custom DNS configuration in /etc/hosts, or for on-premise installations in private environments that don't have a NAT.

It's not about not having internet. It's about internal routes, hosts file, local enterprise DNS server, etc etc. You can't make an enterprise product without using the local resolver! Just don't add the resolver line in nginx.conf and it'll be fine. It'll figure it out.

It's not about not having internet. It's about internal routes, hosts file, local enterprise DNS server, etc etc. You can't make an enterprise product without using the local resolver!

that ^

Nginx needs a resolver entry otherwise you will start seeing 502 Bad Gateway errors. So removing the resolver entry is not an option. It needs to point somewhere and to make it point to /etc/hosts we need to use dnsmasq as I suggested.


[WIP] Continue improve unit cases

:white_check_mark: Build AElf <IP_ADDRESS>0 completed (commit https://github.com/AElfProject/AElf/commit/1bfc5bad73 by @EricBlack)

:white_check_mark: Build AElf <IP_ADDRESS>0 completed (commit https://github.com/AElfProject/AElf/commit/658468b283 by @EricBlack)

:white_check_mark: Build AElf <IP_ADDRESS>9 completed (commit https://github.com/AElfProject/AElf/commit/3990c7f579 by @EricBlack)


decreased acetylcholine level

If this is a request for a new term, please provide us with the following information.

Preferred term label (e.g., asplenia)

decreased acetylcholine level

Synonyms (e.g., absent spleen)

decreased Ach level

Textual definition (the definition should be understandable even for non-specialists. Include a PubMed ID or URL(s) to refer to any relevant article(s) that provides information about the suggested term).

reduction in the normal amount of acetylcholine

Any additional notes to clarify the meaning or use of the term. Please provide a PubMed ID or URL(s) for the source of this information.

PMID: 12163621

Suggested parent term (Please look in the hierarchy of the MP using the MP Browser or other browsers such as OLS and find the place in the MP where the new term best fits)

abnormal acetylcholine level

If you would like a nanoattribution, please indicate your ORCID id or provide a label such as MGI:sbello (organization, first initial-last name)

https://orcid.org/0000-0003-2307-1226

MP:0021012


log format in IE 11

t's logging like
%c prev state color: #9E9E9E; font-weight: bold.
Does it only work in chrome?

Thanks for the PR! 👍


implement command and hook, add config

/cc @Serabe @dpordomingo

PLUS one:
I'd split the pre-commit in three:

checking ascii
csscomb validation
editorconfig validation

@dpordomingo actually, I think we can remove the non-ascii thing, right?

Done

@Serabe @dpordomingo added prettier + ESLint :tada: :nail_care:

Added svgo


Edits according to ta

Minor edits

Coverage remained the same at 89.094% when pulling 5f21c5b4e1130306cccc34d0ef506ae4187d7b3d on A19Sean:edits-according-to-ta into d2d4fe53de6c284cd9afda16622553c858e84465 on CS2103-AY1819S1-W13-1:master.


perseus-cli/0.4.2 crate is missing the tests folder

https://crates.io/crates/perseus-cli/0.4.2 does not have https://github.com/framesurge/perseus/tree/main/packages/perseus-cli/tests
Trying to build this in Nix,
error: builder for '/nix/store/3v37xknb9ij2hsvazh4g0bqjscp2j3gi-perseus-cli-0.4.2.drv' failed with exit code 101;
       last 10 log lines:
       >    Compiling assert_fs v1.0.12
       >    Compiling perseus-cli v0.4.2 (/private/tmp/nix-build-perseus-cli-0.4.2.drv-0/perseus-cli-0.4.2.tar.gz)
       >    Compiling webpki v0.22.0
       >    Compiling sct v0.7.0
       >    Compiling webpki-roots v0.22.6
       >    Compiling ureq v2.6.2
       > error: couldn't read tests/lib.rs: No such file or directory (os error 2)
       >
       > error: could not compile `perseus-cli` (test "integration") due to previous error
       > warning: build failed, waiting for other jobs to finish...
       For full logs, run 'nix log /nix/store/3v37xknb9ij2hsvazh4g0bqjscp2j3gi-perseus-cli-0.4.2.drv'.

The crate is missing the tests/ folder:

Hey there, so sorry for the late reply on this, I've been really busy lately, but I am back! The reason for this is because the Perseus CLI tests are very heavy. I strongly recommend against running them locally, they take about half an hour on CI because they involve end-to-end testing of the entire build process. We make sure that everything passes before releasing, and you could check against GitHub Actions' records for this maybe? I'm not very familiar with Nix though, but I'm happy to help resolve this if you give me some more info about why it's required to run those particular tests.

@srid I'm closing this due to inactivity for now, but please let me know if it's still an issue for you.


python310: 3.10.11 -> 3.10.12; python311: 3.11.3 -> 3.11.4

https://docs.python.org/release/3.10.12/whatsnew/changelog.html
https://docs.python.org/release/3.11.4/whatsnew/changelog.html
Fixes: CVE-2023-24329
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

[x] aarch64-linux

[x] python310
[x] python311

[ ] x86_64-linux

[ ] python310
[ ] python311

[ ] aarch64-darwin

[ ] python310
[ ] python311

[ ] x86_64-darwin

[ ] python310
[ ] python311


Intro Section + Logic

Create Intro section and logic in next steps:
a) Create new route /home
b) Replace existing index.vue with home.vue
c) Make sure to use home layout, and for index create another one
d) Inside index.vue create div with fixed width and height
e) Use banner as background with two variatns for normal and hover state
f) Create content div center by xy to include button
Loader Animation:

should only be displayed on intro section
50/50 grid no gap full screen
slide from center to both side each of them
done

I'm ready to put in practice

@gabighiur all set up, assigning task to you


Added Layers and Entities true color property

Changes in DwgMergedReader,   DwgStreamReaderAC18 and Colors to be able to get RGB true color for layers or entities both with index or true color
Description
Short description about this PR
Tasks done in this PR

[ ] Something awesome.
[ ] An evil bug have been defeted.
[ ] Code cleanup and maintenance has been done.

Related Issues / Pull Requests

Add the links of issues or PR related to this one.

Notes for reviewer

Things to consider during the review of this PR.

one test seems to be failing, can you check it please:
[xUnit.net 00:00:07.56]     ACadSharp.Tests.ColorTests.HandlesIndexedColors [FAIL]
Skipped ACadSharp.Tests.CadDocumentTests.RemoveLayer [1 ms]
Failed ACadSharp.Tests.ColorTests.HandlesIndexedColors [57 ms]
Error Message:
Assert.True() Failure
Expected: True
Actual:   False
Stack Trace:
at ACadSharp.Tests.ColorTests.HandlesIndexedColors() in D:\a\ACadSharp\ACadSharp\ACadSharp.Tests\ColorTests.cs:line 60
[xUnit.net 00:00:08.77]     ACadSharp.Tests.IO.DWG.DwgReaderTests.ReadCrcEnabledTest [SKIP]
Skipped ACadSharp.Tests.IO.DWG.DwgReaderTests.ReadCrcEnabledTest [1 ms]

I don't understand why there is an error there, autocad index colors start at 1 and in the test function it start at 0. Maybe this is not a real case.
I am sorry i am starting on github. Maybe i don't know how to do good job.
I was an AutoCAD drafter and now developeper in gis technologies.
Your project is amazing and you made great job, i would like to help your project as well as i can.

The test also check the method GetTrueColorRbg there is when the test does not pass, you changed the method to return a new Color when is not TrueColor but this method intends to return an array of bytes only if is true color, it returns an empty array if the color is defined by an index.

Another comment about your PR, in the description you may have found that it was already written, that's a template to follow and modify in case that you want to open the PR, is not a big deal that you kept it below your description but is good practice to use it. ;-)
Thanks for your help in the project.


"3rd Charter" tasks - track list

So to recap our progress so far:

First "3-month charter" (Sept-Nov 2021) was targeted on building packages and classes for my needs = completed
"Second charter" (Jan-March 2022 > extended to June 2022) was targeted on typesetting an actual book (a.k.a. Almaq project) = completed (sort of, awaiting confirmation by mid-June, but the greenlight is expected).

Will we go for a "3rd charter" (approx. July-Oct. 2022) after that ? The decision is still pending.
Yet we may tentatively track its expected scope:

[ ] Review and improve "styles" package (Priority 1 = complete at least what we have started).
[ ] Indexer stuff - see SILE https://github.com/sile-typesetter/sile/issues/1339 (Priority 2 - If it's not done, next project is heavily compromised)
[x] More styles in "omipoetry" (Priority 3, though likely easy, no need for it yet)
[x] Markdown with Pandoc Lua (a neat PoC was done, so Priority 3 to get at least a minimal working version) = see #23
[ ] Segond Bible from USFX source (a PoC was done... Priority 4, just for the sake of initiating something, incl. sidenotes...) = see #22
[x] Typesetter mess (see SILE https://github.com/sile-typesetter/sile/issues/1361) = hornets nest... it's a deadly blocker too if our current hacks fail in more general cases... Priority not assessed as it would mean migrating to SILE 0.13 (see below)

Likely out of scope at this date:

Migrating from SILE 0.12.5 to 0.13.x when available. Lots of API changes but no clear benefits (yet) for our projects?
Typesetter mess again: consider how/when to remove our various ugly "hacks" (in the hacks/ folder)...

More styles in "omipoetry"
Addressed in resilient https://github.com/Omikhleia/resilient.sile/pull/6
(Still lagging behind of the items in this old list)

Typesetter mess (see SILE https://github.com/sile-typesetter/sile/issues/1361) = hornets nest... it's a deadly blocker too if our current hacks fail in more general cases...

Addressed

In resilient: https://github.com/Omikhleia/resilient.sile/commit/c6b350b1ff96b426605555f5a47a4338498b6297
In SILE core: https://github.com/sile-typesetter/sile/pull/1717

Review and improve "styles" package (Priority 1 = complete at least what we have started).

Moved to https://github.com/Omikhleia/resilient.sile/issues/12

Indexer stuff (...)

Move to https://github.com/Omikhleia/resilient.sile/issues/17


WebSite with Login authentication?

How does craw4ai handle if page has login authentication ? Then this required to search the page that results the list that to be extracted/scraped .

Please check this example: https://crawl4ai.com/mkdocs/examples/hooks_auth/

I have close this issue; please inform me if you require any additional help.


Fix typo in sql query

What this PR does:
Fix the issue of measures not shown because of a bad query.

 [TARIFF2015] Investigate missing eu measure on latest build


chore(deps): update common-dev-assets digest to c5b82f9

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
27ef988 -> c5b82f9

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

GitHub release
v4.0.0

Your semantic-release bot :package::rocket:


Missing method in Order class

I am attempting to get individual components of a the shipping address for an order (Community Store v1.1.4)
$address1 = $order->getAddressValue('shipping_address', 'address1'));
This throws the following exception:
[Sat May 06 23:00:07.725535 2017] [:error] [pid 13759] [client [redacted]:56546] PHP Fatal error:  Call to undefined method Concrete\Package\CommunityStore\Src\CommunityStore\Order\Order::getValue() in [redacted]/packages/community_store/src/CommunityStore/Order/Order.php on line 1062, referer: http://[redacted]/index.php/dashboard/system/optimization/jobs
It appears that the getValue() method is missing from the Order object.

Just found that I could use this method to get the address components:
$order->getAttribute('shipping_address')->address1
$order->getAttribute('shipping_address')->address2
...
Is the intent of getAddressValue() different from the above.

I does appear that getValue is missing from the Order object. getAddressValue appears to only be used by the shop itself and not at any point on an order object, so I think you've just hit a function that should work for custom purposes, but just was never found to not work.
Perhaps try changing the getAddressValue function in Order.php to:
 public function getAddressValue($handle, $valuename) {
        $att = $this->getAttribute($handle);
        return $this->returnAttributeValue($att,$valuename);
    }

If you could test to see if that works with your original code that would be handy.
Otherwise your method of fetching the individual address components looks fine - just be aware that I think that only works in v8

The change you provided for getAddressValue() worked perfectly.
On a side note, the method I provided in my initial comment does work in v<IP_ADDRESS>:
$order->getAttribute('shipping_address')->address1
$order->getAttribute('shipping_address')->address2
...

That's good to hear, I'll update the master branch shortly, this must have just been an oversight.


Saving a contourf figure to PDF produces too large a file

I think the current contourf implementation is too greedy in some way, such that the PDF outputs — which are beautiful — take too much memory.
Below I compare making a plot and saving it to PDF with different "software". The plots are all similar, but the Makie PDF (CairoMakie backend) is about 27 times bigger than the other PDFs (2.7MB vs ~100KB). See table below:

software
output screenshot
PDF file
size

Makie.jl

Makie_jl.pdf
2.7 MB

Plots.jl

Plots_jl.pdf
112 KB

Python

matplotlib.pdf
106 KB

MATLAB

MATLAB.pdf
96 KB

To be fair, it seems that the MATLAB code actually produces a rasterized image of the filled contours, which is cheating a bit, but the other ones (Plots.jl and matplotlib) don't, so I think these provide a fair comparison.
Can the PDF output of contourf be somehow reduced in future releases?
For reproducibility, below are the MWEs used to make each of these:

Makie.jl:
using CairoMakie

delta = 0.025

x = y = -3.0:delta:3.01
Z1 = @. exp(-x'^2 - y^2)
Z2 = @. exp(-(x' - 1)^2 - (y - 1)^2)
Z = 2(Z1 - Z2)

levels = -2.0:0.1:2.0

fig = Figure()
ax = fig[1,1] = Axis(fig)
co = contourf!(ax, x, y, Z, levels=levels)
cbar = fig[1,2] = Colorbar(fig, co, width=30, tellwidth=true)

save("Makie_jl.pdf", fig)

Plots.jl:
using Plots

delta = 0.025

x = y = -3.0:delta:3.01
Z1 = @. exp(-x'^2 - y^2)
Z2 = @. exp(-(x' - 1)^2 - (y - 1)^2)
Z = 2(Z1 - Z2)

levels = -2.0:0.1:2.0

contourf(x, y, Z, levels=levels)

savefig("Plots_jl.pdf")

matplotlib / Python:
import numpy as np
import matplotlib.pyplot as plt

delta = 0.025

x = y = np.arange(-3.0, 3.01, delta)
X, Y = np.meshgrid(x, y)
Z1 = np.exp(-X**2 - Y**2)
Z2 = np.exp(-(X - 1)**2 - (Y - 1)**2)
Z = 2 * (Z1 - Z2)

levels = np.arange(-2.0, 2.0, 0.1)

fig, ax = plt.subplots()
CS = ax.contourf(X, Y, Z, levels=levels)
cbar = fig.colorbar(CS)

plt.savefig("matplotlib.pdf")

MATLAB:
delta = 0.025

x = -3.0:delta:3.01
y = x
Z1 = exp(-x'.^2 - y.^2)
Z2 = exp(-(x' - 1).^2 - (y - 1).^2)
Z = 2 * (Z1 - Z2)

levels = -2.0:0.1:2.0

contourf(x, y, Z, levels)
colorbar()

print('MATLAB', '-dpdf')

(edit: had a typo in the siz of the make PDF in the table 27 -> 2.7 MB)

The reason why it's so big is that contourf produces a mesh-plot which is then plotted triangle-by-triangle in CairoMakie. The good about this is that you can save any mesh plot (including meshscatter, surface and anything that depends on those) in a vectorized from, including 3d plots. The bad is, well, file size.
If I understand correctly contourf produces a bunch of lines, matching levels, which are interpreted as borders of polygons. These polygons are then triangulated (with holes) by GeometryBasics. I think Cairo allows for drawing any filled polygon, so we could skip the triangulation and instead just draw the raw polygons in the right order.

it used to be polys, I think Simon changed it to mesh because of some updating problem with poly. We didn't think about the file size issue. I think it should be possible to either change back to poly or to intercept fitting mesh calls in CairoMakie, although I'm not sure right now if we have access to the original signature, or only the converted one which would already be triangulated

poly also lowers to a mesh call , so we'd need to intercept either way. But poly would be a good target to intercept

We're already dispatching specifically on poly because of this issue

I just did a local test where I used poly inside contourf again. I also needed to write an explicit method in CairoMakie for Poly{<:AbstractVector{<:Polygon}}. Looked like this and the pdf is 88kb in size:

Will need some cleaning up though, also I'm not sure if using poly inside contourf is difficult for dynamic plots or if it was just easier for Simon to implement it that way.

https://github.com/JuliaPlots/AbstractPlotting.jl/pull/622
https://github.com/JuliaPlots/CairoMakie.jl/pull/134

Nitpicking on the details, is there a way to avoid the thin white lines that are also visible in the colorbar?

that's out of our hands really, it's an antialiasing issue of whatever displays the vector graphics. every plotting tool's output suffers the same from it if you google around. I only introduced a "hack" to CairoMakie for heatmaps where I would slightly enlarge each tile so they overlapped. But I'm still not sure if that can't have edge cases. I only thought about the edge case where you have transparent colors and it checks for that

that was this pr https://github.com/JuliaPlots/CairoMakie.jl/pull/105 because the white line issue annoyed me as well

if you really want to get rid of it in a contourf plot, the easiest might be to plot really thin contour lines on top with the correct color scheme, although that also squarely falls into the "hack" category..

Maybe another hack that could work (in the case of no transparency) would be to draw the fillings one by one on top of each other, but for every i-th filling, merge it with all the j-th fillings for j > i, no? I think that's what old MATLAB used to do (before all the problems it introduced in 2014b), see, e.g., this deconstructed MATLAB contourf (from before 2014b, taken from this post):

the problem is that you can't do this in CairoMakie because one poly drawing function doesn't know about others that will happen. You would have to remove the respective holes from the polygons in the contourf function itself, based on the colors given (don't remove when there's transparency)

Oh I think you mentioned that previously but I had forgotten about it...

this is fixed now, even though the implementation probably breaks some interactive uses of contourf currently, as a collection of polys in poly seems to update incorrectly in glmakie where the mesh worked.


Add tests and rename time to subannual

Replaces #276 fixing and extending original changes

took a first glance at the changes, looks good to me - have one more idea for an additional test, will try to implement and PR into this branch tomorrow

took a first glance at the changes, looks good to me - have one more idea for an additional test, will try to implement and PR into this branch tomorrow

Will it make sense to merge this and target your new PR to original branch?

Merging to original PR #264 to continue


More than 2 digits of country calling code

First of all, thanks for the hard work, the validation mask is working almost perfectly.
I have an issue, when I'm using the code where the country calling code 2 is 100% perfect. But if I want to input 3 digits of prefix ie.: Portugal | 351 / Slovakia | 421 / Slovenia | 386, tha mask always add the last digit to the real number.
What can I do with this? I didn't find any solution mentioned in the issues, if there is something so sorry for oppened this issue.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

^ @assisrafael

There is not an international phone mask available in this library.
You can check the code for the localized versions (e.g. uiBrPhoneNumberMask) and implement a mask in the global package that handles all global formats (could be named uiPhoneNumberMask).

Sad to hear about this. Okey, thanks for your help.


[bridge] emit CommitteeMemberUrlUpdateEvent event

Description

emit CommitteeMemberUrlUpdateEvent when a validator updates url
add url checks when validator add or update bridge url
update a comment: the Blocklist payload contains 20 bytes evm addresses instead of 33 bytes pub keys

Test plan
How did you test the new or updated feature?

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

@longbowlu can you explain the protocol version change? I get lost every time we bump protocol versions

@longbowlu can you explain the protocol version change? I get lost every time we bump protocol versions

I think we have to bump the version but i might be wrong. If I don't bump it, the snapshot compatibility test fails. Thoughts? @dariorussi  @patrickkuo

Will need to bump the protocol version because snapshot version 51 has been created already (in sui-framework-snapshot)

I think we have to bump the version but i might be wrong. If I don't bump it, the snapshot compatibility test fails. Thoughts? @dariorussi @patrickkuo

Will need to bump the protocol version because snapshot version 51 has been created already (in sui-framework-snapshot)

theoretically speaking, can we update the snapshot? since it's not on testnet/mainnet yet

I think we have to bump the version but i might be wrong. If I don't bump it, the snapshot compatibility test fails. Thoughts? @dariorussi @patrickkuo

Will need to bump the protocol version because snapshot version 51 has been created already (in sui-framework-snapshot)

theoretically speaking, can we update the snapshot? since it's not on testnet/mainnet yet

I don’t know, will need to ask @ebmifa


Add check-source-childs hook to .pre-commit-hooks

check-source-childs hook is missing and prevent is from being used.

Codecov Report

Merging #33 (5e2e54f) into main (3233536) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           44        44
  Lines         1921      1921
  Branches       254       254
=========================================
  Hits          1921      1921

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3233536...5e2e54f. Read the comment docs.


[irods/irods#6482] Creates zonehopper#<remote_zone> for federation testing

See commit message for explanation.

Added #


Incorrect Time | Logs local time to Mysql DB

Hello. I'll make this short and sweet.
index.js has this
server.on(PLAYERS_UPDATED, (players) => {
      options.mysqlPool.query(
        'INSERT INTO PlayerCount(time, server, player_count) VALUES (NOW(),?,?)',
        [serverID, players.length]
      );

That logs the local time and not correct UTC time.
Therefore; it should be mentioned in the README that it is necessary to set the mysql instance to use UTC time.

mysql-log plugin has been replaced by DBLog plugin, so I will close this.


Revert "refactor: Replace lazy_static with std::sync::LazyLock (#827)"

Description
This reverts commit f15a9a323550718a3d7abbcd5a6b8c490e677594.
We still need Rust 1.79.0 compatibility until 1.80 percolates into Nixpkgs.
Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Author

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

I would prefer merging this, so that we can merge dependent PRs (such as https://github.com/stackabletech/hdfs-operator/pull/571 and https://github.com/stackabletech/druid-operator/pull/584).
Yes, we are loosing some doc comment changes as well, but I would simply cherry-pick the reverted commit once we are ready for 1.80 and the changes should be back :)

Once this is merged we can IMHO release 0.73.0 :)

We can always revert the revert :)


Replace hopscotch

Hopscotch is unmaintained
Proposed solution
Replace with react-joyride or reactour (careful with dependency baggage)
Additional context
Consider a better placement for steps (in the actual code?)
Also, consider a "What's new" tour

See https://github.com/NCI-Agency/anet/tree/GH-3018-replace-hopscotch for a proof-of-concept replacing hopscotch with react-joyride.
Note that this has some problems, as can be seen when going through the "new report" tour: at some point, the 'next step' pop-up goes off-screen (doesn't scroll into view), and there's no way to scroll manually.
The current hopscotch version has slightly different problems: at some point, the 'next step' pop-up will point to a blank screen.
Both are quite possibly due to our (fixed, flexbox) layout, so that is something that would need to be addressed in either case.


Revert ai2html version

Revert ai2html version back to v0.60 from v0.81.5 after a conversation with @alykat. (Text alignment behavior was unpredictable for center-justified area text and rotated point/area text in responsive layouts.)
Related: https://github.com/nprapps/dailygraphics/issues/230

:shipit:
Koko, do you want to merge this yourself?

:shipit: Will do :shipit:


Kernel Examples Have Numbering Gaps

Problem
Current examples numbers have gaps,
Solution
Reorder the existing ones for V1.

Not any more - please verify


Table Top Defined New Feature - Added Ego save functionality to sheet

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
Added Ego Save to the sheet

Character Sheet Info Roll20 Internal Use only.


misleading information about domestic & international calling plan

Hi,
would you describe better that "domestic & international" plan means 1.200 minutes domestic & 600 minutes international are included.
The sentence "600 minute for Domestic and International Calling Plans" leads to 600 minutes for both, domestic & international, which is not true.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02354090-59c2-297d-2415-70a2cbdd15c4
Version Independent ID: c6dfc9e6-e2f8-2f3c-6172-e15f6311d0aa
Content: Availability in Germany
Content Source: Skype/SfbOnline/country-and-region-availability-for-audio-conferencing-and-calling-plans/availability-in-germany.md
Service: skype-for-business-online
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@fs79 Thank you for this feedback
We appricate you pointing this out. I am sending this over to the Teams/Skype for Business team to get addressed properly.
I was able to get this into the backlog for the Teams/Skype for Business team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Thank you for bringing this to our attention! The Domestic and International Calling Plan option has been clarified.


Fix contacts not deleting when updating a client

Fix contacts not deleting when updating a client

Coverage remained the same at 11.756% when pulling 24ade67ed31a422a8df4557a6cc5d44817e803cf on pierredup:contacts into 92f9531461fc4108df1937d65bc8e58e408b9e5c on CSBill:master.


Git Hub Preview Timing out

I run the Finance app (Lesson 9) using 'flask run'. I get the link. I CTRL-click on it, and I wait and wait.... then it says it timed out.
Version: 1.70.2
Commit: e4503b30fc78200f846c62cf8091b76ff5547662
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

me too

Please report this to the course admin people, not to the people who produce one of the tools you are using on your course.


RECS0033 suggestion produces bad code fix at xor-assignments

The code:
if (foo)
{
    bar ^= true;
}

produces a suggestion RECS0033 Replace with '|='.
Doing the fix produces:
bar |= foo;

It is not correct. I want to invert bar, but it will not assign false.
Also,
if (foo)
{
   bar ^= false;
}

produces a suggestion RECS0093 Replace with '&='.
Doing the fix produces:
bar &= !foo;

It is not correct.

Thank you for reporting!


Detailed README

I feel like the priority on this one should be higher because rn idk what this plugin can do and how i can setup :)

I think further documentation is not that needed since the code can easily being read in this plugin. 💩

That is for people who actually know how to code 💩

I'm working on it as we speak

That should cover the basics @Johnsonk79. Let me know if you need me to cover more.


Remove animation from progress bar in case user has "Reduced motion" turned on

Didn't see a contribution guide, but hopefully it's adequate!
Tried to change the test spec to account for this, but setting up the context and page setup required to emulate prefers-reduced-motion seemed a bit too intrusive for this case.
-Use @media query for checking users preference.

If no preference: show animation
If preference == reduce: remove animation
Either way, set background to the linear-gradient in case the progress bar is empty. Maybe this should be currentColor if it's empty and reduced motion is on?

Thanks for very good input! A lot of clean up has been done, so merged the suggested change into commit https://github.com/u-elements/u-elements/commit/1d22348ef39582a88d8c8c94580b097f277ac6fd ☺


Enable locked down spire-agent usecase.

This patch implements a locked down spire-agent along with updating the production example to use it.
fixes: https://github.com/spiffe/helm-charts/issues/177

whats the bash container for?

whats the bash container for?

runs as root:
https://github.com/spiffe/helm-charts/pull/209/files#diff-e860a3dbff565712efc8045d2a42937c0f58f6994939846799346e253a182e75R59-R60
Then chowns the socket dir so the nonroot user the agent runs as can get to it:
https://github.com/spiffe/helm-charts/pull/209/files#diff-e860a3dbff565712efc8045d2a42937c0f58f6994939846799346e253a182e75R52
This limits the amount of root needed to a second or less at the startup time of the agent.

Can we change the PR title to something like "Allow for SPIRE Agent to run as non root user". I think that will look better in release notes and closer to what we are accomplishing here.

It is defaulting to root when you don't include the production example.


readline with initialize input

The same as rustyline's readline_with_initial.
The scenario is we accept partial inputs, like SELECT 1; SELECT, and then process SELECT 1;, while push back the rest SELECT for the next input.

Find a workaround state.run_edit_commands(&[EditCommand::InsertString("SELECT 1".to_string())]);,
Let me see if it's feature completed.

Seems work well, while such a method can be convenient.

The workaround now looks elegant to me. Close as no longer an issue.


Refactoring: Create a struct for completion items

Similar to ElixirLS.LanguageServer.Protocol.SymbolInformation

Tracked in Experimental server


Put filtered resources below toggle

Looks much nicer.  Shout out to my boi @wwlorey for the suggestion


ER-diagram auto-scroll is trollling if you do double click on table's name

open ER-diagram view
do double click on a table's name at a table with many fields (> 15 or something)

What did happen? You didn't open the table but you scrolled down and opened some field. Really unexpected behaviour, when we talk usability.

Reproduces on 6.0.2

Issue isn't reproducible in 6.2.0.
Ticket closed


Add whereNotWithin and whereNotContains Builder method

I've added a negate of the whereWithin function, it seems necessary.
Regards.

BTW - it will be great if you could add also a whereNotContains method.

Greetings.
I've made the changes

I've removed unnecessary point and files.

@dzhwar-k Thanks! :)


nimble install test failing

https://nimble.directory/ci/badges/selenimum/nimdevel/output.html
     Error: Unsatisfied dependency: nim (>= 1.4.8)

nim 1.2.x?

install test OK!


BlockOverride:baseFee is not working for CallMany and TraceCall

Describe the bug
When overriding the baseFee for TraceCall and CallMany, it's value is not considered.
If we do a traceCall or CallMany on a transaction with a MaxFeePerGas of 1 Wei and we override the block base fee at 100 GWei we should have an error saying that the maxFeePerGas is not sufficient.
Steps to reproduce
Do a trace call (or CallMany) on any transaction  that has a maxFeePerGas of 1 Wei and override the block base fee with 100 GWei :
For traceCall :
curl -X "POST" "http://<IP_ADDRESS>:8543/" \
          -H 'Content-Type: application/json; charset=utf-8' \
          -d $'{
                "jsonrpc": "2.0",
                "id": 0,
                "method": "trace_call",
                "params": [
                {
                    "from": "0x000000000000000000000000000000000000dEaD",
                    "to": "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2",
                    "gas": "0x61a80",
                    "maxFeePerGas":"0x1",
                    "maxPriorityFeePerGas":"0x1",
                    "nonce": "0x0",
                    "value": "0x0",
                    "data": "0x70a0823100000000000000000000000088e6a0c2ddd26feeb64f039a2c41296fcb3f5640",
                    "type": "0x2"
                },
                ["trace"],
                "0x12349d0",
                {},
                {"baseFee":"0x174876E800"}
                ]
                }'

For call Many :
curl -X "POST" "http://<IP_ADDRESS>:8543/" \
        -H 'Content-Type: application/json; charset=utf-8' \
        -d $'{
              "jsonrpc": "2.0",
              "id": 0,
              "method": "eth_callMany",
              "params": [
              {
                  "transactions":[
                          {
                              "from": "0x000000000000000000000000000000000000dEaD",
                              "to": "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2",
                              "gas": "0x61a80",
                              "maxFeePerGas":"0x1",
                              "maxPriorityFeePerGas":"0x1",
                              "nonce": "0x0",
                              "value": "0x0",
                              "data": "0x70a0823100000000000000000000000088e6a0c2ddd26feeb64f039a2c41296fcb3f5640",
                              "type": "0x2"
                          }],
                  "blockOverride":{"baseFee":"0x174876E800"}
              },
              {"blockNumber":"0x12349d0"}
              ]
              }'

Response Call Many
{"jsonrpc":"2.0","result":[{"value":"0x0000000000000000000000000000000000000000000004ed16fd3e38c58560d1"}],"id":0}
Response Trace Call
{"jsonrpc":"2.0","result":{"output":"0x0000000000000000000000000000000000000000000004ed16fd3e38c58560d1","stateDiff":null,"trace":[{"type":"call","action":{"from":"0x000000000000000000000000000000000000dead","callType":"call","gas":"0x61a80","input":"0x70a0823100000000000000000000000088e6a0c2ddd26feeb64f039a2c41296fcb3f5640","to":"0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2","value":"0x0"},"result":{"gasUsed":"0x5d9e","output":"0x0000000000000000000000000000000000000000000004ed16fd3e38c58560d1"},"subtraces":0,"traceAddress":[]}],"vmTrace":null},"id":0}
Node logs
No response
Platform(s)
Linux (x86)
What version/commit are you on?
reth Version: 0.1.0-alpha.15
What database version are you on?
N/A
What type of node are you running?
Archive (default)
What prune config do you use, if any?
None
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[x] I agree to follow the Code of Conduct

okay, so basefee is disabled in eth_call but enabled in traceCall
eth_call
https://github.com/ledgerwatch/erigon/blob/513fd50fa501ab6385dc3f58b18079d806d6ff5a/turbo/transactions/call.go#L86-L86
traceCall
https://github.com/ledgerwatch/erigon/blob/513fd50fa501ab6385dc3f58b18079d806d6ff5a/turbo/transactions/tracing.go#L184-L184

I did some digging in #6246 and it looks like the behaviour re basefee is not consistent across clients.
personally disabling basefee doesn't really make sense to me but perhaps there's a reason for disabling it in trace call related endpoints.

Would be great if it could works in both eth_call and trace_call (and eth_call_many &  trace_call_many). If i remember well from erigon contributor, this was not an intented behavior in Erigon and they had to fix it

Hi @mattsse,
I have updated with the latest alpha and I see some behavior change. What was the last change on this matter ? thank you.
When doing a CallMany or TraceCall, I have lot of "max fee per gas less than block base fee" that I didn't have before.

@corentindenoeud could you try against http://<IP_ADDRESS>:8545 and see if this is still the case there?

@corentindenoeud ah the issue here is that you override the basefee but your tx's fee is lower
https://github.com/paradigmxyz/reth/blob/28f3a2e2d9525bf2f6373e755e2d6dc0c2f97821/crates/rpc/rpc/src/eth/revm_utils.rs#L469-L472
I believe this is also how other clients behave here, although with a better error message
{
    "id": 0,
    "jsonrpc": "2.0",
    "error": {
        "message": "fee cap less than block base fee: address 0x000000000000000000000000000000000000dEaD, gasFeeCap: 1 baseFee:<PHONE_NUMBER>0",
        "code": -32000
    }
}```

But I think there's something else wrong here, checking

@mattsse  I have tested locally your changes and it works ! Thank you ! That was fast !


How to run this map by cloud provider

Checklist

[V ] I have read the FAQ
[ V] I have checked if this issue already exists (both open and closed issues)
[V ] I am using the most recent version of pogom from the master branch
[ ] If this is an installation issue, I am posting my OS, OS version, python version, pip version
[ ] I'm posting the complete log
[V ] I'm using a descriptive title for this issue

My Issue
I successfully setup the map yesterday, however, it is easy to get ip-banned by Niantic which makes my map unable to scan pokemon and I even cannot play the game at home. And I read the FAQ part, the cloud provider can be used to avoid ip-banning and ensure the map run properly. However, I don't even know what a cloud provider is...
Can anyone teach me how to use the cloud provider or send me a tutorial for newbie. It would be highly appreciated..
P.S. Is jelastic a cloud provider? I tried to use it but it is too difficult to me...
...

me too,  after success run "python runserver.py" nothing happen with the sub web.
scanner work perfectly.
*sudo is not allowed for jelastic. -______________-

Please help..

Here is a guide : https://www.reddit.com/r/pokemongodev/comments/4xy8p9/setting_up_easily_pogom_on_cloud/
Please note that cloud services are not free, but some cloud providers provide free trials.


Split the Value type to subtypes

It would address this question and make Iroha's Value more logical.
Value::Primitive::{Bool, String, (Hash), Numeric::{u32, u128, Fixed}}
Value::Metadata::{LimitedMetadata, MetadataLimits, TransactionLimits, LengthLimits, Ipv6Addr, Ipv4Addr}

not implemented in the iroha yet

solved by #4305


Update GitHub "About" section

Currently, the about section reads:
About
The Telegram Bot API provides an HTTP API for creating Telegram Bots.
I would suggest the following, tdlight-focused introduction:
About
The TDLight Telegram API is an actively enhanced fork of the original Bot API, featuring experimental user support with strong focus on memory footprint and performance.

make a pr

make a pr

You can't PR the about description ;)

@JosXa Lol that’s tue


GBA files likely not working

Most likely an issue with pyctr, but someone reported that ninfs would not mount the content properly.

This is because ExeFSReader.decompress_code fails with a GBA rom. With a valid 3DS codebin (compressed or decompressed) it exits just fine.
>>> from pyctr.type import exefs as e
>>> a = e.ExeFSReader('exefs.bin')
>>> a.decompress_code()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyctr/type/exefs.py", line 308, in decompress_code
    code_dec = decompress_code(code)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyctr/type/exefs.py", line 126, in decompress_code
    byte = dec[ptr_out + seg_off]
IndexError: bytearray index out of range

Best way to detect a GBA game seems to be to read the core version from the extheader (https://www.3dbrew.org/wiki/NCCH/Extended_Header#ARM11_Local_System_Capabilities). This would be best after an extheader reader is added. https://github.com/ihaveamac/pyctr/issues/2


All moves that are unobtainable TMs are treated as TMs and not as level up movesets

Heracross Aerial Ace, Wormadam Protect and Hidden Power, Rotom Shock Wave, etc.

Fixed for next server reboot.


Regarding human evaluation

Hi, thanks for your great work!
To reproduce your results of error rate, is it possible for you to release the human evaluation results?
If not, could you tell which 500 entities you were using for the experiments?

Hi @pat-jj, thanks for your interest in our work. The human evaluation results are already included in the data we released. You can download it by installing factscore and then typing python -m factscore.download_data. Or, if preferred, you can download it directly from our Google Drive link. Once you download it, check out the folder named labeled, and it includes human evaluation data.

I see, will check it out. Thanks a lot!


add base workchain

Codecov Report

Merging #24 into master will decrease coverage by 9.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   90.47%   81.28%   -9.20%
==========================================
  Files           6        8       +2
  Lines         168      187      +19
==========================================
  Hits          152      152
- Misses         16       35      +19

Impacted Files
Coverage Δ

aiida_orca/workchains/__init__.py
0.00% <0.00%> (ø)

aiida_orca/workchains/base.py
0.00% <0.00%> (ø)


reaction: 1.3.1 → 1.4.1

Description of changes
Update reaction.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse.

Result of nixpkgs-review pr 318361 run on aarch64-darwin 1

1 package built:

reaction


Mouse Support

A minor issue, but before the last update, aurora could see and change colors of my logitech g502 mouse, but now i cant seem to find where to activate the mouse control, or only found the g900 one.

G900 will work. (Technically any of them will work)

Thank you so much, just tried the g900 from the preferred mouse list (on 0.6.0b) and the lighting seems to be working properly.


Proposal for streaming with Chunked Transfer Encoding

I've implemented a proof of concept for chunked transfer encoding in this branch: https://github.com/subyraman/sanic/tree/explore-streams
The user-facing API would be a new response method, stream, which would accept a coroutine that writes to the response:
async def streaming_fn(response):
    await response.write('foo')
    await asyncio.sleep(.5)
    await response.write('bar')
    await asyncio.sleep(.5)

@app.route("/")
async def test(request):
    return stream(streaming_fn, content_type='text/plain')

The stream method would instantiate a new class, StreamingHTTPResponse, which would be similar to the existing HTTPResponse except it exposes a method write which would write content to the transport:
class StreamingHTTPResponse:
    def __init__(self, streaming_fn, status=200, headers=None,
                 content_type='text/plain'):
        self.content_type = content_type
        self.streaming_fn = streaming_fn
        self.status = status
        self.headers = headers or {}
        self._cookies = None

    async def write(self, data):
        ret = "{}\r\n{}\r\n".format(len(data), data).encode()
        self.transport.write(ret)

    async def start_stream(self):
        headers = self.get_headers()
        self.transport.write(headers)
        await self.streaming_fn(self)

The user could initialize the StreamingHTTPResponse themselves and do things like attach signal handlers which could close the transport on a particular event, but I haven't thought through an event API.
I wanted to get any thoughts; the API pretty closely follows the Django/Flask model for streaming except we can do neat things here asynchronously (like event handling).

Open PR for this here: https://github.com/channelcat/sanic/pull/473

Can this be closed now PR accepted?

Closed for #473


Watchlist Autobid Limit Doesn't Work

Hi. The limit for the autobid when on manage watchlist mode doesn't work, the bot keeps bidding until it wins

Also, when you change the configuration settings and save them, they still don't get applied to the player

Hm ok thank you for pointing this out. I have a couple updates that I haven't pushed from a week ago that might solve this.
My goal is to make the GUI player table display the buy and sell ceilings accurately (current .85 is just a visual placeholder that isn't used)
Not just display, but also editable.
Another fix in the update is the profit logging was double counting.
Let me know any other bugs or ideas I appreciate your input!

Ok amazing, thank you so much! Incredibly impressive program otherwise and will keep you updated.

Hey I just pushed a new update, the GUI accurately displays the ceilings.
I still don't love the market search methods.
I think the buy ceiling and sell ceiling should properly work now but I haven't aggressively tested it, would love to hear your input!

Great thanks a lot. I'll try It out and let you know how it goes


Ability to use REGISTRATOR_BIND_ADDRESS

This commit adds small utility ENTRYPOINT to lookup the host ip address by interface name. To use this, set the REGISTRATOR_BIND_INTERFACE  environment variables to the name of the interface you'd like Registrator to use and a `-ip=argument will be computed and passed to Registrator at startup.

Note, https://github.com/gliderlabs/registrator/pull/484#issue-182047926 mentioned the use of REGISTRATOR_BIND_ADDRESS.
Technically according to this PR you would set REGISTRATOR_BIND_INTERFACE, which generates REGISTRATOR_BIND_ADDRESS respectively for use within the entrypoint.
Possibly amend the PR title/comment @martinssipenko ? :)

Other than my comment above, +1 to this feature.

Updated the PR comment to reflect that REGISTRATOR_BIND_INTERFACE could be set.

Resolves #477

@martinssipenko @progrium Definitely this feature will help to discover easily the host ip when running registrator.
+1

Any news about this pull request ?
I'm using it in production (fork) but it will be good to implement this feature !

+1 to see some action in merging this


XLM Excel conversion

Hey there!
i'm trying to convert an excel to xlm and then replace certain PII information with labels. These labels should be colored red and then finally all the content is converted back to excel
this flow majorly works but i have issues when trying to inject color into the labels
would appreciate any assistance here please :)

There weren't any errors actually, i tried to set the font color of the required text but instead it gave me something like this:
BR Law Corporation
9 PLACES-899 Place
#08-03 PLACES-901 Plaza
Singapore 048619
Tel: 65-63881717
Fax: 65-63947398
Email<EMAIL_ADDRESS>^ these were the contents of one cell
the initial structure of an xml cell i was trying to redact was something like this:
There weren't any errors actually, i tried to set the font color of the required text but instead it gave me something like this:
BR Law Corporation
9 Monk Place
#08-03 Century Plaza
Singapore 048619
Tel: 65-63881717
Fax: 65-63947398
Email<EMAIL_ADDRESS>
i'm assuming that i would have to split the text into different  tags and subsequently add colour in there for the identified words to redact


[SPARK-26119][CORE][WEBUI]Task summary table should contain only successful tasks' metrics

What changes were proposed in this pull request?
Task summary table in the stage page currently displays the summary of all the tasks. However, we should display the task summary of only successful tasks, to follow the behavior of previous versions of spark.
How was this patch tested?
Added UT. attached screenshot
Before patch:

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #99016 has started for PR 23088 at commit cfe2d5f.

Test build #99016 has finished for PR 23088 at commit cfe2d5f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99016/
Test PASSed.

Need to handle more scenarios and optimization, I'm closing this for some moment. Will update the PR.

As the task section shows all the tasks, I think maybe it would be better to show aggregated metrics for all the tasks.

Previous versions of Spark were showing only completed tasks summary metrics. I think it make more sense to show only finished tasks, rather than showing metrics of killed and failed

When evaluating these things I use git blame (or visual tools here and in an IDE) to figure out if there was a previous change that explicitly tried to change the behavior, and whether it was on purpose, wrong, or incomplete. That would really help understand whether it's just a clear bug or something else.

Can one of the admins verify this patch?

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5244/
Test PASSed.

Test build #99137 has started for PR 23088 at commit 8f4498e.

@srowen Yes. I did check the commit history, and the PR which modified the behavior didn't mention about this behavior change. If it is intentional, then we should change the table title of the table  from "summary metrics of completed tasks" to "summary metrics of all tasks".

(Still need more  things to test, so changed to WIP)

Test build #99139 has started for PR 23088 at commit 96fd281.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5246/
Test PASSed.

Test build #99137 has finished for PR 23088 at commit 8f4498e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99137/
Test PASSed.

Test build #99139 has finished for PR 23088 at commit 96fd281.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99139/
Test PASSed.

Merged build finished. Test PASSed.

Test build #99238 has started for PR 23088 at commit 7edc835.

@srowen , could you please review the PR?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5328/
Test PASSed.

Thank you @srowen for the review. I will update the PR.

When did the behavior change? you said you found the commit.

https://issues.apache.org/jira/browse/SPARK-20657 After the PR correspond to the JIRA, this behavior change occurred. Also, In the PR discussion hasn't mentioned whether it is intentional or not.

Test build #99238 has finished for PR 23088 at commit 7edc835.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99238/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5332/
Test PASSed.

Test build #99244 has started for PR 23088 at commit 6b376af.

Test build #99244 has finished for PR 23088 at commit 6b376af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99244/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5370/
Test PASSed.

Test build #99287 has started for PR 23088 at commit b29a150.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5372/
Test PASSed.

Test build #99289 has started for PR 23088 at commit c81fcf3.

Test build #99287 has finished for PR 23088 at commit b29a150.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99287/
Test PASSed.

Test build #99289 has finished for PR 23088 at commit c81fcf3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99289/
Test PASSed.

Test build #99561 has started for PR 23088 at commit dc95355.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5620/
Test PASSed.

Test build #99562 has started for PR 23088 at commit 64fbe5d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5621/
Test PASSed.

Hi @srowen . Yes. Currently for disk store case, we need to have a more optimized code.

While it makes some sense I have two concerns: different answers based on disk vs memory store which shouldn't really affect things. But would a user ever have both and see both side by side and be confused?

This configurable store is only for history server. So user can configure either one at a time for history server. But, the live UI (which open from Yarn UI), also goes through the same code flow. Where it has 'ElementTrackingStore', which is also inMemory. So, if a user configure disk store for History server and open both live and inProgress History UI, the summary metrics will be different.

changing the way the indexing works, so that you can index by specific metrics for successful and failed tasks differently, would be tricky, and also would require changing the disk store version (to invalidate old stores).

I think @vanzin suggestion seems work, but need time to give it a try and to test it. May be we can add as "TODO" for diskStore case or open a seperate JIRA for that.

Second is, that seems like it should still entail pushing down all the quantile logic into the KVStore, to be clean, right? and that's a bigger change.

Thanks @srowen for the suggestion. Probably @vanzin can answer this well.
I have modified the code, for InMemory case. Disk store still uses the old code.

Test build #99564 has started for PR 23088 at commit 7956b27.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5623/
Test PASSed.

Merged build finished. Test PASSed.

Hi @pgandhi999 , It seems after your checkins, when there is no summary metrics, it is displaying empty table rather than a message which shown in the PR title. could you please help me to fix that. Thanks.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5624/
Test PASSed.

Test build #99566 has started for PR 23088 at commit 2235967.

Test build #99562 has finished for PR 23088 at commit 64fbe5d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99562/
Test FAILed.

Test build #99561 has finished for PR 23088 at commit dc95355.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99561/
Test PASSed.

Test build #99564 has finished for PR 23088 at commit 7956b27.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99564/
Test PASSed.

Test build #99566 has finished for PR 23088 at commit 2235967.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99566/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please

Test build #99577 has started for PR 23088 at commit 2235967.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5635/
Test PASSed.

Test build #99577 has finished for PR 23088 at commit 2235967.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99577/
Test PASSed.

Hi @shahidki31 ,thank you for pointing that out. Will put up a fix for it shortly.

Thanks @pgandhi999

PR : https://github.com/apache/spark/pull/23205 for displaying the message on empty data in task summary metrics table.

Also it would be good to open a separate bug to address the fix for SHS / disk store.

Hi @vanzin , I have opened a JIRA for disk store case https://issues.apache.org/jira/browse/SPARK-26260. I will try to work on the same.

Test build #99635 has finished for PR 23088 at commit f8cfb54.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99635/
Test FAILed.

Retest this please

Test build #99645 has started for PR 23088 at commit f8cfb54.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5702/
Test PASSed.

Test build #99653 has started for PR 23088 at commit 41cfe80.

Test build #99645 has finished for PR 23088 at commit f8cfb54.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99645/
Test FAILed.

Test build #99653 has finished for PR 23088 at commit 41cfe80.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99653/
Test FAILed.

retest this please

Test build #99654 has started for PR 23088 at commit 41cfe80.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5710/
Test PASSed.

Merging to master / 2.4.

Thanks @vanzin @srowen


Correction to key generation in Encryption Example

This is a little change but when reviewing the Encryption Example, I found that current key method was just producing NSData of just 64 0's as its key. This was also discovered on a test I did of this method (not committed)
Although that this is a key and that the rest of the code looks like its correct, I am concerned with the non random key generation. This is because I feel for developers new to encrypting their realms they might have looked at this code and think this is correct and that it generates a random key. There is also a risk that a developer running late on a deadline may just copy this code into production code.
I feel that this tutorial does not need to explain what is going on here that a non-unique key is being generated, and the importance of why you want a random unique key. This just means that if someone was to get the hands on on the .realm file it would be very easy to decrypt - a brute force would find this issue immediately.
This commit just adds a function that I have used in other projects to generate a unique key and a few comments to suggest to me what it is doing.
Thanks
Osian

The existing code successfully generates a random key for me when I run it on an iPhone 6S running iOS 11.

During my testing it was not actually unique - if you ran a couple of times you would see while yes it would create a value. if you were to ask it again it would then then just return the same number in the key as 64's 0

If you are not clearing the keychain between runs (which merely deleting the app does not do), then it will return the same value every time, because that's the entire point.

If you are able to construct a consistent repro case for SecRandomCopyBytes() failing to work on a non-jailbroken device then you should report that to Apple as that would be a critical OS-level security flaw.

Closing due to lack of repro.


add blank impl Error for ReadError

Hi.
Thanks for the awesome library.
I have only one problem with it - ReadError doesn't implement std::error::Error, so I can't use ? if my function returns anyhow::Error or Box<std::error::Error>.
I noticed, that impl Error was removed recently as deprecated in 4b804d1ec0df433ccb406d6d3dff3f599000ebac. But I guess it was removed as a whole by mistake. It is still recommended implementing std::error::Error for error types and only implementing description was deprecated in favor of Debug+Display.

thank you for your cooperation!


Show ~7 days by default, added loading spinner for roster screens

jenkins retest this

jenkins retest this


Make docimagesdir attribute available in theme

The theme can currently access the value of the imagesdir attribute using {imagesdir}, but not the absolute path resolved from the document directory (i.e., docdir). To make the value absolute (assume it isn't already), the best the theme can do is use {docdir}/{imagesdir}. However, this assumes that the value is relative.
Compute the absolute path of the imagesdir and assign it to the docimagesdir attribute when resolving values from the theme.

the best the theme can do is use {docdir}/{imagesdir}

Actually, this isn't true. In the theme, the imagesdir is always set to themesdir. That's why this new attribute is even more important.


bns -> cb1 -> others

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Prompts for microphone access

This is probably tricky to fix because it involves init, but I cannot have my app ask for microphone access.
Might be worth splitting the video camera into a separate component. It doesn't actually share much code with the still camera.

Going to close this, let me know if you encounter any problems.


JsonPatch escape hatches are applied twice in CI

YamlFile.writeFile() calls YamlFile.toYaml() which calls JsonPatch.apply(). There,  patching is done with applyPatch() from fast-json-patch, which modifies the passed object.
In CI, we first call YamlFile.toYaml() in the diffProtection block, followed by YamlFile.writeFile().
This causes the patches to be applied twice. That works only if the patches are idempotent. If you define a patch that removes a list element:
pipeline.workflowFile.patch(JsonPatch.remove('/jobs/myJob/steps/0'))

The first element will be remove once locally, but twice in CI.
To fix this, we could:

change YamlFile.toYaml() to clone the object before passing it to JsonPatch.apply()
change JsonPatch.apply() to clone the document before applying patches
change GitHubWorkflow.doBuildPipeline() to skip calling YamlFile.writeFile() in CI

Huh. Good catch. I think we want toYaml to be idempotent. That makes me feel like option 1 is the best: change YamlFile.toYaml() to clone the object before passing it to JsonPatch.apply(). Are you willing to submit a PR for this @christophgysin?

@kaizencc Sure, please check my proposed fix in PR #384


Issue in Storage Loader "Missing New Line"

I am using "snowplow_kinesis_r60_bee_hummingbird" release to setup entire data pipeline.
When storage loader executes following error is consistently popping up
Missing newline: Unexpected charact
er 0x4f found at location 3
Missing newline: Unexpected charact
er 0x0 found at location 0

Hi @anishdevasia - I'm not sure I follow. snowplow_kinesis_r60_bee_hummingbird sets up the Kinesis pipeline, which doesn't use StorageLoader.
Can you add a comment providing more detail on your exact setup?

Thanks for quick reply.
I am using following components to setup kinesis pipeline

Scala Collector(snowplow-stream-collector-0.3.0)
Scala Enrichment( snowplow-kinesis-enrich-0.3.0)
S3 Sink (snowplow-lzo-s3-sink-0.1.0)

All these steps works perfectly and I am getting "lzo" files in S3.
At 4th setup where I try to load "lzo" files from S3 to Redshift using Storage loader I am getting the above reported error.

I think, I should have posted this issue in the forum first.

Hi @anishdevasia - ah, I understand, that makes a lot more sense.
Would you mind posting it into the forum? I'll then answer it there.


Letting user know when a packet has dropped

It would be nice if uvgRTP would tell when a packet was lost during transit. Currently, the user can have a very hard time determining if a frame was lost.
Something like a callback function would probably be useful.
The RTCP reports are specific enough to determine which packet was lost.

There was a plan to implement this at some point but then we pivoted to having the frame receiver drop inter frames until it received an intra so I never finished the implementation but some remnants of it still remain:
https://github.com/ultravideo/uvgRTP/blob/master/src/media_stream.cc#L472
https://github.com/ultravideo/uvgRTP/blob/master/include/uvgrtp/util.hh#L284

@altonen Is there something I can do to detect missing frames to drop those before next Intra? I'm currently trying to get rid of gray screens caused by dropped frames (currently, mostly from #105), but I have not been able to find a way (other than maybe POC in the frame itself) to determine which frames were lost.
I was under the impression that the frame dropping would be done on the application side and that is why the notify-callback was needed.

Can't you determine which frames were lost based on which frames were garbage collected? Maybe I'm not understanding the question but I think determining which frames are lost is quite easy because they are still incomplete in the frame buffer when their timer expire.

Oh, maybe I'm misremembering. That would probably be ok, if it could be disabled via flags and this notify would be implemented for those who want to self-manage.
As it is, neither is usable, so if I understand correctly, it is currently not possible to react to lost frames to avoid those gray screens?
I created a new issue for this (#121).

I think you can disable the behavior by giving RCE_H26X_NO_INTRA_DELAY in which case uvgRTP doesn't drop inters/wait for intras but instead returns all received inter frames, regardless of whether the intra of that GOP(?) was received. Or at least that's how it's suppose to work.
Currently there's no way for the application to react to, or even know about, if/when a frame has been dropped.

A system inside uvgRTP is probably better than having the user to react to lost frames (I already made a simple version). Closing this issue. If someone has need for this, they can reopen this or create a new issue.


New version: Mihomo-Party.Mihomo-Party version 1.2.21

Pull request has been created with WinGet Releaser :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


no-unnecesary-type-assertion: false positive for non-null-assertion and uninitialized variables

Bug Report

TSLint version: 5.8.0
TypeScript version: 2.6.1
Running TSLint via: CLI

TypeScript code being linted
// code snippet
function foo(param: string) {
  let tmp: string;
  if (param)
    tmp = param;
  tmp! === "foo"; // <- this line
}

with tslint.json configuration:
"no-unnecesary-type-assertion": true

Actual behavior
Error on the non-null-assertion, because the type of the is not changed by the assertion. If you remove the assertion you get a compile error because not all code paths initialize the variable.
Expected behavior
No error. That's currently not possible because we need a new TypeChecker method for that: https://github.com/Microsoft/TypeScript/issues/20221
To avoid such false positives, we could exclude identifiers matching the following criteria until we get the new TypeScript API:

assertion is on an identifier
identifier is a mutable variable

let or var
no parameter
no import
no ambient declaration (declare let foo)
not from destructuring declaration

declaration is in the same function scope as the assertion
has a type annotation
declared type does not include | undefined
variable is not initialized

FWIW, I have a working solution in no-useless-assertion of @fimbul/wotan https://github.com/fimbullinter/wotan/blob/master/packages/mimir/README.md#rules

💀 It's time! 💀
TSLint is deprecated and no longer accepting pull requests other than security fixes. See #4534. ☠
We recommend you instead use typescript-eslint to lint your TypeScript code with ESLint. ✅
👋 It was a pleasure open sourcing with you!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


Prisma generated files exceed Vercel 50MB serverless function size limit

Bug description
When creating a serverless function on Vercel with prisma, the generated prisma files exceed 50MB by themselves, making prisma incompatible with vercel serverless functions. Here is an example size table reported by Vercel:

Large Dependencies            Uncompressed size  Compressed size
--
17:47:40.610 | web/generated/prisma                  142.15 MB         51.99 MB
17:47:40.610 | web/node_modules/next                   2.19 MB         760.8 KB
17:47:40.610 | web/node_modules/react-dom              2.18 MB        546.37 KB
17:47:40.610 | web/.next/server                     1007.04 KB        247.88 KB
17:47:40.610 | web/node_modules/@nextui-org          803.96 KB        245.01 KB
17:47:40.610 | web/node_modules/iconv-lite           321.65 KB         175.1 KB
17:47:40.610 | web/node_modules/graphql              598.74 KB        147.53 KB
17:47:40.611 | web/node_modules/@react-aria          430.31 KB        109.37 KB
17:47:40.611 |
17:47:40.611 | All dependencies                      153.51 MB         55.13 MB

How to reproduce
Create a stub nextJS project and include prisma in the dependencies.
Expected behavior
I'm not sure what is expected. Is this a bug or do I need to migrate off of prisma or off of vercel?
Prisma information
@prisma/client 4.3.1
@prisma/engines 4.3.1
Environment & setup
Vercel
Prisma Version
4.3.1

Hi @6peterlu, can you please try again using<EMAIL_ADDRESS>As highlighted in the release notes, we have shrunk the size of Prisma engines by ~50%.

Oh thank you so much! Upgrading prisma and prisma client shrunk it enough. Awesome work by the prisma team 💪

Besides that, do you really need Prisma CLI in your serverless function?
Is Prisma CLI installed as a normal dependency or a dev dependency? As a dev dependency, it should usually not be included in the function archive.

@janpio good question, I did not realize I was including the CLI in the function. is that the "prisma" package?

Yes, prisma is Prisma CLI, @prisma/client is the Prisma Client (runtime) and .prisma/client is the generated Client specific to your Prisma schema.

@janpio got it, thanks. i was originally installing the CLI to run migrate during deployment, but I will now try running that in a separate step instead of bundling it into the prod server


Add a common inventory payload parser

Depends: ~~https://github.com/ManageIQ/topological_inventory-sync/pull/6~~

@gtanzillo okay this is ready to review


Property type inferred as unknown in conditional expression

Here's a simple repro:
class MyStruct {
  method() {
    alert(this.someProp);  // Results in error: property `someProp`. Property not found in MyStruct

    if (this.someProp && this.someProp.length) {  // Works fine.
      alert(this.someProp.length);  // No errors here.
    }
  }
}

Accessing an undefined property directly results in an error, but works fine in conditionals expressions. The interesting thing is that type-at-pos reports the first instance of this in the conditional to be of type MyStruct, but the second instance of it to be (unknown). Is this behavior expected, and/or is there a way to prevent it (i.e., throw an error)? Thanks.
EDIT: related to #1810, #1954

A colleague of mine just ran into this issue.  It would be nice if flow raised errors on any undeclared member instance inside a class.


make http requests redirect to https

either on the lego side, or in go router

resolved in releases/1.0.7 836a1db3986f3824f3cd9d7415402a0ed33fa5d7


List files in dataset

In order to know what files are in a dataset, a generic API endpoint for retrieving the files in a dataset is required:
/v1/datasets/list-files

Duh! Missed the files property in the JSON results. Already present.


UI Chart - Interpolation Method

Description
For line charts, users should be able to define how data is interpolated between those lines.

Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

I'm using line and step with dashboard 1.0