[Feature]: Apply the depletion survey (option 34) with an initial year that is not unfished

Describe the solution you would like.
I think the current implementation of the depletion survey option assumes the first year entered is at unfished. It would be great to have a flexible definition of what the first year is relative to unfished.
For instance, in a model that does not have a full time series of catch, but the user has a guess of depletion in the initial year of available catches, it would be great to be able to specify the survey with that depletion in the first year of the model.
As an example, say catches start in 1975 forward, but there were removals before that time. The user may want to presume the stock is at, say 75% of unfished in 1975, thus the model can move forward with that depletion assumption, instead of it being assumed unfished in 1975.
Describe alternatives you have considered
The tricky part of this I see is assuming what the age/length structure is in that initial year if it is not unfished.
Current ways of doing this is to use the equilibrium catch approach to calibrate a model's population structure and achieve a certain depletion value in a specified year.
If this can be automated in the model, it could be much easier for users to apply.
Statistical validity, if applicable
No response
Describe if this is needed for a management application
No response
Additional context
No response

The calculations do not assume that the first year entered is unfished.  For each year, value that is entered, SS3 creates an expected value from the simple calculation:
                     vbio = (SSB_current + 1.0e-06) / (SSB_virgin + 1.0e-06);
Then with Q=1, this value is treated as the absolute level of depletion in that year.
There is no need to enter a time series or even >1 observation.  The code works with a single value for the depletion survey.
If the user believes that an unknown level of historical catch has depleted the stock to 80% of unfished level at some early year then the setup would:

set the depletion obs to start_yr, 0.80
add an initial eq catch with an arbitrary value
set lambda for the initial eq catch to nil value

This will cause SS3 to estimate the initial F.  The value of the initial F will be mostly influenced by the depletion survey value, plus some influence from the size/age comp in early years.
When the first year, value is something like 1950, 1.0 then it is usually because the user wants model to

@Rick-Methot-NOAA Should this be added anywhere in the user manual or in a vignette on the website? Can this issue be closed?

I or Jason should review the user manual to see if it is sufficient.  A short vignette is a possibility also.

Okay sounds good. @shcaba if you have time to review the user manual, please let us know if information about the depletion survey is sufficient. Info on option 34 (depletion) is found in the Indices section of the user manual


Add notes about installing from master

vendor dir is not included, add notes about how to install from master branch.

Closing this until I setup the release flow properly.


system_certmanager: take extensions out of a DN

Hi.
replaces https://github.com/opnsense/core/pull/4755
closes https://github.com/opnsense/core/issues/4675 i hope

@kulikov-a thanks, looks good. We should probably leave this on master for some releases as a safety precaution, but splitting dn and extns is definitely the way to go.

@AdSchellevis  thanks!!!


ENG-2573: Updates node text size and the initial viewport of react flow canvas.

Describe your changes and why you are making these changes
This PR updates the viewport starting x,y,zoom of ReactFlow canvas as well as makes the text size of DAG nodes larger.
Related issue number (if any)
N/A (will create soon)
Loom demo (if any)
https://www.loom.com/share/dff9a948609441aebeb1bea6443a2876
Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[x] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[x] If this is a new feature, I have added unit tests and integration tests.
[x] I have run the integration tests locally and they are passing.
[x] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[x] All features on the UI continue to work correctly.
[x] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123, quick question about this — we do the refresh, but we don't actually seem to update the state on the UI in this demo. i.e., we rename from succeed_complex_renamed to succeed_complex, but once you do the reload, the breadcrumb and the header of the workflow page both still have succeed_complex_renamed on them. Is that intentional? It seems quite confusing to me from a UX perspective.

@agiron123, the node issue was resolved by my other PR, and I bet it's going to cause some annoying merge conflict issue.
As for the starting point of the ReactFlow viewport, I'm not sure I like the idea of starting with the DAG cutoff. We might have to do this for extremely large DAGs, but for normal-sized DAGs like the ones we have in our tests, I would very much like to show the whole DAG on-load when possible. Let's discuss further before finalizing this.

@agiron123, the node issue was resolved by my other PR, and I bet it's going to cause some annoying merge conflict issue.
As for the starting point of the ReactFlow viewport, I'm not sure I like the idea of starting with the DAG cutoff. We might have to do this for extremely large DAGs, but for normal-sized DAGs like the ones we have in our tests, I would very much like to show the whole DAG on-load when possible. Let's discuss further before finalizing this.

@vsreekanti Sounds good. I'm just going to close this PR.


[BUG] Recurring Job delete not working correctly

I open LH GUI
open volume tab
click a volume to open the details
scroll down
click add job
click ok
open recurring job tab
delete the job there
go back to volume tab
open details of the volume again
scroll down
and see this:

I can delete this "crippled" job now but IMO it is a bug.
PS: The exclamation mark sais "Recurring Job doesn't exist".
Environment

Longhorn version: 1.2.3
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: kubeadm

Number of management node in the cluster: 1
Number of worker node in the cluster: none

Node config

OS type and version: Debian 11.01
CPU per node: 8 hyperthreads
Memory per node: 32 GB
Disk type(e.g. SSD/NVMe): mechanical
Network bandwidth between the nodes: none

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Baremetal
Number of Longhorn volumes in the cluster: 3

Hello @PhilipMay can you still see those deleted Recurring Jobs as CRs? with kubectl command:
$ kubectl get recurringjobs.longhorn.io -n longhorn-system
NAME       GROUPS        TASK       CRON        RETAIN   CONCURRENCY   AGE   LABELS
c-2lyahm   ["default"]   backup     0 0 * * *   1        1             24s
c-ei0v3r                 snapshot   0 0 * * *   1        1             30s

And if possible can you describe the resource, for example:
$ kubectl describe recurringjobs.longhorn.io/c-2lyahm -n longhorn-system

There might be some clues.

This is expected. We don't auto-delete the recurring job from individual volume.
We can add a warning message before deleting a job though. Something like, if there are volumes that are using the job, there should be a warning message notifying the user about this.

This is expected. We don't auto-delete the recurring job from individual volume.

Due to this bug we had to realize after some times that volumes have not been backed up anymore!
Why is this expected?
Basically the use case is: change individual schedules to default schedules and here we create the default one and delete the old one.. so what is the usage of the "old" and "useless label" causing the default job not to be activated and not having a backup anymore?

We can add a warning message before deleting a job though. Something like, if there are volumes that are using the job, there should be a warning message notifying the user about this.

I believe in case this is not automatic - we should add a option to delete the assignments of the jobs on the volumes automatically when deleting the job.

Thanks @Martin-Weiss for the feedback! If the other job of the volume is affected, it seems like a bug. To be more specific, could you re-summarize the reproducing steps?

Basically the use case is: change individual schedules to default schedules and here we create the default one and delete the old one.. so what is the usage of the "old" and "useless label" causing the default job not to be activated and not having a backup anymore?

cc @c3y1huang Could you please take a look at this behavior?

We ran into the problem with using Longhorn backup schedules pre-"reccuring jobs" feature, then upgraded and then deleted the "old migrated jobs" and created new default jobs..

install old longhorn version (without the recurring jobs feature) and use the schedules defined on the storage class
create PVCs and get/use PVs in Longhorn
see backup and snapshot happening
do disaster recovery of some volumes (where you geht longhorn-static storage class)
configure backup for the restored volumes
upgrade longhorn to 1.2.2
see the "migrated" jobs with "strange names"
delete the "jobs with strange names"
create new default jobs
now realize that the volumes are not backed up because they have "old and invalid labels" and the default jobs are not used, because there are invalid labels on the volumes

@Martin-Weiss, thank you for the feedback. We will look into it.

This is impacted by #2955 due to the rancher API client has not been updated for the possible backward compatibility purpose.
cc @derekbit @jenting

@derekbit It seems we need to update https://github.com/longhorn/longhorn-manager/blob/436bda78a955bdaf4bd9a73bc5fd4613f84bcb24/client when the REST API interface updating, but it seems we don't do anything for this condition change for models.
Iff we keep conditions as a condition map for all models used by REST API, we probably need to do sliceToMap(*node*.Status.Conditions) for all models. WDYT?

I remember we intended not to update the REST API interface to minimize the effort on request longhorn-ui update.

I remember we intended not to update the REST API interface to minimize the effort on request longhorn UI change/update.

Is it possible to cause some extra efforts to maintain the generated code if new resources are introduced?

I remember we intended not to update the REST API interface to minimize the effort on request longhorn UI change/update.

Is it possible to cause some extra efforts to maintain the generated code if new resources are introduced? If yes, probably need to rethink a bit.
cc @smallteeths

I remember we intended not to update the REST API interface to minimize the effort on request longhorn UI change/update.

Is it possible to cause some extra efforts to maintain the generated code if new resources are introduced? If yes, probably need to rethink a bit.
cc @smallteeths

Yes. For a new resources introduced, need to implement the conversion if the conditions exist.

Validated on master-head 03/09/2022
Validation - Pass
When the last recurring job is deleted, the recurring job gets deleted from respective volumes as well. Longhorn shows the following warning message when user tries to delete the recurring job.

@c3y1huang I'm assuming the default group will not be deleted even if I created a recurring job in default group and later delete it. Could you please confirm the behavior?

@c3y1huang I'm assuming the default group will not be deleted even if I created a recurring job in default group and later delete it. Could you please confirm the behavior?

Correct, and this behavior is also included in the automation test  here


feat: radiology - generate scan table cli

Added generate scan table CLI with tests and sample data from TCIA
Added a new dependency and updated docker
Fixed tests that were failing due to new version of scikit-image

Codecov Report

Merging #265 (addbd3a) into dev (a63e938) will increase coverage by 0.32%.
The diff coverage is 67.30%.

@@            Coverage Diff             @@
##              dev     #265      +/-   ##
==========================================
+ Coverage   71.38%   71.70%   +0.32%
==========================================
  Files          45       45
  Lines        3138     3220      +82
==========================================
+ Hits         2240     2309      +69
- Misses        898      911      +13

Impacted Files
Coverage Δ

...luna-radiology/luna/radiology/common/preprocess.py
45.58% <ø> (+3.02%)
:arrow_up:

...adiology/luna/radiology/cli/generate_scan_table.py
67.30% <67.30%> (ø)

setup.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63e938...addbd3a. Read the comment docs.


Video source reorder

This means that video transcodes are used before the original video source

Looks good to me


Closes #544 (make sure that overshoot param works)

parse_params takes an overshoot param. It also takes kwargs so if you pass over_shoot no error occurs. Another PR that is open right now is going to deprecate kwargs so that problem will go away eventually. generate_np doesn't raise an error because all the tests called with over_shoot and over_shoot was declared as an argument.


Venues are not indexed

Searching for POPL or LICS at https://quantumpl.github.io/bib/publication/ does not return any results.

Not being indexed for search in the publications filter, but venues are now searchable on the site-wide search. See:

https://quantumpl.github.io/bib/?q=POPL
https://quantumpl.github.io/bib/?q=LICS


[Reboot] New component

Closes #9641
cc @mui-org/core-contributors

Yes!

Nice idea, not sure about the name though... Perhaps Reset? (Or am I being too literal?! 😕)

http://getbootstrap.com/docs/4.0/content/reboot/

Once it's released, we can update the examples.

@oliviertassinari Actually, if this were a standalone project "Reboot" is a bit more catchy - it was just that most things in MD (so by extention in MUI) are named more literally, but that's cool.

to provide a convenience boolean prop on MuiThemeProvider to accomplish the same, i.e.

@pelotom Adding the extra boolean property will make people no using the component pay the import price. Also, it will save people one import.

Good points 👍


Fix test case for a button with no type via text

In the fixtures, this button's text is actually button with no type. The current text (Submit button) selects an element which belogs to another test case: clicking button type[submit] via button text.

Good catch @britto :+1:


Add support for uuid columns

This PR will add support for columns with the UUID type. Since there is no native UUID type in javascript the UUID is converted to a string.
In the SQL schema used for the test I added a new column with the UUID type.

Thank you @MaikelH

Released 0.3.1


Browser Native UI showing up

On this page, https://www.vidstack.io/docs/react/player/providers/video
seeing browser native controls,

Browser: Version 110.0.5481.181 (Official Build) (64-bit)

I think that's intentional because they haven't made a skin yet


fix: use with shadowsocks transport

closed #188

@ibigbug Hello.Tls mode is impl, but i haven't tested yet.


don't block network traffic while iptables refresh

With large iptables to check, the mutex lock the network processing.
Deleting the mutex :

let the network flow to continue while tables are syncing (majority of them are simple checks)
let mutex on fine grains in iptables.go to ensure safe update
lead to potential serviceMap staled data that will recover on next syncloop

This is a workaround that will work for a least 1000 rules, over this limit the check time can be over the sync timer.

I signed it!

@k8s-bot ok to test

@thockin

CLA bot is not happy, can you please double-check?

This is an insufficient change - you can not have unlocked access to a map that is mutated elsewhere, potentially in another goroutine.  You could instead do something like:
// Great big comment on what you're about to do and why.
lock
read all map keys into an array
unlock
for each key {
    lock
    confirm key is in the map
    process key
    unlock
}

Worst case is it misses new entries until the next loop.
You might even get away with unlocking BEFORE processing the key, at a risk of processing keys that no longer exist, which will also be picked up by the next loop.

Not funny I've got no error on compilation there can you tell what's happening. It passes tests on 1.0.1 .
Hum CLA bot be cool because I already sign the CLA ...
Thinking about the risk of processing keys that no longer exist is quite a non sens :

sync loop is called each 5s, at that time we already process keys that no longer exist, and mutex or no, it doesn't change anything.
Why keys will no longer exists? because of pod relocation for sure. So it adds a little delay while the new endpoint won't be reachable. After the docker pull, volume mount, and standard initialization a little extra delay for great benefits worth it.

Re CLA: I manually search the CLA database for bnprss and I find nothing. Did you sign it under a different handle or email?  Your email is not on your github account, so the bot can't verify email.
Re Travis and Shippable: Both failed for needing to run gofmt:
$ ./hack/verify-gofmt.sh
!!! 'gofmt -s' needs to be run on the following files:
./pkg/proxy/proxier.go

Re the code: Whenever any piece of code iterates that serviceMap, the lock is held.  If there is any place that is NOT true, it's a bug.  Go's maps are not thread-safe and require external synchronization.  As I suggested, you can drop the lock after extracting the keys from the map (while locked) but you can not access the map without the lock.

Given #13345 I don't think we need this.  If you still want to do it, I think it is still not quite right.  You really should hold the lock while getting the keys, and when processing each item, but you want to unlock between items.


Remove tilt/reveal animations

Description

This PR removes tilt/reveal animation from all the new styles. Closes #4261

I think you can add "Closes #242" since this would address this sufficiently. Also looks like there is a merge conflict.

/azp run

/azp run

/azp run

The reveal removal was moved to a separate PR


net45 support

@alhardy Is there a reason to not support .NET Framework lower than net452?
It would be great to have a possibility to use this library in net45 projects.

@neoned Why stopping you from upgrading to net452?

@neoned no plans to support net45, @johnduhart mention upgrading, that'd be a better option considering https://github.com/Microsoft/dotnet/blob/master/releases/README.md


Postgres driver download error maven

Description
when I recently installed a DBeaver (some version previous to CE 24.1.2) it showed me the following error when trying to download Postgres drivers:

This simply tells me to uncheck this checkbox:

After restarting its all working to download the driver.
But in the last version (as of today) CE 24.1.2. This is what shows:

Randomly while trying to download, I got more info on the error:
Network unavailable
java.io.IOException:Exception during a connection to https://repo1.maven.org
  Error resolving dependencies
    Exception during a connection to https://repo1.maven.org/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
      Exception during a connection to https://mvnrepository.com/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
        Exception during a connection to https://oss.sonatype.org/content/repositories/snapshots/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
          Exception during a connection to https://repo1.maven.org/maven2/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
            Exception during a connection to https://repo1.maven.org/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
              Exception during a connection to https://mvnrepository.com/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
                Exception during a connection to https://oss.sonatype.org/content/repositories/snapshots/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
                  Exception during a connection to https://repo1.maven.org/maven2/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom

Edit
I was able to install everything with no issue (just the above mentioned need to uncheck that box) with the installer for version CE 23.3.5.
DBeaver Version
Community Edition 24.1.2
Operating System
Microsoft Windows Server 2022 Standard
Database and driver
None at this point.
Steps to reproduce

Click to create a Postgres DB.
Click on the "Driver properties" tab and download.

Additional context
No response

Hello @FMorschel,
Did you install the newer version using the installer? Perhaps you have unchecked the option called "Include Java" during the installation?

Yes I did install with the latest Windows installer.
Sorry but I did not change any default options in the installer.

Can you manually open URLs from the error message in your browser? Do all of them open fine?

The ones that open
Both that machine and my personal computer:

https://repo1.maven.org
https://repo1.maven.org/maven2/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
https://repo1.maven.org/maven2/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom

Only my personal computer:

https://oss.sonatype.org/content/repositories/snapshots/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
https://oss.sonatype.org/content/repositories/snapshots/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom

The ones that do not
Both that machine and my personal computer:

https://repo1.maven.org/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
https://mvnrepository.com/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
https://repo1.maven.org/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
https://mvnrepository.com/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom

Only on said machine:

https://oss.sonatype.org/content/repositories/snapshots/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
https://oss.sonatype.org/content/repositories/snapshots/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom

Every type of error I got

Just to be explicit: both machines are not in the same network.
But my point here stands that when doing the same steps with the previous version, I got a warning to uncheck that security verification and by doing so, everything was downloaded just fine.

@FMorschel Hi, do you use Java with the DBeaver, it might be an issue with java truststore?

Hi!

[...] do you use Java with the DBeaver [...]?

I'm not sure but I think so.

[...] it might be an issue with java truststore?

I'm not familiar with Java Truststore, not a Java dev. What can I do to help you in helping me? Can you point me to any docs so I can meet you with more basic knowledge in common that relates to this problem?

Same problem. Fresh install on windows.
Network unavailable
java.io.IOException:Exception during a connection to https://repo1.maven.org
  Error resolving dependencies
    Exception during a connection to https://oss.sonatype.org/content/repositories/snapshots/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
      Exception during a connection to https://repo1.maven.org/maven2/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
        Exception during a connection to https://oss.sonatype.org/content/repositories/snapshots/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
          Exception during a connection to https://repo1.maven.org/maven2/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom

I have the same issue since I fresh installed DBeaver.

Also having this issue. I'm trying to connect to a postgress 16 DB:
Network unavailable
java.io.IOException:Exception during a connection to https://repo1.maven.org
Error resolving dependencies
Exception during a connection to https://oss.sonatype.org/content/repositories/snapshots/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
Exception during a connection to https://repo1.maven.org/maven2/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
Exception during a connection to https://oss.sonatype.org/content/repositories/snapshots/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
Exception during a connection to https://repo1.maven.org/maven2/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
The ones I'm having trouble opening are these two:
https://oss.sonatype.org/content/repositories/snapshots/com/github/waffle/waffle-jna/1.9.1/waffle-jna-1.9.1.pom
https://oss.sonatype.org/content/repositories/snapshots/org/postgresql/postgresql/42.7.2/postgresql-42.7.2.pom
Browsing the sites for postgres I can't find a 42.7.2 snapshot

Similarly for waffle-jna I can't find a 1.9.1 snapshot

Admittedly I'm a bit out of my depth here but this is as far as I was able to go.

I'm having the same error, fresh installtion of dbeaver

work-around:
* go to Driver Manager - PostgreSQL

* remove all libraries

* add file https://jdbc.postgresql.org/download/postgresql-42.7.3.jar (download first)

This worked for me, thank you.

Just another work-around if anyone is interested or if the above doesn't work for some reason (I commented above):

[...] doing the same steps with the previous version [version CE 23.3.5], I got a warning to uncheck that security verification and by doing so, everything was downloaded just fine.

After downloading the drivers, I simply updated my dbeaver.

I get this same issue when trying to connect to an Azure SQL database.... anybody have any ideas?

Go to Preferences and disable "Use Windows trust store". It worked for me. But if not, try to download 24.1.0 version.

Go to Preferences and disable "Use Windows trust store". It worked for me. But if not, try to download 24.1.0 version.
+1 in Windows 11

Disable it and restart the app.

Vaya a Preferencias y desactive la opción "Usar el almacén de confianza de Windows". A mí me funcionó

Go to Preferences and disable "Use Windows trust store". It worked for me. But if not, try to download 24.1.0 version.

Ve a preferencias > conexiones
el cuadro de security , desactiva Use Window trust store
Cerrar Dbeaver y volver a abrir

Me funciono Gracias

I had the same issue when I tried to add a mySQL db on a freshly installed dBeaver today (on a new machine) with default settings. I managed to correct it by going to Preferences and disabled "Use Windows trust store", then restarted the app.

In 2024-09-20 I downloaded DBeaver version 24.2.0 and had the same problem with Maven dependencies. But in my case when trying to download the MariaDB driver. I solved my problem by DISABLING the option:
Window -> Preferences -> Connections -> Use Windows trust store.
I only have java openSDK 17.0.2 installed on my WSL2 Ubuntu 24.04.

I faced the same issue. Here are the steps to resolve on Mac.
First download PostgreSQL driver from https://jdbc.postgresql.org/download/
"Database"-> "Driver Manager" -> select "PostgreSQL" -> "Edit" -> "Libraries"

Delete everything present there
Click "Add File" -> select the driver downloaded and click "OK"
Close the "Driver Manager" window and restart the DBeaver tool

Now the DB connection starts to work.

Potentially this may happen if Windows root certificate storage doesn't contain CA for GlobalSign (it is the CA for root Maven repository).
By default DBeaver uses Windows cert storage (because it may contain non-standard corporate certificates).
Disabling checkbox "Use Windows trust-store" forces internal DBeaver Java trust store (which contains all standard certificates).
If your browser opens links like https://repo1.maven.org/maven2 then driver download should work in DBeaver with enabled "Use Windows trust store".

@serge-rider thanks for the explanation.
The reason I opened this issue is because on previous versions I got a reasonable message telling me to disable that check, now it doesn't show that message anymore.

@FMorschel thanks for the clarification
We'll try to fix it

I had the same issue when I tried to add a mySQL db on a freshly installed dBeaver today (on a new machine) with default settings. I managed to correct it by going to Preferences and disabled "Use Windows trust store", then restarted the app.

This fixed my issue as well. Thank you.

work-around:

go to Driver Manager - PostgreSQL
remove all libraries
add file https://jdbc.postgresql.org/download/postgresql-42.7.3.jar (download first)

This did work. Thank You!!


How to Stop Subscription?

Given a collection, suppose that there exist some finite set of subscriptions with different parameters over that collection.
Now, if I want to remove a particular subscription, how can that be accomplished using this package's syntax?
Is there any kind of stop/remove subscription method?

Sorry for wasting your time! https://github.com/oortcloud/node-ddp-client/blob/master/lib/ddp-client.js#L492


Add health state for Istio resources

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #387
Does this PR introduce a user-facing change?:

NONE

@ono-max
Nice. We can merge this for now to show the resources are applied normally.
I don't know exactly but I feel like there are a few more areas that need to be checked, especially for Gateway and VirtulService.
Could you look into them a little bit more?

If you've done, it would be nice if you could tell us a bit more about why it's enough 👍

@nakabonne
Sorry, I couldn't figure out how to check health state for them. Could you give me some kind of tips? The following URLs indicate locations of the structs.
https://github.com/istio/api/blob/master/networking/v1alpha3/gateway.pb.go#L474
https://github.com/istio/api/blob/master/networking/v1alpha3/virtual_service.pb.go#L231
https://github.com/istio/api/blob/master/networking/v1alpha3/destination_rule.pb.go#L316
https://github.com/istio/api/blob/master/networking/v1alpha3/service_entry.pb.go#L779

I might figure out one of solutions. Let me implement it.

/hold

/close
Let me close this PR for now.
We will reopen it later if we want.

/close
Let me close this PR for now.
We will reopen it later if we want.


⚠ Blogs Network has degraded performance

In 222bc72, Blogs Network (https://blogs.cranleigh.org) experienced degraded performance:

HTTP code: 200
Response time: 11199 ms

Resolved: Blogs Network performance has improved in bf8be8d.


fix dataclass bug with default_factory lambda func

@jylambert tested with the latest Python 3.12.3 please check and merge if it runs.

Runs with the latest version of Python 3.12.3


Gate doesn't work

After the last update gate doesn't work in notes

Try adding url:  before the link. It works for me.
```gate
url: https://www.google.com/
height: 300
```

Try adding url:  before the link. It works for me.
```gate
url: https://www.google.com/
height: 300

Thx, this really works

Try adding url:  before the link. It works for me.
url: https://www.google.com/
height: 300

Thx, this really works

Try adding url:  before the link. It works for me.
```gate
url: https://www.google.com/
height: 300

Worked for me as well. Thanks !


_hoodie_is_delete works differently on hudi spark datasource on docker compare to hudi on emr.

Describe the problem you faced
I tried _hoodie_is_delete on pyspark emr notebook and it works as desired. Below is my attached example performed in EMR -
https://gist.github.com/ashays83/6beaf642bd55b4c46292b8f382d0088b
and the i  tried _hoodie_is_delete on hudi spark datasource on docker and it gives these results attached below
https://gist.github.com/ashays83/af64d3c3795534e40c3b003b0796f349
So, as you can see in EMR when we upsert the updated records it keeps all the records and value for hoodie_is_delete field is set to false for the desired records and all other records are set to null.
But, I don't see the exact behavior in spark datasource. In here it only keeps the records which has false value for  hoodie_is_delete and all other records gets deleted.
So just wanted to understand why its acting differently on different environment.
Expected behavior
Need to have same result for hudi spark datasource.

hmmm, interesting. this is the first time I am hearing someone saying that they are seeing diff behavior in emr and docker using same script in spark-datasource.
Can you paste the contents of commit metadata when you ingested via docker and via emr? lets see if we can spot any difference.

w/ docker, can you ensure the operation is "upsert" and save mode is "Append".

my hunch is that setting nullable did not work as expected. Can you do df1.printSchema before ingesting to hudi and confirm that nullable for hoodie_is_deleted is set to true in both cases.

@ashah-lightbox : sorry to have dropped the ball on this. I can help me understand what you mean by docker(case 2)? is it hdfs that you are using within docker?
when you say EMR(case1), does it mean spark data source writer in EMR ? and are you using EMR's version of hudi. in docker, are you using oss hudi bundles?

also, I see you have used 2 diff scripts in both.
Can you try your EMR script https://gist.github.com/ashays83/6beaf642bd55b4c46292b8f382d0088b also in docker and share what you see.

@ashah-lightbox : gentle ping. any updates please. if you got the issue resolved, can we close it out.


Not able to retrieve templateParameters from Rest API: Runs - List

Hello MS Support,
According to the documentation: Get List Pipelines I am not able to retrieve templateParameters from the response.
This issue occurs yesterday and break the functionality which we built on it.
I have tried also with different version but the same issue.
Specification:
Rest API URL: GET https://dev.azure.com/{organization}/{project}/_apis/pipelines/{pipelineId}/runs?api-version=7.1-preview.1
Response:
{
    "count": 1,
    "value": [
        {
            "_links": {
                "self": {
                    "href": "https://dev.azure.com/xxxxx/xxxxx-xxx-xxxxx-xxxxx-xxxxxxx/_apis/pipelines/36022/runs/3137807"
                },
                "web": {
                    "href": "https://dev.azure.com/xxxxx/xxxxx-xxx-xxxxx-xxxxx-xxxxxxx/_build/results?buildId=3137807"
                },
                "pipeline.web": {
                    "href": "https://dev.azure.com/xxxxx/xxxxx-xxx-xxxxx-xxxxx-xxxxxxx/_build/definition?definitionId=36022"
                },
                "pipeline": {
                    "href": "https://dev.azure.com/xxxxx/xxxxx-xxx-xxxxx-xxxxx-xxxxxxx/_apis/pipelines/36022?revision=2"
                }
            },
            "pipeline": {
                "url": "https://dev.azure.com/xxxxx/xxxxx-xxx-xxxxx-xxxxx-xxxxxxx/_apis/pipelines/36022?revision=2",
                "id": 36022,
                "revision": 2,
                "name": "XXXXX.XXXX.StartStopService",
                "folder": "\\infra"
            },
            "state": "completed",
            "result": "canceled",
            "createdDate": "2022-11-29T15:26:24.8703595Z",
            "finishedDate": "2022-11-29T15:26:38.8340998Z",
            "url": "https://dev.azure.com/xxxxx/xxxxx-xxx-xxxxx-xxxxx-xxxxxxx/_apis/pipelines/36022/runs/3137807",
            "id": 3137807,
            "name": "20221129.862"
        }
    ]
}

As we can see at the response the parameter: templateParameters (object) is missing.
Could you please explain the reason why it doesn't appear at the response body?

Is anyone looking at this? Our service has been broken for two days because of this.

@madhuv-msft @srivatsn @Porges @abock could someone please check the issue? We have an impediment on production.

Any news on this? It has been one week and it's still broken.
Should we start looking into some workaround to get things running again?

Hi, this repo is for documentation feedback only. It is not the right place if you have an issue that is breaking your service.
For that go through proper support channels to have it looked at https://azure.microsoft.com/en-us/support/devops/

76 days later: “you’re in the wrong queue”
it was fixed recently, but thanks anyway.

The issue is solved


Curvilinear Raycaster crashes on AMD + Ubuntu

To reproduce:

On CISL-VAPOR2, start up vapor, import the WRF files in ~/Downloads/wrfout*
Create a volume renderer and enable it

In this case the Mesa drivers are being used (I updated the title). I managed to get the curvilinear renderer to work with Mesa drivers albeit with some graphical glitches that are only visible at lower grid resolutions.


Remove AssocList?

Based on questions from users, it is not clear when AssocList's should be used, e.g., over ordered maps. Arguably there are almost no cases where they should. Yet their existence may mistake programmers into thinking that their use is adequate when it isn't.

I think other modules are using it, e.g. TrieSet/TrieMap. The name says it's a List not a Map, and hopefully will convey the right time complexity?

I think it's is safe to assume that 75% of programmers do not know about time complexities, and select data types solely by interface. AssocList is more attractive to use than maps, because you don't have to provide an ordering for the key type.
If we can't remove it, then we should at least put a big fat warning in the documentation.

FWIW, I know some of our example apps import AssocList. If that isn't the best choice, maybe we should revisit/update the examples that use it?
Or possibly incorporate the warning message somehow in the examples?

This issue could be closed, IMO.

Yet their existence may mistake programmers into thinking that their use is adequate when it isn't.

They are "adequate" so long as the lists are bounded, as they are in the Trie, which uses them in its implementation.

I think it's is safe to assume that 75% of programmers do not know about time complexities

Probably not true of the developers that are first to approach the Internet Computer, but I take the general point about hiding things that are not efficient enough to be useful in real systems, at large scales.
But AssocList is useful in real systems, so long as the lists are not "too long." :)
Regarding scaling: There are so many different gotchas we have yet to address, that this one (still) seems like a minor one to me.  (A more urgent issue is having any representation for stable memory that is efficient.)


Add example data and resolve some nitpicks

Nitpicks == use of some contractions.

Nitpicks == use of some contractions.

:laughing: I can't help myself :P


React Native Error: Cannot resolve expo-secure-store

I am facing this error when adding polyfillMedplumWebAPIs() from @medplum/expo-polyfills to my React Native project. It looks like this API is not working with React Native CLI, is it only working in Expo?

Hi @duongthai910,
You may be able to use it without Expo Go/ Metro bundler by installing expo into your package as a dependency... That's maybe not ideal but seems to be the only way to get the functionality of Expo SecureStore
I haven't tested this yet, but it may work. Try this out: https://docs.expo.dev/bare/installing-expo-modules/
After installing the expo package alongside @medplum/expo-polyfills I think you should no longer see this error.
Our current support for React Native is limited and so we currently recommend using Expo if you plan to build with React Native and Medplum.
Please let us know if you try out installing expo into your React Native CLI application and if that works / is satisfactory

Closing due to inactivity.


Clerk API key not found during initialization of Express Middleware

Package + Version
<EMAIL_ADDRESS>
Description
I am trying to setup an Apollo GraphQL server, which uses express as the base layer, and the Clerk Express Middleware ClerkExpressWithAuth.
However, when following the documentation I get the following error:
file:///sandbox/node_modules/@clerk/clerk-sdk-node/dist/chunk-LF24WFXO.mjs:131
      throw Error(SupportMessages.API_KEY_NOT_FOUND);
            ^

Error:
Clerk API key not found during initialization.
Please visit https://github.com/clerkinc/clerk-sdk-node#options--env-vars-available for more information.

I added the CLERK_API_KEY in the .env.local file at the root of the directory, but it does not load it.
Codesandbox
Here is a codesandbox that experiences the same issue: https://codesandbox.io/s/apollo-server-clerk-62f4ie?file=/index.js
I set dummy values for the .env.local variables - but I am getting the same error when adding the correct api keys in my local repository, so I don' think it has any effects on my issue.
(The graphql interface would be accessible when navigating to the /api route. However at the moment the server is crashing, because of the error described above.)
Possible solution:
Allow to set the CLERK_API_KEY manually when initiating the middleware.
The general Clerk class already allows this (https://clerk.dev/docs/reference/node/getting-started#custom-instantiation).

Closing this one as the latest @clerk/clerk-sdk-node release should've solved the original issue, as @dimkl said above. Please feel free to reopen if you need any more help!


Duplicate permissions.

I think that it would be cool a command/web panel option to duplicate a bunch of permissions with a different context.
For example if I have these permissions:
https://i.imgur.com/5LEMlGa.jpg
to be able to select all permissions with content server=lobby and duplicate them with context server=skyblock .

Something like this is planned for a future release.
In the meantime, if you find there are a lot of the same permissions you need to use in different contexts I can suggest creating a group with the permissions (set to global) and then add the group with the desired contexts, night make it quicker for you.

This is probably going to be mostly resolved by https://github.com/lucko/LuckPerms/pull/2300
Of course there will still be cases where duplicating will be necessary / useful - just less often than at the moment 😃


Configure imgproxy timeouts + add click to load on imgproxy errors

https://github.com/stackernews/stacker.news/assets/27162016/14b4f919-95c5-47e3-b0bf-43584add0d92

We're still mutating the input markdown in this by the looks of it.
I thought we agreed we shouldn't. Was it too hard to stop doing that with signed urls?

We're still mutating the input markdown in this by the looks of it.
I thought we agreed we shouldn't. Was it too hard to stop doing that with signed urls?

Ah yes, we still mutate the input markdown.
But I realized the original URL is still available so it was faster to fix the issue by continuing with the replacement.
Also, the replacement is reverse-able at any time. I think the biggest argument against replacement was that the original URLs are no longer accessible which is not the case. We only sign the URLs, we don't encrypt them or anything else. The original URL is still available in base64Url encoding inside the imgproxy URL. So I am not sure if not using replacement is worth it :thinking:
The only other argument against replacement is to make the original URL accessible for stackers in any case (not only on errors). But I don't know when a stacker would want the original URL.


Add rate-limit to snapshots

We're taking ~15 snapshots, and we've reached Amazon's ConcurrentSnapshotLimitExceeded.
From what I see, every 1 hour all the snapshots are created in parallel.
Can you add a mechanism to control how many snapshots are created in parallel?

That's a great request - we've seen the same on DigitalOcean.
Not sure when we'll have time to implement, but happy to accept a PR here!

I believe the code needed to track this will also be useful for the Prometheus metric I suggested in https://github.com/FairwindsOps/gemini/issues/43#issuecomment-896347138


Client_credentials grant

Does oauth2-azure support client_credentials grants pls?

Yes, it does, I mean the underlying league/oauth2-client library supports that.
$provider = new TheNetworg\OAuth2\Client\Provider\Azure([
  'tenant' => $tenantId,
  'clientId' => $clientId,
//  'client_secret' => $clientSecret,
  'scope' => 'https://management.azure.com/.default',
]);
$provider->defaultEndPointVersion = $provider::ENDPOINT_VERSION_2_0;

$accessToken = $provider->getAccessToken('client_credentials', ['scope' => $provider->scope, 'client_secret' => $clientSecret]);


1.0.3 release

[1.0.3] - 20/10/2018
Fixed

incorrect build files

Pull Request Test Coverage Report for Build 16

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.542%

Totals

Change from base Build 13:
0.0%

Covered Lines:
180

Relevant Lines:
280

💛  - Coveralls


Dockerfile don't have the server.conf file

$ docker run -it server:v1 /bin/bash
/usr/local/bin/docker-entrypoint.sh: line 36: /etc/redis/server.conf: No such file or directory

It assumes that you've mounted the config file somewhere in the container. See https://github.com/reallyenglish/k8s-redis-ha/blob/master/kube/configmaps.yml

make sense. I'll create a environment for test locally before push to GCP.

Hi Ochko,
Thanks for sharing. I trying improve your repository. I have this goals if
you will find any solution please let me know:

2017-06-14T04:57:00.630562455Z 1:M 14 Jun 04:57:00.630 # WARNING: The TCP
backlog setting of 511 cannot be enforced because
/proc/sys/net/core/somaxconn is set to the lower value of 128.

This warning above is present in both images(server & sentinel)

2017-06-14T04:57:00.630620876Z 1:M 14 Jun 04:57:00.630 # WARNING you have
Transparent Huge Pages (THP) support enabled in your kernel. This will
create latency and memory usage issues with Redis. To fix this issue run
the command 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' as
root, and add it to your /etc/rc.local in order to retain the setting after
a reboot. Redis must be restarted after THP is disabled.

The another warning only present in server image.
I'm testing the new release 3.2.9 and insert the new parameter "PASSWORD"
Cheers,
Marcelo
On Wed, Jun 14, 2017 at 5:50 PM Ochko<EMAIL_ADDRESS>wrote:

It assumes that you've mounted the config file somewhere in the container.
See
https://github.com/reallyenglish/k8s-redis-ha/blob/master/kube/configmaps.yml
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/reallyenglish/k8s-redis-ha/issues/1#issuecomment-308395545,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBLNOadNHA8Mr6ysMABzqVBdbOPVIsSks5sD7rRgaJpZM4N5p3e
.

--
Regards,
Marcelo Barbosa
+66 6 3152 7937


[5.1] Use the remaining half bit in the refcount to bypass ObjC deallocation overhead

(cherry picked from commit c51294671bf2b9587f4de57ed834633359d84db3)
5.1 cherry pick of https://github.com/apple/swift/pull/25418

@swift-ci please test

Depends on https://github.com/apple/swift/pull/25589, so probably won't pass Linux yet

Build failed
Swift Test OS X Platform
Git Sha - e3da6c30b09cd55798b5bd0d82fbe54348f0b448

I meant iOS there, not Linux. That's why that failed.

@swift-ci please test osx platform

@swift-ci test osx

@swift-ci please test

There we go, dunno why it wasn't listening


Do not clear arrays if there are leftovers

Hello,
I’m curious if anybody had a use case similar to the following. I’m trying to decode a deeply nested struct, and I’d like to allow each node to have additional attributes that are not present in the corresponding struct by capturing leftovers in a special field. I’m doing so by post-processing the toml field of Decoder and assigning leftovers to the corresponding structs. The problem is Array: if an element of an array has been entirely parsed, it gets replaced by Value::Integer(0) and eventually removed from the array. As a result, one cannot tell in general the original positions—that is, the positions in the TOML file—of the elements in a leftover array. I would be grateful for any feedback. Thank you.
Regards,
Ivan

The issue remains, but I don’t like my workaround. Dummy Integer(0)s all over the place is not the way to solve this problem.
Regards,
Ivan


lmdbscan: better ability to handle duplicates in a special way

Scanning over databases and treating values for duplicate keys specially seems to be fairly cumbersome. It is always possible to iterate strictly using Cursor.Next. But a simple action like collecting all values for duplicate keys and printing them, is not as easy is it potentially could be. This is an example of scanning over a database using the NextNoDup and NextDup flags.
    err := env.View(func(txn *lmdb.Txn) (err error) {
        scanner := lmdbscan.New(txn, dbi)
        defer scanner.Close()

        for {
            scanner.Set(nil, nil, lmdb.NextNoDup)
            if !scanner.Scan() {
                return scanner.Err()
            }
            k := scanner.Key()
            vals := [][]byte{scanner.Val()}
            scanner.SetNext(nil, nil, lmdb.NextDup, lmdb.NextDup)
            for scanner.Scan() {
                vals = append(vals, scanner.Val())
            }
            if scanner.Err() != nil {
                return scanner.Err()
            }
            log.Printf("k=%q vals=%q", k, vals)
        }
    })
    if err != nil {
        panic(err)
    }

It should not be so clumsy. In particular, scanner.SetNext(nil, nil, lmdb.NextDup, lmdb.NextDup) is pretty lame.

I think its possible that a straightforward solution to this problem is to have the Scanner.Set and Scanner.SetNext functions actually call Cursor.Get, setting Scanner.Key, Scanner.Val, and Scanner.Err and buffering the result for the next call to Scanner.Scan.
    err := env.View(func(txn *lmdb.Txn) (err error) {
        scanner := lmdbscan.New(txn, dbi)
        defer scanner.Close()

        for {
            if !scanner.SetNext(nil, nil, lmdb.NextNoDup, lmdb.NextDup) {
                return scanner.Err()
            }
            var vals [][]byte
            k := scanner.Key()
            for scanner.Scan() {
                vals = append(vals, scanner.Val())
            }
            log.Printf("k=%q vals=%q", k, vals)

            // this may even be optional
            if scanner.Err() != nil {
                return scanner.Err()
            }
        }
    })
    if err != nil {
        panic(err)
    }

I believe that this can also work for scanning DupFixed databases.
    err := env.View(func(txn *lmdb.Txn) (err error) {
        scanner := lmdbscan.New(txn, dbi)
        defer scanner.Close()

        for {
            if !scanner.SetNext(nil, nil, lmdb.NextNoDup, lmdb.NextMultiple) {
                return scanner.Err()
            }
            var vals [][]byte
            k := scanner.Key()
            dup0 := scanner.Val()
            for scanner.Scan() {
                multi := lmdb.WrapMulti(scanner.Val(), dup0)
                vals = append(vals, multi.Vals()...)
            }
            log.Printf("k=%q vals=%q", k, vals)

            // this may even be optional
            if scanner.Err() != nil {
                return scanner.Err()
            }
        }
    })
    if err != nil {
        panic(err)
    }

I think the proposed solution seems pretty good. The lmdb.GetMultiple example is a little clumsy. But afaict at the moment that is because the operation is a little clumsy, forcing a distinction between duplicates and a single value.

I think this is orthogonal to a separate method to set opnext, proposed in #18. If such a method exists it should probably advance the cursor when it is called and return a bool too.


Extra dot in 0.12 docs

Looks like something similar to the previous release happened https://github.com/pytorch/vision/issues/4754
The newly pushed docs are https://pytorch.org/vision/0.12./ instead of https://pytorch.org/vision/0.12 (extra dot at the end), and the version tag shows a lot of extra info:

@mattip  is this something you could help us with, like you did in https://github.com/pytorch/vision/pull/4755 ?

I wonder how this happened. Do you have the build log from the ci run kicked off by tagging the repo?

I wonder how this happened. Do you have the build log from the ci run kicked off by tagging the repo?

CC @brianjo

There are two problems: the version should not be main (0.12.0a0+9b5a3fe) and the directory should not be 1.12. (with a dot).
The first problem:
here is the run, with VERSION=0.12.0. But this is not used to change the version from main (0.12.0a0+9b5a3fe) into 1.12. In pytorch, the conf.py file was changed to avoid the name mangling. It now uses RELEASE and has this (paraphrasing):
RELEASE = os.environ.get('RELEASE', False)
version = 'master (' + torch_version + ' )'
release = 'master'
if RELEASE:
    # Turn 1.11.0aHASH into 1.11
    version = '.'.join(torch_version.split('.')[:2])
    html_title = " ".join((project, version, "documentation"))
    release = version

The second problem
The script to commit the documents is using tag=${CIRCLE_TAG:1:5} instead of a more clever regex tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9]*\.[0-9]*\).*/\1/'). So the tag 1.12.0 is turned into 1.12. (5 characters) instead of 1.12.
I will make a PR to fix this. Then the next tag (the release?) will (hopefully) build the proper documents.

Reopening since https://github.com/pytorch/vision/pull/5583 fixes the issue for the next releases, but the current docs are still https://pytorch.org/vision/0.12./

The docs were moved in #5588. But there is still a problem with the <title> in all the pages. It should be
- <title>torchvision.datasets._optical_flow — Torchvision main documentation</title>
+ <title>torchvision.datasets._optical_flow — Torchvision 0.12 documentation</title>
``

Also, currently the drop-down has v.12 as opposed to v0.12 for older versions:

Also, currently the drop-down has v.12

This is from the versions.html file on the gh-pages branch which is manually maintained. Would adding a 0 be sufficient?
-          v.12 (stable release)
+          v0.12 (stable release)


[Storage Common] Storage Retry Policy

blocked by https://github.com/Azure/azure-sdk-for-cpp/issues/407


HDDS-9573. Restore Matomo web analytics from the original website.

Add Matomo analytics to the new Docusaurus site. References are here:
Matomo integration for the original Ozone website with Hugo
Example of integrating Matomo with a Docusaurus site from Apache Superset
Matomo Javascript client documentation
ASF Matomo documentation
I don't think we can test it until the new website is published.

Thanks for checking @dombizita @jojochuang. I verified that local deployments of the site for testing did not register on the main analytics tracking page for the current site. I think they will show up there once the new site is deployed.

Thanks for reviews @dombizita and @jojochuang


Unable to pull private repos from docker hub with swarm 1.2.5

Description
Trying to deploy private images from docker hub using the following:
docker -H :4000 run -d <image>

fails with the error:
time="2016-11-20T12:05:15Z" level=error msg="HTTP error: Error: image <image> not found" status=500
If i'm running the same command on the local engine and not on the swarm manager, it works.
docker run -d <image>

Output of docker version:
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 22:01:48 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 22:01:48 2016
 OS/Arch:      linux/amd64

Output of docker info On one of the managers
Containers: 4
 Running: 1
 Paused: 0
 Stopped: 3
Images: 4
Server Version: 1.12.3
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 18
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null overlay host
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.4.0-47-generic
Operating System: Ubuntu 16.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 7.795 GiB
Name: ip-172-166-14-71
ID: 4WDI:VMYS:PM73:P6DC:2KXS:ZAMC:TTTL:EP5F:CR6N:UABI:ELYM:TPPL
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 20
 Goroutines: 31
 System Time: 2016-11-20T12:19:46.579355598Z
 EventsListeners: 0
Username: razroel
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Output of docker -H :4000 info On one of the managers
Containers: 3
 Running: 1
 Paused: 0
 Stopped: 2
Images: 2
Server Version: swarm/1.2.5
Role: primary
Strategy: spread
Filters: health, port, containerslots, dependency, affinity, constraint
Nodes: 2
 ip-172-166-14-144: <IP_ADDRESS>:2375
  └ ID: 4WDI:VMYS:PM73:P6DC:2KXS:ZAMC:TTTL:EP5F:CR6N:UABI:ELYM:TPPL
  └ Status: Pending
  └ Containers: 4
  └ Reserved CPUs: 0 / 2
  └ Reserved Memory: 0 B / 8.185 GiB
  └ Labels: kernelversion=4.4.0-47-generic, operatingsystem=Ubuntu 16.04.1 LTS, storagedriver=aufs
  └ UpdatedAt: 2016-11-20T12:21:15Z
  └ ServerVersion: 1.12.3
 ip-172-166-14-145: <IP_ADDRESS>:2375
  └ ID: 4WDI:VMYS:PM73:P6DC:2KXS:ZAMC:TTTL:EP5F:CR6N:UABI:ELYM:TPPL
  └ Status: Healthy
  └ Containers: 3 (1 Running, 0 Paused, 2 Stopped)
  └ Reserved CPUs: 0 / 2
  └ Reserved Memory: 0 B / 8.185 GiB
  └ Labels: kernelversion=4.4.0-47-generic, operatingsystem=Ubuntu 16.04.1 LTS, storagedriver=aufs
  └ UpdatedAt: 2016-11-20T12:21:15Z
  └ ServerVersion: 1.12.3
Plugins:
 Volume:
 Network:
Swarm:
 NodeID:
 Is Manager: false
 Node Address:
Security Options:
Kernel Version: 4.4.0-47-generic
Operating System: linux
Architecture: amd64
CPUs: 2
Total Memory: 8.185 GiB
Name: c2555027f29e
Docker Root Dir:
Debug Mode (client): false
Debug Mode (server): false
WARNING: No kernel memory limit support

Additional environment details (AWS, VirtualBox, physical, etc.):
AWS with Ubuntu 16.04

So i just figure it out that I need to pull the image first and than run it.
Is it expected behavior?

This looks to be an issue with swarm could you open this issue in the swarm issue tracker? https://github.com/docker/swarm/issues ?

@thaJeztah Just figure it out that i'm not using swarm mode.
But the same issue with swarm mode.
I'm running
docker pull <image>

and then create a service
docker service create --replicas 5 --name test <image>

but i have only 1 replica running, on the node that pull the image.

For swarm mode, you need to provide --with-registry-auth if the image is private / requires authorization https://docs.docker.com/engine/reference/commandline/service_create/


deferIntercept() not possible since 1.0.0-alpha.1

Since commit 9a7c605 in src/ng1/services.ts, it's impossible to hook into $locationChangeSuccess before ui-router does in the same way that the docs advertise you can.
The commit introduces use of its own location change registry kept in the urlListeners array. This is fine, except the other important change that was made is that the $locationChangeSuccess hook is registered upon the injection of $urlRouter instead of when $urlRouter.listen() is called.
$get.$inject = ['$location', '$browser', '$sniffer', '$rootScope'];
function $get($location, $browser, $sniffer, $rootScope) {
	$rootScope.$on("$locationChangeSuccess", evt => urlListeners.forEach(fn => fn(evt)));
	...
}

Thus, the logic in the function
function getUrlRouterProvider() {
	router.urlRouterProvider["$get"] = function() {
		router.urlRouter.update(true);
		if (!this.interceptDeferred) router.urlRouter.listen();
		return router.urlRouter;
	};
	return router.urlRouterProvider;
}

has no effect, since router.urlRouter has already been created with $get and the $locationChangeSuccess listener has already been registered with the functions in urlListeners.
Basically this means that that the immediate fix to register your own handler like the example in the documentation would be something like this:
.run(function ($rootScope, $injector, UserService) {

  $rootScope.$on('$locationChangeSuccess', function(e) {
    // UserService is an example service for managing user state
    if (UserService.isLoggedIn()) return;

    // Prevent $urlRouter's default handler from firing
    e.preventDefault();

    UserService.handleLogin().then(function() {
      // Once the user has logged in, sync the current URL
      // to the router:
      $injector.invoke(['$urlRouter', function ($urlRouter) { $urlRouter.sync(); }]);
      // ^^ We can inject $urlRouter now that we have the first handle on $locationChangeSuccess
    }
  });

  // Configures $urlRouter's listener *after* your custom listener
  $injector.invoke(['$urlRouter', function ($urlRouter) { $urlRouter.listen(); }]);
});

Obviously, this isn't ideal, but the best solution would be to expose a way of pushing to the urlListeners array at config time. That way custom handlers added then still would run before the handlers that $urlRouter.listen() adds. I wasn't able to find any way to natively do this in the current documentation however.

I've been looking at this issue but can't see the problem.

The onChange listener registry is created early, but the listener isn't registered until listen() is called.
When listen() is called, it adds a single listener to the registry, which delegates to the URL matching code.
The line if (!this.interceptDeferred) router.urlRouter.listen(); avoids calling listen() automatically.
Although the $locationChangeSuccess event handler is indeed registered early, the urlListeners registry should be empty until $urlRouter.listen() is invoked.

This plunk demonstrates deferIntercept() and it seems to work fine: http://plnkr.co/edit/zkwe1gjiRI324t9KT6IS?p=preview
Let me know if this clears anything up, or if there is still a problem with deferIntercept()
I'm closing for now because I don't think this is a bug.


Issue 47356: Rewrite returnURL in the event of a list name change

Rationale
This addresses Issue 47356 by rewriting the returnURL parameters in the event of a name change to a list.
Related Pull Requests

https://github.com/LabKey/testAutomation/pull/1395

Changes

Rewrite the returnURL parameters in the event of a list name change.
Defer processing of a returnURL until after we've resolved whether an explicit returnURL was provided on the URL.

Instead of rewriting return url, should be fix be to fix the list detail url so it uses listid instead of name as param? That's how we handle sample type and data class designers.

I'm not sure which view "list detail" is referring to, however, most list views already support finding lists by "name" or by "listId". The reason this distinction exists for lists is that listId's are unique to a folder. So you could have a list in the top-level folder with ID = 1 and a list in a subfolder with ID = 1. If you were coming from a cross-folder context we would still need to inspect the returnURL to determine which folder it is and then resolve the listId, otherwise, we might return the user to the wrong list. Name, however, is supported cross-folder hence the approach I've taken.
An overall architecture change we could consider is enumerating listIds as unique across the system (like we do for almost all other data structures) as opposed to unique within a container.

Instead of rewriting return url, should be fix be to fix the list detail url so it uses listid instead of name as param? That's how we handle sample type and data class designers.

I'm not sure which view "list detail" is referring to, however, most list views already support finding lists by "name" or by "listId". The reason this distinction exists for lists is that listId's are unique to a folder. So you could have a list in the top-level folder with ID = 1 and a list in a subfolder with ID = 1. If you were coming from a cross-folder context we would still need to inspect the returnURL to determine which folder it is and then resolve the listId, otherwise, we might return the user to the wrong list. Name, however, is supported cross-folder hence the approach I've taken.
An overall architecture change we could consider is enumerating listIds as unique across the system (like we do for almost all other data structures) as opposed to unique within a container.

I see... I didn't realize listId is not unique globaly.


shoots/adminkubeconfig: drop fallback to ShootState

How to categorize this PR?

/area dev-productivity usability
/kind cleanup
What this PR does / why we need it:
Drops the fallback to the ShootState object in the shoots/adminkubeconfig subresource.
Which issue(s) this PR fixes:
Related to https://github.com/gardener/gardener/issues/7999
Follow-up after https://github.com/gardener/gardener/pull/8088
Special notes for your reviewer:
With https://github.com/gardener/gardener/pull/8144 (starting with v1.75.0), the ShootState objects will be deleted for Shoots running on non-managed Seeds.
/cc @rfranzke
Release note:

The `shoots/adminkubeconfig` relies on the `ca-client` `InternalSecret` only and does not use the `ShootState` object anymore.

pls fix unit tests

/retest-required


Simple random number generator written in Nim

From the tests made by good random numbers with not too much work for the CPU. Shortly the example of operation.

i have make a update blink.nim for picostdlib 0.2.7

Your git history is making it hard to merge this, this PR has multiple things unrelated to the actual PR title.


add vouchers package

see how other packages were added
files that must be amended

[ ] composer.json at ^0 version
[ ] tests (docker/envs/phpunit**, phpunit.xml)
[ ] swagger package (config/l5-swagger.php)
[ ] readme

see how other packages were added https://github.com/EscolaLMS/API/pulls?q=is%3Apr+is%3Aclosed

up up


Changing inbound middleware to be composable

Adds new zonal partitioning middleware by default for open-source implementation.

Pull Request Test Coverage Report for Build 018778e3-b128-4929-9109-24f46b47be81

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
137 unchanged lines in 17 files lost coverage.
Overall coverage decreased (-0.02%) to 57.239%

Files with Coverage Reduction
New Missed Lines
%

common/task/fifoTaskScheduler.go
2
87.63%

service/history/handler.go
2
47.28%

service/matching/matcher.go
2
90.29%

common/persistence/serialization/parser.go
4
63.91%

common/persistence/serialization/thrift_decoder.go
4
57.14%

common/types/history.go
4
45.35%

service/history/historyEngine.go
4
68.96%

service/history/task/fetcher.go
4
91.24%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
6
59.55%

common/persistence/statsComputer.go
6
93.57%

Totals

Change from base Build 01877827-f49a-474a-96e9-94c167d9330d:
-0.02%

Covered Lines:
86071

Relevant Lines:
150371

💛  - Coveralls


Add Maltese Sentiment Classification Dataset

Checklist for adding MMTEB dataset

Reason for dataset addition: Cover Maltese in Classification

[x] I have tested that the dataset runs with the mteb package.
[x] I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.

[x] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
[x] intfloat/multilingual-e5-small

[x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
[x] I have considered the size of the dataset and reduced it if it is too big (2048 examples is typically large enough for most tasks)
[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.
[ ] I have added points for my submission to the POINTS.md file.

Thanks for the tip! I went through the folder, and indeed this is the first Maltese one 🎉
One more thing I wasn't sure on is the points for review. I've been using 1pt but docs/mmteb/readme.md is 2 🤔

Thanks for the tip! I went through the folder, and indeed this is the first Maltese one 🎉 One more thing I wasn't sure on is the points for review. I've been using 1pt but docs/mmteb/readme.md is 2 🤔

Oh I've been adding 1 point for myself too 😅. Well it's 2, you can put 2 now and I'll update my score later 🙂

Sounds good. I suppose we count the missing ones later. Let me add 2 for you here.


Module not working with Latest Apache Release and not with latest develop Branch

Module shown blank in browser when below given example is compiled with latest Apache Royale release  0.9.4 in December 2018.
Blank output in browser when below given example is compiled with latest develop branch https://github.com/apache/royale-asjs/tree/develop/
Example :https://github.com/alinakazi/Examples/tree/master/ParentApplication property/HelloWorld
We have final deadline : 10-Jan-2019 . We will demonstrate some of the modules of our Application and those should be fully functional.
MenuBar with XMLList type dataprovider, module loading, grid with customtype Dataprovider, parentApplication property. All these are mandatory to work property.

Is tourdeflexmodules working for you?  It seems to be working for me.

Yes tourdeflexmodules  was working for me with Latest Release.
After copying tourdeflexmodules  build.xml from  latest release  to my example build.xml .
Module is now working fine in my Example.


Provide a link to Logger's API docs.

@eed3si9n suggested this in #315.

@leifwickland I added you to sbt/website's committer, so feel free to update/review/self-merge-after-inactivity things as you see fit.
/cc @dwijnand

Thanks, @eed3si9n.


firrtl_ir: add statements (block, conditionally, connect, empty)

Codecov Report

Merging #20 into master will decrease coverage by 1.91%.
The diff coverage is 57.56%.

@@            Coverage Diff            @@
##           master     #20      +/-   ##
=========================================
- Coverage   72.71%   70.8%   -1.92%
=========================================
  Files          29      36       +7
  Lines         964    1137     +173
=========================================
+ Hits          701     805     +104
- Misses        263     332      +69

Impacted Files
Coverage Δ

py_hcl/firrtl_ir/stmt/def/register.py
0% <0%> (ø)
:arrow_up:

py_hcl/firrtl_ir/stmt/def/node.py
0% <0%> (ø)
:arrow_up:

py_hcl/firrtl_ir/stmt/def/instance.py
0% <0%> (ø)
:arrow_up:

py_hcl/firrtl_ir/stmt/def/circuit.py
0% <0%> (ø)

py_hcl/firrtl_ir/stmt/def/memory.py
0% <0%> (ø)
:arrow_up:

py_hcl/firrtl_ir/stmt/def/wire.py
0% <0%> (ø)
:arrow_up:

py_hcl/firrtl_ir/stmt/def/module.py
0% <0%> (ø)

py_hcl/firrtl_ir/type_checker/expr/accessor.py
88.88% <100%> (ø)

py_hcl/firrtl_ir/type_checker/expr/mux.py
88.46% <100%> (ø)

py_hcl/firrtl_ir/stmt/conditionally.py
100% <100%> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88feb51...70d53b0. Read the comment docs.


Merge ssdk into main

This takes the contents of the ssdk branch and updates it with main so that we can merge all the ssdk changes into main.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Was not planning to squash, but I suppose we could. I'm 0 on it so vote here with reactions


Recent update not in install version

When installing sbibm via pip install sbibm, recent updates like changing sbi.mcmc.mcmc to sbi.samplers.mcmc.mcmc (#59) are not included.

Hi @JuliaLinhart and thanks for reporting this. We will make a new release of sbibm soon (once #54 in merged) that will be included in the installation via pip. In the meantime, you obtain the recent version by cloning the repo, checking out on main and installing locally using pip install -e .

Okay, thanks a lot!

Thanks for reporting, v1.1.0 is now released.


Someone have the pretrained faster-rcnn and caption model？

The link of pretrained model in ./scripts/demo.ipynb seems invalid.

If you check the file history of scripts/demo.ipynb you will see google storage links were previously used. You can still use those, they actually work - they're marked as "requester pays", so you'll have to pay for the bandwidth used to transfer them but it shouldn't amount to much.

@EmilRais

If you check the file history of scripts/demo.ipynb you will see google storage links were previously used.
How to check the history of scripts/demo.ipynb?
Where can I find the history of scripts/demo.ipynb?
can you share me the url to download lstm_scst_iter_1000.caffemodel.h5?

rcnn_weights
https://storage.googleapis.com/bottom-up-attention/resnet101_faster_rcnn_final.caffemodel
With the caption weights there's a choice between
cross-entropy trained
https://storage.googleapis.com/bottom-up-attention/lstm_iter_60000.caffemodel.h5
self-critical trained
https://storage.googleapis.com/bottom-up-attention/lstm_scst_iter_1000.caffemodel.h5

@EmilRais
Thanks for your share
I try to open the url you shared above
https://storage.googleapis.com/bottom-up-attention/lstm_iter_60000.caffemodel.h5
https://storage.googleapis.com/bottom-up-attention/lstm_scst_iter_1000.caffemodel.h5

But both of them can not open

It's a Google Cloud Platform "Requester pays" bucket.
It simply means that you - rather than Pete Anderson - will pay for the bandwidth used to transfer the files.
So the error you're getting doesn't mean that the weights are not downloadable, it just means you're not initiating the download properly. Before you can pay for the download, you need to create a Google Cloud Platform account and add billing details. It's a bit cumbersome but it's not too bad.
Read more about it here https://cloud.google.com/storage/docs/using-requester-pays#using

@EmilRais
sorry to bother you again.
I can not download lstm_scst_iter_1000.caffemodel.h5
But I was very interested in your work.
I think your work is great.
I want to run demo on my new images.
so can you provide any other ways to download lstm_scst_iter_1000.caffemodel.h5?

I uploaded the models to GG drive:
https://drive.google.com/drive/folders/1KT38ZDgoyCFLTcWlcNgEFpyyHCxqdWw9?usp=sharing
Note that there is limit on download quota, so if you encounter error, you can try again in the next day...


conflict with Create React App ESLint version

When I install standard in a repo which also uses Create React App, I get the error below about conflicting versions of ESLint.
my repo is structured like this:
/package.json
    /client/package.json
    /server/package.json

when I add standard at the root level, I will get the eslint error and cannot build the react app.
however, standard is functioning well.
when I add standard into any of the /client or /server directories, it doesn't seem to run, perhaps I could get around this by adding subfolders as new worksspaces as noted in the docs about dealing with mono-repos, but this seems like a hassle.

StandardJS version?

6.8.0

VSCode version?
latest

StandardJS configuration?
basic

What do you have in the OUTPUT panel?
[Info  - 12:24:49 PM] JavaScript Standard Style server is running.
[Info  - 12:24:50 PM] JavaScript Standard Style library loaded from: /Users/dc/dev/rikai/rabbit/server/node_modules/standard/index.js

error message after trying to build with react-scripts build
$ yarn build
yarn run v1.13.0
$ npm run clean && react-scripts build && mv build ../server/public/
npm WARN lifecycle The node binary used for scripts is /var/folders/wl/fsxhspwn0351_lx_55rkwgwc0000gn/T/yarn--1551846013151-0.6910341591898146/node but npm is using /usr/local/bin/node itself. Use the --scripts-prepend-node-path option to include the path for the node binary npm was executed with.

<EMAIL_ADDRESS>clean /Users/dc/dev/rikai/rabbit/client
rm -rf ../server/public/build

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.
The react-scripts package provided by Create React App requires a dependency:
"eslint": "5.12.0"
Don't try to install it manually: your package manager does it automatically.
However, a different version of eslint was detected higher up in the tree:
/Users/dc/dev/rikai/rabbit/node_modules/eslint (version: 5.4.0)
Manually installing incompatible versions is known to cause hard-to-debug issues.
If you would prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.
To fix the dependency tree, try following the steps below in the exact order:

Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
Delete node_modules in your project folder.
Remove "eslint" from dependencies and/or devDependencies in the package.json file in your project folder.
Run npm install or yarn, depending on the package manager you use.

In most cases, this should be enough to fix the problem.
If this has not helped, there are a few other things you can try:

If you used npm, install yarn (http://yarnpkg.com/) and repeat the above steps with it instead.
This may help because npm has known issues with package hoisting which may get resolved in future versions.

Check if /Users/dc/dev/rikai/rabbit/node_modules/eslint is outside your project directory.
For example, you might have accidentally installed something in your home folder.

Try running npm ls eslint in your project folder.
This will tell you which other package (apart from the expected react-scripts) installed eslint.

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.
P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

installing standard globally didn't work either.
in case anyone else has the problem, I was able to get it working with adding client and server as separate folders to the workspace, but now I have a duplicated layout

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.

@dcsan You could try creating a .env in client with below content
SKIP_PREFLIGHT_CHECK=true
Worked for me!!
More details here

By the way — the tracking issue for this for "create-react-app" is https://github.com/facebook/create-react-app/issues/5247 — consider upvoting. The problem of the solution is above is it disables everything when all you want is to ignore this silly eslint-version non-issue.

So if SKIP_PREFLIGHT_CHECK=true is not a solution, but rather a hack, and reusing eslint from react-scripts package is a bad idea, what is that one correct solution to this?

@dcsan You could try creating a .env in client with below content
SKIP_PREFLIGHT_CHECK=true
Worked for me!!

But hasn't this solution cuased any 'hard-to-debug' issue as mentioned below.

Manually installing incompatible versions is known to cause hard-to-debug issues.

Not at all @seong7
It won't create a problem unless we manually install eslint version which is incompatible to Create React App's own eslint version

We've updated the version of ESLint in standard to the latest, so this issue is likely resolved.

https://github.com/expo/expo/issues/22061


Make Docker image Best Practices-Compliant

Unfortunately, this image does not adhere to Best practices as stated in #65. We should rewrite the Dockerfile to adhere to the following directives:

using a user account
Optimizing layers (minimizing layers)

I'm afraid such official image has to set an example like the rest of the Docker Library images.

cc: @nhooyr

There is already an open issue for sudo. Not sure what you mean in terms of minimizing layers, its very minimal already.

if the dockerfile follows the best practices it can run on open shift cluster. now i cannot run it on open shift because it does not allow to be run as root. that's why a 👍 for me

@nhooyr what OS are you building your docker? i get error messages when . building on osx high sierra

I'm on Mojave. What error messages do you get?

This is a tracking issue since I'm already implementing it @nhooyr. The other issue was more on debating on the Docker image's compliancy.

@sr229 I appreciate and admire your initiative but please wait for consensus before implementing things. I don't want to have to reject things after you put your time into them.
Please respond to my question regarding minimizing layers.
Also #65 is the tracking issue for implementing sudo. So unless there is more to minimizing layers, this issue should be closed.

Each RUN and COPY layer is equivalent to 1 layer. Even if we have a small enough image, having many layers does not equal to optimization.
Without  minding the build layer. We can reduce the two RUNs into one RUN to be one layer. Currently we have 4 layers, which can be reduced to 3 layers which could result in faster builds. This is the same concept we're trying to do in Theia/Gitpod @nhooyr

Without minding the build layer. We can reduce the two RUNs into one RUN to be one layer. Currently we have 4 layers, which can be reduced to 3 layers which could result in faster extraction. This is the same concept we're trying to do in Theia/Gitpod @nhooyr

That will make things harder to read as the two RUN instructions are unrelated. Performance is not all that matters. I also doubt this optimization will be user visible as it's very minor. It's unlikely to get approved by me.
So I'm closing this as wontfix.

I don't see why it won't be readable. You're closing the issue because point 2 does not match your specific requirements, point 1 still needs to be done to compensate for clusters where compliancy is a must (OpenShift).
This is arguably biased.

I don't see why it won't be readable. You're closing the issue because point 2 does not match your specific requirements

Because the two instructions are doing different things. The first one installs runtime deps for code-server and the second one generates locales. By separating the instructions, their distinctness becomes clear. A single instruction would not get this across without comments separating them, which is janky. Furthermore, the optimization is very minor and wouldn't affect users.

point 1 still needs to be done to compensate for clusters where compliancy is a must (OpenShift)

That change is still being discussed and no decision has been made and there is already a tracking issue. #65
Furthermore, you're not blocked on it. Its trivial to extend the Dockerfile and add your own user.

This is arguably biased.

Calling me biased does not help your case. Please stick to technical arguments. I am using my best judgement to help guide the development of code-server.

We can reduce the two RUNs into one RUN to be one layer.

Layers are meant to be a single logical change, allowing reuse on rebuild when that layer is not modified, as well as allowing reuse across different containers that do the same thing. This is not possible if unrelated actions are combined into a single layer. That is why a single Dockerfile doesn't translate to a single layer.
Minimizing layer count is good, but the sole point of layers in Docker is lost if they no longer contain only a single logical change each. In such case, each Dockerfile might as well just have been a single layer.

@kennylevinsen While that is true, abusing layers just for this sole reason is why we have too many unoptimized images. Layer counts does not translate to how fast your application can pull and extract, and keeping many changes in one layer versus two is more ideal.
Please do not count layer as one logical change, Layers are counted in the idea there is substantial changes in the FS that will be overlayed. That's not how it works.

Layer counts does not translate to how fast your application can pull and extract

Exactly. One 100MB layer does not pull or extract faster than ten 10MB layers. Make an update, and you'll see that the one layer approach needs to download 90MB more than the ten layer approach (which also wastes storage).

and keeping some changes in one layer versus two is more ideal.

Depends on what you mean by changes. One change, sure, don't split single tasks if there is no reason to do so.
Several changes, no. Fewer layers guarantee waste, where more layers give the possibility of avoiding it.

Please do not count layer as one logical change, Layers are counted in the idea there is substantial changes in the FS that will be overlayed. That's not how it works.

That's exactly how it works, and how docker is designed. There's a reason that docker stubbornly creates a layer for each and every statement—because docker wants you to create many, tiny layers.
Attempting to combine many things into a single layer is simply against the design of docker, and optimizes an irrelevant metric (layer count), at the cost of relevant, limited and sometimes even billed metrics (storage and bandwidth consumption).
(Oh, and just to clarify: I do not consider one logical change to be installing one out of hundreds of dependencies, but rather something like "install base dependencies".)


Error: too many terms in compound SELECT when running redu with more than 500 restic snapshots

When running redu on a restic repo containing more than 500 snapshots, redu does not start but produces an error
(●    ) Getting restic config                                                                                Using cache file "/[REDACTED]/.cache/redu/0f149918ce61c0ab2eaf374de39951d23e5c70c747222be8ebe296350cf4eb5c.db"
 (●    ) Fetching repository snapshot list
Error: too many terms in compound SELECT

Caused by:
    Error code 1: SQL error or missing database

The (hard) limit for compound select is 500 according to https://www.sqlite.org/limits.html and an SQL statement in redu seems to use the number of snapshots in a select statement.
To reproduce, run in an empty directory (if using Linux/Bash):
#!/bin/bash

export PATH=$PWD:$PATH
export RESTIC_PASSWORD="asdf"

if [ ! -e ./restic ]
then
        wget https://github.com/restic/restic/releases/download/v0.17.0/restic_0.17.0_linux_amd64.bz2
        bzip2 -d restic_0.17.0_linux_amd64.bz2
        mv ./restic_0.17.0_linux_amd64 restic
        chmod +x ./restic
        rm ./restic_0.17.0_linux_amd64.bz2
fi

if [ ! -e ./repo ]
then
        restic init --repo ./repo
fi

if [ $(ls -1 ./repo/snapshots | wc -l) -lt 501 ]
then
        for i in {0..501}
        do
                echo "creating snapshot $i"
                restic backup --quiet --exclude repo $PWD --repo ./repo
        done
fi

./redu-0.2.5-linux-x86_64 -r ./repo

Thank you for the report!
This does seem like a problem.
The simplest solution is probably to do the sqlite query for each snapshot separately and not rely on sqlite to combine everything itself.

The entries for each snapshot are in a different table because otherwise insertions get very slow as the table gets bigger.
I've considered just embracing this separation and putting each snapshot on its own file. This would greatly speed up snapshot deletion.

@bottomquark If you want to try it out or do some review there's a fix available on #63 :)

Thanks, checked out the branch and built redu for testing. It now starts and displays data of my 650 snapshots. I am sadly not qualified to do reviews on Rust code, I just can roughly understand what it may be doing ;)

Great, thank you :)


[BUG]Embeddings not showing from brain key

Describe the problem

After installing fiftyone and installing the brain plugin (along with all others)
After launching the app with the coco-2017 dataset (validation split), setting it to persistent=True
Running the "Compute vizualisation" operation from the brain plugin (with the defaults)
Or running the "Apply model" and calculating the embeddings from there, then computing visualizations

The embedding view is just empty after selecting a brain key
Brain info :
Brain key:my_key

Run type:
visualization

Creation time:2024-13-18 15:13:07
FiftyOne version:0.23.8
cls:fiftyone.brain.visualization.UMAPVisualizationConfig
type:visualization
method:umap
embeddings_field:embedding
num_dims:2
num_neighbors:15
metric:euclidean
min_dist:0.1
verbose:True

Screenshots :

Python command output :
(fiftyone-test-py3.10) alan@alan:~/dev/fiftyone_test$ python ./main.py
['activitynet-100', 'activitynet-200', 'bdd100k', 'caltech101', 'caltech256', 'cifar10', 'cifar100', 'cityscapes', 'coco-2014', 'coco-2017', 'fashion-mnist', 'fiw', 'hmdb51', 'imagenet-2012', 'imagenet-sample', 'kinetics-400', 'kinetics-600', 'kinetics-700', 'kinetics-700-2020', 'kitti', 'kitti-multiview', 'lfw', 'mnist', 'open-images-v6', 'open-images-v7', 'places', 'quickstart', 'quickstart-geo', 'quickstart-groups', 'quickstart-video', 'sama-coco', 'ucf101', 'voc-2007', 'voc-2012']
Downloading split 'validation' to '/home/alan/fiftyone/coco-2017/validation' if necessary
Found annotations at '/home/alan/fiftyone/coco-2017/raw/instances_val2017.json'
Images already downloaded
Existing download of split 'validation' is sufficient
Loading existing dataset 'coco-2017'. To reload from disk, either delete the existing dataset or provide a custom `dataset_name` to use
App launched. Point your web browser to http://localhost:5151

Code to reproduce issue
import fiftyone as fo
import fiftyone.zoo as foz

# List available zoo datasets
print(foz.list_zoo_datasets())

#
# Load the COCO-2017 validation split into a FiftyOne dataset
#
# This will download the dataset from the web, if necessary
#
# Give the dataset a new name, and make it persistent so that you can
# work with it in future sessions
dataset = foz.load_zoo_dataset("coco-2017", split="validation", dataset_name="coco-2017", persistent=True)

# Visualize the in the App
session = fo.launch_app(dataset)
session.wait(-1)

System information

OS Platform and Distribution (e.g., Linux Ubuntu 22.04):Linux user 6.5.0-27-generic #28~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Mar 15 10:51:06 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Python version (python --version):Python 3.10.13
FiftyOne version (fiftyone --version):0.23.8 (fiftyone-0.23.8-py3-none-any.whl with hash sha256:378dfa99d5b2dc682e6ed70b71fce6432de1f2576915966b43289f9cd8339b15)
FiftyOne installed from (pip or source): poetry / pip / conda (tried with each one of them independently)

Don't know if these could affect :

Global node version:v20.12.2

Other info/logs
I don't really know how to get python outputs. If you could guide me ?
I tried using the init_logger function from the package and viewing outputs from the web app. But couldn't find anything useful myself...
Don't hesitate to ask for more info if needed.
Willingness to contribute
The FiftyOne Community encourages bug fix contributions. Would you or another
member of your organization be willing to contribute a fix for this bug to the
FiftyOne codebase?

[ ] Yes. I can contribute a fix for this bug independently
[x] Yes. I would be willing to contribute a fix for this bug with guidance
from the FiftyOne community
[ ] No. I cannot contribute a bug fix at this time

Hi @AlanBlanchet. I'm not sure we will be able to reproduce the issue you are seeing without a full script.
Part of the issue may be you are reusing (and not creating a new dataset) noting this output you shared
Loading existing dataset 'coco-2017'. To reload from disk, either delete the existing dataset or provide a custom `dataset_name` to use

To create a new dataset, you can use dataset.clone("cloned-dataset"), or give the zoo dataset a unique dataset_name when using foz.load_zoo_dataset()

Hello and thanks for the reply.
Yes I'm using a dataset from the zoo. But it should be supported in the viewer ? Right ?
I tried to investigate further and managed to get an error from the backend.
The error is simply that we can't dump a numpy array to json when trying to access the API through http://localhost:5151/embeddings/plot.
It returns this error :
Traceback (most recent call last):
  File \"/home/alan/.cache/pypoetry/virtualenvs/fiftyone-test-KI_-E3R8-py3.10/lib/python3.10/site-packages/fiftyone/server/decorators.py\", line 34, in wrapper
    await run_sync_task(lambda: json_util.dumps(response))
  File \"/home/alan/.cache/pypoetry/virtualenvs/fiftyone-test-KI_-E3R8-py3.10/lib/python3.10/site-packages/fiftyone/core/utils.py\", line 2317, in run_sync_task
    return await loop.run_in_executor(_get_sync_task_executor(), func, *args)
  File \"/home/alan/.pyenv/versions/3.10.13/lib/python3.10/concurrent/futures/thread.py\", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File \"/home/alan/.cache/pypoetry/virtualenvs/fiftyone-test-KI_-E3R8-py3.10/lib/python3.10/site-packages/fiftyone/server/decorators.py\", line 34, in <lambda>
    await run_sync_task(lambda: json_util.dumps(response))
  File \"/home/alan/.cache/pypoetry/virtualenvs/fiftyone-test-KI_-E3R8-py3.10/lib/python3.10/site-packages/bson/json_util.py\", line 472, in dumps
    return json.dumps(_json_convert(obj, json_options), *args, **kwargs)
  File \"/home/alan/.pyenv/versions/3.10.13/lib/python3.10/json/__init__.py\", line 231, in dumps
    return _default_encoder.encode(obj)
  File \"/home/alan/.pyenv/versions/3.10.13/lib/python3.10/json/encoder.py\", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File \"/home/alan/.pyenv/versions/3.10.13/lib/python3.10/json/encoder.py\", line 257, in iterencode
    return _iterencode(o, 0)
  File \"/home/alan/.pyenv/versions/3.10.13/lib/python3.10/json/encoder.py\", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type float32 is not JSON serializable

I haven't had time to investigate why but :

I made a github repo to reproduce the issue
I also made a youtube video showing how I ran the env

I don't really know how data flows back to the frontend but I guess a fix would be to add a .tolist() if the data is an instance of np.array. I just don't know where...

Hi,
Iam encountering the same issue. For UMAP and TSNE no visualizations are shown when using the brain plugins.. I noticed though that PCA works.
regards,
M

This may be a caching issue. Running the reload_dataset operator may resolve the issue when encountered
https://github.com/voxel51/fiftyone/assets/19821840/0aa3a63d-f046-4eea-b038-ec3719fb6f21

Hi Benjamin and thanks for the reply!
Unfortunately not. Reloading the dataset does not help.
Kind regards,
M

I confirm that reloading the dataset doesn't help.
For PCA which works I'm also not able to colorby the ground_truth label. Don't know if it's a distinct bug or if it is linked.

I confirm that reloading the dataset doesn't help. For PCA which works I'm also not able to colorby the ground_truth label. Don't know if it's a distinct bug or if it is linked.

That is a separate issue likely. I have created #4324 which should resolve the original issue report

Awesome, thanks Benjamin!


add support for Tilt Pro hydrometers

This PR adds support for Tilt Pro Hydrometers. They provide one more decimal for gravity and temperature.
Got the logic from the Tilt mobile app (see https://github.com/baronbrew/Tilt-Hydrometer-Framework7/blob/master/www/js/app.js)

Awesome, thank you so much!


Fails to accept offer with two networks setup.

I'm currently working with the asker, anoncreds, and indy vdr modules as documented in the official guides with version 0.4.0-alpha.120. Indy vdr is working with two networks - 'bcovrin:test' and 'idunion'. However, I've encountered an issue when I try to accept an offer from the 'idunion' network.
Here is the debug log when the issue arises:
DEBUG: No credential record found for offer, creating a new one
DEBUG: Processing anoncreds credential offer for credential record 6158974b-460b-410d-81f0-b2be115f6d35
DEBUG: Saving credential record and emit offer-received event
DEBUG: Got a credentialProtocol object for this version; version = v2
DEBUG: Getting credential definition 'did:indy:idunion:HAqR4zXKG7d4L7BQhycnGC/anoncreds/v0/CLAIM_DEF/50281/super-cool-tag' from ledger 'idunion'
DEBUG: Getting transaction with seqNo '50281' from ledger 'bcovrin:test'
ERROR: Could not get schema from ledger for seq no 50281'
ERROR: Error retrieving credential definition 'did:indy:idunion:HAqR4zXKG7d4L7BQhycnGC/anoncreds/v0/CLAIM_DEF/50281/super-cool-tag'

here are the ids from offerCredential methods response:
          "metadata": {
            "_anoncreds/credential": {
                "schemaId": "did:indy:idunion:HAqR4zXKG7d4L7BQhycnGC/anoncreds/v0/SCHEMA/name schema test/1.0.1",
                "credentialDefinitionId": "did:indy:idunion:HAqR4zXKG7d4L7BQhycnGC/anoncreds/v0/CLAIM_DEF/50281/super-cool-tag"
            }
        },

When I operate with a single network, I do not experience this issue and am able to accept offers from both ledgers successfully.
I would appreciate any guidance on resolving this issue or any possible workarounds.

sure, networks look like this
[
    {
      "id": "BCOVRIN_TEST",
      "genesisTransactions": genfile
      "indyNamespace": "bcovrin:test",
      "isProduction": false,
      "connectOnStartup": true
    },
    {
      "id": "IDUNION",
      "genesisTransactions": genfine
      "indyNamespace": "idunion",
      "isProduction": false,
      "connectOnStartup": true
    }
  ]

modules look like this
 {
  connections: new ConnectionsModule({
    autoAcceptConnections: true,
  }),
  credentials: new CredentialsModule({
    autoAcceptCredentials: AutoAcceptCredential.ContentApproved,
    credentialProtocols: [
      new V2CredentialProtocol({
        credentialFormats: [new AnonCredsCredentialFormatService()],
      }),
    ],
  }),
  proofs: new ProofsModule({
    autoAcceptProofs: AutoAcceptProof.ContentApproved,
    proofProtocols: [
      new V2ProofProtocol({
        proofFormats: [new AnonCredsProofFormatService()],
      }),
    ],
  }),
  anoncreds: new AnonCredsModule({
    registries: [new IndyVdrAnonCredsRegistry()],
  }),
  anoncredsRs: new AnonCredsRsModule({
    anoncreds,
  }),
  indyVdr: new IndyVdrModule({
    indyVdr,
    networks,
  }),
  dids: new DidsModule({
    registrars: [new IndyVdrIndyDidRegistrar()],
    resolvers: [new IndyVdrIndyDidResolver()],
  }),
  askar: new AskarModule({
    ariesAskar,
  }),
}

I've tried reproducing the issue but wasn't succesfull. See my attempt here: https://github.com/TimoGlastra/aries-framework-javascript-example/tree/multi-ledger-issue
Can you create a reproduciton that I can run?

Closing as a lot has changed. If the issue still persists with latest 0.5.0 alphla, node 18/20 and 0.2.0 of the shared components, please open a new issue. Thanks!