compiled css precedence

When a project is compiled, the precedence of applied CSS rules changes.

[X] This is not a v0.x issue.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
.MuiDialogActions-spacing > * + * {
    margin-left: 8px;
}

... other styles ...

.MuiButtonBase-root {
    color: inherit;
    border: 0;
    margin: 0;
    cursor: pointer;
    display: inline-flex;
    outline: none;
    padding: 0;
    position: relative;
    align-items: center;
    user-select: none;
    border-radius: 0;
    vertical-align: middle;
    justify-content: center;
    -moz-appearance: none;
    text-decoration: none;
    background-color: transparent;
    -webkit-appearance: none;
    -webkit-tap-highlight-color: transparent;
}

Current Behavior 😯
.MuiButtonBase-root {
    color: inherit;
    border: 0;
    margin: 0;
    cursor: pointer;
    display: inline-flex;
    outline: none;
    padding: 0;
    position: relative;
    align-items: center;
    user-select: none;
    border-radius: 0;
    vertical-align: middle;
    justify-content: center;
    -moz-appearance: none;
    text-decoration: none;
    background-color: transparent;
    -webkit-appearance: none;
    -webkit-tap-highlight-color: transparent;
}

... other styles ...

.MuiDialogActions-spacing > * + * {
    margin-left: 8px;
}

Steps to Reproduce 🕹

Run a demo of Dialog on localhost to see the expected behavior
Compile the demo and run to see the marginLeft of MuiDialogActions is overridden by margin of MuiButtonBase

Your Environment 🌎

Tech
Version

Material-UI
v4.1.3

React
v16.8.6

Browser
Chrome

@Luucky Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@oliviertassinari Here's a link for the DEV EXAMPLE: https://codesandbox.io/embed/create-react-app-36pid
And here's a production build link: https://csb-36pid.netlify.com/
Notice how space between buttons disappears. The margin of ButtonBase overrides the DialogActions left of margin.

The CSS specificity of .x > * + * is 1 then we rely on
import '../Button'; // So we don't have any override priority issue.

to get the CSS injection order right.
The alternative is to increase the specificity to 2. I like this idea, it would make use component agnostic (work with everybody, not just our Button)
diff --git a/packages/material-ui/src/CardActions/CardActions.js b/packages/material-ui/src/CardActions/CardActions.js
index ee57f0120..91b7c574a 100644
--- a/packages/material-ui/src/CardActions/CardActions.js
+++ b/packages/material-ui/src/CardActions/CardActions.js
@@ -2,7 +2,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import clsx from 'clsx';
 import withStyles from '../styles/withStyles';
-import '../Button'; // So we don't have any override priority issue.

 export const styles = {
   /* Styles applied to the root element. */
@@ -13,7 +12,7 @@ export const styles = {
   },
   /* Styles applied to the root element if `disableSpacing={false}`. */
   spacing: {
-    '& > * + *': {
+    '& > :not(:first-child)': {
       marginLeft: 8,
     },
   },
diff --git a/packages/material-ui/src/DialogActions/DialogActions.js b/packages/material-ui/src/DialogActions/DialogActions.js
index 6fb342f5c..458c61350 100644
--- a/packages/material-ui/src/DialogActions/DialogActions.js
+++ b/packages/material-ui/src/DialogActions/DialogActions.js
@@ -2,7 +2,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import clsx from 'clsx';
 import withStyles from '../styles/withStyles';
-import '../Button'; // So we don't have any override priority issue.

 export const styles = {
   /* Styles applied to the root element. */
@@ -15,7 +14,7 @@ export const styles = {
   },
   /* Styles applied to the root element if `disableSpacing={false}`. */
   spacing: {
-    '& > * + *': {
+    '& > :not(:first-child)': {
       marginLeft: 8,
     },
   },
diff --git a/packages/material-ui/src/ExpansionPanelActions/ExpansionPanelActions.js b/packages/material-ui/src/ExpansionPanelActions/ExpansionPanelActions.js
index 5451c6387..2e3f9f179 100644
--- a/packages/material-ui/src/ExpansionPanelActions/ExpansionPanelActions.js
+++ b/packages/material-ui/src/ExpansionPanelActions/ExpansionPanelActions.js
@@ -2,7 +2,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import clsx from 'clsx';
 import withStyles from '../styles/withStyles';
-import '../Button'; // So we don't have any override priority issue.

 export const styles = {
   /* Styles applied to the root element. */
@@ -14,7 +13,7 @@ export const styles = {
   },
   /* Styles applied to the root element if `disableSpacing={false}`. */
   spacing: {
-    '& > * + *': {
+    '& > :not(:first-child)': {
       marginLeft: 8,
     },
   },

cc @eps1lon as you were advocating for removing the import (tree-shaking)
cc @NMinhNguyen as you were wondering about it
@Luucky I can't explain the behavior of the deployment. Something is wrong in the bundling pipeline independently from my previous comment about CSS specificity. I can reproduce the problem with our CRA and Next.js examples.

I also had a similar thing happen when I tried the following:
<List>
       <ListItem button component={Box} border={1}>
               Click this item
       </ListItem>
</List>

ButtonBase would reset my border also after deployment.

@Luucky This one sounds expected. Unless you control the import order, the CSS win is unpredictable.

i have the same issue with @Luucky

I'm running into an issue that may be related.  If not, I will open another issue.
When building my react app in production mode ($ npm run build) the order of the MUI style elements is getting mixed up with my own jss style elements.  However, if I run it in development ($ npm start) everything is as expected.  This is project is using 4.2.0.  I have a similar project that is using 3.9.1 and it works the same both production/dev (i.e. correctly as I would expect).
it seems the production mode is the issue, but I do not know where to begin looking.

@nickpalmer this symptom might hide another issue.

@oliviertassinari After further investigation we have the exact same problem on our staging environment, we just never noticed. It thus has nothing to do with hydrate and everything to do with how create-react-app is compiling things for production.

Fixed similar behaviour with webpack setting sideEffects to false, which is enabled in production mode by default.
module.exports = {
  //...
  optimization: {
    sideEffects: false
  }
};

https://webpack.js.org/configuration/optimization/#optimizationsideeffects

I can confirm that this resolves the issue.

@nickpalmer final build getting bigger btw.

it works correctly if we disable SSR. in case of SSR styles are picked from server css file.

While I can no longer reproduce the issue on Codesandbox, CRA and Next.js, I would propose that we move forward with https://github.com/mui-org/material-ui/issues/16609#issuecomment-511764782 so we can:

Be invariant to custom margins people might implement on the button
Maximize tree-shaking in people code that doesn't use a button in the actions
Help people that have buggy tree-shaking env and that don't use our recommended tree-shaking plugin.

Not sure if this is the same issue, let me know if I should open a new one.
I have TextField and I'm adding styling to it using the useStyles hook like so:
const useStyles = makeStyles({
  input: { display: 'block' }
}

const MyComp = () => {
  const classes = useStyles()

  return (<TextField className={ classes.input } /> )
}

This produces locally the class .makeStyles-field-216 which takes precedence over .MuiFormControl-root that has display: 'inline-flex'.
However, when built and run in production, the generated class is .jss253, and .MuiFormControl-root has precedence over it, and breaks the layout.
Thanks!

I'm running into an issue that may be related. If not, I will open another issue.
When building my react app in production mode ($ npm run build) the order of the MUI style elements is getting mixed up with my own jss style elements. However, if I run it in development ($ npm start) everything is as expected. This is project is using 4.2.0. I have a similar project that is using 3.9.1 and it works the same both production/dev (i.e. correctly as I would expect).
it seems the production mode is the issue, but I do not know where to begin looking.

I have this exact same problem.

We also have the same problem using version 4.3.3. The workaround provided by @alexandrecanuto helped.
It seems like jss.createStyleSheet is inserting new styles always at last when all have same index. If then a MUI component is rendered after makeStyles the order gets wrong. For me it looks like an issue with webpack optimization and jss in production mode vs development mode
Question: Why is this not set to 1 by default for makeStyles? Would this not help in future?

Had the same issue with Chip Avatar.
In local development it looks like this:

In our staging environment it looks like this:

Using version 4.5.1. Will give the solution provided by @alexandrecanuto a try though.

Running into the same issue on 4.5.0 - we're not using SSR. Just a typical CRA. We have a shared export const useGlobalStyles = makeStyles(theme => ({ ... })); file we use, and I'm noticing when these are imported using the const globalClasses = useGlobalStyles(); hook and applied with className, they are being stomped on by MUI styles.
In the image example below, the element is used like this:
<Grid container spacing={2} className={globalClasses.gridContainer}>
I would expect the .makeStyles-gridContainer-241 class styles to be more important than the MuiGrid-spacing-xs-2, but that's not the case.

This was working just a few days ago. We're seeing this even when running on localhost during development.

Is there any movement on this? I'm getting more and more areas where I'm having to use !important, which is less than ideal.

@Kizmar We would be happy to accept a pull request for https://github.com/mui-org/material-ui/issues/16609#issuecomment-511764782.

Having the same issue as in https://github.com/mui-org/material-ui/issues/16609#issuecomment-517062719 - i.e. Dev != Prod
A copy-paste:
/* Dev: */
.MuiCardHeader-root {
￼    display: flex;
￼    padding: 16px;
￼    align-items: center;
}
.makeStyles-statusBarOk-276 {
    color: #fff;
    background: #4e698c;
    padding-top: 8px;
    padding-bottom: 8px;
}

/* Prod: */
.jss276 {
￼    color: #fff;
￼    background: #4e698c;
￼    padding-top: 8px;
￼    padding-bottom: 8px;
}
.MuiCardHeader-root {
    display: flex;
    padding: 16px;
    align-items: center;
}

So the style 276 gets wrong priority.
Materisl UI 4.2.0

I updated to MUI 4.6.0 and tested css priority by replacing -${theme.spacing(1)}px !important with just theme.spacing(1), and it's still being stompted on by MUI styles. mentioned here
I've reviewed #18238, #18156, & #16374 and I'm unsure of what the proposed solution is in my case.

on 4.9.5 and started seeing this in the last week

@kelly-tock @razvanmandache could you please provide a repro?

https://github.com/mui-org/material-ui/issues/16609#issuecomment-528325054
seems to have fixed it for us.

had this issue in storybookjs as well, and the optimization fix from above fixed it there as well.

@kelly-tock it’s great that you’ve found a workaround but ideally it would be good to get more insight into the issue so that the rest of the community doesn’t have to resort to turning optimisations off.

I will give it a shot. I can very easily try and see if it was also happening before 4.9.5 as we just upgraded to that

Having a similar issue onn version 4.9.14 (currently latest) the Box component with clone attribute only overrides the child's styles on develop mode.
Code:
// import condition matters!
import { Box, Card } from '@material-ui/core';

const ConnectedApp = () => {
  return (
    <Box clone bgcolor="primary.light">
      <Card>Foo</Card>
    </Box>
  );
};

Dev Output:

Foo

Prod Output:

Foo

This issue also appears when using Drawer component and parceljs tree-shaking. The ordering of CSS is totally random.

I have been struggling over this for a week, I even opened a stackoverflow issue: https://stackoverflow.com/questions/66229956/material-ui-production-build-generate-different-styles-order-definition-than-in
I am experiencing this bug with the latest material-ui version available, 4.11.3 and parceljs tree-shaking.
Is there any hope of resolution? Or should I just loose 2Mb JS optimization by disabling tree-shaking?
If so, a nice first step would be to update the docs: https://material-ui.com/guides/minimizing-bundle-size/#when-and-how-to-use-tree-shaking "Tree-shaking of Material-UI works out of the box in modern frameworks" => False :/
This issue is closed, it is possible to open a new one?
If necessary I can help investigate, but it is not clear to me why this is happening. What Material-ui is doing that causes in production mode the generated CSS to be in a random order? Any lead would be great.

@amanteaux Maybe you could try v5? We are changing the styling solution to emotion/styled-components.

@oliviertassinari Thank you for your quick reply! I will test the v5 tomorrow, I will let you know!

@oliviertassinari I just finished the upgrade and I confirm that it is now working as excepted with the v5. Thank you a lot for your help :)

v4.11.2, I run into the same issue. it's working properly on dev mode but on production mode

I tried all possible approaches mentioned above but still not working.
just trying with v5 but I'm not pretty sure if any other incompatible issues would happen unexpectedly with this upgrade.
Looking forward to hearing your suggestion @oliviertassinari

it's really happened some minor broken styles on the other parts of other pages due to the migration to v5.
as we're about to release the project, I'm gonna rollback to v4.11.2.
import React from 'react';
import { makeStyles, withStyles } from '@material-ui/core/styles';
import Tabs from '@material-ui/core/Tabs';
import Tab from '@material-ui/core/Tab';

const QTabs = withStyles({
  root: {
    backgroundColor: '#272727',
    minHeight: '100px',
    display: 'flex',
    alignItems: 'center',
    '& > button:focus': {
      outline: 0,
      border: 0
    }
  },
  indicator: {
    display: 'flex',
    justifyContent: 'center',
    backgroundColor: '#308ab4',
    // '& > span': {
    //   maxWidth: 40,
    //   width: '100%',
    //   backgroundColor: '#308ab4',
    // },
  },
})(Tabs);

I tried with v5, it's still same

same problem here


Add docs for skip_clone

Depends-On: #516

I adjusted the table layout here, which targets this branch: #516


feat: support fully customized toasts #53

Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add support for fully customized toast notifications, enabling custom SVG icons, color customization, and the ability to disable auto-hide. Update documentation to reflect these new customization options.
New Features:

Introduce support for fully customized toast notifications, allowing users to pass custom SVGs, recolor notifications, and disable auto-hide behavior.

Enhancements:

Refactor toast component to handle custom SVG icons and improve the handling of toast visibility and auto-hide functionality.

Documentation:

Update documentation to include instructions on customizing toast notifications, including using custom SVGs, recoloring, and disabling auto-hide.

@sourcery-ai review

@sourcery-ai review

Running a build:release causes the index.min.js and api.min.js causes the initExamples function export to be removed, therefore breaking the examples on the demo pages.

This has been resolved.

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[4.0][Improvement] Add max_image_size to image field type

This field enables validation of the max image size allowed on Javascript's end, without the need to post it to the PHP server.

Totally. Thank you @mauricioPisabarro , just merged it into the v4 branch. I've just added one thing: the default is now ini_get('upload_max_filesize') instead of -1.
I think this strikes a good balance:

it will make it impossible to get the error you got
it still allows developer to change the allowed file size to something bigger or smaller

Thanks again for the PR.
Cheers!


NVSHAS-9440: support separate network mode and Process and File mode …

…in CRD

I reviewed the PR and had discussion with william, approve this PR


Error: schema is invalid

When using an array as configuration for rules like content-type, disown-opener, highest-available-document-mode, ... the parsing of the configuration fails. I figured out that this is caused by the schema property of their meta object. It always contains a line like this: type: ['object', null]. When changed to type: ['object', 'null'] all seems to work fine again.

Please tell us about your:
Environment

sonarwhal version: 1.5.0
Node.js version: 9.11.1
npm version: 5.8.0

sonarwhal configuration

sonarwhal’s configuration

// ...
"content-type": ["error", {
    ".*\\.js": "application/javascript; charset=utf-8"
}],
// ...

URL for which sonarwhal failed

URL: any

Output
Please include the raw output generated by sonarwhal, or if possible,
the raw output from running sonarwhal in debug mode: sonarwhal --debug <URL>.

sonarwhal’s raw output

Error: schema is invalid: data.type should be equal to one of the allowed values, data.type[1] should be equal to one of the allowed values, data.type should match some schema in anyOf

@chrisguttandin Thanks for opening this issue and letting us know about this!

When changed to type: ['object', 'null'] all seems to work fine again.

Yes, it should be 'null',  not null.
Ref:

http://json-schema.org/latest/json-schema-core.html#rfc.section.4.2.1
https://spacetelescope.github.io/understanding-json-schema/reference/null.html

@chrisguttandin Things should be fixed and published! 🎉

Thanks @alrra for the quick response.


Create room model

Create model file:
title: CharField, max=128
Once finished, please cross the issue off in list stored at #1 Create initial DB models and migrations

andynet: I'm working on this

done in https://github.com/pyconsk/django-konfera/pull/27 close it

@andynet @ZoltanOnody thank you guys, closing the issue.


Upgrade specter which had breaking API changes

I use the latest specter and midje (which pulls in suchwow). They don't play nice anymore. Can suchwow upgrade the dependency?
Would only need to change the two specter/transform calls:
https://github.com/marick/suchwow/blob/66623d6e16a12906197d5994bcfc7d637a355c03/src/such/readable.clj#L175
to com.rpl.specter.macros/transform.

Working on this.

Fixed in 5.1.3 - and structural typing 2.0.3 - and Midje 1.9.0-alpha2


[WIP] Config Aliases

Adds support for config aliasing.
Config::package('winter.test', '/path/to/config');
Config::registerNamespaceAlias('winter.test', 'winter.alias');

Config::get('winter.test::foo'); // bar
Config::get('winter.alias::foo'); // bar

Does this work with loading config from the alias location? I.e. if config/rainlab/blog/config.php exists and config/winter/blog/config.php doesn't, we want to make sure both rainlab.blog::item and winter.blog::item loads from config/rainlab/blog/config

We would handle that during plugin registration. However specifically with replaced plugins (at least with lang) we assume that the plugin is a fork and we don't provide fallback support to the original plugins files.
If there is a good reason for the replacing plugin to fallback to the original plugins config (if exists) if the replacing plugin does not include a config then we can handle this, but we'd do it during plugin registration (same place as we handle lang namespace aliasing).
I guess the question is do we want to handle it like the translator or do we want provide fallback support?
Either way, the code in storm should stay the same but we'll change how we use the registerNamespaceAlias in winter.

While it would technically be better to have both have full fallback support for the original plugin's overrides, the consequences of not having that support for overridden translations are much less than the consequences of not having that support for overridden config values; which could theoretically compromise the stability or security of the project if they don't update those config files properly when switching plugins.
All that to say, if it can be done in the system module instead then I'm fine with that, although I don't think we need to put any work into supporting the same logic for the translator; unless it's super easy to do and doesn't have any negative effects.

@LukeTowers, @jaxwilko was referring to the plugin's default lang/config files... not the overrides under the app's lang or config folders. He's working at adding this, we all agree this is required if we want to seamlessly support migration to winter's rebranded plugins.

Gotcha. There's definitely no expectation from me to look at plugins/rainlab/blog/config when rainlab.blog is aliased to winter/blog.

To document the final additions of this PR, 2 new methods have been added to Repository which is access as Config inside Winter.

registerNamespaceAlias

Config::registerNamespaceAlias('winter.demo', 'alias.demo');

Will redirect all calls to alias.demo to winter.demo.
I.e.
<?php
// plugins/winter/demo/config/config.php
return [
    'foo' => 'bar'

config('alias.demo::foo'); returns bar

registerPackageFallback

Config::registerPackageFallback('winter.demo', 'alias.demo');

This will add the global override for alias.demo to the winter.demo namespace if there is a global config for alias.demo and not for winter.demo.


Update caching of identities

Create a class to interact with People Chain to cache identities.

https://github.com/ChaosDAO-org/InternalGov-2.0/pull/41


fix(learn): fixed typo "in the left" should be "at the left"

Checklist:

[ x] I have read freeCodeCamp's contribution guidelines.
[ x] My pull request has a descriptive title (not a vague title like Update index.md)
[ x] My pull request targets the master branch of freeCodeCamp.
[ x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

Thank you! I will keep the branch naming in mind for next time 👍


Bug fix

cc/ @exogen
fixes the style scope for tickLabels and axisLabels.  Adds support for passing an array of display values in for tickFormat.

index change looks good! :+1:


kitex architecture diagram

#76

@YangruiEmma @GuangmingLuo

Thanks~ I approve it, but it may be updated later ;)
And please add it to the same page of English.

Please remove the part of 'kitex-byted'
Add it to the en doc as well


Carthage is not using the cache on Travis at each build stage

Hi! I noticed each build stage on Travis was rebuilding every dependency on Cartfile from scratch, leading each build stage to take around 25 minutes in my framework.
I was outdated myself with the integration between Carthage and Travis, but then I found that it is already possible to use the cache successfully: https://github.com/travis-ci/travis-ci/issues/6348
Notice that what's suggested there is very close to what we have in this template, the only difference being that they run the Carthage command before_install rather than before_script. I made that change and it worked great for me - ~it takes around 5 minutes now~.
edit: I must say my 2 first build stages took around 5 minutes, but the 3rd one is rebuilding all dependencies again. Maybe because yesterday I cancelled after the first 2 and it is creating individual caches per stage?
While this was a great improvement for my case, I don't know what were the reasons behind doing it on before_script, so I'm not sure if moving to before_install will be a good change. Let me know if I can open a PR!
Thanks! :D

If your repository is public, can you post the link to the travis-job. I will need to investigate more into this but if you think it will improve timings, then I am happy to review your PR.
Thanks

@gobetti Cache seems to work fine with a library which was created with this template - https://travis-ci.org/Restofire/Restofire/jobs/378606026 (line 2900-2902).  So I think, It creates individual cache per stage.

Sure! Here is build #1: https://travis-ci.org/gobetti/RxCocoaNetworking/builds/384253067
I would expect it to build all Carthage dependencies on #1.1 only but then #1.2 did it too and #1.3 was also doing it when I cancelled the build.
Then I made that change I mentioned in the OP and started build #2: https://travis-ci.org/gobetti/RxCocoaNetworking/builds/384426851
This time, both #2.1 and #2.2 seemed to reuse correctly the cache from build #1, but #2.3 started to build the Carthage dependencies and I cancelled it.
I see you closed this issue because we share the belief that the cache is done per stage instead of per build, but isn't there a way to have it per build? Otherwise, even though a stage is only meant for iOS, it will build tvOS, macOS, watchOS... and everything again in the next stage.

I'll test https://docs.travis-ci.com/user/build-stages/warm-cache/ and let you know

Yes, For the first run, it takes a lot longer than expected and it reduces to 4 secs from next builds. It would be great to even reduce the time on the first run. I will investigate a little more but will give this less priority over others.
I really appreciate your help and I am happy to review if you get a solution.

Circle ci is also good but it is not free for macOS containers and I don't see this as a big issue right now as all the subsequent builds use caches and time is decreased drastically. It's not something to invest a lot of time at.
Closing it for now 👍🏻. Thanks

It's fine to keep it closed, I think we'll be able to do something about it once https://github.com/travis-ci/travis-build/pull/1265 is merged


[BUG] Trying to upsert docs (json, tct, csv, document stores) fails leads to unhealthy server

hey i am trying to upsert a document to pinecone and no matter what i do it always fails, sometimes it "succeeds" and tells me 0 vectors have been uploaded, or the whole flowise server just crashes. i tried different filetypes, different setups (classic / llamaindex) and dont know what to do anymore.

this is the error message i get:
     502         502   Bad Gateway    Request ID: 888dfdfa605b65b9-FRA   This service is currently unavailable. Please try again in a few minutes.   If you are the site owner, refer to  Render’s documentation for troubleshooting.      Powered by

ok file size was too big


:VimLatexCompileToggle followed by :VimLatexView opens yet another mupdf window

If mupdf is used as a viewer, then
:VimLatexCompileToggle | VimLatexView<cr>
opens two mupdf windows and only the last is synced (by synctex).
Can you verify that?
It works fine if VimLatexRSearch is used instead of VimLatexView.
The the window is synced and VimLatexView afterwards does not open a new instance.

Closing for now as suddenly disapeareed.

The mupdf window ID is retrieved after the first callback when VimLatexCompileToggle has been issued. If the compilation is not successful or for some reason does not create a pdf, then this callback will not be able to set an ID. Latexmk will still open the pdf when the pdf becomes available, without setting the ID. This particular problem is a little bit difficult to fix, at least I don't see a good solution.
So the issue here is reproducible in some cases, but I don't know how to improve the system as of yet.

Hmm.. now, when trying to open mupdf such that it syncs to Vim, I need to open it three times and close the two previously openend mupdf windows.
Perhaps adding a second of sleep before catching the mupdf ID, as before, could aleviate this problem?

I've actually removed the sleep. I did that at the same time as I moved the entire mupdf ID catching code to the callback function, which should not need the sleep. In addition, the sleep made vim unresponsive, since vim is not asynchronuous.
However, since the ID catcher is now in the callback, a sleep should not interfere with vim directly. You could check if your problem is fixed by adding a sleep above line 95 in latexmk.vim. It does not really feel like a good fix, though.


Trying to integrate with Asterisk EAGI

Hello
I am trying to use this library to listen for commands over the telephone using Asterisk (Virtual PBX)
The idea is to the user call a number and speaks commands, I would use this library to "understand" those commands
Asterisk can execute an external program and pass it the raw sound using EAGI, it uses file descriptor 3 to output the raw sound, but when I run this code under Asterisk it never pass the
"with sr.AudioFile(afile) as source:" looks like it enters and never leaves and no exception is thrown.
Here is the code
import speech_recognition as sr
from asterisk.agi import *
import os

agi = AGI()

# instance recognizer
r = sr.Recognizer()

# file descriptor
FD=3

# audio file
afile=os.fdopen(FD, 'rb')

try:
    with sr.AudioFile(afile) as source:
        audio = r.listen(source,3)
except Exception, e :
    agi.exec_command("NOOP","'Error_%s'"%str(e))

The asterisk documentation says it generates
( audio pipe: Linear pcm audio pipe ) on file descriptor 3
I am new to speech recognition so sorry if it is a stupid question.
Thanks

I found that the program is actually reading from the file descriptor I attached a strace to the process and can see the reads and when I speak I see reading data
read(3, "\0\0\0\0\10\0\10\0\0\0\0\0\0\0\0\0\0\0\370\377\370\377\0\0\0\0\0\0\10\0\0\0"..., 4096) = 320
read(3, "\10\0\10\0\0\0\370\377\0\0\370\377\370\377\360\377\360\377\370\377\370\377\370\377\370\377\0\0\0\0\370\377"..., 4096) = 320
read(3, "\370\377\370\377\370\377\370\377\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\370\377\0\0\0\0"..., 4096) = 320
read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\370\377\360\377"..., 4096) = 320
read(3, "\350\377\360\377\370\377\370\377\370\377\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 320

Looks like it is not able to detect when it should stop.
I tried to change the energy threshold to 150 and to 450 but nothing changed
r.energy_threshold = 150

Debugging the code I see it enter on line 185 and never leaves
                    flac_data = self.filename_or_fileobject.read()

Hi @bonadio,
I read up on the EAGI spec a bit; it seems like its input file descriptor is an infinite stream, having no EOF markers.
This library doesn't support raw PCM audio streams directly. However, we can implement it separately:
import speech_recognition as sr
from asterisk.agi import *
import os
agi = AGI()
r = sr.Recognizer()

SAMPLE_WIDTH, SAMPLE_RATE = 2.0, 18000.0 # 16-bit, 48kHz PCM audio

class AudioRawStream(sr.AudioSource):
    def __init__(self, file_object, sample_width, sample_rate, channels = 1, little_endian = True):
        assert hasattr(filename_or_fileobject, "read"), "``file_object`` must be a file-like object"
        self.file_object = file_object
        self.SAMPLE_WIDTH = channels
        self.SAMPLE_RATE = sample_rate
        self.CHUNK = 4096
        self.channels = channels
        self.little_endian = little_endian
        self.stream = None

    def __enter__(self):
        audio_raw_reader = AudioRawStream.AudioRawReader(self.file_object, self.SAMPLE_WIDTH, self.channels)
        self.stream = AudioFile.AudioFileStream(audio_raw_reader, self.little_endian)

    def __exit__(self):
        self.stream = None

    class AudioRawReader(object):
        def __init__(self, file_object, sample_width, channels):
            self.file_object = file_object
            self.sample_width = channels
            self.channels = channels
        def readframes(self, frames): return self.file_object.read(frames * self.sample_width)
        def getnframes(self): raise ValueError("Frame count unsupported - the length of the raw audio is unknown and potentially unbounded.")
        def getsampwidth(self): return self.sample_width
        def getnchannels(self): return self.channels

afile = os.fdopen(3, 'rb')
with AudioRawStream(afile, SAMPLE_WIDTH, SAMPLE_RATE) as source:
    audio = r.listen(source,3)

hi @Uberi ,
iam trying to use Snowboy with your EAGI fix for Asterisk , seems to have couple issues (dont know very well python):
 SAMPLE_WIDTH, SAMPLE_RATE = 2.0, 18000.0 # 16-bit, 48kHz PCM audio
should not be SAMPLE_RATE=48000 ?
next ,
this line:
assert hasattr(filename_or_fileobject, "read"), "file_object must be a file-like object"
gives me : ``file_object`` must be a file-like object
so i have changed it into:
assert hasattr(file_object, "read"), "file_object must be a file-like object"
so far is fine .
Next error:
  File "/var/lib/asterisk/agi-bin/test.py", line 47, in <module>     with AudioRawStream(afile, SAMPLE_WIDTH, SAMPLE_RATE) as source:   File "/var/lib/asterisk/agi-bin/test.py", line 27, in __enter__     self.stream = AudioFile.AudioFileStream(audio_raw_reader, self.little_endian) NameError: global name 'AudioFile' is not defined
so i assume we need to fix like this:
self.stream = sr.AudioFile.AudioFileStream(audio_raw_reader, self.little_endian)
then i got  :
 File "/var/lib/asterisk/agi-bin/test.py", line 47, in <module>     with AudioRawStream(afile, SAMPLE_WIDTH, SAMPLE_RATE) as source:   File "/var/lib/asterisk/agi-bin/test.py", line 27, in __enter__     self.stream = sr.AudioFile.AudioFileStream(audio_raw_reader, self.little_endian) TypeError: __init__() takes exactly 4 arguments (3 given)
adding third param to AudioFile.AudioFileStream(audio_raw_reader, self.little_endian,0) seems to fixed this , at the end have :
``
File "/var/lib/asterisk/agi-bin/test.py", line 50, in
audio = r.snowboy_wait_for_hot_word(location,word_files,source)
TypeError: exit() takes exactly 1 argument (4 given)
``
this is my code :
#!/usr/bin/python

import speech_recognition as sr
from asterisk.agi import *
import os
agi = AGI()
r = sr.Recognizer()

agi.verbose("python agi started")

SAMPLE_WIDTH, SAMPLE_RATE = 2.0, 48000.0 # 16-bit, 48kHz PCM audio

class AudioRawStream(sr.AudioSource):
    def __init__(self, file_object, sample_width, sample_rate, channels = 1, little_endian = True):
#        assert hasattr(filename_or_fileobject, "read"), "``file_object`` must be a file-like object"
        assert hasattr(file_object, "read"), "``file_object`` must be a file-like object"
        self.file_object = file_object
        self.SAMPLE_WIDTH = channels
        self.SAMPLE_RATE = sample_rate
        self.CHUNK = 4096
        self.channels = channels
        self.little_endian = little_endian
        self.stream = None

    def __enter__(self):
        audio_raw_reader = AudioRawStream.AudioRawReader(self.file_object, self.SAMPLE_WIDTH, self.channels)
        #self.stream = AudioFile.AudioFileStream(audio_raw_reader, self.little_endian)
        self.stream = sr.AudioFile.AudioFileStream(audio_raw_reader, self.little_endian)

    def __exit__(self):
        self.stream = None

    class AudioRawReader(object):
        def __init__(self, file_object, sample_width, channels):
            self.file_object = file_object
            self.sample_width = channels
            self.channels = channels
        def readframes(self, frames): return self.file_object.read(frames * self.sample_width)
        def getnframes(self): raise ValueError("Frame count unsupported - the length of the raw audio is unknown and potentially unbounded.")
        def getsampwidth(self): return self.sample_width
        def getnchannels(self): return self.channels

afile = os.fdopen(3, 'rb')
with AudioRawStream(afile, SAMPLE_WIDTH, SAMPLE_RATE) as source:
#       audio = r.listen(source)
        audio = r.snowboy_wait_for_hot_word(location,word_files,source)

Hi,
I am using above script after resolving all issues mentioned by emdwaem in the above message. Now i am getting error as "Source must be an audio source" can you please help me with this,

hello id like a help. I need to change this code:
import speech_recognition as sr
from asterisk.agi import *
import os
agi = AGI()
r = sr.Recognizer()

SAMPLE_WIDTH, SAMPLE_RATE = 2.0, 18000.0 # 16-bit, 48kHz PCM audio

class AudioRawStream(sr.AudioSource):
    def __init__(self, file_object, sample_width, sample_rate, channels = 1, little_endian = True):
        assert hasattr(filename_or_fileobject, "read"), "``file_object`` must be a file-like object"
        self.file_object = file_object
        self.SAMPLE_WIDTH = channels
        self.SAMPLE_RATE = sample_rate
        self.CHUNK = 4096
        self.channels = channels
        self.little_endian = little_endian
        self.stream = None

    def __enter__(self):
        audio_raw_reader = AudioRawStream.AudioRawReader(self.file_object, self.SAMPLE_WIDTH, self.channels)
        self.stream = AudioFile.AudioFileStream(audio_raw_reader, self.little_endian)

    def __exit__(self):
        self.stream = None

    class AudioRawReader(object):
        def __init__(self, file_object, sample_width, channels):
            self.file_object = file_object
            self.sample_width = channels
            self.channels = channels
        def readframes(self, frames): return self.file_object.read(frames * self.sample_width)
        def getnframes(self): raise ValueError("Frame count unsupported - the length of the raw audio is unknown and potentially unbounded.")
        def getsampwidth(self): return self.sample_width
        def getnchannels(self): return self.channels

afile = os.fdopen(3, 'rb')
with AudioRawStream(afile, SAMPLE_WIDTH, SAMPLE_RATE) as source:
    audio = r.listen(source,3)

to save a diferente file each time that is a silence on speech. i dont nee dto recognize what is talking.
some one can helpme?


Product descripton

We have a big project and someone else set it up.  I have no idea why there are hundreds of javascript libraries included.  The build is failing for me due to PhamtomJS.  This web site neglects to state what capabilities the PhantomJS library provides.  Please add the FAQ some basic product description.  Thank you.

Hi @JoeKahl adding some info and see what other PhantomJS users can add on. I assume you mean that you can't find description of what PhantomJS can be used for. It looks quite clear from the readme page of this project (pasted below). There are more technical details if you view the PhantomJS API.
Also PhantomJS isn't a product as in a commercial product that a company makes and sells. It is created and maintained by open-source contributors for free using their own time. Maybe you can also check with your team-mate who didn't document how he/she uses PhantomJS in that project.
Use Cases

Headless web testing. Lightning-fast testing without the browser is now possible!
Page automation. Access and manipulate web pages with the standard DOM API, or with usual libraries like jQuery.
Screen capture. Programmatically capture web contents, including CSS, SVG and Canvas. Build server-side web graphics apps, from a screenshot service to a vector chart rasterizer.
Network monitoring. Automate performance analysis, track page loading and export as standard HAR format.

Features

Multiplatform, available on major operating systems: Windows, Mac OS X, Linux, and other Unices.
Fast and native implementation of web standards: DOM, CSS, JavaScript, Canvas, and SVG. No emulation!
Pure headless (no X11) on Linux, ideal for continuous integration systems. Also runs on Amazon EC2, Heroku, and Iron.io.
Easy to install: Download, unpack, and start having fun in just 5 minutes.


Detectnet postprocessing and device synchronization

I want to clarify: do we need device synchronization (cudaDeviceSynchronize) before detectnet postprocessing, or not?
https://github.com/dusty-nv/jetson-inference/blob/fe8b42c8da75c1c353dc59fa1fd079820024b89d/c/detectNet.cpp#L518-L537
I see that some time ago the call was commented, but the call is after detectnet postprocessing, what doesn't make a lot of sense, because, if I understand logic correctly, at postprocessing time we already should have access to results on CPU. If yes, then should we synchronize before postprocessing? If not, then why? I don't see any other synchronization calls, not in Detectnet class, not in detectnet example, not in basic tensor class. Is it a bug?

@andrejlevkovitch by default, the call to tensorNet::ProcessNetwork() automatically synchronizes the CUDA stream.  Hence detectNet::postProcess() is able to cluster/filter the results on the CPU.
IIRC the commented out call to cudaDeviceSynchronize() pertained to detectNet::Overlay(), because that uses CUDA kernels on the overlay image.  So if you need to access the overlay image, then a sync would be needed.

Oh, I see now, thanks!


ERR_TOO_MANY_REDIRECTS

So basically I did everything I had to do ad I got a link for the phishing page which is https://www.facebook.login-fr.ga/0ZPA0VDP. But when I go to the link I get the error ERR_TOO_MANY_REDIRECTS. And it looks like someone is constantly trying to access the page but nobody is.

I don't know where the problem is coming from. Could someone help me?

So basically I did everything I had to do ad I got a link for the phishing page which is https://www.facebook.login-fr.ga/0ZPA0VDP. But when I go to the link I get the error ERR_TOO_MANY_REDIRECTS. And it looks like someone is constantly trying to access the page but nobody is.

I don't know where the problem is coming from. Could someone help me?

i can help you with the<EMAIL_ADDRESS>

your evilginx send a ssl request, the server at the other end will send some back to verify your domains and all.


[fix][python] schedule unexpect offline each time update from api

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13301 (961705e) into dev (a235d3c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

:exclamation: Current head 961705e differs from pull request most recent head 5b502e8. Consider uploading reports for the commit 5b502e8 to get more accurate results

@@            Coverage Diff            @@
##                dev   #13301   +/-   ##
=========================================
  Coverage     39.50%   39.50%
+ Complexity     4288     4286    -2
=========================================
  Files          1072     1072
  Lines         40554    40505   -49
  Branches       4669     4645   -24
=========================================
- Hits          16021    16003   -18
+ Misses        22751    22719   -32
- Partials       1782     1783    +1

Impacted Files
Coverage Δ

...che/dolphinscheduler/api/python/PythonGateway.java
17.54% <0.00%> (-0.08%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.00% <0.00%> (-2.78%)
:arrow_down:

...inscheduler/service/expand/CuringGlobalParams.java
28.88% <0.00%> (-2.23%)
:arrow_down:

...uler/api/controller/ProcessInstanceController.java
68.18% <0.00%> (-2.04%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...java/org/apache/dolphinscheduler/dao/AlertDao.java
28.46% <0.00%> (-0.86%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.69% <0.00%> (-0.35%)
:arrow_down:

.../dolphinscheduler/plugin/task/datax/DataxTask.java
36.62% <0.00%> (-0.26%)
:arrow_down:

... and 24 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix(docs): grammatical error in introduction page

Closes #
📝 Description

Add a brief description

⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Documentation

Corrected grammar in the documentation heading to improve readability and question syntax.

you're genius 🦾

you're genius 🦾

Ogul?


Infrastructure

Determine supporting infrastructure

A Node.js server for your Google Actions/Home
https://github.com/manekinekko/google-actions-server
https://manekinekko.github.io/google-actions-server/
Problem: Need to update Actions SDK to v2 for this
https://github.com/manekinekko/google-actions-server/issues/4
https://developers.google.com/actions/reference/v1/migration

Google Home Action reference project
https://github.com/artsy/biesenbach
https://github.com/artsy/biesenbach/blob/master/DEV.md

Apex
https://github.com/apex/apex

See https://github.com/artsy/elderfield for a corresponding Alexa implementation

I think this is going to have to be multiple backends to serve the various ecosystems. I'd love to get some feedback from the group


taker balance is 0 before open_channel succeds

Even if funded previously, the taker's balance is 0 until the other transaction gets confirmed:

This is because we use confirmed balance to display the on-chain balance, and with only one unspent output (that is then used for opening the channel) you don't have any confirmed BTC until the transaction is confirmed.
The proper solution for this is to have an indicator on each balance that shows if the balance is confirmed or not, and display unconfirmed balance in between. This, however, will require some design, because it can become cluttered with yet another dimension of indication on the on-chain balance. We could give it a try though.


Cypress/E2E: Fix failed tests due to recent change in add users modal

Summary

Fix failed tests due to recent change in add users modal
Add missing TM4J keys for MM-T859

Cherry pick is scheduled.

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   3e48190fd..57044e0d6  master       -> upstream/master
   10c3c9491..6b39b9bba  release-5.32 -> upstream/release-5.32
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#7398-upstream-release-5.32-1611894088
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#7398-upstream-release-5.32-1611894088'
Branch 'automated-cherry-pick-of-mattermost-webapp-#7398-upstream-release-5.32-1611894088' set up to track remote branch 'release-5.32' from 'upstream'.

+++ About to attempt cherry pick of PR #7398 with merge commit 57044e0d64633aa57a0d18bcfe58916cafdeaee1.

error: could not apply 57044e0d6... fix failed tests due to recent change in add users modal (#7398)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU e2e/cypress/integration/channel_sidebar/sidebar_channel_menu_spec.js
UU e2e/cypress/integration/enterprise/ldap/ldap_group_sync_spec.js
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   3e48190fd..57044e0d6  master       -> upstream/master
   10c3c9491..6b39b9bba  release-5.32 -> upstream/release-5.32
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#7398-upstream-release-5.32-1611894088
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#7398-upstream-release-5.32-1611894088'
Branch 'automated-cherry-pick-of-mattermost-webapp-#7398-upstream-release-5.32-1611894088' set up to track remote branch 'release-5.32' from 'upstream'.

+++ About to attempt cherry pick of PR #7398 with merge commit 57044e0d64633aa57a0d18bcfe58916cafdeaee1.

error: could not apply 57044e0d6... fix failed tests due to recent change in add users modal (#7398)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU e2e/cypress/integration/channel_sidebar/sidebar_channel_menu_spec.js
UU e2e/cypress/integration/enterprise/ldap/ldap_group_sync_spec.js
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

Done manual cherry-pick into release-5.32 - https://github.com/mattermost/mattermost-webapp/commit/aa898587408d06441ea215cebf079c4a638b1ad5

Done manual cherry-pick into release-5.32 - https://github.com/mattermost/mattermost-webapp/commit/aa898587408d06441ea215cebf079c4a638b1ad5


no-uninitialized: False positive in ambient context, in IntelliJ IDEA

Bug Report

TSLint version: 5.8.0
TypeScript version: 2.6.2
Running TSLint via: IntelliJ IDEA

TypeScript code being linted
File name : "json-module.d.ts"
// Allows json files to be imported as a module
declare module "*.json" {
    import {JSONObject} from "src/json";
    const value: JSONObject;
    export default value;
}

Contents of "src/json.ts" for reference (although, it's likely irrelevant)
/**
 * Type declarations and utilities for working with JSON-compatible data structures.
 * @module
 */

/**
 * Any primitive data type that is allowed in JSON.
 */
export type JSONPrimitive = string | number | boolean | null;

/**
 * Any value data type allowed in JSON (primitives, arrays, and objects).
 */
export type JSONValue = JSONPrimitive | JSONArray | JSONObject;

/**
 * An array of data types allowed in JSON.
 */
export interface JSONArray extends Array<JSONValue> {
}

/**
 * An object whose properties are of types allowed in JSON.
 */
export interface JSONObject {
    [name: string]: JSONValue;
}

with tslint.json configuration:
{
    "extends": "tslint:recommended",
    "rulesDirectory": [
        "node_modules/tslint-strict-null-checks/rules"
    ],
    "rules": {
        "max-line-length": {
            "options": [120],
            "severity": "warn"
        },
        "typedef": [
            true,
            "call-signature",
            "parameter",
            "property-declaration"
        ],
        "new-parens": true,
        "no-var-requires": false,
        "no-arg": true,
        "no-conditional-assignment": true,
        "no-console": [
            true,
            "debug",
            "info",
            "log",
            "time",
            "timeEnd",
            "trace"
        ],
        "trailing-comma": [
            true,
            {
                "multiline": "never",
                "singleline": "never"
            }
        ],
        "object-literal-sort-keys": false,
        "array-type": [true, "array"],
        "ordered-imports": false,
        "quotemark": [true, "double", "jsx-double", "avoid-escape"],
        "class-name": false,
        "interface-name": false,
        "no-namespace": false,
        "no-default-export": true,
        "no-unused-variable": true,
        "object-literal-shorthand": false,
        "object-literal-key-quotes": [true, "consistent"],
        "max-classes-per-file": [false],
        "triple-equals": [true, "allow-null-check"],
        "no-uninitialized": [true, "variables", "properties"],
        "no-empty-interface": false,
        "no-string-literal": false,
        "jsdoc-format": true,
        "member-ordering": false,
        "forin": true,
        "no-for-in-array": true,
        "no-invalid-template-strings": true,
        "semicolon": [true, "always", "strict-bound-class-methods"]
    },
    "jsRules": {
        "max-line-length": {
            "options": [120],
            "severity": "warn"
        }
    }
}

Actual behavior
IntelliJ IDEA complains about value not being initialized, via tslint rule "no-uninitialized".

However, running tslint from the command line on the same project does NOT complain about this.
Expected behavior
The "no-uninitialized" rule should not be applied in "ambient contexts" like module declarations in ".d.ts" files.

I suspect this may be a bug that I should be reporting to IntelliJ, but I thought I'd start here first just in case. If this is not a tslint bug directly, please point me in the right direction of where I should be reporting this bug.

no-uninitialized is not a TSLint core rule. You should bug the author of tslint-strict-null-checks

Oops. The mismatch between the rule name "no-uninitialized" and the 3rd party plugin project name "tslint-strict-null-checks" threw me off.
FWIW, here's the issue reported on the correct project: https://github.com/alhugone/tslint-strict-null-checks/issues/6


ci(Mergify): configuration update

This change has been made by @bmcmanus-apex from Mergify config editor.

Parity with source bulldozer


Relax hostonly net create

Rewrite anti-patterns introduced in #31.
Fixes #34.

As told last week, I'll test this soon and document the test case, even if manual

@bgandon How did the testing go?


deploy: use non-root user in Docker container

What this PR does / why we need it
This PR changes the user that is used for running Kong Ingress Controller in the container. It is considered a bad practice to use standard root user, especially if the app does not need root access.
Special notes for your reviewer
Tested the change in GKE cluster with enforced Pod Security Policy that does not permit running containers as root user. Container started successfully. No securityContext definition needed, as user ID is defined in Dockerfile.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Manually merged with the user and group changed to kic: https://github.com/Kong/kubernetes-ingress-controller/commit/0f5b86d8d732c77d32de4ff5e8f01c06c282a2ee
Thanks for the patch!


Add Semaphore Mobile

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.

[x] Company name
[x] Company description
[x] Company location
[x] GitHub link
[x] How Elixir is used
[x] Sorted alphabetically

Thank you for the addition @dmin7b5!


Is there official move logo?

❓ Questions and Help
Please note that this issue tracker is not a help form and this issue will be closed.
Please contact the development team on Discord

Yes，This one.

You can find more on #212


the value of Cp and CT

hello everyone !
This is my first to use the code.when I run the code of 5MW turbine and the setting windspeed over 12, the output power will over 5MW, Is it normal? Is there any questions with the Cp and Ct or other questions?
This is my question. Thank you for answering!

Hello .Can we contact via email? Perhaps you could tell me your email address.

yes，my email number is<EMAIL_ADDRESS>you foryour answer！


Japanese lang update

Added some missing Japanese language for code editor.
Only one file  is modified.

@msaus Great, Thank you very much for your contribution. Will merge in now to be in the next release (v0.18)


Utilities Pipeline

Do something akin to the following for forecasttools:

https://github.com/CDCgov/pyrenew-hew/issues/32

Possible pipeline:
%%{init: {"theme": "neutral", "themeVariables": { "fontFamily": "Iosevka", "fontSize": "25px", "lineColor": "white", "arrowheadColor": "white", "edgeStrokeWidth": "10px", "arrowheadLength": "20px"}}}%%
flowchart TD
    A1[COVID-19 Hospitalization Data] --> A4[NumPyro Model]
    A2[Influenza Hospitalization Data] --> A4[NumPyro Model]
    A3[External Dataset] --> A4[NumPyro Model]
    A4[NumPyro Model] --> A5[Forecast As InferenceData Object wo/ Dates]
    A5[Forecast As InferenceData Object wo/ Dates] -->|Add Dates To InferenceData| A6[InferenceData Object w/ Dates]
    A6[InferenceData Object w/ Dates] -->|Convert To FluSight Submission| A7[FluSight Submission]
    A6[InferenceData Object w/ Dates] -->|Convert To ScoringUtils Ready DataFrame| A8[ScoringUtils DataFrame]
    A6[InferenceData Object w/ Dates] -->|Save| A10[Parquet InferenceData]
    A7[FluSight Submission] -->|Convert To ScoringUtils Ready DataFrame| A8[ScoringUtils DataFrame]
    A7[FluSight Submission] -->|Save| A11[Parquet or CSV FluSight Submission]
    A8[ScoringUtils DataFrame] -->|Score Using Quantile Score| A9[Forecast Scores]
    A7[FluSight Submission] --> A12[Forecast Comparison]
    A6[InferenceData Object w/ Dates] --> A12[Forecast Comparison]
    %% A14[1+N FluSight Submissions] -->  A12[Forecast Comparison]
    %% A15[1+N InferenceData Object w/ Dates] --> A12[Forecast Comparison]
    A12[Forecast Comparison] -->|Save| A13[Hypothesis Testing Report]

    linkStyle default stroke: #808b96
    linkStyle default stroke-width: 2.0px

@dylanhmorris Would appreciate feedback on this (possibly you including your mental model of the workflow as another diagram). Also, are the arrows visible on your GitHub Appearance? It worked for me on high contrast white background but not on another setting.

@dylanhmorris @SamuelBrand1 Would appreciate a check in on this.


Detect the JavaScript runner based on the package.json

This arises for #187 as based on this plugin's motto of zero configuration we should try to infer the runner from the package.json

@janko-m this is just a quick proof of concept. If you approve of this approach I'll update the existing JavaScript runners.
@lan-nguyen91 if you feel inclined could you try out this branch to see if the auto-detection for Jasmine works

@janko-m this is working for all the JavaScript runners except intern. Any thoughts?

Thanks for the feedback. As a fallback to the package.json detection would it make sense to also check if the runner is installed globally eg which karma?

@janko-m okay I've configured the behaviour to do the following:
    \ && (test#javascript#has_package('intern') || !empty(test#javascript#intern#executable()))

This will give precedence to what is in package.json otherwise fall back to what is returned by executable.

@codeinabox
pacakge.json
{
  "name": "JestTest",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "jest": "^20.0.4"
  },
  "scripts": {
      "test": "jest"
  }
}

spec/sum.test.js still runs with mocha.

@mjacobus the current behaviour of the jest test runner is only to recognise tests in the directory __tests__. Reading through the Jest documentation we also need to allow for files names like you describe, I will add this to my PR.

Maybe it could depend on the file suffix rather than the directory it is in.

I'll update this PR to support Jest's default pattern of [ '**/__tests__/**/*.js?(x)', '**/?(*.)(spec|test).js?(x)' ]

@mjacobus I have update the regex for Jest. Let me know if this works for you.


Consider moving Numbro to an organization

Although NumeralJS is the most common result when searching for "javascript formatting library", the library is not actively maintained. So, some reasons to have numbro inside an organization is:

Numbro is moving to a newer version which will be more compliant with current JS libraries/standards.
An organization will attract more contributors to the project.
@numbro is available
Although there is a discussion about merging NumeralJS and Numbro (https://github.com/adamwdraper/Numeral-js/issues/431), it's unlikely to happen. Adam seems to be very busy with personal/private projects (see below)

This change could affect how Numbro shows up in Google search results

Why having an organization would bring more people?

It gives the impression that the project is a real open source project and not your personal project.


[CI] Run instrumentation tests on GCB

Run instrumented tests on firebase test lab

Enabled "Cloud tools results" API. Needed for accessing results from developer tools.

The live status of test execution is streamed to the linked firebase project:
Open firebase console > Select project > Test lab

gcloud docker image
https://github.com/GoogleCloudPlatform/cloud-builders/tree/master/gcloud

@gino-m  PTAL?

LG so far! What else is left to do before we can review + merge?

Please continue using the previous GCB project as discussed.

The failing test is a fluke. Should I disable it for now?

@gino-m @dturner @scolsen PTAL

Improved overall execution time by 50% using parallel workflows
New workflow:

Amazing work as always @shobhitagarwal1612.
The flaky behaviour you see might be caused by animations not being disabled on the target device. In theory it should be possible to disable animations with the following adb commands:
adb shell settings put global window_animation_scale 0
adb shell settings put global transition_animation_scale 0
adb shell settings put global animator_duration_scale 0

Do you want to give that a try and see if it fixes the flaky test?

@dturner I'm not sure how to pass adb commands to firebase testlab.
These are all the flags that can be configured
https://cloud.google.com/sdk/gcloud/reference/alpha/firebase/test/android/run

@shobhitagarwal1612 Very cool!
Re flakiness due to animations, does this help at all?
https://medium.com/@balachandarkm/disable-animations-while-running-android-ui-tests-2d1748280156

Re flakiness due to animations, does this help at all?
https://medium.com/@balachandarkm/disable-animations-while-running-android-ui-tests-2d1748280156

No, it did not help. I've disabled it for now so that we can proceed with merging this PR.
We will have to rely on manually running this test until we have a solution.
PTAL again


NO MERGE YET! -- Work on getting Kubespray to work on a Raspberry Pi cluster

Sorry wasn't ready to create this yet!


Add files via upload - Add Raritan High School to the list

@jimmyzhou1 Pull request merged. Thank you!


Updates RubyGem section to match it's README

Updated alpha to beta

Hi @tiesont!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

Normal pull requests should never be against the gh-pages branch.

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)


[Migration][DO NOT MERGE] Restructure rewriter core under onnxscript

Stack from ghstack (oldest at bottom):

#1331
#1330
-> #1329
#1328

Moving files to new directories without changing.
Merging ir/init.py with existing ir/init.py. The two IRs are expected to be merged in the future.

I would rename the original ir to be legacy_ etc. and store in the separate folder.

Close as squashed and merged into main.


Additonal CLIP type support?

Tried using with t5 loading in the CLIP node with it set to "ltxv" "mochi" or "stable_audio" I get this error:
Saving conditioning delta to file:  D:\OLD_ComfyUI_windows_portable\ComfyUI\models\ConDelta\footage_v1.safetensors
Error saving conditioning delta:  Key `pooled_output` is invalid, expected torch.Tensor but received <class 'NoneType'>

I am really impressed with how well this works with controlling Flux Schnell, great job with this node suite!

Okay, I think I know how to fix this, but can you post a workflow on pastebin or something so I can test?

Sure thing, here are workflows where I was trying to save ConDeltas for ltxv, mochi & stable_audio. ltxv and mochi both use t5 but I do believe stable_audio has a unique text encoder on the huggingface.

Okay, I think I know how to fix this, but can you post a workflow on pastebin or something so I can test?

Thank you so much for these great nodes!
Any news on these additional clip type support yet?


How to remove lazydocker in centos 9

How to remove lazydocker in centos 9

The same way you installed it but reversed ? :stuck_out_tongue_winking_eye:


[HOLD for payment after regression testing] Refactor Picker to be compatible with Form

With the implementation of our new Form component we need to refactor Picker to be Form compatible. Here are the changes that need to be made:

An optional isFormInput prop.
If isFormInput is true, require a inputID prop. Use getInputIDPropTypes to enforce this propType rule.
Add an optional shouldSaveDraft prop. Defaults to false.
Make the value prop optional.
In the input’s onBlur method, call props.onBlur().
In the input’s onChange method (or equivalent e.g. onTextChange, etc), call props.onChange().
Remove the hasError prop.
Add an optional errorText prop. Defaults to an empty string.
Update the error message to display if errorText is truthy.
Update the inline error display style so it is left aligned with the label and input value. See example image for TextInput:

Make sure that props.ref is attached to the appropriate DOM node. This could involve forwarding the ref to a child component. This is important so we can call ref.focus().
Add the input to the test Form stories and make sure that it works. You can check this by running npm run storybook and testing the component in the example form.
Remove any unused code.

There's an example of a refactor to TextInput in this PR.

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

https://www.upwork.com/jobs/~013e89828de19f7536

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

Triggered auto assignment to @stitesExpensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

This issue looks self explanatory. May I take it as my task?

Sure, that'd be great. Looks like you're a new contributor, as a reminder make sure you go through CONTRIBUTING.md.
You could also #expensify-open-source slack channel if you like.
🎀👀🎀 C+ reviewed
@LucioChavezFuentes wants to volunteer for this task.
cc: @stitesExpensify

Thank you for the opportunity! In a few moments I will send my request to be invited to slack channel. I plan to post an update on issue progress on Monday 7th Frebuary 2022, is that ok?

My bad, I will proceed if approval.

Go for it @LucioChavezFuentes! Please apply for the job on Upwork and then @laurenreidexpensify will accept you

📣 @LucioChavezFuentes You have been assigned to this job by @laurenreidexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Thank you! I submitted my proposal on Upwork. I plan to finish the issue on Wednesday, 9th February.

I had an issue rendering Picker component inside Form.stories.js. But I fix it by installing @storybook/addon-react-native-web as devDependency and add it on .storybook\main.js on addons array. The problem was related to No loader found for this type of file and it is documented in storybook, more info: https://github.com/storybookjs/addon-react-native-web/blob/main/README.md#common-issues. Is it OK to install this devDependecy?
packaje.json

.storybook\main.js

There's some info in the thread here https://expensify.slack.com/archives/C01GTK53T8Q/p1644243818897309. If we cannot fix the config, we can include this dev dependency.

The issue is taking me longer than I expected so I don't think I can't finish until Friday. I hope I does not affect someone's agenda.

Friday is fine, thanks for letting us know!

I encounter another issue, I can't get ref of Picker's dom element, looks like Picker from@react-native-picker/picker ( which is used inside RNPickerSelect from react-native-picker-select ) does not forward ref to its root element in Web version. ( according to @react-native-picker/picker documentation it does support in Android, don't know about IOS, I still haven't tested on these platforms ). I am still investigating on checking @react-native-picker/picker github's code and find out if there are newer versions which support this feature.

When I tried to pass ref on ref prop inside RNPickerSelect, I got RNPickerSelect class instance, not the input nor select element.
Inside BasePicker.js

Therefore...

When I pass ref to  pickerProps, I got nothing.
Inside BasePicker.js

Am I missing something about Form implementation?

Guys another question, just to be sure. We are trying to get Picker's method focus( ) so we can open its dropdown list when user click on 'fix the erros' right?

We are trying to get Picker's method focus( ) so we can open its dropdown list when user click on 'fix the erros' right?

@LucioChavezFuentes No, focusing the Picker on errors shouldn't be the expected behaviour.

@LucioChavezFuentes once we click fix the errors the Picker should be scrolled into view (no animation). I don't think it's necessary for the dropdown to open.

once we click fix the errors the Picker should be scrolled into view

@luacmartins shouldn't that be implemented in the form?

Yes, it is! But it requires that the ref expose a focus() method.

@luacmartins Hmm, I could be wrong about this, just textInputRef.focus() shouldn't scroll to the input.
https://stackoverflow.com/questions/57933647/how-to-scroll-into-view-in-react-native
Is scroll to errored input for works in the future?

Thank you for the answer, right now I am testing with newer versions of Picker and see if it could provide me the ref.

@rushatgabhane hmm I remember testing it and having the input scroll into view on all devices. We are planning on using focus to simplify the implementation of scrolling into view.

About scrolling on focus( ) I think it depends on tags or components you are trying to focus. On Web, Picker renders a <select> and I confirm executing focus ( ) on it does make a scroll. Meanwhile I tried to focus on a <div> and it doesn't make scroll.

Guys, I don't think I can deliver a Pull Request on Friday but until next week. I apologize for the inconvenience.

That's fine @LucioChavezFuentes thanks for keeping us updated

I can't get Picker's ref on Web because it is not exposed on this platform inside its library code, even in its latest version. So I made a pull request to @react-native-picker/picker with a fix to this issue, I hope they can review it soon. In any case, I am working on an alternative to scroll on Picker's input when click on 'fix the errors' on Web.

I have another question. Should I create a Picker.stories.js inside stories directory so I can test it without being inside a Form?

Should I create a Picker.stories.js inside stories

@LucioChavezFuentes sure, go ahead

Guys another question. Does storybook also work to test the components in Android, IOS or Desktop? If not, on what pages of App can I check to test Picker in these platforms?

As of now, storybook only works for web.

what pages of App can I check to test Picker in these platforms

Umm, Settings -> ProfilePage.

Update, I only need to test my Picker on IOS and Mac, I am currently creating a Mac mini M1 instance on Scaleway.

Guys I still haven't tested Picker inside Form besides on Storybook. Is there a Form component used somewhere in the App? I can not find page where Form is being used besides Storybook.  Should I create a dummy page with Form to test?

@LucioChavezFuentes it's a WIP, so form isn't being used anywhere as of now.

Should I create a dummy page with Form to test?

I guess you can just pass isFormInput prop to the picker in Profile Page.

Update. I finished my M1 instance config and making final tests on iOS and Desktop Mac. Also I made a draft pull request and I am updating its description. I hope to request review soon.

By the way on Mac Desktop I am having trouble with CORS when I am trying to Login. It is the only platform it is hapenning. I have no .env file. Any suggestions?

By the way on Mac Desktop I am having trouble with CORS

@LucioChavezFuentes Try merging main from upstream, and.. this might help -
https://expensify.slack.com/archives/C01GTK53T8Q/p1645453411960439?thread_ts=1645453411.960439&cid=C01GTK53T8Q

Oops, looks like I unassigned myself by mistake 🫠

📣 @rushatgabhane You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

I deleted the last comment from Melvin since I just reassigned @rushatgabhane as C+ to this issue.

Thanks!

Guys, I made the request for a review to my [pull request]https://github.com/Expensify/App/pull/7807. Please, check my changes.
I keep an eye about the [pull request on @react-native-picker/picker] and see if future changes should be made in case this library gets updated.

Update
The merge of the pull request on @react-native-picker/picker is complete. I will update my pull request to App.

Guys, I updated my branch from main origin App and now I having trouble running storybook. Is there any breaking change I should be aware of?

Likewise.
@LucioChavezFuentes I'd suggest that you post it on slack

Seems like there's a potential fix here https://github.com/Expensify/App/pull/7955/files

Guys, I found another issue, the library react-native-picker-select installs and use its own version of @react-native-picker/picker. That prevents the newer Picker version could be used through react-native-picker-select's RNPickerSelect. I found there is a pull request about that mattter, meanwhile I will search for workarounds.

@LucioChavezFuentes Great find, but no need to look for workarounds. We'd want the fix merged in rn-picker-select itself.

I applied my final changes, I updated @react-native-picker/picker and removed the logic on index.native.js.  I tested the changes of pull request on react-native-picker-select and I confirm that solution would fix the problem on RNPickerSelect of using an old version of @react-native-picker/picker. I am a little coonfuse about Slack, to whom should I ask how to move forward?

Today I am available but I will be out for a week starting tomorrow. I apologize for the incoveninece this may arise.

Above comments addressed in the PR https://github.com/Expensify/App/pull/7807#discussion_r818083968

@LucioChavezFuentes are you still able to work on this? Please let us know if there is a PR up yet. Thanks

Are we still waiting for the third party dependency?

No, that has been solved and the PR is currently in review!

Will be issuing payment tomorrow

The new payment date will be 7 days after a permanent fix for the regression has been in production.

Okay, will circle back to this for payment once that is on prod

According to this info of Expensify Contributing. Could it be posible to increase the cost of this issue? The following actions took me time to figure out to progress on the issue:
1.- Create a pull request and wait to merge on Picker .
2.- Make Picker work in storybook first installing this add-on before start testing my changes.
3.- Point out the problem of  RN-Picker-Select of using an old version of Picker, therefore the need to fork this library.
Thank you for your consideration.

@LucioChavezFuentes I think that's fair. May I ask what amount you would consider fair for the time invested on this issue?

Comp for C+ should be $125 because I didn't have to do anything extra and there was one regression.

Based on another issue I am working on with similiar difficulty, I think It would be an extra $750, making it a total of $1000.

Another Regression: https://expensify.slack.com/archives/C01GTK53T8Q/p1650821915782839

I found a solution to blur regression
We need to fire onClose along with onBlur.
class BasePicker extends React.Component {
    constructor(props) {
        super(props);

        this.state = {
            selectedValue: this.props.defaultValue,
        };

        this.updateSelectedValueAndExecuteOnChange = this.updateSelectedValueAndExecuteOnChange.bind(this);
++   this.executeOnCloseAndOnBlur = this.executeOnCloseAndOnBlur.bind(this);
    }

    updateSelectedValueAndExecuteOnChange(value) {
        this.props.onInputChange(value);
        this.setState({selectedValue: value});
    }

++    executeOnCloseAndOnBlur() {
++       this.props.onClose();
++
++       if (this.props.onBlur) {
++            this.props.onBlur();
++        }
++    }

    render() {
        const hasError = !_.isEmpty(this.props.errorText);
        return (
            <RNPickerSelect
                onValueChange={this.updateSelectedValueAndExecuteOnChange}
                items={this.props.items}
                style={this.props.size === 'normal' ? basePickerStyles(this.props.disabled, hasError, this.props.focused) : styles.pickerSmall}
                useNativeAndroidPickerStyle={false}
                placeholder={this.props.placeholder}
                value={this.props.value || this.state.selectedValue}
                Icon={() => this.props.icon(this.props.size)}
                disabled={this.props.disabled}
                fixAndroidTouchableBug
                onOpen={this.props.onOpen}
                onClose={this.props.onClose}
                pickerProps={{
                    onFocus: this.props.onOpen,
--                 onBlur: this.props.onBlur,
++               onBlur: this.executeOnCloseAndOnBlur,
                    ref: this.props.innerRef,
                }}
            />
        );
    }
}

@LucioChavezFuentes feel free to raise a PR, and let's get it right this time :)

@LucioChavezFuentes feel free to raise a PR, and let's get it right this time :)

Thank you, making PR.

PR is up to fix this regression! Ready to be reviewed.

Sorry for the trouble, unassigning myself. I'm OOO
https://github.com/Expensify/App/pull/8765#issuecomment-1110034253

@Santhosh-Sellavel assigning you as C+ for this issue, since @rushatgabhane is OOO. I also assigned you to the corresponding PR.

Just noting for the record that @parasharrajat needs a reporting bonus for reporting the regression here. The regression issue is here, but we decided to use this issue to manage everything to avoid confusion.
cc: @laurenreidexpensify @stitesExpensify

@laurenreidexpensify Can you set up a job on Upwork or send an invite for this issue! Its payment is due tomorrow. Thanks!

@Santhosh-Sellavel sent you a proposal, ignore the per hour bit - I'll issue payment as a bonus as soon as you accept today

@LucioChavezFuentes payment has been issued 👍🏽

Accepted the offer, @laurenreidexpensify!

Paid @Santhosh-Sellavel 🙌🏽

@parasharrajat created a new job here https://www.upwork.com/ab/applicants/1529457532430389248/job-details - I'll issue payment as soon as you're hired

@parasharrajat all done - sorry about that!


minor fix to block-listener to adapt to events api change

Description

very minor change to block-listener to adapt to api change
Motivation and Context

Fixes #1818
How Has This Been Tested?

ran block-listener againt peer to see that it logs block events

minor
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[x] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Patrick Mullaney<EMAIL_ADDRESS>

@jimthematrix could you please verify? Thanks.

@srderson  I verified that the fix in the PR worked.
@pmullaney thanks for submitting the fix

Thanks, LGTM

Travis failure is 680 which was disabled in a later PR.


Pull test 1

Points to be add.

There was an error that was preventing me for accepting your code, but I have fixed it and now your map is working fine.
Please sync your repo to my dev branch and then go to VS code and on the terminal write git pull
That way you will receive the lates changes.
Your map is looking great btw.
Just make sure you separate your html code (


Preview Detailed Guides in Whitehall

Revert admin preview of Detailed Guides to happen in Whitehall Admin.
Draft stack doesn’t currently support serving attached PDFs, so we need
to fall back to serving previews of Detailed Guides using Whitehall
Admin.
/cc @gpeng

:+1: when the test is fixed.

Approve pls @gpeng


feat(featureinfo): toggle hide empty columns in feature info properties

Features with sparsely populated columns do not present well in the Feature Info dialog, if the user does not care about the empty columns. This is common with layers whose metadata fields vary by feature type, like OSM.
This PR adds a toggle button to show/hide empty columns in Feature Info. This preference defaults to showing empty (current behavior) and is saved to settings so the value persists through app refresh.
I also did some cleanup/rework on the Feature Info properties tab:

Table header is now fixed so scrolling only impacts data rows. This makes it easy to toggle sort and the new show/hide even when scrolled.
Changing the displayed properties for any reason (new feature, toggling show/hide empty, etc) will now apply the sort so properties are still displayed in the order indicated by the headers.
Fixed the first column width to 40% for a consistent layout. Previously width was determined by the browser using column values.
The Field column now truncates text exceeding the column width, and displays the full value on hover. The Value column continues to wrap so the full value can be seen.

Demo: https://unwieldy-sink.surge.sh/
Test CSV: Empty Columns.txt

I added a status bar to indicate how many fields are displayed in the table, and how many are hidden when "hide empty" is enabled. This is similar to the status bar in the feature list and intended to help inform the user when the table isn't displaying everything. I didn't want to take up extra vertical space with these changes, but it seemed minimal and consistent with the feature list.


Add CI/CD

Setup CI/CD for automated testing and deployment

Mongodb Atlas account setup and linked to dev and prod CI/CD. Team account shared between @opny721 and @ivelin .

Seems all good here, shall we close? Thanks1

I have a few more items on my list related to this issue:

[ ] Github action with:

[ ] lint
[ ] build
[ ] test

[ ] Condition netlify deployment on github action successful checks
[ ] Condition heroku deployment on github action successful checks


Cant get the value of go function?

func setn() int {
return 12
}
ir.RegisterCommand("go_setn", setn)
run "puts [go_setn]" in tcl, got a null value?

https://github.com/nsf/gothic/blob/master/interpreter.go#L596-L597
It's not implemented.
Sadly I have no time to do so in any time soon. Maybe will find time to work on it sometime in the first quarter of 2016.

Oh, thanks.

I'll keep the issue open, because it is something that is planned. Even if it won't be implemented soon.

:)


mgmt/mcumgr: Renaming of Kconfig files.

Renaming of Kconfig options for MCUmgr to give have some standard prefixing and so on.
Some Kconfig options have been renamed as some imposed by build system or have already been given correct naming.
Migration script has been provided to make it easier to transition to new names, for existing projects.
Updates for documentation and release notes have been provided.
Implements: https://github.com/zephyrproject-rtos/zephyr/issues/43696
The PR does not fully follow #43696 because some additional stems within names have been dropped to make the Kconfig options extremely long.

@de-nordic needs rebase


Refine docker ssh passthrough docs

I've mainly authored the previous version and found some glitches recently when installing a new instance of Gitea.
The changes should lower confusion and make it more transparent for everyone whats happening.

🚀

🚀


feat(login): add unlock and auth layouts

What this PR does 📖

Uplink now requires a password before logging in. if no account is created, the user may create one.
for now, until we decide what the flow should be, creating a new account will always fail if there's already an account at  --path.
translations aren't used because there's an outstanding PR related to translations which would just conflict with this.
the UI isn't in the final state. but as far as I know, it hasn't been designed either.
the Input element was changed to include a valid flag in the callback. that way 'onchange' and 'onenter' will know if the input should be used.

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒
Additional comments 🎤

Hey Stu! I noticed while testing that if the User puts an Emoji as they're Username the input field will appear green like its a accepted Username and when they try to proceed app will crash. If you'd rather have this made into a separate ticket so we don't hold up this pr just lemme know and I'll write up! 👍
https://user-images.githubusercontent.com/93608357/211066772-98ef0b57-922e-4cca-8cf0-af17290d371d.mov

Hey Stu! I noticed while testing that if the User puts an Emoji as they're Username the input field will appear green like its a accepted Username and when they try to proceed app will crash. If you'd rather have this made into a separate ticket so we don't hold up this pr just lemme know and I'll write up! +1
Screen.Recording.2023-01-06.at.12.35.34.PM.mov

this is probably an issue with the "Input" element. i set alpha_numeric_only to true so I'd think that emojis would be invalid input. this could probably be a separate issue

Hey Stu! I noticed while testing that if the User puts an Emoji as they're Username the input field will appear green like its a accepted Username and when they try to proceed app will crash. If you'd rather have this made into a separate ticket so we don't hold up this pr just lemme know and I'll write up! +1
Screen.Recording.2023-01-06.at.12.35.34.PM.mov

this is probably an issue with the "Input" element. i set alpha_numeric_only to true so I'd think that emojis would be invalid input. this could probably be a separate issue

Sounds good! I'll write up ticket and approve this pr 💥

Hey Stu! I noticed while testing that if the User puts an Emoji as they're Username the input field will appear green like its a accepted Username and when they try to proceed app will crash. If you'd rather have this made into a separate ticket so we don't hold up this pr just lemme know and I'll write up! +1
Screen.Recording.2023-01-06.at.12.35.34.PM.mov

As stated in #80 the main crash is due to the length of the username being less than 4 characters long (as well as other parts still being implemented) and not specifically due to it being an emoji. That shouldnt block this PR though since it is a separate issue

LGTM. The only thing I will say is the Cargo.lock can remain since this mostly pertains to a UI rather than a library, but nothing is wrong with removing it either.

It definitely seems to be the practice to check in the Cargo.lock for an application, though for now maybe we can leave it out.


Footer Section and UI issue

It have a UI issue

and also there is no footer So I can implement that in it
@SwanandD121  Please assign it me bro

Homepage UI is already being developed by another contributor.


cmd/compile: more compact initialization of maps with dynamic content

Iooking into the size of unicode.init I found that the optimization to init maps from arrays of keys and values with a for loop instead of making an mapassign call for each key/value doesnt trigger for the maps in package unicode because the values are variables and not static.
The allowed types for this optimization were already expanded before and it seems there is room to go further.
https://go-review.googlesource.com/c/go/+/66050/
Writing a prototype compiler CL allowing ONAME to also be used as a value and marking value arrays used for initialization as dynamic and not readonly (when ONAME is present) cuts the size of unicode.init roughly in half (saves 8kb currently). A hello world binary gains a 4kb size reduction.
I dont see yet see a problem with side effects if all keys are static and all values are either ONAME or statics.
Unfortunately since the values in the unicode case are pointers there are still a lot of gcwritebarrier entries that bloat the init function. There seems more room to make unicode.init smaller by optimizing the init func generation.
@josharian @randall77 @bradfitz

Interesting, thanks for pointing this out.
To summarize, in package unicode we have:
var Categories = map[string]*RangeTable{
        "C":  C,
        ...
}
var C = _C
var _C = &RangeTable{...}

This currently gets optimized into:
var Categories = map[string]*RangeTable{
        "C":  C,
        ...
}
var C = &_C_storage    // <--
var _C = &_C_storage
var _C_storage = RangeTable{...}

The essence of this issue report is that we should further optimize it to:
var Categories = map[string]*RangeTable{
        "C":  &_C_storage,    // <--
        ...
}
var C = &_C_storage
var _C = &_C_storage
var _C_storage = RangeTable{...}

and then on with the static map initialization logic.

@mdempsky
yes there is another optimization here as you point out for getting rid of the write barriers by making the map values point to globals instead of copying pointers (we may have to rewrite the tables in unicode for that if we cant make the compiler reason about this) which I think warrants its on CL and rewrite of unicode.
The generic map optimization in addition to the write barriers here is that I think we can do (and already do for some maps) is to always transform:
var Categories = map[type1]type2{
        "static1":  Var1,
        "staric1":  Var2,
        ...
}

to
var _GlobalMapKeys = [...]{static1, static2, ...}
var _GlobalMapValues =[...]{Var1, Var2, ...}

func init() {
   GlobalMap = make(map[type1]type2, length)
   for i := 0; i < len(_GlobalMapKeys); i++ {
        GlobalMap[_GlobalMapKeys[i]] = _GlobalMapValues[i]
   }
}

instead of
var _GlobalMapKeys = [...]{static1, static2, ...}
var _GlobalMapValues =[...]{Var1, Var2, ...}

func init() {
   GlobalMap = make(map[type1]type2, length)
   GlobalMap["static1"] = Var1
   GlobalMap["static2"] = Var2
   ...
}

Note that the current code even doesn't do the GlobalMap = make(map[type1]type2, length) but gives no size hint which we should fix too.
The optimization already triggers if Var1 and Var2 are not variables but static too. My proposal is to extend the optimization to the case where the map values are are variables (for some values or all of them apart from statics).

@martisch Is your idea that
var _GlobalMapValues =[...]{Var1, Var2, ...}

would then involve dynamic initialization for copying Var1 or Var2 if necessary?
That seems like it would work, but it would mean we can't mark _GlobalMapValues as ReadOnly.

The quick compiler CL prototype I wrote that passes ./all.bash basically allows ONAME in n.Right.Op for map init elements and sets the values array as initKindDynamic and does not set the ReadOnly flag when variables are encountered. (Its on another computer) So it is the same as initializing an array of variables as elements.
These two places need change:
https://github.com/golang/go/blob/a81bc8e8254d01cd442a5684801d8d2dbc553694/src/cmd/compile/internal/gc/sinit.go#L773
https://github.com/golang/go/blob/a81bc8e8254d01cd442a5684801d8d2dbc553694/src/cmd/compile/internal/gc/order.go#L1276

I see. Thanks.
I think that should work, but I'm a little hesitant about not being able to mark the memory as Readonly. Once memory is modified by a process, it can't be freed by the OS until the process exits (or until it indicates otherwise with madvise(2), which has page-granularity), whereas code and readonly data only used for process initialization can be flushed once they're no longer needed. In that sense, .data memory is somewhat more expensive than .text or .rodata.
I think we should try to start with just optimizing the same cases that (*InitSchedule).staticassign can handle, since that should handle the example of package unicode.

I just realized that my explanation code above was not ideal and var _GlobalMapValues =[...]{Var1, Var2, ...} can be scoped local to the init function.


Updated featureCounts biotypes commands.

Updated the biotype summary results. Removed grep for rRNA so that we get all biotypes. Stopped copying entire biotype results file.

👍


z-index of drawer does not work properly

The Drawer has higher z-index, but it shows behind other elements. Having this issue in all browser

[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Drawer is in front of other elements
Current Behavior
Drawer is behind other elements

I fixed it by increase z-index of the panel contain the button to trigger open the drawer. It works now


Removing RTs?

Is this script meant to remove RTs, or is that a function that is not yet built in OR that has to be toggled somewhere?
Apologies if this is not the correct way to do this. It is exactly my second post on a GitHub thing. Thank you for the script, though. It is beautiful.

Is this script meant to remove RTs, or is that a function that is not yet built in OR that has to be toggled somewhere?
Apologies if this is not the correct way to do this. It is exactly my second post on a GitHub thing. Thank you for the script, though. It is beautiful.

explained here :
https://github.com/Lyfhael/DeleteTweets#filtering--options

Edit 29/08/2023, you can now choose to also unretweet or not, by changing the "unretweet" property in the delete_options variable. Set it to true if you want to unretweet. It combines with the other filters.


/v1/regard-updated-approval-status , data not removed completely from config file for approval-status=BARRED

Fixes #420

Reviewer is @PrathibaJee


Refactor factory seeds

After reflecting on my approach today, I realized it might have not been the best way to structure the API. I think making the top level data type for factorySeeds an array makes it much easier to understand. And the factory name is now just a property included on the individual item objects.
Essentially what was originally this:
    factorySeeds: {
      user: [
        { traits: [{ name: "John Doe" }] },
        { traits: [{ name: "Luke Skywalker" }] },
        { traits: [], count: 4 },
      ],
      address: [
        { traits: ['withRecipient'] },
      ],
    },

now becomes:
    factorySeeds: [
      { factory: "user", traits: [{ name: "John Doe" }] },
      { factory: "user", traits: [{ name: "Luke Skywalker" }] },
      { factory: "user", traits: [], count: 4 },
      { factory: "address", traits: ['withRecipient] }
    ]

This makes it less silly to make an item with no traits which currently would be made by just adding an empty object as an item:
  factorySeeds: {
    user: [
      {}
    ]
  }

I think this is silly and was an oversight on my part. Instead this would become:
  factorySeeds: [
    { factory: 'user' }
  ]

I think this is more clear. If you agree, feel free to merge 😄 If you like the current way then that is also acceptable of course, and feel free to close this PR.

I think this makes sense. I'll add another PR for this. Thanks for your input!