Recursive Json.Decode.Decoder types cause temp._0 is not a function runtime error

I'm playing around with Json.Decoder trying to build a generic decoder which produces union types of any possible JSON value, and something about the recursive nature of the decoder is causing a runtime error when attempting to decode object or array values:
http://share-elm.com/sprout/55d556ece4b06aacf0e8c185
https://gist.github.com/jamesmacaulay/ea28b7fdb108d53ddeb7
Introducing some kind of indirection can allow the decoder to work correctly with object values at one level of nesting, but some variations of nested objects and arrays always seems to cause trouble.
I might not be doing this all quite right, but I'm working under the assumption that any runtime error in Elm is a bug ;)
I have a feeling this may actually be a problem with the compiler, but I can't easily think of how I might be able to reproduce it in another situation with other types and functions.

It's this issue, isn't it? See the list of related issues referencing that one over there, for similar errors in different situations.

You might very well be right, I hadn't seen that issue. I don't fully understand the root causes of that issue; however, the indirection I'm introducing makes it so that the top-level decoder is only referenced by the object and array decoders within a function that is only be invoked when needed...I would have thought that this would get around any recursive definition issues. What are the constraints on recursion in Elm?

I'm not actually sure it is exactly the same as the linked issue. It just struck me as likely in view of the similarity to other examples of something like this I've seen (with parser combinators). Also, I hadn't seen that your final example code actually "protects" all the recursive occurrences under lambdas.
It does, so one might expect there to not be any problems. Nevertheless, it could still be the same root issue. Whether you run into the undefinedness depends on when stuff gets run. At initialization time of the module? Or only later? Maybe your Js.dict (Js.succeed True) `Js.andThen` (\_ -> stuff-to-protect) is not actually effective enough in terms of providing protection by delaying evaluation. Since Js.succeed does not consume any input, it (and then also the dangerous stuff) might run at module initialization time all the same as if you had directly written stuff-to-protect at top-level.
Inspecting the generated JavaScript might help.

Changing your example slightly by making object and array be functions with a () argument (see here) leads again to an undefinedness error, and the relevant JavaScript is:
   var decoder = $Json$Decode.oneOf(_L.fromArray([object({ctor: "_Tuple0"})
                                                 ,array({ctor: "_Tuple0"})
                                                 ,string
                                                 ,$int
                                                 ,$float
                                                 ,bool
                                                 ,$null]));
   var array = function (_v4) {
      return function () {
         switch (_v4.ctor)
         {case "_Tuple0":
            return A2($Json$Decode.andThen,
              $Json$Decode.array($Json$Decode.succeed(true)),
              function (_v6) {
                 return function () {
                    return $Json$Decode.map(Array)($Json$Decode.array(decoder));
                 }();
              });}
         _U.badCase($moduleName,
         "on line 57, column 3 to 82");
      }();
   };

The problem here is obvious: decoder is not a function, just a variable whose value is to be computed at module initialization time. But that computation depends on the array function, which is introduced only afterwards.
Some of the discussion in some of the many issues referenced at the end of this was precisely about order of introducing top-level definitions (and about separating declaration and initialization of variables, first introducing some stub that is later overwritten but effectively prevents undefinedness errors at module loading...). Here, if array came before decoder (in the JavaScript), the runtime error would not have occurred. Maybe your original example has the same cause for failure.
(Oh, and of course, since the above JavaScript was taken from what http://share-elm.com spit out, it is not clear whether it accurately reflects what the newest version of elm-compiler does.)

This was the discussion I was referring to: https://github.com/elm-lang/elm-compiler/issues/999.

Unsurprisingly, making also decoder be a function with a dummy () argument lets your program work as desired: see here. Your previous protection against recursive dependencies was not pervasive enough: The expression Js.dict (Js.succeed True) `Js.andThen` (\_ -> stuff-to-protect)`  is indeed strictly depending on stuff-to-protect, despite that (\_ ->.
I'm reasonably certain now that what you ran into here is indeed just another instance of https://github.com/elm-lang/elm-compiler/issues/873.
I guess you have the following options:
a) Wait until that issue is fixed and hope the fix is general enough to cover your case.
b) Introduce dummy arguments by hand, relatively pervasively.
c) Try to get something like the recursively-combinator from https://github.com/Dandandan/parser into Json.Decode.

Ah, interesting! I had previously gone down that path of making those functions take a () argument, but without also using the andThen trick, so it just ended up blowing the stack.
This solves my problem perfectly, I can define the ()-taking functions privately and only expose single instances of e.g. decoder = buildDecoder () outside the module.
I'll let @evancz or someone else decide if this issue should be left open for the sake of tracking the runtime error. I still don't completely understand if this is something that Json.Decode "should" be able to do without this workaround.
Thanks!

Also I will check out that other parser combinator library as well, thanks for the pointer.

Thank you for working through this together! I'm going to close this one and add it to the compiler issue @jvoigtlaender pointed out. I will make an explicit list of issues we need to revisit after we do that fix, so we can confirm that it covers all the cases.
So I'm going to close this for now, and we will reopen if it is not solved when we do the revisit.

@jamesmacaulay have you actually implemented a work around for your general json decoder, because we would be really interested in how you did it?

@awalterschulze I updated the gist with some code that I haven't tried in a while now but I think it does work:
https://gist.github.com/jamesmacaulay/ea28b7fdb108d53ddeb7#file-anydecoderfixed-elm

Thank you very much :)

I actually ran into this identical issue too yesterday. Thanks for sharing the solution @jamesmacaulay.
@evancz Having a generic decoder like this seems like it would be a fairly useful "out of the box" addition to Json. It's quite reusable.

@noprompt Did @jamesmacaulay's solution work for you under (presumably) 0.16.0? I've got a similar issue and it doesn't seem to be working for me.

@zachmay I can verify this works correctly (see here). Everything is effectively the same except for stylistic and naming differences (which were present before I discovered @jamesmacaulay's solution).

Had the same issue, this is pretty hard to debug


Restart of completed pod or  job when i launch helm upgrade

In my Helm chart, i deploy a pod that is completed once the script related is terminated. I could also used a K8s job for my use-case.
I need that my pod (or job) is restarted when i launch a Helm upgrade. So the annotation added in my pod don't work...
The only solution that i found is the post-upgrade Hook usage in my pod.
As indicated in the Hook documentation :
If the resource is a Job or Pod kind, Helm will wait until it successfully runs to completion. And if the hook fails, the release will fail. This is a blocking operation, so the Helm client will pause while the Job is run.
The pod restart works, but I would like Helm will not wait until it successfully runs to completion because the Chart will deployed from GUI MarketPlace. The treatment can be long..
Is it possible to avoid this pause with hook usage? Or without Hook usage, do you known how i could restart my pod when i launch Helm upgrade?
Output of helm version:
version.BuildInfo{Version:"v3.7+unreleased", GitCommit:"8ca401398d8b6dfd41b46f446abcd5285e219829", GitTreeState:"clean", GoVersion:"go1.17.3"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v0.21.0-beta.1", GitCommit:"88e7eba36ac7cc026d064bb6e4a988acc18a144e", GitTreeState:"clean", BuildDate:"2021-11-04T19:40:22Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.11", GitCommit:"27522a29febbcc4badac257763044d0d90c11abd", GitTreeState:"clean", BuildDate:"2021-09-15T19:16:25Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): Rancher 2.5

Please refer to “automatically roll deployments” under the Chart Tips and Tricks Guide.
https://helm.sh/docs/howto/charts_tips_and_tricks/

@bacongobbler I tried to use “automatically roll deployments” feature but it doesn't work with pod/job because the pod/job is stopped, completed. It works with a pod running but maybe not with a pod stopped.
What do you think?

Jobs aren't re-run if their definition is changed. What if you use generateName instead to ensure a new job is created with each helm upgrade?

generateName doesn't work on Helm. It seems not supported.
But as indicated  https://github.com/helm/helm/issues/3348  i added {{ .Release.Revision }} in my job name and it works !!
Thanks for your help.


DAC

Closing this issue to track in the book instead. Please refer to https://github.com/rust-embedded/discovery/issues/231 for more information.


Add support for attaching Azure Container Registries

Hi we would like to attach an ACR isntance to a cluster, both at creation time or as an update as per these docs.
It would be nice if the module would support both these use cases:

Create a new AKS cluster with ACR integration

# set this to the name of your Azure Container Registry.  It must be globally unique
MYACR=myContainerRegistry

# Run the following line to create an Azure Container Registry if you do not already have one
az acr create -n $MYACR -g myContainerRegistryResourceGroup --sku basic

# Create an AKS cluster with ACR integration
az aks create -n myAKSCluster -g myResourceGroup --generate-ssh-keys --attach-acr $MYACR

Configure ACR integration for existing AKS clusters

az aks update -n myAKSCluster -g myResourceGroup --attach-acr <acr-name>

I've recently seen an uptick in ACR usage so this might be something you would want to prioritize. I haven't checked if the terraform provider already supports this.

This feature has been implemented by #298 so I'm closing this issue now, please feel free to reopen it if you have any further question, thanks!


Prepare Contributor guides to be readable directly in GitHub

Per https://github.com/Qiskit/documentation/issues/24#issuecomment-1795506848, we are proposing for these 3 files to ~solely live as Markdown files~ simply live in the Qiskit repo, rather than being in the docs. That complies with normal open source expectations.
https://github.com/Qiskit/qiskit/blob/main/docs/maintainers_guide.rst
https://github.com/Qiskit/qiskit/blob/main/docs/deprecation_policy.rst
https://github.com/Qiskit/qiskit/blob/main/docs/contributing_to_qiskit.rst
~Still, we need to convert them from RST to MD (not MDX) so that they render more usefully in GitHub rich preview. We can use Myst's converter: https://rst-to-myst.readthedocs.io/en/latest/cli.html#rst2myst-convert, but we need to check if there are any Sphinx-isms.~
It's fine if we keep the files in RST, or we could also rewrite to Markdown. The important thing is that the rich preview in GitHub can render everything. Right now we have some Sphinx-isms like :ref:.

@javabster thanks for opening https://github.com/Qiskit/qiskit/pull/11218 and https://github.com/Qiskit/qiskit/pull/11217!!
Where will we point to these markdown guides from in the quantum.ibm.com docs, if it all? I think it'd probably be good to have a small Conributing part of our docs that simply links out to these new guides.


Input range breaks vaul on chromium and differently on safari

Expected behaviour:

user opens drawer
user can interact with input[type=range] the same as outside of the drawer

Actual behaviour:
(on chromium):

user opens drawer
user grabs input-range
while grabbing range input whole drawer is moving down/out of the screen

(on safari):

users open drawer
user grab input thumb to change it's value
after grabbing range input it fires onChange when hovering mouse over the input thumb
user cannot just hover over the input without changing it's value

Minimal sandbox:
https://codesandbox.io/p/sandbox/vaul-safari-range-input-mcm5sk
Minimal code:
       <Drawer.Root>
          <Drawer.Trigger>Open Drawer</Drawer.Trigger>
          <Drawer.Portal>
            <Drawer.Content>

Content

              <input type="range" min={0} max={100} />
            </Drawer.Content>
            <Drawer.Overlay />
          </Drawer.Portal>
        </Drawer.Root>

Recordings:
https://github.com/emilkowalski/vaul/assets/37555757/20a8f263-cdcc-468b-bb3b-d596e499b241
https://github.com/emilkowalski/vaul/assets/37555757/9abbdc82-dd23-468b-a6fd-c1b9c0e216ae

Chrome  gif
Safari gif

You can add data-vaul-no-drag that should prevent dragging. See this example.


Change the german translation of "Cancel"

"Stornieren" is more often used when cancelling invoices, not as a general term for cancelling a process or something.
I think "Abbrechen" is a more commonly used term.
(I was wondering where "Stornieren" came from in the project I was working on!)

Thank you for catching that.


Refactoring/Improvement for File Storage Handling

Proposed Changes

Add a file storage helper class to improve code organization and eliminate redundancy.
Evaluate the ProfileController and make adjustments to use the file storage helper consistently and efficiently.
Add Docker volume for file storage in order for the files to persist in the event of a server failure.

Benefits

Improved code maintainability and organization.
Enhanced file storage capabilities and consistency throughout the project.

https://github.com/awaazo/awaazo/assets/46968018/a7ebdce5-6f21-4337-8cf4-3d18571b4558


Added link to documentation (readthedocs.org) in README

Added a link to the documentation (readthedocs.org) in the README file.
Will make it easier for people to find the docs.

Never mind the many commits – it's only the added link that is changed (commit #3), the others were reverted.

https://twitter.com/robconery/status/725160602419650560

aw :)


Change title to "List of pipeline topologies"

@jasonxian-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@jasonxian-msft: I'm sorry - only the author of this article, @Juliako, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#label:"aq-pr-triaged"

@juliako Could you review the proposed changes to your article? Thanks!

#sign-off


[Http] PSR-7 contract violation

spec
// MessageInterface.php

/**
 * Retrieves all message header values.
 *
 * The keys represent the header name as it will be sent over the wire, and
 * each value is an array of strings associated with the header.
 *
 *     // Represent the headers as a string
 *     foreach ($message->getHeaders() as $name => $values) {
 *         echo $name . ": " . implode(", ", $values);
 *     }
 *
 *     // Emit headers iteratively:
 *     foreach ($message->getHeaders() as $name => $values) {
 *         foreach ($values as $value) {
 *             header(sprintf('%s: %s', $name, $value), false);
 *         }
 *     }
 *
 * While header names are not case-sensitive, getHeaders() will preserve the
 * exact case in which headers were originally specified.
 *
 * @return string[][] Returns an associative array of the message's headers. Each
 *     key MUST be a header name, and each value MUST be an array of strings
 *     for that header.
 */
public function getHeaders();

problem
Slim initializes its environment by feeding it the raw $_SERVER superglobal. Later in the request lifecycle, this environment is used to create the headers array for the request object. Unfortunately, when running under a FastCGI execution environment the headers sent by the client are in the format of 'HTTP_FOO_BAR' instead of the original 'Foo-Bar', which violates the PSR-7 contract.

ferfuxsake why do you care?
I am the author of an HMAC HTTP authentication library that aims to work out of the box with any PSR-7 implementation, so in my use case the whole spec is a very hard dependency. I found out this problem while developing and testing a Slim middleware for Psr7Hmac.

I think I could manage a PR for that, just need to know the proper branch to submit it :)

@1ma 3.x

Presto.

I thought I saw a PSR-7 compliance test suite somewhere. This may help with that too.

https://github.com/php-http/psr7-integration-tests

Fixed for Slim 4 in https://github.com/slimphp/Slim-Http/pull/26


Running build.sh deploy results in Error.

So I found out what the  must look like:
arn:aws:lambda:us-east-1:126707828112:function:name-tocall-mylambdafn
At the command line, $ ./build.sh deploy <role-arn> , it returns the following message:
You must set environment variable AWS_REGION to continue.
Fine. I edited build.sh and set that variable, and run it again.
Checking for an existing version of this function in AWS Lambda...

An error occurred (ResourceNotFoundException) when calling the GetFunction operation: Function not found: arn:aws:lambda:us-east-1:126707828112:function:RedshiftUtilsSnapshotManager

An error occurred (ValidationException) when calling the CreateFunction operation: 1 validation error detected: Value 'lambda_basic_vpc_exec' at 'role' failed to satisfy constraint: Member must satisfy regular expression pattern: arn:(aws[a-zA-Z-]*)?:iam::\d{12}:role/?[a-zA-Z_0-9+=,.@\-_/]+

What do I have to change to get this basically working? New to this.

Can you please provide the full syntax you used to call the script? It looks like when you called this you provided the IAM role name instead of the role ARN. You can get this on the top of the IAM Role page.

Hi @IanMeyers
Here is the full syntax
$ ./build.sh deploy lambda_basic_vpc_exec arn:aws:lambda:us-east-1:126707828112:function:name-tocall-mylambdafn
I  "lambda_basic_vpc_exec" is the role.

OK - instead try:
./build.sh deploy arn:aws:lambda:us-east-1:126707828112:function:name-tocall-mylambdafn schedule <my scheduling config file>

what is the  ?
I have not done anything to have this and perhaps this may be the problem? Is it looking for a JSON file? If so, is this the every-2-hours-.json file ?

You need to include a schedule definition, which I noted above as <my scheduling config file>. If you are happy for the module to run every 2 hours, then this file may be right, but you also need to specify the retention period. Depending where you are in the world, I may be able to do a screen share to walk you through getting all of this setup - can you email<EMAIL_ADDRESS>and we'll see if there's anything else you need?

I am happy for the module to run every 2 hours just to test things out. Sorry, I have no clue how to further configure from here on so any help will be very much appreciated. I'm based in London, UK., and please tell me how can we screen share and walk me through this config stage to get a working example?

Sure, no problem. You'll just need a new file that specifies the properties for snapshots you desire:
{
	"targetResource":"energy-demo",
	"region":"eu-west-1",
	"namespace":"every-2-hours",
	"snapshotIntervalHours":2,
	"snapshotRetentionDays":1
}

targetResource is the name of the cluster that you want to control - you can manage many clusters with one configuration
region is the AWS region where the cluster resides
namespace allows you to uniquely identify the schedule
snapshotIntervalHours specifies how often you want snapshots taken, which define your Recovery Point Objective
snapshotRetentionDays specifies how many days worth of snapshots to retain, which will affect the cost of the overall snapshot storage.

Hi Ian,
That properties file is the every-2-hours.json file in
.../amazon-redshift-utils/src/SnapshotManager
We can use the original file, or another one I have created that points to
a specific Redshift cluster for "targetResource".
Let me know when we can begin.
Kind regards,
Danny Teok
Tel: +44<PHONE_NUMBER> (All day)
t: @dantvli
in: goo.gl/z9oS5P
g+:
On Mon, Feb 26, 2018 at 4:56 PM, IanMeyers<EMAIL_ADDRESS>wrote:

Sure, no problem. You'll just need a new file that specifies the
properties for snapshots you desire:
{
"targetResource":"energy-demo",
"region":"eu-west-1",
"namespace":"every-2-hours",
"snapshotIntervalHours":2,
"snapshotRetentionDays":1
}

targetResource is the name of the cluster that you want to control -
you can manage many clusters with one configuration
region is the AWS region where the cluster resides
namespace allows you to uniquely identify the schedule
snapshotIntervalHours specifies how often you want snapshots taken,
which define your Recovery Point Objective
snapshotRetentionDays specifies how many days worth of snapshots to
retain, which will affect the cost of the overall snapshot storage.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/amazon-redshift-utils/issues/270#issuecomment-368570536,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASUt_tkApS3lR2uskJ6qWyx-PyR8GZh8ks5tYuJPgaJpZM4STfX3
.

Hi!
I think I must also mention that I'm doing this on a brand new EC2 instance running Ubuntu 16.04 LTS. The only things I have set up are:
Boto3
Shortuuid, and
Amazon-Redshift-Utils
I have tried running the following but it still failed:
./build.sh deploy arn:aws:lambda:us-east-1:126707828112:function:name-tocall-mylambdafn schedule every-2-hours.json
Since this is a Node.js handler, is it necessary to pre-configure some things related to this in my new environment? Any other ideas?

In the main source directory you should also run npm install.

I've just done that.

├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

OK - what's the failure message you are getting?

running npm install was successful. That was the output.
what's next?

Hello - sorry for the delay in coming back to you. The good news is that you can now use the internal deploy.yaml to deploy the module, rather than using the build script. This was clearly too complicated and involved too many steps. Now, you should just be able to click the deploy stack button for the correct region in Snapshot Manager's README.md, and not have to use the build and deploy script at all.

Awesome! I'll try it out and revert.
By the way, do I have to revert everything to original or it's okay to continue from where I have left it -- npm install ?

No installation should be required, and what you've done shouldn't interfere with a deployment.

SnapshotManager is now deprecated. Closing this issue as no longer relevant.


Rebuild, upgrade and simplify example: with-firebase-hosting[-and-typescript]

As I tried to use the with-firebase-hosting-and-typescript example and did not work out of the box for me, I learned about firebase (which I never used before) and modified the example ending up to a simple and straightforward setup.
Benefits/changes in a glance

Upgraded firebase-* packages
Simpler (and more flat) folder structure
Simple setup, minimum customization for firebase-hosting integration (clearly mentioned in README)
Simple TS support
Using Node 10 firebase function (latest supported) instead of Node 8

Alongside the reviewers, maybe @jthegedus can also have a look!

Stats from current PR

Default Server Mode

General

zeit/next.js canary
hossam-magdy/next.js canary
Change

buildDuration
8.9s
8.8s
-172ms

nodeModulesSize
47.7 MB
47.7 MB
✓

Client Bundles (main, webpack, commons)

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.js gzip
6.25 kB
6.25 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..3f64.js gzip
10.2 kB
10.2 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
56.4 kB
56.4 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.module.js gzip
4.78 kB
4.78 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.82 kB
6.82 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.5 kB
51.5 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
hossam-magdy/next.js canary
Change

polyfills-HASH.js gzip
26.3 kB
26.3 kB
✓

Overall change
26.3 kB
26.3 kB
✓

Client Pages

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.js gzip
1.24 kB
1.24 kB
✓

_error.js gzip
3.15 kB
3.15 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
2.03 kB
2.03 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.86 kB
7.86 kB
✓

Client Pages Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.module.js gzip
594 B
594 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.28 kB
5.28 kB
✓

Client Build Manifests

zeit/next.js canary
hossam-magdy/next.js canary
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Rendered Page Sizes

zeit/next.js canary
hossam-magdy/next.js canary
Change

index.html gzip
918 B
918 B
✓

link.html gzip
927 B
927 B
✓

withRouter.html gzip
914 B
914 B
✓

Overall change
2.76 kB
2.76 kB
✓

Serverless Mode (Increase detected ⚠)

General

zeit/next.js canary
hossam-magdy/next.js canary
Change

buildDuration
9.5s
9.7s
⚠ +163ms

nodeModulesSize
47.7 MB
47.7 MB
✓

Client Bundles (main, webpack, commons)

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.js gzip
6.25 kB
6.25 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..3f64.js gzip
10.2 kB
10.2 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
56.4 kB
56.4 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.module.js gzip
4.78 kB
4.78 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.82 kB
6.82 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.5 kB
51.5 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
hossam-magdy/next.js canary
Change

polyfills-HASH.js gzip
26.3 kB
26.3 kB
✓

Overall change
26.3 kB
26.3 kB
✓

Client Pages

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.js gzip
1.24 kB
1.24 kB
✓

_error.js gzip
3.15 kB
3.15 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
2.03 kB
2.03 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.86 kB
7.86 kB
✓

Client Pages Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.module.js gzip
594 B
594 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.28 kB
5.28 kB
✓

Client Build Manifests

zeit/next.js canary
hossam-magdy/next.js canary
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Serverless bundles Overall increase ⚠

zeit/next.js canary
hossam-magdy/next.js canary
Change

_error.js gzip
233 kB
233 kB
⚠ +57 B

404.html gzip
1.32 kB
1.32 kB
✓

hooks.html gzip
957 B
957 B
✓

index.js gzip
233 kB
233 kB
⚠ +84 B

link.js gzip
243 kB
243 kB
⚠ +215 B

routerDirect.js gzip
241 kB
241 kB
-107 B

withRouter.js gzip
241 kB
241 kB
⚠ +300 B

Overall change
1.19 MB
1.19 MB
⚠ +549 B

Stats from current PR

Default Server Mode

General

zeit/next.js canary
hossam-magdy/next.js canary
Change

buildDuration
9.6s
9.3s
-297ms

nodeModulesSize
47.7 MB
47.7 MB
✓

Client Bundles (main, webpack, commons)

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.js gzip
6.25 kB
6.25 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..3f64.js gzip
10.2 kB
10.2 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
56.4 kB
56.4 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.module.js gzip
4.78 kB
4.78 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.82 kB
6.82 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.5 kB
51.5 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
hossam-magdy/next.js canary
Change

polyfills-HASH.js gzip
26.3 kB
26.3 kB
✓

Overall change
26.3 kB
26.3 kB
✓

Client Pages

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.js gzip
1.24 kB
1.24 kB
✓

_error.js gzip
3.15 kB
3.15 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
2.03 kB
2.03 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.86 kB
7.86 kB
✓

Client Pages Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.module.js gzip
594 B
594 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.28 kB
5.28 kB
✓

Client Build Manifests

zeit/next.js canary
hossam-magdy/next.js canary
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Rendered Page Sizes

zeit/next.js canary
hossam-magdy/next.js canary
Change

index.html gzip
918 B
918 B
✓

link.html gzip
927 B
927 B
✓

withRouter.html gzip
914 B
914 B
✓

Overall change
2.76 kB
2.76 kB
✓

Serverless Mode (Increase detected ⚠)

General

zeit/next.js canary
hossam-magdy/next.js canary
Change

buildDuration
9.6s
10.2s
⚠ +577ms

nodeModulesSize
47.7 MB
47.7 MB
✓

Client Bundles (main, webpack, commons)

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.js gzip
6.25 kB
6.25 kB
✓

webpack-HASH.js gzip
746 B
746 B
✓

de003c3a9d30..3f64.js gzip
10.2 kB
10.2 kB
✓

framework.HASH.js gzip
39.1 kB
39.1 kB
✓

Overall change
56.4 kB
56.4 kB
✓

Client Bundles (main, webpack, commons) Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

main-HASH.module.js gzip
4.78 kB
4.78 kB
✓

webpack-HASH..dule.js gzip
746 B
746 B
✓

de003c3a9d30..dule.js gzip
6.82 kB
6.82 kB
✓

framework.HA..dule.js gzip
39.1 kB
39.1 kB
✓

Overall change
51.5 kB
51.5 kB
✓

Legacy Client Bundles (polyfills)

zeit/next.js canary
hossam-magdy/next.js canary
Change

polyfills-HASH.js gzip
26.3 kB
26.3 kB
✓

Overall change
26.3 kB
26.3 kB
✓

Client Pages

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.js gzip
1.24 kB
1.24 kB
✓

_error.js gzip
3.15 kB
3.15 kB
✓

hooks.js gzip
664 B
664 B
✓

index.js gzip
222 B
222 B
✓

link.js gzip
2.03 kB
2.03 kB
✓

routerDirect.js gzip
279 B
279 B
✓

withRouter.js gzip
278 B
278 B
✓

Overall change
7.86 kB
7.86 kB
✓

Client Pages Modern

zeit/next.js canary
hossam-magdy/next.js canary
Change

_app.module.js gzip
594 B
594 B
✓

_error.module.js gzip
2.08 kB
2.08 kB
✓

hooks.module.js gzip
370 B
370 B
✓

index.module.js gzip
212 B
212 B
✓

link.module.js gzip
1.48 kB
1.48 kB
✓

routerDirect..dule.js gzip
271 B
271 B
✓

withRouter.m..dule.js gzip
270 B
270 B
✓

Overall change
5.28 kB
5.28 kB
✓

Client Build Manifests

zeit/next.js canary
hossam-magdy/next.js canary
Change

_buildManifest.js gzip
61 B
61 B
✓

_buildManife..dule.js gzip
61 B
61 B
✓

Overall change
122 B
122 B
✓

Serverless bundles Overall increase ⚠

zeit/next.js canary
hossam-magdy/next.js canary
Change

_error.js gzip
233 kB
233 kB
⚠ +226 B

404.html gzip
1.32 kB
1.32 kB
✓

hooks.html gzip
957 B
957 B
✓

index.js gzip
233 kB
233 kB
-17 B

link.js gzip
243 kB
243 kB
⚠ +22 B

routerDirect.js gzip
241 kB
241 kB
⚠ +35 B

withRouter.js gzip
241 kB
241 kB
-208 B

Overall change
1.19 MB
1.19 MB
⚠ +58 B

I will have a look today. I already have a different template I used with different folder structure over at https://github.com/jthegedus/firebase-gcp-examples . I hadn't migrated the examples here to that structure as the change in folder structure would require a lot of rework from those already using these examples. Though I do agree that the current structure is not ideal (hence why I created a different one).

@Timer @lfades @timneutkens I guess this PR can be reviewed and merged maybe, if @jthegedus doesn't have any updates!
Because I believe this template/example is much more simple and straightforward. I am using it already.

I've been playing with the latest version of nextjs and firebase and believe I have further improvements on top of the changes here. I'll raise a PR to share the ideas. I'm hesitant to push this through just because I think there's an even more simple solution.

@jthegedus sounds good... looking forward to your changes then!

Should we close this PR then? Or merge it and wait for the updates?

My updates would make as many changes. So probably just close. Up to @hossam-magdy though as his contributions are useful and valid.

I'll land this for now because I believe we see a lot of people who say the current example doesn't work. I appreciate the work that went into this PR, so we may as well land it for Git Blame credit.
Looking forward to your updates, @jthegedus!


peer To peer Review

#Hi @fickryiman
-you have done a great job implementing this project👌✔
-we kindly recomend you to add a placeholder on the email and message path.

email and message text area is not required as the figma design


Form method to pull a small sample of real PDF urls

For documentation pages and experimentation

We can skip this


Implement query_header_at_height()

Crate
relayer
Summary
Implement https://github.com/informalsystems/ibc-rs/blob/ab6cac1e3dec846b9fb5c2fee0deb6a634f0f290/relayer/src/chain.rs#L112
Problem Definition
Missing implementation. To build a MsgCreateClient the relayer needs a recent LigthtBlock.  For MsgUpdateClient we would need the get_minimal_set() but the query_header_at_height() above would be great if it's faster.
Proposal

Initially, retrieve the header using plain RPC calls
At a later stage, retrieve and verify the header via the light client

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[x] Appropriate milestone (priority) applied
[x] Appropriate contributors tagged
[x] Contributor assigned/self-assigned

Closed via #364 (see build_header() in chain.rs)


[esp32]: Use common DeviceInfoProvider implementation instead of platform specific version

Problem
What is being fixed?  Examples:

The ESP32 platform specific implementation of DeviceInfoProvider has no difference than the common one(examples/providers/DeviceInfoProvider), we should use the common implementation of this class like other platforms since  DeviceInfoProviderImpl is not platform dependent.

Currently, we call SetDiagnosticDataProvider within PaltformMgr separately on ESP32 platform. And this will cause call DiagnosticDataProvider get set up on both client and server side.

Fixes #17400

Change overview
Use common DeviceInfoProvider implementation instead of platform specific version
Please note, currently, some functions of  DeviceInfoProvider does not work since storage delegate has not been setup for DeviceInfoProvider.  This PR does not solve this issue either, it will be addressed in a separate PR.
Testing
How was this tested? (at least one bullet point required)

Confirm we can still read information from DeviceInfoProvider with this change

See #18236 (comment)

I don't think this PR is conflict with  https://github.com/project-chip/connectedhomeip/pull/18236#issuecomment-1134112446, it should use the existing common implementation of DeviceInfoProvider instead of making a copy of it and put it into platform/esp in #18236
The goal of this PR is to decouple the DeviceInfoProvider and PlatfromMgr on ESP32.


[Fix] Stats at a Glance text overlap

Overview
Currently, Stats at a Glance text overlaps in the charts.
Proposal
Format text diagonally to prevent overlap and increase legibility
Supplemental Information
Current Implementation:

Ideal Implementation:

May need to use a different library as @devexpress/dx-react-chart does not currently support text staggering/rotation


Fix StressChaos CRD

What problem does this PR solve?
legacy #515 , we should also update the crd and zz_generated.deepcopy.go
What is changed and how does it work?
Check List
Tests

Unit test
E2E test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has Go code change
Has CI related scripts change
Has Terraform scripts change

Side effects

Breaking backward compatibility

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

/run-e2e-test

Codecov Report

Merging #551 into master will decrease coverage by 5.22%.
The diff coverage is 40.84%.

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   61.39%   56.16%   -5.23%
==========================================
  Files          64       67       +3
  Lines        4069     4307     +238
==========================================
- Hits         2498     2419      -79
- Misses       1383     1717     +334
+ Partials      188      171      -17

Impacted Files
Coverage Δ

controllers/kernelchaos_controller.go
0.00% <0.00%> (ø)

controllers/podchaos/types.go
65.95% <0.00%> (ø)

controllers/stresschaos_controller.go
0.00% <0.00%> (ø)

pkg/chaosdaemon/netem_linux.go
26.66% <0.00%> (ø)

pkg/chaosdaemon/netlink_linux.go
0.00% <ø> (ø)

pkg/chaosdaemon/stress_server_linux.go
0.00% <0.00%> (ø)

pkg/utils/chaosdaemon.go
51.21% <ø> (ø)

pkg/webhook/config/config.go
17.14% <ø> (-72.86%)
:arrow_down:

pkg/webhook/config/watcher/config.go
41.66% <ø> (-58.34%)
:arrow_down:

pkg/webhook/config/watcher/util.go
75.00% <ø> (ø)

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a380075...adead70. Read the comment docs.

/merge


 without surfaceshader declaration will crash code generation (GLSL)

Issue
If you create a <surfacematerial> but don't specify the surfaceshader and try to generate code then code generation can crash when it tries to emit the function for a ShaderNode created by default for the surfaceshader input. This is due to the fact
that this node has no implementation and code tries to read through these null implementations.
Example
<?xml version="1.0"?>
<materialx version="1.38">
  <displacement name="displacement_float" type="displacementshader">
    <input name="displacement" type="float" value="0.0" />
    <input name="scale" type="float" value="1.0" />
  </displacement>
  <surfacematerial name="material_displacement_float_out" type="material">
    <input name="displacementshader" type="displacementshader" nodename="displacement_float" />
  </surfacematerial>
</materialx>

Initial Triage

All I could figure out was that a ShaderNode was being created based on the surfacematerial nodedef signature instead of just failed during initla ShaderGraph creation time. This would avoid trying to parse this node to get it's implementation later on inside the MaterialNode implementation.
Marking for GLSL only as did not test with other code generators.

Note: There are pre-checks for this in integrations but it seems that this check should exist within code-generation to not try and create a dummy surface shader as not sure what it means to have a material with no surface shader but have a displacement shader?

As of today, on main (c7f01d8), this MaterialX network can be loaded both via MaterialXGraphEditor and MaterialXView, without crashing. Should this perhaps be closed then?

Hi @madmann91 ,
I'm not sure. I don't recall if this was performed via unit tests and there was additional protection added to those apps to prevent a crash. Might be best to add this to the testsuite and run RTS first.

Although there are likely still improvements needed on the GLSL code generation side, I believe we should close this issue as we no longer have a straightforward repro case.  Feel free to write up a new issue if we encounter this again in the future.


Grant-CsTeamsChannelsPolicy' is not recognized as the name of a cmdlet

I get this error when executing
The term 'Grant-CsTeamsChannelsPolicy' is not recognized as the name of a cmdlet, function, script file or program
executable. Please check if you spelled the name correctly or if you included a path, check that the path is correct and try again.
My script
$GroupName = "Permitir_crear_grupos"
$PolicyName = "Docentes"
$credential = Get-Credential
Connect-AzureAD -Credential $credential
Import-Module MicrosoftTeams
Connect-MicrosoftTeams -Credential $credential
$group = Get-AzureADGroup -SearchString $GroupName
$members = Get-AzureADGroupMember -ObjectId $group.ObjectId -All $true | Where-Object {$.ObjectType -eq "User"}
$members | ForEach-Object { Grant-CsTeamsChannelsPolicy -PolicyName $PolicyName -Identity $.UserPrincipalName}

@desarrollocdb thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Supplementary material?

Thanks for the code. Was wondering if you code also post the supplementary material for reference as well.

I got the same question since there is no supplementary material on the arxiv.

Please find the supplementary materials on our project page.


Removes obsolete condition for currency factor

1. Why is this change necessary?
It isn't. Just cleans up some obsolete code.
2. What does this change do, exactly?
Removes a condition that checks the variable $factor for 0. But in this condition it is already checked and if it is 0 it falls back to 1. Therefore it can never be 0 here.
3. Describe each step to reproduce the issue or behaviour.
None.
4. Please link to the relevant issues (if any).
None.
5. Which documentation changes (if any) need to be made because of this PR?
None.
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hey @jkrzefski,
can you add a test case for sAddVoucher with currency factor?

@shopwareBot I will take a look at it soon.

Hey @jkrzefski,
are you still on it?

@shyim Yeah, I was a bit busy the last week. But I'll look into this over the weekend.

I have added a test for sBasket::sAddVoucher() with different currency factors. I test it with 0, .5, 1, 1.5 and 2. Let me know, if this is a sufficient implementation.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-23892
Please use this issue to track the state of your pull request.

Thanks for your Contribution!


Icon request: question mark

Request for a question-mark icon, similar to the existing "alert-circle" and "info" icons, but with a question mark inside. I see it having a very similar use to "info" but maaaaybe more applicable in non-English settings...?

agree. couldn't believe what I just saw, there really is none.


[W5][W16-3]Jitesh Khiani

Unable to update tests due to timing related feature

The amount of time a user spends using the application and the amount of commands he enters is useful information for not only the user, but also the developers because it allows us to tailor our work to our user's preferences. Good job.

Nice! To count the number of commands is very cool! You may also consider to count repeat times for each command.


Upgrade charming actions to v2.1.0 to resolve upload to charmhub issue

Issue
Release to charmhub action is failing due to a change in the way resources are uploaded to charmhub.
Solution
Upgrade the charming action to v2.1.0 which should resolve the issue
Release Notes
Upgrade charming actions to v2.1.0 to resolve upload to charmhub issue

Closing in favor of #108

Just a curiosity here.
Paulo bumped action to 2.1.1 in PR #108 but you have committed 2.1.0 only.
The release notes mentioned two fixes: #67 in 2.1.0 and  #68 in 2.1.1 (which fixes #67).
Q: Should we use here 2.1.1 too? Tnx!


Fix typo in README

Codecov Report

Merging #33 (d7aa130) into master (6dda7e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   85.45%   85.45%
=======================================
  Files           1        1
  Lines          55       55
=======================================
  Hits           47       47
  Misses          5        5
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703cefd...d7aa130. Read the comment docs.


installer: Allow selecting version to install

Adds option under "Advanced options" for release channel and version. The "More info" link opens the releases.flynn.io page for the selected channel/version. Only versions for which there is an EC2 image available are listed for AWS (all other launchers use the install script).

Closes #2287

Tested successfully in DigitalOcean.

@lmars comments addressed.


How does one get a Slack token?

Not sure how to setup the Slack side of things. I'm trying to use the "Incoming WebHooks" feature in Slack, where it generates a webhook URL, but I can't find any place to generate a token. Any tips on the Slack side of things?

Oy.  Slack has changed their advertised URLs.  You could try just using the
last hashed path segment of their advertised URL and see if that works.

Still trying to debug it, but I got further by defining slack.hook to point to the Webhook URL. From the best I can tell, this step is missing from the install docs. The test send message step now finishes silently, but I don't ever receive a message in Slack.

Yeh, no dice. When I run ssh <hostname> slack test I get a 404 from the Slack endpoint. Tried various formulations of slack.token and slack.hook without success.

Yup.  My hook keeps chugging along, but that may be because my Slack
account is older.
The fundamental issue is this LOC:
return String.format("https://%s.slack.com/services/hooks/%s?token=%s",
team.toLowerCase(), hook, token);
which apparently is invalid for newer Slack accounts.

How bad of an idea would it be to expose the format string as a config property?

PPS: My settings look something like this:
slack.team = foobar
slack.token = xoxp-2304675908-2304123785-3647258168-9268c2
slack.hook = T028YKVSQ/B02J2CNBD/bmjBGrbvKx37OBZRTR4e37oK
slack.defaultChannel = gitblit

I hope you sanitized those... if not we'll delete.  Try removing the slack.hook setting and changing  slack.token to bmjBGrbvKx37OBZRTR4e37oK.  If team is correct, it might work.

Yeh, they were sanitized. Thanks for asking.
w00t! It works!! I guess I didn't test it properly before.
Thanks so much for your help!

Followup Kudos: The information and formatting fed into Slack is absolutely fantastic. Very impressive integration on the end-user front! Dev team is very excited about it. Thanks for writing it.

Your very welcome!


[Compute] Adding dedicated host APIs and update of Gallery APIs

https://github.com/Azure/azure-rest-api-specs/pull/6400
https://github.com/Azure/azure-rest-api-specs/pull/6475/
https://github.com/Azure/azure-rest-api-specs/pull/6612

@erich-wang   I re-ran the failed tests, and they all passed.  Thanks.


[google_maps_flutter] fix crash and remove listeners

Description
Map plugins crashes when exiting app while using the FragmentActivity.
We are calling MapView.onDestroy at an inappropriate location which caused sone undefined behavior. MapView.onDestroy should only be called in the corresponding onDestroy method in from the activity or fragment. According to https://developers.google.com/android/reference/com/google/android/gms/maps/MapView#onDestroy() "You must call this method from the parent Activity/Fragment's corresponding method."
Also added some house keeping code to remove all the listeners when disposing.
Related Issues
https://github.com/flutter/flutter/issues/55406
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

LGTM, thanks

the crash seems to be something new related to google map sdk
https://stackoverflow.com/questions/61397027/androidruntime-fatal-exception-androidmapsapi-zoomtablemanager-java-lang-arra

ummm do we need a specific maps version constraint in our gradle in the meantime for our plugin?

@xster It seems to pass now (at least for my other gmap PR) Will see how this one goes.

Still LGTM


Use chrono for Datetime

Either using chrono's types directly (removing the Datetime type used right now) or providing a feature for chrono integration would be very useful. Can I make a pull request?

Nevermind, duplicate issue.


Make a Summary tab

Create a "pseudo-dimension" called "Summary" that shows up as the leftmost tab, and make it look like the attached screen shot:

The current version is getting close.  @aaronlugo please add the "Benchmark" markers to the Dimensions tab.  The Benchmark value should be 50% of the Available points for that dimension.  Benchmarks are displayed for Subdimensions.

This is done


Issues with installing tools

I'm not sure what is happening but it seems that the base switch is somehow confused:
  -> [1/2] Building ocamlformat...
ocaml-platform: [DEBUG] Running: 'opam' 'install' 'ocamlformat.0.18.0' '--yes' '-q' '--color=never' '--switch' '/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d' '--root' '/Users/thomas/.opam'
ocaml-platform: [INFO] Error in 'opam' 'install' 'ocamlformat.0.18.0' '--yes' '-q' '--color=never' '--switch' '/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d' '--root' '/Users/thomas/.opam':
[ERROR] The compilation of ocaml.4.12.2 failed at "ocaml /private/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d/_opam/share/ocaml-config/gen_ocaml_config.ml 4.12.2 ocaml".

#=== ERROR while compiling ocaml.4.12.2 =======================================#
# context              2.1.3 | macos/arm64 |  | https://opam.ocaml.org#29fbc663
# path                 /private/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d/_opam/.opam-switch/build/ocaml.4.12.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build ocaml /private/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d/_opam/share/ocaml-config/gen_ocaml_config.ml 4.12.2 ocaml
# exit-code            1
# env-file             ~/.opam/log/ocaml-25749-a4eaff.env
# output-file          ~/.opam/log/ocaml-25749-a4eaff.out
### output ###
# OCaml version mismatch: 4.14.0, expected 4.12.2

The former state can be restored with:
    /opt/homebrew/bin/opam switch import "/private/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d/_opam/.opam-switch/backup/state-20221029083723.export"
  -> [2/2] Building ocaml-lsp-server...
ocaml-platform: [DEBUG] Running: 'opam' 'install' 'ocaml-lsp-server.1.14.1' '--yes' '-q' '--color=never' '--switch' '/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d' '--root' '/Users/thomas/.opam'
ocaml-platform: [INFO] Error in 'opam' 'install' 'ocaml-lsp-server.1.14.1' '--yes' '-q' '--color=never' '--switch' '/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d' '--root' '/Users/thomas/.opam':
[ERROR] The compilation of ocaml-system.4.14.1+trunk failed at "ocaml gen_ocaml_config.ml".

#=== ERROR while compiling ocaml-system.4.14.1+trunk ==========================#
# context              2.1.3 | macos/arm64 |  | file:///Users/thomas/.opam/plugins/ocaml-platform/platform_sandbox_compiler_packages
# path                 /private/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d/_opam/.opam-switch/build/ocaml-system.4.14.1+trunk
# command              ~/.opam/opam-init/hooks/sandbox.sh build ocaml gen_ocaml_config.ml
# exit-code            1
# env-file             ~/.opam/log/ocaml-system-25924-96cb2c.env
# output-file          ~/.opam/log/ocaml-system-25924-96cb2c.out
### output ###
# ERROR: The compiler found at /opt/homebrew/bin/ocamlc has version 4.14.0,
# and this package requires 4.14.1+trunk.
# You should use e.g. 'opam switch create ocaml-system.4.14.0' instead.

ocaml-platform: [DEBUG] Running: 'opam' 'switch' 'remove' '/var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d' '--yes' '-q' '--color=never' '--root' '/Users/thomas/.opam'
ocaml-platform: [ERROR] Command 'opam install ocaml-lsp-server.1.14.1 --yes -q --color=never --switch
           /var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d
           --root /Users/thomas/.opam' failed: exited with 31
ocaml-platform: [ERROR] Command 'opam install ocamlformat.0.18.0 --yes -q --color=never --switch
           /var/folders/88/jkblgplx33db3c6606wyy7rc0000gn/T/ocaml-platform-sandbox-28211d
           --root /Users/thomas/.opam' failed: exited with 31

Also: would be nice to install the tools that installed sucessfully/were cached, even if some other tools have failed.

❯ ocaml-platform --version
3130818

I suspect that you have cached compiler packages (the modified compiler package that ocaml-platform uses for the sandbox switch) created with another version of ocaml-platform, which suffered from a wrong way of detecting the version (especially for pinned and variants compiler).
One way to test this would be to remove (or rename) the compiler cache (which is located at <opam_root>/plugins/ocaml-platform/platform_sandbox_compiler_packages) and retry. Could you do it and report if that works? (Note that you won't lose your cached tools).
However, clearly this show that we need some kind of versioning for packages (tools and compiler), to be able to fix bugs and make breaking changes later. I will open an issue dedicated to this.
Finally, you are right that it would be better to continue installing even if one build failed. I will also open an issue, to be able to close this one if the solution above worked.

This particular issue should be fixed by https://github.com/tarides/ocaml-platform-installer/pull/136. We started working on fixing this class of bugs in the future https://github.com/tarides/ocaml-platform-installer/issues/131


DCC error: invalid literal for int() with base 10

+ DCC @/vf/users/Ziegelbauer_lab/circRNADetection/circRNA_daq_v0.8.x/samples_3_032223/results/iSLK_BAC16_72hpi_R1/DCC/samplesheet.txt --temp /lscratch/61412431/9e8ae03f-5978-4f36-8fbc-5ce64779c11f/DCC --threads 32 --detect --gene --bam /vf/users/Ziegelbauer_lab/circRNADetection/circRNA_daq_v0.8.x/samples_3_032223/results/iSLK_BAC16_72hpi_R1/STAR2p/iSLK_BAC16_72hpi_R1_p2.bam -ss --annotation /vf/users/Ziegelbauer_lab/circRNADetection/circRNA_daq_v0.8.x/samples_3_032223/ref/ref.gtf --chrM -G --rep_file /data/Ziegelbauer_lab/resources/fastas_gtfs/hg38.repeats.gtf --refseq /vf/users/Ziegelbauer_lab/circRNADetection/circRNA_daq_v0.8.x/samples_3_032223/ref/ref.fa --PE-independent -mt1 @/vf/users/Ziegelbauer_lab/circRNADetection/circRNA_daq_v0.8.x/samples_3_032223/results/iSLK_BAC16_72hpi_R1/DCC/mate1.txt -mt2 @/vf/users/Ziegelbauer_lab/circRNADetection/circRNA_daq_v0.8.x/samples_3_032223/results/iSLK_BAC16_72hpi_R1/DCC/mate2.txt
[W::hts_idx_load3] The index file is older than the data file: /vf/users/Ziegelbauer_lab/circRNADetection/circRNA_daq_v0.8.x/samples_3_032223/results/iSLK_BAC16_72hpi_R1/STAR2p/iSLK_BAC16_72hpi_R1_p2.bam.csi
Traceback (most recent call last):
  File "/data/CCBR_Pipeliner/db/PipeDB/Conda/envs/DCC/bin/DCC", line 11, in <module>
    load_entry_point('DCC==0.5.0', 'console_scripts', 'DCC')()
  File "build/bdist.linux-x86_64/egg/DCC/main.py", line 492, in main
  File "build/bdist.linux-x86_64/egg/DCC/main.py", line 680, in findCircSkipJunction
  File "build/bdist.linux-x86_64/egg/DCC/Circ_nonCirc_Exon_Match.py", line 281, in findcircAdjacent
  File "build/bdist.linux-x86_64/egg/DCC/Circ_nonCirc_Exon_Match.py", line 222, in getAdjacent
ValueError: invalid literal for int() with base 10: '127997-129368_transcript_1'

Total: 34
completed: 23
failed: 11

All 11 have the same error:
ValueError: invalid literal for int() with base 10: '127997-129368_transcript_1'

This could be because of note key in the ref.gtf for the last gene on the virus. The value of note also has a ; which is the key-value pair delimiter in GTF. May be need to use the ref.fixed.gtf which are originally generated for nclscan. Here is the same line in ref.gtf
NC_009333.1	RefSeq	transcript	127997	129368	.	+	.	gene_id "NC_009333.1:127997-129368"; gene_name "NC_009333.1:127997-129368"; transcript_id "NC_009333.1:127997-129368_transcript_1"; transcript_name "NC_009333.1:127997-129368_transcript_1"; gbkey "mRNA"; note "K14, ORF74; polyA_site not reported"; gene_biotype "mRNA"; transcript_type "mRNA";

and ref.fixed.gtf:
NC_009333.1	RefSeq	transcript	127997	129368	.	+	.	transcript_type "mRNA"; gene_id "NC_009333.1:127997-129368"; gbkey "mRNA"; transcript_name "NC_009333.1:127997-129368_transcript_1"; gene_biotype "mRNA"; transcript_id "NC_009333.1:127997-129368_transcript_1"; gene_name "NC_009333.1:127997-129368";

Testing if error disappears if we use ref.fixed.gtf for running DCC

Error disappears! ... Need to force the use of ref.fixed.gtf for all rules!!

Use commit 0a097f8 or later


Vue-ls: Storage "local" is not supported your system, use memory storage

Vue-ls: Storage "local" is not supported your system, use memory storage

Your browser does not support WebStorage
This example https://jsfiddle.net/Robin_ck/6x1akv1L/ works well


Use Swift 3.0.1

I updated the project configuration to use Swift 3.0.1.

This changes make Result unbuildable by Xcode 8.0 with following error:

“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

Are there any reason for requiring this changes?

This changes make Result unbuildable by Xcode 8.0 with following error:

Thanks @norio-nomura! Without this change, we can still build the framework with Xcode 8.1. So this should be closed I think.

Closing this with the reasoning as I said above.

I'm having trouble importing Result into a Swift 3.0.1 project, but since apparently no one else is seeing this (and because I'm not sure why I don't see it with other projects) I agree it should be closed for now. Sorry for the noise.

The reason for the pull request is that I cannot use Result as a Carthage dependency with Xcode 8.1 (8T61a) and Swift 3.0.1.
Here is a sample project demonstrating the problem:
https://www.dropbox.com/s/gjzfvkvl2czeba0/ResultWithCarthage.zip?dl=0
It is an Xcode project that only varies from the "Single View Application" iOS template as follows:

It incorporates Result as a Carthage dependency.
The "AppDelegate.swift" file includes "import Result" at the top.

To reproduce the problem:

Download the project.
Run "carthage update" from the project directory.
Try to run the project using Xcode 8.1 (8T61a) on a device or simulator.

You will see the following error:
Module compiled with Swift 3.0 cannot be imported in Swift 3.0.1.
To see the fix:

Open Cartfile and comment out this:
github "antitypical/Result" "3.0.0"
Uncomment this:
github "jbrayton/Result" "58a860424cda4742b485c412206c9efe62068c78"
Clean and run the project.

That said, I understand that Xcode 8.0 is the version available in the Mac App Store and that this does not work in Xcode 8.0. I can appreciate why it may be best to hold off on this change.
Thanks.

Oh! That works. Thank you, @ikesyo.


move integration tests out of main dub.json

which avoids dub conflicts with mir versions.

The tests are failing, but completely randomly including what looks like dub segfaulting in some cases.
It all works fine for me locally.

Done some more local tests with recent dmd and ldc versions, it all seems to work.


library can't use with 0.57 (Gradle 3)

when run debug mode console show this :

Configure project :react-native-documentscanner-android
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

I found that because newer version require permission then solve by ask for them before call it


Handle robot_unavailable errors when creating load balancers or adding targets to a load balancer

/kind feature
Describe the solution you'd like
According to the Hetzner documentation there is a possibility for the error robot_unavailable for both the operations https://docs.hetzner.cloud/#load-balancers-create-a-load-balancer and https://docs.hetzner.cloud/#load-balancer-actions-add-target.
We should implement a handling of this error code and wait for some time before we try this operation again. In this way, we prevent the controller from calling the API again and again.
We should include a condition (respectively a reason for a condition) that tracks this temporary problem for users.

I guess this is still valid.


vlive unable to extract creator

youtube-dl:master* λ python test/test_download.py TestDownload.test_VLive
[vlive] 1326: Downloading webpage
ERROR: Unable to download webpage: timed out (caused by timeout('timed out',))
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/extractor/common.py", line 358, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 1933, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 431, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 449, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/utils.py", line 719, in http_open
    req)
  File "/usr/lib/python2.7/urllib2.py", line 1200, in do_open
    r = h.getresponse(buffering=True)
  File "/usr/lib/python2.7/httplib.py", line 1131, in getresponse
    response.begin()
  File "/usr/lib/python2.7/httplib.py", line 453, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python2.7/httplib.py", line 409, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/usr/lib/python2.7/socket.py", line 480, in readline
    data = self._sock.recv(self._rbufsize)

Retrying: 1 failed tries

##########

[vlive] 1326: Downloading webpage
[vlive] 1326: Downloading JSON metadata
ERROR: unable to extract creator; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "test/test_download.py", line 141, in test_template
    force_generic_extractor=params.get('force_generic_extractor', False))
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 683, in extract_info
    self.report_error(compat_str(e), e.format_traceback())
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 543, in report_error
    self.trouble(error_message, tb)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 513, in trouble
    raise DownloadError(message, exc_info)
DownloadError: ERROR: Unable to download webpage: timed out (caused by timeout('timed out',))
Traceback (most recent call last):
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 668, in extract_info
    ie_result = ie.extract(url)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/extractor/common.py", line 319, in extract
    return self._real_extract(url)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/extractor/vlive.py", line 68, in _real_extract
    webpage, 'creator', fatal=False)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/extractor/common.py", line 624, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/extractor/common.py", line 617, in _search_regex
    self._downloader.report_warning('unable to extract %s' % _name + bug_reports_message())
  File "/home/cody/source/unsorted/youtube-dl/test/helper.py", line 236, in _report_warning
    real_warning(w)
  File "test/test_download.py", line 52, in report_warning
    raise ExtractorError(message)
ExtractorError: unable to extract creator; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

E
======================================================================
ERROR: test_VLive (__main__.TestDownload)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_download.py", line 141, in test_template
    force_generic_extractor=params.get('force_generic_extractor', False))
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 683, in extract_info
    self.report_error(compat_str(e), e.format_traceback())
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 543, in report_error
    self.trouble(error_message, tb)
  File "/home/cody/source/unsorted/youtube-dl/youtube_dl/YoutubeDL.py", line 513, in trouble
    raise DownloadError(message, exc_info)
DownloadError: ERROR: unable to extract creator; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

----------------------------------------------------------------------
Ran 1 test in 21.681s

FAILED (errors=1)

version:
youtube-dl:master* λ git log -n 1 --oneline
e0dccdd [test_YoutubeDL] PEP 8

Thanks this will be fixed in the next version.


Add Grouped time entries support

Group similar entries in the list. Same as in the current web app.

+1, this is the reason why I prefer the web app currently.


Why won't it generate json file when I run "generate_settings_file.py" as instructed ?

It generated an empty file when I first run the script, but it didn't work for a second try.


[5.9][CursorInfo] Prefer AST based results over solver based

Explanation: Solver based results are fast within a function, where the ASTContext can be re-used. But it is significantly slower than the AST based results when outside of a function. Instead of using solver based as the primary results, only use them as a fallback for when AST based fails.
Scope: Cursor info
Risk: Doesn't touch any compiler code. Low for the cursor info request itself as theAST based was previously always used. The main risk is the async and callback heavy nature of this code.
Testing: Current tests still pass (with slight modifications to actually trigger solver based to be used). Have also run ASAN and the stress tester.
Original PR: https://github.com/apple/swift/pull/65688

@swift-ci please test


Go SDK Support

Accepted :D

@marcellanz Do you have any work started on this that I could try to continue? Any piece of ready code would help me progress.


ADR-6 specify consumer name

We don't allow slash or backslash in stream names and consumer names in 2.9.

We don't allow slash or backslash in stream names and consumer names in 2.9.

So what about other filename unsafe characters? Maybe we should switch
stream-name        = term
durable-name       = term
consumer-name      = term

filename-safe      = (printable except dot, asterisk, lt, gt, colon, double-quote, fwd-slash, backslash, pipe, question-mark, ampersand)
...
stream-name        = filename-safe
durable-name       = filename-safe
consumer-name      = filename-safe

@derekcollison Which way do you want to go?  We should minimally match 2.9 validations.  If we make filename-safe then the 2.9 server allows illegal characters and implication is we should add the restrictions in a subsequent release.
Current stream and consumer validation on create is essentially (term except fwd-slash, backslash)

@derekcollison @tbeets On windows, stream creation fails for these allowed characters
Failed creating stream: 'lessthan<' io.nats.client.JetStreamApiException: error creating store for stream [10049]
Failed creating stream: 'greaterthan<' io.nats.client.JetStreamApiException: error creating store for stream [10049]
Failed creating stream: 'colon:' io.nats.client.JetStreamApiException: error creating store for stream [10049]
Failed creating stream: 'doublequote"' io.nats.client.JetStreamApiException: error creating store for stream [10049]
Failed creating stream: 'pipe|' io.nats.client.JetStreamApiException: error creating store for stream [10049]
Failed creating stream: 'question?' io.nats.client.JetStreamApiException: error creating store for stream [10049]

The server handled these, we know this is part of 2.9.0
Failed creating stream: 'fwdslash/' io.nats.client.JetStreamApiException: Stream name can not contain path separators [10128]
Failed creating stream: 'backslash\' io.nats.client.JetStreamApiException: Stream name can not contain path separators [10128]

ampersand & worked I guess is safe on windows, but maybe not on other OSes (Mac?)
On ubuntu I got this:
Failed creating stream: 'fwdslash/' io.nats.client.JetStreamApiException: Stream name can not contain path separators [10128]
Failed creating stream: 'backslash\' io.nats.client.JetStreamApiException: Stream name can not contain path separators [10128]
Created stream: 'lessthan<'
Created stream: 'greaterthan<'
Created stream: 'greaterthan<'
Created stream: 'colon:'
Created stream: 'doublequote"'
Created stream: 'pipe|'
Created stream: 'question?'
Created stream: 'ampersand&'

Waiting for someone run this on a mac.

We could add client support to check them if we feel that is a better experience. Can add in additional checks to server as well.

Will most installations have only one type of server? Probably, and most often linux servers, so as is it's probably not that much of a problem. I only wonder if other symbols that are used in shells like pipe | could be security issues. That's why it and ampersand & is on the filename-safe list. What do you think @philpennock ?
So the options are:

It's fine how it is in 2.9.0
Make it stricter on windows
Make it stricter everywhere

How many installations are actually using <, :, ", | or ? in stream names? That answer might help make the decision.

These changes simply try to reflect the current state of the server as of v2.9.0


Process ES6 as ES7 code

Hi!
I want to use ESDoc to write and generate my code documentation, I have found a problem with the following code:
// @flow
import request from './request';
import User from '../models/User';
import { BASE_URL_V2 } from '../config';

const Auth = {
  login: (username: string, password: string): Promise => {

    const options = Object.assign({}, {
      body: new User(username, password)
    });

    return request.post(`${BASE_URL_V2}auth/token/`, options).then(saveToken);
  },
  logout: () => {
    localStorage.removeItem('auth-token');
  },
  isAuthenticated: () => {}
}

/**
 * Saves the auth token to local storage
 * @param  {Object} response: Object        Response
 * @return {Object}           [description] Response
 */
function saveToken(response: Object): Object {
  if(!response || !response.token) {
    return {};
  }

  localStorage.setItem('auth-token', response.token);

  return response;
}

export default Auth;

ESDoc is reporting that could not process it since is ES7 code, I have already installed the plugin but the error persists.
My esdoc.json file:
{
  "source": "./src",
  "destination": "./esdoc",
  "plugins": [
    {"name": "esdoc-es7-plugin"}
  ],
  "test": {
    "type": "mocha",
    "source": "./test"
  }
}

Does esdoc-es7-plugin exist within your package.json file as well?

Yes

All parsing errors are treated the same. Esdoc tells you that in case you were trying to parse es7 code, you should use the es7 plugin, but in fact it has no clue what kind of code you are parsing.
I would bet that the types in your code are what's causing the problem. Do you know at what stage this feature is ? I believe it is not part of es7...

Hi @hmil those are Flow annotations, as you can see at the top of the file

Thanks for the heads up.
That is indeed what's causing the problem. ESDoc uses espree to parse the code but espree does not support flow annotations.
The only way to get around this is to change the parser with a plugin.

@hmil Thank you :)

@hmil Thank you :)

Late to the party here.. I have a fork of ESDoc that uses babylon which will parse any ES6/ES7/edge/flow, etc. To be clear though it parses the AST of course, but doesn't include any type info from flow typing into the docs produced.

Please check latest ESDoc and ECMAScript Proposal Features.


Integrate select samples

This pull request depends on #1039 so merge that one first Merged
This pull request slightly changes the analysis object's add_samples feature to bring it in line with the current sample passing convention of dict of list in form {pid: [samp1, samp2, ...], ...}
It also adds websocket-based sample selection to the studies listing page, allowing the selection of samples in real time without having to click a button.

Coverage decreased (-0.33%) to 78.72% when pulling 173a61a2e68a6d34f3aad9ca6182c2cdedf3c7ed on squirrelo:integrate-select-samples into c1fc3c891d1e645fa20bc40aa62119cc45e94a7c on biocore:cart-branch.

Ready for review

Changes Unknown when pulling 16f18affbf2026a781ac23729d8a07b52781a60d on squirrelo:integrate-select-samples into ** on biocore:cart-branch**.

Can you pull upstream master and upstream cart-branch here?

Done

Changes Unknown when pulling c96b3f24260fb9d5c2c5e919e296d86329f6a922 on squirrelo:integrate-select-samples into ** on biocore:cart-branch**.

Ready for review.

A few minor comments:
When samples are added and removed a glyphicon of a + sign and a - sign should be added correspondingly instead of the ! that's presented now.
After selecting a few samples, and I tried to create a new analysis, I got an error 405:
Time: 2015-04-15 00:19:46.381434
Message:
ERROR:
HTTP 405: Method Not Allowed
TRACE:
Traceback (most recent call last):

  File "/Users/yoshikivazquezbaeza/.virtualenvs/qiita/lib/python2.7/site-package
s/tornado/web.py", line 1141, in _when_complete
    callback()

  File "/Users/yoshikivazquezbaeza/.virtualenvs/qiita/lib/python2.7/site-package
s/tornado/web.py", line 1162, in _execute_method
    self._when_complete(method(*self.path_args, **self.path_kwargs),

  File "/Users/yoshikivazquezbaeza/.virtualenvs/qiita/lib/python2.7/site-package
s/tornado/web.py", line 183, in post
    raise HTTPError(405)

HTTPError: HTTP 405: Method Not Allowed

HTTP INFO:
body: action=create&name=asdf&description=bbbbb
files: {}
protocol: http
connection: <tornado.httpserver.HTTPConnection object at 0x109c
0d090>
uri: /analysis/2
_start_time:<PHONE_NUMBER>.31
headers: {'Origin': 'http://localhost:1111', 'Content-Length':
'41', 'Accept-Language': 'en-us', 'Accept-Encoding': 'gzip, deflate', 'Connectio
n': 'keep-alive', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0
.9,*/*;q=0.8', 'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) Ap
pleWebKit/601.1.27+ (KHTML, like Gecko) Version/8.0.5 Safari/600.5.17', 'Host':
'localhost:1111', 'Cookie': 'user=ImRlbW9AbWljcm9iaW8ubWUi|1429078385|738f95e6aa
cd8630c23d673f890e4241953b94b1', 'Referer': 'http://localhost:1111/study/list/',
 'Content-Type': 'application/x-www-form-urlencoded'}
host: localhost:1111
version: HTTP/1.1
arguments: {'action': ['create'], 'name': ['asdf'], 'descriptio
n': ['bbbbb']}
_finish_time:<PHONE_NUMBER>.35
query:
path: /analysis/2
_cookies: Set-Cookie: user=ImRlbW9AbWljcm9iaW8ubWUi|1429078385|
738f95e6aacd8630c23d673f890e4241953b94b1
method: POST
remote_ip: ::1

Info:

Any ideas?

@biocore/qiita-dev can someone else go through the code and interface? We are close to finally finish merging the cart-branch.

You can't create an analysis yet, thats what the next pull request does. Taking the incremental, possibly broken in-between steps approach since it's in it's own branch.

Changes Unknown when pulling e812bad4f7f9842d0b35faa7910527ef2de55724 on squirrelo:integrate-select-samples into ** on biocore:cart-branch**.

Got it! Just wanted to make sure.
On (Apr-15-15| 6:29), Joshua Shorenstein wrote:

You can't create an analysis yet, thats what the next pull request does. Taking the incremental, possibly broken in-between steps approach since it's in it's own branch.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/1056#issuecomment-93398603

@squirrelo :+1: the only "odd" thing that could be improved, is that if your screen has a smaller resolution that the number of studies that can be fit in the screen exceeds the space available, you won't be able to see the bootstrapalert and instead  you'll see a scroll-up/down.

Also, any updates on:

When samples are added and removed a glyphicon of a + sign and a - sign should be added correspondingly instead of the ! that's presented now.

I'll take a look at the glyph, but that's currently a hard-coded part of bootstrapAlert function. Shouldn't be blocking.

Anyone want to give this a once-over and hopefully merge?

Just a couple comments/questions. Code looks good. Need to test interface.

Found a bug, just talked to @squirrelo offline. To reproduce:

Create a test environment
log in as<EMAIL_ADDRESS>view studies
search for samp_salinity = 7.1
select all samples for the study (should be 9)
Note in PSQL that now analysis 5 (the default analysis for<EMAIL_ADDRESS>has 9 samples
clear search, hit submit
select all samples for the study again (should be 27)
Note in PSQL that now analysis 5 (the default analysis for<EMAIL_ADDRESS>has 35 samples

Something is up! This also highlights another problem: the analysis_sample table does not have a primary key defined!

Note: bug is now fixed, but we do need that primary key.

Since there are other PRs that modify the database, I think we should just add the PK in one of those other PRs so that we can minimize conflicts and delays.

Which other PR are modifying the database? (Please use labels to note that on the PR!)

@josenavas, I was informed by @squirrelo that one of your PRs is modifying the DB, but I didn't verify that personally. If that's not the case, then can we please add the PK to analysis_sample in this PR?
Confirmed that the bug appears to be fixed.

I do not see another open PR that modifies the DB, so suggest doing it here @squirrelo.
After that, :+1: to merge

I don't think I have any open PR modifying the DB. @squirrelo can you add that here?

Patch added

Build failed for no good reason that I can see, restarting

I send a few messages to gitter, but I guess that didn't make it to everyone,  most of our builds are failing for the same reason. Not sure what might be the problem.

@squirrelo please pull from upstream!

Coverage decreased (-0.39%) to 79.32% when pulling e8894958c88633fa3fae55c89e3a654ad80df8b2 on squirrelo:integrate-select-samples into 62edf7a53ca92e4e1a0fd2cc000d3f04f75b1f86 on biocore:cart-branch.


Very slow on Windows 11?

Is anyone experiencing slowness issues on Windows 11?
I'm using this from WSL2 to connect to the OpenSSH Agent, like so
# KeepassXC as SSH agent
export SSH_AUTH_SOCK=$HOME/.ssh/agent.sock

ss -a | grep -q $SSH_AUTH_SOCK
if [ $? -ne 0 ]; then
    rm -f $SSH_AUTH_SOCK
    (setsid socat UNIX-LISTEN:$SSH_AUTH_SOCK,fork EXEC:"$HOME/npiperelay/npiperelay.exe -ei -s //./pipe/openssh-ssh-agent",nofork &) >/dev/null 2>&1
fi

And it works, but it takes about 25-30 seconds for any SSH or Git-over-SSH operations.
I even tried a straight up, direct call to it.
time $HOME/npiperelay/npiperelay.exe --help

And that took 25 seconds. Everything else in the WSL2 is fast, no slowdowns that I can see, so I think it's just this npiperelay.  I've tried building it via go, and also getting it from the Releases of this repo, same problem.
I'm not famliar with ss, or socat or nipiperelay so I'm not sure how to troubleshoot this or figure out what's going wrong.

Have you followed the instructions to put the binary in the Windows file system with a soft-link from Linux? I too observed a delay of a few seconds when I tried to run it in the Linux file system, but that's Windows 10 so it might be different.

Thank you so much! You're right, that made a huge difference.  And the README even calls me out on it 😀

You may be tempted to just put the real binary directly into /usr/local/bin, but this will not work because Windows currently cannot run binaries that exist in the Linux namespace -- they have to reside somewhere under the Windows portion of the file system.

So it was working for me somehow but very slowly.  As a test, I moved the .exe to C:/Temp and created a symlink,
sudo ln -s /c/Temp/npiperelay.exe /usr/local/bin/npiperelay.exe

Then in my .bashrc
# KeepassXC as SSH agent
export SSH_AUTH_SOCK=$HOME/.ssh/agent.sock

ss -a | grep -q $SSH_AUTH_SOCK
if [ $? -ne 0 ]; then
    rm -f $SSH_AUTH_SOCK
    (setsid socat UNIX-LISTEN:$SSH_AUTH_SOCK,fork EXEC:"/usr/local/bin/npiperelay.exe -ei -s //./pipe/openssh-ssh-agent>fi

Yep it's back to regular speeds.  Thanks so much @a-m-s even if it was super obvious!


fix: typo in descriptive name for www.kubestack.com URL

Just a small typo fix.

Thank you @skoenig


cmd+backspace doesn't work for keybinding terminalFocus

VSCode Version: 1.12.2
OS Version: macOS 10.12.5

Steps to Reproduce:

The cmd+backspace key binding works fine for delete all left when edit text focused;
I added a key binding for clear all left action when terminal focused, as follows:

[
{ "key": "cmd+backspace",         "command": "deleteAllLeft",
                                     "when": "terminalFocus" }
]

Problem: the cmd+backspace doesn't work and this key binding only clear one letter as same as single backspace behavior.
Moreover, the cmd+k also doesn't work when the terminal focused, and the integrated shell is /bin/zsh.
Please let me know if more settings should be provided.

In general, the integrated terminal key binding issue refers to #11314.
But since the integrated terminal default settings support cmd+arrowkeyUp or cmd+arrowkeyDown etc., and they work perfectly. However, the cmd+k doesn't work properly, which might confuse users.

cmd+backspace is sent to the terminal shell for processing. You can send it to the vscode keybinding system (ie. keybindings.json) by adding the command (deleteAllLeft) to the terminal.integrated.commandsToSkipShell setting. However, deleteAllLeft looks like an editor shortcut so if you did that it would delete all left in the editor.
#11314 is what you're after - to be able to customize how the shell interprets your keystrokes.


hover effect after mousewheel not working until mouse move

Check that this is really a bug

[ ] I confirm

Reproduction link
https://codepen.io/brilliant-coding/pen/JjrrpoW
Bug description
If the mouse cursor is above the slider while loading - and not moving.
And then I use the mousewheel to navigate through the slider.
Slider is stopping - but the mouse hover effect is not working immediately.
Not until I move the mouse.
The problem is, the slider will be fullsize and you don't have to move the mouse before using it.
Expected Behavior
No response
Actual Behavior
No response
Swiper version
7.3.4
Platform/Target and Browser Versions
macOS Firefox, Chrome, Safari
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Sorry, but Swiper doesn't do anything with it, this is how browser handles it