[SwitchBase] Add missing parameter to docs

The onChange function signature in Switch api documentation was missing the second checked parameter.

[x] I have followed (at least) the PR section of the contributing guide.

@samuliasmala Thanks for the pull request, the argument was removed in #20342. I think that we should remove this arg in v5. @eps1lon was this the end-goal?

Changed the SwitchBase api documentation which propagates the change to both Switch and Radio components.

@samuliasmala Thanks for the pull request, the argument was removed from the documentation in #20342. I think that we should remove this argument in v5. @eps1lon was this the end-goal?

Was it removed or moved to SwitchBase?

@eps1lon was this the end-goal?

Most likely by accident (but totally intended if we decide to remove it in v5 :laughing: ). Though I'm not sure why we need the checked state as a second parameter. Seems like it's just a mirror of event.target.checked: https://github.com/mui-org/material-ui/blob/1e8b29315fa906c44fb0d09ac94ea0160a43a206/packages/material-ui/src/internal/SwitchBase.js#L87-L92

@eps1lon Ok, great. A few months ago, I have started to update all the demos to use event.target.checked exclusively, a few weeks ago I did a second iteration. I think that we should continue in this direction. This will

better embrace the native controls
avoid developed to ask themselves which one is best and eventually lead to inconsistency in their codebase for mixing the two approaches
match the DX of our textboxes

@samuliasmala What do you think? We could fully migrate the codebase to stop using this second arg, keep it undocumented, add a TODO v5 removal notice.

@oliviertassinari I agree with all of your reasoning to remove the second argument going forward so let's not merge this PR.
I see you changed the title bu should I still close this PR?

@samuliasmala Let's keep it open, I will commit a patch to align with this new direction.

@samuliasmala Thanks for raising the issue!


921 update readme file

PROJECT
Project ticket
Code reviewers

[x] @loqimean

Summary of issue
Add installation guide for Windows, Linux, MacOS.
Summary of change
Add installation guide for:

[x] WSL,
[x] Linux,
[x] MacOS.

CHECK LIST

[x]  PR is reviewed manually again (to make sure you have 100% ready code)
[x]  All reviewers agreed to merge the PR
[x]  PR meets all conventions

Update ReadMe.md - add installation guide for Windows, Linux, MacOS.


Don't overwrite existing configuration

Coverage remained the same at 95.304% when pulling e440350d285506abd06c049ad70fc73c39b0070b on existing-config into bdfa710375711536a49b1d2b616c9c8b51998088 on master.

is there anything still holding this up?

Yes, the requested comment.


subscribe_to_objects and unsubscribe_from_objects return null

These used to return true if successful, would be nice to have them return a true/false status.

They always succeed unless an exception is thrown.


Pieces-widgets: Failed test, not able to hit autocomplete route.

Pieces-widgets should be able to autocomplete docs fails when it tries to hit the apostrophe-docs autocomplete route using the request module, returning a 404. It appears that route might only respond to post requests. Should we rewrite this test to use a post request or make it so this autocomplete route works for more http methods?

Test should use 'post' instead of get.

PR merged.


The content of the ResxManager window is empty.

I've read the Fixing-error page, but my problem is not mentioned there.
DuplicateEntensionFinder reports no duplicates, I have 3 installed extensions: GhostDoc 2019.0.19055, Resharper 2019.1 EAP 2 and ResXManager
Visual Studio 2019 RC.3
Last week ResXManager was working, as far as I remember only the Resharper was upgraded since then.
ResXManager is working when I disable Resharper, but it is not a good solution.
Output:
ResX Resource Manager loaded.
Home: https://github.com/tom-englert/ResXResourceManager
Report issues: https://github.com/tom-englert/ResXResourceManager/issues
Support the project by adding a short review: https://marketplace.visualstudio.com/items?itemName=TomEnglert.ResXManager#review-details
Assembly location: c:\users\username\appdata\local\microsoft\visualstudio\16.0_fa83e8fb\extensions\t21redm1.x1s
Version: 1.34.1869.0
.NET Framework Version: 461814 (https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed)
Switch.System.Windows.Baml2006.AppendLocalAssemblyVersionForSourceUri=False (https://github.com/Microsoft/dotnet/blob/master/releases/net472/dotnet472-changes.md#wpf)
Error: Could not load file or assembly 'Microsoft.Expression.Interactions, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.
Assembly 'DataGridExtensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=43de855f87de903a' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/DataGridExtensions.DLL
Assembly 'DocumentFormat.OpenXml, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=8fb06cb64d019a17' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/DocumentFormat.OpenXml.DLL
Assembly 'JetBrains.Annotations, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=1010a0d8d6380325' loaded from file:///C:/Users/username/AppData/Local/JetBrains/Installations/ReSharperPlatformVs16_fa83e8fb_000/JetBrains.Annotations.DLL
Assembly 'ResXManager.Infrastructure, Version=1.34.1869.0, Culture=neutral, PublicKeyToken=695a75ddb69d5a4b' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/ResXManager.Infrastructure.DLL
Assembly 'ResXManager.Model, Version=1.34.1869.0, Culture=neutral, PublicKeyToken=695a75ddb69d5a4b' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/ResXManager.Model.dll
Assembly 'ResXManager.Translators, Version=1.34.1869.0, Culture=neutral, PublicKeyToken=695a75ddb69d5a4b' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/ResXManager.Translators.dll
Assembly 'ResXManager.View, Version=1.34.1869.0, Culture=neutral, PublicKeyToken=695a75ddb69d5a4b' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/ResXManager.View.dll
Assembly 'ResXManager.VSIX, Version=1.34.1869.0, Culture=neutral, PublicKeyToken=695a75ddb69d5a4b' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/ResXManager.VSIX.dll
Assembly 'System.IO.FileSystem, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' loaded from file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.IO.FileSystem/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.IO.FileSystem.dll
Assembly 'System.IO.FileSystem.Primitives, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' loaded from file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.IO.FileSystem.Primitives/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.IO.FileSystem.Primitives.dll
Assembly 'System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' loaded from file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Net.Http/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Net.Http.dll
Assembly 'System.Runtime.InteropServices, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' loaded from file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.InteropServices/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Runtime.InteropServices.dll
Assembly 'System.Windows.Interactivity, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' loaded from file:///C:/Users/username/AppData/Local/JetBrains/Installations/ReSharperPlatformVs16_fa83e8fb_000/System.Windows.Interactivity.DLL
Assembly 'TomsToolbox.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=60b39f873a8e3fc2' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/TomsToolbox.Core.DLL
Assembly 'TomsToolbox.Desktop, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=60b39f873a8e3fc2' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/TomsToolbox.Desktop.DLL
Assembly 'TomsToolbox.ObservableCollections, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=60b39f873a8e3fc2' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/TomsToolbox.ObservableCollections.DLL
Assembly 'TomsToolbox.Wpf, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=60b39f873a8e3fc2' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/TomsToolbox.Wpf.DLL
Assembly 'TomsToolbox.Wpf.Styles, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=60b39f873a8e3fc2' loaded from file:///c:/users/username/appdata/local/microsoft/visualstudio/16.0_fa83e8fb/extensions/t21redm1.x1s/TomsToolbox.Wpf.Styles.DLL
Please read https://github.com/tom-englert/ResXResourceManager/wiki/Fixing-errors before creating an issue.

I can't reproduce this: VS2019 Preview 4.3, R#2018.3.4

Ok, let's wait until the stable release of VS + Resharper, which is 1 week for the VS, and I guess Resharper will be also released soon after it.
Problem only exists with Resharper 2019 EAP 2 (EAP 1 was OK)

OK, I'll try EAP 2, and file a bug for R# if it's reproducible

Still works fine with R# EAP 2...

It works again with stable VS 2019 and Resharper 2019.1 EAP 4
Thanks.

empty right after installing here, does it need r#? the standalone works perfectly fine

@davepermen no, it does not need R#. Any messages in the output window?

apparently it needed Blend to be installed. Now it works perfectly fine..

@davepermen no, it should not... do you have the error message when it did not run?

I think it said "Could not find System.Windows.Interactivity".
I compared to the Clickonce app, which had the dll beside the exe.
Bing said to install Blend, and that, indeed, fixed it.


On PC 'Delete' key not working on insiders for approx last week

On Windows 10 with insiders for the last 5 to 7 days the delete key has been doing "funny" things like and the issues have changed, but still does not work correctly.

When editing files pressing the delete key has deleted in the terminal window.
With the latest pressing the delete key a pop up with the test "Cannot read property 'dispose' of undefined" occcurs.
I cannot find any area where the delete key works like it did before a week ago.

The delete key works fine in all other windows apps, so the physical keyboad is okay.
If you need logs or anything else please let me know and I will try to supply the data/info ASAP.
Version: 1.57.0-insider (user setup)
Commit: b95b73b7b074f5dddccd57e5e290617f1a767ec1
Date: 2021-05-05T17:20:18.311Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Extension
Author (truncated)
Version

vscode-openapi
42C
4.5.0

Handlebars
and
0.4.1

ng-template
Ang
11.2.14

swagger-viewer
Arj
3.0.1

npm-intellisense
chr
1.3.1

path-intellisense
chr
2.3.0

vscode-markdownlint
Dav
0.40.4

vscode-eslint
dba
2.1.20

githistory
don
0.6.16

xml
Dot
2.5.1

gitlens
eam
11.4.1

EditorConfig
Edi
0.16.4

tslint
eg2
1.0.46

vscode-npm-script
eg2
0.3.21

git-project-manager
fel
1.7.1

vscode-firefox-debug
fir
2.9.4

code-runner
for
0.11.3

docker-explorer
for
0.1.7

vscode-pull-request-github
Git
0.25.1

docker-linter
hen
0.5.0

rest-client
hum
0.24.5

angular-essentials
joh
11.0.0

Angular2
joh
11.0.0

openapi-lint
mer
1.2.0

Angular-BeastCode
Mik
10.0.3

file-downloader
min
1.0.10

mindaro
min
1.0.120210423

vscode-docker
ms-
1.12.1

vscode-kubernetes-tools
ms-
1.3.2

mssql
ms-
1.10.1

python
ms-
2021.4.765268190

jupyter
ms-
2021.6.812916528

remote-containers
ms-
0.177.0

remote-wsl
ms-
0.56.1

cpptools
ms-
1.3.1

vscode-typescript-tslint-plugin
ms-
1.3.3

debugger-for-chrome
msj
4.12.12

debugger-for-edge
msj
1.0.15

vscode-run-git-difftool
nar
0.0.5

angular2-inline
nat
0.0.17

material-icon-theme
PKi
4.6.0

swaggitor
qns
0.1.1

diff
raf
0.0.1

vscode-yaml
red
0.18.0

partial-diff
ryu
1.4.3

markdown-preview-enhanced
shd
0.5.18

prettier-vscode
Sim
2.0.7

vscode-taskexplorer
spm
2.0.7

vscode-icons
vsc
11.4.0

gitblame
wad
6.0.2

debug
web
0.25.0

JavaScriptSnippets
xab
1.8.0

json
Zai
2.0.2

Does the problem also happen when all your extensions are disabled? Maybe use the "Start Extension Bisect" command in order to investigate.

Is there any easy way to disable all extensions at once? If not I will read up on the bisect blog posting I seen previously.

I have disabled all of the extensions and the delete key is still poping up the "Cannot read property 'dispose' of undefined" in the edit window and does not remove breakpoints.
Its it working for you on Windows?

Can you run "Developer: Toggle Keyboard Shortcuts Troubleshooting" and include the logs it generates concerning how the delete key is being handled?

Here's mine when I press the delete key:
[2021-05-06 14:44:43.466] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Delete, keyCode: 46, key: Delete
[2021-05-06 14:44:43.466] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Delete, keyCode: 20 ('Delete')
[2021-05-06 14:44:43.467] [renderer1] [info] [KeybindingService]: | Resolving Delete
[2021-05-06 14:44:43.467] [renderer1] [info] [KeybindingService]: \ From 12 keybinding entries, matched workbench.action.terminal.killInstance, when: terminalIsOpen && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus, source: built-in.
[2021-05-06 14:44:43.538] [renderer1] [info] [KeybindingService]: | Resolving Delete
[2021-05-06 14:44:43.539] [renderer1] [info] [KeybindingService]: \ From 12 keybinding entries, matched workbench.action.terminal.killInstance, when: terminalIsOpen && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus, source: built-in.

Can you run "Developer: Toggle Keyboard Shortcuts Troubleshooting" and include the logs it generates concerning how the delete key is being handled?

@feeva I presume you did not have the terminal tabs tree focused at that time?
cc @meganrogge are the context keys maybe being incorrectly set?

@JacksonKearl I removed the key binding. So now I don't know that for sure. Do you still need to know?

It would be helpful for debugging to know if your focus was in on the terminal tabs view, in which case running workbench.action.terminal.killInstance would make sense, or elsewhere, in which case we shouldn't have dispatched to that command and it might be the case that some of the context keys we use to determine how to route keybindings my be incorrectly set.
This problem is appearing now because terminal tabs are a new feature with this iteration.

Ah, yeah, the new terminal tabs. I like it anyway. 👍
My focus was in the editor. I was just doing just normal edit activities. But I'm not sure the terminal was open or not.

Plot thickens, when I first run the "Developer: Toggle Keyboard Shortcuts Troubleshooting" command I get the following error as I have deleted the initial powershell terminal as I use the "javascript Debug Terminal" as my default.
[2021-05-06 12:32:18.733] [renderer1] [error] Terminal with ID 1 does not exist (has it already been disposed?): Error: Terminal with ID 1 does not exist (has it already been disposed?)
at W._getIndexFromId (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2714:29334)
at W.setActiveInstance (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2714:24738)
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2120:32850
at l.fire (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:1836)
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:58:58655
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:3623
at l.fire (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:1836)
at r._set (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:124:31818)
at r.set (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:124:31633)
at p.setSelection (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:142:9062)
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2120:31876
at l.fire (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:1836)
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2714:15732
at l.fire (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:1836)
at W.setActiveTabByIndex (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2714:24996)
at W._removeTab (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2714:23753)
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2714:15623
at l.fire (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:1836)
at l.fire (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:1856)
at f._onInstanceDisposed (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1802:26559)
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1802:25962
at l.fire (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:60:1836)
at ii.dispose (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2627:111308)
at file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2124:1403
at b._runForSelectionOrInstance (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2124:1708)
at R.M [as _actionCallback] (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2124:1369)
at R.run (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:171:30505)
at _.runAction (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:171:30953)
at _.run (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:171:30855)
at f.onClick (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:171:33980)
at Immediate._onImmediate (file:///C:/Users/andrew/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:171:33512)
at processImmediate (internal/timers.js:461:21)

The log when I press the delete key is:
[2021-05-06 16:30:11.937] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Delete, keyCode: 46, key: Delete
[2021-05-06 16:30:11.938] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Delete, keyCode: 20 ('Delete')
[2021-05-06 16:30:11.938] [renderer1] [info] [KeybindingService]: | Resolving Delete
[2021-05-06 16:30:11.938] [renderer1] [info] [KeybindingService]: \ From 11 keybinding entries, matched workbench.action.terminal.killInstance, when: terminalIsOpen && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus, source: built-in.
[2021-05-06 16:30:12.080] [renderer1] [info] [KeybindingService]: | Resolving Delete
[2021-05-06 16:30:12.080] [renderer1] [info] [KeybindingService]: \ From 11 keybinding entries, matched workbench.action.terminal.killInstance, when: terminalIsOpen && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus, source: built-in.

The log when I press the delete key with the focus in the breakpoint window and press the delete key after selecting a breakpoint via the mouse:
[2021-05-06 16:34:37.107] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Delete, keyCode: 46, key: Delete
[2021-05-06 16:34:37.108] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Delete, keyCode: 20 ('Delete')
[2021-05-06 16:34:37.109] [renderer1] [info] [KeybindingService]: | Resolving Delete
[2021-05-06 16:34:37.109] [renderer1] [info] [KeybindingService]: \ From 11 keybinding entries, matched workbench.action.terminal.killInstance, when: terminalIsOpen && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus, source: built-in.

More details:

The delete key works until you delete the initial powershell terminal.

I did the following:

Start VSC  - default terminal is powershell

can delete

Add a new Powershell terminal via the new tab feature

can delete

Add a  Javascript Debug terminal via the new tab feature

can delete

Delete the second powershell terminal

can delete

Delete the initial powershell
***** DELETE STOPS WORKING ****

I also did the following

Start VSC  - default terminal is powershell

can delete

Add a  Javascript Debug terminal via the new tab feature

can delete

Delete the initial powershell
***** DELETE STOPS WORKING ****

Let me know if I can do anything more.

I've encountered the same issue with the delete key. It started working after I removed following binding:
{ "key": "delete",                "command": "workbench.action.terminal.killInstance",                                      "when": "terminalIsOpen && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus" },
Though, now I can't delete open terminals in terminal side panel with the delete key.

Yes more info:
If I delete the terminal by the old terminal dropdown the del key wored fine, so the issue is further refined to the new tab delete functionality not working the same as the old functionality.

Just updated to 1.56.0 and the delete key stopped working.
When a terminal is open, the delete key focuses on the terminal, and after disposing of the terminal it just doesn't do anything.
This is the log from pressing delete:
[2021-05-06 14:21:21.586] [renderer2] [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Delete, keyCode: 46, key: Delete
[2021-05-06 14:21:21.586] [renderer2] [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Delete, keyCode: 20 ('Delete')
[2021-05-06 14:21:21.587] [renderer2] [info] [KeybindingService]: | Resolving Delete
[2021-05-06 14:21:21.587] [renderer2] [info] [KeybindingService]: \ From 11 keybinding entries, matched workbench.action.terminal.killInstance, when: terminalIsOpen && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus, source: built-in.

Removing the workbench.action.terminal.killInstance works as a workaround.
About info:
Version: 1.56.0 (user setup)
Commit: cfa2e218100323074ac1948c885448fdf4de2a7f
Date: 2021-05-04T22:09:06.405Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

All shortcuts using terminalTabsFocus not working. Delete and F2 in my case.
Version: 1.56.0
OS: Linux x64 5.4.0-72-generic (Linux Mint 20.1)

Are people experiencing this all using the new terminal tabs, or is it happening with tabs disabled?

@Tyriar, It also happens when Terminal Tabs are disabled. When the editor is in focus, if you hit DELETE, it switches focus to the Terminal.

I have kinda the same issue and it happens until I disable tabs and restart VScode.
In Windows 10 after enabling terminal tabs and deleting a terminal, When I press delete in editor it deletes the selected terminal tab instead of deleting a character.

I can confirm that I deleted the PowerShell terminal, and that is when the delete key stopped working. Adding a PowerShell terminal back made it work again.

I'm having this issue with the latest release, is there anything I can do to resolve this issue?
Or wait for the 1.57.0 release?
Version: 1.56.1 (user setup)
Commit: e713fe9b05fc24facbec8f34fb1017133858842b
Date: 2021-05-06T10:08:05.141Z (6 日前)
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

@Lycolia 1.56.2 is coming soon which will have this fixed


Occasional transactions failing after 30 seconds

I've created a mainnet farm and farmers using the GemFarm front end here https://www.gemfarm.gg/
I had no issues on devnet, but as soon as I switched to mainnet I started getting transaction timeout errors (see below). They're happening for maybe every 4 out of 10 transactions. I'm not sure if this is a network issue as i've tested with others and had no issues. Has anybody experienced anything similar?
Thanks
Transaction was not confirmed in 30.01 seconds. It is unknown if it succeeded or failed. Check signature 3p2MkXJEs55yxAUyoiDuCd4yriL6YLQhBaYMKQ2ycSrf53vpsJBquKCe2VNRNCW8ncSTgqyMUBzx1YLDPC3H8NzB using the Solana Explorer or CLI tools.

@chris-hellon since you closed this, have do you have a solution to this?

I've also been having this issue, tried with various RPC providers, and still occasionally get the timeout. Most of the time when the error occurs the transaction does go through. I call the Solscan API to confirm if it was successful or not. https://public-api.solscan.io/transaction/${signature}

I wasn't able to fix it i'm afraid, I was told that it was pretty much normal behaviour. Not good though, i'd definitely like a better option as it's failing quite often

I too am seeing this more often than I like.  Is this because the on-chain code isn't efficient enough, or are we able to optimize the front-end code.
I don't think it's "normal", or there would be many many programs that would do this.
I go ahead and load one of my NFTs into the vault and it may work, but the second one is giving me a lot of issues on MainNet.
Here's what I'm seeing more often than not:

It could also be due to the RPC endpoint, I tried the actual mainnet endpoint and had even more errors of timeouts and rate limits.
To be honest, in it's current state it's pretty unusable, i'm getting lots of complaints about it.

Ok so i've created my own custom RPC endpoint which has drastically reduced the timouts occuring. I'd recommend doing the same thing

How does one "create my own custom RPC endpoint"?  Do tell!

I found a tutorial at https://medium.com/@MisterKevin_js/how-to-run-your-own-solana-rpc-endpoint-on-figments-datahub-e9ca881bebb7.  Giving it a try.

Thanks man - I just set up one with Figment (we already have an account there).  It seems to be working better, but still txns are failing.  Trying with the latest update to main - let's see if it works well enough!

Hi @numisman @chris-hellon, interested in your solution to make your own RPC node, after 1 month doing it, is it working better than mainnet?

@kafinsalim it's been a lot better since I used my own node. I'm just using the launch plan on quicknode.com and i've had zero issues since I started using it.

@chris-hellon where exactly do you point your custom rpc in the gem-farm code.
sorry noob but when using candymachine it was in an env file I remember


SunSpec after Restart HA not available

Hi, I have this error after restart Home Assistant:
Einrichtung fehlgeschlagen, wird erneut versucht: Caught blocking call to sleep with args (0.5,) inside the event loop by custom integration 'sunspec' at custom_components/sunspec/api.py, line 159: client.scan(. (offender: /usr/local/lib/python3.12/site-packages/sunspec2/modbus/client.py, line 258: time.sleep(delay)), please create a bug report at https://github.com/cjne/ha-sunspec/issues For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#sleep
Does anyone have an idea to fix it?
Thank you.

After a restart from the inverter, sunspec worked again for me

Hello, I have the same issue. After a restart from HA (eg update or other reasons) the integration shows no values. After a manually restart (sun spec) it works. It looks like during HA start the integration doesn't start as it should.

I think this should work better with the latest version, 0.0.26

Hi CJNE, I still seems to have the issue.

Same. Not better with the new version.


Error on Swagger for relative paths with colon character

I have an API endpoint (.net core 3.1), with the following signature:
[HttpGet("{divisionName}/things:count", Name = "GetNumberOfThings")]
public async Task<IActionResult> GetNumberOfThings([FromRoute] [Required] string divisionName, [FromQuery] [Required] string groupBy)

When I try to go to the Swagger page, I get the following error:

The endpoint is working as expected, it is just when I try to access the Swagger.
Previously the Swagger was working, it was only when I updated Swashbuckle.AspNetCore to version 6.2.2.
I think it has to do with that new internal method 'RelativePathSansParameterConstraints', which is looking for a '}' after the ':'.
Can you please have a look?
Many thanks in advance.

Happy to contribute this feature if we can flesh it out @domaindrivendev


add a blog to README

Description
there is a blog which about htnn: https://segmentfault.com/a/1190000044973100
I think it can be added into README, so that more people can read it and know htnn.
Environment

HTNN version: main

Thanks! This blog is written in a short time and we will write a more formal one to introduce HTNN later.


HADOOP-17908. Add missing RELEASENOTES and CHANGELOG to upstream.

https://issues.apache.org/jira/browse/HADOOP-17908
RELEASENOTES and CHANGELOG of 2.10.1, 3.1.4 and 3.3.0 are missing in trunk.
While CHANGES* were renamed to CHANGELOG* by HADOOP-14671, there are some CHANGES files left. I would like to rename those to CHNAGELOG here for consistency.
$ find . -name 'CHANGES*'
./hadoop-common-project/hadoop-common/src/site/markdown/release/2.10.0/CHANGES.2.10.0.md
./hadoop-common-project/hadoop-common/src/site/markdown/release/3.1.2/CHANGES.3.1.2.md
./hadoop-common-project/hadoop-common/src/site/markdown/release/3.1.3/CHANGES.3.1.3.md

hadoop-common-project/hadoop-common/src/site/markdown/release/2.10.0 contains both CHANGES.2.10.0.md and CHANGELOG.2.10.0.md. Since the contents of current CHANGELOG.2.10.0.md is invalid, I replaced it with the contents of current CHANGES.2.10.0.md (and removed the CHANGES.2.10.0.md).
HTML files under "Changelog and Release Notes" pages (hadoop-project/hadoop-project-dist/hadoop-common/release/*) are generated by mvn site regardless of the file names.

I would like to rename those to CHNAGELOG here for consistency.

Scripts seem to expect CHANGELOG.
https://github.com/apache/hadoop/blob/trunk/dev-support/bin/create-release#L623-L628

Generated index.html of "Changelog and Release Notes" (hadoop-project/hadoop-project-dist/hadoop-common/release/index.html) can be verified by building docs with -Preleasedocs like
$ mvn site site:stage -Preleasedocs -DstagingDirectory=/var/www/html/hadoop-site/trunk

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 34s

trunk passed

+1 :green_heart:
mvnsite
1m 56s

trunk passed

+1 :green_heart:
shadedclient
58m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 45s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
mvnsite
2m 11s

the patch passed

+1 :green_heart:
shadedclient
24m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

88m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3433

Optional Tests
dupname asflicense mvnsite codespell markdownlint

uname
Linux 4e3aef186475 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8e104c26915a2feba99c6b1185983f87c1d613b4

Max. process+thread count
594 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 49s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
shadedclient
46m 40s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
46m 59s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
shadedclient
14m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

65m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3433

Optional Tests
dupname asflicense mvnsite codespell markdownlint

uname
Linux ca151a4e7a42 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5dff429d91fe8c7f1924d27151e0dc733530d193

Max. process+thread count
719 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The patch has 1 line(s) that end in blanks.

The relevant file (RELEASENOTES.3.3.0.md) are part of already published release artifacts. I think it should be added as is.

Thanks, @aajisaka. I merged this.


Remove Windows Forms targets

These targets have been moved to seperate repository, https://github.com/NLog/NLog.Windows.Forms, and will be released in a seperate package.
Should not be merged until NuGet package exists for new package.
closes #455

Since RichTextBoxTarget has been moved away, maybe some related stuff should also go with it, namely RichTextBoxWordColoringRule and RichTextBoxWordColoringRule?

Missed those, thanks.


how to add a menu ?

I'm not sure if this is in the scope of this project. But I've noticed that a lot of Facebook Messenger bots are integrating a little menu that can be used to navigate to different options or conversations.
These are two bots that make use of the menu
Coding Memes: https://www.messenger.com/t/272687346480612
Alexa Dating: https://www.messenger.com/t/alexadating
I'm wondering how those menus are created, and whether Botman can help or plans to add this feature in the future.
Thanks!

Hi,
Do you mean this menu?
https://developers.facebook.com/docs/messenger-platform/thread-settings/persistent-menu
If that's what you want, it looks like you can just send a request with your menu entries to Facebook.
Botman would then need a way to listen for those button click events : payloads.
I already plan to add support to the "Get started" Facebook button, which will be the same kind of payload driver.
But the menu creation would be out of the scope of BotMan (at least right now).

Yes I meant that one, although it looks different on the messenger.com website or inside the osx messenger client. But it's the same persistent menu.
Would be really cool if you added it to Botman although I don't mind doing things manually of course.
Looking forward to your support of the "Get started" button. Do you think it'll be available soon'ish?
Cheers! Keep up the great work!

You can now listen to "Get started" or Menu postback payloads using this code:
$botman->hears('USER_DEFINED_PAYLOAD', function (BotMan $bot) {
    $bot->reply('Let\'s get started!');
})->driver(FacebookPostbackDriver::DRIVER_NAME);

This way, BotMan will only listen for the postback payloads, and will not trigger the method if a user types "USER_DEFINED_PAYLOAD" in the chat!
It's currently only on dev-master.

Yes, BotMan is focused around hearing commands and therefore it specifies the driver by parsing the incoming requests.
I am not sure if such a command would really be useful inside of BotMan, because it is a one-time only setup process - once you've set up the menu, you won't need it again.
You could as well just copy-paste the example code from the Facebook messenger API website, modify it and edit your page access token.
Maybe I'm going to change my mind, but right now I don't think it fits into BotMan.


auth: fix docstring

Fixed small docstring mismatch

Coverage remained the same at 95.565% when pulling ec5ac009594c87fd3451e7fe0ba648d0fc9bcdd3 on marcinkuzminski:patch-1 into d7370622a4479b1b933d29a965e4720fa11391d3 on onelogin:master.


Context based state manager

Big time architecture change: This PR removes mobx entirely, and replaces the global state manager with a system based on React Contexts. The design is largely taken from this blogpost.
The motivation behind this proposal is to maintain app state across clients, as described in https://github.com/covid19risk/permission-portal/issues/111. As you can tell from that description, initially I intended to keep mobx, but in building this realized that neither it (nor Redux) are up to the task. The problem with both libraries is that they make it arbitrarily complex to attach and detach Firebase document listeners based on app state, and update app state based on the listeners. With this design, we can manage our state with all the flexibility of an ordinary React component class, while getting reactive virtual DOM updates for free.
The magic happens primarily in src/store/index.js, where createStore returns an HOC that defines the store. createStore is called only once, in App.js, ensuring that there is only ever a single store, at the highest level in our component hierarchy. createStore takes our App and wraps it in a context Provider, and passes this store component's state object as a prop:
...
render() {
      return (
        <StoreContext.Provider value={this.state}>
          <WrappedComponent {...this.props} />
        </StoreContext.Provider>
      )
    }

With the entire app is wrapped by that Provider, and its value is set to our store component's state, we can now make any other component in our hierarchy subscribe to that state's updates by making it a Consumer of the context. The function withStore does this for us, so that any component we wrap with it gets a prop called store (hence heavy usage of props.store throughout the app), that points to our highest level state object. You can see that all of our components that make use of global state are now wrapped with withStore:
const withStore = (WrappedComponent) => {
  return class extends React.Component {
    displayName = 'storeConsumer'
    render() {
      return (
        <StoreContext.Consumer>{(store) => <WrappedComponent store={store} {...this.props} />}</StoreContext.Consumer>
      )
    }
  }
}

The rest of the magic is contained in this.authStateListener, which is set up when the app loads up to listen for a user logging in or out. When a user logs in, this function goes through and updates the global state by grabbing relevant documents from the db, and sets up listeners that wait for changes in relevant documents. When a listener is notified of a change, it updates the global state variable accordingly.
Importantly, the programmer should (almost?) never change the properties of the global state variable directly, except from within the component returned by createStore (and should be sure to always call setState when doing so). Data should only flow one way --

a component makes a call to a function exposed in the global state variable (i.e. updateOrganization)
that function makes a call modifying the Firestore database
a listener is notified of that modification (on all currently running clients), and modifies the global state variable accordingly
any components that were rendering something based on global state data (i.e. are wrapped with withStore and making use of props.store) are automatically re-rendered.

A bit rambly, but hopefully more clarifying than befuddling. Hit me up in Slack if you have any questions.
closes #111

Update: after discussion with @therealnikhil, this is being revised to make use of mobx


Instructions and screenshots on page are incorrect

The instructions and screenshots on this page relate to the previous functionality of Analytics Configuration and do not reflect the current user experience. Could someone please review both Azure and Dynamics Marketing and update accordingly.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 06d56767-ae95-eb6b-353e-af2ccb415d00
Version Independent ID: 5100476a-5a38-b8b3-6ba7-b61869ba3383
Content: Prepare for analytic reporting with Power BI (Dynamics 365 Marketing)
Content Source: ce/marketing/custom-analytics.md
Service: dynamics-365-marketing
GitHub Login: @alfergus
Microsoft Alias: alfergus

Thanks for your comment, @justinreading. This issue has been assigned to the doc author for review.


feat(vscode): update to version 1.56.0

This PR updates vscode to 1.56.0
TODOS

[x] test editor locally
[x] test terminal locally
[x] make notes about any significant changes in docs/CONTRIBUTING.md#notes-about-changes

Files with conflicts (fix these)

[x] lib/vscode/build/yarn.lock
[x] lib/vscode/extensions/github-authentication/src/githubServer.ts
[x] lib/vscode/package.json
[x] lib/vscode/src/vs/code/browser/workbench/workbench.ts
[x] lib/vscode/src/vs/platform/product/common/productService.ts
[x] lib/vscode/src/vs/workbench/browser/parts/titlebar/menubarControl.ts
[x] lib/vscode/test/smoke/package.json
[x] lib/vscode/yarn.lock

Note: running yarn watch gave me a bunch of errors related to xcode tools. Now I'm trying to reinstall xcode command line tools by removing and running xcode-select --install to see if it fixes it.

Hmm...xcode errors are gone but I can't get yarn watch to work. It seems to finish compilation of extensions and then stop 🤔

I'll try deleting branch, yarn and try again

No luck :( Can't get yarn watch to work locally. Any ideas?

I think they broke their build scripts... yarn build:vscode "fails" with an error, but if you move forward with yarn release, yarn release:standalone the resulting build works just fine.
I'm investigating it right now - I never use yarn watch in my local test loop (not enough memory on laptop), so I didn't catch it, oops.

I'm investigating it right now - I never use yarn watch in my local test loop (not enough memory on laptop), so I didn't catch it, oops.

Definitely not your fault. We've missed those in the past. Ideally, we should have a test for yarn watch so that we catch these sooner. I'm tracking in https://github.com/cdr/code-server/issues/2963 and will add to the next milestone.

@jsjoeio I think it should be fixed now, though :eyes:

@code-asher the reason its in draft mode is because 1.56 isn't out upstream yet and they're still doing last-minute bugfixes - when they release their tarballs (thursday), I plan on pulling in the latest changes and then just merging if it works (which hopefully it will!)
Would appreciate you testing/looking at the terminal stuff ^^

Uh oh - is that a build from CI or a build you made locally @jsjoeio?

This is from a local build! I updated with more info. Hopefully not an issue from this PR. Let me test again

Everything seems to be working now!
https://user-images.githubusercontent.com/3806031/116911744-1bb6b880-abfc-11eb-83a0-9e32a1074c50.mov

Heads up - I went and reviewed the changes to the yarn.lock files, and it turns out that upstream still hasn't updated xmldom to a non-vulnerable version, so I put that change in. I'll re-update it later today.

Oh no... I appear to have messed up the commit log :(

Tested again locally. Took a little bit to start up running yarn watch but after a reload, it was working
https://user-images.githubusercontent.com/3806031/117348214-cdedba80-ae5e-11eb-9e0f-e1173a02e70e.mov

It occurred to me we could probably use https://github.com/cdr/code-server/blob/main/lib/vscode/src/vs/platform/terminal/node/ptyService.ts directly.


[BUG] keep asking for Registration

Nothing much to say, the problem started occurring after a EasyAuth reinstall.
Basically we can't login but only register again and again.
I've already tried removing the EasyAuth folder.
(I am on Fabric 0.7.4 for 1.17.1)
Any tips?

Which version of mod do you use, 1.9.7 or older?
If you use 1.9.7 please try with 1.9.6

Which version of mod do you use, 1.9.7 or older?
If you use 1.9.7 please try with 1.9.6
Upd:

It asking for registration after relogin to server or server restart?
Version of Fabric API?
Did you change something in config?
Maybe some errors in console?

I tried with both 1.9.6 and 1.9.7 version.
1: It ask for registration after every relogin.
2: Fabric API is api-0.40.1+1.17.
3: I did a complete wipe of the EasyAuth folder.
4: No error in console by searching for "EasyAuth".

I don't thinks that's that matter, but:
Offline or online server? Linux or Windows? Other installed mods?
You can register user with command auth register <uuid> <password>, note that uuid must be for lowercase variant of nickname (e.g. nikitacartes, not NikitaCartes). You can use that site for offline uuid.

I don't thinks that's that matter, but: Offline or online server? Linux or Windows? Other installed mods?

The server is actually in Offline mode but it happens even when i use my main Mojang account. The host is running Linux. There are plenty of mods but the problem persist even when removing all the others mods, I've also tried to remove the EasyAuth folder present in the Mods folder and also to remove the usercache.json but with no success.
I've recently updated the fabric server .jar

@HexHyte
Hello, sorry for long answer.
I'm finally can reproduce it and can suugest a quick fix for you:
Try to change "useBCryptLibrary" to true

sorry for long answer.

Thanks for the answer man, don't worry about that

I'm finally can reproduce it and can suugest a quick fix for you: Try to change "useBCryptLibrary" to true

This actually did the trick, thank you again!

@HexHyte
I'm glad that help you.

This actually did the trick, thank you again!

Be sure that you will not change back to false because players will not be able to log in after that


Fix ineffective 'dynaClear' within surrounding s of nested fields

Rationale
Currently, the 'New Line' option in nested field definitions does not apply. This is caused by DSpace CRIS, adding additional
s around JDynA's response, which is composed of two
s (.dynaField, .dynaClear), and casts the responsible dynaClear element ineffective.

This pull request addresses this issue. It might not be the cleanest way, but it does not interfere with other functionality and just searches the JDynA response for the dynaClear element and adds it to the proper place if it exists.
The comments can be removed if a merge is considered.

we will try to fix the issue directly in JDynA to avoid the need of a DOM manipulation. I will keep this PR open as workaround until then

Thank you @r3r57 to point us to this bug. You can find the effective fix at commit 4dbc5eb2c7b0c2f9dc1c6defb3c7f5c645d8e8c0


adding IP to sysinfo on discovery to be able to use discovery for sav…

…ing devices
Hi,
would be great if this makes it into the discovery. Without it the discovery doesn't help me much.
Great little packet, thought about making it on my own after deciphering the code some months ago but luckily I searched again and you have already created it and someone else also cracket the "encryption"
Thanks
x

Been in the middle of a move, but I should have some time this week to work on this. Rewriting a large portion of the discovery.


You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 72 MB. How to fix this ?

Description

I am using 'ubuntu-latest' as github runner for my pipeline.

My GitHub Actions pipeline defines a workflow for building and publishing an Android project to Firebase App Distribution.

My pipeline sometimes given warning - "You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 72 MB" and pipeline fails.

Seeing other github issues similar to this one, I found and tried a workaround as below:-

sudo rm -rf /usr/share/dotnet
sudo rm -rf /opt/ghc
sudo rm -rf "/usr/local/share/boost"
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
But above folders does not exist when I tried viewing folders on my github runner 'ubuntu-latest'.
I can see below files and folders:-
36G	    /usr
23G	    /usr/local
13G	    /usr/local/lib
12G	    /usr/local/lib/android/sdk
12G	    /usr/local/lib/android
12G	    /opt
8.5G    /opt/hostedtoolcache
7.8G	    /usr/local/lib/android/sdk/ndk
6.7G	/usr/lib
5.6G	/usr/share
5.5G	/usr/local/.ghcup/ghc
5.5G	/usr/local/.ghcup
5.0G	/opt/hostedtoolcache/CodeQL/2.18.1/x64/codeql
5.0G	/opt/hostedtoolcache/CodeQL/2.18.1/x64
5.0G	/opt/hostedtoolcache/CodeQL/2.18.1
5.0G	/opt/hostedtoolcache/CodeQL
3.1G	    /swapfile
3.0G	/opt/hostedtoolcache/CodeQL/2.18.1/x64/codeql/swift
2.8G	/usr/local/.ghcup/ghc/9.10.1
What can I do for this issue ?
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Runner version: '2.317.0'
Is it regression?
It is occuring randomly.
Expected behavior
It should not give this warning and build should be completed successfully and build should not fail due to disk space issue.
Actual behavior
My pipeline sometimes gives warning - "You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 72 MB" and pipeline fails.
Repro steps
This issue comes due to disk space issue of github runner.

Hi @sagarkalankar1 -Thank you for bringing this issue to our attention. We will update you on this issue after investigating.

I'm facing a similar issue with an android build that was working fine last week. Now it fails with java.io.IOException: No space left on device

Hi @sagarkalankar1 - You can try the following strategies to free up space and optimize your pipeline:
A. Clean Up Unnecessary Directories and Files
You can add steps in your workflow to remove unnecessary directories and files to free up space.
name: Build and Publish Android Project

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - name: Checkout repository
      uses: actions/checkout@v2

    - name: Set up JDK
      uses: actions/setup-java@v2
      with:
        distribution: 'adopt'
        java-version: '11'

    - name: Remove unnecessary directories to free up space
      run: |
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost

    - name: Install dependencies
      run: |
        sudo apt-get update
        sudo apt-get install -y your-required-packages

    - name: Build the Android project
      run: ./gradlew build

    - name: Publish to Firebase App Distribution
      run: |
        # Your commands to publish the build to Firebase

B. Cache Dependencies
Use caching to avoid re-downloading dependencies, which can save space and speed up builds.
```

name: Cache Gradle files
uses: actions/cache@v2
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('/.gradle', '/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-gradle-

C. **Optimize Gradle Configuration**

Optimize your Gradle configuration to reduce the amount of data generated during builds.

Add the following to your **gradle.properties**:

org.gradle.daemon=false
org.gradle.parallel=false
org.gradle.configureondemand=false
D. If disk space continues to be an issue, consider using self-hosted runners with larger disk space.

E. **Monitor Disk Usage**
Add steps to monitor disk usage throughout the build process.

    ```
- name: Check disk usage
      run: df -h

    - name: Check directory sizes
      run: du -sh /usr/local/* /opt/* /usr/* | sort -hr

F. For your understanding I am providing an example of the workflow with added cleanup steps:-

name: Build and Publish Android Project
on:
push:
branches:
- main
pull_request:
branches:
- main
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
  uses: actions/checkout@v2

- name: Set up JDK
  uses: actions/setup-java@v2
  with:
    distribution: 'adopt'
    java-version: '11'

- name: Remove unnecessary directories to free up space
  run: |
    sudo rm -rf /usr/local/.ghcup
    sudo rm -rf /opt/hostedtoolcache/CodeQL
    sudo rm -rf /usr/local/lib/android/sdk/ndk
    sudo rm -rf /usr/share/dotnet
    sudo rm -rf /opt/ghc
    sudo rm -rf /usr/local/share/boost

- name: Install dependencies
  run: |
    sudo apt-get update
    sudo apt-get install -y your-required-packages

- name: Build the Android project
  run: ./gradlew build

- name: Publish to Firebase App Distribution
  run: |
    # Your commands to publish the build to Firebase

- name: Check disk usage
  run: df -h

    - name: Check directory sizes
      run: du -sh /usr/local/* /opt/* /usr/* | sort -hr

By using above steps, you can try to manage disk space and reduce the likelihood of your builds failing due to insufficient disk space.

I'm facing a similar issue with an android build that was working fine last week. Now it fails with java.io.IOException: No space left on device

The issue seems to be with the ubuntu-latest image since the pipeline works if I run on an mac-os image and it was working before the latest update.
Was working:
Image: ubuntu-22.04
Version: 20240721.1.0
Is failing:
Image: ubuntu-22.04
Version: 20240730.2.0

We are running into a similar issue - we run elasticsearch in docker that we use in our test suite, and we get an error high disk watermark [90%] exceeded which prevents it from working. We started observing this when the image changed to 20240730.2.0 - last successful run was on 20240721.1.0

same probleme for me
Run df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        73G   [6](https://github.com/xxx/actions/runs/10262882021/job/28393484095#step:16:7)4G  8.7G  89% /
tmpfs           3.9G  172K  3.9G   1% /dev/shm
tmpfs           1.6G  1.1M  1.6G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
tmpfs           [7](https://github.com/xxx/actions/runs/10262882021/job/28393484095#step:16:8)93M   12K  793M   1% /run/user/1001

i just run clean action before with this script
name: Free Disk Space (Android)

on:
  workflow_dispatch: # To trigger manually

jobs:
  free-disk-space:
    runs-on: ubuntu-latest
    steps:
      - name: Free Disk Space (Ubuntu)
        uses: jlumbroso/free-disk-space@main
        with:
          # this might remove tools that are actually needed,
          # if set to "true" but frees about 6 GB
          tool-cache: false

          # all of these default to true, but feel free to set to
          # "false" if necessary for your workflow
          android: true
          dotnet: true
          haskell: true
          large-packages: true
          docker-images: true
          swap-storage: true

any solution please ?

@alainib @danibonilha @mantljosh - By this week, new image version will be rolled out. So, kindly try once after new image version rolled out.
However, for you, I am providing an updated workflow that integrates more aggressive cleanup steps:-
name: Build and Publish Android Project

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-22.04  # Specify a fixed version of Ubuntu

    steps:
    - name: Checkout repository
      uses: actions/checkout@v2

    - name: Free Disk Space Before Build
      run: |
        echo "Disk space before cleanup:"
        df -h
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost
        sudo apt-get clean
        echo "Disk space after cleanup:"
        df -h

    - name: Set up JDK
      uses: actions/setup-java@v2
      with:
        distribution: 'adopt'
        java-version: '11'

    - name: Install dependencies
      run: |
        sudo apt-get update
        sudo apt-get install -y your-required-packages

    - name: Cache Gradle files
      uses: actions/cache@v2
      with:
        path: ~/.gradle/caches
        key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
        restore-keys: |
          ${{ runner.os }}-gradle-

    - name: Build the Android project
      run: ./gradlew build

    - name: Publish to Firebase App Distribution
      run: |
        # Your commands to publish the build to Firebase

    - name: Free Disk Space After Build
      run: |
        echo "Disk space before post-build cleanup:"
        df -h
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost
        sudo apt-get clean
        echo "Disk space after post-build cleanup:"
        df -h

Explanation:-
Pre-Build Cleanup:
The script cleans up various large directories (/usr/local/.ghcup, /opt/hostedtoolcache/CodeQL, /usr/local/lib/android/sdk/ndk, /usr/share/dotnet, /opt/ghc, /usr/local/share/boost) to free up space.
df -h is used to show the disk space before and after cleanup for monitoring purposes.
Post-Build Cleanup:
Similar cleanup steps are performed after the build to ensure any temporary files created during the build process are removed.
df -h is again used to show the disk space before and after cleanup.
By this approach, you should be able to manage disk space more effectively and prevent build failures due to insufficient disk space.

@Prabhatkumar59  wow thank you for fast answer and response :)
i will try it . what is the best approach please ?

add this to the yml script who fail and run it each time
create another yaml file and run it only when needed

i'm not sure if multiples yml file share folders like in macos/linux etc or each one have it's one space like in docker and running  cleanup yml file whould not affect my reel yml file . thanks

FWIW we changed ubuntu-latest to ubuntu-24.04 and it seems to be working okay with the new version

Hi @alainib - Here are the best approaches which I am providing you to handle the disk space issue effectively:
Approach 1: Add Cleanup Steps to the Failing YAML File
Adding cleanup steps directly to the failing YAML file ensures that cleanup is performed every time the workflow runs. This approach guarantees that disk space issues are addressed before the build process starts.
Updated YAML File Example:
name: Build and Publish Android Project

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - name: Checkout repository
      uses: actions/checkout@v2

    - name: Free Disk Space Before Build
      run: |
        echo "Disk space before cleanup:"
        df -h
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost
        sudo apt-get clean
        echo "Disk space after cleanup:"
        df -h

    - name: Set up JDK
      uses: actions/setup-java@v2
      with:
        distribution: 'adopt'
        java-version: '11'

    - name: Install dependencies
      run: |
        sudo apt-get update
        sudo apt-get install -y your-required-packages

    - name: Cache Gradle files
      uses: actions/cache@v2
      with:
        path: ~/.gradle/caches
        key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
        restore-keys: |
          ${{ runner.os }}-gradle-

    - name: Build the Android project
      run: ./gradlew build

    - name: Publish to Firebase App Distribution
      run: |
        # Your commands to publish the build to Firebase

    - name: Free Disk Space After Build
      run: |
        echo "Disk space before post-build cleanup:"
        df -h
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost
        sudo apt-get clean
        echo "Disk space after post-build cleanup:"
        df -h

This approach 1 ensures that cleanup is performed before every build, preventing disk space issues from affecting the build process.
Approach 2: Create a Separate Cleanup YAML File
You can try to create a separate YAML file dedicated to disk space cleanup. This approach allows you to trigger the cleanup workflow manually or on a schedule, without cluttering the main build YAML file.
Cleanup YAML File Example:
name: Free Disk Space

on:
  workflow_dispatch:  # Trigger manually
  schedule:
    - cron: '0 0 * * *'  # Runs daily at midnight

jobs:
  cleanup:
    runs-on: ubuntu-latest

    steps:
    - name: Free Disk Space
      run: |
        echo "Disk space before cleanup:"
        df -h
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost
        sudo apt-get clean
        echo "Disk space after cleanup:"
        df -h

Main Build YAML File (Simplified) which is as follows:-
name: Build and Publish Android Project

on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - name: Checkout repository
      uses: actions/checkout@v2

    - name: Set up JDK
      uses: actions/setup-java@v2
      with:
        distribution: 'adopt'
        java-version: '11'

    - name: Install dependencies
      run: |
        sudo apt-get update
        sudo apt-get install -y your-required-packages

    - name: Cache Gradle files
      uses: actions/cache@v2
      with:
        path: ~/.gradle/caches
        key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
        restore-keys: |
          ${{ runner.os }}-gradle-

    - name: Build the Android project
      run: ./gradlew build

    - name: Publish to Firebase App Distribution
      run: |
       # Your commands to publish the build to Firebase

This approach 2 provides flexibility, allowing you to trigger cleanup manually or on a schedule. This keeps the main build YAML file clean and focused.
So, by the above approaches, you will able to fix those issues.

I'm still experiencing the same issue, even with the (seemingly) new image:
Current runner version: '2.319.0'
Operating System
  Ubuntu
  22.04.4
  LTS
Runner Image
  Image: ubuntu-22.04
  Version: 20240804.1.0
  Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20240804.1/images/ubuntu/Ubuntu2204-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240804.1
Runner Image Provisioner
  2.0.374.1

I cannot do any clean-up steps since the role of the runner image is simply to load another linux's docker container. The free space seems to have gotten lower in the last 6 to 12 months from about 26GB down to 19GB at the moment. It was 21GB 3 weeks ago. I have a df at the beginning of the start of the container.
Switching from ubuntu-latest (22.04) to ubuntu-24.04 explicitly, gives me an extra 10GB from 19GB back to 30GB.
I am wondering if the apt-get clean should get done at the end of the preparation of the runner image itself, since the runner image seems to have gotten gradually worse over time.
sudo apt-get clean

I am doing
    runs-on: ubuntu-24.04 # unbuntu-latest is 22.04
    container: fedora:40

so any clean-up of ubuntu can't be done.

getting this issue on the m1 Mac runners as well. Only started today.

Also seeing this in Firebase builds on the macos-14 runner starting Friday, August 30, on otherwise unchanged configurations - https://github.com/firebase/firebase-ios-sdk/actions/runs/10626580586

@alainib @danibonilha @mantljosh - By this week, new image version will be rolled out. So, kindly try once after new image version rolled out. However, for you, I am providing an updated workflow that integrates more aggressive cleanup steps:-
name: Build and Publish Android Project

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-22.04  # Specify a fixed version of Ubuntu

    steps:
    - name: Checkout repository
      uses: actions/checkout@v2

    - name: Free Disk Space Before Build
      run: |
        echo "Disk space before cleanup:"
        df -h
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost
        sudo apt-get clean
        echo "Disk space after cleanup:"
        df -h

    - name: Set up JDK
      uses: actions/setup-java@v2
      with:
        distribution: 'adopt'
        java-version: '11'

    - name: Install dependencies
      run: |
        sudo apt-get update
        sudo apt-get install -y your-required-packages

    - name: Cache Gradle files
      uses: actions/cache@v2
      with:
        path: ~/.gradle/caches
        key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
        restore-keys: |
          ${{ runner.os }}-gradle-

    - name: Build the Android project
      run: ./gradlew build

    - name: Publish to Firebase App Distribution
      run: |
        # Your commands to publish the build to Firebase

    - name: Free Disk Space After Build
      run: |
        echo "Disk space before post-build cleanup:"
        df -h
        sudo rm -rf /usr/local/.ghcup
        sudo rm -rf /opt/hostedtoolcache/CodeQL
        sudo rm -rf /usr/local/lib/android/sdk/ndk
        sudo rm -rf /usr/share/dotnet
        sudo rm -rf /opt/ghc
        sudo rm -rf /usr/local/share/boost
        sudo apt-get clean
        echo "Disk space after post-build cleanup:"
        df -h

Explanation:- Pre-Build Cleanup:
The script cleans up various large directories (/usr/local/.ghcup, /opt/hostedtoolcache/CodeQL, /usr/local/lib/android/sdk/ndk, /usr/share/dotnet, /opt/ghc, /usr/local/share/boost) to free up space. df -h is used to show the disk space before and after cleanup for monitoring purposes. Post-Build Cleanup:
Similar cleanup steps are performed after the build to ensure any temporary files created during the build process are removed. df -h is again used to show the disk space before and after cleanup.
By this approach, you should be able to manage disk space more effectively and prevent build failures due to insufficient disk space.

works!

I have the similar problems. Why not increase the disk size of action runner to about 50G free.

Prabhatkumar59

@Prabhatkumar59 Hi, I didn't understand your approach 2, when the main build job trigger cleanup job? I didn't find the connection between them. Could you explain more in details.

this is fixed now, right?


[BUG] Mismatched number of columns while performing GpuSort

We are seeing an exception on 9 tests of the integration suite when executing in a distributed fashion (a box with 4 T4s), and we run with UCX. I haven't run without UCX in this environment, so I am not entirely sure if it's UCX specific or just the distributed part.
The tests that failed are:
05:18:07  FAILED ../../src/main/python/repart_test.py::test_round_robin_sort_fallback[[('a', Struct(('a_1', Struct(('a_1_1', Integer)))))]][IGNORE_ORDER({'local': True}), ALLOW_NON_GPU(ShuffleExchangeExec,RoundRobinPartitioning)]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a ASC NULLS FIRST'>0-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-True-200]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a ASC NULLS FIRST'>0-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-False-200]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a ASC NULLS FIRST'>1-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-True-200]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a ASC NULLS FIRST'>1-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-False-200]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a DESC NULLS LAST'>0-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-True-200]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a DESC NULLS LAST'>0-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-False-200]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a DESC NULLS LAST'>1-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-True-200]
05:18:07  FAILED ../../src/main/python/sort_test.py::test_single_nested_orderby_plain[Column<b'a DESC NULLS LAST'>1-Struct(['child0', Byte],['child1', Short],['child2', Integer],['child3', Long],['child4', Float],['child5', Double],['child6', String],['child7', Boolean],['child8', Date],['child9', Timestamp],['child10', Null])-False-200]

The exception was in GpuSort while in upperBound:
Caused by: ai.rapids.cudf.CudfException: cuDF failure at: row_operators.cuh:361: Mismatched number of columns.
    at ai.rapids.cudf.Table.bound(Native Method)
    at ai.rapids.cudf.Table.upperBound(Table.java:1409)
    at ai.rapids.cudf.Table.upperBound(Table.java:1434)
    at com.nvidia.spark.rapids.GpuSorter.$anonfun$upperBound$2(SortUtils.scala:168)
    at com.nvidia.spark.rapids.Arm.withResource(Arm.scala:28)
    at com.nvidia.spark.rapids.Arm.withResource$(Arm.scala:26)
    at com.nvidia.spark.rapids.GpuSorter.withResource(SortUtils.scala:65)
    at com.nvidia.spark.rapids.GpuSorter.$anonfun$upperBound$1(SortUtils.scala:167)
    at com.nvidia.spark.rapids.Arm.withResource(Arm.scala:28)
    at com.nvidia.spark.rapids.Arm.withResource$(Arm.scala:26)
    at com.nvidia.spark.rapids.GpuSorter.withResource(SortUtils.scala:65)
    at com.nvidia.spark.rapids.GpuSorter.upperBound(SortUtils.scala:166)
    at com.nvidia.spark.rapids.GpuRangePartitioner.$anonfun$computeBoundsAndClose$4(GpuRangePartitioner.scala:187)
    at com.nvidia.spark.rapids.Arm.withResource(Arm.scala:28)
    at com.nvidia.spark.rapids.Arm.withResource$(Arm.scala:26)
    at com.nvidia.spark.rapids.GpuRangePartitioner.withResource(GpuRangePartitioner.scala:167)
    at com.nvidia.spark.rapids.GpuRangePartitioner.$anonfun$computeBoundsAndClose$3(GpuRangePartitioner.scala:186)
    at com.nvidia.spark.rapids.Arm.withResource(Arm.scala:28)
    at com.nvidia.spark.rapids.Arm.withResource$(Arm.scala:26)
    at com.nvidia.spark.rapids.GpuRangePartitioner.withResource(GpuRangePartitioner.scala:167)
    at com.nvidia.spark.rapids.GpuRangePartitioner.$anonfun$computeBoundsAndClose$2(GpuRangePartitioner.scala:184)
    at com.nvidia.spark.rapids.Arm.withResource(Arm.scala:28)
    at com.nvidia.spark.rapids.Arm.withResource$(Arm.scala:26)
    at com.nvidia.spark.rapids.GpuRangePartitioner.withResource(GpuRangePartitioner.scala:167)
    at com.nvidia.spark.rapids.GpuRangePartitioner.$anonfun$computeBoundsAndClose$1(GpuRangePartitioner.scala:182)
    at com.nvidia.spark.rapids.Arm.withResource(Arm.scala:28)
    at com.nvidia.spark.rapids.Arm.withResource$(Arm.scala:26)
    at com.nvidia.spark.rapids.GpuRangePartitioner.withResource(GpuRangePartitioner.scala:167)
    at com.nvidia.spark.rapids.GpuRangePartitioner.computeBoundsAndClose(GpuRangePartitioner.scala:180)
    at com.nvidia.spark.rapids.GpuRangePartitioner.columnarEval(GpuRangePartitioner.scala:201)
    at org.apache.spark.sql.rapids.execution.GpuShuffleExchangeExec$.$anonfun$prepareBatchShuffleDependency$3(GpuShuffleExchangeExec.scala:205)
    at org.apache.spark.sql.rapids.execution.GpuShuffleExchangeExec$$anon$1.partNextBatch(GpuShuffleExchangeExec.scala:226)
    at org.apache.spark.sql.rapids.execution.GpuShuffleExchangeExec$$anon$1.hasNext(GpuShuffleExchangeExec.scala:237)
    at scala.collection.Iterator.foreach(Iterator.scala:941)
    at scala.collection.Iterator.foreach$(Iterator.scala:941)
    at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
    at org.apache.spark.sql.rapids.RapidsCachingWriter.write(RapidsShuffleInternalManagerBase.scala:97)
    at org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59)
    at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99)
    at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:52)
    at org.apache.spark.scheduler.Task.run(Task.scala:127)
    at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:462)
    at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1377)
    at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:465)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    ... 1 more

This issue can be reproduced locally with #2507
TEST_PARALLEL=1 \
SPARK_HOME=~/dist/spark-3.1.1-bin-hadoop3.2 \
./integration_tests/run_pyspark_from_build.sh -k 'test_large_orderby and Struct'

This issue can be reproduced locally with #2507
TEST_PARALLEL=1 \
SPARK_HOME=~/dist/spark-3.1.1-bin-hadoop3.2 \
./integration_tests/run_pyspark_from_build.sh -k 'test_large_orderby and Struct'

The other important part is to be able to match the same number of tasks.  How many tasks did this run with, typically the number of CPU threads that your processor has?

I ran with @gerashegalov's branch locally with 12 tasks (that's the number of cores I have), for test_large_orderby[Struct(('child0', Long)):
../../src/main/python/sort_test.py::test_large_orderby[Struct(('child0', Long))] 21/05/26 13:22:36 ERROR Executor: Exception in task 6.0 in stage 5.0 (TID 66)
ai.rapids.cudf.CudfException: cuDF failure at: /home/jenkins/agent/workspace/jenkins-cudf_nightly-dev-github-324-cuda11/cpp/include/cudf/table/row_operators.cuh:361: Mismatched number of columns.
	at ai.rapids.cudf.Table.bound(Native Method)
	at ai.rapids.cudf.Table.upperBound(Table.java:1409)
	at ai.rapids.cudf.Table.upperBound(Table.java:1434)
	at com.nvidia.spark.rapids.GpuSorter.$anonfun$upperBound$2(SortUtils.scala:168)

These other tests passed:
../../src/main/python/sort_test.py::test_large_orderby_stable[Struct(('child0', Long))] PASSED [ 66%]
../../src/main/python/sort_test.py::test_large_orderby_nested_ridealong[Struct(('child1', Byte))] PASSED [100%]

I will get a repro case for cudf and file an issue

@revans2 sorry, I was looking into it, we synced, I'll take over and file an issue.

Seeing it here https://github.com/NVIDIA/spark-rapids/blob/branch-21.06/sql-plugin/src/main/scala/com/nvidia/spark/rapids/SortUtils.scala#L168, where both findInTable and findTable are struct columns, and have 0 nulls. Getting CUDF C++ build going to add a test.
One interesting thing is that the single row in findTbl is not in findInTbl.
FIND IN TBL => Table{columns=[ColumnVector{rows=1024, type=STRUCT, nullCount=Optional[0], offHeap=(ID: 1646 7fa9bc0d8440)}], cudfTable=140366980782704, rows=1024}
FIND TBL: Table{columns=[ColumnVector{rows=1, type=STRUCT, nullCount=Optional[0], offHeap=(ID: 1651 7fa9bc0d8340)}], cudfTable=140366981198240, rows=1}

@revans2 I ran out of time yesterday to look deeper for even smaller , potentaill/y cudf-only repro , for this issue. I  first  encountered  it  with NUM_LOCAL_EXECS=2 CORES_PER_EXEC=6 but then consistently reproduced it with the single-JVM local mode with the command provided. My desktop has 12 cores.

Merged @gerashegalov's change with the added test, which is now passing CI.


Add some default JDK-level class blacklisting to inspection

The io.syndesis.connector.salesforce.Contact object is heavily generic, parameterized and extended. This results in a lot of unnecessary inspection on inner member fields that do not need to be presented to the end user.


Add support for "caching" reflection and tags?

Hello I found this module and it makes what I'm trying to do a lot easier.
One ask I have is if we could "cache" the reflect parsing ahead of time instead of need to re-compute it each time we try to decode a struct -- the reason I'd like this is that I'm using this decoder in my http handler (built on top of Gin) and the decoder/parsing doesn't change from type to type, but having to re-reflect each and every request is a bit wasteful.
I'm more than happy to open a PR to this if you are happy with this?
My rough idea is to turn this
func Decode(targetStruct interface{}, decoder TagDecoder) error {
	t, v, fields, err := getStructInfo(targetStruct)
	if err != nil {
		return err
	}
	...
}

Into this:
func Decode(targetStruct interface{}, tagDecoder TagDecoder) error {
	structDecoder, err := NewDecoder(targetStruct, tagDecoder)
	if err != nil {
		return err
	}
	err = structDecoder.Decode(targetStruct)
	if err != nil {
		return err
	}
}
type StructDecoder struct {
	Type reflect.Type
	Fields []Field
}

func NewDecoder(targetStruct interface{}, tagDecoder TagDecoder), (s StructDecoder, err error){
	s.Type, _, s.Fields, err := getStructInfo(targetStruct)
}

func (s StructDecoder) Decode(targetStruct interface{}) error {
	t = s.Type
	fields = s.Fields
	v  := reflect.ValueOf(targetStruct)
	// Rest of existing code
	...
}

Names could probably do some work, but something like this.
Thoughts?

Hello @ashb, sorry for the delay to answer, yeah this might be a good thing indeed, I had a similar problem actually when I was thinking about using this library on a similar situation (wrapping an http library).
Ok so some things to keep in mind before I go too much into this:
The first thing is that we should probably have a benchmark, odds are this might not really cause any impact on performance since the operations to read the type and etc might not be the slow part of the reflection.
Check This Benchmark I wrote, with focus on these two values:

toMapWithNoReflection taking 523
toMapUsingCachedTagNames taking 607

The first one is literally using zero reflection, and the second one is more or less what we are doing here. The difference is small 523 vs 607 (i.e. only 16% slower with reflection), and with bigger data types this tends to become even less significant. So for example if this new solution adds a single operator of full-copy of the struct this might be enough the make it as performant as what we currently have. (I can write this benchmark for us I think)
Also on the same benchmark above you will see what is the actually slow part of reflection: testing_toMapUsingTag. i.e. if we need to parse the tags on every operation it makes the whole process extremely slow, and this is being cached already.
The second is that even though this library is very small at the moment (since I am not promoting it yet), I would like to try to think of the best interface we can give to the user. So I will need to brain storm a little about it.

Finally about your current proposal, as an API for the library this might be unsafe in the sense that a library should never panic unless if it is an actual code error. And being able to pass a different struct on the call to Decode() would probably cause a panic unless we added at least one more type check e.g.:
func (s StructDecoder) Decode(targetStruct interface{}) error {
	t = s.Type
	fields = s.Fields
	v  := reflect.ValueOf(targetStruct)
	if v.Type() != s.OriginalType {
		return fmt.Errorf("types must match ...", ...)
	}

So the implementation would look something like this:
func Decode(targetStruct interface{}, tagDecoder TagDecoder) error {
	structDecoder, err := NewDecoder(targetStruct, tagDecoder)
	if err != nil {
		return err
	}
	err = structDecoder.Decode(targetStruct, tagDecoder)
	if err != nil {
		return err
	}
}

type StructDecoder struct {
	targetStruct interface{}
	originalType reflect.Type
	type reflect.Type
	fields []Field
}

func NewDecoder(targetStruct interface{}, tagDecoder TagDecoder), (s StructDecoder, err error){
	s.targetStruct = targetStruct

	// Here I added an extra return value with the original type:
	s.originalType, s.type, _, s.fields, err := getStructInfo(targetStruct)

	return s, err // I prefer to always use explicit returns
}

func (s StructDecoder) Decode(targetStruct interface{}) error {
	t = s.type
	fields = s.fields
	v  := reflect.ValueOf(targetStruct)
	if v.Type() != s.OriginalType {
		return fmt.Errorf("struct decoder expected an instance of %v but got %v", s.OriginalType, v.Type())
	}

	// Rest of existing code
	...
}

That said I am still thinking if we can come up with a better API, right now the usage of this flow would look like this:
type Request struct{
    // ... some attrs ...
}

func someWorker(inputCh chan Args, outCh chan Request) {
	structDecoder, err := structscanner.NewDecoder(&Request{})
	if err != nil {
		return err
	}

	for _, dataSource := range inputCh {
		var req Request
		err = structDecoder.Decode(&req, NewMyTagDecoder(dataSource))
		if err != nil {
			return err
		}
		outCh <- req
	}
}

I think it is actually a nice solution. It is not too complicated, and I don't foresee any future issues 🤔
I think you can go for it. I will try to write the benchmark for the current version today, so when we have your PR we can compare the implementations, if it is at least slightly faster we should keep it.

Sounds good!
Another thought as a way to avoid panic might be to use generics - that way passing the wrong struct type to Decode becomes a compile error
One other thing I would find useful is the ability to access the Fields[] outside of decoding a struct as part of OpenAPI spec generation

Hmmm, @ashb actually it occurred to me a solution that might do the exact same number of operations but keeping the current API, maybe we can just improve the caching system to do less operations before using the cache, because currently this is what we have:
func getStructInfo(targetStruct interface{}) (reflect.Type, reflect.Value, []Field, error) {
	v := reflect.ValueOf(targetStruct)
	t := v.Type()
	if t.Kind() != reflect.Ptr {
		return nil, reflect.Value{}, nil, fmt.Errorf("expected struct pointer but got: %T", targetStruct)
	}
	if v.IsNil() {
		return nil, reflect.Value{}, nil, fmt.Errorf("expected non-nil pointer to struct, but got: %#v", targetStruct)
	}

	t = t.Elem()

	if t.Kind() != reflect.Struct {
		return nil, reflect.Value{}, nil, fmt.Errorf("can only get struct info from structs, but got: %#v", targetStruct)
	}

	data, _ := structInfoCache.Load(t)
	info, ok := data.([]Field)
	if ok {
		return t, v, info, nil
	}
	// ...
}

But what if instead we used the original type as key on the cache, this would allow us to skip several operations, e.g.:
func getStructInfo(targetStruct interface{}) (reflect.Type, reflect.Value, []Field, error) {
	v := reflect.ValueOf(targetStruct)
	t := v.Type()

	data, _ := structInfoCache.Load(t)
	info, ok := data.([]Field)
	if ok {
		return info.Type, v, info.Fields, nil
	}

	if t.Kind() != reflect.Ptr {
		return nil, reflect.Value{}, nil, fmt.Errorf("expected struct pointer but got: %T", targetStruct)
	}
	if v.IsNil() {
		return nil, reflect.Value{}, nil, fmt.Errorf("expected non-nil pointer to struct, but got: %#v", targetStruct)
	}

	t = t.Elem()

	if t.Kind() != reflect.Struct {
		return nil, reflect.Value{}, nil, fmt.Errorf("can only get struct info from structs, but got: %#v", targetStruct)
	}

	// ...
}

This would mean that before we started doing the operations we would only perform one call to reflect.ValueOf and another to v.Type() which we would necessarily also have to make on your implementation, what do you think about this simpler approach, is there something I am missing?

That night work too yes, and my other ask could be met by making that function exported

Would it really be necessary to export it? 🤔
I think that with this optimization having just using the existing structdecoder.Decode() function would be exactly as efficient for handling several different structs as it is in the proposal above for the same struct.
Like the best of both worlds: We could keep the API as simple as possible (a single public Decode function) while also having the best performance possible.

Export wouldn't be needed for this, no, but I'd like to reuse this information in other ways

Sounds good!
Another thought as a way to avoid panic might be to use generics - that way passing the wrong struct type to Decode becomes a compile error
One other thing I would find useful is the ability to access the Fields[] outside of decoding a struct as part of OpenAPI spec generation

Oh sorry I missed this message.
Yeah, indeed using generics here might work for that. But then we would have to make the benchmark to be sure this optimization is really improving performance since generics docs do mention some performance loss.
About your last comment, yeah you want to have this information about the fields outside.
I think it's a good idea too, we just need to make sure we return a struct so it's easier to add more fields as necessary in the future.

Finally now you mentioned Open API I think you might be thinking about implementing something I am also thinking about.
Are you thinking about implementing an http server framework that supports structs as inputs and outputs in order to (among other things) build a swagger doc automatically?

Hey @ashb, I really liked both your suggestions, do you want to implement them? If you do, I will leave it to you so you can add your name to the project, otherwise I can implement them myself too.
And again thanks for opening this issue =].

Are you thinking about implementing an http server framework that supports structs as inputs and outputs in order to (among other things) build a swagger doc automatically?

Yes, exactly. I am initially building it on top of Gin as that's what we use at my work. I've got 90% of a poc already written


Covid 19 immunization plan

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

is there an issue this is linked to? can you please add that to the description, or add an issue if it does not exist

This PR is good to go @maimoonak.

Relevant tickets https://github.com/google/android-fhir/issues/2036 and https://github.com/google/android-fhir/pull/2016 and https://github.com/google/android-fhir/pull/2032


Update package.json

Updated dependencies to resolve issues with accessing the dataSign function in the @stardust-collective/dag4 library. This includes:

Upgraded @stardust-collective/dag4 to version ^9.5.1
Ensured compatibility with the required functions for signing data.

These changes should resolve the current TypeError and ensure the correct functionality of the script.

Hi @dann5525 - would you file an issue that describes what this PR is aiming to solve?
The latest dag4 package version is v2.2.2 so this change should fail.
https://www.npmjs.com/package/@stardust-collective/dag4?activeTab=versions


Add ability to configure access-control list (ACL) on project's resources

What would you like to be added:
Currently, each project has 3 teams (admin, editor, view)  and the permissions associated with all project's resources are based on the team.
Some projects, they need to divide the team become smaller for better management,
so support multiple editor teams and multiple view teams or allow configuring ACL on each project`s resource would be considered.
Why is this needed:

/assign @nakabonne


Modals now close map, wiki, and chat asides when they are displayed

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (Closes #XXXX): Closes

Description

Fixed issue where modals could be blocked by aside panes. Now when a modal opens, all asides will be collapsed. The help button was also modified to close other asides before opening the help chat room.
closes #8372

Thanks a lot @vcooley for the PR. I think this is intuitive behavior.
/cc : @hallaathrad will you please to take a look and QA this.

Tried, but my local fails because of Node 6
See this for others having the same issue.

@hallaathrad
Seems your local setup is not supported on Node 6. Its known that the dependencies would break on higher node versions.
I have this running on the C9 VM for FCC that we worked on sometime back. You have got access to it, you could check on that, if you want.
Nevertheless, if you prefer checking it on local then maybe you have to use a Node version manager and install Node 4 I guess.
But just for info I have checked this and the basic functionality seems to be working. Hit me up if you want to see it working.

This works for me, unless anyone else sees anything broken lets ship this!
@hallaathrad do you want to add any changes?

:sparkles: :sparkles: LGTM. :sparkles: :sparkles:
Thanks.


Error handling

Added a callback for error handling, e.g. to display a message instead of the failed item (that's what I'm using it for in our app).
Will get called for error events on:

img tags: will happen if image fails to load or decode (unknown format). Note that the preloading will fail silently, because the error will be thrown again when displaying, and it makes more sense to handle it when the item is expected to be displayed.
source tags in audio or video items: if the media item fails to load or play (unknown format)
iframe tags: any error. I didn't test this one.

The callback gets container and activeItem like all the others already present, plus the error itself.
I'm using Windows so I didn't commit the build outputs because they are different from yours (backslashes etc.). Let me know if I should change something else.

Thanks, I'll review it in the next few days

Added in 1.1.7.
I did remove the iframe listener because it's not as simple to implement as the others. If users need to add their own logic for iframes, it can be done with onOpen or onUpdate.


[error-tests] added some more tests

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #65   +/-   ##
======================================
  Coverage    81.2%   81.2%
======================================
  Files           2       2
  Lines         463     463
======================================
  Hits          376     376
  Misses         87      87


Error when running ./startReplica.sh

Hello here are the steps i followed installing and running hyperledger-bftsmart.
i did git clone https://github.com/jcs47/fabric
into the path $GOPATH/src/github.com/hyperledger/
installed all the Pre-requisites for the Hyperledger
Also installed JUDS library
Then i did these
cd $GOPATH/src/github.com/hyperledger/fabric/
sudo ./devenv/setupUbuntuOnPPC64le.sh
make dist-clean peer orderer configtxgen
export FABRIC_CFG_PATH=$GOPATH/src/github.com/hyperledger/fabric/sampleconfig/
Also i donfiguerd the absolute paths for CERTIFICATE  and PRIVKEY.
and then:
cd $GOPATH//src/github.com/hyperledger/hyperledger-bftsmart
i run
ant and then
./startReplica.sh 0
and i get this error
mitaros@dsg2:~/GoProjects/src/github.com/hyperledger/hyperledger-bftsmart$ sudo ./startReplica.sh 0
Exception in thread "main" org.bouncycastle.openssl.PEMException: unable to convert key pair: EC KeyFactory not available
	at org.bouncycastle.openssl.jcajce.JcaPEMKeyConverter.getKeyPair(Unknown Source)
	at bft.BFTNode.getPemPrivateKey(BFTNode.java:797)
	at bft.BFTNode.loadConfig(BFTNode.java:197)
	at bft.BFTNode.<init>(BFTNode.java:130)
	at bft.BFTNode.main(BFTNode.java:223)
Caused by: java.security.NoSuchAlgorithmException: EC KeyFactory not available
	at java.security.KeyFactory.<init>(java.base@9-internal/KeyFactory.java:138)
	at java.security.KeyFactory.getInstance(java.base@9-internal/KeyFactory.java:180)
	at org.bouncycastle.jcajce.util.DefaultJcaJceHelper.createKeyFactory(Unknown Source)
	at org.bouncycastle.openssl.jcajce.JcaPEMKeyConverter.getKeyFactory(Unknown Source)
	... 5 more
mitaros@dsg2:~/GoProjects/src/github.com/hyperledger/hyperledger-bftsmart$

The solution was to add hyperledger-bftsmart into the $GOPATH//src/github.com/hyperledger/fabric