Move world object shapes from PlanningScene

Description
Adds the ability to move the object shape poses from the PlanningScene.
One must supply all the shape poses. We could use some of the CollisionObject field to only update the desired poses, but it would be hacky.
https://github.com/moveit/moveit/assets/32679594/c5916553-1327-4c4a-944d-34d79d99b82e

Codecov Report
Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 47.18%. Comparing base (c174715) to head (26cd8bf).
Report is 13 commits behind head on master.

Files
Patch %
Lines

moveit_core/planning_scene/src/planning_scene.cpp
0.00%
19 Missing :warning:

moveit_core/collision_detection/src/world.cpp
0.00%
9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3599      +/-   ##
==========================================
+ Coverage   47.15%   47.18%   +0.04%
==========================================
  Files         603      603
  Lines       58999    59141     +142
  Branches     6969     7002      +33
==========================================
+ Hits        27814    27902      +88
- Misses      30773    30821      +48
- Partials      412      418       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Moving meshes seems to not be as cheap in terms of CPU time. It takes 0.3 seconds to update my object which contains 3 meshes. Only 2 of the 3 meshes are actually updated. These meshes are somewhat detailed.
I think that the FCL collision environment removes the FCL object and recreates it instead of just updating the poses of it's shapes. Will try and fix that, but this is another issue, so not related to this PR.


proxy

harbor give error message when backend haproxy (haproxy work with ssl and 443 port, harbor not ssl and 80 port),
how can i do this configuration
haproxy and harbor use same ssl ignore this error
i dont think the right way
error message is
Failed to get secret cookie, error: http: named cookie not present
token.go:53]: uid for logging:
authenticator.go:57]: Current AUTH_MODE is db_auth
authenticator.go:69]: Login failed, locking , and sleep for 1.5s
login request with invalid credentials in token service, uid:

Harbor does not support the scenario that deploying Harbor behind another proxy for now.


Docker development environment update and packages cleanup

Cleaning up apt packages result in a much smaller docker image
Updating to support Node v6
Enabling npm install for development environment for quickly refreshing the container without building

On second thought, I don't think we need to wait for @helxsz to report back. These changes accomplish the goal of cleaning up the Docker image and having the development configuration install the packages & start the application will really help out during development.
I say merge when you're ready.

Cool, merging in.
I'm working with these changes locally and haven't seen any issues yet.


feat(concurrency): add halt() to scheduler

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.49%. Comparing base (139a010) to head (8e5600d).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           avi/scheduler/add-commit    #1891      +/-   ##
============================================================
- Coverage                     77.93%   77.49%   -0.44%
============================================================
  Files                            60       60
  Lines                          8723     8602     -121
  Branches                       8723     8602     -121
============================================================
- Hits                           6798     6666     -132
- Misses                         1496     1497       +1
- Partials                        429      439      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crates/blockifier/src/concurrency/scheduler.rs line 30 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Can you please elaborate?

I just mean that if there is some logic that the executor runs after the final transaction of the block, and it should only run once, then this marker is used to check whether the thread that called the halt() method is actually the thread that halted the scheduler (i.e., no other thread called halt() earlier).

crates/blockifier/src/concurrency/scheduler_test.rs line 218 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Why incarnate? Shouldn't it be something closer to execute or run?

Most of the names come from the BlockSTM paper, and we avoided changing them to make it easier to compare our code to the algorithm in the paper. The word incarnate comes from the fact that any given execution of the same tx is called an "incarnation" in the paper.

+reviewer:@Yoni-Starkware

crates/blockifier/src/concurrency/scheduler.rs line 46 at r8 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
done should be the last operation on the scheduler (no bug right now but better to be safe)

Done.


How to do EMA update of the teacher model in accelerate?

The template for the training of student and teacher model in  https://github.com/microsoft/esvit/blob/main/main_esvit.py has the following way to update teacher parameters during an epoch.

def train_one_epoch(student, teacher, teacher_without_ddp, dino_loss, data_loader, optimizer, lr_schedule, wd_schedule, momentum_schedule, epoch, mixup_fn, p16_scaler, args):

`# EMA update for the teacher

with torch.no_grad():

m = momentum_schedule[it]  # momentum parameter
for param_q, param_k in zip(student.module.parameters(), teacher_without_ddp.parameters()):

param_k.data.mul_(m).add_((1 - m) * param_q.detach().data)`

As done in https://github.com/microsoft/esvit/blob/main/main_esvit.py for distributed data parallel training. teacher_without_dpp is also passed during training for updating the teacher parameters manually, since no gradients are backpropogated through the teacher.
If I am using accelerate for distributing training:
student, teacher,  optimizer, data_loader= accelerator.prepare(student, teacher, optimizer, data_loader)
How should the teacher update look like?

`# EMA update for the teacher

with torch.no_grad():

m = momentum_schedule[it]  # momentum parameter
for param_q, param_k in zip(student.parameters(), teacher.parameters()):

param_k.data.mul_(m).add_((1 - m) * param_q.detach().data)`

cc @muellerzr

As accelerate lightly wraps around pytorch, it'd look such that:
    student, teacher, optimizer, data_loader= accelerator.prepare(
        student, teacher, optimizer, data_loader
    )
    # EMA update for the teacher
    with torch.no_grad():
        m = momentum_schedule[it] # momentum parameter
        for param_q, param_k in zip(student.module.parameters(), teacher.module.parameters()):
            param_k.data.mul_(m).add_((1 - m) * param_q.detach().data)

However to fully recreate it the exact same (such that the teacher is not on DDP), your code must look like so:
    student, optimizer, data_loader= accelerator.prepare(
        student, teacher, optimizer, data_loader
    )
    teacher.to(accelerator.device) # If they change the device of the teacher in the code
    # EMA update for the teacher
    with torch.no_grad():
        m = momentum_schedule[it] # momentum parameter
        for param_q, param_k in zip(student.module.parameters(), teacher.parameters()):
            param_k.data.mul_(m).add_((1 - m) * param_q.detach().data)


Refactor/Deprecate createDataStoreWithProps

Context: #1537, #3631
The _createDataStoreWithProps function defined in interface IContainerRuntimeBase and its implementation class ContainerRuntime were deprecated in 0.16 and should be removed.
The following files are affected:

\packages\runtime\runtime-definitions\src\dataStoreContext.ts
\packages\runtime\container-runtime\src\dataStoreContext.ts

There are no remaining uses inside of FluidFramework, but there are uses found within partner repos, so those must be removed first before they are removed from FluidFramework.

Duplicate of https://github.com/microsoft/FluidFramework/issues/3631.


ButtonSetWithOverflow causing an error in react-resize-detector

Found when using PageHeader with pageActions provided on all recent versions of the package.
Shortly after initial render, the component crashes with an error:
TypeError
Argument 1 ('target') to ResizeObserver.observe must be an instance of Element

The simplest recreate is to access the component in your own code sandbox:
https://codesandbox.io/s/github/carbon-design-system/ibm-cloud-cognitive/tree/main/examples/carbon-for-ibm-products/PageHeader?file=/src/components/SamplePage/SamplePage.js:776-787
Accessing this today in Safari results in the above error.
Removing the pageActions property of PageHeader avoids the issue. It also means that no ButtonSetWithOverflow is rendered, which is where I think the problem ultimately lies.

Having same issue. Will be glad to have it fixes in some future version.

This seems to have been resolved in 1.10, please re-open if still seeing this issue.


chore(xp-treatment): Upgrade hpa API to autoscaling/v2

Motivation
Autoscaling API version autoscaling/v2beta2 is removed in Kubernetes 1.26: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v126
Modification
Upgrading the xp-treatment chart to use autoscaling/v2 that's available since Kubernetes 1.23
Checklist

[x] Chart version bumped
[x] README.md updated

Wait what that's it? 😅 I wasn't expecting it to be so... simple :O

Wait what that's it? 😅 I wasn't expecting it to be so... simple :O

That's it lol. Thanks for the quick review. Merging!


Have i been blocked form using this.

I keep getting this message each time. I have this setup to run hourly I wouldn't have thought that would have been classed as spam

https://github.com/rg3/youtube-dl#http-error-429-too-many-requests-or-402-payment-required
#5138.


Load3D missing node Types

newest version: Load3D missing node Types  in workflow ID_TRELLIS_WF_multy.json

you need to be on the latest comfyui to use that node also I update the workflows it should work now


fix(JumpLine): Fix wrong message when jump line

What this PR does 📖
1. Fix wrong message when jump line

Which issue(s) this PR fixes 🔨

Resolve #673

Special notes for reviewers 🗒
Additional comments 🎤

that last message started with 3 backticks and the word "rust", which should have made the message be formatted as rust code


Support several default sourcemap loaders

Eg, a transformationChain, where a series of transformations on a single file are remapped to a root sorucemap

Or a builder API:
// Given 3 transforms on a file x.js:
const builder = new resorcery.Builder(thirdSourcemap);

const secondMap = builder.traceSource(0, secondSourcemap);

const firstMap = secondMap.traceSource(0, originalFile);

etc.


OData filter field list in APIM List APIs by service is slightly inaccurate

In https://docs.microsoft.com/en-us/rest/api/apimanagement/2019-12-01/apis/listbyservice the OData filter section of the document includes a list of the fields that can be included in filter clauses.
For all but name the actual OData query needs to prefix the names with "properties/" - e.g. to filter by displayname you would use "properties/displayname" not "displayname" as documented

@delradie Your link is not found.


Add rxm7706 as BackUp maintainter to Otel suite of feedstocks

Summary:

All 50+ feedstocks for open telemetry have only one maintainer mariusvniekerk; who is a key contributor to conda-forge, working on more important items with other core / admins. I've updated the title too that shows all the add maintainer PRs together.
Because of the levels of dependency - this suite ends up needing custom analysis and sequential re-execution every release - I have made PR's and rerun, waited for weeks for an admin to merge for the last 3 release this year.
I currently own and have helped maintain over 200+ feedstocks on conda-forge - so I'm happy to help where I can.

My thought process was - the simplest contribution I could made was figure out the dependency and take rerun's, the easy fixes of dependency version changes and keep this suite uptodate for everyone. My list of ten PRs to add me as co-maintainer - addresses the packages the rest depend on - and I believe If I can keep those 10 uptodate, the rest are easier to tackle, and I have PRs open to add me as an alternate maintainer linked above
Tracking:

Used and needed for Airflow

https://github.com/conda-forge/opentelemetry-sdk-feedstock/pull/33
https://github.com/conda-forge/opentelemetry-api-feedstock/pull/47
https://github.com/conda-forge/opentelemetry-instrumentation-feedstock/pull/34
https://github.com/conda-forge/opentelemetry-exporter-otlp-proto-grpc-feedstock/pull/16
https://github.com/conda-forge/opentelemetry-exporter-otlp-proto-http-feedstock/pull/13
https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/16
https://github.com/conda-forge/opentelemetry-exporter-otlp-proto-common-feedstock/pull/4
https://github.com/conda-forge/opentelemetry-semantic-conventions-feedstock/pull/30
https://github.com/conda-forge/opentelemetry-util-http-feedstock/pull/24
https://github.com/conda-forge/opentelemetry-proto-feedstock/pull/25

Rest Level 0 & 1 Deps

https://github.com/conda-forge/opentelemetry-instrumentation-grpc-feedstock/pull/18
https://github.com/conda-forge/opentelemetry-instrumentation-wsgi-feedstock/pull/20
https://github.com/conda-forge/opentelemetry-instrumentation-dbapi-feedstock/pull/22
https://github.com/conda-forge/opentelemetry-instrumentation-asgi-feedstock/pull/20
https://github.com/conda-forge/opentelemetry-exporter-jaeger-proto-grpc-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-exporter-jaeger-thrift-feedstock/pull/22
https://github.com/conda-forge/opentelemetry-exporter-zipkin-json-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-exporter-zipkin-proto-http-feedstock/pull/19

Rest of the ecosystem

https://github.com/conda-forge/opentelemetry-distro-feedstock/pull/6
https://github.com/conda-forge/opentelemetry-exporter-jaeger-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-exporter-opencensus-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-exporter-zipkin-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-aiohttp-client-feedstock/pull/25
https://github.com/conda-forge/opentelemetry-instrumentation-aiopg-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-asyncpg-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-boto-feedstock/pull/10
https://github.com/conda-forge/opentelemetry-instrumentation-botocore-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-celery-feedstock/pull/23
https://github.com/conda-forge/opentelemetry-instrumentation-django-feedstock/pull/20
https://github.com/conda-forge/opentelemetry-instrumentation-elasticsearch-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-falcon-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-fastapi-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-flask-feedstock/pull/20
https://github.com/conda-forge/opentelemetry-instrumentation-jinja2-feedstock/pull/23
https://github.com/conda-forge/opentelemetry-instrumentation-logging-feedstock/pull/23
https://github.com/conda-forge/opentelemetry-instrumentation-mysql-feedstock/pull/22
https://github.com/conda-forge/opentelemetry-instrumentation-psycopg2-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-pymemcache-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-pymongo-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-pymysql-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-pyramid-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-redis-feedstock/pull/20
https://github.com/conda-forge/opentelemetry-instrumentation-requests-feedstock/pull/20
https://github.com/conda-forge/opentelemetry-instrumentation-sklearn-feedstock/pull/23
https://github.com/conda-forge/opentelemetry-instrumentation-sqlalchemy-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-sqlite3-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-instrumentation-starlette-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-tornado-feedstock/pull/20
https://github.com/conda-forge/opentelemetry-instrumentation-urllib-feedstock/pull/19
https://github.com/conda-forge/opentelemetry-instrumentation-urllib3-feedstock/pull/21
https://github.com/conda-forge/opentelemetry-propagator-b3-feedstock/pull/23 - has another maintainer
https://github.com/conda-forge/opentelemetry-propagator-jaeger-feedstock/pull/16

Full list of all Opentel Packages

The thing I'm confused about is that you are making a request to be added as a maintainer, but you are listing specific problems that exist.
Can you summarize it in 1 sentence?
Finally, I would like to go a different way, you have listed the different "stages" you need to go through.
Please make PRs to the remaining level 0 feedstocks implementing the fixes:

Accomplishes the concrete fix you need.
Adds yourself to all the level 0 feedstock.

For the later stages, we can add the whole  to the maintainers of one of the level0 feedstocks to avoid this kind of future problem.
https://github.com/conda-forge/qt-feedstock/blob/main/recipe/meta.yaml#L91
You would:

Make the concrete fix you need.
Add a maintainer
Ping us for a single PR.

Otherwise, it is a little difficult for us to judge exactly how you will address the problems at hand.
Ultimately, I don't like to entertain the requests: "please just add me". I think it goes a long way to "fix something" then "add yourself as a commitment to continued maintenance".

Accomplishes the concrete fix you need.
"fix something" then "add yourself as a commitment to continued maintenance".

Hi @hmaarrfk
Thank you for taking the time to respond. I was operating on the assumption that my intent was apparent. My Apologies.

All 50+ feedstocks for open telemetry have only one maintainer mariusvniekerk; who is a key contributor to conda-forge, working on more important items with other core / admins. I've updated the title too that shows all the add maintainer PRs together.
Because of the levels of dependency - this suite ends up needing custom analysis and sequential re-execution every release - I have made PR's and rerun, waited for weeks for an admin to merge for the last 3 release this year.
I currently own and have helped maintain over 200+ feedstocks on conda-forge - so I'm happy to help where I can.

My thought process was - the simplest contribution I could made was figure out the dependency and take rerun's, the easy fixes of dependency version changes and keep this suite uptodate for everyone. My list of ten PRs to add me as co-maintainer - addresses the packages the rest depend  on - and I believe If I can keep those 10 uptodate, the rest are easier to tackle, and I have PRs open to add me as an alternate maintainer linked above
I would like to perhaps consolidate all Level 0's in this repo, or make this entire suite subpackages like airflow - there is another issue proposing that. That might take a bit more time, and I would probably need more direction and help before I attempt that.
For one concrete next steps
opentelemetry-exporter-otlp is at version 1.18.0 while the rest of the suite - while I have been able to bring bits and pieces of the rest of the suite to version 1.21.0
If you can merge this
https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/16
I have https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/14 ready to merge, and it clear one big hurdle for Conda Airflow feedstock users - where pip install brings in version 1.21.0 and conda install brings in version 1.18.0
Please let me know if you need any further clarification.
Thanks & Regards

Please take some time to read my message and make my life easier to help you.
Thank you for mentioning that you are active in conda-forge, but it is a rather big community, and we may not have overlapped. I checked your github profile and in fact you have forked a bunch
I was the member of core that responded to your request. So please take a moment to respond to mine.
I personally do not like to merge PRs that just add maintainers. How does that help your workflow? You will open a PR anyway with the rest of the changes later.
In my mind you can:

clone a bunch of repos
fix all of them
add yourself to all of them
use mamba build to build them locally
then really gain confidence they are all fixed
then me on the PRs that are green ,with your name on them.

Please get https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/14 to a working state, and add yourself as a maintainer there. Then when you are ready ping me.
I prefer to merge https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/14, not https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/16
Other core members may have a different flow, especially if they have worked with you before. but this is mine. please respect it.

Other core members may have a different flow, especially if they have worked with you before. but this is mine. please respect it.

@hmaarrfk absolutely - I have only been contributing for <2 years. Glad to take direction from you. Appreciate you taking the time.
I've already realizing my inefficiencies. I have made so many repetitive PRs every 3 months to Feedstocks - Because I was skipping step 3 in your instructions. So I've been pinging and waiting weeks each time - vs adding myself as a maintainer while fixing the feedstock.
I was not sure of the right etiquette and thought requesting to be added to a feedstock as a maintainer should always be a separate request.

https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/14 has been fixed for your review.
I've added myself as a maintainer but was not able to close https://github.com/conda-forge/opentelemetry-exporter-otlp-feedstock/pull/16 (which was created to add me as a maintainer - and is now duplicate. )

I think for me the right etiquette is to ask in the PR if you can be added. typically mentioning other feedstocks you work on is a good way to build credibility.
if somebody doesn't respond within 1-2 weeks, then you can go ahead and add yourself, and ping core.
that way, within 2 weeks you would have fixed the repo, and helped maintain it in a slightly longer run.
the main idea, is to

fix first
ask to be part of the longer term maintenance once you have fixed something meaningful.

meaningful varries, but a version bump definitely qualifies.

Ok i decided to help out a little bit and I merge the "needed for airflow" ones.
Please do consider adding conda-forge/opentelemetry-api or conda-forge/opentelemetry-sdk as a maintainer to the future feedstock PRs you make:
https://github.com/conda-forge/qt-feedstock/blob/main/recipe/meta.yaml#L91


Portable Version

Can you provide portable version of the app?

Thanks for your interest in this. great suggestions. I haven't touched this long time ago, but would be happy to revisit it as soon as I can :)

I agree with @omodia. A portable version of this app would be great. Thank you for coding this app.


Necessary to add a message to the user about unsuccessful  completion of the current task

Preconditions:
1 Log in as an existing user. Open:groups/speech exercises/sentences/a 2-words sentence
https://brainup.site/groups/2/series/4/subgroup/29
Step:
1 Select 1 exercise
2 Allow 11 wrong answers
Actuai result

Expected result: A message is displayed for the user: "You should complete the current task again"

not fixed


Harmony 2.x is incompatible with all Harmony 1.x mods

Revert :)

@kianzarrin Might be able to assist as he's been dealing with this same issue recently.

I am just waiting for @krazychu24 to release his pre-assembly load hook mod.
@Boformer is working on a self-patching harmony which is better than my approach. but he is busy right not.

I do have a dll that is compatible both with harmony 1 and harmony 2 right now if that helps

https://steamcommunity.com/sharedfiles/filedetails/?id=2040656402


Update for XCode Version 7.0 beta 5 (7A176x)

Workaround for llvm-crash

Thanks for the PR! Merged.


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.10.166

from: https://github.com/jenkins-x/jx

/retest


Allow multiple input files and/or directories

I've just created a git hook and I have to call the binary foreach file, I would prefer to call it with all files I want to check.
edit: I've seen that already does that, may I have a problem in my hook, but if I have multiples wrong yaml files, it only tells me what is wrong with one file
Good project, I was looking for a yaml linter I could install with composer

Thanks for the suggestion — that sounds like it could be a useful feature to add.
Currently I lint multiple files using find with xargs, however being able to execute within a git hook would be useful.
Could you give me an example of the hook script you're using?

That is the code
FYI gitamine f:c returns a list with the files that are being commited, those files are which later i am checking with your linter
`#!/usr/bin/env bash
FILES="$(gitamine f:c | grep -E "(.yaml$|.yml$)" | tr '\r\n' ' ')"
LINES="$(echo ${FILES} | wc -c)"
if [ "$LINES" -gt "1" ]
then
bin/yaml-lint ${FILES}
fi
`

Hi, I just came across probably the same issue. I have lint step on my CI defined as vendor/bin/yaml-lint *.yml. But only the first matched yaml file was linted, even though the pattern is expanded to multiple files. Also this produces no warning, so I mistakenly assumed all my yml files are being linted...

Hi @OndraM, thanks for your comment — I can see that this is a more serious issue than I first realised.
I need to carve out some time to upgrade the tool with multi-file support — it's not a difficult change, but now that the tool is seeing a fair bit of usage, and has to support multiple PHP and Symfony Yaml versions, I also want to set up adequate test coverage before undertaking non-trivial changes.
Because of this, I've created a separate issue (https://github.com/j13k/yaml-lint/issues/7) to track the need for a patch in the short term.
I can see that you've worked around the issue in your project — the style of file iteration you've used is how I've typically invoked the tool in my own CI setup.


Google Auth on login page

Hey there, It will more user friendly, if we add "Login with Google" button in login page. Can we add "Login with Google" button?
I would like to work on this feature. could you assign this feature to me under GSSOC'24 label ?
To implement this we gone make use of React OAuth2 NPM library which provides built in support for google Authentication.

Hi @SaurabhS55 You are assigned this task.

Hello! I'd be happy to help with this issue. Could you please assign it to me?

please assign me this issue , i have already done

@ashutoshgithubs Please Assigned this issue to me i have done it issue already


Can't set value on PhoneInput ??

<PhoneInput    onChange={(phone) => {     setPhoneNumber(phone)   }}   initialCountry="ma"  />
i can't set the value to what i want cause it doesn't exist

@sadiki-o Hey!
If you want to set the value you can use the initialPhone prop.
Seems like there is a typo in the "Basic usage" example.
Let me know if this helped. Thanks!

@sadiki-o You can now set the value property (after version 1.4.0 update). Thanks!


Overhaul UserModifyActivity

This should include:
Verify Password when updating User
Merging with ChangePasswordActivity
Do not send password back and forth all the time.

I did it in v0.4


[SPARK-27733][CORE] Upgrade Avro to version 1.10.1

Upstream SPARK-XXXXX ticket and PR link (if not applicable, explain)
https://github.com/apache/spark/commit/e9e81f798fc2c4a936b967b0e5fb13fd5dfdeb69
What changes were proposed in this pull request?
Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

https://github.com/palantir/spark/pull/757 better


Updated references from k8s.gcr.io to registry.k8s.io

Fixes: #738
Ref : kubernetes/k8s.io#4738

/kind cleanup

Hi @dchen1107 @vteratipally
Could you please have a look

/ok-to-test

/lgtm


Rio versions should have a way to package dashboard tags with it

When installing the rio binary, it should lock in a specific dashboard version. Currently, all versions of rio point to the CDN version of Dashboard. We need a way (part of the build process) to point to a specific tag.

We also need the ability to override the UI version such as for testing purposes (e.g. maybe I am ahead of release on master or something and I want xyz UI for testing purposes)


Return all index items when using basic implementation, eager loaded associations and pagy_search method / limit is ignored

We are using Rails 7 here and the pagy gem to paginate results.
The implementation is basic, similar to the one mentioned in the docs.
We were experiencing poor performances, investigation showed that our whole index is returned by meilisearch when no filter is passed, even with the limit set. Did we do something wrong?
Description
Rails 7 + meilisearch + pagy
Simple search using the pagy_search method. Some associations are eager loaded through :includes
Expected behavior
Returns only the number of items specified by the :limit options
Current behavior
Query with pagy_search returns the whole index
Screenshots or Logs
     # inside controller
     product_filters = ["type=AppProduct AND release_at_timestamp<=#{Date.current.strftime('%s')}"]

    options =
      { filter: product_filters, limit: 240 }.tap { |options|
        options[:sort] = ["release_at_timestamp:desc"] if params[:q].to_s.blank?
      }

    q = Product.includes(:category_secondary, :gender, :brand).pagy_search(params[:q], **options)

    puts "------------------- PAGY SEARCH RESULTS #{q.first.size} ---------------------"
    # => HERE THE FULL INDEX IS RETURNED (+6000 items)

    @pagy, @products = pagy_meilisearch(q, items: 24)
    ...

    # inside model
      include MeiliSearch::Rails
      extend Pagy::Meilisearch
      ActiveRecord_Relation.include Pagy::Meilisearch
      # scope :meilisearch_import, -> { eager_load(:category_secondary, :gender, :brand) } # we tried with and without scope

     meilisearch

Environment (please complete the following information):

OS: [e.g. Debian GNU/Linux] : render.com
Meilisearch server version: [e.g. v.0.20.0] : v1.3.2
meilisearch-rails version: [e.g v0.1.0] : 0.9.1
Rails version: [e.g. <IP_ADDRESS>] : <IP_ADDRESS>

Hi @Menelle how are you?!
I've tried to reproduce your issue but I was not able to, in the meilisearch-rails you can find a playground that uses Kaminari and another model with pagy already configured.
Can you try to reproduce it using them?
Also, the pagy is only affected by the items: 24 not by the limit: ... during the pagy_search source

Hello @brunoocasali, thank you for your message.
It seems that the issue occurs prior to the pagination (pagy_meilisearch call)
In our tests, the pagy_search call is actually returning the full index.
We observe a different response from meili when we eager load associations. I think that's what's causing our issue as with the includes, the limit seems ignored.
with includes:
# model
ActiveRecord_Relation.include Pagy::Meilisearch
# controller
q = Product.includes(:category_secondary, :gender, :brand).pagy_search(params[:q], **options)
puts "------------------- RESPONSE #{q.inspect} ---------------------"
=> [#<ActiveRecord::Relation [#<AppProduct id: 230, brand_id: 1, ...]>, nil, {:filter=>["type=AppProduct AND release_at_timestamp<=1693958400"], :limit=>240, :sort=>["release_at_timestamp:desc"]}]
puts "------------------- ITEMS RETURNED #{q.first.size} ---------------------"
=> Full index is returned

and without :
# controller
q = Product.pagy_search(params[:q], **options)
puts "------------------- RESPONSE #{q.inspect} ---------------------"
=> [Product(id: integer, brand_id: integer, ...), nil, {:filter=>["type=AppProduct AND release_at_timestamp<=1693958400"], :limit=>240, :sort=>["release_at_timestamp:desc"]}]

From what we see in the codebase, the pagy_search method should behave like ms_search, and accept the limit arg.
Just to be sure, we tried to call pagy_search with items: ... in place of limit: ..., and it raised MeiliSearch::ApiError (400 Bad Request - Unknown fielditems: expected one of q, offset, limit, page, hitsPerPage, attributesToRetrieve, attributesToCrop, cropLength, attributesToHighlight, showMatchesPosition, filter, sort, facets, highlightPreTag, highlightPostTag, cropMarker, matchingStrategy` as expected.
I hope your message was understood correctly. Let me know if we can provide more info. I will look at the playground you mentioned. Thank you.

Hi @Menelle thanks for your answer!
I'm still trying to understand what is happening but I suppose you controller should look like this:
def index
  product_filters = ["type=AppProduct AND release_at_timestamp<=#{Date.current.strftime('%s')}"]

  options = { filter: product_filters }.tap { |options|
    options[:sort] = ["release_at_timestamp:desc"] if params[:q].to_s.blank?
  }

  hits = Product.includes(:category_secondary, :gender, :brand).pagy_search(params[:q], **options)
  @pagy, @products = pagy_meilisearch(hits, items: 240)
end

With no limit at all... Pagy uses the exhaustive pagination from Meilisearch behind the scenes.
If it does not work by doing that, I would suggest removing the includes and then adding the relationships again, one by one.
I'm eager to hear your feedback.

Hello @brunoocasali
The limit and eager loading seems to work. The benchmark/tap we used to monitor memory and perf played the query prior to pagy, resulting in the full index being fetched... So that's on us.
However, that was not the cause of the performance issue, it just not helped the debugging.
We removed our Frankfurt index from meilisearch and recreated it in San-Francisco.
Our web servers are hosted in Oregon.
Doing that, we observed a X10 in perf, from 650ms to 70ms.

Amazing to know that! So I guess this issue can be closed right?! Let me know if this is a mistake! :)
Thanks for using Meilisearch!


React Handbook Deprecated Ref to TSLint

In the React handbook:
https://www.typescriptlang.org/docs/handbook/react.html
I've found a reference to TSLint which has been deprecated.
https://medium.com/palantir/tslint-in-2019-1a144c2317a9
The create-react-app in fact doesn't add TSLint refs.

This page is still in the v2 site, but should probably be a stub which redirects to the React docs, and to the react cheatsheets repo: https://github.com/typescript-cheatsheets/react-typescript-cheatsheet

Fixed in https://github.com/microsoft/TypeScript-Website/pull/774


Fixing emissary tests

Issue #, if available:
Description of changes:
Removing/changing tests to use images not from Dockerhub.

/lgtm


Issues/165

Example notebook for loading a merged tract+patch from an HDF5 file and checking the stellar color-color locus.

@yymao Agreed.  I hope that we can stop at four.  1) GCR 2) DB 3) Merged catalog 4) Butler-based


Update reCaptcha handling

Fixes #259

Thank you!

I guess this should be a minor version bump?

Please allow me to review it again as something just caught my eye.
Minor version bump.
One sec...

No problem, take your time

All good now :)

For quick testing:
const cloudscraper = require('.');
cloudscraper.debug = true;
cloudscraper.get({ uri: 'https://captcha.website', onCaptcha: () => {} })

// Logs response.captcha, siteKey matches, and whether a fallback was used.

In practice, all of the keys are the same but it's defensive anyway and prefers the best possible match.


How to finetuning model to recognize english abbreviations? eg: GDP，CPI etc

@luomingshuang Very thanks for your great work in wenetspeech recipe. The model have archived a good CER, but it is hard to recognize english abbreviations, eg: GDP，CPI etc. Is there any advice to improving it?

Thanks for your observation. Yes, in my public recognized results, the English abbreviations still can't be recognized correctly. It's a good question. How to improve the performance of recognizing English abbreviations in Chinese texts. I think there are some reasons leading this case.
For example, the English abbreviations is GDPR, and my recognized results is 极低P而. Some chinese chars which have the same tone as the English abbreviations mislead the model.
How to solve this problem is a good topic. Maybe we can leverage the language model or context to relieve it. And maybe others can have more suggestions for this problem.

I think one place which can be improved is to do some changes when generate the tokens.txt. In my current, I split the
proper English abbreviations into individual letters. (GDP-->G D P, generating three tokens: G, D, P.) So one way that we can do is to regard the GDP as a single token, not split it. Maybe I will have some experiments based on this way.

Very thanks for your reply. I look forward to your release of the new model as I don't have enough hardware to experiment.


Add Finch adapter

This adds an adapter for Finch (#381).
Caveats:

Since finch and its dependencies require Elixir 1.7 I removed those from the test matrix for now. I'm not sure if it's okay to drop support for v1.5 and v1.6 though.
For the "run tests against v1.0.0" CI job to succeed, the :docs option tests on the v1.0.0-compat branch must be updated.
Request body streaming is not supported.

Merged as https://github.com/teamon/tesla/pull/420


Handle buildCountryData args validation

What has been done

buildCountryData

Fixed country data filtering
Added validation of passed country value

Fixes the problem mentioned in #37

Exported CountryData type from root
docs: added e164 story, fixed typos on the docs website

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(wallet-adapter): integrate with SUIET wallet

This is the commit for wallet adapter from Suiet Wallet team. We hope to integrate with the official sui wallet-adapter kit and we've submitted the adapter codes. Please review the pull request, thanks!

@bruceeewong We're planning on updating our wallet adapters in the near future to be based on the new wallet standard. I'd recommending implementing this at the wallet-level if possible, as it'll automatically be supported in the upcoming standardized wallet adapter.

@Jordan-Mysten we would like to know will the wallet adapters released in 1 week?
the reason why we are asking because we are integrating with the ecosystem projects, if it takes longer we are hoping to get merged first. Then we will adjust for the wallet standard then.

@bruceeewong We're planning on updating our wallet adapters in the near future to be based on the new wallet standard. I'd recommending implementing this at the wallet-level if possible, as it'll automatically be supported in the upcoming standardized wallet adapter.

Thanks for the reply~ As my teammate Fred said, we have several dev partners who want to integrate with our wallet. We prefer to let them use the sui official wallet kit to dev & debug. So if the new standard couldn't release in short time, how about that your team merges the current pr? Of course we'd love to follow the new standard in the future. Feel free to comment back, thanks again!

@bruceeewong @fredliang44 I can let you know more concrete timelines next week. My main concern with merging this as-is is that this package would need to be deprecated and removed after the standardized adapter lands. I ideally want to minimize the amount of packages we need to deprecate, but I'm also sympathetic to your desire to enable developer partners. It also should be possible for y'all to separately publish a wallet adapter (e.g. a package like @suiet/wallet-adapter), which should unblock early dev partners.

@bruceeewong @fredliang44 I can let you know more concrete timelines next week. My main concern with merging this as-is is that this package would need to be deprecated and removed after the standardized adapter lands. I ideally want to minimize the amount of packages we need to deprecate, but I'm also sympathetic to your desire to enable developer partners. It also should be possible for y'all to separately publish a wallet adapter (e.g. a package like @suiet/wallet-adapter), which should unblock early dev partners.

Make sense, thanks anyway! We'll keep watching on it.

@Jordan-Mysten Hi Jordan, we have publish our own adapter and some project already using them, really appreciate your help. I wonder can we make a PR to add our adapter package repo in the README.md of the sui wallet adapter dir, so anyone who willing to integrate multiple wallets at once can find us there.
Because we are worrying that user who import the @mysten/wallet-adapter-all-wallets package would expect all wallets are included there, but actually we are published with an individual package.


Update s3 ListObject api

Signed-off-by: Masataka Mizukoshi<EMAIL_ADDRESS>Switch to v2 of S3 List Objects API in s3.go.
This is because AWS recommend that we use GET Bucket (List Objects) version 2 API.

This is kind of a weird change on its own. Do you have an upstream doc/reference to mentions the difference here.

Sorry for my late reply.
If we use List Objects API version 2, we can reduce few data to transfer/process.
That's  because  v2 API does not fetch object owner information by default.
see GET Bucket (List Objects) Version 2
In addition, aws recommend that we use GET Bucket (List Objects) version 2.
So I think we shoud switch  to v2.

#3218 seems like a duplicate of this PR, but it does provide test coverage. @m-masataka, would you mind if we closed this PR and track this change in #3218 ?

Closing in favour of #3218


CLI Usage ?

Is there any CLI support to remove gulp / node usage, and use only npm scripts ?

Not currently. It was made with gulp in mind and uses vinyl file containers but if you look at the test script it's not actually running through gulp there: https://github.com/ianmcgregor/imagepack/blob/master/test.js. Removing the node dependency would be a rewrite though.

I'll give a try, thank you anyway for this very useful lib.


User-defined transparency

In order to analyze a mesh, it is often helpful to quickly make the mesh object transparent. f3d already has support for transparency by passing the parameter --opacity=. It would be nice to have a keyboard shortcut for it
Possible solutions

CTRL+T: toggle alpha between 1.0 and e.g 0.3
Shift+scroll wheel: freely choose alpha value between 0 and 1 with your mouse scroll wheel

Sounds like a good idea to me.
I think it will probably be addressed in F3D 3.0 with the interactor rework or at least the interactive console. Right @mwestphal ?

definitely!

need: https://github.com/f3d-app/f3d/issues/443


[pt-br] Cleanup Portuguese localization reviewers sections

Changes

Remove empty reviewers sections and reviewers sections that contain reviewers who are not reviewers for the Portuguese localization.

/cc @jcjesus @edsoncelio @devlware
/kind cleanup

/hold for #41070

Changes

Remove empty reviewers sections and reviewers sections that contain reviewers who are not reviewers for the Portuguese localization.

/cc @jcjesus @edsoncelio @devlware /kind cleanup

Why not look on github to see who did the translation?
We can keep track of the translators' history.

Why not look on github to see who did the translation? We can keep track of the translators' history.

Blunderbuss also tries to determine reviewers based on past changes, do you consider that to be insufficient? Relevant docs: https://docs.prow.k8s.io/docs/components/plugins/approve/approvers/#blunderbuss-selection-mechanism

Hi @stormqueen1990 !
I understood now, so, I think we can go to remove, I will go ahead with my review and approve.
Thanks for the explanation.

@stormqueen1990 can you resolve this conflict and let me now after, please?

@stormqueen1990 can you resolve this conflict and let me now after, please?

@jcjesus sure, will do!

/unhold

/lgtm


How I could create layers dinamycally

Hello.
I need create layer for my map dynamically instead of static like all the examples.
How I could do this?
Thanks

Hi!
Layers in a CARTO for React application are essentially functions that return a deck.gl layer.
If you are using one of the CARTO for React templates and you use the Hygen code generator, the code for creating a CartoLayer is automatically created. This code takes some properties from the source through the useCartoLayerProps hook. If you attach the layer to a view, when the view is opened, the source and the layer gets added to the store (using the addSource-addLayer actions). This means the layer is instantiated and added to the map through the getLayers() function.
You can create your dynamic layers in the same way, by creating a new function that return a deck.gl layer. You can use any deck.gl layer, not only the CartoLayer. Our recommendation is to link the layer to a source, if possible, so if you have widgets using the same source, all the filters are integrated. You can decide to add the layer to the map every time a given view is added or not.
You can review all the steps needed in the Layers guide within the CARTO for React documentation.

Closing this issue.

@borja-munoz is there anywhere to find more information about how to use custom layers with a CARTO app?
The documentation shows how to use custom layers for one-off single-view apps, but doesn't really show complete examples of how to integrate custom layers with the broader ecosystem of CARTO react / redux state management.
What would really help is to show how a custom layer can live side-by-side with CartoLayers - including whether and how to add a custom source, how to properly add and remove the layer from the corresponding view, etc.
After looking through the docs there is still a number of questions:

it isn't clear how to create a source for a custom layer?
custom layers expect a data property - how to link the creation of this layer to a source for the custom layer?
if fetching the data with fetchLayerData - then how to link this to a source?
if using custom layers without a source, then adding and removing the layer from the corresponding view page doesn't seem to work as intended? Maybe because the source is null it skips some internal steps? In my case it seems to load the custom layer even on non-related view pages and doesn't seem to remove the layer.

@borja-munoz thank you this was helpful, particularly the link for data-sources and document mode.
The last question was a mistake on my part due to styling, if following the memoization strategy suggested in the docs then all seems to work (including adding to and removing from views).
What would help people like me who are new to the CARTO stack is to maybe have a documentation page containing some of the points you made above just to help people build a conceptual model of how to interface custom layers with with the CARTO API and workflows.

Thank you for the feedback, we'll definitely consider it for improving the documentation.


Change RedMap title bar

Hello,
I am using Redmap for a proof of concept, and by reading the documentation, I haven't found any way of getting rid of the title bar (or changing it).
Am I missing something on the documentation? Please let me know cause otherwises I'll try to make some changes on the project and send a pull request.
Thanks

You can embed it as an iframe in your own page and that will remove it etc...

OK to close or are you still working on a PR ?


Dependabot for Dockerfile

Me again 🙂
What about to add dockerfile to dependabot config, so every implementation will be tested with the latest compiler/interpreter?
Thanks.

Sure, this sounds good to me.


velero not picking up cloud-credentials update before backup is triggered

I tried to run a migration through the UI.
Velero failed with:
time="2019-07-08T15:31:34Z" level=error msg="backup failed" controller=backup error="rpc error: code = Unknown desc = NoCredentialProviders: no valid providers in chain. Deprecated.\n\tFor verbose messaging see aws.Config.CredentialsChainVerboseErrors" error.file="/go/src/github.com/heptio/velero/pkg/cloudprovider/aws/volume_snapshotter.go:58" error.function=github.com/heptio/velero/pkg/cloudprovider/aws.getSession key=mig/72188780-a195-11e9-95aa-f318654dbe30-68fk6 logSource="pkg/controller/backup_controller.go:230"
time="2019-07-08T15:31:35Z" level=error msg="Error getting backup store for location" backupLocation=jmontleo-velero-dcwdz controller=backup-sync error="rpc error: code = Unknown desc = NoCredentialProviders: no valid providers in chain. Deprecated.\n\tFor verbose messaging see aws.Config.CredentialsChainVerboseErrors" error.file="/go/src/github.com/heptio/velero/pkg/cloudprovider/aws/volume_snapshotter.go:58" error.function=github.com/heptio/velero/pkg/cloudprovider/aws.getSession logSource="pkg/controller/backup_sync_controller.go:162"

I restarted the velero pod and created a new basically identical migration plan and it succeeded.
I believe when the cloud-credentials secret is being updated velero isn't picking up the change, at least not immediately, causing the backup to fail.

Related to: #84

I think this is a dup of issue #84 so will close this to consolidate as issue #84 has accumulated some other references


cuda cask is gone?

Description of issue
I want to install CUDA on my macOS. Several guides (e.g. https://srikanthpagadala.github.io/notes/2016/11/07/enable-gpu-support-for-tensorflow-on-macos)
point to the cuda cask. However, it does not seem to exist anymore?
Output of install command
$ brew cask install cuda
Error: Cask 'cuda' is unavailable: No Cask with this name exists. Did you mean one of:
cuda-z
Error: Install incomplete.

Output of install command with --verbose --debug
$ brew cask install cuda --verbose --debug
Error: Cask 'cuda' is unavailable: No Cask with this name exists. Did you mean one of:
cuda-z
Error: Install incomplete.
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:13:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/abstract_command.rb:35:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:97:in `run_command'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:167:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:131:in `run'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'
Error: Kernel.exit
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:172:in `exit'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:172:in `rescue in run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:155:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:131:in `run'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

Output of brew cask doctor
$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.3.2-13-g5b04152
caskroom/homebrew-cask (git revision aabdd; last commit 2017-09-06)
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
/usr/local/Caskroom
==> Homebrew-Cask Cached Downloads
~/Library/Caches/Homebrew/Cask (1 files, 226.6MB)
==> Homebrew-Cask Taps:
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask (3721 casks)
==> Contents of $LOAD_PATH
/usr/local/Homebrew/Library/Homebrew/cask/lib
/usr/local/Homebrew/Library/Homebrew
/Library/Ruby/Site/2.0.0
/Library/Ruby/Site/2.0.0/x86_64-darwin16
/Library/Ruby/Site/2.0.0/universal-darwin16
/Library/Ruby/Site
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/x86_64-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby/2.0.0/universal-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/vendor_ruby
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/x86_64-darwin16
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/universal-darwin16
==> Environment Variables
LC_CTYPE="UTF-8"
PATH="/usr/local/opt/python/libexec/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/Homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"

It’s in caskroom/drivers. You need to tap that repo.

try
brew tap caskroom/drivers

It is now called nvidia-cuda, so
cask install nvidia-cuda


FancyZones. Switch virtual desktop maximaze windows

Microsoft PowerToys version
0.64.1
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
Have 2 monitor and 2 virtual desktop on one of them. Use FancyZones with 3 zone.
Run app Yandex.Music. It open in actual size, not in maximaze size in one zone.
Switch virtual desktop (win+ctrl+right) and back (win+ctrl+left).
Reproduce on 0.64.1, 0.64.0, 0,62.1, 0.62.0, 0.61.0, 0.60.0
Not reproduce if uncheck option "Move newly created windows to their last known zone"
✔ Expected Behavior
Yandex.Music not resize.
❌ Actual Behavior
Yandex.Music resize itself maximaze in one first zone.
Other Software
No response

PowerToysReport_2022-11-09-09-49-11.zip

Potential dupe of #21772 ?

Potential dupe of #21772 ?

Yes, looks like

reproduced
v.0.73.0

/dup https://github.com/microsoft/PowerToys/issues/21982


[source-build-release] Incorrect instructions in "Approval - PR merged" dialog

Stage: Approval - PR merged & ready for dotnet-security-partners mirroring
When trying to approve this stage, a dialog is shown with instructions, at the bottom of the dialog, that do not match current release process. Smoke-test-prereqs get automatically packaged and uploaded during next, mirroring, stage, so it cannot be verified at this stage.
Here's the message:

Besides updating this message, it would be helpful to add a blurb about smoke-test-prereqs in the checklist's step 3.c Mirror sources and packages

Hey @NikolaMilosavljevic, if my understanding of the issue is correct, we would want the instructions for the approval to say something like:
Verify that new sources were merged into `security-partners-dotnet`

Or do you see value in something else / something more being there? Thanks!

Or maybe @mthalman would have more context into this issue. Thanks in advance!

Hey @NikolaMilosavljevic Nikola Milosavljevic (CLR) FTE, if my understanding of the issue is correct, we would want the instructions for the approval to say something like:
Verify that new sources were merged into `security-partners-dotnet`

Or do you see value in something else / something more being there? Thanks!

Yeah, I think that message should be sufficient.

The message has been updated, closing as Done
New message:


Fixes issue 511 where refresh token is stored without enhancements

Enhanced refresh tokens are not persisted to token store correctly during the refreshAccessToken routine in DefaultTokenServices.
The issue is not noticeable when utilizing a JwtTokenStore since it does not perform persistence. However it is evident using any other token store, e.g. the InMemoryTokenStore.
Fix was trivial. A test was created as well.
This solves issue #511

Hi Marco, I see pull request is still open. What release is this targeted for  ?

I am not part of the core team. They have to decide whether to accept the pull request or not. I assume @dsyer .

Thanks again for the PR @marcolenzo and for your patience. This is now merged to master.


Move reconcile and relevant unit tests to NomadFacet

Description
Contracts are over size limit:

BridgeFacet
StableSwapFacet

In order to bring us back under the size limit for the former of the above two, I moved all of the reconcile functionality to NomadFacet.
Type of change

[ ] Docs change / dependency upgrade
[ ] Configuration / tooling changes
[x] Refactoring
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Requires changes in customer code

High-level change(s) description - from the user's perspective
This is purely a refactor - nothing should change on an interface level here.
Related Issue(s)
Fixes
Related pull request(s)

New contract sizings


Density should cleanup better

In cases where one wants to run multiple iterations of density back to back, we really need to make sure a pervious iteration's load doesn't leak into this one. 2 main culprits are:

Deleting the namespace will return in a moment, when really it takes like ~15m to delete all events (~20,000 events for 3000 pods). These deletes actually have a bad effect on the next run.
We should make sure the pods are actually gone on the kubelet before staring a new run by using the proxy to poll /pods or something. Otherwise we're effectively putting > 30 pods on a node and the kubelet is known to be slow during pod deletes.

This is obviously not a problem if we tear down the entire cluser between iterations.
@gmarek

IMO it's not a problem. In Jenkins we do turn down clusters between runs, and when running manually it's all in hands of the person running.
In my case, when running tests I was always waiting for proper namespace deletion. Delete indeed returns straight away, but get namespace still returns namespace in question as "terminating". It's slightly faster than turning down the cluster.
In addition if you want to save the time you don't want to delete pods used to saturate the cluster (those first 30/node), as bringing them up again takes 7-8 minutes. Instead you just play with the test commenting out pieces you don't want to use, rebuild the test, which takes seconds and run it again.
Deleting additional 100 pods together with associated events is pretty quick.

I believe we can close this issue.

Instead you just play with the test commenting out pieces you don't want to use, rebuild the test, which takes seconds and run it again.
Deleting additional 100 pods together with associated events is pretty quick.

Sure, there's doing something like that, and theres leaving a clean environment for the next test by default so your tests can run in any order. We have iterations there as a feature, and I think we still run density as part of e2e, so anything that runs after it feels the after effects. It's just too easy to shoot yourself in the foot if you don't do proper cleanup in a test, assuming it's always giong to run alone in a fresh cluster doesn't sound like a good idea even if it happens to work today.

IIUC this (i.e. test isolation) is deeper issue, not only for the Density, but also Load test, and any other e2e that creates non-trivial number of resources.

We no longer run those tests as part of regular gce e2e test - see #9858

See https://github.com/GoogleCloudPlatform/kubernetes/issues/3954#issuecomment-113509698

The events deletion at least is handled by https://github.com/GoogleCloudPlatform/kubernetes/pull/10175.

Yup. I believe we can close this bug.

Hmm, there's still the problem of cleaning up containers on the kubelet (delete just removes keys from etcd currently)

/cc @rrati

@bprashanth details?

kubectl delete pods doesn't wait till the kubelet has deleted containers on the node

Ohh yeah, that's been that way forever it's non-blocking.

@quinton-hoole @wojtek-t is this still a thing?

Currently it's hacked - to provide a clear and fast solution we need to be able to quickly remove the whole namespace and to do it we need to be able to remove a collection of objects in a single step.
But I think we can close it now as a duplicate of https://github.com/kubernetes/kubernetes/issues/10380


Expiry Feature

Can we add an option that whenever jwt.verify is called, if the token is verified, reset the expiry timer,
example:
var token = jwt.sign(user, process.env.SECRET_KEY, {
expiresIn: 10
});
token expires in 10 seconds,
If after 5 seconds i call an api and it verifies the token, reset the expiration counter, so it count for 10 seconds after the verification process and not continue the remaining 5 seconds.
Thanks in advance,
Regards

Humm ... there is a very clear reason for a token to have an expiration time ... validation!
I believe that this "feature" you want is more related to issue #122 which is described in the documentation
A practical example (and the reason why it is not part of this lib) is described in this gist


[Transaction] Txn ack abort process

Fixes https://github.com/streamnative/pulsar/issues/1314
Motivation
Currently, the transaction ack abort process is not well.
Modifications
Make some changes for the transaction ack abort process.
Verifying this change
This change added tests and can be verified as follows:
-org.apache.pulsar.broker.transaction.TransactionProduceTest#ackAbortTest
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

/pulsarbot run-failure-checks

@codelipenghui @zymap @congbobo184 to help review this PR.


Align id max-length between gallery database and validation

As pointed out in this discussion, it appears that client and server validation logic allow a max-version-length of 100 characters.
The gallery database however allows for a max-length of 64 characters, which is inconsistent. The introduction of semver2 support may pose new requirements in terms of max-version-length (as the metadata part is likely going to result in longer original version strings).
Note: there's been similar efforts in the past (https://github.com/NuGet/NuGetGallery/pull/3305)
cc @scottbommarito @joelverhagen @skofman1

Duplicate of https://github.com/NuGet/NuGetGallery/issues/3561

Incorrectly marked as duplicate: this issue is about package id length, not package version length.


Server error when using force_ssl true and running server with rackup

$ lotus new force_ssl_test

# config/routes.rb
get '/', to: ->(env) { [200, {}, ['OK']] }

# apps/web/application.rb
force_ssl true

$ bundle exec rackup
[2015-11-04 17:54:21] INFO  WEBrick 1.3.1
[2015-11-04 17:54:21] INFO  ruby 2.2.3 (2015-08-18) [x86_64-darwin15]
[2015-11-04 17:54:21] INFO  WEBrick::HTTPServer#start: pid=70829 port=9292
::1 - - [04/Nov/2015:17:54:31 +0300] "GET / HTTP/1.1" 301 - 0.0048
[2015-11-04 17:54:31] ERROR NoMethodError: undefined method `each' for "":String
	/Users/vlazar/.rvm/gems/ruby-2.2.3@force_ssl_test/gems/rack-1.6.4/lib/rack/body_proxy.rb:31:in `each'
	/Users/vlazar/.rvm/gems/ruby-2.2.3@force_ssl_test/gems/rack-1.6.4/lib/rack/lint.rb:708:in `each'
	/Users/vlazar/.rvm/gems/ruby-2.2.3@force_ssl_test/gems/rack-1.6.4/lib/rack/body_proxy.rb:31:in `each'
	/Users/vlazar/.rvm/gems/ruby-2.2.3@force_ssl_test/gems/rack-1.6.4/lib/rack/chunked.rb:23:in `each'
	/Users/vlazar/.rvm/gems/ruby-2.2.3@force_ssl_test/gems/rack-1.6.4/lib/rack/handler/webrick.rb:112:in `service'
	/Users/vlazar/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/webrick/httpserver.rb:138:in `service'
	/Users/vlazar/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/webrick/httpserver.rb:94:in `run'
	/Users/vlazar/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/webrick/server.rb:294:in `block in start_thread'

$ http http://localhost:9292/
HTTP/1.1 500 Internal Server Error
Connection: close
Content-Type: text/html; charset=ISO-8859-1
Date: Wed, 04 Nov 2015 14:04:16 GMT
Location: https://localhost:2300/
Server: WEBrick/1.3.1 (Ruby/2.2.3/2015-08-18)
Transfer-Encoding: chunked

http: error: ChunkedEncodingError: ('Connection broken: IncompleteRead(0 bytes read)', IncompleteRead(0 bytes read))

For the reference.
I've traced this error by getting H17 - Poorly formatted HTTP response errors on Heroku in Lotus application started with bundle exec puma -C ./config/puma.rb


Media Conch Allow comparison between properties

Hi Jerome,
An interesting use came up this week that we didn't have a good way to solve in media conch. The issue was out of order tracks. In some cases, tracks can get out of order and we wanted to add a check that the audio was after video in the ordering.  Because we aren't able to compare different tracks' values, we ended up making sure that the video was the first stream, but we are worried this may be too restrictive across all the formats.
Thoughts on a capability to be able to compare two values across tracks?
General
Complete name                            : /Users/jsciame/Downloads/SAOC3793H_ordered.mov
Format                                   : MPEG-4
Format profile                           : QuickTime
Codec ID                                 : qt   0000.02 (qt  )
File size                                : 555 MiB
Duration                                 : 22 s 23 ms
Overall bit rate mode                    : Variable
Overall bit rate                         : 211 Mb/s
Frame rate                               : 29.970 FPS
Writing application                      : Lavf60.3.100

Video
ID                                       : 2
Format                                   : ProRes
Format version                           : Version 0
Format profile                           : 422 HQ
Codec ID                                 : apch
Duration                                 : 22 s 22 ms
Bit rate mode                            : Variable
Bit rate                                 : 202 Mb/s
Width                                    : 1 920 pixels
Height                                   : 1 080 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 29.970 (30000/1001) FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:2
Scan type                                : Interlaced
Scan type, store method                  : Interleaved fields
Scan order                               : Top Field First
Bits/(Pixel*Frame)                       : 3.254
Stream size                              : 531 MiB (96%)
Writing library                          : apt0
Default                                  : Yes
Alternate group                          : 1
Color primaries                          : BT.709
Transfer characteristics                 : BT.709
Matrix coefficients                      : BT.709

Audio #1
ID                                       : 1
Format                                   : PCM
Format settings                          : Little / Signed
Codec ID                                 : in24
Duration                                 : 22 s 23 ms
Bit rate mode                            : Constant
Bit rate                                 : 6 912 kb/s
Channel(s)                               : 6 channels
Channel layout                           : L R C LFE Lb Rb
Sampling rate                            : 48.0 kHz
Bit depth                                : 24 bits
Stream size                              : 18.1 MiB (3%)

Audio #2
ID                                       : 3
Format                                   : PCM
Format settings                          : Little / Signed
Codec ID                                 : in24
Duration                                 : 22 s 23 ms
Bit rate mode                            : Constant
Bit rate                                 : 2 304 kb/s
Channel(s)                               : 2 channels
Channel layout                           : L R
Sampling rate                            : 48.0 kHz
Bit depth                                : 24 bits
Stream size                              : 6.05 MiB (1%)
Default                                  : Yes
Alternate group                          : 2

Other
ID                                       : 4
Type                                     : Time code
Format                                   : QuickTime TC
Duration                                 : 22 s 22 ms
Frame rate                               : 29.970 (30000/1001) FPS
Time code of first frame                 : 00:00:00;00
Time code of last frame                  : 00:00:21;29
Time code, stripped                      : Yes
Language                                 : English
Default                                  : No

Because we aren't able to compare different tracks' values, we ended up making sure that the video was the first stream, but we are worried this may be too restrictive across all the formats.

With first video StreamOrder == 0, right?
If you want to catch e.g. also content with time code first, you may add "or (first video StreamOrder == 1 && first audio StreamOrder == 2)".

Thoughts on a capability to be able to compare two values across tracks?

If I understand correctly, the idea is to be able to have a rule e.g. "first video StreamOrder < first audio StreamOrder", right?
Not yet implemented but something we could add.

Yes, the idea is a multi stream comparison where "first video StreamOrder < first audio StreamOrder".

@joe-sciame-wm you may test this snapshot (for CLI) or this snapshot (JS).
GUI is not yet ready, you have to write the policy by hand but the way to write it is not difficult.
With e.g.
p2a.xml (the policy corresponding to your example):
<policy type="and" name="Video before audio">
  <description>Check if video is before audio</description>
    <rule name="StreamOrder" value="StreamOrder" tracktype="Video" occurrence="1" operator="<">
      <source value="StreamOrder" tracktype="Audio"  occurrence="1"/>
    </rule>
</policy>

p2b.xml (the opposite)
<policy type="and" name="Video before audio">
  <description>Check if video is before audio</description>
    <rule name="StreamOrder" value="StreamOrder" tracktype="Video" occurrence="1" operator=">">
      <source value="StreamOrder" tracktype="Audio"  occurrence="1"/>
    </rule>
</policy>

Result is:
> mediaconch example.mkv -p p2a.xml
pass! .\example.mkv
> mediaconch example.mkv -p p2b.xml
fail! .\example.mkv
   --  [fail:Video before audio]
   --   [fail:StreamOrder]


Robotium execution against ice cream sandwich

From<EMAIL_ADDRESS>on February 08, 2012 16:21:46
What steps will reproduce the problem? 1. Have a Ice cream sandwich emulator running
2. Execute any robotium test What is the expected output? What do you see instead? Expected is test should run fine. However we are getting random Null pointer exceptions. What version of the product are you using? On what operating system? 2.3 Please provide any additional information below. Do we support Robotium with ice cream sandwich yet? Do we need to upgrade jar or any other suggestion here?
Has any one tried executing automation with robotium against ice-cream sandwich. Please let me know.
Thanks
Shama
Original issue: http://code.google.com/p/robotium/issues/detail?id=226

From<EMAIL_ADDRESS>on February 08, 2012 20:47:13
You need to use the latest version of Robotium, 3.1.
Status: Invalid

From<EMAIL_ADDRESS>on February 08, 2012 21:31:31
Sounds good! Thanks for the update. Are there any known issues with 3.1 for Robotium to work with ICS Android 4.0?

From<EMAIL_ADDRESS>on February 08, 2012 22:24:48
There is an issue with getCurrentActivity() that is due to a bug in the platform that is fixed in 4.0.3. Other then that it should work fine.


Image byte size is different after loading inside tui editor by comparing with c# byte size

Case : Masking is mandatory in the tui tool before saving image in the media server . As we are keeping all the images in the cloud server s3 bucket
Action :  To do mandatory masking i have compared byte size of image before masking and after masking.
Result : If there is no masking done and we calculate image size by following way 👍
download: function download() {
//debugger;
				var dataURL = _this.toDataURL("image/jpg").replace("image/jpg", "image/png");
                var imageName = _this.getImageName();
                var blob = void 0,
                    type = void 0,
                    w = void 0;

                if (_util2.default.isSupportFileApi() && window.saveAs) {
					blob = _util2.default.base64ToBlob(dataURL);
					//blob = dataURItoBlob(dataURL);

                    type = blob.type.split('/')[1];
                    if (imageName.split('.').pop() !== type) {
                        imageName += '.' + type;
                    }
                    if (typeof uploadToFtp !== 'undefined' && $.isFunction(uploadToFtp)) {
						return uploadToFtp(dataURL, imageName, _this.ui.options.ftpUrl, blob.size, _this.ui.options.newByteLengthControl, _this.ui.options.oldByteLengthControl);
						//return uploadToFtp(dataURL, imageName, _this.ui.options.ftpUrl, blob.size, blob.size, _this.ui.options.oldByteLengthControl);
                    } else {
                        saveAs(blob, imageName); // eslint-disable-line
                    }
                } else {
                    w = window.open();
                    w.document.body.innerHTML = '<img src=\'' + dataURL + '\'>';
                }
                event.preventDefault();
            }
        }, this._commonAction());
    },

getting this image size in the javascript by following method
function uploadToFtp(dataURL, imageName, ftpUrl, blobSize, newByteLengthControl, oldByteLengthControl) {
   /// **Here blob size which is image size of the tui editor image loaded  is greater without masking**

        }

The same issue found when  i compared with c# in which image byte size different than loaded and exposed in the blob (mentioned code above) image  from the tui editor image

@rajeshparbatgit
Thank you for the information. I'll check.


Uncaught Error: This socket is closed

[Enter steps to reproduce below:]

...
...

 Please open a new issue if the problem arises again.


Add [xunit*]* to default excluded modules filter

@vagisha-nidhi's comment
Also, I have been trying out things with xunit/nunit and I found this https://github.com/tonerdo/coverlet/issues/361#issuecomment-470044541. This would be a bad experience for any first user, if a test run crashes with --collect:"Xplat code coverage".
Should we add [xunit*]* to default exclude filter here https://github.com/tonerdo/coverlet/blob/master/src/coverlet.collector/Utilities/CoverletConstants.cs#L21?
cc: @cltshivash @tonerdo @onovotny

I agree with I think the more 80% likely defaults and "right thing" should be defaulted, fwiw, so I'd say yes.
Btw are we sure that the right solution is to hard-code in a "immutable" list of filters? https://github.com/tonerdo/coverlet/blob/87f4dda3de7d215c23185c91288254c1c8468c42/src/coverlet.collector/DataCollection/CoverletSettingsParser.cs#L122
If for some reason someone need to instrument a lib included in that filters?
Is it too much coarse filter?
I mean if we hard code that value we don't have a "plan b" available and we'll anwer what to users?
Maybe we should try to recognize "tests frameworks(xunit)/tests sdk(*.test.dll)" and filter out selectively using public key or a list of full name, something like trusted list.
Thoughts?

Is it an immutable list or a default? If I specify exclude filters in config, does it replace or augment what's in code?

If we add to constants we can only augment filter.
Maybe we could add default filters if no excluded specified, in this way we "only" handle gracefully simplest use.

Maybe we could add default filters if no excluded specified, in this way we "only" handle gracefully simplest use.

I think that's fair -- The constants/defaults can be documented, but if people want to specify their own, they shouldn't expect a union of config and code, I'd think

@vagisha-nidhi @tonerdo thoughts?If we reach an agreement I could create a PR, we should add to core lib to have same behaviour with tool/msbuild.

@vagisha-nidhi @tonerdo thoughts?If we reach an agreement I could create a PR, we should add to core lib to have same behaviour with tool/msbuild.
@MarcoRossignoli
I agree with specifying the defaults when no exclude has been explicitly given. If user wants to specify their own list, they can very well refer to documentation to see if they want to union the defaults.
But [coverlet.*]* should always be defaulted otherwise dotnet vstest won't work?

But [coverlet.] should always be defaulted otherwise dotnet vstest won't work?

It's a question or a statement?

But [coverlet.] should always be defaulted otherwise dotnet vstest won't work?

It's a question or a statement?

Statement. We should not rely on user to add this since it is known that dotnet vstest won't work without the filter

Statement. We should not rely on user to add this since it is known that dotnet vstest won't work without the filter

Yup we keep our module in default exclusion filters.

Statement. We should not rely on user to add this since it is known that dotnet vstest won't work without the filter

Yup we keep our module in default exclusion filters.

Then we are okay with this change.

I would also suggest it exclude .test.dll/.tests.dll assemblies as you almost never want to instrument and report on the unit test assembly itself.

@onovotny at the moment we exclude by default test assembly, added back in https://github.com/tonerdo/coverlet/pull/376 after some discussions

@vagisha-nidhi you can test with nightly if you want https://www.myget.org/feed/coverlet-dev/package/nuget/coverlet.collector/1.0.33-g66a0119867

@MarcoRossignoli This works great!
@tonerdo Also if it is possible to get coverlet.collector 1.0.1 with the fix gone in, I should be able to add that to dotnet core csproj templates.

@tonerdo if can take a look at
https://github.com/tonerdo/coverlet/pull/458 <- affect a lot of users
https://github.com/tonerdo/coverlet/pull/464
We could release all packages with PATCH bumped by 1

@MarcoRossignoli will take a look at the PRs and work on getting them merged in today


Observable pipe() take(1) type mismatch

Argument type MonoTypeOperatorFunction is not assignable to parameter type OperatorFunction
  Type unknown is not assignable to type IDestination[]
    Type unknown is not assignable to type Array unknown idestination idestination

this.getDestinations().pipe(take(1)).subscribe()
with return type Observable<IDestination[]>

Please fill out the issue template.

I observe similar error:
const totalSubject  = new Subject<number>();
totalSubject.pipe(takeUntil(this.componentDestroyed));

this code produces tslint error:
Argument type MonoTypeOperatorFunction is not assignable to parameter type OperatorFunction<number, unknown>

Closing as stale. There is insufficient information in this issue for it to be an actionable bug report - the template has not been filled out and no additional information has been provided within the last four weeks.


test: run tests on webworkers

@dryajov

@diasdavid can we finally retire this module... we are not using it anymore internally

ping @dryajov

on it.

This requires https://github.com/diasdavid/webcrypto/pull/17

@dryajov merged and released

Woot! All green!
cc @diasdavid


Pixljs Support?

Can pixljs support be added? It looks like the firmware patch could support several eapruino boards with the same hardware but I think pixljs has the most potential with the lcd.

The script may already work for the pixl.js provided that the appropriate custom firmware is built for it, but I don't have a pixl that I could actually test with, so I can't verify.
Here's the custom firmware built for pixl.js if you want to try
espruino_2v15.1_pixljs.zip

Thanks. My pixljs hasn't arrived yet but I took some time today and built the firmware with your patch. I'm planning on starting with your script and build up from there. In a reddit post, you mentioned issues with  the newest firmware. We're you able to resolve those?

Since posting that, I've moved everything important into native code in the custom firmware, you have the NTAG215 javascript object that handles all the setup and NFC communication.

I was able to load up the custom firmware and test the script with only a few modifications and it's working as expected. I noticed you had custom firmware for the banglejs watches but since they are using different chips, I don't think they will support the add ntag lib you created. With that said, I think we can close this.
Is there any way to get the amiibo id or name from the tag? I see you have get tag info but I'm not sure how to get the values in text.

The bangle uses NRF52840 like the puck, does it not?
What modifications did you need to make to get it working?

getTagInfo returns the minimal information needed to identify an amiibo and to decrypt the nickname given.
The function slices data off the full tag, so to reconstruct it you would reconstruct as follows:

Bytes 0-7 -> 0-7 of the tag
Bytes 8-19 -> 16-27 of the tag
Bytes 20-39 -> 32-51 of the tag
Bytes 40-47 -> 84-91 of the tag
Bytes 48-79 -> 96-127 of the tag

You are right, the banglejs2 has the same chip as the puck and pixl. It is the original bangle that has a nRF52832. I Actually own a banglejs2 so I should try the custom firmware and see if it works.
The biggest changes so far I made to the script is identifying the pixl vs the puck from the BOARD and then using BTN1 instead of BTN. I could test it again but I don't think BTN was working. Beyond that, I'm hoping to print the current tag information to the LCD.
Trying to wrap my head around how to convert the bytes to get the head and tail values mentioned here:
To determine amiibo model type, use data from page #21 and #22. Page #21 (bytes[84..<88]) is the "head" and page #22 (bytes[88..<92]) is the "tail" - you can use these values at amiiboapi.com.

https://stackoverflow.com/questions/34309988/byte-array-to-hex-string-conversion-in-javascript

I was able to get the firmware working and have a good understanding of the amiibo format.

Reopened because I want to implement at least basic support for the pixl.js (and the other capable espruino hardware)

Instead of trying to keep one script for all the devices, I stripped out the puck specific functionality I didn't care about to reduce the bloat. Not sure if you want to re-use anything.
https://github.com/christopher-roelofs/ntag215-puck.js/blob/master/pixl.js
Also, based on the comments from the Espruino creator, both bangle and bangle2 don't have the same nfc functionality  so I think the only official boards applicable for this are puck, pixl and the MDBT42Q Breakout

That's unfortunate that the bangle devices don't have the NFC capability.
As far as a single script for multiple boards, I use terser to minify the code and that removes dead code paths as part of the minification and optimization.
So, if you set a constant to a value and then check that value, it will evaluate the if and remove that code branch entirely if the check fails.


What an awesome tool! :)

Thanks for putting this together!

Closing as "works-for-me". Thanks =).


softrelu activation clipping bug in MKLDNN

Description
With MKLDNN (enabled in mxnet-cuxxmkl builds), using softrelu activation, the output is clipped to maximum value of 88.37625885009766. This regression was introduced in 1.2.0 when MKLDNN was enabled for activations other than relu in #10336.
Looking at MKLDNN implementation of softrelu, I don't see any overflow prevention logic, so most likely the exp() function overflows and results in this bug.
Environment info (Required)
mxnet-cu90mkl >= 1.2.0b20180403
Minimum reproducible example
nd.Activation(nd.array([100]), act_type='softrelu')

output:
[ 88.37625885]
<NDArray 1 @cpu(0)>

@jinhuang415

@pengzhao-intel @zheng-da

@safrooze Thanks for reporting this. We confirmed this is a bug in mkldnn, and will fix this in future. considering input > 88 is a corner case in most of models, most users shouldn't face this problem when using soft_relu with mkldnn. If you're having trouble with this on a certain model, please let us know.

@ZhennanQin do we have an ETA when this would be fixed? should we fallback if input too large?

@azai91 , this defect will be addressed within the next sprint, with expected target date ww33.5.

@ZhennanQin Is this fixed in MKLDNN now?

@safrooze  Patch is ready for internal test. Will push to github repo in next promotion.

@safrooze Please verify at your earliest convenience if this issue has been fixed. Thanks!

@safrooze I have verified that using the master from intel/mkl-dnn module the problem has been fixed.
`>>> from mxnet import ndarray as nd

nd.Activation(nd.array([100]), act_type='softrelu')

[100.]
<NDArray 1 @cpu(0)>`
@sandeep-krishnamurthy @nswamy Please close this issue.

@apeforest Thanks! Closing this issue. Just for reference this fix will be included in MKLDNN 0.17 release.


Remove haproxy zombie processes left after a haproxy reload

@aledbf do you know someone familiar with this code to review?

LGTM
@aledbf can you please move the godep to a separate commit as specified in the last line of https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md#using-godep ?

Thanks

@bprashanth yes, sorry about that.


Create index add size info

Signed-off-by: tumao<EMAIL_ADDRESS>

Please update insight docs as well.


Faulty calculation in UncommunicativeName

I didn't check this cop closely, but just looking at the code, there are multiple errors in the calculation of the offending range.
I think the following examples will lead to the wrong selection range: any_offensive_name_with_underscore, *anyoffensivename, **anyoffensivename.
Code can probably simply rely on location.name (not sure, didn't check all dependents)

Hey @marcandre 👋  I'm interested in picking this up.
I just want to confirm the buggy behaviour first. I created a file that looks like the following.
# frozen_string_literal: true

def test(_x); end

Running rubocop on this file produces the following offense.
Inspecting 1 file
C

Offenses:

app.rb:5:10: C: Naming/MethodParameterName: Method parameter must be at least 3 characters long.
def test(_x); end
         ^

1 file inspected, 1 offense detected

The expected behaviour should be that the calculated location is over all of _x, right?
Inspecting 1 file
C

Offenses:

app.rb:5:10: C: Naming/MethodParameterName: Method parameter must be at least 3 characters long.
def test(_x); end
         ^^

1 file inspected, 1 offense detected

I see similar issues when using * and **.


Update Enable-SPProjectQueueStatsMonitoring.md

Filled in place holder text.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Enable-SPProjectQueueStatsMonitoring.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Pass env variables to Unity build environment

Context
I would like to build multiple flavors of mobile apps (Android & iOS) using GameCI. Therefore during the build I need to modify certain parameters (like the app name, bundle identifier, icon paths, ... ). I tried to pass this information via environment variables. However it seems that since the build is executed inside a Docker container, the environment variables are not present during build time.
Suggested solution
Unless there is another option to pass my own parameters into the build, it would be great to forward all available env variables to the docker build container.
Considered alternatives

customParameters (seem to have a different use case which is special build parameters?)

Additional details

Example workflow in GitHub Actions:
      - uses: game-ci/unity-builder@v2
        env:
          APP_NAME: ${{ matrix.appName }}
          APP_PACKAGE_NAME: ${{ matrix.packageName }}
          APP_ICON_PATH: ${{ matrix.appIconPath }}
        with:
          projectPath: ${{ matrix.projectPath }}
          targetPlatform: ${{ matrix.targetPlatform }}
          androidAppBundle: true
          androidKeystoreName: user.keystore
          androidKeystoreBase64: ${{ secrets.ANDROID_KEYSTORE_BASE64 }}
          androidKeystorePass: ${{ secrets.ANDROID_KEYSTORE_PASS }}
          androidKeyaliasName: ${{ secrets.ANDROID_KEYALIAS_NAME }}
          androidKeyaliasPass: ${{ secrets.ANDROID_KEYALIAS_PASS }}

And this is how I would like to react to this parameter during the Unit Build, using a Prebuild script:
public class PreBuild : IPreprocessBuildWithReport
{
    public int callbackOrder { get { return 0; } }

    public void OnPreprocessBuild(BuildReport report)
    {
        Debug.Log("Executing PreBuild script");

        // read parameter from environment variables. Use a fallback if empty
        var appID = this.getEnv("APP_PACKAGE_NAME", "default.package.name");

       // use the parameter to modify some player settings like the bundleID
       PlayerSettings.applicationIdentifier = appID;
   }
}

After reading this I think for safety reasons we could also come up with a special prefix (like X_GAMECI_ or X_UNITY_) to better control which parameters exactly are being passed into the docker container.

You can already do this using a combination of buildMethod and customParameters. For example, you could have customParameters: myCustomAppId my.app.id and then use PlayerSettings.applicationIdentifier = options["customAppId"]; in the buildMethod

@davidmfinol thanks a lot for your quick support! Yes that works for me. I was a bit confused since those parameters are added to the unity binary as command line args. I didn't expect that to work for custom params but it seems that Unity simply ignores any self invented additional parameters in this case.
In addition I also found an option without the need to modify the default build script, so here a quick summary for the records in case someone is interested:

As explained by @davidmfinol we can use our own buildMethod based on the code of the default buildMethod as explained here.
Since I wanted to re-use the default build script without the need to modify it if possible, the snippet below is what I came up with. It also reads the CUSTOM_PARAMETERS env variable directly inside another build script which is executed in addition to the default build script. I prefer using a separate script since that way I can benefit of any possible new features / improvements / bug fixes in the default build script.

public class PreBuild : IPreprocessBuildWithReport
{
    public int callbackOrder { get { return 0; } }

    private Dictionary<string,string> customParameters = new Dictionary<string, string>();

    public void OnPreprocessBuild(BuildReport report)
    {
        Debug.Log("Executing PreBuild script");
        parseCustomParameters();
        var appID = this.getCustomParam("appId", "de.dfinkbeiner.blockwise.beta");
        var appName = this.getCustomParam("appName", "blockwise (local)");
        var appIconPath = this.getCustomParam("appIconPath", "local"); // can be live, beta or local
    }

    private void parseCustomParameters(){
        var customParamsString = Environment.GetEnvironmentVariable("CUSTOM_PARAMETERS");
        Debug.Log("CUSTOM_PARAMETERS: " + customParamsString);
        if(customParamsString != null){
            var customParams = customParamsString.Split(' ');
            foreach(var customParam in customParams){
                var keyValuePair = customParam.Substring(1).Split('=');
                customParameters.Add(keyValuePair[0], keyValuePair[1]);
            }
        }
    }

    private string getCustomParam(string key, string defaultValue){
        var customValue = customParameters[key];
        if (customValue != null){
            Debug.Log("Load value from customParams: " + key + "=" + customValue);
            return customValue;
        }
        return defaultValue;
    }

Workflow File:
      - uses: game-ci/unity-builder@v2
        with:
          projectPath: ${{ matrix.projectPath }}
          targetPlatform: ${{ matrix.targetPlatform }}
          androidAppBundle: true
          androidKeystoreName: user.keystore
          androidKeystoreBase64: ${{ secrets.ANDROID_KEYSTORE_BASE64 }}
          androidKeystorePass: ${{ secrets.ANDROID_KEYSTORE_PASS }}
          androidKeyaliasName: ${{ secrets.ANDROID_KEYALIAS_NAME }}
          androidKeyaliasPass: ${{ secrets.ANDROID_KEYALIAS_PASS }}
          customParameters: -appId=${{ matrix.packageName }} -appName=${{ matrix.appName }} -appIconPath=${{ matrix.appIconPath }}


We should support Jenv to manage JDK versions

as title

It seems jenv not work, by add jenv local jdk[version] before compile command.