Need Tighter Back-End Data Validation

IMPORTANT: This issue should not be worked on before the new schema/data object model(s) to be merged into development.
Please provide a summary of the feature
Credit to @timmyichen for helping me understand this issue.
The back end needs tighter data validation/sanitization. Currently, Mongoose does well to whitelist the data to ensure that it fits the MongoDB object model:

      await Event.create({
        title: data.title,
        description: data.description,
        initialDate: data.initialDate,
        finalDate: data.finalDate,
        startTime: data.startTime,
        endTime: data.endTime,
        recurring: data.recurring.rate === "weekly",
        dates: data.dates,
        recurringPattern: data.recurring,
        location: data.location,
        discordName: req.user.displayName,
      });

server\models\Event.js could also use some bounds for data, e.g. mins and maxes for String fields to prevent DDOS attacks via very large strings (Docs for this: https://mongoosejs.com/docs/validation.html).
Most of the logic in the generateRecurringDatesArray() in client\src\utilities\calendar.js should be moved to the backend
The "5 events per user" check from issue #153 can also be transferred here.

Are there any potential issues you foresee with this feature

There will be quite a bit of code that will be refactored on both the frontend and backend for this issue. Communication will be key to preventing merge errors with other issue-branches.

Is this feature related to any current or past issues? Please provide the

Some overlap with Issue #153 Soft Security

Additional context
Which Branch should this fix be Pulled into?
PR into development
If you're interested in working on this feature, please comment so you can be assigned

I would love to work on this issue

@isaaclee12, what do you think are the reasonable max lengths for strings in the context of this app?

@isaaclee12, what do you think are the reasonable max lengths for strings in the context of this app?

Twitter max character limit is 280. Think around there would be a good starting point?

@isaaclee12 Could you elaborate on the benefits of moving logic from the generateRecurringDatesArray method to the backend?

Hey Roman, sorry for the late response. Moving whatever logic we can to the back-end is best practice because code in the back-end (which the user can't directly manipulate) is infinitely more secure than code in the front-end (which the user can manipulate).

@isaaclee12, what do you think are the reasonable max lengths for strings in the context of this app?
I liked Caleb's idea for a limit of 280 characters for the descriptions. Maybe make the limit for title and location something shorter, say 50 to 100 characters.


Add automatic changelog generation based on labels (loghub)

Let's combine this with automatic release generation. As a reference, I do this for a personal project here: https://github.com/TheKevJames/jarvis/blob/master/circle.yml#L47


[Gardening] Update alloc_stack documentation in SIL.rst

As of Swift 4.0, alloc_stack always uses stack which means it's now guaranteed that the allocated memory is really located on the stack since this change below.
https://github.com/apple/swift/commit/cd1037b799402f4d68322011ef1b196f94281cea

@swift-ci please smoke test

@swift-ci Please smoke test Linux

Added the current behavior. Let me know if that doesn't make sense!

That isn't what I meant. I meant what do we do today if we have a runtime sized stack allocated thing. IIRC we use a dynamic alloca or something like that. @aschwaighofer did I get that right?

Yes, if the type is runtime sized we use a dynamic alloca which will allocate memory on the stack.

@swift-ci please smoke test

⛵


Example?

Is there an example walk-through tutorial of how to package an application, like how MSI can be made with WiX? I don't see anything like that here.
In this documentation I do not see any example projects, example files, example folder structures, or really anything of a final product. Everything is spread across many many pages with no connecting thread. This documentation is not usable to me to make a very simple project and deploy it as an IT professional.
For example, I would like to:

Put a file on the disk
Put a link to that file on the Start Menu
Send the package to a user and have them install it

I do not see any quick, logical way of accomplishing my goals with the information currently provided, or way to see what a finished product looks like. Nor do I see a compelling argument to developers for moving to this format from existing solutions, which are trivial to use.
WiX has a great example of a tutorial here. It defines the problem, explains how they solve the problem, and then delivers a concise solution built with their framework.
https://www.firegiant.com/wix/tutorial/
Thank you, hope my feedback helps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 896bae75-1efb-9fae-bb47-60acb4d51b77
Version Independent ID: c77ef381-91fc-c97b-c138-e4a4f74728a8
Content: Manual app packaging - MSIX
Content Source: msix-src/package/manual-packaging-root.md
Product: msix
GitHub Login: @dianmsft
Microsoft Alias: diahar

HI @SwiftOnSecurity , thank you for the feedback.
In general, here are the steps to manually create an MSIX:

Create a package manifest and add Target-based unplated assets (optional)
Create an MSIX package or bundle with the MakeAppx.exe tool
Create a certificate for package signing
Sign an app package using SignTool

We did recently restructure our docs so that they are scenario base. If the material presented in the docs is insufficient we will take that as feedback and work to provide better examples.

Hi @SwiftOnSecurity,
We have now updates our documentation to better follow along with the workflow that one might go through when creating an MSIX. You can start at the Overview page here on how to create an MSIX with an existing installer. If you are interested in examples, we have a series of lab exercises that you can go through, showing off different features of MSIX. If you feel we are still missing information, please let us know as we are always working to improve our documentation.
Best,
Sharla


Bugfixes for functions and function pointers

Patch instructions:
The second argument of leaq has to be a register. Using movq instead of leaq to rax resulted in segmentation faults and I think it's a bug that has been overlooked from the assignments.
Explicate tail:
Because we can pass functions as arguments to other functions, these arguments will be seen as Name objects and not considered in our reveal function pass, therefore not transformed into FunRefs. This leads to Name objects being used in tailcalls when trying to return the application of a function similar to how it happend with our primitive functions. My idea is to check whether the var in the call is a FunRef or not. If it's not a FunRef the base case will be triggered and with that it works.

As someone has pointed out for me the second fix with isinstance is wrong, I have misunderstood something about FunRefs therefore this PR should be ignored as the leaq fix is also contained within one of the others.


UI Test:Initiate e2e UI tests

Test scripts/functions verified on APIM v4.1.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Bathiya Ladduwahetty seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Rancher 2.2: Login fails for users with escaped comma in CN when using Active Directory LDAP authentication

Bug Report
Exception in log when trying to login (some users may login, but Admin user cannot):
Steps to reproduce
Use an active directory that includes an escaped "," (comma) in the CN.
Result:
The following log output is produced (personal data replaced in quoted string)
2019/08/15 11:46:12 [ERROR] Error refreshing token principals, skipping: LDAP Re                                                                                sult Code 34 "Invalid DN Syntax": 0000208F: NameErr: DSID-03100225, problem 2006                                                                                (BAD_NAME), data 8350, best match of:
', Name (999999),OU=99,OU=Tool-Users,DC=domain-index,DC=com'
Other details that may be helpful:
CN in LDAP (ActiveDirectory) looks like "CN=LastName, Forname (999999)"
Environment information

Rancher 2.2 latest stable.
Single install (on RHEL 7.7 with SE Linux)

Related issue: https://github.com/rancher/rancher/issues/9827

@FFock yes the dn in that request is not being escaped causing that error. But your admin should still be able to login. If admin cannot login, can you share the exact error in logs when admin tries to login?

I cannot reproduce the bug in v2.3.1,
Steps:

run Rancher:v2.3.1 single install
enable the authentication with Active Directory
connect to the Active Directory management server via Microsoft Remote Desktop client
added new users with the following variances:
-- the first name contains \,
-- the last name contains \,
-- the display name contains \,
-- the user login name contains \,

As menitioned in my initial report, the problem does not directly occur after initial setup and it occurs only when the comma is escaped in the CN. The problem occurs several hours after adding a user to the allowed users. Then some cache-update fails in the background due to the LDAP CN field parsing error and then no further login is possible with that user.
In our LDAP server all user accounts have an properly escaped comma in their CN but not in any other field. The problem occurs after several hours to a few days after a user was authorized to login in Rancher. When the problem shows up, no login (even not for the admin) is possible anymore.
We are currently blocked to use Rancher 2.x. Rancher 1.6.x is working with the same LDAP server though.

@jiaqiluo Can you try this:

After setting up AD, add any of the test users containing comma to allowed users list
Login as the user with comma in dn.
Log back in as the admin and check that a "User" account is created on the Global->Users page for this user with comma in dn.
While on the Global->Users page click on the "Refresh Group Memberships" button
Then you should see error in the logs:

2019/11/04 19:12:30 [ERROR] Error refreshing token principals, skipping: LDAP Result Code 34 "Invalid DN Syntax": 0000208F: NameErr: DSID-03100225, problem 2006 (BAD_NAME), data 8350, best match of:
	', first,CN=xxxxx'

@FFock yes a call to get all user's current groups fails in the background due to incorrectly escaped dn. However the logins are still working. Do the users see any error in the UI or in the logs when the logins fail for them?

The bug fix for the escaped comma is validated in v2.3-head 22483d475
Results:

the error is not showing in the log
and the group is refreshed successfully

Tested with Rancher 2.3.2 again and the bug is still there:
2019/11/25 14:05:58 [INFO] Creating user for principal activedirectory_user://CN=Name, Forename (110099),OU=06,OU=Users,DC=domain,DC=com
2019/11/25 14:05:58 [INFO] Creating globalRoleBindings for u-ux3ix4axu5
2019/11/25 14:05:58 [INFO] Creating new GlobalRoleBinding for GlobalRoleBinding grb-v729l
2019/11/25 14:05:58 [INFO] [mgmt-auth-grb-controller] Creating clusterRoleBinding for globalRoleBinding grb-v729l for user u-ux3ix4axu5 with role cattle-globalrole-user
2019/11/25 14:05:58 [ERROR] Error refreshing token principals, skipping: LDAP Result Code 34 "Invalid DN Syntax": 0000208F: NameErr: DSID-0310022E, problem 2006 (BAD_NAME), data 8350, best match of:
', Forename (110099),OU=06,OU=Users,DC=domain,DC=com'

@FFock the fix is not in 2.3.2, it's in 2.3.3, can you please test with 2.3.3?

Verified fix by QA as of v2.3.3.


[EDA] Remove Naming Exclusions Functionality

Critical Changes
Changes
Updates to Naming Exclusions
We've removed the functionality associated with the Naming Exclusions field (hed__Naming_Exclusions__c). Now, when a Contact is marked deceased or a deceased value is changed, the Naming Exclusions field will not change. Instead, if you want to specify how name exclusion is managed, use the Exclude From Household Name, Exclude From Household Formal Greeting, and Exclude From Household Informal Greeting settings on Contact.
Issues Closed
Closes #1273
New Metadata
Deleted Metadata
Testing Notes

Passes QA - Merging
Will close WI


hi

Hi Can you help me from telegram? Please share with me user name.

Sure, Join our Telegram API Group (https://t.me/bitmart_api) that you can find me.


Problem with an if-else statement

I added another command to the bot that is intended to give a randomized quote through a random number generator in an if/else statement. the case I added was this:
case 'quote':
bot.sendMessage({
to: channelID,
message: quote
});
I defined the variable "quote" in the if/else statement:
var rng = Math.floor(Math.random()*2) //Generates a 0 or 1 randomly
if (rng === 0){
let quote = 'These violent delights have violent ends.';
return quote;
}else if (rng === 1){
let quote = 'To be or not to be, that is the question.';
return quote
};
When I save bot.js and use the node bot.js command, nothing happens. If I delete the if/else statement, the bot works as intended. Any ideas?

On moving the statement to the bottom of the code, node bot.js works, but when I use the quote command, the console returns a undefined error for the quote variable.

Finally fixed it by using a switch as opposed to the if-else statement.


FIX CMDER_ROOT for admin launch

When launching a cmd in admin mode, if %ConEmuDir%\..\.. contains any space, it breaks the init script.
Thanks to this patch, the path is correctly defined now.

Maybe you don't need this comment but. Applying this change works with externals tools like PhpStorm when I setup the console with cmder

@killua99 Could you explain how you added Cmder to PhpStorm to use as Terminal? When I use C:\cmder\Cmder.exe as the Shell path, the Terminal window opens and then closes but Cmder opens up in a separate window (but not in the correct directory).

Hi, I was on holidays I forgot to reply. I set on the terminal "Shell path"
cmd /k "C:\opt\cmder\vendor\init.bat"
Hope it work for you.

Hey @killua99 it worked however the prompt is pretty awkward, looks corrupt or something. Well, I'll just continue with a separate instance on my 2nd monitor then, thanks for the reply! :+1:

You must to be sure you had this patch in your init.bat file. If not it look broken

Oh I see, it's not yet in stable release. Great, then I'll try it again when it's merged into master. Thanks!

@killua99 I have the same issue , it looks awkward.


Improve the About page GSSOC'23

I would like to work on this issue under gssoc'23

Hi, @karthiknadar1204, you can work on this and please refer to the Contribution guidelines on the readme once.
All the best!

Sure thank you

@AKD-01 I first ran npm i because running npm start first was giving error,
After running npm i first,i ran npm start but it is showing this error
How do i proceed.
I faced a similar issue,slightly more complex while setting the extraCloud project as well
Please help

@AKD-01 any update?

Hey @karthiknadar1204 , the card is not aligned properly

correct this and raise another pr with some more changes. I am closing this for now.

@srivastavaritik @AKD-01 Will submit pr again, please elaborate what does some more changes mean, like apart from the card alignment, should I add or delete something


Adding iptable rules using firewalld_rich_rule

This is my previous code and I want to modify it using firewalld. We used firewalld because we are using centos 7.2.
%w(all_established all_icmp prefix postfix).each do |rule|
    iptables_rule "#{rule}" do
        action :enable
    end
end

How can I implement it again using firewalld?

Check out the rich_rule section of the README  and if you want to see how the rich_rule provider was implemented you can see the source here.


Profiling code for low level CUDA analysis  ?

Coming here after reading this twitter thread and the results look super cool !
Is it possible to share the profiling scripts for both of the plots referenced there ? I was interested in plugging it into NVIDIA's Nsight Systems and look at the low level CUDA kernels (similar to what was done here).
Thanks for sharing this work !
Edit: Found this helpful thread about benchmarking torch.compile which might be relevant.

Hi Mit,
Sure, I will push the code soon, likely on Friday/Saturday.
Thanks for sharing!

Apologies for reopening this but was wondering whether you have timing/benchmarking scripts that I can just throw onto my RTX A5500 to see what the numbers look like and do a apples to apples comparison with your plots. Thanks again for doing this !
Also was trying to get torch.compile to work with fullgraph=True and as you said on Twitter there seem to be some errors. Is it Ok if I file issues for them so that other folks can help out with debugging ?
Would be cool to compare jax.jit vs torch.compile for these type of implementations (Don't worry I don't want to start another Twitter war :D )

Also was trying to get torch.compile to work with fullgraph=True and as you said on Twitter there seem to be some errors. Is it Ok if I file issues for them so that other folks can help out with debugging ?
Would be cool to compare jax.jit vs torch.compile for these type of implementations (Don't worry I am not trying to start another Twitter war :D )

And FYI for SEGNN and EGNN there's also (these)[https://github.com/smsharma/eqnn-jax/blob/main/models/segnn.py] implementations that would be interesting to compare against.

I just added the script for CEGNN in JAX.
Concerning opening issues, please go ahead, I would love people to help. I was recently playing with CEGNNs and managed to indicate operations that make torch struggle with compilation:

normalization (due to the for loop in algebra.norms, parhaps)
broadcasting along subspaces in MVLinear

weight = self.weight.repeat_interleave(self.algebra.subspaces, dim=-1)

get_weight in Cayley table

I will update the codebase if I manage to resolve them :)


integration: crio: Add 2 more tests

With recent changes brought to the runtime and to hyperstart agent,
we can add two new tests from the CRI-O bats:

ctr logging [tty=true]
ctr execsync failure

Fixes #260

@sboeuf I presume we are waiting for some changes in the other repos to land before we will see these tests pass?
 Do we need a DNM or WIP label etc.?

@jcvenegas updated the hyperstart version and we need this to land into clear-containers.img. It's been a month that we have merged a patch for hyperstart but we never updated the hyperstart version in our image.

The image 16660 now includes hyperstart changes  thttps://download.clearlinux.org/releases/16660/clear/RELEASENOTES

@grahamwhaley @chavafg This one is now passing :)


Unable to do S3 read from noobaa

Environment info

NooBaa Version: master-20210519
Platform: OCP 4.6.16

Actual behavior

Unable to download file using s3 cp operation

Expected behavior

Download should work well

Steps to reproduce

Create account with UID 5000, GID 800.
Create a bucket, bucket-1
Upload an object "check_4"
List the object
Download the object with same user credentials -> This has failed

[root@hpo-node1 ~]# ls -lart check_4
-rwxr-x--- 1 root root 0 May 23 23:55 check_4

[root@hpo-node1 ~]# s3u1 cp check_4 s3://bucket-1/
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
upload: ./check_4 to s3://bucket-1/check_4

[root@hpo-node1 ~]# s3u1 ls s3://bucket-1/ |grep check_4
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
2021-05-24 03:39:48          0 check_4

From noobaa endpoint:
sh-4.4# ls -lart |grep check_4
-rw-r-----.   1 5000  800       0 May 24 10:39 check_4    >>> This file is uploaded correctly with UID, GID values
sh-4.4# pwd
/nsfs/parent/bucket-1

More information - Screenshots / Logs / Other output
[root@hpo-node1 ~]# s3u1 cp s3://bucket-1/check_4 check_5
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
download failed: s3://bucket-1/check_4 to ./check_5 Could not connect to the endpoint URL: "https://api.ocp-akshat-1.cp.fyre.ibm.com:8443/bucket-1/check_4"

May-24 10:39:48.636 [Endpoint/8]    [L0] core.sdk.object_sdk:: _load_bucket_namespace {
  name: SENSITIVE-f53e749d8f84e52b,
  active_triggers: [ [length]: 0 ],
  system_owner: SENSITIVE-9cf0fd89409efef8,
  bucket_owner: SENSITIVE-3d288e97f8a66631,
  bucket_info: { name: SENSITIVE-f53e749d8f84e52b, owner_account: { email: SENSITIVE-3d288e97f8a66631, id: '60a682b15691c200274328b2' }, namespace: { write_resource: { resource: 'nsfs-nsr-1', path: '/bucket-1' }, read_resources: [ { resource: 'nsfs-nsr-1', path: '/bucket-1' }, [length]: 1 ], should_create_underlying_storage: true }, tag: '', num_objects: { value: 0, last_update:<PHONE_NUMBER>425 }, writable: false, storage: { values: { used: 0, used_other: 0, total: 0, free: 0 }, last_update:<PHONE_NUMBER>570 }, data: { size: 0, size_reduced: 0, free: 0, available_for_upload: 0, last_update:<PHONE_NUMBER>570 }, usage_by_pool: { pools: [ [length]: 0 ], last_update:<PHONE_NUMBER>425 }, stats_by_type: [ [length]: 0 ], mode: 'OPTIMAL', bucket_type: 'NAMESPACE', versioning: 'DISABLED', triggers: [ [length]: 0 ] },
  namespace: {
    write_resource: { resource: { fs_root_path: '/nsfs/parent', fs_backend: 'GPFS', id: '60a678cb5691c20027432898', name: 'nsfs-nsr-1' }, path: '/bucket-1' },
    read_resources: [ { resource: { fs_root_path: '/nsfs/parent', fs_backend: 'GPFS', id: '60a678cb5691c20027432898', name: 'nsfs-nsr-1' }, path: '/bucket-1' }, [length]: 1 ],
    should_create_underlying_storage: true
  }
}
May-24 10:39:48.636 [Endpoint/8]    [L0] core.endpoint.s3.ops.s3_put_object:: PUT OBJECT bucket-1 check_4
May-24 10:40:18.645 [Endpoint/8]   [LOG] CONSOLE:: update_endpoint_stats. namespace_stats = []
May-24 10:43:44.115 [Endpoint/8]    [L0] core.endpoint.endpoint:: Sending endpoint report: { group_name: '7691dda8-3150-469f-b856-3051f531492b', hostname: 'noobaa-endpoint-846db467f9-tghjt' }
May-24 10:44:06.973 [Endpoint/8]    [L0] core.sdk.object_sdk:: _load_bucket_namespace {
  name: SENSITIVE-f53e749d8f84e52b,
  active_triggers: [ [length]: 0 ],
  system_owner: SENSITIVE-9cf0fd89409efef8,
  bucket_owner: SENSITIVE-3d288e97f8a66631,
  bucket_info: { name: SENSITIVE-f53e749d8f84e52b, owner_account: { email: SENSITIVE-3d288e97f8a66631, id: '60a682b15691c200274328b2' }, namespace: { write_resource: { resource: 'nsfs-nsr-1', path: '/bucket-1' }, read_resources: [ { resource: 'nsfs-nsr-1', path: '/bucket-1' }, [length]: 1 ], should_create_underlying_storage: true }, tag: '', num_objects: { value: 0, last_update:<PHONE_NUMBER>425 }, writable: false, storage: { values: { used: 0, used_other: 0, total: 0, free: 0 }, last_update:<PHONE_NUMBER>483 }, data: { size: 0, size_reduced: 0, free: 0, available_for_upload: 0, last_update:<PHONE_NUMBER>483 }, usage_by_pool: { pools: [ [length]: 0 ], last_update:<PHONE_NUMBER>425 }, stats_by_type: [ [length]: 0 ], mode: 'OPTIMAL', bucket_type: 'NAMESPACE', versioning: 'DISABLED', triggers: [ [length]: 0 ] },
  namespace: {
    write_resource: { resource: { fs_root_path: '/nsfs/parent', fs_backend: 'GPFS', id: '60a678cb5691c20027432898', name: 'nsfs-nsr-1' }, path: '/bucket-1' },
    read_resources: [ { resource: { fs_root_path: '/nsfs/parent', fs_backend: 'GPFS', id: '60a678cb5691c20027432898', name: 'nsfs-nsr-1' }, path: '/bucket-1' }, [length]: 1 ],
    should_create_underlying_storage: true
  }
}
May-24 10:44:06.974 [Endpoint/8]   [LOG] CONSOLE:: /nsfs/parent/bucket-1/check_4 { dev: 2097253, ino: 79957457, mode: 33184, nlink: 1, uid: 5000, gid: 800, rdev: 0, size: 0, blksize: 4194304, blocks: 0, atimeMs:<PHONE_NUMBER>641.978, ctimeMs:<PHONE_NUMBER>642.569, mtimeMs:<PHONE_NUMBER>642.569, birthtimeMs:<PHONE_NUMBER>642.569, atime: 2021-05-24T10:39:48.642Z, mtime: 2021-05-24T10:39:48.643Z, ctime: 2021-05-24T10:39:48.643Z, birthtime: 2021-05-24T10:39:48.643Z }
May-24 10:44:07.322 [Endpoint/8]   [LOG] CONSOLE:: /nsfs/parent/bucket-1/check_4 { dev: 2097253, ino: 79957457, mode: 33184, nlink: 1, uid: 5000, gid: 800, rdev: 0, size: 0, blksize: 4194304, blocks: 0, atimeMs:<PHONE_NUMBER>641.978, ctimeMs:<PHONE_NUMBER>642.569, mtimeMs:<PHONE_NUMBER>642.569, birthtimeMs:<PHONE_NUMBER>642.569, atime: 2021-05-24T10:39:48.642Z, mtime: 2021-05-24T10:39:48.643Z, ctime: 2021-05-24T10:39:48.643Z, birthtime: 2021-05-24T10:39:48.643Z }
May-24 10:44:07.323 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream { file_path: '/nsfs/parent/bucket-1/check_4', start: 0, end: Infinity }

noobaa_diagnostics_1621853639.tar.gz

@akmithal I see that the endpoint address looks a bit weird - is that the correct endpoint address?
Using port 8443 for S3 ??? Can you try to reach it with curl and see if you get back a response (should be xml with AccessDenied, but still it should answer).
download failed: s3://bucket-1/check_4 to ./check_5 Could not connect to the endpoint URL: "https://api.ocp-akshat-1.cp.fyre.ibm.com:8443/bucket-1/check_4"

s3u1 is an alias for
alias s3u1="AWS_ACCESS_KEY_ID=<access> AWS_SECRET_ACCESS_KEY=<secret> aws --endpoint https://api.ocp-akshat-1.cp.fyre.ibm.com:8443/ --no-verify-ssl s3"
From OCP+ environments, we get hostname of OCP infrastructure node as api. only. Are you suggesting, we use names from oc get route command:
[root@ocp-akshat-1-inf ~]# oc get route
NAME          HOST/PORT                                              PATH   SERVICES      PORT         TERMINATION          WILDCARD
noobaa-mgmt   noobaa-mgmt-noobaa.apps.ocp-akshat-1.cp.fyre.ibm.com          noobaa-mgmt   mgmt-https   reencrypt/Redirect   None
s3            s3-noobaa.apps.ocp-akshat-1.cp.fyre.ibm.com                   s3            s3-https     reencrypt            None

Curl o/p on the existing endpoint address. Is this an expected o/p ?
[root@hpo-node1 ~]# curl -v https://api.ocp-akshat-1.cp.fyre.ibm.com:8443/bucket-1/check_4
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to api.ocp-akshat-1.cp.fyre.ibm.com (<IP_ADDRESS>) port 8443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, [no content] (0):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, [no content] (0):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: self signed certificate in certificate chain
* Closing connection 0
curl: (60) SSL certificate problem: self signed certificate in certificate chain
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

Hello @guymguym , I attempted doing read using endpoint from command "oc get route" but it failed with the same error as above.
alias s3u4="AWS_ACCESS_KEY_ID=A83nz1ZeDJfi8ioJLAjT AWS_SECRET_ACCESS_KEY=NCjHMMgccLHZzcoyekGbQVpRY7HoM3DogADcBNRH aws --endpoint https://s3-noobaa.apps.ocp-akshat-1.cp.fyre.ibm.com   --no-verify-ssl s3"
Upload worked well but download/read operation is failing.
[root@hpo-node1 ~]# s3u4 cp check_8 s3://bucket-1/
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 's3-noobaa.apps.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
upload: ./check_8 to s3://bucket-1/check_8
[root@hpo-node1 ~]# s3u4 cp s3://bucket-1/check_8 check_8_content
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 's3-noobaa.apps.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 's3-noobaa.apps.ocp-akshat-1.cp.fyre.ibm.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings

noobaa_diagnostics_1621936063.tar.gz

O/p of curl command with -k option:

[root@hpo-node1 akshat]# curl -k -v https://api.ocp-akshat-1.cp.fyre.ibm.com:8443/bucket-1/check_4

Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to api.ocp-akshat-1.cp.fyre.ibm.com (<IP_ADDRESS>) port 8443 (#0)
ALPN, offering h2
ALPN, offering http/1.1
successfully set certificate verify locations:
CAfile: /etc/pki/tls/certs/ca-bundle.crt
CApath: none
TLSv1.3 (OUT), TLS handshake, Client hello (1):
TLSv1.3 (IN), TLS handshake, Server hello (2):
TLSv1.3 (IN), TLS handshake, [no content] (0):
TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
TLSv1.3 (IN), TLS handshake, [no content] (0):
TLSv1.3 (IN), TLS handshake, Certificate (11):
TLSv1.3 (IN), TLS handshake, [no content] (0):
TLSv1.3 (IN), TLS handshake, CERT verify (15):
TLSv1.3 (IN), TLS handshake, [no content] (0):
TLSv1.3 (IN), TLS handshake, Finished (20):
TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
TLSv1.3 (OUT), TLS handshake, [no content] (0):
TLSv1.3 (OUT), TLS handshake, Finished (20):
SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
ALPN, server accepted to use http/1.1
Server certificate:
subject: CN=s3.noobaa.svc
start date: May 20 14:51:18 2021 GMT
expire date: May 20 14:51:19 2023 GMT
issuer: CN=openshift-service-serving-signer@1619583883
SSL certificate verify result: self signed certificate in certificate chain (19), continuing anyway.
TLSv1.3 (OUT), TLS app data, [no content] (0):

GET /bucket-1/check_4 HTTP/1.1
Host: api.ocp-akshat-1.cp.fyre.ibm.com:8443
User-Agent: curl/7.61.1
Accept: /

TLSv1.3 (IN), TLS handshake, [no content] (0):
TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
TLSv1.3 (IN), TLS handshake, [no content] (0):
TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
TLSv1.3 (IN), TLS app data, [no content] (0):
< HTTP/1.1 403 Forbidden
< x-amz-request-id: kp3w09e1-gja7ta-152o
< x-amz-id-2: kp3w09e1-gja7ta-152o
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Credentials: true
< Access-Control-Allow-Methods: GET,POST,PUT,DELETE,OPTIONS
< Access-Control-Allow-Headers: Content-Type,Content-MD5,Authorization,X-Amz-User-Agent,X-Amz-Date,ETag,X-Amz-Content-Sha256
< Access-Control-Expose-Headers: ETag,X-Amz-Version-Id
< Content-Type: application/xml
< Content-Length: 191
< Date: Tue, 25 May 2021 10:19:58 GMT
< Connection: keep-alive
< Keep-Alive: timeout=5
<
Connection #0 to host api.ocp-akshat-1.cp.fyre.ibm.com left intact

AccessDeniedAccess Denied/bucket-1/check_4kp3w09e1-gja7ta-152o[root@hpo-node1 akshat]#

I moved on to new build 20210307 via clean install. Have set debug level as 5 using command set_debug_level:
Observation:
Upload worked fine for 1GB x 20 files
Download failed for each of these 20 files and endpoint crashed - 1st instance
Download worked for all these files - 2nd instance
Endpoint log:

4194304, blocks: 2000000, atimeMs:<PHONE_NUMBER>052.019, ctimeMs:<PHONE_NUMBER>917.2744, mtimeMs:<PHONE_NUMBER>917.2744, birthtimeMs:<PHONE_NUMBER>917.2744, atime: 2021-06-08T14:23:05.052Z, mtime: 2021-06-08T14:18:03.917Z, ctime: 2021-06-08T14:18:03.917Z, birthtime: 2021-06-08T14:18:03.917Z }
Jun-8 14:23:08.249 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream { file_path: '/nsfs/nsfs-nsr-1/bucket-1/small_chunk_1', start: 201326592, end: 209715200 }
Jun-8 14:23:08.328 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:08.503 [Endpoint/8]   [LOG] CONSOLE:: /nsfs/nsfs-nsr-1/bucket-1/small_chunk_1_read { dev: 242, ino: 85208383, mode: 33184, nlink: 1, uid: 5000, gid: 800, rdev: 0, size:<PHONE_NUMBER>, blksize: 4194304, blocks: 2000000, atimeMs:<PHONE_NUMBER>553.0498, ctimeMs:<PHONE_NUMBER>655.6125, mtimeMs:<PHONE_NUMBER>655.6125, birthtimeMs:<PHONE_NUMBER>655.6125, atime: 2021-06-08T14:23:05.553Z, mtime: 2021-06-08T14:18:25.656Z, ctime: 2021-06-08T14:18:25.656Z, birthtime: 2021-06-08T14:18:25.656Z }
Jun-8 14:23:08.503 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream { file_path: '/nsfs/nsfs-nsr-1/bucket-1/small_chunk_1_read', start: 142606336, end: 150994944 }
Jun-8 14:23:08.564 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:08.830 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:08.833 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:08.893 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:08.894 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:08.924 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.016 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.017 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.017 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.134 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.185 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.205 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.301 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.301 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.301 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.327 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.499 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.499 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.499 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.500 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.500 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
Jun-8 14:23:09.500 [Endpoint/8]   [LOG] CONSOLE:: NamespaceFS: read_object_stream completed { num_bytes: 8388608, num_buffers: 1, avg_buffer: 8388608, log2_size_histogram: { '23': 1 } }
/noobaa_init_files/noobaa_init.sh: line 74:     8 Killed                  $*
######################################################################
Tue Jun  8 14:23:09 UTC 2021 NooBaa: Process exited RIP (RC=137)
######################################################################

endpoint_6530_1GB_read.zip

noobaa_diagnostics_1623163166.tar.gz

@akmithal do we still see this with endpoint mem > 2.5GB ?

Closing this bug now.


Did the AR.js can do markerless tracing?

Such as take a picture, use the picture as a marker. Then open the camera, tracing the picture center position and draw same 3D stuff on it ?

unfortuntatly not :( AR.js doesnt support image based marker at the moment

Hi  jeromeetienne, thank you.
Perhaps you can give me some advice to do this with AR.js!


Relax test_adapt_freq error tolerance threshold

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #1417

[x] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[x] CHANGES.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Relaxes the tolerance threshold so that false-positive errors occur less often.

Does this PR introduce a breaking change?
No.

@aulemahal Can I tag you in on this? I can't figure out why this is happening only on conda:
FAILED tests/test_analog.py::test_spatial_analogs[friedman_rafsky] - AssertionError:
Not equal to tolerance rtol=0.001, atol=0.001

Mismatched elements: 1 / 6496 (0.0154%)
Max absolute difference: 0.14285714
Max relative difference: 0.21428571
 x: array([[     nan,      nan,      nan, ...,      nan,      nan,      nan],
       [     nan,      nan,      nan, ...,      nan,      nan,      nan],
       [     nan,      nan,      nan, ...,      nan,      nan,      nan],...
 y: array([[     nan,      nan,      nan, ...,      nan,      nan,      nan],
       [     nan,      nan,      nan, ...,      nan,      nan,      nan],
       [     nan,      nan,      nan, ...,      nan,      nan,      nan],...
FAILED tests/test_ensembles.py::TestEnsembleReduction::test_kmeans_rsqopt - assert [4, 5, 7, 10, 11, 12, ...] == [3, 4, 5, 7, 10, 11, ...]
  At index 0 diff: 4 != 3
  Right contains one more item: 13
  Full diff:
  - [3, 4, 5, 7, 10, 11, 12, 13]
  ?  ---
  + [4, 5, 7, 10, 11, 12, 13]
FAILED tests/test_ensembles.py::TestEnsembleReduction::test_kmeans_sampleweights - assert [4, 5, 7, 10, 12, 13] == [4, 5, 7, 10, 11, 12, ...]
  At index 4 diff: 12 != 11
  Right contains one more item: 13
  Full diff:
  - [4, 5, 7, 10, 11, 12, 13]
  ?               ----
  + [4, 5, 7, 10, 12, 13]

Most likely due to the June 30th update of scikit-learn!


Make fields in Sort compulsory

Make fields in Sort compulsory so it is less confusing for users

Codecov Report

Merging #187 (2dc61ef) into master (d33d699) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #187      +/-   ##
============================================
- Coverage     47.34%   47.09%   -0.26%
  Complexity      355      355
============================================
  Files            89       89
  Lines          1679     1688       +9
  Branches        184      188       +4
============================================
  Hits            795      795
- Misses          815      824       +9
  Partials         69       69

Impacted Files
Coverage Δ

...java/seedu/trackermon/logic/parser/ParserUtil.java
73.17% <0.00%> (-7.92%)
:arrow_down:

...edu/trackermon/logic/parser/SortCommandParser.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/trackermon/model/show/Name.java
72.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33d699...2dc61ef. Read the comment docs.


send_capabilities_request was misspelled

this corrects the spelling of "capabilities" and adds an alias to the
old name to avoid breaking existing code.

Merged, thanks!


Rewrite web rendering to use templating

Rewrite web rendering to use templating

Done in https://github.com/NewDayNaz/SmartSwitchPowerSequencer/commit/5ca8482a190cf6438f3ac807a638e325f1ffbeb4


🐛 BUG: Vue types imported from monorepo package are not regonized

Describe the Bug
I have monorepo, with two packages one is vue components and other regular astro site. I use project references and so on. Importing regular ts/tsx files inside astro pages work as expected, but when I try importing any of my vue components, types are not resolved correctly. If i reexport vue components to index.ts and then import that, it shows that such export exists but types are empty. Actual vue component runs, just types are wrong.
Semi related to https://github.com/withastro/language-tools/issues/649 but I don't do any bundling/dts emit so it is bit different.
Steps to Reproduce

Setup monorepo with 2 packages. One vue components, other regular astro site.
Try to import component from vue package, into astro site.
Observe types being not recognized.

Any chance you could share a reproduction?

You should be able reproduce issue here https://github.com/minht11/astro-monorepo-types-issue

I installed volar extension to see virtual files for vue components in design-system package and they are empty, because of this line https://github.com/withastro/language-tools/blob/7e5ccb70a59b0449048295b24e8cb4742063f6b0/packages/language-server/src/core/utils.ts#L17-L23
As far as I understand astro resolves entry point for design-system not for site package, it doesn't find @astro/vue integration installed there so it returns empty file.
In fact if I add "@astrojs/vue": "^3.0.1" to design-system package.json it starts to work.

@Princesseuh Just found my way here through Google. Could you comment on the state of support for TSC project references in astro check? I have been trying to get Astro to correctly type-check .astro files which import files from other projects but it either complains about those files not existing (if I use astro check --tsconfig tsconfig.astro.json) or it ignores those imports entirely & fails to recognize type errors  (if I use astro check --tsconfig tsconfig.json, where tsconfig.json is the "main" aka "solution-style" tsconfig that references everything else). I'll be happy to file a bug report but I just wanted to check what to expect here.
More generally, it'd be great if the docs went into more detail about what astro check actually does. (Does it use TSC under the hood? What TSC features does it support? etc.)

I don't know exactly the features that are supported., astro check is a pretty thin wrapper around @volarjs/kit, which uses the TypeScript APIs directly to get errors (this is also how vue-tsc works, if you're familiar with that)

I see, thank you! The thing is that vue-tsc works well with project references, so now I'm surprised that astro check behaves differently. :\

If I file a bug report, I suppose I should file it here in this repo then?

If I file a bug report, I suppose I should file it here in this repo then?

I think the issue is ultimately upstream, but you may fill it here for convenience and I'll report it upstream (either way, I'm a maintainer of both projects so...)
vue-tsc only somewhat works like this, it uses fairly different codepaths mostly because it does other things


bumping inventory to 0.18.0.Final

Jenkins failure is some internal NPE in the GitHub pusher. Build itself went well.


Migrate quesiton edit, API key and translation pages to use standard buttons

Description
Additionally made view changes:

Switched view code from using LinkButton to use ViewUtils.makeSvgButton and removed code that no longer used.
Replaced "Remove" with "Delete" to be consistent with other pages in admin.
Updated JS to use event.currentTarget instead event.target to get element that event listener was registered on instead of element that received the event. That's important as now buttons can have nested elements (svg, span) and event listeners normally care only about button.

Release notes
Admin question edit page, API key page and translation page now use standard buttons.
Checklist
General

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[x] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Wrote browser tests using the validateAccessibility method
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/application.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Issue(s) this completes
Issue #3659

Codecov Report

Merging #3936 (0d2f5a9) into main (8e77309) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3936   +/-   ##
=========================================
  Coverage     80.79%   80.79%
  Complexity     2458     2458
=========================================
  Files           298      298
  Lines          9676     9676
  Branches        659      659
=========================================
  Hits           7818     7818
  Misses         1603     1603
  Partials        255      255

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi Mikita! The button changes look great. I think the only thing is the buttons with an icon look like the padding to the left of the icon within the button looks a bit larger than the padding on the right side. Thank you for making these changes!
https://screenshot.googleplex.com/Krutc3s6ytsouGj

Filed https://github.com/civiform/civiform/issues/3938 to align buttons better


What if I want to use as library instead run the entire source code?

According to some researches, is mandatory the use of the internal folder example to use Raneto.
That is fine but some folks might want to use as simple npm module. I tried:
var raneto = require('raneto');
var config = require('./config.default.js');
var app = raneto(config);
var server = app.listen(app.get('port'), function () {
  console.log('Express HTTP server listening on port ' + server.address().port);
});

So in order to make this works, I need to install as npm module:
npm i raneto --save

This throws an error:
gulp not found

That is because gulp is in devDependencies.
I think gulp is not just a dev library for Raneto.
Due to Raneto necesity of public/lib folder with several js files, I think must be moved to dependencies.
I moved it and this error dissapear

Can you provide more of your use-case and what you're trying to accomplish?
Typically the public/ directory would not need to be used for a Node "library" but it depends on how it is used.
Please give us an idea and we can better advise.
Are you looking to use the markdown rendering engines alone?
An embeddable widget on pages?

Hi.
I mean that if I want to use raneto, I need the entire source code of raneto. Is it correct?
Comparing with similar frameworks or thinking as a library maker, it would be grateful if Raneto will be able to be used as library, instead to clone the entire Raneto source code.

Hi.
I mean that if I want to use raneto, I need the entire source code of raneto. Is it correct?
Comparing with similar frameworks or thinking as a library maker, it would be grateful if Raneto will be able to be used as library, instead to clone the entire Raneto source code.

Adding this to the Roadmap megathread.
Closing this issue to cleanup


Short circuit updated

Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[x] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[x] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[x] General Coding Practices

@petrblaho I added back short_circuit (though this will need to merge after the latest drift-backend PR to update the schema there), and I commented out the logger for the _emit_notification until the kafka portion is merged.


Move Tests to separate Packages bo_test, com_test and enum_test

only code re-structuring. not actual changes


Update for 1.4.0 release

Tested on minikube with k8s 1.16.8, 1.17.4, 1.18.1.

This largely refers to https://github.com/weaveworks/kured/pull/127
I tested this in our Dev environment at Weaveworks too.

Looking at https://github.com/weaveworks/kured#kubernetes--os-compatibility and read "Kubernetes aims to provide forwards & backwards compatibility of one minor version between client and server" - I'm wondering should we have moved to 1.17 instead?

Yes it might be safer to have updated to just 1.17, but I don't think it's a big problem.
People can use version 1.3.0 until they upgrade to a k8s 1.16/1.17, for which they would be able to use 1.3.0, upgrade to 1.4.0, and then upgrade to k8s further. That's not good enough IMO.

Mh. Not sure - we could try to get back to 1.17 and be clearer about what we support.

I am fine with that approach too.

This will need changing once #135 is merged.


Typo in "Migrating to version 3"?

I see in your readme.md > Migrating to version 3:
view.setImageBitmap(map) -> view.getImage(ImageSource.bitmap(map))
Is it typo there? I think it should be view.setImage(ImageSource.bitmap(map)) instead.

Corrected, thanks!


[WFCORE-3722] delete duplicate version properties.

https://issues.jboss.org/browse/WFCORE-3722 delete duplicate version properties.

@soul2zimate Can you expand on this a bit and get the rest on the plugin version props in that section moved to be properly grouped in alphabetically with all the rest? Perhaps wait a day or two in case people disagree.
@dosoudil @psakar @kabir FYI, in case you disagree with organizing them all together. I see some vague benefit in separating out plugins from normal dependencies, but OTOH experience is teaching me that any organizing principle other than the simplest possible is just going to fall apart over time, as it has here.

I agree that plugin versions should be in a separate section. There is already a commented with <!-- Non-default maven plugin versions and configuration -->.

@jamezp You said you agree, but I asked Chao Wang to move those version props out of that section. :)

@bstansberry Whoops I read that wrong for sure. I don't have a strong opinion either way as long as it's consistent.

I think I'll go ahead and merge this as there's no reason to leave the duplicates while we discuss organization.  By doing that I don't mean to imply I'm not interested in any input.
I know Kabir is looking at generating the former component-matrix/pom ,the content of which probably (???) is not meant to include plugins. It was very vague wondering about ease of maintenance of that kind of thing that led to my question.

@bstansberry Correct, at least the component-matrix we removed did not really contain plugins.

Gosh, I totally misread this PR anyway. It fixed the duplication by removing the plugins from the alphabetical list.


Query - Custom Yang Parameter Validation

I installed some of my custom Yang configurations using sysrepoctl. Once I start the netopeer2-server, I am able to see the respective schema getting loaded during startup. Using netopeer2-cli, I am editing the running config and pushing my Custom Configuration based on the Custom Yang configuration I have provided.
My query is, Will Netopeer2-server validate the pushed configuration from netopeer2-cli with the Custom Yang configuration installed with sysrepoctl ? Because in my Custom Yang conf lets say I have given a range for parameter to be (0..65535) then I expect the netopeer2-server to throw error when wrong value is pushed but I dont see any such result, I am able to push even alphabets for this parameter and netopeer2-server still accepts it with no rpc-error.
But when I change something related to ietf-nacm module, and then I try to push/edit configuration related to this module, I am able to get rpc-error. On checking the code, I can see that there are condition checks to verify the configurations in relation to ietf-nacm module.
So, should we write separate code for our custom yang configurations to acheive this validation scenario ? If yes, Could you please let me know the procedure to do so in netopeer2-server ? Thanks.
Please correct me if my understanding is wrong as well.Thank you.

Hi,
well, it all depends on your value restrictions. YANG provides quite a wide array of statements that you can use for this and these are checked automatically. But it is also possible to write your own code for validating the values but that should not be needed for 99% of cases. So, can you paste your custom YANG?
Regards,
Michal

One of the Yang parameter:
leaf dlbw {
description  " dlbw";
mandatory false;
config true;
type uint16 {
range "1 .. 65535" {
error-message "dlbw value Should be in range from [1, 65535].";
}
}
must " .  != '0' " {
error-message "dlbw value should not be 0.";
}
}

This is the ietf-nacm file I used which I got from https://github.com/CESNET/netopeer2/issues/658.

false

If I make any wrong changes here, I can see rpc-error. And the "enable-nacm" checks are present in netopeer2-server code/

Hi,
like I said then, the value is checked automatically so you must be doing something wrong. Can you also paste the commands you have used for editing the data and any output?
Regards,
Michal

To edit the running config:

edit-config --target running --config=/home/debian/sysrepo_cfg/ct/cu.xml
OK

Hm, this is all weird. What netopeer2 version are you using?
Regards,
Michal

$ netopeer2-server -V
netopeer2-server 1.1.39

Okay, can you then post the output of netopeer2-server when run with -v2 and you doing this edit-config? Thanks.

Netopeer2  Server:
debian@debian-debian:~/netopeer/netopeer2$ sudo netopeer2-server -d -v3
[INF]: LY: Plugin "/usr/local/lib/libyang1/extensions/yangdata.so" successfully loaded.
[INF]: LY: Plugin "/usr/local/lib/libyang1/extensions/metadata.so" successfully loaded.
[INF]: LY: Plugin "/usr/local/lib/libyang1/extensions/nacm.so" successfully loaded.
[INF]: LY: Plugin "/usr/local/lib/libyang1/user_types/user_inet_types.so" successfully loaded.
[INF]: LY: Plugin "/usr/local/lib/libyang1/user_types/user_yang_types.so" successfully loaded.
[INF]: LY: Reading module "ietf-yang-metadata".
[INF]: LY: Module "ietf-yang-metadata@2016-08-05" successfully parsed as implemented.
[INF]: LY: Reading module "yang".
[INF]: LY: Resolving "yang" unresolved schema nodes and their constraints...
[INF]: LY: All "yang" schema nodes and constraints resolved.
[INF]: LY: Module "yang@2017-02-20" successfully parsed as implemented.
[INF]: LY: Reading module "ietf-inet-types".
[INF]: LY: Resolving derived type "union" failed, it will be attempted later.
[INF]: LY: Resolving derived type "union" failed, it will be attempted later.
[INF]: LY: Resolving derived type "union" failed, it will be attempted later.
[INF]: LY: Resolving derived type "union" failed, it will be attempted later.
[INF]: LY: Resolving "ietf-inet-types" unresolved schema nodes and their constraints...
[INF]: LY: All "ietf-inet-types" schema nodes and constraints resolved.
[INF]: LY: Module "ietf-inet-types@2013-07-15" successfully parsed as implemented.
[INF]: LY: Reading module "ietf-yang-types".
[INF]: LY: Module "ietf-yang-types@2013-07-15" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-yang-types" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Resolving "sysrepo" unresolved schema nodes and their constraints...
[INF]: LY: All "sysrepo" schema nodes and constraints resolved.
[INF]: LY: Module "sysrepo@2020-01-15" successfully parsed as implemented.
[WRN]: SR: Removing event pipe "sr_evpipe25" after a crashed subscription.
[WRN]: SR: Removing event pipe "sr_evpipe26" after a crashed subscription.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: SR: Applying scheduled changes.
[INF]: LY: Searching for "ietf-datastores" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-datastores@2018-02-14" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-yang-library" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-inet-types" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Searching for "ietf-datastores" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-yang-library@2019-01-04" successfully parsed as implemented.
[INF]: LY: Searching for "sysrepo-monitoring" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Resolving "sysrepo-monitoring" unresolved schema nodes and their constraints...
[INF]: LY: All "sysrepo-monitoring" schema nodes and constraints resolved.
[INF]: LY: Module "sysrepo-monitoring@2020-04-17" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-netconf-with-defaults" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-netconf" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-netconf-acm" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-netconf-acm@2018-02-14" successfully parsed as imported.
[INF]: LY: Module "ietf-netconf@2013-09-29" successfully parsed as imported.
[INF]: LY: Resolving "ietf-netconf-with-defaults" unresolved schema nodes and their constraints...
[INF]: LY: All "ietf-netconf-with-defaults" schema nodes and constraints resolved.
[INF]: LY: Module "ietf-netconf-with-defaults@2011-06-01" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-netconf-notifications" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Resolving "ietf-netconf-notifications" unresolved schema nodes and their constraints...
[INF]: LY: All "ietf-netconf-notifications" schema nodes and constraints resolved.
[INF]: LY: Module "ietf-netconf-notifications@2012-02-06" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-origin" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-yang-metadata" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Resolving "ietf-origin" unresolved schema nodes and their constraints...
[INF]: LY: All "ietf-origin" schema nodes and constraints resolved.
[INF]: LY: Module "ietf-origin@2018-02-14" successfully parsed as implemented.
[INF]: LY: Module "ietf-netconf-acm@2018-02-14" now implemented.
[INF]: LY: Searching for "ietf-netconf-monitoring" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-netconf-monitoring@2010-10-04" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-netconf-nmda" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-origin" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-netconf-with-defaults" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Resolving "ietf-netconf-nmda" unresolved schema nodes and their constraints...
[INF]: LY: All "ietf-netconf-nmda" schema nodes and constraints resolved.
[INF]: LY: Module "ietf-netconf-nmda@2019-01-07" successfully parsed as implemented.
[INF]: LY: Searching for "nc-notifications" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "notifications" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "notifications@2008-07-14" successfully parsed as imported.
[INF]: LY: Module "nc-notifications@2008-07-14" successfully parsed as implemented.
[INF]: LY: Module "notifications@2008-07-14" now implemented.
[INF]: LY: Searching for "ietf-x509-cert-to-name" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-x509-cert-to-name@2014-12-10" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-crypto-types" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-crypto-types@2019-07-02" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-keystore" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-crypto-types" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Resolving "ietf-keystore" unresolved schema nodes and their constraints...
[INF]: LY: All "ietf-keystore" schema nodes and constraints resolved.
[INF]: LY: Module "ietf-keystore@2019-07-02" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-truststore" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-truststore@2019-07-02" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-tcp-common" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-tcp-common@2019-07-02" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-ssh-server" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-ssh-common" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-ssh-common@2019-07-02" successfully parsed as imported.
[INF]: LY: Searching for "ietf-keystore" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "iana-crypt-hash" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "iana-crypt-hash@2014-08-06" successfully parsed as imported.
[INF]: LY: Module "ietf-ssh-server@2019-07-02" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-tls-server" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-tls-common" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-tls-common@2019-07-02" successfully parsed as imported.
[INF]: LY: Searching for "ietf-truststore" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-tls-server@2019-07-02" successfully parsed as implemented.
[INF]: LY: Searching for "ietf-netconf-server" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-x509-cert-to-name" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-tcp-client" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Searching for "ietf-tcp-common" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-tcp-client@2019-07-02" successfully parsed as imported.
[INF]: LY: Searching for "ietf-tcp-server" in /home/debian/netopeer/sr_repo/yang.
[INF]: LY: Loading schema from<EMAIL_ADDRESS>file.
[INF]: LY: Module "ietf-tcp-server@2019-07-02" successfully parsed as imported.
[INF]: LY: Resolving "ietf-netconf-server" unresolved schema nodes and their constraints...
[INF]: LY: All "ietf-netconf-server" schema nodes and constraints resolved.
[INF]: LY: Module "ietf-netconf-server@2019-07-02" successfully parsed as implemented.
[INF]: SR: No scheduled changes.
[INF]: SR: Datastore copied from  to .
[INF]: SR: Session 1 (user "root") created.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: There is no leafref "/ietf-keystore:keystore/ietf-keystore:asymmetric-keys/ietf-keystore:asymmetric-key/ietf-keystore:name" with the value "genkey", but it is not required.
[INF]: LY: All data nodes and constraints resolved.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: LN: Listening on <IP_ADDRESS>:830 for SSH connections.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Ext SHM was defragmented and 4368 B were saved.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-server" "done" event on enabled data.
[INF]: SR: Triggering "ietf-keystore" "done" event on enabled data.
[INF]: SR: Triggering "ietf-truststore" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-acm" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-acm" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-acm" "done" event on enabled data.
[INF]: SR: Triggering "ietf-netconf-acm" "done" event on enabled data.
[INF]: LN: Accepted a connection on <IP_ADDRESS>:830.
[INF]: SR: Session 2 (user "root") created.
[INF]: LN: Received an SSH message "request-service" of subtype "ssh-userauth".
[INF]: LN: Received an SSH message "request-auth" of subtype "none".
[INF]: LN: Received an SSH message "request-auth" of subtype "interactive".
[INF]: LN: Received an SSH message "request-auth" of subtype "interactive".
[INF]: LN: Failed user "debian" authentication attempt (#1).
[INF]: LN: Received an SSH message "request-auth" of subtype "password".
[INF]: LN: User "debian" authenticated.
[INF]: LN: Received an SSH message "request-channel-open" of subtype "session".
[INF]: LN: Received an SSH message "request-channel" of subtype "subsystem".
[INF]: SR: Session 3 (user "root") created.
[INF]: SR: There are no subscribers for "ietf-netconf-notifications" notifications.
[INF]: NP: Generated new event (netconf-session-start).
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-yang-library" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-datastores" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-datastores" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: SR: Published event "rpc" "/ietf-netconf:get" with ID 1 priority 0 for 1 subscribers.
[INF]: SR: Processing "/ietf-netconf:get" "rpc" event with ID 1 priority 0 (remaining 1 subscribers).
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: SR: Successful processing of "rpc" event with ID 1 priority 0 (remaining 0 subscribers).
[INF]: SR: Event "rpc" with ID 1 priority 0 succeeded.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "sysrepo" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "sysrepo-monitoring" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-netconf-with-defaults" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-netconf-notifications" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-origin" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-yang-metadata" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-origin" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LN: Schema "ietf-netconf-with-defaults" was requested.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: SR: Published event "rpc" "/ietf-netconf:edit-config" with ID 1 priority 0 for 1 subscribers.
[INF]: SR: Processing "/ietf-netconf:edit-config" "rpc" event with ID 1 priority 0 (remaining 1 subscribers).
[INF]: NP: edit-config error-option "stop-on-error" not supported, rollback-on-error will be performed.
[INF]: SR: There are no subscribers for changes of the module "ietf-netconf" in running DS.
[INF]: SR: Successful processing of "rpc" event with ID 1 priority 0 (remaining 0 subscribers).
[INF]: SR: Event "rpc" with ID 1 priority 0 succeeded.
[INF]: NP: Session 1: thread 3 event new RPC.
Netopeer CLi:
debian@debian-debian:/$ netopeer2-cli

connect
Interactive SSH Authentication
Type your password:
Password:
debian@localhost password:
edit-config --target running --config=/home/debian/sysrepo_cfg/cu/cu.xml
OK

Now for this cu.xml, I have not installed any yang prior.

6

Reflected on get-config:

get-config --source running
DATA

default-ssh

<IP_ADDRESS>

1
10
5

default-key

genkey

interactive

genkey
rsa2048
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtnoAu/zNOpbq/YChGTtG
AwdqWtRwJT3kwt4x2OwGs4TgAa3VA0TdRGffuR7NzWMEzd47v8CFoPn91Dtz3Ean
lRxj8vJCqHtRHstcU8HRnN+1WnbrGsC4jQ5q9qs+TZomq4O9dadsPviJPeAu8Fwh
i9W6m9DUKeY7xlIc+1DKqLuKLBR8IXRvlKD8d1gkD3vdvusKpcSioW9I+09b/W2z
PZKkxnnWnsoP/vIGiUrNPGm4XuTj6tqCa4Kb4em4oUfCqVVqyvzCOYhuJOJ7T4k4
7XsHYnBscYojPhUuUwKhPGAEjQ2GCqGP2DHP3RUi9HdReNMVebX/Wu9r36yrALMA
zQIDAQAB
MIIEvwIBADANBgkqhkiG9w0BAQEFAASCBKkwggSlAgEAAoIBAQC2egC7/M06lur9
gKEZO0YDB2pa1HAlPeTC3jHY7AazhOABrdUDRN1EZ9+5Hs3NYwTN3ju/wIWg+f3U
O3PcRqeVHGPy8kKoe1Eey1xTwdGc37VadusawLiNDmr2qz5Nmiarg711p2w++Ik9
4C7wXCGL1bqb0NQp5jvGUhz7UMqou4osFHwhdG+UoPx3WCQPe92+6wqlxKKhb0j7
T1v9bbM9kqTGedaeyg/+8gaJSs08abhe5OPq2oJrgpvh6bihR8KpVWrK/MI5iG4k
4ntPiTjtewdicGxxiiM+FS5TAqE8YASNDYYKoY/YMc/dFSL0d1F40xV5tf9a72vf
rKsAswDNAgMBAAECggEBAIwVzUqEIOnBwlUq0oIURwM8RiHExPNSOLSA77OgPuTC
NVYUpVsFGvjQ5aewRj5Orfl9ilEC85NJV9v+aEvK0gxe5zwzT4kYYoZJiG+kc88C
zq7MbGD1YrinQOZtQD9DADzbvi78gNU25+VgnahYkkhPpBrKjpY78demYiltNKej
RTq/x4kYm/QICNUe2dyrnWjs/+L2rKkUZ+PU93r3uASlsArBG314elgDo7wF7Yji
IGlBnQxo+fHupLfqYkvBqlgYG8HCrzGiGhmeuJUkeJ/3PdGveJbzCJfd67aaqn+P
nCYHhO4c/tmSNWkLphNdPbIph7Hgo7yLB/ZJH8MNcQECgYEA5p9LzgiPkEI1n1NU
6Z/cCzUbw4o4VkZdm6cO/dIGq2jKdWYWXbY3d9KetZ5//HWB+aWvL8tW3Zu5iEM5
kisclPHBmyPm7SHTGLCtcRTNud6LwYS3z6rCC5dJAFEK8Szk3RslrPnSKklFm0rC
WZg5uhL1TuY2nohXzIFtic5ddGUCgYEAyo5tZ9WQye19KxY3Au+TeliVeJs1mK5E
RQoFCtg+g0+ah5/3KZ7Vea6N33ik6Qs2Lcr87WgP9zn8AbdxIEijoyUa0DaKiBh5
o8tF6/cYEreUjO8dy8Jd7vi0oijZmbOYz1QXF6773PTN7N8rwQVGlP/SAJCbEge4
SVmE6OEEkEkCgYAw70gUdbiQsZvTLMltsR/tuN0lRqThmZivOGlz7ibAJEIhWwIP
7GQkpqpKe1FI7l4f7MoZaBoMd8iMY0dJ/p/X8txT4PBVDMJQEN0ci3+DmvcontKp
29/EudshmBCsUAxX5jS+WVwA4P9GDjzi6ewF0ZP/o9WfGesXV7c4cHNgCQKBgQCb
cDjc2bLGgozvJ5kHk7nkxV3Os6ypgfG52TqNW+x87/Vx5nvRYKYJPr54oyhJ/eSR
t5fox1aZLdIJrzAMyjFo3Ox6o6AjWETgQPljXrcGhgJlNIn09y8GV6ymVBrILF4z
nCAseIemw+XSxF/bO6Uyai5JaK7XYz00bJHl8+eAoQKBgQCcieV1eTMBzeMSS9Pe
aWZmtoHVb29g5X5upBs3EHk745sYwvg9AfCQ4F9k0A5A653sXs2EkXpvdAsCKzMf
+Qwu4YW/8JWxBRgIfGIgFzg8e1PM9syIgP9ON1LnrN/0qFuUg5yDBpWI+G5oHtSS
TV6kuThFKdEbq6EBqVF0tNquLA==

false

<ME xmlns="urn:3g:tsg:sa5:nr:ran"><dlbw>6</dlbw></ME>

Oh, wow, that is some use-case. What you are actually doing is editing a dummy anyxml node that is always added to ietf-netconf module so that configuration from an url (for url capability) can be loaded. It was never meant to be actually set to any value, it is just an unfortunate side-effect that it is possible to be configured.
What is more, it should actually be correctly handled if you have just used
<config xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
  <ME xmlns="urn:3g:tsg:sa5:nr:ran">
	<dlbw>6</dlbw>
  </ME>
</config>

meaning specify the correct namespace. So my guess is the namespace got corrected later as a part of some lenient user-friendly parsing.
TLDR; just drop the whole config element and your edits will work the way they should. If you need to have them for some reason, then at least correct the namespace and remove the prefix.
Regards,
Michal

Yes its throwing error now after using the correct xml format. Thanks.

edit-config --target running --config=/home/vvdn/sysrepo_cfg/cu/cu.xml
ERROR
type:     application
tag:      operation-failed
severity: error
path:     /
message:  Unknown element "ME".

So, one last query before I close. In any case, i should provide the correct xml namespace for proper Custom YANG validation . Correct ?

I do not understand your question. When you use edit-config, directly the configuration data are expected, with their proper namespace. There is just the one exception that you may enclose them in config element in the urn:ietf:params:xml:ns:netconf:base:1.0 namespace because it is specified that way for url. But you should not do that normally.
Regards,
Michal

okay understood. Thanks.


Incorrect name of NuGet package to seach for in package manager

NuGet package, in package explorer, search for "Microsoft.ML" instead of "Microsoft ML.NET"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8e22825-c4ee-5a36-f911-8ad456970ecc
Version Independent ID: ad0bf640-7dfc-1184-077c-358bb14277a7
Content: Use ML.NET in a sentiment analysis classification scenario
Content Source: docs/machine-learning/tutorials/sentiment-analysis.md
Service: dotnet-ml
GitHub Login: @JRAlexander
Microsoft Alias: johalex

Thanks for your feedback @RobDaPraia. I have a PR open already to fix this issue.

PM> Install-Package Microsoft.ML


Disable commiting changes to perf_results.json in every PR

Every single PR updates this file, hence anyone submitting a PR will always have their PR out of date,
as a result, the CI will never run.
Assume i have 1 PR (even worse when you have 2-3)

All will be blocked
Then i updated all 5 to run
Now merge 1
Now others will be out of date and CI will block..

I think this should get updated ONLY in the main branch, not in PRs.
Also this results in the local PR branch being out of date, as there are changes on the server (that is not expected)
Hence to me this is more of a hindrance to my workflow.
Summary of problems

Cannot submit PRs as it get blocked & CI jobs never run
After fixing this and then submitting more changes to the PR to fix tests, then you find out its out of date all over again
The server branch is updated with changes and my local branch is out of sync (when I own the branch)

Suggestion

Commit only in main branch
Upload this into azure blob store

For now I'm disabling the commits in PRs

Do you know if azure blob storage maintains a history? The goal was to have something tied to a commit that contains the perf results of the commit. So CI could run the test only on main but then update the perf results output with the commit id. But we'd still want to know the history of the perf results.

Need to setup a meeting to discuss once Don is back.

Another idea, submit perf results with every PR to vscode-jupyter-internal so it doesn't interfere with the PR in question.

Even with that we're still uploading files to a separate repository, wouldn't be the same as uploading individual files to azure blob store with each file name having the commit id

I just want a history of the results. Azure blob doesn't support it by default and it seems silly to use azure for source control.

@amunger is actively working on solving this with telemetry.


Adds Phoenix example for Google OAuth2 3-LO

Here is an example of Google OAuth 3LO for Elixir/Phoenix.
There are a lot of files as part of the phoenix framework. I would love to remove as many of them as possible, but I want to stay idiomatic.
Hopefully the running example at https://elixir-auth.appspot.com and the README will help clarify the important parts.

@chingor13 is this ready to merge?


[monkeys-audio] Update to 5.70

Describe the pull request

What does your PR fix? Fixes #

Update to current version 5.70
Released MAC_SDK files are currently only provided for download for a
short period of time and replaced frequently by newer versions.
See: https://monkeysaudio.com/files/
Add alternative download URL from Internet Archive
The feature tools was tested the following way:
.\vcpkg.exe install monkeys-audio[tools]:x86-windows
.\vcpkg.exe install monkeys-audio[tools]:x64-windows

Which triplets are supported/not supported? Have you updated the CI baseline?
!(uwp|osx|linux)

Does your PR follow the maintainer guide?
Yes

Could you please help confirm if the end of line format for these two patches is LF instead of CRLF?

The original MAC_SDK source files are CRLF:
Source/Projects/VS2019/Console/Console.vcxproj
Source/Projects/VS2019/MACDll/MACDll.vcxproj
However, the previous versions of the two patch files were both LF only in all lines:
fix-project-config.patch
remove-certificate-step.patch

Have you tested the feature tools?

The feature tools was tested the following way:
.\vcpkg.exe install monkeys-audio[tools]:x86-windows
.\vcpkg.exe install monkeys-audio[tools]:x64-windows

The built mac.exe files are working properly:
vcpkg\installed\x86-windows\tools\monkeys-audio\mac.exe
vcpkg\installed\x64-windows\tools\monkeys-audio\mac.exe

LGTM now, thanks for your PR @c72578.

Thanks for the PR!


SPFx Gulp Package-Solution --Ship Error

I am in the process of completing some feature updates to a SPFx extension (Application Customizer) that hasn't been modified in approx a year. I've completed my changes and can successfully build, serve, and debug my extension locally. Everything is working great, but I'm running into some trouble with deployment.
Bundling appears to be completing successfully (gulp bundle --ship), but I'm running into the following error trying to package the solution (gulp package-solution --ship):

Could not find Element Manifest: sharepoint\assets/elements.xml

Can anyone offer some guidance regarding what could cause this error and how best to troubleshoot?
Category

[X ] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
the ability to execute gulp package-solution --ship without error.
Observed Behavior
Here is the detailed output and error I'm seeing trying to gulp package-solution --ship:

PS C:\s7sgit\IBSA\spfx\extensions\ibsa-spfx-extensions> gulp package-solution --ship
Build target: SHIP
[14:55:42] Using gulpfile C:\s7sgit\IBSA\spfx\extensions\ibsa-spfx-extensions\gulpfile.js
[14:55:42] Starting gulp
[14:55:42] Starting 'package-solution'...
[14:55:42] Starting subtask 'configure-sp-build-rig'...
[14:55:42] Finished subtask 'configure-sp-build-rig' after 5.67 ms
[14:55:42] Starting subtask 'package-solution'...
[14:55:42] [package-solution] Found manifest: C:\s7sgit\IBSA\spfx\extensions\ibsa-spfx-extensions\temp\deploy\90fa8f0c-3a3f-4a42-adc4-f86985a7a572.json
[14:55:42] [package-solution] Found client-side build resource: ibsa-app-insights-application-customizer_5c1a7f415ba2be16ecf4cb1b7cbccd1f.js
[14:55:42] Verifying configuration...
[14:55:42] Done!
[14:55:42]
[14:55:42] Normalizing solution information...
[14:55:42] Attempting creating component definitions for {1} manifests
[14:55:42] Created component definitions for {1} manifests
[14:55:42] feature.componentIds not set! Adding all [1] components to feature { Application Extension - Deployment of custom action. }.
[14:55:42] Done!
[14:55:42]
[14:55:42] Reading custom Feature XML...
[14:55:42] Done!
[14:55:42]
[14:55:42] Validating App Package...
[14:55:42] Done!
[14:55:42]
[14:55:42] Reading resources...
[14:55:42] Done!
[14:55:42]
[14:55:42] Reading Sharepoint Assets & Creating XML...
[14:55:42] Error - 'package-solution' sub task errored after 51 ms
Could not find Element Manifest: sharepoint\assets/elements.xml
[14:55:42] 'package-solution' errored after 60 ms
[14:55:42]
[14:55:42] ==================[ Finished ]==================
Error - 'package-solution' sub task errored after 51 ms
Could not find Element Manifest: sharepoint/assets/elements.xml
[14:55:43] Project ibsa-spfx-extensions version:0.0.1
[14:55:43] Build tools version:3.9.7
[14:55:43] Node version:v8.15.1
[14:55:43] Total duration:5.27 s
[14:55:43] Task errors:1
The build failed because a task wrote output to stderr.
Exiting with exit code: 1
PS C:\s7sgit\IBSA\spfx\extensions\ibsa-spfx-extensions>

@patrickabel I am running into a similar issue at the moment.  Did you end up resolving yours?


Buffer overflow in event history data structure

Fix applied. Need to confirm there's no more issues with event logs.

Some events being missed. Should simplify event-history, implement push/pop, remove EventHistoryRecord struct.

Replaced with new event buffer in revision 7


chore(deps) bump lua-resty-openssl from 0.7.2 to 0.7.3

Bump luaresty-openssl to 0.7.3
Summary
[0.7.3] - 2021-06-29
fix

pkey: only pass in passphrase/passphrase_cb to PEM_* functions 15e512c
pkey: avoid callbacks overflow when setting passphrase_cb b178224

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@gszr Is it too late to include this in 2.5? It brings a callback overflow fix that some customers hit.

Thanks for pinging @aboudreault. We will get it in.

Awesome. Thanks!

This is included in the 2.5.x release branch. Thanks @aboudreault!


Use the monaco editor in the playground and experiments

fixes #3
@bobmcwhirter Texmate grammar is not supported in the js-embedded version of monaco

@ctron didja stumble over some way to textmate with monaco?

@bobmcwhirter I need to look into this https://github.com/bolinfest/monaco-tm


expose jsdoc factory

Fixes #29341

⬆

🙋🏻♂

@DanielRosenwasser @RyanCavanaugh @rbuckton Please take a look at this change as the issue is not marked as help wanted and is suggestion so not sure if we agreed/discussed if this is right approach.

@sandersn  any update?

Any update？@DanielRosenwasser @RyanCavanaugh @rbuckton

Could we push this down? it's useful for the code generator.

Nope, please feel free to this.

Squash those comments please if someone going to merge.

@typescript-bot pack this.

up plz :XD

Unfortunately there is some overlap between this PR and https://github.com/microsoft/TypeScript/pull/35282 as I also have all of these methods on the new NodeFactory API and I'm deprecating any factory-like methods exposed directly on the ts namespace.


Create a style guide for threats

A Wiki page within the repo would make sense I think.

Can, not may
Focus on a single threat
Mitigations are not 1:1 to threats (some mitigations will address multiple threats, some threats will require multiple mitigations to deal with even a first "level" of attack.)

This information will be transferred over to the BDD styleguide, as part of a threats section.

See https://github.com/owasp-cloud-security/owasp-cloud-security/wiki/BDD-style-guide


Missing click on group action in multiselect.

Hello, is it possible to catch group header (optgroup) action ? Or is possible to click on group header and select/unselect all oprions in that group ?

It might be possible. I'm glad to take pull requests but I won't have any free time to do this myself. Also, I've found that http://www.ember-power-select.com/ has a bootstrap theme and works about 100 times better. I think I might deprecate this addon in favor of that one in the future.

Hi there. I know power select, and to tell truth its UI is very bad, id closes on every pick so you have open it again and again, default pick graphic is only grayed background(no checkboxes) , in page examples did not found one with "4 of 10 picked", and of course does not have click action on group. I browsed all select plugins that were in repo, your was nearest to my needs 👍

Hmm. Well PS has an option to keep it open. And I mention it is because it is flexible and completely customizable. If I were to to do anything to this addon I would completely rewrite it using PS. Sounds like what you need is a better theme then the default.
Again I can not see myself having the time in the near future. But if you willing to wait I might get to it. That said the source is freely editable and I would likely be happy to merge any Pull Requests you come up with.


fix: update OpenFeature core version to 1.5.0

This PR

bumps OpenFeature core version to match the current release

Notes
This should have been automatically by the CI but it didn't work for some reason. I'll look into why after the issue is resolved.
https://github.com/open-feature/js-sdk/commit/fe3ad8eeb9219ff08ba287cab228016da0b88e88#diff-e35631c960979816b4b2bda7950788e968930fcaf2cf39b482ff23117cd13888R50

The script to bump the peer version is very inconsistent but I'm not sure why. The web SDK fairly constantly has the dev dependency version bumped but not the peer version. Running the script again properly bumps the peer. If I update the root package.json to update web before server, the server peer version isn't bumped. It must be some very odd race condition. Any ideas @toddbaert @lukas-reining?

We may want to loosen the peer dependency requirements if possible. It's a bit painful to run both the server and web SDK in a single project due to constant version mismatches.

We may want to loosen the peer dependency requirements if possible. It's a bit painful to run both the server and web SDK in a single project due to constant version mismatches.

It's not possible without introducing significant risk.


Error with parsed json returned by gists

octo.gists(gist_id).fetch() returns incorrectly parsed json for data.files:
{
raw:
      { [Function]
        url: 'https://gist.githubusercontent.com/..../file.txt' },
}

This should be raw_url but it looks like somehow it is getting parsed. read() returns the correct unparsed json string.

Here's a failing test:
https://github.com/gmaclennan/octokat.js/blob/gist-raw_url-test/test/ruby-specs/gists.spec.coffee#L112
Sorry I don't really know chai, but raw_url should be a url, but it is undefined.

Thanks! You should be able to use raw.url instead of raw_url. This conversion is a result of adding support for GitHub's Hypermedia (details in the Repo Readme).
There should probably be an option for turning off the JSON conversion in future versions of this client.

Aha! I had missed that part of the readme. It makes sense now.


Unicode characters are incorrectly highlighted

Describe the bug
MeiliSearch seems to fall short of highlighting phrases containing multi-byte unicode characters such as "Hammarskjöld":

(Note that the last character is not highlighted.)
To Reproduce
Steps to reproduce the behavior:

Spin up a MeiliSearch instance.
Add the following dataset:

[
  {
    "id": 1,
    "name": "Hjalmar Hammarskjöld"
  },
  {
    "id": 2,
    "name": "Per Albin Hansson"
  },
  {
    "id": 3,
    "name": "Östen Undén"
  },
  {
    "id": 4,
    "name": "Tage Erlander"
  }
]

Try searching for Hammarskjöld or Undén.

Expected behavior
The whole word should be highlighted (as per the search query).
Screenshots

MeiliSearch version:
v0.24.0
Additional context
I was able to reproduce this issue on my Windows 10 amd64 machine but originally observed it on my Linux boxes.

Hello @ThePicoNerd thanks for the issue
you issue is a duplication of #1460 so I close it! Thanks for your feedback, we will fix this problem at the beginning of 2022


Simple Lightmap editor

@wootguy

Awesome!
I tried it out on de_dust and it works well on an 8x8 lightmap near T spawn. For most other lightmaps though it's pretty broken. The lightmap gets partially filled with random data which changes when I click Reload, and when I draw with a red color I get blue instead, and sometimes other colors.

It's ok if you don't want to fix that, but please add a "WIP" text somewhere explaining these bugs (like in the face editor).

@wootguy i see IMGUI bad works with images non two multiple ?

@wootguy okay I added WIP text. + some fixes for future

@wootguy issue at imgui github https://github.com/ocornut/imgui/issues/3829

@wootguy I can enable editing lightmap for all 4 styles, but i don't know about styles. I don't see changes in game if edit other styles.
You can simple uncomment here line to enable editing for all 4 styles : https://github.com/wootguy/bspguy/blob/d4a0061478955cb6a997c2f04eadf43bbbbad8b0/src/editor/Gui.cpp#L3128

@wootguy I can enable editing lightmap for all 4 styles, but i don't know about styles. I don't see changes in game if edit other styles.

The other styles are for toggled lights. I don't think there are many of those in CS. It would be hard to edit those now since you can't manually toggle lights on/off in the editor.

@wootguy I can enable editing lightmap for all 4 styles, but i don't know about styles. I don't see changes in game if edit other styles.

The other styles are for toggled lights. I don't think there are many of those in CS. It would be hard to edit those now since you can't manually toggle lights on/off in the editor.

You know style names ? I can add it to lightmap editor)

Lights can have styles with these names:
https://twhl.info/wiki/page/light
not sure that's what you meant though.

@wootguy you missing glPixelStorei(GL_UNPACK_ALIGNMENT, 1); in texture code for RGB format!

Good find! Weird that it didn't show artifacts until now.

@wootguy all fixed and added lightmap edit for all styles))
But I found new problem ) Sometime crashes when do reloadLightmaps.

@wootguy now all works :)

@wootguy may be need add pixel alignment 1 byte for any texture format ?

That fixed all the problems I saw earlier. Some comments on the window:

The labels don't really make sense. All lightmaps could be considered "Light enabled". Maybe go with "Light 0", "Light 1", "Light 2", "Light 3".
The lightmap size will be the same for all layers, so no need to show the size for all of them.
would be nice to be able to resize the window to show the color picker without scrolling.

may be need add pixel alignment 1 byte for any texture format ?

it's only needed for RGB textures. The default value of 4 is faster for RGBA.

@wootguy now all fixed ?))
Added turn off light in lightmap editor, and return back texture aligment for non RGB.

All checked and should work now!

Nice that you you can toggle light styles now. I've got ideas for improvement, but it's working well enough to merge.


Add semantic-release badge?

Like so:
[![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)

Link to semantic-release/semantic-release or voorhoede/vh-semantic-release-cli?

Closed by 1da5d7e


Single node server only? ( Router )

Hello,
I was wondering if this solution is a single server solution... I could not find anything talking about how to run a cluster.
Thanks!
-sean

Yes, it's a single server solution and there is not something like integrated cluster support.
There is also no standard for WAMP clustering, but afaik crossbar implements (or wants to implement) some kind of clustering functionality.
I'm also not sure whether WAMP is a really suitable for horizontal scaling in general, especially how consistency and partition tolerance in a cluster could be implemented. The protocol is quite stateful (it is required to store all kind of function providers and event publishers/subscribers and synchronize them also between multiple nodes in the cluster).


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.395

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.395


We must never ask for a password interactively

Signed-off-by: David Gageot<EMAIL_ADDRESS>

LGTM, I'd like to support passphrase encoded SSH keys though :(