Safer, more consistent uninitialized values

Hi
We are trying to use UAVCAN (libcanard) in our project. We found some inconsistency with uavcan.equipment.safety message - most of other messages uses 0 for nominal state and all bits set to indicate error (uavcan.protocol.NodeStatus.health - 0b00 for HEALTH_OK, 0b11 for HEALTH_CRITICAL, etc.). The same is valid for undefined values (maximum value for unsigned integer, NaN for float (in both cases all bits set to 1)). For uavcan.equipment.safety message this approach results in FULLY_ARMED as default value.
I propose:
#
# This message represents the system arming status.
# Some nodes may refuse to operate unless the system is fully armed.
#

uint8 STATUS_DISARMED           = 0
uint8 STATUS_FULLY_ARMED        = 254
uint8 STATUS_MALFUNCTION = 255 # or STATUS_CRASHED

uint8 status

Or to flip values to 0 = FULLY_ARMED and 255 = DISARMED
We are trying to initialize all our UAVCAN buffers and structs with 0xFF to make it more "errorproof" by setting it to safe, detectable, bug indicating default value (e.g. 127%).

Thanks, @KNiewiadomski-uAvionics!
I am reluctant to introduce a breaking change just for the sake of a minor security improvement. Perhaps you could choose a different memory initialization pattern or apply some other practices of defensive programming?
The fact that other values use all-set bits to indicate errors was not entirely intentional.


Move LLM library extraction to stable location

This refines where we extract the LLM libraries to by adding a new OLLAMA_HOME env var, that defaults to ~/.ollama
The logic was already idempotenent, so this should speed up startups after the first time a new release is deployed.  It also cleans up after itself.
I thought there was an issue tracking this but maybe it was just discussed in discord. (users seeing lots of orphaned ollamaXXX temp dirs)

I'm tinkering with ROCm payload patterns to try to make things more reliable, so this PR will likely need some re-work if that works out.


[KYUUBI # 651][FOLLOWUP][BRANCH-1.2] Bump Spark 3.1.2

Why are the changes needed?

Manually cherry-pick from #651
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #652 (767727a) into branch-1.2 (28c10b5) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             branch-1.2    #652   +/-   ##
============================================
  Coverage          7.21%   7.21%
  Complexity          132     132
============================================
  Files               120     120
  Lines              4672    4672
  Branches            563     563
============================================
  Hits                337     337
  Misses             4291    4291
  Partials             44      44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c10b5...767727a. Read the comment docs.

thanks, merging to branch-1.2


glitch.com guide

Glitch allows easy running of nodejs applications. Many hackathons ask for opensourced access to code and this may be a great thing to add to the documentation. https://glitch.com/about/features/

Developers/Hackathon Participants can just provide a link to their project's Github repo to meet the requirements for open source access.


[V2]Label physical net devices under /sys with sysfs_net attribute

Tracked-On: OAM-88335
Signed-off-by: Tong Bo<EMAIL_ADDRESS>

@ceiba1985 @fofeir. Please help approve. Thanks.


Enable mistral-small global agent by default

Description

This PR enabled mistral-small global agent by default.
Risk

Deploy Plan

As per slack, it’s not obvious we want it

Will keep the PR around until we figure this out 🙃.


Can't render more than 1 Scenario camera

Good day, again :)
I tried having multiple scenario cameras at the same time, but the render camera method hangs indefinitely if the scenario contains more than one camera.
Everything gets encoded correctly and it seems the request is sent correctly, but I never receive a response from it.

Hi, I found that the data attribute in the Camera object doesn't get updated at all for scenario cameras. Commit that should resolve this bug.
But I couldn't replicate your issue. If you encounter it again, please post the log output of the simulation, from BeamNGpy and state what BeamNG.tech and BeamNGpy version you are using. 🙏


Error on Laravel 5.4

Installed the package on Laravel 5.4 and got the following error below:
PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Foundation\Application::share()
Are you going to add a fix for the new framework?

This should be the correct change. In the middle of testing it now, but I am open for input.
public function register()
    {
        $this->mergeConfigFrom(__DIR__.'/config/config.php', 'slack');

        $this->app->singleton('Maknz\Slack\Client', function ($app) {
            return new Client(
                $app['config']->get('slack.endpoint'),
                [
                    'channel' => $app['config']->get('slack.channel'),
                    'username' => $app['config']->get('slack.username'),
                    'icon' => $app['config']->get('slack.icon'),
                    'link_names' => $app['config']->get('slack.link_names'),
                    'unfurl_links' => $app['config']->get('slack.unfurl_links'),
                    'unfurl_media' => $app['config']->get('slack.unfurl_media'),
                    'allow_markdown' => $app['config']->get('slack.allow_markdown'),
                    'markdown_in_attachments' => $app['config']->get('slack.markdown_in_attachments'),
                ],
                new Guzzle
            );
        });
    }

+1 on this.

See #11

I have 3 clients waiting on updates for this (awesome) package - their site reporting goes through Slack. Can't deploy updates until we have 5.4 compatibility.

Perfect thanks!

@connorjburton Using your fork for now chap, as it doesn't look like an update is coming soon. Thanks for putting that together!

I'll make sure not to delete it then!

I hate to be that guy, but +1

Also.... +1

+1

Guys, @maknz said on twitter that he doesn't have time to maintain this package anymore and will soon post a deprecation notice.
Link: https://twitter.com/maknz/status/833866298232754177

That's disappointing. I guess I will be refactoring my code to use https://laravel.com/docs/5.4/notifications#slack-prerequisites instead of this package.

Ah, thanks Alex. Bummer though.

It's sad, but we have to be thankful for @maknz and the time he spent on this. The code is still there, easily forkable. If someone feels like it, is so easy to take it over (we even have  @maknz 's ok) and ensure this lives on. In the end, if he doesn't have time to maintain it anymore, so be it, we shouldn't be mad at him.
@denaje I too went in that direction. It was a great opportunity to move towards official framework code. I had to dig in the source code to figure out how to post attachments that are full with (what used to be short-false in this lib) but in the end I got everything up and running.

Any god, please help...

No compatibility for Laravel 5.4

Fixed-> https://github.com/ketosthegreat/slack-laravel

I think this repo is dead and should be transferred to organization or person who will maintain it. @maknz

@PixellUp Yup, I agree on it.

How about this one? We are working off a fork with your fix @ketosthegreat so thanks for that.
{"message":"Unresolvable dependency resolving [Parameter #0 [ <required> $endpoint ]] in class Maknz\\Slack\\Client","status_code":500}

Here is the fix for my issue above:
https://github.com/getmaple/slack-laravel/commit/2e9b7c0188728ecc32196259bccd6a8f1df88eca


feature: ability to call ion-refresh programmatically

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
There seems to be no API to programmatically start the loading of the refresher.
It would be awesome to use the refresher to also show the user that some content is reloading, e.g. if the app is resumed. Additionally it does not make sense to use another component (like the LoadingController) if the refresher is used on the page anyhow – if there are two different components that basically indicate the same thing (which is reloading content) it could possibly confuse the user.
Expected behavior:
Steps to reproduce:
Related code:
Other information:
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.4
OS: macOS Sierra
Node Version: v5.2.0
Xcode version: Xcode 8.2.1 Build version 8C1002

need ！

Hello everyone! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to driftyco/ionic-feature-requests#93

Well, the new feature request has been removed? ;)


add line break after the adjacent ANSI cell

Hi, all,
I have made a simple commit to fix #105

Thanks!
Can you please provide an example where this bug shows itself?
Also, I'm having a hard time understanding why your fix works and what's the difference to inserting a literal new line.
Can you please elaborate?

An example is available here. When converted to latex, it will be like this:
% This comment is needed to force a line break for adjacent ANSI cells
\begin{OriginalVerbatim}[commandchars=\\\{\}]
/var/matlab/ifog_analysis/get_tems_data.m
\end{OriginalVerbatim}\begin{itemize}
\item {}
Help information of get\_tems\_data.

\end{itemize}

When I use xelatex to compile this tex file, some errors occur:
! FancyVerb Error:
  Extraneous input `\begin {itemize}\end {}' between \end{OriginalVerbatim} and
 line end
.
\FV@Error ...ncyVerb Error:^^J\space \space #1^^J}

l.1188 \end{OriginalVerbatim}\begin{itemize}

! LaTeX Error: Lonely \item--perhaps a missing list environment.

See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...

l.1189 \item {
              }

Underfull \hbox (badness 10000) detected at line 1189
[][]

! LaTeX Error: \begin{document} ended by \end{itemize}.

See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...

l.1192 \end{itemize}

! Extra \endgroup.
<recently read> \endgroup

l.1192 \end{itemize}

Please ignore the line number, cause they are not correct.

@Harlan-pku Thanks! I can reproduce the problem.
However, your fix doesn't seem to work for me (on Linux).
Do you happen to use Windows?
Do you have another idea how to fix this?

Yes, I use Windows and the fix worked for me. And I think it's sphinx's bug instead of nbsphinx's bug. I wrote a rst file and a similar error occurred.
Source code:
hello
=====

some code

.. raw:: latex

	\begin{OriginalVerbatim}[commandchars=\\\\\\{\\}]
		hello too
	\end{OriginalVerbatim}

* item1
* item2

The LaTex output:

\chapter{hello}
\label{\detokenize{test:hello}}\label{\detokenize{test::doc}}\label{\detokenize{test:welcome-to-my-test-s-documentation}}
some code
\begin{OriginalVerbatim}[commandchars=\\\\\\{\\}]
        hello too
\end{OriginalVerbatim}\begin{itemize}
\item {}
item1

\item {}
item2

\end{itemize}

I have reported it to sphinx
https://github.com/sphinx-doc/sphinx/issues/3594

@mgeier the contributor of Sphinx @jfbu said this is not Sphinx's bug, and Sphinx always treat ..raw:: latex as inline text. So, I think we can add a \relax into the raw latex cell to fix this bug.

Thanks for resolving this!
At https://github.com/sphinx-doc/sphinx/issues/3594 there is now actually some discussion if the behavior of Sphinx should be changed ... anyway, with our \relax we should be safe, even if they decide to insert a newline for raw LaTeX directives.


Add PR checks workflow for pull requests

Pull Request Template
Title: Add GitHub Actions Workflow for PR Checks
Description
This pull request adds a GitHub Actions workflow that automates checks for pull requests (PRs). The workflow is triggered when a PR is opened, edited, or reopened. It performs the following tasks to ensure the quality of the pull request:

Checkout Code: Retrieves the latest version of the code from the repository.
Set Up Node.js Environment: Installs Node.js version 16 for running commands.
Install Dependencies: Runs npm install to install all necessary project dependencies.
Run Tests: Executes unit tests via npm test to ensure no functionality is broken.
Lint Code: Optionally checks code formatting and style via npm run lint.
Build Project: Builds the project to ensure that the build passes successfully.
Security Checks: Optionally performs security audits on dependencies via npm audit.
Static Code Analysis: (Optional) Runs static analysis tools (like ESLint) to detect potential issues.
Post Notifications: Provides success or failure notifications based on the result of the checks.

Related Issue
Fixes #15
Changes Made

Added pr-check.yml under .github/workflows directory.
Configured the workflow to run on PRs when they are opened, edited, or reopened.
Set up Node.js environment, dependency installation, linting, testing, and build steps.
Optional security checks and static code analysis included in the workflow.

Checklist

[x] I have tested my code and it works as expected.
[ ] I have added/updated documentation where necessary.
[x] I have included tests for new features.
[x] I have followed the project's coding standards.

Screenshots (if applicable)

Reviewers
@thakuratul2

@thakuratul2 Sir could you review it

@Rizvi-Faiz oky i will review it and meanwhile find new issue

@thakuratul2 please add the levels in this pr and the gssoc-ext and hactoberfest
and also that you assigned me cause if you dont add they will not count towards my points
can you please add them

@thakuratul2  @saurabhbakolia  can you please add the labels here the issue #15

@saurabhbakolia SIRR CAN YOU PLEASE ADD THE LABELS TO THIS PR AND ALSO ASSIGN THIS PR TO ME AND THIS ISSUE IS LEVEL 3
SO PLEASE ADD THE LEVEL 3 LABEL AS I FIXED ISSUE NUMBER #15 .

CAN YOU PLEASE DO IT.


[DONT MERGE THIS PR] Call "which patch"

TODO

shell seems to be prohibited on the latest OSX. Try run (https://docs.raku.org/routine/run)


Add "Select All" to SelectControl and allow free form group by expressions

Changes to SelectControl: Add a "Select All" feature such that you can easily show all the columns in a Table non-group-by select box
Allow adding custom expressions to the group by select box such that we can now group by any sql expression and not just columns (no need to add them as "calculated columns first")
Add ordering of options in the FilterBox

This LGTM. As discussed eventually we'll want a consistent popover with the MetricsControl that exposes a way to validate the expression.

I don't know the details yet, but I was looking for the source of this bug and bisected until I got here and identified this as the source of the issue.
The problem is that the clear x on some Selects doesn't clear anymore as it used to. We need to fix this quickly.

Hi Max, sorry about that ! Can you please point me to which bug and what
selects have this issue. Thanks!
On Wed, Apr 3, 2019 at 12:06 AM Maxime Beauchemin<EMAIL_ADDRESS>wrote:

I don't know the details yet, but I was looking for the source of this bug
and bisected until I got here and identified this as the source of the
issue.
The problem is that the clear x on some Selects doesn't clear anymore as
it used to. We need to fix this quickly.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/pull/6722#issuecomment-479366738,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATnI_9Q9KRGApc0O9RVIZ6eEcmdOjXtDks5vdFMPgaJpZM4aHRYE
.

@agrawaldevesh the bug is linked above your comment ^^^

No pb, I'm fixing this one on


[Feature Request] Tag original torrent with “cross-seed”

Hi there, one challenge when evaluating torrents that have been cross-seeded in qBittorrent is that it’s not easy to identify the original torrent which was cross-seeded.
Is it possible to include in the processing pipeline the tagging of the original torrent with “cross-seed” tag as well? Then filtering by tag “cross-seed” in qBT will show both the cross-seed torrents and the original torrent at the same time.

qbitmanage has the capability to add tags to torrents for certain reasons (eg. tracker name, lacking Hardlinks, unregistered or error), but I haven't seen any functionality that would allow it to check the names of torrents (or info hash?) for duplicates and then tag them.
If cross-seed is already applying tags in the processing pipeline then it is probably a simpler overall handling of the problem than relying on a secondary application to tag the torrent that originated the pipeline.

people are using tags to apply share limits as well.
This can break already defined rules.

I'm curious if this would work/be acceptable workaround...
Once v6 is released, all torrents AND data will be linked if linking is possible, therefore - if you enabled it -  you could always check the save path, and if it's not within linkDir then it's the original.
I know this isn't "automated" - but given a little scripting a python script could probably handle this using the qbittorrent-api module.

That would probably make things easier, certainly, but not as clean from a user perspective as a toggleable option.  This is a feature request, something I thought might be a nice improvement.  If it's not feasible to do this within the project, or it's not popular with other users, it's not a big deal by any means.

I wasn't trying to imply your request was denied, merely giving you something that might work for you for the time being.
To be honest, I've been a little occupied with preparations for v6, so this hasn't been on my radar much. It just occurred to me that with the different behavior, there might be an interim solution (assuming this is something we decide to do). There honestly hasn't been any real discussion around implementing this or not.

I'd also love to see a feature like this. I use qbitmanage to (among other things) remove torrents that have met share limits. However, I want it to never remove cross seed torrents. The logic I want to achieve is something like "If a torrent is not being cross seeded, apply [default rule set I've created]. If it is being cross seeded, never automatically remove the original or any cross seeds referring to the original's data." This would be easy to do with qbitmanage if the original torrent could somehow be tagged by cross-seed when a cross-seed referring to it is snatched.

In v6 with linking enabled, this would readily be apparent based on the save path of the torrent.
Otherwise without linking, assume that when a tag does not exist with either 'cross-seed' or with 'cross-seed' in it, it is the original.
I think given that qbitmanage can handle tasks like this if it doesn't already, that would be where I would look to get this sort of thing added.
You could also simply base this on the time it was added to the client being the earliest as a fallback, but that would be less accurate due to naming variations.


uib-dropdown not working

i used uib dropdown but its not working properly the problem is its opening the li option without opening the dropdown selects the first option
here is my code

   Save View

  Edit

  Delete

please help me

@raman15071991, please be respectful of our time and processes by adhering to the issue template.  As we are all volunteers, we simply do not have the time to chase every incomplete or poorly-written issue entered by users.  As such, I apologize, but I am going to close this until you comply.  Thanks.

ok i will write it in a proper manner , I apologize for that


Reporting changed on US website

Amazon changed the reporting on the US website on March 22nd so Olivaw doesn't work there anymore.

@eansearch Did you found a solution ?

No solution, yet. The Olivaw code needs to be updated to the new US website.

Now Amazon also changed the reporting on all other websites, so Olivaw is useless until we get this fixed.

Please feel free to submit a pull request with a fix.  Due to the captcha and other anti-bot techniques Amazon has implemented, we have moved on from any automated report collection, and I will not be updating Olivaw anymore.  It is clear that Amazon does not want people to access their accounts in this way.  Unfortunate!

Hi @eansearch did you find a solution? I also ran into the same problem. Using stuff at phantombuster.com I managed to solve the captcha but then Amazon requests a code sent by email...

@nicolasdaudin I didn't find any solution. Sorry.

No problem ;-)


Raffe converted to services, ZMQ receiver working

rearrange code, convert to services, ZMQ receiver working
Changed all components to be services (using tjstebbing/conductor)
Added config for ZMQ
Detect missing config (silent failure otherwise)
Changed to use updated dogeorg/go-libdogecoin bindings

Good point about types - looks like it contains the public interface to 'broker' module, which belongs out in the root package per our discussions. I'll clean it up in the next PR.


Fix not opening on iOS with nested modal views

The earlier fix in c3cda7fa3c07ef316f05c2aba6b5ce0f5ce532ae did not
handle nested modal views. It only considered the first "level" along
the stack.

Would love to see this merged. Tested on iOS, works flawlessly.


Add method to update all the tasks at once

With this PR I add two new methods; the first one updates all the orientation and gravity task at once by passing an unordered map with the number of nodes and the new struct 'nodeStruct' containing the orientation and angular velocity data of the nodes. The second one calibrates all the nodes by passing the already described unordered map.

Closing this PR and deleting the branch since there are some problems with the commits.


Split /projects/{projectName} API into two smaller APIs

In ProjectServiceV1.java:
    @Get("/projects/{projectName}")
    @RequiresRole(roles = { ProjectRole.OWNER, ProjectRole.MEMBER })
    public CompletableFuture<ProjectMetadata> getProjectMetadata(
            @Param("projectName") String projectName,
            @Param("checkPermissionOnly") Optional<Boolean> isCheckPermissionOnly) { ... }

getProjectMetadata() could be split into two smaller API:

the one that provides basic information only, such as:

the list of repositories and their creation/removal timestamp and head revision.

the one that provides permission information, e.g. /projects/{projectName}/permissions

The reason why I'm asking for this is because it seems to be an overkill to fetch the complete permission information when a user calls CentralDogma.listRepositories() in the client library. Also, the current API does not have headRevision property of each repository, which is a requirement for the Java API. (See RepositoryInfo.java.)

Never mind. I realized that there's /projects/{projectName}/repos which provides the basic information only already.


New version: NordSecurity.NordVPN version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #4015.
Logs
Updated: <IP_ADDRESS> → <IP_ADDRESS>
Submitting WinGet manifests

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,

This PR's version number <IP_ADDRESS> has 4 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 7.15, which has 2 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 876)


The number of image tokens is 2 while the number of image given to the model is 1.

Fine-tune llava-interleave-qwen-0.5b, do I have to use the multi_images.json format? Can't use celeba_image_train.json data format?

Previously there was a bug, and it has been fixed by https://github.com/zjysteven/lmms-finetune/commit/5db747c86bc899e2664af3f88343a0cbf31c0ae1. Could you pull the latest code and try again?

Previously there was a bug, and it has been fixed by 5db747c. Could you pull the latest code and try again?

I finally got what I need to report for the group meeting tomorrow, thank you a lot!!!!!!!!! LOVE YOU!!!!!!!


Add feature review

🛠 Fixes Issue

👨💻 Changes proposed(required)

✔ Check List (Check all the applicable boxes)(required)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
- Add some logic to the review to display a message when review are loading
- Make the section into the .phoneType main element display flex
- Align the h2 element inside the review section
- Make the review section responsive
📷 Screenshots

thanks for this but you filled PR wrong, read the header for clues

hi dunsin how are you? I don't understand well what i should do i'm new to open source on github and this is my first contribution can you help me to figure out what i'm doing wrong?

Check thus out
https://github.com/Dun-sin/smartsearch/pull/20

thank you it's more clear now


Move the two fx android declaration at the end

Coverage remained the same at 25.497% when pulling 81dd80af5a21183d3ba2c409bce9f106bdad393c on sylvestre-patch-1 into 6dbd6ab7e69d79b3418d3669da08abe7a965b2a0 on master.


iasql_* functions except iasql_upgrade should error on unsupported versions

This will entail reading one record out of iasql_module, parse the version number, check if it's less than the oldestVersion config variable and throw an error in all of the src/services/iasql.ts functions except upgrade.


onbeforeunload does not work on iphone

OS : Ios (Iphone)
Browser : chrome last version

I have a page with this body :

 [... all the content]

I am using this code to show / hide a spinner
function unLoader(e) {
    $(".site-content").hide();
    $(".loading").show();
    }

   $(window).on('load', function() {
         $(".loading").hide();
         $(".site-content").show();
          window.onbeforeunload = unLoader;
     });

The problem is that the spinner works in desktop both PC and mac, on safari, firefox, chrome etc...
But it does not work on my Iphone.
On the other side, i am using the spinner for calls in ajax :
var $loading = $('.loading').hide();
$(document)
    .ajaxStart(function () {
        $loading.show();
    })
    .ajaxStop(function () {
        $loading.hide();
    });

But this time the spinner works in mobile device (iphone) !
How can I make the spinner work for the mobile devices in all my pages (using the code shown first) ?
I know the problem is from onbeforeunload event
Thanks in advance.

Unfortunately this is outside of Bootstrap. Try asking on StackOverflow.

I have already asked the question and no answer ...

But you say it yourself, it happens with onbeforeunload.
Otherwise, provide a Codepen for us to test.


Updating examples for 0.5.0

Trying to continue to update docs based on the current docs.

Travis build is failing due to unrelated tests.

Should be fixed after #626, just make sure to merge those changes in with yours

@seemethere does it make sense to keep this open for a bit?

@Sniedes722 are you planning to add more to it?

@r0fls will throw in a few more over the next couple days.

Updated basic examples to be in-line with the docs. Also added a detailed example, a port of Plotly's Flask Example to Sanic, for browser-based graphs using pandas, numpy, and some Sanic extensions. I'll open a new request whenever I have time to add more.

@seemethere @r0fls
Would you please check this pull request?
I think most of the changes are unnecessary.

@38elements it seems like the only qualm you have is that I used responses exactly like the docs list them:
import response

@app.route("/")
async def index(request):
    return response.response_type()

@Sniedes722 @38elements I personally often use them that way (from sanic import response). However if we want to standardize the usage pattern (in either direction) I'm ok with that. Beyond that, I can see @38elements's point that adding examples that don't exhibit sanic functionality aren't necessary. I agree the plotly example might make more sense as its own extension or gist, in order to keep the examples focusing on sanic features.

I think changing text() to response.text() is needless.
This change cause losting consistency.
I thought that implicit standards for  adding examples existed.
I thought that the example is one of the following.

Example of how to use Sanic

Example of how to use Sanic extensions

Example of how to use Sanic and asynchronous library

@38elements yes I think that is a fair assumption. The examples obviously aren't part of the core, so the approval is less strict in that area. However I understand your concern.


Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions

Follow https://github.com/opensearch-project/.github/issues/125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.
Close this issue when:

MAINTAINERS.md has the correct list of project maintainers.
CODEOWNERS exists and has the correct list of aliases.
Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

The MAINTAINERS and CODEOWNERS lists look good to me.
@VachaShah would you mind taking a look at the permissions? Thank you!

@boktorbb and @mihirsoni are not showing up as maintainers on the repo permissions, nor as members of the opensearch project organization, and therefore adding them will be a few steps. It might make sense to confirm that they want to remain as maintainers before going through that process.

@boktorbb and @mihirsoni are not showing up as maintainers on the repo permissions, nor as members of the opensearch project organization, and therefore adding them will be a few steps. It might make sense to confirm that they want to remain as maintainers before going through that process.

I think they can go into emeritus per our guidelines. And they can re-ask for permissions in the future.

I agree with @kavilla's suggestion. It looks like neither of them have commits in the repo.

Verified, thanks.


Implementation of Carlini&Wagner's L0 optimized attack

Description
This pull request merges #844 and add final style check updates.
Thank you very much to @mamerzouk for implementing CarliniL0Method!
Fixes #443
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[x] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Codecov Report

Merging #1109 (b1d1331) into dev_1.7.0 (a2f1af0) will decrease coverage by 27.11%.
The diff coverage is 3.55%.

@@              Coverage Diff               @@
##           dev_1.7.0    #1109       +/-   ##
==============================================
- Coverage      64.45%   37.34%   -27.12%
==============================================
  Files            221      221
  Lines          19295    19491      +196
  Branches        3533     3560       +27
==============================================
- Hits           12437     7278     -5159
- Misses          5438    11347     +5909
+ Partials        1420      866      -554

Impacted Files
Coverage Δ

art/attacks/evasion/carlini.py
6.46% <3.06%> (-82.81%)
:arrow_down:

art/attacks/evasion/__init__.py
100.00% <100.00%> (ø)

...rt/defences/detector/poison/clustering_analyzer.py
8.22% <0.00%> (-86.71%)
:arrow_down:

...ces/detector/evasion/subsetscanning/scanningops.py
11.59% <0.00%> (-85.51%)
:arrow_down:

...ient_descent/projected_gradient_descent_pytorch.py
16.27% <0.00%> (-76.75%)
:arrow_down:

...escent/projected_gradient_descent_tensorflow_v2.py
17.60% <0.00%> (-75.20%)
:arrow_down:

art/metrics/verification_decisions_trees.py
13.68% <0.00%> (-73.16%)
:arrow_down:

art/attacks/evasion/decision_tree_attack.py
22.66% <0.00%> (-69.34%)
:arrow_down:

art/attacks/evasion/adversarial_patch/utils.py
11.53% <0.00%> (-69.24%)
:arrow_down:

... and 93 more


rmsnorm not trainable

Hi, it seems like from the beginning of this project rmsnorm is not trainable, which is not usual in other implementations I guess. How does it effect the training speed and the final loss?
What I mean by trainable is:
class RMSNorm(nn.Module):
    def __init__(self, n_embd, eps=1e-6):
        super().__init__()
        self.eps = eps
        self.weight = nn.Parameter(torch.ones(n_embd))# trainable, requires_grad=True by default

    def forward(self, x):
        x = self.weight * x * torch.rsqrt(x.pow(2).mean(dim=-1, keepdim=True) + self.eps)
        return x

x = torch.rand(1, 196, 768)# batch size, sequence length, embedding dimensionality (n_embd)
rmsnorm = RMSNorm(n_embd=768)
y = rmsnorm(x)
assert x.shape == y.shape

oops, just saw this line in readme:

Removed all affine scale and bias parameters from the architecture, and switched to RMSNorm (actually this causes a slight slowdown, and I just did it to reduce code complexity)

Sorry about this, maybe change the order of the sentence a bit would be easier to understand: "Switched to RMSNorm (actually this causes a slight slowdown, and I just did it to reduce code complexity), and removed all affine scale and bias parameters from the architecture."


Remove sync/async optimisation, evaluate everything as promise

Coverage decreased (-5.6%) to 94.421% when pulling bc881fbe5e6f0b302962e2831ebbbbc5bc1e45c7 on async into 6eedab93fceec7c599b169db520e99e566473dc7 on master.


Make music still play during game window resize

[ Issue #137 ] Moved the logic of updating the audio stream to a separate thread

Please note that something's wrong with your commit history: there are a lot of unrelated commits in the PR.


Upgrade lexical-core to 0.8

Which issue does this PR close?

Closes #747
Rationale for this change
Upgrade to latest version, which has some performance improvements (usage of Eisel-Lemire algorithm being one important change)
See:
https://github.com/Alexhuszagh/rust-lexical/releases/tag/v0.8.0
What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #748 (1e9dae2) into master (3b56485) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   82.47%   82.47%
=======================================
  Files         168      168
  Lines       47715    47715
=======================================
  Hits        39353    39353
  Misses       8362     8362

Impacted Files
Coverage Δ

arrow/src/compute/kernels/boolean.rs
96.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b56485...1e9dae2. Read the comment docs.


vz: add support for nested virtualization

This PR adds support for nested virtualization for the VZ driver via the nestedVirtualization yaml config.
It is dependent on upstream PR https://github.com/Code-Hex/vz/pull/159 getting merged.
Nested virtualization is currently limited to m3 devices running macOS 15 or newer.

Testing Instructions
⚠ This only works on macOS 15 (currently beta) with VZ driver and on M3 devices.
For those willing to try this out, these are the steps.
1. Clone sources in same directory
Clone my fork of VZ and checkout enable-nested-virtualization branch.
git clone -b enable-nested-virtualization https://github.com/Code-Hex/vz

Clone my fork of Lima and checkout vz-nested-virtualization branch.
git clone -b vz-nested-virtualization github.com/lima-vm/lima

2. Modify Lima to use local copy of VZ
Edit go.mod in Lima and append the following snippet.
replace github.com/Code-Hex/vz/v3 => ../vz

3. Build Lima
From the root directory of Lima, perform a build.
PS: You might need to unlink Brew version if previously installed with Brew. brew unlink lima
make && sudo make install

4. Start Lima with nested virtualization enabled
Use VZ driver and enabled nested virtualization.
The lima.yaml config file should contain the following.
vmType: vz
nestedVirtualization: true

5. Validate nested virtualization in Lima VM
Enter the Lima VM with lima (or similar command) and validate the existence of /dev/kvm.
$ ls -lh /dev/kvm
crw-rw---- 1 user kvm 10, 232 Aug 29 09:06 /dev/kvm

If the VM is running Ubuntu, you can install cpu-checker package and run kvm-ok to further ascertain.
$ kvm-ok
INFO: /dev/kvm exists
KVM acceleration can be used

I was able to create a Lima VM with KVM support with your testing instructions.
$ limactl shell ubuntunested
WARN[0000] treating lima version "bc39aed.m" from "/Users/asauber/.lima/ubuntunested/lima-version" as very latest release
asauber@lima-ubuntunested:/Users/asauber$ kvm-ok
INFO: /dev/kvm exists
KVM acceleration can be used

Very cool. Thank you for working on this.

CI is failing https://github.com/lima-vm/lima/actions/runs/10903645853/job/30258186834?pr=2530
# github.com/lima-vm/lima/pkg/vz
Error: pkg/vz/vm_darwin.go:256:18: platformConfig.SetNestedVirtualizationEnabled undefined (type *"github.com/Code-Hex/vz/v3".GenericPlatformConfiguration has no field or method SetNestedVirtualizationEnabled)
make[1]: *** [_output/bin/limactl] Error 1

CI is failing https://github.com/lima-vm/lima/actions/runs/10903645853/job/30258186834?pr=2530

Yes, that is because the upstream PR is not yet merged and that is why I made it a draft PR.

https://github.com/Code-Hex/vz/pull/159 remains still unreviewed, maybe the repo should be forked?

Code-Hex/vz#159 remains still unreviewed, maybe the repo should be forked?

https://github.com/lima-vm/vz/pull/1

The failing test does not appear related to the code change and it appears to run Lima successfully https://github.com/lima-vm/lima/actions/runs/11231643603/job/31221517661?pr=2530#step:10:1133. 😕

CI is green on the master, but this PR seems failing 4 times.
Maybe the failure is caused by another recent change in vz?

CI is now green, let's merge it


Fix arc projectiles exploding prematurely

Fixes:#264
I'm not really a huge fan of this fix to be honest. It's not a catch-all. It might be more ideal to not have a capped segment count in the first place. Maybe a time limit instead? Anyway, the segment count was really low and those grubs can really yeet projectiles, so it was going insanely high but the segment count wasn't large enough and the projectile exploded early. The ArcPhysicsGadgetComponent defaulted to exploding the projectile regardless of its ExplodeAfter time.

We have two options here imo:

Calculate the minimum segments required and use that number
Fall back to a standard PhysicsGadgetComponent when the ArcPhysics segments reach 0

I wanted to increase the segment count either way. I won't approve this right away but we can continue the discussion in the issue or on Discord.

We have two options here imo:

Calculate the minimum segments required and use that number
Fall back to a standard PhysicsGadgetComponent when the ArcPhysics segments reach 0

I wanted to increase the segment count either way. I won't approve this right away but we can continue the discussion in the issue or on Discord.

Sounds good. I'll explore both these options and follow up on Discord if I run into any issues.


feat: Gateway Authentication using middleware

Previously we had a naively implementation for Gateway authentication. We were using ValidateRequestHeaderLayer::bearer, which required a password to be specified during the setup of the webserver. Therefore, in order to support changing the password via the set_configuration API, we needed to restart the webserver. This is not ideal because it leads to longer wait times, failed requests, and made our tests flaky https://github.com/fedimint/fedimint/actions/runs/8350129601/job/22855854147
These PR removes ValidateRequestHeaderLayer::bearer and introduces middleware functions that intercept the requests to the gateway before they are processed and validate them again the current password that is stored within the gateway. This way, when the password is updated, it is not required to restart the webserver and subsequent requests will not fail.

@okjodom Are you able to take a look? I think you're most familiar with this code.

@okjodom Are you able to take a look? I think you're most familiar with this code.

yes. it's in my review bucket for the day 🔖

This diff contains name suggestions and some DRY suggestions.

Can you post the comments to Github?


Fix problem in documentation in python generation code, deleting from a dictionary while iterating over it.

This is a very brute-force solution.  And there seem to be numerous other places where the same problem could come up, deleting from a container in a loop that iterates over it.

This is already fixed in #4541 but as usual no one has bothered to look at it.


Dispatcher stream error, tuner may have crashed.

Environment:

NNI version:2.0
NNI mode (local|remote|pai):local
Client OS: win10
Server OS (for remote mode only):
Python version: 3.7.8
PyTorch/TensorFlow version: torch 1.7
Is conda/virtualenv/venv used?: conda
Is running in Docker?: no

Log message:

nnimanager.log:
[2021-02-26 09:43:02] ERROR [ 'Dispatcher error: This socket has been ended by the other party' ]
[2021-02-26 09:43:02] ERROR [ 'Error: Dispatcher stream error, tuner may have crashed.\n    at EventEmitter.dispatcher.onError (d:\anaconda\envs\py_1.7\lib\site-packages\nni_node\core\nnimanager.js:533:32)\n    at EventEmitter.emit (events.js:198:13)\n    at Socket.IpcInterface.outgoingStream.on (d:\anaconda\envs\py_1.7\lib\site-packages\nni_node\core\ipcInterface.js:42:72)\n    at Socket.emit (events.js:198:13)\n    at Socket.writeAfterFIN [as write] (net.js:399:8)\n    at IpcInterface.sendCommand (d:\anaconda\envs\py_1.7\lib\site-packages\nni_node\core\ipcInterface.js:49:38)\n    at NNIManager.pingDispatcher (d:\anaconda\envs\py_1.7\lib\site-packages\nni_node\core\nnimanager.js:378:29)' ]
[2021-02-26 09:43:02] INFO [ 'Change NNIManager status from: RUNNING to: ERROR' ]
[2021-02-26 09:43:02] WARNING [ 'Commands jammed in buffer!' ]

dispatcher.log:
[2021-02-26 09:42:04] INFO (GP_Tuner_AutoML/Thread-1) Generate paramageters:
{'layers': 10, 'neurons': 20}
[2021-02-26 09:42:51] INFO (GP_Tuner_AutoML/Thread-1) Received trial result.
[2021-02-26 09:42:51] INFO (GP_Tuner_AutoML/Thread-1) value :-0.010340445765208602
[2021-02-26 09:42:51] INFO (GP_Tuner_AutoML/Thread-1) parameter : {'layers': 10, 'neurons': 20}
[2021-02-26 09:42:53] WARNING (medianstop_Assessor/Thread-2) trial_end: trial_job_id does not exist in running_history
[2021-02-26 09:42:53] ERROR (nni.runtime.msg_dispatcher_base/Thread-1) 'str' object has no attribute 'decode'
Traceback (most recent call last):
File "D:\anaconda\envs\py_1.7\lib\site-packages\nni\runtime\msg_dispatcher_base.py", line 88, in command_queue_worker
self.process_command(command, data)
File "D:\anaconda\envs\py_1.7\lib\site-packages\nni\runtime\msg_dispatcher_base.py", line 147, in process_command
command_handlerscommand
File "D:\anaconda\envs\py_1.7\lib\site-packages\nni\runtime\msg_dispatcher.py", line 101, in handle_request_trial_jobs
params_list = self.tuner.generate_multiple_parameters(ids, st_callback=self.send_trial_callback)
File "D:\anaconda\envs\py_1.7\lib\site-packages\nni\tuner.py", line 132, in generate_multiple_parameters
res = self.generate_parameters(parameter_id, **kwargs)
File "D:\anaconda\envs\py_1.7\lib\site-packages\nni\algorithms\hpo\gp_tuner\gp_tuner.py", line 123, in generate_parameters
self._gp.fit(self._space.params, self._space.target)
File "D:\anaconda\envs\py_1.7\lib\site-packages\sklearn\gaussian_process_gpr.py", line 249, in fit
bounds))
File "D:\anaconda\envs\py_1.7\lib\site-packages\sklearn\gaussian_process_gpr.py", line 504, in _constrained_optimization
_check_optimize_result("lbfgs", opt_res)
File "D:\anaconda\envs\py_1.7\lib\site-packages\sklearn\utils\optimize.py", line 243, in _check_optimize_result
).format(solver, result.status, result.message.decode("latin1"))
AttributeError: 'str' object has no attribute 'decode'
[2021-02-26 09:42:57] INFO (nni.runtime.msg_dispatcher_base/MainThread) Dispatcher exiting...
[2021-02-26 09:42:59] INFO (nni.runtime.msg_dispatcher_base/MainThread) Dispatcher terminiated

nnictl stdout and stderr:

The code worked a month ago. But today it did not. I want to do 100 trials. It will stop in  the middle and give me the erroe 'Dispatcher stream error, tuner may have crashed'.

I also meet the error,but just a few trails was run successfully for me .
ERROR [ 'Error: Dispatcher stream error, tuner may have crashed.\n    at EventEmitter.dispatcher.onError (/home/zhangshuo/anaconda3/lib/python3.6/site-packages/nni_node/core/nnimanager.js:533:32)\n    at EventEmitter.emit (events.js:198:13)\n    at Socket.IpcInterface.outgoingStream.on (/home/zhangshuo/anaconda3/lib/python3.6/site-packages/nni_node/core/ipcInterface.js:42:72)\n    at Socket.emit (events.js:198:13)\n    at Socket.writeAfterFIN [as write] (net.js:399:8)\n    at IpcInterface.sendCommand (/home/zhangshuo/anaconda3/lib/python3.6/site-packages/nni_node/core/ipcInterface.js:49:38)\n    at NNIManager.onTrialJobMetrics (/home/zhangshuo/anaconda3/lib/python3.6/site-packages/nni_node/core/nnimanager.js:550:29)' ]

I want to know what have caused it?
Was it the cause that I fix the code when the nni is running?

@drxmy Hi, could you show your sklearn and scipy version, try to update sklearn>=0.24.1 or downgrade scipy<=1.5.3 may solve this.
https://stackoverflow.com/questions/65682019/attributeerror-str-object-has-no-attribute-decode-in-fitting-logistic-regre
https://github.com/scikit-optimize/scikit-optimize/issues/981

@zs963048949 Hi, could you show more information, like dispatcher.log and nnimanager.log under ~/nni-experiments/EXPERIMENT_ID/log. Most NNI training services and tuners do not support modify user code during running, so if you need to fix the code, better to run a new experiment.

@J-shang My scipy is 1.6.1 and sklearn is 0.24.1. Thank you for replying! I will try to downgrade scipy.


Distinguish documents at ingestion

Changes in this PR:
Distinguish documents at ingestion
Dependent on https://github.com/nationalarchives/ds-caselaw-custom-api-client/pull/236 being merged and then a version 10.0.0 of the api client being released.
Trello card / Rollbar error (etc)
https://trello.com/c/T6x6GXmc/803-ensure-judgments-dont-display-press-summaries-erroneously

(assuming tests go green once the API client is updated)


📏 Standardize Error Keys

We're using a mix of dashes and underscores, which I find confusing. I've introduced some failures trying to get these right, so I'm making all string keys dasherized.

What would you say to making these constants in common/lib/dependabot/errors.rb?


Header styling

Describe the bug
Summary
The header styling differs a from the design in Figma in terms of elements displayed, font-sizes, and alignment of elements.
URL / Environment
https://bron.live
Steps to reproduce**

View the Figma design for the header
View the header on any page on bron.live
See the differences.

Expected behavior

Elements displayed are the same for design and implementation
Alignment of logo and tagline elements are to the left
Menu items are: Bronnen and Over ons (sources and about us) and are aligned to the right
Font families and sizes are the same as specified in design
Bottom border is implemented

Screenshots

Additional context
Figma header design: https://www.figma.com/file/Tcv7xuwikoVW0U8c0pqDDq/Graphics?type=design&node-id=303-85&mode=dev

Leuk die figma maar ik heb dus geen idee welke van de drie designs ik in dat ding moet hebben

The url under "Additional context" points directly to the components artboard in Figma. That artboard contains all the main components. The other artboards contain instances of those main components. For more info on components in Figma: https://help.figma.com/hc/en-us/articles/360038662654-Guide-to-components-in-Figma

figma://www.figma.com/file/Tcv7xuwikoVW0U8c0pqDDq/Graphics?type=design&node-id=303-85&mode=dev

Border bottom: should be #D9D9D9
.logo-container height property should be 42px. Now the bottom of the letter 'O' is cut off.


Upload to a release created in a different job

I'm setting up a CI environment for a C++ application on three different platforms - Linux, macOS and Windows. My idea is the following:

job A creates a release (with actions/create-release) once;
jobs B, C and D build the app each platform and then upload the three binaries as release assets (one asset per platform).

Is there a way to pass the upload_url variable from job A to the other three jobs? The example in the README file only shows how to do that across steps in the same job.

Here's what I did:
name: Release (checkers)

on:
  push:
    tags:
    - 'v*'

jobs:
  job1:
    name: Create Release
    runs-on: ubuntu-latest
    outputs:
      upload_url: ${{ steps.create_release.outputs.upload_url }}

    steps:
      - name: Create Release
        id: create_release
        uses: actions/create-release@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          tag_name: ${{ github.ref }}
          release_name: ${{ github.ref }}
          draft: true
          prerelease: false

  job2:
    name: Build
    needs: job1
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os:
          - windows-latest
          - ubuntu-latest
          - macOS-latest
    steps:
      - uses: actions/checkout@v2
      - name: make all
        run: |
          cd checkers
          mkdir build
          make all

      - name: Create tarball
        uses<EMAIL_ADDRESS>        run: |
          cd checkers/build
          tar -czvf ${{ matrix.os }}.tar.gz *

      - name: Upload assets
        id: upload-release-asset
        uses: actions/upload-release-asset@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          upload_url: ${{ needs.job1.outputs.upload_url }}
          asset_path: checkers/build/${{ matrix.os }}.tar.gz
          asset_name: ${{ matrix.os }}.tar.gz
          asset_content_type: application/gzip

You need to do it something like this...
Archive the release asset upload URL:
https://github.com/Optum/sourcehawk/blob/561fb11492b710db1acfafcf7ab625d47edebfcf/.github/workflows/release.yml#L96-L102
Download and expose the release asset upload URL in next job:
https://github.com/Optum/sourcehawk/blob/561fb11492b710db1acfafcf7ab625d47edebfcf/.github/workflows/release.yml#L184-L191
Use the upload URL:
https://github.com/Optum/sourcehawk/blob/main/.github/workflows/release.yml#L217

And here’s my version:
Configuration: https://github.com/courselore/courselore/blob/6e1311a852360475714614fa67b94cc4bf38bb1a/.github/workflows/main.yml
Example release: https://github.com/courselore/courselore/releases/tag/v0.0.5
It’s similar, but it fixes some small issues that I ran into, for example, the following didn’t work for me:
- name: Create tarball
  uses<EMAIL_ADDRESS>  run: |
    cd checkers/build
    tar -czvf ${{ matrix.os }}.tar.gz *

First, GitHub complained that a step can’t have both uses and run. But even if you separate it in two steps, tar -czvf ${{ matrix.os }}.tar.gz * didn’t work for me on Windows; it complained about file permissions.
In any case, thanks @infinitepr0 for getting me very close to the solution.

And here’s my version:
Configuration: https://github.com/courselore/courselore/blob/6e1311a852360475714614fa67b94cc4bf38bb1a/.github/workflows/main.yml
Example release: https://github.com/courselore/courselore/releases/tag/v0.0.5
It’s similar, but it fixes some small issues that I ran into, for example, the following didn’t work for me:
- name: Create tarball
  uses<EMAIL_ADDRESS>  run: |
    cd checkers/build
    tar -czvf ${{ matrix.os }}.tar.gz *

First, GitHub complained that a step can’t have both uses and run. But even if you separate it in two steps, tar -czvf ${{ matrix.os }}.tar.gz * didn’t work for me on Windows; it complained about file permissions.
In any case, thanks @infinitepr0 for getting me very close to the solution.


chore(code): switch to biome

no, biome phpstorm plugin was not highlighting errors

biome plugin for idea doesn't work as expected


tab completion always adds trailing slash

When using the tab completion feature, it appears that the console always adds in a trailing slash, not just with directories, which leads to e.g. python not being able to read a file.
Consider this:
 $ ls listfiles.py -la
-rwxrwxrwx 1 root root 1565 Jul  1 09:54 listfiles.py
 $ python listfiles.py/
python: can't open file 'listfiles.py/': [Errno 20] Not a directory
 $ python listfiles.py
usage: listfiles.py [-h] [--dir DIR] [-Q] [-B] [-X] path
listfiles.py: error: too few arguments

I have experienced that issue not just with python, but also with root, cat, and others. I have no running Linux machine available right now so I can't assert the bug better.
I am running on the Release Preview ring (14393.82), so it might already be fixed in the fast ring. However, I didn't find any issues posted here.
If you manually remove the slash it does obviously work, but it is of somewhat inconvenience.
Cheers

Interesting -- that doesn't reproduce for me.  Using tab-complete to select the name:
$ ls -l listfiles.py
-rwxrwxrwx 1 root root 14 Aug 21 11:30 listfiles.py
$ python listfiles.py
files
$

This machine is currently running 14393.10.

I saw that sometimes when following a symlink from VolFS to DrvFS. Perhaps something like that happened?

I saw that sometimes when following a symlink from VolFS to DrvFS. Perhaps something like that happened?

I just checked it from the $HOME dir and it looks like that's correct (checked both for root and the user). It also doesn't occur when going to the previously symlinked dir the normal way.
From that I assume this falls in line with #647 and #650 ? May be closed / referenced then.

Closing this as a duplicate of #647 and #650.


Access Violation with Code Completion

I'm trying to use the code completion features of this library.  Here's a simple example:
// input is the text of my C++ source file
public static void DoCodeCompletion(string input, int row, int column)
{
	List<Completion> completions = new List<Completion>();

	string fileName = Path.GetTempFileName();
	File.WriteAllText(fileName, input);

	CXIndex index = clang.createIndex(1, 0);
	CXUnsavedFile unsavedFile;
	CXTranslationUnit tu;
	string[] arr = { "-x", "c++" };
	CXErrorCode errorCode = clang.parseTranslationUnit2(index, fileName, arr, 2, out unsavedFile, 0, (uint)CXTranslationUnit_Flags.CXTranslationUnit_PrecompiledPreamble, out tu);
    // errorCode is CXError_Success

	IntPtr pResults = clang.codeCompleteAt(tu, fileName, (uint)row, (uint)column, out unsavedFile, 0, 0);
	CXCodeCompleteResults results = Marshal.PtrToStructure<CXCodeCompleteResults>(pResults);

    // Access violation here
	clang.disposeCodeCompleteResults(out results);
	clang.disposeTranslationUnit(tu);

	File.Delete(fileName);
}

struct Adder
{
	int add(int a, int b)
	{
		return a + b;
	}
};

void fn()
{

}

int main()
{
	Adder adder;
    adder.      <--  Initiating completion here

	return 0;
}

It results in an access violation at disposeCodeCompleteResults.
Please advise.
Thanks!

Thanks for reporting this, I can reproduce this. I have a debug build of Clang that I'll look into over the weekend.

Hello!
Any news on this issue?

Sorry this slipped my radar.
Can you add the following to your code:
[DllImport("libclang.dll", EntryPoint = "clang_disposeCodeCompleteResults", CallingConvention = CallingConvention.Cdecl)]
public static extern void disposeCodeCompleteResultsTryingOut(IntPtr Results);
Then pass in
IntPtr pResults = clang.codeCompleteAt(tu, fileName, (uint)row, (uint)column, out unsavedFile, 0, 0);

pResults.
I think that is the problem. If you can confirm, great, otherwise I will try it out.

Sorry, I had to move on to a C++/CLI implementation.  I don't have the setup for testing anymore.

I can confirm, this solves the problem.

Alright, next release that's coming out for Clang 3.7 will have this fixed.


[BUG]: Not fetching database name from connection string

What version of drizzle-orm are you using?
0.29.3
What version of drizzle-kit are you using?
0.20.14
Describe the Bug
For establishing a connection with pg database, the below function
export const connection = postgres(process.env.DB_URL!, {
  database: 'nexerson',
});

If i don't pass second param with database name it connects with default db that is in my case 'postgres'
Expected behavior
It should fetch database name from connection string
DB_URL=postgres://postgres:postgres@<IP_ADDRESS>:5432/test

In this case, database name should be test
Environment & setup
No response

This is a driver bug and not related to Drizzle. I assume you are using postgres.js, so I suggest this issue should be reported there


Prepare for v0.2.1 release

Bump the changelog for release.

Codecov Report

Merging #32 (c232916) into main (25d617f) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   85.67%   85.67%
=======================================
  Files          15       15
  Lines         705      705
=======================================
  Hits          604      604
  Misses        101      101

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Abort sl root call if output resembles a steam locomotive

Summary
Jest detects whether a repository is a sapling repo by calling the sl
binary, and getting the output. If sl (steam locomotive) is installed,
the output of sl root 1) takes forever to get and 2) is not the root,
but a moving image of a steam locomotive. This change monitors the
stdout stream, and aborts the sl call if the first character is an
escape character, which indicates that the terminal is being cleared to
make way for a train to come through.
See also: https://github.com/jestjs/jest/issues/14046
Test plan
This was tested manually. I don't think I have the time to figure out
automated testing for this, as it requires installing a binary, which
means mucking around in the CI code.
With the existing main branch, with sl on $PATH:
$ node ~/dev/jest/packages/jest/bin/jest.js --watch
Determining test suites to run...

  ● Test suite failed to run

thrown: [Error]

With the existing main branch, in a repo with sapling roots, with sapling on $PATH:
$ node ~/dev/jest/packages/jest/bin/jest.js --watch

<a bunch of output>

With the proposed changes, with sl on $PATH:
$ node ~/dev/jest/packages/jest/bin/jest.js --watch
No tests found related to files changed since last commit.

With the proposed changes, in a repo with sapling roots, with sapling on $PATH:
$ node ~/dev/jest/packages/jest/bin/jest.js --watch

<a bunch of output>

Added changelog entry.

Should we set some module scoped variable so we can reuse in findChangedFiles (and also skip the spawn)?

Do you mean like this @SimenB? Not sure what we'd be re-using in sl.findChangedFiles, since I don't think it gets called if we don't find any roots. This new change means we spawn at most 5 sl processes. I could move the logic into index.ts and delay calling sl.getRoot until we know what type of sl is installed, if that's what you mean?

Added changelog entry.

Should we set some module scoped variable so we can reuse in findChangedFiles (and also skip the spawn)?

Do you mean like this @SimenB?

That, yes 🙂

https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.4


tree-wide: rename WIRE_API_AUTHORIZATION_ENDPOINT to WIRE_AUTHORIZATION_ENDPOINT

The prefix suggests this is using the same domain, because it's hosted by the API, but in fact, the authorization endpoint is provided by the web app.
Remove the _API part in the env var to make this more clear.

PR Submission Checklist for internal contributors

The PR Title

[ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
[ ] contains a reference JIRA issue number like SQPIT-764
[ ] answers the question: If merged, this PR will: ... ³

The PR Description

[ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:

[ ] GitHub link to other pull request

Testing
Test Coverage (Optional)

[ ] I have added automated test to this contribution

How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

[ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

[ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


1422 redirect to root if timed out user attempts to signout

Context
If a user session has expired making current_user is nil then a user attempts to signout from DfE-Signin a server error is thrown because DfE-Signin requires the users id_token which is stored in the current_user object
Changes proposed in this pull request
Check for the presence of current_user and redirect to root as their session has already expired
Do we need to think about a more robust strategy for this i.e. persist the id_token on the user when the signin?
Guidance to review
Delete the session in your browser and hit signout

 SessionsController timeout error

Do we need to think about a more robust strategy for this i.e. persist the id_token on the user when the signin?

Why would we bother to do this? Just to guarantee that they're signed-out of DFE Sign-In? I'm not sure I see the value in this, offhand.

This approach looks Good Enough (:tm:) to me.


[BUG] [Tizen] Calling ChipDnssdResolve with the CHIP stack locked can cause deadlock

Reproduction steps
During our (SmartThings) testing on the Tizen platform we have been encountering an issue where the DNS-SD implementation may become deadlocked when attempting to resolve multiple devices at the same time. I have determined that this occurs because we call ChipDnssdResolve with the CHIP stack locked. Consider the following scenario with threads [1] and [2]:

[2] Is in the middle of handling a request for service resolution.
[1] Some function calling ChipDnssdResolve acquires the CHIP stack lock some arbitrary amount of time beforehand.
[2] The service is resolved and this thread acquires the NSD lock (ref)
[1] As a result of calling ChipDnssdResolve, this thread reaches dnssd_create_remote_service and attempts to acquire the NSD lock. It waits.
[2] The callback OnResolve in the Matter SDK attempts to acquire the CHIP stack lock. It also waits (here).

As a result, the mutually dependent NSD and CHIP stack locks become deadlocked.
If it helps, I've also modified the TestDnssd unit test and some build files on a branch in a fork to demonstrate this issue (just a rough patch using your existing work with containers, @arkq). You can find it at https://github.com/gharveymn/connectedhomeip/tree/tizen-deadlock. You can run the test by starting up the docker container and executing gen-cmd.sh and then ninja -C out/tizen-unit-check check-unit.
CC: @msandstedt @arkq @hyunuktak @chulspro
Bug prevalence
Whenever successfully resolving multiple devices concurrently
GitHub hash of the SDK that was being used
39573776dd08f0357691bbe569dc7686669bef6c
Platform
other
Platform Version(s)
No response
Anything else?
No response

OK, I'll look into it. Thanks for reporting!

Hey @arkq, thanks for the quick update! I'm just gonna let you know that I'm currently experiencing some health issues, so I personally won't be able to test this immediately. This is still a high priority issue for us though, so I'll see if someone else can take over in the mean time.

@arkq Apologies for the wait. I've live-tested the patch with the same setup as before, and it seems to fix the issue as expected. Thanks for the help!


fix(imagecard): restrict sizes

Summary

Restrict card sizes for ImageCard

Related Issues

Closes IBM/carbon-addons-iot-react#395
Closes IBM/carbon-addons-iot-react#397

Acceptance Test (how to verify the PR)

The smaller sizes shouldn't be accepted for ImageCard

:tada: This PR is included in version 1.74.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.9 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.74.3 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


query params not properly reconstructed if method != GET

I believe the issue is in this following code snipped from index.ts:
let [urlBase, queryParams = ''] = url_or_path.split('?')

if (method === 'GET' && payload && typeof payload === 'object') {
    const merged = new URLSearchParams(queryParams)

    // @ts-expect-error ignore this
    const entries = (payload instanceof URLSearchParams ? payload : new URLSearchParams(payload)).entries()
    for (let [key, value] of entries) merged.append(key, value)

    queryParams = '?' + merged.toString()
    payload = null
}

const full_url = (options.base || '') + urlBase + queryParams

if the method is not GET, then when the url is reconstructed, the ? is lost, so a url like  https://api.example.com/example?query=string becomes https://api.example.com/examplequery=string
This seems like a pretty simple fix, just need to move the logic to prepend ? to the querystring from inside the conditional out into the assignment to full_url. I'd be happy to submit a PR to make this change if preferred.

This should be addressed in the latest patch version - lemme know!

specifically v0.9.4 :)

commit (for reference): d9e714c


Enable unified access to job accounting & reporting data

It would be great if one could easily access these data (e.g. output of SGE: qacct or SLURM: sacct  commands) from a single interface.

At the moment the scheduler.getJobStatus() method returns a JobStatus with scheduler specific information


Beta tag for merging cubes

fix: No shadow on tag if not clickable
fix: Missing translations
feat: Add beta tag

Very nice @ptbrowne the tooltip with the info is a nice addition. Could we get this on INT soonish (latest End of Week) as the feature is already on INT?


wdl_runner: Add retries to setup.sh (used by wdl_pipeline_from_git.yaml)

Makes setup.sh more robust to network or server failures.
Reformats the docker command in wdl_pipeline_from_git.yaml to demonstrate how to more cleanly implement a multi-line "command".
Adds us-west zones to the basic.jes.us.options.json.

LGTM


Robot model flickers in rviz2

Describe the bug
Running the app in a ROS 2 Foxy docker container.
The robot model flickers a lot, it looks like there's a problem in the wheels TF publisher
To Reproduce
I'm using branch master
ros2 launch irobot_create_gazebo create3.launch.py

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
https://user-images.githubusercontent.com/25433200/136392069-e4e254d9-950f-47dc-92a0-3b66b74391d2.mp4

I think I also have problems with this bug. I noted that in the tf tree, the wheel frames are being broadcasted with a real timestamp while everything else is in sim time. Not sure if it is related or not, tho.
ros2 doctor doesn't show me anything either.
transforms:
- header:
    stamp:
      sec: 136
      nanosec: 321000000
    frame_id: odom
  child_frame_id: base_link
  transform:
    translation:
      x: 1.751332318387998
      y: -2.1631093830641075
      z: -0.0034154606198514154
    rotation:
      x: -0.00030014269185197413
      y: -0.0024524258137914663
      z: 0.14331001757702422
      w: -0.9896747619213424
---
transforms:
- header:
    stamp:
      sec:<PHONE_NUMBER>
      nanosec: 258963110
    frame_id: wheel_drop_left
  child_frame_id: left_wheel
  transform:
    translation:
      x: 0.0
      y: 0.0
      z: 0.0
    rotation:
      x: 0.0
      y: 0.0
      z: -0.0005212527839987735
      w: 0.9999998641477583


Revert to use the opster API's and onboard to OpenSearch universal release mechanism

Description
Revert to use the opster API's and onboard to OpenSearch universal release process .
Issues Resolved
https://github.com/opensearch-project/opensearch-k8s-operator/issues/709
https://github.com/opensearch-project/opensearch-k8s-operator/issues/674
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hey @swoehrl-mw can you please take a look and add your review? looks to me like the functional tests are failing because of the image not able to get pulled.
Thanks
Adding @bbarani @peterzhuamazon

Next steps are:

Onboard a jenkins job in https://build.ci.opensearch.org/ that uses the jenkins/release.jenkinsfile.
Cut a tag with 2.5.0 which should trigger the above created job to build and push the docker images to ECR and dockerhub.
The existing release.yaml will do a helm and github release.

@swoehrl-mw @bbarani @peterzhuamazon

Thanks @swoehrl-mw and @peterzhuamazon, one more change, I dont think we need to build, push and maintain the busybox image separately , I have modified the logic to use the existing official busybox https://hub.docker.com/_/busybox, any concerns ?

Yup all the tests pass now, merging the PR.

I have modified the logic to use the existing official busybox https://hub.docker.com/_/busybox, any concerns ?

I believe it was only mirrored so that people would not potentially run into the dockerhub rate limits. But for most users this should not be a concern.

Thanks I can change to ECR busybox https://gallery.ecr.aws/docker/library/busybox, as ECR has no rate limits for now.


DataGrid cell header Issue

Using the library in several of my college projects and frankly, i just fall in love with the provided UI. Recently I have used the library in one of my projects and I defined few columns in a DataGrid user can resize. While resizing the column I noticed that if I tried to drag the resize handle of the cell header it resized the cell weirdly.
Also, I want to suggest to implement a helper behavior for row index in the DataGrid row header.

@bluecomb can you provide a solution the reproduces the problem?

Closing issue until a sample repo is provided.


cluster supporting k8s authentication

i checked  the relevant codes and found that we do not support  K8S certified clusters. do we have any plans to support ?

We will support soon.


[Up] Opener position

For info :
On my config (in flex li) opener appear at the end if I move item on nexw  submenu.
I change :
if ( hintWrapperNode.length )
{
		hintWrapperNode.prev( 'div' ).append( opener.clone( true ) );
}

by
if ( hintWrapperNode.length )
{
	if( setting.opener.position == "after" )
		hintWrapperNode.prev( 'div' ).append( opener.clone( true ) );
	else
		hintWrapperNode.prev( 'div' ).prepend( opener.clone( true ) );
}

And add option open.position on setting

Why did you do it? You can controll the position by css e.g. position absolute.

Hi (too),
I use complex  with flex rules.
When I load your module, the opener are the first block in my .
If I move and create a sublist the opener are appending and by default the "minus" appear at the end.

I dont understand how flex can disable position absolute. Can you make an example on jsfiddle?

Here an exemple of my li :

				Auto Created

		SUBLIST

Float element are ignore if parent is flex contener

This does not work?
.contener {
    position: relative;
}

.s-l-opener {
    position: absolute;
    left: 0;
    top: 0;
}

Of course, it's work, but must force me to configure margin or padding for other element (or contener) to prevent layering.
With my option, it's automatic.
I use your (great) plugin on multiple page of my admin, sometime I want the "plus/minus" at the end, sometime at the beginning.
With my parameter, no need to use CSS rules on contener

As I wrote in the first comment. This way options object and the code become more and more complicated. It can have impact to the speed. Sorry css is the right clean way.

ok ;)


Adding scripts for using the NCEDC data stored on s3

This PR is for adding scripts/functions and a tutorial for using the NCEDC data stored on s3.

adding a format condition for the NCEDC XML format in channelcatalog.py
adding ncedc_3cstore.py by mimicking scedc_s3store.py
adding a notebook noisepy_ncedc_tutorial.ipynb for the tutorial

@kuanfufeng - Looks like you need to update your branch, e.g.
git checkout main
git pull
git checkout kuanfu_ncedc
git merge main
# resolve any conflicts and commit the merge
git push

See above comment about updating the branch

My bad. It has failed somewhere. Let me close this PR and start over again by creating a branch on the up-to-date main.


reassign_floating_island() error

This is a weird one.  Just started this evening, but it's happened repeatedly (requires a restart each time):
Running 3D Photo Inpainting ..
Loading edge model ..
Loading depth model ..
Loading rgb model ..
0%|                                                                                | 0/16 [00:00<?, ?it/s]
Generating inpainted mesh .. (go make some coffee) ..
> /scratch/StableDiffusion/AUTOMATIC1111/stable-diffusion-webui/extensions/stable-diffusion-webui-depthmap-script/scripts/inpaint/mesh.py(282)reassign_floating_island()                                              | 0/7 [00:00<?, ?it/s]
-> for ne in get_cross_nes(lost_x, lost_y):
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb)
(Pdb) asdasdas
*** NameError: name 'asdasdas' is not defined
(Pdb)
(The "asdasdas" just just me typing, to see if I'm in a shell, which I clearly am)
In case it has to do with the first file in the directory, so here it is:

... but I've generated videos from that image before, so... ?

The 3d inpainting code has a lot of pdb.set_trace() commands, which breaks into the debugger, often in places where it checks for a specific condition and tries to recover, sometimes probably left from debugging some interesting situation it got into ..
I've removed this line where it breaks for you above in the latest version. You can also type 'continue' to exit pdb and continue..
I had not encountered the specific conditions for it to run that code, and want to be cautious in just removing all of those commands, as some of them will lead to plain crashes or garbage output.

Great - let me know when I can pull the commit :)  (I just checked, nothing to pull).  For now, I'll type "continue" the next time it happens.

I made the commit around the same time as that post ..
https://github.com/thygate/stable-diffusion-webui-depthmap-script/commit/8d9fa636112f1aaa69242b2cee649c3c1c625c3a


MODULES-8616 Check for permissions to be present on all tables, not j…

Check for permissions to be present on all tables, not just one

Hello @wimvr ,
Thank you for your contribution! :)
The acceptance tests are failing on sles-11-x86_64. Here is our configuration
Error: Execution of '/usr/bin/zypper --quiet install --auto-agree-with-licenses --no-confirm postgresql91-server' returned 104: Problem retrieving the repository index file for service 'spacewalk':
17:11:16   [|] This client is not registered to any spacewalk server.
17:11:16
17:11:16   No provider of 'postgresql91-server' found.
17:11:16   Error: /Stage[main]/Postgresql::Server::Install/Package[postgresql-server]/ensure: change from 'absent' to 'present' failed: Execution of '/usr/bin/zypper --quiet install --auto-agree-with-licenses --no-confirm postgresql91-server' returned 104: Problem retrieving the repository index file for service 'spacewalk':
17:11:16   [|] This client is not registered to any spacewalk server.
--- HOSTS:   sles11-64-1:     pe_dir:     pe_ver:     pe_upgrade_dir:     pe_upgrade_ver:     platform: sles-11-x86_64     packaging_platform: sles-11-x86_64     template: sles-11-x86_64     hypervisor: vmpooler     roles:     - agent     - default   redhat7-64-1:     pe_dir:     pe_ver:     pe_upgrade_dir:     pe_upgrade_ver:     platform: el-7-x86_64     packaging_platform: el-7-x86_64     template: redhat-7-x86_64     hypervisor: vmpooler     roles:     - agent     - master     - database     - dashboard CONFIG:   nfs_server: none   consoleport: 443   pooling_api: http://vmpooler.delivery.puppetlabs.net/
Just put this info default nodeset and run acceptance tests with your changes. If you need any help, please let me know!
Cheers!

Hello @lionce,
I'm not sure, but looking at the error I would say there is a problem installing postgres91-server on sles-11. As I only changed a query, I doubt there is a relation. Can you please have a look and give me some hints what I should do different?
Cheers,
Wim

Hello @wimvr ,
Yes, it's a bit strange, because the updates are working on different platforms and failing just on this one (on installation - I believe it's a permission issue). Without your changes everything is passing. I'll take a deeper look on it! I'll come back to you as soon as possible :) Thanks!
Cheers

Hello @wimvr ,
I found the issue. No provider of 'postgresql91-server' found. It needs to be updated to a newer version:. it worked with postgresql94-server'. I'll inform you when it's fixed on github. thank you for your patience!
Cheers!

Hello @wimvr ,
Sorry for closing this PR. I've closed it and reopened it just to pick up the latest changes on tests. Now you can check the results on travis.
Cheers!

@wimvr Thanks for submitting the PR.
The changes are incorporated in the following PR which is merged
https://github.com/puppetlabs/puppetlabs-postgresql/pull/1096
Please let us know if that works.
@georgehansper Thank you.

@wimvr Feel free to reopen the PR if the fix doesn't work  (PR #1096)

Thank you @wimvr for your contribution.


Failed to read byte from socket(MQTT::ProtocolException)

hi
please @michaelklishin  would can help me.
I have problems with a mqtt client but not happen with amqp client, I use a broker rabbitmq.
my stage are three pc in a network lan
This error with mqtt client
railpc@railpc-VirtualBox:/media/sf_ProjectRubyLinux/Ruby/Semillero$ ruby producer_mqtt.rb
=> Published Message mqtt sended @<PHONE_NUMBER>
/home/railpc/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/mqtt-0.3.1/lib/mqtt/packet.rb:283:in `read_byte': Failed to read byte from socket (MQTT::ProtocolException)
	from /home/railpc/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/mqtt-0.3.1/lib/mqtt/packet.rb:31:in `read'
	from /home/railpc/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/mqtt-0.3.1/lib/mqtt/client.rb:454:in `receive_packet'
	from /home/railpc/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/mqtt-0.3.1/lib/mqtt/client.rb:283:in `block in connect'

The code of mqtt client :
require "mqtt"

c = MQTT::Client.connect(
  host: '<IP_ADDRESS>',
  port: 1883,
  username: 'guest',
  password: 'guest')

loop do
  m = "Message mqtt sended @ #{Time.now.to_i} "
  c.publish("builds", m)
  puts "=> Published #{m}"
  sleep 0.2
end

The broker have is configuration in rabbitmq.config :
[
 {rabbit, [
        %%=====================================
        %%----Configuration of AMQP protocol----
        %% =====================================

        {tcp_listeners, [{"<IP_ADDRESS>", 5672}]},
        {default_user, <<"guest">>},
        {default_pass, <<"guest">>},
        {default_permissions, [<<".*">>, <<".*">>, <<".*">>]},
        {default_vhost, <<"/">>},
        {loopback_users, []}
 ]},
        %%-----------------------------------------------------

        %%======================================
        %%----Configuration Of MQTT protocol----
        %%======================================
 {rabbitmq_mqtt,[
        {vhost,<<"semillero">>},
        {default_user, << "guest">>},
        {default_pass, <<"guest">>},
        {exchange, <<"amp.topic">>},
        {tcp_listeners,[{"<IP_ADDRESS>", 1883}]},
        {allow_anonymous, true}

 ]}
        %%-----------------------------------------------------
].

sorry to my english.
thanks @michaelklishin :+1:

Duplicate of #63


Timestamp Inconsistent for different channels

Hello,
I am using cyber_monitor to see the data transferred via cyberRT. It seems to me that data from different channels tend to have different timestamps. I guess the timestamps should be exactly the same for all channels? How could I synchronize them?

The timestamp represents the time of the current module, for example, the message will pass A-> B-> C 3 modules. So if a message in A at 1s, and the calculation took 200ms, then the time of module B is 1.2s, if B module cost 500ms, then C module's time is 1.7s.

So take my screenshot as an example, the message passes through lidar at<PHONE_NUMBER>,027 and then it comes to pose at<PHONE_NUMBER>,38. The information of pose is over 60 second behind lidar?
Since the definition of timestamp is completely different from 'current_time', how could I get information of exact same time point from all channels?

The localization/pose set the timestamp through
https://github.com/ApolloAuto/apollo/blob/a29a563e95944b603ab9be338cce46e6486a89be/modules/localization/rtk/rtk_localization.cc#L188-L195
The compensator/PointCloud2
https://github.com/ApolloAuto/apollo/blob/06253f8cde316be183c5aa37815d6769bc1b8da0/modules/drivers/lidar/velodyne/compensator/compensator.cc#L77-L81
Next
I‘m not sure that which localization method you used. If it is RTK, then they have different ways of obtaining time. Need to confirm whether this's the problem

Thanks! I need some time to look into cpp code.
I am using the default method in r6.0.0 version which is set to be MSF.
syntax = "proto2";

package apollo.localization;

message LocalizationConfig {
  enum LocalizationType {
    RTK = 0;
    MSF = 1;
  };
  optional LocalizationType localization_type = 1;
}

And currently I choose a dummy way of using time.time() to manually assign the time in listener.py. However, it slows down the simulation.
cyber_start_time = time.time()

def lidar_callback(data):
    global cyber_start_time
    current_time = time.time()
    timestamp = str(current_time - cyber_start_time)

My question for this temporary:
Will a complex listener.py affect the performances of different modules (localizaton, prediction, routing...etc)?

I don’t think there is a high probability, because every task is a coroutine unless you have a small number of CPU cores

Thanks for your feedback! Then for now I will go with the python solution. Since tt takes me longer to understand cpp code, I will update here once I locate the problem.


drivers: led_gpio: minor tweaks

A follow-up PR since I did not review https://github.com/zephyrproject-rtos/zephyr/pull/34417 in time.
Two minor tweaks and a semantics change:

fix a whitespace nit
use gpio_pin_configure_dt()
turn the LED on in case the percentage is nonzero

The last change patterns this driver after behavior in the Android
lights HAL, which recommends analogous behavior when the user requests
a color change in a non-RGB LED:
Do your best here. [...] If you can only do on or off, 0 is off,
anything else is on.

https://source.android.com/reference/hal/structlight__state__t

I think this behavior makes more sense.

I've added a patch to the API docstring which makes the expected behavior clear.

Hi @mbolivar-nordic,
For some reasons I missed #34417. So I am taking the opportunity of this PR to ask a couple of questions.
I remember from a previous PR (#21578) that we were concerned about the order of the children nodes not preserved across the builds. Are we good with that now ?
I also remember a proposal of yours: a DT_CHILD_INDEX macro allowing to bind a LED subnode label to an array index. Indeed an application may need some help to retrieve the index of a targeted LED. Are you still considering adding this helper ?

For DT_INST_FOREACH_STATUS_OKAY there is information that order is not guaranteed:
https://docs.zephyrproject.org/apidoc/latest/group__devicetree-inst_gaeac7ed0f4a6820a6e5d7dadb6d62d6e7.html
For DT_FOREACH_CHILD the order should be preserved (at least that is suggested by the example usage in doc):
https://docs.zephyrproject.org/apidoc/latest/group__devicetree-generic-foreach_ga2f4eead8e8190110f5c0eb353e6a408f.html#ga2f4eead8e8190110f5c0eb353e6a408f

For DT_INST_FOREACH_STATUS_OKAY there is information that order is not guaranteed:
https://docs.zephyrproject.org/apidoc/latest/group__devicetree-inst_gaeac7ed0f4a6820a6e5d7dadb6d62d6e7.html
For DT_FOREACH_CHILD the order should be preserved (at least that is suggested by the example usage in doc):
https://docs.zephyrproject.org/apidoc/latest/group__devicetree-generic-foreach_ga2f4eead8e8190110f5c0eb353e6a408f.html#ga2f4eead8e8190110f5c0eb353e6a408f

I would be surprised if the order is not preserved between builds. This should be deterministic unless somebody made it explicitly not to. I would expect the order to change if you modify the DTS or add some overlay. But from the application perspective it is good enough as application controls what is build and when (unless somebody thinks better and tries to add soma automagically added stuff under our feet).


[Fix-8337][Master] Process instance can not be kill when task is failure and can be retry

Purpose of the pull request
This pr will close #8337

Codecov Report

Merging #8387 (0ed2f27) into dev (49a1270) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #8387      +/-   ##
============================================
- Coverage     45.41%   45.36%   -0.05%
- Complexity     3998     4028      +30
============================================
  Files           680      686       +6
  Lines         26417    26700     +283
  Branches       2839     2866      +27
============================================
+ Hits          11996    12112     +116
- Misses        13288    13446     +158
- Partials       1133     1142       +9

Impacted Files
Coverage Δ

...lphinscheduler/service/process/ProcessService.java
31.96% <0.00%> (ø)

...r/service/queue/PeerTaskInstancePriorityQueue.java
68.00% <0.00%> (-5.92%)
:arrow_down:

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (-2.00%)
:arrow_down:

.../org/apache/dolphinscheduler/api/enums/Status.java
100.00% <0.00%> (ø)

...dolphinscheduler/service/k8s/K8sClientService.java
0.00% <0.00%> (ø)

...uler/api/service/impl/K8sNameSpaceServiceImpl.java
78.90% <0.00%> (ø)

...ache/dolphinscheduler/dao/entity/K8sNamespace.java
0.00% <0.00%> (ø)

...heduler/api/controller/K8sNamespaceController.java
71.42% <0.00%> (ø)

...pache/dolphinscheduler/service/k8s/K8sManager.java
31.57% <0.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a1270...0ed2f27. Read the comment docs.

PTAL @lenboo


0.18.0 has no support arm64

Subject of the issue
As discussed for a previous version in #15, the latest docker images do not support arm architectures. @dopey created an 0.17.2-rc1 image that did support both arm and amd. Since then, the issue has gone cold.
Environment

Kernel (e.g., uname -a): arm64

Steps to reproduce
Try to run autocert v0.18.0 on an arm64 node
Expected behaviour
Everything works as expected
Actual behaviour
  Normal   Pulling    12s (x4 over 104s)  kubelet            Pulling image "smallstep/autocert-controller:0.18.0"
  Warning  Failed     9s (x4 over 101s)   kubelet            Failed to pull image "smallstep/autocert-controller:0.18.0": rpc error: code = NotFound desc = failed to pull and unpack image "docker.io/smallstep/autocert-controller:0.18.0": no match for platform in manifest: not found
  Warning  Failed     9s (x4 over 101s)   kubelet            Error: ErrImagePull

Hey @satdeveloping, will discuss this later this week. Here's the branch @dopey was working on: https://github.com/smallstep/autocert/tree/max/arm64-docker.

https://github.com/smallstep/autocert/pull/198 was merged

Thanks @hslatman. Is there a timeline for a release?


Dialog component cant be submit using actions, but only submit button inside body of the Dialog.

Dialog component cant be submit using actions, but only submit button inside body of the Dialog.
Versions

Material-UI: 0.17.0
React: 15.3.2
Browser: Chrome  56.0.2924.87

Could you provide a reproduction test case? That would help a lot 👷 .
It could be a code sample or a live example. You can use this playground to do so: http://www.webpackbin.com/4yeaqq5_z. Thanks!

Added test case:
http://www.webpackbin.com/4JvmacqOM

@ozluy Thanks for the reproduction test case.
That pattern do not work and it's expected. The <Dialog /> component render the DOM outside of his parent. That's done in order to avoid overflow: hidden issues.
<form onSubmit={this.handleSubmit}>
  <Dialog
    title="Dialog With Post Problem"
    actions={actions}
    modal={false}
    open={this.state.open}
    onRequestClose={this.handleClose}
  >
    <TextField hintText="Name Surname" fullWidth={true} />
  </Dialog>
</form>

I don't have any workaround. We have addressed that issue on the next branch by embracing composition. You can do the following:
<Dialog open={this.state.open} onRequestClose={this.handleRequestClose}>
  <DialogTitle>{"Use Google's location service?"}</DialogTitle>
  <form onSubmit={this.handleSubmit}>
    <DialogContent>
      <TextField hintText="Name Surname" fullWidth={true} />
    </DialogContent>
    <DialogActions>
      <Button onClick={this.handleRequestClose} primary>Disagree</Button>
      <Button onClick={this.handleRequestClose} primary>Agree</Button>
    </DialogActions>
  </form>
</Dialog>

Any updates about this?

@ralphstodomingo What do you mean by update?

@oliviertassinari Sorry, is it correct to assume that dialog composition comes in the next major version? Thanks for all your hard work.

Yes, it is. You can find the documentation here.

@oliviertassinari I am guessing there are no types for this since I can't use it.

If anyone else comes by this and still cannot get it to work and look right this should make it look just like normal and work.
`<Dialog
      title={this.props.title}
      open={this.props.open}
 >
      <form onSubmit={handleSubmit(this.localSubmit.bind(this))} ref="formT">
             <div>
                  <Field
                         title="Truck ID"
                         name="truckId"
                         type="text"
                         required
                         style={styles}
                         component={renderTextField}
                    />
             </div>
                    <FlatButton
                           style={{
                                display:      'inline-block',
                                float: 'right',
                           }}
                           label="Submit"
                           type="submit"
                           primary={true}
                      />
                      <FlatButton
                           style={{
                                display:      'inline-block',
                                float: 'right',
                           }}
                           label="Cancel"
                           primary={true}
                           onTouchTap={this.props.handleEditClose()}
                      />
          </form>
  </Dialog>`

I fixed this using button form="my-form-id" attribute and form id="my-form-id" attribute, works in HTML5.
return (
  <Dialog
    open
    title="Form issue"
    actions={[
      <RaisedButton type="submit" form="my-form-id" label="Submit" />
    ]}
  >
    <form id="my-form-id" onSubmit={handleSubmit(this.onSubmit)}>
      <TextField {...fields.username} floatingLabelText="Username" />
    </form>
  </Dialog>
);

I'm currently on material-ui v0.20.


Add documentation on wrap_err vs wrap_err_with

This PR adds documentation to address the issue described in https://github.com/yaahc/color-eyre/issues/126.

This is ready to squash and merge when the merge conflicts are resolved : )

Thanks so much for your contribution again, the new docs look great! :D I'm still getting used to github PRs or I would've merged it myself, I've been using git+reviewboard for years ^^; I hope you have a great weekend.

thanks!


Add support for offset and limit to the invoke endpoint

So I don't know what's up with github but the commit that got accidentally added is now in master...