error when using pnpm

After cloning the repo and executing pnpm dev, you get the following error:
><EMAIL_ADDRESS>dev /home/user/github/SaaS-Boilerplate
> run-p dev:*

 ERROR  Unknown option: 'saas-boilerplate:commitizen_path'
For help, run: pnpm help run
 ERROR  Unknown option: 'saas-boilerplate:commitizen_path'
For help, run: pnpm help run
ERROR: "dev:spotlight" exited with 1.
 ELIFECYCLE  Command failed with exit code 1.

npm run dev works fine on the other hand. Even though I don't see why anyone would still use npm in 2024.

The project is built and tested on NPM, the documentation suggests NPM and it uses the NPM lock file.
As you confirmed, the project doesn't work on PNPM. But I'm also very surprised it didn't work on PNPM, there isn't any specific feature for NPM. In theory, it should also work on PNPM.
That being said, I only focus on NPM. I have limited resources and it's impossible for me to maintain for yarn, pnpm, or bun. I choose the most support package manager, which is NPM. Of course, you can use other package manager but the default one is NPM.
So, I'm totally open to PR to make it work on PNPM. But the project focuses on NPM.


Set cookie header workaround

This is a small workaround for the Set-Cookie header issue, should a resource provide multiple headers of Set-Cookie.
It feels a little bit hacky, but I'm not entirely sure what the best way to improve this specific use case would be.
I have done some testing with this particular implementation, and there doesn't appear to be any interference with anything else operating as usual.
The base issue here seems to be that UrlRequest is based on urllib2 - as Requests doesn't seem to have this particular issue (seems to be based on urllib3)

Feels hacky but LGTM.


Additional OOTB Cluster components

Summary
The repo is great but it is lacking a couple really easy tasks and playbooks that I think I've created fairly simplisticly in a best-effort attempt to get more people going OOTB faster. These changes are adding DMC and License Master sample playbooks and tasks.
Description of Changes

DMC

Adds all inventory hosts except indexers to the DMC's search peers via CLI
Configures host in MC mode auto

License Master

Adds licenses from the roles/splunk/files/licenses folder as licenses via CLI

Let me know if you'd like any additional changes

Regarding the license master configuration, I have an open PR here that adds that functionality. I have not merged it yet because I failed to test a few scenarios in one of the commits. I hope to have that in soon.
I will look in to the other commits in your PR.

Anything wrong with merging this now?


Debug?

First and foremost, the script is excellently crafted, and I'm quite fond of it. Occasionally, it does shut down, but I've mitigated this by creating a .bat file to restart it whenever necessary, so that's not a major issue. The primary concern arises when I use a program installed or compiled from source. It often displays only a black screen, doing nothing further, and sometimes it even shuts down after a while. To rectify this, I believe I need to uninstall cargo and reinstall everything, though I'm not entirely certain. Additionally, I'm curious about the consequences if one of the API keys becomes inactive. How can I troubleshoot to determine the cause of the program's failure to start? Any assistance would be greatly appreciated.

First and foremost, the script is excellently crafted, and I'm quite fond of it. Occasionally, it does shut down, but I've mitigated this by creating a .bat file to restart it whenever necessary, so that's not a major issue. The primary concern arises when I use a program installed or compiled from source. It often displays only a black screen, doing nothing further, and sometimes it even shuts down after a while. To rectify this, I believe I need to uninstall cargo and reinstall everything, though I'm not entirely certain. Additionally, I'm curious about the consequences if one of the API keys becomes inactive. How can I troubleshoot to determine the cause of the program's failure to start? Any assistance would be greatly appreciated.

It's not really a script, its a binary. Anyways, I just made this as a side project in the past. Sometimes it fails to start due to one of the API's request taking way too long to respond (most likely, moonriver or optimism). It also crash sometimes because even though a wallet doesn't exist, the API for moonriver and optimism will return null. I was also using rust nightly instead of regular version which probably explains why you have to reinstall everything. Not gonna lie, I havent really gotten anything with this program. I'm currently busy with other stuff, so I wouldn't be able to debug or fix issues with this though pull request are always open :>


fix: remove vulnerabilities and adjust card animation in mobile

Adjust older dependencies and vulnerabilities
Adjust animate card in mobile size

Thanks!


Why RR4 alpha 5 doesn't work with yarn

https://github.com/yarnpkg/yarn/issues/1922#issuecomment-261805178

Ah, that's what's causing all the problems. I'll see about getting a new version pushed.

Published alpha 6 to fix that. @ryanflorence has some big changes coming in a day or two, so only install alpha 6 if you're having issues with installation: https://github.com/ReactTraining/react-router/releases/tag/v4.0.0-alpha.6


VS Code release 0.3.0

VSCode Extension Installation Instructions

Download the extension at https://azuresdkreleasepreview.blob.core.windows.net/azd/vscode/pr/641/azure-dev-0.3.0.vsix
Extract the extension from the compressed file
In vscode
a. Open "Extensions" (Ctrl+Shift+X)
b. Click the ...\ menu at top of Extensions sidebar
c. Click "Install from VSIX"
d. Select location of downloaded file


Document extend() properties args as optional

For all of the extend() method documentation (e.g. on Model, View, Collection) can the properties argument please be documented as optional, since it actually is. If I just want to setup the prototype chain and access the prototype, like:
var Klass = Backbone.Model.extend();
Klass.prototype.whatever = whatever;
// ...

There's no point in having to do Backbone.Model.extend({}) just because these params aren't documented as optional.

Meh. You could do it that way — but what's the point?


Compilation error in spring example

I get following error during the compilation of the spring example.
I switched back to the usage of 8.0.4, which works without issue.
[ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/docker/camunda/camunda-platform-get-started/spring/src/main/java/io/camunda/getstarted/ProcessApplication.java:[4,38] cannot find symbol   symbol:   class ZeebeClientLifecycle   location: package io.camunda.zeebe.spring.client [ERROR] /home/docker/camunda/camunda-platform-get-started/spring/src/main/java/io/camunda/getstarted/ProcessApplication.java:[27,11] cannot find symbol   symbol:   class ZeebeClientLifecycle   location: class io.camunda.getstarted.ProcessApplication

Thanks for reporting, as a duplicate of #132 it was closed by the fix in https://github.com/camunda/camunda-platform-get-started/commit/5e4727e6a68b258e61b112a5d65e3ef956dc886f.


data_phase_01 error

Can anyone help with this ?
Thanks in advance

我也遇到这个问题了，请问你解决了吗

I also encountered this issue. Have you solved it?


Response status code does not indicate success: 401 (Unauthorized)

It works well until 11/31
But, from 2023/12/1, azure-cost didn't work like below.
-> Response status code does not indicate success: 401 (Unauthorized)

Please close this issue. Thank you.


Add upgrade host configure warning for ceph nodes

Comes from personal experience during an upgrade where I was too casual about running host configure

I think it would be best to also place the host in maintenance mode using the playbooks ceph-enter-maintenance.yml and ceph-exit-maintenance.yml
This would allow you to perform any maintenance tasks without wide spread disruption.

I think it would be best to also place the host in maintenance mode using the playbooks ceph-enter-maintenance.yml and ceph-exit-maintenance.yml
This would allow you to perform any maintenance tasks without wide spread disruption.

Good idea, done


Make read accept strval or xdr, and output strval, json, or xdr

What
Make read accept strval or xdr, and output strval, json, or xdr.
Why
To make it easier to use, and to include its use in examples.

The --output thing is nice. Would be good for this to be consistent across other subcommands (e.g. invoke)


Filter list of users in org settings menu by role

There are a lot of situations where a user might want to contact an owner/admin/moderator to ask them to do something. Right now, it's tricky to figure out who the admins for your org are. You can currently do it be resorting users by role in the Organization > Users menu, but it's not at all obvious.
To solve this, we should add filtering by role capability to the Organization > Users settings page.
This is probably best implemented as a dropdown with a checkbox next to each role for which roles to show, called "Filter roles".
Follow-ups:

#18618
Help center documentation to explain how to find org admins.

CZO discussion

Hey,
can i work on this?
also I am a bit new to this can you explain the issue a bit more?

Welcome @Satendra124 ! You are welcome to work on this issue. Please check out our guide for new contributors, and comment here whenever you have specific questions about the issue.

Yes so i read the guide and did setup everything locally as well
so i don't understand "You can currently do it be resorting users by role in the Organization > Users menu"
In the users section in the right the only option i see is to search users (I did saw search operators but could not find anything related to sorting by role)
I don't know if I am looking at the right place can you help?

If you click the columns in the table, it'll sort by the column you clicked on.
Questions in the "development help" stream in https://zulip.com/developer-community/ is the best place for getting a quick
response to questions.  Generally you'll want to play with the part of the app in your development environment, use your browser "inspect element" feature to look at how that part of the page is implemented, and then use git grep and browsing filenames in the codebase to find the code implementing a given feature, and then once you understand that code, you can think about changing it to complete an issue like this one.  Zulip's "New application feature" tutorial in ReadTheDocs is also helpful.

Thanks a lot :)

@zulipbot claim

@zulipbot abandon
I will work on it later if available

@zulipbot claim

Can we just add a dropdown next to the user's section and then sort there by the role of the user?
in this case, the user doesn't have to go every time to the settings page and change the sorting.

@zulipbot claim

@zulipbot claim

@zulipbot claim

Yes, I am still working on it.

@zulipbot claim

@zulipbot claim

@zulipbot Claim

@zulipbot abandon

claim

@zulipbot claim

@zulipbot claim

Hey @Chiranjeev-Kartik , it's been sometime and you haven't opened a PR for this issue, are you still working on this ? Or should I take over this.

@zulipbot claim

@zulipbot abandon

@zulipbot claim

zulipbot claim

@zulipbot claim

Hi ! Is this issue still available to try out?

Hey @tohirul , thanks for your interest. However, I have already raised a PR for this, and it is currently under review. You can check out other issues with the "help wanted" label. Thanks! :)

Hi, is this issue still open?

Yes, if an issue is open in GitHub, that means it's open.
Please note that there is already a PR for this issue.
As noted in the contributor guide:

What if there is already a pull request for the issue I want to work on? Start by reviewing the existing work. If you agree with the approach, you can use the existing pull request (PR) as a starting point for your contribution. If you think a different approach is needed, you can post a new PR, with a comment that clearly explains why you decided to start from scratch.

@zulipbot Claim

I had a look at the current open PR and I don't think we can use that without a rewrite since that PR introduces business logic to list_widget.js. list_widget.js is a generic component used at multiple places, it should not have business logic. I'll start work on a new PR soon

@zulipbot claim


[Service Bus] Consider updating the _response in the returned response from HTTPOperationResponse to HTTPResponse

Consider updating the _response in the returned response from HTTPOperationResponse to HTTPResponse.
// Service Bus
_response: HttpOperationResponse;

// From core-http
export interface HttpOperationResponse extends HttpResponse {
  parsedHeaders?: { [key: string]: any };
  bodyAsText?: string | null;
  parsedBody?: any;
  blobBody?: Promise<Blob>;
  readableStreamBody?: NodeJS.ReadableStream;
}

// Example for `_response` in storage
_response: HttpResponse & {
  parsedHeaders: ServiceGetUserDelegationKeyHeaders;
  bodyAsText: string;
  parsedBody: UserDelegationKeyModel;
};

Reference #10491

@HarshaNalluru Is there anything left to do here or does #12015 cover what we wanted to do?

#12015 closes this issue


pista: init at unstable-2023-02-20

a simple {bash, zsh} prompt for programmers
Description of changes
https://github.com/nerdypepper/pista
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Please add yourself as a maintainer in a separate commit, and then add the package in a second commit.

Since this is a new package, it should be put now into pkgs/by-name/pi/pista/package.nix, and removed from all-packages.nix.

@smancill Thanks for the review, suggestions applied! I had already done the move from all-packages.nix to by-name/....

Thanks again!

Result of nixpkgs-review pr 184768 run on x86_64-darwin 1

1 package built:

pista


DOC: Point to SurfaceTopography for details on installation

@pastewka do you know how to strat the test.yml workflow ? I added the file but nothing happens

I don't remember. I thought it would run automatically.

Ok I spotted the error: MaskedArray.max does not possess that argument.
However, I thought we wanted to get rid of masked arrays in ContactMechanics simulations.
So the problem will probably solve itself in ContactMechnics.

I've fixed the max problem in NuMPI - see here: https://github.com/IMTEK-Simulation/NuMPI/pull/56

Now there is another problem. It seems that Flake8 is crashing ...


Help with typescript configuration

I tried to adapt the configuration to use pure typescript as can be seen in this repo:
https://github.com/Aranir/create-react-app-typescript
The application compiles but the page stays blank. I am certainly missing something simple.
Currently only the webpack.config.dev.js file has been adapted to use typescript.
I tried to use:
create-react-app my-awesome-typescript-app-folder --scripts-version=git://github.com/mattiamanzati/create-react-app.git#typescript-support
But this seems not to be working anymore:
Cannot find module '.../my-awesome-typescript-app-folder/node_modules/git:/github.com/mattiamanzati/create-react-app.git#typescript-support/package.json'

Any help would be appreciated.

Hey, I am maintaining a fork of react-scripts called react-scripts-ts which is published to NPM. You might want to have a look at it, as it's working perfectly at the moment with up-to-date fixes from facebook's react-scripts. https://github.com/wmonk/create-react-app/

Thank you that is very helpful!

TypeScript is now officially supported as of Create React App 2.1. Read the release notes to get started!


Requested Route has not been mapped in Spark for Accept and Not Found 404 Errors

Hello, I have been happily using HABridge in a docker container for about a year now with no issues and today for some reason it started having problems. When I log into the web interface it shows many 404 Not Found error messages on the side panel, (see attached screenshot). The logs also show a bunch of these:
03-28-2024 18:20:19.619	INFO	The requested route [/api/devices] has not been mapped in Spark for Accept: [application/json, text/plain, */*]	spark.http.matching.MatcherFilter
03-28-2024 18:20:19.621	INFO	The requested route [/api/devices/hass/devices] has not been mapped in Spark for Accept: [application/json, text/plain, */*]	spark.http.matching.MatcherFilter
03-28-2024 18:20:34.934	INFO	The requested route [/api/devices] has not been mapped in Spark for Accept: [application/json, text/plain, */*]	spark.http.matching.MatcherFilter
03-28-2024 18:20:34.986	INFO	The requested route [/api/devices] has not been mapped in Spark for Accept: [application/json, text/plain, */*]	spark.http.matching.MatcherFilter
03-28-2024 18:20:34.987	INFO	The requested route [/api/devices/backup/available] has not been mapped in Spark for Accept: [application/json, text/plain, */*]	spark.http.matching.MatcherFilter
03-28-2024 18:20:59.928	INFO	The requested route [/api/0f57486ed5cf4d20a945eff81c262629/lights] has not been mapped in Spark for Accept: [null]	spark.http.matching.MatcherFilter
03-28-2024 18:21:00.524	INFO	The requested route [/api/devices/harmony/activities] has not been mapped in Spark for Accept: [application/json, text/plain, */*]	spark.http.matching.MatcherFilter
03-28-2024 18:21:00.525	INFO	The requested route [/api/devices/harmony/devices] has not been mapped in Spark for Accept: [application/json, text/plain, */*]

I tried dropping in an old backup of the config and DB files and it did not make a difference, I also checked the file permissions and those are as they should be as well. I am a little lost on how to fix this. DB and Config files attached (passwords removed). Thanks in advance!
ha-bridge.config.txt
device.db.txt

Found the issue was with my Harmony hub. I blew away the container and the config files and started from scratch, added my home assistant instance and it was fine, once I added the Harmony hub it started freaking out. Turns out I don't really need it anyways so everything is back to working. Thanks.


Using Prisma Model in FastAPI response annotation gives warnings

Bug description
Using Prisma Model in FastAPI response annotation gives warnings about being subclassed, when user cannot change behaviour.

How to reproduce
Run a basic FastAPI app and return data from db using prisma, ensure to use type annotations or the response model (I used fastapi-utils InferringRouter). In the output will be something similar to:
backend-fastapi-prisma | /usr/local/lib/python3.10/site-packages/fastapi/utils.py:88: UnsupportedSubclassWarning: Subclassing models while using pseudo-recursive types may cause unexpected errors when static type checking;
backend-fastapi-prisma | You can disable this warning by generating fully recursive types:
backend-fastapi-prisma | https://prisma-client-py.readthedocs.io/en/stable/reference/config/#recursive
backend-fastapi-prisma | or if that is not possible you can pass warn_subclass=False e.g.
backend-fastapi-prisma |   class Role(prisma.models.Role, warn_subclass=False):
backend-fastapi-prisma |   use_type = create_model(original_type.__name__, __base__=original_type)

Expected behavior
No Warning to be shown

Prisma information

Any schema
Environment & setup

OS: All
Database: All
Python version: All
Prisma version: 0.5.0

In the meantime I have surpressed the warnings using the following (before importing my app)
import warnings
from prisma.errors import UnsupportedSubclassWarning
warnings.filterwarnings(action="ignore", category=UnsupportedSubclassWarning)


Execute permission for bash scripts not set on Linux

If the repository is cloned on Linux with the command git clone https://github.com/ckormanyos/real-time-cpp.git the execute permission bit for each of the bash build scripts is not set.
For example, as can be seen in the directory listing for chapter04_04 below, the execute permission bit for build.sh is not set.
$ ls -la
total 144
drwxrwxr-x  5 brian brian  4096 Jun 12 23:39 .
drwxrwxr-x 16 brian brian  4096 Jun 12 23:39 ..
-rw-rw-r--  1 brian brian  5966 Jun 12 23:39 build.bat
-rw-rw-r--  1 brian brian  6498 Jun 12 23:39 build.sh
-rw-rw-r--  1 brian brian   949 Jun 12 23:39 chapter04_04.atsln
-rw-rw-r--  1 brian brian 21897 Jun 12 23:39 chapter04_04.cppproj
-rw-rw-r--  1 brian brian  1624 Jun 12 23:39 chapter04_04.sln
-rw-rw-r--  1 brian brian 33029 Jun 12 23:39 chapter04_04.vcxproj
-rw-rw-r--  1 brian brian 18877 Jun 12 23:39 chapter04_04.vcxproj.filters
drwxrwxr-x  2 brian brian  4096 Jun 12 23:39 images
-rw-rw-r--  1 brian brian  3604 Jun 12 23:39 readme.md
drwxrwxr-x 11 brian brian  4096 Jun 12 23:39 src
drwxrwxr-x  4 brian brian  4096 Jun 12 23:39 target
-rw-rw-r--  1 brian brian 11813 Jun 12 23:39 target.vcxproj
-rw-rw-r--  1 brian brian  2315 Jun 12 23:39 target.vcxproj.filters
$

Attempting to run the command ./build.sh results in an error:
$ ./build.sh
bash: ./build.sh: Permission denied
$

It's possible to resolve this issue by setting the execute permission bit for build.sh with the command chmod +x build.sh. However, it would be nice if the execute permission bits for bash scripts were already set in the GitHub repository so that this manual intervention could be avoided.

This will be handled both here i nthis issue as well as in #56

Hello @ckormanyos,
is there a way to create a Pull-Request to this project?
I already created a bugfix branch with the fix of the missing execute permissions for bash scripts...
BR,
Mark

is there a way to create a Pull-Request to this project?

Yes. Of course. Just create a normal PR for your branch. I can integrate the PR immediately thereafter.
Thank you and kind regards, Chris.

Should be solved for all shell scripts in Pull-Request #59
:)

Fixed by #59


Fix for strict flag in TypeScript

Reproduction
Dependencies:
 "dependencies": {
    "react": "^16.0.0",
    "react-dom": "^16.0.0",
    "styled-components": "^2.2.1"
  }
}

tsconfig.json with strict flag set to true.
{
    "compilerOptions": {
        "outDir": "dist",
        "target": "es6",
        "module": "es2015",
        "declaration": true,
        "sourceMap": true,
        "noImplicitAny": true,
        "strictNullChecks": true,
        "noUnusedLocals": true,
        "removeComments": true,
        "jsx": "react",
        "moduleResolution": "node",
        "strict": true,
        "baseUrl": "."
    },
    "include": [
        "src/**/*"
    ],
    "exclude": [
        "node_modules"
    ]
}

Example:
import * as React from 'react';
import styled from 'styled-components';

export interface MyCompProps  {
    className: string;
}

export class MyComp extends React.Component<MyCompProps> {
    public render() {
        return (

               Hello

        );
    }
}

const MyCompStyled = styled(MyComp) `
    background: red;
`;

export default MyCompStyled;

Error
ERROR in [at-loader] ./src/components/core/heading.tsx:61:37
    TS2345: Argument of type 'typeof MyComp' is not assignable to parameter of type 'StatelessComponent<{}>'.
  Type 'typeof MyComp' provides no match for the signature '(props: { children?: ReactNode; }, context?: any): ReactElement<any> | null'.

Same error occurs if I provide the props type e.g: styled<MyCompProps>(MyComp)..
Workaround
The workaround is to cast the component type to an any:
const MyCompStyled = styled(MyComp as any) `
    background: red;
`;

The problem is that the shape of MyComp is different to React.Component so it does not pass the strict guard. This won't occur if you leave out the constructor (implicitly any) or set your constructor props to any.
Fix
I changed the styled-components.d.ts interface to allow an  ComponentClass` with props.

(component: React.ComponentClass
 | React.ComponentClass<T>): ThemedStyledFunction
;

cc @styled-components/typers

hm, I could not reproduce your error on the latest build.
Packages used<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Strict mode was used.
Please make sure you're using latest @types/*

@Igorbek thanks, updating to 2.2.3 has fixed this!

@jbw I tried again on a fresh project, and did work.
See exact files I used: https://gist.github.com/Igorbek/5230426eca53232b0742e9b6bbcc40c0
Changes comparing to your sample:

tsconfig.json: changed declaration to false, since TS cannot export private names
styled-components: used version 2.2.3

I included yarn.lock so you can see exact versions of other packages that were used.
Let me know if it helps you or not.

Also, make sure your awesome-typescript-loader uses the same typescript version.

You need to have a constructor with props and will fail.

@jbw I don't understand. I took the example you posted in the beginning. Can you please give exact code that is failing, a reproduction code?

And BTW, I did comment out these lines and it still worked correctly.

You should be able to modify the gist you sent to include a constructor in your component.
import * as React from 'react';
import styled from 'styled-components';

export interface MyCompProps  {
    className: string;
}

export class MyComp extends React.Component<MyCompProps> {

   constructor(props:MyCompProps) {
       super(props);
    }

    public render() {
        return (

               Hello

        );
    }
}

const MyCompStyled = styled(MyComp) `
    background: red;
`;

export default MyCompStyled;

Ok, now I see it. You first posted it with the constructor.
I just explained why that happens here: https://github.com/styled-components/styled-components/issues/1287#issuecomment-341997404
So basically, the issue in @types/react.

*without. Yes, you're right and I can see your confusion now :)


Vector search and embeddings API

Currently we don't have anything, and the RAG example just uses OpenAI's plain API to generate embeddings.
It seems simple enough to add a dedicated API to models to generate embeddings, would wouldn't provide much on top of what the OpenAI SDK already offers, but would help a lot with Gemini where there's currently not interface in what we have.
I suspect that the vector search part is harder to provide an API for: anything beyond toy examples will require full control of the database being searched, and we're not (yet) building an ORM.
Am I wrong or missing something?

Can the retriever pattern be reused for vector search?

tool calls already work well for vector search, see https://ai.pydantic.dev/examples/rag/.
The main thing we can add is a model agnostic interface for creating embeddings.


haskell.packages.ghc881.th-lift: fix build

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

This depends on https://github.com/NixOS/nixpkgs/pull/67654.

Closed in favour of #67709.


Rename excon component attribute from http to excon

The rack middleware uses the same component value. So excon and rack
requests are currently impossible to differenciate.
The value excon seems like the most explicit one to me. I'm open to any alternative though.

Technically, we are supposed to remove the component attribute from this (and all other) instrumentation. See: https://github.com/open-telemetry/opentelemetry-specification/pull/447. We should replace this with the InstrumentationLibrary (see: https://github.com/open-telemetry/oteps/pull/84) and make that available on SpanData for export.
I will try to write some issues up about this shortly.

That definitely makes sense, and feels much better in the end.
I've opened #264 and #265. I suppose we can continue there.


Offer to re-open a file without restarting binary ninja

Sometimes we edit (e.g. recompile) a file and wish to have BN re-analyze the new file. Right now, this can be achieved by the action "restart binja and re-open files", but restarting binja is indeed not necessary -- simply close the file, and re-open it is fine

Added in 4.1.5110-dev


Make $pullAll remove all instances from the existing array

Description
Closes https://github.com/FerretDB/FerretDB/issues/2109.
When I was testing I noticed that https://github.com/FerretDB/FerretDB/pull/2032 did not remove all instances from the array. According to this it should remove all instances specified in the $pullAll field. This PR attempts to resolve that issue.

Readiness checklist

[ ] I added/updated unit tests.
[x] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed. (it crashes - only test-integration-pg worked)
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[ ] I marked all done items in this checklist.

I am trying to do rm -rf records and then task test and see if it doesn't crash.

I am trying to do rm -rf records and then task test to see if it doesn't crash.

I'm not sure if I understand, but we moved records into ./tmp/records

I am trying to do rm -rf records and then task test to see if it doesn't crash.

I'm not sure if I understand, but we moved records into ./tmp/records

Really? They don't seem to be there for me.
byron@byron-ThinkCentre-M910q:~/workdir/FerretDB$ tree | grep records
│       ├── records_test.go
├── records

We just moved it: https://github.com/FerretDB/FerretDB/commit/dbca2b115f2100c843821f316cf05eb19e050152#diff-cd2d359855d0301ce190f1ec3b4c572ea690c83747f6df61c9340720e3d2425eR261

@AlekSi fixed.
The introduction of the new composite was causing TestQueryCompatRunner/ArrayAllWholeNotFound to fail so I changed the filter.


[JS] Intl, Fx 72 tasks

Trello
https://trello.com/c/qs3x49mf/138-intl-updates-fx-72
Acceptance criteria

[x] Support specifying calendar/numberingSystem in the |options| argument for {DateTime,Number}Format

This is nightly only. I've commented to say that the bug that enables this needs to have the dev-doc-needed flag, so that we can document this when it actually ships and the spec is stable. Nothing to do here for now.


Extra Dates at Bottom of Screen

I first noticed this happening after the double message was fixed.
When you open hermes, you'll find a list of dates at the bottom. I have seen from 2 to 4:

If you send a message, these dates move up:

But if you reload, they go back to the bottom:

Just a quick pointer 😄

The fix for this is the same as that of the message duplication issue: checking if the date element already exists before printing it.


SublimeLinter-contrib-ansible-lint isn't in PackageControl

Hi,
I don't know if I missed something - but I cannot find SublimeLinter-contrib-ansible-lint in Package Control. Is this a known issue?

@nklmilojevic Thanks to your comment on the ticket in the SublimeLinter repo this plugin is now on it's way to Package Control. Let me know if there is any problems with it or if you have suggestions for improvements.

Woohoo, great, thanks a lot. Package is now in Package Control so I'll be closing this issue.


Debug Console doens't follow output when a command is entered while paused in debug mode

Issue Type: Bug

Pause a node process in debugger
open Debug Console
enter a command (can be anything)
hit enter
line just stays there and doesn't jump to bottom of the result

VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:37:28.172Z)
OS version: Darwin x64 21.1.0
Restricted Mode: No

see images:
before, I entered in some dummy lines to fill up the console window, then typed a real command and hit enter. as you can see it looks like nothings happened.

but if I scroll down...

this is a frustrating function, I have scroll every time I enter something. really gets in the way

I can't repro it and don't remember seeing this before. Does it happen 100% of the time?

There was a fix that went in here some months ago, let me know if it still happens.


Unrecognized cigar character 'N' from cigar component

Hello,
I've mapped my whole genome sequencing reads from S.cerevisiae to the yeast genome using HISAT2 to generate my .sam files. I've set up a brand new conda environment with java and quickvariants as described in this Github. Unfortunately, I run into an issue with each of my four tester .sam files as depicted below:
Exception in thread "Thread-0" java.lang.RuntimeException: Failed to process [GCTTAGCCTGCGCTTAGCCTACAACTTCTTCCGCTCTCGAAAAGACCAATATAATAGAAAGTTATAAATTACATTTCCTTATTAGGTATA
CGACCTCGCGCTTCGAAGTAGAGGAGCCCTTTTTGGCGTACCTACATATGGCGCGTCAGA ACCCATTCACCCACGACGTATCAAGTTACTTCCTTGGTGCAATGTCCCACTATAAAAAAATTCCTTGACGCTAGATCGTTGGACTAAAATCTGCGTCACAATCGCCT
ACACAGGAAATATTGCCTATTTTCGTACAAGGTTACTTCCTAG ]
at mapper.AlignerWorker.process(AlignerWorker.java:108)
at mapper.AlignerWorker.run(AlignerWorker.java:83)
Caused by: java.lang.IllegalArgumentException: Unrecognized cigar character 'N' from cigar component '5535N' from full cigar string '138M5535N12M'
at mapper.SamAlignment.toSequenceAlignment(SamAlignment.java:57)
at mapper.AlignerWorker.tryConvertSamAlignment(AlignerWorker.java:188)
at mapper.AlignerWorker.align(AlignerWorker.java:175)
at mapper.AlignerWorker.process(AlignerWorker.java:106)
... 1 more
Worker failed; aborting
The java script appears to run into issues when "N" is in the cigar string -- any idea how I can still use the tool for my sam files? Thanks in advance!

That would be wonderful! Thanks for the prompt response.

This should be done now in version 1.1.0!
Thanks for the report - sorry it took so long as we've been moving countries and institutions.


I can't tweak hx30v

Using drivers Windows-MSC, Windows-MTP, Windows-vendor-specific, libusb-MSC, libusb-MTP, libusb-vendor-specific
Looking for Sony devices
Querying mass storage device
Sony DSC is a camera in mass storage mode
Getting device info
Using firmware for model DSC-HX30V
Unknown device: DSC-HX30V
this what it says
I don't know what to do the camera is in Japanese, I want to be able to change it to English.

contact my email, i can fix it
<EMAIL_ADDRESS>


[OSF-2052] LinkedIn share button should warn about adblockers. Share button file url should be the OSF file page url.

Purpose
(1) If a user has ad block turned on and tries to share a project via linked in, the user is not able to share the project and get no information as to why. I think we should improve this with a tooltip that informs the user that having ad blocked enabled may prevent successful sharing of their project.
(2) The link on the file detail page used in the share/embed popover is to the rendered file, which is fine, however with the social media sharing links the link should be to the file.
Changes
Added tooltip, changed share button file link.

Side effects
NO
Ticket
https://openscience.atlassian.net/browse/OSF-2052

If item 1 was approved by product, great, otherwise it should be something more obvious if possible than a tooltip (for example, overlaying a 🚫 over top of the LinkedIn icon). We can change this in the future if need be.
Overall, code seems fine. Has the functionality been demo'd and approved? 🎉 🐧 🎉

Those were both requests from the @saradbowman and @nicipfeiffer. Detecting whether the user has an inappropriately acting adblocker seems like it would be a lot of additional work, especially since it is likely that newer adblocking programs would have fewer false positives; but yes, that could be done in the future.
The previous version before these small changes went through Q/A, so otherwise I believe they are happy with it.


MFA push / Authy API compatibility

I'm not quite sure whether this is possible and whether the issue title explains properly what this is about.
The general idea is to improve usability for 2FA.
So for 2FA there's usually a separate app and once users are prompted to type their second factor they might have to unlock their mobile phone, open the authenticator app, search the platform and then they can actually start to type or copy the code.
The company Twilio created a smart solution for making this workflow easier: Authy.
Authy's workflow goes as follows:

the application calls Authy when it wants 2FA assurance. Using Apple or Google, Authy sends a push notification to the user’s device, which improves the user’s experience by leading the user to the mobile app. This push notification does NOT contain the transaction details.

This workflow sounds great and clearly removes friction. But it relies on a proprietary uncontrollable service. Such as most push notification infrastructure besides ntfy.
And this workflow obviously relies on push infrastructure anyway.
Therefore it would be nice to have a free solution to improve people's security.
Without knowing any details about Android development I would guess that it would need these things:

The server must have an integration possibility so that services and applications can actually provoke this. The best way would probably to mimic the Authy API, since other developers only would have to give the config option to change the API URL then.
ntfy Android app should have a possibility to open a particular entry from an MFA app (maybe it would be good to discuss that with the folks from FOSS OTP projects, such as andTOP, FreeOTP+ and Aegis). I'm not quite sure how video players declare that they are capable of opening videos or certain URLs. Maybe something similar would work here too (i.e. there's already a schema to create a new entry in an OTP app with otpauth://totp/some_email_provider).

I'm fully aware that this is a lot to ask but improving security and its usability for people believing in free software is a probably  worth a try.
PS: Thank you so much for nfty :raised_hands:

You can use something like Authelia on your web server.

You can use something like Authelia on your web server.

This issue is not about securing ntfy with an identity provider. It's about providing a Authy inspired/compatible API within ntfy and allowing to open an Android intent on OTP apps that will open a particular entry.

You want to use ntfy to proxy OTP requests from back-end services to OTP apps?

I'm not quite sure what 'proxying' would mean in this context.
The way Authy works (and how I imagine this could work in a combination of ntfy and an OTP) is this:

You try to sign in with activated MFA on a platform (i.e. example.org)
The platform sends a notification to Authy (or maybe your ntfy instance) that you need the OTP code for example.org (there are some libraries to communicate with an Authy API)
Your mobile device is getting the notification and when you tap on it, you'll see the entry for example.org in your favourite OTP app

Since ntfy already supports bringing push notifications from $somewhere via ntfy server to the ntfy Android client two things are missing to replace Authy with ntfy in this scenario:

an incoming API entrypoint for "show OTP entry of example.org" (platform maintainers could probably even use official libs if the API would be compatible to the Authy API)
a way for the ntfy Android to open your OTP on the mobile device for example.org (maybe by opening a scheme like this otprequest://example.org)


Updated the Favicon

[The fav icon was not visible. Now it is visible and works fine. Not a big issue to fix but i guess it's fine. :)

PR MERGED!
Thanks for contributing and being part of the project :)

Can I know what specific changes you made for the Favicon to be visible again


[Amazon Review Required] ALMS-87 iOS Authentication SDK - add support for username and password Cognito authentication

[ALMS-77] iOS Sample App - Add ability to associate a tracker with a collection of geofences

I have been reviewing this with the internal team. We appreciate the effort here, but we have decided that we do not want to merge this in right now. Adding authenticated user pools could have unintended side effects with the way that credentials are stored in the SDK. We will revisit this topic in the future, but I am closing this pull request for now.


fixed rng guide outputs

fixed rng guide output discrepancies

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (598958e) 56.13% compared to head (1e712cb) 56.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3685   +/-   ##
=======================================
  Coverage   56.13%   56.13%
=======================================
  Files         102      102
  Lines       12220    12220
=======================================
  Hits         6860     6860
  Misses       5360     5360

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


API: global atob/btoa functions

Description

closes #123 #124

Manual testing

npm run docs:dev

Checklist

[ ] Changes follow the existing code style (use make fmt-check to check)
[ ] Documentation has been locally tested
[ ] ALL spec deviations of the implemented methods have been documented

Could you run make fmt?


[WIP] Third party adapters

Closes #428
TODO

[ ] Split up zod adapter into dedicated package

[ ] Write integration tests
[ ] Write type tests

[ ] Write Yup adapter
[ ] Fix Vue adapter typings
[ ] Add support for Form-level third-party adapters

I'm reasonably sure there's a bug in the legacy setup of TSUp that's renaming this to this$1, even for DTS generation:

The bug with TSUp is an underlying bug with rollup-plugin-dts: https://github.com/Swatinem/rollup-plugin-dts/issues/279

Temporarily fixed the tsup/rollup-plugin-dts issue using PNPM's patch functionality. Long-term tracking of fix here:
https://github.com/Swatinem/rollup-plugin-dts/pull/287

Codecov Report
Patch coverage is 90.90% of modified lines.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed
Coverage

packages/form-core/src/FormApi.ts
ø

packages/react-form/src/useField.tsx
83.33%

packages/form-core/src/FieldApi.ts
92.00%

packages/react-form/src/useForm.tsx
100.00%

:loudspeaker: Thoughts on this report? Let us know!.

@wobsoriano I believe I broke Vue's onChange value inferencing in this PR. Any chance you'd want to help me review the changes and figure out why that's the case? I'm admittedly a little stumped.

@crutchcorn Doing something like :onChange makes it a prop instead of an event in a Vue SFC, hence losing the types. What we're looking for is @change.
Changing the Vue example to @change fixes it:

SFC - @eventName
JS/JSX - onEventName (you can confirm this by looking at the test file)

@crutchcorn Doing something like :onChange makes it a prop instead of an event in a Vue SFC, hence losing the types. What we're looking for is @change.
Changing the Vue example to @change fixes it:

SFC - @eventName
JS/JSX - onEventName (you can confirm this by looking at the test file)


Fixes return value of the _getSourceId method

The source of a layer is not a model anymore, so the method should change.

Left a suggestion. :+1:


Initial Swedish translation

First version of a Swedish translation

This translation should now be ready for release.

Hello 🙂
Thank's for your contribution. Don't forget to include your file in the localize file. 🙂

Ah, thanks! There we go, now it's included.


Detail about 'background' class

Hi, thanks for your great work.
I have a question about the classifier in this paper, I want to know whether you used the 'background' class in the training. In vanllia maskformer, the author used the background class.  If you used a background class, is it learnable or fixed?

Note, that the classifier predicts an additional "no object" category (∅) in case the embedding does not correspond to any region

Hi,
We use a learnable "void" embedding as defined here.
Best,

Hi,
We use a learnable "void" embedding as defined here.
Best,

OK, I see. Thanks.


Remove ForSqlServer and flattern all provider-specific fluent API int…

…o extension methods
Also some renaming and name-aligning per API review and guiding principles

:shipit:


update all wiki entries for 8.3

e.g. remove references to permissions.xml and set new ones for config.xml.
Maybe add FAQs and bring other sites up to date.
(we would of course appreciate any help of expirienced SimpleServer users)

I am happy about this! You wouldn't believe how many times I accidentally clicked that google link instead of GitHub.

must update the config group syntax


Leaksprotect sensor

Getting an error message for a leak sensor.
Log Details (ERROR)
Logger: custom_components.sia
Source: custom_components/sia/init.py:437
Integration: Sia
First occurred: 2:12:11 PM (1 occurrences)
Last logged: 2:12:11 PM
Hub: Process Event: CRC: 6702, Calc CRC: 6702, Full Message: "SIA-DCS"0174L0#FF8B[#FF8B|Nri1/WA1]_14:12:10,05-01-2020, Message type: SIA-DCS, Sequence: 0174, Receiver: , Prefix: L0, Account: FF8B, Encrypted Content: , Content: #FF8B|Nri1/WA1]_14:12:10,05-01-2020, Zone: 1, Code: WA, Message: 1, Timestamp: 14:12:10,05-01-2020, Code: WA, Type: Water Alarm, Description: Water detected at protected premises, Concerns: Zone or point gave error can only concatenate str (not "bool") to str

hi, good one, this is just a logging line, but will indeed cause an error.

thanks @eavanvalkenburg
the state for these sensors won't change in the HA. It always shows 'dry'

Yeah the error throws before the value is changed, what you can do is comment out/delete line 323-328 in init.py, because I don't know when I'll get around to fixing this version, since I'm creating a official component for HA for SIA, but might be a while before that is merged.

For information same problem for me.
Thx for the component !

For information same problem for me.
Thx for the component !

which version is that on?

v0.2.4, I install the component today with HACS interface.

Can you try installing the preview of the new official integration, in HACS go to the integration, then re-install and then select v0.3.2b?

I installed the v0.3.2b but I cannot connect to Ajax Hub, with same config un configuration.yaml.
Basic conf:
sia:
port: 8000
hubs:
- name: AjaxHub
account: ____
On Ajax Mobile App the "monitoring center" is disconnect.

I've also installed 0.32b))
Here's log
`2020-06-26 18:43:31 ERROR (MainThread) [homeassistant.setup] Setup failed for sia: unknown error
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 3028, in _dep_map
return self.__dep_map
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 2822, in getattr
raise AttributeError(attr)
AttributeError: _DistInfoDistribution__dep_map
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 3019, in _parsed_pkg_info
return self._pkg_info
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 2822, in getattr
raise AttributeError(attr)
AttributeError: _pkg_info
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 142, in _async_setup_component
component = integration.get_component()
File "/usr/src/homeassistant/homeassistant/loader.py", line 264, in get_component
cache[self.domain] = importlib.import_module(self.pkg_path)
File "/usr/local/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "", line 728, in exec_module
File "", line 219, in _call_with_frames_removed
File "/config/custom_components/sia/init.py", line 6, in
from pysiaalarm.aio import SIAAccount, SIAClient, SIAEvent
File "/usr/local/lib/python3.7/site-packages/pysiaalarm/init.py", line 11, in
version = get_distribution(dist_name).version
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 482, in get_distribution
dist = get_provider(dist)
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 358, in get_provider
return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 901, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 795, in resolve
new_requirements = dist.requires(req.extras)[::-1]
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 2743, in requires
dm = self._dep_map
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 3030, in _dep_map
self.__dep_map = self._compute_dependencies()
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 3039, in _compute_dependencies
for req in self._parsed_pkg_info.get_all('Requires-Dist') or []:
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 3021, in _parsed_pkg_info
metadata = self.get_metadata(self.PKG_INFO)
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 1422, in get_metadata
value = self._get(path)
File "/usr/local/lib/python3.7/site-packages/pkg_resources/init.py", line 1618, in _get
with open(path, 'rb') as stream:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.7/site-packages/pycryptodome-3.9.7.dist-info/METADATA'`

OK config flow config only ... 2 min I make conf.

I config with flow and the entity was add without error.
Integration is very simple, it's perfect for me.
But my problem of returning to the initial state persists, if I put a flood sensor in the water the status changes to "Wet" in the Ajax application and in Home Assistant.
By cons if I take it out of the water it returns to a "Dry" status in the Ajax application but it remains in "Wet" status in Home Assistant.

Could you create some logs for that?
Enable this in your configuration.yaml https://www.home-assistant.io/integrations/logger/
with custom_components.sia: debug
as one of the rows, and then in your Logs (now in Configuration under Logs) you should be able to see something going on

Hi @eavanvalkenburg ,
Do you know if this warning message is critical?
2020-07-09 14:25:27 WARNING (MainThread) [pysiaalarm.base_sia_server] CRC mismatch, ignoring message.

Looks like I had to reconfigure using the Integrations wizard AND the encryption field should not be empty.
Now I'm getting this message
2020-07-09 14:44:28 WARNING (MainThread) [pysiaalarm.base_sia_server] Event timestamp is no longer valid: 2020-07-09 11:38:59

The issue is fixed.
Thanks a lot for your work!

ok, great that it is fixed, thanks for checking, the CRC mismatch is def not good, but the encryption field should be allowed to stay empty, I will check that one!

Just noticed that status of a moisture entry won't change from wet back to dry.
Don't you know what might be the issue?


Issue #69 Add + configure redux devtools and dependencies

Adds Redux DevTools + dependencies and configures according to default instructions. Result is Redux DevTools available in React Native's remote debugger window.
Despite the required changes to how we create the Redux store, Redux DevTools is only enabled when application is running/built in development mode.
See #69 for more details.

Should be handy. Looks good to me.


ACCSEC-20443 Xcode 12

Jira Ticket

ACCSEC-20443

Description

Support xcode 12

Testing

[ ] Added unit tests
[ ] Ran unit tests successfully
[ ] Added documentation for public APIs and/or Wiki

Code coverage
Total coverage: 95.18%

Powered by Slather

  Generated by :no_entry_sign: Danger

Code coverage
Total coverage: 95.13%

Powered by Slather

  Generated by :no_entry_sign: Danger

Code coverage
Total coverage: 95.18%

Powered by Slather

  Generated by :no_entry_sign: Danger


feature: Config cycle_results and skip_groups

Did you check the docs?

[X] I have read all the trouble.nvim docs

Is your feature request related to a problem? Please describe.
Hey there, thanks for the v3 rewrite! I appreciate your contributions to OSS.
While migrating my config I found a few settings that I'm not sure made it over, but I want to ask here in case I missed something.
I have the following configs:
cycle_results = true, -- cycle item list when reaching beginning or end

and in next(opts):
require("trouble").next({
  skip_groups = true,
  jump = true,
})

Q1. Where/How can I enable cycle_results again? I would like the prev/next funcs to go around the list from bottom -> top, or top -> bottom, depending on the direction.
Q. Where is skip_groups? Is that still a thing?
Describe the solution you'd like
N/A
Describe alternatives you've considered
N/A
Additional context
No response

I still have this question.
On Sat, Oct 12, 2024, 9:03 PM github-actions[bot] @.***>
wrote:

This issue is stale because it has been open 30 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
—
Reply to this email directly, view it on GitHub
https://github.com/folke/trouble.nvim/issues/577#issuecomment-2408783642,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARBRFBF5YAZLGODCYNSGEDZ3HIHHAVCNFSM6AAAAABOEAVCOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYG44DGNRUGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I've been looking for skip_groups too but with no success, would greatly appreciate any work towards that 🙏

I still have these questions :(


Utility to restore original dimension order after apply_ufunc

This seems to be coming up quite a bit for wrapping functions that apply an operation along an axis, e.g., for interpolate in #1640 or rank in #1733.
We should either write a utility function to do this or consider adding an option to apply_ufunc.

I wonder if it would make sense to simply change the behavior of apply_ufunc so existing dimensions always get restored to their original location, and only new dimensions remain at the end. It seems like this is almost always desirable.

At this point, I think I'm +1 on either automatically restoring dimension order or providing some option to do so (with restoring as the default). I'm still getting used to apply_ufunc so I'm not sure I feel strongly enough to make this call yet though.

I started trying to implement this in apply_ufunc and then realized why I hadn't done so before: it's really not clear how to match up input/output arguments if there are more than one of each. We could do something special for there first input/output but that could be more confusing than helpful.
This is probably better reserved for the simpler apply_raw(https://github.com/pydata/xarray/issues/1618).

What if we just supplied an output_dims kwarg to apply_ufunc or apply_raw?

What if we just supplied an output_dims kwarg to apply_ufunc or apply_raw?

We could do that, but how to do we handle specifying output dimensions for a Dataset function? Maybe use a dict?
This is part of why a helper function starts to make sense to me.

What do we think about attempting to enforce a dimension order throughout the dataset? That would solve these issues for free.
We already have some order in .dims & .sizes. Could we transpose all dimensions to that ordering after any operation?
(Maybe this doesn't need to be strictly enforced, but we'd at least set the expectation that dimensions could be reordered to that dimension order at any time)
Or are there uses to having different dimension order throughout a dataset?
In [45]: ds
Out[45]:
<xarray.Dataset>
Dimensions:  (lat: 25, lon: 53, time: 2920)
Coordinates:
  * lat      (lat) float32 75.0 72.5 70.0 67.5 65.0 ... 25.0 22.5 20.0 17.5 15.0
  * lon      (lon) float32 200.0 202.5 205.0 207.5 ... 322.5 325.0 327.5 330.0
  * time     (time) datetime64[ns] 2013-01-01 ... 2014-12-31T18:00:00
Data variables:
    air      (time, lat, lon) float32 ...
Attributes:
    Conventions:  COARDS
    title:        4x daily NMC reanalysis (1948)
    description:  Data is from NMC initialized reanalysis\n(4x/day).  These a...
    platform:     Model
    references:   http://www.esrl.noaa.gov/psd/data/gridded/data.ncep.reanaly...

In [46]: ds.dims
Out[46]: Frozen(SortedKeysDict({'lat': 25, 'time': 2920, 'lon': 53}))

In [47]: ds.sizes
Out[47]: Frozen(SortedKeysDict({'lat': 25, 'time': 2920, 'lon': 53}))

Consistent dimension ordering is usually a best practice, but I'm not sure we want to enforce it. If a user explicitly supplies two variables, with dimensions ('x', 'y') and ('y', 'x'), respectively, we would either have to raise an error or automatically transpose the second variable. Neither option sounds great to me.
As for the current order in ds.dims, right now we use sorted order. Mostly this is because I didn't want to need to use an OrderedDict for keeping track of dimensions on datasets, and until recently Python dict order was entirely arbitrary. Perhaps this could be relaxed now that Python's dict always preserves the order in which items are added.

we would either have to raise an error or automatically transpose the second variable. Neither option sounds great to me.

Agree, I was thinking we'd transpose the second one, but fair if you think too invasive

Perhaps this could be relaxed now that Python's dict always preserves the order in which items are added.

Ah OK. If we relaxed that, what would the order be? Just the order they were initially added, and so at least consistent through time (though not necessarily with the variables)?

we would either have to raise an error or automatically transpose the second variable. Neither option sounds great to me.

Agree, I was thinking we'd transpose the second one, but fair if you think too invasive

Maybe this would be fine. We already do automatic alignment, and this is really not that much different.
It would be a breaking change, though, so we would  need to  roll it out slowly.

Perhaps this could be relaxed now that Python's dict always preserves the order in which items are added.

Ah OK. If we relaxed that, what would the order be? Just the order they were initially added, and so at least consistent through time (though not necessarily with the variables)?

Yes, that's right.
One potential concern is that this would expose a detail of xarray's data model that would not be easy for users to control. I can imagine that we might have internal xarray methods that inadvertently change  dimension order.
So maybe this would make sense only if we also do your other suggested change (enforcing a consistent dimension order throughout a Dataset).

OK great. We can meditate on it for a while, no great rush! Thanks for engaging.

I'm very new to xarray so I'm not the best person to comment on this at all, but recently I had to figure this out on something I was working on. I ended up using .transpose to reorder the dims. Perhaps adding an example of a 3D array ('time', 'x', 'y') to the documentation might be a good idea?


Add script and docs for deploying schema changes.

Documents https://github.com/alphagov/govuk-puppet/pull/4249
https://trello.com/c/6fnMMZaX/642-1-make-govuk-content-schemas-visible-to-the-publishing-api-in-prod

The whitehall contract tests seem to have been broken for a while.

Needs a rebase.

Weird, it rebased cleanly, merge should've worked.  Anyway, rebased.


Press more juice

Remove extra waste of string comparison when going through bind class hierarchy

This only improves the situation if you get several miss that all go up until the framework class.

Test needs updated

Updated, tests fixed.

Fixed as e9c1533e2af2b26bf26ce13c139ae6ffdeb3a7c5


Update kapp-controller to allow the use of the --preflight flag when using kapp as the deployment method

Once a version of carvel-dev/kapp with support for preflight checks has been released and carvel-dev/kapp-controller has been updated to use that version, kapp-controller needs to be updated to support configuring the preflight checks provided to kapp via the App CR.
For some additional context as to how kapp-controller configures the flags that can be passed to kapp via the App CR, see https://github.com/carvel-dev/kapp-controller/issues/1381#issuecomment-1957478793

What does this entail? Is it just a bump of the kapp-controller version we depend on? Do we know which version of kapp-controller we'll need yet?

What does this entail? Is it just a bump of the kapp-controller version we depend on? Do we know which version of kapp-controller we'll need yet?

Sorry, was updating the parent epic issue with some more stuff that we will need to do on the carvel side of things. I made the issue based on a new check box I added so it defaulted to no description. I'm planning to spend some time today to go through all the issues in the parent epic and making sure that all the descriptions are up to date.

Closing this issue as we are no longer planning to build on top of the carvel tool suite


Swift 3 support

Swift 3 support would be great!
Can't do it by myself, stuck on now unsupported mach_vm_read_overwrite

@vvghost1 Have you tried to port this to Swift 3 yourself? seems easy. If I have sometime this weekend ill do it myself and port a PR. But it's @mikeash hehe who knows if he'll accept!.

Rather than port it, I ended up just writing a whole new version from scratch: https://github.com/mikeash/memorydumper2

@mikeash Good man, thanks a bunch <3


Support of running different Digger projects on different private runners

Scenario: completely separate infra stacks for staging and production, with separate sets of GitHub Action runners.
Desired behaviour: only production runners are used to run Digger against production projects; only staging runners are used for staging.
User suggestion:

One way for us to mitigate this would be to allow having multiple digger configuration files in a repository, and add a parameter on the GitHub action in order to specify the digger configuration file name to use.
Thus, we could have a digger-production.yml listing production projects and a digger-staging.yml listing staging projects, and then run the digger GitHub action on two different runners (production and staging) along with this new parameter specifying which digger configuration file to use.

Mo's comment:

The issue here is that the runners are specified in the workflow file itself which means that we neeed to know which project is impacted before kickstarting the GitHub action workflow

This could probably be addressed in the backend-first flow (aka "authenticated"):

PR activity never triggers workflows directly; only pings digger backend
Digger backend then triggers the right workflow(s) based on the projects affected

This way the user could have completely separate Action workflows for prod and staging (potentially with different digger configurations too)


Update OHW user groups and admin users

Starting preparations for OHW-in-Spanish event.
Adding the new GH teams, and adding myself to the Authenticator/admin_users list
ref #4883

@jmunroe any chance this PR could be reviewed and merged soon? It'll allow our instructors to start testing their tutorials. Thanks!

Thank you @jmunroe !!


fix: Fix storage path in browser

copilot:all

Current dependencies on/for this PR:

main

PR #3563   👈

This comment was auto-generated by Graphite.


[Settings] A11y fixes (2)

Summary of the Pull Request
#13482 - Replaced RadioButtons with ComboBox since these are more appropriate, reduces space and resolves this issue:
FancyZones

Color Picker

Awake

Quality Checklist

[X] Linked issue: #13482
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

@niels9001
Why not use the "OpenInNewWindow" symbol on CP page for "activation behavior"?

I suppose #13316 is off topic?

I suppose #13316 is off topic?

Yes, out of scope for this PR.

/azp run


Test deployment on OpenShift / CRC

We need to make sure that the system can be run on OpenShift or OpenShift-compatible platforms.
For local testing, Red Hat provides CRC.

Note: Maybe there are linters for checking OpenShift compat. of Dockerfiles? That would make it easier to spot issues early, without requiring a CRC cluster.

We already got the system running on Minikube, most parts should be the same for OpenShift.

Starting on this one

was able to do an initial deployment of vulnerability-analyzer, frontend and hyades-apiserver on openshift in dev environment together and perform an end to end test on it. Will also deploy mirror service using this in dev environment.


Missing Employee definition

Hi @ricsirigu, thanks for your time.
The Employee case class is defined here , which is the type that is being expected in this other place

Yeah, I know where it's defined.. but it's not defined  in the exercise text :)

Oh, I see..
In that case, you need to include the definition within the comments ;)


Table().Where(Expression) gives Member access failed to compile expression exception

Hey,
I am using praeclarum sqlite-net library in xamarin PCL library, when I am using :
var item = sQLiteConnection.Table().Where(e =>  (e.Id == CurrentId) && (e.name == Currentname));
It gives exception: Member access failed to compile expression
CurrentId and Currentname both have a value.
The table does exist with its columns.
MyClass is:
public class MyClass
{
[Ignore]
public List<ClassB> Bs{ get; set; }

public string BsAsJson { get; set; }

public string Datestamp { get; set; }

[PrimaryKey]

public string ClassId { get; set; }

public string SomeId { get; set; }

public string name { get; set; }

public MyClass ()
{

}

public MyClass (string datestamp, string id)
{
    Bs= new List<ClassB>();

    Datestamp = datestamp;

    ClassId = id;

    name= "Bagera";

    SomeId= "SomeValue";

}

}
I have asked about this problem in stack over flow:
http://stackoverflow.com/questions/43784932/praeclarum-sqlite-net-table-whereexpression-gives-member-access-failed-to-co
And in Xamarin forums:
https://forums.xamarin.com/discussion/94718/praeclarum-sqlite-net-table-where-expression-gives-exception

Passing CurrentId as parameter fixed my problem.
Before, I used the function like this where Current Id = StaticClassA.MyStaticList[StaticIndex].Id
`public list<MyClass> GettAll()

{
var item = sQLiteConnection.Table().Where(e =>  (e.Id ==  CurrentId) && (e.name == Currentname));
return item.ToList();
}`
The code before will throw => exception: Member access failed to compile expression.
But, when I pass CurrentId as parameter it works fine:
`public list GettAll(string id)
{
var item = sQLiteConnection.Table().Where(e =>  (e.Id == id) && (e.name == Currentname));
return item.ToList();
}
`
I still don't know what is the difference !
Hope this will help someone.

Yes the problem is with calling methods from the query. I will look into supporting this.

Worked! Thanks for the update

Workaround: add .ToList() to the Table result first. Try:
 var item = sQLiteConnection.Table<MyClass>().ToList().Where(e =>  (e.Id ==  CurrentId) && (e.name == Currentname));

@joehanna this is not a good solution, because when you use ToList() all the table will be load to memory before Where filter.
Sorry for my bad english.

I understand @astolfoho. That is why I called it a workaround and not a solution. Work arounds are not usually ideal and are only temporary until the issue is resolved.

I transformed the table in the list, it worked for me.

Any news on this?
I have to same issue sql.Table().Where( xxxx) --> "System.NotSupportedException: Member access failed to compile expression"

Are there any plans on resolving this issue?

same problem when connection.Table<MyTable>().Where(a => !a.Property.HasValue || ids.Contains(a.Property.Value)).ToArray()
MyTable.Property  is Nullable

Thask,It help me.


update STS to <IP_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.762%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
30827

Relevant Lines:
69073

💛  - Coveralls


refactor(parser): adjust function inlining

These 2 #[inline(always)] were introduced by accident by me just playing around in #4298. One should be kept, but the other one we should leave to compiler to decide.

#4530  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

I'm only cleaning up mess I made myself, so merging without review.


Documentation for GPU_Flip

I am in the process of updating a project from SDL2 to SDL_gpu and I encountered some strange behavior:
The content of my GPU_Images are drawn to the window, even though they are supposed to be off-screen drawables.
After digging trough the source code of SDL_gpu I believe that this is caused by the GPU_Flip function.
I used the GPU_Flip function to replace all occurrences of SDL_RenderPresent, as it is suggested in the "Conversion" section in your README. When I used SDL_RenderPresent on my off-screen drawables, they where not drawn on the window.
If it is intended for GPU_Flip draw the content of a GPU_Image to the screen, please document that behavior so others won't make the same mistake as I did.

SDL_RenderPresent's documentation doesn't make this use-case very clear either.  GPU_Flip() is not necessary for render-to-texture, but it should still be okay to call it.  So this is more than just a documentation bug.  In 26bc4111f74539c5fb54f11e26fb9fdfbe66be85, I have added a check to GPU_Flip() so that it should work as expected for rendering to texture.

The fix works, the GPU_Images are not drawn to the screen anymore by GPU_Flip.
Thanks for the fast fix!


amy.c: filter_logfreq slew-rate limited

The filter frequency cannot change faster than -2 oct/AMY_BLOCK to avoid filter state glitches.  See #126.
Verified that this results in sane behavior of the new test.py:TestFilterReleaseGlitch, which gave a clipping transient before this change.

Top is pre-change, front is post-change.  There's still a small transient, but it's not objectionable.
Because the allowed slew rate is so large, none of the other tests are affected.  Some Juno voices certainly hit this limit, but I think they are only improved.  I quickly ran through them to check nothing was suddenly broken.

Fixes #126


{WIP} align hashrocket experiment

The package.json lists the feature flag to be "featureFlag" with a capital F,
however the settings class expected a lowercase f.  This commit updates the
settings class to ues the expected capital F.  Without this change, no
feature flags can be set.

This commit adds an auto-aligner for the hash rocket (=>) for .pp files.  This
feature is hidden behind the 'hashrocket' featureflag as it may have unintended
consequences and reformat user's files unexpectedly.
The auto-align triggers on the > character.

The provider then determines if the user is in a hashrocket.
It then looks at the preceeding and proceeding lines to determine the block
of hash rockets to consider
Once it has block of lines, it determines the smallest hash rocket location
and edits the text file appropriately.

In use

This formatter is a little naive and won't handle multiline hashes

@glennsarti Does this use the logic (or code) of Better Align? I ask because I have been really happy with it in my manifests.

None at all.  This was an experiment.  The difference between this and BetterAlign, is this is trigger as you type.  No need for a command to format the document.

To be honest this should probably use the puppet-lint lexer.

I like the idea of it using puppet-lint

We do use puppet-lint, but it doesn't do live-typing like the demo above does.  also it doesn't enforce the hashrockets the same.

Bouncing PR for Appveyor check

Closing as won't do.  Should be done in the Language Server with proper tokenising.

@glennsarti is there a ticket on the Language Server I should follow related to this?

@genebean No ticket as yet.  When we start the work in earnest I'll migrate issue 465 to the editor-services project


Are model_4 and model_5 the same model?

I appreciate your generosity in providing the finetuned models' weight for future research.
I have a small inquiry.
I noticed that model_4 and model_5 have the same state_dict value.
Would it be a mistake?
Thanks.

Hmmm that seems odd/wrong and may have been an issue which came up when uploading files -- sorry.


Mininet topologies to use the sdx_global.cfg

Adapt the simple_sdx.py of each example to use the information defined in the sdx_global.cfg to keep the topology consistent with the configuration

Will check again if there still any static simple_sdx.py

You should take a look at sdx_mininet.py and mininet.cfg at iSDX-Repo. It is probably not exactly what you want but already a step closer than the simple_sdx.py.

Thanks. So sdx_mininet.py is actually a successor of simple_sdx.py correct?

Correct. We realized that it is too complicated to use the hardcoded topology in simple_sdx.py for testing.

@rbirkner Seems that sdx_mininet.py is not needed any more. At least it was deleted with this commit
Any plans at the iSDX team to handle consistency now?

sorry for the delay. I don't know why it was deleted. The ongoing development focuses more on the hardware deployment and making the code more reliable. The two examples test-ms and test-mt were only used by me to test it. Now, they do more sophisticated regression testing.

Will be obsolete as soon as we use torch for setting up the example topology

Will be obsolete as soon as we use torch for setting up the example topology


only set main parameters (e.g. pldStartRule) if not present as primitive attribute

users should be able to change pldStartRule before the assign node, not between assign and generate
reasons:

if pldStartRule is read by the assign nodes, palladio can be more elegantly put into a HDA (no attribute overwrite logic needed, which might differ between scenes)
otherwise we generate the wrong default rule attributes values for start rules other than the one hardcoded in the assign node parameters. this is a rare case, i.e. can only happen if the rule attribute default values depend on "initialShape.startRule":

attr foo =
	case initialShape.startRule == "Lot": "blue"
	else: "red"

fixed/implement both "reasons" above and merged to master for v1.6.1


[Log] Misleading text

The following text appears when unable to connect to ray. Instead the proper message should say that we are unable to connect.
| /home/superduper/.local/lib/python3.10/site-packages/snowflake/sqlalchemy/base.py:1068: SAWarning: The GenericFunction 'flatten' is already registered and is going to be overridden.            |
|   functions.register_function("flatten", flatten)                                                                                |
| INFO:     Application startup complete.                                                                                |
| INFO:     Uvicorn running on http://<IP_ADDRESS>:8001 (Press CTRL+C to quit)                                                                                |
| 2024-Jul-30 11:31:46.86| ERROR    | statefulset-0| superduper_services.cdc.cdc:301  | In DatabaseListenerThreadScheduler LocalComputeBackend.broadcast() got an unexpected keyword argument 'to' |
| Traceback (most recent call last):                                                                                |
|   File "/home/superduper/superduper_services/superduper_services/cdc/cdc.py", line 299, in run                                                                                |
|     self.listener.next_cdc(cdc_stream)                                                                                |
|   File "/home/superduper/superduper_services/superduper_services/cdc/ibis/listener.py", line 221, in next_cdc                                                                                |
|     self.event_handler(ids, event=cdc.DBEvent.insert)                                                                                |
|   File "/home/superduper/superduper_services/superduper_services/cdc/cdc.py", line 260, in event_handler                                                                                |
|     self.on_create(ids, self.db, self._on_component)                                                                                |
|   File "/home/superduper/superduper_services/superduper_services/cdc/ibis/listener.py", line 194, in on_create                                                                                |
|     self.create_event(                                                                                |
|   File "/home/superduper/superduper_services/superduper_services/cdc/cdc.py", line 236, in create_event                                                                                |
|     db.compute.broadcast(events, to=deps)                                                                                |
| TypeError: LocalComputeBackend.broadcast() got an unexpected keyword argument 'to'

@fnikolai Because of version mismatch
services version and superduper version both should be latest
we need a version check at startup probably in future.


#2480: Autocomplete updates only after a few characters or after space has been pressed

Applies both to the Main and Edit screen.
Part of #2480

This doesn't happen anymore. I think it was fixed by f00c588e97f4188fe6998cc20b8c9ae2c9d73196


Linux executable fails.

I downloaded the Linux executable from http://openmopac.net/MOPAC2016_for_Linux_64_bit.zip
When I run it, it gives errors to the terminal and NaN's in the output:
          Sat Mar 12 14:34:24 2022  Job: 'mopac' started successfully

Intel MKL ERROR: Parameter 1 was incorrect on entry to DSYEVD.

Intel MKL ERROR: Parameter 1 was incorrect on entry to DSYEVD.```

An executable from a couple weeks ago works fine.

I've verified the problem with this build, and I suspect that MOPAC was linked against the wrong BLAS/LAPACK MKL interface in this instance. The other Linux builds (http://openmopac.net/MOPAC2016_for_CentOS-6.zip and http://openmopac.net/MOPAC2016_for_CentOS-7.zip) seem to be working fine and are practically interchangeable with the one you are trying to use. I'll notify Jimmy of this problem, and it should be simple enough for him to fix on his end.

Jimmy fixed the problem.


why storage medium setting only supports the path extension?

When setting storage_root_path,  doris uses the path extension (.ssd/.hdd) to define the storage medium. Why not just add the medium at the end of each root path, seperate by ',', like 'capacity limit'?
e.g.
storage_root_path = /home/disk1/palo , HDD,50

That's a historical reason, there is no special purpose

That's a historical reason, there is no special purpose

OK. For my part, I can't rename the storage paths.  I'll fix it.

That's a historical reason, there is no special purpose

OK. For my part, I can't rename the storage paths. I'll fix it.

I think you should provide some details about the format which you want to change to. Because it should be kept compatible with old format.

How about "storage_root_path = , ,  "?
We can set medium after the capacity limit, it's optional. So we can still use "storage_root_path = /home/disk1/palo.HDD,50;/home/disk2/palo.SSD,1;/home/disk2/palo" to set root path.
I'd prefer to delete reading medium from the extension. But if you want to keep it, that's no problem.
Who has the greater priority, extension or medium parameter?

@imay How about "storage_root_path = < path >, < capacity >, < medium > "?

If this format is used, if capacity or medium is not specified, what does the final path look like? like"< path >, , < medium >" or "< path >, < capacity >,". And if other property is added to this path later, the what will the format be?
How about the format like "path,medium=xxx,capacity=xxx". If user don't specify medium and capacity we use the default option.

We can set medium after the capacity limit, it's optional. So we can still use "storage_root_path = /home/disk1/palo.HDD,50;/home/disk2/palo.SSD,1;/home/disk2/palo" to set root path.
I'd prefer to delete reading medium from the extension. But if you want to keep it, that's no problem.

Even we support new format of path, we should be compatible with old format. Because there are already many instances running now, we should make them happy.

Who has the greater priority, extension or medium parameter?

And if other property is added to this path later, the what will the format be?

It's a good question.  The format like "path,medium=xxx,capacity=xxx" looks like the best choice.
But now, config's pattern is "key = value", so it'll look like:
storage_root_path = /home/disk1/palo.HDD,capacity=50,medium=HDD;/home/disk2/palo.SSD,capacity=1;/home/disk2/palo, medium=SSD
It's difficult to punctuate. And it's difficult to discriminate one pattern from another.
How about support one more pattern? We can set a obvious format marker '('. If we read '(', that means we use the new pattern to parse path. Otherwise, we use the old pattern "< path.extension >, < capacity >;< path.extension >".
The new pattern can be:
storage_root_path = ( { path  = < path >;capacity = < capacity >;medium = < medium >;},{ path = <    path >;} );
We don't need to mix the patterns up, right?

@vagetablechicken

And if other property is added to this path later, the what will the format be?

It's a good question. The format like "path,medium=xxx,capacity=xxx" looks like the best choice.
But now, config's pattern is "key = value", so it'll look like:
storage_root_path = /home/disk1/palo.HDD,capacity=50,medium=HDD;/home/disk2/palo.SSD,capacity=1;/home/disk2/palo, medium=SSD
It's difficult to punctuate. And it's difficult to discriminate one pattern from another.

If = is difficult to punctuate, how about :, like storage_root_path = /home/disk1/palo.HDD,capacity:50,medium:HDD

How about support one more pattern? We can set a obvious format marker '('. If we read '(', that means we use the new pattern to parse path. Otherwise, we use the old pattern "< path.extension >, < capacity >;< path.extension >".
The new pattern can be:
storage_root_path = ( { path = < path >;capacity = < capacity >;medium = < medium >;},{ path = < path >;} );
We don't need to mix the patterns up, right?

Unless one format is not suitable, otherwise it is better not to introduce anthor format.

OK, : is good.
So we can handle /home/disk1/palo.HDD, 50,/home/disk1/palo, capacity:50, medium: HDD.
But how to do with /home/disk1/palo.HDD, capacity:50, medium:SSD?

@vagetablechicken

But how to do with /home/disk1/palo.HDD, capacity:50, medium:SSD?

For this case, property medium has a higher priority. Otherwise, the medium can not be specified except changing directory name.


Dart support.

Added support multiline strings in Dart.

It would be awesome to have Dart support. Is the code incomplete or can this pull request be merged?

@barklan is there any issue with my pr?

@LacticWhale since there has been no answer, would you mind forking and released a Dart-supported version of this plugin? Unfortunately, I don't really have the time for this atm.


Enforce that custom nodes/resources keep their original type

Implementation for proposal https://github.com/godotengine/godot-proposals/issues/7905
Replaces PR #82494 with a clean commit
Bugsquad edit: Closes https://github.com/godotengine/godot-proposals/issues/7905

Crash when opening a project:
CrashHandlerException: Program crashed
Engine version: Godot Engine v4.2.beta.custom_build (3e7f638d7b574785f521beafaf52a6ad95be016f)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] HashMap<String,DocData::ClassDoc,HashMapHasherDefault,HashMapComparatorDefault<String>,DefaultTypedAllocator<HashMapElement<String,DocData::ClassDoc> > >::_lookup_pos (C:\godot_source\core\templates\hash_map.h:100)
[1] HashMap<String,DocData::ClassDoc,HashMapHasherDefault,HashMapComparatorDefault<String>,DefaultTypedAllocator<HashMapElement<String,DocData::ClassDoc> > >::find (C:\godot_source\core\templates\hash_map.h:501)
[2] EditorInspector::update_tree (C:\godot_source\editor\editor_inspector.cpp:3202)
[3] EditorInspector::edit (C:\godot_source\editor\editor_inspector.cpp:3438)
[4] ImportDock::initialize_import_options (C:\godot_source\editor\import_dock.cpp:703)
[5] EditorNode::EditorNode (C:\godot_source\editor\editor_node.cpp:8050)
[6] Main::start (C:\godot_source\main\main.cpp:3253)
[7] widechar_main (C:\godot_source\platform\windows\godot_windows.cpp:179)
[8] _main (C:\godot_source\platform\windows\godot_windows.cpp:204)
[9] main (C:\godot_source\platform\windows\godot_windows.cpp:218)
[10] WinMain (C:\godot_source\platform\windows\godot_windows.cpp:232)
[11] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[12] <couldn't map PC to fn name>
-- END OF BACKTRACE --

@KoBeWi, not sure this crash is related to this PR. Any project now crashes for me on latest master, even without this PR. It also doesn't matter if I try to load an existing project or create a totally new project. Latest master always crashes now.

I get this crash with this PR.

Could you remove that part from the commit message? @AThousandShips and I get notification emails every time you update the commit since we're mentioned in it:

In general you don't need to acknowledge reviewers for minor suggestions like this :)

The crash is fixed now. I did some testing of the feature.
You can still clear the script in the inspector when it's the base script:
https://github.com/godotengine/godot/assets/2223172/e67fe797-4525-4935-bdc6-9c4584c29271
So the node still loses its type.
Detach script can be clicked when using base script:
https://github.com/godotengine/godot/assets/2223172/d7cfea87-2047-46fb-bbb9-0ccabff20e3d
It does "modify" the scene, but has no real effect, just empty action in undo history. I think the button should be replaced with Extend Script when custom node is selected.
Custom types added with EditorPlugin.add_custom_type() are not recognized:

(though this feature is on the verge of being deprecated)
I noticed that custom resources have 2 script entries now:
custom_type_script = ExtResource("1_2b2a6")
script = ExtResource("1_2b2a6")

I wonder if it was possible to skip saving script if custom_type_script exists. But I guess that's prone to errors and not really worth it.

You can still clear the script in the inspector when it's the base script:
So the node still loses its type.

Will look into that.

Detach script can be clicked when using base script:
It does "modify" the scene, but has no real effect, just empty action in undo history. I think the button should be replaced with Extend Script when custom node is selected.

Good idea. I will make this change.

Custom types added with EditorPlugin.add_custom_type() are not recognized:  (though this feature is on the verge of being deprecated)

I will check if this case is also easy to be considered.

I noticed that custom resources have 2 script entries now:
custom_type_script = ExtResource("1_2b2a6")
script = ExtResource("1_2b2a6")

I wonder if it was possible to skip saving script if custom_type_script exists. But I guess that's prone to errors and not really worth it.

I thought about that but I decided not to do it for backwards compatibility. If only custom_type_script gets saved, the project won't load properly in previous versions where custom_type_script didn't exist. Keeping both makes it a non-breaking change.

I thought about that but I decided not to do it for backwards compatibility. If only custom_type_script gets saved, the project won't load properly in previous versions where custom_type_script didn't exist. Keeping both makes it a non-breaking change.

But that's forward compatibility if anything. If old project can be opened in new version then it's good, other way around does not matter.

You can still clear the script in the inspector when it's the base script:

After checking the code you seem to already handle that and print a warning. I think it should not be allowed at all probably.

You can still clear the script in the inspector when it's the base script:

After checking the code you seem to already handle that and print a warning. I think it should not be allowed at all probably.

Yes, currently it's a warning to catch those functionalities that still don't handle the existence of custom_type_script properly. Like the one where you managed to clear Script. This is handled by the EditorResourcePicker class. It creates most of the popup menu with the "Clear" and "Make Unique" options. Derived from it is EditorScriptPicker that actually knows it's dealing with a script and adds the "Create" and "Extend" options to the popup menu.
I'm not sure how to prevent EditorResourcePicker from adding the Clear option to the popup menu when the Script is already equal to the custom type script. I think this should be handled by EditorScriptPicker somehow.

Maybe it's better to keep this editor-only, it's safer this way. So no changes to setters are needed, except maybe some warnings.

Maybe it's better to keep this editor-only, it's safer this way. So no changes to setters are needed, except maybe some warnings.

OK. I will leave the setters with warnings only.
I believe I added all the suggestions we discussed in this last commit.
EditorPlugin.add_custom_type() should be working now.

Detach script can be clicked when using base script:
I refactored the logic that handles the script button in the scene tree dock. If there is a script that's also the custom type script, you now get an "extend" button.

Known issues: You can still force-"Clear" the script from the popup menu in the inspector.

When you change node type from native to custom one, the new node gets a script attached. It doesn't work the other way around - changing custom node to a native type does not detach the script and there is no way to do so. I think the custom type script should be changed/removed when changing type in the scene tree editor.

When you change node type from native to custom one, the new node gets a script attached. It doesn't work the other way around - changing custom node to a native type does not detach the script and there is no way to do so. I think the custom type script should be changed/removed when changing type in the scene tree editor.

Should be working as expected now.

Crash when changing custom node to native type:
CrashHandlerException: Program crashed
Engine version: Godot Engine v4.2.beta.custom_build (59457685c18e2d729eea50c751c11f049a7186f0)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] Object::get (C:\godot_source\core\object\object.cpp:322)
[1] SceneTreeDock::_replace_node (C:\godot_source\editor\scene_tree_dock.cpp:2647)
[2] SceneTreeDock::replace_node (C:\godot_source\editor\scene_tree_dock.cpp:2606)
[3] SceneTreeDock::_create (C:\godot_source\editor\scene_tree_dock.cpp:2541)
[4] call_with_variant_args_helper<SceneTreeDock> (C:\godot_source\core\variant\binder_common.h:308)
[5] call_with_variant_args<SceneTreeDock> (C:\godot_source\core\variant\binder_common.h:418)
[6] CallableCustomMethodPointer<SceneTreeDock>::call (C:\godot_source\core\object\callable_method_pointer.h:105)
[7] Callable::callp (C:\godot_source\core\variant\callable.cpp:58)
[8] Object::emit_signalp (C:\godot_source\core\object\object.cpp:1175)
[9] Node::emit_signalp (C:\godot_source\scene\main\node.cpp:3624)
[10] Object::emit_signal<> (C:\godot_source\core\object\object.h:925)
[11] CreateDialog::_confirmed (C:\godot_source\editor\create_dialog.cpp:434)
[12] call_with_variant_args_helper<CreateDialog> (C:\godot_source\core\variant\binder_common.h:308)
[13] call_with_variant_args<CreateDialog> (C:\godot_source\core\variant\binder_common.h:418)
[14] CallableCustomMethodPointer<CreateDialog>::call (C:\godot_source\core\object\callable_method_pointer.h:105)
[15] Callable::callp (C:\godot_source\core\variant\callable.cpp:58)
[16] Object::emit_signalp (C:\godot_source\core\object\object.cpp:1175)
[17] Node::emit_signalp (C:\godot_source\scene\main\node.cpp:3624)
[18] Object::emit_signal<> (C:\godot_source\core\object\object.h:925)
[19] Tree::gui_input (C:\godot_source\scene\gui\tree.cpp:3826)
[20] Control::_call_gui_input (C:\godot_source\scene\gui\control.cpp:1811)
[21] Viewport::_gui_call_input (C:\godot_source\scene\main\viewport.cpp:1596)
[22] Viewport::_gui_input_event (C:\godot_source\scene\main\viewport.cpp:1825)
[23] Viewport::push_input (C:\godot_source\scene\main\viewport.cpp:3325)
[24] Window::_window_input (C:\godot_source\scene\main\window.cpp:1553)
[25] call_with_variant_args_helper<Window,Ref<InputEvent> const &,0> (C:\godot_source\core\variant\binder_common.h:303)
[26] call_with_variant_args<Window,Ref<InputEvent> const &> (C:\godot_source\core\variant\binder_common.h:418)
[27] CallableCustomMethodPointer<Window,Ref<InputEvent> const &>::call (C:\godot_source\core\object\callable_method_pointer.h:105)
[28] Callable::callp (C:\godot_source\core\variant\callable.cpp:58)
[29] Callable::call<Ref<InputEvent> > (C:\godot_source\core\variant\variant.h:847)
[30] DisplayServerWindows::_dispatch_input_event (C:\godot_source\platform\windows\display_server_windows.cpp:2716)
[31] DisplayServerWindows::_dispatch_input_events (C:\godot_source\platform\windows\display_server_windows.cpp:2686)
[32] Input::_parse_input_event_impl (C:\godot_source\core\input\input.cpp:731)
[33] Input::flush_buffered_events (C:\godot_source\core\input\input.cpp:995)
[34] DisplayServerWindows::process_events (C:\godot_source\platform\windows\display_server_windows.cpp:2401)
[35] OS_Windows::run (C:\godot_source\platform\windows\os_windows.cpp:1474)
[36] widechar_main (C:\godot_source\platform\windows\godot_windows.cpp:182)
[37] _main (C:\godot_source\platform\windows\godot_windows.cpp:204)
[38] main (C:\godot_source\platform\windows\godot_windows.cpp:218)
[39] WinMain (C:\godot_source\platform\windows\godot_windows.cpp:232)
[40] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[41] <couldn't map PC to fn name>
-- END OF BACKTRACE --

Tested with my SliderLabel addon, you can get it from AssetLib.

OK, I was able to reproduce. Will check.

I don't understand what problem does this PR solves. It's a very core change that has no significant demand so far.

I don't think it's this PR that moves the scripting system into another direction. If anything, it just complements the direction the scripting system was already pushed to.
It's currently possible for people to create custom node types with the scripting system and distribute them in the form of plugins for other people to use. What this PR does is just to follow the logical consequence of this idea and make these custom node types behave as expected to someone using a plugin.
This PR doesn't really affect or push the scripting system into any new directions. It just adds consistency, improved usability and transparency to anyone using plugins.

It's a very core change that has no significant demand so far.

The lack of support might come from vague proposal/PR. I myself have overlooked it for quite some time, until I decided to take a look and it turned out to be a nice feature. Though as I noted, I only reviewed how it works in the editor. If there is a way to implement the same functionality, but with less/no core modifications, that could be better.

Gonna work on this and maybe create a new PR


Tinkers Construct Axe Incompatible

The Tinker's Construct Axe just breaks the block instead of what happens with fists and with axes.
MC 1.16.5 (Forge 36.1.4)
Tinkers Construct <IP_ADDRESS>
TreeChop 0.13.0

Tinker's Construct for 1.16.5? Oh me oh my!
Thanks for bringing this to my attention, I'll look into it shortly.

Fixed in 0.14.0


docs: specify timeout unit for resty.kong.log.get_log_level()

Reference the effect here.

@ADD-SP @dndx I think it could be merge now.


ISPN-5310 Produce and distribute module org.hibernate.search.infinispan-...

...storage
https://issues.jboss.org/browse/ISPN-5310

Created an alias to org.infinispan.hibernate-search.directory-provider. This name is required by other projects that depends on this feature

merged, thanks!


Feature request: Option to add a final newline in Bag.to_textfiles

I was kinda caught by surprise with Bag.to_textfiles() not ending each partition file with a newline; using a simple cat *.part > full bash line to concatenate them doesn't work as expected. It would be useful to add an optional parameter, say final_newline=False, to end each partition file with a newline.

Sounds reasonable and not hard to implement.
Would you be interested in writing a PR?

Yeah i'll give it a try, thanks!