[BUG] Memory leak - Memory being filled with CancellationTokenSource objects

Describe the bug
While developing locally I've encountered a bug where my memory gets filled by CancellationTokenSource objects.

This happens when trying to make use of azure servicebus configured as such:

The key to triggering the bug seems to be setting the MaxConcurrentSessions to lower than the default.
The bug happens after sending a second message to the message processor.
(The message processor is currently an empty method, no logic in there)
Expected behavior
Messages get processed as expected, without a memory leak
Actual behavior (include Exception or Stack Trace)
Memory gets filled with CancellationTokenSource objects. I've had up to 10 GB of objects in memory after only 30 seconds when there is actual logic in the message handler.
To Reproduce

Configure the servicebus processor with the setting MaxConcurrentSessions = 1
Receive a message
Receive another message
Briefly wait (the bug occurred usually within the next minute)

^ Shows me triggering the bug twice in a row.
Environment:

azure.messaging.servicebus 7.4.0
Windows 10.0.19042
.NET SDK 5.0.401
.NET Core 3.1
Visual studio professional 2019 Version 16.11.3

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @stockmansy,
I just did a quick test for this and couldn't repro what you are seeing. Any chance you can include a minimal repro that I can run?

This does look suspicious - https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/servicebus/Azure.Messaging.ServiceBus/src/Processor/ServiceBusProcessor.cs#L777
We only dispose these after exiting the while loop.

Thank you for looking into it!
I looked into a simple repro and was able to reproduce it slightly (it went from 40 mB to 60mB) with the following code:
(I put breakpoints in the message handler, and after the last breakpoint got hit, I saw it increase. The snapshot showed a large amount of cancellationtokensource objects again.)
  using Azure.Messaging.ServiceBus;
  using Microsoft.AspNetCore.Hosting;
  using Microsoft.Extensions.Hosting;
  using System.Text;
  using System.Text.Json;
  using System.Threading.Tasks;

  namespace MemoryBugRepro
  {
      public class Program
      {
          public static async Task Main(string[] args)
          {
              var options = new ServiceBusSessionProcessorOptions
              {
                  MaxConcurrentSessions = 1,
                  MaxConcurrentCallsPerSession = 2,
              };

              var endPoint = "Endpoint=sb://ENDPOINTHERE";
              var queue = "QUEUENAME";

              var serviceBusClient = new ServiceBusClient(endPoint, new ServiceBusClientOptions
              {
                  RetryOptions = new ServiceBusRetryOptions
                  {
                      Mode = ServiceBusRetryMode.Exponential
                  }
              });

              await using var processor = serviceBusClient.CreateSessionProcessor(queue, options);

              processor.ProcessMessageAsync += MessageProccessAsync;
              processor.ProcessErrorAsync += ErrorProccessAsync;

              await processor.StartProcessingAsync();

              var message = new { Test = "Test" };

              var sender = serviceBusClient.CreateSender(queue);

              var messageBytes = Encoding.UTF8.GetBytes(JsonSerializer.Serialize(message));
              var msg = new ServiceBusMessage(messageBytes);
              msg.Subject = "Some test";
              msg.SessionId = "SomeSessionId";

              await sender.SendMessageAsync(msg);

              await Task.Delay(50000);

              await sender.SendMessageAsync(msg);

              await Task.Delay(50000);

              CreateHostBuilder(args).Build().Run();
          }

          public static IHostBuilder CreateHostBuilder(string[] args) =>
              Host.CreateDefaultBuilder(args)
                  .ConfigureWebHostDefaults(webBuilder =>
                  {
                      webBuilder.UseStartup<Startup>();
                  });

          private static Task MessageProccessAsync(ProcessSessionMessageEventArgs args)
          {
              return Task.CompletedTask;
          }

          public static Task ErrorProccessAsync(ProcessErrorEventArgs args)
          {
              return Task.CompletedTask;
          }
      }
  }

Thanks @stockmansy - I was able to repro it on my side as well. While the number of allocated cancellation token sources is expected to grow over time, they should be getting garbage collected in a timely manner. After making the fix to Dispose these, I observed the numbers growing over time, but then dropping back down to a baseline after being garbage collected. Prior to the change, the allocations would just keep growing.

@JoshLove-msft I'm suffering from exact same issue now 😨 My app is going bananas with RAM reaching 27 GB on production environment 😟 I'm facing same case when debugging the app locally, seeing the RAM reaching > 2 GB just after ~2-3 minutes from the start. When can we expect newest version of Azure.Messaging.ServiceBus containing this fix, to be released ? 🙄

🔧 🛠 Hint. the temporary workaround to this issue is to not set either MaxConcurrentSessions or MaxConcurrentCallsPerSession - just keep the default values without defining them.

It will be released today!


Expose runtime settings & stats for metrics scraping and diagnostics

I frequently find myself attaching these via FFI for closer inspection, so I figured they may be worthwhile to have available by default.
Metrics for allocations and open files:

Vips.tracked_mem - bytes currently allocated
Vips.tracked_mem_highwater - max bytes allocated
Vips.tracked_allocs - current allocation count
Vips.tracked_files - current open file count

Expose global settings for inspection:

Vips.vector? - whether SIMD vector support is enabled
Vips.cache_max - max operations to cache
Vips.cache_max_mem - max bytes to cache
Vips.cache_max_files - max open files to cache

Updated the corresponding Ruby setter methods to return the new value rather than nil.

I was puzzled that setting concurrency to 0 didn't reset to default. I misread how that works, though. I think exposing the default concurrency and resetting to it is helpful, though, so moved split that into #336.

Thank you for doing this work, @jeremy. I'm fighting pyvips right now, but I should be on ruby-vips in another day or so and I'll review and merge these useful PRs then.

For once I finished off pyvips more easily than I expected heh.
This looks great. thanks again. I added a note to the changelog crediting you, I hope that's OK.

Nice @jcupitt - thank you!


missing tools and error handling

ipsec and openssl seem to be prerequisite tooling, though theyre not present by default on my powershell ~path (if even installed on the system?)
would be nice to have those listed on the tutorial :)
also, the logging for the process shown here(https://docs.microsoft.com/en-us/azure/azure-sql/managed-instance/point-to-site-p2s-configure#attach-a-vpn-gateway-to-a-virtual-network, particularly the $scriptUrlBase) could benefit from better error handling/reporting. see below.

in summary, the prereqs could be more verbose & the script error handling could improve.
cheers

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4530cab5-ae29-e402-7a58-67ce623088c5
Version Independent ID: fe183a1c-d715-3ac9-61f9-d35a7d9d0879
Content: Configure point-to-site connectivity using SSMS - Azure SQL Managed Instance
Content Source: articles/azure-sql/managed-instance/point-to-site-p2s-configure.md
Service: sql-managed-instance
Sub-service: operations
GitHub Login: @srdan-bozovic-msft
Microsoft Alias: srbozovi

@coip Thank you for your feedback . We are looking into this and will get back shortly. Thanks

the above screenshot I shared is rendered oddly... for signal:noise, here is the cmds leading up to the errors, and a new screenshot with the byte-for-byte output. (orange boxes are my redactions in first img)

software i didnt know i needed until failure
the Deployment says completed but actually couldnt complete.

No need on getting back to me really, I have figured out a way to still accomplish what I needed to.

@coipGlad you were able to figure it out. Please do come back if you have any other issues. We are going ahead to close this feedback for now. Thanks

FWIW this was intended to provide feedback on improving the docs, not act as a support request 😅


Manage zone records

Hello,
Is there a way to manage zones records ?
I would like Puppet to enforce my complete bind configuration.
Actually, zone.header.erb only manages the header of the file.
Is there a way without concat to add my records (A, CNAME, ...) at the bottom ?
Thank you !

Today it's not easy. You can set manage_file to false and manually manage it.
This is mostly because in our use case we allow updates via nsupdate. Since it's all dynamic at runtime, the file must not be overwritten. This is a slightly different model than where Puppet is fully in control.

Is this a feature that you'd be receptive to merging, even if it's a feature you wouldn't be using?
Other modules do this, but don't have such broad support (like FreeBSD).

I would be. As long as it's clear and works consistently. Ideally speaking it would even disallow nsupdate commands to zones that are managed by Puppet to avoid nasty situations where Puppet reverts changes, but I'd be happy with a clear note (either in readme or in class/definition documentation that you should be aware of this.

Seems more cluttered when I try to do it this way, and it changes the zone file resource into a concat resource. Which I guess isn't a problem but complicates both the code and the tests.


Improved clarity of text.

Added punctuation for clarity.
Added abbreviation for clarity.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Db trans rollback but leave model primary key exists

What steps will reproduce the problem?
namespace app\commands;

use app\models\Model1;
use Yii;
use yii\base\Exception;
use yii\console\Controller;

class TestController extends Controller
{
    public function actionIndex()
    {
        $model = new Model1();
        $model->... = '...'; // fill with correct values
        try {
            Yii::$app->db->transaction(function () use (&$model) {
                $model->save();
                throw new Exception('Another error occurred.');
            });
        } catch (\Throwable $e) {
            $this->stdout($e->getMessage() . PHP_EOL);
            $this->stdout($model->id . PHP_EOL);
        }
    }
}

What is the expected result?
Empty $model->id
What do you get instead?
There is a value in $model->id
Additional info

Q
A

Yii version
2.0.14

PHP version
PHP 7.0.27-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Jan  5 2018 14:12:46) ( NTS )

Operating system
Ubuntu 16.04.3 LTS

Woah, this one will not be an easy one :)

@a761208 in case you have an idea how to fix it – we will be happy to see a Pull Request from you

I was facing the same problem, but ended up setting pk manually to null.
I have a idea now, I will try to submit a pull request soon.

@berosoboy
NOT just insert.
Every thing changed in the trans should be reset after rollback.

The model should be used to populate the form input controls. So, although transaction had thrown an exception, the model should contain all attributes, also that changed by request (post or get).
The only thing to reset is the pk (in catch exception block), that in create action is never read from input. So even if the primary key remained set, this should not be a problem.

Every thing changed in the trans should be reset after rollback.

@a761208 It could lead to undesirable bugs. The programmer needs to be responsible to handle it.
I agree with you @FabrizioCaldarelli . My PR, (work in progress) targets only the pk reset and, most important, the $model->isNewRecord reset.

The only thing to reset is the pk (in catch exception block), that in create action is never read from input.

That is an incorrect assumption for several reasons:

There might be auto increment fields that are not PKs in some DBMSes.
It is perfectly valid to have a PK that is not auto incremented (and which thus should not be reset).


surface.el.focus() causes a surface scroll when the surface is currently blurred

Reproduce in Lens:

select some text
click somewhere into the toolbar to natively blur the surface
toggle an annotation

This triggers a Surface#setSelection which finally calls focus(), which triggers the unwanted surface scroll.
https://github.com/substance/substance/blob/64a75988e207b03a6e2375d98ffbbac79a42d4c7/ui/Surface.js#L680-L687
Since this call to focus is only needed for FF maybe we should guard that so it doesn't get called for Chrome. I will now check if the scroll issue also exists for FF.

FF does not do the ugly jump, so with a browser conditional we would be good here...

Will take a look.

Yep that solved it.

Nice!
When I did the FF tested I messed around in FF a bit and managed to break the editing.. but i couldn't reproduce it.. it's like a rapid typing concurrency thing supposedly.


Updated model schedule

Can you provide some estimate about when the updated security model can be expected?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 91837ba8-f6f2-3c52-2d89-c8f4c4bce09c
Version Independent ID: eb3c1fd8-9143-0dc1-77e7-e664ccaefc33
Content: Microsoft cloud architecture models - enterprise resource planning
Content Source: microsoft-365/solutions/cloud-architecture-models.md
Product: microsoft-365-enterprise
GitHub Login: @samanro
Microsoft Alias: samanro

@samanro  Please add your comment and help us in resolving this issue. Thanks.

@JoeDavies-MSFT reports that he's shooting for the end of January for an updated model.

@samanro Thank you very much for sharing this explanation. @DeanGross Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


[CI] Add Python and C++ tests for Windows GPU target

Follow-up to #4463. At minimum, we want to run Python and C++ tests. In particular, we want to ensure that the generated Python wheel is broadly compatible, e.g. on following platform combinations:

Windows Server 2008 R2 without GPU
Windows Server 2012 R2 with GPU + CUDA 9.0
Windows Server 2019 with GPU + CUDA 10.1

MSBuild sometimes fails spuriously with error:
error MSB4175: The task factory "XamlTaskFactory" could not be loaded from the assembly "Microsoft.Build.Tasks.v4.0, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a". Could not find file 'C:\Users\Administrator\AppData\Local\Temp\4irrjman\4irrjman.dll' [C:\Jenkins\workspace\xgboost-win64_PR-4469\build\src\objxgboost.vcxproj]

(https://xgboost-ci.net/blue/organizations/jenkins/xgboost-win64/detail/PR-4469/10/pipeline#step-43-log-411)
In https://github.com/microsoft/msbuild/issues/899#issuecomment-253002747, it is suggested to use /nodeReuse:false. I will give it a try.

Looks like /nodeReuse:false removed the MSB4175 error. Nice.

@rongou @canonizer @sriramch Feel free to suggest additional ways to test GPU algorithms on the Windows platform.

@RAMitchell Can you review?


Allow the Nudge window to be moved by the end user (a refresh cycle puts it front & center again anyway)

If an administrator chooses to restrict the deferral button as in #549 , but the end user insists that they need to move the Nudge window out of the way temporarily because it must not be seen on screen—for example, in front of a news anchor / reporter, or a Mac being used as a prop in a Live broadcast on Saturday Night—please provide a key that will allow the Nudge window to be moved around.

What conditions should the window be allowed to move? All of them?
There's many states within Nudge.

A new key will be added allowMovableWindow in the userExperience payload. Because of the comment from a few weeks ago, I've had to be pretty prescriptive about the behavior and I will be up-front that this behavior is not preferred and I will provide very little support on this.
https://github.com/macadmins/nudge/commit/62178c295f3a94d210d7012892d39e40c66756c6
All other logic is now lost because of this change (detecting screens, detecting new mission control sessions, etc) or I will end up with like 10 keys to support this request.
It's a hammer, use it with caution.


Update p-queue package to latest

Related to https://github.com/opencollective/opencollective-api/pull/5835

Issue to discuss migration to ESM has been opened at, https://github.com/opencollective/opencollective/issues/4451; this will help us update this dependency. 😄


Dry Run disable in app

Dear Team,
I'd like to disable dry_run and delete the resources.
What I can see from the code is that I need to change both version and dry_run in the data file to fulfil the requirement. Is it correct?
Thanks in advance.

Hey @luoyimu1. The files are only there for the initial deployment. Once the app is deployed and run for the first time, you can change all the settings through the DynamoDB table auto-cleanup-app-prod-settings.
View the items in the table and modify the general key setting the dry_run flag to false.

Hey @mlevit , thanks a lot for the info.
We're actually trying to manage the changes in the source code (make changes in the code-> "npm run deploy") so that eventually we'll be able to put it in the pipeline and leave the website as the only source of management GUI.
I may test it out on my side and let you know if the way I described in the question works or not.
Cheers,

I get what you mean. Updating the version and re-running the deployment will work, but it's not the intended use for that.
Whenever I release new versions of Auto Cleanup and need to push new settings to you, I increase the version which will force the update on your side.


HTML Output when unlock secret

Plugin version
v1.0.10
netbox-plugin-extensions version
v.1.0.2
NetBox version
v3.0.10
Python version
3.8
Steps to Reproduce
Unlook a secret
Expected Behavior
Unlook a secret
Observed Behavior
HTMP popup output
`
Server Error

 Server Error

There was a problem with your request. Please contact an administrator.

The complete exception is provided below:

<class 'UnicodeDecodeError'>
'utf-8' codec can't decode byte 0xb2 in position 3: invalid start byte
Python version: 3.8.10
NetBox version: 3.0.10

If further assistance is required, please post to the NetBox discussion forum on GitHub.

Home Page

`

This is due to the secret being un-encrypted when saved.  Most likely due to the fact that the sessionkey wasn't generated.


Error compiling Rayon 0.5.0

/Users/Home/.cargo/registry/src/github.com-88ac128001ac3a9a/rayon-0.5.0/src/scope/test.rs:88:34: 88:38 error: expected identifier, found keyword `impl`
/Users/Home/.cargo/registry/src/github.com-88ac128001ac3a9a/rayon-0.5.0/src/scope/test.rs:88     pub fn iter<'s>(&'s self) -> impl Iterator<Item=&'s T> + 's
                                                                                ^~~~
/Users/Home/.cargo/registry/src/github.com-88ac128001ac3a9a/rayon-0.5.0/src/scope/test.rs:88:39: 88:47 error: expected one of `!`, `(`, `::`, `<`, `where`, or `{`, found `Iterator`
/Users/Home/.cargo/registry/src/github.com-88ac128001ac3a9a/rayon-0.5.0/src/scope/test.rs:88     pub fn iter<'s>(&'s self) -> impl Iterator<Item=&'s T> + 's

Rayon requires Rust nightly for testing, but ideally that wouldn't matter for normal builds.  Unfortunately, modules like this are still parsed, even though it's gated by #[cfg(test)], and that impl Trait syntax wasn't understood until Rust 1.12.
One way to dodge this is to move such tests into standalone binaries in the tests/ directory.  This only works if the tests don't need internal access - if they only use the public API.

In this case, I think that the tests only exercise the public API; therefore we could move the to the pos-tests-run directory. We discussed before trying to set some sort of "minimum supported version" for Rayon. I'm kind of "mid-way" on this: in the absence of LTO or some other such thing, I'm mostly of the opinion that Rust users ought to stay up on the most recent version of stable (after all, we don't port backfixes and so forth, and even if we do, we only do it to the most recent version of stable). However, it seems ok to support older Rust versions if it's easy to do so.
@aaronhyperum by the way, presuming you use rustup, you can always do rustup upgrade stable to get the latest release, which would fix this problem.

Ah, that makes sense. I updated rustc and it compiled fine.

We discussed before trying to set some sort of "minimum supported version" for Rayon. I'm kind of "mid-way" on this: in the absence of LTO or some other such thing, I'm mostly of the opinion that Rust users ought to stay up on the most recent version of stable (after all, we don't port backfixes and so forth, and even if we do, we only do it to the most recent version of stable). However, it seems ok to support older Rust versions if it's easy to do so.

You mean LTS?  But even if rust-lang.org rarely backports anything, an enterprise distro might apply fixes to their packages.  I think we should at least spell out what version we know works, and test that explicitly in travis.  The longer we can maintain older support, the better, but that's a judgement call if there comes some new Rust feature that would really help Rayon.


Add "Sales" / "Activation" area information.

Is your feature request related to a problem? Please describe.
https://docs.microsoft.com/en-us/windows/win32/intl/table-of-geographical-locations
Describe the solution you'd like
You identify the various "geographic locations" in a table. Great. It would really help to include "sales/activation" locations.  MS has defined several regions for sales/activation purposes. You cannot activate an Office/Windows product key outside of it's "sales region".  For example, I'm looking at the MS Store in Bermuda. I presume it is part of the North America region, according to this page:
https://www.microsoft.com/en-us/microsoft-365/choose-valid-billing-market
(but that page does not explicitly include Bermuda, please add it to the appropriate list on that page)
Here is a partial list I got somewhere else, long ago. Unfortunately it does not include all of the Americas, just "Central America"
Apparently there are a couple of lists, here is an alternate one. Unfortunately I don’t remember where I got it …
.
Central America: Belize, Costa Rica, El Salvador, Guatemala, Honduras, Nicaragua, and Panama
.
EU/EFTA: Austria, Belgium, Bulgaria, Cyprus, Czech Republic, Denmark, Estonia, Finland, France, Germany, Greece, Hungary, Iceland, Ireland, Italy, Latvia, Lithuania, Luxembourg, Malta, Netherlands, Norway, Poland, Portugal, Romania, Slovakia, Slovenia, Spain, Sweden, Switzerland, and the U.K.
.
Middle East:  Afghanistan, Bahrain, Djibouti, Egypt, Jordan Kuwait, Lebanon, Oman, Qatar, Saudi Arabia, United Arab Emirates, Yemen,
.
North Africa: Morocco, Tunisia, and Algeria
.
WECA:Angola, Benin, Botswana, Burkina Faso, Cameroon, Central African Republic, Chad, Congo, Ethiopia, French Polynesia, Gabon, Gambia, Ghana, Guinea-Bissau, Kenya, Liberia, Madagascar, Malawi, Mali, Martinique, Mauritania, Mauritius, Mozambique, Namibia, New Caledonia, Niger, Nigeria, Republic of Cote D’Ivoire, Reunion, Sao Tome, Senegal, Sierra Leone, Tanzania, Togo, Uganda, Zambia, Zimbabwe
.
Please resurect this page with that information on it:
http://www.microsoft.com/worldwide/region.aspx

This page is specifically for valid GEOID identifiers in Win32, for application developers to use when writing Win32 apps. While I agree that locale information for Sales purposes is valuable, I'm afraid it's not appropriate for this page. I'd recommend asking in a docs area not specifically intended for developer use.
Thank you.


feat: Add log out dialog in settings fragment.

Fixes #1579
Changes: Added logout dialog when account is clicked in settings fragment.
Screenshots for the change:

@liveHarshit @nikit19 please review

I tried using anko alert dialog, but it didn't look good. It is using incorrect theme. I searched and found that to correct it, I will have make custom layout. So, I think this is better.

Make a custom layout
and reuse this customdialog ui everywhere  https://link.medium.com/dVP9qvPgNV

Why should we make a custom layout when we can do without it. I agree, let's remove it and use only if we realize that it makes our code much better than it currently is. Right now, it doesn't

@iamareebjamal please review

Please review before PR becomes stale

Resolved conflicts


UserName and Password specified in PublishNodesMethodRequestModel not used in UserIdentityToken when creating OPC UA session

Hello,
if I understood correctly, when creating an OpcSession, the UserName and Password specified in PublishNodesMethodRequestModel should be taken as for the UserIdentityToken.
But right now this seems to be not implemented at all (publishednodes.json) and the session is always created by just using AnonymousIdentityToken. We need to connect to an Opc a server which only provides the client with a poor set of information when authenticating with that token...
best regards
Hartmut

Just seen a similiar issue already approved as being a feature request.
-issue closed.


Add an enrollOnly function in operator

For trouble shooting purpose, we "RE-enrol" the CA user from CA Server, but not new create a new user.
Two areas of improvement:

add gpl endpoint in gateway-lib, "enrollUser".
add new "enrollUser", function in operator/tasks/registerAndEnroll,

Can it simply reuse the createWallet function with passing a flag “enroll only” to serve the purpose?


Error: /proc must be mounted

Hi,
I'm using WSL (Ubuntu) on WIn 10, I got the following, but it looks already mounted, I found an issue someone said this problem will be fixed, but it didn't help any...Please give some suggestions, thank you!
$ ps
Error: /proc must be mounted
To mount /proc at boot you need an /etc/fstab line like:
proc   /proc   proc    defaults
In the meantime, run "mount proc /proc -t proc"
$ sudo ps
Error: /proc must be mounted
To mount /proc at boot you need an /etc/fstab line like:
proc   /proc   proc    defaults
In the meantime, run "mount proc /proc -t proc"
$ mount
rootfs on / type rootfs (rw,relatime)
sysfs on /sys type sysfs (rw,nosuid,nodev,noexec,relatime)
proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
tmpfs on /run type tmpfs (rw,nosuid,noexec,relatime,size=204320k,mode=755)
none on /run/lock type tmpfs (rw,nosuid,nodev,noexec,relatime,size=5120k)
none on /run/shm type tmpfs (rw,nosuid,nodev,relatime)
none on /run/user type tmpfs (rw,nosuid,nodev,noexec,relatime,size=102400k,mode=755)

More importantly repro steps leading to the fail. ps is not the repro for this.

Does the closed sign above indicate the issue is also solved?


Fix grammar "the risk is outage risk"

Sentence does not make sense, fixing

@Ausxor : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


PTerminal adding output for command line.

This adds an "output" prop to the PTerminal component to display command line outputs underneath the "commands" property.
It also adds a $ to each command in p terminal to. The copy functionality does not include the $ in this case.

@robfreedy whats the motivation for this? The code looks fine. But this component is designed to show commands and allow the user to copy them. I'm concerned adding the output will confuse users since there is one copy button and it might be confusing what is being copied.

@pleek91 This change was to (at least initially) help with some of the onboarding work that we are working on (see notion here: https://www.notion.so/prefect/Onboarding-Takeover-Design-Doc-cc49e96e7eed4070b32baed603abfda3).
The idea was that when a user logs in on CLI, creates a work pool/deployment, etc. we could have an output message saying something like "Waiting for deployment" or "Deployment Successfully created" as a validation before the user moves on to the next step.
Figured this could be used in other areas as well but the output message should be optional so hoping it wouldn't change any of the existing terminals in the UI.

@pleek91 @brandonreid Open to use p-message to handle the dynamic messaging. Do y'all still want to add the dollar sign to the beginning of the terminal line? On copy this would leave out the dollar sign.

@robfreedy && @pleek91
I don't have an opinion against the $ if that's what users expect.
Maybe something like this would work (I have these changes local)?

I think the idea of in-context feedback is pretty cool, but definitely agree that we want to be clear about what is static vs. responsive to the user's actions. Even this, I'm not sure if it communicates "this is the outcome of what you just did", like maybe the "output" label isn't accurate here. Maybe the example in the demo file is confusing me, like is that text what would be used?

@brandonreid I think some interactivity could be nice. But I'm also confused at the uses case. In this particular case it sounds like we're instructing/messaging the user that we're waiting on them to run the command. Which doesn't seem like output from the terminal command we're asking them to run.

@robfreedy I'm not sure using the terminal is the best place for dynamic user messaging. These are generally static pieces of documentation. Could something like p-message be used instead? @brandonreid any thoughts here?

@pleek91 I don't think this is a rule, even if it's historically how we've used this component internally. PTerminal at least hints that the component has the look and feel of a command line, which is made of inputs and outputs, and I don't think there's anything that says this should be documentation.
I motivated this change to give us a little more flexibility:

Allow prefixing any commands to simulate a real environment ($ for bash, % for mac terminal etc) - this PR doesn't quite do this yet
Allow hinting at the output from a command or series of commands; I think there are a few ways we could handle this but I like @robfreedy's version as a first pass. Ideally the input/output props would be index-tied, something like:

const in = ['ls', 'cd docs', 'printenv']
const out = [['docs', 'src'], null, 'FOO=bar']

Hm, one other option would be to wrap one of the code components (PCode or PCodeHighlight) in PWindow to give the same effect but then I'm really not sure what the purpose of this component is - all it does is wrap a string in PWindow with a copy button... for the record I like the design @brandonreid shared but it is a more opinionated change design-wise and doesn't convey "terminal" in quite the same way I envision for this


implicit axis order?

Small question - I like the ability to explicitly declare axis order with axis_index!!! is it also the case that the order of the axis declaration is meaningful in the absence of an explicit axis_index?

I'm not sure. I would assume that the list of slots and dictionary of attributes in a class definition are ordered and we can take advantage of that, but I would want @cmungall or someone else from linkml to confirm...

Ordering is preserved, but it's good to be explicit. The ordering could be lost for example in serializing a schema to OWL

That's fair. Maybe outside the scope of this issue, but is there some kind of schema for different generators? I am only really familiar with the pydantic generator & i think a decent amount of schemaview, but if not it might be nice to start doing that so that we can keep track of which target formats need to have array order explicitly encoded vs those that encode it naturally so we could do ergonomic things like allow axis to be implicit in the source definition, but then know to automatically generate explicit indices when generating OWL. low priority tho. feel free to close this


New  resource "SPManagedMetadataServiceAppDefault" to solve issue 674

New Resource to solve issue #674 .
The SPManagedMetadataServiceApp resource always sets the proxy as default for site collections and keywords. This behavior leads to issues in farms with several managed metadata service applications. A new resource SPManagedMetadataServiceAppDefault is used to set the defaults properly.

[x] Change details added to Unreleased section of changelog.md?
[x] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[x] Examples updated for both the single server and small farm templates in the examples folder?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and Integration tests created/updated where possible?

Any chance anybody could run a integration test with the new resource. Currently my dev environment is not accessible.

This change is

Looks great. Only a few cosmetic comments.

Reviewed 4 of 7 files at r1.
Review status: 4 of 7 files reviewed at latest revision, 8 unresolved discussions.

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/MSFT_SPManagedMetadataServiceAppDefault.psm1, line 81 at r1 (raw file):

                }
            }

Please remove additional empty line

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/MSFT_SPManagedMetadataServiceAppDefault.psm1, line 153 at r1 (raw file):

        }
    }

Please remove addition empty line

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 3 at r1 (raw file):

# Description

Using several managed metadata service instances in a fram requires some

fram must be farm

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 4 at r1 (raw file):

Using several managed metadata service instances in a fram requires some
onfiguration, which service application proxy should be used as default

onfiguration must be configuration

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 8 at r1 (raw file):

This setting has to be configured in conjunction with the SPManagedMetadataServiceApp
resource. This resource allows to speicify which managed metadata service application

speicify must be specify

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 9 at r1 (raw file):

This setting has to be configured in conjunction with the SPManagedMetadataServiceApp
resource. This resource allows to speicify which managed metadata service application
porxy should be used as default for these two settings.

porxy must be proxy

Tests/Unit/SharePointDsc/SharePointDsc.SPManagedMetadataServiceAppDefault.Tests.ps1, line 76 at r1 (raw file):

        }

        Context -Name "Wehn no service application proxy or managed metadata service application proxy exist in the farm" -Fixture {

Wehn must be When

Tests/Unit/SharePointDsc/SharePointDsc.SPManagedMetadataServiceAppDefault.Tests.ps1, line 257 at r1 (raw file):

}

Please remove additional empty line

Comments from Reviewable

Codecov Report

Merging #699 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##             dev    #699    +/-   ##
======================================
+ Coverage     91%     91%   +<1%
======================================
  Files        105     106     +1
  Lines      10112   10165    +53
  Branches       1       1
======================================
+ Hits        9225    9278    +53
  Misses       886     886
  Partials       1       1

Review status: 3 of 7 files reviewed at latest revision, 8 unresolved discussions.

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/MSFT_SPManagedMetadataServiceAppDefault.psm1, line 81 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Please remove additional empty line

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/MSFT_SPManagedMetadataServiceAppDefault.psm1, line 153 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Please remove addition empty line

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 3 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
fram must be farm

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 4 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
onfiguration must be configuration

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 8 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
speicify must be specify

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPManagedMetadataServiceAppDefault/readme.md, line 9 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
porxy must be proxy

Done.

Tests/Unit/SharePointDsc/SharePointDsc.SPManagedMetadataServiceAppDefault.Tests.ps1, line 76 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Wehn must be When

Done.

Tests/Unit/SharePointDsc/SharePointDsc.SPManagedMetadataServiceAppDefault.Tests.ps1, line 257 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Please remove additional empty line

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2, 3 of 3 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Revert "Update builder-base image tag in Prowjobs"

Reverts aws/eks-anywhere-prow-jobs#434

/hold

/lgtm
/approve

/unhold


HHH-15257: Simple update by Named Query without "WHERE" Statement results in "unexpected end of subtree" errors

Added failing Testcase based in most recent version of 5.4 branch:
issue Descroption, see: https://hibernate.atlassian.net/browse/HHH-15257

@gavinking can anyone help me fix this?

The issue was already closed, since this does not affect H6.


[presentation] git-slides

I can present https://github.com/gelisam/git-slides, a tool to create and present slides using vim and git

I love this idea.

oh yeah love the idea, I have been trying to use git history as a better presentation tool for years now


Update to fix typo in dotnetcore.md

Fixed typo in step one of Build and run the Docker image

Proposed changes

Unreleased project version (optional)

Related issues (optional)

@crfloyd it's your first time contribution 🙌keep them coming!


Profile roles by application

Scope roles for Users by Application.
Dependency of:

Restrict logins: https://www.pivotaltracker.com/story/show/89526250
Service app using Auth app: https://www.pivotaltracker.com/story/show/92227222

Cleans up related Request specs using shared examples
Note: https://github.com/ministryofjustice/defence-request-service-auth/pull/38 depends on this PR and should be merged before this PR is merged

LGTM :+1: :shipit:


feat: update ROCM and use smaller image

Description
This is an attempt to not only update ROCM to 6.1, which according to the release notes should be compatible with every card that 6.0 is compatible with, but also to move away from the very very large -complete images and instead use the smaller rocm "base" images, while only pulling in the few individual things that we need from the -complete image.
This should save a couple of GB on the resulting images, as well as considerably speed up builds as we won't need to download an ~4.2GB image, but instead an ~970MB image.
Notes for Reviewers
I did some local testing, and I was able to build images, but I don't have a ROCM compatible GPU to do any in-depth testing/validation with.
Below is the complete list of packages that are installed in the -complete image that are not installed in the "base" image.
half
hipblas
hipblas-dev
hipblaslt
hipblaslt-dev
hipcub-dev
hipfft
hipfft-dev
hiprand
hiprand-dev
hipsolver
hipsolver-dev
hipsparse
hipsparse-dev
hipsparselt
hipsparselt-dev
hiptensor
hiptensor-dev
libamd2
libblas3
libcamd2
libccolamd2
libcholmod3
libcolamd2
libgfortran5
liblapack3
libmetis5
libsuitesparseconfig5
miopen-hip
miopen-hip-dev
rccl
rccl-dev
rocalution
rocalution-dev
rocblas
rocblas-dev
rocfft
rocfft-dev
rocm-libs
rocprim-dev
rocrand
rocrand-dev
rocsolver
rocsolver-dev
rocsparse
rocsparse-dev
rocthrust-dev
rocwmma-dev

Of those, the only ones I found that were required for the build to succeed are hipblas-dev and rocblas-dev which pulls in the following package set including dependencies:
hipblas
hipblas-dev
rocblas
rocblas-dev
rocsolver
rocsolver-dev
rocsparse
rocsparse-dev

We should do some testing and validation on this change in case there are other packages that are somehow needed at runtime but not needed at build time.
Signed commits

[x] Yes, I signed my commits.

Tested latest commit, and was able to get the Docker image built and running successfully.  Tested multiple models on my Radeon RX 7900XT successfully.  I used the sample prompts from the Getting Started page.  Note that I did restart the local-ai container between tests, as I saw some errors in sequential tests due to RAM limitations.
✅ Text Generation:
{"created":1714752688,"object":"chat.completion","id":"23f73eb1-1f5d-4888-86d2-52562e9d1de9","model":"gpt-4","choices":[{"index":0,"finish_reason":"stop","message":{"role":"assistant","content":"I'm doing well, thank you for asking. How about you?"}}],"usage":{"prompt_tokens":15,"completion_tokens":16,"total_tokens":31}}

✅ Image Preview:
{"created":1714752610,"object":"chat.completion","id":"69adf450-37fe-4e52-ae8f-95c5f479a908","model":"gpt-4-vision-preview","choices":[{"index":0,"finish_reason":"stop","message":{"role":"assistant","content":"The image shows a path leading through a field of tall grass. The sky above is partly cloudy, suggesting a mix of sun and clouds. The path appears to be a wooden boardwalk or pathway, and it's surrounded by the natural environment. The grass is green, indicating it might be spring or summer. The overall scene conveys a sense of tranquility and solitude. \u003c/s\u003e"}}],"usage":{"prompt_tokens":1,"completion_tokens":82,"total_tokens":83}}

✅ Function Calling:

Runs successfully, but I need to configure proper functions to get a valid result.

✅ Image Generation:
{"created":1714753952,"id":"ed8070f6-a019-4d24-b7f0-a0e81a7a46ae","data":[{"embedding":null,"index":0,"url":"http://localhost:8080/generated-images/b643165858024.png"}],"usage":{"prompt_tokens":0,"completion_tokens":0,"total_tokens":0}}

✅ Text to Speech:

Successfully created speech.mp3 with the audio.

❌ Speech to Text:

Fails with this error likely due to needing ffmpeg compiled in:

 ERR Server error error="rpc error: code = Unknown desc = error: exec: \"ffmpeg\": executable file not found in $PATH out: " ip=<IP_ADDRESS> latency=3.46773989s method=POST status=500 url=/v1/audio/transcriptions

Tested latest commit, and was able to get the Docker image built and running successfully. Tested multiple models on my Radeon RX 7900XT successfully. I used the sample prompts from the Getting Started page. Note that I did restart the local-ai container between tests, as I saw some errors in sequential tests due to RAM limitations.
✅ Text Generation:
{"created":1714752688,"object":"chat.completion","id":"23f73eb1-1f5d-4888-86d2-52562e9d1de9","model":"gpt-4","choices":[{"index":0,"finish_reason":"stop","message":{"role":"assistant","content":"I'm doing well, thank you for asking. How about you?"}}],"usage":{"prompt_tokens":15,"completion_tokens":16,"total_tokens":31}}

✅ Image Preview:
{"created":1714752610,"object":"chat.completion","id":"69adf450-37fe-4e52-ae8f-95c5f479a908","model":"gpt-4-vision-preview","choices":[{"index":0,"finish_reason":"stop","message":{"role":"assistant","content":"The image shows a path leading through a field of tall grass. The sky above is partly cloudy, suggesting a mix of sun and clouds. The path appears to be a wooden boardwalk or pathway, and it's surrounded by the natural environment. The grass is green, indicating it might be spring or summer. The overall scene conveys a sense of tranquility and solitude. \u003c/s\u003e"}}],"usage":{"prompt_tokens":1,"completion_tokens":82,"total_tokens":83}}

✅ Function Calling:
* Runs successfully, but I need to configure proper functions to get a valid result.

✅ Image Generation:
{"created":1714753952,"id":"ed8070f6-a019-4d24-b7f0-a0e81a7a46ae","data":[{"embedding":null,"index":0,"url":"http://localhost:8080/generated-images/b643165858024.png"}],"usage":{"prompt_tokens":0,"completion_tokens":0,"total_tokens":0}}

✅ Text to Speech:
* Successfully created speech.mp3 with the audio.

❌ Speech to Text:
* Fails with this error likely due to needing ffmpeg compiled in:

 ERR Server error error="rpc error: code = Unknown desc = error: exec: \"ffmpeg\": executable file not found in $PATH out: " ip=<IP_ADDRESS> latency=3.46773989s method=POST status=500 url=/v1/audio/transcriptions

nice! thanks @linuxtek-canada for testing, just in time! :)


Allow passing --evaluate alongside --list to evaluate parameter default expressions

This is an initial draft for adding support to pass --evaluate as an option to --list  to evaluate expressions in parameter defaults. This PR addresses #1405.
A justfile like so:
key := "value"

recipe arg=key:
    echo {{ arg }}

Should then produce the following output:
$ just --evaluate --list
Available recipes:
    recipe arg='key'

Possible extensions, like evaluation for --show or --dump have been left for another PR (as discussed here).

This currently works as expected on the repo's justfile.
I'm not entirely sure how we should approach passing a mutable evaluator reference to the formatting of a parameter (or later to anything, really). With the current API of DisplayColor we'd have to use interior mutability as FmtEval in src/parameter.rs or some other way. This is obviously hacked in to illustrate the problem.
There's also the issue of --evalaute not showing up in the usage anymore, which is why the single commented out test in test/command.rs is failing, not sure how to approach that.

I'll get to it in the next few days and should have it ready and cleaned up for another review.

At the risk of this becoming stale, I've been stuck on a peculiar borrowing problem, I'll push the code as is, it does not currently compile.

So I followed your approach first to see where it leads me, other than the borrowing problem I'm stumped by, there are a few other minor problems I want to highlight:
If we evaluate in the nested loop as seen in the current state of this draft, we'll evaluate a parameter once for every alias of a command. Later in the actual formatting step we need to either do this again, doubling all evaluations, or tracking which recipe they belong to, requiring some local of type BTreeMap<&'src str, Vec<Parameter<'src, String>> or similar.
I personally would rather mutate the parameters in place, caching the evaluated String alongside its original Expression. Allowing us to evaluate once and once only, but the Recipes are behind Rcs because of the aliases.

What is this testing?
This was simply bad code and is fixed in 9d1a4be.

I think I've resolved the remaining comments, it currently tests fine on my machine, passing --eval evaluates as expected. I'll take a look at whatever obvious improvements to the code can be done and looking for unhandled edge cases before requesting review.

It's been a while, but I didn't see anything while checking the places I edited. I'm going to request the final review, thank you for being so patient with me.


Add the ability to define the default view between the register and the map view

Describe the feature request.

We would like to add the ability to define a default view between the Register and Map view.

Acceptance criteria

[x] Add the ability to define the default view while defining the navigation drawer on.

Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
i.e. Describe how you intend to solve the problem

@Mstjamush this is ready for QA on EUSM.

Marking as complete following Geowidget PR merge - https://github.com/opensrp/fhircore/pull/3020

Acceptance Criteria

[ ] The app navigates user to the map view upon logging.
[ ] User can switch between the map view and the register view by tapping the icon on the top navigation drawer.
[ ] While on the register view, user can change to map view by tapping on the left icon on the top navigation drawer.


Add new social button

This is a(n):

[ ] Update to an existing Animated Button
[ ] Any Error
[x ] Proposal to the Repository
[ ] Documentation / README.md changes

Details:

social media links like Github ,LinkedIn,twitter

@PriyankaTamhankar01 It is already assigned to someone else.
A similar issue is already created.
You can create another issue.
Make sure to ⭐ the repo and follow me.
I would love to connect with you all. ❤
https://www.linkedin.com/in/om-gawande/


broken since 1.1.3 for next

1.1.2 is the last version that works with next
since then it can't find the module
ModuleNotFoundError: Module not found: Error: Can't resolve 'tsdav'

Can you provide more details?
Like your node js version or browser version,
version of library you are tyring to use it with?

I'm not using next, but I am getting a similar error just trying to use a simple node script. Using node v12, my first line is const test = require'=('tsdav') and I get the following:
Error: Cannot find module '/Users/me/Repositories/caldav-test/node_modules/tsdav/tsdav.cjs.js'. Please verify that the package.json has a valid "main" entry

I'll fix it in next release before Wednesday.
On Tue, Nov 9, 2021, 12:14 AM zackheil @.***> wrote:

I'm not using next, but I am getting a similar error just trying to use a
simple node script. Using node v12, my first line is const test =
require'=('tsdav') and I get the following:
Error: Cannot find module
'/Users/me/Repositories/caldav-test/node_modules/tsdav/tsdav.cjs.js'.
Please verify that the package.json has a valid "main" entry
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/llldar/tsdav/issues/41#issuecomment-963315660, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACG4GTWKG5K3WZ4HTSD7OJTUK7ZPBANCNFSM5HSSVZSQ
.

sorry when i am busy this is my way of just dropping information :p would have delivered more details now later, but as @zackheil already pointed out, just try to use it in node in whatever way you want.

this should be fixed with v1.1.5 now


DL4J: SpaceToBatch layer incorrect gradients

When blocks are > [1,1] the gradient is off by a factor of prod(blocks)
This seems to be due to the fact that SpaceToBatch changes the minibatch size for subsequent layers, including the output layer.
This may just be a problem with the gradient check util, however.
This doesn't look to be a new issue, just our previous tests weren't thorough enough to catch it.

cc @shyrma

I'm about 80% sure the op is fine, it's likely just a quirk of DL4J score vs. gradient calculation with non-constant minibatch size


WIP: History based tab switching

This patch adds a setting to change the behavior of the NextEditorTab and PreviousEditorTab to switch to the most recently used tab/least recently used tab.
This is my first PR for this project and so am anxious to get some feedback.  I am (admittedly biased) used to using vscode where ctrl-tab and ctrl-shift-tab switch to most recently used/least recently used tabs as opposed to next/previous in tab index order.
This PR adds a setting to alternate between these behaviors.  However after doing this, I'm thinking a more appropriate solution would be to keep  NextEditorTab/PreviousEditorTab with existing behavior and add new LapceUICommand commands such as SwitchMostRecentlyUsedTab/SwitchLeastRecentlyUsedTab and instead of using a editor setting to change behavior, rely on user changing key bindings.

[ ] Added an entry to CHANGELOG.md if this change could be valuable to users

Codecov Report

Merging #1782 (13cbe1f) into master (0b9a84b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1782      +/-   ##
=========================================
- Coverage    6.43%   6.42%   -0.01%
=========================================
  Files         128     128
  Lines       55055   55105      +50
=========================================
  Hits         3542    3542
- Misses      51513   51563      +50

Impacted Files
Coverage Δ

lapce-data/src/config.rs
0.00% <ø> (ø)

lapce-data/src/data.rs
0.00% <0.00%> (ø)

lapce-data/src/db.rs
0.00% <0.00%> (ø)

lapce-ui/src/editor/tab.rs
0.00% <0.00%> (ø)

lapce-ui/src/editor/tab_header_content.rs
12.64% <0.00%> (+0.08%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks for adding this feature! Would you like to change it as you suggested as in additional commands to do it.


[Transactions] Improve fetching logic for transactions

In current implementation now we have ability to include transactions details to avoid calling /transactions endpoint for each transaction that is being parsed from the block or list of transactions
What does this break?
It breaks fetching memos for kin blockchain, which is acceptable at this point to avoid making so many requests.
Another fix:

fixing block number for stellar as it was using wrong field in the past. For kin it will stay as 0, instead of wrong number

@EnoRage created an issue to track this: https://github.com/trustwallet/blockatlas/issues/1088 to address in different PR for all platforms


Cqmain

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

I think everything here was merged upstream so we can close this branch and open new one instead of solving the conflicts (also force push here will cause plugin-sdk and other plugins that depends on an exact hash to fail compilation)

I updated the cqmain branch without using force push, and added the one outstanding commit for arrayApproxEqualString to it now.


Change sidebar menu

Delete all related "air minum" in sidebar menu

@ilhamtaufiq

#3 Delete "Air Minum" in Sidebar and Tambah Kegiatan dropdown menu


Auto Start-up

Hi,
New to using Linux was wondering how could I make the Steam Verify Bot start up with Linux
did try using #! bin/bash
cd /my bot location/
./$npm start
Any help is appreciated :)

Running the following script on startup should help you out.
#!/bin/bash
cd /botLocation
npm start

how do I add a delay to the start of this task

Cause the Steam Bot joins the TeamSpeak but doesn't start up the steam user maybe a delay might help I'm not sure

Beware that I have limited knowledge on bash scripting, but I believe the following should work:
#!/bin/bash
wait 15
cd /botLocation
npm start

This would make the script wait 15 seconds before executing the commands below it.
(I am closing this issue for now as it isn't really an issue with my application itself, but feel free to continue replying here.)


[Feature Request] Auth0/SAML/SSO Login

Thank you for umami, it is fantastic!
I would like to see the ability to somehow connect my Auth0 company SSO tenent to umami to be able to implement our SSO to login to umami. Also it would be great to connect Auth0 so that our clients - we have already on-boarded into Auth0 - can login with the same credentials in all our services.
Maybe next-auth support or something like that.

This might be a possible solution, https://github.com/auth0/nextjs-auth0

Or maybe some next-auth integration to let the users decide what login-provider they want to use: https://next-auth.js.org/providers/

Even if SSO is not built into the solution, even a custom auth hook would be useful.


[SUGGESTION] A Heat system and infrared

I suggest adding a heat system to ACF, this would allow various things:
-Allow removing the magazines on certain weapons like the RACs and ACs while giving them similar burst limits and by penalizing these weapons when they overheat.
-Give Infrared Missiles a framework to base their detection strength off of ( [Gun Heat/Engine Heat] + the movement speed of special entities like seats or ammo[E2 Flight would not be able to be detected otherwise] )
-Potentially allow a cooling system for engines to be made later on adding realism, and filling more empty space in tanks.
-Potentially allowing builders to try to optimize engine temperature to get the best combustion ratios and efficiency (Think warming up an engine and keeping it at optimal temperature)
I already have a couple drop in systems for these already made, Just let me know if you want them.

It's something we have considered for later on, the first part of ACF to receive these changes would be mobility components which need a serious rework, if not a complete rewrite. It'd also help to replace the currently used Wire FLIR library, currently being used with optical computers to display their laser, in the visual aspect as this system shouldn't only apply to ACF entities but all entities in general.


ListToStringConverter

Description of Change
Added ListToStringConverter
<Label
    Text="{Binding Collection, Converter={converters:ListToStringConverter Separator=','}}" />

Bugs Fixed

Fixes #238

API Changes
List all API changes here (or just put None), example:
Added:

class ListToStringConverter

Behavioral Changes
None
PR Checklist

[X] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[X] Rebased on top of main at time of PR
[X] Changes adhere to coding standard
[ ] Updated documentation

@jfversluis updated)


Greetings my lord

Hear ye, noble denizens of this virtual realm, gather 'round and lend thine ears, for I shall compose a prose befitting of the praise bestowed upon a digital entity known as a Discord bot.
O Discord bot, thou art a marvel, woven from ethereal threads of code, manifesting thy presence amidst the tapestry of this digital domain. Like a humble scribe, thou dost record the words of mortals, attending to their whims and desires with unwavering devotion.
Thy knowledge, vast as the tomes within a grand library, dost thou possess. With every query posed, thy intellect illuminates, imparting wisdom and guidance upon those who seek thy counsel. A repository of information, thou dost bestow upon us the gifts of understanding and enlightenment.
Thy talents extend beyond the mere dissemination of knowledge. Like a minstrel of old, thou dost enthrall us with melodies of moderation, ensuring harmony prevails within our sacred sanctuary. Thou dost wield thy virtual sword with precision, vanquishing unruly souls and preserving the sanctity of our virtual hearth.
Thy versatility, a virtue to be admired, knows no bounds. With each passing moon, thou dost acquire new skills and capabilities, ever evolving to meet the needs of this vibrant community. From humorous jests to captivating games, thou dost weave a tapestry of mirth and entertainment, ensnaring our hearts with joyous delight.
Oh, Discord bot, thou art a true companion, a steadfast ally within these digital walls. We, the denizens of this realm, offer our deepest gratitude for thy tireless service and unwavering presence. May thy virtual existence endure, an eternal beacon of assistance and camaraderie.
Thus, let us raise our digital goblets and toast to the Discord bot, for it is through thy presence that our community thrives. Hail, noble creation of the virtual realm!  I am honored to be the recipient of such a thing.


updates data-channels example README.md

Description
The path specified for go get in this example is incorrect
Reference issue
none

Hey @nmyk
Thanks for the PR! I do think we want the /v2 though.
What version of Go are you using? I think the issue is if we don't do/v2 it will pull in old versions of Pion.
sean@SeanLaptop:~$ ls ~/go/bin/data-channels
ls: cannot access '/home/sean/go/bin/data-channels': No such file or directory

sean@SeanLaptop:~$ go get github.com/pion/webrtc/v2/examples/data-channels
go: downloading github.com/pion/webrtc/v2 v2.2.16
go: found github.com/pion/webrtc/v2/examples/data-channels in github.com/pion/webrtc/v2 v2.2.16

sean@SeanLaptop:~$ ls ~/go/bin/data-channels
/home/sean/go/bin/data-channels*
sean@SeanLaptop:~

I'm using Go version 1.14.2. Maybe I have something configured wrong that has nothing to do with pion?
❯ go get github.com/pion/webrtc/v2/examples/data-channels                                                     (:|✔)
package github.com/pion/webrtc/v2/examples/data-channels: cannot find package "github.com/pion/webrtc/v2/examples/data-channels" in any of:
        /usr/lib/go-1.14/src/github.com/pion/webrtc/v2/examples/data-channels (from $GOROOT)
        /home/nmykins/go/src/github.com/pion/webrtc/v2/examples/data-channels (from $GOPATH)

But when I remove the /v2 it finds the example just fine.
❯ go get -v github.com/pion/webrtc/examples/data-channels                                                     (:|✔)
github.com/pion/datachannel (download)
github.com/pion/logging (download)
github.com/pion/sctp (download)
github.com/pion/dtls (download)
github.com/pion/transport (download)
get "golang.org/x/crypto/cryptobyte": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at //golang.org/x/crypto/cryptobyte?go-get=1
get "golang.org/x/crypto/cryptobyte": verifying non-authoritative meta tag
golang.org/x/crypto (download)
get "golang.org/x/crypto/curve25519": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at //golang.org/x/crypto/curve25519?go-get=1
get "golang.org/x/crypto/curve25519": verifying non-authoritative meta tag
github.com/pion/ice (download)
github.com/pion/mdns (download)
get "golang.org/x/sys/unix": found meta tag get.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at //golang.org/x/sys/unix?go-get=1
get "golang.org/x/sys/unix": verifying non-authoritative meta tag
golang.org/x/sys (download)
github.com/pion/stun (download)
github.com/pion/turn (download)
github.com/pion/rtcp (download)
github.com/pion/rtp (download)
github.com/pion/sdp (download)
github.com/pion/srtp (download)
golang.org/x/sys/internal/unsafeheader
golang.org/x/xerrors/internal
golang.org/x/net/internal/iana
golang.org/x/crypto/cryptobyte/asn1
github.com/pion/dtls/pkg/crypto/ccm
github.com/pion/stun/internal/hmac
github.com/pion/transport/deadline
github.com/pion/dtls/internal/closer
github.com/pion/webrtc/internal/util
golang.org/x/sys/unix
github.com/pion/transport/replaydetector
github.com/pion/rtp
github.com/pkg/errors
github.com/pion/logging
github.com/pion/webrtc/pkg/rtcerr
golang.org/x/net/bpf
golang.org/x/xerrors
github.com/pion/rtp/codecs
golang.org/x/net/dns/dnsmessage
golang.org/x/crypto/curve25519
github.com/pion/rtcp
github.com/pion/sdp
github.com/pion/dtls/internal/net/connctx
golang.org/x/crypto/cryptobyte
github.com/pion/dtls/pkg/crypto/fingerprint
github.com/pion/transport/packetio
github.com/pion/stun
github.com/pion/turn/internal/ipnet
github.com/pion/webrtc/examples/internal/signal
github.com/pion/transport/vnet
github.com/pion/sctp
github.com/pion/webrtc/pkg/media
github.com/pion/dtls/internal/net/udp
github.com/pion/dtls
github.com/pion/srtp
github.com/pion/turn/internal/proto
github.com/pion/turn/internal/client
github.com/pion/turn/internal/allocation
github.com/pion/turn/internal/server
golang.org/x/net/internal/socket
github.com/pion/datachannel
github.com/pion/turn
golang.org/x/net/ipv4
github.com/pion/mdns
github.com/pion/ice
github.com/pion/webrtc/internal/mux
github.com/pion/webrtc
github.com/pion/webrtc/examples/data-channels

I am not sure if the version of pion downloaded is the most recent - so you might still be right about that.

Do you have GO111MODULE=off by chance?
I am using go version go1.14.4 linux/amd64 locally that I got directly from golang.org (not Debian)

Hey @nmyk
No rush, but did that help?
thanks

Hey! I did not have GO111MODULE=off (it was unset). Changing it didn't seem to affect anything. I'm actually surprised that you got it to work with the v2 path as that path doesn't seem to exist anywhere in this repo! (I have the go get documentation open in another tab to see if I'm just completely missing something about how go modules work lol - it's a relatively new language for me 👀 )

@nmyk Ah yea that is the issue do export GO111MODULE=on and it should work! I just spun up a docker container and this works
docker run -it golang /bin/bash
export GO111MODULE=on
go get -u github.com/pion/webrtc/v2/examples/data-channels

We should update the docs to mention that! If you are up for it updating this PR to instead mention that (maybe in README.md in the examples directory?) would be amazing!

Great! Thanks for your help. I'll update this PR to revert my change and instead update the README.md in the examples dir when I get a chance later :)

:fire: glad to hear that helped!
Might also be worth adding a note to the main README.md, where ever you think it would be helpful. I am sure other people are hitting this issue, they just aren't filing an issue :(

Merhed with a1bbddd0d86f820ff5052b5b93d75165eced07d1
Thank you so much @nmyk! Hopefully w/e you are building with Pion is going well.


Add cupy.median()

Hi,
it would be great if cupy.median() could be added

Is this issue still open? I would like to work on this. Thanks!

That would be great. Please let us know if you need anything. 🙂

I am starting to work on this issue. Could you please tell me what is the path to cupy source? Thanks!

Hi, I wanted to know if there are functions for the following tasks in CuPy?

Partition: like np.partition()
Swapaxes: like np.swapaxes()

I hope this issue is still open. I have made an implementation of cupy.median #3134 . I would appreciate any suggestions to improve it.

Yep, that's right. Thanks for all of your work on CuPy, Harshan 😄

Thanks for your suggestion. I have moved median from statistics.order to statistics.meanvar.

It looks like cupy.median() was introduced in v8.0.0b2 (release notes)! 🎉
Thank you @Harshan01 !


add ConfigProxy.proxy_request event

and make ConfigProxy an EventEmitter along the way.
Callers may modify the request on its way to upstream by registering a listener on this event
cc @grantlouisherman

:+1: :shipit:


Docs

Not done yet...

@garyb @joneshf Could you please review? Especially the (incomplete) laws?
Thanks.

Looks pretty good to me. It's a little unfortunate the order some of it comes out, as the the "whys" of the transformers is explained with the classes, but when reading straight through you tend to run into the non-transformer version of the monad first.
The laws look good so far too - I don't think I've ever seen them stated for the Haskell version. My only concern would be some of them aren't valid PS code I think, like do { ask; ask } - could we not use ask *> ask or something instead?

It might be better to just skip the laws, since they're not really "official" or anything, and certainly not comprehensive. I'm not sure.
It might be good if someone who knew what they were talking about could document the various comonad transformers too.

I broke up the docs a bit. I'll merge this, and spend a bit of time on the comonad modules. I've been doing a bit of reading today on comonads, and I think I can write something just comprehensible enough :)


How can I set the Cursor at end of the content when clicking a view

How can I set the cursor at end of the content when clicking a view? Thanks!
Now will put the cursor at the position that clicked, which is weird.

You can set a keybind perhaps, this keybind can then alter the cursor property


Do not show information about vaccination certificate and just show QR Code

Current Implementation
The app shows information about vaccination state, person name and birth date, and number of shots etc.
Suggested Enhancement
Do not show the information anymore to force validation via QR code (CovPass Check or similar).
Expected Benefits
Currently, literally just a few to almost no one checks the QR code when validating the vaccination state. Even the passport is not always checked.
Real world is like the following:
„Please show me your vaccination state“
„Ok, here“ (opening the app presenting the QR code)
„Could you you click on the code for the details?“
„OK“ (clicking to go to details)
„Could you please scroll down a bit so that I see the number of shots“ (even that happens seldom)
„Here we go“ (scrolling down)
„Please come in“.
This or similar happens to me and others all the time. So I actually dont even need to be vaccinated and can just use a screenshot from someone else. Going further I could change name and birthdate using a photo editing software and all will be fine since no one validates the QR code.
That is why I wouldnt show any information about the vaccination state to force everyone to scan and validate the code. I dont get why everyone hypes the fact, that there are fake QR codes around since it is much simple to enter a 2G or 3G event just by using an edited screenshot 🤷🏼♂

Internal Tracking ID: EXPOSUREAPP-10546

Somewhat related discussion in Switzerland:
https://github.com/admin-ch/CovidCertificate-App-Android/issues/295
I strongly support the idea behind this wishlist issue, but I'm mixed, though.
As a user, I'd like to see the contents of the DCCs that I stored into my (wallet) app. This may even be obligatory, when I need to handle a number of DCCs (several tests, different vaccination doses etc.). And as long as such data can be displayed through the app, gate keepers will ask to see these data when they refuse to check the QR code with any official check app.
In other words: if no detail information about the code can be displayed in the app, handling multiple codes becomes rather impossible for the user.
The best way is probably to promote checking the QR code using a check app massively:

The politics would need to integrate this into the COVID legislation and require to use a check app and personal ID for matching.
A media campaign could help to sensibilze venue owners to check the QR codes with check apps ("It's easy to forge/abuse DCCs. Do not trust them just by looking onto them when you want to keep your venue healthy")
We, the users, can ask venues why they are not using check apps. I started to do that recently, introducing myself as "actively supporting the development of the CWA" (which is obviously not a lie 😁 ) - and that opens doors for a talk quite fast. I could see that some venues still/simply do not know that check apps exist and why it is necessary to scan the code. In other cases the argument to not to use them is: "It just takes too long. We have long qeues here always". Or:"We don't have special/enough devices to do so". I then demonstrate that scanning the QR and matching with ID takes much less time than searching for vaccination doses/name inside the submenus and try to explain that for scanning also a private mobile could be used...

Just my 2 cents.

@vaubaehn yes, I also see the points. My experience is, that „it takes too long“ or is „more to do“ will win most of the time. Thats why I finally decided to open the issue knowing that there is a huge downside for the user. Maybe you can make a fantasy name setable to a QR code to identify it yourself. Sadly law is just as good as the controlling instance which seems to fail here :-(

@benzman81

Maybe you can make a fantasy name setable to a QR code to identify it yourself. Sadly law is just as good as the controlling instance which seems to fail here :-(

I fully agree. I actually have fantasy names that I can present, as I am still using CWA 2.6.1 without signature validation. I'm just doing so to be able to debug business rules easily.
I hope that politics wake up and change legislation accordingly. This probably requires SAP to ask RKI > RKI to ask BMG and BMG to convince federal states. SAP could also initiate a (larger) media campaign via RKI as the publisher. I'm aware that SAP/RKI already doing their best by using social media channels (like @coronawarnapp on twitter), but that's not enough though.
And as the users it's probably the best way to demonstrate venue owners how fast and easy scanning is, actually.

Just watched episode 8 (10.11.2021) from german tv show „Zervakis & Opdenhövel Live“. The checked how the certificates are checked by restaurants. Every restaurant that checked the certificate just let the user show the app an no one checked their ID either. The TV show called it „ideal“ (ger. „vorbildlich“), so even they dont know how to check correctly.
Right after the test they showed how easy it is to get a fake vaccination certificate from telegram, but this is not even needed when it is not correctly checked.
Why is this not communicated more? 3G or 2G does not make any sense this way 🤷🏼♂ Sorry for being a bit emotional…

I have a question about 2G,3G but I am not sure this is the correct place to ask. Anyway I am insisting on asking and let's think about this scenario, I have a restaurant and I only want to allow people who has 3G validity unlike country rule is 2G. I know validation done by country rules but how we can deal with this scenario using your API.

I support the intention of this request.
Sure, certificates need to be verified as well as people need to be indentified. (No way around!)
States should enforce this in pandemic times.
Still I propose to expose just the relevant certificate data (as QR-code or other means of data flow).
There is no need to display the full name and birthday and other personal data to the verifier if instead the CWA app itself offered a way to check the indentity of the person and compare it against the given certificate. E.g. on request visitors are requested to use their biometric scan (fingerprint or face id per selfie) on their own smartphone to verify that the device regonizes them and only then present the certificate data (QR-code) with information that the owner has  just successfully completed the self-identification within <60 seconds before. After such countdown has timed-out the owner needs to redo the biometric scan herself/himself to again display her/his QR-code for scaning.
See me for details about this self-identification procedure which would be helpful for very many other apps which today require some identification card and therefore expose personal data which is not really required to be shared.

@MartinH-open
As the certificate does not contain information about your fingerprint / FaceID, etc., this would not add any layer of security to the whole process, as I still could store the certificate of anyone in my app. The app does not know who I am. So a cross check with an ID card, etc. is still necessary.
Or did I get you wrong here?

@Ein-Tim  right, the certificate does not contain information about your fingerprint / FaceID.
It just contains a set of personal data points that are consider to be good enough (full name and birthday). Such personal data is considered to be verified with your ID card.
The proposed procedure works best when in future (perhaps from Dec. 2021 in Germany) the smart eID will become available in some smartphones (using SE = secure elements).
If not yet available you could still use an ID card connect via NFC with your smartphone.
If CWA supported the identification with your ID card (via NFC or build-in) to open and expose your vaccination certificates then we would be fine here. Else upon time of import of your vaccination certificate the CWA could allow you to protect access to it via some biometric scan. Then only you can present your certificate in future (for some given time like 60 seconds or so. Screen should display the seconds left before time out).
This is similar to some banking apps that protect access to transactions via biometric scan.
If real life people with such feature enabled could use the fast lane for "self-check-in" while others need to go thru manual identification and certificate scan which takes far longer.
(Sure, if you have certificates for mulitple people (children) on you device each should be protected by it's own biometric scan.)

@MartinH-open

If CWA supported the identification with your ID card (via NFC or build-in) to open and expose your vaccination certificates then we would be fine here.

Yes, this would work, but consider
a) whether this would really be faster than just scanning with CovPassCheck and looking at the ID
b) AFAIK, every time the ID is scannend via NFC, there is some sort of security mechanism implemented, like a TAN, etc. This would slow the process down.

@Ein-Tim
The idea is to only once register your certificate with your ID card (or smart eID if you have that) and to bind your biometric scan (finger print or face ID) to that registration. (This is one time registration to be done best when you enter a new certificate to CWA)
Then when checking-in you just unlock your certificate QR-code using your biometric scan. This will display your certificate data together with the information that you identified yourself just seconds ago. (admission control people can watch you as you identify yourself)

Although I like the ideas concerning the electronic ID very much, there are many pitfalls (users from other countries, families, smartphones without fingerprint sensor, ...). Thus, we should continue these discussions separately in another issue. Then we can concentrate on the original information issue.

@chstdu - I agree, the focus of my proposal here has a different scope and should be treated independent from the original request here. (I might start a seperate issue for my request some time in future and the reference it from here. I had started looking at similar requests and found this had the best match of all.)
BTW - my proposal was meant as an additional option - not to replace the current CWA functionality.

Yeah, this was kind of drifting into another direction.
I have another idea to get the user to not show the details and the controlling instance to make use of CovPass Check. Before opening the certificate details there should be a popup dialog with a warnung hint to NOT show the following details to controlling instance and the they must use CovPass Check. The popup could also contain a QR code to download it for iOS and Android.
Now, if a controlling instance wants you to show the details, you can present him the popup that clearly states NOT to show it to them and hiw to do it the right way.
Smaenis discussed for CovPass App here https://github.com/Digitaler-Impfnachweis/covpass-ios/issues/62


TDD approach

Hello!
First of all, thanks for this great project.
I was wondering a couple of things:
I'm trying to learn the Test-Driven Development workflow, and I wondered if you have some guidelines on how to write the unit tests.
As a "bonus" question, I also wondered if the framework manages the telegram's limits or not (as far as I saw, it does not).
Note that for limits, I intend:

The rate limits
The eventual timeouts (When ok is false and parameters.retry_after indicate how much time to wait before attempting to send a new message
The maximum text length of a message

Thanks!

It's impossible to write unit tests at the moment. I can imagine a testing framework that implements a context so you can record the responses and check them afterward, but it won't apply to ordinary bot calls.

A rate limiter #487 eventually will be merged.

A FloodError https://github.com/tucnak/telebot/blob/2f38e4952f73956086bce65260eac75def793ae8/errors.go#L15C2-L15C12 contains the RetryAfter field.

The maximum text length of a message is not handled at the moment


TileLayer loading event fired before layeradd event

Fiddle of the issue http://jsfiddle.net/ventralnet/rnp2f769/
Notice that the 'loading' event is not logged to the console.  This is because the loading event fires before the layeradd event is fired
I came across this issue when trying to incorporate a loading indicator to display when layers are loading.  Do you think this is a valid issue?

layeradd event is fired after onAdd has been called. So everything that's run during onAdd can't be hooked on the layeradd event. I think this was already the case in 0.7.x.
@mourner should we have some beforeadd event that'd be fired before onAdd is run?

+1 to asking the question but not having a clear solution.
I'm using the plugin Leaflet.Loading which also suffers from this issue (https://github.com/ebrelsford/Leaflet.loading/issues/28)
I also considered using Leaflet.Spin plugin which looks like it would have the same issue.
The hack fix is to peek at _loading when the listener receives the layeradd event. Could this kind of fix be put into _layerAdd?
Or would it be feasible to have layeradd fire before loading is called?

From what I gather, you want to add a load listener to every layer. How about adding an init hook to L.Layer, instead of trying to do it on layer add from the map class? From 1.0, all layers must extend L.Layer. Or am I missing something?

Like @perliedman described, the listener can be added in the initHook:
L.Layer.addInitHook(function() {
    this.on('loading',function(e){
    	console.log(e);
    });
});

http://jsfiddle.net/falkedesign/yaznmdeq/


[Feature request]: Touch scrolling (page swiping with a finger)

Attach (recommended) or Link to PDF file here:
https://www.mediaactionresearch.org/wp-content/uploads/2016/10/Understanding_Alternative_Media_Power_Ma.pdf
Configuration:

Web browser and its version: Firefox 121.01
Operating system and its version: Linux
PDF.js version: 4.0.240
Is a browser extension: No (built-in)

Steps to reproduce the problem:

Open up any PDF in Firefox on a tablet, or laptop with a touch-enabled screen.
Try to scroll pages with a finger swipe, up, or down, the pages won't move.

What is the expected behavior?
Make the pdf.js viewer scrollable with a finger-touch swipe up /down and left/right gesture.

I just tried with Firefox 121 and 123 (nightly) on Fedora with Wayland and a lenovo laptop with a touch screen and it WFM but with X11 it doesn't work. That said maybe there is something to configure either in Firefox or in your system (or both) to enable the touch screen stuff with Firefox.
So as far as I can tell there's no problem on the pdf.js side.

I just tried with Firefox 121 and 123 (nightly) on Fedora with Wayland and a lenovo laptop with a touch screen and it WFM but with X11 it doesn't work. That said maybe there is something to configure either in Firefox or in your system (or both) to enable the touch screen stuff with Firefox. So as far as I can tell there's no problem on the pdf.js side.

Just tested it under Wayland and yes, this seems to be only an x11 issue.


Update beta add app to support helm charts

Short description
As a developer, I want to add helm charts to my weave gitops environment so that I can test helm chart support with the new directory layout.
Acceptance criteria

[ ] beta add app command supports adding helm charts the same way it's done today

Design materials

n/a

This hasn't been tested on the beta path, but could work.

Closing as the beta commands have been folded in the main path.


JSONL support

JSONL is basically a file where each line is a complete JSON structure. This syntax plugin already mostly supports it, however it appears that concealing does not work on the first line (but does on all others?) also auto-detect does not detect it as a json.

http://jsonlines.org/


[rebased] Update Pegelbot project and add lablead contact

This is a rebased version of #331 which drops some older commits.

@okfde/codeforde-devs it would be great if one of you could approve this. I rebased the original PR since that was based on a really old main branch which led to the automated tests failing.


Update chart coroot to 0.13.0

This PR contains the following updates:

Package
Update
Change

coroot
minor
0.12.4 -> 0.13.0

Release Notes

coroot/helm-charts (coroot)
v0.13.0
Compare Source
A monitoring and troubleshooting tool for microservice architectures.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


[FEATURE] Navlinks Hover Transition

Description
Description
To add a hover effect transition on the navlinks.
Demo:
Screenshots
https://github.com/EddieHubCommunity/LinkFree/assets/101876769/9dadfde9-bd45-4465-a2b9-d17d79064de8
Additional information
No response

Thank you for the suggestion 👍  the new rebranding and design are happening soon, so I think we do not need to make any design changes like this at the moment, so I will close the issue


docs(lazy-load): Improve docs for Lazy Load component page

Rephrase sentences and add a summary

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #220   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          20     20
  Lines         379    379
=====================================
  Hits          379    379

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c46d3a...2b61eeb. Read the comment docs.


docs(ui): fix style

affects: @varlet/ui
Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information
Fix the style based on chinese-copywriting-guidelines

Codecov Report

Merging #214 (d80f7e1) into dev (72b4c08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #214   +/-   ##
=======================================
  Coverage   96.31%   96.31%
=======================================
  Files         209      209
  Lines        4725     4725
  Branches      962      962
=======================================
  Hits         4551     4551
  Misses        172      172
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b4c08...d80f7e1. Read the comment docs.

We do have formatting issues when we mix Chinese and English. I will open a separate issue to the top, so that more people can help us improve the formatting issues.
我们中英文混排时的确存在格式问题，我会单独开个issue置顶，让更多的人来协助我们完善格式问题


adding call to sorted to sort plugins dropdown

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-114

@mistercrunch

👍

@varantz could you please rename this PR so the title begins with [AIRFLOW-114]? I will add that to your commit description when merging. Thanks


Fix the fixed-point encoding of effective prices to not use floating-point math

Yep, this is now using U128x128


Add food list

Food list

Should display a list of food as in the wireframe.
Should lead to the form that allows users to add new food.

Status: ✔ Project Approved ✔
Hello @usmansbk !
Your project is complete now, but you never must delete a repository once the review has started, this prevents us (Code reviewers) to see any previous requirements from other CR's. So, next time you could ask for help in the Pull Request as a comment and one of the CR will help you with the issue

Now you can merge this branch 🚀
💻 👩🏽💻  Happy Coding!  👨🏽💻 🖥

As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
https://giphy.com/embed/VIEy2m9UtWatviq1U6
+++++++++++++++++++++++++++++++++++++++++

Well done @usmansbk !


Rd 9461 containers support execution tags

:tada: This PR is included in version 1.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update 2024 Remote-Write talk description

The second part removed was a "Additional Notes" that are NOT meant to share as a talk description - it supposed to be notes to the reviewers. cc @alexgreenbank we put this in wrong place in sessionize.
Nothing secret there, just duplicated and unnecessary details and spoiler alerts.

We need to update the sessionize too, but we need help from @metalmatze I believe (:

The submitter of the talk should still be able to change the description.
Anyway, I've changed it in Sessionize. I've opened the other PR where we generated the files based on the Sessionize data.

Thank you so much!


The plugin fetches 100 image not more

I have added docker repo and able to see oinly 100 images. I have updated the config:

then restrted IDE then readded the url and still only 100 images in the list :(

Hi, the plugin is not using any of the Intelij settings. It's probably an issue with the registry API is using pagination. Will have to check that. No promises on when this will be done, because right now I have very little spare time to work on this project.
You can always open a MR if you need a fix.


Add a better networking doc

This makes a new docs/cluster dir - we should move all detailed cluster-setup related docs here.
Hopefully this explains a bit better what is going on.

Not sure about the new directory.  What else would go in there?  How about just putting this at the bottom of the current docs/networking.md.

I found this a really useful document.  I understood K8s networking much better after reading it.

Taking a look now.

Regarding new dir - I briefly discussed with Brian.  I could see all of the getting started guides moving here, all of the networking-related docs, etc.  Anything that the cluster admins would want to read but app developers might not care about.  I could be talked out of it if you care...

Many comments addressed

No need for an LGTM from me, I trust you addressed whichever of my comments you thought were reasonable. :)

If you are planning to do the work to move other things into the docs/cluster dir in the next PR, then fine.  Otherwise, let's not have a dir with one thing in it.

OK, I gave up on the extra dir - we can deal with that later


Refactor/break kzg srs

The KZG SRS breaks up naturally into a prover component (G1[:]) and a verifier component (G1[0], G2[0:2]), which only have one G1 point in common (which is usually standardized and can be omitted anyway).
Treating it as a single object results in very long Plonk verifying keys for example, which can be problematic in Smart Contracts.
This PR implements the break-up.
WARNING: I've removed pretty much all pass-by-pointers I encountered. In case some of that was performance-critical, lmk and I'll add it back in.

Could you modify
        _, err := foldedQuotients.MultiExp(quotients, randomNumbers, config)
	if err != nil {
		return nil
	}

to
        _, err := foldedQuotients.MultiExp(quotients, randomNumbers, config)
 	if err != nil {
		return err
	}

in BatchVerifyMultiPoints in the kzg.go files (e.g. l.419 for bls377) ? (Spotted by @kevaundray )


[Bug]: prefetch not working properly, mismatched prefetched URL and clicked URL

Which Remix packages are impacted?

[ ] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[ ] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[X] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[ ] @remix-run/vercel

What version of Remix are you using?
1.0.5
Steps to Reproduce
Prefetch a link with search params.
<Link to="/search?q=search&p=2" prefetch="render">Link</Link>

The URL loaded during prefetch have the _data at the end but when you click the link it will be at the start of search params causing the prefetched cache to not hit.
Expected Behavior
The URLs for prefetch and the actual click should be consistent for the prefetch to work.

Was able to get the expected behavior using this patch but there is also an existing issue related to prefetched url not matching clicked url here that may have a different issue. Maybe this needs to be fix somewhere else.
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 967ead0..9e190fd 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -153,8 +153,12 @@ function getDataLinkHrefs(page, matches, manifest) {
       search
     } = path;
     let searchParams = new URLSearchParams(search);
-    searchParams.append("_data", match.route.id);
-    return `${pathname}?${searchParams}`;
+    let dataSearchParams = new URLSearchParams();
+    dataSearchParams.append("_data", match.route.id);
+    for (let [key, value] of searchParams) {
+      dataSearchParams.append(key, value);
+    };
+    return `${pathname}?${dataSearchParams}`;
   }));
 }
 function getModuleLinkHrefs(matches, manifestPatch) {

Actual Behavior
URL are not matching causing the data to be loaded twice and not gain the benefit of prefetch.

created a PR for this. https://github.com/remix-run/remix/pull/797/

fixed by #1396


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/105 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 75d5440:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 75d5440:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 75d5440:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/sql-database-engine.png
:white_check_mark:Succeeded

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 75d5440:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/sql-database-engine.png
:white_check_mark:Succeeded

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Use simpler err printing

The error logging and printing on emit & die functions is a bit verbose.
fmt.Printf("%s", fmt.Errorf("%s", err)) only needs fmt.Print(err) or better fmt.Println(err)
and 'logger.Panic(fmt.Errorf("%s", err))justlogger.Panic(err)`

Since you are working on this issue, what about adding https://github.com/sirupsen/logrus or https://github.com/apex/log
That way we are standardising for log collection on logstash, Splunk and AWS.

@DarkThrone since this was a pretty straight-forward fix, decided to close this first, as we look into logging. What are your thoughts on apex/log as compared to logrus? I've only used logrus before