fix randomIndex throw exception when use JSONPath.of(JSONReader)

fix 2 bugs:

JSONPath.eval() does not support get field after randomIndex(), throws TODO . Exception
JSONPath.extract() does not support randomIndex()

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.风起 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #169 (8b2aeaf) into main (e8b2ebc) will decrease coverage by 1.23%.
The diff coverage is 28.20%.

@@             Coverage Diff              @@
##               main     #169      +/-   ##
============================================
- Coverage     69.78%   68.55%   -1.24%
+ Complexity     8655     8515     -140
============================================
  Files           411      411
  Lines         44512    44402     -110
  Branches       8897     8867      -30
============================================
- Hits          31062    30439     -623
- Misses         9797    10338     +541
+ Partials       3653     3625      -28

Impacted Files
Coverage Δ

.../src/main/java/com/alibaba/fastjson2/JSONPath.java
71.51% <28.20%> (-0.91%)
:arrow_down:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
30.18% <0.00%> (-49.06%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
40.25% <0.00%> (-30.07%)
:arrow_down:

...va/com/alibaba/fastjson2/reader/ValueConsumer.java
16.66% <0.00%> (-16.67%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
66.74% <0.00%> (-14.76%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterUTF16.java
66.78% <0.00%> (-10.96%)
:arrow_down:

...java/com/alibaba/fastjson2/JSONWriterUTF8JDK9.java
73.41% <0.00%> (-8.87%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
52.04% <0.00%> (-6.23%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/util/IOUtils.java
55.06% <0.00%> (-5.07%)
:arrow_down:

...baba/fastjson2/reader/FieldReaderObjectMethod.java
74.41% <0.00%> (-4.66%)
:arrow_down:

... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b2ebc...8b2aeaf. Read the comment docs.


🚀 Feature: Restrict acces to user-groups

Feature description
Hi,
I'm thinking about using pocket-id to handle authentication for multiple services. Each of them will have their own OIDC client.
The problem is that not every app has the same list of users. I'd like to be able to configure pocket-id in a way that, for example,  allows:

users of 'group A' to access 'App A'
users of 'group B' to access 'App B'
users of 'group Admin' to acces both apps.

Pitch
The 'user group' settings seemed suitable for this, but as far as I can find there is no way to restrict an OIDC client to only one (or more) user-groups.
Any thoughts? 😄

Well, I only know that with Grafana (i.e. the OIDC client itself) that you have to be a member of a certain group and if not, then the certain user doesn't work for the login.

The user must either be in the grafana_admin group, and or be in the Admin group for the normal admin. If he is not in one or both groups, the user is not created.

You can assign Custon Claims not only to users, but also to user groups.
That works for me to restrict admin access to certain apps via pocket ID

I think this is something that should be handled by the client. Or do other providers like Keycloak support client authorization permissions?

Thank you for all the suggestions. Unfortunately it's often not that easy to let the client handle this. For example Immich, a pretty popular project, doesn't have any field to define a specific group to allow access for.
I'm sure they could add this, but it would be a pretty big task to expect every client to do this.
Keycloak supports realms

A realm is a space where you manage objects, including users, applications, roles, and groups. A user belongs to and logs into a realm. One Keycloak deployment can define, store, and manage as many realms as there is space for in the database.

The way that pocket-id is designed now, would mean that I'd have to deploy one instance for every service that I want to give people access to.
To be able to share one user among multiple projects/realms would be perfect. But even a simpler solution where we can have multiple projects/realms with each their own set of users (leading to multiple accounts for some users) would be a pretty nice addition!

@stephanvane In my opinion multiple projects/realms are an overkill for Pocket ID. The main goal of the project is to remain a simple OIDC provider. For more complex use cases, I would recommend using Keycloak.


Error from static-html

I've got the following error while trying to create a client-bundle from a working Meteor project.
Errors prevented bundling:
While processing files with static-html (for target web.browser):
client/main.html:12: Expected  or  tag

/usr/local/lib/node_modules/meteor-client-bundler/node_modules/execa/index.js:277
		throw (result.error || new Error(result.stderr === '' ? result.stdout : result.stderr));
		^

Here is the whole session:-
samphan gray:~/src/btrapp$ meteor-client bundle --source=../better/
Created a new Meteor app in '/var/folders/16/x31xxbkx2lg9zb1hrcy21c4m0000gn/T/tmp-33798TtHmhEF3DFDV'.

To run your new app:
  cd /var/folders/16/x31xxbkx2lg9zb1hrcy21c4m0000gn/T/tmp-33798TtHmhEF3DFDV
  meteor

If you are new to Meteor, try some of the learning resources here:
  https://www.meteor.com/learn

meteor create --bare to create an empty app.
meteor create --full to create a scaffolded app.

Changes to your project's package version selections:

accounts-base                   added, version 1.2.17
accounts-facebook               added, version 1.1.1
accounts-oauth                  added, version 1.1.15
aldeed:browser-tests            added, version 0.1.1
autopublish                     removed from your project
barbatus:typescript             added, version 0.6.5_1
barbatus:typescript-compiler    added, version 0.9.5
barbatus:typescript-runtime     added, version 1.0.0
blaze-html-templates            removed from your project
coffeescript                    added, version 1.0.17
ddp-rate-limiter                added, version 1.0.7
dispatch:mocha                  added, version 0.4.1
dispatch:mocha-browser          added, version 0.0.4
email                           added, version 1.2.1
facebook-oauth                  added, version 1.3.0
less                            added, version 2.7.9
localstorage                    added, version 1.0.12
meteortoys:toykit               added, version 3.0.4
msavin:mongol                   added, version 2.0.1
npm-bcrypt                      added, version 0.9.2
oauth                           added, version 1.1.13
oauth2                          added, version 1.1.11
practicalmeteor:chai            added, version 2.1.0_1
practicalmeteor:loglevel        added, version 1.2.0_2
practicalmeteor:mocha           added, version 2.4.5_6
practicalmeteor:mocha-core      added, version 1.0.1
practicalmeteor:sinon           added, version 1.14.1_2
rate-limit                      added, version 1.0.8
react-meteor-data               added, version 0.2.11
reactive-dict                   added, version 1.1.8
service-configuration           added, version 1.0.11
session                         added, version 1.1.7
simple:dev-error-overlay        added, version 1.5.1
softwarerero:accounts-t9n       added, version 1.3.9
static-html                     added, version 1.2.2
std:accounts-ui                 added, version 1.2.20
tmeasday:check-npm-versions     added, version 0.3.1
tmeasday:test-reporter-helpers  added, version 0.2.1

WARNING: The output directory is under your source tree.
         Your generated files may get interpreted as source code!
         Consider building into a different directory instead
         meteor build ../output

Errors prevented bundling:
While processing files with static-html (for target web.browser):
client/main.html:12: Expected  or  tag

/usr/local/lib/node_modules/meteor-client-bundler/node_modules/execa/index.js:277
		throw (result.error || new Error(result.stderr === '' ? result.stdout : result.stderr));
		^

Error: null
    at Function.module.exports.sync (/usr/local/lib/node_modules/meteor-client-bundler/node_modules/execa/index.js:277:26)
    at Object.bundle (/usr/local/lib/node_modules/meteor-client-bundler/lib/bundler.js:79:9)
    at Command.<anonymous> (/usr/local/lib/node_modules/meteor-client-bundler/cli:42:13)
    at Command.listener (/usr/local/lib/node_modules/meteor-client-bundler/node_modules/commander/index.js:301:8)
    at emitTwo (events.js:106:13)
    at Command.emit (events.js:191:7)
    at Command.parseArgs (/usr/local/lib/node_modules/meteor-client-bundler/node_modules/commander/index.js:615:12)
    at Command.parse (/usr/local/lib/node_modules/meteor-client-bundler/node_modules/commander/index.js:458:21)
    at Object.<anonymous> (/usr/local/lib/node_modules/meteor-client-bundler/cli:50:9)
    at Module._compile (module.js:570:32)

And this is the usual client/main.html :-

  <meta charset="utf-8" />
  <link href='https://fonts.googleapis.com/css?family=Roboto:400,300,300italic,400italic,500,500italic,700,700italic' rel='stylesheet' type='text/css'>
  <link rel="stylesheet" href="css/onsenui.css">
  <link rel="stylesheet" href="css/onsen-css-components.css">
  <link rel="stylesheet" href="main.css">

  <title>Better</title>

I get the same error. Did you find a solution for this? Thanks.

Run
‘meteor remove static-html’ in your Meteor project


Some changes from my preliminary walk-through of the code

Should not cause any changes in functionality, tests etc. Will comment the code snippets to give background (i.e. don't merge yet).
On the removal of the activator files: Typesafe Activator likes leaving them in projects, but they are really not required. activator is just a wrapper for sbt. Maybe the idea is that people would be able to get started with a project without having anything (not even sbt) installed, but that's overkill.. Anyways, I prefer projects not having those three.
On the main.scala: I believe it should be placed elsewhere, e.g. under the test/ folder. It's not part of the deliverable library, is it? If not, placing it under test allows one to launch it with sbt test:run. I find this extremely handy for placing such test-like exercisers that are useful in development.

manually applied PR


Wrong value on verbose for 0 * * * *

Version: 1.106.0
Reproduction:
cronstrue.toString('0 * * * *', {verbose: true})
'Every hour, every hour, every day'

Thanks!

Notices it is already reported. My bad!

Notices it is already reported. My bad!


[v7] Update requirements for CuPy v7.8.0

Ref #3802.

Jenkins, test this please

Sorry I failed to add cuDNN v7.6.

pfnCI, test this please.

Jenkins CI test (for commit feea5a258ac3a6e1c21c233a9162bb44af4ddf68, target branch v7) succeeded!


Add Buttons

Right now refresh is the only functional button.

I'll save the upload implementation for the next PR, since that will be pretty involved.

Updated buttons:

:+1:


ImGui::mouse_delta broke after update to imgui 1.65.2

ImGui::mouse_delta now returns values extremely close to 0.
For example, after adding the following line to the hello_world.rs example,
let mouse_delta = ui.imgui().mouse_delta();
println!("Mouse Delta: {:?}", mouse_delta);

Only the following kind of lines will be printed on my machine running Ubuntu 18.04 with X11 (on commit b4edc01 and current latest master 8bf6831).
Mouse Delta: (0.000000000000000000000000000000000000000000589, 0.000000000000000000000000000000000000000001265)

We would instead expect mouse delta to print the number of pixels the mouse has moved between two frames. It works as expected on commit c85e73e.
I currently do not know why such regression happened, and I am going to investigate. I will update this issue when I have more information. @Gekkio Do you have any thought or idea?

There was a struct layout problem in ImGuiIO that I fixed just now with 1750aa5e72e630959f4b019c8bb7017c133e58bc
Could you check if that fixes the problem?

I went an a walk and when I was back it was fixed! Awesome!
I confirm that commit 1750aa5 fixes the error raised by this issue.


Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2.5

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 31s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
2m 53s
branch-2.5 passed

+1 :green_heart:
compile
0m 13s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
0m 14s
the patch passed

+1 :green_heart:
javac
0m 14s
the patch passed

+1 :green_heart:
shadedjars
4m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-common in the patch passed.

20m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8424be43a768 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / d151af1663

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/testReport/

Max. process+thread count
165 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m  2s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
branch-2.5 passed

+1 :green_heart:
compile
0m 21s
branch-2.5 passed

+1 :green_heart:
shadedjars
6m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 19s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
shadedjars
5m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 58s
hbase-common in the patch passed.

29m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5112

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 86f132889c55 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / d151af1663

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/testReport/

Max. process+thread count
254 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+1 :green_heart:
mvninstall
3m 31s
branch-2.5 passed

+1 :green_heart:
compile
0m 31s
branch-2.5 passed

+1 :green_heart:
checkstyle
0m 12s
branch-2.5 passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 28s
branch-2.5 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 12s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
checkstyle
0m 11s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 29s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 37s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

32m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5112

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux e0cad45906c9 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / d151af1663

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5112/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


changed the printing strategy of profiles

The profile info in the job handler are printed by the Runners (i.e. threads/cpus). This can cause that in case of simultaneous printing, not all the information of a job are printed sequentially causing the impossibility to connect the info reported with the actual job. This PR improves this behavior creating a string a-priori and print it all in once.

I created a script. But there are a lot of workaround for the not-thread safe printing. I will modify the script and commit it (in another PR) once this is in.


Add Contribution Guidelines

hey, @Rick-mad-lab assign me this issue under hacktoberfest!
I will add guidelines

Nice !

@Rick-mad-lab is this issue still available?


Create IntelliSense XML conflict tool

Related work item: https://dev.azure.com/ceapex/Engineering/_workitems/edit/633174
Related tool: https://github.com/gewarren/api-docs-sync/tree/main/src/PortToDocs
Idea:

Input: 1) Path to local IntelliSense XML files and 2) Path to local ECMAXML files.

Match up documentation comments for each API that has a non-empty comment in the IntelliSense XML file and a non-empty comment in the ECMAXML file.

If the text doesn't match, modify the IntelliSense file with conflict syntax:
The area where a pair of conflicting changes happened is marked with markers <<<<<<<, =======, and >>>>>>>. The part before the ======= is typically your side, and the part afterwards is typically their side.

Associated WorkItem - 95353

I have this working for <summary>. I need to add all the other tags, e.g. <param>, <returns>, etc.


Shift focus to newly inserted node

Given I am  in data entry dialog
When I insert a node
Then submit the changes
and shift focus to the new node

Done


Snap Get - Error on no value set

Problem
When performing snap get:
        snap_cache = snap.SnapCache()
        mongodb_snap = snap_cache["charmed-mongodb"]
        current_uri = mongodb_snap.get("monitor-uri")

this will cause an error if monitor-uri is not set
Ideal usage
        snap_cache = snap.SnapCache()
        mongodb_snap = snap_cache["charmed-mongodb"]
        if mongodb_snap.get("monitor-uri") == self.monitor_config.uri:
             return

        # do something

Current usage
        snap_cache = snap.SnapCache()
        mongodb_snap = snap_cache["charmed-mongodb"]
        try:
            if mongodb_snap.get("monitor-uri") == self.monitor_config.uri:
                return
        except snap.SnapError:
            # SnapError occurs when the config option `monitor-uri` is not set.
            pass

        # do something

Desired Behavior
Return None  if value is not set

Thanks for this. I think you're right it would be a nicer API to return None in the case where a config key isn't present (and it matches Python's dict.get behaviour). However, strictly speaking this wouldn't be a backwards-compatible change, because some callers might be relying on the SnapError to be raised in this case. And I don't think it's worth creating a new major version for a relatively trivial change this like.
One possibility to keep it backwards compatible is to add a default argument that, if provided, would return that value instead of raising (the default would still be to raise SnapError). Something like so:
_raise = object()  # unique object to signal a "raise exception" default

...

    def get(self, key, default=_raise) -> str:
        """Fetch a snap configuration value.

        Args:
            key: the key to retrieve
            default: if specified, return that value if the configuration key is not found
                (the default is to raise SnapError)

        Raises:
            SnapError: if default not provided and the configuration key is not found
        """
        if default is _raise:
            return self._snap("get", [key]).strip()
        else:
            try:
                return self._snap("get", [key]).strip()
            except SnapError:
                return default

Hi @benhoyt my apologies for missing this message - that implementation sounds perfect thank you!


Vertical parallax

Is your feature request related to a problem? Please describe.
Well the issue here is that if you attempt to scroll the screen vertically with parallax scrolling enabled, layers 1 and 2 will stay in the same vertical position and scrolling glitches will occur (even with only 1 layer).
Describe the solution you'd like
Combining the camera code with the interrupt code so that the layers can move vertically based off of the camera's Y position.
Describe alternatives you've considered
There are no alternatives.
Additional context
Add any other context or screenshots about the feature request here.

Not easily possible due to the way Gameboy hardware does. You could do this with some vram tomfoolery, but it would require a major engine rewrite and wouldn't work that well.

Not easily possible due to the way Gameboy hardware does. You could do this with some vram tomfoolery, but it would require a major engine rewrite and wouldn't work that well.

Would it be possible to “just” have the parallax layers scroll off the screen vertically, but not have any vertical parallax effect?

Not easily possible due to the way Gameboy hardware does. You could do this with some vram tomfoolery, but it would require a major engine rewrite and wouldn't work that well.

By scrolling 8 pixel tall strips? Think you must be getting confused with the game gear and master system, which have this limitation and can only scroll 8 pixel tall strips. The gameboy, on the other hand, has complete control over where the background is scrolled on each scanline, and the final boss in wario land is an example of this.

Not easily possible due to the way Gameboy hardware does. You could do this with some vram tomfoolery, but it would require a major engine rewrite and wouldn't work that well.

Would it be possible to “just” have the parallax layers scroll off the screen vertically, but not have any vertical parallax effect? Enabling non-glitchy scenes with parallax that are taller than 144 and can scroll horizontally and vertically

I don't think so, because there's no such thing as negative scanlines (scanline #0 being the top of the screen) If the screen was scrolled vertically, the Y position of the 1st layer would probably underflow to 255 and possibly lead to a crash because of the Gameboy waiting for a scanline that doesn't exist. A simple range check would probably fix this though.
That's just my theory.

Not easily possible due to the way Gameboy hardware does. You could do this with some vram tomfoolery, but it would require a major engine rewrite and wouldn't work that well.

Would it be possible to “just” have the parallax layers scroll off the screen vertically, but not have any vertical parallax effect? Enabling non-glitchy scenes with parallax that are taller than 144 and can scroll horizontally and vertically

I don't think so, because there's no such thing as negative scanlines (scanline #0 being the top of the screen) If the screen was scrolled vertically, the Y position of the 1st layer would probably underflow to 255 and possibly lead to a crash because of the Gameboy waiting for a scanline that doesn't exist. A simple range check would probably fix this though.
That's just my theory.

This Retro Game Mechanics Explained video explains a few ways this could be achieved. The video focuses on NES, but the Game Boy works in a similar way.
If you go the background scrolling + scan line interrupt route, the full width of the screen will have the same scrolling. Within those full width horizontal chunks of screen, there's nothing stopping you from scrolling vertically though. This is how split screen multiplayer works. To really sell the vertical parallax though, you need to also constantly change the interrupt lines (ie. as you get higher on the screen, the horizon line should slowly get lower).
The tile replacement route is more difficult, but you could do pretty much anything you want with it. For a single tile, you could just shift the bits of your background tile. You could precompute the parallax tiles and replace them like you would any other animated tile. If you need "foreground" elements with bits of parallax peeking through, combine your parallax tile with the foreground tile using a mask.

I think it would be really cool to be able to do tile-based parallax


Zxing.Net.Mobile.WindowsUniversal AutoFocus crash

Library version: 2.1.45
I want to report a random crash when i start the scan on my tablet (Alcatel 8085) with Windows 10.
The app freezes with a white screen with a red line in the middle and then the app crashes 4-5 seconds after the freeze.
Sometimes the library works as expected, but occasionally it crashes.
In the logs i can see:
AutoFocus requested
Exception thrown: 'System.Runtime.InteropServices.COMException' in ZXingNetMobile.dll
WinRT information: This object needs to be initialized before the requested operation can be carried out.
Exception thrown: 'System.Runtime.InteropServices.COMException' in mscorlib.ni.dll
WinRT information: This object needs to be initialized before the requested operation can be carried out.

+1

I experienced this issue today. It occurs when users tap on the page instantly to focus specific are before the scanner control even initialize the camera.
I will fix the issue and send a PR if no one's interested in fixing.


Deprecate kamel install and change default installation to kustomize/helm/olm?

As soon as the work on #5610 is closed, we can retake the work previously discussed in #3865. However I'd like to suggest some change as, while working on #5610 I realized that Kustomize may not be the best option when it comes to a simple methodology to install that has similar capabilities to what we're used in kamel install.
During these years we've worked adding a lot of flags to the kamel install in order to simplify the installation (ie, registry, maven repositories, build configs, ...). This was a very handy way to apply quickly configuration during the installation procedure as the user has to specify some parameter=value approach.
Helm has a similar approach, as, it allows the chart to provide variables we can easily include in the Helm templating system and set those variables (ie, helm install camel-k  --set platform.build.registry.address=<IP_ADDRESS>). It even allows the installation to stop if that value is not provided.
Kustomize seems to be much more advanced as, conversely, requires the user to know exactly the Kubernetes resource to deal with. This could be a bit tricky, above all when we need to replace the CLI in the e2e tests. Although we may think to just install via overlay and later change the IntegrationPlatform parameters by changing Kubernetes custom resources directly.
OLM, probably is something we cannot really use as a default, as, it also require managing the custom resource configuration for most of parameters.
I'd like to hear any other pros and cons, so, we can try to work on this before next minor release.

Perhaps an experimentation would be to change the kamel install of CI / e2e to either kustomize / helm and an open PR similar to the camel jbang experiment, to see thow that goes at first.
I'm not that familiar with kustomize, but helm seems pretty easy to customize the values, but when it comes with behavior we have to change the chart values for specific install conditions with those helm curly brackets, but that's the way it works.
The good part is either helm/kustomize are know to the community and easier to change customization by declaration.


Next.js 5 Throws Error When Using react-native-web

Support for react-native-web worked in Next.js 4, but now throws an error when upgrading to Next.js 5. From my research, this would appear to be related to an issue that has been closed in necolas/react-native-web#364.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
The Next.js server should successfully compile and load the application without errors.
Current Behavior
The Next.js server throws an error and failed to compile.
ERROR  Failed to compile with 1 errors

This dependency was not found:

* react-dom/unstable-native-dependencies in ./node_modules/react-native-web/dist/modules/injectResponderEventPlugin/index.js

To install it, you can run: npm install --save react-dom/unstable-native-dependencies

Steps to Reproduce (for bugs)

Spin up Next.js 5 project
yarn add react-native-web
yarn add -D babel-plugin-react-native-web
Add .babelrc configured for the plugin installed in previous step
Setup Next.js with react-native-web (see slightly different example below to match latest version of react-native-web)
yarn start

Context
The Next.js application is unable to compile.
Your Environment

Tech
Version

next
5.0.0

node
8.9.4

OS
macOS 10.13.3

browser
Chrome 64.0.3282.140

react-native-web
0.4.0

Custom Document
import Document, { Head, Main, NextScript } from 'next/document';
import React from 'react';
import { AppRegistry } from 'react-native-web';
import { renderToStaticMarkup } from 'react-dom/server';

export default class MyDocument extends Document {
  static async getInitialProps({ renderPage }) {
    AppRegistry.registerComponent('Main', () => Main);
    const { getStyleElement } = AppRegistry.getApplication('Main');
    const page = renderPage();
    const styles = [getStyleElement()];
    return { ...page, styles };
  }

  render() {
    return (
      <html style={{ height: '100%', width: '100%' }}>
        <Head />
        <body style={{ height: '100%', width: '100%', overflowY: 'scroll' }}>
          <Main />
          <NextScript />
        </body>
      </html>
    );
  }
}

@dcalhoun we fixed a related issue for this.
Could you try this version: https://github.com/zeit/next.js/releases/tag/5.0.1-canary.2

This fixes issues with react-dom/server also.
I was using react-quill and 5.0.0 broke the whole thing. using canary.2 fixes that.
Thanks! Good job folks!


Tidied up dependencies and made the juce_audio_processors optional.

See #148

Ah! This makes a ton of sense @jrlanglois, thanks very much!
I'm quite ready to merge, just have one last question: will this break existing projects? I don't think so, right? Because those existing projects will have been forced already to add all of these juce module dependencies. When this merges, those existing projects wont' break, but will now have the opportunity to remove their dep on juce_audio_processors. Is that right?

It shouldn't have any effect on other projects!

When this merges, those existing projects wont' break, but will now have the opportunity to remove their dep on juce_audio_processors. Is that right?

That's precisely the it: assuming a non-audio app is in the works, the user can simply pull that module out of their project now.

Excellent, then I'll go ahead and merge! Thanks very much @jrlanglois


Favicon is 404

No bug found. Working fine.

Went back to get more detail. User reported they were using iPad OS 17.1 and Firefox.
Looks like the asset is bundled correctly in production.


Add json-to-ffmpeg

Hey @krzemienski , this util translates JSON files written in strongly typed schema into complex FFmpeg commands. I made this tool as part of writing simple video editor software and open-sourced to others so they can benefit from the tool also. JSON follows convention from GUI video editors where you have timelines, tracks and clips that are translated into filter_complex in the output.
Regards

@pilotpirxie Love it...


Introduce Logger and LogParams

This PR introduces a Logger struct and makes some significant changes to the mechanics of the macros for reasons that I'll outline below.
The most obvious change is that LogConditions has been replaced with LogParams and the logging macros no longer have an overload that takes in a LogConditions argument. Instead the first argument of each macro is an expression that can be evaluated to something that implements the AsLogParams trait. All of the conditions that used to be expressed by LogConditions are now packed into LogParams.
As an example, in the previous code we had
log_info!(
    &node.name(),
    LogConditions {
        occurs: LoggingOccurrence::Always,
        publish_interval: Duration::from_millis(1000),
        log_if_true: count % 10 == 0,
    },
    "Manually constructed LogConditions",
);

but the new equivalent would be
log!(
    node
    .interval(Duration::from_millis(1000)
    .only_if(count % 10 == 0),
    "Manually constructed LogConditions",
);

More examples of the new syntax can be found in fn test_logging_macros inside logging.rs.
Another notable feature is the introduction of Logger which has two roles:

Pre-validate and pre-allocate logger names before a user tries to pass them into a logging macro
Allow the user to set the severity level of a logger (including the default logger)

Finally there was some significant restructuring of the log macro implementation, most of which was meant to avoid redundantly allocating CStrings on the heap every time the same log macro gets called. With the new implementation, each CString gets allocated exactly once, the first time it's needed. The only exception to this is the log message itself which may change each time the macro is called, so it's impractical to cache it.
One thing that could use improvement is we should add assertions to test_logging_macros to validate that the right output is being produced for every macro call. I'm deliberating whether to do this by capturing stdout/stderr or by subscribing to the rosout topics.

I couldn't resolve the conflicts in the files above without having it look like I did all the work!  Not wanting to steal credit I've left this PR as-is.  The conflict resolution was easy though - I created a local branch and want through the process.

without having it look like I did all the work

I appreciate the consideration. I knew there would be merge conflicts because of the little bit of overlap between the PRs, and I planned on resolving that once the other PRs were merged. Thanks for doing the test run! I've resolve the merge conflicts now, and also fixed the formatting.

Sadly I just noticed that LazyLock, which I use extensively in this PR, was not stabilized until Rust 1.80, but upstream we'll need to target 1.75 at the latest in order to make feasible for rclrs to be hosted on the build farm prior to Ubuntu 26.04 being released. I'll need to replace their use with OnceLock. I should have time to fix that tomorrow.
One other thing I'd like to do is use rcl_logging_configure_with_output_handler to redirect stdout and stderr in the logging tests to

Suppress the misleading error messages that are being produced
Add assertions to the tests that make sure the logging conditions are being handled correctly.

But I think we can leave this for a follow-up PR and move forward with merging this PR once the LazyLock issue is resolved.

Sadly I just noticed that LazyLock, which I use extensively in this PR, was not stabilized until Rust 1.80, but upstream we'll need to target 1.75 at the latest in order to make it feasible for rclrs to be hosted on the build farm prior to Ubuntu 26.04 being released. I'll need to replace their use with OnceLock. I should have time to fix that tomorrow.

I'd hit the same issue locally (we were using 1.79) - easy enough for us to upgrade our local rust, but good call on the upstream version (I'm afraid to say I'd not even looked into that).

But I think we can leave this for a follow-up PR and move forward with merging this PR once the LazyLock issue is resolved.

That's a nice idea and I agree that we should create a separate PR for that work - it would be nice to get the logging integrated if possible.

I think this one is finally ready to merge with CI being green. After that #11 should be ready for review.


cellular ketone metabolic process missing children?

shouldn't a lot of sugar metabolism terms be is_a cellular ketone metabolic process?
(The chemical reactions and pathways involving any of a class of organic compounds that contain the carbonyl group, CO, and in which the carbonyl group is bonded only to carbon atoms)
e.g fructose metabolic process, sorbose metabolic process

Closing this becasue it depends on ChEBI.

Piling on after the whistle. Monosaccharides spontaneously isomerize between "keto" andf "enol" forms, nd the equilibrium state has a fair amount of keto form, I think. But biochemists still don't think of sugars as ketone derivatives, so there probably isn't much to gain from pushing ChEBI to make terms to enable it.

I hadn't noticed @cmungall 's request above and wrote to ChEBI separately, hoefully they will come to the same conclusion as you.

I tend to keep shadow tickets open til upstreams are closed YMMV


Replace dataset on-the-fly

Feature Request
Our company's library updates our internal catalogue on a daily basis. To keep results up-to-date, I would like to always use the latest dataset. Is it possible to replace the dataset on-the-fly, for an already defined project. And if so, how can I do that.

Is the like what we do with the Covid-19 plug-in? We created a plug-in with two databases which are updated in the front-end every time the owners of the data upload a new dataset. For example, every time the CORD19 is updated by Semantic Scholar , it will be updated via this script.
You could create your own plug-in using a template , see for more options the RTDs.

Hi, I am not sure, but I think my question is similar: After working through a few thousand articles and starting to analyse and structure the findings (for, say, 6 months) can one then later update/upload a data set to the same project with new publications?


Ergonomic improvements to concatenation scripts

This introduces a few changes to the concatenation scripts. These are all surface-level changes (they don't affect the output format -- that is still something I want to address).
There are essentially 3 changes:

first, I introduced a new script called concat.py that can be used to concatenate more than one kind of dataset at a time (3D-cubes or multiple kinds of 2D datasets).
next, I replaced --concat-outputs with --snaps (this is a subjective improvement)

The main differenece has to do with specifying ranges of snapshots with --snaps is of the form START:STOP[:STEP] (just like a python slice). For comparison, you use would specify a range with FIRST-LAST with --concat-outputs (LAST is included in the range)
You can still use --concat-outputs, but you get a deprecation warning
I definitely want to hear if people dislike this approach

finally, I made it possible to automatically detect the number of files that need to be concatenated. You can still specify --num-processes, but you get a warning about it.

I also haven't really touched the particle-concatentation script. Based on how code is shared, change number 2 will affect that script. But propagating change 3 would take some additional work.
I'm definitely open to any kind of feedback!
In a subsequent PR, it's my intention to modify things so that we can optionally use multiprocessing or mpi4py to speed up concatenation (I have an idea on how to do that in a minimally invasive manner that won't affect hypothetical dask-usage).

I think this looks good! I like having the default behavior be that you don't have to specify the number of processes. It might be nice to also do that with the file numbers at some point. I also don't have any issues with changing the way the file numbers are specified.
I am having a little bit of trouble figuring out which arguments are required/what the default behavior is and was wondering if you could clarify. For example, if I run this and my input directory contains 2D and 3D snapshots will it just go ahead and concatenate all of them unless I tell it to omit certain types of output? Sorry if I'm missing something obvious!
It would also probably be good to update the documentation with these changes.

I think this looks good! I like having the default behavior be that you don't have to specify the number of processes.

And it is less error-prone!

It might be nice to also do that with the snapshot numbers at some point.

I think that could definitely be nice! One of my goals here is achieving more sensible default behavior with fewer arguments (along those lines, it could be cool to do something along those lines with the -s or -o flag)
My next primary concern is introducing some level of parallelism.

I am having a little bit of trouble figuring out which arguments are required/what the default behavior is and was wondering if you could clarify. For example, if I run this and my input directory contains 2D and 3D snapshots will it just go ahead and concatenate all of them unless I tell it to omit certain types of output? Sorry if I'm missing something obvious!

The behavior of concat_3d_data.py and concat_2d_data.py are unchanged in this regard.
For concat.py you need to opt in for each type of output with the --kind parameter. Consequently,

--kind 3D just does 3D data
--kind slice just does slices (--kind slice-xy,xz will omit data from the yz datasets).
--kind proj just does axis-aligned projections
--kind rot_proj just does rotated projections
--kind 3D slice proj rot_proj would do all of the above

Once we add support for concatenating particles, I might support --all-kinds to handle all types of supported datasets)

It would also probably be good to update the documentation with these changes.

I'm happy to do that. I might hold off until I have your approval/this is merged.

This is great. I'm totally for it

Ah, I see. I had gotten myself a little confused before... I appreciate the clarification!
I think this is good to go!

I'll go ahead and merge this, @mabruzzo feel free to update the wiki when you get a chance.


Fix copyCompatibility bug in copy method for checkbox column data

When the option copyCompatibility: true, there is currently a bug where it copies the innerHTML rather than value of TRUE/FALSE.
The fix is to check the column type, and modify the treatment of the text that is copied into the clipboard.
In the case of checkbox, we should NOT do the previous default behavior of copying the innerHTML, instead, we should copy the value of TRUE or FALSE. However, if the default innerHTML has been overriden programmatically by the user, then we should revert to default treatment of copying the innerHTML, as the value can no longer be relied on being the intended copy source.
This patch maintains backwards compatibility, while adding a new fork in the control flow to better handle different column data-types, such as: image, color bar, etc. The intent is to improve ease of copy/pasting data into ASCII that can be understood by most spreadsheet apps when the data is pasted into them. At the moment, this patch is only proposing a solution to handling the checkbox. Future patches can be easily coded to handle other cases noted above.

Thanks for your suggestion. I have implemented those in a slightly different way including radio considering the column type, but the results should be the same as yours.


Run time error for examples

The holoscope.py and parallel_imaging.py examples run well. However, the parallel-imaging.py example fails to run with the following error message:

jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Failed to execute XLA Runtime executable: run time error: custom call 'xla.gpu.fft' failed: RET_CHECK failure (external/org_tensorflow/tensorflow/compiler/xla/service/gpu/fft_thunk.cc:143) fft_plan != nullptr Failed to create cuFFT batched plan with scratch allocator.

The example script was run with the following command:

assign-gpu -n 4 python examples/parallel_imaging.py

I've added some variables to change the number of devices these programs use --- could you try it again and make sure it works on your computer (in the morning)?

Still causing the same error :(

Even if you change the num_devices to 1?

@diptodip Did you fix this?

This error doesn't happen on our machines, and the holoscope.py example has been updated a lot since then. Might be something to do with CUDA/cuDNN versions?

Alright, so closing due to probably some user machine error.


how to produce demo.nc?

Can you tell me,how to product demo.nc data file please?
I found some history:
Wed Apr 17 10:29:08 2019: D:\GreenSoft\Science\Data_Processing_Analysis_Visualization\NetCDF_Operators\ncap2.exe -3 -S getMinMax.nco C:\Users\Rayman\Downloads\tempInvDim.nc C:\Users\Rayman\Downloads\uv.nc
Wed Apr 17 10:29:07 2019: D:\GreenSoft\Science\Data_Processing_Analysis_Visualization\NetCDF_Operators\ncpdq.exe -a -lat C:\Users\Rayman\Downloads\tempFixDim.nc C:\Users\Rayman\Downloads\tempInvDim.nc
Wed Apr 17 10:29:07 2019: D:\GreenSoft\Science\Data_Processing_Analysis_Visualization\NetCDF_Operators\ncks.exe --no_rec_dmn lev C:\Users\Rayman\Downloads\tempRecDim.nc C:\Users\Rayman\Downloads\tempFixDim.nc
Wed Apr 17 10:29:07 2019: D:\GreenSoft\Science\Data_Processing_Analysis_Visualization\NetCDF_Operators\ncecat.exe -u lev C:\Users\Rayman\Downloads\tempLevDim.nc C:\Users\Rayman\Downloads\tempRecDim.nc
Wed Apr 17 10:29:07 2019: D:\GreenSoft\Science\Data_Processing_Analysis_Visualization\NetCDF_Operators\ncap2.exe -S defineLev.nco C:\Users\Rayman\Downloads\tempUV.nc C:\Users\Rayman\Downloads\tempLevDim.nc
Wed Apr 17 10:29:07 2019: D:\GreenSoft\Science\Data_Processing_Analysis_Visualization\NetCDF_Operators\ncrename.exe -v u-component_of_wind_planetary_boundary,U -v v-component_of_wind_planetary_boundary,V C:\Users\Rayman\Downloads\tempWind.nc C:\Users\Rayman\Downloads\tempUV.nc
Wed Apr 17 10:29:06 2019: D:\GreenSoft\Science\Data_Processing_Analysis_Visualization\NetCDF_Operators\ncks.exe -v u-component_of_wind_planetary_boundary,v-component_of_wind_planetary_boundary C:\Users\Rayman\Downloads\20180916.nc C:\Users\Rayman\Downloads\tempWind.nc
Read using CDM IOSP GribCollection v3
but I dont have some data,like tempInvDim.nc,uv.nc ...
Can you upload these files?THANKS!

Actually the data is from NOAA GFS, I just converted it from GRIB2 to NetCDF 3 format, and then used NetCDF operators to extract and process the data I need.
I don't think you should need the tempInvDim.nc or uv.nc if you want to use custom NetCDF data. Just make your own and ensure it contains the necessary values in the required format (read the updated README file for more info)

hello,can you tell me where are the NetCDF data from and how can i get it? thank you!

The demo data is downloaded from NOAA Global Forecast System.
The original data is in GRIB2 format and I used toolsUI to convert the GRIB2 file to a NetCDF V3 file

hello, the demo only shows the wind direction，how does the demo to show the wind power？

could you tell me how to download and show other climate data? for example ocean data、temperature data、humidity data and so on，thank you!

Wind power is displayed by color
The scalar field (one value at one position, for example, temperature and humidity) can be displayed by WMS layer, you can read the source code in wind3D.js and the document of Cesium for how to use WMS layer

Excuse me， I use new netcdfjs(file) This file is provided by you named demo.nc but I got an  ERROR that is  'Not a valid NetCDF v3.x file:  should start with CDF' and I print the buffer.readByt(3) return "<!D"

can you tell me how to resolve this problem  Thanks

Do you mean you use a different version netcdfjs library? If so, please make sure you are using the latest version.
If you did not change the netcdfjs library, please check your netcdf file version, the README file states clearly that you should use netcdf v3 file

Thanks can you tell me that whitch Version about Cessium you used. now I Got An Error:[Cesium WebGL] Fragment shader compile log: ERROR: 0:? : '' : syntax error and my cessum version is 1.59.0

@xqwIOS
Sorry, I am busy these days...
For your problem, I think you should check your GLSL files location, because "ERROR: 0:? : '' indicates you are probably reading an non-exist file

OK ， Thanks


Implement prefix caching

Refs #91.
This PR implements prefix caching, a concept introduced in RadixAttention. It works by caching the KV cache resulting from running the model over the prompt (the "prefill step"), which is expensive. We implement a PrefixCacheManager which stores input prompt tokens with their prefilled KV caches and which avoids OOM by evicting caches.
Caching

[x] The prefix cache manager holds all the KV caches from the prompts of previous sequences. Internally, this looks like a HashMap<token ids, kv cache>. The caching step is very simple and does not copy the KV cache, which is left on the device and only the KV cache Tensors are cloned.

Evicting

[x] When the scheduler runs, it will check if there is enough memory for the KV cache for the next token to be allocated. If there is not enough memory, the prefix manager will evict some KV caches from device memory to the CPU.

Loading

[x] When a sequence is received, it will check with the prefix cache manager to see if it can skip the prefill step based on its prompt.
[x] Further step: if a prompt exists in the prefix cache manager which contains more tokens after the input prompt (that is, we can truncate the KV cache), we can still skip the prefill step.

@lucasavila00, what do you think about this?

@lucasavila00, what do you think about this? It is ready for merging, but I wanted to get your opinion.

This looks amazing, thank you!
I read the code and my little understanding saw no issue.
I'll clone and run it.

I added a few dbg! and I can see that in Chat a second message doesn't use the KV cache of the first.
Ideally this would be supported. When doing constrained generation of say Markdown, one needs to send the request with the # that marks the heading, then the model completes the heading, then re-send the prompt + heading for the model to generate a list and so on.
Besides that, even when the cache was hit, I could not tell a performance difference on my system :thinking:

Yes, it doesn't cache the entire KV cache of the previous request, only the prompt. Given sampling, I don't think that would be a good idea, but please let me know.
I have fixed the lack of performance improvement, it is now much faster!

Yes, it doesn't cache the entire KV cache of the previous request, only the prompt. Given sampling, I don't think that would be a good idea, but please let me know.

That would be good enough. In my example it'd re-calculate a handful of tokens every request. My understanding was that it wouldn't use any part of the cache if the prompt is not entirely cached.

I have fixed the lack of performance improvement, it is now much faster!

Yes, it is for me too


Integrate Nutri-Patrol at various relevant places in the app (tracker)

What

Integrate Nutri-Patrol at various relevant places in the app (tracker)

Blocked on

https://github.com/openfoodfacts/nutripatrol-frontend/issues/58
https://github.com/openfoodfacts/openfoodfacts-dart/issues/885

Scopes

https://github.com/openfoodfacts/nutripatrol/issues/59

Where

Photo manager
Price Proof manager
Editing form
Product page
Search results

Why

Moderation of content

Part of

#525

@g123k @monsieurtanuki NutriPatrol is now live in production
Tickets only available to moderators
Flagging available to everyone (logged-in)
Flagging webviews by Valentin:
A product https://nutripatrol.openfoodfacts.org/flag/product?barcode=3017620422003&source=web&flavor=off
A image https://nutripatrol.openfoodfacts.org/flag/image?barcode=3017620422003&source=web&flavor=off&image_id=1
We can do it in two times, integrate as links to webviews, then integrate natively at a later point. All the more that integrations need to be done at several places, and that's some work: https://github.com/openfoodfacts/smooth-app/issues/5390

I have already discussed this with Valentin and it would be nice to let him implement it (and give him some help).

Could you asign me on this issue please ?

The code has been deployed: https://github.com/openfoodfacts/openfoodfacts-server/pull/10991
There are server side issues: https://world.openfoodfacts.org/product/4607074063892 eg the // on the url for Report this product to our moderators https://nutripatrol.openfoodfacts.org//flag/product/?barcode=4607074063892&source=web&flavor=off
There's a new smoothie action that needs to be implemented for the Knowledge panel to work (see the tt.json file in the pull request above)
I'm not sure whether @alexgarel out of an abondance of caution hasn't put it behind a url flag
@Valimp @g123k


Fix specs for primitive arrays

To add support primitive arrays
https://github.com/ruby-grape/grape-swagger-entity/pull/7

@LeFnord i think this can be merged

👍


ISPN-5139 Fix trace logs of clustered interceptors

https://issues.jboss.org/browse/ISPN-5139

Integrated


Migrate content from release notes on docs.amd.com to GitHub

Note: this is a development task.
In order to ensure the accuracy of this GitHub repository, release notes from docs.amd.com for all ROCm releases 5.0 to 5.4 to the file https://github.com/RadeonOpenCompute/ROCm/blob/develop/CHANGELOG.md.
A few specific instructions for the migration. Content for the math libraries should be copied from GitHub repositories via scripts. A prewritten script will be provided upon request by email.
OS and GPU support information should not be copied into the CHANGELOG.

@saadrahim Few questions:

This should be a pure GFM file right?
Should the math libraries changes be grouped per library or per ROCm release?
Do we want a neater, more interactive version (foldouts, reference links) with Myst for use in the webview? I can generate this easily with how the script is setup.

We can discuss during the meeting.

@saadrahim Few questions:

This should be a pure GFM file right?
Yes, must be pure GFM
Should the math libraries changes be grouped per library or per ROCm release?
Everything should be grouped per ROCm release.
Do we want a neater, more interactive version (foldouts, reference links) with Myst for use in the webview? I can generate this easily with how the script is setup.
use valid GFM html and other GitHub recommended techniques.

We can discuss during the meeting.

@saadrahim

Is it possible to get the source-text of the release notes on docs.amd.com? Maybe it's already in Markdown. That would make everything a lot easier for me.

There is a lot of duplication in the deprecation notes between the releases on docs.amd.com. Should we group these by major/minor releases? Or keep them on a per-patch basis (there will be a lot of text)?

Release Notes: (Proposed)

ROCm 5.4.x

HIPCC Deprecation
Patch Notes

ROCm 5.4.3
ROCm 5.4.2
ROCm 5.4.1
ROCm 5.4.0

ROCm 5.3.x

HIPCC Deprecation
Patch Notes

ROCm 5.3.3
ROCm 5.3.2
...

Release Notes: (Current)

ROCm 5.4.3

HIPCC Deprecation

ROCm 5.4.2

HIPCC Deprecation

ROCm 5.4.1

HIPCC Deprecation

ROCm 5.4.0

HIPCC Deprecation

ROCm 5.3.3

HIPCC Deprecation

...

I think having things grouped by major/minor version first allows people to get the most important things first and the patch specific changes can be read without going through all the boilerplate of all the shared items.

I am happy to provide the release notes' source files, which are not in Markdown.
The replication of deprecation content is intended; they are, sometimes, a reminder/warning to our users for upcoming and actual deprecations in a release.

@Rmalavally

I am happy to provide the release notes' source files, which are not in Markdown.

Awesome, feel free to contact me via email: nara <at> streamhpc <dot> com

The replication of deprecation content is intended; they are, sometimes, a reminder/warning to our users for upcoming and actual deprecations in a release.

That makes sense. Will keep the same ordering then.

Can you access Sharepoint or Confluence yet?

Not yet, but no ETA yet so it could take a while. I'll probably just convert everything manually then.

Please let me know when you have access, and I can share the source files with you.


[BUG] eks with ip whitelists, using the lustre integration module fails

Describe the bug
When using eks with ip whitelists, using the lustre integration module fails.
To Reproduce

Create eks module

path: git::https://github.com/awslabs/idf-modules.git//modules/compute/eks?ref=release/1.11.0&depth=1
with ip whitelists

name: eks-compute
value:
...
eks_api_endpoint_private: False
ips_to_whitelist_adhoc: ${IPS_TO_WHITELIST_ADHOC}

create fsx module

path: git::https://github.com/awslabs/idf-modules.git//modules/storage/fsx-lustre?ref=release/1.11.0&depth=1

create lustre-on-eks module

path: git::https://github.com/awslabs/idf-modules.git//modules/integration/fsx-lustre-on-eks?ref=release/2.11.0&depth=1
Expected behavior
EKS and FSx created, connected via lustre-on-eks.
Error
I guess it cannot download the manifest becasue it has no connection to the outside anymore?:

addf-llpdrsw-integration-lustre-on-eks |  7/13 | 11:09:16 AM | CREATE_IN_PROGRESS   | Custom::AWSCDK-EKS-KubernetesResource | namespace/Resource/Default (namespace177341A3) Resource creation Initiated

580

RCA: When using ips_to_whitelist_adhoc, a PUBLIC_AND_PRIVATE cluster API endpoint is created with public access only being limited to whitelisted IPs and private to traffic only from within the VPC. FSX for Lustre on EKS integration module deploys manifests via custom resources, which requires custom resource lambdas to be provisioned in private VPC subnets to be able to access the cluster API endpoint.
@swirkert1, a fix is merged and planned for the upcoming release. As the release is cut, please make sure to update your integration/fsx-for-lustre-on-eks manifests to the latest version and pass VpcId and PrivateSubnetIds of your EKS cluster.
  - name: VpcId
    valueFrom:
      moduleMetadata:
        group: base
        name: networking
        key: VpcId
  - name: PrivateSubnetIds
    valueFrom:
      moduleMetadata:
        group: base
        name: networking
        key: PrivateSubnetIds

Closing as completed. Please use v1.12.0.


observer.midnight fails for some input Time values

python 3.6
astropy 3.2.2
astroplan 0.6
example code to generate the error:
from astroplan import Observer
import astropy.units as u
from astropy.time import Time

observer = Observer(longitude=-67.8 * u.deg,
                    latitude=0 * u.deg,
                    elevation=0 * u.m)

i = Time(1480479600, format='unix')
near_midnight = observer.midnight(i, which='nearest')

generated error:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-24-55761e37d700> in <module>
      9
     10 i = Time(1480479600, format='unix')
---> 11 near_midnight = observer.midnight(i, which='nearest')

/etc/anaconda3/lib/python3.7/site-packages/astroplan/observer.py in midnight(self, time, which, n_grid_points)
   1344         """
   1345         return self.target_meridian_antitransit_time(time, get_sun(time), which,
-> 1346                                                      n_grid_points=n_grid_points)
   1347
   1348     # Twilight convenience functions

/etc/anaconda3/lib/python3.7/site-packages/astroplan/observer.py in target_meridian_antitransit_time(self, time, target, which, grid_times_targets, n_grid_points)
   1184                                                 rise_set='setting',
   1185                                                 n_grid_points=n_grid_points,
-> 1186                                                 grid_times_targets=grid_times_targets))
   1187
   1188     @u.quantity_input(horizon=u.deg)

/etc/anaconda3/lib/python3.7/site-packages/astroplan/observer.py in _determine_which_event(self, function, args_dict)
    924
    925         if which == 'nearest':
--> 926             mask = abs(time - previous_event) < abs(time - next_event)
    927             return Time(np.where(mask, previous_event.utc.jd,
    928                                  next_event.utc.jd), format='jd')

/etc/anaconda3/lib/python3.7/site-packages/astropy/time/core.py in __sub__(self, other)
   1774
   1775             if other.scale != out.scale:
-> 1776                 other = getattr(other, out.scale)
   1777
   1778         jd1 = out._time.jd1 - other._time.jd1

/etc/anaconda3/lib/python3.7/site-packages/astropy/time/core.py in __getattr__(self, attr)
   1526                 else:
   1527                     tm = self.replicate()
-> 1528                     tm._set_scale(attr)
   1529                     if tm.shape:
   1530                         # Prevent future modification of cached array-like object

/etc/anaconda3/lib/python3.7/site-packages/astropy/time/core.py in _set_scale(self, scale)
    723
    724         if self.masked:
--> 725             jd2[self.mask] = np.nan
    726
    727         self._time = self.FORMATS[self.format](jd1, jd2, scale, self.precision,

TypeError: 'numpy.float64' object does not support item assignment

I've found that small changes to either the longitude or the argument to Time do not produce this error and seem to produce the expected result. Changing the elevation and the latitude do not seem to effect the result.

Hi,
Please update astroplan and astropy, this error is a compatibility problem between old versions of these two packages.


Drag and drop should drop the element in the selected element

Expected behavior
Drag and drop should drop the element in the selected element
Actual behavior
It does not drop in the specified location
Steps to replicate
const { openBrowser, goto, text, inputField, rightClick, $, dragAndDrop } = require('taiko');
(async () => {
    try {
        await openBrowser();
goto("https://www.w3schools.com/HTML/html5_draganddrop.asp",{timeout:60000});
        await dragAndDrop($("#drag1"),$("#div2"));
    } catch (e) {
        console.error(e);
    } finally {
        await closeBrowser();
    }
})();

Version
commit - c184a28f73a14c8bfd25a9c9f3e319c0c3b23a02

Blocks #107

Happening because of https://github.com/getgauge/taiko/issues/279


Complete migration of scripts notebooks or other fates

Scripts to be converted or retired.

[x] FASPScript1
[ ] FASPScript2
[x] FASPScript3
[ ] FASPScript4
[x] FASPScript5
[ ] FASPScript6
[ ] FASPScript7
[ ] FASPScript8
[x] FASPScript9
[x] FASPScript10
[ ] FASPScript11
[ ] FASPScript12
[x] FASPScript13
[x] FASPScript14
[x] FASPScript15
[ ] FASPScript16
[x] FASPScript17
[ ] FASPScript18

Created FASPNotebook07, still using BigQuery - needs lower case column names for tables.

FASPScript11 is a special case because the SRA Data Locator needs to be run in the same region as the data.


dep ensure hangs indefinitely when github 404 is in required and github.com is not in SSH known hosts

What version of dep are you using (dep version)?

dep version v0.4.1-157-gf9cb443

Problem statement
When a github project that 404s is added to required, and the github host is unknown to ssh dep ensure hangs indefinitely on the ssh unknown host prompt. I unfortunately ran into this when I added a url with a typo...
Steps to reproduce
#Back up or remove ~/.ssh/known_hosts
mv ~/.ssh/known_hosts ~/.ssh/known_hosts.bak

Add a project with a fake url
> cat Gopkg.toml
required = ["github.com/doesnotexist/doesnotexist"]

[prune]
  go-tests = true
  unused-packages = true

Then run dep ensure. ctrl-c and It will hang at Signal received: waiting for 1 ops to complete.... Then you have to ctrl-c again or send QUIT with ctrl-\ since it hangs there as well.
After investigating the code in vcs_source.go with the debug information below, I found that for repositories which 404 we first do git ls-remote https://github.com/doesnotexist/doesnotexist which does not prompt for password as expected, and then git ls-remote ssh://github.com/doesnotexist/doesnotexist. If github.com's ip is not in the known hosts, the openssh client will prompt directly to /dev/tty. This causes the command to hang waiting for input. For some reason the actual prompt is not printed however.
Environment
go version: go version go1.10 linux/amd64
OS:  Ubuntu 16.04
Debugging:
Output on termination, ctrl-c and then ctrl-\ to send sigangry because ctrl-c also hangs:
> dep ensure
^CSignal received: waiting for 1 ops to complete...
^C^\SIGQUIT: quit
PC=0x45ba91 m=0 sigcode=128

goroutine 0 [idle]:
runtime.futex(0xc00848, 0x0, 0x0, 0x0, 0x7ffe00000000, 0x0, 0x0, 0x0, 0x7ffe8b53fce8, 0x410cfb, ...)
	/home/diserovich/go/src/runtime/sys_linux_amd64.s:526 +0x21
runtime.futexsleep(0xc00848, 0x7ffe00000000, 0xffffffffffffffff)
	/home/diserovich/go/src/runtime/os_linux.go:45 +0x4b
runtime.notesleep(0xc00848)
	/home/diserovich/go/src/runtime/lock_futex.go:151 +0x9b
runtime.stoplockedm()
	/home/diserovich/go/src/runtime/proc.go:2096 +0x8c
runtime.schedule()
	/home/diserovich/go/src/runtime/proc.go:2488 +0x2da
runtime.park_m(0xc42007ea80)
	/home/diserovich/go/src/runtime/proc.go:2599 +0xb6
runtime.mcall(0x0)
	/home/diserovich/go/src/runtime/asm_amd64.s:351 +0x5b

goroutine 1 [syscall]:
syscall.Syscall6(0xf7, 0x1, 0x3ba, 0xc4200f9c88, 0x1000004, 0x0, 0x0, 0x0, 0xc42007c000, 0x0)
	/home/diserovich/go/src/syscall/asm_linux_amd64.s:44 +0x5
os.(*Process).blockUntilWaitable(0xc420234780, 0x0, 0x0, 0x3)
	/home/diserovich/go/src/os/wait_waitid.go:31 +0x98
os.(*Process).wait(0xc420234780, 0xc42021e6c0, 0x0, 0xc42007c000)
	/home/diserovich/go/src/os/exec_unix.go:22 +0x3c
os.(*Process).Wait(0xc420234780, 0x96ebf8, 0x96ec00, 0x96ebf0)
	/home/diserovich/go/src/os/exec.go:123 +0x2b
os/exec.(*Cmd).Wait(0xc420262420, 0x96e438, 0x9ba6a0)
	/home/diserovich/go/src/os/exec/exec.go:461 +0x5c
github.com/golang/dep/gps.cmd.CombinedOutput(0x9ba6a0, 0xc42022a5f0, 0xc420262420, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/gps/cmd_unix.go:80 +0x160
github.com/golang/dep/gps.(*gitSource).listVersions(0xc420236330, 0x9ba6a0, 0xc42022a5f0, 0x435c54, 0xc4200fa250, 0x412568, 0x10, 0x8d3300)
	/home/diserovich/test/src/github.com/golang/dep/gps/vcs_source.go:233 +0x2f2
github.com/golang/dep/gps.(*sourceGateway).loadLatestVersionList.func1(0x9ba6a0, 0xc42022a5f0, 0x9ba3a0, 0xc4200b5b80)
	/home/diserovich/test/src/github.com/golang/dep/gps/source.go:593 +0x6d
github.com/golang/dep/gps.(*supervisor).do(0xc42008d8c0, 0x9ba3e0, 0xc4200ac018, 0x94a252, 0x3, 0x1, 0xc4200fa368, 0x0, 0xc4200fa370)
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:675 +0xd5
github.com/golang/dep/gps.(*sourceGateway).loadLatestVersionList(0xc42022a550, 0x9ba3e0, 0xc4200ac018, 0xc42022a5a0, 0x50, 0x50)
	/home/diserovich/test/src/github.com/golang/dep/gps/source.go:591 +0xf8
github.com/golang/dep/gps.(*sourceGateway).sourceExistsUpstream(0xc42022a550, 0x9ba3e0, 0xc4200ac018, 0x0, 0xc4200fa448, 0x412568)
	/home/diserovich/test/src/github.com/golang/dep/gps/source.go:557 +0x63
github.com/golang/dep/gps.(*sourceGateway).require(0xc42022a550, 0x9ba3e0, 0xc4200ac018, 0xc400000001, 0x778375, 0x8cdb00)
	/home/diserovich/test/src/github.com/golang/dep/gps/source.go:617 +0x178
github.com/golang/dep/gps.newSourceGateway(0x9ba3e0, 0xc4200ac018, 0x9be900, 0xc420236330, 0xc42008d8c0, 0xc4201b5ea0, 0x1d, 0x0, 0x0, 0xc420232560)
	/home/diserovich/test/src/github.com/golang/dep/gps/source.go:284 +0x216
github.com/golang/dep/gps.(*sourceCoordinator).getSourceGatewayFor(0xc4201d35e0, 0x9ba3e0, 0xc4200ac018, 0xc420234330, 0x24, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/gps/source.go:219 +0xad1
github.com/golang/dep/gps.(*SourceMgr).SourceExists(0xc42008d920, 0xc420234330, 0x24, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:489 +0x88
github.com/golang/dep/gps.(*bridge).SourceExists(0xc420222810, 0xc420234330, 0x24, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/gps/bridge.go:124 +0x93
github.com/golang/dep/gps.(*solver).createVersionQueue(0xc42024e5a0, 0xc420234330, 0x24, 0x0, 0x0, 0xc420236290, 0x1, 0x1, 0x0, 0x0, ...)
	/home/diserovich/test/src/github.com/golang/dep/gps/solver.go:811 +0xed
github.com/golang/dep/gps.(*solver).solve(0xc42024e5a0, 0x9ba3e0, 0xc4200ac018, 0x40, 0x40, 0x8)
	/home/diserovich/test/src/github.com/golang/dep/gps/solver.go:517 +0x5b7
github.com/golang/dep/gps.(*solver).Solve(0xc42024e5a0, 0x9ba3e0, 0xc4200ac018, 0xc4202260e0, 0x20, 0x20, 0xc420222200)
	/home/diserovich/test/src/github.com/golang/dep/gps/solver.go:457 +0xe4
main.(*ensureCommand).runDefault(0xc42019f916, 0xc42008d0e0, 0xc420159740, 0x0, 0x0, 0xc42008d140, 0x9bdae0, 0xc42008d920, 0xc420026064, 0x1e, ...)
	/home/diserovich/test/src/github.com/golang/dep/cmd/dep/ensure.go:301 +0x168
main.(*ensureCommand).Run(0xc42019f916, 0xc42008d0e0, 0xc420159740, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/cmd/dep/ensure.go:219 +0x867
main.(*Config).Run(0xc42008cfc0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/cmd/dep/main.go:232 +0x10e5
main.main()
	/home/diserovich/test/src/github.com/golang/dep/cmd/dep/main.go:69 +0x52c

goroutine 20 [syscall]:
os/signal.signal_recv(0x9b7a40)
	/home/diserovich/go/src/runtime/sigqueue.go:139 +0xa6
os/signal.loop()
	/home/diserovich/go/src/os/signal/signal_unix.go:22 +0x22
created by os/signal.init.0
	/home/diserovich/go/src/os/signal/signal_unix.go:28 +0x41

goroutine 21 [select, locked to thread]:
runtime.gopark(0x96eff8, 0x0, 0x94b32f, 0x6, 0x18, 0x1)
	/home/diserovich/go/src/runtime/proc.go:291 +0x11a
runtime.selectgo(0xc42003ff50, 0xc42008e4e0)
	/home/diserovich/go/src/runtime/select.go:392 +0xe50
runtime.ensureSigM.func1()
	/home/diserovich/go/src/runtime/signal_unix.go:549 +0x1f4
runtime.goexit()
	/home/diserovich/go/src/runtime/asm_amd64.s:2361 +0x1

goroutine 22 [semacquire]:
sync.runtime_notifyListWait(0xc42008d8e8, 0xc400000000)
	/home/diserovich/go/src/runtime/sema.go:510 +0x10b
sync.(*Cond).Wait(0xc42008d8d8)
	/home/diserovich/go/src/sync/cond.go:56 +0x80
github.com/golang/dep/gps.(*supervisor).wait(0xc42008d8c0)
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:743 +0x43
github.com/golang/dep/gps.(*SourceMgr).Release.func1()
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:391 +0x45
sync.(*Once).Do(0xc42008d970, 0xc4200406c0)
	/home/diserovich/go/src/sync/once.go:44 +0xbe
github.com/golang/dep/gps.(*SourceMgr).Release(0xc42008d920)
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:388 +0x52
github.com/golang/dep/gps.(*SourceMgr).HandleSignals.func1(0xc42008d920, 0xc42008d980, 0xc42008e5a0)
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:345 +0x194
created by github.com/golang/dep/gps.(*SourceMgr).HandleSignals
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:330 +0xb2

goroutine 35 [semacquire]:
sync.runtime_Semacquire(0xc4201d3604)
	/home/diserovich/go/src/runtime/sema.go:56 +0x39
sync.(*RWMutex).RLock(0xc4201d35f8)
	/home/diserovich/go/src/sync/rwmutex.go:50 +0x49
github.com/golang/dep/gps.(*sourceCoordinator).getSourceGatewayFor(0xc4201d35e0, 0x9ba3e0, 0xc4200ac018, 0xc420234330, 0x24, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/gps/source.go:94 +0xc6
github.com/golang/dep/gps.(*SourceMgr).SyncSourceFor(0xc42008d920, 0xc420234330, 0x24, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/test/src/github.com/golang/dep/gps/source_manager.go:513 +0x82
github.com/golang/dep/gps.(*bridge).SyncSourceFor(0xc420222810, 0xc420234330, 0x24, 0x0, 0x0, 0xc42022a280, 0x1)
	/home/diserovich/test/src/github.com/golang/dep/gps/bridge.go:214 +0x5b
created by github.com/golang/dep/gps.(*solver).selectRoot
	/home/diserovich/test/src/github.com/golang/dep/gps/solver.go:644 +0x614

goroutine 40 [IO wait]:
internal/poll.runtime_pollWait(0x7f0bd9d92f00, 0x72, 0xc420260ce8)
	/home/diserovich/go/src/runtime/netpoll.go:173 +0x57
internal/poll.(*pollDesc).wait(0xc42022a6a8, 0x72, 0xffffffffffffff01, 0x9b5660, 0xbc4540)
	/home/diserovich/go/src/internal/poll/fd_poll_runtime.go:85 +0x9b
internal/poll.(*pollDesc).waitRead(0xc42022a6a8, 0xc4202a0001, 0x200, 0x200)
	/home/diserovich/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc42022a690, 0xc4202a0000, 0x200, 0x200, 0x0, 0x0, 0x0)
	/home/diserovich/go/src/internal/poll/fd_unix.go:157 +0x17d
os.(*File).read(0xc4202280c0, 0xc4202a0000, 0x200, 0x200, 0xc4202a0000, 0x0, 0x0)
	/home/diserovich/go/src/os/file_unix.go:226 +0x4e
os.(*File).Read(0xc4202280c0, 0xc4202a0000, 0x200, 0x200, 0x0, 0x0, 0xc420260e60)
	/home/diserovich/go/src/os/file.go:107 +0x6a
bytes.(*Buffer).ReadFrom(0xc4202382a0, 0x9b4aa0, 0xc4202280c0, 0x7f0bd9d0e020, 0xc4202382a0, 0x1)
	/home/diserovich/go/src/bytes/buffer.go:205 +0xa0
io.copyBuffer(0x9b4080, 0xc4202382a0, 0x9b4aa0, 0xc4202280c0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/diserovich/go/src/io/io.go:386 +0x31a
io.Copy(0x9b4080, 0xc4202382a0, 0x9b4aa0, 0xc4202280c0, 0x0, 0x0, 0x0)
	/home/diserovich/go/src/io/io.go:362 +0x5a
os/exec.(*Cmd).writerDescriptor.func1(0x0, 0x0)
	/home/diserovich/go/src/os/exec/exec.go:275 +0x4d
os/exec.(*Cmd).Start.func1(0xc420262420, 0xc4202325c0)
	/home/diserovich/go/src/os/exec/exec.go:396 +0x27
created by os/exec.(*Cmd).Start
	/home/diserovich/go/src/os/exec/exec.go:395 +0x5df

goroutine 41 [chan receive]:
github.com/golang/dep/gps.cmd.CombinedOutput.func1(0x9ba6a0, 0xc42022a5f0, 0xc420262420, 0xc42021e6c0)
	/home/diserovich/test/src/github.com/golang/dep/gps/cmd_unix.go:74 +0x203
created by github.com/golang/dep/gps.cmd.CombinedOutput
	/home/diserovich/test/src/github.com/golang/dep/gps/cmd_unix.go:63 +0x152

rax    0xca
rbx    0xc00700
rcx    0x45ba93
rdx    0x0
rdi    0xc00848
rsi    0x0
rbp    0x7ffe8b53fcb0
rsp    0x7ffe8b53fc68
r8     0x0
r9     0x0
r10    0x0
r11    0x286
r12    0xc42003ff68
r13    0xff
r14    0xff
r15    0xf
rip    0x45ba91
rflags 0x286
cs     0x33
fs     0x0
gs     0x0

Strace output:
...
epoll_ctl(4, EPOLL_CTL_ADD, 5, {EPOLLIN|EPOLLOUT|EPOLLRDHUP|EPOLLET, {u32=3174006528, u64=139666920537856}}) = -1 EPERM (Operation not permitted)
epoll_ctl(4, EPOLL_CTL_DEL, 5, 0xc4200e6edc) = -1 EPERM (Operation not permitted)
fstat(5, {st_mode=S_IFREG|0600, st_size=5, ...}) = 0
read(5, "1542\n", 517)                  = 5
read(5, "", 512)                        = 0
close(5)                                = 0
kill(1542, SIG_0)                       = -1 ESRCH (No such process)
unlinkat(AT_FDCWD, "/home/diserovich/test/pkg/dep/sm.lock", 0) = 0
openat(AT_FDCWD, "/home/diserovich/test/pkg/dep/sm.lock.843843724", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 5
epoll_ctl(4, EPOLL_CTL_ADD, 5, {EPOLLIN|EPOLLOUT|EPOLLRDHUP|EPOLLET, {u32=3174006528, u64=139666920537856}}) = -1 EPERM (Operation not permitted)
epoll_ctl(4, EPOLL_CTL_DEL, 5, 0xc4200e6e84) = -1 EPERM (Operation not permitted)
getpid()                                = 1622
write(5, "1622\n", 5)                   = 5
linkat(AT_FDCWD, "/home/diserovich/test/pkg/dep/sm.lock.843843724", AT_FDCWD, "/home/diserovich/test/pkg/dep/sm.lock", 0) = 0
lstat("/home/diserovich/test/pkg/dep/sm.lock.843843724", {st_mode=S_IFREG|0600, st_size=5, ...}) = 0
lstat("/home/diserovich/test/pkg/dep/sm.lock", {st_mode=S_IFREG|0600, st_size=5, ...}) = 0
close(5)                                = 0
unlinkat(AT_FDCWD, "/home/diserovich/test/pkg/dep/sm.lock.843843724", 0) = 0
close(3)                                = 0
unlinkat(AT_FDCWD, "/home/diserovich/test/pkg/dep/sm.lock.861287841", 0) = 0
futex(0xc420046d48, FUTEX_WAKE, 1)      = 1
rt_sigprocmask(SIG_SETMASK, ~[HUP INT QUIT ILL TRAP ABRT BUS FPE SEGV TERM STKFLT CHLD PROF SYS RTMIN RT_1], NULL, 8) = 0
futex(0xc420046d48, FUTEX_WAKE, 1)      = 1
rt_sigprocmask(SIG_SETMASK, ~[HUP INT QUIT ILL TRAP ABRT BUS FPE SEGV TERM STKFLT CHLD PROF SYS RTMIN RT_1], NULL, 8) = 0
futex(0xc420046948, FUTEX_WAKE, 1)      = 1
futex(0xc00848, FUTEX_WAIT, 0, NULL)    = 0
futex(0xc00848, FUTEX_WAIT, 0, NULL

Hey @davidmi, good find! Are you interested in submitting a PR for this?

Yes but I'm not sure of what the correct workaround would be. The ssh prompt can't be bypassed since it reads directly from /dev/tty. Potential solutions I've thought of are:

a timeout, but reading the code in cmd.go it seems like this isn't considered an ideal solution. Also a long list of typo'd URLs would be a pathological situation that would also seem to hang for the user.
disabling strict host key checking for this command. Doesn't seem ideal, but since this isn't the actual clone operation (we just want to see if the repo exists with ls-remote) it might be OK. This solution also leaves open the edge case of a repository which has not been cloned yet that is only accessible through ssh, which would then hang on the prompt for clone.
finding some way to make it seem to to the subrocess that it's running headless/with no /dev/tty. I can't figure out how to do this except the nohup command, and that is probably not present on all systems. Perhaps there's something I can use in the Go standard library but I haven't figured it out.

Any suggestions?

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!


[Feature Request] Add ability to auto-maximize video to viewport dimensions on load

Title pretty much sums it up, would like a way to have the maximize behavior that is triggered by the maximize button to occur when a video is initially loaded. Having a toggle for this in settings page would be awesome.
Thanks.

@sjclayton Thanks for making an issue. I'll add that in the next update.

Hi @sjclayton,
While working on your requested feature, I noticed that the code for maximizing the player needs some cleaning up to smoothly integrate with the automatic maximize player feature. This cleanup might extend the time needed to finish your feature. Thanks for your understanding! 🛠

If I could make an addendum to this feature. Could you also make it so you can still scroll the page with Maximize enabled? It was the one feature I liked most about another youtube addon before it broke.

@happygolucky919 I should be able to do that I think.

Feature menu is offset above the player controls way more than it should be when maximize player is enabled

Just a bit of info I put into a file so I know what I have to do when re-writing the maximize player feature.
I'm working on making the feature actually proper right now it works but it relies on the theater mode being enabled which is janky. The list of things to be updated  is what I have discovered that need adjusting ones with check marks I already know how to implement.
@sjclayton mentioning you to let you know I'm working on this the auto maximize feature shouldn't be delayed much longer after I finish determine what needs to be adjusted then implement that.

There is hope @sjclayton https://github.com/VampireChicken12/youtube-enhancer/commit/f97aa3bdbc9b4755861dbdfcb0e96dba4a473d39 sorry for taking so long. I just want to make the feature as good as possible.

@VampireChicken12
Any hope for this? It's one of the main things that is still missing for me in using this extension full time.

@sjclayton I'm going to continue working on this. Are you okay with the seek preview being messed up until I figured out how to get it fixed. I was re-writing the maximize feature then I was going to implement this feature.

@VampireChicken12
The seek preview is working fine for me currently as far as I know... I'm using the last actual release as of now (1.26.0)

@sjclayton
yes in the current version it is but in the re-worked feature it doesn't work properly it. I can't show how it looks right now.

@VampireChicken12
Well keep working on it and release it when it's ready... I can't not have the seek preview working.

@sjclayton okay, it works but it doesn't fit the the full size.


Fix selenium tests

What is the context of this PR?
Describe what you have changed and why.
How to review
Describe the steps required to test the changes.

[ ] Do all commits have sensible commit messages?
[ ] Is all new code unit tested?
[ ] Are there integration tests if needed?
[ ] Is there sufficient logging?
[ ] Is there documentation or is the code self-describing?

Who worked on the PR
Describe who worked on the changes, so that other people can review.

Current coverage is 78.81% (diff: 100%)

Merging #416 into master will not change coverage

@@             master       #416   diff @@
==========================================
  Files           139        139
  Lines          4951       4951
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           3902       3902
  Misses         1049       1049
  Partials          0          0

Powered by Codecov. Last update 14622c6...df09f65

Current coverage is 78.81% (diff: 100%)

Merging #416 into master will not change coverage

@@             master       #416   diff @@
==========================================
  Files           139        139
  Lines          4951       4951
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           3902       3902
  Misses         1049       1049
  Partials          0          0

Powered by Codecov. Last update 14622c6...df09f65

Current coverage is 78.81% (diff: 100%)

Merging #416 into master will not change coverage

@@             master       #416   diff @@
==========================================
  Files           139        139
  Lines          4951       4951
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           3902       3902
  Misses         1049       1049
  Partials          0          0

Powered by Codecov. Last update 14622c6...df09f65

This works now but warrants splitting up into individual PRs to address the bugs fixed, test changes and travis config separately.


fix-flaky: MultiCodecReindexIT

Description
The test spawns random number of data, client and manager nodes which sometimes lead to connect_exception when any of the test nodes fail to connect to the other node(s) leading to flakiness. Let's use only one data node as per the requirement of the test to reduce flakiness.
Related Issues
Resolves #8980
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] ~New functionality has been documented.~

[ ] ~New functionality has javadoc added~

[x] Commits are signed per the DCO using --signoff
[ ] ~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~

rashiwal@local ➜  ./gradlew ':modules:reindex:internalClusterTest' --tests "org.opensearch.index.codec.MultiCodecReindexIT"

> Configure project :
========================= WARNING =========================
         Backwards compatibility tests are disabled!
See https://github.com/opensearch-project/OpenSearch/issues/4173
===========================================================
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.4
  OS Info               : Mac OS X 13.5.2 (x86_64)
  JDK Version           : 11 (Amazon Corretto JDK)
  JAVA_HOME             : /Users/rashiwal/.sdkman/candidates/java/11.0.19-amzn
  Random Testing Seed   : CD1EB507DB38F56C
  In FIPS 140 mode      : false
=======================================
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/Users/rashiwal/workplace/OpenSearch/test/framework/build/distributions/framework-3.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/Users/rashiwal/.gradle/wrapper/dists/gradle-8.4-all/56r6xik2f6skrm47et0ibifug/gradle-8.4/lib/plugins/gradle-testing-base-8.4.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

BUILD SUCCESSFUL in 30s
69 actionable tasks: 1 executed, 68 up-to-date

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97 : Can I have a review? Thanks 😄

@r1walz looks good to me! Please run multiple iterations and confirm if the flaky-ness is fixed.

@sarthakaggarwal97 wrote:

@r1walz looks good to me! Please run multiple iterations and confirm if the flaky-ness is fixed.

No issues for 500 iteration run:
$ ./gradlew ':modules:reindex:internalClusterTest' --tests "org.opensearch.index.codec.MultiCodecReindexIT" -Dtests.iters=500 -Dtests.timeoutSuite='500000000!'
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.4
  OS Info               : Linux 5.4.257-177.360.amzn2int.x86_64 (amd64)
  JDK Version           : 11 (Amazon Corretto JDK)
  JAVA_HOME             : /local/home/rashiwal/.sdkman/candidates/java/11.0.19-amzn
  Random Testing Seed   : 20DCD5ADB634C4C9
  In FIPS 140 mode      : false
=======================================
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/workplace/rashiwal/OpenSearch/test/framework/build/distributions/framework-3.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/local/home/rashiwal/.gradle/wrapper/dists/gradle-8.4-all/56r6xik2f6skrm47et0ibifug/gradle-8.4/lib/plugins/gradle-testing-base-8.4.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

BUILD SUCCESSFUL in 1h 20m 40s
69 actionable tasks: 1 executed, 68 up-to-date

thanks @r1walz! @reta @shwetathareja please take a look!

Yes, @ankitkala. I'm running these tests in the background. Will wait for 1000+ runs to get completed.

1286 runs passed and still running:

Let's use only one data node as per the requirement of the test to reduce flakiness.

As has been mentioned in this comment thread, I don't think this is the right direction. I think by avoiding multi-node setups this is hiding an issue - as a vast majority of tests run on multi-node setups.
There are some outstanding suggestions; I'd recommend if it isn't clear how to proceed after following those suggestion add telemetry to the logs around the test failure. It can help our understanding of the issue and better point towards the root cause.

Looks like the comment thread where we were discussing the fix got deleted. Does anyone know what happened?

@r1walz could you please backport to 2.x manually? thank you


Wrong namespace listed for VariableNumber

The message for a VariableNumber offense incorrectly lists the namespace as Style, rather than Naming.

Expected behavior
The message displayed for a VariableNumber violation should say:

Naming/VariableNumber

Actual behavior
The message actually displayed says:

Style/VariableNumber

Screenshot:

Steps to reproduce the problem
I think simply including a violation should replicate the problem. E.g.:
variable_1 = 1

Perhaps additional switches are necessary.  I encounter the error when running:

$ rubocop -RD -f html > rubocop.html test/controllers/observer_controller_test.rb

for the app in https://github.com/MushroomObserver/mushroom-observer.
But note that I am in the process of removing the RuboCop violations in that file, so to reproduce the problem in that app, it may be necessary to deliberately add a violation.
RuboCop version
$ rubocop -V
0.49.1 (using Parser <IP_ADDRESS>, running on ruby 2.2.3 x86_64-linux)

VariableNumber cop has been renamed to Naming/VariableNumber in master, but it hasn't been released yet. So, the cops says Style/VariableNumber in v0.49.1 .
Our documentation mentions about master branch by default.
https://readthedocs.org/projects/rubocop/

So, I think we should change the default to stable, and build the documentation each release.
The latest version is updated each commit in master, but the stable version is updated each latest release. http://docs.readthedocs.io/en/latest/versions.html#
@bbatsov Could you change the project setting or invite me to readthedocs? My account name is pocke.

@pocke: Thank you so much for the explanation!


build: depend on the architecture variant on non-MachO

For the non-MachO targets, which do not have the concept of fat
binaries, depend explicitly on the architecture variant.  This is
particularly useful for Windows which permits cross-compilation and
cross-targeting of all the variants even though it does not support fat
binaries.  This allows us to build a single variant of the windows
standard library at a time in the case that we would like to build a
subset of the targets.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 825864411b7712db40323ff6332444400fb6167d

Build failed
Swift Test Linux Platform
Git Sha - 825864411b7712db40323ff6332444400fb6167d

@swift-ci please test linux platform

Build failed
Swift Test Linux Platform
Git Sha - 53122666bb0b6661f2586056ff48b206d2ea3ce6

Please test with following pull request:
https://github.com/apple/swift-corelibs-foundation/pull/1354
@swift-ci Please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 53122666bb0b6661f2586056ff48b206d2ea3ce6

Please test with following pull request:
@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 53122666bb0b6661f2586056ff48b206d2ea3ce6


tests: adds a test to verify a query argument does not block in phase 2.

This PR adds a test which shows that when we are suppose to block due to a rule looking at query args (e.g. XSS detection) we fail to do block. On the other hand, we expect to fail there but this specific XSS rule is supposed to work in phase 2 (cc @fzipi):
#
# -=[ XSS Filters - Category 1 ]=-
# http://xssplayground.net23.net/xssfilter.html
# script tag based XSS vectors, e.g., <script> alert(1)</script>
#
SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|REQUEST_FILENAME|REQUEST_HEADERS:User-Agent|REQUEST_HEADERS:Referer|ARGS_NAMES|ARGS|XML:/* "@rx (?i)<script[^>]*>[\s\S]*?" \
    "id:941110,\
    phase:2,\
    block,\
    capture,\
    t:none,t:utf8toUnicode,t:urlDecodeUni,t:htmlEntityDecode,t:jsDecode,t:cssDecode,t:removeNulls,\
    msg:'XSS Filter - Category 1: Script Tag Vector',\
    logdata:'Matched Data: %{TX.0} found within %{MATCHED_VAR_NAME}: %{MATCHED_VAR}',\
    tag:'application-multi',\
    tag:'language-multi',\
    tag:'platform-multi',\
    tag:'attack-xss',\
    tag:'paranoia-level/1',\
    tag:'OWASP_CRS',\
    tag:'capec/1000/152/242',\
    ctl:auditLogParts=+E,\
    ver:'OWASP_CRS/4.0.0-rc1',\
    severity:'CRITICAL',\
    setvar:'tx.xss_score=+%{tx.critical_anomaly_score}',\
    setvar:'tx.inbound_anomaly_score_pl1=+%{tx.critical_anomaly_score}'"

First question would be: why this fails in phase 2 and not 1 given that URI is connected to headers rather than request body and 2. My second question would be, shall we evaluate uri before headers or after headers instead? cc @jptosso @piyushroshan @M4tteoP

About phase 2 vs phase 1, I don't know the precise reasoning behind the specific rule (apart from things like ARGS also include POST params, therefore we need to evaluate it at phase 2), but in the past, the CRS did reason about moving what was possible from phase 2 to phase 1.


[NotIssue] UserScript for Duplicate comments fix

As title says, removes duplicate comments from torrent page.
https://gist.github.com/AkatsukiNin/46dad656be7a57dd20c8aaea67ac768a
Nyaa Pantsu Fix.js

I've added a workaround in the website to hide duplicate comments from same users until @ewhal cleans them, this is better since it means everyone (including non-js users) get to have duplicate-free comment zone, and the visual artifact caused by HTML suddenly disappearing is also removed


KAW (Kawi or "Old Javanese") missing

For proper Javanese (and also Balinese) OT feature code, we may need a possibility to reference Kawi (Old Javanese), ISO language code KAW. Can this be added to the list of registered languages?
TIA, Fadhl & Rainer
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 662c6f54-f90c-52ed-dca2-0f0a0a49fee5
Version Independent ID: 6aa33924-d45e-60c3-a9fd-e317ff662993
Content: Language system tags (OpenType 1.8.4) - Typography
Content Source: typographydocs/opentype/spec/languagetags.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: alib

Added.


Feature request: State the differences with uutils-coreutils in README

Is your feature request related to a problem? Please describe.
Curious what are the development differences between this and widely available https://github.com/uutils/coreutils (besides the license)
Describe the solution you'd like
Add it to the README for others interested.
Describe alternatives you've considered
None.
Additional context
None.

I didn't even think about adding this to the README, I obviously chose the GPL over the MIT license because I believe that utilities like these should be free for all user and I'd rather if my work is used in any way it isn't commercial. I'm really doing this mostly as a learning exercise to become more comfortable with writing Rust code and I also found Linux as my real foray into learning about coding so it has a special spot in my heart, system tooling like the GNU Utils seemed like an obvious choice. I will definitely be updating the README soon and thank you for the input!


Ci build

Builds site using CI. Probably not good to enable  GitHub pages since search engines may index the site instead of docs.sarufi.io - perhaps can put built site into a folder in to a branch as a follow on pull   request.

Hi @bkmgit
Thank for your awesome contribution
Can you help me understand something?
We have deployed this using a normal EC2 instance, would this CI work? On my previous googling I realized Github only supports ECS for github actions.

You can automate deployment to EC2.  Not sure what your setup is, if a standard webserver, pulling the static site from GitHub to the EC2 instance and putting the files in the webroot is one option.  For the static site alone, Cloud front and S3 may be more efficient. Some tutorials:

https://www.alexejgossmann.com/AWS_S3_and_CloudFront/
https://exanubes.com/blog/aws-code-pipeline-with-s3-deployment-from-github-repository
You may also wish to consider access logs and where most people will access the site from so that site responsiveness is good.
Cloudfront does have an endpoint in Nairobi, but connectivity from other parts of Africa is unclear. Free tier is generous but cost will depend on site traffic.

For the deployment preview, probably GitHub pages is sufficient?  The preview can be generated when there is a pull request to the main repository. It can be deleted by a cron job after one week, or upon closing of the pull request. Cloudfront or other CDN's can also be used for this, probably want to minimize administrative load and have good security.

Hello @bkmgit
Thank you for your recommendation, We have moved the deployment from EC2 to AWS Amplify which automatically installs CI/CD pipelines