Deploy to ECS using Fargate always stuck on creating ECS Service

Hi,
I have updated the toolkit to 1.36.00 and got stuck each time I deploy my project to ECS. I'm not sure if this issue related to aws toolkit or latest change in aws on processor quota. All I remember was everything seems to be fine before those 2 updates.
Steps,
Publish->New Traget->Choose Fargate->Edit Settings to use an existing VPC. ( everything else remains as default).->Click Publish.
Log
aws log.txt
Screenshots

Computer (please complete the following information):
Windows Version: Windows 11
Visual Studio Version: VS 2022
AWS Toolkit for Visual Studio Version: 1.36.00

It looks like the CloudFormation deployment waited three hours for the Fargate service to create and enter a stable state. The key deployment failure from the log appears to be:

Recipe/AppFargateService/Service (RecipeAppFargateService71FD6243) Service arn:aws:ecs:ap-southeast-3:175195474598:service/DevelopmentRediAutomotiveBlazorServer/DevelopmentRediAutomotiveBlazorServer-service did not stabilize.

Is there a chance that your service is not starting up successfully, causing Fargate to continuously re-launch it?
https://aws.amazon.com/premiumsupport/knowledge-center/cloudformation-ecs-service-stabilize/ has a potential (temporary workaround), but it is worth finding out if there is an underlying root cause to fix.
Pinging @philasmar in case he has additional insights.

It's kinda weird that my service is actually already in a steady state but the CloudFormation unable to read that status. I can even access my application from the browser, but then the CloudFormation will rollback the deployment after timeout occured.

Hi @philasmar
I've tried to deploy to new VPC, no luck with same error tho. Any other possible workaround I can try?

Here's the log when creating the service:
{
"eventVersion": "1.08",
"userIdentity": {
"type": "AssumedRole",
"principalId": "AROASRSTWZKTFBCGLXSOM:AWSCloudFormation",
"arn": "arn:aws:sts::175195474598:assumed-role/cdk-hnb659fds-cfn-exec-role-175195474598-ap-southeast-3/AWSCloudFormation",
"accountId": "175195474598",
"accessKeyId": "ASIASRSTWZKTOBXO5LWH",
"sessionContext": {
"sessionIssuer": {
"type": "Role",
"principalId": "AROASRSTWZKTFBCGLXSOM",
"arn": "arn:aws:iam::175195474598:role/cdk-hnb659fds-cfn-exec-role-175195474598-ap-southeast-3",
"accountId": "175195474598",
"userName": "cdk-hnb659fds-cfn-exec-role-175195474598-ap-southeast-3"
},
"webIdFederationData": {},
"attributes": {
"creationDate": "2022-10-29T01:18:31Z",
"mfaAuthenticated": "false"
}
},
"invokedBy": "cloudformation.amazonaws.com"
},
"eventTime": "2022-10-29T01:20:14Z",
"eventSource": "ecs.amazonaws.com",
"eventName": "CreateService",
"awsRegion": "ap-southeast-3",
"sourceIPAddress": "cloudformation.amazonaws.com",
"userAgent": "cloudformation.amazonaws.com",
"requestParameters": {
"clientToken": "diAutomotiveBlazorServer-service",
"cluster": "DevRediAutomotiveBlazorServer",
"deploymentConfiguration": {
"maximumPercent": 200,
"minimumHealthyPercent": 50
},
"desiredCount": 1,
"enableECSManagedTags": false,
"enableExecuteCommand": false,
"healthCheckGracePeriodSeconds": 60,
"launchType": "FARGATE",
"loadBalancers": [
{
"targetGroupArn": "arn:aws:elasticloadbalancing:ap-southeast-3:175195474598:targetgroup/DevRe-Recip-1BVMPHP8YOBVZ/169c77a97c336cae",
"containerName": "AppContainerDefinition",
"containerPort": 80
}
],
"networkConfiguration": {
"awsvpcConfiguration": {
"assignPublicIp": "ENABLED",
"securityGroups": [
"sg-0532b8d03c0657717"
],
"subnets": [
"subnet-08413dc9b864b96c8",
"subnet-0886ce387be8ad3b6",
"subnet-01c38fe7a30c45cc8"
]
}
},
"placementConstraints": [],
"placementStrategy": [],
"serviceName": "DevRediAutomotiveBlazorServer-service",
"serviceRegistries": [],
"tags": [
{
"key": "aws-dotnet-deploy",
"value": "AspNetAppEcsFargate"
}
],
"createdBy": "arn:aws:iam::175195474598:role/cdk-hnb659fds-cfn-exec-role-175195474598-ap-southeast-3",
"taskDefinition": "arn:aws:ecs:ap-southeast-3:175195474598:task-definition/DevRediAutomotiveBlazorServerRecipeAppTaskDefinitionAD244FDC:38"
},
"responseElements": {
"service": {
"serviceArn": "arn:aws:ecs:ap-southeast-3:175195474598:service/DevRediAutomotiveBlazorServer/DevRediAutomotiveBlazorServer-service",
"serviceName": "DevRediAutomotiveBlazorServer-service",
"clusterArn": "arn:aws:ecs:ap-southeast-3:175195474598:cluster/DevRediAutomotiveBlazorServer",
"loadBalancers": [
{
"targetGroupArn": "arn:aws:elasticloadbalancing:ap-southeast-3:175195474598:targetgroup/DevRe-Recip-1BVMPHP8YOBVZ/169c77a97c336cae",
"containerName": "AppContainerDefinition",
"containerPort": 80
}
],
"serviceRegistries": [],
"status": "ACTIVE",
"desiredCount": 1,
"runningCount": 0,
"pendingCount": 0,
"launchType": "FARGATE",
"platformVersion": "LATEST",
"platformFamily": "Linux",
"taskDefinition": "arn:aws:ecs:ap-southeast-3:175195474598:task-definition/DevRediAutomotiveBlazorServerRecipeAppTaskDefinitionAD244FDC:38",
"deploymentConfiguration": {
"deploymentCircuitBreaker": {
"enable": false,
"rollback": false
},
"maximumPercent": 200,
"minimumHealthyPercent": 50
},
"deployments": [
{
"id": "ecs-svc/4522459054729015200",
"status": "PRIMARY",
"taskDefinition": "arn:aws:ecs:ap-southeast-3:175195474598:task-definition/DevRediAutomotiveBlazorServerRecipeAppTaskDefinitionAD244FDC:38",
"desiredCount": 1,
"pendingCount": 0,
"runningCount": 0,
"failedTasks": 0,
"createdAt": "Oct 29, 2022 1:20:14 AM",
"updatedAt": "Oct 29, 2022 1:20:14 AM",
"launchType": "FARGATE",
"platformVersion": "1.4.0",
"platformFamily": "Linux",
"networkConfiguration": {
"awsvpcConfiguration": {
"assignPublicIp": "ENABLED",
"securityGroups": [
"sg-0532b8d03c0657717"
],
"subnets": [
"subnet-0886ce387be8ad3b6",
"subnet-08413dc9b864b96c8",
"subnet-01c38fe7a30c45cc8"
]
}
},
"rolloutState": "IN_PROGRESS",
"rolloutStateReason": "ECS deployment ecs-svc/4522459054729015200 in progress.",
"failedLaunchTaskCount": 0,
"replacedTaskCount": 0
}
],
"roleArn": "arn:aws:iam::175195474598:role/aws-service-role/ecs.amazonaws.com/AWSServiceRoleForECS",
"version": 0,
"events": [],
"createdAt": "Oct 29, 2022 1:20:14 AM",
"placementConstraints": [],
"placementStrategy": [],
"networkConfiguration": {
"awsvpcConfiguration": {
"assignPublicIp": "ENABLED",
"securityGroups": [
"sg-0532b8d03c0657717"
],
"subnets": [
"subnet-0886ce387be8ad3b6",
"subnet-08413dc9b864b96c8",
"subnet-01c38fe7a30c45cc8"
]
}
},
"healthCheckGracePeriodSeconds": 60,
"schedulingStrategy": "REPLICA",
"deploymentController": {
"type": "ECS"
},
"tags": [
{
"key": "aws-dotnet-deploy",
"value": "AspNetAppEcsFargate"
}
],
"createdBy": "arn:aws:iam::175195474598:role/cdk-hnb659fds-cfn-exec-role-175195474598-ap-southeast-3",
"enableECSManagedTags": false,
"propagateTags": "NONE",
"enableExecuteCommand": false
}
},
"requestID": "e3970bee-d5fe-4314-9314-b16fddff6ba7",
"eventID": "081f1836-4fee-4413-ab51-fc02fb63ff9f",
"readOnly": false,
"eventType": "AwsApiCall",
"managementEvent": true,
"recipientAccountId": "175195474598",
"eventCategory": "Management"
}

Hi @awschristou and @philasmar
I can confirm this behavior only for Jakarta region as I have tested deploying my project to Singapore region and everything works well as expected.

@achmadmulyadi thank you for the insight. @philasmar , is there a chance that the deploy tool is using an older version of one or more AWS SDK packages, for example, a version that predates when Fargate was added to Jakarta?

There are multiple AWS SDK references that could use an update. I will put out a PR soon to go over the package references and update them.

@achmadmulyadi I have updated the AWS SDK references to the latest versions. Could you please try the latest version of the CLI https://github.com/aws/aws-dotnet-deploy/releases/tag/1.7.3 and check if the issue is still there?

@philasmar I have updated my CLI to 1.7.3 as you can see from the screenshot, but the issue still there, either with default VPC or new VPC.

Are you able to share the logs of the ECS Container? That will help us figure out what's going on

My container doesn't have any instance, is there any way I can get the logs from it? My CloudTrail is active but I'm not sure if it has detailed info you need.

I'd like to set up a virtual debugging session to better understand your issue. Is that something you'd be open to?

Sure, I'd love to. Just let me know how we are going to do that, I can adjust the timing according to your location. I'm at GMT +7 btw.

I have sent you an email with more instructions on how to schedule a session.

Sorry for the late reply @philasmar but now seems everything works well as expected without me doing anything. I suppose there are some updates in Jakarta region internally. I think we can close issue as I already tried it several times without any issue.


Add test to force routes that use handler_method to explicitly declare which verbs they service

@insgadget can you take a look at this?

Nice! LGTM.


Prepopulation of custom fields

Issue type: Feature request
**Python version: 3.5.2
**NetBox version: 2.1.2
I would like to be able to pre-populate fieds.
In example, for each sites, I have Custom fields that should contain URLs that we use to document those. We use the "Facility" field to put in the location code (A####)
this is similar to https://github.com/digitalocean/netbox/issues/969 and https://github.com/digitalocean/netbox/issues/600
So for each URL custom property, I would like to set a default value of the base URL + the content of facility field for this site:
*  http://internal.site.com/locations/{facility}
*  http://internal.site.com/{facility}/folder
*  http://internal.site.com/default.aspx?ABBR=?{facility}
The admin should have the luxury to override the default value if needed.
It would be useful to be able to refer not only to the out of the box field, but also to other Custom Fields. An example would be Lat Long coordinates being reused for a link towards a map provider site.

Custom fields already allow you to set a default value. What are you proposing that is not covered by #600 or #969?

Indeed, I can have a default value, but it is my understanding that I cannot use variables that refer to other fields of the given site, right?
I currently have default values that I edit manually every time I create a site, and type in the location code. For each site I create into NetBox,  I have about 5 or 6 URLS in custom properties to maintain, that could be automated by those variables.
The goal of my use case is when creating a site, when I enter a location code in the facility field and click save, the URLs are updated to include the location code I provided in the facility field.
Something like http://internal.site.com/locations/{facility} would then show  http://internal.site.com/locations/A1234 when not in edit mode (A1234 being the content of the Facility field.
#600 or #969 were really axed towards the devices information. I created this FR to ensure it's captured that it would be also available for site information. I also haven't seen anybody that were requiring to reference a custom field into another custom field.  It would be useful when storing LAT/LONG coordinates in custom fields, to be able to recreate an URL from those...

The goal of my use case is when creating a site, when I enter a location code in the facility field and click save, the URLs are updated to include the location code I provided in the facility field.

There's no reason to duplicate the value of the facility field in the database. The {facility} placeholder would be rendered upon request and replaced with the value of the site's facility field. This is what #600/#969 aim to implement. I'm going to close this out as I'm confident your use case will be addressed by the implementation of one or both of those FRs.


ci: Print rustc version in the MSRV job

Codecov Report

Merging #24 (7355671) into main (1b94bff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   87.29%   87.29%
=======================================
  Files           7        7
  Lines         480      480
=======================================
  Hits          419      419
  Misses         61       61


Feature/sdk content updates

Description
Content update:
Hero teaser added using one adventure detail model
How Has This Been Tested?
Locally
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Contains PR https://github.com/adobe/aem-guides-wknd-graphql/pull/13, should be reviewed / merged after PR 13 is merged

ONHOLD: Depends on #22


Add more options for :ssh

addresses https://github.com/lumoslabs/broadside/issues/11

p.s. specs are failing?

(just get that hound comment)

👍


chore(driver): allow modern probe to compute API/SCHEMA versions

Signed-off-by: Andrea Terzolo<EMAIL_ADDRESS>What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR allows the modern probe to compute the API/SCHEMA version even when the driver folder is not included in the building phase.  This PR allows us to build Falco with the modern probe :)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Right now Falco needs to be bumped to work with libs, I will do it ASAP :)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Rename ViewControllers to match the framework

For example:

InitialPageViewController -> SwiftImageCarouselViewController
ScrollablePageItemController -> SwiftImageCarouselModalViewController

Done in onTap branch


feat: Remove social account for ticketCredential [DEV-1921]

Task linked: DEV-1921 Remove credential guard for IIW credential


Native module cannot be null.

Hi, I can not run my app on ios simulator using react-native-firestack. Here are the steps I followed.

Created a project with create-react-native-app
Installed react-native-firestack with npm i react-native-firestack
ejected the project by running npm run eject
linked to react-native-firestack by running react-native link react-native-firestack
cd appname && pod update

After completing all the steps I run my project with react-native run-ios
It started and I got the my initial page. After this step I have imported the module using 'import firestack from 'react-native-firestack'
Now If I run the project I am getting error Native module cannot be null
Dependencies from package.json:
firebase: "^4,6.1"
react: "16.0.0"
react-native: "^0.49.5"
react-native-firestack:"^2.3.9"
Simulator
iphone 7 - iOS 10.0 (14A345)
My Podfiel file

My simulator screen

Am I missing anything. I followed the documentation exactly.

This lib is way out of date, see https://github.com/invertase/react-native-firebase


Add default_expr support for ColumnDef

PR Info
Fixes
#1398  and #826
File Changed

sea-orm-macros/src/derives/entity_model.rs parse attribute and generate function call.
src/entity/column.rs updated ColumnDef to store SimpleExpr instead of Value and updated  default_value function.

Tests
Have removed PartialEq from ColumnDef because SimpleExpr does not implement  PartialEq, thats why test using assert_eq on ColumnDef are failing.
To make a temporarily fix we can implementing eq method for ColumnDef for test only and for supported features only.

I had certain questions:

Should I add a test for default_expr and may be default_value?
Should I comment test for now.

Thanks I will do that, additionally if you are going to impl PartialEq I had done some research for that it will be helpfull.
**
I went through all the fields in SimpleExpr and the problem is caused by pub type DynIden = SeaRc<dyn Iden>;   in sea-query/src/types.rs. This Iden is created by macro_rules! iden_trait https://github.com/SeaQL/sea-query/blob/94a1ab7290075e8a8bbb7a10e5207350def3455c/src/types.rs#L18.
If we can make it implement PartialEq it will solve the problem.
But SeaRc<dyn Iden> is actually Rc from standard library which does not implement PartialEq and we cannot implement that in other crate than rust itself. I am stuck here.
**

I think it's possible to implement PartialEq for sea_query::SimpleExpr but it's not trivial. I can try though.

We discussed a while before. The gist is DynIden is a foreign type we can't simply impl PartialEq for.
But I imagine it could be implemented as follows:
(*self).get_type_id() == (*other).get_type_id() && self.to_string() == other.to_string()

Checking type id is necessary, because two types with the same name is not deemed to be equal.

Hey @Diwakar-Gupta @tyt2y3, I just did a POC, https://github.com/SeaQL/sea-query/pull/620.

Hello! Why do we need PartialEq for ColumnDef? Does something using this?

Hey @Diwakar-Gupta, I just upgraded SeaQuery dependency to https://github.com/SeaQL/sea-query/pull/620

Hey @Diwakar-Gupta, don't worry about the error at https://github.com/SeaQL/sea-orm/actions/runs/4500149841/jobs/7918900727?pr=1474. The root cause is that SeaORM and SeaSchema depend on two different version of SeaQuery. We can fix it after SeaQL/sea-query#620 has been merged.

I see that this PR was merged, is there still integration / release / deps work remaining? Am just curious what to keep an eye on regarding blockers / next-steps. :D


Make lber compatible with 32-bit architectures

Fixes #99
In case of a >32bit length given on a 32-bit architecture, issue a parsing error "Too big"

Tested with cargo build --target=armv7-unknown-linux-gnueabihf

Thanks for the PR! I concur, a BER element larger than the addressable space is pointless. I'll merge the changes shortly.


Gen2 code refactor + improvements

This PR improves the code structure making it more flexible, also reorganizes where certain logic is kept in the code.
Contains also various runtime fixes to make the script more usable and stable

Just one note: We could likely automatically detect the number of cameras connected.

And is there a reason that the NN FPS is only 27FPS?  How many SHAVES/NCE are being used here?  This seems a bit low.

Also we should add the disparity confidence slider that was in Gen1.  That is quite nice to have.

Oh but yes, the comments above definitely can go into a future PR/etc. @VanDavv .  I think it was the right call to have merged this.

@Luxonis-Brandon I merged this because it runs more stable and flexible than the version on the gen2 branch (to which this branch was merged).
@themarpe added the capability to detect connected cameras here - https://github.com/luxonis/depthai-python/tree/device_improvements - so will give it a try now
(posting here for clarity)

Sounds great thanks!  And agreed.  :-)


Is there a way to have a bullet for each level of indentation in nested lists?

Right now, it correctly indents doe nested ul lists, but it only adds one bullet instead of one for each level. For example:

item 1

item 2

sublist item 1

produces:

item 1
item 2

sublist item 1

When it should (or I would like it to) produce:

item 1
item 2

sublist item 1

I have even tried running str.replace("   ", "* ") but the string replace cannot pickup those gaps even if I copy and paste them from the console log. I would be content with either a way to to it inside the turndown options, or even getting the replace to work. Any thoughts?

What does doe nested mean? The above example is not valid HTML.
 must be inside an
 block, not directly inside another
 block.

But the indented content after rich text editing is like this.<PHONE_NUMBER>3 .The ideal rule is to increment the count by 2 when encountering a ul, and when encountering an li, to retrieve the content, where the number of spaces in the front end equals the count, followed by a line break.


separate dependencies of sdkexamples and grid simulator

sdkexamples should be a package of bunch of notebooks that needs to be execute separately from gridsimulator, also in case there's an error in simulator it doesn't break the sdk example

idea is:
j.servers.notebook can set notebooks path and have startcmd for each.

1a6518a32710a398e5a0bafb1402c748a23195bb
and in libs_extra: threefoldtech/jumpscaleX_libs_extra@a2309c3a31a3b2fbbb44b6d25ab12d33bcef6f04


Matcher.eachLike(_:min) not generating examples in Pact file

New Issue Checklist

[x] Updated pact-consumer-swift to latest version
[x] Searched for existing GitHub issues

Issue description
When writing Pact tests with Matcher.eachLike(_ value: Any, min: Int) and using 0 for min,
the generated Pact file does not include the provided example value.
Given Pact test:
myProvider!
.given("some values")
.uponReceiving("a request to get a list of values")
.withRequest(method: .GET, path: "/some/endpoint")
.willRespondWith(status: 200,
                 body: ["someArray": Matcher.eachLike(["date": Matcher.term(matcher: "\\d{4}-\\d{2}-\\d{2}", generate: "2018-04-12"),
                                                       "description": Matcher.somethingLike("Some description")], min: 0))

In Pact file:
{
      "description": "a request to get a list of values",
      "providerState": "some values",
      "request": {
        "method": "get",
        "path": "/some/endpoint"
      },
      "response": {
        "status": 200,
        "headers": {
        },
        "body": {
          "someArray": [
            {

            }
          ]
        },
        "matchingRules": {
          "$.body.someArray": {
            "min": 0
          },
          "$.body.someArray[*].*": {
            "match": "type"
          },
          "$.body.transactions[*].description": {
            "match": "type"
          },
          "$.body.transactions[*].date": {
            "match": "regex",
            "regex": "\\d{4}-\\d{2}-\\d{2}"
          }
        }
      }
    }

Expected behaviour
Pact file should include the provided example description and date:
...
        "body": {
          "someArray": [
            {
              "description": "Some description",
              "date": "2018-04-04",
            }
          ]
        }
...

Improvement
eachLike(_ value: Any, min: Int = default, examples: Int = default) -> [String : Any]

Providing 2 for examples value would generate 2 entries in the Pact file.
...
        "body": {
          "someArray": [
            {
              "description": "Some description",
              "date": "2018-04-04",
            },
            {
              "description": "lasjkdhfclakushdcfmahsdlfchm",
              "date": "8731-49-62",
            }
          ]
        },
...

You should not be able to specify 0 as a min. It should be at least 1. From the pact docs

Why is there no support for specifying optional attributes?

Firstly, it is assumed that you have control over the provider's data (and consumer's data) when doing the verification tests. If you don't, then maybe Pact is not the best tool for your situation.

Secondly, if Pact supports making an assertion that element $.body.name may be present in a response, then you write consumer code that can handle an optional $.body.name, but in fact, the provider gives $.body.firstname, no test will ever fail to tell you that you've made an incorrect assumption. Remember that a provider may return extra data without failing the contract, but it must provide at minimum the data you expect.

The same goes for specifying "SOME_VALUE or null". If all your provider verification test data returned nulls for this key, you might think that you had validated the "SOME_VALUE", but in fact, you never had. You could get a completely different "SOME_VALUE" for this key in production, which may then cause issues.

The same goes for specifying an array with length 0 or more. If all your provider verification data returned 0 length arrays, all your verification tests would pass without you ever having validated the contents of the array. This is why you can only specify an array with minimum length 1 OR a zero length array.

Remember that unlike a schema, which describes all possible states of a document, Pact is "contract by examples". If you need to assert that multiple states are possible, then you need to provide an example for each of those states. Consider if it's really important to you before you do add a Pact test for each and every state however. Remember that each interaction comes with a "cost" of maintenance and execution time, and you need to consider if it is worth the cost in your particular situation.

https://docs.pact.io/faq#why-is-there-no-support-for-specifying-optional-attributes


Phaser Game Framework

So I begun using this recently (without using Transcrypt) and it's mind blowing what games you can create in just a few lines of code. Extremely beginner friendly. I think Transcrypt would benefit immensely if there was a tutorial about writing Phaser games with it. Just wanted to bring this to the attention of Jacques and whoever may be interested.

Games are popular and examples of Phaser games are of course welcome as contributions in the gallery.
With regard to Transcrypt I have to limit myself to the core (apart from the Pong example :) ).

@notzoom, I did a direct conversion of the Phaser 3 intro tutorial. Left the 'this' keywords in, i guess not all would be pleased with that, but at least it demonstrates that it's not a very big jump to get started.

@fzzylogic That is totally fantastic !!! Well done !!!!

@notzoom, Thanks. It would be more interesting if it took advantage of python specific language features. So be sure to share your creations!

Closing since no further comments for a while now.


ip regex range limit

that should mitigate some of the edge conditions we saw in #57 and CFE-125

Good stuff!
/lgtm


[HOLD for payment 2024-08-26] Workspace switcher - Huge gap between "Create a workspace" modal and "Workspaces" title

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.21-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Precondition:

Account has no workspace.

Go to staging.new.expensify.com
Open workspace switcher.

Expected Result:
"Create a workspace" modal should be right below the "Workspaces" title (production behavior).
Actual Result:
There is huge gap between "Create a workspace" modal and "Workspaces" title.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @wildan-m

We think that this bug might be related to #vip-vsb

It might be caused by https://github.com/Expensify/App/pull/47527

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The logic in this render might be incorrect:
https://github.com/Expensify/App/blob/62722e8bc636f1be2e2c9e8e980aac93b76804c9/src/components/SelectionList/BaseSelectionList.tsx#L690-L695
headerMessage value should be mandatory to show the component
What changes do you think we should make in order to solve the problem?
Change the logic to
{(
    ((!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) ||
    (flattenedSections.allOptions.length === 0 && !showLoadingPlaceholder)) &&
    !!headerMessage
) && (
    <View style={headerMessageStyle ?? [styles.ph5, styles.pb5]}>
        <Text style={[styles.textLabel, styles.colorMuted, styles.minHeight5]}>
            {headerMessage}
        </Text>
    </View>
)}

What alternative solutions did you explore? (Optional)
N/A

@wildan-m are you available to work on a fix?

@luacmartins sure

@luacmartins the PR is ready.

I think we don't need to create regression test, it's not directly related to any flow

@luacmartins @abekkala bump for payment

@luacmartins bump https://github.com/Expensify/App/issues/47601#issuecomment-2311805942

Seems like I closed this issue without payment 😬 Reopening so we can process it @abekkala

PAYMENT SUMMARY

Fix @wildan-m [$250] OFFER
PR Review: internal @luacmartins

@abekkala thanks, accepted the offer

@wildan-m payment sent and contract ended - thank you! 🎉


Does it work with moment 2.12.0 ?

Adding jalali-moment caused crashing browser when clicking on datetimepicker (https://eonasdan.github.io/bootstrap-datetimepicker)

Tested with moment 2.12.0 and all tests passed. There might be some other issue. Can you investigate more?


Fix unable to load JavaScript module with "." in the name

lgtm

will this affect the jsx stuff?    if there's a module named foo.bar that has foo.bar.jsx?

That should be fixed as well.


Change note scheduling style

To allow tempo to be altered at runtime between notes. Specifically, this uses a sliding window - every 60ms the scheduler schedules all unscheduled notes for the next 100ms at the current tempo - those parameters are tweakable, but IMO they give a good balance of scheduling ahead and accounting for latency in setInterval callbacks.
One thing I have yet to decide the goodness of is line 105 - when I choose to kick in tempo changes. It waits for the last scheduled note to finish (as per its old tempo), and schedules notes at the new tempo after that. This makes sense until you start playing sequences in parallel - this method can cause parallel sequences to desync from one another as they can adopt the new tempo at different times (since their active/last scheduled notes can be of different lengths). This can be avoided if you know it's there by delaying your setTempo call until you know notes of the same duration have been scheduled between all of your parallel sequences... but it's awkward. I'm wondering if there's a decision to be made here which can make that easier.

Aww, man. I wish you'd filed an issue first.
I think this is a bit beyond the scope of what I want to support in TinyMusic. Scheduling is really tricky, exactly for the reasons you mentioned. To do it really well,  you'd probably need a class like Song or something that can hold multiple Sequence instances and make sure all the timing stuff is completely deterministic.
I think the majority of people using TinyMusic are looking for a really simple, bar-bones solution with a small footprint – so this feels like added weight that probably won't get used super often.
That said, if your project calls for tempo changes, I think you could probably just extend Sequence.prototype and do whatever you need. I've added reverb in one of my projects the same way. You're also totally welcome to fork, of course. Maybe there's sufficient demand for a more feature-rich version of this thing.

:+1:


schedule PR template

follow-up to #3256

Is this still relevant @casperdcl cc @julieg18 ? Thanks

Is this still relevant @casperdcl cc @julieg18 ? Thanks

I think we are good to close this! We don't have a way to schedule PRs currently, and if we are going to look into a different way to accomplish this, it's a low priority task and won't be completed for a bit :)


enable codecov in GH check

Change-Id: I2ee14831a7562c5735f20ccedd13fb2e887cbcdc

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

Not bad. We could aim for 100% though :-)
https://app.codecov.io/github/garymm/gpu-deflate/commit/350b5ac8b0f817e741a4807f306f5e21439b5b31/tree


Issues building _framework_bindings.so for android arm64

OS Platform and Distribution
Linux Mint 5.15.0-56-generic
Compiler version
No response
Programming Language and version
C++
Installed using virtualenv? pip? Conda?(if python)
No response
MediaPipe version
<IP_ADDRESS>
Bazel version
5.2.0
XCode and Tulsi versions (if iOS)
No response
Android SDK and NDK versions (if android)
ndk 21, sdk, unsure
Android AAR (if android)
None
OpenCV version (if running on desktop)
No response
Describe the problem
When trying to build the `_framework_bindings.so` using `bazel build -c opt --config=android_arm64 mediapipe/python:_framework_bindings.so`, however it errors out, specifically in the `mediapipe/python/pybind:packet` part.
It shows

ERROR: /home/brandon/mediapipe/mediapipe/python/pybind/BUILD:96:15: Compiling mediapipe/python/pybind/packet.cc failed: (Exit 1): clang failed: error executing command external/androidndk/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -gcc-toolchain external/androidndk/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64 -target ... (remaining 82 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from mediapipe/python/pybind/packet.cc:15:
In file included from ./mediapipe/python/pybind/packet.h:18:
In file included from external/pybind11/include/pybind11/pybind11.h:13:
In file included from external/pybind11/include/pybind11/detail/class.h:12:
In file included from external/pybind11/include/pybind11/detail/../attr.h:13:
In file included from external/pybind11/include/pybind11/detail/common.h:208:
In file included from bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include/Python.h:8:
bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include/pyconfig.h:9:12: fatal error: 'aarch64-linux-gnu/python3.10/pyconfig.h' file not found
#  include <aarch64-linux-gnu/python3.10/pyconfig.h>
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Target //mediapipe/python/pybind:packet failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1.623s, Critical Path: 1.36s
INFO: 3 processes: 3 internal.
FAILED: Build did NOT complete successfully

I already have the pyconfig.h and all other python headers in the /usr/lib/aarch64-linux-gnu/python3.10/.

### Complete Logs

```shell
INFO: Analyzed target //mediapipe/python/pybind:packet (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
ERROR: /home/brandon/mediapipe/mediapipe/python/pybind/BUILD:96:15: Compiling mediapipe/python/pybind/packet.cc failed: (Exit 1): clang failed: error executing command
  (cd /home/brandon/.cache/bazel/_bazel_brandon/97261b983e2c54d2e8d662dd735e7089/sandbox/linux-sandbox/3101/execroot/mediapipe && \
  exec env - \
    PATH=/home/brandon/.cache/bazelisk/downloads/bazelbuild/bazel-5.2.0-linux-x86_64/bin:/home/brandon/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    PWD=/proc/self/cwd \
  external/androidndk/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -gcc-toolchain external/androidndk/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64 -target aarch64-none-linux-android -fpic -isystemexternal/androidndk/ndk/sysroot/usr/include/aarch64-linux-android '-D__ANDROID_API__=21' -no-canonical-prefixes -Wno-invalid-command-line-argument -Wno-unused-command-line-argument -funwind-tables -fstack-protector-strong -fno-addrsig '-Werror=return-type' '-Werror=int-to-pointer-cast' '-Werror=pointer-to-int-cast' '-Werror=implicit-function-declaration' -O2 -g -DNDEBUG -MD -MF bazel-out/arm64-v8a-opt/bin/mediapipe/python/pybind/_objs/packet/packet.d '-frandom-seed=bazel-out/arm64-v8a-opt/bin/mediapipe/python/pybind/_objs/packet/packet.o' -iquote . -iquote bazel-out/arm64-v8a-opt/bin -iquote external/com_google_protobuf -iquote bazel-out/arm64-v8a-opt/bin/external/com_google_protobuf -iquote external/zlib -iquote bazel-out/arm64-v8a-opt/bin/external/zlib -iquote external/com_google_absl -iquote bazel-out/arm64-v8a-opt/bin/external/com_google_absl -iquote external/com_github_glog_glog_no_gflags -iquote bazel-out/arm64-v8a-opt/bin/external/com_github_glog_glog_no_gflags -iquote external/pybind11 -iquote bazel-out/arm64-v8a-opt/bin/external/pybind11 -iquote external/local_config_python -iquote bazel-out/arm64-v8a-opt/bin/external/local_config_python -Ibazel-out/arm64-v8a-opt/bin/external/com_github_glog_glog_no_gflags/_virtual_includes/default_glog_headers -isystem external/com_google_protobuf/src -isystem bazel-out/arm64-v8a-opt/bin/external/com_google_protobuf/src -isystem external/zlib -isystem bazel-out/arm64-v8a-opt/bin/external/zlib -isystem external/pybind11/include -isystem bazel-out/arm64-v8a-opt/bin/external/pybind11/include -isystem external/local_config_python/python_include -isystem bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include -w '-std=c++17' -fexceptions '--sysroot=external/androidndk/ndk/platforms/android-21/arch-arm64' -isystem external/androidndk/ndk/sources/cxx-stl/llvm-libc++/include -isystem external/androidndk/ndk/sources/cxx-stl/llvm-libc++abi/include -isystem external/androidndk/ndk/sources/android/support/include -isystemexternal/androidndk/ndk/sysroot/usr/include -c mediapipe/python/pybind/packet.cc -o bazel-out/arm64-v8a-opt/bin/mediapipe/python/pybind/_objs/packet/packet.o)
# Configuration: bc113378d8420dfd857078289773f4fbb5cd04e45284558a4ecd0964ef08a12d
# Execution platform: @local_execution_config_platform//:platform

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from mediapipe/python/pybind/packet.cc:15:
In file included from ./mediapipe/python/pybind/packet.h:18:
In file included from external/pybind11/include/pybind11/pybind11.h:13:
In file included from external/pybind11/include/pybind11/detail/class.h:12:
In file included from external/pybind11/include/pybind11/detail/../attr.h:13:
In file included from external/pybind11/include/pybind11/detail/common.h:208:
In file included from bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include/Python.h:8:
bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include/pyconfig.h:9:12: fatal error: 'aarch64-linux-gnu/python3.10/pyconfig.h' file not found
#  include <aarch64-linux-gnu/python3.10/pyconfig.h>
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
ERROR: /home/brandon/mediapipe/mediapipe/python/pybind/BUILD:96:15: Compiling mediapipe/python/pybind/packet.cc failed: (Exit 1): clang failed: error executing command
  (cd /home/brandon/.cache/bazel/_bazel_brandon/97261b983e2c54d2e8d662dd735e7089/sandbox/linux-sandbox/3100/execroot/mediapipe && \
  exec env - \
    PATH=/home/brandon/.cache/bazelisk/downloads/bazelbuild/bazel-5.2.0-linux-x86_64/bin:/home/brandon/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    PWD=/proc/self/cwd \
  external/androidndk/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -gcc-toolchain external/androidndk/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64 -target aarch64-none-linux-android -fpic -isystemexternal/androidndk/ndk/sysroot/usr/include/aarch64-linux-android '-D__ANDROID_API__=21' -no-canonical-prefixes -Wno-invalid-command-line-argument -Wno-unused-command-line-argument -funwind-tables -fstack-protector-strong -fno-addrsig '-Werror=return-type' '-Werror=int-to-pointer-cast' '-Werror=pointer-to-int-cast' '-Werror=implicit-function-declaration' -O2 -g -DNDEBUG -MD -MF bazel-out/arm64-v8a-opt/bin/mediapipe/python/pybind/_objs/packet/packet.pic.d '-frandom-seed=bazel-out/arm64-v8a-opt/bin/mediapipe/python/pybind/_objs/packet/packet.pic.o' -fPIC -iquote . -iquote bazel-out/arm64-v8a-opt/bin -iquote external/com_google_protobuf -iquote bazel-out/arm64-v8a-opt/bin/external/com_google_protobuf -iquote external/zlib -iquote bazel-out/arm64-v8a-opt/bin/external/zlib -iquote external/com_google_absl -iquote bazel-out/arm64-v8a-opt/bin/external/com_google_absl -iquote external/com_github_glog_glog_no_gflags -iquote bazel-out/arm64-v8a-opt/bin/external/com_github_glog_glog_no_gflags -iquote external/pybind11 -iquote bazel-out/arm64-v8a-opt/bin/external/pybind11 -iquote external/local_config_python -iquote bazel-out/arm64-v8a-opt/bin/external/local_config_python -Ibazel-out/arm64-v8a-opt/bin/external/com_github_glog_glog_no_gflags/_virtual_includes/default_glog_headers -isystem external/com_google_protobuf/src -isystem bazel-out/arm64-v8a-opt/bin/external/com_google_protobuf/src -isystem external/zlib -isystem bazel-out/arm64-v8a-opt/bin/external/zlib -isystem external/pybind11/include -isystem bazel-out/arm64-v8a-opt/bin/external/pybind11/include -isystem external/local_config_python/python_include -isystem bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include -w '-std=c++17' -fexceptions '--sysroot=external/androidndk/ndk/platforms/android-21/arch-arm64' -isystem external/androidndk/ndk/sources/cxx-stl/llvm-libc++/include -isystem external/androidndk/ndk/sources/cxx-stl/llvm-libc++abi/include -isystem external/androidndk/ndk/sources/android/support/include -isystemexternal/androidndk/ndk/sysroot/usr/include -c mediapipe/python/pybind/packet.cc -o bazel-out/arm64-v8a-opt/bin/mediapipe/python/pybind/_objs/packet/packet.pic.o)
# Configuration: bc113378d8420dfd857078289773f4fbb5cd04e45284558a4ecd0964ef08a12d
# Execution platform: @local_execution_config_platform//:platform

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from mediapipe/python/pybind/packet.cc:15:
In file included from ./mediapipe/python/pybind/packet.h:18:
In file included from external/pybind11/include/pybind11/pybind11.h:13:
In file included from external/pybind11/include/pybind11/detail/class.h:12:
In file included from external/pybind11/include/pybind11/detail/../attr.h:13:
In file included from external/pybind11/include/pybind11/detail/common.h:208:
In file included from bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include/Python.h:8:
bazel-out/arm64-v8a-opt/bin/external/local_config_python/python_include/pyconfig.h:9:12: fatal error: 'aarch64-linux-gnu/python3.10/pyconfig.h' file not found
#  include <aarch64-linux-gnu/python3.10/pyconfig.h>
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Target //mediapipe/python/pybind:packet failed to build
INFO: Elapsed time: 1.429s, Critical Path: 1.19s
INFO: 3 processes: 3 internal.
FAILED: Build did NOT complete successfully

Hi @tomorroisnew,
Seems from the error logs, Linux distribution is by default taking the older version of python, not the python3.
Could you install the below command:
sudo apt-get install python3.10-dev
Please revert back if still an issue from other end.

@tomorroisnew,
Please allow us some time to share the possible solution on the query raised.

Hello @tomorroisnew,
Could you check or specify the python bin path --action_env PYTHON_BIN_PATH="/foo/bar" as below:
bazel build -c opt --action_env PYTHON_BIN_PATH="/foo/bar" --config=android_arm64
mediapipe/python:_framework_bindings.so

Please let us know if resolves the issue. Thank you

should i point it to the cross compiled aarch64 python?

I tried it with my arm64 python3 binary, still doesnt work. Btw, cant i just include the path /usr/include/ for bazel, since i have the asked header file in there

Hello @jiuqiant,
Could you please help here. Thank you!


D3 Zoom on Selections?

Maybe not an issue but I have a question of whether this is meaningful or not. Consider the example below
<!DOCTYPE html>
<meta charset="utf-8">
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/d3/4.2.6/d3.min.js"></script>
<body>
</body>
<script>
var zoom
var svg
var initial_transform

zoom = d3.zoom()
initial_transform = d3.zoomIdentity.translate(50,50)

svg = d3.select("body").append("svg")
 svg.call(zoom.transform, initial_transform)

console.log(d3.zoomTransform(svg))
console.log(d3.zoomTransform(svg.node()))
</script>
</html>

ea {k: 1, x: 0, y: 0}
ea {k: 1, x: 50, y: 50}

The first line is the d3.zoomTransform object on the selection, the second is the zoom transform on the element.
My twofold question is
Is passing a selection to zoomTransform meaningful? I especially ask because all the documentation shows node as an argument.
If not would it be better for d3 to raise an error if I try passing a selection to d3.zoomTransform instead of a node? I spent a couple of hours scratching my head trying to figure out why the initial_transform was not working and it took a while for me to realize I needed to pass the svg node, not the svg selection.
also thanks for the great library!

As documented, d3.zoomTransform takes a node, not a selection. This is because a selection may consist of multiple nodes, and d3.zoomTransform only returns a single transform. I’ve added some clarifying text to the README to make this more obvious.
Regarding the implementation: perhaps it could be changed to use the first node from the selection if passed a selection, similar to selection getter methods, but I’d rather avoid overloading the method signature and have usage be consistent. Often this method is used from within an event handler, where you want to pass in this, being the active element.
Or it could be changed to throw an error if node is a selection, but that seems tailored to the exact error here. Wouldn’t it be better if it throw an error if the given node is not a node? Yet there isn’t a strict definition of what a “node” is in the context of selections, though node instanceof Element would likely be reasonable here. There are some cases where it’s valid to create a selection of non-element objects; see tomwanzek/d3-v4-definitelytyped#2. D3 selections use duck typing: if a node is an object that defines the needed methods, then it’s fine to create a selection from it.
More generally, D3 does not try very hard to protect against incorrect usage. This is partly a language consequence: JavaScript is a weakly-typed language. Some operations enforce types, while others do not. For example, consider the following abuse of function.apply, which takes an array of arguments as the second argument:
function log(message) {
  console.log(message);
}

log.apply(null, "hello"); // TypeError: CreateListFromArrayLike called on non-object(…)

Yet JavaScript is perfectly happy to take other questionably-array inputs:
log.apply(null, {0: "hello"}); // logs "undefined"
log.apply(null, {0: "hello", length: 1}); // logs "hello"

As another example, d3.dispatch throws an error if you try to register a callback listener that is not a function. This is so because callbacks are typically invoked asynchronously, and so it’s much easier to debug if there error is thrown when the callback is registered rather than when it is invoked. But if you pass the wrong sort of thing to d3.zoomTransform, the result is synchronous: the returned transform will always be the default identity transform. If you use a debugger, you can step through the code and see why (node.__zoom is undefined).
So, I’m not convinced it’s worthwhile to add an assertion here, though if people continue to run into this confusion, then I’ll consider it again in the future.
Another option for stronger protection is a language enhancement such as TypeScript; see tomwanzek/d3-v4-definitelytyped and DefinitelyTyped/DefinitelyTyped#9936.

Thank you for the long and informative response!


transparency issue?

When I try to reproduce the transparency illustration
transparent sphere
I obtain an opaque sphere. Can someone reproduce this issue? Perhaps it is a problem in my installation..

Did setting transparency = 0.4 or transparency = true in surface help?

Yes, transparency = true  in surface solves the problem. Thanks a lot.

transparency = 0.4

Transparency is a boolean ;)

is there a way to control the degree of transparency ?, sometimes it shows too much.

You can add an alpha value to a colormap (or any color) by doing something like colormap=(:viridis, 0.4)

Yes, I know. But that doesn't affect the transparency strength, one just gets a more diffusive color.

I don't know what you're asking for then. transparency enables or disables transparency and the alpha component of a color controls how transparent something is. We don't have different transparency methods at this point.
This is (:viridis, 0.8) vs (:viridis, 0.2)


Function deprecated

Hi,
I've got a deprecated call:
Function mcrypt_get_iv_size() is deprecated.
g4/crypto 1.0.1
Symfony 3.1.7
PHP 7.1.0RC5
mcrypt 2.5.8
Os : Mac 10.12.1
Let me know if you need more infos.
This issue is not critical.
Thank you for your help

Fixed in new version - 2.0.0
https://packagist.org/packages/g4/crypto
Change in usage
https://github.com/g4code/crypto#usage


feat: limit total number of pods created by the controller. Fixes #4561

Signed-off-by: weafscast<EMAIL_ADDRESS>Fork of #9878 with added test(weren't present in original pr).
The original pr has been stale since ~6 months
Fixes #4561

@terrytangyuan the failing test is unrelated and is passing for me locally, could it be a flake?

Could you create a ResourceQuote directly?

Could you create a ResourceQuote directly?

@alexec could you clarify what do you mean?

unstale, will resume.

Hi @weafscast , do you have plans to finish this PR? Thanks for the update so we can prioritize accordingly.

Very useful PR, will you complete it? @weafscast

Closing this PR as it's been stale for awhile.

where @weafscast


Bug report: msix not merged by git ref: 207eddfe797225ab2736001cbdb8fafd04946b38

Describe the bug
msix:
# https://github.com/YehudaKremer/msix/pull/174
git:
url: https://github.com/Tienisto/msix.git
ref: 207eddfe797225ab2736001cbdb8fafd04946b38
To reproduce
flutter pub ge
Could not find a file named "pubspec.yaml" in https://github.com/Tienisto/msix.git 207eddfe797225ab2736001cbdb8fafd04946b38.
pub get failed

Expected behavior

Annotate this commit. 👇🏻
msix:
https://github.com/YehudaKremer/msix/pull/174
git:
url: https://github.com/Tienisto/msix.git
# ref: 207eddfe797225ab2736001cbdb8fafd04946b38

Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response

This is not a bug. This is just an unmerged fork.

It works on my machine. But the hash is incorrect. It should be<PHONE_NUMBER>cb2284a510ee2ddc58cf082d37595c

Updated dependency hash

This is not a bug. This is just an unmerged fork.

I know,  It only happens when running locally；
thanks for the update！I wish you a happy life


Improve documentation InputType and IteratorType

Closes #3245.

Coverage remained the same at 100.0% when pulling 10486abe35c8b5fe32975bdcdf52009fec7bb665 on issue3245_improve_documentation into 9e89c2fdb5dffb400413289cdef11b2b79bbdad8 on develop.


[BUG] When the output from the upstream node is JSON, the received value is [object Object].

Describe the bug
When a component receives the value of {{xxxxx_0.data.instance}} from the previous node, as shown in the image

if the value of {{xxxxx_0.data.instance}} is a JSON object, the component displays "[object Object]" instead of the actual content.
To Reproduce
Location in the internal code:
https://github.com/FlowiseAI/Flowise/blob/45a42c4404c82872861110606d69cb8ac3f27f14/packages/server/src/utils/index.ts#L564C28-L564C28
When variableValue is an object, the assignment fails, and the content becomes "[object Object]".
Example:
const a = '{"response":"{{mapiProxy_0.data.instance}}","qustion":"{{question}}"}'
const b = a.split('{{mapiProxy_0.data.instance}}').join({
  "json": {
    "name": "guwenjia",
    "login_id": "guwenjia"
  }
})
console.log(b)

Expected behavior
Should it be modified to

I got bitten by this bug, too -- unfortunately, I can't rely on any internal JSON parsers until this issue is fixed.

Okay, so I tested @zerogu's fix here:
https://github.com/fletch-ai/flowise/commit/df190017881e3227bde84853e914ae3ecbd23d8a
And it looks like JSON parsing is working again, but I had to enable the autofix option.

tested the same, looks good! @dkindlund what do you mean by autofix ?

Hey @HenryHengZJ , I'm talking about the Autofix slider option visible in the node's UI:


ts+yarn workspaces - relative import preferred over node_module imort

VSC: 1.55.2
For yarn, I'v also set nodeLinker: node-modules
When working with ts and yarn workspaces, example (@project is placeholder):

packages/app -> linked to node_modules/@project/app
packages/lib -> linked to node_modules/@project/lib

From inside @project/app i can manually import items from @project/lib and the typing works:
// this works manually, I can use item and it has typings (tsconfig strict, so no implicit any)
import {item} from '@project/lib'

However: I don't receive any fix proposal or auto-import for the it, instead I get proposed relative imports ../../lib/* and the @project/lib import does not show up in the list of options
The lib package has also explicit types pointing to the d.ts that provides the items.

I have yarn 2.4.1. and<EMAIL_ADDRESS>

I just had two colleagues try the repro on Ubuntu and it’s working for them as well. I’m on macOS. To avoid executing the included copy of yarn (as a routine security precaution), these are the steps we took. You could try them to ensure there’s not something weird here:

clone the repo
delete yarnPath from .yarnrc.yml
rm -r .yarn
npx yarn@berry set version berry
yarn --version - 2.4.1
yarn

After that, can you share your TS Server logs with index.ts open? https://github.com/microsoft/TypeScript/wiki/Getting-logs-from-TS-Server-in-VS-Code

Problem persists. This is basically restart ts server and trigger the quick-fix and opening the logs (nothing privicy-critical inside and its not long, so I post it here):
Info 0    [13:49:23.516] Starting TS Server
Info 1    [13:49:23.516] Version: 4.3.0-dev.20210505
Info 2    [13:49:23.516] Arguments: /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/code-insiders /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /tmp/vscode-typescript1000/42b4dd7c213a1e87164d/tscancellation-11e13de89dc464e65d75.tmp* --logVerbosity verbose --logFile /home/andre/.config/Code - Insiders/logs/20210514T134321/exthost1/vscode.typescript-language-features/tsserver-log-mjHkIX/tsserver.log --globalPlugins typescript-vscode-sh-plugin --pluginProbeLocations /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/typescript-language-features --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3    [13:49:23.516] Platform: linux NodeVersion: 14 CaseSensitive: true
Info 4    [13:49:23.516] ServerMode: undefined syntaxOnly: false hasUnknownServerMode: undefined
Info 5    [13:49:23.522] Binding...
Info 6    [13:49:23.526] request:
    {"seq":0,"type":"request","command":"configure","arguments":{"hostInfo":"vscode","preferences":{"providePrefixAndSuffixTextForRename":true,"allowRenameOfImportPath":true,"includePackageJsonAutoImports":"auto"},"watchOptions":{}}}
Info 7    [13:49:23.527] Host information vscode
Info 8    [13:49:23.527] Host watch options changed to undefined, it will be take effect for next watches.
Info 9    [13:49:23.527] response:
    {"seq":0,"type":"response","command":"configure","request_seq":0,"success":true}
Perf 10   [13:49:23.527] 0::configure: async elapsed time (in milliseconds) 0.9492
Info 11   [13:49:23.527] request:
    {"seq":1,"type":"request","command":"compilerOptionsForInferredProjects","arguments":{"options":{"module":"commonjs","target":"es2020","jsx":"preserve","strictFunctionTypes":true,"sourceMap":true,"allowJs":true,"allowSyntheticDefaultImports":true,"allowNonTsExtensions":true,"resolveJsonModule":true}}}
Perf 12   [13:49:23.528] 1::compilerOptionsForInferredProjects: elapsed time (in milliseconds) 0.2481
Info 13   [13:49:23.528] response:
    {"seq":0,"type":"response","command":"compilerOptionsForInferredProjects","request_seq":1,"success":true,"body":true}
Info 14   [13:49:23.528] request:
    {"seq":2,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"/home/andre/code-insider-test/packages/app/index.ts","fileContent":"// it works, if you uncomment the import. \n// However there are no quick-fixes/auto-imports for it\n//import {Item} from \"@code-insider-test/lib\"\n\nconst i: Item = {}","projectRootPath":"/home/andre/code-insider-test","scriptKindName":"TS"}]}}
Info 15   [13:49:23.528] Search path: /home/andre/code-insider-test/packages/app
Info 16   [13:49:23.529] For info: /home/andre/code-insider-test/packages/app/index.ts :: Config file name: /home/andre/code-insider-test/packages/app/tsconfig.json
Info 17   [13:49:23.529] Creating configuration project /home/andre/code-insider-test/packages/app/tsconfig.json
Info 18   [13:49:23.530] FileWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/packages/app/tsconfig.json 2000 undefined Project: /home/andre/code-insider-test/packages/app/tsconfig.json WatchType: Config file
Info 19   [13:49:23.531] event:
    {"seq":0,"type":"event","event":"projectLoadingStart","body":{"projectName":"/home/andre/code-insider-test/packages/app/tsconfig.json","reason":"Creating possible configured project for /home/andre/code-insider-test/packages/app/index.ts to open"}}
Info 20   [13:49:23.538] Config: /home/andre/code-insider-test/packages/app/tsconfig.json : {
 "rootNames": [
  "/home/andre/code-insider-test/packages/app/index.ts"
 ],
 "options": {
  "strict": true,
  "configFilePath": "/home/andre/code-insider-test/packages/app/tsconfig.json"
 }
}
Info 21   [13:49:23.539] Loading global plugin typescript-vscode-sh-plugin
Info 22   [13:49:23.539] Enabling plugin typescript-vscode-sh-plugin from candidate paths: /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/typescript-language-features,/home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/tsserver.js/../../..
Info 23   [13:49:23.539] Loading typescript-vscode-sh-plugin from /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/typescript-language-features (resolved to /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/typescript-language-features/node_modules)
Info 24   [13:49:23.542] typescript-vscode-sh-plugin active for version < 4.2 and JS/JSX files. Current version : 4.3.0-dev.20210505
Info 25   [13:49:23.542] Intercepting getEncodedSemanticClassifications and getEncodedSyntacticClassifications.
Info 26   [13:49:23.542] Plugin validation succeeded
Info 27   [13:49:23.544] Starting updateGraphWorker: Project: /home/andre/code-insider-test/packages/app/tsconfig.json
Info 28   [13:49:23.549] DirectoryWatcher:: Added:: WatchInfo: /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules 1 undefined WatchType: node_modules for closed script infos in them
Info 29   [13:49:23.553] Elapsed:: 4.23204299993813ms DirectoryWatcher:: Added:: WatchInfo: /home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules 1 undefined WatchType: node_modules for closed script infos in them
Info 30   [13:49:24.102] DirectoryWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/packages/app/node_modules/@types 1 undefined Project: /home/andre/code-insider-test/packages/app/tsconfig.json WatchType: Type roots
Info 31   [13:49:24.102] Elapsed:: 0.4969499986618757ms DirectoryWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/packages/app/node_modules/@types 1 undefined Project: /home/andre/code-insider-test/packages/app/tsconfig.json WatchType: Type roots
Info 32   [13:49:24.102] DirectoryWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/packages/node_modules/@types 1 undefined Project: /home/andre/code-insider-test/packages/app/tsconfig.json WatchType: Type roots
Info 33   [13:49:24.102] Elapsed:: 0.08555999957025051ms DirectoryWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/packages/node_modules/@types 1 undefined Project: /home/andre/code-insider-test/packages/app/tsconfig.json WatchType: Type roots
Info 34   [13:49:24.103] Finishing updateGraphWorker: Project: /home/andre/code-insider-test/packages/app/tsconfig.json Version: 1 structureChanged: true Elapsed:<PHONE_NUMBER>997976ms
Info 35   [13:49:24.103] Project '/home/andre/code-insider-test/packages/app/tsconfig.json' (Configured)
Info 36   [13:49:24.104] 	Files (6)
	/home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.d.ts
	/home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.es5.d.ts
	/home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.dom.d.ts
	/home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.webworker.importscripts.d.ts
	/home/andre/programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.scripthost.d.ts
	/home/andre/code-insider-test/packages/app/index.ts

	../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.d.ts
	  Default library
	../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.es5.d.ts
	  Library referenced via 'es5' from file '../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.d.ts'
	../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.dom.d.ts
	  Library referenced via 'dom' from file '../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.d.ts'
	../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.webworker.importscripts.d.ts
	  Library referenced via 'webworker.importscripts' from file '../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.d.ts'
	../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.scripthost.d.ts
	  Library referenced via 'scripthost' from file '../../../programme/code-insider-x64-1620279117/VSCode-linux-x64/resources/app/extensions/node_modules/typescript/lib/lib.d.ts'
	index.ts
	  Matched by include pattern 'index.ts' in 'tsconfig.json'

Info 37   [13:49:24.104] -----------------------------------------------
Info 38   [13:49:24.105] FileWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/packages/app/package.json 250 undefined WatchType: package.json file for import suggestions
Info 39   [13:49:24.106] FileWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/package.json 250 undefined WatchType: package.json file for import suggestions
Info 40   [13:49:24.108] FileWatcher:: Added:: WatchInfo: /home/andre/code-insider-test/packages/lib/index.d.ts 500 undefined WatchType: Closed Script info
Info 41   [13:49:24.108] Starting updateGraphWorker: Project: /dev/null/autoImportProviderProject1*
Info 42   [13:49:24.110] Finishing updateGraphWorker: Project: /dev/null/autoImportProviderProject1* Version: 1 structureChanged: true Elapsed: 1.8659719992429018ms
Info 43   [13:49:24.110] Project '/dev/null/autoImportProviderProject1*' (AutoImportProvider)
Info 44   [13:49:24.110] 	Files (1)
	/home/andre/code-insider-test/packages/lib/index.d.ts

	../lib/index.d.ts
	  Root file specified for compilation

Info 45   [13:49:24.110] -----------------------------------------------
Info 46   [13:49:24.110] event:
    {"seq":0,"type":"event","event":"projectLoadingFinish","body":{"projectName":"/home/andre/code-insider-test/packages/app/tsconfig.json"}}
Info 47   [13:49:24.111] event:
    {"seq":0,"type":"event","event":"telemetry","body":{"telemetryEventName":"projectInfo","payload":{"projectId":"5226ea00578033df3d2e2d6b009ba8d443a47aad140924eec71be125780e5d42","fileStats":{"js":0,"jsSize":0,"jsx":0,"jsxSize":0,"ts":1,"tsSize":164,"tsx":0,"tsxSize":0,"dts":5,"dtsSize":1049309,"deferred":0,"deferredSize":0},"compilerOptions":{"strict":true},"typeAcquisition":{"enable":false,"include":false,"exclude":false},"extends":false,"files":false,"include":true,"exclude":false,"compileOnSave":false,"configFileName":"tsconfig.json","projectType":"configured","languageServiceEnabled":true,"version":"4.3.0-dev.20210505"}}}
Info 48   [13:49:24.112] event:
    {"seq":0,"type":"event","event":"configFileDiag","body":{"triggerFile":"/home/andre/code-insider-test/packages/app/index.ts","configFile":"/home/andre/code-insider-test/packages/app/tsconfig.json","diagnostics":[]}}
Info 49   [13:49:24.112] Project '/home/andre/code-insider-test/packages/app/tsconfig.json' (Configured)
Info 49   [13:49:24.112] 	Files (6)

Info 49   [13:49:24.112] -----------------------------------------------
Info 49   [13:49:24.112] Project '/dev/null/autoImportProviderProject1*' (AutoImportProvider)
Info 49   [13:49:24.112] 	Files (1)

Info 49   [13:49:24.112] -----------------------------------------------
Info 49   [13:49:24.112] Open files:
Info 49   [13:49:24.112] 	FileName: /home/andre/code-insider-test/packages/app/index.ts ProjectRootPath: /home/andre/code-insider-test
Info 49   [13:49:24.112] 		Projects: /home/andre/code-insider-test/packages/app/tsconfig.json
Perf 49   [13:49:24.112] 2::updateOpen: elapsed time (in milliseconds) 584.7808
Info 50   [13:49:24.113] response:
    {"seq":0,"type":"response","command":"updateOpen","request_seq":2,"success":true,"performanceData":{"updateGraphDurationMs":560.6539529990405,"createAutoImportProviderProgramDurationMs":5.230364998802543},"body":true}
Info 51   [13:49:24.113] event:
    {"seq":0,"type":"event","event":"typingsInstallerPid","body":{"pid":12175}}
Info 52   [13:49:24.122] request:
    {"seq":3,"type":"request","command":"projectInfo","arguments":{"file":"/home/andre/code-insider-test/packages/app/index.ts","needFileNameList":false}}
Perf 53   [13:49:24.122] 3::projectInfo: elapsed time (in milliseconds) 0.3009
Info 54   [13:49:24.122] response:
    {"seq":0,"type":"response","command":"projectInfo","request_seq":3,"success":true,"body":{"configFileName":"/home/andre/code-insider-test/packages/app/tsconfig.json","languageServiceDisabled":false}}
Info 55   [13:49:24.123] request:
    {"seq":4,"type":"request","command":"geterr","arguments":{"delay":0,"files":["/home/andre/code-insider-test/packages/app/index.ts"]}}
Perf 56   [13:49:24.123] 4::geterr: async elapsed time (in milliseconds) 0.4701
Info 57   [13:49:24.125] event:
    {"seq":0,"type":"event","event":"syntaxDiag","body":{"file":"/home/andre/code-insider-test/packages/app/index.ts","diagnostics":[]}}
Info 58   [13:49:24.132] event:
    {"seq":0,"type":"event","event":"semanticDiag","body":{"file":"/home/andre/code-insider-test/packages/app/index.ts","diagnostics":[{"start":{"line":5,"offset":10},"end":{"line":5,"offset":14},"text":"Cannot find name 'Item'.","code":2304,"category":"error"}]}}
Info 59   [13:49:24.133] event:
    {"seq":0,"type":"event","event":"suggestionDiag","body":{"file":"/home/andre/code-insider-test/packages/app/index.ts","diagnostics":[]}}
Info 60   [13:49:24.133] event:
    {"seq":0,"type":"event","event":"requestCompleted","body":{"request_seq":4}}

@akomm I tried this again with the nightly version of TypeScript referenced in your TS Server log (4.3.0-dev.20210505), and it does reproduce for me now. However, it doesn’t reproduce with the 4.3.2 stable release. I think you just happened to get a nightly where things were temporarily broken. Let me know if you still get the issue with the latest TS version.

@andrewbranch thanks. The problem was not directly nightly, because I only installed it after I was asked to install vsc preview. It did not work in 4.2.* in general.
I think it was just fixed at some point and my nightly version was a step to short of the nightly version you'v got in which it worked...
But now I have installed v. 4.3.2 and it works! Problem solved, thans.


Allow Fields to have an "_error" assigned to them

Fields can have object values, in which case we need a way to set an
error at the object level. The library will pass "_error" to the Field as
the "error" prop to be displayed, but isValid wasn't respecting it as an error.
Also reused isValid selector in the reduxForm connect function so that we're not duplicating logic.
Fixes #1107

Nice work. 👍

Published in v6.0.0-rc.5.

@clayne11, dude... Reducing with string concatenation? 😎

Wow - I must have been half asleep when I wrote that... a little embarrassing.


is the plugin compatible with  redmine_didyoumean?

I used redmine_didyoumean now, is it  compatible with  redmine_didyoumean?
Thanks.

urrr, it seems having solve the problem. I can use it with redmine_didyoumea ,thanks.
Sorry to disturb.
Please Close the issue.


Uno

Hi @JerryNixon and thanks for all of your amazing work!
Do I understand right that Template10 is mostly aimed for UWP apps?
I read your post on issue #1688.
Any chance to have Template10 support for the Uno Platform?
It's basically UWP code that is ported to Droid, iOS, and WASM!
I'm willing to contribute if feasible at all.

I am not sure, yet, if that makes sense. Does it? Can navigation be made generic?


fix: build fixes for non-linux platforms

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libscap
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
TODO; nothing to see here, just testing things :)
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

/unhold

LGTM label has been added.  Git tree hash: 6781c9c6f4cc925d5a47e302033ee8eb18f27292

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


CLOUDSTACK-8821: UI Change

It provides appropriate message in the UI when configuring the firewall rules in Network page.
If the default egress policy is allow, then it says to block traffic. If the default egress policy is deny, then it says to allow traffic.

Dear Nitin,
I really appreciate your contribution to help end users understand what they are doing in this page - I honestly think that some sections need better explanations -, but having to close the pop up every time we access that page is a little annoying. Wouldn't it be better to show the informative text somewhere in the UI instead of showing a pop up every single time?
Thanks

Hi @GabrielAnca,
Generally we show some information in notification field(Top-Right side corner), which disappears after one or two seconds. But that is used in case of any event occurs. I don't think other than that any field exists UI which will disappear without user interaction.


Instructions do not match current UI with smartsheets

[Enter feedback here]
Trying to follow along with the instructions but smartsheets changed the UI
Sign in as a SysAdmin in the Smartsheet portal and navigate to Account Admin. (these options do not exist.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a53b5040-1612-5f4b-df45-e58637b8c290
Version Independent ID: a315f833-df85-7b61-796e-b82723efbe81
Content: Tutorial: Configure Smartsheet for automatic user provisioning with Azure Active Directory
Content Source: articles/active-directory/saas-apps/smartsheet-provisioning-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @twimmers
Microsoft Alias: jeedes

@Navoxctr
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Thanks @Navoxctr  for the feedback.I have made the doc change to address this issue and it should be live in next couple of days.
#please-close


allow for customization of the builder class

This isn't tested in a real laravel app yet but I did take a stab at it. I will test further in my app soon.
Note: I couldn't quite figure out what the difference between the ServiceProvider setting the AccessToken class was vs the AccessTokenRepository. It appears the Repository is needed for the unit test but I wasn't convinced based on the way the SP was written that it didn't need to be set in both places. Any ideas on this would be helpful.

This isn't tested in a real laravel app yet but I did take a stab at it. I will test further in my app soon.
Note: I couldn't quite figure out what the difference between the ServiceProvider setting the AccessToken class was vs the AccessTokenRepository. It appears the Repository is needed for the unit test but I wasn't convinced based on the way the SP was written that it didn't need to be set in both places. Any ideas on this would be helpful.

At some point Laravel added a way to add a custom AccessToken class. Before that existed, the only path to overriding the claims was to first override AccessTokenRepository, then have that class create your own AccessToken instead of Laravel's AccessToken, which would then allow you to build a custom JWT.  This was left in for backwards compatability.

I'm not really sure why your patch is so elaborate. Maybe I'm not understanding it properly. The ISS is a string, so all we'd need is a way to create a string. I see several ways..

simply allow for a 'issuedBy' => 'foobar'  in the config.
use a class like 'issuedBy' => MyCustomIssuedByClass, and have the handle method return a string.
both? Test for string vs class and use either.

Then just add one or more lines essentially doing:
  if (...config exists..) $jwt = $jwt->issuedBy(...);

But maybe im just missing the problem.
I'm not around much for a few days traveling.

I thought of doing a config value for issued by alone, but I was thinking possibly there were other builder functions like the iss one that I wasn't aware of, so I was trying to make a drop in replacement for other devs / use cases.

Letting you insert your own AccessToken kind of defeats the purpose of this package. Then you might as well just add ```Passport::useAccessTokenEntity(MyCustomAccessToken::class) to one of Laravel's Providers and you don't even need my package. And that might just be the best way to do this. Then you can write your own custom convertToJWT method with all the Registered Claim methods you want.
My package originated in a time when it was not straightforward to insert your own AccessToken (and thus custom claims). It's much easier now, and this package now really is just a convenience if you want to easily add some claims.

Thanks for tip on using Passport::useAccessTokenEntity. I didn't realize I could do that. I jumped through a lot of unanswered github issues about customizing the token and arrived at this project as the solution - thought it was just missing one little piece I needed. But you're right its definitely easier to use that method instead.


bma423 as wakeup ESP32 : OK at first time then KO , how to clear IRQ

Bonjour ,
I wish use bma423 as twatch 2020 V1 wakeup from lightsleep
The bma wake the watch up only first time
seems that the IRQ is always ON and the watch wake up after machine.lighsleep(10000).
No display from bma423.c ...
How to clear the IRQ or debug ?
Thanks for help
...
b.wrist_wear(double_tap_cb)

def bma_interrupt(pin):
    print("bma interrupt" + str(pin))
    print("Got BMA Accellorator Interrupt on pin:", pin)

bmaint = Pin(39, Pin.IN)
bmaint.irq(trigger=Pin.IRQ_RISING, handler=None,wake=machine.sleep)
#esp32.wake_on_ext0(bmaint, esp32.WAKEUP_ALL_LOW)
#esp32.wake_on_ext0(bmaint, esp32.WAKEUP_ANY_HIGH)

while True:
    print('5 s')
    utime.sleep(5)
    print('sleep 10s')
    machine.lightsleep(10000)
    print(str(machine.wake_reason()))

The following line of code will cause bma423 to fail to enter irq_handler.
bmaint.irq(trigger=Pin.IRQ_RISING, handler=None,wake=machine.sleep)

I execute the following code and it seems to wake up normally.
from machine import Pin, I2C
import bma
i2c = I2C(0, scl=Pin(22), sda=Pin(21),freq=400000)

bmaint = Pin(39)
b = bma.BMA423(i2c, address=25, int1=bmaint)

# 配置使能三轴加速度
b.accel_config(True, direction=b.LOWER_LEFT, layer=b.BOTTOM_LAYER)
b.accel()

# 使能步数统计
b.step_config(True)
# 读取步数
b.step_counter()

# 活动检测中断
def activity_cb(event):
    if event == 0:
        print('User is stationary')
    elif event == 1:
        print('User is walking')
    elif event == 2:
        print('User is running')
    elif event == 3:
        print('Invalid activity recognized')

b.activity(activity_cb)

# 单击事件中断
def single_tap_cb(event):
    print('Single tap received')

b.single_tap(single_tap_cb)

# 双击击事件中断
def double_tap_cb(event):
    print('Double tap received')

b.double_tap(double_tap_cb)

# 抬腕事件中断
def wrist_wear_cb(event):
    print('Wrist wear received')

b.wrist_wear(wrist_wear_cb)

def bma_interrupt(pin):
    print("bma interrupt" + str(pin))
    print("Got BMA Accellorator Interrupt on pin:", pin)

import machine
import utime
import esp32

#esp32.wake_on_ext0(bmaint, esp32.WAKEUP_ALL_LOW)
esp32.wake_on_ext0(bmaint, esp32.WAKEUP_ANY_HIGH)

while True:
    print('5 s')
    utime.sleep(5)
    print('sleep 10s')
    machine.lightsleep(10000)
    print(str(machine.wake_reason()))

The log is as follows:

You can run the above code to experience whether bma423 wakes up esp32 normally.

Thanks for help


chore: clean up synthtool

LGTM only with one question, the // eslint-disable-next-line @typescript-eslint/no-unused-vars in test files are auto-generated or manually added? If it's manual work we may want to do it through synth.py to avoid lint error. Thanks!

I guess the test you mention here is manual test not the test generated from micro-generator.


Test: Try out the Environments extension

Refs: https://github.com/microsoft/vscode-python/issues/24025, https://github.com/microsoft/vscode-python/issues/24067, https://github.com/microsoft/vscode-python/issues/23155

[ ] anyOS @anthonykim1
[ ] anyOS @eleanorjboyd
[x] anyOS @aeschli

Complexity: 3
Create Issue

Introduction
You are testing the environments extension. This extension is intended to replace the functionality of the python extension, specifically the environment management parts. When installed along side with Python extension, the environments extension will provide the various features that you normally used the python extension for, such as selecting environments, creating, deleting, managing packages etc. The current implement supports virtual environment via venv as a built-in feature.
Requirements:

Download and install the following, pick the platform specific VSIX from the build artifacts:

Envs extension: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=308165&view=artifacts&pathAsName=false&type=publishedArtifacts
Python extension: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=307999&view=artifacts&pathAsName=false&type=publishedArtifacts

Reload VS Code

Testing:

Open a python workspace
Create a venv environment if it does not exist. If it does make sure that it got selected. This view should have the info you need:

Try running python in the terminal using the run-in-terminal command from the editor run menu
Try switching environments, see if it is using the right one when you run. Ensure status bar shows the change.
Since venv are activated environments, environments view and project view should have an inline command create terminal try it.
Try deleting the .venv you created from file explorer, see what happens. (Note: deleting from outside of VS Code might not work because VS Code watcher does not report folder deletions, unless we specifically watch that folder)

seems like a env can have multiple versions of wheel?
should we signal which is being used actively?


endDate for month view is wrong

option endDate for month view is one month early

The bug is in 'fill' function (see the snap below).

months[0] and months[1] is the left / right arrow icon, months[2] ~ months[13] is 'Jan'~'Dec'.
The parameter in 'slice' function of jquery should be 'endMonth+2'.
My fixed code:
      if ((year == endYear) && (endMonth < 12)) {
        months.slice(endMonth + 2).addClass('disabled');
      }

@netwww1 thank you! That was very useful!

This is fixed in the current version :)


JSON.parse in py2ju is not able to parse strings containing single quotes

This works fine:
julia> str = """{
               "format": "zip",
               "variable": "surface_air_temperature",
               "product_type": "climatology",
               "month": "08",
               "origin": "era_interim"
           }""";

julia> py2ju(str)
Dict{String,Any} with 5 entries:
  "format"       => "zip"
  "month"        => "08"
  "product_type" => "climatology"
  "variable"     => "surface_air_temperature"
  "origin"       => "era_interim"

But the CDS website gives python dictionary with single quotes and on passing that to py2ju() it produces the following error:
julia> str = """{
               'format': 'zip',
               'variable': 'surface_air_temperature',
               'product_type': 'climatology',
               'month': '08',
               'origin': 'era_interim'
           }""";

julia> py2ju(str)
ERROR: Invalid object key
Line: 1
Around: ...{     'format': 'zip',     ...
                 ^

Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] _error(::String, ::JSON.Parser.MemoryParserState) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:142
 [3] parse_object(::JSON.Parser.ParserContext{Dict{String,Any},Int64,true,nothing}, ::JSON.Parser.MemoryParserState) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:227
 [4] parse_value(::JSON.Parser.ParserContext{Dict{String,Any},Int64,true,nothing}, ::JSON.Parser.MemoryParserState) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:168
 [5] parse(::String; dicttype::Type{T} where T, inttype::Type{Int64}, allownan::Bool, null::Nothing) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:463
 [6] parse at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:461 [inlined]
 [7] py2ju(::String) at /home/aries/.julia/dev/CDSAPI/src/CDSAPI.jl:41
 [8] top-level scope at REPL[16]:1
 [9] eval(::Module, ::Any) at ./boot.jl:331
 [10] eval_user_input(::Any, ::REPL.REPLBackend) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/REPL/src/REPL.jl:86
 [11] run_backend(::REPL.REPLBackend) at /home/aries/.julia/packages/Revise/BqeJF/src/Revise.jl:1184

Thank you for checking. Do you mind submitting a PR with a fix ?
On Tue, Jun 30, 2020, 08:02 Lakshya Khatri<EMAIL_ADDRESS>wrote:

This works fine:
julia> str = """{               "format": "zip",               "variable": "surface_air_temperature",               "product_type": "climatology",               "month": "08",               "origin": "era_interim"           }""";
julia> py2ju(str)
Dict{String,Any} with 5 entries:
"format"       => "zip"
"month"        => "08"
"product_type" => "climatology"
"variable"     => "surface_air_temperature"
"origin"       => "era_interim"
But the CDS website gives python dictionary with single quotes and on
passing that to py2ju() it produces the following error:
julia> str = """{               'format': 'zip',               'variable': 'surface_air_temperature',               'product_type': 'climatology',               'month': '08',               'origin': 'era_interim'           }""";
julia> py2ju(str)
ERROR: Invalid object key
Line: 1
Around: ...{     'format': 'zip',     ...
^
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] _error(::String, ::JSON.Parser.MemoryParserState) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:142
[3] parse_object(::JSON.Parser.ParserContext{Dict{String,Any},Int64,true,nothing}, ::JSON.Parser.MemoryParserState) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:227
[4] parse_value(::JSON.Parser.ParserContext{Dict{String,Any},Int64,true,nothing}, ::JSON.Parser.MemoryParserState) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:168
[5] parse(::String; dicttype::Type{T} where T, inttype::Type{Int64}, allownan::Bool, null::Nothing) at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:463
[6] parse at /home/aries/.julia/packages/JSON/d89fA/src/Parser.jl:461 [inlined]
[7] py2ju(::String) at /home/aries/.julia/dev/CDSAPI/src/CDSAPI.jl:41
[8] top-level scope at REPL[16]:1
[9] eval(::Module, ::Any) at ./boot.jl:331
[10] eval_user_input(::Any, ::REPL.REPLBackend) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/REPL/src/REPL.jl:86
[11] run_backend(::REPL.REPLBackend) at /home/aries/.julia/packages/Revise/BqeJF/src/Revise.jl:1184
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JuliaClimate/CDSAPI.jl/issues/17, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZQW3M2EKHCJL3U23CJXRDRZHA2ZANCNFSM4OMDUDEQ
.

Yes. I will fix this and #16 by today (and possibly #12 too).

@LakshyaKhatri Should we move back to implement our parse function again?
I start to think maybe regex is good for this case.

@michiboo, I think we might give a try to macros: Python dict/JSON to Julia dict. What do you say?

I think we should implement the parse function again, perhaps without regex. Also please avoid macros as much as possible. They are overused in languages out there.

This version works, (have to handle edge cases):
function py2ju(dictstr::AbstractString)
    try
        return JSON.parse(dictstr)
    catch
        dictstr = replace(dictstr, "'" => "\"")
        return JSON.parse(dictstr)
    end
end

I am working on other implementations but they are almost 10 times slower.

I don't think we need to super speed here as this operations will happen once, and most of the time will be spent on data transfer. I would just keep it simple and always replace the ' as you did before calling JSON.parse.


CA Car heating controls not working

Please check Services, Known Bug / Issues and Troubleshooting over here first: https://github.com/fuatakgun/kia_uvo/blob/master/README.md
Region and Brand of car
Canada SantaFe 2019
Version of the integration
Latest
Describe the bug
A clear and concise description of what the bug is.
My car supports the feature to remote start and has options for the heating steering wheel as well as both front and back defrosters. as seen below.

when i try to do it through this integration it starts the care but doesn't turn on those switches

Try the other options and let me know if they work.

i tried all the different options none work

is there something i can do?

On the website go into debug mode and sniff the traffic while you run the command. Compare the values to what we send.

How do i sniff the traffic?

is that something i can do with charles reverse proxy?

For Canada easiest way is the developer menu in your browser.

Charles works too if you prefer.

is there a tutorial i can follow?

i think this is what you're looking for right?
the settings i had it on were all heated features on (only heated steering wheel and front/back windshields are supported for my car) these are what i captured using the iPhone app and a proxy capture
{
"responseHeader": {
"responseCode": 0,
"responseDesc": "Success"
},
"result": {
"status": {
"lastStatusDate": "20240528195033",
"airCtrlOn": true,
"engine": true,
"doorLock": true,
"doorOpen": {
"frontLeft": 0,
"frontRight": 0,
"backLeft": 0,
"backRight": 0
},
"trunkOpen": false,
"airTempUnit": "C",
"airTemp": {
"value": "1AH",
"unit": 0
},
"defrost": true,
"lowFuelLight": false,
"acc": false,
"hoodOpen": false,
"transCond": true,
"steerWheelHeat": 1,
"sideBackWindowHeat": 1,
"dte": {
"value": 346.0,
"unit": 1
},
"tirePressureLamp": {
"tirePressureLampAll": 0
},
"battery": {
"batSoc": 72,
"batState": 0,
"sjbDeliveryMode": 1,
"batSignalReferenceValue": {}
},
"remoteIgnition": true,
"seatHeaterVentInfo": {},
"lampWireStatus": {
"headLamp": {},
"stopLamp": {},
"turnSignalLamp": {}
},
"windowOpen": {},
"engineRuntime": {}
}
}
}

let me know what to do next.

@cdnninja ?

Compare this to the debug logs and code to see what differs.

how can i view the debug logs?

Enable on the integration and view them in home assistant system core logs.

2024-06-05 00:14:34.372 DEBUG (SyncWorker_7) [hyundai_kia_connect_api.KiaUvoApiCA] hyundai_kia_connect_api - Planned start_climate payload {'setting': {'airCtrl': 1, 'defrost': True, 'heating1': '4', 'igniOnDuration': 10, 'ims': 0, 'airTemp': {'value': '14H', 'unit': 0, 'hvacTempType': 0}, 'seatHeaterVentCMD': {'drvSeatOptCmd': 0, 'astSeatOptCmd': 0, 'rlSeatOptCmd': 0, 'rrSeatOptCmd': 0}}, 'pin': '****'}
this is what appears

So now sniff the matching start command in the website compare and if you find differences in format submit a pull request.  If difference in values play with the yaml.
This will need to be something for you or the community to work on.  I don't own one of these cars anymore and don't have time to do the work.

In your yaml try pass 1 as the heating value instead of using the interface.

which yaml? in the custom_components folder under kia uvo?

No the yaml your sending in start_climate command.

Ah i figured it out! Next question is i want the temp to be set to 17º however that gets sent out through blue link as "01H" for the value of temp how can i input that as well?

That converts in code.  Send 17 and see if the logs show it sent correctly.

Hey i know it has been a while since this thread was created but so far this has worked quite well other than the fact that i cannot set the remote start value on the temp to HI the value for it "FEH" when captured through hyundais website additionally the heated steering wheel and rear defrost function doesnt get activated how can i get these functions to work or is there a way this could be implemented?

hey @cdnninja any idea how to fix this or a way I can help to provide the correct values to a contributor of this plugin?x

Looks like you have sniffed the traffic? Posting that and the logs would help.   Really it's just comparing what's different.

Yes I sniffed the traffic a couple of times. This is what i found.

that is what is sent.
what else should i retrieve?

With debug logs enabled what do you find is sent?   Here is the code that sends the command.   https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api/blob/2a9ce5712aed22eda031cfab4773b945527fb267/hyundai_kia_connect_api/KiaUvoApiCA.py#L544-L622
Starting line 597 is where it should align.  Please also compare without setting temp to "high" to see if that works as it was never implemented.

I went through the logs i believe this is what is being sent.
2024-12-27 17:33:31.678 DEBUG (SyncWorker_4) [hyundai_kia_connect_api.KiaUvoApiCA] hyundai_kia_connect_api - Planned start_climate payload {'setting': {'airCtrl': 1, 'defrost': True, 'heating1': '4', 'igniOnDuration': 10, 'ims': 0, 'airTemp': {'value': '1AH', 'unit': 0, 'hvacTempType': 0}, 'seatHeaterVentCMD': {'drvSeatOptCmd': 0, 'astSeatOptCmd': 0, 'rlSeatOptCmd': 0, 'rrSeatOptCmd': 0}}, 'pin': '****'}

Yes.  Heating 4 maps to a value that is in the stop climate command.   If you edit it via yaml you can switch it.  I don't recall which one 1 maps to in text form.

Yes.  Heating 4 maps to a value that is in the stop climate command.   If you edit it via yaml you can switch it.  I don't recall which one 1 maps to in text form.

I tried to put 1 here but it still didn't work. Is there a different yaml u were referring to?

Yes that is the correct spot.  So to clarify the home assistant logs now show the following after passing 1 to heating?
{'setting': {'airCtrl': 1, 'defrost': True, 'heating1': '1', 'igniOnDuration': 10, 'ims': 0, 'airTemp': {'value': '1AH', 'unit': 0, 'hvacTempType': 0}, 'seatHeaterVentCMD': {'drvSeatOptCmd': 0, 'astSeatOptCmd': 0, 'rlSeatOptCmd': 0, 'rrSeatOptCmd': 0}}, 'pin': '****'}
and the sniffed traffic matches perfectly other than air temp and the heated seats?
So from a symptom standpoint you are telling me the native app passes a 1 but turns on the steering wheel but home assistant starts the car without the steering wheel?
I am a bit lost on what the issue is.

Sorry my apologies for the lack of clarity. Home assistant sends heating1: "4", the traffic I sniffed from the native bluelink website/app sends heating1: 1, I cannot get the HACS integration to send the heating1: 1, value to bluelink.

So when you set to 1 in yaml what happens?
I'm needing more details vs brief responses.

I reinstalled the HACS integration and it worked I don't know what changed because when I tried to run it with the value of 1 before reinstalling it never worked and said unknown error. Great! Thanks for helping me with that!
Moving to the HI setting on the temp how can I send 1AH which I think is the value for high? I tried to put them value in the yaml but it only will accept a number.

Yeah it won't pass that through since logic exists to convert a degree to a hex value.
I'll have to see how hard it would be to add hi.
Hi probably has limited value though as a cold car will produce the highest temp it can when set to say 21 until it reaches that.


Preview/Save menu hiding behind plot on website?

@michaelaye reported in main bokeh repo: https://github.com/bokeh/bokeh/issues/3954
I just tried the preview/save function on this example:
http://bokeh.pydata.org/en/latest/docs/gallery/candlestick.html
and the result looked like this:
https://www.dropbox.com/s/3a6l141vqle2ybe/Screenshot 2016-02-26 16.10.01.png?dl=0
which is confusing at the least (same in Safari and Chrome, all on OSX, all current versions)
I also couldn't get to save anything, when I did right-click->save as on the remainder of that little preview window, it only offered to save something in html, i tried to change that extension to png, but the browsers (both) insisted that it would have to be html.

This is now fixed as we have a new better save button.


Update project title to use the preferred spelling #127

@gissoo want to make sure you're aware (I think you already are); I see on the Percy snapshots that the site title now requires too lines and the second is showing in our current styles.
review

[x] review site title on render PR site and confirm display is as expected/desired

Please see my note in Slack about verifying with Keely.

@rlskoeser Yes thank you! I became aware yesterday while I was working on the site title typefaces. I think the mobile header to become taller. I can make a chore to adjust after you complete this PR.

I'm going to go ahead and merge this. It's easy to update the title site config if needed and home page content when we're ready.


Features requiring direct linking to MIT Open

There are a few features we want that are ideal to have a per-environment reference to the MIT Open root url (i.e. http://mitopen.odl.mit.edu/) in situations where it needs to be a direct link regardless of the context. There's possibly a few ways to deal with this:
Approach

Statically link to the production url in our templates. It might be confusing in non production environments, but we can note that as a known limitation
Setting within Keycloak itself. I did some preliminary investigation for this and it is more involved and even more undocumented (to the degree of needed to dig through their source code). It's likely this is going to either take too long or dead end.
Derive the value from an environment variable. This doesn't involve needing to acquire a technical understanding of Keycloak's internals, but it's a bit nonstandard for Keycloak itself which wants to have values like this stored in the DB. Probably going to go with this though.

Acceptance Criteria

[ ] Logo should link to MIT Open (need to determine if this can be done on a per-environment basis or if it it'll have to be static).
[ ] When the user logs in, if they don't have a destination we should direct them over to Open. This is acceptable as a link/button on whatever page they end up on, but we don't want it to be a dead end.

Is this still an issue?

It's solved for html pages but not for emails. It's probably not a dealbreaker though since emails just statically link to production and we can live with that so I'll close this for now.