Bug fix for unaccounted bottom array rotation in NaI detectorID assig…

This PR fixes the bug in detectorID assignment of bottom NaI array.
The previous version does not take the rotation of bottom array geometry into account for detectorID assignment thus assigning vertical array detID to G4Step beyond unrotated bottom array. In this PR, I have fixed the x-position range.

@spandeyehep since this is a bug we can do this as a "hotfix" which means please make this PR target the master branch. Thanks!

@villaa Done.


support to accept automatically  the consent messages (one or more) at the start of the connection.

Hello everyone.
During the start of the connection several "consent messages" may be displayed.
In my case, they each end with the string:
"
[...]
I understand and agree to the terms of this policy (Y/N)
"
To accept them, you must press the "Y" + "enter" keys on each one.
It would be fantastic if we can automate this process with some kind of command line option such as:
"/consent-message-autoaccept" in case there is only on options ("y" for yes) or "/consent-message-autoaccept-string=" (for example "y,I do,y,y,just let me in, yes!!!,I said yes") in case the protocol allows more complex answers to the "consent messages"  user input.
Best regards && Thank you very much.

That seems like a totally specific feature, which will be in use just for your case.

If I take a step back, and try to take a larger view, we'd need a scripting language that would allow to:

send key pressed
send mouses moves
potentially do some graphics recognition (like waiting for a window to open)
inject clipboard content (easier than doing it key by key)
a few control primitives (if, wait, ...)

And at the end you have the nicest toolbox for remote automated tests, or for automating getting profit of a compromised host !

I think "It would be awesome ™ "
Best regards


Modernisation

Would there be any interest in migrating this project to more modern tooling and using an ESM only output?
I have a fork of this library: https://github.com/sachaw/mgrs-js/
There are a number of changes that I am implementing:

Use Biome in favour of TSLint + Pretter
Make package pure ESM
Move testing to a typescript native framework such as Japa
Improve formatting and correctness (semantics)
Use PNPM over NPM
Likely more

Sure, if you want to make some improvements, go for it.  Once you are done you can issue a pull request and we will take a look.

Except the ESM thing.  We use CommonJS and are not going to switch everything to ESM

Additionally, I don't think we'll be switching our toolchain to PNPM.  You're free to use PNPM if you wish, and make any modifications to satisfy its stricter requirements, but this package won't require it.  I personally don't have a strong opinion on the specific linter.  I question the payoff of switching test frameworks, and we certainly won't embark on that, but as @danielbarela says, we will gladly consider a PR.  Thanks for your interest and contribution.


Is there scope for adding bezier curves and circular arcs?

Thank you for a very well constructed and useful library!
Would there be scope for adding support for non-linear geometry like Bezier curves or circles and circular arcs?  Or would that not be compatible with this style of library?

Hi, thanks for the feedback,
about non-linear geometries: it will be great to have them, but I'm not aware of algorithms for circle-polygon intersection and others, so if you are know one -- then we can try to implement it.

I need to do more research on algorithms for the various linear/non-linear interactions and revisit this after that.

good luck in your research, I hope it will be productive


Core Team Profile Image Broken: _lila*

It seems the core team _lila* profile image is broken

Not sure why hugo is not correctly reading this remote profile image ?
https://pbs.twimg.com/profile_images/435039741671505920/Kt7C5rQi.jpeg


Passed a JWT with to a cluster with a 'cluster' role.

Added a new API Action to delete a cluster.
Cluster uses the JWT to call the API to shutdown when it is finished, rather than trying to delete its own stack.
Expected Differences

[ ] Do these changes modify the system output in any way? [Yes or No]
If yes, please describe:

Pull Request Testing

[ ] Describe testing already performed for these changes:

[ ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

[ ] Do these changes include sufficient testing updates? [Yes or No]

[ ] Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:

[ ] Please complete this pull request review by [Fill in date].

Pull Request Checklist

[ ] Review the source issue metadata (labels, project, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Project
Select: Milestone as the version that will include these changes
Select: Development to link to the original development issue.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe - Without the JWT, the API request to delete the cluster will fail.  So, unless you go out of your way to create the JWT and make it available on the cluster, the delete request will fail because it does not have the cluster ID and will not pass authentication or authorization.

closes #125


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter schoolfree for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.schoolfree
   -
:thumbsup: No errors found
:thumbsup: No warnings found
SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 06 Sep 2024 10:17:27 GMT

Issue outdated due to RECREATE request. Follow up issue #291 has been created.
This issue will be closed.
your
ioBroker Check and Service Bot


Improved some docstrings

Improved some docstrings:

mapping between mistletoe and commonmark terminology,
describing the representation of the content of the tokens.

Note: updated the docstrings for the HTML tokens, too.


Adds support for docker-machine

Related to issue #50.
Although it is already working I'd still consider this as a preview.
It seems to be missing to update Readme, add tests and improve the install (e.g. add_environment_variables is not important for docker-machine).
Can you please provide some feedback? And also what would you expect to get this merged?

Thanks for the pull request. I apologize for the delay, but I'm currently on the road with limited Internet access, so I'll take a look once I'm back (should be early August).

Since probably in almost all cases docker-osx-dev would be run against the active machine, I think you could drop the requirement to set the machine name environment variable on every invocation, and instead just use $(docker-machine active) to get it. Thoughts?

@brikis98, no problem, I still have to add some tests.
@ilkka, sorry getting ahead of you, but I needed it this week.
Correct, but there is the case where you can have multiple active docker-machines. What about passing the machine name as first argument?
docker-osx-dev machine-name

Also, I am trying to maintain compatibility with boot2docker. Later if needed we can drop support for it.

Thank you for the PR. This is a pretty massive change that forks the code in quite a few places. Do we know for sure that using boot2docker directly via the CLI is deprecated? Is docker-machine definitely the way to interact with Docker on the desktop in the future? If so, it's worth thinking about supporting only docker-machine. This project is hard to test (see #7), so I worry about any complications that fork the code too much.

The boot2docker-cli deprecation notice is here: https://github.com/boot2docker/boot2docker-cli#pending-deprecation
I have used docker-machine locally on OS X and it seems to work just fine, not sure if there's any reason to keep supporting the boot2docker-cli instead. Maybe somebody from Docker or somebody that has more knowledge around that can chime in.

Hmm, the Docker Docs still point to boot2docker and using it as a command line tool.

Thanks @brikis98 for the feedback!
I made some changes but, for me, there are at least two things outstanding:

Find an alternative to using python to parse docker-machine inspect json.
Add some automated tests

Regarding the boot2docker deprecation, my understanding is that it is slowly being deprecated. I'd suggest for now keeping support for both boot2docker and docker-machine. But in the near future, boot2docker support should be dropped.

OK, let's keep the boot2docker support a bit longer. Let me know if you have ideas on the JSON & automated test front.

Correct, but there is the case where you can have multiple active docker-machines.

@labianchin, multiple active? I thought the active machine was determined by DOCKER_HOST in the env, meaning there can only be one?

just tried this branch again and noticed a weird thing: my freshly generated virtualbox docker machine has a config like this:
{
    "DriverName": "virtualbox",
    "Driver": {
        "IPAddress": "<IP_ADDRESS>",
        ...
        "SSHPort": 55045,
        ...
    }
   ...
}

which makes docker-osx-dev sync try to connect to port 55045, which fails. docker-machine ssh <machine> works just fine though, as does manually ssh'ing to port 22. I have no idea why that value is there or what it's significance is, but set up like this, the sync doesn't work.

Ah, now I understand what is happening with SSHPort: that's the port on localhost that the vbox SSH port is forwarded to. So if you're gonna use SSHPort for rsync, you should connect to localhost, not the docker machine itself.

@labianchin, multiple active? I thought the active machine was determined by DOCKER_HOST in the env, meaning there can only be one?

@ilkka, Yes. That makes more sense when you use a driver like EC2, OpenStack or GCE. This way you can have multiple docker-machine active (and running) in the cloud. You might want to have a docker-machine per each project you have.
So in one terminal tab you can run:
cd project-foo && docker-osx-dev --machine-name machine-for-project-foo

And in the other:
cd project-bar && docker-osx-dev --machine-name machine-for-project-bar

which makes docker-osx-dev sync try to connect to port 55045, which fails. docker-machine ssh  works just fine though, as does manually ssh'ing to port 22. I have no idea why that value is there or what it's significance is, but set up like this, the sync doesn't work.

@ilkka Thanks for catching that! I was testing more with the openstack driver. There the SSHPort was 22. I will take a look on that. I guess I will have to understand better which params docker-machine ssh use.

@ilkka
So I was looking into what is the arguments docker-machine scp use, with the virtualbox driver it is this:
/usr/bin/scp [/usr/bin/scp -o IdentitiesOnly=yes -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -3 -i /Users/me/.docker/machine/machines/local/id_rsa foo.txt docker@<IP_ADDRESS>:/]

So, I just removed the -p argument for the rsync --rsh. Now should be fine.
But, one problem I am getting is that even after install_rsync_on_docker_host, and with rsync on /usr/local/bin it keeps getting -sh: rsync: not found.
It seems rsync 64bits is now available for tce-load: https://github.com/boot2docker/boot2docker/issues/936#issuecomment-120992953. @brikis98, should we use it?

You might want to have a docker-machine per each project you have.

@labianchin ah yes, but since active is stored in the env, it is per terminal session, so you can run multiple machines that way too, just in separate terminals. Essentially it's the same. I don't mind having the parameter, I just think that defaulting to whatever docker-machine active outputs saves typing and is in no way surprising behaviour :)

But, one problem I am getting is that even after install_rsync_on_docker_host, and with rsync on /usr/local/bin it keeps getting -sh: rsync: not found.

I found that I had to docker-osx-dev install before it found rsync after restarting (but not recreating) my docker machine, although I might have been hallucinating from all the coffee 😅 Don't know if it's related at all.

@labianchin: Yes, if the 64 bit rsync is now working, we should go back to using tce-load to install it. I think the original code is still in the comments. I've been meaning to do this, but haven't had a chance to get to it, so PRs are welcome :)

@ilkka, that make sense. I agree that would be a good default. But if, for now, we are keeping the support for boot2docker, then it would be better to keep the default (no --machine-name arg) as using boot2docker.
Also, I just run docker-machine active and I get this:
dev

But when I run docker-machine ls:
NAME         ACTIVE   DRIVER       STATE     URL                         SWARM
dev                   virtualbox   Stopped
dev1                  virtualbox   Stopped
dokku-test            openstack    Running   tcp://<IP_ADDRESS>:2376
lbianchin2            openstack    Running   tcp://<IP_ADDRESS>:2376
local                 virtualbox   Running   tcp://<IP_ADDRESS>:2376

That is weird.

So, I added some test cases and removed the python dependency. @brikis98 can you take a look?
I also rebased on top of master.
I run some simple manual tests and things look good. What I did was the following:
docker-machine -D create --driver virtualbox local
docker-osx-dev --machine-name local -e .git -l DEBUG install
docker-osx-dev --machine-name local -e .git -l DEBUG
touch foo

@labianchin: Thanks! I just left a bunch more comments. Almost there.

@labianchin that docker-machine active behaviour is due to the slightly different ways active and ls determine the active host. active only looks at the value of DOCKER_HOST, but ls also checks that the host is running.

@brikis98 thanks for the feedback, I will be making the fixes.
@ilkka Please see this: https://github.com/brikis98/docker-osx-dev/pull/77#discussion_r36412414
So running eval "$(docker-machine env <machine-name>)" would mean the user does not need use the --machine-name argument.

One idea I've tinkered with is some kind of --delta flag to docker-machine scp which would shell out to rsync if available instead of scp.  Would that be of interest to you / help your workload on this project?

Yes @nathanleclaire, I would be interested! Can you provide some details on what you have in mind? Probably via e-mail. Thanks!

@brikis98 I think I got all the suggested fixes in this last commit. Can you take a look?

@labianchin: A few more questions/comments above :)

Hey @brikis98, I've made some fixes. Please also see my previous comments.

I expect developers to run the docker-osx-dev script very frequently, so we should keep its startup time well under one second in the normal case. Therefore, the install command should take care of anything that:

Takes a long time (more than ~1 second)
Anything that needs to happen only once per computer
Anything that needs to be run before you can use docker (i.e., install docker itself)

This is why it includes install_dependencies, init_docker_host, install_rsync_on_docker_host, add_docker_host, and add_environment_variables. The actual docker-osx-dev script, in theory, should run just the watch_and_sync command. However, it runs a few other steps (e.g., install_rsync_no_docker_host) that:

Might go out of sync as the user tweaks their docker environment
Are very fast to run in the normal case (e.g., checking if rsync is installed is very quick)

The question I asked earlier, though I guess not very clearly, was whether the install command should automate the eval "$(docker-machine env <machine-name>)" command you have listed in the README, or any other manual steps necessary for using docker-machine?

Yes. That really make sense. Thanks for clarifying.
Answering your question: I believe it shouldn't, as users might want to switch between different docker-machine instances (machines). So every time they run docker-osx-dev (watch_and_sync), they supply which machine name they want to run with.
So, clarifying, this steps, should run just after creating a new machine instance:
eval "$(docker-machine env <machine-name>)"
docker-osx-dev install

Which is equivalent of:
docker-osx-dev --machine-name <machine-name> install

After the instance is created and docker-osx-dev installed, users only need to run:
eval "$(docker-machine env <machine-name>)"
docker-osx-dev

Or the equivalent:
docker-osx-dev --machine-name <machine-name>

Awesome, thanks for the PR. It's now merged.

Thanks for all the feedback! That has been a great experience contributing to this project.


Button: add critical action feature

Description

References
Fixes #1439
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
https://deploy-preview-2871--moduswebcomponents.netlify.app/?path=/story/components-button--danger-button&args=criticalAction:true
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Can we make "Accessibility Warning" text bold and remove the comma before "as." Otherwise, it's good to go :)

@prashanthr6383 By default, the critical-action in Storybook is set to true, but it should be changed to false.

I have updated now please check

Can we make "Accessibility Warning" text bold and remove the comma before "as." Otherwise, it's good to go :)

@enowak1031 changes Updated.

 Doesn't work on iPad

@coliff Yes. it Doesn't work on touch screen devices for now. So we have updated the storybook documentation as per discussion on meeting.

This doesn't work on iPad (Tested on iPad Pro with iPadOS 18.2)

@coliff Added the support for touch screen devices.


Improve Bootstrap ansible role

This change provides better documentation about the bootstrap Ansible role. Adds more system tests for checking kernel parameters, Kubernetes resources, cluster creation, etc. and expands its scope to Ubuntu Jammy release. Last but not least, it fixes some linting issues.

/approve
/lgtm
/override e2e


Cannot load module by SystemJS: Expected object

version: 1.4.1
SystemJS settings:
map = {
      "power-assert": "n:power-assert",
};
packages = {
   "power-assert": { main: "build/power-assert.js", defaultExtension: "js" },
}

My code
import * as assert from 'power-assert';

Which transpiles to:
var assert = require('power-assert');

And this line throws error:
Error: (SystemJS) Expected object
	TypeError: Expected object

Stack trace:
systemjs.src.js ~ line:3326
    if (exports && (exports.__esModule || exports instanceof Module))
      entry.esModule = loader.newModule(exports); // line:3326 <--- exports = function powerAssert ()
    // set module as 'default' export, then fake named exports by iterating properties
    else if (entry.esmExports && exports !== __global)
      entry.esModule = loader.newModule(getESModule(exports));
    // just use the 'default' export
    else
      entry.esModule = loader.newModule({ 'default': exports });

systemjs.src.js ~ line:892
    // <IP_ADDRESS>
    newModule: function (obj) {
      if (typeof obj != 'object')
        throw new TypeError('Expected object'); // line:892 <!--- obj  = function powerAssert (), typeof obj = "function"

      var m = new Module();

Link to <IP_ADDRESS> of Loader-Spec
https://github.com/calvinmetcalf/Loader-Spec/blob/master/spec.md#263312-reflectloaderprototypenewmodule--obj-
obj is referencing to:
        powerAssert = function powerAssert () {
            return enhancement.apply(null, slice.apply(arguments));
        };

Updated.

@unlight Thanks for your reporting and repro / fix case.
Hmm. Seems that your fix conflicts with ES6 Modules / CJS / Babel interop hack.

https://github.com/power-assert-js/power-assert/pull/28
https://github.com/power-assert-js/power-assert/pull/37

I know a little about SystemJS so I need your help more.
Is there any solution in SystemJS to solve this situation?

Hmm. Seems that your fix conflicts with ES6 Modules / CJS / Babel interop hack.

Maybe, but I just said that it fixes my problem.
I do not use Babel, etc.

Do you have unit tests for #28 and #37?
Actually #28 do not have conflicts, it is the same code:
var defaultAssert = customize();
defaultAssert.default = defaultAssert;
module.exports = defaultAssert;

var defaultAssert = customize();
module.exports = defaultAssert;
module.exports['default'] = defaultAssert;

About #37.
{ '__esModule': true } I don't understand why it was added, this property is added by transpilers when generating ES6 code. But your code written in es5.
I think @falsandtru should provide the case what cause him to pull such request.
What module consumer/platform requires that.

Would you try __useDefault: true?

Actually #28 has no conflicts, it is the same code:

ah, yes.


Made log-level configurable for nats-manager

Description
Changes proposed in this pull request:

Made log-level configurable for nats-manager

Related issue(s)

https://github.com/kyma-project/nats-manager/issues/53

/test all


Hovers & infoview fail for ex_of_PSigma

Neither the LSP hover for the definition id nor the infoview goal display (on the first x in the body e.g.) work in the ex_of_PSigma theorem. The infoview shows the following error:
Error updating: Error fetching goals: Rpc error: InternalError: unknown constant '«term_×'_»'

What happens is that there's a built-in delaborator for PSigma, but the ×' syntax is defined using a ParserDescr.  So the delaborator produces invalid syntax before the notation command for ×'.

Several other delaborators have the same issue, namely delabDite and delabCond.

I think this is a known issue, it is only a problem inside the prelude itself.


Fix 404 on "Cloud Site List Management for IE mode (Public Preview)" page

Some links return 404 because of domain duplication.

@SIkebe thanks for catching. Since we're republishing for another reason, I'll do the fixes in my branch. Please cancel the merge request. Thank you.

@dan-wesley  Some recently updated documents have similar issues. Do you plan to fix them, too?
https://docs.microsoft.com/en-us/deployedge/microsoft-edge-relnote-stable-channel?source=docs#version-950102030-october-21
If not, I can send a PR.

Yes, this evening
From: SIkebe @.>
Sent: Thursday, October 21, 2021 6:00 PM
To: MicrosoftDocs/Edge-Enterprise @.>
Cc: Dan Wesley (Experis) @.>; Mention @.>
Subject: Re: [MicrosoftDocs/Edge-Enterprise] Fix 404 on "Cloud Site List Management for IE mode (Public Preview)" page (PR #246)
@dan-wesleyhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdan-wesley&data=04|01|v-danwesley%40microsoft.com|cd95fa3d1475496fe0bc08d994f73514|72f988bf86f141af91ab2d7cd011db47|1|0|637704611740000957|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cEofEsP066ETJud5nV5uPfQZTaCNE%2F2Um%2BOjhiVHUjM%3D&reserved=0 Some recently updated documents have similar issues. Do you plan to fix them, too?
https://docs.microsoft.com/en-us/deployedge/microsoft-edge-relnote-stable-channel?source=docs#version-950102030-october-21https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fdeployedge%2Fmicrosoft-edge-relnote-stable-channel%3Fsource%3Ddocs%23version-950102030-october-21&data=04|01|v-danwesley%40microsoft.com|cd95fa3d1475496fe0bc08d994f73514|72f988bf86f141af91ab2d7cd011db47|1|0|637704611740010913|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=rVya8qVScshH1uCESXLT9LCGxdelEwzgXs8W%2BG%2Fi%2BFM%3D&reserved=0
If not, I can send a PR.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FEdge-Enterprise%2Fpull%2F246%23issuecomment-949137719&data=04|01|v-danwesley%40microsoft.com|cd95fa3d1475496fe0bc08d994f73514|72f988bf86f141af91ab2d7cd011db47|1|0|637704611740010913|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=AxNv1785pBpgEnIxO5On2gvJFZCiNJ1PHo9IigdSU6Q%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJCKPOBZH2HPY3VJBIR7L73UICZPHANCNFSM5GM74Y7A&data=04|01|v-danwesley%40microsoft.com|cd95fa3d1475496fe0bc08d994f73514|72f988bf86f141af91ab2d7cd011db47|1|0|637704611740020876|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=mM0%2BFLUg1pCB3ECOdGf4Qf%2BmkydH35DRx42WvkQNRZs%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|v-danwesley%40microsoft.com|cd95fa3d1475496fe0bc08d994f73514|72f988bf86f141af91ab2d7cd011db47|1|0|637704611740020876|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=KR9ZWx7T7Ivyk8lH0TJqeCVdpwGdkSPUnbAOoUwHNms%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|v-danwesley%40microsoft.com|cd95fa3d1475496fe0bc08d994f73514|72f988bf86f141af91ab2d7cd011db47|1|0|637704611740030839|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PiDBsoTodnNH0d7TN%2FZhIao2HuywXBBwCKuB0Sw%2FFMs%3D&reserved=0.

Just republished, found some others from previous iterations.
Thanks for your catches.
dan
From: SIkebe @.>
Sent: Thursday, October 21, 2021 6:23 PM
To: MicrosoftDocs/Edge-Enterprise @.>
Cc: Dan Wesley (Experis) @.>; Mention @.>
Subject: Re: [MicrosoftDocs/Edge-Enterprise] Fix 404 on "Cloud Site List Management for IE mode (Public Preview)" page (PR #246)
Thanks!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FEdge-Enterprise%2Fpull%2F246%23issuecomment-949164098&data=04|01|v-danwesley%40microsoft.com|5c2077473b4d46573d7208d994fa6c57|72f988bf86f141af91ab2d7cd011db47|1|0|637704625555264927|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Tj6ZfCNOm1TtizI5yqEerOm9umDUCF1Qe3C00kH1iTs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJCKPOC3DOJBVY3KO2UGJHDUIC4FRANCNFSM5GM74Y7A&data=04|01|v-danwesley%40microsoft.com|5c2077473b4d46573d7208d994fa6c57|72f988bf86f141af91ab2d7cd011db47|1|0|637704625555264927|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=kCdnnfIo2A9FBs5oLLz41yA78El8yyswaN5PCxxXkx4%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|v-danwesley%40microsoft.com|5c2077473b4d46573d7208d994fa6c57|72f988bf86f141af91ab2d7cd011db47|1|0|637704625555274882|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=OK9opdnlJ4Mu3nVMDjDkBwgMLXrQ%2BO7UjkT8Ez8CbS4%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|v-danwesley%40microsoft.com|5c2077473b4d46573d7208d994fa6c57|72f988bf86f141af91ab2d7cd011db47|1|0|637704625555274882|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=fFlwrpfAOolCPQ%2BOnqkEXqJnKRSc5Mkm1CE7QgrKH4w%3D&reserved=0.


DateTime field keyboard issue

When I click into the DateTime field in my form many times, eventually, the arrow in the bottom left makes goes down believing there's a keyboard there. When I click my X in the top left of the screen, I have a dialog that comes up and when I press a button, it calls Navigator.pop() twice so that it removes the dialog and goes back to the previous page. However, when I get to that page, the DateTime field shows up on my screen. When I click "Cancel", my editor pauses on an exception and when I tell it to continue a couple of times, it spits out this error.

E/flutter ( 6866): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: NoSuchMethodError: The method 'didChange' was called on null.
E/flutter ( 6866): Receiver: null
E/flutter ( 6866): Tried calling: didChange(null)
E/flutter ( 6866): #0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:51:5)
E/flutter ( 6866): #1      _FormBuilderDateTimePickerState._onShowPicker
package:flutter_form_builder/…/fields/form_builder_date_time_picker.dart:343
E/flutter ( 6866):
E/flutter ( 6866): #2      _DateTimeFieldState.requestUpdate
package:datetime_picker_formfield/datetime_picker_formfield.dart:287
E/flutter ( 6866):

When I press the down-facing arrow, it acts as though there's nothing there and it keeps popping the screen like usual. However, nothing I do fixes it unless I go into the form and the keyboard appears. When I get rid of the keyboard by pressing that arrow, it returns to it's normal position.
This screenshot shows the arrow in the bottom left pointing down signaling a keyboard or something else:

Should have been closed by v3.10.0. Feel free to reopen if not.


Admin Console - Twitter Import Not Authenticating

I'm on crate_0.50.3 and when I click the "Import tweets for testing" button the twitter authentication window fails to appear.
Seems to be failing (502 Bad Gateway) on this GET call:
https://twitter.crate.io/api/v1/sample?origin=http%3A%2F%2F<IP_ADDRESS>%3A4200%2F_plugin%2Fcrate-admin%2Findex.html
Trying to roadshow Crate internally so any help on this would be appreciated!

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26250978-admin-console-twitter-import-not-authenticating?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github).

Not getting the 502 today.
Not sure if you made a change or not , but the redirect to twitter is working.
Thanks.


Crash when rfxtrx configuration contains hex device IDs that look decimal

Home Assistant release (hass --version):
0.23.1
Python release (python3 --version):
Python 3.4.2
Component/platform:
rfxtrx
Description of problem:
When device IDs don't contain HEX "letters", the IDs are parsed from YAML as ints, which causes a crash when trying to convert what is assumed to be a hex string but is actually an int.
Expected:
A proper error message should be displayed, and the documentation should probably show device IDs wrapped in quotes.
Problem-relevant configuration.yaml entries and steps to reproduce:
  devices:
<PHONE_NUMBER>010170:
      name: x10_a1

Traceback (if applicable):
INFO:homeassistant.loader:Loaded switch.rfxtrx from homeassistant.components.switch.rfxtrx
Traceback (most recent call last):
  File "/usr/lib/python3.4/pdb.py", line 1661, in main
    pdb._runscript(mainpyfile)
  File "/usr/lib/python3.4/pdb.py", line 1542, in _runscript
    self.run(statement)
  File "/usr/lib/python3.4/bdb.py", line 431, in run
    exec(cmd, globals, locals)
  File "<string>", line 1, in <module>
  File "/usr/local/bin/hass", line 4, in <module>
    import re
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/__main__.py", line 386, in main
    exit_code = setup_and_run_hass(config_dir, args)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/__main__.py", line 293, in setup_and_run_hass
    log_rotate_days=args.log_rotate_days)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/bootstrap.py", line 292, in from_config_file
    skip_pip=skip_pip)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/bootstrap.py", line 264, in from_config_dict
    _setup_component(hass, domain, config)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/bootstrap.py", line 129, in _setup_component
    p_validated = platform.PLATFORM_SCHEMA(p_validated)
  File "/usr/local/lib/python3.4/dist-packages/voluptuous.py", line 355, in __call__
    return self._compiled([], data)
  File "/usr/local/lib/python3.4/dist-packages/voluptuous.py", line 655, in validate_dict
    return base_validate(path, iteritems(data), out)
  File "/usr/local/lib/python3.4/dist-packages/voluptuous.py", line 432, in validate_mapping
    cval = cvalue(key_path, value)
  File "/usr/local/lib/python3.4/dist-packages/voluptuous.py", line 794, in validate_callable
    return schema(data)
  File "/usr/local/lib/python3.4/dist-packages/voluptuous.py", line 1392, in __call__
    v = schema(v)
  File "/usr/local/lib/python3.4/dist-packages/voluptuous.py", line 355, in __call__
    return self._compiled([], data)
  File "/usr/local/lib/python3.4/dist-packages/voluptuous.py", line 794, in validate_callable
    return schema(data)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/rfxtrx.py", line 90, in _valid_light_switch
    return _valid_device(value, "light_switch")
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/rfxtrx.py", line 68, in _valid_device
    if get_rfx_object(key) is None:
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/rfxtrx.py", line 162, in get_rfx_object
    binarypacket = bytearray.fromhex(packetid)
TypeError: must be str, not int
Uncaught exception. Entering post mortem debugging
Running 'cont' or

Is #pr2497 solving your problem?


Support for non diffuse Fluids

I think the only functionality missing for it is creating the particle buffer for it
PxCudaTopLevelFunctions.CreateAndPopulateParticleBuffer

I didn't come across anything that I miss yet, will let you know whenever I encounter something else. Great work on the wrapper! :)


Disable no atomic push command line flag

Fix #166

After playing around with the code, I'm not sure about the name of the key in the configuration file
@mlongtin0 what do you think about using:
[git]
atomic_push = false

instead? the "use" verb is a bit confusing for me

sounds good


Compute new workspace analytics

We want to display more analytics in the workspace page:

mentions from 30 days
configurations from 30 days
user_messages from 30 days

References:

Figma
Original Github issue

(cc @thib-martin for progress tracking)

Closing at this needs more framing
See https://github.com/dust-tt/tasks/issues/897


[WIP] Create nightly builds and upload them to public Dropbox folder

I had idea that it would be nice to have something like nightly builds :-)
Dropbox just because it was first think that I could think of for file sharing.
This adds script that automatically uploads binaries for multiple platforms to public directory on Dropbox.
Resulted binaries are accessible to anyone at https://www.dropbox.com/sh/lcz3o5o0i0gv6fw/AADMZrz7URk0R6qkKnyE7Hs7a?dl=0
depends on: #46

lets forget about this for now ;-)


Open Mainframe Summit promotion materials

[ ] - Create social materials for community members to share
[ ] - Push on CFP, registration, and sponsorship via social
[ ] - John personally reach out to members and opportunities

Here are a bunch:
The inaugural #OMPSummit will bring together mainframers to share best practices, learn technical insight from the best, and network with like-minded individuals who are passionate about the #mainframe industry. Sept. 16-17 - Register: https://bit.ly/3fg77zI
The virtual #OMPSummit will be here before you know it! Collaborate with fellow #mainframers and learn the latest technical insight from the best.  Sept. 16-17 - Register now: https://bit.ly/3fg77zI
Mark your calendars!!  September 16-17 the inaugural #OMPSummit. Register now to learn and network with like-minded individuals who are passionate about the #mainframe industry. Register now: https://bit.ly/3fg77zI
JOIN #OMP for the inaugural #OMPSummit Sept. 16-17.  This is a virtual event to bring together mainframers to share best practices, learn technical insight from the best, and network with like-minded individuals who are passionate about the #mainframe industry. Register: https://bit.ly/3fg77zI
BECOME A SPONSOR at the #OMPSummit – Sept. 16-17 - Learn more by downloading the prospectus: https://bit.ly/2O9ERTx  #mainframe #OMP
Interested in sponsoring at the #OMPSummit this Sept. 16-17? Find out how: https://bit.ly/2O9ERTx #mainframe #OMP
CALL FOR PAPERS – For The Open Mainframe Summit - a virtual event! Submit your talk for any of the three tracks: Executive, Linux on Z and z/OS. Extended until July 17th.  https://bit.ly/3890xbI  #CFP #OMP #OMPSummit
Also went with OMPSummit so we could get more charcters into twitter and it was used in December.

I update with @OpenMFProject


want to add new game

game :
I want to add AI chess game under GSSocC'23.

I want to add a temperature converter game

Please assign this issue to me under GSSOC 2023


addresses issue 97

see #97

Coverage decreased (-0.9%) to 94.303% when pulling e3a01ba49d3962417bb3fbeacb6ba5637b9ec642 on sfrooster:add_request_timeout_2 into d277cab2b7a9ec00a8ca9075bfa53d700ed572db on nats-io:master.

Coverage decreased (-0.9%) to 94.303% when pulling e3a01ba49d3962417bb3fbeacb6ba5637b9ec642 on sfrooster:add_request_timeout_2 into d277cab2b7a9ec00a8ca9075bfa53d700ed572db on nats-io:master.

Be good to have some tests to prove it works correctly. Also check why tests failed.

I fixed he original round of failures, current failure only occurs with
Node6:

Yield should yield to other events:
Uncaught AssertionError: expected 21 to be within 10..20
at Assertion.fail (node_modules/should/cjs/should.js:205:17)
at Assertion.value [as within] (node_modules/should/cjs/should.js:277:19)
at Timeout. (test/yield.js:33:20)

Don't know what that is.  As for a new test, my question is what behavior
would be inline with a timeout from the other clients?
On Sun, Nov 20, 2016 at 7:15 PM, Derek Collison<EMAIL_ADDRESS>wrote:

Be good to have some tests to prove it works correctly. Also check why
tests failed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nats-io/node-nats/pull/99#issuecomment-261832808, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC-vlxzyaTAkVyRQLcibTGZhG3WI1Yxdks5rAQzrgaJpZM4K3xTA
.

That failure may be an anomaly. The testing framework allows for async testing, so we should add in a test that passes only if the request times out within the right amount of time.

Let me know when you add in the tests. If you could also rebase with master (not required) that would be great.

Tried writing mocha tests to catch async errors thrown and treat as success - no luck.

looks like there are other ways to tackle this in node

The correct is way is https://github.com/nats-io/node-nats/issues/97


Text cursor movement by tap fails on iPad

As guessed in #28 Substance isn't quite ready for mobile yet.
Current Substance demos render on iPad and it is possible to type, but only at the original text cursor position. You can tap somewhere else in the text and the text cursor will move, but you still type at the original location.
On iPhone the demos have issues with the small screen and it is hard to get to typing.
On an Android 4.4 phone with 1020p screen, both portrait and landscape, it is only the credits footer that renders while the rest of the screen is grey.

I should add that I consider this issue to be about the text cursor only, while I described rendering behaviour only as background. The replacement of contenteditable with a custom technique benefits from early validation.
It is interesting that iPad shows a B/I/U styling button when text is selected, so it must have some understanding of the editable concept. It fails to change styling though.

Hey @solsson Thanks for this investigation! We will try to address this soon.
As you have seen, we do not deal with touch events (as opposed to mouse events) correctly. Then you see the selection not changing internally.
The other thing you detected are natively implemented ContentEditable features, such as those annotations, but also things like spell-checking etc. We pretty much know how to address this, but just haven't done it yet.

On Windows 8 touch it works nicely with all browsers, though with visual differences. Firefox just sets the cursor, IE 11 sets the cursor and displays a black circle underneath, Chrome sets the cursor and displays a blue drop shape and a small menu akin to iPad's that gives you the option to paste or expand a context menu. I guess this is by design for each browser and all good. With all of them you get your typing where the cursor is.


This page is outdated

This page is outdated and refers to the old AWS SSO console. The new IAM identity center configuration steps and interface is different from AWS SSO. Also there seems to be missing a process for configuring AWS IAM identity center integration with Azure AD if AWS organizations is enabled.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3bd35b3e-5e84-8be5-f87b-b4b666a9f7cd
Version Independent ID: c768f626-4ea1-4ede-492d-3a9d9e2178f3
Content: Tutorial: Azure Active Directory integration with Amazon Web Services to connect multiple accounts - Microsoft Entra
Content Source: articles/active-directory/saas-apps/aws-multi-accounts-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@dextercgy
Thanks for your feedback! We will investigate and update as appropriate.

the document has removed from repo.
#please-close


Apply dark theme

Can be implemented by following this post ?

commit b607fcb06fd99fc4ffe0c9a44f8c543ac481ad8a
Done the same as https://github.com/anebz/anebz.github.io/commit/07c9a7701fb1fb8166e83a8d83351fd09b2f309f but nothing happened...

Applied!


Init nixVersions.minimum and fix lib tests for all Nix versions

Description of changes
The lib.filesystem.pathType implementation now uses the new builtins.readFileType when available (in Nix 2.14) since https://github.com/NixOS/nixpkgs/pull/224834. But the tests introduced in that same PR weren't verified to work with 2.14, discovered in https://github.com/NixOS/nixpkgs/pull/233439, so this PR fixes that:
$ PATH=$(nix-build -A nixVersions.nix_2_14)/bin:"$PATH" lib/tests/filesystem.sh
test case failed:  lib.filesystem.pathType "/tmp/tmp.NXl2RIGW9m/non-existent" == error:
       … while calling the 'readFileType' builtin

         at «string»:1:46:

            1| { path }: let lib = import <nixpkgs/lib>; in lib.filesystem.pathType path
             |                                              ^

       error: getting status of '/tmp/tmp.NXl2RIGW9m/non-existent': No such file or directory, but error: evaluation aborted with the following error message: 'lib.filesystem.pathType: Path /tmp/tmp.NXl2RIGW9m/non-existent does not exist.' was expected

In addition, this PR fixes the tests for Nix version 2.3, since that's the minimum supported Nix version in Nixpkgs according to lib/minver.nix
And in order to ensure this doesn't happen again in the future, I created nixVersions.minimum to point to the Nix version from lib/minver.nix, and set up the lib tests to run with all of nixVersions.minimum, the default one, and nixVersions.unstable.
This work is sponsored by Antithesis :sparkles:
Things done

[x] Ran the above command successfully

Backport to 23.05 needed?  It still won't pass with latest Nix version, which seems problematic, e.g. https://github.com/NixOS/nix/pull/8569

(Apparently, parts of this were already backported in the PR shown above.)

So at least this one?
https://github.com/NixOS/nixpkgs/pull/239188


expose dialog close attempts

context:
https://github.com/angular/material2/pull/2853#discussion_r98515217
https://github.com/angular/material2/pull/2853#issuecomment-276301986
will try to do it myself later next week, unless someone wants to take it ( @crisbeto )

Dredging up some seriously old memories, I believe this was just called 'beforeClose' in ExtJS (and possibly others). Not a clue if they still use the paradigm, but many action events had 'beforeEVENT_NAME' versions that would abort the primary event if any of the 'before' listeners returned false.
Not suggesting it is ideal for this case, just throwing out some existing terminology that jumped to mind. Looking forward to this feature, for the basically exact reasoning you mentioned - catching a close before it happens and updating a model. The model update has a validation step, meaning that I might need to prevent the close.

I don't know, beforeClose has the opposite problem of what @crisbeto has, with closeAttempt.. if "attempt" implies fail, "beforeClose" pretty much implies success. I still think attempt fits better. Anyway I lost hope of that PR ever getting merged or reviewed anyway.

It has the advantage of being prior art. A whole lot of people are familiar with ExtJs / Sencha. Perhaps closeRequest or closeRequested - but I don't think that improves on closeAttempt.
The advantage of beforeClose, is that it is quite clear that it takes place before an actual close. It isn't as obvious that the close attempt isn't guaranteed to follow.
Just making noise. Could call it perhapsClosingSoonMaybe for all I care. I just want to be able to abort the close! I can see why you're frustrated.


Support for Token Refresh

Attention:
Changed Configuration due to inconsistent naming of options:

backendLoginApi is now obtainTokenUrl.

I kept the original around, but marked it as deprecated. This attribute should be removed in the future and at the same time obtainTokenUrl made required.
As always: quick release is much appreciated!

I will have a quick look and release it asap! Thank you for your contributions!

I have made a short code review and while doing so, I have observed that the refresh-token flow you have implemented is not quite the standard. As far as I understand, the access_token and the refresh_token are two different things. The access_token is the signed JWT for stateless auth handling and should optimally be rather short lived. The refresh_token on the other hand can be opaque to the client, meaning it is just a random string token which can be used to fetch a new access_token.
If you think about it: You can not fetch a new JWT with an already expired JWT as by definition, an expired JWT has no (auth) value at all and wont be trusted.
I found the following links quite well written about refresh tokens:
https://auth0.com/learn/refresh-tokens/
https://auth0.com/blog/refresh-tokens-what-are-they-and-when-to-use-them/

Hm, funny thing. I've based my work on this, which for some reason follows a completely different philosophy. Since, obviously there is a discrepancy between the standard and my backend, how about providing a varied api? E.g. I could rename the option to refreshAccessTokenUrl or some other name.

If I understand your design right, the only difference is that there is no special refresh_token and the access_token is (abused) for the refresh_token too. So it should be rather simple to support your special case but still be compatible with the standard by default:
By default, upon login the following JSON is expected:
{
  token_type: "bearer"
  access_token: "my-jwt.token.asdf..."
  refresh_token: "abcdef..."
}

As the refresh token is opaque to our client, it does not care what its content is. So it might well be the access_token JWT. So if we allow to config the field names of the access_token and refresh_token, you could simply configure it as refresh_token: "access_token" so it will use the JWT for refreshing - if that is what your backend requires.

I will give this a shot as it is something which we want to support in our system anyway. I merge this PR into a feature branch here and then refactor it to what I believe is compliant with the standard and still allows your use-case to work.

A version targeting more broad use cases is on its way...

alright i will then wait until you have finished and will remerge into our feature branch.

I'm going to refactor a greater part of the code. Is it alright for you, if I just rename Authentication*to Auth*? This would make the code much more handy.

Yes you can, as I already plan for some other breaking changes which will require a new major release anyway. Speaking of refactorings, I think it would be great to have the refresh handling in a separate class / file.
The idea would be that the TokenRefreshManager would take a refresh_token and the use a configurable interval to refresh the current access_token. Once he gets the new access token, it will update it by invoking the AuthService. This way, the auth service does not increase in complexity too much.

Ok, I was planning a TokenService providing such a machanism. In my point of view, this would be more appropriate, since it'll combine all functionalities regarding tokens.

Maybe you can go for a TokenService and a TokenRefreshService :) I guess you will see what plays out along the way.

Ok, I'm done for today. Would be great, if you have a look around the new code.


added edward elric card

Sorry, Edward Elric already exists on the website. Please try adding a different character. Do Sync your Fork before adding other characters.


Adds a BIL Concrete Executor

This PR adds a concrete executor for the BAP IL. As of now, it is not used anywhere, but it should hopefully be integrated into the tests soon.

A few things, it's not clear this code should be in QIRA and not BAP. That said, QIRA is fine if you think it is, but move it out of middleware.

We were initially planning on leaving this out of QIRA, but after seeing it identify bugs in QIRA, it seems that it could be useful to build some test cases around it. Additionally, we will soon be extending it to a concolic executor, which will be useful for QIRA.
As long as you're in agreement, where would be a reasonable place to put this?

I think of it more like pin or QEMU, let's move pin and qemu into a folder called tracers, then put this in tracers/

Done. It's super cool that BAP matches byte for byte on this stuff. Add to whatever you want to call it under tracers/
Also, can we add this to the regression testing suite?

Moved


Added features / redesign plugin

Please see commits and README.MD for changes.
There are breaking changes in this PR, that's why I've changed the version to 2.1.
I think the changes are useful, I have them implemented on my project.
Solves:
https://github.com/dellermann/i18n-asset-pipeline/issues/4
https://github.com/dellermann/i18n-asset-pipeline/issues/11
https://github.com/dellermann/i18n-asset-pipeline/issues/12

Thank you for your contributions. I'll revise it soon…

i see  this PR is from may and hasnt been updated. anyone opposed to me just rolling it into the official asset-pipeline github repository

@davydotcom please do. I think it makes more sense being a part of the overall asset-pipeline ecosystem anyways


Panic: regex string should be pre-tested

I ran git dive some/path.js, and I got this error.
I didn't see another issue like this.  Also, CONTRIBUTING.md links to pages that are 404 under the Reproducing Bugs section.
name = "git-dive"
operating_system = "Mac OS 12.6.3 [64-bit]"
crate_version = "0.1.4"
explanation = """
Panic occurred in file '/Users/username/.cargo/registry/src/github.com-1ecc6299db9ec823/syntect-5.0.0/src/parsing/regex.rs' at line 69
"""
cause = 'regex string should be pre-tested: InvalidEscape("\\g")'
method = "Panic"
backtrace = """

   0: 0x100ec91ac - core::panicking::panic_fmt::hc1e7b11add95109d
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/core/src/panicking.rs:64
   1: 0x100ec94e4 - core::result::unwrap_failed::ha64769ab43736478
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/core/src/result.rs:1790
   2: 0x100dc3754 - once_cell::imp::OnceCell<T>::initialize::{{closure}}::hd160a7b43ae47aca
   3: 0x100e7cc88 - once_cell::imp::initialize_or_wait::h4bf1cb0769eecfc6
   4: 0x100ec29e0 - once_cell::imp::OnceCell<T>::initialize::hfa0ecea66c21dd66
   5: 0x100db9c1c - syntect::parsing::parser::ParseState::parse_line::h67de369ea7193e18
   6: 0x100dbfc84 - syntect::easy::HighlightLines::highlight_line::hf107f86ea5a37c78
   7: 0x100ce32fc - git_dive::blame::Highlighter::highlight_line::h5615ad5bcf46457f
   8: 0x100ce1970 - git_dive::blame::blame::hf39c7be23b699d5e
   9: 0x100cdd0ac - git_dive::run::he7b58947217cc271
  10: 0x100cdbad8 - git_dive::main::hbc47442bdfbf0b39
  11: 0x100cbe68c - std::sys_common::backtrace::__rust_begin_short_backtrace::h8f8aee8f71355006
  12: 0x100cc203c - std::rt::lang_start::{{closure}}::h36056f8a7137c93b
  13: 0x100e93b3c - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h602b6f29451c74c7
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/core/src/ops/function.rs:287
                 - std::panicking::try::do_call::h8ad76c1527a3892b
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/panicking.rs:483
                 - std::panicking::try::hbfc990f7ac38d34c
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/panicking.rs:447
                 - std::panic::catch_unwind::h936bb5789e0b4241
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/panic.rs:140
                 - std::rt::lang_start_internal::{{closure}}::h896fa40a3ab062d0
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/rt.rs:148
                 - std::panicking::try::do_call::h21fb8583a42bdaac
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/panicking.rs:483
                 - std::panicking::try::h90121103ee57470a
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/panicking.rs:447
                 - std::panic::catch_unwind::hfd5c7b5d06b8f149
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/panic.rs:140
                 - std::rt::lang_start_internal::h9f0566e553deb11e
                at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/rt.rs:148
  14: 0x100cdd694 - _main"""

Interesting.
Would you be able to narrow down the java script to what syntax it is failing on?

It's unclear to me how to figure out what line of code it's failing on.  I tried making a new git repo with a new JS file in it with the following contents to try to find a minimal failing test case.
test('arg1');

I committed it and ran git dive foo.js and I got the same error.  It works for other languages, so maybe it's something with JavaScript.

Thanks!
I've reproduced it locally but can't reproduce it with bat which most of our syntax highlighting is taken from.  Going to need to dig into the differences.

v0.1.5 is out with the fix


accounts.register returning isRegistered: true when "finalizeRegistration": false in Android alone

Hi there,
I hope someone can please help with this as I do not seem able to figure out on my own.
Here is our gigyaSdkConfiguration.json:
{   "apiKey": "secret",   "apiDomain": "eu1.gigya.com",   "accountCacheTime": 60,   "account": {     "cacheTime": 1,     "include": [       "data",       "profile",       "emails"     ],     "extraProfileFields": [       "locale",       "phones"     ]   },   "sessionVerificationInterval": 0 }
We are moving from a single step registration to a three steps one.
What we currently have is this:
await _gigya.register(options.email, options.password, params: { "profile": ..., "data": ...data, "preferences": ...preferences, "subscriptions": ...subscriptions, "finalizeRegistration": true, });
moving on to:
final Map<String, dynamic>? initRegistrationResponse = await _gigya.send("accounts.initRegistration",{}); await _gigya.register(options.email, options.password, params: { "profile": ..., "data": ...data, "preferences": ...preferences, "subscriptions": ...subscriptions, "finalizeRegistration": false, "regToken": initRegistrationResponse?['regToken'].toString(), });
which works correctly on iOs, as it returns something like:
{ "errorCode": 206001,  "errorMessage": "Account Pending Registration", "statusCode": 206, "statusReason": "Partial Content"}
For some reason the same flow in Android will return a success such as:
{ errorCode: 0, apiVersion: 2, statusCode: 200, statusReason: OK, isActive: true, isRegistered: true, isVerified: false }
the expected response should be the same as the one from iOs, so as to be able to then call accounts.finalizeRegistration and effectively change the value of "isRegistered" to true.
Any idea why this is happening?
The sdk is correctly configured, I am currently using ^0.2.1, but have also tested several previous ones, and we have been using a dozen other endpoints for months without a single issue.

Issue resolved in v1.0.2 update.


Error installing POSHRSJob

Getting the following error when trying to issue the import-module command for POSHRSJob command:
VERBOSE: Loading module from path 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\PoshRSJob\PoshRSJob.psd1'.
VERBOSE: Loading module from path 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\PoshRSJob\PoshRSJob.psm1'.
Add-Type : (0) : Metadata file 'System.Core.dll' could not be found
(1) :     using System;
At C:\Windows\system32\WindowsPowerShell\v1.0\Modules\PoshRSJob\PoshRSJob.psm1:4 char:1

Add-Type -TypeDefinition @"

  + CategoryInfo          : InvalidData: (error CS0006: M...ld not be found:CompilerError) [Add-Type], Exception
  + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

Add-Type : Cannot add type. There were compilation errors.
At C:\Windows\system32\WindowsPowerShell\v1.0\Modules\PoshRSJob\PoshRSJob.psm1:4 char:1

Add-Type -TypeDefinition @"

  + CategoryInfo          : InvalidData: (:) [Add-Type], InvalidOperationException
  + FullyQualifiedErrorId : COMPILER_ERRORS,Microsoft.PowerShell.Commands.AddTypeCommand

VERBOSE: Importing function 'Get-RSJob'.
VERBOSE: Importing function 'Receive-RSJob'.
VERBOSE: Importing function 'Remove-RSJob'.
VERBOSE: Importing function 'Start-RSJob'.
VERBOSE: Importing function 'Stop-RSJob'.
VERBOSE: Importing function 'Wait-RSJob'.
VERBOSE: Importing alias 'gsj'.
VERBOSE: Importing alias 'rmsj'.
VERBOSE: Importing alias 'rsj'.
VERBOSE: Importing alias 'spsj'.
VERBOSE: Importing alias 'ssj'.
VERBOSE: Importing alias 'wsj'.
Any idea how I can work around this issue?
Thanks
Brad

What version of PowerShell and OS are you running this on? This error:
Add-Type : (0) : Metadata file 'System.Core.dll' could not be found seems odd to me but am not quite sure why it is throwing that error.

$PSVersionTable.PSVersion

Major  Minor  Build  Revision

3      0      -1     -1

PS C:\Users\brad.baker> [Environment]::Is64BitProcess
True

The only thing I can think of that we have non-standard is that we have a powershell.exe.config with the following:
<?xml version="1.0"?>
<configuration>
    <startup useLegacyV2RuntimeActivationPolicy="true">
        <supportedRuntime version="v4.0.30319"/>
        <supportedRuntime version="v2.0.50727"/>
    </startup>
</configuration>

I think we needed to add this to solve some other issue on our system - although I don't specifically remember what the problem was.

That really shouldn't make a difference as this was tested on a Windows 2003 system supporting PowerShell V2 running .Net 2.0 and adding support for .Net 4.0 shouldn't have affected it. But any chance that you can test this on a different system?

It seems to work ok on another server i have so something in particular about this server - although that doesn't necessarily help me resolve the issue. Any other ideas?

Are you having any issues with other 3rd party modules on that system? Any chance that you are running in a constrained language mode via a System profile? This is something that I have not seen before and am not quite sure what could be causing the issue.

Are you having any issues with other 3rd party modules on that system?
I'm not running any other third party modules but other scripts are working just fine.

Any chance that you are running in a constrained language mode via a System profile?
Nope:

PS C:\Users\brad.baker> $Host.Runspace.LanguageMode
FullLanguage

I'm kind of at a loss on what to look at next besides reverting powershell.exe.config back its default configuration and testing to see what happens...or adding the config to another system for testing.

I've uninstalled and re-installed Microsoft.net 3.5 - that seems to have fixed things up. Sorry for bothering you!

No worries about it! Glad that you were able to get it resolved.


Breaking changes

use CSS custom properties in preference to inline styles
use sass:math for division

Picked up during testing of css custom property of back to top:
The JavaScript assumes a footer element will always be provided or available and causes a null exception if it isnt.


geekChat: a chat that automatically turns everything geek.

Maybe we could make a geek chat as a subdomain of geeksay.xyz. It would look like IRC, but translate everything to geeksay.
Photo: This is just a fork of jennChat on glitch.

chat.geeksay.xyz does seem an interesting idea to try! 🔥

@partlybakedideas
idea is cool... In the screenshot, it was mentioned as folks on chat.. is it intended to be a part of it?
how is that possible? Are we going to use WebSockets or anything else like webrtc?


Add best-effort support for COLRv1

Ready to merge?

Ready to merge?

Yep.

I plan to make a resvg release soon. Do you have any more changes planned?

Well, ideally it would've been nice to figure out the font selection problem (#754) before the next release, but it it looks like it will still take some time and I think @laurmaedje is currently busy with other stuff right now, so I guess there is nothing holding us off from making a new release right now.

Ok, I will take a look at #754 myself this week and if it would not work will release resvg as is.


Fix issue with tox-gh-actions

py310-pillow-latest: tox-gh-actions couldn't understand the parallel
option. ignoring the given option: 0

I've been wondering what was causing that error myself. Thanks!


[scripts] Clean up unnecessary steps in coverage_report.sh

Motivation
There should never be a need to remove gcda and gcno files
from the target directory:

The script first runs "cargo clean", which removes the old target
directory.
Running "cargo build" will not create any data (gcda) files.
Any gcno files created during the build should be kept, except...
There is no need to first run "cargo build" since "cargo test" will
also build the files to be tested.

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I've run the coverage_report.sh script locally and manually verified that the results look sane.

@bors-libra r=darioncassel

:pushpin: Commit a736902 has been approved by darioncassel

:hourglass: Testing commit a7369026adc37f126b449b543df509a2a1477cff with merge 6ea1d4f15e8938bd096d0a95704d56bd0b5f8bfd...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: darioncassel
Pushing 6ea1d4f15e8938bd096d0a95704d56bd0b5f8bfd to master...


Add DataPreprocessor API

Issue Link :link:
This is a generalized solution to #2683.
Goals :soccer:
This PR adds the DataPreprocessor API to all response serializers, to allow easy access to raw Data before serialization, to do things like stripping XSSI strings.
Implementation Details :construction:
DataPreprocessor is just a closure that each serializer can have set. By default it just passes Data through, so it should have minimal impact for anyone not using the API. It also supports throwing, so errors can be returned as well.
Testing Details :mag:
Additional tests were added to the various DataResponseSerializer cases, as all serialization flows through those methods.

Design question: is the closure good enough, or should this be full abstracted into a protocol?

@cnoon I've refactored DataPreprocessor into a protocol, take a look! I think it's okay, but would be far better but for a Swift limitation around being able to use static members of protocols.


HTTP_HEADERS DEAFAULT_HTTP_HEADERS and OVERRIDE_HTTP_HEADERS seem not to have any effect

A clear and concise description of what the bug is.
How to reproduce the bug
We have such config in superset_config.py
HTTP_HEADERS = {
    "X-Frame-Options": "ALLOW-FROM *",
    "x-frame-options": "ALLOW-FROM *",
    "Content-Security-Policy": "frame-ancestors http://* https://*",
    "content-security-policy": "frame-ancestors http://* https://*"
}
DEFAULT_HTTP_HEADERS = {
    "X-Frame-Options": "ALLOW-FROM *",
    "x-frame-options": "ALLOW-FROM *",
    "Content-Security-Policy": "frame-ancestors http://* https://*",
    "content-security-policy": "frame-ancestors http://* https://*"
}
OVERRIDE_HTTP_HEADERS = {
    "X-Frame-Options": "ALLOW-FROM *",
    "x-frame-options": "ALLOW-FROM *",
    "Content-Security-Policy": "frame-ancestors http://* https://*",
    "content-security-policy": "frame-ancestors http://* https://*"
}

but once a dashboard is embedded in an iframe, the client keeps getting x-frame-options: SOMEORIGIN
Expected results
I was expecting to override x-frame-options header
Actual results
The client keeps receiving x-frame-options: SOMEORIGIN
what is the right way to remove this limitation?

Same problem here

Same Problem with 3.0rc2

@giacomochiarella, the issue might be due to Enable CSP by default. I was facing the same issue but after I set
TALISMAN_ENABLED = False
in superset_config.py I was able to get the embed working.

I did the same and it worked. But I've read no where how HTTP headers configuration and Talisman work together

I wonder if there is a proxy sitting in front of your superset? If there is one, you need to make sure your proxy does not have anything special in X-Frame-Options: "". This is just a syntax to remove X-Frame-Options for Traefik, which is the proxy I'm using.
Wrote a guide on it, hopefully, it helps someone 😄 Choose your preferred media 😝
https://huamichaelchen.substack.com/p/end-to-end-example-of-setting-up
https://medium.com/@huamichaelchen/end-to-end-example-of-setting-up-superset-embedded-dashboard-f72fc985559

Same result with this config :
TALISMAN_ENABLED = False
SESSION_COOKIE_SAMESITE = None
ENABLE_PROXY_FIX = True
PUBLIC_ROLE_LIKE_GAMMA = True
FEATURE_FLAGS = {
"EMBEDDED_SUPERSET": True
}
SQLALCHEMY_DATABASE_URI = 'postgresql://postgres:postgres@db:5432/superset'
HTTP_HEADERS = {'X-Frame-Options': 'ALLOWALL'}
CORS_OPTIONS = {
'supports_credentials': True,
'allow_headers': [''],
'resources':[''],
'origins': ['*']
}
When trying to embed the dashboard, the response header is always with x-frame-options=SAMEORIGIN, meaning the HTTP server does not allow embedding frames.
My superset is deployed at localhost (no proxy).
Perhaps a guniicorn setting to change ?

Same here with google cloud load balancer and k8s. balancer with https and internal traffic with http.
reference post: https://medium.com/@huamichaelchen/end-to-end-example-of-setting-up-superset-embedded-dashboard-f72fc985559
I tried with TALISMAN_ENABLED = False and got same error. 403 and refused to display in a frame because it set 'X-Frame-Options' to 'sameorigin'. User has proper permissions.
my helm values override:
configOverrides:
  my_override: |
    SESSION_COOKIE_SAMESITE = 'Lax'
    SESSION_COOKIE_SECURE = True
    ENABLE_PROXY_FIX = True
    CORS_OPTIONS = {
      'supports_credentials': True,
      'allow_headers': ['*'],
      'resources': ['*'],
      'origins': ['*']
    }
    FEATURE_FLAGS = {
      "DASHBOARD_RBAC": True,
      "EMBEDDABLE_CHARTS": True,
      "EMBEDDED_SUPERSET": True,
      "ENABLE_TEMPLATE_PROCESSING": True,
      "LISTVIEWS_DEFAULT_CARD_VIEW": True
    }
    HTTP_HEADERS={"X-Frame-Options":"", "Content-Security-Policy": "frame-ancestors *"}
    from flask_appbuilder.security.manager import AUTH_DB
    AUTH_TYPE = AUTH_DB
    AUTH_ROLE_ADMIN = 'Admin'
    AUTH_USER_REGISTRATION = False

@giacomochiarella, the issue might be due to Enable CSP by default. I was facing the same issue but after I set TALISMAN_ENABLED = False  in superset_config.py I was able to get the embed working.

Thanks, it worked for me. Superset version apache/superset:3.0.2rc1 and embedded in Angular

Setting TALISMAN_ENABLED = False doesnt work with 3.1.1 and its not behind any of the proxy server. Running the non dev using the docker compose.
TALISMAN_ENABLED = False

Thanks @goldman7911 that solution also worked for me using Helm Chart.

Feeling a bit lost here, but is the situation effectively solved, then? Is there anything that ought to be added to the docs to help others in the future?

@giacomochiarella, the issue might be due to Enable CSP by default. I was facing the same issue but after I set TALISMAN_ENABLED = False  in superset_config.py I was able to get the embed working.

Thanks, it worked for me but now I have another error: POST http://localhost:8088/api/v1/chart/data 403 (FORBIDDEN). I tried to find any solution but no luck still. I hope someone know something about it

I'm using Caddy as my reverse proxy, and have tried all of these options without success.
Additionally, I've tried configuring CORS with CORS_OPTIONS: dict[Any, Any] = {'origins': ['*']} without luck.
When I inspect the frame, I see that the server is listed as gunicorn and the X-Frame-Options are set to SAMEORIGIN. This holds true no matter what options I change.

I've researched and haven't seen a way to configure gunicorn that coincides with what superset offers (I never found a config). I've tried playing with the flask settings that I saw on another forum, but still no luck.
Any thoughts?


Use plain Impulse rather than a full Read for 0, 1 element Creates.

Most of the complexity here is in preserving the read for update compatibility.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Thanks, just curious was there an issue reading 0, 1 elements or what is the advantage of switching to Impulse?

We hit some bugs with the overhead of Read and splitting too much when there is really no point in splitting at all.

better get tests green and VR tests

R: @kennknowles

Please run spotless and push it up.

Wasn't this demonstrated to have an improvement? I honestly thought this had been merged.

There was a test failure I needed to investigate, and it never got to the
top of the "urgent" pile. I plan on wrapping this up now that I'm back from
vacation.
On Mon, Jul 10, 2023 at 8:08 AM Kenn Knowles @.***>
wrote:

Wasn't this demonstrated to have an improvement? I honestly thought this
had been merged.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/26332#issuecomment-1629161050, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADWVAOYQER2XR5I2PPJ5S3XPQLF3ANCNFSM6AAAAAAXDCAJGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Run Java PreCommit

Run Java PreCommit


Lookahead optimizer

System information

TensorFlow version (you are using): 1.14
Are you willing to contribute it (Yes/No):Yes

Describe the feature and the current behavior/state.
https://arxiv.org/abs/1907.08610
This is not a conventional optimizer as in tensorflow API. It observes through k iterations of optimizers(SGD, Adam), and linear interpolates entire weight into direction where fast weight after k iteration has reached.
I have seen an implementation of this defining two ops for slow weight update and fast weight update. However I see some potential performance benefit if it was defined on backend.
Will this change the current api? How?
I believe not.
Who will benefit with this feature?
Tasks with heavy training load will benefit from faster learning rate.
Any Other info.

Yep sounds good. @jinmel do you want to contribute to it?

@tanzhenyu Sure

preflight:
https://github.com/jinmel/lookahead-tensorflow

@jinmel thanks for your implementation, but it seems to be missing the sparse gradients update. Is this a limitation of this specific optimizer?

@nova77 I still need to implement this feature.

This optimizer might be a better fit in TensorFlow Addons, then graduated to TensorFlow Core. @jinmel, do you have an update on progress for the sparse gradients update?

Hi all, addons holds a lookahead optimizer implementation.
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/optimizers/lookahead.py

Closing this issue, as there is an implementation available in TensorFlow Addons. Thank you for the feature request!


Problem with model update hook.

I got in properties and all fields that have default values in migrations and have not been changed since model was created.
"properties": {
    "a": "New",
    "b": "Default", // $table->string('b')->default('Default');
    "c": "Default", // $table->string('c')->default('Default');
    "d": "Default", // $table->string('d')->default('Default');
    "updated_at": "2019-05-15 03:26:10"
},
"old": {
    "a": "Old",
    "b": null, // ???
    "c": null, // ???
    "d": null, // ???
    "updated_at": "2019-05-15 03:25:53"
}

And like so every update.

We run on updated so the model contains the new values (DB default). Compared to the old attributes they have changed.
But the update after this shouldn't contain these values because they are already default!?

Compared to the old attributes they have not changed. I can change "a" attribute (any attrbute without default value) any times, and every time I will get
"properties": {
    "a": "New",
    "b": "Default", // $table->string('b')->default('Default');
    "c": "Default", // $table->string('c')->default('Default');
    "d": "Default", // $table->string('d')->default('Default');
    "updated_at": "2019-05-15 03:26:10"
},
"old": {
    "a": "Old",
    "b": null, // ???
    "c": null, // ???
    "d": null, // ???
    "updated_at": "2019-05-15 03:25:53"
}

even if protected static $logOnlyDirty = true;
I will get them while I will not change them.
After $model->update(["b" => "Not Default", "c" => "Not Default", "d" => "Not Default"]) I get
"properties": {
    "a": "New",
    "b": Not "Default",
    "c": "Not Default",
    "d": "Not Default",
    "updated_at": "2019-05-15 03:26:10"
},
"old": {
    "a": "Old",
    "b": null, // ???
    "c": null, // ???
    "d": null, // ???
    "updated_at": "2019-05-15 03:25:53"
}

Then it work as expected.
I'm using pgsql, if it important

Could you provide a full code example (model, create & update call) or better a failing unittest?
With the logged changes I have to say that it's right what the package does. null and "default" are different so they have changed.

Example migration:
public function up()
{
    Schema::create('users', function (Blueprint $table) {
        $table->increments('user_id');
        $table->string('name');
        $table->string('email')->unique();
        $table->string('login')->nullable();
        $table->string('currency')->default('RUB');
        $table->text('description')->nullable();
        $table->string('password');
        $table->rememberToken();
        $table->timestamps();
        $table->softDeletes();
    });
}

Example model:
<?php
namespace App\Models;

use \Hash;
use Illuminate\Database\Eloquent\SoftDeletes;
use Illuminate\Notifications\Notifiable;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Spatie\Activitylog\Traits\CausesActivity;
use Spatie\Activitylog\Traits\LogsActivity;
use Tymon\JWTAuth\Contracts\JWTSubject;

/** @mixin \Barryvdh\LaravelIdeHelper\Eloquent */

class User extends Authenticatable implements JWTSubject
{
    use Notifiable, SoftDeletes, LogsActivity, CausesActivity;

    /**
     * @var integer ID key
     */
    public $primaryKey = 'user_id';

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name',
        'email',
        'login',
        'currency',
        'description',
        'password'
    ];

    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password',
        'remember_token'
    ];

    protected static $logAttributes = ['*'];

    protected static $logAttributesToIgnore = [
        'password',
        'remember_token',
        'updated_at'
    ];

    protected static $logOnlyDirty = true;

    /**
     * Automatically creates hash for the user password.
     *
     * @param  string  $value
     * @return void
     */
    public function setPasswordAttribute($value)
    {
        $this->attributes['password'] = Hash::make($value);
    }

    /**
     * Get the identifier that will be stored in the subject claim of the JWT.
     *
     * @return mixed
     */
    public function getJWTIdentifier()
    {
        return $this->getKey();
    }

    /**
     * Return a key value array, containing any custom claims to be added to the JWT.
     *
     * @return array
     */
    public function getJWTCustomClaims()
    {
        return [];
    }
}

Unexpected behavior:
 $ php artisan tinker
Psy Shell v0.9.9 (PHP 7.3.4 — cli) by Justin Hileman
>>> $user = User::create([
            'name' => 'Test',
            'email' =><EMAIL_ADDRESS>            'password' => '123456'
        ])
[!] Aliasing 'User' to 'App\Models\User' for this Tinker session.
=> App\Models\User {#3106
     name: "Test",
     email<EMAIL_ADDRESS>     updated_at: "2019-05-15 11:47:04",
     created_at: "2019-05-15 11:47:04",
     user_id: 1,
   }
>>> $user->update(["description" => "New description"])
=> true
>>> $user->update(["description" => "Another new description"])
=> true
>>> Spatie\Activitylog\Models\Activity::latest()->limit(3)->get()->reverse()->all()
=> [
     2 => Spatie\Activitylog\Models\Activity {#3101
       id: 1,
       log_name: "default",
       description: "created",
       subject_id: 1,
       subject_type: "App\Models\User",
       causer_id: null,
       causer_type: null,
       properties: "{"attributes":{"user_id":1,"name":"Test","email":"test@email.com","login":null,"currency":"RUB","description":null,"created_at":"2019-05-15 11:47:04","deleted_at":null}}",
       created_at: "2019-05-15 11:47:04",
       updated_at: "2019-05-15 11:47:04",
     },
     1 => Spatie\Activitylog\Models\Activity {#3100
       id: 2,
       log_name: "default",
       description: "updated",
       subject_id: 1,
       subject_type: "App\Models\User",
       causer_id: null,
       causer_type: null,
       properties: "{"attributes":{"currency":"RUB","description":"New description"},"old":{"currency":null,"description":null}}",
       created_at: "2019-05-15 11:47:24",
       updated_at: "2019-05-15 11:47:24",
     },
     0 => Spatie\Activitylog\Models\Activity {#3094
       id: 3,
       log_name: "default",
       description: "updated",
       subject_id: 1,
       subject_type: "App\Models\User",
       causer_id: null,
       causer_type: null,
       properties: "{"attributes":{"currency":"RUB","description":"Another new description"},"old":{"currency":null,"description":"New description"}}",
       created_at: "2019-05-15 11:47:28",
       updated_at: "2019-05-15 11:47:28",
     },
   ]

When model was created "currency":"RUB", but after every update in old "currency":null. I think it is unexpected behavior.

Ok, the problem is related to eloquent and not this package.
I've created a failing unittest in #530 (first commit) and fixed it in the last commit.
The problem is that eloquent doesn't refresh the model after a save. So the currency attributes stays null after creation. That's why the column occurs all the time in the changes.

Eloquent doesn't refresh the model fields. So it was constantly. I do not think that фfter so much time this behavior will be changed. You can use somesithg like $model->getChanges() insted get diff of model fields after and before save in this packadge and it will work right.

I've found something in our package that could cause it - I will try if it's the reason.
We fresh the model before we clone it.

@freekmurze the only way I found is to call refresh() instead of fresh() in \Spatie\Activitylog\Traits\DetectsChanges::attributeValuesToBeLogged().
But this would change the model used by the developer in it's app context (what is needed to have the DB default in the attributes after a save/create and know about it in a following save/update call.
Which is the only case where it doesn't behave like expected.
For me this is a super rare case - so I could live with the solution to expect the developer to refresh his model if it's saved and the database could change the values (DB triggers would be also such a case).
In opposit I think that refreshing the general model instance could lead to much more trouble.

Usually when i have default value in migration, I also add the default $attributes in the model, so the model has the default value even it is not saved..
// in Model Class

protected $attributes = [
    'currency' => 'RUB',
];

After getting into this myself and googling the 💩 out of Laracast the common solution seems to add the default values as $attributes property - like suggested by @therour .
As there's no way for us to detect the default values or that there are some at all I will close this with several provided solutions.

It appears that default values, including null, have to be added as $attributes


fix(grid-list): fullscreen reset max-height

:tada: This PR is included in version 7.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Issue 126 turn key training demo

This PR implements a turn-key training demo-script using hydra config management. The goal is to reduce the entry barrier for the developer. Hydra enables config composition and convenient overwrite from command line which are demonstrated below. It is a widely used config management tool in ML community. The proposed workflow for the developer looks as below.
The developer

clones the repo
creates the environment
downloads the input.wav and output.wav from provided links. (This step can be automated as well)
run demo by calling below from the repo root

python  nam/train/demo.py --config-path=bin/train/inputs/data --config-name=demo.yaml common.x_path=path/to/input.wav common.y_path=path/to/output.wav common.train_path=path/to/training_output"

Note that, hydra allows conveniently overwriting config parameters.

Hi! Thanks for the PR.
What's the difference between this and using bin/train/main.py?

demo.yaml seems to copy bin/train/inputs/data/single_pair.json
This doesn't seem to expose for the demo how the model is configured (cf e.g. bin/train/inputs/models/wavenet.json or other model configs in there) nor the learning algorithm.

Do you think that we might achieve effectively the same result as this PR by sprucing up the README? (I also wouldn't mind not picking up another dependency with Hydra. What's the sell there?)
I think that, at a high level, I'm not convinced that this repo should be going all-in on the wrappers in nam.train, though that's obviously what easy_colab.ipynb and the GUI trainer do...basically if a developer wants to get into this, having something that doesn't conflate the UX with the moving parts underneath may be more helpful?
But obviously I have a PoV bias, so I'm interested to hear if you've got any feedback on these thoughts.

@sdatkinson You are right this PR achieves the same functionality as bin/train/main.py. I have missed that. There are different entry points to the training, from colab, from command-line ...etc. I was pursuing the colab's call path. In that sense, yes, we can achieve similar affect if we improve the README, plus improve config management (more details below). I would also suggest populating all training functionality into single python file and calling relevant functions from the same colab, command line or gui. The idea is reducing the call pathways as much as possible to improve maintainability.
About config management and hydra. In this example I only illustrate the command-line override convenience, where one can override a config parameter without need to change the config file. In this particular example, user can run the training without touching the config file. More powerful part of Hydra is composing configs. It allows you define default behavior and change details as needed. For example you can define all training parameters like optimizer, learning rate, batch size ...etc. in a config file but may prefer to change only the batch size for a particular model. Using hydra you can create a config file and override only the parts of the default config, the batch size in this case. It allows to switch between configs conveniently as well. The idea here is again reducing config duplication, or sources of truth as much as possible to improve maintainability. See here for a composition example. Hydra works with yaml files that is why I converted single_pair.json to demo.yaml.
I hope this clarifies some of the questions above.

Closing this in the light of our discussion and follow up PR.


my tradecards arent going to be tradeable

since you guys know a lot of steam dropping system, can you helpme with this issue?
i've bought some games and dropped all the cards, since my account was new, i had to wait 15 days until the time from the steam autenticator was gone, but when it finished, all the cards turned to be untradeable, why did this happened?

First of all - this is not a helpdesk. Issues are dedicated only to bugs and suggestions about ASF.
And about your question - you probably have limited account, you need to spend at least 5$ at steam store to remove limitations.

GitHub is not a place to ask for ASF support.
Check http://steamcommunity.com/groups/ascfarm/discussions/1/405693392916924930/ and especially https://steamcommunity.com/linkfilter/?url=http://www.steamgifts.com/go/comment/otxfhRH for more help regarding your issue.


Go Python 3!

Would be nice to work with sensu_plugin on python 3.

The current master version works with Python3, but the PyPI version is outdated.

Can you tag release 0.2.0 in github? Since the version on PYPI is outdated, I forked this repo just so I can tag it. That way I know what version I'm getting when I pip install from github.

@rchacon1 sorry for the long silence the community is starting to take ownership and once we sort out some things we will follow the same cadence as it's ruby counterpart and release every functional change. See #15 #14 for more details.

0.2.0 has been released. I am closing this out.


Hotfix/with without fixes

Jira
https://app.asana.com/0/1132619174015272/1140685646931269/f
https://app.asana.com/0/1132619174015272/1142071935279842/f
https://app.asana.com/0/1132619174015272/1142061852792839/f
Summary
Fix self-drawing circle rotation in edge; fix mobile padding overlap; add IntersectionObserver; code cleanup
Details
This branch contains a number of fixes, many of which I implemented  as I discovered them when working to fix IE 11.

Add InteresectionObserver to animation on when  initially scrolled into view
Fix mobile padding overlap
Force full bleed as per stakeholder discussions
Circle CSS cleanup and refactor
Fix self-drawing circle erratic rotation in Edge
Short-circuit if no toggle found to fix errors on non-with/without PL pages
Fixing fallout from forcing full bleed, correcting general spacing issues especially on tablet
Some fixes for the lowest blocks to prevent overflowing the container on tablet

This does not include IE 11 fixes, but Edge is solid, minus the selection shown around the toggler, which is already tracked.
How to test
Examine /pattern-lab/?p=experiments-with-without-intersection-test and /pattern-lab/?p=viewall-experiments-with-without

@glassdimly I'm pulling this into Drupal and testing it there. Off the bat, It looks like the "don't tread on me" is still getting covered below 1250px:
https://hotfix-with-without-fixes.boltdesignsystem.com/pattern-lab/?p=experiments-with-without

Alright, I believe I've addressed all of these issues, or we've agreed they're not necessary for this release:

Self drawing circle now rotates in the proper direction and resets and stops its spin before re-animation

We talked about the full-bleed content on the call: stakeholders requested full bleed early and we planned for this. If for some reason this changes, I have moved the full-bleed behavior into its own class, so it can be easily removed. I cannot guarantee there will be no fallout from this, but I added a couple fixes so that this should work fine.

1239/1251: added padding right to with pega results block

1231 is now fixed

1467 overlap is now fixed.

5 and 6. We agreed that supporting scaling content up and down without page refresh is not launch critical

I have not been able to replicate this between-breakpoints problem on Chrome/FF. I tried starting big, moving down to 1230. I tried starting small, moving up to 1230. I tried refreshing at 1230. Perhaps this is fixed? Can you check once build finishes on this branch?

Misc.: Yeah, I had trouble with adding that icon to icons, the size wasn't supported. I was actively avoiding bolt components as per my instructions to avoid dependencies on bolt. I will do it differently next time!
Other:

Fixed excessive black space at the bottom of tablet container problem
Fixed height on mobile/tablet after accordion expand
Edge fixes
Hide with/without entirely on IE 11 as per @charginghawk's discussion with stakeholders

@sghoweri @glassdimly This hotfix was checked and approved by stakeholders.


Optimize speed and stabilize the batch graph refresh memory usage

Optimize speed and stabilize the batch graph refresh memory usage

@miq-bot assign @agrare
@miq-bot add_label enhancement, performance


Refactor to RTK

There are a number of contexts and providers that use React's native useReducer. Due to the proliferation of these contexts and the need to provide an opinionated way of generating new contexts, @jarosenb has recommended a refactor to use Redux-Toolkit. The scope of this refactor includes:

A Root State and Provider for tapis-app, which encompasses Notifications (which should be renamed Toasts since it is application appropriate and should be disaggregated from the Notifications API) and FilesListing selections
Refactor TapisProvider to use RTK, and build in slices for the Job Launcher. This will replace the withFragment hook and provider generator and allow for fine grained logic when building Jobs such as the ability to add optional inputs directly from app definitions into the Job Launcher stsate

We identified several issues related to our application/component modularization structure which prevents use of reduxjs-toolkit:

tapis-ui and tapis-app would require a single global state provider, or better modularized design between components to properly use redux. currently, there are scoping issues with the current setup. namely, each tapis-ui component would require its own localized redux store and cannot share a tapis-ui module wide store. this removes some of the advantages that would have been gained from a move to redux
object bindings generated by tapis-typescript use the Date object extensively, which cannot be serialized. this makes these objects incompatible with the default serialization strategy of redux and will cause bugs

At this time we are closing this issue and opening a new one for a smaller scoped refactor that does not include redux.


Review #176: support for std::wstring, soci::binary and unified ODBC product type gathering

The original PR #176 has not been merged, but automatically closed as result of deleting hotfix/3.2.2 branch after releasing SOCI 3.2.2.
The PR is worth to review and may still be merged into future releases, so let's keep this issue open as reminder.

I'm gonna clear SOCI 4.0.0 milestone and push this one towards future


Fix AbstractHydrator

I think someone overlooked hydrateAll() method and edited only iterate(). https://github.com/doctrine/doctrine2/pull/1515
As a result an event listener is not added which can cause problems if EventManager implementation does not check for existence of a listener upon its removal.
In my case it causes E_NOTICE (undefined index) because of https://github.com/Kdyby/Events/blob/master/src/Events/EventManager.php#L198
If my PR should be altered (commit message, etc.) please let me know.

@echo511 this still requires a test case

@Ocramius OK, I'll do it as a fix of DDC-3146 and its test case? Where should it go? On top of 2.5.8?

@echo511 all patches should go against master (this one included) -  backporting is up to us

@echo511 I manually merged and backported to 2.5, thanks!
master: doctrine/doctrine2@57a9509dec83fec705dde1792510b6420dfbcb02
2.5: doctrine/doctrine2@1554af0c07db130b8fd03d40c4a2a67ac1bc3110


fixes #1910: loop index should be mutable within a loop iteration and immutable between loop iterations

Why ++i instead of i++?

Simpler compilation. That way we can just prepend indexVariableName =  to it and have it work. I prefer the prefix {in,de}crement to postfix {in,de}crement anyway.

If you don't mind, let's stick with the postfix -- both in the generated code, and in the compiler itself, when both are equivalent. It's the more familiar/usual of the two, for most readers. ++i usually signals that you need the incremented value for something special.

@jashkenas: We do need the incremented value in some cases, when the index variable is named (like for value, indexName in array). Do you want me to have it the other way when we don't use the value?

Yes please. I think that'd be just a little bit clearer.

Alright, I did it, but the code is much uglier now.

Thanks -- I appreciate the appeasement. Lovely work.

By the way, that truly is the hairiest method in all of CS. Especially since there's for loops in the lexer/rewriter. Ugh, it wasn't easy.

Personally I found a bit odd to add an extra variable to all the loops everywhere in the CoffeScript world just to fight with the rare case when somebody want to have i+=2 somewhere in the loop body.


PostgreSQL support upsert

Dialect: PostgreSQL
failing sql:
INSERT INTO feeds (id,  title,   author,  image,  description,  pub_date,  webpage_url,  lang,  display_url)
VALUES            (:id, :title,  :author, :image, :description, :pub_date, :webpage_url, :lang, :display_url)
ON CONFLICT (id) DO UPDATE SET
  title       = :title,
  author      = :author,
  image       = :image,
  description = :description,
  pub_date    = :pub_date
RETURNING id;

error:
',' expected, got 'ON'

Similarly:
CREATE TABLE SchemaVersion (
    id INT PRIMARY KEY NOT NULL,
    version INT NOT NULL
);
setVersion:
INSERT INTO SchemaVersion(id, version) VALUES (0, ?)
ON CONFLICT (id) DO UPDATE SET version = excluded.version;

gets me:
line 8:0 - ',' or RETURNING expected, got 'ON'
7    INSERT INTO SchemaVersion(id, version) VALUES (0, 'test')
8    ON CONFLICT (id) DO UPDATE SET version = excluded.version
      ^^


Change to lamda syntax for async methods

This PR switches the master branch to java 8 and introduces a few enhancements that come with that.

This looks good to me, great simplification! I am further fine with requiring Java 8, so this can be merged from my perspective.