Add knip to pre-push hook

We have added knip to the CI in #225
We should also add it to our pre-push hooks

@cguedes @danvk I'm opening this issue because I just had a failing CI job on a PR because of an unused file. This is really nice but I think it would make sense to run knip along our other pre-push hooks to catch the error before pushing the code.
I don't think the command takes too much time, so it should be fine to run it on pre-push. Let me know if you think of any reason why we shouldn't

@sehyod sounds good to me!


Narrows type of url on DatabaseCredentials to fix error in block registration

Summary

Fixes error in registration caused by the URL type from sqlalchemy. URL does not inherit from pydantic's BaseModel and we can't generate a schema for it. Narrowing the type to only AnyUrl fixes the issue.
Relevant Issue(s)

Closes #28
Checklist

[x] Summarized PR's changes in CHANGELOG.md

Confirmed that this PR fixes my issues.
The Block now properly shows up in the UI, and I am able to build deployment configurations again.

and


fake timers do not mock AbortSignal.timeout or timers/promises

Describe the bug
mock timers do not mock node's timers/promises or AbortSignal.timeout
There is an open issue in sinon fake-timers to implement these.
https://github.com/sinonjs/fake-timers/issues/418
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-5rmugo?file=test/basic.test.ts
describe('with fake timers', () => {
  beforeAll(() => {
    vi.useFakeTimers();
  });

  test('signal should abort after timeout', () => {
    const signal = AbortSignal.timeout(100);
    expect(signal.aborted).toBe(false);

    vi.advanceTimersByTime(200);

    // This will fail, aborted is still false.
    expect(signal.aborted).toBe(true);
  });
});

System Info
stackblitz

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Related: https://github.com/sinonjs/fake-timers/issues/418

Could mocking module "timers/promises" and "node:timers/promises" builtin solve the problem? Or waiting shinonJS' decision?

I think we're waiting on sinon. In the mean time I've been mocking timers/promises with an implementation that delegates to global setTimeout so it's correctly mocked by useFakeTimers. I'm not sure how accurate my mock is so I won't bother sharing it here.

I am closing the issue here since Vitest cannot do anything to resolve this unless happy-dom implements the correct API.


fix the wrong type error of == fuction

@dreamnice, I don't think the == Operator implemention is correct, see my review code comments.
I've got a proposal for a test file I suggest it should be placed in a in directory "test/chart/cartesina/axis/spec". Below is a start I think it would be good if we added tests for the other classed in the file:
// Copyright 2020 the Charts project authors. Please see the AUTHORS file
// for details.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

import 'package:charts_common_cf/src/chart/cartesian/axis/spec/ordinal_axis_spec.dart';

import 'package:test/test.dart';

void main() {

  FixedPixelSpaceOrdinalScaleSpec fixedPixelSpaceOrdinalScaleSpec1;
  FixedPixelSpaceOrdinalScaleSpec fixedPixelSpaceOrdinalScaleSpec2;
  FixedPixelSpaceOrdinalScaleSpec fixedPixelSpaceOrdinalScaleSpec3;

  FixedPixelOrdinalScaleSpec fixedPixelOrdinalScaleSpec1;
  FixedPixelOrdinalScaleSpec fixedPixelOrdinalScaleSpec2;
  FixedPixelOrdinalScaleSpec fixedPixelOrdinalScaleSpec3;

  setUp(() {
    fixedPixelSpaceOrdinalScaleSpec1 = FixedPixelSpaceOrdinalScaleSpec(20);
    fixedPixelSpaceOrdinalScaleSpec2 = FixedPixelSpaceOrdinalScaleSpec(20);
    fixedPixelSpaceOrdinalScaleSpec3 = FixedPixelSpaceOrdinalScaleSpec(25);
    fixedPixelOrdinalScaleSpec1 = FixedPixelOrdinalScaleSpec(20);
    fixedPixelOrdinalScaleSpec2 = FixedPixelOrdinalScaleSpec(20);
    fixedPixelOrdinalScaleSpec3 = FixedPixelOrdinalScaleSpec(25);
  });

  group('== operator', () {
    test('SimpleOrdinalScaleSpec', () {
      SimpleOrdinalScaleSpec simpleOrdinalScaleSpec1 = SimpleOrdinalScaleSpec();
      SimpleOrdinalScaleSpec simpleOrdinalScaleSpec2 = SimpleOrdinalScaleSpec();

      expect(simpleOrdinalScaleSpec1 == simpleOrdinalScaleSpec2, equals(true));

      // Verify order doesn't matter
      expect(simpleOrdinalScaleSpec1 != fixedPixelSpaceOrdinalScaleSpec1, equals(true));
      expect(fixedPixelSpaceOrdinalScaleSpec1 != simpleOrdinalScaleSpec1, equals(true));
    });

    test('FixedPixelSpaceOrdinalScaleSpec', () {
      expect(fixedPixelSpaceOrdinalScaleSpec1 == fixedPixelSpaceOrdinalScaleSpec2, equals(true));
      expect(fixedPixelSpaceOrdinalScaleSpec1 != fixedPixelSpaceOrdinalScaleSpec3, equals(true));

      // Verify order doesn't matter
      expect(fixedPixelSpaceOrdinalScaleSpec1 != fixedPixelOrdinalScaleSpec1, equals(true));
      expect(fixedPixelOrdinalScaleSpec1 != fixedPixelSpaceOrdinalScaleSpec1, equals(true));
    });

    test('FixedPixelOrdinalScaleSpec', () {
      expect(fixedPixelOrdinalScaleSpec1 == fixedPixelOrdinalScaleSpec2, equals(true));
      expect(fixedPixelOrdinalScaleSpec1 != fixedPixelOrdinalScaleSpec3, equals(true));

      // Verify order doesn't matter
      expect(fixedPixelOrdinalScaleSpec1 != fixedPixelSpaceOrdinalScaleSpec1, equals(true));
      expect(fixedPixelSpaceOrdinalScaleSpec1 != fixedPixelOrdinalScaleSpec1, equals(true));
    });
  });

}

FYI: Here's a couple ways I run just one test file:
wink@3900x:~/prgs/flutter/projects/benchmarkx_gui/submodules/charts_cf/charts_common_cf (Fix-some-NaNs-when-window-is-small)
$ pub run test/chart/cartesian/axis/spec/ordinal_scale_test.dart
00:00 +0: == operator SimpleOrdinalScaleSpec

00:00 +1: == operator FixedPixelSpaceOrdinalScaleSpec

00:00 +2: == operator FixedPixelOrdinalScaleSpec

00:00 +3: All tests passed!

wink@3900x:~/prgs/flutter/projects/benchmarkx_gui/submodules/charts_cf/charts_common_cf (Fix-some-NaNs-when-window-is-small)
$ pub run test test/chart/cartesian/axis/spec/ordinal_scale_test.dart
00:01 +3: All tests passed!

To run all of the tests in a single project:
wink@3900x:~/prgs/flutter/projects/benchmarkx_gui/submodules/charts_cf/charts_common_cf (Fix-some-NaNs-when-window-is-small)
$ pub run test
00:42 +420: All tests passed!

And to run all of the tests in charts_cf:
wink@3900x:~/prgs/flutter/projects/benchmarkx_gui/submodules/charts_cf (Fix-some-NaNs-when-window-is-small)
$ make test
00:25 +420: All tests passed!
00:02 +28: All tests passed!

Looks good, txs!
When you have time, will you be able to add support for hashCode and tests?

Looks good, txs!
When you have time, will you be able to add support for hashCode and tests?

Can you tell me what the hashCode means, I have never used it before.

Can you tell me what the hashCode means, I have never used it before.

Every dart pbject inherits hashCode from Object and is primarily used by HashMap.
https://api.dart.dev/stable/2.8.4/dart-core/Object/hashCode.html
https://dart-lang.github.io/linter/lints/hash_and_equals.html
A google search for .


Update ci/cd setup to check with py3.9 till py3.11

In order to align with updated installation instructions (see https://github.com/inbo/niche_vlaanderen/issues/382) and overcome deprecation warnings (see https://github.com/inbo/niche_vlaanderen/issues/380), this PR adjusts the setup of the github actions and updates the installation instructions.
Python 3.7 is deprecated in numpy/pandas/... stack hence I excluded it from the testing and metadata, supporting python 3.9 till 3.11, while advising to users to use python 3.11 (see installation instructions).
I did not yet included Python 3.12 as pygeos is not tested against python 3.12, see https://github.com/pygeos/pygeos/blob/master/.github/workflows/test-pip.yml and conda-forge does not support this yet either (https://prefix.dev/channels/conda-forge/packages/pygeos).
@Sachagobeyn can you have a new test round with the updated installation instructions? I did a check on both windows/linux running also 4 notebooks in docs folder, but a second try-out might be good.
@johanvdw as discussed, the CI includes now multiple versions for conda on windows and uses the environment.yml file again.

@Wardlorenz if you would be able to verify the updated installation instructions in this PR, it should overcome the issues mentioned in https://github.com/inbo/niche_vlaanderen/issues/382 to install versions 1.3 or 2.0 from niche-vlaanderen package. Any feedback is welcome to improve the workflow.

@cecileherr can you have a check if with these updated installation instructions (with Python 3.11 and an updated version of the dependencies), the issue mentioned in https://github.com/inbo/niche_vlaanderen/issues/380 is no longer present?

@cecileherr can you have a check if with these updated installation instructions (with Python 3.11 and an updated version of the dependencies), the issue mentioned in #380 is no longer present?

It is on my to do list, but I need a few more days because I also want to try it on a colleague's computer. I keep you informed

@stijnvanhoey :

The installation works on my Windows machine.
The notebooks in docs/ run smoothly with that installation.
Note that I explicitly had to switch my conda solver to libmamba, otherwise conda was not able to resolve the environment (stuck: memory error). I started from the miniconda Python 3.12 installation. I would add that between brackets (conda config --show-sources and conda config --set solver libmamba), as I'm not sure if other users struggle with this.
A number of notebooks posted to this branch contain output. I'm not sure if this is deliberalty, I just want to notify you.

Note that I explicitly had to switch my conda solver to libmamba, otherwise conda was not able to resolve the environment (stuck: memory error). I started from the miniconda Python 3.12 installation. I would add that between brackets (conda config --show-sources and conda config --set solver libmamba), as I'm not sure if other users struggle with this.

Thanks, I will add this to the manual

A number of notebooks posted to this branch contain output. I'm not sure if this is deliberalty, I just want to notify you.

For this repo it is deliberate (rendered as such in the docs).

@cecileherr can you have a check if with these updated installation instructions (with Python 3.11 and an updated version of the dependencies), the issue mentioned in #380 is no longer present?

The installation with the new instructions worked flawlessly (miniconda 64 bits with Python 3.11) and I do not get the warning mentioned in #380 .

Thanks to everyone for the checks, merging this one now


Lens .deb package is missing on the official repository

Lens latest version(2024.9.300059-latest) is missing from the official repository
Aapt repositoiry:
deb [arch=amd64 signed-by=/usr/share/keyrings/lens-archive-keyring.gpg] https://downloads.k8slens.dev/apt/debian stable main
$ apt policy lens
lens:
  Installed: 2024.8.291605-latest
  Candidate: 2024.8.291605-latest
  Version table:
 *** 2024.8.291605-latest 500
        500 https://downloads.k8slens.dev/apt/debian stable/main amd64 Packages
        100 /var/lib/dpkg/status

Thank you for reaching out ! I have contacted our development team about your issue .

Hello @MarianBojescu,
Thank you for bringing this up! We are aware of the issue and are already working on it. The updated binaries will be available very soon. I’ll make sure to update you here once they’re ready. We appreciate your patience and look forward to sharing them with you shortly.

Hey, this is really annoying not being able to install the newer versions of Lens. There is similar problem for snap and AppImage that are not latest

Hello @MarianBojescu, Thank you for bringing this up! We are aware of the issue and are already working on it. The updated binaries will be available very soon. I’ll make sure to update you here once they’re ready. We appreciate your patience and look forward to sharing them with you shortly.

Any news?


[JS] Move from using tslint to using eslint

Description
tslint is being deprecated in preference to eslint. This change moves our projects over to using eslint with rules similar to those we used to use, and with some additional rules turned on.
Just to clarify how I envision us integrating this change:

First, we need to settle on the exact rules we want enacted. What I've encoded here is:

Porting of existing tslint rules to eslint
Enabling some new rules to help us catch more issues
Guessed or otherwise made arbitrary choices about some behaviors we may want to flag. What it in .eslintrc.js is just my opinion. I'm happy to discuss adding/removing/reconfiguring as needed. Some rules I enabled I feel strongly about. Others, not so much. :) This PR is where I expect the discussion to occur
You'll notice that there aren't any actual code changes in this PR. Since the set of rules isn't final, it doesn't make sense to fix the problems. It's worth noting that a lot of the rules can be autofixed, so don't let large lint error counts scare you

Once this PR is merged, I'll create a task in our build pipeline to perform lint checks. However, the build job won't fail on linting failures.
Follow-on PRs will fix and tweak rules until linting is clean. At this point, we will begin failing build jobs on linting failures.

eslint results by directory:
adaptivecards-controls-lint.log
adaptivecards-designer-app-lint.log
adaptivecards-designer-lint.log
adaptivecards-lint.log
adaptivecards-templating.log
adaptivecards-visualizer.log
aclint-lint.log
ac-typed-schema-lint.log
Microsoft Reviewers: Open in CodeFlow

@paulcam206 some conflicts that have creeped in here FYI.

/azp run


doesn't work with canvas.setZoom(x)

Hi
Great library. I have an issue so far: it doesn't work if you change canvas zoom level.
It also doesn't "drop" the shape on my canvas.
Any thought?

OK go it working with zoom by passing viewportTransform.
vp = this.canvas.viewportTransform;
ctx.transform(vp[0], vp[1], vp[2], vp[3], vp[4], vp[5]);

Where in the code exactly did you add that?


Question: How to preserve the src/ directory structure when building to dist/ directory?

Could you please clarify how to achieve the same directory structure in the dist/ as in the src/. None of the responses from here https://stackoverflow.com/questions/52121725/maintain-src-folder-structure-when-building-to-dist-folder-with-typescript-3 helped.
Thanks in advance

Did you manage to solve this, none of the answers on the linked stack overflow helped?
I'd like it to maintain the structure as we'd potentially have a lot of files, you can see here only one script.ts is output.

Thank you


add fog-aliyun for cloud foundry deployment

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

This PR adds fog-aliyun and aims to use it to deploy Cloud Foundry.

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the master branch

[ ] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

@petergtz @smoser-ibm
I'm not sure what to do in the context of the new golang bits service.  In the fog compatible world I would normally just accept this..

@zrob I think it's fine to merge it. Even if Bits-Service were still written in Ruby, merging this PR wouldn't automatically make Bits-Service support Alibaba Cloud. The fact that Bits-Service does not support it, shouldn't be a stopper for Cloud Controller.
We have a story to add support in Bits-Service.

Hello @xiaozhu36!
We noticed you dropped by in our Slack channel  a few days ago and it sounded like you were having trouble validating that the Cloud Controller works successfully with Alibaba Cloud OSS.
Slack Convo:
https://cloudfoundry.slack.com/archives/C07C04W4Q/p1528939029000169
Did you get it working? If so, we can merge it, but we'd like it if you marked it as experimental in the README (since our team does not test this integration directly).
Also, can you squash your commits and rebase this branch against the latest code on master? Thanks!
@ewrenn8 && Tim

Hi @tcdowney I have found the reason about problem in Slack channel and the reason is I used an incorrect way to install wordpress and it is not related the fog-aliyun. I can push other application using  Alibaba Cloud fog. So, you can merge it.
In addition, I have rebase this branch on master, please check it.
By the way, what is the mean of  "marked it as experimental in the README "?
Regards,
Guimin He

We can take care of the README.
Thanks!
Eli && @lisamcho


Path segment variable with visible name?

Looks like there is no way to render a parameter with visible name not as a query parameter.
For example: I have a commits (/commits) resource with page and size query parameters. And I would like to have ability to filter commits by project, and I would like to have it as an optional path parameter with name, like /project/windows95/commits. Is it possible?
Maybe some form of "form-style path operator" ({/project}) could be introduced? Like:
FORMAT: 1A
# Sample API
## Read commits [GET /{/project}/commits{?page,size}]
+ Parameters
  + page: 1 (number)
  + size: 1 (optional, number)
  + project: `windows95` (optional, string)
+ Response 200 (application/json)

That will be rendered as:
/project/windows95/commits?page=1

Hi @sniff
## Read commits [GET /{project}/commits{?page,size}]

+ Parameters
  + page: 1 (number)
  + size: 1 (optional, number)
  + project: `windows95` (optional, string)

+ Response 200 (application/json)

is  exactly what you ask for if I am reading correctly.
Another example with parameters https://apiblueprint.org/documentation/examples/07-parameters.html

@w-vi No, it does not. This will add only parameter value to URL (windows95) without parameter name (project) itself.
Your example will be rendered as /windows95/commits?page=1 if project is present, and i would like to have /project/windows95/commits?page=1.

How about shared parameter section:
FORMAT: 1A

# Sample API

## Commit collection [/commits{?page,size}]

+ Parameters
    + page: 1 (number)
    + size: 1 (optional, number)

### Read commits [GET /commits{?page,size}]

+ Response 200 (application/json)

### Read commits for project [GET /project/{projectName}/commits{?page,size}]

+ Parameters
    + projectName: `windows95` (optional, string)
+ Response 200 (application/json)

You can inherit parameters for an action from a resource currently.

@franklinyu Could be an option, but it still requires to duplicate descriptions and Responses for both sections


DEET-2069

Adding:
tagged = false;
and
else {
                  tagged = false;
}

Allowed for the var to reset back to false whenever the user lands on a new topic, instead of inheriting the true value from the previous post. To verify issue is resolved, head over to staging and open a delhi-mug post (like this one) that shows MUG Homepage, then visit a post without delhi-mug. The MUG Homepage button should be gone. Only delhi-mug works on staging because for testing purposes I only added the one tag in the newly installed theme component.

LGTM


Mouse Input under Wayland misses slow movement

Tested versions

Reproducible in: Godot 4.3 dev3 on Gnome Wayland in Fedora 39

System information
Godot v4.3.dev3.mono - Fedora Linux 39 (Workstation Edition) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (RADV NAVI22) () - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)
Issue description

I have a Corsair high DPI mouse that is set to high DPI and the movement speed in the OS is reduced.
When holding right mouse button to nevigate the editor scene and moving the mouse slowly the movement seems to be filtered, like if an float to int conversion is missing all values bellow 1.0.

Steps to reproduce

Setup Mouse with high dpi settings and reduce movement speed in OS.
Open Godot with --display-driver wayland.
Right click on scene to navigate
move mouse slowly.
Then move mouse fast to see that some movement is registered if its fast enough.

Minimal reproduction project (MRP)
No project is needed to reproduce this issue.

cc @Riteo

This is great news @Riteo. Keep up the great work!!

Done! @pracedru could you test #88343 and tell me if it fixes the issue for you?

I've recently got a new desktop and i've only now pulled your branch.
I am build right now.

@Riteo
I've just built your branch and i get:

Does one need to pass an argument to get wayland support ?

You might be missing the wayland-scanner build dependency.

You might be missing the wayland-scanner build dependency.

Yeah. How do i get that? I am on Fedora 39.

Done! @pracedru could you test #88343 and tell me if it fixes the issue for you?

Hi @Riteo  I have build your branch and can confirm that this branch fixes the issue with captured mouse navigation in the editor.

Apparently this was fixed, why is it still open?

The PR which purports fixing this hasn't been reviewed/merged yet (see the green "Open" label, it means it's not merged). So the bug isn't fixed yet.

I'm having a similar issue just trying to use Input.warp_mouse directly with a new slightly different position. Would fixing this allow me to make <1 changes or does it just not make sense to warp_mouse to a subpixel ?


Low slice value at high speed does not produce realistic results

When a wheel is spun with only 2 or 4 slices the full speed animation of the pointer does not produce a nice affect.
The pointer needs to fall down when in gaps that more densly populated wheels do not

Just change result to
var result = Math.ceil(rawResult);

to
var result = Math.round(rawResult);

it help me but he need to fix maybe i am too late to answer


Cannot delete nested translations when using --fix

Thanks for creating a really neat tool. I was using the --fix option and this addon threw the following error:
TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at deleteNestedTranslation (/Users/kcmurphy/.asdf/installs/nodejs/14.16.1/.npm/lib/node_modules/ember-intl-analyzer/index.js:343:14)
    at deleteNestedTranslation (/Users/kcmurphy/.asdf/installs/nodejs/14.16.1/.npm/lib/node_modules/ember-intl-analyzer/index.js:348:7)
    at deleteNestedTranslation (/Users/kcmurphy/.asdf/installs/nodejs/14.16.1/.npm/lib/node_modules/ember-intl-analyzer/index.js:348:7)
    at /Users/kcmurphy/.asdf/installs/nodejs/14.16.1/.npm/lib/node_modules/ember-intl-analyzer/index.js:317:9
    at Array.forEach (<anonymous>)
    at removeUnusedTranslations (/Users/kcmurphy/.asdf/installs/nodejs/14.16.1/.npm/lib/node_modules/ember-intl-analyzer/index.js:313:26)
    at run (/Users/kcmurphy/.asdf/installs/nodejs/14.16.1/.npm/lib/node_modules/ember-intl-analyzer/index.js:83:5)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

We have lots of nested translations in different files in the following format:
key1:
  key2:
    key3: 'translation'
  key4: 'another translation'
...

and our folder structure is nested as well:
app > translations > folder1 > folder2 > en-ca.yml
app > translations > folder1 > folder2 > fr-ca.yml

app > translations > folder1 > folder3 > en-ca.yml
app > translations > folder1 > folder3 > fr-ca.yml
...

@kcarmonamurphy Hey thanks for the issue and info, I have managed to track down the bug and written a fix. I'm creating a MR now and will update this issue when it has been reviewed and released.

excellent, thank you @Mikek2252!

This bug should now be fixed in the 3.1.1 release, sorry for the delay. Im going to close this issue now, feel free to reopen if you are still experiencing it.


Receive image spacing from image messages

Current solution throws away spacing of incoming image messages and sets spacing to (1, 1, 1). The incoming values should be kept.

@lassoan is this somehow related to Slicer storing spacing info in MRML (or something like that? I remember it wasn't stored in the vtkImageData)

Right, I thought so.
Here:
https://github.com/openigtlink/SlicerOpenIGTLink/blob/master/OpenIGTLinkIF/MRML/vtkMRMLIGTLConnectorNode.cxx#L367
If the spacing is set both on the image data and in the ijk to ras, there will be a compounding effect. This PR will have to have an accompanying PR in there to properly manage the spacing on the vtkImageData.
@lassoan is it as simple as:
          volumeNode->SetIJKToRASMatrix(imageDevice->GetContent().transform);
          volumeNode->SetAndObserveImageData(imageDevice->GetContent().image);
          volumeNode->Modified();

becomes
          volumeNode->SetIJKToRASMatrix(imageDevice->GetContent().transform);
          volumeNode->SetAndObserveImageData(imageDevice->GetContent().image);
          volumeNode->GetImageData()->SetSpacing(1.0, 1.0, 1.0); // IGTL device sets spacing in image data, do not duplicate with IJKtoRAS
          volumeNode->Modified();

?

@olevs could you also add in setting of the origin as well? I can't send edits to your PR
  float spacing[3];       // spacing (mm/pixel)
  float origin[3];        // origin (mm)
  int   svsize[3];        // sub-volume size
  int   svoffset[3];      // sub-volume offset
  int   scalarType;       // VTK scalar type
  int   numComponents;    // number of scalar components
  int   endian;

  scalarType = IGTLToVTKScalarType( imgMsg->GetScalarType() );
  endian = imgMsg->GetEndian();
  imgMsg->GetDimensions(size);
  imgMsg->GetSpacing(spacing);
  imgMsg->GetOrigin(origin);
  numComponents = imgMsg->GetNumComponents();
  imgMsg->GetSubVolume(svsize, svoffset);

  // check if the IGTL data fits to the current MRML node
  int sizeInNode[3]={0,0,0};
  int scalarTypeInNode=VTK_VOID;
  int numComponentsInNode=0;

  if (imageData.GetPointer()!=NULL)
    {
    imageData->GetDimensions(sizeInNode);
    scalarTypeInNode = imageData->GetScalarType();
    numComponentsInNode = imageData->GetNumberOfScalarComponents();
    }

  if (imageData.GetPointer()==NULL
      || sizeInNode[0] != size[0] || sizeInNode[1] != size[1] || sizeInNode[2] != size[2]
      || scalarType != scalarTypeInNode
      || numComponentsInNode != numComponents)
    {
    imageData = vtkSmartPointer<vtkImageData>::New();
    dest->image = imageData;
    imageData->SetDimensions(size[0], size[1], size[2]);
    imageData->SetExtent(0, size[0]-1, 0, size[1]-1, 0, size[2]-1);
    imageData->SetOrigin(origin[0], origin[1], origin[2]);
    imageData->SetSpacing(spacing[0], spacing[1], spacing[2]);

@olevs could you also add in setting of the origin as well? I can't send edits to your PR

And if you detect VTK9 is used then you could set image directions, too.

@lassoan I don't have the time or setup to test/verify image directions and VTK 9. If we should do it now, that probably needs to be done in a separate pull request by someone else?


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 0c6f25c:
:clock10: Pending: waiting for processors (25 builds ahead of you)
:warning: Docs Build is busy, currently there are 25 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 0c6f25c:
:clock10: Full build: the average full build time is 5 min(s) 55 sec(s), this is based on the last 734 build(s) for this repository.

Docs Build status updates of commit 0c6f25c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update docs

This PR updates doc to techdocs format.

Codecov Report

Merging #134 (23e0c0b) into master (0305d85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   46.96%   46.96%
=======================================
  Files           8        8
  Lines         313      313
=======================================
  Hits          147      147
  Misses        159      159
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0305d85...23e0c0b. Read the comment docs.


Updating videos on MLRun and Iguazio

Switched featured videos for ones that explain the projects better

@alexiguazio
Hey, the t params don't work so well (You can browse the preview in the Netlify comment here) . Can you just remove them?
If they are necessary, I'd be more than happy if you post a feature request or implement it yourself.


Logo For Fractal Image Compression

Hello @pvigier , Can I Make a Logo For This Project ?

Hi @iqbalhood, of course you can!


Sudden performance issues

In the last week continuous mode has been having performance issues it wasn't a week ago.
I'm using the same settings on the same book but scrolling has become unusuably slow, and then it will crash. This persists with different books and on different browsers (brave and firefox).
I'm also using G-Drive as my storage method.
I doubt it's a specs issue but if it helps:
Processor	AMD Ryzen 7 5700X 8-Core Processor                3.40 GHz
Installed RAM	32.0 GB
Windows 10
Images below show the crash on brave and the task manager stats I grabbed before it crashed.

Let me know if there's further info needed.

probably related to the major update of svelte- i deployed the old version. let me know if the issue still exists after couple of site refreshes / browser restart

probably related to the major update of svelte- i deployed the old version. let me know if the issue still exists after couple of site refreshes / browser restart

It seems back to normal now, thank you so much👍


Properly resolve absolute path of exposed module.

The change in #1033 is flawed. And the test coverage for requires is inadequate.
See #1039 (part 1). A broken bundle is generated when doing something like...
// bundle.js
browserify('./src/a')
  .require('./src/b');

// src/a.js
require('./b');

// src/b.js
// I'm the file being required

...because the code in #1033 essentially does...
this._expose[row.id] = '/somedir/src/b';

...which leads to a mismatch here...
https://github.com/substack/deps-sort/blob/c61e515015a0f8392c1b07530877084b6c411cb7/index.js#L72
...because there should be an entry index['/somedir/src/b.js'], but instead there's index['/somedir/src/b'].
I'm not 100% sure this pull request completely and correctly solves the problem for all cases, but it does solve it for the scenario in #1039 and is a step in the right direction. That this apparently used to work (according to @gasi in #1033) and that #1033 was merged as a fix underscores the need for better and more comprehensive tests around this functionality.

Here's an example of a test that currently fails:
jmm/node-browserify@ae9aedb

Merged in 8.1.1 with an asynchronous version. Thanks for the patch!

@substack Thanks! I started working on an async version after I submitted this pull request and I think it was shaping up similar to what you did (although I've only glanced at that so far) -- I was mimicking the pattern used for adding transforms -- but then I realized I think there's an even better solution, since the paths are already being resolved later on. I'll flesh that out a bit more and submit a pull request so you can see what you think.


Use Mark/Unmark for Ground Markers and Object Markers and Tag/Untag for NPC Indicators

Closes #2184

LGTM at a glance. Add this change for object indicators as well?

Updated for object indicators too


Make AppLifecycleScope an instance of WidgetsBindingObserver

AppLifecycleScope should mix in WidgetsBindingObserver with pre-defined, decompositioned stubs.

Closed via #123


chore(CPlusPlus): add longest common prefix and first unique character

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is on refer on the language README.md file
[x] My addition does not have a spelling problem
[x] My submission has a proper and user-friendly description of the algorithm
[x] My submission has the time complexity of the algorithm
[x] My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

hello @ming-tsai ,
this PR hasn't been merged yet.


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/jupyterlab-latex-feedstock#5.


[chip-test] chip_sw_sleep_pin_retention

Test point name
chip_sw_sleep_pin_retention
Host side component
SystemVerilog
OpenTitanTool infrastructure implemented
No response
Contact person
@tjaychen
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[x] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)  Yes - chip_sw_sleep_pin_wake
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)

Note that for this test, it will be preferred to reuse the chip_sw_sleep_pin_wake test which does not appear to be developed yet.

chip_sw_sleep_pin_mio_dio_val covers this test. Let me assign this to me and revise testplan to point to the sleep_pin_mio_dio_val test after it is implemented.

One thing chip_sw_sleep_pin_mio_dio_val misses is to check the active output value after wake-up. I think adding the output value checking logic to chip_sw_sleep_pin_wake makes sense.

I am working on this.


Write automated tests based on sinsp-example

Motivation
In an effort to improve the reliability of the repository, I think it would be a good idea if we wrote automated tests that could (hopefully one day) run as part of the PR checks.
Feature
There are many variations of tests we could create, but particularly I've been playing around with the idea of using a containerized version of sinsp-example to capture events triggered from scripts and validating the logs generated, you can check out my PoC here. The TL;DR of it is:

A container running pytest is in charge of inserting and removing the scap.ko kernel module (I've not implemented an eBPF variant yet but should be possible).
That same container spawns an additional container running sinsp-example with the filter found in the example readme.
A simple script is executed and the logs for the sinsp-example container are read in order to find expected events.

This approach, even if rough at this point, combined with the ability to spawn additional containers from the test itself, should allow us to implement any number of tests we want to test different functionalities of the libraries as a whole, some examples I can think of:

Detect specific containers starting/stopping.
Detect commands being executed in a specific container.
Run a basic nginx container and make a request to it in order to detect IP and port values are processed correctly.

Alternatives
It's been suggested to use gtest or catch2 as the driver for the tests themselves, my PoC simply used pytest because of my familiarity with it and Python just seemed the easiest way to achieve my goal. I think it would be worth it to compare the amount of boilerplate/extra code needed, as well as the level of effort needed to implement a similar concept with either of those frameworks.
Additionally, in order to make this testing approach a little easier, I think implementing a flag in sinsp-example for it to output JSON would come a long way into making parsing its logs a lot easier. Furthermore, we could implement a JSON schema for those events and validate all events generated against it, (including the events that don't match the ones we are looking for in the test), which would help us ensure all fields have a valid format and are not somehow corrupt.
Additional context
Because right now the only check needed to merge a change is for the libs to compile, it's relatively easy for bugs to slip past into master. Adding any sort of testing would go a long way into preventing some of them and this is the broadest, yet simple approach I could come up with for testing multiple components at once.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

Moreover, the PoC repo indeed actually helped us spot at least a couple of issues.
I :100:  agree on having something similar (if not exactly that repo) running in our CI.
Once #453 is merged and we have gh actions, perhaps you can try to port your CI here?

I've been putting a bit of thought on what it would take to merge the existing tests from my PoC into the libs repo, this is what I think would work best, at least as a first approach that can be refined and tuned afterwards.
First thing would be to move all required new files into the repo (tests, dockerfiles, makefiles), those could live in one of two places:

Because sinsp-example is the main binary under test, we could place all files under userspace/libsinsp/tests/e2e/
We could add an e2e-tests (or simply tests) directory in the root of the repository, this might be a little cleaner and could make it easier to add tests based on the files found there for other example binaries like scap-open.

Because the current CI already builds sinsp-example and drivers for the system it runs on, we could simply add steps to the current workflow to build all the required container images and run the tests. We could also look into splitting the workflow so that the binaries are reused in a separate job, but that can be an improvement after we get a minimal version of this running. It's also worth noting that building sinsp-example using address sanitizer could provide added value, since it would catch wrong memory uses for us, but for a first attempt, we can skip this for now.
The PoC right now uses raw makefiles for building and running, we can probably change it to use CMake instead with custom commands, it might be overkill but it would also mean we can use the same build system with these tests as well.
One thing I would like to get feedback on is how does people feel about adding a bunch of Python into the repository, I could rewrite the tests to use a different language but I find Python is great for quickly prototyping and debugging these type of tests.
As a final note, the PoC only runs tests for Linux on x86 systems. I think getting those merged would be a good first step, we can expand from that to add tests on other platforms and operating systems.
Unless there is any strong push back against this, I'll try to get a draft PR for this as soon as I get a chance, since I feel that might inspire people to be more vocal on this subject 🙂

I've been putting a bit of thought on what it would take to merge the existing tests from my PoC into the libs repo, this is what I think would work best, at least as a first approach that can be refined and tuned afterwards.
First thing would be to move all required new files into the repo (tests, dockerfiles, makefiles), those could live in one of two places:

Because sinsp-example is the main binary under test, we could place all files under userspace/libsinsp/tests/e2e/

We could add an e2e-tests (or simply tests) directory in the root of the repository, this might be a little cleaner and could make it easier to add tests based on the files found there for other example binaries like scap-open.

Personally, I prefer this second option and the test folder should be already there if the  https://github.com/falcosecurity/libs/pull/484 is merged. I find this approach cleaner when more than one component is involved in the testing phase.

Because the current CI already builds sinsp-example and drivers for the system it runs on, we could simply add steps to the current workflow to build all the required container images and run the tests. We could also look into splitting the workflow so that the binaries are reused in a separate job, but that can be an improvement after we get a minimal version of this running. It's also worth noting that building sinsp-example using address sanitizer could provide added value, since it would catch wrong memory uses for us, but for a first attempt, we can skip this for now.

Having a minimal version already brings a huge value IMHO. big +1 :tada:

The PoC right now uses raw makefiles for building and running, we can probably change it to use CMake instead with custom commands, it might be overkill but it would also mean we can use the same build system with these tests as well.

It would be great to have just a unique build system, but it depends on the effort! If it becomes too complicated I don't see big issues in using plain makefiles for building these tests.

One thing I would like to get feedback on is how does people feel about adding a bunch of Python into the repository, I could rewrite the tests to use a different language but I find Python is great for quickly prototyping and debugging these type of tests.

To be honest, I am not so familiar with python, so I cannot say if it is the best language for doing this, but again I don't see a big issue in using it, if tests are clear and well documented there shouldn't be problems :) @FedeDP @leogr

As a final note, the PoC only runs tests for Linux on x86 systems. I think getting those merged would be a good first step, we can expand from that to add tests on other platforms and operating systems.

Oh yes, it would be great to have something at least for ARM64, but I agree with you we can add it in the following steps.

Unless there is any strong push back against this, I'll try to get a draft PR for this as soon as I get a chance, since I feel that might inspire people to be more vocal on this subject slightly_smiling_face

It would be amazing, we really need tests in the repo and mainly in libsinsp! Thank you for all your effort @Molter73! :clap: :tada:


Add support for bulk update, delete and create of resources

Some modules like Localization support bulk operations, so Connect Client should support this too.

Codecov Report

Merging #39 (7ea00fc) into master (d9b0a03) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   97.87%   98.38%   +0.50%
==========================================
  Files          19       19
  Lines        1273     1297      +24
  Branches      210      218       +8
==========================================
+ Hits         1246     1276      +30
+ Misses         14       10       -4
+ Partials       13       11       -2

Impacted Files
Coverage Δ

connect/client/models/base.py
100.00% <ø> (+1.35%)
:arrow_up:

connect/client/mixins.py
100.00% <100.00%> (ø)

connect/client/models/mixins.py
100.00% <100.00%> (ø)

connect/client/models/iterators.py
100.00% <0.00%> (+4.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b0a03...7ea00fc. Read the comment docs.


Triage bot is failing?

After creating a new Issue (https://github.com/Seagate/cortx/issues/629), I got an email that triage failed with a link to this:https://github.com/Seagate/cortx/actions/runs/515516207

Looks like a problem with our triage bot?

@johnbent, I had removed the triage workflow from cortx repo,

@johnbent, I had removed the triage workflow from cortx repo,


No samos package

The jupyter notebook example use the package samos but I cannot find it. Is that an personal package?

Hi Jianxing,
samos can be found at https://github.com/lekah/samos.
Be aware that samos and the example notebook are written for the older Python 2.7 release (https://github.com/Linux-cpp-lisp/sitator/releases/tag/v1.0.1). A lot of what's in there is applicable to the Python 3 version, but unfortunately right now there isn't a actual full demonstration for the newer version.


k8s-lint: Start linter

Currently checks a few small bits but can be expanded for more thorough cases.
The linter may not follow SemVer as new checks are added.
Example linter output (skipping config read)
☠  ERROR /Users/philipcristiano/gits/k8s-scripts/deploy/example-app.statefulset.yml does not exist
✓  /Users/philipcristiano/gits/k8s-scripts/deploy/example-app.service.yml exists
✓  /Users/philipcristiano/gits/k8s-scripts/deploy/example-app.deployment.yml exists
☠  ERROR /Users/philipcristiano/gits/k8s-scripts/deploy/example-app.deployment.yml does not include 'revisionHistoryLimit' https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy
Exit: 1

@reactiveops/daas-team-members Please let me know what checks would be helpful!

strategy: RollingUpdate
maxUnavailable
maxSurge
livenessProbe
readinessProbe
anything else @robwar?

Added those to #70 as I believe those will work in 98% of deployments but will need a way to override the linter which doesn't exist yet.


Extending this tool for more than 1 second

Would it be foolish of me to assume it is as trivial as changing desired_length_ms = 1000 to desired_length_ms=10000?
I understand you mentioned in your README that this tool is not designed to be flexible, but I'm wondering if the answer here is simple.
Otherwise I will see what I can do with some digging and learning.
Thanks!

I would expect that change would work, but I haven't tried it myself.
On Thu, Nov 8, 2018 at 6:21 PM naveen<EMAIL_ADDRESS>wrote:

Would it be foolish of me to assume it is as trivial as changing
desired_length_ms = 1000 to desired_length_ms=10000?
I understand you mentioned in your README that this tool is not designed
to be flexible, but I'm wondering if the answer here is simple.
Otherwise I will see what I can do with some digging and learning.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/petewarden/extract_loudest_section/issues/6, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJ2sxxMh6Erq3ezJAoIOQZiU9uMRjFZks5utOaagaJpZM4YV10W
.


Have option for multi page app routing

Since this seems like a trickier thing with express routing for the back end and running both servers together like this. I should probably add in the generator for it to prompt if needing multi page routing to generate the stuff required for that.

this is now in place - however I need to write documentation around it so I'm leaving this open for now until I get that done

closing issue out since documentation is done and this is now fully incorporated in the generator as of v1.1.7


Make use of libvirt's volume API

We should be doing this, if not for anything else then at least to avoid copying images without having to rely on external qemu-img command.

Just remembered that using volume API also implies storage pool API AFAIK. This isn't a problem on it's own. We can create a dir pool and put the volume there but it means that the location of disk image will be different on different platforms then and a bit more work than I previously thought. The latter is not a problem if the former is not though. WDYT?

but it means that the location of disk image will be different on different platforms

I don't understand this one. libvirt is only used on linux.

I don't understand this one. libvirt is only used on linux.

that's why the path will be different on Linux (sorry could have worded it better) and that's why on Linux the path will be different. Not sure if it's an issue though.

Still not quite clear what you mean :( The dir pool could point at ~/.crc/machines/crc, so the image would still be in the same location as other platforms. I'm totally missing your point and concern :(

The dir pool could point at ~/.crc/machines/crc

Yeah but then the dir belongs to the pool and deletion will remove it, which may not always be what we want.

Ok, so you are suggesting pointing the pool at a path outside of ~/.crc/machines/crc ?
Removing the pool behind crc back sounds like something unsupported, so I would say losing ~/.crc/machines/crc in that case would not be that bad.

Ok, so you are suggesting pointing the pool at a path outside of ~/.crc/machines/crc ?

I was thinking of a subdir there actually but now I also remembered that currently the driver keeps room for multiple machines in the future (crc machine name is not hard coded) so a directory outside that would be best, yes.

Removing the pool behind crc back sounds like something unsupported,

No, I wasn't thinking of that. I was thinking that we might not want everything in that dir to be always deleted at the same time as we delete the pool, in the future. Also the other way around: not deleting the pool but deleting the dir still. The main issue i see here is the dir becoming a property of the pool and it's not exactly the case here.


[Question] Bot Framework openUrl not working for suggested action on Facebook Messenger

System Information (Required)

SDK Language: NODE
SDK Version: 3.8.3

Issue Description
Bot Framework openUrl not working for suggested action on Facebook Messenger
Code Example
More details and code example, can be found in this Stackoverflow post

Closing as duplicate of https://stackoverflow.com/questions/45081848/bot-framework-openurl-not-working-for-suggested-action-on-messenger

When will this work?

Any updates for this issue?
It does not help that there is a similar question (without any solution) on stackoverflow.


AssertionError: Breakout-v0.npy"

[1201 10:47:55 @monitor.py:363] max_score: 863
[1201 10:47:55 @monitor.py:363] mean_score: 590.14

This is my first work out with GYM
Ran for 2 days with and stable , pretty good with single 1070 w8G Ram
it still running,
when I do
./train-atari.py --task gen_submit --load Breakout-v0.npy --env Breakout-v0 --output output_dir

It said
AssertionError: Breakout-v0.npy"

Do I need to wait for the training finish to get Breakout-v0.npy ????

Look at your log directory. That's where your models are. Breakout-v0.npy is my released pretrained model.


API refinements

moves ByteArrays under utils
minor renamings to KeyUtils functions
SecureHash minor renaming and provide more meaningful API name for toString

I am not convinced we need most of this. Maybe the move, but not sure the renames make much difference to clarity. Also note the higher priority for some of these is likely to be the scaling issues with taking Iterable rather then Set, though that can be fixed by adding an extra overload.

I am ok with the moving and the implementations changes, but I don't think the renaming of the functions added much here, I'd rather not do that bit. The real question I was asking myself when reading this code review is whether we actually need all these functions on the public API? Are they used in API classes? Or are they really utils that should either be shipped in a separate utils lib, or be part of runtime-os if CorDapp writers don't need them?

AFAIK atomic swap contracts are usually implemented with composite keys.
So I suspect the interop team will need at least the one with the threshold checks.
@jmacmahonr3: do I remember right?


Needs updating: latest version is 3.1.1

Comment:
The current version of visidata available in conda-forge is 2.1.1. this version is problematic in Windows (see https://github.com/saulpw/visidata/issues/725). The latest available version in the pip is 3.1.1, which resolves the issue. Is it possible to update it? Many thanks.

@anjakefala, any chance you could help out on this one? very much appreciated!

Hi! I bumped it to v3.1.1. Thanks for the ping. =)
Please try it out, and let me know everything is working.


Bootstrap Multi Tab Switching Issue

When you have more then one set of tabs on one page and your using the boostrap.js, not bootstrap.min.js (file already fixed), if some of your have tabs that have the same identifiers it fails to change tab when the link is clicked.
Here's how to fix it:
You need to change the line that reads
'var $target = $(selector)'
in the tab class definition section to
'var $target = $ul.siblings('.tab-content').children(selector)'

Having multiple elements with the same id is invalid HTML, unless you mean something else by "identifiers".

it maybe invalid but it still doesn't stop it happening sometimes, did you add the change to the code?

We don't attempt to accommodate blatantly invalid HTML. Down that road lies madness.

you already have the fix in the minifed version, you just need to put it in the normal version too

Suffice it to say that that's not how minification works and that there's nothing broken here in Bootstrap to begin with. What's broken is whatever is generating that invalid HTML.

The version of the minifed file i was looking at was an older one but the point still stands, in its current way it just search for the first id called that, where as in my method is looks local to its self to find that id. I know that your not suppose to have html elements with the same id but in web applications, and other large projects, sometimes it can happen. This wont promote using the 'invalid html' to people, it will just make bootstrap more robust.

Look, guys, I understand your desire not to allow invalid HTML.
But also you should take into account use case, when it is required to place a lot of similar tab widgets.
Please, understand, that generating unique id's is very bad solution (and it become bigger nightmare working with ajax, because server do not know the last used id on the page).
Maybe using id's for switching tabs (and for similar tasks) was totally wrong decision from your side at the very beginning? Didn't you think about that?
Or, maybe, you have better solution how to place a lot of tab widgets on one page without unique ids?

@ertong +1


istio 1.13.2 to 1.18.0 upgrade breaks the all application reachability

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
I trying to upgrade the istio with canary procedure , Now i have a both the versions of controlplane and ingress running. I have properly configured the service and gateway to point to 1.13.2 ingress gateway pods(before upgrade) . Now after upgrade none of the apps are reachable ,
ELB apps not reachable
ALB apps says 502 bas gateway.
Internal within k8s service reachability works, Only external access via gateway is broken.
k get po -n istio-system
NAME                                              READY   STATUS    RESTARTS   AGE
istio-ingressgateway-1-18-0-6bfbbbc647-bnllz      1/1     Running   0          36s
istio-ingressgateway-66645554d4-sv2hd             1/1     Running   0          7h38m
istio-ingressgateway-alb-1-18-0-67c59fd9c-nhf5q   1/1     Running   0          34s
istio-ingressgateway-alb-69c57f75c8-nfsls         1/1     Running   0          7h38m
istiod-1-13-2-5b7574489d-k2prm                    1/1     Running   0          8h
istiod-1-18-0-568b9cd57d-ncd4x                    1/1     Running   0          38s
jaeger-585bdbb6dc-m8xd4                           1/1     Running   0          41s
kiali-ffbb9f565-hxtjg                             1/1     Running   0          39s

Version
client version: 1.13.1
control plane version: 1.13.2
data plane version: 1.13.2 (3 proxies)

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[X] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

It is recommended to upgrade within 2 minor versions. There might be changes breaking backward compatibilities. I think you can examine the components' logs, and also try to enable debug log of the proxy to see if there are issues.

@hanxiaop THanks for responding,  I haven't upgraded to newer version yet, You can see from above Both the control plane(istio +ingress) versions are running.   And the dataplane is still running with 1-13-2 version .   I did enable the debug logs ,i don't see the packets arriving at the ingress gateway pods itself .  Is there any upgrade envoyfilter causing the issue ?
 k get envoyfilter -n istio-system
NAME                                AGE
accesslog-settings                  10h
cccbufferlimit                      10h
security-by-default-header-filter   10h
stats-filter-1.11-1-13-2            4d20h
stats-filter-1.12-1-13-2            4d20h
stats-filter-1.13-1-13-2            4d20h
stats-filter-1.16-1-18-0            10h
stats-filter-1.17-1-18-0            10h
stats-filter-1.18-1-18-0            10h
tcp-stats-filter-1.11-1-13-2        4d20h
tcp-stats-filter-1.12-1-13-2        4d20h
tcp-stats-filter-1.13-1-13-2        4d20h
tcp-stats-filter-1.16-1-18-0        10h
tcp-stats-filter-1.17-1-18-0        10h
tcp-stats-filter-1.18-1-18-0        10h

This is weird for old pods also listeners are missing , Any clue how to rectify this ?
(base) istio ananayak(k8s: staging-eks) $ istioctl proxy-config listeners istio-ingressgateway-66645554d4-bj855.istio-system --port 8443
ADDRESS PORT MATCH DESTINATION
(base) istio ananayak(k8s: anand-eks) $ istioctl proxy-config listeners istio-ingressgateway-66645554d4-bj855.istio-system --port 8443
ADDRESS PORT MATCH DESTINATION
(base) istio ananayak(k8s: anand-eks) $ istioctl proxy-config listeners istio-ingressgateway-66645554d4-bj855.istio-system --port 8080
ADDRESS PORT MATCH DESTINATION

@hanxiaop  I deployed the istio 1.18.0 from scratch as well, I see the same issue .
(base) istio ananayak(k8s: anand-eks) $ istioctl proxy-status
NAME                                                          CLUSTER       CDS        LDS        EDS        RDS          ISTIOD                             VERSION
istio-ingressgateway-1-18-0-6bfbbbc647-h7ccc.istio-system     anand-eks     SYNCED     SYNCED     SYNCED     NOT SENT     istiod-1-18-0-568b9cd57d-m8wkj     1.18.0
(base) istio ananayak(k8s: anand-eks) $


[Event Request] Codeunit 80 Sales-Post OnAfterAssocItemJnlLine

We have added fields in our extension to the Item Journal Line table whose values are based on SalesLine fields.  In order to update the related fields in the Item Journal Line table when the Item Journal Line is initialized, we need a parameter to be added to the OnAfterInitAssocItemJnlLine event for the SalesLine variable.
This is called at the end of Local function InitAssocItemJnlLine within the Sales-Post codeunit 80
Ex:  OnAfterInitAssocItemJnlLine(ItemJnlLine,PurchOrderHeader,PurchOrderLine,SalesHeader,SalesLine);

Apologies, I should have also stated that SalesLine will need to be passed into InitAssocItemJnlLine function within the codeunit in order to accomplish this.
Thank you!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


FlowContorller for new v2.Batcher

This is a part of series of PR for v2/Batcher, and following up with #744
What this PR contains
This PR introduces FlowContorller in v2.BatchingSettings, Whose interface is copied over from existing FlowController.
Note: The implementation is still under discussion.
cc: @igorbernstein2 @kolea2

Change of plan: using existing


Corrupt NCTL linebreaks

PROBLEM:
On release-1.3.1 branch, running the NCTL activation script results in the following:
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: No such file or directorysperLabs/casper-node/utils/nctl
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found
: command not found

The problem seem to be Windows-type linebreaks, and everything is right again after applying the dos2unix utility to every script

@AlexanderLimonov please provide more details like OS, steps to reproduce etc

@cspramit, I would close this out for now, because it might be an issue with some of the software I use (CLion, in particular), will check again with 1.4


Add but() method to builder

Sometimes you want to build many instances, but only one (or some) of the attributes are different.
In order to do so, as it is now, you should build a new Builder for each attribues combination.
I suggest to add a but() method that creates a new builder instance with the same attribues values.
In general it is the clone method, but it has the meaning that I want the same builder as it is now "but" set some attributes as i need.
For example, we have class A:
@Builder
public @Data class A {
     private final String a1;
     private final String a2;
}

The implementation in the builder should be like that:
...
public ABuilder but() {
    return A.builder().a1(a1).a2(a2);
}
....

I would like to do the following:
ABuilder builder = A.builder().a1(A_STRING);
ABuilder builderWithSomething = builder.but().a2(SOMETHING)
ABuilder builderWithSomethingElse = builder.but().a2(SOMETHING_ELSE)

By that I can create an hierarchical of builders, while each one of them sets the attributes they need without change it to the other builders.

I still do not understand the use-case. I do have two way to 'implement' similar behavior:

Reuse an existing Builder instance
Use toBuilder

@Builder(toBuilder=true)
class Foo {
  int x;
  int y;
}

FooBuilder b = Foo.builder().x(0).y(0);
Foo origin = b.build();
Foo unit = n.x(1).build();

Foo imagine = origin.toBuilder().y(1).build();

Did I miss a substantial use-case?

Sorry if I miss any point from the discussion.
From my experience the toBuilder() method called but() is useful and more fluent when the builder methods are prefixed with with, for, using, etc. (for which I also couldn't find a way to configure @Builder with, but that's another topic).

@picimako The names have a system:

The @Wither uses the "with" prefix and creates a new object rather than setting anything. It rarely makes sense with mutable objects.
The builder uses "fluent" "chained" setters, i.e., setters returning this and having no "set" prefix. The former is rather necessary and the latter is quite convenient. Using the "with" prefix for setters would be very confusing.

There's no configuration for this and I guess, this won't change. All you can configure are the classical @Getter and @Setter using @Accessors or lombok.config.
Concerning but, for, using, etc., I guess, they'd make it all even more confusing. The "with" prefix has its place as there must be something allowing to tell it from a setter, builder and toBuilder do just what they say, but the others feel very redundant to me.

@Maaartinus Thank you for the explanation.
I agree with you about for and using being confusing. That should change on our side.
And I can definitely live with having non-prefixed builder methods, I was just hoping for that I could migrate some frequently used builder classes (with methods mainly prefixed with with) to Lombok Builder without having to update the many references of those methods.

I don't know what 'but' is trying to accomplish, here. I think you misunderstand how builder works. Relevant notes:

You can generate a builder off of an instance using @Builder(toBuilder = true).
You can just continue to use a builder; they do NOT become invalid after using them to build. The builder continues to remember all properties you set.

If I'm missing something, please reopen and be really specific and serve it up on a silver platter for me:
Write some java that has lombok and this mythical 'but' thing, then show what it would look like delomboked, and make sure to write the example such that it is inherently obvious as to what its for. Right now I don't get it.


Fix permissions/mode of [php][ext_conf_dir]

Since the resource pointed by node['php']['ext_conf_dir'] will certainly be a directory it will need execution permissions. Otherwise when activating an extension for CLI for instance by creating a symlink under /etc/php5/cli/conf.d it won't be able to read and import it.

Looks like a solid contribution to me, I've added this to the next milestone.

Hi @Rockstar04
I'm not aware of your release plan. But this change was intended as a bug fix (things were broke for me) so maybe this should be in a 1.7.1 release before the 1.8.0 one?
Regards,

Ya are right, When I first took over the library there was a huge backlog for both new features and bug-fixes, so I was just doing a mix of both (and a minor version bump) but this could definitely go out as a 1.7.1.

Release 1.7.1 pushed to the supermarket!
Thanks @Restless-ET


Mongoose schema customizable

We're currently create and passing mongoose schemas, there is no ways for users to customize it.

https://github.com/dryerjs/dryerjs/pull/193


new props don't cause Presenters to re-render

This issue popped up when upgrading from 11.6.0 to 12.2.0
I noticed this issue when components stopped swapping out on route changes. Simplified, the issue looks like this:
class Application extends Presenter {
  render() {

      { this.props.children }

  }
}

Routes:
<Route path="/" component={Application}>
  <Route path="foo" component={Foo} />
  <Route path="bar" component={Bar} />
</Route>

Changing from /foo to /bar, does not cause a re-render, and the component is not swapped out.
Simply adding children to the model seems to force the Presenter to update when the prop changes, and works around the issue.
class Application extends Presenter {
  getModel (props) {
    return {
      children: () => props.children
    }
  },

  render () {

      { this.props.children }

  }
}

But as I understand it, prop changes should cause render to be called again.

This should be fixed in 12.2.1, currently in release candidate. Will close after we publish to stable.

Fixed: https://github.com/vigetlabs/microcosm/releases/tag/v12.2.1


Override both type and format in annotation

Sometimes the type and/or format generated by swagger bindings is inappropriate (due to issues or fuzzy spec). It would be very helpful, if one could override the type and format in @ApiModelProperty annotation, to match its needs. Currently you can specify an alternative type in the dataType attribute. But this does not help, if there is no adequate alternative.
So, is there currently a way to override theses attributes, or would that be a desirable feature?

This has been added in https://github.com/swagger-api/swagger-core/commit/9e8b2c6bff639598df077465b9a78ebb854f0b83


By late 2021, bots will not be able to proactively retrieve the userPrincipalName or email properties

[Enter feedback here]
Is there any updated guidance available on this as of March 2021?

By late 2021, bots will not be able to proactively retrieve the userPrincipalName or email properties for members of a chat/team and will need to use Microsoft Graph to retrieve them. Specifically, userPrincipalName and email properties won't be returned from the new GetConversationPagedMembers API starting in late 2021. Bots will have to use Microsoft Graph with an access token to retrieve this information. This is obviously a major change: We must make it easier for bots to get an access token, and we must streamline and simplify the end-user consent process.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c780d605-b1b2-716f-5888-503608769b5a
Version Independent ID: 53c724f8-d9a2-4af6-6d75-ddeaef084137
Content: Bot API Changes for Team/Chat Members (2020 update) - Teams
Content Source: msteams-platform/resources/team-chat-member-api-changes.md
Product: msteams
GitHub Login: @ojasvichoudhary
Microsoft Alias: ojchoudh

The date is already updated to 2022 in the article https://docs.microsoft.com/en-us/microsoftteams/platform/resources/team-chat-member-api-changes @surbhigupta12

Closing this issue


v1.0.0

Signed-off-by: Brandon Wolfe<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
15 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 0.0%

Files with Coverage Reduction
New Missed Lines
%

src/ApplicationLibrary/MobileLibrary.py
1
0%

src/ApplicationLibrary/DesktopLibrary.py
14
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
752

💛  - Coveralls

Broken link checker will fail until we have pushed to pypi and the download checker updates at 1 am UTC


EGAS00001004344 - HumanLungCellAtlas2020

Project short name:
HumanLungCellAtlas2020
Primary Wrangler:
Ami --> Ida
Secondary Wrangler:

Associated files

Google Drive:

https://drive.google.com/drive/folders/1KAdjRx2BmChOGk8N1gG6cBG96UB62c5z
Latest version:
Response from authors about bulk data: "The immune cells for bulk mRNA sequencing were from an entirely different source (the blood was purchased from https://allcells.com/).". I have decided to not include this bulk data, as it is not from the same sample types as the single cells.
I have also decided to not include the mouse data from Tabula Muris Senis (authors also let us know that almost all the mouse data is from that datasets). I have created a separate project for Tabula Muirs Senis in ingest as the main publication is separate.
https://docs.google.com/spreadsheets/d/1zguXGnB2i0hqEHW_sK5FhvKkyivzND-2Pe5pO8RstRM/edit#gid=375992513
Old version (V1, with bulk):
https://docs.google.com/spreadsheets/d/1dDNNH1bda10sQ-GlEuzMl4T_F-VhZ5spoHhAZ-Pq0L8/edit#gid=89826910
Link to Ingest:

https://contribute.data.humancellatlas.org/projects/detail?uuid=6936da41-3692-46bb-bca1-cd0f507991e9

Published study links

Paper: A molecular cell atlas of the human lung from single-cell RNA sequencing

Accessioned data: EGAS00001004344

Key Events

[x] Convert published metadata to HCA spreadsheet
[x] Manually curate dataset to meet HCA metadata standard
[x] Collect any matrix and cell-type annotation files
[ ] Upload sheet to validate metadata
[ ] Check linking using ingest graph validator
[ ] Transfer raw files to ingest to validate data files
[ ] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[ ] Submit dataset to Production
[ ] Complete the Export SOP
[ ] Convert project data to SCEA format following the SCEA conversion SOP if appropriate

Request new cell type ontology "immune cell": https://github.com/HumanCellAtlas/ontology/issues/120

Challenging dataset: way too many cell barcodes to link to either new cell suspensions (like an experiment accession) or an analysis file in a single cell in excel or google sheets. We need to find a programmatic way to do the linking in ingest.

Note about cell type ontologies:
Hi @bvarner-ebi and @addiehl suggest rather than 'immune cell', I could use 'leukocyte' and that "immune cell" should be added as a related synonym to the ontology term.
Request new ontology terms for: CD8-positive T cell, CD4-positive T cell

Found a workaround to link all cell suspensions

Emailed the authors about mouse single cell seq data and bulk data.

Info from Kyle:
"Ah I think I understand where the confusion is coming from. The accession in the paper only includes FASTQs for 608 SmartSeq2 cells specific to the study. The remainder are from the Tabula Muris Senis are available on that data portal. Of the 608, there are 1 set of FASTQs for the “Tbx4-Cre > ZsGreen1” cells (tagged with KJT) and 2 (across 2 sequencing lanes) sets for the “Axin2-CreER > mTmG” cells (tagged with ANN). 224 KJT + 2 * (384 ANN) = 992 sets of FASTQs. The cell IDs have the form “P-16-CGCTCAGT-TTATGCGA_ANN_S256” (after concatenating the lanes). This represents [The 384 well it was sorted into][The i5 and i7 indices][the sorter, Ahmad versus myself]_[the bcl2fastq index during de-multiplexing]."

Linking data files to samples in spreadsheet: on-going

Downloading SRA object files

Also waiting on test data: cell suspension as input to cell_suspension

504bec8b-733e-41d1-a5c3-5b19289036cd

Dataset exceeds maximum cell suspension count - error in ingest. Creating a ticket for this.

@ESapenaVentura will be working on the technical side of this with @amnonkhen

What I know so far of this dataset

Organism
Techinque
Specimens
Cell suspensions

Human
10x
7
17

Human
SS2
8
9409

Mouse
10x
16
63

Mouse
SS2
2
608 or 525 --> not clear yet

@idazucchi and @ESapenaVentura will discuss this today

I updated the metadata for human 10x and uploaded the analysis files to the hca-util area
up next: human ss2

Contacting the collaborators again

This is not on the high priority list, so while we wait it could be down prioritised

@idazucchi to chase one last time and close if no response

I emaild the authors again, if I don't get a reply in one month I'll close this ticket

we got a reply! I'll work on this dataset from next week, I'm trying to close the ones I have open at the moment

Open questions for review

there is no exact ontology term for the mouse strain - just text? request new ontology term? we don't know where the mice came from so accurate annotation is impossible

mouse ss2
the cell ids from the metadata csv have been truncated: to match them up to the sequence file you need to discard the decimal digit for the plate well row

Start sec reviewing it.

Very well done Ida, on such an extensive dataset!
Donor

We have some information for donor_organism.medical_history.smoking_history but not exact number of cigarettes per day. Maybe we could just provide that patient 1 has remote history of smoking while patients 2,3 are non-smokers. The schema allows it but I am not sure about the consistency of our data (given that all other datasets have the guideline format).

Cell suspension

You could add a small explanation in the description of the pooled cell plates (row 9432 to 9485)

Analysis files

Genome version for barcodes and possibly feature tables, could be Not applicable.

All file and biomaterial mappings are verified. Awesome work!

verified in the browser


Fix pre-pump step in pypi release CI

Issue description
Check actions:  https://github.com/pypa/pipenv/actions/runs/7749006292/job/21132708157
It fails, but after publishing successful wheel.  It doesn't block release, but we need to evaluate either removing the bump release version, or fixing the step.
Describe the issue briefly here.

We removed it instead, a while back.


Add Traffic Ops Delivery Service Name FQDN Validation

I'm submitting a ...

improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

Traffic Ops

Current behavior:
Traffic Ops validates that Delivery Service names (xmlId) don't contain spaces or periods:
https://github.com/apache/trafficcontrol/blob/6959ec/traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go#L1328
But it doesn't verify it's a valid FQDN component.
Traffic Portal does, but Traffic Ops doesn't.
There is specifically an interest in prohibiting underscores, which we use in Header Rewrite files, e.g. hdr_rw_mid_foo.config. As-is, if an untrusted person were allowed to make Delivery Services, they could create a Delivery Service named "mid_foo" in order to attack and manipulate a different Delivery Service. This isn't a huge issue today, without Self Service, but it will be if and when we ever get there. Adding the validation now prevents the future security issue.
New behavior:
Traffic Ops is changed to validate Delivery Service names to only contain alphanumeric and hyphen characters.
Minimal reproduction of the problem with instructions:
POST a new Delivery Service to Traffic Ops with underscores in the xmlID
Anything else:

Since the xmlID is only used to create the HOST_REGEXP w/ order = 0, which actually determines the delivery FQDN, we should also validate the HOST_REGEXP similarly. But since that is a regex, I don't know if we can really limit it to alphanumeric and hyphen characters.

Is this a duplicate of #3312? I know the title there is specifically about underscores, but it was the issue attached to the PR that added the validation to TP.

It looks like #3312 is a subset of this. I'd vote we close that in favor of this.

That's fine too


Automated cherry pick of #8925: feat(region): add SCloudregionResourceBase for SInstanceSnapshot

Cherry pick of #8925 on release/3.6.
#8925: feat(region): add SCloudregionResourceBase for SInstanceSnapshot

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.6@0a4ddb8). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/3.6    #8940   +/-   ##
==============================================
  Coverage               ?   17.82%
==============================================
  Files                  ?       88
  Lines                  ?     8857
  Branches               ?        0
==============================================
  Hits                   ?     1579
  Misses                 ?     7105
  Partials               ?      173

Flag
Coverage Δ

aFlag
17.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4ddb8...6cf67fd. Read the comment docs.


add a button to "select all" choices in dashboard dropdowns

Describe the Feature

Hi, I would love to work on this one. Can you plz assign this to me?

Hey @loki1205 :wave: apologies I did not see this comment before merging the PR for this! This is now closed with https://github.com/aws-amplify/discord-bot/pull/443, but I'd be happy to walk through other good first issues we have!


Optimizations in i2b2 <-> geco communications

Made the retrieval of the patient IDs optional in explore query
Only the IDs are now retrieved (not all the info)
Patched i2b2 to use the right modifier path when using i2b2 API to retrieve concepts
Implemented retrieval of observations through i2b2 API (but not used because it is very slow, to be seen if there is a way to improve the speed)
Implemented the retrieval of observation (direct access to the database) by using the patient set ID instead of patient IDs (no need to request and unmarhsal the patient IDs anymore)

Also survival query is now refactored not to retrieve patients


Feature/clean npm and repository

@marenpri92 was having issues with the version not having the dist folder

The build artifacts should not be on the repo - otherwise we would be pushing changes with every commit.


Split tiledbsc and tiledbsoma into branches [WIP]

main-v0 has tiledbsc
main has tiledbsoma

Miskeyed; will redo


proposal: crypto/tls: add support for exported authenticators

Proposal to implement support for exported authenticators in crypto/tls as described in draft-ietf-tls-exported-authenticator-10. I'm happy to write a CL for this.
cc @grittygrease @wbl

Hello @tatianab, this is not something we are likely to implement for the time being.

Go likes to wait until things mature and gain enough adoption to justify their complexity, and we basically never implement draft standards.

Before moving to a CL, we'd have to discuss what a safe and useful API looks like.

I haven't checked the draft in a long time, but I thought the point was to leverage the RFC 5705 exporters, which we already expose via ConnectionState.ExportKeyingMaterial, allowing this entire implementation to live outside the standard library.

crypto/tls stayed simple and robust over the years by implementing a tiny subset of the constellation of TLS features. When TLS 1.3 was new it was easy to maintain this tradition, but now that many additions are being proposed, we'll have to once again figure out what a useful minimal subset looks like.


react/socket greater than 0.4

Now react/socket available greater than 0.4 tagged version, please update your dependencies

Same problem here when trying to get it working with voryx\thruway. I had to do this in my composer.json:
"evenement/evenement": "2.*@dev",
"react/promise": "1.*@dev",
"react/stomp": "^0.2.0"

Srsly :)


[Tutorial] Add parameter shape check in 01 Vector Addition

Adding a sanity shape check a.shape == b.shape in add function seems good, since it raise a runtime error like RuntimeError: The size of tensor a (98433) must match the size of tensor b (98432) at non-singleton dimension 0 in torch.
Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.

[ ] I am not making a trivial change, such as fixing a typo in a comment.

[x] I have written a PR description following these
rules.

[ ] I have run pre-commit run --from-ref origin/main --to-ref HEAD.

Select one of the following.

[ ] I have added tests.

/test for lit tests
/unittest for C++ tests
/python/test for end-to-end tests

[x] This PR does not need a test because it adds a trivial check.

Select one of the following.

[x] I have not added any lit tests.
[ ] The lit tests I have added follow these best practices,
including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)

Thanks for sending a PR but we ask to refrain from sending trivial PRs that don't add direct value to the project.


Refactor wlr_list

Note: the only part of the code using wlr_list is the libinput backend.

This is ready for review.


objc2winmd binary update: Added support for marshaling NSURL

NSURL will now be marshalled as StorageFile or Uri or both depending on the type of annotations provided.

This change is

:shipit:


ASB-742: Align documents page with design

:tada: This PR is included in version 2.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[at-spi2-core] Build error

Fedora 37

OS: Linux
Compiler: gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install opencv
Failure logs

console output

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
    Command failed: /usr/bin/python3 /home/liuzw/vcpkg/installed/x64-linux/tools/meson/meson.py -Dintrospection=no --buildtype plain --backend ninja --wrap-mode nodownload --libdir lib --native /home/liuzw/vcpkg/buildtrees/at-spi2-core/meson-x64-linux-dbg.log -Ddebug=true --prefix /home/liuzw/vcpkg/packages/at-spi2-core_x64-linux/debug --includedir ../include -Dcmake_prefix_path=['/home/liuzw/vcpkg/installed/x64-linux/debug','/home/liuzw/vcpkg/installed/x64-linux'] /home/liuzw/vcpkg/buildtrees/at-spi2-core/src/ORE_2_44_1-fa40e2a5ad.clean
    Working Directory: /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/liuzw/vcpkg/buildtrees/at-spi2-core/config-x64-linux-dbg-meson-log.txt.log
      /home/liuzw/vcpkg/buildtrees/at-spi2-core/config-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:432 (vcpkg_execute_required_process)
  ports/at-spi2-core/portfile.cmake:13 (vcpkg_configure_meson)
  scripts/ports.cmake:147 (include)

failure log file

cat /home/liuzw/vcpkg/buildtrees/at-spi2-core/config-x64-linux-dbg-meson-log.txt.log

Build started at 2023-01-04T13:36:19.893521
Main binary: /usr/bin/python3
Build Options: -Dintrospection=no -Ddebug=true '-Dcmake_prefix_path=['"'"'/home/liuzw/vcpkg/installed/x64-linux/debug'"'"','"'"'/home/liuzw/vcpkg/installed/x64-linux'"'"']' -Dprefix=/home/liuzw/vcpkg/packages/at-spi2-core_x64-linux/debug -Dincludedir=../include -Dlibdir=lib -Dbackend=ninja -Dbuildtype=plain -Dwrap_mode=nodownload '--native-file /home/liuzw/vcpkg/buildtrees/at-spi2-core/meson-x64-linux-dbg.log'
Python system: Linux
The Meson build system
Version: 0.62.1
Source dir: /home/liuzw/vcpkg/buildtrees/at-spi2-core/src/ORE_2_44_1-fa40e2a5ad.clean
Build dir: /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg
Build type: native build
Project name: at-spi2-core
Project version: 2.44.1
Sanity testing C compiler: /usr/bin/cc
Is cross compiler: False.
Sanity check compiler command line: /usr/bin/cc sanitycheckc.c -o sanitycheckc.exe -fPIC -g -I/home/liuzw/vcpkg/installed/x64-linux/include -D_FILE_OFFSET_BITS=64 -L/home/liuzw/vcpkg/installed/x64-linux/debug/lib
Sanity check compile stdout:

-----
Sanity check compile stderr:

-----
Running test binary command: /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/sanitycheckc.exe
C compiler for the host machine: /usr/bin/cc (gcc 12.2.1 "cc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4)")
C linker for the host machine: /usr/bin/cc ld.bfd 2.38-25
Sanity testing C compiler: /usr/bin/cc
Is cross compiler: False.
Sanity check compiler command line: /usr/bin/cc sanitycheckc.c -o sanitycheckc.exe -D_FILE_OFFSET_BITS=64
Sanity check compile stdout:

-----
Sanity check compile stderr:

-----
Running test binary command: /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/sanitycheckc.exe
C compiler for the build machine: /usr/bin/cc (gcc 12.2.1 "cc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4)")
C linker for the build machine: /usr/bin/cc ld.bfd 2.38-25
Build machine cpu family: x86_64
Build machine cpu: x86_64
Host machine cpu family: x86_64
Host machine cpu: x86_64
Target machine cpu family: x86_64
Target machine cpu: x86_64
Pkg-config binary for 1 is not cached.
Pkg-config binary for 1 specified from cross file, native file, or env var as ['/bin/pkg-config']
Found pkg-config: /bin/pkg-config (1.8.0)
Determining dependency 'dbus-1' with pkg-config executable '/bin/pkg-config'
env[PKG_CONFIG]: /bin/pkg-config
env[PKG_CONFIG_PATH]: /home/liuzw/vcpkg/installed/x64-linux/debug/lib/pkgconfig/:/home/liuzw/vcpkg/installed/x64-linux/debug/share/pkgconfig/
Called `/bin/pkg-config --modversion dbus-1` -> 1

CMake binary for 1 is not cached
CMake binary for 1 specified from cross file, native file, or env var as ['/usr/bin/cmake']
Found CMake: /usr/bin/cmake (3.25.1)
Extracting basic cmake information
CMake Toolchain: Calling CMake once to generate the compiler state
Calling CMake (['/usr/bin/cmake']) in /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/__CMake_compiler_info__ with:
  - "--trace-expand"
  - "--trace-format=json-v1"
  - "--no-warn-unused-cli"
  - "--trace-redirect=cmake_trace.txt"
  - "-G"
  - "Ninja"
  - "-DCMAKE_TOOLCHAIN_FILE=/home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/__CMake_compiler_info__/CMakeMesonTempToolchainFile.cmake"
  - "."
  - "-DCMAKE_PREFIX_PATH=/home/liuzw/vcpkg/installed/x64-linux/debug;/home/liuzw/vcpkg/installed/x64-linux"
Try CMake generator: auto
Calling CMake (['/usr/bin/cmake']) in /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/cmake_dbus-1 with:
  - "--trace-expand"
  - "--trace-format=json-v1"
  - "--no-warn-unused-cli"
  - "--trace-redirect=cmake_trace.txt"
  - "-DCMAKE_TOOLCHAIN_FILE=/home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-private/cmake_dbus-1/CMakeMesonToolchainFile.cmake"
  - "."
  - "-DCMAKE_PREFIX_PATH=/home/liuzw/vcpkg/installed/x64-linux/debug;/home/liuzw/vcpkg/installed/x64-linux"
  -- Module search paths:    ['/', '/home/liuzw/vcpkg/installed/x64-linux', '/home/liuzw/vcpkg/installed/x64-linux/debug', '/opt', '/usr', '/usr/local']
  -- CMake root:             /usr/share/cmake
  -- CMake architectures:    []
  -- CMake lib search paths: ['lib', 'lib32', 'lib64', 'libx32', 'share']
Preliminary CMake check failed. Aborting.
Run-time dependency dbus-1 found: NO (tried pkgconfig and cmake)

../src/ORE_2_44_1-fa40e2a5ad.clean/meson.build:52:0: ERROR: Dependency "dbus-1" not found, tried pkgconfig and cmake

cat /home/liuzw/vcpkg/buildtrees/at-spi2-core/config-x64-linux-dbg-out.log
WARNING: Recommend using either -Dbuildtype or -Doptimization + -Ddebug. Using both is redundant since they override each other. See: https://mesonbuild.com/Builtin-options.html#build-type-options
The Meson build system
Version: 0.62.1
Source dir: /home/liuzw/vcpkg/buildtrees/at-spi2-core/src/ORE_2_44_1-fa40e2a5ad.clean
Build dir: /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg
Build type: native build
Project name: at-spi2-core
Project version: 2.44.1
C compiler for the host machine: /usr/bin/cc (gcc 12.2.1 "cc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4)")
C linker for the host machine: /usr/bin/cc ld.bfd 2.38-25
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /bin/pkg-config (1.8.0)
Found CMake: /usr/bin/cmake (3.25.1)
Run-time dependency dbus-1 found: NO (tried pkgconfig and cmake)

../src/ORE_2_44_1-fa40e2a5ad.clean/meson.build:52:0: ERROR: Dependency "dbus-1" not found, tried pkgconfig and cmake

A full log can be found at /home/liuzw/vcpkg/buildtrees/at-spi2-core/x64-linux-dbg/meson-logs/meson-log.txt

Additional context
I have already installed libxi-dev and libxtst-dev via the system package manager, but there is no such package called libdub-1 (there is a package called dbus-libs and it has already been installed)

comfirmed.

Follow the prompts to execute the following commands:
sudo apt-get install libdbus-1-dev libxi-dev libxtst-dev

Follow the prompts to execute the following commands: sudo apt-get install libdbus-1-dev libxi-dev libxtst-dev

Fedora has a different package manager (not apt)

sudo dnf install dbus-devel libXi-devel libXtst-devel

The vcpkg log puts libxi-dev and libxtst-dev as the required libraries - sudo apt install libxi-dev libxtst-dev resolved it for me


demo Run fild in mac

master branch now can not run, you can switch to the puppet-hostie branch, we will support the master branch as soon as possible.

@shuyabin
The puppet-hostie branch has been merged into master. If you have a hostile token, you can already test it. If you cannot succeed, you may get some help here.
#32

thanks
I want to know How  to apply   hostile token

To get a hostie token  you can apply for the donut alpha testers program at https://github.com/wechaty/wechaty/issues/1941


Fix edge case when transforming union collectible type

This fixes an edge case where a property may both be Collection<int, Product>|Collection<int, array>.
Steps for reproduction
use Spatie\LaravelData\Data;

class Person extends Data
{
    public function __construct(
        /** @var array<int, Pet>|array<int, array> */
        public array $pets,
    ) {
    }
}

class Pet extends Data
{
    public function __construct(
        public string $name,
    ) {
    }
}

$person = new Person(
    pets: [
        ['name' => 'Fido']
    ]
);

dd(json_encode($person));

This will produce the following error
TypeError: Spatie\LaravelData\Resolvers\TransformedDataCollectableResolver::Spatie\LaravelData\Resolvers{closure}(): Argument #1 ($data) must be of type Spatie\LaravelData\Contracts\BaseData, array given, called in vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php on line 72
vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php:108
vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php:72
vendor/spatie/laravel-data/src/Resolvers/TransformedDataCollectableResolver.php:49
vendor/spatie/laravel-data/src/Resolvers/TransformedDataResolver.php:164
vendor/spatie/laravel-data/src/Resolvers/TransformedDataResolver.php:66
vendor/spatie/laravel-data/src/Resolvers/TransformedDataResolver.php:37
vendor/spatie/laravel-data/src/Concerns/TransformableData.php:35
vendor/spatie/laravel-data/src/Concerns/TransformableData.php:55
Fix
Simply removing the typehint will return the original $data and fix the issue.

I'm not going to merge this in since we currently do not support multiple types like this. Though it seems like a simple fix, it actually removes a lot of context of these methods, there should always be a data object at this point.
In the future, when we support types like these, another path for transformation will be chosen, for now we keep it as is.


When a PR is open the golangci-lint job is running twice

Proposal for fix:
Only have the job run on pull_request into branch main as it doesn't really matter if the lint fails until it is trying to be merged into main

@whutchinson98 this was planned to be addressed in #46. Although it sets the job to run on push only for gitleaks, tests and linting.
My rationale for this was to get early feedback instead of discovering the potentially sizeable refactoring effort needed if left until the end. For instance, when the linter runs (if setup with valid options) it might pick up on a patterns that are discouraged. Having this feedback early will aid the developer to fix-on-fail instead of perhaps propagating the anti-pattern in multiple places and then having to fix a larger a codebase.
I'm also aware that this may get picked up locally via the pre-commit hook but it relies on the developer installing the hook so it not a guarantee.


[Test-Proxy] TLS validation cert setup not working in Python with Docker

When using the test proxy's recording options API, requests coming from Python aren't able to set a TLS validation certificate when using the test proxy via Docker. This issue was raised by Confidential Ledger, which has a test that tries to set a certificate that's fetched from the service: test code.
The same error is raised when using a PEM certificate that's used for test proxy tests, though this certificate is known to be problematic on Linux.
An example of error response (which is raised when certificate newlines are removed or not):
'Unable to instantiate a valid cert from the value provided in Transport settings key "TLSValidationCert".
Value: "-----BEGIN CERTIFICATE-----MIIBe[redacted]MZFq+9-----END CERTIFICATE-----".
Message: "ASN1 corrupted data.".'

When the "-----BEGIN/END CERTIFICATE-----" delimiters are removed, the error's Message is "No PEM encoded data found." instead.
This has been observed when using the Docker test proxy tool on WSL Ubuntu and Windows 11.

Thank you for filing the issue! You're the first folks to try these features against docker. I'm certain that if JS had been the first they would have also encountered this.
When debugging locally on a windows machine, the recording option sets just fine. Anecdotally, these operations also succeed in CI for azure-sdk-for net, which absolutely runs on a linux machine.
This makes me think the failure is specific to the docker image, but I will be digging into this today.


Decompile and Repack new Catsystem2 file "Binding Data.khe" UI images encryption

Game in question : https://vndb.org/r71356
When I'm using Garbro to extract Update01.int (contains .hg3 images for menu UI and gameplay UI parts of this visual novel series) >> It gave me one .fes file and one BindingData.khe which is encrypted in a new format .khe (can't be open or extract with any tools I found on internet )

What I want to request is can you make a simple tool to decompressing this new BindingData.khe file encryption >> into .hg3 image files ? I just want to translate the gameplay icons part to play more easily with Textractor or VNR
Thanks for reading

If you give me a download link to the files, I can try to take a look at it. But I don't have any guarantee of when (or if) I'll get around to it.
But... an CS2 unknown file format... that's kind of exciting ^ ^

Here is the link to the full game ( when I'm using Textractor I realized these new game use Catsystem3 and not 2 like Grisaia ,so maybe you should making new tools to translate this new series)
The normal version (package ver) don't have update01.int , only the Premium with full append DLC has these kind of file .Iguess this is dev new .khe encryption to protect their DLC assets . I hope you will crack this one and making a (easy to use) tool for fan translation scene !


Update ftdomdelegate to v5

Removals

Remove license related webpack config, as new version of ftdomdelegate changes the license.

Changes

Update ftdomdelegate to v5 (last maintained version)

Testing

PR checks should pass.

Hmmm looks like it can't find the new package: https://github.com/cfpb/design-system/actions/runs/3912578396/jobs/6687390238#step:5:121

Hmmm looks like it can't find the new package: https://github.com/cfpb/design-system/actions/runs/3912578396/jobs/6687390238#step:5:121

Thanks! Not quite sure what happened there. In my editor it resolved to a typescript type. I added the actual script name inside the package and that worked. I think maybe this needs to be main instead of browser so it works in a nodejs environment https://github.com/Financial-Times/ftdomdelegate/blob/master/package.json#L4
Moot point though as the ftdomdelegate project is archived. I want to rip the whole thing out.

Superceded by https://github.com/cfpb/design-system/pull/1561