error retrieving resource lock

The following error occurs when deploying v0.0.8
E1231 06:31:47.702125       1 leaderelection.go:325] error retrieving resource lock group-sync-operator/085c249a.redhat.io: leases.coordination.k8s.io "085c249a.redhat.io" is forbidden: User "system:serviceaccount:group-sync-operator:default" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "group-sync-operator"

This issue is being resolved by #61

Issue has been resolved

Issue has been resolved


ABNF Expressions: Remove mentions of message from the expression syntax for 1.0.*

An unfortunate left over from the draft phase was mentions of $message within the runtime expression section. This was there when AsyncAPI support was in scope.
In order to improve clarity we should tidy up the runtime expression syntax and wording to remove specifics related to AsyncAPI which will not be supported with 1.0.x specification versions.

Fix to be included in 1.0.1 release


Command configuration: global with overrides

It'd be great to have most, if not all, options in the CommandBuilder on the parser's Config, having the options set per-command override those on the parser.

Do you mean to have a config like config.global_case_sensitive(true) to skip adding it to every command?

Yes. Sensitivity is less likely to be something overridden, but later configurations could very well make this a hurting point in ergonomics.

This should still be relevant, unless I missed a commit that addressed this?

I think I will turn off that bot, because yeah this is still relevant

@Erk- Bless. Stale bots are very toxic

Commands no longer have builders. However, we now have #389 to rework the command parser as a whole, so this issue has been superseded by it


lost TSI reference / close TagValueSeriesIDIterator in error case [port to influxdb]

In cloud2 an issue with TagValueSeriesIDIterator losing a reference in an error case was fixed via 14876.
This issue is to evaluate the need of backporting the fix to appropriate OSS versions.

Ported to master, master-1.x, 1.10, and 1.9 branches.


[BugFix] Fix scalar subquery with const expression bug

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #5898 #5947 #5950 #5949 #5942
Problem Summary(Required) ：

AssertOneRowNode will fill NULL value if children output is empty, it's will cause expression evalution error, we can't push down predicate on AssertOneRowNode

[FE PR Coverage check]
:heart_eyes: pass : 21 / 21 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
5
5
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAssertOneRow.java
14
14
100.00%

@mergify backport branch-2.2

run ORCA

run starrocks_fe_unittest

[FE PR Coverage check]
:heart_eyes: pass : 22 / 22 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
5
5
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateAssertOneRow.java
14
14
100.00%

Predicates should not be pushed below assertOneNode, such as SQL: select * from t0 where 0 < (select v7 from t2); if t2 contains multiple rows, an error should be reported, and the push-down of redundant predicates may lead to loss of error information

You are right

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%

@Mergifyio backport branch-2.2

[FE PR Coverage check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%

[FE PR Coverage check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%

[FE PR Coverage check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%

[FE PR Coverage check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%

#5975

[FE PR Coverage check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/PruneAssertOneRowRule.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAssertOneRowOperator.java
1
1
100.00%

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFilterOperator.java
1
1
100.00%


Css variable in dev mode become shortened

🐞 Bug report
Command (mark with an x)

[x] build
[x] serve

Description
I'm using css variables for colors.
for example:
:root {
--s1-N-0-color: #FFFFFF;
}

in prod mode it become shortened;
:root {
--s1-N-0-color: #fff;
}

In dev mode is work as expected and it keep the hex as is.
🔬 Minimal Reproduction

Create a new angular cli project
Add to styles.scss

:root {
--s1-N-0-color: #FFFFFF;
}

server the project in dev mode
open the browser and in the dev tools you can see the hex color changed to #fff

🌍 Your Environment

Angular CLI: 11.0.5
Node: 12.3.1
OS: darwin x64

Angular: 11.0.5
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1001.2
@angular-devkit/build-angular   0.1100.5
@angular-devkit/core            11.0.5
@angular-devkit/schematics      11.0.5
@angular/cdk                    11.0.3
@angular/material               11.0.3
@nguniversal/express-engine     10.1.0
@schematics/angular             11.0.5
@schematics/update              0.1100.5
rxjs                            6.6.3
typescript                      4.0.5

This is expected since when using the "optimization" option CSS is compressed and one these compressions is to shorthand colors to remove redundant characters.
#FFFFFF is the same as #fff

This is expected since when using the "optimization" option CSS is compressed and one these compressions is to shorthand colors to remove redundant characters.
#FFFFFF is the same as #fff

@alan-agius4 the issue with this is we using this js code
getComputedStyle(document.documentElement).getPropertyValue(colorName)

and pass to a third party the hex color which is throw exception when we pass the  shorthand color
can I use the optimization with a flag that tell the cli not to include color shorthand?

@alan-agius4 the issue with this is we using this js code
getComputedStyle(document.documentElement).getPropertyValue(colorName)

and pass to a third party the hex color which is throw exception when we pass the  shorthand color
can I use the optimization with a flag that tell the cli not to include color shorthand?

can I use the optimization with a flag that tell the cli not to include color shorthand?

The only way to do it is to disable style optimizations completely. See: https://next.angular.io/guide/workspace-config#optimization-configuration
I suggest to open an issue with the author of the 3rd party library since it doesn't handle valid shorthand colors.

can I use the optimization with a flag that tell the cli not to include color shorthand?

The only way to do it is to disable style optimizations completely. See: https://next.angular.io/guide/workspace-config#optimization-configuration
I suggest to open an issue with the author of the 3rd party library since it doesn't handle valid shorthand colors.


Create use case diagrams according to use-cases

For each subsystem provided create a diagram with use cases.

Currently blocked until subsystems are not provided (#11)


Ingress Polishing

List:

[x] Add a column to flag "Default"
[x] Add the text "Default" to point to the default backend that's used similar to 2.4 UI

Edit:

[x] Move the default backend tab to be after rule

[x] Validation of the "target service" should be a tool tip and color

[x] Putting a "/" de-focuses

Style (Lauren):

The drop down of the "Namespace" shows background form, z-index change

View:

[x] Combine the rule and certs into one table instead of multiple boxes, need a name

[ ] Block component for Rules will need to make sure to follow the redesign that Lauren is doing. - #1737

[ ] Also while you are there can you fix: the drop-downs for Path as well, or work with Lauren to make sure component is correct?  They are opaque and I can't select anything from the first drop-down if there is a second one.
Path (Prefix)

[ ] Fix the spacing/Headers (work with Lauren/Tani to ensure all sections have headers & spacing is correct).  All pages.  But especially Labels & Annotations:

Pro-tips needs fixing as well (maybe work with Lauren for this?) -

[ ] The text is not centered for key=value or the key: value.
[ ] The highlight for those two also look weird in Light view.

[ ] Remove the word ProTip: - Seems redundant and just takes up space

Also while you are there can you fix: the drop-downs for Path as well, or work with Lauren to make sure component is correct? They are opaque and I can't select anything from the first drop-down if there is a second one.
Path (Prefix)

I believe this will be handled in https://github.com/rancher/dashboard/issues/1753. I'll make a note of it there.

@tfiduccia @lvuch
I updated spacing on the Labels and Annotations component. Are there any changes you'd like to see from this?

@tfiduccia do we actually want to support the code tags in the tooltip? Would em tags be acceptable?

On 2.5-head - commit id: 71da1569
List

Default column is available
Text "Default" to point to the default backend is available

Edit:
Default backend tab moved to be after rule

View:
Rule and certs combined into one table instead of multiple boxes, need a name

Spacing & prefix not fixed.  Other issues as well.  I'm closing this one and entered new issue #1875 with list.


Agent: re-enable bindings generation CI check

Fixes CODY-3809
Previously, we didn't automatically generate Kotlin bindings when making changes to the agent protocol. This was problematic because it meant that JetBrains, Visual Studio, and Eclipse teams need to manually write the bindings to stay updated with the latest Cody.
Now, we re-enable the CI check. In addition, the codegen tool also reports much more helpful errors now to increase the odds that a developer can work around codegen issues in the future when making changes to protocol types.
We have made a mistake in the past of leaking too many internal types into the protocol. This is problematic because internal types tend to lean heavily on advanced TypeScript typing techniques that are complicated to translate to other languages. Instead, we should start using more actively Protocol* named types, which mirror internal types but don't rely on advanced type machinery. This is a bit extra work on the agent side, but increases the odds we can keep the bindings generation enabled in CI. Internal types are regulary updated with features we don't need to care about in other IDE clients so this technique should also lower the burden on VSC changes to constantly run pnpm generate-agent-kotlin-bindings.
Test plan
Green CI.

Changelog

Closing this as superseded by #5854


fix(slider): emit events for home and end keys when appropriate.

Fixes #5123

please rebase

@mmalerba rebased


Feature: Benchmarking without a reference?

Reading the documentation made me wonder why the __benchmarks__ entries are tuples with two functions a and b. Apparently this assumes that a benchmark always has to be performed against some kind of reference?
I'm wondering if the framework can be easily adapted to use cases where one doesn't have such a reference function. Say, I just to benchmark sort_three without the kind of arbitrary sort_seven reference.
Is this already supported somehow?

no that's not currently supported.
Just so I understand, would you run all the benchmarks with no comparison function? You're only interested in min, max and mean?
I could change the code to look at the length of the tuple and not run a comparator test if there isn't a second benchmark defined. It would get tricky if some did and some didn't (with the table output)

Just so I understand, would you run all the benchmarks with no comparison function? You're only interested in min, max and mean?

Yes that would already suffice (perhaps trimmed mean / median).
What I had in mind is a workflow as offered by frameworks like e.g. criterion.rs in Rust. By default they just measure the test cases as defined. Internally they also offer comparison to the last execution or also explicitly saved snapshots. This can be helpful to e.g. benchmark before/after an optimization or refactoring for comparison. Or to track the longer term performance development of a project to see how things evolve over time when e.g. dependencies change (by committing these snapshot files into git).
This internal diffing isn't super important though, because a lot can already be achieved by doing manual before/after or snapshot runs. Thanks to the beautiful output in the form of a table, once could for instance simply take the output and append it to some benchmarks_log.txt committed to git, which would also nicely document the performance evolvement of a project.

ASV (airspeed velocity) might suit your requirements, it has a database, web UI and a ton of other tools. Some big data science libraries (iirc Pandas inc) use it.
https://asv.readthedocs.io/en/stable/using.html

Yes indeed, ASV is pretty nice! In certain use cases something more lightweight like rich-bench is a nice alternative though due to its simplicity.


How ro calculate the model size and flops in NAS project?

I want to use NAS method to search a resource-aware model, but for each step, the mutator generates a new model structure so that it is not easy to calculate the generated model size, especially flops. Is any possible and easy way to implement this? Thanks!

Hi @marsggbo. Thanks for raising this issue.
For parameter size, because NNI builds a supernet for training, you may experience issues if you directly use model.parameters() which will count every parameter even if some of them is not used. This issue will be addressed later in NNI framework. For now, a simple workaround is to dry run and do back-propagation and count the parameters used. e.g.,
def param_size(model, loss_fn, input_size):
    """
    Compute parameter size in MB
    """
    x = torch.rand([2] + input_size).cuda()
    y = model(x)
    target = torch.randint(model.n_classes, size=[2]).cuda()
    loss = loss_fn(y, target)
    loss.backward()
    n_params = sum(np.prod(v.size()) for v in model.parameters() if v.grad is not None)
    return n_params / 1e6

As for FLOPS, calculating FLOPS doesn't have native support in PyTorch. You need to consort to tools like torchscope.

while a straightforward way to implement it is to define a "sample" function in your model, like:
...
     def forward(self, x):
         return self.classifier(self.tail(self.mid(self.stem(x))).flatten(1))

     def sample(self, mutator, no_els=False):
         mid = nn.Sequential([
             for i in range(len(mid))
         ])
         mid = []
         for i in range(len(mid)):
             m = mid[i][mutator._cache[mid[i].key]]
             if no_els and isinstance(m, ConvELS):
                 continue
             mid.append(m)
         mid = nn.Sequential(*mid)

         class S(nn.Module):
             def __init__(selff):
                 super(S, selff).__init__()
                 selff.stem = self.stem
                 selff.tail = self.tail
                 selff.mid = mid
                 selff.classifier = self.classifier
             def forward(selff, x):
                 return selff.classifier(selff.tail(selff.mid(selff.stem(x))).flatten(1))
         return S()

The good thing is that you can choose the specific sample method. In my case, I need to change "ConvELS" module to "Identity" in some training phrase

@marsggbo @CuriousCat-7 I‘m closing this issue as it has no updates from user for 3 months, please feel free to reopen if you are still seeing it an active issue.


Figure out a way to not inline the scripts

I had to inline the vendor scripts as Electron only supports preloading one script. We need to figure out a better way or fix the Electron bug (https://github.com/electron/electron/issues/5400).
@paulmolluzzo @danhp Thoughts?

I know I can load the next ones async inside the first preloaded script, but that get's convoluted fast.

What if we concatenate specific files and preload only that generated file?


Unable to resize an image with FS selected file store

I would like to resize the uploaded image before saving it to FS File collection using Filestore parameters.
I created two FS file stores and a FS file collection. When I insert a FS file with specific store name to collection, it always saves the image with default store value. Can you guys please help me with selecting a FS file store dynamically ?
// Create FS file with specific File Store
var fsFile = new FS.File(file, {store: 'testimages'});
// Insert file to database
AdImage.insert(fsFile);
// Image File collection
AdImage = new FS.Collection('ad_image', {
stores: [thumblinePhotosStore, testPhotosStore],
filter: {
allow: {
contentTypes: ['image/*'] //allow only images in this FS.Collection
}
}
});
// Image store properties to crop and resize image before saving it to collection
thumblinePhotosStore = new FS.Store.FileSystem('images', {
path: chroot_ad,
beforeWrite: function(fileObj) {
return {
extension: 'png',
type: 'image/png'
};
},
transformWrite: function(fileObj, readStream, writeStream) {
// Transform the image into a 10x10px PNG thumbnail
debugger;
gm(readStream, fileObj.name()).resize(200, 200, '!^').stream().pipe(writeStream);
}
});
testPhotosStore = new FS.Store.FileSystem('testimages', {
path: chroot_ad,
beforeWrite: function(fileObj) {
return {
extension: 'png',
type: 'image/png'
};
},
transformWrite: function(fileObj, readStream, writeStream) {
gm(readStream, fileObj.name()).resize(100, 100, '!^').stream('PNG').pipe(writeStream);
}
});

As per the API, you can't specify a store when constructing an FS.File. are What's the use case?


Module not Found

react-moment-proptypes Module is not found.

I've rewritten the component in React 16 and reviewed all dependencies. This problem should have been fixed on 0.4.0.


Changing font size doesn't influence some texts from the app

The following texts sizes don't change when editing the global font size setting:

page title (from page details)
"Comments" and "Leave a comment" titles
comments (author, date, comment text)
side menu items

Regarding the page title, can we also make the default size larger?

page title(from page details) font size is fixed to keep alignment with the close button.

"Comments" and "Leave a comment" titles font-size is fixed to contain font to fixed height topBar.

comments (author, date, comment text). Author and date are fixed to maintain alignment to fixed height, width imageAvatar. Can't reproduce this for comment text.

side menu items fixed font-size. Some elements in the sideMenu are constrained to a fixedHeight, so to maintain consistency between items that have a fixedHeight and items that don't, this decision was taken where font-sizing shouldn't affect the sideMenu.

fix pageDetails title height after discussion


Update assets submodule

Description
This PR updates the assets submodule to the latest commit, which contains the assets required for the recently merged dynamic rendering local read sample. No code changes.
Fixes #1163
General Checklist:
Please ensure the following points are checked:

[ ] My code follows the coding style
[ ] I have reviewed file licenses
[ ] I have commented any added functions (in line with Doxygen)
[ ] I have commented any code that could be hard to understand
[ ] My changes do not add any new compiler warnings
[ ] My changes do not add any new validation layer errors or warnings
[ ] I have used existing framework/helper functions where possible
[ ] My changes do not add any regressions
[ ] I have tested every sample to ensure everything runs correctly
[ ] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

[ ] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

[ ] I did a full batch run using the batch command line argument to make sure all samples still work properly

Merging this as it's urgent. Without this, the dynamic rendering local read sample can't run.


The documentation is wider on small devices than on medium

This is related to Bootstrap's grid options, so I'm using their definitions: a small device is ≥768px, medium ≥992px and large ≥1200px.
Take a documentation page and change the width of your browser window. Once you go below 992 pixels, the main content becomes wider rather than narrower. Medium is set to 8 columns and small to 12 columns.
Also, the navbar search box is strangely displaced in the medium view, but aligned in small and large.

Good catch, thanks! Should be fixed in https://github.com/cppformat/cppformat/commit/caa8f76a88f644881b73d944ad73afeab7e2dabe and online.


Not understanding _includes and post_url...

Hi,
Just want to point out a few things I might not be understanding. From the wiki for Liquid Extensions, I see I could include textile formats so I was assuming I could also created files in markdown format. I created _includes/test.markdown and added {% include test.markdown %} on my index.html although after running jekyll it simply just included file without converting to html. Also added {% post_url 2010-07-21-name-of-post %} in my index.html but nothing printed out. Any help appreciated, thanks!

When you include a file the contents of the file are literally inserted as is.  Since index.html isn't considered a markdown file Jekyll does not render the markdown.

Are you sure you actually have a post called 2010-07-21-name-of-post in _posts?  I would assume not since it is 2012...

Oh cool. Makes sense now, thanks.

Yep, I migrated old posts from my blog over to jekyll. It seems the template data are not being parsed anymore. After adding {% post_url 2010-07-21-name-of-post %}, values are not what they're supposed to be. All I see then are {% for post in site.categories.blog %} or {{ post.title }}.


Ufs read metrics are not updated in k8s

Alluxio Version:
2.0.0-RC4
Describe the bug
$ alluxio fsadmin report metrics
Total IO:
Under Filesystem Read <- this is always zero
To Reproduce

deploy alluxio on k8s
exec into master pod
cat a persisted file with 0% in alluxio storage

ufs read metrics are not updated
Expected behavior
ufs read io should match the file size
Urgency
not urgent
Additional context
not reproducible with on a local machine deployment (no containers or k8s)

The issue should be fixed with #9652.


Make transistion from git submodules easier

Below the scenarios, DFetch  should provide documentation or a HowTo guide for the below, or test that it is possible
Background:
  Given you have a project with submodules
  And you have created a manifest with "dfetch import"
  And you have removed the submodules
  And committed everything on a branch "use-dfetch"

Scenario: Switching from branch with dfetch to without
    Given you are on branch "use-dfetch"
    When you checkout "master"
    Then git should switch without issues

Scenario: Switching from branch without dfetch to with
    Given you are on branch "master"
    When you checkout "use-dfetch"
    Then git should switch without issues

See here for a description of the problem: https://ryansechrest.com/2014/03/git-error-switching-branch-replacing-directory-submodule/

With submodule --> dfetched branch
When switching from branch with submodules to branch without git will warn about overwriting.
$ git checkout feature/use-dfetch
error: The following untracked working tree files would be overwritten by checkout:
    MySubmodule/somefile.c
    MySubmodule/someotherfile.c

But git status will show nothing:
$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

Solution
Remove submodule folder & checkout branch
$ rm -rf MySubmodule
$ git checkout feature/use-dfetch

With dfetched branch --> submodule branch
Gives no problem, but  submodules are gone and need to be initialized again
Solution
$ git checkout master
$ git submodule update --init
Submodule path 'MySubmodule': checked out '08f95e01b297d8b8c1c9101bde58e75cd4d428ce'


Change display of RepartitionExec from SortPreservingRepartitionExec to RepartitionExec preserve_order=true`

Is your feature request related to a problem or challenge?
Most (all?) nodes in DataFusion explain plans have the property that they are displayed with the same name as the struct that implements them, which makes matching explain plans to code easy
However, a notable exception is RepartitionExec which is displayed sometimes as  RepartitionExec and sometimes as  SortPreservingRepartitionExec to signify it preserves the input sort order, which makes finding the relevant code harder (as there is no such code as SortPreservingRepartitionExec)
For example in the following plan RepartitionExec and SortPreservingRepartitionExec` are the same ExecutionPlan node:
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| plan                                                                                |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| SortPreservingMergeExec: [cpu@2 ASC NULLS LAST,time@1 ASC NULLS LAST]                                                                                |
|   SortExec: expr=[cpu@2 ASC NULLS LAST,time@1 ASC NULLS LAST]                                                                                |
|     ProjectionExec: expr=[cpu as iox::measurement, time@0 as time, cpu@1 as cpu, coalesce(P@2 / 99.99, 0) as P]                                                                                |
|       RepartitionExec: partitioning=RoundRobinBatch(16), input_partitions=16                                                                                |
|         ProjectionExec: expr=[time@1 as time, cpu@2 as cpu, (selector_max(cpu.usage_system,cpu.time)@3).[value] as P]                                                                                |
|           CoalesceBatchesExec: target_batch_size=8192                                                                                |
|             FilterExec: AVG(cpu.usage_idle)@4 > 0.5 AND AVG(cpu.usage_idle)@4 < 1.5 AND (selector_max(cpu.usage_system,cpu.time))[value]selector_max(cpu.usage_system,cpu.time)@0 > 0 AND (selector_max(cpu.usage_system,cpu.time))[value]selector_max(cpu.usage_system,cpu.time)@0 < 1                                                               |
|               ProjectionExec: expr=[(selector_max(cpu.usage_system,cpu.time)@2).[value] as (selector_max(cpu.usage_system,cpu.time))[value]selector_max(cpu.usage_system,cpu.time), time@0 as time, cpu@1 as cpu, selector_max(cpu.usage_system,cpu.time)@2 as selector_max(cpu.usage_system,cpu.time), AVG(cpu.usage_idle)@3 as AVG(cpu.usage_idle)] |
|                 AggregateExec: mode=FinalPartitioned, gby=[time@0 as time, cpu@1 as cpu], aggr=[selector_max(cpu.usage_system,cpu.time), AVG(cpu.usage_idle)], ordering_mode=PartiallyOrdered                                                                                |
|                   CoalesceBatchesExec: target_batch_size=8192                                                                                |
|                     SortPreservingRepartitionExec: partitioning=Hash([time@0, cpu@1], 16), input_partitions=16, sort_exprs=cpu@1 ASC                                                                                |
|                       AggregateExec: mode=Partial, gby=[date_bin(10000000000, time@1, 0) as time, cpu@0 as cpu], aggr=[selector_max(cpu.usage_system,cpu.time), AVG(cpu.usage_idle)], ordering_mode=PartiallyOrdered                                                                                |
|                         RepartitionExec: partitioning=RoundRobinBatch(16), input_partitions=1                                                                                |
|                           ProjectionExec: expr=[cpu@1 as cpu, time@3 as time, usage_idle@4 as usage_idle, usage_system@5 as usage_system]                                                                                |
|                             DeduplicateExec: [cpu@1 ASC,host@2 ASC,time@3 ASC]                                                                                |
|                               SortExec: expr=[cpu@1 ASC,host@2 ASC,time@3 ASC,__chunk_order@0 ASC]                                                                                |
|                                 CoalesceBatchesExec: target_batch_size=8192                                                                                |
|                                   FilterExec: time@3 <=<PHONE_NUMBER>099501000                                                                                |
|                                     RecordBatchesExec: chunks=1, projection=[__chunk_order, cpu, host, time, usage_idle, usage_system]                                                                                |
|

Describe the solution you'd like
I would like to change the display of RepartitionExec so it always looks like RepartitionExec and has preserve_order=true to follow the same pattern as the other nodes where the output of the explain plan matches the name of the code that implements it.
So for example, name should always be RepartitionExec: https://github.com/apache/arrow-datafusion/blob/91c9d6f847eda0b5b1d01257b5c24459651d3926/datafusion/physical-plan/src/repartition/mod.rs#L373-L379
And instead of
 SortPreservingRepartitionExec: partitioning=Hash([time@0, cpu@1], 16), input_partitions=16, sort_exprs=cpu@1 ASC

It should display like
 RepartitionExec: partitioning=Hash([time@0, cpu@1], 16), input_partitions=16, preserve_order=true, sort_exprs=cpu@1 ASC

Describe alternatives you've considered
I recommend ONLY displaying preserve_order when it is true
so when false, display like this:
RepartitionExec: partitioning=RoundRobinBatch(16), input_partitions=16

Additional context
I think this is a good first issue as it is well specified and a mechanical change and would teach the person about datafusions tests. Beware, however, that this is likely to require a non trivial number of changes to expected test output.
Thanks in advance!

FYI @ozankabak  and @mustafasrepo  and @metesynnada  as this may impact you

I wouldn't mind taking a look into this

We are fine with this change

Thanks @JacobOgle !

Should this be closed now that https://github.com/apache/arrow-datafusion/pull/8521 is merged?
Looks like the PR description simply mis-formatted the Close #123 statement so it didn't auto-close.

Closed by #8521


fix: publishing plugin with public access

I was getting an error when publishing @graphql-gene/plugin-sequelize because it seems like organization packages are treated as private package by default. We need to explicitly set the access to "public".
See https://stackoverflow.com/a/59711239/1895428

:tada: This PR is included in version graphql-gene-v1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @graphql-gene/plugin-sequelize-v1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Regression] pilot upload fails in 2.69.0: private method 'include' called for Array:Class (NoMethodError)

New Issue Checklist

[✔] Updated fastlane to the latest version
[✔] I read the Contribution Guidelines
[✔] I read docs.fastlane.tools
[✔] I searched for existing GitHub issues

Issue Description
I submit app builds to TestFlight through Visual Studio Team Services continuous integration, which uses Fastlane. The CI system is set up to automatically update Fastlane if an update is available for each release. That's how I found this regression.
Yesterday, the release worked fine. Checking the logs, I found that testflight version 2.68.2 was used then. Today's release failed (it had updated TestFlight to 2.69.0).  It reliably fails each time on this new version.
Note: in the meanwhile, I have configured the CI system to force Fastlane version 2.68.2 for now to work around this issue.
Here's the command the CI system runs, and the failing output, when using Fastlane 2.69.0.
Complete output when running fastlane, including the stack trace and command used
fastlane pilot upload -u ******** -i /Users/*******/buildagent/_work/r5/a/*******/ios_release/******.ipa -a com.*****.******* --skip_waiting_for_build_processing true
fastlane pilot upload -u ******** -i /Users/*******/buildagent/_work/r5/a/*******/ios_release/******.ipa -a com.*****.******* --skip_waiting_for_build_processing true
2017-12-12T23:42:13.4643610Z /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:17:in `block in <top (required)>': private method `include' called for Array:Class (NoMethodError)
2017-12-12T23:42:13.4743770Z 	from /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:14:in `each'
2017-12-12T23:42:13.4846830Z 	from /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:14:in `<top (required)>'
2017-12-12T23:42:13.4945890Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5052070Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5149200Z 	from /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb:2:in `<top (required)>'
2017-12-12T23:42:13.5179650Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5209300Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5236760Z 	from /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core.rb:19:in `<top (required)>'
2017-12-12T23:42:13.5266310Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5295180Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5325740Z 	from /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/fastlane/lib/fastlane.rb:1:in `<top (required)>'
2017-12-12T23:42:13.5357100Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5396980Z 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in `require'
2017-12-12T23:42:13.5427300Z 	from /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/fastlane/lib/fastlane/cli_tools_distributor.rb:18:in `take_off'
2017-12-12T23:42:13.5457120Z 	from /Users/xamarin/.gem-cache/gems/fastlane-2.69.0/bin/fastlane:20:in `<top (required)>'
2017-12-12T23:42:13.5484290Z 	from /usr/local/bin/fastlane:23:in `load'
2017-12-12T23:42:13.5510660Z 	from /usr/local/bin/fastlane:23:in `<main>'
2017-12-12T23:42:13.5714150Z ##[error]Error: fastlane failed with return code: 1

Environment

(I can't easily run this command since Fastlane is run through a continuous integration system. Let me know if you need this and I'll figure out a way.)

I have the same issue. Yesterday was working, today I updated to last version and now it is not working giving the following error:
/Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:17:in block in <top (required)>': private method include' called for Array:Class (NoMethodError)
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:14:in each' 	from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:14:in <top (required)>'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb:2:in <top (required)>' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require' 	from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core.rb:19:in <top (required)>'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/fastlane/lib/fastlane.rb:1:in <top (required)>' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require'
from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:73:in require' 	from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/fastlane/lib/fastlane/cli_tools_distributor.rb:18:in take_off'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.69.0/bin/fastlane:20:in <top (required)>' 	from /usr/local/bin/fastlane:23:in load'
from /usr/local/bin/fastlane:23:in `'

I just started investigating this, sorry about the issues! It seems to come from an older version of ruby (that we still support). I double checked the documentation for ruby and the method should exist, so this was likely a bug that got fixed in a later version. I'm exploring alternative options for the code that's failing now

@MikePaer @cbo1964 What system versions are you using? Am I correct to assume that both of you are using the system ruby?

I can confirm the issue. Started showing up like 10 hours ago on our jenkins machine. Probably someone updated fastlane.
workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:17:in block in <top (required)>': private method include' called for Array:Class (NoMethodError) 	from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:14:in each'
from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb:14:in <top (required)>' 	from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb:2:in require'
from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb:2:in <top (required)>' 	from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core.rb:19:in require'
from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane_core/lib/fastlane_core.rb:19:in <top (required)>' 	from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane/lib/fastlane.rb:1:in require'
from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/fastlane-2.69.0/fastlane/lib/fastlane.rb:1:in <top (required)>' 	from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/trainer-0.7.0/lib/trainer.rb:1:in require'
from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/trainer-0.7.0/lib/trainer.rb:1:in <top (required)>' 	from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/trainer-0.7.0/bin/trainer:4:in require'
from /Users/jenkins/.jenkins/jobs/DEP/jobs/iOS_PullRequester_RD/workspace/gems/ruby/2.0.0/gems/trainer-0.7.0/bin/trainer:4:in <top (required)>' 	from ./bin/trainer:21:in load'
from ./bin/trainer:21:in <main>' osxbuildserver:workspace jenkins$

I just submitted a PR #11202 that should fix this issue.
If you don't want to wait until this is released, you can try my branch by using a Gemfile. Create a Gemfile in your project directory:
gem "fastlane", github: "milch/fastlane", branch: "regression/fix-plist-for-old-rubies"

Make sure to install bundler if you don't have it already. Then, in your command line, run bundle install and you will be able to run fastlane by using bundle exec:
bundle exec fastlane frameit

To get back to a regular release version of fastlane you can simply remove the Gemfile, or remove the github and branch parameters from the Gemfile I presented above to read:
gem "fastlane"

If you removed the Gemfile simply remove the bundle exec from your fastlane commands. Otherwise you can re-run bundle install after you've made the above edits.
Let me know if you have any questions!

Thanks @milch for the fast fix! For now I've downgraded to 2.68 but it's good to have an alternative until the fix gets merged!

Hi,
sorry but I'm not expert enough to change my fastlane configuration to test your fix.
By the way, I could I downgrade to previous version ?

@cbo1964 If you installed fastlane via rubygems, you can do that by running gem install --version 2.68.0 fastlane. The new version should be released shortly though

many thanks
Claudio

On 13 Dec 2017, at 16:25, Manu Wallner<EMAIL_ADDRESS>wrote:
@cbo1964 https://github.com/cbo1964 If you installed fastlane via rubygems, you can do that by running gem install --version 2.68.0 fastlane. The new version should be released shortly though
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/fastlane/fastlane/issues/11199#issuecomment-351424153, or mute the thread https://github.com/notifications/unsubscribe-auth/ARdiH0B_UFonJcLxroqph4qoL8U3-Newks5s_-x7gaJpZM4Q_0Hf.

Hey everyone! As you might've seen we've released 2.69.1 a couple hours ago. Let me know if you have any more issues with this.

Hi,
I just tested it. It works.
Many thanks
Claudio

On 13 Dec 2017, at 18:03, Manu Wallner<EMAIL_ADDRESS>wrote:
Hey everyone! As you might've seen we've released 2.69.1 a couple hours ago. Let me know if you have any more issues with this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/fastlane/fastlane/issues/11199#issuecomment-351455584, or mute the thread https://github.com/notifications/unsubscribe-auth/ARdiHyF9udCD8DYA0_IQ506_d6ltlNEeks5tAAN1gaJpZM4Q_0Hf.


Handle storage partition assignment as part of Verify cli.

This PR verifies storage partition assignment on ZooKeeper and partition assignment on the storage nodes. Also check if quorum can be achieved for a partition or not.

@ymatsuda @patrickghannage @abhipardhu
Removed merge conflict and made few changes to ClusterCli.Verify. Please review the new changes.


changed version to 0.10.0-alpha.1

What type of PR is this?
Add one of the following kinds:

subproject management

What this PR does / why we need it:
First upload of YAML from previous Edge Cloud sub-project, incorporating the scope of Simple Edge Discovery for Fall 24  Release #3
Which issue(s) this PR fixes:

Fixes issue 3 (which will remain pinned/open as it relates to the release scope )
Special notes for reviewers:
Changelog input
 release-note
 Incorporates the changes listed in  #3

Additional documentation
This section can be blank.
docs

@Kevsy two options here:

This is already the PR which creates the alpha release. Then it should contain the CHANGELOG.md and the change to the README. Please add in the CHANGELOG also the link to the YAML within EdgeCloud (the exact commit which you have copied (I suppose that is https://github.com/camaraproject/EdgeCloud/blob/ed32560de80e55943d67766a040962df54d5498b/code/API_definitions/Discovery/simple_edge_discovery.yaml)
In this case you have to set also the URL to simple-edge-discovery/v0.10alpha.1

Recommend: you use this PR only to transfer the YAML and doing a release PR after some correction. Then the version both in version field and the URL would be "wip".

Thanks @hdamker ,

@Kevsy two options here:

Recommend: you use this PR only to transfer the YAML and doing a release PR after some correction. Then the version both in version field and the URL would be "wip" for now.

Done

Need to be aligned with the version number.

Done

These lines are producing a linting error as they are not intended.

Done, removed
Also removed the release tag.

Looks good to me. Perhaps you want to include the SED.test file since both files are in the Edge Cloud repository or do you want to wait for Commonalities 0.4 to upload all the necessary documents?

Thanks @javierlozallu  - I'll make a separate PR for that, and probably wait for the Commonalities v0.4 which will  confirm the  instructions in https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Testing-Guidelines.md


Add favicon

Favicon is showing on dev server. Not showing on production for some reason. Need to look into it

It is showing now


Issues while comparing SQL and MDX query

I'm having issues while comparing an SQL and MDX query. I'm receiving the following error:
NBi.NUnit.Runtime.TestSuite.Compare two query results:
System.AggregateException : One or more errors occurred.
----> System.Data.SqlClient.SqlException : Incorrect syntax near the keyword 'on'.
Both queries are fully functional on the SQL server but I can't seam to get them to work in NBI.
<?xml version="1.0" encoding="utf-8"?> <testSuite name="Dupa testSuite" xmlns="http://NBi/TestSuite"> 	<test name="Compare two query results"> 	  <system-under-test> 		<execution> 			 <query connectionString="Server=.;Database=Gas;User Id=###;Password=######;"> 			select Sum([Nominated_exit]) AS [NominatedExit] from ( 			select 	SUM([Nominated_exit]) AS [Nominated_exit] from NominationsPerNetworkpoint_Julianadorp 				union 			select 	SUM([Nominated_exit]) AS [Nominated_exit] from NominationsPerNetworkpoint_Other 			) AS [NominatedExit] ;	  		</query>	 		</execution> 	  </system-under-test> 	    <assert> 		<equalTo> 		<column  index="0" role="value" type="numeric" tolerance="0.1"/> 		 <query name = "mdx" connectionString="Server=.;Database=Gas_DW;User Id=###;Password=######;">	  		SELECT [Measures].[Nominated Exit] AS [NominatedExit] on 0  FROM [Gas DW]  ; 		  </query> 		 </equalTo> 	  </assert> 	</test> </testSuite>
I'm probably making a shameful mistake but if anyone could help me out it would be extremely appreciated.

Does the MDX-query really work like that?
Otherwise try
WITH MEMBER [NominatedExit] AS [Measures].[Nominated Exit] SELECT [Measures].[NominatedExit] on 0 FROM [Gas DW]

Yes the MDX works perfect on the SQL server Management studio.
When using "WITH MEMBER" it still works fine in Management studio but it generates an extra syntax error in NUnit.
I've tried everything that I could find online and I'm completely out of ideas.
I'm using this framework for my internship and it has been very useful but with my deadline approaching this is the only real problem that I have left.

The connection string for the assertion is not recognised as an SSAS connection string.
change it and it will fix your issue.

Thanks for helping me out, I knew it was a shameful mistake.
And thanks for making this framework it really helped me a lot!


bug when grid in scrollable container

  [x] bug
  [ ] feature request
  [ ] enhancement

Expected behavior
usual behavior in a scrollable container
Actual behavior
In scrollable container when scrollTop is bigger than 0, dragging ghost jump up for scrollTop value.
Posible fix
in ngx-widget-grid.js in NgxWidgetMoverDirective.prototype.onMove method
 var scrollLeft = window.pageXOffset || document.documentElement.scrollLeft, scrollTop = window.pageYOffset || document.documentElement.scrollTop;
desiredPosition.top = Math.min(Math.max(dragPositionY - this.moverOffset.top + scrollTop, 0), gridDimensions.height - startRender.height+ scrollTop - 1);
desiredPosition.left = Math.min(Math.max(dragPositionX - this.moverOffset.left + scrollLeft, 0), gridDimensions.width - startRender.width + scrollLeft - 1);

Video of behavior
https://drive.google.com/file/d/1036t40UCISyRpJ1PMvXy9_1iyxlbNcF1/view?usp=sharing
Environment details

Angular version: 5.2.x

OS and version:

Browser: [Chrome]

did you fix it https://github.com/valuta777

@DBHATT014 now it's fixed locally in my solution, I'm waiting for a new release
widgetMover.directive.ts 119-121
 var scrollLeft = window.pageXOffset || document.documentElement.scrollLeft, scrollTop = window.pageYOffset || document.documentElement.scrollTop;
      desiredPosition.top = Math.min(Math.max(dragPositionY - this.moverOffset.top + scrollTop, 0), gridDimensions.height - startRender.height + scrollTop - 1);
      desiredPosition.left = Math.min(Math.max(dragPositionX - this.moverOffset.left + scrollLeft, 0), gridDimensions.width - startRender.width + scrollLeft - 1);

i tried 1st 1 fix and its working fine  thanx

@envyN do you have this on your radar? do you think @valuta777 solution is fine and would you accept a pull request with that code?


Bad rendering in dark mode.

Description
It appears as dark gray and the text (white) is barely visible.
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
d166e00f-d0ca-4336-b8e7-be0e8c4b740c
Paper URL
https://arxiv.org/html/2412.01708v1
Browser
Firefox/133.0
Device Type
Desktop


Tetsuya Yamamoto: Watch wolkwill.com

Tetsuya Yamamoto requests the watch of the watch_keyword wolkwill.com. See the Metasmoke search here and the Stack Exchange search here.

Coverage remained the same at 63.155% when pulling eddd468d87ce48467f309174381cdec100a860da on auto-blacklist-1512542914.379551 into 603e3b138c38f70fd331472b30be160ddf598605 on master.

!!/approve


Vim highlight search show wrong visual range

@Yukaii Thanks for reporting. What version of extension are you using? Did you do anything before in this file?

NVIM v0.4.3
extension: 0.0.34
And maybe it's caused by my lots of vim plugins 😅  , I'll try to disable some of them and report it here.

Also the visual selection doesn't work as VSCode, it should only display active cursor at ends.

Also the visual selection doesn't work as VSCode, it should only display active cursor at ends.
This is extension addition - visual line/block modes spawn multiple cursors. I may put it under a conf flag later

I found that it's set number config causing this.

Thank you for your research. If you'll find anything else which breaks extension - don't hesitate to send a PR to reset the value here


Material UI import results in broad inclusion of packages

In https://github.com/alexplumb/material-ui-phone-number/blob/master/src/components/index.jsx the following code results in the entire material ui library being included as a dependency
import {
  TextField, InputAdornment, Button, Menu, Divider, RootRef,
} from '@material-ui/core';

Ideally this would only include the desired components and the material ui folks could probably make that better....but for now if you include explicitly the size of the install package would be greatly reduced.
import Button from '@material-ui/core/Button';
import Divider from '@material-ui/core/Divider';
import InputAdornment from '@material-ui/core/InputAdornment';
import Menu from '@material-ui/core/Menu';
import RootRef from '@material-ui/core/RootRef';
import TextField from '@material-ui/core/TextField';

These packages were already being excluded from the build thanks to webpack, but I've gone ahead and made this change in 2.0.0 just to be more explicit. Thanks!


remove shovels

A picture tells a thousand words
Before this PR

After this PR

Coverage increased (+0.03%) to 44.189% when pulling f2adc46552b5e1a23ad693c9c9a3251e8dad1fd6 on removeShovel into 79fc5389336d07064e484f85a60c08abadd0a8e9 on master.


Restore Style relate to issue #38

After bug #38 resolved, the style that related were damage by this. Thus restore the style back to the prior resolved issue.

The bug already fixed?

Yes, correct. The bug was already resolved. U can take a look at https://github.com/StoicNeutron/GMU_ACM/issues/38


Update FSHPermissions.cs

What is the reason for this change?
AFAICT this doesn't change the functionality in any way, and will be less performant (adds an extra ReadOnlyCollection allocation).

in this way you can use FSHPermissions like complete permissions but at the same time use XYZPermission (for new groupset of permittions:
private static readonly FSHPermission[] _allFSH = new FSHPermission[] ...
private static readonly FSHPermission[] _xyz = new FSHPermission[] ...

public static IReadOnlyList<FSHPermission> All { get; } = new ReadOnlyCollection<FSHPermission>(_allFSH.unionall(_xyz).toarray());

in short, it can be extensible but at the same time follow the evolution of the project

ok. you right


[BridgeTower] Fix for NoneType in clip mediapipe

Fixes NoneType issue in Clip Media Reader

[N] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[N/A] Did you make sure to update the documentation with your changes?
[N] Did you write any new necessary tests?

https://github.com/huggingface/optimum-habana/pull/796


Pretraining matters？

Many thanks for you breakthrough work of introducing transformer into Person Re-id. I have tried your code locally and it works
well as expected. However, I just find that the pretraining models from imagenet may have a significant influence on the downstream reid performance. The vit-base model was pretrained on imagenet21k and finetuned on imagenet 1k afterwards, while other cnn-based networks were mostly pretrained on imagenet 1k directly instead. So in fair, I think we have to compare these models by using the pretrained model from the same data scale.
I have also replaced the vit with the swin architecture which provides 1k pretrained model as well as 22k. The experiments with 22k pretrained models on market1501 and msmt17 outperforms those with 1k greatly.  I suppose if using vit models pretrained on 1k imagenet dataset, the gap between TransReID and other cnn-based networks could be narrowed.
Anyway, transformer benefits a lot from dataset scale which can also be considered as a trick for downstream works like person reid. If you have also tried some experiments over such pretraining issues, I would appreciate if you can share some findings with me.

Hi, morgenzhang!
Recently I am trying to use swin transformer to replace vit as backbone, but I discover that pretrained model in imagenet can not directly used if the person image's size is [256,128].So I resize person image to [224,224], the result doesn't look well through this
way. Can you give me some advices about how to adjust to make it work normally, thank you!

Many thanks for you breakthrough work of introducing transformer into Person Re-id. I have tried your code locally and it works
well as expected. However, I just find that the pretraining models from imagenet may have a significant influence on the downstream reid performance. The vit-base model was pretrained on imagenet21k and finetuned on imagenet 1k afterwards, while other cnn-based networks were mostly pretrained on imagenet 1k directly instead. So in fair, I think we have to compare these models by using the pretrained model from the same data scale.
I have also replaced the vit with the swin architecture which provides 1k pretrained model as well as 22k. The experiments with 22k pretrained models on market1501 and msmt17 outperforms those with 1k greatly. I suppose if using vit models pretrained on 1k imagenet dataset, the gap between TransReID and other cnn-based networks could be narrowed.
Anyway, transformer benefits a lot from dataset scale which can also be considered as a trick for downstream works like person reid. If you have also tried some experiments over such pretraining issues, I would appreciate if you can share some findings with me.

Hi, morgenzhang!
Recently I am trying to use swin transformer to replace vit as backbone, but I discover that pretrained model in imagenet can not directly used if the person image's size is [256,128].So I resize person image to [224,224], the result doesn't look well through this
way. Can you give me some advices about how to adjust to make it work normally, thank you!

Many thanks for you breakthrough work of introducing transformer into Person Re-id. I have tried your code locally and it works
well as expected. However, I just find that the pretraining models from imagenet may have a significant influence on the downstream reid performance. The vit-base model was pretrained on imagenet21k and finetuned on imagenet 1k afterwards, while other cnn-based networks were mostly pretrained on imagenet 1k directly instead. So in fair, I think we have to compare these models by using the pretrained model from the same data scale.
I have also replaced the vit with the swin architecture which provides 1k pretrained model as well as 22k. The experiments with 22k pretrained models on market1501 and msmt17 outperforms those with 1k greatly. I suppose if using vit models pretrained on 1k imagenet dataset, the gap between TransReID and other cnn-based networks could be narrowed.
Anyway, transformer benefits a lot from dataset scale which can also be considered as a trick for downstream works like person reid. If you have also tried some experiments over such pretraining issues, I would appreciate if you can share some findings with me.

Hi, morgenzhang!
Recently I am trying to use swin transformer to replace vit as backbone, but I discover that pretrained model in imagenet can not directly used if the person image's size is [256,128].So I resize person image to [224,224], the result doesn't look well through this
way. Can you give me some advices about how to adjust to make it work normally, thank you!

Yes, swin transformer is indeed restricted by the input size. I also resized images to [224, 224] and slightly fine tuned the training hyperparameters based on TransReID (e.g. larger learning rate from 0.008 to 0.032 or 0.016). You can also try different architectures (tiny, small, base) and using the pretrained models on imagenet 22k, which outperforms 1k pretrained models. Actually, the results of my experiments on swin is close to TransReID.

Many thanks for you breakthrough work of introducing transformer into Person Re-id. I have tried your code locally and it works
well as expected. However, I just find that the pretraining models from imagenet may have a significant influence on the downstream reid performance. The vit-base model was pretrained on imagenet21k and finetuned on imagenet 1k afterwards, while other cnn-based networks were mostly pretrained on imagenet 1k directly instead. So in fair, I think we have to compare these models by using the pretrained model from the same data scale.
I have also replaced the vit with the swin architecture which provides 1k pretrained model as well as 22k. The experiments with 22k pretrained models on market1501 and msmt17 outperforms those with 1k greatly. I suppose if using vit models pretrained on 1k imagenet dataset, the gap between TransReID and other cnn-based networks could be narrowed.
Anyway, transformer benefits a lot from dataset scale which can also be considered as a trick for downstream works like person reid. If you have also tried some experiments over such pretraining issues, I would appreciate if you can share some findings with me.

Hi, morgenzhang!
Recently I am trying to use swin transformer to replace vit as backbone, but I discover that pretrained model in imagenet can not directly used if the person image's size is [256,128].So I resize person image to [224,224], the result doesn't look well through this
way. Can you give me some advices about how to adjust to make it work normally, thank you!

Yes, swin transformer is indeed restricted by the input size. I also resized images to [224, 224] and slightly fine tuned the training hyperparameters based on TransReID (e.g. larger learning rate from 0.008 to 0.032 or 0.016). You can also try different architectures (tiny, small, base) and using the pretrained models on imagenet 22k, which outperforms 1k pretrained models. Actually, the results of my experiments on swin is close to TransReID.

Many thanks for you breakthrough work of introducing transformer into Person Re-id. I have tried your code locally and it works
well as expected. However, I just find that the pretraining models from imagenet may have a significant influence on the downstream reid performance. The vit-base model was pretrained on imagenet21k and finetuned on imagenet 1k afterwards, while other cnn-based networks were mostly pretrained on imagenet 1k directly instead. So in fair, I think we have to compare these models by using the pretrained model from the same data scale.
I have also replaced the vit with the swin architecture which provides 1k pretrained model as well as 22k. The experiments with 22k pretrained models on market1501 and msmt17 outperforms those with 1k greatly. I suppose if using vit models pretrained on 1k imagenet dataset, the gap between TransReID and other cnn-based networks could be narrowed.
Anyway, transformer benefits a lot from dataset scale which can also be considered as a trick for downstream works like person reid. If you have also tried some experiments over such pretraining issues, I would appreciate if you can share some findings with me.

Hi, morgenzhang!
Recently I am trying to use swin transformer to replace vit as backbone, but I discover that pretrained model in imagenet can not directly used if the person image's size is [256,128].So I resize person image to [224,224], the result doesn't look well through this
way. Can you give me some advices about how to adjust to make it work normally, thank you!

Yes, swin transformer is indeed restricted by the input size. I also resized images to [224, 224] and slightly fine tuned the training hyperparameters based on TransReID (e.g. larger learning rate from 0.008 to 0.032 or 0.016). You can also try different architectures (tiny, small, base) and using the pretrained models on imagenet 22k, which outperforms 1k pretrained models. Actually, the results of my experiments on swin is close to TransReID.

Thanks~
I think it does work better after my adjustment, but seems still have little differences with TransReID. I wonder Swin transformer achieves sota performence in many fields, why the performance is just comparable to TransReID baseline when it is applying to ReID?

Many thanks for you breakthrough work of introducing transformer into Person Re-id. I have tried your code locally and it works
well as expected. However, I just find that the pretraining models from imagenet may have a significant influence on the downstream reid performance. The vit-base model was pretrained on imagenet21k and finetuned on imagenet 1k afterwards, while other cnn-based networks were mostly pretrained on imagenet 1k directly instead. So in fair, I think we have to compare these models by using the pretrained model from the same data scale.
I have also replaced the vit with the swin architecture which provides 1k pretrained model as well as 22k. The experiments with 22k pretrained models on market1501 and msmt17 outperforms those with 1k greatly. I suppose if using vit models pretrained on 1k imagenet dataset, the gap between TransReID and other cnn-based networks could be narrowed.
Anyway, transformer benefits a lot from dataset scale which can also be considered as a trick for downstream works like person reid. If you have also tried some experiments over such pretraining issues, I would appreciate if you can share some findings with me.

Hi, morgenzhang!
Recently I am trying to use swin transformer to replace vit as backbone, but I discover that pretrained model in imagenet can not directly used if the person image's size is [256,128].So I resize person image to [224,224], the result doesn't look well through this
way. Can you give me some advices about how to adjust to make it work normally, thank you!

I have tried swin transformer. For [224,224] or [256,256] image size, swin transformer (22K pretraining) achieves 89+% mAP on the Market. For [256,128] image size, swin transformer only achieves 86.8% mAP on the Market. Swin transformer is more suitable for square images.


Add dev dependency "debug"

Any package with a dev dependency on "karma" now also needs a dev dependency on "debug"
Package<EMAIL_ADDRESS>adds a peer dependency on "debug", and "karma -> http-proxy -> follow-redirects"
rush update --full

Closing in favor of https://github.com/Azure/azure-sdk-for-js/pull/9609


Roll Flutter Engine from 9091107e594d to 6bd7b717e110 (1 revision)

https://github.com/flutter/engine/compare/9091107e594d...6bd7b717e110
2023-08-15<EMAIL_ADDRESS>Roll Dart SDK from d240bef060ed to d1c68769eba0 (1 revision) (flutter/engine#44715)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Replace deprecated std::auto_ptr with std::unique_ptr from C++11

This is a backport of change from Bitcoin Core that replaces uses of std::auto_ptr that is deprecated in C++11 with newer std::unique_ptr.
The goal is to eliminate deprecation warnings from build log.
Also, two changes that upgrade Boost from depends to 1.61.0 and then to 1.63.0 are included in this pull request. They are needed to eliminate other deprecation warnings that were caused by use of auto_ptr from Boost when building with GCC 6.3 on Fedora 25.

Please merge only if all Travis tests were successful.

I think, but don't quote me, that you need to make changes to configure.ac before this will work ;)

Ack 👍

ACK