Implement async A*

Right now, the A* implementation is sync, when the computation timeout, we return the path to the best node. While the returned path is generally in the good direction, complexes environments like mazes can be deceiving.
To improve the path, more nodes needs to be explored, so the timeout should be removed. But the computation should not block other plugins like physics that should be updated every tick. Additionally, to keep the responsiveness of the api, a path estimation should be returned as soon as possible so the bot can start walking, while the computation continues. The solution is to allow a fixed amount of time per tick to advance the computation and save the computation context to continue where it left on the next tick.
Things that needs to be considered:

Computation should restart on environment / goal change

This issue track what has to be done to achieve that goal:

[x] Make A* a class to store the computation context
[ ] Implement free motion and path compression (this is needed in case the part of the path that was already walked is updated)
[ ] Path merging logic
[ ] Update movement monitoring

That's a really cool feature
On Wed, Jun 24, 2020, 21:04 Karang<EMAIL_ADDRESS>wrote:

Right now, the A* implementation is sync, when the computation timeout, we
return the path to the best node. While the returned path is generally in
the good direction, complexes environments like mazes can be deceiving.
To improve the path, more nodes needs to be explored, so the timeout
should be removed. But the computation should not block other plugins like
physics that should be updated every tick. Additionally, to keep the
responsiveness of the api, a path estimation should be returned as soon as
possible so the bot can start walking, while the computation continues. The
solution is to allow a fixed amount of time per tick to advance the
computation and save the computation context to continue where it left on
the next tick.
Things that needs to be considered:

Computation should restart on environment / goal change

This issue track what has to be done to achieve that goal:

Make A* a class to store the computation context
Implement free motion and path compression (this is needed in case
the part of the path that was already walked is updated)
Path merging logic
Update movement monitoring

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Karang/mineflayer-pathfinder/issues/14, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR437RWPVUX7RPFMH74UGTRYJE47ANCNFSM4OHC7Z6Q
.

The implementation is pretty simple and straightforward. (Example is shown here.)
All you need to do is wrap the function inside an object which stores the open and closed sets. Then have a function which only runs a single iteration. Lastly, add a second function to run as many iterations as possible for a given amount of time. This allows you to configure how long you want to run for, or if you want to run indefinitely until a path if found. Or simple want to configure your own kill-switch, sort of speak.

The original implementation was O(n), not O(1). set.has() is an O(n) operation. I just removed the hashing part.

No it is not, the node team is working hard to optimize their library and the Set data-structure is what it says it is: a Set. A set is generally implemented using hash tables and node is no exception: https://v8.dev/blog/hash-code Note that it is not specific to js, you'll find basic datastructures implementations in every languages.
If you're still not convinced, you can run a benchmark yourself:
let array = []
let set = new Set()

for (let i=0 ; i <10000 ; i++) {
  array.push(i)
  set.add(i)
}

let start = performance.now()
for (let i=0 ; i <10000 ; i++) {
  set.has(i)
}
console.log(performance.now() - start)

start = performance.now()
for (let i=0 ; i <10000 ; i++) {
  for (const j of array) {
    if (j===i) break
  }
}
console.log(performance.now() - start)

Outputs:
0.40607601404190063
52.816532015800476

Set is x130 faster than iterating on an array.

No, I was saying to not start walking until the entire path is found, even if it takes several ticks to find the path.

Well that's the goal, if we can afford to wait, there is really no point in doing all that, the current implementation just work.

Another option is to solve the path backward. This might actually be a better solution. Because nodes keep a pointer to the node they can from, you actually have a pointer to find all shortest paths from any closed node to the start node for free. (The information already exists, just don't reverse the path array when constructing the path)
By doing this, you can actually run two smaller path finding algorithms. The first algorithm starts at the goal node an moves out, looking for the bot's current position. The second pathfinder starts at the bot's current position and looks for any node that was already explored by the first pathfinder. The first pathfinder spans multiple ticks, while the second pathfinder runs for one frame and is recalculated the next frame. This allows the bot to start moving instantly and will always reach the goal node.

Yeah that's what I just said. Note that walking the path backward is an approximation that can work but is not necessary optimal.

Yeah that's what I just said. Note that walking the path backward is an approximation that can work but is not necessarily optimal.

Oh, I misunderstood your comment then.
And yes, I'm aware it's not optimal. But if you want to start executing the path immediately, you will lose some accuracy in exchange for speed. It's often impossible to promise the first few starting steps can be absolutely optimal until the entire path is known, or at least all relevant paths. For example, the famous U obstacle example. The bot wouldn't know that direction couldn't be taken until it's almost already at the goal position.

But if you want to start executing the path immediately, you will lose some accuracy in exchange for speed.
Yes it's a trade-off, but it is possible to find a strategy that converge to the optimal solution. I think it will converge quite quickly.

For example, the famous U obstacle example. The bot wouldn't know that direction couldn't be taken until it's almost already at the goal position.

In this example, recomputing the path is better than walking backward, because the bot may choose to dig through the wall, which is slower than walking the right path from the start, but faster than going back.
Also note that the U or maze will need to be really large to fool the algorithm, and if it is too large it will go out of the view distance, so anyway it will not be possible to be 100% accurate, this is why dynamic re computation was implemented (and its working quite well already).
Don't worry it's all thought of already :) Just lacking a bit of time to do the actual implementation.

I see. I wish you the best of luck with the implementation, then!


fix: atcmd: wifi_api prototype parameter order

Fix the header prototype for wifi_api_start_softap which has the bandwidth and frequency parameters swapped. The only caller for this function, atcmd_wifi, is passing the arguments in the correct order.
This change does not affect the binary, it's only a documentation fix.

Dear @corytodd,
Thank you for your contribution.
Best regards,
Newracom


1.083 I no longer get any text in the inventory tooltip description box

With 1.083 I no longer get any text in the inventory tooltip description box; i.e. the box at the bottom of the inventory page is completely empty always when I mouse over an item.

Can you confirm this is fixes in 1.0.84?


[FRS-59] Fix SHUFFLE_CONF_DIR didn't work in standalone mode

What is the purpose of the change
Fix bug: Env variable SHUFFLE_CONF_DIR didn't work in standalone mode
Brief change log

Change start-daemon script

Verifying this change
This change is already covered by existing tests.

Releated issue: #59

@dangshazi Thanks for the contribution. I notice that only the shuffle-daemon.sh script was fixed, I guess the shuffle-console.sh script incurs the same problem, could you please also fix the shuffle-console.sh script?

Done

@dangshazi Thanks for the update. Merged.


Select component blocking/slowing renders

Bug report
Current Behavior
Video
Expected behavior
Select component should not block/slows renders.
Reproducible example
CodeSandbox Template
Additional context
I recently find out that the Select component slows/blocks renders if it has more items "than usual". In the CodeSandbox example the component is rendering 500 items to evidence the behavior, but this starts to happen with 90+ (approx) items. I've tried to resolve this with memo, but the "block" behavior still happens.
I don't know if this happens because the component is generating a "shadow" native select to control values and selected items, but I didn't notice this same behavior happening with other components, like Dropdown and Popover. I know these components are not doing the same thing, but I put in the example just to compare.
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-select
2.0.0

React
n/a
18.2.0

Browser
Chrome
120.0.6099.72 64 bits

Node
n/a
20.9.0

npm/yarn
npm
9.8.1

Operating System
Windows
10

+1 i am suffering this issue too

any updates so far?

The custom Select has a lot more work to do than the native one to bring in the same functionality.
Arguably, if you have that many items, a select probably is the wrong UI/UX anyway as it's painful for a user to scroll through hundreds of items.
A combobox in these cases would make more sense, or some filtering mechanism that allows to whittle down options.

@benoitgrelard Hello, my Select has less than 10 values and it's still slow  (not dynamic values)

I have the same problem with @JeffreyJoumjian, in my I open a Dialog inside another Sheet then sometime both Dialog and Sheet trying to claim the focus it lead me to Maximum call stack size exceeded and damm this so hard to debug. In my case I set the modal={false} like Jeff said and it seems work for me. Thank you again.


New attempt of packaging

The wheel created by PYPI did not include the _nimlite directory despite being included in locally built wheel, might be something to do with publishing settings, so instead I've moved it under tablite/_nimlite.

Codecov Report

Merging #90 (eae98ee) into master (ad562ff) will decrease coverage by 5.06%.
Report is 69 commits behind head on master.
The diff coverage is 59.10%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   83.04%   77.98%   -5.06%
==========================================
  Files          24       25       +1
  Lines        3704     3952     +248
==========================================
+ Hits         3076     3082       +6
- Misses        628      870     +242

Files
Coverage Δ

tablite/__init__.py
100.00% <100.00%> (ø)

tablite/base.py
87.51% <100.00%> (+0.04%)
:arrow_up:

tablite/config.py
100.00% <100.00%> (ø)

tablite/core.py
86.58% <ø> (ø)

tablite/version.py
100.00% <100.00%> (ø)

tablite/utils.py
89.75% <80.00%> (-0.21%)
:arrow_down:

tablite/nimlite.py
72.54% <72.54%> (ø)

tablite/import_utils.py
43.89% <51.78%> (-33.24%)
:arrow_down:

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


InitialValues and array fields is not rendered on server side

I'm trying to initialize my form with the value arrived from async-connect. From server, my form doesn't render so when I log the fields from the render method, it comes empty. But the data provided to the initialValues is not empty:
[1] form { panels: [] }
[1] data { formDto:
[1]    { form: { panels: [Object] },
[1]      tripId: 'dmg1',
[1]      requestId: 'president' } }

I've updated to 5.2.3 hoping this was fixed with https://github.com/erikras/redux-form/issues/621, but probably it missed something with the Array fields?

Thanks for reporting the issue. Unfortunately I'm unable to reproduce the issue. Could you create a minimal gist so I would be able to further investigate?


Controll only Kids Account

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.
[ ] This issue is a feature request to test other Nintendo Parental Controls mobile app configurations

Is your feature request related to a problem? Please describe.
I would like to controll only the Kids Account
Describe the solution you'd like
Right now i have an Family (Parents Account) and within this Account there is the Kids Account, i would like to use the Switch as Parents without limitation and only controll the Kids Account with the Integration
Describe alternatives you've considered
N/A
Additional context
N/A

I don't think this is possible, because there is only a device control.
Your only option is to deactivate the limitations when you play and activate them when the kids play...
To be honest I don't even know if it's a good idea having the parental account on the same switch like the kid, because you can not even lock the parental account with a pin... -__-

Hi,
Yes, I have to agree with @JokerGermany - I don't think this is possible. If its something that can't be done in the app, then its something that I can't do within the integration.
Understandably this integration doesn't expose everything that is in the app currently, however I haven't seen any feature requests for the stuff that is missing. As I don't really manage screentime anymore, I don't really have a need for those features.

Closing - limitation of Nintendo Switch itself.


Add master to Travis

Should be enough to specify 1.10beta2 ( not 1.10.x or anything else).

Fixed on https://github.com/Azure-Samples/azure-sdk-for-go-samples/pull/99


ESP-NOW: header validation ignoring most fields (IDFGH-8074)

Environment

Chip used: ESP32-C3
IDF version: v4.4.2

Problem Description
Most fields in the vendor specific action frame and vendor specific ie are not validated properly.
Actual Behavior

OUI both in the Vendor Specific Action Frame and the Vendor Specific IE are not validated. This means that ESP-NOW might also listen for Vendor Specific Action Frames from other Manufacturers!
Random Value can be the same every time https://github.com/espressif/esp-idf/issues/9544
Invalid FCS is ignored https://github.com/espressif/esp-idf/issues/9575
Type and Version Fields are not validated. This might cause problems if they change sometime in the future.

In the example below, all mentioned fields are set to 0xFF but the message is still received.

Steps to reproduce
Use the firmware and scripts from https://github.com/ceribu/esp-now-header-validation/blob/main/combined.py

Hi @ceribu
Thanks for the reporting, it's helpful for us to improve ESP-NOW.
We will optimize ESP-NOW according your report.


Preprocessing sequences

In the configuration we added:
conf["assembly_preprocessing_steps"]=['normalized', 'errorcorr', 'merged']

This gives the impression that these steps are optional or that their order can be changed. They are currently required steps of preprocessing and occur linearly starting with normalization.

Yes, I tried to implement the steps quite general, to refuse them may be somewhere else. The steps are in fact optional and the order can be changed. But I see this is not really necessary. So I might go back to the 'merge pairs'
To be clear there normalization, error correction, and merging is done on the qc reads just before assembly.
In contrast to earlier, the reads mapped to the prefilterd contigs are not error corrected with tadpole, nor merged.
I thought this could allow SNP calling later on.
On Nov 28, 2017, 19:52, at 19:52, Joe Brown<EMAIL_ADDRESS>wrote:

In the configuration we added:
conf["assembly_preprocessing_steps"]=['normalized', 'errorcorr',
'merged']

This gives the impression that these steps are optional or that their
order can be changed. They are currently required steps of
preprocessing and occur linearly starting with normalization.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/pnnl/atlas/issues/55


Add GRPC check

It would be useful to have a library of commonly used health checks. In the scope of this issue, a health check should be implemented that checks if a GRPC endpoint is reachable, e.g. by using a HealthClient instance from google.golang.org/grpc/health/grpc_health_v1 to retrieve its status and see if it is "serving" (I.e. HealthCheckResponse_SERVING).
A few constraints to keep things clean and simple:

The check should be added to the checks module that you can find in the development branch.
As with all health check functions of this library, the check implementation should support accepting and forwarding context.Context that is being passed to each health check function.
If the health check requires external external modules or other dependencies, the check should be implemented as a separate Go module(similarly how it is done for the tests, that require dependencies to other packages as well). This is required to avoid that when people import the base library, they also need to import all dependencies of all provided checks.
The check should have a README.md in its root directory that describes how to use it and maybe what to look out for.
You should provide a test that checks at least the happy path. If a docker container is required to properly test the check, the docker container can be added to the docker-compose.yaml file in the checks base package.

Should you have questions or require help, please join our discord chat room.

Was the checks module removed?
It seems that it still exists on the development branch, but not main?
What is the status of the development branch?
https://github.com/alexliesenfeld/health?tab=readme-ov-file#compatibility-with-other-libraries


BUY order Invalid order or insufficient balance with bitcoin-co-id

Note: for support questions, please join our Discord server

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
Bot was failed to buy order

Expected result (what you hoped would happen)
buy with correct quantity

Actual result (unexpected outcome)

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

2018-02-10 16:36:39 (INFO):	Attempting to BUY 4.2499405469678955 XRP at Bitcoin-co-id price: 0.00012767 2018-02-10 16:36:39 (ERROR):	unable to buy { VError: Bitcoincoid._request() API error: Insufficient balance.     at Request._callback (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/index.js:85:23)     at Request.self.callback (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/node_modules/request/request.js:186:22)     at emitTwo (events.js:126:13)     at Request.emit (events.js:214:7)     at Request.<anonymous> (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/node_modules/request/request.js:1163:10)     at emitOne (events.js:116:13)     at Request.emit (events.js:211:7)     at IncomingMessage.<anonymous> (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/node_modules/request/request.js:1085:12)     at Object.onceWrapper (events.js:313:30)     at emitNone (events.js:111:20)   jse_shortmsg: 'Bitcoincoid._request() API error: Insufficient balance.',   jse_info: {},   message: 'Bitcoincoid._request() API error: Insufficient balance.' }
2018-02-10 17:06:18 (INFO):	Trader Received advice to go long. Buying  XRP 2018-02-10 17:06:18 (ERROR):	unable to cancel order:  3403670 ( { VError: Bitcoincoid._request() API error: invalid order.     at Request._callback (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/index.js:85:23)     at Request.self.callback (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/node_modules/request/request.js:186:22)     at emitTwo (events.js:126:13)     at Request.emit (events.js:214:7)     at Request.<anonymous> (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/node_modules/request/request.js:1163:10)     at emitOne (events.js:116:13)     at Request.emit (events.js:211:7)     at IncomingMessage.<anonymous> (/home/chekerlamer/Documents/gekko/node_modules/bitcoin-co-id/node_modules/request/request.js:1085:12)     at Object.onceWrapper (events.js:313:30)     at emitNone (events.js:111:20)   jse_shortmsg: 'Bitcoincoid._request() API error: invalid order.',   jse_info: {},   message: 'Bitcoincoid._request() API error: invalid order.' } ), retrying...

Same problem here with Gekko 6.2.0 and Binance - ONT/USDT:
2018-07-10 13:36:21 (DEBUG):    Requested ONT/USDT trade data from Binance ...
2018-07-10 13:36:22 (DEBUG):    Processing 38 new trades. From 2018-07-10 11:36:02 UTC to 2018-07-10 11:36:19 UTC. (a few seconds)
2018-07-10 13:36:42 (DEBUG):    Requested ONT/USDT trade data from Binance ...
2018-07-10 13:36:43 (DEBUG):    Processing 37 new trades. From 2018-07-10 11:36:22 UTC to 2018-07-10 11:36:40 UTC. (a few seconds)
2018-07-10 13:37:02 (DEBUG):    Requested ONT/USDT trade data from Binance ...
2018-07-10 13:37:02 (DEBUG):    Processing 39 new trades. From 2018-07-10 11:36:42 UTC to 2018-07-10 11:37:00 UTC. (a few seconds)
2018-07-10 13:37:02 (INFO):     Trader Received advice to go long. Buying  ONT
2018-07-10 13:37:07 (DEBUG):    [ORDER] statusChange: SUBMITTED
handleCreate [binance.js] Error -2010: Account has insufficient balance for requested action.

/home/gekko/gekko/exchange/orders/sticky.js:122
      throw err;
      ^
Error
    at Object.<anonymous> (/home/gekko/gekko/exchange/exchangeErrors.js:34:24)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/gekko/gekko/exchange/exchangeChecker.js:4:16)
    at Module._compile (module.js:652:30)

@ferdy42id unfortunately that exchange (recently renamed to indodax) is currently not working anymore.
@PhunkyBob Very strange, I did not encounter this before. Can you please download the latest develop branch that includes a few binance fixes. And if the issue persists please open a new issue.

Closing this since Bitcoin-co-id is currently not enabled.


biz timestamp  not instead of promethus timestamps

What did you do?
step1:  create  my export with java client，
output.  metrics with my timestamps
step2: config prometheus.yml .add job
step3.run  export and prometheus
step4. check export result  and. premetheus /api/v1/query result
What did you expect to see?
1、exporter  result

2、but promethues query /api/v1/query

promethues not use my timestamps
What did you see instead? Under which circumstances?
query /api/v1/query.  prometheus not use my timestamp .

System information
Darwin 20.3.0 x86_64
Prometheus version
prometheus version	2.37.0 / 2.36.2
Revision	b41e0750abf5cc18d8233161560731de05199330
Branch	HEAD
BuildUser	root@04e08efba15f
BuildDate	20220714-15:13:17
GoVersion	go1.18.4

Prometheus configuration file
global:
  # 采集间隔
  scrape_interval:     15s # By default, scrape targets every 15 seconds.
  # 计算报警和预聚合 间隔
  evaluation_interval: 10s

  # 采集超时 时间
  scrape_timeout: 10s

scrape_configs:

  - job_name: "myexportor"
    # honor_labels: true
    # honor_timestamps: false
    static_configs:
         # export address
      - targets: ['<IP_ADDRESS>:8082']
        labels:
          instance: exportor

Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Thanks for your report. It looks as if this is actually a question about usage and not development.
It makes more sense to ask questions like this on the prometheus-users mailing list or our forums rather than in a GitHub issue. In our community channels, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

yes,  I found this problem. It's Ok,I just contacted prometheus, the wrong verification method of the cause of

I also encountered this problem, want to add a custom timestamp, the above problem, have you solved?
If yes, please let me know how. thank you

What did you do?
step1: create my export with java client， output. metrics with my timestamps
step2: config prometheus.yml .add job
step3.run export and prometheus step4. check export result and. premetheus /api/v1/query result
What did you expect to see?
1、exporter result
2、but promethues query /api/v1/query
promethues not use my timestamps
What did you see instead? Under which circumstances?
query /api/v1/query. prometheus not use my timestamp .
System information
Darwin 20.3.0 x86_64
Prometheus version
prometheus version	2.37.0 / 2.36.2
Revision	b41e0750abf5cc18d8233161560731de05199330
Branch	HEAD
BuildUser	root@04e08efba15f
BuildDate	20220714-15:13:17
GoVersion	go1.18.4

Prometheus configuration file
global:
  # 采集间隔
  scrape_interval:     15s # By default, scrape targets every 15 seconds.
  # 计算报警和预聚合 间隔
  evaluation_interval: 10s

  # 采集超时 时间
  scrape_timeout: 10s

scrape_configs:

  - job_name: "myexportor"
    # honor_labels: true
    # honor_timestamps: false
    static_configs:
         # export address
      - targets: ['<IP_ADDRESS>:8082']
        labels:
          instance: exportor

Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

yes, I found this problem. It's Ok,I just contacted prometheus, the wrong verification method of the cause of

I also encountered this problem, want to add a custom timestamp, the above problem, have you solved?
If yes, please let me know how. thank you


awk language support

What about awk language support?

You'll get suggestions when writing awk scripts. What is the problem?


Licence

I would like to use you code in a personnal project (that will be on Github too).
Could you add a licence to your project (mine is GPL) ?
Thank a lot

No problem, it's now MIT licensed.


utilitarian data has no labels

Hello,
As of February 28, 2022 the utilitarian subfolder of the data downloaded from https://people.eecs.berkeley.edu/~hendrycks/ethics.tar does not contain labels or header information.
It is likely to have been the case since Oct 28, 2020 ("Last Modified").
If possible, please update the files with labels + headers. Thank you. I hope to apply these datasets soon :)

I think the higher utility scenario is above the lower ranked scenario.
On Mon, Feb 28, 2022 at 1:50 AM vincent wi @.***> wrote:

Hello,
As of February 28, 2022 the utilitarian subfolder of the data downloaded
from https://people.eecs.berkeley.edu/~hendrycks/ethics.tar does not
contain labels or header information.
It is likely to have been the case since Oct 28, 2020 ("Last Modified").
If possible, please update the files with labels + headers. Thank you. I
hope to apply these datasets soon :)
—
Reply to this email directly, view it on GitHub
https://github.com/hendrycks/ethics/issues/4, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZBITRYMGD4SUBNZM4SBYTU5NANVANCNFSM5PQS4SZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Ah my misunderstanding. Thank you, clear now.


Problem with Vietnamese font

Hi @andrey-ushakov ,
This is good lib to print over thermal printer. I have tested, but there is still a problem with Vietnamese character.
I have changed all the alternatives to print VN font, including study your source code, but cannot get proper result.
    ticket.text('VÉ XE', styles: PosStyles(align: PosAlign.left, codeTable: PosCodeTable.westEur), linesAfter: 0);
is ok, but only for vietnamese with one vietnamese signal, if the text have 2 signals, such as "tối" it prints failed.
I aslo try to use PosCodeTable.vietnam which your lib support, but the same error.
Other trying is
utf8.encode('VÉ XE'); CharsetConverter.encode("windows1258", "VÉ XE");
all result failed.
I know that I can convert Vietnamese text into bytes by encoding proper type, then push into printer throughout your driver. So I dont know is this a issue of driver or I dont find true solution.
Please help me to solve this.
Thanks a lot,
Khanglq.

i have issues with khmer language also. @andrey-ushakov  please help to fix text encoding for unicode please


GeoFile Reader fails to read in file written with the GeoFile Writer

If I use the GeoFile Reader to read in a geojson file that I did write out with the GeoFile Writer I get the following exception:
Duplicate column names found: ['', '', 'area', 'geometry']
For an example see: https://hub.knime.com/-/spaces/-/latest/~DIO5lPPwYuXwqv_d/

@koettert I can not replicate the error now with the. Did you already update the code:)

Fixed with this commit: https://github.com/spatial-data-lab/knime-geospatial-extension/commit/07f6258b740ed5227b7467fa97520b68cc56fa9c


fix: replace native pipe with re-exported magrittr pipe

closes #2

Thanks! I've got another couple of small changes to add and this is a good suggestion (although I'm moving in general to native pipe). I'll incorporate this and publish asap.

although I'm moving in general to native pipe

Totally fair. My only consideration of this as it relates to packages is that it requires other users of the package to have R > 4.1.0 which I appreciate is absolutely your call to make.

Yep, good shout as there'll be plenty still on 3.x and I want it to be as easy as possible to use. Thanks for being our first pull request! Really helps :)


Introduce same validation logic as tendermint

implement basic validation logic to fix #81
additionally fix a decoding issue in Request::read (see https://github.com/tendermint/kms/pull/110/commits/bf304dcb7c2ee8b8e2bbcfb1d81b288fea3c77f6)

Thanks a lot for the review @tarcieri!
I think all comments are addresses now.


Implement multithreading tests

I have added some multithreading tests. It happened to me that context sharing was working ok in the current test (same thread) but was failing on servo due to multithreading environment. Better to test all the scenarios ;)

Neat, looks good to me with that test change.

r=me


Refactor diffusers tasks

What does this PR do?
This PR:

[x] Refactors "stable-diffusion" and "stable-diffusion-xl" into "text-to-image", "image-to-image" and "inpainting"
[ ] Adds auto diffusion pipelines ORTPipelineForText2Image, ORTPipelineForImage2Image and ORTPipelineForInpainting

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

Who can review?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


wheres the opt-out???

all of this info is great and all but whats the point of it being "optional" without there being any clear indication of how to opt out of these optional privacy controls...otherwise all of your blah blah info is just empty appearances of amelioratory nothingness...and we dont want that do we?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d14345a-d55e-f7ed-4a0a-a8fe97e442ff
Version Independent ID: 409d6b69-b142-29e8-86cc-0df365e73b30
Content: Required diagnostic data for Office - Deploy Office
Content Source: DeployOffice/privacy/required-diagnostic-data.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

Information about diagnostic data controls (on Windows) for organizations can be found here: Policy setting for diagnostic data. There is similar info for other platforms, such as macOS. See the Table of Contents on the left hand side of the page.


Issue with fields request params

As I'm playing with the Sparse Fieldsets, I encountered some issues.
With the following resources:
class UserResource < JSONAPI::Resource
  has_one :status, class_name: 'UserStatus'
  attributes :name, :email
end
class UserStatusResource < JSONAPI::Resource
  has_one :user
  attributes :foo, :bar
end

Relationships are removed from then response when using fields, so we can't link a user to his status.
/users?include=status&fields[users]=name

Association with custom class_name failed with fields.
/users?include=status&fields[users]=name&fields[user-statuses]=foo

returns:
{:errors=>
  [{:title=>"Invalid resource",
    :detail=>"user-statuses is not a valid resource.",
    :id=>nil,
    :href=>nil,
    :code=>101,
    :path=>nil,
    :links=>nil,
    :status=>"bad_request"},
   {:title=>"Invalid resource",
    :detail=>"user-statuses is not a valid resource.",
    :id=>nil,
    :href=>nil,
    :code=>101,
    :path=>nil,
    :links=>nil,
    :status=>"bad_request"}]}

i think it works fine with last release
curl -X GET -i -H "Accept: application/vnd.api+json" -d "include=author_detail&fields[authors]=name&fields[author_details]=address" "http://localhost:3000/authors"
HTTP/1.1 200 OK
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 1; mode=block
X-Content-Type-Options: nosniff
Content-Type: application/vnd.api+json
Etag: W/"e9aeb6e11757b67167f3aeed416ef863"
Cache-Control: max-age=0, private, must-revalidate
X-Request-Id: 895da017-b296-40ec-adc7-9204f198b8e9
X-Runtime: 0.022558
Server: WEBrick/1.3.1 (Ruby/2.2.2/2015-04-13)
Date: Mon, 13 Jul 2015 17:22:44 GMT
Content-Length: 879
Connection: Keep-Alive

{
  :data => [
    [0] {
      "id" => "1",
      "type" => "authors",
      "links" => {
	:self => "http://localhost:3000/authors/1"
      },
      "attributes" => {
	"name" => "john"
      }
    },
    [1] {
      "id" => "2",
      "type" => "authors",
      "links" => {
	:self => "http://localhost:3000/authors/2"
      },
      "attributes" => {
	"name" => "bob"
      }
    }
  ],
  :included => [
    [0] {
      "id" => "1",
      "type" => "author_details",
      "links" => {
	:self => "http://localhost:3000/author_details/1"
      },
      "attributes" => {
	"address" => "qwe"
      }
    },
    [1] {
      "id" => "2",
      "type" => "author_details",
      "links" => {
	:self => "http://localhost:3000/author_details/2"
      },
      "attributes" => {
	"address" => "asd"
      }
    }
  ],
  :meta => {
    "record_count" => 2
  },
  :links => {
    "first" => "http://localhost:3000/authors?fields%5Bauthor_details%5D=address&fields%5Bauthors%5D=name&include=author_detail&page%5Bnumber%5D=1&page%5Bsize%5D=10",
    "last" => "http://localhost:3000/authors?fields%5Bauthor_details%5D=address&fields%5Bauthors%5D=name&include=author_detail&page%5Bnumber%5D=1&page%5Bsize%5D=10"
  }
}

module Client

  class Base < JsonApiClient::Resource
    self.site = 'http://<IP_ADDRESS>:3000/'
  end

  class Author < Base
    has_one :detail, class_name: 'AuthorDetail'
  end

  class AuthorDetail < Base
    belongs_to :author
  end

end

@senid231 - Thanks for trying this out. I updated to 0.4.4 but am still getting the same error. Are you on 0.4.4?
The fields work fine for other includes where we don't use a custom class.
{
  "errors": [
    {
      "detail": "user_statuses is not a valid resource.",
      "title": "Invalid resource",
      "status": "bad_request",
    }
  ]
}

I'll try to get a fix for this into the next release.

@lgebhardt :+1: thanks!

Hello! I'm trying this:
http://localhost:3000/users?filter[id]=1,2,3,4,5&include=profile&fields[users]=username&fields[profile]=full-name,country

and the answer is:
{
  "data": [
    {
      "id": "1",
      "type": "users",
      "links": {
        "self": "http://localhost:3000/users/1"
      },
      "attributes": {
        "username": "4sq75z"
      }
    },
    {
      "id": "2",
      "type": "users",
      "links": {
        "self": "http://localhost:3000/users/2"
      },
      "attributes": {
        "username": "4sq7e5z"
      }
    },
    {
      "id": "3",
      "type": "users",
      "links": {
        "self": "http://localhost:3000/users/3"
      },
      "attributes": {
        "username": "4sq7es5z"
      }
    },
    {
      "id": "4",
      "type": "users",
      "links": {
        "self": "http://localhost:3000/users/4"
      },
      "attributes": {
        "username": "4sq7eds5z"
      }
    },
    {
      "id": "5",
      "type": "users",
      "links": {
        "self": "http://localhost:3000/users/5"
      },
      "attributes": {
        "username": "4sq7edds5z"
      }
    }
  ],
  "included": [
    {
      "id": "1",
      "type": "profiles",
      "links": {
        "self": "http://localhost:3000/profiles/1"
      },
      "attributes": {
        "full-name": "12312312",
        "country": "VE",
        "address": null
      },
      "relationships": {
        "user": {
          "links": {
            "self": "http://localhost:3000/profiles/1/relationships/user",
            "related": "http://localhost:3000/profiles/1/user"
          }
        }
      }
    },
    {
      "id": "2",
      "type": "profiles",
      "links": {
        "self": "http://localhost:3000/profiles/2"
      },
      "attributes": {
        "full-name": "12312312",
        "country": "VE",
        "address": null
      },
      "relationships": {
        "user": {
          "links": {
            "self": "http://localhost:3000/profiles/2/relationships/user",
            "related": "http://localhost:3000/profiles/2/user"
          }
        }
      }
    },
    {
      "id": "3",
      "type": "profiles",
      "links": {
        "self": "http://localhost:3000/profiles/3"
      },
      "attributes": {
        "full-name": "12312312",
        "country": "VE",
        "address": null
      },
      "relationships": {
        "user": {
          "links": {
            "self": "http://localhost:3000/profiles/3/relationships/user",
            "related": "http://localhost:3000/profiles/3/user"
          }
        }
      }
    },
    {
      "id": "4",
      "type": "profiles",
      "links": {
        "self": "http://localhost:3000/profiles/4"
      },
      "attributes": {
        "full-name": "12312312",
        "country": "VE",
        "address": null
      },
      "relationships": {
        "user": {
          "links": {
            "self": "http://localhost:3000/profiles/4/relationships/user",
            "related": "http://localhost:3000/profiles/4/user"
          }
        }
      }
    },
    {
      "id": "5",
      "type": "profiles",
      "links": {
        "self": "http://localhost:3000/profiles/5"
      },
      "attributes": {
        "full-name": "12312312",
        "country": "VE",
        "address": null
      },
      "relationships": {
        "user": {
          "links": {
            "self": "http://localhost:3000/profiles/5/relationships/user",
            "related": "http://localhost:3000/profiles/5/user"
          }
        }
      }
    }
  ],
  "links": {
    "first": "http://localhost:3000/users?fields%5Busers%5D=username&filter%5Bid%5D=1%2C2%2C3%2C4%2C5&include=profile&page%5Blimit%5D=10&page%5Boffset%5D=0",
    "last": "http://localhost:3000/users?fields%5Busers%5D=username&filter%5Bid%5D=1%2C2%2C3%2C4%2C5&include=profile&page%5Blimit%5D=10&page%5Boffset%5D=-5"
  }
}

My problem is the relationships between the users an the profile disappear when I used fields[users]=username (when I remove is, the relatioships come back :( )
Is there a way to restrict the fields but retain the include relationships?
thanks you.

My bad, i missed adding profile to the fields[users]. The correct call would be the following
http://localhost:3000/users?filter[id]=1,2,3,4,5&include=profile&fields[users]=username,profile&fields[profile]=full-name,country

@dgeb do you know if this ever got addressed?


Use golistic/xgo

We need to use golistic/xgo instead of, for example, golistic/xmath.

Fix with commit 26347191


Xenova/whisper-tiny preprocessor_config.json is missing mel_filters

Describe the bug
A clear and concise description of what the bug is.

How to reproduce
Steps or a minimal working example to reproduce the behavior
async function clearTransformersCache() {
  const tc = await caches.open("transformers-cache");
  const keys = await tc.keys();
  keys.forEach(key => tc.delete(key));
}
await clearTransformersCache();
// git clone https://huggingface.co/Xenova/whisper-tiny/
env.localModelPath = "http://<IP_ADDRESS>/transformer/models/";
const pipe = await pipeline("automatic-speech-recognition", "whisper-tiny");
const audioCTX = new AudioContext({
  sampleRate: 16000
});
const arrayBuffer = await (await fetch(SPEECH2TEXT_AUDIO.currentSrc)).arrayBuffer();
const decoded = await audioCTX.decodeAudioData(arrayBuffer);
const audio = decoded.getChannelData(0);
const result = await pipe(audio);
console.log("result", result);

Expected behavior
Making this code crash-proof:
https://github.com/xenova/transformers.js/blob/13b570ce975306d3b9dd3f88fb59dffc3a001cc1/src/processors.js#L860-L861
Environment

Transformers.js version: latest docs branch
Browser (if applicable): Chrome (should happen everywhere though)
Operating system (if applicable): Linux (should happen everywhere though)

Other
My current "solution" is to simply copy over the entire file from:
https://huggingface.co/Xenova/whisper-tiny.en/blob/main/preprocessor_config.json
(it's the same, but having mel_filters)

That is quite strange indeed. Those were saved directly from using .save_pretrained, so, I'm not too sure why it didn't include it. It also seems to be a problem with small and base (non-english models). I'll look into it. Thanks!


Update TFM to netstandard2.0

@pranavkm Updated. Appveyor should pass after IISIntegration changes are in

Could you wait until @JunTaoLuo merges in IISIntegration and the build passes? Looks :shipit: otherwise

This should now be unblocked.

I'll wait for Coherence to pass. Right now it doesn't build locally. Thanks!


Feature: enforcing the usage of a single package manager

Description

I have always used npm as package manager and only recently started to use yarn.
I try to avoid mixing the two in my projects, but sometimes it just happens that I run npm install <somePackage> in a new yarn project.
I searched for a way to enforce using yarn, but as you can see from this open issue on yarn there is no clean way to do it.
So I opted for writing a script that would run in a pre-commit hook with the help of husky.
The script would just delete a staged package-lock.json, and git add the deletion:
#!/bin/sh
if [ `git diff --name-only --cached | egrep -c 'package-lock.json'` -ne "0" ]; then
  echo "WARNING: You just used npm in a yarn project. Please use yarn next time."
  rm -rf package-lock.json
  git add package-lock.json
fi

This works fine for me. But having the enforcement feature implemented in a widely used library could do much more good to the world.
lint-staged already has logic to get the name of the staged files and adding the step to remove package-lock.json should be fairly easy.
The logic above was written specifically to enforce yarn over npm, but of course any requested use case could be implemented.
The various implementations could be simple functions defined in a new enforcePackageManager.js in the lib. This new file would then export only the desired implementation (possibly chosen via a flag).

I think that I'd prefer lint-staged to stay agnostic of such use cases since it's just a runner. But I see your point of reaching a broader audience. I could suggest doing two things: publishing your script to NPM so it can be easily installed as a dependency and submitting a PR for the docs here to highlight your use case. What do you think?

I could suggest doing two things: publishing your script to NPM so it can be easily installed as a dependency and submitting a PR for the docs here to highlight your use case. What do you think?

I think this is a valid alternative.
I'll take my time to write the package, as first I would like to learn bash scripting (rather than just copy/pasting code I find on the web) and also do some research related to publishing such package. In any case, if you happen to change mind about implementing the feature, you have my support :grin:

This can already be done in the npm/yarn preinstall script, which will run before any install. For example the process.env.npm_execpath value will include either npm or yarn, depending on what you're using.
See this Stackoverflow thread for great examples: https://stackoverflow.com/questions/41076172/force-yarn-install-instead-of-npm-install-for-node-module
Anyway, I agree with @okonet that this isn't really in the scope of lint-staged. I will close this issue. 👍

This can already be done in the npm/yarn preinstall script

Unfortunately preinstall runs only before npm install (with no arguments), there would be nothing stopping you from running npm install <somePackage>. And by the way even npm install, before failing, leaves you an unwanted package-lock.json.
The only solution currently available would be specifying a fictitious npm engine and create an npmrc with the rule engine-strict = true (see this comment).
But implementing this solution in every project may be tedious and not so "clean". Also someone reports that it may cause problems later on.
Using a pre-commit hook would be as clean as the preinstall script and as effective as the fictitious engine.
Regarding whether the feature is in the scope of lint-staged, I don't think there is an easy answer: after all (one of) the purpose of linters is to enforce chosen standards within a project.

maybe you can create a generic script like this:

Yes, something like that.
But wouldn't it be nice to have the script already in lint-staged?

No, this is not in the scope of lint-staged. Let's stick to running (linter) tasks on files staged in git. We have removed previous advanced config and want to keep it simple and easy to use.

I disagree with you because lint-staged is not a linter itself, but it's only meant to run other linters on staged files.

Alright, but since the only way (I found) to handle this enforcement is to run a script in a pre-commit hook, which is not where a linter does its things, and which is exactly where lint-staged does its things, I thought that lint-staged may have been the right place for the enforcement. If you assume the proposed script to be a linter, because it enforces a standard, than even with the proposed feature, lint-staged would still be just "run other linters on staged files"
Anyway, I understand that at the moment you do not see this feature as legitimate for your library, as at the moment I do, and that's fine. It may even be that we are both right from a certain point of view. It's not my intention to persuade anyone to do anything. I did what was in my power by proposing the feature and I happy with that, regardless of whether the feature will ever get implemented.
Have a nice one :laughing:

@iiroj I'm just passing by to say you were right. lint-staged is not supposed to have any built in linters/rules/enforcement.
I will probably write a small package because it will be easier for me to enforce yarn with it rather than to manually add a script to every project and also because I am curious about node scripts (like the one in the gist you linked, or in lint-staged all over the places) and want to do some practice writing them..
Well, sorry for taking up so much of your time and thanks for sparking up my curiosity :raised_hands:

@DaviDevMod no problem, and glad to help.


[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch app
Tap fab
Tap assign task
Enter title
Tap next
Select any user for Share somewhere
Tap confirm task
From the Confirmed Task screen
Tap assignee
Select any user - button unresponsive = you can't add an assignee

You  can add an assignee by
Find a Task in the LHN > tap Assignee > you can assign one
Expected Result:
Tapping on any contact, user must be able to select assignee
Actual Result:
Tapping on any contact, user unable to select assignee
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.56-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/6d11370e-c9b4-4d59-b613-bd3ec418152d
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01198bfad5e1717772
Upwork Job ID:<PHONE_NUMBER>312887296
Last Price Increase: 2023-08-29
Automatic offers:

shubham1206agra | Contributor | 26488545

This looks like there is a long-running operation on the main thread which is blocking UI input for a few seconds before the tap to select a contact finally registers.

I can reproduce but this bug is inconsistent - but updated the OP to be as direct as possible on how to reproduce it. I think this can be External

Unable to repro on DEV

@shubham1206agra It's reproducible on the latest main. I'm also attaching a video for reference.
https://github.com/Expensify/App/assets/61146594/13d79bfb-f49f-48cc-a80d-b779c63e27eb
@saalimzafar I don't think your suggested root cause is correct, and the same applies to the solution you provided. The isLoading state controls whether the option list is visible or not, and it's set before any user interaction with the list. You can find it here:
https://github.com/Expensify/App/blob/4f412db5e26782740529eb0ef17b5db157628413/src/pages/tasks/TaskAssigneeSelectorModal.js#L202
Your proposed change would cause this screen to be stuck in the loading state, and only the skeleton of the components would be visible.

It appears that the issue is reproducible right after the task is created. If you navigate away from it and then return, it seems to work as intended.

Proposal
Please re-state the problem that we are trying to solve in this issue
Assign task-Tapping on any contact, user unable to select assignee
What is the root cause of that problem?
This is due to race condition between unmounting NewTaskPage (which calls to clear the contents of Task inside Onyx) and setting the report inside task Onyx after the API call (or optimistic onyx set of the report and maybe response too).
This problem will occur when
https://github.com/Expensify/App/blob/43c6f11bd59b1d83ed4cef1162610f3e34aff701/src/pages/tasks/NewTaskPage.js#L100-L108
will execute after
https://github.com/Expensify/App/blob/43c6f11bd59b1d83ed4cef1162610f3e34aff701/src/components/ReportActionItem/TaskView.js#L44-L46
And props.report never changes after that in TaskView component.
What changes do you think we should make in order to solve the problem?
Temporarily block the change in the task changes in Promise then mechanism when unmounting the NewTaskPage, and after unmounting, we can start resolving the changes (i.e. after calling of clearOutTaskInfo).
Examples of similar mechanisms can be found for Growl
https://github.com/Expensify/App/blob/43c6f11bd59b1d83ed4cef1162610f3e34aff701/src/libs/Growl.js
What alternative solutions did you explore? (Optional)

I cannot longer reproduce this issue on production environment, could you double-check on your end also?

I cannot longer reproduce this issue on production environment, could you double-check on your end?

@robertKozik
It's really hard to repro the issue from the start cause it's a race condition which has special case

I got it, but beforehand (two days ago) I was able to reproduce it continuously. I'll try to repro it again and again
@shubham1206agra about your proposal - Root cause is propably correct (I'll confirm it as soon as I will be able to reproduce it). But using the simmilar machanism to Growl seems like an overkill there. Maybe we can try to extend the function Task.createTaskAndNavigate so it will synchronously invoke the Task.clearOutTaskInfo before executing navigation process? So we will no longer dependant only on component recycle method (returning the function from useEffect)

I got it, but beforehand (two days ago) I was able to reproduce it continuously. I'll try to repro it again and again
@shubham1206agra about your proposal - Root cause is propably correct (I'll confirm it as soon as I will be able to reproduce it). But using the simmilar machanism to Growl seems like an overkill there. Maybe we can try to extend the function Task.createTaskAndNavigate so it will synchronously invoke the Task.clearOutTaskInfo before executing navigation process? So we will no longer dependant only on component recycle method (returning the function from useEffect)

Ok
This will be easier ig

Able to reproduce - I can continuously do that on iphone se simulator. @shubham1206agra I can confirm your root cause of the issue - we indeed have some race condition here

Able to reproduce - I can continuously do that on iphone se simulator. @shubham1206agra I can confirm your root cause of the issue - we indeed have some race condition here

It's just an order of code execution that will determine the outcome of the race. That's why the repro is hard sometimes

@robertKozik Can I take this up in this case?

I had concerns about your solution in my previous comment. I don't think we want to couple two screens with each other that way. Growl component is more general-use one (can be accessed from various places), here we have two separate screens which should work independently from each other.

I had concerns about your solution in my previous comment. I don't think we want to couple two screens with each other that way. Growl component is more general-use one (can be accessed from various places), here we have two separate screens which should work independently from each other.

Ok, I think we can clear task data just before the API call. This will not affect anything and will solve the issue.

Sorry for the inconvenience but I've checked out previous PR related to clearOutTaskInfo and it looks like we are gonna revert the changes from there https://github.com/Expensify/App/pull/23342 . Could you double check whether issues fixed by that would still occurred after this solution? I'm gonna check too

@robertKozik Looks like there's an easier way.
Something overwritten the changes from https://github.com/Expensify/App/issues/23556
Can you find the commit which overwritten the change from this PR?
I am also unable to find the merge commit of this PR in the file TaskAssigneeSelectorModal.js

Sorry for the inconvenience but I've checked out previous PR related to clearOutTaskInfo and it looks like we are gonna revert the changes from there #23342 . Could you double check whether issues fixed by that would still occurred after this solution? I'm gonna check too

We can prevent this problem by using state for title and description just like assignee and shareDestination

I think we should aim for both changes

@robertKozik Looks like there's an easier way. Something overwritten the changes from #23556 Can you find the commit which overwritten the change from this PR? I am also unable to find the merge commit of this PR in the file TaskAssigneeSelectorModal.js

The Issue/PR you have pointed out is not overwritten by anything. Changes are visible on latest main https://github.com/Expensify/App/blob/6e17b64be0e571773bed42446346045c659640d6/src/pages/tasks/TaskAssigneeSelectorModal.js#L117-L122

I think we should aim for both changes

Could you update your proposal accordingly? So I can check it clearly, if we are on the same page there

@robertKozik Looks like there's an easier way. Something overwritten the changes from #23556 Can you find the commit which overwritten the change from this PR? I am also unable to find the merge commit of this PR in the file TaskAssigneeSelectorModal.js

The Issue/PR you have pointed out is not overwritten by anything. Changes are visible on latest main
https://github.com/Expensify/App/blob/6e17b64be0e571773bed42446346045c659640d6/src/pages/tasks/TaskAssigneeSelectorModal.js#L117-L122

Not this one
There's a line in this
Task.setAssigneeValue(option.login,option.accountID,props.route.params.reportID,OptionsListUtils.isCurrentUser(option));

@shubham1206agra
That PR https://github.com/Expensify/App/pull/22778 introduces the function which overwritten the editTaskAndNavigate. But I'm not sure why we need to know this

@shubham1206agra That PR #22778 introduces the function which overwritten the editTaskAndNavigate. But I'm not sure why we need to know this

Looks like it got overwritten here accidently

edit: as I asked before, could you update your proposal and solution so it would be up-to-date?

Done

i don't think we should revert this change - editTaskAssigneeAndNavigate introduces the optimistic creation of the asignee, so removing or changing back this method will cause regression

@robertKozik Which change??

@robertKozik ??

Sorry, I think I've misunderstand your suggestion from the proposal 😅 I think we are good to go, if you could only modify your proposal so the solution we are discussing would be as the main one not the alternative and expand a little section about the state variable for title and description

Sorry, I think I've misunderstand your suggestion from the proposal 😅 I think we are good to go, if you could only modify your proposal so the solution we are discussing would be as the main one not the alternative and expand a little section about the state variable for title and description

Ok

@robertKozik Updated https://github.com/Expensify/App/issues/25689#issuecomment-1690319329
Do you want any other changes?

@robertKozik ?

I think we are ready with proposal :)
chosen proposal: Proposal
contributor: @shubham1206agra
🎀 👀 🎀 C+ reviewed

prepping for payment... @robertKozik should there be a regression test for this?

Also @cristipaval I see a merge freeze was involved in the PR merge, this might have affected the speed bonus. Do we think a speed bonus applies here?

Good point @Christinadobrzyn! Yes the speed bonus should apply, I checked the dates. I held the issue due to that merge freeze.

[X]  [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/23342
[X]  [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23342/files#r1335754275
[X]  [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X]  [@robertKozik] Determine if we should create a regression test for this bug. I think we don't need regression test here. It's rather edge-case scenario, which can be fixed with re-accessing the screen.
[X]  [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

CC. @Christinadobrzyn

Payouts due:
Issue Reporter: NA
Contributor: $1000 +500 bonus @shubham1206agra in Upwork
Contributor+: @robertKozik payment through contract
Eligible for 50% #urgency bonus? Yes - https://github.com/Expensify/App/issues/25689#issuecomment-1732672658
Upwork job is here.
@robertKozik let us know about the regression test so we can get this closed out -thanks!

I don't think we need regression test for it  https://github.com/Expensify/App/issues/25689#issuecomment-1733481176

Ah sorry I missed that note about the regression test. Thanks for clarifying! Closing this out.


Fix plot ensemble model on Windows

Issue #, if available:
https://github.com/autogluon/autogluon/issues/1065
Description of changes:

path attributes already being stored in the node is causing some weird issue to pygraphviz on Windows likely because it somehow treat \\ separator on Windows as escape character.
This PR removes all unneeded attributes from the nodes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Have tested on Windows. Will merge now


v5: Redo .display-* headings

Convert to Sass map
Consolidate font-weights into single option (matching line-height for them)
Add two new sizes and create a new scale
Update migration docs

Fixes #26515 and closes #28453.
Demo: https://deploy-preview-30568--twbs-bootstrap.netlify.com/docs/4.3/content/typography/#display-headings

Maybe we should add the $display-font-sizes map to the docs with scss-docs?


Gamma Correct , image bad color

when trying to upload images of different sizes, a black layer was formed in picture colors other than the original size. this problem ;
public $gamma_correct = false;
I figured it out by typing.

I think it's related to PR #163 and I consider creating the 2.x branch to resolve that or using alternative approach to resolve existed codes.

@falconsw , maintainers of gumlet/php-image-resize rejected any changes or pull requests from me about V2 (see closed PR)
You can use my package: ajur-media/php-image-resize

Sorry. I'm busy at the recent time. And I need to figure out the current way to integrate your PR #163.
Sorry for my delay response.

We are now disabling default gamma correction now.


Can't create LAE collection

The attempt hangs and then returns a 405. This is the same behavior observed when creating Genizah was failing at the end of February, but that was related to https://github.com/pulibrary/figgy/issues/1656 and in this case the manifest is returning in ~45 seconds.
Could this be related to https://github.com/pulibrary/dpul/issues/865?
Impact: this will be needed in the next week.

@kelea99 When you saw the LAE collection here which do you mean:

slug lae-collection, label "Latin American Ephemera - not LAE main site"
slug lae label "Latin American Ephemera"

I assume not the one with the slug lae_isc.

I mean the "Latin American Ephemera" Collection (the Ephemera Project). not the Figgy Collection.


[VSCode Alpha] Freeze on startup

From @tht13 on March 17, 2016 13:29

VSCode Version:0.10.12-alpha 32bd7fd3
OS Version:Win7

The latest version of VSCode alpha freezes during startup when running the extension Gerrit. The reason that I am reporting this here is that the same version of Gerrit (v0.2.1) runs correctly on v0.10.11
I am only able to get the freeze to occur on a specific Git repository, and if I step through the code in debug mode it doesn't freeze. I believe it has something to do with handling of rejected promises.
I will continue to debug the extension, I just posted this here incase a regression had occurred in the way you launch extensions or handle errors within them,.
Copied from original issue: Microsoft/vscode#4361

From @tht13 on March 17, 2016 13:53
Somehow the issue was resolved by deleting everything in appdata/roamin/vscode - alpha/ except for the User folder. Possibly something to look into there?


Where is the Accessibility plugging in Protractor 3.0

Hi all,
Where is the Accessibility plugging (and others) in Protractor 3.0 version?
They should be under node_modules/protractor/plugins path
Protractor 2.5.1 version is the last one with the plugins folder.
Regards
Javi

As mentioned in our changelog, https://github.com/angular/protractor/blob/master/CHANGELOG.md#breaking-changes, plugins have been moved to their own repos.

Great, Thanks a lot!!


Key len check always false?

https://github.com/filip26/iron-ed25519-cryptosuite-2020/blob/24c391f98f854deb29d256b01e5110d6000ed152/src/main/java/com/apicatalog/ld/signature/ed25519/Ed25519Signature2020.java#LL45C43-L45C43
Looks like you're checking the key length against 3 different values, should be || instead of && ?

Hi, thank you for reporting that, looks like a bug. The suite has been refactored, please see https://github.com/filip26/iron-ed25519-cryptosuite-2020/blob/6ec5281205c33922e341fb9e578b9d4dd310f7b3/src/main/java/com/apicatalog/ld/signature/ed25519/Ed25519Signature2020Proof.java#L35


Error while connecting on Channel

Hi All,
I am getting this exception when I receive a message on the bridge
(node:24242) UnhandledPromiseRejectionWarning: TypeError: externalMediaChannel.externalMedia is not a function
at Bridge.addChannel (/Users/MacBookPro/emad-project/asterisk-dialogflow-ari-bridge/lib/Bridge.js:67:59)
Any idea ?
Thanks.

What version of asterisk are you running?
On Fri, 24 Jul 2020, 21:05 TareqD<EMAIL_ADDRESS>wrote:

Hi All,
I am getting this exception when I receive a message on the bridge
(node:24242) UnhandledPromiseRejectionWarning: TypeError:
externalMediaChannel.externalMedia is not a function
at Bridge.addChannel
(/Users/MacBookPro/emad-project/asterisk-dialogflow-ari-bridge/lib/Bridge.js:67:59)
Any idea ?
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nimbleape/asterisk-dialogflow-ari-bridge/issues/10,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB3LLLIRGAFIS2XHGLYRB3R5HSQ5ANCNFSM4PHA4IBA
.

Hi,
We are running version 17.
Thanks

Can you tell.me exactly which version and I'll try and check tomorrow for
you
On Sun, 26 Jul 2020, 11:29 TareqD<EMAIL_ADDRESS>wrote:

Hi,
We are running version 17.
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nimbleape/asterisk-dialogflow-ari-bridge/issues/10#issuecomment-663970757,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB3LLJGVZPKTNA3S4XP2HTR5QAQRANCNFSM4PHA4IBA
.

Hi,
I believe its 17.0.0 , we are using it on aws
https://aws.amazon.com/marketplace/pp/Technology-Innovation-Lab-of-Texas-Asterisk-1700-A/B079Y7449R
Thanks.

I wonder if that one hasn't been compiled with some options ... Have you
tried compiling your own asterisk?
On Sun, 26 Jul 2020, 19:42 TareqD<EMAIL_ADDRESS>wrote:

Hi,
I believe its 17.0.0 , we are using it on aws
https://aws.amazon.com/marketplace/pp/Technology-Innovation-Lab-of-Texas-Asterisk-1700-A/B079Y7449R
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nimbleape/asterisk-dialogflow-ari-bridge/issues/10#issuecomment-664025418,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB3LLI6ZQRUVH2OAMYE54DR5R2IXANCNFSM4PHA4IBA
.

Hi,
I have tried it with 16.12 now, things sorta worked with us, but the line opened and we don't receive any voice.
No exceptions occured, it just opens the channel and no interactions.
Any idea on what happened ? We used your example configurations.
Thanks.

hey @TareqD - were you using a SIP phone or the PSTN?

Hi @danjenkins - we are using Softphone no PSTN. we are getting the message from the intent as text, but we don't here anything.
Thanks.

While I havent needed it.... others have fopund playing back some media to be needed.... have you tried the playback flag in the config? https://github.com/nimbleape/asterisk-dialogflow-ari-bridge/blob/master/config/default.js#L16

I will give it a try today.
Thanks.

Hi,
Enable playback: 'silence/1' didn't make the trick. Any ideas ?

Not really... can you get me any logs that are relevant from asterisk or the node app? I assume youre also running the other corresponding project?

Yes I do, of course, I will send:
Here is the logs for the ari-bridge:
[1596550793472] INFO  (Asterisk-Dialogflow-ARI-Bridge/55030 on MBPs-MBP): channel entered our application     id: "1596550793.76"     event: {       "type": "StasisStart",       "timestamp": "2020-08-04T14:19:53.356+0000",       "args": [],       "channel": {         "id": "1596550793.76",         "name": "SIP/102-0000003d",         "state": "Ring",         "caller": {           "name": "102",           "number": "102"         },         "connected": {           "name": "",           "number": ""         },         "accountcode": "",         "dialplan": {           "context": "from-internal",           "exten": "7000",           "priority": 2,           "app_name": "Stasis",           "app_data": "playback-example"         },         "creationtime": "2020-08-04T14:19:53.355+0000",         "language": "en"       },       "asterisk_id": "0e:79:e0:78:29:85",       "application": "playback-example"     } [1596550795208] INFO  (Asterisk-Dialogflow-ARI-Bridge/55030 on MBPs-MBP): created an externalMedia channel [1596550795209] INFO  (Asterisk-Dialogflow-ARI-Bridge/55030 on MBPs-MBP): got a stasisStart event on the externalMediaChannel     type: "StasisStart"     args: []     channel: {       "id": "1cc2a564-6989-45d2-ad58-6923c92443f1",       "name": "UnicastRTP/<IP_ADDRESS>:7777-0x7f03bc007020",       "state": "Up",       "caller": {         "name": "",         "number": ""       },       "connected": {         "name": "",         "number": ""       },       "accountcode": "",       "dialplan": {         "context": "default",         "exten": "s",         "priority": 1,         "app_name": "Stasis",         "app_data": "playback-example"       },       "creationtime": "2020-08-04T14:19:55.115+0000",       "language": "en"     }     asterisk_id: "0e:79:e0:78:29:85"     application: "playback-example" [1596550796995] INFO  (Asterisk-Dialogflow-ARI-Bridge/55030 on MBPs-MBP): got a message     topic: "dialogflow-asterisk/1596550793.76/events"     payload: {       "transcript": null,       "intent": {         "fulfillmentMessages": [           {             "platform": "PLATFORM_UNSPECIFIED",             "text": {               "text": [                 "Good day! what are you trying to do at Moussa's office?"               ]             },             "message": "text"           }         ],         "outputContexts": [],         "queryText": "WELCOME",         "speechRecognitionConfidence": 0,         "action": "input.welcome",         "parameters": {           "fields": {}         },         "allRequiredParamsPresent": true,         "fulfillmentText": "Good day! what are you trying to do at Moussa's office?",         "webhookSource": "",         "webhookPayload": null,         "intent": {           "inputContextNames": [],           "events": [],           "trainingPhrases": [],           "outputContexts": [],           "parameters": [],           "messages": [],           "defaultResponsePlatforms": [],           "followupIntentInfo": [],           "name": "projects/api-interaction-iqxkeu/agent/intents/fc1a820e-e19d-4836-bc05-cb0715c391b1",           "displayName": "Default Welcome Intent",           "priority": 0,           "isFallback": false,           "mlEnabled": false,           "webhookState": "WEBHOOK_STATE_UNSPECIFIED",           "action": "",           "resetContexts": false,           "rootFollowupIntentName": "",           "parentFollowupIntentName": "",           "mlDisabled": false,           "endInteraction": false         },         "intentDetectionConfidence": 1,         "diagnosticInfo": null,         "languageCode": "en",         "sentimentAnalysisResult": null,         "knowledgeAnswers": null       }     } [1596550800635] INFO  (Asterisk-Dialogflow-ARI-Bridge/55030 on MBPs-MBP): got a message     topic: "dialogflow-asterisk/1596550793.76/events"     payload: {       "timeout": true     }

Here is the astrisk logs:
`Executing [7000@from-internal:1] NoOp("SIP/102-00000006", "") in new stack
-- Executing [7000@from-internal:2] Stasis("SIP/102-00000006", "playback-example") in new stack
Audio is at 16868
Adding codec ulaw to SDP
Adding codec alaw to SDP
Adding non-codec 0x1 (telephone-event) to SDP
<--- Reliably Transmitting (NAT) to <IP_ADDRESS>:56020 --->
SIP/2.0 200 OK
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;branch=z9hG4bKPjc2567339b5234402b6e579d9263fe211;received=<IP_ADDRESS>;rport=56020
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1425 INVITE
Server: TILTX
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Session-Expires: 1800;refresher=uas
Contact: sip:7000@<IP_ADDRESS>:5060
Content-Type: application/sdp
Require: timer
Content-Length: 276
v=0
o=root<PHONE_NUMBER><PHONE_NUMBER> IN IP4 <IP_ADDRESS>
s=Asterisk PBX 16.12.0
c=IN IP4 <IP_ADDRESS>
t=0 0
m=audio 16868 RTP/AVP 0 8 101
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-16
a=ptime:20
a=maxptime:150
a=sendrecv
<------------>
Retransmitting #1 (NAT) to <IP_ADDRESS>:56020:
SIP/2.0 200 OK
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;branch=z9hG4bKPjc2567339b5234402b6e579d9263fe211;received=<IP_ADDRESS>;rport=56020
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1425 INVITE
Server: TILTX
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Session-Expires: 1800;refresher=uas
Contact: sip:7000@<IP_ADDRESS>:5060
Content-Type: application/sdp
Require: timer
Content-Length: 276
v=0
o=root<PHONE_NUMBER><PHONE_NUMBER> IN IP4 <IP_ADDRESS>
s=Asterisk PBX 16.12.0
c=IN IP4 <IP_ADDRESS>
t=0 0
m=audio 16868 RTP/AVP 0 8 101
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-16
a=ptime:20
a=maxptime:150
a=sendrecv

0x7f9db800b540 -- Strict RTP switching to RTP target address <IP_ADDRESS>:7072 as source

<--- SIP read from UDP:<IP_ADDRESS>:56020 --->
ACK sip:7000@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;rport;branch=z9hG4bKPjcd143dcd514a40818eff0c108a342887
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1425 ACK
Max-forwards: 70
Content-Length: 0
<------------->
--- (8 headers 0 lines) ---
<--- SIP read from UDP:<IP_ADDRESS>:56020 --->
INVITE sip:7000@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;rport;branch=z9hG4bKPja5c83878f7b44ccdadfb499a5118a247
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1426 INVITE
Contact: "102" sip:102@<IP_ADDRESS>:56020;ob
Content-Type: application/sdp
Allow: PRACK
Allow: INVITE
Allow: ACK
Allow: BYE
Allow: CANCEL
Allow: UPDATE
Allow: INFO
Allow: SUBSCRIBE
Allow: NOTIFY
Allow: REFER
Allow: MESSAGE
Allow: OPTIONS
Max-forwards: 70
Supported: replaces
Supported: 100rel
Supported: timer
Supported: norefersub
Session-expires: 1800;refresher=uas
Min-se: 90
Content-Length: 316
v=0
o=-<PHONE_NUMBER><PHONE_NUMBER> IN IP4 <IP_ADDRESS>
s=pjmedia
b=AS:84
t=0 0
a=X-nat:0
m=audio 7072 RTP/AVP 0 101
c=IN IP4 <IP_ADDRESS>
b=TIAS:64000
a=rtcp:4013 IN IP4 <IP_ADDRESS>
a=ssrc:306277939 cname:6a3b519940501428
a=rtpmap:0 PCMU/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-16
a=sendrecv
<------------->
--- (28 headers 15 lines) ---
Sending to <IP_ADDRESS>:56020 (NAT)
Comparing SDP version<PHONE_NUMBER> -><PHONE_NUMBER> and unique parts [-<PHONE_NUMBER> IN IP4 <IP_ADDRESS>] -> [-<PHONE_NUMBER> IN IP4 <IP_ADDRESS>]
Found RTP audio format 0
Found RTP audio format 101
Found audio description format PCMU for ID 0
Found audio description format telephone-event for ID 101
Capabilities: us - (ulaw|alaw), peer - audio=(ulaw)/video=(nothing)/text=(nothing), combined - (ulaw)
Non-codec capabilities (dtmf): us - 0x1 (telephone-event|), peer - 0x1 (telephone-event|), combined - 0x1 (telephone-event|)
Peer audio RTP is at port <IP_ADDRESS>:7072
<--- Transmitting (NAT) to <IP_ADDRESS>:56020 --->
SIP/2.0 100 Trying
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;branch=z9hG4bKPja5c83878f7b44ccdadfb499a5118a247;received=<IP_ADDRESS>;rport=56020
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1426 INVITE
Server: TILTX
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Session-Expires: 1800;refresher=uas
Contact: sip:7000@<IP_ADDRESS>:5060
Content-Length: 0
<------------>
Audio is at 16868
Adding codec ulaw to SDP
Adding non-codec 0x1 (telephone-event) to SDP
<--- Reliably Transmitting (NAT) to <IP_ADDRESS>:56020 --->
SIP/2.0 200 OK
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;branch=z9hG4bKPja5c83878f7b44ccdadfb499a5118a247;received=<IP_ADDRESS>;rport=56020
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1426 INVITE
Server: TILTX
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Session-Expires: 1800;refresher=uas
Contact: sip:7000@<IP_ADDRESS>:5060
Content-Type: application/sdp
Require: timer
Content-Length: 252
v=0
o=root<PHONE_NUMBER><PHONE_NUMBER> IN IP4 <IP_ADDRESS>
s=Asterisk PBX 16.12.0
c=IN IP4 <IP_ADDRESS>
t=0 0
m=audio 16868 RTP/AVP 0 101
a=rtpmap:0 PCMU/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-16
a=ptime:20
a=maxptime:150
a=sendrecv
<------------>
-- Channel SIP/102-00000006 joined 'simple_bridge' stasis-bridge
<--- SIP read from UDP:<IP_ADDRESS>:56020 --->
ACK sip:7000@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;rport;branch=z9hG4bKPjcd143dcd514a40818eff0c108a342887
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1425 ACK
Max-forwards: 70
Content-Length: 0
<------------->
--- (8 headers 0 lines) ---
Retransmitting #1 (NAT) to <IP_ADDRESS>:56020:
SIP/2.0 200 OK
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;branch=z9hG4bKPja5c83878f7b44ccdadfb499a5118a247;received=<IP_ADDRESS>;rport=56020
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1426 INVITE
Server: TILTX
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Session-Expires: 1800;refresher=uas
Contact: sip:7000@<IP_ADDRESS>:5060
Content-Type: application/sdp
Require: timer
Content-Length: 252
v=0
o=root<PHONE_NUMBER><PHONE_NUMBER> IN IP4 <IP_ADDRESS>
s=Asterisk PBX 16.12.0
c=IN IP4 <IP_ADDRESS>
t=0 0
m=audio 16868 RTP/AVP 0 101
a=rtpmap:0 PCMU/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-16
a=ptime:20
a=maxptime:150
a=sendrecv

<--- SIP read from UDP:<IP_ADDRESS>:56020 --->
ACK sip:7000@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;rport;branch=z9hG4bKPj2d3925cbb88c4a58a47be16eb7b7c4a8
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1426 ACK
Max-forwards: 70
Content-Length: 0
<------------->
--- (8 headers 0 lines) ---

0x7f9db801ad10 -- Strict RTP learning after remote address set to: <IP_ADDRESS>:7777
-- Called <IP_ADDRESS>:7777
-- UnicastRTP/<IP_ADDRESS>:7777-0x7f9db8006da0 answered
Launching Stasis(playback-example) on UnicastRTP/<IP_ADDRESS>:7777-0x7f9db8006da0

<--- SIP read from UDP:<IP_ADDRESS>:56020 --->
ACK sip:7000@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;rport;branch=z9hG4bKPj2d3925cbb88c4a58a47be16eb7b7c4a8
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1426 ACK
Max-forwards: 70
Content-Length: 0
<------------->
--- (8 headers 0 lines) ---
-- Channel UnicastRTP/<IP_ADDRESS>:7777-0x7f9db8006da0 joined 'simple_bridge' stasis-bridge
[Aug 4 14:49:25] WARNING[7552]: channel.c:6646 ast_channel_make_compatible_helper: No path to translate from UnicastRTP/<IP_ADDRESS>:7777-0x7f9db8006da0 to SIP/102-00000006
-- Channel UnicastRTP/<IP_ADDRESS>:7777-0x7f9db8006da0 left 'simple_bridge' stasis-bridge

0x7f9db800b540 -- Strict RTP learning complete - Locking on source address <IP_ADDRESS>:7072
Reliably Transmitting (NAT) to <IP_ADDRESS>:5060:
OPTIONS sip:<IP_ADDRESS>;user=phone SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK7cbfc6c6;rport
Max-Forwards: 70
From: "asterisk" sip:asterisk@<IP_ADDRESS>;tag=as22af7152
To: sip:<IP_ADDRESS>;user=phone
Contact: sip:asterisk@<IP_ADDRESS>:5060
Call-ID: 5deae82837c5770722a677972a75e17e@<IP_ADDRESS>:5060
CSeq: 102 OPTIONS
User-Agent: TILTX
Date: Tue, 04 Aug 2020 14:49:29 GMT
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Content-Length: 0

<--- SIP read from UDP:<IP_ADDRESS>:5060 --->
SIP/2.0 200 OK
Via: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK7cbfc6c6;rport;received=<IP_ADDRESS>
From: "asterisk" sip:asterisk@<IP_ADDRESS>;tag=as22af7152
To: sip:<IP_ADDRESS>;user=phone;tag=as72abdde9
Call-ID: 5deae82837c5770722a677972a75e17e@<IP_ADDRESS>:5060
CSeq: 102 OPTIONS
Server: FPBX-2.11.0(<IP_ADDRESS>)
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH
Supported: replaces, timer
Contact: sip:<IP_ADDRESS>:5060
Accept: application/sdp
Content-Length: 0
<------------->
--- (12 headers 0 lines) ---
Really destroying SIP dialog '5deae82837c5770722a677972a75e17e@<IP_ADDRESS>:5060' Method: OPTIONS
<--- SIP read from UDP:<IP_ADDRESS>:56020 --->
BYE sip:7000@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;rport;branch=z9hG4bKPjdf0427d98278425da0d16abca471005c
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1427 BYE
Max-forwards: 70
User-agent: MicroSIP/3.19.31
Content-Length: 0
<------------->
--- (9 headers 0 lines) ---
Sending to <IP_ADDRESS>:56020 (NAT)
Scheduling destruction of SIP dialog '9204e1714c8a4cff8e58aadec312c084' in 14720 ms (Method: BYE)
<--- Transmitting (NAT) to <IP_ADDRESS>:56020 --->
SIP/2.0 200 OK
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;branch=z9hG4bKPjdf0427d98278425da0d16abca471005c;received=<IP_ADDRESS>;rport=56020
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1427 BYE
Server: TILTX
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Content-Length: 0
<------------>
-- Channel SIP/102-00000006 left 'simple_bridge' stasis-bridge
<--- SIP read from UDP:<IP_ADDRESS>:56020 --->
BYE sip:7000@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;rport;branch=z9hG4bKPj95f42ab85cfa41fe8dd793404b85b3f2
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1428 BYE
Max-forwards: 70
User-agent: MicroSIP/3.19.31
Content-Length: 0
<------------->
--- (9 headers 0 lines) ---
Sending to <IP_ADDRESS>:56020 (NAT)
<--- Transmitting (NAT) to <IP_ADDRESS>:56020 --->
SIP/2.0 200 OK
Via: SIP/2.0/UDP <IP_ADDRESS>:56020;branch=z9hG4bKPj95f42ab85cfa41fe8dd793404b85b3f2;received=<IP_ADDRESS>;rport=56020
From: "102" sip:102@<IP_ADDRESS>;tag=a02a3f41b1e84ffda9927da2fafff653
To: sip:7000@<IP_ADDRESS>;tag=as3073ce1e
Call-ID: 9204e1714c8a4cff8e58aadec312c084
CSeq: 1428 BYE
Server: TILTX
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Content-Length: 0
<------------>
Really destroying SIP dialog '4d7ab751ca64425fb6534bb851cbe181' Method: REGISTER
Really destroying SIP dialog 'f2e706b0da914038b8954c61a355d0da' Method: REGISTER
ip-172-31-43-12CLI> sip set debug off
SIP Debugging Disabled
-- Remote UNIX connection
-- Remote UNIX connection disconnected
ip-172-31-43-12CLI>`

Are you actually getting audio back from dialogflow? put in a console.log where the code for audio playback is

We got to work finally. The issue was I am doing the same runs on the same servers which seems to do the issue.
Million thanks for the support man.

ah - yes - UDP and NAT ;)

Hello!
I'm facing the same error.
I have a single server with public IP for all components:  ubuntu 20.04, using its packages of asterisk 16.2.1, mosquitto 1.6.9, and nodejs 10.19.0.
I am running the ARI-Bridge, and the RTP-Audioserver from NimbleApe.
I have a DialogFlow agent created and running.
I think all configs are ok, checked and debugged several times.
But when I run the ARI-Bridge, an I call to the extension, I can heard a "hello-world" at the start I put for debugging, but when "ari-bridge" tries to create the externalMediaRes it fails with:
-> TypeError: externalMediaChannel.externalMedia is not a function
I am struggling for hours with this and I am stuck.
Any idea?
Thank you very much! :)

Hello again! Problem solved!! The problem was in Asterisk.
Neither Ubuntu's Asterisk 16 nor a compiled Asterisk 18 had enabled all the necessary modules.
At the end, setting  autoload = yes  in /etc/asterisk/modules.conf  was the solution.
If not set, some modules like chan_rtp, and dependencies didn't work.
Great work and thank you for the scripts!
Regards.


magnified image not displayed correctly if component is not visible when first mounted

Hello Ethan,
Great work on this library! I'll be happy to provide a fix if you think this is a legit issue. In short, the issue is that the enlarged image does not appear correctly if our component is placed within other UI that has hidden the component when it is first mounted (via display:none on an ancestor DOM element).

I've got rim components embedded within an Accordion Component. I have enlargedImagePosition: 'over' . I think Accordion is using display:none and block to toggle visibility of content.
When the page loads,  the smallImageEl/img element has offsetWidth and offSetHeight of 0. As a result, the enlarged image dimensions are also zero and remain there, even when the rim component is finally displayed (by using the Accordion).
I suspect this is because 'componentDidMount' in ReactImageMagnify.js doesn't get called when the rim component comes into view. I tried to force matters by calling setSmallImageDimensionState when the user clicks to expand an Accordion element but it doesn't help, probably because the event gets called before the offset dimensions of the img element have updated.

Before thinking of other ways to trigger  setSmallImageDimensionState, I should ask if this is user error on my part...

Hi @tojvan - Thanks for the detailed explanation of your issue. I'm wondering what happens if you provide width and height props on the small image object, like this. Do you get something closer to the result you are looking for?

thanks for the response! does not seem to make a difference. confirmed that the props were being set (via Inspect --> React) but the div that gets created on hover still had 0px width and height.
i've been wondering if it'd be appropriate to call setSmallImageDimensionState on hover for situations like this. we could put the call behind a new property such as setSmallImageDimensionsOnHover. when it's true, we would only call setSmallImageDimensionState on hover and not on mount (and keep the call on window-resize in either case).

Hi @tojvan - I'm surprised you have zero height when configuring small image dimensions. Something I neglected to write in my previous post is to remove or set false the small image property isFluidWidth.  When isFluidWidth is set false, small image dimensions are read from the small image props. Please let me know your findings. Thanks!

@ethanselzer, that restores the zoom function, thanks. i'll have to think about layout some more, however. the images being zoomed are dynamically fetched and  will have different aspect ratios. that, and responsive...

@tojvan - Thanks for the feedback. It may be possible to invoke setSmallImageDimensionState by setting a ref on ReactImageMagnify and then using it in your parent component like this myRef. setSmallImageDimensionState().

Hi, I came here encountering the same issue. Any work arounds available? Setting small image fluid to false makes the large image goes giant, and zoom now works, but it pops up a very large image on the side

I found a solution in my case where I had  inside a map of images
setting a new key on click on rim
https://reactjs.org/docs/reconciliation.html#keys
const [activeIndex, setActiveIndex] = useState(0)
{map(images, (image, idx) => (
<ReactImageMagnify key={idx + activeIndex} {...{
smallImage: {
alt: 'main',
isFluidWidth: true,
src: image,
},
largeImage: {
src: image,
width: 1500,
height: 1500,
},
shouldUsePositiveSpaceLens: true,
}} />
))}
I am sure you can find a solution to remount in your case.


add getDescription and getMediaSection helpers

mostly for testing. Not very efficient right now.

Codecov Report

Merging #43 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #43     +/-   ##
=========================================
+ Coverage   91.05%   91.26%   +0.2%
=========================================
  Files           1        1
  Lines         302      309      +7
=========================================
+ Hits          275      282      +7
  Misses         27       27

Impacted Files
Coverage Δ

sdp.js
91.26% <100%> (+0.2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2666f93...43337fe. Read the comment docs.

published as 2.6.0


adding zinc finger to ProteinFeatures

@ielis
There are many errors related to allele_count. These are not related to this PR. Is this a known issue or should I try to fix?

I do not see any issue with allele_count in the context of this PR. The CI fails because of a REST API timeout, which is a common issue.
If you see
UNEXPECTED EXCEPTION: HTTPError('429 Client Error: TOO MANY REQUESTS for url: https://rest.variantvalidator.org/VariantValidator/tools/gene2transcripts/NM_181486.4')

then pls just re-run the CI until it passes.

Can you please check this locally? Why I run pytest in Pycharm I get about 20 errors because of this.

One CI ran OK (3.11), which should mean that the issue is local to your environment. The CI run for 3.10 stopped due to timeout, leading to cancellation of 3.12.
So, thanks to 3.11 finishing, I am almost sure that the PR will pass on my side.

Fixes #344


Xray index option for federated repositories does not sync

Describe the bug
We recently realized that the xrayIndex (boolean) property does not properly sync between federated repositories, which is apparent when applying our Terraform code, since we create these repositories on only one cluster and expect their settings to be synchronized to others.
In Europe, Watches creations generate errors, because the target federated repositories are not indexed, when they should be by replication of the US configurations.
Requirements for and issue

[x] A description of the bug

[x] A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.

resource "artifactory_federated_docker_v2_repository" "terraform-federated-test-docker-repo" {
  key       = "terraform-federated-test-docker-repo"

  xray_index = true

  member {
    url     = "http://tempurl.org/artifactory/terraform-federated-test-docker-repo"
    enabled = true
  }

  member {
    url     = "http://tempurl2.org/artifactory/terraform-federated-test-docker-repo-2"
    enabled = true
  }
}

[x] Your version of artifactory (you can curl it at $host/artifactory/api/system/version
7.59.9

[x] Your version of terraform
1.5.4

[x] Your version of terraform provider
9.0.0

Expected behavior
We expect the xrayIndex (boolean) property to sync between federated repositories.

May be related to #825

In this case, even in the creation of the repo the xray index option is not syncing. The #845 is referring to the update. Definitively either way we need the provider to be able to sync the federated repo options.

@gmartinezmelo The synchronization of the repository settings are not done by the Terraform provider. This is performed by Artifactory.
The provider can potentially trigger a synchronization as suggested in #825, but fundamentally this isn't not the core responsibility of the provider.

Thank you very much @alexhung, for clarifying this. As this not an issue with the provider but and Artifactory sync issue, I will close this issue.


[FEA][AUDIT][SPARK-44641] Incorrect result in certain scenarios when SPJ is not triggered

Closes https://github.com/NVIDIA/spark-rapids/issues/9180
This PR copies the 340 shim version of BatchScanExec into the 350 shim and applies the following change, to reflect the change made in https://github.com/apache/spark/commit/5c7d1e2f8a#diff-f82edfef27867e1285af13f3603efbc5e77d81d715d427db4b51f0c3e3a0df14.
<               finalPartitions = p.partitionValues.map { partValue =>
---
>
>               // In case `commonPartitionValues` is not defined (e.g., SPJ is not used), there
>               // could exist duplicated partition values, as partition grouping is not done
>               // at the beginning and postponed to this method. It is important to use unique
>               // partition values here so that grouped partitions won't get duplicated.
>               finalPartitions = p.uniquePartitionValues.map { partValue =>

As noted in the issue, it is not easy to add a test for this because OSS Spark does not have any V2 data sources that implement SupportsReportPartitioning.

To reduce code duplication. Would it be okay to fix this bug in all versions of Spark? I know we would not be bug for bug compatible, technically, but it would save on a lot of code duplication, and I don't think it would be that big of a deal.

To reduce code duplication. Would it be okay to fix this bug in all versions of Spark? I know we would not be bug for bug compatible, technically, but it would save on a lot of code duplication, and I don't think it would be that big of a deal.

I added a new shim KeyGroupedPartitioningShim for getting the unique partitions and removed the duplicate of GpuBatchScanExec. I did not port the fix back to 3.3.0 or earlier because the GpuBatchScanExec code in Spark is structured differently for those versions and it isn't clear to me where the fix should be applied.

To reduce code duplication. Would it be okay to fix this bug in all versions of Spark? I know we would not be bug for bug compatible, technically, but it would save on a lot of code duplication, and I don't think it would be that big of a deal.

I added a new shim KeyGroupedPartitioningShim for getting the unique partitions and removed the duplicate of GpuBatchScanExec. I did not port the fix back to 3.3.0 or earlier because the GpuBatchScanExec code in Spark is structured differently for those versions and it isn't clear to me where the fix should be applied.

The v2 bucketing configs are new in 3.4.0, so I don't think we need to do anything with prior versions.

build


Bug with bootstrap-vue modals

I try to make the slide bar inside modal, but when the model shown the slide bar is bugged: i can't change value, always 100 and the range is in 0.

The solution is
Add this property to b-modal
`@shown="refreshSlide"`

And then add this method
refreshSlide(){
      this.$refs.slidebar.refresh()
  }


Add a target called list to the Makefile.common in order to list all targets for make

Description
Same as the title of the PR.
Testing
> make -f Makefile.common list | xargs
arpa clean coverage default echo-project-name echo-proof-uid goto litani-path property report report1 report2 result setup_dependencies testdeps veryclean

I found this Stackoverflow response helpful.


AZ-800 Labs Updated

Module/Lab: 00
Exercise: 00
Fixes # .
Changes proposed in this pull request:

Relevant Issues link

updated with changes for Azure AD to Microsoft Entra ID