[wasm] Fix CocoaError construction for unsupported copy/link operations

This is a follow-up fix for 6c0a3e8453cdde633e1c55f6112fd53a0d756979, which re-organized CocoaError helper functions, to repair the following build failure:
/home/build-user/swift-foundation/Sources/FoundationEssentials/FileManager/FileOperations.swift:926:36: error: 'fileOperationError' is inaccessible due to 'private' protection level
  74 |     }
  75 | #else
  76 |     private static func fileOperationError(_ errNum: Int32, _ suspectedErroneousPath: String, sourcePath: String? = nil, destinationPath: String? = nil, variant: String? = nil) -> CocoaError {
     |                         `- note: 'fileOperationError(_:_:sourcePath:destinationPath:variant:)' declared here
  77 |         // Try to be a little bit more intelligent about which path should be reported in the error. In the case of ENAMETOOLONG, we can more accurately guess which path is causing the error without racily checking the file system after the fact. This may not be perfect in the face of operations which span file systems, or on file systems that only support names/paths less than NAME_MAX or PATH_MAX, but it's better than nothing.
  78 |         var erroneousPath = suspectedErroneousPath
     :
 924 |             // wasi-libc does not support FTS for now, so we don't support copying/linking
 925 |             // directories on WASI for now.
 926 |             let error = CocoaError.fileOperationError(.featureUnsupported, src, dst)
     |                                    `- error: 'fileOperationError' is inaccessible due to 'private' protection level
 927 |             try delegate.throwIfNecessary(error, src, dst)
 928 |             return

@swift-ci please test

I'll merge this once I verified the change in our CI https://github.com/swiftwasm/swiftwasm-build/pull/440


gjs: 1.70.0 -> 1.70.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for gjs is: "JavaScript bindings for GNOME"
meta.homepage for gjs is: "https://gitlab.gnome.org/GNOME/gjs/blob/master/doc/Home.md"
meta.changelog for gjs is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
gjs result is not automatically checked, because some tests take a long time to run

Rebuild report (if merged into master) (click to expand)

63 total rebuild path(s)

60 package rebuild(s)

60 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
adapta-gtk-theme
chrome-gnome-shell
clapper
flatpak
flatpak-builder
foliate
gjs
glade
gnome-builder
gnome.anjuta
gnome.gnome-books
gnome.gnome-characters
gnome.gnome-documents
gnome.gnome-maps
gnome.gnome-session
gnome.gnome-shell
gnome.gnome-software
gnome.gnome-sound-recorder
gnome.gnome-terminal
gnome.gnome-tweaks
gnome.gnome-weather
gnome.gpaste
gnome.polari
gnome.sushi
gnomeExtensions.ddterm
gnomeExtensions.drop-down-terminal
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.night-theme-switcher
gnomeExtensions.pop-shell
gnomeExtensions.screenshot-tool
gnunet-gtk
gtkpod
haskellPackages.gi-ostree
libsForQt5.discover
libsForQt512.discover
libsForQt514.discover
libsForQt515.discover
malcontent-ui
minishift
ostree
pantheon.appcenter
pantheon.elementary-greeter
pantheon.elementary-onboarding
pantheon.elementary-session-settings
pantheon.sideload
pantheon.switchboard-plug-applications
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-with-indicators

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8am0qy2hhapkkzbmfjhgx0i1fs0qbcgf-gjs-1.70.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gjs https://github.com/r-ryantm/nixpkgs/archive/1c8c66a7280168f1eae474cd82c7288743d64f7d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8am0qy2hhapkkzbmfjhgx0i1fs0qbcgf-gjs-1.70.1
ls -la /nix/store/8am0qy2hhapkkzbmfjhgx0i1fs0qbcgf-gjs-1.70.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @hedning @jtojnar @dasj19 @maxeaubrey for testing.

Changes look okay:

Version 1.70.1

Build and crash fixes backported from the development branch.
Closed bugs and merge requests:

Handle optional out parameters in callbacks [#439, !681, Evan Welsh]
Link fails on Debian armel|mipsel|powerpc: needs more -latomic [#442, !686,Simon McVittie]
gjs/jsapi-util.cpp: fix build on gcc-12 [!697, Sergei Trofimovich]


Captions status inconsistent after reloading

Load the demo app with Angel One. Turn on the English Captions.
Hit 'Load' button again.
The captions menu shows that 'English' is selected, however English captions is not being displayed.

The text container appears to be at z-index -1, while the controls and video are both at z-index 0.  So the text is not only behind the controls, but the video.  I think this is a duplicate of #1878.

I see the same issue

I stand corrected.  Separate issue.

This also happens if you set the Preferred audio language to a different value than Preferred text language.  The UI says captions are enabled but none show.  I also get an assertion failure saying text visibility has fallen out of sync.


Add documentation about how to customise containers, args, and tweak resources

As requested here: https://github.com/nf-core/viralrecon/issues/348
Closes #1643
Note I also transferred over from viralrecon the containers update, and clarified a few things on the resource tweaks.
Once this is in, I'll replace the template docs to point to these docs rather than have the current wordy RNASEQ example.

@nf-core-bot fix linting


wcversion fails when checking project in which ant build file resides [Tigris #1463]

Description
When pointed at the (versioned) directory in which the build file resides,
wcversion reports that "the path ... is not under version control !".

To reproduce in Eclipse:

(1) Use the following build file:

<?xml version="1.0" encoding="UTF-8"?>
<project name="project" default="default">
  <taskdef resource="org/tigris/subversion/svnant/svnantlib.xml"/>
  <svnSetting id="settings.svn" javahl="false" svnkit="false" failonerror="true"/>
  <target name="default" description="description">
    <svn refid="settings.svn">
      <wcversion path="${basedir}/../eclipse-project-under-version-control"
processUnversioned="true"/>
    </svn>
  </target>
</project>

(2) Have two projects in Eclipse: one, called in the build file
'eclipse-project-under-version-control', must be under version control.

(3) Place the build file in the root of each project.

(4) Make sure svnant-1.3.1 and svnClientAdapter-0.9.102 are on the ant
classpath; make sure you have subversion installed on the command line

(5) When run from "eclipse-project-under-version-control" the build fails.
Here's the output on my machine:

> Buildfile: C:\Users\markaf\Documents\Eclipse Workspaces\Projects
Workspace\eclipse-project-under-version-control\test.xml
> default:
>       [svn] <WcVersion> failed.
>
> BUILD FAILED
> C:\Users\markaf\Documents\Eclipse Workspaces\Projects
Workspace\eclipse-project-under-version-control\test.xml:12: The path
'C:\Users\markaf\Documents\Eclipse Workspaces\Projects
Workspace\eclipse-project-under-version-control' is not under version control !
>
> Total time: 1 second

(6) When run from the other project, the build succeeds.  My output is:

> Buildfile: C:\Users\markaf\Documents\Eclipse Workspaces\Projects
Workspace\test\test.xml
> default:
> BUILD SUCCESSFUL
> Total time: 2 seconds

Environment:
Windows 7 x64
SVN 1.7.2-SlikSvn-1.7.2-X64 (SlikSvn/1.7.2) X64
Eclipse 3.8.0
Svnant 1.3.1
Svn Client adapter 0.9.102

Subclipse installation:
Subversion Client Adapter 1.8.3
Subversion Revision Graph 1.1.1
SVN Team Provider Core 1.8.16
SVNKit Client Adapter <IP_ADDRESS>

Metadata Imported from Tigris (Issue 1463)

Creation Date: 2012-11-02 09:53:09
Reporter: markaf
Subcomponent: svnant
Version: unspecified
Milestone: not determined
Keywords:
Cc:

Comments
2012-11-02 09:53:53 by markaf
Created an attachment (id=393)
Build file to use

Attachments
test.xml - Build file to use
Posted 2012-11-02 09:53:53 by markaf
<?xml version="1.0" encoding="UTF-8"?>
<project name="project" default="default">

    <taskdef resource="org/tigris/subversion/svnant/svnantlib.xml"/>

    <svnSetting id="settings.svn"
        javahl="false"
        svnkit="false"
        failonerror="true"/>

    <target name="default" description="description">
        <svn refid="settings.svn">
            <wcversion path="${basedir}/../eclipse-project-under-version-control" processUnversioned="true"/>
        </svn>
    </target>

</project>

Experiencing the exact same issue ... but I should use maven and git anyways!!!


Questions/additions to the benchmark

I am the developer of a new JSON encoder/decoder called sonnet, a library designed for full compatibility and speed.
I would like you to include mine in the benchmarks listed in your README, as I noticed that your library have similar objectives.
Also, I have benchmarked Sonic against several others.
However, the results did not appear to be as outstanding as stated in the README. below is an example - It uses JSON data which is from your repository (Medium Twitter JSON)

( sec/op )
Marshal
Unmarshal
Encode
Decode

encoding/json
19.89µ
131.6µ
17.55µ
146.1µ

go-json-experiment/json
22.03µ
51.18µ
N/A
N/A

segmentio/encoding
10.60µ
41.91µ
7.858µ
70.66µ

json-iterator/go
25.09µ
41.55µ
30.88µ
45.86µ

goccy/go-json
9.364µ
31.68µ
⭐ 7.060µ
44.65µ

bytedance/sonic
⭐ 6.881µ
33.59µ
8.376µ
32.96µ

sugawarayuuta/sonnet
12.77µ
⭐ 31.01µ
9.692µ
⭐ 31.77µ

Machine:
goos: darwin
goarch: amd64
cpu: Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz

Benchmark code:
https://gist.github.com/sugawarayuuta/8b67fdf07f342aae1fe63e694a6121aa
Notes:

easyjson is not here per this comment
every benchmark code has warm-up logic per this comment

It is interest. thanks your sharing. Welcome to pull request for the benchmark.


1.2.8 to 1.2.9 issue

Hi, sorry to re-open, but I think there may be a bigger issue with the upgrade from 1.2.8 to 1.2.9. When I revert to 1.2.8, my gridstore issue with my test is resolved in this ticket (https://github.com/christkv/mongodb-core/issues/42) . However, I noticed another issue with 1.2.9. I think it has something to do with my standard replicaSet setup. My process crashes every 10 seconds or so with the following stack trace. However, if I downgrade to 1.2.8, everything seems fine.
TypeError: self.isDead is not a function
    at nextObject (/opt/sgapp/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:576:44)
    at Cursor.next (/opt/sgapp/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:223:12)
    at Store.execute (/opt/sgapp/node_modules/mongoose/node_modules/mongodb/lib/topology_base.js:83:18)
    at null._onTimeout (/opt/sgapp/node_modules/mongoose/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/replset.js:888:31)
    at Timer.listOnTimeout (timers.js:89:15)

Looking at the code changed in 1.2.9, it seems like some replicaset stuff is changed..  I very well could just be coding stuff incorrectly, but this had been working fine for many months until 1.2.9.

ugh.. i'm sorry, late night.. trying to figure this out, and this may be a red herring.  i'll repost a ticket if I can get a clearer pictures of what is actually causing my issues..

I'm taking a fresh look at this today and will try to get you a minimal example to reproduce.  It's not clear to me why isMasterDiscovery() in mongodb-core/lib/topologies/server.js was removed in 1.2.9.  This seems to be the culprit.   Is it possibly an over site?

it was removed due to it causing this problem
https://jira.mongodb.org/browse/NODE-518

so I haven't been able to exactly isolate this down.. However, I was able to "fix" the issue with this small patch that checks to see if isDead is defined:
https://github.com/amit777/node-mongodb-native/commit/6a1bacc0c9eef03a790283e30d755b14bf12bd21
I have a feeling there is some sort of race condition that exposes this bug.  Another interesting observation is that I get this stacktrace where my process crashes about 3 times, and then my process seems to run fine.  The process is managed by pm2 and is auto-restarted.  My replica set is 3 nodes.  2 of the nodes including the master are in a different datacenter than where my test machine is.

solved.. closing


Translations

Do you have any translation service so we can use to translate the app, there is a lot of keys not translated.

We will pubnish a new version that supporting i18n at next week. Your can define translating keys for your app at that time.

The new version is available via the link below:
https://release-sv-1252011659.cos.na-siliconvalley.myqcloud.com/archives/yao-0.10.0-darwin-amd64  Mac
https://release-sv-1252011659.cos.na-siliconvalley.myqcloud.com/archives/yao-0.10.0-darwin-arm64   Mac M1/M2
https://release-sv-1252011659.cos.na-siliconvalley.myqcloud.com/archives/yao-0.10.0-linux-amd64  Linux
Language packs are placed in the langs directory：
https://github.com/YaoApp/gou/blob/main/tests/app/langs/zh-cn/global.yml
Language variables are prefixed with ::
https://github.com/YaoApp/gou/blob/main/tests/app/models/demo.mod.json

I'm trying translate to "es" the login page tags (ex. Account: Usuario, Password: Contraseña) adding /path/myapp/langs/es/global.yml, then in the .env file: YAO_LANG="es" but not working...
Am I doing something wrong, or this functionality is not available yet?

Only zh_cn & en_us support yet.


Add Faker::Music::Opera

[x] run test suite successfully with bundle exec rake
[x] run Rubocop successfully
[x] added opera.yml in `locales/en'

Now Faker can generate a title of an opera by Rossini, Donizetti, Verdi or Bellini

@Adsidera please add documentation link to README.md file.

@Adsidera please add documentation link to unreleased_README file so that we can update to README after release.

done :)


cmd/go: vague error when VCS tool not available

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.11rc1 linux/amd64

Does this issue reproduce with the latest release?
n/a: working with 1.11rc1
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/tmp/tmp.JrnIrHb6a5"
GOPROXY=""
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/tmp/tmp.yCavsj0ED5/hello/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build243376190=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Requires that bzr not be in your PATH:
export GOPATH=$(mktemp -d)
cd $(mktemp -d)
mkdir hello
cd hello
go mod init example.com/hello
cat <<EOD > main.go
package main

import _ "launchpad.net/gocheck"

func main() {}
EOD
go mod tidy

What did you expect to see?
An error message telling me that bzr was not available in my PATH
What did you see instead?
Zero exit code and no messages. go.mod also untouched:
$ cat go.mod
module example.com/hello

go build at least fails with a non-zero exit code, but a rather vague error message:
$ go build
build example.com/hello: cannot find module for path launchpad.net/gocheck

In fact in this situation we can be very specific: the error comes about because bzr is not in our PATH.
/cc @rsc @bcmills
Not sure whether you would consider this a release-blocker? I've not marked it as such for now

Filed #27063 for the silent mod tidy and repurposed this for the missing VCS error.


getHolidayName type declaration mismatch

Looks like #9 added in a type declaration for the return from getHolidayName but it is not nullable. Calling the method on a non-holiday returns a type error.
Changing the function declaration to
 public function getHolidayName(): ?string     {          ...     }
should do the trick. I'd be happy to author the PR and add in a test but wasn't sure where such a test should go (Utilities seems like it could do the trick but don't want to make assumptions about the structure of your repo)

Thanks for letting me know about this. Fix incoming shortly

fixed in v2.3.1


Exclude button for Tetra Sylphid in esper list doesn't work

I clicked on the esper slot and proceeded to click the exclude button for each of the espers (expeditions don't use espers). Tetra Sylphid was the only one where this didn't work. This might indicate some sort of UI problem. Equipping it and excluding it from the main screen still works.

Tetra Sylphid is the only esper with a space in her name, probabky the problem. I'll correct it.
On another matter, you can use the "Only owned equipment available for expedition" in the equipmenet section to disable espers from being used.


Confusing error message on invalid input

What I wrote:
isEven("two")

What I expected:
is-even expects a number.

(or something like that)
What I got:
is-odd expects a number.

Yep, is-even should most probably have the same structure of is-odd, like this:
module.exports = function isEven(i) {
  if (!isNumber(i)) {
    throw new TypeError('is-even expects a number.');
  }
  if (Number(i) !== Math.floor(i)) {
    throw new RangeError('is-even expects an integer.');
  }
  return !(~~i & 1);
};

To avoid duplication, you may want to create an is-integer package:
module.exports = function isEven(i) {
  if (!isInteger(i)) {
    throw new TypeError('is-even expects an integer.');
  }
  return !(~~i & 1);
};

Or even have an assert that throws the exception you want directly:
module.exports = function isEven(i) {
  assertInteger(i); // may throw a type error or a range error, depending on the exact error
  return !(~~i & 1);
};

I'm not sold on the relevance of range error though. the odd and even predicate only make sense on integers. Giving it anything else is a type error in my book. You could simplify the above like this:
module.exports = function isEven(i) {
  if (!isNumber(i) || Number(i) !== Math.floor(i)) {
    throw new TypeError('is-even expects an integer.');
  }
  return !(~~i & 1);
};

If you're adamant about not duplicating !(~~i & 1), then you can catch lower-level exceptions:
module.exports = function isEven(i) {
  if (!isInteger(i)) {
    throw new RangeError('is-even expects an integer.');
  }
  try {
    return !(~~i & 1);
  } catch(err) {
    throw new TypeError('is-even expects an integer.');
};

Maybe try to distinguish between type errors and range errors, but as I said, range error is not very relevant in my opinion.
My, the design space is much larger than I had anticipated. Reminds me why I don't like dynamic typing—too many ways to fail.

My, the design space is much larger than I had anticipated

Lol, indeed!

If you're adamant about not duplicating !(~~i & 1), then you can catch lower-level exceptions:

Not at all, I think we should probably re-write that code here and get rid of the dep. Fwiw, this is what I had before, and forgot about the error messages when I merged that PR, but the error messages and type checking are the reason for the lib.  Good for you, you're getting off to a great start in the community.

lmao

@antipodite so, you just joined GitHub, you have no code, and your first public contribution is a troll comment. Good for you, you're getting off to a great start in the community.


Issue With fq=

Hi,
I was running SolrNet <IP_ADDRESS>2 but had to restore my nuget packages.  This is no longer available so I was upgraded to <IP_ADDRESS>01. My issue is that the fq part of my generated command has changed from fq=parameter: (1 OR 2)
to
fq=(parameter: 1 OR 2)
This breaks the search and means only items 1 are returned.  Is there a way to get <IP_ADDRESS>2 back on Nuget?
Thanks

Can you post the code you're using to generate this filter query?

Sure,
The code is below and mediatypefq = "1 OR 2 OR 5".
  var q = solr.Query(new SolrQueryByField("autocomplete", searchTerm) { Quoted = false }, new QueryOptions
        {
            FilterQueries = new ISolrQuery[]
            {
                new SolrQueryByField("itemtype", mediatypefq) { Quoted = false }
            },
            Rows = resultsPerPage,
            Start = startResult,
            Grouping = new GroupingParameters()
            {
                Fields = new[] { "parent_id" },
                Main = true
            },
            OrderBy = sortOrder,
            Fields = new[] { "parent_id", "itemtype", "score", "heat" }
        });

I updated to 0.5.0-alpha2 and it started working as expected again. I just had to change
Start = startResult
to
StartOrCursor = new StartOrCursor.Start(startResult)
to remove the deprecated warnings although it still worked without that change.

Cool, so it's working fine on 0.5.0-alpha2 then?

Yes perfectly thanks. Hopefully if anyone else has this issue they will see this thread and make the upgrade as well.


[feature request]  add regular expression  supprot for config ‘cache-agent‘ of yurthub

What would you like to be added:
Why is this needed:
others
/kind feature

@hhstu Very appreciate for raising this issue. I agree with you that add regular expression for cache-agents fields, like cache-agents=* means all responses will be cached.

@hhstu Would you like to take over the feature and make a pull request?

/assign @hhstu


YARN-11524. Improve the Policy Description in Federation.md.

Description of PR
JIRA: YARN-11524. Improve the Policy Description in Federation.md.
The Federation.md file lacks an introduction to Policy. In this pr we will enhance the content regarding Router Policy, AMRM Policy, and PolicyManager to help users gain a better understanding of these types of policies.

Router Policy

AMRM Policy

Policy Manager

How was this patch tested?
Documentation modifications do not require unit tests.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 39s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
shadedclient
83m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 11 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
shadedclient
33m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

122m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux 12088632f39d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 002c574f1351dbd7d086447e01a87844abaeb3db

Max. process+thread count
650 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m  9s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
shadedclient
80m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
shadedclient
33m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

119m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux 2caa612ad7ba 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f3e4756afd2ed3909c89d469dd0bc557b0f7f254

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 46s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
shadedclient
84m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
shadedclient
33m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

122m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux d1f4246e2608 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a501d5bc8469e2628fb4940f5f341d59d54a9967

Max. process+thread count
561 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/4/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
54m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
shadedclient
88m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
shadedclient
33m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

126m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux 88174e672c60 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a501d5bc8469e2628fb4940f5f341d59d54a9967

Max. process+thread count
671 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/3/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
52m  5s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
shadedclient
86m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
shadedclient
33m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

124m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux c5328f17198d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 886cf54be5218a154216ade8a4d24e536fb2f6db

Max. process+thread count
737 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/5/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 39s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
shadedclient
78m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
shadedclient
32m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

116m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux 4ad6f8f28dda 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f08139f275773ca33fe5b2214c88bac8a0c2c3f1

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/6/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this pr? Thank you very much!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

-1 :x:
mvninstall
44m 55s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
shadedclient
78m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
shadedclient
32m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

116m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux 6fc4847b4160 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 63cb91bcf615c724c6d52f2cb95b8bb5d7043783

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/7/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

-1 :x:
mvninstall
45m 44s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
shadedclient
79m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
shadedclient
33m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

118m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux a1a0925388d6 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9e3fda6aad82f99b38029e417e3fe74e81216f0c

Max. process+thread count
706 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/8/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 20s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
shadedclient
83m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
shadedclient
32m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

122m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5797

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux a3da1174a81b 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e95c90b4bdf1cf0f4267e3abe9ccc0afcb7002dd

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5797/9/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help to review this PR again? Thank you very much!

@goiri Thank you very much for your help in reviewing the code!


library doesn't always recognise thunks

The regex is not good enough, it only recognises arrow functions.

Fixed with https://github.com/jsbuzz/redux-transitions/commit/e0c31d7387b4115696344f61c23dda295a36333d


fix(breadcrumb): remove unknown props on dom elements

Codecov Report

Merging #433 (dd44355) into dev (00b2aad) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #433   +/-   ##
=======================================
  Coverage   89.12%   89.12%
=======================================
  Files         170      170
  Lines        4147     4147
  Branches     1368     1368
=======================================
  Hits         3696     3696
  Misses        230      230
  Partials      221      221

Impacted Files
Coverage Δ

...magma-dom/src/components/Breadcrumb/Breadcrumb.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b2aad...dd44355. Read the comment docs.


Change default behavior (push into empty tuple), remove DispatchedTupleDict

I repeatedly needed to look at the docs/tests to remember the difference between DispatchedTuple and DispatchedTupleDict.
I think this is a much cleaner interface/design, and the new table in the readme quickly helps me get oriented. cc @ali-ramadhan

I'll try switching to this branch and playing around with some DispatchedTuples!

bors r+


Committor improvements

As part of a collaboration we're spinning up, I'm running some committor calculations. In the process of that, I found a number of things that could be improved in the committor code.
Only thing that modifies the API is that I changed the output of committor_histogram to match the output of numpy.histogram and numpy.histogram2d (if the committor_histogram is a 2D variant). I'd call that more of a bug fix than an API break (and we are still 0.9.x, so we can break the API!)
Everything else just makes it easier to work with:

[x] make ShootingPointAnalysis.committor_histogram match numpy's behavior
[x] separate out the ability to add to the ShootingPointAnalysis one step at a time
[x] make it possible to create a ShootingPointAnalysis object without it doing analysis on initialization by giving it steps=None
[x] add class method ShootingPointAnalysis.from_individual_runs which takes a list of (shooting_point, final_state) tuples and creates the shooting point analysis object
[x] Add output to CommittorSimulation to see how much more of the simulation is left to run.
[x] Tests
[x] Docstrings

I'll keep this as WIP for the time being, as I continue starting this new project. Not sure if there is much else I'll need to change, though.

I think I've done all that I'll need to with this. Ready for review.

Looks good. Merging..


Different results for the same certificate under Android and iOS (Corona-Warn-App and CovPass-App)

Describe the bug
Checking the same certificate under iOS and Android against the Swiss leas to two different results:

Android
iOS

Same goes for CovPass under iOS and under Android, iOS shows fail, Android shows the open status.
Expected behaviour
The result should be the same under iOS and Android.
Steps to reproduce the issue

Add a EU DCC to the Corona-Warn-App under iOS & under Android.
Select "Check Validity"
Select "Switzerland"
See the result

Technical details

iPhone XR
iOS 15.0.1
CWA 2.10.2
Huawei P Smart 2019
Android 10
CWA 2.10.1

Additional context
I hope this is the right place for this issue.

Some additional information:
There are currently (as of October 4th, 2021) errors within the Swiss business rules -> see https://github.com/corona-warn-app/cwa-documentation/issues/711#issuecomment-933701107 for two suspects.
These errors lead to certificate status "open" in Android when validated with CertLogic - which is apparently corrrect: due to technical problems with the rules of Switzerland the DCC can not be validated.
This means, the results returned by iOS CertLogic are wrong - they should be "open" instead of "fail".

And more additional information by @Ein-Tim here: https://github.com/corona-warn-app/cwa-documentation/issues/711#issuecomment-934683161
German CovPass app iOS also shows "fail", while CovPass Android shows "open".

ping @martinreichart and @alexchornyi

Little update: The problem with the Swiss was fixed on 18.10.2021 on 12:00 UTC, so to reproduce this issue one now has to select a date & time before 18.10.2021 12:00 UTC.

@Ein-Tim I cannot reproduce this issue anymore.
Checkin my certificate for Swiss works on Android and iOS in both apps correct. (A date before today I cannot select) Can you please clarify if this ticket can be closed or provide some further infos if it doesn't further works for you.

@kerstin-oppermann-tsi
Yes, this works now (as Swiss fixed this issue).
I guess we can close this, however, please note that there was and maybe still is an underlying bug in the certlogic.

Hi @kerstin-oppermann-tsi and @Ein-Tim ,
you cannot reproduce the issue anymore, because the Swiss team fixed their business rules! See your own comment https://github.com/eu-digital-green-certificates/dgc-certlogic-ios/issues/49#issuecomment-949006306
However, the bug that was filed in this issue is, that iOS-CertLogic falsely evaluates broken business rules as "invalid" while they should be evaluated as "open". As far as I can see, that iOS bug has not been fixed yet.
Please re-open this issue.
@alexchornyi Could you give an update on the process of fixing this bug? For testing the fix you now would need to create a set of broken business rules. There is just a small chance that France currently has one broken rule in production... (last checked three days ago).

@alexchornyi If you need the old buggy Swiss rules, I could provide these to you here from a backup upon request.

thanks @kerstin-oppermann-tsi

@Hendrik-Schmidt-Schierhorn-TSI and @alexchornyi ,
two different errors in Swiss business rules led to a deviating evaluation in iOS-CertLogic, see here for details:
https://github.com/corona-warn-app/cwa-documentation/issues/711#issuecomment-933701107
the comment of @mlenkeit in https://github.com/eu-digital-green-certificates/dgc-certlogic-ios/issues/49#issuecomment-935533733 only covers the wrong parameter external.validationClockAtStartOfDay .

Hi @mlenkeit or @thomasaugsten , could you please check business rule VR-FR-0009 (currently in prod) where validation has different results in iOS (pass) and Android (CWA 2.6.1 & CWA 2.13.2: open):
   {
      "AffectedFields":[
         "v.0",
         "v.0.ma"
      ],
      "CertificateType":"Vaccination",
      "Country":"FR",
      "Description":[
         {
            "desc":"Only manufacturers in the allowed valueset that have been approved by the EMA are allowed.",
            "lang":"en"
         },
         {
            "desc":"Seuls les fabicants approuv\u00e9s par l'AEM (Value set UE) sont accept\u00e9s en France.",
            "lang":"fr"
         }
      ],
      "Engine":"CERTLOGIC",
      "EngineVersion":"0.7.5",
      "Identifier":"VR-FR-0009",
      "Logic":{
         "if":[
            {
               "var":"payload.v.0"
            },
            {
               "in":[
                  {
                     "var":"payload.v.0.ma"
                  },
                  {
                     "var":"external.valueSets.vaccines-covid-19-auth-holders"
                  }
               ]
            },
            true
         ]
      },
      "SchemaVersion":"1.0.0",
      "Type":"Acceptance",
      "ValidFrom":"2021-10-31T00:00:00Z",
      "ValidTo":"2030-10-31T00:00:00Z",
      "Version":"1.0.0"
   }

At first glance structure/syntax of the rule seems to be correct, and also the pointer to the value set looks appropriate (https://github.com/ehn-dcc-development/ehn-dcc-schema/blob/release/1.3.0/valuesets/vaccine-mah-manf.json)
Do you have any idea, why results are different?
Side note: The manufacturers in this value set are not all approved by the EMA - does the French team know this, @SchulzeStTSI ?

Fixed with https://github.com/corona-warn-app/cwa-app-android/pull/4344 in 2.13.3

Thanks, @thomasaugsten . Having some space is nice in general, but not everywhere...

Will someone eventually address this issue? Or was it decided to not fix this issue?

Will someone eventually address this issue? Or was it decided to not fix this issue?

@Ein-Tim entering Switzerland is currently possible without providing any kind of DCC-related proof. They have changed their rules accordingly to effectively pass for any certificate:
https://distribution.dcc-rules.de/rules/CH/a68f9b6940fbbd71706293838bfe0bd7561f0203ea2437e81f9a398fdfff181b (that's the only rule for CH at the moment)

@kerstin-oppermann-tsi
Thanks! I'm closing this issue, could you please keep us updated reg. the business rules situation via https://github.com/Digitaler-Impfnachweis/covpass-ios/issues/190?


Looking forward to Ember 2.0

Hi,
Great library, helps make things simple and clean!
A lot of changes and a more structured way of doing things looks to be right around the corner with Ember 2.0.  As I'm working on making my app 'future proof' ( https://gist.github.com/samselikoff/1d7300ce59d216fdaf97 ), I want to make sure that this library doesn't violate the "data down, actions up" principle in particular.  @asaf, could you share whether this library will be on board with the coming changes in Ember 2.0 and continue to be well supported as this changes?  It looks like the Ember team plans to keep things mostly backwards compatible, but I would hope this project continues to evolve with Ember.  For reference, there is some good discussion of the changes at https://github.com/emberjs/rfcs/pull/15 and https://speakerdeck.com/tomdale/ember-2-dot-0-in-practice
Thanks

@leejt489 sorry for the long delay I was in a holiday,
Sure, I am interesting in supporting Ember 2 but will continue to support 1.x for the time being,
We can create another branch in the near future to support 2 in parallel if the changes cannot live together for both versions.
I'll be more than happy to get some help around,
Asaf.

@leejt489 I barely able to release versions that supports 0.x! now I push 1.x version,
I'm keeping this open but we'll have to look more closely when Ember 2 will come into a final shape.


Transition to Graphs.jl

The package is dependent on an ecosystem of packages (HybridSystems, SwitchOnSafety, etc) that have not yet fully made the switch from LightGraphs.jl to its successor, Graphs.jl. Will make the switch from LightAutomaton to GraphAutomaton once the ecosystem has caught up (HybridSystems 4.0 just made the switch but SwitchOnSafety is not there yet)

Done!


Add build system tutorial

I wrote a build system tutorial in some spare time, explaining the webpack setup completely from scratch - something I took some time to learn. I hope to expand on this in sometime. It doesn't teach much about vue.js itself.

:+1: nice tutorial! One thing I found is that it should be npm install vue --save instead of npm install vuejs --save :)

Thank you :) I fixed the error on the post.


Egg script seems to load and activate before dependencies have loaded

On testing and then trying
  tooltip.output();
  dropdown.output();

Both of these fail as they haven't been loaded yet...

Completed this and now merged into master


cannot find invitation

help me further

Not sure what invitation you are referring to, please raise on our support repo with more information https://github.com/EddieHubCommunity/support


UIImageViewExtension miss access control modifier

can't access these two methods.

@gongruike Thank you for reporting, fixed in 1.6.4


chore Refactor is_acting_on_a_slot

Proposed changes
Refactor is_acting_on_a_slot
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

Merge in https://github.com/apache/doris/pull/25953


Adding QuickSort C

I have added QuickSort C Program.

@ramaadarshh This issue isn't assigned to you. Closing the PR.


Changing restangularFields breaks Restangular.service

I tried to add a prefix $ for all Restangular methods by setting restangularFields, as suggested here (https://github.com/mgonto/restangular/issues/675#issuecomment-41151648).
Unfortunately, Restangular.service does not work any more after that, an error occurs instead:
Uncaught TypeError: Expected a function(…)
...
Restangular.all('editor')

The problem due to this seems to be, collection.post and collection.getList are hard coded in function toService, which in my case are changed to collection.$post and collection.$getList.

Same problem here!

This hasn't been fixed yet?

Any status update here?

Thanks for the bump. I'll try to take a look at it when I have time. In the meantime, PRs are welcome ;)

Is this issue substantially different from what was addressed by this PR?: https://github.com/mgonto/restangular/pull/826

I already have a working fix for this and lot more issues in my fork here if somebody wants to check. Might do a PR later. (Working with the current state of this project was completely impossible but the fixes were all easy enough)


Base Interfase to work with Map

Add animation to change button image and fix bug when location button tapped missed. Create button to show days of saving history and what's user can choose day to look. Add identification direction to annotation current location.


Uninitialized constant Gem (NameError)

Hi!
When I open a new terminal using bash_it, I get the error at the top "Uninitialized constant Gem (NameError)". Just wondering what I should do to resolve this?
Thanks

Which plugins/completions do you have enabled? Anything related to Ruby or Gem? Do you have rb and gem on your path? If not, you should probably disable the ruby plugin.
Also, which theme are you using?

I'm using powerline theme. I just enabled the defaults when I was setting bash-it up! How do I disable the ruby plugin?

Try this:
bash-it disable plugin ruby
bash-it disable completion gem
reload

Perfect. Thank you!

Is the error gone? If so, please feel free to close this ticket.


something wrong

hello guys
setNewData is useless for me, it seems  source data empty.

Please check your usage


proposal: testing: add testing.T.Volatile to exempt test functions from result caching

Proposal Details
While generally, a test function should be self-contained and isolated to prevent flakes, there are cases where a test needs to interact with state not reflected in the build artifact. For example an integration test, that tests interaction with a CLI tool or relies on a separate database server. For such tests, the current behavior of the Go test cache is counterproductive: It might conclude that since the code itself has not changed and re-use a cached test run, even if the external resource has changed and thus the test needs to be re-run.
It is possible to pass -count=1 to force a re-run, but this is flawed as well, as it applies globally. If you want to run all tests in a large project and run go test -count=1 ./..., that will re-run all tests, even though most of them might be perfectly cacheable. There is a reason, after all, that the test cache was introduced.
So it might be useful to have a way to indicate that one specific test function depends on external state, that makes it non-cacheable.
Thus, I propose to add a method to *testing.T to exempt a function from result caching:
// Volatile marks the current test function as exempt from result caching.
// A test function marked as volatile is re-run, even if none of the Go source it uses has been modified.
func (t *T) Volatile()

The call would just be recorded in the *T and after the test function is finished, its result would not be stored in the cache if Volatile was called. Thus no other tests are affected by use of Volatile.
One drawback of this mechanism is that it again runs all volatile tests on every invocation of go test, even if the external resources did not change. Especially if Volatile is overused, that would again increase test running times. Theoretically, it would be possible to prevent that by allowing the test function to include a token that encapsulates the external state (e.g. by hashing the version of the database server or the contents of the called binary), though this might be too finicky, ultimately:
// Volatile controls results-caching for the current test function.
// The given tag is persisted with the test result in the test cache. If a future run calls
// Volatile with the same tag, it behaves like `Skip`, except that the cached test result is output.
func (t *T) Volatile(tag uint64)

I'm not terribly sure this is a good idea. It came up in a discussion on Mastodon and it doesn't seem like a completely unreasonable compromise. So I wanted to propose it formally, to gather some feedback.

related #23799

I still agree with my old comment https://github.com/golang/go/issues/23799#issuecomment-433090627: some marker is fine but the default behavior of 'go test' should still be to cache things. We could have 'go test -volatile' to explicitly rerun volatile tests even when the result is cached from last time, but I think that's indistinguishable from -count=1.

Also reading the Mastodon thread it seems like the first thing to understand is https://hachyderm.io/<EMAIL_ADDRESS>That has nothing to do with volatile tests.

I posted https://hachyderm.io/@rsc/112491348314936122 over on Mastodon about the potential build/test cache misbehavior.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Making this require a command line option feels strange to me, because a testing being volatile is a property of the test, rather than a property of the test run or a personal preference of the person running the test suite. Relying on a cached result of a volatile test is a mistake.
I could imagine a compromise where volatile tests don't run at all by default; e.g. perhaps t.Volatile() behaves like t.Skip("volatile tests not enabled") unless the -volatile option is present. That would avoid implying that cached results are valid for that test, but also seems surprising.
I have some prior art of something similar to that in some of the software I maintain in my dayjob: we have some integration tests that access external network services to verify correct behavior, and currently have those tests call t.Skip if an opt-in environment variable isn't set. That then allows someone running the entire test suite to not be bothered by them and their potential flakiness, but still makes it relatively easy to include the integration tests in the full run when that's appropriate.
However, the primary motivation for that is not that the tests are "volatile" but rather than they can only work when the person running the test has a suitable network connection to access the relevant services. They are volatile as defined by this proposal, but that's not the main motivation for skipping them by default, so this example might not be relevant.

Ultimately, beliefs about what is correct here depend on why you want to run the test: is it to test that the code works, or is it to test that the external, volatile dependencies still work?
Most of the time, you run tests to check the source code in the repo where you are working. In that context, if you've run go test ./... and they all pass, and then you edit one source file, and then you run go test ./... again, you only want it to run tests that could have been affected by that source code change. Tests that are literally the exact same binary before and after your source code change don't need to run again. Only re-running tests affected by recent source code changes is the whole purpose of the test cache. Defaulting to rerunning some tests always completely defeats the purpose, slows down development, and scales especially badly in large repositories. The volatile tests are also often the slowest ones. Those are the last ones you want to run when you haven't been editing anything related to the test.
Sometimes you are running tests to check a full end-to-end behavior, including that external, volatile dependencies are still working as expected. In that case, using -volatile might be helpful, but it is very close to -count=1.

I think perhaps the main point of contention here may be whether "volatile tests" are common enough and useful enough to deserve different treatment than unit tests?
For what it's worth, I agree that the caching mechanism as currently implemented is a fine answer for unit tests, and that unit tests are likely the most common situation and therefore it makes sense for the default behavior to prioritize those.
However, I read this proposal as extending Go's testing facilities to better support integration-type tests (aka "end-to-end tests") so that those who wish to write them and use them don't need to fight the test harness to use them effectively. Thinking that you've got a passing integration test suite when really all you've done is recalled an older positive result from the cache is a real hazard that I've encountered myself and have seen others on my team encounter.
I do find your argument convincing @rsc -- particularly the part of only wanting to run these relatively-expensive tests once you've got fully-passing unit tests. To me, that seems to favor the compromise of making uncacheable tests not run by default, but for -volatile to (unlike -count=1) still use the test cache to avoid unnecessarily re-executing the cacheable tests. The fact that skipped tests are not very visible in the output by default would probably still lead to someone thinking the tests are all passing when they aren't, though, so I'm not sure that really solves the problem either.
(I could also perhaps accept the argument that go test is primarily designed for unit tests and that integration tests are different enough to deserve their own entry point, separate from go test. They also tend to require special configuration that's awkward to provide through the go test wrapper, which our projects tend to stuff awkwardly into environment variables but could instead be a configuration file or plain CLI arguments passed to a normal program -- a package main -- that runs the integration tests. :thinking: )

I think we understand the relevant issues. We could implement -volatile but it doesn't seem like the right answer here. For now it seems like -count=1 is as good as anything else.

(There is the separate issue of the Mastodon report that test caching was horribly broken and not noticing source file edits. That's a separate discussion if they can reproduce it.)

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group


BLUE-273 Worker processed debug log flag

I think src/worker-process/index.ts should also have the flags around the ( console.log / console.error .. etc. ) .. right now i can see that only being done for src/primary-process/index.ts

As the other file was out of scope for what Jai thought we needed, I will in principle agree with you, but I think we should create a separate ticket for the additional flag wrapping.  Will have a task created


[Vue warn]: Invalid watch source

Hello. When trying to use the carousel in nuxt3, it gives an error to the console with the following content:
[Vue warn]: Invalid watch source:  {
  itemsToShow: 1,
  itemsToScroll: 1,
  wrapAround: false,
  snapAlign: 'center',
  transition: 300,
  breakpoints: undefined,
  autoplay: 0,
  pauseAutoplayOnHover: false,
  modelValue: undefined,
  mouseDrag: true,
  touchDrag: true,
  settings: {}
} A watch source can only be a getter/effect function, a ref, a reactive object, or an array of these types

Example code:
<script setup>
import 'vue3-carousel/dist/carousel.css';
import { Carousel, Slide, Pagination, Navigation } from 'vue3-carousel';
</script>

<template>
        <Carousel>
            <template #slides>
                <Slide v-for="(slide, index) in 10" :key="index">{{ slide }}</Slide>
            </template>
            <template #addons>
                <navigation />
                <pagination />
            </template>
        </Carousel>
</template>

The carousel works without errors only if you wrap it in client-only, but then SSR support is lost

Same error here with nuxt 3 as well 🙂

Same error here with custom SSR setup made wih vite and Vue 3
[Vue warn]: Invalid watch source:  {
  itemsToShow: 9,
  itemsToScroll: 1,
  wrapAround: false,
  snapAlign: 'center',
  transition: 300,
  breakpoints: undefined,
  autoplay: 0,
  pauseAutoplayOnHover: false,
  modelValue: undefined,
  mouseDrag: true,
  touchDrag: true,
  settings: {}
} A watch source can only be a getter/effect function, a ref, a reactive object, or an array of these types.

Same error here with custom SSR setup made wih vite and Vue 3
[Vue warn]: Invalid watch source:  {
  itemsToShow: 9,
  itemsToScroll: 1,
  wrapAround: false,
  snapAlign: 'center',
  transition: 300,
  breakpoints: undefined,
  autoplay: 0,
  pauseAutoplayOnHover: false,
  modelValue: undefined,
  mouseDrag: true,
  touchDrag: true,
  settings: {}
} A watch source can only be a getter/effect function, a ref, a reactive object, or an array of these types.

Same thing..

Fixed in v0.1.36


Implemented stubs for CampaignAdminControllerTests

Thanks @auroraocciduusadmin for your contributions again!
@mgmccarthy can you take a peek at these before I merge?

@tonysurma, I might not be able to get to it until Sunday or Monday.

@mgmccarthy I started reviewing this one but will wait for your feedback as well.
@auroraocciduusadmin Thanks for your contributions! Your tests are asserting what they should be, and perhaps a little more. In some respects they may be brittle as unit tests, but parts could be extracted as integration tests. That said, I see throughout the project that other tests are going to this level as well, so what you're doing is consistent. We'll likely merge, but we should also be giving you proper guidance here, too. Thanks again for the heavy lifting!

@MisterJames, I agree with all of your feedback. I am watching my 8 month old today solo (my wife's at work), so don't really have that much time to contribute today :baby:
One thing I think is important to get alignment with the project owners (@tonysurma @BillWagner ) is the fact that we should be passing null for unused dependencies in the constructor of classes instead of new'ing up a mock for unit testing.
One mock is not expensive, but after you clear 10,000 unit tests on classes with multiple dependencies, then 1/4 of the mocks you're creating are for nothing, and you're going to slow down your builds.
This links back to an Issue #891, which is something I brought up about guard clauses. @dpaquette @stevejgordon and @BillWagner all weighed in on the topic and it appears there is no consensus as to whether or not we should be using guard clauses in class constructor's for injected dependencies.
The apporach to unit testing your suggesting (which I agree with), is to pass in null for unneeded dependencies for a given unit test, but, if we start putting guard clauses for injected dependencies looking for null and throwing exceptions, we won't be able to approach unit testing this way.
We'll always need to supply a mock for each injected dependency.
Thoughts?

Thanks all, I will merge this in - as its good (thank you @auroraocciduusadmin) and the thoughts on unit testing and guards will still be here as well as in the other issue for discussion.

@MisterJames  re "testing the test":
I often feel that I'm testing the test when using mocks. For example, a test like Campaign.DetailsReturnsCorrectViewModelWhenViewModelIsNotNullAndUserIsOrgAdmin would be expected to ensure that, when passed an ID for a Campaign, we get a view that is passed a CampaignDetailModel with the correct data for that campaign (and user type). But we need a way to have the method return a viewmodel so we can see that it's working correctly. So we look under the hood of CampaignController.Details() and see that it's getting the data from CampaignDetailQueryHandler. So in our test we build a controller, mock the handler, and make sure that the handler gets called in the test. But how do we know that the "real" handler that got mocked is working? Well, we have tests for CampaignDetailQueryHandler so everything's good. But now we're not really testing the "contract" for CampaignController.Details() which is that we give it a campaign id for a known campaign and get the right CampaignDetailModel passed to a view. But isn't that the same thing? Not really. I shouldn't really need to know how the controller is working in order to test it...I just need to know what it expects as input and what it's expected to return (and expected side-effects). We could pass a CampaignDetailQuery in the CampaignController test and have it pass the test. We could also pass a CampaignDetailQuery to a CampaignDetailQueryHandler test and have it pass that test and (perhaps wrongly) conclude that the controller is working properly...espcially if the two tests are passed different parameters. The only way to really exercise the controller would be to use a "real" Mediator, in-memory database, and the like. So that's my case for "overkill" in unit tests.
Maybe there's a way to write more "expensive" tests that won't get run after each build (ie. on demand)?


Add "Analysis" tab for the elements information panel (along with Properties ans Description tabs) in HTML report

Version of Archi
4.9.3
Expected Behaviour
Show tab "Analysis" is HTML report for the selected element.

It will be very helpful for navigating through the model views.
At first a "Used in views" part is mostly needed (each view name must be a link), and, a "Model relations" info would be pleased to be realised too (but no links, cause the is no navigation to a model elements in HTML report).

Implemented in #984


fix: JSON form splits keys to multiple lines when it should not #32230

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #32230

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Summary by CodeRabbit

Style

Updated the JSON Form Widget to prevent text wrapping in field labels, ensuring labels are displayed in a single line.

/build-deploy-preview skip-tests=true

@akshat8605 Can you pull and merge the latest appsmith release branch to your branch? Since your changes are on top of last week's code and not the latest; there seems to be some sort of discrepancy in the deploy preview that was generated.
I see that you have another PR. Please go ahead and sync up that as well just to be on the safe side.
Let me know if you need any help.

Hi @ashit-rath, I just wanted to confirm that I made this pull request last week, and the other request was made yesterday after the latest pull from the release. So, do I need to make both requests again, or is just this one fine?

Hi @ashit-rath,
Sure, I am committing again with the latest release code.
Regarding the other PR, it was a mistake. I actually created a new branch and a new pull request for that. However, I will fix that as well.
Thank you for your assistance!


Removes ENC samples

Sample data was not ready before release, so the samples need to be removed.

Hi @dkemlage , can you please take a look at this? We need to get this in before v.next is merged into master.

Thanks for the quick review! :)


VM auto-shutdown causing issue in Lab 08

Module: 02
Lab/Demo: 08
Description of issue
My class was running Lab 08 just before 7PM UTC, the template creates the two VMs with Auto-Shutdown at 7PM UTC causing the lab to fail. (Yes, they only needed to start the two VMs.)
Should we remove the Auto-Shutdown from the template, or add a warning in the lab?  (Is this an issue with other labs?)

Lab devs took a look through the templates and found the below reference timed shutdown:
It appears that the learners performed the steps at the exact time as the shutdown, which caused the failure. We have not seen any reference on our side to something like this.

Is there a reason for the auto-shutdown? If so, please add a warning to all labs, if not, why not remove it from the template?
Thanks

Reviewing the needed updates tomorrow.


RS3621xs+ can not support third-party m2 expansion card using ASM2824 chip

I have a RS3621xs+. I installed a 25G network card on the device. So I only have one pcie expansion slot left. But I want to install 4 m2 SSDs.
I found that the official E10M20-T1 expansion card uses the ASM2824 chip. At the same time, many third-party 4-bay m2 expansion cards also use the ASM2824 chip. I think these third-party expansion cards can be used with RS3621xs+.
But when I tried to install, I found some problems. My third-party expansion card is correctly recognized by the underlying linux system.I can see the expanded pcie channel in ssh. And the syno_hdd_db.sh script log also shows the correct m2 hard disk information. This is the log of the last run:
Synology_HDD_db v3.4.87
RS3621xs+ DSM 7.2.1-69057-5
StorageManager 1.0.0-0017

rs3621xs+_host_v7 version 8025

Using options: -nr --autoupdate=3
Running from: /volume1/本地存储/Scripts/syno_hdd_db.sh

HDD/SSD models found: 3
HUS728T8TALE6L4,V8GNW980
SSDSC2KG019TZ,7CV10100
WUH721816ALE6L4,PCGNW680

M.2 drive models found: 2
INTEL SSDPEK1W120GAH,K4110410
KIOXIA-EXCERIA G2 SSD,ECFA17.1

No M.2 PCIe cards found

No Expansion Units found

HUS728T8TALE6L4 already exists in rs3621xs+_host_v7.db
SSDSC2KG019TZ already exists in rs3621xs+_host_v7.db
WUH721816ALE6L4 already exists in rs3621xs+_host_v7.db
INTEL SSDPEK1W120GAH already exists in rs3621xs+_host_v7.db
KIOXIA-EXCERIA G2 SSD already exists in rs3621xs+_host_v7.db

Support disk compatibility already enabled.

Support memory compatibility already disabled.

Max memory already set to 64 GB.

NVMe support already enabled.

M.2 volume support already enabled.

Drive db auto updates already disabled.

DSM successfully checked disk compatibility.

You may need to reboot the Synology to see the changes.

But in DSM's storage manager, I can't find any m2 SSD.

I also tried the syno_enable_m2_card.sh script. It returned the following information:
Synology_enable_M2_card v3.1.15
RS3621xs+ DSM 7.2.1-69057-5

StorageManager 1.0.0-0017

RS3621xs+: No PCIe x8 slot found!

What should I do to make DSM recognize my m2 expansion card correctly? Or I have to use official expansion cards.

I also tried the syno_enable_m2_card.sh script. It returned the following information:
Synology_enable_M2_card v3.1.15
RS3621xs+ DSM 7.2.1-69057-5

StorageManager 1.0.0-0017

RS3621xs+: No PCIe x8 slot found!

I'm curious why syno_enable_m2-card thought your RS3621xs+ has no PCIe x8 slots.
What does the following command return?
sudo dmidecode -t slot | grep "PCI Express x8"

If that command returns nothing can you reply with what this command returns:
sudo dmidecode -t slot

Synology_HDD_db uses the synodisk command to get the type of M.2 PCIe card.
What do these commands return?
synodisk --m2-card-model-get /dev/nvme0n0
synodisk --m2-card-model-get /dev/nvme0n1
synodisk --m2-card-model-get /dev/nvme0n2
synodisk --m2-card-model-get /dev/nvme0n3
synodisk --m2-card-model-get /dev/nvme0n4

Does "Control Panel > Info Center" show for "PCIe Slot 1" and "PCIe Slot 2"?
You could this:
sudo set_section_key_value /usr/syno/etc.defaults/adapter_cards.conf FX2422N_sup_nvme rs3621xs+ yes

I also tried the syno_enable_m2_card.sh script. It returned the following information:
Synology_enable_M2_card v3.1.15
RS3621xs+ DSM 7.2.1-69057-5

StorageManager 1.0.0-0017

RS3621xs+: No PCIe x8 slot found!

I'm curious why syno_enable_m2-card thought your RS3621xs+ has no PCIe x8 slots.
What does the following command return?
sudo dmidecode -t slot | grep "PCI Express x8"

If that command returns nothing can you reply with what this command returns:
sudo dmidecode -t slot

I used the "sudo dmidecode -t slot" command and the return is as follows
# dmidecode 3.2
Getting SMBIOS data from sysfs.
SMBIOS 2.8 present.

Handle 0x0019, DMI type 9, 17 bytes
System Slot Information
	Designation: J15
	Type: x1 PCI Express 2 x1
	Current Usage: In Use
	Length: Other
	ID: 1
	Characteristics:
		PME signal is supported
		Hot-plug devices are supported
	Bus Address: 0000:00:1c.4

Handle 0x001A, DMI type 9, 17 bytes
System Slot Information
	Designation: J16
	Type: x4 PCI Express 2 x4
	Current Usage: In Use
	Length: Other
	ID: 2
	Characteristics:
		PME signal is supported
		Hot-plug devices are supported
	Bus Address: 0000:00:1c.0

Handle 0x001B, DMI type 9, 17 bytes
System Slot Information
	Designation: J14
	Type: x8 PCI Express 3 x8
	Current Usage: In Use
	Length: Other
	ID: 3
	Characteristics:
		PME signal is supported
		Hot-plug devices are supported
	Bus Address: 0000:00:01.0

Synology_HDD_db uses the synodisk command to get the type of M.2 PCIe card.
What do these commands return?
synodisk --m2-card-model-get /dev/nvme0n0
synodisk --m2-card-model-get /dev/nvme0n1
synodisk --m2-card-model-get /dev/nvme0n2
synodisk --m2-card-model-get /dev/nvme0n3
synodisk --m2-card-model-get /dev/nvme0n4

admin@NAS:/dev$ synodisk --m2-card-model-get /dev/nvme0n0
Not M.2 adapter card
admin@NAS:/dev$ synodisk --m2-card-model-get /dev/nvme0n1
FX2422N
admin@NAS:/dev$ synodisk --m2-card-model-get /dev/nvme0n2
Not M.2 adapter card
admin@NAS:/dev$ synodisk --m2-card-model-get /dev/nvme0n3
Not M.2 adapter card
admin@NAS:/dev$ synodisk --m2-card-model-get /dev/nvme0n4
Not M.2 adapter card
admin@NAS:/dev$ synodisk --m2-card-model-get /dev/nvme0n5
Not M.2 adapter card

Does "Control Panel > Info Center" show for "PCIe Slot 1" and "PCIe Slot 2"?
You could this:
sudo set_section_key_value /usr/syno/etc.defaults/adapter_cards.conf FX2422N_sup_nvme rs3621xs+ yes

I tried running the "sudo set_section_key_value /usr/syno/etc.defaults/adapter_cards.conf FX2422N_sup_nvme rs3621xs+ yes" command and restarted, but it had no effect.

In your screenshot for "PCIe Slot 2" what does that translate to in English?
Can you try this, with a capitol RS:
sudo set_section_key_value /usr/syno/etc.defaults/adapter_cards.conf FX2422N_sup_nvme RS3621xs+ yes

You might need to reboot after that.

In your screenshot for "PCIe Slot 2" what does that translate to in English?
Can you try this, with a capitol RS:
sudo set_section_key_value /usr/syno/etc.defaults/adapter_cards.conf FX2422N_sup_nvme RS3621xs+ yes

You might need to reboot after that.

The screenshot shows that pcie slot 2 is "occupied". This command still had no effect, so I restarted it after executing it.

Sadly I don't think your PCIe card is going to work.


Support Question (Primary Group Prefix Placeholder)

Hi, I can't seem to find a primary group prefix placeholder, I can see this %primarygroup% placeholder but I need a placeholder that shows the prefix of the group not the group name.
I looked all over for it and can't seem to find it, any help is appreciated.

https://github.com/lucko/LuckPerms/wiki/Placeholders
I believe what you are looking for is %luckperms_primary_group_name%

This shows the group name, i'm wondering if there is a placeholder to show the primary group prefix that you enter in the group file.
This: https://i.gyazo.com/9119e18a72d79ad55c1362a5e9ac0c7c.png

%luckperms_prefix% will show the highest priority prefix, unless you've changed stacking settings in meta-formatting

ty


tl::expected didn't respect LIBCORO_BUILD_TESTS=OFF

Closes #143

OK, got it, verifies here. The magic is in the order of merging the lines in my test. If CMakeLists.txt has it like this, snip snip:
if(NOT LIBCORO_EXTERNAL_DEPENDENCIES)
    if(NOT LIBCORO_BUILD_TESTS)
        # Disable testing in expected
        set(BUILD_TESTING OFF CACHE INTERNAL "")
    endif()
    add_subdirectory(vendor/tartanllama/expected)
else()
    find_package(tl-expected CONFIG REQUIRED)
endif()

i.e. fist disable, then add subdirectory, the lenghty test builds are omitted.
Merge away :-)

Woohoo!


REST service to fetch full content of a specified Rasa test story

AS AN Architect
I WANT to have a REST service to fetch full content of a specified Rasa test story
SO THAT there wouldn't be duplicate services for it
Acceptance Criteria

[ ] Use POST endpoint /rasa/test-stories with test_story_name as a POST parameter
[ ] Rasa test_stories.yml as source of truth

Examples
Input
stories:
- story: common_tervitus
  steps:
  - user: |
      tere
    intent: common_tervitus
  - action: utter_common_tervitus

- story: common_hüvasti_jätmine
  steps:
  - user: |
      headaega
    intent: common_hüvasti_jätmine
  - action: utter_common_hüvasti_jätmine

Output when making a request for common_tervitus as test_story_name value
{
  "story": "common_tervitus",
  "steps": [{
    "user": "tere\n",
    "intent": "common_tervitus"
  },
  {
    "action": "utter_common_tervitus"
  }]
}

sample input for /rasa/test-stories
{
"story": "common_tervitus"
}

@janyprus please link this issue with an appropriate pull request.

Pull requests #141 and #149


Update istioctl  -create-voting-app-gateway.yaml

[Enter feedback here]
Please update command to create gateway for pod. We get warning as following
istioctl create -f istio/step-1-create-voting-app-gateway.yaml --namespace voting
Command "create" is deprecated, Use kubectl create instead (see https://kubernetes.io/docs/tasks/tools/install-kubectl)
Created config virtual-service/voting/voting-app at revision 733544
Created config gateway/voting/voting-app-gateway at revision 733545

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35b1812f-e2f3-f798-2788-611787994794
Version Independent ID: 3c593804-a3ef-24dc-cc82-0c4af12eb833
Content: Intelligent routing and canary releases with Istio in Azure Kubernetes Service (AKS)
Content Source: articles/aks/istio-scenario-routing.md
Service: container-service
GitHub Login: @paulbouwer
Microsoft Alias: pabouwer

Thanks for the feedback! We are currently investigating and will update you shortly.

@sasachan - thanks for the report.
This is the new behaviour for Istio 1.1.x - istioctl create has been deprecated and will be removed in Istio 1.2.x.
The azure docs are currently targeting Istio 1.0.x - we are in the process of updating them for Istio 1.1.x.
/cc @jakaruna-MSFT

@paulbouwer Since you have a workitem to migrate this article to the new version if Istio, I think we can close this issue now. Please provide your comments.

@jakaruna-MSFT agreed - #please-close

@sasachan
I will close this out for now. If you need additional help please let me know and we can reopen and continue.


Need option to turn off sound

Currently video runs with sound on by default, which is not suitable for all use cases.

Just noticed that I can pass audio={false} while reading through a source:)

Yep, but this should definitely be documented in the readme.

It's in the readme with the latest change, closing.


finish week1

Here i finished the week 1 tasks and the week 1 end of the week hackathon challenge

Here i finished the week 1 tasks and the week 1 end of the week hackathon challenge
I think i did this correctly... hopefully


Install dev tools using Poetry when the poetry environment related to current folder is selected

For #8372 Closes https://github.com/microsoft/vscode-python-internalbacklog/issues/93
Closes https://github.com/microsoft/vscode-python-internalbacklog/issues/12
Should be merged only after https://github.com/microsoft/vscode-python/pull/15765, otherwise old poetry support for installation will break when in discovery experiment.

@karthiknadig Waiting on your review on Added Poetry locator #15765 before merging this.

@karrtikr I approved it:


The culling cannot be disabled

Describe the bug
Even if I disabled all culling options in the settings panel, the culling cannot be disabled.

Screenshot

Environement:

OS: Windows 11
Version UE 5.3 + Plugin 1.1.3

Moreover, the generated scene is super large. However, only a very small part is displayed.


GPT2 Tokenizer got an expected argument skip_special_tokens

❓ Questions & Help
I keep running into this error when trying to use the GPT2 model and GPT2 tokenizer while decoding.
Keep getting the following error when I run the piece of code below:
tokenizer.decode(response_ids, skip_special_tokens=True)
Error:
TypeError: decode() got an unexpected keyword argument 'skip_special_tokens'

Could you please submit a bug report with the version of the library you're using?

will close this issue. Opened a bug report.


It´s not possible to create or to connect to a ssid with space separated characters

If you try to create a ssid like "A B C" or connect to a ssid like "A B C" by console it will save only the first letter.
If you try to do the same described above via web interface the "space" is substituted by a plus sign "+".

This is a banal problem, because your B and C letter are interpreted as arguments, so if you want a space caracter on ssid you need to use ASC II codes. In your example you need to create a ssid named as "A%20B%20%C". Banal.

Thank you very much guiyti, it worked!


No resnet_orig.pt

There is no resnet_orig.pt state dict in the state_dict.zip file

Sorry that model is not supported. Only the ones listed in the table.


Time on X axis renders incorrectly the second time

When rendering a plot with time on the x axis and something else on the y, ggplot renders it perfectly the first time, but the second & subsequent times seems to reset the timestamps to near 1970 and completely mess up the ordering.
Once this behaviour is triggered, it's continued until the Python process is restarted.
I've verified this behaviour w/ matplotlib 1.4.2, ggplot 0.6.5, and pandas 0.13.1 on Mac OS X 10.9.
Reproducing example
from datetime import datetime, timedelta

from ggplot import *
import pandas as pd

dates = [datetime.now() + timedelta(days=i) for i in range(10)]
df = pd.DataFrame({'t': dates, 'x': range(10)})

ggplot(aes(x='t', y='x'), df) + geom_line()
ggplot(aes(x='t', y='x'), df) + geom_line()

First time (correct)

Second time (incorrect)

0.9.3


add initial calls to update table list

remove delay in displaying the tables list

Oh, I almost forgot - please add a changelog entry

it was caused by a fix on master that wasn't released yet

Ah! Ok, cool :slightly_smiling_face:


Add suggest edits to top repo button

Jupyter book has a built-in extra dropdown button for "suggest edits" per our discussion in today's meeting. This is also a chance for anyone in @ProjectPythia/education to see if you're able to push to my PR. I can always wipe out your change if it works. Attached is a screenshot of the important setting beneath the body text of your PR to enable collaboration from project maintainers. This is enabled by default for me, and if it's disabled then external maintainers will not have default write access to your branch on your fork. Otherwise we might have a permissions issue somewhere? Screenshot attached:

Hi @dcamron , I'm still not totally clear of the right collaborative workflow here ...  so if I wanted to make a change to your fork, would I first create a fork of your fork and then attempt to make a pull request to that?

The easiest path is probably to install the GitHub Command Line Tools so that from your copy of the main repo you can do:
gh pr checkout 25

make changes, commit them, and then do:
git push

I just successfully pushed to this branch, yay!
My commit added some verbiage to the footer directing readers' attention to the new buttons, and also says something about this on the "How to Contribute" page.

Tried to push but encountered linting error once again ... seems that although I checkout out pr 25, my _build directory still had the Cartopy content I had added.

(reads the error messages closer) Actually the linting worked; the error lies in the creation of the environment.

@ktyle as you noted above, the old build was not the issue here, but FYI you can always do
jupyter-book clean .

to wipe out previous builds.

@dcamron said

Attached is a screenshot of the important setting beneath the body text of your PR to enable collaboration from project maintainers. This is enabled by default for me, and if it's disabled then external maintainers will not have default write access to your branch on your fork.

This raises a workflow issue. In general when we open new Pull Requests, it's probably best that they are from new feature branches of our fork, not from main. Giving people write access to our main branches sounds like it could cause trouble.

@brian-rose For git, one branch is no different than any other--main is a special one only because we humans say it is. So in my mind there's no reason to thinking giving people access to main on your fork is any different than any other.
Having said that, it's a really bad idea to be making PRs from the main branch on your fork in general. The problem is if on your laptop, you're making all your commits on main, it makes it much more challenging to then pull in changes from, say, Pythia's main branch when you want e.g. to get updated content.
TLDR; yes it's better to work on your own branch other than main, but not for the reasons you might think.

@dopplershift thanks for that, I think I "git" it

Hmm. Struggling to figure out how to use suggestions. After cloning dcamron:suggest-edits and rendering a local copy of the book, I opened the book, clicked  "suggest edit",  made my change, and then I'm given two options:

commit directly to the main branch
create a new branch and start a PR

Which do I want? I tried (1) but that seemed to actually commit the change to main (just like it says), and gave no indication that I could see that this was a suggested change (it looked like an actual change).
Thanks for any guidance.

Which do I want? I tried (1) but that seemed to actually commit the change to main (just like it says), and gave no indication that I could see that this was a suggested change (it looked like an actual change).

I'm not sure, but I suspect that option (1) only shows up if you already have write privileges in the source repo. What happens if someone who is not part of the dev team clicks the "suggested edit" button?

(1) only works since @clyne has write access. (2) would be the better way to "suggest a change", and would be the only option available to someone from the broader community. That method works pretty well for things like editing docs, where the needs for tab completion and code highlighting aren't as great as when editing code.

@dopplershift Good to know. Thanks. but  with (2) my one-line change is failing:
https://github.com/ProjectPythia/pythia-foundations/pull/29/checks?check_run_id=2271950198

Probably best to complete the discussion over there, but nothing went wrong with the process--it's just that your change is failing linting. 😉

This seems like an important infrastructure topic. The linter is very stringent. My hope is that we can set up a workflow that is a little more encouraging of community contributions!

Well the linter is able to fix that automatically for you when you make a commit locally. Heck, most editors automatically add a newline when you save. The problem is that if you do it through the GitHub web interface, it doesn't add it nor can it run the linter.
I have no idea what config tweaks exist on the linter to make this easier or if there's any way to get it to annotate the PR to identify the problematic lines.

Yeah, and I wonder whether this will just cause more rather than less confusion for a newbie who is trying to contribute.
An alternative is to remove the "suggested edit" button and instead offer detailed instructions on how to branch, edit locally, and open a new pull request. We need to do this anyway!

I think suggestions as they currently work will cause confusion and frustration. Perhaps offering multiple ways to make suggestions would be best: GitHub discussions for the impatient, or branch/edit/PR for the adventurous

Another option would be to let contributors do like @clyne did and someone with write permission can correct any style issues by pushing to their branch.

Merging now, based on our discussion at last week's EWG! Sorry I meant to do this earlier.


Investigate pdb2sql v0.5.3 error

In pdb2sql v0.5.3 a new check was created that is being triggered by deeprankcore/tools/target.py when the StructureSimilarity object is created.
I have temporarily suppressed it in PR #333. We should investigate whether this error indicates that there is something wrong in the code or not.
The error is the "Atoms not identical in ref and decoy" thing.
@NicoRenaud, any ideas/comments on this?

The change that is causing problems is this one: https://github.com/DeepRank/pdb2sql/pull/82/files


bump to 3.0.7

% git lg v3.0.6..
* 66f4c2d - (origin/master, jsvd/bump_3_0_7, master) Add info on processing order for http-input codec and additional_codecs (4 weeks ago) <Karen Metts>
* 6ee3b80 - [skip ci] Travis: update LOGSTASH_BRANCH from 6.[0..4] to 6.5 (4 weeks ago) <Rob Bavey>
* 57664bd - pin bundler version to < 2 (5 weeks ago) <Rob Bavey>
* 281c6f8 - [skip ci] update license to 2018 (1 year, 1 month ago) <Joao Duarte>

Thanks @karenzone


Code review suggestions for German translation

These are (at least should be) all the suggestions from the code review for #349. They will improve the German translation.
Thanks to @warappa for the review on #349!

Could you please add translations for these new keys?
<x:String x:Key="Text.CtrlClickTip" xml:space="preserve">Hold Ctrl to start directly</x:String>
<x:String x:Key="Text.Repository.ShowTagsAsTree" xml:space="preserve">Show Tags as Tree</x:String>


Transition to grpc

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #1

PR #2

PR #3

PR #4

PR #5   👈

This stack of pull requests is managed by Graphite.