[Avatar] common props are not being passed to custom component

Context 🔦
I am trying to use material-ui-image to load images in <Avatar />.

[ ] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

My Code
import Image from 'material-ui-image';
import Avatar from '@material-ui/core/Avatar';

export default () => (
  <Avatar
    alt="space"
    component={Image}
    src="https://material-ui.com/static/images/avatar/1.jpg"
  />
)

Current Behavior 😯
<Image /> component requires src prop to load images.
But in Avatar.js src prop is being destructured on line 106
I did not find any way to pass my src prop in <Image \> which is returned as <Component /> on line 138 of Avatar.js
I am getting this error in console which makes sense after checking Avatar.js code.
Warning: Failed prop type: The prop src is marked as required in Image, but its value is undefined.
Am I missing something here?
Is there any workaround for this problem?
Your Environment 🌎

Tech
Version

Material-UI
v4.11.0

React
16.13.0

@Adarsh077 Provide the Image as a child element to the Avatar.

Thank you @oliviertassinari and sorry guess I should improve my skill in reading documentation carefully 😅.


feature: Support sr25519 signatures

This primitive has better built-in support for domain separation, first-class HKD support, and most importantly a lack of cofactor/encoding related headaches.  The SDK should support it as an alternative to ed25519 (and perhaps start to prefer it once hardware support gets there).

[x] Go
[x] Rust
[ ] Typescript

Go and Rust have been done via https://github.com/oasisprotocol/oasis-sdk/pull/306


Sign-in error code missing: 500172

Sign-in error code missing: 500172. Failure reason listed as 'Other'.  This is occurring with POP3 and MAPI logins.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa732de6-2cab-d780-aa21-dfec80e0a8fe
Version Independent ID: 1a11b9b6-cf4f-3581-0864-0d5046943b6e
Content: Error codes in the Azure Active Directory portal
Content Source: articles/active-directory/reports-monitoring/reference-sign-ins-error-codes.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@mdcole
Thanks for your feedback! We will investigate and update as appropriate.

I have staged an updated version of this article.
#please-close


feat(Probability/Kernel/Basic): Evaluation function of a finite kernel is integrable

Can you merge master, to see if it fixes the stuck "detect changes to headers SHAs" test?

Did you merge the wrong branch? There are now category theory changes in this PR.

Yeah, I merged the wrong branch. I'm trying to figure out how to fix this

bors r+


question about imagic

Hi, this is a really cool survey and really helpful for me! I wonder how to evaluate imagic in your leaderboard? I did not find its open source code and demo to try it.
https://github.com/SiatMMLab/Awesome-Diffusion-Model-Based-Image-Editing-Methods/blob/5e3fa0ad5a6c52b65ff370eee90f262af26e0438/Leaderboard.md?plain=1#L27-L32

Thanks for your attention! We use the implementation of diffusers (https://github.com/huggingface/diffusers/blob/main/examples/community/imagic_stable_diffusion.py) to evaluate Imagic.

Thanks to your reply! I will try it.


i suggest that you add [ autocomplete="off" ] in [ core/account/edit.scala.html ]

Hi! Mr.takezoe
i suggest that you add [ autocomplete="off" ] in [ core/account/edit.scala.html ]'s password section.
such like
---------------------
<input type="password" name="password" id="password" value="" />
->
<input type="password" name="password" id="password" value="" autocomplete="off" />
---------------------
it's not big problem, but for better usability.
thank you.

@my-dev Thanks. You can send such improvements as pull request :-)


DEV: support doctesting app module and fix errors

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 91.542%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
236143

Relevant Lines:
257962

💛  - Coveralls

Everything passing with nox -s test_module_docs-3.11  and nox -s test-3.11 on my machine! This includes my min_length-related changes.


Update cotede_test.py to handle pre-1900 profiles

woa_normbias can't handle pre-1900 profiles because it uses datetime.datetime.strftime which fails if given a date before 1900. Profiles from before 1900 are set to have year=1900. This should not have an impact on QC results but will prevent an error.

I think that the update to CoTeDe must have changed the QC decisions. It's affecting the postgres branch as well, although there is an additional error message in this branch. I'll investigate as soon as possible.

I've updated the expected QC decisions. Only failure is a complaint about lack of 'threshold' being explicitly stated in the config. This would be fixed by https://github.com/castelao/CoTeDe/pull/29 but as far as I know does not impact on results.

Looks like this is passing on iquod/autoqc/postgres - thanks, @s-good!


Make solve_challenge public

Great work!
But integration with a project that does not use requests.Session is annoying ...
That's why I am asking for make public solve_challenge or even better separating and making public the prepared js. #L113-L128

The JS (as I understand) is dynamically served to you from cloudflare. In the lines you mentioned, it's simply using a few regex patterns to get that javascript, and then, after executing that JS in node and looking at the result to generate the cookie.
In fact, taking a quick look at solve_challenge reveals that it if you spend a few minutes refactoring it out of the class, it would easily work on it's own.

Yes, you are right, but the JS challenge code is changed from time to time, and as you use cloudflare-scrape as a package, it's less work with the upgrade.

There are no plans to do that at this time.


Add usage server side templates + helpers on client side using handlebars.js client

[x] Load all needed server side templates to client side
[x] Add helpers used on server side to client side
[x] Check on client side how template for message renders

Time spent: 4h 18.06.2019
Time spent: 4h 19.06.2019

Will need to check how to create message with templates on client side and render inside messages list. I will do it tomorrow

Continue work on render message on client side using templates from server-side

Now message added using client-side rendering then posted to server using fetch without reload whole page.


Information in README.md

First of all, many thanks for your Silmarils depacker and ALIS engine restoration. It's amazing work and I keep my eye on its development.
In README.md you said that “Luckily, when checking the files present on the Silmarils Trilogy CD-ROM that I bought a few years back, I ran into some C files that were not part of the DOSBox sources (but had to be shipped, do to the GPL license), and looked like custom opcode tables.”
Unfortunately, I tried but was unable to identify this disk.
I have two different Ishar Trilogy CDs (I guess you meant it by “Silmarils Trilogy”, but I'm not sure), but I don't see anything like that inside. There are no C or DOSBox files on this disk, as it was issued in the days when DOSBox was not yet needed. I don't see any such С files on the GOG release either. I guess there is another CD in your possession.
Would you be so kind as to give more information about this CD? Who released it and when? Maybe you could show a picture of the CD or the cover? Many thanks in advance for any information.

Hello,
From memory, this disk contained all the Silmarils games and many tweaked
DOSBox versions (each with its source code), so you're right, it wasn't
named "Silmarils Trilogy", but "Silmarils Collection" instead.
I don't have the CDROM anymore, but I've found a copy of the disk online:
https://archive.org/details/SilmarilsCollection
After install, the "magic" C files that helped me so much for starting
reversing the virtual machine will be located in this archive (after
install):
C:\Program Files (x86)\DotEmu\Silmarils\Source\5 - dosbox 0.73-ishar deus
delenter.zip\src\routineTableFunctionsNames.c
Cheers !
Olivier
Le ven. 16 août 2024 à 23:50, Cosmicore @.***> a écrit :

First of all, many thanks for your Silmarils depacker and ALIS engine
restoration. It's amazing work and I keep my eye on its development.
In README.md you said that “Luckily, when checking the files present on
the Silmarils Trilogy CD-ROM that I bought a few years back, I ran into
some C files that were not part of the DOSBox sources (but had to be
shipped, do to the GPL license), and looked like custom opcode tables.”
Unfortunately, I tried but was unable to identify this disk.
I have two different Ishar Trilogy CDs (I guess you meant it by “Silmarils
Trilogy”, but I'm not sure), but I don't see anything like that inside.
There are no C or DOSBox files on this disk, as it was issued in the days
when DOSBox was not yet needed. I don't see any such С files on the GOG
release either. I guess there is another CD in your possession.
Would you be so kind as to give more information about this CD? Who
released it and when? Maybe you could show a picture of the CD or the
cover? Many thanks in advance for any information.
—
Reply to this email directly, view it on GitHub
https://github.com/maestun/alis/issues/8, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6CQJW7YOJKZOW37AYL2E3ZRZX2DAVCNFSM6AAAAABMUYL2S6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3TCMBYHEYDAMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Create modal to display performance test results

Current Behavior
Performance results are show in the /results page and intermix both a line graph and metadata about the test. This text is hard to read and not well-structured. See screenshot.
Current Behavior Screenshot

Enhancement Description
This enhancement is to move the test and environment metadata into a modal that is displayed when the user clicks on the line chart.
Implementation
The metadata should be clearly structured for easy of understanding.

[ ] show metadata in a modal.
[ ] use the "results.... endpoint" for retrieving metadata.
[ ] font size increased to be the same size as the text in the results table.
[ ] a tabular format for displaying metadata would work well (i.e. columns for the label and a columns for the values) like the cluster name, Kubernetes version, Installed Mesh & its version, etc.

Mockup

Dependency:

JSON returned in the "results.... endpoint" does not currently have all available metadata to be displayed in the modal. issue/xxx will need to be delivered in order to expose all metadata.

i would like to work on this

Excellent! Yes, please, @Pika1998. :)

@Pika1998 join this Slack and we'll get you introduced to others in the community and contributor resources you might need, like the Meshery Newcomer Welcome Guide (request access).

@Pika1998 just message in Slack when you dive in here, so that we can assist if needed. :)

Hey sorry I am finding it a bit hard to understand the code
On Sun, 13 Oct 2019, 11:35 pm Lee Calcote<EMAIL_ADDRESS>wrote:

@Pika1998 https://github.com/Pika1998 just message in Slack when you
dive in here, so that we can assist if needed. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/layer5io/meshery/issues/353?email_source=notifications&email_token=AIV6ZUCAD3F6MU4FFE37ZYTQONPNLA5CNFSM4I7QQV3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBC37NI#issuecomment-541441973,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIV6ZUABTKKENIZLL5LTIIDQONPNLANCNFSM4I7QQV3A
.

@Pika1998 no problem. Join this Slack (http://slack.layer5.io) and a community member will help. // @Nikhil-Ladha


Trouble Accessing Document ID in WeaviateHybridSearchRetriever Results

System Info
langchain: 0.0.334
python: 3.11.6
weaviate-client: 3.25.3
Who can help?
No response
Information

[X] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
I am trying to implement the WeaviateHybridSearchRetriever to retrieve documents from Weaviate. My schema indicates the document ID is stored in the _id field based on the shardingConfig.
When setting up the retriever, I included _id in the attributes list:
hybrid_retriever = WeaviateHybridSearchRetriever(
  attributes=["_id", "aliases", "categoryid", "name", "page_content", "ticker"]
)

However, when I try to access _id on the returned Document objects, I get an error that _id is not found.
For example:
results = hybrid_retriever.get_relevant_documents(query="some query")
print(results[0]._id) # Error!_id not found

I have tried variations like id, document_id instead of _id but still cannot seem to access the document ID field.
Any suggestions on what I am missing or doing wrong when trying to retrieve the document ID from the Weaviate results using the _id field specified in the schema?
Let me know if any other details would be helpful in troubleshooting this issue!
Schema Details
{
   "classes":[
      {
         "class":"Category_taxonomy",
         "invertedIndexConfig":{
            "bm25":{
               "b":0.75,
               "k1":1.2
            },
            "cleanupIntervalSeconds":60,
            "stopwords":{
               "additions":"None",
               "preset":"en",
               "removals":"None"
            }
         },
         "moduleConfig":{
            "text2vec-openai":{
               "baseURL":"https://api.openai.com",
               "model":"ada",
               "modelVersion":"002",
               "type":"text",
               "vectorizeClassName":true
            }
         },
         "multiTenancyConfig":{
            "enabled":false
         },
         "properties":[
            {
               "dataType":[
                  "text"
               ],
               "description":"Content of the page",
               "indexFilterable":true,
               "indexSearchable":true,
               "moduleConfig":{
                  "text2vec-openai":{
                     "skip":false,
                     "vectorizePropertyName":false
                  }
               },
               "name":"page_content",
               "tokenization":"word"
            },
            {
               "dataType":[
                  "number"
               ],
               "description":"Identifier for the category",
               "indexFilterable":true,
               "indexSearchable":false,
               "moduleConfig":{
                  "text2vec-openai":{
                     "skip":false,
                     "vectorizePropertyName":false
                  }
               },
               "name":"categoryid"
            },
            {
               "dataType":[
                  "text"
               ],
               "description":"Ticker symbol",
               "indexFilterable":true,
               "indexSearchable":true,
               "moduleConfig":{
                  "text2vec-openai":{
                     "skip":false,
                     "vectorizePropertyName":false
                  }
               },
               "name":"ticker",
               "tokenization":"word"
            },
            {
               "dataType":[
                  "text"
               ],
               "description":"Name of the entity",
               "indexFilterable":true,
               "indexSearchable":true,
               "moduleConfig":{
                  "text2vec-openai":{
                     "skip":false,
                     "vectorizePropertyName":false
                  }
               },
               "name":"name",
               "tokenization":"word"
            },
            {
               "dataType":[
                  "text"
               ],
               "description":"Aliases for the entity",
               "indexFilterable":true,
               "indexSearchable":true,
               "moduleConfig":{
                  "text2vec-openai":{
                     "skip":false,
                     "vectorizePropertyName":false
                  }
               },
               "name":"aliases",
               "tokenization":"word"
            }
         ],
         "replicationConfig":{
            "factor":1
         },
         "shardingConfig":{
            "virtualPerPhysical":128,
            "desiredCount":1,
            "actualCount":1,
            "desiredVirtualCount":128,
            "actualVirtualCount":128,
            "key":"_id",
            "strategy":"hash",
            "function":"murmur3"
         },
         "vectorIndexConfig":{
            "skip":false,
            "cleanupIntervalSeconds":300,
            "maxConnections":64,
            "efConstruction":128,
            "ef":-1,
            "dynamicEfMin":100,
            "dynamicEfMax":500,
            "dynamicEfFactor":8,
            "vectorCacheMaxObjects":1000000000000,
            "flatSearchCutoff":40000,
            "distance":"cosine",
            "pq":{
               "enabled":false,
               "bitCompression":false,
               "segments":0,
               "centroids":256,
               "trainingLimit":100000,
               "encoder":{
                  "type":"kmeans",
                  "distribution":"log-normal"
               }
            }
         },
         "vectorIndexType":"hnsw",
         "vectorizer":"text2vec-openai"
      }
   ]
}

Example Document
{
    "class": "Category_taxonomy",
    "creationTimeUnix":<PHONE_NUMBER>601,
    "id": "ad092eb1-e4a6-4d93-a7d2-c507c33c3837",
    "lastUpdateTimeUnix":<PHONE_NUMBER>601,
    "properties": {
        "aliases": "Binance Coin, Binance Smart Chain",
        "categoryid": 569,
        "name": "BNB",
        "page_content": "ticker: bnb\nname: BNB\naliases: Binance Coin, Binance Smart Chain",
        "ticker": "bnb"
    },
    "vectorWeights": null
}

Example Search Result
{
   "status":"success",
   "results":[
      {
         "page_content":"ticker: bnb\nname: BNB\naliases: Binance Coin, Binance Smart Chain",
         "metadata":{
            "_additional":{
               "explainScore":"(vector) [-0.0067740963 -0.03091735 0.00511335 0.0016186031 -0.016120477 0.017543973 -0.0072548385 -0.023063144 0.015246399 -0.0020884196]...  \n(hybrid) Document ad092eb1-e4a6-4d93-a7d2-c507c33c3837 contributed 0.00819672131147541 to the score",
               "score":"0.008196721"
            },
            "aliases":"Binance Coin, Binance Smart Chain",
            "categoryid":569,
            "name":"BNB",
            "ticker":"bnb"
         },
         "type":"Document"
      }
   ]
}

App Code
# Prepare global variables
WEAVIATE_URL = os.getenv('WEAVIATE_URL')
WEAVIATE_API_KEY = os.getenv('WEAVIATE_API_KEY')
OPENAI_API_KEY = os.getenv('OPENAI_API_KEY')
INDEX_NAME = "Category_taxonomy"
TEXT_KEY = "page_content"

# Dependency provider function for Weaviate client
def get_weaviate_vectorstore():
    # Initialize the Weaviate client with API key authentication
    client = weaviate.Client(
        url=WEAVIATE_URL,
        auth_client_secret=weaviate.AuthApiKey(WEAVIATE_API_KEY),
        additional_headers={
            "X-Openai-Api-Key": OPENAI_API_KEY,
        }
    )

    # Initialize embeddings with a specified model
    embeddings = OpenAIEmbeddings(openai_api_key=OPENAI_API_KEY, model='text-embedding-ada-002')

    # Initialize vector store with attributes and schema
    vectorstore = Weaviate(
        client=client,
        index_name=INDEX_NAME,
        text_key=TEXT_KEY,
        embedding=embeddings,
        attributes=["aliases", "categoryid", "name", "page_content", "ticker"],
        by_text=False
    )
    return client, vectorstore

def get_weaviate_hybrid_retriever(k: int = 5):
    # Directly call the function to get the client and vectorstore
    client, vectorstore = get_weaviate_vectorstore()

    # Instantiate the retriever with the settings from the vectorstore
    hybrid_retriever = WeaviateHybridSearchRetriever(
        client=client,
        index_name=INDEX_NAME,
        text_key=TEXT_KEY,
        attributes=["aliases", "categoryid", "name", "page_content", "ticker"],
        k=k,
        create_schema_if_missing=True
    )
    return hybrid_retriever

async def parse_query_params(request: Request) -> Dict[str, List[Any]]:
    parsed_values = defaultdict(list)

    for key, value in request.query_params.multi_items():
        # Append the value for any key directly
        parsed_values[key].append(value)

    return parsed_values

@router.get("/hybrid_search_category_taxonomy/")
async def hybrid_search_category_taxonomy(parsed_values: Dict[str, List[Any]] = Depends(parse_query_params), query: Optional[str] = None, k: int = 5):
    categoryids = parsed_values.get('categoryid', [])
    tickers = parsed_values.get('ticker', [])
    names = parsed_values.get('name', [])
    aliasess = parsed_values.get('aliases', [])

    # Use a partial function to pass 'k' to 'get_weaviate_hybrid_retriever'
    retriever = get_weaviate_hybrid_retriever(k=k)

    # Initialize the where_filter with an 'And' operator if there are any filters provided
    logging.info(
        f"query: {query}, "
        f"categoryID: {categoryids}, "
        f"ticker: {tickers}, "
        f"name: {names}, "
        f"aliases: {aliasess}, "
        f"k: {k}"
    )

    # Adjustments to reference parameters from 'parse_query_params'
    where_filter = {"operator": "And", "operands": []} if any([categoryids, tickers, names, aliasess]) else None

    # Add filters for categoryid and ticker with the 'Equal' operator
    if categoryids:
        category_operands = [{"path": ["categoryid"], "operator": "Equal", "valueNumber": cid} for cid in categoryids]
        if category_operands:
            where_filter["operands"].append({"operator": "Or", "operands": category_operands})

    if tickers:
        ticker_operands = [{"path": ["ticker"], "operator": "Equal", "valueText": ticker} for ticker in tickers]
        if ticker_operands:
            where_filter["operands"].append({"operator": "Or", "operands": ticker_operands})

    if names:
        name_operands = [{"path": ["name"], "operator": "Equal", "valueText": name} for name in names]
        if name_operands:
            where_filter["operands"].append({"operator": "Or", "operands": name_operands})

    if aliasess:
        aliases_operands = [{"path": ["aliases"], "operator": "Equal", "valueText": aliases} for aliases in aliasess]
        if aliases_operands:
            where_filter["operands"].append({"operator": "Or", "operands": aliases_operands})

    try:
        # Format the results for the response
        effective_query = " " if not query or not query.strip() else query

        # Log the where_filter before fetching documents
        logging.info(f"where_filter being used: {where_filter}")

        # Fetch the relevant documents using the hybrid retriever instance
        results = retriever.get_relevant_documents(effective_query, where_filter=where_filter, score=True)

        # Format the results for the response
        response_data = [vars(doc) for doc in results]

        return {"status": "success", "results": response_data}
    except Exception as e:
        logger.error(f"Error while processing request: {str(e)}", exc_info=True)
        raise HTTPException(detail=str(e), status_code=500)

Expected behavior
Expected Behavior
When using the WeaviateHybridSearchRetriever for document retrieval, I expect that including the _id attribute in the attributes list will allow me to access the document ID of each retrieved document without any issues. Specifically, after setting up the WeaviateHybridSearchRetriever like so:
hybrid_retriever = WeaviateHybridSearchRetriever(
    attributes=["_id", "aliases", "categoryid", "name", "page_content", "ticker"]
)

I anticipate that executing a query and attempting to print the _id of the first result should successfully return the unique identifier of the document, as per the below code snippet:
results = hybrid_retriever.get_relevant_documents(query="some query")
print(results[0]._id)  # Expecting this to print the _id of the first result

In this scenario, my expectation is that the _id field, being specified in the attributes parameter, should be readily accessible in each Document object returned by the get_relevant_documents method. This behavior is crucial for my application as it relies on the unique document IDs for further processing and analysis of the retrieved data.

I appreciate your earlier guidance on including the _id attribute in the WeaviateHybridSearchRetriever. Following your suggestion, I implemented a subclass, CustomWeaviateHybridSearchRetriever, to append _id to the attributes list. However, I encountered an error indicating that _id is not a recognized attribute in the query.
Error
raise ValueError(f"Error during query: {result['errors']}")

ValueError: Error during query: [{'locations': [{'column': 184, 'line': 1}], 'message': 'Cannot query field "_id" on type "Category_taxonomy".', 'path': None}]

I've attached the updated implementation of my subclass for your reference. Could you please advise on how to resolve this issue or suggest an alternative approach to include the _id attribute in the search results?
class CustomWeaviateHybridSearchRetriever(WeaviateHybridSearchRetriever):
    def __init__(self, **data: Any):
        super().__init__(**data)
        self.custom_validate_client()

    def custom_validate_client(self):
        if "_id" not in self.attributes:
            self.attributes.append("_id")

def get_weaviate_hybrid_retriever(k: int = 5):
    # Directly call the function to get the client and vectorstore
    client, vectorstore = get_weaviate_vectorstore()

    # Instantiate the retriever with the settings from the vectorstore
    hybrid_retriever = CustomWeaviateHybridSearchRetriever(
        client=client,
        index_name=INDEX_NAME,
        text_key=TEXT_KEY,
        attributes=["_id", "aliases", "categoryid", "name", "page_content", "ticker"],
        k=k,
        create_schema_if_missing=True
    )
    return hybrid_retriever

I'm quite surprised that there isn't a more straightforward way to retrieve the Weaviate document_id from search results, akin to how the document type is always returned. I'm wondering if I might be overlooking a simpler solution or an essential step in the process.

I successfully implemented a solution for retrieving the document ID from Weaviate search results by creating a subclass of WeaviateHybridSearchRetriever. This subclass overrides the _get_relevant_documents method.
The key modification in this method is the inclusion of "id" in the query_obj.with_additional call whenever the score parameter is set to True.
class ModifiedWeaviateHybridSearchRetriever(WeaviateHybridSearchRetriever):
    def _get_relevant_documents(
        self, query: str, *, run_manager: CallbackManagerForRetrieverRun,
        where_filter: Optional[Dict[str, object]] = None,
        score: bool = False,
        hybrid_search_kwargs: Optional[Dict[str, object]] = None
    ) -> List[Document]:
        ...
        if score:
            query_obj = query_obj.with_additional(["score", "explainScore", "id"])
        ...

While this implementation works as intended and solves the problem at hand, I am still exploring if there's a more straightforward or less invasive method to achieve this. Overriding an entire class to modify a single method seems somewhat excessive for what appears to be a relatively simple requirement.
Ideally, a more direct way to include the document ID in the search results, without the need for subclassing, would be preferable. I am open to suggestions and hoping for an easier solution that aligns with best practices and maintains the integrity and simplicity of the code.

@blockfer-rp fyi, this is solved in the new integration. See langchain-ai/langchain-weaviate#87


Overrides existing protected branch settings

Before enabling LGTM, I had "Include Administrators" enabled and other status checks enabled on my protected branch. After enabling LGTM on the repo, "Include Administrators" was disabled and my other status check was disabled, leaving only approvals/lgtm enabled.

tracking under #10

because the github protected branches API is unstable and in developer preview, the API behavior has changed significantly since last November. Previously the PATH didn't replace or overwrite existing information. The API endpoint has now been completely replaced as of last week [1] and LGTM will need to be adjusted accordingly
[1] https://developer.github.com/changes/2016-06-27-protected-branches-api-update/


Is it possible to show different widths?

I wanna achieve something like this:
Is it possible with this library? If not, is it planned to add this feature?
Thank you in advance!
As you can see, some of the bricks are different sized in width:

+1


Add support for a shared folder

Hello,
First of all thank you for your fantastic work on this. It has helped me save time immensely.
I'd like to request adding support for a shared folder. Especially when Typescript is also supported for src/main in the future.
One use case for this is for interfaces that can be shared between main and renderer.
Consider the following interface:
export interface Something {    somethingA: string;    somethingB: number; }
Then in the main process we have an IPC handle:
ipcMain.handle("my-channel", (event, args) => {    // Return something or do something });
And in the renderer:
ipcRenderer.invoke("my-channel", something);
Likewise for common services that could be shared between main and renderer.
Thanks

Glad this helped not only me 😃
I was thinking about a shared folder, I will look into that after typescript support for main. Though it has some fundamental inconsistencies as both main and renderer would bundle it and you can't really be sure that both processes will get the same result. For now, I'd suggest creating a yarn workspace with your constants and re-use them in both main and renderer.

Hi,
Thanks for getting back to me. I look forward to the updates, if I can help out in anyway let me know!
Thanks

@BarFoo upgrade to latest version and check examples for setup config

@karolis-sh Thanks very much, I will check it out.


[CI] Migrate CI pipelines from Jenkins to BuildKite

I have been personally maintaining our Jenkins CI server (https://xgboost-ci.net/) since April 2018. While the CI pipeline has been a great asset to the XGBoost project, it suffered from a few glaring problems:

Security issues necessitate frequent system updates, and some plug-ins would unexpectedly fail. The plug-in oriented architecture of Jenkins makes it brittle
The Jenkins server involves lots of manual configuration via its GUI
Many cloud components (EC2 machine images, Lambdas, Jenkins server software) were manually set up by me; no reproducible provision; no ability to debug the setup process
Most importantly, I am the only person who knows how to manage the server. It's hard to delegate, since most portion of the Jenkins setup was done manually by me.

To address the issues, I am migrating our CI pipeline to BuildKite. BuildKite is a SaaS (Software as a Service) that orchestrates cloud machines to host CI pipelines. Benefits include:

Minimal pricing overhead over what we already spend on AWS. They only charge $9/month per each admin user we add on BuildKite control panel. The funding will still come from our Open Collective account.
Reduced maintenance burden as we no longer have to run a server 24/7
Infrastructure as Code. Using CloudFormation, we automate the provision of various cloud resources. No more manual configuration or setup.
As a result, someone else who decides to take over the management of the CI pipeline will have easier time understanding the system.
YAML configuration file to define the pipeline; those who are familiar with GH Action will feel right at home.
Many open-source projects use it: LLVM, CUDA.jl, Horovod.

is there any github integration like a status icon?

Yes, you'll see an icon on the master branch already. Pull requests don't have an icon yet because we haven't merged this PR yet. For now, I created a separate feature branch to test BuildKite: https://github.com/dmlc/xgboost/tree/use_buildkite

could you please add some documents to give a brief introduction on how things work and how others should maintain it?

Yes, let me write documentation this week.

Now every test job will require a manual approval prior to running. This will significantly reduce our CI expenses.

Build status:

https://buildkite.com/xgboost/xgboost-ci/builds/56
https://buildkite.com/xgboost/xgboost-ci-windows/builds/52

Merging this for now. I will closely monitor the CI for next 3 days (until Sep 10). If everything goes well, I will remove Jenkins


Aarch64 macOS: ucontext_t is not FFI-Safe

When using ucontext_t in getcontext (manually added, the API seems not to be exported on aarch64 mac in libc), like so:
extern "C" {
    fn getcontext(ucp: *mut ucontext_t) -> c_int;
}

the compiler complains that ucontext_t is not ffi-safe, as 128 bit integers are not supported in FFI.
I did not find any use of 128 bit ints, hence, I assume the compiler is overly smart for the neon state(?) which is:
    #[repr(align(16))]
    pub struct __darwin_arm_neon_state64 {
        pub __v: [[u64; 2]; 32],
        pub __fpsr: u32,
        pub __fpcr: u32,
    }

When I hand-roll the ucontext_t struct, including a neon-state like this, the compiler no longer complains.
#[repr(C, align(16))]
pub struct arm_neon_state64 {
    pub opaque: [u8; (32 * 16) + (2 * mem::size_of::<u32>())],
}

Coincidentally, my testcase would segfault after the original getcontext, which may be related.
This is on macos, aarch64, with libc 0.2.121 and rust 1.59.0

Thanks for the report. isn't it because ucontext_t type has a missing field in libc ? mcontext_data

What I can propose eventually :

adding the "missing" field here (and tests still pass with) but you keep the getcontext prototype in your side. Indeed the *context api on macos is deprecated and the aforementioned field exists solely when used with the *context api (means setting _XOPEN_SOURCE but that create a lot of build warning in all other parts.
keeping all the definition in your side as you are already doing.

Let me know what you think.

As far as I can tell, there is not really any good alternative to these APIs, and of course it would be great to have them somehow officially supported by the libc create (?)
I guess there is no concept of feature flags to enable deprecated APIs by any chance?

I ve prepared a change, is it possible for you to temporarily tried out this repo/branch ?

I guess there is no concept of feature flags to enable deprecated APIs by any chance

I added it there but beware it says "no longer supported" whatever that means :-)

I think this change broke the sigaction API on Apple silicon. Related to https://github.com/wasmerio/wasmer/issues/4072


Tweaked screenshot tool for Firefox on Windows 10 (closes #55)

\cc @inikulin @AlexanderMoskovkin

@AndreyBelym Can you bump version in context of this PR, please?

No problem.

lgtm

lgtm


Error when executing Custom Button - "takes from 2 to 3 positional arguments but 4 were given"

I was able to find and add my custom remote, however it appears only the power toggle works.
All other custom buttons within the remote return the same error upon invoking them.
Integration Debug logs:
homeassistant_switchbotremote_debug_logs.txt

Switchbot Remote, and HA Integration Setup:

@joshepw could you check?

Any progress on this?

@Maetzi87 i'll try to figure out in this weekend, but idk if I have time.

Thank you 😀

Hello guys, sorry i will check right now this

@MarcStocker I've bumped a new release 1.1.1 that should fix this issue.


chore: update to temurin 17

WHAT
updates all Dockerfiles and CI jobs to use temurin-17
WHY
it is the latest LTS version

We should pin the parent images to a specific version in the Dockerfiles. Otherwise our builds wouldn't be reproducible.

17.0.6_12-jre-alpine seems to be the latest one

<IP_ADDRESS> doesn't exist. Only the <IP_ADDRESS> exists on hub.docker.com https://hub.docker.com/_/eclipse-temurin/tags?page=1&name=17.0.6

don't know how that ended up in my clipboard...

merging, as previously approved.


VTR200/B connection type/wirring

Hello/Labdien
I see you are using very the same Systemair model VTR200/B that I need to make the installation. I do not have free access to the top of the unit - not easy to identify connectors on the top.
Could you please help:

Waveshare RS485 unit connected to VTR200/B modbus port
What jack type is used for Modbus port at VTR200/B - rj10 or rj45? (if you share the picture of connection it would help me a lot)
Could you please share the wiring schema?

Thank you in advance
Malik

Hi,
Waveshare RS485, you can get from eay, something like that one:
https://www.ebay.com/itm/255747041868?_skw=Waveshare+RS485&itmmeta=01J9RM2FWHHT6TDRHR7B4CJ3GJ&hash=item3b8bb62a4c%3Ag%3AW~cAAOSwKb9jMr2p&itmprp=enc%3AAQAJAAAA8HoV3kP08IDx%2BKZ9MfhVJKmdqqNoqCEaUioLoYhxLC5CB3JAip5aXYMOw5GZWv612V9kw5E8HEvfFoy%2BXnLTpaO4M6MOC8rc8oFnRFPOIuud1D9Es2dF6m3W5LUs%2By2hbM3Y3sNLDbIlz5TAwKhPAMKK6CxF1GMCAB%2F5USsSoH8TKZFbZdHKxgGCzzNceawhKoFldZj%2BONJ9E4k4Yhork9ThwoATBqjPTdJrJOaFpxnHXZB%2F287JJJMeb40JTBbVVJZVBRmWR%2FBIT7XqvHB9aXQer%2BOxmzRNJtlo6%2F80xiDcXdhl06MI7%2B6m2JPBBVnZmw%3D%3D|tkp%3ABk9SR67-iZTOZA&var=555680671976
It is rj45.
Wiring schema is here:
https://camo.githubusercontent.com/043aa0c0b10ad7f6918f2d3d0c19cd348e2c843b503ed5650dd81e34d1d694df/68747470733a2f2f692e696d6775722e636f6d2f705949493365612e6a706567
On connector side, it is just regular ethernet cable:
https://incentre.net/wp-content/uploads/2024/06/ethcable568b.gif
Cheers!

Hi! Did you figure it out? Do you still need my assistance or I can close this issue? Cheers!

thank you


[AutoPR] mixedreality/resource-manager

Created to accumulate context: mixedreality/resource-manager

(message created by the CI based on PR content)


feat: add VS code notifications for workspace actions

Opening this PR in place of #110 as this solution is a little cleaner.
This resolves https://github.com/coder/coder/issues/7360

I have not tried it out yet since when I build it tells me deleting_at does not exist. Do we need to update the coder dependency maybe?
Done! Let me know if you still see that error.


Use Array.isArray instead of util.isArray in flash.js

This PR addresses the [DEP0044] DeprecationWarning in Node.js, which suggests replacing the deprecated util.isArray with Array.isArray().  (below)
(node:38224) [DEP0044] DeprecationWarning: The util.isArrayAPI is deprecated. Please useArray.isArray() instead.
Needed to install diff@latest and vows@latest for npm test to pass.

duplication of https://github.com/jaredhanson/connect-flash/pull/57


docs: new tutorial "create asyncapi documents"

Description

This is the first part on the streetlights tutorial which describes how to "create asyncapi documents"

Related issue(s)
Fixes #850

Hello @alequetzalli & @derberg , I would love your feedbacks
Thank you!

Thanks @derberg!
I just sent in my update, kindly have a look.

Hi @alequetzalli & @derberg,
I've implemented the changes, kindly help review.
Thank you!

I just left one comment and looks like this one is ready.
What are the plans for merging these, are you waiting for all tutorials to be ready or?

What are the plans for merging these, are you waiting for all tutorials to be ready or?

Yes @derberg all 4 new GSoD tutorials must be merged together. We decided this months ago because of the prev/next buttons each one has.

We decided this months ago because of the prev/next buttons each one has.

I already know, my comment is month old 😼

We decided this months ago because of the prev/next buttons each one has.

I already know, my comment is month old 😼

BAHAHAHA oops my bad then 🙊 😂  @derberg

it has been a while, sorry but I need to clarify
in case of tutorials, didn't we agree that there will always be a CLI command (maybe also studio instruction) that will instruct how to perform tutorial steps? so in the end you can just do asyncapi new SOMETHING and you get the same file generated immediately? to assure tutorials are based on the same example?

it has been a while, sorry but I need to clarify
in case of tutorials, didn't we agree that there will always be a CLI command (maybe also studio instruction) that will instruct how to perform tutorial steps? so in the end you can just do asyncapi new SOMETHING and you get the same file generated immediately? to assure tutorials are based on the same example?
something like https://github.com/asyncapi/website/pull/1061/files#diff-8e9be9eabe193de3ae63ce37ae40ca0ab76e4567ed323f605572fa788f48da97R17-R27 that you can see here https://deploy-preview-1061--asyncapi-website.netlify.app/docs/tutorials/message-validation#background-context

added, we're ready for review again @derberg

You wrote "this tutorial is about creating asyncapi document, no generation should be mentioned", but then you proceed to add a commit with the word generate 😜  ... nicely going there @derberg ... 😂

Nice catch tho so thank you... and I fixed it for real 😄✌🏽

/rtm


Fixed too few arguments exception thrown in the admin with using flex objects

https://github.com/getgrav/grav/issues/3657
The following methods from the  Grav\Common\Flex\Types\Pages\PageIndex object do not work as expected in Admin.

public function ofType($type)
public function ofOneOfTheseTypes($types)
public function ofOneOfTheseAccessLevels($accessLevels)

Preconditions and environment

Grav CMS v<IP_ADDRESS>
PHP 7.4

Steps to reproduce

Load the Pages Collection of type 'default’ in the admin using the following code $grav['flex']->getCollection('pages')->ofType('default’)

Expected Result
The collection Grav\Common\Flex\Types\Pages\PageCollection is loaded with all the pages of a type ‘default’.
Actual Result
Too few arguments to function Grav\Common\Flex\Types\Pages\PageCollection::ofType(), 0 passed in grav-cms/system/src/Grav/Framework/Flex/FlexIndex.php on line 489 and exactly 1 expected

Thanks for this, will review and get back to you.


[Bug]: The size of the overlay2 folder is growing rapidly

Is there an existing issue for this?

[X] I have searched the existing issues

Example public repository
coolify
Description
Hi,
On one of my servers, I installed Coolify, I then tried to deploy various applications, however when I checked the disc consumption, it was excessive upon more inspection, I discovered that overlay2  is consuming more space. It may have been as a result of coolify. So if you can, please examine and inform me of the solution.
Steps To Reproduce
Install the coolify and try to deploy some applications. Then verify the overlay2 size
Version
v3.12.31

The overlay2 folder is used by Docker to store the different layers of images. The growth of it isn't exclusively an issue with Coolify as it also happens with other solutions (e.g. Portainer, but even manually deploying images and containers via the CLI).
It's feasible that Coolify might not be cleaning up unused images, but you may want to consider pruning unused images and containers: docker system prune --all
(Details: https://docs.docker.com/engine/reference/commandline/system_prune/)

I will add a bit more aggressive cleanup on the docker images/caches in the next version.
(In v4, these automations will be more precise and alert you in your preferred notification thing (email/discord/slack/telegram...) if something is not okay with your server.)


Integrated terminal session restore should inherit some ENV vars instead of restoring them

The current terminal session restore overwrites all ENV vars.  I want to be able to supply a list of ENV names to never overwrite.
Specifically, after a computer reboot, the value of SSH_AUTH_SOCK changes.  I want the new value to propagate into all processes and terminals and such.  However with the terminal session restore, it overwrites SSH_AUTH_SOCK with the old value that is no longer valid.  So I would like to have a config somewhere to say that when restoring the session, don't overwrite these names if they exist all ready.

I hit this while setting up my new PC and it was definitely a little confusing.


Used with iPad air4 got a error

Showing Recent Messages
'/Users/herryliq/Library/Developer/Xcode/DerivedData/Example-bqnbyojkvoxhdfcptdgyoanshrsi/Build/Products/Debug-iphoneos/libpython3.8.a(ceval.o)' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. for architecture arm64

Bitcode is not supported.  Please turn off bitcode.

Thanks for your reply.
With  turn off bitcode, I can run the Example project in iPad air4.


Localize “email address” placeholder on home page

https://github.com/kubernetes/website/issues/19272
/language es

/assign

/remove-lifecycle stale

https://github.com/kubernetes/website/pull/19365 has been already merged, this issue can be mark as resolved!
Thanks @npu21!


Internationalization add urser form

@sneridagh by mistake I committed directly to the 16.x.x branch, to make a backport. See if I need to revert. Sorry for the mistake.

@wesleybl I guess that reverting will add more noise even. No worries but please pay more attention to it. Create always a backport PR from the squashed commit in master. Target it to the milestone 16.x.x

@sneridagh Should we add a branch protection rule for the 16.x.x branch so this can't happen by accident?

@davisagli done.


Documentation examples for fractional delay fail

General

pyfar version: develop

Description
Building the documentation fails for the examples for fractional delay function.
See:
https://app.circleci.com/pipelines/github/pyfar/pyfar/270/workflows/7fc7df39-77b5-41cf-af5b-e51e0aa296d2/jobs/1456

I think I fixed this (in bad practice) as part of another pull-request. Lets wait if this still happens after merging open pulls.

Dude, if you don't stop doing this, we'll really need to start a penalty system where you buy everyone else a pack of beers each every time this happens!

Does Sterni count as beer?


Folded text respects org_hide_leading_stars

This commit adds a better foldtext function that replaces leading stars with spaces when org_hide_leading_stars is true.
Example without this commit (Lines 2 and 5 are folded):

Same example with this commit:

Thanks

Nice, thanks!


fix typo in documentation

Fix some typos in the example for handling errors
What was changed
Fix some typos on the documentation about error handling
Why?
This change was done for two reasons:

It was unsatisfying to see
If someone copies the example and uses it as a base for their own error handling the example should be working.

Checklist

How was this tested:
This only includes some changes to comments so no executable code is affected. Therefor it is untested

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the contribution, this whole error switch should be its own sample


Distributed orientDB node becomes unreachable for unknown reasons

OrientDB Version, operating system, or hardware.

v2.2 SNAPSHOT[x]

Operating System

[x] Linux

Expected behavior and actual behavior
In our system we have two distributed database nodes. Periodically we faces with issue when one of nodes become unreachable for unknown reasons. I can see process of this node, but when I try to connect via console, it stucks on connecting. In orientDB logs I saw "out of memory" error messages and increased heap in server.sh

ORIENTDB_OPTS_MEMORY="-Xms512m -Xmx4g -Dstorage.diskCache.bufferSize=8000"

but it seems this hasn't helped us.
Our database size is 2.3GB and I have no idea how it can produce out of memory errors.
Here is crashed node logs:
https://www.dropbox.com/s/605xsy93msygjzb/crashed-orient-log.txt?dl=0
Here is stacktrace of crashed node (it was unreachable from console when I got this stacktrace):
https://www.dropbox.com/s/5nmge3mswgxbsb9/crashed_node_stacktrace.txt?dl=0

How much available RAM do you have before to start OrientDB? Please remember that the sum of -Xmx4g and -Dstorage.diskCache.bufferSize=8000 must be minor of the available RAM.

About 15Gb

@lvca What do you think about available RAM?
What can be the reason of our problem and how we can to fix it?

@syzdykov is this issue still present with a recent 2.2.x?

Closing this issue, because of no response after a while. In case this issue is still valid, please comment this. Thanks.


Open XML Productivity Tool should normally open files read-only

I mostly use the Open XML Productivity Tool as a diff system, and it's proved very useful in this role. However, the tool appears to open all files read-write, which means I can't run my own Packaging code while I have a diff open in Tool.
This is frustrating because debugging packaging/openxml code often consists of finding a problem in the diff, fixing your code, and then attempting to re-export your file. Since Tool has the file locked, the only way to write a new version is to quit Tool, run your code, quit your code (because it won't open a file open elsewhere), and then go through the entire diff process again.
I don't see any way to change a file using the Tool, so it does not appear there is any need for the files to be opened read-write. Changing this to read-only, even if just in diff, would greatly improve workflow.

@maurymarkowitz thanks for the suggestion.

@maurymarkowitz, @tomjebo, I thought the Open XML Productivity Tool is no longer supported. Or we can expect its new versions?🙂


look up ActiveRecord::Base.descendants instead of .subclasses

Backstory
In Rails 5, all models inherit from ApplicationRecord, which inherits from ActiveRecord::Base ( https://github.com/rails/rails/pull/22567 ). For instance, my User model:
class User < ApplicationRecord
    # model stuff
end

sprig-reap looks up models via ActiveRecord::Base.subclasses, which only looks up direct subclasses of ActiveRecord::Base. As a result, rake db:seed:reap in Rails 5 fails silently with no records reaped:
D, [2016-07-15T11:48:44.342965 #93348] DEBUG -- : Reaping records from the database...
D, [2016-07-15T11:48:44.345559 #93348] DEBUG -- : Finished reaping!

Reaping from the Rails console shows the error:
$ rake db:seed:reap MODELS=User
rake aborted!
ArgumentError: Cannot create a seed file for User because it is not a subclass of ActiveRecord::Base.

Tasks: TOP => db:seed:reap
(See full trace by running task with --trace)

Change
Using the .descendants method, however, all levels of subclassing can be accessed, and I can successfully reap all of my models.
Rather than changing sprig-reap to look up direct subclasses of ApplicationRecord, I've modified it to call ActiveRecord::Base.descendants. This should preserve compatibility with pre-Rails-5 models that inherit directly from ActiveRecord:Base and/or don't inherit from ApplicationRecord.

Thanks for the PR!  I need to add some additional tests around STI to make sure the change from ActiveRecord::Base.subclasses to ActiveRecord::Base.descendants doesn't result in an extra seed file being generated for the base class.  If it does, I'll have to handle that case.
Either way -- appreciate this!  I'll try to get on the STI thing sometime over the next week.


Failed to update auto layout status with LTMorphingLabel

Hi,
I just updated to Xcode 8 and Swift 2.3 and the LTMorphingLabel, which had been working perfectly, started throwing the following error in my storyboard:
error: IB Designables: Failed to render and update auto layout status for UserViewController (IXY-6h-Cuw): dlopen(LTMorphingLabel.framework, 1): Symbol not found: __TMPVs19DictionaryGenerator   Referenced from: LTMorphingLabel.framework   Expected in: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Overlays/../../../../../../Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib  in LTMorphingLabel.framework
This prevents selection of the ViewController containing the LTMorphingLabel from the TabBarController. I have tried removing and reinstalling it in my podfile and updating Cocoapods. Any help would be greatly appreciated.
Thanks

I have the same problem. I'm seriously considering uninstalling this pod since it prevent me from working properly with IB Designable and IB Inspectable

Hi @LivioGama,
I was pressed for time with my project and ended up deciding to work with UILabel in order to adjust constraints and positioning in the storyboard, then changing the label's class to LTMorphingLabel at the last minute.
However, this is obviously less than a workaround, and if you have the time it may be worth writing a simple animation of your own, this tutorial http://swiftyeti.com/texteffects-with-nslayoutmanager/  looks relatively simple and could potentially be adapted to something like LTMorphingLabel or you could look at something like FlipLabel (https://github.com/beryu/FlipLabel) by @beryu, which looks wonderful.
I would like to add, however, that LTMorphingLabel has worked perfectly in production and the effects are incredibly well done.
Best of luck

Hi,
I unfortunately don't have time to work on it. I ended up by uninstalling LTMorphingLabel.
In addition you should know that LTMorphingLabel doesn't work well on iOS 8, tons of crash from Crashlytics.

Guys, I'm so sorry for that inconvenience. But I'm busy working on my reallife job. I hope I have more spare time to contribute to this project. I have to say it's a experimental project. Please consider better alternatives until I remove this tag.
Back to this issue. Maybe it's related to https://github.com/CocoaPods/CocoaPods/issues/5334 ?


fix(t8s-cluster/management-cluster): ignore machine images for artifa…

…cthub
Needs https://github.com/teutonet/teutonet-helm-charts/pull/280 to be merged

This mechanic should be documented, i already see myself getting confused over how the comments are used for this :D


Bot Response

Hello.
I'd like to report that I've a bot to send commands and It doesn't get a response from /status command.

Thanks in advanced.

.... that's on purpose

Its to prevent users from spamming, no need to check server status each minute

Yeah of course, that was an example, just need a 1 hour message not every minute. I did the test with 10 minutes and the bot doesn't get any response too.

bot messages are ignored


fix(hack): use /dev/urandom for token secret on WSL

As these are hack scripts to help spin up a development environment, we should lean towards usability over security.
WSL does not have enough entropy available to generate a random seed with /dev/random.
Using /dev/urandom is less cryptographically secure, but it enables users on WSL to utilize the hack script.
closes #276
Signed-off-by: Matthew Fisher<EMAIL_ADDRESS>

Today I also learned https://www.2uo.de/myths-about-urandom/


updated scheduler extension

Overview
This PR updates the scheduler extension. It replaces dill by a json dump/load to transfer the job status to the scheduler working nodes.
It has been tested with slurm. See the updated scheduler docker demo:
https://github.com/bird-house/birdhouse-docker-images/tree/master/pywps-scheduler-demo
Related Issue / Discussion
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x ] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x ] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@tommygod3 maybe you like to try it on your side. There are probably still issues which we can fix in this PR.

Coverage increased (+0.6%) to 75.054% when pulling 3ddf237884d9d750e597bd5def7d3fd561f26b6a on cehbrecht:update-scheduler into e9b939aa1992c99cc151c86efed08b890096225a on geopython:master.

@cehbrecht Will have a look

@cehbrecht Tested on SLURM and it works :)

@tommygod3 cool :) Thanks for trying it :)

Think it is safe to say this would close #480

@tommygod3 done.


frontend common/Label: Do not end-align HoverInfoLabel

The HoverInfoLabel was changed to have its contents aligned to the
end (right, in LTR languages) as the date label used should be aligned
as such and uses this component internally. However, many other values
are represented with this label, so we cannot always align it.
This patch fixes that by making this component have an inline-flex
display, allowing for the labels+icons to be vertically aligned to the
center (reason for which it had a display:flex rule) while respecting
the text-align rule set on a wrapping element. i.e. the date labels get
aligned to the right in most tables as their cell has that text-align
rule, but other uses of the mentioned component don't get affected.
Before the fix:

After the fix:

How to test:

[ ] Go to the details view of a Custom Resource (object) that has extra columns (values in the metadata display grid that have an info icon): verify that these are not aligned to the right in the row (screenshots above)
[ ] Go to any resource list: verify the date column is still aligned to the right

This fixes both the extra info alignment and the date


Is there a way to share data among emmulated users?

I have a series of data sets that I use for my load testing, and I want to make them available for all the users instantiated, since the data is large and kept on memory. If I understand correctly how locust works, it doesn't seem possible to share data among hatched users, or am I missing something?

Hi!
If you're not running locust on a single machine and a single processor core (not distributed) there's no problem sharing data beteen the Locust user instances.
However, for larger load tests you'll most likely want to run Locust distributed over multiple processes on multiple machines. Then you'll need to use some sort of central database for the data that you want to share between the Locust user instances. You could use Redis, or whatever DB you fell like.

Alternatively, if the data is like stored in file and read into memory, for distributed mode, each slave could just hold their own copy in memory. Should work as long as there is no unique-ness that each slave needs to be aware of for other slaves in terms of the dataset.


Future Ownership

Just as an awareness thing, I've no longer got a Dreamscreen so I'm not able to continue maintaining this. I know that @J3n50m4t was doing a lot of work on this and keeping it relevant. If someone wants to take ownership and move the repo into their own space I'm more than happy to facilitate that. Otherwise I don't believe I'll be active in this project any longer.

Hey Gregory,
I'm not a python developer in the first place, but I will keep it up to date. Big Feature Requests may be a bit difficult for me, but I always try my best.
Feel free to transfer it to me. I will publish updates, as I still love my dreamscreen and i love Homeassistant.


Physical deletion for Trie/TrieMap

Update: The current AssocList.replace() with null is indeed deleting.
This PR only optimizes the Trie and TrieMap delete functionality that it can free more memory.
Leaves (but not the branches) are recursively collapsed along the delete path in the trie.

Unit testing: Added randomized tests for TrieMap, implicitly also testing Trie.
GC benchmark: Shows that more heap space can be reclaimed than with the current implementation.

(The existing remove logic only stored a logical delete flag, null, in the cleared entry and therefore was leaking memory.)

@luc-blaeser  I do not follow this claim.
The existing logic, as with the new logic proposed here, uses association lists.  Those lists then must do the delete physically for the Trie or TrieMap to have this property.
Looking at the existing replace logic (which subsumes both insert and remove and implements both with a more general type), I see that it does in fact "shrink" the list when it finds the target element of the remove (again, phrased as a replace):
        case (?((hd_k, hd_v), tl)) {
          if (equal(key, hd_k)) {
            // if value is null, remove the key; otherwise, replace key's old value
            // return old value
            switch value {
              case (null) { (tl, ?hd_v) };
              case (?value) { (?((hd_k, value), tl), ?hd_v) }
            }
          } else {
          ...
          }

So we see that in the subcase for null, the copied list really is shrinking.
I realize that this PR is doing some orthogonal improvements around this operation, but I remain very confused by the claim that the existing logic does not actually release memory (after GC over a TrieMap that uses this logic, it should, right)?

(The existing remove logic only stored a logical delete flag, null, in the cleared entry and therefore was leaking memory.)

@luc-blaeser I do not follow this claim.
The existing logic, as with the new logic proposed here, uses association lists. Those lists then must do the delete physically for the Trie or TrieMap to have this property.
Looking at the existing replace logic (which subsumes both insert and remove and implements both with a more general type), I see that it does in fact "shrink" the list when it finds the target element of the remove (again, phrased as a replace):
        case (?((hd_k, hd_v), tl)) {
          if (equal(key, hd_k)) {
            // if value is null, remove the key; otherwise, replace key's old value
            // return old value
            switch value {
              case (null) { (tl, ?hd_v) };
              case (?value) { (?((hd_k, value), tl), ?hd_v) }
            }
          } else {
          ...
          }

So we see that in the subcase for null, the copied list really is shrinking.
I realize that this PR is doing some orthogonal improvements around this operation, but I remain very confused by the claim that the existing logic does not actually release memory (after GC over a TrieMap that uses this logic, it should, right)?

Thanks Matthew for pointing this out. You are right, I found a mistake in my benchmark case (deleting less than allocating). I am very sorry for this confusion.
So, after re-measuring (hopefully correct this time), the benchmark shows that a majority of the memory can be reclaimed after deleting the entries in the TrieMap. Only the (empty) leaves in the trie remain after delete. This PR only adds a small optimization insofar that it also combines and frees some of the leaf nodes.
Measurement results, creating 1_000_000 (Nat, Nat) entries in a TrieMap, then removing all of them (several rounds):
Heap size

After allocation
After deletion (current code)
After deletion (with this PR)

75MB
11 MB
2MB

The question is on whether we should consider this PR or close it for the moment.

@luc-blaeser Okay, I am relieved.  No worries!
Before you mentioned finding an actual bug, I started wondering if the Trie is just so wasteful (rebuilding those little lists in a pure way) that it seemed like there was a leak, as you alluded to today in the meeting.
FWIW, I apologize for the Trie being cryptic in its implementation.  When I started rereading that code snippet this morning I started doubting if I even understood it, then I did again, eventually. :)

The space savings (and more tests) still look worthwhile to me, so I'd suggest continuing with the PR or merging in its current state (perhaps with TODO to improve filter and mapFilter (if we have that)..
Is it possible to get to the situation where removing all the elements from a tree gets you back to #empty or is that just too expensive to arrange? I'm just curious, not necessarily suggesting we reach for that goal.

The space savings (and more tests) still look worthwhile to me, so I'd suggest continuing with the PR or merging in its current state (perhaps with TODO to improve filter and mapFilter (if we have that)..
Is it possible to get to the situation where removing all the elements from a tree gets you back to #empty or is that just too expensive to arrange? I'm just curious, not necessarily suggesting we reach for that goal.

I tested it, and the tree is actually empty again after the removal of all entries.

Nice. Just made some minor suggestions to remove parens and perhaps optimize replace, but all optional.
There's probably similar spurious parens in patterns in the rest of the file, but I can't make GH suggestions on unchanged lines. Probably not worth fixing.

Thanks a lot for all these valuable suggestions. Would you like to push the parentheses optimization?


Upgraded to Spark 2.0. Contains  breaking changes - not backwards…

… compatible.

Thanks for your contribution. I have a few comments/questions.

Spark 2.0 is still in "preview". Can we defer this PR until it is officially released?

What do you mean by "backward compatibility to Spark 1.X", your pom.xml specifies Spark 2.0, so it will be built with Spark 2.0. Do you mean I can take the compiled jar file and launch it with Spark 1.6.1, which is the latest release?

Why do you need a new Logger? I notice you copy it from org.apache.spark.internal. Does the existing Logger in CaffeOnSpark not meet your needs?

Superseded by  https://github.com/yahoo/CaffeOnSpark/pull/79

@junshi15
I have built a completely new PR #79 that makes the whole process simpler.
https://github.com/yahoo/CaffeOnSpark/pull/79
To answer your questions:

My team is building only on top of Spark 2.0 . At the very least we need this presently.  It is my intention to help out the overall project .

My original PR recommended  to maintain a separate 2.0-only branch.   @mriduljain  requested to make it backwards compatible on same branch : so the new PR addresses this.

New PR takes care of this.

The Logger is required because of one of CaffeOnSpark classes improperly depends on internal Spark Logging class - which is noted  in 1.x to be deprecated for external use and in fact is private in 2.X.  Take a look at  LmdbRDD  "with Logging".

This looks fine. I will test out locally soon and then we should be good. Meanwhile you should be able to move ahead anyway.


Improve error descriptions around S3 operations and storage

Now, this isn't exactly pretty (maybe @cutepig has ideas on prettifying it?), but this PR turns the previously somewhat cryptic API error:
ERROR (API) AccessDenied: Access Denied
    at Request.extractError (/var/runtime/node_modules/aws-sdk/lib/services/s3.js:816:35)
    at Request.callListeners (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
    at Request.emit (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/var/runtime/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/var/runtime/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/var/runtime/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /var/runtime/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/var/runtime/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/var/runtime/node_modules/aws-sdk/lib/request.js:685:12)
    at Request.callListeners (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:116:18)
    at Request.emit (/var/runtime/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/var/runtime/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/var/runtime/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/var/runtime/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /var/runtime/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/var/runtime/node_modules/aws-sdk/lib/request.js:38:9) {
  message: 'Access Denied',
  code: 'AccessDenied',
  region: null,
  time: 2020-04-29T08:56:51.766Z,
  requestId: 'CF791B7D850C56CC',
  extendedRequestId: 'Vm/45e1bjUBoxsI+vRgAtTasPfdAlFyMqyQbHx7etTlbqOjbSsWmuAK0amObA68vfYzxmXkRwiE=',
  cfId: undefined,
  statusCode: 403,
  retryable: false,
  retryDelay: 4.375497904653702
}

to:
API request processing failed (caused by
Error: Couldn't obfuscate low population postal code "99999" (caused by
Error: Couldn't get JSON from S3 object "symptomradar-dev-open-data/low_population_postal_codes.json" (caused by
AccessDenied: Access Denied
)
)
)

I was mostly thinking whether you find wrapping entire function bodies in a try/catch entirely appalling, or merely slightly distasteful, and whether something nicer might get the same job done.
With Promise chains, this is less ugly, because to get this "error refinement" behaviour, you just tack a .catch(...rethrow...) to the end of a chain.


Build fails on Arch Linux

Hi,
I haven't been able to figure out why the build fails on my side. In the log:
LOG from webpack.FileSystemInfo
<w> Managed item /home/ryutas/packages/cowasm/cowasm/packages/browser/node_modules/python-wasm isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option)
+ 12 hidden lines

and
ryutas@archlinux ~/packages/cowasm/cowasm
ls -l packages/browser/node_modules/python-wasm
lrwxrwxrwx 1 ryutas ryutas 17 Jan 20 07:16 packages/browser/node_modules/python-wasm -> ../../python-wasm

but I don't see any pytnon-wasm in packages directory. Am I missing something?
Any advice will be greatly appreciated. Thank you!
Here is the full log:
ryutas@archlinux ~/packages/cowasm/cowasm
make
./bin/make-all all packages/browser/ packages/build/ packages/bzip2/ packages/coreutils/ packages/cowasm.org/ packages/cowasm.sh/ packages/dash/ packages/dash-wasm/ packages/dylink/ packages/f2c/ packages/kernel/ packages/less/ packages/libedit/ packages/libffi/ packages/libgit2/ packages/libpng/ packages/lua/ packages/luatex/ packages/lzma/ packages/man/ packages/ncurses/ packages/openssl/ packages/posix-browser/ packages/posix-node/ packages/posix-wasm/ packages/rogue/ packages/sqlite/ packages/tar/ packages/termcap/ packages/terminal/ packages/viz/ packages/wasi-js/ packages/wasm-opt/ packages/zlib/

TARGET=$1
shift
ROOTDIR=`pwd`

for PACKAGE in $*
do
    cd "$ROOTDIR/$PACKAGE"
    echo $PACKAGE
    if [ $TARGET = "all" ]; then
        make
    else
        make $TARGET
    fi
done
packages/browser/
make[1]: Entering directory '/home/ryutas/packages/cowasm/cowasm/packages/browser'
npm ci

added 471 packages, and audited 1886 packages in 12s

102 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
npm run build

><EMAIL_ADDRESS>build
> webpack

asset main.bundle.js 461 KiB [compared for emit] (name: main)
asset index.html 246 bytes [compared for emit]
runtime modules 1.13 KiB 5 modules
modules by path ./node_modules/ 156 KiB
  modules by path ./node_modules/assert/build/ 67.8 KiB 4 modules
  modules by path ./node_modules/object-is/*.js 1.14 KiB 4 modules
  modules by path ./node_modules/is-nan/*.js 1.2 KiB 4 modules
  modules by path ./node_modules/util/ 27.9 KiB 3 modules
  modules by path ./node_modules/object-keys/*.js 4.36 KiB 3 modules
  modules by path ./node_modules/debug/src/*.js 12 KiB 2 modules
  modules by path ./node_modules/call-bind/*.js 1.68 KiB 2 modules
  modules by path ./node_modules/function-bind/*.js 1.55 KiB 2 modules
  modules by path ./node_modules/has-symbols/*.js 2.13 KiB 2 modules
  + 18 modules
modules by path ./src/*.ts 9.31 KiB
  ./src/index.ts 2.94 KiB [built] [code generated]
  ./src/python.ts 6.37 KiB [built] [code generated] [1 error]

LOG from webpack.FileSystemInfo
<w> Managed item /home/ryutas/packages/cowasm/cowasm/packages/browser/node_modules/python-wasm isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option)
+ 12 hidden lines

ERROR in ./src/python.ts 38:0-37
Module not found: Error: Can't resolve 'python-wasm' in '/home/ryutas/packages/cowasm/cowasm/packages/browser/src'
 @ ./src/index.ts 39:0-30 46:37-43

ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/kernel.ts
3:28-44
[tsl] ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/kernel.ts(3,29)
      TS2306: File '/home/ryutas/packages/cowasm/cowasm/packages/kernel/index.d.ts' is not a module.

ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/python.ts
./src/python.ts 3:23-36
[tsl] ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/python.ts(3,24)
      TS2307: Cannot find module 'python-wasm' or its corresponding type declarations.
 @ ./src/index.ts 39:0-30 46:37-43

3 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.73.0 compiled with 3 errors in 1720 ms
make[1]: *** [Makefile:9: /home/ryutas/packages/cowasm/cowasm/packages/browser/dist/.built] Error 1
make[1]: Leaving directory '/home/ryutas/packages/cowasm/cowasm/packages/browser'
make: *** [Makefile:10: all] Error 2

Could you give the exact steps you take, from start to finish, starting with "git clone ..."?

Here's the exact steps:
$ git clone --recursive https://github.com/sagemathinc/cowasm
$ cd cowasm
$ make

and the full log:
ryutas@archlinux ~/packages/cowasm
git clone --recursive https://github.com/sagemathinc/cowasm
Cloning into 'cowasm'...
remote: Enumerating objects: 20441, done.
remote: Counting objects: 100% (1380/1380), done.
remote: Compressing objects: 100% (515/515), done.
remote: Total 20441 (delta 895), reused 1308 (delta 840), pack-reused 19061
Receiving objects: 100% (20441/20441), 13.33 MiB | 9.37 MiB/s, done.
Resolving deltas: 100% (14775/14775), done.

ryutas@archlinux ~/packages/cowasm
cd cowasm/

ryutas@archlinux ~/packages/cowasm/cowasm
make
./bin/make-all all packages/browser/ packages/build/ packages/bzip2/ packages/coreutils/ packages/cowasm.org/ packages/cowasm.sh/ packages/dash/ packages/dash-wasm/ packages/dylink/ packages/f2c/ packages/kernel/ packages/less/ packages/libedit/ packages/libffi/ packages/libgit2/ packages/libpng/ packages/lua/ packages/luatex/ packages/lzma/ packages/man/ packages/ncurses/ packages/openssl/ packages/posix-browser/ packages/posix-node/ packages/posix-wasm/ packages/rogue/ packages/sqlite/ packages/tar/ packages/termcap/ packages/terminal/ packages/viz/ packages/wasi-js/ packages/wasm-opt/ packages/zlib/

TARGET=$1
shift
ROOTDIR=`pwd`

for PACKAGE in $*
do
    cd "$ROOTDIR/$PACKAGE"
    echo $PACKAGE
    if [ $TARGET = "all" ]; then
        make
    else
        make $TARGET
    fi
done
packages/browser/
make[1]: Entering directory '/home/ryutas/packages/cowasm/cowasm/packages/browser'
npm ci

added 471 packages, and audited 1886 packages in 9s

102 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
npm run build

><EMAIL_ADDRESS>build
> webpack

asset main.bundle.js 461 KiB [emitted] (name: main)
asset index.html 246 bytes [emitted]
runtime modules 1.13 KiB 5 modules
modules by path ./node_modules/ 156 KiB
  modules by path ./node_modules/assert/build/ 67.8 KiB 4 modules
  modules by path ./node_modules/object-is/*.js 1.14 KiB 4 modules
  modules by path ./node_modules/is-nan/*.js 1.2 KiB 4 modules
  modules by path ./node_modules/util/ 27.9 KiB 3 modules
  modules by path ./node_modules/object-keys/*.js 4.36 KiB 3 modules
  modules by path ./node_modules/debug/src/*.js 12 KiB 2 modules
  modules by path ./node_modules/call-bind/*.js 1.68 KiB 2 modules
  modules by path ./node_modules/function-bind/*.js 1.55 KiB 2 modules
  modules by path ./node_modules/has-symbols/*.js 2.13 KiB 2 modules
  + 18 modules
modules by path ./src/*.ts 9.31 KiB
  ./src/index.ts 2.94 KiB [built] [code generated]
  ./src/python.ts 6.37 KiB [built] [code generated] [1 error]

LOG from webpack.FileSystemInfo
<w> Managed item /home/ryutas/packages/cowasm/cowasm/packages/browser/node_modules/python-wasm isn't a directory or doesn't contain a package.json (see snapshot.managedPaths option)
+ 12 hidden lines

ERROR in ./src/python.ts 38:0-37
Module not found: Error: Can't resolve 'python-wasm' in '/home/ryutas/packages/cowasm/cowasm/packages/browser/src'
 @ ./src/index.ts 39:0-30 46:37-43

ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/kernel.ts
3:28-44
[tsl] ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/kernel.ts(3,29)
      TS2306: File '/home/ryutas/packages/cowasm/cowasm/packages/kernel/index.d.ts' is not a module.

ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/python.ts
./src/python.ts 3:23-36
[tsl] ERROR in /home/ryutas/packages/cowasm/cowasm/packages/browser/src/python.ts(3,24)
      TS2307: Cannot find module 'python-wasm' or its corresponding type declarations.
 @ ./src/index.ts 39:0-30 46:37-43

3 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.73.0 compiled with 3 errors in 1531 ms
make[1]: *** [Makefile:9: /home/ryutas/packages/cowasm/cowasm/packages/browser/dist/.built] Error 1
make[1]: Leaving directory '/home/ryutas/packages/cowasm/cowasm/packages/browser'
make: *** [Makefile:10: all] Error 2

After the latest refactor I got this to work, building everything (including all the python packages like pandas and numpy too) all on archlinux.  There were numerous subtle little issues with make vars, etc., that I had to fix.  Also I figured out that this is the minimal list of packages to install:
pacman -Sy binutils git nodejs npm cmake curl m4 yasm texinfo python libtool tcl zip unzip patch binutils diffutils

I did my build testing in a Docker container on x86_64 Linux, started using
docker run -it archlinux bash

Then just install the above, git clone https://github.com/sagemathinc/cowasm/, cd in and make.

Oh, the full test suite (via make test) also passed on aarch linux for me.  Yeah!

Thank you for the fix!
One thing I realized was that pnpm was not part of the standard Arch Linux package.
It may be useful to document how to get pnpm. For example, I installed pnpm from
https://aur.archlinux.org/packages/pnpm

Thanks for testing.

It may be useful to document how to get pnpm

Can you make a PR?


Class type parameter is not flowed to class property

class Class<T> {
  a: (b: T) => string
}

class Class2 extends Class<number> {
  a = b => 'b' // ERROR: Parameter 'b' implicitly has an 'any' type.
}

Expected: b should be a number
Actual: b is any
This is likely tracked already, but I was not able to find it. Filing here just in case.

#10570


[Snyk] Upgrade @testing-library/react from 16.0.1 to 16.1.0

Snyk has created this PR to upgrade @testing-library/react from 16.0.1 to 16.1.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released a month ago.

Release notes

Package name: @testing-library/react

16.1.0 - 2024-12-0516.1.0 (2024-12-05)
Features

Add support for React 19 (#1367) (85ac253)

16.0.1 - 2024-08-2916.0.1 (2024-08-29)
Bug Fixes

Add support for exactOptionalPropertyTypes in TypeScript (#1351) (3dcd8a9)

    from @testing-library/react GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@0467616). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage        ?   66.57%
=======================================
  Files           ?       20
  Lines           ?      700
  Branches        ?        0
=======================================
  Hits            ?      466
  Misses          ?      234
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix cluster redis bug #19910

This PR is for:

Server

Fixes cluster redis bug
Steps to reproduce the bug
Changes to fix the bug
Affected branches

main

Checklist

[ ] Added unit test to verify the fix.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhengya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature: Add confirmation buttons to date pickers

Related Issues
Closes #254
Short Description and Why It's Useful

Adds confirmation buttons to all app date pickers

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

@adityasharma7

Thanks @franciscoemanuel! This has been merged with https://github.com/hotwax/job-manager/pull/269


HIRE DIGITAL WEB RECOVERY : THE TOP CRYPTO RECOVERY EXPECT FOR BTC/ETH/USDT RECOVERY

Crypto theft is on the rise thanks to people going crazy over Bitcoin and Ethereum. Greedy scammers are scheming and tricking innocent investors into losing their precious digital coins. But fear not, for there is a glimmer of hope in the form of Digital Web Recovery. Back in 2022, I threw all my hard-earned cash into Bitcoin. Fast forward to today, I had amassed a cool 50 BTC, which was now worth over a million bucks. I thought my private keys were safely tucked away offline, but turns out I fell for a sneaky phishing scam. Next thing I knew, my crypto fortune had disappeared into the abyss of an anonymous wallet. Lesson learned: always keep your keys close and your scams closer. Distraught at having my nest egg wiped out, I turned to Digital Web Recovery, a new service specializing in tracking stolen crypto funds and assisting victims. Through advanced blockchain analysis, Digital was able to trace the path the stolen Bitcoins took as they got laundered through various wallets under the hacker's control. Eventually Digital located the hacker's main wallet and coordinated with law enforcement to seize the wallet and return the stolen crypto to me. Thanks to Digital web recovery crypto tracking expertise and perseverance, I recovered my lost life savings. I am now a firm believer in using crypto recovery services for protection against theft. My story highlights that even if you lose crypto funds to hacking or scams, there are still options like Digital Web Recovery, their website https://digitalwebrecovery.com/ that may be able to recover your losses by following the digital trail on the blockchain. So call Digital web recovery today through: Zoho Mail<EMAIL_ADDRESS>Telegram user; @digitalwebrecovery

Fraudulent binary options go to great lengths to advertise their platforms mostly on social networking sites, trading websites, message boards, and even spam e-mails.. They make promises of easy money, low risk, and superior customer service
Potential investors are also cold-called from boiler room operations, where high-pressure salespeople use banks of phones to make as many calls as possible to offer “once-in-a-lifetime” opportunities. Many binary option outlets have been exposed as fraudulent and cash has been recovered from them through. To recover your money or bitcoin from Binary option scammer i suggest you contact a recovery company like ( accessrecoveryconsultant @ GMAIL COM )


exclude files via command line?

Is there a way to exclude paths and files via a command line option? I know it's possible via config file.
JSHint has the option to exclude:
--exclude

Allows you to specify directories which you DON'T want to be linted.

I'm trying to avoid having to create a new ignore file in each of our projects and instead just include in my package.json as an npm script. Looking through bin/jscs leads me to believe this is not possible today. Is this correct?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/22279635-exclude-files-via-command-line?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Yes, there's excludeFiles: https://github.com/jscs-dev/node-jscs/blob/master/OVERVIEW.md#excludefiles.
Feel free to ask questions like this on the gitter channel: https://gitter.im/jscs-dev/node-jscs

This lets me ignore using a config file, but this option doesn't exist using the command line tool (as far as I can tell).
I will take my question to gitter - thanks for the heads up.

Actually, you're right. This doesn't exist. I assume we'd accept a comma-sep list of dir-names and split that to form the excludeFiles config value.

PR welcome!

Forked the project - will give it a shot!

Working on this

Wouldn't it be better to exclude mutiple files by using this:
jscs lib/config/configuration.js --exclude lib/config/configuration.js,lib/config/blabla.js
instead of this:
jscs lib/config/configuration.js --exclude lib/config/configuration.js --exclude lib/config/blabla.js

Yes, there's excludeFiles: https://github.com/jscs-dev/node-jscs/blob/master/OVERVIEW.md#excludefiles.

Think that excludeFiles should not be a part of .jscsrc. It causes some issues when copying/pasting .jscsrc from project to project. excludeFiles should be an argument of some internal checkFileList function, which should filter the list IMHO

Yeah, we agree, feel free to implement

At this point only major and CST related bugs will be fixed.


Meta

if anyone ever tells you that meta is hard
they are wrong

also apparently discord defaults to using opengraph meta tags if oembed isn't available
so this should look :ok_hand: when embedded in discord
ofc we can't test it yet because it's not on an actual live public server

Rebased


Using this package without ipvs doesn't return error

I use you example, slightly modified;
package main

import (
	"log"

	"github.com/moby/ipvs"
)

func main() {
	handle, err := ipvs.New("")
	if err != nil {
		log.Fatalf("ipvs.New: %s", err)
	}
	log.Println("ipvs.New did NOT give an error!!")
	_, err = handle.GetServices()
	if err != nil {
		log.Fatalf("handle.GetServices: %s", err)
	}
	log.Println("handle.GetServices did NOT give an error!!")
}

And run on a kernel where ipvs is not configured. Output:
# moby-example
WARN[0000] Running modprobe ip_vs failed with message: `modprobe: WARNING: Module ip_vs not found in directory /lib/modules/6.1.0`, error: exit status 1
ERRO[0000] Could not get ipvs family information from the kernel. It is possible that ipvs is not enabled in your kernel. Native loadbalancing will not work until this is fixed.
2022/12/23 18:09:43 ipvs.New did NOT give an error!!
2022/12/23 18:09:43 handle.GetServices did NOT give an error!!

So, that ipvs can't be loaded is obviously noted, but even so err==nil is returned.
This is a serious bug, which enforces weird work-arounds do detect if ipvs can be used:
https://github.com/Nordix/kubernetes/blob/68d78c89eccf2d2f381033c836472d53f3ba41c9/pkg/proxy/ipvs/proxier.go#L692-L694

This is output on a statically linked kernel where ipvs is configured:
# moby-example
WARN[0000] Running modprobe ip_vs failed with message: `modprobe: WARNING: Module ip_vs not found in directory /lib/modules/6.0.0`, error: exit status 1
2022/12/23 18:22:09 ipvs.New did NOT give an error!!
2022/12/23 18:22:09 handle.GetServices did NOT give an error!!

Please drop the "WARN". To use a statically linked kernel is not an "odd thing". When using moby/ipvs in a system that tries to use structured logging, printouts like this from a library is an annoyance.

Is this project still active?

@thaJeztah


"could not import [package]" error when building with go modules

I have the following .go2 code
package main

import (
	"github.com/NdoleStudio/lfu-cache"
)

func main() {
	_, _ = lfucache.New(3)
}

module test.com

go 1.14

require github.com/NdoleStudio/lfu-cache v1.0.1 // indirect

If I attempt to build it with
 docker run --rm -v "$PWD":/go/src/myapp -w /go/src/myapp levonet/golang:go2go go tool go2go build

I get the error
main.go2:1: cannot find package "github.com/NdoleStudio/lfu-cache" in any of:
        /usr/local/lib/go/src/github.com/NdoleStudio/lfu-cache (from $GOROOT)
        /tmp/go2go173741299/src/github.com/NdoleStudio/lfu-cache (from $GOPATH)
        /usr/local/lib/go/src/cmd/go2go/testdata/go2path/src/github.com/NdoleStudio/lfu-cache
        /go/src/github.com/NdoleStudio/lfu-cache
/usr/local/lib/go/bin/go [build] failed: exit status 1

I even tried downloading the dependency before building with the command
 docker run --rm -v "$PWD":/go/src/myapp -w /go/src/myapp levonet/golang:go2go /bin/bash -c "go get -v && go tool go2go build"

And I still get the same error. I'm not sure if this is an issue with this docker image or if the issue is with go2go itself  https://github.com/golang/go/issues/40061

Closing this since it's caused by golang/go#40061


Example: changing HCL files

We are collecting specific use cases on this, user feedback welcome, particularly specific scenarios with code snippets.

Examples from my experience:

Change VPC IP adress blocks
deprecate an instance type
change module versions
upgrade terraform
change AWS IAM policy across all repositories using a template


Data dependent method calling

We have currently concept of single caller methods (#416, #425). Such methods allow us to add condition in ready signal which depends from input argument. Such conditions are only supported in single caller methods, because when there are two or more callers there is a risk that we end up with combinational cycle. Goal of this PR is to extend data dependent readiness of methods to multi caller methods.
Current implementation of transactron assume that readiness signal is constant for the whole cycle. So we use it to calculate runnable signal for each transaction. When ready signal depend from data we can decided after scheduling a transaction to execution that method isn't ready. This cause change in runnable and an another transaction can be chosen to execution, which data will be potentially accepted by method, so the ready will be high one more time and the whole story will repeat.
Solution which I propose in this PR is to calculate data dependent readiness before scheduling the transaction, so that we already know that method will accept data from this transaction. The old ready signal is used as global readiness for the whole method for backward compatibility.
Additionally I modified types in method_uses to be more strict. Instead of ValueLike only Record is accepted. This allow to properly type input argument for the user_ready_function.

Solution which I propose in this PR is to calculate data dependent readiness before scheduling the transaction, so that we already know that method will accept data from this transaction.

I find this explanation very unintuitive. "Before" and "after" doesn't matter for combinatorial logic; only thing that exists are data dependencies. What you are doing, in actuality, is generating separate circuits for the readiness condition for each calling transaction. This relaxes the previous restriction on ready signals, but at the cost of a (potentially small) increase in circuit size.
The idea seems sound; I'll review the PR later.

The old ready signal is used as global readiness for the whole method for backward compatibility.

This is not just backward compatibility. Both things have a different performance characteristic: there is only one combinatorial circuit generating the old ready signal, but the ready function is instantiated for each transaction calling the method.

Merged without a second review.


ISPN-5298 HotRod millisecond precision for lifespan/maxidle

https://issues.jboss.org/browse/ISPN-5298

Bumped Hot Rod protocol version to 2.2
Support for all time units from the API. Timespan and maxidle are sent using vLong. Timeunits are encoded in an extra byte (4 bits timespan + 4 bits maxIdle)
Added test for millisecond precision
Updated documentation
Removed hardocoded server version on JCache TCK remote tests

Also it seems like all of the hotrod SSL tests fail now. http://ci.infinispan.org/viewLog.html?buildId=26149&buildTypeId=bt9&guest=1

@wburns I can't reproduce those failures here... CI is showing exact the same (intermittent) failures for test running on IBM JDK 1.8...Not sure if it's related, will dig it further

PR updated.

Removed the 30 days rule for protocol versions >= 2.2
Added DEFAULT and INFINITE special units to avoid sending the values when not needed.

I have no local test failures, OTOH It looks like something is massively broken on CI, with plenty of Unsupported major.minor version 52.0 being thrown everywhere.
On the bright side, at least  hotrod-server and hotrod-client are passing :smile:

Looks good to me, any other comments @wburns @danberindei ?

Btw, TCK tests are passing when combining this PR with https://github.com/infinispan/infinispan/pull/3449 including the millisecond expiration.

@gustavonalle @galderz Looks good, only one small comment about the lifespan > 0 check in Codec22.

@gustavonalle @galderz On further consideration, I see 0 must have a special meaning in RemoteCache because of the way put(k, v) is implemented in RemoteCacheSupport, so let's integrate this PR as is.

Seems fine to me as well.

The failures on CI are happening on master as well and DistWriteSkewAtomicMapAPITest.testConcurrentWritesAndIteration seems not related, it failed randomly recently...

Ok, integrating...

Done, thanks Gustavo!


Alert closing needs a transition

Instead of having an alert being closed just close instantly, it would be great to have a transition so it smoothly fades away instead.
Bonus points if you can vertically center the close button along with the transition.
Be sure to comment if you would like to complete this issue so that we know who is doing what.

I can work on figuring this out

Cr*p, I'd take this but it's too late and I should hit the bed.
If @mtoadvine does not do it tonight, I can do it in the morning...
Will check on this repo tomorrow anyways, maybe more things appear as issues.

OK @dvlden . @mtoadvine You can take this issue over.

Yeah I'm at work tonight. Should I have a slow night (I work EMS) I might be able to get it.

Already pointed some things out and improvement to @mtoadvine pull request.
It's not ideal tho, I think whole component should be refactored and maybe jQuery should not be a dependency at all.

@dvlden If you don't mind, could you go into a little more depth about how you plan on refactoring the alert component before you get started, just so I can get an idea about the changes being made

Sure, may I open a new issue where I explain everything more detailed?

Definitely @dvl. New issue would work best for a full refractor of a
component. I will close this issue now and let you open a new one.
On Wed, Oct 4, 2017 at 9:01 AM, dvL<EMAIL_ADDRESS>wrote:

Sure, may I open a new issue where I explain everything more detailed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cpdevelops/simple.css/issues/30#issuecomment-334165147,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APfr97DtcwMlOgUCuaejwoHsdNYib_L1ks5so4_DgaJpZM4Ps6BF
.

--
Colin Pokowitz
<EMAIL_ADDRESS>www.cpdev.me


Also Error on load with Lazy and neovim 0.9.2,.

Problem

Steps to reproduce

Setup the plugin with Lazy config
maybe same to _https://github.com/lukas-reineke/indent-blankline.nvim/issues/700#issue-1927882676_
but i have no idea to fix it.
removing show_first_indent_level = true is not work.
Expected behavior
The error should not appear
Neovim version (nvim -v)
0.9.2

update your plugin, it has been fixed, see the commit https://github.com/lukas-reineke/indent-blankline.nvim/commit/877c1db2bf957300097dd5348a665666a4d900cb

@Couto ψ(._. )> yeah, maybe it is, i didn't notice this commit.  my bad.😂


Update and rename "Send an SMS" link

Previous link was linking to a broken header. Updated the link to redirect to the correct header.

@nathan78906 Good catch, thanks!