update deps, modernise usage, use readable-stream

some modernisation:

use readable-stream rather than stream to prevent breakage and fix to a specific version (stream_browserify is currently being a pain because of upstream breakage)
update dependencies, fix all security warnings
update standard and fix all linting errors
switch from new Buffer() to Buffer.alloc() and Buffer.from()
skip tests for signatures where the algorithm isn't supported by Node.js (main algos that use DSA and SHA1 which have been removed from the default OpenSSL bundle now used)
update travis descriptor to run on latest versions of Node.js
(edit: updated) added explicit require('buffer').Buffer to make it safe for Webpack 5 et. al. that are dropping node.js buildins.

this is all semver-patch safe for anything Node 6 and above, semver-minor could be a good idea to send a signal about amount of change if you like

should we be using safe-buffer (which is what we do for a bunch of other crytpo-browserify libs so we probably wouldn't be adding it to the deps)

No, safe-buffer is redundant these days. I think we were even shipping the new Buffer APIs back in a later release of version 4. All supported release lines now support the new APIs and as long as you're using them directly then there's nothing safe-buffer can add and it ends up being both a noop and dead-weight in your dependency tree:
https://github.com/feross/safe-buffer/blob/7d544741d5a360613abb0d47926e107722fae723/index.js#L11-L13
var buffer = require('buffer')
var Buffer = buffer.Buffer
...
if (Buffer.from && Buffer.alloc && Buffer.allocUnsafe && Buffer.allocUnsafeSlow) {
  module.exports = buffer
} else {
  // Copy properties from require('buffer')
  copyProps(buffer, exports)
  exports.Buffer = SafeBuffer
}

In other words, if you're still using safe-buffer, it's time to remove it.

Related with #47 ....

so we need to figure out how we are going to support both browserify and webpack when wepback starts forcing you to requiring 'buffer' while browserify doens't allow you to require buffer (you need to require('buffer/'))

Regarding bn.js upgrade issues, there probably solution (https://github.com/indutny/bn.js/issues/239#issuecomment-631309725) which will allow use v4.x and v5.x at one time, but while bn.js is not updated in libs each bundle will have two bn.js versions =(

ah fuck I missed that this upgraded that, ok we should revert that

Or we should force bn.js v5.x everywhere :)
I actually think that if bn.js v4.x patch will be successful revert here will not be required.

No, I don't think it would break.
Is this about cutting a release? 3 years after merge? Caring about a version of Node.js that's been unsupported for more than 5 years? Maybe none of this matters and do whatever feels most comfy to you.


Client id for crawlers to work with nodebalancer

Changes
Added client id argument for crawlers
How to test these changes?
Requres tests
Related issues

Fall with error:
polygon-synchronize[1476292]:     raise HTTPError(http_error_msg, response=self)
polygon-synchronize[1476292]: requests.exceptions.HTTPError: 415 Client Error: Unsupported Media Type for url: http://nodebalancer.moonstream.internal:8
544/nb/polygon/jsonrpc

resolved with https://github.com/bugout-dev/moonstream/pull/567


Could you tell me how to use the pod is available adapter Swift4.0 Moya/RxSwift？

hi,
I through
pod 'Moya/RxSwift '

RxSwift version can't get Swift, Excuse me, is my wrong operation?
I use
pod" Moya/RxSwift', '~ > 10.0.0'

and 'pod install'
is errors.
Thank you，ooo

Hey @ReverseScale - can you post your complete podfile?
Also, please try pod 'Moya/RxSwift' without the space at the end - does that fix the problem?

Hey @BasThomas
# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'podsMoyaDemo' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!
  pod 'Moya/RxSwift'

  # Pods for podsMoyaDemo

  target 'podsMoyaDemoTests' do
    inherit! :search_paths
    # Pods for testing
  end

  target 'podsMoyaDemoUITests' do
    inherit! :search_paths
    # Pods for testing
  end

end

Analyzing dependencies
Downloading dependencies
Installing Alamofire (4.5.1)
Installing Moya (9.0.0)
Installing Result (3.2.4)
Installing RxSwift (3.6.1)
Generating Pods project
Integrating client project

try 'pod update '

Hey @ReverseScale - @Mikelulu's suggestion fixes the problem, but doing a pod install should install version 10.0.0 as far as I can tell. I'll create a separate issue. 👍

👌,Thank you very much for your answer😀


Pop contains invalid chars while provisioning in HomeKit Example (MEGH-2323)

Development Kit: ESP32-DevKitC
Kit version (for WroverKit/PicoKit/DevKitC): DevKitv1
Module or chip used: ESP32-WROOM-32
IDF version (run git describe --tags to find it):
v4.2
Build System: idf.py
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
8.4.0
Operating System: Windows
(Windows only) environment type: PowerShell
Using an IDE?: No
Power Supply: USB
Pop contains invalid chars while provisioning in HomeKit Example.
Ex.:
https://rainmaker.espressif.com/qrcode.html?data={"ver":"v1","name":"PROV_8BEA1C","pop":"���X57�g","transport":"softap"}
I (1720) app_wifi: Provisioning Started. Name : PROV_8BEA1C, POP : ���X57�g

This issue is still there.
Any help is appreciated.

@adukale , we plan to make some more changes to the wifi code in HomeKit, but for the time being, you can use this patch:
homekit_wifi_patch.txt
Apply using:
git apply homekit_wifi_patch.txt

@shahpiyushv Awesome. This fixed the issue.
The homekit code seems bit complicated to me but considering functionality it is worth diving into.
Cheers...!
Thanks. Appreciate your help.


RGB 48LE XYZ input help

Hi
I don't know if this is a stupid question :-) but I'm trying to find my fastest options to convert a bitmap formatted as RGB48LE in XYZ space to RGB 709 or 2020, and hopefully a result consisting of 10 bit or higher data and/or include HDR data.
I wonder if zimg supports that and if yes, hopefully some help on the matter.
Thank you very much.

zimg_image_format src_format, dst_format;
zimg_image_format_default(&src_format, ZIMG_API_VERSION);
zimg_image_format_default(&dst_format, ZIMG_API_VERSION);

// Width, height here.
src_format.pixel_type = ZIMG_PIXEL_WORD;
src_format.color_family = ZIMG_COLOR_RGB;
src_format.matrix_coefficients = ZIMG_MATRIX_RGB;
src_format.transfer_characteristics = ZIMG_TRANSFER_LINEAR; // Or something else.
src_format.color_primaries = ZIMG_PRIMARIES_ST428;

// Width, height here.
dst_format.pixel_type = ZIMG_PIXEL_WORD;
dst_format.color_family = ZIMG_COLOR_RGB;
dst_format.matrix_coefficients = ZIMG_MATRIX_RGB;
dst_format.transfer_characteristics = ZIMG_TRANSFER_BT2020_10;
dst_format.color_primaries = ZIMG_PRIMARIES_BT2020;

zimg_filter_graph *graph = zimg_filter_graph_build(&src_format, &dst_format, NULL);

If the XYZ contains colors not representable in the output color space, then the colors will be per-channel c.lipped (inaccurate). To handle this case, you can convert to floating-point linear RGB and use a separate solution for gamut mapping. Note that XYZ exchange is most commonly used to transfer DCI-P3 content.

Great, thank you for the solution.
Does the api support passing the packed byte buffer, or should I convert it to planar first? I remember you once mentioned in comments that only planar input is accepted.

Planar only.


changing domain from "katsuragi.detzz.in.th" to "katsuragi.cyou"

@dethMastery Thanks for keeping the info up to date.
I checked your RSS feed, it still points to your old domain, so links in the RSS feed is now broken. Please fix that. Meanwhile, I’ll go ahead and merge your changes.
Cheers!


explore generating SVG entities for each onion piece

to make visual comparison between piece areas easier, like this D3 demo by Jason Davies which sorts countries by decreasing area

approach in https://github.com/the-pudding/onion/commit/fad0f7ac337ce3da00b470112eb42b70d5c4a77c uses masks, but these pieces won't animate cleanly for #17. so probably best to use a library like clipper-js (see comment in commit)


[ARCTIC-441] Unify the options of file and log in arctic source

Solve #441
Why are the changes needed?
For now, scan.startup.mode has valid values 'earliest-offset、latest-offset、group-offsets、timestamp、specific-offsets' in arctic.read.mode=log, but 'earliest、latest' in arctic.read.mode=file.
And group-offset is the default value for log, but earliest for file.
On the other hand, the default value for 'streaming' is false, but the majority is true.
It's inconvenient for user.
Brief change log

Unify the 'scan.startup.mode' configuration for file and log.
The flink 1.12 and 1.14, 1.15 versions are affected.
Change the default value of streaming to true.

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[X] Run test locally before making a pull request

Documentation

Does this pull request introduces a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zstraw  You may change the comment of PR from Solve #441 to Resolve #441 to link this PR with issue.


Make test runs parallel by default.

Unit tests run in ~1 min. Using our PR/CI builds as a gate keeper for reliability.

@dotnet-bot test Windows_NT / Release Build please


a take on making sagas easier to grok

After diving into Redux, I've been reading through all of the issues that discuss handling async effects. It seems like redux-saga has been the most championed idea on that front. But there's still talk of canonicalizing an "official" way to do side effects that's easier to grok, since the learning curve for redux-saga is still really steep.
I figured I'd throw something here that might be useful, or might be complete non-sense...
Here's an example, of what a current saga implementation might look like:
import fetch from 'isomorphic-fetch'
import * as actions from '../actions'
import { call, fork, take, put } from 'redux-saga'

/**
 * Users saga.
 *
 * @param {Function} getState
 */

function* users(getState) {
  yield fork(get, getState)
  yield fork(create, getState)
  yield fork(update, getState)
  yield fork(remove, getState)
}

/**
 * Get a user by `id`.
 *
 * @param {Function} getState
 */

function* get(getState) {
  while (true) {
    const action = yield take(actions.USER_GET)
    const { id } = action

    const state = getState()
    const user = state.api.users[id]
    if (user) return yield put(actions.getUserResolve(user))

    const res = yield call(fetch, `/users/${action.id}`)
    const json = yield res.json()
    const next = res.ok ? actions.getUserResolve : actions.getUserReject
    yield put(next(json))
  }
}

/**
 * Export.
 */

export default users

Which by itself is not bad, but there are a series of things that make it tricky to understand what's going on coming fresh from Redux:

The concept of fork and others can be confusing.
Having to indirect things through call, apply, and cps makes things awkward.
The need to take and while (true) adds extra boilerplate, and requires learning the internals.
Using put is a new unfamiliar term, instead of dispatch.

I was thinking, if the above example is possible, it doesn't seem far off to get to something a little bit terser, with fewer new concepts to explain, and a bit more "Redux-like"...
import fetch from 'isomorphic-fetch'
import * as actions from '../actions'
import { createSaga, wrap } from 'redux'

/**
 * Wrap for testability.
 */

fetch = wrap(fetch)

/**
 * Get a user by `id`.
 *
 * @param {Object} action
 * @param {Store} store
 * @return {Object}
 */

function* get({ id }, { dispatch, getState }) {
  const state = getState()
  const user = state.api.users[id]
  if (user) return yield dispatch(actions.getUserResolve(user))

  const res = yield fetch(`/users/${id}`)
  const json = yield res.json()
  const next = res.ok ? actions.getUserResolve : actions.getUserReject
  yield dispatch(next(json))
}

/**
 * Export.
 */

export default createSaga({
  [actions.USER_GET]: get,
  [actions.USER_CREATE]: create,
  [actions.USER_UPDATE]: update,
  [actions.USER_REMOVE]: remove
})

The changes are basically:

Change call to be a transparent wrap helper instead, which is easy to add/remove.
Pass in store-like { dispatch, getState } for familiarity.
Allow for sugar with createSaga to remove boilerplate.

Which (I think?) gets it a lot closer to being simple to explain to newcomers—a way to have long-running processes observe specific actions and run async effects.
There's a chance I completely misunderstood how Sagas work, and something in there isn't possible. If so, feel free to close. But I figured I'd drop this here since others have been thinking about how to canonicalize async effects, and make them as simple as possible to integrate into the Redux mental model.

cc @yelouafi

Shouldn't this be on the redux-saga repo instead?
My two cents: I don't think there's ever going to be an official effects system for Redux. Namely because there are tradeoffs with every proposal so far. They're a getting really good, but some are better at certain things than others, so one choice might not be the best for all use cases. I'd rather have the "official" nature of a library come from its popularity and quality, rather than someone dictating what they should do. Basically, laissez-faire :smile:

I am leaning this way too. Up to the point where I'd create async-sagas, real-world-sagas examples just to show the difference in a approaches. That and an official recipe on using sagas as alternative async model could help IMO.

Shouldn't this be on the redux-saga repo instead?

Yes I think so
@ianstormtaylor using wrap(fetch) you should repeat this with every api service you call. call gives a generic way to do this.
initially I implemented all api calls as redux actions so you'd be dispatching effects as actions. It turned out that this solution wasn't really practical. Because you'd have also to create a custom action constant/action creators which is a lot of boilerplate (people are already complaining about the boilerplate of normal actions).
I used put because it sounded symmetrical to take. The lib is also inspired by [CSP] https://en.wikipedia.org/wiki/Communicating_sequential_processes. Using dispatch would put some confusion because w're not calling the dispatch function just creating an effect description (consider it like a shortcut to call(dispatch, action) so you don't have to worry about passing dispatch to your sagas).
as for createSaga, you're firing the control flow (Sagas) on each incoming action; redux-saga considers incoming actions themselves as part of the control flow. It allows to implement logic that spans accross a sequence of multiple actions.

They're a getting really good, but some are better at certain things than others, so one choice might not be the best for all use cases

@timdorr agree 100%. There is no one fit-all paradigm for all possible use cases. For some situations ELM like solutions like redux-loop seems more appropriate (esp. when there is 1-1 mapping between the state shape and effects). Some use cases are better handled by Reactive Streams like Rx.

Thanks for your input!

Thanks for replying @yelouafi! I'm aware of a few of the things you mentioned:

createSaga definitely isn't as feature-full as the top-level generator, that's why it's sugar. But for cases where you want to do things across actions, you'd want less of the sugar. You could imagine a case where createSaga(gen, gen, gen) would be one-level removed, firing for any action. And just regular *saga would be the current top-level with full functionality. Very similar to how combineReducers helps you eliminate boilerplate. It's not firing the control flow on each incoming action, it's composing the control flow from multiple more focused controlling functions.

wrap you have to use with every method, but it results in code that's readable instead of having to muddy up the source with call. You could still choose to call if you really wanted to, but most of the cases are for things like fetch or readFile, where just wrapping a few methods gets you the testability without having to make each invocation harder to parse.

I think that redux-saga as currently implemented, and evidenced by the real-world example, has way too much indirection for the common case, resulting in lots of boilerplate. Basically just trying to start conversations that aim to get rid of boilerplate, and move towards something that's actually useable without lots of configuration, but that's okay for it to not be here.

Just in case anyone was curious about this kinds of conveniences, here's the code to make the cleaned up example possible: https://gist.github.com/ianstormtaylor/84f3529e218d381a54cc


unable to merge dex error with Android Studio 3

When using  compile 'com.coinbase.android:coinbase-android-sdk:1.0.1' on Android Studio 3.0.1, I am getting error Unable to merge dex

Same issue, if you exclude the duplicate module then you get a runtime crash.

When using compile 'com.coinbase.android:coinbase-android-sdk:1.0.1' on Android Studio 3.0.1, I am getting error Unable to merge dex


Understand the HTML corpus

Research:

the different types of URLs we have
how many of those link to PDFs which represent the same document -> could we determine this for a page automatically?
how many of those are pages containing the policy text itself

Produce a dataset categorising all the HTML policies in the CCLW dataset.
Also look at the manually labelled CPD HTML dataset.

Completed HTML corpus analysis, identifying that ~50% of English language CCLW URLs with MIME type HTML are to documents which contain XML, plain text or PDF versions. We should consider writing structured data parsers for the top sources.
Write up and link to notebook in Notion.

Added stats for CPD based on the labelling challenge last summer. Just checking @chrisaballard that these stats make sense.

Hey team! Please add your planning poker estimate with ZenHub @eurolife @kdutia @opyate


cleanup fields

Closes #21
cc @zorbyte

oops, i always forget we have badges for feat lol

@zorbyte I've also added a Config struct that would be used in future to implement remote configs.

@zorbyte Updated.


How to execute async generator in Pool

Description
Hi, great library, thanks!
I want to run async generator in Process Pool using aiomultiprocess lib, how can I do that, any pointer. Currently I'm getting error like:
File "/home/rohankar/anaconda3/lib/python3.6/site-packages/aiomultiprocess/core.py", line 93, in __init__     raise ValueError(f"target must be coroutine function") ValueError: target must be coroutine function
Script that I tried;
import asyncio

async def ait(nr):
    for i in range(nr):
        await asyncio.sleep(0.1)
        yield i

from aiomultiprocess import Worker

async def main():
    # This Works
    # async for i in ait(10):
    #     print(i)

    # This throw error
    p = Worker(target=ait, args=(20,))
    p.start()
    print(await p)

loop = asyncio.get_event_loop()
loop.run_until_complete(main())

Details

OS: Ubuntu 18.04
Python version: 3.6
aiomultiprocess version: 0.5.0
Can you repro on master? didn't try
Can you repro in a clean virtualenv? didn't try

multiprocessing depends on "pickling" objects and return values between the parent and child processes, so any unit of work for the child process must be "pickleable". Generator objects are not currently pickleable in Python, so you can't pass a generator directly.  Also, in this case, you're passing the async generator function itself, which isn't actually a coroutine – it's a normal, synchronous function that immediately returns an async generator object when called.  Your example code is trying to send the async generator function (which itself can't be awaited), but wouldn't use it in any asynchronous way, and doesn't do anything to consume the generator object.
Maybe more specifically, you would want to do something like:
async def ait(nr):
    for i in range(nr):
        await asyncio.sleep(0.1)
        yield i

async def consume(nr):
    async for i in ait(nr):
        print(i)
    return nr

 async def main():
    p = Worker(target=consume, args=(20,))
    p.start()
    print(await p)


Fix autocast scope again

Sometimes in preprocessing layers our dtype is not a floating point dtype. In these cases we should never autocast, it would error immediately.

Done!


can i just invoke a function instead of push a button to copy a text.

Minimal example

Fork this JSFiddle and reproduce your issue.

Expected behaviour
I thought that by going to the page '...' and pressing the button '...' then '...' would happen.
Actual behaviour
Instead of '...', what I saw was that '...' happened instead.
Browsers affected
I tested on all major browsers and only IE 11 does not work.

hi,Zeno Rocha.
this project is great and very helpful. but after i read the code, i found that if i want to copy or cut, i have to click a button. can i just declare a function invoked it and passed the msg and then the copy is done.
im a new guy in JS and i realy dont know how to solve it. if you can tell me the possible way, it will be very greatful.

The basic JS method that this plugin relies on, document.execCommand(), requires that it be triggered by user interaction to prevent web pages from messing with the clipboard without the user's knowledge. This is a security feature and is enforced by every browser.
There is no way around this, but you can use JS to simulate a button click when you do something else. That "something else" must also be a user interaction though, but it can be as simple as the user focusing an element.

@joshuaptfan Thank you very much for guiding me. After i ask the question, I do try to simulate a button click event, and yes it worked. But it invoked the error callback, not the success. I dont know what did i miss.

Possibilities:

The first triggering event does not classify as a valid user interaction, so execCommand() failed due to security enforcement.
You "broke the link" between the valid triggering event and execCommand(), such that the browser does not associate the user interaction trigger with execCommand() for security enforcement.
Too much time passed between the triggering event and execCommand(), and it no longer counted as a "short-lived event". Very unlikely unless you're doing some serious computation creating this lag.
You used the plugin improperly. You can try your luck these pluginless methods that do the same thing.

Troubleshooting is easy using the console (press F12), it will tell you where the error happened and why.

thank you @joshuaptfan.
I used these methods that you provided, and i think this function "copyText(text)" is exactly what i need. But i still can not copy the text. I opend the console, there was nothing errors here, and the code was actually executed. I dont know if there is any way to track it.

Use breakpoints or console.log() to see if the code is really being executed, or if there are no errors because the code didn't run.
document.execCommand('copy') will do nothing if there is no text to copy. Make sure you are passing a string to copyText().

@joshuaptfan have you resolved your issue? Can this be closed?


Invalid route name

One should change the name of the route defined here.
At the moment it is impossible to use the plugin with the original Mibew Boilerplate. Also, the current name of the route is confusing.

ok, I'll change the route name

the current name of the route is confusing

Is there any suggestion? I'm not a professional developer.


[Feature Request] Contextual Popover ala Ghostnote

On MacOS there is a great app called Ghostnote.
Its primary function is to create hotkey-triggered popup notes that are document- & website-specific. So, for instance, you can trigger the hotkey on any given Microsoft Word document and have a dropdown note appear from the menu bar that is specific to that document and will reappear when triggered in the future.
Unfortunately the app is getting old; it appears not to have been updated for several years. And so far as I can tell, the lack of AppleScripting with Obsidian means that Ghostnote can't be "taught" how to recognize individual documents within Obsidian.
Your popovers remind me so much of the Ghostnote drop-downs that I wonder if they could be repurposed in the same fashion. Could the hover editor plugin be expanded such that it keeps a dedicated folder of "hover notes"—each uniquely associated with one other file—that can be triggered from the command palette or a hotkey? I don't know anything about coding, but perhaps this could be done by associating a hover note with the UID's generated by the Advanced URI plugin?
Something like Ghostnote is helpful because it allows me to keep instantly available notes about a particular document without modifying the document itself. I find Ghostnote useful, for instance, in reviewing a document with a coauthor so I can take to-do notes on our future edits to the document. Having the same feature available within Obsidian would be amazing.
Just a suggested feature, although perhaps it is too far beyond the function of the current Hover Editor to be an appropriate enhancement rather than a separate plugin entirely. The form of the Hover Editor just looked so much like Ghostnote that I thought it could potentially serve the same usecase within Obsidian.

Why not create your associated notes as notes that link to the note you want to associate them with?  Then, if you have the backlinks pane open (or use "backlinks in document" mode), you can just hover them.

Hotkey function! What you're suggesting definitely works (and is a good option, to be clear!) but what I loved about GhostNote was the on-demand "scratchpad" type note that could be triggered by a hotkey.
It was always the same note, associated with the same file, and openable with the press of a hotkey. Unfortunately, I can't get GhostNote to play nicely with Obsidian file identities—it just creates a single note for the app "Obsidian" rather than for specific files, which is what it does for Word, Excel, etc.
My thought was a hotkey-triggered "scratchpad" note, only one of which would exist in association with any particular "main" note. You'd hit the hotkey, the Hover Editor instance of the "scratchpad" note would open, and you'd have a place to keep a running "sticky note," so to speak, to jot down whatever is front-of-mind about the main note without incorporating that information into the main note itself.
I'm sorry for not being clearer in how I wrote the initial post. I was thinking less of multiple "notes" (that is, unique Obsidian .md files) in association with the target note, but rather of a single, hotkey triggered Hover Note that serves as a scratchpad and can be pulled up at any time without combing through menus or a pane of links.

And so far as I can tell, the lack of AppleScripting with Obsidian means that Ghostnote can't be "taught" how to recognize individual documents within Obsidian.

It just occurred to me (because I was looking to do something similar with Notezilla on Windows) that you might be able to use  the Custom Window Title plugin to make Ghostnote work, since it was actually written to integrate with other Mac apps that use the window title to obtain context.  If Ghostnote uses the window title, and you've configured the window title to include identifying info for the note, you would then be able to have your context notes.

This was a sharp catch. Unfortunately, Ghostnote seems to not automatically take stock of the Window Title, and the app's built-in script editor, which could perhaps allow me to program it to do so, crashes each time I try 😅
It seems like the universe just doesn't want me using Ghostnote for this purpose lol.
I still think it would be a terrific Hover Editor function, but I realize it's probably too much of a fringe use case to warrant the time investment right now.
Thanks again for making the Hover Editor—it works fantastically well, and it's extremely useful as is!


add docker, refactor JsonResponse in account and shop

#49 and #48 have done the docker things, closing it.


✨Whitelist HTTP Status Codes

Ability to select which status codes are considered "Online"
Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category
Feature
Overview
This allows services to accept more than 1 HTTP status code as "Online"
Issue Number (if applicable)
#219
New Vars (if applicable)
Status (Config) - Array of Strings
Screenshot (if applicable)
https://user-images.githubusercontent.com/39219859/173731204-74280a40-875b-4568-9fe6-508af7449877.mp4

The code is good but you are adding an option to every service in the menu and the config only to get a green light when an status code matches ?
To me it's like building a chainsaw to cut a stick.
I think this whole thing is way too overkill and does too much for how little the ping service integration is worth.
You could make it so these options are selectable at the ping module level by making them module options tho, it would apply to all services and wouldn't add too much complexity to the interface.
What do you think of a rework like that @LarveyOfficial ?
Plus do you see everyone adding manually all the http status codes they want on each service they have ?
( Keep in mind if you do this you will probably need my help because currently only string and boolean options are supported )

also you made your PR merge into Master…

also you made your PR merge into Master…

My bad, didn't double check before requesting.

The code is good but you are adding an option to every service in the menu and the config only to get a green light when an status code matches ?
To me it's like building a chainsaw to cut a stick.
I think this whole thing is way too overkill and does too much for how little the ping service integration is worth.
You could make it so these options are selectable at the ping module level by making them module options tho, it would apply to all services and wouldn't add too much complexity to the interface.
What do you think of a rework like that @LarveyOfficial ? Plus do you see everyone adding manually all the http status codes they want on each service they have ?
( Keep in mind if you do this you will probably need my help because currently only string and boolean options are supported )

I see what you are saying, and agree with most of your points, but still think it deserves to be though about.
Working on UptimeKuma integration (#200) might also be a good idea

This feature has been included in #229


Fix cmake-built libraylib.a to properly include GLFW's object files

I broke this in PR #3573 by accidentally removing too much
The examples still compiled fine so I didn't notice - my guess is that cmake was still adding a separate link to glfw manually.

@Peter0x44 ok, thanks for the review.


Peer Invalid Warning

Hi there. I was interested in checking out your project, but I ran into a problem when trying to install this with a basic, fresh install of NodeBB. As of this dependency change, your design is incompatible with nodebb-plugin-spam-be-gone and nodebb-theme-lavender which are pinned with NodeBB itself, and require nodebb-theme-vanilla < 1.0.0. Specifically, the error is:
npm ERR! peerinvalid The package nodebb-theme-vanilla does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
Would you consider bumping back down, or do you have any alternative suggestions?

@shortstuffsushi  What version of NodeBB are you using?

I am using 0.6.1, which I installed via npm, I believe. Just follow the docs on their site.

Uninstall nodebb-theme-material and
Install it from the admin control panel by going to Extend -> Plugins
or use
npm install<EMAIL_ADDRESS>

Sure, I've already done as much (using 0.0.9), but I was asking more about plans for the future, or how to handle potentially less technical users. The docs you have listed for this (npm install ...) won't work for a standard install at this point.

This happens with any theme for Nodebb, not just this one. nodebb-theme-lavender for example installs a specific version even though there is a latest version available in npm because it gets which version to install from package.json of your nodebb installation.
If you remove the dependency from package.json and run ( npm install nodebb-theme-lavender), you run in to the same issue.

Ah, the latest lavender does indeed use that later version of vanilla, which would cause the same problem. So how do any of these themes expect things to work then? You can't just do a clean npm install of the latest, are they perhaps running on a development version of NodeBB with a more recent version of vanilla?
In terms of suggestions, mine would be to keep your dependencies lined up with NodeBB -- unless I'm mistaken, 0.1.0 of your theme is unusable with a standard copy of NodeBB. I would only update to vanilla 1.0.0 after they have.

Updated installation instructions to install it from the plugins page in NodeBB ACP.

That'll work. Thanks :+1:


play called on null

I am geting this when try running the example:
The method 'play' was called on null.
Receiver: null
Tried calling: play()

after digging some more. Here is the debug screenshot. There is an issue in _fetchVideoURL().
parseAll = _allStringMatches(urls[1], RegExp("([^&,]*)[&,]"));
fails with the URL:
https%3A%2F%2Fr5---sn-4g5ednz7.googlevideo.com%2Fvideoplayback%3Fexpire%3D1572647605%26ei%3DVV68XdODCoHVgQfNrabYCA%26ip%3D<IP_ADDRESS>%26id%3Do-ABUrs8s4iKF-Afhtr2yiN4LGpTEm1Qpmp3oxcmMVuMfz%26itag%3D18%26source%3Dyoutube%26requiressl%3Dyes%26mm%3D31%252C29%26mn%3Dsn-4g5ednz7%252Csn-4g5e6nl7%26ms%3Dau%252Crdu%26mv%3Dm%26mvi%3D4%26pl%3D26%26initcwndbps%3D1150000%26mime%3Dvideo%252Fmp4%26gir%3Dyes%26clen%3D34221542%26ratebypass%3Dyes%26dur%3D569.051%26lmt%3D1540767188318662%26mt%3D1572625956%26fvip%3D6%26fexp%3D23842630%26c%3DWEB%26txp%3D5531432%26sparams%3Dexpire%252Cei%252Cip%252Cid%252Citag%252Csource%252Crequiressl%252Cmime%252Cgir%252Cclen%252Cratebypass%252Cdur%252Clmt%26sig%3DALgxI2wwRAIgA-rdN8L1gxIW4wB-PDtkbhoaANjacsACMkhfkUVTCDUCIFDT7Bt_IHxM6DrDUFnGFvDAAzr_oqiyLzpoV4lrZFS_%26lsparams%3Dmm%252Cmn%252Cms%252Cmv%252Cmvi%252Cpl%252Cinitcwndbps%26lsig%3DAHylml4wRAIgHnmd42bT6NwsqiWf-qr-N0nFpQ_LanF1jjBJvp_01-MCIA25W6oH11kOs5KEDg-s0wwiPcWCHU7lFVeACWqnwH0O\u0026quality=medium\u0026itag=18\u0026type=video%2Fmp4%3B+codecs%3D%22avc1.42001E%2C+mp4a.40.2%22"
And thus is not getting initialized and then play is called on null. There should be an error way before hitting the play button.

I experience the same problem. Seems to me that YouTube changed something so it affected everyone who tries to download their videos. Check this for example https://github.com/kkdai/youtube/issues/14

https://github.com/ja2375/FluTube/issues/22#issuecomment-568295302


Update Mocha link

Coverage remained the same at 100.0% when pulling 9c63d7ef8ac4ded7eb169c6b156b02e235462b42 on mortonfox:patch-1 into 238bdcf634bc0180f0ebf3b865a28e285a044294 on doc-metrix:master.


How to understand the meaning of the conv operations in the function "RenderHistorgramGaussian"?

hi，
@jonbarron, thanks for sharing the codes of the ffcc. I can't understand the meaning of the conv operations in the function "RenderHistorgramGaussian". The code is as follow,
% Threshold the mahalanobis distance at 3 to make a binary mask, which is
% dilated to produce an ellipse with a dot in the center.
mask = mahal_dist <= 3;
prediction = (conv2(double(mask), ones(3,3), 'same') > 0) & ~mask;
prediction = prediction | (conv2(double(mahal_dist == min(mahal_dist(:))), [0, 1, 0; 1, 1, 1; 0, 1, 0], 'same') > 0);

% Optionally create a mask with the ground-truth white point rendered as a dot.
if ~isempty(mu_true)
  D = (us - mu_true(1)).^2 + (vs - mu_true(2)).^2;
  truth = D == min(D(:));
  truth = (conv2(double(truth), [0, 1, 0; 1, 1, 1; 0, 1, 0], 'same') > 0);
  truth = (conv2(double(truth), [0, 1, 0; 1, 1, 1; 0, 1, 0], 'same') > 0);

I want to ask the questions,

What's the meaning of the function conv2(double(mask), ones(3,3), 'same') > 0)  ?
I can understand the formula about mahal_dist == min(mahal_dist(:) to get the ellipse of the minmum distance. However, i can't understand why to run the conv operation of the formula conv2(double(mahal_dist == min(mahal_dist(:))), [0, 1, 0; 1, 1, 1; 0, 1, 0], 'same') and why to chose the matrix [0, 1, 0; 1, 1, 1; 0, 1, 0] .
Why are the two same conv operations with conv2(double(truth), [0, 1, 0; 1, 1, 1; 0, 1, 0], 'same')  ?

Look forward to your favourable reply !
@jonbarron

This just dilates the mask, https://en.wikipedia.org/wiki/Dilation_(morphology). By dilating the mask and then removing the original mask, you get a boundary around the ellipse.
mahal_dist == min(mahal_dist(:) just makes a single pixel at the argmin, and then it's convolved by a plus shape to make a plus. This is just because I wanted a plus shape at the center.
Convolving by [0, 1, 0; 1, 1, 1; 0, 1, 0] twice just gives a nice diamond shape.
All of this code is just for visualizing the results, and isn't critical to the algorithm.

@jonbarron
I am very glad to receive your prompt reply! Thanks!


Updated validations.py python script

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Thanks! CLA signed


Fix omk login url

Solves #35 and replaces https://github.com/hotosm/OpenMapKitServer/pull/38

(I don't have write access, otherwise I'd merge.)


Specify node entry point script

can we have a patch release to npm containing this? Won't work with browserify properly otherwise.

I don't use browserify anymore (using webpack these days) so I'm not sure if I know this correctly. By node entry point script, do you mean "main" field in package.json? If that's not what you meant, would you like to create a PR?

Yes, I have test it and just adding the src/timeAgo.js to the main is enough to worked with browserify.

Updated package.json. Let me know if the problem persists.

I, yes I have check and he must be work, but, it missing the release on npm repo, because with browserify we used npm install angular-timeago for installing it.
Thank for your reactivity.

Oops, I missed npm publishing. Just published now.

everything is Ok, thanks for your work.


Run Line/Selection Not working

Environment data

VS Code version: 1.41.1
Extension version (available under the Extensions sidebar):  15,020,608
OS and version: Windows 10 Windows_NT x64 10.0.17763
Python version (& distribution if applicable, e.g. Anaconda): Anaconda / Python 3.7.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): CONDA
Relevant/affected Python packages and their versions: none
Jedi or Language Server? : Jedi

Expected behaviour
Python initialises and executes line of code
Actual behaviour
terminal runs command but python does not start, text is enter into the terminal but nothing happens ">>>" does not appear
(PythonEnv) C:\Python Projects_Projects\Py_BrowserAutomation>conda run -n PythonEnv python
import os
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Pressing Shift + Enter to execute Line or selection

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
No Output

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)
[Extension Host] Info Python Extension: 2020-01-09 13:13:48: Get Conda File from interpreter, Class name = b, completed in 2ms, Arg 1: "C:\\Users\\user\\.conda\\envs\\PythonEnv\\python.exe", Arg 2: "PythonEnv", Return Value: undefined

Couple of notes:
Running the Script through control shift enter works fine.

Python: Run Selection Line in Python Terminal also triggers this issue for me.

I have the same issue. Additionally, I can't run line/selection in terminal or Python Interactive Window
VS Code version: 1.41.1
Version: 2020.1.57204
OS and version: Windows 10 Windows x64 version 1803
Python version (& distribution if applicable, e.g. Anaconda): Anaconda / Python 3.7.3
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): CONDA
Relevant/affected Python packages and their versions: none
Jedi or Language Server? : Jedi

I can confirm that this works on
Name: Python
Id: ms-python.python
Description: Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.
Version: 2019.11.50794
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-python.python
can also confirm the setting terminal.integrated.inheritEnv set to true / false does not fix my issue

This is a dupe of #9439 which should be fixed shortly

me too


Flickering on scaled ultrawide monitor on M3 Pro Mac

Type: Bug
Random parts of the VS Code window flicker when typing / scrolling.
https://github.com/microsoft/vscode/assets/813661/f208c708-0c2f-429b-870c-b9a738dfa142
https://github.com/microsoft/vscode/assets/813661/4cb1e107-5b78-4747-8cd3-0d292bd40c73
https://github.com/microsoft/vscode/assets/813661/bd6d8993-6f25-4f2c-8bfc-bbd77f677d2a
Steps to Reproduce:

External screen with native resolution of 5120x2160 (Dell U4025QW)
Setup scaled resolution of 3840x1620. This is OS scaling, the monitor still reports a native resolution of 5120x2160.
Open VSCode with all extensions disabled, and default settings (json settings emptied).
Open several files side by side, optionally using "diff mode". The more visible editors, the more the error is likely to appear.

Note:

This is not linked to dark colors as described in other issues. (Issue occurs when OS is in light mode, with a light theme)
Scrolling while VS Code is not focussed does not trigger the issue
Happens both in full screen mode and non-fullscreen mode

Similar issues:

https://github.com/microsoft/vscode/issues/193908
https://github.com/microsoft/vscode/issues/165681

Workaround:

Disable HiDPI scaling in OS and use VS Code's window zoom. This affects all apps, making it not suitable.
Set "disable-hardware-acceleration": true, in  Preferences: Configure Runtime Arguments.

VS Code version: Code 1.90.2 (5437499feb04f7a586f677b155b039bc2b3669eb, 2024-06-18T22:54:35.075Z)
OS version: Darwin arm64 23.5.0
Modes:

System Info

Item
Value

CPUs
Apple M3 Pro (12 x 2400)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: disabled_softwarevideo_encode: disabled_softwarewebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: unavailable_software

Load (avg)
2, 2, 2

Memory (System)
36.00GB (0.30GB free)

Process Argv
--crash-reporter-id b9f963fa-db84-4aac-9a3d-85fa771e9805

Screen Reader
no

VM
0%

Extensions (28)

Extension
Author (truncated)
Version

lit-html
bie
1.11.1

vscode-tailwindcss
bra
0.12.3

npm-intellisense
chr
1.4.5

postcss
css
1.0.9

vscode-eslint
dba
3.0.10

eslint-disable-snippets
drK
1.4.1

gitlens
eam
15.1.0

EditorConfig
Edi
0.16.4

prettier-vscode
esb
10.4.0

vscode-firefox-debug
fir
2.9.10

vscode-jest-runner
fir
0.4.73

copilot
Git
1.208.0

copilot-chat
Git
0.16.1

copy-github-url
mat
0.14.0

import-sorter
mik
3.3.1

dotenv
mik
1.0.1

ecdc
mit
1.8.0

hexeditor
ms-
1.10.0

sublime-keybindings
ms-
4.1.10

vscode-typescript-next
ms-
5.6.20240701

one-dark-theme
msk
1.14.2

material-icon-theme
PKi
5.4.2

rewrap
stk
17.8.0

code-spell-checker
str
3.0.1

sort-lines
Tyr
1.11.0

highlight-bad-chars
wen
0.0.6

change-case
wma
1.0.0

markdown-all-in-one
yzh
3.6.2

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
jchc7451:31067544
chatpanelc:31048052
dsvsc021:30996838
g316j359:31013175
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
newcmakeconfigv2:31071590
impr_priority:31082723

Tried on https://vscode.dev on the same project, but the flickering did not happen there:
https://github.com/microsoft/vscode/assets/813661/1c7006f6-626b-4fff-b915-53292c372836

Also, opening more panels seem to make the issue worse but it also happens when only one file is open:
https://github.com/microsoft/vscode/assets/813661/9df8d898-c142-47f1-bba3-c2aaf3d60ff5

The issue appears to be linked to the resolution of the window and, in my setup, happens significantly more when the window goes above approx 6200x3192. Note that the window resolution is significantly higher than my screen resolution (5120x2160) probably because of apple's HiDPI feature.

Having the same issue under the same conditions: M3 Pro Mac, full screen editor windows. It helps to manually zoom the VSCode instance but it's non-deterministic.

Can you confirm if the issue persists with latest stable, if it does please share the following outputs

chrome://gpu from your chrome browser
Developer: Show GPU info from VSCode


Create a good readme for the project.

Good Readme file to pr to be merged

@ashavijit I would like to work on this. Can you tell me what things should be in the README.md ?

@Abhirv08 okk

I have created a readme file for this repo can you assign me this issue 😄


restarts are failing

have been for about 5 days.  issue already open for ruby gem https://github.com/travis-ci/travis.rb/issues/417

fixed, I think, but now having authentication issues, still not working


The paper address

Sorry for interputing you. Do you have the arxiv version of this paper？

Sorry for the late response.
The paper is currently in revision for publishing, but the following paper also provides technical context:
https://www.mdpi.com/1424-8220/22/1/210


[$500] Private notes - Note editor opens instead of list for user with existing private notes

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.6-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/31344
Action Performed:
Precondition: There is a chat with some content in the Privates notes and the note is not visited before. If visited, please log out and log in again

Go to staging.new.expensify.com
Open the chat from the precondition
Click on the header
Click Private notes

Expected Result:
User is navigated to private note list screen
Actual Result:
User is navigated to private note editor instead of private note list screen
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f5c6ab80-2132-417a-b48d-9f54941681c7
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b1540c07c23a34c8
Upwork Job ID:<PHONE_NUMBER>515441664
Last Price Increase: 2023-11-30

@lanitochka17, can you elaborate what you mean by this,

Open the chat from the precondition

whats do you mean by precondition?
Also i tested the private notes on a DM and a group chat and it seemed to work fine for me on staging chrome. Can you double check?
Meanwhile I'll ping the authors of https://github.com/Expensify/App/pull/31344 to double check as well.

Asked authors in slack here
Asked QA here.

I don't see any issue so I've asked others to confirm. If the issue does infact persist we can revert https://github.com/Expensify/App/pull/31344 but i'd like to confirm it first before reverting.

i removed the job posting from upwork because it was created by accident, this issue is about fixing a logic with a very recent PR.

I am working on it

Found a possible regression whilst testing for https://github.com/Expensify/App/pull/31257. If you go offline before the GetReportPrivateNote request completes, the notes page still loads but is always empty (even when there are notes saved).

@jjcoffee

the notes page still loads but is always empty

What is the "notes page" that you mentioned? (Currently, we have two  page, "notes list" page and "notes edit" page

Apologies, forgot to attach a video. It's the notes list page (I think), but we get navigated to the edit page (incorrectly):
https://github.com/Expensify/App/assets/27287420/280c3991-4896-467c-9810-8a7dd5a1bcc7

@jjcoffee

Do you have any suggestions in this case? Because if the getReportPrivateNote is not called successfully, we will navigate user to edit note page as expected.
My suggestion is that, BE will return the private note data when in the OpenReport API.

@jjcoffee Can you help check this one https://github.com/Expensify/App/issues/32302#issuecomment-1857599642 once you have a chance

Issue not reproducible during KI retests. (First week)

@DylanDylann I'm not sure I fully understand your comment or if you are proposing a particular solution, but I think it's up to the C+ on this issue to handle regressions. cc @ArekChr

@jjcoffee Maybe @ArekChr is not available

QA, for retesting, here's a vid example
https://github.com/Expensify/App/issues/32302#issuecomment-1857581195
@shubham1206agra , yes, I'll assign you as C+ if the bug persists after more testing.  Did you try to reproduce?


Animation in Loading page.

Three dots on the loading page can be animated for a more appealing appearance.

I'm taking this issue.

@zulipbot claim


Allowed Syntax differs from Specification

Describe the bug
See discussion here: https://github.com/ehn-dcc-development/dgc-business-rules/issues/67
In order to avoid different behaviour on Android/iOS I would suggest aligning one or the other library (or as it seems the iOS implementation here).
I'm not sure, how this is best achieved. The obvious chose would be to just fix the two issues with var and !.

@ubamrein do you think this issue should be still open? Or can I close it? The related discussion is closed.


Clean up invalid Host Applications

Follow up from https://github.com/opencollective/opencollective-api/pull/9324#issuecomment-1709956578.
The model check in https://github.com/opencollective/opencollective-api/blob/main/checks/model/hosted-collectives.js#L45 will fix those host applications that are still PENDING when the Collective was approved to the host.
We should also consider deleting applications where the Collective's HostApplicationId does not match what is in the host application, as you can only apply to one host at a time and that a new application will immediately change the Collective's HostApplicationId.

@gustavlrsn should we close this issue?

@znarf the model check in https://github.com/opencollective/opencollective-api/blob/main/checks/model/hosted-collectives.js#L45 will fix those host applications that are still PENDING when the Collective was approved to the host.
The follow up was to also consider deleting applications where the associated Collective's HostCollectiveId does not match the application's HostCollectiveId.
I've updated the issue description.


Replace ray-default with necessary submodules

Issue #, if available:
Description of changes:
ray-default installs NodeJS as a dependency while we are not really making use of the UI component of Ray in AutoGluon. By removing NodeJS, we could help reduce AutoGluon's surface area in services which has AG as a dependency.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can you provide a description for why this change is being made?

Can you provide a description for why this change is being made?

I have updated the description for the PR.

It looks like there is no way to get around ray-default in conda build since one of our required submodules ray-tune ( https://github.com/autogluon/autogluon/blob/ea7b4fba7695a5a09deafb10fd8d034fb2265916/core/src/autogluon/core/hpo/ray_hpo.py#L15would) requires ray-default (https://github.com/conda-forge/ray-packages-feedstock/blob/94f217b781ea4c1c606c169f9e6eb47cdeb0ff27/recipe/meta.yaml#L256)


{{ProjectId}} template placeholder

Hi. Placeholder {{projectId}} conflicts with some static site generators which use this pattern for replacing placeholders by variable values. Can you change this pattern on some other, for example on [[projectId]]?

Hi, can you please elaborate more on the issue that you are getting and what static site generator you use so we can reproduce?

Used server is jekyll
Before launching all files combined into one file app.js using tool browserify
When server is launched, it processes file app.js. And as the file includes all files from your sdk which use this pattern for preparing paths to resources, as a result this placeholders are replaced on value projectId. For example before was: var pathCartBase = '/hybris/cart/v1/{{projectId}}/carts' after became var pathCartBase = '/hybris/cart/v1/projectId/carts';
As a result base path cannot be prepared when a request helper tries to make request

For solving this problem I need to customize and keep your library out of node modules

I would suggest if we change things here, then we should use template literals.
I'm fine bringing such a change into master, if you can send us a PR.

Maybe this is not the best time for adding this feature using template literals, because if it would be done, users who use your SDK have to update their javascript tools to the latest version for supporting ES6. For example popular uglify tool is not able to parse source code which contains template literals, I got the next error:
WARN: ERROR: Unexpected character '`' [-:3715,19]
../node_modules/uglify-js2/lib/parse.js:199
    throw new JS_Parse_Error(message, line, col, pos);
    ^
Error
    at new JS_Parse_Error (../node_modules/uglify-js2/lib/parse.js:185:18)
    at js_error (../node_modules/uglify-js2/lib/parse.js:199:11)
    at parse_error (../node_modules/uglify-js2/lib/parse.js:291:9)
    at Object.next_token [as input] (/mnt/ssd/expbag5/bag/front/node_modules/uglify-js2/lib/parse.js:523:9)
    at next (../node_modules/uglify-js2/lib/parse.js:616:25)
    at vardefs (../node_modules/uglify-js2/lib/parse.js:1015:48)
    at var_ (../node_modules/uglify-js2/lib/parse.js:1028:27)
    at ../node_modules/uglify-js2/lib/parse.js:788:30
    at ../node_modules/uglify-js2/lib/parse.js:677:24
    at block_ (../node_modules/uglify-js2/lib/parse.js:935:20)

And there is other reason which makes a difficult to use template literals, currently the place, where base path is declared, does not contain project Id but for using literals templates you have to declare this template in the same place where variables are defined, in our case it is projectId.


Pass autostart and out of process from cmake

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Determine plugin behavior for unauthorized users

Also, determine behavior for users who don't have access to editing board widgets


Hello there msg

Please do not actually merge this!!!

Current coverage is 97.67% (diff: 100%)

Merging #44 into master will not change coverage

@@             master        #44   diff @@
==========================================
  Files             8          8
  Lines          1849       1849
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1806       1806
  Misses           43         43
  Partials          0          0

Powered by Codecov. Last update ada3e7d...7d60ef2


[pt-br] Broken links due to using "githubbranch" param

This is a Bug Report
Problem:
Regarding https://github.com/kubernetes/website/issues/31248, I found the similar broken links on other pages.
English pages have already been fixed. ref: https://github.com/kubernetes/website/pull/29311
pt pages also need to be fixed.
Proposed Solution:
Fixes broken links including {{< param "githubbranch" >}} to master.
In the case of link to https://releases.k8s.io/, fixes to {{< param "fullversion" >}}.
ref: https://github.com/kubernetes/website/pull/29311#discussion_r685845250

/assign


Separate the building of the Artemis image from the EnMasse code base

Currently, the EnMasse build cycle creates an Artemis image based on the Apache Artemis tgz.  This is done as there is no Artemis image published by the Apache project.
As this image changes infrequently, the repetitive work is superfluous and slows the build/test cycle of the developers.
It would be better if we moved production of the image to a separate project beneath https://github.com/EnMasseProject/ in a similar way as to what already done for enmasse/qdrouterd-base by https://github.com/EnMasseProject/router-docker-base.
I see we started down this path before, https://github.com/EnMasseProject/artemis-docker-base, so I propose to re-use the existing project as its home.  @dejanb @lulf thoughts?

Fully agreed

Image build now -> https://github.com/EnMasseProject/artemis-docker-base/pull/1


Differentiate between types of search results.

This PR caters for the three different types of search results, and allows the user to test for each based on the format of musicToken.

Released as 1.7.2


stage1: Rustify stage1 and update IGVM VTOM on TDP platforms

Move stage1/*.S to a Rust crate. This allows for better interfacing with other crates and reduces hard-coding and chances of breakage.
Update IgvmParamBlock.vtom in addition to Stage2LaunchInfo.vtom during IGVM boot. It ensures Stage2 & the SVSM kernel can use VTOM as expected.

This fails CI as stage1/stage1.o and stage1/reset.o no longer exist.

Hi Peter,
I like this change, it will simplify the build process and allows more sharing of constants and code between the different stages.
Can you please adapt the CI files to make it pass with these changes and have a look at using the existing x86-64-unknown-none target? I tried that already but ran into linker errors due to 32-bit relocations in 64-bit code. But maybe there is a way around that.

Hi Joerg, I sidestepped the ld issue on the CI system using --emit=obj -C linker=/usr/bin/true. It should work as expected now.


docs: teaseing with an image

Help people to want to click on the documentation website
Made with https://carbon.now.sh
Code:
#!/usr/bin/env kotlin
// .github/workflows/github-action.main.kts

@file:DependsOn("it.krzeminski:github-actions-kotlin-dsl:VERSION")

workflow(
    name = "GitHub Action workflow - but YAML free 🎉",
    on = listOf(Push()),
    sourceFile = __FILE__.toPath(),
) {
    job(id = "my_job", runsOn = RunnerType.UbuntuLatest) {
        uses(name = "Check out",      action = CheckoutV3() )
        run( name = "Print greeting", command = "echo Hello world" )
    }
}.writeToFile()

I guess you meant
#.github/workflows/github-action.main.kts

in the second line :)

right, I wrote a bash script today  :)

I don't see a setting for transparent background on https://carbon.now.sh/

I don't see a setting for transparent background on https://carbon.now.sh/

I think I found it!

Could you try it out? I'm on mobile.

done but that's only for the margin, the code background is still in black

Thanks! :tada:


Support for Shanghai / Solidity 0.8.20

Tangentially related to other issues, but as an old version of revm is used, the PUSH0 opcode introduced in Shanghai will always cause a revert, meaning that anything compiled with 0.8.20 won't run in the simulator.

Indeed, now it makes sense why all my contract transactions got reverted without any apparent reason !
Tried with an older contract deployment using 0.8.0 and worked well


Fix broken link

Changes in this pull request
Added missing URL to link to try to fix doc build.  Made a couple other trivial formatting changes in Supported Formats table while I was at it.
Checklist

[x] This PR represents a single feature, fix, or change.
[x] All applicable changes have been documented.
[x] Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Codecov Report

Merging #118 (2fc39ce) into main (f04b856) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   77.38%   77.38%
=======================================
  Files           3        3
  Lines         367      367
=======================================
  Hits          284      284
  Misses         83       83

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


To push the current branch and set the remote as upstream, use

    git push --set-upstream origin feature/something

If the bug only appears with a specific application, the output of that application and its version:
same

Anything else you think is relevant:
> git push
fatal: The current branch feature/something has no upstream branch.
 RTM:

git_push – adds --set-upstream origin $branch to previous failed git push;


fix(vue3): Fix vue3 components remounting every time a key is added to state

The codespell error is unrelated to this PR, it has to do with a typo in another commit message that ended up in the changelog

Can you trigger an event with {type: "new-keys", keys: [...] }. It won't be use right now, but could be useful down the road.

Added the new-keys event, and actually refactored the fix to use it in TrameTemplate.js

Commit message should be fix(vue3): prevent remounting when keys are added
No upper case after :

you can also edit the codespell check on the changelog


Support cheap and large size data storage in EOS

This is not an actionable suggestion.
If you have an actionable plan, like
"Implement ROCKS database storage solution on EOS" and can lay out some steps to get that into the picture, it could be accepted. As is, this isn't actionable, and I can't accept it into the repo. Plus, there's a lot of grammar and spelling errors in here.


feat: add streaming endpoint which returns events according to metadata value

User request: support use-cases where the workflow run ids aren't known (for example, in a separate long-lived streaming endpoint). In this case we'd like to get all stream events corresponding to a metadata tag.

It would be good to be able to use the same parameters used to get a list of workflow runs for this feature


[KeyVault-Certificates] API alignment

Some notes and questions (if you see something marked as “Done” that doesn’t show anything in the changes of this PR, it’s because the fix already exists in master):

Jonathan's branch wasn't up to date with master, but I took inspiration from the work he did!
create certificate should return GetCertificateWithPolicy Done.
get certificate should return GetCertificateWithPolicy, getCertificate already returns CertificateWithPolicy. I marked it as done.
updateCertificate should be updateCertificateProperties. Done.
updateCertificateProperties receives the certificate's name, the certificate's version and the options bag, which aligns with keys and secrets for us. I asked about this and confirmed that this is correct.
updateCertificatePolicy should receive a param named policy (of type CertificatePolicy). Done
beginDeleteCertificate, can the return type be any cleaner? --- https://github.com/Azure/azure-sdk-for-js/issues/6315.
backupCertificate, match what keys and secrets do for the result type. Made it Uint8Array | undefined, like how it is in keys and secrets.
restoreCertificateBackup certificateBackup should be backup. match keys and secrets Should return GetCertificateWithPolicy. Done.
listPropertiesOfCertificateVersions should not have includePending in its option bags. Done.
createIssuer, flatten credentials accountId and password into options bag. get rid of current type that holds these. Done.
deleteCertificateOperation name to certificateName. Done.
All CertificateContacts to CertificateContact[]. Done.
importCertificate take in the bytes instead of a base 64 encoded string. Done.
KeyVaultCertificate, remove content type. Done.
CertificateOperation is missing CertificateTransparency: We're using the generated CertificateOperation, which has certificateTransparency inside of issuerParameters. certificateTransparency is also at the root level of CertificatePolicy already. The generated version of CertificatePolicy also has issuerParameters, and we're flattening it for the public type. I wonder if we should do it. CertificateTransparency only exists as part of CertificatePolicy in .Net, as in, CertificateOperation doesn't have this property in .Net (at least I don't see it).
CertificateOperationError: create and operation pollers now set the state error to the operation error.
CertificatePolicy's certificateType must be string enum, and it must be exported. Done.
CertificateContentType, investigate why content type is "application/pem". Not doing this in this PR.
CertificiatePolicyAction is missing. It's not, in .Net, CertificiatePolicyAction belongs to LifetimeAction, which belongs to CertificatePolicy. The same happens in TS/JS: Action (which comes from the generated code) exists in LifetimeAction, which exists in CertificatePolicy.
LifeTimeAction, splat Trigger, rename Action to CertificatePolicyAction. Done.
rename JsonWebKeyType to KeyType only if it was already renamed elsewhere. This is as required already.
Remove "oct". Done.
ImportCertificateOptions,  double check the type it's extending from. It was extending from CertificateProperties…. Which was missing the CertificatePolicy! Oops. Fixed now.
WellKnownIssuer -> WellKnownIssuerNames. Done.
emailAddress -> email. Done in both AdministratorContact and CertificateIssuer.
CertificateIssuer: split IssuerProperties into CertificateIssuer. What is the action item here? Our CertificateIssuer has properties, of type CertificateIssuerProperties. This properties type has three properties: id, name, provider. We have a copy of these (id and name) in CertificateIssuer, but not provider. Same as .Net. I believe there's no action item here.

All samples and comments should be updated, but they should be revisited (probably after code complete).
Fixes #6291
No tests needed to be re-recorded. Unit tests and integration tests for node and the browser have all passed.

Unit tests and integration tests for node and the browser have all passed.

@heaths and all - sorry for the confusion, we've actually got two different PRs we're working on, and we're working to consolidate. Please consider this one a DRAFT.

Closing this PR on favor of #6334


Problem using https on IOS devices (Safari browser)

When you turn on the https protocol on IOS devices, the web page does not appear. Letsencrypt certificate used. Apache server. In other browsers (Opera, Firefox, MS Edge) the secure connection works without problems.

Can't seem to replicate. I used these hosts on my iPhone every day.

I've fo
Just set into Custom Nginx Configuration:
 proxy_hide_header Upgrade;

Full list of useful configs:
proxy_hide_header Upgrade;
proxy_hide_header X-Powered-By;
add_header Content-Security-Policy "upgrade-insecure-requests";
add_header X-Frame-Options "SAMEORIGIN";
add_header X-XSS-Protection "1; mode=block" always;
add_header X-Content-Type-Options "nosniff" always;
add_header Cache-Control "no-transform" always;
add_header Referrer-Policy no-referrer always;
add_header X-Robots-Tag none;

I can’t replicate the issue too.

What's your httpd server behind proxy? What's configuration you using?
In my case it's:

Apache version 2.4.46. behind proxy
Scheme: https -> https (self-signed, server cert behind proxy and Let's encrypt on front from NPM)
x-Frame-Option  set in in proxy and in apache config (where <IP_ADDRESS> is my proxy server IP):

RemoteIPHeader X-Forwarded-For
RemoteIPTrustedProxy <IP_ADDRESS>

proxy_hide_header Upgrade;
proxy_hide_header X-Powered-By;
add_header Content-Security-Policy "upgrade-insecure-requests";
add_header X-Frame-Options "SAMEORIGIN";
add_header X-XSS-Protection "1; mode=block" always;
add_header X-Content-Type-Options "nosniff" always;
add_header Cache-Control "no-transform" always;
add_header Referrer-Policy no-referrer always;
add_header X-Robots-Tag none;

That worked for me thanks

Thanks a lot, this fix worked perfectly for me too!

I've faced similar issue too. To fix just set into Custom Nginx Configuration:
 proxy_hide_header Upgrade;

Full list of useful configs:
proxy_hide_header Upgrade;
proxy_hide_header X-Powered-By;
add_header Content-Security-Policy "upgrade-insecure-requests";
add_header X-Frame-Options "SAMEORIGIN";
add_header X-XSS-Protection "1; mode=block" always;
add_header X-Content-Type-Options "nosniff" always;
add_header Cache-Control "no-transform" always;
add_header Referrer-Policy no-referrer always;
add_header X-Robots-Tag none;

I think this issue can be closed now? Let me know if I my assumption is wrong.

Can anyone offer some insight into why this happens and what the fix does? Is this something that would happen on any nginx setup?

It seems to be an nginx issue, so yes, it would happen on any nginx setup. See the nginx issue or an explanation on serverfault

It worked for me, thanks a lot for your help, many hours couldn't figure out what the problem was

I meet error the css and javascript doesn't loading on Safari but Chrome is ok

I'm running a React JS application on an Nginx server (Ubuntu 22.04) and encountering problems with video playback on iOS devices. The videos play correctly on other platforms.


Accelerate ROIPooling layer

Description
As title. The major changes in implementation:

Use index_t to store max_idx,  avoiding possible value change when casting int to float.
Remove assert in code, fix a bug in processing invalid box
Store global index of input data blob in max_idx to simplify grad accumulation in backward pass.

Benchmarking script
import mxnet as mx
import numpy as np
np.random.seed(0)
import time

batch_size = 4
channel = 16
height = 256
width = 256
n_rois = 500
pooled_size = (5, 5)

def test(ctx, tries=5):
    s = 0.
    for idx in xrange(tries + 1):
        x = np.random.random((batch_size, channel, height, width))
        y = np.zeros((n_rois, 5))
        y[:, 0] += np.floor(np.random.random((n_rois)) * batch_size)
        y[:, 1] += np.random.random((n_rois)) * width
        y[:, 2] += np.random.random((n_rois)) * height
        y[:, 3] += np.minimum(y[:, 1] + np.random.random((n_rois)) * width, width)
        y[:, 4] += np.minimum(y[:, 2] + np.random.random((n_rois)) * height, height)

        with ctx:
            x = mx.nd.array(x)
            y = mx.nd.array(y)
            mx.nd.waitall()
            start = time.time()
            with mx.autograd.record():
                x.attach_grad()
                r = mx.nd.ROIPooling(data=x, rois=y,
                                     spatial_scale=1,
                                     pooled_size=pooled_size)
                r.backward(mx.nd.ones_like(r))
            mx.nd.waitall()
            if idx > 0:
                s += time.time() - start
    print 'time: {} s on {}'.format(s / tries, ctx)

if __name__ == '__main__':
    test(mx.cpu())
    test(mx.gpu())

Result
Before:
time: 13.2959038258 s on cpu(0)
time: 0.0346892356873 s on gpu(0)

After:
time: 0.6734582901 s on cpu(0)
time: 0.0038733959198 s on gpu(0)

Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-label-bot add [pr-awaiting-review]

@arcadiaphy Thanks for your contribution!
@sxjscience , @KellenSunderland Could you please review this PR? Thanks!

@sxjscience @KellenSunderland Gentle ping...

@mxnet-label-bot add [Operator]

@sxjscience @KellenSunderland
Could you please help take a review? Thank you!

I think it should be good. One concern is it may be backward incompatible due to the atomicAdd. Although I feel it's reasonable to use the faster version, I need to confirm with the GluonCV team whether it will break the current training scripts.

Would be nice to apply to ROIAlign similarly since GluonCV have transitioned to use ROIAlign in recent networks.

This is great, is the performance increase only due to type changes as in the description?

@larroy I think the main reason is that the indices of the maximum numbers are saved in this PR.

LGTM.  Many thanks for the speedup / refactor.


Processing Messages

Curious here as to why on user commands your doing;
elseif ($message_text === $this->bot_config['giveaway_join_keyword'])
and
elseif ($words_in_message_text[0] === $this->bot_config['quote_keyword'])
I have noticed some commands are not being picked up and I am wondering if its because of the way it processes user messages. All Admin commands are using '$words_in_message_text[0]' and SOME user commands are using $words_in_message_text[0] some are using $message_text.
So the question is why use message_text and not the first element of the array? Only my admin users can place bets, regular users cannot for some weird reason. It has trouble picking them up. So I can't find why this isn't processing them correctly and this is the only thing I cant think of.

hi and thanks for pointing that out!
it seems the bet_place_keyword for regular users was buggy - too much copy-paste from the neighboring if-else loops.
you are right, that i am using different condition each time, it depends on if the in question command is expected to have more than words, but i guess you figured it out.
i patched it now, but if you fell into any other issues, plz do let me know.
cheers!

No problem. I actually replaced them all with $words_in_message_text[0] and it seems to be working perfect now.
My real question is if this can handle thousands of concurrent requests (For betting in particular)?

unfortunately, i cant answer that. the loop will parse all the messages it receives in each loop, i wouldnt expect it to have a problem, but cant say it ..
in line 400 of IzyBot.php, there is a sleep(1) (i.e 1 second interval). if you are having a really high traffic, i would decrease that value to a smaller one. maybe set it to usleep(300000);.
but i guess you would see some errors if your load is that much PHP cannot handle them.


Added ability to run segmentation inference module in the test data without or partial ground truth files.

Addressing issue #459: ability to run segmentation model inference on datasets without or partial segmentation files.

Hello @asantamariapang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file InnerEye/ML/config.py:

Line 492:80: E501 line too long (113 > 79 characters)
Line 493:80: E501 line too long (81 > 79 characters)
Line 777:80: E501 line too long (92 > 79 characters)

In the file InnerEye/ML/dataset/full_image_dataset.py:

Line 216:80: E501 line too long (82 > 79 characters)
Line 255:80: E501 line too long (118 > 79 characters)
Line 265:80: E501 line too long (88 > 79 characters)
Line 273:80: E501 line too long (110 > 79 characters)
Line 275:80: E501 line too long (107 > 79 characters)
Line 276:80: E501 line too long (107 > 79 characters)
Line 282:80: E501 line too long (116 > 79 characters)
Line 313:80: E501 line too long (99 > 79 characters)
Line 324:80: E501 line too long (116 > 79 characters)
Line 325:80: E501 line too long (85 > 79 characters)
Line 343:80: E501 line too long (120 > 79 characters)
Line 349:80: E501 line too long (115 > 79 characters)
Line 355:80: E501 line too long (109 > 79 characters)
Line 367:80: E501 line too long (93 > 79 characters)
Line 368:80: E501 line too long (107 > 79 characters)
Line 370:80: E501 line too long (107 > 79 characters)
Line 371:80: E501 line too long (114 > 79 characters)

In the file InnerEye/ML/dataset/sample.py:

Line 147:80: E501 line too long (91 > 79 characters)

In the file InnerEye/ML/metrics.py:

Line 234:80: E501 line too long (101 > 79 characters)
Line 237:80: E501 line too long (84 > 79 characters)
Line 247:80: E501 line too long (107 > 79 characters)
Line 249:80: E501 line too long (82 > 79 characters)
Line 250:80: E501 line too long (105 > 79 characters)
Line 252:80: E501 line too long (84 > 79 characters)
Line 263:80: E501 line too long (105 > 79 characters)

In the file InnerEye/ML/model_testing.py:

Line 28:80: E501 line too long (117 > 79 characters)
Line 86:80: E501 line too long (108 > 79 characters)
Line 87:80: E501 line too long (107 > 79 characters)
Line 97:80: E501 line too long (106 > 79 characters)
Line 102:80: E501 line too long (87 > 79 characters)
Line 114:80: E501 line too long (92 > 79 characters)
Line 116:80: E501 line too long (89 > 79 characters)
Line 130:80: E501 line too long (84 > 79 characters)
Line 186:80: E501 line too long (80 > 79 characters)
Line 188:80: E501 line too long (115 > 79 characters)
Line 238:80: E501 line too long (80 > 79 characters)
Line 239:80: E501 line too long (91 > 79 characters)
Line 242:80: E501 line too long (96 > 79 characters)
Line 244:80: E501 line too long (91 > 79 characters)
Line 245:80: E501 line too long (88 > 79 characters)
Line 249:80: E501 line too long (80 > 79 characters)
Line 250:80: E501 line too long (82 > 79 characters)
Line 252:80: E501 line too long (83 > 79 characters)
Line 255:80: E501 line too long (104 > 79 characters)
Line 256:80: E501 line too long (110 > 79 characters)
Line 257:80: E501 line too long (118 > 79 characters)

In the file InnerEye/ML/utils/dataset_util.py:

Line 204:80: E501 line too long (83 > 79 characters)

In the file InnerEye/ML/utils/io_util.py:

Line 415:80: E501 line too long (103 > 79 characters)
Line 416:80: E501 line too long (91 > 79 characters)
Line 423:80: E501 line too long (92 > 79 characters)
Line 436:80: E501 line too long (85 > 79 characters)
Line 439:80: E501 line too long (82 > 79 characters)
Line 441:80: E501 line too long (83 > 79 characters)
Line 444:80: E501 line too long (92 > 79 characters)
Line 448:80: E501 line too long (91 > 79 characters)
Line 449:80: E501 line too long (104 > 79 characters)
Line 450:80: E501 line too long (111 > 79 characters)
Line 523:80: E501 line too long (120 > 79 characters)

In the file InnerEye/ML/utils/metrics_util.py:

Line 39:80: E501 line too long (116 > 79 characters)
Line 66:80: E501 line too long (101 > 79 characters)
Line 72:80: E501 line too long (104 > 79 characters)
Line 81:80: E501 line too long (92 > 79 characters)
Line 90:80: E501 line too long (84 > 79 characters)
Line 91:80: E501 line too long (113 > 79 characters)
Line 121:80: E501 line too long (102 > 79 characters)

In the file Tests/ML/configs/DummyModel.py:

Line 72:80: E501 line too long (95 > 79 characters)
Line 73:80: E501 line too long (93 > 79 characters)
Line 74:80: E501 line too long (91 > 79 characters)

In the file Tests/ML/pipelines/test_inference.py:

Line 27:80: E501 line too long (114 > 79 characters)
Line 210:80: E501 line too long (112 > 79 characters)
Line 218:80: E501 line too long (97 > 79 characters)
Line 219:80: E501 line too long (82 > 79 characters)
Line 220:80: E501 line too long (80 > 79 characters)
Line 239:80: E501 line too long (113 > 79 characters)
Line 259:80: E501 line too long (90 > 79 characters)
Line 264:80: E501 line too long (90 > 79 characters)
Line 265:80: E501 line too long (92 > 79 characters)
Line 272:80: E501 line too long (97 > 79 characters)
Line 278:80: E501 line too long (80 > 79 characters)
Line 311:80: E501 line too long (97 > 79 characters)
Line 312:80: E501 line too long (99 > 79 characters)
Line 315:80: E501 line too long (90 > 79 characters)
Line 321:80: E501 line too long (90 > 79 characters)
Line 326:80: E501 line too long (87 > 79 characters)
Line 329:80: E501 line too long (99 > 79 characters)
Line 330:80: E501 line too long (101 > 79 characters)
Line 332:80: E501 line too long (96 > 79 characters)
Line 338:80: E501 line too long (81 > 79 characters)

In the file Tests/ML/test_model_testing.py:

Line 12:80: E501 line too long (92 > 79 characters)
Line 29:80: E501 line too long (102 > 79 characters)
Line 30:80: E501 line too long (109 > 79 characters)
Line 36:80: E501 line too long (96 > 79 characters)
Line 51:80: E501 line too long (96 > 79 characters)
Line 73:80: E501 line too long (143 > 79 characters)
Line 75:80: E501 line too long (116 > 79 characters)
Line 80:80: E501 line too long (92 > 79 characters)
Line 83:80: E501 line too long (88 > 79 characters)
Line 96:80: E501 line too long (118 > 79 characters)
Line 101:80: E501 line too long (92 > 79 characters)
Line 102:80: E501 line too long (92 > 79 characters)
Line 104:80: E501 line too long (88 > 79 characters)
Line 105:80: E501 line too long (80 > 79 characters)
Line 106:80: E501 line too long (84 > 79 characters)
Line 107:80: E501 line too long (98 > 79 characters)
Line 108:80: E501 line too long (82 > 79 characters)
Line 109:80: E501 line too long (96 > 79 characters)
Line 110:80: E501 line too long (113 > 79 characters)
Line 113:80: E501 line too long (136 > 79 characters)
Line 114:80: E501 line too long (136 > 79 characters)
Line 115:80: E501 line too long (134 > 79 characters)
Line 116:80: E501 line too long (134 > 79 characters)
Line 117:80: E501 line too long (140 > 79 characters)
Line 118:80: E501 line too long (140 > 79 characters)
Line 123:80: E501 line too long (112 > 79 characters)
Line 129:80: E501 line too long (91 > 79 characters)

In the file Tests/ML/util.py:

Line 199:80: E501 line too long (106 > 79 characters)
Line 203:80: E501 line too long (94 > 79 characters)
Line 209:80: E501 line too long (123 > 79 characters)
Line 213:63: W291 trailing whitespace

In the file Tests/ML/utils/test_io_util.py:

Line 88:80: E501 line too long (104 > 79 characters)
Line 93:80: E501 line too long (108 > 79 characters)
Line 97:80: E501 line too long (104 > 79 characters)


coreos-base/coreos-init: Work around bash regression and handle dd error

This pulls in
https://github.com/flatcar/init/pull/97
and
https://github.com/flatcar/init/pull/99
to work around a bash regression and add handling for disk write errors.
How to use
Backport to Alpha and Beta, maybe also Stable?
Needs to be done through init backport branches for Beta/Stable.
Testing done
So far only manual testing. Jenkins test started with Equinix Metal.

[x] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Closes: https://github.com/flatcar/Flatcar/issues/1059

Backported to Alpha and Beta (using flatcar-3602-backport as init branch).


Update with italian

Thank you @Rawnly . Your are great helper. I wanted to add these information today but you did first 👍 .

No worries!
Il mer 25 gen 2017, 12:46 Sattar Hummatli<EMAIL_ADDRESS>ha
scritto:

Thank you @Rawnly https://github.com/Rawnly . Your are great helper. I
wanted to add these information today but you did first 👍 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hummatli/MAHAds/pull/12#issuecomment-275088045, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APqyC9uS-AAwl0a4Bp9tbk0KiPtr2ewNks5rVzYlgaJpZM4LtWUy
.

Thank you @Rawnly.

To protect and rate don't forget to start our MAHAds on Github.

I need another help from you.
We have another useful Open Source library MAHAndroidUpdater https://github.com/hummatli/MAHAndroidUpdater . We need to translate it Italiano too.
If you relevant can you help?
Best regards. Sattar Hummatli.


Allow Schema Definition with Fixed Byte Sizes for Strings and Other Data Types

I came across this package from a tweet recently and started using it for a project to learn more about buffers, bytes, etc., in NodeJS. If this feature is possible to implement, I'd love to contribute with some guidance, as I'm still a beginner. 🙏
Would it be possible to define the byte size of a value when creating a schema? For example, the current documentation states that bin.string is a variable-length string of ASCII characters. Here's an example of the current approach:
export const PlayerUpdatePacket = bin.object({
  id: bin.string, // string is a variable-length string of ASCII characters.
  x: bin.f32,
  y: bin.f32,
});

const packet = {
  id: 0,
  x: 2.4,
  y: 1.6,
} as const;

const packetSize = PlayerUpdatePacket.measure(packet).size;
const buffer = Buffer.alloc(packetSize);

It would be great if we could specify the allocated byte size for the id in the PlayerUpdatePacket. For instance, the schema could be defined as follows:
export const PlayerUpdatePacket = bin.object({
  id: bin.string(20), // where 20 is the fixed byte size for the string
  x: bin.f32,
  y: bin.f32,
});

I used bin.string as an example, but would this also be possible for other types, like integers, floats, or even generic types?
This feature could also enable an API to get the total byte size for the values in an object. This could be used directly in the Buffer.alloc call. In the case of the example above, it might look like this:
export const PlayerUpdatePacket = bin.object({
  id: bin.string(10), // where 10 is the fixed byte size for the string
  x: bin.float(32), // 32-bit float
  y: bin.float(32), // 32-bit float
});

console.log(PlayerUpdatePacket.size); // 74 bytes total
const buffer = Buffer.alloc(PlayerUpdatePacket.size);

Would love to know your thoughts on whether this feature could be implemented!

Thank you for creating the issue!
The bin.chars should help you encode a string of known size, there you can pass the length in bytes by calling bin.chars(20) as an example. By doing this, Buffer.alloc(PlayerUpdatePacket.maxSize) should allocate the appropriate buffer for any value of PlayerUpdatePacket 🙌 .
The .size API you're envisioning already exists, but is kind of hidden and undocumented 🙈. It's the .maxSize property on some schemas. It returns the number of bytes needed to encode any value the schema describes. In the case of a variable-length schema, that value is NaN, since we cannot compute an upper bound. By using bin.chars though, the schema's max size is known.
Doing the same for floats would be a bit tricker, as there are many different ways to encode a float into an n-number of bytes. I do plan on adding f16 as a primitive though, could be useful 💜.
Hopefully that clears things up a bit, let me know if you want to discuss anything further!

@iwoplaza Thanks so much! Using bin.chars(20) and .maxSize works. I can see how doing the same for floats or ints can be tricky...
Is there an API for validating/ensuring that the size of the char is not violated when assigning values to the schema?
For example:
export const PlayerUpdatePacket = bin.object({
  id: bin.chars(2),
  x: bin.f32,
  y: bin.f32,
});

PlayerUpdatePacket.write(writer, {
  id: 'abc' // this should trigger an error maybe since byte size of abc is 3
  ...
}

My little/naive understanding tells me this might be tricky or impossible but figured I could ask

The code you wrote should raise an error, and if it doesn't, adding such a guard should not be a problem 😃. You can try and run this code locally on your machine and see if it indeed throws an error.

I wrote a StackBlitz to showcase this behavior. Hope you find it useful 🙌
https://stackblitz.com/edit/vitejs-vite-cps536?file=src%2Fmain.ts

OMG!  I am honestly enjoying this lib, thank you so much 👏 @iwoplaza
How can I help with updating the docs for the .maxSize and any other properties needed

You should be able to fork the repository, and then create a Pull Request with any changes you made to your fork. Then if everything is okay, it will be merged 💜


[Enhance]: append CSP after meta charset please?

Hi :)
Thanks for this plugin! Even if it is at an early stage, it looks promising. :)
Prerequisites

[x] I have searched through existing issues

Feature Request
Currently, the plugin injects CSP directives at the top of the <head>. This moves <meta charset="UTF-8" /> further down and could potentially break its meaning, scope, and functionality.
Since CSP isn't going to suffer from it, I would suggest injecting it right after said meta by default (or even later by using 'head' instead of 'head-prepend')
Cheers and keep up the good work :)
Please and thank you

Are you using the most recent release? There was a release about 10 days ago that should have solved this.


A11y_AzureDataStudio_NewQuery_ScreenReader: Expand/Collapse state is not announced when we are expanding the "Select database" combo box using ctrl + downward arrow key

"[Check out Accessibility Insights!] - Identify accessibility bugs before check-in and make bug fixing faster and easier."
#GitHub Tags:
#A11yMAS; #A11ySev3; #A11yTCS; #DesktopApp; #SH-AzureDataStudio-Linux-Jul2021; #Azure Data Studio; #WCAG1.3.1; #Linux; #ScreenReader; #ORCA; Element:Combobox;
Actual Result:
Expand/Collapse state is not announced when we are expanding the "Select database" combo box using ctrl + downward arrow key.
Expected Result:
Expand/Collapse state should be announced when we are expanding the "Select database" combo box using ctrl + downward arrow key.
Environment Details:
Application Name: MySQL extension for Azure Data Studio
Application Version: 1.42.0-insider
Operating System: Ubuntu 20.04.2 LTS
GNOME Version: 3.36.8
ORCA: 42.2-1ubuntu1
Distributor ID: Ubuntu
Description: Ubuntu 22.10
Release: 22.10
Codename: kinetic
Repro Steps:

Launch Azure Data Studio application.
TAB to "Servers" and select any server from the list and hit ENTER on 'Connect' button.
TAB to "File" and hit ENTER key. TAB to "New Query" and hit ENTER key.
TAB to "Select database" and observe that Expand/Collapse state is not announced when we are expanding the "Select database" combo box using ctrl + downward arrow key.

User Impact:
Screen reader users will not be able to know the state of combo box as it is expanded or collapsed.
"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver."
Attachments:
228850831-8807262b-7170-4449-bbad-a9ba7f20c2c1.webm

Primary bug: https://github.com/microsoft/azuredatastudio-mysql/issues/182

Lowering the severity of the bug to Sev3


400 error still after trying someones fix

Severity	Code	Description	Project	File	Line	Suppression State
Message		see declaration of 'std'	deadcell	E:\vs\VC\Tools\MSVC\14.28.29333\include\deque	24
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2838	'Application': illegal qualified name in member declaration	deadcell	C:\Users\SaaduPc\Desktop\DEADCELL-CSGO-master\deadcell\input\input.hpp	13
Severity	Code	Description	Project	File	Line	Suppression State
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	deadcell	C:\Users\SaaduPc\Desktop\DEADCELL-CSGO-master\deadcell\input\input.cpp	23
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2039	'string_view': is not a member of 'std'	deadcell	C:\Users\SaaduPc\Desktop\DEADCELL-CSGO-master\deadcell\console\console.hpp	23
I AM NEW TO PASTING PLEASE HELP ME FIX ERROR OR TELL ME WHAT I AM MISSING

the readme clearly states this wouldn't be the project for you. have a nice day. eternity please close this.

whyyyyyyyyyyyyyyy

just help meeeeeeeeeeeeeeeeeee

no.

yes ?
why?
no?

Please learn how to use StackOverflow or https://www.learncpp.com/


Improving the CORS behavior

While the CORS behavior is very nice there's some room for improvement. I would expect the CORS behavior to

Terminate the request if it came from invalid origin
On success, set the response status to 204
On success just send the response.

The above would solve the following issues

CORS behaviour with CompositeAuth following (preflight req. contains no auth info - usually - and as such CompositeAuth terminates with 401)
CORS should not be counted against rate limiting
In 99% of the cases, I wouldn't want my action code to run if it was a PREFLIGHT request.

(Especially the CORS with the CompositeAuth following is a very annoying and tricky combination)
What do you guys think?

In 99% of the cases, I wouldn't want my action code to run if it was a PREFLIGHT request.

isn't a preflight request an OPTIONS request? therefore it will not execute any other action than the options action

preflight requests are sent to the requested URL with verb OPTIONS.
This means that request arrives as expected to the desired controller/action. If you allow the code to normally propagate, after the CORS behavior it reaches the expected controller/action. If you don't handle it per action (or via beforeAction) your action will run and will return what it would return under normal circumstances.
Howerver. preflight requests expect response status 204 (No Content) or browser rejects them.

hmm sorry are we not talking about a REST API here? cause this is not the case for Yii's REST api

It is a RESTapi (but not using the default Yii2 REST controller).
Still (in my case) the exact same API is used by an AngularJS app and of course by normal server-to-server requests.
I find it verycommon for an AngularJs, Backbonejs, etc, to be accessing a RESTful API directly.

maybe you should create route to a particular OPTIONS action to handle any options request for that endpoint instead of doing a beforeAction to check if it's a preflight or not...
also i don't see in the link requiring the preflight to return 204, i work with emberjs as client and they accept 200 as proper response

I could create a default route but that could have sideeffects - i.e. an actual preflight to 404 would return 204. Not much of an issue but beforeAction turns out to be a cleaner solution.

the 204 is not documented there, true, but play over chrome with CORS and after a lot of searching and wondering you'll end up in the 204 (no content) :)

Thing is, one would have expected this to be handled by the CORS behaviour to keep things clean and tidy.

well you also are probably not using Yii's restful routing, that implementation will automatically route options request to the proper actions per controller so the 404 problem will not occur


Support Node.js 21

I don't know if there's more that needs to be done besides this.

It looks like existing semver range for node-abi includes its latest version, so perhaps you need to update your local lockfile?

Running
rm -rf node-modules package-lock.json
npm install

in my package's directory installed node-abi 3.52.0 and everything works now, thanks.