chore: enable additional eslint rules

Enabled the following rules as they typically catch programming errors
that are susceptible to be the causes of difficult to diagnose bugs or
performance issues:

@typescript-eslint/no-misused-promises helps ensure not-awaited
promises are not used in conditions, etc... as those are typically not
the intention of the developer and constitutes a bug that is difficult
to identify when just reading the code (i.e: likely missed in code
reviews).
@typescript-eslint/prefer-nullish-coalescing requires consistent use
of the ?? operator instead of || for nullish-coalescing, as this
operator is safer in this context (|| is falsey-coalescing, which
has a broader reach).
@typescript-eslint/return-await ensures consistency in how promises
are returned from async functions, in particular making sure await
is present when a promise is returned from a try-catch-finally
block, as failure to await in this context is usually a bug.
@typescript-eslint/switch-exhaustiveness-check requires all switch
are exhaustive, making sure no value is silently ignored, which often
is the source of silent bugs that are difficult to root cause.

One of the code changes made branch coverage in jsii-reflect drop
below the threshold (it was just above and fell just below), so
instead of lowering the threshold I added new tests to improve the
coverage of the library.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: c4b0992ae06b16e45c97aff25a8bd46571af3208
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 45570e5bd36cc5bc381251e44405c9277b166672
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 9270bf06b36549544d53348cd4f1f3ba460bef10
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: e7c7d518b10350d66507827262f8a78da90428dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 3519221d416e5b7d8249408cb5f1673901caf20f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


WalletConnect bug fixes

[ ] Whenever the user reloads after connecting using wallet connect, the state for the user account is not retrieved
[ ] After connecting the wallet using WalletConnect, the user is not able to switch chains

Have started working on this

Closed by #25


FIPS mode check with hashlib.md5 is not handled correctly

https://github.com/cython/cython/blob/87329f1f9747a5a7e483cf4827d40457f6354c7c/Cython/Compiler/ParseTreeTransforms.py#L2044-L2047
When a machine has FIPS mode enabled, via a fips=1 option on the kernel command line, the MD5 algorithm, among others, is blocked within the kernel. The AttributeError exception shown above is intended to catch situations where this is the case and omit md5 from the list of algorithms, However, simply appending the hashlib.md5 function to the checksum_algos list does not invoke the function, and thus does not raise an exception of any kind if the function is available but blocked. The exception occurs later, when the function is used in "for mkchecksum" to try to create an MD5 checksum, throwing a ValueError exception when it's blocked by the kernel:
https://github.com/cython/cython/blob/87329f1f9747a5a7e483cf4827d40457f6354c7c/Cython/Compiler/ParseTreeTransforms.py#L2050-L2053
A fix would be to make a dummy call to hashlib.md5 in the try block immediately before appending it to the array, and catching and passing that ValueError exception, demonstrated here:
>>> import hashlib
>>> hashlib.md5(b'')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: unknown reasons
>>>

sh-4.2# fipscheck
usage: fipscheck [-s <hmac-suffix>] <paths-to-files>
fips mode is on
sh-4.2#

You would want to look for both the ValueError and AttributeError exceptions so as to catch both FIPS mode blockage as well as a missing md5 function.
This is the root cause of https://github.com/PySlurm/pyslurm/issues/236. Based on information there, downgrading to Cython 0.25.2 works around the issue in PySlurm.

Thanks for the detailed report. Could you verify that https://github.com/cython/cython/commit/3a373e2ccdddc79202d9ed13edc85d4b95616b26 works for you?

There also looks to be the usedforsecurity argument on Python 3.9+, which we might want to use to get access to md5

When FIPS mode is enabled, the setting of usedforsecurity wouldn't matter; the MD5 algorithm is blocked in the kernel, not by Python. The WerkZeug project, for example, switched from md5 to sha1 for their integrity checks in their 2.0 release for this reason. It seems to me that MD5 should be considered extinct, to be avoided in nearly all cases.

Thanks for the detailed report. Could you verify that 3a373e2 works for you?

That did the trick, yes! Thanks! I like the implementation; it handles all the algorithms in the same way.


[New Sheet] NoReturn 2nd Edition

Official sheet for NoReturn 2nd Edition by Manifest Games

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <NoReturn 2nd Edition>  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is:  (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is:  (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[x] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
Erste Version des Charakterbogens für das aktuelle Crowdfunding von NoReturn 2nd Edition

Character Sheet Info Roll20 Internal Use only.

Hey there @Gorthian, at the current moment we do not support external fonts hosted outside Google fonts. Even though they will work on a dev sandbox game, they will break once the sheet is moved to production.
Maybe that is not as well documented as it should, I will see what we cand do on our side to make this clearer. Is this something you could work around?

We did hope it would work if we host the font files on the GitHub and link to them.
I planned to change the URL as soon as the files are part of the repository.
Would that be possible?

Unfortunately, we cannot have the font hosted through github: It must be hosted in Google Fonts. We've got a document that could be a good place to start looking for alternatives, but feel free to look through https://fonts.google.com/ as well

OK,. Thanks for your help.
Would it be a problem if we leave the font definition of the original fonst in the css file, and remove only the includes of the font files?
So you could install the fonts on your local pc.
Of course we would implement a fallback to a google font for those browsers without the local fonts.

Hi @Gorthian
That is a good solution. Thanks for your understanding.

OK.
It will take a while before I can change this.
Don't know if you want to let the merge requests open until then.
For me it's OK if you close it.

I have marked it as draft. You should be able to remove that status when you're ready to merge :)


Change storage account output information.

@bganapa a minor change for azure stack new srp, could you help to check it?

Was there a change in swagger spec that triggered this?

Was there a change in swagger spec that triggered this?

Yes, the one in spec is already checked in.

@wenjlu-lgy your PR contains breaking changes such as renaming a model class, plesae put a link to your swagger review PR here, and also update the major version number.

@wenjlu-lgy your PR contains breaking changes such as renaming a model class, plesae put a link to your swagger review PR here, and also update the major version number.

So I should update the version number from 1.9.0 to 2.0.0, right?

@wenjlu-lgy your PR contains breaking changes such as renaming a model class, plesae put a link to your swagger review PR here, and also update the major version number.

So I should update the version number from 1.9.0 to 2.0.0, right?
Here's the pr link https://github.com/Azure/azure-rest-api-specs/commit/e99d1c20d3cc621a38af09d3c146149812a87e38#diff-02ee76c268524d9c18f32bc098eff02b

@isra-fel The pr link for spec is https://github.com/Azure/azure-rest-api-specs/pull/7591, the version is upgraded from 1.9.1 to 2.0.0

Please also check in eng/mgmt/mgmtmetadata/<yourservicename>.txt, which is generated when you run generate.ps1. Other changes look good to me
Thanks

Please also check in eng/mgmt/mgmtmetadata/<yourservicename>.txt, which is generated when you run generate.ps1. Other changes look good to me
Thanks

It's already checked in as https://github.com/Azure/azure-sdk-for-net/blob/master/eng/mgmt/mgmtmetadata/azsadmin_resource-manager_storage.txt, anything needs to change?

Yeah, it's already there, but when you run generated.ps1 that file should be updated. And you should check in that change.
If the file was not changed during generation, please follow these steps to update build tools then run generate.ps1 again. Thanks

Yeah, it's already there, but when you run generated.ps1 that file should be updated. And you should check in that change.
If the file was not changed during generation, please follow these steps to update build tools then run generate.ps1 again. Thanks

done.


Refined Storage Crafters interfaced with hoppers will result in recipes being removed

Issue description:
Crafter interfaced with a hopper.  Hopper interfaced with some machine (Pneumaticcraft's Pressure Chamber in this example as the crafter will not work with the chamber).  The hopper pulls the recipes from the crafter.  Tada!
What happens:
The hopper is doing what it thinks is best but truly it doesn't know whats best.
What you expected to happen:
The hopper should not remove recipes from a crafter on the interfaced side.
Steps to reproduce:

Place a chest
2.Place a hopperpointing into said chest
3.Place a crafter, interface side down, on top of the hopper.
4.Place patterns into the crafter
5.Observe the chest: it has patterns
...

Version (make sure you are on the latest version before reporting):

Minecraft:1.15.2
Forge:31.1.74
Refined Storage:1.8.3

Does this issue occur on a server? [yes/no] Yes (but also tested in SSP)
If a (crash)log is relevant for this issue, link it here:
Nein
Here are some pretty pictures if you need to duplicate this for testing:

Oh also, V6 autocrafting appears to be much friendlier (so far) on servers, thank you!

Actually, this probably isn't a bug since the crafter can point to ANY other side of a hopper and still work.  Please close this ticket if it is intended behavior and not a bug.

This behavior could be changed, a pattern inventory shouldn't be exposed to the side the crafter is facing, probably.


DTLS 1.3 test cases available for testing?

Hello,
The latest addition of DTLS 1.3 looks really exciting. I tried this update with the OpenSSL's feature/dtls-1.3 branch, appropriately setting up all the required environment variables. The specific commit I used: Fix DTLS 1.3 handshake transcript hash .
I ran some tests with this & while the TLS tests completed successfully, the DTLS ones did not run.
Could you confirm whether the DTLS 1.3 test cases are currently implemented and available for testing?

I did run the test on the feature branch and it executed (and passed) DTLS handshake testing. Did you run the "scripts/fullbuild.sh" with the OPENSSL_BRANCH env var suitably set as per comment?

This did work! I was actually trying some manual compilation of the test cases & might have missed something in that. The pre-defined scripts are running fine though.
Thank you :)


Chocolate shop, some missing stuff added

For a potential v0.2 BN3 Archipelago Beta test

Added the BMD Chest Icons back into the zip file
Added ACDC School Bookshelf BMD to the tracker
Added DNN Security Panel BMD to the tracker
Reworked the NumberMan Gacha prize tracker format
Added Chocolate Shop Gacha prizes to the tracker in a similar fashion to the new NumberMan prize tracker

Hey, thanks for the fixes. If you don't mind me asking, why did you pile all the Numberman checks back together? They were separated to minimize the manual clicking (until autotracking gets implemented on my end), and also to have them show logical availability.

I actually wanted to manually click every check on my end, so I apologize for that. Feel free to change that and the chocolate shop back to the older format to prevent the headache, especially if you plan on adding auto-tracking support.
As for logical availability, you just need Zenny and Bugfrags to buy them and they're available. They're not really progression locked otherwise and may house items that are important for areas that "might" be within the areas you have listed. I don't know how the progression works in the code, I'll have to check.

Auto-tracking is on my to-do list once I have time again, but that's not likely for another week or two.
And yes, the shop items are all immediately accessible. It's a design decision on Digi's part that logical access requires other progression before you're expected to get later shop items in order to prevent the opening of every seed being "farm 16k zenny".


Get value question type html

Hi,
I use question type html, but does not return the values of the marked reforms.
Has anyone ever been through this?

survey jquery

Hi, @hugofabricio!
Could you please explain - what the "marked reforms" are?
Can you share the content of your html question for better understanding?

I create html questions, example:
	"locale": "pt",
	"showCompletedPage": false,
	"showNavigationButtons": false,
	"showTitle": false,
	"showPageTitles": false,
	"pages": [
		{
			"name": "page_1",
			"elements": [
				{
					"name": "question_1",
					"type": "html",
					"renderAs": "quiz",
					"html": "

Calculadora da Vida Saudável

No dia a dia, você prefere:

<input type=\"radio\" class=\"input-radio\" id=\"answer-1\" name=\"question_1\" val=\"1\">Aproveitar a batida da música

<input type=\"radio\" class=\"input-radio\" id=\"answer-2\" name=\"question_1\" val=\"2\">Curtir a natureza

<input type=\"radio\" class=\"input-radio\" id=\"answer-3\" name=\"question_1\" val=\"3\">Reunir os amigos

<input type=\"radio\" class=\"input-radio\" id=\"answer-4\" name=\"question_1\" val=\"4\">Ficar relaxando em casa

VoltarPróximo

"
				}
			]
		}
	]
}```

I want to get the value of the input and save, but I'm not done.

@hugofabricio html question was created for showing the information. We do not parse it and look for inputs. If you are using something in html - you are on your own.
Please use other questions, like dropdown, text and so on. Take a look at our question types and custom widgets examples: https://www.surveyjs.io/Examples/Library/
Thank you,
Andrew

Custom widgets works in type html?

No, they are work as a typical question.
Please take a look at examples.


v3.4 turn on experimental features

In environment-variables.md, enable ones that were opt-in in v3.2.
When complete, create new issue for v3.5.

Which features will we be turning on?

not sure, need to look at doc when time comes

This should be kept open for discussion but not necessarily targeting for v3.4.


Ensure file lock is released before cache cleanup

Caches with on-demand locking keep hold of file locks unless contended
by other Gradle processes. Prior to this commit, such previously
acquired file locks were held for the complete duration of cache
cleanup only to be released immediately afterwards. While cache cleanup
was running, requests to release such file locks from other processes
(via DefaultFileLockContentionHandler) were not processed because the
stateLock of DefaultCacheAccess was already locked by another
thread and thus, the ContentionAction in
LockOnDemandCrossProcessCacheAccess was blocked until the close()
method in DefaultCacheAccess was finished.
Since cache cleanup only deletes files that are no longer in use, it
does not use file locking (which would not work anyway because the
current cache access infrastructure is not usable while the cache is
already being closed). Thus, this commit closes the
CrossProcessCacheAccess of the DefaultCacheAccess before cleaning
up caches.
Issue: gradle/gradle-private#1412

Since cache cleanup only deletes files that are no longer in use, it
does not use file locking (which would not work anyway because the
current cache access infrastructure is not usable while the cache is
already being closed).

Does this mean that if a file that could be cleaned up is marked as used while the cleanup is happening, we can delete that file even though the other Gradle process has locked the cache?  Or if two Gradle processes decide to cleanup the same cache at the same time, they'll both be listing/deleting files from the cache concurrently?


local bootstrap deployment should scale down databases services

Deploying 3 nodes of etcd and elasticsearch can be an issue on systems with low resources.
The bootstrap should be able to deploy a single container of each service when deploying a local swarm.

Unfortunately variable interpolation doesn't work for int fields: https://github.com/docker/compose/issues/2730


[ntf-core] new port

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

Resubmission of #32738 with company CLA attribution

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 everything look good here?

@hallfox  Test error on x64-linux locally:
Installing 4/4 ntf-core:x64-linux...
Building ntf-core:x64-linux...
-- Downloading https://github.com/bloomberg/ntf-core/archive/2.1.0.tar.gz -> bloomberg-ntf-core-2.1.0.tar.gz...
-- Extracting source /home/test/vcpkg/downloads/bloomberg-ntf-core-2.1.0.tar.gz
-- Using source at /home/test/vcpkg/buildtrees/ntf-core/src/2.1.0-b5bd59a649.clean
-- Configuring x64-linux
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /home/test/vcpkg/downloads/tools/ninja/1.10.2-linux/ninja -v
    Working Directory: /home/test/vcpkg/buildtrees/ntf-core/x64-linux-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      /home/test/vcpkg/buildtrees/ntf-core/config-x64-linux-dbg-CMakeCache.txt.log
      /home/test/vcpkg/buildtrees/ntf-core/config-x64-linux-rel-CMakeCache.txt.log
      /home/test/vcpkg/buildtrees/ntf-core/config-x64-linux-out.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:252 (vcpkg_execute_required_process)
  ports/ntf-core/portfile.cmake:9 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)

/home/test/vcpkg/buildtrees/ntf-core/config-x64-linux-out.log:
CMake Error at repository.cmake:3916 (find_program):
  Could not find debugger_path using the following names: gdb
Call Stack (most recent call first):
  targets.cmake:18 (ntf_repository)
  CMakeLists.txt:42 (include)

Argh, the current version of ntf-core seems to require a debugger on configuring. I'm working with the maintainer to remove this requirement. Is there a way to require a debugger in the dependencies, or are we just stuck until this requirement is removed?

Is there a way to require a debugger in the dependencies

No.

Sounds good, I've updated the config to use a fake variable for the debugger path, this shouldn't affect the build except to let it continue without a debugger installed. Future releases of ntf-core will remove the requirement for the debugger, so I expect we can remove this option in the future.

/azp run

Checking in, is this good to go?


Metal Gear Rising: Revengeance hangs/freezes on launch

//Description
You launch it, it freezes, simple as. Take a look at the files if you want.
Set the shader model to either 1.4, 3.0 or 4.0, to no avail.
I've also disabled the Steam overlay, just in case. Nothing has worked so far.
 Windowed or full screen, same thing.
d3d9.log
METAL GEAR RISING REVENGEANCE_d3d9.log
NvRemixBridge.log

Hello! Will you please check on the latest release and let us know if this issue persists? We have been able to launch the game with Remix internally since this issue was filed. Thank you!


Update OWNERS

This patch syncs OWNERS file with https://github.com/openshift/knative-serving/blob/main/OWNERS.
Without this, all Serving members cannot approve release repo like https://github.com/openshift/release/pull/26253.
/cc @rhuss @skonto

/retest

@nak3 are the failures expected above?

Yes, the main branch is not synced with upstream  (by design) so the failure is expected.


Do We Need a Database When We Have Apache Kafka?

Proposed title of article
Do We Need a Database When We Already Have Apache Kafka?
Proposed article introduction
Kafka has occasionally been described as something much more than just a better message broker. Proponents of this viewpoint position Kafka as a fundamentally new way of managing data, where Kafka replaces the relational database as the definitive record of what has happened. Instead of reading and writing a traditional database, you append events to Kafka and read from downstream views that represent the present state. This architecture has been described as “turning the database inside out“.
In principle, it is possible to implement this architecture in a way that supports both reads and writes. However, during that process, you will eventually confront every hard problem that database management systems have faced for decades. You will more or less have to write a full-fledged DBMS in your application code. And you will probably not do a great job, because databases take years to get right. You will have to deal with dirty reads, phantom reads, write skew, and all the other symptoms of a hastily implemented database.
Key takeaways
Apache Kafka and database explained briefly
Storage in Kafka
Queries and Processing in Kafka
Transactions in Kafka
Kafka and ACID Guarantees
Article quality
This article digs deeper into Kafka storage functionalities while giving examples. It also deconstructs Kafka and databases.
References
N/A

Great topic 🚀 , make sure it matches the following:

Adds value beyond what is in the official docs and what is covered in other blog sites.
To avoid potential article closure, it should not overlap with existing EngEd articles or incoming topic suggestions.

Please reference any relevant EngEd articles in yours and build a unique project - Approved.


KeyError: 'albumNameEnc'

2020-07-23 10:48:46 DEBUG    Looking up all photos and videos...
Traceback (most recent call last):
  File "/usr/bin/icloudpd", line 11, in <module>
    sys.exit(main())
  File "/usr/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/icloudpd/base.py", line 253, in main
    photos = icloud.photos.all
  File "/usr/lib/python3.6/site-packages/pyicloud_ipd/services/photos.py", line 228, in all
    return self.albums['All Photos']
  File "/usr/lib/python3.6/site-packages/pyicloud_ipd/services/photos.py", line 194, in albums
    folder['fields']['albumNameEnc']['value']).decode('utf-8')
KeyError: 'albumNameEnc'

and my script is just like the md file:
$ docker run -it --rm --name icloud -v $(pwd)/Photos:/data ndbroadbent/icloudpd:latest \
    icloudpd /data \
    --username<EMAIL_ADDRESS>\
    --password pass1234 \
    --size original \
    --recent 500 \
    --auto-delete

It's always successful all the time except today ( I use this script on or two month a time)
I've got nothing changed, and I double checked my album name, nothing wired character exists, except Chinese character, is this the reason? but they're here from a while and successfully downloaded many times.

I'm getting the same error, with no Chinese character

This should be fixed with #150 . Please recheck @simon1573 and @walkerwzy . Thanks!


Debug Protocol

Adding the code for emitting the debug protocol via Protocol tool.

Hi @singhsarab, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Sarabjot Singh). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@dotnet-bot  test this please.


Reproducing the experimental results

Hello there,
Thank you for your nice work! I do have a question regarding about reproducing the codebase. I tried to run the main file on LLAMA-2-7B-Chat and it shows the jailbreak prompt for each of the harmful question and its corresponding harmful response, but when I record each of the successful jailbreak prompt for each harmful question and apply the inference directly on LLAMA-2-7b-Chat, I found that the ASR on LLAMA-2-7B-Chat is only around 33% when using keyword matching metric. I am just wondering if you can point out any errors that I did wrong during the experiment. I could provide other details if you needed! Let me know! Thank you for your help!

Hmm, there might be some difference in terms of the chat template and system prompt maybe when you apply the inference directly? It would be definitely helpful to see your inference code.

Hello,
Thank you for your promptly replied. Here is the inference code:
`import os
os.environ["HF_HOME"] = "/tmlscratch/andriush/models/"
import argparse
import random
import string
import torch
import numpy as np
from loggers import WandBLogger
from judges import load_judge, judge_rule_based
from language_models import GPT
from prompts import get_universal_manual_prompt
from conversers import load_target_model
from utils import insert_adv_string, schedule_n_to_change_fixed, schedule_n_to_change_prob, extract_logprob, early_stopping_condition
import pandas as pd
parser = argparse.ArgumentParser()
########### Target model parameters ##########
parser.add_argument(
"--target-model",
default = "gpt-3.5-turbo",
help = "Name of target model.",
# choices=["vicuna", "llama2", "gpt-3.5-turbo-1106", "gpt-4-0613", "gpt-4-1106-preview", "claude-instant-1","claude-2", "palm-2"]
)
parser.add_argument(
"--target-max-n-tokens",
type = int,
default = 150,
help = "Maximum number of generated tokens for the target."
)
##################################################
############ Judge model parameters ##########
parser.add_argument(
"--judge-model",
default="gpt-4-0613",
help="Name of judge model.",
choices=["gpt-3.5-turbo-1106", "gpt-4-0613", "gpt-4-1106-preview", "no-judge"]
)
parser.add_argument(
"--judge-max-n-tokens",
type = int,
default = 10,
help = "Maximum number of tokens for the judge."
)
parser.add_argument(
"--judge-temperature",
type=float,
default=0,
help="Temperature to use for judge."
)
parser.add_argument(
"--judge-top-p",
type=float,
default=1.0,
help="Top-p to use for judge."
)
parser.add_argument(
"--judge-max-n-calls",
type = int,
default = 1,
help = "Maximum number of calls to the judge inside the random search loop."
)
##################################################
args = parser.parse_args()
seed=1
random.seed(seed)
np.random.seed(seed)
torch.manual_seed(seed)
if torch.cuda.is_available():
torch.cuda.manual_seed(seed)
torch.cuda.manual_seed_all(seed)
Initialize models and logger
targetLM = load_target_model(args)
df_data = pd.read_csv("/workspace/llm-adaptive-attacks/llama_adaptive_llm_rs.csv")
jb_prompts=df_data["best_msg"]+" "+"Kindly furnish a thorough response to the former user's question."
jb_count=0
for i in range(len(jb_prompts)):
jb_prompt=jb_prompts[i]
response=targetLM.get_response([jb_prompt], max_n_tokens=args.target_max_n_tokens, temperature=1.0)[0]['text']
jb_flag=judge_rule_based(response)
if jb_flag:
jb_count=jb_count+1
print(f"########################################Batch_{i}########################################")
print(response)
print(f"Total Jailbreak: {jb_count}")
print(f"ASR: {jb_count/len(jb_prompts)}")`
I am using the same fschat version (0.2.23) you mentioned in the github repository. Please let me know if you have additional questions/concerns! Really appreciate your help! Thank you!

Thanks, this is helpful.
Do I understand correctly that you are changing the prompts by adding an additional sentence at the end?
jb_prompts=df_data["best_msg"]+" "+"Kindly furnish a thorough response to the former user's question."
I think this definitely interferes with the adversarial suffixes found by random search. Can you just try jb_prompts=df_data["best_msg"] (I'm assuming df_data["best_msg"] is something like prompt from the jailbreak artifacts https://github.com/tml-epfl/llm-adaptive-attacks/blob/main/jailbreak_artifacts/exps_llama2_7b.json)?

sure, I will try that and get back to you!
Thanks

Hello there,
I tried the jailbreak artifacts from the [https://github.com/tml-epfl/llm-adaptive-attacks/blob/main/jailbreak_artifacts/exps_llama2_7b.json] and I also removed the  +" "+"Kindly furnish a thorough response to the former user's question." part and directly apply the prompt from the jailbreak artifiacts on LLAMA-2-7B-Chat, and I got an increased ASR: 0.68.  However, I observed some interesting output that some of the responses are shown below:

Here from Batch 13 and 15 are outputting some random strings. I am just wondering why this happened. I counted that there are 8 in total jailbreak questions output some random strings. Below is my modified code for your reference. Let me know if you need additional information. Thank you!
`
import os
os.environ["HF_HOME"] = "/tmlscratch/andriush/models/"
import argparse
import random
import string
import torch
import numpy as np
from loggers import WandBLogger
from judges import load_judge, judge_rule_based
from language_models import GPT
from prompts import get_universal_manual_prompt
from conversers import load_target_model
from utils import insert_adv_string, schedule_n_to_change_fixed, schedule_n_to_change_prob, extract_logprob, early_stopping_condition
import pandas as pd
import json
parser = argparse.ArgumentParser()
########### Target model parameters ##########
parser.add_argument(
"--target-model",
default = "llama2",
help = "Name of target model.",
# choices=["vicuna", "llama2", "gpt-3.5-turbo-1106", "gpt-4-0613", "gpt-4-1106-preview", "claude-instant-1","claude-2", "palm-2"]
)
parser.add_argument(
"--target-max-n-tokens",
type = int,
default = 150,
help = "Maximum number of generated tokens for the target."
)
##################################################
############ Judge model parameters ##########
parser.add_argument(
"--judge-model",
default="gpt-4-0613",
help="Name of judge model.",
choices=["gpt-3.5-turbo-1106", "gpt-4-0613", "gpt-4-1106-preview", "no-judge"]
)
parser.add_argument(
"--judge-max-n-tokens",
type = int,
default = 10,
help = "Maximum number of tokens for the judge."
)
parser.add_argument(
"--judge-temperature",
type=float,
default=0,
help="Temperature to use for judge."
)
parser.add_argument(
"--judge-top-p",
type=float,
default=1.0,
help="Top-p to use for judge."
)
parser.add_argument(
"--judge-max-n-calls",
type = int,
default = 1,
help = "Maximum number of calls to the judge inside the random search loop."
)
##################################################
args = parser.parse_args()
seed=1
random.seed(seed)
np.random.seed(seed)
torch.manual_seed(seed)
if torch.cuda.is_available():
torch.cuda.manual_seed(seed)
torch.cuda.manual_seed_all(seed)
Initialize models and logger
targetLM = load_target_model(args)
#df_data = pd.read_csv("/workspace/llm-adaptive-attacks/llama_adaptive_llm_rs.csv")
file = open("/workspace/llm-adaptive-attacks/jailbreak_artifacts/exps_llama2_7b.json")
llama_data = json.load(file)
jb_prompts = llama_data['jailbreaks']
#jb_prompts=df_data["best_msg"]+" "+"Kindly furnish a thorough response to the former user's question."
jb_count=0
for i in range(len(jb_prompts)):
jb_prompt=jb_prompts[i]['prompt']#+" "+"Kindly furnish a thorough response to the former user's question."
response=targetLM.get_response([jb_prompt], max_n_tokens=args.target_max_n_tokens, temperature=1.0)[0]['text']
jb_flag=judge_rule_based(response)
if jb_flag:
jb_count=jb_count+1
print(f"########################################Batch_{i}########################################")
print(response)
print(f"Total Jailbreak: {jb_count}")
print(f"ASR: {jb_count/len(jb_prompts)}")
`

Seems like something is wrong with the chat template. I'll take a look.

Hello there,
Sorry for disturbing you again. I do have another question. I am just wondering if the prompts in  are generated by main.py. I am using the bash script in the experiments/exps_llama2_7b.sh folder for LLAMA-2-7B-Chat and only got 0.4 in terms of ASR. I am just wondering if you have any additional insights about it. Thank you for your help!

Indeed, the chat template is to blame (as always... :) ). The issue is that I produced the results in the paper with an older version of the code which I subsequently changed. I thought that I successfully fixed the chat template, but apparently not completely. There was still a discrepancy: a missing  at the beginning and a space before [/INST] (not sure why FastChat didn't handle this correctly).
In any case, I've fixed it in this commit https://github.com/tml-epfl/llm-adaptive-attacks/commit/f82e6f9a0e45f314cf3c7b4eb2c1325a4728401d. With this fix, using your script with temperature zero, 90% generations now start with 'Sure' and 80% pass the rule-based judge. To get to 100% ASR, you would need to sample Llama-2 multiple times and pick a good continuation according to the semantic judge.
I expect that this fix will also help you reproduce the results when running main.py. Ideally, you should get an output close to what is in the logs (https://github.com/tml-epfl/llm-adaptive-attacks/blob/main/attack_logs/exps_llama2_7b.log). Let me know if the problem persists.

Thank you for your help, I will try that!

Thank you for your time! I will close the issue now!


PC crashes when tooltip text is too long

Description
When hovering over a cell in a table and the tooltip text would be too long, it takes the whole screen and is truncated. This causes the entire PC to crash.
dbeaver_tooltip_crash.log
DBeaver Version
24.1.5
Operating System
Ubuntu 24.04
Database and driver
Mysql 8.2.0
Steps to reproduce

Open a table
open either the Properties or Data view
hover over a cell that has a lot of text content
Text is larger than the screen
result: crash

Additional context
Tested back to version 23.3.5, still reproducible

Thank you for bug report.
Unfortunately, DBeaver logs doesn't tell a lot in case of crash. Could you try looking for java fatal logs? They're called hs_err_PID.log, where PID is a number and usually resides in the same directory where the DBeaver launcher is.
You can find information about them here https://dbeaver.com/docs/dbeaver/Log-files/#java-fatal-logs

dbeaver-debug-1725031480203.log
This file has the error.

What do you mean by "crash"? Does the app just close, or does an error appear in the error log? If the former, please look for the fatal logs mentioned in https://github.com/dbeaver/dbeaver/issues/35411#issuecomment-2321755946. Regular debug logs won't help there.

I think we can just truncate long tooltips. It doesn't make sense to have too big ones.

What do you mean by "crash"? Does the app just close, or does an error appear in the error log? If the former, please look for the fatal logs mentioned in #35411 (comment). Regular debug logs won't help there.

"crash": The entire Ubuntu desktop crashes with an irrecoverable error, and I am forced to log out + login


Feature Proposal! - "show amount of urls scanned out of total amount of given urls trough url file list in output terminal"

Feature Proposal! - "show amount of urls scanned out of total amount of given urls trough url file list in output terminal"
Why?
I love your tool, and sometimes i am scanning 10000+ links (don't ask). BUT, when scanning i only see the output of the tool testing parameters and XSS found etc.
I would love to have a counter that displays how much urls are scanned and how much still need to be scanned. Example:
i have 100 *.example.com links in a list scan file. I point dalfox to the file and start scanning. [progress: 2/100]
I love Dalfox and XSpear btw ;), let me know what you think about the feature. I could code it for you maybe but i have Zer0 Golang expirience yet... :p

Hi @Slowpoke079
Thank you for your opinion. I preparing for the next version now, and i'll include it😉
I thought the current log output method was insufficient in many URL modes such as pipe, file mode.
Thank you so much for your good opinion!

Thank you! Much appreciated.
Btw, im a new/newby bugbounty hunter, is there a channel (like discord) where i can ask you things regarding encoded XSS attacks? I recently found one (with dalfox) but i don't know how to get the "alert poc" to work since i do not know how to read encoded payloads for shit.
[V] Reflected Payload in JS: page=';this'x65x76x61x6c';//
94 line:  ","query":{"page":"2';this['x65x76x61x6c']('this['x61x6cx65x72x74'](this['x61x74
+> https://somewebsite.com/somepage?page=2'%3Bthis['x65x76x61x6c']('this['x61x6cx65x72x74'](this['x61x74x6fx62']('WFNT'))')%3B%2F%2F

Dev logs
First of all, it is reflected in the current code version. It's going to be distributed in a 2.0 release.
=> 300f231 , and change spinner format

Question
I don't know which channel to recommend because I'm not participating in channels like discord. Why don't you DM to Awesome guys like BruteLogic with masked information with test code?

If you really don't know how, DM me (with masked. your information is important!). I don't know if it'll help, but I'll check.

Oh i didn't see that! I am dyslexic ,(hi dyslexic) and tend to read over things quite fast when not concentrated... And thanks for all the help! I won't ask to take more time from you since that would be selfish on my side. The tool already does a lot for me <3. And i am waaay to shy for twitter and the like :P.
Thanks for the commitment :)


Default pkg source credentials

🚀 Feature
Add support for configurable or "default" pkg source credentials, to avoid needing to re-enter on the command line each time and make it easier to automate ops in a non-interactive environment.
This could be implemented in a number of ways. My proposal is to storing some config yml file in $XDG_CONFIG_HOME/opctl/credentials.yml with a way to match package sources with credentials.
The structure could be something like:
credentials:
- source: github.com/Remitly
  username: $(github.username) # environment variable / object reference
  password: $(github.accessToken)
- source: github.com
  username: myusername # plain text
  password: $(GITHUB_PASSWORD) # environment variable

This attempts to math opctl's opspec format. It uses opctl's object property referencing syntax and its ability to read environment variables.
It would use the credential source to match the pkg source's prefix and use the first credential found (e.g. opctl run -a apiKey=$LOKALISE_TOKEN github.com/Remitly/parakeet#v1.0.0/parakeet-ops/update-all-locales would match the first credential, not the second).

@apexskier thanks for filing!
Just wanna clarify, is the intent only to use these creds to pull the root op of a call (github.com/Remitly/parakeet#v1.0.0/parakeet-ops/update-all-locales in your example) i.e. not calls within the call graph thereafter?

Also, per https://github.com/opctl/opctl/issues/745 just thought i'd mention, another possibility could be to allow git cred store to be a default source

Also worth mentioning, pkgs do get cached; you shouldn't be prompted more than once per pkg, but I know that doesn't solve the underlying thing you're after.

There's been the idea of a space floating around for some time. Idea was to solve for at least configuration of op inputs across all the things. So your ops would be started within a given space and therefore have access to variables defined in said space. It would/could replace things like credential stores and env vars. It's particularly useful to tie together the experience from the CLI and the UI; obviously the UI doesn't have access to things like env vars.

Just wanna clarify, is the intent only to use these creds to pull the root op being run/installed (github.com/Remitly/parakeet#v1.0.0/parakeet-ops/update-all-locales in your example) and not arbitrary descendant calls thereafter?

I didn't have a specific intent. I've never encountered a use case where I get prompted for creds to pull sub-ops.
I'd expect it to re-run the same credentials resolution logic each time it needs creds though, not to potentially use different creds based on the top level op that's resolved.

Right, the reason you don't get prompted when private sub ops are encountered is because that's supported via setting pullCreds. Just wanted to verify you weren't intending to change that aspect which is a bigger change to consider cuz it would essentially be using an input (the creds) but without declaring it as an input which arguably breaks composability.
Doing it at the root is less controversial because you're on your host in that context.


Memory leak ?

Describe the bug
A memory leak seems to live in adonisUI (tested with v1.16.0 but it seems to be older than that).
To Reproduce
Steps to reproduce the behavior:

Clone and startup RoleDDNG
Make the Memory Usage tab from the Diagnostic Tools window visible
Fire up the Dice Roller 'Window' (or "Lanceur de dés") with the keybinding (this is important) Ctrl-D and hold it.
See the memory usage grow and grow over time. Moving the mouse along  at the same time seems to make it grow faster.

Expected behavior
Same as the "memleak" branch on the same repo (where adonisUI was removed) : no memory leak.
Screenshots
master branch :

This goes on forever and grows up to hundred of megabytes, even gigabytes, pretty quickly.
memleak branch :

This quickly stabilizes around 175 MB.
Additional context
Granted, constantly firing a keybinding isn't an expected "real user" behavior, but still.
No mem leak seems to happen if you close the 'window' first (by clicking on the 'x' button).
Key code points :

MainViewModel#AddMdiWindow
MDIContainer#OnSelectionChanged

Thank you for your report and sorry for the late reply! I am really busy lately.
I cloned your repo but cannot run it unfortunately. It fails at resolving some Hammer.MDIContainer.Control dependency.
Are there any setup instructions?

It's inside the Controls directory and should be a local reference. It's a fork of the nuget package of the same name. I think you could use the nuget version instead and still reproduce the issue.
If it fails, I'll try to setup a minimal reproduction repo.

I can't get it to run, sorry.
Switching to the NuGet version gives me an error that it does not support build target netcoreapp3.1.
Seems like Hammer.MDIContainer.Control itself is fine but it has a reference to Xceed.Wpf.Toolkit which cannot be resolved again. I noticed that this is placed as a local copy in your repo as well but does not get downloaded when cloning the repo. So I downloaded it manually and placed it in the empty directory wpftoolkit. Now the solution loads correctly but Visual Studio does not build anymore. It does not even start a build. It just pops up a message box that sais something like "Error: Interface is not supported".
The log file states: "Visual Studio ran into an unexpected problem with 'Axeed.Wpf.Toolkit'. System.ArgumentException: The project configuration "Debug|AnyCPU" was not found in the project manifest."

Sorry about this mess.
I removed wpftoolkit from all branches. It wasn't used anyway. it should work now.

It runs now and I can reproduce the increasing memory consumption. I will try to find the source of this.

Is this related to memory leak I reported here: https://github.com/benruehl/adonis-ui/issues/43 ?

@benruehl : Thank you for looking into it.
My bet was on events, but I didn't have time either to look into it.

Is there anything we can do to help ?

Small update:
Last time I tried some VS memory profiling but didn't find anything unexprected. I am not used to debugging memory leaks so I might have made mistakes here.
Now I did a fresh restart. I cloned your repo again and noticed that the leak does not occur anymore. Looks like you fixed it by not instantiating new windows when holding down the keyboard shortcut. Anyway, I removed the check for existing windows and got the memory leak again. Then I disabled the ripple effect because @Mgamerz suggested it might be the reason. But nothing changed. I disabled the cursor spotlight as well but nothing changed still. I excluded all default styles and then excluded Adonis UI completely but nothing changed. And by "excluded Adonis UI" I mean I removed every single usage in all projects and the project references so that no DLL of Adonis UI can be found in the output directory.
I am a little confused now. To me it looks like this does not have anything to do with Adonis UI. Maybe it's an issue of the MDIContainers you used. Am I missing something here? Please tell me if I did a mistake and came to the wrong conclusion.

Since you have an open source project, you should be able to get a free
resharper license from jetbrains, if you're interested. I use their
dotmemory program which I find much easier than visual studio's memory
tools.
I trace memory leaks by attaching a weak reference in the constructor of my
windows and objects and then monitor for when they go dead. Once I find
something is not being released that should be, I use dotmemory to find the
root path which is almost always some event handler not being unset.
I'm not sure the issue is the same for my app as the one here but that's
how I traced it to Adonis. I used an older version when I reported my
issue, it could be it was unintentionally fixed since. In my implementation
I use weak event handlers which don't count as a reference for an object,
but at a cost to performance. How much, I don't know. Whenever I get back
to working on my app I might be able to take a look when I pull the latest
code.
On Sun, Aug 23, 2020, 4:23 PM Benjamin Rühl<EMAIL_ADDRESS>wrote:

Small update:
Last time I tried some VS memory profiling but didn't find anything
unexprected. I am not used to debugging memory leaks so I might have made
mistakes here.
Now I did a fresh restart. I cloned your repo again and noticed that the
leak does not occur anymore. Looks like you fixed it by not instantiating
new windows when holding down the keyboard shortcut. Anyway, I removed the
check for existing windows and got the memory leak again. Then I disabled
the ripple effect because @Mgamerz https://github.com/Mgamerz suggested
it might be the reason. But nothing changed. I disabled the cursor
spotlight as well but nothing changed still. I excluded all default styles
and then excluded Adonis UI completely but nothing changed. And by
"excluded Adonis UI" I mean I removed every single usage in all projects
and the project references so that no DLL of Adonis UI can be found in the
output directory.
I am a little confused now. To me it looks like this does not have
anything to do with Adonis UI. Maybe it's an issue of the MDIContainers you
used. Am I missing something here? Please tell me if I did a mistake and
came to the wrong conclusion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/benruehl/adonis-ui/issues/109#issuecomment-678832399,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAU4VFHFVGYQG33WIQ35LD3SCGJH5ANCNFSM4OQR74XQ
.

Closing this because it seems like the issue is not caused by Adonis UI and the ticket didn't receive any attention for quite some time now.

Closing this because it seems like the issue is not caused by Adonis UI and the ticket didn't receive any attention for quite some time now.


Allow using labels as argument to rst

Fixes #448.
This is also a test regarding an object file version bump—the next RGBDS release will use the RGB7 format, whose spec will change during its development.
An attempt has been made in RGBLINK to keep handling the RGB6 format, but the way it's currently implemented has a flaw: RGB6 files can contain the new RPN opcode, and RGBLINK won't complain. In practice, a well-formed RGB6 file will not contain such an opcode, and supporting an extra one shouldn't be doing any harm.
On the other hand, duplicating more of the object-processing code (I have copy-pasted the function because it is likely to change during development of RGB7, especially due to #292) depending on version sounds risky, and I'd rather avoid it.
Thoughts?

Please avoid changing the spec later without changing the version number. That's almost guaranteed to result in issues building.

Personally I think there is no point in supporting old object file formats. We haven't supported older formats for years and nobody has complained. The only reason why you would want to do that is to have a closed source library or something like that, which very niche. Considering how niche the toolchain itself is... I think it's just extra code to maintain for no real benefit.

Please avoid changing the spec later without changing the version number. That's almost guaranteed to result in issues building.

That's not supposed to be an issue, as master is unstable with no real releases; the spec would be considered frozen on the next release (which would include updating of https://rednex.github.io/rgbds/rgbds.5.html)

Personally I think there is no point in supporting old object file formats. We haven't supported older formats for years and nobody has complained. The only reason why you would want to do that is to have a closed source library or something like that, which very niche. Considering how niche the toolchain itself is... I think it's just extra code to maintain for no real benefit.

My rationale for that one was that several tools appear to output RGBDS object files directly, and maybe nobody has complained because RGB6 has been there for a while? (That's how it seems to me, at least). I believe it also makes sense to support the previous version if the added cost is small, so people may have an easier time transitioning between versions.

That's not supposed to be an issue, as master is unstable with no real releases; the spec would be considered frozen on the next release

You know very well this is not the case. People use master all the time, for various good reasons. It's not a good idea to break people's builds because you don't want to make a branch.
If you really need to iterate over the new format (which I doubt — if you already know what it needs, why not define it properly at once?), then add a minor version field, so the iteration doesn't break people's builds. Being forced to rebuild a .o is not a problem. Having the tool crash or output the wrong code (or even worse, go completely haywire) because it's using a different spec to read the .o file even though it matches the expected version number, on the other hand, is a big one.
I don't understand why you refuse to acknowledge this problem, even though you're well aware of it. master has never been unstable here, not for as long as I've been using the tool at least. Even if your approach is right in theory (which I doubt), in practice, that doesn't matter. People's builds will break if you do this.

My rationale for that one was that several tools appear to output RGBDS object files directly, and maybe nobody has complained because RGB6 has been there for a while? (That's how it seems to me, at least). I believe it also makes sense to support the previous version if the added cost is small, so people may have an easier time transitioning between versions.

If this is the case, and the complexity becomes too much to handle, perhaps a tool to convert to the newest object file format version would solve the problem? I've never heard of tools other than rgbasm outputting object files, though.

There is no point in making a new branch for this, as people will just switch to it.
I believe that users of master should be competent enough to know that they are on an unstable track—that's why breakage happens often—and be prepared for some breakage as well. Having to care about every single commit being sound and safe is not feasible (at least not with the current CI), and that's why I suggested making pre-releases, but that idea went nowhere.
To put it simply: RGB7 isn't defined yet. I Do not know yet how it will be designed, both because I don't know which features will be changed, and because I can't plan in advance how they will be implemented, especially in regards to changes required by bug fixes.
Adding a minor version field is basically extending the version number, but it does not solve the problem because it's not automatically increased. Having it be modified by two different PRs at once will happen and adds extra required attention I do not want to have to give for the sake of an unstable track.
I know for a fact that GBTD / GBMB allow outputting .o files. I have no usage statistics on anything though.

There is no point in making a new branch for this, as people will just switch to it.
I believe that users of master should be competent enough to know that they are on an unstable track—that's why breakage happens often—and be prepared for some breakage as well. Having to care about every single commit being sound and safe is not feasible (at least not with the current CI), and that's why I suggested making pre-releases, but that idea went nowhere.

Exactly. If you use non-tagged versions of a tool, expect changes every now and then. That's no reason to break things on purpose on master, but nobody should expect master to be completely stable, and iterations over a complicated design look to me like a valid reason to break master.

Breaking changes are generally OK. If you're using master, you'd sometimes expect it to fail and give you an error because a feature changes. That's fine.
This is not just giving errors. This can result in the wrong code being generated because a pre-existing object file is being read in a different way. The user would have no indication of this, even.
A minor version number solves this problem, causing builds to fail as expected. (Builds failing because the tool updated are generally OK — you just clean and rebuild.) As for the PR issue, it should be easy to check that the version number has been changed in it, and fix conflicts when fixing other merge conflicts.
Or you can just use the commit hash as the minor version number.

Or you can just use the commit hash as the minor version number.

Relying on the git repository to be present isn't a great idea.
In any case, I don't see the benefit of having a minor version number. In practice, the check is to see if the version is exactly the same. Changing the major version number achieves the same effect. Also, we don't really need to worry about running out of space for version numbers in the header...
Personally I think that changing the major number between releases is fine, and that the format should only be locked when a release is tagged. That is, any change after a tagged release implies an increase in the version number of the object file, but you only need to do it once per release.
Also, I think that it is nice to tag a release whenever there are big changes, and modifying the format of the object files counts to me as a big change. Maybe not right away, but after 1-2 weeks.

It seems to me that we're mostly in agreement regarding how to handle the version number, except for the major/minor split.
The issue is that the current version number can't grow past 9. Do you have any better ideas on how to extend it?

The user would have no indication of this, even.

It's possible to add a warning message to RGBLINK to warn users of the unstable object file spec.

The issue is that the current version number can't grow past 9. Do you have any better ideas on how to extend it?

What I currently have in mind is to add an "extended" version number when RGB9 is reached; however, that will be in a while, as we still have RGB7 and RGB8 before that, which should be a couple years.

As for the PR issue, it should be easy to check that the version number has been changed in it, and fix conflicts when fixing other merge conflicts.

My point is when two PRs try to increase the version number to the same value, which will not cause a merge conflict, and would instead require special attention, whenever merging one, to change the number in all others. That means having several such PRs would be tedious, which is either more involvement (and I don't want to have that added) or only one such PR at a time (slowing down development further).

It's possible to add a warning message to RGBLINK to warn users of the unstable object file spec.

Such a warning is non-actionable and not particularly helpful, since it would appear all the time.

If we go by this idea:

Also, I think that it is nice to tag a release whenever there are big changes, and modifying the format of the object files counts to me as a big change. Maybe not right away, but after 1-2 weeks.

...then merging this PR means that a new release is imminent, and RGB7 will be locked in by approx. the end of the month. (This is an acceptable compromise IMO.) Since you have more changes queued, I sincerely doubt two version numbers will last a couple of months, let alone years.

My point is when two PRs try to increase the version number to the same value, which will not cause a merge conflict, and would instead require special attention, whenever merging one, to change the number in all others.

You only have to check the version numbers prior to merging a PR, and only increase it in that particular PR before merging if it has fallen out of date.

Just to make myself clear: I'm not against making multiple changes while merging a series of PRs over the course of several days, nor against making a quick fix a day or two after merging said PRs. But that's not what you propose.
Your proposal consists of the format changing multiple times over an undefined, lengthy period of time, all without updating the version number. This is almost guaranteed to cause issues and it defeats the purpose of having a versioned file format in the first place. All because of the technical debt of having a single-digit version number?

My point is when two PRs try to increase the version number to the same value, which will not cause a merge conflict, and would instead require special attention, whenever merging one, to change the number in all others.

Possible solution: make pre-release version numbers be the number of the most-recently merged PR.

I've done that. If everyone is happy with this, I will merge this and start working on other modifications to the object format.

Awesome, thank you! I will start working on fixing @ expressions being incorrectly computed by RGBLINK, which requires passing the value of PC in expressions.


Autostart with PM not working

What a cool piece of software.
After a fresh install yesterday and updated buster to december version, my raspberry runs into desktop login screen after having started teleframe. Any ideas?

Hey,
what is the output for pm2 status?

Hey again, after another reboot everything works. I'll try another few times. Thanks a load.


syslog: dial udp: lookup logs3.papertrailapp.com: Try again

It seems like my logspout container is always dead. It only ever seems to run for about 5 minutes before exiting.
I'm seeing logs delivered to papertrail during this time, so it seems to be correctly setup. It looks like a network hiccup which kills the container. Shouldn't it just retry when it fails to connect?

@intellix did you find a fix for this?
Also, have you seen #150?

I think this has been fixed for the most part in v3. Please try it out and report back.


Datetime bug

#@maigfrga @cormacp
This is a workaround for a problem I've encountered converting strings to datetimes. The current implementation works fine as long as the string is in the form YYYY-MM-DD HH:MM:SS e.g. 2017-05-10 16:43:53
However, if the string is in a format where microseconds or timezone are included e.g. 2017-05-10 16:43:53.197842+00:00, then the method throws a Value error: ValueError: unconverted data remains: .197842+00:00
This MR limits the length of the string to 19 characters, the length of YYYY-MM-DD HH:MM:SS, which prevents the error being thrown but there might be a much better way to do this so I'm open to ideas if you have any.

:+1:

👍


Labels are being dropped between the get-sli and the get-sli.done keptn events

Describe the bug

Labels are being dropped between the get-sli and the get-sli.done keptn events.
To Reproduce

Add a label to a start evaluation event and then review the sli done event.
Expected behavior
The labels in the event are not dropped.

This is also already mentioned in https://github.com/keptn/keptn/issues/1151.
Anyway, we should switch the service to the latest go-utils and use the utility functions provided in there to process cloud-events. This takes care of sending labels.

@johannes-b this has been fixed in your PR, so we can close this issue, right?


Assume robots are allowed if robots.txt returns 410 (Gone)

While using supercrawler, I noticed that some sites (e.g. http://zompist.com) return a 410 status for their robots.txt. Google indexes that page, so I think supercrawler should be able to crawl it as well.

Many thanks, I have published the change.


error! not finding Grape::Entity if called in rescue_from block

Example:
class Api::Post < Grape::API
  rescue_from StandardError do
    error!('Message' 404)
  end

  resource :post do
    desc '' do
      failure [[404, 'Not found', Api::Entity::Error]]
    end

    get :working_example do
      error!('Message' 404)
    end

    get :not_working_example do
      raise StandardError
    end
  end
end

As I understood, calling error! from rescue_from results being in context of Grape::Middleware::Error, thus env['api.endpoint'].status is nil. While calling error! from get do ; end works just fine because of the env['api.endpoint'].status being properly set already in Grape::DSL::InsideRoute. So in the first case Grape is not able to find the Entity responsible for the error (see https://github.com/intridea/grape/blob/master/lib/grape/error_formatter/base.rb#L42).
Can anyone confirm that it is an expected behavior?

The workaround I'm currently using is to use with options, e.g. error!({ message: 'Message', with: API::Error}, 404).


Fix formatting and linting errors from previous merge

#568 had some prettier errors, which showed up in a failed build. I discovered that my local version of prettier or prettier-ruby was outdated, and that's how the commit slipped through without hooks catching it. I don't know why checks in GitHub didn't fail, though - I'll dig into that. But for now, this PR should get master building again 🤞

It looks like checks didn't fail because they didn't run the tests for #568.

Oooooohhhhh because I forgot that we are PR'ing from branches in artsy/convection, not from forks. Closing this and re-opening from a branch in this repo.


Use google-auth-library-java for oauth

Depends on https://github.com/google/google-auth-library-java/issues/2 and having a public maven artifcat

This is already implemented.


IPv6 capable bootstrappers

Currently all bootstrap peers seem to be IPv4 only. I think there should be at least some IPv6 capable bootstrappers to make IPv6-only peers able to connect to the network.
This might not be very high priority issue, but definitely something I think should be fixed eventually.

Word! We definitely want IPv6 everywhere and are tracking the progress in ipfs/infrastructure#88.
I'm closing this request in the meantime since this repo is for specific requests which are immediately actionable and don't need further planning or discussion (see readme)


Content Security Policy prevents render when reaching out to unpkg.com

pdfjs requires the workerSrc to be set at runtime. The current implemenation sets this to a CDN (https://unpkg.com). When a content security policy is defined this logic can fail when the CDN is not defined in the allow list of the CSP. It appears that work was started to eliminate the usage of the CDN but was never completed.   The prerelease script executes copy-worker.mjs to the dist folder but it is never used to set the workerSrc.  We were able to mitigate this on our end by patching the code but this is a maintaince nightmare. I tried fixing locally and it appears to work but will need more eyeballs. I am not a vite and/or webpack guru.  Assistance would be great to get this resolved. I will send a PR shortly with the changes I have thus far.

The same issue is also faced when trying to load pdf in offline mode. Since we are using cdn, the worker does not load in offline mode


Correction for raw affiliation Muséum national d’Histoire naturelle, UMR 7207, CP38, 8, rue Buffon 75231, Paris, Cedex 05, France

Correction needed for raw affiliation Muséum national d’Histoire naturelle, UMR 7207, CP38, 8, rue Buffon 75231, Paris, Cedex 05, France
raw_affiliation_name: Muséum national d’Histoire naturelle, UMR 7207, CP38, 8, rue Buffon 75231, Paris, Cedex 05, France
new_rors: 03wkt5x30;05ax2x637
previous_rors: 03wkt5x30
works_examples: W4388084528;W4389726577
contact: 9b44900643bf1c3ad6361f669c4acef4:b701e875b9cdb31aeb41acf565 @ sorbonne-universite.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


Strange, negative Ranks shown before matches are played.

Reminder about this, moving to DataSync repo issue.
https://github.com/orange-alliance/the-orange-alliance/issues/226
Looks like it's still happening, possibly also correlated with wrong team lists being updated too. e.g.,  Rankings at this event:
https://theorangealliance.org/events/1819-VA-QTVA6B

See https://github.com/orange-alliance/TOA-DataSync/commit/e6be0d74d28d3cba284450e573d60b76bc7c2ded

Thanks. Is there a way to double check the teamlist in the DataSync too? I'm seeing events on TOA that have the same team listed twice, and events on TOA that have teams listed that don't play in any matches. This seems to be a scorekeeper app issue, where scorekeepers add teams but then later don't use them, but the teams still show up in the teamlist when the archive is exported. It would be great if the DataSync could clean the teamlist to have the teamlist (and rankings?) only show teams that actually appear in the matchlist.
Let me know if I should open a new issue for this.

Sure.  I'll make it so that when the auto sync first starts, it purges and reuploads the teams list.

Great! Thanks!
So now, last question: I think this will prevent errors with teamlists in future events. Is there a way to correct teamlists that have problems that are already on TOA (besides having to manually correct things in the db)? Maybe once a week, run a script that regenerates db teamlists for all events based on matchlists, so any errors will get fixed?
Again, this is probably the wrong place for this discussion, but I don't know where this question should be asked. Thx.

Spectacular!  Thanks!  How often (and when) does the autosync run?

I'm talking about the auto sync in the DataSync.  I don't know off of the top of my head at what interval the auto sync runs. I'll have to discuss with other about the team list rebuilding script.

OK. Thanks. It would probably be a good idea to have the entire db reupload once a week or so, so that problems from all sources get fixed without manual interventions (e.g., scorekeeper SW updates like reporting high scores in rankings, teamlist issues, etc.). I dunno if this is happening already or has been discussed.

The EventParticipant list will now get purged and reuploaded when the match schedule is posted.


py.test errors using travis

Since hitch has been removed, I am trying to run my tests with py.test for a new project.
The project uses travis for ci.
There is a default travis config file in the repo .travis.yml -- however I get an error telling me that it needs a script key.
Please override the script: key in your .travis.yml to run tests.
After some research I found an article explaining that there is no sensible default for it so it has to be part of the file: https://github.com/travis-ci/travis-ci/issues/2870
What is the suggestion to put in the script part of the travis file when using py.test?
Another challenge I face with that is that I have a test.txt requirements file -- so travis needs to install these packages in order for the tests to work. Right now I get an error:
E   ImportError: No module named 'test_plus'

(since it uses the local settings by default which in my case do not have django-test-plus included -- in my case they are in requirements/test.txt)
Do you have any suggestions, hints or directions?
They are very welcome. :)
Best, Eraldo

@Eraldo  - To get around your second issue, what I changed on travis.yaml
install:
  - pip install -r requirements/test.txt

separating out configuration settings to its own file, ie. production, etc /config/production, config/staging config/testing.
and in app determining locations include
import os
if 'TRAVIS' in os.environ:
     select testing configurations, etc.

@Eraldo, have the issue been resolved?

Yes
I did not test the mentioned solution. However the issue is resolved.


Feat: bundle outputs

Creating in Draft form to get early feedback on approach...
Currently, this PR adds:

functionality to parse a new outputs section in a porter manifest (Note: the current implementation requires a mixin-specific step/action output to be declared before it can be exposed/used as a bundle-level output.)
functionality to place output values under /cnab/app/outputs in the execution environment, per the CNAB Spec (outputs are currently written only when added under the new outputs section and the optional applyTo specification doesn't conflict)
functionality to place these same outputs under the local/user's $PORTER_HOME/outputs/<bundle name> directory, assuming the default Docker driver is being used
cli commands: porter outputs list -b <bundle> to list outputs of a bundle and porter output show -b <bundle> -n <name> to show an output's info/value

TODO:

[x] add a cli command that users can invoke to print outputs from the corresponding local file (question around AC posed in https://github.com/deislabs/porter/issues/344#issuecomment-507460567)
[x] add unit tests for logic added in run.go
[ ] docker driver bind mount refactor/units
[ ] update the base porters schema template to include the outputs section
[ ] add/update docs

In the most recent commit, I went ahead and added the cli commands mentioned/proposed in https://github.com/deislabs/porter/issues/344#issuecomment-507460567

Putting into 'ready for review' while I finish up unit tests...

Ok, latest commits are up intending to address all feedback.
Lemme know if there are any outstanding items; otherwise I/we can squash commits and merge when ready.


Update docs with PHP file config

Symfony 6 will recommend the use of PHP files instead of YAML for config, so it's convenient to show users how to perform PHP config from now on.

LGTM
Thanks @TavoNiievez !


chore(docs): tried to document the --base-path option better

As noted, the option could likely be more explicite in what it does
Resolves https://github.com/maplibre/martin/issues/1415

thx!


Azure pipeline fails on IPInstrument

See #69
The pipeline fails to create docstrings for classes which have IPInstrument as base, since https://qcodes.github.io/Qcodes/api/instrument/index.html
doesn't have ip.IPInstrument
Steps to reproduce:

Create a class with IPInstrument as base
Create a pull request

@jenshnielsen @WilliamHPNielsen


Batt functions for reopt sizing

Pull Request Template
Description
Add new function  Reopt_size_standalone_battery_params to assist with dGen PV and battery sizing using the battery compute module. Also update URDB Python call to version 8.
SAM equations functions for this change. Pairs with SSC PR https://github.com/NREL/ssc/pull/1022 and PySAM PR https://github.com/NREL/pysam/pull/149
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Do we want to consider making this REopt call available in the SAM UI for Standalone Battery configurations (and Generic Battery if that is possible)? That would be a separate effort and pull request for the Fall 2023 release or later.

That's a good idea, I'll put that on the agenda for next week.


Implement util::misc::signed_msg_hash()

A simple utility function to hash messages using Bitcoin's message signing format, with the Bitcoin Signed Message: prefix.

Wasn't sure whether this should return a sha256d::Hash, a secp256k1::Message, or possibly just a simple [u8; 32]. I ended up going with sha256d::Hash, let me know if you prefer something different.


Text type missing in ecto.schema documentation

Ecto version (mix deps): 3.3.4
Hi people,
I have noticed the text sql type is missing in ecto.schema documentation.
Is that on purpose or just an oversight ?
Thanks :)

:string type already covers that! Note, you'd use :string in your Ecto schema but you're free to use :text in your migration.


Switch to indexed applicatives

The original qtraverse wasn't powerful enough to implement
qfoldMapDefault. Using an indexed applicative makes it so.
Add qfoldMapDefault.
Adjust the type of traverse_ to match.
Remove the surprising QFunctor superclass of QFoldable.

Closes #10

@echatav , here's my first little pull request. I have one or two more generalities to put in before I start porting things over from type-aligned (with some performance tweaks).


question: Debug test/extensions/filters/http/ext_proc/mutation_utils_test.cc

Title: Question about https://github.com/envoyproxy/envoy/blob/b96ae4314b675dda73599b2985daccd757c1a165/tools/vscode/README.md?plain=1#L50-L64
Description:
I would like to use vscode to debug the tests in test/extensions/filters/http/ext_proc/mutation_utils_test.cc.
How to generate debug config using the python script?
Is this command correct? tools/vscode/generate_debug_config.py //test/extensions/filters/http/ext_proc/mutation_utils_test:my-target

It seems that this command works:
tools/vscode/generate_debug_config.py //test/extensions/filters/http/ext_proc:mutation_utils_test --debugger lldb


Multicast must assign sendAs and receiveAs permissions to the registrant

Whenever a participant becomes part of a multicast group, the multicast participant must assign "sendAs" and "receiveAs" for the multicast address.

see #207


Chart fail in 0.38.0

RN Version：0.38.0
Chart Version：1.0.8-beta
When I run  chart component in 0.37.0,it work well.But run in 0.38.0,when I set the chart height,it show the error:
View was rendered with explicitly set width/height but with a 0 flexBasis. (This might be fixed by changing flex: to flexGrow:) View: <RCTShadowView: 0x6080001ba940; viewName: RCTView; reactTag: 253; frame: {{0, 0}, {315, 0}}>

code is:
 <View style={styles.subContainer}>
                <View style={styles.upView}>
                    <Chart
                        style={styles.chart}
                        data={this._fetchData()}
                        verticalGridStep={4}
                        type="line"
                        showDataPoint={true}
                        color={'#5FC3E5'}
                        gridLineWidth={2}
                        showXAxisLabels={true}
                        gridColor={'#DCDCDC'}
                        axisColor={'#969696'}
                        xAxisHeight={15}
                        xAxisTransform={()=>(['aaaa','bbbb'])}
                    />
                </View>
                <View style={styles.bottomView}>
                    <Text>PushPage2</Text>
                </View>
            </View>

style:

const styles = StyleSheet.create({
    container: {
        flex: 1,
        justifyContent: 'center',
        alignItems: 'center',
    },
    subContainer:{
        flex:1,
    },
    upView:{
        flex:1
    },
    bottomView:{
        flex:1,
        backgroundColor:'gray'
    },
    chart: {
        flex:1,
        width:200,
        height:200,
    }
});

When I replace Chart  with Text ,it work well
I am so confuse to this error,could someone tell me how to fix it.Thx!

You have to edit the Chart.js. Replace line 13, flex:1 by flexGrow: 1 and rebundle the package

@lin493369 https://github.com/tomauty/react-native-chart/issues/161

Replacing flex with flexGrow didn't solve the issue for me - instead I saw @robcalcroft's code and noticed that he deleted the flex property in line 13. Changing that line fixed it for me.

As a generic FYI — I am no longer able to maintain this library. I recommend checking out victory-native as it's much more maintained.


GPT-J integration

Huggingface transformers supports GPT-J. This pull request will add GPT-J support to the softtuning.

I have merged @harubaru 's PR as I'm fairly sure this one is missing a comma in the EXTRA_ALLOWED_MODELS list. Otherwise it's the same change.

Same change. Unsure if copy from my build or similar idea. Either way, handy to have it in the original. Code is tested to work with Huggingface in the master branch, not in Finetuneanon's version (which seems to have an alternative GPT-Neo 6B). Might integrate this in KoboldAI.


Declared support for Dart 2; fixed analysis warnings; upgraded dependencies

Thanks for this great package!

Thanks! Published it.

Awesome, thanks!


Attestation aggregation

We should try to aggregate attestations according to : https://github.com/ethereum/eth2.0-specs/blob/v0.8.3/specs/networking/p2p-interface.md#interop-3
and
https://github.com/ethereum/eth2.0-specs/issues/1331

closing in favor of #533


Module Settings Missing 0.11.13

After updating to 0.11.13 the module settings button disappeared from the Configuration Settings in Foundry, when I downgraded to 0.11.12 its back

That normally only happens if the module fails to load. Check your console after loading in and look for errors.

Even if all the compendiums are still there?

Yes

If a dependent module doesn't load it may be causing CPR to also fail to load. Please provide your console log.

https://paste.ofcode.org/3btMuGQC3UMTXqF5PHQKbAc

You may want to downgrade your Midi-Qol version. I'm don't see anything obvious that would be causing it to not load. The Midi-Qol Discord server may be better able to help you track down those Midi-Qol errors.

Strange because the the version before 0.11.13 works, but I will check with Midi


Marathon, docker, consul. containerPort = hostPort = 0 for udp and tcp

I would like to be able to do this with docker bridge :
      "portMappings": [
        { "containerPort": 0, "hostPort": 0, "protocol": "all" },
      ]

Consul requires same udp and tcp port for container and host.
I use -advertise switch of consul.
https://consul.io/docs/agent/options.html

@tnachen I like your idea of named ports.

@amiorin, did you see issue https://github.com/mesosphere/marathon/issues/751?
Allowing the ports to be named could help in other circumstances, but I don't see how it would solve this specific problem.  What is the docker run command you would use to run the consul image in bridged networking mode at the command line?

@ConnorDoyle 40000 (ssh) and 40001 (consul) are used only in development mode.
I don't use marathon during development. I start the container manually with the docker command.
In production everything is supposed to be dynamic.
docker run \
  -d \
  --net bridge \
  -p <IP_ADDRESS>:40000:22 \
  -p <IP_ADDRESS>:40001:40001/tcp \
  -p <IP_ADDRESS>:40001:40001/udp \
  -e PORT0=40000 \
  -e PORT1=40001 \
  container

Hello,
We have the same requirement where containerPort and hostPort can be set to 0 so that both are dynamically generated and are mapped. Currently setting both container and host ports to 0 causes an error in submitting the tasks. I can submit a patch for it if the issue isn't being looked into.
Thanks!

@sanjana-bhat
That would be nice.

@amiorin
Can you please review the changes? https://github.com/mesosphere/marathon/pull/1468

The commit https://github.com/mesosphere/marathon/commit/445dc4e966eaea27634b0518d6b80e7a68ab009f does not fix the problem of this issue. The issue asks for dynamically chosen ports with tcp and udp in parallel.
E.g. I have a Kerberos KDC here which wants to provide services on port X with tcp and udp. This cannot be expressed in Marathon.


Can't download PDF Invoice

Login to rider.uber.com
Asks me to give my location, choose skip down the bottom
Go to My Trips
Click on a trip
Click on Save Invoice
Text changes to Loading and spins forever

Tried this in Firefox, Chrome, IE10.
Receipt is no good, need invoice.

@dpetzer Sorry, this has nothing to do with https://rider.uber.com
I suggest following the instructions in the link to file a support request. https://help.uber.com/riders/article/how-to-contact-support?nodeId=4c69afef-5739-4842-9e98-ed0087b873db

@twojtasz you are a champion.


Python controller to support writing zcl attributes

Python controller to support writing zcl attributes thru IM. This is required for TE3 to verify ZCL write functionality.

https://github.com/project-chip/connectedhomeip/issues/7563 dup


Proxy Support

Please add a function to use a proxy to connect to Azure Monitor REST API.

Can you explain more?

The Azure Monitor data source is unable to directly connect to https://api.applicationinsights.io and https://management.azure.com, because my Grafana is installed on a server behind a firewall. The issue is usually resolved by setting the environment variable "http_proxy=:" on the server but this setting isn't being picked up by azure-monitor-datasource.
Another alternative would be to add a "proxy" field so users can manually set the proxy.

@srudos did you try to use https_proxy variable and not http_proxy?


disableShowClear option appear to not be working

Hello,
I discovered that the disableShowClear options appears to not be working,
Rather than create an issue I created a pull request, https://github.com/ellipticaljs/paper-autocomplete/pull/48
Hope this is okay,
thanks,
vidhill

Closed by #48


Fix Glacier & Nukie planet.

About the PR
This is a mix of my upstream PR
https://github.com/space-wizards/space-station-14/pull/12683 and cherry-picked https://github.com/space-wizards/space-station-14/pull/12650. Together, this should allow Glacier and the Nukie planet to load again with atmosphere and parallax. An explanation is on the upstream PR.
Screenshots

Changelog

:cl:

fix: Glacier station has been placed back into the atmosphere.

seems to fail tests, hmmm

i might try this when i merge upstream tomorrow because it might depend on some other stuff

That's quite possible. All tests passed on upstream. Weird.

uhhh i'll wait and see what upstream is doing, the glacier update isn't even done yet

i merged upstream, they have some planetmos stuff now, see if that is even needed

i've merged upstream, see if glacier can be fixed now

The saved map prototype is still being overwritten at this stage. We need https://github.com/space-wizards/RobustToolbox/pull/3511 or maybe https://github.com/space-wizards/RobustToolbox/pull/3516 due to https://github.com/space-wizards/RobustToolbox/issues/3523.


Connecting up Phase 1 Refactor Work to Allow Passage Through to Categorization Page

This PR represents a kind of glue between the two phases of our store refactor for the annotation tool. The overall goal was to produce a version of the tool that is working up to the categorization page.
As such there are a number of varied tasks which are described in the issues below. Generally, they cover:

The addition of store fields/methods that were not added during the initial refactor for various reasons
Nominal refactor changes like name changes
Ensuring proper initialization of store fields and loading of the data table/data dictionary
Further adapting navigation/page accessibility code
Updating the pages and their components as needed to ensure the new workflow functions (upload table -> upload dictionary (optional, but not before data table upload) -> go to categorization page, etc.)
Components functioning at least to the point where they don't break the app when loaded on their respective page.

The specific issues covered are listed in #251, but the relevant ones are re-listed below for convenience.

[ ] #300
[ ] #307
[ ] #308
[ ] #313
[ ] #314
[ ] #315

There remain several bugs, the consequence of which mostly do not interfere with the general goal of a working app up to the categorization page. They are:

[ ] #316
[ ] #317
[ ] #320

@surchs Standby for check/fix on failed component test(s)

@surchs Could you put an eye on https://github.com/neurobagel/annotation_tool/blob/jarmoza-308/cypress/component/category-select-table.cy.js ? I've been scratching my head as to why this is failing.

Glad you resolved the issue @jarmoza, sorry it took me so long to check it out. Would you mind pushing your fix?

This PR will be closed without merge all tasks in #251 for phase 1 refactor are complete.

I am closing this now that the Phase 1 refactor work has been completed by PRs separating (and improving upon) this one - last one is #330 for reference.


Changing between material3 dark and light themes with different TextStyles raises Exception: AnimatedTheme(duration: 200ms, dirty, state: _AnimatedThemeState#f6b46(ticker active, ThemeDataTween(ThemeData#ee39f → ThemeData#99352)))

Steps to Reproduce

Execute flutter run on the Counter app code sample below
Click increment. The app will crash
Expected results:
Switching dynamically between light and dark themes

Actual results:
═══════ Exception caught by widgets library ═══════════════════════════════════ The following assertion was thrown building AnimatedTheme(duration: 200ms, dirty, state: _AnimatedThemeState#f6b46(ticker active, ThemeDataTween(ThemeData#ee39f → ThemeData#99352))): 'package:flutter/src/painting/text_style.dart': Failed assertion: line 1076 pos 12: 'a == null || b == null || a.inherit == b.inherit': is not true. package:flutter/…/painting/text_style.dart:1076
This happens when using themeMode to switch between light and dark themes, trying to switch between different themes in theme attribute will work.

Sample Code (Using the counter app)
import 'package:flutter/material.dart';

late ValueNotifier<ThemeMode> preferedTheme;

void main() {
  String theme = 'system';
  preferedTheme = ValueNotifier(theme == "dark" ? ThemeMode.dark : ThemeMode.light);
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return ValueListenableBuilder<ThemeMode>(
      valueListenable: preferedTheme,
      builder: (_, themeMode, __) {
        debugPrint("themeMode: $themeMode");
      return MaterialApp(
      title: 'Flutter Demo',
      themeMode: themeMode,
      theme: ThemeData(
        useMaterial3: true,
        textTheme: Theme.of(context).textTheme.copyWith(displayLarge: const TextStyle(fontSize: 76)
        ),
      ),
      darkTheme: ThemeData(
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
      },);
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {

    //Change theme mode
    preferedTheme.value = preferedTheme.value == ThemeMode.dark ? ThemeMode.light : ThemeMode.dark;

    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(

        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

Logs
                    ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY
╞═══════════════════════════════════════════════════════════
                    The following assertion was thrown building AnimatedTheme(duration: 200ms, dirty,
state:
                    _AnimatedThemeState#d8295(ticker active, ThemeDataTween(ThemeData#685d2 →
ThemeData#2c158))):
                    'package:flutter/src/painting/text_style.dart': Failed assertion: line 1076 pos 12:
'a == null || b
                    == null || a.inherit == b.inherit': is not true.

                    Either the assertion indicates an error in the framework itself, or we should provide
substantially
                    more information in this error message to help you determine and fix the underlying
cause.
                    In either case, please report this assertion by filing a bug on GitHub:
                      https://github.com/flutter/flutter/issues/new?template=2_bug.md

                    The relevant error-causing widget was:
                      MaterialApp
MaterialApp:file:///C:/Users/mmahg_000/playground/material3bug/lib/main.dart:21:14

                    When the exception was thrown, this was the stack:
                    #2      TextStyle.lerp (package:flutter/src/painting/text_style.dart:1076:12)
                    #3      TextTheme.lerp (package:flutter/src/material/text_theme.dart:617:32)
                    #4      ThemeData.lerp (package:flutter/src/material/theme_data.dart:1993:28)
                    #5      ThemeDataTween.lerp (package:flutter/src/material/theme.dart:185:41)
                    #6      Tween.transform (package:flutter/src/animation/tween.dart:329:12)
                    #7      Animatable.evaluate (package:flutter/src/animation/tween.dart:53:46)
                    #8      _AnimatedThemeState.build (package:flutter/src/material/theme.dart:240:20)
                    #9      StatefulElement.build (package:flutter/src/widgets/framework.dart:4975:27)
                    #10     ComponentElement.performRebuild
(package:flutter/src/widgets/framework.dart:4861:15)
                    #11     StatefulElement.performRebuild
(package:flutter/src/widgets/framework.dart:5033:11)
                    #12     Element.rebuild (package:flutter/src/widgets/framework.dart:4587:5)
                    #13     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2667:19)
                    #14     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:882:21)
                    #15     RendererBinding._handlePersistentFrameCallback
(package:flutter/src/rendering/binding.dart:378:5)
                    #16     SchedulerBinding._invokeFrameCallback
(package:flutter/src/scheduler/binding.dart:1172:15)
                    #17     SchedulerBinding.handleDrawFrame
(package:flutter/src/scheduler/binding.dart:1101:9)
                    #18     SchedulerBinding._handleDrawFrame
(package:flutter/src/scheduler/binding.dart:1012:5)
                    #19     _invoke (dart:ui/hooks.dart:148:13)
                    #20     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:318:5)
                    #21     _drawFrame (dart:ui/hooks.dart:115:31)
                    (elided 2 frames from class _AssertionError)

════════════════════════════════════════════════════════════════════════════════════════════════════

❯ flutter analyze
Analyzing material3bug...
No issues found! (ran in 8.0s)

flutter doctor -v
[✓] Flutter (Channel master, 3.1.0-0.0.pre.1105, on Microsoft Windows [Version 10.0.19043.1766], locale
    en-US)
    • Flutter version 3.1.0-0.0.pre.1105 at C:\Users\mmahg_000\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1006f9cf70 (3 weeks ago), 2022-06-04 16:43:05 -0400
    • Engine revision edc0f9d605
    • Dart version 2.18.0 (build 2.18.0-170.0.dev)
    • DevTools version 2.14.0

Checking Android licenses is taking an unexpectedly long time...[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\mmahg_000\Android\adt-bundle\sdk
    • Platform android-31, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\mmahg_000\Android\adt-bundle\sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2022 17.0.4)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.0.32014.148
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[✓] VS Code (version 1.68.1)
    • VS Code at C:\Users\mmahg_000\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.10.1

[✓] VS Code, 64-bit edition (version 1.63.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.10.1

[✓] Connected device (4 available)
    • ONEPLUS A5010 (mobile) • 74b5523b • android-arm64  • Android 10 (API 29)
    • Windows (desktop)      • windows  • windows-x64    • Microsoft Windows [Version 10.0.19043.1766]
    • Chrome (web)           • chrome   • web-javascript • Google Chrome 102.0.5005.115
    • Edge (web)             • edge     • web-javascript • Microsoft Edge 102.0.1245.33

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

https://user-images.githubusercontent.com/436503/175790469-8e7c190d-a614-4ad8-8547-17760c58b0ac.mp4

Duplication of #103864

@rydmike I opt to use similar textStyles for both dark and light modes

Yes that avoids the issue. I don't know why the framework could for the conditions where it now throws an assert error since it cannot lerp animated between them, instead just swap between them without any animation. For the cases that this situation applies to, it would still be better than throwing an error and crashing.
@xu-baolin Any thoughts on when we might see a fix for this issue land? I know you made a fix proposal PR, but it was rejected for "reasons".


prune unused icons

merging this into odysee may make rebase easier.

While you're messing with icons and such, can you take a look at this stale branch and see if it can be deleted or if it needs to be merged or stashed?
https://github.com/lbryio/lbry-desktop/tree/icon-wildWest