Quick fix import not working

Issue Type: Bug
Nothing was changed only restarted the notebook. At the moment I have issue with quick fix import when you add some exported interface I don't have a quick-fix helper for adding interface import!
VS Code version: Code 1.48.2 (a0479759d6e9ea56afa657e454193f72aef85bd0, 2020-08-25T10:09:08.021Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 8, 15

Memory (System)
8.00GB (0.22GB free)

Process Argv
-psn_0_57358

Screen Reader
no

VM
0%

Extensions (21)

Extension
Author (truncated)
Version

jest-snippets
and
1.8.0

gitstash
art
3.2.2

npm-intellisense
chr
1.3.1

path-intellisense
chr
2.3.0

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
2.1.8

githistory
don
0.6.10

xml
Dot
2.5.1

es7-react-js-snippets
dsz
3.0.0

gitlens
eam
10.2.2

vsc-material-theme
Equ
33.0.0

vsc-material-theme-icons
equ
1.2.0

prettier-vscode
esb
5.7.1

git-graph
mhu
1.26.0

vscode-docker
ms-
1.6.0

material-icon-theme
PKi
4.3.0

vscode-sass-format
sas
1.1.7

sass-indented
syl
1.8.11

vscodeintellicode
Vis
1.2.10

quokka-vscode
Wal
1.0.321

wallaby-vscode
Wal
1.0.244

(1 theme extensions excluded)

So it's real BUG I have added a mask in the tsconfig.json at the property include - and everything starts to work after I sometimes I removed and still works. I restart notebook - works!

it is not a solution because some exported classes don't catch by autocompleting and quick-fix

Please share steps to reproduce the problem.
/needsMoreInfo

@mjbvz Hi, here is the test repo for reproducing. https://github.com/Alexzanderk/vscode_contex_menu

@mjbvz any updates?

This is expect because you've defined separate projects: one for test that does not include a and one for app that does.
Either restructure your projects or use project references


Fix issue 180 : Use pyccel for vector-vector dot product

Added 6 kernels for the different possible inner product (1/2/3 d and real/complex)
Updated the call in stencil according to this changes
Beware that for the complex version, the complex conjugate is on the first variable as this was the case in the previous implementation and swapping that would break a lot of other things. This will need to be updated when everything is changed to use conjugate on the first variable.

We need to add OpenMP pragmas to handle the multithreading case otherwise, it will be slow when we use hybrid parallelization

Good point! I suppose that we can start by adding the following instruction before our nested loops:
#$ omp parallel for collapse(N) reduction(+ : result)

where N is the number of dimensions. (In the 1D case the clause collapse(1) is redundant.)

We need to add OpenMP pragmas to handle the multithreading case otherwise, it will be slow when we use hybrid parallelization

Good point! I suppose that we can start by adding the following instruction before our nested loops:
#$ omp parallel for collapse(N) reduction(+ : result)

where N is the number of dimensions. (In the 1D case the clause collapse(1) is redundant.)

We also need to specify private and shared variables to get better performance.

We need to add OpenMP pragmas to handle the multithreading case otherwise, it will be slow when we use hybrid parallelization

Good point! I suppose that we can start by adding the following instruction before our nested loops:
#$ omp parallel for collapse(N) reduction(+ : result)

where N is the number of dimensions. (In the 1D case the clause collapse(1) is redundant.)

We also need to specify private and shared variables to get better performance.

Then, in 3D:
#$ omp parallel private(i0, i1, i2) shared(result)
#$ omp for collapse(3) reduction(+ : result)

We need to add OpenMP pragmas to handle the multithreading case otherwise, it will be slow when we use hybrid parallelization

Good point! I suppose that we can start by adding the following instruction before our nested loops:
#$ omp parallel for collapse(N) reduction(+ : result)

where N is the number of dimensions. (In the 1D case the clause collapse(1) is redundant.)

We also need to specify private and shared variables to get better performance.

Then, in 3D:
#$ omp parallel private(i0, i1, i2) shared(result)
#$ omp for collapse(3) reduction(+ : result)

It would be like this in 3D
 #$ omp parallel default(private) firstprivate( pads0, pads1, pads2, shift0, shift1 shift2, shape0, shape1, shape2) shared(result, v1, v2)
 #$ omp for collapse(3) reduction(+ : result)

It would be like this in 3D
 #$ omp parallel default(private) firstprivate( pads0, pads1, pads2, shift0, shift1 shift2, shape0, shape1, shape2) shared(result, v1, v2)
 #$ omp for collapse(3) reduction(+ : result)

Pyccel is complaining about result that don't have a specified type :
2019 |     !$omp &shared(result, v1, v2)
     |
Error: Symbol ‘result’ at (1) has no IMPLICIT type; did you mean ‘result_0001’?
/home/cato/Code/psydac/psydac/linalg/__pyccel__/kernels.f90:1970:72:

Also the fact that the type of result is not specified create an issue on the reduction :
 1869 |     !$omp do collapse(1) reduction(+: result)
      |
Error: !$OMP DECLARE REDUCTION + not found for type UNKNOWN at (1)

Also the fact that the type of result is not specified create an issue on the reduction :
 1869 |     !$omp do collapse(1) reduction(+: result)
      |
Error: !$OMP DECLARE REDUCTION + not found for type UNKNOWN at (1)

This error is caused by the first one, you do not need to worry about it.

It would be like this in 3D
 #$ omp parallel default(private) firstprivate( pads0, pads1, pads2, shift0, shift1 shift2, shape0, shape1, shape2) shared(result, v1, v2)
 #$ omp for collapse(3) reduction(+ : result)

When I try to add the openMP instruction and the flag --openmp in the pyccel command, pyccel is complaining about result that don't have a specified type :
2019 |     !$omp &shared(result, v1, v2)
     |
Error: Symbol ‘result’ at (1) has no IMPLICIT type; did you mean ‘result_0001’?
/home/cato/Code/psydac/psydac/linalg/__pyccel__/kernels.f90:1970:72:

Also the fact that the type of result is not specified create an issue on the reduction :
 1869 |     !$omp do collapse(1) reduction(+: result)
      |
Error: !$OMP DECLARE REDUCTION + not found for type UNKNOWN at (1)

This is related to this issue: https://github.com/pyccel/pyccel/issues/590
The contents of the clause are not parsed through pyccel so any variables that are renamed are not renamed in the clause. result is a keyword in Fortran so it gets renamed before printing. This is then causing the error you see here. The code will compile if you use a different variable name


testing: integration testing checks in CI for linux and OS X

Extracting out the integration tests to a separate job from the unit tests.
Also cleaning up after the fix from https://github.com/envoyproxy/envoy-mobile/pull/1401. The changes here revert the os check in the JniLibrary and instead relies on bazel hackery only.
Signed-off-by: Alan Chiu<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: testing: integration testing checks in CI for linux and OS X
Risk Level: low
Testing: ci/local
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

java_tests_new and kotlin_tests_new are now named java_tests_osx and kotlin_tests_osx respectively.


"ch -v" doesn't complain even if chakracore cannot be loaded?

When running ch -v, it shows version of ch and chakracore which is expected. But it doesn't complain if chakracore is unavailable to load and just output version of ch. Do we need error message to imply that chakracore cannot be loaded?

Probably a good idea but not a huge priority, I think.


logs(node): add logs to IsInit func to report errors

I was playing around with some stuff and accidentally broke config formatting and the node didn't tell me any meaningful message and this PR should fix this,

Logging for such startup errors looks ugly(timestamps and other logs verbosity) and instead we should probably just fmt.Println, but this is other concern.


pedantic fails at operator overload

Hey there,
I have an issue when decorating a function with @pedantic that overloads the python in-operator.
Example:
@pedantic
def __contains__(self, item:str) -> bool:
  if item in self.my_string:
    return True
  else:
    return False

I override contains to enable following syntax:
my_text = MyTextObject('abcd')
if 'ab' in my_text -> True # do something

But when I decorate contains with @pedantic and call it, then I get the error-message:
assert args_without_self == (), f'Use kwargs when you call {func.__name__}! {args_without_self}'
AssertionError: Use kwargs when you call __contains__! ('ab',)

I guess, because the python in-operator doesnt call contains with explicit function arguments? Is it a problem with your implementation or is it Python?
full code snippet:
from pedantic import pedantic
class MyTextObject:
    def __init__(self, text):
        self.my_string = text

    @pedantic
    def __contains__(self, item: str) -> bool:
        if item in self.my_string:
            return True
        else:
            return False

my_text = MyTextObject('abcd')
if 'ab' in my_text:
    print('yes, its working')

Good catch. This is fixed in https://github.com/LostInDarkMath/pedantic-python-decorators/pull/7/commits/41f7f0e698dd2e7bb886da91a21972b3487454b0.


 Have you same update please? Or somebody reslove it. HA do not read OTE price.

Item has no "Hour" child or is empty: 2023-05-25

That is just a warning, I have removed it in latest version 0.5.1.


'style'-attribute of component has no effect

not one single component respects the style option. Using existing hl_group works.
{ 	text = function(buffer) 		return buffer.filename 	end, 	style = "italic", },

Duplicate of #154, the style property was removed in 0.4 in favor of individual properties.


Custom annotation images

Allow a custom image instead of the pin.

@nicked  if u have sample project for customizing the pin with images..can you please share ti here.it is really helpful for me
thanks
saran

@nicked can u please help me to tell how to overwrite NAAnnotaion to customize pin images with our own.i am stuck. i am new to ios.so please help me

@nicked can u tell how to overwrite the annotation class and cutomize pin images.

@saravananNV and @nicked - please be respectful of time of others on this project, you've started to become spammers on this repo and I don't want to resort to using the blocking tools because it can cut you off from documentation.


osfv_cli/src/osfv/libs: Add exception handling in a flashing path

During ROM flashing, traces originating from closed connection may appear. This patch addresses it by catching those traces.

@SebastianCzapla looks good now, all we need is to fix pre-commit

Rebased and added commit with some small fixes from pre-commit.

Was able to generate the following while working over VPN (might be relevant for network issues):
osfv_cli rte --rte_ip <IP_ADDRESS> flash probe
DUT model retrieved from snipeit: VP2430
Using rte command is invasive action, checking first if the device is not used...
Asset 171 successfully checked out.
Probing flash...
Traceback (most recent call last):
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/connectionpool.py", line 789, in urlopen
    response = self._make_request(
        conn,
    ...<10 lines>...
        **response_kw,
    )
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/connectionpool.py", line 536, in _make_request
    response = conn.getresponse()
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/connection.py", line 507, in getresponse
    httplib_response = super().getresponse()
  File "/usr/lib64/python3.13/http/client.py", line 1428, in getresponse
    response.begin()
    ~~~~~~~~~~~~~~^^
  File "/usr/lib64/python3.13/http/client.py", line 331, in begin
    version, status, reason = self._read_status()
                              ~~~~~~~~~~~~~~~~~^^
  File "/usr/lib64/python3.13/http/client.py", line 300, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
                             " response")
http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/macpijan/.local/lib/python3.13/site-packages/requests/adapters.py", line 667, in send
    resp = conn.urlopen(
        method=request.method,
    ...<9 lines>...
        chunked=chunked,
    )
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/connectionpool.py", line 843, in urlopen
    retries = retries.increment(
        method, url, error=new_e, _pool=self, _stacktrace=sys.exc_info()[2]
    )
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/util/retry.py", line 474, in increment
    raise reraise(type(error), error, _stacktrace)
          ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/util/util.py", line 38, in reraise
    raise value.with_traceback(tb)
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/connectionpool.py", line 789, in urlopen
    response = self._make_request(
        conn,
    ...<10 lines>...
        **response_kw,
    )
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/connectionpool.py", line 536, in _make_request
    response = conn.getresponse()
  File "/home/macpijan/.local/lib/python3.13/site-packages/urllib3/connection.py", line 507, in getresponse
    httplib_response = super().getresponse()
  File "/usr/lib64/python3.13/http/client.py", line 1428, in getresponse
    response.begin()
    ~~~~~~~~~~~~~~^^
  File "/usr/lib64/python3.13/http/client.py", line 331, in begin
    version, status, reason = self._read_status()
                              ~~~~~~~~~~~~~~~~~^^
  File "/usr/lib64/python3.13/http/client.py", line 300, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
                             " response")
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rtectrl_api.py", line 115, in gpio_set
    response = self._patch_request(f"/gpio/{gpio_no}", message)
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rtectrl_api.py", line 157, in _patch_request
    response = requests.patch(f"{url}{endpoint}", json=data, headers=headers)
  File "/home/macpijan/.local/lib/python3.13/site-packages/requests/api.py", line 145, in patch
    return request("patch", url, data=data, **kwargs)
  File "/home/macpijan/.local/lib/python3.13/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
           ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/macpijan/.local/lib/python3.13/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/home/macpijan/.local/lib/python3.13/site-packages/requests/adapters.py", line 682, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rte.py", line 304, in flash_cmd
    self.pwr_ctrl_before_flash(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.dut_data["programmer"]["name"],
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        self.dut_data["pwr_ctrl"]["flashing_power_state"],
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rte.py", line 276, in pwr_ctrl_before_flash
    self.spi_enable()
    ~~~~~~~~~~~~~~~^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rte.py", line 194, in spi_enable
    self.gpio_set(self.GPIO_SPI_VOLTAGE, state)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rtectrl_api.py", line 120, in gpio_set
    requests.exceptions.ProtocolError,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'requests.exceptions' has no attribute 'ProtocolError'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/macpijan/.local/bin/osfv_cli", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/cli/cli.py", line 898, in main
    flash_probe(rte, args)
    ~~~~~~~~~~~^^^^^^^^^^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/cli/cli.py", line 335, in flash_probe
    rte.flash_probe()
    ~~~~~~~~~~~~~~~^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rte.py", line 407, in flash_probe
    return self.flash_cmd(args)
           ~~~~~~~~~~~~~~^^^^^^
  File "/home/macpijan/.local/lib/python3.13/site-packages/osfv/libs/rte.py", line 308, in flash_cmd
    except requests.exceptions.ConnectionError as e:
           ^^^^^^^^
NameError: name 'requests' is not defined

Using the latest version as of today:
osfv_cli --version
0.5.8

Which should have the changes from linked PR integrated.


Spark 2.5 don't work with Jetty 9.4.0.M0

Seems that Jetty 9.4.0 introduced an incompatible change that broken the EmbeddedJettyServer class. See my stacktrace:
Exception in thread "Thread-1" java.lang.NoClassDefFoundError: org/eclipse/jetty/websocket/server/pathmap/PathSpec     at spark.embeddedserver.jetty.EmbeddedJettyServer.ignite(EmbeddedJettyServer.java:105)     at spark.Service.lambda$init$0(Service.java:349)     at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.ClassNotFoundException: org.eclipse.jetty.websocket.server.pathmap.PathSpec     at java.net.URLClassLoader.findClass(URLClassLoader.java:381)     at java.lang.ClassLoader.loadClass(ClassLoader.java:424)     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)     at java.lang.ClassLoader.loadClass(ClassLoader.java:357)     ... 3 more
This is the relevant part of my classpath:

jetty-http-9.4.0.M0.jar
jetty-io-9.4.0.M0.jar
jetty-security-9.4.0.M0.jar
jetty-server-9.4.0.M0.jar
jetty-servlet-9.4.0.M0.jar
jetty-util-9.4.0.M0.jar
jetty-webapp-9.4.0.M0.jar
jetty-xml-9.4.0.M0.jar
websocket-api-9.4.0.M0.jar
websocket-client-9.4.0.M0.jar
websocket-common-9.4.0.M0.jar
websocket-server-9.4.0.M0.jar
websocket-servlet-9.4.0.M0.jar
spark-core-2.5.jar
slf4j-api-1.7.21.jar
slf4j-simple-1.7.21.jar
javax.servlet-api-4.0.0-b01.jar

It choked on the PathSpec interface that used to be present in websocket-server-9.3.6.v20151106.jar (and probably also in a few newer versions). Now I tried to move to Jetty 9.4.0.M0, and that interface is not there anymore because it was moved to the jetty-http-9.4.0.M0.jar file. However, the package name also changed from org.eclipse.jetty.websocket.server.pathmap to org.eclipse.jetty.http.pathmap.
Going to line 105 of the EmbeddedJettyServer, it is not something obvious for me that I could easily and readily fix.
This also rises me an alert. The guys from Jetty don't really care if they will break other people code by refactoring their codebase around (I already got a similar issue last year with another tool that ceased to work due to this exact reason, though with earlier Jetty versions). This means that anything which directly interact with Jetty classes is inherently brittle, including Spark.
So, to solve this and ensure that this won't happen again in the future, I think that the Jetty-dependent classes would need to be moved to a JAR of their own tied to both the Spark version and Jetty's version (let's call it spark-on-jetty-xxx.jar, where xxx is the version) . The upsides are:

Whenever the Jetty guys introduce an incompatible change, just release a new spark-on-jetty package. No need to release a new full spark-core package.
People who use something else instead of Jetty will get rid of the unused jetty-related classes from their Spark.
This also open up the road for a future implementation of something like a spark-on-tomcat, spark-on-glassfish, spark-on-youknowwhat implementation.

The downside is the need to have still yet another JAR in the classpath.

Are u serious? Month for fixing one import =\

On vacation.

Still on vacation?

Nope.

Shameless plug: would PR #674 be of any help?

We can use maven repository update feature in case there is some version change, in order to resolve such issues.

I have hit the same problem. I really like SparkJava, and wanted to use to set up http resources, especially for test purposes. Unfortunately, I am getting the missing PathSpec error.
Exception in thread "Thread-1" java.lang.NoClassDefFoundError: org/eclipse/jetty/websocket/server/pathmap/PathSpec
at spark.embeddedserver.jetty.EmbeddedJettyServer.ignite(EmbeddedJettyServer.java:106)
at spark.Service.lambda$init$1(Service.java:391)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.ClassNotFoundException: org.eclipse.jetty.websocket.server.pathmap.PathSpec
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 3 more
Seems to be the same problem reported so well by Victor.

We will update jetty soon, don't really need an issue for this. Other points about splitting project up is also discussed elsewhere.


Read-only mode

Would be nice to have this to quickly check out what is in a notebook while at the terminal

:+1:


Graph and stats does not data across months, list does not restore graph

Command Sequence:
graph 30/10 d/8/11
list

fixed by #232


[Suggestion] Change from white/black to a more inclusive language (allow/block?)

Thanks for all the work on this library and for making it robust!
Proposal
This issue is being opened as a suggestion to move in a more inclusive terminology, removing the white/black reference and changing it to the allow/block reference (names are just a suggestion).
Impacts and Legacy usage
Understanding legacy projects that are not being maintained and those that can schedule a change to their projects, the suggestion is to inform about the deprecation with a warning while using those terms and already accept the new ones. Thinking about this, there are 2 PRs opened:

Deprecation Warning from the usage of whitelist/blacklist and support to allowlist/blocklist as default
Totally removal from white/black terms usage

The first one is not a breaking change, so it is possible to be merged and deployed as the old terms are still supported. The second one could be merged in the future version as it is a breaking change (new major version? 🤔)
Reference
As one of many references for this change, Rails community already changed it with the small difference between block for deny.

that's pretty awesome actually. The only thing is- this will be a breaking change. Do you think we should do both for now? As in, duplicate functionality temporarily with the new terms and then remove the white/black terms later?

The idea is exactly a breaking change and possibly, be merged at a future release! 😄
Thanks for accepting! 🙏


Unable to view user info in successful login response object

After I login and hit the onLogin callback, I can't find any user related information in that object. The permissions array says I have access to all of these different fields, but where can I find them?
Here is my FBLogin component.
<FBLogin
            permissions={['email', 'user_friends', 'public_profile', 'user_posts', 'user_videos']}
            loginBehavior={FBLoginManager.LoginBehaviors.Browser}
            onLogin={(data) => { console.log(data) }}
            onLogout={function(){
              console.log("Logged out.");
            }}
            onLoginFound={function(data){
              this.setState({ currentUser: data.credentials });
            }.bind(this)}
            onLoginNotFound={function(){
              console.log("No user logged in.");
            }}
            onError={function(data){
              console.log("ERROR");
              console.log(data);
            }}
            onCancel={function(){
              console.log("User cancelled.");
            }}
            onPermissionsMissing={function(data){
              console.log("Check permissions!");
              console.log(data);
            }} />

Screenshot of the response object.

@paulokuda when the user clicks on login, Facebook only returns a userId & token. In order to get other user information such as name, email, profile picture etc.. you need to make another API call like such:
var user = this.props.user
    var api = `https://graph.facebook.com/v2.3/${user.userId}?fields=name,email&access_token=${user.token}`;

    fetch(api)
      .then((response) => response.json())
      .then((responseData) => {
        _this.setState({
          info : {
            name : responseData.name,
            email: responseData.email,
          },
        });
      })
      .done();

I would suggest you explore the Facebook Graph API documentation to learn more.

thanks for the response @Monte9 - much appreciated!

how to set the state values with onLogin object?


fix - json_name to HttpJsonTranscodingQueryParmaMatchRule

Motivation:
Currently, LOWER_CAMEL_CASE and ORIGINAL_FIELD are used to match query params with protobuf messages.
It would be nicer if HttpJsonTranscodingQueryParamMatchRule supports json_name field option which is a well-known option that most protobuf JSON codecs implement
Modifications:

Support for json_name in HttpJsonTranscodingQueryParamMatchRule
The json name of the field is camelcase by default.  so, it is supported both when it is a camel case and when it is not.
( This is the default value when json_name is not used in protobuf. https://protobuf.dev/programming-guides/proto3/#json)

Result:

Closes #5193. (If this resolves the issue.)
Use origin field and json name
Use camel case and json name

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Prometheus and PeerLastSeen out of sync

After a long while, Prometheus seems to have some metrics for peers with 0 RTT that do not exist in ping-monitor's PeerLastSeen data structure. Similarly, there are occasional error messages that appear in ping-monitor trying to delete gauges (from PeerLastSeen's expiry mechanism) that do no exist in Prometheus.
This can be seen by calling hl-cli list periodically at an interval over a long period of time. A few metrics w/ 0 RTT should appear in the dashboard but do not exist within the PeerLastSeen structure.
Attempted to wrap all access to Prometheus client code in ping-monitor using mutex, but that doesn't seem to fix it.

Easiest "solution" (more of a work-around) is to simply have a seperate goroutine sync the two every x minutes.


Files on Dev Drive are corrupted and contain all zeros

Dev Home version
<IP_ADDRESS>
Windows build number
10.0.23475.1000
Other software
OS Build Version: 10.0.23475.1000.amd64fre.ni_prerelease.230602-1331
.NET Version: .NET 6.0.16
Steps to reproduce the bug
Mounted and created a Dev Drive D: from a new SSD.
Copying files onto the drive does corrupt the destination files.
The content is all binary zero's, but the size is correct, so this is not noticed at the time of copying.
E.g. this simple copy command corrupts the destination file:
copy e:\test.html d:\test
1 file(s) copied.
Expected result
No response
Actual result
The destination file is corrupted, and contains all binary zeroes.

This also happens e.g. when I do 'Save As' in Edge to save an html page.
This seems to be unrelated to the file type. Some specific files are copied correctly.
Files that are created in VSCode on the Dev Drive seem to be correct.
Same for cloning git repos.
Included System Information
CPU: Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Physical Memory: 31.94GB (21.11GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHomeGitHubExtension_<IP_ADDRESS>_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHome_<IP_ADDRESS>_x64__8wekyb3d8bbwe

Additional information.
When using copy/paste in Exporer I do get this error message:

The file is created, but apparently cannot be written to.

Found the cause of this serious issue!  Turning off virus scanning temporarily does solve the issue.
The protection software is 'KPN veilig' which is based on F-Secure.
Note that for this issue no alarm or message from the protection software is generated at all, also no Event Log. File copying just fails to copy the content.
The new Dev Drive is the only place in my PC which has this issue, which makes it likely that the protection software cannot handle this new configuration (yet).
I have now switched to Windows Defender and have experienced no issues since!

Thanks @marknn3 we appreciate the effort. Thats a lot of good information you provided and will help us in the future. I'm glad you were able to solve it for now!

Still something bad going on.
I got this fatal error while compiling the dotnet runtime (for some experiments, yeah I know, but it should not crash!)

Again I see some 'zero' files in some locations. (Using Windows Defender)

The json file in the same folder is correct:

@bbonaby Rerunning the runtime build (after renaming the artifacts folder) eventually resulted in the same crash, although this time it run much further. (Artifacts folder size 3.94 GB v.s. 235 MB after the first crash).
Then I turned off Real-Time protection:

Renamed the Artifacts folder and started the build again.
This time the build ran to completion!

Then I turned on Real-Time protection again. Renamed the artifacts folder and started the build again.
And... again crash! This time the artifacts folder was filled with 3.50 GB.
So there seems to be a strong indication towards a generic issue involving Real-Time protection software.
Hope the above 'evidence' will help to pinpoint and fix the rootcause.

To eliminate any hardware related drive issues on my side I did the following:

Unmounted the M.2 Dev Drive
Created a new dynamic vhdx Dev Drive of 200GB on an existing SATA drive.
Cloned the dotnet runtime repo onto the new Dev Drive, and started the build.

Same fatal crash occurs after a few minutes (artifacts folder size 3.94 GB)

I have reproduced the fatal crash in a VM! (Hyper-V)
At first it ran to completion in 1+Hr(...)  With 6 cores, 6GB and Dev Drive as E:.
Then I hard deleted the artifacts folder, changed cores to 8, Memory to 10GB and changed driveletter of Dev Drive to D:.
Started the build again, and within a few minutes the crash occured.
I have saved the MEMORY.DMP and Minidump.

After installing latest Insider Preview: OS Build Version: 10.0.23486.1000.amd64fre.ni_prerelease.230616-1447
I am unable to reproduce the fatal crash.
But I do notice an extreme slowness at step 'Microsoft.NETCore.App.Runtime ->' in the build. This single step took almost 1 hour to complete! And eventually everything run to completion in  01:13:20.43.

Hi @marknn3,
Thank you for providing this information and taking the time to investigate this issue.  It does seem like an AV is getting in the way.
Can you please file a feedback hub item about this on Developer Platform/Dev Drive with all the information you have collected.
I'm going to close this issue because this is an OS and File System issue.


Review keyboard shortcuts clashing with system shortcuts

e.g. cmd+m, cmd+h on mac

I have the same issue, so I am requesting that this be reopened. When I use the Alt+Tab shortcut to select parent, it triggers the system shortcut instead and switches between open windows. I don't see any other way to select parents other than the shortcut, and the shortcut is not working for me.

We'll add Alt+Shift+P to select parent in the next release.

Encountered the same issue, found that using program specific hotkey mappings provided by certain mouse softwares a working workaround before the new release. I made a profile for drawio desktop and set the side button to Alt + Tab in Logi Options+, it's now working as expected.


[Coverity] Fix resource leak

Fix resource leak reported by coverity

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #396. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Further reduce size of Docker image

Removing man pages, logs generated by the image build process
Add apt-get autoremove to cleanup unused packages at build
Move environment variable for non-interactive mode to ENV

This is awesome! I really need to start using things like Docker.


use manifest pipeline for workflows

Right now we are expecting the workflow file and use the Workflow type provided in core-js. We should add support for workflow files to @polywrap/polywrap-manifest-schemas and @polywrap/polywrap-manifest-types-js, and the Workflow type should be imported similar to DeployManifest and InfraManifest.
This would basically validate the workflow file against a json schema, and allow for future migrations of workflow files.


Swizzle all methods from NSURLSession and NSURLConnection

Description
It's time to support all methods from URLSession and URLConnection.

We've implemented all URLSession Delegate, except URLConnection 👍


Use this awesome plugin for code block indicator

I finally found this plugin.

Tested, not good, bad for user expeience


Ignite 5259 Support backward compatibility with versions without service permissions

The ticket is resolved, closing PR.
Please close PRs for your resolved tickets and other non-needed PRs.
Alternatively, ask a committer

to use GitHub UI (committer can associate accounts here: https://gitbox.apache.org/setup/ )
or https://github.com/apache/ignite/blob/master/scripts/apply-pull-request.sh from Apache Ignite source.
or mention in commit message 'Fixes #(a number of PR)'.

These methods will automatically close PR.
Feel free to reopen this PR if it is anyway actual.


The integrated terminal does not work

Issue Type: Bug
Today, the terminal in VS code has stopped opening, when you run any script or click the "New Terminal" button, the terminal window opens for a second and immediately closes. It is possible that another problem follows from this - when opening a remote SSH connection, an error occurs "A bad result was obtained from the installation script".
VS Code version: Code 1.68.0 (Universal) (4af164ea3a06f701fe3e89a2bcbb421d2026b68f, 2022-06-08T11:44:00.250Z)
OS version: Darwin x64 21.3.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 3

Memory (System)
16.00GB (0.52GB free)

Process Argv
--crash-reporter-id 6a1b6d1e-ab83-4413-8d03-aaa25d68b659

Screen Reader
no

VM
0%

Problem was solved by rebooting


Add RubyImportResolver pass

May be irrelevant for now. Making draft PR for posterity when this actually needs to be implemented.

Immediately closing to be reopened when relevant.


Add jenkins/integration test support for parquet-hadoop tests jar for testing parquet encryption

Is your feature request related to a problem? Please describe.
Followup to https://github.com/NVIDIA/spark-rapids/pull/5761 to add integration test support to download the parquet-hadoop-tests jar and ship it to the cluster so we can test with jenkins.

let me take this issue.

Let keep it open until the nightly jars get uploaded, and will verify the latest integration-test.tgz with IT jobs to make sure all the spark-3.2.0 CI jobs PASS the  test_parquet_read_encryption test cases.
After CI MR914 get merged, then we can close the issue.

Merged MR 914, will keep monitoring status of test runs

passed in all nightly CI. Closing it


Adjust server job to handle .git upload and Bundle.ndjson

The new g3t client will upload a *.git.zip file.
Should/how the server job:

deprecate reading *.meta.zip and producing *SNAPSHOT.zip in lieu of reading from *.git.zip
process Bundle.ndjson to process deletes of files meta that no longer exist
produce a better [out] json file
streamline discovery page, other issues

deprecate reading *.meta.zip and producing *SNAPSHOT.zip in lieu of reading from *.git.zip

Parts of this branch should get folded into this. Specifically separating download part of _dowload_and_unzip into its own function - https://github.com/ACED-IDP/aced_etl_pod/blob/feature/reset-commit/etl-job/fhir_import_export.py#L173C5-L193

process Bundle.ndjson to process deletes of files meta that no longer exist

So given a bundle like:
{   "resourceType": "Bundle",   "id": "a3bd9781-444b-51e3-8c39-dd075207b758",   "identifier": {     "use": "official",     "system": "https://aced-idp.org/cbds-5e3cfd2db836439db952804ac7b44194",     "value": "2024-05-16T20:40:08.109104Z"   },   "type": "transaction",   "timestamp": "2024-05-16T20:40:08.109104+00:00",   "entry": [     {       "request": {         "method": "DELETE",         "url": "DocumentReference/ca5a5fb3-1c5d-5e05-b026-2ed62720f625"       }     }   ],   "issues": {     "resourceType": "OperationOutcome",     "issue": [       {         "severity": "warning",         "code": "processing",         "diagnostics": "Meta data items no longer in study."       }     ]   } }
unzip, pass to an aced submission function that iterates through every dict in "entry" and creates a list of the method:url where url is just the uuid. Then do a bulk delete type action for each  "method": "DELETE", in this case DELETE.
elastic:
https://github.com/ACED-IDP/submission/blob/cf04d2cabab37d743a48d6b7711ec6f0ace2bee1/aced_submission/meta_flat_load.py#L726-L748
and in peregrine something similar to: https://github.com/ACED-IDP/submission/blob/cf04d2cabab37d743a48d6b7711ec6f0ace2bee1/aced_submission/meta_graph_load.py#L390-L395

produce a better [out] json file

Yeah, especially ensuring that logs in the submission library are preserved and returned to the user in the etl_pod library, and not just when exceptions occur.


Handle the extra StoreInfo from memory_sink

What
Fixes a test failure on main.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check

Merging since main is broken. Post-review welcome.


Mirroring to a GitHub repository

On my old Gitolite setup, I had post-receive hooks set up in such a way that every push would also be automatically mirrored (git push --mirror) to an equivalent repository on GitHub (where the actual issue management and such lives).
While it's possible to specify this kind of hook manually in each repository's settings, it'd be nicer to have a "mirror to remote Git repository" button to set it up more or less automatically. Would this be a possibility?

Thanks your feedback!
I think this is duplicated to https://github.com/gogits/gogs/issues/96?

Ah yes, you are correct, that indeed seems like the same request. I searched for a while but I couldn't find a previous issue for this - probably because it was titled 'sync' rather than 'mirror' :)

EDIT: The 'have to confirm host key' point is a good one, I hadn't thought about that. Maybe there is an SSH flag to automatically trust on first contact?

I don't know about that and looking for a solution, you can post any possible solution to that thread.


[BUG]connection error

Describe the bug
Failed to create photon:
(MaxRetryError('HTTPSConnectionPool(host='huggingface.co', port=443): Max
retries exceeded with url: /api/models/mistralai/Mistral-7B-Instruct-v0.1
(Caused by SSLError(SSLCertVerificationError(1, "[SSL:
CERTIFICATE_VERIFY_FAILED] certificate verify failed: Hostname mismatch,
certificate is not valid for 'huggingface.co'. (_ssl.c:997)")))'), '(Request
ID: 92e7ab3a-6a8f-4b86-8626-9c40352a8499)')
To Reproduce
lep photon create --name mistral-7b --model hf:mistralai/Mistral-7B-Instruct-v0.1
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: MacOS
Python version: 3.10
LeptonAI library version: lep, version 0.11.0

Additional context
located in China and use VPN be able to access huggingface.co.

Thanks for reporting the error!
Quick question - if you run the following python command:
import huggingface_hub
print(huggingface_hub.model_info("mistralai/Mistral-7B-Instruct-v0.1"))

Does the infor get print correctly? I suspect it might be a network connection issue that is unfortunately beyond our control...

Thanks for reporting the error!
Quick question - if you run the following python command:
import huggingface_hub
print(huggingface_hub.model_info("mistralai/Mistral-7B-Instruct-v0.1"))

Does the infor get print correctly? I suspect it might be a network connection issue that is unfortunately beyond our control...

My network can not access hf directly,  but I have got a hf model from somewhere. Can I use it like this:
lep photon run --name my_model --model hf:./my_local_model_dir

The bug has been fixed by changing the connection. But...
lep photon run --name mistral-7b --local
Launching photon on port: 8080
2023-10-24 19:24:21.694 | INFO     | leptonai.photon.hf.hf:pipeline:199 - Creating pipeline for text-generation(model=mistralai/Mistral-7B-Instruct-v0.1, revision=7ad57997).
HuggingFace download might take a while, please be patient...
2023-10-24 19:24:21.694 | INFO     | leptonai.photon.hf.hf:pipeline:204 - Note: HuggingFace caches the downloaded models in ~/.cache/huggingface/ (or C:\Users<username>.cache\huggingface\ on Windows). If you have already downloaded the model before, the download should be much faster. If you run out of disk space, you can delete the cache folder.
2023-10-24 19:24:22.579228: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library libcudart.so.11.0
:219: RuntimeWarning: scipy._lib.messagestream.MessageStream size changed, may indicate binary incompatibility. Expected 56 from C header, got 64 from PyObject
Failed to launch photon: 'mistral'

This looks like a dependency issue and not one from lepton.
I'd suggest starting with a clean anaconda install, and use conda python to run pip install lepton - I think there is a conflict in the underlying C library between scipy and some other libraries, which is a common case if mac system python and other python installations are mixed up.

Closing since the original issue has been addressed. Feel free to open new issues if you have run into other problems. Thanks


Curly option only warning when multiline

Can you give an option that don't warn when oneline
{
  "curly": "oneline"
}

Code
// Good
if (true) console.log(true);

// Bad
if (true)
  console.log(true);
  console.log(true);

:+1:

If you accept this idea, I can make a PR.

Its kind of a style requirement in the case where you want it fail/pass depending on whitespace.
In that case, please consider switching off curly requirement in jshint and investigating jscs.. It may already be possible.
e.g. you want curly's not required and then an enforcement that without curlies, the statement is on the same line with no new line.

@lukeapage Hi, I'm not sure it is an issue yet so I'm asking you here before: Is there a reason the JSHint curly option has not been deprecated in favor of JSCS requireCurlyBraces rule ?

Omitting braces for single-statement conditional block bodies can be misleading depending on the indentation of the surrounding code (the recent SSL/TLS bug in IOS is a high-profile example of this kind of confusion). For this reason, we do not consider brace usage a stylistic concern.


Support for Value Objects for mapping create parameters

At the time of writing, the CreateServiceInstanceRequest provides a getParameters method that takes a class to convert the parameters to. This class needs to be a Java bean class for this work; if there's no setter for the field, it's not set. However, I think it will be useful in many cases to be able to use immutable objects as well. In Domain Driven Design, Value Objects are meant to be immutable, and create parameters seem to fit the pattern.
For example, if I have the following Parameters class (annotated with Lombok for brevity):
@Value
@With
public class Parameters {
    private String name;
    private Integer count;
}

I want to be able to do:
public Mono<CreateServiceInstanceResponse> createServiceInstance(CreateServiceInstanceRequest request) {
    var params = request.getParameters(Parameters.class);
    var transformed = params.withName("transform" + params.getName());
}

There are many reasons people would want to work with Value Objects instead of Java beans.

Thanks for the suggestion! Seems like a nice complement to the existing API. It probably makes most sense in a 3.x version.


Added tags for each node

Waiting for https://github.com/PerCollECT/Source-Files/pull/41 to be merged, so the submodule can be set to the correct commit of the Source Files.


DynamicUser units race with nscd at system startup

Describe the bug
When using DynamicUser=true for a nixos service, it can happen that the dynamic user is not found (does not exist) when the unit is executed.
This leads to errors like bin/chown: invalid user: where the chown is used to change ownership of files to the service.
Steps To Reproduce
The following flake shows the behaviour (I set Before  = "nscd.service" to make the race reliable, but in practice this can also occur randomly by chance if there is no ordering dependency). On boot, test-service fails to start with:
/nix/store/php4qidg2bxzmm79vpri025bqi0fa889-coreutils-9.5/bin/id: ‘test-service’: no such user

However, after the system has booted (and nscd has started), starting test-service succeeds.

flake.nix for the VM

{
  inputs.nixpkgs.url = github:NixOS/nixpkgs/63dacb46bf939521bdc93981b4cbb7ecb58427a0;
  outputs = { self, nixpkgs }: {
    packages.x86_64-linux.default = (nixpkgs.lib.nixosSystem {
      modules = [
        ({ lib, pkgs, config, modulesPath, ... }: {
          users = {
            mutableUsers = false;
            users.root.password = "";
          };

          systemd.services.test-service = {
            enable = true;
            wantedBy = [ "multi-user.target" ];
            before = [ "nscd.service" ];
            serviceConfig = {
              Type = "oneshot";
              DynamicUser = true;
              ExecStart = "${lib.getBin pkgs.coreutils}/bin/id test-service";
            };
          };
          services.getty.autologinUser = "root";

          # default configuration from nixos-generate-config follow
          imports =
            [ (modulesPath + "/profiles/qemu-guest.nix")
            ];

          networking.hostName = "base";
          system.stateVersion = "24.05";

          # Use the systemd-boot EFI boot loader.
          boot.loader.systemd-boot.enable = true;
          boot.loader.efi.canTouchEfiVariables = true;

          boot.initrd.availableKernelModules = [ "ahci" "xhci_pci" "virtio_pci" "sr_mod" "virtio_blk" "virtio_console" ];
          boot.initrd.kernelModules = [ ];
          boot.kernelModules = [ "kvm-intel" ];
          boot.extraModulePackages = [ ];
          boot.kernelParams = [ "console=tty0" "console=ttyS0" ];

          fileSystems."/" =
            { device = "/dev/disk/by-label/root";
              fsType = "ext4";
            };

          fileSystems."/boot" =
            { device = "/dev/disk/by-label/esp";
              fsType = "vfat";
            };

          swapDevices = [ ];

          # Enables DHCP on each ethernet and wireless interface. In case of scripted networking
          # (the default) this is the recommended approach. When using systemd-networkd it's
          # still possible to use this option, but it's recommended to use it in conjunction
          # with explicit per-interface declarations with `networking.interfaces.<interface>.useDHCP`.
          networking.useDHCP = lib.mkDefault true;
          networking.useNetworkd = true;

          nixpkgs.hostPlatform = lib.mkDefault "x86_64-linux";
        })
      ];
    }).config.system.build.vm;
  };
}

Expected behavior
Edit with DynamicUser = true should work robustly also at system boot.
Workaround
Add After = nss-user-lookup.target to the service config.
Notify maintainers
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.32, NixOS, 24.05 (Uakari), 24.05.20240531.63dacb4`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `not found`

Add a :+1: reaction to issues you find important.

See previous discussions there https://github.com/NixOS/nixpkgs/pull/105354


this within function typed as any when annotated with JSDoc

Bug Report
When function is annotated with JSDoc then even if the type explicitly specifies the type of this, the this is typed as any within the function. It seems to work in a *.ts file but not in *.js with JSDoc annotation.
Also it seems to be a regression (or intentional change) in 4.9.4.
🔎 Search Terms
jsdoc this any
🕗 Version & Regression Information

This changed between versions 4.8.4 and 4.9.4

⏯ Playground Link
Stackblitz link is below but it doesn't reproduce there as it doesn't seem to support JSDoc well.

Go to https://stackblitz.com/edit/bc4n2m?file=types.d.ts,index.ts,index.js,tsconfig.json&view=editor
Download the project to hard drive

Install dependencies with npm i or yarn
Open project in VSCode and open file index.js
Hover over this.

💻 Code

index.js
/** @type {import('./types').Module} */
export default function SentryModule () {
  return this.test()
}

types.d.ts
interface ModuleThis {
  foo: () => void;
}

export type Module = (this: ModuleThis) => void;

🙁 Actual behavior
any has any type in TS 4.9.4
🙂 Expected behavior
this is correctly typed as ModuleThis as in TS 4.8.4.

Note: The current version of VSCode might default to 4.8.4 version in which case the issue will not show up but it reproduces after switching to version of typescript from project in the bottom right corner of the status bar.

This seems to be an issue specific to typing function declarations. If you switch to a variable declaration initialized to a function expression, it works:
/** @type {import('./types').Module} */
export const SentryModule = function() {
  return this.test()
  //          ^^^^ Property 'test' does not exist on type 'ModuleThis'.
}

But on the other hand, it’s not as if the annotation on the function declaration does nothing. Mismatched parameters errors as expected:
/** @type {import('./types').Module} */
//         ^^^^^^^^^^^^^^^^^^^^^^^^ The type of a function declaration must match the function's signature.
export default function SentryModule (a, b) {
  return this.test()
}

This inconsistency does seem like a bug.


Removed stray spaces

causing bold to fail and leaving confusing "**" characters

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/coreinfo.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Please create this against master

Re-issued Pull against Master


Save network weights in a text file

Hi, I would like to save the Tensorflow neural net weights in a text file in a matrix form or something like:
neuron1_1 weight1_12 weight1_13 ...
...
neuron2_N weight2_N1 weight2_N2
I'm not intersted in such particular form, I just want a text file that is not a .meta file that I get when I save the agent with r.agent.save_model()
I tried with the following code:
with tf.Session(graph=g) as sess:
	with g.as_default():
		variables = tf.trainable_variables()
		variables_values = sess.run(variables)
		for var, val in zip(variables, variables_values):
			print(var.name, val)

but I get
RuntimeError: The Session graph is empty.  Add operations to the graph before calling run().

Can someone help me, please?

If some is


License

Hi, thank you for sharing the code of the interesting work. Will you add a license for the code?

A license has been added. Thank you.


Compute horizon SO threshold before transformation

Fixes: https://github.com/godotengine/godot/issues/51897 for 4.0
4.0 version of https://github.com/godotengine/godot/pull/51927

Thanks!


EPR-36 Solving userid null issue in OS audit service

When userid is null, audit was not getting added. Fixed this issue in OS audit service

This is not needed. Fix was found another way.


upgrade: fix error checking dependents

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Error: undefined local variable or method `formulae_to_install' for Homebrew:Module
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/upgrade.rb:164:in `block in check_installed_dependents'
/usr/local/Homebrew/Library/Homebrew/cache_store.rb:17:in `use'
/usr/local/Homebrew/Library/Homebrew/upgrade.rb:163:in `check_installed_dependents'
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:114:in `upgrade'
/usr/local/Homebrew/Library/Homebrew/brew.rb:111:in `<main>'

Thanks for the fix, sorry for the bug @Bo98!


Add support for installing a 3.x or 3.5.x type version

It would be cool if I could specify something like pyenv install 3.x and get the latest version installed automagically.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/33335076-add-support-for-installing-a-3-x-or-3-5-x-type-version?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github).


Episode rewards not updated before being used by callback.on_step()

The following applies to DDPG and TD3, and possibly other models.  The following libraries were installed in a virtual environment:
numpy==1.16.4
stable-baselines==2.10.0
gym==0.14.0
tensorflow==1.14.0
Episode rewards do not seem to be updated in model.learn() before callback.on_step().  Depending on which callback.locals variable is used, this means that:

episode rewards may not be available until after the beginning of the next episode
reported episode rewards may not include the reward for the last step of the episode.

Also the callback.locals episode reward variables are different for DDPG and TD3, meaning that a callback that is useful for both models has to account for differences in episode reward variable names and types.
The following code reproduces the error for DDPG and TD3:
from gym import spaces, Env
from stable_baselines import DDPG, TD3
from stable_baselines.common.callbacks import BaseCallback
import numpy as np

NUM_STEPS = 5
MODELS = [DDPG, TD3]

'''
    Callback()
    A simple callback function that prints the episode number and reward
'''
class Callback(BaseCallback):

    def __init__(self, model):
        super(Callback, self).__init__()
        self.count = 0
        self.model = model

    def _on_step(self) -> bool:

        if self.training_env.done:
            self.count += 1
            if type(self.model) is DDPG:

                # 1) We should be able to use episode_reward instead of epoch_episode_reward,
                #   but neither is updated until after the callback.  This means that the episode reward is not available until the next episode has begun
                # 3) "episode_reward", a scalar that could be used for DDPG, is different than "episode_rewards"
                #   a list that could be used for TD3.  Callbacks that are designed for both DDPG or TD3 have to
                #   handle the discrepancy in variable types and names
                if len(self.locals['epoch_episode_rewards']) >  0:
                    reward = self.locals['epoch_episode_rewards'][-1]
                    print('Episode: ' + str(self.count) + ' | Reward: ' + str(reward))
                else:
                    print('-------- Episode 1 is missing b/c the episode_rewards has not been updated -------')

            if type(self.model) is TD3:
                # 2) episode_rewards is not updated to include the last reward from an episode BEFORE being
                #       used by the callback
                reward = self.locals['episode_rewards'][-1]
                print('Episode: ' + str(self.count) + ' | Reward: ' + str(reward))

        return True

'''
    TestEnv()
    A simple environment that ignores the effects of actions
    Episodes always last for NUM_STEPS steps
    For the last step, a reward of +1 is given, regardless of the action
    For every other step, a reward of +0.1 is given, regardless of the action
    For NUM_STEPS = 5, the reward for each episode should be 4 * 0.1 + 1 * 1 = 1.4
'''
class TestEnv(Env):

    def __init__(self):
        self.action_space = spaces.Box(np.asarray([0]), np.asarray([1]), dtype=np.float32)
        self.observation_space = spaces.Box(np.asarray([0]), np.asarray([1]), dtype=np.float32)
        self.reset()

    def step(self, action):
        self.count += 1
        obs = np.asarray([1])

        reward = 0.1
        self.done = False
        if self.count == NUM_STEPS:
            reward = 1
            self.done = True

        info = {'is_success': False}

        return obs, reward, self.done, info

    def reset(self):
        self.count = 0

'''
    Construct a DDPG and a TD3 model and demonstrate the bugs in the model.learn() functions.
    In both cases, episode rewards are not updated before being passed to the callbacks
    The bug is present in stable-baselines 2.10.0
    DDPG and TD3 may not be the only classes effected
'''
if __name__ == '__main__':

    env = TestEnv()

    for m in MODELS:

        callback = Callback(model=m)
        model = m('MlpPolicy', env, random_exploration=0)
        print('--------------------------------------------------')
        print(str(m))
        print('Each reward should be 1.4, and there should be 20 episodes printed')
        model.learn(100, callback=callback)
        print('--------------------------------------------------')

This should be fixed in 2.10.1 (see changelog). See if that works.

Installing stable-baselines=2.10.1 did not work.  Looking at TD3.learn() version 2.10.1:

the rewards for each step are returned from self.env.step() on line 330
the locals are updated on line 336
callback.on_step() is called on line 337
episode_rewards is updated on line 394.

Since callback.on_step() has access to the correct reward for the step, but not the correct reward for the episode, the problem could be solved by having the callback keep track of the episode rewards.  But, it seems that calling callback.on_step() after episode_rewards[-1] += reward_ (or equivalent for other models) would be a more robust solution.

Hello,
If you want a robust way to retrieve episode reward variable, you should use a Monitor wrapper together with a callback.
This is what we do in Stable-Baselines3.
In fact, depending on what you really want to do, you could possibly only use a gym.Wrapper.

Hi, I wish to make my first contribution. @Miffyli How can I help on this?


Opening two reveal modals in a row causes second one not being closed correctly

If you show a reveal modal, and then close it and show another at the same time you end up with the first one closing, removing the underlay and the second being shown with no underlay, and hence can't be closed.
Furthermore, when you close the second modal the underlay is displayed and is not removed on click.
The problem is reproduced here
Interestingly, if you don't call .foundation('reveal', 'close') then it works as expected.

Working here on the docs http://foundation.zurb.com/docs/components/reveal.html

The docs don't provide the same scenario as the JSBin example. The JSBin example clearly demonstrates the problem. Surely this isn't the desired behaviour?

In this case, the Foundation API is a bit misleading and not very clearly explained in the docs (I'll update accordingly), but to fix this problem, you actually do NOT call .foundation('reveal', 'close').
The 'open' method checks for whether or not other modals are currently open. If there are any others open, it'll automatically close them and open the next one in the "queue." This is similar to the example that @rafibomb showed in the docs, where there are "nested" subsequent modals.

Cool, I see. So @Derrick666 the solution is to not call close: http://jsbin.com/gevelu/1/edit?js,output


[DatePicker] StaticDatePicker scrolls the page after selecting a year

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

If you use the StaticDatePicker and you select a year, the scroll position jumps down the page a bit.
Expected Behavior 🤔

The scroll position should remain the same after selecting a year.
Steps to Reproduce 🕹

You can reproduce the bug in the official demo: https://next.material-ui.com/components/date-picker/#static-mode.
Steps:

Click on any year
Notice that the scroll position jumps down

Context 🔦

Your Environment 🌎

Tech
Version

@material-ui/lab
v5.0.0-alpha.16

Hello! I would like to work on this issue. Starting today

@tpeek Can you still reproduce this? If so, could you please add a screen recording so that I understand the issue? I cannot notice any change in scroll position when clicking a year:
https://user-images.githubusercontent.com/12292047/119887946-11ef4f00-bf35-11eb-8a27-52ef9cb4fe47.mp4

Hello! Has this issue been resolved?

Closing since this is no longer reproducible: https://github.com/mui-org/material-ui/issues/23650#issuecomment-849894834


RDP support

A suggestion: please consider adding RDP support (add apt install -y xrdp, add to supervisord.conf). In my testing the latency is a lot lower than when uxing x11vnc.

It's a good idea, but I have no plan to support this in this repo, because

To support RDP will break original objective. The name in this repo has vnc.
I quickly tried and found it may change a lot to support rdp and vnc in a same repo

So I will close this issue. It's still welcome to discuss and +1 if anyone really need RDP


add crossing fixes for cost estimates

cost estimate isn't working because crossing_fix column isn't present


Dynamic validation of "EncryptionAtHost" feature subscription level registration at the RP.

Which issue this PR addresses:

ARO-3211
What this PR does / why we need it:

When customers are attempting to set EncryptionAtHost, but that feature is not enabled for their Subscriptions, an error message describing about the issue and its resolution is displayed to them. This is achieved by dynamically validating their Subscription in the RP's frontend.
Test plan for issue:

E2E
Is there any documentation that needs to be updated for this PR?

N/A

error message looks good to me

Closing this and moving to an updated branch in https://github.com/Azure/ARO-RP/pull/3826


upgradewallet missing from help output

Describe the issue
-upgradewallet no longer appears in the help output for dashd/dash-cli
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

Run dashd -help or dash-cli -help

Expected behaviour
Expect to see help output for upgradewallet (the RPC still exists)
Actual behaviour
upgradewallet missing from help output
What version of Dash Core are you using?
v19.0.0-RC.7

-upgradewallet cmd-line option was removed in https://github.com/dashpay/dash/commit/5f10b3e5dc9744aedca5cb4b222c777389f86155#diff-f807f97d1de845ebccc36c08e68869abcfe37478871194d5d4beb9a29047145aL65


Towards Solidity syntax: not

Replace the logical operator not with !. For instance:
not flag

becomes:
!flag

Commit 1057c71 solves this issue.


Fixes for Universal Angular

Inject DOCUMENT and remove HostListener decorator.

Hi threesquared,
thanks for the PR. Is there any reason/source for favoring the "host" in the directive annotation over the @HostBinding annotation? I like it because this way the whole "interface" is at one place, just asking about caveats or consequences.
Sebastian

Hi Sebastian,
There is an issue with the Event global when running in angular universal. I copied the fix from here which goes into more detail.
Ben


Support built-in resources (such as service "kubernetes") for tenant spaces

(To add more details)

Per discussion with Hongwei and Pengdu, this issue does not block the feature of multi-tenancy CRD, as multi-tenancy CRD can work end-to-end via configuration in user context.
Yet, we agree this issue is a critical issue in multi-tenancy networking. So I assign it to Xiaoning.

Mechanism of service kubernetes in arktos multi-tenancy is in part of service design proposal.
Plan to implement it in future milestone 6/30.

core-dns pod is house-keeping the default kubernetes + kube-dns service for rach network; closed


Add web support for zoom_factor

Before, when setting the zoom_factor, the website was already enlarged, but the zoom was ignored when calculating the logical window size and mouse position, causing an offset between the actual cursor and selected elements. That is addressed here

Thank you very much for the library! I did my first bigger project in rust and am really happy with it, especially the ease with which one can create both a native and web application. My prof had some difficulty reading the text, and I can see how one might have problems, especially with the moderate text contrast in dark mode. So I created this PR because I would like to enlarge the website a bit by default

The intent of the current behavior is that the web browser is in charge of the zoom-factor/pixels-per-point.
If you launch a native egui app and press cmd-plus, you will zoom in, because egui catches that command and adjust the zoom factor.
If you go to egui.rs you'll notice cmd-plus also works to zoom in, but this time it's the browser that is in control. This means egui just follows the general zoom of the web page. In other words, if you embed an egui/eframe app into a web page and tells the browser to zoom in, egui will act just like any other web element.
Do you want to be able to zoom an egui app independently of the browsers setting?

Exactly, I don't want to override the browsers zoom level, but I would like to be able to adjust the zoom level of the application programmatically

Makes sense - thanks for the PR!


RNA transcription

Implement RNA transcription exercise.

This looks great, thank you! Would you mind squashing your commits?

@kytrinyx There, that ought to do it. Commits squashed.

Fabulous, thank you! Merged in cadb21fd73896791edf2f42eac809c1f784953ba


Generate Protocol Buffers

Scope of changes
Updates the package to generate the protocol buffers from the github.com/rotationalio/ensign repository.
Fixes SC-14968
Type of change

[x] new feature
[ ] bug fix
[ ] documentation
[ ] testing
[x] technical debt
[ ] other (describe)

Acceptance criteria
Really just check to make sure this makes sense.
NOTE: The tests won't pass until https://github.com/rotationalio/ensign/pull/302 is merged.
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[x]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]  Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
[ ] Are there any TODOs in this PR that should be turned into stories?

Thanks! I'll rerun the tests now that the ensign PR is merged in to make sure they pass.


A demo app

The Monocle comes bare-bones. To be able to have a quick impression of its abilities, as well as allow to use it without any programming, a demo app could provide a set of core features.
Some examples from the chat:
https://discord.com/channels/963222352534048818/1100115561997934633/1100118956091654225

Image transfer from the camera to the Bluetooth central (output)
Show notifications from the Destkop (input)

The features from earlier firmware:

Start continuous recording and offer to show a replay (eventually save it / transfer it?) of the camera feed
Zoom the camera output.

I can try come up with something for this


keep the screen in the landscape on Android

You can assign this to me if you aren't actively working on it.

I can't assign it to you. You may need to write JNI bindings or make NDK calls through cgo. Go mobile doesn't have a orientation setter currently. Are you sure you want to take a look at it? :)

Ahaha I see, maybe I bit on more than I could chew. I'll track the progress then, and learn from the way you'll do it.

Btw if it isn't a show stopper though I'd be interested in learning how to do this, or at least help write the parts to this under your guidance.

It's not as trivial as I thought it may be. One possible solution could be https://github.com/golang/go/issues/10943.

I was considering rewriting this for practice using material. Would you be interested in these changes? I could fork your repo and convert it directly.


build errors, failed to cabal install llvm-sclicing

Hello, when I do cabal install in /src directory, I got the errors as following, Could you help me ? Thank you.
Ubuntu 14.04
LLVM 3.4
cabal-install version <IP_ADDRESS>
The Glorious Glasgow Haskell Compilation System, version 7.8.4

[ 3 of 22] Compiling LLVM.Analysis.CFG.Internal ( src/LLVM/Analysis/CFG/Internal.hs, dist/build/LLVM/Analysis/CFG/Internal.o )
src/LLVM/Analysis/CFG/Internal.hs:245:37:
Couldn't match type ‘GV.Number’ with ‘GV.GraphID’
Expected type: Int -> GV.GraphID
Actual type: Int -> GV.Number
In the first argument of ‘(.)’, namely ‘GV.Int’
In the ‘GV.clusterID’ field of a record
Failed to install llvm-analysis-0.3.0
cabal: Error: some packages failed to install:
hashtables-<IP_ADDRESS> failed during the building phase. The exception was:
ExitFailure 1
llvm-analysis-0.3.0 failed during the building phase. The exception was:
ExitFailure 1
llvm-data-interop-0.3.0 depends on hashtables-<IP_ADDRESS> which failed to install.
llvm-slicing-0.3.3 depends on llvm-analysis-0.3.0 which failed to install.

It is because that the version of Haskell library hashtable installed in your computer does not meet (e.g. higher) the requirement for Haskell libray llvm-analysis. There are two solutions: 1) uninstall your higher version of hashtable , reinstall its lower one such as <IP_ADDRESS>, and try them again; or 2) directly download our pre-built binary in the folder bin/. In addition, for more detailed install information about llvm-analysis, please see its website: http://hackage.haskell.org/package/llvm-analysis. I strongly recommend you to select Solution 2. Thanks for your interest in our llvm-slicing.

@zhangyz Thanks, but I have to use LLVM3.4 on Ubuntu14.04. I' ll try solution1 to see if I can solve it


Update meta.json

The original Chainspace Discord had a custom URL (/chainspace) but lost it when our Boosts went below a threshold, and some hacker picked up the URL and now has an active wallet drainer in that Discord. Please accept this commit ASAP so that we can avoid more people getting drained.
DM me on Twitter @timshelxyz if you need confirmation that I'm the founder and this is accurate.

Assuming this is still the metadata index that ord.io and ordinalswallet uses for collections, please merge this PR ASAP — there's a scam/drainer Discord link on the Chainspace collection right now


new GCC performances trouble

Hello, I just updated to latest version and I got half fps everywhere, even in menu,
is there some build flags I should try ?
Thanks.

no its ok, i had some old resources conflict


Export releases for iOS

The newest release should also be exported for iOS.

v0.0329 has been exported for iOS, but I'll wait for confirmation that someone can actually run it.

I'll close this issue for now. If the iOS build is flawed, we can open a bug.


An option for doing binomial+1 or epsilon-dropout from DART paper

Current coverage is 33.73% (diff: 0.00%)

Merging #1922 into master will decrease coverage by 0.15%

@@             master      #1922   diff @@
==========================================
  Files            68         68
  Lines          5281       5291    +10
  Methods         827        827
  Messages          0          0
  Branches        526        528     +2
==========================================
- Hits           1790       1785     -5
- Misses         3415       3426    +11
- Partials         76         80     +4

Powered by Codecov. Last update 7e07b2b...936f89b

I've changed to use an ugly but MSVC2013-friendly constructor of std::discrete_distribution. I've checked that it works equivalent to the iterator range-based version in gcc.
@marugari as well


vscode-unpkg.net proxy result domain replace

VS Code Version:
OS Version:

Steps to Reproduce:
web worker extension resource fetch from vscode-unpkg.net, but this domain enable cors limit:

In my case, for example like github1s.com, I must try proxy this request

visit https://xxx-static.xxx.com/proxy/vscode-unpkg/{publisher}/{extensionName}/{version}/extension
Can the return value domain name use the source domain name?
For example:
visit https://xxx-static.xxx.com/proxy/vscode-unpkg/{publisher}/{extensionName}/{version}/extension response
[
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/.eslintignore",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/.idea/",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/CHANGELOG.md",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/dist/",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/LICENSE.txt",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/package.json",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/package.nls.en.json",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/package.nls.json",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/package.nls.zh-cn.json",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/README.md",
"https://xxx-static.xxx.com/{publisher}/{extensionName}/{version}/extension/resources/"
]

@TylerLeonhardt

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


[plot] Add class to handle interactive selection

This PR adds a class InteractiveSelection to the plot tools.
This class controls interaction to request input from the user. The input can be points, rectangles, polygons, lines , horizontal and vertical lines.
It is possible to undo an input with Ctrl-Z.
It also change the structure of tests by adding a silx.gui.plot.tools.test package.
This is a first step, that it is possible to extend in different ways (not for this PR, but here to provide a list of ideas):

Implement redo
[Done] Add edition of input points/shapes
[Done] Add text markers to each shape
[Done] Allow to give the text to print in for each marker
Return 'rich' information by performing a picking under the points (or what is inside shapes)
[Done] Use it in sx.ginput
Snapping to curves

Added:

Add edition of input points/shapes
Add text markers to each shape
Allow to give the text to print in for each marker

Added a Table widget to view the current selection and manipulate it.
API updated.

Just few comments:

The architecture of InteractiveSelection looks good to me as manager of ROIs
It would be good to be able to have a addSelection with a single object as argument (already created by the user)
Maybe you could rename addSelection into createInteractiveSelection?
I am not very comfortable with updateStatusMessage and the message signals. Maybe because this class also manage the creation or ROIs while it should maybe not be it's responsibility. But i dont have clear idea, there's maybe nothing better.

Is that for silx 0.8?

Hopefully yes...

Added use in sx.ginput
Splitted class into a selection/ROI manager and stuff more dedicated to be used from the console as a blocking function.

I renamed things from Selection to RegionOfInterest and did a few fixes and changes so that I can use it for the profile interaction.
As it is now, there is a single RegionOfInterest class for all kind of shape (rectangle, polygon...). It would be more convenient to have one subclass for each, but for me that can wait.
Ready for review.

BTW, PR #1870 should be merged first.

Few comment about the GUI.

I think it would be good to set a row selection to the tableview setSelectionBehavior(qt.QAbstractItemView.SelectRows), or no selection at all
And it would be better to move the icons as toolbar on top of the widget
And remove the title "Add ROIs", but add little "+" in the icons.

Let me know if you want a patch.

Yes wouldn't mind a patch

Typo @ enum.unique -> @enum.unique?
It could be good to split the widget (widget, toolbars...) and the model (manager and object) into 2 modules (it's a big one)
The delete icon could go to the end of the row
The delete column could not have the title (it can be a smaller column without)
Add a tooltip to the delete button

I will send a patch with another PR.
LGTM.


hue sync box the synchronization is in progress stop / start

hallo
can you add a service or a button that will stop and start the sync before I can turn it off via home assistant?
thanks in advance!

Hi @jrspowers ,
There are 2 off status:

The HDMI is on, but it doesn't sync the lights. This can be achieved with hue_sync_box.set_sync_mode passing sync_mode as passthrough.

The HDMI is off (and it doesn't sync the lights). This can be achieved with remote.turn_off. Of course, turn_on and toggle works too.

Is this what you were asking for?
Thanks,
Nito

hi @nitobuendia ,
this is what i'm looking for now i do for light from hue_sync_box.set_sync_mode passthrough and for lights back on i use hue_sync_box.set_sync_mode video this work perfect and but in app mentions that sync is performed button with stop if the lights are on and start when the lights are off, which is also handy do you get it?
greetings jrspowers

Hi @jrspowers I am not sure if I follow. Let me try:
You want to make a call that:

Will stop the sync AND switch off the lights.
Will start the sync AND switch on the lights.

If yes, you should be able to achieve that with 2 components:

hue to control the lights (on and off)
hue sync box (this component) to control the sync

In order to achieve that with one button, you can create a script that will perform both actions together. If you need support in doing that, the community could help.


Possible code duplication in preparing Service Emails and Admin emails

https://github.com/shreyb/managed-tokens/blob/200b4b540da8b2f53fe37e2716d14342cb3bb56f/internal/notifications/tableUtils.go#L120
Investigate if this func can be replaced with a call to PrepareTableStringFromMap, like in this line:
https://github.com/shreyb/managed-tokens/blob/main/internal/notifications/admin.go#L464
Given that the service email table and the admin email table are the same, I think they can be the same thing.  Then maybe we don't have to duplicate the work of aggregating it in a service email AND an admin email, and just have both read from the same data structure.

This is done.  Just have to run some end-to-end tests and write documentation and this feature is done.

All tests pass.  There was one bug that came up, but has been fixed.  Now to document the changes to the AdminNotificationManager interface.

Documentation done.


[ok.ru] Download subtitle

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm requesting a site-specific feature
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Example URLs
https://ok.ru/video/4249587550747
Provide a description that is worded well enough to be understood
Download subtitle from ok.ru
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['https://ok.ru/video/4249587550747', '--no-download', '--list-subs', '-vU']
[debug] User config "/home/nir/.config/yt-dlp/config": ['--no-overwrites', '--restrict-filenames', '--merge-output-format', 'mkv', '--paths', '~/Downloads/youtube_dl', '--output', '%(title)s_%(id)s_%(autonumber)d.%(ext)s']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.11.11 [8b644025b] (source)
[debug] Lazy loading extractors is disabled
[debug] Plugins: ['SamplePluginIE', 'SamplePluginPP']
[debug] Git HEAD: 935bac1e
[debug] Python 3.8.10 (CPython x86_64 64bit) - Linux-5.15.0-56-generic-x86_64-with-glibc2.29 (OpenSSL 1.1.1f  31 Mar 2020, glibc 2.31)
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7
[debug] Optional libraries: certifi-2019.11.28, secretstorage-2.3.1, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1731 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.11.11, Current version: 2022.11.11
yt-dlp is up to date (2022.11.11)
[Odnoklassniki] Extracting URL: https://ok.ru/video/4249587550747
[Odnoklassniki]<PHONE_NUMBER>747: Downloading desktop webpage
[Odnoklassniki]<PHONE_NUMBER>747: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
4249587550747 has no subtitles

try with yt-dlp -o '%(title).20s' "https://vd265.mycdn.me/?expires=1670582591232&srcIp=<IP_ADDRESS>&srcAg=CHROME&ms=<IP_ADDRESS>&type=2&ix=0&sig=PtWWzXxbqFE&ct=13&urls=<IP_ADDRESS>&clientType=0&id=2782319872539"

This works:
diff --git a/yt_dlp/extractor/odnoklassniki.py b/yt_dlp/extractor/odnoklassniki.py
index 4f325f087..679535635 100644
--- a/yt_dlp/extractor/odnoklassniki.py
+++ b/yt_dlp/extractor/odnoklassniki.py
@@ -11,6 +11,7 @@
     int_or_none,
     qualities,
     smuggle_url,
+    traverse_obj,
     unescapeHTML,
     unified_strdate,
     unsmuggle_url,
@@ -294,6 +295,18 @@ def _extract_desktop(self, url):

         like_count = int_or_none(metadata.get('likeCount'))

+        subtitles = {}
+        for sub in traverse_obj(metadata, ('movie', 'subtitleTracks', ...), expected_type=dict):
+            sub_url = sub.get('url')
+            if not sub_url:
+                continue
+            if sub_url.startswith('//'):
+                sub_url = f'https:{sub_url}'
+            subtitles.setdefault(sub.get('language') or 'en', []).append({
+                'url': sub_url,
+                'ext': 'vtt',
+            })
+
         info = {
             'id': video_id,
             'title': title,
@@ -305,6 +318,7 @@ def _extract_desktop(self, url):
             'like_count': like_count,
             'age_limit': age_limit,
             'start_time': start_time,
+            'subtitles': subtitles,
         }

         # pladform


Reward point counter does not increase

Like we can see in the picture, the reward point counter does not increase, only decreases.

It looks like it doesn't keep track of the currently reward points, but it keeps track of when rewards are spent.

Also having this problem. Tried uninstalling reinstalling multiple times with opening and closing runelite. It's driving me nuts

Same here, still an issue

I am also still having this issue

@DatBear you will need to update the manifest to reflect the newest commit, the PR's you've accepted fixing these issues have not been applied to the live plugin-hub

Updated!


XInputGetStateEx?

There's a bunch of hidden xinput functions in later XInput versions - in particular I'm wondering if you'd be interested in a PR to get XInputGetStateEx (ordinal 100) available, which exposes the Guide button on xbox 360 controllers.
http://reverseengineerlog.blogspot.com/2016/06/xinputs-hidden-functions.html
If so, there's also the question of what the behavior should be when the function is missing.  On the one hand, implementing it as just yet another optional function would let the end user detect when it's missing.  On the other hand, you're almost certain to just fall back on regular XInputGetState in those cases...

Note: XInputGetCapabilitiesEx() also contains the vendor ID and product ID of the device, which allow deriving a stable gamepad identifier across application restarts. This is missing to allow gilrs to implement its Gamepad::uuid(), which would allow applications to e.g. save per-device user preferences (button mappings, etc.).
https://gitlab.com/gilrs-project/gilrs/-/issues/153
This StackOverflow answer has some code explaining the fields (I think they're missing from the original link): https://stackoverflow.com/questions/64251320/is-it-possible-to-get-an-xinput-devices-name-product-id-vendor-id-or-some-oth/68879988#68879988

Can you also link the appropriate MSDN or other docs page for me to reference? I can try to get this all sorted out and released this weekend.

As mentioned in those links, those APIs are unfortunately unofficial/undocumented.

Ah, okay. That's why I don't have any memory about reading docs for this function ever.
That shouldn't be a problem though, we can still do it.

Awesome, thanks! The StackOverflow link has an example code in C showing the various fields for XInputGetCapabilitiesEx().


7.0 source-built SDK packs are missing missing xml doc

The XmlDocTests caught a regression in 7.0 where it appears that all xml doc for the packs is missing.

In speaking w/@crummel, he thinks this may be caused by not picking up the SBRP versions of the packs which are the only ones with the XML doc.

General overview:
Certain target packs that should contain .xml docs in the produced source-build do contain any in 7.0.
The origin of the issue should be identified and, if plausible, fixed. The at-the-time-of-writing XmlDocTests disabled test should be updated and re-enabled to allow for catching of any similar issues in the future.
Actions to take:

verify that source-build does indeed differ in .xml doc content compared to MS build. If it does not - the issue should be pushed to other product teams up the chain
identify the reason for the issue and restore the .xml docs to the build
update the baseline for XmlDocTests and enable it for CI and local test runs

I verified the available target pack .xml docs between the source-built and the default built product and found no differences.
I also compared the existing missing docs baseline that the test in question uses with the contents of the target packs and found 3 missing .xml doc files:

Microsoft.NETCore.App.Ref\ref\netx.y\System.Net.Quic.xml
Microsoft.NETCore.App.Ref\ref\netx.y\System.Runtime.InteropServices.JavaScript.xml
Microsoft.NETCore.App.Ref\analyzers\dotnet\cs\Microsoft.Interop.JavaScript.JSImportGenerator.xml

@MichaelSimons could you please advise on the person I should refer this issue to? Thanks
Note: the dotnet/installer commit I used to build the product is 549b7d641e2f5e90ae284c3154b04cf48aa1b68f

@oleksandr-didyk,  Hmmm, that doesn't match what I see with a quick inspection.  Let me clarify what steps I think should be taken and let me know how/if that differs from what you did.  These are the steps the test is doing.

Grab a source-built SDK from CI or build one yourself.
Install the MSFT built SDK for the same commit sha or one that is close.
Retrieve a list of the XML doc files included with the Microsoft.NETCore.App.Ref and Microsoft.AspNetCore.App.Ref packs directory of both the MSFT and SB builds
Diff the two lists - there should be no differences.  I expect that you will find that most of the Microsoft.NETCore.App.Ref xml doc is missing.

The baseline file for the test represents the list of assemblies that do not container xml doc.  The reason the test stores this as a baseline is so that it can avoid having to retrieve the MSFT build to compare against.  This makes the test more efficient as well as supporting the ability to run in an offline environment.

I think I probably described the findings in a non-clear way, resulting in us miss-understanding each other. What I meant is that I got the same result as in point 4 -> the MSFT and source-built SDK do not differ in targeting packs doc content. All of the docs form the baseline are missing as you mentioned + I found additional 3 .dlls that are not stated in the baseline but also don't have a doc (the ones listed in my original comment)

Ah that makes sense.  Please work with @crummel on this as had a speculation as why this was happening.

Pinging @ViktorHofer as suggested by @crummel -> there seem to be missing docs in targeting packs that are missing from both MSFT build and source-build. Could you please advise on if this is something that runtime could take care? Thanks

I will take a look

Sorry because of conflicting priorities hadn't had a chance to look at this yet.

Hey @ViktorHofer, I understand you are busy with .NET7 release date approaching, but could you give us at least an ETA when do you think you'd be able to look into this? Cheers!

I just spoke offline with @ericstj about this and based on @oleksandr-didyk's latest comment this doesn't seem to be a source build issue but a more general case of xml files missing from the targeting pack. One observation: We don't think that source generators must produce xml files as those aren't referenced by the consumer's app but by the compiler itself. So whatever component/test complains about them missing from the targeting pack, might need an update to ignore them.
@carlossanlop can you please help with this request as you are the Intellisense expert on our team? The gist is that some of our assemblies in the targeting pack don't have a corresponding xml file. A list of identified files was shared above.
We want to look at this sooner than later as it impacts both .NET 7 and main (hence I added the blocking-release label).

this doesn't seem to be a source build issue but a more general case of xml files missing from the targeting pack.

If I look at the Microsoft targeting pack for rc1 (e.g. Microsoft.NETCore.App.Ref), I see it contains all of the xml doc.  I don't see this in the latest source built sdk

We don't think that source generators must produce xml files as those aren't referenced by the consumer's app but by the compiler itself

I am expecting users of a source-build SDK would have intellisense documentation when utilizing the source-built targeting packs.

The gist is that some of our assemblies in the targeting pack don't have a corresponding xml file.

Source build is missing all of xml doc for Microsoft.NETCore.App.Ref.  It is present for Microsoft.AspNetCore.App.Ref.

The issue here is that https://github.com/dotnet/runtime/pull/59937 was not backported from 6.0 to main/7.0.  @carlossanlop is going to backport the PR and I will update the text-only source-build-reference-package to the be latest.


Update context 'remove' flag var name to avoid collision with 'text' OT type method

Fixes #380.
I've updated the context 'remove' flag var name to 'shouldBeRemoved' as proposed on the discussion of the issue mentioned above. Context remove flag name was updated to avoid collision with the method remove(pos, length, callback) of the 'text' OT type. This collision was causing issues that are documented on the ShareJS GitHub repository, such as #380 and #382.

Thanks!


let's learn maths!

I like this one.

What do you think about the f-string example, @giangbui123 ?

looks cool :D


Syntax for conditional field visibility based on multi-choice checkbox selection

Hi, is there a more comprehensive list of supported syntax functions for conditional field visibility? I'm trying to confirm if it is possible to show or hide a field based on the selection/s in a multi-choice checkbox drop-down. I have tried Find and Search to search within the multi-choice field's output string but does not appear to be supported?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 536f88e0-51aa-9a3a-20da-64b4a8b155a1
Version Independent ID: efa34015-6402-a024-ae62-3b0c6c0865ea
Content: Show or hide columns in a list form
Content Source: docs/declarative-customization/list-form-conditional-show-hide.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

@andrewconnell This is for list-form conditional show hide customization. Clearing the list-formatting tag.


Login issue

Following error related to google API when attempting to login.
Error is : Uncaught gapi.auth2.ExternallyVisibleError: Missing required parameter 'client_id'
Error occurs in all browsers. Also error messages are not displaying correctly on failed login. Partial information showing on Edge but not other browsers.

Thank you for pointing out the bug. :+1:
This patch has changed the  overridden file "Frapid.Account/Views/SignIn/Index.cshtml".
Replace the Overridden File
Copy the file from :
src/Frapid.Web/Areas/Frapid.Account/Override/Frapid.Account/Views/SignIn/Index.cshtml
and paste/replace it on
src/Frapid.Web/Catalogs/<tenant>/Areas/Frapid.Account/Views/SignIn/Index.cshtml
Build Solutions
Build all solutions using the msbuild script src/builds/all.bat
Confirm If This Patch Fixes the Issue
Please feel free to close this if the patch actually fixes the bug.

Can confirm the error related to Google API is now gone but it still does not login.


Django 1.11 compatibility

If anyone haven't stepped yet I am interested to start working on django 1.11 support on wagtail

https://github.com/wagtail/wagtail/pull/3284 starting

Closing this in favour of #3314 where we track all the 1.11 compatibility efforts.