yarn tauri init doesn't work on my fedora machine. Help

Describe the bug
Hi, I'm starting with Tauri but I couldn't pass the yarn tauri init.  I tried first using pnpm, then npm, then yarn, and all of them give the same error. If i enter yarn tauri it works, version and help also work, but anything else throws error.
PS.: the only difference in my machine is that it uses volta instead of nvm. Could that be it??
To Reproduce
Steps to reproduce the behavior:

Install all dependencies necessary for fedora (with volta instead of npm).
Create a project folder.
With yarn installed by volta (volta install yarn), run yarn add @tauri-apps/cli.
Run yarn tauri init.
See error.

Expected behavior
Should install.
Platform and Versions (please complete the following information):
OS: Fedora 33 (Workstation Edition), 64 bit, GNOME Version: 3.38.5, Windowing System: Wayland; fully updated.
Node: v14.16.1
Yarn: 1.22.10
Rustc: rustc 1.51.0 (2fd73fabe 2021-03-23)
Stack Trace
yarn run v1.22.10
$ /home/gabriel/Documents/VSCode/mini-browser/node_modules/.bin/tauri init
app:spawn Running "/home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/bin/tauri-cli tauri init" +0ms
events.js:292
throw er; // Unhandled 'error' event
^
Error: spawn /home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/bin/tauri-cli EACCES
at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
at onErrorNT (internal/child_process.js:465:16)
at processTicksAndRejections (internal/process/task_queues.js:80:21)
Emitted 'error' event on ChildProcess instance at:
at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
at onErrorNT (internal/child_process.js:465:16)
at processTicksAndRejections (internal/process/task_queues.js:80:21) {
errno: -13,
code: 'EACCES',
syscall: 'spawn /home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/bin/tauri-cli',
path: '/home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/bin/tauri-cli',
spawnargs: [ 'tauri', 'init' ]
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Getting the same issue on macOS, was just about to post an issue for it.
Also, running npx create-tauri-app gives me this error:
===== running tauri init =====

> tauri-app@ tauri /Users/kasper/dev/git/riddle/x/tauri-app
> tauri "init" "--app-name" "tauri-app" "--window-title" "Tauri App" "--dist-dir" "../dist" "--dev-path" "../dist"

Downloading Tauri CLI
(node:11509) UnhandledPromiseRejectionWarning: HTTPError: Response code 404 (Not Found)
    at Request._onResponseBase (/Users/kasper/dev/git/riddle/x/tauri-app/node_modules/got/dist/source/core/index.js:899:31)
    at Request._onResponse (/Users/kasper/dev/git/riddle/x/tauri-app/node_modules/got/dist/source/core/index.js:934:24)
    at ClientRequest.<anonymous> (/Users/kasper/dev/git/riddle/x/tauri-app/node_modules/got/dist/source/core/index.js:948:23)
    at Object.onceWrapper (events.js:422:26)
    at ClientRequest.emit (events.js:327:22)
    at ClientRequest.origin.emit (/Users/kasper/dev/git/riddle/x/tauri-app/node_modules/@szmarczak/http-timer/dist/source/index.js:39:20)
    at HTTPParser.parserOnIncomingClient (_http_client.js:641:27)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:126:17)
    at TLSSocket.socketOnData (_http_client.js:509:22)
    at TLSSocket.emit (events.js:315:20)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:11509) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:11509) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Your issue was triggered because the prebuilt CLI binary wasn't published. It is published now, give it a try and it should work. You will probably have to reinstall the js package so that the prebuilt CLI is redownloaded as well.

Closing issue. If it is still happening, by all means reopen it.

Hi again, not sure if it is relatively the same issue but yarn tauri info gives out an error. yarn tauri init is working now.
Error:
yarn run v1.22.10
$ /home/gabriel/Documents/VSCode/mini-browser/node_modules/.bin/tauri info
 app:spawn Running "/home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/bin/tauri-cli tauri info" +0ms

Operating System - Fedora, version 33.0.0 X64

Node.js environment
Error: missing field `js_cli` at line 8 column 1

 app:spawn Command "/home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/bin/tauri-cli" failed with exit code: 1 +1ms
(node:9569) UnhandledPromiseRejectionWarning: Error
    at d (/home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/dist/helpers/rust-cli.js:1:6078)
    at w (/home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/dist/helpers/rust-cli.js:1:6119)
    at ChildProcess.<anonymous> (/home/gabriel/Documents/VSCode/mini-browser/node_modules/@tauri-apps/cli/dist/helpers/rust-cli.js:1:7250)
    at ChildProcess.emit (events.js:315:20)
    at maybeClose (internal/child_process.js:1048:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:9569) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:9569) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Done in 0.22s.

@Gabriel-Alves-Cunha this is issue has been reported and fixed but not released yet. It should be released soon

@Gabriel-Alves-Cunha this is issue has been reported and fixed but not released yet. It should be released soon

Oh, ok. Thank you :)

Thanks for reporting this and fixing it so quickly ♥ I'm having the exact same issue on Ubuntu 20.04 under WSL 😀
🚀

Hi!
I'm on windows, and i have same error with yarn tauri init command.
F:\perso\simple-calculator>yarn tauri init
yarn run v1.22.10
$ tauri init
 app:spawn Running<EMAIL_ADDRESS>tauri init" +0ms

What is your app name?: Error: Not a terminal

 app:spawn Command<EMAIL_ADDRESS>failed with exit code: 1 +0ms
(node:7696) UnhandledPromiseRejectionWarning: Error
    at d (F:\perso\simple-calculator\node_modules\@tauri-apps\cli\dist\helpers\rust-cli.js:1:6078)
    at w (F:\perso\simple-calculator\node_modules\@tauri-apps\cli\dist\helpers\rust-cli.js:1:6119)
    at ChildProcess.<anonymous> (F:\perso\simple-calculator\node_modules\@tauri-apps\cli\dist\helpers\rust-cli.js:1:7250)
    at ChildProcess.emit (events.js:315:20)
    at ChildProcess.cp.emit (F:\perso\simple-calculator\node_modules\cross-spawn\lib\enoent.js:34:29)
    at maybeClose (internal/child_process.js:1048:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:7696) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:7696) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Done in 2.12s.

F:\perso\simple-calculator>

My package.json config :
{
  "name": "simple-calculator",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "tauri": "tauri"
  },
  "dependencies": {
    "@tauri-apps/cli": "^1.0.0-beta-rc.2"
  }
}

@loicngr this is a know issue, tracked at #1492


Issue/new agent integrate

Description
Separate the executor from the agent.
This makes one major breaking change, in that the current handlers get a reference to the agent instance.
This can not remain when the agent instance is in a different process
Overview:

merge the interfaces from both branches to executor.py
move agent's actual execution code to in_process_executor.py and remove all reference to the agent. This allows this code to be re-used as is on the remote side as well.
move the venv management to remote executor only
introduce the new executor.AgentInstance api, that is the interface seen by the handler

Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Pull request rejected by merge tool. Failed to parse change entry file: Change entry /tmp/tmp32lqr0uu/changelogs/unreleased/agent_executor_5.yml does not match pydantic schema: 1 validation error for ChangeEntry
sections
Input should be a valid dictionary [type=dict_type, input_value=[{'upgrade-note': "Handle...ernals, it may break."}], input_type=list]
For further information visit https://errors.pydantic.dev/2.6/v/dict_type

Processing this pull request

Merged into branches master in 48a780475ae561c988deefc0ba667b919ca98793


Panic after upgrade 2.4.3 to 2.7.1

When upgrading Prometheus from 2.4.3 to 2.7.1
 level=info ts=2019-02-11T12:26:44.709257742Z caller=kubernetes.go:201 component="discovery manager scrape" discovery=k8s msg="Using pod service account via in-cluster config"
 level=info ts=2019-02-11T12:26:44.710505333Z caller=kubernetes.go:201 component="discovery manager scrape" discovery=k8s msg="Using pod service account via in-cluster config"
 level=info ts=2019-02-11T12:26:44.711558252Z caller=kubernetes.go:201 component="discovery manager scrape" discovery=k8s msg="Using pod service account via in-cluster config"
 level=info ts=2019-02-11T12:26:44.712770757Z caller=kubernetes.go:201 component="discovery manager scrape" discovery=k8s msg="Using pod service account via in-cluster config"
 level=info ts=2019-02-11T12:26:44.714364213Z caller=kubernetes.go:201 component="discovery manager scrape" discovery=k8s msg="Using pod service account via in-cluster config"
 level=info ts=2019-02-11T12:26:44.715412567Z caller=kubernetes.go:201 component="discovery manager scrape" discovery=k8s msg="Using pod service account via in-cluster config"
 level=info ts=2019-02-11T12:26:44.716649605Z caller=kubernetes.go:201 component="discovery manager notify" discovery=k8s msg="Using pod service account via in-cluster config"
 level=info ts=2019-02-11T12:26:44.727791547Z caller=main.go:722 msg="Completed loading of configuration file" filename=/etc/prometheus/config_out/prometheus.env.yaml
-config-reloader level=info ts=2019-02-11T12:26:44.72825157Z caller=reloader.go:208 msg="Prometheus reload triggered" cfg_in=/etc/prometheus/config/prometheus.yaml.gz cfg_out=/etc/prometheus/config_out/prometheus.env.yaml rule_dirs=
 level=error ts=2019-02-11T12:26:49.646633379Z caller=scrape.go:147 component="scrape manager" scrape_pool=istio-demo/istio-demo-istio-demo-servicemonitor/0 msg="Error creating HTTP client" err="unable to use specified CA cert /etc/prometheus/secrets/istio-prometheus-certs/root-cert.pem: open /etc/prometheus/secrets/istio-prometheus-certs/root-cert.pem: no such file or directory"
 level=error ts=2019-02-11T12:26:49.648118428Z caller=scrape.go:147 component="scrape manager" scrape_pool=pieabo/pieabo-pieabo-servicemonitor/0 msg="Error creating HTTP client" err="unable to use specified CA cert /etc/prometheus/secrets/istio-prometheus-certs/root-cert.pem: open /etc/prometheus/secrets/istio-prometheus-certs/root-cert.pem: no such file or directory"
 level=warn ts=2019-02-11T12:26:50.757977344Z caller=scrape.go:1091 component="scrape manager" scrape_pool=monitoringctl/monitoringctl-alertmanager-bolcom-dev-d0t-platform/0 target=http://<IP_ADDRESS>:9093/metrics msg="Error on ingesting samples with different value but same timestamp" num_dropped=3
 level=warn ts=2019-02-11T12:26:52.300550842Z caller=scrape.go:1091 component="scrape manager" scrape_pool=monitoring/alertmanager-bolcom-dev-d0t-platform/0 target=http://<IP_ADDRESS>:9093/metrics msg="Error on ingesting samples with different value but same timestamp" num_dropped=14
 level=warn ts=2019-02-11T12:27:00.961245949Z caller=scrape.go:1091 component="scrape manager" scrape_pool=monitoring/bolcom-dev-d0t-platform-pushgateway/0 target=http://<IP_ADDRESS>:9091/metrics msg="Error on ingesting samples with different value but same timestamp" num_dropped=11

 panic: runtime error: invalid memory address or nil pointer dereference
 [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x669c12]

 goroutine 2928 [running]:
 net/http.(*Client).deadline(0x0, 0xc0246422f8, 0x40bb8f, 0xc033d3f440)
 	/usr/local/go/src/net/http/client.go:187 +0x22
 net/http.(*Client).do(0x0, 0xc01b4ff000, 0x0, 0x0, 0x0)
 	/usr/local/go/src/net/http/client.go:527 +0xab
 net/http.(*Client).Do(0x0, 0xc01b4ff000, 0x23, 0xc00d75b350, 0x9)
 	/usr/local/go/src/net/http/client.go:509 +0x35
 github.com/prometheus/prometheus/scrape.(*targetScraper).scrape(0xc03ae12c00, 0x1fd4a60, 0xc00f876de0, 0x1fb2760, 0xc0352e6af0, 0x0, 0x0, 0x0, 0x0)
 	/app/scrape/scrape.go:471 +0x111
 github.com/prometheus/prometheus/scrape.(*scrapeLoop).run(0xc03a95f480, 0x6fc23ac00, 0x2540be400, 0x0)
 	/app/scrape/scrape.go:813 +0x487
 created by github.com/prometheus/prometheus/scrape.(*scrapePool).sync
 	/app/scrape/scrape.go:336 +0x45d

Related to https://github.com/prometheus/prometheus/issues/5172 ?

Yes it looks the same problem as #5172... Would you mind closing this one?

Closing as it is the same stack trace and already covered by #5172. Thanks for the report anyway!


⚠ Bofrost.be has degraded performance

In 208fdd8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1272 ms

Resolved: Bofrost.be performance has improved in fe666a0 after 6 minutes.


totalCount not defined for UsePaging for v11.1

Relay-style cursor pagination works well according to the spec. But in previous versions it was possible to get a field totalCount as automatically added metadata as well (manual: https://chillicream.com/blog/2020/03/18/entity-framework ). Now for version 11.1, when trying to add this field to the request, an error occurs: "The field totalCount does not exist on the type MasterConnection.".
Code:
public class Query
{
    [UseDbContext(typeof(Context))]
    [UsePaging(typeof(MasterType))]
    [UseFiltering]
    [UseSorting]
    public IQueryable<Master> GetContacts([ScopedService] Context context)
    {
        return context.Masters;
    }
}

query {
masters(first : 10) {
totalCount
edges {
cursor
node {
id
}
}
pageInfo {
hasNextPage
hasPreviousPage
startCursor
endCursor
}
}
}

There is IncludeTotalCount in the class UsePagingAttribute which determines whether to add this field.


Resource representation is only available with these Content-Types:\napplication/json; charset=UTF-8

{
"activationId": "fb53bf3368bc4f60bb6730d50fda3f9b",
"annotations": [
{
"key": "limits",
"value": {
"logs": 10,
"memory": 256,
"timeout": 60000
}
},
{
"key": "path",
"value": "guest/messaging/kafkaFeed"
}
],
"duration": 50,
"end":<PHONE_NUMBER>679,
"logs": [],
"name": "kafkaFeed",
"namespace": "guest",
"publish": false,
"response": {
"result": {
"error": {
"code": 4715,
"error": "Resource representation is only available with these Content-Types:\napplication/json; charset=UTF-8"
}
},
"status": "application error",
"success": false
},
"start":<PHONE_NUMBER>629,
"subject": "guest",
"version": "0.0.2"
}
I see this error when i am trying to create a trigger
wsk trigger create /guest/MyKafkaTrigger -f /guest/messaging/kafkaFeed -p brokers "["<IP_ADDRESS>:5000"]" -p topic mytopic -p isJSONData false -p endpoint <IP_ADDRESS>

@golisandeep3 Just off the top of my head, it looks like may need to escape quotes around your broker -p brokers "[\"<IP_ADDRESS>:5000\"]". Additionally, the brokers param also accepts a comma-separated list of brokers, which would free you from having to use JSON format on the command line.
Please let me know if this resolves your issue.


Immediate Abort of Scanning Process

Current Behavior
I've done everything as I'm supposed to, as far as I'm aware, but I'll detail the process.
I unzipped the Kamera app after downloading, and opened the .exe program.
I've opened Genshin and switched my window to 1600x900 (Windowed) and then went back to the Paimon Menu.
My controls are set to Keyboard, and I don't have Inventory (B) or Characters (C) bound to anything but B and C
I try to scan, and the app immediately aborts the scan, throwing this error:
System.DllNotFoundException:` Failed to find library "tesseract41.dll" for platform x86.

   at InteropDotNet.LibraryLoader.LoadLibrary(String fileName, String platformName)

   at InteropRuntimeImplementer.TessApiSignaturesInstance.TessApiSignaturesImplementation..ctor(LibraryLoader loader)

These files are in the folder, but don't seem to be found.
Expected Behavior
The scanner continues to scan
Reproducing a Behavior
I don't know, as I opened the program and immediately experienced the error upon trying to scan.
Device OS
Windows 11
Genshin Impact Version
3.0
Inventory Kamera Version
1.3
Screen resolution, screen mode, and UI scale
1600x900
Additional notes and remarks
I did find a few threads with similar issues but they had no solutions because the OPs didn't include enough information.
Evidence
System.DllNotFoundException: Failed to find library "tesseract41.dll" for platform x86.
at InteropDotNet.LibraryLoader.LoadLibrary(String fileName, String platformName)
at InteropRuntimeImplementer.TessApiSignaturesInstance.TessApiSignaturesImplementation..ctor(LibraryLoader loader)

edit: formatting
Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[X] I tried setting the scanning delay to maximum, and it still doesn't work.
[ ] I have attached the video recording to the bug report.
[X] I have attached the error log to the bug report.
[X] I am available to later explains the issue.
[X] I have disabled all screen filtering software or plugins (i.e. HDR, Image Sharpening) while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

System.DllNotFoundException: Failed to find library "tesseract41.dll" for platform x86.

Please make sure you unzipped the release completely and the x86 and x64 folders exist with two files in them

Unless I'm mistaken I believe I have already?

I run Genshin on an external hard drive, could it have to do with that?

That's not likely. Do you have the latest packages from Microsoft?

I'll double check! I believe I have the 64 but not the 86 version. Where do these go on my computer once I get them downloaded?

The default installer should be fine.

That got it working, thank you!


Bumps Harp 0.15

Update harp version

I've been having an issue with node-sass bundled with Harp:
child_process: customFds option is deprecated, use stdio instead.
child_process: customFds option is deprecated, use stdio instead.

Updating to harp 0.15 seemed to fix this so would suggest merging this pull request.


Identical compiler warnings in problems panel

Brief Issue Summary
When compiling a project with multiple translation units that have warnings in some common include file they are shown multiple times. All of them work and open the same file in the same position.

Expected:
There are no identical warnings.
Apparent Behavior:
Identical warnings are shown.
Minimal project to reproduce:
CmakeLists.txt:
cmake_minimum_required(VERSION 3.16)
project(Test)

add_executable(Test main.cpp Foo.cpp)
target_compile_options(Test PRIVATE -Wextra)

main.cpp:
#include "Foo.hpp"
#include "Duplicate.hpp"

int main() { return 0; }

Foo.hpp:
#pragma once

#include "Duplicate.hpp"

Foo.cpp:
#include "Foo.hpp"

Duplicate.hpp:
#pragma once

class Duplicate {
public:
  void test(int i) {}
};

Multiple unused-parameter warnings should be shown in problems pannel.

Build output:
[main] Building folder: Test clean
[build] Starting build
[proc] Executing command: /usr/bin/cmake --build /mnt/media/dev/projects/Test/build/Clang-linux/Debug --config Debug --target clean --
[build] [1/1 100% :: 0.003] Cleaning all built files...
[build] Cleaning... 3 files.
[build] Build finished with exit code 0
[main] Building folder: Test
[build] Starting build
[proc] Executing command: /usr/bin/cmake --build /mnt/media/dev/projects/Test/build/Clang-linux/Debug --config Debug --target all -- -j 18
[build] [2/3  33% :: 0.022] Building CXX object CMakeFiles/Test.dir/Foo.cpp.o
[build] In file included from ../../../Foo.cpp:1:
[build] In file included from ../../../Foo.hpp:3:
[build] ../../../Duplicate.hpp:5:17: warning: unused parameter 'i' [-Wunused-parameter]
[build]   void test(int i) {}
[build]                 ^
[build] 1 warning generated.
[build] [2/3  66% :: 0.022] Building CXX object CMakeFiles/Test.dir/main.cpp.o
[build] In file included from ../../../main.cpp:1:
[build] In file included from ../../../Foo.hpp:3:
[build] ../../../Duplicate.hpp:5:17: warning: unused parameter 'i' [-Wunused-parameter]
[build]   void test(int i) {}
[build]                 ^
[build] 1 warning generated.
[build] [3/3 100% :: 0.330] Linking CXX executable Test
[build] Build finished with exit code 0

Platform and Versions

Operating System: Arch Linux
CMake Version:  3.17.3
VSCode Version: Latest insiders
CMake Tools Extension Version: 1.4.1
Compiler/Toolchain: Clang 10.0.0

Other Notes/Information

Still happening with cmake-tools 1.15.31

@sean-mcmanus @bobbrow Should this be transferred to vscode-cpptools? Or is this actually a cmake-tools issue. Thanks!

@gcampbell-msft It seems external to me. The warnings are coming from GCC. The user can set the command line arguments to disable the warnings or fix the warnings.

@gcampbell-msft Oh, I see the bug is with the duplicates -- still, it's coming from the "GCC" problem matcher which isn't from our extension (our extension provides the "gcc" problem matcher, lower cased).

@Lightirius It seems like this issue may be coming from whatever is providing the "GCC" problem matcher, do you have an extension contributing this or some other problem matcher set up?

@gcampbell-msft Retested with only cmake-tools installed - this is the build output from the same minimal project:

"cmake-build-diags" matcher is not from cmake-tools extension?
Also it's not exactly a bug, more of a feature request to filter identtical warnings/errors from build output
Full output from configure+build:
[main] Building folder: cmake-tools-duplicated-warnings clean
[proc] Executing command: D:\apps\scoop\shims\cmake.EXE --version
[proc] Executing command: D:\apps\scoop\shims\cmake.EXE -E capabilities
[main] Configuring project: cmake-tools-duplicated-warnings
[proc] Executing command: D:\apps\scoop\shims\cmake.EXE -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_STANDARD=20 -DCMAKE_CXX_STANDARD_REQUIRED=YES -DCMAKE_CXX_EXTENSIONS=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=YES -DCMAKE_INSTALL_PREFIX=S:/dev/projects/bugs/cmake-tools-duplicated-warnings/out/install/Clang-Debug -SS:/dev/projects/bugs/cmake-tools-duplicated-warnings -BS:/dev/projects/bugs/cmake-tools-duplicated-warnings/out/build/Clang-Debug -G Ninja
[cmake] -- Configuring done (0.1s)
[cmake] -- Generating done (0.0s)
[cmake] -- Build files have been written to: S:/dev/projects/bugs/cmake-tools-duplicated-warnings/out/build/Clang-Debug
[build] Starting build
[proc] Executing command: chcp
[proc] Executing command: D:\apps\scoop\shims\cmake.EXE --build S:/dev/projects/bugs/cmake-tools-duplicated-warnings/out/build/Clang-Debug --parallel 18 --target clean
[build] [1/1] Cleaning all built files...
[build] Cleaning... 3 files.
[driver] Build completed: 00:00:00.152
[build] Build finished with exit code 0
[main] Building folder: cmake-tools-duplicated-warnings
[build] Starting build
[proc] Executing command: D:\apps\scoop\shims\cmake.EXE --build S:/dev/projects/bugs/cmake-tools-duplicated-warnings/out/build/Clang-Debug --parallel 18
[build] [1/3] Building CXX object CMakeFiles/Test.dir/main.cpp.obj
[build] In file included from S:/dev/projects/bugs/cmake-tools-duplicated-warnings/main.cpp:1:
[build] In file included from S:/dev/projects/bugs/cmake-tools-duplicated-warnings/Foo.hpp:3:
[build] S:/dev/projects/bugs/cmake-tools-duplicated-warnings/Duplicate.hpp:5:17: warning: unused parameter 'i' [-Wunused-parameter]
[build]     5 |   void test(int i) {}
[build]       |                 ^
[build] 1 warning generated.
[build] [2/3] Building CXX object CMakeFiles/Test.dir/Foo.cpp.obj
[build] In file included from S:/dev/projects/bugs/cmake-tools-duplicated-warnings/Foo.cpp:1:
[build] In file included from S:/dev/projects/bugs/cmake-tools-duplicated-warnings/Foo.hpp:3:
[build] S:/dev/projects/bugs/cmake-tools-duplicated-warnings/Duplicate.hpp:5:17: warning: unused parameter 'i' [-Wunused-parameter]
[build]     5 |   void test(int i) {}
[build]       |                 ^
[build] 1 warning generated.
[build] [3/3] Linking CXX executable Test.exe
[driver] Build completed: 00:00:00.953
[build] Build finished with exit code 0

CmakePresets.json used for configuration:
{
   "version": 2,
   "cmakeMinimumRequired": {
      "major": 3,
      "minor": 20,
      "patch": 0
   },
   "configurePresets": [
      {
         "name": "Base",
         "hidden": true,
         "binaryDir": "${sourceDir}/out/build/${presetName}",
         "generator": "Ninja",
         "cacheVariables": {
            "CMAKE_CXX_STANDARD": "20",
            "CMAKE_CXX_STANDARD_REQUIRED": "YES",
            "CMAKE_CXX_EXTENSIONS": "OFF",
            "CMAKE_EXPORT_COMPILE_COMMANDS": "YES",
            "CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}"
         }
      },
      {
         "name": "Clang-Debug",
         "displayName": "Clang Debug",
         "inherits": "Base",
         "cacheVariables": {
            "CMAKE_BUILD_TYPE": "Debug",
            "CMAKE_C_COMPILER": "clang",
            "CMAKE_CXX_COMPILER": "clang++"
         }
      }
   ]
}

@Lightirius cmake-build-diags is from the cmake-tools extension, but I don't think that is fixable using problem matchers, and the identical compiler warnings are from building different 2 different translation units with the same header, so it's somewhat "by design".

@sean-mcmanus, sorry for a long delay
If it's working as intended or not an issue with cmake-tools feel free to close this issue or change it to a feature request instead
Out of curiocity, i've checked how vs-code problem matchers in tasks handle this situation.
I may be missing something, but with this tasks.json file there are no duplicated messages in problems panel:
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Custom Cmake build",
            "type": "shell",
            "command": "cmake --build .",
            "options": {
                "cwd": "${workspaceFolder}/out/build/Clang-Debug"
            },
            "problemMatcher": {
                "owner": "cpp",
                "fileLocation": "absolute",
                "pattern": {
                    "regexp": "^(.*):(\\d+):(\\d+):\\s+(warning|error):\\s+(.*)$",
                    "file": 1,
                    "line": 2,
                    "column": 3,
                    "severity": 4,
                    "message": 5
                }
            }
        }
    ]
}

I am not a TS dev and don't really know how VS code plugins work so the next part may be wrong/irrelevant.
I've dug a little bit into the cmake-tools implementation to find where diagnostics are parsed and collected.
It looks like they are parsed and initially collected in: https://github.com/microsoft/vscode-cmake-tools/blob/15c6e4c8acfe41c156086798a9c29460e40b4071/src/diagnostics/util.ts#L101
Then converted to VS Code diagnostics in: https://github.com/microsoft/vscode-cmake-tools/blob/15c6e4c8acfe41c156086798a9c29460e40b4071/src/diagnostics/build.ts#L49
And finally put into DiagnosticCollection in: https://github.com/microsoft/vscode-cmake-tools/blob/15c6e4c8acfe41c156086798a9c29460e40b4071/src/diagnostics/util.ts#L68
For me, it looks like it should be relatively straightforward to implement some sort of filtering in one of those places

@Lightirius Yeah, it looks like you're right -- I mistakenly thought they implemented it with a problemMatcher in their package.json (like the gcc problem matcher in vscode-cpptools), but it is not.


Add documentation to Discord examples

Questions pop up from time to time in our Discord channels, GitHub (for example https://github.com/badges/shields/issues/1659), etc. regarding the process for leveraging our Discord badges.
It would be great to add those steps inline within the Discord example so that users could see that information directly on Shields.
For anyone interested in tackling this one, all that's needed is to add a "documentation": ... key to this object with the relevant info.
Here's a couple examples of other Services with docs for reference:

CII Best Practices
Azure DevOps Build

I will try doing this before attempting the W3C badge.

Thanks!

@calebcartwright Should we include the instructions for enabling the Discord server widget. I made the following video but embedding it adds an image about 311k to the page.

Ideally there'd be some external docs/guides/videos/etc that we could simply link to from our inline text

Closed by #4117, thanks @seetd !


Quantization with pytorch yolov5

I want to quantize the Pytorch yolov5 model. But I don't know how to fill in quantize.py and other necessary files. I couldn't find any tutorial on this topic. The transactions I mentioned in the #675 issue have been done successfully. I want to do exactly what was done there. Can anyone help me on what to do about this?

Hi @alpereenkaratas
Thanks for your interest in Vitis-AI toolchain. Due to the license issue, we have not publicly released yolov5 related content for the time being.
But in the next version Vitis-AI 3.0, we plan to give more reference information for latest yolo series including v5 and v6. The expected release time is in 2023.1.

Closing since no activity for more than 2 weeks, please reopen if you still have question, thanks

I want to quantize the Pytorch yolov5 model. But I don't know how to fill in quantize.py and other necessary files. I couldn't find any tutorial on this topic. The transactions I mentioned in the #675 issue have been done successfully. I want to do exactly what was done there. Can anyone help me on what to do about this?

Hello @alpereenkaratas I am facing the same problem and I don´t know how to fill the quant.py file. Did you find any resources regarding that?


Introduce endpoints/schemas for handling legacy tasks in V2

closes #1378
closes #1381
Checklist before merging

[ ] I added an appropriate entry to CHANGELOG.md
[ ] I merged main into the current branch.

This is not expected


input:off_window_axis_events values

hyprwm/Hyprland#4177
Am I allowed to use line-breaks?

Am I allowed to use line-breaks?

idfk but I'd rather not


Allow switch_inline_query_current_chat on InlineKeyboardButton

We can also send switch_inline_query_current_chat according to Telegram docs. So I'm allowing this option on the InlineKeyboardButton struct as well.
https://core.telegram.org/bots/api#inlinekeyboardbutton

Merged. Thanks for your contribution!


Config to lint filenames for snake_case

Install https://github.com/loeffel-io/ls-lint
[ ] Add to CI

FAO @karensawrey

Yeah, you can just add a specific file or directory to the ignore list.

Also part of DOC-160

Left a request for better error messages at https://github.com/loeffel-io/ls-lint/issues/62


To Display Spiral Matrix (GFG)

Aim
Given a matrix of size r*c. Traverse the matrix in spiral form.
link to the Question:-  https://practice.geeksforgeeks.org/problems/spirally-traversing-a-matrix-1587115621/1#
Details
We have given a matrix and we have to display it's spiral form.
For Example:-
Input:
r = 4, c = 4
matrix[][] = {{1, 2, 3, 4},
{5, 6, 7, 8},
{9, 10, 11, 12},
{13, 14, 15,16}}
Output:
1 2 3 4 8 12 16 15 14 13 9 5 6 7 11 10
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

@ravikr126 Please assign me this issue under LGM-SOC'21.
I will add the solution in C++

Hi,
I want to implement this in java as apart of LGM-SOC'21.
@ravikr126 @Amit366 Please assign it to me. Thankyou!!


Add 'Notes' Feature : Convert notes into txt

Codecov Report

Merging #158 (1a80aad) into master (1ae98db) will decrease coverage by 0.19%.
The diff coverage is 45.00%.

:exclamation: Current head 1a80aad differs from pull request most recent head 33cd1e3. Consider uploading reports for the commit 33cd1e3 to get more accurate results

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     56.08%   55.88%   -0.20%
- Complexity      749      753       +4
============================================
  Files           160      162       +2
  Lines          3001     3035      +34
  Branches        294      297       +3
============================================
+ Hits           1683     1696      +13
- Misses         1207     1226      +19
- Partials        111      113       +2

Impacted Files
Coverage Δ
Complexity Δ

...eedu/dictionote/logic/parser/DictionoteParser.java
62.74% <0.00%> (-1.26%)
28.00 <0.00> (ø)

src/main/java/seedu/dictionote/model/Model.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

...main/java/seedu/dictionote/model/ModelManager.java
58.92% <16.66%> (-1.57%)
39.00 <0.00> (ø)

...ctionote/logic/commands/ConvertTxtNoteCommand.java
17.64% <17.64%> (ø)
2.00 <2.00> (?)

...rc/main/java/seedu/dictionote/model/note/Note.java
68.49% <80.00%> (+0.37%)
15.00 <0.00> (ø)

...note/logic/parser/ConvertTxtNoteCommandParser.java
100.00% <100.00%> (ø)
2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae98db...33cd1e3. Read the comment docs.


sdk: Extract curve syscalls

Problem
There is now a curve25519 crate but its syscalls are still being defined by solana-program.
Summary of Changes
Extract the definition of curve syscalls out of solana-program and place them into a syscalls module under the curve25519 crate, re-exporting them to maintain backwards compatibility. As a side-effect, curve25519 does not depend on solana-program (the dependency is inverted).
Definitions moved:

sol_curve_validate_point
sol_curve_group_op
sol_curve_multiscalar_mul
sol_curve_pairing_map

This would add a big dependency to solana-program

This would add a big dependency to solana-program. I really think the curve syscalls should live separately from solana-curve25519 because they have no heavy dependencies #3405

Good point! At the moment we have the syscalls generally together with their corresponding types (e.g., solana_msg, solana_pubkey). Wonder if having a separate crate specifically to declare the curve ones would create confusion/inconsistency by mixing the way they are declared.
I don't have a solution for it, but perhaps having them all declared in a separate crate would be clearer – e.g., solana-syscalls – and each type can re-export their own ones. In this case, solana-curve25519 would re-export the sol_curve_* syscalls from solana-syscalls and solana-program would only have dependency to solana-syscalls.

don't have a solution for it, but perhaps having them all declared in a separate crate would be clearer – e.g., solana-syscalls

Unfortunately some of the syscalls bring extra dependencies like solana-instruction and solana-pubkey so moving them all to a single crate would break things (solana-instruction would now have a circular dependency).
Hence why in the PR I linked I just moved what remains in solana-program, because those syscall definitions just require primitive types

don't have a solution for it, but perhaps having them all declared in a separate crate would be clearer – e.g., solana-syscalls

Unfortunately some of the syscalls bring extra dependencies like solana-instruction and solana-pubkey so moving them all to a single crate would break things (solana-instruction would now have a circular dependency).
Hence why in the PR I linked I just moved what remains in solana-program, because those syscall definitions just require primitive types.
I thought about making a new crate for those syscalls but one problem was I couldn't think of a name. And I didn't want to make multiple crates since they all compile so quickly already

Oh, I like that – sorry, did not follow the link the first time I read your message. We could also re-export the syscalls from their "own" crates – e.g., curve25519 could re-export all sol_curve* ones.

We could also re-export the syscalls from their "own" crates – e.g., curve25519 could re-export all sol_curve* ones.

Yes I think this is a good idea

Closed in favour of #3405


Unsafe encoding

This the first step of a feasibility study of using Span for bytes-like objects (triggered by #762). I address here my first concern for encodings not having access to the underlying byte[] hence needing to copy data to a new array every time on decode.
I did the experiments in net45; I didn't want to get sidetracked by the target upgrade. Once the project target is upgraded to .NET 4.6, we can use/override Encoding.GetString(bytes*, ...), which will eliminate a few copy actions in my feasibility code. Since those changes are straightforward, there is no need to address them in this exercise.
My first concern was the feasibility of Span (i.e. byte pointer overloads) for UnicodeEscapeEncoding. This encoding depends on LiteralParser, which in its turn serves two masters, UnicodeEscapeEncoding (which used Ilist<byte>) and Tokenizer (which used IList<char>). In #671 we managed to cover both usecases by a generic method, which was not straightforward to get right so I wasn't sure how it would go here. I am happy to see that it actually went quite fine. Commit e0f7a580f0571ec289bcf5e0c2bdb304c2484f49 shows the result.
It was nice to see that the IConvertible.ToChar(null) on Span<byte> still works the same as for IList<byte>. In fact the whole expression data[i].ToChar(null) is somewhat simpler for Span than IList, probably because get_Item call site is simpler. Interesting observation: get_Item on Span is marginally faster (by one assembly instruction) than on ReadOnlySpan. I am guessing that this is because Span is being passed by value, while ReadOnlySpan by reference. In a loop like this it adds up and probably is more than the extra cost of passing by value. I tried to force the compiler to pass ReadOnlySpan by value, by not using the in parameter modifier, but it had no effect. The generated IL code still had the parameter tagged with InAttribute. Maybe because ReadOnlySpan as a whole is a readonly struct, so compiler "optimization" kicks in. In the end, not a big deal but it is strange to see that the compiler assumes it "knows better" and ignores what the programmer wrote.
In the next commit I go further along the feasibility of spans for decoding functions. Unfortunately, I have encountered some roadblocks there.

In this step I changed the signature of StringOps.DoDecode from accepting IList<byte> to ReadOnlySpan<byte> and looked for the ripple effects. I haven't changed signature of all decode functions in _codecs, to avoid failing tests or necessary but straightforward Binder updates. Instead of it, I convert IList<byte> to an array and create a span over it, to match changes in StringOps.DoDecode. This is a data copy, but will disappear after public function signature change. There are more places like that, so I will focus only on data copying that is problematic.
I will start with the major roadblock encountered in DoDecode. When the error handler is none of the builtin handler names, PythonDecoderFallback is used, which will possibly call any of the user-registered handlers. This fallback class requires a reference to the data being decoded, so I cannot pass Span. Hence a data copy to an array. The fact that a copy is being made by itself is acceptable — CPython will also wrap any input data into bytes before passing to an error handler — but the copy will happen always for any user-defined error handler, even when no errors are being generated. Even if this were acceptable, it would become a problem with my planned refactoring of error handling to always use StringOps.*Errors methods and abolish this switch-on-string we have now on every call. This would make all built-in error handlers be registered and called as any user-defined handler, which can be redefined/overriden. For instance, this works in Python:
import codecs

def my_error_handler(err):
    if isinstance(err, UnicodeDecodeError):
        return ("<error>", err.end)
    else:
        raise err

# redefine every built-in error handler
for eh in ["test", "strict", "replace", "ignore", "xmlcharrefreplace", "backslashreplace", "surrogateescape", "surrogatepass"]:
    codecs.register_error(eh, my_error_handler)
    assert b"a\xffc".decode('utf-8', eh) == "a<error>c"

assert codecs.utf_8_decode(b"a\xffc", None) == ("a<error>c", 3)

I see two possibilities here: for _codecs functions to use either IBufferProtocol or ReadOnlyMemory<byte>. Simple functions accepting bytes-like input may still use Span. The former option is basically my proposal from #762 ("Choice D with a mixin from B"). It also plays well with UserDecode discussed below. Conversion from IBufferProtocol to bytes (or Span or Memory) can be delayed to when the data is actually needed. I am pretty confident this will work, so I do not need to test it out in actual code now.
Using ReadOnlyMemory<byte> should also be sufficient, though I would continue my experiment to get a better feeling for it. As far I can see now, it will force every object to create a ReadOnlyMemory right from the beginning, possibly done by the Binder. Getting Memory may be more expensive than Span, though it probably does not matter that much. For all builtin types like Bytes, this will be the same.
OK, here is the second interesting issue. StringOps.RawDecode does not use Span, it uses IProtocolBuffer. I have found that user decode functions in CPython are being given objects of type memoryview. If the input object was already memoryview, it is being passed as is to user decode. In case of any other buffer-protocol-compliant object, a memoryview wrapper is passed. I am not completely recreating this behavior in UserDecode because IronPython's MemoryView does not implement IBufferProtocol, but I anticipate it will, so I used IBufferProtocol as the input data type. @slozier, I remember you mentioned that adding IBufferProtocol to MemoryView is "technically not correct". Can you elaborate? All I see is that memoryview is being accepted by CPython wherever a buffer-protocol-compliant object is required and dir on an instance of memoryview shows all familiar Py_Buffer members.
On a side note, I do not understand why there are two identical in purpose, but different in implementation functions: _codecs.decode and StringOps.RawDecode (the same for encode). Perhaps this could be straightened out. I will need to investigate it further. It is a separate issue except that if StringOps.RawDecode uses IBufferProtocol so should _codecs.decode. And if so, then perhaps all other decoding functions in _codecs?

I forgot to say: I looked into the performance of LiteralParser on .NET Core 3.0 only. I see that there are still issues with JIT that impact performance of indexed access. The newest version of Span has a workaround for it. Maybe it will drip down to the NuGet package at some point.

The CI test on Windows fails because of failing net45.IronPython.interop.net.dynamic.test_dynamic_regressions, which fails to load System.Memory.dll when executing os.system("%TEMP%/IronPython/cp20519_vb.exe"):
Unhandled Exception: System.Reflection.TargetInvocationException: Failed to load language 'IronPython 3.4.0': Could not load file or assembly 'System.Memory, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Memory, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.
   at IronPython.Modules.PythonIOModule.BufferedReader.__init__(CodeContext context, Object raw, Int32 buffer_size)
   at IronPython.Modules.PythonIOModule.BufferedReader.Create(CodeContext context, Object raw, Int32 buffer_size)
   at IronPython.Modules.PythonIOModule.CreateConsole(PythonContext context, SharedIO io, ConsoleStreamType type, String name, FileIO& fio)
   at IronPython.Runtime.PythonContext.SetStandardIO()
   at IronPython.Runtime.PythonContext.InitializeSystemState()
   at IronPython.Runtime.PythonContext..ctor(ScriptDomainManager manager, IDictionary`2 options)
   --- End of inner exception stack trace ---
   at Microsoft.Scripting.Runtime.LanguageConfiguration.LoadLanguageContext(ScriptDomainManager domainManager, Boolean& alreadyLoaded)
   at Microsoft.Scripting.Runtime.DlrConfiguration.LoadLanguageContext(ScriptDomainManager manager, LanguageConfiguration config)
   at Microsoft.Scripting.Runtime.DlrConfiguration.TryLoadLanguage(ScriptDomainManager manager, String str, Boolean isExtension, LanguageContext& language)
   at Microsoft.Scripting.Runtime.ScriptDomainManager.TryGetLanguage(String languageName, LanguageContext& language)
   at Microsoft.Scripting.Hosting.ScriptRuntime.TryGetEngine(String languageName, ScriptEngine& engine)
   at Microsoft.Scripting.Hosting.ScriptRuntime.GetEngine(String languageName)
   at CodePlex20519.Main()
-532462766

I remember you mentioned that adding IBufferProtocol to MemoryView is "technically not correct". Can you elaborate?

The issue isn't really that MemoryView shouldn't implement IBufferProtocol. It's that IBufferProtocol is all wrong. The protocol itself should consist of only two methods GetPythonBuffer and ReleasePythonBuffer. When you call GetPythonBuffer it should give you a PythonBuffer struct, which is equivalent to the Py_buffer object.
We could define an IPythonBuffer interface and leave it up to the IBufferProtocol objects to return something that implements the interface. We could also potentially drop the ReleasePythonBuffer if we select this option and make IPythonBuffer also implement IDisposable.
Anyway this would been prototyping. My goal is to be able to support the following:
ba = bytearray()
mv = memoryview(ba)
ba.append(0) # this should throw a BufferError since we're trying to resize the buffer

If you think implementing the current IBufferProtocol on MemoryView would be helpful in the short term then we can do that.

I understand your point. I like the idea of separating IPythonBuffer from IBufferProtocol, with IPythonBuffer representing Py_buffer. MemoryView could implement both interfaces. In the short term, the following would be helpful:

A common interface across Bytes, ByteArray, MemoryView, and array.array that allows access to Memory/ReadOnlyMemory and Span/ReadOnlySpan, directly or indirectly (e.g. through IPythonBuffer), ideally without copying data. It doesn't have to be IBufferProtocol but I think it suits the purpose. The actual design of this interface can be refined later. So let's assume MemoryView implements IBufferProtocol

If we go ahead with ReadOnlyMemory on _codecs decoding functions, a MemoryView constructor accepting ReadOnlyMemory, obviously without data copying.

If we go ahead with ReadOnlyMemory on _codecs decoding functions, a Bytes constructor accepting ReadOnlyMemory, ideally without data copying. Unfortunately, the current implementation exposes the backing array through UnsafeByteArray, which turns out to be quite popular (37 usages). So for now a copy will be necessary. Maybe over time we can wean the code off UnsafeByteArray and replace it with ReadOnlyMemory/ReadOnlySpan access.

Currently bytes(bytes(1)) will copy the underlying array, despite it being read-only. It would be nice if the array could be shared. This would be beneficial if we adopt IBufferProtocol on _codecs decoding functions. If we go ahead with ReadOnlyMemory, the previous point will take care of it — over time, that is.

ByteArray.cs, lines 1174:1176:
            // always copy from a List object, even if it's a copy of some user defined enumerator.  This
            // makes it easy to hold the lock for the duration fo the copy.
            IList<byte> other = GetBytes(value);

I can't figure out the purpose of this line.  The comments suggests that a copy is required, but a copy is already made in the caller, object? this[[NotNull]Slice slice]. Besides, value here is always IList<byte> hence GetBytes is simply returning the same reference as the argument received. As much in the latest version as well in the very first version checked into the ironpython3 git archive.
Shouldn't this line simply be removed? Or am I missing something?

Indeed, seems safe to remove. Probably just a copy/paste of the PythonList.SliceNoStep which had an object argument.

I consider this exercise as completed. Any other improvement discussed here can be further done on the mainline, after this PR is merged, assuming it is going to be merged.

Thanks!


Suggestion: Sprite Z Ordering Feature

It would be nice to easily have a sprite z ordering feature (with options) particularly with the tileEngine in addition to the position all sprites including player controlled sprite.
An example option would be basing it on y value for top down maps.

If I understand correctly, you'd like something like this?
spriteManager = new SpriteManager();

/* add all sprites to spriteManager */

// somewhere else in the code
sprite.z = 10;

loop = new GameLoop({
  render() {
    spriteManager.render(); // renders all sprites in z order (or y order)
  }
});

Yes, would it also be nice to automatically set the sprite z property?
example:
spriteManager.renderY()
..or renderX() if this is also used on some type of games.
so for top down styles like the tileEngine example it automatically sets all the sprites ordering depending on the sprites y location and perhaps you can set the others manually or exclude them on conditions like a gui sprite that is always rendered last.

I too would find this a useful addition, especially where the "z index" of a sprite can be set based on the sprite's y property but that also takes the anchor.y property into consideration.

I ended up doing something like this (seems to work):
render:() => {
  tileEngine.render()
  sprites
    .sort((a, b) => Math.round(a.y) - Math.round(b.y))
    .forEach(sprite => sprite.render());
}

I'm sure there's a more elgant solution out there but just in case it's any use for folk.


Consider Merging with Already Adopted Code of Conduct

See https://github.com/CoralineAda/contributor_covenant and the list of groups that have already adopted it. /cc @CoralineAda

I tried to answer this question here: https://github.com/todogroup/opencodeofconduct#can-i-use-something-simpler-what-about-the-contributor-covenant
We definitely call out other CoCs here and thank them appropriately: https://github.com/todogroup/opencodeofconduct#thanks


Possibility to limit Completed PR's history view

Current implementation seem to list pr's that goes about a bit over 1 year in history. Currently for our solution this is 276 PRs
It would be nice to have a filter for this view only that you can filter out entries older than X days (7,14,30, user defined)

in addition there seem to be a mix of how how far back you currently fetch the history in respective git repo (check dates)

@surfaace Please install the beta release I have created, https://marketplace.visualstudio.com/items?itemName=hannes-widrig.azure-devops-pull-request-center-beta. It would be easiest to message back and forth on a messaging platform like telegram.


extra firstline indent in lang-bash code style should be removed

For example, step 3 in https://angular.io/docs/js/latest/quickstart.html

fixed in my branch, coming soon


Consistent cmdline args for XML and HAN

Currently the arguments for XML and HAN have underscores in them which is inconsistent with the style followed in other models in this project.

Thanks @Ashutosh-Adhikari for fixing this. Closing the issue.


wont run on newer nukkit

getting this error
https://bytebin.lucko.me/BlyhSiVwcx
running 2:29:05 [INFO ] Starting Minecraft: BE server version v1.14.60

https://github.com/lucko/LuckPerms is the right repo


Unable to select Polygon ROI

Hi @saharshleo,
Tried your tool which is very good. I'm able to capture lines but not able to get polygons. Can you please help on this.
Thank you.

Figured it out. Thanks.


export 'layout05' (imported as 'layout05') was not found in '@carbon/layout'

WARNING in<EMAIL_ADDRESS>314:37-45
export 'layout05' (imported as 'layout05') was not found in '@carbon/layout' (possible exports: baseFontSize, breakpoint, breakpointDown, breakpointUp, breakpoints, container, container01, container02, container03, container04, container05, em, fluidSpacing, fluidSpacing01, fluidSpacing02, fluidSpacing03, fluidSpacing04, iconSize, iconSize01, iconSize02, miniUnit, miniUnits, px, rem, size2XLarge, sizeLarge, sizeMedium, sizeSmall, sizeXLarge, sizeXSmall, sizes, spacing, spacing01, spacing02, spacing03, spacing04, spacing05, spacing06, spacing07, spacing08, spacing09, spacing10, spacing11, spacing12, spacing13, unstable_tokens)
Why is layout05 missing from @carbon/layout or does the name need to be updated in @carbon/ibm-products?

This is most likely happening because you're using Carbon v11 with our component library. We do not yet support v11, but are currently working on providing a release candidate for people to try out. Feel free to follow along with the following issues to see our progress:
https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/2020
https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/2071
https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/1869


Fix taint removal

In manual tests and NHC CI the NoExecute taint isn't removed after remediation.
For debugging and fixing the issue this PR evolved over time and mainly contains these changes:

add e2e test for the taint (didn't reproduce the issue)
add taint after adding finalizer (didn't fix the issue)
wait for removal of Unschedulable Taint after setting Unschedulable to false: this fixed the issue! It was a race between node-lifecycle-controller and us with removing taints

more changes:

added logging
fix running unit test when they break (prevent metrics port conflicts)
use existing DeleteTaint func
add TimeAdded to taint

hm, here it looks good...
STEP: checking if NoExecute taint was removed
2022-06-17T13:51:35.356Z	INFO		{"taints": [{"key":"medik8s.io/remediation","value":"self-node-remediation","effect":"NoExecute"}]}
2022-06-17T13:51:45.422Z	INFO		{"taints": null}

I think that when restoring the Node Back Up we need to remove the taint from the backup

it's done here: https://github.com/medik8s/self-node-remediation/blob/224e9472ec40fddf35c18394e30b210b2f353dc3/controllers/selfnoderemediation_controller.go#L342-L344
Otherwise this test would fail: https://github.com/medik8s/self-node-remediation/blob/224e9472ec40fddf35c18394e30b210b2f353dc3/controllers/controller_test.go#L204

/lgtm


Cannot read property get of undefined

I'm trying to use this plugin like this:
const { Octokit } = require('@octokit/core');

module.exports = async (context) => {

  const { owner, repo } = context.repo();
  const octokit = new Octokit();
  const lookupTable = await octokit.config.get({
    owner,
    repo,
    path: 'lookup-table.yaml',
  });

}

But I always get the following error: ERROR event: Cannot read property 'get' of undefined (id=7600d710-dfc5-11eb-8be9-a0fed017660a)  TypeError: Cannot read property 'get' of undefined
Can you please help me getting my head wrapped around this? Sorry if this is trivial, but I'm quite a JavaScript noobie

I assume the async (context) => { ... } function is a Probot event handler function? Use context.octokit instead of importing @octokit/core and instantiating it. context.octokit is a pre-authenticated Octokit instance with all the plugins loaded, including octokit-plugin-config


Adding search for map

Hi
Is it possible to address search to the map?
Thanks!

Hi @keweik !  Is this what you had in mind?
https://docs.mapbox.com/mapbox-gl-js/example/mapbox-gl-geocoder/


Fix some issues in adopters list

Replace Node.JS and Javascript with JavaScript consistently
Add the missing referenceTitle to make the link to the ebay blog appear

/easyCLA

/easyCLA


my birthday added

i added my birthday 8/8/1994

Should follow repo format. Propose to cahnge to
1994-08-08


Calico CI

part of https://github.com/networkservicemesh/integration-k8s-kind/issues/325

@edwarnicke Finally Calico passes CI.
As I can see this PR adds a separate job that runs a few of our tests on packet setup with Calico CNI plugin.
For me, these CI changes look overcomplicated, but I think we can go with them for now.
Can we merge this and consider simplification a bit after?
Please share your thoughts.

My overall thoughts here are:

It might be much more productive to think of this in terms of testing across different CNIs, rather than a binary Calico/NotCalico binary
I'm a little confused why Calico has its own custom suite instead of simply using the standard test suites.  I'm also confused why healing/sriov/etc are disabled.


_AxesStack' object is not callable

TypeError: '_AxesStack' object is not callable
I am trying to just run https://github.com/SkBlaz/py3plex/blob/master/examples/example_multilayer_visualization.py this example and gives me the above error. Can anybody help me please

@kazim01011 we just released a new version (0.95) that has mpl + nx libraries pinned - this seemed to have been the issue (examples seem to work fine now)

Please re-open the issue if it persists in the new version


daos: add mfu_file_unlink and daos_unlink

The copy function might eventually call mfu_unlink on destination files if it detects an error after performing the copy.
https://github.com/hpc/mpifileutils/blob/a059f299c3b0d4f4409a0ce48360a1081645d1b4/src/common/mfu_flist_copy.c#L2125
To handle this, we'll want to add an mfu_file_unlink and daos_unlink.
This code is commented out now.  I forget why I left that commented, other than maybe I'm paranoid about deleting things.

Based on:
https://man7.org/linux/man-pages/man2/unlink.2.html
"If the name referred to a symbolic link, the link is removed."
Since dfs supports symbolic links, but not hard links, I think a simple dfs_remove would suffice to emulate unlink


Too many 9s in the port range...

Under "Requirements for using Transport Relays" the port range is listed as "50 000 – 59 9999" - too many 9s
Thanks...
Matt

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 10b198f4-9576-a14d-4359-1e8cc0319cda
Version Independent ID: ba7c3252-21d4-9be1-2a84-de2d51646f7b
Content: Plan for media bypass with Direct Routing
Content Source: Teams/direct-routing-plan-media-bypass.md
Service: msteams
Product: skype-for-business-itpro
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@scanum this is an easy typo to confirm, please remove an extra 9 and republish.
@CarolynRowe Do you concur?

Thanks for your feedback.  I've already fixed this and it will be published soon.  Closing this issue.


Adds PrintablePageAsOfRevision view that uses an iframe

I tried to test it in labels-experiment but it didn't work the way I expected: http://labels-experiment.wmflabs.org/ui/wikidatawiki/

Also the widening looks good on wikidata but I don't like this for other wikis. Can we make it configurable?

@Ladsgroup: Strangely, that screenshot seems to be using the old PageAsOfRevision view rather than the PrintablePageAsOfRevision.  I can tell by the color of some things.   However, I think you make a good point about the change to width.  Let me see how that might be addressed.

OK i brought the width back under control.  I also did a little bit of styling with the PrintablePageAsOfRevision view so that it will not cause weird scroll bars as often.


test: Automation tests for Cortex CLI

Problem
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Success Criteria
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.

Closing this, too broad


Replace the default Storybook logo with a branded logo

https://storybook.js.org/docs/react/configure/theming


adding method to calculate active case

Resolves https://github.com/lazd/coronadatascraper/issues/33

Excellent work, thank you!


added small troubleshooting section

Summary
Added small piece of documentation regarding ruby versions
Details
Added small troubleshooting section explaining how to use RVM to upgrade to a more recent version of Ruby
Motivation and Context
A couple of us on slack had a small issue when installing from github, regarding Ruby Versions, this was how I fixed it.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation

Checklist:

[ ] I've added tests for my code
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

Thanks for your contribution @SimonS - but bbc-a11y has no Ruby code now, so I'm closing this.


Support Let's Encrypt w/Ingress

This will put kube-lego into the cluster, and once we create an Ingress resource, kube-lego will automatically attempt to retrieve a certificate from Let's Encrypt.
Fixes #3
Needs a Namespace addition after #17 lands

This got all sorts of tangled up.


return statement copy elision error from clang

Trying to build with clang 4.0.0. Getting the following error when trying to build command_line_option.cc. Is this a known problem? Any suggestions for a workaround?
/home/apan/hetereomark/src/common/command_line_option/argument_value_factory.h:51:12: error: moving a
      local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
    return std::move(argument_value);
           ^
/home/apan/hetereomark/src/common/command_line_option/argument_value_factory.h:51:12: note: remove
      std::move call here
    return std::move(argument_value);

This problem is solved in most recent version of the Develop branch.


Teams Room Management topic should cover the Teams Admin Center portal experience

This page speaks about managing Microsoft Teams Rooms with logs of other tools, can this page be updated to include what is capable from Teams Admin Center under Devices and Teams Rooms?
If content for Teams Admin Center does exist and I missed it, please add a url to this page for that content.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ad37b23-8b85-a502-f176-d90586c0a1c1
Version Independent ID: dcc4aba8-e341-4f19-cd0a-4c99cd5ef3bf
Content: Management overview for Microsoft Teams Rooms - Microsoft Teams
Content Source: Teams/rooms/rooms-manage.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

@tomlaciano Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@tomlaciano thank you for reaching out and helping improve MS Docs. Please have a look at these two articles and let me know if you need further help - https://docs.microsoft.com/microsoftteams/manage-teams-skypeforbusiness-admin-center and https://docs.microsoft.com/MicrosoftTeams/using-admin-roles

Hi Lindspea,
Sorry but the content you offered is not relevant to my comment. Your content focuses on permissions where this article was describing how to use Azure to monitor equipment. At Ignite 2019, there was a session - MTG30 https://youtu.be/rL9fXZJSnog?t=2158 starting at 35:58 that shows the new Teams Admin Center capabilities to manage and monitor Teams Rooms which should make this Azure content a secondary alternative for customers.

@dstrome please could you assist?

@tomlaciano - thanks for you feedback. This new UI has not yet been released widely and so the current management experience for the majority of customers is reflected in the documentation. As soon as the new management experience is broadly released, the documentation will be updated.


Support Sublime Text plugins

I'd be really cool if you added some kind of adapter, so Sublime Text plugins could be used in VS Code as-is.

Support for atom packages would also be good

Closing as out of scope currently. Please let us know if you run into any limitations that prevent porting a sublime plugin to vscode

For settings please see, https://github.com/Microsoft/vscode-sublime-importer and for keybindings we have https://github.com/Microsoft/vscode-sublime-keybindings


format report output

User story
As a reader of the CLI reports I want to be able to easily consume the generated information.
Formatting is key here. Even if many IDEs support a markdown viewer or auto-format JSON files, it still helps to be able to read the reports in a plain editor.
The current output of the markdown format is not formatted.
Acceptance criteria

[ ] implement helper form text formatting by wrapping prettier

[ ] accept the content to format and a optional argument for the format

[ ] format all markdown formats accordingly
[ ] ensure formatting is given over snapshot tests

Implementation details
Prettier wrapper:
// packages/utils/src/lib/formatting.ts
import { format, Options } from 'prettier';

export function formatText(
  content: string,
  parser: Options['parser'] = 'typescript'
) {
  return format(content, {
    parser
  }).trim();
}

Markdown helper:
// packages/utils/src/lib/report/md/table.ts
import { formatText } from '../formatting';

export function tableHtml(data: (string | number)[][]): string {
  if (data.length === 0) {
    throw new Error("Data can't be empty");
  }

  const tableContent = data.map((arr, index) => {
    if (index === 0) {
      const headerRow = arr.map(s => `<th>${s}</th>`).join('');
      return `<tr>${headerRow}</tr>`;
    }
    const row = arr.map(s => `<td>${s}</td>`).join('');
    return `<tr>${row}</tr>`;
  });
  return formatText(`<table>${tableContent.join('')}</table>`;
}

We should check if prettier is installed and run it if available. That way we don't have to list an extra dependency.

I believe this one was closed by the new md-build library.
Cc @matejchalk

Indeed, after #755 was merged the tables have padding and alignment to make the source more readable. In general, the output should be prettified already, so there's no need to run Prettier afterwards.


Ability to automatically skip duplicates during harvest

I suggest combining the cli option to use a skip list by producing & then using one on-the-fly.

The harvester can not 'detect' duplicates in an scalable way as other tools (e.g. dwca-validator) can do it. The current errors thrown by PostgreSQL but INSERTS are run in batches meaning that the whole transaction is then dropped. In other words, you can not only keep a reference to what was inserted since it won't scale and you can't use the PostgreSQL error since you still want to use batch INSERTS. The only scalable and robust solution is that the cli could use the dwca-validator(internally with the proper parameters) to generate a json object and then use to json object as exclusion list.


MNT: unpin setuptools_scm

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Closes #11

@conda-forge-admin, please rerender


[FeatureRequest]Support tilde as alias for home directory in file paths

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): 2.2.0
Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
I was trying to use ~/dir/file style file-path to create Dataset using tf.data.Dataset.list_files, but it failed with NotFoundError: No such file or directory. With an expanded home directory path it works fine. Is it possible to add this feature to automatically resolve tilde as home directory.
Will this change the current api? How?
Not sure.
Who will benefit with this feature?
Maybe everyone (Or at least some lazy people like me)
Any Other info.

Typically Python APIs don't expand ~, e.g. open('~/file') will not expand the ~. ~ expansion is usually only done automatically by shells. To get the behavior of starting a path with ~, users should call os.path.expanduser("~") directly. It is possible for a filename to start with the character '~', so this change would technically break backwards compatibility. Closing for now, feel free to reopen if you think there are more good arguments for automatically expanding ~/

Typically Python APIs don't expand ~, e.g. open('~/file') will not expand the ~. ~ expansion is usually only done automatically by shells. To get the behavior of starting a path with ~, users should call os.path.expanduser("~") directly. It is possible for a filename to start with the character '~', so this change would technically break backwards compatibility. Closing for now, feel free to reopen if you think there are more good arguments for automatically expanding ~/

This is annoying , and causes issues
for instance, i am running  tensorflow_datasets.load('cats_vs_dogs'), and it downloads the data, not to my home directory, but to something like project_root/~/tensorflow_datasets/cats_vs_dogs, this is definitely not desirable.....

To expand on this: Tensorflow itself tries to expand the ~ sign when datasets are downloaded and no download_dir is given. In the documentation for the download_and_prepare method this is even stated, see https://www.tensorflow.org/datasets/api_docs/python/tfds/core/DatasetBuilder#download_and_prepare. Either the ~ needs to be expanded or the default download dir should be relative to the CWD. Otherwise this poses a possibly severe risk of deleting the home directory by mistake.


Error creating obsgridDG in LIS_DAobservationsMod.F90

LIS with ESMF 8 aborts at line 373 in subroutine create_obsdomain_objects in file LIS_DAobservationsMod.F90
[ERR] ESMF_DistGridCreate failed: obsgridDG Stopping.

The issue is deblklist is sized (2,2,LIS_npes).  However it is being assigned values like this:
367              deblklist(:,1,i+1) = (/stid/)
368              deblklist(:,2,i+1) = (/enid/)

This first dimension has a size of 2, but it is being assigned a single value.  Thus deblklist(2,:,:) contain uninitialized values.
Either deblklist should be sized (1,2,LIS_npes) or the assignment should be something like:deblklist(:,1,i+1) = (/x,y/).

@jvgeiger, I believe Dan introduced a fix for this in the NUOPC Cap pull request that I'm currently reviewing.
It is in this commit in particular: https://github.com/NASA-LIS/LISF/pull/618/commits/58c6dddda54d6162ff749525b912de1721db05b3

Thanks.  That does look like the correct fix.  The deblklist for obsgridDG looks like it should be (1,2,LIS_npes).  A few lines down, we have deblklist(2,2,LIS_npes) for gridEnsDG.  That block is consistent for a first dimension of size 2.

I am debugging a separate issue, and added "-check all" to FFLAGS and FFLAGS77 in configure.lis
I see multiple messages also showing this error:
forrtl: severe (408): fort: (33): Shape mismatch: The extent of dimension 1 of array DEBLKLIST is 2 and the corresponding extent of array  is 1
Image              PC                Routine            Line        Source
LIS<PHONE_NUMBER>41FDAF  Unknown               Unknown  Unknown
LIS<PHONE_NUMBER>E1F326  lis_daobservation         368  LIS_DAobservationsMod.F90
LIS<PHONE_NUMBER>E0C319  lis_daobservation         188  LIS_DAobservationsMod.F90
LIS<PHONE_NUMBER>4AEE82  retrospective_run          91  retrospective_runMod.F90
LIS<PHONE_NUMBER>580712  lisinit_                  126  LIS_runmode_FTable.c
LIS<PHONE_NUMBER>5BB344  MAIN__                     65  lisdrv.F90
LIS<PHONE_NUMBER>414352  Unknown               Unknown  Unknown
libc-2.22.so       00002AAAB45D7725  __libc_start_main     Unknown  Unknown
LIS<PHONE_NUMBER>414269  Unknown               Unknown  Unknown

Fixed in #618.


Track references uploads => file-hashes

When creating an upload, also create an entry that marks that each referred file-hash is known, with empty documents at stores / { storeId } / files / { fileName } / hashes / { hash } for each file-hash . This should be an empty document.
Similarly, also create entries at stores / { storeId } / files / { fileName } / hashes / { hash } / uploads / { uploadId } for each file-hash. These will allow for reverse lookups: which uploads - if any - refer a specific file-hash? Again, this should be an empty document.

Closed via #51.


useSortBy should togglearia-sort on column headers and relevant demos should encourage a11y best practices

Describe the bug (required)

useSortBy should leverage the aria-sort attribute which describes the current sort direction for a particular column to screen reader only users
The demo for useSortBy is not keyboard accessible - fortunately this can be overcome easily via manually leveraging column.toggleSortBy! Since this library is fairly popular, it would be good to encourage best practices where possible.

Provide an example via Codesandbox! (required)
Codesandbox Demo <-- here is a demo demonstrating the lack of aria-sort on the  elements with a keyboard accessible implementation using column.toggleSortBy
Steps To Reproduce (required)

Go to the linked demo in the documentation for useSortBy
Try to control the sorting using a keyboard only - unfortunately you can't due to some HTML semantics problems
When clicking on a  to sort, inspect the DOM for the aria-sort attribute - it isn't set at all.

Expected behavior (Recommended)
Here is a great demo of how this should work from a reliable source:
https://dequeuniversity.com/library/aria/table-sortable

All sortable  elements have a nested <button> inside to make them keyboard accessible
All sortable  elements have a valid aria-sort attribute (but only if they are sortable!)
Note they do not have the title attribute that is currently provided by useSortBy - this shouldn't be necessary with the aria-sort attribute in place.

Screenshots
N/A
Desktop (please complete the following information):

OS: macOS Big Sur
Browser: All browsers
Version: 7.6.3

Smartphone (please complete the following information):
N/A
Additional context
Seriously, thanks to all of the maintainers for your work. The headless approach this library takes serves the React community well.
Depending on the complexity of the code, I could potentially jump in and help out with this one. The aria-sort problem in particular seems like low-hanging fruit. Updating a CodeSandbox demo should be quite easy as well, though I'm not sure of the best way to go about doing that in this case.

In addition to that I have noticed that it sets title on header cell to "Toggle SortBy". I think name of the column should be preserved here like: 'Toggle SortBy, column: ${name}"

In addition to that I have noticed that it sets title on header cell to "Toggle SortBy". I think name of the column should be preserved here like: 'Toggle SortBy, column: ${name}"

Right - definitely not the right content. I think when paired with aria-sort, the regular heading content should do just fine for screen reader users.

@tannerlinsley I believe this should be reopened as it's still an issue with react-table v8. It makes it hard to target sortable headers in cypress tests in an accessible way.

It’s headless, so you should be able to put your own area attribute in your market depending on the table state

For anyone else that comes across this. I made it work using the following:
                <TableHeaderColumn
                  {...column.getHeaderProps(column.getSortByToggleProps())}
                  aria-sort={
                    column.isSorted
                      ? column.isSortedDesc
                        ? 'descending'
                        : 'ascending'
                      : 'none'
                  }
                >
                  <TableHeaderCell role="button">
                    {column.render('Header')}
                    {column.canSort && (
                      <SortIcon
                        size={IconSize.extraSmall}
                        direction={
                          column.isSorted
                            ? column.isSortedDesc
                              ? Direction.down
                              : Direction.up
                            : null
                        }
                      />
                    )}
                  </TableHeaderCell>
                </TableHeaderColumn>

Nice, @esetnik!
A couple of things to be sure to address too (your component might do this under the hood):

Make sure the rendered th does not have role="button" - that would wipe out the semantic meaning of the th and make aria-sort meaningless
The rendered markup should render like so at the end of the day:

  <button>Table header content here</button>

Check out this example for more:
https://dequeuniversity.com/library/aria/table-sortable

And @tannerlinsley in response to your comment here:

It’s headless, so you should be able to put your own area attribute in your market depending on the table state

It is headless though it does render relevant HTML attributes for some features of the table but not others. col-span and row-span, for example:
https://tanstack.com/table/v8/docs/api/core/header#colspan
I suppose it depends on what "headless" means exactly! For some headless libraries (React ARIA, Downshift, Radix) they are all about adding the right HTML attributes for handling state changes (including ARIA). Is this library only concerned with data? If it's concerned at all with producing the right HTML to reflect table state, then ARIA attributes should be part of the mix I would think.
(And thanks for all your hard work on this and so many other libraries 🙏  - big fan of your work)

Nice, @esetnik!
A couple of things to be sure to address too (your component might do this under the hood):

Make sure the rendered th does not have role="button" - that would wipe out the semantic meaning of the th and make aria-sort meaningless
The rendered markup should render like so at the end of the day:

  <button>Table header content here</button>

Check out this example for more: https://dequeuniversity.com/library/aria/table-sortable

Class Name

I suppose it depends on what "headless" means exactly! For some headless libraries (React ARIA, Downshift, Radix) they are all about adding the right HTML attributes for handling state changes (including ARIA). Is this library only concerned with data? If it's concerned at all with producing the right HTML to reflect table state, then ARIA attributes should be part of the mix I would think.

I agree. And most devs don't know too much about aria and often don't have the business justification to bother supporting it. In my opinion it should be baked in whenever possible. If adding too many properties by default was a concern there could be some configuration one could set to decide whether or not to generate aria attributes.

I’m happy to accept any PRs for better aria attrs!


[x] References to issues, e.g. close #X, are in the commit messages.
[ ] The buildserver is happy.
[x] The PR is rebased with current master.

Checklist

[ ] I added unit tests for my code
[ ] I fully described what my PR does in the documentation
(not in the PR description)
[ ] I fixed all affected documentation
[ ] I fixed all affected decisions
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax

Review

[ ] I've tested the code
[ ] I've read through the whole code
[ ] Documentation is conforming to our Documentation Guidelines
[ ] Examples are well chosen and understandable
[ ] Code is conforming to our Coding Guidelines
[ ] Code is consistent to our Design Decisions

@markus2330 loading data from the scraper works now :rocket:

jenkins build libelektra please

jenkins build please

I didn't change anything, but it seems to work:
Jenkins Job
postgres@pr:~$ psql cidb

cidb=# SELECT COUNT(*) FROM plants;
 count
-------
  9810
(1 row)

jenkins build please


Local.CollectionChanged gets raised twice for the same operation

Blog b = ctx.Blogs.First();
ctx.Blogs.Local.CollectionChanged += (sender, e) => { Console.WriteLine("changed"); };
ctx.Blogs.Local.Remove(b);

This outputs "changed" twice.

@Wain123 What version of EF Core are you using? This is fixed in the current dev branch, so unless you're seeing this on the currently nightly builds I'll close as fixed.

<IP_ADDRESS>
If it's fixed in 2.0, feel free to close. Sorry.


read_liberty segfault on LEF PINs for liberty pg_pins

OpenROAD v2.0-1750-gce49eb6f2

This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[INFO ODB-0222] Reading LEF file: ./tmp/merged_unpadded.lef
[INFO ODB-0223]     Created 13 technology layers
[INFO ODB-0224]     Created 25 technology vias
[INFO ODB-0225]     Created 441 library cells
[INFO ODB-0226] Finished LEF file:  ./tmp/merged_unpadded.lef
./run: line 14: 462423 Segmentation fault      (core dumped) $OPENROAD_BIN -exit $OR_SCRIPT_0

packaged.tar.gz

Also verified on OpenROAD v2.0-1764-g9d9403c75, which only builds with clang and not gcc for some reason.

lldb backtrace for your convenience:
Process 476509 stopped
* thread #1, name = 'openroad', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
    frame #0: 0x000055555586a705 openroad`void utl::Logger::log<char const*, char const*>(utl::ToolId, spdlog::level::level_enum, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, char const* const&, char const* const&) + 53
openroad`utl::Logger::log<char const*, char const*>:
->  0x55555586a705 <+53>: movswl 0x38(%rcx,%rax,2), %edx
    0x55555586a70a <+58>: leal   0x1(%rdx), %esi
    0x55555586a70d <+61>: movw   %si, 0x38(%rcx,%rax,2)
    0x55555586a712 <+66>: leaq   0x221fe8f(%rip), %rsi     ; utl::Logger::max_message_print
(lldb) bt
* thread #1, name = 'openroad', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
  * frame #0: 0x000055555586a705 openroad`void utl::Logger::log<char const*, char const*>(utl::ToolId, spdlog::level::level_enum, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, char const* const&, char const* const&) + 53
    frame #1: 0x000055555586e1b9 openroad`sta::dbNetwork::readLibertyAfter(sta::LibertyLibrary*) + 553
    frame #2: 0x00005555559461ee openroad`sta::Sta::readLibertyFile(char const*, sta::Corner*, sta::MinMaxAll const*, bool, sta::Network*) + 190
    frame #3: 0x00005555559460c3 openroad`sta::Sta::readLiberty(char const*, sta::Corner*, sta::MinMaxAll const*, bool) + 83
    frame #4: 0x000055555582b467 openroad`_wrap_read_liberty_cmd(void*, Tcl_Interp*, int, Tcl_Obj* const*) + 535
    frame #5: 0x00007ffff7e20c62 libtcl.so`TclNRRunCallbacks + 114
    frame #6: 0x00007ffff7e22b3a libtcl.so`TclEvalEx + 1386
    frame #7: 0x00007ffff7e23363 libtcl.so`Tcl_EvalEx + 19
    frame #8: 0x00007ffff7e23387 libtcl.so`Tcl_Eval + 23
    frame #9: 0x0000555555874eb8 openroad`sta::sourceTclFile(char const*, bool, bool, Tcl_Interp*) + 120
    frame #10: 0x00005555556a78de openroad`ord::tclAppInit(Tcl_Interp*) + 1214
    frame #11: 0x00007ffff7ee5135 libtcl.so`Tcl_MainEx + 453
    frame #12: 0x00005555556a7f54 openroad`main + 1268
    frame #13: 0x00007ffff6030b25 libc.so.6`__libc_start_main + 213
    frame #14: 0x00005555556976ce openroad`_start + 46

@donn :   Any ideas what's going on?  There should have been no changes to liberty files in the last open_pdks update, so nothing should have changed for STA. . . So I don't even know where to begin looking.

What is going on is there are errors in the LEF/liberty port names and the logger is not properly initialized. The problem does not show up with well formed libraries.

@jjcherry56 :  Can anybody tell me what those errors are?  The liberty files did not change, but I did make a change to the LEF files to fix the erroneous "soft" ports in the original SkyWater LEF macros for the standard cells.  Chances are that the modification introduced some syntax error into the LEF files.  But I don't know where to go looking for that, since OpenROAD crashed rather than generate an error message.

In my book, a segfault is something that needs immediate attention and a fix, even if it is the input data that's at fault.

FIne, next time I won't bother to tell you why it seg faulted, I'll just make you wait until it is fixed. I don't need a lesson on the severity of a seg fault.

fixed.
Note that the sta.tcl script will discard any DEF placement information if it is ever used with CURRENT_DEF because the unconditional  read_verilog following read_def will clobber the netlist in the database.

@donn :  With the segfault fixed, is there any additional information on what input caused the issue in the first place?  Does it remain a problem or not?