Live example broken?

On the live example, the create item button makes an item that cannot be edited.
Also, when deleting some items, the wrong list item is deleted.
I haven't installed and tested yet. Will update if I find the root cause

I looked for the example and did some corrections. By now everything seems to be ok for me.
Create and edit work fine.
Btw. the example shows the webcomponent with a minimal setup, so it's just an example ;) :
The used create and other operations can easily be seen here: https://ivosdc.github.io/svelte-generic-crud-table/crud-table-config-html.js
The idea of the crud-table is to dispatch events for the options "create", "delete", "edit" and "detail" so you can do further operations with the data. E.g. open a separate create/edit-page, implement your own sort-algorithm, do database or api operations...
I use it to implement in a fast way a DTOs from the backend. The corresponding api-calls can easily be added, especially in svelte  :)


fix: adjust collectible arrow hover transparancy, closes #4971

This PR adjusts the size of the collectible icon as per https://github.com/leather-io/extension/issues/4971#issuecomment-2200575470

Summary by CodeRabbit

New Features

Updated the CollectibleHover component to use a new IconButton with improved custom icon styling.

@pete-watters I'm still not understanding the overall fix here if the description of issue shows a square button with a different icon? Why are those changes not being implemented?

#4971 (comment)

Sorry thats my mistake, I was just reading the issue text and not seeing the different icon 🤦
I will change it to have the correct icon


Ctrl+X/C/V not working on Windows / Linux

Cut/copy/paste works from drop-down application menu, but not via keyboard shortcut, on Windows and Linux.
Works as expected on macOS.

Select all is also not working on win and linux

I did some investigated with this issue and after and the only good finding I found is that nothing is being dispatched to the store when using Ctrl + X/C/V

Can you test if the IPC call is being invoked at all? I tested and I think it isn't - so it's not a store problem, it's a "back end never even tells the front end" problem
Even worse, I think the menu is never even invoking the click() method on these items when the keyboard shortcuts are pressed

The 'Even worse' case... I just added log statements inside the copyText, cutText, pasteText, functions and they only get printed (executed) when you click the the menu options and never when you press the keyboard shortcuts.

I thought as much... can you try the following

remove the ctrl+X cut menu item, then change a shortcut that you know DOES work to be ctrl+X. Does that item still work?
remove a menu item you know works (e.g. undo), then change the cut shortcut to use that shortcut (e.g. ctrl+Z)

If either/both of these work then we can basically conclude it's a reserved shortcut or something. Haven't found any docs online though. I'm hoping it doesn't work then we'll likely have something to work with

Alright here is what I found:

I removed Ctrl + X and changed Ctrl + Z to Ctrl + X. And the undo action no longer worked.
I removed Ctrl + Z (undo) and made the accelerator for the cut action Ctrl + Z. And it worked.

I guess we can conclude that it is reserved for something. But its weird how you can use Ctrl + X on slack and discord...

We could attach event listeners when the user navigates to the editor view.
However, we should keep the menu items for the shortcuts that do not work since the user might peek at the edit menu and look at the accelerator.

I found a fix, it might come across as smart at first but it isnt very elegant in my opinion.
here is the code for it.
  let keys = {};

  window.addEventListener('keydown', (e) => {

    keys[e.key.lower()] = true;

    if (keys['a'] && keys['control']) {
      console.log('select all');
    } else if (keys['v'] && keys['control']) {
      console.log('paste');
    } else if (keys['c'] && keys['control']) {
      console.log('copy');
    } else if (keys['x'] && keys['control']) {
      console.log('cut');
    }
  });

  window.addEventListener('keyup', (e) => {
    keys[e.key.lower()] = false;
  });

  console.log(keys);

this code block could be placed in Project.tsx, or we could place it in a function and call call the function in Project.tsx..
The reason I say its not elegant is because we now have to check if the event listeners have been added or not (if the Project.tsx component gets rerendered then it will re-add the event listeners). This could be done in a couple ways.

Use the getEventListeners function and iterate over the results to see if we have already added the event listeners or not.
We could have a boolean stored in the global state to indicate whether we have already added the event listeners or not.

I think we don't need to even do this from within the react context, it can just be globally declared on the front end on load. I'll whip up a prototype tonight

Didn't get to this tonight, will do sometime this week

Select all also not working - heads up

Select all also not working - heads up

Yep known issue - see first comment in this thread


changed web to Web and upcoming to Upcoming

Related Issue

Description of Changes
web to Web & upcoming to Upcoming
Checklist:

[x ] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Original
Updated

Hi @Sharjeel-Afridi .... thanks for typo correction. Could you find and recheck more UX of grabtern or suggesting any improve in UX like as when you arive at book session page that UX of pop up needs to improve!

Hi @Sharjeel-Afridi .... thanks for typo correction. Could you find and recheck more UX of grabtern or suggesting any improve in UX like as when you arive at book session page that UX of pop up needs to improve!

I'll try, for sure.


First Bigtable gapic gen for php

Copied over from api-client-staging

PTAL

GAPIC code looks good, but there are some other changes that we will need in addition. Check out this PR, which adds the DLP API for the first time: https://github.com/GoogleCloudPlatform/google-cloud-php/pull/569
In particular, we will need:

Updates to settings files in docs folder
LICENSE file
README files
composer.json file
Version bump for proto-client library to a version that includes the newly merged Bigtable protobuf classes

@andreamlin, Did you run artman using PHP 5.5 by any chance? @vam-google discovered an issue where php-cs-fixer was failing silently during generation as it was requiring a version of PHP greater than 5.5.
https://github.com/googleapis/artman/pull/310 &
https://github.com/googleapis/artman/pull/316
should address that issue and will use a ruleset which fixes items like extra whitespace and unused imports.

@dwsupplee I'm running php v5.5.9. That should be fine, right?

Yeah, v5.5.9 should work!
Do you know which version of php-cs-fixer you are running? It should be v2.2.7 to ensure comparability with your version of PHP. The reason I ask is because it appears the task may have failed:
https://github.com/GoogleCloudPlatform/google-cloud-php/pull/731/files#diff-5235c551bb78376c8ebd0495ed33870aR55 (unused import, should be removed)
https://github.com/GoogleCloudPlatform/google-cloud-php/pull/731/files#diff-5235c551bb78376c8ebd0495ed33870aR222 (extra whitespace)

I was using the wrong version of php-cs-fixer :/
Regen'd using php-cs-fixer 2.7
PTAL

The autogen code LGTM now. Nice work!
We still will need the changes @michaelbausor mentioned earlier in the thread, as well as a VERSION file (it can just be versioned as master right now).

Added VERSION, license, readme, bigtable/composer.json, and docs files; updated top-level composer.json.
PTAL

LGTM, @dwsupplee and/or @jdpedrie can you also take a look?

@dwsupplee Added a README.md to the bigtable/v2 directory.


Whisker configuration cannot be saved

I think this was introduced in #142 where I started using phetcore.merge instead of _.merge since objects no longer fill in recursively.

A fix has been merged into main, I am able to edit whisker values again.


Bonfire Confirm the Ending

In one of the statements for the instructions, "end("He has to give me a new name", "me") should return true." I think this should return false. Please confirm if I am correct.

hey, no returning true is correct for that case. ('me' is substring of 'name')

Sorry, but Issues are not for code problems.  Please ask for help in Help Chat.
Thanks and Happy Coding!


🔨 Normalize CWD history entries (2nd approach)

Fixes #157932
:warning: Since I couldn't manually test Windows-related behaviors, I wouldn't call this PR ready to review. Nor it's a draft PR, for I wouldn't contribute to it anymore. So, may this be a little groundwork for anyone who wants to use it.
Changes made in this PR:

A new parameter, reverse:? boolean, was added to getWslPath to let it act in the reverse order. That is, to receive WSL paths which are in POSIX format (like /mnt/c/windows) and return their Windows-native equivalent (e.g., c:\windows).
A new method, getCygPath, was added to terminal backends to help with paths of Git-Bash in Windows. This acts just like the getWslPath, with the same signature.
CWD history entries now include two optional fields: shellType and platformNativePath, which are supposed to be present when the actual CWD path is different than its platform-native representation. For example, in WSL, the working directory could be /mnt/c/windows and so is different than c:\windows which is its platform-native representation. The same thing happens on Git-Bash too. So, in such cases, we store the shellType and platformNativePath in the CWD history storage to later use them to properly eliminate duplicate items from the Go To Recent Directory... picker. For non-Windows environments, we do not store these two extra fields and things are the same as before.

This is getting there but it's a little different from what I think we should be doing which is:

When the directories are added to the list, store them in as a URI (URI.toString()?) to ensure they're all consistent, this includes setting a remote authority when necessary.
When it comes time to use the directories, convert them to the shell type's format. This is mostly happening in the PR but we should make it a little more generic. For example creating a function like this:interface ITerminalBackend {
  formatUriForShellType(path: URI, shellType: TerminalShellType): Promise<string> | string;
}

This function would only go to the backend if it's actually needed, for example I know wsl path is needed due to some edge cases, but can cygpath be evaluated purely based on the drive letter?

Closing off as this still needs more work, but this is a good reference for future PR(s).


Invalid value for decimal column type when using prepared statement

I have a table with a decimal(11,4) column. If I query that table with a prepared statement, I get a value of 2.40588e-57. If I query the table with a regular query, I get the actual value.
Attached is a diff for the integration.d module that will add tests for this specific situation. Of the 4 sets of tests, the third will fail. That test can be made to work by moving the case SQLType.NEWDECIMAL: (packet_helpers.d:681) down to the string section, but doing the move will cause the other tests to fail.

Looks like the fix for #39 was incorrect after all. Finally found some documentation on NEWDECIMAL, courtesy of MariaDB:
https://mariadb.com/kb/en/mariadb/resultset-row/#decimal-binary-encoding
Apperently, MySQL/MariaDB treats NEWDECIMAL as a string. Since converting floatings from text representation to native binary decimal/double/real/etc is inherently lossy, I'm thinking the best thing to do is simply expose NEWDECIMAL as a string as well, and let the client code handle the conversion however it code sees fit.
I still need to look closer into out the the unittest cases you priovided...fingers crossed that hopefully won't reveal any unpleasant surprises...


Use context from ClientHello during GetCertificate

See discussion in #247
/cc @ankon -- I haven't tested this myself yet (been a very, very busy day with notifications rolling in all day!) but I feel like this makes the most sense. Could you try it when you have a chance?
Thanks for your patience!

So, we actually were running with this for a while, but reverted it yesterday due to the problems in #247/#248. Apart from that this worked quite like it should though, so I think this would be good to do indeed.
I'm right now not sure if #246 plays into this as well, gut feeling says "maybe, but probably not" as it is a synchronous case and the handshake context itself doesn't have a timeout (but a I/O deadline on the underlying network connection!).

Gotcha; ok I'll hold this open until we are confident with a fix for #246 and can try them together.

Could you find a safe way to try it out and let me know?

We're currently redoing our infra to run experiments like this in a safer way, so will try it out as soon as we that up and running :)

Awesome. In the future, as we work on testing infrastructure with the Caddy project, I'm hoping this kind of thing will get easier :)

I've been using this a little bit and so far it is working well. I want to get this fix, along with a patch I just merged into this branch, out for Caddy v2.7.4 today, so I'm going to merge this in and tag CertMagic v0.19.2.
When you do get around to trying this out, just try the latest release (or commits on master). Looking forward to your results! :100:


clean up search CSS

This PR does a few things:

converts SASS variables to CSS custom properties, to make them easier to access from the new CSS file
moves the CSS for search into its own file
renames a search classname to be more accurately descriptive

This PR has no visual or functional changes.

This looks great, merged, thanks @evykassirer!


Fix IntervalChunkingQueryRunner for groupBy v2.

Using MergeSequence instead of ConcatSequence is necessary for queries like groupBy
that potentially return more than one result per granular bucket. See also discussion
at issue #2262.
Also includes a couple other fixes:

handling for periods of irregular length, like "P1M" or "P1Y".
groupBy v1 was no longer being tested by GroupByQueryRunnerTest since #3953, now it
is once again.

Adding to 0.10.0 since with groupBy default changing to v2, this would be a regression
causing incorrect results for anyone using the chunkPeriod feature.

Added some docs and a new test describing behavior with subqueries + chunkPeriod.

👍

@gianm tests are failing

The interval chunking query decorator is called in the preMergeQueryDecoration methods. Now you're doing merges in the pre-merge. This seems like a violation of the expected query execution ordering.

The interval chunking decorator did merges before (it does toolChest.mergeResults) so at least I didn't make it worse! But this patch is no good for other reasons, which I am in the middle of writing up. chunkPeriod has an interesting history…

@himanshug @drcrallen @fjy after looking into this more I have learned some facts about chunkPeriod.

In the olden days (initial OSS Druid), chunkPeriod was implemented as Sequences.concat(lazyIterableOfChunkSequences) and so queries were executed sequentially. The sequences for later chunks weren't created until earlier chunks had finished, and this had the effect of reducing load on the historicals (since they'd only see part of each query at once).
But, TWIST: Druid 0.6.71 included commit 1d1ec1d8556be02878b68f4daad1b6b0aaa886d0, which effectively disabled chunkPeriod since it bypasses chunking if period.getMillis() == 0, which is true for any period that doesn't have a millisecond component. To get a nonzero millis component you'd have to use a period like "PT60.001S" which I doubt anyone was doing.
Later on, Druid 0.7.1 included #1150, where chunkPeriod was re-implemented as Sequences.concat(Lists.newArrayList(lazyIterableOfChunkSequences)). Doing Lists.newArrayList creates the sequences eagerly, which sends queries to the cluster in parallel. Additionally, the sequences are created in a thread pool, and the the chunks are all wrapped in toolChest.mergeResults(...) before sequences are created, which for groupBy v1 means each chunk is merged in its own thread in parallel. This patch also fixed the period.getMillis() == 0 check, so chunking started doing something again.
So in particular, #1150 changed chunkPeriod from something that was meant to decrease resource impact on historical nodes (by breaking up long queries and running them sequentially), into something that is meant to break up long queries and run them in parallel, which would either leave resource impact unchanged or increase it, especially on the broker.
The docs still say that chunkPeriod breaks queries into "shorter interval queries, reducing the impact on resources". I think the docs are wrong now in that regard.
The old behavior was useful at reducing resource impact for any query type, but the current behavior is only useful for parallelizing queries where toolChest.mergeResults(...).run(...) does merging eagerly, which is only groupBy v1. Other types like timeseries, topN, groupBy v2, all do merging lazily, so parallelizing the call to toolChest.mergeResults(...).run(...) isn't useful.

My question for you all: is this analysis correct and if so what should we do about it? Druid 0.6.71 and 0.7.1 are pretty old, so we've had the current behavior for quite a long time, and it seems to have gone un-noticed by anyone that might have been using chunkPeriod for its old purpose.
My vote for 0.10.0 would be to update the docs to reflect reality (chunkPeriod makes queries more resource intensive, not less, by parallelizing merging on the broker, and is only useful for groupBy v1). I'd also suggest including code to ignore chunkPeriod for groupBy v2 queries since it makes the results wrong, and even if that were fixed, it wouldn't really do anything useful anyway.

👍 on updating docs for 0.10.0 to reflect reality

@himanshug @drcrallen @fjy Updated PR description and top comment with a new "fix", disabling chunkPeriod for groupBy v2. It wouldn't help much anyway (seehttps://github.com/druid-io/druid/pull/4004#issuecomment-284171911)  and doesn't mesh well with how groupBy v2 merges results.

👍

@gianm thanks for looking it up.
I believe we should also remove it from [Search|Select|TopN|Timeseries]QueryToolChest.preMergeDecoration(..) . I have not seen it being used and helpful anywhere except GroupBy-v1 queries. (we can fix it too but I don't see that worth it)
so effectively, chunkPeriod in its current form would retire with GroupBy-v1.

@himanshug it seems to work fine for other query types, it's not accomplishing much but it seems harmless. I want to include this patch in 0.10.0 (since chunkPeriod + groupBy v2 gives wrong results now) so would prefer to keep the changes minimal.
I am down to disable it for other query types in 0.10.1 though.

@gianm Hi, we are using thetasketch with (1M size) . Interesting to find query time group linearly with intervals using timeseries. I think chunkPeriod may help. And also I guess chunkPeriod child query cache make senses .
we have tried 0.17 forkjoin broker merge, still not good enough.
Ideally, P1d ->10s, P10d ->15s. But reality is P1d ->10s, P10d ->100s.
But we encounter #4826, Would you like to give some suggestion?


chore: Update cargo-deny config

Updates it to support current project status.

I believe the deny check isn't running in CI, we should probably fix that if we want to keep this up to date.

Fixed it. However I noticed that tonic depends on MPL-2.0 because of webpki-roots. It is a copyleft license. Should us allow to use it in the deny config?

Yeah, we can allow it.

The copyleft licenses seem to be warned for default. I added copyleft = "deny" config to make the cargo-deny job fail due to MPL-2.0 in https://github.com/hyperium/tonic/pull/1169/commits/8e7a949907f7d0c3b9df049b7c31db2bee510d2f (the failed ci), and allowed it explicitly in https://github.com/hyperium/tonic/pull/1169/commits/ea3a7141dc1d2f5b7cc5ed80cabd6a57d3044a9a.

Thank you!


Base weapon(Under details) when creating weapons, inputs the wrong Base Damage

Whenever you create any weapon in pf2e, and choose a base weapon for example, Maul, Greatsword, etc, it will always default to a 1d6 Slashing damage, regardless of the base weapon. if this wasn't meant to auto-fill I'd imagine it'd leave it empty for manual-filling, however, since it auto-fills it to a 1d6 slashing, I assume it is simply a bug. 🪲
Note: In the books and nethys, their die is a 1d12 bludgeoning or slashing

1d6 is simply the initial value for that field in weapon data. You can change it to whatever you'd like.

I have to ask, why have a field for base weapon then? isn't a weapon group sufficient? When putting a base weapon I figured its expected to have it fit those stats?
Please lmk if i miss understand.

Base weapon is there to set the base weapon, which gets used in a lot of automation. We are definitely never going to hard code the damage of a greatsword beyond just having it in the item. That would make the process of making new equipment longer for not much benefit.


[#716] improvement(operator): support specifying imagePullSecrets

What changes were proposed in this pull request?
Support specifying imagePullSecrets
Why are the changes needed?
If the images are stored in a private registry, Kubernetes needs to be provided with the necessary credentials to authenticate with the registry.
Fix: #716
Does this PR introduce any user-facing change?
Example:
apiVersion: uniffle.apache.org/v1alpha1
kind: RemoteShuffleService
metadata:
  name: rss-demo
  namespace: rss
spec:
  # ConfigMapName indicates configMap name stores configurations of coordinators and shuffle servers.
  configMapName: rss-configuration
  imagePullSecrets:
    - name: "default-secret"

How was this patch tested?
UT

Codecov Report

Merging #765 (7830086) into master (47cac39) will increase coverage by 2.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #765      +/-   ##
============================================
+ Coverage     60.72%   62.86%   +2.14%
  Complexity     1905     1905
============================================
  Files           239      225      -14
  Lines         13038    11074    -1964
  Branches       1093     1093
============================================
- Hits           7917     6962     -955
+ Misses         4681     3732     -949
+ Partials        440      380      -60

see 14 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Is it possible to Swipe Action Context Menu View move both ways?

Hello Andrei.
Great job, I really like this lib.
The function is the same as SwipeActionContextMenuView, but with the ability to swipe both sides and each side performing a different function, just like the ios email application.
Thanks

for now not, but we can consider it


[Wallet] Available balance - Desktop

As a user, I want to connect my wallet through Keplr, so that I can see the available balance.
Acceptance criteria
Scenario 1 : Wallet balance
Given that I am an end user,
And I have connected my wallet through Keplr
When I click on wallet button on my desktop
And the menu opens
Then I should be able to read the exact number of Know that I have in my wallet

The balance of the wallet is updated at a frequency of approximately every 30 seconds on the frontend.
At a screen refresh, the balance is updates
The on-chain price is always the most updated one, regardless of what is shown on the screen.
When starting a transaction, the transaction window must have accurate balance information

As a technical implementation, we need to focus on 2 parts:

the logic domain called Bank that must ensure the RPC calls to the blockchain to get back the account balance
the UI dropdown in the toolbar that must be wired to a getBalance command and then display the received data

@ChaimaaZaoui
For now, I'l suggest to only refresh the balance when the connect menu (dropdown) is opened because our app is a bit different from Osmosis one: they directly display the balance in the page while we display the balance at the drop-down opening.
If you agree, we have no need to refresh the balance in another ways.

Hey team! Please add your planning poker estimate with Zenhub @0xLodz @AnjaMis @ErikssonJoakim @fredericvilcot


Automated cherry pick of #8282

Cherry pick of #8282 on cloud.
/cc  @Willyfrog

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

/release-note-none

@Willyfrog Build is failing.

@Willyfrog Build is failing.

I just noticed, can I cherry pick https://github.com/mattermost/mattermost-webapp/pull/8298 to fix it?

@Willyfrog Build is failing.

I just noticed, can I cherry pick #8298 to fix it?

Yes, you can.

/update-branch


Infinite loading animation after connect to SQL server

Issue Type: Bug
Infinite loading animation after SQL server is connected (green badge next to server name).
No databases are shown.

For this to work, I need to exit Azure Data Studio (CMD+Q) and reopen (several times).

Azure Data Studio version: azuredatastudio 1.37.0 (d904740d93d7df76a0ba361f20e4351813b57645, 2022-06-14T19:53:12.357Z)
OS version: Darwin x64 21.5.0
Restricted Mode: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 2

Memory (System)
16.00GB (0.05GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

schema-compare
Mic
1.14.0

vscodeintellicode
Vis
1.2.1

This issue is fixed by #21954 and #21811


Remove vestiges of delayed_job from asset-manager

We've switched to using Sidekiq instead of DelayedJob in Asset Manager
(see https://github.com/alphagov/asset-manager/pull/232).
The presence of govuk::delayed_job::worker meant that the
asset-manager machines were trying to start and monitor the jobs:work
Rake task that is no longer available in the code.

This is dependent on us first removing https://github.com/alphagov/govuk-app-deployment/blob/master/asset-manager/config/deploy.rb#L19-L22.

@chrislo has updated govuk-app-deployment in https://github.com/alphagov/govuk-app-deployment/pull/193.


RuntimeError: Exporting/importing meta graphs is not supported when eager execution is enabled. No graph exists when eager execution is enabled.

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
2022-02-11 11:05:30.792376: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
Traceback (most recent call last):
File "01_GenQuadProposals.py", line 82, in
CNNModel.restoreCNNSess()
File "/home/dms/SupplementaryMaterials/CodeAndData/Code/QuadProposals/CNNQuadDetector.py", line 92, in restoreCNNSess
saver = tf.train.import_meta_graph(self.cfg.cornerdet_sess + '.meta', import_scope="cornerdet")
File "/home/dms/anaconda3/envs/SupplementaryMaterials/lib/python3.8/site-packages/tensorflow/python/training/saver.py", line 1460, in import_meta_graph
return _import_meta_graph_with_return_elements(meta_graph_or_file,
File "/home/dms/anaconda3/envs/SupplementaryMaterials/lib/python3.8/site-packages/tensorflow/python/training/saver.py", line 1472, in _import_meta_graph_with_return_elements
raise RuntimeError("Exporting/importing meta graphs is not supported when "
RuntimeError: Exporting/importing meta graphs is not supported when eager execution is enabled. No graph exists when eager execution is enabled.
System information

TensorFlow version (you are using):
tensorboard                  2.8.0
tensorboard-data-server      0.6.1
tensorboard-plugin-wit       1.8.1
tensorflow                   2.3.1
tensorflow-estimator         2.3.0
tensorflow-hub               0.12.0
tensorflow-io-gcs-filesystem 0.24.0
tensorflowjs                 3.13.0
cuda                           10.1
cudnn                          7.6
python                         3.8
Are you willing to contribute it (Yes/No):
Yes

Describe the feature and the current behavior/state.
Will this change the current api? How?
Who will benefit with this feature?
Any Other info.

use tf.compat.v1.disable_v2_behavior() to stop all tensorflow2 behaviours  solve this problems.


Fix warning when compiling with atlas feature

This fixes an unused import warning when compiling with the atlas feature.
warning: unused import: `IntoSystemAppConfig`
  --> src/lib.rs:19:5
   |
19 |     IntoSystemAppConfig, IntoSystemConfig, Plugin, Query, Reflect, ReflectComponent, Transform,
   |     ^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Thank you for testing and fixing that.


Improve permission path handling

This replaces
initialise({
  permissions: {
    fs: {
      privatePaths: [ "Music" ],
      publicPaths: [ "Mixtapes" ]
    }
  }
}

with
initialise({
  permissions: {
    fs: {
      private: { directories: [ "Music" ], files: [] },
      public: { directories: [ "Mixtapes" ], files: [] }
    }
  }
}

Then it passes the paths to the lobby in the following way:

Directory: foo/bar/
File: foo/bar

Also cleans up the way functions, that use permissions, deal with paths.
Why is this necessary?
The SDK and lobby currently assume every filesystem permission is a directory, but we need to support files too.

Why break out files vs directories specifically? Is there an advantage over paths?

Also some light ambiguity on the wording:
directories: [ "Music" ], files: []
Can I get multiple directories, or is this a single path down the DAG? I'm guessing that it's a single line of directories, and possibly many files at the ends? Or can you have multiple directories and multiple files?

One suggestion for how to get rid of that ambiguity would be to tag it with a type field
  //////////////////
 // SINGLE FILES //
//////////////////
private: {
  type: FILE,
  segments: ["foo", "bar"]
}

// or

private: {
  type: FILE,
  path: "foo/bar"
}

// or

private: {
  filePath: ["foo", "bar"]
}

  ////////////////
 // MANY FILES //
////////////////

private: [
  { file: ["foo", "bar"] },
  { directory: ["baz", "quux"] },
  { file: ["vacation.png"] }
]

// and other variants above

Why break out files vs directories specifically? Is there an advantage over paths or segments? Should we define all paths in this format for consistency, and make it a TS interface?

Because we want to support permissions for files too.

Having to depend on a / at the end of a path is confusing, and a lot of people will forget to do just that.
I would like to have a better interface for all the paths in webnative, but not sure yet what that would exactly look like.

Can I get multiple directories, or is this a single path of segments down the DAG? I'm guessing that it's a single line of directories, and possibly many files at the ends? Or can you have multiple directories and multiple files?

Multiple directories and files.
directories: [ "Music/Playlists", "Documents" ], files: [ "Documents/Invoice.pdf" ]

Because we want to support permissions for files too.

Having to depend on a / at the end of a path is confusing, and a lot of people will forget to do just that.

Yes understood. Refresh the browser — I updated my comment to clarify that we may want to use tags on paths or segments.

Multiple directories and files.
directories: [ "Music/Playlists", "Documents" ], files: [ "Documents/Invoice.pdf" ]

Ah, I see. So still using string paths. Yup that totally works! If we have examples or docs, ones with /s in them would help clarify.
It would also be nice to have a universal way of disambiguating between directories and files, but I honestly don't know if that's common enough of a use case to need to explicitly separate file or directory elsewhere.

I do like these interfaces 👌
{
  type: FILE,
  pathSegments: ["foo", "bar"]
}

Would be my preferred option.
Do you think we should tackle that now, or later with the big SDK overhaul?

It may also be nice to have a universal way of disambiguating between directories and files, but I honestly don't know if that's common enough of a use case to need to explicitly separate files vs directories elsewhere 🤷♀

I don't think so? Need to think about it more. But I'd assume not, because the various filesystem operations already assume one type or another. For example, ls assumes directories, read assumes files.

Do you think we should tackle that now, or later with the big SDK overhaul?

How much effort would it be today? Minutes vs hours vs days?

Also possibly worth noting that UCANs follow the format {TAG: {...permissions}}, rather than {type: _, permissions: _}. They're strictly equivalent, so it really doesn't bother me one way or another, but thought I'd mention it!

Also possibly worth noting that UCANs follow the format

I like {TAG: {...permissions}} as well 👍
I don't think this is something we should tackle now, would be a couple of days of work.
Rather do this properly from the get-go in the overhaul.

Rather do this properly from the get-go in the overhaul.

Okay sounds good.
Should we hold off on this PR as well in that case, since these are also file paths that we may want to have also be consistent? I'm honestly happy either way 👍

Don't think we should hold off with this, since the type of paths used is the same (ie. just strings as opposed to an interface). Would like to get this in so the lobby can provide permissions for files, which is something Daniel will probably need for his keychain work.


Reuse git commit template file

This plugin is very useful.
It would be great ,if this plugin offer an option to specify a template file, so people can use the commit.template file both in command and IDE.

Great idea.
Working on it.

Closed with the latest commit.


Don't sync from block height 0

#2679 likely introduced a regression that a freshly started federation will try to sync from block 0 by defaulting the consensus block height to 0 while not enough votes are available.
We should only sync from the first consensus block height or a few blocks earlier.

Looks like it's addressed here in https://github.com/fedimint/fedimint/pull/2739


Ad?

Hi.
I use your library and saw full ad banner. So, used in the library advertising?

There is absolutely no ad in the library. Your ad should come from something else.


[Bug]: Issues using with SentenceTransformer

What happened?
I know ChromaDB will use SentenceTransformer by default, if no other embedding function is given. However I want to make things more explicit by using ST directly.
I've tried:
class TextEncoder(EmbeddingFunction):
    def __call__(self, texts: Documents) -> Embeddings:
        text_encoder = SentenceTransformer(
            'sentence-transformers/all-MiniLM-L6-v2'
        )

        return text_encoder.encode(
            texts,
            show_progress_bar=True,
        )

embedding_collection = chroma_client.get_or_create_collection(
    name='CaP',
    embedding_function=TextEncoder()
)

# documents come from LangChain, `pages` are `list[Document]`, and `page_content` is a string.
embedding_collection.add(
    documents=[page.page_content for page in pages],
    ids=[f'page{p + 1}' for p in range(len(pages))]
)

Using this I get the error:
File "/<path>/.venv/lib/python3.11/site-packages/chromadb/api/segment.py", line 600, in _records
    embedding=embeddings[i] if embeddings else None,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

Versions
chromadb==0.4.10
Python==3.11.5
Arch Linux
Relevant log output
No response

@felipefcm, the issue is that sentence transformers return np ndarray, we have a PR in the works to address that but in the meantime you can update your TextEncoder as so:
class TextEncoder(EmbeddingFunction):
    def __call__(self, texts: Documents) -> Embeddings:
        text_encoder = SentenceTransformer(
            'sentence-transformers/all-MiniLM-L6-v2'
        )

        return text_encoder.encode(
            texts,
            show_progress_bar=True,
        ).tolist()


site down?

https://r.j3ss.co/

It's just the static page acting up the registry itself is up, also I have
no SLA
On Wed, Jan 11, 2017, 01:54 xros<EMAIL_ADDRESS>wrote:

https://r.j3ss.co/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jessfraz/dockerfiles/issues/223, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbIeQEx0hZ-rq2lzrThEzjC2Bsa2sks5rRKbDgaJpZM4LgYjf
.


✨ Exposed image_sizes through Content API /settings endpoint

refs #11011
@allouis @kevinansfield this is an extraction from https://github.com/TryGhost/Ghost/pull/11007 which introduces the following:

[x] Exposes only "core" image size types through Content API in v2 and canary
[x] Makes sure the settings cannot be edited through Admin API

In the public issue, it would tick off the first point:

Expose core image sizes through Content API

There is no need for migrations as data in settings is pupulated automatically when not present.
The "management" bit will come in once we agree upon approach :+1:

Will have to come back to this and possibly reopen once the task is re-prioritized.


Multiple defined symbol crashes language server

A couple of questions first

Your IDE/editor (e.g. vscode, emacs,...) you use with verible LSP ? VSCode
IDE version: 1.74.3
What other SystemVerilog plugins are active alongside ? No

What activity failed
go-to-definition fails when there are two files in the file list that define the same symbol.
Expectation
At least the jump to one definition without crashing.
Ideal scenario: show that there are multiple definitions and allow user to choose where to go.
What actually happened
I0130 11:22:03.951129 2859273 symbol-table-handler.cc:78] Parsing project files...
 Server will restart.
[Error - 11:22:04 AM] Request textDocument/definition failed.

Test case
Two files, that both define a symbol bar
bar.sv
module bar();
  // one bar
endmodule

another-bar.sv
module bar();
  // another bar
endmodule

... then a file that uses the symbol
foo.sv
module foo();
  bar x;
endmodule

File list created with
echo *.sv > verible.filelist

Bug is triggered when opening foo.sv, then placing cursor on bar and request Go To Definition.

I will take a look at this.


Disable owner caching when guild subs are off

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
The owner cache will be outdated when guild subscriptions are disabled thus we need to disable it as well.

Is there a way to explicitly fetch the current owner?

@DV8FromTheWorld yes there is:
long ownerId = guild.getOwnerIdLong();
guild.retrieveMemberById(ownerId).queue(...);

I added a convenience method and linked to it from getOwner():
guild.retrieveOwner().queue(
    (member) -> System.out.printf("The owner is %#s\n", member.getUser())
);

Good job Github.. Double commits.


Modify global search project and adjust selected label position

Modify global search project issue  #4845
Adjust selected label position when add labels in tag page #4860
Modify label piece and color panel borders color #4833

Coverage increased (+0.04%) to 64.538% when pulling 5006693fd61b92800dfa1bf6f8619fb994b83975 on pengpengshui:fixIssues into e6a52f49a4020ee3a1a2e7907b0d0c0e2a2fb4a4 on vmware:master.


dnfjson: allow (optional) field solver in the dnfjson output

With the new "dnf5" solver is seems useful to allow the dnfjson code return what solver was actually used in the transaction.
This commit allows an (optional) "solver" field in the json that is returned from the dnfjson helper. It does not do more yet but we should (probably) make it avaialble for the higher layers too so that it can be e.g. logged.
See also https://github.com/osbuild/osbuild/pull/1776

Looks good, other than the linting complaints :)

Made #729 to ignore the pylint error


jest-worker's test do not pass when run in worker-farm

Do you want to request a feature or report a bug?
Either code bug or infrastructure bug
What is the current behavior?
packages/jest-worker/src/__tests__/child.test.js does not pass when doing a full test run locally. It passes on CI as that's run using --runInBand. It also passes locally if you just run that test.
If the current behavior is a bug, please provide the steps to reproduce and either a repl.it demo through https://repl.it/languages/jest or a minimal repository on GitHub that we can yarn install and yarn test.
On current jest master (7db15f028eb8c44b2ff90648e0673016bef5c36d)
$ ./jest worker --no-cache
 PASS  packages/jest-worker/src/__tests__/worker.test.js
 FAIL  packages/jest-worker/src/__tests__/child.test.js
  ● lazily requires the file

    TypeError: Cannot read property 'concat' of undefined

      at handle (node_modules/worker-farm/lib/child/index.js:44:24)

 PASS  packages/jest-worker/src/__tests__/index.test.js
 PASS  packages/jest-haste-map/src/__tests__/worker.test.js
 PASS  packages/jest-config/src/__tests__/get_max_workers.test.js
 PASS  packages/jest-cli/src/reporters/__tests__/coverage_worker.test.js

Test Suites: 1 failed, 5 passed, 6 total
Tests:       1 failed, 41 passed, 42 total
Snapshots:   0 total
Time:        4.12s
Ran all test suites matching /worker/i.

This is also reported in #4630
/cc @mjesun as you wrote the test.
What is the expected behavior?
Test should pass
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
jest@7db15f0, <EMAIL_ADDRESS><EMAIL_ADDRESS>macOS High Sierra

A fix might be to drop worker-farm completely for jest-worker?

Yeah, this bug is really weird. It looks that the child processes executing the tests get messed up with something; probably process.send. I'm fine deleting the test until we find out what it is; I will get some time to work on that next week.

Fixed in #5027.


Unable to continue for multiple days in a row - directory not empty

Using latest docker version after successfully redeeming a game and it goes back to its cron scheudule it seems to fail on the next day.
[2024-12-23 12:00:42.200 -0500] WARN: Unable to delete folder
    file: "puppeteer_dev_profile-CNOhCP"
    err: {
      "type": "Error",
      "message": "ENOTEMPTY: directory not empty, rmdir '/tmp/puppeteer_dev_profile-CNOhCP'",
      "stack":
          Error: ENOTEMPTY: directory not empty, rmdir '/tmp/puppeteer_dev_profile-CNOhCP'
      "errno": -39,
      "code": "ENOTEMPTY",
      "syscall": "rmdir",
      "path": "/tmp/puppeteer_dev_profile-CNOhCP"

Is there any other error? This is just a warning that part of the cleanup step failed. It's okay if that happens.

Ah man, I'll have to check tomorrow I guess, sorry. I just flushed everything.
I for sure missed the 19th and 20th's free games. I didn't remember seeing any but I'll have to end up checking again another day for it. sorry!
There must be something else though since it hasn't been running right.
will keep you posted tomorrow.

Well today it worked - I restarted container as I have run-on-startup as true, and it e-mailed me to check out/solve the captcha just fine today. Will let it ride tomorrow and see what happens.

Ok i'm not sure what's going on it's worked 3 days in a row now but there was for sure a few days where it got missed. odd. :)

Still no issues now. Idk what was going on. Sorry.
This is ok to close.


Notification parsing for Canadian dollars

Description
First of all, the notification listener works perfectly with the RBC Mobile banking app, it extracts the necessary information and populates the input fields in the add transaction view. However it selects USD by default (I reckon it's because of the $ character). It wouldn't be a big deal, I can change the currency by hand, however doing so resets the amount field, forcing me to reenter it by hand.
Proposal
I see a few easy solutions to this:

allow setting the default currency when configuring an app for listening
remove the input reset when the currency is changed

Screen recording
https://github.com/dreautall/waterfly-iii/assets/111386682/72d41cfe-ff26-4ea3-8847-4a031c27194e
Additionally, could you also add an optional field for the listening configuration where one could select the default expense account, not just the asset account?

I'll make the configuration change in Firefly, thank you!


Misreported Mint Supply

adam@Adams-MacBook-Pro ~ > http http://<IP_ADDRESS>:4000/v2/assets/MINTS/
HTTP/1.1 200 OK
Access-Control-Allow-Headers: *
Access-Control-Allow-Methods: *
Access-Control-Allow-Origin: *
Content-Length: 356
Content-Type: application/json
Date: Sat, 19 Oct 2024 12:19:34 GMT
Server: waitress
X-Bitcoin-Height: 866348
X-Counterparty-Height: 866348
X-Counterparty-Ready: True
X-Counterparty-Version: 10.5.0-alpha.2

{
    "result": {
        "asset": "MINTS",
        "asset_id": "5633620",
        "asset_longname": "",
        "confirmed": true,
        "description": "FAIRMINT",
        "divisible": true,
        "first_issuance_block_index": 377786,
        "issuer": "1PWef6kHvfmdEBBM2vKtJcijzVJpiE4Fic",
        "last_issuance_block_index": 866297,
        "locked": false,
        "owner": "1FairPYzS6MJJq5fPQqf3M58ZxJEpkiGfX",
        "supply":<PHONE_NUMBER>0000000
    }
}

adam@Adams-MacBook-Pro ~ > http https://api.counterparty.io:4000/v2/assets/MINTS/
HTTP/1.1 200 OK
Alt-Svc: clear
Content-Length: 356
access-control-allow-headers: *
access-control-allow-methods: *
access-control-allow-origin: *
content-type: application/json
date: Sat, 19 Oct 2024 12:19:39 GMT
server: waitress
via: 1.1 google
x-bitcoin-height: 866348
x-counterparty-height: 866348
x-counterparty-ready: True
x-counterparty-version: 10.5.0-alpha.2

{
    "result": {
        "asset": "MINTS",
        "asset_id": "5633620",
        "asset_longname": "",
        "confirmed": true,
        "description": "FAIRMINT",
        "divisible": true,
        "first_issuance_block_index": 377786,
        "issuer": "1PWef6kHvfmdEBBM2vKtJcijzVJpiE4Fic",
        "last_issuance_block_index": 866297,
        "locked": false,
        "owner": "1FairPYzS6MJJq5fPQqf3M58ZxJEpkiGfX",
        "supply":<PHONE_NUMBER>0000000
    }
}

adam@Adams-MacBook-Pro ~ >

Probably user error. Watch it to see if it happens again

Unable to reproduce


Docker client: tlsverify flag misses value

See also https://github.com/docker/machine/issues/2257
On Windows 7 I installed Docker Toolbox 1.9.0b and ran through the multi-host networking example.
Step 1:
docker-machine create -d virtualbox mh-keystore
OK
Step 2:
docker $(docker-machine config mh-keystore) run -d -p "8500:8500" -h "consul" progrium/consul -server -bootstrap
docker client complains about --tlsverify flag:
PS C:\Users\bergtwvd> docker $(docker-machine config mh-keystore) run -d -p "8500:8500" -h "consul" progrium/consul -ser
ver -bootstrap
flag provided but not defined: --tlsverify --tlscacert
See 'C:\Program Files\Docker Toolbox\docker.exe --help'.
PS C:\Users\bergtwvd>
PS C:\Users\bergtwvd> echo $(docker-machine config mh-keystore)
--tlsverify --tlscacert="C:\Users\bergtwvd.docker\machine\certs\ca.pem" --tlscert="C:\Users\bergtwvd.docker
\machine\certs\cert.pem" --tlskey="C:\Users\bergtwvd.docker\machine\certs\key.pem" -H=tcp://<IP_ADDRESS>:237
6
PS C:\Users\bergtwvd>
When I set --tlsverify==true it works:
docker --tlsverify=true --tlscacert="C:\Users\bergtwvd.docker\machine\certs\ca.pem" --tlscert="C:\Users\bergtwvd.docker\machine\certs\cert.pem" --tlskey="C:\Users\bergtwvd.docker\machine\certs\key.pem" -H=tcp://<IP_ADDRESS>:2376 run -d -p "8500:8500" -h "consul" progrium/consul -server -bootstrap

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This is an issue with flags on the docker windows client.  Are we sure this is not a powershell issue with how you provide flags?   some type of escaping needed?  Sorry, i don't know much about powershell.

The same on Ubuntu 16.04 x64:
$ docker-machine create -d virtualbox mh-keystore
Running pre-create checks...
Creating machine...
Waiting for machine to be running, this may take a few minutes...
Machine is running, waiting for SSH to be available...
Detecting operating system of created instance...
Provisioning created instance...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...
To see how to connect Docker to this machine, run: docker-machine env mh-keystore
$ docker (docker-machine config mh-keystore) run -d -p "8500:8500" -h "consul" progrium/consul -server -bootstrap
flag provided but not defined: --tlsverify --tlscacert
See 'docker --help'.

While:
$ docker-machine config mh-keystore
--tlsverify --tlscacert="/home/nazar-pc/.docker/machine/certs/ca.pem" --tlscert="/home/nazar-pc/.docker/machine/certs/cert.pem" --tlskey="/home/nazar-pc/.docker/machine/certs/key.pem" -H=tcp://<IP_ADDRESS>:2376

And all files are present where they specified.

This is an issue on Mac as well, a regression. My scripts stopped working because docker-machine config outputs --tlsverify and for whatever reason docker is no longer liking it.

@aperepel please explain.
--tlsverify is still a flag, and is on OSX client.

@cpuguy83 do you know what's going on?

let's close this because this does not appear to be an issue.
@aperepel @bergtwvd Please explain more if you can. --tlsverify is a flag on the client defined for all platforms.
We need more info to be able to troubleshoot this.


Create abstraction for Sensu mutators

Create an abstraction to execute Sensu Mutators (https://docs.sensu.io/sensu-go/5.5/reference/mutators/). Mutators accept a Sensu event, transform the event and returns the output JSON.
The first version of this repository contains an abstraction for the common Sensu handles logic. The abstraction is responsible to

Read and validate the Sensu event from stdin
Read the arguments from the command line, environment variable or Sensu event
Execute the user provided validation logic
Execute the user provided handler logic

We want to implement something similar for mutators.
The similarities and differences are:

Mutators and handlers both read a Sensu event from stdin
Mutators and handlers both read command line and env variable arguments
Do we want to support configuration overrides in the mutators? @calebhailey
Mutators return the transformed event's JSON to stdout or stderr @calebhailey is the transformed event just another event or it can be any arbitrary data structure?
Mutators return a 0 exit status code upon success or any other in case of failure

How to implement

See the way options are defined at https://github.com/sensu-skunkworks/sensu-aws-ec2-deregistration-handler/blob/sensu-auth/main.go#L31. Very similar approach but no need to have the Path property since it defines where to look in the Sensu Event. Dependent on the support of configuration overrides
Create a new sensu.NewGoMutator method instead of sensu.NewGoHandler https://github.com/sensu-skunkworks/sensu-aws-ec2-deregistration-handler/blob/sensu-auth/main.go#L31
The validation method signature should be the same - https://github.com/sensu-skunkworks/sensu-aws-ec2-deregistration-handler/blob/sensu-auth/main.go#L31
The execution method should return an interface object with JSON annotations, or an error - https://github.com/sensu-skunkworks/sensu-aws-ec2-deregistration-handler/blob/sensu-auth/main.go#L31 Signature might be something like func(event *types.Event) (interface{}, error)
If no error is present the exit status code is automatically set to 0, otherwise it is set to 1

Unit tests are required.

 Sensu Go Plugin Library

This has been implemented in https://github.com/sensu/sensu-plugins-go-library/pull/5.


[Bug] cant pull out methods from class diagram in separate morphs

SStickySourceCodeMorph>toolbarButtons
Author forgot to add the tooltip content as fifth array element -> 'syntax highlighting'
TODO: Write SStickyCodeMorph class comment

TODO: Write Test


Error message for long filename is confusing

Describe the bug
When uploading a receipt, there is an error message if the name of the file is too long. However, it isn't clear that that is what is going on.

To Reproduce
Steps to reproduce the behavior:

Try and submit a receipt with a filename over 255 characters long. I don't know how to do this - I couldn't figure out how to make a filename that long on OSX.

Expected behavior
I think the warning should be: "The filename for your receipt is too long. Could you shorten it?"
Additional context
Noted here: https://opencollective.com/email-markup-consortium/expenses/125848#new-comment-on-expense

Triage Template (core team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

In https://github.com/opencollective/opencollective-api/pull/8533 we've increased the max URL length but not the max file length. We'll solve the root issue and add a clearer error message.


License addition to source code

Hi There Joost Voskuil,
Great piece of work, Would you mind adding license to source code aka MIT / apache 2 or anything that works for you.
Cheers
Mani.

Fixed


Unable to publish a package -- Publish hangs without errors

Package: https://github.com/deco-cx/deco (version 1.108.1)
Command line execution (it hangs on the last message):
matheusgr@decocx deco % deno publish
Checking for slow types in the public API...

[...] a lot of warnings...

Visit https://jsr.io/auth?code=MPWD-SLSR to authorize publishing of @deco/deco
Waiting...
Authorization successful. Authenticated as Matheus Gaudencio do Rêgo
Publishing<EMAIL_ADDRESS>...
Already uploaded, waiting for publishing<EMAIL_ADDRESS>
Publish progress (from JSR page):
Waiting for some packages to complete publishing.
<EMAIL_ADDRESS>
Publishing has not started yet...

Dry run execute successfully. We have the same issue with our CI.
Task IDs (from jsr versions page):
Version: 1.108.1
Task ID: 9bff39dd-f7af-4a7d-bde1-d863fdb6ad2a
Created: 23 hours ago
Submitter: [View user](https://jsr.io/user/bf0dbdb3-77e0-481e-88ac-cb3889299523)
Status:
processing

It also happens to another user with publishing access (mcandeia).

I think I'm running into this issue as well for the @paul-db/core package. A few days ago this completed in ~30 seconds. This is the first time I attempted to published something via a github action, but I'm pretty sure my workflow configuration is correct.

We are looking into it - it's related to a recent upgrade of our documentation generation system. Sorry.

Fix: #877

This is fixed and all affected publishes are now unstuck and have succeeded


Konsole

Konsole is not in the list of terminal emulators

+1 pls add this

Konsole or Yakuake for me, why install another when I can use kfind instead? - your list is so limited...

+1 pls add this


Scale cursor so it matches the scale of everything else

Makes use of the percent scale setting to scale the cursor in the X11 client. This ensures that the cursor scale matches the scale of the rest of the RDP session. In my particular use case, the cursor is not tiny when viewing a 1080p session on a 4k monitor.

@freerdp-bot test

@nloewen I think you misunderstood something there. The settings you check have nothing to do with scaling, they just set the current resolution. smart-sizing is the only option that enforces local scaling, the other options activate server side scaling, which already adjusts the cursor sizes.

The way I've scaled it, the cursor is always an appropriate size for the monitors native resolution, when using percent scale.
I can change it to use settings->DesktopWidth / (double)xfc->scaledWidth as the scale, which would have the benefit of matching the scale of the remote content, but the cursor would have to be resized any time the window was resized. That seemed like it would add a lot of complexity, and the simpler solution seemed like an improvement over no scaling at all.

I updated my branch to use the window scale. It generates new cursor sizes as needed, and selects the correct size for the current scale when setting the cursor. The scaled cursors are cached since I figure it's common to go between a couple different window sizes. Unscaled windowed, and fullscreen for example. I suppose the latest commit isn't showing up here since the PR is closed already. I can create a new PR if needed.

@nloewen there is no percent scale, you use a convenience setting settings->PercentScreenUseWidth et al, which has nothing to do with scaling, as your factor.
Check settings->SmartSizing for local scaling enabled and compare local and remote resolutions to get a factor.

DesktopScaleFactor and DeviceScaleFactor are the settings enabling high dpi support server side (if the server supports that)


Fix cdmparser

Contributes to #125 and closes #126

Codecov Report

Merging #169 into master will increase coverage by 1.08%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   56.65%   57.74%   +1.08%
==========================================
  Files          44       44
  Lines        3777     3706      -71
==========================================
  Hits         2140     2140
+ Misses       1637     1566      -71

Impacted Files
Coverage Δ

src/base.jl
92.3% <50%> (ø)
:arrow_up:

src/parsers/pm_io/psse.jl
45.01% <0%> (+0.12%)
:arrow_up:

src/parsers/pm_io/data.jl
44.68% <0%> (+0.3%)
:arrow_up:

src/parsers/cdm_parser.jl
90.07% <0%> (+0.7%)
:arrow_up:

src/parsers/pm2ps_parser.jl
92.3% <0%> (+1%)
:arrow_up:

src/parsers/pm_io/matpower.jl
51.27% <0%> (+1.15%)
:arrow_up:

src/parsers/forecast_parser.jl
80.89% <0%> (+1.77%)
:arrow_up:

src/parsers/pm_io/common.jl
77.14% <0%> (+2.14%)
:arrow_up:

src/utils/print_timearray.jl
79.71% <0%> (+2.24%)
:arrow_up:

src/utils/data.jl
36.36% <0%> (+3.03%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410930c...6f3f7ec. Read the comment docs.


OS Support

[] Detecting OS...
[] OS Detected : Linux parrot 4.9.0-parrot16-amd64 #1 SMP Parrot 4.9.16-1parrot0 (2017-03-29) x86_64 GNU/Linux
[] Setting HERCULES path...
[] HERCULES_PATH=/root/HERCULES
[!] ERROR : HERCULES does not support this OS
[!] ERROR : Unable to create shoutcut

Did you run the setup with root rights? e.g. sudo....
It would be possible to get a workaround and change the os string to a supported one
but Hercules fails also because it, cant access the shell;
OutBin, _ := exec.Command("sh", "-c", "cd /bin/ && ls").Output()

I have the same error message
[] Detecting OS...
[] OS Detected : Linux raspberrypi 4.9.24-v7+ #993 SMP Wed Apr 26 18:01:23 BST 2017 armv7l GNU/Linux
[] Setting HERCULES path...
[] HERCULES_PATH=/home/pi/Downloads/HERCULES


[cordova][Crosswalk-15] Update component name and category

BUG=https://crosswalk-project.org/jira/browse/XWALK-4887

LGTM


add my blog samples-of-thoughts.com

Hey Cosima, thanks for reaching out. Here my PR to add my blog :)

Thanks so much for contributing 🥳✨


Bug report: chili code not covered

Priority
(Low) Something is a little off
Description
Since the latest version, i get an uncovered line in the chili.ts file when I do npm run test.
Seems that && typeof global.it === 'undefined' is not covered with me
Steps to reproduce
pull the latest version
do:

npm run clean
npm run build
npm run test

Expected results
Lines covered for 100%
Actual results

Diagnostics
No response
CLI for Microsoft 365 version
6.9.0
nodejs version
18.12.1
Operating system (environment)
Windows
Shell
PowerShell
cli doctor
No response
Additional Info
No response

Hi, @nicodecleyre seems like I cannot replicate this. Seems to be working for me.

Do you have any custom settings on your local machine that's causing this?

Works fine for me as well. But, I am curious about how your tests are running in just 14 seconds. @nicodecleyre

Thats fast indeed @Saurabh7019. I don't think my machine gets that score either

It seems that my laptop was having a hard time then 😄 .
From what it's worth here are some of the specs i have:

12th Gen Intel(R) Core(TM) I7 - 12899H, 2400 Mhz, 14 Cores, 20 Logical Processors
32 GB Ram

Thx! for checking this issue on your end @Saurabh7019 !
After doing m365 cli config reset, the problem dissapeared and now i can't reproduce it

14 cores... 🥶 go figure...

After doing m365 cli config reset, the problem dissapeared and now i can't reproduce it

Could you have a look at which config value caused this? Tests should run independently of config values set on the local machine.

This is something that would be solved with my centralized mocha idea:
https://github.com/pnp/cli-microsoft365/issues/4901

This is something that would be solved with my centralized mocha idea:
#4901

Ok, let's close it then.


Don't restart WAL streaming in the middle of a record.

I think this was changed inadvertently by commit 2c308da4d2. Change it
back.
Fixes https://github.com/zenithdb/zenith/issues/98

It would be nice to have a test for this, given that we've already broken this once. It seems pretty cumbersome to automate, though. At https://github.com/zenithdb/zenith/issues/98, I described the steps I used to test this manually.

Yeah, that was my typo between get_last_record_lsn()/get_last_valid_lsn(), sorry for the trouble.

Pushed, thanks!


Remove some dependencies

Remove the thiserror dependency from cranelift-codegen and cranelift-module and use a cleaned up version of it's derives expansion instead.
This improves compilation time of cg_clif by 6s. For users of cranelift that don't already disable optimizations for syn and other dependencies of the thiserror proc macro, the release mode compilation time wins will be even larger.
Remove some unnecessary dependencies as found by cargo-udeps.

I approve these changes in cranelift-module. I'm not a maintainer of cranelift-codegen so I will defer overall approval to someone else - @cfallin maybe?

It's somewhat surprising to me that changes in error-printing code would give such a large speedup in compile times. It's always welcome, of course, when speedups come -- but @bjorn3, do you have any sense of why this happens? I ask because it could be a symptom of something weirder going on behind the scenes -- for example, are we throwing a bunch of errors and doing work to capture backtraces but then silencing them somehow?
All other things being equal, the auto-derived error handling is kind of nice, but I won't fight too hard for it if we win by doing something lighter-weight.

I believe, because thiserror is a proc macro that depends on the usual stack of syn and friends, that compiling those dependencies is the tentpole in embeddings which otherwise don't use proc macros.

Ah -- to clarify, @bjorn3, you mean the compile time of cg_clif, not the time that cg_clif takes to compile code?
(I was assuming the latter, and thus was quite confused about the impact of error-path code on the happy path!)

Ah -- to clarify, @bjorn3, you mean the compile time of cg_clif, not the time that cg_clif takes to compile code?

Correct, I mean the time it takes to compile cg_clif itself. Sorry for the confusion.

but I imagine that cg_clif is very careful about deps.

Indeed. I try to avoid dependencies where possible and even use dependencies from the rustc-dev rustup component instead of crates.io where possible.

Would you mind leaving a comment above the Display & Error impls that these are written by hand to avoid pulling in the thiserror dep? That may help anyone who sees them and gets the clever idea that they can be replaced by a macro.

Done

Rebased


AuthController still could not be found

I have read answer to issue #16 but it not solves the problem. SocialAuthMiddleware is loaded after the RoutingMiddleware but the error persists.
src/Application.php:
        public function middleware($middlewareQueue)
        {
        $middlewareQueue
            ->add(ErrorHandlerMiddleware::class)

            ->add(new AssetMiddleware([
                'cacheTime' => Configure::read('Asset.cacheTime')
            ]))

            ->add(new RoutingMiddleware($this, '_cake_routes_'))
            ->add(new SocialAuthMiddleware([
            'requestMethod' => 'POST',
            'loginUrl' => '/users/login',
            'loginRedirect' => '/',
            'userEntity' => false,
            'userModel' => 'Users',
            'socialProfileModel' => 'ADmad/SocialAuth.SocialProfiles',
            'finder' => 'all',
            'fields' => [
                'password' => 'password',
            ],
            'sessionKey' => 'Auth.User',
            'getUserCallback' => 'getUser',
            'serviceConfig' => [
                'provider' => [
                    'facebook' => [
                        'applicationId' => '<application id>',
                        'applicationSecret' => '<application secret>',
                        'scope' => [
                            'email',
                        ],
                        'fields' => [
                            'email',
                        ],
                    ],
                    'google' => [
                        'applicationId' => '<application id>',
                        'applicationSecret' => '<application secret>',
                        'scope' => [
                            'https://www.googleapis.com/auth/userinfo.email',
                            'https://www.googleapis.com/auth/userinfo.profile',
                        ],
                    ],
                ],
            ],
            'httpClient' => '\ADmad\SocialAuth\Http\Client',
            'logErrors' => true,
        ]))
        ;

        return $middlewareQueue;
    }

OK, after full migration to from old Cake 3.5 to new 3.6 plugin system it started to work. So I'm closing the issue.


ufoai: fix underlinking against -lm

Without the change build fails as:
ld: release-linux-x86_64/testall/client/sound/s_mix.c.o: undefined reference to symbol 'acos@@GLIBC_2.2.5'
With change added I was able to start ufoai.

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/767

@ofborg build ufoai


Reproduces discs when I use it ina Jukebox

Minecraft 1.20.1 with Fabric Loader 0.15.9
When I place it under the Jukebox to pull out discs.. it pull one out but not the actual discs.... it replicates it, leaving the original in the jukebox.  I'm feeding it a new one from the side using your ducts but what happens is the same disc just plays over and over.
In the image below I had to use a Hopper to a chest to solve the issue.  Before the hopper wasn't there, it was a CollectorConnectedToBottomOfJukebox ---> Duct ------>BottomOfBarrel

I am suspecting this may be a Fabric Transfer API bug:
https://github.com/FabricMC/fabric/issues/3680
Are you running the very latest FAPI version?  If not, would you be willing to try 0.92.1:
https://modrinth.com/mod/fabric-api/version/0.92.1+1.20.1

I am suspecting this may be a Fabric Transfer API bug: FabricMC/fabric#3680
Are you running the very latest FAPI version? If not, would you be willing to try 0.92.1: https://modrinth.com/mod/fabric-api/version/0.92.1+1.20.1

Yup, it's what I'm already using 😁😎

This isn't reproducing for me.  I can reproduce the bug Fabric fixed if I use FAPI 0.92.0, but with 0.92.1 the discs cycle as I would expect.  So now I am wondering if you are using an old version of Cooldown Coordinator or Ductwork ... or if there is some other mod interfering with things.  Are you using Lithium?  Cooldown Coordinator should be suppressing its hopper optimizations, but I could look into that.  Make sure you are using Cooldown Coordinator version 0.6.2 and Ductwork version 0.7.4.

Yeah, they're lates and greatest for 1.20.1
This is the setup.. I p;aced C418 into the Barrel and it was pushed to the jukebox... Then it appears on the collector but the jukebox keeps playing.. They keep accumulating in the ducts and the collector.. just not in the barrel lol

This does not reproduce.  If you can provide the full log so I can see what mods are present and what if anything is logged, I can look into it further.

I do have a question if you don't mind?  I have a standard vanilla Barrel as the source...  Where I put the discs.  It's ALWAYS empty.  The discs are in the collector or ducts (spread around) at all times.  It's like they are storage themselves.
Is there a way to make it so that if the receiving end isn't taking in anything.. the the Collector leaves the items or is this the intent?

They work like hoppers; that is to say, yes they are storage and if the collector has space, it will take in items.  Just like with hoppers, you can stop this by powering collectors or dampers, so if you can come up with a redstone arrangement powering the collector when you don't want it to pull items, that will prevent it from pulling the items.
(I'm fairly certain the original issue reported here is caused by a mod; maybe the same one that makes the jukeboxes look different from vanilla jukeboxes.  I searched for a jukebox mod with a similar look but couldn't find one.)

It's just a resource pack, a replacement image/model.  Feel free to close
it, no one would ever expect you to isolate the issue with so many possible
conflicts.  I'm really sorry for wasting your time 😎. and thank you for
being so receptive to even looking at it and answering my questions.
Thank you for what you do.  💯🙏
On Thu, Apr 18, 2024, 16:29 gniftygnome @.***> wrote:

They work like hoppers; that is to say, yes they are storage and if the
collector has space, it will take in items. Just like with hoppers, you can
stop this by powering collectors or dampers, so if you can come up with a
redstone arrangement powering the collector when you don't want it to pull
items, that will prevent it from pulling the items.
(I'm fairly certain the original issue reported here is caused by a mod;
maybe the same one that makes the jukeboxes look different from vanilla
jukeboxes. I searched for a jukebox mod with a similar look but couldn't
find one.)
—
Reply to this email directly, view it on GitHub
https://github.com/gniftygnome/ductwork/issues/6#issuecomment-2065483398,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADC4Q46RYIGYCBGCG75IEV3Y6BJOZAVCNFSM6AAAAABGF5PNL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGQ4DGMZZHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


vkdt does not compile on Manjaro

This is the log from "make -j20 debug > debug.txt"  debug.txt
vkdt not built, only vkdt-cli, vkdt-fit and vkdt-eval-profile

interesting. obviously works here. your log doesn't even indicate that it tried to build the gui. do you have a custom config.mk? maybe something broke with the newer updates? is it a clean directory/fresh checkout? maybe bin/vkdt already exists and for odd reason has newer timestamp?

I always follow these steps (I did it twice to sure):
renamed directory vkdt to vkdtold
$ git clone https://github.com/hanatos/vkdt.git --recursive $ cd vkdt $ git submodule init $ git submodule update
copied config.mk from vkdtold/bin to vkdt/bin
$ make -j20 debug > debug.txt
all other known dependencies are installed.
config.mk.txt
(added ".txt" to config, otherwise it couldn't be uploaded)

hm okay sounds sane. could you try without your old config.mk? things
moved a bit lately. you don't need a recursive checkout any more, there are
no submodules (so these commands can go, too). also if you're configured
with rawler you don't need to set the pugixml things in the config.
On Sun, Jun 16, 2024 at 8:35 PM Heddesdorfer @.***>
wrote:

I always follow these steps (I did it twice to sure):
renamed directory vkdt to vkdtold
$ git clone https://github.com/hanatos/vkdt.git --recursive $ cd vkdt $
git submodule init $ git submodule update
copied config.mk from vkdtold/bin to vkdt/bin
$ make -j20 debug > debug.txt
all other known dependencies are installed.
config.mk.txt
https://github.com/user-attachments/files/15859446/config.mk.txt
(added ".txt" to config, otherwise it couldn't be uploaded)
—
Reply to this email directly, view it on GitHub
https://github.com/hanatos/vkdt/issues/127#issuecomment-2171802586, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMAKKLR4RKILYCBX542WQTZHXLF3AVCNFSM6AAAAABJI3C5I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRHAYDENJYGY
.
You are receiving this because you commented.Message ID:
@.***>

One thing I could do myself: I had to update rust from 1.78 to 1.79. But still no GUI was built.
I appended compiler logs to file and console.
vkdt_compilation_console_log.txt
debug.txt

.. do you have the xxd utility? it is needed to create the gui shaders.
On Mon, Jun 17, 2024 at 4:37 PM Heddesdorfer @.***>
wrote:

One thing I could do myself: I had to update rust from 1.78 to 1.79. But
still no GUI was built.
I appended compiler logs to file and console.
vkdt_compilation_console_log.txt
https://github.com/user-attachments/files/15872744/vkdt_compilation_console_log.txt
debug.txt https://github.com/user-attachments/files/15872746/debug.txt
—
Reply to this email directly, view it on GitHub
https://github.com/hanatos/vkdt/issues/127#issuecomment-2173594839, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMAKKMLCMG4TNLTUW2YRHLZH3YBNAVCNFSM6AAAAABJI3C5I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGU4TIOBTHE
.
You are receiving this because you commented.Message ID:
@.***>

This is a new dependency for me...
Now vkdt compiles, but crashes.
vkdt-bt-175265.txt

okay you could try again with current master. in general these assertions are mostly validation layer complaints that are way more useful to debug with vkdt -d qvk because then the error message will be printed to the console. also these are very useful to debug/harden the program, and not very useful just to run it for productive use. in fact the debug build target introduces some extra slow checks and memory overhead..

Now it works. Thank you!


Return codes of 404 for unauthorized users may disclose data

Describe the bug
We have several cases where users may query entities for an specific id:
group get --id 1
policy_type delete --id 2

In this case we need to search for the related entity in DB, to get its context (provider, group, org...) and only then we can check if the user is authorized or not.
But also in this check, we are returning a 404 error if the id is not found, even if the user is not authorized.
This may be the right thing to do , because we can inform the end user if it has some mistake with the ID it is using. But in the other hand, we may be informing an unauthorized user about this specific ID not existing, so it could be a security problem.
We need to discuss what's the best thing to do:

return some unauthorized error in the case an id is not found
continue doing as we do now, while we report a 404 when the id is wrong

Everything has pros/cons. We need to discuss about it and arrive to a decision to apply globally

This has been addressed.


E tensorflow/core/platform/cloud/http_request.cc:514

I run the train.py  in the object detection api, use the code in the terminal
python3 train.py --logtostderr --train_dir=training --pipeline_conf
ig_path=training/ssd_mobilenet_v1_pets.config
encounter with the problems like that,
Please use tf.global_variables instead.
2017-09-20 21:10:31.065044: E tensorflow/core/platform/cloud/http_request.cc:514] The transmission has been stuck at 0 bytes for 61 seconds and will be aborted.
2017-09-20 21:10:31.065307: I tensorflow/core/platform/cloud/retrying_utils.cc:77] The operation failed and will be automatically retried in 0.980452 seconds (attempt 1 out of 10), caused by: Unavailable: Error executing an HTTP request (HTTP response code 0, error code 42, error message 'Callback aborted')
2017-09-20 21:11:33.330807: E tensorflow/core/platform/cloud/http_request.cc:514] The transmission has been stuck at 0 bytes for 61 seconds and will be aborted.
2017-09-20 21:11:33.331297: I tensorflow/core/platform/cloud/retrying_utils.cc:77] The operation failed and will be automatically retried in 1.92775 seconds (attempt 2 out of 10), caused by: Unavailable: Error executing an HTTP request (HTTP response code 0, error code 42, error message 'Callback aborted')

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Ubuntu 16.04):
TensorFlow install from pip:
TensorFlow 1.3.0:
Python 3.5:
Only CPU:
-: i also install python2 and anaconda 2.7 in my linux

Source code / logs
python3 train.py --logtostderr --train_dir=training --pipeline_config_path=training/ssd_mobilenet_v1_pets.config

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Systemhealth "wrong" interfacename on optional interfaces

Hello again,
there is a Bug in the systemhealth page. Under packets / traffic there are the automaticaly created adapter names (opt1, opt2, op3). I renamed it after adding but on the health page there is still the old created ones.

this duplicates #428, we are unsure how to properly change it :)
The gist is this: the database content is fixed, but the interface names may be changed in the GUI all the time tough. It's nice to have to map them, but it's not a priority.


Resolve inconsistent percentage split evaluations

Changes
Updates the engine to the latest version to ensure that percentage split evaluations are consistent across Core, Edge and Local Evaluation mode.
As part of this, I have renamed the environment attribute use_mv_v2_evaluation to use_identity_composite_key_for_hashing. This field will now be used for all multivariate and percentage split evaluations.
Note that there are 3 PRs associated with this change:

Engine - https://github.com/Flagsmith/flagsmith-engine/pull/171
Edge API - https://github.com/Flagsmith/edge-api/pull/172
Core API (this one)
Edge Proxy - https://github.com/Flagsmith/edge-proxy/pull/61

These should be merged and released in the above order.
How did you test this code?
Fixed all the broken tests.

Migrations missing: https://github.com/Flagsmith/flagsmith/actions/runs/5392072603/jobs/9789884688?pr=2350#step:8:1


Incorrect stacktrace label when combined with extension tracer.

The only stacktrace is:
array_map
<path>/vendor/opencensus/opencensus/src/Trace/Tracer/ExtensionTracer.php:119

Looks like the backtrace was not propagated when creating the TraceSpan https://github.com/census-instrumentation/opencensus-php/blob/30bfa18773c36e9a522eae24221e96a1afcade16/src/Trace/Tracer/ExtensionTracer.php#L111


proposal: rename schema file names to snake case

we can probably also get rid of the " schema" suffix.
for example: Data Description Schema.json => data_description.json

I've done the top level schemas. I'll fix the ephys and imaging ones next.

done


Trouble installing TopShelf

Attempting to install via PM
Install-Package : Could not install package 'Topshelf 4.0.4'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.5', but the package does not contain any assembly references or content
files that are compatible with that framework. For more information, contact the package author.
At line:1 char:1

Install-Package Topshelf -Version 4.0.4

  + CategoryInfo          : NotSpecified: (:) [Install-Package], InvalidOperationException
  + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PowerShell.Commands.InstallPackageCommand

Minimum version is 4.5.2, so you'll need to upgrade your projects target framework.


GPU memory chunking error

@kylechampley   I can see that your current chucking method has some issue, when I use 720x2196x2404(numAngle,numRows, numCols) projection images, there is exceptional error which comes from the last chuck is overflow.
So I changed the maxSlicesForChunking to 180 from 128, because it is closely related to numAngle value. As you know, 720/128 = 5.625, which is not integer, so there should be residual memory area.
My modification is temporal, please adapt your final modification at your next release.

I'm sorry I don't understand your post.  What is the issue?  The chunk sizes don't have to divide evenly; the last chunk can be a different size.

Yes it is. the last chunk size is over the size of real projection mem-size, so there is exceptional error happens.  I guess that the difference comes from the one between the host-alloc-size and gpu-alloc-size.

Oh, I see this is with the 2D median filter.  You should have stated that in your original post.  This is an easy fix, all you have to do is replace:
medianFilter2D(f_chunk, numSlices, N_2, N_3, threshold, w, true, whichGPU);
with this:
medianFilter2D(f_chunk, sliceEnd - sliceStart+1, N_2, N_3, threshold, w, true, whichGPU);
This be fixed in the next LEAP release.

Yes, that modification works well.


dirmngr isn’t working in GnuPG 2.1.11

It may well be a config error on my side, but since updating to GnuPG 2.1.11 I get the following error:
$ gpg-connect-agent --dirmngr 'keyserver --hosttable' /bye
gpg-connect-agent: no running Dirmngr - starting '/usr/local/Cellar/gnupg21/2.1.11/bin/dirmngr'
gpg-connect-agent: waiting for the dirmngr to come up ... (5s)
gpg-connect-agent: connection to the dirmngr established
S # hosttable (idx, ipv6, ipv4, dead, name, time):
OK
$ gpg2 --refresh-keys
gpg: refreshing 8 keys from hkp://subset.pool.sks-keyservers.net
gpg: keyserver refresh failed: End of file

Can you reproduce this in the newest GnuPG or the same version built from source outside Homebrew? Thanks!

I first tried with brew reinstall gngup21 --build-froms-ource but the make check step failed!, gpgtar.test
Trying to build from source directly now.

All tests pass when I self-compile

Attemtping with brew again and the tests have passed shrugs

And dirmngr seems top be working again!

The gpgtar issue seems to be known:

Quoting Daniel Kahn Gillmor (2016-01-28 16:45:22)
I've packaged gnupg 2.1.11 for debian and uploaded it to debian
unstable.  however, i'm seeing intermittent failures in the gpgtar test
suite.  Particularly, in tests/openpgp/gpgtar.test.  These are not
reliable failures -- they just happen sometimes, frustratingly enough.

I have also seen it fail every now and then.  I'll look into that.

Justus


FLASH_TORCH is missing

Hi
I can't select FLASH_TORCH from camerakit constants, actually, it does not exist there.

same problem here, can someone explain why it is removed?


Jest setup

This PR addresses DM-911 installs and configures Jest for front-end testing. It also includes an example unit test suite for the ProgramType component (two tests should pass, one should fail).
Note: I had to use older versions of jest and jest types because the project's typescript version was old. Once Jon finishes the updates, we might be able to go up.

Our team should get an agreement going on when a commit of the package-lock.json is appropriate (this might be one).
You had mentioned having to play with older versions of Jest due to our old versions of everything. Should we wait to commit this until we get our packages up to date?

Reviewed with team - this issue has been fixed and is included in PR #214.

Closing ticket.


Checkboxes should return value

Checkboxes currently return true/false. When the checkbox is checked, it should return the the value of the value prop.
HTML would use the value attribute to send in a normal HTTP form submission when the checkbox is checked. When it is not checked, it technically would not submit the key/value (not too sure if that is desired here).
A possibility may be to work like angular's ngTrueValue and ngFalseValue, where, when present, are used when the checkbox is checked or not, respectfully. If not provided, use true/false We could have trueValue and falseValue props.

Fixed in 7970615 released in 1.3.0
trueValue and falseValue props have been added, true and false by default, respectfully.
Documentation has been added as well.


V2 color lost if translate sphere

Expected Behavior
translated red sphere
Actual Behavior
translated default color sphere
Steps to Reproduce the Problem

packages/web
npm run dev
run simple example sphere code

Specifications
function main(params){
  return translate([1,0,0],color([1,0,0], sphere()))
}

fails
function main(params){
  return color([1,0,0],translate([1,0,0], sphere()))
}

works and sphere is red

Version: V2
Platform: all
Environment: Brave, Firefox

Correct.  Color has to be applied as the last step.
I’ll keep this open, as other users might want to comment.

yeah, It is not  a problem to work around, but a step forward be to make a decision

to fix if feasible (may be too much trouble)
decide to leave it and document it in migration guide

Sry bout this ..., one unrelated question: is there a link with API docs for parameters for the functions.. right now I am looking into the source. Can I maybe build docs since I have the source checked out ?

You can build the API docs. :)
npm run docs
There will be a set of HTML files created in the ‘out’ directory.

I want to add another voice in favor of color being preserved through operations.
My workflow involves making a lot of things like libraries for bolts and whatnot when then lose their color when imported and used in a project.
I'm guessing that if this hasn't been done by now it's probably difficult to do though

I couldn't see any workaround to this problem when assembling parts together. Only the big parts in the last assembling step can have color. But parts of big parts cannot have any colors.

@crysislinux and folks
Keep in mind that many pieces can be returned from a design, each having colors.

My workflow involves making a lot of things like libraries for bolts and whatnot when then lose their color when imported and used in a project.

Not really. It depends on what’s being done with the parts.

Doesn't this make it impossible to generate the two tone jscad logo?

The two tone piece was not by choice. It was a result of boolean operations.  It’s not coming back.

If not the V1 behavior, what would be the ideal behavior of subtract(A,B) where A and B are different colors? The result is the color of A?

Keep in mind that many pieces can be returned from a design, each having colors.

Yeah, that's why I said:

Only the big parts in the last assembling step can have color as a whole. But parts of big parts cannot have any colors.

translate is required when assembling parts together, then you can only specify colors for parts in the final step.
After all, this is a really great thing to have, if it's adorable.

If not the V1 behavior, what would be the ideal behavior of subtract(A,B) where A and B are different colors? The result is the color of A?

Now, V2 does not set a color after operations.
Ideal color after booleans? I don't think there is one. The old V1 boolean operations were just weird.

It makes sense to me that most of the boolean operations would have a clear behavior when it comes to color, or at least an answer which is more user intuitive than no color at all.
I guess union would be the tricky one, because looking at the way color works there isn't a way for an object to have multiple colors.
If the decision is that the way things work now is the way things will stay, should we tag this as "wontfix" or close the issue? Personally I liked the way color in V1 worked better, although I agree it was weird for sure 😛

Visually, V1 might be better at times.
But colors really need to be applied per solid for 3D printing. Many of the slicers use colors to determine which filament to select, and produce multi-color prints. The focus of JSCAD is still 3D printing. 👍

It's actually fine to lost colors when doing transformations. It's useful when designing the parts. But we can have a main function for each part and work with a standalone part at a time most of the time.
Off-topic,
@z3dev could you please take a look at https://github.com/jscad/OpenJSCAD.org/issues/719 is that a limitation or bug?

I've been thinking about this further. Basically, there are some 'operations which produce a new geometry.

extrusions
expansions
hull
It's pretty clear that these would produce a new geometry without 'color'.

Next up are the booleans (union, subtract, intersect) which also produce a new geometry. (Forget V1 behaviour please.) So, I still think that a new geometry without 'color' is the best behaviour. If not then the boolean operations will be slower to retain color at the 'polygon' level.
Last are the transforms (align, center, mirror, rotate, scale, translate) which basically become a 'transform' on the geomtry, e.g. newgeometry = geom3.transform(matrix, oldgeometry). I think these could retain 'color' (and other attributes).
I think this makes working with parts (especially those with color) slightly easier.

I've been thinking about this further. Basically, there are some 'operations which produce a new geometry.

extrusions
expansions
hull
It's pretty clear that these would produce a new geometry without 'color'.

Next up are the booleans (union, subtract, intersect) which also produce a new geometry. (Forget V1 behaviour please.) So, I still think that a new geometry without 'color' is the best behaviour. If not then the boolean operations will be slower to retain color at the 'polygon' level.
Last are the transforms (align, center, mirror, rotate, scale, translate) which basically become a 'transform' on the geomtry, e.g. newgeometry = geom3.transform(matrix, oldgeometry). I think these could retain 'color' (and other attributes).
I think this makes working with parts (especially those with color) slightly easier.

@hrgdavor @crysislinux @BarbourSmith
This is fixed. Please try the latest release of JSCAD.

The transforms now preserve color. This issue is fixed :)

I'd like to add that the change in the way colors are handled impacts me a lot.  I often will color one part before a boolean operation so I can see that it was properly done.  For example coloring all the hole solids red before subtracting them from the main object, which now has the holes lined in red.
For 3d printing and selecting filaments by color, the change also hurts me there.  Assembling a complex object with boolean operations and losing the color info makes V2 almost useless for this case.
It would be nice if all of the operations had an option to retain the v1 color behavior, is that a possibility?

@johnwebbcole rendering I think still supports colorPerVertex. I think someone would need to port booelans from v1 to use functional style (instead of being part of classes) and then simply use that boolean when you need preview for the boolean operation with colors. You are not limited to jscad when writing jscad scripts, you can use any js library, so you might find a variant of csg.js that has the booleans that would keep color info.

It seems that color is lost when applying a mirror transformation on a geom2 object, but not on a path2 object. I'm not sure if this is desired, but its a bit confusing. For my application I'm generating a 2D design based on various parameters. Sometimes I need to mirror the whole design which is easily done as the last step, but some of the geometries (geom2) are not retaining the color. I'm exporting the design to DXF files for laser cutting where I'm using the color of the lines to control how the laser should cut the lines.

It seems that color is lost when applying a mirror transformation on a geom2 object, but not on a path2 object. I'm not sure if this is desired, but its a bit confusing. For my application I'm generating a 2D design based on various parameters. Sometimes I need to mirror the whole design which is easily done as the last step, but some of the geometries (geom2) are not retaining the color. I'm exporting the design to DXF files for laser cutting where I'm using the color of the lines to control how the laser should cut the lines.

@johnwebbcole can you open a new issue for this? It really doesn't make sense to open an issue from two years ago.


replace keys in config with constants

review @thieman

Is this necessary? If we're going to do this can we at least make sure we get something out of it, e.g. will pylint fail our tests if we reference a constant that doesn't exist?


entities fail to display

When the next field is set in the kong response, the list of entities (consumers, services, ...) fails to load with an invalid URL exception in urlOffset. Looks like this is due to the base argument not provided to URL for the relative URLs stored in next. I'll be adding a PR for your review (with a likely suboptimal solution :P)

Thanks Patrick.