Detekt Formatting has no effect

Introduction:
I have been using detekt in my Android project and the code quality stuff works really good. However I want to check formatting of the code as well and I am pretty sure my code is not well formatted.
How I use detekt formatting
I have a detekt.gradle -
apply plugin: 'io.gitlab.arturbosch.detekt'

detekt {
    config = files("$rootDir/quality/detekt.yml")
    baseline = file("$rootDir/quality/baseline.xml")
}

In my global build.gradle -
buildscript {
    ext.kotlin_version = '1.3.71'
    repositories {
        google()
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.6.2'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

plugins {
    id "io.gitlab.arturbosch.detekt" version "1.7.4"
}

dependencies {
    detektPlugins "io.gitlab.arturbosch.detekt:detekt-formatting:1.7.4"
}

allprojects {
    apply from: "$rootDir/quality/detekt.gradle"
    repositories {
        repositories {
            google()
            jcenter()
        }
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

In the detekt.yml, the formatting looks like this -
formatting:
  active: true
  android: false
  autoCorrect: true
  AnnotationOnSeparateLine:
    active: false
    autoCorrect: true
  ChainWrapping:
    active: true
    autoCorrect: true
  CommentSpacing:
    active: true
    autoCorrect: true
  EnumEntryNameCase:
    active: false
    autoCorrect: true
  Filename:
    active: true
  FinalNewline:
    active: true
    autoCorrect: true
    insertFinalNewLine: true
  ImportOrdering:
    active: false
    autoCorrect: true
  Indentation:
    active: false
    autoCorrect: true
    indentSize: 4
    continuationIndentSize: 4
  MaximumLineLength:
    active: true
    maxLineLength: 120
  ModifierOrdering:
    active: true
    autoCorrect: true
  MultiLineIfElse:
    active: true
    autoCorrect: true
  NoBlankLineBeforeRbrace:
    active: true
    autoCorrect: true
  NoConsecutiveBlankLines:
    active: true
    autoCorrect: true
  NoEmptyClassBody:
    active: true
    autoCorrect: true
  NoEmptyFirstLineInMethodBlock:
    active: false
    autoCorrect: true
  NoLineBreakAfterElse:
    active: true
    autoCorrect: true
  NoLineBreakBeforeAssignment:
    active: true
    autoCorrect: true
  NoMultipleSpaces:
    active: true
    autoCorrect: true
  NoSemicolons:
    active: true
    autoCorrect: true
  NoTrailingSpaces:
    active: true
    autoCorrect: true
  NoUnitReturn:
    active: true
    autoCorrect: true
  NoUnusedImports:
    active: true
    autoCorrect: true
  NoWildcardImports:
    active: true
  PackageName:
    active: true
    autoCorrect: true
  ParameterListWrapping:
    active: true
    autoCorrect: true
    indentSize: 4
  SpacingAroundColon:
    active: true
    autoCorrect: true
  SpacingAroundComma:
    active: true
    autoCorrect: true
  SpacingAroundCurly:
    active: true
    autoCorrect: true
  SpacingAroundDot:
    active: true
    autoCorrect: true
  SpacingAroundKeyword:
    active: true
    autoCorrect: true
  SpacingAroundOperators:
    active: true
    autoCorrect: true
  SpacingAroundParens:
    active: true
    autoCorrect: true
  SpacingAroundRangeOperator:
    active: true
    autoCorrect: true
  StringTemplate:
    active: true
    autoCorrect: true

Problem
I have a gradle task detekt. When I run, he does not complain formatting issues. What am i doing wrong here?

 Could you post what the fix for you was, just for protocol? Thx!

I have the same problem, after task detektFormat there is no effect
val detektFormat by tasks.registering(io.gitlab.arturbosch.detekt.Detekt::class) {     description = "Reformats whole code base."     parallel = true     disableDefaultRuleSets = true     buildUponDefaultConfig = true     autoCorrect = true     setSource(files(projectDir))     include("**/*.kt")     include("**/*.kts")     exclude("**/resources/**")     exclude("**/build/**")     config.setFrom(files(projectDir.resolve("${rootProject.projectDir}/detekt/format.yml")))     reports {         xml.enabled = false         html.enabled = true         txt.enabled = true     } }

@alexxxdev I guess you also added the formatting jar?
dependencies {
    detektPlugins "io.gitlab.arturbosch.detekt:detekt-formatting:1.7.4"
}

Apologies for the late reply -
I had the issue that the detekt did not work with formatting. It turned out that I had made the formatting active as false. I set it to true and It worked.

@arturbosch yes, sure.
I have downgraded version and it worked
there may be a problem in a multi-module project, where the modules are not in the root of the project, but in subfolders?


Enabled 3.6, 3.7, 3.8 to conda build automation

Motivation and Context
Added head/headless options, enabled 3.6, 3.7, 3.8 to conda build automation
Regarding badges, propose to avoid deduplication and remove some of them:

Removed black badge as pre-commit badge is presented and if pre-commit installed black will be picked up, badge is important for contributors only
Removed version release badge as version is already mentioned on Anaconda release and should be the same
Added Docs badge as we want to focus users more that Documentation is available and it's alive
Added python languages supported.

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

We probably also need to update the build matrix then to do to install_and_test_ubuntu for 3.7, right? (in parallel)

Adding 3.8 is good idea based on statistics from Pytorch Conda repo, 3.9 maybe too early.
Regarding running testing for 3.7. I would rather add some integration tests for conda package builded than running all over tests on one more setup. Let's make conda packages testing separate PR.

Regarding badges, propose to avoid deduplication and remove some of them:

Removed black badge as pre-commit badge is presented and if pre-commit installed black will be picked up, badge is important for contributors only
Removed version release badge as version is already mentioned on Anaconda release and should be the same
Added Docs badge as we want to focus users more that Documentation is available and it's alive
Added python languages supported.

Removed black badge as pre-commit badge is presented and if pre-commit installed black will be picked up
How I wish I could actually enforce pre-commit being installed properly, but there are contributors who don't run it on every commit.

How I wish I could actually enforce pre-commit being installed properly, but there are contributors who don't run it on every commit.

Then they will get CI failed as soon as they send PR and discover that.

Badges now:

Slate Anaconda badges is known issue, switch to shields.io badge instead.

Removed the date from versioning for releases, while left it for nightly builds.

9 packages produced. PR is ready to be merged.


RNA alphabet error

Incredible work! Thanks so much for sharing! I've been encountering a PyTorch error when using RNA sequences that contain "U". I think I've traced it to network/parsers.py line 104: shouldn't the rna_alphabet contain U instead of T?

Hello, This is due to the fact that our RNA MSA generation pipeline produces 'T's.  I will check in a fix so it recognizes either.


TypeError: cb is not a function

Keep getting this error every time I try to update a cell value or use any functions (del, bulkUpdate, etc) for that matter.
doc.getInfo(function(err, info) {

    sheet = info.worksheets[10];

    sheet.getCells({
        'min-row': 2,
        'max-row': 5,
        'return-empty': false
    }, function(err, cells) {
        var cell = cells[0];
        cell.value = 'test';
        cell.save();
    });
});

cell.save is expecting a callback!
usually wise even if you just log it so you can see if there are any errors happening

While I personally feel like cell.save shouldn't fail if not given a callback, if that is the case then the README may need to be updated because it shows cell.save(); without one.

@theoephraim the demos show save without a calllback. You should upate the demos!

interesting PR, but i think because it is async, allowing callbacks to be omitted would be more mis-leading to the user.  It would give the impressions that those calls are sync.
Although, the lack of callbacks in the example on the readme tripped me over, it was mentioned that the callbacks had been missed for berevity.  However, i think including , cb on those functions would be a better way to give the examples.
Happy to do a PR if you're happy to accept?

I think it's still unintuitive considering most other asynchronous libraries do not require a callback for things like .save() where you don't always need to get a result. Some notable ones are mongoose (.save() doesn't require a callback), requestjs, and even in standard es6 promises you can call .then() and not pass anything to it.

FYI - I've just a published a new version of this module which is a complete rewrite using Google's V4 Sheets API (v3 is being deprecated on March 3, 2020).
Docs available here - https://theoephraim.github.io/node-google-spreadsheet
The new version is promise based and should be much cleaner.
Thanks! 😄


flutter-engine LTS strategy

For Flutter SDK there are google storage buckets that archive stable releases.
This is not the case for flutter-engine.  The preferred approach is that the Flutter Engine team adds source archive similar to how the Chromium team does it.  Without having source tarball of entire tree, the recipe is is forced to use gclient.  Gclient pulls all the repos in the DEPS file.  These files are not archived in the Download Directory, and there is no guarantee the DEPS repos/links will all be good in the future.  Having source tarball allows all source to be archived in Download directory, as will as frees up the patch stage for actual patches.

In addition for near term I have refactored flutter-engine into a bbclass.  This allows creating dedicated release recipes.

https://github.com/meta-flutter/meta-flutter/releases/tag/AGL-0.3.0


Sender names missing from newly created chats & tapping on a received picture opens a different picture

After creating a newly created chat (in the most recent nightly app), received messages do not show sender names. Also, when receiving a picture, tapping on the picture opens a different picture. Restarting the app fixes this and the sender names appear and tapping the picture will open the correct picture.

I assume this has been fixed. Closing. If not, comment here and I will re-open it.


Fix bugs converting conditional transitions to jani

As title says, this PR fixes a problem when converting conditional SCXML transitions to Jani.
Additionally, a test for ensuring a correct translation of implication properties has been added (the bug itself seems to be already solved)
This addresses https://github.com/convince-project/AS2FM/issues/37

Hello, this PR should solve some of the issues we noticed in Genova.
Since we switched from a multi-package to a mono-package setup, you need to remove the old packages and install the new one (conveniently called as2fm, thanks Christian for doing that :smile:  ), you can find the instructions here: https://github.com/convince-project/AS2FM/pull/60/files#diff-e285c1b9901cd202e89d9f37e3249a6fee524a65428895e1a45fd062cc0f9aca
Additionally, I quickly updated the documentation with the new executable names and the new links.


Timestamp calibration issue on Apple Silicon

This was discussed previously in #1996, but I think the problem still remains.
It appears that on Apple Silicon, macOS GPU timestamp units are recorded and returned by MoltenVK in nanoseconds.  However, by changing the timeStampPeriod from 1.0 to 41.667 this causes a mis-calibration with external applications that are required to multiply returned Vulkan timestamps by the device property timeStampPeriod.  Final values are therefore too large by a factor of 41.667.
This is not an issue with MoltenVK 1.2.4 and earlier, but is an issue starting in SDK 1.3.261.1 and MoltenVK 1.2.5.  It is not likely an application problem either, since the same cross platform application logic for Vulkan GPU timing works correctly on Windows, Linux, and macOS Intel.
Perhaps we should return to timeStampPeriod = 1.0 for macOS on Apple Silicon, or if you require timeStampPeriod = 41.667, then "raw" timeStamps from queries would need to be returned in ticks not nanoseconds.
Please let me know if I am looking at this correctly, or if I have misinterpreted something.
UPDATE:  I was able to demonstrate that timeStampPeriod should be 1.0 for macOS on Apple Silicon by commenting out the following condition in MoltenVK and forcing time stamp calibration on my M1 Air.  The returned timeStampPeriod was 1.0 (with LowPassAlpha = 1.0 to eliminate filtering).
// On Apple GPUs, CPU & GPU timestamps are the same, and timestamp period never changes.
void MVKPhysicalDevice::updateTimestampPeriod() {
	if ( /* _properties.vendorID != kAppleVendorId && */
		[_mtlDevice respondsToSelector: @selector(sampleTimestamps:gpuTimestamp:)]) {
...

PR #2043 fixes this issue. Please retest with latest MoltenVK, and close this issue if it resolves the issue.
timestampPeriod is now set to 1.0 for Apple GPU's.

Thanks for fixing.  The only thing I am concerned about is possible impact on iOS.  I am less familiar than with macOS, so I don’t want my request for a fix on macOS to break this for iOS.
Is it possible that timestampPeriod should be 1.0 for macOS but remain 41.667 for iOS?

Thanks for fixing. The only thing I am concerned about is possible impact on iOS. I am less familiar than with macOS, so I don’t want my request for a fix on macOS to break this for iOS.
Is it possible that timestampPeriod should be 1.0 for macOS on Apple Silicon but remain 41.667 for iOS on A-series chips?

Good catch. Thanks for pointing that out.
The timestampPeriod was originally set to 41.667 on iOS when timestamps were generated by the CPU instead of the GPU, because that's the CPU tick on Apple Silicon.
For older devices that do not support GPU timestamps, I've now pushed an additional change to have the CPU-timestamps use nanoseconds instead of CPU ticks. That way, timestampPeriod can be 1.0, even with CPU-generated timestamps.
So, the only situation where timestampPeriod deviates from 1.0, should now be for GPU-generated timestamps on non-Apple GPU's.

Issue is fixed for macOS on Apple Silicon.  Thanks.


feat: concrete material properties and material class for Eurocode 2, 2004

Description
Implementation of the material properties of concrete according to Eurocode 2, Tab. 3.1, and a ConcreteEC2_2004 material class.
To do

[x] Implement material properties:

[x] fcm
[x] fctm
[x] fctk_5
[x] fctk_95
[x] Ecm
[x] eps_c1
[x] eps_cu1
[x] eps_c2
[x] eps_cu2
[x] n
[x] eps_c3
[x] eps_cu3

[x] Implement material class

Hi @DanielGMorenaFhecor, please have a look at this PR and let me know if you have any comments.

Thanks for the thorough review, @DanielGMorenaFhecor. I have addressed your direct comments above.
You are right that fcd was missing from the implementation, thanks for pointing it out. I have added a simple implementation of it in 82be739, including tests, and a method on ConcreteEC2_2004. The method on the concrete class is deliberately made simple, since we anyway need to figure out a clever way to handle the partial factors and other parameters that we get from the national annexes. We will return to this 😃
I also deliberately did not implement a function for calculating stress according to the parabolic rectangular law. We have an implementation of this law in #27, and after merging with that branch, we should make sure that all our material classes have proper methods for handling constitutive laws. So, we will return to this as well 😃

Also, thanks for your general comment related to our development workflow! I think what you have sketched makes perfect sense, since as you say, it might speed up the process. I do sense a bit of impatience, though, and this I can understand. We are moving slowly, but steadily. We are carefully considering our steps, but we are also bold in taking leaps. I am the first to agree that writing tests and docstrings is not a ton of fun. But one thing that is even less fun, is to break existing code without knowing it. One reason for the slow pace, is that we have prioritized building a good test suite. For the moment, we have approximately 1300 tests and a coverage of 96%! And thanks to you and others, we are on the way to build the sustainable library with the strong integrity we set out to build. I foresee that after merging #27, we can start moving slightly faster. Let us see how we can implement your ideas then 😃


AWS Lambda Tool implementation

Summary
This tool implements the same AWS Lambda functionality which I previously added to the JS package:https://js.langchain.com/docs/modules/agents/tools/lambda_agent

this looks pretty reasonable to me - i can fix lint if you think its good to land?

Sure, by all means!

this looks pretty reasonable to me - i can fix lint if you think its good to land?

Sure, by all means!

Never mind... figured it out


sw_engine: missing implementations added

Raster func for (inv)masked clipped images were missing .
before:

after:

example (calls all new funcs):
Masking_missing_func.zip

builds after #1015

@mgrudzinska could you please PR example as well?

I didn't close it on purpose...  #1023


not working

logs.log

Overnight the game offsets were updated overnight which is related to your problem, everything is working stable at the moment. Is your problem solved?

Yes thank you Great TB


sir one quick question

when u deploy it I m seeing master and sentinel are bundled in one pod and for other each slave has its own pod and as well as same see for sentinel also it has its own pod.
What is the reasoning for one master and sentinel to bundle in one pod? Thanks

It's for the bootstrap process, once the cluster is up you can set the replicas to 0.
The pod ( master and sentinel) uses the shared network namespace to bootstrap the Redis cluster.
In particular, the very first sentinel needs to know how to find the master.
The others subsequent sentinels will ask the first sentinel.

Thank you again sir.


Unable to Uninstall Extension.

[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to
Firebase support directly.

[REQUIRED] Step 2: Describe your configuration

Extension name:  firestore-send-email,
Extension version: 0.1.23
Configuration values (redact info where appropriate):

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
I tried installing the extension and it gave the following error. And then I tried to remove the extension and I can't do it.
I retried installing another instance and its same error. I have owner access to the project.
Expected result

Should be able to install/uninstall extension.

Actual result

Unable to uninstall/install extension.

PLEASE HELP

Hi there, thanks for raising this. I've been unable to reproduce this. Does this happen for you with a fresh firebase project?

It seems one of the permissions are probably broken for your project - You'll need the firebase CLI to be <v11 but you can update them:
> npm install -g firebase-tools@10
> firebase ext:update ${ext-name} . --project={project-name}.
> npm install -g firebase-tools@latest

In my case I ha deleted the service account
solved it by running
gcloud projects add-iam-policy-binding aefct-dba1e --member<EMAIL_ADDRESS>--role roles/editor

OK seems like this is solved? I will close. Feel free to reopen if the problem persists :)


Execute sensaas.py as Python script from meta-sensaas.py

Execute sensaas.py as Python script from meta-sensaas.py. Fix #7 .

Closing as stale.


Add one more Include to have the product workable with FetchContent

The issue with FetchContent was opened here https://github.com/oneapi-src/oneMKL/issues/306
The problem is that when we use FetchContent_Declare, it creates ${CMAKE_BINARY_DIR}/_deps dir where we have the build folder, downloaded sources, etc.
We do have generation of or config.hpp file as a part of oneMKL cmake and it puts this config file into ${CMAKE_CURRENT_BINARY_DIR}/oneapi/mkl/config.hpp folder
So if we don't add paths to the ${CMAKE_CURRENT_BINARY_DIR} into the includes, we end up with failures from domains that this config.hpp is not found.
To fix the problem, we just need to add ${CMAKE_CURRENT_BINARY_DIR} into includes.
You can see, that I have 2 versions here: ${CMAKE_CURRENT_BINARY_DIR}/.. and ${CMAKE_CURRENT_BINARY_DIR}/../../..
${CMAKE_CURRENT_BINARY_DIR}/.. works for general domain build (because in the general domain build CMAKE_CURRENT_BINARY_DIR is {CMAKE_CURRENT_BINARY_DIR}/)
${CMAKE_CURRENT_BINARY_DIR}/../../.. works for backend/gpu backend/cpu domain build (because in this build CMAKE_CURRENT_BINARY_DIR is {CMAKE_CURRENT_BINARY_DIR}///<mklcpu/mklgpu>)

Thanks for the patch. I can see you are only adding the include path for the mklcpu and mklgpu backends, don't we need this for all the other backends too?
Also just a suggestion I think it would be more readable to store the path to include in src/CMakeLists.txt as an internal variable ONEMKL_GENERATED_INCLUDE_PATH for instance and use it everywhere instead of relying on relative paths.

Thanks for the patch. I can see you are only adding the include path for the mklcpu and mklgpu backends, don't we need this for all the other backends too? Also just a suggestion I think it would be more readable to store the path to include in src/CMakeLists.txt as an internal variable ONEMKL_GENERATED_INCLUDE_PATH for instance and use it everywhere instead of relying on relative paths.

Thank you for pointing me to the missed backends! I love your ideas! Does it look better now?


Grid Items not Re-Rendering when Component Props Update

I have an app that displays a grid of widgets using react-grid-layout. Each widget is dependent upon external data and is set up to display a loader until the data has been retrieved and the its props have been updated whereupon the component is re-rendered with the appropriate data. For some reason, though, the grid items aren't re-rendering after the props are updated. Any idea why?
Here's the block of code that calls the react-grid-layout component (see code comments):
<ResponsiveReactGridLayout
	className="layout qtDashboard_widgets"
	layouts={{lg: col4, md: col4, sm: col2, xs: col2, xxs: col2}}
	breakpoints={{lg: 1200, md: 996, sm: 768, xs: 480, xxs: 0}}
	cols={{lg: 4, md: 4, sm: 2, xs: 2, xxs: 2}}
	onLayoutChange={this.onLayoutChange}
	isResizable={false} isDraggable={false}
	rowHeight={290} margin={[10, 10]}>
	{this.widgets().map( function ( widget, i ) {
		return (

				{/*THIS BLOCK RE-RENDERS PROPERLY*/}
				<DashboardWidget {...widget} appState={this.props.appState} />

		);
	}, this )}
</ResponsiveReactGridLayout>

...and here's the DashboardWidget component render block:
render: function() {
	return (

			{/*THIS BLOCK DOES NOT RE-RENDER*/}
			<SingleMetric metrics={this.props.appState.metrics} />

	);
}

When I removed react-grid-layout from the equation, the re-renders took place as expected with the prop updates, but once re-inserted, the DashboardWidget component ceased re-rendering with prop updates.
Thanks, in advance, for your help!

You may need to use immutable data structures.  I'm guessing GridItem's shouldComponentUpdate is returning false when it compares props and nextProps because it is actually comparing a reference to the same object.  Have a look at this link for more info:
https://facebook.github.io/react/docs/advanced-performance.html#shouldcomponentupdate-in-action

Ahh... that makes sense. ImmutableJS solved it. Thanks so much!

FWIW, looks like GridItem is using a deep comparison of props and state via PureDeepRenderMixin.

Can someone here share an example?


Make link clickable in references at the end of tutorial

... when possible

Most reference links are clickable, did you have a page where that wasn't the case?

My mistake then. I should add the link in the bib file


Create blank repo and invite will to edit

Use github org MADE

Waiting for will to join the organization MADE (accept invitation) before closing this

I'm in

you are @willblev


Community call

We'll have our first community call tomorrow, at 14:30 UTC. Here's the link: meet.google.com/gcn-hbnx-imn
All welcome to join!
To find out what time that is for you, you can run:
import polars as pl
from datetime import datetime

MY_TIME_ZONE = 'Europe/London'  # replace with your time zone
print(pl.Series([datetime(2020, 6, 7, 14, 30)], dtype=pl.Datetime('us', 'UTC')).dt.convert_time_zone(MY_TIME_ZONE))

See you at:
shape: (1,)
Series: '' [datetime[μs, Europe/Amsterdam]]
[
2020-06-07 16:30:00 CEST
]


implement %%python for groovy kernel

remaining from https://github.com/twosigma/beaker-notebook-private/issues/97
this is harder because we have to refer to another kernel
https://jupyter-client.readthedocs.io/en/latest/api/manager.html#multikernelmanager-controlling-multiple-kernels
https://github.com/jupyter/jupyter_client/blob/master/jupyter_client/multikernelmanager.py#L42

Can the JVM fork off a Python process that starts the kernel?

I may be lacking important context for answering this, but there's a python package called javabridge which seems to allow a JVM to start a Python process and versa vice.
Calling Python from Java
Starting and Killing the JVM

closing in favor of https://github.com/twosigma/beakerx/issues/7124


glob-based include/exclude functionality

A few slight tweaks to Lalem001's awesome work on glob-based excludes:

I've switched to (at this time an older) version of micromatch. This works with leading ./ so that using npm link does not break exclusions.
I've added support for include along with exclude.

Reviewers: @Lalem001, @davidchase, @novemberborn

Looks good to me. :thumbsup:

I see a potential problem with the include implementation.
If both include and exclude are defined, shouldInstrumentFile will ignore the this.exclude completely.
Also, if someone wished to include the entire contents of their source directory without using --all, this implementation of include will not do that. It will only specifically include whatever was required.

Personally, I have come to prefer multimatch, you write specific includes, and can exclude with negated (!) patterns at any time.
If you are going to provide both include and exclude, my opinion is that exclude should take priority (i.e. if it matches exclude then it is excluded no matter what include says) include-exclude works that way.

Also, if someone wished to include the entire contents of their source directory without using --all, this implementation of include will not do that. It will only specifically include whatever was required.

I guess the README could make that more clear (though the section after config.include covers it).

If you are going to provide both include and exclude, my opinion is that exclude should take priority (i.e. if it matches exclude then it is excluded no matter what include says)

There are default excludes though. Would be good to allow a particular module to be covered, even if generally all modules are excluded.

There are default excludes though. Would be good to allow a particular module to be covered, even if generally all modules are excluded.

@jamestalmage hit on this a bit. It would be possible to have exclusion negations with a leading!. ESLint does this. For example, since node_modules is always excluded, a negation to allow glob to be covered could be something like:
{
  exclude: ['!node_modules/glob']
}

This is effectively the same as the current idea of include, where a file is included despite having been excluded in other patterns.

Yep, I think that's why it may make sense to have separate include/exclude globs, with the following defaults:
{
  "include": "**/*",
  "exclude": "!**/node_modules/"
}

@jamestalmage That example is effectively what --all will accomplish with this PR.
What would be nice, and I was hoping to accomplish in a future PR, is to have something like:
{
  include: ['src/**/*.js', 'bin/**/*.js']
}

This is not precisely possible with the current include implementation.

the two use-cases that I'd like to solve are:

a project has many files, but only cares about covering one -- for instance a codebase that transpiles quite a few files into a single asset (moment does this) -- I see include solving this problem.
a project that has many files, and only wants to exclude a few -- this is the more common case, and I think is solved by exclude.

I wonder what the most elegant approach to solve this is.

Right, I think what I suggested before:
var defaults = {
  include: everything,
  exclude: node_modules_and_common_test_paths
};

Our algorithm for matching is:
var fileMatches = includes.matches(file) && !excludes.matches(file)

If they provide their own includes we replace the default array, this makes a whitelist approach easy (but still provides automatic exclusion of node_modules, just in case they carelessly do something like **/lib/*.js).

If they provide their own excludes we append to the default array. This makes excluding one/two other files in addition to the sensible defaults easy.

If they really want to include something in node_modules, they have to provide a negation for it (since we aren't allowing them to replace the default excludes). It's a bit weird, but it is also a super rare need. Even then, it's probably the simplest (fewest characters) for the user once they understand. We obviously would need to document this with an example.

@bcoe, I think this method gives you the best answer to your request:

a project has many files, but only cares about covering one -- for instance a codebase that transpiles quite a few files into a single asset (moment does this) -- I see include solving this problem.

Just add a glob for that file to include.

a project that has many files, and only wants to exclude a few -- this is the more common case, and I think is solved by exclude.

Just add that file to exclude, since we are appending it to the default exclusion list (instead of replacing the default), you won't suddenly be covering node_modules, etc when you provide an exclusion pattern.They can use negation patterns for exclude in the corner cases where they actually want to exclude node_modules

@jamestalmage I am sold \o/

@jamestalmage I think this is ready to land, I've tested thoroughly at this point.

Sorry for the last minute comment. Please bear with me, but I would like to air out my thoughts.
I see files being loaded in two distinct modes right now:

Files required after wrap has been invoked (default)
Files picked up by glob when the --all flag is present

In the default mode, include and exclude are only working against a very limited set of files.
Include is not actually adding any files that were not required.
In the second mode, all files that are not explicitly excluded are included.
Include, I think, would have little effect here.
I was thinking that include can instead replace the **/*.js that is currently in addAllFiles. Basically have a new function addFiles and addAllFiles simply calls the prior with **/*.js. Then include can be sent to addFiles.
This way include can specifically add files that are not required.

@Lalem001 let's open a discussion about addAllFiles in a separate thread, I would like to land a first pass of these glob changes, and get a release out of nyc out the door -- we have several important patches ready to go live.

@bcoe understood. Go for it

:shipit:


Fix ambiguity when parsing POSITION(x IN (y))

The argument x IN (y) should be parsed as part of the special POSITION syntax but it's being
interpreted as an IN predicate.
Move the rule up above the functionCall rule to give it higher precedence.

Looks good

lgtm, thanks for the fix


Profile shows about commitment which I never made.

I clicked on the $5 commitment but I never fulfilled it or don't plan to. But my profile shows about the commitment.

These commitments are self-reported. We assume you go through with the donation. Did you click the golden "commit" button?
That's why we use the word "pledge" instead of "donate". You can edit your commitment at the bottom of your code profile.

@QuincyLarson nice! :+1:
I thought it would be something like another "goal" related project in which people assign a donation amount to their goal. If they don't reach the goal till the deadline, then a chosen amount is donated to the chosen campaign.


Option to not expand function in outline

Issue Type: Feature Request
In the outline when I click on the name of a function I DO NOT WANT that part of the outline to expand. All I want to see in the outline are the names of the functions and global variables and the ability to click on one and auto scroll to that declaration/definition.
Another option would be that only one function in the outline is expanded at a time. When one is expanded, all other functions are collapsed.
Thanks in adavance!
VS Code version: Code 1.66.0 (e18005f0f1b33c29e81d732535d8c0e47cafb0b5, 2022-03-30T05:50:04.419Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

Are you clicking on the function's name or icon, or on the twistie that is on the left side of the function's icon?

It's not from clicking anywhere in the Outline panel. It happens whenever I click on an explicit or a derived variable declaration inside the text of a function. I want the outline to expand the function only when I click the twistie next to the name in the outline.

Try unchecking Follow Cursor in the ... menu on Outline panel's header.

I want the function of Follow Cursor. And I don't need or want to see the local variables in the outline when I see them readily when I'm editing that function. I'd be happy with an option to turn off the ability to expand a function in the outline in any way.

Have you tried altering the settings described at https://github.com/microsoft/vscode/issues/53262#issuecomment-731433068?

Thanks, that works. That option is either misnamed or needs a better explanation. To me turning off Outline: Show Variables means don't show any variables in the outline. I think a better name would be Outline: Show Local Variables or Outline: Show Function Variables.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


updated platform-api operand to a7cb08

please also update these files

README.md
csv_images.sed
docker rmi -f on line 240 in Makefile

/lgtm


SQL authentication failure

I've built the 3 dockers in accordance with the instructions multiple times.
The logs are always the same for cleanslate server.

The port is different because I have multiple other SQL dockers running without issue.
I can connect to the same database with the same username and password and it works.

The client portal works but obviously you can't login.
I've also tried building the dockers without the variables from the env (direct in the compose) and same issue.
Any chance the issue is in the build.

Found the problem, it's this line:
HASURA_GRAPHQL_DATABASE_URL: postgres://postgres:${POSTGRES_PASSWORD}@host.docker.internal:5432/postgres
I had to specify the password removing the variable, also did it for POSTGRES_PASSWORD: and HASURA_GRAPHQL_ADMIN_SECRET: to be sure.
I don't use special characters in my SQL passwords so it can't be that.
The env file is in the cleanslate root directory with no name as specified.

Hmmmm...
So I think it because you are using a different port but never changed it in HASURA_GRAPHQL_DATABASE_URL. I updated the README.md to make the steps clearer. Can you run through the newly improved How do I host Clean Slate? section again. If that does not fix it, share the custom.yml and I'll see if I can help debug further. Thanks!

Sorry the line was copied from the compost in Github as my modified line had my password.
I did set the custom port and the logs showed it was failing to authenticate and thus was reaching the database.
On a side note before I close this.
The app is excellent, simple and most importantly self hosted.
Will there be other tracking measures such as carbohydrates and fat.
I used to use MyFitnessPal and it's the biggest wish for the Cleanslate app.

So, the app is designed for people who struggle with other apps, and want to lose weight. And the more things they have to track, the more they can get overwhelmed or feel like they have blown a target when they hit something. So it is definitely not a core feature for us, as we consider carbohydrates and protein really the only numbers worth tracking.
However, you’re not the first person who has asked this, so we may end up adding it by the feature flag.


[BBU-RFP] Indicio.tech: Financial support

RFP Topic Area
Consortium membership
Question
We like more information on the financial contractual obligations members of this consortium will have.

You are applying to be a Utility Service Provider to a public non-profit legal entity. You are being asked to respond to bid for services which you have expertise in providing.
Would you request financial obligations of investors in a business you are considering as a client? This question is not relevant to demonstrate your ability to provide the required services.

RFP Process has entered review stage.


Cow: Watch answaqar.onnmuhammad.9(?# facebook)

Cow requests the watch of the watch_keyword answaqar\.onnmuhammad\.9(?# facebook). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

answaqar\.onnmuhammad\.9(?# facebook) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


first install successfully， but import error

Traceback (most recent call last):
File "D:/code/py/vibora_test/main.py", line 6, in
from vibora import Vibora
File "C:\Program Files\Python36\lib\site-packages\vibora_init_.py", line 7, in
from .server import *
File "C:\Program Files\Python36\lib\site-packages\vibora\server.py", line 5, in
from signal import pause
ImportError: cannot import name 'pause'

Which version do you use? The version from PyPi? It is version 0.0.6 which contains a bug for windows. Version 0.0.7 on Github fixes this bug, but contains another import error (from socket import SO_REUSEPORT).
I would advise you to wait a little time for 0.1.0 and hope that it works on windows.

signal.pause()
Cause the process to sleep until a signal is received; the appropriate handler will then be called. Returns nothing. Not on Windows. (See the Unix man page signal(2).)
some code not work well on windows, I modify some but endless?

@danieldaeschle ye, I see it, But imcompatible code seem too many.

The newest version on repo (master branch) is fixed version. There is already issue opened for this error (https://github.com/vibora-io/vibora/issues/28). This is not connected with pip or python version. Signal.pause is just not supported on Windows.

@rikewang what does not work except of singal.pause()?


Fix alignment of marshaled inline arrays

Fixes #8274

  Generating native code
  Segmentation fault (core dumped)
/__w/1/s/bin/Linux.x64.Release/build/Microsoft.NETCore.Native.targets(231,5): error MSB3073: The command ""/__w/1/s/tests/../bin/Linux.x64.Release/tools/ilc" @"/__w/1/s/tests/src/Simple/PInvoke/obj/Release/x64/native/PInvoke.ilc.rsp"" exited with code 139. [/__w/1/s/tests/src/Simple/PInvoke/PInvoke.csproj]

I'll retrigger the CI just in case something didn't get restored properly.


ChangeTracker don't see changes in navigation property collection

I'm trying to get all changes made to an entity, including any changes made on navigation properties which belongs to that entity.
So, I've made an extension which recursively walks trough entity properties and all properties on it's references, and collects a list of what changed.
Here is my extension:
public static IEnumerable<PropertyEntry> GetChanges(this EntityEntry entity) {
	// Get changed properties
	var changes = entity.Properties
		.Where(m => m.IsModified == true && m.IsTemporary == false)
		.ToList();

	// Get changes from any navigation property
	var references = entity.References
		.Select(m => m.TargetEntry)
		.ToList();

	// Iterate navigation properties changes
	foreach (var reference in references) {
		// Add navigation properties changes to changes list
		changes.AddRange(reference.GetChanges());
	}

	// Return complete list of detected changes
	return changes;
}

and I call it from my repository class like so:
// ...
this.context.Entry(entity).GetChanges();
// ...

Entity class (User, inherited from IdentityUser), has about 8 navigation collections (Claims, Roles, AuthorizedIPs, ...).
Now, when I'm trying change AuthorizedIPs collection (add one new entry), I see CollectionEntry.CurrentValue containing newly added entry, but CollectionEntry.IsModified is still false

Further technical details
EF Core version: 2.0.3
Database Provider: Pomelo.EntityFrameworkCore.MySql 2.0.1
Operating system: Windows 10
IDE: (e.g. Visual Studio 2017 15.7.3)

Duplicate of #10450

Was this issue ever solved or was there a solution provided? I'm experiencing similar problem in which a property change or update is not persisted to the database because the property is part of a navigation property key. Hence, it's not mark as "modified". I can't find a solution.

@crackyTozo The closed-duplicate indicates that this issue was closed as a duplicate of #10450


Azure Cosmos DB naming confusion

When looking at the naming conventions for databases and more specifically Azure Cosmos DB, there is some confusion due to the use of terminology.
https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming#example-names-databases
The document states the naming for the "Azure Cosmos DB database" but shouldn't this be the "Azure Cosmos DB account"?
The database within an "Azure Cosmos DB account" doesn't has a "Global" scope as far as I know.
It also seems weird to add an environment suffix at the end for a database name within an account?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d3a84ce2-7a0b-4558-1e28-aeefc649b567
Version Independent ID: 3dffb383-4087-9aca-3b33-c5f777334062
Content: Define your naming convention - Cloud Adoption Framework
Content Source: docs/ready/azure-best-practices/resource-naming.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @martinekuan
Microsoft Alias: ssumner

Thank you for your feedback. We have created internal ticket 143250 to track and investigate this issue.

#please-close


Add support for 13.4

Add revision number for 13.4 and added the pointers

ok nvm, i cant find a good revision version pointer for 13.4. It works sometimes.
What was your strategy to finding the rev numbers to get the version correctly?

I used the openttd debug symbols and a debugger like Visual Studio to find all variable locations. I can find the version number offset myself if you'd like

I found an offset of 0x0094cd24 for _openttd_revision in https://github.com/OpenTTD/OpenTTD/blob/13.4/src/rev.h using a debugger (was annoying to get, my debugger kept crashing on me haha)

I tried the offset on my machine and it worked! I updated the offset and cleaned up the formatting in a commit, and it's all good to merge. Thank you very much for the contribution!


[Bug]: Chromium-based browsers' installation folder require special permissions

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name
chromium, chrome + any chromium-based browser
Expected/Current Behaviour
The print preview feature in Chromium 125.0.6422.77 does not currently work.
Steps to Reproduce
Click on 'Print...' or type 'Ctrl-P' to open print preview.

Possible Solution
According to the Chromium Issue Tracker, the cause is due to the installation folder requiring special permissions on Windows. The solution is setting the permissions on the folder. (comment #33 in Chromium Issue Tracker).
The Chromium contributors note that these permissions must be set to avoid the current feature loss in Chromium and potential future bugs and issues. A manual option on the install executable to set the permissions may be added later (comment #35 in Chromium Issue Tracker).
Please see the following issue for more details:
https://issues.chromium.org/issues/339994760
Scoop and Buckets Version
Current Scoop version:
d337bb1f (HEAD -> master, tag: v0.4.2, origin/master, origin/HEAD) chore(release): Bump to version 0.4.2 (#5964)

'main' bucket:
d796c1484 (HEAD -> master, origin/master, origin/HEAD) talosctl: Update to version 1.7.3

'extras' bucket:
f51a7538b (HEAD -> master, origin/master, origin/HEAD) wxformbuilder: Update to version 4.2.0

'versions' bucket:
8524ab137 (HEAD -> master, origin/master, origin/HEAD) vim-tux: Update to version 9.1.0448_20240529

'java' bucket:
8a3ee0fc (HEAD -> master, origin/master, origin/HEAD) zulumc: Update to version <IP_ADDRESS>

'games' bucket:
67747feb6 (HEAD -> master, origin/master, origin/HEAD) steam-rom-manager: Update to version 2.5.6

Scoop Config
last_update                       scoop_branch scoop_repo
-----------                       ------------ ----------
2024-05-29T22:38:52.0931703+02:00 master       https://github.com/lukesampson/scoop

PowerShell Version
Name                           Value
----                           -----
PSVersion                      5.1.19041.4412
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.4412
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Additional Softwares
No response

@aicynide I tried the fixes described here: https://issues.chromium.org/issues/339994760, but they don't seem to work with the latest Chromium 128+. Please check the link and see if something there works for you. I will try again if I get a chance and if I find a solution I will update here


Remove skip test field

VI Tester added a feature in version 3.0.2 to allow skipping from setUp.vi.

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Remove duplicate fields for determining whether to skip tests or not.
Why should this Pull Request be merged?
The field in VeriStandTestCase is now useless.
What testing has been done?
Ran Engine Simulation tests that use skipping logic.
2019_02_27_08_03_31 VI Tester.txt

Please bump the required version of VI Tester in the README


Refactored Inputs, config.schema.json, and updated eiscp fork

Before submitting your PR, please review the following checklist:

[x] CHOOSE CORRECT BRANCH: if filing a bugfix/enhancement use master branch
[x] TEST: run "npm test" before commiting
[x] TEST MORE: run "npm install" to check if you dependencies are OK
[x] LIST ISSUES this PR resolves
Directly addresses:
https://github.com/solowalker27/homebridge-onkyo/issues/13
https://github.com/ToddGreenfield/homebridge-onkyo/issues/70
https://github.com/ToddGreenfield/homebridge-onkyo/issues/75
https://github.com/ToddGreenfield/homebridge-onkyo/issues/79
https://github.com/ToddGreenfield/homebridge-onkyo/issues/77

Touches code around and thus potentially addresses (this should at least be looked at again after this):
https://github.com/ToddGreenfield/homebridge-onkyo/issues/74
https://github.com/ToddGreenfield/homebridge-onkyo/issues/72
https://github.com/ToddGreenfield/homebridge-onkyo/issues/71
https://github.com/ToddGreenfield/homebridge-onkyo/issues/68
https://github.com/ToddGreenfield/homebridge-onkyo/issues/63

[ ] KEEP PR small so it could be easily reviewed.
[x] AVOID making unnecessary stylistic changes in unrelated code

Manually merged my changes back in. Ran npm test and fixed all the linting errors. Performed a sanity check with my own Onkyo and confirmed it's functioning properly. I tried to keep your styling changes as much as possible. I updated the input mapping to use your input_name and display_name. Did some cleanup along the way. Should hopefully be easier to review and more immediately testable.

Sorry guys, I was really busy caused by a covid-19 project that forced me to work literally every day since April this year.
I lost track of all the changes, so please give me some short update what kind of help is needed here.
To give you some background info: I am authorized to merge commits on GitHub. To publish a new release on npmjs.org we need help from @ToddGreenfield
@ToddGreenfield to make things easier: in another project I added an npm token to my GitHub repository and enabled a GitHub action to push a new release to npm every time a new release was published on GitHub.
This is the action: https://github.com/cbrandlehner/homebridge-daikin-local/blob/master/.github/workflows/npmpublish.yml
Token documentation: https://docs.github.com/en/free-pro-team@latest/packages/using-github-packages-with-your-projects-ecosystem/configuring-npm-for-use-with-github-packages

@cbrandlehner You should be authorized to publish on npm for this package. Sorry guys, I just don't have time to maintain or assist.

@ToddGreenfield good to know, thanks. ALL, if you need me to publish something, please let me know.

hey there, any news regarding merging this PR? :)

If this is what is needed, I can easily help.

I would definitely use the DRX receiver support.  Anything I can do to help please let me know.

So is this the main repo now with 0.7.x, or is @ToddGreenfield's with 0.8.0?

I'm curious if anyone figured this out

Yes. It works. Just lots of trial and error. For the DRX 4 use the name DRX-4 input is bd.


Transaction feedback - when 'processing' tag is shown

A question has come up regarding the feedback we show when a transaction is triggered.
For example in the claim stake and fees modal.
If I tap 'claim' the processing tag appears before the MM window appears.
Is there a way for it to display after, and how would this work with other wallets?
cc: @Chwy5 @bthaile

@phoebemirman made a point about why we originally added it there: sometimes the mm window shows up behind the browser window so it can confuse people. 'Pending' worked better in this instance but it still doesn't tell the user they need to sign the transaction.
Should the label first be telling the user to sign, then once signed this label turns into 'processing'
This also relates to this ticket https://app.zenhub.com/workspaces/augur-5bfed3424b5806bc2bf8d173/issues/augurproject/augur/1750

We either need to add a delay and wait until MM is signed to say processing or say something else like pending or pending MM signing, before showing processing....bc we are not processing anything at that moment....and the MM signing box can show up behind the browser window here as well and a user would think a transaction is being processed when nothing is happening

At one time we had the button to run a transaction say ‘sign’ then change to ‘processing’ that would give the user feed back. And tell them the tx hasnt been sent. Something like that.

What about:

User taps "Claim"
Tag appears "Pending" (tooltip on hover says something like "waiting for you or your wallet to sign for..."
MM window appears > user signs
Tag updates to "Processing"

OR Edge auto signs and it automatically goes from "pending" to "processing"

is this MM specific - if so I would say "Please sign your MetaMask transaction to proceed" or "you to sign you must sign your MetaMask transaction to proceed"
Rest works

With ledger and trezor we throw up a blocking modal telling the user to sign the tx.

@bthaile @cillianhunter0 -- Were these states added in the v2 Designs?

Design has the task to incorporate the new functionality in design.

Ok, I'm gonna close this ticket and this can be handled dev wise in the follow-on engineering epic to #2378


Enable manual dispatch of build workflow

Oh, another idea: we could do something like
on:
  workflow_dispatch:
    inputs:
      commit:
        description: 'The commit to build from'
        required: true
        default: 'NA'

and modify the periodic.yaml to make it possible to create a release with a custom commit hash + repo location. That would be more complicated though but might be nice 🤷

cancelling in favor of https://github.com/clangd/clangd/pull/786


Weird conflicting behavior with generic functions in generic types?

Initial Problem
So I have a generic typed implementation of a binary search tree: https://gist.github.com/MaximumADHD/10ff7eaeeca558ae2b8ceec22350c44f
The type seems to work fine within the module itself, but problems start happening when I import and embed the type into other types:
--!strict

local BST = require(workspace.BST)
local data: { BST.Class<number> } = {}

for i, dummy in data do
	dummy:Add(0)
end

Type Error: (6,1) Type '{ @metatable BinarySearchTree, {| _compare: (number, number) -> number, _root: Node<number>? |} }' could not be converted into '{ @metatable BinarySearchTree, {| _compare: (number, number) -> number, _root: Node<number>? |} }'
caused by:
Type 'BinarySearchTree' from 'game.Workspace.BST' could not be converted into 'BinarySearchTree' from 'game.Workspace.BST'
caused by:
Property 'Add' is not compatible. Type '({ @metatable BinarySearchTree, {| _compare: (a, a) -> number, _root: Node<a>? |} }, a) -> boolean' could not be converted into '<T>({ @metatable BinarySearchTree, {| _compare: (T, T) -> number, _root: Node<T>? |} }, T) -> boolean'; different number of generic type parameters

Comparing the two functions types, it seems the function isn't being treated as a generic correctly?
({ @metatable BinarySearchTree, {| _compare: (a, a) -> number, _root: Node<a>? |} }, a) -> boolean
<T>({ @metatable BinarySearchTree, {| _compare: (T, T) -> number, _root: Node<T>? |} }, T) -> boolean

Possible root issue?
While I was trying to work around this bug, I noticed the following type definition is invalid:
type BST<T> = {
	Add: <T>(self: BST<T>, value: T) -> boolean,
	Remove: <T>(self: BST<T>, value: T) -> (),
	Iter: <T>(self: BST<T>, value: T) -> () -> T?,
	Front: <T>(self: BST<T>) -> T?,
	Back: <T>(self: BST<T>) -> T?,
	ToArray: <T>(self: BST<T>) -> {T},
	Clear: <T>(self: BST<T>) -> (),
}

However, it's fine to add a generic function to a generic type as long as the arguments don't include generics?
type Generic<T> = {
	Test: <T>() -> ()
}

I tried adding this Test function to my workaround and started seeing a similar different number of generic type parameters error:

I'm a little stumped on what the exact problem is, but I hope this repro is enough to track it down.

I spent way too much time on this. Glad I finally found this post.
I think generics are nowhere near production ready.

To explain one of the parts:
type BST<T> = {
	Add: <T>(self: BST<T>, value: T) -> boolean,
	Remove: <T>(self: BST<T>, value: T) -> (),
	Iter: <T>(self: BST<T>, value: T) -> () -> T?,
	Front: <T>(self: BST<T>) -> T?,
	Back: <T>(self: BST<T>) -> T?,
	ToArray: <T>(self: BST<T>) -> {T},
	Clear: <T>(self: BST<T>) -> (),
}

This is invalid because <T> on a function type introduces a different local T generic type, so it says that Add function has to work with any type T, not just the outer T that the BST type is being defined with.
Because outer and inner Ts are different, it creates an infinite recursion in instantiation of BST with potentially different types.
It should just be just:
type BST<T> = {
	Add: (self: BST<T>, value: T) -> boolean,
	...
}

Or if functions are intended to be generic over one of the parameters:
type BST<T> = {
	Add: <U>(self: BST<T>, value: U) -> boolean, -- even if function is generic over U, we still use BST<T>
	...
}

I know this doesn't help with the original problem, but I wanted to address this part.

I think this is the minimal repro:
--!strict

local BinarySearchTree = {}
BinarySearchTree.__index = BinarySearchTree

export type Class = typeof(setmetatable({}, BinarySearchTree))

function BinarySearchTree.Add<T>(self: Class, value: T)
end

local data: { Class } = {}

for i, dummy in data do
	dummy:Add(0)
	BinarySearchTree.Add(dummy, 0)
end

We get this error
Type Error: (14,2) Type 'Class' could not be converted into 'Class'
caused by:
  Type 'BinarySearchTree' from 'game.Workspace.Script' could not be converted into 'BinarySearchTree' from 'game.Workspace.Script'
caused by:
  Property 'Add' is not compatible. Type '(Class, a) -> ()' could not be converted into '<T>(Class, T) -> ()'; different number of generic type parameters```


CreateContainer can hang indefinitely if a non-responsive CIFS mount is used as a hostPath volume

Description
When hostPath volumes are used, containerd invokes os.Stat to determine whether a directory exists and create it if necessary.  A CIFS mount can become unresponsive and hang, and cause fstatat to hang.  containerd does not have a timeout on os.Stat (and Go does not seem to support interrupting os.Stat).
Steps to reproduce the issue

Mount some CIFS endpoints to directories on the host
Wait for the CIFS endpoint to become unresponsive
Start a container with a hostPath volume pointing to the unresponsive CIFS mount

Describe the results you received and expected
Expected: CreateContainer either starts the container (and it's the application's responsibility to deal with the volume being unresponsive) or fails with an error within the Kubelet's request timeout.
Actual: CreateContainer hangs, Kubelet times out and retries, containerd returns failed to reserve container name errors for subsequent retries (since the container name is being used by the hung request)
What version of containerd are you using?
1.7.13, but this seems like it can occur on any version
Any other relevant information
Here's an example goroutine hung in os.Stat:
goroutine 5669979 [syscall, 4896 minutes]:
syscall.Syscall6(0xc00308bc30?, 0xd?, 0x7f214c1a0888?, 0x7f21970aba68?, 0xd0?, 0xc00346c000?, 0xc001b1de10?)
        /usr/lib/go-1.21/src/syscall/syscall_linux.go:91 +0x30
syscall.fstatat(0xc000c3a880?, {0xc00308bc30?, 0xc00335eed8?}, 0xc001b1de48, 0x40?)
        /usr/lib/go-1.21/src/syscall/zsyscall_linux_amd64.go:1453 +0x98
syscall.Stat(...)
        /usr/lib/go-1.21/src/syscall/syscall_linux_amd64.go:66
os.statNolog.func1(...)
        /usr/lib/go-1.21/src/os/stat_unix.go:32
os.ignoringEINTR(...)
        /usr/lib/go-1.21/src/os/file_posix.go:251
os.statNolog({0xc00308bc30, 0xd})
        /usr/lib/go-1.21/src/os/stat_unix.go:31 +0x52
os.Stat({0xc00308bc30, 0xd})
        /usr/lib/go-1.21/src/os/stat.go:13 +0x2c
github.com/containerd/containerd/pkg/os.RealOS.Stat(...)
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/pkg/os/os.go:59
github.com/containerd/containerd/pkg/cri/server.(*criService).containerSpec.WithMounts.func8({0x5651d3d0b288, 0xc000dd6de0}, {0x0?, 0x0?}, 0xc00335f368?, 0xc000d39cb0)
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/pkg/cri/opts/spec_linux_opts.go:109 +0x802
github.com/containerd/containerd/oci.ApplyOpts({0x5651d3d0b288, 0xc000dd6de0}, {0x0, 0x0}, 0xc000ed7640?, 0x40?, {0xc0007a2300, 0x1f, 0x0?})
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/oci/spec.go:107 +0x91
github.com/containerd/containerd/oci.GenerateSpecWithPlatform({0x5651d3d0b288, 0xc000dd6de0}, {0x0, 0x0}, {0xc0012da280, 0xb}, 0xc00059bb00, {0xc0007a2300, 0x1f, 0x30})
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/oci/spec.go:78 +0xdd
github.com/containerd/containerd/oci.GenerateSpec({0x5651d3d0b288, 0xc000dd6de0}, {0x0, 0x0}, 0x5651d236ec65?, {0xc0007a2300, 0x1f, 0x30})
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/oci/spec.go:67 +0x98
github.com/containerd/containerd/pkg/cri/server.(*criService).runtimeSpec(0xc0002a8d80, {0xc000ed7640, 0x40}, {0x0, 0x0}, {0xc0007a2300?, 0x1f, 0x30})
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/pkg/cri/server/container_create.go:371 +0x3c5
github.com/containerd/containerd/pkg/cri/server.(*criService).containerSpec(_, {_, _}, {_, _}, _, {_, _}, {0xc00308bb30, 0x9}, ...)
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/pkg/cri/server/container_create_linux.go:344 +0x2c65
github.com/containerd/containerd/pkg/cri/server.(*criService).CreateContainer(0xc0002a8d80, {0x5651d3d0b288, 0xc00066df50}, 0xc00066cf90)
        /build/containerd-G5EoGn/containerd-1.7.13/.gopath/src/github.com/containerd/containerd/pkg/cri/server/container_create.go:160 +0x17da

Here are some containerd OS threads from ps -elfL:
5 D root        1864       1    5137  0   64  80   0 - 2079604 cifs_r Sep29 ?      00:05:29 /usr/bin/containerd
5 D root        1864       1    5152  0   64  80   0 - 2079604 cifs_r Sep29 ?      00:05:25 /usr/bin/containerd
5 D root        1864       1 1086529  0   64  80   0 - 2079604 cifs_r Oct02 ?      00:02:55 /usr/bin/containerd
5 D root        1864       1 1123167  0   64  80   0 - 2079604 cifs_r Oct02 ?      00:02:51 /usr/bin/containerd
5 D root        1864       1 1518802  0   64  80   0 - 2079604 cifs_r Oct04 ?      00:00:48 /usr/bin/containerd
5 D root        1864       1 1750232  0   64  80   0 - 2079604 cifs_r Oct04 ?      00:00:56 /usr/bin/containerd
5 D root        1864       1 1761205  0   64  80   0 - 2079604 cifs_r Oct04 ?      00:00:59 /usr/bin/containerd
5 D root        1864       1 1793732  0   64  80   0 - 2079604 cifs_r Oct04 ?      00:00:11 /usr/bin/containerd

Show configuration if it is related to CRI plugin.
No response

Some thoughts here:

containerd shouldn't hang just because a specified volume is backed by a non-responsive remote filesystem; we should compensate for that somehow.
Go does not seem to have support for cancelling an os.Stat.
Naively, we could break os.Stat out into a goroutine and have a select on a channel + context to have a timeout.  But this risks leaking goroutines (and OS threads) indefinitely.
We could have an in-memory data structure that tracks ongoing os.Stats and allows us to early return if the same os.Stat is being attempted.  This will still leak goroutines, but seems like it's not worse than the current behavior.
We should be tracking paths, not specific pods or containers here.  The Kubelet will likely keep retrying, and if we track containers (by their name, which changes based on retry attempt) we'll leak lots of threads.  Paths won't change between retries, so we should leak a maximum of one thread per pod this way.
It'd be useful to report a metric on the leaked threads, and record log lines about the leak occurring (i.e., when we've timed out an os.Stat, but the actual thread remains hanging).

Consider this:
errs := make(chan error)
ctx, cancel := context.WithTimeout(context.TODO(), 2*time.Minute)
defer cancel()

go func() {
	_, err := os.Stat("/path/to/whatever")
	errs <- err
}()

select {
case <-ctx.Done():
	fmt.Println("timeout")
case err := <-errs:
	fmt.Println("err", err)
}

The goroutine (and OS thread) calling os.Stat will stay blocked on the return of os.Stat until it returns.  If that hangs indefinitely because of the backing filesystem hanging (like we saw with these CIFS errors), the goroutine will leak.  I do think this ends up being strictly better behavior because containerd is still usable in this state (even if the particular container is failing).

What if we did this?
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()

errs := make(chan error, 1)
defer close(errs)

go func() {
        select {
        case <-ctx.Done():
                return
        default:
                _, err := os.Stat("/tmp/foo")
                // If you uncomment this you can force an error.
                // time.Sleep(6 * time.Second)
                errs <- err
                return
        }
}()

select {
case <-ctx.Done():
        fmt.Println("timeout")
case err := <-errs:
        if err != nil {
                fmt.Println("err", err)
        } else {
                fmt.Println("success")
        }
}

I think the goroutine would go into its default case since <-ctx.Done() is not ready, so it'd still block on the os.Stat.  If you want to simulate it, uncomment the time.Sleep and place some output in the <-ctx.Done() case inside the goroutine to see if it executes.

I see -- yeah if I add another print statement where you suggested, it only prints "timeout" (and doesn't go into that case).

this pr may fix https://github.com/containerd/containerd/pull/10841/files

I don't have an environment to verify this either; this was debugged based on logs from a customer's node.
My thought on how to test this was to have a FUSE filesystem that allows us to control the time it takes to respond to fstatat, using something like fifosync to trigger the filesystem to respond.

I refer to this pr https://github.com/kubernetes/kubernetes/pull/119968/files maybe it works well.

I don't think statx with AT_STATX_DONT_SYNC is really sufficient.  It might decrease the likelihood of this happening, but I'd rather make sure that containerd is resilient to the stuck os.Stat.


Added ability to use a custom field name for optimistic locking

I added the option to define a custom field name for optimistic locking.
optimistic_lock_field :some_custom_field
You can still use the old way
field lock_version
If both lock_version and a custom lock field is set, It will  make use of the custom lock field

Hello,
Thank you for this improvement! Would you mind making the interface conform to ActiveRecord's API (http://api.rubyonrails.org/classes/ActiveRecord/Locking/Optimistic.html)? I'd like Dynamoid to conform to ActiveRecord as much as reasonably possible.

Okay thanks! I'll make the change.


feat(plugins): Add config option to disable logging of warnings in co…

…nsole plugin
Running tests in multiple browsers ends up printing out a lot of useless warnings I'm already aware of. To make skimming through logs in the case of an actual failure easier, I want to be able to disable the logging of warnings in the console plugin.

I signed it!

Both concerns should be addressed now. Let me know if there are others. Thanks!

Merged in at a54c0e0


RuleValidator changes as requested by @tkrop

RuleValidator changes as requested by @tkrop

Codecov Report

Merging #594 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #594   +/-   ##
=========================================
  Coverage     84.58%   84.58%
- Complexity      905      909    +4
=========================================
  Files           145      145
  Lines          2335     2335
  Branches        307      306    -1
=========================================
  Hits           1975     1975
  Misses          223      223
  Partials        137      137

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/de/zalando/zally/rule/RulesValidator.kt
96.42% <100%> (ø)
16 <4> (+4)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987edaf...5c2de52. Read the comment docs.

:+1:

👍


Release nvidia GPU drivers as a hostapp extension

Customers with Nvidia GPUs are having trouble building the drivers as external modules. We should prepare a hostapp not only with the drivers but also the required libraries to use the GPU for CUDA etc.
This depends on the work on hostapp extension support to be completed

Just wanted to keep this issue tracked.
Any idea how long it would take to fix this? :+1:

hi @openedhardware we are currently working on this same support for the Nvidia Jetson device types. Once that is done we will start working on this.

Hi, @alexgg
Any update here?

hi @openedhardware unfortunately the scope of this work keeps growing and we don't have a clear ETA at the moment.

I would too like to know if any work has gone into this lately? Would be great to have!


Error (401/Unauthorized) downloading artifact from Github

Hi.
When I try to use the plugin from the Github repository I get a 401 HTTP error.
maven-plugin-plugin:jar:3.6.0 -> com.github.gantsign.maven.plugin-tools:kotlin-maven-plugin-tools:jar:0.9.26:
Failed to read artifact descriptor for com.github.gantsign.maven.plugin-tools:kotlin-maven-plugin-tools:jar:0.9.26:
Could not transfer artifact com.github.gantsign.maven.plugin-tools:kotlin-maven-plugin-tools:pom:0.9.26 from/to github (https://maven.pkg.github.com/gantsign/kotlin-maven-plugin-tools):
Authentication failed for https://maven.pkg.github.com/gantsign/kotlin-maven-plugin-tools/com/github/gantsign/maven/plugin-tools/kotlin-maven-plugin-tools/0.9.26/kotlin-maven-plugin-tools-0.9.26.pom
401 Unauthorized -> [Help 1]

Thanks!

Hi, @ddsimoes. I've finally reimplemented the Kotlin source scanning (Dokka replaced with Kotlin compiler) and deployed the new version (1.0.0) to Maven Central. I should fix the above issue.


HubConnection Off function requires exact same function reference

Version<EMAIL_ADDRESS>In my Angular 5 app I have to do this to make sure the OFF function removes the callback from the queue:

ngOnInit() {
    this.handleDecisionFn = this.handleDecision.bind( this );
    this.notificationService.on( 'creditDecision', this.handleDecisionFn );
}

handleDecision() {
  // do some logic here
}
someOtherFunction() {
  this.notificationService.off( 'creditDecision', this.handleDecisionFn );
}

Before I just passed this.handleDecision.bind( this ) in as the callback of the on(), but then I noticed that the indexOf function used in the source code of the Off function can't match because the reference is probably different.
In the signalr.js function Off, should the line
   var removeIdx = handlers.indexOf(method);

use a string comparison of the function instead of an object comparison?

use a string comparison of the function instead of an object comparison?

Why? Why can't you give it the same reference? AFAIK thats how most of the other javascript eventing systems work.

Well that is what I am doing, but it seems weird to store the reference in
an extra variable and then pass that into the on and off function.
It felt like I was working around the issue but if you think that is the
proper way of doing so, then I will accept that.
On Mon, 16 Apr 2018 at 5:35 pm, David Fowler<EMAIL_ADDRESS>wrote:

use a string comparison of the function instead of an object comparison?
Why? Why can't you give it the same reference? AFAIK thats how most of the
other javascript eventing systems work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/SignalR/issues/2039#issuecomment-381506842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFCkqzDgrTOp1qKqigRrhoADix2Mn11Mks5tpEncgaJpZM4TV_Et
.

Yes this is by design.


GROOVY-9800: ClassNode#toString includes generics of type arguments

https://issues.apache.org/jira/browse/GROOVY-9800

Merged. Thanks!


[BUG]Team leave doesn't work

Describe the bug
A few people in my server try to leave there team but they can't.
When they try to leave there team they get the following message: an internal error has appeared.
They don't are server operators.
My server console log also get a big error message.
To Reproduce
Steps to reproduce the behaviour:
/team leave
Expected behaviour
Leaving the team where they are in.
Screenshots

If applicable, add screenshots to help explain your problem.
Details
Please provide the following details about your server set-up:

Spigot version (found by running /version): 1.17
BetterTeams version (found by running /version BetterTeams):  4.0.2

Additional context
The server log error message https://mclo.gs/M7K73fb
Plugins used:

This bug has been fixed and the patch will be included in the next update. Thank you for reporting.


HTTP/2 Sending a GO_AWAY with an error code should close conneciton

Motivation:
The specification requires that sending a GO_AWAY frame with an error code results in closing the TCP connection https://tools.ietf.org/html/draft-ietf-httpbis-http2-17#section-5.4.1.
Modifications:

Close the connection after successfully sending a GO_AWAY.

Result:
Fixes https://github.com/netty/netty/issues/3653

@nmittler - FYI.

@Scottmitch LGTM ... just one question.

@normanmaurer - Care to elaborate on your suggestion to use ctx.close() instead of ctx.channel().close()?  Then I will cherry-pick :)

@Scottmitch ship it :beers:

Thanks for review!
Cherry-picked 4.1 (f250dfe) master (ba0f920)


Improve Key Rollover management

[x] Be able to register future SP x509cert on the settings and publish it on SP metadata
[x] Be able to register more than 1 Identity Provider x509cert, linked with an specific use (signing or encryption)
[x] Support the ability to parse IdP XML metadata (remote url or file) and be able to inject the data obtained on the settings.

Hey @pitbulk, this looks great. I've read through the documentation (but not the code) and it looks like it will fulfil the use-case of Azure signing key rollover nicely (ref #140).
So I take it the expectation is that we define the ['x509certMulti']['signing'] array with all the public keys that Azure provides us in their metadata - the three listed under <IDPSSODescriptor>, and the module will try each in succession?
This is awesome, thanks for implementing!

Yes, 'x509certMulti' allows to register more than 1 IdP public certificate and define if gonna be used for signing or encryption. The idp metadata parser is able to retrieve all the certificate data.

@pitbulk do you have a timeline in mind for merging this into master?

If I receive no negative feedback in the following days I will execute a new release next week.


Problem loading CT image

I'm accessing the viewer via the json URL. An MR image carries normal, but a CT does not. Didn't show any error, any idea what it might be?

same problem here => https://github.com/OHIF/Viewers/issues/2319

I'm accessing the viewer via the json URL. An MR image carries normal, but a CT does not. Didn't show any error, any idea what it might be?

I think to maybe Cross-Origin Request Problem try to read about it

The requests are OK, without any error, so much so that it loading other modalities. Can it still be Cross-Origin Request ??

The requests are OK, without any error, so much so that it loading other modalities. Can it still be Cross-Origin Request ??

I think there are two possibilities for the problem , first one is what i said Cors-origin because you don't have any response like 200 or 404  and u should try to prevent it from chrome or Firefox .
second one that u  have problem in query itself so try to compare your query of frame by the one at OHIF main site

Thanks @ngutman for the hint!
I can confirm that the new DCM4CHE was the root of this issue for me.

I found the problem.
I am a private server to return the metadata to me and load the images through Oracle's Object Storage and I ended up returning two tags that were outside of JSON Launch.
TAGS:
"RescaleSlope": "1",
 "RescaleIntercept": "0",


Internal publisher only publishes event payload

The internal dispatcher current only publishes the event.payload.
Is there a reason why it doesn't publish the other event information i.e. aggregateId, aggregate etc?
Context: Am using the dispatcher to publish to a message broker.

event.payload should be what you're looking for if you want to publish to a message broker.
The other information is an "internal" wrap of what you should send via a message broker (https://github.com/adrai/node-eventstore/blob/master/lib/event.js#L38)
If you need the information like aggregateId, etc... you have to put them in there.

Ok thanks for the prompt clarification.  👍


[AutoParallel] Fix ckpt convert bug for sharding v2

PR types

PR changes

Description

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Hosting on replit

Hi, have you considered hosting this tool on something like replit (https://replit.com/~), to avoid installation?

Hi Bridget,
Have a look at the Blazor version of Topo. It is a browser app, no installation runs on all browsers, computers, phones and tablets.
https://nomisnostab.github.io/Topo-Blazor/


Fix some typos that seem accidental

This pr fixes some typos that seem accidental

Thanks, i hadn't seen this pop up. I should probably update this soon


Fix crash when tabbable called with document

#13 broke tabbable(document) since ownerDocument is null on all document nodes.1 This PR fixes that calling pattern

@felipeochoa Published in 1.1.1

Awesome, thanks!


Fix div by zero

Closes #420 .
Added test case.

Note: The MIP solver is not supposed to generate zero prices. I guess the other two should be investigated for this case as well.


Fixed icons and added Road category to LMP3 series

Updated 525.jpg images to the most recent ones
Added Road category to LMP3 series

The series.txt entry is missing LICENSE and ID information.

@bfiete - Fixed formatting, also updated images for Falken Challange

The name of the GT4/LMP3 multi class series is still incorrect. It should be 'Falken Tyre Sports Car Challenge'.
Its listed multiple times in the Series.txt file so unsure which one is meant to be edited.


Windows Machine File Copy copies wrong files if correct mapping is missing

Using TFS2015 Update 1...
Using the step Windows Machine File Copy and specify $/some/path/in/tfvcrepo as source path but not having that specific path mapped in my build definition results in all mapped paths being copied to target machine destination folder!
Expected behaviour would be that the step fails due to incorrect  source path

I tried with latest VSTS task and it is working as expected.
There is a change in design of Windows file copy between update 1 and update 2., with the new design it should not be happening can you try with TFS 2015 Update 2 or VSTS account let us know the results.

Did you get a chance to try out?

Any update on this or can I assume it is working in latest and close the issue?

If you still face issue with latest version, feel free to re-open the issue


Class 'Twig_Cache_Null' not found

I'm using theme based on Timber and Twig and all works fine on my local dev environment, but when I publish it on WPengine server and navigate to the site I get this error:
PHP Fatal error: Class 'Twig_Cache_Null' not found in /nas/content/staging/ptlondon/wp-content/plugins/timber-library/vendor/twig/twig/lib/Twig/Environment.php on line 280
Contacted WPengine and they could not help me, advised to check with plugin developer.
Plugin and theme activates without any errors, only when I navigate to the site itself it breaks.
What version of WordPress, PHP and Timber are you using?
WordPress 4.7, PHP 5.5, Timber 1.1.12
How did you install Timber?
WP.org

allright, found what was the issue. There was cache in .gitignore file and therefore 'Cache' folder in lib was excluded in deployment. Maybe worth to note this somewhere in docs or even rename folders.


[aes, dv] Fix reseed test

Previously, this test had a couple of serious issues:

The reseed checking function was pretty broken. It did not get updates of the probed signals inside the busy loop as the function was call-by-value. In most cases function the function just timed out.
There was no failure in case the reseed didn't happen.
Writes to shadow registers were not correctly handled which in some rare cases caused recoverable alerts and test failures.

Also, the test did not properly verify automatically triggered reseed operations based on the reseed rate setting.
This resolves lowRISC/OpenTitan#17357.

I did run 200 tests an none of them failed.


"Failed to load the jupyter-notebook package" on Atom 1.18

Hello,
I get this same error message, both when  installing directly through GitHub as described here and when going through the plugin manager.
Is there a trick I could do to make it work? Any help would be greatly appreciated!
Atom: 1.18.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.6
Thrown From: jupyter-notebook package 0.0.10
Stack Trace
Failed to load the jupyter-notebook package
At /Users/mKals/.atom/packages/jupyter-notebook/lib/main.js: Unexpected token (36:4)

SyntaxError: /Users/mKals/.atom/packages/jupyter-notebook/lib/main.js: Unexpected token (36:4)
        return el;
      }
    });
  },

  deactivate() {
    at Parser.pp.raise (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/location.js:24:13)
    at Parser.pp.unexpected (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/util.js:82:8)
    at Parser.pp.expect (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/util.js:76:33)
    at Parser.pp.parseExprList (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:785:12)
    at Parser.pp.parseSubscripts (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:270:29)
    at Parser.pp.parseExprSubscripts (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:240:17)
    at Parser.pp.parseMaybeUnary (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:217:19)
    at Parser.pp.parseExprOps (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:163:19)
    at Parser.pp.parseMaybeConditional (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:145:19)
    at Parser.pp.parseMaybeAssign (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:112:19)
    at Parser.pp.parseExpression (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:79:19)
    at Parser.pp.parseStatement (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/statement.js:137:23)
    at Parser.parseStatement (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/plugins/flow.js:655:22)
    at Parser.pp.parseBlock (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/statement.js:442:21)
    at Parser.pp.parseFunctionBody (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:747:22)
    at Parser.parseFunctionBody (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/plugins/flow.js:643:20)
    at Parser.pp.parseMethod (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:717:8)
    at Parser.pp.parseObjPropValue (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:658:23)
    at Parser.parseObjPropValue (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/plugins/flow.js:891:13)
    at Parser.pp.parseObj (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:640:10)
    at Parser.pp.parseExprAtom (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:392:19)
    at Parser.parseExprAtom (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/plugins/jsx/index.js:412:22)
    at Parser.pp.parseExprSubscripts (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:236:19)
    at Parser.pp.parseMaybeUnary (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:217:19)
    at Parser.pp.parseExprOps (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:163:19)
    at Parser.pp.parseMaybeConditional (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:145:19)
    at Parser.pp.parseMaybeAssign (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/expression.js:112:19)
    at Parser.pp.parseExport (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/statement.js:682:21)
    at Parser.parseExport (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/plugins/flow.js:713:20)
    at Parser.pp.parseStatement (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/statement.js:115:90)
    at Parser.parseStatement (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/plugins/flow.js:655:22)
    at Parser.pp.parseTopLevel (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/statement.js:30:21)
    at Parser.parse (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/parser/index.js:70:17)
    at Object.parse (/Applications/Atom.app/Contents/Resources/app/node_modules/babylon/lib/index.js:45:50)
    at Object.exports.default (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/helpers/parse.js:36:18)
    at File.parse (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/file/index.js:574:40)
    at File.parseCode (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/file/index.js:691:20)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/pipeline.js:167:12
    at File.wrap (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/file/index.js:639:16)
    at Pipeline.transform (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/pipeline.js:165:17)
    at Object.exports.compile (/Applications/Atom.app/Contents/Resources/app/src/babel.js:70:22)
    at Object.compile (/Applications/Atom.app/Contents/Resources/app/src/package-transpilation-registry.js:79:33)
    at compileFileAtPath (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:97:37)
    at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:238:26)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (Applications/Atom.app/Contents/Resources/app/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)
    at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:887:35)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:158:34
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:99:21)
    at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app/src/package.js:144:18)
    at PackageManager.module.exports.PackageManager.loadAvailablePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:565:22)
    at PackageManager.module.exports.PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:495:27)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/package-manager.js:521:35
    at exit (/Applications/Atom.app/Contents/Resources/app/node_modules/settings-view/lib/package-manager.js:128:22)
    at triggerExitCallback (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:338:17)
    at /Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:351:17
    at Socket.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:220:15)
    at emitOne (events.js:101:20)
    at Socket.emit (events.js:188:7)
    at Pipe._handle.close [as _onclose] (net.js:493:12)

Commands
     -2:04.7.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-xcode-theme.theme-atom-light-ui)
     -1:40.2.0 core:confirm (input.hidden-input)

Non-Core Packages
atom-beautify 0.30.3
autocomplete-clang 0.11.3
busy-signal 1.4.3
cpp-generator 0.1.0
ex-mode 0.15.0
Hydrogen 1.18.0
intentions 1.1.2
jupyter-notebook 0.0.10
linter 2.2.0
linter-clang 4.1.1
linter-ui-default 1.6.2
markdown-preview-plus 2.4.9
vim-mode-plus 0.93.0
xcode-theme 1.4.0

Me too

Same here.

Me too

same

same

Up, same, me too

same

+1

+1

+1

+1

Bump

+1

+1

+1

+1

+2

Oh, simply remove the '}' at that line can get rid of the exception, but after doing so the layout get really ugly

How to remove the '}'

Any update?

+1

+1

bumpy bump

wtf?!?

+1

+1

+1

+1

+1

+1

+1

When do they want to address this?

Please try to delete { in the main.js file as mentioned #68  You should be able to find this file here: /Users/USERNAME/.atom/packages/jupyter-notebook/lib This will fix this issue.

At line 34 In main.js at /home/$USER/.atom/packages/jupyter-notebook/lib
activate(state) {
    // console.log('Activated');
    fixPath();
    this.openerDisposable = atom.workspace.addOpener(openURI);
    this.commands = atom.commands.add('.notebook-cell atom-text-editor', 'jupyter-notebook-atom:run', this.run);
    atom.views.addViewProvider(NotebookEditor,
      model => {
        let el = document.createElement('div');
        el.classList.add('notebook-wrapper');
        let viewComponent = ReactDOM.render(<NotebookEditorView store={model} />, el);
        return el;
      }
    }); //  *** delete this curly bracer at the begining of line ***
  },

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

++1 ... that was such an easy fix. someone needs to issue a PR for this and get it merged already.

++

Now the error message is gone and so did the design of the notebook ... rip  :cry:

++

+1

+1

+1

layout is ruined :(

FYI, this project is deprecated:

This project does not have any active maintainers. We recommend that you use nteract, a native notebook application built using Electron, React (like this project), Redux, and RxJS, or Hydrogen, a LightTable-inspired package for Atom that allows users to run code blocks and selections using Jupyter kernels.

If anyone would like to become maintainer of this repo, let me know and I'll spend some time introducing you to the codebase.

@gnestor I would not mind. why did the maintainers decide to let it go though?

+1

is it rude to say "Me too" ?!

same issue here

wow! me too. Seems like this project is dead :/

Ya, dead until we can find a maintainer. Check out Hydrogen!

is it rude to say "Me too" ?!

#MeToo

error still exists, atom says "issue reported" and links here after failure

There is a extra } in the main .js file
Simply open file : /home/.atom/packages/jupyter-notebook/lib/main.js
inside main.js on line 36: }); Replace this with )}, and On line 37 or 38 there is a }, remove it
Save the file
restart Atom

There is a extra } in the main .js file Simply open file : /home/.atom/packages/jupyter-notebook/lib/main.js inside main.js on line 36: }); Replace this with )}, and On line 37 or 38 there is a }, remove it Save the file restart Atom

Windows path for me was C:\Users\<username>\AppData\Local\atom\packages/jupyter-notebook/lib/main.js


fix: Use Image.LANCZOS with Pillow resize

Fix #108
Image.LANCZOS has been introduced in Pillow 2.7.0 https://pillow.readthedocs.io/en/stable/releasenotes/2.7.0.html#antialias-renamed-to-lanczos and removed in 10.0.0

Image.LANCZOS has been introduced in Pillow 2.7.0, so change should be safe


TypeError: a bytes-like object is required, not 'str'`

When I try to load my dataset folder, this happens.
[tag-editor] Loading dataset from C:\dataset\handholdingaftermarriage
[tag-editor] Total 820 files under the directory including not image files.
[tag-editor] Loading Completed: 410 images found
Traceback (most recent call last):
  File "F:\sd2\stable-diffusion-webui\venv\lib\site-packages\gradio\routes.py", line 414, in run_predict
    output = await app.get_blocks().process_api(
  File "F:\sd2\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1326, in process_api
    data = self.postprocess_data(fn_index, result["prediction"], state)
  File "F:\sd2\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1260, in postprocess_data
    prediction_value = block.postprocess(prediction_value)
  File "F:\sd2\stable-diffusion-webui\venv\lib\site-packages\gradio\components.py", line 4411, in postprocess
    file = processing_utils.save_pil_to_file(img)
  File "F:\sd2\stable-diffusion-webui\venv\lib\site-packages\gradio\processing_utils.py", line 86, in save_pil_to_file
    pil_image.save(file_obj, pnginfo=get_pil_metadata(pil_image))
  File "F:\sd2\stable-diffusion-webui\venv\lib\site-packages\PIL\Image.py", line 2432, in save
    save_handler(self, fp, filename)
  File "F:\sd2\stable-diffusion-webui\venv\lib\site-packages\PIL\PngImagePlugin.py", line 1318, in _save
    data = name + b"\0\0" + zlib.compress(icc)
TypeError: a bytes-like object is required, not 'str'

Seems to be related to metadata.

Cannot reproduce this issue as far as in my environment.
Is this still an issue?


Gushup doesn't start.

Hi, Gushup doesn't start.
Install output
https://pastebin.com/EhLnTd2r
Startup error
https://pastebin.com/RpvW8iw2
System information:
Archlinux kde plasma version 5.24.4
Python 3.10.4-1

You are just missing pyperclip.
pip3 install pyperclip

Thank you, that work!

I've added pyperclip to the dependencies. Closing this now :)


Need help getting a Release version with a tag

@richtea I'm having some trouble figuring out how to create a tag that will be seen as a 'release tag', can you help me figure out what I am doing wrong?
Here is my rfconfig.yml:

I have a release branch named 'release/sprint45'
I also have a tag on the latest commit of release/sprint45 named 'v45.1'.
That tag is getting ignored and I'm not sure why.
I'm testing this locally from the command line, no azure pipelines are involved.
The full debug output is attached, but here is a chunk of it where it seems to be seeing the tag along with the other branches, but then says next that it didn't find any release version tags and I get a 'beta' version.

Does anything stand out?  Any other info I can provide?
thx
Scott
release-flow-output.txt

Hi Scott, what command-line parameters are you passing? In particular, what value are you passing for --source-ref? This needs to be in the form refs/tags/v45.1 for the library to identify a release build type (see test).

Ah, got it.  I wasn't passing any parameters, other than --pretty, and as it was mostly working I didn't think to go back to the parameters, and I think assumed it would find the tag on it's own.  I've been using GitVersion for a few years and got used to that one.
That leads me to another question then, when using this in an Azure pipeline it sounds like I need to figure out myself whether a build should use a tag and conditionally pass that to the pipeline tasks's 'SourceBranch' input?  It sounds like it won't just find the tag on it's own?
Do you have/know of any example pipelines?  We typically just have a single pipeline that runs for any branch, trying to determine if we'll need to change that approach or not.  I looked through the tests in the extension repo but nothing jumped out.

Awesome, thanks for the pointers.
Have a great vacation!


Add Node 16 to msal-node supported versions

Coverage decreased (-0.2%) to 83.52% when pulling 8853e302bfde4ff34cf7dd2be63df9feebcbd157 on msal-node-16 into b38dc6bd734507d0fa9749eba522dc77c405d18e on dev.

I want the samples tested on node 16 before we release this. Let me know if you need any help, me or @samuelkubai can pitch in.

I want the samples tested on node 16 before we release this. Let me know if you need any help, me or @samuelkubai can pitch in.

@sameerag the way the E2E tests are set up, adding the Node version to the workflow, as this PR does, automatically runs the E1E tests for that version, so at least the automated E2E tests are covered here.

I want the samples tested on node 16 before we release this. Let me know if you need any help, me or @samuelkubai can pitch in.

@sameerag the way the E2E tests are set up, adding the Node version to the workflow, as this PR does, automatically runs the E12E tests for that version, so at least the automated E2E tests are covered here.

@sameerag @hectormmg Yeah, I was relying on the E2E tests here.

I want the samples tested on node 16 before we release this. Let me know if you need any help, me or @samuelkubai can pitch in.

@sameerag the way the E2E tests are set up, adding the Node version to the workflow, as this PR does, automatically runs the E12E tests for that version, so at least the automated E2E tests are covered here.

@sameerag @hectormmg Yeah, I was relying on the E2E tests here.

In that case, yes. Approving.


Simply Akka EventsController Stream Logic

Replace the custom stage implementation with stream composed via the DSL.
Add unit tests

JIRA Issues: MARATHON-7317

Closing patch for now; need to sort out the upstream Curator leader election simplification patch, first

@timcharper if you ever need the test from https://github.com/mesosphere/marathon/pull/5403 ported to new setup, it is here: https://github.com/gosubpl/marathon/commit/67b2a16931dab81f79a69938358b3cc392e8f62c