gulp not found for tasks when using custom location for global installs

VSCode Version: 1.1.1
OS Version: Linux Mint 17.3

Steps to Reproduce:

set npm globals to custom location; e.g. npm config set prefix '~/.npm-global'
change $PATH to put custom npm global folder first
install gulp and other globals modules to custom location

If I try to run a task, the following message is received...even though npm ls -g confirms gulp is installed properly...
Gulp is not installed on your system. Run npm install -g gulp to install it.
If I install gulp as global to the root location, then the task will run properly
Thanks,
David

I have got the very same issue, (currently running vsCode 1.3.1 over Ubuntu 16.04)
It seems that, when vsCode is launched through .desktop entry created after install, it doesn't seem to recognise this custom npm global folder. When is launched by a terminal like code . it works perfectly though
Hope it helps

@joaomoreno  looks like we still don't source the environment correctly when not launched from a terminal. I guess VSCode does't see the correct path.
@angel-aam could you do the following when started from the .desktop entry.

F1 > Toggle Dev Tools
in the console could you check if the process.env.PATH contains your custom global npm bin folder which contains the gulp script.

Hi @dbaeumer, I've tried what you posted and the PATH wasn't configured as expected, but that has shed some light, and I have found what was happening. I am using Ubuntu, and has the path configured through .bashrc, it looks like vscode configure the environment with .bash_profile, we just need to configure the path in there.
Many thanks!

@angel-aam Thanks for your insights.
Also, try updating to the latest VS Code version.

OK. Great to hear.  @davidmcl are you still experience the problem?

I was also experiencing this issue and just updated to the new version. Problem is still there, PATH not loading correctly.

@tiansivive do you have the path in the right profile script. See comment https://github.com/Microsoft/vscode/issues/6534#issuecomment-237522618

@dbaeumer Yes, I configured the PATH in .bash_profile. By the way, I use zsh and launching from terminal works , which is what I ended up doing...

@tiansivive when started from the Desktop (not terminal) can you do the following:

F1 > Toggle Dev Tools
in the console could you check if the process.env.PATH contains your custom global npm bin folder which contains the gulp script.

@dbaeumer it doesn't. It has my .rvm folder for gems but not my .nvm folder for npm modules.
I checked my profile files and the .zshrc exports both rvm and nvm, which gets picked up by VScode when I run it in the terminal. .bashrc exports rvm and .bash_profile adds everything from .bashrc and adds npm to it.
I thought vscode might be picking up on .bashrc so I added the nvm there but still nothing :/

@joaomoreno can you check this comment pls: https://github.com/Microsoft/vscode/issues/6534#issuecomment-242703168 @tiansivive is using zsh and it looks like his environment isn't sourced into VSCode.

@tiansivive Which version are you on? Did you try on the latest Insiders release?

@joaomoreno v1.4, I'm using ArchLinux so I'm always on the latest version.
I'll try with the insiders release as soon as possible.

@tiansivive @davidmcl @angel-aam Is this still an issue on the latest version?

I think this is related to #1771 and ultimately has the same answer: that  Code would ideally not look for a global install at all, but use the project local install of the build tool (Gulp) sitting right there, locked and specified at the correct version for this particular project. Not all of us have the luxury or practice of ensuring that every project we must touch work with the same global install of something like a build tool. I don't know that this problem comes up specifically with Gulp, but I also don't see any reason that Code would demand a global install that it can find, regardless.

This is related to the user env issues. Fixed long ago.


How to use?

I compiled it successfully but I don't know what to do with the dll after that.
Would it be just getting a dll injector and injecting it?
Can anyone make a simple tutorial?
Another question, is it for online or offline server?

Compile DLL. Start game , and use DLL Injector, Cheat Engine, Process Hacker or any you like. After complete intiliazing press in game INSERT to call the cheat menu.

Compiled it after adding the include and lib files to the project, INS doesn't work... the game did have an 18 gb update maybe the offsets have changed?

Compiled it after adding the include and lib files to the project, INS doesn't work... the game did have an 18 gb update maybe the offsets have changed?

Donts think so, i have actual update of the game and this DLL. Its still working perfectly on dedicated server


sameHourOfDay test broke after upgrade, semantics are unclear to me

Hey all, I've upgraded from 2.0.5 to 2.0.7, the following test succeeds in <2.0.7, and fails in 2.0.7
(hope that Kotlin is not a problem)
    @Test
    fun `Test hour matcher`() {
        val zonedTime = ZonedDateTime.now()
        val utcZonedTime = ZonedDateTime.now(ZoneId.of("UTC"))
        assertThat(zonedTime, sameHourOfDay(utcZonedTime))
    }

So does sameHourOfDay mean same hour in the selected time zone, or the same hour after correcting for time zone? I can't make out exactly what the supposed semantics are. If 2.0.7 is correct, I'd suggest adding a line of documentation.

Hi, thanks for getting in touch. There were changes in which fixed several latent timezone issues and defaulting of conversions. The code had a bug in it before, the semantics should not have been to adjust times to the default timezone when comparing. The expectation is now correct.  If the default timezone in the JVM the code is running is not UTC then the hour can't the same e.g. "now" in Paris would be 8am, now in "UTC" is 6am.
I'd have to try it, but if you did want to use adjustment semantics then the code below would do that
    assertThat(zonedTime, sameHourOfDay(utcZonedTime).atZone(ZoneId.systemDefault())


adding this repo to https://github.com/grantjenks/py-tree-sitter-languages

it looks like https://github.com/grantjenks/py-tree-sitter-languages is tryign to compile all tree-sitter languages in a single place.
Would you be ok for me to send a PR there to add this repo as one of the language being built ?

Would you be ok for me to send a PR there to add this repo as one of the language being built ?

Sure, go ahead!

Looks like the parser is already included


Unexpected "Parsing error: Unexpected token" errors

Is this a bug report?
No/maybe
Not sure if this is an issue with CRA or VSCode.
I am getting " Unexpected token" errors where I shouldn't - please see image below:

The error can be fixed by delete the character and typing it again. However the issue will arise again at the same place after a few refreshes.

Ok

Hi @jeremypeters,
sounds like an editor / OS issue to me 🤔 Does this occur with other editors?

Hi @petetnt
It's only been happening in one project - I've had to move on to another project now, but will check when I'm back on it.

@jeremypeters @petetnt I am also facing this issue. I am on CRA 2.
Tried on sublime and vscode, it's happening on both the editors.
FYI - It started as soon as I upgraded to CRA 2.


Source ARM Images

Can you please add source arm images?

Hey, I can look into this later when I have time.

Ok sir.

I support, it would be extremely nice

There's no support for ARM64 in the source games themselves.


Add x265, VPx, Opus, Ogg and Vorbis codecs

Can you rebase , it looks good but apparently can't  be merged

I can't seem to get it to build using your latest commits. It seems the --enable-ssl flag should be --enable-openssl:
Unknown option "--enable-ssl".
See ./configure --help for available options.

Thanks !


AsyncStream multi-consumptions does not propagate .finished event to all consumers

Description
As of main branch's 4d1d8a9de5e, AsyncStream's underlying AsyncStream._Storage.State.continuations (array of continuations) management is slightly different from AsyncThrowingStream._Storage.State.continuations (single optional continuation) which doesn't have fatalError("attempt to await next() on more than one task") thus causing the following multi-consumption issue which .finished event does not propagate correctly to all consumers:
@MainActor
func test() async throws {
    let stream = AsyncStream<Int> { cont in
        let task = Task {
            try await Task.sleep(nanoseconds: 1_000_000)
            cont.yield(1)
            cont.finish()
        }
        cont.onTermination = { termination in
            task.cancel()
        }
    }

    var iter = stream.makeAsyncIterator()

    for i in 1 ... 3 {
        Task {
            let value = await iter.next()
            print("===> await \(i) = \(value as Any)")
        }
    }

    try await Task.sleep(nanoseconds: 1_000_000_000)
}

Example console log:
===> await 1 = Optional(1)
===> await 3 = nil

/* NOTE: result varies for each run, but correct 3 awaits will rarerly be called */

The reason behind this is AsyncStream._Storage.finish() is not sending .finished events to all managed continuations but only first one.
However, due to the current nature of unshared AsyncStream by default, it might be simpler to just add fatalError("attempt to await next() on more than one task") for AsyncStream as well.
(Related: https://github.com/apple/swift-async-algorithms/issues/110)
Expected behavior
Either one would be the expected behavior:

Sending .finished events to all managed continuations in AsyncStream._Storage.finish()
Add fatalError("attempt to await next() on more than one task") for AsyncStream to explicitly tell multi-consumption is disallowed.

Thanks @FranzBusch for comment.
Your pitch looks great overall, so hope to see it coming in future Swift version!


Fix/388 hover on another element after dragstart

Solves #388, to the extent that options.hoverClass will not be added to any new item for as long as dragging takes place.
Chrome still maintains pseudo-class :hover at the original location of the item that is being drag.
Recent Firefox and Safari, however, do not maintain CSS :hover pseudo-class at the original item location.
The README.md warning not to use CSS :hover selectors for styling still holds true.

Coverage decreased (-0.4%) to 78.458% when pulling add62d042b7b03858e2bcb51d9ff67d4e88872c7 on mfeherpataky:fix/388-Hover_on_another_element_after_dragstart into 46bbb9d754f65a87586d3bae5145f0917183adf0 on lukasoppermann:master.

Geniously simple fix, thanks a lot. 👍


Show type picker for adding barrel to sidebar

Previously a message with options were shown instead of a picker.

Reason of force push: Mert's suggestion is done as commit --amend and this branch is rebased on feature/sidebar


N36: Way of Rhea

Let me know if you need any tweaks! :)
Part of #1098

Thanks!

It's been quite a busy month 😄

It has 😅


Restart operation on already stopped EAP7 standalone server does not display failure message to the user

At present, when user executes Restart operation on already stopped EAP standalone server, it shows the message - 'Restart initiated for selected server(s)'. Nothing happens to EAP standalone server and it remains in stopped state.
The UI should show some useful message to the user if it is expected that restart operation not to start already stopped EAP server.

@miq-bot add_label providers/hawkular
cc @abonas

so ...there is no 'start' operation at present.  should there be?

cc @pilhuhn

This is currently "working as designed" as the backend functionality to start a server (which needs to be done for a stopped server) does not yet exist in Hawkular proper. This will for sure not be in Euwe.

@miq-bot move_issue manageiq-providers-hawkular


Use the macros for duplicating as well

Introduced in #11416
We weren't using these macros for duplicating as well, so I forgot to duplicate a couple settings. This PR switches duplicating over to using the macros as well, which shou;d reduce future bugs.
Also adds notes to which properties are intentionally omitted from these macros.

[x] closes #12265
[x] Verified manually that #12120 still works as expected

did you make sure all our duplication scenarios work?

Are there any others than just the duplicate profile in the SUI?


Subscribe to the platform

Issue Template
Description
I want to add subscribe implementation to the platform so that users filling in the mail ids receive confirmation mail to their valid mail ids.
I will create API in the backend and also the frontend component in the footer to receive the mail ids and send the confirmation mail.

thanks for raising the issue, but we're not planning this feature currently ;)


Fix Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting...

Fix Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!
http://stackoverflow.com/questions/14376879/error-10-digest-iterations-reached-aborting-with-dynamic-sortby-predicate
== Info ==
angular#1.3.11
bootstrap#3.0.3
bootstrap-daterangepicker#1.3.19

Doesnt work for me...

So... did you have same issue ?

Yea having same issue
On Thu, Apr 2, 2015 at 9:43 AM, timezstyle<EMAIL_ADDRESS>wrote:

So... did you have same issue ?
--
Reply to this email directly or view it on GitHub
https://github.com/luisfarzati/ng-bs-daterangepicker/pull/68#issuecomment-88721504
.

--
Aayush


Compiling id_open

When compiling. I encountered the following error:
lib\libopendroneid\wifi.c: In function 'odid_wifi_build_nan_sync_beacon_frame':
lib\libopendroneid\wifi.c:261:11: error: 'struct ieee80211_beacon' has no member named 'element_id'      beacon->element_id = 0xDD;
lib\libopendroneid\wifi.c:262:11: error: 'struct ieee80211_beacon' has no member named 'length'      beacon->length = 0x22;
lib\libopendroneid\wifi.c:263:18: error: 'struct ieee80211_beacon' has no member named 'oui'      memcpy(beacon->oui, wifi_alliance_oui, sizeof(beacon->oui));
lib\libopendroneid\wifi.c:263:57: error: 'struct ieee80211_beacon' has no member named 'oui'      memcpy(beacon->oui, wifi_alliance_oui, sizeof(beacon->oui));
lib\libopendroneid\wifi.c:264:11: error: 'struct ieee80211_beacon' has no member named 'oui_type'
I was able to fix it by modifying the ieee80211_beacon struct  in odid_wifi.h adding the missing variables.
struct __attribute__((__packed__)) ieee80211_beacon {     uint64_t timestamp;     uint64_t element_id;     uint64_t length;     uint64_t oui_type;     uint64_t oui;     uint16_t beacon_interval;     uint16_t capability; };
I just wanted to let you know and thank you for your work.

You shouldn't be compiling anything in lib\libopendroneid.
From the README -
"Needs opendroneid.c, opendroneid.h and odid_wifi.h from opendroneid. The wifi.c in this directory is slightly modified from the one in opendroneid."
The last time that I checked for compatibility with the opendroneid library was a few weeks ago when they issued release 1.0.

Thank you for your reply.
"Needs opendroneid.c, opendroneid.h and odid_wifi.h from opendroneid"
Your program has dependencies with these files so I included them as a library and replaced wifi.c with your version.
However, it fails to compile as your version of wifi.c refers to element _id in the  ieee80211_beacon struct
error: 'struct ieee80211_beacon' has no member named 'element_id'
I was able to fix it by modifying the ieee80211_beacon struct in odid_wifi.h adding the missing variables.
I hope this makes sense!

I think I know what the problem is. The ESP32 project has its own local copy of wifi.c (with slight modifications). However, that file was changed recently in the core-c project to reflect some changes in the structure definitions in opendroneid.h (for adding Wi-Fi Beacon support) and the ESP32 project therefore no longer compiles correctly if you pick up the latest opendroneid.h from core-c.
wifi.c should be updated in the ESP32 project.
Probably a better long term solution would be figuring out what exactly those differences in that file are and get them committed to core-c somehow (possibly under a compile flag that identify the ESP32 environment). Then the entire core-c project could be added as a git submodule project in the ESP32 project and they wouldn't run out of sync. That would also get rid of the need to manually copying files.

@friissoren The difference is a few #if defined()'s so that it compiles on systems that do not have a MONOTONIC clock. I'll try to whistle up the enthusiasm to do a pull request.

@pierreSCpapon wifi.c is now compatible with the latest opendroneid code.

Compiles without a problem now! Thank you.


fix: improved undefined error handling

:tada: This PR is included in version 5.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use the 5 day/3 hour API to return the 5 day forecast for searched city

Makes a call to the API for the 5-day forecast data and displays a summary for each day #1
Added Weather Icon to have a visual element for each day's forecast to break up the text a bit (might need a review of how I've laid out the 5-day forecast)
Added some notes about the data displayed

@kopijunkie, This is Fantastic!! Very nicely done. I love your layout of the 5 day forecast. I removed your 'today' text in WeatherMessage.jsx as it was conflicting with an earlier merge. Other than that, things look great. Merging and closing. Please feel free to keep contributing!!

@bmorelli25 cool. had fun working on this project. i was thinking of possibly using Moment.js to format the dates to a more human readable format as a UI improvement.

Hah, I was thinking the same thing - using moment to add days of the week. This PR also got me thinking about a ton of over changes/improvements that could be implemented:

Maybe there is a button where you can select if you want to see current weather or the 5 day forecast
Custom background colors for each day of the week depending on the forecast
Formatting the current weather in the same way that you have done with the 5 day forecast

Not gonna lie, this was one of the improvements I was really hoping someone would do. It opens the door to so many cool features

oh, yeah. definitely has opened the door for more features now that there's more data to play around with. will start with the date display formatting with Moment.js as I think that will be a handy thing to have access to.

Awesome. Moving the conversation to issue #17.


Before deleting, how do I get the list of this table and update a field value of another table?

I have three tables , Inspection,InspectionDetail,and PurchaseOrderDetail.
when delete Inspection row,I want to update one field  on PurchaseOrderDetail table(IsAssign=0).
how can do this..
thanks ..
protected override void OnBeforeDelete()
{
base.OnBeforeDelete();
if (Row.OrderDetailsList != null)
{
var fld = PurchaseOrderDetailRow.Fields;
foreach (var detail in Row.OrderDetailsList)
{
if (detail.OrderDetailId.HasValue)
{
new SqlUpdate(fld.TableName)
.Where(fld.OrderDetailId == detail.OrderDetailId.Value)
.Set(fld.IsAssign, 0)
.Execute(this.UnitOfWork.Connection);
}
}
}
}
on this way ,the OrderDetailsList  object  is null, I Can't get details on delete row.

protected override void OnBeforeDelete()
{
base.OnBeforeDelete();
if (Row.InspectId.HasValue)
{
var sqlCommond =
"update PurchaseOrderDetail set IsAssign=0 where OrderDetailId in(select OrderDetailId from InspectionDetail where ParentId =" +
Row.InspectId.Value + ")";
                this.UnitOfWork.Connection.Execute(sqlCommond);
            }
        }

I try many way ,but any works on update another table field .why can't update for this SQL ..

create a new custom deleteHandler do it..


Performance decrease when upgrade from 3.31.0 to 3.31.1

Describe the bug
After upgrading package Microsoft.Azure.Cosmos from version 3.31.0 to 3.31.1, the average response time of our API drastically increases. This causes our web application to become very slow and unusable for our customers.
To Reproduce
Upgrade package Microsoft.Azure.Cosmos from version 3.31.0 to 3.31.1.
Expected behavior
We expect a patch version upgrade not to impact the performance negatively.
Actual behavior
The patch version upgrade drastically increases the average response time. I am unable to upload a picture for some reason, but we can clearly see the difference between the average response time with and without the package upgrade. Before we upgraded, the average response time was stable below 5 ms. After we upgraded Microsoft.Azure.Cosmos to 3.31.1, it would rise to around 20 ms. After we downgraded it again to 3.31.0, we can clearly see that the average response time is again below 5 ms.
The average response time may seem relatively low. The reason is that this graph is from a test environment. There is a low amount of activity, but as a result, the differences are clearly visualized. On a production environment, the average response times are much higher after the package upgrade (the average is around 1 second). A production environment has hundreds of users and as a result our application becomes unusably slow.
Workaround
The issue we encounter seems the same as the one reported in #3613. This issue has been closed in the meantime. The symptoms that we encounter seem to be the same that they have reported. The solution that this issue has been closed with was to upgrade the app service plan from P1V2 to P1V3. We have tried to upgrade the app service plan as well on our test environment. There, we saw that this also solves the issue for our application. However, upgrading the plan a single tier doubles the cost and as such we do not see this as a viable option. Similar to the reported issue, we do not see why the change in plan matters, since we do not see that cpu or memory of the machine is a bottleneck.
Environment summary
SDK: .NET8
App service plan: Premium v3 P0V3
Additional context

The package version of Microsoft.Azure.Cosmos 3.31.0 is over 2 years old and several new versions have come out in the meantime. We have tried to use newer versions as well in the hopes that the issue might have been mixed in the meantime. Unfortunately, we can still reproduce the issue with version 3.45.0.

I have compared the changes done in the repository between version 3.31.0 and 3.31.1 and the only change that happened was the upgrade of Microsoft.Azure.Cosmos.Direct from 3.29.1 to 3.29.4. https://github.com/Azure/azure-cosmos-dotnet-v3/compare/releases/3.31.0...releases/3.31.1
I have also looked at the changes done in the Microsoft.Azure.Cosmos.Direct package. Due to the large amount of changes, I cannot make sense of this. https://github.com/Azure/azure-cosmos-dotnet-v3/commits/msdata/direct/Microsoft.Azure.Cosmos/src/direct

can you please share the diagnostic string for patch operation with slower and faster sdk version. Maybe we can compare them by putting side by side and find out, why you are getting high latency.

I have done an investigation to further pinpoint the source of the issue. I have slowly removed parts of our code base related to CosmosDB to determine when the symptoms stopped showing. After doing this, it became clear that only having open a connection with the CosmosDB is enough to produce the latency problems. This means the problem is not related to any queries or such that we do. The code is following the best practices outlined in the documentation regarding only creating a single client throughout the apps lifetime. (1)
I am currently looking into any configuration options that can be passed when setting up the connection. I was wondering if this problem is known and if you have any recommendations for the type of machine that we are using. As mentioned in the initial description, our app is hosted on Azure using the 'Premium v3 P0V3' plan.
Note: I also read in the best practices document (1) that it is recommended to use a machine that has at least 8-GB memory and 4-cores. I realize that the 'Premium v3 P0V3' does not fulfill these requirements. However, as mentioned before, a machine that does is at least twice as expensive as the one that we are currently using so I am trying to avoid having to scale up.
(1) https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/best-practice-dotnet

Looks like these are the commits consumed
https://msdata.visualstudio.com/CosmosDB/_git/CosmosDB/commit/3fad226ed6247450bde8b5fad151ed7349d560e8?refName=refs/heads/sdkReleases/direct/EN20220407_3.29.4
https://msdata.visualstudio.com/CosmosDB/_git/CosmosDB/commit/3152c9d43fdfa539755f25e1cd9bf7bfa8166b56?refName=refs/heads/sdkReleases/direct/EN20220407_3.29.4
https://msdata.visualstudio.com/CosmosDB/_git/CosmosDB/commit/fd78585262f644246f54a8f16201fd71871e296c?refName=refs/heads/sdkReleases/direct/EN20220407_3.29.4
The first one has the highest likelihood to change client-side resource consumption

I do not have access to these links

I do not have access to these links

Understood - added them for engineer looking into this

For me it's working fine if I download it. Nonetheless, here is the zip again.
cosmos_diagnostics.zip

Am still getting

@FabianMeiswinkel, @sourabh1007 can you please try?


chore(curriculum): add quotes to strings in todo app

Checklist:

[ x ] I have read and followed the contribution guidelines.
[ x ] I have read and followed the how to open a pull request guide.
[ x ] My pull request targets the main branch of freeCodeCamp.
[ x ] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

This PR is related to #51036 about Quotes in Code Strings. I have looked over all of the steps in 'JavaScript Algorithms and Data Structures (Beta) --> Learn localStorage by Building a Todo App'. I only found five steps where quotation marks could be added (viz. steps 19-22, and step 46).

@Sembauke
Thank you for the suggestion. I have updated the PR in line with your request to put quotes around relevant strings in the hints as well.


[SPARK-24163][SPARK-24164][SQL] Support column list as the pivot column in Pivot

What changes were proposed in this pull request?

Extend the Parser to enable parsing a column list as the pivot column.
Extend the Parser and the Pivot node to enable parsing complex expressions with aliases as the pivot value.
Add type check and constant check in Analyzer for Pivot node.

How was this patch tested?
Add tests in pivot.sql

Test build #92656 has started for PR 21720 at commit 942a30d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/710/
Test PASSed.

Test build #92656 has finished for PR 21720 at commit 942a30d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92656/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/806/
Test PASSed.

Test build #92792 has started for PR 21720 at commit d468821.

Test build #92792 has finished for PR 21720 at commit d468821.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92792/
Test FAILed.

retest please

retest this please

Test build #92823 has started for PR 21720 at commit d468821.

Test build #92823 has finished for PR 21720 at commit d468821.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92823/
Test PASSed.

ping @maryannxue Resolve the conflicts? Will review it again after that.

Test build #92993 has started for PR 21720 at commit b27245e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/943/
Test PASSed.

Test build #92993 has finished for PR 21720 at commit b27245e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92993/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1026/
Test PASSed.

Test build #93138 has started for PR 21720 at commit b27245e.

Test build #93138 has finished for PR 21720 at commit b27245e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93138/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #93152 has started for PR 21720 at commit b27245e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1038/
Test PASSed.

Test build #93152 has finished for PR 21720 at commit b27245e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93152/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1057/
Test PASSed.

Test build #93182 has started for PR 21720 at commit b27245e.

Test build #93182 has finished for PR 21720 at commit b27245e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93182/
Test PASSed.

LGTM
Thanks! Merged to master.

@gatorsmile @maryannxue Can we move forward with this PR: https://github.com/apache/spark/pull/21699 ?

@maryannxue I know this is an old PR, but it doesn't actually include SPARK-24163.  Can the Jira ticket be re-opened for SPARK-24163?


Abbreviated words

Hey,
I'm currently working on a project that needs to support pluralization of the abbreviated words, so I need to add lowercase 's' letter to the end of these words (e.g. VIP => VIPs, currently I get VIPS).
Are you planning to add this feature to your library? Something like pluralize.addAbbreviatedRule() or similar.
Regards
P.S. Thanks for the great library!

I thought there had been a previous discussion around this sort of thing, but I can't recall it now. I think it's reasonable to want to do this, but in reality I'd need to know a lot more about the context to figure out if it's something that should be here. Can you give more information? An abbreviated rule is pretty similar to an irregular rule, what would be the main difference? Is it just how to handle casing, in which case is there perhaps a better way (maybe a case-sensitivity flag?) that doesn't change the core behaviour?

Yes, In my use case only difference between an abbreviated rule and irregular rule is case handling. So something like addIrregularRule(single, plural, preserveCase) will do the trick for me.


Ayush Addhyan Added

Please Review and Add my name

Hi, did you make a branch, made changes to it, merged it with your forked main and then pulled a request?

Because I made a pull request directly from the branch I created for changes


Add Swift Documentation Preview Support

Is your feature request related to a problem? Please describe.
When user actives documentation preview panel and is currently on a .swift, .h or .markdown file, preview the documentation on the right panel.
Describe the solution you'd like
It can be achieved by using the existing ConvertService API provided by DocC.
No Xcode magic is required.

https://twitter.com/franklinschrans/status/1666343700442628098

Benefits
Improve the doc-writing experience on non-Xcode IDE.
Additional context
Inspiration: Xcode 15's documentation preview feature
See more info https://developer.apple.com/videos/play/wwdc2023/10244/

You can use the command Markdown: Open preview to the side to give a markdown preview. This won't give you the full docc preview obviously but it is a start.

You can use the command Markdown: Open preview to the side to give a markdown preview. This won't give you the full docc preview obviously but it is a start.

Yeah. VSCode has a build-in Markdown feature panel.
But I'd like to know if it was possible to render a HTML directly in a associated-panel(The same as Markdown file and Markdown-Preview panel) via the VSCode plugin SDK.

You can do it. But managing the preview server, associating the current page with the correct page on the server isn't simple. It is all possible, just complex.
I have looked into to it a bit and got it displaying a page served by preview server I was running separately. But it is far away from a finished feature.

Any updates on this issue?

No update on this. I haven't had anymore time to look into it.

@adam-fowler Can we grab this one? If so, do you have your prototype changes in a fork somewhere?

@daveyc123 its all yours. I had some basic code setup to display the documentation but there was a loads of issues managing the preview server and updating the documentation. Don't think I kept any of the code around though.

@daveyc123 I found this https://github.com/adam-fowler/vscode-swift/tree/documentation-preview

I just posted a general overview of how this feature could be implemented on the Swift forums: https://forums.swift.org/t/rfc-swift-docc-integration/75537
Please check it out and leave any feedback/suggestions that you might have!


[Screen Reader-Control Playground-Diffeditor (editor)] Screen reader does not announce tooltip information while press alt+f1 key to expand accessibility option when lands on "old content to change" editor field.[Bug]

Actual:
Screen reader not announce tooltip information while press alt+f1 key to expand accessibility option when lands on "old content to change" editor field.
Observation:
When press alt+f1 to expand tooltip information, Narrator don't announce any information (Blank).
Issue appear only with narrator
NVDA and JAWS announce dialogue information as "Line 1, Column 1 in a read-only pane of a diff editor" etc.
Expected:
If any tooltip appear on the blade it should be announce by screen reader as well.
GitHubTags:#A11yMAS;#A11yTCS;#A11ySev2;#Desktopweb;#WCAG1.3.1;#Win11;#AILimited;#FTP;#Visual Studio Code Client;#VisualStudioCode-Web-Apr2021;#a11y-monacoeditor;#Narrator;#NVDA;
Environment Details:
#URL: https://aka.ms/portalfx/playground
Chromium edge: 98.0.1100.3 (Official build) dev (64-bit)
Chrome: Version 96.0.4664.110 (Official Build) (64-bit)
Repro Steps:

Open https://aka.ms/portalfx/playground and valid credentials.
Navigate to the controls and select it.
Navigate to the "Diff Editor (Editor)" an select it.
Navigate to the playground option.
Navigate to the control and control properties appearing on the "Sample" Pane.(Diff Editor (Editor))
Navigate "Old content to change" editor field.
Press alt+f1 to expand the tooltip
Verify the issue.

User Impact:
Screen reader user who rely on screen reader will unaware about that tooltip information if while pressing alt+f1 tooltip appear but not announce any information by screen reader.
Attachment:

Please file against narator. We primarily support nvda and jaws.
Closing as we have no plans to tackle this. There are bigger problems with Narator (not very web aria compatible)


Auto Leveling

Is there a way to allow auto leveling without beeing required: Student, Apprentice, etc etc
So it just levels up with amount of casts.
Kind Regards
Jan

You can put "upgrade_required_path: beginner" on every level of every spell, but this will obviously take a lot of work.
I'm thinking of adding a feature for overriding properties of all spells, I'll keep this open til that's done, it'd make this kind of thing much easier.

I am working with a limited amount of spells, instead of letting players pick all spells.
Any chance you can give me an example for 1 spell? So I can apply this to all spells I use?
ps. love the Magic at the moment, really adds some dept to my server!

Oh, sure - so for instance Magic Missile would be like this:
missile:
    upgrade_required_path: beginner
missile|2:
    upgrade_required_path: beginner
missile|3:
    upgrade_required_path: beginner
missile|4:
    upgrade_required_path: beginner

So you have to do it for every level of the spell.
The "overrides" thing I can try to add tomorrow maybe, that would really make this task a lot easier. Are you on the latest Magic build, or is your server on 1.8?

I am owning the latest verion, my server is 1.9.2

Ok! Yeah I have been wanting to do it for a while, it'd help so many people. I'll do it ASAP and let you know.

You are awsome! Thank in advance!

Dev Build#1651 supports an "override" config, which will apply settings to every spell. So in your spells.yml, you can now just do this:
override:
  upgrade_required_path: ""

And it will turn off the required path for all spell upgrades.
http://jenkins.elmakers.com/job/MagicPlugin/1651/com.elmakers.mine.bukkit.plugins$Magic/


[firestore-bundle-server] Deployment failed

Expected Behavior
Installing via the Firebase console or CLI should deploy correctly.
The last deployment of the extension in GCP should not say "Version 1, deployment failed at ..."
Actual Behavior
Installing via CLI or UI fails. The extension installs correctly, but when I check the GCP deployment it says "failed".
The actual error message is:

Deployment failure:
Build failed: lib/index.js does not exist; Error ID: bc73f5cd

When I download the .zip with the source code, there is no lib folder, there's just src/ and test/ (same as in this Github repo).
Steps to Reproduce the Problem
Install the extension.
Specifications

Extension name: firestore-bundle-server
Version: v0.1.1

@dackers86 can you take a look at this? Jeff can deploy the fixed version

We're also using the experimental firestore-auth-claims, which works perfectly. There's also a lib folder, so I assume someone just forgot to run tsc and commit the lib folder here as well?

Yes, that is correct - so npm now allows a pre-install script called prepare, this means we no longer to commit the generated lib files as they are generated in the docker build.
Interestingly, the build logs generate this file - local installation works fine for installing and deploying the source code locally.

I published a new version today after pre-generating the lib files. Please give version 0.1.2 a shot.

Works great, thanks!


tap vs drag adjustments

Is it possible to set the touch and drag sensitivity? Operating a wall mounted tablet is different then operating it in your hand. the tablet registers drags instead of presses a lot. this results in button presses not being executed but merely the UI trying to drag the page. Its hard to keep your finger very still to press a button on a small screen on the wall. I wonder if there is a way to maybe adjust this sensitivity of drag and touch. so that it registers presses easier / more often.
Maybe im the only one having these issues and maybe it isnt even possible to adjust. But i need to press most tabs on home assistant multiple times before it actually registers a press instead of a swipe/drag.

Can you be more specific, you taking about the code screen?

Im sorry if im wasn't clear enough.
I mean in the browser or whatever is used to show home assistant in within the wallpanel app. So what i mean is pressing buttons in home assistant within wallpanel. When controlling home assistant on the tablet using wallpanel most of the presses i make are registered as drags/swipes thats because it is very hard to keep your finger still when aiming for a small button on the screen.
I just wondered if the sensitivity of the touch / drag can be adjusted so this doesnt happen.
I hope i explained it right this time. My english isn't very good with explaining these kind of things.

I would turn off the browser refresh option in the application settings, then there is no drag events captured.   If that is not on, there is nothing I can do to fix the drag events within the web page rendered.

I understand. i will look if i can adjust these setting in android itself


Add ETag support for StaticFile.fromUrl

This PR brings changes made at #6621 and #4879 solving Issue #2826 .

Thank you for the PR!
I am a bit concerned though about using java.net's URL and URLConnection as a part of public APIs.
Is it somewhat necessary, or can it be switched to http4s Uri and maybe fs2.net capabilities ?

Is it somewhat necessary

I cannot remember why at this moment, but I think for some reason it was.

or can it be switched to http4s Uri and maybe fs2.net capabilities ?

Well, yes and no 😂  in theory, absolutely yes. In practice, it would require implementing all the protocols that URLConnection supports ... such as HTTP ... and then we end up with Ember lol.

I mean, perhaps it could be ok to use it internally, when necessary... Just wondering, if it is possible to avoid exposing it in APIs.. Sorry, I haven't wrapped my head around the case yet, so perhaps I'm saying silly things. I just get triggered to java.net.URL and a lot of blocking calls inside 😊

Not at all, it's a very good question, it's a suspicious looking API. I must have been convinced at some point, when I was reviewing the previous PR, but I'm having a hard time remembering why we needed it.


Allow specifying wildcard certificates in router

I should be able to load the router with wildcard certificates (and perhaps certs with SANs) and have them automatically applied to matching HTTP routes.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


[Fix #2212] Handle methods without parentheses in auto-correct

Add to StringReplacement a condition for checking if the method has an opening parentheses, before adding the ')' in the end of the new call.

I'll fix that.


chore: update, audit

update deps, audit fix

👍 Although now wondering is as the CI time is much faster, and the lists seem a little smaller at the mo if we could get away with merging dependabots PRs directly again?

Yeah but what will I do on Monday mornings?


[COOK-3844] iptables provider for firewall/rule lwrp

https://tickets.opscode.com/browse/COOK-3844
See https://github.com/opscode-cookbooks/firewall/pull/6 for further description.
Signed CLA today, pulled to latest state and added some test and refactorings.
Enjoy

Please see the current master for iptables support.


Update .NET Core casks for 2.0.6 Runtime and 2.1.101 SDK

Updating .NET Core casks for 2.0.6 runtime and 2.1.101 SDK according to URLs published in https://github.com/dotnet/core/blob/master/release-notes/releases.json
⚠ first-time contributor to homebrew-cask, please check if guidelines have been followed correctly!
Checksums have been manually updated to the versions downloaded from the links. public confirmation is SHA512 only so I have manually compared the SHA512 checksums of the downloaded versions to the published ones - https://dotnetcli.blob.core.windows.net/dotnet/checksums/2.1.101-sdk-sha.txt, https://dotnetcli.blob.core.windows.net/dotnet/checksums/2.0.6-runtime-sha.txt
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked the cask was not already refused in closed issues.
[ ] Checked the cask is submitted to the correct repo.

In the future please submit one Cask per PR.
Thanks for the PR!


[Storage] Support create container with Encryption scope

and upgrade version to 15.0.0

/azp run


[BUG] Cannot read properties of undefined (reading 'find')

What happened?
Opened the GUI (ubuntu) to my remote (pi4) chia node, clicked on the key account and immediately it goes to this crash screen. Happens every time, 1.3.4 is also broken but goes blank rather than giving a message.
Version
1.3.5-dev88
What platform are you using?
Linux
What ui mode are you using?
GUI
Relevant log output or stacktrace
Cannot read properties of undefined (reading 'find')

URL
#/dashboard/wallets/1

Stacktrace
at webpack://@chia/wallets/dist/esm.js:3741:29 strayCats.find(function
at webpack://@chia/wallets/dist/esm.js:3798:14 _toConsumableArray(nonAddedKnownCats.map(function
at webpack://@chia/wallets/dist/esm.js:3790:46 _toConsumableArray(nonAddedKnownCats.map(function
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:168:376 $h
at webpack://@chia/gui/node_modules/react/cjs/react.production.min.js:23:112 useLayoutEffect
at webpack://@chia/wallets/dist/esm.js:3747:13 useMemo(function
at webpack://@chia/wallets/dist/esm.js:4294:39 WalletsManageTokens
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:157:136 Ch
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:180:153 oi

Fixed with https://github.com/Chia-Network/chia-blockchain-gui/pull/713

Merged


Add Support Symbol Information

Requires the following extensions:

Add a new command to the VSCode extension.
Extend the Flix compiler with support for this new command. In particular see:

https://github.com/flix/flix/tree/master/main/src/ca/uwaterloo/flix/api/lsp
https://github.com/flix/flix/blob/master/main/src/ca/uwaterloo/flix/api/lsp/LanguageServer.scala#L160
https://github.com/flix/flix/blob/master/main/src/ca/uwaterloo/flix/api/lsp/Request.scala

https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#symbolInformation

Nicola is working on this one.

Fixed in master. Now just needs Flix compiler support.


Adding env variables to the pack command

Do you have plans to add env variables to this action? Many of the buildpack features can be customized using the -e to specify a version of Java etc. Example
pack build repo/image:v1 -B gcr.io/paketo-buildpacks/builder:base -e BP_JVM_VERSION=8.*

I will add an input value so that you can specify some environment variables.

Thank you. Specifying the Java runtime version, for example, is required for many of my apps. I look forward to using it in action.

Thank you, it worked perfectly! Any interest in adding the ability to build and push the image?

Any interest in adding the ability to build and push the image?

You mean so that not only builds, but pushes can be performed within this action?
This action is a command wrapper for buildpacks, so it is only responsible for building. Pushing can be done through another action or through the docker CLI.


Add optional parameter to exclude internal classes and methods etc.

It would be good to have an optional parameter to exclude internal classes and methods from the generated documentation. Or maybe this is already possible?

There is a way to limit the documentation of certain classes by using the --ignore-attribute switch and adding an attribute to classes that should be excluded.

Ok, good to know that that option exist, it will work for me at the moment. However, I think that adding the option to exclude internal classes and methods etc, without having to add an attribute, would be a really good addition. For example, If you want some public documentation for you library. Thank you for creating this awesome tool!

Closing this for now. Not adding a new type of filtering to keep the tool simple.


storyboard accessory view is nil

...and, of course unless there is not storyboard segue, neither does accessoryButtonTappedForRowWithIndexPath get called.
workaround: remove storyboard segues for accessory views (Detail Disclosure in my case) and add programmatic support in cellForRowAtIndexPath
// SWTableViewCellStuff setting accessoryView to nil?
if (cell.accessoryView == nil)
{
cell.accessoryType = UITableViewCellAccessoryDetailDisclosureButton;
cell.accessoryView = [UIButton buttonWithType:UIButtonTypeDetailDisclosure];
    // set the action or delegate
    //cell.accessoryAction =
    [(UIButton *)cell.accessoryView addTarget:self action:@selector(accessoryButtonTapped:) forControlEvents:UIControlEventTouchUpInside];
}

I'm seeing the same problem. I don't really want to rip out the storyboard segue and reimplement all of that plumbing.
It seems like the accessoryView should be fine as nil since that is required for the accessoryButtonTappedForRowWithIndexPath to be called.
SWTableViewCell is setting the accessory frame, but I don't see where it is interfering with the accessory button tap.


No refetch after changing query parameters

I'm currently integrating solr into a nuxt-typo3 project and i'm facing
the following problem:
async submit() {
  await navigateTo({
     query: {
      'tx_solr[q]': this.searchTerm
    },
    replace: true
  })
},

When i trigger the submit function, the url in the address bar changes but
the data from TYPO3 is not refetched. Only when i hit the browser reload button
the data will be loaded.
To get it running I'm temporary using reloadNuxtApp() instead of navigateTo()
reloadNuxtApp({
  path: '?tx_solr[q]='+this.searchTerm
 });

Hi @dkd-lehnebach, you can add a watcher for the route query at the page level to refresh pageData.
<template>
  <T3BackendLayout
    v-if="pageData?.content"
    :name="backendLayout"
    :content="pageData.content"
  />
</template>

<script setup lang="ts">
const { headData, pageData, backendLayout, getPageData } = await useT3Page()
useHead(headData)
const route = useRoute()

watch(() => route.query, async () => {
  await getPageData(route.fullPath)
})

</script>

To achieve this, you need to override our dynamic page. Refer to the documentation here: -> https://t3headless.macopedia.io/nuxt-typo3/guide/override-page#step-1-create-a-new-slugvue-file
We will see what we can do to handle it at the library level


high memory used

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
kong:2.0.2-centos
Current Behavior
high memory userd
Expected Behavior
high memory userd
Steps To Reproduce
pod of kong high memory used, how to decrease memory

Anything else?

Hi @bruse-peng
Thanks for the report. In order to help you, we may need additional information such as

Deployment mode (hybrid, traditional, db-less)
How many kong nodes are you running?
How does your request pattern look like? (RPS in particular)

Also, I'm seeing that you have RAM to spare. Could you elaborate why the memory usage you're seeing is problematic in this case and maybe what you're expecting in this case?
TIA


change distance to take references

distance (and distance2) function of the MetricSpace trait take types as parameters and consume them. This requires the types to implement Copy to work, or to clone them explicitely. Copying for just calculating the distance is an unneccessary overhead, especially when using custom types, which don't implement Copy

The problem set that this crate is dealing with only covers cg-related vector types, which are all kinda small, (Vector4<f64> being the biggest, yet even that consumes only 256 bits). It is quite reasonable to consider these vectors to be small enough such that they should all implement Copy and being passed around by values whenever possible.
Under these presumptions, I don't think we should change the current design mentioned here. Unless being proven otherwise ( by a dedicated benchmark or something), I'd assume that passing values around would be more register-friendly and result in more efficient operations.

Yeah - this is a kind of hard thing with designing traits for Rust - sometimes it is better to copy a small data structure, so it is hard to be generic :(


Generate proper API description for Map types using "additionalProperties"

This PR changes the way Cloud Endpoints handles Map types when generating API specs:

Previously, maps were always described as JsonMap, making the API Explorer buggy, and the Java clients barely usable.
The new behavior is to use "additionalProperties" in the JsonSchema, that work really well for String-keyed maps, and generate correctly typed Java clients.
A flag system based both on env variables and system properties (see MapSchemaFlag) can be used to fine tune the new behavior.

This introduces backward incompatible changes to the generated Java clients, and the stricter validation of acceptable Map types can make some APIs fail to generate the spec.
Legacy behavior can be reintroduced for both of these using flags in MapSchemaFlag (see FORCE_JSON_MAP_SCHEMA and IGNORE_UNSUPPORTED_KEY_TYPES).
A note about Map types with array-like values:

This use case is properly supported by both the Discovery and Swagger formats, and works fine in the API explorer.
However, it is not supported by the cloud-based client library generator (which is presumably base on this project), it will generate invalid Java code.
So the default behavior is to keep using JsonMap schema for the array-valued maps, but it can be forced to use additionalProperties with the MapSchemaFlag.SUPPORT_ARRAYS_VALUES flag.

I previously opened an issue about this: https://github.com/cloudendpoints/endpoints-java/issues/142

Codecov Report

Merging #155 into master will increase coverage by 0.07%.
The diff coverage is 92%.

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     80.04%   80.11%   +0.07%
- Complexity     1682     1697      +15
============================================
  Files           156      157       +1
  Lines          5597     5642      +45
  Branches        731      742      +11
============================================
+ Hits           4480     4520      +40
- Misses          838      839       +1
- Partials        279      283       +4

Impacted Files
Coverage Δ
Complexity Δ

...com/google/api/server/spi/config/model/Schema.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...e/api/server/spi/discovery/DiscoveryGenerator.java
88.49% <100%> (+0.1%)
63 <0> (+1)
:arrow_up:

...oogle/api/server/spi/swagger/SwaggerGenerator.java
77.91% <100%> (+0.26%)
59 <0> (+2)
:arrow_up:

...gle/api/server/spi/config/model/MapSchemaFlag.java
90.9% <90.9%> (ø)
4 <4> (?)

.../api/server/spi/config/model/SchemaRepository.java
91.6% <90.9%> (-0.56%)
37 <8> (+9)

.../server/spi/discovery/CommonPathPrefixBuilder.java
94.44% <0%> (-5.56%)
8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c842566...414b23d. Read the comment docs.

Looks like there is a conflict now (may have merged out of order)

I rebased from latest master (conflict was only in imports).

I fixed formatting and copyright issues.


Subscriptions not found when having AAD B2C setup

Describe the bug
When running:
az login
It gives the warning

"The following tenants don't contain accessible subscriptions. Use 'az login --allow-no-subscriptions' to have tenant level access. 15ce3ddb-0ba0-4110-92f6-6f3da6910357"

It does not actually login.
In order for it to work I need to provide my tenant:
az login -t egelke.net
To Reproduce
Setup an AAD B2C as specified by the doc: https://docs.microsoft.com/en-us/azure/active-directory-b2c/tutorial-create-tenant
Note that is did it quite a while ago and at that time it was mandatory to first create your tenant and then link it to your existing subscription.
Set the default directory in the azure portal to the corporate (not B2C) directory.
Run:
az login
You should get the warning and not be logged in.
Note that it might work in your case depending on the order the tenants are returned by the the https://management.azure.com/tenants?api-version=2020-01-01 service.
Expected behavior
To find my subscription, without having to specify the tenant.
It is a very standard setup, I just have the ADD B2C service enabled in the documented way.  There should be no issue for the CLI to handle this situation without the need provide any additional info.
Environment summary
Linux-5.4.0-40-generic-x86_64-with-debian-bullseye-sid
Python 3.6.10
Installer: DEB
{
"azure-cli": "2.8.0",
"azure-cli-command-modules-nspkg": "2.0.3",
"azure-cli-core": "2.8.0",
"azure-cli-nspkg": "3.0.4",
"azure-cli-telemetry": "1.0.4",
"extensions": {}
}
Additional context
az login --debug learned that it first retrieves the list of tenant and then retrieves the subscriptions from both tenants.  The first egelke.net tanant returns my subscription, but although the AAD B2C tenant (egelkeIdp.onmicrosoft.com) is linked to the same subscription the service does not return it. (I verified everyting via https://docs.microsoft.com/en-us/rest/api/resources/)
In this particular case the CLI seems to have "forgotten" the subscriptions returned by the first tenant while it should have merged the 2 lists and find the sole subscription.
Below a snipped of the logs:

urllib3.connectionpool : Starting new HTTPS connection (1): management.azure.com:443
urllib3.connectionpool : https://management.azure.com:443 "GET /tenants?api-version=2019-06-01 HTTP/1.1" 200 348
msrest.http_logger : Response status: 200
msrest.http_logger : Response headers:
msrest.http_logger :     'Cache-Control': 'no-cache'
msrest.http_logger :     'Pragma': 'no-cache'
msrest.http_logger :     'Content-Type': 'application/json; charset=utf-8'
--snip--
msrest.http_logger :     'Date': 'Thu, 16 Jul 2020 06:41:04 GMT'
msrest.http_logger :     'Content-Length': '348'
msrest.http_logger : Response content:
msrest.http_logger : {"value":[{"id":"/tenants/7aed0c3e-dc7c-4ac0-8e6b-c8cb344472fa","tenantId":"7aed0c3e-dc7c-4ac0-8e6b-c8cb344472fa","countryCode":"BE","displayName":"Egelke BVBA","domains":["egelke.net","share.egelke.net","www.egelke.net","egelke.onmicrosoft.com"],"tenantCategory":"Home"},{"id":"/tenants/15ce3ddb-0ba0-4110-92f6-6f3da6910357","tenantId":"15ce3ddb-0ba0-4110-92f6-6f3da6910357","countryCode":"BE","displayName":"Egelke BVBA","domains":["egelkeIdp.onmicrosoft.com"],"tenantCategory":"Home"}]}
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - Authority:Performing instance discovery: ...
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - Authority:Performing static instance discovery
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - Authority:Authority validated via static instance discovery
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - TokenRequest:Getting token from cache with refresh if necessary.
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - CacheDriver:finding with query keys: {'_clientId': '...', 'userId': '...'}
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - CacheDriver:Looking for potential cache entries: {'_clientId': '...', 'userId': '...'}
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - CacheDriver:Found 3 potential entries.
adal-python : 009b4e6a-42c1-4525-98e8-72a9ba9be42f - CacheDriver:Resource specific token found.
--snip--
msrest.universal_http.requests : Configuring retry: max_retries=4, backoff_factor=0.8, max_backoff=90
msrest.async_paging : Paging async iterator protocol is not available for SubscriptionPaged
msrest.http_logger : Request URL: 'https://management.azure.com/subscriptions?api-version=2019-06-01'
msrest.http_logger : Request method: 'GET'
msrest.http_logger : Request headers:
msrest.http_logger :     'Accept': 'application/json'
msrest.http_logger :     'accept-language': 'en-US'
msrest.http_logger :     'User-Agent': 'python/3.6.10 (Linux-5.4.0-40-generic-x86_64-with-debian-bullseye-sid) msrest/0.6.9 msrest_azure/0.6.3 azure-mgmt-resource/10.0.0 Azure-SDK-For-Python AZURECLI/2.8.0 (DEB)'
msrest.http_logger : Request body:
msrest.http_logger : None
msrest.universal_http : Configuring redirects: allow=True, max=30
msrest.universal_http : Configuring request: timeout=100, verify=True, cert=None
msrest.universal_http : Configuring proxies: ''
msrest.universal_http : Evaluate proxies against ENV settings: True
urllib3.connectionpool : Starting new HTTPS connection (1): management.azure.com:443
urllib3.connectionpool : https://management.azure.com:443 "GET /subscriptions?api-version=2019-06-01 HTTP/1.1" 200 431
msrest.http_logger : Response status: 200
msrest.http_logger : Response headers:
msrest.http_logger :     'Cache-Control': 'no-cache'
msrest.http_logger :     'Pragma': 'no-cache'
msrest.http_logger :     'Content-Type': 'application/json; charset=utf-8'
--snip--
msrest.http_logger :     'Date': 'Thu, 16 Jul 2020 06:41:05 GMT'
msrest.http_logger :     'Content-Length': '431'
msrest.http_logger : Response content:
msrest.http_logger : {"value":[{"id":"/subscriptions/09aa7e5c-38b1-4cad-b283-e2aa6c411d25","authorizationSource":"Legacy, RoleBased","managedByTenants":[],"subscriptionId":"09aa7e5c-38b1-4cad-b283-e2aa6c411d25","tenantId":"7aed0c3e-dc7c-4ac0-8e6b-c8cb344472fa","displayName":"Betalen per gebruik","state":"Enabled","subscriptionPolicies":{"locationPlacementId":"Public_2014-09-01","quotaId":"PayAsYouGo_2014-09-01","spendingLimit":"Off"}}],"count":{"type":"Total","value":1}}
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - Authority:Performing instance discovery: ...
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - Authority:Performing static instance discovery
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - Authority:Authority validated via static instance discovery
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - TokenRequest:Getting token from cache with refresh if necessary.
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - CacheDriver:finding with query keys: {'_clientId': '...', 'userId': '...'}
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - CacheDriver:Looking for potential cache entries: {'_clientId': '...', 'userId': '...'}
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - CacheDriver:Found 3 potential entries.
adal-python : 2ade8d89-485d-4d7b-9c56-ac8ea1b5ed13 - CacheDriver:Resource specific token found.
--snip--
msrest.universal_http.requests : Configuring retry: max_retries=4, backoff_factor=0.8, max_backoff=90
msrest.async_paging : Paging async iterator protocol is not available for SubscriptionPaged
msrest.http_logger : Request URL: 'https://management.azure.com/subscriptions?api-version=2019-06-01'
msrest.http_logger : Request method: 'GET'
msrest.http_logger : Request headers:
msrest.http_logger :     'Accept': 'application/json'
msrest.http_logger :     'accept-language': 'en-US'
msrest.http_logger :     'User-Agent': 'python/3.6.10 (Linux-5.4.0-40-generic-x86_64-with-debian-bullseye-sid) msrest/0.6.9 msrest_azure/0.6.3 azure-mgmt-resource/10.0.0 Azure-SDK-For-Python AZURECLI/2.8.0 (DEB)'
msrest.http_logger : Request body:
msrest.http_logger : None
msrest.universal_http : Configuring redirects: allow=True, max=30
msrest.universal_http : Configuring request: timeout=100, verify=True, cert=None
msrest.universal_http : Configuring proxies: ''
msrest.universal_http : Evaluate proxies against ENV settings: True
urllib3.connectionpool : Starting new HTTPS connection (1): management.azure.com:443
urllib3.connectionpool : https://management.azure.com:443 "GET /subscriptions?api-version=2019-06-01 HTTP/1.1" 200 161
msrest.http_logger : Response status: 200
msrest.http_logger : Response headers:
msrest.http_logger :     'Cache-Control': 'no-cache'
msrest.http_logger :     'Pragma': 'no-cache'
msrest.http_logger :     'Content-Type': 'application/json; charset=utf-8'
--snip--
msrest.http_logger :     'Date': 'Thu, 16 Jul 2020 06:41:05 GMT'
msrest.http_logger :     'Content-Length': '161'
msrest.http_logger : Response content:
msrest.http_logger : {"value":[],"count":{"type":"Total","value":0}}
The following tenants don't contain accessible subscriptions. Use 'az login --allow-no-subscriptions' to have tenant level access.
15ce3ddb-0ba0-4110-92f6-6f3da6910357

add to S174

I have no idea what is wrong with my Azure account, but I had a similar issue where I needed to specify my tenant... but I didn't know what my tenant was... to find it, I looked at a subscription I wanted to use from the CLI and and noted the Default Directory. Let's say my account email was<EMAIL_ADDRESS>then my Directory was<EMAIL_ADDRESS>Then, using this cli login worked:
az login -t<EMAIL_ADDRESS>


fix new HTTP API stage handling

closes #44
FYI, API Gateway is tricky because you can have stage, api prefix (/api/{proxy+}), path mapping (with custom ulr), that's why there are a lot of If/else in the code.
I think the lib should work now and return the correct host. The documentation on the event dict is not great. I tried to look at the context content but this will be maybe for version 7 ;-)
cc @kylebarron

Thanks!


developing app for Tizen / Webo

Hi, we've developed our app mainly for android devices and would like to now start building it for Samsung/LG. Just wanted to ask if we need to redo everything from scratch to convert all screens to pages or is there any way to do it automatically ?

Depends what engine you would like to use, Create does support rn-web engine where essentially you don't need to convert anything. You can try our template https://github.com/flexn-io/create/tree/main/packages/template-starter by running npx rnv run -p tizen --hosted or npx rnv run -p webos --hosted it will run it in web interface but you will see that same code is running under these platforms also.
Also there is an option to run Lightning.JS engine, but for that you will need to develop your app in Lightning.JS syntax, since there is no transpilation from RN

@aurimasmi could you please advice a version of Node, RNV, Template, that can successfully build/export tizen app ?

@saimirg
│  ReNative Version: 0.37.4                                                    │
│  Project Name ($package.name): tizen                                         │
│  Project Version ($package.version): 0.1.0                                   │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): tizen                                                        │
│  Engine ($.platforms.tizen.engine): engine-rn-web                            │
│  Template<EMAIL_ADDRESS>                            │
│  App Config (-c): app                                                        │
│  Build Scheme (-s): debug                                                    │
│  Target (-t): T-samsung-7.0-x86                                              │
│  Supported Platforms: tizen                                                  │
│  Env Info: darwin | x64 | node v16.14.2                                      │
│  Executed Time: 0h:0m:19s:683ms

I'm running the build command for tizen and webos, and it is only generating static files for webos. It is also generating WGT file for Tizen, but it does not have any static JS files inside.
Here is the build results for TIZEN

output

And these are the results for same command for Webos

output

I have the same problem.
if I run
npx rnv build -p tizen
it will produce a debug wgt, with an index.html with href to my local webserver. I expected to find static js inside wgt in order to publish my wgt to samsung store.
Same thing with webos
same thing with
npx rnv build -p tizen -s production
ReNative Version: 0.37.4
node v16.14.2

@saimirg this is a valid issue, and is already partially fixed, but no release yet made, will inform you once release has been made

@saimirg @fisarmio renative has this issue solved already on 1.0.0-rc.12, however create hasn't been yet updated with latest renative


named matchers to adding routes

This change adds paramaters to adding routes to check for common use cases.  Specifically you can add routes that check for integers, ascii, and uuids.
route_set = Amber::Router::RouteSet(Symbol).new
route_set.add "/get/pages/:page_num", :page_num, {:page_num => :integer}
route_set.add "/get/page_name/:page_name", :page_name, {:page_name => :ascii}
route_set.add "/get/page_uuid/:page_id", :page_id, {:page_id => :uuid}

I have checked the perfomance of these matchers and all are more performant then their regex counterparts, some are way faster.  But this change is intended to make the patterns more decalritive and understandable.
Integer
require "benchmark"
Benchmark.ips do |x|
  x.report("integer regex") do
    /\d+/ =~ "123"
  end

  x.report("integer matcher") do
    "123".each_byte do |byte|
      next unless 48 <= byte <= 57
    end
  end
end

$ crystal int_match.cr --release
  integer regex  10.11M ( 98.93ns) (± 2.06%)  16 B/op  54.88× slower
integer matcher 554.78M (   1.8ns) (± 4.40%)   0 B/op        fastest

Ascii
require "benchmark"
Benchmark.ips do |x|
  x.report("ascii regex") do
    /[^\w]+/ =~ "foo123"
  end

  x.report("ascii matcher") do
    "foo123".ascii_only?
  end
end

$ crystal ascii_match.cr --release
  ascii regex  15.64M ( 63.94ns) (± 2.33%)  16 B/op  30.29× slower
ascii matcher 473.69M (  2.11ns) (± 3.61%)   0 B/op        fastest

UUID
require "benchmark"
Benchmark.ips do |x|
  x.report("uuid regex") do
    /[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}/ =~ "87b3042b-9b9a-41b7-8b15-a93d3f17025e"
  end

  x.report("uuid matcher") do
    segment = "87b3042b-9b9a-41b7-8b15-a93d3f17025e"
    next if segment.bytesize != 36
    {8, 13, 18, 23}.each { |offset| next if segment[offset] != '-' }
    {0, 2, 4, 6, 9, 11, 14, 16, 19, 21, 24, 26, 28, 30, 32, 34}.each do |offset|
      next unless (ch1 = segment[offset].to_u8?(16)) && (ch2 = segment[offset + 1].to_u8?(16))
    end
  end
end

$ crystal uuid_match.cr --release
  uuid regex   3.75M (266.68ns) (±24.79%)  16 B/op   1.69× slower
uuid matcher   6.34M (157.84ns) (±21.00%)   0 B/op        fastest

I was thinking of an enum, makes it easy to document/expand upon in future if we add more of these.  It would be nice if you could have a method type restricted to a specific enum member, then could have one method just overloaded for each type.
Maybe something like:
enum Param
  Integer
  Ascii
  Uuid
end
...
def initialize(segment, @pattern : (Regex | Param)? = nil)
  super segment
end

def match?(segment : String) : Bool
  case @pattern
  when Regex then !(segment =~ @pattern).nil?
  when .integer? then match_integer?(segment)
  when uuid? then match_uuid?(segment)
  when ascii? then segment.ascii_only?
  else
    true
  end
end

@Blacksmoke16 I like the idea of an enum or more restrictive interface to take advantage of static typing.  However, the interface is more clunky.  This is is a matter of Ambers pervious routing interfaces and how this fits in.  But I really like the idea and would be interested in working on it if it fits into the theme of amber.

Fair enough.  You can parse an enum member from a string, so it would be doable to have the interface an Enum under the hood, but have the user do like {:page_num => "integer"}.
Either way this provides a nice speed boost, so i'm good with it for now.

Any update on this @robacarp @drujensen @amberframework/contributors ?

I can do more work on this but I wanted to check in and see if the repo maintainers still want this.
@robacarp @drujensen @amberframework/contributors

@wontruefree I think this is a valuable addition.
Looking over this again, I can see that it has the possibility to impact the match speed significantly. I'd like to see the constraint matching moved to as late in the RouteSet selection as possible. Implementing the filters this early on in the process means that any url which hits the routeset will have to pass the extra matches, even if they would later be stripped out by simpler means.
For example, with this route set:
route_set.add "/get/pages/:page_num/reverse", :payload, {:page_num => :integer}
route_set.add "/get/pages/:page_num/forward", :payload, {:page_num => :integer}

These urls won't match either route, but will run the integer comparison code once for each route:

/get/pages/steve
/get/pages/3/upside_down

@wontruefree @robacarp what is the status of this PR?

@drujensen  I have not thought about this PR is a long time.  I don't understand the last comment from @robacarp and the link is dead.  I don't mind finishing I think it is a good project but I don't really know what is holding it up.


Deprecated link for pretrained models

When I tried to download the pretrained models, such an error occurred:
wget: unable to resolve host address ‘penzhanwu2bbs.blob.core.windows.net’
It seems like the download link is deprecated. Could you perhaps renew the link? Or can anyone else successfully download the pretrained models from the given links? Thank you so much!

Hello, thanks for your interesting to our work. You can just visit the official GLIP github repo  https://github.com/microsoft/GLIP to download the pre-trained GLIP models and prepare environments. We just added the gradio interface for GLIP at https://github.com/VIRL-Platform/GLIP/blob/main/glip_app.py.

Thank you! Sorry to bother you again, I'm facing this issue:
when I run rx399_ny, the glip server side always raises 'Not compiled with
GPU support', but I am pretty sure that cuda is available. Is it related to
the major 'WITH_CUDA'? Can you give me some possible solution? Thank you so
much and sorry again for bothering you so much!
Jihan Yang @.***> 于2024年7月2日周二 10:21写道：

Hello, thanks for your interesting to our work. You can just visit the
official GLIP github repo https://github.com/microsoft/GLIP to download
the pre-trained GLIP models and prepare environments. We just added the
gradio interface for GLIP at
https://github.com/VIRL-Platform/GLIP/blob/main/glip_app.py.
—
Reply to this email directly, view it on GitHub
https://github.com/VIRL-Platform/GLIP/issues/1#issuecomment-2201693232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHBKLK2DZZLX3ZKGRLTB36DZKIFDTAVCNFSM6AAAAABKGAJO32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBRGY4TGMRTGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

when you launch the glip server, it will provide an HTTP address with a port. Can you first try it on the webpage to make sure it can work? Also, you can try their official colab demo locally to make sure your environment is feasible: https://colab.research.google.com/drive/12x7v-_miN7-SRiziK3Cx4ffJzstBJNqb?usp=sharing


chore: remove webpack as devDeps

Build
Remove webpack as devDeps (#171)
CI
Drop testing against Ember.js LTS v3.20 (#171)
Add testing against Ember.js LTS v3.28 (#171)

Plip plop

Ping @GreatWizard


HSEARCH-2343 Possible resource leak in IndexControl MBean

https://hibernate.atlassian.net/browse/HSEARCH-2343

@Sanne Only got one comment : https://github.com/hibernate/hibernate-search/pull/1156#discussion-diff-78393899 . The other one may go a bit too far.
If you agree with my first comment, I'll do the change and merge.

Closing and following up on #1157
I will merge once the build is okay. Thanks, @Sanne!


Flesh Reading Ease variants for other languages

PR for #94
Added Flesch Reading Ease versions for:

German (Toni Amstad)
Spanish (Fernandez Huerta Readability Formula)
Italian (Flesch-Vacca)
French (based on Yoast/YoastSEO.js#267)
Russian (https://ru.wikipedia.org/wiki/Индекс_удобочитаемости)
Dutch (Flesch-Douma)

Set whole .idea folder in .gitignore.

@lmaczulajtys thank you for this 🎉
sorry for the delay getting this merged.


Make CodeGenerator and Context overridable

It's probably not needed very often, but subclassing e.g. the Environment to use a custom class for it would be so much cleaner than having to monkey-patch or fork.

I'm really confused by your commit referencing the PR itself but the diff checks out.

Initially I was going to open a separate PR, then I remembered that the hub util can convert an existing issue in a PR.

I see, I thought that functionality has been removed from Github.

It's deprecated (not sure why, seems to be useful) according to the output of the command:

Warning: Issue to pull request conversion is deprecated and might not work in the future.

Thanks, merged!

Regarding that hub feature: https://github.com/github/hub/commit/4f70dd126f46dec14fc341c97c18efae417743c7


Update dev_install.md

We should update the dev_install instructions, and might as well merge into the README.md

As of today the dev_install.md are actually fairly accurate (just went through them).
Also it doesn't hurt to have a separate file, as it's mostly non relevant information for most people arriving at the repo. Maybe adding a Contributing section with a link dev_install.md could be enough?

Closing as resolved.


Support additional config

I am using yaml to configure size and scaling rules for my conatiner apps right now.
It would be great if this action could also support some advanced config to make the switch easier.

@heddendorp Hey Lukas -- apologies for the delayed response; just to make sure I'm on the same page as you, when you say that you're using a YAML file to configure certain configurations of your Container App, is this YAML file being provided to an az containerapp command within the Azure CLI, or is there a separate flow you're using this YAML file in? Thanks!

@heddendorp Hey Lukas, with the latest v0 release, you can now use the yamlConfigPath argument to provide a YAML configuration file that specifies that properties of the Container App to create or update.
Please feel free to let me know if this doesn't work for, or if there are any additional comments or questions you have. Thanks!


[WIP] Minor release 10.7.0 tracking PR

Primer Minor Release
Tracking Issue for next minor release: 📦 10.7.0
Approximate release date: 📆
Must

[x] change double quotes to single quotes in Avatar stack stories https://github.com/primer/primer/pull/511
[x] Patch release 10.6.1 https://github.com/primer/primer/pull/510
[x] Deleting color-systems docs https://github.com/primer/primer/pull/507
[x] Deleting the dev branch workflow instructions https://github.com/primer/primer/pull/513

Should

[x] Auto publish storybook site https://github.com/primer/primer/pull/515
[ ] Automate the changelog
[ ] Update ship checklist template

Could

[ ] Add more utilities for coloring primer-react labels to make outline/no-outline versions match colors
[ ] Gain more markdown as source of truth examples storybook coverage
[x] Split publish status into multiple statuses https://github.com/primer/primer/pull/517

Ship checklist

[ ] Update CHANGELOG
[ ] Run version bump
[ ] Update primer.github.io
[ ] Update github/github
[ ] Update the style guide
[ ] Update the release tag note

/cc @primer/ds-core

For the changelog automating I need to discuss logic. Ideally I'd like the automation to 1) update CHANGELOG.md 2) create a draft github release
I got worried about timing, and if I commit to the branch from travis, then would that kick off another travis build? maybe the second one wont do anything because the commit diff will not be different. Thoughts we can discuss further.


<IP_ADDRESS> Grid is not resizeing for child records

When nesting a entity under another in the grid the space the nested data gets is not larger than the number of columns of the parent.
see attached image

CRM 2013 , Internet Explorer, Edge And Chrome all shows same behaviour

Hi,
This was a tricky issue. I have come up with a solution. However, I need more time to tweak and test it in all browsers (specially IE) to ensure I don't end up breaking something else. I hope to have this done by next week.
Thank you,
Mehrdad

Sounds great that i can be fixed :-) looking forward to the next release
you're doing great work thank you.

Sorry about that, I accidentally closed this issue. Re opened.

Okay :-)  , I was just checking if I should test the functionality in <IP_ADDRESS>. I'm looking forward to the fix
Thankyou

Hello,
Any idea when this bug will be fixed ?
thank you

Hi,
Hoping to wrap up the next release by the end of this weekend.
Thank you,
Mehrdad

Thank you for the quick response :-)
looking forward to the next release

Hi,
I have bad news, during my tests, I ran into an issue with IE 11 and was not able to make IE cooperate. I will keep this issue open. Hopefully, I will come across a fix for IE soon.
Thank you and sorry about this.
Mehrdad

What about the other browsers Will it Work there

Yes, It should work in other browsers (Chrome, FF, Opera).

I just tested <IP_ADDRESS> In Chrome , the resizing is not working there either, I have tried finding a solution, if i Change the width of the Parent  to 100% and remove the max width property its working as expected, I don't know if you can use that for something :-) , I have attached the changes as images to this comment.

I tested it in all browser and the outcome was the same, I know that it's not that easy because you have a lot of other parameters to think on, what if there is more than one header will the % then work and so on :-) but I hope you can use the info to find a solution :-)
thank you

Is there any news on this issue?
thank you


Use non-linear mapping for ReflectionProbe mip levels to match sky

Fixes: https://github.com/godotengine/godot/issues/85299
This is the same change from https://github.com/godotengine/godot/pull/69514 and it should have been applied to ReflectionProbes at that time.
This change isn't needed for the compatibility renderer because it uses a linear mapping of perceptual roughness to mipmap levels
Scene from the MRP (with roughness layers disabled for sky so the quality matches exactly)
Sky reflection

Probe reflection

Thanks!


Finish TLS implementation

TLS implementation started, but needs to be completed.
Additionally, Encryption should be the only method of communication. The non TLS network code should be removed.
If the Client or Server do not have certificates, self-signed certs should be generated progmatically and used.

Completed https://github.com/smasherprog/Remote_Access_Library/commit/15f3d12ed3bb352f6e8d0913553df0d1d45e1d3f


Add transitionstart event

https://developer.mozilla.org/en-US/docs/Web/Events/transitionstart#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/Events/transitionend#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent#Browser_compatibility
According to MDN, transitionend is more widely support than any of the other events.

transitionend is already covered at http://caniuse.com/#feat=css-transitions as it was part of the original transitions specification. transitionstart is a new event.

+1

Looks like this is now covered by MDN data:
https://caniuse.com/mdn-api_htmlelement_transitionstart_event
(via mdn/browser-compat-data#3563)


Fixed issue when paginator orders by a subselect expression

On platforms that support the ROW_NUMBER() OVER() function, we've found issues when ordering by a subselect expression. Have included a test demonstrating the problem that was failing with a syntax error under Postgres:
Caused by
PDOException: SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near "SELECT"
LINE 1: ...d = c0_.id) AS sclr_4, ROW_NUMBER() OVER(ORDER BY SELECT MAX...

I think the coverage drop is down to the change not running under SQLite. Running the tests under postgres, this change is definitely covered.

@ehimen that's alright, we should rather merge the coverage in future. Thanks!

Thanks @Ocramius! I've updated with some changes. Are these what you had in mind?


[WFCORE-2966] WildFly Elytron tool script has to pass the command name from the script to the tool.

wildfly-core: https://issues.jboss.org/browse/WFCORE-2966
JBEAP: https://issues.jboss.org/browse/JBEAP-11591

Retest this please


feat(docs): show enum values

Simple feature to show the enum values of proptypes in a popup

Current coverage is 100% (diff: 100%)

Merging #906 into master will not change coverage

@@           master   #906   diff @@
====================================
  Files         137    137
  Lines        2259   2259
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits         2259   2259
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 28c7122...6a0821a

This PR / doc approach will be outdated once #731 is merged since we will then inline all enums.  Component._meta.props will no longer contain prop enums.
However, this is a great stopgap for now.  Can we change the icon to something like:
{enum} (hover to view)

I updated it removing the icon in favor of the original text, also fixed an issue where polymorphic types weren't showing the tooltip.
Fresh screenshot:

I wanted to show all enums when there were only a few options, which spiraled into some a number of other fixes and updates.  I added an enums display that will be in line with the function signature display once we update docs for those.  They are shown in the description area:

Show all toggle (closed)

Show all toggle (open)


Binary Keys: incorrect node selection

In file https://github.com/Netflix/dyno/blob/master/dyno-jedis/src/main/java/com/netflix/dyno/jedis/DynoJedisClient.java
you have the following constructor:
private BaseKeyOperation(final byte[] k, final OpName o) {
        	this.key = null;
        	this.binaryKey = null;
        	this.op = o;
}

which simply discards "k".
then in the Token Aware LB part (file https://github.com/Netflix/dyno/blob/master/dyno-core/src/main/java/com/netflix/dyno/connectionpool/impl/lb/TokenAwareSelection.java)
only the String keys are used to select a node:
@Override
	public HostConnectionPool<CL> getPoolForOperation(BaseOperation<CL, ?> op) throws NoAvailableHostsException {

		String key = op.getKey();
		HostToken hToken = this.getTokenForKey(key);

		HostConnectionPool<CL> hostPool = null;
		if (hToken != null) {
			hostPool = tokenPools.get(hToken.getToken());
		}

		if (hostPool == null) {
			throw new NoAvailableHostsException("Could not find host connection pool for key: " + key + ", hash: " +
                    tokenMapper.hash(key));
		}

		return hostPool;
}

so it'll always return the first node when using binary keys which is kind of bad for performance.

For the first, you are correct. I will fix that. However, I am not following the second comment. The Token is derived from the key. What is the problem with that?

I'll rephrase the second comment:
fixing the BaseKeyOperation constructor by assigning "k" to "this.binaryKey" won't be enough to make binary keys work in Dyno.
TokenAwareSelection only uses BaseKeyOperation.getKey() and ignores the getBinaryKey() method.

@AndrewBourgeois sorry for delay on this.. Have been swamped with Dynomite and Dynomite-manager changes. Once complete, I will get to this.

@ipapapa  I am facing same issue and this might potentially cause
https://github.com/Netflix/dynomite/issues/416
too. The DynoJedisClient.java is not honoring binary key so the routing is not happening as it should be.
One small thing that @AndrewBourgeois  missed in his earlier comment was that
com.netflix.dyno.connectionpool.impl.lb.TokenAwareSelection#getPoolForOperation uses BaseOperation which doesnt have getBinaryKey. instead it should use BaseKeyOperation if we are actually using BaseKeyOperation.binaryKey. If we are going to still use the string value of byte[] as key then there is no need to change TokenAwareSelection and just set this.key as string value in BaseKeyOperation constructor.

@shailesh33  and @ipapapa  I just confirmed by modifying the dyno code at local base to change
private BaseKeyOperation(final byte[] k, final OpName o) {         	this.key = null;         	this.binaryKey = null;         	this.op = o;         }
to
private BaseKeyOperation(final byte[] k, final OpName o) {         	this.key = new String(k);         	this.binaryKey = k;         	this.op = o;         }
and this resolved the issue that is raised for https://github.com/Netflix/dynomite/issues/416
However I think dynomite might have to handle the case as well with the invalid routing.
The change is a hack to consider the binary key as its string value so the routing works as it is. This might now be the proper fix. This is one of a blocking issue for us. Can you please fix this for us and publish the new version to maven repository? Please.

@ipapapa  any update on this issue?

Hey, sorry no update on this. I was swamped with some prod issues past few
days. I will try to get to this by end of the week
On Thu, Feb 2, 2017 at 12:12 PM, Balaji Venkatesan<EMAIL_ADDRESS>
wrote:

@ipapapa https://github.com/ipapapa any update on this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/dyno/issues/156#issuecomment-277069581, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALle5-MozRXpw5K8A8ywXOOd_lLlE3aFks5rYjjDgaJpZM4LED0E
.

@balajivenki I have a couple of questions.

Are you  getting a NoAvailableHostsException from Dyno prior to setting byte[] key as String?
If an exception is not thrown from the Dyno client, why do you think we need to fix this in Dynomite? Dynomite should do the hashing of whatever it gets from the wire. Then Dynomite would do the hashing and re-routing properly. Isn't that the case?

Looking down in the implementation of the HashPartitioner we actually convert the String to a byte array. So it may be feasible to directly give the byte[].

@ipapapa When we give byte[] the routing is not happening and it always goes to node1 in the local rack. Atlease that is what we get when we parse the response hostname from the response. This have caused some glitches in dynomite, but I do not experience that right now. This issue is purely on dyno client as the BaseKeyOperation constructor for binary key doesnt set the key and binarykey. So getKey() call gets as null and then routed to node1 all the time.

@balajivenki yes it will be sent to only one Dynomite node, but that node should properly reroute to whatever node is the owner of the that token. Right?

Yes @ipapapa  you are right, the issue we had was that since it is going to same node we had some glitches on dynomite side which I am not able to repro now and hence I joined the existing issue.

ok. I tried it locally (finally) and yes you will map to the same node because the hash will be 0.
But dynomite is doing the right thing and getting you the data that you need.
I think you can close the issue created on dynomite.
Talking about dynomite what were the glitches?

Sure I will @shailesh33 and @ipapapa
The glitch was
com.netflix.dyno.connectionpool.exception.FatalConnectionException: FatalConnectionException: [host=Host [hostname=UNKNOWN, ipAddress=UNKNOWN, port=0, rack: UNKNOWN, datacenter: UNKNOW, status: Down], latency=0(0), attempts=1]redis.clients.jedis.exceptions.JedisDataException: ERR Storage: Connection refused at com.netflix.dyno.jedis.JedisConnectionFactory$JedisConnection.execute(JedisConnectionFactory.java:104) at

@balajivenki this looks a little more complicated to change in Dyno, but I am looking at it.

@balajivenki This seems to be relative big endeavor https://github.com/Netflix/dyno/compare/binaryKeys?expand=1. I have developed most of it and added new test cases that fail. Need to fix them. I am worried though If I have missed something structurally that would require even more work. Does the workaround with converting the string to byte array working for you? You can do it at the app side as well.


Suggest camelCase for more identifiers

As I understood the code, camel case is checked only for exposed identifiers.
Can it be also suggested for other identifiers, such as variable name.
I'd like the following to suggest to rewrite x_y to xY, however for now hlint 2.2.2 does nothing:
fooBar = let
  x_y = 10
  in x_y

That's deliberate. The number of people who like non-camel-case identifiers is relatively high. I can't see it likely making this check catch more things by default, given that it's already catching more than a lot of people like. In a way choosing a non-camel-case local identifier doesn't have much impact, so is less of a problem.

Thank for the answer. Your point is valid. I'm closing.

Are you interested in an off-by-default check for non-exposed identifiers? I'm not aware of any other off-by-default checks in hlint. Otherwise we'll find another way to lint for this in our codebasel.

The problem is at the moment all the off-by-default hints have to be applied always, and then are ignored later in the pipeline. Checking this properly on all variables is quite expensive (I had it doing that very originally), so not suitable even as off by default, unfortunately.

Thank you, understood.


Make compatible with Linux

The swipl stack-limit flag malfunctions on compilation on Linux, so Time Machine scripts need to run algorithms using shell commands with stack-limit given without compiling algorithms. Also, it needs to be tested on Windows.

This solution doesn't work (at least Text to Breasonings, which needs a large amount of memory, only works on Linux if T2B files are split).

I can use :-set_prolog_stack(global, limit(10 000 000 000)). for a 10 GB stack.