Add a fides init command

Closes #276
Closes #315
Code Changes

[x] break up the CLI commands
[x] add an init command that creates a .fidesctl directory
[x] update where the config can be found (.fidesctl/config.toml)
[ ] add tests
[ ] update docs with the new flow

Steps to Confirm

[ ] list any manual steps taken to confirm the changes

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
[ ] Documentation Updated

Description Of Changes
Write some things here about the changes and any potential caveats

@PSalant726 the connection string is passed to SQLAlchemy, which will throw errors immediately if it is not correctly formed. After that, a test select 1 query is run to make sure that a connection can be established. I don't see any vulnerabilities here.
As for arbitrary code execution, I'm also not sure where that would/could happen. I checked around online for user input sanitization in click/python which doesn't really seem to exist, which leads me to believe its not really an issue here.
As for checking output filenames, I don't really think thats on us. As an example, spaces are completely fine in Windows filenames, so we'd then be going down a path of platform-specific checking. I think its up to the user to provide a valid filename, otherwise they'll get an error when the code breaks.

@PSalant726 Almost all of the tools that I've used personally auto-generate a full config file for you and then let you decide what you want to edit/delete etc. I don't see the user having to put in key/value arguments to the command as a better user experience than editing a toml file.
I also don't think suggesting any kind of file structure is needed either. I prefer to let users organize their files as they see fit
For now it creates the .fides dir and dumps out a config file, but in the future I'd like to greatly expand it and see this as a solid starting point

@ThomasLaPiana

the connection string is passed to SQLAlchemy, which will throw errors immediately if it is not correctly formed. After that, a test select 1 query is run to make sure that a connection can be established.

I had no idea this happened automatically - that's fantastic!

As for arbitrary code execution, I'm also not sure where that would/could happen. I checked around online for user input sanitization in click/python which doesn't really seem to exist, which leads me to believe its not really an issue here.

I appreciate you digging into this! For me it's the difference between a potential attack vector and an actual vulnerability. It might be that it would only represent an issue if we took the input string and passed it right to eval(), which would obviously be bad practice, but it also might be something totally unforeseen. We don't need to over-engineer things just to be safe, but at the same time I'm not content to say "input sanitization doesn't exist in click/python, therefore it's not an issue". I think if we can do anything [relatively simple] to narrow the scope of accepted input from just "any str", then we should do that. Unfortunately I can't think of any specific ideas at this point.

As an example, spaces are completely fine in Windows filenames, so we'd then be going down a path of platform-specific checking. I think its up to the user to provide a valid filename, otherwise they'll get an error when the code breaks.

Yea, after doing some more research it seems like this is a known unsolved problem in Python. Lame. Do you think whatever error might get raised would be helpful, or cryptic? It might just be that we can't do much to help here 😕

I don't see the user having to put in key/value arguments to the command as a better user experience than editing a toml file.

Good point. So maybe we only include the properties that are absolutely required, and point users to the documentation as part of the output (like you're already doing)? I think it eliminates the question of what to exclude because it wouldn't be some arbitrary subset of config options, it would only be the optional ones.

I also don't think suggesting any kind of file structure is needed either. I prefer to let users organize their files as they see fit

For me, the cost/benefit analysis is: what do users gain from the flexibility vs. what do we as maintainers lose by allowing it? If we're going to try and get all fides tools onto the same standard of config/manifest file management, then enforcing some more structure feels very valuable. I'm not sure what users gain from the flexibility, and it might lead them into messy manifest management practices. Thoughts?

in the future I'd like to greatly expand it

Do you have any ideas about what else might be included? Is there anything worth adding now?

@PSalant726

I appreciate you digging into this! For me it's the difference between a potential attack vector and an actual vulnerability. It might be that it would only represent an issue if we took the input string and passed it right to eval(), which would obviously be bad practice, but it also might be something totally unforeseen. We don't need to over-engineer things just to be safe, but at the same time I'm not content to say "input sanitization doesn't exist in click/python, therefore it's not an issue". I think if we can do anything [relatively simple] to narrow the scope of accepted input from just "any str", then we should do that. Unfortunately I can't think of any specific ideas at this point.

I dug into Click a little more and found some good options for validating user input, such as this, that being said, the hard part is now deciding what to clean. Is there a general best practice for sanitization?

Yea, after doing some more research it seems like this is a known unsolved problem in Python. Lame. Do you think whatever error might get raised would be helpful, or cryptic? It might just be that we can't do much to help here 😕

It looks like the click.Path() type we're already using implements this, so we should be good to go here. I can also add the exists flag for manifest_dir and it will check the directory actually exists before executing it. I'll also update output_dir with the new type validation

For me, the cost/benefit analysis is: what do users gain from the flexibility vs. what do we as maintainers lose by allowing it? If we're going to try and get all fides tools onto the same standard of config/manifest file management, then enforcing some more structure feels very valuable. I'm not sure what users gain from the flexibility, and it might lead them into messy manifest management practices. Thoughts?

I'm still of the opinion here that it isn't up to us to determine how a user should structure their stuff. When you give fidesctl a manifest file, it navigates the entire directory tree and attempts to load every yml file it finds. This means the current supported structure is completely arbitrary. Additionally, this will return a normalized Taxonomy object. So if fidesops or fidescls wants to ingest a set of manifest files, they can use that code from the fideslang.manifests directory and get back a standard Taxonomy object to work with. I believe fidesops is already doing this

Do you have any ideas about what else might be included? Is there anything worth adding now?

For sure, you yourself gave really good examples in the issue. Giving people the option to jump right into generating manifests seems like a logical next step once we support policy/system generation as well as datasets.
We could also point to more docs here.

Good point. So maybe we only include the properties that are absolutely required, and point users to the documentation as part of the output (like you're already doing)? I think it eliminates the question of what to exclude because it wouldn't be some arbitrary subset of config options, it would only be the optional ones.

Yeah I was on the fence between include/exclude, but landed on exclude so that anything new we added would be automatically included. I have preferred in the past to browse through a full config file just to see what we could configure, so here I just left off the things that we automatically set at config runtime.

Looking really good! Nothing major at this point. Separately though, I think it makes more sense to remove the analytics-related changes until we open a PR to add analytics/opt-out support. IMO the changes belong in that diff, and with that context. Also, we don't have the "approved" copy yet.

this was a sloppy friday afternoon PR, sorry about that, thanks for catching all of the little issues!


Summaries 3 and 7

I will move edits into their own PR and merge before this is ready, so diff will likely only contain summaries and TOC.
Details:

Lots of edits in Ch 3 as I was summarizing
Summary for 3 in bullet form

Superseded by #77


Fix hover issue on skill dice

Fix for #951 hover issue

This also maybe considered a fix for #942


What is the status of the project?

Is it an official and supporting approach for embedding .Net? Or the project is done and won't  develop more?

This is a duplicate of https://github.com/mono/Embeddinator-4000/issues/758 , though you couldn't have easily seen that since it was closed. I'll copy the text here:

There currently is not active development by members of the Xamarin team, but we are triaging incoming issues and assisting where it makes sense.
As a community project, the hope is that people will be able to build upon it to bundle C# libraries in native libraries. However, to do so today does involve getting your hands dirty by creating simplified "facade" interfaces in places.


TextDecoder.decode() should accept ArrayBuffer too

The definition here:
https://github.com/facebook/flow/blob/9dfe1c367b7aee3407f272c9be6e0e1728c5f684/lib/bom.js#L1237
should be amended to:
decode(buffer?: ArrayBuffer | $ArrayBufferView, options?: { stream: bool }): string;

As per https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder , .decode() accepts either an ArrayBuffer or an ArrayBufferView.

Feel free to PR!


Battle Info glitch(?)

http://i.imgur.com/PYIlPVE.png
Seems like it seems out of place. I might be just me though. I tried reloading the extension but it still occurs.

adding for another display glitch, don't know whether this only in me or not
it's usually work well, but since I updated to v13.0 via manual unpacking, the enemy formation details only showing two first enemies, and the rest are white:

@Erupi you are right.

Did you try closing the panel and open it again? Then see if the problem still persists or not.


fix: Change "npm install" to "npm ci" to install fixed version packag…

…es for docker image
Description
The npm ci command is similar to the npm install command, except that it is intended for use in automated deployment environments where you want to make sure you perform a clean install of your dependencies.
Fixes #320
Closes #320
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] CI system update

Test Configuration:

Java: v11
LPVS Release: v1.x.x

Checklist:

[x] My code follows the style guidelines of this project
[x] My code meets the required code coverage for lines (90% and above)
[x] My code meets the required code coverage for branches (80% and above)
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e4e613) 91.54% compared to head (c006f79) 91.54%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #385   +/-   ##
=========================================
  Coverage     91.54%   91.54%
  Complexity      495      495
=========================================
  Files            48       48
  Lines          1703     1703
  Branches        206      206
=========================================
  Hits           1559     1559
  Misses           86       86
  Partials         58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Floating album cover gets covered by the player button bar

When the album cover is in large format it gets covered by the player button bar when "youre listening"
appears on dribbblish
Have the album art in large format. Listen to music on your phone while you have spotify on your pc open. The div covers the bottom of the album art.
The album art should move up when the div moves up.
https://imgur.com/VYxMUYc

OS: Windows 19043.1081
Spotify version  <IP_ADDRESS>3
Spicetify version 2.5.0
Dribbblish

Please add this to https://github.com/morpheusthewhite/spicetify-themes/issues/440


KeepAlive is not working for PingRequest

I'm testing using basic example and having three issues with a client disconnect timeout:
1 - The client got disconnected before send ping request to the server;
2 - If I change the server source code to configure timeout as 1.5 times the value of keepalive, client will continue to disconnecting because the ping request package doesn't refresh the keepalive timer as publish packet does;
3 - When client try to disable keepalive (keepalive = 0), the connection are closed immediataly.
The client only connect to server and subscribe to one topic. If client send publish messages periodicaly, the connection keep alive

fixed in new client api, v0.3.5


Project manifest migration strategy update

We should probably rethink our manifest migration strategy. While we can have all of these options set as optional manifest properties, I'd say that we'll likely want to create a proper migration strategy sooner than later, as it will reduce future work.
Current migration strategy:
Auto-generated code requires us to implement certain, fixed migrators.
available manifests:
0.1.0
0.2.0
0.3.0
0.4.0

migrators/migration paths:
0.1.0 -> 0.4.0
0.2.0 -> 0.4.0
0.3.0 -> 0.4.0

After update to 0.5.0:
We need to update/create n+1 migrators if we want full migration support.
available manifests:
0.1.0
0.2.0
0.3.0
0.4.0
0.5.0

migrators/migration paths:
0.1.0 -> 0.5.0 #added/modified
0.2.0 -> 0.5.0 #added/modified
0.3.0 -> 0.5.0 #added/modified
0.4.0 -> 0.5.0 #added

Proposed migration strategy:
Allow developers to declare their own migrators, from whichever version to whichever other version.
A simple search algorithm would then find the appropriate migration path, and could even allow for downgrades if the correct migrator exists.
available manifests:
0.1.0
0.2.0
0.3.0
0.4.0

migrators:
0.1.0 -> 0.2.0
0.2.0 -> 0.3.0
0.3.0 -> 0.4.0
0.1.0 -> 0.3.0

migration paths to 0.4.0:
0.1.0 -> 0.2.0 -> 0.3.0 -> 0.4.0
0.1.0 -> 0.3.0 -> 0.4.0

After update to 0.5.0:
available manifests:
0.1.0
0.2.0
0.3.0
0.4.0
0.5.0

migrators:
0.1.0 -> 0.2.0
0.2.0 -> 0.3.0
0.3.0 -> 0.4.0
0.1.0 -> 0.3.0
0.4.0 -> 0.5.0 #added

migration paths to 0.4.0:
0.1.0 -> 0.2.0 -> 0.3.0 -> 0.4.0 -> 0.5.0
0.1.0 -> 0.3.0 -> 0.4.0 -> 0.5.0

Niraj: Look into Django migrations.

I think this is a good idea, but I think we should require the simplest complete path:
migrators:
0.1.0 -> 0.2.0
0.2.0 -> 0.3.0
0.3.0 -> 0.4.0

This ensures any migration can always happen, even when nobody adds a shorter path. Even though this is the longest path, the migrators are inexpensive and it won't be a practical issue.


Bundled tool to convert GLTF/GLB to USDZ on Linux/OSX

As a 3D content publisher,
when I deploy my production content,
I would like to generate USDZs from my GLTFs,
so that it is easy to support iOS users
This issue proposes that we build and maintain a distributable, all-in-one build tool that makes it easy to generate a USDZ from a GLTF. Such a tool will allow content publishers to maintain GLTFs as their primary assets, and generate USDZs as an artifact as they go to production.
This tool can also be used in <model-viewer> so that we can work by example and only generate USDZ when we go to deploy production artifacts to Github Pages.

Resources:
https://github.com/TimvanScherpenzeel/gltf-to-usdz-research
https://blendersushi.blogspot.com/2018/09/convert-gltf-into-usdz_3.html
https://github.com/kcoley/gltf2usd

Does https://github.com/google/usd_from_gltf close this issue?

@cwervo it is definitely a start. I think what we should do to close out this issue is to bundle that converter as an NPM package so that web folk can trivially incorporate it into their build pipelines.

Oh an implementation on npm would be great!! 👍🏼👍🏼👍🏼

There's also a docker version of https://github.com/google/usd_from_gltf here: https://github.com/Giorat/docker-gltf-to-udsz
But it's really heavy in the build phase due to docker and compilation time of USDZ

in 2020 there is now the python usdzconver script from Apple.
I tried multiple glTF and it worked pretty well. I couldnt make it work with Morph Target though.

in 2020 there is now the python usdzconvert script from Apple.
I tried multiple glTF and it worked pretty well. I couldnt make it work with Morph Target though.

usdzconvert is only for Mac os? Were you able to test it on linux or mac?

in 2020 there is now the python usdzconvert script from Apple.
I tried multiple glTF and it worked pretty well. I couldnt make it work with Morph Target though.

usdzconvert is only for Mac os? Were you able to test it on Linux or Windows?

Yes, out of the box it's macOS only, since it contains native libraries for macOS only.
Presuming Apple didn't change anything in any dependecy lib, theoretically one could build all the native libs for other platforms like Windows and Linux and use it. But that's a bit of work (getting USD libs to compile is not straight forward).
So no, Apple's usdzconvert is no Linux solution.

@DavidPeicho at the time of authorship usd_from_gltf was considered to be faster and more faithful in converting glTF to USD compared to the tools provided by Apple. It was written by engineers working on Search who use it to automatically produce USDs from third-party glTFs displayed in search results. In the past, it has produced good results on a lot of models that appeared broken when using usdzconvert.
I'm not sure if those qualifications are still true today. I assume both projects have been evolving steadily over time.

Yes I was just bringing another alternative. I looked into the tool more deeply and indeed it looks like a lot to make it work on linux. Probably feasible, surely not easy 😢

To revive this a bit more, I gave a shot to usd_from_gltf. It's pretty good and fast. However, as the README states, they don't support Morph Targets. May not be a big deal for most users, but in my case I make heavy use of them.
I gave a shot as well to gltf2usd. Worked pretty well on really complex model, but messed up the Z axis and made my material transparent (easy to fix).

Thanks for checking out those tools @DavidPeicho . We should probably do a survey to get a sense of the limitations of all the tools that are currently available.

It seems to me that an interim solution to this problem would be to encourage @donmccurdy & Co. to integrate usd_from_gltf into https://threejs.org/editor/ exporters.

/cc https://github.com/mrdoob/three.js/issues/14219#issuecomment-652649975

@cdata is there any npm package or a functionality in model-viewer library that we can use to convert GLB model or GLTF file to USDZ ?

@Weltfern you can actually use apples usdz converter or Google’s gltf to usd repository to do that. You can download prebuilt USD binaries from Nvidia if you don’t want to build it yourself.

@lanxinger apple's usdz converter only works on mac and Google’s gltf to usd install steps are daunting. There still isn't an easy to use bundled tool that's (web) accessible to non-developers or mac owners.

Any reliable tool for creating or reading USDZ files is going to have to rely on the USD Runtime. It doesn't work on the web, and I'm not aware of any plans to fix that. You may need to request this from Apple or from Pixar, because there's not much that web developers can do about things without it.

I would highly recommend this website as a solution: https://spase.io/playground


Feature Request

Is your feature request related to a problem? Please describe.
When viewing notes the path to the note is hidden unless you mouse over the top of the note where the path shows on the default theme.
Describe the solution you'd like
It would be nice to have an option to always show the path to the note and not have to mouse over the top part of the note just to see where it is stored.

this is already implemented, see Style Settings → Titles → Tab title bar


use color theme for dark mode

like default theme, it could be nice to have a dark mode color theme

FIX with  #713


R LDAvis plots need rework for new class structure

Reed, assigning this to you, as we discussed earlier today.  This is much the same as #3 - If you can use PyLDAvis instead, you're killing two birds with one stone.

Fixed in #31


fix nodeport reconciliation for Kube APIServer

without this: every reconciliation loop the node port changes on the service which will break network connectivity with the master
Also will cause constant fluctuation of iptable rules across nodes as nodeports change on every iteration

/test e2e-aws


Custom Assertion Library

Is there a way to have jest use a different assertion library and alias it to expect?

Yes! Check out the testRunner config option and the jasmine2 integration here: https://github.com/facebook/jest/blob/master/src/testRunners/jasmine/jasmine2.js

@cpojer Link is broken. Has that file been moved?

@mnpenner it was removed yes. you can still use it with another assertion library if you replace the global expect in a setup file

In here? OK, thanks.

you should add something like
global.expect = require('my-custom-expect');

in here https://facebook.github.io/jest/docs/configuration.html#setupfiles-array


Difference between Category and Categories layouts

What's the difference between Category and Categories because I'm confused ?

I thought the documentation explained this clearly, but here's another take.
Categories layout
Shows all categories currently used on your site, with the posts attributed to them. For example if you have two categories foo and bar you'd get a page like:
## foo
- Some post that is in the foo category
- Another post that is in the foo category

## bar
- Some other post that is in the bar category

The category layout is for building a page that only lists 1 category and all the posts in it. So if you wanted an archive page for just the foo posts you'd create a "category" page for it.
This page would look something like this:
## foo
- Some post that is in the foo category
- Another post that is in the foo category

To summarize, categories layout shows all categories and their posts, category is for a single category and its post. The same is true for the tag and tags layouts.

Visuals may help...
this is a layout: categories page (shows all categories and their posts)
and this is a layout: category page (shows just the "edge case" category and its posts)

So, how can I see a category link on the homepage of my site ?


Bug: spark cli does not assign a default group to newly created user

PHP Version
8.2.14
CodeIgniter4 Version
4.4.4
Shield Version
dev
Which operating systems have you tested for this bug?
Windows, Linux
Which server did you use?
apache
Database
MariaDB 10.2
Did you customize Shield?
No
What happened?
While creating a new user from the cli, the php spark shield:user create command does not assign any group to the user (if not using the group option/parameter).
I think the command should assign a default group to the newly created user by using the following setting: config(\Config\AuthGroups::class)->defaultGroup in order to avoid possible permissions issues at the first login attempt.
Steps to Reproduce
php spark shield:user create

Username : bgeneto
Email<EMAIL_ADDRESS>Password : *******
Password confirmation : *******
User "bgeneto" created

Expected Output
A corresponding line in the auth_groups_users table using the default group from config(\Config\AuthGroups::class)->defaultGroup.
Anything else?
No response

@bgeneto I sent PR #1162. Please check.


Mike's QA of carbon-wesbite

Mike noticed several bugs:

wrong green here:
https://www.carbondesignsystem.com/components/toggle/usage/
View in Slack

We used to have the space above but now there are places where it touches the top black bar. Which do we want to do?
View in Slack

the first one looks like the image needs to be updated on toggles/usage. Not sure what his second comment is referring to though?

He's talking about these gaps. There are a few moments like these and sometimes there aren't. We need to come to a consistent solution on the design side and then I will get back to ya.


POI API integration

Story
Developer team has access to the POI information provided by Open Street Map APIs by giving co-ordinates. SOMETHING MORE HERE
Tasks
ADD TASKS HERE

[ ] first
[ ] second
[ ] ....
[ ] Meets the criteria in Definition of Done


Translate project and iPhone Dark Mode

Thank you for the amazing project!
I downloaded the quickstart sample for the translate feature:
https://github.com/firebase/quickstart-ios/tree/master/translate/TranslateExample
and I added the required element, and the project ran smoothly without errors. However, the main page appeared like this:

The application looked like a mess, and I wasn't able to see the languages list. After investigating the issue, I discovered that the issue is related to the Dark Mode in the iPhone system being Active. Once I deactivate it, the application looked great, and everything was appearing as it should be.
My suggestion: consider supporting iPhone Dark Mode or disable its effect on your examples to avoid confusion.

You are right, sample doesn't support Dark Mode.
We'll update all quickstarts to support Dark mode soon. However this sample is moved to https://github.com/googlesamples/mlkit/tree/master/ios/quickstarts/translate


No access to local files from JS/HTML

I'm trying to play local audio files, video files and webworkers (referencing a local JS file) in wkwebview but none of them seem to load. However, local images are shown normally.
I get no explicit error messages.
Am I missing some configuration directive?

Where are you loading the files from?  Wkwebview can't access any path except the app root

For audio for example, I'm using:
<audio src='assets/audio/test.mp3' controls></audio>

where assets is in the www folder.

I was just checking that it was within the www folder as wkwebview cannot access files in other paths.  It should be able to access that though I would think, if you look at the network request diagnostics in safari do you see any 404 not founds or similar errors?  Once the app is running once attach the safari debug tools and hit refresh so you can monitor a load from scratch to catch any early console output or network request failures.

I get the following for an audio file:

Any update on this? I really like this plugin, as the performance increase for lower end device is quite amazing, so I'd really like to use it.

Were anyone was able to fix this issue?


log information data and its pipeline

log.info or log.debug some data in methods, where we are consuming, sending, or processing data

we don't need logging since Kafka do this job


Is there a way to make it so that the QGrid view doesn't take up the whole height of the screen?

In every grid I place, in the canvas preview, it takes up the whole screen of the device. Is there a way to limit this so that the height of the whole view is restricted to the items in the grid? i.e. to remove unnecessary white space

How about calculating the height from content, rowCount, vSpace and vPadding and specifying it in the frame?


This is not C++.

[Enter feedback here]
This is C with printf replaced by std::cout.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08c574a2-cef0-ab13-7375-55851f966ef6
Version Independent ID: fe3421c7-e9f4-4986-589f-fadaedce583e
Content: Walkthrough: Create and use your own Dynamic Link Library (C++)
Content Source: docs/build/walkthrough-creating-and-using-a-dynamic-link-library-cpp.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

@deanmsands3
Thanks for the commentary. I'll agree that the interface presented by the DLL is C, and intentionally so. A C interface means the DLL can be used by clients that aren't written in C++. That's more common in practice than an interface that uses C++ linkage. C++ linkage means all the parts of your application have to be built with the same toolchain and linked with the latest linker used for any part of the app. DLLs written with C++ interfaces have issues when handing off memory or other resource handles. Other restrictions can take surprising forms, such as link failures related to partial definitions of nested objects or uninstantiated template specializations. As a practical, software engineering matter, a C interface is usually the best choice for a DLL. Those are the reasons that drove the design of the DLL presented in this article. It's a feature, not a bug.

This is not C++.......??????
Sorry but I'm fed up with this type of comments.

@corob-msft This is a very late response, but thank you for explaining that. I never got the full reason why none of the DLL examples I'd seen were real C++. This makes the reasoning clear. Thank you.
@shd8698766 That's fair, but in my experience, C and C++ are so wildly different that saying "C/C++" deserves its own swear jar. This is made worse when working with EE's.


Provide a warning if a record exists but feedback is empty

It is possible for a commit to be graded and end up with an empty feedback field. Rather than checking the field and silently failing, warn the user that something went wrong and to make a new commit and try again (do not charge for this feedback request).

@nickbradley fixed this in the updated grader. Closing.


[fix] Remove duplicated section

#10 was opened to address the same issue.

Closing in favor of #10.


feat: remove scheduler peer stat log

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Remove scehduler peer stat log.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #797 (9d2acc0) into main (d389ce2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   40.88%   40.88%
=======================================
  Files          96       96
  Lines        7792     7792
=======================================
  Hits         3186     3186
  Misses       4210     4210
  Partials      396      396

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
40.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_base.go
46.95% <0.00%> (ø)


Assembler messages: Error: no such instruction

I am trying to run Ceedling tests for a module and am receiving the somewhat cryptic compilation output:
Test 'test_motorDrive.c'
------------------------
Compiling motorDrive.c...

C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s: Assembler messages:
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:48: Error: no such instruction: `ldrsh %eax,[%r8]'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:49: Error: no such instruction: `ldrsh %ecx,[%r8,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:50: Error: expecting operand after ','; got nothing
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:51: Error: number of operands mismatch for `mul'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:52: Error: invalid char '[' beginning operand 2 `[%r9]'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:53: Error: no such instruction: `asr %ecx,%ecx,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:54: Error: number of operands mismatch for `add'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:55: Error: number of operands mismatch for `sub'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:56: Error: no such instruction: `rsb %edx,%edx,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:57: Error: no such instruction: `ssat %ecx,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:58: Error: no such instruction: `ssat %edx,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:59: Error: no such instruction: `strh %ecx,[%r9,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:60: Error: no such instruction: `strh %edx,[%r9,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:128: Error: no such instruction: `ldrsh %r9d,[%rdx]'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:129: Error: no such instruction: `ldrsh %r8d,[%rdx,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:130: Error: no such instruction: `ldrsh %ecx,[%rax]'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:131: Error: no such instruction: `ldrsh %rdx,[%rax,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:132: Error: number of operands mismatch for `mul'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:133: Error: no such instruction: `mls %rax,%r8d,%ecx,%rax'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:134: Error: no such instruction: `ssat %rax,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:135: Error: number of operands mismatch for `mul'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:136: Error: no such instruction: `mla %r8d,%r9d,%ecx,%r8d'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:137: Error: no such instruction: `ssat %r8d,'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:138: Error: no such instruction: `strh %rax,[%r10]'
C:\Users\[userName]\AppData\Local\Temp\cc2DmMto.s:139: Error: no such instruction: `strh %r8d,[%r10,'
ERROR: Shell command failed.
> Shell executed command:
'gcc.exe -I"test" -I"test/source" -I"test/source/utilities" -I"test/utilities" -I"test/support" -I"source" -I"source/utilities" -I"drivers" -I"board" -I"CMSIS" -I"C:/nxp/RTCESL/CM4F_RTCESL_4.5_MCUX/GMCLIB/Include" -I"C:/nxp/RTCESL/CM4F_RTCESL_4.5_MCUX/MLIB/Include" -I"C:/nxp/RTCESL/CM4F_RTCESL_4.5_MCUX/GFLIB/Include" -I"D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/vendor/unity/src" -I"D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/vendor/cmock/src" -I"build/test/mocks" -DTEST -DCPU_MK64FN1M0VMD12 -DGNU_COMPILER -g -c "source/utilities/motorDrive.c" -o "build/test/out/motorDrive.o"'
> And exited with status: [1].

rake aborted!
ShellExecutionException: ShellExecutionException
D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/lib/ceedling/tool_executor.rb:78:in `exec'
D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/lib/ceedling/generator.rb:95:in `generate_object_file'
D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/lib/ceedling/rules_tests.rake:17:in `block in <top (required)>'
D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/lib/ceedling/task_invoker.rb:74:in `invoke_test_results'
D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/lib/ceedling/test_invoker.rb:104:in `block in setup_and_invoke'
D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/lib/ceedling/test_invoker.rb:63:in `setup_and_invoke'
D:/Documents/MCUXpressoIDE_10.1.0_589/workspace/SR544/vendor/ceedling/lib/ceedling/tasks_tests.rake:11:in `block (2 levels) in <top (required)>'
C:/Ruby21/bin/ceedling:23:in `load'
C:/Ruby21/bin/ceedling:23:in `<main>'
Tasks: TOP => build/test/results/test_motorDrive.pass => build/test/out/test_motorDrive.out => build/test/out/motorDrive.o
(See full trace by running task with --trace)
ERROR: Ceedling Failed

Any suggestions for how to locate and fix the issue here would be appreciated.

If you rerun the test with verbosity turned up, it should show the call you're making to the assembler.   Does it look correct? It seems like it's trying to call the wrong tool when you are passing it an assembly file?

The verbosity doesn't shed any more light on it for me, but it's attached here for your perusal.
Ceedling_VerboseOutput.txt
There are some warnings before the Assembler errors, but those don't appear to be the main issue. (All of the warnings are generated by the third party drivers).
The shell command that causes the exit (on line 218) looks ok.

It appears from that snippet that motorDrive.c includes peripherals.h which includes ccjubmUE.s (or does motorDrive.c directly include it?) I'm just trying to see how you get to the point where you are attempting to compile this assembly file... it LOOKS like it's being pulled in as C code, which is why it is failing.

motorDrive.c does include peripherals.h. But peripherals.h doesn't include any .s files. In fact, I can't even find those .s files (they are in a \Temp\ directory that I am not explicitly making use of for my project). Does Ceedling or gcc write intermediate files to \Temp?

Nope. All of Ceedling's output goes into the build directory and subdirectory. This is one of the other tools. I'm not really sure what is going on here. If you copy the compile command that Ceedling is generating and execute it by itself at the command prompt, does it run properly or still have the same issue?

If I run the gcc command from line 219 of the above .txt file, it has the same issue (although the .s files are named differently each time).
If I run the very first line, I get:
gcc.exe: error: build/temp/_test_motorDrive.c: No such file or directory
gcc.exe: fatal error: no input files
compilation terminated.

I have a hunch with what's going on here. The project I am testing is for a Cortex M4 CPU, and in order to compile, I need to define the CPU. I've therefore included "CPU_MK64FN1M0VMD12" in the list of :defines: in the project.yml settings. (Without this #define, the compilation throws the error "No valid CPU defined!"). But since Ceedling is trying to compile the code for execution on a host PC, this is not the correct CPU, and so I get the "Error: no such instruction" messages from the assembler.
If this is the right interpretation of this error, how can I properly break the source code dependency on the CPU?

You will need to "mock" the functions in that header files or manually assign variables. I do this trick very often where I redifne absolute addresses to some variable. For example:
#define ADC0_BASE         (0x40002000UL) /**< ADC0 base address  */

is then changed to in file procfamilyprocnummock.h:
volatile ADC_TypeDef	  adc0_base;
#define ADC0_BASE         (&adc0_base) /**< ADC0 base address  */

Then in the file where CPU is defined I just add another ifdef and then actually define PROCFAMILYPROCNUMMOCK, so that MOCK gets chosen in Ceedling, while all else works normally.
Your invalid instructions is mostly because of some hardcoded asm magic. That I usually replace with some ifdef by valid C implementation, which keeps everybody happy. When you upgrade the library I usually put the new version on separate branch, and then merge it in with "master".
I hope that makes some sense.

i am using
#define DATA_MEMORY_BARRIER() asm volatile("dmb sy": : :"memory")
in my one of source.cpp file and calling DATA_MEMORY_BARRIER() in many places.
while compiling for my gtest sourceFile_test.cpp [source.cpp is added in Makefile.am for compilation dependency] it is giving an error as,
Error: no such instruction: `dmb sy'. [got this error ubuntu 16.04 x86-64 amchine]
How can i resolved it or what Assembler option I can use to make compilation successful for source.cpp file?

@Ajay107246 -- I think you may be on the wrong forum? You're talking about C++ code and gTest. This is a forum for Ceedling and C testing. (If I had to guess, though, I would suspect that you are going to need to define DATA_MEMORY_BARRIER as nothing during a test. With Ceedling, TEST is defined during a test so you can use an #ifdef to decide which definition to use. There is likely something similar in gTest).

Have you been able to solve this @abergerSRS  ?
we are having the exact same issue...

Hello. Any updates ? I am having same issue. @tomh4 @abergerSRS

I don't think this has anything to do with Ceedling. You are compiling ARM assembly while you are running test cases on x86_64 machine. So you either define/remove the assembly with ifdef TEST or you use simulator to run your tests (along with arm compiler).

It seems no one solve this problem until now.

Can you explain a bit what is not solved?

Can you explain a bit what is not solved?

I face the same issue..
While compiling source file i get the same errors
Compiling dfu_mode.c with coverage...
C:\Users\x\AppData\Local\Temp\cc3Lvn1N.s: Assembler messages:
C:\Users\x\AppData\Local\Temp\cc3Lvn1N.s:28: Error: number of operands mismatch for ds' C:\Users\x\AppData\Local\Temp\cc3Lvn1N.s:57: Error: number of operands mismatch for ds'
C:\Users\x\AppData\Local\Temp\cc3Lvn1N.s:474: Error: no such instruction: mrs %eax,primask' C:\Users\x\AppData\Local\Temp\cc3Lvn1N.s:504: Error: no such instruction: cpsid i'
C:\Users\x\AppData\Local\Temp\cc3Lvn1N.s:577: Error: no such instruction: `msr primask,%eax'
but I could not find "mrs %eax, primask" or "msr primask, %eax" instructions in my source code.
It worth noting that this error appeares when i move test project files to a folder one level deeper.

I still think you guys are compiling the ARM code (or whatever target) with x86_64 compiler and running it on your PC? That is why it is logical that it does not recognize the instructions. You include a source file which uses some assembly file which is target specific and not x86_64.

Here is the way I found how to deal with this error in my case
in .yml file add  __asm definition
:defines:
in order to add common defines:
1) remove the trailing [] from the :common: section
2) add entries to the :common: section (e.g. :test: has TEST defined)
:commmon: &common_defines #[]
- __asm
And it will show files with assembly related errors.
Then I just substitute this files with __asm (bla bla bla...) lines removed.

So you are basically omitting the assembly code (designed to do something)? Does it work? It is a potential hack, but I would rather follow the suggested path of amending library code or running on a simulator (if possible).


File ending is checked case sensitive

I wondered why my .CSV files always open in text mode. Then I renamed it to .csv and it worked as it should.
Is it possible to check the ending case insensitive?
Thanks

Yes, of course, I'll add that in the next release, for the time being you can add CSV in the 'Supported Csv Extensions` setting.


Replace py::object type by optionalstd::string for name parameters

Summarize your change.
Yet another type improvement. This time, I'm changing the name parameters to be explicit about which types they accept. They accept either None or a string.
Note that this has a side effect. Before, the name parameters would accept anything (because of py::object), which means that passing a dict would produce "{}" for example. I think it's fine if we stop supporting this as it was probably not intentional in the first place.
Question for the TSC: Some constructors use std::string for the name parameter while some others accept None or string. Should we simply just remove support for None? That would simplify things and also make it consistent across constructors.

Are you asking, specifically with regards to this PR, should we replace the optional<std::string> with std::string, or are you asking a broader question across the entire OTIO API?

Codecov Report

Merging #1446 (8854598) into main (0763bf6) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage   78.83%   78.84%
=======================================
  Files         203      203
  Lines       22252    22248    -4
  Branches     4521     4519    -2
=======================================
- Hits        17543    17542    -1
  Misses       2437     2437
+ Partials     2272     2269    -3

Flag
Coverage Δ

py-unittests
78.84% <33.33%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...entimelineio-bindings/otio_serializableObjects.cpp
24.54% <33.33%> (-0.19%)
:arrow_down:

...ntimelineio/opentimelineio-bindings/otio_tests.cpp
29.78% <0.00%> (+1.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0763bf6...8854598. Read the comment docs.

Are you asking, specifically with regards to this PR, should we replace the optional<std::string> with std::string, or are you asking a broader question across the entire OTIO API?

Specifically with regards to this PR.

Ok, my first question would be if you make it not-optional, would there be a lot of work on adapters and other py based tools to introduce names where maybe there are none presently?

When I remove the optional, it looks like we only need to do a small change:
diff --git a/src/py-opentimelineio/opentimelineio/adapters/fcp_xml.py b/src/py-opentimelineio/opentimelineio/adapters/fcp_xml.py
index 98e1fd1..4d60e3a 100644
--- a/src/py-opentimelineio/opentimelineio/adapters/fcp_xml.py
+++ b/src/py-opentimelineio/opentimelineio/adapters/fcp_xml.py
@@ -738,7 +738,7 @@ class FCP7XMLParser:
         """
         local_context = context.context_pushing_element(track_element)
         name_element = track_element.find("./name")
-        track_name = (name_element.text if name_element is not None else None)
+        track_name = (name_element.text if name_element is not None else '')

         timeline_item_tags = {"clipitem", "generatoritem", "transitionitem"}

At least all tests are passing with this change.
name is already a kwarg with a default of ''. I think that disallowing None would be a safe change to do.

ok, sounds good to me.

@ssteinbach @meshula what should we do about the inconsistency of the name parameter type (sometimes optional and sometimes string)?

From TSC meeting: The change of no longer accepting None for these sounds okay - we just need to document in the release notes that this will be a breaking change for people.

Perfect, I'll create a PR later this week. Thanks!


C-Ares: Remove Internal Header

The nameser.h header is a C-Ares internal header which is not installed with C-Ares.
This fixes build errors with externally installed C-Ares (1.13) with
  cmake -DgRPC_CARES_PROVIDER=package ..

Removes a the header defining two IANA controlled numbers to do a SRV lookup.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

too bad I don't have a google account to sign the CLA

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

I hereby state this is a trivial change and license it under CC0 if someone needs it one day

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@randomguy3 since you fixed other install issues with external c-ares, do you want to re-open this PR to get it included? It's minimal and I give it out for free but don't have a google account to sign the CLA.

oh well...

I signed it!

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@markdroth @y-zeng I updated the PR to make it more clear and less magically-appearing, including RFC references.
Can you please add me to your jenkins-allowed list for testing? :)

@jtattermusch regarding a build with all-external dependencies, it would be great if this fix could also make it into 1.5.0 :)

test this please

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

@jtattermusch can you please re-trigger the two failed tests (Basel, Windows)? There is no apparent reason why they should fail :)

I pushed again to trigger the time-outed builds of some test components. let's see if this worked...

test this please

Jenkins: test this please

[microbenchmarks] No significant performance differences

This should not be a question of platforms but is a question of accessing an internally shipped file of c-ares (which will not be found if it is properly installed as external lib) or not :)

@y-zeng the tests have run :)
anything you need from my side?

@ax3l I've merged this pull request into #11927

@ax3l May I submit your commit with #11927? : )

Yes, feel free to move it there! :)

Thanks, @ax3l! I've merged #11927.


[feature-needed ?] How can I use typedoc in my angular-cli generated project ?

Hello,
I've tried to use typedoc on my project but since angular-cli relies on webpack, I needed to override the webpack config to add a dedicated plugin to integrate typedoc.

Since webpack config is not accessible in angularcli projects , it would be nice to be able to generate project documentation in the future.

( If you know how I could do this on my own, please enlight me and I'll propose a pull request)

Follow this step:

Install Typedoc globally with this command npm install --global typedoc.
Add typedoc.json with Typedoc configuration:

{
  "mode": "modules",
  "out": "doc",
  "theme": "default",
  "ignoreCompilerErrors": "true",
  "experimentalDecorators": "true",
  "emitDecoratorMetadata": "true",
  "target": "ES5",
  "moduleResolution": "node",
  "preserveConstEnums": "true",
  "stripInternal": "true",
  "suppressExcessPropertyErrors": "true",
  "suppressImplicitAnyIndexErrors": "true",
  "module": "commonjs"
}

Add these two lines to the package.json:

"docs": "npm run typedoc -- --options typedoc.json --exclude '**/*.spec.ts' ./src/",
"typedoc": "typedoc"

Now you can run Typedoc using npm run docs.

Have fun with Typedoc :)

@zacol thanks for the detailed writeup!

hello, I have this problem when I hit npm run docs.
You must either specify the 'out' or 'json' option

i had same problem. but i solved this way.
"docs": "typedoc --json typedoc.json --exclude '**/*.spec.ts' ./src/"

@luismiguelbravo If you are using typedoc 0.9.0, there is an issue saying --options typedoc.json is broken on this version.
Replacing typedoc.json with typedoc.js works for me.

Add typedoc.js with the same configuration

module.exports = {
  mode: 'modules',
  out: 'doc',
  theme: 'default',
  ignoreCompilerErrors: true,
  excludePrivate: true,
  excludeNotExported: 'true',
  target: 'ES5',
  moduleResolution: 'node',
  preserveConstEnums: 'true',
  stripInternal: 'true',
  suppressExcessPropertyErrors: 'true',
  suppressImplicitAnyIndexErrors: 'true',
  module: 'commonjs'
};

Change the corresponding command in package.json

"docs": "npm run typedoc -- --options typedoc.js --exclude '**/*.spec.ts' ./src/",
Hope this helps.

work perfect


pos is ignored after initial load

Changing the pos property after player's initial load is not changing the audio's cursor position.

Hi,
Could you check if this is still happening? I updated the dev example to load the initial position in onReady but setting it directly as a prop (e.g. pos={2}) works with me too.

I am able to confirm that this issue still exists. Everything works as expected if i click on the WaveSurfer canvas but if i try to change the value of the pos-property after i have started playback nothing happens. it works though if i change it before i start to actually play something e.g. if i set the pos-property in the onReady-eventhandler

This is due to the fact that while playing the position is updated constantly, thus the value of the input field in the example gets updated while you're trying to put in a new value.
I have added a button which fires a function which sets the position to check this and I can confirm it changes the position to the correct value even when playing. (Code is in this branch https://github.com/mspae/react-wavesurfer/tree/pos-check)
Thanks for the comment anyway though :+1:


[FIX][UI]add button disabeld when isDetails

with ONLINE process definition Add button should disabeld for readOnly

Is the save button in the gray toolbar more friendly

Is the save button in the gray toolbar more friendly

after click save ,user have to config something before click add

You add this graying out for the work that is already online. The backend of the online workflow is checked. If you are only for the online workflow, you can prevent the user from clicking the save button and restrict the user from adding it. Can’t add some changes

You add this graying out for the work that is already online. The backend of the online workflow is checked. If you are only for the online workflow, you can prevent the user from clicking the save button and restrict the user from adding it. Can’t add some changes

but if disabled the save button , i can't check the config[tenant,alert,timeout]info in the popout dialog,
so I just graying out the add button to avoid unnecessary click

but if disabled the save button , i can't check the config[tenant,alert,timeout]info in the popout dialog,
so I just graying out the add button to avoid unnecessary click

If the user needs to see the configuration information inside, it is also possible


add(docs): Explain each config field

We have added xcall support. Will be updated once finalised.


Windows Phone image has a border?

Why does the Windows Phone image have a border around the device? Android and iOS do not. Looks weird.

That is actually the white of the windows phone device


Create subclass with PointMixin in it

Currently tests don't pass because of an AttributeError in fields inheriting PointMixin. Something's broken in how the classes are handled in inheritance. What works is including it in the with_metaclass(...) call.
This passes manage.py test on Django versions 1.4-1.7 (latest of each).

+1 on this

+1


Fix mapping of bool to string #1966

This will make ogr2ogr2 honor quoted_fields_guessing which was wrongly
mapped to QUOTED_FIELDS_AS_STRING when passed.
@juanignaciosl one-liner review please

Frontend tests were OK :+1: (details)

:+1:


Readme link pointing to a 404

The test helpers support both module-level and project-level tests. See:

Terraspace Testing
Link is broken

Testing docs was moved to main docs site.
Updated old link to https://terraspace.cloud/docs/testing/


Python RestrictedUnpickler issue

We had written code as -
import os
import builtins
import pickle
import sys
sys.tracebacklimit=0
import traceback
import io
from logging import Logger

safe_builtins = {
        'range',
        'complex',
        'set',
        'frozenset'
        }

class RestrictedUnpickler(pickle.Unpickler):
  def find_class(self, module, name):
  # Only allow safe classes from builtins.
   if module == "builtins" and name in safe_builtins:
       return getattr(builtins, name)
    # Forbid everything else.
   raise pickle.UnpicklingError("global '%s.%s' is forbidden" %
   (module, name))

def restricted_loads(s):
    """Helper function analogous to pickle.loads()."""
    return RestrictedUnpickler(io.BytesIO(s)).load()

def func1(a):
  try:
    x= restricted_loads(pickle.dumps(a))
    return x
  except pickle.UnpicklingError :
    s= pickle.UnpicklingError("unsupported persistent object")
    return s

def func2(s):
  try:
    x=restricted_loads(pickle.dumps(s))
    return s[x]
  except pickle.UnpicklingError :
    s=traceback.format_exc()
    return s

if __name__ == "__main__":
       a=range(int(input()))
       b=func1(a)
       print(b)
       y=tuple(input())
       z=func2(y)
       print(z)

Getting
TypeError: tuple indices must be integers or slices, not tuple
Input (stdin)
50
"a", "b", "c", "d", "e", "f", "g", "h"

Your Output (stdout)
range(0, 50)
Expected Output
range(0, 50)
Traceback (most recent call last):
_pickle.UnpicklingError: global 'builtins.slice' is forbidden

I don't see relation to our project.
Sorry but if you can clarify and post a clear description, please re-open it and I will personally take care of the issue.
Thanks


Squashing commits in a given branch?

Hi,
Sometimes renovate suggests updates for a module, and as we take some time to merge the MR, new updates get pushed to this branch.
That's super practical that renovate is able to push all new versions in the same branch, leading to a single MR per dep and not one per version. However, the commit history looks like:

Update X to v1
Update X to v2
Update X to v3

Which makes some useless commits in the history. Is there an option to make renovate squash its commits to have a single commit updating to v3, with all the history in its description?
What do you think about adding such an option if it's not available?
Thanks!

@Phyks thanks for the suggestion. This should already be the default behaviour, since about a week ago. The PR I implemented it in is here: https://github.com/singapore/renovate/pull/1018
The aim of this was to have a single commit per branch in all cases except where end users start editing the branch themselves, in which case we just add any new commits on top instead of squashing.
Maybe I didn't test all possibilities, or maybe it broke since then, or maybe you were looking at older examples or running older code? If you think this is still happening with the recent code, then I need either steps to reproduce it, or some debug logs of it happening.
(FYI: we don't technically git rebase or git squash but I use those terms as they are most understandable for people)

Oh, indeed I completely missed this PR in my search. I am running last tagged version, which is quite old it seems. I will just move to the master branch :)

Actually the npm release is essentially never "behind" master because we use semantic-release to bump version and release on almost every commit. The latest was 20 hours ago: https://www.npmjs.com/package/renovate
If you're seeing the "old" behaviour (incremental commits to existing PR) with a recent renovate version then it sounds like something is wrong.

Also, in that PR I used term rebase but now I'm thinking "squash" would have been much better

Actually, I followed these instructions so I am in sync with an old master branch I think. I will update and let you know!

ok, I got it. I'll close this then, please reopen if you don't see the behaviour you expect.

Sure, thanks!


[BEAM-4745, BEAM-4016] Reintroduces Setup and TearDown on SplitRestrictionFn and PairWithRestrictionFn

This should be safe now, after a Dataflow worker release that is more correctly shaded and picks up fresh versions of this code.

Run Dataflow ValidatesRunner

Run Java Precommit


Prevent deadlock in webapp

Fixes https://github.com/get10101/10101/issues/1938.
There was definitely a deadlock here, so I'm closing optimistically closing #1938, as this may be the only deadlock.
Probably didn't need to bother with the repro, but it was a fun exercise.
Thanks for spotting it, @Restioson!

Hey, @maxcountryman! We found the source of one deadlock. This does not necessarily settle our argument on async vs blocking locks here, but I wanted to keep you up to date anyway :D

One more thing I noticed here: I believe you're awaiting the join handle of the task: this can lead to zombie processes depending on how the app is run. You may want to pass that handle to a graceful shutdown handler and abort it in a signal. We've added that to the examples that use continuous deletion a while back.


Kubernetes Deployment - "privileged: true" Security Context - Runs on Docker instead Hypercontainer

Below container i am using in my kubernetes deployment file:
containers:
- name: bbva
image: bbvainnotech/kvm:latest
imagePullPolicy: Always
stdin: true
tty: true
env:
- name: AUTO_ATTACH
value: "yes"
securityContext:
privileged: true
If i use "privileged: true" i think its not running on Hypercontainer it automatically runs on "Docker" runtime.
I didn't used "OSContainer: "true" annotation in my kubernets file still it runs on docker!

@harshapic yep, privileged containers are running in docker instead of hypercontainer. This is expected behavior.

I'm closing this since this is the expected behavior.


Front opt merge

Overall dev merge

Codecov Report

Merging #103 (b742f6c) into development (f019383) will increase coverage by 0.27%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #103      +/-   ##
===============================================
+ Coverage        61.38%   61.66%   +0.27%
===============================================
  Files               24       19       -5
  Lines              259      253       -6
  Branches            24       23       -1
===============================================
- Hits               159      156       -3
+ Misses              83       81       -2
+ Partials            17       16       -1

Impacted Files
Coverage Δ

backend/models/content.js
69.23% <0.00%> (-5.77%)
:arrow_down:

backend/controllers/authentication.js
15.00% <0.00%> (-3.75%)
:arrow_down:

backend/auth/auth.js
31.03% <0.00%> (-3.59%)
:arrow_down:

backend/models/user.js
68.00% <0.00%> (-1.57%)
:arrow_down:

backend/utils/db.js
55.17% <0.00%> (-0.39%)
:arrow_down:

backend/controllers/authorization.js
50.00% <0.00%> (ø)

frontend/src/reportWebVitals.js

frontend/src/setupProxy.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469d953...b742f6c. Read the comment docs.

Codecov Report

Merging #103 (b742f6c) into development (f019383) will increase coverage by 0.27%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #103      +/-   ##
===============================================
+ Coverage        61.38%   61.66%   +0.27%
===============================================
  Files               24       19       -5
  Lines              259      253       -6
  Branches            24       23       -1
===============================================
- Hits               159      156       -3
+ Misses              83       81       -2
+ Partials            17       16       -1

Impacted Files
Coverage Δ

backend/models/content.js
69.23% <0.00%> (-5.77%)
:arrow_down:

backend/controllers/authentication.js
15.00% <0.00%> (-3.75%)
:arrow_down:

backend/auth/auth.js
31.03% <0.00%> (-3.59%)
:arrow_down:

backend/models/user.js
68.00% <0.00%> (-1.57%)
:arrow_down:

backend/utils/db.js
55.17% <0.00%> (-0.39%)
:arrow_down:

backend/controllers/authorization.js
50.00% <0.00%> (ø)

frontend/src/reportWebVitals.js

frontend/src/setupProxy.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469d953...b742f6c. Read the comment docs.


iOS13.0/13.1 debugging stuck at "Installing and launching..."

mac:10.15.2
iphone x:13.3.1
Logs:
flutter run -v
(17D50)/Symbols/System" "/private/var/containers/Bundle/Application/444E0654-EDDC-4DDB-9FB3-8AC1788657B4" "/Volumes/data/app/Fluttery_first/flutter_app/build/ios/iphoneos"
"/var/containers/Bundle/Application/444E0654-EDDC-4DDB-9FB3-8AC1788657B4" "/Volumes/data/app/Fluttery_first/flutter_app/build/ios/iphoneos" /Developer "/Users/dev/Library/Developer/Xcode/iOS DeviceSupport/13.3.1
(17D50)/Symbols/Developer"
[  +21 ms] (lldb)     command script import "/tmp/05757ED0-39B6-4628-985D-3236FC689ACF/fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.py"
[   +6 ms] (lldb)     command script add -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.connect_command connect
[        ] (lldb)     command script add -s asynchronous -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.run_command run
[        ] (lldb)     command script add -s asynchronous -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.autoexit_command autoexit
[        ] (lldb)     command script add -s asynchronous -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.safequit_command safequit
[        ] (lldb)     connect
[  +27 ms] (lldb)     run
[+1206 ms] success
[        ] (lldb)     safequit
[ +203 ms] Application launched on the device. Waiting for observatory port.
[   +7 ms] Attempting to forward device port 56233 to host port 1024
[        ] executing: /Volumes/data/Soft/flutter/bin/cache/artifacts/usbmuxd/iproxy 1024 56233 aad6996b29c1a53f9532320436bf1dfe28e11018
[+1012 ms] Forwarded port ForwardedPort HOST:1024 to DEVICE:56233
[  +12 ms] HttpException: Connection closed before full header was received, uri = http://localhost:1024/ws
[+2008 ms] HttpException: , uri = http://localhost:1024/ws
[+2008 ms] HttpException: , uri = http://localhost:1024/ws
[+2005 ms] HttpException: , uri = http://localhost:1024/ws
[+2009 ms] HttpException: , uri = http://localhost:1024/ws
[+2006 ms] Failed to connect directly, falling back to mDNS
[   +5 ms] Checking for advertised Dart observatories...
[+5021 ms] No pointer records found.
[   +1 ms] mDNS query failed. Checking for an interface with a ipv4 link local address.
[   +2 ms] Found interface "en0":
[        ]      Bound address: "<IP_ADDRESS>"
[        ] Found interface "vnic0":
[        ]      Bound address: "<IP_ADDRESS>"
[        ] Found interface "vnic1":
[        ]      Bound address: "<IP_ADDRESS>"
[        ] Found interface "vnic2":
[        ]      Bound address: "<IP_ADDRESS>"
[        ] Found interface "utun2":
[        ]      Bound address: "<IP_ADDRESS>"
[        ] Found interface "en9":
[        ]      Bound address: "<IP_ADDRESS>" link local
[        ] Found interface "bridge100":
[        ]      Bound address: "<IP_ADDRESS>"
[        ] An interface with an ipv4 link local address was found.
[        ] Failed to connect with mDNS, falling back to log scanning

flutter doctor -v
[✓] Flutter (Channel dev, v1.15.19, on Mac OS X 10.15.2 19C57, locale zh-Hans-CN)
    • Flutter version 1.15.19 at /Volumes/data/Soft/flutter
    • Framework revision 60d0fef17a (21 hours ago), 2020-03-09 22:07:34 -0700
    • Engine revision 0e2c8feeeb
    • Dart version 2.8.0 (build 2.8.0-dev.12.0 9983424a3c)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/dev/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[!] IntelliJ IDEA Ultimate Edition (version 2019.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.42.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • iPhone • aad6996b29c1a53f9532320436bf1dfe28e11018 • ios • iOS 13.3.1

! Doctor found issues in 1 category.

Duplicate #41335

Hi @mycode65678
as @JosepBove pointed out there are issues [1, 2]
that address the problem you describe and offer several solutions
https://github.com/flutter/flutter/issues/41335#issuecomment-573483477
https://github.com/flutter/flutter/issues/41335#issuecomment-585554998
https://github.com/flutter/flutter/issues/43570#issuecomment-550367862
does any of those work for you?
thank you

嗨@ mycode65678
作为@JosepBove指出有问题[ 1，2 ]
该地址你描述并提供了多种解决方案的问题
＃41335（评论）
＃41335（评论）
＃43570（评论）
做任何对你的工作？
谢谢

I tried it and it didn't work

Now stuck here won't continue
[        ] Starting debug of aad6996b29c1a53f9532320436bf1dfe28e11018 (D22AP, iPhone X, iphoneos, arm64) a.k.a. 'iPhone' connected through USB...
[+1993 ms] [  0%] Looking up developer disk image
[  +17 ms] [ 95%] Developer disk image mounted successfully
[+1446 ms] [100%] Connecting to remote debug server
[        ] -------------------------
[ +326 ms] (lldb) command source -s 0 '/tmp/FA65BBAE-E7C4-4DB0-A8C0-A8858731775F/fruitstrap-lldb-prep-cmds-aad6996b29c1a53f9532320436bf1dfe28e11018'
[        ] Executing commands in '/tmp/FA65BBAE-E7C4-4DB0-A8C0-A8858731775F/fruitstrap-lldb-prep-cmds-aad6996b29c1a53f9532320436bf1dfe28e11018'.
[        ] (lldb)     platform select remote-ios --sysroot '/Users/dev/Library/Developer/Xcode/iOS DeviceSupport/13.3.1 (17D50)/Symbols'
[        ]   Platform: remote-ios
[        ]  Connected: no
[        ]   SDK Path: "/Users/dev/Library/Developer/Xcode/iOS DeviceSupport/13.3.1 (17D50)/Symbols"
[        ] (lldb)     target create "/Volumes/data/app/Fluttery_first/flutter_app/build/ios/iphoneos/Runner.app"
[+5178 ms] Current executable set to '/Volumes/data/app/Fluttery_first/flutter_app/build/ios/iphoneos/Runner.app' (arm64).
[        ] (lldb)     script fruitstrap_device_app="/private/var/containers/Bundle/Application/D5E5ECCD-7E34-4E13-B314-854913944647/Runner.app"
[ +377 ms] (lldb)     script fruitstrap_connect_url="connect://<IP_ADDRESS>:53041"
[        ] (lldb)     script fruitstrap_output_path=""
[        ] (lldb)     script fruitstrap_error_path=""
[        ] (lldb)     target modules search-paths add /usr "/Users/dev/Library/Developer/Xcode/iOS DeviceSupport/13.3.1 (17D50)/Symbols/usr" /System "/Users/dev/Library/Developer/Xcode/iOS DeviceSupport/13.3.1
(17D50)/Symbols/System" "/private/var/containers/Bundle/Application/D5E5ECCD-7E34-4E13-B314-854913944647" "/Volumes/data/app/Fluttery_first/flutter_app/build/ios/iphoneos"
"/var/containers/Bundle/Application/D5E5ECCD-7E34-4E13-B314-854913944647" "/Volumes/data/app/Fluttery_first/flutter_app/build/ios/iphoneos" /Developer "/Users/dev/Library/Developer/Xcode/iOS DeviceSupport/13.3.1
(17D50)/Symbols/Developer"
[  +21 ms] (lldb)     command script import "/tmp/FA65BBAE-E7C4-4DB0-A8C0-A8858731775F/fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.py"
[   +5 ms] (lldb)     command script add -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.connect_command connect
[        ] (lldb)     command script add -s asynchronous -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.run_command run
[        ] (lldb)     command script add -s asynchronous -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.autoexit_command autoexit
[        ] (lldb)     command script add -s asynchronous -f fruitstrap_aad6996b29c1a53f9532320436bf1dfe28e11018.safequit_command safequit
[        ] (lldb)     connect
[  +38 ms] (lldb)     run
[ +397 ms] success
[        ] (lldb)     safequit
[ +126 ms] Process 6478 detached
[  +62 ms] Application launched on the device. Waiting for observatory port.
[   +4 ms] Checking for advertised Dart observatories...
[+5016 ms] No pointer records found.
[   +2 ms] mDNS lookup failed, attempting fallback to reading device log.
[        ] Waiting for observatory port.

HI @mycode65678
given the error  Failed to connect with mDNS, falling back to log scanning
are you located in china?
If so could you check if you double check your vpn and this docs
Thank you

Hi @mycode65678
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore
reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any
more information for us; we will reopen it right away!
Thanks for your contribution.

I had the same problem then I fixed it by disabling the firewall on my macOS Catalina.


gotosocial: skip more flakey tests

golang 1.21.8 introduced some minor test suite breakages in gotosocial. Skip these tests for now. See: https://github.com/superseriousbusiness/gotosocial/pull/2760
Will manually backport to https://github.com/NixOS/nixpkgs/pull/295584 to unblock 0.14.2 being updated in NixOS 23.11.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 296069 run on x86_64-linux 1

1 package built:

gotosocial


"-f bestaudio" downloads vorbis@128k when opus@160k is available

Checklist

[?] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.05.20
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-f', 'bestaudio', 'https://www.youtube.com/watch?v=SYRlTISvjww']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.05.20
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-93886-gfbdb3aa179, ffprobe N-93886-gfbdb3aa179
[debug] Proxy map: {}
[youtube] SYRlTISvjww: Downloading webpage
[youtube] SYRlTISvjww: Downloading video info webpage
[youtube] {18} signature length 42.43, html5 player vflFo4HCs
[youtube] {137} signature length 42.43, html5 player vflFo4HCs
[youtube] {248} signature length 42.43, html5 player vflFo4HCs
[youtube] {136} signature length 42.43, html5 player vflFo4HCs
[youtube] {247} signature length 42.43, html5 player vflFo4HCs
[youtube] {135} signature length 42.43, html5 player vflFo4HCs
[youtube] {244} signature length 42.43, html5 player vflFo4HCs
[youtube] {134} signature length 42.43, html5 player vflFo4HCs
[youtube] {243} signature length 42.43, html5 player vflFo4HCs
[youtube] {133} signature length 42.41, html5 player vflFo4HCs
[youtube] SYRlTISvjww: Downloading player https://www.youtube.com/yts/jsbin/player_ias-vflFo4HCs/en_US/base.js
[youtube] {242} signature length 42.43, html5 player vflFo4HCs
[youtube] {160} signature length 42.43, html5 player vflFo4HCs
[youtube] {278} signature length 42.43, html5 player vflFo4HCs
[youtube] {140} signature length 42.43, html5 player vflFo4HCs
[youtube] {171} signature length 42.43, html5 player vflFo4HCs
[youtube] {249} signature length 42.43, html5 player vflFo4HCs
[youtube] {250} signature length 42.43, html5 player vflFo4HCs
[youtube] {251} signature length 42.43, html5 player vflFo4HCs
[debug] Invoking downloader on 'https://r1---sn-q4flrnel.googlevideo.com/videoplayback?id=o-AAIF4FuzADn9H4vWDxwV9HGBRhe5geYWHGR7dGWXKhFr&itag=171&source=youtube&requiressl=yes&mm=31%2C26&mn=sn-q4flrnel%2Csn-5ualdn7r&ms=au%2Conr&mv=m&pl=42&ei=bVfjXJvCJIK5iwTtk5DQCQ&initcwndbps=1067500&mime=audio%2Fwebm&gir=yes&clen=4360584&dur=268.664&lmt=1540151762175749&mt=1558402850&fvip=1&keepalive=yes&c=WEB&txp=5411222&ip=2600%3A1702%3A1dc1%3A82c0%3Abdec%3Abfd5%3A7401%3Abcd7&ipbits=0&expire=1558424525&sparams=ip%2Cipbits%2Cexpire%2Cid%2Citag%2Csource%2Crequiressl%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cei%2Cinitcwndbps%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&key=yt8&signature=52D61277C3DD65915C42BE72196FB4E03F5A7F38.7C169560EE684A2817F95681C5FB2A04D505829C&ratebypass=yes'
[download] Destination: Uptime Funk - (Uptown Funk parody)-SYRlTISvjww.webm
[download] 100% of 4.16MiB in 00:06

Description

I am trying to download https://www.youtube.com/watch?v=SYRlTISvjww with -f bestaudio. However, this downloads the inferior vorbis@128k track even though an opus&160k track is available, as evidenced by -F https://www.youtube.com/watch?v=SYRlTISvjww

Actual reported bitrate per metadata of 171 is higher that 251.


tf.rnn.contrib ops missing in Java API

I am trying to run an LSTM built with the Python API, exported to to protobuf, and evaluated in Java. After I updated my python scripts to use tf.contrib.rnn.LSTMBlockCell, LSTMBlockFusedCell, etc cell implementations, the Java portion stopped working and started throwing:
org.tensorflow.TensorFlowException: org.tensorflow.TensorFlowException: Op type not registered 'BlockLSTM' in binary running on xubuntu. Make sure the Op and Kernel are registered in the binary running in this process.

and
org.tensorflow.TensorFlowException: org.tensorflow.TensorFlowException: Op type not registered 'LSTMBlockCell' in binary running on xubuntu. Make sure the Op and Kernel are registered in the binary running in this process.

Evaluating the graph in Python works swimmingly. I didn't see anything on stack overflow. There are a couple tickets on github which might be related: #11847 and #12566
TF Version (Java and python): 1.3.0
Python Version: 2.7

Unfortunately, operations compiled into their own shared library (which happens with operations in contrib) are not yet loadable in Java.
We will be making that possible, but no concrete timeline just yet.
I'm closing this as a duplicate of #10454 - the workaround there (which requires building from source) and will post updates there.
Thanks!


Initialize framework

Need to add a button to the configuration module to initialize everything that isn't done automatically.  Should be temporary since there is a way to do everything we need to automatically.

I've already done this but want to test it more before committing.  Putting the issue so I don't forget about it.


Request on a Fetch method.

Hi, in the ajax part is there a way to trigger the fetch method after a period of time, so i can performed the instagram effect, fadeIn out on each image after x mins / sec.

There is a new version of the library, get it from the releases page, maybe you can try with the complete option. Check the documentation. Thanks.


Impossible to hide navigation arrows

I tried to implement a Swiper in my app.
I works but navigations arrows are displayed. I haven't activate any option for that. How can I hide them ?
My html file ...
<swiper>

Toto

</swiper>

My Angular informations ...
Angular CLI: 9.0.1
Node: 12.15.0
OS: darwin x64

Angular: 9.0.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.1
@angular-devkit/build-angular     0.900.1
@angular-devkit/build-optimizer   0.900.1
@angular-devkit/build-webpack     0.900.1
@angular-devkit/core              9.0.1
@angular-devkit/schematics        9.0.1
@angular/cdk                      8.2.3
@angular/cli                      9.0.1
@ngtools/webpack                  9.0.1
@schematics/angular               9.0.1
@schematics/update                0.900.1
rxjs                              6.5.4
typescript                        3.7.5

the problem is [hiden], which is { display: none} is not active..
A easy way to solve this, in the component css, use following style
:host ::ng-deep [hidden] { display: none !important }

Got the same issue here. The solution provided by @LILU-WEB works for me.

ng-deep is not supported anymore

same issue.
Angular 10
<EMAIL_ADDRESS>

Can I fix this?

Will be fixed in the coming 10.0.0 release (should be out next weekend at the latest).


Dialog action buttons order

Could you please implement something for changing action buttons order? At least swapping positive and negative ones?
Of course, I could fork your lib and implement it myself, but that's a useful feature for the origin, isn't it?

I don't think that's necessary or a good idea since that doesn't follow the Material guidelines

#DGBN


Replay Finetuning & store as GGML

Hi
I have been trying to redo TinyLlama finetuning starting from PY007/TinyLlama-1.1B-intermediate-step-480k-1T using both finetuning.py and using the last command from script.sh.
I used one A100 40G (using only 27GB of VRAM). Everything went well apparently.
I just added:
final_model="path to last checkpoint"

tokenizer = AutoTokenizer.from_pretrained(final_model)

model = model = AutoModelForCausalLM.from_pretrained(
        final_model,
        device_map="auto",
        trust_remote_code=True,
    )

model.save_pretrained("TinyLlama-1.1B-chat-hf")
tokenizer.save_pretrained("TinyLlama-1.1B-chat-hf")

Then I tried to convert the model to a GGML format using convert.py from llama.cpp
!python convert.py <path to TinyLlama-1.1B-chat-hf>
This lead to the following error:
Loading model file <path to TinyLlama-1.1B-chat-hf/pytorch_model.bin>
params = Params(n_vocab=32003, n_embd=2048, n_layer=22, n_ctx=2048, n_ff=5632, n_head=32, n_head_kv=4, f_norm_eps=1e-05, f_rope_freq_base=10000.0, f_rope_scale=None, ftype=None, path_model=PosixPath('/content/drive/MyDrive/TinyLlama/TinyLlama/sft/TinyLlama-1.1B-chat-hf'))
Loading vocab file '/content/drive/MyDrive/TinyLlama/TinyLlama/sft/TinyLlama-1.1B-chat-hf/tokenizer.model', type 'spm'
Traceback (most recent call last):
  File "/content/drive/MyDrive/TinyLlama/llama.cpp/convert.py", line 1193, in <module>
    main()
  File "/content/drive/MyDrive/TinyLlama/llama.cpp/convert.py", line 1175, in main
    vocab = load_vocab(vocab_dir, args.vocabtype)
  File "/content/drive/MyDrive/TinyLlama/llama.cpp/convert.py", line 1086, in load_vocab
    return SentencePieceVocab(path, added_tokens_path if added_tokens_path.exists() else None)
  File "/content/drive/MyDrive/TinyLlama/llama.cpp/convert.py", line 372, in __init__
    raise Exception(f"Expected added token IDs to be sequential and start at {len(added_tokens)}; got {actual_ids}")
Exception: Expected added token IDs to be sequential and start at 6; got [0, 1, 2, 32000, 32001, 32002]

Any idea what I am doing wrong ?
Some more info contained in related files:
special_tokens_map.json
{
  "additional_special_tokens": [
    "<unk>",
    "<s>",
    "</s>",
    "[PAD]",
    "<|im_end|>",
    "<|im_start|>"
  ],
  "bos_token": "<s>",
  "eos_token": "</s>",
  "pad_token": "[PAD]",
  "unk_token": "<unk>"
}

added_tokens.json
{
  "</s>": 2,
  "<s>": 1,
  "<unk>": 0,
  "<|im_end|>": 32001,
  "<|im_start|>": 32002,
  "[PAD]": 32000
}

Those files are slightly different from what can be found in PY007/TinyLlama-1.1B-Chat-v0.3 and I don't understand why.

Hi, as for this bug, I think it is because that in llama.cpp they will find the tokens in added_tokens.json and put them into SentencePiece Vocabulary. However, because </s>, <s>, <unk> have already in the original vocabulary which comes from tokenizer.model, they will raise an error if the added tokens id does not start from vocab_size. You can rewrite the added_token.json as
{
  "<|im_end|>": 32001,
  "<|im_start|>": 32002,
  "[PAD]": 32000
}

Perhaps it could work by this way? If there is still something wrong. I will test it tmr.


Consider logmonitoring in the node-selector check

Description
DAQ-2191
Enhances the check previously removed in https://github.com/Dynatrace/dynatrace-operator/pull/4109

With the caveat, that we use theapiUrl for checking if DynaKubes use the same tenant

this is not perfect, because of tenant aliases, but it is considered misconfiguration to use a tenant alias for 1 DynaKube and not for another one.

How the nodeSelector validation changed:

2 CloudNative (or any OneAgent) on same node with different tenant ==> ⛔  (this is not new)
2 LogMonitoring on same node with different tenant ==> 🆗
1 LogMonitoring and 1 CloudNative(or any OneAgent) on same node with different tenant ==> 🆗

How can this be tested?
Try recreating the scenarios from the unit-tests

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.57%. Comparing base (087d461) to head (5d433a1).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4    #4124      +/-   ##
===============================================
+ Coverage        64.50%   64.57%   +0.07%
===============================================
  Files              400      400
  Lines            26758    26766       +8
===============================================
+ Hits             17259    17284      +25
+ Misses            8146     8126      -20
- Partials          1353     1356       +3

Flag
Coverage Δ

unittests
64.57% <100.00%> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.