gateway performance issues

Hi, authors of Spring Gateway, I have a problem that bothers me a lot. When I route through the gateway to a Spring Boot service interface on two 4U,8G and Centos8 virtual machines, the performance has not been improved. I removed any business logic, empty load test. Used WRK tool for pressure test. QPS has been around 3000. Pressure tester is also 4U, 8G configuration.
Number of threads and concurrency and time for WRK: WRK-T8-C400-d30S
I would like to ask if the Gateway has any configuration items that can be optimized? I look forward to hearing from you

Nothing specific. You've not given any details about how you have configured gateway and what the downstream service looks like.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Sort targets in documentation. Fixes #1524.

Should be a simple but effective fix for #1524. Assume sort command is available.

r? @gnzlbg
(rust_highfive has picked a reviewer for you, use r? to override)

:pushpin: Commit<PHONE_NUMBER>ce3b12490007377322747e8f6421aa has been approved by gnzlbg

:hourglass: Testing commit<PHONE_NUMBER>ce3b12490007377322747e8f6421aa with merge bc5c15efd06c72802c5d9d3499842147d5e823bc...

Thanks, this is exactly what I had in mind.

:sunny: Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing bc5c15efd06c72802c5d9d3499842147d5e823bc to master...

@gnzlbg I also don't like unsorted random lists.
But the list at https://rust-lang.github.io/libc/#platform-specific-documentation seems not quite sorted. Does it take some time till the new documentation get pushed?
Because as far as i understand this list is generated form the master Branch. My PR is now merged into master. So this list should be now sorted or?

It should just work, but apparently it stopped working 2 months ago: https://github.com/rust-lang/libc/tree/gh-pages (last time that was updated).
The job for this is indeed running: https://github.com/rust-lang/libc/blob/master/ci/azure.yml#L132
But apparently the deploy to github pages is being skipped: https://dev.azure.com/rust-lang2/libc/_build/results?buildId=501
@pietroalbini do you have any idea of what might be going on ?

But apparently the deploy to github pages is being skipped: https://dev.azure.com/rust-lang2/libc/_build/results?buildId=501

Ok, so the problem is that these run in the auto-libc branch, but the deployment only happens for master.

I've added a new pipeline that should build master: https://dev.azure.com/rust-lang2/libc/_build?definitionId=7

@senden9 thanks, look: https://rust-lang.github.io/libc/#platform-specific-documentation now everything shows up sorted!

Nice :D.
I see mipsel-unknown-linux-gnu is two times in the list. See screenshot.

Should I fix that i another PR by checking for doubles in the list or do you want to fix that problem on another level?

#1557 should fix it

Good. Found just in that moment the same lines that you edited.


CI: nightly test failed when upgrading from stable to latest

Build link: https://jenkins.cilium.io/job/Cilium-Master-Nightly-Tests-All/172/testReport/
Relevant output:
Stacktrace

/home/jenkins/workspace/Cilium-Master-Nightly-Tests-All/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:227
Cilium image didn't update correctly
Expected
    <string>: cilium/cilium:latest
to equal
    <string>: cilium/cilium:stable
/home/jenkins/workspace/Cilium-Master-Nightly-Tests-All/src/github.com/cilium/cilium/test/k8sT/Nightly.go:390

Logs:
test_results_Cilium-Master-Nightly-Tests-All_172.tar.zip

Fixed by https://github.com/cilium/cilium/pull/3590#event-1567118418

@eloycoto awesome, thanks! Closing.


Nodes are not running

Pulled the latest Docker image, ran it with the recommended command, and looking at the memsql-ops panel, the nodes are either not connected or are not running. There are no errors on stdout/stderr either.
*** Running /etc/my_init.d/00_regen_ssh_host_keys.sh...
*** Running /etc/rc.local...
*** Booting runit daemon...
*** Runit started as PID 10
Sep 30 01:57:49 9bc9aa92b6ee syslog-ng[17]: syslog-ng starting up; version='3.5.3'

Did you run it by mounting a volume?  We have a bug in the current iteration that causes it to fail when the volume is mounted via nfs (for example if you are running the quickstart container on a mac in boot2docker or docker-machine).  We have a fix for this that will be on our docs tomorrow.  For the time being either don't use a volume (for testing) or use another container (as a data container) for the volume.  For example:
docker create --name memsql_data memsql/quickstart /bin/true
docker run -d --name memsql -p 3306:3306 -p 9000:9000 --volumes-from memsql_data memsql/quickstart

I'm running on a Mac with docker-machine. Not using any volume or using another container results in the same issue. I'll check back tomorrow

Interesting - thanks for the update.
The first thing I am curious about is why you have 3 MemSQL nodes in the attached screenshot.  Our docker-quickstart container only includes two MemSQL nodes so it seems that you launched a third.
Also, can you use docker exec to access the instance and check the memsql logs?  For example:
~ $ docker run -d --name memsql -p 3306:3306 -p 9000:9000 memsql/quickstart
0aa3eee01a9483c4475b3e28b68ed014bc79bdf7a3968da369394a4aeca997df
~ $ docker exec -it memsql /bin/bash
root@0aa3eee01a94:/# cd /memsql/master/tracelogs
root@0aa3eee01a94:/memsql/master/tracelogs# cat memsql.log
64 2015-09-27 20:05:42 INFO: Log opened
...

If the logs are empty also check the MemSQL Ops logs at /memsql-ops/memsql-ops.log.

Also, can you pull down /latest again? I just pushed a version with some tweaks to it.

Ah looks like here's the problem:
79 2015-09-30 16:20:46 INFO: Log opened
00700676 2015-09-30 16:20:47  INFO: Initializing Open SSL
00702005 2015-09-30 16:20:47  INFO: MemSQL version hash: f8b720e1ac467b30e2b96f7fd250820bc1a2aca5 (Wed Sep 23 21:57:54 2015 +0000)
00895516 2015-09-30 16:20:47  INFO: ./memsqld: ready for connections.
00895562 2015-09-30 16:20:47  INFO: Version:  '4.1'  Edition:  'community'  Socket:  '/memsql-ops/installs/master-3306/data/memsql.sock'  Port:  '3306'
00896697 2015-09-30 16:20:47  INFO: System Information: sockets (1), physical cores (8), virtual cores (8), model name (Intel(R) Core(TM) i7-3635QM CPU @ 2.40GHz), memory<PHONE_NUMBER>), uname (Linux 2338b11efbe1 4.0.9-boot2docker #1 SMP Thu Aug 13 03:05:44 UTC 2015 x86_64)
01053411 2015-09-30 16:20:48  INFO: starting up with aggregator id 0
01053522 2015-09-30 16:20:48  INFO: Setting aggregator id to 1
01056470 2015-09-30 16:20:48  INFO: Master aggregator has started with ID=1
01056666 2015-09-30 16:20:48  INFO: Completed recovery of system databases.  Beginning recovery of user databases.
01057750 2015-09-30 16:20:48  INFO: Used cluster capacity: 7179, Maximum cluster capacity:<PHONE_NUMBER>3709551615
03253246 2015-09-30 16:20:50  INFO: Adding new leaf node root@<IP_ADDRESS>:3307
03606419 2015-09-30 16:20:50  INFO: New node 2 (<IP_ADDRESS>:3307)
03645656 2015-09-30 16:20:50  WARN: ReplicationMaster[sharding]: Sync slave '<IP_ADDRESS>:3307/sharding' got synchronized with master 'sharding'.
03791715 2015-09-30 16:20:50  INFO: Done Adding new leaf node root@<IP_ADDRESS>:3307
35 2015-10-01 02:45:22 INFO: Log opened
00000065 2015-10-01 02:45:22 FATAL: This machine does not have enough CPU cores to run MemSQL. The minimum required number is 4, and this machine has 1 cores

I was able to increase the amount of CPUs on my docker host and everything seems to be working now.

And yes, I tried adding a third node before.

Ah, good find!  I am updating our check-system script which is included with memsql/quickstart to include a core check in order to make this easier to debug.

I ran into what might be this issue again on Mac OS X.
Digging into the docker's logs, I found
2015-11-27 16:22:31,080 [ERROR] memsql_platform.jobs.engine: Failed to execute job: Failed to start MemSQL: This machine does not have enough CPU cores to run MemSQL. The minimum required number is 4, and this machine has 1 cores

The system check was successful.

Increasing the docker-machine's CPU count to 4 solved this.


Made changes updated read me

Updated
This is some great text please review and accept.

Thoughts
How does this look 👍


invalid mount config for type "bind": bind source path does not exist: /data/swirl

Hello,
I am doing a swarm deployment of Swirl. My swirl tasks get rejected with this message: invalid mount config for type "bind": bind source path does not exist: /data/swirl using the following compose.yml.
version: '3.3'
services:
  manager_agent:
    image: cuigh/socat:latest
    volumes:
     - /var/run/docker.sock:/var/run/docker.sock
    networks:
     - default
    logging:
      driver: json-file
    deploy:
      mode: global
      placement:
        constraints:
         - node.role == manager
  mongo-express:
    image: mongo-express:latest
    environment:
      ME_CONFIG_MONGODB_URL: mongodb://mongodb:27017/
    ports:
     - 7081:8081
    networks:
     - default
    logging:
      driver: json-file
  mongodb:
    image: mongo:latest
    networks:
     - default
    logging:
      driver: json-file
  swirl:
    image: cuigh/swirl:latest
    environment:
      AGENTS: swirl_manager_agent,swirl_worker_agent
      DB_ADDRESS: mongodb://mongodb:27017/swirl
      DB_TYPE: mongo
      DOCKER_ENDPOINT: tcp://swirl_manager_agent:2375
    ports:
     - 8001:8001
    networks:
     - default
    logging:
      driver: json-file
    deploy:
      placement:
        constraints:
         - node.role == worker
  worker_agent:
    image: cuigh/socat:latest
    volumes:
     - /var/run/docker.sock:/var/run/docker.sock
    networks:
     - default
    logging:
      driver: json-file
    deploy:
      mode: global
      placement:
        constraints:
         - node.role == worker
networks:
  default:
    driver: overlay

I also noticed there are no clear instructions on how to supply database credentials, am I going to be prompted for those in the UI once I get it running?
Thank you very much.

I also noticed there are no clear instructions on how to supply database credentials, am I going to be prompted for those in the UI once I get it running?

You can configure database authentication information through the connection string of the database:
https://www.mongodb.com/docs/manual/reference/connection-string/
For example: mongodb://{user}:{password}@mongodb:27017/swirl?authSource=admin

Will do, do you have some insight into what the mount config error is? I'm not binding anything like that in this compose  yaml.

It's weird. This error looks like DB_ TYPE option is set to bolt, which means Swirl did not read the environment variables you set in composite.yml file.

I tried to set the database to bolt just to get something working first. I'm getting panic: failed to load storage engine: failed to open bolt database: open /data/swirl/swirl.db: no such file or directory. Again, here is the compose.yml:
version: '3.8'

services:
  swirl:
    image: cuigh/swirl
    environment:
      DB_TYPE: bolt
      DB_ADDRESS: /data/swirl
      # DB_ADDRESS: mongodb://root:example@mongo:27017/swirl?authSource=admin
      DOCKER_ENDPOINT: tcp://swirl_manager_agent:2375
      AGENTS: swirl_manager_agent,swirl_worker_agent
    networks:
      - net
    depends_on:
      - mongo
    ports:
      - "8001:8001"
    deploy:
      replicas: 1
      placement:
        constraints: [ node.role == manager ]

  manager_agent:
    image: cuigh/socat
    networks:
      - net
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    deploy:
      mode: global
      placement:
        constraints: [ node.role == manager ]

  worker_agent:
    image: cuigh/socat
    networks:
      - net
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    deploy:
      mode: global
      placement:
        constraints: [ node.role == manager ]

networks:
  host:
    external: true
  net:

I would be happy to try to create it manually and bind it into the docker container, but I don't know the file name, you'd have to tell me the correct bolt.Open call.
I will be happy to do a pull request with compose files that work out-of-the-box for both supported databases, provided that I get them to work.

I tried to set the database to bolt just to get something working first. I'm getting panic: failed to load storage engine: failed to open bolt database: open /data/swirl/swirl.db: no such file or directory in the swirl_swirl service. Again, here is the compose.yml:
version: '3.8'

services:
  swirl:
    image: cuigh/swirl
    environment:
      DB_TYPE: bolt
      DB_ADDRESS: /data/swirl
      DOCKER_ENDPOINT: tcp://swirl_manager_agent:2375
      AGENTS: swirl_manager_agent,swirl_worker_agent
    networks:
      - net

volumes:
  - /Users/xxx/data/swirl:/data/swirl

Mount a volume to swirl service and ensure /Users/xxx/data/swirl already exists.

I managed to spin up swirl with bolt thanks to you. In the meantime I realized I can't run mongo because of hardware limitations on the cluster. I will eventually try to get it working too, but for now I will just use this. Thank you once again and have a nice day!


Long page names overflow their container in explorer menu in Safari 9

Issue Summary
Initially reported by @jjanssen in #3645. Page names that wrap to a second/third line overflow their container, in both Mobile Safari iOS 9 and (desktop) Safari 9.1 (works in version 10.1).

Related to: https://github.com/philipwalton/flexbugs#1-minimum-content-sizing-of-flex-items-not-honored
Steps to Reproduce

Create a page with a long title (100+ chars, create it at the "Homepage" level to get to it faster).
Add children to the page so the  > caret is displayed in its menu item.
Open the pages explorer menu and navigate to the location of this page in the page tree.

Technical details

Latest Wagtail / 1.11 RC
Mobile Safari iOS 9 and (desktop) Safari 9.1

Edit: I spent about half an hour playing with every variation of layout properties I could think of, to no effect. Unless I've missed something obvious (further attempts welcome), I'd probably opt to rebuild this __link component without Flexbox.

Testing this in with Safari in an iPhone 6s (iOS 9) emulator, the page name looks exactly as I would expect -- the same as it does using Firefox on a desktop.
Am I missing something or has this already been patched?

Hi @kapito,
This has not been fixed just yet. Unless it happened by accident 😄  I'd suggest maybe using the exact example from the issue: "This is a test to determine how a page will look with an extremely long title, and this should be long enough or should I go on a little longer to be sure?"
We are using BrowserStack as well.

@jjanssen Ah, my bad -- I didn't create any children pages when I tested it. I'll see if I can find a fix :)

I'm closing this due the release of Safari 11 for OSX and iOS. According to our browser support we only support the last 2 versions.


Considering to extend CSS with PostCSS

There are a few features that are not yet supported by default. Today, we encountered an issue with the rgba() method. By default, CSS does not support rgba(#hexcode, opacityValue). Therefore, we need to convert the #HEX to RGB colours.
However, we can avoid the need to convert #HEX to RGB colours by utilizing PostCSS or CSS preprocessors. These tools provide additional functionality and support for rgba() with #HEX and opacity values.
However, I do not want to just implement a tool without investigating the pros and cons between them. We should also wait for @mimarz to be back from holidays.
With the small research I have already done, I think PostCSS looks great - modular and small.

If the UX/UI can use another color palette instead of opacity, then we do not need to support RGBA within our CSS.

Related to https://github.com/digdir/designsystem/issues/606

We should not fix this with PostCSS as its to "late" in the pipeline as the changes would only apply to the react package. This would leave out our users who are using the tokens directly.
Changes to color unit would needs to be done in the token transformation step. Style dictionary and Token studio already have transformers for this feature.


Gridview filter dropdown

Hello,
On my index page, I have a GridView widget, using an ActiveDataProvider object (from ->search() )
So I don't have any model object.
So, I did a bit of 'hack' to get the full list of statues:
$model = MyModel::find()->one();
	$allStatuses = WorkflowHelper::getAllStatusListData(
	 	$model->getWorkflow()->getId(),
	 	$model->getWorkflowSource()
	);

GridView::widget([
	'dataProvider' => $dataProvider,
	'filterModel' => $searchModel,
	'columns'=>[
		[
			'attribute' => 'status',
			'filter' =>$allStatuses,
		]
]
]);

Is there a better way to generate the dropdown filter menu that this?
Thanks

Hi,
given a workflow Id, one option could be to directly get the list of all statuses from the workflowSource component (which wouldn't force to read a model from the DB). However this would be possible only if you're sure that MyModel is only associated with only one workflow, and that you know the ID of this workflow.
By default the workflowSource component has name "workflowSource".
Once you have a reference to the workflowSource just call getAllStatuses (see workflowHelper for example)
Hope it helps

Thanks that works well:
	$worflowSource = Yii::$app->get('workflowSource');

	$allStatuses = WorkflowHelper::getAllStatusListData(
	 	'MyWorkflow',
	 	$worflowSource
	);


[QA] Wilderness P2E scene missing at (-24, 92)

Explorer Alpha build versions:

v0.13.0

Issue Description:
In the Wilderness P2E scene at coordinates (-24, 92), the scene itself is missing. Only certain UI elements, such as icons for Twitter, Discord, and other in-game interfaces, are visible and interactive. The main scene content does not render.
STR:

Launch the explorer
Use /goto -24,92 command on chat
Observe the absence of the main scene content.

Expected behavior:

Current behavior:

Additional Notes:
Windows 11. 12th Gen Intel(R) Core(TM) i7-12650H 2.30 GHz. nvidia geforce RTX

Closing in favor of #1757


Filter by name

Is it possible now or in the future to scan device but instead of filtering by UUID, doing it by name or with a prefix ?
I know we can do that with Web BLE.

It is possible to do so as long as advertisement data send from your devices includes "Complete Local Name" or "Shortened Local Name". You can see that value in localName property of your scanned device object. There is no way to filter that in one API call, so you have to code that part manually in scanning callback.

Ok thanks for the clarification.


[C++] Fix message id error if messages were sent to a partitioned topic

Motivation
If messages were sent to a partitioned topic, the message id's partition field was always -1 because SendReceipt command only contains ledger id and entry id.
Modifications

Add a partition field to ProducerImpl and set the MessageId's partition field with it in ackReceived method later.
Add a test to check message id in send callback if messages were sent to a partitioned topic.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as BasicEndToEndTest.testSendCallback.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Thanks @BewareMyPower for the fix.

Motivation
If messages were sent to a partitioned topic, the message id's partition field was always -1 because SendReceipt command only contains ledger id and entry id.
Modifications

Add a partition field to ProducerImpl and set the MessageId's partition field with it in ackReceived method later.
Add a test to check message id in send callback if messages were sent to a partitioned topic.


[celery] upgrading celery

What changes were proposed in this pull request?

celery 5.2.3 requires setuptools<59.7.0,>=59.1.1 and these versions have CVE-2022-40897 hence we are upgrading celery to 5.2.7 (latest)

For testing, you can create a Py3 cluster using a build having this package change and checking if Hue is working fine in it or not.

For testing, you can create a Py3 cluster using a build having this package change and checking if Hue is working fine in it or not.

Yes, I have checked it locally, working fine. and I am checking it on jenkins as well.

@ranade1 @amitsrivastava
I have upgraded the virtualenv also as it was restricting setuptools to 65.3.0.


Working with windows

Sorry new to stuff like this, but a bit lost on how to make this work on windows? Most of "how-tos" seems to be using make - instead of just running a main.py file instead - didn't know if there way a to force this to run like that or not?

I'm going to close this ticket as part of cleanups for the next release, but please re-open if you have any questions!


Fix the garbled code in different languages

relation:https://github.com/wintercms/wn-docs-plugin/pull/17

Replaces #17

Thanks heaps @wpjscc!


[BUG] helm-operation pod uses incorrect taint for RKE2 Control Plane/etcd nodes, blocking provisioning

Rancher Server Setup

Rancher version: 2.8.5
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): Rancher runs on EKS, issue is with a downstream RKE2 cluster.

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.27.14-rke2r1
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Infrastructure Provider, OpenStack

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions: Admin

Describe the bug
As part of cluster provisioning, Rancher installs the rancher-webhook chart on to the downstream cluster. This appears to be a critical dependency which is performed after the etcd/control plane nodes have been bootstrapped, but before any worker nodes are allowed to be brought in - the provisioning log is stuck on the "waiting for control plane to be available" step. Therefore, if the install operation for rancher-webhook fails (or hangs indefinitely as in this case, since the pod is forever pending), no workers will be brought in.
A helm-operation pod is spawned to install the webhook chart. This pod has the following tolerations;
Tolerations:     cattle.io/os=linux:NoSchedule
                 node-role.kubernetes.io/controlplane=true:NoSchedule
                 node-role.kubernetes.io/etcd=true:NoExecute
                 node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule
                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                 node.kubernetes.io/unreachable:NoExecute op=Exists for 300s

While these tolerations are correct for RKE1, they are not correct for RKE2. Specifically;

Control Plane nodes have a hyphen in control-plane and no value, i.e. node-role.kubernetes.io/control-plane:NoSchedule.
etcd nodes have no value, i.e. node-role.kubernetes.io/etcd:NoExecute.

As a result, if provisioning an RKE2 cluster with dedicated control plane, etcd and worker pools the cluster will fail to initialise as the helm-operation pod cannot be scheduled on the control plane or etcd nodes (since the tolerations don't match the taints) and it can't run on the worker nodes either (as provisioning the webhook blocks the next step of cluster provisioning, i.e. the control plane being considered ready and thus bringing in worker nodes).
These tolerations are hardcoded here. As far as I can tell, there is no way that I, as an end user, can override them.
To fix this issue, while maintaining RKE1 compatibility, I suggest that the following changes should be made;

Add an additional NoSchedule toleration for node-role.kubernetes.io/control-plane (i.e. with the hyphen), but with no value and an operator of exists (as RKE2 does not set a value for this taint).
Modify the existing NoExecute toleration for node-role.kubernetes.io/etcd to have no value and an operator of exists (which will still match the "true" value on RKE1, as well as the no-value in RKE2)

To Reproduce
Provision an RKE2 cluster, on any infrastructure provider, with dedicated Control Plane, etcd and Worker Node pools.
Result
Expected Result
The helm-operation pod starts successfully, and thus the cluster provisions successfully.
Screenshots
N/A
Additional context

A comment was left on the original commit that hardcoded the tolerations, noting that this does not work for RKE2.
Discussions on the implications of making RKE1 align to the Kubernetes standard for this taint.

Yes, we are also started to observe that. A fresh Rancher 2.8.5 cluster and entirely new rke2 1.28.10. And it was not like that... Dont known where that comes from.
Did anyone found some solution to this ?

Did anyone found some solution to this ?

Not a solution, but a workaround - i'm setting the control plane nodepool to also have the worker role, then adding a custom PreferNoSchedule taint on it. This allows the helm-operation pods to schedule on it, and unblock provisioning.
It's not ideal though, as it means other pods can still land on the control plane nodes if there are no other available nodes. I want to keep the control plane as free as possible from non-control plane pods so this is a bit of a pain still.

Temporary workaround:
---
apiVersion: provisioning.cattle.io/v1
kind: Cluster
metadata:
  labels:
  name: ${CLUSTER_NAME}
  namespace: fleet-default
spec:
  agentEnvVars:
    # Enable debug logs
    - name: CATTLE_AGENT_LOGLEVEL
      value: 'debug'
    - name: RKE2_DEBUG
      value: 'TRUE'
    # Enable API audit logging
    - name: RKE2_AUDIT_POLICY_FILE
      value: '/etc/rancher/rke2/audit-policy.yaml'
    # Customize Pod Security Admission config file
    - name: RKE2_POD_SECURITY_ADMISSION_CONFIG_FILE
      value: '/etc/rancher/rke2/rancher-psact.yaml'
  cloudCredentialSecretName: cattle-global-data:${DC8_NAME}
  clusterAgentDeploymentCustomization:
    appendTolerations:
      - key: CriticalAddonsOnly
        operator: Exists
      - key: node-role.kubernetes.io/etcd
        operator: Exists
      - key: node-role.kubernetes.io/control-plane
        operator: Exists
  fleetAgentDeploymentCustomization:
    appendTolerations:
      - key: CriticalAddonsOnly
        operator: Exists
      - key: node-role.kubernetes.io/etcd
        operator: Exists
      - key: node-role.kubernetes.io/control-plane
        operator: Exists

Note that "control-plane" is the correct form as per upstream docs:
https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-control-plane


[BACKLOG-2253]: ExcelWriter: cell background goes completely black when editing a cell that has been formatted

There is a fix that consists of avoiding using CellUtil.setCellStyleProperty() method on POI because of known issue:
https://bz.apache.org/bugzilla/show_bug.cgi?id=56548.

@deinspanjer
Hi, Please review the fix.


Test diagnosability improvements

Some improvements to tests that I made while investigating failures for node reuse.

Looks like a good change regardless :)

Added a few more diagnosability improvements I added while investigating failures.

That's a new one:
/Users/dotnet-bot/j/w/Microsoft_msbuild/master/innerloop_OSX10.13_CoreCLR_prtest/artifacts/Debug/bootstrap/netcoreapp2.1/MSBuild/NuGet.targets(104,5): error : The file '/Users/dotnet-bot/j/w/Microsoft_msbuild/master/innerloop_OSX10.13_CoreCLR_prtest/artifacts/2Debug/obj/MSBuild/project.assets.json' already exists. [/Users/dotnet-bot/j/w/Microsoft_msbuild/master/innerloop_OSX10.13_CoreCLR_prtest/src/MSBuild.UnitTests/Microsoft.Build.CommandLine.UnitTests.csproj]

@dotnet-bot test OSX10.13 Build for CoreCLR please

I don't think I touched this:
https://ci2.dot.net/job/Microsoft_msbuild/job/master/job/innerloop_Windows_NT_Full_prtest/279/testReport/junit/Microsoft.Build.UnitTests.GetSDKReferenceFiles_Tests/GetSDKReferenceFilesTestFixture/PassReferenceWithNoReferenceDirectory/
@dotnet-bot test Windows_NT Build for Full please


retain logger instance to actually log things

This is nasty.  I'm open to suggestions but frame logging doesn't work without this.
https://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html#getLogger-java.lang.String-

Yep. What a terrible API that is.

Thanks!


feat(cli): adds db:create and db:drop

:tada: This PR is included in version 1.30.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add simple product time period dataset count page

add dataset period count for products page
add csv download option for products period dataset count

Thanks Pin!
I'm going to adjust the URL offset to fit the other URLs (/audit/product-counts, to match the existing /audit/product-metadata) ... and maybe add a little bit of formatting to the html table (Usually the HTML is optimised for humans and CSV for computers). But looks good.

Thinking about it further, I'm leaning toward using separate year, month, day columns here, as that's what the rest of the APIs we have use (where blank in a column means "all").  I think that's easier to work with in CSVs too, rather than users knowing which parts of the "1900-01-01" style dates to ignore. I'm going to make that change unless you think it'll hurt your use-case. I like consistency too much :)

sure, no worries,


Allow subdomain variations in presentation

Hi, I'm using the presentation editor and it seems I have a use case that is not yet supported.
My project has both languages and markets.
https://<market>.domain.com/<language>/pathname
The languages work fine as they are simple path prefixes. But the markets being subdomains is what causes issues.
When inside the editor and navigating to a specific subdomain, I get many obscure errors that don't provide much relevant context.
I do know it's not a DNS or CORS issue.
Describe the solution you'd like
I think the solution would be to add some more options in the presentationTool() plugin. Perhaps a allowedSubdomains array?
If subdomains are defined, there could be a dropdown in the editor to select them.
Describe alternatives you've considered
I have considered implementing alternate logic to pull market data via URL query params, but that's a bit too hacky to my taste.
Additional context

FYI I opened a similar question with some examples here https://github.com/sanity-io/visual-editing/issues/1280


-fail-on-error doesn't work. reviewdog returns zero as exit code even if warnings are found in input

This is a bug report of -fail-on-error option. Even if warnings are found in input, reviewdog command returns zero as exit code.
  -fail-on-error
    	Returns 1 as exit code if any errors/warnings found in input

How to reproduce

https://github.com/suzuki-shunsuke/test-github-action/pull/146
https://github.com/suzuki-shunsuke/test-github-action/actions/runs/4738975477/jobs/8413381617

$ reviewdog --version
0.14.1

$ tflint -v
TFLint version 0.46.0
+ ruleset.terraform (0.2.2-bundled)

main.tf
// hello

$ tflint --format checkstyle --module
<?xml version="1.0" encoding="UTF-8"?>
<checkstyle>
  <file name="">
    <error rule="terraform_required_version" line="0" column="0" severity="warning" message="terraform "required_version" attribute is required" link="https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.2/docs/rules/terraform_required_version.md"></error>
  </file>
</checkstyle>

$ tflint --format checkstyle --module |
            reviewdog \
              -f checkstyle \
              -name tflint \
              -filter-mode nofilter \
              -reporter github-pr-check \
              -level warning \
              -fail-on-error 1
reviewdog: Reporting results for "tflint"
Warning: [tflint] reported by reviewdog 🐶
terraform "required_version" attribute is required

Raw Output:
:0:0: warning: terraform "required_version" attribute is required ()

$ echo "$?"
0

Expected behaviour
The exit code of reviewdog command is not zero because warning is outputted.
Actual behaviour
The exit code of reviewdog command is zero.

I've been seeing the same thing, the output logs show errors but it doesn't exit 1.  It doesn't even report the error to GitHub.  It doesn't seem to be very consistent.

I had the same issue, so I decided to run vale manually. Here's my workaround steps:
- name: Get latest version of Vale
  id: lastversion
  uses<EMAIL_ADDRESS>  with:
    repository: errata-ai/vale

- name: Install Vale
  run: |
    wget https://github.com/errata-ai/vale/releases/download/v${{ steps.lastversion.outputs.last_version }}/vale_${{ steps.lastversion.outputs.last_version }}_Linux_64-bit.tar.gz -O vale.tar.gz
    tar -xvzf vale.tar.gz vale
    rm vale.tar.gz

- name: Validate the syntax
  run: ./vale --config=.vale.ini *.md

The vale command has the proper exit code, so the workflow will fail or succeed normally.
You can skip the first step, and wget the direct link if you want to use a specific version, instead of using the latest.

Here's an example of how one format reports failure, the other doesn't:
Run with eslint output format:
/path/to/file
  14:3  error  Delete `··`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

  14:3  error  Delete `··`  prettier/prettier
reviewdog: input data has violations
ERROR: "lint:graphql" exited with 1.

Run with rdjson format:
{"source":{"name":"eslint","url":"https://eslint.org/"},"diagnostics":[{"message":"Delete `··`","location":{"path":"/home/dobes/projects/formative/app.fixups/packages/main/src/ui/client/teamMember/commandCenter/sections/ManageOneRosters/ManageOneRoster.graphql","range":{"start":{"line":14,"column":3},"end":{"line":14,"column":5}}},"severity":"ERROR","code":{"value":"prettier/prettier","url":"https://github.com/prettier/eslint-plugin-prettier#options"},"original_output":"{\"ruleId\":\"prettier/prettier\",\"severity\":2,\"message\":\"Delete `··`\",\"line\":14,\"column\":3,\"nodeType\":null,\"messageId\":\"delete\",\"endLine\":14,\"endColumn\":5,\"fix\":{\"range\":[220,222],\"text\":\"\"}}","suggestions":[{"range":{"start":{"line":14,"column":3},"end":{"line":14,"column":5}},"text":""}]}]}
ERROR: "lint:graphql" exited with 1.

Actually, I think my comments above are inaccurate.  I wasn't passing -format rdjson in those cases, so it wasn't parsing the linter output.

Facing the same issue, using errata-ai/vale-action@reviewdog version 3.4.1.


Change Rocket.Chat data path

My Setup

My OS name and version: Windows 10
My current app version: 2.5.0

[x] I have tested with the latest application version
[x] I can simulate the issue easily

Description

Current Behavior

Right now Rocket.Chat for Desktop/Win can only store its data in %APPDATA%
Expected Behavior

It would be nice if user can use some command line option or environment variable or any other means to change Rocket.Chat's data path, eg. to a folder in its program folder.
In short, a portable mode :)
Thanks!

Windows client 2.5.0 -- can't download any file attachments either.  Works fine in browser.  Windows client doesn't do anything when you click a file to download.

Conversely, a portable executable (that uses %APPDATA%) would be nice as well.


Simple API / plugin design

Description of the new feature / enhancement
There are many requests for PowerRename to support features from other utilities, or to support special syntax. Rather than attempting to implement each of these in the core PowerRename Utility, consider an extension methodology that allows custom modules to perform operations based on hooks like pre_rename and post_rename.
Summary
At critical points in this utility, execute a BAT file using a well-defined API, and incorporate the well-defined result from that call into subsequent operations. Take time to think through all of the data that would be useful at each hook point. The better a job that's done on this thinking the less that will need to be done later to accommodate applications.
Detail
For the greatest impact support is required for .NET, NodeJS, Python, or Java. Supporting languages and an API is too difficult and will doom a suggestion like this. This application can implement the functionality by executing a .BAT file at every hook point, and using the results. Developers can do anything they want to get that BAT file to call their application, no matter the language or architecture.
Example: pre_file.BAT (fired before each file)
Contents: foo.exe --regex 1 --from "...." --to "...." --flagx "...." --filename "current_file.ext"
A developer can replace foo.exe with whatever they want.
The return value from the bat should be parsed to derive a new from/to change for the current file. (Use output from a cmd invocation or in the API define a text or JSON structure for return values.)
If the filename has already changed, use that filename as the result. (An enhancement might be added to support a flag which causes the new filename to be used for continued processing.
Another post_file.BAT would allow for conversion, for example, of sequential numeric indices from base10 to hex, or allow a local application to re-index the new filename in a database. It would also allow for logging the name of the --original_filename and the new --new_filename along with information like who did it and the specifications that were used - in case triage is required.
Add a pre_all.BAT and post_all.BAT which might allow a user to log the fact that files were changed, or allow a for pre-copying or zipping all files before a rename.
This can also be used to implement PowerRename for compressed file archives. A high-level pre_app.BAT might decompress a zip or gz or 7z file into a folder and return the name of the folder for PowerRename to operate on. post_app.BAT would allow the developer to compress the folder back into its original form. This application wouldn't need to support that new feature!
Values passed to x_app.BAT need to include the original folder/file selected for renaming. This data can be used for subsequent logging in-context and other operations that are common to an entire run.
Scenario when this would be used?
Any scenario applies that has prompted a change request here for enhancements to the From/To mechanism.
Requests like #4929 are common.

Can we use file creation time sytax or advanced counter syntax along with regex? No. Pre-processing and post-processing can address this without a change to the PowerRename core utility.
Can we append a unique ID other than the default Windows-assigned " (n)? No. Again, custom post-processing can detect an existing file and change the file name before a file is written with its new name.
Can we append a GitHub ticket ID to the end of a document name where the ID is in file metadata? Of course not. We a plugin we can.

Supporting information
Many users have applications that are outside the known scope of the original SmartRename application and the imagination of those who maintain PowerRename. As with any core platform that supports a plugin architecture, we don't know all of the possible scenarios where this utility can or will be used, so rather than everyone here waiting for someone to triage and maybe process requests, this simple API implementation can be used by anyone, and we can turn requests for new features into references to gists, wiki pages, and blogs where solutions have been implemented.
How does a hook know what code to use for a given file or folder?
For the first iteration of this feature I think it would be adequate to suffix the from or to replacement strings with any sytax a developer prefers. For example, if I end a From string with  [[git1]], PowerRename will pass the request to the common BAT file, and my utility will remove that text from the From string and pass the request to the correct utility to process the current request.
A v2 implementation might add a dropdown list of processors to be invoked for the current run for defined hooks, but the intent of this ticket is intended to facilitate implementation without any UI changes at all.
In summary on this : PowerRename does not need to be concerned about this.
Possible arguments against

It will affect performance : Does anyone care?
It's inefficient to execute a BAT file via exec/cmd if there is nothing there to process : Require command-line flags on flags on the PowerRename executable, or a registry entry, or (best) read for files up-front and if they don't exist, don't do the calls.
What if a user-defined process fails? : Not the problem of this application or any platform that supports such an architecture. Timeouts and try/catch can be added but that's overkill for a v1 of this feature.

This sounds pretty cool, @TonyGravagno is this something you would be interested in working on? Maybe even a small proof of concept to get an estimate of effort.


Balance listening

Seems like it's working but I cannot test until faucet starts working again.
Changes:

switched example to westend default
fixed snap to work with westend and kusama in near future (cannot update api because ses issue, cannot interact with public chains with old api, added tmp fix to add missing type definitions)
refactored adapter to expose event based api

Aditional bugfixes:

url in api handler is of type URL and not string as suggested in docs
a lot of places was missing origin in event emitting
handle currency on frontend
network is now switched as expected

@irubido @MakMuftic Your review is expected^^


More cookie fortunes

About the PR

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Over 50 new fortunes can be found in fortune cookie

LGTM after fixing tests


Weird behavior in stateless widget

I tried signals in a stateless widget
The watch is not updating the UI. If I add another watch with the same signal variable, it rebuilds the first one only. Why does this happen, but in the case of StatefulWidget, it's working fine
Scaffold(
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          controller.increment();
          print('incremented counter value: ${controller.counter.value}');
        },
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Watch(
              (context) => Text('You have pushed the button this many times: ${controller.counter.value}'),
            ),
            Watch.builder(
              builder: (context) {
                return Text('test => ${controller.counter.value}');
              }
            ),
            Watch((context) {
              return Text(
                'You have pushed the button this many times: ${controller.counter.value}',
                style: Theme.of(context).textTheme.headlineMedium!,
              );
            }),
          ],
        ),
      ),
    );`
```

    ```
`class CounterController  {

  var counter = signal(0);
  void increment() => counter.value++;
}`
```

it runs when force restart the app,

So the hot reload might be changing the element id, but will see if I can write some tests to validate.
Can you create a minimal example to link to for testing? Or provide the complete code working and non working in the issue?

import 'package:flutter/material.dart';
import 'package:signals/signals_flutter.dart';

import 'counter_controller.dart';

class CounterPage extends StatelessWidget {
  CounterPage({super.key});

  final controller = CounterController();

  @override
  Widget build(BuildContext context) {
    // var state = controller.counter.watch(context);
    print('rebuild state');
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          controller.increment();
        },
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Watch((context) {
              print('rebuild watch controller');
              return Text('You have pushed the button this many times: ${controller.counter}');
            }),
          ],
        ),
      ),
    );
  }
}

import 'package:signals/signals.dart';

class CounterController  {

  var counter = signal(0);

  void increment() => counter.value++;

}

This is the code. If anything changes, then hot reload it. After that, it won't update the UI until I stop and rerun the app
but if i change StatelessWidget to StatefullWidget , its working fine as expected

Looking into it!

And one more thing: if it's working after rerunning the app, when I hot reload again, it loses the state of the signal (e.g., the counter integer resets to its initial state). This behavior doesn't happen in other state management libraries like Riverpod and GetX.
However, in stateful widgets, it's absolutely fine. We need this behavior in stateless widgets too.
I really like the concept of this state management. The primary goal is to spin up the app very quickly, and not using the generator is actually a good move. I'm fed up with Riverpod, Provider, MobX - most of them need to run build_runner to generate their classes. That's why GetX has huge popularity; it's straightforward.

Was able to reproduce, working on the fix!

Fixed on 4.2.1!

It's working fine. But in the case of the stateless widget, it does not persist the state when hot-reload.
I think its a bug because most of the statemanagemnt libs handle this well even in stateless or stateful widgets

@rodydavis  please take a look on to it

That is because it is not created with const or static. If you add the static keyword to the controller declaration it will persist state

how? i cant create signal variable using static or const
can you show me the example?

import 'package:flutter/material.dart';
import 'package:signals/signals_flutter.dart';

import 'counter_controller.dart';

class CounterPage extends StatelessWidget {
  CounterPage({super.key});

-  final controller = CounterController();
+  static final controller = CounterController();

  @override
  Widget build(BuildContext context) {
    // var state = controller.counter.watch(context);
    print('rebuild state');
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          controller.increment();
        },
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Watch((context) {
              print('rebuild watch controller');
              return Text('You have pushed the button this many times: ${controller.counter}');
            }),
          ],
        ),
      ),
    );
  }
}

Can you open a new discussion or issue about a CLI or Code Snippets?

yes
On Mon, 12 Feb, 2024, 12:49 pm Rody Davis, @.***> wrote:

Can you open a new discussion or issue about a CLI or Code Snippets?
—
Reply to this email directly, view it on GitHub
https://github.com/rodydavis/signals.dart/issues/155#issuecomment-1938340330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAQO3NW3QJBRBDACYZ4C4LYTHQUJAVCNFSM6AAAAABC5LD6L2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGM2DAMZTGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Remap the char map when lowercasing strings

This PR is related to https://github.com/meilisearch/meilisearch-support/issues/1 and creates a test with a string making, producing a panic. The issue is due to the standard Rust lowercase function not recomputing the char map because it is stated that a lowercase doesn't change the size of the character when, in fact, it does (stackoverflow), e.g. Ɦ gives ɦ, 3 bytes to 2 bytes.

As I am the only one available on the team, I will merge _by hand without approval 🆘


JASM update with new features

What's new

Records
Deprecated attribute
Attributes moved to Attributable interface

What's fixed

Some inconsistent attribute parsing

👍 for new language features supported
Got some design things I'd like to see changed though, as commented above, and auto-format things.


id2wikidata file

Hi there,
where can I find the id2wikidata.json file which is needed in the context_entity_detection/contextEntityRetrieval.py  (line 69)?
d2wikidata = json.load(open("models/id2wikidata.json"))
Thank you in advance,
Ellis

Ah ok it is a file that is loaded from Blink...

Hi Ellis,
yes exactly, the id2wikidata.json file is created automatically by the ELQ dependency we use: https://github.com/facebookresearch/BLINK/blob/main/elq/main_dense.py (line 132). You just need to make sure that you created a directory named "models" inside context_entity_detection.
Best Regards,
Magdalena


Removed support for EOL-versions of PHP and Symfony

Other versions (<7.4) are now End of Life.
MCrypt is deprecated since PHP 7.1 and removed in 7.2, so I removed support for it as well.
Closes #122

@stephanvierkant what about the other symfony/* dependencies? In composer.json for example `"symfony/framework-bundle": "~2.3|~v3.0|~4.0|~5.0|~6.0". i think we can also drop some of the old versions

@stephanvierkant what about the other symfony/* dependencies? In composer.json for example `"symfony/framework-bundle": "~2.3|~v3.0|~4.0|~5.0|~6.0". i think we can also drop some of the old versions

We can do that in another PR as it will require some other clean ups.
@Seldaek are you fine releasing this change (when it's ready) in v2.11?

IMO either wait, clean up all the things and release a 3.0 breaking what needs to be, or release a minimal sf6 support minor version which does not break anything beyond perhaps dropping very old symfony /php

I agree, let's release 2.11.0 with support of Symfony 6 (which was released some time ago) and then we start cleaning things up for a new major version with support of PHP >= 7.4.

@franmomu I agree! Let's release a new minor version. I'll continue with this PR for 3.x

👍🏻 thanks everyone for pushing forward here.

I've rebased to resolve the conflicts and remove support of Twig 1 (it was the one making tests fail).

thanks @stephanvierkant!


Can object_store on 32-bit systems read ranges in 4GB+ files? (Should we use u64 vs usize)

[First, sorry for the flurry of issues and thank you for your responsiveness. Second, I apologize that this issue will be vague and without a repro case.]
Rust's file seek for local files uses u64, not usize. This allows even 32-bit OS to access regions of files beyond 4GB.
object_store's get_range and many related methods use usize. This works fine on a 64-bit OS, but on a 32-bit OS (including WASM32) using HTTP I think limits one to the first 4GB of any file.
Possible fixes:

Limit object_store to 64-bit systems
Change the range related methods to u64.

Thanks,
Carl

I think changing to support u64 would make sense as part of a broader initiative to support wasm32. However, given the crate doesn't support anything other than in memory for wasm32 currently, I think it would be a pretty tough sell given downstream impact of such a change

I was running into this today as well. The axum-range crate returns a Range that's using u64 as ranges, and due to get_ranges in object_store only accepting usize, the conversion is a bit more ugly than necessary.


build  update dependencies

Description
Update dependencies:

build(dependencies): 🧱 update crates
build(dependencies): 🧱 update supply chain vetting

Type of change

[X] Dependency update

How Has This Been Tested?

[X] cargo test run with all tests passing

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.36%. Comparing base (3ad350c) to head (559b515).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   36.36%   36.36%
=======================================
  Files           4        4
  Lines        1166     1166
=======================================
  Hits          424      424
  Misses        742      742

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix issue with ASPNET_ENV always undefinied

Follow aspnet env from IHostingEnviroment interface to node process in prerender and webpack flows.

@SteveSandersonMS merge rc2 migration, please review

I'd be happy to merge this if it's needed, but investigating just now, I wasn't able to repro the original issue (#72). Maybe it's been fixed in .NET Core RC2, or maybe I'm misunderstanding the requrement.
Is the issue that you want the ASPNETCORE_ENVIRONMENT environment variable to be made available in your Node.js code (i.e., as process.env.ASPNETCORE_ENVIRONMENT)? If so, as far as I can tell, that already happens by default, because the Node.js child process gets all the environment variables from the parent process.
I just checked this both on OS X and Windows (and on Windows, both when launching with dotnet run and inside VS/IISExpress). In all cases, I find that all the environment variables, including ASPNETCORE_ENVIRONMENT, are showing up in the Node.js child process.
Can you let me know if I'm misunderstanding the requirement? If not, maybe it was a bug in .NET Core RC1 that was fixed in RC2.

@laskoviymishka, sorry to hassle you, but do you have any thoughts on my questions above? I'll keep things tidy by closing this if there are no further requirements.

Sorry I away from my PC :(
You can close it for now. If I find anything new I just reopen this PR or create new one

OK, thanks for confirming!


Stop key event propagation.

In JupyterLab, key events were bubbling up from inputs to be considered as shortcut keys in the application. This ensures that key presses in inputs stay in inputs.
As an example, this would create a new cell in a notebook in JupyterLab:
import ipywidgets as w
w.Text()

and then pressing a.

CC @SylvainCorlay for review.


Plugin ID mismatch

This plugin cannot be installed via Obsidian community plugin's pannel in Obsidian 1.1.9 in macOS 13.2. The error message is "Plugin ID mismatch".
I look forward to this plugin being really useful in my workflow. Thanks for sharing.

I'm experiencing the same using Obsidian v1.1.12 on Ubuntu 22.04.
Cheers, and thanks for your work Łukasz !

Hi! Thank you for info. Now it should be ok in version 0.6.3

Great, thanks !


Unable to add apps

Environment
Docker
Version
0.10.7
Describe the problem
Unable to add apps to Homarr. Successfully added two, but others refuse to add. No logs are available in the ghcr.io/ajnart/homarr:latest container and as far as I can tell from the docs, there is no way to change log level to provide any, so I apologise but I'm not sure how to debug it.
Additional info
Nothing to screenshot -- click the submit/add button after filling out the form and nothing happens, no error, nothing.
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues
[X] You've tried to debug yourself

Hello @tomlawesome ,
we're sorry that Homarr isn't working for you.
Let's do some investigation to find out why.
Right click on your page > Inspect > Click on "Console" in the developer tools.
Do you see there any red error messages?

Hello @tomlawesome , we're sorry to hear that Homarr isn't working for you. Let's do some investigation to find out why.
Right click on your page > Inspect > Click on "Console" in the developer tools. Do you see there any red error messages?

Thanks for such a quick reply and for the help -- using the inspect feature I was able to determine that there was a connection error to my client, and for some reason this was preventing newly added services to show up at all.
Once I resolved the connection issue to the client, the other services appeared on the homepage.


The logout func causes 404

The logout button has some problems with the href attribute, cuz the base path of  the target website has been omitted. It caused 404, just like the image shows:

The same problem occurs when I reach the logout confirmation page.

Hi, thanks for reaching out.
Please follow the issue template.

Describe the bug(Actual behavior)
I have more than one app run in the same server, so I need to change the context path of the Kafka-UI.
But when I changed the configuration "server.servlet.context-path" in the file "application.yml"(you can refer the first page of the screenshots), it worked with the back-end, but not with the front-end. I can't find any way to do the same change with the front-end.
What I have changed caused several problems as below:

The CSS stylesheet lost when I open the login page.
The logout func navigates to 404 page.

Expected behavior
I can logout without any problem.
Set up
How do you run the app? Please provide as much info as possible.

App version: v0.5.0(027d9b4)
Helm chart version, if you use one
Any IAAC configs

Steps to Reproduce

change the "application.yml" configuration, modify the "server.servlet.context-path" into "/kafka_prod"
restart the app
add the context path when you login the Kafka-UI

Screeshots

Thanks. Looks like it's been resolved within #3206.
Considering that you're running a jar file, you have to build one on master since we build jars just for the release versions.
Let me know if you need help building a master jar, or I can do that for you.

Thanks for your reply. I'll try to build the project by myself. Btw, what is the java version used in this project ?

@JiepingLi 17
https://provectus.gitbook.io/kafka-ui/development/building/prerequisites

What should I do to change the base path of the project?
I tried to change the env "SERVER_SERVLET_CONTEXT_PATH", it worked at the first step which means I can jump to the logout page correctly, but if I clicked the "Log Out" button at the logout page, it still navigated to 404.
Is there any thing wrong about what I have done to change the base path?
I think maybe I should change the baseUrl of the front-end too, but I'm not really good at React, so I can't find a good way to make it.

@Haarolean
Version: v0.5.0(027d9b4)
Type of authentication: LOGIN_FORM
Redirected to URL: http://<IP_ADDRESS>:30001/logout

@JiepingLi I mean it's the same URL in your URL tab, how can it be 404?..

@Haarolean
Sorry for mislead you, I have token the wrong screenshot for this problem.

When I clicked the Log out button, it navigate to http://<IP_ADDRESS>:30001/logout, which cause 404.
And then I added the context path "kafka_shanglv_prod", the final url is "http://<IP_ADDRESS>:30001/kafka_shanglv_prod/logout", then it showed the following page:

Running this compose:
  kafka-ui:
    container_name: kafka-ui
    image: provectuslabs/kafka-ui:master
    ports:
      - 8080:8080
    depends_on:
      - kafka0
      - schema-registry0
      - kafka-connect0
    environment:
      // the rest omitted
      AUTH_TYPE: "LOGIN_FORM"
      SPRING_SECURITY_USER_NAME: admin
      SPRING_SECURITY_USER_PASSWORD: pass
      SERVER_SERVLET_CONTEXT_PATH: /kafkaui

The logout URL is valid:


Scan package pipelines fails to scan single file

A scan_package with https://repo1.maven.org/maven2/com/github/librepdf/openpdf-parent/1.3.11/openpdf-parent-1.3.11.pom  will NOT scan the file at all, and results are empty.

Code is ready at https://github.com/nexB/scancode.io/pull/1031 but blocked by https://github.com/nexB/purldb/issues/263

Implemented in https://github.com/nexB/scancode.io/pull/1031


XmlFilelistsTest.java:38-42: This test only creates a...

The puzzle 84-f98fbe90 from #84 has to be resolved:
https://github.com/artipie/rpm-adapter/blob/319f59902602559d29450c83141ec583fb71106c/src/test/java/com/artipie/rpm/meta/XmlFilelistsTest.java#L38-L42
The puzzle was created by Victor Noël on 11-Apr-20.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@g4s8/z please, pay attention to this issue

The job #107 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@paulodamaso/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

The puzzle 84-f98fbe90 has disappeared from the source code, that's why I closed this issue.

@sereshqua/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat quality good


UI Tests

Get familiar with application
Application : https://open-physiology-viewer-tgbugs.surge.sh/

Instructions to load model:

Download json model from here https://raw.githubusercontent.com/MetaCell/apinatomy-models/metacell-models-update/models/dev-layout-conn/source/dev-layout-conn.json
Load model by following instructions in this video. here.

Linked to this trello card in the QA Board -> https://trello.com/c/De4bEohM


Possible "broken" URLs in FIBO PROD literals

The attached table collects 500+ triples from FIBO PROD (commit: dbdd526) where the object value is a URL that possibly does not refer (any more).
fibo_prod_possibly_broken_urls_dbdd526.xlsx
The check for these is not 100% precise, e.g., the links from the https://www.ffiec.gov domain like https://www.ffiec.gov/npw/Help/InstitutionTypes or https://www.ffiec.gov/nicpubweb/Content/DataDownload/NPW Data Dictionary.pdf, are classified as 403 although you can access them via a web browser.
For a great deal of other cases, but not for all of them, the 'http' schema should be updated to the 'https'.

@merelog - also per our conversation on the FIBO DER telecon, please exclude all of the ones that are identified in the MarketsIndividuals ontology in FBC - they are provided by ISO and so we have no control over what they claim is the website of the exchange or other market participant.

@merelog - after discussion on the FIBO DER telecon this afternoon, we think you should exclude 403 errors. We did a spot check on those, and they resolved via a browser, as you mentioned, so that "doesn't count" as broken.

I would advise that we might check what url the browser resolves, e.g., when you sent http://www.otcmarkets.com you are being redirected to https://www.otcmarkets.com, so you can interpret some of these 403s as warnings for updates in the schema.


Implement Qdrift as ProductFormula

Summary
This pull request implements the QDrift method of Trotterization as a product formula and fixes Issue #7218.
Details and comments
The implementation is virtually the same as in https://github.com/Qiskit/qiskit-terra/blob/main/qiskit/opflow/evolutions/trotterizations/qdrift.py with the only change being that
self.sampled_ops = algorithm_globals.random.choice(
            np.array(scaled_ops, dtype=object),
            size=(int(N * self.reps),), p=weights / lambd,
        )

becomes
self.sampled_ops = algorithm_globals.random.choice(
            np.array(scaled_ops, dtype=object),
            size=(int(np.ceil(N * self.reps)),),
            p=weights / lambd,
        )

to make sure that the sample size is always at least 1 and because N is chosen to satisfy an error bound, so the former int(N * self.reps) would not have been strictly correct in some instances.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

40 of 44 (90.91%)  changed or added relevant lines in 4 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.007%) to 82.554%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/synthesis/evolution/suzuki_trotter.py
1
2
50.0%

qiskit/synthesis/evolution/qdrift.py
37
40
92.5%

Files with Coverage Reduction
New Missed Lines
%

qiskit/synthesis/evolution/lie_trotter.py
1
96.15%

qiskit/synthesis/evolution/suzuki_trotter.py
3
91.49%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
49871

Relevant Lines:
60410

💛  - Coveralls

I originally had this as automerge (trying to get things merged before the Monday/Tuesday rush), but then I realised that @dlasecki had never actually commented on whether the algorithm does exactly what it's supposed to.  I don't know enough about this particular expansion to approve that properly, so I'll wait for Dariusz to give his tick as well before merging.

@anedumla I added a functional test to see if it works as expected and had to change the num_gates to an int (I think in the paper they use an int too).


start example fail

按照readme启动example时，执行flutter run 失败。报错如下 ：
../lib/src/gesture/scroll_position_with_single_context.dart:37:7: Error: The non-abstract class 'ScrollPositionWithSingleContext' is missing implementations for these members:

ViewportOffset.hasPixels
Try to either
provide an implementation,
inherit an implementation from a superclass or mixin,
mark the class as abstract, or
provide a 'noSuchMethod' implementation.

class ScrollPositionWithSingleContext extends ScrollPosition implements ScrollActivityDelegate {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../flutter/packages/flutter/lib/src/rendering/viewport_offset.dart:96:12: Context: 'ViewportOffset.hasPixels' is defined here.
bool get hasPixels;
^^^^^^^^^
FAILURE: Build failed with an exception.

Where:
Script '/Users/chenzefeng/Development/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 991

What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command '/Users/chenzefeng/Development/flutter/bin/flutter'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 14s

需要 flutter 1.22 以上版本

Flutter version in the kraken/pubspec.yaml

安装后报错：
E/DartVM  (29022): vm-service: Error: Unhandled exception:
E/DartVM  (29022): WebSocketException: Invalid WebSocket upgrade request
E/DartVM  (29022):
E/flutter (29022): [ERROR:flutter/runtime/dart_isolate.cc(882)] Unhandled exception:
E/flutter (29022): WebSocketException: Invalid WebSocket upgrade request
Error connecting to the service protocol: failed to connect to
http://<IP_ADDRESS>:55543/ufXtD_4_LD0=/

重新安装下指定版本的 Flutter

flutter 的版本已经切到1.22.0了

Flutter 2.0.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 4d7946a68d (4 days ago) • 2021-03-18 17:24:33 -0700
Engine • revision 3459eb2436
Tools • Dart 2.12.2

同样的错误

flutter 2.0 现在还不支持，请切换到 1.22.4 版本


resolve tooltip and label overlay issue (#4583)

Pull request opened by the merge tool on behalf of #4583

Merged in d661150cf9f765ba7ea181678a1206fb2ffe7585


Update specs2-cats, specs2-core to 4.12.4-js-ec

Updates

org.specs2:specs2-cats
org.specs2:specs2-core

from 4.6.0 to 4.12.4-js-ec.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2" } ]

labels: library-update, semver-minor

Superseded by #162.


Verify Fence Agent CLI Output

Don't expose FA command as it might include privileged credentials that an attacker can manipulate and abuse. Instead we expose node identifier to differentiate between log outputs of different FAR CRs.
Support only reboot action - we always build the FA command with  reboot action, and we raise a warning when a different action was requested.
Check fence agent CLI output - Error and expected success output

ECOPROJECT-1323

E2E test is expected to fail as we don't support reboot action in E2E. Hopefully with the merge of #20 the E2E test could be tested.
/hold

/retest

/retest

/lgtm

/retest


added a new university

@kbeksss I am sorry, it's impossible to add this domain to the repository. There is a relationship between this domain and owners of losrios.edu domain, which is blacklisted. The domain of Los Rios is blacklisted because the colleges of the system allow to register an email address there even if you are not a student of the college. If you are the student of this college, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Change logo and name

Need to change page title to “CGDN: Canadian Geoscience Data Network” (not GSIP) and remove GIN logo; will need some long-term plan here to distinguish between IOW and CGDN
suggest grab NGSC logo from [https://www.geologicalsurveys.ca/]

Done 51ab70bcf8e17d0f2aa94c931d74b78ca8b1fc42


[Storybook][File Sharing] Update file sharing for Teams Interop scenario

What

Why

How Tested

Process & policy checklist

[x] I have updated the project documentation to reflect my changes if necessary.
[x] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

All the changes look good. Just think we should be a little more specific with the messaging saying file sharing only works one way for now from Teams -> ACS

Yeah, we have mentioned one sentence there:
 <Description>
        At this time, the UI library only facilitates File Sharing in a Teams Interop chat sent by the Teams user. To
        utilize this feature, you can employ the `CallWithChat` composite.
</Description>


Convert all input/output amounts to decimal strings

The Issue
Building on top of https://github.com/lbryio/lbry/pull/1436 - continue fixing amounts everywhere they are used in the wallet/sdk to be uniform decimal strings. @eukreign is aware of this issue.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Does https://github.com/lbryio/lbry/pull/1508 take care of all the required work for this ticket?

@eukreign, still seeing issues on wallet_send:
{"jsonrpc":"2.0","method":"wallet_send","params":{"claim_id":"7d3ae777a9afc0430e33d66c4932c40f41784269","amount":"0.1"},"id":1539122815431}
      "builtins.ValueError: Invalid value for 'amount': ",
      "Decimal inputs require a value in the ones place and in the tenths place",
      "separated by a period. The value provided, '10000000', is not of the correct",
      "format.",

@eukreign - the bid shows as dewies in the publish logs too :
2018-10-10 11:46:47,907 INFO     lbrynet.daemon.Daemon:2329: Publish: {'name': 'test22', 'file_path': 'C:\\Users\\thoma\\Desktop\\31bee797cf27cd6b958094ce07121ab8e45746cc8de97124d4684b5696104b28.jpg', 'bid': 10000000, 'claim_address': None, 'change_address': None, 'claim_dict': {'version': '_0_0_1', 'claimType': 'streamType', 'stream': {'metadata': {'title': 'test2', 'nsfw': False, 'license': 'None', 'licenseUrl': '', 'language': 'en', 'thumbnail': '', 'version': '_0_1_0'}, 'version': '_0_0_1'}}, 'channel_id': '', 'channel_name': None}

Key fee payments also show incorrectly:
2018-10-11 17:24:44,424 INFO     lbrynet.daemon.Downloader:137: Pay key fee 400000000.000000 --> bXJ3x47ZfUkHXouAyruo9Vgape65wSqoQZ

All of the mentioned issues above have been resolved.


AAD app auth

Resolves #175

Potentially superseded by #212 depending on what we decide

decided on v1 auth (#212 ) based on no azapi call


Support cloud

built-in milvus pipes support cloud
disable op check
Signed-off-by: junjiejiangjjj<EMAIL_ADDRESS>

/lgtm


Yes, you may be worried about the damn hard PA2, the Exercises and the Finals, but here is one thing...

You've came that far. Give yourself a clap.
You have done the following throughout this entire course:

[x] 6 self-practice exercises
[x] 6 lab sessions
[x] 1 medium-scale project
[x] 2 practical examinations
[x] 2 ungraded exercises (which I got a C and E for)
Total: 20 exercises in CodeCrunch, plus 11 recitations.

Pretty soon what looms after you for this course is the Final written exam, so I wish you all the best.
Also see #720.
You after PA2 (including me)

As a bonus, here's one tip for Exercise 6
Pass CompletableFutures around, use the thenApply or thenCompose methods and only call .join() at the end.

thanks Hao Dong

Thanks Hao Dong for giving consistant tips on the forum.

thanks hao dong!

nah its over change course

bruh

Thank you Hao Dong for your service!

thank you!

thanks hao dong

thank u brother

thank you Hao Dong!

thank you bro!

Thank you Haodong!

Thank you Hao Dong. Your tips have been extremely helpful for my revision.

Thank you ZHD1987E😍😍

thank you!

thanks hao dong

thanks hao dong

Thanks hao dong

thank you haodong

thanks so much hao dong!

thank you!! :D

Thank you!

thank you!

thank you!!

thanks bro

Triple bonus

love u haodong


Improve error message on module parsing

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Error message now (example):
F1019 12:19:24.281334   28900 clusterloader.go:379] Test compilation failed: [error flattening module steps: erorr while processing module api.Module{Steps:[]*api.Step(nil)}: decoding failed: error converting YAML to JSON: yaml: line 15: mapping values are not allowed in this context]

Error message after this PR (example):
F1019 12:21:40.998204   29714 clusterloader.go:379] Test compilation failed: [error flattening module steps: error while processing module modules/benchmark-deployment.yaml: decoding failed: error converting YAML to JSON: yaml: line 15: mapping values are not allowed in this context]

Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
/assign @jkaniuk

/lgtm
Just wondering: is it better than changing default serialization of module?

/hold
to wait for response

module api.Module, which is currently printed, does not contain any meaningful information. This PR uses moduleRef *api.ModuleRef instead. moduleRef.Path is probably sufficient here, as the error message comes with the exact line number of the problematic expression.
But it does not hurt to print entire moduleRef object. I applied the requested change. Example error message:
F1019 15:14:40.165657   51954 clusterloader.go:379] Test compilation failed: [error flattening module steps: error while processing module &api.ModuleRef{Path:"/modules/services.yaml", Params:map[string]interface {}{"actionName":"Create", "largeBackendLbServiceCount":2, "mediumBackendLbServiceCount":2, "smallBackendLbServiceCount":2}}: decoding failed: error converting YAML to JSON: yaml: line 12: mapping values are not allowed in this context]

/assign @mborsz

/lgtm
/approve

/unhold


[BUG] merge_metaphlan_tables.py errors on inputs with >4 header rows

Describe the bug
Upon running the script (e.g. merge_metaphlan_tables.py profile1.txt profile2.txt -o output.txt), I get the following error.
RuntimeError.
  warnings.warn(msg)
Traceback (most recent call last):
  File "merge_metaphlan_tables.py", line 84, in <module>
    main()
  File "merge_metaphlan_tables.py", line 78, in main
    merge(args.aistms, sys.stdout)
  File "merge_metaphlan_tables.py", line 46, in merge
    names = names,
UnboundLocalError: local variable 'names' referenced before assignment

I see that the variable names is defined conditionally in merge_metaphlan_tables.py on the length of a list of header rows (starting with "#"), but the conditions only cover a length of 1 or 4.  My input files have 5 header rows as follows:
$ head profile1.txt
#mpa_v30_CHOCOPhlAn_201901
#/path/to/miniconda3/envs/metaphlan3.0/bin/metaphlan /path/to/HMP_data/metaphlan3/sample1_un.fastq --input_type fastq --bowtie2db /path/to/database/metaphlan -t rel_ab_w_read_stats
#SampleID	Metaphlan_Analysis
#estimated_reads_mapped_to_known_clades:4265712
#clade_name	clade_taxid	relative_abundance	coverage	estimated_number_of_reads_from_the_clade
UNKNOWN	-1	65.25005	-	8009736
k__Bacteria	2	34.74995	1.97289	4265712
k__Bacteria|p__Firmicutes	2|1239	13.75146	0.78072	1569658
k__Bacteria|p__Proteobacteria	2|1224	13.44175	0.76314	1620281
k__Bacteria|p__Fusobacteria	2|32066	6.16249	0.34987	849835

To Reproduce

Activate metaphlan3.0 environment
run merge_metaphlan_tables.py profile1.txt profile2.txt -o output.txt where the input files have headers as described above

Platform (please complete the following information):

metaphlan version 3.0
Download source: conda

Additional context
This may be related to issue #98.  I tried changing line 31 to if len(headers) >= 4: and it runs without error on my test data, but I'm not sure what other implications this may have.

Which build have you installed?

Francesco Beghini
PhD Student
Lab. of Computational Metagenomics
Department of Cellular, Computational and Integrative Biology - CIBIO
University of Trento
Via Sommarive 9, 38123 Trento, Italy
Il Mar 7 Lug 2020, 18:49 Bari Ballew<EMAIL_ADDRESS>ha scritto:

Describe the bug
Upon running the script (e.g. merge_metaphlan_tables.py profile1.txt
profile2.txt -o output.txt), I get the following error.
RuntimeError.
warnings.warn(msg)
Traceback (most recent call last):
File "merge_metaphlan_tables.py", line 84, in
main()
File "merge_metaphlan_tables.py", line 78, in main
merge(args.aistms, sys.stdout)
File "merge_metaphlan_tables.py", line 46, in merge
names = names,
UnboundLocalError: local variable 'names' referenced before assignment
I see that the variable names is defined conditionally in
merge_metaphlan_tables.py on the length of a list of header rows
(starting with "#"), but the conditions only cover a length of 1 or 4. My
input files have 5 header rows as follows:
$ head profile1.txt
#mpa_v30_CHOCOPhlAn_201901
#/path/to/miniconda3/envs/metaphlan3.0/bin/metaphlan /path/to/HMP_data/metaphlan3/sample1_un.fastq --input_type fastq --bowtie2db /path/to/database/metaphlan -t rel_ab_w_read_stats
#SampleID	Metaphlan_Analysis
#estimated_reads_mapped_to_known_clades:4265712
#clade_name	clade_taxid	relative_abundance	coverage	estimated_number_of_reads_from_the_clade
UNKNOWN	-1	65.25005	-	8009736
k__Bacteria	2	34.74995	1.97289	4265712
k__Bacteria|p__Firmicutes	2|1239	13.75146	0.78072	1569658
k__Bacteria|p__Proteobacteria	2|1224	13.44175	0.76314	1620281
k__Bacteria|p__Fusobacteria	2|32066	6.16249	0.34987	849835
To Reproduce

Activate metaphlan3.0 environment
run merge_metaphlan_tables.py profile1.txt profile2.txt -o output.txt
where the input files have headers as described above

Platform (please complete the following information):

metaphlan version 3.0
Download source: conda

Additional context
This may be related to issue #98
https://github.com/biobakery/MetaPhlAn/issues/98. I tried changing line
31 to if len(headers) >= 4: and it runs without error on my test data,
but I'm not sure what other implications this may have.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biobakery/MetaPhlAn/issues/113, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGKRKP6QK2PA7J3KVEREITR2NG2NANCNFSM4OTAVQZQ
.

$ metaphlan --version
MetaPhlAn version 3.0 (25 Feb 2020)

The build you have installed is an older one still affected by this bug, the latest one is metaphlan-3.0.1-pyh5ca1d4c_0. Can you try update metaphlan using conda install metaphlan=3.0.1?

Thank you @fbeghini!  I'll keep an eye out for a new build on conda.

Hi @fbeghini - I tried running this same analysis with metaphlan-3.0.1-pyh5ca1d4c_0, and received the same error message as for 3.0.  Not sure if you just haven't gotten around to pushing a fix yet.  Thanks again!

No, still not pushed a new build, but the script in the repo is updated, if you want to replace.
I'll push a new build probably in the next days, the database installation function need to be updated.

Hello,
I am still getting this error after updating the merge_metaphlan_tables.py script:
Traceback (most recent call last):   File "merge_metaphlan_tables.py", line 10, in <module>     sys.exit(main())   File "merge_metaphlan_tables.py", line 78, in main     merge(args.aistms, sys.stdout)   File "merge_metaphlan_tables.py", line 46, in merge     names = names, UnboundLocalError: local variable 'names' referenced before assignment
I'm running MetaPhlAn version 3.0 (20 Mar 2020)

Hello,
I am receiving the same error as @bballew:
Traceback (most recent call last):
File "merge_metaphlan_tables.py", line 84, in
main()
File "merge_metaphlan_tables.py", line 78, in main
merge(args.aistms, sys.stdout)
File "merge_metaphlan_tables.py", line 46, in merge
names = names,
UnboundLocalError: local variable 'names' referenced before assignment
It seems like this was fixed in previous versions, but I am using the script from what looks like the most recent version (https://github.com/biobakery/MetaPhlAn/blob/master/metaphlan/utils/merge_metaphlan_tables.py). Is there a different location I could download from to stop receiving this error?

Hello,
I am receiving the same error as @bballew:
Traceback (most recent call last):
File "merge_metaphlan_tables.py", line 84, in
main()
File "merge_metaphlan_tables.py", line 78, in main
merge(args.aistms, sys.stdout)
File "merge_metaphlan_tables.py", line 46, in merge
names = names,
UnboundLocalError: local variable 'names' referenced before assignment
It seems like this was fixed in previous versions, but I am using the script from what looks like the most recent version (https://github.com/biobakery/MetaPhlAn/blob/master/metaphlan/utils/merge_metaphlan_tables.py). Is there a different location I could download from to stop receiving this error?
Hi @fdavis2022, can you upload here the files you are trying to merge?