Release v6.0.0 Stable

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

I'd like to have a solid plan for getting v6 out the door.
TODO
In no particular order.

[x] Simple import from v5 config in package.json to v6 config (#653)
[x] Another pass on the documentation (including actually having a front page)
[x] Migrate electronforge.io to actually using the v6 docs
[x] Move https://github.com/MarshallOfSound/electron-forge-docs to the electron-forge org (will this break gitbook?)

[ ] Update tools/sync-readmes.ts when this happens
[ ] Fix gitbook sync

[x] Update templates (https://github.com/electron-userland/electron-forge-templates/pull/64)

[x] Add at least one template with webpack

[x] Last upgrade of as many dependencies as possible

[x] Upgrade to Electron Packager 14, when it's released
[x] Upgrade to @malept/electron-installer-flatpak 0.10.0, when it's released
[x] Upgrade to electron-installer-snap 4, when it's released
[x] Upgrade to electron-winstaller 4, when it's released

Replace s3 due to #479 Unfortunately not necessary for the release
[x] Try to resolve any pending PRs
[x] Figure out what to do with the electron-forge NPM package
[x] Add docs to CONTRIBUTING.md on how to develop on Electron Forge (e.g., install bolt globally)
[x] Make sure packages like create-electron-app are updated appropriately
Assist downstream packages like ember-electron with upgrading (this will probably happen post-release)
[x] Native modules in webpack https://github.com/electron-userland/electron-forge/issues/703
#1029 (bug with webpack + certain native modules)
[x] Add note mentioning the experimental nature of native modules + webpack

Figure out what to do with the electron-forge NPM package

npm deprecate all versions of it with a message to move to @electron-forge/cli?

Do we no longer want to use the electron-forge NPM package?

@malept I don't think so, we could alias it to @electron-forge/cli but I think we should just make people move 👍

I don't know, there's something to be said for having install instructions be npx electron-forge init my-electron-app and that's it. But I guess we live in a copy/paste world, and npx @electron-forge/cli init my-electron-app is about the same.

@malept We can have npx create-electron-app and yarn create electron-app for the one-liner no-scope commands

Update templates

From what we've talked about previously, we're going to reduce the templates to just a webpack template (and a parcel template perhaps). We should add guides for how to create apps for various frameworks, e.g. React via create-react-app plus electron-forge init --template=webpack.

This issue suggests v6 stable release is imminent (??).
The documentation wisely says don't use the Webpack plugin yet...but given you're gearing up for stable release, is it possible to go ahead and work with Webpack?
Thanks so much for your work on "forge" - this is so very helpful.

@philcockfield Those warnings are just disclaimers at this point.  A bunch of people are already using the webpack plugin, feel free to dive in

This issue suggests v6 stable release is imminent (??).

I would not characterize it as imminent. This issue is meant as a line in the sand to show progress towards releasing a stable version.

The documentation wisely says don't use the Webpack plugin yet...but given you're gearing up for stable release, is it possible to go ahead and work with Webpack?

What @MarshallOfSound said. There's not much in the way of documentation, so we're not yet comfortable recommending it yet.

Awesome - thanks.

It'd be nice to have more than 1 webpack (or parcel) template, where  at least one acts like electron-compile.  My app is still basically a webview into a local app, so I've only been focused on setting up the main process so far. I ended up using node-webpack-externals to basically ignore node_modules and package it as is (otherwise webpack tries to handle node-gyp files and other stuff). I also had to override the ignore to keep node_modules for main.

We don't plan on having more than one template per bundler included by default with Electron Forge v6, as with the old 5.x templates, they are meant to be minimal starters (like electron-quick-start) and not boilerplates. (Quite frankly, it seems to be difficult to find someone to have the time to even do a minimal template.)
That is not to say that a community member can't contribute a third-party template.

Can you make automation of new electron-prebuilt-compile packages also part of this release? electron-forge heavily depends on that package and it's pretty out of dated.
Everybody is building apps on an old version of electron w/ security issues because of that. (or they hacked some things together to make it work)

As of Forge v6, electron-prebuilt-compile is no longer a requirement (although it's still somewhat supported). Its automation is specific to that module, though. See https://github.com/electron-userland/electron-prebuilt-compile/issues/55 for the automation of releases there (which I've noticed you've already found).

@malept ah I see, good to hear that. Thanks for the heads up!

I love this project, great job!  What's the status of V6?

I've updated the TODOs in the issue summary.

Thanks.  Looks close.  Nice work!

Nice work

I've had a great experience with electron-forge so far and really looking forward to v6!
Could anyone point me to documentation (couldn't find any) or summarize how a migration might look like? Just hoping to get a rough estimate of effort/time required.

It should mostly be config changes. I wrote a fairly simple importer from v5 to v6 here: https://github.com/electron-userland/electron-forge/blob/v6.0.0-beta.42/packages/api/core/src/util/upgrade-forge-config.ts (it's invoked by running electron-forge import, using v6, on a v5 app).
Obviously, there's also a cost to migrate off of electron-prebuilt-compile (and probably onto webpack), but that can be done in a separate step.

Hi guys, do you have and ETA on this?
We need a more recent version of electron but the current dependency on electron-prebuilt-compile is limiting us (we use webpack so we don't really need it).
Thanks!

The main blocker is resolving bugs with webpack and native modules. We'd be happy to have help with this so we can (finally) release a stable version.
Aside from that, it's pretty stable.

@malept The migration script worked great, thanks for that!
Overall, the move to version 6 (and from electron-compile to webpack) took me around 7 hours. A lot of time was also spent on getting TS up and running with webpack.
Awesome work on v6!

Is v6 stable yet? Or usable?

You can see from the checklist that only minor items remain. Very much usable and production ready in my view.
Feels great to ditch electron-compile!

And are the docs at https://electronforge.io for v6? Because I vividly remember the docs were at https://v6.electronforge.io before

The v6 docs have been moved to the main domain.  https://electronforge.io/ is now the docs site

@MarshallOfSound Hi,I cannot download the packages that electron-forge needs to execute the make command on the windows platform. Can the required installation package be downloaded by other means and placed in a certain folder, so that electron-forge can be used. Linux and Mac can use proxychains 4. But the network environment of the window platform under the console is too bad. I can't package it in the window environment now.
An unhandled rejection has occurred inside Forge:
GotError [RequestError]: read ECONNRESET
    at ClientRequest.<anonymous> (E:\tools\node_modules\got\source\request-as-event-emitter.js:178:14)
    at Object.onceWrapper (events.js:418:26)
    at ClientRequest.emit (events.js:323:22)
    at ClientRequest.EventEmitter.emit (domain.js:482:12)
    at ClientRequest.origin.emit (E:\tools\node_modules\@szmarczak\http-timer\source\index.js:37:11)
    at TLSSocket.socketErrorListener (_http_client.js:426:9)
    at TLSSocket.emit (events.js:311:20)
    at TLSSocket.EventEmitter.emit (domain.js:482:12)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {
  name: 'RequestError',
  code: 'ECONNRESET',
  host: 'github.com',
  hostname: 'github-production-release-asset-2e65be.s3.amazonaws.com',
  method: 'GET',
  path: '/9384267/11290e80-469b-11ea-89b8-1b05701b4097?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200308%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200308T080453Z&X-Amz-Expires=300&X-Amz-Signature=27242affaec6bbf634838ca20aa0cb9f2e7b49c3df5c5f1b9d5cfea6ab2b387f&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Delectron-v8.0.0-win32-x64.zip&response-content-type=application%2Foctet-stream',
  socketPath: undefined,
  protocol: 'https:',
  url: 'https://github-production-release-asset-2e65be.s3.amazonaws.com/9384267/11290e80-469b-11ea-89b8-1b05701b4097?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200308%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200308T080453Z&X-Amz-Expires=300&X-Amz-Signature=27242affaec6bbf634838ca20aa0cb9f2e7b49c3df5c5f1b9d5cfea6ab2b387f&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Delectron-v8.0.0-win32-x64.zip&response-content-type=application%2Foctet-stream',
  gotOptions: {
    path: '/9384267/11290e80-469b-11ea-89b8-1b05701b4097?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200308%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200308T080453Z&X-Amz-Expires=300&X-Amz-Signature=27242affaec6bbf634838ca20aa0cb9f2e7b49c3df5c5f1b9d5cfea6ab2b387f&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Delectron-v8.0.0-win32-x64.zip&response-content-type=application%2Foctet-stream',
    protocol: 'https:',
    slashes: true,
    auth: null,
    host: 'github.com',
    port: null,
    hostname: 'github-production-release-asset-2e65be.s3.amazonaws.com',
    hash: '',
    search: '?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200308%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200308T080453Z&X-Amz-Expires=300&X-Amz-Signature=27242affaec6bbf634838ca20aa0cb9f2e7b49c3df5c5f1b9d5cfea6ab2b387f&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Delectron-v8.0.0-win32-x64.zip&response-content-type=application%2Foctet-stream',
    query: null,
    pathname: '/9384267/11290e80-469b-11ea-89b8-1b05701b4097',
    href: 'https://github-production-release-asset-2e65be.s3.amazonaws.com/9384267/11290e80-469b-11ea-89b8-1b05701b4097?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200308%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200308T080453Z&X-Amz-Expires=300&X-Amz-Signature=27242affaec6bbf634838ca20aa0cb9f2e7b49c3df5c5f1b9d5cfea6ab2b387f&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Delectron-v8.0.0-win32-x64.zip&response-content-type=application%2Foctet-stream',
    retry: {
      retries: [Function],
      methods: [Set],
      statusCodes: [Set],
      errorCodes: [Set]
    },
    headers: {
      'user-agent': 'got/9.6.0 (https://github.com/sindresorhus/got)',
      'accept-encoding': 'gzip, deflate'
    },
    hooks: {
      beforeRequest: [],
      beforeRedirect: [],
      beforeRetry: [],
      afterResponse: [],
      beforeError: [],
      init: []
    },
    decompress: true,
    throwHttpErrors: true,
    followRedirect: true,
    stream: true,
    form: false,
    json: false,
    cache: false,
    useElectronNet: false,
    method: 'GET'
  }
}

Electron Forge was terminated. Location:
{}
error

@printjs this is unrelated to this issue.
Please read the Electron docs about installing Electron with Chinese mirrors: https://www.electronjs.org/docs/tutorial/installation#mirror

I get the impression that with just a little bit of focused attention this release could get out of beta.  Is there anything I and others could do to make this happen?

I get the impression that with just a little bit of focused attention this release could get out of beta. Is there anything I and others could do to help make this happen?

See https://github.com/electron-userland/electron-forge/issues/621#issuecomment-530082551

Could the Snapcraft maker be resolved for a stable v6 version? It's currently impossible to build a snapcraft artefact on a standard version of Ubuntu.
It seems like there may be a PR that might resolve the issue: https://github.com/electron-userland/electron-installer-snap/pull/75
And there are a number of issues open that appear related:
https://github.com/electron-userland/electron-forge/issues/1696
https://github.com/electron-userland/electron-installer-snap/issues/83
I'd be very happy to help however I can, but I'm not sure asking people to run Forge from within a Docker container is ideal, considering snapcraft packages can be built easily when using electron-builder.

When is eta for 6.0.0?

Can I help sponsor this?

@maccman I would be more than happy to have conversations about sponsoring work on Electron Forge. You can either use GitHub Sponsors or I'm on the official Electron Discord server.

Boom - done! Thanks so much mate for working on this.

Is there any chance of releasing a new beta version? The previous beta release was 4 months ago.
In particular, I'm looking for the fix for https://github.com/electron-userland/electron-forge/issues/1377
No pressure; just checking 🙂

Ta Da? 🎉


NumDiff abstraction for cost functions

In GitLab by @cmastalli on Nov 27, 2018, 10:04
null

In GitLab by @cmastalli on Nov 27, 2018, 10:05
mentioned in merge request !24

In GitLab by @nmansard on Jan 21, 2019, 15:29
Done in refact

In GitLab by @nmansard on Jan 21, 2019, 15:29
closed


Dspace 5 x

Closing this PR. This seems to be an accidental PR, likely meant for a different repo.


Use embedded log viewer servlet over SSL connection

Hi,
I'm trying to use the log viewer functionality embedded into a Spring Boot app.  It runs great in non-ssl, but I'm getting an error after enabling SSL.  I'd just like to verify there is no work-around?
This article, dzone-log-viewer, seems to indicate that viewing logs over SSL is not possible, so just making sure.

.
Thanks

I discovered the issue was csrf tokens.  I disabled csrf tokens and noticed things work.  Closing issue.


May I ask about the configs of pre-training? For example, did you use dropout?

May I ask about the configs of pre-training? For example, did you use dropout?

We use the exact same hyperparameters as described in the original llama paper.

I didn't find dropout in the paper. May I ask if llama has used dropout?


Create .serverless dir if necessary

Fixes #45

@mar-io could you test this? Install with npm i 'UnitedIncome/serverless-python-requirements#bugfix/missing-dot-serverless'

works for me..thanks for quick fix here

Uploaded v2.4.1 with this fix 😃


Fix unknown option compiler warning

bad option '-Xsource:3' was ignored

Not sure that fixed it. Will followup later.


cli: add support for nested arrays

Add support of array parameters to cli.

@alexvanin --- this one is for arrays, actually looks better than I've expected.


Add support for headers for ExtensionRestRequest

Description
Opened this draft PR for @nassipkali to get started on #431
Issues Resolved
https://github.com/opensearch-project/opensearch-sdk-java/issues/431
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Closing this as @nassipkali has raised a new PR: https://github.com/opensearch-project/opensearch-sdk-java/pull/605


Global Store Introduction

Description:
Adds a global redux store to the app, with persistence & an action / reducer for replacing the on boarding async storage flow.
The motivation for this is to set up the infrastructure for sharing of cross-component state in a way that is more easily consumable by different screens & components, ensures a shared, normalized data layer for our upcoming APIs, and allows us to more gracefully handle (and ommit) loading states.
Additionally, we can debug our coupled state better (I've set up RN debugger integrations for Redux Dev Tools here).
Replacing the onboarding async store with a persited redux state allows us to have a state of "onboardingComplete" at mount time for the navigator, stopping navigator flash between onboarding and main. Follow up is needed to keep the splash screen up during the persist gate loading.
Screenshots:
Behavior of the app load with the persist gate (note the button text flash on the before):

Before
After

How to test:
Ensure that going through the onboarding flow can only occur once.
No app functionality should change.
Can additionally now use Redux Dev Tools / RN Debugger to ensure that redux state is persisted / updated properly after onboarding flow.

@johnschoeman I fully get the bearishness on introducing redux.

loss the benefit of Pub/Sub design

Generally I agree with this, but we've already lost it with our abstractions to classes to share the state via store writes (e.g. previous onboarding status), and for holding api states (e.g. HA list)
I think this is an improvement here because the shared data was already floating around without strong couplling, but now we can have stronger invariants on it, debugging tools, and the ability to write stronger tests (as well as mock app states easier)

Given your goal is to share information between components, what do you think about using just the state sharing portion of redux, that is a react context, directly to solve this?

This is half the goal (fully the goal in this pr, which aims to set up the infrastructure). The other half is to provide infrastructure to interact with HA API data in a consistent way. E.g. for the HA List that is needed for the subscription & the sharing step, to provide both a context provider for the data and an api / action layer to ensure we are consistent in how we are fetching / storing from the api.

This is half the goal (fully the goal in this pr, which aims to set up the infrastructure). The other half is to provide infrastructure to interact with HA API data in a consistent way. E.g. for the HA List that is needed for the subscription & the sharing step, to provide both a context provider for the data and an api / action layer to ensure we are consistent in how we are fetching / storing from the api.

Got it, thanks for the explanation! This makes sense to me.

Also checked and redux toolkit uses an immer.js like pattern where you can mutate the state object without worry and it will always store new refs:
https://redux-toolkit.js.org/api/createReducer#direct-state-mutation

@tstirrat  updated with Redux Tool kit!
@johnschoeman in doing so introduced the freezing as middleware
this also now includes a bunch of prettier changes because of the husky pre commit hook


Cannot activate DNSecure

I cannot activate DNSecure in Sonoma. I enable a DNS server and DNSecure shows up in the filters, but I am unable to enable it. What can I check to see what might be blocking it?

It might be related to #38.

It is, but it does not help me resolve it.


DuckDB WASM large file size

Repro
Run an sql query from a doc e.g.
```sql
select 1
```

Build
npm run build

Load the page from a static site. It downloads _npm/<EMAIL_ADDRESS>which is over 18MB. Is this correct? The equivalent WASM file at https://duckdb.org/docs/api/wasm/overview.html is 6.4MB

Yes, this is DuckDB-Wasm’s bundle, and that’s how big it is. The equivalent Wasm file from the example you linked is actually 34.6MB, which perhaps is larger because they’re using the prerelease 1.28.1-dev181.0 rather than the latest release 1.28.0.
https://shell.duckdb.org/static/wasm/duckdb-eh.7c395809b8743828320d.wasm
Note that the compressed size is 4.2MB (and 6.4MB in the case of 1.28.1-dev181.0). Getting a smaller Wasm file would depend on optimizations made by the DuckDB-Wasm team, so you might try asking over there:
https://github.com/duckdb/duckdb-wasm


Allow declaring a queue without specifying the name

Code examples on https://rabbitmq.com for RPC recommend declaring a queue without a name to serve as channel for the response from the RPC server.
When we do this, the RabbitMQ server generates a random queue name for us.
See example here :
https://www.rabbitmq.com/tutorials/tutorial-six-dotnet.html
Relevant code in the RpcClient class:
replyQueueName = channel.QueueDeclare().QueueName;
We can see that the queue is declared without a name and then the code use the automatically generated name in the messages sent to the RPC server. The RPC server then sends the answer to this queue.
When trying to do the same with amqpcpp, declaring the queue fails with this exception : "the queue must to have the name".
So I think amqpcpp should allow doing the same thing :

Accept an empty name when declaring a queue
Use the name provided by RabbitMQ in that case

You can just remove the check – works fine, at least on my machine: https://github.com/akalend/amqpcpp/pull/78/commits/8365a677d5dca7977ac5728ae09569e08a091141
That "fix" is included in PR #78, together with other improvements I've found useful. So you may want to try and use my develop branch.

It turns out being able to disable SSL is quite useful for me.
So I will be using you develop branch.


Filter fix

This pr removes the --patterns / -P option and replaces them with --no-patterns, making patterns the default option.
Furthermore it adds an aditional literal parsing step, that ensures literals are properly formatted regarding the count, positioning and escaping of qutation marks (as requested in #160).
Finally it adds support for filters on result tables that have more than 5 columns, presumably fixing #162.

That said, before we merge let me try this on Wikidata Full


Still can't get in

Uncaught Exception: SyntaxError: Unexpected token } in JSON at position 1770 at Object.parse (native) at /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/main.js:259:25 at /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/node_modules/portfinder/lib/portfinder.js:138:14 at /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/node_modules/portfinder/node_modules/async/lib/async.js:52:16 at /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/node_modules/portfinder/node_modules/async/lib/async.js:269:32 at /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/node_modules/portfinder/node_modules/async/lib/async.js:44:16 at /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/node_modules/portfinder/lib/portfinder.js:106:16 at Server.onListen (/Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/node_modules/portfinder/lib/portfinder.js:35:5) at Server.g (events.js:286:16) at emitNone (events.js:86:13)

Can you try to get a fresh install of the PokemonGo-Bot-Desktop?

Okay, I will try

Having problem..
`><EMAIL_ADDRESS>start /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop

electron main.js

2016-08-01 13:54:11.197 Electron Helper[1877:141121] Couldn't set selectedTextBackgroundColor from default ()
Starting Python process...
Got open port: 8000
Bot path: /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/gofbot
python ./pokecli.py
Bot path: /Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/gofbot/web
python serveit.py 8000
Python: Traceback (most recent call last):
File "./pokecli.py", line 40, in
from pokemongo_bot import PokemonGoBot, TreeConfigBuilder
File "/Users/Amuyea/Desktop/NEWBOTDESKTOP/PokemonGo-Bot-Desktop/gofbot/pokemongo_bot/init.py", line 14, in
from pgoapi.utilities import f2i, get_cell_ids
ImportError: cannot import name get_cell_ids
server started!
`
Is there a fix for it or fix the files?

Did you run npm install?

You can also try the new release to bypass all these issues
https://github.com/PokemonGoF/PokemonGo-Bot-Desktop/releases

Yes.
Yeah, I tried it. No problem but its not doing anything

I get this error can someone point me to the proper setup instructions please.

@Rlewisrlou666  Seems like you are missing on of the python packeges. Try running npm install

Cheers it seems to be working now.


Get Data Lab completed!

@AaronGullickson 🎉🎉🎉😎🐺

Looks good, except your code is not in a code chunk. See my PR #4 for the correction.


WIP: NE-366: Ingress: Add logLevel and operatorLogLevel configuration for ingress and ingress operator

Implementation of openshift/enhancements#806
Adds operatorLogLevel to ingress.config, and logLevel to ingresscontroller, to control the log level of the operator and the log level of the router controller process, respectively.

/retest

/retest

/label docs-approved

/label px-approved

/assign
/assign @miheer

[FAIL]  [config.openshift.io/v1, Resource=ingresses] [Stable] Ingress On Create [It] Should be able to create a minimal Ingress
/go/src/github.com/openshift/api/tests/generator.go:195
/test integration

The integration failure looks legitimate; the ingress that was created had operatorLogLevel: Normal in the spec. I'll have to address that

Sorry it took me so long to get back to this, but I've addressed the review comments. @candita and @miheer please take another look when you have a chance

/lgtm

Moving back to WIP while I work on a better fit for the operatorLogLevel location

Since the design now deviates from that in the original enhancement, I've opened a PR to update that enhancement: openshift/enhancements#1314
Assuming that updated design is acceptable, this should be ready for review again. However, I do have a couple open questions. I will add some comments shortly for each of them.


Create an intro.

Add an intro about yourself: who are you, what is your strength, why are you here.


Talk Page Does Not Show Talk Venue

The talk location is emphasized rather than the venue. For example, the CHI talks are shown as Denver, Colorado but not as CHI'17 talks:

This is fixed on the landing page:

Indeed, to reduce code redundancy, perhaps this should be rendered from a common function, if possible? Otherwise, relevant code could likely be copy/pasted from landing page.

Error is in the script that loads the data from django into JSON, should be talk.forum_name, is listed as talk.location

This is now fixed (using a snippet).


MetalTranslator support OpConstantComposite and OpStore.

MetalTranslator support OpConstantComposite.
MetalTranslator OpStore support array declaration.
CStyleTranslator support retrieve base type from OpPointer type.
MetalTranslator use base type functions.
MetalStageInTranslator use base type functions.

In case you're confused, I was logged in under the company account when I submitted this pull request.

Not confused, seen it before :)
Thanks!


Laravel is removing "s" from the resource route name

Laravel Version
10.14.0
PHP Version
8.1
Database Driver & Version
MySQL 8.1
Description
Laravel removes the "s" from the declared contact_us resource route.
Route::resource('contact_us', ContactUsController::class);
In the route:list command the

This causes issues when working with the controller and route model binding.
The show, edit, and destroy method returns an empty model.
Steps To Reproduce

php artisan make:model ContactUs -rmc.
Declare the above mentioned routes

By default, Route::resource will create the route parameters for your resource routes based on the "singularized" version of the resource name.  https://laravel.com/docs/10.x/controllers#restful-naming-resource-route-parameters

Try the following:
Route::resource('contact_us', ContactUsController::class)->parameters([
    'contact_us' => 'contact_us'
]);

Thanks @saade
On the link doc, it has clearly mentioned the singularized version concept.
But a confusing thing is that the contact_us is already a singular version. Then why the laravel routes is removing "s" from that. ?
By the way thanks for the reference link.


Another flake caused by waitForCompletion returning in the middle of WorkflowRun.finish

From from bom PCT as usual: https://github.com/jenkinsci/bom/pull/208#issuecomment-611476831. Can be reproduced this way:
diff --git src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
index 1177ef4..f2aebc3 100644
--- src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
+++ src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
@@ -589,6 +589,11 @@ public final class WorkflowRun extends Run<WorkflowJob,WorkflowRun> implements F
             synchronized (getMetadataGuard()) {
                 myListener = getListener();
                 completed = true;
+                try {
+                    Thread.sleep(1000);
+                } catch (InterruptedException ex) {
+                    ex.printStackTrace();
+                }
             }
             duration = Math.max(0, System.currentTimeMillis() - getStartTimeInMillis());
             LOGGER.log(Level.INFO, "{0} completed: {1}", new Object[]{toString(), getResult()});

IIUC, https://github.com/jenkinsci/jenkins-test-harness/pull/210 fixes the underlying issue that was causing this test to flake, and that PR is in jenkins-test-harness 2.63, which is in plugin-pom 4.1, which is what this plugin is currently using, so I am going to close the PR. Feel free to reopen if that's not the case.


FIP timeseries is incorrectly aligned

Looking at the NWB files generated from the pipeline there are two issues with time alignment

The R channel timestamps start ~30s after the G channel. They should be synchronized

The G,R,Iso timestamps are not synchronized (likely a result of the first issue)

this might be related to the handling of the "10 fist blank frames" that we used to have in the past

Note that debugging this code is very annoying because of this issues outlined here: https://github.com/AllenNeuralDynamics/aind-physio-arch/issues/45#issuecomment-2276796729

Todo for rachel:
Write a testing function that will eventually be integrated into the QC code.

@srecanatesi gives this fix, editing line 460 of "aligned_fiber_to_nwb.py" which reads:
        timestamps[channel] = df_fip_sel[df_fip_sel['channel'] == channel]['time_fip'].values

to
        timestamps_channel = df_fip_sel[df_fip_sel['channel'] == channel]['time_fip'].values
        conversion_factor = np.round(statistics.mode(np.round(np.diff(timestamps_channel),2))/0.05)
        power = 10**round(np.log10(abs(conversion_factor)))
        timestamps[channel] = timestamps_channel / power

This appears to resolve the issue. Remaining tasks:

[ ] add this line to the pipeline
[ ] Add a QC check to look for this issue in the future
[ ] Test on more sessions

PR to update the pipeline. https://github.com/AllenNeuralDynamics/NWB-Packaging-FiberPhotometry-Base-Capsule/pull/14
I'm struggling to test it on CO, because I'm not familiar with CO tools.

If easily debugable, I wouldn't discourage to do so. However, practically, we can completely drop the "falling" from nwb or dataframe.
Rationale:
-rising is corresponding to the starting time of Green channel camera frame exposure
-falling is corresponding to the ending time of Green channel camera frame exposure
-Green channel one data point has only one (Bonsai-software) timestamp and thus only one HARP-aligned timestamp.
-thus, the only one additional info we have by keeping falling is the exposure time (diff between rising and falling)

Making a list of sessions where the alignment is to ISO, and not G1
BAD:
behavior_717531_2024-08-07_09-01-02_processed_2024-08-08_13-34-22 (but still has 30 second offset issue)
GOOD:
behavior_711042_2024-08-23_13-27-08_processed_2024-08-24_07-39-12
behavior_717531_2024-08-23_08-58-49_processed_2024-08-24_10-37-56
behavior_732163_2024-08-23_13-36-21_processed_2024-08-24_06-57-41


Update optimize configure to set deployment UID on optimizer Orion config object

Description
In order to create FMM entities associated with the deployment under optimization, the ARO backend needs to have the UID of the relevant deployment. This update writes deployment UID to a new field within the optimizer configuration object so that it can be used by the backed in its entity creation.
Type of Change

[ ] Bug Fix
[ ] New Feature
[x] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[ ] New code contribution is covered by automated tests
[x] All new and existing tests pass

Codecov Report

Merging #140 (7e6bed5) into main (dae6f72) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   32.33%   32.33%
=======================================
  Files          27       27
  Lines        3569     3569
=======================================
  Hits         1154     1154
  Misses       2324     2324
  Partials       91       91


add sasha pang to site

Looks good! But I only see the changes you made to the _config file and I don't see your photo in the commit. Could you add that and I'll merge it in?

Looks good!! :shipit:

You are live! Check out codehbsclub.com.

Yaaaaay thanks!!
On Monday, September 26, 2016, Andrea Coravos<EMAIL_ADDRESS>wrote:

You are live! Check out codehbsclub.com.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codehbs/codehbs-official-homepage/pull/10#issuecomment-249751540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVWFIB_V0OnxyuF9Ki6f480gneKISQB_ks5quIEzgaJpZM4KGEu7
.


modified for chander-dhall

Docs Build status updates of commit ff97664:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/chander-dhall.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[Loading Indicator] Are there any way to show a custom spinner during sorting

Hi guys,
After dropping, I need to show a spinner to wait for action.
Are there any props that support this?

Hi, i currently search answer for this question. How i can invoke updateBeforeSortEnd? So, before onSortEnd callback is invoke, interface looks like freeze bug, for this i want add loader.  (Big data, have some lags, virtualized not given solution)


error in file name and add command to start

The filename is cs-custom-bouncer.yaml and not cs-firewall-bouncer.yaml .
And I add the command to start the service manually ( can be discussed, but for me, "not a linux expert about how to start the service" it can help ... And yes it's already written in the readme, but the filename too, not sure about what to do )

First of all, sorry for the delay, secondly, thanks for the MR !


Small issue in split Test

Hello,
Should the join, in the split test, not actually be a Split function?
https://github.com/cloudtools/troposphere/blob/87ea14285eabeebc2ad72ddbb34c30a7d527be5c/tests/test_basic.py#L483

Good catch. Thanks!


Adding try {} catch {} to getPhantomJsVersionFromBinary() to trigger …

I have found a few scenarios in which getPhantomJsVersionFromBinary() fails to execute as expected. This kills the composer process. Often, removing phantomjs and re-installing resolves the issue.
This simple change will catch exceptions and cause phantomjs to be re-downloaded in the case of an error.
This should be fully backwards compatible.

Hello Matthew!
Thank you for contributing.

I have found a few scenarios in which getPhantomJsVersionFromBinary() fails to execute as expected.

Is one of the scenarios reproducible?

Yes. This largely happens when using virtual machines, or when the filepath of the repository changes.
E.g., I create a virtual machine, ssh into it, and execute composer install. I then exit the vm and execute composer install on the host machine. Since PhantomJS installer records the absolute filepath of the Phantom binary, and since the binary is OS-specific, attempting to execute it from the host machine will cause an error and kill the Composer process.

👍 Thank you for explaining the issue.


Feature/status request: NRPcalc for CDS's

Hi! Howard mentioned you're working on a nonrepetitive parts calculator for protein coding sequences. How's that going? Would love to use it for some projects. I've found it difficult to use the regular nrpcalc for this task--most queries end up with no solved sequences, and no indication what regions of the sequence are causing problems.

Hello Isaac,
The prototype is done & tested. I can prepare the web interface
(sometime this week) & throw it up on our test server for your usage.
Regarding the solution space: If Lmax is too small and/or if the CDS is
very polymeric, then the # of non-repetitive CDSs will indeed be small.
Though I routinely received 10+ non-repetitive CDSs with 300 randomly
generated AA sequences with an Lmax of 20. But an Lmax of 15 reduced the
solution set to 2-3 CDSs. So your best strategy is to start off with a high
Lmax. On the website, it will automatically calculate the solution set with
lower and lower Lmax until some threshold is reached.
Thanks,
Howard
~~
Howard Salis
Associate Professor
Biological Engineering and Chemical Engineering
Penn State University
Email<EMAIL_ADDRESS>Phone:<PHONE_NUMBER>
Lab web site: http://salislab.net
Design your DNA: http://salislab.net/software
On Sun, Mar 7, 2021 at 7:25 PM Isaac Larkin<EMAIL_ADDRESS>wrote:

Hi! Howard mentioned you're working on a nonrepetitive parts calculator
for protein coding sequences. How's that going? Would love to use it for
some projects. I've found it difficult to use the regular nrpcalc for this
task--most queries end up with no solved sequences, and no indication what
regions of the sequence are causing problems.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ayaanhossain/nrpcalc/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA6NO733SOEFD3YAIPSKU3TCQKPZANCNFSM4YYNRZRQ
.

And it's done. I'll DM you our test server URL. Let me know how it goes.


Chats on XMTP.chat aren't sorted reverse chronologically

Summary
Chats on XMTP.chat aren't sorted reverse chronologically.
Steps to reproduce

Send/receive messages from 5+ wallets.
Check sorting of the messages.

Expected behavior
The most recent chats should be displayed at the top and the oldest at the bottom in the messages feed.
Actual behavior
Chats are randomly ordered and not sorted reverse chronologically.
Attachments

Environment

OS version: MacOS Monterey 12.3.1
Browser version: Google Chrome 105.0.5195.125
xmtp-js version (if known): -
Deployment URL (if applicable): -

Resolved by https://github.com/xmtp/example-chat-react/commit/a4d7329299a67d4c9293e625540c8828bf6d9c91

🤜 🤛


feat(@angular/cli): adding resolver blueprints

Fixes: https://github.com/angular/angular-cli/issues/6011

@cexbrayat Done with changes.

@Brocco This was approved but never merged. Should that be reopened on @angular/schematics?

Closing every Blueprints related issue and PR.


Permissions Missing

I have the following code set up. It runs without errors.
try:
token = util.prompt_for_user_token(username)
except:
scope = 'user-read-private user-read-playback-state user-modify-playback-state'
os.remove(f".cache-{username}")
token = util.prompt_for_user_token(username, scope)
spotifyObject = spotipy.Spotify(auth=token)
However, I am trying to use voice commands to do things such as skipping songs. I have the following set up:
elif 'skip this song' in command:
talk('skipping')
spotifyObject.next_track(device_id='0d1841b0976bae2a3a310dd74c0f3df354899bc8')
I get an error "Permissions missing, reason: None" which makes no sense because the scope should be set up correctly.

Nevermind, I had to re-authorize my program


Update makefile to handle trailing slashes in the project argument in…

Update makefile to adjust for the binary name when a trailing / is specified in the project.

This closes #183


6-circle drawing is mislabeled

The drawing used with the TARDIS example is mislabeled as E6C.  Clearly it is not since mu is not part of the detector stack in the E6C geometry.  The drawing is correct for the SPEC sixc geometry which is the IUCr 6-circle geometry.

The drawing should be psic (the geometry described by Hoydoo Yoo's paper).
Confirm all this before proceeding.

This is the drawing and description of E6C, from (a private copy of) the libhkl documentation

The PETRA3 P09 EH2 libhkl geometry matches the figure above:

@prjemian i confirm that for the tardis is sixc and we also identified this (hkl-engine-petra3-p09-eh2.c) as the correct picca set of circles.
we ran into some problems when adding a 4th axis so there may still be so circle direction inversion but we are not in a position to resolve that.  If we go back to the 4th axis, we will start with this engine (hkl-engine-petra3-p09-eh2.c)


refactor: non-gmo, organic Settings object using pydantic

Description

Refactors the wandb.Settings a.k.a wandb.sdk.wandb_settings.Settings class to use pydantic>=2 under the hood.
Removes the complex bespoke settings source tracking logic with a simpler design, with a first pass on minimizing the number of places where the settings updates are applied. There is a clear distinction between different types of settings:

Public settings declared as class attributes with optional default values and validator methods.
Modifiable settings meant for internal use should be prefixed with x_.
Read-only computed settings defined as class methods using the @computed_field and @property decorators. If meant for internal use only, prefixed with _.

[ ] I updated CHANGELOG.md, or it's not applicable

Testing
How was this PR tested?

@dmitryduev anyway we could allow both str and pathlib.Path?
https://github.com/wandb/wandb/blob/main/wandb/sdk/wandb_settings.py#L176

@skothenhill-nv https://github.com/wandb/wandb/pull/9061 -- this will be in the next release.


FPS drop on doomfist

Whenever someone plays Doomfist, everyone's FPS drops by around 40%.

The fps drop is caused by indicator slam gui calculations.
v0.5.0 slightly improves on the fps, but doom still drops fps for everyone in the lobby when his indicator becomes visible.


2.3.3op2: make test fails on some distributions

I'm trying to update the cups package for openSUSE to 2.3.3op2.
In addition to changing upstream, I've also decided to run make check and make test during the build process (rpm %check section), 2.3.3op2 manages to compile and check on all targets (SLES 12.5 upto Factory), but the testsuite fails on SLE15.2, Leap 15.1 and Factory zSystems  with FAIL: 34 error messages, expected 33.
[  417s] Test Summary
[  417s]
[  417s] PASS: cupsd exited with no errors.
[  417s] PASS: All job control files purged.
[  417s] PASS: Printer 'Test1' correctly produced 37 page(s).
[  417s] PASS: Printer 'Test2' correctly produced 23 page(s).
[  417s] PASS: Printer 'Test3' correctly produced 2 page(s).
[  417s] PASS: 165 requests logged.
[  417s] PASS: CUPS-Get-Default not logged.
[  417s] PASS: 0 emergency messages.
[  417s] PASS: 0 alert messages.
[  417s] PASS: 0 critical messages.
[  417s] FAIL: 34 error messages, expected 33.
[  417s] E [19/Mar/2021:12:04:54.950854 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  417s] E [19/Mar/2021:12:04:54.953741 +0000] Missing attributes-natural-language attribute.
[  417s] E [19/Mar/2021:12:04:54.953759 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  417s] E [19/Mar/2021:12:04:54.953821 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  417s] E [19/Mar/2021:12:04:54.956154 +0000] Missing attributes-charset attribute.
[  417s] E [19/Mar/2021:12:04:54.956172 +0000] Missing attributes-natural-language attribute.
[  417s] E [19/Mar/2021:12:04:54.956188 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  417s] E [19/Mar/2021:12:04:54.956229 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  417s] E [19/Mar/2021:12:04:54.957767 +0000] Missing attributes-charset attribute.
[  417s] E [19/Mar/2021:12:04:54.957785 +0000] Missing attributes-natural-language attribute.
[  417s] E [19/Mar/2021:12:04:54.957800 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  417s] E [19/Mar/2021:12:04:54.957878 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  417s] E [19/Mar/2021:12:04:54.958804 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  417s] E [19/Mar/2021:12:04:54.958853 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  418s] E [19/Mar/2021:12:04:54.960897 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (ipp://localhost:8631/jobs) from localhost.
[  418s] E [19/Mar/2021:12:04:54.961922 +0000] [Client 2] Returning IPP server-error-version-not-supported for Get-Jobs (no URI) from localhost.
[  418s] E [19/Mar/2021:12:04:55.203118 +0000] [Client 4] Returning IPP client-error-bad-request for Print-Job (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.442505 +0000] [Client 5] Returning IPP client-error-too-many-subscriptions for Create-Printer-Subscriptions (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.458837 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (no URI) from localhost.
[  418s] E [19/Mar/2021:12:05:02.477194 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (no URI) from localhost.
[  418s] E [19/Mar/2021:12:05:02.478330 +0000] Missing attributes-natural-language attribute.
[  418s] E [19/Mar/2021:12:05:02.478388 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.479305 +0000] Missing attributes-charset attribute.
[  418s] E [19/Mar/2021:12:05:02.479350 +0000] Missing attributes-natural-language attribute.
[  418s] E [19/Mar/2021:12:05:02.479401 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.480708 +0000] Missing attributes-charset attribute.
[  418s] E [19/Mar/2021:12:05:02.480728 +0000] Missing attributes-natural-language attribute.
[  418s] E [19/Mar/2021:12:05:02.480785 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.511870 +0000] [Client 8] Returning IPP server-error-version-not-supported for Get-Printer-Attributes (no URI) from localhost.
[  418s] E [19/Mar/2021:12:05:02.514085 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  418s] E [19/Mar/2021:12:05:02.514177 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (no URI) from localhost.
[  418s] E [19/Mar/2021:12:05:02.590432 +0000] [Client 8] Returning IPP client-error-not-possible for Cancel-Job (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.609595 +0000] [Client 8] Returning IPP client-error-not-possible for Cancel-Job (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.646590 +0000] [Client 8] Returning IPP client-error-bad-request for Send-Document (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] PASS: 8 warning messages.
[  418s] PASS: 0 notice messages.
[  418s] PASS: 784 info messages.
[  418s] PASS: 23560 debug messages.
[  418s] PASS: 88718 debug2 messages.
[  418s]
[  418s] Copied log file "access_log-2021-03-19-abuild" to test directory.
[  418s] Copied log file "debug_log-2021-03-19-abuild" to test directory.
[  418s] Copied log file "error_log-2021-03-19-abuild" to test directory.
[  418s] Copied log file "page_log-2021-03-19-abuild" to test directory.
[  418s] Copied report file "cups-str-2021-03-19-abuild.html" to test directory.
[  418s]
[  418s] 1 tests failed.
[  418s] make: *** [Makefile:241: test] Error 1
[  418s] error: Bad exit status from /var/tmp/rpm-tmp.iN0zmj (%check)

The full log is here: home:sp1rit:branches:Printing/cups

@sp1ritCS The issue seems to be the Cancel-Job request:
[  418s] E [19/Mar/2021:12:05:02.590432 +0000] [Client 8] Returning IPP client-error-not-possible for Cancel-Job (ipp://localhost:8631/printers/Test1) from localhost.
[  418s] E [19/Mar/2021:12:05:02.609595 +0000] [Client 8] Returning IPP client-error-not-possible for Cancel-Job (ipp://localhost:8631/printers/Test1) from localhost.
I'll have to go through the full log to see the context...

@sp1ritCS Actually, it doesn't look like you have the full error_log file available. What I've done for the Github Actions builder is to cat the error_log when the test fails so that I have a full copy of the log present in the build output. If you can add that and provide a link I'll be happy to investigate further.

FYI:
The build environment that is used by the openSUSE Build Service (OBS) is rather limited.
I don't know all the details but in OBS each package is built
within a new from scratch set up virtual machine
that has no access to "something outside".
Furthermore - as far as I know - the built is run as normal user (not as root)
so I think things like running the cupsd within the build environment won't work normally.

@jsmeix Spirit is just running the "make test" target as part of building the package, which sets up a cupsd that runs as an ordinary user without any additional software. As Github Actions has similar limitations (WRT accessing build artifacts, etc.) so my setup includes the following when running the automated test suite:
make test || cat test/error_log*

Basically, if there is an error during the test then I copy the error_log file to the build log. Messy but effective... :)

Ok, so this seems to be some kind of race condition that does not have to occur, but apparently occurs more often on s390x (openSUSE:Factory zSystems).
rpmbuild kills the build process as soon as a procces returns a non-zero exit code, so I had to be a little creative :)
I've replaced make check and make test (it occurs on make check) with
bash -c 'make %{?_smp_mflags} check; EXIT=$?; if [ $EXIT -gt 0 ]; then cat test/*_log*-$(whoami); fi; exit $EXIT'
bash -c 'make %{?_smp_mflags} test; EXIT=$?; if [ $EXIT -gt 0 ]; then cat test/*_log*-$(whoami); fi; exit $EXIT'

As now the log file far exceeds 100 lines, and you need an account on OBS to see the full log, I'll send the full build log, here.
cups_log_factory_zsystems_s390x.gz

@sp1ritCS Can you point me to the other patches you are using?
The failure happens for the 7th job in the test. In a working "make test" log, job 7 is just starting its processing when the Cancel-Job request comes in. In your build log the job has already completed. I need to confirm what the expected behavior is...

@sp1ritCS Can you point me to the other patches you are using?

to quote from the specfile, because every patch is documented fairly well:

// Patch0...Patch9 is for patches from upstream:
// Source10...Source99 is for sources from SUSE which are intended for upstream:
// Patch10...Patch99 is for patches from SUSE which are intended for upstream:
// Patch10 cups-2.1.0-choose-uri-template.patch adds 'smb://...' URIs to templates/choose-uri.tmpl:
Patch10:       cups-2.1.0-choose-uri-template.patch
// Patch11 cups-2.1.0-default-webcontent-path.patch changes the default path whereto the
// web content is installed from /usr/share/doc/cups to /usr/share/cups/webcontent
// because the files of the CUPS web content are no documentation, see CUPS STR #3578
// and http://bugzilla.novell.com/show_bug.cgi?id=546023#c6 and subsequent comments:
Patch11:        cups-2.1.0-default-webcontent-path.patch
// Patch12 cups-2.1.0-cups-systemd-socket.patch Use systemd socket activation properly:
Patch12:        cups-2.1.0-cups-systemd-socket.patch
// Patch100...Patch999 is for private patches from SUSE which are not intended for upstream:
// Patch100 cups-pam.diff adds conf/pam.suse regarding support for PAM for SUSE:
Patch100:       cups-pam.diff
// Patch101 cups-2.0.3-additional_policies.patch adds the 'allowallforanybody' policy to cupsd.conf
// see https://fate.novell.com/303515 and https://bugzilla.suse.com/show_bug.cgi?id=936309
Patch101:       cups-2.0.3-additional_policies.patch
// Patch103 cups-1.4-do_not_strip_recommended_from_PPDs.patch
// reverts the change which was added by Michael Sweet in Jan 2007
// which strips the word "recommended" from NickName in PPDs because
// at least yast2-printer in SUSE needs it, compare the
// 'Why not "recommend" PPDs in the NickName?' and the subsequent
// 'RFC: New Driver Rating/Information Attributes' mail thread on<EMAIL_ADDRESS>Patch103:       cups-1.4-do_not_strip_recommended_from_PPDs.patch
// Patch104 cups-config-libs.patch fixes option --libs in cups-config script:
Patch104:       cups-config-libs.patch
// Patch106 Fixes web UI Kerberos authentication (bsc#1175960)
Patch106:       fix-negotiate-authentication-between-CGIs-and-scheduler.patch

(# has been replaced with //, due to markdown on gh)
As you can see, some of these patches appear to be very old (up to 15 years) and refer to webpages that don't even exist anymore. Maybe some of them are unneeded nowadays, but I'm unsure.

All our sources to build CUPS for openSUSE are public accessible at
https://build.opensuse.org/package/show/Printing/cups
On "Wed Jan 27 14:43:37 CET 2010" I dropped
"almost all our own patches to enforce a
reset to almost 100% compliance with upstream", cf.
https://build.opensuse.org/package/view_file/Printing/cups/cups.changes?expand=1
Meanwhile I am no longer the onyl one who maintains CUPS for openSUSE
but as far as I can tell we have no patches at openSUSE that modify some
generic standard behaviour of CUPS - at least we should not have such patches.
I cannot tell about systemd related patches because I don't know about that stuff.
I gave up trying to understand how that stuff works or is meant to work.
I can understand a single simple systemd unit file to start a service but I gave up
with several unit files for several conflicting use cases for one same service.

@sp1ritCS Where do we stand with this?

@sp1ritCS Where do we stand with this?

well, for now the testsuite is disabled

however, what might be the cause for the unexplainable behaviour are the limited resources (memory) that are provided to the vm. If I have time, I'll try enabling the testsuite and adding a bit of debug output (free) before that. If one one the builds fails I could try to replicate that on my local machine by limiting the memory of the vm.

@sp1ritCS The test suite does require some amount of memory, storage, networking, and time to run. I haven't been able to duplicate the issue you are seeing, and neither Travis CI (our former CI service) nor Github Actions (current one) show this same problem using the Ubuntu and macOS VMs.

@sp1ritCS I'm going to close this as "unable-to-reproduce". If you can reproduce with 2.4.0 (close to beta now) please let me know.

Hello, this problem can also occur occasionally in cups-2.4.0 version
“Returning IPP client-error-not-possible for Cancel-Job ”，this err log appears 2 times
[  220s] FAIL: 34 error messages, expected 33.
[  220s] E [25/Jul/2022:10:31:52.958248 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  220s] E [25/Jul/2022:10:31:52.958774 +0000] Missing attributes-natural-language attribute.
[  220s] E [25/Jul/2022:10:31:52.958787 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  220s] E [25/Jul/2022:10:31:52.958819 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  220s] E [25/Jul/2022:10:31:52.959219 +0000] Missing attributes-charset attribute.
[  220s] E [25/Jul/2022:10:31:52.959232 +0000] Missing attributes-natural-language attribute.
[  220s] E [25/Jul/2022:10:31:52.959244 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  220s] E [25/Jul/2022:10:31:52.959274 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  220s] E [25/Jul/2022:10:31:52.959681 +0000] Missing attributes-charset attribute.
[  220s] E [25/Jul/2022:10:31:52.959694 +0000] Missing attributes-natural-language attribute.
[  220s] E [25/Jul/2022:10:31:52.959706 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  220s] E [25/Jul/2022:10:31:52.959741 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  220s] E [25/Jul/2022:10:31:52.960130 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  220s] E [25/Jul/2022:10:31:52.960165 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (no URI) from localhost.
[  220s] E [25/Jul/2022:10:31:52.960970 +0000] [Client 2] Returning IPP client-error-bad-request for Get-Jobs (ipp://localhost:8631/jobs) from localhost.
[  220s] E [25/Jul/2022:10:31:52.961348 +0000] [Client 2] Returning IPP server-error-version-not-supported for Get-Jobs (no URI) from localhost.
[  220s] E [25/Jul/2022:10:31:53.018648 +0000] [Client 4] Returning IPP client-error-bad-request for Print-Job (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] E [25/Jul/2022:10:32:00.055408 +0000] [Client 5] Returning IPP client-error-too-many-subscriptions for Create-Printer-Subscriptions (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] E [25/Jul/2022:10:32:00.149059 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (no URI) from localhost.
[  220s] E [25/Jul/2022:10:32:00.160887 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (no URI) from localhost.
[  220s] E [25/Jul/2022:10:32:00.172884 +0000] Missing attributes-natural-language attribute.
[  220s] E [25/Jul/2022:10:32:00.172928 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] E [25/Jul/2022:10:32:00.184888 +0000] Missing attributes-charset attribute.
[  220s] E [25/Jul/2022:10:32:00.184903 +0000] Missing attributes-natural-language attribute.
[  220s] E [25/Jul/2022:10:32:00.184941 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] E [25/Jul/2022:10:32:00.196892 +0000] Missing attributes-charset attribute.
[  220s] E [25/Jul/2022:10:32:00.196908 +0000] Missing attributes-natural-language attribute.
[  220s] E [25/Jul/2022:10:32:00.196951 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] E [25/Jul/2022:10:32:00.228893 +0000] [Client 8] Returning IPP server-error-version-not-supported for Get-Printer-Attributes (no URI) from localhost.
[  220s] E [25/Jul/2022:10:32:00.241222 +0000] Missing printer-uri, job-uri, or ppd-name attribute.
[  220s] E [25/Jul/2022:10:32:00.241266 +0000] [Client 8] Returning IPP client-error-bad-request for Get-Printer-Attributes (no URI) from localhost.
[  220s] E [25/Jul/2022:10:32:00.351754 +0000] [Client 8] Returning IPP client-error-not-possible for Cancel-Job (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] E [25/Jul/2022:10:32:00.392474 +0000] [Client 8] Returning IPP client-error-not-possible for Cancel-Job (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] E [25/Jul/2022:10:32:00.448922 +0000] [Client 8] Returning IPP client-error-bad-request for Send-Document (ipp://localhost:8631/printers/Test1) from localhost.
[  220s] PASS: 14 warning messages.
[  220s] PASS: 0 notice messages.
[  220s] PASS: 872 info messages.
[  220s] PASS: 24069 debug messages.
[  221s] PASS: 80585 debug2 messages.

@shirelyhhdl @sp1ritCS can you reproduce still on s390x? I've created a PR which will hold the job which we need to cancel, so the additional error shouldn't be generated.
Would you mind testing it?


feat: scrolltotopbutton added

Back to top button added

Fixed #173
@CSEdgeOff Made the button successfully
#194 it is closed now.. Kindly review now and do add the labels


Adding FAQ section to troubleshoot potential cURL errors

Added FAQ section with details about fixing and troubleshooting cURL errors.

@deancsmith Very nice, thanks a lot!
I'm in the process of completing the test suite so that coverage will be near 100%; I'm thinking a 1.0 release will be coming very soon...
Once it gets to an alpha state, would you be willing to do a review of this package? Making this all myself is bound to create bugs so another pair of eyes would be really helpful! I don't want to ask too much of your (free) time obviously.
Additionally, I would like to have a few more contributors to this package once it reaches a stable state, would you be interested in becoming the second maintainer?

@cleentfaar I'd be more than happy to cast my eyes over it when you want me to, so just let me know.
In terms of becoming the second maintainer, I'm not sure that I'm going to be using Slack enough in the future to really be able to help out enough. I'm open to it but let's see what has happened once you get to 1.0.


Has structured list border been removed?

Summary
The example for a structured list still includes the border class
bx--structured-list--border
Should this be removed or is this a missing feature?

@aledavila Any insights...? Thanks!

Seems to be left over class.
Removed in https://github.com/IBM/carbon-components/pull/2349

@aledavila Thank you for your quick fix!


Vortex Update Detection

Here's a little timeline of my experience, partly explained in https://github.com/alandtse/PapyrusExtenderSSE/issues/1#issuecomment-1330395940:

I started with 0.36.0
Vortex detected updates as expected up to 0.48.0.
The "v" prefix started on v0.50.0. Vortex didn't consider it an update.
0.52.0 released without the prefix. Vortex didn't consider it an update.
I manually updated to v0.65.0 to see if Vortex would detect v0.66.0, and it did.
Now similarly to 0.52.0, Vortex doesn't consider 0.67.1 an update.

Apparently, the existence of any prefixed version turns Vortex blind to non-prefixed versions. I suspect even if the prefixes could be removed from old versions, it wouldn't help players currently on a prefixed version. So I think the lesser evil is to continue prefixing at this point, unless a third version format can set Vortex straight by showing up as an update regardless of a player's current version.

I just deleted all old versions and removed the prefix version. It may mess stuff up in the short term but hopefully ti'll make the long term more sustainable.


Parallelize fetching deploys for fast-sync

The current fast sync implementation downloads deploys one at a time.  This can be very slow for full blocks.  This should be parallelized.

#2188


Delete @function.outer deletes more than it should

Describe the bug
After configuring daf to delete outer function lines, more than the function is deleted.
To Reproduce
Given LazyVim and the following snippet configuration
return {
  {
    -- [Linewise selections should include all empty lines below](https://github.com/nvim-treesitter/nvim-treesitter-textobjects/issues/307)
    -- [Treesitter text objects mapping not working or being overwritten](https://www.reddit.com/r/neovim/comments/12x8mbf/treesitter_text_objects_mapping_not_working_or/)
    -- [example config](https://github.com/augustocdias/dotfiles/blob/main/.config/nvim/lua/setup/treesitter.lua)
    "nvim-treesitter/nvim-treesitter",
    opts = {
      textobjects = {
        select = {
          enable = true,

          -- Automatically jump forward to textobj, similar to targets.vim
          lookahead = true,
          keymaps = {
            -- You can use the capture groups defined in textobjects.scm
            -- You can optionally set descriptions to the mappings (used in the desc parameter of
            -- nvim_buf_set_keymap) which plugins like which-key display
            ["aZ"] =<EMAIL_ADDRESS>            ["af"] =<EMAIL_ADDRESS>            ["if"] =<EMAIL_ADDRESS>            ["ac"] =<EMAIL_ADDRESS>            ["ic"] = { query =<EMAIL_ADDRESS>desc = "Select inner part of a class region" },
            ["au"] =<EMAIL_ADDRESS>            ["iu"] =<EMAIL_ADDRESS>            ["ab"] =<EMAIL_ADDRESS>            ["ib"] =<EMAIL_ADDRESS>          },
          -- You can choose the select mode (default is charwise 'v')
          --
          -- Can also be a function which gets passed a table with the keys
          -- * query_string: eg<EMAIL_ADDRESS>          -- * method: eg 'v' or 'o'
          -- and should return the mode ('v', 'V', or '<c-v>') or a table
          -- mapping query_strings to modes.
          selection_modes = {
<EMAIL_ADDRESS>= "v", -- charwise
<EMAIL_ADDRESS>= "V", -- linewise
<EMAIL_ADDRESS>= "V", -- linewise
<EMAIL_ADDRESS>= "V", -- blockwise
<EMAIL_ADDRESS>= "V", -- blockwise
          },
          -- If you set this to `true` (default is `false`) then any textobject is
          -- extended to include preceding or succeeding whitespace. Succeeding
          -- whitespace has priority in order to act similarly to eg the built-in
          -- `ap`.
          --
          -- Can also be a function which gets passed a table with the keys
          -- * query_string: eg<EMAIL_ADDRESS>          -- * selection_mode: eg 'v'
          -- and should return true of false
          include_surrounding_whitespace = true,
        },
      },
    },
  },
}

And the following sample code
     1  #!/usr/bin/env python3
     2
     3
     4  class A:
     5      def a(self):
     6          pass
     7
     8
     9  def f1(a: int):
    10      a = 1
    11      pass
    12
    13
    14  def f2(a: int):
    15      a = 2
    16
    17      def ff2(b: int):
    18          b = 2
    19
    20          pass
    21
    22      pass
    23
    24
    25  if __name__ == "__main__":
    26      f1(1)
    27      f2(2)

if you go online :18 and press daf, you will delete
    17      def ff2(b: int):
    18          b = 2
    19
    20          pass
    21
    22      pass

Expected behavior
I'm expecting to delete exactly
    17      def ff2(b: int):
    18          b = 2
    19
    20          pass

the pass on line 22 should still be there after dap.
Output of :checkhealth nvim-treesitter

──────────────────────────────────────────────────────────────────────────────
nvim-treesitter: require("nvim-treesitter.health").check()
Installation

WARNING tree-sitter executable not found (parser generator, only needed for :TSInstallFromGrammar, not required for :TSInstall)
OK node found v21.1.0 (only needed for :TSInstallFromGrammar)
OK git executable found.
OK cc executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl", "zig" }
Version: cc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
OK Neovim was compiled with tree-sitter runtime ABI version 14 (required >=13). Parsers must be compatible with runtime ABI.

OS Info:
{
machine = "x86_64",
release = "5.4.0-132-generic",
sysname = "Linux",
version = "#148-Ubuntu SMP Mon Oct 17 16:02:06 UTC 2022"
}
Parser/Features         H L F I J
- bash                ✓ ✓ ✓ . ✓
- c                   ✓ ✓ ✓ ✓ ✓
- diff                ✓ . . . .
- html                ✓ ✓ ✓ ✓ ✓
- javascript          ✓ ✓ ✓ ✓ ✓
- jsdoc               ✓ . . . .
- json                ✓ ✓ ✓ ✓ .
- jsonc               ✓ ✓ ✓ ✓ ✓
- lua                 ✓ ✓ ✓ ✓ ✓
- luadoc              ✓ . . . .
- luap                ✓ . . . .
- markdown            ✓ . ✓ ✓ ✓
- markdown_inline     ✓ . . . ✓
- python              ✓ ✓ ✓ ✓ ✓
- query               ✓ ✓ ✓ ✓ ✓
- regex               ✓ . . . .
- toml                ✓ ✓ ✓ ✓ ✓
- tsx                 ✓ ✓ ✓ ✓ ✓
- typescript          ✓ ✓ ✓ ✓ ✓
- vim                 ✓ ✓ ✓ . ✓
- vimdoc              ✓ . . . ✓
- yaml                ✓ ✓ ✓ ✓ ✓
Legend: H[ighlight], L[ocals], F[olds], I[ndents], In[j]ections
       +) multiple parsers found, only one will be used
       x) errors found in the query, try to run :TSUpdate {lang}

Output of nvim --version
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1692716794

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/__w/neovim/neovim/build/nvim.AppDir/usr/share/nvim"

Run :checkhealth for more info

Additional context
Add any other context about the problem here.

The problem is, if you set include_surrounding_whitespace = true and then use linewise mode, then it will try to include the whitespace before pass and then it will change into a line selection mode. That way the pass also gets deleted.

A possible solution is to change the include_surrounding_whitespace mode to activate only when it is a char-wise selection mode.

Another option would be to set the selection_modes of @function.outer to charwise, as it is the default. Therefore, it can be removed from the table. I encountered the same issue, and not only did this change fix it, but it also worked very well. If you set include_surrounding_whitespace to false, it will select the function from def to the first pass. Conversely, if you set it to true, it will select until the start of the second pass.
For reference
include_surrounding_whitespace = false
  |def ff2(b: int):
    b = 2

    pass|

include_surrounding_whitespace = true
  |def ff2(b: int):
    b = 2

    pass

  |pass

Changing @function.outer to charwise works for most operations (delete, yank, etc..) but it doesn't work with commenting actions (gc) since the cursor is still on the beginning of the next line and ends up commenting it out, for example (indentiation is important here) doing gcaf in fun1 (whether it's charwise or linewise):
    def fun1(self):
        pass

    def fun2(self):
        pass

becomes:
    # def fun1(self):
    #     pass

    # def fun2(self):
        pass

It is also better to yank/delete a method linewise to move it around. Yanking/deleteting it charwise results in weird indentation issues if you're not accounting for that. I have gotten it to work by adding a check if the selection mode is linewise to update the column end position to 0 before the update.selection call. Realize it's not the best solution but it seems to work well. I can get a pr out for this if the solution seems decent.


Setup oauth metrics

What does this PR do?
Setup oauth metrics
Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?
n/a
How to test this PR?
n/a

lgtm


Authentication

Hey,could you help me with the authentication? I have no ideea how can I do that in multi tenant application.

And how can I set up the endpoints for an user?

That's a pretty broad question. Conceptually, I think your steps here are going to be:

Choose an authentication library.  (Guardian or coherence)
You'll want to follow whatever their guidelines are, but move the migrations they generate into your multi-tenant migrations folder instead.
Create your tenants however you wish.  Not sure how to advise you here, since I'm not sure what you're building, but a seeds.exs file would make sense to at least create an admin tenant with an admin user
If you're doing a web app, the usual pattern is to choose the tenant by subdomain.  You can create a plug that will drop that into your 'conn'.  (Example of this plug below)
You'll then grab that value in your controller actions (def show(%{assigns: %{tenant: tenant}} = conn, params) do for example.  Now you'll have your tenant, which if you're using Ecto 2.1+ (I think that's the version) should be easy to use by passing it in as a prefix.

defmodule Api.Web.Plug.Subdomain do
  import Plug.Conn

  @doc false
  def init(default), do: default

  @doc false
  def call(conn, router) do
    case get_subdomain(conn.host) do
      subdomain when byte_size(subdomain) > 0 ->
        conn
        |> assign(:tenant, subdomain)
        |> router.call(router.init({}))
        |> halt
      _ -> conn
    end
  end

  defp get_subdomain(host) do
    host |> String.split(".") |> List.first
  end
end

Hope that helps.


Add "Kelvin" unit

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.50%. Comparing base (942011b) to head (0b877f3).
Report is 2 commits behind head on main.

Additional details and impacted files


doc:v0.1.0 document filing

What this PR does:
Which issue(s) this PR fixes:

Fixes #335
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #338 (3f14e90) into master (7f7a079) will increase coverage by 0.12%.
The diff coverage is 26.56%.

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   50.34%   50.46%   +0.12%
==========================================
  Files          99       98       -1
  Lines        5345     5362      +17
==========================================
+ Hits         2691     2706      +15
- Misses       2485     2487       +2
  Partials      169      169

Impacted Files
Coverage Δ

pkg/datasource/sql/datasource/mysql/default.go
25.00% <0.00%> (ø)

pkg/datasource/sql/datasource/mysql/meta_cache.go
0.00% <0.00%> (ø)

pkg/datasource/sql/datasource/mysql/trigger.go
0.00% <0.00%> (ø)

pkg/datasource/sql/exec/executor.go
1.81% <0.00%> (-0.04%)
:arrow_down:

pkg/datasource/sql/stmt.go
0.00% <0.00%> (ø)

...asource/sql/undo/builder/basic_undo_log_builder.go
46.87% <0.00%> (-0.75%)
:arrow_down:

.../sql/undo/builder/mysql_delete_undo_log_builder.go
35.93% <0.00%> (ø)

...ndo/builder/mysql_multi_delete_undo_log_builder.go
55.37% <0.00%> (-0.73%)
:arrow_down:

...ndo/builder/mysql_multi_update_undo_log_builder.go
43.70% <0.00%> (-0.74%)
:arrow_down:

pkg/datasource/sql/undo/executor/sql.go
49.00% <ø> (ø)

... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Greenkeeper opening duplicate branches

I've recently come across on one of my repos, greenkeeper creates a new branch identical to one already created.
It's trying to update the babel7 monorepo deps from 7.1.0 to 7.1.2 again in the new branch.
Related PR (direct link to greenkeeper's coment trying to do the same update): https://github.com/wolfy1339/m8tro-bootstrap/pull/64#issuecomment-429095240

Ping. This is happening in another repo of mine.
https://github.com/hellomouse/GNS


Cannot call method 'join' of undefined

Hi Dustin,
With the latest version (0.3.1), I always get this error Cannot call method 'join' of undefined. I tried both on Ubuntu 15 and Windows 10, same problem.

I tried with an older version of this plugin (0.2.6) and the deployment worked without changing anything in my Gruntfile.js (just updating the content of /node_modules/grunt-ssh-deploy) . But I need the features that have been recently introduced (options.release_subdir + options.release_root).
I tried running grunt ssh_deploy:digitalocean --debug but it didn't help me figure out what's wrong. Please let me know what debug information I should provide you to help me solve this.
Thanks!
PS: I'm cc'ing @julien731

What does your package.json and grunt task look like for it? Also what version of node do you have installed locally? I'm wondering if it's out of date even though this package has a certain version requirement.

Hi Dustin,
Thanks for looking into this.
Package.json
{
  "name": "getawesomesupport.com",
  "version": "0.1.1",
  "private": true,
  "devDependencies": {
    "grunt": "~0.4.2",
    "grunt-autoprefixer": "~0.8.2",
    "grunt-contrib-concat": "^0.5.0",
    "grunt-contrib-jshint": "^0.10.0",
    "grunt-contrib-less": "^0.12.0",
    "grunt-contrib-uglify": "~0.5.1",
    "grunt-contrib-watch": "~0.5.3",
    "grunt-dploy": "0.0.2",
    "grunt-grunticon": "~1.0.0",
    "grunt-keycdn": "0.0.3",
    "grunt-ssh-deploy": "^0.3.1",
    "grunt-svgstore": "~0.3.0",
    "grunt-uncss": "^0.3.8",
    "load-grunt-tasks": "~0.2.1"
  }
}

Deployment task
environments: {
	options: {
		local_path: 'test',
		current_symlink: 'awesome-support',
		deploy_path: '/srv/users/serverpilot/apps/wordpress/public/wp-content/themes'
	},
	digitalocean: {
		options: {
			host: '<%= secret.production.host %>',
			username: '<%= secret.production.username %>',
			password: '<%= secret.production.password %>',
			port: '<%= secret.production.port %>',
			releases_to_keep: '5',
			release_root: '/srv/users/serverpilot/apps/wordpress/public/wp-content/themes_releases'
		}
	}
},

Node version

0.10.31
Do you also need to check the results of npm list to see the locally installed packages? Is there anything else that I can provide to help figure this out?
Thanks

Try upgrading your version of node/npm.

God dammit, that worked! Many thanks
I installed the latest version of node/npm, and re-install all Grunt dependencies (remove the folder /node_modules/ and run npm install).
But when I deployed, I realized that there is another problem (linked with issue #30). With my current deployment task:
The generated release_root path is
/srv/users/serverpilot/apps/wordpress/public/wp-content/themes/srv/users/serverpilot/apps/wordpress/public/wp-content/themes_releases/20150915101703473

I want it to be only
/srv/users/serverpilot/apps/wordpress/public/wp-content/themes_releases

Is it possible to configure the grunt task like this release_root: '../themes_releases'?

Try setting release_root to just themes_releases since you already have deploy_path set to the directory.

I managed to finally get everything and I'm really happy with this deployment workflow. Here's the final task:
environments: {
	options: {
		local_path: 'dist',
		current_symlink: 'awesome-support',
		deploy_path: '/srv/users/serverpilot/apps/wordpress/public/wp-content/themes'
	},
	digitalocean: {
		options: {
			host: '<%= secret.production.host %>',
			username: '<%= secret.production.username %>',
			password: '<%= secret.production.password %>',
			port: '<%= secret.production.port %>',
			releases_to_keep: '5',
			release_root: '../themes_releases',
			zip_deploy: true
		}
	}
},
grunt.registerTask('deploy', ['build', 'copy:before_deploy', 'ssh_deploy:digitalocean', 'clean:after_deploy', 'keycdn:purgeZone']);

Thanks for the help.


PD011 in random code

I had a function such as:
$ cat foo.py
def foo(parser):
        parser.values.foo

$ ruff --select PD011 --fix foo.py
foo.py:2:2: PD011 Use `.to_numpy()` instead of `.values`
Found 1 error.

I don't use pandas.
I don't know the details of this check. Maybe further access can be checked? Or if pandas is imported in the code?
Otherwise just close the issue and I add this to the ignore list.

I thought we did do something like this (check if Pandas is imported). Let me check...

I'd recommend disabling PD altogether... It's kind of tough to condition these on the presence of import pandas statements, since it's not required to import Pandas in a module in order for any given variable to be a DataFrame.

Ran into this problem with torch.max when you do multi-dimensional max you get a namedtuple with attrs indices and values as in the example code:
>>> a = torch.randn(4, 4)
>>> a
tensor([[-1.2360, -0.2942, -0.1222,  0.8475],
        [ 1.1949, -1.1127, -2.2379, -0.6702],
        [ 1.5717, -0.9207,  0.1297, -1.8768],
        [-0.6172,  1.0036, -0.6060, -0.2432]])
>>> torch.max(a, 1)
torch.return_types.max(values=tensor([0.8475, 1.1949, 1.5717, 1.0036]), indices=tensor([3, 0, 0, 1]))

In our code-base, this was picked up by PD011. Perhaps there can be logic for cases where the use of .values are not pandas related, such as this.


Property check on dynamic wheres not entirely working

Larastan Version: 0.6.10
--level used: 6

Description
Replicating what I wrote in https://github.com/nunomaduro/larastan/pull/686#issuecomment-737501518
✔ This works / no error, because there is a column profiles.type:
Profile::whereType('test');

✔ This generates an error now in *stan (correctly 👍 ) because there's no profiles.yolo:
Profile::whereYolo('test');

produces
  57     Call to an undefined static method App\Profile::whereYolo().

❌ But this does not generate an error (although there's no profiles.yolo column):
Profile::whereType('test')->whereYolo('test');

Thank you!

Tried something here https://github.com/nunomaduro/larastan/commit/2581f3b255a6ad3f38301d088557a0ddc598dbf8 Can you test again with master branch? It should give you the error now.

It works 🎉
  42     Call to an undefined method Illuminate\Database\Eloquent\Builder<App\Profile>::whereYolo().

(btw, is there a way to not make phpstan wrap the lines in the terminal ? This drives me crazy)
Ran it over my whole (private) code base, found one other error but that was because I override the return result of a builder (for unknown reason) and thus lost the generics information of the model => removed the superfluous typehint => worked as expected.
Thank you!

(not sure if you want to close it now or when released, I'm fine with closing)

(btw, is there a way to not make phpstan wrap the lines in the terminal ? This drives me crazy)

PHPStan uses Symfony Console for commands, outputs and stuff I believe. So if you can do it with Symfony Console, you can do it with PHPStan :smile:
If it's fixed I will close it now, and release a new version.


Add support for custom readiness timeout seconds in istiod chart

We faced an issue when the istio-proxy sidecar became unready when receiving a lot of requests, we want to increase the timeoutSeconds (readiness probe) to allow requests (even with a big delay) to pass to our microservice.
The current chart values file does not support adjusting the timeoutSeconds value of the readiness probe (adjusting with kustomize seems to be not easy and ugly), so I created this PR to allow devs like me to adjust the values to my needs.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ X] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @Rez0k. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test
is there any related issue?

@Rez0k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests-arm64

unit-tests_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests-arm64

unit-tests_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests

gencheck_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

We haven't opened an official issue, I think the timeoutSeconds should be adjustable, this is a need me and my team are now facing with the istio sidecar container.

/retest-required

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests

gencheck_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test gencheck

unit-tests-arm64_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests

unit-tests-arm64_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests-arm64

gencheck_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests-arm64

gencheck_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test gencheck

unit-tests_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test gencheck

unit-tests_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test unit-tests

unit-tests-arm64_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d1b245ff5d0edaaf22ed236012de2d133bc4beac
link
true
/test gencheck

unit-tests-arm64_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test unit-tests-arm64

unit-tests_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test unit-tests-arm64

unit-tests_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test unit-tests

gencheck_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test unit-tests

gencheck_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test gencheck

unit-tests-arm64_istio
ddad4b3a6183613562ed730cc4ec01d8351e16dc
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
14eedd1ae331055bfea7186abb3abfd2a965ffe2
link
true
/test gencheck

unit-tests-arm64_istio
ddad4b3a6183613562ed730cc4ec01d8351e16dc
link
true
/test unit-tests-arm64

unit-tests_istio
ddad4b3a6183613562ed730cc4ec01d8351e16dc
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rez0k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
ddad4b3a6183613562ed730cc4ec01d8351e16dc
link
true
/test unit-tests-arm64

unit-tests_istio
ddad4b3a6183613562ed730cc4ec01d8351e16dc
link
true
/test unit-tests

gencheck_istio
ddad4b3a6183613562ed730cc4ec01d8351e16dc
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This seems like a really bad idea. If the proxy isn't responding in 3s, its not ready -- its pretty much super broken? Are you sure you want to increase it?
BTW, it needs to fail 30 times in a row to be unready

yes, its relevant especially for busy nodes (high CPU usage) or to edge cases for k8s scheduler This PR just adding this capability to change the timeout to the same value as the default , users should take their own responsibility for those changes

Its also our responsibility to not provide users with a way to cause outages easily. And to not introduce ever-growing complexity into the product by exposing 1000s of options that should not be configured, though.

This seems like a really bad idea. If the proxy isn't responding in 3s, its not ready -- its pretty much super broken? Are you sure you want to increase it?
BTW, it needs to fail 30 times in a row to be unready

yes, its relevant especially for busy nodes (high CPU usage) or to edge cases for k8s scheduler This PR just adding this capability to change the timeout to the same value as the default , users should take their own responsibility for those changes

Its also our responsibility to not provide users with a way to cause outages easily. And to not introduce ever-growing complexity into the product by exposing 1000s of options that should not be configured, though.

so, you are saying this PR is not going to be approved, tnx for the response


Initialize 2.4.1.dev0 version

Coverage remained the same at 89.062% when pulling aa36eb7a61d57279dc91eea8166ab169db9f3613 on release/dev into 9fa8783213e99ed90271316a158c91df63c92d2c on master.


Error in "static/js/bundle.js" file

Hi,
I have tried the option with npm client and managed to connect to the server. However, when further click one character to talk with, I got this error:

Searching on Google suggests that the syntax used in the js file only work with https instead of http. Is there any suggestios?
Thanks a lot!

As suggested in another issue, you would need to set up SSL if you want to deploy remotely


[BUG]: XCCK - Fix Error method XCube_IntArrayProperty::XCube_IntArrayProperty

Which module?
legacy
Description of the bug
Fatal PHP ERROR
Error: Call to undefined method XCube_IntArrayProperty::XCube_IntArrayProperty()
Steps To Reproduce

go to module construction kit
add a new definition
create new tyype field "checkbox"
ex)
Sports|1
Game|0
Travel|0
Add new page
Fatal Error

Additional Information
Module Construction Kit

Module is not supported by the developer and is not available in XCL bundle.


Set default calendar

is there a way to set a default calendar without having to to specify --calendar everytime?
ie)  gcalcli quick "11:00 tomorrow Lunch" --calendar "mycal"
can be:
gcalcli quick "11:00 tomorrow Lunch"

There's a defaultCalendar option, apparently, but I haven't been able to figure out how to set it or use it.

Best place to set it is in your .gcalclirc file:
--defaultCalendar=brian.andrew#red

Make sure each option is on it's own line.

Thanks tresni. I was trying to set in from the command line but that wasn't working


Refactor BMC provider opener to probe concurrently

Summary
In the Tinkerbell project where we leverage bmclib in Cluster API contexts we've had reports of BMC interactions taking too long resulting in CAPI components rolling nodes it thinks are faulty. As part of the investigation we dived into the timeout capabilities available in bmclib when connections/interfaces are initial established/probed and found a user can either (1) specify a static timeout that's shared among all providers (IPMI, Redfish etc) or (2) specify a per provider timeout that will linearly grow the total timeout applied with the total providers attempted.
This change alters the algorithm to open connections to operate concurrently. By operating concurrently we stand a better chance of giving each provider the maximal timeout period to establish its connection and avoid the linear growth with per provider timeouts.
We haven't benchmarked this change and acknowledge systems that don't offload network IO or are single CPU won't necessarily benefit but given modern consumer hardware is generally multicore we anticipate it will bring a general improvement.

Thanks for the efforts here! Could we also include a check for Goroutine leaks in TestOpenConnectionFromInterfaces so its covered for now and any changes going ahead.

I was almost ready to open a PR.

Nice, I did this quite late so haven't verified everything. Lets compare the approaches and see what we prefer.

Thanks for the efforts here! Could we also include a check for Goroutine leaks in TestOpenConnectionFromInterfaces so its covered for now and any changes going ahead.

Overlooked this comment, will add it in.

@joelrebel The goleak tests should be in-place.


(PA-652) Bump Puppet version to 4.8.1

This updates the Puppet version to 4.8.1 following the release of 4.8.0
as part of puppet-agent 1.8.0.

Travis commit checker is failing because it requires a PUP ticket. Do we want to allow to fail, or switch to maint? Might it be worthwhile to add PA tickets to the whitelist?

For this sort of thing I usually use (packaging) as the prefix.

+1 to (packaging)

Updated

CLA signed by all contributors.

👍