Update contribute.md

Problem

In contribute.md  under the heading Recommended Setup for WordPress Coding Standards in item 3 titled Confirm Installation the suggested PATH will not work with linux Ubuntu 20.04 distribution. Instead this one below works:
export PATH="$HOME/.config/composer/vendor/bin:$PATH"

I followed the outlined contributing instructions but as I was using composer to install the php code sniffer instead of creating a .composer folder for the configs the system created a .config/composer directory. The differences in the installation procedure might be either due to differences in OS or its coming up because of updates.

Prospective contributors are not advised to run composer install after project setup so as to install package dependencies

In addition to contributors should be informed that dependency Quelat will not load automatically despite being a mu-plugin and advised how to proceed. I personally used the composer auto-loader.

Description

I recommend we update contribute.md and add that detail so as to ensure faster on-boarding of linux Ubuntu contributors.
Alternatives

N/A

Implementation

Edit the docs where there is a problem area, by just adding a statement detailing what would work for Ubuntu users and also by enriching the docs' content so as to make it more intuitive.

[x]  I would be interested in implementing this feature.

Hey @JackieBinya thank you so much for pointing this out
You're right about the incomplete documentation (still a work in progress)
I'll appreciate your contributions regarding this
Thanks!


[Draft] Add AutoRound support

What does this PR do?
New Feature: Support AutoRound quantization algorithm which has shown benefit for finetuning https://substack.com/@bnjmnmarie/p-147609171
Before submitting

[x] Did you read the contributor guideline?
[ ] Did you write any new necessary tests?
Not yet, only draft now, but test locally

Hi @hiyouga
After attempting to integrate AutoRound, I’ve encountered several issues, and one in particular that I’d like to discuss with you first.
Quantization Order: I’ve noticed challenges related to quantization with GPTQ on multiple GPU devices. Specifically, the torch parallelization seems to distribute the quantization process across different devices, which doesn’t appear optimal. Additionally, I’ve encountered exceptions after the quantization process."ValueError: You can't train a model that has been loaded with device_map='auto' in any distributed mode. Please rerun your script specifying --num_processes=1 or by launching with python {{myscript.py}}."
To avoid conflicts between settings for models during quantization and fine-tuning, I’ve opted to quantize the model first, followed by fine-tuning. However, I believe there’s room for improvement in the code.
Which approach do you prefer? Would you rather merge the quantization process into the model loading phase, or is the naive method I proposed acceptable? I would appreciate your input.
Thank you!

Hi @hiyouga， could you kindly take a look?


Segfaults on Appveyor

These Segfaults look like they come from WinRPM:
https://ci.appveyor.com/project/SimonDanisch/freetype-jl-bl4qr
Any ideas?

WinRPM.jl#53 Is this related?

if you're running with julia-debug, then this is a new similar problem. There's a base issue on it. Needs someone to bisect.

Okay, seems to work without debug :) Guess I leave this open for now...

https://github.com/JuliaLang/julia/issues/14560

Not really sure why it fails again after changing the README....
https://ci.appveyor.com/project/SimonDanisch/freetype-jl-bl4qr/build/job/tkcj6g0w2d2siqi7

new nightlies, LibExpat.jl is broken on llvm 3.7 and probably not just on windows. it's doing something fishy with an empty union ccall return type

I've filed a separate issue (https://github.com/JuliaLang/WinRPM.jl/issues/63) for the ReadOnlyMemoryError, as it took me a while to understand that it's the same as the bug you described in the last comments. I suppose many people are going to report this once the get AppVeyor to fail. Better keep issues separate.

Should we close this now that the ReadOnlyMemoryError is gone?

Does it work with julia-debug now?

seems fine: https://ci.appveyor.com/project/SimonDanisch/freetype-jl-bl4qr/build/1.0.7/job/eha0ta1iwfmm5045
Is julia-debug the preferred option for appveyor?

No, not really, but it breaks more often so I"d hope someone tests it occasionally.


enable IntelliSense builds

/cc @rpetrusha

@mairaw, sorry -- I won't merge. The build hasn't completed


Fix dependency on unmaintained and vulnerable trait

Hey, this trait depends on typemap, which is unmaintained, and depends on unmaintained crate "unsafe-any", which depends on another unmaintained crate AND vulnerable crate "traitobject".
Are there any mitigation steps that we can take?

+1
I discovered this when my minimal-versions test failed.

Yes we need to replace typemap.

@estk is there any work planned regarding this issue?

@GiorgioBertolotti it's not currently a vulnerability, it may become one in the future.
The exploit is possible given a different memory layout since rust's layout is not stabilized. I would love to move away from it but... https://github.com/reem/rust-typemap/issues/45 has discouraged me.
Searching crates.io I see https://crates.io/crates/typemap_rev which seems to be maintained by the discord folks, so I guess that seems fine. I or someone else needs to then just do the migration. I will not have time in the next few weeks but I encourage anyone interested to take a crack at it, I will of course try to do timely code reviews and provide any mentorship necessary.

@estk Thank you for the detailed explanation.
I tried to take a look at the typemap_rev crate you recommended but honestly I'm afraid that as of today it is not mature enough to cover all the typemap features.
For example typemap_rev does not implement in trait Clone which is currently used in log4rs. There is an open issue but it has been there since April 2021....
This is just one example but could be limiting in several other ways.
Unfortunately not knowing the codebase of log4rs I can't tell if there are other possibilities to replace the crate typemap, do you have any suggestions?

FYI As traitobject, unsafeany and typemap are unmaintained I've pulled https://github.com/philip-peterson/destructure_traitobject/ into unsafe-any here https://github.com/No9/rust-unsafe-any/commit/e0c79e23f0265597f6ab92b296296ff6f474e174
and updated typemap here https://github.com/No9/rust-typemap/commit/f15452a41e34ecdee89852b7727a0cac221ef3e7
I've then pulled typemap into a fork of log4rs here https://github.com/estk/log4rs/compare/master...No9:destructure_traitobject_fix
The tests in all the repos pass but it's probably not a good idea to create a PR from a set of repos under my account.
While this isn't ideal it might be a useful interim measure and I'm happy to move the code to a shared place or whatever makes sense.

Hey @No9 we should probably file unmaintained for unsafe-any and could point to your fork ?
Also if you have typemap fork going we could include it as alternative - there is also another one

Add unmaintained typemap - https://github.com/rustsec/advisory-db/pull/1406
Add unmaintained traitobject - https://github.com/rustsec/advisory-db/pull/1390

Would you be publishing typemap and unsfe-any fork's to crates.io ?

@No9 @pinkforest thanks for staying on this one. @No9 it seems there is an appetite for having access to your forks via crates.io. One question tho, what do you mean by this?

The tests in all the repos pass but it's probably not a good idea to create a PR from a set of repos under my account.
While this isn't ideal it might be a useful interim measure and I'm happy to move the code to a shared place or whatever makes sense.

If the authors/maintainers of those crates are unresponsive I suggest you just create new crates.io projects so long as you have the bandwidth for long-term maintenance of said resources.
My only objection to using forks is that I prefer not to directly depend on a git repo.

Happy to publish these to crates.io I'll look at it over the weekend and update my fork.
I can take the maintenance for the short/medium term but I think it would also be a good idea to give @estk or someone else admin access to the forked repo too so this doesn't happen again.

You could always start a github organisation and then give publish right to team in the github organisation
That's what we do e.g. with cargo-geiger where we got cargo-geiger admins under wg-secure-code
I've been meaning to start orphanage-rs GH org to cater these crates that need new adoptees and that could use maintainer bus

@pinkforest I really like the idea of orphanage-rs. I'd be happy to pitch in where i can.

k. I started orphanage-rs and we can create teams based cargo publish from there and move the forks there

Dependency repos have moved to orphanage-rs with some additional housekeeping done (clippy/fmt/CI).
https://github.com/orphanage-rs/rust-unsafe-any
https://github.com/orphanage-rs/rust-typemap
Crates published and invites sent to @pinkforest and @estk
https://crates.io/crates/unsafe-any-ors
https://crates.io/crates/typemap-ors
I've PRd updates to this repo to use typemap-ors
https://github.com/estk/log4rs/pull/275

Are we all set on this now that we use typemap-ors?


Add a wiki: Bloons

Link to origin wiki:
https://bloons.fandom.com/wiki/Bloons_Card_Storm
Link to destination (independent) wiki:
https://www.bloonswiki.com/Bloons_Card_Storm

Thanks for the submission!
I believe it's still premature to add the independent Bloons Wiki (Fandom has 5,500+ articles, indie has 3,000+). See https://github.com/KevinPayravi/indie-wiki-buddy/issues/802

oh, i didn't know someone else had suggested it lol.
guess i'll contribute what i can. Don't know much about the series though, so i might just help copy pages from fandom or something.


Why is api.Pod.Host not called api.Pod.Node?

It's minor, but now that I see it, I can't unsee it.
@bgrant0607

We also still have LOTS of references to "minion".
Eventual consistency is the best we can hope for. :-/

@thockin you just saved me from opening this exact issue :)

Should it be NodeID or NodeName (whichever it is)? Since Node could imply that it's the whole object.

NodeName

Part of the v1 API: #7018


Can I install .aab files with it?

dadb is functioning similarly to a regular adb in that regard, meaning you would need to do some preparation before aab can be installed. This StackOverflow answer explains it well: https://stackoverflow.com/a/50465619/926907


Provide sharing to Android Feature

Add Feature to share tasks with other Android apps (i. e. Email, Threema,  ES File Manager)

@lemonboston please take care of this. The share option should appear in the menu of the task detail view.
The share option should share a text document that contains all the details.

@dmfs ok, just to confirm, the text document here will be just an easy to read, custom (non-standard) format not an .ics (iCalendar - VTODO) file, right? Thanks.

I wanted to print all available data for a task, so using the code below from ViewTaskFragment:
List<FieldDescriptor> fields = model.getFields();
// iter over fields:
Object o = field.getFieldAdapter().get(contentSet);
sb.append(field.getTitle()).append(": ").append(o.toString()).append("\n");

I got this output for a local task for which I filled out every field in the Edit task screen:
List: -15108409
List: My tasks
List: Local
Title: task title
Status: 2
Location: locationtext
Description: desc
Check list: [org.dmfs.tasks.model.CheckListItem@3d10ff95, org.dmfs.tasks.model.CheckListItem@37b24e02]
Start: 20160923T171500Europe/Budapest(5,266,7200,1,1474643700)
Due: 20160928T140500Europe/Budapest(3,271,7200,1,1475064300)
All Day: false
Time Zone: libcore.util.ZoneInfo[id="Europe/Budapest",mRawOffset=3600000,mEarliestRawOffset=3600000,mUseDst=true,mDstSavings=3600000,transitions=152]
Completed: 20160930T190000UTC(5,273,0,0,1475262000)
Percent complete: 100
Priority: 5
Privacy: 2
URL: http://someurl.com
List: My tasks (Local)

So I assume this is all the available data to include in the shared text. (?)
Below is a first proposal how we could format it for the shared text. List, Status, and Percent complete fields are not added. (If any property is not present, that line won't be added.)
@dmfs Please let me know if something like this would be okay.
Task from OpenTasks:

Title: <task title>
Description: <task description>
Check list:
 - <checked/unchecked with special char?> <check list item 1>
 - <checked/unchecked with special char?> <check list item 2>
Location: <task location>
Start: <start date time>
Due: <due date time>
Completed: <completed date time>
Time Zone: <time zone>
Priority: <priority text>
Privacy: <privacy text>
URL: <url>

I don't think that we need the labels for all of the items. In some cases it's pretty clear what it means. Also The title doesn't need to be "Task from OpenTask". IIRC the share intent has a "title" extra. That should be the title of the task. As for the content I think we could do something like this.
<task title>
============

<task description>
[X] checked list item
[ ] unchecked list item

Start: <start date time> <timezone>
Due: <due date time> <timezone>
Completed: <due date time> <timezone>
Priority: <priority text>
Privacy: <privacy text>
<url>

Shared by OpenTasks

Of course, if a field is missing the entire line should be omitted.
Ideally we can make it compatible to Google Keep. As it happens OpenTasks can understand the notes and checklists shared by Google Keep (by coincidence they use the same format for the check list items). Not sure about the due dates though.
Ideally we use some sort of template that we can localize.

Why don't you use iCalendar format/type or let the user choice which format to use (plain text or iCalendar)? It would also be useful to share single tasks in iCalendar format to other people, who could import the task directly into their task list.

@korelstar maybe later. I think it's reasonable to start with a simple option. We surely can improve it later on.
Also, I think that it's probably better to add participants instead (which is similar to attendees for calendars). Adding participants will make sure that they will get updates when we modify a task (we can't do that when sharing it in an email, because the recipient will be unknown to OpenTasks).

Okay

A few questions about implementation:

Should we force app chooser or not upon sharing? (docs1, docs2 - they suggest forcing chooser for sharing).
If we don't force then the first time all apps are shown, the 2nd time the last time selected one is brought up and choice offered to select it as always, which would result that next time that app opens automatically without question. This can only be reset in device settings.
If we force chooser, all apps (and contacts) are shown always without highlighting the last one, so user always have to find the app in the list, which might need scrolling.
Should the task title be part of the body or not?
We can send the texts as EXTRA_TEXT and EXTRA_SUBJECT in the Intent. If it is received by an email app, it will be the email body and subject respectively. Also, Google Keep will use EXTRA_SUBJECT as the task title and EXTRA_TEXT as the content. So it is fine, but if the receiving app wants to save the text as a file, for example I tried it with Total Commander, then only EXTRA_TEXT will be used for the content of the file, so we could loose task title.

With title in the EXTRA_TEXT as well:

I would like to just double-check if status (needs action/in process/done/cancelled/incomplete) would really be needed. I ask it partly because it is the only property that gets added by default. So even if the task only had title and we share it, the line "Status: needs action" is added. The other reason why I ask it is because if I imagine sharing a task, I think the status of it would probably not be relevant. It is a changing property and if I share a task, it probably means that it has to be completed or I want to share/save some information. But I probably don't do it as a way to create a snapshot of the status of the task. I might be wrong, I am not actually a user, so I am not sure.
What do you think, add status or not?

Thanks.

Yes, we should force an app chooser. We can not assume that users always want to use share with the same app (and it's annoying to have to go to the settings and to reset the defaults if you hit the wrong button).
However, some apps show two share options, a generic one and another one for the last app that was selected (in which case no chooser is shown). Not sure how that feature is called and if there is a support utility for that.
In addition it might be useful to show our own app chooser. That way we could let the user select the app before we build the intent. If we know the target app before we build the share intent we can build a more adequate share intent. That way we could omit the title when sharing with Google keep or a known email app. Later on we could share it as an IMIP message when sharing with a known email app or share it as HTML if we know the target supports it.
For now we add the title to the document as well.
Yes, I want the status in there. It could be sufficient to add the progress, but not all task models have a progress. The only case in which we probably can omit the status is when the task has been completed (because we have the completed date in there).
It also occurred to me that we probably should be able to parse the format that we share. What do you think?

@lemonboston  We don't use Google Translate for translations. For now we keep the English version, you can do the Hungarian and I do the German translation.

In terms of architecture, I'd prefer something like this:
public final class SharedTaskText implements CharSequence {
  ...
}

That's applied like so
CharSequence sharedText = new SharedTaskText(contentSet);

I.e. using an adapter pattern that adapts the task to a CharSequence (which can be converted to a String using toString()).
In general I'd prefer this more "declarative" approach.

Thanks for the clarifications and input.

The only case in which we probably can omit the status is when the task has been completed (because we have the completed date in there).

I've updated code to omit status for completed task.

@lemonboston We don't use Google Translate for translations. For now we keep the English version, you can do the Hungarian and I do the German translation.

Okay, if you let me know the German ones, I will update:
<string name="activity_task_details_share">Share</string> // menu item short name
<string name="activity_task_details_share_task">Share task</string> // menu item long name
<string name="share_footer">Shared by OpenTasks</string>

For the Hungarian one, could you please check if it has been merged to staging? I couldn't find it.

Regarding parsing the format we share, yes, I think you are right, it probably makes sense that if OpenTasks receive the same text shared that it created than it could parse it back to a task.
I don't know how often this would be used, but I assume much rarely compared to sharing, maybe like 10 to 1, so I think it would make sense to treat it as a separate feature and complete this one first. But of course it's worth thinking forward about implementation now, to see if it could affect text format or anything else.
I don't have much experience with templates, parsing, but I looked up template engines libraries a little bit now to see if they can parse as well, but it looks like they can't (I guess that is not a straightforward problem). So I assume now that regardless of how we generate the format, we will probably need a separate solution for parsing. Perhaps regular expressions for each field and some logic (a lib here, although we would be probably better off writing our own custom logic). Assessing whether a shared text is actually in our format or not might be the trickier part: checking for the footer might not be enough, cause user could delete that, so probably checking for our title format as well. Not sure if we should change anything in the format to make parsing easier. Any ideas, suggestions?
I think this is probably the only thing we need to do at this point, to make sure the format is parseable theoretically. (Note: I suppose we will only be able to parse texts that are in the actual language used.)
What do you think?

Regarding the adapter pattern and declarative style for representing the texts, I've implemented it on a separate branch (172-share-task-declarative-text), please check it out.
However, for me it doesn't seem to add anything in this case, because we right away call toString() on them:
So it changed from this:
String title = mTextComposer.title(contentSet, model);
String body = mTextComposer.body(contentSet, model);

to this:
String title = new TitleText(contentSet).toString();
String body = new ShareTaskText(contentSet, model, mActivity).toString();

So it's the same thing as someone noted for yegor's Max object example (unfortunately that very good comment disappeared*), that we would only create this transient object just to immediately calculate a value with it. ("..it represents a continuation that you'll most likely immediately discard").
And even if we didn't discard the object immediately, then I would have concern that the captured context (ContentSet, Context) would live on, risking leaking.
So I would go with the 'function' way in this case, let me know how you would prefer.
*I had it saved in an email:

Depending on what kind of a problem you are modeling, certain parts of code are better to express using OO paradigm, others using functions and function composition. They should be used when most appropriate.
Creating a new class just to express a pair of numbers that you can take a maximum of makes sense if these two numbers are always operated on as a pair and/or if the object will have an intransient existence. More often than not, though, you'll be taking these numbers individually from various sources and creating the Max object only to calculate its value. Such object is a functor; it represents a continuation that you'll most likely immediately discard. It seems like gratuitous obfuscation if you ask me.

App chooser is forced now, the title for the chooser is "Share task" now, the same string as for the menu item.
It would be possible to use a much longer text there (screen wide in normal text font), like "Share task as text" or "Share task  details as text", if needed.

Should we force app chooser or not upon sharing?

Did you have a look on the ShareActionProvider? I think that is state of the art for sharing in Android.
See https://developer.android.com/training/sharing/shareaction.html

@korelstar That's what I meant. Unfortunately it only works by providing the share Intent upfront. AFAIK it doesn't allow to build an intent that's specific to the target.
Anyway, it's good enough for now.
@lemonboston, please use the ShareActionProvider.

I saw that in the docs with this note, so I didn't look into:

Note:  ShareActionProvider is available starting with API Level 14 and higher.

But I see that there is a v7 support library version, so I will check it out. Thanks.

Added ShareActionProvider, and it's much nicer with that:

It lists the last used app first, so it's quite user friendly.
(Code on PR #277)
Unfortunately it is not possible to detect which app the user selects as you suspected @dmfs.
So currently the title is added to the body, too.
An alternative could be to add 2 submenus to the share menu item, like : "...as title and body" and "..as one text", or maybe add settings to the app so user can change the default behavior.
Video on how the submenu would look like (on Android 6.0.1): link
What do you think?

@dmfs Could you please provide the German transations for these new strings?
    <string name="opentasks_task_details_menu_send_short">Send</string>
    <string name="opentasks_task_details_menu_send">Send to</string>

Both are for the menu item label (the short one is not used normally).

Oh, and this one, too:
    <!-- Outgoing share -->
    <string name="opentasks_share_footer">Shared by OpenTasks</string>

(The footer of the shared text message)

    <string name="opentasks_task_details_menu_send_short">Teilen</string>
    <string name="opentasks_task_details_menu_send">Aufgabe teilen</string>
    <string name="opentasks_share_footer">Geteilt mit OpenTasks</string>

@dmfs Thanks, there is one more missing DE translation from earlier:
<string name="opentasks_details_no_task_selected">No task selected</string>

It is displayed in the middle of the empty details view fragment.

<string name="opentasks_details_no_task_selected">Keine Aufgabe ausgewählt</string>

merged

ah, now quite but almost. Still need to rebase and resolve conflicts.


add nullptr check

@zehuaiWANG: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
1fde745fc45b5f704144f6633b8186b783444e32
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zehuaiWANG: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
22c7564e3b2373f1b87696adb679d5124851b9dc
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Multi consumer ringBuffer.next () blocked

public static void init() {
//创建RingBuffer
ringBuffer = RingBuffer.create(ProducerType.MULTI, new EventFactory() {
@Override
public ConductAudits newInstance() {
return new ConductAudits();
}
},64,new YieldingWaitStrategy());
//通过ringbuffer创建屏障
SequenceBarrier barrier = ringBuffer.newBarrier();
//创建消费者组
LogBatchHandler[] consumers = new LogBatchHandler[10];
for (int i=0;i<consumers.length;i++){
consumers[i] = new LogBatchHandler();
}
//构建消费者工作池
WorkerPool workerPool = new WorkerPool(
ringBuffer,
barrier,
new EventExceptionHandle(),
consumers);
//设置多个消费者的sequence序号
ringBuffer.addGatingSequences(workerPool.getWorkerSequences());
//启动workpoll
ExecutorService pool = Executors.newFixedThreadPool(12);
workerPool.start(pool);
if (ringBuffer!=null){
LogCache.ringBuffer.put("ringBuffer",ringBuffer);
logger.debug("Disruptor容器启动成功！");
}else {
logger.debug("Disruptor容器启动失败！");
}
}
Problem description：
If used in this way
LogBatchHandler[] consumers = new LogBatchHandler[10];
ExecutorService pool = Executors.newFixedThreadPool(12);
result：obtain ringBuffer.next () is normal
LogBatchHandler[] consumers = new LogBatchHandler[12];
ExecutorService pool = Executors.newFixedThreadPool(10);
result：
obtain ringBuffer.next () is abnormal
conclusion：
Executors.newFixedThreadPool () The parameter of must be greater than the parameter of new logbatchhandler []

This is expected behaviour.
You are instructing the ringbuffer to gate on all the workers, but aren't providing enough threads to run them all.
Once the ringbuffer would wrap and overwrite unprocessed data, next() will start blocking.

Ok thanks
发件人: Sam Adams<EMAIL_ADDRESS>发送时间: 2020年9月2日 16:30
收件人: LMAX-Exchange/disruptor
抄送: 郭家林; Author
主题: Re: [LMAX-Exchange/disruptor] Multi consumer ringBuffer.next () blocked (#303)
This is expected behaviour.
You are instructing the ringbuffer to gate on all the workers, but aren't providing enough threads to run them all.
Once the ringbuffer would wrap and overwrite unprocessed data, next() will start blocking.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/LMAX-Exchange/disruptor/issues/303#issuecomment-685442846, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKLLXRXIHPJ453OD3PFEKWLSDX7B7ANCNFSM4QSVEROQ.


Move ID and storage URL into FileMetadata

In preparation for implementing Google Drive export of report data, add fields for
the file ID and storage URL to FileMetadata. Since we use that class both for
new file uploads and for fetching existing files, introduce typealiases to make
the new fields null or non-nullable using the same scheme we use for other model
classes.
Remove redundant parameters and fields in places where we already have a
FileMetadata with the required information.
No change in client-visible behavior.

Current dependencies on/for this PR:

main

PR #1006   👈

This comment was auto-generated by Graphite.


Feature/green steel ammonia

Change to using installation-relative path specifications, in order to step towards better tool/project separation.
With these, code should still function as previously, but if, e.g., HOPP/green_steel_ammonia_run_scenarios.py were run outside of the HOPP directory (and with appropriate adjustments to imports), the tools from hopp_tools_steel.py and other helpers would load successfully.

This looks fine to me. Requesting others reviews from primary authors/users.


IntelliJ 12.1.6 RSS feed not working

Hi,
thanks for the very helpful plugin. Unfortunately the rss feed seems not to get picked up. I managed it only once to get a rss message inside the event log by jenkins. But except of this I never see any message from jenkins inside the log. It does not work either automatically (5 minutes) nor manually by hitting the button. The job view works as intended.
Any ideas?

Hi,
please test the latest version of the plugin and tell me if it works.
Sorry for being late in processing your request

If error still occurs with 0.11.0 please feel free to reopen.


JAMES-3558 JMAP Email/changes: moves should be considered as updates

Rebased to squash fixups... No changes beyond this.


Won't reconfigure

Today Drivvo has come up that it needs reconfiguring but when I try it says invalid authentication.
My email and password have not changed so I don't understand why.

The same issue has been occurring for me since today. Is there a solution yet? Thanks in advance.

The same issue has been occurring for me since today. Is there a solution yet? Thanks in advance.

Yesterday it worked again...


Improving VT Hits & Hiding Manual Pull

Added in two features;

The option of using multiple AntiVirus Vendors, bringing back the best suited (earlier in the Array)
This is enabled by use of $av_multiple in config
The ability of the manual pull of VT, Crits to be hidden, so that it can be done as crontab or automatic pull

I do like that AV array option, nice feature!

Thanks, I implemented a similar thing in a different project of mine, and thought the same concept would be well suited here!


Fix formatting of authentication methods

The order of the authentication methods in the docs is a bit broken, this should fix it.

@der-eismann Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Not signing CLA because of an “Obvious Fix”.

@der-eismann This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

Thanks a lot, that's merged now.


bootnode connect to itself

After deploying bootnode https://github.com/threefoldtech/tf_operations/issues/1455 for testnet got this error message
Docker image :  threefolddev/tfchain:2.2.0-rc8
bootnodes /ip4/<IP_ADDRESS>/tcp/30333/ws/p2p/12D3KooWHe8Wbn6dDbyxXietaXSRTZJfykPRgrkJDjXh9xZ4383k

2023-02-28 09:23:44 💔 The bootnode you want to connect to at`/ip4/<IP_ADDRESS>/tcp/30333/ws/p2p/12D3KooWHe8Wbn6dDbyxXietaXSRTZJfykPRgrkJDjXh9xZ4383k` provided a different peer ID `12D3KooWD2gguzT2zFKuet4ZFsJniHH1SdDn2yaNPH5MVQQ6bYSN` than the one you expect `12D3KooWHe8Wbn6dDbyxXietaXSRTZJfykPRgrkJDjXh9xZ4383k`.

Why do you think it connects to itself? Can you show me the logs from start up until you receive this message?

/ip4/<IP_ADDRESS>/tcp/30333

because /ip4/<IP_ADDRESS>/tcp/30333.. is the ip of the local docker bridge

ip : <IP_ADDRESS>
logs :

same on 03.bootnode.main.grid.tf
image: ghcr.io/threefoldtech/tfchain:2.2.1
bootnodes /ip4/<IP_ADDRESS>/tcp/30333/ws/p2p/12D3KooWLtsdtQHswnXkLRH7e8vZJHktsh7gfuL5PoADV51JJ6wY

@PeterNashaat  @coesensbert  can we close this one now

No I think the issue remains. @PeterNashaat ?
I'll test with a new node and see if it syncs

new test node tfchain-test-pub-synctst started syncing, follow it here: https://telemetry.tfchain.grid.tf/#list/0x0378abe88c21bd382106e7977902eef4f542bb2d3e67e8a318151e323b2d0660
root@Main-Grid-BE-bknd-3:/storage# docker logs -f --tail 50 tfchain-test-pub-synctst
2023-11-06 13:08:40 Substrate Node
2023-11-06 13:08:40 ✌  version 2.2.0-rc8-unknown
2023-11-06 13:08:40 ❤  by Substrate DevHub <https://github.com/substrate-developer-hub>, 2017-2023
2023-11-06 13:08:40 📋 Chain specification: Tfchain Testnet
2023-11-06 13:08:40 🏷  Node name: tfchain-test-pub-synctst
2023-11-06 13:08:40 👤 Role: FULL
2023-11-06 13:08:40 💾 Database: RocksDb at /storage/chains/tfchain_testnet/db/full
2023-11-06 13:08:40 ⛓  Native runtime: substrate-threefold-123 (substrate-threefold-1.tx2.au1)
2023-11-06 13:08:42 Using default protocol ID "sup" because none is configured in the chain specs
2023-11-06 13:08:42 🏷  Local node identity is: 12D3KooWFyQsusopQ3iaRkNE53KHzsYHJPiAPYL9NiDYDt3XMQKK
2023-11-06 13:08:42 💻 Operating system: linux
2023-11-06 13:08:42 💻 CPU architecture: x86_64
2023-11-06 13:08:42 💻 Target environment: gnu
2023-11-06 13:08:42 💻 CPU: Intel(R) Xeon(R) E-2336 CPU @ 2.90GHz
2023-11-06 13:08:42 💻 CPU cores: 6
2023-11-06 13:08:42 💻 Memory: 64206MB
2023-11-06 13:08:42 💻 Kernel: 5.15.0-25-generic
2023-11-06 13:08:42 💻 Linux distribution: Ubuntu 20.04.5 LTS
2023-11-06 13:08:42 💻 Virtual machine: no
2023-11-06 13:08:42 📦 Highest known block at #0
2023-11-06 13:08:42 〽 Prometheus exporter started at <IP_ADDRESS>:9615
2023-11-06 13:08:42 Running JSON-RPC HTTP server: addr=<IP_ADDRESS>:9933, allowed origins=["*"]
2023-11-06 13:08:42 Running JSON-RPC WS server: addr=<IP_ADDRESS>:9944, allowed origins=["*"]
2023-11-06 13:08:42 discovered: 12D3KooWMq6SvUY8tU26MYjyjLwbJL3p5oSnNCuFV8cDT2C9tr4R /ip4/<IP_ADDRESS>/tcp/30333
2023-11-06 13:08:44 🔍 Discovered new external address for our node: /ip4/<IP_ADDRESS>/tcp/30333/ws/p2p/12D3KooWFyQsusopQ3iaRkNE53KHzsYHJPiAPYL9NiDYDt3XMQKK
2023-11-06 13:08:47 ⚙  Syncing, target=#10769292 (2 peers), best: #4941 (0x753b…3628), finalized #4608 (0x30df…08e6), ⬇ 526.0kiB/s ⬆ 21.0kiB/s
2023-11-06 13:08:52 ⚙  Syncing 1221.6 bps, target=#10769293 (2 peers), best: #11049 (0x12b1…5bbe), finalized #10752 (0x1653…006f), ⬇ 452.6kiB/s ⬆ 6.3kiB/s
2023-11-06 13:08:55 🔍 Discovered new external address for our node: /ip6/2a10:b600:0:a:3eec:efff:fe95:b39c/tcp/30333/ws/p2p/12D3KooWFyQsusopQ3iaRkNE53KHzsYHJPiAPYL9NiDYDt3XMQKK
2023-11-06 13:08:56 🔍 Discovered new external address for our node: /ip6/2a10:b600:1:0:3eec:efff:fe95:b39d/tcp/30333/ws/p2p/12D3KooWFyQsusopQ3iaRkNE53KHzsYHJPiAPYL9NiDYDt3XMQKK
2023-11-06 13:08:57 ⚙  Syncing 1286.8 bps, target=#10769294 (10 peers), best: #17483 (0x359e…be10), finalized #17408 (0x208f…379c), ⬇ 402.1kiB/s ⬆ 30.5kiB/s
2023-11-06 13:09:02 ⚙  Syncing 1325.8 bps, target=#10769295 (10 peers), best: #24112 (0x325b…7a9a), finalized #24064 (0xd34b…44b4), ⬇ 425.5kiB/s ⬆ 5.7kiB/s
2023-11-06 13:09:07 ⚙  Syncing 1183.4 bps, target=#10769296 (10 peers), best: #30029 (0x1d04…a810), finalized #29696 (0xd9a6…6690), ⬇ 355.8kiB/s ⬆ 10.3kiB/s
2023-11-06 13:09:12 ⚙  Syncing 1419.0 bps, target=#10769297 (10 peers), best: #37124 (0x2c62…a5ce), finalized #36864 (0x3faa…dc67), ⬇ 414.9kiB/s ⬆ 7.1kiB/s

As far as I can see, the testnet bootnodes are also still not synced. Could you elaborate @PeterNashaat ?

So the issue seems to remain. This test node also stopped at block #4,263,037

Node was started with:
docker run -d --restart unless-stopped -v /storage/:/storage/ --name tfchain-test-pub-synctst --network host threefolddev/tfchain:2.2.0-rc8 --name tfchain-test-pub-synctst --base-path /storage --chain /etc/chainspecs/test/chainSpecRaw.json --bootnodes /ip4/<IP_ADDRESS>/tcp/30333/p2p/12D3KooWHe8Wbn6dDbyxXietaXSRTZJfykPRgrkJDjXh9xZ4383k --rpc-cors all --node-key 9fbcca009905ac444ce757987069e39db467cb040653c2f7ffb7631f4ece3406 --ws-external --rpc-methods=safe --ws-max-connections=148576 --pruning archive --telemetry-url 'wss://shard1.telemetry.tfchain.grid.tf/submit 1'

You are currently using an outdated image with an old binary release threefolddev/tfchain:2.2.0-rc8 .
I have pushed a new image, threefolddev/tfchain:2.6.0-rc1.
You should use this new image to avoid any syncing issues.
Additionally, I have opened an issue to maintain and update the docker image with every release.

yes, full sync from 0 works with tfchain:2.6.0-rc1. Got 3 nodes fully synced.


Good checkpoint.pth ?

Hi
Thanks for your great work.
Are you sure you provided the correct checkpoint.pth file ?
I have the same level of hallucination that with MiniGPT4.
In fact the model hasn't been able to detect any false statement regarding objects that do not exist.

Thanks for your comments! let's me double check. BTW, which dataset you are using?


Tweak to use async/await

https://codereview.chromium.org/1091613002

For anyone following along: I should have removed the void return type annotation.


Testing

Github Actions
Cyprus
Mocks
Jest

I remember you saying that Katie recommended looking into Capybara

i like that i still get emails for this repo
miss you guys 💗


Upgrade GPS feeder to new API

Use new kuksa-client python lib in GPS feeder.
The resulting feeder shall still work with  kuksa.val server and in addition also support databroker

Done in #34


Rename form objects to have suffix "Input"

What problem does this pull request solve?
The suffix "Form" for form objects which represent the input fields on a HTML form was difficult to work with, as we have a "Form" entity represing a GOV.UK Forms form, which is used throughout the application.
Use the suffix "Input" for form objects, to hopefully avoid this point of confusion.
Things to consider when reviewing

Ensure that you consider the wider context.
Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

I've just realised that this change will affect the end to end tests, because they rely on the name of some of the inputs when requesting a confirmation email:
https://github.com/alphagov/forms-e2e-tests/blob/01233e44de56d85a87ee0b5f9323b41a3edb9179/spec/support/feature_helpers.rb#L272
We shouldn't really be relying on the name of this input, it should be possible to use the label instead, but we will need to change the end to end tests before merging this PR.

I've just realised that this change will affect the end to end tests, because they rely on the name of some of the inputs when requesting a confirmation email:
https://github.com/alphagov/forms-e2e-tests/blob/01233e44de56d85a87ee0b5f9323b41a3edb9179/spec/support/feature_helpers.rb#L272
We shouldn't really be relying on the name of this input, it should be possible to use the label instead, but we will need to change the end to end tests before merging this PR.

Good spot! Thanks, I'll update this


Failed validation: #/definitions/QuoteResponseArray

Validation Error
Minimal Reproduction

await yahooFinance.quote('BRK.A)
Symbol(s) that it happened for

BRK.A

Error Message

  result: [
    {
      language: 'en-US',
      region: 'US',
      quoteType: 'EQUITY',
      typeDisp: 'Equity',
      triggerable: false,
      customPriceAlertConfidence: 'LOW',
      esgPopulated: false,
      earningsTimestamp: 2018-05-05T16:30:00.000Z,
      earningsTimestampStart: 2018-08-02T16:30:00.000Z,
      earningsTimestampEnd: 2018-08-06T16:30:00.000Z,
      tradeable: false,
      priceHint: 2,
      symbol: 'BRK.A'
    }
  ],
  errors: [
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'exchange'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'exchangeDataDelayedBy'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'exchangeTimezoneName'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'exchangeTimezoneShortName'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'fullExchangeName'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'gmtOffSetMilliseconds'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'market'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'marketState'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/definitions/QuoteEquity/required',
      keyword: 'required',
      params: [Object],
      message: "must have required property 'sourceInterval'",
      data: [Object]
    },
    {
      instancePath: '/0',
      schemaPath: '#/anyOf',
      keyword: 'anyOf',
      params: {},
      message: 'must match a schema in anyOf',
      data: '[shortened by validateAndCoerceTypes]'
    }
  ]

Environment
Browser or Node:  Node
Node version (if applicable): v17.5.0
Npm version: v8.4.1
Browser verion (if applicable):
Library version (e.g. 1.10.1): v2.3.3
Additional Context

Thanks @apteryxxyz for another report.  You're bringing lots of... interesting... cases :)
What exactly is BRK.A, can you give me any more info about it?
I don't know if maybe this is meant to be BRK-A (Berkshire Hathaway Class-A)?
From what I can tell it seems to be a mistake on the Yahoo Finance data entry...  BRK.A shows some Berkshire Hathaway but is otherwise missing all the other data it should have, and that's why our validation is catching this case.

What exactly is BRK.A, can you give me any more info about it?

Like I mentioned in my previous issue comment, this was just me testing and trying to break my project.
Google lists it as BRK.A on there market summary snippet.

Thanks for the quick reply.
Ok so, in this case, the validation is actually doing its job to protect you from working with bad data.  I guess I need to add a third note in the validation error help text about this kind of case.  Thanks!

:tada: This issue has been resolved in version 2.3.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error on Manager.CreateObject()

Hello,
I was trying to create an issue using the example provided in the wiki.
When applying "manager.CreateObject(obj)" the following error message appears on the catch block:

"Not Found".

Can you tell me why and in what situations this may occur?
Notes:

I've filled all the properties defined on the example (Author, Stauts, ..)
I can connect and receive issues

Thanks!

I've found out the reason!
I was placing a bad project id so the API probably couldn't find the target resulting in the error.
Thanks.


Z coordinate in streaming api

Hi guys,
would it be possible to include the Z coordinate and the corresponding GetTop and GetBottom functions? The data are already transmitted by the standard API but are not yet included in the existing functions. In LightLocations they are already stored.

I updated #213 with some changes.
I don't think I'm able to change the Angle function. It now explicitly calculates the angle between 2 X, Y points in a 2D space. If I change this to XYZ it will have different results.

I see. looks good. :)

This is in release 3.15.0 on NuGet


Storage: Disabled failing ChecksForCancelation live test

We've seen ChecksForCancelation failing during the live test runs.  Marking it Explicit until it can be made more reliable.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=283306&view=results

Hi @tg-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


refactored map.ts

!closes #427

This hasn't seen activity in several months; closing. Feel free to let me know if you pick this up again!


Audio Glitches out

I can play audio yes but a few seconds in it cuts out and just makes a whining sound, have tested multiple audio files all result in the same thing

nvm i fixed it


No response except "//testing challenge..."

Challenge Arguments Optional has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
When I  ran my code, I got only "// testing challenge...".
My code:
function add() {
  var args = (arguments.length === 1 ? [arguments[0]] : Array.apply(null, arguments))
      .reduce(function (prev, curr) {
	    return ( typeof prev !== 'number' ||
		         typeof curr !== 'number' ? undefined : prev + curr );
      }, 0);

  if (arguments.length === 1) {
    return function (x) {
      return ( ( typeof args !== 'number' || typeof x !== 'number' ) ? undefined : args + x );
    };
  }
  return args;
}

/*add(2, 3);
add(2)(3); */
add("http://bit.ly/IqT6zt");
/*add(2, "3");
add(2)([3]);*/

@SteveHiChae
The challenge has been recently updated to use a function name addTogether instead off add
I have tested this with the below snippet (taking your logic):
function addTogether() {
  var args = (arguments.length === 1 ? [arguments[0]] : Array.apply(null, arguments))
      .reduce(function (prev, curr) {
        return ( typeof prev !== 'number' ||
                 typeof curr !== 'number' ? undefined : prev + curr );
      }, 0);

  if (arguments.length === 1) {
    return function (x) {
      return ( ( typeof args !== 'number' || typeof x !== 'number' ) ? undefined : args + x );
    };
  }
  return args;
}

addTogether(2,3);

This lets me pass the test cases properly except for the bit.ly test case. Well that could be a logical error with the provided logic, not sure, but I'll let you figure that out.
Please confirm and close if this is expected. I believe the original issue that you report is resolved.
Thanks and happy coding!

@raisedadead
If you put addTogether("http://bit.ly/IqT6zt"); on the bottom of the code, it'll give you an error in the console:

This may have something to do with the fact that addTogether("http://bit.ly/IqT6zt"); returns a function instead of undefined.

@alistermada Thanks for checking this, the "test freeze" is directly related to the solution/logic implemented by the camper. IMHO, its not related to the challenge itself having a issue, correct?
And I can confirm with your analysis that the addTogether is indeed returning a function as opposed to undefined in case of a string as argument.
Refer :
console.log(typeof addTogether(2, 3)); <-- Output: number
console.log(typeof addTogether("Hello World")); <-- Output: function
@SteveHiChae Closing this with the above comments, please feel free to continue the discussion if you still need any assistance with this.


Binary Ninja 3.3 has broken antialiasing with Windows 10 (no HiDPI)

Version and Platform (required):

Binary Ninja Version: 3.3.3996 Personal (Build ID e34a955e)
OS: Windows 10
OS Version: 21H2
CPU Architecture x64

Bug Description:
The font antialiasing has been failing for me since at least 3.2. While I could work around it in that version (see below), 3.3 has broken it completely. having blurry widgets even with the default Inter typeface.
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

Go to Settings, type font in the search bar.
Set font.app > "Application font name" to "Segoe UI"
Restart Binary Ninja.
Repeat 1, then set font> "Font Antialiasing Style" to any desired option.

Expected Behavior:
Crisp font rendering.
Screenshots:
With 3.3:

Inter/Roboto
Segoe UI/Consolas

subpixel

grayscale

none

With 3.2:

Inter/Roboto
Segoe UI/Consolas

subpixel

grayscale

none

Additional Information:
In 3.2, it was possible to work around this by setting "Segoe UI" and "Consolas" as the application and view font name respectively, plus setting the antialiasing to Subpixel.
In 3.3, this has broken completely and the UI look just wrong irrespective of font and antialiasing option, as shown in the screenshots above.

Could you give us some more information about your specific setup? I've tried replicating this on both Windows 10 and Windows 11 VMs, plus a bare-metal Windows 11 install, and I don't think I'm seeing the same font issues that you are.
I tossed Segoe UI in as my font choice and then took two screenshots from inside of my Windows 10 VM:

This is with subpixel antialiasing on.
Now, I'm usually pretty nitpicky about fonts and rendering and stuff, but these seem reasonable to me? They also seem slightly clearer than your own screenshots? But, I dunno, maybe I'm missing something.

For completeness, here's how my bare-metal Windows 11 install looks with 3.2:

...and 3.3:

...both with Segoe UI and subpixel antialiasing enabled.

For completeness, here's how my bare-metal Windows 11 install looks with 3.2:

That one already confirms my issue, your 11 VM has no antialiasing:

whereas 3.2 shows the smoothed edges of subpixel Cleartype:

Your 10 VM on the other hand looks OK:

My setup is as follows:

OS: Windows 10 21H2
CPU: Ryzen 7 2700x
GPU: Nvidia Geforce GTX 1660 Ti, driver version 527.56
Screens: 1080p, 1x Samsung S24F350, 1x LG M2380A, no HiDPI. Both calibrated with ArgyllCMS and with the ICC profile active

I'll check GPU driver settings and ICC profile now and let you know.

Thanks, I now understand better what you're talking about. And, actually, I think you might've already helped me understand the problem better. The screenshots I had from Windows 11 are actually not from a virtual machine, which suggests the reason why we didn't catch this before release is that there is a difference between the rendering inside the VM versus bare-metal.
I also have an Nvidia Geforce GTX card in the bare-metal machine I got the Windows 11 screenshots from. I'm wondering if there's an interaction with Qt and device drivers that is causing the issue, since we haven't changed any font rendering code on our end.

a difference between the rendering inside the VM versus bare-metal

I've not digged into Binja's innards, but are you shipping Qt6? Perhaps it's high DPI antialiasing rearing its head, I believe it's enabled by default there.

We are, actually. A quick 1-minute Google search didn't bring up anything in the way of a recent Qt bug regarding high DPI antialiasing. Are you aware of something I could try to resolve the issue?
We do have the following ifdef that shouldn't be compiling into the product now:
#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
	QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
	QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);
#endif

...presumably because it is on by default now. I'm not personally very knowledgeable about antialiasing in Qt on Windows, though.
If you're aware of some stuff I could try, please let me know, otherwise I'll try and mess with some settings when I get a chance and see what happens.

Does this look better?

Does this look better?
I think it does, but I'm obviously not as sensitive, so I want to make sure before I try and figure out how to get this out in a dev build.

I think so, yes! I need to test with the system fonts, but the borders look as they should. Let me know if/when I can check it out.

This is now live in builds >= 4060 on the dev branch and will be included in the next stable release.
For posterity, there is some problem with Qt 6's default High DPI rendering on Windows. The solution was to put this:
qputenv("QT_ENABLE_HIGHDPI_SCALING", "0");

...before the main QApplication gets instantiated.
Big thanks to Stuart Mentzer's post here that clued me in to this as a possible solution (and pointed out that the solution I tried first probably wasn't going to work). Additional shout out to the Qt 6 documentation that does, in fact, explain how this works...but does so buried at the bottom of the page.

I am reverting the change I made. I'm reasonably certain it's behind a different bug where the Windows UI appears to be super small relative to the text on the screen. If I'm correct, I'll need to find a different way to make this happen.

I think I have an idea for you @fuzyll, can you check which backend you're using for rendering binja's UI? In particular, are you using FreeType?

Also see https://bugreports.qt.io/browse/QTBUG-100774 and related (coming from https://github.com/telegramdesktop/tdesktop/issues/25936 where I'm experiencing a related kind of blurry once FreeType is enabled).

Thanks! Ironically, I had just found that same issue (and the one it links to, 111380 last night, along with this one, which all seem related. This is unfortunately not my top priority right now, but I'm still slowly getting to understand the High DPI code and trying to pick through where the problem is. Unfortunately, since they've removed the other settings and replaced them with a single environment variable switch, figuring this out is slightly painful.
Appreciate you helping to point me in the right direction, though! Hopefully I'll have time to sit down and figure it out for good soon. 🙂

I'm slipping this to next release. I suspect there are multiple confounding factors here, only one of which is the antialiasing being off.
We upgraded to Qt 6.4.3 for the next release, which has had some improvements, but linear view in particular still looks pretty bad:

There are, however, places in the product that don't look quite so bad. So, I might need to do a more thorough audit of how we're rendering text to see if maybe we're causing additional issues. Since some of the Qt issues mentioned earlier are still open as well, it's also possible that a future update to the Qt 6.5 series (or newer) might also help resolve some of these problems.
I apologize for this process taking so long, and I do want to get it fixed. It's just been difficult because of so many confounding factors.

@fuzyll I've been digging into old bug reports, and I found this: https://bugs.chromium.org/p/chromium/issues/detail?id=405445
Together with https://stackoverflow.com/a/75839785, I'm wondering if Qt6 needs to have a whitelist of DW-unhappy fonts, or alternatively some custom hinting parameters?

Hey thanks!
So, I'm not 100% sure if the top one is relevant or not... The link seems to suggest that if we were having an issue where DirectWrite was unable to display the font correctly, we should be getting some sort of 'halo' effect because of how the colors bits are swapped around? But, regardless, DirectWrite is something I need to look into because Qt6 now relies heavily (entirely?) on that for rendering on Windows.
The second link was interesting and had me looking all over the codebase for places where we mess with the font hinting settings. It turns out there were some inconsistencies, so hopefully I can make an improvement here regardless. But, I'm not completely sold that the setting it encourages turning on is the right move. Here's how it looks in a special build where we go all-in on platform font hinting:
With subpixel:

With hidpi:

With none:

None of these look 'blurry'; which is great! But, here's how Firefox is rendering your comment on the same box:

...and I just can't shake the feeling that we're still getting something very wrong on Windows on HiDPI screens. I haven't tried this in a VM, but based on earlier screenshots in this ticket, I think this should look even better in a VM. It's bare-metal font rendering that's the problem.
Anyway, thanks for the links! I'm still looking into this in-between other things, and I appreciate any other information you're able to give me. Hopefully we'll figure this out and get it fixed soon!

YESSS! 🎉 That looks awesome @fuzyll !
Let me know once it lands in the development channel and I'll be more than happy to test it.

Okay, these changes are now live on builds >= 3.5.4425-dev.
There is still an issue with the default interface font (Inter), but only in certain situations, and I'm starting to think that maybe there's an issue with that font interacting with the PreferFullHinting setting. If hinting is turned off, it looks great (which is how I was able to fix the way the font looks in the interface in general), but if it's turned on (which happens for any widgets that get dynamically created) it looks really strange.
The problem with the hinting setting is that it is global - once you set it, it's that way for everything rendered from then on.  Unfortunately, this means stuff like the Plugin Manager can look a bit off for much of the rendered text.
I'll keep digging into the issue, but for now this should be fixed enough that Binary Ninja is pleasant to work in on Windows now.

@fuzyll Looks great now! One nit: Segoe UI at sizes between 8 and 11 points look very blurry still, I think DirectWrite or something along the pipeline is doing upscaling of a lower integral size. That's the only thing outstanding now.

Just to confirm: When you say it looks "very blurry", where are you looking? I'm actually not seeing any issues with Segoe UI at 10 point on 3.5.4426-dev, which maybe suggests that the problem I'm still trying to track down is actually the fault of our Inter font file and not something in Qt.
I'm currently at 150% scale:

...and this is how Segoe UI looks on the New Tab page:

It also looks fine in the Plugin Manager:

...which does not look fine in our Inter font right now (because hinting appears to be off, despite it actually being turned on):

This is with Segoe UI at the default size (10 point):

I also took a pic with my camera showing the blurry font vs Consolas:

Okay, I've made some more changes and I believe this may actually be taken care of now? Hopefully? Maybe?
If you could check out version 3.5.4481-dev (which should be making its way to update servers as I write this), that would be appreciated.
The TL;DR is that I realized most of what we were doing was working around a prior Qt 5 bug and an actual issue with the custom-built version of Inter that we were shipping with Binary Ninja. As a result, I've ripped out nearly all of the custom code we had surrounding Windows font handling and put us back to Qt defaults. I've also shipped a new version of the font that was built with hints for DirectWrite.
The combination of all these changes should have all font issues resolved on Windows, regardless of DPI. I've also changed the handling of one of the font antialiasing options to prefer antialiasing (where previously it was left to the Qt default of "no preference"). This can still be turned down/off in our settings, so if things still seem a bit blurry by default, give the other options a shot again and see if that resolves things.
But, from my testing across all 3 platforms and in VMs vs. not in VMs, this should result in either no change (macOS), a slight improvement (Linux, Windows on low DPI/in VMs), or a huge improvement (Windows at high DPI) in font rendering across the product.
Absolutely let me know if this isn't the case because there are a fair number of changes and my testing, while fairly extensive, wasn't exhaustive, so there's always a chance I missed something. Hoping I can finally close this issue! 🤞

Hey! 🎉  yes, it works!
Nit: did you hardcode TTF Inter as the UI font? It correctly recognises the Segoe UI sizes now, but the main view uses Inter nomatter what I set.

I did not, but I did implement a fallback to our font if there isn't a match on the filesystem for the font specified in the user settings to fix #4566. So, it sounds like I did indeed have an edge-case that I didn't account for and I'll need to implement that differently. 😞
I'll close this one and re-open that one while I look for a better solution. So close! 😛 Thanks again for testing this out for me.


Update inner-slider.js

updated hardcoded dir value based on rtl props

We have a lot of RTL issues that need to be fixed. We will handle this along with those fixes


RecyclerViewBackedScrollView - unable to resolve module

Version
Tell us which versions you are using:

react-native-router-flux: 3.38.1
react-native: 0.43.4

Expected behaviour
Expected to load the scene like previous version (RN 0.42.3)
Actual behaviour
Simulator complains about being unable to find the RecyclerViewBackedScrollView within React-Native.
Steps to reproduce

Use React-Native 0.43 cli to initialize a project
look at the package.json
"react": "16.0.0-alpha.6",
"react-native": "0.43.4",
"react-native-router-flux": "^3.38.1",
Initialize a router with one scene
load up the simulator

npm install -g react-native-git-upgrade
react-native-git-upgrade
Does that solve it?

Also, if you're using master you should delete react-native-router-flux's node_modules/

Looks like deleting react-native-router-flux's node_modules/ fixed, but I did run it after installing and running react-native-git-upgrade.
Is this something that has to be done after every clean install?

After every npm install. Unless you stop using the master branch
Enviado do meu iPhone
Em 30 de abr de 2017, às 19:44, Pedro Mass <notifications<EMAIL_ADDRESS>escreveu:
Looks like deleting react-native-router-flux's node_modules/ fixed, but I did run it after installing and running react-native-git-upgrade.
Is this something that has to be done after every clean install?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/aksonov/react-native-router-flux/issues/1828#issuecomment-298262320, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABbjhbLgq6pjZFj9MTzKYNtzuaBKG9Iyks5r1Q7XgaJpZM4NMnXw.

the master branch for react-native-router-flux?

Yes. Are you using it?

Or just rollback to v 3.38.0
npm install --save<EMAIL_ADDRESS>

tried rollback to 3.38.0 and also tried to upgrade from 0.43.4 to 0.44.
Still throws me an error on RecyclerViewBackedScrollView
renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />}

Same issue
"react": "15.5.4",
"react-native": "0.44.0",
"react-native-router-flux": "^3.38.1",

same issue on v4
"react-native-router-flux": "^4.0.0-beta.32",

@aksonov any help?

@akinolu52  How to you solve it at end?

Yeah; That is what I used @colorfulberry

To solve this problem I had to explicitly state the version
"react-native-router-flux": "3.38.0",
If you do:
"react-native-router-flux": "^3.38.0",
Then the later version with the 127 phantomChildren libraries will be used instead and break building. Corporate sabotage?

To avoid duplicating my comment: https://github.com/aksonov/react-native-router-flux/issues/960#issuecomment-424953838. 😝


Implement deselectRow/selection clearing

Let me first thank you for this excellent Anvil component! I'm finding it extremely useful.
I have a small request: could you implement a way to clear the row selection?
I tried self.tabulator._table.deselectRow(...) but it did not work.
Oh it seems that tabulator.select_row() does not work... I tried to pass the row item or the row id, but neither worked.
TIA
Marcel

i've had a look and have checked select_row works fine for me on the example app.
self.tabulator.select_row(0) # single id
self.tabulator.select_row([0,1,2,3]) # list of ids
self.tabulator.select_row('visible')

I've added the deselect_row function in commit 3887ec079ac3c739840e614fb62a956340dcc8fb which should do the expected and also works on the example app.
self.tabulator.select_row(0) # single id
self.tabulator.deselect_row([0,1,2,3]) # list of ids
self.tabulator.deselect_row() # all currently selected rows

let me know if you still have problems.

i've had a look and have checked select_row works fine for me on the example app.
self.tabulator.select_row(0) # single id
self.tabulator.select_row([0,1,2,3]) # list of ids
self.tabulator.select_row('visible')

I've added the deselect_row function in commit 3887ec079ac3c739840e614fb62a956340dcc8fb which should do the expected and also works on the example app.
self.tabulator.select_row(0) # single id
self.tabulator.deselect_row([0,1,2,3]) # list of ids
self.tabulator.deselect_row() # all currently selected rows

let me know if you still have problems.

Ah, thanks to your pointer, I found the problem: I had not set the index to the field being used. And now I also have the confirmation that the key and not some row index should be used.
It would be useful to have a cheatsheet with Tabulator's usage on the GH page. It is cumbersome to consult the demo app just to check the usage, with Anvil IDE being able to open one page at the time.
Now I have to find out how to merge these changes on GH into my current Tabulator component (silly Anvil dependencies).

Ah, thanks to your pointer, I found the problem: I had not set the index to the field being used. And now I also have the confirmation that the key and not some row index should be used.
It would be useful to have a cheatsheet with Tabulator's usage on the GH page. It is cumbersome to consult the demo app just to check the usage, with Anvil IDE being able to open one page at the time.
Now I have to find out how to merge these changes on GH into my current Tabulator component (silly Anvil dependencies).

yes - documenting this is something I never got round to but definitely should.
As a minimum i should add better docstrings since anvil now supports autocomplete for depenencies
Very open to pull requests 😉

yes - documenting this is something I never got round to but definitely should.
As a minimum i should add better docstrings since anvil now supports autocomplete for depenencies
Very open to pull requests 😉


docs(readme): Replace changelog with valid url

Purpose
Update the changelog URL since the old changelog file was removed.
Changes
Just a one line change in README.md - update the link.
Additional information
This is my first PR so please let me know if I've dome something wrong :) Cheers!

[*] I updated readme

thanks


Update auth, dynamodb, s3, sqs to 2.17.147

Updates

software.amazon.awssdk:auth
software.amazon.awssdk:dynamodb
software.amazon.awssdk:s3
software.amazon.awssdk:sqs

from 2.17.66 to 2.17.147.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #859.


Add Taylor

Merging @owtaylor  commits to the OCI manifest PR.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "add-taylor" git@github.com:mikebrow/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354433648
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

I repushed my brach with sign-offs - sorry for not having them earlier.

@owtaylor yeah I tried to do a pull merge / rebase of your changes but got some test errors and the sign-off issues.  Could you just rebase and push your PR to this repo as a dependent PR? Then we can merge both when the tests pass.

Not quite sure what you mean by dependent PR. I created a pull request https://github.com/mikebrow/distribution/pull/1 against your ocitype branch - I think if that is merged to your ocitype branch, #2076 will be updated to include my commits.

Your branch is already dependent.. just needs to be pushed. Ah I see you did! Thanks!


[CLOSED] remove duplication in manual_document_builder.rb

 Issue by b-murphy
Monday 02 June 2014 at 18:29 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/98

b-murphy included the following code: https://github.com/alphagov/specialist-publisher/pull/98/commits

 Comment by bestie
Wednesday 04 June 2014 at 12:26 GMT

Thanks @thealmightyis but that class doesn't exist right now so I'm closing.

 Comment by b-murphy
Wednesday 04 June 2014 at 12:31 GMT

Sure thing :package:

 Comment by bestie
Wednesday 04 June 2014 at 12:27 GMT

We have a few issues I could point you in the direction of of you're interested in contributing.


HTTP01 solver fails self-check/propagation check on 1.7.1 when used with client-certificate auth on nginx Ingress 1.1.1

Description
It seems as though HTTP01 challenges aren't working with ingress hosts that use client-certificate authentication. The self-check/propagation fails, leading to a cert not being issued.

Expected Behaviour
The certificate should get issued.
Environment

Kubernetes version: 1.22.4
Cloud-provider/provisioner: AKS
cert-manager version: 1.7.1
Install method: Static manifests

/kind bug

Looks like this might be a red herring...
I stumbled across this error separately:
ingress-nginx ingress-nginx-controller-54d8b558d4-xtmt9 controller E0221 04:09:59.705682       7 annotations.go:206] "error reading Ingress annotation" err="Location denied, reason: invalid format (namespace/name) found in 'my-client-ca-cert'" name="CertificateAuth" ingress="my-app/trusted-ingress"

Not sure why that would result in a 403 but perhaps it's a built-in mechanism of how nginx handles bad annotations.

I don't think this is a red herring. I stumbled upon this issue as well today with a configuration similar to yours and my mtls certificate is being correctly read by nginx. Did you manage to solve the issue?
I understand why the issue is here. Of course cert-manager can't connect to the mtls-secured endpoint without using an mtls certificate itself, which is why cert-manager will not try to get certificates for this endpoint. However as far as I can see there is no way to tell cert-manager to use a specific certificate to authenticate itself against mtls-secured endpoints, which is the missing feature here to solve this problem.

/remove-lifecycle stale

/remove-lifecycle rotten


Found 2 bugs in the library

When calling a function: getUserProfile()
Comes out:
{
data: { userData: { user: [Object] } },
extensions: { is_final: true }
}
Also the getUserFollowers and getUserFollowings function gives only 100 elements... why?

The first one is not a bug it just the console.log here
https://github.com/junhoyeo/threads-api/blob/74ded4b1bce9f59b1c3b547e353ecc2025a5a0a2/threads-api/src/threads-api.ts#L664-L666
the data is in the variable you are using with the method
const userProfile = await threadsAPI.getUserProfile()
// all the data is in userProfile

The second one getUserFollowers and getUserFollowings have pagination so its up to you
const { users, next_max_id: cursor } = await threadsAPI.getUserFollowers(userID);
console.log(JSON.stringify(users));

The first one is not a bug it just the console.log here
https://github.com/junhoyeo/threads-api/blob/74ded4b1bce9f59b1c3b547e353ecc2025a5a0a2/threads-api/src/threads-api.ts#L664-L666
the data is in the variable you are using with the method
const userProfile = await threadsAPI.getUserProfile()
// all the data is in userProfile

The second one getUserFollowers and getUserFollowings have pagination so its up to you
const { users, next_max_id: cursor } = await threadsAPI.getUserFollowers(userID);
console.log(JSON.stringify(users));

@Aerglous any idea why it doesn't return next_max_id?
https://github.com/junhoyeo/threads-api/issues/231

Thank you! You helped me a lot.


test: Made the memdisk test up to date, solving #657

Made nosector service default on make
Facelift to services using CHECKSERT macro
Extracted bigdisk creation to separate script
Added test.py, chaining 3 test in one run using the same Makefile
Added README and vm.json

Added memdisk to jenkins, retest please 🙏


proposal: TestMain should not require os.Exit

TestMain is expected to call os.Exit itself. This leads to subtle issues with defer and panic that leads to much headscratching.
Let's say you start here:
func TestMain(m *testing.M) {
  setup()
  defer teardown()
  os.Exit(m.Run())
}

Subtle bug #1: your teardown isn't running; you're making a mess of your test environment. Try this:
func TestMain(m *testing.M) {
  var exitCode int
  defer os.Exit(exitCode)

  setup()
  defer teardown()
  exitCode = m.Run()
}

Oops, setup has a panic call. Now when you run go test, it's silent..
go test .
ok  	_/Users/abuchanan/scratch/testmain_bug	0.010s

Uh, headscratch.  Oh, os.Exit is hiding my panic call. Ok, finally:
func TestMain(m *testing.M) {
  // testMain wrapper is needed to support defers and panics.
  // os.Exit will ignore those and exit silently.
  os.Exit(testMain(m))
}

func testMain(m *testing.M) int {
  setup()
  defer teardown()
  return m.Run()
}

Let's save people some headscratching (and time and effort and silly wrapper code). The testing framework probably has enough information to call os.Exit appropriately for you after TestMain returns, right? Why require users to call it?
TestMain is really useful for writing end-to-end tests, where a single setup/teardown for all the tests is important. If I break those tests into packages for organization, it would be nice not to copy that TestMain wrapper code everywhere.

Related: #9917.
One possibility, that I thought was discussed before but I can't find an issue, is to change the behavior depending on the result of TestMain.  If TestMain does not return a value, assume it calls os.Exit.  If TestMain returns an int, then pass that int to os.Exit.

https://github.com/golang/go/issues/23404

Ah, thanks.

@robpike and @mpvl, any thoughts?

No real insight from me. The topic seems covered by @ianlancetaylor's and @rsc's  points.

It seems like if we do the "automatic os.Exit" that will fix quite a few buggy tests, and it basically eliminates the need for a TestMain that returns int. We could always revisit that and add it later, if needed, but let's start with the automatic os.Exit.
To be clear, the proposal is this. Right now, the overall test func main calls TestMain(m), and the TestMain function is expected to do two things:

Call m.Run() and record the result.
Call os.Exit with the result of m.Run.

The proposal is that:

m.Run records its own result in an unexported field of m, and then
if TestMain(m) returns, the outer test func main harness calls os.Exit with that code.

This would mean that implementations of TestMain that forget to call os.Exit will have it called for them. And implementations that want to explicitly avoid os.Exit in order to make defer useful can do that.
If TestMain does not call m.Run (presumably for a good reason) and returns, then the outer func main should os.Exit(0) as it does today.
Does anyone object to this plan or think it would not address the necessary use cases?

This seems like a likely accept.
Leaving open a week for final comments.

No new comments in the past week, so marking as accepted.


Fileserver tests

change the returned error from serveFile in case f.Stat fails

Oh my. This are excellent. Thanks for your work, Bisser! :100:


Naming, immutable array manipulation

:+1:

:+1: thanks!

Ooops. I copy/paste fail.

Do you want to PR and fix it or want me to?

I'd say just go ahead and push the fix :)

Done :+1:


Review span in face of p1024 and p1089 (Continued from #14)

References:

Continued from #14
p1024 - voted in, 2019-02 Kona ISO C++ Committee Trip Report
p1089 - see #27

Plan:

[ ] Use feature test macros: defined(__cpp_deduction_guides) etc.
[ ] Differentiate storage for dynamic, static extent.
[ ] Structured bindings support for fixed-size spans (only non-dynamically-sized spans) (p1024)
[ ] Allow also for Extent to be unsigned with dynamic_extent numeric_limits<index_type>::max() (p1089)?

some small change was apparently missed:
rename as_writeable_bytes -> as_writable_bytes


fix(nextjs): Allow overriding hostname with HOSTNAME env variable

Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[x] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[] npm test runs as expected.
[] npm run build runs as expected.

Override the req.nextUrl host with the HOSTNAME environment variable.
With this fix we can resolve the incorrect hostname in the NextJS applications deployed outside Vercel platform.

!snapshot

Hey @dimkl - the snapshot version command generated the following package versions:

Package
Version

@clerk/backend
0.23.5-snapshot.4e42478

@clerk/chrome-extension
0.3.15-snapshot.4e42478

@clerk/clerk-js
4.50.0-snapshot.4e42478

eslint-config-custom
0.3.0

@clerk/clerk-expo
0.18.6-snapshot.4e42478

@clerk/fastify
0.5.4-snapshot.4e42478

gatsby-plugin-clerk
4.3.16-snapshot.4e42478

@clerk/localizations
1.21.0-snapshot.4e42478

@clerk/nextjs
4.21.8-snapshot.4e42478

@clerk/clerk-react
4.20.5-snapshot.4e42478

@clerk/remix
2.6.13-snapshot.4e42478

@clerk/clerk-sdk-node
4.10.12-snapshot.4e42478

@clerk/shared
0.19.1

@clerk/themes
1.7.5

@clerk/types
3.46.0-snapshot.4e42478

Tip: use the snippet copy button below to quickly install the required packages.
# @clerk/backend
npm i<EMAIL_ADDRESS>
# @clerk/chrome-extension
npm i<EMAIL_ADDRESS>
# @clerk/clerk-js
npm i<EMAIL_ADDRESS>
# eslint-config-custom
npm i<EMAIL_ADDRESS>
# @clerk/clerk-expo
npm i<EMAIL_ADDRESS>
# @clerk/fastify
npm i<EMAIL_ADDRESS>
# gatsby-plugin-clerk
npm i<EMAIL_ADDRESS>
# @clerk/localizations
npm i<EMAIL_ADDRESS>
# @clerk/nextjs
npm i<EMAIL_ADDRESS>
# @clerk/clerk-react
npm i<EMAIL_ADDRESS>
# @clerk/remix
npm i<EMAIL_ADDRESS>
# @clerk/clerk-sdk-node
npm i<EMAIL_ADDRESS>
# @clerk/shared
npm i<EMAIL_ADDRESS>
# @clerk/themes
npm i<EMAIL_ADDRESS>
# @clerk/types
npm i<EMAIL_ADDRESS>

!snapshot

Hey @nikosdouvlis - the snapshot version command generated the following package versions:

Package
Version

@clerk/backend
0.23.5

@clerk/chrome-extension
0.3.15

@clerk/clerk-js
4.50.0

eslint-config-custom
0.3.0

@clerk/clerk-expo
0.18.6

@clerk/fastify
0.5.4

gatsby-plugin-clerk
4.3.16

@clerk/localizations
1.21.0

@clerk/nextjs
4.21.9-snapshot.56dc3e3

@clerk/clerk-react
4.20.5

@clerk/remix
2.6.13

@clerk/clerk-sdk-node
4.10.12

@clerk/shared
0.19.1

@clerk/themes
1.7.5

@clerk/types
3.46.0

Tip: use the snippet copy button below to quickly install the required packages.
# @clerk/backend
npm i<EMAIL_ADDRESS>
# @clerk/chrome-extension
npm i<EMAIL_ADDRESS>
# @clerk/clerk-js
npm i<EMAIL_ADDRESS>
# eslint-config-custom
npm i<EMAIL_ADDRESS>
# @clerk/clerk-expo
npm i<EMAIL_ADDRESS>
# @clerk/fastify
npm i<EMAIL_ADDRESS>
# gatsby-plugin-clerk
npm i<EMAIL_ADDRESS>
# @clerk/localizations
npm i<EMAIL_ADDRESS>
# @clerk/nextjs
npm i<EMAIL_ADDRESS>
# @clerk/clerk-react
npm i<EMAIL_ADDRESS>
# @clerk/remix
npm i<EMAIL_ADDRESS>
# @clerk/clerk-sdk-node
npm i<EMAIL_ADDRESS>
# @clerk/shared
npm i<EMAIL_ADDRESS>
# @clerk/themes
npm i<EMAIL_ADDRESS>
# @clerk/types
npm i<EMAIL_ADDRESS>

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Add accessibility improvements to Preview Govspeak component

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
What
Accessibility improvements to Preview Govspeak component.
Add aria labels to the govspeak preview button.
Add aria-live to the govspeak preview.
Why
The preview button relies on visual context to associate it with the field. This alone is unsuitable for screen reader users.
Changing label was seen to be more informative than a selected or pressed state.

Trying this with NVDA/Firefox a couple of possible problems become evident:

when you click on "Preview" the relevant content is read out but focus remains on the button and there is no indication that the button has now changed to "Edit"
if you tab away from this button and then back again the label content is announced but this is still "Preview Body (required)" rather than the expected "Edit Body (required)"

/home/runner/work/whitehall/whitehall/app/assets/javascripts/components/govspeak-editor.js:41:55: Operator ':' must be spaced.

FYI linting errors


programmatic import failures in Runner

When input file definitions are provided in a module that was installed after rsopt the import will fail.
See example from @sdwebb:
$ python3 run_libE_lhc_scan.py --nworkers 2 --comm local
Traceback (most recent call last):
File "run_libE_lhc_scan.py", line 80, in
runner = Runner(os.path.join(SCHEMA_DIR, BASE_SCHEMA.format(1)), objective_function=None, processing=test_func)
File "/home/vagrant/.pyenv/versions/py3/lib/python3.7/site-packages/rsopt/codes/runner/Runner.py", line 84, in init
self._set_codes_from_schema()
File "/home/vagrant/.pyenv/versions/py3/lib/python3.7/site-packages/rsopt/codes/runner/Runner.py", line 94, in _set_codes_from_schema
cd['code'] = code_templatesname
File "/home/vagrant/.pyenv/versions/py3/lib/python3.7/site-packages/rsopt/codes/runner/Templates.py", line 148, in init
super(Opal, self).init(options)
File "/home/vagrant/.pyenv/versions/py3/lib/python3.7/site-packages/rsopt/codes/runner/Templates.py", line 23, in init
self.import_input()
File "/home/vagrant/.pyenv/versions/py3/lib/python3.7/site-packages/rsopt/codes/runner/Templates.py", line 27, in import_input
input_file_module = importlib.import_module(input_file)
File "/home/vagrant/.pyenv/versions/3.7.2/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 953, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 953, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 953, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 953, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 965, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'fastfelo'

This will be resolved when Runner is refactored for use by Optimizer executors unless someone besides me starts regularly having a problem with this.
Plan is to no longer dynamically import an installed module but set a module path and use https://github.com/radiasoft/pykern/blob/master/pykern/pkrunpy.py

pkrunpy is being used in regular rsopt execution for both serial and parallel Python function evaluation


Setting backend service url

Hi,
When using Creator tool and config.yaml to generate the templates, looks like the
serviceUrl: url
is ignored by Azure. I see it is correctly added to generated ARM template, but in created API there is always url from swagger:

If the swagger is attached as a file - Azure will pick up the url from host property of swagger.json file
If swagger file is attached as remote url - Azure will use that url as a backend service url.

Expectation:
Backend service url specified in config.yaml file or in ARM template is the one that will be used.

We also faced this same issue and used remote Swagger file to fix as interim solution till this fix

Will take a look.

@MichalKosowski Thanks for reporting ! You are right ! The backend service don't support deploy swagger file and create api (with version set) at the same time, and the swagger file which comes later will always overwrite the backend url.
Two ways to fix:

It can be fixed by creating a third api template to deploy and change the backend url, but it's not a good way
We are waiting the new backend service, which will solve this problem.

resolved


Did the Face landmark detection can tell us whether the face is swollen and unsymmetric？

MediaPipe Solution (you are using)
Face landmark detection
Programming language
android
Are you willing to contribute it
None
Describe the feature and the current behaviour/state
I'm testing this project. The examples run up successfully. I want to know is the results can tell whether the face is swollen and unsymmetric
Will this change the current API? How?
no
Who will benefit with this feature?
Medical practitioners
Please specify the use cases for this feature
Showcasing the patient's injury situation
Any Other info
No response

Hi @joveth1,
We believe this is out of scope section of MediaPipe face landmarker, which is primarily designed for entertainment and assistive technologies. It is not intended for making critical human life decisions or medical purposes.
For a more comprehensive understanding, please refer to our model card.
Thank you!!!


Override underscore template settings

Hi,
I have seen in other implementations being able to override the _.templateSettings (for different deliminters for example)
Anyway we can add this? I can open up PR based on some other libraries I have seen if you like.

Ping. This is also an issue for me

fixed in #4 thanks @ralekna


graphql: conditions for exceptions

Opening this issue to discuss when an error should be returned for graphql request. Geth only returns errors if the execution of the graphql request fails, but still returns 200 if the request was valid, but the information queried for doesn't exist. For example, this test case attempts to query for the balance of an invalid account address. Geth returns a 0 balance because geth assumes every address exists on ethereum, just with a 0 balance, so geth returns:
{
     "data": {
       "block": {
         "account": {
           "balance": "0x0"
         }
       }
     }
 }

with a 200 status code.
Geth and Besu shouldn't really return two different responses for such a query. Would it be possible to remove the account does not exist exception in Besu?
cc @atoulme

That sounds like a simple fix I can look after.


docs: expanded code snippet on the apps page

Fixes #1310
Expanded code snippet on the Apps Page to:
apiVersion: lifecycle.keptn.sh/v1alpha2
kind: KeptnApp
metadata:
  name: podtato-head
  namespace: podtato-kubectl
spec:
  version: "1.3"
  workloads:
  - name: podtato-head-left-arm
    version: 0.1.0
  - name: podtato-head-left-leg
    version: 1.2.3
  # The following are optional
  preDeploymentTasks:
  - pre-deployment-hello
  preDeploymentEvaluations:
  - my-pre-deploy-evaluation
  postDeploymentTasks:
  - post-deployment-hello
  postDeploymentEvaluations:
  - my-post-deploy-evaluation

Hey @agardnerIT, please let me know if there should be any changes.

closing since the docs page does not exist anymore


navigator: check distances between waypoints

Instead of just checking whether the first waypoint is too far away from home it makes sense to also check between waypoints.
This can prevent

flyaways due to user errors, or
catch the corner case where a takeoff waypoint is added to a mission
and therefore the first waypoint is not too far away, however, the
subsequent waypoints are still too far away.

Tested in SITL using DroneCore.

Sounds like a good addition. While we're on the subject, what do you think of the distance to first waypoint check?
The majority of our existing feasibility checks could happen even before you have GPS or a valid home. So if we handle the distance to first waypoint check at a different level we could be a lot more restrictive and prevent navigator from taking the mission at all if it's not feasible.
The current situation where navigator has the updated mission even if it's not feasible can be dangerous.

The current situation where navigator has the updated mission even if it's not feasible can be dangerous.

But it is still safe because it won't do the mission later even if you can upload it.
I think the advantage of the current flow is that you can load the mission before going to the field.

I want both the ability to plan the mission before going to the field (when possible), and the separation of navigator mission not even able to touch an infeasible mission.
By not safe I mean for a plane that needs a planned mission landing to not hit trees or a building.

I want both the ability to plan the mission before going to the field (when possible), and the separation of navigator mission not even able to touch an infeasible mission.

I see. So we need library calls for the mission checks that we can use in e.g. mavlink where the mission arrives but also later in navigator.

@julianoes this might make sense for multirotors but for FW it is way too narrow a default.
The allow use of the full range of the DeltaQuad you would need to set 200 waypoints this way.
Any ideas on how to solve this? Maybe disable by default and set it separately in MC FW and VTOL rc defaults script?

@sanderux I didn't think of that. I was assuming most people can only fly line of sight, so a radius of 500m anyway 😄.
I think it makes sense to change the param once you are actually doing a longer mission (and really know what you're doing), or change the param for the vehicle, so you could add it into the DeltaQuad startup script.

It is making it hard for me to manage vehicles already in service when they upgrade.
but if it is what it is i suppose i will have to instruct all of them to disable this param or set it to something sensible.

I guess so. Otherwise you can hard-code it for DeltaQuad in:
https://github.com/PX4/Firmware/blob/master/ROMFS/px4fmu_common/init.d/13013_deltaquad#L110
if param compare MIS_DIST_WPS 900
then
    param set MIS_DIST_WPS <new value>
fi

For the DeltaQuad i can fix it (its still manageable now) but im also concerned for other vtol/fw users

I still think the default values make sense for the general case because I think we should err on the side of caution and trying to prevent fly-aways.


Define community structure

How do I become a flagd:

Member
Promoter
Contributor
Maintainer
Docs maintainer

What even are the "levels" and how do I "move through" them, when, why and how?
For example, I would like to put myself forward as a docs maintainer.
@staceypotter FYI

The community structure should come from the OpenFeature org guidelines.
https://openfeature.dev/community/


Bundle output not created after first compilation

Hi! Thank you for developing this rule. It looks great ❤ !
I'm trying to use this rule to speed up builds using webpack and persistent workers.
Description of the problem
First compilation works great, but any change in source files makes consecutive builds fail because no bundle output is generated.
The app I'm trying to build is a typescript and react app (.tsx).
Minimal reproduction
BUILD file:
ts_config(
  name = "typescript_config",
  src = "tsconfig.app.json",
  deps = [
    "//:tsconfig.base.json",
    ":tsconfig.json",
  ],
)

SRCS = [
  "src/main.tsx",
  "src/app/app.tsx",
  "src/app/welcome.tsx",
]

DEPS = [
  "@npm//@types",
  "@npm//styled-components",
  "@npm//react",
  "@npm//typescript",
  "@npm//react-dom",
]

ts_project(
  name = "ts",
  tsconfig = ":typescript_config",
  allow_js = True,
  source_map = True,
  srcs = SRCS,
  deps = DEPS,
  supports_workers = True,
)

webpack_bundle(
  name = "bundle",
  data = [
    ":ts",
    ":webpack.config.js",
    "@npm//:node_modules",
  ],
  supports_workers = True,
  entry_point = "src/main.js",
  webpack_config = ":webpack.config.js",
)

webpack app config is just a babel loader with some presets:
      {
        test: /\.tsx?$/,
        loader: 'babel-loader',
        options: {
          presets: ['@babel/preset-env','@babel/preset-react', '@babel/preset-typescript']
        }
      }

Steps:

Run bazel build //:bundle. First compilation successfully generates the application bundle (using webpack_dev_server rule I can see the app up and running)
Make a change in one of the ts files (E.g src/app/welcome.tsx)
Runbazel build //:bundle again. It sends the inputs to the webpack worker, worker says that Compilation Has succeeded but bazel crashes because no output is generated

Error
output 'apps/examples/example-front/bundle.js' was not created
ERROR: `/`/` Running Webpack [webpack-cli] failed: not all outputs were created or valid

Environment
Output bazel version:
Build label: 4.2.1
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Mon Aug 30 15:24:28 2021<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

Tested with bazel 5.0.0 and got the same result.
Rules_nodejs version: 5.1.0    Rules webpack version: 0.2.1

Debugging the worker a bit seems like everything is ok (I'm not a webpack expert).
What I've seen is that the WorkerWatchFileSystem get the inputs from the worker_adapter and it adds the changed source file to changes map and callbackUndelayed.

I'll take a look at this at my earliest convenience.
However, I wanna point out a few things that I feel are wrong but should not affect anything.

you might not need preset-typescript as ts_project handles the transpilation part.
the as above but for preset-react as typescript also handles that part? (not sure though)

things you might try to do whilst we look into this.

try to remove babel and leave the transpilation part to typescript
disable worker mode for ts_project
disable worker mode for webpack_bundle (just to see if the error is in fact only happens in worker mode.)

Thanks to take a look in to this, @thesayyn.
I think you're absolute right about the preset-typescript.
Trying out the the options you mentioned:

No babel loader: It still fails with rebuilds (however first compilation works, so I think there's no need for babel loader).
Disable worker mode for ts_project: Tried this before and it fails too
Disable worker mode for webpack_bundle: Yes, I also tried this one before. The issue does not occur with standalone runs

thanks for narrowing the possibilities. most certainly something is broken in worker mode.

hi @thesayyn. Any updates on this?

hi @thesayyn. Any updates on this?

this should be solved by #15. but beware that rules_webpack is not layered on top of rules_nodejs anymore. You need to switch to rules_js in order to use the new version of rules_webpack.

closing as fixed. feel free to reopen if the issue persists.