PHOENIX-6295 : Fix non-static inner classes for better memory utilization

4.x backport of PR #1053

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 11s
4.x passed

+1 :green_heart:
compile
1m  4s
4.x passed

+1 :green_heart:
checkstyle
2m 21s
4.x passed

+1 :green_heart:
javadoc
0m 47s
4.x passed

+0 :ok:
spotbugs
3m 17s
phoenix-core in 4.x has 962 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m  3s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

-1 :x:
checkstyle
2m 20s
phoenix-core: The patch generated 60 new + 6925 unchanged - 64 fixed = 6985 total (was 6989)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

-1 :x:
spotbugs
3m 32s
phoenix-core generated 1 new + 947 unchanged - 15 fixed = 948 total (was 962)

_ Other Tests _

-1 :x:
unit
190m 30s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

231m 58s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.hbase.index.covered.update.IndexUpdateManager$MutationComparator implements Comparator but not Serializable  At IndexUpdateManager.java:Serializable  At IndexUpdateManager.java:[lines 47-94]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1054

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux e0ea573d2332 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 5ad54f9

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/testReport/

Max. process+thread count
5696 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 11s
4.x passed

+1 :green_heart:
compile
1m  4s
4.x passed

+1 :green_heart:
checkstyle
2m 21s
4.x passed

+1 :green_heart:
javadoc
0m 47s
4.x passed

+0 :ok:
spotbugs
3m 17s
phoenix-core in 4.x has 962 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m  3s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

-1 :x:
checkstyle
2m 20s
phoenix-core: The patch generated 60 new + 6925 unchanged - 64 fixed = 6985 total (was 6989)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

-1 :x:
spotbugs
3m 32s
phoenix-core generated 1 new + 947 unchanged - 15 fixed = 948 total (was 962)

_ Other Tests _

-1 :x:
unit
190m 30s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

231m 58s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.hbase.index.covered.update.IndexUpdateManager$MutationComparator implements Comparator but not Serializable  At IndexUpdateManager.java:Serializable  At IndexUpdateManager.java:[lines 47-94]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1054

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux e0ea573d2332 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 5ad54f9

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/testReport/

Max. process+thread count
5696 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 59s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 28s
4.x passed

+1 :green_heart:
compile
1m  4s
4.x passed

+1 :green_heart:
checkstyle
2m 20s
4.x passed

+1 :green_heart:
javadoc
0m 48s
4.x passed

+0 :ok:
spotbugs
3m 25s
phoenix-core in 4.x has 962 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 54s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
2m 21s
phoenix-core: The patch generated 60 new + 6924 unchanged - 64 fixed = 6984 total (was 6988)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

+1 :green_heart:
spotbugs
3m 25s
phoenix-core generated 0 new + 947 unchanged - 15 fixed = 947 total (was 962)

_ Other Tests _

-1 :x:
unit
195m 30s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

241m 17s

Reason
Tests

Failed junit tests
phoenix.end2end.index.PartialIndexRebuilderIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1054

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 8b231ff33d8e 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 16c0bb4

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/testReport/

Max. process+thread count
6193 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 59s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 28s
4.x passed

+1 :green_heart:
compile
1m  4s
4.x passed

+1 :green_heart:
checkstyle
2m 20s
4.x passed

+1 :green_heart:
javadoc
0m 48s
4.x passed

+0 :ok:
spotbugs
3m 25s
phoenix-core in 4.x has 962 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 54s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
2m 21s
phoenix-core: The patch generated 60 new + 6924 unchanged - 64 fixed = 6984 total (was 6988)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

+1 :green_heart:
spotbugs
3m 25s
phoenix-core generated 0 new + 947 unchanged - 15 fixed = 947 total (was 962)

_ Other Tests _

-1 :x:
unit
195m 30s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

241m 17s

Reason
Tests

Failed junit tests
phoenix.end2end.index.PartialIndexRebuilderIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1054

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 8b231ff33d8e 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 16c0bb4

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/testReport/

Max. process+thread count
6193 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Perilous Moon

Adds Perilous Moon. On review, there's two bits that should be specifically considered:

At the start, try to skip the dialog from the builders when you're about to enter Cam Torum. This sets something where they recommend talking to Jess, but I'm not sure it's strictly required.
At the end, see if only talking to Jess and Zuma works for finishing the quest, skipping talking to Attala. From the variables available, it seems he's optional to talk to.  Who knows, maybe given long enough, you might start to grow on them!.

I refuse to do the quest until this is added lol


Add emscripten targets to new 'rustbuildcross' slaves

I'm still waiting for the nightly to finish in dev, but I think it will be successful.
I ended up doing this by adding new "rustbuildcross" slaves, which of course will take up more resources...

@brson: no appropriate reviewer found, use r? to override

This doesn't actually work correctly....

I'm going to force-push a revert.


only load org.reflections classes when #scanClasspathForConcreteTypes…

… is enabled

Fantastic! Thank you for the quick update.
Do you think I can make the dependency optional after this change?

Yes you can make it optional

Ok great, I'll do it


Image blending

Hi everybody,
I want to display segmentation mask as an overlay of my DICOM image.
I tried your lesson 04 viewers_labelmap but the modality SEG is not supported or implemented by most of the tools used to segment images...
So, is it possible to display a mask even if it's not a SEG modality?
Moreover, it would be nice if we can upload other formats for segmentation like mhd/raw, vtk, itk, etc...

Yes, you can overlay any kind of data as long as we can parse it (dcm, nii, mhd/raw, nrrd).
Did you have a look at this one?
For models (vtk) see the approach used there
Does it help?

In the second example, in the 2D renderers, do the masks are sections representations of the 3D models?
Because the source you are only uploaded .stl and a DICOM.
Many thanks for you quick answers!

Yes @FredChamp, is is a representation of the intersection between the 3D model and the slice.
Example 1 was to highlight how to overlay 2 "images" and the second example was about images + 3D models.

Thank you Nicolas!
Just a last question: do you have any example of how to overlay a mhd/raw image over a DICOM?

@FredChamp not yet but if you have some anonymized data available only we can easily put a JSFiddle together -

@FredChamp note that the MHD/RAW viewer is experimental, there might be orientation issues but due to the lack of testing datasets we left it as it is for now - testing against your data will help a lot in this matter, to make sure orientation is what it should be!

Ok thanks a lot @NicolasRannou ! It will be really helpful if you can provide a JSFiddle ;)
In the following WeTransfer link, you can find a DICOM image + a mhd/raw mask.
https://we.tl/ubDa9Q0GU0
Bests,

Thx - @FredChamp which tool do you use to see DICOM + mask on top of each other?

I'm using ScanIP software but for web purpose, we currently try to implement AMI on our web platform.
Concerning DICOM visualization is possible to have a sequential slice loading as the Lify example:
https://lify.io/watch/62116fb17e0444879845ea23fb1c105c

OK Thanks - would to happen to have smaller datasets in order to speed up the debugging process?

Sorry, all my DICOM are quite big...

Could you somehow just load 3 slices of the data in ScanIP and generate a "dummy" segmentation? And also send a screenshot of what you expect it to look like? I can load MHD properly but it doesn't overlay as expected so far... Not sure what is going on...

Thank you, Nicolas!
I don't want to waste your time! So because I have STL, I can generate "mask" as you shown in the example.
Concerning DICOM loading, does AMI is able to do "sequential slice loading ?" as the following example:
https://lify.io/watch/62116fb17e0444879845ea23fb1c105c

Sorry for the late answer, was traveling for the past week with no internet connection -
That wouldn't be a waste of time :) that would be very helpful as other people are interested into it too but there is a lack of testing datasets on my side -
I addition, it should perform much better than the STL approach.
Sequential loading is possible but there are a couple of gotchas. Best way to make it would be to implement a new helper that would to the on-demand loading. With this approach, you can only look at the data in the "acquisition" direction and would need extra information about the data to be loaded.
Please open a new issue to chat more about this problem if you are still interested into it!

Hi Nicolas,
Thank you for your help!
Please find this WeTransfer link with a DICOM of 20 slices and the associated MHD/RAW mask.
https://we.tl/cqNFt4fPQY
Concerning performances, it seems STL approach is better because it avoids mask loading (100 Mo).
If the app is deployed on a server, it will decrease the amount of data stored for each patient case and will speed up the upload/load time.

awesome @FredChamp !
Dou you know if there could have been an issue while generating the first mhd/raw mask you provided? The offset seem strange but the new file you provided appears to work as expected.

Yeah it's possible, but cool if the new one works ;)

OK I'll close it then, please re-open if needed! @FredChamp


Show scheduled game number

Given that Schedule takes you to this ordered lists of games to be played, it would be good to be able to see in the viewer a reference of which game is being played.
Use case for this is knowing when your engine plays (i.e. games # 30, 44, 58, etc.) and with a quick glance at the viewer being able to estimate how long until their next one.
An option to do that without thinking too much about the UI is by adding the game number at the beginning of the [Server] message, so at least you can check the # of the previous game.

This is a suggestion that requires functional changes in the underlying server that powers this tool (Toms Live Chess Server). As that will most likely never happen, these suggestions are only possible view a few "hacks".

Could scrape the given link for the schedule and try to parse that
Would want to catch the server messages announcing game results and prepend the number

Fair, it's non trivial then 😄
I haven't had the chance to have a look at the code just yet, but some reason I assumed it would be less coupled to Toms Live Chess Server.
Feel free to close the issue in that case if this is something which you consider it's not worth tracking.


How to avoid title changing.

Hello,
is there a config parameter to set to avoid page title change?
I'm using this for a project but i had to edit the state object like this:
var state = {
      original: '',
      idle: '',
      timedout: ''
    };

Thanks!

You can add idle-disabled="true" to your title to opt-out of automatic title changes. See the wiki.

Thanks a lot, I missed that!
Il 27/mag/2015 21:17, "Mike Grabski"<EMAIL_ADDRESS>ha scritto:

You can add idle-disabled="true" to your title to opt-out of automatic
title changes. See the wiki
https://github.com/HackedByChinese/ng-idle/wiki/Title#usage.
—
Reply to this email directly or view it on GitHub
https://github.com/HackedByChinese/ng-idle/issues/87#issuecomment-106039603
.


4x: Setup sample build process

Setup sample build using grunt

Kelly, this is old. closing. reopen if necessary.


mono.osx operation not permitted

Environment data
dotnet --info output:
.NET Command Line Tools (2.0.0)
Product Information:
Version:            2.0.0
Commit SHA-1 hash:  cdcd1928c9
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.12
OS Platform: Darwin
RID:         osx.10.12-x64
Base Path:   /usr/local/share/dotnet/sdk/2.0.0/
Microsoft .NET Core Shared Framework Host
Version  : 2.0.0
Build    : e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d
VS Code version:
1.14.2
C# Extension version:
1.12.1
Steps to reproduce
Attempt to Go to Definition on a class type in my code
Expected  behavior
To switch to my source file with my class definition.
Actual behavior
Nothing happens, except for the following errors...
OmniSharp server started wth Mono
Path: /Users/jasonworks/.vscode/extensions/ms-vscode.csharp-1.12.1/.omnisharp/run
PID: 83884
/Users/jasonworks/.vscode/extensions/ms-vscode.csharp-1.12.1/.omnisharp/run: line 43: /Users/jasonworks/.vscode/extensions/ms-vscode.csharp-1.12.1/.omnisharp/mono.osx: Operation not permitted

Hmmm... I haven't seen this issue before. I would expect to see this error if permissions have been changed in some way. Perhaps the extension was installed as a different user? Could you provide the full directory listing of /Users/jasonworks/.vscode/extensions/ms-vscode.csharp-1.12.1/.omnisharp. You can follow these steps to do that:

Open a new Terminal window.
Type the following:

cd /Users/jasonworks/.vscode/extensions/ms-vscode.csharp-1.12.1/.omnisharp
ls -al

Copy and paste the directory listing from the terminal window to here.

total 8304
drwxr-xr-x    7 jasonworks  5001      238 Aug 16 11:57 .
drwxr-xr-x   20 jasonworks  5001      680 Aug 16 11:57 ..
drwxr-xr-x    4 jasonworks  5001      136 Aug 16 11:57 etc
drwxr-xr-x   69 jasonworks  5001     2346 Aug 16 11:57 framework
-rwxr-xr-x    1 jasonworks  5001  4245036 Aug 16 11:57 mono.osx
drwxr-xr-x  137 jasonworks  5001     4658 Aug 16 11:57 omnisharp
-rwxr-xr-x    1 jasonworks  5001     1036 Aug 16 11:57 run

That looks OK to me. Are you able to run mono.osx from this directory? If so, could you also try running it from within the Terminal window inside VS Code?

Sorry, I'm not sure what you mean by run mono.osx.  Based on your request, here's what I have tried...
jasonworks-macbookpro:.omnisharp jasonworks$ mono --version
Mono JIT compiler version 4.6.1 (mono-4.6.0-branch-c8sr0/abb06f1 Fri Sep 23 19:24:23 EDT 2016)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
TLS:           normal
SIGSEGV:       altstack
Notification:  kqueue
Architecture:  x86
Disabled:      none
Misc:          softdebug
LLVM:          yes(3.6.0svn-mono-master/8b1520c)
GC:            sgen
jasonworks-macbookpro:.omnisharp jasonworks$ mono.osx
-bash: mono.osx: command not found
jasonworks-macbookpro:.omnisharp jasonworks$ mono mono.osx
Cannot open assembly 'mono.osx': File does not contain a valid CIL image.

Sorry, I have fledgling knowledge of mac/linux terminal.  Running ./mono.osx showed that the company I work for requires that I request the application be whitelisted.  Once I did that I was able to properly run mono.osx.  I'm now able to get intellisense and such working with VS Code.
Thanks!

Excellent! I had expected it was some sort of permissions issue. I'm very glad to hear it's working now.


How can I use my own dataset to train the model?

I want to use the simgan to train other dataset，so what format does the data need？

Uses Keras image preprocessing. Look at keras documentation but this is pretty simple. Expects each dataset to be in a directory containing directories of images corresponding to label.

So in order to use a custom dataset what code file do i have to modify? Or it is just to have the right directory structure?

Hey, you shouldn't have to modify the code. Synthesized images in one dir, refined in another. Make sure directories are named correctly. See keras image processing docs for more info.

Another question, Once the network is trained, how do i generate refined images?

@dagoPA  Did you solve this problem?how to get refined images?

@wushilian I haven't yet Because i think this project only takes a random small set of data to inference and instead of saving it only saves the weights and the plot

@dagoPA It seems like that.

@wushilian i think in the code i stead of predict batch we need a loop that iterates predicting each image in target directory

@dagoPA that's all right.And I think cycle GAN and simGAN are very similar,so now I use cycleGAN to
Converte synthetic data into real data

@wushilian I saw you forked that project, im new to github but i hope i can know your email

@dagoPA<EMAIL_ADDRESS>

@dagoPA I guess you have saw my email,so I deleted it.


Support new Nutanix-style credentials in "secretdir"

Separated NutanixCredentials definition and parsing into their own package to be shared between "kubernetes" and "secretdir" providers.

This change is based on PR 33. Diff will look cleaner once PR 33 has been merged.


Added option to use tel type for time fields

Unless there is some reason not to? Thanks for considering!

Hi Tom,
thanks for your contribution!
There was some discussion in #3, #42 and #43. It is not possible to use type="number" because the field features prefix zero which is not supported by that type. I've decided that we can use type="tel" as an optional feature (use some attr to switch type="text" to type="tel"). If you are interested, feel free to implement it :)
Thanks again for your work!

How about now? I haven't tested this but it seems straightforward enough...

This won't work as expected, because $scope.timeFieldType is a function, but it is used as a string value in the template. But we can simplify this more, see review notes.

Haven't forgotten about this one! Just short on time ATM. Hope to finish this up within the year :)

No problem, take your time 👍

Maybe you could also add
autocomplete="off" autocorrect="off" spellcheck="false"

to the input field, because I got an "ugly" autocorrect bar above the keyboard (KeyboardAccessoryBar) and autocomplete/autocorrect suggestions are not necessary when changing the time ⌛ 😅


Updated switchScene() to keep the current yaw

When switching scenes with the switchScene(), the yaw is always been reset to the initialViewParameters value of that scene. This piece of code tries to take the current yaw offset (from the initialViewParameters' value) and update the new yaw value for the newly switched scene. The prerequisite for this to work naturally is for all the scenes to have the same orientation in space (they are all facing the same side of the world, whether it is North, East, South or West), when setting the initial view.

I signed it!
From: googlebot<EMAIL_ADDRESS>Sent: 14. novembar 2017. 13:28
To: google/marzipano<EMAIL_ADDRESS>Cc: mbukejlovic<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [google/marzipano] Updated switchScene() to keep the current yaw (#124)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas  and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/ .
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/google/marzipano/pull/124#issuecomment-344244136 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASVdIlnzJprBN-nsprQqwH_JGZX17R-Xks5s2YdJgaJpZM4QdQ1P .

While this is an interesting idea in general, it is out of scope for this demo.
The demo code is shared with the Marzipano Tool (so we don't have it to maintain it separately), and it's too much to assume that panoramas uploaded into the tool are all aligned in the way you describe. For people who upload unaligned panoramas into the tool, this patch would result in an apparently random change of orientation when switching scenes.


feat: Use bloom filter when reading parquet to skip row groups

Which issue does this PR close?
Impl #4512
Rationale for this change
What changes are included in this PR?
Implement bloom filter support when pruning row group.
Are these changes tested?

[x] Test with a parquet file that can prune row group by  bloom filter
[x] Test with a parquet file that can't prune row group by bloom filter
[x] Test with a parquet without bloom filter
[x] Test with SQL  where col in (a, b)

Are there any user-facing changes?
no

I already created a PR and merged for support read bloom filter with async https://github.com/apache/arrow-rs/pull/4917
But before arrow-rs team make a new release we need to test it with a special commit id in Cargo.toml
Let's use this to discus this PR,  I will switch to the new version after arrow-rs team made the new release.
@Ted-Jiang @alamb Can you review this PR, any suggestions? Thanks

To test this feature we need to enable an option:
datafusion.execution.parquet.bloom_filter_enabled default is false
Or just set an ENV:
DATAFUSION_EXECUTION_PARQUET_BLOOM_FILTER_ENABLED=true

This is my test use the datafusion-cli in this branch:
DataFusion CLI v32.0.0
❯ create external table tbl stored as parquet location '/Users/yanghengfei/code/rust/github.com/zinclabs/openobserve/data/bloomfilter/stream/files/default/logs/traces/';
0 rows in set. Query took 0.042 seconds.

❯ select count(*) from tbl;
+----------+
| COUNT(*) |
+----------+
| 60992352 |
+----------+
1 row in set. Query took 0.083 seconds.

❯ SELECT * FROM tbl where (_timestamp >=<PHONE_NUMBER>204000 AND _timestamp <<PHONE_NUMBER>571122) AND trace_id='3c7dbf90d1a66e3faffa344519c3bac0' LIMIT 150;
+------------------+----------+---------------------+--------+-------+...
| _timestamp       | duration | end_time            | events | flags | trace_id  |...
+------------------+----------+---------------------+--------+-------+...
|<PHONE_NUMBER>199046 | 2008886  |<PHONE_NUMBER>207932061 | []     | 1     | ...
|<PHONE_NUMBER>199000 | 2009958  |<PHONE_NUMBER>208958875 | []     | 1     | ...
+------------------+----------+---------------------+--------+-------+...
2 rows in set. Query took 4.086 seconds.

❯ set datafusion.execution.parquet.bloom_filter_enabled=true;
0 rows in set. Query took 0.000 seconds.

❯ SELECT * FROM tbl where (_timestamp >=<PHONE_NUMBER>204000 AND _timestamp <<PHONE_NUMBER>571122) AND trace_id='3c7dbf90d1a66e3faffa344519c3bac0' LIMIT 150;
+------------------+----------+---------------------+--------+-------+...
| _timestamp       | duration | end_time            | events | flags | trace_id  |...
+------------------+----------+---------------------+--------+-------+...
|<PHONE_NUMBER>199046 | 2008886  |<PHONE_NUMBER>207932061 | []     | 1     | ...
|<PHONE_NUMBER>199000 | 2009958  |<PHONE_NUMBER>208958875 | []     | 1     | ...
+------------------+----------+---------------------+--------+-------+...
2 rows in set. Query took 0.234 seconds.

The information of this directory:
$ cd /Users/yanghengfei/code/rust/github.com/zinclabs/openobserve/data/bloomfilter/stream/files/default/logs/traces/
 du -sh .
2.8G	.
$ find . -name "*.parquet"|wc -l
     326

But before arrow-rs team makes a new release we need to test it with a special commit id in Cargo.toml

Thank you -- I expect that we'll have a new arrow-rs release candidate later this week and the next release in about 7 days from now, for your scheduling planning

Let's use this to discuss this PR, I will switch to the new version after arrow-rs team makes the new release.
@Ted-Jiang @alamb Can you review this PR, any suggestions? Thanks

Thank you @hengfeiyang  -- I plan to review this PR carefully later today or tomorrow

I also have an idea of how to make this code potentially even more general using interval analysis that I am trying out

FWI DataFusion has been upgraded to arrow 48 now

@alamb Thanks, already rebased the main branch.

My question might be naive, but if count(distinct values) == number of rows then does this MR use this info (eg returning early from the scan because we know it’s exactly one row as the column is a primary key)?

@alippai The count or distinct can't optimize by bloom filter.

My understanding is that bloom filter returns false positives which you have to filter exactly (without a bloom filter) in a second step. I was referring to the second step. I never wrote such algorithm before so there is a good chance I don’t know what I’m talking about 😅

My understanding is that bloom filter returns false positives which you have to filter exactly (without a bloom filter) in a second step. I was referring to the second step. I never wrote such algorithm before so there is a good chance I don’t know what I’m talking about 😅
Hi @alippai  -- what this PR does is use the (optional) Bloom Filter that is stored in parquet files to evaluate equality predicates more efficiently -- for example, a = 4 type predicates.
In general it would be interesting to contemplate using a bloom filter for COUNT(distinct ...) type predicates, though the existing hash table based implementation is pretty fast


Build query string from context instead of original request

Recreate query string from either getCurrentContext().getRequestQueryParams()
or original request as fallback. This allows to override query string
params in pre filters and matches behaviour of RibbonRoutingFilter
gh-426

Two questions, how about a unit test to verify your fix?  Also, have you signed the contributor agreement?

I am unsure how to go about it - SimpleHostRoutingFilter is quite opaque and I don't see a way to mock HttpClient, override forwardRequest() or intercept constructed request in another way.
Yes.

Don't mock make a real request ala https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/zuul/SampleZuulProxyApplicationTests.java

I added two tests - one showing that overriding query string works and another to verify that it does not break normal case.

@qbast very nice, thanks!

Merged via 22ed8818053d3915200e422c6d56801af8a861d6

I know this is a closed issue, but I wanted to bring to everyone's attention that this implementation is going to be problematic because URLEncoder does not properly encode query parameters as it encodes "/" and "?" which are not necessary to be encoded in query parameter values and will cause some applications to fail as they do not expected an encoded value here.

@Xero314 you're right it is closed. Please open a new issue if you think there is an issue.


IntProperty does not support upper bound > 1

This issue is blocking development of OPIL.
  File "/usr/local/lib/python3.7/site-packages/sbol3/int_property.py", line 41, in IntProperty
    raise ValueError('Upper bound > 1 not handled yet')
ValueError: Upper bound > 1 not handled yet

The SBOL 3.0 data model doesn't require integer properties with upper bound greater than 1, so IntListProperty is not yet implemented. The same holds for Boolean, DateTime, and Float properties. None of these should be hard to implement, as they are largely copy/paste. We'll want to define Custom classes for the unit tests because no core class is available to use in these cases.


Is there a way to filter the obtained user-agents?

Hi everyone,
I have a Scrapy script that uses "scrapy_user_agents" and i was planning to change to "scrapy-fake-useragent". I was wondering if exist a mechanism to filter or validate the user agent to use. I need to check if its from the latests  versions of the browser. Thats because currently some of my scripts fails, and when i investigate the error it turns out that the website indicates that my user-agent is outdated and "not secure" to use  their page.
So, I came here to ask for advice, and if this is not the place for this type of question, I would appreciate it if you would let me know so I can ask it where appropriate.
Thanks in advance

Subclass the middleware (see https://github.com/alecxe/scrapy-fake-useragent/blob/371254aafd34244de8098ccc6c36320d1a1c3024/scrapy_fake_useragent/middleware.py, it's not that much code), change how it treats the result of self._ua_provider.get_random_ua(), and in settings set your middleware instead.


⚠ Samsung has degraded performance

In e907df1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3069 ms

Resolved: Samsung performance has improved in 53d6df4.


Update InstallArc.php

Fix Process Library Update
Fixes #25

Thanks for the response and the pull request 😊🙏


Discover Imagery Relevant to Your Mission – needs slides and video posted

for Ops Server release
Deadline 9Oct
see email for post location

The slides have been posted.

The current version of the Discovery App needs to be rebuilt with different styling before I can make the video.  This will keep the video consitent with the demo/released version.

Video has been posed to \disldb\OpsServerStaging\2015_Q4\Resources\Videos\ImageDiscovery


feat: Popular cities name

Issue #20 solved.
If everything works fine do merge this under 'hacktoberfest' and 'hacktoberfest-accepted' label?

its not working so marking invalid

@kanishk-001 Can you add this under 'gssoc-ext' label as well ?


⚠ WSINGRESOS - RECIBOPAGO has degraded performance

In 540c67a, WSINGRESOS - RECIBOPAGO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsRecibosPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 5369 ms

Resolved: WSINGRESOS - RECIBOPAGO performance has improved in 7dfad38 after 10 minutes.


Add logo and favicon

and a few other improvements
@jgroth don't forget to add them here as well: https://docs.kompendium.dev/

:tada: This PR is included in version 0.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Acceptance tests hang

Running the acceptance tests seem to hang at
Debug: Prefetching v2 resources for route53_mx_record
Debug: Checking if MX record local.98515e13-b948-4762-b531-904e2c471383.com. exists
Info: Deleting MX record local.98515e13-b948-4762-b531-904e2c471383.com.
Let run for hours with no progress. How can I see what this is waiting on?

@daveseff, I've reconfirmed this issue, and even when I run each Route53 test individually, it happens. I'll keep digging into this, but for now, I've temporarily disabled the Route53 acceptance
tests with https://github.com/puppetlabs/puppetlabs-aws/pull/452. (This is to unblock all of the other acceptance tests, which run on each merge.)


Polyglot Rebrand Feedback

Hey All!
I'm finding the rebrand a bit confusing since .NET Interactive seems to still exist? Do we have a good landing page to differentiate .NET Interactive and Polyglot Notebooks?
My suggestion would be to go all-in on Polyglot for all the related products for brand continuity

Polyglot Notebooks - Extension/Front End

Polyglot Kernel or Polyglot Interactive  - Backend Kernel

.NET SDK for Polyglot Notebook - .NET NuGets for extension writing and libraries for interacting with kernel.

Python SDK for Polyglot Notebooks - Python libraries for extension writing and libraries for interacting with kernel.

JS SDK for Polyglot Notebook - JS libraries for extension writing and libraries for interacting with kernel.

That will help a bit. The branding still seems to lack continuity though.

In the Kernel/Language picker it just says both everywhere.

They are two different layers.
The .NET Interactive kernel can be used for things other than notebooks, e.g. dotnet-repl and other non-notebook form factors.
Polyglot Notebooks can be used for non-.NET kernels (e.g our JavaScript kernel and potential future polyglot Jupyter kernels don't require .NET).
Do you think more closely aligning the naming would clarify or confuse these examples?

For me it's just confusing for ".NET Interactive" to exist as a public facing brand after a rebrand to "Polyglot Notebooks".
.NET Interactive is still

The github repo https://github.com/dotnet/interactive
In the language picker
The nuget names https://www.nuget.org/packages/Microsoft.DotNet.Interactive/1.0.0-beta.22553.7
The url for installing the extension https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.dotnet-interactive-vscode
Everywhere inside of the Polyglot Notebooks extension

Polyglot Notebooks is

The name of the extension

It feels like a shallow rebrand and requires folks that are new to Notebooks to know the nuances of Notebooks and Kernels to get the difference.
Feel free to close out the issue if you all disagree and haven't heard similar feedback from others -- Just my 2 cents.

.NET Interactive kernel can be used for things other than notebooks, e.g. dotnet-repl and other non-notebook form factors.

Doesn't it also support more languages than just .NET? Isn't this the thing that makes Polyglot Notebooks ... Polyglot?

Polyglot Notebooks can be used for non-.NET kernels (e.g. the JavaScript and HTML kernels as well as potential future polyglot Jupyter kernels don't require .NET).

Doesn't it still require .NET Interactive?

The intent is not to rebrand .NET Interactive, which is a .NET-based technology that hosts .NET languages like C#, F#, and PowerShell. You can use it to create non-polyglot experiences.
The protocol it uses is language-agnostic and enables polyglot experiences like Polyglot Notebooks.

It feels like a shallow rebrand and requires folks that are new to Notebooks to know the nuances of Notebooks and Kernels to get the difference.

Learning the difference between a notebook and a kernel is fairly important early on in learning Jupyter, I think.

.NET Interactive kernel can be used for things other than notebooks, e.g. dotnet-repl and other non-notebook form factors.

Doesn't it also support more languages than just .NET? Isn't this the thing that makes Polyglot Notebooks ... Polyglot?

It doesn't support them directly and has no special knowledge of them. It supports them by proxying those behaviors to remote processes.

JavaScript and HTML are proxied to browser-hosted kernels written in TypeScript.
SQL and KQL are proxied to the SQLToolService executable.
Python, R, etc. are proxies to Jupyter kernels.

Polyglot Notebooks can be used for non-.NET kernels (e.g. the JavaScript and HTML kernels as well as potential future polyglot Jupyter kernels don't require .NET).

Doesn't it still require .NET Interactive?

The JavaScript and HTML kernels don't require .NET Interactive today. Though we haven't yet made them available standalone in Polyglot Notebooks, they can be loaded into a browser and used directly with no .NET in the picture. And Polyglot Notebooks will eventually work in browser-only mode with no server-side compute needed.

I think it's starting to make more sense then.

What is the motivation for (Polyglot Notebooks) to be in the language picker for everything then?

Each of the languages listed with (Polyglot Notebook) after it is actually a superset of the language, which allows e.g. C# and Polyglot Notebook magic commands.
The following isn't valid C# but it is valid in Polyglot Notebooks:
#!share --from fsharp someVariable
Console.WriteLine(someVariable);

I see - that's pretty nuanced!


Default args for nested inductive constructors

Prerequisites
Please put an X between the brackets as you perform the following steps:

[x] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
For nested inductive types, any nested-inductive arguments to the constructors can't be assigned a default value.
Steps to Reproduce
inductive Foo
| mk (x : Array Foo := #[])

Expected behavior: It should compile, and Foo.mk should have a default value for x.
Actual behavior: An error is thrown:
application type mismatch
  optParam _nested.Array_1 #[]
argument has type
  Array Foo
but function has type
  _nested.Array_1 → Type

Versions
Reproduced on

4.9.0-nightly-2024-05-25
4.11.0-nightly-2024-07-29

Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

duplicate of #4824


Use jsonld-context-parser for expanding properties

This is quite a bit more lightweight than jsonld.js, and probably faster as well, since the context is parsed+normalized only once.
Bonus feature: not only context objects can be passed, but also context arrays and URLs (such as https://schema.org/)
Closes #1

Pull Request Test Coverage Report for Build 90

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 89:
0.0%

Covered Lines:
232

Relevant Lines:
232

💛  - Coveralls

Great, thanks!


chg: fix: RUB-114: Fixed the security bugs reported

Codecov Report

Merging #266 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #266      +/-   ##
=========================================
- Coverage   50.16%   50.1%   -0.07%
=========================================
  Files          60      60
  Lines        2994    2994
  Branches      325     325
=========================================
- Hits         1502    1500       -2
- Misses       1404    1406       +2
  Partials       88      88

Impacted Files
Coverage Δ

.../qubole/rubix/hadoop2/Hadoop2ClusterManagerV2.java
49.12% <0%> (ø)
:arrow_up:

...n/java/com/qubole/rubix/bookkeeper/BookKeeper.java
70.27% <0%> (ø)
:arrow_up:

.../com/qubole/rubix/bookkeeper/BookKeeperServer.java
60.41% <0%> (ø)
:arrow_up:

...om/qubole/rubix/hadoop2/Hadoop2ClusterManager.java
60.97% <0%> (ø)
:arrow_up:

...ole/rubix/bookkeeper/validation/FileValidator.java
68.96% <0%> (-6.9%)
:arrow_down:


MAINT: mypy: fix errors about incompatible types in lists

Reference issue
None
What does this implement/fix?
The following construct appears several times in the codebase:
real_dtypes = [np.float32, np.float64]
dtypes = real_dtypes + [np.complex64, np.complex128]

Mypy doesn't like that because

it types the first list as Type[np.floating]

the second line then tries to add things of type Type[np.complex64]

lists are invariant:
https://mypy.readthedocs.io/en/stable/common_issues.html#invariance-vs-covariance

We could fix this by explicitly typing the first list more
broadly, but this instead fixes it by making those lists
tuples. Philosophically tuples make sense here-we are creating a
fixed length, immutable sequence of dtypes to iterate over, not a
mutable possibly growing container of dtypes.
Additional information
Mypy started picking this up because we added the NumPy type
stubs-before both of those lists would have been List[Any],
which mypy would have been fine with.

With this patch, mypy errors are reduced to:
$ mypy
scipy/linalg/setup.py:121: error: Cannot find implementation or library stub for module named 'linalg_version'  [import]
scipy/linalg/setup.py:121: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
scipy/io/matlab/tests/test_mio.py:140: error: Argument 2 to "zeros" has incompatible type "List[Tuple[str, Type[object]]]"; expected "Union[dtype, None, type, str, Tuple[Any, int], Tuple[Any, Union[int, Sequence[int]]], List[Union[Tuple[Union[str, Tuple[str, str]], Any], Tuple[Union[str, Tuple[str, str]], Any, Union[int, Sequence[int]]]]], Dict[str, Union[Sequence[str], Sequence[Any], Sequence[int], Sequence[Union[bytes, str, None]], int]], Dict[str, Tuple[Any, int]], Tuple[Any, Any]]"  [arg-type]
scipy/io/matlab/tests/test_mio.py:140: note: "List" is invariant -- see http://mypy.readthedocs.io/en/latest/common_issues.html#variance
scipy/io/matlab/tests/test_mio.py:140: note: Consider using "Sequence" instead, which is covariant
Found 2 errors in 2 files (checked 626 source files)

I have no preference about this and if it helps to move us forward with MyPy +1 from me.

Alright, thanks Josh


[FEATURE] Fully support Enable File Requests in SharePoint or OneDrive

Is your feature request related to a problem? Please describe.
Limited functionality
Describe the solution you'd like
I can use PnP to set the Request files at a tenant level for sites and OneDrive, e.g.  Set-PnPTenant -CoreRequestFIlesLinkEnabled $True -CoreRequestFilesLinkExpirationInDays 14 -OneDriveRequestFIlesLinkEnabled $True -OneDriveRequestFilesLinkExpirationInDays 7
and also at the site level, e.g. Set-PnPSite -Identity $SiteURL -RequestFIlesLinkEnabled $True -RequestFilesLinkExpirationInDays 30
However, Get-PnPTenant and Get-PnPSite do not return the current values, so I must revert to SharePoint Online PowerShell.
Describe alternatives you've considered
You can use SharePoint Online PowerShell as described https://learn.microsoft.com/en-us/sharepoint/enable-file-requests
Get-SPOTenant | Format-List CoreRequestFIlesLinkEnabled, CoreRequestFilesLinkExpirationInDays, OneDriveRequestFIlesLinkEnabled, OneDriveRequestFilesLinkExpirationInDays
Get-SPOSite -Identity $SiteURL | Select-object url, RequestFIlesLinkEnabled, RequestFilesLinkExpirationInDays
Additional context
Screenshot of sunning Get-PnPSite and Get-SPO site

Correct, these are missing. Adding them now.

hi @nikki-c , has been fixed. Will be available in tomorrow's nightly builds as well as the next major version when we release it.

I have just tried with nightly build that I installed using
Install-Module PnP.PowerShell -AllowPrerelease
And it still doesn't show the option in Get-PnPTenant, although I got confirmation that its working now for sharepoint users.
Thanks!

@spigaz Works here. What is this returning for you?

I don't know, something went wrong when I installed the Prerelease? I had to use -Force

I existed the powershell and then tried again and it works now.

Must be that you already invoked PnP PowerShell in that PowerShell screen before you updated. In that case, it keeps it in memory.

It makes sense. Thanks!


Create npm-publish.yml

Hi @nadavshatz, I see that you haven't attached any Trello card, let me help you with that...

 ember-gtm - Create npm-publish.yml


Update Composer dependencies (2021-09-30-21-12)

Visual regression test passed!
View the visual regression test report


How can I make BeforeSuite steps configurable?

I need to do something like the following:
BeforeSuite:
   Given my db runs at "{{DB_HOST}}"

Scenario:
    Given I can reach my api at "{{API_HOST}}"
    When I make a request to get all gifts with label "{{GIFT_LABEL}}"
    Then I should get at least 1 gift back

Then in a BeforeSuite step I want to seed my database, then I can run different scenarios in parallel that depend on the seeded data. I need to have DB_HOST configurable to enable my tests to run across environments (eg. a db deployed locally is going to have a different hostname from a db deployed on Kubernetes).

Hi, read the godoc. If you wanted it as a background step in gherkin, then change it.
Though, your gherkin looks ugly with these environment variables, why it cannot just take it from the step as Given my production database is running the step could read production as an argument, translate it to DB_HOST use the production database and work on it.

@l3pp4rd the only inputs to the test are the variables passed through the arguments which makes it easier to reason about the actual requirements needed for the test to run. If I start mapping a word in a step with a source of inputs that I need to get in my tests via a different way, eg. environment variables then the test is more complicated to setup and run across all envs because now apart from setting up the features files appropriately I need to:

document that this test depends on an env variable apart from its feature file
make sure the right variable is set during the test's runtime


ERR_CONNECTION_REFUSED

Hotel not working on chrome but on all other browsers. When i try to access http://hotel.local it shows ERR_CONNECTION_REFUSED. But is working when try to access same via safari or firefox

duplicate of https://github.com/typicode/hotel/issues/326


Erigon node choice

Feature details
Add Erigon as an execution client choice for ethereum networks

Looks like we can do this now https://erigon.gitbook.io/erigon/basic-usage/getting-started/docker
I don't think they had a single container option previously.

Available in the latest release v6. Unfortunately, you can't auto update to this version. you must re-download NiceNode and install


Update why.rst

Fix of obvious typo.

Current coverage is 100% (diff: 100%)

Merging #57 into master will not change coverage

@@           master   #57   diff @@
===================================
  Files           7     7
  Lines         363   363
  Methods         0     0
  Messages        0     0
  Branches       86    86
===================================
  Hits          363   363
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 46ac6b6...c6795c7

Thank you!  Turns out, any code that is not automatically tested, contains bugs. ;)


Mark RegEx type as deprecated in favor of stdlib Regex

Users should migrate to Swift stdlib Regex type instead.

@swift-ci test


Is the cpu metric available?

Looking at the code, it appears that the relevant code for the cpu is still under development.
If i simply modify the policy registration (Constants.metrictype: public static String[] metrictype = {METRIC_TYPE_MEMORY, "CPU"};) part, auto scaling seems to work with the cpu metric.
Could it be used this way?
For some reason, is the cpu metric unusable?

We have no plans to expose the CPU metric. We are building this to make other metrics possible and our first goal is memory. CPU is problematic because it doesn't provide enough detail to make an accurate assessment. In CF, an application can be given any amount of available CPU. If we were to see an application use 800% CPU, does it mean we should scale out? It is using what is available which isn't a bad thing. Until we have enough data to decide that CPU is being exhausted, we are avoiding it.

@fraenkel can this be reconsidered? We are running with the cpu_quota_per_share_in_us setting and thereby limiting the CPU shares that containers can use. If we are close to the limit we would like to scale up applications.


[jsperf.com bug] Sorry, you have been blocked

When opening this page:
https://jsperf.com/eval-vs-script-tag/2
Cloudflare Ray ID: 4581fbd9285e34b2
This url works well for me: https://jsperf.com

Sorry, we have very little control over Cloudflare's blocking

Is there any specific reason why this happening ONLY on this website?
(for me this happening when I'm trying submit a new test)

Because of cloudflare XSS protection, it filters out specific javascript code.

Cloudflare Ray ID: 53dc5e580f7bd709

I'm getting blocked when trying to add a third-party library to the test. For example, when clicking on the jquery to add corresponding script. Just that automatically blocks me

@DmitryEfimenko just try https://www.measurethat.net/Benchmarks/

I have been blocked too, I think you guys need better developer to know who is harmful and who is not, I was just adding another test cases. You lost one person,

What a bummer. I really liked using this service. Now cannot edit anything.

Renamed ticket because I get heart attack every time I receive new email "Sorry, you have been blocked"

Because of cloudflare XSS protection, it filters out specific javascript code.

...on a website designed to receive a JS code to run in browser 🤦♂

Just happened to me as well..guess I can't use jsperf anymore. @Finesse thanks for the suggestion!

@maxbeatty You seriously want people to go away from jsperf because of your cloud provider ?

@meetDeveloper please be respectful and constructive with your comments.

@meetDeveloper I meant people are commenting on this ticket and you are taking no action.


Using COLLAB Dataset

❓ Questions & Help

hello.
I want to use collab dataset.
I could find the way of pubmed, citeseer, cora using Plaintoid.
And I could find the way of reddit using "from torch_geometric.datasets import Reddit"
But I cannot find the way of using "collab dataset" or any example code of using "collab dataset".
In this web page(https://ls11-www.cs.tu-dortmund.de/staff/morris/graphkerneldatasets), this says
"The datasets can also be accessed using PyTorch Geometric" which makes me think that there is a certain way of calling "collab dataset".
Is there any way OR i ought to make my own using raw collab data?
thank you.

COLLAB can be accessed via torch_geometric.datasets.TUDataset :)

Oh! thank you for reply. then, two following small detail questions.
Q1. the possible 'name' values could be found in this web page(https://chrsmrrs.github.io/datasets/docs/datasets/), right?
upper-case letter and lower-case letter(english alphabet) should be decided by the list of names in this web page, right?
Q2. Then, simply this would works, right?
from torch_geometric.datasets import TUDataset
dataset = TUDataset(path, name='COLLAB')
Thank you :)

Exactly!

hello, again.
I could get COLLAB 5000 dataset, as you instructed.
But the datasets look like this (ex, Data(edge_index=[2,2352], y=[1])), which means this dataset is not for graph neural network. It seems normal graph data.
What i want was COLLAB dataset for Graph Neural Network.
Dataset's format is like this (#vertex 12,087 #feature length 492, #edge 1,446,010 from this paper https://arxiv.org/pdf/2001.02514.pdf).
After i googled, I found this site(https://dl.acm.org/doi/pdf/10.1145/2783258.2783417) would be related to it.
Can you tell me how to get COLLAB for graph neural network.
Thank you.

Oh, i will try this(https://github.com/rusty1s/pytorch_geometric/issues/1557).
Thanks.

It seems like they are using exactly this dataset, but batch it together into a single graph. Node features need to be added manually.

okay. dataset[0] is like "Data(edge_index=[2,2352], y=[1])". So, it seems like graph classification problem. Because one data has bunch of edges but no vertex label, only has one label. I wonder how i can decide the size of vertices. But i will try and find the solution and share that in this issue later.
Thanks!


App.js location in todos example

In todos example, App.js is in the components folder. This seems a little confusing to me. In other examples, App.js is in the containers folder which makes more sense.
Thanks,
William

Created pull request; https://github.com/reactjs/redux/pull/1467

It is there for a reason. In some examples, App is connect()ed to Redux store and acts as a container. In other examples, it’s a purely presentational component that isn’t aware of Redux store.
I would like to convert more examples to make App presentational. For example, see #1354.

Ah, thanks for clarification.


fix(lsp): use distinct styles for (non-)underline diags

Supersedes #136
Fixes https://github.com/sainnhe/gruvbox-material/issues/120
Fixes https://github.com/sainnhe/sonokai/issues/87
Fixes https://github.com/sainnhe/everforest/issues/121 (proper fix, not upstream workaround)
Fixes https://github.com/sainnhe/gruvbox-material/issues/145 (proper fix, not upstream workaround)
Description
Ensures that LspDiagnostic and LspDiagnosticUnderline use distinct styles: highlighted for the former, underline (undercurl) for the latter.
Rationale:

If underline is enabled in Neovim, the editor will always use the LspDiagnosticUnderline variant.
By setting a foreground color for the LspDiagnostic variant, we ensure that the many popular plugins which leverage these highlight groups default to the correct foreground color.

I have used these settings for a bit and tried them with plugins that used to have issues with Everforest. So far I haven't noticed any problem.
Screenshots
Nothing new to see here, but I'm including examples of highlights without/with g:everforest_diagnostic_text_highlight to illustrate the PR:

@zennolux would you by any chance be able to test this branch with LSP Saga?

@antoineco
Great! It works!
Thank you for your work.


Make URL from extract_link safe and add missing scheme

Problem:
In some cases, the extract_link function returns links that are not fully valid or not entirely safe to use in requests.
Suggested fix:
There is an additional function that makes the link safe using the safe_url_string function, and also adds a scheme for cases where we have a link that looks valid but lacks a scheme and base URL. (e.g. //example.com)

Hi @wRAR please take a look at the suggested fix.

Hi @lopuhin , could you also take a look?

@kmike, @lopuhin  could you please take a look once again?


Change node to nodes in inference/search/__init__.py

This should fix #82 for the IC algorithm.

done!


Deploy MS-Sheduler into Firebase

https://www.youtube.com/watch?v=piGza_X9Gj4 - Refer this

Done - Deployed in Netlify


add swc tests cases

Some test cases (real world examples) have been removed because they require
too much memory.
Need to quickly check the json files.
@MatthiasEgli-chainsecurity FYI

Not much there, just added the corresponding test cases. I added some recursive argument in the test.py for convenience.


Rename CSHTML file reference.

### Summary of the changes
Rename the reference.  Since the referenced file isn't actually anywhere on disk and this is being used to measure the performance of the project razor json handling code in general, it doesn't need to match an actual file.

Fixes:
https://dev.azure.com/devdiv/DevDiv/_queries/edit/1826430

Was this PoliCheck? You know you can just close those as By Design or Won't Fix if the use is not in a sensetive context? 😛

edit: Ah, I see the details in the original issue now. Would CountryRegion still be flagged since it still contains the word Country?

According to the docs, that should be sufficient.


Row properties

Added options for setting height and cantSplit (keep_together)  for each row individually.
Tried to keep it similar to cell stilling, and to keep backward compatibility, setting those new values to defaults that should not change anything.
For backward compatibility, i created  table_rows that is a list of  TableRowModel, and changed rows to map table_rows to the old format of an matrix of cells. But, would be better find someway to make TableRowModel fully comparability with the old simple array row.
https://github.com/trade-informatics/caracal/issues/119 row height settings

The errors in CI test doesn't seen to be in nothing that i touched, and also completely pass in some versions, so i will not look what are causing those errors.


Fix syntax error of net.ipv6 configuration option

net.ipv6=true is not valid YAML syntax. This fixes it.

LGTM

Need this fix in stable

Could this be merged into master?

+1

Merged - Thanks!

Nice thx


Why master nodes are not defined as StatefulSet ?

I saw data node can be defined as StatefulSet, so when one of data node(POD) fails, then another Pod with same name will be created and to take over the same data volume, so the data and status is consistency.
But master & client node are defined as Deployment(ReplicaSets), if one of nodes fails, then another Pod will be created, however, the new Pod's name is not same as the failed one, and the attached data volume is different too (I cannot confirm).
So my question is how to keep the master nodes' data consistency when some of them failed in such architecture?

Master and client nodes do not store data and that's why they don't need data consistency.


MWPW-159032: Accessibility requirements for ratings comment field

Adds a floating label as accessibility requirements for comments field

Resolves: MWPW-159032
Test URLs:

Before: https://main--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?martech=off
After: https://mwpw-159032--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?milolibs=MWPW-159032-ratings--milo--joaquinrivero&martech=off

@joaquinrivero - I see the story is marked as done. Do we need the PR?


Dynamic response body

How can I set a dynamic response body? I have what's below right now but that's not my actual response.
#[utoipa::path(
    post,
    path = "/auth/signup",
    request_body = SignupBody,
    responses(
        (status = 200, description = "User created successfully", body = User),
        (status = 400, description = "Validation failed"),
    )
)]

This is:
{
  "success": true,
  "user": User
}

How can I do this without having to create a struct for each response in my project that supports success? I'd like to do something like this.
(status = 200, description = "User created successfully", body = json!({ "success": true, "user": User }))

Is this possible?

@Xenfo By the nature of utoipa being compile time what enforces users to know the type before it is being used naturally makes dynamic responses or types in general impossible. However there is a new feature coming up in next release that might come close for what you are looking for. You can find it here https://github.com/juhaku/utoipa/tree/master/examples/raw-json-actix.
The new feature allows use of "Any Type" within utoipa that basically can serialize to serde_json::Value. That means that dynamic response bodies can be used, but the type is basically unknown (all possible types are allowed).


[Long-term] Specialize wrapper functions for 0-sized closures

Very long term issue. Requires specialization to be stable and a way to specialize for functions and closures that don't borrow any environment.

In order to be a bit more specific, in Rust a closure is composed of two things: a function and an "environment". The environment contains all the local variables that were captured by the closures.
For example if you do let a = 5; move || a + 3 then the environment of the closure is the variable a.
In order to make this work, hlua asks lua to allocate some memory, copies the environment inside it, pushes the environment as a "hidden parameter" for the C callback, and when the C callback is called the environment is loaded and the closure is recreated.
However many closures and all freestanding functions don't have any environment at all. In this situation hlua still asks lua to allocate 0 byte of memory, pushes the hidden parameter, and when the C callback is called it asks lua to load the zero-sized data. This issue is about removing all these useless steps.

rust-lang/rust#39817 can possibly help here


spice-gtk: fix sound (gstreamer plugins)

propagatedBuildInputs is not the right way to propagate runtime dependencies. wrapGAppsHook makes sure that we have gstreamer environment set.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

cc @lassulus

Result of nixpkgs-review pr 266692 run on x86_64-linux 1

14 packages built:

appvm
gnome.gnome-boxes
incus
lxd
quickemu
remmina
spice-gtk
spice-gtk.dev
spice-gtk.devdoc
spice-gtk.man
virt-manager
virt-manager-qt
virt-manager.dist
virt-viewer


Add shaders to paint, extend with tile-modes

Generalizes our gradients to shaders
Makes all shaders sharable and immutable
Extends shader notion to images (i.e. patterns)
Extends gradients to also include sweep gradients
Extends shaders to have tile modes (defaulting to clamp today)

Obviously, part of the motivation for this refactor is making it easy to have new shader types:

sweep gradients
image patterns
tilemodes on shaders

Don't know the relative interest/priority for any of these from the Designer's POV


How to change Audio Sink Codec Configured to 48000 Hz

Hi everyone, I am programming an ARM Board that uses Petalinux to receive Audio from Phone and send that Audio A2DP to another Bluetooth speaker.
My problem is that the sound I get is an active sound with frequency 44100 Hz (capture) and the output (playback) is again 48000 Hz.
Is there a way for me to increase the Audio Sink Codec Configured to 48000 Hz. Because bluetooth speaker is fixed at 48000 Hz.
I found out bluealsa offers the option --a2dp-force-audio-cd to force capture und playblack devices to 44100. But I really want both ends to be 48000 Hz.
Is there a way to tune this frequency from the capture side to 48000 Hz.
Thank you.
Here is the result of bluealsa-aplay-l
bluealsa-aplay -l
bluealsa: D: ../../src/dbus.c:59: Called: org.bluealsa.Manager1.GetPCMs() on /org/bluealsa
**** List of PLAYBACK Bluetooth Devices ****
hci0: B9:76:59:02:C8:B5 [BT-WUZHI], trusted audio-card
A2DP (SBC): S16_LE 2 channels 48000 Hz
hci0: 9C:E6:5E:D5:DF:D8 [iPad của Minh Tung], trusted computer
SCO (CVSD): S16_LE 1 channel 8000 Hz
**** List of CAPTURE Bluetooth Devices ****
hci0: 9C:E6:5E:D5:DF:D8 [iPad của Minh Tung], trusted computer
A2DP (SBC): S16_LE 2 channels 44100 Hz
SCO (CVSD): S16_LE 1 channel 8000 Hz

Unfortunately, it's not possible to force Bluetooth audio to 48000 (also it's not possible to force to 44100). Bluetooth sink (receiving end) shall support both 48kHz and 44.1kHz in order to comply with the Bluetooth A2DP specification. The --a2dp-force-audio-cd option is not force but more like try to force in case where Bluetooth source supports both sampling frequencies (e.g. some Android phones support only 44.1kHz).
In order to resample audio from 44.1kHz to 48kHz you need another piece of software. When using ALSA, you can use standard ALSA plug plugin. For more information consult ALSA documentation.

r
Hi Arkq.
Thank you for this quick response. Now I can hear the sound very well using the command bluealsa-aplay-vv.

But I am trying to write a program in C++ to read and write Audio signal without using commands like bluealsa-aplay -vv. The goal is to combine with several other components in the project to complete a complete signal processing device. Currently I am using CYW20719 bluetooth chip and as far as I know it has support for both 44.1 kHz and 48 kHz frequencies. To avoid having to resample from 44.1 kHz to 48 kHz again via C++ application, I would like to ask for your help.
Is using alsa plugin type plug the only solution I have??

But I am trying to write a program in C++
Currently I am using CYW20719 bluetooth chip and as far as I know it has support for both 44.1 kHz and 48 kHz frequencies

If you're writing your own app, then I think there is no issue with writing/using resampling lib. Because, there is no way of avoiding resampling issue. Even though your chip supports 44.1kHz and 48kHz (I'm not sure what you mean by that, though), the sampling frequency is determined by source Bluetooth device. If the source does not support 48kHz you will end up with 44.1kHz no matter what.

OK so I get what you mean. my source bluetooth device is a phone and it seems to only support 44100 Hz. Thank you very much.


Initial User Defined Functions (UDFs) proto example. [WIP]

Initial Protocol definition for communicating with child processes.
Includes a working example in udf_example where the go code spawns the python server and communicates with it via STDIN and STDOUT.
The proto file here udf/udf.proto is the meat of this PR.
This example uses varint + protobuf encoded streams of data over the sockets to the process.
I decided not to use the RPC framework in proto3 since using it would require writing our own version of gRPC. More thoughts on the design are in the issue #72.

This is nearly done. Just need to:

[ ] Add docs for how to use UDFs, much of this already exists in udf.proto.
[ ] Add tests for the agent code. I want a utility that can test your custom written UDFS external to the Kapacitor process so you can iterate on them easily.


SD card Image for Rasberry pi boards

Can you please share an SD card image with everything preconfigured for easy and quick evaluation of the device.

Got the image from the web page - https://github.com/google-coral/edgetpu-platforms/releases

I added a prebuilt image for Raspberry Pi Zero:
https://github.com/google-coral/edgetpu-platforms/releases/download/v1.9.2/rpi0-raspbian-stretch-edgetpu-1.9.2.img.gz


New features

Added:

getRecommendations
getAvailableGenreSeeds
getUserTopArtists
getUserTopTracks
getTrackAudioFeatures
getTracksAudioFeatures

As outlined in https://developer.spotify.com/news-stories/2016/03/29/api-improvements-update/

Current coverage is 93.40%

Merging #43 into master will increase coverage by +0.46% as of 519f8a3

@@            master    #43   diff @@
=====================================
  Files            1      1
  Stmts          170    182    +12
  Branches         0      0
  Methods          0      0
=====================================
+ Hit            158    170    +12
  Partial          0      0
  Missed          12     12

Review entire Coverage Diff as of 519f8a3

Uncovered Suggestions

+3.30% via ...c/angular-spotify.js#525...530
+2.20% via ...c/angular-spotify.js#71...74
+1.10% via ...c/angular-spotify.js#518...519

Powered by Codecov. Updated on successful CI builds.

Coverage increased (+0.5%) to 93.407% when pulling 4bf28714f5a23c855d825cf04e1aa14d01bc518a on new-features into ebec56a78b2fec4da3ed9d93879bdd8bcc0dc516 on master.


Add support for microformats

Extruct ought to support microformats.

@cathalgarvey could you please clarify which microformats do you mean or link to a spec?

I am working on a pull request that adds https://github.com/microformats/mf2py for microformat extraction

Indeed, those microformats! Thanks Ludovica. :)
On 21 March 2018 21:56:47 GMT+00:00, Ludovica Gonella<EMAIL_ADDRESS>wrote:

I am working on a pull request that adds
https://github.com/microformats/mf2py for microformat extraction
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/scrapinghub/extruct/issues/64#issuecomment-375109223

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

closing because feature was implemented

Awesome, thanks Ludovica! I think this merits a version bump.. :)
On 28 March 2018 20:19:47 GMT+01:00, Ludovica Gonella<EMAIL_ADDRESS>wrote:

closing because feature was implemented
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/scrapinghub/extruct/issues/64#issuecomment-377004699

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

@cathalgarvey how can I do that? :)


Basic Visualisation

This PR will introduce visualisation of state machines and labels locations in them.
Note: this has been handy for debugging configs but low priority and will likely not be finished and merged before launch.
Todo:

[ ] Example visualisation that exercises all cases we want visible.
[ ] The above... as a test.
[ ] ~Visualisation of a label and its history and future.~
[ ] Improve the visuals so that it's a bit more understandable.
[ ] Add legend

@danpalmer were there any particular things you thought that the example visualisation should do? The example.yaml contains forks and merges in the graph, as well as both gates and actions, so I'm proposing that we build the example visualisation around that.

The main things I wanted to do were around readability. I remember it being pretty basic and not very clear. Destinations, triggers, defaults, etc would be good to get on there, maybe the field used to control the destination selection, etc.

@danpalmer since we discovered that pydot does indeed depend on having graphviz installed, thoughts on letting the render be in JavaScript? https://www.graphdracula.net/ looks fairly reasonable (and appears to allow annotations on various things which we know we want to do at some point)

Coverage decreased (-0.1%) to 99.857% when pulling ce5a5da6e0c9981068b9fec94d00cb156a4c597c on visualisation into 1cf3f69afdda7f7137383ab10fb828d8c7245c01 on master.


Saiga

@chujiezheng if you find this appropriate for the repository, I would like to add a chat template for the Saiga model (which is a Russian model based on LLama-2 or Mistral).
The dialogue consists of messages, and each message is built the following way:
<s>{role}\n{content}</s>

There are three possible roles: system, user, and bot.
An improvised dialogue example (text is in English for illustration purposes):
<s>system
You are Saiga, the Russian—speaking automatic assistant. You talk to people and help them.
</s><s>user
Why is the grass green?</s><s>bot
It just so happened</s>

Hi, I am willing to merge it. I believe it is valuable for Russian users. Thanks for your contribution!

@chujiezheng thank you! :slightly_smiling_face:


3.4.4rc1 fails to install

The following fails;
$ pyenv install 3.4.4rc1
Downloading Python-3.4.4rc1.tgz...
-> https://www.python.org/ftp/python/3.4.4/Python-3.4.4rc1.tgz
/home/vagrant/.pyenv/plugins/python-build/bin/python-build: line 223: pushd: Python-3.4.4: No such file or directory

BUILD FAILED (Ubuntu 14.04 using python-build 20151222-7-g4c06f23)

Inspect or clean up the working tree at /tmp/python-build.20151231160648.28021
Results logged to /tmp/python-build.20151231160648.28021.log

Last 10 log lines:
/tmp/python-build.20151231160648.28021 ~

Looks like it's not detecting rc1 on the end of the filename, instead going for Python-3.4.4.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29506618-3-4-4rc1-fails-to-install?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github).

CPython 3.4.4 has already been released and 3.4.4rc1 is obsolete now. I'll just remove it instead of fixing. Thanks for reporting anyway
https://www.python.org/download/releases/3.4.4/

CPython 3.4.4 has already been released and 3.4.4rc1 is obsolete now. I'll just remove it instead of fixing. Thanks for reporting anyway
https://www.python.org/download/releases/3.4.4/

Ah great stuff, thank you!

Ah great stuff, thank you!


SkillAPI Module not working

I use Quests 4.13 and ProSkillAPI lastest
i tried with SkillAPI Pre but it not working too

Reach out to the developer of the module.


Added error 404 page component

Description
Created 404 Error Page Component
Fixes # (issue)
#23
How to test?
npm run storybook
Checklist

[x] I have performed a self-review of my own code
[ ] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] This PR is ready to be merged and not breaking any other functionality

looks nice @sandhana14 👍


Request to Assign Autocomment PR Request File

I am interested in implementing an autocomment feature for newly raised pull requests in the repository.
This feature will automatically provide contributors with information and guidelines for submitting pull requests, enhancing the contribution process.
Assigning me this task under gssoc24 would be highly appreciated, and I am excited to contribute to the project in this manner.

please assign me this issue to me under gssoc 24
i will complete it very soon


Cut setting file

Create .json files containing cuts and their implementation, e.g.:
{     "tag":"Proton",     "monitor":true,     "rapidity":{         "less_than":0.3,         "more than":1.4     },     "pid":{         "equal":2212     } }
This would need an implementation of the comparison semantics. One would need to somehow tell the program which options are known, and, best yet, tell the user which can be used (e.g. store key-values in some enum/class and later generate .txt file for the user to look at).
Problem: how to treat pid? force users to choose only one or make it possible to choose multiple? Give the option to select unwanted PID instead.
Problem: The option for the monitor is currently optional IMO, would be nice, but implementation could be possible with only 1D histograms unless we make explicit options in the code, such as: If rapidity and pT are present in the cut settings file, make 2D histogram instead

It would be necessary somehow to convert the .json semantics into a C++ object so that it exists through the whole scope of particle selection to avoid a colossal speed decrease in the program.

New idea: if I change the structure of EventCandidate, TrackCandidate, and PairCandidate such that they use a map for all the observables (which also adds the flexibility to add more later or add only those which are needed), all my problems are solved immediately.

Read selection.json
Check it against the known values in cutMapping.json
Create a map of relation operators, e.g. now only "inside", "outside", and "equal"
Pass the accepted cuts into a new map
Compare observables to their cuts, same as currently:

Loop over observable names
Compare keys according to the relation.
Return bool

Proceed as before

The only obstacle now is: I need map which accepts various data types. Some ideas are here: https://stackoverflow.com/questions/24702235/c-stdmap-holding-any-type-of-value

I need to think how the selection.json file should be structured. I think I need to utilise the conversion from json format to structure. It means that the form of the structure will determine the format of .json. One has to keep in mind that the struct has to be flexible enough to work with the rest of the code.


No Cache is stored because nothing has been found

Im getting to following messages during the POST step.
I'm using version 1.10
Save gradle-generated-jars   gradle-generated-jars: no files to cache => won't upload empty cache Save dependencies-gradle   dependencies-gradle: creating single-layer cache image   dependencies-gradle: no files to cache => won't upload empty cache Save dependencies-maven   dependencies-maven: creating single-layer cache image   dependencies-maven: no files to cache => won't upload empty cache

I'm having the same issue, @eye2web do you find a way to solve it?
I'm using the action like this:
      - uses: burrunan/gradle-cache-action@v1
        name: Test Coverage
        with:
          read-only: false
          arguments: :project:unitTestCoverageVerificationDebug
          concurrent: false
          gradle-build-scan-report: false

@mcarrillowz  would you share the link to the actions log?

@mcarrillowz would you share the link to the actions log?

The repo is private, but let me know what you want to see and I can share it

@vlsi It seems that I found the issue. I'm running the action within a container using the root user and the gradle cache goes to /root/.gradle/caches, but the action uses ~/.gradle/caches and ~ is resolved as /github/home/
Any plans to use an input to specify the .gradle path?
Reference: https://github.community/t/how-to-use-the-github-cache-action-in-a-containerized-workflow/219514/3

@mcarrillowz , thank you for the analysis. I'll fix it tomorrow


4/show user avatar

This PR

replaces the user data json with a UserData model in the SDK

and in the demo

show the avatar (or default avatar) after sign-in (fixes #4)
fixes crash on restart (you can now press home and restart the demo with immediate signin using the previous authResponse without verifcation)
fixes scrolling
renames demo app

(without username)

(with username)

This works well for me @friedger ! I moved the did and avatar image into properties: https://github.com/blockstack/blockstack-android/commit/f266638f8109e57615cb9e61d36af266cfc55817 Thank you!


R interface uses stringr CRAN package which is GPL-2 licensed, incompatible with Apache 2.0

Probably the most viable fix would be using stringi package functions instead of the wrappers in stringr.
https://github.com/dmlc/xgboost/blob/master/R-package/NAMESPACE
https://cran.r-project.org/web/packages/stringr/index.html
http://www.apache.org/licenses/GPL-compatibility.html

cc @hetong007

Hi @rbalint, there is a vote in https://github.com/dmlc/xgboost/issues/1338 about the licensing issue.
It is because ggplot2, knitr, data.table are also GPL, and the cost to keep xgboost from them is high.

as a correction, only ggplot2 and ```stringr`` will become problem

I have checked a legal books about GPL (unfortunately it s in French: Droit des logiciels - édition Puf - F Pellegrini et S. Canevet) and basically, to avoid contamination of a project with GPL2 licence, you need to wrap the GPL2 code and access to it through a generic interface.
This interface should make it possible to use code from other projects with similar functionalities than the GPL code. One interesting point is that to make it work, another project with similar function but under another licence should exist.
The implementation of the other project has not to be written, but just be easily possible. The idea is that it should be easy to replace the code under GPL with another one because of the interface (like a lego block).
The approach is inspired of how to limit GPL2 contamination because of the Linux kernel executing some non GPL code.
In general, my opinion is to limit the consequences of GPL code to the final user.
For instance, forcing the user to install another package to get some functions just for legal reasons is really an overkill. And letting the GPL licence contamining the whole project and making it impossible to use for some startup seems not Ok at all.
If you have any question, please don't hesitate.
Kind regards,
Michaël

stringr is not used anymore.
https://github.com/dmlc/xgboost/pull/1401
I close the issue.


Determine structure/setup of database(s)

As mentioned, I'm unsure whether, moving forward, it would be more productive to have just one database being referenced or two: one for authentication and one for website reference. I'd appreciate any insight or information as I explore this further.

Close as database has been created with MySQL


Does BYOL work without sync_batchnorm?

Hi! I wanted to ask authors of BYOL code questions, which is more of a discussion.
I can see that you didn't use sync_batchnorm in Trainer when implementing BYOL. Per my understanding of this methods, calculating statistics over all GPUs/TPUs should be crucial for this algorithm to work well. Is this a conscious decision on your side?
I'm sorry I can't prove my hypothesis with some experimental results, but wanted to quickly check if you've considered this before running the whole training.
Thank you very much for great code!

@ananyahjha93 any update here?

We are deprecating the self-supervised learning paper implementations in bolts and instead provided a VISSL integration in PyTorch Lightning Flash which can be used to train models using self-supervised learning algorithms. You can refer to the documentation here.


Invalidate (outdate) data

After running some commands like continue or start, the data will be outdate. This include registers and RAM memory data.

Related to #13 and #10


New Language Proposal: Nim

Add support for nim language https://nim-lang.org for creating its data types

We'll accept PRs for new languages, but open issues about them does not help so we'll close this for now. Thank you.


added modal-component

This PR resolves #103
Added a reusable onClick model-component which is previously not present in website builder.It is highly customizable.
The Button Text,Modal Heading,Modal Body,Modal Buttons can be modified using props like this :-

The Modal Component Initially:-

Modal component when we click on button:-

Please review this @charithccmc @wdevon99 and suggest changes if any.


ARROW-16499: [Release][Ruby] Add missing export

We need to export GEM_HOST_OTP_CODE so that "gem push" can use it.

+1


Bot is replying to comments even if it's disabled

Bot is still replying to comments after this is set.
  "reddit_reply_to_comment": False,
Also is would be sane default to not reply to mod, because most of bots are mods.

Looking at this
you have to change the config to  "reddit_reply_to_comment": 0, to disable replying to comments.

yeah it needs to be set to 0 as @igosad shared. the not replying to a mod is a nice idea. I will consider it for the future if I have some time to work on this


ci: add web releases workflow

closes https://github.com/mandiant/capa/issues/2364
example run
Checklist

[ ] No CHANGELOG update needed

[x] No new tests needed

[ ] No documentation update needed

Looks great, let's think a bit about the CHANGELOG and if we want to report/auto log any additional information (release date/time, SHA256, etc.).

@mr-tz I think that's good idea. Check example runs here.


Changed Web View2 Get Started Winforms

Per work item 33982430

Docs Build status updates of commit 76229c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/get-started/media/winforms-designer-txtbtn.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-designer.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-empty-app.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-install-webview2-preview.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-new-project.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-opening-panel.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-properties.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-source.png
:white_check_mark:Succeeded

microsoft-edge/webview2/get-started/media/winforms-toolbox.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/wpf-getting-started-mng-nuget.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/winforms.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit be3b26b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/get-started/media/winforms-designer-txtbtn.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-designer.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-empty-app.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-install-webview2-preview.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-new-project.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-opening-panel.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-properties.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-source.png
:white_check_mark:Succeeded

microsoft-edge/webview2/get-started/media/winforms-toolbox.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/wpf-getting-started-mng-nuget.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/winforms.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9195997:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/get-started/media/winforms-designer-txtbtn.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-designer.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-empty-app.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-install-webview2-preview.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-new-project.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-opening-panel.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-properties.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-source.png
:white_check_mark:Succeeded

microsoft-edge/webview2/get-started/media/winforms-toolbox.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/wpf-getting-started-mng-nuget.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/winforms.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 469efc1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/get-started/media/winforms-designer-txtbtn.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-designer.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-empty-app.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-install-webview2-preview.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-new-project.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-opening-panel.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-properties.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/winforms-source.png
:white_check_mark:Succeeded

microsoft-edge/webview2/get-started/media/winforms-toolbox.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/media/wpf-getting-started-mng-nuget.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/get-started/winforms.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Get.snackbar, adding styling and properties to the Text.

Hi
i was playing/experimenting with Get.snackbar, and i noticed that i couldn't center the text message of the snack bar which is always aligned on the left, also i couldn't change the text message styling.
i really like the Get.snackbar because it doesn't need a context, and I'd like to see these features being added.
Thank you.

Hi, there are already these options, please follow this issue:
https://github.com/jonataslaw/getx/issues/410

Thank you


converge all pointer types

Better solution to #97.
Launchpad to add volatile pointers.

Sorry, I didn't look at this merge request before merging #97. Can you say more about this pull request? A cursory look seems like it is more complex. You mention adding volatile pointers. Is the idea to make this generalization, allowing you to add volatile pointers on top of the framework?

The first reason is adding volatile pointers and a couple of safe cast functions. I'm working with C code with const and volatile pointers a lot, and currently just ignore GCC warnings about volatile-discarding casts. But I want to write more safe code.
The second reason is writing constancy-polymorphic or nullability-polymorphic code. For example, search in a tree of pointers must return nullable pointer (null if nothing found), but the constancy of the result must be taken from the source constancy. Also we need type families and type classes to convert pointers to const and mutable and to nullable and non-nullable. (I have some in our company's private repo.)
I think one 3-parameter type is better than 8 distinct types with many type classes around.

Ok, I see. That makes sense. It looks like all this will be behind the Ivory interface, so for pointers as they exist today, the API change won't matter, correct?

Sorry, that wasn't clear. I mean, there won't be a change to the API, correct?

This patch must extend API only, but I didn't updated Ivory.Language export list. Also, I've added a few TODOs to deprecate and remove obsolete parts.

updated patch

Ok, give me a few days. I'd like to review this @elliottt .

sure

@leepike, @elliottt, any thoughts?

Sorry! It's been a busy couple of weeks. I think this is the right idea. Give me until next week. Sorry for the delay. :/

Ok, sorry again for the delay. Looks great! I may add some light comments.