Overall review: bug fixes, unit tests, new sources, stock publication.

Hello @xeroc ,
sorry for this massive pull request, it's not in my habits, but I feel like it will be more efficient like this.
However, I have reported most of the issues seperately.
My initial goal was to implement stock price publication (#54), but when I saw #35 and @clockworkgr 's comment, I thought it needs a global review.
This pull request solve most of the currently open issues.
Here is the detailed content:
New feature:

Add unit tests (fix #39)
Add ability to publish Stock prices. (fix #54)
Add Binance source
Add WorldCoinIndex source
Add BitsharesFeed source (to retrieve the current MPA feed)

Bug fix:

Fix error when asset has no specific cer defined (fix #27).
Update default configuration for CNY CER value (fix #28)
Clean config (fix #31)
Fix volume bug (fix #34).
Fix Asset with type formula (fix #37, #38)
Add unit tests #39 (fix #39)
Remove closed exchanges (fix #40)
Remove Yahoo finance (fix #41)
Fix source Bitcoin Venezuela. (fix #42)
Fix ALTCAP.X computation in Coincap source. (fix #45)
Coinmarketcap: If multiple quotes are provided only the last one is returned. (fix #46)
Coinmarketcap: ALTCAP and ALTCAP.X are computed but ignored. (fix #47)
Fix Fixer source: upgrade to new API. (fix #49)
Fix Graphene source: If multiple quotes are provided only the last one is returned. (fix #50)
Quandl: Quote inconsistency between Quandl and QuandlPlain. (fix #52)
Wrong prices displayed on summary for formula assets (fix #55)

Se the status of all the sources: https://github.com/Zapata/bitshares-pricefeed#sources
Any feedback/review welcome!

Is "BitsharesFeed source" similar to what I've done with the SettleGraphene source?
Overall, I think that the extern/intern/formula stuff is added complexity for no reason.
E.g. My way of calculating Hero is a Hero source that provides Hero/USD through a formula.
And when I request a feed for Hero, I add that source and the USD/BTS from SettleGraphene (which returns current settlement price for USD) only. Thus I only get 1 price which is the correct one.
This allows a simpler way of adding algorithmic feeds (by copying a source template and replacing a calculation) and keeps the pricefeed code cleaner and simpler. Part of the cleanup I want to do is keep only extern from now on.

Hi I agree with using the same login for price computation. But I believe HERO price was designed to specifically use the bitUSD settlement price now? Hence why I'm only using that SettleGraphene source for hero rather than the "generic" USD/BTS price reached.
Same goes for Hertz I think

Excellent work. If you may improve on the comments I made, I am fine merging this in.

Excellent piece of work. Thank you for your contribution!


Player model invisible when emoting

Whenever I use an emote, my player model is invisible. It loads for a split second, then disappears. None of the people I play with are having this issue, so it could have something to do with my hardware? Maybe?

I read through the forum a bit and saw some people talking about some things not working if you have a controller plugged in. I decided to try unplugging it and it worked.


Info State - new pattern

related to empty state.
Might help drive #274 in the future.

@danethurber @jaketrent  Here is a link to design specs and docs page. Some of the illustration set assets are still outstanding, but the docs page copy and everything else is ready to go.
https://www.figma.com/file/G7IDalBuCq6llvVlwYpaEBGR/Info-states?node-id=0%3A1


podcast feature request 博客功能請求

希望能支持視頻網站的audio only RSS export
in distances,
Bilibili
YouTube
or
Youku
應用範圍希望是podcasts application
audio only希望是減少data usage

唔...這個擴展并不能直接生成RSS源，只是可以查找相對應的RSS源
想問一下你提到的這些視頻網站本身有audio only RSS export嗎
如果有的話可以麻煩給一個link嗎？感謝！
有的話我可以添加進來

Ya, got it but only for YouTube.
In distance,
To a user or channel,
Fill in their user ID or channel ID at star place
http://youcast.cloudapp.net:80/FeedService/GetUserFeed?userId=***&encoding=Audio&maxLength=0&isPopular=False
To a playlist on YouTube,
Make it same way as well
http://youcast.cloudapp.net:80/FeedService/GetPlaylistFeed?playlistId=***&encoding=Audio&maxLength=0&isPopular=False
To be noticed,
This project is done by youcast on github
In which maintained by a Microsoft DEV

From: 不蠢会死的某翠<EMAIL_ADDRESS>Sent: Tuesday, April 30, 2019 8:58:23 PM
To: idealclover/Easy-to-RSS
Cc: Kaijian Lawrence Law; Author
Subject: Re: [idealclover/Easy-to-RSS] podcast feature request 博客功能求 (#14)
唔...@U展并不能直接生成RSS源，只是可以查找相RSS源
想一下你提到的@些lW站本身有audio only RSS export
如果有的可以麻┙o一link幔扛兄x！
有的我可以添加M
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/idealclover/Easy-to-RSS/issues/14#issuecomment-487941850, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADJXGGWIW66EJMKVQI22RVLPTA667ANCNFSM4HIZSVIQ.


[BUG REPORT] [Linux, macOS] Administration privileges required for any commands

Bug report
Expected vs actual behavior
We should ask administration privileges only for commands requiring core calls
Steps to reproduce
Screenshots (if relevant)

Additional information

Fixed


fix(tap-agent): execute rav requests until fees equals zero

Closes #171

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

6 of 25 (24.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 68.574%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tap-agent/src/agent/sender_allocation.rs
6
25
24.0%

Files with Coverage Reduction
New Missed Lines
%

tap-agent/src/agent/sender_allocation.rs
1
82.58%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
3751

Relevant Lines:
5470

💛  - Coveralls


issues about kafka

The deployment project is bound to kafka, do I need to set the kafka group separately?

Hi, @xyjwsj. This is an incomplete report. It is unclear what you're attempting to do; we won't be able to help with limited information. See the "Reporting Issues" wiki for the guideline.
Likewise, we would appreciate if you can also clarify the problem in spring-cloud/spring-cloud-dataflow-server-kubernetes#311 as well.

closing due to inactivity


Add ability to rate an area to recommend pick locations

Add ability for signed in user to tag a location on a map and rate how dirty / clean the location is to help people find areas near them that needs cleaning

This is a future feature and needs to have design work done on it before implementing.... database schema is needed, expiry times (like a report expires after 2 months if not renewed). Should be done in concert with Decay maps.


Enable Public API labs flag by default

Casper 2.0 has some features which depend on the {{#get}} helper, which needs the Public API flag to be enabled in order to work. I think it might make sense for 1.0 to take the next step of moving the Public API flag to being checked-by-default in /ghost/settings/labs/ ?
A secondary issue to this is that it would be really good to rename the file which is injected into {{ghost_head}} - currently ghost-url.js to something that makes a bit more sense, like ghost-api.js or ghost-sdk.js.
However the latte issue may be better suited to post-1.0?

[x] enable public api access by default
[x] rename ghost-url.js -> raise a new issue for post 1.0.0

Hannah on Slack:

facebook uses sdk.js - medium uses medium-sdk

So ghost-sdk.js sounds like a winner

It would be good (IMO) if this file was included by default in {{ghost_head}}. Quite a few themes use it in the back end but don't use it on the front end at all and it just ends up being another file for the browser to download and not end up using.

@jloh Hey 🙃 Thanks for your feedback.
Could you please move your comment to #8605?
Thank you!

I ran into an issue today with a use case that wasn't covered by my initial implementation of this.
If you import from LTS, and didn't already have the public API enabled, it will be disabled after import.
The desired behaviour is that the Public API flag be enabled in 1.0.0 unless a user manually disables it.


3d model Import bug

3d model Import bug
Hi,
Just found out that no matter if its boned or vertex animation on the fbx, if after you import an animated model, you delete the material it creates when imported, and assign another one, properly setting the checkbox in either skinning or morph targets on the material properties, No animation is displayed anymore, neither in the animation tab or when running the project. Right now the working workaround is assign proper resource texture to created material on import, but this should not be happening, that's why I reported it anyways.
version 0.95 desktop
Platform Windows 10

Hi
I will have to take a look at this, do you have some fbx test file that i can use?
Thanks a lot.

Hello
This bug has been fixed in the last version of the editor.
Thanks  a lot for reporting

great!


XCopy over Web Deploy (MSDeploy) for publishing to IIS?

I'm surprised you went the direction you did with Publishing to IIS. Isn't XCopy going to be crazy slow because it's going to copy all of the files to the server every publish? Is that correct? That's what I read about it.

I use robocopy and my assumption was so would most folks. Historically MS has written XCopy as brute force approach and most folks seem to know to use robocopy.


Move build system to use pyproject.toml

Signed-off-by: Alan Chin<EMAIL_ADDRESS>
removed MANIFEST.in, setup.cfg, pytest.ini
use hatch engine instead of setuptools
moved labextension output directory due to hatch requirements (will not allow artifacts in dist dir to be placed in sdist)

TODO:

[x] update release script
[x] verify tests still function
[x] address codeql issues
- [ ] setup build hooks for lab extensions (stretch)

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC - the primary changes from #3032 are not present here. I suspect this is because you had started this work prior to the merge of 3032 and since this PR removes pytest.ini and 3032 added a bunch of entries to it, the file's deletion takes precedence over content-reconciliation. As a result, the entries in 3032 (and any other recently merged PRs that might have modified files deleted in this PR) should have those changes added to their new locations in pyproject.toml.

Thanks, I was totally rushing and missed that during the rebase

From a front end build perspective this look good, I also tested the dev on local lab functionality and it works with these changes, but this doc will need to be updated since the location of some of the lines that need to be edited has changed https://elyra.readthedocs.io/en/latest/developer_guide/development-workflow.html#developing-elyra-against-the-jupyterlab-source-repo

@kevin-bates - if you're still lurking around.
Had to cap a few items in the last commit in this PR before merging

Cap on jupyter-core due to v5+ not supporting 3.7. (temp until we stop as well)
Cap on jupyter events due to kfp not supporting jsonschema v4
Cap on jupyter_server_terminals due to >0.4.0 causing issues with installation. See output below. I dont think we actually need this yet since it looks like its a dependency for jupyter_server v2. Unfortunately I think its getting pulled in during dependency resolution.

Will open issue to track if this is an ok workaround.
$ jupyter server extension list

Config dir: /Users/akchin/.jupyter

/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server_terminals/__init__.py:8: UserWarning: Could not import submodules
  warnings.warn("Could not import submodules")
Traceback (most recent call last):
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/manager.py", line 320, in add_extension
    extpkg = ExtensionPackage(name=extension_name, enabled=enabled)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/manager.py", line 166, in __init__
    super().__init__(*args, **kwargs)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/traitlets.py", line 1357, in __init__
    value = self._traits[key]._cross_validate(self, getattr(self, key))
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/traitlets.py", line 743, in _cross_validate
    value = obj._trait_validators[self.name](obj, proposal)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/traitlets.py", line 1229, in __call__
    return self.func(*args, **kwargs)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/manager.py", line 175, in _validate_name
    self._module, self._metadata = get_metadata(name)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/utils.py", line 58, in get_metadata
    return module, module._jupyter_server_extension_points()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server_terminals/__init__.py", line 15, in _jupyter_server_extension_points
    "app": TerminalsExtensionApp,
NameError: name 'TerminalsExtensionApp' is not defined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/akchin/opt/anaconda3/envs/remove/bin/jupyter-server", line 8, in <module>
    sys.exit(main())
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_core/application.py", line 269, in launch_instance
    return super().launch_instance(argv=argv, **kwargs)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/config/application.py", line 992, in launch_instance
    app.start()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/serverapp.py", line 2814, in start
    self.start_app()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/serverapp.py", line 2710, in start_app
    super().start()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_core/application.py", line 258, in start
    self.subapp.start()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/serverextension.py", line 368, in start
    super().start()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_core/application.py", line 258, in start
    self.subapp.start()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/serverextension.py", line 342, in start
    self.list_server_extensions()
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/serverextension.py", line 323, in list_server_extensions
    config_dir, ext_manager = _get_extmanager_for_context(**option)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/serverextension.py", line 59, in _get_extmanager_for_context
    extension_manager = ExtensionManager(
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/config/configurable.py", line 86, in __init__
    super().__init__(**kwargs)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/traitlets.py", line 1364, in __init__
    self.notify_change(changes[key])
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/traitlets.py", line 1513, in notify_change
    return self._notify_observers(change)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/traitlets/traitlets.py", line 1560, in _notify_observers
    c(event)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/manager.py", line 253, in _config_manager_changed
    self._load_config_manager(change.new)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/manager.py", line 308, in _load_config_manager
    self.from_jpserver_extensions(jpserver_extensions)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/manager.py", line 313, in from_jpserver_extensions
    self.add_extension(name, enabled=enabled)
  File "/Users/akchin/opt/anaconda3/envs/remove/lib/python3.9/site-packages/jupyter_server/extension/manager.py", line 325, in add_extension
    if self.serverapp.reraise_server_extension_failures:
AttributeError: 'NoneType' object has no attribute 'reraise_server_extension_failures'
make: *** [check-install] Error 1

Thanks for moving forward with this PR in my absence.

The jupyter_server_terminals issue looks like a server-related issue.  I can try to look into this upon my return, not a big deal to cap that for now.
The jupyter_events cap due (indirectly) to kfp is concerning.  This will prevent others from using Elyra alongside event-related functionality (not a big deal right now) and we may very well want to use the event system ourselves as well.  We should probably create an issue to revisit the jsonschema cap and how kfp v1 and jupyter_events can co-exist.
The introduction of write_error() calling the mixin's write_error() strikes me as unnecessary - and I thought I left had left a comment to this affect, but either it was blown away by a forced push or I forgot to save it.  Was the need for this triggered by a linting issue?  The Mixin's write_error() implementation should resolve and prevent the need for the override.

The jupyter_server_terminals issue looks like a server-related issue.  I can try to look into this upon my return, not a big deal to cap that for now.

@kevin-bates - Sorry for bothering you on vacation. Yeah this package is causing some headaches atm. pips resolver continues to pull in jupyter_server >2, thus pulling in this package causing issues. Capping the issue still doesnt resolve the issue, as a result terminals are not working in the latest 3.14 release. Need a way avoid pulling jupyter_server >2 completely. I have tried capping it but the resolver still pulls in jupyter_server > 2......then.....resolves and installs the capped version...leaving the problematic dependency in place.


Multiple scalability improvements to controller

Switch to using SharedIndexInformer to provide shared resource
state with other controllers.
Use workqueue in lieue of channels which prevents work backlog,
stale state, true concurrency, and enable future improvements
such as rate limited retry and backoff.
Add ability to PATCH workflows to prevent errors related to having
too old resource versions.
Pod updates no longer result in an 1:1 workflow update and instead
adds the workflow name back to the workqueue. This allow database
updates to be batched in a single db update.

My latest change addresses the issue of pods becoming deleted from underneath the controller, among other things. It accomplishes this by honoring a deadline for workflow operations. If the operate exceeds the deadline (currently 10s), it saves whatever work it already did, and requeues itself back to the workqueue. This has several key benefits:

progress for workflows with very long pod submission will now be visible to the end user
relinquishing control prevents starvation of other workqueue items.
requeuing the workflow allows pod reconciliation to take place at regular intervals. pod reconciliation enables the controller to see when pods complete much quicker, and reduces the chance that a pod can become deleted without the controller handling the event.


Remove Test.Case's conformance to Identifiable.

With further consideration after #548, we've decided to remove conformance to Identifiable from Test.Case rather than promoting it to API. The identity of a test case is fuzzy because it depends on the arguments to a test, not all of which may be uniquely identifiable. We need more time to consider the design of this part of the interface before making it a permanent part of our API.
Checklist:

[ ] Code and documentation should follow the style of the Style Guide.
[ ] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


Create feature flag methods

Copy of https://github.com/PostHog/posthog-java/pull/42 with maven push permissions

Thanks for all your work @batosti - I'll merge this, but the commits should still be attributed to you since I haven't rebased.


Release Camunda Platform Helm Chart v9.3.5

Before opening the PR:

[x] Run make release.chores
[x] Create a PR with the printed URL
[x] Trigger Renovate to ensure that all deps are updated (to avoid any delayed sync from Renovate service).

After opening the PR:

[ ] Take a final look at the release commits (version bump and release notes)
[ ] Make sure that all checks in the PR passed
[ ] If everything in place, add release label to the PR
[ ] Follow up the release workflow and make sure it succeeded (double-check the releases page)
[ ] Ensure that all fixed issues with support label has the release version like version:10.0.0 (this will be automated later).

If the release is a minor version bump (e.g. from 8.2.x to 8.3.0):

[ ] Make sure the regression test matrix is updated: located at .github/workflows/test-regression.yaml

I expect the Chart upgrade tests to fail due to the upgrade tests taking the latest released helm chart and downgrading to the 9.3.5 version
https://github.com/camunda/camunda-platform-helm/issues/1585


heatmap_mutation_frequency_bin lost rotation of the column title

The heatmap_mutation_frequency_bin used to plot the column titles with rotation 90. But this feature was lost at some point. See this parameter:
https://github.com/morinlab/GAMBLR.viz/blob/6563146016f1231d39356ad4d4ecbbd7185207f9/R/heatmap_mutation_frequency_bin.R#L347
The default setting in the earlier versions of this function were set to 90, so the gene names do not overlap when single regions are plotted. Probably, this was changed intentionally because it was making some version of the resulting plot better. So why don't we convert this to a user-configurable argument that can be dynamically set based on user's needs. The default can be 0 to respect current behaviour.

Fixed in #44


Missing ability to secure sentinel?

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 5.5.10
Distribution: CentOS 7.6.1810
Module version: 4.0
Redis: >= 5.0.1

How to reproduce (e.g Puppet code you use)
I mean  I don't have code but currently you can't configure the sentinel instances to requirepass to improve security in multi server redis instances managed by sentinel.
What are you seeing
No security
What behaviour did you expect instead
security via requirepass at the sentinel level
Output log
Any additional information you'd like to impart

The documentation could certainly be better, but I think this is already possible.
You can set auth_path  and that will configure sentinel correctly.
The server also has the required parameters. See https://github.com/voxpupuli/puppet-redis/blob/5464b335f9bd05fc0dd412bdd9dad97d4539a1f6/manifests/init.pp#L208 https://github.com/voxpupuli/puppet-redis/blob/5464b335f9bd05fc0dd412bdd9dad97d4539a1f6/manifests/init.pp#L185
Hope this helps.
PRs that improve documentation always appreciated :)

This would (and correct me if I'm wrong) only enable sentinel to talk to a secure redis installation, not secure the communication between sentinel instances.
https://redis.io/topics/sentinel#configuring-sentinel-instances-with-authentication
This was added in Redis 5.0.1, so it's rather new.

@ragingdave Ah, ok. I didn’t know about that. Thanks for the link. Would you be able to create a PR to add the functionality?

maybe.... I will see if I can tomorrow-nextweek-ish to put one through


RPC AddNode, GetAddedNodeInfo, BackupWallet and EstimatePriority

@NicolasDorier, I'm sending the PR for review and discussion.

This is a good idea, but should have the async versions too.
Also, the IpEndpoint class is not portable. For RestClient, I only used #if !NOSOCKET to disable any code coupled with IpEndpoint. But it sucks to delete code, just because IpEndpoint is not available in portable library. I'm not sure about the best way to handle this problem.
I can't test for now, my node is indexing transactions :-S

In the latest commit I moved code for grouping it in code regions. I did it to have a better idea about the  implemented and missing RPC methods. I know this makes the review harder but on the other hand the code is easier to find and work with.

Can you wrap return GetAddedNodeInfoAsync(detailed).Result; correctly so we get back a real exception and not a generic aggregate exception ? I did it several time in RPCClient, and RestClient you should find an example.

@NicolasDorier, this PR is done since yesterday. Could you review it?

trait should be [Trait("RPCClient", "RPCClient")], I am using it for my build server.
Some .Result are still not wrapped (EstimatePriority)

Done.

last nit, you use %temp% in the test, can you just use the relative path (which will resolve to the output dir of the test project) ?

Sure, no problem. It is an important point.


Not stable for SetRGB/temperature/brightness

adjust the temperature & brightness many times,  it will shows the error info "UnhandlePromiseRejectionWarning: Unhandled promise rejection (rejection id: xx) [object object]"
In addition, cannot right set correct color with "colour picker" node for SetRGB

Thanks for report. Will dig into it  next week.

Hi. There is critical issue for yeelight IP address. For example, the yeelight connect AP and assigned <IP_ADDRESS>, we can command yeelight. But the network is shutdown or AP is shutdown, the node-red will crash. I think the code should add exception function to handle the network issue.
BR,
Chris

Could you try the latest version?

Dears,
I will try the latest version. Also find the node-red crash issue that is yeelight is offline or AP is shutdown. For example, the yeelight assigned by AP is <IP_ADDRESS>, when AP shutdown or yeelight offline, the node-red crash and cannot running. I believe maybe should add exception handle the issue.
Best Regards,
Chris
发件人: Alexander Sorokin<EMAIL_ADDRESS>发送时间: 2017年12月4日 15:23
收件人: Gromina/node-red-contrib-yeelight<EMAIL_ADDRESS>抄送: Chris Tang<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>主题: Re: [Gromina/node-red-contrib-yeelight] Not stable for SetRGB/temperature/brightness (#1)
Could you try the latest version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGromina%2Fnode-red-contrib-yeelight%2Fissues%2F1%23issuecomment-348879938&data=02|01|chris.jj.tang%40jci.com|2885baf10cfb49b6404208d53ae7e753|a1f1e2147ded45b681a19e8ae3459641|0|0|636479690052311798&sdata=hxdg7ZandjFJvZIBvPDidxWEeA%2FC6YNdZbdEzhozKzg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAe4iDXizjzGbLrnJdgl3-0of6yMV29p_ks5s853qgaJpZM4PoRol&data=02|01|chris.jj.tang%40jci.com|2885baf10cfb49b6404208d53ae7e753|a1f1e2147ded45b681a19e8ae3459641|0|0|636479690052311798&sdata=jWToaGflxpyGpixKMpikM9fhQ4%2FPxR7qixScnfFdxHI%3D&reserved=0.

Dears,
I test it by latest version but crash issue still exist. Attach crash graphic for reference.
<EMAIL_ADDRESS>Best Regards,
Chris
发件人: Chris Tang
发送时间: 2017年12月4日 17:08
收件人: 'Gromina/node-red-contrib-yeelight'<EMAIL_ADDRESS>Gromina/node-red-contrib-yeelight<EMAIL_ADDRESS>抄送: Author<EMAIL_ADDRESS>主题: 答复: [Gromina/node-red-contrib-yeelight] Not stable for SetRGB/temperature/brightness (#1)
Dears,
I will try the latest version. Also find the node-red crash issue that is yeelight is offline or AP is shutdown. For example, the yeelight assigned by AP is <IP_ADDRESS>, when AP shutdown or yeelight offline, the node-red crash and cannot running. I believe maybe should add exception handle the issue.
Best Regards,
Chris
发件人: Alexander Sorokin<EMAIL_ADDRESS>发送时间: 2017年12月4日 15:23
收件人: Gromina/node-red-contrib-yeelight <node-red-contrib-yeelight<EMAIL_ADDRESS>抄送: Chris Tang <Chris.JJ.Tang<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>主题: Re: [Gromina/node-red-contrib-yeelight] Not stable for SetRGB/temperature/brightness (#1)
Could you try the latest version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGromina%2Fnode-red-contrib-yeelight%2Fissues%2F1%23issuecomment-348879938&data=02|01|chris.jj.tang%40jci.com|2885baf10cfb49b6404208d53ae7e753|a1f1e2147ded45b681a19e8ae3459641|0|0|636479690052311798&sdata=hxdg7ZandjFJvZIBvPDidxWEeA%2FC6YNdZbdEzhozKzg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAe4iDXizjzGbLrnJdgl3-0of6yMV29p_ks5s853qgaJpZM4PoRol&data=02|01|chris.jj.tang%40jci.com|2885baf10cfb49b6404208d53ae7e753|a1f1e2147ded45b681a19e8ae3459641|0|0|636479690052311798&sdata=jWToaGflxpyGpixKMpikM9fhQ4%2FPxR7qixScnfFdxHI%3D&reserved=0.

I've also had the same issue, when the light is offline, i.e. power is switched off, node-red will crash. The light in this example is found at <IP_ADDRESS> but is offline:
Dec  7 10:26:52 raspberrypi Node-RED[28092]: 7 Dec 10:26:52 - [red] Uncaught Exception: Dec  7 10:26:52 raspberrypi Node-RED[28092]: 7 Dec 10:26:52 - Error: connect EHOSTUNREACH <IP_ADDRESS>:55443 Dec  7 10:26:52 raspberrypi Node-RED[28092]: at Object.exports._errnoException (util.js:1020:11) Dec  7 10:26:52 raspberrypi Node-RED[28092]: at exports._exceptionWithHostPort (util.js:1043:20) Dec  7 10:26:52 raspberrypi Node-RED[28092]: at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1090:14) Dec  7 10:26:52 raspberrypi systemd[1]: nodered.service: main process exited, code=exited, status=1/FAILURE Dec  7 10:26:52 raspberrypi systemd[1]: Unit nodered.service entered failed state. Dec  7 10:26:52 raspberrypi systemd[1]: nodered.service holdoff time over, scheduling restart.

Hi,
Please find the "index.js" on C:\Users\xxxx\node_modules\yeelight2 and edit "//    this.emit('error', err);" on Line 45. I believe can solve the issue.
BR,
Chris

Thanks Chris, but nope, still the same issue

Hi,
I attach index.js file you can replace it on C:\Users\xxxx\node_modules\yeelight2
P.S. Please change the name index.bak to index.js firstly.
Best Regards,
Chris
发件人: glennss<EMAIL_ADDRESS>发送时间: 2017年12月12日 1:15
收件人: Gromina/node-red-contrib-yeelight <node-red-contrib-yeelight<EMAIL_ADDRESS>抄送: Chris Tang <Chris.JJ.Tang<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>主题: Re: [Gromina/node-red-contrib-yeelight] Not stable for SetRGB/temperature/brightness (#1)
Thanks Chris, but nope, still the same issue
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGromina%2Fnode-red-contrib-yeelight%2Fissues%2F1%23issuecomment-350792013&data=02|01|chris.jj.tang%40jci.com|8ade7b7508024e70f1a608d540babc9e|a1f1e2147ded45b681a19e8ae3459641|0|0|636486093123539341&sdata=nME0v1DpI9kHqtedylz99gQWSABTlJNRomXZAvtUXOo%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAe4iDbDpi5TN9dBX8u_yk6ncOx0tb8m9ks5s_WMbgaJpZM4PoRol&data=02|01|chris.jj.tang%40jci.com|8ade7b7508024e70f1a608d540babc9e|a1f1e2147ded45b681a19e8ae3459641|0|0|636486093123539341&sdata=WUMWu347f5ecf%2FXkfNdAevPFLHRxJ9ESPQwGIK5S68A%3D&reserved=0.

Hey,
I can confirm the issue with SetRGB and Colour Picker. Already got the latest version of node-red-contrib-yeelight along with Colour Picker in "Format: hex" and it's just changing the color to blue, but no other color.
Thank you for your help :)


ipld.get() should never give the direct result of resolver.util.deserialize()

Calling ipld.get() should never result in the direct, deserialized value from a resolver’s util.deserialize() function. It should instead result in the equivalent of resolving the path / if no path is provided.
Right now, we explicitly return the result of resolver.util.deserialize(rawBlockData) if no path is specified: https://github.com/ipld/js-ipld/blob/c81882e82cdc3985a24b639f1034249988c1da37/src/index.js#L138-L148
(where ipld._get(cid) is just a wrapper for getResolverForCid(cid).util.deserialize(rawData))
Instead, we should always call resolver.resolver.resolve(rawBlockData, path) as part of ipld.get(), and the path we pass to the resolver should be / if no path was specified as an argument to ipld.get().
This is because get() should always return an object where the keys reflect paths that could be resolved — i.e. the IPLD focused concept of the DAG node, not some other underlying representation, like a BitcoinjsBlock from the Bitcoin library, for example. See the discussion in #141 for more about this.

With version 0.23 that's the case now. Though get() might have additional methods attached. This means that get() possible returns a superset of resolve('/') (or the same).


Dispose Ringing

I need to stop the call ringing in some condition how can I do that?

use https://github.com/ConnectyCube/connectycube-flutter-call-kit#notify-the-plugin-about-user-actions-concerning-the-call-on-the-flutter-app-side if you need to notify the plugin about some users' actions
or specify your needs with more details


Draft 1 Developer Guide Updates

This PR adds some more changes to the Developer Guide as mentioned in the comments to the previous
PR.
The following changes were implemented in this PR:

Removed stray comments
Added product survey
Added hyperlink to glossary where missing

Pull Request Test Coverage Report for Build 102

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.338%

Totals

Change from base Build 101:
0.0%

Covered Lines:
1599

Relevant Lines:
1942

💛  - Coveralls


Set open-pull-requests-limit to zero

⚠ Draft until https://github.com/gnosis/safe-notification-service/pull/138 is merged
From now on we are only going to enable security updates to this repo.
The documentation regarding this feature is a bit confusing but according to https://docs.github.com/en/code-security/supply-chain-security/managing-vulnerabilities-in-your-projects-dependencies/about-dependabot-security-updates

The Dependabot security updates feature is available for repositories where you have enabled the dependency graph and Dependabot alerts. You will see a Dependabot alert for every vulnerable dependency identified in your full dependency graph. However, security updates are triggered only for dependencies that are specified in a manifest or lock file.

This leads me to believe that we still need the dependabot configuration to have the security updates enabled.
Also according to https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#open-pull-requests-limit

This option has no impact on security updates, which have a separate, internal limit of ten open pull requests.

So setting it to zero should have no impact on the security updates.
@gnosis/safe-services

Good, what's missing to merge?

Good, what's missing to merge?

It failed on the pipeline and then I realised that we had a dependency issue so I decided to hold this off until we figured that one out. So right now is ready to be reviewed/merged.


How can I send tokens/parameters along with messages?

The server listens to messages via this which does not expose a request object.
server.post('/api/messages', connector.listen());
For my purpose, I need to receive a parameter token form the client app (webchat) at the time of connections.
What is the best approach for this ?

Hey seems like you are trying to intercept the request and you want to forward the request only if you get the right token. If that is the case it's pretty simple. The listen() method returns a closure function back that takes the restify request and response object you can simply wrap the object in your own closure and intercept the request example:
var botListener = connector.listen();
server.post('/api/messages', (req, resp) => {
    if (req.query.token == '<WHATEVER YOUR TOKEN IS>') {
        botListener(req, resp);
    }
});

Let me know if this works for you.

@maxpert this works just fine, thanks!

@mohit-jcc
Are you doing this as another level of authentication/authorization for the user with the bot? We are attempting something similar and would appreciate your thoughts/approach in this regard.
~abhishan

@maxpert @abhishan
Well what Im attempting is to bind the token value passed with the session created -
var botListener = connector.listen();
server.post('/api/messages', (req, resp) => {
// How can I save req.query.token here so it's uniquely available within the bot session?
botListener(req, resp);
});
var bot = new builder.UniversalBot(connector, function(session){
session.send("Hello");
//this is where i need to set 'session.userData.token'
session.beginDialog('login');
});
While the solution by @maxpert works, I am still not completely through with this. Thanks.

@abhishan : please have a look at this - https://github.com/Microsoft/BotBuilder/issues/1996

@mohit-jcc Nops session object won't directly carry the query parameters by default. But you can write a session middlewa

@maxpert Thanks for the heads up. So if this is added as a feature, do you suggest I wait for it or it will be good to use the middleware and have a work around? How soon can the feature be expected? Thanks.

You should be able to write a piece of middleware that extracts the token and saves it to the session object for each request. That's one of the intended reasons for supporting middleware.

Closing issue as it has been answered.


[update] remove test hardcode

Summary
:facepalm:
I'm so sorry. I added these hardcodes last minute to do a sanity test and forgot to undo the change.
How was it tested?
Will test

Current dependencies on/for this PR:

main

PR #1024   👈

This comment was auto-generated by Graphite.

Fixes #1022


[x] introduce a couple of guppy linters and fix up the issues they found

Introduce a couple of linters that use data obtained from guppy.

a project linter which ensures that there are no banned direct dependencies
a package linter which ensures that license and authors are set correctly for every crate.

Also:

implement the logic for running project and package linters
fix up the issues found by the linters.

Disabled the clippy lint for now -- may consider dropping Copy in the future as well depending on how things evolve (I still want to add more functionality to the lint engine).

@bors-libra r=bmwill

:pushpin: Commit b202705 has been approved by bmwill

:hourglass: Testing commit b202705fdc719e0be03ae4fb53c4a916af3703c3 with merge d6031e472c76905a8148727cce1d039a845a657b...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: bmwill
Pushing d6031e472c76905a8148727cce1d039a845a657b to master...


Add Functionality to Remove Unused Translation Keys

When texts/strings no longer exist anywhere in the UI, add a delete button in the translation editor when editing with environment variable LUBELOGGER_TRANSLATOR to remove the dictionary key and value from en_US file.
Since all translations will always look towards en_US, this ensures that the key will also be removed from other translations going forward as they are updated.
Additional requirements:

Pretty print translation export
Sort translation export A-Z

Released.


UP-TO-DATE check ignores empty directory in 7.4-rc-1

Given the android library project attached
UpToDateCheckRepo.tar.gz

Run gradle lib:bundleLibResDebug
Add a empty directory testDir under UpToDateCheckRepo/lib/src/main/resources/(there is already a dummy file foo.txt under resources directory)
Run gradle lib:bundleLibResDebug --console=plain and check the status of > Task :lib:bundleLibResDebug

Expected Behavior

:lib:bundleLibResDebug should be executed when running with gradle 7.3.3 and 7.4-rc-1
Current Behavior

:lib:bundleLibResDebug is UP-TO-DATE when running with 7.4-rc-1(it got executed with 7.3.3)
Context

Android Gradle Plugin is trying to upgrade gradle version from 7.3.3 to 7.4-rc-1.

I am pretty sure this is this (intentional) change: https://docs.gradle.org/7.4-rc-1/userguide/upgrading_version_7.html#empty_directories_file_tree
What kind of input does bundleLibResDebug declare, is it using @InputDirectory? Is this a problem for the task or is it fine for it to ignore empty directories?

This is the class which declares the inputs: https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:build-system/gradle-core/src/main/java/com/android/build/gradle/internal/tasks/BundleLibraryJavaRes.kt;l=143?q=BundleLibraryJavaRes
The relevant sections there are:
    // We cannot use @Classpath as it ignores empty directories which may be used as Java resources.
    @get:InputFiles
    @get:PathSensitive(PathSensitivity.RELATIVE)
    @get:SkipWhenEmpty
    @get:Optional
    abstract val resources: ConfigurableFileCollection

        private fun computeResourcesForTaskInput(projectJavaRes: FileCollection): Any {
            return projectJavaRes.elements.map {
                it.flatMap { fsLocation ->
                    fsLocation.asFile.walk().filter { f ->
                        if (f.isDirectory && f == fsLocation.asFile) return@filter false
                        MergeJavaResourceTask.predicate.test(f.extension)
                    }.sortedBy(File::invariantSeparatorsPath)
                }
            }
        }

So the problem is that computeResourcesForTaskInput basically flattens the hierarchy, so there is only a list of files and directories, each being at the root. The change in Gradle 7.4 is that for relative path sensitivity, we ignore directories at the root completely. In 7.3 we already ignored the name of the directory. So for example renaming a resource directory already didn't mark the task as out-of-date.
As a solution, you can register the input via the runtime API using ignoreEmptyDirectories(false):
val resources = project.files()
resources.from(projectJavaRes)
inputs
    .files(
        resources.filter { isNotEmptyDirectory(it) }
            .asFileTree
            .matching(MergeJavaResourcesTask.patternSet)
    )
    .withPropertyName("resources")
    .skipWhenEmpty()
    .ignoreEmptyDirectories(false)
    .withPathSensitivity(PathSensitivity.RELATIVE)

I am closing the issue now. If this is still a problem, please re-open.


Containerisation Improvements - phase 1

Describe the feature
Provide a container which can be easily/quickly used to run thin-edge and its components.
This is marked as phase 1 of containerisation support and is limited in scope to focus on quick-wins rather than a full refactoring task. See the Out of scope section for more details on what is NOT included in this proposal.
Motivation: Why a container?

Easy to create a demo which includes all the components in a preconfigured, ready-to-go format
More portable as it can be run from any docker instance, e.g. docker, docker desktop and colima (MacOS)
Process isolation. Protect the host system from components running inside the container

Current pain points

Custom environment setup is needed when running either on Windows WSL2 or MacOS operating systems
Add device to container is not straight forward as the container is not running as a classic container setup, e.g. one container/one process
Requires some knowledge of init systems (e.g. systemd, init.d system-v) for the service management to work
Can't easily use alpine base image as it does not support installing via .deb files (alpine uses .apk packages)

Describe the solution you'd like

Publish a container. It should be published to ghcr.io
Publish the container in three different flavours:

debian based with systemd installed (to provide a container is very close to a real device. Though this container is not intended for production use, just demos and development!)
debian based with another init system (e.g. init.d?)
alpine based (for small container sizes)

Publish the containers as a linux container in the following CPU architectures (one for each base image):

amd64
arm64
arm7 (would be good to have if it is not too much effort)

Describe alternatives you've considered
Building and maintaining my own container image. This can be hard to keep up to date as there is always a delay after a new thin-edge release as I have to get familiar with the changes and how they impact the container.
Out of scope
The following items are out of scope for this ticket.

External mqtt broker. At the moment it is to be assumed that the mosquitto MQTT broker is running inside the same container
Mount of volumes is up to the user to define, either with usage of the container, or when building their custom image.
The bootstrapping of thin-edge should continue to be done by the user

Additional information

An example of a systemd enabled container is viewable here, however you need to start the container using --privileged! Otherwise you can mount /sys/fs/cgroup:/sys/fs/cgroup:ro and add the CAP_SYS_ADMIN capability.

Closing as the tedge-demo-container meets most of this ticket and provides a ready-to-go environment to use and demo thin-edge.io.
Other issues have already been implemented to make thin-edge.io more container friendly (e.g. support setting config via environment variables #1790).


type hint fixes

After seeing Issue #1207 and PR #1208, I was curious about the pytype tool, so I just installed it and tried it out.
I was not intending to do a thorough "audit" of our type hint use at this time (although I think I heard that Adai might be doing that already) -- I only tried it on smarts/core/smarts.py.  This PR just contains fixes for some of the "easier" problems that pytype reported when I did this (including a couple return-type inconsistencies).
I figured I might as well do a PR for these now, notwithstanding that audit that might be currently underway, just in case it isn't yet.

For how minor the changes are this should be good to go. But I think if Adai is going to continue working on this in his free time, we should not be creating a separate PR for every file fixed by pytype lol.

Yep, I completely agree!  (I had to stop myself from doing more files as it's kind of "fun" -- lol -- to do these fixes.  But yeah, I don't think more than one of us should be working on them at a time.)
In fact, I'm ok with not merging this PR if it's already subsumed by whatever Adai is doing.  I just made the push in case it wasn't yet.

For how minor the changes are this should be good to go. But I think if Adai is going to continue working on this in his free time, we should not be creating a separate PR for every file fixed by pytype lol.

Given there are numerous type errors, I would not be able to fix all of them on my own. Everyone is encouraged to check their types using pytype for all new code or new pull requests. I guess, we will eventually include a pytype test in the CI workflow. I believe our code structure and maintenance improves with proper typing.


Feature/tweak download links

This PR fixes download links, adjusting them to the updated URL structure of the data-explorer (slugs instead of ids)
PIVOTAL
Test: To test it check all download links that lead to the data-explorer page

Right, I wasn't aware of this feature there...  I will take care of it today, thanks!

Hey @Bluesmile82 , this is ready again now. Two issues that I've spotted:

Gases filters on the Historical Emissions page don't parse very well, because on the page we use kebabCase function which for some cases parses the slugs differently e.g. CH4 to ch-4 instead of ch4 on the backend, more about this here
Historical Emissions and years filters - Visualize in... doesn't pass years to the emissions page, we would need to implement that in the another PR

I'll add these two issues to Pivotal

Álvaro, when you can please review this again.

Oh! I see that this is pointing to data-explorer-url instead of develop. That is why we don't have conflicts

Thanks for checking it, I removed commented bit as you suggested. I'll merge it now to the parent branch feature/data-explorer-url and then will open a PR with the rebased codebase to develop 👍


fix: unknown caddy language

https://github.com/symfony/symfony-docs/commit/83fa5c62a668c5489f2027dd3398072bce0bdedc introduced a new code-block directive 'Caddy'
We have now builds errors like:
[ERROR] There were some errors while building the docs:                                                                          Build errors from "2023-04-25 08:14:03"                                                                                Error while processing "code-block" directive: "Unsupported code block language "caddy". Added it in                     SymfonyDocsBuilder\Renderers\CodeNodeRenderer" in file "security"
I added 'caddy' as plaintext as there is no definition of caddy's syntax in https://github.com/scrivo/highlight.php

just a test comment

Thanks for fixing this bug Mickael.


Logging in doesn't work

After having installed Steam, and ran it (but never logged in through the GUI), there is a config.vdf file to read, but it has no 'Accounts' key. This will trigger a failure on line 276:
          username = list(vdf.parse(f)['InstallConfigStore']['Software']['Valve']['Steam']['Accounts'].keys())[0]

If afterwards you remove the config.vdf file, or at least rename it to something else, the following crash occurs when running steam-cli login:

Traceback (most recent call last):
File "/usr/bin/steam-cli", line 33, in
sys.exit(load_entry_point('steam-cli==0.0.0', 'console_scripts', 'steam-cli')())
File "/usr/lib/python3.9/site-packages/steam_cli.py", line 765, in main
client.login()
File "/usr/lib/python3.9/site-packages/steam_cli.py", line 274, in login
if os.path.exists(cfg):
File "/usr/lib/python3.9/genericpath.py", line 19, in exists
os.stat(path)
TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

My config.vdf has the subkey Steam but written in lowercase, so when I use it like
username = list(vdf.parse(f)['InstallConfigStore']['Software']['Valve']['steam']['Accounts'].keys())[0]

there is at least no exception, but it will hang indefinitely on the login response from the Steam server.


Serve side Pagination with Infinite scroll

Hi all.I want to know.your library support infinite scroll for server side pagination

duplicate of https://github.com/swimlane/ngx-datatable/issues/353


Tabs Component

Design
Figma Design Document
Implementation
General usage example:
<Component>Example</Component>

Rules
Put some rules about how this component should behave and implemented

Rule 1
Rule 2

API Reference:
Component component
Description
Properties

Property
Description
Default Value

attr (string)
attr desc
-

Here is the design documentation link. 🚀


Python entry is missing in config file

I don’t know if it is on purpose or not but python argument can’t be set from config file (if not provided at cluster initialization, it is set to sys.executable).
My use case is that I run dask in a singularity container on a PBS cluster so it can’t rely on sys.executable.

Hi @PhML, thanks for the issue.
I don't think it is on purpose, it's true that it's one of the few (the only one? Didn't really check) argument that is not available in config file.
I'm not sure how it impacts your use case, but any PR making it easier to run dask-jobqueue in Singularity container would be welcomed! Are you interested in proposing something?
At least, could you described more precisely your use case and the problem encountered?

@PhML, do you have more input on this? Can't you use the python kwarg when building your Cluster object?
Wihtout any news from you in the following weeks, I'm going to close this issue as stale, but any PR proposing to solve you issue will be welcomed.

Closing this issue as stale for now.


Error in checking cURL version for TLS 1.2. Error Num:[7] Error message:[Failed to connect to www.howsmyssl.com port 443: Connection refused]

Hi there,
Faced a problem: once in a few months an «Error in checking cURL version for TLS 1.2. Error Num:[7] Error message:[Failed to connect to www.howsmyssl.com port 443: Connection refused]» error appears. But after 5-10 minutes and page reloading it is gone by itself. TLS version is 1.2, checked twice. The error appears during execution of $curlVersionResponse = curl_exec($curl); in a versionOfTLS method. Any thoughts of what it might be caused by?
Thanks a lot in advance.

I ran into this recently on 1/29/20 around 10:50am CST it seems the www.howsmyssl.com was unavailable for 5 minutes, causing this payment SDK to stop working.

As it stands howsmyssl.com is down causing this library to fail perpetually. Is there any plan to replace howsmyssl.com? Their downtime is getting too much. For hours now, they're still not up

@MrHeart What is the version of SDK you are on? We updated the SDK to not use howsmyssl in the release 5.3.5. Can you please pull the latest version of the SDK?


Dependency installs failing

Whenever I run install.bat it either fails or I get
C:\Users\ru>npm install
npm WARN saveError ENOENT: no such file or directory, open 'C:\Users\ru\package.
json'
npm WARN enoent ENOENT: no such file or directory, open 'C:\Users\ru\package.jso
n'
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is inst
alled. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of erlpack@hammerandchisel/erlpack bu
t none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is insta
lled. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is inst
alled. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installe
d. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none
is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed.
You must install peer dependencies yourself.
npm WARN ru No description
npm WARN ru No repository field.
npm WARN ru No README data
npm WARN ru No license field.
up to date in 0.703s
What am I doing wrong?

I have same problem


patronictl pause and resume function will not work with current PATRONI_RESTAPI_LISTEN setting

Describe the bug
The current setting for the PATRONI_RESTAPI_LISTEN environment variable is "<IP_ADDRESS>:8008".
However when running a patroninctl pause (to get into maintenance mode) and then the patroninctl resume it runs into an error where the system is left in maintenance mode. The error says that it cannot find the rest api at <IP_ADDRESS>:8008.
By setting PATRONI_RESTAPI_LISTEN=$POD_IP:8008' the issue is solved.
I suggest to include this in the set up.

OK after a few more re-installs and testing, this does not seem to happen anymore. So it might have been something related to my testing (taking down nodes, re-initialize them etc.)


Disable upgrade detector

Hi,
is there any chance you would consider removing upgrade detection:
master/chrome/browser/upgrade_detector_impl.cc
This would be most useful for a kiosk application, which is not connected to the web at all.
Or did I miss this feature?
Thanks!

Is this for the browser itself? In that case, it isn't even enabled in Chromium if my memory serves me correctly (since Chromium's usually built by developers, so there's no point in checking Google for updates). ungoogled-chromium definitely does not have this enabld.


Stream rendering to reduce TTFB and CPU load

I suggest to stream-render pages > 50KB (hypothetical stream overhead) to reduce TTFB and CPU load.

Inferno offers streamAsString, streamAsStaticMarkup, streamQueueAsString, streamQueueAsStaticMarkup with inferno-server (master). As of 1.2.1, the stream renderer was experimental and 10-15% slower than renderToString. Should wait for 1.3 (currently RC3).
React with aickin/react-dom-stream, which replaces renderToString and renderToStaticMarkup.
thysultan/dio.js with renderToStream (SSR/renderToStream.js).

It would supersede https://github.com/zeit/next.js/pull/767. Preact does not support streaming (https://github.com/developit/preact/issues/23#issuecomment-226954130).

One thing to mention..
Stream rendering usually won't add much CPU improvements since the amount of work to be done is the same. But it'll reduce the response time.
It's a pretty good idea to provide a way to customize the SSR rendering system. But I think for now, we'll stick with the React's renderToString() methods by default.
This is something we could do after 2.0.

Stream rendering usually won't add much CPU improvements since the amount of work to be done is the same.

from aickin/react-dom-stream
One call to ReactDOM.renderToString can dominate the CPU and starve out other requests. This is particularly troublesome on servers that serve a mix of small and large pages.

Wouldn't streaming sensibly reduce memory allocation and CPU usage for large pages by being both asynchronous and partial?

Thought this was along the same lines.  Has anyone tried https://github.com/FormidableLabs/rapscallion ?

It provides a streaming interface so that you can start sending content to the client immediately.

Other features from the docs:

Rendering is asynchronous and non-blocking.
Rapscallion is roughly 50% faster than renderToString.
It provides a streaming interface so that you can start sending content to the client immediately.
It provides a templating feature, so that you can wrap your component's HTML in boilerplate without giving up benefits of streaming.
It provides a component caching API to further speed-up your rendering.

Added an example of Rapscallion in #2279... can confirm that Rapscallion + Next is insane. Streamed/promise-based render is awesome, but Component-level caching is a game-changer for us... :godmode:

Now that React 16 has its own renderToNodeStream, it would be a huge advantage for next.js to add an option to use it instead of renderToString. What do you think, @timneutkens?

It's on our list of things to add already 👍

Any news about this?

https://github.com/zeit/next.js/pull/4074#issuecomment-466996162

Any news?

Next.js needs to expose custom render (with renderToString as default renderer` in order for user to use their custom async renderer i think.

any roadmap / plan of streaming rendering support? so expected have this in next.js .

The is pending on the React team implementing React Fizz / their plan for it.

@timneutkens What the issue, PR to track here?

From Facebook's blog post, published on August 8th 2019
https://reactjs.org/blog/2019/08/08/react-v16.9.0.html
An Update on Server Rendering
We have started the work on the new Suspense-capable server renderer, but we don’t expect it to be ready for the initial release of Concurrent Mode. This release will, however, provide a temporary solution that lets the existing server renderer emit HTML for Suspense fallbacks immediately, and then render their real content on the client. This is the solution we are currently using at Facebook ourselves until the streaming renderer is ready.

Is there any update or any other method to implement renderToNodeStream in next.js ?

Is there any update?

<3

Any update?

@StarpTech I'd looked a bit into this (curious for this feature as well!) and it looks like the react team is working on something called react-flight, which will probably be the base for the streaming solution we are waiting for here :)
react-flight:

This is an experimental package for consuming custom React streaming models.

The relevant PR's that shine some light on the inner workings, interpreted by me (not an expert in any of this 🙈 )
#17285: Basic api for flight, the server should be able to stream everything as a string, but leave placeholders for the chunks that are asynchronously resolved on the server. An incomplete, yet interesting, syntax for how react would know from a stream what data type it actually represents is over here.
#17398 More recent PR, adds an api for Chunks so (if you're feeling lucky) you could try that part out yourself. Not sure how everything would come together but nevertheless I'm kinda happy with seeing all this work being done :)
This might be slightly off-topic, but hopefully interesting for people subscribing to this issue :)

@pepf thanks for the info!

Hm. Thank u all guys, interesting info. I am just thinking why should NextJS wait for React support SSR for suspense and stuff, and not just use streamAsString now?

@arunoda I think it will reduce memory consumption, very important for low memory (FaaS) lambda functions. I see this as the obvious next optimization-to-lower-TTFB/latency after geo-routing to origin (lamdas in my case).

Any news about this?

Any news?

Any news guys? :P

Given that react suspense feels like it may never come out, is there any way we can revisit this? I'm seeing initial render times of 800-1000ms on fairly generic, low-content pages (that are rendered from a serverless function on vercel). Streaming the HTML in theory could bump up that initial point of contact and lead to much much faster perceived first-load ux.

Is that a limitation of Vercel rather than NextJS? Does Vercel fall victim to the same sort of cold-startup that Lambda does? My team runs a bunch of content heavy sites and our timings are under 50ms for the whole request. I don't think streaming is going to be a silver bullet here.

I don't expect it to be a silver bullet, but it certainly would be a welcome improvement.

50ms sounds really low and relatively insignificant to optimize compared to the mentioned cold-start times, but 50ms is a lot when rendering at edge with something like Cloudflare Workers (it is as much as the ping to the nearest Cloudflare edge location, or at least half), Cloudflare Workers respond very quickly, typically in under 5 milliseconds, when cold starting. In contrast, both Lambda and Lambda@Edge functions can take over a second to respond from a cold start.
I know this does not make a better case for Varcel (which builds its own cdn) employed developers of next.js to prioritize this.

Is there any documentation or repositories where people have successfully deployed next.js to cloudflare workers? I did some googling and couldn’t find much on it. That would be amazing.
Sent from my phone

On Jul 5, 2020, at 5:47 PM, Wis<EMAIL_ADDRESS>wrote:

50ms sounds really low and relatively insignificant to optimize compared to the mentioned cold-start times, but 50ms is a lot when rendering at edge with something like Cloudflare Workers (it is as much as the ping to the nearest Cloudflare edge location, or at least half), Cloudflare Workers respond very quickly, typically in under 5 milliseconds, when cold starting. In contrast, both Lambda and Lambda@Edge functions can take over a second to respond from a cold start.
I know this does not make a better case for Varcel (which builds its own cdn) employed developers of next.js to prioritize this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

50ms sounds minuscule and relatively too insignificant to optimize compared to the mentioned cold-start times

To clarify, I wasn't complaining about my 50ms response times - I was just pointing out that NextJS' SRR is relatively performant even of north of 3k requests / minute for content-heavy pages, so Switz's problem might lay elsewhere.

Is there any documentation or repositories where people have successfully deployed next.js to cloudflare workers

I would also be interested in that. We're currently running in Fargate but pushing our app to the edge would be the next logical step.

Eu fiz todas as melhorias possiveis dentro do meu HTML e o tempo de resposta do servidor esta altissimo! :(

@huggler you can combine this example with cacheable-response. You can use Redis (or in-memory cache for example) to store html in cache. It improves server response time.

Is there any documentation or repositories where people have successfully deployed next.js to cloudflare workers? I did some googling and couldn’t find much on it. That would be amazing.

@switz @tills13  did you check out https://fab.dev/ ? We played with it early 2020 and it was in pre-release state, but they seem to have come pretty far. One of the limitations back them was Cloudflare itself, but things might have changed by now.

Haven't looked in a while. Would have to reevaluate. Last time I looked, there were some pretty serious tradeoffs.
I am also keeping my eye on https://github.com/flareact/flareact.

Any update on this?

Hi @timneutkens any update on this issue? Is React Fizz still the solution you’re waiting for?
(I have a high-traffic site that currently scales really poorly due to renderToString)

@timneutkens I would like to echo the same concern as @tomsoderlund's. If Next isn't deciding to support it any time soon; do you think it's a wise idea for me to run a fork of Next that supports streaming or would you advise against it?

Hi
Any update on this?
No one is gonna answer us? :)

Yes any update?

Still this: https://github.com/vercel/next.js/issues/1209#issuecomment-485270144
Streaming rendering will eventually be added once the React team published the new version of the server renderer, this is currently on the experimental channel.

If I'm not wrong, it seems it might come in React 18?

Any update on this?

Streaming rendering support is currently being worked on by @devknoll, @shuding, and @huozhi. We'll share when there are relevant proposals here.

Any update on this?

With the launch of Next.js 12v I think this will come out of the box now: https://nextjs.org/blog/next-12#server-side-streaming Next.js 12 introduces a bunch of new performance features, including Suspense and SSR streaming and much more, so I think this issue can be marked as resolved?

It is under an experimental flag, and requires React 18 which is in alpha. So I'd say it is far from stable. And I wouldn't close this issue until both are available as stable.

any news?

The recently launched App Router supports streaming rendering by default, you can add Suspense boundaries to flush early loading states.
@kostia1st we're currently not planning to add streaming to the Pages Router as we had to add specific APIs (i.e. metadata) in order to make early flushing work. Without Server Components you can't stream in data so you wouldn't get clear benefits from having it for Pages like you do in App Router.
I'm going to close this issue now as it has been shipped 👍


Linux Implementation

is there an instruction for implementing the AI system using Linux?

I managed to make it work. You're probably missing the Java package.
sudo apt-get install default-jre

it should solve the OSError (or something like that) :)


Minimize code duplication

I am working on another PR which would allow to remove country flags from the Selector list. This PR is just to suggest some improvements in the code before I do that. I have attempted to do 2 things in this PR

Replace Function(Country) onCountrySelected with ValueChanged<Country> onCountrySelected.
Use CountrySelectorNavigator class to hold the common values and return a CountrySelector with appropriate values

Let me know how this looks.

Nice PR, thanks.
In the same vein as your other changes, maybe the defaults values should be the same for all and set up on super.
However the way defaults work in dart might make the code less readable. What do you think? I can merge this as is though.

Nice PR, thanks.
In the same vein as your other changes, maybe the defaults values should be the same for all and set up on super (specifically the three boolean values).
However the way defaults work in dart might make the code less readable. What do you think? I can merge this as is though.

@cedvdb So you mean something like super(addSeparator: addSeparator ?? true) and make the booleans required in CountrySelectorNavigator?


It could not add more than one upstreams to a route

Issue description
i want add more than one upstreams to a route ，but I find it doesn't work
Environment
[root@lhdev2 routes]# curl -i -X PUT http://<IP_ADDRESS>:9080/apisix/admin/routes/00000001 -d '

{
"uri": "/*",
"methods": ["PUT", "GET", "POST", "DELETE"],
"upstream_id": ["00000001", "00000002"]
}'
HTTP/1.1 400 Bad Request
Date: Fri, 06 Dec 2019 09:52:22 GMT
Content-Type: text/plain
Transfer-Encoding: chunked
Connection: keep-alive
Server: APISIX web server
{"error_msg":"invalid configuration: property "upstream_id" validation failed: object matches none of the alternatives"}

我发现用http请求不能灵活的修改upstream中的ip和权重，每次修改，发送请求，都需要将nodes中的所有ip重新写一边，其实我只想修改nodes中某一个ip的权重

@DHB-liuhong Apache APISIX does not support yet.
I think you can refer to https://github.com/apache/incubator-apisix/pull/371 if you want to do this.

@moonming if i have


comments on deprecateds in WhitelistedQuery wasmbinding

Closes: #5735
What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....
Most of the mentioned endpoint already have a replacement.Comment on what are deprecated and their successors
Testing and Verifying
(Please pick one of the following options)

[x] This change is a trivial rework / code cleanup without any test coverage.

(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

So every outdated queries have already been replaced by the new one right?

@phamminh0811 No not replaced, since we don't want to break contracts from this upgrade


Document the response to the GetParticipant API

There is no description of the response to GetParticipant.
Even the sample response body is hidden under the "JSON" Example tab.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b60eeacc-a71e-9644-b869-3e0a4f1506d8
Version Independent ID: 313bf83f-5325-f9f4-5780-9bc81e315c1e
Content: Create apps for teams meetings - Teams
Content Source: msteams-platform/apps-in-teams-meetings/create-apps-for-teams-meetings.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

Hi @aosolis, there is a response body under Json Example Tab. Here is the sample response for GetParticipant
{    "user":{       "id":"29:1JKiJGPAX9TTxtGxhVo0wLx_zwzo-gG8Z-X03306vBwi9p-xMTEbDXsT6KH7-0kkTS8cD-2zkrsoV6f5WJ6_aYw",       "aadObjectId":"e236c4bf-88b1-4f3a-b1d7-8891dfc332b5",       "name":"Bob Young",       "givenName":"Bob",       "surname":"Young"<EMAIL_ADDRESS><EMAIL_ADDRESS>      "tenantId":"2fe477ab-0efc-4dfd-bde2-484374e2c373",       "userRole":"user"    },    "meeting":{       "role ":"Presenter",       "inMeeting":true    },    "conversation":{       "id":"<conversation id>",       "isGroup":true    } }

@surbhigupta12 we should move the response documentation out of the JSON tab, and make it more obvious/accessible.


Update Cursor Colors for Better Visibility Across Themes

I made a slight modification to the cursor component to ensure better visibility across both "light" and "dark" themes. The changes are straightforward and do not involve any conditional logic based on the theme.
Changes:

Updated the cursor background color from bg-black/20 to bg-gray-500/20.
Changed the cursor text color from text-white to text-black.

These adjustments improve the cursor's visibility regardless of the active theme.

Thanks for your help!


Fix bugs in education brief

Merge it first and then we will replicate it into sprint 5 prototype. The checkboxes bug in Education Brief will be fixed in sprint 5 prototype.


is it possible to disable the retry feature?

im adding :retry-handle #(do false) to the options but the retry still happens, is it possible to disable it forever?

Can you expand on where you're seeing the retry? What is it retrying after? I need to figure out where the retry is coming from in order to stop it.

Closing as there has been no feedback, feel free to comment if this was closed erroneously.


Xcode restarts when quit

When I quit Xcode it is immediately restarted and sometimes is recognized as a crash.
This is directly related to Privacy -> Automation -> DiscordX -> Xcode.
I'm currently using 14.2 on Monterey 12.6.7. Didn't appear to be an issue on Ventura 13.4 with Xcode 14.3

bump


Technical hotline suggest to call verification hotline on positive quick test

Which hotline
App/Technical hotline
Describe the issue
Somebody on Twitter told me that the technical hotline said him that if a quick test returns positive, the verification hotline should be called to get a TAN and warn others.
According to https://www.coronawarn.app/en/faq/#rapid_test, it is currently not supported to enter quick tests into the app.
The blog post "Die Bundesregierung integriert Schnelltests in die Corona-Warn-App" says:
"Die App integriert künftig Schnelltests. "
Both sources make it very clear that you shouldn't add quick tests into the app currently.
Suggested change
Please

Clarify wether it is suggested to add positive quick test results into the app via calling the verification hotline
If it's not suggested, please make sure that hotline staff doesn't advice people to do this.

This is not an enhancement, please relabel.
Thanks!

 Thanks.

Although it should now, with the release of version 2.1, be clearer what to do, I'll close this issue once somebody from the team ensures that hotline staff was instructed to not issue any TeleTANs for quick tests.

@Ein-Tim

Although it should now, with the release of version 2.1, be clearer what to do, I'll close this issue once somebody from the team ensures that hotline staff was instructed to not issue any TeleTANs for quick tests.

The FAQ Can I share my positive rapid antigen test result via the TAN hotline? says:
"It is not possible to share a positive rapid test result via the TAN hotline. Only rapid test results communicated via the app have been performed according to the dual control principle and by trained personnel, and can therefore be shared."
so that also makes it very clear.

I guess we won't get an answer here, so closing this issue.


Adaptive Layout

The page should resize accordingly when viewed on different screen resolutions.

Elements on the page resize when resolution is below 1000px.


Use latest Play Service Security Updates

If Google Play Services is installed TLSv1.2 support is provided back to API 9
This should also fix Issue #20


Missing types

Describe the bug
When using TypeScript, NugetDepsTree.generate returns any.
Expected behavior
NugetDepsTree.generate should return Tree and I should be able to consume the Tree and Project types in my project.

PR here: https://github.com/jfrog/nuget-deps-tree/pull/25


Project specific settings

Could you add project specific settings? So one could have different isort settings for a project.

There are project-specific settings already. It looks like the following:

Do you have anything particular in mind that is missing maybe?

😳 I must have been blind


LIBXSMM + ATen

Using LIBXSMM alongside ATen breaks (wrong results) the matmul ops in ATen.
I am building LIBXSMM with make BLAS=0 and linking statically (libxsmm.a).
I guess LIBXSMM is interfering with respective BLAS calls.
Don't recall seeing this before.
Is this an expected behavior?

( What's "ATen"? Sorry for my side Q... )
I can guess something like this is possible since I unified building static and shared library based on the very same object. I believe(d) to be around issues related to BLAS call-interceptor, but I can be wrong.
Can you check your output when running with LIBXSMM_VERBOSE?
Any non-zero verbosity s fine, e.g., LIBXSMM_VERBOSE=4.
( Note: at current development stage we have "two main branches", i.e., main_stable and main. )

It could be that stderr is redirected during the actual tests (otherwise the table at the end of the execution is shown nicely). If not redirected, it's unlikely the cause I mentioned above. I will take a look in any case!

I see: I’ll have a look at that later today.
FYI: I have seen this in a similar case a couple of days ago. At that time LIBXSMM was complaining (at runtime) that it doesn’t have BLAS support; I can reproduce that error if it helps.

FYI: I have seen this in a similar case a couple of days ago. At that time LIBXSMM was complaining (at runtime) that it doesn’t have BLAS support; I can reproduce that error if it helps.

This is the warning I get just when calling Aten:
auto options = at::TensorOptions().dtype(at::kFloat);

at::Tensor a = at::arange(0,72, 1, options);
at::Tensor b = at::arange(0, 48, 1, options);

a = at::reshape(a, {9,8});
b = at::reshape(b, {8,6});

at::Tensor res = at::einsum("ij, jk -> ik", {a, b});
at::Tensor res2 = at::matmul(a, b);

std::cout << "A: " << a << "\n";
std::cout << "B: " << b << "\n";
std::cout << "einsum: " << res << "\n";
std::cout << "matmul: " << res2 << "\n";

LIBXSMM WARNING: application shall be linked against LAPACK/BLAS sgemm!
A:   0   1   2   3   4   5   6   7
  8   9  10  11  12  13  14  15
 16  17  18  19  20  21  22  23
 24  25  26  27  28  29  30  31
 32  33  34  35  36  37  38  39
 40  41  42  43  44  45  46  47
 48  49  50  51  52  53  54  55
 56  57  58  59  60  61  62  63
 64  65  66  67  68  69  70  71
[ CPUFloatType{9,8} ]
B:   0   1   2   3   4   5
  6   7   8   9  10  11
 12  13  14  15  16  17
 18  19  20  21  22  23
 24  25  26  27  28  29
 30  31  32  33  34  35
 36  37  38  39  40  41
 42  43  44  45  46  47
[ CPUFloatType{8,6} ]
einsum:   294   301   308   315   322   329
  630   645   660   675   690   705
  966   989  1012  1035  1058  1081
 1302  1333  1364  1395  1426  1457
 1638  1677  1716  1755  1794  1833
 1974  2021  2068  2115  2162  2209
 2310  2365  2420  2475  2530  2585
 2646  2709  2772  2835  2898  2961
 2982  3053  3124  3195  3266  3337
[ CPUFloatType{9,6} ]
matmul:   294   301   308   315   322   329
  630   645   660   675   690   705
  966   989  1012  1035  1058  1081
 1302  1333  1364  1395  1426  1457
 1638  1677  1716  1755  1794  1833
 1974  2021  2068  2115  2162  2209
 2310  2365  2420  2475  2530  2585
 2646  2709  2772  2835  2898  2961
 2982  3053  3124  3195  3266  3337
[ CPUFloatType{9,6} ]

I have been working on a simple reproducer and it looks like that this is an OpenMP issue and unrelated to LIBXSMM: Simply compiling/linking with -fopenmp brakes ATen when using GCC (for certain matrix sizes); icpc works.
This still leaves the warning LIBXSMM WARNING: application shall be linked against LAPACK/BLAS sgemm! which appears when combining LIBXSMM 2d69da4 and ATen. I can give this another shot using main_stable and also try out icpc over gcc.

Thank you for digging deeper! I am working on the remaining issue already.

The issue about LIBXSMM WARNING: application shall be linked against LAPACK/BLAS sgemm! should be resolved for main and will soon be backported to main_stable.

Thanks!


Evaluate a condition branch only if needed

The CEL language definition suggests:

To get traditional left-to-right short-circuiting evaluation of logical operators, as in C or other languages (also called "McCarthy Evaluation"), the expression e1 && e2 can be rewritten e1 ? e2 : false. Similarly, e1 || e2 can be rewritten e1 ? true : e2.

cel-python used to evaluate the full tree before deciding if a branch will be used or not. This PR only evaluates a branch if selected by the condition.
Fixes issue https://github.com/cloud-custodian/cel-python/issues/50

thanks for the pr, lgtm, but would appreciate a look by @slott56

See https://github.com/cloud-custodian/cel-python/pull/63 which fixes this problem.


Fix compilation errors with btrfs-progs-4.5

btrfs-progs-4.5 introduces device delete by devid
for this reason btrfs_ioctl_vol_args_v2's name was encapsulated
in a union
this patch is for setting btrfs_ioctl_vol_args_v2's name
using a C function in order to preserve compatibility
with all btrfs-progs versions
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

LGTM, and worth considering if we have another rc IMO

let me add it to the milestone so that we don't loose sight; we can decide after that

LGTM


Lambdas sdcard update

oh god i fucked up the git by forgetting to have each changelist as a separate branch at the same commit level as dev so what i was basically doing was having like 6 branches that are all one ahead of the other but contain those same commits
please i cannot solve this, everything is a mess, it would be great if you could accept this as it is as i really cant do anything to fix it at this point, im so sorry
at least each commit is its own individual group of changes? is that at least okay with you? i dont think theres anything i can do about it at this point without starting completely over...

it would be so messy though, i think

gotten much better since then, so ill do this embarrassment over


Handle image files

We can now print images, next step is to handle image files. We want to be able to open them, dither and send to printer

I've decided to look into the crate image


TypeScript?

Would it be possible to add a type declaration (ideally something like @types/react-under-construction and modify the attributes in the example to make TypeScript happy?
Thank you.

Hi @KevinBurton, this repository is just an example of how to create an NPM package with create-react-library: https://github.com/DimiMikadze/create-react-library.
I want to leave it as simple as it is right now. If we convert it to Typescript, people who don't have experience with it will have a hard time understanding the example.
However, feel free to convert it to Typescript in another branch, if you want to. 🙂


node: Add WireguardPubKey to ToCiliumNode

This ensures the WireGuard public key is preserved when converting a
nodeTypes.Node object to a CiliumNode CRD. This conversion is currently
is only used for attaching external workloads (which has no support for
WireGuard at the moment anyways), but it might be used in other places in the
future, therefore we should ensure that it propagates all information
correctly.
I discovered this while validating WireGuard support in Clustermesh.
This PR does not fix any outstanding bugs.

test-me-please

test-me-please

test-me-please


[move-model] replace TypeConstraint with AbilityConstraint

As title. TypeConstraint (i.e., copyable, resource) no longer exists, use the AbilityConstraint instead.
Only the first commit needs to be reviewed, the second one is doc update which is auto-generated.
Motivation
Found this when converting Spec types into Move types.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI

/land

:broken_heart: Test Failed - ci-test-success

Rebase to the latest main and try landing again.
/land


Feature/1206762379115955 runtime version

After merge, we also need to cherry-pick the merge to the dev branch


Zigbee Examples persist network after reboot (IDFGH-10677)

Is your feature request related to a problem?
I tried the HA_on_off_light HA_on_off_switch
examples and compiled them for the ESP32-H2 everything worked. But after a reboot of the coordinator the light-node needs to reboot as well otherwise commands are not transferred.
Describe the solution you'd like.
Add a example how to persist the zigbee network state for both devices after reboot.
Describe alternatives you've considered.
No response
Additional context.
No response

Hi @muc-martin ,
The Zigbee network still exists after the coordinator reboots. The reason why commands are not transferred is that the switch example uses a volatile variable to store the light (end device) device information. When the switch (coordinator) resets, the device information is cleared from the switch's RAM, resulting in the commands not being transferred.
The esp-zigbee-sdk provides the esp_zb_zdo_device_bind_req() API to bind two devices. By doing so, the device information can be stored into flash and recovered by the device, which can be referred to in the esp-zigbee-sdk
Besides, more practical examples  will be added to esp-idf zigbee.

Hi @xieqinan,
thank you for the info.
It would be great if you could add an example how to connect and use a commercially available zigbee wall switch (e.g. switch to receive and process commands on the ESP32 board and perform custom actions depending on which button was pressed.
Thanks.

@muc-martin We have updated the examples in the esp-zigbee-sdk to store the network and binding information persistently: https://github.com/espressif/esp-zigbee-sdk/tree/main/examples/esp_zigbee_HA_sample
So after the reboot, the devices will continue to work together.

The Zigbee Stack related information is maintained within SDK, the SDK will do the store and retrieve by itself. User applicaion only handles the application specific info.


switching projects by clicking file wrong behavior

when clicking on a file in an inactive project it correctly switches to that project and opens the file, but the active file stays the previous active file

I can't seem to replicate this anymore


Lock version in template

Not super important, but this makes it so that the simple-broker-template on the release-1.1 branch is using the correct container images.

Not associating a bug with this as it's just a template change for upstream.


[FR] Always show logged in user in leaderboards

The idea here is it enables you to see how close you are to ranking without needing to muck around in the API.

Done, by @IanPhilips!


Image event onLoad not firing on production initial load

UPDATE: further reducing this to:
 {console.log('fired')}} />

During dev, console logs 'fired' immediately, during npm run serve, it only fires when I visit another route then go back to homepage
==========
Hi guys. I need your help, I'm trying to check if all the images have loaded before applying a class for show animation.
During npm run start, during dev:
export class AwesomeClass extends React.Component {
   constructor(props) {
       super(props);
       this.handleImageLoad = this.handleImageLoad.bind(this);
       this.state = { imageStatus: 0 };
   }

   handleImageLoad() {
      var counter = this.state.imageStatus;
      counter++;
      this.setState({ imageStatus: counter });
     console.log('handleImageLoad is called');
   }

   componentWillMount() {
     this.imagesArr = [ "1.png", "2.png", "3.png"];
   }

   render() {
      let my = this;
      return (

             this.imagesArr.map( (item) => {
                return
             }

      )
   }
}

this works perfectly well during dev, but when I try to build then serve, handleImageLoad is not called on first load (blank console). When I switch to another page, and then go back to the homepage (where the images are), only then does handleImageLoad() work (console logs my handleImageLoad is called).
Did somebody else experience this? Thank you so much!

I just realized that during dev, app.abcdef13579.js is loaded first and then during prod, the image '1.abcd1234.png` is loaded first before the app.js is. so the image is loaded before the code itself that handles image onload is loaded.
So I guess that what I really should work on is onError rather than onLoad?
This is embarassing haha.


Fix for #172.

This change fixes #172.

Gentle ping for code review...

:+1: (Assuming the test passes)

Yep, tests (new and old ones) are good.

Do you have an estimate on when a new release with this fix will be published?

yikes this just killed my build.  Is this released?

Is this going to be released soon?


[Bug]: Container hangs in azure-pipelines.yml

Testcontainers version
3.7.0
Using the latest Testcontainers version?
Yes
Host OS
Ubuntu 22.04.3
Host arch
x64
.NET version
8
Docker version
Whatever azure-pipelines.yml is currently using

Docker info
Whatever azure-pipelines.yml is currently using

What happened?
Running dotnet test just hangs
Relevant log output
A total of 1 test files matched the specified pattern.
##[debug]Agent running environment resource - Disk: available:16874.00MB out of 74244.00MB, Memory: used 35MB out of 6921MB, CPU: usage 12.86
[testcontainers.org 00:00:00.06] Connected to Docker:
  Host: unix:///var/run/docker.sock
  Server Version: 24.0.7
  Kernel Version: 6.2.0-1019-azure
  API Version: 1.43
  Operating System: Ubuntu 22.04.3 LTS
  Total Memory: 6.76 GB

Additional information
This runs fine on Windows with Docker Desktop installed, but when I run it in azure pipelines it hangs.

I use Testcontainers daily on Azure Pipelines with Microsoft's hosted agents and private agents. Hanging containers are very likely a misconfigured wait strategy. If the wait strategy does not indicate readiness, Testcontainers will keep trying it repeatedly. Can you share your container builder configuration?
But I need to admit that I have had issues with my last two builds as well (GH and Azure DevOps share basically the same agents).
[testcontainers.org 00:00:02.51] failed to register layer: write ...: no space left on device

Do you still run into the issue? Can you please share your builder configuration (a reproducer)? Without additional information, I am afraid I cannot help.

As mentioned, without additional information, I cannot help. Usually, this happens either due to a misconfigured custom wait strategy or blocking the async context. I will close the issue in the meantime. Do not hesitate to reopen it again if you need further assistance.

If I whittle it down to a minimal repro, I will. Thanks.


No test folder in duke_evaluation

In "evaluation_res_duke_fast.m"
there are a line :  Hist_query = importdata(['test/IDE_' netname '_query.mat']);
However, I cannot find folder test
Thx~

Please see here.


fix(layout): using react component and default props for layout to fa…

…cilitate overriding

:tada: This PR is included in version 1.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Not able to resolve the filestack android library

During the integration of the library in a current Android project I noticed that gradle was not able to resolve it despite being declared as it is stated in the documentation:
implementation 'com.filestack:filestack-android:5.3.0'
The current repositories specified are the following:
repositories {         google()         jcenter()         mavenCentral() }
If any additional information is required to address this issue feel free to ask. Thanks in advance for any feedback provided regarding this problem.

Did you find any solution?

Same issue, Failed to resolve: com.filestack:filestack-android:6.0.0. Where is this library hosted now, post the sunsetting of jcenter?

Update on this? if any.

Worked for me you are the best.


Help on Linux says "Windows PowerShell Help"

related https://github.com/PowerShell/PowerShell/issues/3345

Actually, this is a dupe of https://github.com/PowerShell/PowerShell-Docs/issues/1228


SASS-Loader added. Board component + footer component changed to SASS

SASS files added to board component and footer component.

This change is

@nimishamukherjee Can you please review this too. I think we all need to be on the same page before we bring this into the project.

Should we leave the CSS loader and support in place too? We could have the loader support CSS, LESS, and SASS. I don't know if that would make things more confusing but it is possible.

@joshuawilson , @SMahil - Patternfly scss files are not available under the patternfly node package. That only has the css files. For now we can go ahead with the approach of including the patternfly files under the assets folder.

@nimishamukherjee I think that will work for now. Thanks for reviewing this.

PatternFly SASS is available via the GEM package manager
https://rubygems.org/gems/patternfly-sass

@mindreeper2420 do you know how to make that work with Webpack? We are trying to keep our dependencies handled by NPM. I'll have to consider using the gem.

Reviewed 18 of 18 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add webauthn beta badge

Closes #5976
To be merged after #5795. I have made this as a separate PR, so that we can easily revert to remove the badges :)
Screenshots

@brainwane as per your issue, did you want me to link through to here, or are we planning to add a FAQ?

@brainwane as per your issue, did you want me to link through to here, or are we planning to add a FAQ?

@nlhkabu Good question. I think we should add a "what are beta features?" FAQ item. And then we can update that FAQ with "here are the current beta features" and provide appropriate hyperlinks -- in the case of WebAuthn I need to update https://wiki.python.org/psf/WarehousePackageMaintainerTesting to give context and suggest how to test it.

@nlhkabu
Here's a quick draft of an FAQ item:

Q: What does the "beta" badge mean? What are Warehouse's current beta features?

A. While Warehouse's maintainers are deploying new features, at first we mark them with a small "beta" symbol to tell you: this should probably work fine, but it's new and less tested than other site functionality. Right now our beta features are:

In your Account Settings: WebAuthn (U2F key) support for two-factor authentication, rolled out as beta 11 June 2019.

I updated https://wiki.python.org/psf/WarehousePackageMaintainerTesting enough that it would be fine to link to in an FAQ.

Updated to work with new UI and FAQ:

replaced with #6027, the merge situation got a bit too wild for me to unwind.


Colour theme

Dear developer, I think this is one of the better IDEs for developing in MicroPyhon. Unfortunately, I have poor eyesight and cannot read texts with limited contrast, for example red text on a black background. In the future can you add the options for choosing a color theme? Thank you in advance!

Hi and thank you @GerardHarkemaAvans  ! ♥
I'm sorry, but unfortunately I'm not working on it at the moment :(
I'm co-founding an AI start-up dedicated to e-commerce customer service... (www.achille.ai).
However, you can always open the package/zip and go to the CSS file to try and change the fonts and sizes.
It's Web format behind the UX ;)

So, I suppose no light mode either?


docker: Error response from daemon: failed to verify image

Output of docker version:
core@r12s6 ~ $ docker version
Client:
 Version:      1.10.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   8acee1b
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   8acee1b
 Built:
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 0
Server Version: 1.10.3
Storage Driver: overlay
 Backing Filesystem: extfs
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 4.5.0-coreos-r1
Operating System: CoreOS 1010.5.0 (MoreOS)
OSType: linux
Architecture: x86_64
CPUs: 24
Total Memory: 62.95 GiB
Name: r12s6.sjc.aristanetworks.com
ID: HCTY:Q3PK:PF2E:5XDO:RNWV:GYGS:LD5E:GVC5:Q3KC:7ED5:I2HL:GAMZ

Additional environment details (AWS, VirtualBox, physical, etc.):
Fresh install of CoreOS stable (1010.5.0) on a dedicated server.
Steps to reproduce the issue:
I don't know why but on this particular host, after reformatting the root filesystem and doing a fresh CoreOS install, I'm unable to deploy this particular container:
core@r12s6 ~ $ docker run --restart=always --net=host --name=lldpd -d registry.docker.sjc.aristanetworks.com:5000/tools/lldpd
docker: Error response from daemon: failed to verify image: sha256:6720cea9f393cd435c53b7ac3d4b8ac8a60e0341308251d52bcb8a8911263fc0.
See 'docker run --help'.

Describe the results you received:
Error above.
Describe the results you expected:
Container should start.
Additional information you deem important (e.g. issue happens only occasionally):
I did a rm -rf /var/lib/docker/image/overlay/layerdb/sha256/* but that didn't change anything.

Are there any more error messages in the daemon logs? It looks like you might have a corrupted image file, although it is not entirely clear from the error message.

The relevant log seems to be:
core@r12s6 ~ $ journalctl -u docker.service | tail -n 2
Jun 13 09:36:50 r12s6.sjc.aristanetworks.com dockerd[1130]: time="2016-06-13T09:36:50.094817415Z" level=warning msg="HostsPath set to \"/var/lib/docker/containers/b835d568452d477dcdb9d1aad67bae065ba888257db7c01c2d62467690f8b308/hosts\", but can't stat this filename (err = stat /var/lib/docker/containers/b835d568452d477dcdb9d1aad67bae065ba888257db7c01c2d62467690f8b308/hosts: no such file or directory); skipping"
Jun 13 09:36:55 r12s6.sjc.aristanetworks.com dockerd[1130]: time="2016-06-13T09:36:55.293853797Z" level=error msg="Handler for POST /v1.22/containers/create returned error: failed to verify image: sha256:6720cea9f393cd435c53b7ac3d4b8ac8a60e0341308251d52bcb8a8911263fc0"

Let me close this ticket for now, as it looks like it went stale.