Growing performance penalty over time

We have spent an extraordinary amount of time tracing progressive degradation of app performance (to the point of unresponsiveness) to this tool. The problem does not appear to be the result of a change in this library, but a change in one of its direct or transitive dependencies, which made it quite painful to track down.
Beginning with the deployment of a service that included only small changes and updated dependencies, we began experiencing a significant leak of sorts. The latency of HTTP requests between our cloud load balancer and application would continue to grow, while becoming increasingly variable. At the same time, all metrics and samples collected from within the application remained stable.
Through a lot of trial and error we discovered that we could only reproduce the issue in production, which made us suspect the various Google agents we have installed (trace, profile, and debug). We eliminated all of them, which fixed our issues. We first reintroduced trace without experiencing the leak; we then added profile without issue; we finally added debug back in and the behavior described here returned.
Here are a few additional deploys we did to test the effect of allowExpressions:

The latencies continue increasing about linearly until we restart the processes (or kill pods in our case).
Between "good" and "bad" versions of our application, the following dependencies of @google-cloud/debug-agent changed, so there's likely an interaction somewhere in one of these:

name
last good version
current version

@google-cloud/common
2.0.4
2.2.6

@google-cloud/debug-agent
4.2.0
4.2.1

@google-cloud/projectify
1.0.1
1.0.4

@google-cloud/promisify
1.0.2
1.0.4

base64-js
1.3.0
1.3.1

coffeescript
2.4.1
2.5.0

end-of-stream
1.4.1
1.4.4

gaxios
2.0.1
2.2.2

gcp-metadata
3.2.2
3.3.0

google-auth-library
4.2.6
5.9.1

google-p12-pem
2.0.1
2.0.4

gtoken
3.0.2
4.1.4

https-proxy-agent
2.2.2
4.0.0

jwa
1.4.1
2.0.0

jws
3.2.2
4.0.0

node-forge
0.8.5
0.9.1

p-limit
2.2.0
2.2.2

readable-stream
2.3.6
2.3.7

semver
5.7.0
7.1.1

stream-shift
1.0.0
1.0.1

string_decoder
1.2.0
1.1.1

teeny-request
4.0.0
6.0.0

uuid
3.3.2
3.4.0

yallist
3.0.3
3.1.1

We also observe a small memory leak, which may mean that this is the same as #811. However, the memory growth was very small and slow on node version 10.x, and was dwarfed by our concerns about latency. I will also note that when testing on node versions 12 and 13, we experienced a significant memory leak, but tentatively dismissed it as this (also here).
We are (obviously) no longer running the debug agent anywhere, and it isn't critical to our daily operations. Please let me know if you have any more questions or could use more information.
Environment details

OS: GKE container optimized
Node.js version: 10.17.0 - 10.18.1, 12.14.1, 13.6.0
@google-cloud/debug-agent version: 4.2.0 - 4.2.1

Steps to reproduce

yarn add @google-cloud/debug-agent
Add the following (with either value for allowExpressions):// Add cloud debugging.
import { start as startDebug } from "@google-cloud/debug-agent";
startDebug({ serviceContext, allowExpressions: true });

Allow the application to run inside GKE with access to cloud debugging, serving a steady stream of requests over HTTP. The service graphed above was receiving between 1.5 and 3 requests per second.

Sorry for the long silence on this issue.  I'm looking into this and #811 at the moment.
Thanks for all of the information; it's very much appreciated.
Do you know whether the cloud debugger was actively being used during the times that the performance degraded?  If there were no logpoints or snapshots being requested then it limits the potential codepaths that could be involved.

Hi @mctavish, I believe we saw this behavior irrespective of whether the debugger was actively being used for logpoints or snapshots.

Thanks. That helps

We cannot reproduce the error performance wise, but according to the graph, it looks related to the memory leak in #811. Since we have came up the fix for the memory leak after v5.2.4, we would close this issue for now.  Please reopen it if the problem still exists.


Add extractTypeDescribedValue to PropsTable

Fixes #21
Description
Treat different kind of prop types.
It ignore complex types, like recursive types and others.
Good reference: https://github.com/reactjs/react-docgen/blob/55bbefed8321d535e53786b684708bd618cc15fb/src/utils/tests/getPropType-test.js
Pre-merge checklist

[ ] Test

I think it would be cool to add it as JSX tags, so we could style the different types?

Yeah, I'm thinking improve this PropsTable later. But for now I only want to fix the bugs.

Thanks @renatorib 🙏


CS8002 Error: assembly Microsoft.Azure.StackExchangeRedis does not have a strong name

Looks like the package is not strong name signed.
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS8002	Referenced assembly 'Microsoft.Azure.StackExchangeRedis, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have a strong name.

Thanks for reporting this @jayshims. We're working on a new release that will be fully signed.

Is there any update for this issue @philon-msft?

No update yet - the next release will be fully signed

The Microsoft.Azure.StackExchangeRedis.dll assembly is now strong name signed in v2.0.0. Please give it a try and let us know if any issues remain.


Update templates to work with Xcode 6.3

Untested with earlier versions of xcode.
Apparently in Xcode 6.3 the TemplateInfo.plist has a version of the macros that
xcode provides (e.g.:: ___FILENAMEBASE___) that are different from the contents of
the template. The template contents use the actual file name, rather than what the
user provides.
This fix just captures the class the user typed as a variable, and then uses it
in the template. I believe this should work on earlier versions of Xcode, but
I haven't had the liberty to check yet.
Fixes #324

Huge shoutouts to @akitchen for motivating me to do this, and for my son for staying asleep for the time it took me to figure out how the crazy variable syntax for Xcode templates works (yet again).

Thanks @tjarratt!  I just tried it out on Xcode 6.2 and it doesn't seem to break anything.

Aww damn. Thanks!
On Monday, May 4, 2015, pivotal-ryan-mcleod<EMAIL_ADDRESS>wrote:

Thanks @tjarratt https://github.com/tjarratt!  I just tried it out on Xcode 6.2 and it
doesn't seem to break anything.
—
Reply to this email directly or view it on GitHub
https://github.com/pivotal/cedar/pull/325#issuecomment-98853159.

--
Magnetized From My Etch-A-Sketch

Thanks @tjarratt @pivotal-ryan-mcleod !


Add utils to translate custom types

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Proposed change set are helper functions to translate to and from custom types.
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes-sigs/gateway-api/issues/826
Does this PR introduce a user-facing change?:
No

Thanks @abhijit-dev82! This LGTM but will defer to someone else to add final LGTM.
/ok-to-test
/approve


Mashing restart+back when in practice mode breaks practice logic in some cases

basically just causes a desync in lua vs c++
steps:

turn on practice mode
pick a song, go into gameplay
at any point, press restart and 0-1 frames later press escape, so that the gameplay restarts and goes into ScreenStageInformation (the hidden screen before gameplay) but quits into ScreenSelectMusic next
at this point, you are in ScreenSelectMusic
go to the title screen
go back to select music
pick a song without doing anything else
you are in "practice" mode with practice mode off

05588d1a62470e6f379ef0d8102c45a69c9c9a73


Missing Files when switching to Mobile

Hey there :)
At first Awesome Work 👍 👍
It ist not really a Issue, but when I change my Browser window size to mobile size, log tells me following:
Dez 13, 2017 11:45:02 PM com.vaadin.server.VaadinServlet serveStaticResourcesInVAADIN INFORMATION: Requested resource [/VAADIN/bower_components/webcomponentsjs/webcomponents-lite.js.map] not found from filesystem or through class loader. Add widgetset and/or theme JAR to your classpath or add files to WebContent/VAADIN folder.
Dez 13, 2017 11:45:02 PM com.vaadin.server.VaadinServlet serveStaticResourcesInVAADIN INFORMATION: Requested resource [/VAADIN/bower_components/shadycss/apply-shim.min.js.map] not found from filesystem or through class loader. Add widgetset and/or theme JAR to your classpath or add files to WebContent/VAADIN folder.
Dez 13, 2017 11:45:02 PM com.vaadin.server.VaadinServlet serveStaticResourcesInVAADIN INFORMATION: Requested resource [/VAADIN/bower_components/shadycss/custom-style-interface.min.js.map] not found from filesystem or through class loader. Add widgetset and/or theme JAR to your classpath or add files to WebContent/VAADIN folder.
As I said, all works fine, but it gives this bad taste in my Log that something is wrong.

This error comes from missing source map files. This error only seems to occur if you have your chrome developer console open and source map enabled.

Can you confirm it?

Sorry,
Gonna Check it when I'm at home
Am 14.12.2017 2:06 nachm. schrieb "appreciated"<EMAIL_ADDRESS>
Can you confirm it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/appreciated/vaadin-app-layout/issues/77#issuecomment-351705695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AakKgJ3mNMdBg_ewAPwRxmE0unY8Z4B1ks5tAR1hgaJpZM4RBS6f
.

No need to apologise 😉. I just wanted to point out that I'm waiting for a response, which my previous comment didn't state clearly.

yep u were right. Only happens, when I'm on the developer console of chrome.
Next time ill google first ;)
Thx for your help

You are welcome have a nice day!


Use --use-script-input-files instead of running on each file

Hi,
First of all, thanks for a nice addition to Danger 🥇
We recently ran into the invalid byte sequence in UTF-8 error which happens under certain circumstances within ruby-git. So I changed our use of this plugin to pass all swift files into swiftlint.lint_files.
This however resulted a runtime of 19 minutes for linting ~1300 swift files on our CI vs roughly 1 minute  using swiftlint in the terminal.
So I looked into the source and in danger_plugin.rb run_swiftlint is run on each file individually.
My guess is that this is why the runtime goes from 1 minute to 19 minutes.
Would you be interested in a pull request that uses the --use-script-input-files like it is done in the fastlane::swiftlint plugin?
Cheers
Morten

@mbogh awesome, thank you!


Improve error message for invalid connection property

If I try to put an actual connection string in the function.json connection property for a storage trigger/binding, as a customer might assume a property with that name could take, I get a generic “object not set” error.
Microsoft.Azure.WebJobs.Host: Error indexing method 'Functions.QueueTriggerCSharp1'. Microsoft.Azure.WebJobs.Host: Object reference not set to an instance of an object.
It might be worth catching this error and returning something more helpful like “connection property is not a valid app setting key for a storage connection string”

I'm doing this in my current changeset - I didn't notice that Fabio was assigned before I started.

I've added an early validation for all "connection" properties - these will now result in descriptive function validation errors in the portal:
Connection value 'DefaultEndpointsProtocol=https;AccountName=xxx;AccountKey=yyy' is invalid.

:+1:


trace.ignore_path does not work in spring cloud gateway

Please answer these questions before submitting your issue.

Why do you submit this issue?

[x] Bug

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?
6.6.0

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

Please use the latest version.


deduplication bug: nessus issues with low severity replace high severity issues

Issue Template
Issue Type

[x] Bug
[ ] Enhancement

Description
when deduplicating findings of an engagement (in this case a nessus report and a ci/cd engagement) the high findings "disappeared" and became low or medium findings because they were deduplicated and the findings marked as "original", were the findings with the lower severity....
if duplicates exist I would expect the system to deduplicate the lower-prio issue into the higher-prio issue. not the other way around. aka. I dont want to loose visibility of the high-prio issues, because of deduplication in the "open findings" view. (also in reports etc. the duplicates would be "excluded" because the originals are reported anyway)
If the issue is a bug, please also include the following:
Operating System
Ubuntu 18.04 LTS
Install

[ ] setup.bash
[x] docker

DefectDojo Version
https://github.com/DefectDojo/django-DefectDojo/commit/cce053272650283adf1a0c34ac0d61f15eb565cf
Steps to Reproduce
Sample Scan File (if applicable)
Screenshots (optional)
 high issues as duplicates, no issues with severity "critical" exist, meaning that all of these high issues were deduplicated into lower prio issues...
Console Logs (optional)

Could you please check if this is still happening with the latest dev/master ? Also , could you give a few more details on which deduplication options were used ? Using deduplication on engagement can still currently cause this I believe but normal deduplication should be fixed .

Also could you tell which finding was considered as the original for the high ones that were marked dupllicate? Are they the same title/filepath/cwe?

Hi guys, sry this takes so long. unfortunately I am having big trouble getting defectdojo up and running again after the update. I am running dojo in docker and the docker-compose seems to have changed quite a bit, and I have not been able to get it to run for now.
@adracea I will keep you posted after I get the system back up. But this could take a few days, as I have zero ideas why the system is not working.
@valentijnscholten  I will check after I get the system back up (having problems with my old version as well unfortunately)
for the curious: the problems seems to be this (new version):

uwsgi_1         | wait-for-it.sh: waiting 30 seconds for mysql:3306
uwsgi_1         | wait-for-it.sh: mysql:3306 is available after 0 seconds
uwsgi_1         | *** Starting uWSGI 2.0.18 (64bit) on [Mon Apr 15 06:52:57 2019] ***
uwsgi_1         | compiled with version: 6.3.0 20170516 on 15 April 2019 06:51:20
uwsgi_1         | os: Linux-4.15.0-20-generic #21-Ubuntu SMP Tue Apr 24 06:16:15 UTC 2018
uwsgi_1         | nodename: a500f9870db5
uwsgi_1         | machine: x86_64
uwsgi_1         | clock source: unix
uwsgi_1         | pcre jit disabled
uwsgi_1         | detected number of CPU cores: 2
uwsgi_1         | current working directory: /app
uwsgi_1         | detected binary path: /usr/local/bin/uwsgi
uwsgi_1         | *** WARNING: you are running uWSGI without its master process manager ***
uwsgi_1         | your memory page size is 4096 bytes
uwsgi_1         | detected max file descriptor number: 1048576
uwsgi_1         | lock engine: pthread robust mutexes
uwsgi_1         | thunder lock: disabled (you can enable it with --thunder-lock)
uwsgi_1         | uwsgi socket 0 bound to TCP address <IP_ADDRESS>:3031 fd 3
uwsgi_1         | Python version: 2.7.16 (default, Mar 27 2019, 09:43:28)  [GCC 6.3.0 20170516]
uwsgi_1         | *** Python threads support is disabled. You can enable it with --enable-threads ***
uwsgi_1         | Python main interpreter initialized at 0x564d67bf0bb0
uwsgi_1         | your server socket listen backlog is limited to 100 connections
uwsgi_1         | your mercy for graceful operations on workers is 60 seconds
uwsgi_1         | mapped 72920 bytes (71 KB) for 1 cores
uwsgi_1         | *** Operational MODE: single process ***
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "./dojo/wsgi.py", line 29, in
uwsgi_1         |     application = get_wsgi_application()
uwsgi_1         |   File "/usr/local/lib/python2.7/site-packages/django/core/wsgi.py", line 13, in get_wsgi_application
uwsgi_1         |     django.setup(set_prefix=False)
uwsgi_1         |   File "/usr/local/lib/python2.7/site-packages/django/init.py", line 22, in setup
uwsgi_1         |     configure_logging(settings.LOGGING_CONFIG, settings.LOGGING)
uwsgi_1         |   File "/usr/local/lib/python2.7/site-packages/django/conf/init.py", line 56, in getattr
uwsgi_1         |     self._setup(name)
uwsgi_1         |   File "/usr/local/lib/python2.7/site-packages/django/conf/init.py", line 41, in _setup
uwsgi_1         |     self._wrapped = Settings(settings_module)
uwsgi_1         |   File "/usr/local/lib/python2.7/site-packages/django/conf/init.py", line 110, in init
uwsgi_1         |     mod = importlib.import_module(self.SETTINGS_MODULE)
uwsgi_1         |   File "/usr/local/lib/python2.7/importlib/init.py", line 37, in import_module
uwsgi_1         |     import(name)
uwsgi_1         | ImportError: No module named settings
uwsgi_1         | unable to load app 0 (mountpoint='') (callable not found or import error)
uwsgi_1         | *** no app loaded. going in full dynamic mode ***
uwsgi_1         | *** uWSGI is running in multiple interpreter mode ***
uwsgi_1         | spawned uWSGI worker 1 (and the only) (pid: 1, cores: 1)

Yeah , this is related with one of the docker issues , namely #1036 , you should also check out #1045 for more info :)

@adracea thx for the hint!!! the workaround provided in issue #1036 worked. :)


Guide Please

Can someone make a video or a step by step dummy guide for the people that are struggling ?

While I am still learning and fiddling with this repo, it is largely dormant and most are now  focused here:
https://github.com/glinscott/leela-chess/issues/88

well i am intrested in the learning of alpha zero and how he will destroy me after 50 games being beaten so i wanna know how to install it . Thx tho

nothing i do works i cant make it start and move

Even if it works I doubt it will be super strong like you seem to expect. It needs a lot of training to become strong.

Try running it from a terminal or cmd with the /run.py uci command.  At first it will say little and enter "uci", then wait.  After the engine responds, enter "isready" and wait again.  It can take a bit of time to set things up.  You should be familiar with the UCI protocol.  If it works this way, then try installing it with Xboard or Arena or another GUI for an actual game.  It moves slowly (depending on the config settings).

add me on discord and help please Disc0rd#2571


Automated profiling of user-submitted bug reports

A given bug report has all the needed information to reproduce the execution of the haskell backend. There are standard ways we have of profiling these executions.
See here: https://github.com/runtimeverification/haskell-backend/issues/3216#issuecomment-1229193911
In particular, we have a way to setup cabal to do this type of profiling: https://github.com/runtimeverification/haskell-backend/wiki/Profiling#haskell-profiling. And we also have a way to do memory profiling: https://github.com/runtimeverification/haskell-backend/blob/master/docs/profiling.md
We should setup a CI job that allows:

User to submit a bug report as a GitHub issue, with the tarball attached to the main issue body.
CI machine grabs that tarball, and builds haskell backend with profiling turned on, then profiles the bug report.
Uploads all the generated artifacts directly to the github issue (speedscope logs, etc...).

As we improve our profiling setup over time, we can make sure this harness is also taking advantage of those changes. This will hopefully make some small portion of the issues much quicker to fix. Maybe we can immediately spot the problem in the initial profiles, without having to do much extra work, and this removes the human step of having to download and run those profiles.

@F-WRunTime can help with setting up the CI side of things.

@jberthold @goodlyrottenapple @ana-pantilie please add a comment describing how you generate profiles and what info you'd like to get automatically when someone opens an issue like this.

An overview of my workflow when first profiling a bug report
Requirements: cabal, hs-speedscope
With a fresh copy of the project:
git clone git@github.com:runtimeverification/haskell-backend.git
cabal v2-configure --enable-profiling -f-threaded
cabal v2-build all
// to successfully automate this the newly built kore-exec should be added to path somehow
cd <path-to-bug-report>
timeout -s INT 4m env GHCRTS='-p -l-au' ./kore-exec.sh
hs-speedscope kore-exec.eventlog

That should output kore-exec.eventlog.json which can be loaded into https://www.speedscope.app/ and viewed.

For convenience, I am usually using stack install --profile and have the binary output directory on the path.
With GHCRTS='-p' alone, one gets a textual time/memory profile which is what I usually use in the first place.
I haven't worked much with speedscope yet but I guess it is useful for partial profile data from a timed-out program run.
According to the speedscope manual, it can import GHC profiles created with `GHCRTS='-pj' directly but this RTS option is only for GHC>=9.0 (and I haven't tried it)

I have set up some targets in nix for profiling, especially for GHC9 which has some new profiling features. I usually do
nix shell github:runtimeverification/haskell-backend#kore-exec-prof-ghc9

or
nix shell .#kore-exec-prof-ghc9

if i am already in the haskell-backend repo and then something similar to @ana-pantilie's
timeout -s INT 4m env GHCRTS='-p -l-au' ./kore-exec.sh

We need to write a script which builds the latest master with profiling and generates:

textual/json profile
eventlog profile
standard heap profile (cost centres)

Can we do the above in the same run? Will the eventlog profile contain different information depending on the other profiling options?
Can we view the html files directly from eventlog2html? Should we just post the picture of the graph in the issue?
Also set up heap profiling with GHC 9. Needs a different build, but not a profiling build (eventlog needs to be turned on but it's already on by default on our project). This needs to be checked, if it's true then merge https://github.com/runtimeverification/haskell-backend/pull/3231. We want to do this type of profiling: https://well-typed.com/blog/2021/01/first-look-at-hi-profiling-mode/
Test this on #3216
We will want to run this on our own machines because we need the profiles to contain as much information as possible.

We want to be able to run it anywhere, which means that it should be incorporated into the build system committed to the repo.
But we also want a "default" template, with a series of simple-to-run commands, which can be run on CI, so that we can automate the first round of collecting that performance information. That way, without having to do anything, you can already have a discussion as a team about those initial profiles that are produced automatically, before assigning more specific investigations.

Who will take this? I think it's high priority @ana-pantilie. Collecting profiles should be as low-friction as possible.

We should run these jobs on an isolated instance. We can tag each instance with performance tag, and use the old rv-master node (which should be unused now) with a single github runner taking up 95% of the capabilities of the machine.

Got First tests Executing here: https://github.com/runtimeverification/devops-actions/actions/runs/3063300591/jobs/4945220719

Further information How to use:
When using in a pull request a performance test can be triggered via being labeled properly FIRST, then adding a comment with to the PR with the .tar file

Alternatively can be triggered when adding a comment to an existing or in the issue body.
Editing an existing Issue or PR triggers the same by adding a comment and the tar file.

Label MUST be 'performance' on the issue or pull request for a test to run. Otherwise the trigger will skip and not run.
Tests currently are run against the primary branch only.

And it was working when I posted it ran a test again and it complains about an error that didn't exist before.
Further investigation needed...

Made some progress this morning. Got a couple runs setup to go now. Made a fix with suggestion from @jberthold
Fixed an issue in the first run with thefile name. Think the Environment file is only sourced once per step (makes sense). So should see a couple successful run throughs here. Hopefully this means we can look to move this over to the haskell repository in a PR on Monday and get some auto profiling running!
@ehildenb @ana-pantilie @goodlyrottenapple let me know if you have any questions
changes are currently on master of the devops-actions repository
I will remove concurrency for the haskell repo.

@goodlyrottenapple Any insight as to why this is failing
It says it passes but on step: "Run Tests" it is running the 'nix command' we discussed
And there are errors as shown below.
gzip: stdin: unexpected end of file
/nix/store/mnln1nxdhxx5qj8rcyvllhhs6d4h668b-gnutar-1.34/bin/tar: Child returned status 1
/nix/store/mnln1nxdhxx5qj8rcyvllhhs6d4h668b-gnutar-1.34/bin/tar: Error is not recoverable: exiting now
env: ‘./kore-exec.sh’: No such file or directory
cp: cannot stat 'kore-exec.prof': No such file or directory
cp: cannot stat 'kore-exec.eventlog': No such file or directory
hs-speedscope: kore-exec.eventlog: openBinaryFile: does not exist (No such file or directory)
cp: cannot stat 'kore-exec.eventlog.json': No such file or directory
env: ‘./kore-exec.sh’: No such file or directory
cp: cannot stat 'kore-exec.hp': No such file or directory
cp: cannot stat 'kore-exec.eventlog': No such file or directory
hp2pretty: kore-exec.hp: openFile: does not exist (No such file or directory)
eventlog2html: kore-exec.eventlog: openBinaryFile: does not exist (No such file or directory)
cp: cannot stat 'kore-exec.svg': No such file or directory
cp: cannot stat 'kore-exec.eventlog.html': No such file or directory
env: ‘./kore-exec.sh’: No such file or directory
cp: cannot stat 'kore-exec.eventlog': No such file or directory
eventlog2html: kore-exec.eventlog: openBinaryFile: does not exist (No such file or directory)
cp: cannot stat 'kore-exec.eventlog.html': No such file or directory
/home/github-runner/actions-runner/_work/_temp/0daef5be-08b4-4580-b7[91](https://github.com/runtimeverification/devops-actions/actions/runs/3069572010/jobs/4958385049#step:4:92)-ad4b673a6d8e.sh: line 13: Fri Sep 16 17:37:17 UTC 2022: syntax error in expression (error token is "Sep 16 17:37:17 UTC 2022")

The current snapshot of the _work folder looks as follows:
github-runner@github-runner-1:~/actions-runner/_work/devops-actions/devops-actions$ ls -l
total 32
-rw-r--r-- 1 github-runner github-runner    0 Sep 16 17:22 foundry.tar.gz
drwxr-xr-x 3 github-runner github-runner 4096 Sep 15 21:11 profile-20220915-211153-foundry
-rw-r--r-- 1 github-runner github-runner  306 Sep 15 21:11 profile-20220915-211153-foundry.tar.gz
drwxr-xr-x 3 github-runner github-runner 4096 Sep 15 22:58 profile-20220915-225804-foundry
-rw-r--r-- 1 github-runner github-runner  307 Sep 15 22:58 profile-20220915-225804-foundry.tar.gz
drwxr-xr-x 3 github-runner github-runner 4096 Sep 15 23:02 profile-20220915-230241-foundry
-rw-r--r-- 1 github-runner github-runner  308 Sep 15 23:02 profile-20220915-230241-foundry.tar.gz
drwxr-xr-x 3 github-runner github-runner 4096 Sep 16 17:37 profile-20220916-173717-foundry
-rw-r--r-- 1 github-runner github-runner  307 Sep 16 17:37 profile-20220916-173717-foundry.tar.gz

Is there a known issue with having multiple runs in the same folder?
Only issue I see is the artifact uploads after finished are uploading all the runs. I will add a 'clean folders' before starting a new run to make sure there is no left overs from previous runs.

Looking at https://github.com/runtimeverification/haskell-backend/blob/master/nix/run-profiling.nix#L15 (which seems to again be the first failure in the script), and your directory listing:
-rw-r--r-- 1 github-runner github-runner    0 Sep 16 17:22 foundry.tar.gz
This is an existing empty file. On my machine, tar -xvzf will respond with the error we see, gzip: stdin: unexpected end of file when given an existing empty file.
Also, we should definitely add a -e to the shell script that runs the profile. No point trying anything further if unwrapping failed. Just need to ensure the steps that may fail (like a timeout call)  are wrapped so we still get results.
And yes, cleaning up the working directory would be a good idea. I am not sure but the script might also have an issue confusing ./profile and $out_folder.

@jberthold
Added some fixes but when I run the test I'm still getting some errors, here is me running it manually with the foundry.tar.gz test file
github-runner@github-runner-1:~/actions-runner/_work/devops-actions/devops-actions$ nix run github:runtimeverification/haskell-backend#profile ./foundry.tar.gz
kore-exec.sh
vdefinition.kore
spec.kore
kore-exec.log
result.kore
tests/foundry/foundry.debug-log: openFile: does not exist (No such file or directory)
tests/foundry/foundry.debug-log: openFile: does not exist (No such file or directory)
/tmp/kore-exec-e82bd9f554ffa191/kore-exec.log: withFile: does not exist (No such file or directory)

@goodlyrottenapple @jberthold
Please see latest results. I am getting an error now regarding 1000 traces.
https://github.com/runtimeverification/devops-actions/actions/runs/3084571476/jobs/4986872128
Is there a configuration I'm missing?

The 1000 traces is actually a warning, emitted by the tool that post-processes a trace log into speedscope format. The tool has options to filter the trace log for specific K rules, and speedscope might have trouble loading data which has too many traces.
What errored out in the run linked above was the computation on dates (Mon for Monday , the time when this ran...)

Okay good to know. Sounds like it's fine though just to be clear before leaving it alone?

Fixed by #3265


Quarkus: application not updated on source file change (in Codewind)

Describe the bug
A clear and concise description of what the bug is.
When using the Quarkus stack in Codewind, a source file change is not triggering the application to get updated
I was not able to reproduce this outside of Codewind, however, what I can determine is the source file change does get reflected inside the appsody container, and it does trigger something to happen:
[Container] [ERROR] Port 5005 in use, not starting in debug mode
[Container] Debugger failed to attach: handshake failed - connection prematurally closed
[Container] 2020-04-10 01:04:35,887 INFO  [io.quarkus] (Quarkus Shutdown Thread) Quarkus stopped in 0.002s

Additionally, if I shell into the appsody container and make changes directly inside, it does trigger the application update normally.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Actual behaviour
What is the actual behaviour.
Environment Details (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

If applicable please specify:

CLI version:
Stack you are using (including the version):

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@paulrobinson ^^

Thanks @neeraj-laad  and @makandre.
Are you saying that you make a change to the source code in Codewind, and then you can see that specific change reflected on the filesystem when you shell into the container, but Quarkus doesn't react to that change?
If so, I'm confused why shelling into the container direct to make the code change would cause Quarkus to reload the code.
I'm just trying to understand at what point in the flow it's breaking.
I can probably have a go at reproducing this later this week (Friday). Can you provide some reproduction steps for someone unfamiliar with Codewind? Or maybe I just: install Codewind into VSCode, select a new Quarkus application, run it, change code, observe code change not reflected in Quarkus.

@paulrobinson Yes, the steps to reproduce this in Codewind are exactly as you have said.
When you save a file change, the change is not reflected in the webpage during hot reload. You have to do a full build again (rerun appsody run) to see the application updated

Hi Paul, the steps you stated are the easiest way to reproduce and how I did it yesterday.
When I tried this and modified the GreetingResource.java code Quarkus from within Codewind, the logs in the running Quarkus container showed this:
2020-04-14 16:51:32,808 INFO  [io.quarkus] (Quarkus Shutdown Thread) Quarkus stopped in 0.002s
Listening for transport dt_socket at address: 5005
__  ____  __  _____   ___  __ ____  ______
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2020-04-14 16:51:37,574 INFO  [io.quarkus] (main) getting-started 1.0-SNAPSHOT (powered by Quarkus 1.3.0.Final) started in 1.912s. Listening on: http://<IP_ADDRESS>:8080
2020-04-14 16:51:37,577 INFO  [io.quarkus] (main) Profile dev activated. Live Coding activated.
2020-04-14 16:51:37,577 INFO  [io.quarkus] (main) Installed features: [cdi, resteasy]

notice the first line that is saying it is using [io.quarkus] (Quarkus Shutdown Thread) and it doesnt detect the file change and rebuild the app.
What is supposed to be doing the watching for code changes, is this Quarkus itself?
However, if I exec into the Quarkus container and look at the file I changed from Codewind, it has been updated to what was changed from within Codewind.  While within the container I edit the same file and save it I get the following:
2020-04-14 16:49:43,588 INFO  [io.qua.dev] (vert.x-worker-thread-7) Changed source files detected, recompiling [/project/user-app/src/main/java/org/acme/quickstart/GreetingResource.java]
2020-04-14 16:49:44,352 INFO  [io.quarkus] (vert.x-worker-thread-7) Quarkus stopped in 0.025s
__  ____  __  _____   ___  __ ____  ______
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2020-04-14 16:49:44,701 INFO  [io.quarkus] (vert.x-worker-thread-7) getting-started 1.0-SNAPSHOT (powered by Quarkus 1.3.0.Final) started in 0.074s. Listening on: http://<IP_ADDRESS>:8080
2020-04-14 16:49:44,701 INFO  [io.quarkus] (vert.x-worker-thread-7) Profile dev activated. Live Coding activated.
2020-04-14 16:49:44,702 INFO  [io.quarkus] (vert.x-worker-thread-7) Installed features: [cdi, resteasy]
2020-04-14 16:49:44,702 INFO  [io.qua.dev] (vert.x-worker-thread-7) Hot replace total time: 1.130s

which seems to have detected the change and recompiled the application.
So main question is why is one different from the other?

@skoh7645 does the codewind software contain appsody in itself? If so, is what version? The quarkus stack employs quite new feature: multiple deps mounts. I think that may be causing issues.
[{volume appsody-controller-0.3.4 /var/lib/docker/volumes/appsody-controller-0.3.4/_data /.appsody local z true }
 {bind  /home/mvasek/codewind-data/my-java-quarkus /project/user-app   true rprivate}
 {volume my-java-quarkus-deps /var/lib/docker/volumes/my-java-quarkus-deps/_data /project/user-app/target;/home/quarkus/.m2 local z true }]

Note that /project/user-app/target;/home/quarkus/.m2.

@matejvasek Yes Codewind does bundle appsody with it.  We saw this in Codewind dev branch using the latest 0.6.0 release of appsody

@matejvasek We did notice that currently Codewind 0.9.0 is using Appsody 0.5.8 with the 0.3.0 Quarkus stack (this stack requires at least Appsody 0.6.0). However, when we used an older version of the Quarkus (which does not require the latest Appsody version) we still saw this issue. We do not think it is a problem with the Appsody CLI version as older versions of the Quarkus stack shows the same issue when using Codewind.

What does docker inspect -f '{{ .Mounts }}' PROCID return?

In my running container stared by codewind I have:
[
    {bind  /Users/stevengroeger/codewind-data/test-quarkus /project/user-app   true rprivate
    } {volume appsody-test-quarkus-20200415154851.61601840 /var/lib/docker/volumes/appsody-test-quarkus-20200415154851.61601840/_data /project/user-app/target local z true
    } {volume appsody-test-quarkus-20200415154851.61635870 /var/lib/docker/volumes/appsody-test-quarkus-20200415154851.61635870/_data /home/quarkus/.m2 local z true
    } {volume appsody-controller-0.3.4 /var/lib/docker/volumes/appsody-controller-0.3.4/_data /.appsody local z true
    }
]

I have noticed one difference between running this locally and within codewind.
When running locally the bind mount for /project/user-app within the container is to the project directory, so in my case it is /Users/stevengroeger/projects/test-quarkus.
Whereas with codewind, even though my project was specified to be created in the /Users/stevengroeger/projects/test-quarkus directory, Codewind seems to copy the project code to /Users/stevengroeger/codewind-data/test-quarkus (which is hidden from the user) and  the container has the bind mount to this directory.
So with the latter, when the code is changed in the project directory, Codewind copies the changed files to the codewind-data directory. The container should pickup those changes and the quarkus hot replace should get triggered, but for some reason when this happens the container gets the changed file but quarkus ends up doing "[io.quarkus] (Quarkus Shutdown Thread) Quarkus stopped"

When running watch -n 0.1 docker exec -ti PROCID lsof -i :8080,5005 I noticed that appsody run doesn't kill the java process (the same pid is displayed), but with codewind it seems that the process is restarted when code is changed.

Ah yes, I meant to say. I noticed the following in the original report:
[Container] [ERROR] Port 5005 in use, not starting in debug mode
Which suggests that multiple versions of Quarkus could be running.

When I manually copy java file from project to the codewind-data directory the code his hot swapped. What else is codewind doing beside copying files when a change is detected?

Just FYI, this is where Codewind does the writing out of files: https://github.com/eclipse/codewind/blob/master/src/pfe/portal/routes/projects/bind.route.js#L173

Looks like quarkus doesn't like modification of pom.xml while mvn quarkus:dev.

I think this could be possibly fixed by selective updating, I mean upload/update only files that has been really changed.

@matejvasek So are you saying that when you change GreetingResource.java, you see the pom.xml file is also getting uploaded? That's actually strange...

Let me check.

When I changed just the GreetingResource.java file then pom.xml was also updated in the codewind-data. Checked by watch -n 0.1 stat pom.xml

Of course ideally quarkus should survive changes of pom.xml too.

Thanks for confirming that @matejvasek.  We'll take a look on Codewind side why we seem to be uploading the pom file when it's unchagned.

I can also confirm that if I change the GreetingResource.java in my project directory, that file gets updated in the codewind-data directory as well as the pom.xml, but the pom.xml does not get updated in the project directory.
I can also confirm that when running the quarkus stack with appsody run (not using codewind) and I modify the pom.xml, then the stack crashes and restarts same as when running under codewind.
So we have 2 issues here:
1: quarkus stack doesn't handle hot replace of pom.xml
2: codewind updates pom.xml even if it hasn't changed when other files are changed.
If #2 was fixed then I think that the hot replace for quarkus would work 95% of the time. It could be documented that modifying pom.xml will need a rebuild/restart of the container (until the quarkus stack can handle hot replace of pom.xml)

There could be some reason Codewind is copying the pom (tho I can't imagine why at the moment).  I'll check with the team and work through that in https://github.com/eclipse/codewind/issues/2657

Ok, I found a potential fix for the pom issue in Codewind, see https://github.com/eclipse/codewind/issues/2657#issuecomment-614635378
Basically, the pom was not uploaded everytime, but it was in temp staging dir in PFE and the project is copied to codewind-data when any file change and upload occurs.

We have put in a fix on Codewind side to preserve the pom timestamp, and that appears to make Quarkus happy.

Good news :-)
Do you still see a problem in that "Quarkus stack doesn't handle hot replace of pom.xml"? If so, I can take a look.

Yes, if I modify the pom directly it will crash

@makandre when you say it 'crashes', do you mean it restarts the full server? Other than looking odd, do you experience any problems?
I believe this behaviour is intentional for Quarkus. Given how quickly Quarkus boots we are quite aggressive about how much is restarted on code changes. It's also simpler and safer to do fuller restarts.
I created a simple application from https://code.quarkus.io/ (without Appsody, to help isolate the behaviour), then ran it with: ./mvnw compile quarkus:dev
You will see:
OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
Listening for transport dt_socket at address: 5005
__  ____  __  _____   ___  __ ____  ______
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2020-04-17 16:24:18,862 INFO  [io.quarkus] (main) code-with-quarkus 1.0.0-SNAPSHOT (powered by Quarkus 1.3.2.Final) started in 0.749s. Listening on: http://<IP_ADDRESS>:8080
2020-04-17 16:24:18,873 INFO  [io.quarkus] (main) Profile dev activated. Live Coding activated.
2020-04-17 16:24:18,873 INFO  [io.quarkus] (main) Installed features: [cdi, resteasy]

I then did a touch pom.xml to simulate a code change of the pom.xml. You will notice the following, which shows a full reload of the server. I think this is expected for pom.xml changes as there's a lot that can change in there (e.g new dependencies).
[ERROR] Port 5005 in use, not starting in debug mode
Debugger failed to attach: handshake failed - connection prematurally closed
2020-04-17 16:24:59,820 INFO  [io.quarkus] (Quarkus Shutdown Thread) Quarkus stopped in 0.002s
OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
__  ____  __  _____   ___  __ ____  ______
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2020-04-17 16:25:01,908 INFO  [io.quarkus] (main) code-with-quarkus 1.0.0-SNAPSHOT (powered by Quarkus 1.3.2.Final) started in 0.698s. Listening on: http://<IP_ADDRESS>:8080
2020-04-17 16:25:01,909 INFO  [io.quarkus] (main) Profile dev activated. Live Coding activated.
2020-04-17 16:25:01,910 INFO  [io.quarkus] (main) Installed features: [cdi, resteasy]

I then did a touch src/main/java/org/acme/ExampleResource.java to simulate a Java code change, and visited http://<IP_ADDRESS>:8080/ (source code changes are live reloaded on request). This resulted in the following hot replace. I'm not sure how much of the server was restarted this time (maybe less than when the pom.xml changed):
2020-04-17 16:26:34,005 INFO  [io.qua.dev] (vert.x-worker-thread-0) Changed source files detected, recompiling [/Users/paul/tmp/quarkus/code-with-quarkus/src/main/java/org/acme/ExampleResource.java]
system modules path not set in conjunction with -source 11, line -1 in [unknown source]2020-04-17 16:26:34,294 INFO  [io.quarkus] (vert.x-worker-thread-0) Quarkus stopped in 0.012s
__  ____  __  _____   ___  __ ____  ______
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/
2020-04-17 16:26:34,427 INFO  [io.quarkus] (vert.x-worker-thread-0) code-with-quarkus 1.0.0-SNAPSHOT (powered by Quarkus 1.3.2.Final) started in 0.020s. Listening on: http://<IP_ADDRESS>:8080
2020-04-17 16:26:34,427 INFO  [io.quarkus] (vert.x-worker-thread-0) Profile dev activated. Live Coding activated.
2020-04-17 16:26:34,427 INFO  [io.quarkus] (vert.x-worker-thread-0) Installed features: [cdi, resteasy]
2020-04-17 16:26:34,428 INFO  [io.qua.dev] (vert.x-worker-thread-0) Hot replace total time: 0.423s

This all looks right to me, except the [ERROR] Port 5005 in use, not starting in debug mode message after touching the pom.xml which seems a bit odd. However, that occurs before the shutdown occurs, not on the new startup.
I tested that the debugger port is available after the restart, and it is. I was able to use the debugger. However, I did need to re-connect the debugger which might be a bit irritating. Although, the debugger does stay attached when a Java code change is live-reloaded.

Hey @paulrobinson, yes that is exactly what I see.
I guess it is that ERROR message that made me think it crashed (and also the error appears on every other edit of the pom file)
[Container] [ERROR] Port 5005 in use, not starting in debug mode
[Container] Debugger failed to attach: handshake failed - connection prematurally closed

@paulrobinson I think the problem is when pom.xml and some java source is updated simultaneously.
The restart itself isn't probably bad thing, but it looks like it causing quarkus to miss that java source has been changed too. However I doubt that simultaneous update of pom.xml and java src happens often in practice.

Aha! I think I reproduced with:
gsed -i 's/YYY/ZZZ/g' ./src/main/java/org/acme/quickstart/GreetingResource.java; touch pom.xml

I then visited http://<IP_ADDRESS>:8080/hello and 'YYY' was returned, despite the code looking like:
    @GET
    @Produces(MediaType.TEXT_PLAIN)
    public String hello() {
        return "ZZZ";
    }

I refresh http://<IP_ADDRESS>:8080/hello over and over, and I still get YYY. After I touch src/main/java/org/acme/quickstart/GreetingResource.java the code does reload.
So looks like we've found an edge-case where live code reload doesn't work. I'll probably file a Quarkus issue shortly (I need to finish for the day now).

@paulrobinson Did you raise a Quarkus issue for this live core reload issue?
If so, can you link the issue here so we can track it and retest this issue once it has been resolved.
Thanks

@groeges Sorry, I never actually got around to reporting the issue. However, it seems fixed in Quarkus 1.5.0.Final. I've just tried to reproduce it now, and I can't.
Can you verify with your scenario?

@paulrobinson Thanks. I retested this issue with the latest version of Codewind and Quarkus stack and everything seems to be working OK now. Will close this issue.

Thanks, good to know!


become no_std compatible

Hi there!
I noticed the crate could be made no_std compatible easily enough.
Some tests do depend in std so I added a feature to make it optional.
I also fixed a couple warnings. I hope you like it.
Please feel free to change anything as you prefer.

Hello @joseluis :wave:
no_std  compatibility is a nice addition.
I made the std feature a default feature, so that future "std-only" API additions are present by default.
I will merge this PR soon. Thank you for your contribution :heart:


platform: remove re-definition of mmsghdr for Android targets

Description: remove Android flag that caused re-definition issues with Android's ndk for mmsghdr.
Risk Level: low given Envoy Mobile is the only active, well-known Android target for Envoy.
Testing: built Envoy Mobile for Android successfully.
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

Chatted with @danzh2010 in #envoy-udp-quic-dev

The aws_lambda_filter_integration_test seems to be flaky from inception per https://github.com/envoyproxy/envoy/pull/10398#issuecomment-600405192. I am going to merge here in spite of the mac os failure.


Use gosec v2.14.0 to prevent breakage

What does this PR do?

Applies latest version which does not require golang 1.19, so that this CI check does not break during module install.
Which issue(s) does this PR fix

part of devfile/api#1021
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

Open new test/doc issues under the devfile/api repo
Check each criteria if:
There is a separate tracking issue. Add the issue link under the criteria
or
test/doc updates are made as part of this PR
If unchecked, explain why it's not needed

[ ] Unit/Functional tests

[ ] QE Integration test

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer

/retest

blocked by #1036


Check for multiple thundra libs

Pull Request Test Coverage Report for Build 53ecbc6a-3303-482b-a572-85e44c541556

0 of 0   changed or added relevant lines in 0 files are covered.
14 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 66.894%

Files with Coverage Reduction
New Missed Lines
%

dist/index.js
14
57.14%

Totals

Change from base Build 22726a6a-a67e-4e47-b258-dfd73e62fd30:
-0.08%

Covered Lines:
1238

Relevant Lines:
1747

💛  - Coveralls


Support custom reactive functions for reactivity rule

Fix #112

Thank you for this PR and your patience! Though this isn't the approach I'd like to use in the long-term, I'd like to merge this to alleviate this pain point in the short-term. I don't expect many users to need it, given the use* and create* escape hatches, but no harm done in having it.


Unification against set domain values

This PR implements unification for sets.
Two cases are covered:

two concrete sets
one concrete set and one framed set

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

Jenkins: test this please

Jenkins: test this please

Jenkins is failing because some files are out-of-date with respect to the style guide:
./scripts/check-stylish-haskell.sh \
	src/main/haskell/kore/app \
	src/main/haskell/kore/src \
	src/main/haskell/kore/test
Found dirty files:
 M src/main/haskell/kore/src/Kore/Builtin/Set.hs
 M src/main/haskell/kore/src/Kore/Step/Simplification/AndTerms.hs
 M src/main/haskell/kore/test/Test/Kore/Builtin/Set.hs
Makefile:45: recipe for target 'check' failed


2024-10-15_01-35-19_master-next_aws-cli

Automatically created.

Successfully created backport PR for kirkstone-next:

#9940

Successfully created backport PR for scarthgap-next:

#9941

Successfully created backport PR for styhead-next:

#9942


Indirect github.com/imdario/mergo dependency breaks builds when using<EMAIL_ADDRESS>

What happened?
We have an indirect dependency on github.com/imdario/mergo via github.com/crossplane/crossplane-runtime. As the version of mergo was raised to v1.0.0 and the module name was changed to dario.cat/mergo it breaks our build now.
I already saw that you updated to<EMAIL_ADDRESS>Please could you release a new version of crossplane/crossplane-runtime with the updated mergo version?
github.com/imdario/mergo<EMAIL_ADDRESS>parsing go.mod:
module declares its path as: dario.cat/mergo
but was required as: github.com/imdario/mergo
What environment did it happen in?
Crossplane version: v0.19.2
Cloud Provider: IONOS Cloud

Currently fixed on our side. Updated webdevops/go-replace to 22.10.0 as it then does not resolve to 1.0.0.
Still an update of the library in crossplane would be good.


add more example tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 8 (25.0%)  changed or added relevant lines in 2 files are covered.
14 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.6%) to 51.991%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

jwk/jwk.go
2
4
50.0%

jws/jws.go
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

internal/jsonutils/decode.go
2
0%

jwk/jwk.go
12
55.66%

Totals

Change from base Build<PHONE_NUMBER>:
1.6%

Covered Lines:
666

Relevant Lines:
1281

💛  - Coveralls


JAMES-3658 LocalResourcesImpl should public constructor

In order to easier for reusable

04:58:50,054 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) on project james-server-spring-app: Failed to install metadata org.apache.james:james-server-spring-app:3.7.0-SNAPSHOT/maven-metadata.xml: Could not parse metadata /home/jenkins/.m2/repository/org/apache/james/james-server-spring-app/3.7.0-SNAPSHOT/maven-metadata-local.xml: in epilog non whitespace content is not allowed but got c (position: END_TAG seen ...</metadata>\nc... @21:2)

definitely not your fault... is there a maven issue on the CI?


Fix foldMapDefaultL

Previously,
foldMapDefaultL singleton [1, 2] = [2, 1]

This commit fixes this:
  foldMapDefaultL singleton [1, 2]
= foldMapDefaultR singleton [1, 2]
= [1, 2]

Thanks! Can you please add a short test using your example?

This is maybe a bit controversial. It trims the code down and detects more defects though, as far as I can tell.

Can you please explain the change? Thanks!

Previously

Only the instance of Array was tested. The refactoring should make it trivial to add tests for Maybe's instance as well, which is currently untested AFAIK.
foldMap (and its implementations in terms of foldr and foldl) was tested with a commutative monoid only, namely Additive Int. This is why the tests didn't detect that f x <> y should've been y <> f x (or vice-versa, I don't remember now). I changed the tests so that the properties can be tested for any monoid, in particular for Array a itself, which is non-commutative.
the tests for the default implementation don't really need newtypes with different instances, because we need to check foldMap = foldMapDefaultL = foldMapDefaultR (and the other laws) laws anyway.

Do you mean that I should've added a few comments?

Do you mean that I should've added a few comments?

No, sorry, I was just being lazy.

It's not clear to me why a lot of the Foldable test data types were removed.
Also, I didn't write these tests, so I'm not familiar with them. I'd prefer to just merge what you had for now, and make a patch release, and then make a separate PR with the new tests.
Thanks!

Thanks!

Alright then. I've added the example from the original fix as test instead.
You don't really need the new types to test the default implementations. Instead, you can just call e.g.foldMapDefaultL directly, instead of first wrapping them in a newtype and then calling foldMap.

Btw, there are quite a few more untested funtions -- for example, the Maybe instance is not tested at all. Is there interest in expanding the test suite?


Suggested CLI for Discussion

Suggested CLI for vulndb tool
(moved from the original repo)
Generic Options
--help = help for the current sub command
-v, -vv = verbose output, if any is provided - print output as logs.
--file = output file name
-o, --output-format = output format (table, json, cyclone-dx-json)
Commands
ingest
ingest data from various sources into vulndb database
version
Displays software version, database schema version, update date for each data source (none if not included)
sub commands:
nvd,
osv (I sugget that the command is vulndb ingest nvd/osv)
Flags:
--nvd-api-key
--limit (for experimentation, default - none)
--offset (for experimentation, default - 0) (Note: I'm not sure this is needed)
--update-only
--osv-sources pypi/maven/.... default - all
purl-cves
Retrieve CVE vulnerabilities for purl or a list of purls
Flags:
--input-file = input file. if this flag is used it overrides input given as arguments
--input-file-format = raw-list, cycloneDX-json default raw-list
--min-level = minimum severity level (low, medium, high, critical) default - low
--package-managers = pypi,maven (a list), default to all
--from-date = inlude only new vulnerabilities published after from-date
--include-non-nvd = include non NVD vulnerabilities (from OSV) default - false
cve-lookup
Retrieve PURLs that are affected by the CVE (according to the OSV database)
Flags: As for the purl-cves command
In the case of output format cycloneDX, the purls will be added as components + linked to the vulnerabilities in the vulnerabilities section.
sbom-vulnerabilities
Add a vulnerabilities section to a CycloneDX SBOM
Command format: vulndb sbom-vulnerabilities
Notes:

command should update the SBOM tool section and the SBOM identifier.
command can be made redundant - the capability can be provided by the purl-cve command (input and output formats of cycloneDX)

search (optional)
Text search on all fields.
vulndb search 'query'
query can include SQL wildcard %

lingo: cyclonedx-json
output: output as json or table should be hierarchical
[output json is missing]
Ingest: remove limit and offset, default to update and flag for not updating.
purl-cves:
detect format (if not cyclonedx then raw list) - wei will add it to his flask PR.
purls affected by cve: only output as raw list, the cyclonedx does not make sense.
sbom-vulnerabilities - this is not a separate command - when running purl-cves with input format and output format cyclonedx then sbom patching will be preformed.
search: remains optional.
need an additional command to dictate if tool is run as cli or service - to be done by Wei or Frederick


Simplify building of requestFactory

Clients have to provide a requestFactory to the NakadiClient, which can handle authorization and problem-responses.
final SimpleClientHttpRequestFactory requestFactoryDelegate = new SimpleClientHttpRequestFactory();
final ProblemHandlingClientHttpRequestFactory problemHandlingRequestFactory = new ProblemHandlingClientHttpRequestFactory(requestFactoryDelegate, objectMapper);
final ClientHttpRequestFactory requestFactory = new AuthorizedClientHttpRequestFactory(problemHandlingRequestFactory, () -> "MY_ACCESS_TOKEN");

As both is mandatory when communicating with nakadi it would be great if fahrschein could offer an easy way to wrap a client's requestFactory.

I introduced this in the latest commit of PR #18
https://github.com/zalando-incubator/fahrschein/blob/close-http-components/src/main/java/org/zalando/fahrschein/ClientHttpRequestFactoryHelper.java
I don't like the name though, especially as we discussed having no "helpers" or "utils" so far :)

We could hide this in a NakadiClientBuilder like this:
client = NakadiClient.Builder.for("https://my.nakadi.zalan.do")
    .withBackoff(new ExponentialBackoff())
    .withCursorManager(new PersistentCursorManager())
    .wrappingRequestFactory(new HttpComponentsRequestFactory())
    .build();

ExponentialBackoff, inMemoryCursorManager and SimpleRequestFactory can be defaults.

One complication is that the ManagedCursorManager itself needs a ClientHttpRequestFactory, so once you use that you again have to configure everything yourself.

Why not creating the HttpClient inside NakadiClient instead of asking the user for it? We can let the user specify the Parameters (e.g. connection and read timeouts), which then could be also coordinated with the Nakadi parameters stream_timeout, batch_flush_timeout etc.


[+[!LIVE!]+] Australian Diamonds vs Vitality Roses LIVE Streams ON TV Channel 21 September 2024

Vitality Roses tour of Australia and New Zealand: England squad, streams and how to watch live on Sky Sports
The Vitality Roses play three matches in Australia and a further three Tests against New Zealand; Jess Thirlby's England side are currently third in the world; watch every match live
The Vitality Roses are out in Australia, ready to take on the world number ones in what is sure to be a fiercely competitive, action-packed three-match test series.
Sky Sports will be broadcasting all three matches, and with potential debutants on both teams joining experienced campaigners and leaders, this is not a series to be missed.
Read on to find out all the details about how you can watch, and whilst you wait patiently for the matches to begin, you can listen to Vitality Roses Head Coach Jess Thirlby, along with Specialist Coaches Jo Harten and Sharni Norder, speaking on Sky’s Off The Court podcast about the team’s preparations and approach to facing the world number ones.
Game One: First Centre Pass 10 am (UK time) Thursday 19 September
Led by captain Fran Williams, the Vitality Roses will be looking to start strongly and make a statement of intent in this first game against Australia. There is plenty of exciting new talent to look out for across both teams, with Lois Pearson, Jess Shaw, Ash Ervin, Rudi Ellis and Georgie Horjus all hoping for the chance represent their country at a senior level for the first time. If she takes to court, Horjus will make her debut for the Australian Diamonds just over a month after winning the Suncorp Super Netball trophy on the very same court at the Adelaide Entertainment Centre.
Game Two: First Centre Pass 7 am (UK time) Sunday 22 September
Heading to Syndey for the second instalment of this test, fans are sure to see plenty of grit and determination out on court as the Vitality Roses battle against the Diamonds yet again on their home turf. If there is one Vitality Rose who is very used to playing in Sydney, it’s Helen Housby who plays her club netball with the New South Wales Swifts in Sydney. Vitality Roses fans will be hoping to see more of her powerful leadership and slick shooting skills on display during this series.
Game Three: First Centre Pass 10 am (UK time) Wednesday 25 September
The final match in this three-match series sees the Vitality Roses travel to Bendigo, where they will take to court against the Australian Diamonds in what (depending on the results of the first two matches) could turn out to be a series-deciding match. Who will lift the coveted trophy at the end of these 60 minutes? You’ll have to wait and watch to find out!
Where can I watch?
The match will be broadcast on Sky Sports Mix and Sky Sports YouTube.


lang: Require IdlCreateAccounts instruction authority to be the program authority

Problem
As mentioned in https://github.com/coral-xyz/anchor/issues/444#issuecomment-957056279, IdlCreateAccounts instruction is permissionless, meaning anyone can claim the IDL authority of a program if it hasn't yet been claimed:
https://github.com/coral-xyz/anchor/blob/be3ab9902fe6657c470317caf63faf2a566d690b/lang/syn/src/codegen/program/idl.rs#L39-L41
Summary of changes
Require from account of IdlCreateAccounts to be the program authority.
Note: This only changes the initial IDL creation instruction authority, meaning any existing IDL authority won't be affected by this change. Ideally, the IDL authority and the program deploy authority should be the same, but given that could break existing programs, it makes more sense to only let the IDL account be initialized by the program deploy authority.
Resolves https://github.com/coral-xyz/anchor/issues/444

looks good!


Add number input support.

Number inputs are currently not supported.
These are a input type available in Modals.
I am a rank amateur and this PR definitely isn't the final solution.
This is merely the minimum amount of code that I needed to get a number_input element working for my application.
In particular:

I couldn't figure out how to get min value and max value to accept int / float arguments, yet output str in the final output. The Slack API docs specify that both min_value and max_value must be strings.
I am not sufficiently familiar with Pydantic to implement the validation that min_value < max_value as required by the Slack API docs.
I haven't written any tests for this.

Hey! Thanks for the contribution. Your changes will be available in the next release of the library.


Bump bazeldnf to 0.5.6

What this PR does / why we need it:
Bazeldnf 0.5.6 will make dependency management easier since it now pulls in prebult binaries and does no longer have to build the binary.
This should avoid two problems:

Previously we had to integrate bazeldnf golang dependencies which was error prone
Updating gazelle was blocked because external bazeldnf dependencies are no longer resolvable with latest gazelle versions. These versions have significant improvements but changed some default behaviour.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/retest


I am testing react native android and ios apps with appium using python and pytest. So do appcenter supports appium -python-client.If yes where is the documentation

Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

App Center only supports Appium Java, you can read more in our docs: https://docs.microsoft.com/en-gb/appcenter/test-cloud/preparing-for-upload/appium
If you want this to be a feature request please re-open with more details.


Undesirable ng-attr-disabled behavior on custom elements

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] other

Current behavior:

ng-attr conditionally sets attributes. For most attributes, including ad hoc custom attributes, this means that if the expression interpolates to a string, that attribute will be set with that string as its value. But certain attributes, such as disabled, are recognized specifically and have different behavior. On some elements (e.g. button, input, etc.) disabled is a boolean HTML attribute and valid HTML requires it be either <button disabled> or <button disabled="disabled">. And that's how ng-attr-disabled behaves. But disabled isn't a global attribute and these semantics and rules really only apply for the standard HTML elements that are specified with the standard disabled attribute.
I have defined a Custom Element that observes a disabled attribute. But due to this behavior, consumers of my Custom Element can't use ng-attr on that custom element for the disabled attribute, because instead of outputting the value they're trying to set, the string disabled always gets output instead.

Actually, it's "worse" than I originally thought. There's no way to set any other value with Angular. See final section.

Expected / new behavior:

React has some similar issues affecting support for Web Components where it attempts to provide value to developers by throwing errors when standard HTML elements and attributes are used in invalid ways in JSX. My understanding is that React now checks for a hyphen, assumes any tag with hyphen in its name is a custom element, and goes down a different path without its potentially disruptive HTML validation behavior for those.
I think it might be preferable if ngAttr and ngDisabled (among, probably, some other directives) did something similar. The enforcement of disabled="disabled" should really only apply on standard HTML elements, not on Custom Elements.
Especially since, without the draconian error handling of serving XHTML as XML (perhaps even with it, I don't recall, it's been so long), it really doesn't matter what the value is for any element. Strictly speaking, it's invalid, but practically speaking, you can write the HTML <button disabled="woooooooo!!!"> and it's handled the same in browsers as <button disabled="disabled">.
Minimal reproduction of the problem with instructions:

https://codepen.io/morewry/pen/QxqrmJ
AngularJS version: 1.6.7, 1.7.3

Browser: all

Anything else:

I get that this could be problematic since it's a change in how Angular has behaved for a long time. It's a pain for using Web Components with Angular as-is, however, because it's almost impossible to work around without changing the attribute name, since the behavior shows up in all of the following:

When using ng-attr-disabled
When using ng-disabled
When using disabled with interpolation, e.g. disabled="{{something}}"

But there's no particular reason this attribute name should have to change. The best vocabulary choice is disabled, not disable, not disabled-whatever or whatever-disabled, in part because it's familiar.

A little background:

Special handling of boolean attributes in $compile was introduced long ago in 4f78fd692.
Later, in de9464c14, boolean attributes where limited to specific elements (as the previous approach was too aggressive).
However, while boolean attributes are limited to specific elements as far as $compile's $attrs is concerned (e.g. see here), jqLite's attr —which is used by $attrs under the hood to set the attribute value— only takes the attribute name (not the element) into account.
jqLite#attr() matches the behavior of jQuery#attr().

So, I would say it is reasonable to take the element into account in attr(), but we need to keep it compatible with jQuery 😞
Thoughts @mgol, @jbedard?
It is possible to special-case $attrs.$set() to handle boolean properties more consistently, but I would rather avoid special casing if possible.

Discussed this and agreed this is an issue with jQuery. We decided it doesn't make sense to break compatiblity with jQuery atm. (If this is changed in jQuery in the future, we can reconsider.)
In the meantime, it is fairly straight forward to work around this by creating your own directive that set disabled via setAttribute() and not .attr().

Didn't think of that workaround, thanks! It necessitates more education and a habit change for consuming developers, but it'll certainly mitigate.
Do you think I should file this for jQuery? Do you happen to know if they are concerned about Web Component compatibility?

No idea about jQuery, but @mgol said he will bring it up in an upcoming meeting.
Probably doesn't hurt to open an issue on their tracker (if one doesn't exist already) :wink:

A relevant jQuery ticket has been opened: https://github.com/jquery/jquery/issues/4114.


python-language-server: 3.8 fixes + deps

Motivation for this change
I have not tested what these bumps have broken elsewhere.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Parts are already in staging-next

mhm. I suppose python3.8 should have waited until staging-next was ready?

Fixed now.


Update spa.po

Minnor fixes

I don't know why, but I can't rebase this :-(
Can you do a clean pull request? Thanks?


Generate Format using SwiftSyntaxBuilder

In preparation for some a small refactor to the formatting/leading trivia generation, this PR ports Format.swift to a file generated by SwiftSyntaxBuilder's DSL.

@swift-ci please test

Some observations I've made while tinkering on FormatFile that aren't directly related to this PR, but to the future plan of making Format responsible for generating leading trivia based on a node rather than the generated build... methods:

We can't determine requiresLeadingNewline solely based on a passed node, since it is a property of Child rather than Node
Even in collection nodes, the newline trivia attached to the elements crucially depends on the fact that the parent is a collection
_makeIndent() has to be public or at least internal to be testable (so we cannot fully abstract these internals away, but that shouldn't be much of an issue AFAICT)

My current experiments can be found here and here.
Since the node-child relationship determines most the newline-related formatting anyway, I am not entirely sure whether this approach would really be feasible. Any thoughts?
cc @ahoppen

We can't determine requiresLeadingNewline solely based on a passed node, since it is a property of Child rather than Node
Even in collection nodes, the newline trivia attached to the elements crucially depends on the fact that the parent is a collection

Since we SwiftSyntaxBuilder builds the tree top-down, I think we would pass the parent node to _leadingTrivia. That way you should be able to determine all the child properties, I believe.

_makeIndent() has to be public or at least internal to be testable (so we cannot fully abstract these internals away, but that shouldn't be much of an issue AFAICT)

You could use @_spi(Testing) like we do here: https://github.com/apple/swift-syntax/blob/6ce8c4871484da39be1e92b04ca885461c1995b0/Sources/SwiftSyntax/gyb_generated/TokenKind.swift#L315


Check if this audio is already added to RetroStudio.

[X] The audio is not already in game.

Is this for the main-menu playlist?

[X] Add to main-menu playlist.

Is this song from an old Roblox era or a sound effect?

[X] This song is from old Roblox or is a sound effect.

A link to the audio on Roblox
https://www.roblox.com/library/9745583170/
A link to the audio file to download.
https://supercubecavern.fandom.com/wiki/File:Bonetrousle.ogg
Notes
I think I did everything correctly this time. (●'◡'●)
I was originally going to upload Caramelldansen, but it ended up getting rejected two times (once original, once with higher pitch).
...I ended up getting warned for the last one.
Although, it seems like ROBLOX doesn't acknowledge Undertale audio as much as I thought they would, which is good in this case.

Im unable to download the audio file

Im unable to download the audio file

My bad. It seems to allow you to play the file when you open it up from the source link itself. I just edited the OP.

It works now


[Bug]:    not display the icons for commands in the second and later rows(mobile v1.14.16)

Describe the bug
I updated to mobile v1.14.16
Currently, the commander's custom toolbar does not display the icons for commands in the second and later rows

Relevant errors (if available)
No response
Steps to reproduce
I have tried the following with no improvement
Restarting the plugin
Restarting the application
Expected Behavior
No response
Additional context
No response
Operating system
Android

I have this issue too

Same on iOS. Probably due to the new release v1.4.16 contains the following:

iOS: Added new persistent "Hide keyboard" button to the mobile toolbar.

Affects android as well

Did some analysis:
Found that after obsidian is upgraded, the html tag in mobile-toolbar is one level indent: from
 ->
 to
 ->
 ->

Left hand side: before upgrade. Right hand side: after upgrade.

Hence replacing .mobile-toolbar-options-container to .mobile-toolbar-options-list in styles/advanced-toolbar.scss should be able to display icons in multiple rows.
To remove the "Hide keyboard" button in iOS, as
  containing the button which is a child of
. Adding .mobile-toolbar-floating-options {display:none} in some css file should work.

Same here. I'm on Android 11

.mobile-toolbar-options-container to .mobile-toolbar-options-list styles/advanced-toolbar.scss should be able to display icons in multiple rows.

Oh! I tried its steps. It works the same way on Android.

Can you elaborate on the solution a little bit? Where should we make these changes?
Because II added ‘.mobile-toolbar-floating-options {display:none}’ in CSS but multiple rows still don’t work. I am on IOS.

This is nuking my ability to use Obsidian on android. On that device, I downloaded a generic text editing app and tried replacing .mobile-toolbar-options-container with .mobile-toolbar-options-list in .obsidian/plugins/obsidian-commander/styles.css but that didn't fix the issue. I assumed styles/advanced-toolbar.scss is compiled to styles.css, no?
@Akiyam-hub did you fork, modify, and recompile this repo and transfer it to your phone?

This is my only changes. Hope it helps.
https://gist.github.com/hkw1831/2c7176cd0ff024724f9c812f706d503c

This is my only changes. Hope it helps.
https://gist.github.com/hkw1831/2c7176cd0ff024724f9c812f706d503c

This worked for me on Android. Thanks!

This is my only changes. Hope it helps.
https://gist.github.com/hkw1831/2c7176cd0ff024724f9c812f706d503c

Can confirm these three long lines also fix it on iOS. I saved the line locally as a txt file and then imported them to my vault using a Shortcut. Definitely a pain to add custom css to iOS but doable.

\u003Cdiv

Where can I find this file so that I perform the changes?

An alternate place that the css file can be placed for iOS (and presumably Android is /<vaultname>/.obsidian/snippets/mobileToolbarFix.css and then you can turn the file on in the bottom of the appearance settings in Obsidian within the css snippets section.
Adding the vault name directory in Taibo as an Added Location is new to me and a great find! Makes it pretty easy to do. (Thanks for that one)

\u003Cdiv

Where can I find this file so that I perform the changes?

A few messages up, you see:  .obsidian/plugins/cmdr/styles.css.
Make a copy of this file, like styles.css.bak and create a new one with the lines in the gist linked above, save it as styles.css and save it (in the cmdr folder).
You can do this on a PC if you have synced to your desktop or laptop or you can do it on your mobile as well, with some text editor. I mentioned Taio for iOS.

Many thanks! Managed to do it.

\u003Cdiv

Where can I find this file so that I perform the changes?

A few messages up, you see:  .obsidian/plugins/cmdr/styles.css.
Make a copy of this file, like styles.css.bak and create a new one with the lines in the gist linked above, save it as styles.css and save it (in the cmdr folder).
You can do this on a PC if you have synced to your desktop or laptop or you can do it on your mobile as well, with some text editor. I mentioned Taio for iOS.

Many thanks! Managed to do it. Copied the .css file and then renamed the extension to .md. Opened the file via Obsidian, deleted everything, then pasted the gist text onto it. Rerenamed to .css extension. Moved the file onto the cmdr folder, and the toolbar was back to work as expected.

Is there anyone that can open a pull request with this fix? I can’t before this weekend at the earliest…

Amazing work, thanks for fixing it and sharing your solution!

Thanks for this fix. Works great!

Thanks!

I submitted the PR #111 for this, new update has been merged and the issue appears to be fixed — make sure to update your day extension in Obsidian!


Update target frame tooltips and companion icons

From Rae who is still consigned to GH jail.

This project actually expanded a bit in scope when I was working on it.
The main parts of this are the following profile buttons:

Show Character
Show Companion
Show Mount

[!TIP]
These now all work with the following template:
Character/Companion/Mount (white header text)
Name (golden text, optional)

! Unread description (green, only shows when there is.. unread description)

Left-Click: Action (green)     | Click: Action (green)
Right-Click: Action (green)    |

Companions and Mounts
Both these profile buttons now also let you left click to just open their profile.
This flows better than first having to right-click and then click the first option in the list. The right-click menu still exists, however.
Companions and Mounts are now consistent with Character and have a single consistent button for the target frame:

Companions have the pet cage.
Mounts have the blue horseshoe.

Player
Target
Companion
Mount

Companion
Mount

The following buttons have been updated too:

Notes (Click has been made consistent.)
Ignore player --> Ignore character (Updated with new description of what it does.)

Notes
Ignore

[!IMPORTANT]
The following localizations were added:

TF_MORE_OPTIONS

The following localizations have been edited and require NEW translations:

TF_OPEN_CHARACTER
TF_OPEN_COMPANION
TF_IGNORE
TF_IGNORE_TT

The following localizations has been removed:

REG_LIST_CHAR_TT_NEW_ABOUT

Raenore has been delivered from the jaws of Hell and as such, we don't need the fake copy anymore.


Allow spawn on join to be forced again.

Please, add the following feature, that was present on v2, available on HuskHomes v3
spawn_command:
enabled: true
force_teleport_on_login: true

Still active?

It’s not currently a thing, mainly because it can get confusing as it doesn’t tend to work with the /server command feature. I’ll consider it at some point though

So at the moment you would not add the option to move the player to spawn if the PlayerLoginEvent is triggered? (Player joins Spigot/Paper Server)


Update tutorial notebook

Self-merging as I need this for a workshop in the morning, and this pull request is limited to the tutorials.


CaptivePortal doesn't log anything

Hi everyone,
I'm testing the captive portal of version OPNsense 16.1.1 but I'm not receiving cp-log-entries at all - neither via syslog nor as local logfile ("File /var/log/portalauth.log yielded no results.").
Best regards
Tobias

Hi Tobias,
The portalauth log file is a bit of a left over from the old code, it logs all local4 messages from syslog (which isn't only from captive portal).
All service related actions are logged into system.log at the moment, may we should filter the captive portal ones out of there and use portalauth exclusively for captiveportal.
User logins aren't logged at the moment, I will look into that.
Regards,
Ad

Added logging and changed syslog in commits https://github.com/opnsense/core/commit/9b6dc9535ccb1d8ea1d01fac6cc4e61b6f71b823 https://github.com/opnsense/core/commit/181215b2677e3ad77c5f00fc53b086da1b1db97e https://github.com/opnsense/core/commit/e1d6a690e78014a1e0db97ef5ae970a043d72391
I've asked @fichtner to add this into tomorrows release

Backported into 16.1.2 as d49d6b0e28fc652604


For the Serverless API tile a detailed explanation page is available

The contents of the page are:

detailed description of the use case
a flow diagram similar showing how logic flows

@silveyram Let's work with Thomas, Micah and @trevorbodz on the linkage from the Bluemix tile to a new Accelerate scenarios page like OpenFridge.

Tracking content in the wiki for this repository.

Done.
Accelerate page here: https://developer.ibm.com/accelerate/journey/build-serverless-api-handlers/


Tidies up the uci_wrt.c file

~Draft until #234 is merged.~
Tidies up the uci_wrt.c file.
I've added two new functions:

uwrt_set_properties()
uwrt_add_list_properties()

They look like the following:
/**
 * @brief Set multiple OpenWRT UCI properties at once
 * @param[in] ctx UCI context. The context ptr will be modified.
 * @param[in] properties Array of properties to set. Warning, strings may be
 * modified by UCI.
 * @retval  0 Success
 * @retval -1 Error
 */
int uwrt_set_properties(struct uci_context *ctx, UT_array *properties) {
  for (char *const *prop = (char **)utarray_front(properties); prop != NULL;
       prop = (char **)utarray_next(properties, prop)) {

    if (uwrt_set_property(ctx, *prop) < 0) {
      log_error("uwrt_set_property fail for %s", *prop);
      return -1;
    }
  }
  return 0;
}

Essentially, they just call uwrt_set_property/uwrt_add_list_property multiple times.
This means:

Less code reuse!
Code Coverage is happy since there are less branches.
Smaller code.
Bad news is that it's slightly slower.
(I don't think the compiler is smart enough to optimise utarray loops)

I've also quickly added a simple test for uci_wrt, just to confirm that my changes don't cause any errors.

Is it still in the draft mode?
Now that #234, I'll open it up as ready!


Move nightly Docker image to Alpine 3.13

Once support for Alpine 3.13 is complete for .NET Core 3.1 (see https://github.com/dotnet/core/issues/5687), move the Docker image to Alpine 3.13 in dotnet-docker (see https://github.com/dotnet/dotnet-docker/issues/2530)

Complete with https://github.com/dotnet/dotnet-docker/pull/2644


Increment version code

I can't say if this is correct, I lack the knowledge. I guess this is build number?


ENOENT: no such file or directory, open 'protos.json'

I'm trying to use the google cloud speech to text API.
I'm using the sample google code, and when I create the client object, I got this error.
{
   "errno":-2,
   "syscall":"open",
   "code":"ENOENT",
   "path":"protos.json",
   "stack":"Error: ENOENT: no such file or directory, open 'protos.json'\n    at Object.openSync (fs.js:440:3)\n    at Object.readFileSync (fs.js:342:35)\n    at fetch (transcript-server-js/node_modules/protobufjs/src/root.js:160:34)\n    at Root.load (/transcript-server-js/node_modules/protobufjs/src/root.js:194:13)\n    at Root.loadSync (/transcript-server-js/node_modules/protobufjs/src/root.js:235:17)\n    at Object.loadSync (/transcript-server-js/node_modules/@grpc/proto-loader/build/src/index.js:221:27)\n    at GrpcClient.loadFromProto /transcript-server-js/node_modules/google-gax/src/grpc.ts:165:40)\n    at GrpcClient.loadProto (/transcript-server-js/node_modules/google-gax/src/grpc.ts:199:17)\n    at new SpeechClient /transcript-server-js/lib/webpack:/src/v1/speech_client.ts:135:28)\n    at createText$ (/transcript-server-js/lib/webpack:/src/transcriptGenerator.js:50:18)"
}

this is the code
const speech = require('@google-cloud/speech');
const client = new speech.SpeechClient();

I got this error when I create the client.
I have added a log on the protobufjs/src/root.js file to see which files are fetched.
transcript-server-js/node_modules/protobufjs/google/protobuf/api.proto

transcript-server-js/node_modules/protobufjs/google/protobuf/google/protobuf/source_context.proto

transcript-server-js/node_modules/protobufjs/google/protobuf/descriptor.proto

transcript-server-js/node_modules/protobufjs/google/protobuf/source_context.proto

transcript-server-js/node_modules/protobufjs/google/protobuf/type.proto

protos.json

I tried to use storage api and they worked.
Where am I doing wrong?
can someone help me?
thanks

@Etto91 are you running this inside a Node.js application? Is there anything special about your environment, e.g., is it part of an angular application.

Yes..I'm using fastify. I have used it inside a docker container after that I have tried on my local machine.
i'm using webpack with babel to compile the code.

this is my webpack config
import path from 'path';
import fs from 'fs';
import webpack from 'webpack';
import NodemonPlugin from 'nodemon-webpack-plugin';

const outputServerPath = path.resolve('./lib/server.js');
const nodeModules = {};
fs.readdirSync('node_modules')
  .filter(x => ['.bin'].indexOf(x) === -1)
  .map(mod => {
    nodeModules[mod] = `commonjs ${mod}`;
    return mod;
  });

const serverFile = {
  mode: process.env.NODE_ENV === 'production' ? 'production' : 'development',
  devtool: 'inline-source-map',
  entry: {
    server: './src/server.js'
  },
  output: {
    path: path.resolve(__dirname, 'lib'),
    filename: '[name].js',
    publicPath: '/dist/'
  },
  node: {
    __dirname: false,
    fs: 'empty'
  },
  target: 'node',
  externals: nodeModules,
  plugins: [
    new webpack.BannerPlugin({
      banner: 'require("source-map-support").install();',
      raw: true,
      entryOnly: false
    }),
    new webpack.DefinePlugin({
      NODE_ENV: JSON.stringify(process.env.NODE_ENV || 'development')
    }),
    ...(process.env.NODE_ENV !== 'production'
      ? [
          new NodemonPlugin({
            watch: outputServerPath,
            script: outputServerPath
          })
        ]
      : [])
  ],
  watchOptions: {
    ignored: /tests/
  },
  module: {
    rules: [
      {
        test: /\.js$/,
        loader: 'babel-loader'
      }
    ]
  }
};

module.exports = [serverFile];

@Etto91 if you're going to use @google-cloud/speech in the context of WebPack, there area . few additional steps. You can find a conversation related to getting our libraries up and running in a front-end context, with WebPack, here:
https://github.com/googleapis/google-cloud-node/issues/2933
Let me know if this helps 👍

thanks @bcoe  you saved my day


[ON HOLD Onyx PR #534] Fix Onyx typings across the project

Details
Follow-up PR when the changes in this PR are merged and available to use in E/App.
Fixed Issues

$ https://github.com/Expensify/App/issues/34339
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@fabioh8010 this is good to come off hold now that https://github.com/Expensify/react-native-onyx/pull/534 is merged

@roryabraham Since this PR would require an Onyx bump in E/App from v2.0.32 to v2.0.37, can I use this PR to do it? There were a lot of changes since v2.0.32, so I'm not sure how to proceed.

There was already a known regression in 2.0.33. Not sure if that was fixed already or not

I'll close this PR as we already have one Onyx bump here including these changes.


Remove EV locality lint

The proper localityName checks as set out by <IP_ADDRESS>.2 (e) on all subscriber certificates are found in e_sub_cert_locality_name_must_not_appear and e_sub_cert_locality_name_must_appear, thus this lint is not required.
This addresses #225

For reference:
	if len(c.Subject.Organization) == 0 && len(c.Subject.GivenName) == 0 && len(c.Subject.Surname) == 0 {
		if len(c.Subject.Locality) > 0 {
			return &LintResult{Status: Error}
		}
	}

and
	if len(c.Subject.Organization) > 0 || len(c.Subject.GivenName) > 0 || len(c.Subject.Surname) > 0 {
		if len(c.Subject.Province) == 0 {
			if len(c.Subject.Locality) == 0 {
				return &LintResult{Status: Error}
			}
		}
	}
	return &LintResult{Status: Pass}

BR: <IP_ADDRESS>.2 (e)
Certificate Field: subject:localityName (OID: <IP_ADDRESS>)
Required if the subject:organizationName field, subject:givenName field, or subject:surname field are present and the subject:stateOrProvinceName field is absent.
Optional if the subject:stateOrProvinceName field and the subject:organizationName field, subject:givenName field, or subject:surname field are present.
Prohibited if the subject:organizationName field, subject:givenName, and subject:surname field are absent.


Docs: implement automatic testing for broken links

https://www.npmjs.com/package/broken-link-checker


KAFKA-6106: Postpone normal processing of tasks until restoration of all tasks completed

Once all the state stores are restored, then the processing of tasks takes place. This approach will reduce the time taken to restore the state stores as single thread is used to restore the state and process the task.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

\cc @bbejeck @vvcephei

@mjsax Feel free to merge if you are comfortable with the latest changes.

@kamalcph Can you please rebase this PR to resolve the conflicts? Thanks!

@mjsax Rebased with trunk now.

Merged to trunk and cherry-picked to 1.1 branch.
Cherry-picking to older branches was not easy. If we want to backport it, we should need a new PR. \cc @guozhangwang

@dguy If RC for 1.1 does not pass, we would need to update the JIRA board with fixed version 1.1.0 instead of 1.1.1.


Status bar hides app bar on mobiles

We should integrate https://github.com/apache/cordova-plugin-statusbar to control the behaviour.

Using  https://github.com/apache/cordova-plugin-statusbar fix the issue
This is more an issue related to the apps :
[ ] https://github.com/kalisio/kApp/issues/91
[ ] https://github.com/kalisio/aktnmap/issues/129


If I only have one GPU, how should I set the training parameters?

As mentioned, I only have one RTX 4080, and I want to replicate the paper's results as closely as possible. I'm unsure about the optimal training parameter settings as I've noticed that training takes a considerable amount of time. Do you have any prior knowledge or recommendations? This would greatly help me save time!

python tools/train_net.py --num-gpus 1 --dist-url='tcp://<IP_ADDRESS>:52125' --resume --config-file ./configs/OWOD/t1/t1_train.yaml SOLVER.IMS_PER_BATCH 1 SOLVER.BASE_LR 0.0025 OUTPUT_DIR "./output/t1"
try it bro