Have question about the WaveNet Causal Conv

Hi, thanks for the great repo. I have a question here.
The line 110 in Tacotron-2/wavenet_vocoder/models/modules.py shows:
cropped = tf.slice(outputs, [0, 0, crop], [-1, -1, -1])
I think it should be
cropped = tf.slice(outputs, [0, 0, 0], [-1, -1, new_shape[0]-crop])
Am I right?

https://github.com/Rayhane-mamah/Tacotron-2/blob/e2f9780b18648b8d0b671e1c85dd95d20d6f8553/wavenet_vocoder/models/modules.py#L62-L87
Padding is added to the left. Therefore, cropping out left seems like valid.

Hello @liusongxiang, @a3626a answer is perfectly correct. i hope this answers your question.
You can refer to fast wavenet official implementation for more insight about this. Feel free to reopen the issue if needed. :)


Exports only one search result

i tried to export with the following POST
http://localhost:9200/_export/?path=/tmp/elasticsearch/test.bulk
{
"query": {
"filtered": {
"query": {
"match": {
"environment": "beta"
}
},
"filter": {
"range": {
"@timestamp": {
"gte": "2015-04-29T00:00:00.000Z",
"time_zone": "+8:00"
}
}
}
}
},
"fields": [
"message"
]
}
It always export only the first result. if i remove the search query, it exports all data properly

Does the query in POST export request supports elasticsearch full query DSL?

Check if
curl -XPOST 'http://localhost:9200/_search' -d '
{
    "fields": [
        "message"
    ],
    "query": {
        "filtered": {
            "filter": {
                "range": {
                    "@timestamp": {
                        "gte": "2015-04-29T00:00:00.000Z",
                        "time_zone": "+8:00"
                    }
                }
            },
            "query": {
                "match": {
                    "environment": "beta"
                }
            }
        }
    }
}
'

gives the required total hits.

still the same...has only one hit

If _search gives one hit, Knapsack also can get only one hit.

yes of course..._search gives 1091 hits but knapsack exports only one

I also get this exact behaviour. Did you solve it in the end?
proof:
curl -XPOST 'localhost:9200/scf/doc/_export?path=/tmp/export.bulk&overwrite=true&pretty=true' -d '{
   "query" : {
       "match" : {
           "SerialNumber" : "480417204"
       }
   },
   "fields" : [ "_id", "url" ]
}'

However the export only has 1 result :
cat /tmp/export.bulk
{"index":{"_index":"scf","_type":"doc","_id":"http://farm6.staticflickr.com/5056/5521728468_7a187ba9bc_o.jpg"}
http://farm6.staticflickr.com/5056/55 21728468_7a187ba9bc_o.jpg

Changing the command to search instead of export proves that the same query should return 212 results (output truncated) :
curl -XPOST 'localhost:9200/scf/doc/_search?path=/tmp/export.bulk&overwrite=true&pretty=true' -d '{
   "query" : {
       "match" : {
           "SerialNumber" : "480417204"
       }
   },
   "fields" : [ "_id", "url" ]
}'
{
  "took" : 9,
  "timed_out" : false,
  "_shards" : {
    "total" : 5,
    "successful" : 5,
    "failed" : 0
  },
  "hits" : {
    "total" : 212,
    "max_score" : 12.048178,
    "hits" : [ {
      "_index" : "scf",
      "_type" : "doc",
      "_id" : "http://mattburns.co.uk/images/0.jpg",
      "_score" : 12.048178,
      "fields" : {
        "url" : [ "http://mattburns.co.uk/images/0.jpg" ]
      }
    }, {
      "_index" : "scf",
      "_type" : "doc",
      "_id" : "http://mattburns.co.uk/smiletapper/resources/unhappy/15.jpg",
      "_score" : 12.048178,
      "fields" : {
        "url" : [ "http://mattburns.co.uk/smiletapper/resources/unhappy/15.jpg" ]
      }
    }
[...snip...]

As an update I figured out a solution that works for me... all results are returned if I don't specify the "fields" I want. But I can still achieve the same thing by passing in the _source instead. See https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-get.html#get-source-filtering
In short, just change "fields": [ to "_source": [ in your request.


Use std::optional for optional objects in C++17

I just tried quicktype for parsing schema supporting optional fields in C++, and noticed it uses std::shared_ptr for these fields. C++17 introduced std::optional which is closer than std::shared_ptr to the "optional value" notion, hence I think it should be used on demand instead of std::shared_ptr. Furthermore, std::optional doesn't need to allocate memory on nlohmann::adl_serializer<std::optional<T>>::from_json as oposed to std::shared_ptr. There is already a Require a dependency on boost. Without boost, C++17 is required switch, so the changes to implement should be relatively small.

Browsing the source code of quicktype, I found a note explaining why boost/std optional aren't the best choice for usage with Json. I still think std::optional is a better choice here because it avoids dynamic allocation and isn't required to offer thread-safe operations, which result in extra overhead when not needed. Hence, I think it would be better if quicktype's interface would offer an option to use optional or shared_ptr as needed: When one is sure no forward-declared data type exists and/or don't want thread safety by default, they can enable the "use optional" flag. Otherwise, fall back to shared_ptr. For compatibility, I think this flag should be off by default (aka. use shared_ptr by default).

Probably a good idea for someone with sufficient privileges to add the "C++" label to this issue! :)

This is currently being implemented. I've created a discussion thread and there was a PR concerning the issue. Currently still looking for it.

Here it is :)


add docker- to sys-mgmt-agent-go target

Signed-off-by: Ernesto Ojeda<EMAIL_ADDRESS>

Codecov Report

Merging #1589 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1589   +/-   ##
=======================================
  Coverage   26.85%   26.85%
=======================================
  Files         105      105
  Lines        9714     9714
=======================================
  Hits         2609     2609
  Misses       6924     6924
  Partials      181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1996e...432a871. Read the comment docs.


test: create and deploy new account

Following workflow should be investigated:

Creating account smart contract
Creating account in wallet
Declaring account
Deploying account

Therefore, following issues should be solved:

[ ] https://github.com/eigerco/beerus/issues/717
[ ] https://github.com/eigerco/beerus/issues/718

hey @ICavlek I would like to onboarding on this project and to tackle this issue

hey @ICavlek I would like to onboarding on this project and to tackle this issue

Hi @jrmncos, you can apply for the open positions at the company's website:
https://www.eiger.co/company#positions

thanks @ICavlek I'll do it, but, can I take the issue in the meanwhile?

thanks @ICavlek I'll do it, but, can I take the issue in the meanwhile?

Issue assignments are only for employees by Eiger and I am currently working on this one. If you want to introduce specific changes, create a PR and we will review it.

oh, got it, I though that I could ask for any issue, just to confirm, with this one is the same right? https://github.com/eigerco/beerus/issues/684 or can I create a PR with the changes?
In any case, I will apply :)

oh, got it, I though that I could ask for any issue, just to confirm, with this one is the same right? #684 or can I create a PR with the changes?
In any case, I will apply :)

It's the same, you won't be assigned to any issue, but you can work on it and create a PR for it


make_torch_dataloader using TransformSpec applies transformation on entire dataframe (not lazy loading)

Since my dataset (Nsynth dataset by Magenta Google) has really big size because of many audio files present and it can't be fully loaded in memory, I'm trying to lazy loading it.
Currently I'm loading a JSON in a dataframe containing path to audio files and some other midi data (pitch, velocity and sammple rate) in order to synth audio from them. So I have a dataframe with the following schema:

note_str
pitch
velocity
sample_rate

guitar_acoustic_01_C3.wav
89
50
16000

guitar_acoustic_02_F2.wav
41
127
16000

guitar_acoustic_03_A#5.wav
106
127
16000

...
...
...
...

So my idea is to use as TransformSpec a function which loads the audio files and also make the audios from midi and returns the following: spectrogram from original audio, spectrogram from synth audio, phase from original audio, phase from synth audio.
The problem comes when I use:
with converter_train.make_torch_dataloader(transform_spec=get_transform_spec(training=True), batch_size=64, workers_count=1) as train_dataloader:
    train_dataloader_iter = iter(train_dataloader)
    trainer.fit(model, train_dataloader_iter)

Basically when the make_torch_dataloader function runs, it fills up the memory and it seems like the TransformSpec is applied on the entire dataframe instead of lazy loading batches (in fact the only way to make it not fill up the memory and crash is to reduce the number of rows in the original dataframe).
Since I have tried different approaches and I still get the same behaviour I would like to understand the problem and be sure that my idea is right or this is the expected behaviour.

TransformSpec is applied to the entire row-group at once. Although, it's not the entire dataset, but it is likely to be pretty large, say hundreds of megabytes.

Thank you! I just realized that since my dataframe is small in size but it increase a lot after the transformation, I have to decrease the row group size in order to not fill the memory after that. In fact, as you said, it wasn't on the entire dataset but instead it was applied on the default group size (which was way too large in my case).
I share with you my solution in case it can be helpful to others in the future:
converter_train = make_spark_converter(df_train, parquet_row_group_size_bytes=avg_row_size*n)

I simply used as parameter parquet_row_group_size_bytes the number of rows n I want in a group times the average row size (computed before).


Maint

Merge #14 first. General maintenance.

Looks good! I've opened https://github.com/wasade/q2-state-unifrac/issues/21 to address macros at a later time.


Error in log

Describe the bug
An error appears frequently in my log. Anyone facing similar issue?
Debug log
Logger: custom_components.renault.renault_vehicle
Source: helpers/update_coordinator.py:166
Integration: Renault (documentation, issues)
First occurred: 6:29:41 PM (1 occurrences)
Last logged: 6:29:41 PM
Error fetching VF1xxxxxxxxx battery data: Error communicating with API: ('err.tech.wired.kamereon-proxy', 'Failed to forward request to remote service.')

That is a temporary error on the Renault side (it seems to be an error between their internet-facing servers and the backend servers) - there's nothing we can really do about it.

That is a temporary error on the Renault side (it seems to be an error between their internet-facing servers and the backend servers) - there's nothing we can really do about it.


ccoin: library code to generate Hierarchical Deterministic Wallet keys (BIP32)

Overall looks good.  One nit -- this adds several warnings to the build.  Fix the warnings and it is ready to merge.
Making all in test
hdkeys.c:119:13: warning: ‘print_n_base58’ defined but not used [-Wunused-function]
 static void print_n_base58(const void *data, size_t len)
             ^
hdkeys.c:126:13: warning: ‘print_from_base58’ defined but not used [-Wunused-function]
 static void print_from_base58(const char *str)
             ^
hdkeys.c:135:13: warning: ‘print_from_base58_key’ defined but not used [-Wunused-function]
 static void print_from_base58_key(const char *str)
             ^

Oops ... I amended the branch so I can now build it with "-Wall -Werror".
Should I add those flags to the travis script, at least for linux?


How should one use Map with a SharedFacet?

e.g., in this example:
import { Map, useFacetState } from "@react-facet/core";
import { sharedFacet, sharedDynamicSelector, useSharedFacet } from "@react-facet/shared-facet";

interface Member {
    name: string
    rank: number
    health: number
}

const membersArray = [
    {
        name: "Zeus",
        rank: 3,
        health: 90
    },
    {
        name: "Demeter",
        rank: 2,
        health: 100
    },
    {
        name: "Poseidon",
        rank: 1,
        health: 85
    }
];

const membersFacet = sharedFacet<Member[]>("data.team", membersArray);

const memberNameSelector = sharedDynamicSelector((index: number) => [
    (member) => member[index].name,
    [membersFacet]
]);

const memberRankSelector = sharedDynamicSelector((index: number) => [
    (member) => member[index].rank,
    [membersFacet]
]);

const memberHealthSelector = sharedDynamicSelector((index: number) => [
    (member) => member[index].health,
    [membersFacet]
]);

const Member = ({ index }: { index: number }) => {
    return (

            Name: <fast-text text={useSharedFacet(memberNameSelector(index))}/>

            Rank: <fast-text text={useSharedFacet(memberRankSelector(index))}/>

            HP: <fast-text text={useSharedFacet(memberHealthSelector(index))}/>

    );
};

export const Team = () => {
    // works (as expected)
    // const [membersFacetState] = useFacetState<Member[]>(membersArray);

    // does not
    const membersFacetState = useFacetState(membersFacet);

    return (
        <Map array={membersFacetState}>
            {(_, index) => <Member index={index} />}
        </Map>
    );
};

the type error returned on Map's "array" prop:
TS2322: Type
[Facet<SharedFacet<Member[]>>, Setter<SharedFacet<Member[]>>]
is not assignable to type Facet<unknown[]>
Map.d.ts(4, 5): The expected type comes from property array which is declared here on type IntrinsicAttributes & MapProps<unknown>

I've tried digging through the docs, attempting to map from a SharedFacet to a Facet (couldn't seem to get that working), so figured I'd ask here. Thanks!

ignore! feelin' silly now in hindsight, but got it working-- marking this issue as Closed
in case anyone else bumps into similar in the future, my solution:
import { Map } from "@react-facet/core";
import { sharedFacet, sharedDynamicSelector, useSharedFacet, sharedSelector } from "@react-facet/shared-facet";

interface Member {
    name: string
    rank: number
    health: number
}

interface TeamFacet {
    members: Member[]
}

const membersArray: Member[] = [
    {
        name: "Zeus",
        rank: 3,
        health: 90
    },
    {
        name: "Demeter",
        rank: 2,
        health: 100
    },
    {
        name: "Poseidon",
        rank: 1,
        health: 85
    }
];

const teamFacet = sharedFacet<TeamFacet>("data.team", {
    members: membersArray
});

const membersSelector = sharedSelector(({ members }) => members, [teamFacet]);

const memberNameSelector = sharedDynamicSelector((index: number) => [
    (members) => members[index].name,
    [membersSelector]
]);

const memberRankSelector = sharedDynamicSelector((index: number) => [
    (members) => members[index].rank,
    [membersSelector]
]);

const memberHealthSelector = sharedDynamicSelector((index: number) => [
    (members) => members[index].health,
    [membersSelector]
]);

const Member = ({ index }: { index: number }) => {
    return (

            Name: <fast-text text={useSharedFacet(memberNameSelector(index))}/>

            Rank: <fast-text text={useSharedFacet(memberRankSelector(index))}/>

            HP: <fast-text text={useSharedFacet(memberHealthSelector(index))}/>

    );
};

export const Team = () => {
    const members = useSharedFacet(membersSelector);

    return (
        <Map array={members}>
            {(_, index) => <Member index={index} />}
        </Map>
    );
};


LoadEmbedding node recognizes only the pt extension.

The safetensors extension is not recognized, and an error occurs.
Error occurred when executing LoadEmbedding:
cannot identify image file 'O:\AI\SynologyDrive\stable-diffusion-webui-SDXL\embeddings\A.safetensors'
File "O:\AI\SynologyDrive\ComfyUI-webui\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "O:\AI\SynologyDrive\ComfyUI-webui\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "O:\AI\SynologyDrive\ComfyUI-webui\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "O:\AI\SynologyDrive\ComfyUI-webui\ComfyUI\custom_nodes\ComfyUI-Chibi-Nodes\chibi_nodes.py", line 250, in loadembedding
image = Image.open(img_path)
^^^^^^^^^^^^^^^^^^^^
File "O:\AI\SynologyDrive\ComfyUI-webui\python_embeded\Lib\site-packages\PIL\Image.py", line 3298, in open
raise UnidentifiedImageError(msg)

Yes, we have an embedding in safetensors.
Maybe that's why the pt extension is normal, but the safetyensors extension is getting an error.
It's all confirmed in sd 1.5 and sdxl.

https://civitai.com/models/100191/ti-easynegativev2-textual-inversion-embedding
This link is made of safetensors.

ok, i think this has to do with the image preview i tried implementing on this node. i made a change. see how it goes. might need a rewrite at some point.


feat: cors and ephemerides

Codecov Report

Merging #27 (3c387eb) into master (5a4d5b4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          295       298    +3
=========================================
+ Hits           295       298    +3

Impacted Files
Coverage Δ

kanon_api/app.py
100.00% <100.00%> (ø)

kanon_api/core/ephemerides/ascendant.py
100.00% <100.00%> (ø)

kanon_api/core/ephemerides/true_position.py
100.00% <100.00%> (ø)

kanon_api/routes/ephemerides.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4d5b4...3c387eb. Read the comment docs.


Add Kill Options

Add Kill Options to monsters. Examples:

Number of barrows points, whether you have diary completed or not
Whether youre in task, in wildy, etc
In catacombs or not

Ring of wealth maybe not as it would probably be a big pain.

Legends Quest completion state changes rates for rare drop table items, however I think it's best to just ignore that and leave it as is for now.
flag for if the player is skulled (rev caves)
whole bunch of diary checks, however it sounds like we're ignoring those for now.

Add in current KC as option and drop tattered KQ head in KQ

Ecumenical keys, looting bags


Use isComplete() for tasks in UI

You can test it in http://labels-experiment.wmflabs.org/gadget/

Tested


go/cmd: remove redundant check for nil

Local variable err is defined with nil value and almost immediately
compared with nil. This comparison is redundant as always evaluates
to true.
Updates #30208

I opened a new pull request that contains changes from this one.
https://github.com/golang/go/pull/30226
Current request can be closed (rejected).

Please, see this comment:
https://github.com/golang/go/issues/30208#issuecomment-463359517


Per-build separation of httprox repositories

Not merge. Pls review.

ftest added

retest this please

Updated. Please review again.


Windows: CLI Improvement (TP3)

Signed-off-by: John Howard<EMAIL_ADDRESS>@swernli @brendandixon @ahmetalpbalkan @jstarks @tiborvass @icecrime
The Ansi parser and their associated actions have been decoupled. Now
parsing results in call backs to an interface which performs the
appropriate actions depending on the environment.
This improvement provides a functional Vi experience and the vttest no
longer panics.
This PR replaces the stale docker/docker #13224.

This PR is needed for the TP3 build for correct ANSI support in Windows containers. But also improves the Linux experience significantly.

@jhowardmsft just for my info; is TP3 to be presented at the same time as Docker 1.8? Wondering if these should be marked somehow to make sure they get in in time (if it's any of "our" worries here :wink:)

The current plan is that the docker daemon Windows release to support TP3 will be in 1.9.0-dev. I though we were supposed to have snapped to 1.8 earlier this week and the version bumped. I haven't seen that happen though? Certainly though, there are a few PRs which are still needed to support TP3, but we're very close now :)

With the version bump, you mean the version bump here? https://github.com/docker/docker/blob/master/VERSION (it's 1.8-dev now)

Yup, that's the one.

LGTM

LGTM

merging, its a big one but if anything goes wrong we know where to find you ;)

if anything goes wrong we know where to find you ;)

Yup. on Bing searching for Nyancats 😉🐱🐱


[4.0.0-beta 8] ion-tab color doesn't take primary color in android

Bug Report
Ionic Info
   ionic (Ionic CLI)          : 4.1.1 (C:\Users\XXXX\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.8
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.7
   @ionic/schematics-angular  : 1.0.5

Describe the Bug
In md mode, the ion-tab color doesn't take the primary color as selected tab color. However in ios it's working well.
Steps to Reproduce
Only change the chrome debugger profile to some device with md and ios.
Related Code
theme/variables.scss
  /** primary **/
  --ion-color-primary: #f185cf;
  --ion-color-primary-rgb: 72,138,255;
  --ion-color-primary-contrast: #fff;
  --ion-color-primary-contrast-rgb: 255,255,255;
  --ion-color-primary-shade: #E359B8;
  --ion-color-primary-tint: #E359B8;

tabs.component.html
<ion-tabs>
  <ion-tab icon="home" href="/tabs/(home:home)" tabsHideOnSubPages="false">
    <ion-router-outlet name="home"></ion-router-outlet>
  </ion-tab>
  <ion-tab icon="card" color="primary" href="/tabs/(offers:offers)" tabsHideOnSubPages="false">
    <ion-router-outlet name="offers"></ion-router-outlet>
  </ion-tab>
  <ion-tab icon="heart" color="primary" badge="{{$numItemsInWishList > 0 ? $numItemsInWishList : '' }}"
      href="/tabs/(wishlist:wishlist)" badgeColor="dark" tabsHideOnSubPages="false">
    <ion-router-outlet name="wishlist"></ion-router-outlet>
  </ion-tab>
  <ion-tab icon="basket" color="primary" badge="{{$numItemsInCart > 0 ? $numItemsInCart : '' }}"
      href="/tabs/(cart:cart)" badgeColor="dark" tabsHideOnSubPages="false">
    <ion-router-outlet name="cart"></ion-router-outlet>
  </ion-tab>
  <ion-tab icon="contact" color="primary" href="/tabs/(profile:profile)" tabsHideOnSubPages="false">
    <ion-router-outlet name="profile"></ion-router-outlet>
  </ion-tab>
</ion-tabs>

Expected Behavior
In md mode should take the primary color as expected.
Additional Context
IOS:

MD:

Thanks @jytx, I know how to change it, but I have reported because for me it is not the expected behaviour that in one mode changes and with the other not.

@marticrespi The developers wrote this next to the iOS Tabbar color: "// TODO fallback $tabbar-text-color-active"
So I think they will make the ios mode to the md mode (and so you have to change --ion-tabbar-text-color-active as @jytx  wrote

Ok, we will have to declare or specify it for both modes,
Thanks!

This is still an issue in 4.0.0-beta.13. This is because the default for md is:
$tabbar-text-color-active:          var(--ion-tabbar-text-color-active, #488aff);

where iOS uses:
$tabbar-ios-text-color-active:                      ion-color(primary, base);

I will be looking into this.


"onBeforeRouteLeave" guard is not removed after switching to another view when using keep-alive and composables api

Version
3.6.5
Reproduction link
github.com
Steps to reproduce

Clone the Github repo
Run 'npm install'
Run 'npm run dev' and open the broswer
Click the first link
Click the second link
Click the first link one more time

What is expected?
The window alert "onBeforeRouteLeave" only once after step 5
What is actually happening?

The window alert "onBeforeRouteLeave" after step 5
The window alert "onBeforeRouteLeave" after step 6

This bug only appears when using keep-alive and composables api.

Hello is it possible to work on this issue?


GHA: Add Check for repo source

Description
Push actions from outside the source repo should not trigger pipeline to publish package to pypi; for example, syncing the main branch on a fork.
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

Good catch, thanks


Cacheid param

R: @jeffposnick @addyosmani
Fixes #417
Adds cacheId to sw-build, sw-lib, sw-precaching, sw-runtime-caching. Also fixes some pre-caching bugs.

Talked about this offline and we're going to merge ahead so Matt isn't blocked on further work that needs to be done.


Cannot get Visual Studio prerelease version detection to work

Describe your question
I am trying to get prerelease version of Visual Studio to work. So far I was trying to set ENABLE_VS_PRERELEASE_VERSIONS or IncludePrereleaseVersions environment variables with no luck. Since this is the first time I am trying to use agent knobs, do I even do this right?
Versions
3.239.1
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[X] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Operation system
No response
Version controll system
No response
Azure DevOps Server Version (if applicable)
No response

Hi @avivanoff, could you show how you specify this variable?

I was able to get it to work.


docker private registry not working in AI training job

USERNAME=hellosivi
REPOSITORY=library
IMAGE_NAME=clr
TAG=v1
IMAGE_URI=$USERNAME/$REPOSITORY/$IMAGE_NAME:$TAG
IMAGE_URI_NEW=registry-1.docker.io/hellosivi/library/$IMAGE_NAME:$TAG

ovhai job run $IMAGE_URI_NEW \
--timeout "10d" \
--gpu 1 \
--name "sample-training-docker" \
--flavor ai1-1-gpu

We added a private registry in dashboard and it created an url :: registry-1.docker.io/hellosivi/library
We tried many combinations of the path. No luck.
Do you support private registries?

Hi, this was a known issue that should be fixed now, yo may have to delete and register you registry again in the AI Dashboard


zig: 0.3.0 -> 0.4.0

Bump to use LLVM8, but just guessing ;).
Update: of course it does, here's
the release notes:
https://ziglang.org/download/0.4.0/release-notes.html
Built (updated) tetris example, LGTM!
(rem to grab its deps via nix-shell or so)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @andrewrk

On Mon, 08 Apr 2019 23:39:12 -0700, Andrew Kelley<EMAIL_ADDRESS>wrote:

andrewrk approved this pull request.
The default cmake build is Debug, which is fine considering this is the stage1 C++ compiler which really doesn't need to be Release. But Release would be fine too. I think it's fine either way.

};

nativeBuildInputs = [ cmake ];
buildInputs = [ llvmPackages.clang-unwrapped llvmPackages.llvm libxml2 zlib ];

cmakeFlags = [
"-DCMAKE_BUILD_TYPE=Release"

The cmake setup-hook doodad actually sets this by default these days,
and just double-checked the nix log to confirm I see it there too :).
So this was meant as a small cleanup not a functional change :).

No more release?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/59198#pullrequestreview-224214901Non-text part: text/html


Need changelog.md

Hello,
This really isn't an issue, but had to reach and ask you. Would be great if you add chanegelog.md or something to let us know what you changed and if anything needs to be changed from our side.

Great suggestion, @SergiOnGit . When I have a chance, I'd like to adopt semantic versioning with something that auto-captures changes since the last release. Will try to get to this prior to the next fix (which I'm actively working on).
Thank you!

Ok - finally also got this to work with automated GitHub releases as well: https://github.com/fivecar/react-native-draglist/releases/tag/3.2.0
CHANGELOG.md also generated all the way back to initial release. Thanks for your suggestion, @SergiOnGit


[package] node-stream-zip project appears to be inactive

We may have to replace this package at some point.

There is confirmation from the maintainer about the project state. However, it seems to be one of those dependencies that is not working well under deno.


add light scene recall message

LS_NORMAL
LS_PROJECTION
LS_WRITEBOARD

add config for scene in roomconfig, "sceneRecall:true" for recalling scene instead of each zone percentage


Implement String.prototype.lastIndexOf

Refs: https://github.com/devsnek/engine262/issues/22

Landed with https://github.com/devsnek/engine262/pull/50


Trying to get "last" 300, seems to get last 100x3?

Here is my function:
function getHistory(chnl,count) {
    var options = {
        channel: chnl,
        last: count
    };
    pubnub.flex_history(options, function(result) {
        var msgs = result.messages;
        var msgcount = msgs.length;
        for (var i = 0; i < msgcount; i++) {
            var msg = JSON.parse(msgs[i].message);
            processMessage(chnl,msg);
        }
    });
}

It seems to loop 100 messages.  Am I doing something wrong?

I confirmed that result.messages[0] is the same as result.messages[100] and result.messages[200].


Adding NYC dac list

Quick agency comparison. To rerun once pairwise comparison is merged in.

@lucasmbrown-usds -- it makes sense to (1) merge the pairwise comparison tool branch, and then (2) rebase this based on that branch so all of the updates there carry through here. LMK if you disagree!


PROPOSAL: Move CPU-bound functionality to WASM

toBinary
fromBinary
toJson
fromJson

Or https://nodejs.org/api/addons.html


Bump Refinery to Latest Version

Bump Refinery
Update Refinery to latest version

Done in following PR:

https://github.com/honeycombio/helm-charts/pull/373


more efficient implementation of RecurrentCycle

2x ~ 3x acceleration on NVIDIA A100, with batch_size=128 and dataset=traffic.

Wow, this is great! Thank you so much for your contribution!


Fix the safe typos

A subset of #7752

@peternewman Thanks a bundle for pulling these out! I can review the remaining changes when I'm back to full-time maintainer or have some spare time.

@peternewman Thanks a bundle for pulling these out! I can review the remaining changes when I'm back to full-time maintainer or have some spare time.

Thanks @quincylvania . If it helps I could also separate the preset changes (which are now mostly just adding the actual word alongside the current typo) from the actual code changes.


core-compat-api: add convertLegacyRouteRefs + use in converLegacyApp

Hey, I just made a Pull Request!
Plugins currently don't have their routes migrated when using convertLegacyApp, meaning you can't configure external routes to or from these plugins. This fixes that and also exports the new convertLegacyRouteRefs as it can be quite handy when adding support for the new system in existing plugins.
Just a reminder that the long-term goal is still to remove the need for convertLegacyRouteRef and convertLegacyRouteRefs, once we're confident that we can bake those into the existing system.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@freben piece of cake at this point 😁


Fix default accessory name to be the same as in api.registerAccessory

Without it HomeBridge says "No plugin was found for the accessory "Cooper&Hunter AC" in your config.json. Please make sure the corresponding plugin is installed correctly"

thanks!


layout - Allow providing a remove handler in options

This allows to push a remove handler through to setUI and allows cleanup after using a layout.

Thanks! That's a good idea...


Add CUDA_HOME's lib to library_dirs

In addition to searching $CUDA_HOME/lib64, make sure to search  $CUDA_HOME/lib as well.

@gmarkall can you please review? 🙂

/merge


Test build for all architectures

Does this mean the build is broken??

No, I think the build is currently okay. I was trying to add a check that all architectures build to CI, but I'm not really sure what's going on. I'm hoping to finish this with @imikushin tomorrow.

@joshwget I agree this would be great.  We can also hook up ARM64 CI.


Logo Proposal for Guard

Hi, I'm a graphic designer and I like to collaborate with open source projects. Do you know that the graphic image of a project is very important? thinking about it I would like to design a logo for your Project Guard.
I will be pleased to collaborate with you.

Thank you ! If you want to contribute logo for this project, you are most welcome ! What do you have in mind?

I'll make a couple of proposals and send them to you
If you have some ideas, suggestions as to style or colors would be great to be able to start.
I also need a brief summary of Guard to get a better idea.

Guard is an authentication server that protects against unauthorized access to a cluster.
As for ideas, if you can has something like a warrior with a shield where the shield looks like Kubernetes logo that will be nice.

Perfect, I'm going to work on the sketches

Hi @tamalsaha Working on your suggestions this was the result, what do you think?

Remember that this is a sketch, you can suggest the changes you want.

Icon or Favicon

Wow, you are quick ! Looks pretty good. I am going to ask another in the team and get back to you .

@area55git , we like the one below for logo. For favicon, we would like the one in the middle without the gray background.

Perfect, I will prepare the final files in various formats (SVG, PNG and others)
I will also make a PR to place the logo in the Readme folder to merge.
Do you have any other suggestions?

Please make a top level logo folder and put all the files there.

Hi @tamalsaha, What option do you like?

What option do you like?

I am new to github, I will not create a folder, can you create it? and I then attach the logos
or can you teach me how to do it?

From left, Darker Red.
From right, Clear gradient

Do you like this image for the Readme folder?

I was doing an investigation and the helmet of the Romans have a detail, I made the change and it looks much better, sorry for so many changes, but I want to do a good job.

In this proposal the logo is rougher, I like it a lot, what you think?

:+1:

FILE DOWNLOAD

This work is licensed under a Creative Commons Attribution 4.0 International License.

PR #185

Thank @area55git . Did you use Illustrator or something else to design the logo? Can you share the original files for it?
Also, do you have any twitter account or something else. Happy to give you a shout out.

In the link are the editable files (CDR, SVG, EPS, etc.)

instagram.com/@area55_ib

In the link are these images too

Thank you again! I tweeted here:

https://twitter.com/tsaha/status/1022280294949244928
https://www.facebook.com/appscode/posts/820707174793073


Disconnect the wallet from the  channel.db

Background
Not sure why the lnd bitcoin wallet has to be in the channel.db. It might be more stable to disconnect between the two, so that in the channel.db is corrupted, one can still access the lnd wallet without having to use the recovery seed.
It will make the recovery process much easier. Especially as the node already has a working and synchronized bitcoind
Some points I get form this crush:
https://github.com/lightningnetwork/lnd/issues/4720

This is already implemented. The on-chain wallet is a separate file (by default located in .lnd/data/chain/bitcoin/mainnet/.
My comment in #4720 was imprecise. If you only need to recover the channels because of a database corruption in the channel.db file, you can just move or delete that file and access the on-chain wallet individually (but all channels will be gone until recovered from SCB).
I recommended doing a full restore from the seed because the data corruption from a failed hard drive could also affect the wallet.db file.

thanks!
Maybe it will be good to update
https://github.com/lightningnetwork/lnd/blob/master/docs/recovery.md


Add DeleteSection method for Init class

It is functionally equivalent to WritePrivateProfileString(section, null, null, filepath) call on Windows platform. This method will be useful on .Net Core or in any other cross-platform .Net implementation.

Nice addition


x509: certificate signed by unknown authority when using v1.0.0

Title
x509: certificate signed by unknown authority (1.0.0)
Summary
I'm finding that since switching from quay.io/keycloak/keycloak-gatekeeper:10.0.0 to louketo/louketo-proxy:1.0.0 I get 403 errors when attempting to auth.
Reverting to gatekeeper:10.0.0 works.
There are no other configuration changes happening here (just the image).
Environment
Version of everything that it's running in your environment:

OS: K8s / GKE 1.14.x
Kernel: K8s / GKE 1.14.x
Go: K8s / GKE 1.14.x
Server: https://github.com/dexidp/dex   [ quay.io/dexidp/dex:v2.21.0 ]
Louketo: 1.0.0

Configuration
        image: quay.io/louketo/louketo-proxy:1.0.0
        - args:
        - --add-claims=groups
        - --client-id=grafana
        - --client-secret=grafana
        - --discovery-url=https://dex.svc.nb1.gke-dev.example.com/.well-known/openid-configuration
        - --enable-authorization-header=false
        - --enable-json-logging=true
        - --enable-logging=true
        - --enable-metrics=true
        - --enable-token-header=false
        - --enable-default-deny=true
        - --listen=:6001
        - --preserve-host=true
        - --redirection-url=https://grafana.svc.nb1.gke-dev.example.com
        - --resources=uri=/*|groups=it-all
        - --scopes=groups
        - --secure-cookie=true
        - --skip-openid-provider-tls-verify
        - --skip-upstream-tls-verify
        - --upstream-url=http://<IP_ADDRESS>:3000

I'm specifying both skip-upstream-tls-verify and skip-openid-provider-tls-verify
Expected Results
Token issued, auth'd and redirected to upstream site, i.e:
"msg":"issuing access token for user","email":"me@example.com","expires":"2020-07-03T12:22:20Z","

Actual Results

Access to grafana.svc.nb1.gke-dev.example.com was deniedY
ou don't have authorization to view this page.
HTTP ERROR 403

Louketo logs:
{"level":"info","ts":"2020-07-03T08:11:39.788Z","msg":"starting the service","prog":"louketo-proxy","author":"Louketo","version":"v2.3.0 (git+sha: 9eca196-dirty, built: 01-07-2020)"}
{"level":"info","ts":"2020-07-03T08:11:39.788Z","msg":"attempting to retrieve configuration discovery url","url":"https://dex.svc.nb1.gke-dev.example.com","timeout":"30s"}
{"level":"info","ts":"2020-07-03T08:11:39.803Z","msg":"successfully retrieved openid configuration from the discovery"}
{"level":"info","ts":"2020-07-03T08:11:39.804Z","msg":"enabled reverse proxy mode, upstream url","url":"http://<IP_ADDRESS>:3000"}
{"level":"info","ts":"2020-07-03T08:11:39.804Z","msg":"enabled the service metrics middleware","path":"/oauth//metrics"}
{"level":"info","ts":"2020-07-03T08:11:39.804Z","msg":"using session cookies only for access and refresh tokens"}
{"level":"info","ts":"2020-07-03T08:11:39.804Z","msg":"protecting resource","resource":"uri: /*, methods: DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE, required: authentication only"}
{"level":"info","ts":"2020-07-03T08:11:39.805Z","msg":"Louketo proxy service starting","interface":":6001"}
{"level":"error","ts":"2020-07-03T08:12:45.192Z","msg":"no session found in request, redirecting for authorization","error":"authentication session not found"}
{"level":"info","ts":"2020-07-03T08:12:45.193Z","msg":"client request","latency":0.000375573,"status":303,"bytes":86,"client_ip":"<IP_ADDRESS>:52134","method":"GET","path":"/"}
{"level":"info","ts":"2020-07-03T08:12:45.217Z","msg":"client request","latency":0.000166577,"status":303,"bytes":312,"client_ip":"<IP_ADDRESS>:52136","method":"GET","path":"/oauth/authorize"}
{"level":"error","ts":"2020-07-03T08:12:45.896Z","msg":"no session found in request, redirecting for authorization","error":"authentication session not found"}
{"level":"info","ts":"2020-07-03T08:12:45.896Z","msg":"client request","latency":0.000084038,"status":303,"bytes":86,"client_ip":"<IP_ADDRESS>:52152","method":"GET","path":"/"}
{"level":"info","ts":"2020-07-03T08:12:46.071Z","msg":"client request","latency":0.000093519,"status":303,"bytes":312,"client_ip":"<IP_ADDRESS>:52160","method":"GET","path":"/oauth/authorize"}

{"level":"error","ts":"2020-07-03T08:13:06.425Z","msg":"unable to exchange code for access token","error":"Post \"https://dex.svc.nb1.gke-dev.example.com/token\": x509: certificate signed by unknown authority"}
{"level":"info","ts":"2020-07-03T08:13:06.425Z","msg":"client request","latency":0.100279943,"status":403,"bytes":0,"client_ip":"<IP_ADDRESS>:52736","method":"GET","path":"/oauth/callback"}

"level":"error","ts":"2020-07-03T08:13:06.425Z","msg":"unable to exchange code for access token","error":"Post "https://dex.svc.nb1.gke-dev.example.com/token\": x509: certificate signed by unknown authority"}

It looks like Move from coreos/go-oidc OAuth2 library to golang.org/x/oauth2 doesn't work with skip-openid-provider-tls-verify config.

@jangaraj I think it's not passing in the desired context here
https://github.com/louketo/louketo-proxy/blob/master/oauth.go#L134
The provided  context is what can be used to control which http-client is used. Suspect it's using a default one.

Hi, is there a workaround for this issue?

Workaround: make CA cert available for Louketo (it must be available in the /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem in case of louketo Docker image)

I would also really appreciate a fix for this, I guess it is not really hard if you have some go knowledge and know the sources of this project which I currently not really have, there is also an example https://github.com/golang/oauth2/issues/187#issuecomment-227811477 I will take a look at this when I find some time.

See https://github.com/jangaraj/louketo-proxy/commit/ddb37f62388fbd046ec6cb181ef73a9d32826903 feel free to test and create here.


fix(brightness): tuya maximum brightness set to 1000 by api

Hello,
I found out an issue with the plugin while using it with a connected light bulb, it seems like console was displaying a warning:

I believe this is due to Tuya API changes from 100 to 1000 maximum of brightness. I made this little change right into brightness characteristics and tested it locally it seems to work just fine.

Thank you for creating this MR.
While this MR would solve your problem and your error, it would break the plugin for many other users.
The max value you change is dependant on the light, I just confirmed so with my own lights once more.
Please update your config and set the appropriate value for the max_brightness for these lights and it should work.


ENH: Added voigt in scipy.special.

The implemented Voigt function currently uses the scipy.special.wofz function because it provides a smoother look than my own implementation in C.
It has been discussed in the scipy-dev mailing list [1] and the responses were positive.
[1] https://mail.python.org/pipermail/scipy-dev/2018-September/023085.html

While I don't want to be the pain in the neck... Maybe it's better to add it as an actual ufunc? Pros: it's available in the cython_special; array_like inputs are handled automatically, etc.
This isn't too hard either, see e.g. log1p or hyp0f1

While I don't want to be the pain in the neck... Maybe it's better to add it as an actual ufunc?

Seconded.

While I don't want to be the pain in the neck... Maybe it's better to add it as an actual ufunc? Pros: it's available in the cython_special; array_like inputs are handled automatically, etc.
This isn't too hard either, see e.g. log1p or hyp0f1

Done. The ufunc is _voigt and the voigt function is a thin wrapper of _voigt, just to set some default arguments.

I'm not sure how to put optional arguments on ufunc, that's why I made a thin wrapper on Python. One possible solution is to rename _voigt in ufunc to voigt and wrap ufuncs.voigt with a voigt function in basic.py. In Python scipy.special, the voigt from basic.py will be loaded (voigt in ufunc is overwritten by it). This way, voigt can be loaded to cython_special and the Python's scipy.special has 3 optional arguments. I'm not sure if this is the best solution, though.

I'm not sure how to put optional arguments on ufunc, that's why I made a thin wrapper on Python.

@mfkasim91 are the optional arguments particularly desirable here? It's pretty atypcial in the special API (perhaps precisely because you can't have default arguments in a ufunc).


Yet another fixes for data models

Support for detailed_merge_status in Merge Request event
Proper name for pipeline property in PipelineEvent (it was me who named it like that 🤦)
Pipeline event not necessarily is related to Merge Request (allow merge_request: null)
PipelineAttributes::$finished_at can be null (when pipeline is running)
PipelineAttributes::$duration can be null (when pipeline is running)
PipelineAttributes::$queued_duration can be null (when pipeline is running)
Label::$project_id can be null, when label is a project group's label (defined for all projects in a group)

@Rezrazi is there a chance for merging this? We deployed new webhook handling system to production today using my fork's version, but it would be better to switch to official release 🙂.
PS. problems in CI are not related to this PR, that's why I don't provide any fixes for them. It looks like minimal required versions for Composer dependencies are wrong.

Yeah sorry was taken by some other stuff.
Will look at the broken CI and potentially merge this either today or over the weekend
Thanks again for the contribution!

@Wirone could you please rebase your PR? The CI has been fixed


Tell pytest the Test is not a Python test class

See https://github.com/lazyscribe/lazyscribe/issues/28, p. 11.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.54%. Comparing base (616c505) to head (acc2b73).
Report is 2 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #34      +/-   ##
===========================================
+ Coverage    96.40%   96.54%   +0.13%
===========================================
  Files           19       19
  Lines         1002     1013      +11
===========================================
+ Hits           966      978      +12
+ Misses          36       35       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[PLAT-11215] Garnet : Fix item couldn't be selected

Issue
: Radio button image didn't change properly when it selected in
DataListSamplewithRadioButtonsSample.
Fix
: Fixed background position in selected class
Changed deprecated property 'groupSelection' to 'selectonType'
https://jira2.lgsvl.com/browse/PLAT-11215
Enyo-DCO-1.1-Signed-off-by: Mikyung Kim<EMAIL_ADDRESS>

@MikyungKim
If we don't need this PR, please close this PR.

We've already taken this pr into 1.5.0-pre.3.
Closing this issue.


Eye candy for README/Help command?

Only done the README so far, will do the embed thing later

I should be done now, I have not tested the changes to the help command.
Also the blacklist command's behavior seems to be different from the code (you're hosting a more updated copy of the bot?) so I'm still struggling to get my head around how it works.
Please do check the text embed does not exceed the character limit, and **theres *no error**s in the markdown.


NBTAPI Update

[00:28:34 INFO]: [NBTAPI] [NBTAPI] Found Spigot: v1_16_R3! Trying to find NMS support
[00:28:34 INFO]: [NBTAPI] [NBTAPI] Found Gson: class com.google.gson.Gson
[00:28:34 INFO]: [NBTAPI] [NBTAPI] NMS support 'MC1_16_R3' loaded!
[00:28:34 WARN]: [NBTAPI] [NBTAPI] Please update the nbt-api or the plugin that contains the api!
[00:28:34 WARN]: [NBTAPI] [NBTAPI] The NBT-API at 'package com.dnyferguson.mineablespawners.nbtapi' seems to be outdated!
[00:28:34 WARN]: [NBTAPI] [NBTAPI] Current Version: '2.6.0' Newest Version: 2.7.1'

update your version and see if it resolves the issue
[00:28:34 WARN]: [NBTAPI] [NBTAPI] Current Version: '2.6.0' Newest Version: 2.7.1'

Same issue here - Version 3.0.11
It also occured on Version 3.0.8
[14:58:27 INFO]: [NBTAPI] [NBTAPI] Found Spigot: v1_16_R3! Trying to find NMS support
[14:58:27 INFO]: [NBTAPI] [NBTAPI] NMS support 'MC1_16_R3' loaded!
[14:58:27 INFO]: [NBTAPI] [NBTAPI] Found Gson: class com.google.gson.Gson
[14:58:27 WARN]: [NBTAPI] [NBTAPI] The NBT-API at 'package com.dnyferguson.mineablespawners.nbtapi' seems to be outdated!
[14:58:27 WARN]: [NBTAPI] [NBTAPI] Current Version: '2.6.0' Newest Version: 2.7.1'
[14:58:27 WARN]: [NBTAPI] [NBTAPI] Please update the nbt-api or the plugin that contains the api!

update your version and see if it resolves the issue
[00:28:34 WARN]: [NBTAPI] [NBTAPI] Current Version: '2.6.0' Newest Version: 2.7.1'

This isn't something we can update easily - we'd have to recompile the plugin ourselves.

These are just warnings from the library we use, you can ignore them and the plugin will be fine


Reload all tabs when switch to info Mode?

Yes, I suppose this makes sense.

Implemented and close https://github.com/dhowe/ChinaEye/pull/43


In Documents page, contact email not updated

1. Goto company, change default contact shweta to sachin.
2. open documents, type company name
3. right click on document and share email
4. old email shown, updated sachin mail not shown. see below picture

Default contact/Company has no meaning to send email.
Now all emails coming from all contacts with send notification on.

Displays emails of all the contacts attached with that company(whose notification is on).


docs: update to sphinx 5.0

Summary

depends on #564
Checklist

[ ] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[ ] I have formatted the code properly by running task lint
[ ] I have type-checked the code by running task pyright

[ ] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[x] This PR is not a code change (e.g. documentation, README, ...)

now waiting on https://github.com/sphinx-doc/sphinx/issues/10657 before updating.

Sphinx 5.1.0 was just released, which should allow us to get rid of the patched searchtools.js again.

We should read through the the changelog and see if there are any other options we can benefit from aside from removing the patched searchtools.
https://www.sphinx-doc.org/en/master/changes.html

We should read through the the changelog and see if there are any other options we can benefit from aside from removing the patched searchtools.

As far as I can tell, there's only https://github.com/sphinx-doc/sphinx/commit/95b81831b19727a3a933e387b1bc6c1053c3aadd which may help avoid this (technically a workaround):
https://github.com/DisnakeDev/disnake/blob/0fc40e6062ba9cba143dc1aa8e4dba15a498670a/docs/conf.py#L248
Additionally, there's https://github.com/readthedocs/sphinx-hoverxref/commit/02502633fa95333430fbc604796828f35231ec48 which was added in hoverxref v1.1.2, we'll have to update our custom css to use the new selectors. May also want to consider using == instead of ~=, since it doesn't really seem to follow semver (I'd consider this a breaking change but it was added in a patch version /shrug).

I think i fixed both of those issues in https://github.com/DisnakeDev/disnake/pull/565/commits/15535dce9bd8f6d4fbd84429847ae819608106a5 and https://github.com/DisnakeDev/disnake/pull/565/commits/0f14d8d9cf3288f754b577f7c86ca9be92b15027


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit f471a65:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

archiveTargetFolder/index.md
:x:Error

Details

archiveTargetFolder/content/someContent.md
:warning:Warning

Details

[Error] Response status code does not indicate success: 403 (Forbidden).

archiveTargetFolder/index.md

[Error] Response status code does not indicate success: 403 (Forbidden).

archiveTargetFolder/content/someContent.md

[Warning] The call to the validation service timed out and validation was not completed. This happens when there's an issue with the service and continuing to retry the call could cause build delays. You might have content issues that were not reported. To retry validation, close and re-open your PR, or force a full build of your branch via https://ops.microsoft.com. Note that forcing a full build requires admin permissions to the repo. If you don’t know who your repo admin is, or if you continue to see this message after a forced build, file an issue via https://SiteHelp.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Tweak concurrency groups

Current dependencies on/for this PR:

main

PR #2   👈

This comment was auto-generated by Graphite.


adding a MerkleTree serializer

Hi, currently rs-merkle only supports serializing MerkleProof types.
In our use case we build a MerkleTree and want to store it on disk to generate proofs at a later time. Would you be interested in a PR adding a serialize/deserialize methods to MerkleTree?

Hey @themighty1 ! I sure would!


Ruby phase 2 - Workflows

Summary

This is the proposal for the second phase of the Ruby SDK about workflows. Please review and leave comments!

Can see the first phase here or look at PRs #92 and #93 for discussion on it.

See it rendered.
Much of this is inspired by the previous Temporal Ruby SDK (and its proposals which were moved to a sub directory) and our other SDKs.
The design of workflows and their handlers is an early one and we welcome any suggestions for alternative designs here. Nothing is concrete.
There are plenty of outstanding questions on the proposal, some of which need more implementation and performance measurements to decide.
Use this PR for comments/discussion. Don't be afraid of making too many comments; if it gets too noisy, I'll just create another PR.
Any points of contention will be discussed in-person by the SDK team and a decision will be made.

For general discussion beyond comments here, please also join us on #ruby-sdk in Slack.

Updated with the following changes:

Workflows now must extend from Temporalio::Workflow::Definition
Activities now must extend from Temporalio::Activity::Definition
Ractor-based task execution is now on by default
Clarified that concurrency primitives in the standard library can be used
We now discourage use of the async library
Changed names of no-failure Future class methods

Made two minor fixes, but otherwise no outstanding/unresolved things (or even updates) for a while. Merging.


fix #2871 by introducing additional directories

This PR fixes issue #2871 by moving 3 binaries to a directory named debug_binaries, and 7 binaries to a directory named test_binaries.

Hey @sgpearse just to clarify, there are 3 places to put binaries. test_app does not have binaries.


Use Environment Variables and Fixed File Templates for Global Project Settings

Creates templates and fixed settings per the setup documentation, and a basic environment substitution system for simplifying and consolidating the different settings throughout the project. Once merged, this should prevent us from having any discrepancies in configuration, or from committing any files which contain team-specific values.
Testing:

Use the steps in the README to initialize a brand new project (should be a quick and easy process)
Make sure firebase things (functions, dashboard, etc.) deploy properly.
Make sure iOS app builds
Make sure Android app builds properly

@cara-wong Tagging you to give a final review now that I'm merged with the new onboarding logic, including verification codes.

Thanks @rlnsy for all your hard work on this one. Looking really good :) @rossingram @vitorbarros you might want to consider pulling parts of this into your master repo so setting up future clients will be easier.


Riak Updates

you seem to be the most recently active person looking at Riak.  Is it in active  development?  I can only find Basho stuff :(
Looked like a really cool product.
cheers,

You will find all the info in Riak's release notes.
https://github.com/basho/riak/blob/develop-2.9/RELEASE-NOTES.md#riak-kv-290-release-notes---patch-4


[r/python] Package dependencies need max version for tiledb dependency

The Python dependency on tiledb, used for the write path, must have a maximum version specified.  The max version must be a version that is compatible with the SOMAReader-linked version used for the read path.
In other words, need to make sure that you can't write data which is then not readable due to version skew.
[x] Python #807
[ ] R #812

Per @maniarathi , the R ecosystem does not actually make it possible to do the pinning easily. Instead, at a later point in time, the long term solution (C++ pinning) will be prioritized.


Task History Control Activate Issue

I have a task history control on a form with a task list view. I've included a refresh option on the task list to try and update the task history. When the form first loads and fires the .activate it loads the history just fine. When I call the same method via the refresh menu option it will update the number of events count but does not show the new history in the control.
Here is the code I use
        void ActOnTask(Task t)
        {
            if (t != null)
            {
                currentTask = t;
                currentTaskInterval = t.Definition.Triggers[0].Repetition.Interval.TotalMilliseconds;
                taskHistory.Activate(t);
            }
        }

Originally posted: 2014-04-24T17:32:49

After being able to do some more research I have found that the following is thrown when trying to refresh from an installed client.
This BackgroundWorker is currently busy and cannot run multiple tasks concurrently.
Originally posted: 2014-06-03T12:42:13


Optional auto rotating/renewing certificates

One of the key features of csi-lib is Automatically rotating/renewing certificates near expiry.
But do we consider make this feature optional?
One particular use case is: one-time and short-lived cert for init-container (for mTLS to pull some secrets).
The user container will no longer need the cert after consuming it. Since the pod is still running, csi-lib will continue the renewal logic for this short-lived cert. With least privilege guidance, shall we disable the renewal in this case ?
Upon checking the code, all certificates will be auto renewed once it hits the NextIssuanceTime:
https://github.com/cert-manager/csi-lib/blob/v0.3.0/manager/manager.go#L499
A workaround is to set the NextIssuanceTime much longer than the pod lifetime. But add an option here (pass in as volumeAttribute) would be much cleaner logic.

bump it again up for awareness
@munnerz any thoughts ?


Dont read from layouts and dependencies tables in QCoDeS

This PR removes usage of functions which read information from layouts and dependencies tables. Reading information from layouts and dependencies tables is substituted with reading RunDescriber object (stored in run_description column of runs table). This PR does NOT remove writing to layouts and dependencies tables, this will be done in another PR.
This PR is just one of the PRs on the way towards removing the layouts and dependencies tables completely from QCoDeS database.
ToDo:

[x] instead of raise DeprecationWarning, use warnings.warn on the non-underscored deprecated functions
[x] whenever necessary remove usage of private attributes to access RunDescriber and/or InterDependencies
[ ] flatten data arrays get_data_by_id or not? the tests of get_data_by_id say "yes". but perhaps when plot_by_id is improved (that's in a different PR) then it can use get_parameter_data directly, and then get_data_by_id can be deprecated; but within the scope of this PR we just make sure that the tests work and plotting notebooks still produce correct plots (since plot_by_id uses get_data_by_id that is drastically adjusted in this PR)

I'd say this PR is ready for review. Note that it is not completely true that we don't read from layouts and dependencies; there is a single place (in the current API) where that happens: in the create_run function from sqlite.queries.
@QCoDeS/core

there is a single place (in the current API) where we still read from layouts and dependencies: in the create_run function from sqlite.queries

do you mean the _get_layout_id inside _add_parameters_to_layout_and_deps inside _insert_run? if so, that's fine, but this "reading" is now done only with "private" methods of sqlite.queries and it will go away together with the tables (because everything will be tied to run_description column)


Update link_credential_phishing_voicemail_language.yml

Description
format and add reuse logic against OCR output of message_screenshot
Associated samples

Sample 1

/update-test-rules

/update-test-rules


OpenApi for application/octet-stream should have type=string, format=binary

OAPI reference specifies this for 'files' i.e. opaque binary request/response bodies.
The previous value of MediaType(None) means anything is allowed, which is technically correct; but Swagger Codegen refuses to parse a schema that doesn't have a type specified, and if I specify type="string", then format="binary" is also required for the schema to mean the right thing. (This might have changed in the latest swagger-codegen release.)

I can't reproduce the error with the latest (online) version of swagger-codegen. So this was probably fixed at some point. I have an older 5.x version in my CI flow (and I'll update it now).
The change to the schema is still good, according to OAS 3.0.0, but it would make it backward-incompatible with OAS 3.1.0 when you do switch - I hadn't realized that! So perhaps it's better not to merge this, and keep the schema slightly non-explicit but more forward compatible.
Do you want me to push a commit fixing the tests here? Or close the PR?

So perhaps it's better not to merge this, and keep the schema slightly non-explicit but more forward compatible.

OK, let’s do that.
Thank you for the investigation!


Update fakegato-timer.js

start the fakegatotimer with subscription

seems not to work completly. Timer is running, but no data is written. I think the last value is unkown. Can you have a look on this?


expose a list of available (injected) wallets

The wallets inject themselves in the window.cardano object, so it should be possible to detect which wallets are available by that.

This is implemented


Tags order modified

When deploying an application, I specify tags, and it appears that sometimes Slipstream doesn't store the tags in the same order I initially specified them.
For example, when I deploy an application with tags elouan, dev, DNS-namespaces, tags are stored in this different order: DNS-namespaces, dev, elouan.
However, when I deploy a single component (not a whole application) with the same tags (elouan, dev, DNS-namespaces), the order is preserved.
For a little bit of context, my team is planning to do some introspection using tags, and in our code we expect them to be in the specific order in which we specified them initially.
As a solution, we can get rid of the order by using the following tag format: key1_value1, key2_value2, key3_value3, but it makes it heavier and we would prefer to rely on the order.

Finally we decided not to rely on the tag order

Hi.  Thanks for sharing this.  We'll discuss this issue and either make it clear in the documentation that tags are unordered, or make it ordered in all cases.

For reference, the server is not involved on that: the client sanitises the tag list before sending it to the server by removing duplicates and sorting it alphabetically. As correctly reported by @WinstonSureChill, the deploy dialog in the component page does not include the  sanitation code.
I've opened an issue in the UI module for this: https://github.com/slipstream/SlipStreamUI/issues/577.


Add Mdns implementation for darwin

Problem
This patch add an Mdns implementation for the darwin device layer.
Summary of Changes

Add src/platform/darwin/MdnsImpl.cpp to host the darwin specific code
Enable Mdns by default if the darwin device layer is used and use the new implementation

Could some of the recurring arguments for functions like OnGetAddrInfo OnResolve, be regrouped in an obj or structure?
Arguments like context, DNSServiceRef, DNSServiceFlags, DNSServiceErrorType, interfaceId, Port, hostname...

Sadly On* methods are from the DNS-SD API itself and I can't change their signatures.


Passing Signal as Value or Itself Does Not Trigger Reactive Updates in Child Components

Describe the bug
In Solid.js, passing a signal either as its value (count()) or as itself (count) to a child component should allow for reactivity. However, in the following example, neither approach triggers reactivity in the child components (Child and Child2):
import { createSignal } from 'solid-js';

const Even = () => I am even;
const Odd = () => I am odd;

const Child = (props) => {
  // Expected to work when passing count() as value but it's not reactive
  return props.count % 2 === 0 ? <Even /> : <Odd />;
};

const Child2 = (props) => {
  // Expected to work when passing count as signal but it's not updating
  return props.count() % 2 === 0 ? <Even /> : <Odd />;
};

function App() {
  const [count, setCount] = createSignal(0);

  return (

      <button onClick={() => setCount(count() + 1)}>{count()}</button>
      <Child count={count()} />
      <Child2 count={count} />

  );
}

export default App;

Your Example Website or App
https://stackblitz.com/edit/solidjs-templates-9kebyj?file=src%2FApp.jsx
Steps to Reproduce the Bug or Issue
Use the code above.
Click the button to increment the count.
Neither Child nor Child2 reactively update based on the new count value.
Expected behavior
Child: When passing count() as a value, it should render the correct child (Even or Odd) based on the value of count(). However, this does not work because it's not reactive—Child does not update when count changes.
Child2: When passing the signal count directly, it should reactively update whenever the signal changes. However, the component does not update correctly in this case either.
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

For it to be reactive, it has to be wrapped in jsx, this is how things become reactive in solid
const Child = (props) => {
  return <>{props.count % 2 === 0 ? <Even /> : <Odd />}</>;
};

Trying to explain why the example given won't work, for something to be reactive it has to be a function.
If you want to make Child reactive, taking Child as the function to re-run when reactive values change, then that will mean you will be rerunning the full Child on each change, which is undesired as it won't be fine-grained.
// this not solid-js code
const Child = (props) => {
  somethingElse() // this will re-run if props.count change
  return props.count % 2 === 0 ? <Even /> : <Odd />;
};

You can think of jsx as to be the following, which returns a new function that can be re-run when the count changes.
// this not solid-js code
const Child = (props) => {
  somethingElse()  // this won't re-run when props.count change
  return () => props.count % 2 === 0 ? <Even /> : <Odd />; // this function re-runs when props.count change
};

So the idiomatic way of making things reactive in solid is to wrap these in jsx as follows
https://playground.solidjs.com/anonymous/672bae4b-2afc-460c-8b8b-0079fc179767

As for count vs count()
 <Child count={count()} />

vs
 <Child count={count} />

This is done this way by a design decision.  The basic, first idea is that you won't have to think if something is a function or not. Taking from your own example:
const Child = (props) => {
  return <>{props.count % 2 === 0 ? <Even /> : <Odd />}</>;
};

const Child2 = (props) => {
  return <>{props.count() % 2 === 0 ? <Even /> : <Odd />}</>;
};

Child is using the value and Child2 is using the function. That mix of different uses will make you having to look up if what you pass to the component or get, is a function or not. As in trying to do <Child2 count={count()}/> will error out, as prop.count is not a function.  One could possibly use a wrapper, as in $(props.count) which will use the value or call the function if it's a function, but then you will have to use the wrapper.

Then there's the issue that reading a signal causes tracking (making the caller function re-run whenever the signal changes)
In your first example there is
<Child count={count()} /> // reading count signal

const Child = (props) => {
  return <>{props.count % 2 === 0 ? <Even /> : <Odd />}</>;
};

If count={count()} were really reading the signal, then props.count would be just a regular value and can't be reactive. Therefore, you cannot get fine-grained updates inside Child and instead you will have a full re-render of wherever you read count() and also a re-render of Child.
For this reason solid comes with a compiler. The compiler changes props to be getters, to "push" reading a signal down in the tree as possible.
When you write
<Child count={count()} />

solid compiler outputs
<Child count={get count() { return count() }} />

That way the signal is not read until you access props.count, pushing the signal read as deep as possible giving fine-grained updates.
<Child count={get count() { return count() }} />

const Child = (props) => {
  return <>{props.count % 2 === 0 ? <Even /> : <Odd />}</>;
};

Granted this can be confusing, when you do
const [count, setCount] = createSignal(1)
<Child count={count()} />

You may expect to be the same as
const [count, setCount] = createSignal(1)
<Child count={1} />

but that's not the case, what happens is
const [count, setCount] = createSignal(1)
<Child count={{ get count() { return count() /* 1 */ }} />

Let me know if you have any doubt

Yes it is working now. Thank you so much! What I understood is unlike react js, solid js reruns jsx for updates while react js runs whole component. Is my understanding correct?


Adding (third-party) plugins to the index

For the beginning there will be only "official" plugins on the index / list under https://woodpecker-ci.org/plugins. The question that came up in #451 is how third-party plugins should be added and how they need to be managed to provide some kind of liability.

Suggestion: The two orgs approach

org:woodpecker-ci holds all "official plugin" - they could get a verified badge in the index
org:woodpecker-plugins holds all other third-party / not so official plugins and we could put a warning to the index saying that the user of such a plugin has to make sure that he can / will trust the author

I still like the approach of having users to apply to list their plugin as that allows us to removed them in case someone reports them or if they are just outdated not working for a long time. Having listed third-party plugins in one org keeps the community closer together IMO and allows us a bit of control while we still could grant the users full-access to their repos.

For reference, this is how drone seems to populate their index. https://github.com/drone/drone-plugin-index
For the record, I don't love it.

I would like to have something in between their approach and the suggestion above.
I think it may be hard to get people to "give" their repo to the plugin org. Many devs (I think) are going to be hesitant to hand power of the repo over to us, even if we give them write access to it.
I think instead we should let them keep their repo in their own namespace, but still have a process where they need to PR a request to add it to the index that we would need to approve.
Perhaps an annual/quarterly/etc review of the index as well.

For reference, this is how drone seems to populate their index. https://github.com/drone/drone-plugin-index

What I like about our current approach by #451 over the way of the drone-plugin-index is the automatic docs gathering. That reduces active maintenance by the Woodpecker maintainers drastically and allow the plugin owners to get updates live much quicker.

Also as part of this, we should promote a specific topic and then offer a link to a GH search of that topic. That way users can < > easily look across GH (or other forges wink ) for plugins.

We already started something similar in #320

This would essentially end up being three "levels"

Plugins in our organization, maintained by us
Plugins that are PRed into the index, somewhat "vetted" by us
The topic search, which is "unofficial" plugins, but allows the user to judge for themselves

Nice idea. We could add a note to the plugin index describing how to apply for the index (hosted under woodpecker-plugins org) or that not-listed plugins can be found under the topic xyz with a link.

What I like about our current approach by #451 over the way of the drone-plugin-index is the automatic docs gathering. That reduces active maintenance by the Woodpecker maintainers drastically and allow the plugin owners to get updates live much quicker.

I agree with this, it would be much nicer to allow a bit more autonomous function by plugin maintainers (even within our own org).
We should cache the info so as to not hit the GH API every time a page is loaded, but I think it's easily doable and much easier to maintain than their hard-coded index.

Also to clarify

Plugins that are PRed into the index, somewhat "vetted" by us

What I meant by this wasn't to make people give up their repo to our plugin org. I meant something more akin to an "awesome list" where people need to PR their project into a list that we could then use to grab info from the GH API.
I still think that asking people to give over their repo (regardless of us promising to give them write access) isn't ideal.
I think there's middleground, rather than making them PR their docs we could just have them PR their namespace/repo and we could gather their docs/topics using the API.
This still allows us some gateway control, but doesn't force them to give away their repo. If we need to remove them from the "vetted" list, we simply remove them from our list.


In the case of packet loss, there can be a mismatch between the request and response of a transaction.

For example, in a TCP session with HTTP request and response packets:
Request 1 => GET /test.js
Response 1 => Response for /test.js
Request 2 => POST /api/v1/test
Response 2 => Response for /api/v1/test
If there is packet loss, such as the loss of Response 1 and Request 2 packets, causing a packet gap, the libhtp may incorrectly combine Request 1 and Response 2 into a single transaction.

I think the scenario you describe is correct.
Do you have a pcap to verify this ? (or even better a https://github.com/OISF/suricata-verify PR with a test)
How would you handle this ?


Parcel and building from source

Description
When running the build scripts there are a few problems and curiosities that come up.
The first problem is that the contribution document doesn't line up with what happens when we run build:src. The contribution document says we should get four files. index.js, index.min.js, index.browser.js, and index.browser.min.js The first two being for node, with the last two being for the browser. However, what we actually get when we build is index.min.js, index.browser.min.js, and index.browser.min.js.map. It's not a huge problem, but it is confusing to new folks coming into the project.
The second problem is that the current parcel set up builds for development, rather than production because it is missing the production flag in the config. It's a simple fix, but not one that is obvious if you aren't familiar with parcel. When the production flag isn't set, parcel builds for development mode which tries to open up a websocket with the server for what I think is hot-reloading. A useful feature but not what you're looking for when you're trying to build.
The third problem is documented on parcel. parcel-bundler/parcel#2128. With a potential fix in the same thread. But then if we want to implement that fix, the question is how far back do we want to go in version numbers? Or is there another way we want to fix this?
I'm thinking we could have two different directories one labeled dev and one for prod. That we'd put here.
As for the parcel issue 2128, I'm less sure of how to properly handle it. I'm brand new to this project and would like to hear from those that have been around for their thoughts.
Files
You can see the current items that you get out of the build here, and here is where the contribution guide says what you're supposed to see.
Then here is and here is where you'd need to add the production flag.
To Reproduce
Use "npm run build:src" and then try to include index.browser.min.js into a browser application.
Tasks

[ ] Determine how we want to separate building for development and production.
[ ] Determine how we want to fix up the problem stemming from parcel-bundler/parcel#2128
[ ] Fix the contribution guide so that it properly shows what is built, but that may need to wait until we figure out how we want to deal with problems two and three. Which would be done here

There is another question to ask:
Webpack or Parcel ?
Right now both are implemented, which is very bad.

@raimannma Well, just tried running webpack. It's not currently working correctly because it's pointing at a file doesn't exist anymore. Which is ./src/carrot.js. If we switch it to the correct file ./src/index.js it works better.
Though I can see that it has options to build for production, I'm not sure how to get it to use them.
Using the flag env.production doesn't seem to work. Nor does --mode=production.

As for webpack or parcel. I'm unsure of which would be the better tool. I'm familiar with webpack, but not parcel. What are the advantages of using parcel over webpack?

As far as I understand, parcel is a bit faster and is more friendly to the ES2015 module system (which we may want to explore in the future to have true isomorphic code), but for right now I think it's giving us more headache that it's worth. The changes that introduced parcel in are clustered in a series of commits from c09adef487927b72b4110bad07bdef647dee0635 to f3c334df2da1ba288a2e22a9715557bd9200a0f2 it seems. We might be able to just "roll these back" (although we may have to do this manually, not sure what the git-way would be right now) and keep going with webpack for now which was really working fine.

I tried that. Though I was having a similar issue of figuring out how to run it different for production/development.
@christianechevarria

I tried that. Though I was having a similar issue of figuring out how to run it different for production/development.
@christianechevarria

If I'm understanding your question correctly (I suspect I might not be), inside of the webpack.config.js we're using something called parallel-webpack.createVariants which automatically builds production and development files for various targets so that you just have to call webpack from the command line and it's done for you -- the relevant code for this is in added below https://github.com/liquidcarrot/carrot/blob/3a4a96764ab26e4cf03786f48c733bf5d83c2205/webpack.config.js#L55-L59

Ah, maybe I'm just dropping the wrong file into place then. I'll tinker some more with it.

Hi all, just making sure if this issue should still be open, I believe we resolved in the Gitter chat to continue using Webpack and roll back these changes correct?

Yeah we can close down the issue. Long as we know that we're going to roll back to webpack.


Overlord v2

@abake-enova Nice improvement on the tests and improving upon the comments I made there. Take a look at the comments on the front-end work, and apply them in the Pmail exercise in Section 5.
Good work!


Terminal scrolls up when typing a command

VS Code Version:
Version: 1.56.1 (system setup)
Commit: e713fe9b05fc24facbec8f34fb1017133858842b
Date: 2021-05-06T10:08:05.141Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.14393

OS Version:` Windows Server 2016

Steps to Reproduce:

Run 'Get-Process' in the terminal
Make the terminal panel larger by dragging the separator upwards
Scroll in the terminal pane so you see the prompt as the last line against the bottom edge of vscode and the output of 'Get-Process' populating the remaining terminal pane (we do this because we want to see some data at the top)
At the prompt, which is now located at the bottom, you type another command 'Get-Service' for example

6Notice the terminal prompt moves to the middle of the terminal pane and doesn't stay at the bottom.
After step 3 you see this:

At step 4 when you type the first letter in the terminal you see this:

This makes it really annoying if you want to see some data at the top while typing commands.
Does this issue occur when all extensions are disabled?: Yes

Thanks for the issue. Did this start happening recently? What do you have terminal.integrated.scrollback set to?

This looks like an issue with our old terminal backend "winpty", going forward we are focusing our efforts on the new backend "conpty" which is build by the Console team at Microsoft and should fix many issues with the terminal under Windows. You can read more about getting ConPTY here.
/duplicate https://github.com/Microsoft/vscode/issues/45693

@Tyriar so we need to switch to compty? Is that a setting somewhere?

@DarkLite1 it's a feature of windows 10, I'm assuming the latest windows server would ship with it


The possibility to graphically display the shop floor with important KPIs at a glance

Informations like:
-For each Station:

current Operator
current Order
current Produkt
KPIS (speed, OEE)
etc.

@krgrsebastian This issue seems to relate to your current Grafana plugin implementation.
Can you reference it in your PR, once you have finished it ?


mount input data files

// TODO: mount input data files

https://github.com/filecoin-project/bacalhau/blob/ab0aa3a1065133d19085ae7040e95df59e666f24/internal/runtime/runtime.go#L372

This is closed by the refactor branch - you can now declare input volumes in a job spec


No data in injected model when using RouteServiceProvider.php

Laravel Version: 7 or 8.*
PHP Version: 7.4.*
Database Driver & Version:
Postgresql and MariaDB

Description:
I have defined a group in app/Http/Kernel.php:
    protected $middlewareGroups = [
      'web' => [
        \App\Http\Middleware\EncryptCookies::class,
        \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
        \Illuminate\Session\Middleware\StartSession::class,
        \Illuminate\Session\Middleware\AuthenticateSession::class,
        //  \Illuminate\View\Middleware\ShareErrorsFromSession::class,
        \App\Http\Middleware\VerifyCsrfToken::class,
        \Illuminate\Routing\Middleware\SubstituteBindings::class,
      ],

      'api' => [
        'throttle:api',
        \Illuminate\Routing\Middleware\SubstituteBindings::class,
      ],

      'auth.api' => [
        \App\Http\Middleware\AddBearerToken::class,
        'throttle:60,1',
        'auth:api',
        \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
      ],
    ];

\App\Http\Middleware\AddBearerToken::class:
<?php

  namespace App\Http\Middleware;

  use Closure;
  use Illuminate\Http\Request;

  class AddBearerToken
  {
    /**
     * Handle an incoming request.
     *
     * @param $request
     * @param $next
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
      if (!$request->bearerToken()) {
        if ($request->hasCookie(env('ACCESS_TOKEN_NAME'))) {
          $token = $request->cookie(env('ACCESS_TOKEN_NAME'));
          $request->headers->add(['Authorization' => 'Bearer ' . $token]);
        }
      }

      return $next($request);
    }
  }

I define a new directory with routes in app/Providers/RouteServiceProvider.php:
    public function boot()
    {
      $this->configureRateLimiting();

      $this->routes(function () {
        Route::prefix('api')
          ->middleware('api')
          ->namespace($this->namespace)
          ->group(base_path('routes/api.php'));

        // Here
        Route::prefix('api/v1')
          ->middleware(['auth.api'])
          ->namespace($this->namespace)
          ->group(base_path('routes/Api/V1/Users/routes.php'));

        Route::middleware('web')
          ->namespace($this->namespace)
          ->group(base_path('routes/web.php'));
      });
    }

I create a route:
  Route::post('users/{user}/', function(User $user) {
    dd($user->toArray());
  });

In the output, I am getting an empty array.
But if I define this route, for example, in api.php like this:
  Route::prefix('v1')
    ->group(function () {
      Route::middleware(['auth.api'])->group(function () {
        Route::post('users/{user}/', function(User $user) {
          dd($user->toArray());
        });
      });
    });

The model is there. If this is not a bug, then why does it work like that?

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!


Proxy redirects don't seem to be rewriting the URL properly

1. Which version of Caddy are you using (caddy -version)?

5823dc22c1

2. What are you trying to do?

I'm trying to use Invidious proxied with Caddy to the world, and the URLs don't seem to be rewriting properly.
See https://github.com/omarroth/invidious/issues/542 for more context.
3.   Please paste any relevant HTTP request(s) here.

N/A
6. What did you expect to see?

The URL be rewritten properly
7. What did you see instead (give full error messages and/or log)?

The URL gets "non-rewritten," and is sending requests to the server that should just be /
8. Why is this a bug, and how do you think this should be fixed?

The URL seems to not be rewritten
9. What are you doing to work around the problem in the meantime?

N/A
10. Please link to any related issues, pull requests, and/or discussion.

https://github.com/omarroth/invidious/issues/542
Bonus: What do you use Caddy for? Why did you choose Caddy?

Because I've followed it since the beginning, and it's worked amazingly!

Howdy @ThatNerdyPikachu!
There's no rewriting going on in your Caddyfile at the moment. The /invidious part of the proxy directive is a base path, think of it like a filter that determines which requests go upstream. Even if it meets this base path, the entire URI gets sent to the upstream server, including the prefix /invidious.
If you want to remove the prefix, there's a proxy subdirective that does that:
proxy /invidious localhost:3000 {
  without /invidious
}

https://caddyserver.com/docs/proxy

Alright, [thank you!] I got the page loading (see https://i.pinged-b1nzy-for.fun/i/nl3aaahb.png
), but it's unstyled: https://i.pinged-b1nzy-for.fun/i/nl3aaahb.png, and the Login button, for example, takes me to /login, instead of /invidious/login
Originally posted by @ThatNerdyPikachu in https://github.com/omarroth/invidious/issues/542#issuecomment-494197927

Oh! Looking over that linked issue, it seems like you actually mean to proxy it into the subfolder.
I've written a bit about this problem in the past as it relates to Caddy. This post in particular has been seeing a bit of usage.
https://caddy.community/t/proxy-url-not-loading-site/5393/2
In short: Invidious needs to be able to set a Base URL / base path setting so that it accepts /invidious as a path prefix, OR you need to use a subdomain instead, OR you can try to get creative with Caddy's http.filter and proxy header rewriting (which can range from simple to extremely complicated).

Just a different thing, I tried doing what you mentioned in https://caddy.community/t/proxy-url-not-loading-site/5393/7, my Caddyfile is something like this:
subdomain.myurl {
...
}

anothersubdomain.myurl {
...
}

And it's saying that subdomain.myurl.. is an invalid directive.
Am I doing this wrong or something?

Caddy will do that if the braces aren't matched properly. You might be short one, perhaps one of your directives in the first site has a block missing its own closing brace?

I might just close this issue, too, because it doesn't look like it's a bug or anything, just help with configuration.
Feel free to keep fielding questions here in the closed issue, but the Caddy Community is the best place to get this kind of help.

alright.
yeah:
my-url:2500

subdomain.my-url:2500 {
	proxy / localhost:3000
	basicauth / username password
}

Error during parsing: Unknown directive 'subdomain.my-url:2500'

Yeah, if you're putting in multiple sites, each site block needs to be a block of its own.
Way it is now, it thinks the latter is a directive of the former.
You can just add an empty block - open a brace { on the end of the 1st line, and close the brace } on the beginning of the next line.

@whitestrake Alright, last thing I'll ask you, but is there a way to share http.login and http.jwt logins across subdomains?

@ThatNerdyPikachu you can use the snippets feature to copy the same blocks between site definitions: https://caddyserver.com/docs/caddyfile#snippets
But otherwise, that would be a question for the plugin authors (https://github.com/tarent/loginsrv and https://github.com/BTBurke/caddy-jwt) if you need that feature.


Automatic update check at application start

Whenever a user starts or goes back to the app, it queries the web to see if there's updates since the last sync and offers to update the data.

Do you envision this working differently than setting Sync Mode to On Startup (Always)?

Oh... Only slightly.  Instead of it Always syncing on startup, it would
only sync if there have been changes on the website.  But, this option is
good enough for the first release.
On Thu, Jul 21, 2016 at 8:45 AM, MorganRodgers<EMAIL_ADDRESS>wrote:

Do you envision this working differently than setting Sync Mode to On
Startup (Always)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MorganRodgers/Macroinvertebrate-Field-Guide/issues/38#issuecomment-234295407,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APdwHbG8FvMXe8WdY-p5RCOGCeyea6tnks5qX5QTgaJpZM4JRTgh
.


Investigate using node-config

Right now our config story is fairly basic - config/environment.js plus (broken) .env support.
The challenge is that we want to support simple deployment use cases, i.e. "I just git push my app to Heroku", all the way through complex cases, i.e. "I manage my own multi-AZ, HA, VPC server fleet running Kubernetes with a couple snowflakes as well".
The ideal solution would start out simply, and scale up. node-config looks like a good contender.

So this is unfortunately a bit more problematic than I was hoping.
node-config seems to take the opinionated approach. Rather that simply encapsulating the "load these files in this order, plus env vars, etc" functionality, it wants to run the show. This makes things tough for Denali, which has plenty of opinions of it's own.
The biggest showstopper is that addons need the ability to affect their consuming app's configuration, and node-config seems designed to prevent exactly that. The best it offers is util.loadFileConfigs, which lets us load any directory as if it was the main config directory. But this just gives us an object that is the result of running node-config against that directory. This falls short of the current implementation, which gives the app config to each addon, giving them the chance to mutate the config.
While this child-mutating-parent seems odd at first, I think it could enable all kinds of interesting functionality. A trivial example: imagine an addon that integrates support for Hasicorp's Vault. It might want to scan the entire app config and modify / inject values based on leased secrets extracted from Vault. Of course this requires addons to be "good citizens" and not troll the app config, but in my experience that kind of behavior is relatively rare.
I also don't love the env var implementation - basic Heroku style deployments would require a special custom-environment-variables.json mapping file to map the flat env var names to node-config's nested object structure.

we ended up using nconf in Ghost's new 1.0 configuration setup, and it seems to work pretty well. It's not as structured as node-config, which makes it much more flexible.

@acburdine is there anything in particular you like about nconf that isn't present in our current config loading approach (assuming we fix .env files)?

Closing this for now, going to stick with our existing approach + moving dotenv to the CLI. Happy to revisit if anyone has some specific wants/needs that our current approach isn't ideal for, but I'd rather move forward with what's working for now rather than ruminate forever on the perfect approach.


Updated styling for add items page

These changes don't seem like they'll have any side effects I'd need to account for. They might alter some of Jillian's recent changes, but Jillian will know better than I on that.


Updated Partner Name for Northrop

Updated Partner Name for Northrop

@todorgb : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Event PointerPressed doesn't work in OpenGlControl

public class OpenGlControl : OpenGlControlBase
{
    public OpenGlControl()
    {
        PointerPressed += OpenGlControl_PointerPressed;
    }

    private void OpenGlControl_PointerPressed(object? sender, Avalonia.Input.PointerPressedEventArgs e)
    {
        Console.WriteLine("press");
    }

    protected override void OnOpenGlRender(GlInterface gl, int fb)
    {
    }
}

version: avalonia11-preview5

I confirm that this does not work.  I have tried to use both methods below and neither of them will fire the event.
// This does not work . . .
AddHandler(PointerPressedEvent, OnPointerPressed, handledEventsToo: true);

// Or this . . .
AddHandler(PointerPressedEvent, OnPointerPressed, handledEventsToo: false);

// Or this . . .
this.PointerPressed += OnPointerPressed;

I'm also encountering this issue.
My guess is the OpenGlControlBase is "transparent" to the logic that decides which control is under the cursor.
This is supported by looking at a window with one, with the Avalonia DevTools:

On the following screenshot I click on my control derived from OpenGlControlBase (the green background with orange triangle), which should breakpoint/print a message. Neither happens so we conclude the event isn't fired.
Note my cursor is on the OpenGL control, but the DevTools only show :pointerover on the MainWindow window. I think this means the events are simply not fired because to Avalonia i'm clicking simply the window, not the OpenGL control at all.

Reproduce:
clone https://github.com/Dragorn421/DragoStuff/tree/ea3b9f4ae60ef47d95d914eec6100821f4eb2435
and add
    protected override void OnPointerPressed(PointerPressedEventArgs e)
    {
        Console.WriteLine("OnPointerPressed " + e);
    }

to MyOpenGLControl.cs

I don't know if this is me doing something wrong, if there needs to be an option in the subclassed control enabled to receive pointer events, but the docs don't mention any of that

I think the "real" solution involves more, but good to have a workaround at least


deps: Bump com_github_google_perfetto -> 1.7.1

Fix #23925
Signed-off-by: Ryan Northey<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

not sure if this needs to be updated with #24584 given sync version numbers - that one fails with a new dependency issue i think

/lgtm deps


Update dependencies and lock pint at 1.5

This PR locks Pint at 1.5 as 1.6 is for PHP 8.1+

Sorry if there's context I'm missing here, but wouldn't ^1.2 still work? Assuming Pint is only installed via Duster and not directly, and so the end user doesn't have any Pint version constraint, users on PHP 8.1+ would get Pint 1.6 or higher and users on PHP 8.0 would get Pint 1.5 or lower, right?

@bakerkretzmar Duster is now a Laravel Zero app packaged and released as a Phar.  It gets built with Pint included so need to lock at 1.5 to support earlier versions of PHP.

Ahh gotcha 👍🏻