TEST: Do NOT Merge (pls)

Do NOT merge - TEST

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Lowestcategoryscore
Spellingissues
Scorecard
Processed

articles/overview/what-is-qsharp-and-qdk.md
88
60
0
link
:white_check_mark:

articles/quickstarts/index.md
87
72
0
link
:white_check_mark:

articles/quickstarts/install-command-line.md
84
68
1
link
:white_check_mark:

articles/tutorials/explore-entanglement.md
84
56
3
link
:white_check_mark:

articles/tutorials/quantum-random-number-generator.md
88
74
0
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Docs Build status updates of commit 837a5c4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/overview/what-is-qsharp-and-qdk.md
:white_check_mark:Succeeded
View

articles/quickstarts/index.md
:white_check_mark:Succeeded
View

articles/quickstarts/install-command-line.md
:white_check_mark:Succeeded
View

articles/tutorials/explore-entanglement.md
:white_check_mark:Succeeded
View

articles/tutorials/quantum-random-number-generator.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


SBT should support triggered execution.

Current generation breaks SBT's triggered execution in that the generated files trigger a new execution run, looping indefinetly, e.g.:
[play-swagger-test] $ ~compile
[info] Compiling 9 Scala sources to /Users/marco/Code/play-swagger-test/target/scala-2.11/classes...
[success] Total time: 3 s, completed Oct 13, 2015 6:09:16 PM
1. Waiting for source changes... (press enter to interrupt)
[info] Compiling 9 Scala sources to /Users/marco/Code/play-swagger-test/target/scala-2.11/classes...
[success] Total time: 3 s, completed Oct 13, 2015 6:09:21 PM
2. Waiting for source changes... (press enter to interrupt)
[info] Compiling 9 Scala sources to /Users/marco/Code/play-swagger-test/target/scala-2.11/classes...
[success] Total time: 3 s, completed Oct 13, 2015 6:09:24 PM
3. Waiting for source changes...
<never stops>

Fixed in 0.1.5


New revive 2.4.4 multiplies health

Hello,
I had a Sprite with health 3 and not alive, when I call revive(3) the Sprite now has health = 9
I have no maxHealth defined, so I expected for this to leave the health as is, since it was not 0
Or is this supposed to work like this now that the "heal" function is taking place? If yes, then I will have to check whether or not the Sprite has 0 health before I revive it with the health argument, or to define a maxHealth property. Correct?
Thanks.

The maxHealth is defaulted at 100. I can't imagine why it would multiply to 9. Maybe 6 as heal adds health, so if it already had 3, and the max is 100 then it will keep adding. Perhaps it got called twice to get to that 9.

Fixed in dev.


(SP: 1) Create an endpoint for toggling bookmarks

Create a patch endpoint that will receive an offer ID and add it to the user's bookmarkedOffers array if the array doesn't contain the offer ID. If the array contains the offer ID the ID must be removed from the array.

this issue should be created for a backend repo


Unable to use some keyboard shortcuts while focused in terminal

Since the January 2022 update that I received today, I can't hide/close the side panel while I'm focused on the terminal. The new command is workbench.action.toggleAuxiliaryBar. It seems that I can't do any simple keyboard shortcut while in the terminal, other than workbench.action.focusLastEditorGroup.
The following shortcuts work.
{
	"key": "alt+t",
	"command": "workbench.action.focusLastEditorGroup",
	"when": "terminalFocus",
},
{
	"key": "ctrl+shift+w",
	"command": "workbench.action.toggleAuxiliaryBar",
	"when": "terminalFocus",
},

However, the following shortcuts don't work.
{
	"key": "ctrl+w",
	"command": "workbench.action.toggleAuxiliaryBar",
	"when": "terminalFocus",
},
{
	"key": "alt+w",
	"command": "workbench.action.toggleAuxiliaryBar",
	"when": "terminalFocus",
},

I don't see a pattern here, so it looks like there might be multiple bugs. I can't use simple shortcuts sometimes, and other times I can.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.64
OS Version: Windows 10

Steps to Reproduce:

Assign one of the 2 broken shortcuts listed above.
Open a file
Focus on the terminal
Try to use the key

@RobbyCBennett this is because Alt+w is being eaten by the terminal. You will need to add to the setting terminal.integrated.commandsToSkipShell => workbench.action.toggleAuxiliaryBar


[SP-2456]PDI-11215: Cannot Edit Multiway Merge Join After Deleting an…

… Input Hop.
Error occurred because different parts of the dialog had a different idea of what the input steps were (previous steps according to transformation vs infosteps as per step meta configuration). This fix takes both into account so that any newly linked input steps can be configured, and any saved configuration does not get lost when the incoming hop is disabled.
To make this work the step's rowprocessor needed to be modified as well and this now takes all input steps into account that are also present as info stream. This allows a disabled incoming hop to be ignored during row processing (as it should).

@e-cuellar Could you review it please?


feat Support materailze CTE

Proposed changes
Before this PR, new optimizer would inline CTE directly. However in many scenario a CTE could be referenced many times, such as in TPC-DS tests, for these cases materialize the result sets of CTE and reuse it would significantly agument performance. In our tests on tpc-ds related sqls, it would improve the performance by up to almost 4 times than before.
We introduce belowing plan node in optimizer

CTEConsumer: which hold a reference to CTEProducer
CTEProducer: Plan defined by CTE stmt
CTEAnchor: the father node of CTEProducer, a CTEProducer could only be referenced from  corresponding CTEAnchor's right child.

A CTEConsumer would be converted to a inlined plan if corresponding CTE referenced less than or equal inline_cte_referenced_threshold (it's a session variable, by default is 1).
For SQL:
EXPLAIN REWRITTEN PLAN
WITH cte AS (SELECT col2 FROM t1)
SELECT * FROM t1 WHERE (col3 IN (SELECT c1.col2 FROM cte c1))
UNION ALL
SELECT * FROM t1 WHERE (col3 IN (SELECT c1.col2 FROM cte c1));

Rewritten plan before this PR:
+------------------------------------------------------------------------------------------------------------------------------------------------------+
| Explain String                                                                                |
+------------------------------------------------------------------------------------------------------------------------------------------------------+
| LogicalUnion ( qualifier=ALL, outputs=[col1#14, col2#15, col3#16], hasPushedFilter=false )                                                           |
| |--LogicalJoin[559] ( type=LEFT_SEMI_JOIN, markJoinSlotReference=Optional.empty, hashJoinConjuncts=[(col3#6 = col2#8)], otherJoinConjuncts=[] )      |
| |  |--LogicalProject[551] ( distinct=false, projects=[col1#4, col2#5, col3#6], excepts=[], canEliminate=true )                                       |
| |  |  +--LogicalFilter[549] ( predicates=(__DORIS_DELETE_SIGN__#7 = 0) )                                                                             |
| |  |     +--LogicalOlapScan ( qualified=default_cluster:test.t1, indexName=t1, selectedIndexId=42723, preAgg=ON )                                    |
| |  +--LogicalProject[555] ( distinct=false, projects=[col2#20 AS `col2`#8], excepts=[], canEliminate=true )                                          |
| |     +--LogicalFilter[553] ( predicates=(__DORIS_DELETE_SIGN__#22 = 0) )                                                                            |
| |        +--LogicalOlapScan ( qualified=default_cluster:test.t1, indexName=t1, selectedIndexId=42723, preAgg=ON )                                    |
| +--LogicalProject[575] ( distinct=false, projects=[col1#9, col2#10, col3#11], excepts=[], canEliminate=false )                                       |
|    +--LogicalJoin[573] ( type=LEFT_SEMI_JOIN, markJoinSlotReference=Optional.empty, hashJoinConjuncts=[(col3#11 = col2#13)], otherJoinConjuncts=[] ) |
|       |--LogicalProject[565] ( distinct=false, projects=[col1#9, col2#10, col3#11], excepts=[], canEliminate=true )                                  |
|       |  +--LogicalFilter[563] ( predicates=(__DORIS_DELETE_SIGN__#12 = 0) )                                                                         |
|       |     +--LogicalOlapScan ( qualified=default_cluster:test.t1, indexName=t1, selectedIndexId=42723, preAgg=ON )                                 |
|       +--LogicalProject[569] ( distinct=false, projects=[col2#24 AS `col2`#13], excepts=[], canEliminate=true )                                      |
|          +--LogicalFilter[567] ( predicates=(__DORIS_DELETE_SIGN__#26 = 0) )                                                                         |
|             +--LogicalOlapScan ( qualified=default_cluster:test.t1, indexName=t1, selectedIndexId=42723, preAgg=ON )                                 |
+------------------------------------------------------------------------------------------------------------------------------------------------------+

After this PR
+------------------------------------------------------------------------------------------------------------------------------------------------------+
| Explain String                                                                                |
+------------------------------------------------------------------------------------------------------------------------------------------------------+
| LogicalUnion ( qualifier=ALL, outputs=[col1#14, col2#15, col3#16], hasPushedFilter=false )                                                           |
| |--LOGICAL_CTE_ANCHOR#-1164890733                                                                                |
| |  |--LOGICAL_CTE_PRODUCER#-1164890733                                                                                |
| |  |  +--LogicalProject[427] ( distinct=false, projects=[col2#1], excepts=[], canEliminate=true )                                                    |
| |  |     +--LogicalFilter[425] ( predicates=(__DORIS_DELETE_SIGN__#3 = 0) )                                                                          |
| |  |        +--LogicalOlapScan ( qualified=default_cluster:test.t1, indexName=t1, selectedIndexId=42723, preAgg=ON )                                 |
| |  +--LogicalJoin[373] ( type=LEFT_SEMI_JOIN, markJoinSlotReference=Optional.empty, hashJoinConjuncts=[(col3#6 = col2#8)], otherJoinConjuncts=[] )   |
| |     |--LogicalProject[370] ( distinct=false, projects=[col1#4, col2#5, col3#6], excepts=[], canEliminate=true )                                    |
| |     |  +--LogicalFilter[368] ( predicates=(__DORIS_DELETE_SIGN__#7 = 0) )                                                                          |
| |     |     +--LogicalOlapScan ( qualified=default_cluster:test.t1, indexName=t1, selectedIndexId=42723, preAgg=ON )                                 |
| |     +--LOGICAL_CTE_CONSUMER#-1164890733#1038782805                                                                                |
| +--LogicalProject[384] ( distinct=false, projects=[col1#9, col2#10, col3#11], excepts=[], canEliminate=false )                                       |
|    +--LogicalJoin[382] ( type=LEFT_SEMI_JOIN, markJoinSlotReference=Optional.empty, hashJoinConjuncts=[(col3#11 = col2#13)], otherJoinConjuncts=[] ) |
|       |--LogicalProject[379] ( distinct=false, projects=[col1#9, col2#10, col3#11], excepts=[], canEliminate=true )                                  |
|       |  +--LogicalFilter[377] ( predicates=(__DORIS_DELETE_SIGN__#12 = 0) )                                                                         |
|       |     +--LogicalOlapScan ( qualified=default_cluster:test.t1, indexName=t1, selectedIndexId=42723, preAgg=ON )                                 |
|       +--LOGICAL_CTE_CONSUMER#-1164890733#858618008                                                                                |
+------------------------------------------------------------------------------------------------------------------------------------------------------+

Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


added missing embedding_function param in get_or_create_collection

Description of changes
Added a missing param(embedding_function) for get_or_create_collection as mentioned in #304

Thank you! Can we add tests for get_or_create_collection with embedding functions?

Sure. I'll add them

@HammadB I guess the tests are already included for get_or_create_collection with embedding functions. The only change made here was that the abstract class function signature didn't match with the actual implementation.

@shivankar-p Right now the test doesn't check if the embeddings themselves are the same, just that they exist by looking at the len() could you add that?

@HammadB does the latest commit look good? If this is fine I will update similarly for other tests like get_collection etc. because they are also just tested on len()

Thank you - This looks great! I think we can tackle that on a separate PR if you are up for that!


Impossible to set examples for enums?

Example
Here's a self-contained, minimal, reproducible, example with my use case:

from fastapi import FastAPI

app = FastAPI()

class SomeValue(str, Enum):
   a = 'a'
   b = 'b'

@app.get("/")
def read_root(query_value: SomeValue = Query(..., example='a')):
   # Doesnt matter what happens here
    return {"Hello": "World"}

Description
I set an example for query_value but in the openapi-schema this example is ignored and doesn't appear.
Is that intended or a bug? I need to set a specific example for every parameter (as required by our testsuite) and I don't see why it shouldn't be allowed to set one for enums.
Environment

OS: Windows 10

FastAPI Version 0.60.1

Python version: 3.8

There are imports missing on the minimal example :sleeping:
Only the body example appears in the possible responses field. You already have the possible values in the query field, so I don't understand exactly the reason why you need it for your testsuit.

I'm sorry for the missing imports, I edited it.
We have a guideline that every parameters needs an example and our testsuit has a test where it explicitly tests each endpoint with its examples (which it gets from the created /openapi.json).
This is because we need to provide an example endpoint call that 100% works, otherwise the ui designers are complaining.
I understand that for enums all possible values are already present but I don't understand why examples for enums are removed.

found a workaround
from enum import Enum

from fastapi import FastAPI, Query

app = FastAPI()

class SomeValue(str, Enum):
    a = 'a'
    b = 'b'

    @classmethod
    def __modify_schema__(cls, field_schema):
        # __modify_schema__ should mutate the dict it receives in place,
        # the returned value will be ignored
        field_schema.update(
            example='b',
        )

@app.get("/")
def read_root(query_value: SomeValue):
    # Doesnt matter what happens here
    return {"Hello": "World"}

Thanks for the help here @Kludex ! :clap: :bow:
Thanks for reporting back and closing the issue :+1:


Refactor ADR(s) to conform with MADR style

This PR aims to follow open ADR standards by following the style of MADR backed by a tooling to easily initialize new ADR(s) with a pre-defined template. There is also the possibility of building a static site out of this and deploy it to GitHub Pages as well.

Refactors all available ADR(s) to conform to the style of MADR
Uses log4brains tooling to init new ADR(s) with a pre-defined template
Fixes several typos
Minimal documentation on how to get started to write new ADR(s)

@auhlig - Since the ADR(s) were moved from internal repository, I am missing timeline of the created ADR(s). Could you point me to the internal repository, if it exists? Then I can update the timeline of the ADR(s). Currently they all point to yesterday's date.

re-opened in #8


chore: remove kintsugi capacity migration

Should be executed soon anyway

This is also included in https://github.com/interlay/interbtc/pull/960

We won't merge #960 before the governance update


⚠ Bofrost.fr has degraded performance

In 6a39690, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 987 ms

Resolved: Bofrost.fr performance has improved in e26f451 after 6 minutes.


Modify the trigger function parameter description

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.西流 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 92.234% when pulling e6f929cdd20bdd286d069ccad78d8b194bb372e0 on trigger into aa604fbbf50bba829df96297167a6c7b0aed7b55 on master.


Discount and default interest (BT-20)

Hello,
I'm looking for the possibility to transmit discount (SKONTO). According to the definition, this currently has to be done in BT-20 as a string.
[https://www.zugferdpro.com/skonto-und-verzugszinsen-bt-20/]
I'm currently missing the BT-20 area, is there anything else coming?
PaymentTermsDescription

BT-20 is:
    pt = PaymentTerms()
    pt.description = "Text for BT-20"
    doc.trade.settlement.terms.add(pt)


escaped quation marks  (  " or ' ) or any quotation marks - cause parser.js to crash the application

Ok This seems to be a problem with the parser.js
Whenever you have escaped quotation marks inside <<mytest(\"test\")>>, this crashes the parser and the object fails to load.
This is the error message
VM122:156 Uncaught Error: Parse error on line 2: Unexpected 'LeftParen'
this is where it happens
const parserNodes = Array.from(parser.parse(yarnNode.body));

Ok I have never actually written a parser, so adding a new rule in parser.js is totally over my head. I have no idea how that thing is set up and tutorials seem to be scarce

Adding this line to parser.js > command: [...]
['BeginCommand Text LeftParen Text RightParen EndCommand', '$$ = new yy.TextNode($2,$3,$4,$5);'],
This is guessingg the syntax a little bit. I must be getting it wrong
I now get
VM122:159 Uncaught Error: Parse error on line 11: Unexpected 'EndOfInput'

ok here goes something, adding:
['BeginCommand Identifier LeftParen RightParen EndCommand', '$$ = new yy.CommandNode($2,$3,$4,$5);'],
Now allows me to use <<myfunction()>>
However, I still need to figure out how to allow triggering a function with parameters

Ok Here when I try the same with parameters:
['BeginCommand Identifier LeftParen arguments RightParen EndCommand', '$$ = new yy.CommandNode($2+ "("+ $4 + ")");'],
The problem is that it is returning myfunction([object object]) instead of myfunction(parameter,parameter)

Ah  ok, sorry for the monologue.. I think I figured it out now and even implemented a new node type (jsEval Node). I added it to my pull request here:
https://github.com/jhayley/bondage.js/pull/33

It looks like this issue is centered around this line in the lexer states. When this state is arrived at from the command state there's no differentiation of whether or not it's coming from at the beginning of a command vs after an <<if
This is incorrect because <<if visited("blah")>> is valid syntax but <<visited("blah")>>` is not. The latter should be sent to the command handler. (I'm actually not sure how/if this edge case is handled in yarnspinner but I don't have time to test right now).
If you would like to put in a pull request for this, you should be able to fix it by adjusting the lexer states in that file such that it knows that a yarn function cannot be called from the beginning of the command block. Let me know if you have any questions.
Good catch!

@jhayley thank you for helping me understand how this is set up.
We have to remember that yarnspinner was written for Unity specifically and in our case - with bondage.js we really are targetting js based environments, where the <<functionCall("parameter")>> syntax would be very useful to allow :)
It doesnt have to negate in any way what is already established
I will look into adding it to the command in another pull request.
Sorry that in the previous pull where I did that by creating a new type

@jhayley the problem with the command handler is that you have to set it in advance:
runner.setCommandHandler((command) => {
  // Called whenever there is a <<command>>, the parameter being the text inside
});

Where as in my case I want to do it more reactively by using a syntax akin to how text is parsed.
  if (result instanceof bondage.CommandResult) {
    console.log(result.text);
}

I guess thats why in my previous pull request I created a new node type- so I can return it like that.
Would you be ok If the commandResult gets added as a return type?

Would you be ok If the commandResult gets added as a return type?

Fun fact, this used to actually be how commands worked. I'm uh...honestly not sure why I changed it. I still only want to have one way to handle commands so we should remove the callback way which means this would be a breaking api change. I think this is an ok change for consistency between callback results, and it makes sense that it would be easier to handle that way. So feel free to change this, it shouldn't be too hard. Also remember to change the readme to reflect this change in the example.
For the record, this part should be a separate pull request.

Should it be a commandResult type or it's own type (specific to if its detected as a js function call ) like my previous pull?

It should be a CommandResult in results.js

The advantage of having it be it's own is that you can apply different treatment to
<<command command>>and <<callfunction()>>

I disagree that these should be handled as separate cases. We should leave it up to the user to discern the difference between them. Handling it in bondage is undeeded complexity and obfuscates things for people that expect to be able to use parenthesis in commands and have them returned as strings which is the expected behaviour generally for commands.

closed via https://github.com/jhayley/bondage.js/pull/40
Thank you @jhayley for reviewing this and for explaining some of the workings of the lexer :) 👍


[TASK] Bar chart - features

Description
Features for bar chart in both Vega and Echart
Existing
Reference
Tasks
Tools include:

[x] Legend - toggle on/off
[x] Customize value labels
[x] Display value labels
[x] Tooltips  - toggle on/off
[x] Trendlines - toggles on/off

Trendlines - Toggle on/off - working


Allow user set smb port (proper fix)

Task editor: If we specify the SMB port manually (exp 445), listing the shares and selecting folders in remote sbm server fails.
However, the sync was properly executed if we select Share name and Folder name manually in the Task Editor.

This fix is better than the simpler previous one
Appending the ":" to the port number should only be done by the function reconstructing the complete host_url (host_url = host_protocol + host_name + ":" + host_port)
That way host_port remains a string "number" across all the code to be manipulated as needed

Merge your commit.

:-)


Mailer because the name is already in use

Generated Mailable using artisan,
php artisan make:mail ConfirmationEmail

Content:
<?php

namespace App\Mail;

use Illuminate\Bus\Queueable;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;

class ConfirmationEmail extends Mailable
{
    use Queueable, SerializesModels;

    public $newUser;

    /**
     * Create a new message instance.
     *
     * @return void
     */
    public function __construct($user)
    {
        $this->newUser = $user;
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        return $this->view('emails.confirm')->subject('E-Mail Confirmation');
    }
}

When sending mail by web it throws:
FatalErrorException in Mailable.php line 10:
Cannot use Illuminate\Contracts\Mail\Mailer as Mailer because the name is already in use

But when sending through tinker it works ok.

Are you using the very latest version?

Sorry, forgot to say.
composer.lock:
[...]
"name": "laravel/framework",
"version": "5.3.x-dev",
[...]

Please show me the actual commit of laravel/framework you're using.

The commit is 81c4428924fd565bfaca3941402be29cd384f8d4


Cannot use Unicode characters in Electron Apps

[ids]

[main]
capslock = layer(capslock)
f13 = leftmeta
control = layer(ctrl)
[capslock:C]
' = ß
j = ä
k = ö
l = ü
; = å
f1 = f13
f2 = f14
f3 = f15
f4 = f16
f5 = f17
f6 = f18
f7 = f19
f8 = f20
f9 = f21
f10 = f22
f11 = f23
f12 = f24
shift = layer(capslock_shift)
[capslock_shift]
' = ß
j = Ä
k = Ö
l = Ü
; = Å
[ctrl:C]
capslock = capslock
See title
Symbols like ö or å work in many places, but not in apps like Chromium based apps (Brave, Discord) or Obsidian
Instead of ö it prints 03a
My System:
Fedora 41 KDE Plasma
Wayland

Very unfortunate. This is the same as #273, right? If there are some other ways to generate these keys in the system layout you're using, you could write them using macros as a workaround.

Oh yeah, sorry then it's a duplicate.

I solved plenty of issues by creating a "special" english keyboard, basically standard US with non-English language in lv3+4, and various dead keys to remaining "free" keys (numbers). Then by using macro it should be indeed possible to easily activate either common characters (explicitly mapped in custom) or at least activate a dead key (didn't test it but it should work).


Do not attempt to commit the already committed block

Fork resolution decides if a newly arrived block
should be chosen over current chain. However
if duplicate block is received from the validator
the consensus engine shall ignore the block and not
try to commit again.
Signed-off-by: S m, Aruna<EMAIL_ADDRESS>

@kulkarniamol @manojgop

This seems like a pretty late-in-the game time to evaluate duplicates.  Shouldn't this be done when a new block is received?

This seems like a pretty late-in-the game time to evaluate duplicates. Shouldn't this be done when a new block is received?

I thought of it earlier but then proceeded with the solution in this patch because of the way the function is written. This function has single return statement. This function assumes that even though block id is same for two blocks (the chance that rarest collision has occurred in hashing algorithm), still verify that previous blocks are not same, their mean time is different etc checks which follows PoET algorithm.


Events: the "Guest" tab generates some warnings

like
Warning: Undefined array key "date_start" in [path_to_UNA]modules/boonex/events/classes/BxEventsMenuViewActionsAll.php on line 30 Call Stack

Fixed in https://github.com/unaio/una/commit/cd96f5df66999b5cc5067b47a39f00a5a43c39cb


tsp-openapi3 - update to group items by namespace when separated by dot, and escaped otherwise invalid identifiers

Fixes #3810 and replaces #3808
This PR does 2 things:

Groups operations/models into namespaces based on the dots in their schema names/operationIds.
Escapes invalid identifiers by surrounding them with backticks.

All changed packages have been documented.

:white_check_mark: @typespec/openapi3

Show changes
@typespec/openapi3 - feature ✏

Updates tsp-openapi3 to escape identifiers that would otherwise be invalid, and automatically resolve namespaces for schemas with dots in their names.

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Master

Added in a plugin for updating metadata in LadioCast.app

Added a plugin that should update the track metadata for LadioCast streaming


Hey how can give  after some " . " regex?

Hey first of all thank you so much this packages
My question is that how can I add  tag after 2 or 3 or 4  " . "

Hi @vipin733,
Thanks for submitting.
Please read the contribution guidelines and provide the required information named there.

never mind i just solved


Add CHANGELOG.md

Fixes #34.

We'd been using https://github.com/graphql/graphql-relay-js/releases in the past for this (so you could add the info on 0.3.3 there and then link to https://github.com/graphql/graphql-relay-js/releases/tag/v0.3.3)

Just added the info from this PR into https://github.com/graphql/graphql-relay-js/releases/tag/v0.3.3

Ah cool. Makes sense to only have it in one place. Let me resubmit this as a link to the releases page.

Let me resubmit this as a link to the releases page.

Perfect!


some mobile can't support "el.closet()"

Ionic version: (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[] 2.x
[X] 3.x
I'm submitting a ... (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
I use  and run in MeiZu， it report errors "undefined is not a function"

the browser's UA： Mozilla/5.0 (Linux; Android 5.1; m3 Build/LMY47I) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/40.0.2214.117 Mobile Safari/537.36
and I find this problem is cause by "el = el.closest(selector);"

Hello, thanks for using Ionic! It looks like you are running on an old chrome webview. Most likely, Meizu is not using the modern chrome webview that comes with Android and is instead using their proprietary version of it that unfortunately, does not support modern web standards. To get around this and ensure your app is using a modern chrome webview I would recommend using crosswalk.


FY2019Q4 Refresh

Updated instructions for all exercises and demos
Updated project files for all exercises
Fixed typo in slide deck for Ex 2

manually merged


Avoid wiping quickfix list on :RescriptFormat

(This probably applies to the :RescriptBuild command as well)
On format, the users quickfix list should not be wiped, since it can be a list of stuff unrelated to Rescript.
Currently, it is getting wiped here:
https://github.com/rescript-lang/vim-rescript/blob/08de54132587131e762b036c11e0e9a9603992fa/autoload/rescript.vim#L164
I think this should be achievable using quickfix IDs.
Thanks

yeah, i made this because I didn't know how to isolate quickfix results to certain scope. Didn't know about ids... currently I don't consider this a very big problem (except for wiping e.g. build errors from quickfix.. but for that I usually just rerun the build real quick with a hotkey).
Don't have much time right now to fix this right away, so I would be open for a PR!


Add HOMEBREW_FORCE_BOTTLE variable

This does the equivalent of always passing --force-bottle. This will be enabled by default on Mojave to allow people to avoid building everything from source until our porting and bottling is a bit further along.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Please do not file issues if you encounter errors when using this environment variable.

If this is the default behavior for non-developers, why the don't-file-issues statement?

If this is the default behavior for non-developers, why the don't-file-issues statement?

I'm exposing the internal variable that we set automatically for users on Mojave (who are already told not to file issues). Thoughts?

This is causing the bottles to be used even when they shouldn't be (i.e. when using options, bottle is still used). Should I just set HOMEBREW_NO_FORCE_BOTTLE instead?
$ brew upgrade
==> Upgrading 1 outdated package, with result:
vim 8.1.0200 -> 8.1.0202
==> Upgrading vim --with-override-system-vi --with-gettext --with-client-server --with-lua --with-tcl
==> Downloading https://homebrew.bintray.com/bottles/vim-8.1.0202.high_sierra.bottle.tar.gz
######################################################################## 100.0%
==> Pouring vim-8.1.0202.high_sierra.bottle.tar.gz
🍺  /usr/local/Cellar/vim/8.1.0202: 1,434 files, 23.4MB

@iandrewt apologies yes set that for now.

@iandrewt I've opened a proper fix PR here: https://github.com/Homebrew/brew/pull/4542


Picking up image name from rhcos.json

This PR bumps stream-metadata-go to ed4342200417970d5f49ee40cddc5c417b49e0cb to pick up PowerVS support.
Currently this is using eu-de, I am uncertain the best long term solution for picking up the image's region.
This replaces PR 85.

After a quick glance, it looks like the commit message needs updating?

Currently this is using eu-de, I am uncertain the best long term solution for picking up the image's region.

Otherwise looks sound. Have you tested this out?

Yes, this fills the image name with the one from the rhcos.json file


New Page Request: Product's About Page

Right now, in our shop page, the products are listed, but each individual product isn't clickable. This is not going to be ok if our project scales up, since we want to display more information for each product. For example, a short description of the project, how long it is able to be shipped, etc.
We would need a separate page, so that whenever the user clicks on the image of a certain product, it would bring them to that product's about image. We would need a new component in the page folder to do that.
This issue is currently open to discussion as we need to first figure out the design, layout, as well as content of what should be included in the page.
Feel free to leave any ideas or suggestions here and whether you are interested in working on this issue.

Does this need to be done?


Fix Syntax Error: Remove Trailing Comma from Code Snippet

Remove trailing comma for syntax correctness
Motivation:
The trailing comma in the code snippet is a syntax error in Swift.
Modifications:
Removed the trailing comma from the @Test macro in the code snippet.
Result:
The code snippet is now syntactically correct and consistent with Swift standards.

@swift-ci please test

@swift-ci please test Linux

@swift-ci please test


zipkin lens UI bugs / improvements

These issues / improvements are not worth of separate tickets so I'm filing them together

[x] search page result rows and traces are mismatched: https://www.dropbox.com/s/60s8vmz4ogmbt7g/Screenshot 2019-01-16 14.13.56.png As you can see in the screenshot the result row says there are a lot of services and spans, but the trace viewer shows very few. I think the result lines and the trace data are simply mismatched.
[ ] opinionated change: it'd be nice if the search button was on the right or at least it was it bigger to make it obvious you need to click that
[x] there's no favicon
[ ] it's be nice if the search dropdowns had tooltips on what should go in them, mostly the annotation query. Like some examples of what people can do with it
[x] I'd also remove the default "error" annotation query since we don't default any other field
[ ] remove the - from the custom time picker since it makes the boxes unaligned: https://www.dropbox.com/s/tzu82pyczl5lzya/Screenshot 2019-01-16 16.25.24.png
[x] the + and - symbols from collapsing / expanding subtrees are inverted. I'd expect pressing + to expand, not to collapse the tree
[x] leaf spans should use remoteEndpoint service name rather than the localEndpoint. If the SERVER span exists, the server's localEndpoint should be used (same as now).
[x] it'd be nice if pressing enter executed the search
[x] the services list is not alphabetically ordered (span names are sorted instead)
[x] in the search results there should be a space between the number and "spans"
[x] since we have microsecond precision we should show also the microseconds when clicking on a span
[ ] the "serviceName" column is larger than it needs to (larger than the longer service name), the spanName column instead is super narrow
[ ] when I try adding a tags filter the ui gets very slow. The characters that I type appear very slowly, as if the JS is trying to do something with each of them. Querying the autocomplete api maybe? But I never enabled it.

the services list is not alphabetically ordered (span names are sorted instead)

resolved  #2434

@drolando I missed this list. thank you so much!

reinstate the 'x minutes ago' feature when listing traces.


 :D

What do you expect this to do?

adjust  fake_item:i@item  (including item scripts)
or - adjust dInventory.slot fake_item:i@item

would show a fake item on the specified slot in the specified inventory that preferably only exists on the client, or if it has to be, exists on the server (which then it would kind of be a replacement for trying to make an untouchable item in the inventory in dscript which is almost impossible)
if possible a duration would be possible to be added as a 2nd value behind the dItem.
if the player tries to grab the item it would update and dissapear

What would be the use case of a fake item that can't be used and only you can see?

Sounds useful to me.

possibilities could be:

a flashing example of the recipe in a workbench a player has to complete that doesn't interrupt his progress in the recipe.

Using the hotbar as a temporary GUI without it interrupting the behaviour to the server or obstructing the player too much

Could replace the item_message mechanism by doing

adjust player.item_in_hand "display_name:beautiful day today" save:item
adjust player.item_in_hand.slot fake_item:entry[item].result|10s

(though this isn't exactly a benefit, i thought i'd point it out)

The general idea is trying to get the possiblities to make some items clientside only to avoid any potential issues at all when trying to use Items for a more graphical than physical purpose

I think this would be a command, rather than a mechanism.
fakeitem [<inventory>] [<#>] [<item>] (duration:<duration>)
so
- fakeitem <player.inventory> 4 i@red_wool duration:3s
would show fake red wool at slot 4 in the player's inventory for 3 seconds

I vote slot:4 just for clarity - beyond that, I like it @Morphan1

could make slot:<#> optional, and the default is to show at the first open slot, like - give would.

What happens in the event they have something in that slot and are actively using it? Such as holding a sword and fighting? Would the item be changed only in the hotbar, or in their hand as well?

@AnthonyAMC it would change it in their hand because of the way Minecraft calculates that

Fun times... so would the player then be (un)able to place the block that is in that slot?

@AnthonyAMC In theory, if they right click, it should act just like if the real item is the only item involved. EG if you're holding a block before the fakeitem is applied, you'll still place that block.
it will probably also reset the item in your bar when you do that.

make it able to use the quantity property in the dItem beyond normal stack sizes just like unlimit_stack_size goes in the give command please, if that is not already default

I highly agree it being better as a command. can you add a player argument that takes a list input, so you can send the packets to multiple people at once, still only applying to the specified inventory?

Or just a list of inventories.
- fakeitem <server.list_online_players.parse[inventory]> i@stick

as long as there is full control over who gets the packet, and what inventories the packet recievers will see the item in, seperately

Oh I misunderstood your request, you have multiple people opening one inventory? In that case, yeah, a player list. Good idea.

@Morphan1 add pls

@Morphan1 you going to add?

Where's the inventory argument? it seems to only work for player inventories?

It works with any inventory the player has open. The inventory argument is actually illogical because if you don't have it open, you won't be able to see it

I was expecting you to be able to specify a location based inventory too, and send the packet to all players with that inventory opened

@BlackCoyote at that point, it's not even a fake item. It's an item that just doesn't save when the server shuts down and that you can't take, but is otherwise actually known by the server, albeit weirdly. If you wanna do that, use an event with the command

FINE D:<

oh and thanks btw c:


Useless try-catch block

There's no reason for the following try-catch block in HttpClient.kt, because there's the outer try-catch block that will catch any exception
                //try - catch just in case both methods throw
                try {
                    httpStatusCode = connection.responseCode
                    httpResponseMessage = connection.responseMessage
                } catch(exception: IOException) {
                    throw exception
                }

Thanks!

Removed!


X11docker not operational

Describe the bug
The system x11docker package does not works as planned.
Steps To Reproduce
Steps to reproduce the behavior:

Set up docker(I'm not currently using rootless at the time)
Switch to a shell with x11docker with nix-shell -p x11docker nx-libs
pull some necessary docker images, such as x11docker/xfce x11docker/xserver
make some attempts:
x11docker --desktop x11docker/fvwm

Expected behavior
A window should popup and display something.
Additional Context
The final error message for fvwm was:
x11docker ERROR: No container command specified and no CMD or ENTRYPOINT found in image.

  Type 'x11docker --help' for usage information
  Debug options: '--verbose' (full log) or '--debug' (log excerpt).
  Logfile will be: /home/erina/.cache/x11docker/x11docker.log
  Please report issues at https://github.com/mviereck/x11docker

The following error is also seen some times:
x11docker ERROR: start_container(): Did not receive PID of PID1 in container.
  Maybe the container immediately stopped for unknown reasons.
  Just in case, check if host and image architecture are compatible:
  Host architecture: amd64 (x86_64), image architecture: amd64.

I have this potentially important warning that was thrown:
/nix/store/k1yz4qzbi84hzxrg9ybl2prxx8caaj4r-x11docker-7.6.0/bin/.x11docker-wrapped: line 1099: -: command not found
x11docker WARNING: parse_inspect(): Error while parsing json for
  Architecture     (Line 5611)

Note that running x11docker/fvwm using docker run x11docker/fvwm works fine(with no x output)
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.23, NixOS, 24.05 (Uakari), 24.05pre604424.d8fe5e6c92d0`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/home/erina/.nix-defexpr/channels/nixpkgs`

Actually this worked once per many attempts, I'm moving this issue to x11docker instead.


How to enable Personalization on NextJS framework server side render? Can't  take effect on  server side render

Here is we are using framework: NextJS / React / klevu-core
We use next.js framework, because is good for SEO.
NextJS => klevu-core SDK=>   personalisation =>https://github.com/klevultd/frontend-sdk/blob/master/packages/klevu-core/docs/modules/personalisation.md
1> The Personalization will not take effect on  server side render. How can we achieve the Personalization functionality when rendering on the server side?
2> how to implement Personalization in a user-friendly way for existing/returning customers that have analytics data already. i.e. not reloading page content  =>   So far one idea for  Personalization only take effect on client, it means need to call Klevu API after page load(server side render)  and update page content again (client side reloading page content).  But we don't want to do it this way.

Hi @canyan1989

The tricky part is that Klevu uses the previously viewed product IDs to determine which products to boost/deboost; which makes the results personalized for the user's session. Since we typically store this information in the user's browser, you would need to somehow make these IDs available on the server in order to make personalization work.

Similarly to the information shared above, the tricky part is sending the IDs. If you can store the IDs on the server-side and tie it to the user's session, you could retrieve this information and send it when making the server-side requests.

This being an SDK, it's completely upto you on which mechanism you use. The SDK provides localStorage automatic storing and retrieving of the IDs, but you can modify the requests if you are providing the IDs. I hope this helps.

Hi @jerrypena1
Thanks, It's helpful. And have more question want to confirm:
1> About Point2, if we  modify the requests and provides the IDs on  server-side requests, but SDK provides localStorage automatic storing and retrieving of the IDs on client-side requests. Is it also correct?
2> For at same search condition, this case will case the different results between server-side and client-side?
3> If we want to keep same logic with SDK on server-side, How can we provides the Similarly IDs on  server-side requests?
4> How about the SDK logic of storing and retrieving of of the IDs ?
5> What is the maximum of providing  product IDs and what is the minimum of  providing product IDs ?
6> search() / categoryMerchandising() => SDK provides localStorage automatic storing and retrieving of the IDs on client-side requests. Both are same logic ? Have any different?

Hi @jerrypena1
Thanks.
We're testing this way: store the IDs on the server-side and tie it to the user's session,  retrieve this information and send it when making the server-side requests.

hi @canyan1989 I'm curious is that worked for you?


Unit tests with chroot?

I would like to run bats in a chroot environment to get a fs-side-effect-free unit test.  Is this possible/recommended with bats?

I'm not sure, but you should try it out and report back with how it went! Keep in mind that bats requires a few system utilities in PATH to function, e.g. readline/greadline.


Update the https in the json this time.

Replacement for #880, this time editing the json.

Thank you! Should be merged soon !


manual and changelog updates

Alright, edited a buncha lines, bumped the importance of a cooouple items in the changelog. I'm happy to merge this in and release the RC, thanks for the amazing work!


REPL is missing

I’m really feeling the lack of a REPL.  Every time I want to execute a small bit of code, I find myself typing it out, highlighting it, running it, and then deleting it.  Not a great workflow.

I've opened a ticket in web-client-ui to possibly expose console features that the extension could use. https://github.com/deephaven/web-client-ui/issues/2111

Looks like there is an api that allows interacting via vscode terminal. Here's an example: https://github.com/microsoft/vscode-extension-samples/blob/main/extension-terminal-sample/src/extension.ts

Looking at the terminal API, it doesn't have the feature we would need to implement a repl.
Other than a terminal, vs code doesn't have a paradigm of a rich interactive repl. You can display a python repl in terminal but there's no equivalent rich experience in vs code. There are no APIs or building blocks to create similar experience, so any implementation would be sub-optimal and a lot of work.
We can provide a link to open a repl in a browser from your current connected worker. And if the deephaven server command implemented a -i / --interactive or -repl mode we could display that in the terminal.
I don't think we should be trying to build our exact ide experience shoe-horned into vs code, we should build what the equivalent vs code experiences is in vs code, using the APIs they provide.
My interpretation of the underlying user need is a way to have quick iterative development, and the closest vs code equivalent experience would be vs code python notebooks. VS Code does have a python notebook api that we can explorer, and if possible I think that would be a better native VS code feeling experience. I know they aren't quite equivalent, but do fulfill a similar user need.


[Bug]: File Ascending Sort Not Working Properly

Contact Details
<EMAIL_ADDRESS>What happened?
Good Evening @RafaelGB
I hope you are well
When I select the option to sort the results by the filename in ascending order, the results do not appear in the correct order, as can be seen in the video present in the link below:
BUG - VIDEO
If you need anything else, just let me know.
I am waiting to hear from you.
What platform were you using?
Desktop
Version of the plugin
2.9.2
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

the problem is that an alphabetical order is used.
"file9">"file109"
"file1"<"file109"
You can use a padding of Zeros to fix it
"file009"<"file109"
Internally the plugin can not know how to order correctly with a mix of strings and numbers


Add cluster compatibility note for ACPT images

Add cluster compatibility note for ACPT images with NC series of clusters

Learn Build status updates of commit af028c5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/machine-learning/resource-curated-environments.md
:warning:Warning

Details

articles/machine-learning/resource-curated-environments.md

Line 54, Column 74: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/virtual-machines/nc-series' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 54, Column 74: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/virtual-machines/nc-series' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@ssalgadodev

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Okay how

Learn Build status updates of commit 6c0d2b5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/machine-learning/resource-curated-environments.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off


Updated README with more detailed instructions on how to succesfully …

…import the project in Eclipse and then build it with maven. This is needed if you want to develop in Eclipse and then build with mvn command. Fixes issue #2028.

Right, I see that you mentioned somewhere else that in this issue the exclude of 'src/com/google/debugging/sourcemap/super' is discussed (I didn't have this issue with Eclipse though).

Can you try to build the project in Eclipse and run the CommandLineRunner class? With build i mean right click on the parent project and press ´Build Project´
From slack @lbercken

And how did you perform your maven build?

There is no ´Build Project´ option, but I can Maven Build to project. How did you manage to build the project?

Were you ever able to run the CommandLineRunner.java file? @lbercken

@sveningsonrobin No, because I got out of memory errors during building the project.

I have Build Project available... But it might be after the maven build has successfully been ran

I think the "Build Project" comes up after you have ran:

mvn eclipse:eclipse -DdownloadSources=true

and

mvn -DskipTests -pl externs/pom.xml,pom-main.xml,pom-main-shaded.xml

As specified in the manual. And after that you can run the CommandLineRunner.java file

@sveningsonrobin Thanks, I see.

Ok, now I did exactly what the original readme told me to do, and I get the error as described in https://github.com/google/closure-compiler/issues/2028. Then I followed your changes and it works (i.e. I am able to run the project as an Java Application). Therefore I am (still) approving this PR.

We can discuss it further once we have submitted the real pull request @xmwen, with the creators of Closure Compiler 👍


fix: negative stx available balance

Try out this version of the Hiro Wallet - download extension builds.

Closes #3761 and #3716
Fixes the issue of extracting fees of inbound txs from available balance

@kyranjamie you mean Math.max? to remove possibility of showing negative value?

@kyranjamie I changed according to your suggestion but then revert. I think we shouldn't manually set negative value to zero, as this indicates about problems in code. if we did this before - this bug would probably be always there

Yep, makes sense


TransformSetterIntercept Not Found

My unity version is 2018.2.17f1.

Hi, apologies for late reply I've not been monitoring this one.
From the error it looks like the contents of manifest.json could be wrong. Potentially a typo or something similar.
If you want to post it here I'll have a look.
Thanks,
Chris


Wrong version of Xcode Command Line tools is installed on High Sierra.

Cookbook version
8.0.4
Chef-client version
13.6.4
Platform Details
macOS 10.13
Scenario:
When including the build-essential cookbook in a node runlist, on a machine running 10.3.0 or higher, Command Line Tools (macOS El Capitan version 10.11) for Xcode-8.2 is installed instead of the correct version Command Line Tools (macOS High Sierra version 10.13) for Xcode-9.2
Steps to Reproduce:
Include build-essential in a 10.13 node's runlist. Or on a 10.13 machine without the xcode-command line tools installed on, run the following commands:

touch /tmp/.com.apple.dt.CommandLineTools.installondemand.in-progress
softwareupdate -l | grep "\*.*Command Line" | head -n 1 | awk -F"*" '{print $2}' | sed -e 's/^ *//'

You will receive:
Command Line Tools (macOS El Capitan version 10.11) for Xcode-8.2
Expected Result:
The expectation is that Command Line Tools (macOS High Sierra version 10.13) for Xcode-9.2 would be installed.
Actual Result:
Command Line Tools (macOS El Capitan version 10.11) for Xcode-8.2 is installed instead.
Potential fix
Change the PROD softwareupdate command to:
softwareupdate -l | grep "\*.*Command Line" | grep "$(sw_vers -productVersion | awk -F "." '{print $2}')" | awk -F"*" '{print $2}' | sed -e 's/^ *//' | tr -d '\n' or something much more clever.

This should be fixed by just tailing the results so we pick the last not the first. I released it in 8.1.1. If this still doesn't work there's a gem for installing xcode that's probably a better idea.


(apis) research into making endpoints limited/invite only (API keys) (ben and arnav)

We would like to make certain endpoints limited (i.e. requiring authentication). This is specifically for cases where a user wants to access create, update, and delete operations. For example, we don't want a user to be able to delete a game that isn't their own game (i.e. a game that they didn't create).

https://docs.gitlab.com/ee/api/invitations.html; some ideas on how to create certain attributes to the api that restrict access to actions, such as user vs. admin


feat(avm): add ECC ops to avm_proving_test

Please read contributing guidelines and remove this line.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#7058  👈
#7056
#7048
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

proof_construction_time_sha256_30_ms (16): 1,858 (+27%)
avm_simulation_time_ms (Token:mint_public): 593 (+786%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 62.4 (-73%)
avm_simulation_time_ms (Token:transfer_public): 36.0 (-49%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-init): 464 (-16%)
l2_block_public_tx_process_time_in_ms (4): 25,265 (+17%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_30_ms
11,525 (-2%)
3,108 (-2%)
:warning: 1,858 (+27%)
1,602 (-1%)
1,534 (+4%)

proof_construction_time_sha256_100_ms
45,588 (+4%)
12,211 (+4%)
5,703 (+5%)
5,596 (+3%)
5,530 (+3%)

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0
57.0 (-3%)
87.0 (-2%)

proof_construction_time_poseidon_hash_30_ms
1,536 (+1%)
423 (-3%)
202
222 (-4%)
274 (+3%)

proof_construction_time_poseidon_hash_100_ms
5,807 (+1%)
1,595 (+1%)
726 (-1%)
787 (+2%)
802 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,452
9,460
9,464

l1_rollup_execution_gas
610,273
610,281
610,285

l2_block_processing_time_in_ms
755 (+1%)
1,388 (-2%)
2,701 (+1%)

l2_block_building_time_in_ms
28,962 (+14%)
50,792 (-1%)
108,171 (+9%)

l2_block_rollup_simulation_time_in_ms
28,866 (+14%)
50,495 (-1%)
107,819 (+9%)

l2_block_public_tx_process_time_in_ms
:warning: 25,265 (+17%)
46,772 (-1%)
102,563 (+7%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
6,895 (-1%)
9,584 (-2%)

node_database_size_in_bytes
12,157,008
16,126,032

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
66.9
13,873

GasToken:set_portal
16.8 (+1%)
3,495

Token:constructor
92.5 (-5%)
24,207

FPC:constructor
61.7
13,893

GasToken:mint_public
51.4 (-3%)
10,241

Token:mint_public
:warning: 593 (+786%)
19,216

Token:assert_minter_and_mint
:warning: 62.4 (-73%)
13,034

AuthRegistry:set_authorized
32.7 (-5%)
7,869

FPC:prepare_fee
84.0 (-2%)
15,187

Token:transfer_public
:warning: 36.0 (-49%)
31,425

FPC:pay_refund
64.3 (+7%)
20,080

Benchmarking:increment_balance
2,720 (+1%)
15,465

Token:_increase_public_balance
58.7 (-16%)
15,089

FPC:pay_refund_with_shielded_rebate
52.1 (+2%)
21,167

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.181

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.5 (+2%)
16.9 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.608 (+2%)
0.520 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.1 (-3%)
79.4 (+5%)
132 (+2%)
240 (-2%)
472 (+1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.492 (-3%)
0.488 (+5%)
0.453 (+1%)
0.436 (-2%)
0.441 (+1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.2 (-4%)
114 (+3%)
182 (+1%)
346 (-2%)
693 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.503 (-3%)
0.513 (+3%)
0.480
0.470 (-1%)
0.476 (+1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
72.2 (-2%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.516 (-2%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
85,672
670,983

Transaction size based on fee payment method
| Metric |  |
| - |  |


Support URL / Git Repo Build Context Declaration

Description
Currently you can only specify a context directory using the <dockerDirectory> parameter. As of docker 1.12 build contexts can be url's or git repositories... can we extend this parameter to allow url build contexts or maybe create another parameter called <buildContext>?
https://docs.docker.com/engine/reference/commandline/build/
Software:

docker version: 1.12
docker-maven-plugin version: 0.4.13
maven version: 3.3.9

We recommend users switch to https://github.com/spotify/dockerfile-maven. This project is now bug fix only mode.


bitcoind: unload any leftover watchonly wallet at startup

We used to have this check and i removed it since it does not seem right
for us to unload wallets on the host's bitcoind. But it's actually fine
if it's the very same one we create (by name) and we'll now also refuse
to start with an inconsistent number of loaded watchonly wallets.


Using Polybar with Ionicons?

Is it possible to use Polybar with Ionicons? I can't find a guide for this anywhere. Here's what I got so far:
[bar/bot]
# ...
font-0 = SourceCodePro:size=10;0
font-1 = FontAwesome:size=10;0
font-2 = Ionicons:size=10;0

It looks like
[bar/bot]
# ...
font-2 = ionicons:size=10;0

Works, but some icons I'm pasting from the [cheatsheet](file:///home/dave/Downloads/ionicons-2.0.1/cheatsheet.html) do not reflect what they are supposed to be. For example, The ion-battery-charging actually pastes a bullet:  in gedit. This bullet is also what appears in Polybar.

Try specifying the font t9 use for the icon directly: https://github.com/jaagr/polybar/wiki/Fonts

Yeah, you can use the font as long as it is available to fontconfig.

Yeah, the unicode character is most likely caught by a previous font in the fontlist. As @skystrife said, you would have to explicitly specify what font to use.
label-font = <font-index>
# or
label = %{T<font-index>}...%{T-}

Perfect! Thank you!


[Bug] instance.PhotometricInterpretation : MONOCHROME2

Describe the Bug
if "instance. PhotometricInterpretation : MONOCHROME2" , the image is invisible.
{
_vrMap: {
PixelData: "UN",
},
PresentationLUTShape: "IDENTITY",
SpecificCharacterSet: "ISO_IR 192",
ImageType: [
"ORIGINAL",
"PRIMARY",
],
SOPClassUID: "1.2.840.10<IP_ADDRESS>.<IP_ADDRESS>",
SOPInstanceUID: "1.2.840.1142<IP_ADDRESS>.1629699669.11.20210823150429",
StudyDate: "20210823",
SeriesDate: "20210823",
AcquisitionDate: "20210823",
StudyTime: "150252.000000",
SeriesTime: "150429.000000",
AcquisitionTime: "150429.000000",
AccessionNumber: "20210823150252",
Modality: "DX",
PresentationIntentType: "FOR PRESENTATION",
Manufacturer: "PedraView",
InstitutionName: null,
ReferringPhysicianName: null,
StudyDescription: "",
SeriesDescription: "UPPER EXTREMITY",
PerformingPhysicianName: null,
NameOfPhysiciansReadingStudy: null,
OperatorsName: [
{
Alphabetic: "admin",
},
],
ManufacturerModelName: "DXD",
AnatomicRegionSequence: [
{
_vrMap: {
},
CodeMeaning: null,
},
],
"00090002": {
InlineBinary: "W3siYzAueCI6MTM5Ni4yMDIyOTg4NTA1NzQ2LCJjMC55IjoxMDU5LjQyOTg4NTA1NzQ3MTIsInRleHQiOiJMIiwidHlwZSI6Im1hcmtlciJ9XQ==",
},
"00090010": "M",
"00090020": "{\n    ".Version": "<IP_ADDRESS>",\n    "Background": false,\n    "BackgroundCollimator": 0,\n    "BackgroundWeight": 100,\n    "Clip": true,\n    "ClipPixels": 10,\n    "FixWindow": false,\n    "FixWindowCenter": 33104,\n    "FixWindowWidth": 24335,\n    "Gradation": false,\n    "GradationContrast": 0,\n    "GradationWeight": 100,\n    "GradationWhite": 100,\n    "Grid": true,\n    "GridWeight": 1,\n    "Noise": true,\n    "NoiseWeight": 74,\n    "Sharpening": true,\n    "SharpeningWeight": 1,\n    "Smoothing": true,\n    "SmoothingWeight": 0,\n    "Tissue": true,\n    "TissueDetail": 40,\n    "TissueFine": 38,\n    "TissueStructure": 33,\n    "TissueUltra": 0,\n    "TissueVolume": 21\n}",
PatientName: [
{
Alphabetic: "",
},
],
PatientID: "3733-1",
IssuerOfPatientID: "DCM4CHEE.031986EB.07076CCB",
PatientBirthDate: "19590120",
PatientSex: "Male",
PatientAge: "000Y",
PatientSize: "0",
PatientWeight: "0",
AdditionalPatientHistory: null,
PatientComments: null,
BodyPartExamined: "WRIST",
KVP: "52",
SoftwareVersions: "DDDDDD",
ExposureTime: "40",
XRayTubeCurrent: "125",
ImagerPixelSpacing: [
"0.14",
"0.14",
],
ExposureIndex: "0",
TargetExposureIndex: "5000",
DeviationIndex: "0",
ShutterShape: "RECTANGULAR",
ShutterLeftVerticalEdge: "209",
ShutterRightVerticalEdge: "2386",
ShutterUpperHorizontalEdge: "686",
ShutterLowerHorizontalEdge: "2500",
ShutterPresentationValue: 0,
PatientPosition: "AP",
DetectorType: "SCINTILLATOR",
ExposureInmAs: 5,
StudyInstanceUID: "1.2.840.1142<IP_ADDRESS>.20210823150342",
SeriesInstanceUID: "1.2.840.1142<IP_ADDRESS>.1629699669.20210823150429",
StudyID: null,
SeriesNumber: "1629699669",
InstanceNumber: "1629698670",
ImageLaterality: null,
SamplesPerPixel: 1,
PhotometricInterpretation: "MONOCHROME2",
NumberOfFrames: "1",
Rows: 3052,
Columns: 3052,
PixelSpacing: [
"0.14",
"0.14",
],
PixelAspectRatio: null,
BitsAllocated: 16,
BitsStored: 16,
HighBit: 15,
PixelRepresentation: 0,
PixelPaddingRangeLimit: null,
BurnedInAnnotation: "NO",
PixelIntensityRelationship: null,
PixelIntensityRelationshipSign: null,
WindowCenter: "20400",
WindowWidth: "38127",
RescaleIntercept: null,
RescaleSlope: null,
RescaleType: null,
WindowCenterWidthExplanation: null,
VOILUTFunction: null,
RedPaletteColorLookupTableDescriptor: null,
GreenPaletteColorLookupTableDescriptor: null,
BluePaletteColorLookupTableDescriptor: null,
RedPaletteColorLookupTableData: null,
GreenPaletteColorLookupTableData: null,
BluePaletteColorLookupTableData: null,
ICCProfile: null,
LossyImageCompression: "00",
VOILUTSequence: [
{
_vrMap: {
},
LUTDescriptor: null,
LUTExplanation: null,
LUTData: null,
},
],
PixelDataProviderURL: null,
PatientInstitutionResidence: null,
ScheduledProcedureStepStartDate: "20210823",
ScheduledProcedureStepStartTime: "150252.000000",
AcquisitionContextSequence: [
{
_vrMap: {
},
ConceptNameCodeSequence: [
{
vrMap: {
},
CodeMeaning: null,
},
],
},
],
RequestedProcedureID: "-",
RequestedProcedurePriority: null,
ImageHorizontalFlip: "N",
ImageRotation: 90,
PixelData: {
BulkDataURI: "http://****",
retrieveBulkData: () => {
// handle the scenarios where bulkDataURI is relative path
(0,utils_fixBulkDataURI__WEBPACK_IMPORTED_MODULE_9.fixBulkDataURI)(value, naturalized, dicomWebConfig);
const options = {
// The bulkdata fetches work with either multipart or
// singlepart, so set multipart to false to let the server
// decide which type to respond with.
multipart: false,
BulkDataURI: value.BulkDataURI,
// The study instance UID is required if the bulkdata uri
// is relative - that isn't disallowed by DICOMweb, but
// isn't well specified in the standard, but is needed in
// any implementation that stores static copies of the metadata
StudyInstanceUID: naturalized.StudyInstanceUID
};
// Todo: this needs to be from wado dicom web client
return qidoDicomWebClient.retrieveBulkData(options).then(val => {
// There are DICOM PDF cases where the first ArrayBuffer in the array is
// the bulk data and DICOM video cases where the second ArrayBuffer is
// the bulk data. Here we play it safe and do a find.
const ret = val instanceof Array && val.find(arrayBuffer => arrayBuffer?.byteLength) || undefined;
value.Value = ret;
return ret;
});
},
},
wadoRoot: "http://",
wadoUri: undefined,
imageId: "wadors:http://",
}
Steps to Reproduce
.
The current behavior
.
The expected behavior
.
OS
Windows 11
Node version
.
Browser
.

It's not a MONOCHROME2 problem.
Other MONOCHROME2 images look fine.

The image has been modified to display.
I hope someone will merge this into git.
MetadataProvider.js _getCornerstoneDICOMImageLoaderTag()
case WADO_IMAGE_LOADER_TAGS.MODALITY_LUT_MODULE:
const { RescaleIntercept, RescaleSlope } = instance;
if (
RescaleIntercept === undefined ||
RescaleSlope === undefined ||
RescaleIntercept === null ||
RescaleSlope === null
) {
return;
}

Could you kindly provide the data if it has been anonymized and you can confirm that there is no patient health information present in any of the headers or embedded within the pixel data?


Prometheus adapter - not able to get data from external metrics

I am not able to fetch items by running this command: kubectl get --raw "/apis/external.metrics.k8s.io/v1beta1/namespaces/default/rabbitmq_queue_messages_ready" | jq
As you can see in below output items is an empty array:
{
  "kind": "ExternalMetricValueList",
  "apiVersion": "external.metrics.k8s.io/v1beta1",
  "metadata": {
    "selfLink": "/apis/external.metrics.k8s.io/v1beta1/namespaces/default/rabbitmq_queue_messages_ready"
  },
  "items": []
}

Even APIResourceList is also empty:
kubectl get --raw /apis/external.metrics.k8s.io/v1beta1 | jq .
{
  "kind": "APIResourceList",
  "apiVersion": "v1",
  "groupVersion": "external.metrics.k8s.io/v1beta1",
  "resources": []
}

However, I am getting proper data in prometheus endpoint:
Prometheus URL: http://<prometheus_url>:9090/api/v1/series?match%5B%5D=%7B__name__%3D~%22%5Erabbitmq_queue_.%2A%22%7D&start=1597255421.51
Response:
{
"status":"success",
"data":[
    {
        "__name__":"rabbitmq_queue_messages_ready",
        "app":"prometheus-rabbitmq-exporter",
        "durable":"true",
        "instance":"<IP_ADDRESS>:9419",
        "job":"kubernetes-pods",
        "namespace":"default",
        "pod_name":"rabbitmq-exporter-prometheus-rabbitmq-exporter-754c845847-gzlrq",
        "pod_template_hash":"754c845847",
        "queue":"test",
        "release":"rabbitmq-exporter",
        "vhost":"/"
    },
    {
        "__name__":"rabbitmq_queue_messages_ready",
        "app":"prometheus-rabbitmq-exporter",
        "durable":"true",
        "instance":"<IP_ADDRESS>:9419",
        "job":"kubernetes-pods",
        "namespace":"default",
        "pod_name":"rabbitmq-exporter-prometheus-rabbitmq-exporter-754c845847-gzlrq",
        "pod_template_hash":"754c845847",
        "queue":"test1",
        "release":"rabbitmq-exporter",
        "vhost":"/"
    }
]
}

I installed stable/prometheus-adapter using below helm values:
rules:
  default: false
  external:
    - seriesQuery: '{__name__=~"^rabbitmq_queue_.*"}'
      resources:
        #template: <<.Resource>>
        overrides:
          namespace:
            resource: namespace
          service:
            resource: service
          pod:
            resource: pod
      name:
        matches: ""
        as: "rabbitmq_queue_messages_ready"
      metricsQuery: 'rate(<<.Series>>{<<.LabelMatchers>>}[1m])'

Version of Helm and Kubernetes:
Client: &version.Version{SemVer:"v2.16.9", GitCommit:"8ad7037828e5a0fca1009dabe290130da6368e39", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.16.7", GitCommit:"5f2584fd3d35552c4af26036f0c464191287986b", GitTreeState:"clean"}
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.11", GitCommit:"ec831747a3a5896dbdf53f259eafea2a2595217c", GitTreeState:"clean", BuildDate:"2020-05-29T19:56:10Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"linux/amd64"}
Which chart:
stable/prometheus-adapter
What you expected to happen:
It should fetch metrics from Prometheus
How to reproduce it (as minimally and precisely as possible):
Install stable/prometheus-rabbitmq-exporter and stable/prometheus-adapter charts using above configs.
Anything else we need to know:
I am following this guide: https://nuvalence.io/building-a-k8s-autoscaler-with-custom-metrics/

https://nuvalence.io/building-a-k8s-autoscaler-with-custom-metrics/ from the article, the author didn't override the resource, so what do you see when you do
resources:         template: <<.Resource>> and remove the rest of override part?
by the way, I also encounter the same issue, but I resolved by removing <<.LabelMatchers>> in the metricsQuery. you could take a shot at it.

Also, how did you install prometheus-adapter and which version? I installed it through the helm chart, its latest version, and external metrics return a not found error (Error from server (NotFound): the server could not find the requested resource).

So, in my case, I found out that I was using prometheus-adapter with kube-metrics-adapter. I removed kube-metrics-adapter and it worked.


Get rid of MapView scale by using the floating point zoom

Issue Type
[v] Improvement
Description and/or steps/code to reproduce the problem
Now that we have floating point zooms (instead of integer zooms), we could get rid of the notion of MapView scale.
For the moment, the scale always equals 1.0f, except during pinch gesture where it reflects the delta zoom in/out. The idea would be to compute directly the next zoom and forget the notion of scale:

The code would be simpler and easier to maintain.
The behavior (especially the tiles display) would be the same during pinch gesture and when the gesture stops
The best possible tiles would always be displayed, instead of a scaled version of the tiles that where on screen at pinch gesture start.

Please feel free to comment!
Version of osmdroid the issue relates to:
6.0.0

Additional thoughts if we get rid of the notion of scale:

we won't use it on Canvas and as a result we may avoid related problems about hardware acceleration
I think there's a pending issue about "some layers being scaled when some others are not", which displays smaller/bigger marker pop-ups. We would solve that too

Could solve #595 too.

Sounds great! Would probably reduce some CPU overhead too, right?

I guess so. And in the supposedly common case of a 0 degree map orientation, we could get rid of the whole canvas manipulation (save / rotate / scale / restore).

I can tell you, so far it looks great! Still working on it.

Sounds promising - really looking forward to this!

merged

After all these changes related to "floating point map scale", the overall result is wonderful.
Seeing for instance the marker clustering operating during the pinch zoom gesture (without any code change needed on my side), that's really great.
@spyhunter99 & @monsieurtanuki Do you see something else absolutely required before releasing a new version? (could V6.0 land under the christmas tree?)

@MKergall that can be arranged! depends on what you want to do for the zoon button overlay

@MKergall I'm glad you enjoyed the new pinch gesture!
Regarding pending issues I have an interest in:

#817 is minor but could be quickly fixed.
I'm currently working on #809, which is very interesting but not altogether a core feature, and which is already working - I'm just expanding the feature
I don't see anything absolutely required before the new release.


Inconsistent quoting for unknown flag error

https://github.com/jessevdk/go-flags/blob/master/parser.go#L604
On that line, the opening quote is a backtick and the closing quote is a single quote. My expectation was that the opening/closing quote would be the same.

Duplicate of https://github.com/jessevdk/go-flags/issues/167.


RFC: reviewer management, e.g. lab reviewer --add --remove --require

The request is to add the ability to add and remove reviewers in an MR.
For example:
lab mr reviewer --add mumble,sprotz,hust
... adds reviewers mumble, sprotz, and hust to the mr.
lab mr approver --add aus
... adds aus as an approver to the mr

OK, this is already there, mostly.


proxy_set_header does not support X-Forwarded-Proto and X-Forwarded-Port

location_custom_cfg => {
    'proxy_set_header' => {
      'X-Real-IP'         => '$remote_addr',
      'X-Forwarded-For'   => '$proxy_add_x_forwarded_for',
      'X-Forwarded-Proto' => 'https',
      'X-Forwarded-Port'  => '443',
      'Host'              => '$host'
    },
  }

Doing the above, removes the X-Forwarded-Proto and X-Forwarded-Port headers.
Is it because its missing here?
https://github.com/jfryman/puppet-nginx/blob/master/data/common.yaml#L26

I have same problem, the above config pattern worked for me though..

It's worth noting the above configuration pattern won't help you if you need to differentiate any two vhosts and have some proxies have certain headers and not others…

For me it works like this perfectly fine:
  include nginx

  nginx::resource::vhost { "${domain}-ssl":
    server_name           => [ "${domain}" ],
    listen_port           => 443,
    proxy                 => $proxy_host,
    proxy_set_header      => [
      'X-Real-IP         $remote_addr',
      'X-Forwarded-For   $proxy_add_x_forwarded_for',
      'X-Forwarded-Proto https',
      'X-Forwarded-Port  443',
      'Host              $host'
    ],
    ssl                   => true,
    ssl_cert              => "${cert_path}",
    ssl_key               => "${key_path}",
  }

And I could define my module as many times as needed

Is anyone still seeing this problem as of now (with a recent version of the module? I have tested this recently and worked for me as expected, so I'm going to close this for now.


alphafold2 doesn't work on RTX4090?

I followed everything every step of the instruction
I0605 11:20:06.397100<PHONE_NUMBER>02496 run_docker.py:235] Traceback (most recent call last):
I0605 11:20:06.397124<PHONE_NUMBER>02496 run_docker.py:235] File "/app/alphafold/run_alphafold.py", line 459, in
I0605 11:20:06.397146<PHONE_NUMBER>02496 run_docker.py:235] app.run(main)
I0605 11:20:06.397182<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/absl/app.py", line 312, in run
I0605 11:20:06.397204<PHONE_NUMBER>02496 run_docker.py:235] _run_main(main, args)
I0605 11:20:06.397226<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/absl/app.py", line 258, in _run_main
I0605 11:20:06.397248<PHONE_NUMBER>02496 run_docker.py:235] sys.exit(main(argv))
I0605 11:20:06.397271<PHONE_NUMBER>02496 run_docker.py:235] File "/app/alphafold/run_alphafold.py", line 444, in main
I0605 11:20:06.397292<PHONE_NUMBER>02496 run_docker.py:235] models_to_relax=FLAGS.models_to_relax)
I0605 11:20:06.397313<PHONE_NUMBER>02496 run_docker.py:235] File "/app/alphafold/run_alphafold.py", line 222, in predict_structure
I0605 11:20:06.397335<PHONE_NUMBER>02496 run_docker.py:235] random_seed=model_random_seed)
I0605 11:20:06.397356<PHONE_NUMBER>02496 run_docker.py:235] File "/app/alphafold/alphafold/model/model.py", line 167, in predict
I0605 11:20:06.397378<PHONE_NUMBER>02496 run_docker.py:235] result = self.apply(self.params, jax.random.PRNGKey(random_seed), feat)
I0605 11:20:06.397400<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/random.py", line 132, in PRNGKey
I0605 11:20:06.397438<PHONE_NUMBER>02496 run_docker.py:235] key = prng.seed_with_impl(impl, seed)
I0605 11:20:06.397461<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/prng.py", line 267, in seed_with_impl
I0605 11:20:06.397483<PHONE_NUMBER>02496 run_docker.py:235] return random_seed(seed, impl=impl)
I0605 11:20:06.397505<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/prng.py", line 580, in random_seed
I0605 11:20:06.397528<PHONE_NUMBER>02496 run_docker.py:235] return random_seed_p.bind(seeds_arr, impl=impl)
I0605 11:20:06.397550<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/core.py", line 329, in bind
I0605 11:20:06.397573<PHONE_NUMBER>02496 run_docker.py:235] return self.bind_with_trace(find_top_trace(args), args, params)
I0605 11:20:06.397596<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/core.py", line 332, in bind_with_trace
I0605 11:20:06.397617<PHONE_NUMBER>02496 run_docker.py:235] out = trace.process_primitive(self, map(trace.full_raise, args), params)
I0605 11:20:06.397639<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/core.py", line 712, in process_primitive
I0605 11:20:06.397660<PHONE_NUMBER>02496 run_docker.py:235] return primitive.impl(*tracers, **params)
I0605 11:20:06.397680<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/prng.py", line 592, in random_seed_impl
I0605 11:20:06.397703<PHONE_NUMBER>02496 run_docker.py:235] base_arr = random_seed_impl_base(seeds, impl=impl)
I0605 11:20:06.397723<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/prng.py", line 597, in random_seed_impl_base
I0605 11:20:06.397745<PHONE_NUMBER>02496 run_docker.py:235] return seed(seeds)
I0605 11:20:06.397766<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/prng.py", line 832, in threefry_seed
I0605 11:20:06.397787<PHONE_NUMBER>02496 run_docker.py:235] lax.shift_right_logical(seed, lax_internal._const(seed, 32)))
I0605 11:20:06.397808<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/lax/lax.py", line 515, in shift_right_logical
I0605 11:20:06.397829<PHONE_NUMBER>02496 run_docker.py:235] return shift_right_logical_p.bind(x, y)
I0605 11:20:06.397851<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/core.py", line 329, in bind
I0605 11:20:06.397871<PHONE_NUMBER>02496 run_docker.py:235] return self.bind_with_trace(find_top_trace(args), args, params)
I0605 11:20:06.397893<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/core.py", line 332, in bind_with_trace
I0605 11:20:06.397914<PHONE_NUMBER>02496 run_docker.py:235] out = trace.process_primitive(self, map(trace.full_raise, args), params)
I0605 11:20:06.397935<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/core.py", line 712, in process_primitive
I0605 11:20:06.397955<PHONE_NUMBER>02496 run_docker.py:235] return primitive.impl(*tracers, **params)
I0605 11:20:06.397976<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/dispatch.py", line 115, in apply_primitive
I0605 11:20:06.397998<PHONE_NUMBER>02496 run_docker.py:235] return compiled_fun(*args)
I0605 11:20:06.398021<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/dispatch.py", line 200, in
I0605 11:20:06.398042<PHONE_NUMBER>02496 run_docker.py:235] return lambda *args, **kw: compiled(*args, **kw)[0]
I0605 11:20:06.398062<PHONE_NUMBER>02496 run_docker.py:235] File "/opt/conda/lib/python3.7/site-packages/jax/_src/dispatch.py", line 895, in _execute_compiled
I0605 11:20:06.398084<PHONE_NUMBER>02496 run_docker.py:235] out_flat = compiled.execute(in_flat)
I0605 11:20:06.398105<PHONE_NUMBER>02496 run_docker.py:235] jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Could not find the corresponding function
and this is my docker image:
(af2) bulat@AuroraR15:~/apps/AF230multimer/alphafold$ docker image inspect alphafold
[
{
"Id": "sha256:fcb14e253899d17d14b0b094c03db3262352ac946df6e6ccd75d8feed624fecf",
"RepoTags": [
"alphafold:latest"
],
"RepoDigests": [],
"Parent": "",
"Comment": "buildkit.dockerfile.v0",
"Created": "2023-06-05T11:11:19.751298916-04:00",
"Container": "",
"ContainerConfig": {
"Hostname": "",
"Domainname": "",
"User": "",
"AttachStdin": false,
"AttachStdout": false,
"AttachStderr": false,
"Tty": false,
"OpenStdin": false,
"StdinOnce": false,
"Env": null,
"Cmd": null,
"Image": "",
"Volumes": null,
"WorkingDir": "",
"Entrypoint": null,
"OnBuild": null,
"Labels": null
},
"DockerVersion": "",
"Author": "",
"Config": {
"Hostname": "",
"Domainname": "",
"User": "",
"AttachStdin": false,
"AttachStdout": false,
"AttachStderr": false,
"Tty": false,
"OpenStdin": false,
"StdinOnce": false,
"Env": [
"PATH=/opt/conda/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"NVARCH=x86_64",
"NVIDIA_REQUIRE_CUDA=cuda>=11.1 brand=tesla,driver>=418,driver<419 brand=tesla,driver>=450,driver<451",
"NV_CUDA_CUDART_VERSION=11.1.74-1",
"NV_CUDA_COMPAT_PACKAGE=cuda-compat-11-1",
"CUDA_VERSION=11.1.1",
"LD_LIBRARY_PATH=/usr/local/nvidia/lib:/usr/local/nvidia/lib64",
"NVIDIA_VISIBLE_DEVICES=all",
"NVIDIA_DRIVER_CAPABILITIES=compute,utility",
"NV_CUDA_LIB_VERSION=11.1.1-1",
"NV_NVTX_VERSION=11.1.74-1",
"NV_LIBNPP_VERSION=<IP_ADDRESS>1-1",
"NV_LIBNPP_PACKAGE=libnpp-11-1=<IP_ADDRESS>1-1",
"NV_LIBCUSPARSE_VERSION=<IP_ADDRESS>-1",
"NV_LIBCUBLAS_PACKAGE_NAME=libcublas-11-1",
"NV_LIBCUBLAS_VERSION=<IP_ADDRESS>-1",
"NV_LIBCUBLAS_PACKAGE=libcublas-11-1=<IP_ADDRESS>-1",
"NV_LIBNCCL_PACKAGE_NAME=libnccl2",
"NV_LIBNCCL_PACKAGE_VERSION=2.8.4-1",
"NCCL_VERSION=2.8.4-1",
"NV_LIBNCCL_PACKAGE=libnccl2=2.8.4-1+cuda11.1",
"NV_CUDNN_VERSION=<IP_ADDRESS>",
"NV_CUDNN_PACKAGE_NAME=libcudnn8",
"NV_CUDNN_PACKAGE=libcudnn8=<IP_ADDRESS>-1+cuda11.1"
],
"Cmd": null,
"Image": "",
"Volumes": null,
"WorkingDir": "/app/alphafold",
"Entrypoint": [
"/app/run_alphafold.sh"
],
"OnBuild": null,
"Labels": {
"com.nvidia.cudnn.version": "<IP_ADDRESS>",
"maintainer": "NVIDIA CORPORATION<EMAIL_ADDRESS>},
"Shell": [
"/bin/bash",
"-o",
"pipefail",
"-c"
]
},
"Architecture": "amd64",
"Os": "linux",
"Size":<PHONE_NUMBER>,
"VirtualSize":<PHONE_NUMBER>,
"GraphDriver": {
"Data": {
"LowerDir": "/var/lib/docker/overlay2/sbxmecbsjt11l3qyccji7l5kf/diff:/var/lib/docker/overlay2/u5kuh6plaibllh9jpuomdyjhn/diff:/var/lib/docker/overlay2/t49o4ey3s5b7ekg1zxidppxbb/diff:/var/lib/docker/overlay2/xmtjesixrlc1mg14cowazbk0m/diff:/var/lib/docker/overlay2/irr673954hnwg04pfp20vq8lz/diff:/var/lib/docker/overlay2/l0vuaq33gpdbn7fzulqngf2kx/diff:/var/lib/docker/overlay2/suhsvcnbzjxh1peozvhn58noz/diff:/var/lib/docker/overlay2/50elvoyrfa07nd835wravqkbl/diff:/var/lib/docker/overlay2/kbmsqxhwpwyqmsj27pvb3ak43/diff:/var/lib/docker/overlay2/y266fduk6jzb7dd3sf1v7dbf9/diff:/var/lib/docker/overlay2/u15ulcsr1gdp7ok28cek67cg0/diff:/var/lib/docker/overlay2/16801172f93f69d9e0d740f62371ca7ba0bee729769a731b7d33c914651ae460/diff:/var/lib/docker/overlay2/f02078794c77293e590608047d0febff6f7dcf4d51e2404ea61e44c46b614017/diff:/var/lib/docker/overlay2/e8d3910161e3e31d142e6f458ea98a78e95fd34053da8a611aaf3c93e54e3289/diff:/var/lib/docker/overlay2/e1c4a091c1795ba8d134f7eaa59e83aff45105578a8b71f04d128753d1b57211/diff:/var/lib/docker/overlay2/691a7bdc38fb271d19270bfc90e903dcf73e8793819ece86b2aeba8d02df91a7/diff:/var/lib/docker/overlay2/0f852a4c5ac28097307f18e42b9c6967d35d5aa322290ab59fb34080b7b2e918/diff:/var/lib/docker/overlay2/7e7f687fede356633f48844f4f09572d730a8e21b2814b1bd00dae3974ee2821/diff:/var/lib/docker/overlay2/2a568af471f4f6a2bca78c0002c18d4baf5379e5838e8aaa8422761d5766e69e/diff",
"MergedDir": "/var/lib/docker/overlay2/whe6wf7mkchy8fvyt3m34yuc2/merged",
"UpperDir": "/var/lib/docker/overlay2/whe6wf7mkchy8fvyt3m34yuc2/diff",
"WorkDir": "/var/lib/docker/overlay2/whe6wf7mkchy8fvyt3m34yuc2/work"
},
"Name": "overlay2"
},
"RootFS": {
"Type": "layers",
"Layers": [
"sha256:69f57fbceb1b420d7e4697e0f6514887b0805ee0059bea7d51e0a832962e74bf",
"sha256:d93d28fd98962ad87ccb1d4120928fbc75b263a3a02680e467c5dcf034165f3b",
"sha256:7f8e22e7b3728674b67db632eaf322f0f5d1d6f88fd81929b274deb0035271c2",
"sha256:e3c807b397c6b872bf574144054b276295027ec33db5398de56b7549831d1704",
"sha256:809a77dc6665ed2de39af508af0d277f5ceb071163811ec602f5a1fb069da095",
"sha256:b8f2664c41aaa22295786369c92b2e984d5273317a26989c6b3d84113deed13e",
"sha256:acfe97fde47e2d82ac4b727956c6ce0a12974c444a5473df70520136735e8c70",
"sha256:4bae95ca3a263e1388cb9bcdf4f5317ea17d0d384b3ac1b5cdb7f5018eaed8b9",
"sha256:5bac3e58e979d44d37323869e39ac1bd347e944ce2903f82842f4133db0071fd",
"sha256:98189b3865160391663b7d3450e56acd391d6fe1ecfad2d79503b71a7a9b27cd",
"sha256:d0d440ba7ef2b09bfa35770d274b4564b823912273c5722dc6eae58e7bcd71d3",
"sha256:b36ed72887ac02f3c772e6ac2267e28c57bdec280674ae64fff2ff54f8cc7946",
"sha256:a7e9e4c7cd5e0e43cfeee24a85ab8194aefd7f0f8b2bf04fd6fd88b2ee89a37f",
"sha256:b8074f4e7d22b866fcd09d60c5262b6b0f7f691d592c98fadf9514d9cf8b9839",
"sha256:a827e81751a7b3c72c87fdf4a160a746085ca77ae10fc4307a0d0b5d03d0bc54",
"sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef",
"sha256:756e5317e1d484ad1e77862430ec8150875a1e49ef66bc6f3b6b9a8523e85c7a",
"sha256:213a79d7456b950ae34c364a88ceb3c6600354cb852fdc605d59528e34dc71c1",
"sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef",
"sha256:f9f35834bc449ef3071cb17822df1748888e683c98a484372859f0f4984c184a"
]
},
"Metadata": {
"LastTagTime": "0001-01-01T00:00:00Z"
}
}
]

I met same issue.  RTX4090, Ubuntu 22.04, Cuda 11.6

I'm having a similar issue. I think its something to do with the cuda version and the jax/jaxlib versions. I've been trying different combinations but i keep getting errors.

I also use RTX4090. My driver version is 520.61.05, and the CUDA version is 11.8.
In my case, I solved the problem by editing the Dockerfile in docker folder.
Here are the changes I made:
$ ARG CUDA=11.1.1
$ FROM nvidia/cuda:${CUDA}-cudnn8-runtime-ubuntu18.04
to
$ ARG CUDA=11.8.0
$ FROM nvidia/cuda:11.8.0-cudnn8-devel-ubuntu20.04
After making these changes, I rebuilt the Docker images and run alphafold.
You might find these issues helpful as well:
https://github.com/deepmind/alphafold/issues/764
https://github.com/deepmind/alphafold/issues/646
I'm a newbie on GitHub and coding so I don't know why this method lead to solve, but I solved it anyway.
I hope this helps you solve the problem too.

I also use RTX4090. My driver version is 520.61.05, and the CUDA version is 11.8. In my case, I solved the problem by editing the Dockerfile in docker folder. Here are the changes I made: $ ARG CUDA=11.1.1 $ FROM nvidia/cuda:${CUDA}-cudnn8-runtime-ubuntu18.04 to $ ARG CUDA=11.8.0 $ FROM nvidia/cuda:11.8.0-cudnn8-devel-ubuntu20.04
After making these changes, I rebuilt the Docker images and run alphafold.
You might find these issues helpful as well: #764 #646
I'm a newbie on GitHub and coding so I don't know why this method lead to solve, but I solved it anyway. I hope this helps you solve the problem too.

I am having the same problem. And trying different cuda combination. Hope this will work.

I also use RTX4090. My driver version is 520.61.05, and the CUDA version is 11.8. In my case, I solved the problem by editing the Dockerfile in docker folder. Here are the changes I made: $ ARG CUDA=11.1.1 $ FROM nvidia/cuda:${CUDA}-cudnn8-runtime-ubuntu18.04 to $ ARG CUDA=11.8.0 $ FROM nvidia/cuda:11.8.0-cudnn8-devel-ubuntu20.04
After making these changes, I rebuilt the Docker images and run alphafold.
You might find these issues helpful as well: #764 #646
I'm a newbie on GitHub and coding so I don't know why this method lead to solve, but I solved it anyway. I hope this helps you solve the problem too.

THX, BRO! I finally made it with your advice!


Feat: vela adopt support multi-cluster adoption

Description of your changes

Close #5464
I have:

[x] Read and followed KubeVela's contribution process.
[x] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer
Multi-cluster adoption needs to get resources from sub-cluster, maybe we should have a more elegant implement instead of reusing multicluster.RequestRawK8sAPIForCluster:thinking::thinking::thinking:

Reconstruct to support adopt multi-cluster resources in one adoption.
There are two cases with different policy and workflow:

adopt multi resources in the same cluster, using topology policy like:

  policies:
  - name: read-only
    properties:
      rules:
      - selector:
          componentNames:
          - nginx.Deployment.nginx-sub-cluster
          - nginx.Deployment.nginx-2-sub-cluster
    type: read-only
  - name: topology-sub-cluster
    properties:
      clusters:
      - sub-cluster
    type: topology

adopt multi resources in different cluster, using apply-component workflowstep like:

  policies:
  - name: read-only
    properties:
      rules:
      - selector:
          componentNames:
          - nginx.Deployment.nginx
          - nginx.Deployment.nginx-sub-cluster
    type: read-only
  workflow:
    steps:
    - name: apply-component-nginx.Deployment.nginx
      properties:
        cluster: local
        component: nginx.Deployment.nginx
      type: apply-component
    - name: apply-component-nginx.Deployment.nginx-sub-cluster
      properties:
        cluster: sub-cluster
        component: nginx.Deployment.nginx-sub-cluster
      type: apply-component

@basuotian Let's wait for a bit time because @FogDong is developing another vela adopt capability in parallel now. Generally LGTM, great job!

Let's hold this until 1.7.6 is released since a new command called vela adopt --all will be cherry-picked into 1.7.6.

OK, got it

Let's do some rebase. The PR of adopt --all has been merged. @basuotian

Let's do some rebase. The PR of adopt --all has been merged. @basuotian

👌

/backport release-1.8


Keep the drive status expanded

What feature or improvement do you think would benefit Files?
It's used a lot，so i wish to add the ability to keep the drive status expanded
Requirements
It's used a lot，so i wish to add the ability to keep the drive status expanded
Files Version
Version:<IP_ADDRESS>
Windows Version
Windows 10 企业版 LTSC 21H2 10.0.19044.1379
Comments
It's used a lot，so i wish to add the ability to keep the drive status expanded

What drive status? Were is it located?

I see this feature
------------------ 原始邮件 ------------------
发件人:                                                                                "files-community/Files"                                                                                @.>;
发送时间: 2023年2月23日(星期四) 晚上9:42
@.>;
<EMAIL_ADDRESS>主题: Re: [files-community/Files] Keep the drive status expanded (Issue #11431)
What drive status? Were is it located?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

That doesn't answer the questions. If you added an image you have to do it through GitHub and not an email

Are you talking about the status column in OneDrive?


Add warning against using PreSendRequestHeaders

For managed modules, adding more details w.r.t w3wp crashes
When creating a new PR, please do the following and delete this template text:

Reference the issue number if there is one:
Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.

@yaananth  Much appreciated.

and..https://github.com/dotnet/docs/pull/4002 for docs