[Snyk] Upgrade: , , express

Snyk has created this PR to upgrade multiple dependencies.
👯 The following dependencies are linked and will therefore be updated together.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

Name
Versions
Released on

@types/nodefrom 18.15.10 to 18.19.47 | 107 versions ahead of your current version | 21 days agoon 2024-08-28
@types/expressfrom 4.17.17 to 4.17.21 | 4 versions ahead of your current version | 10 months agoon 2023-11-07
expressfrom 4.18.2 to 4.19.2 | 4 versions ahead of your current version | 6 months agoon 2024-03-25
Issues fixed by the recommended upgrade:

Issue
Score
Exploit Maturity

Open RedirectSNYK-JS-EXPRESS-6474509
98
No Known Exploit

Release notes

Package name: @types/node

18.19.47 - 2024-08-28

18.19.46 - 2024-08-26

18.19.45 - 2024-08-19

18.19.44 - 2024-08-09

18.19.43 - 2024-08-02

18.19.42 - 2024-07-23

18.19.41 - 2024-07-18

18.19.40 - 2024-07-16

18.19.39 - 2024-06-22

18.19.38 - 2024-06-20

18.19.37 - 2024-06-19

18.19.36 - 2024-06-17

18.19.35 - 2024-06-17

18.19.34 - 2024-06-03

18.19.33 - 2024-05-08

18.19.32 - 2024-05-06

18.19.31 - 2024-04-09

18.19.30 - 2024-04-05

18.19.29 - 2024-04-02

18.19.28 - 2024-03-30

18.19.27 - 2024-03-30

18.19.26 - 2024-03-19

18.19.25 - 2024-03-18

18.19.24 - 2024-03-13

18.19.23 - 2024-03-11

18.19.22 - 2024-03-06

18.19.21 - 2024-02-29

18.19.20 - 2024-02-28

18.19.19 - 2024-02-27

18.19.18 - 2024-02-22

18.19.17 - 2024-02-15

18.19.16 - 2024-02-15

18.19.15 - 2024-02-08

18.19.14 - 2024-02-01

18.19.13 - 2024-02-01

18.19.12 - 2024-01-31

18.19.11 - 2024-01-30

18.19.10 - 2024-01-26

18.19.9 - 2024-01-24

18.19.8 - 2024-01-17

18.19.7 - 2024-01-15

18.19.6 - 2024-01-09

18.19.5 - 2024-01-07

18.19.4 - 2023-12-30

18.19.3 - 2023-12-07

18.19.2 - 2023-12-03

18.19.1 - 2023-12-01

18.19.0 - 2023-11-30

18.18.14 - 2023-11-29

18.18.13 - 2023-11-23

18.18.12 - 2023-11-22

18.18.11 - 2023-11-21

18.18.10 - 2023-11-18

18.18.9 - 2023-11-07

18.18.8 - 2023-10-31

18.18.7 - 2023-10-25

18.18.6 - 2023-10-18

18.18.5 - 2023-10-12

18.18.4 - 2023-10-06

18.18.3 - 2023-10-02

18.18.2 - 2023-10-02

18.18.1 - 2023-09-29

18.18.0 - 2023-09-25

18.17.19 - 2023-09-23

18.17.18 - 2023-09-20

18.17.17 - 2023-09-16

18.17.16 - 2023-09-15

18.17.15 - 2023-09-08

18.17.14 - 2023-09-02

18.17.13 - 2023-09-01

18.17.12 - 2023-08-28

18.17.11 - 2023-08-24

18.17.10 - 2023-08-24

18.17.9 - 2023-08-23

18.17.8 - 2023-08-22

18.17.7 - 2023-08-22

18.17.6 - 2023-08-18

18.17.5 - 2023-08-11

18.17.4 - 2023-08-08

18.17.3 - 2023-08-05

18.17.2 - 2023-08-04

18.17.1 - 2023-07-25

18.17.0 - 2023-07-22

18.16.20 - 2023-07-21

18.16.19 - 2023-06-30

18.16.18 - 2023-06-13

18.16.17 - 2023-06-10

18.16.16 - 2023-05-26

18.16.15 - 2023-05-25

18.16.14 - 2023-05-21

18.16.13 - 2023-05-18

18.16.12 - 2023-05-16

18.16.11 - 2023-05-16

18.16.10 - 2023-05-16

18.16.9 - 2023-05-13

18.16.8 - 2023-05-11

18.16.7 - 2023-05-10

18.16.6 - 2023-05-08

18.16.5 - 2023-05-05

18.16.4 - 2023-05-05

18.16.3 - 2023-04-29

18.16.2 - 2023-04-27

18.16.1 - 2023-04-25

18.16.0 - 2023-04-23

18.15.13 - 2023-04-21

18.15.12 - 2023-04-19

18.15.11 - 2023-03-28

18.15.10 - 2023-03-25

    from @types/node GitHub release notes

Package name: @types/express

4.17.21 - 2023-11-07

4.17.20 - 2023-10-18

4.17.19 - 2023-10-10

4.17.18 - 2023-09-23

4.17.17 - 2023-02-03

    from @types/express GitHub release notes

Package name: express

4.19.2 - 2024-03-25

4.19.1 - 2024-03-20What's Changed

Fix ci after location patch by @ wesleytodd in #5552
fixed un-edited version in history.md for 4.19.0 by @ wesleytodd in #5556

Full Changelog: 4.19.0...4.19.1

4.19.0 - 2024-03-20What's Changed

fix typo in release date by @ UlisesGascon in #5527
docs: nominating @ wesleytodd to be project captian by @ wesleytodd in #5511
docs: loosen TC activity rules by @ wesleytodd in #5510
Add note on how to update docs for new release by @ crandmck in #5541
Prevent open redirect allow list bypass due to encodeurl
Release 4.19.0 by @ wesleytodd in #5551

New Contributors

@ crandmck made their first contribution in #5541

Full Changelog: 4.18.3...4.19.0

4.18.3 - 2024-02-29Main Changes

Fix routing requests without method
deps<EMAIL_ADDRESS>
Fix strict json error message on Node.js 19+
deps<EMAIL_ADDRESS>deps<EMAIL_ADDRESS>

Other Changes

Use https: protocol instead of deprecated git: protocol by @ vcsjones in #5032
build<EMAIL_ADDRESS>and<EMAIL_ADDRESS>by @ abenhamdine in #5034
ci: update actions/checkout to v3 by @ armujahid in #5027
test: remove unused function arguments in params by @ raksbisht in #5124
Remove unused originalIndex from acceptParams by @ raksbisht in #5119
Fixed typos by @ raksbisht in #5117
examples: remove unused params by @ raksbisht in #5113
fix: parameter str is not described in JSDoc by @ raksbisht in #5130
fix: typos in History.md by @ raksbisht in #5131
build : add<EMAIL_ADDRESS>by @ abenhamdine in #5028
test: remove unused function arguments in params by @ raksbisht in #5137
use random port in test so it won't fail on already listening by @ rluvaton in #5162
tests: use cb() instead of done() by @ kristof-low in #5233
examples: remove multipart example by @ riddlew in #5195
Update support Node.js@18 in the CI  by @ UlisesGascon in #5490
Fix favicon-related bug in cookie-sessions example by @ DmytroKondrashov in #5414
Release 4.18.3 by @ UlisesGascon in #5505

New Contributors

@ vcsjones made their first contribution in #5032
@ abenhamdine made their first contribution in #5034
@ armujahid made their first contribution in #5027
@ raksbisht made their first contribution in #5124
@ rluvaton made their first contribution in #5162
@ kristof-low made their first contribution in #5233
@ riddlew made their first contribution in #5195
@ DmytroKondrashov made their first contribution in #5414

Full Changelog: 4.18.2...4.18.3

4.18.2 - 2022-10-08
Fix regression routing a large stack in a single route
deps<EMAIL_ADDRESS>
deps<EMAIL_ADDRESS>perf: remove unnecessary object clone

deps<EMAIL_ADDRESS>

    from express GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.
Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Checkmarx One – Scan Summary & Details – e562c1d4-dc90-4bf5-8421-006f938d4e07
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Second_Order_SQL_Injection
/room/room-paging/src/main/java/androidx/room/paging/util/RoomPagingUtil.kt: 140
Attack Vector

Second_Order_SQL_Injection
/room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt: 74
Attack Vector

Stored_XSS
/room/room-paging/src/main/java/androidx/room/paging/util/RoomPagingUtil.kt: 140
Attack Vector

Stored_XSS
/room/room-paging/src/main/java/androidx/room/paging/util/RoomPagingUtil.kt: 140
Attack Vector

Stored_XSS
/room/room-paging/src/main/java/androidx/room/paging/util/RoomPagingUtil.kt: 140
Attack Vector

Stored_XSS
/buildSrc/private/src/main/kotlin/androidx/build/checkapi/ApiLocation.kt: 96
Attack Vector

Stored_XSS
/buildSrc/private/src/main/kotlin/androidx/build/checkapi/ApiLocation.kt: 96
Attack Vector

Stored_XSS
/buildSrc/private/src/main/kotlin/androidx/build/checkapi/ApiLocation.kt: 96
Attack Vector

Stored_XSS
/room/room-paging/src/main/java/androidx/room/paging/util/RoomPagingUtil.kt: 140
Attack Vector

Stored_XSS
/room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt: 74
Attack Vector

Stored_XSS
/room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt: 74
Attack Vector

Stored_XSS
/room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt: 74
Attack Vector

Stored_XSS
/room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt: 74
Attack Vector

Stored_XSS
/buildSrc/private/src/main/kotlin/androidx/build/checkapi/ApiLocation.kt: 96
Attack Vector

Stored_XSS
/buildSrc/private/src/main/kotlin/androidx/build/checkapi/ApiLocation.kt: 96
Attack Vector

Stored_XSS
/buildSrc/private/src/main/kotlin/androidx/build/checkapi/ApiLocation.kt: 96
Attack Vector

Stored_XSS
/buildSrc/private/src/main/kotlin/androidx/build/checkapi/ApiLocation.kt: 96
Attack Vector

Stored_XSS
/room/room-paging/src/main/java/androidx/room/paging/util/RoomPagingUtil.kt: 140
Attack Vector

CVE-2024-37890
Npm-ws-8.9.0
Vulnerable Package

CVE-2024-4068
Npm-braces-3.0.2
Vulnerable Package

CVE-2024-45296
Npm-path-to-regexp-0.1.7
Vulnerable Package

CVE-2024-45590
Npm-body-parser-1.20.2
Vulnerable Package

Reflected_XSS
/wear/watchface/watchface-editor/src/main/java/androidx/wear/watchface/editor/WatchFaceEditorContract.kt: 168
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt: 1809
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt: 1809
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt: 1335
Attack Vector

Reflected_XSS
/navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLinkRequest.kt: 51
Attack Vector

Reflected_XSS
/navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLinkRequest.kt: 51
Attack Vector

Reflected_XSS
/compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt: 243
Attack Vector

Reflected_XSS
/compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/VisualTransformation.kt: 30
Attack Vector

Reflected_XSS
/compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputFieldMinMaxLines.kt: 140
Attack Vector

Reflected_XSS
/glance/glance-template/src/main/java/androidx/glance/template/GlanceTemplate.kt: 39
Attack Vector

Reflected_XSS
/glance/glance-template/src/main/java/androidx/glance/template/GlanceTemplate.kt: 39
Attack Vector

Reflected_XSS
/compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/textfield/TextFieldSelectionTest.kt: 452
Attack Vector

Reflected_XSS
/window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitDeviceStateActivityBase.kt: 100
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.kt: 288
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.kt: 277
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.kt: 316
Attack Vector

Reflected_XSS
/compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/EditProcessorBenchmark.kt: 96
Attack Vector

Reflected_XSS
/compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/EditProcessorBenchmark.kt: 96
Attack Vector

Reflected_XSS
/compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/EditProcessorBenchmark.kt: 96
Attack Vector

Reflected_XSS
/window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitDeviceStateActivityBase.kt: 117
Attack Vector

Reflected_XSS
/compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/util/TestTextField.kt: 59
Attack Vector

Reflected_XSS
/paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3/Item.kt: 21
Attack Vector

Reflected_XSS
/paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3/Item.kt: 21
Attack Vector

Reflected_XSS
/paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3/Item.kt: 21
Attack Vector

Reflected_XSS
/paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3/Item.kt: 21
Attack Vector

Reflected_XSS
/compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text2/DecorationBoxDemos.kt: 85
Attack Vector

Reflected_XSS
/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TimePicker.kt: 1554
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt: 1317
Attack Vector

Reflected_XSS
/compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/colorspace/ColorSpace.kt: 458
Attack Vector

Reflected_XSS
/compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/colorspace/ColorSpace.kt: 458
Attack Vector

Reflected_XSS
/camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/ImageValidationActivity.kt: 114
Attack Vector

Reflected_XSS
/camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/ImageValidationActivity.kt: 113
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3585
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3558
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3504
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3464
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3437
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3416
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3393
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3368
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3344
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3321
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3298
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3269
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt: 3250
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt: 2359
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt: 2332
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt: 2278
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt: 2234
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt: 2207
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt: 2152
Attack Vector

Reflected_XSS
/navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt: 2132
Attack Vector

Reflected_XSS
/activity/activity/src/main/java/androidx/activity/ComponentActivity.kt: 588
Attack Vector

CVE-2024-31207
Npm-vite-4.4.7
Vulnerable Package

CVE-2024-4067
Npm-micromatch-4.0.5
Vulnerable Package

CVE-2024-43796
Npm-express-4.19.2
Vulnerable Package

CVE-2024-43799
Npm-send-0.18.0
Vulnerable Package

CVE-2024-43800
Npm-serve-static-1.15.0
Vulnerable Package

CVE-2024-45047
Npm-svelte-4.1.1
Vulnerable Package

Cx14b19a02-387a
Npm-body-parser-1.20.2
Vulnerable Package

Parameter_Tampering
/camera/integration-tests/uiwidgetstestapp/src/main/java/androidx/camera/integration/uiwidgets/foldable/FoldableCameraActivity.kt: 402
Attack Vector

Parameter_Tampering
/camera/integration-tests/uiwidgetstestapp/src/main/java/androidx/camera/integration/uiwidgets/foldable/FoldableCameraActivity.kt: 402
Attack Vector

Parameter_Tampering
/camera/integration-tests/uiwidgetstestapp/src/main/java/androidx/camera/integration/uiwidgets/foldable/FoldableCameraActivity.kt: 402
Attack Vector

Privacy_Violation
/compose/runtime/runtime/samples/src/main/java/androidx/compose/runtime/samples/ModelSamples.kt: 45
Attack Vector

Privacy_Violation
/compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/TextFieldSamples.kt: 198
Attack Vector

Privacy_Violation
/compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt: 170
Attack Vector

Privacy_Violation
/compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Draggable.kt: 575
Attack Vector

Privacy_Violation
/compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextFieldKeyboardTypeDemo.kt: 35
Attack Vector

Privacy_Violation
/compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextFieldKeyboardTypeDemo.kt: 34
Attack Vector

Privacy_Violation
/compose/runtime/runtime/samples/src/main/java/androidx/compose/runtime/samples/ModelSamples.kt: 45
Attack Vector

Privacy_Violation
/compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/TextFieldSamples.kt: 198
Attack Vector

Privacy_Violation
/compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt: 170
Attack Vector

Privacy_Violation

More results are available on AST platform


Warn user if hub_model_id is set without setting save_steps or saves_per_epoch

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
The model doesn't get saved if save steps aren't explicitly defined. If the user is setting hub_model_id, they probably have the expectation it should save.
✔ Solution
in validate_config function, let's raise a ValueError with a message that they should set one of the various save settings.
❓ Alternatives
No response
📝 Additional Context
No response
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

@winglian believe you can close this one :)


Change the transition applied to Ajax Cart Product Row when a product is removed?

Hi,
I'd like to change the animation/transition thats currently being applied to the product row in the ajax cart when the product is removed from the ajax cart.
I'd like it to just fade the product row out and then slide the remaining product rows up but I'm having some trouble locating the code thats currently controlling what happens.
Am I right in thinking the .ajaxcart__product { &.is-removed {...} } is whats controlling the transition? Is there anything anywhere else?
Any help would be appreciated, many thanks in advance!

Yes, that's all that's controlling the animation. If you want a fade and then a slide, I'd suggest removing the styles associated with is-removed in the CSS and do it only in JS. It's possible to do with CSS keyframe animations as well, but can be tricky to get the timing right.

Great, thanks for confirming that for me. I'll have a go with what you have suggested.
Thanks again!


Scripttags not installing

I'm having some difficulty getting the scripttags to install. I have made a few minor changes, but nothing that should be causing this, to my knowledge. I'm using ngrok, for starters. I added some changes to my AppSeviceProvider so it can autodetect the current domain automatically so I can use relative links in the shopify-app config file.
Here's my AppServiceProvider.php file, you can see how I add the absolute url.
    // Handle dynamic domain for absolute urls in config files
    // Script tags
    $scriptTags = config('shopify-app.scripttags');
    foreach ($scriptTags as $index => $tag) {
        config([
            "shopify-app.scripttags.$index.src" => asset($tag['src'])
        ]);
    }

    // Webhooks
    $webhooks = config('shopify-app.webhooks');
    foreach ($webhooks as $index => $webhook) {
        config([
            "shopify-app.webhooks.$index.address" => url($webhook['address'])
        ]);
    }

Here is the scripttags portion of my shopify-app config file. You can see all I've done is added a key of form so I can reference it directly if I want, and I use relative file paths.
'scripttags' => [
    'form' => [
        'src' => '/js/app/custom.js',
        'event' => 'onload',
        'display_scope' => 'online_store',
    ],
],

I am using sync as my queue driver, for testing.
So, now that's out of the way... when I install my app nothing seems to fire. I've logged $scripttag inside of ScripttagInstaller.php and I get:
[
  'src' => 'http://2ec482fd.ngrok.io/js/app/custom.js',
  'event' => 'onload',
  'display_scope' => 'online_store',
]

I'm totally confused as to why my scripttags are not auto-installing? If I manually do it
$shop = \App\Models\Shop::find($shopId);
    $post = $shop->api()->rest('POST', '/admin/api/2019-04/script_tags.json', ['script_tag' => config('shopify-app.scripttags.form')]);

It works perfectly fine. I'm out of ideas. I've even stripped out my custom code to set the domain and it doesn't work.

Welp, never-mind. It's an old fashioned case of HTTPS.
I'll leave my answer for anyone else who wants to use my method in the future. If you're going to automatically set your domains in your AppServiceProvider like me, use secure_asset and secure_url respectively.  It will pick up your current ngrok url but not add the S to your protocol.


types field in package.json should be dist/index.d.ts

Currently the types field targets to types/bmapgl/index.d.ts where defines GL JSAPI types in BMapGL namespace. There is a problem when we import this package:

Because of the types field, TypeScript can only find the BMapGL namespace in this package, all the types from the src are not exposed.
I think the types field should be dist/index.d.ts (not the previous dist/types/index.d.ts). If users complain they cannot get the type declarations for BMapGL, they should install @types/bmapgl.
This doc in this repo talks about the relations between types/bmapgl and @types/bmapgl. Users can just get BMapGL type definitions from @types/bmapgl, not from this project.

https://github.com/huiyan-fe/react-bmapgl/issues/55


Add DPG: Open Drone Suite

Works towards #555, may need some cleanup.
( created with https://github.com/ericherman/dpg-csv-to-json )

An Open Multipurpose Extensible Aerial Platform initially submitted with several gaps in the DPG standard indicators which need to be addressed before we can proceed with the review:

[ ] Clear Ownership
[ ] Platform Independence
[ ] Adherence to Standards & Best Practices
[ ] Adherence to Privacy and Applicable Laws
[ ] Do No Harm
[ ] Protection from Harassment

I have contacted the person who made the submission and will update once they come through.

This looks good to me. Remember to update the stage from nominee to DPG

Resolved in commit d9906c0


Incorrect Ordering in Cursor Pagination when Using DB Query Builder

Laravel Version
10.4.1
PHP Version
8.1.4
Database Driver & Version
No response
Description
Description:
When utilizing Laravel's cursor pagination feature with the cursorPaginate() method and attempting to navigate to the previous page using the prev_cursor parameter, the retrieved results are not the 10 records immediately preceding the prev_cursor. Instead, the pagination starts from the beginning, returning the first 10 records.
Steps To Reproduce
Steps to Reproduce:

Use the cursorPaginate() method for cursor pagination, with the following code:

$terms =  DB::table('terms')->orderBy('id')->select('id', 'title')->cursorPaginate(10);

Make a request to retrieve the next page of results.

Retrieve the prev_cursor value from the response.

Make a request to navigate to the previous page, using the prev_cursor as the cursor parameter.

Expected Result:
When navigating to the previous page using the prev_cursor, the query should reverse the ordering and retrieve the correct results so that application retrieve the immediate preceding 10 results before the specified cursor. The expected SQL query should be:
select * from terms where (id<  200) order byid desc limit 11
Above query always returns 11 records, starting from the first record in the entire database table.
Actual Result:
Instead, the generated SQL query is:
select * from terms where (title< 200) order byid asc limit 11
Note: Eloquent Models Working Correctly as expected.

I've tested locally, and indeed the cursorPaginate method is broken when used with raw query builder. @paras-malhotra Any ideas on this?


Stroke order animation

Firstly, thank you for the awesome api. I'm using it in my personal project.
Secondly, I was wondering if it would be possible to get the stroke animation or should I just directly use the kanjiVG for that?

Hi, thanks for your feedback :)
It looks like Jisho.org uses Javascript in the browser to animate the SVG files from KanjiVG. So I could have this API return a URI for the SVG that Jisho uses, if that's what you want, but then you would have to write the code to animate it. I could try to reverse-engineer Jisho's animation code to generate gifs that look the same as what you see when you run the animation on the website, but due to the high amount of work that would be involved I don't realistically see myself ever having time to do that.
If you want gifs but you don't need them to look exactly like they do on Jisho.org, you are welcome to use the ones that I generated from KanjiVG data for one of my projects, those are here: https://github.com/mistval/kotoba/tree/master/resources/images/kanjianimations . Those were generated using Kanimaji: https://github.com/maurimo/kanimaji . I can certainly add URIs to those in this API if that would get you the results you are hoping for.
Would either of those options do what you're hoping for?
1: Return a URI to the SVG that Jisho.org animates.
2: Return a URI to the appropriate gif file from here: https://github.com/mistval/kotoba/tree/master/resources/images/kanjianimations

Check out the new version 1.1 (https://www.npmjs.com/package/unofficial-jisho-api) I've added both to the result data: a strokeOrderSvgUri and a strokeOrderGifUri property. Usage is demonstrated in the updated README.md.
Please note that a strokeOrderGifUri will always be returned, but a gif file may not exist at that location for some rare kanji. Gifs are available for about ~6000 kanji.
Closing the issue, please feel free to reopen if you have any trouble :)

Thank you! It works great.


Error when starting rtlamr

I installed rtlamr on my mac , plugged in an rtl_sdr, and ran it:
./go/bin/rtlamr -msgtype=r900 -centerfreq=912000000
16:06:46.280750 main.go:90: Error connecting to spectrum server: dial tcp <IP_ADDRESS>:1234: connect: connection refused
rcvr.Connect
main.(*Receiver).NewReceiver
    /Users/ihf/go/pkg/mod/github.com/bemasher/rtlamr@v0.9.3/main.go:90
main.main
    /Users/ihf/go/pkg/mod/github.com/bemasher/rtlamr@v0.9.3/main.go:313
runtime.main
    /usr/local/Cellar/go/1.23.2/libexec/src/runtime/proc.go:272
runtime.goexit
    /usr/local/Cellar/go/1.23.2/libexec/src/runtime/asm_amd64.s:1700
I realize I was naive thinking this would just work, but perhaps someone could shed light on these errors.

Hey, how did you get rtl_tcp to run? I have set to start as a service, and when I check the status everything seems to be running correctly (all green). But running the ./go/bin/rtlamr command results in the same error as you get.


🐛 Fixed error when importing members

fixes TryGhost/Team#2266
The getCreatedEvents method was removed but was still used in the verification trigger

Closed in favour of https://github.com/TryGhost/Ghost/pull/15832


RRuleSetIter: removed lifetimes and added from_str example

This is just between a feature and a fix.
In my use-case, i have to store a RRuleSetIter inside an object up to keep the current state of the iterator and not recreate the iterator again and again
Therefore, it was not possible due to the lifetime of  RRuleSetIter, currently :
pub struct Recurrent<'a> {
    rrule_iter: RRuleSetIter<'a>,
}

impl<'a> FromStr for Recurrent<'a> {
    type Err = RRuleError;

    fn from_str(s: &str) -> Result<Self, Self::Err> {
        let rrule = s.parse::<RRuleSet>()?;
        let iter: RRuleSetIter<'a> = rrule.into_iter();
        return Ok(Self {
            rrule_iter: iter,
        });
    }
}

Gives this error :
error[E0597]: `rrule` does not live long enough
  --> src/programs/module/recurrent.rs:17:38
   |
12 | impl<'a> FromStr for Recurrent<'a> {
   |      -- lifetime `'a` defined here
...
16 |         let rrule = s.parse::<RRuleSet>()?;
   |             ----- binding `rrule` declared here
17 |         let iter: RRuleSetIter<'a> = rrule.into_iter();
   |                   ----------------   ^^^^^ borrowed value does not live long enough
   |                   |
   |                   type annotation requires that `rrule` is borrowed for `'a`
18 |         return Ok(Self { rrule_iter: iter });
19 |     }
   |     - `rrule` dropped here while still borrowed

So, I removed the lifetimes, and the only real change is the in the struct IterInfo where the field rrule have to be a value and not a reference, and it has to be cloned on IterInfo::new.
Since it is also possible now, I implemented FromStr for  RRuleSetIter in addition.

Thanks for the contribution. LGTM!
Once the CI issues are resolved we can merge this

Thanks for review, I reformatted the file who broke the CI.


wildcards

Wildcards don't seem to work. For example I want -ukrai* in my search. Thanks

Sorry, wildcards are not supported, and I have no plans to implement them.
hnapp supports basic stemming, e.g. if you search for "sponsored" you'll get words like "sponsor" as well, but it doesn't cover all variations of the same word root. You'll need to specify all the word variations that you want to exclude from your query.


Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I want to use PGVectorStore but when is creating a table instead of use the table name I pass, why? And the file is created empty.
vector_store = PGVectorStore.from_params(
database=db_name,
host=url.host,
password=url.password,
port=url.port,
user=url.username,
table_name="interrests_embeddings",
schema_name="public",
perform_setup= False,
embed_dim=1536  # openai embedding dimension
)
And what collumns are necessary in my table?

I use UUID as the primary key throughout my database. Is it necessary to use a numeric auto-increment ID for this table? Are there any other options for using the UUID type in the ID field?


Automations rules not firing upon incident update of type comment added

Describe the bug
Hi there !
It seems like sometimes automation rules of type incident update (specifically comment added or incident ownership change in our use-case) do not fire their affected logicapp. It also seems to happen randomly and with or without other automation rules having their child logicapp execution done or not.
Although there was a specific case in which stopping a logicapp with a long execution time fired by an automation rule of type incident created did then permit correct execution of our automation rule, that does not seem to be the problem since it also happens without this.
We do use this on a cross-tenant sentinel configuration across multiple sentinels, however i do not think this could be the issue? (unless some sort of cap is in place for incident updates)
To Reproduce
Steps to reproduce the behavior:

Make automation rules, some of type incident created and others of type incident updated (comment added or owner changed), have them fire logicapps
Some expected logicapp executions from incident update automation rules will not happen. Bear in mind the proportion in which it happens is not huge but definitely not unnoticeable even compared to our influx of incidents.

Expected behavior
In our specific case every time a comment is added or the owner changed, the configured logicapp should be triggered.
Screenshots
Here is an incident update supposed to trigger a logicapp :

Here is the automation rule supposed to trigger :

And here is the latest entry in the logicapp run and trigger history :

Hi @FormindALH , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 21Dec23. Thanks!

I believe we might be seeing the same issue as @FormindALH in a multi-tenant setup, where certain automation rules will occasionally - and seemingly randomly - fail to trigger the associated playbook (which is shared between all tenants).
The same playbook is triggered both on incident creation and on incident updates, but so far it looks as if we're only experiencing the issue when incidents are updated.
When the "incident updated" automation rules fail to trigger the playbook, we can see related entries with the following details in SentinelHealth in the affected workspaces:

OperationName
ExtendedProperties.TriggeredOn
ExtendedProperties.TriggeredWhen
Status
Description
Reason

Automation rule run
Incident
Updated
Failure
Could not trigger playbook: <playbookName>. An internal server error occurred. Please contact support for assistance.
Action run failed.

The issue reported by @FormindALH is being investigated in case #2312210050000718. Will update if there is something noteworthy to share.
@brynjare I would suggest you to do the same and raise a case with Sentinel if you can.
We should close this issue. A proper investigation involves sharing confidential data and this is not the correct place to do so.

Ok @garis , we are closing the issue (https://github.com/Azure/Azure-Sentinel/issues/9604)  If you still need support for 	this issue, feel free to re-open at any time. Thank you for your co-operation!


FileSystemSourceSetting can not be deserialized

The path and regex's cause issues with deserializing due to Pattern.compile and Path.get.

This has now been addressed (in Baleen at least) with a Pattern and Path serializer/deserializer. Closing, but reopen again if still an issue.


Usage directions hard to find

The usage directions for Nostalgy available at http://alain.frisch.fr/info/ABOUT_NOSTALGY.html are hard to find, but should be easy to find.
Users starting from https://addons.thunderbird.net/de/thunderbird/addon/nostalgy/ do not have a change to find them. Starting from this page they can install Nostalgy or go to the homepage of Nostalgy at http://alain.frisch.fr/soft_mozilla.html. But this page does not contain a link to the usage directions.
Therefore I would like to have the usage directions as part of the information available via Github.
I volunteer for this task.

Hi @obfischer Obfisher, could you send a pull request to my fork? https://github.com/MLopez-Ibanez/nostalgy
Or if you attach the markdown text here, I'll merge it and make a pull request.

I agree that it would be nice to add the Usage directions to the repository and replace the link in the Nostalgy Preferences accordingly.

Actually the Usage directions already in this repository (see about.xhml):
https://github.com/nostalgy/nostalgy/blob/7dc4f78de515cf8dbb58306585a17356603e5fa0/chrome/content/about.xhtml#L20

@obfischer Would it be enough to link to this file from the README.md?


Test Helper

Consider adding some test helpers like assertSentEmail(), here or in the framework.

Should also include DOM capabilities, probably leveraging TestResponse somehow.


Add jsconfig.json support

Hey 👋
It would be nice if jsconfig.json would be used if it exists in the root directory, similar to tsconfig.json.

Sounds good! I will try it as soon, and thanks for your interest in this project!

@9romise wow that was fast 😅
Thank you a lot, I've been using and recommending your resolver for a few weeks and it works great so far!


[Help] How to invoke third http api?

I want to invoke rest api , how can I make it happen?

Hi @NiuBlibing, this is a feature that would be available with custom node under #47. Closing in favour of it.

Hi @NiuBlibing, this would be possible once #47 is resolved, closing in favour of it.


Add Netlify Support

Support Netlify
Documentation: https://docs.netlify.com/configure-builds/environment-variables/#git-metadata
Environment variables:

service detection: NETLIFY
Branch: BRANCH
Commit sha: COMMIT_REF
Is Pull request: PULL_REQUEST
Pull request: REVIEW_ID
Build number: BUILD_ID

Willing to create a PR if this sounds reasonable


[da-vinci][server] Introduced configs to control maximum database size

Summary
This code change introduces two configs:
/**

Ingestion will be paused or fail when the disk usage hits either {@link #SERVER_DISK_FULL_THRESHOLD} or {@link #SERVER_DATABASE_SIZE_LIMIT}
Default: -1, disabled. */ public static final String SERVER_DATABASE_SIZE_LIMIT = "database.size.limit";

/**

Database size measurement is an expensive operation, and we would like to make the measurement interval
configurable to tune the performance.
Default: 256MB */ public static final String SERVER_DATABASE_SIZE_MEASURE_INTERVAL = "database.size.measure.interval";

If the persisted database size exceeds the configured maximum size, the ingestion will fail for batch push and pause for hybrid stores. This feature is mainly introduced for PlainTable use cases especially with DaVinci since Venice will try to mmap all the data files into memory, and it is good to have a uppper limit to avoid OOM.

How was this PR tested?
CI
Does this PR introduce any user-facing changes?

[ ] No. You can skip the rest of this section.
[X] Yes. Make sure to explain your proposed changes and call out the behavior change.
Please check the above new configs.

What is a recovery process after triggering this check?

One more moment with the check, it should work well for PlainTable when application uses mlockall, but in other cases the check will stop the ingestion preemptively.

One more moment with the check, it should work well for PlainTable when application uses mlockall, but in other cases the check will stop the ingestion preemptively.

Why does it work for PT?

@sixpluszero I mean that memory usage for PT + mlockall is almost equivalent to size on disk. But peak physical memory usage is less than size on disk during version transition due to page-cache.

Closed this since we have merged DaVinci memory limiter feature.


Added kernel .config that works with docker

This may not belong in this repo. It's a sample config to build a kernel on the Jetson tx2 that will run docker.

This is interesting. I need to decide how to incorporate something like this in a more general case.
Would you consider writing a little for  a post on JetsonHacks saying how you use it with RPI images?

L4T 28.2 now includes Docker kernel support.


ocp4.4 provider cluster up stuck in infinite wait when using export KUBEVIRT_NUM_NODES=3

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
following the ocp4.4 README, I tried in a remote server:
export KUBEVIRT_PROVIDER=ocp-4.4
export KUBEVIRT_NUM_NODES=3 # master + two workers
make cluster-up

The cluster gets stuck waiting for a second worker. console stdout attached
if I unset KUBEVIRT_NUM_NODES env then the cluster up spins ok.
What you expected to happen:
the cluster should spin up with no issue
How to reproduce it (as minimally and precisely as possible):
follow the ocp4.4 README file.
Anything else we need to know?:
nope
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

please move it to kubevirtci imo
thanks

can be closed ocp is removed from kubevirtci
thanks


⚠ ClamAV has degraded performance

In c7c612d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in 16a62f9.


Tinyheads

New clock

Fun one - thanks!
Just a thought, personally I think it looks a little off when on light theme the widget field will be white. But it also made me think maybe tinyheads could randomize the background color, so it looked a bit like the thiny head wore a headband.


Non-continuous Rotational Acceleration

I made a holonomic test path that drives straight forward 3 meters and rotates 360 degrees. I had to add an intermediate point at the halfway point with a holonomic angle of 180 degrees to force. Looking at the preview it looks good, but looking at the angular velocity graph, it is not smooth. Meaning that the angular acceleration is not continuous.
The angular velocity for the first half of the of the path is higher than the velocity for the second half. I understand that the angular velocity will be impacted by the speed of the robot, but there shouldn't be a discontinuity at the midpoint.
Is this just a limitation of how the path planner creates trajectories?

Likely another issue with control point placement. If you send the path file I can tell you exactly what is wrong. Path is fine on my end when I make a path according to your description.

{
  "waypoints": [
    {
      "anchorPoint": {
        "x": 2.0,
        "y": 3.0
      },
      "prevControl": null,
      "nextControl": {
        "x": 3.0,
        "y": 3.0
      },
      "holonomicAngle": 0.0,
      "isReversal": false,
      "velOverride": null,
      "isLocked": false,
      "isStopPoint": false,
      "stopEvent": {
        "names": [],
        "executionBehavior": "parallel",
        "waitBehavior": "none",
        "waitTime": 0
      }
    },
    {
      "anchorPoint": {
        "x": 3.5,
        "y": 3.0
      },
      "prevControl": {
        "x": 3.4696235779280062,
        "y": 3.0
      },
      "nextControl": {
        "x": 3.5303764220719938,
        "y": 3.0
      },
      "holonomicAngle": 180.0,
      "isReversal": false,
      "velOverride": null,
      "isLocked": false,
      "isStopPoint": false,
      "stopEvent": {
        "names": [],
        "executionBehavior": "parallel",
        "waitBehavior": "none",
        "waitTime": 0
      }
    },
    {
      "anchorPoint": {
        "x": 5.0,
        "y": 3.0
      },
      "prevControl": {
        "x": 4.441675349270015,
        "y": 3.0
      },
      "nextControl": null,
      "holonomicAngle": 360.0,
      "isReversal": false,
      "velOverride": null,
      "isLocked": false,
      "isStopPoint": false,
      "stopEvent": {
        "names": [],
        "executionBehavior": "parallel",
        "waitBehavior": "none",
        "waitTime": 0
      }
    }
  ],
  "maxVelocity": 2.0,
  "maxAcceleration": 2.0,
  "isReversed": null,
  "markers": []
}

Yeah, your midpoint has control points way too close to the anchor point so it is going to do weird things.
Turn this:

into something like this (since the points completely overlap, you wont be able to drag them since it will just move the entire waypoint. you will have to delete this point and make another):

When creating paths, you need to make sure that the control points are positioned properly. They aren't just tangent lines, they affect the shape of the path. So, if you have them way too close together, overlapping, etc., it will give you a weird result because it is getting weird input. As a decent rule of thumb I would make sure they never overlap with the anchor point at all.

I was able to reduce the non-continuity at the midpoint by adding a velocity override to the midpoint. Using a velocity override lower than the max velocity,  1.8 m/s for a max velocity of 2.0 m/s.
I am wondering if the rotational velocity graph glitches when the angle changes sign.

I was just looking at the edit data that shows up when you click on the point and ignoring the tangent lines in the GUI. Making the tangent lines as short as I can greatly improved the graph.

Generally, making them as short as you can is not a good idea. You should probably create a path and just drag the control points around for a while to see how they affect the path. Moving them to extremes of too close/too far will end up making sharp curves in the path that can cause issues with discontinuity.

They aren't just tangent lines, they affect the shape of the path.

I don't understand how the location of the control points along a straight line with zero curvature can effect the freedom of the robot to rotate to match the desired holomorphic angle. That's ok, I do see the effect when I tinker with the control points.
I can understand how trying to satisfy robot path heading and the holomorphic heading can be at odds. It makes sense that as you reduce the weight of the path heading (by shortening the length of the control vector) you give more freedom to satisfy the holomorphic heading.

Generally, making them as short as you can is not a good idea.

I understand that. Just in this special case, I'm making a straight line path with no curvature at all, so no sharp curves.
Thanks for the feedback. I learned a lot!


Fix --restart

I've always had trouble with the --restart flag. I want it to restart web servers on file changes, but I always seem to get an address in use error no matter what I do.
Steps to reproduce
$ touch a
$ filewatcher -I --restart a 'python -m SimpleHTTPServer'
Serving HTTP on <IP_ADDRESS> port 8000 ...

Then in another window, run touch a to make filewatcher restart the server. I get something like this.
Traceback (most recent call last):
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/SimpleHTTPServer.py", line 218, in <module>
    test()
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/SimpleHTTPServer.py", line 214, in test
    BaseHTTPServer.test(HandlerClass, ServerClass)
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/BaseHTTPServer.py", line 592, in test
    httpd = ServerClass(server_address, HandlerClass)
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/SocketServer.py", line 408, in __init__
    self.server_bind()
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
    SocketServer.TCPServer.server_bind(self)
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/SocketServer.py", line 419, in server_bind
    self.socket.bind(self.server_address)
  File "/Users/lthomas1/.asdf/installs/python/2.7/lib/python2.7/socket.py", line 222, in meth
    return getattr(self._sock,name)(*args)
socket.error: [Errno 48] Address already in use

The new process we're starting isn't able to listen to the port because the old process is still hanging around.
I started digging around and I noticed the variable child_pid is always nil, ever after filewatcher cycles the process. I think we need to add an explicit return in the ensure block to alter the return value of the restart command. I did some googling and this blog post seems to confirm that suspicion http://blog.leshill.org/blog/2009/11/17/ensure-with-explicit-return.html.

@luk3thomas Thank's for taking time to dig into to the problem and submitting a pull request. The solution was very simple.
I am happy to see that the --restart option is being used.

My pleasure!
What is the process for creating a new release?

What is the process for creating a new release?

I can do this. But I'd like to see some tests for this (that don't work without this change and work with it).

What is the process for creating a new release?

Done today as 1.1.0.


Permanent error

v1.0.0
C:\Users\Glaived\AppData\Local\Programs\VALORANT rank yoinker>"VALORANT rank yoinker-Portable.exe"
Traceback (most recent call last):
  File "main.py", line 1, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "PyInstaller\loader\pyimod03_importers.py", line 546, in exec_module
  File "requests\__init__.py", line 100, in <module>
  File "requests\__init__.py", line 85, in check_compatibility
Exception: You need either charset_normalizer or chardet installed
[636] Failed to execute script 'main' due to unhandled exception!

???

Gonna be fixed in 1.2


FlipIt on chocolatey  - package manager for windows

Hi!
I would like to suggest you to put Fliplt on chocolatey which is a package manager for windows.
With chocolatey you could install a screensaver with command like:
choco install flipIt

Let me know what do think about this idea! 😄

Hi!
Any updates or thoughts on chocolatey?
If not, there is a second option - win-get. It just needs a manifest file and it will be available to you and everyone else by a single command.
https://learn.microsoft.com/en-us/windows/package-manager/package/repository
Let me know what do think about this idea! 😄


[plugin-prisma] select not present in query

According to the documentation:

the query argument will add in includes or selects to resolve as much of the request in a single query as possible.

However, we notice that this is not happening in our case. In the example below we query only the field hash, but we notice that when adding a breakpoint and inspecting the query object, that there is no select inside, so it still queries all the fields. Is this a configuration issue?
I've included short examples of our setup. If you wan to peek at the full one, the repository is open source:

Yoga Server
SchemaBuilder
Block query

query {
  block(hash: "~snip~") {
    hash
  }
}

builder.queryField('block', (t) =>
  t.prismaField({
    args: {
      hash: t.arg.string({ required: true }),
    },
    type: Block,
    nullable: true,
    async resolve(query, __parent, args) {
      return await prismaClient.block.findUnique({
        ...query,
        where: {
          hash: args.hash,
        },
      });
    },
  }),
);

This depends on how Block is defined.   The default behavior is to select all columns, and oy include the queried relations.  You need to define a select option on the Block type if you don't want to select all columns

So, I've found a way to do this, but it's probably error prone, and you have to ditch type safety mostly (also ts-ignoring the resolve since it only returns a partial Block).
builder.queryField('block', (t) =>
  t.prismaField({
    args: {
      hash: t.arg.string({ required: true }),
    },
    type: Block,
    nullable: true,
    // @ts-ignore
    async resolve(query, __parent, args, context, info) {
      try {
        const fieldNodes = info.fieldNodes;
        let select;

        if (fieldNodes.length) {
          const selectionSet = fieldNodes[0].selectionSet;
          select = selectionSet?.selections.reduce(
            (acc: any, selection: any) => {
              acc[selection.name.value as string] = true;
              return acc;
            },
            {},
          );
        }

        const block = await prismaClient.block.findUnique({
          ...query,
          where: {
            hash: args.hash,
          },
          select,
        });

        return block;
      } catch (error) {
        throw normalizeError(error);
      }
    },
  }),
);

That will probably cause a lot of other issues.   Just add select: {} to your Block type definition and everything should work the way you want

That worked!
Some findings:

In prismaNode Block I do select: {}, then for every field in Block that calls parent.<some_field> I have to do a select: { <some_field>: true }, otherwise it will throw Typescript errors, thinking the field does not exist. This is by design I assume?
One of my fields in prismaNode Block is a reference to a different Block, thus ebing the same type. I noticed that here Prisma still queries all fields, even if only one if requested form the GraphQL query.
To continue on the first point, if a prismaConnection field inside prismaNode Block references parent.<some_field>, then adding select: { <some_field>: true } does not work, it will still throw type errors, unlike the other types of fields. So here I have to do a ts-ignore or cast parent to type Prisma Block.

In prismaNode Block I do select: {}, then for every field in Block that calls parent.<some_field> I have to add a select: { <some_field>: true } on that specific field, otherwise it will throw Typescript errors, thinking the field does not exist on the parent. This is by design I assume?

Yes this is by design, the select on the type determines what is selected by default, and therefore what is available on the parent object.   t.expose, t.relation, and t.relatedConnection add their required selections automatically.  Anything else we don't know what columns you might depend on so you need to select them yourself.

One of my fields in prismaNode Block is a reference to a different Block, thus being of the same type. I noticed that here Prisma still queries all fields, even if only one field is requested form the GraphQL query.

I don't know what this means

To continue on the first point, if a prismaConnection field inside prismaNode Block references parent.<some_field>, then adding select: { <some_field>: true } on that specific field does not work, it will still throw type errors, unlike the other types of prisma functions (like prismaNode, where it does work). So here I have to do a ts-ignore or cast parent to type Prisma Block.

This may be a bug, and is something I usually don't need.  I'll look into it but in the meantime time, usually relatedConnection is better if it can work, if not, looking at the docs for indirect connections may help.   The other thing you can do is just add the selection to the who type, usually things like the primary key are selected anyway so adding that to the base selection for the type doesn't add any overhead.

This is not configurable for the node and nodes queries (as far as I could find), there it will still select all fields.

This should work fine for the node/nodes queries, do you have an example of this not working?  If you are talking about other fields defined with t.node that probably depends on how you are defining the fields

Your not using the query arg in your prisma call.  If you don't spread that into prisma query the query obviously won't have the right selections


//test/common/upstream:load_balancer_benchmark_test timeouts under --config=clang-tsan

It seems that some of the benchmarks added in #12594 contributed to pushing the benchmark past the tsan timeout, but there are other benchmarks that are very slow.
Slow benchmarks under tsan include:
benchmarkLeastRequestLoadBalancerChooseHost/100/1/1000000        25 sec
benchmarkLeastRequestLoadBalancerChooseHost/100/2/1000000        25 sec
benchmarkLeastRequestLoadBalancerChooseHost/100/3/1000000        27 sec
benchmarkLeastRequestLoadBalancerChooseHost/100/10/1000000       32 sec
benchmarkLeastRequestLoadBalancerChooseHost/100/50/1000000       69 sec
benchmarkLeastRequestLoadBalancerChooseHost/100/100/1000000     115 sec
benchmarkRingHashLoadBalancerHostLoss/500/256000/1/10000          8 sec
benchmarkRingHashLoadBalancerHostLoss/500/256000/2/10000          8 sec
benchmarkRingHashLoadBalancerHostLoss/500/256000/3/10000          8 sec
benchmarkSubsetLoadBalancerCreate/0/512                           6 sec
benchmarkSubsetLoadBalancerCreate/0/2500                        120 sec
benchmarkSubsetLoadBalancerUpdate/0/512                          10 sec
benchmarkSubsetLoadBalancerUpdate/0/2500                       240 sec

cc @ggreenway


Update notification banner example to use correct markup

Updating one of the examples in the notification banner component so that the heading within the banner uses a h3 instead of a p.
I think that was our original intent, and reflects the hierarchy of the content more accurately. Let me know there's a reason it is the way it is!

You can preview this change here:
Built with commit 858a3e7a46eab17c0100ed75df4b79cfbec34baf
https://deploy-preview-1515--govuk-design-system-preview.netlify.app


Support a pool of available drive images

Typcially most images reside in the same folder. It would be convenient for the users if one could specify those images just by their name instead of their full path. In addition, the set of available images might be displayed by the web interface so that one could simply select new images from this image pool.
Essentially, a new command line option that specified the path of this image folder is needed, with some simple logic to look up the images in the pool.

The web interface currently does show a listing of the available images in the /home/pi/images directory. We could use that as the default, then add a command line option to override that at startup.

Sounds good!

The location of the default image folder should be known to the rascsi process, so that one can use rasctl to attach an image without providing the full path.
The default image folder should be returned with PbServerInfo.


A7670G SSL EC formats

It works with HTTPS server with RSA 2048bit public key and Elliptic Curve 256bit public key.
BUT, If I connect to a server with EC 384bit then I get HTTP error 751 (TLS handshake failure).
Is there a new modem firmware which supports contemporary TLS suite? My modem has firmare V1.11.1

There is currently no firmware that supports EC formart

I don't think that is quite correct. EC256 keyed certificates are processed OK, just not EC384.
Can you confirm modem v1.11.1 is the latest?

V1.11.1?
This is not the modem firmware version. Send AT+SIMCOMATI to check the return result.

Because ATI and AT+SIMCOMATI provide different revision numbers......
ATI
Manufacturer: INCORPORATED
Model: A7670G-LLSE
Revision: A7670M7_V1.11.1
AT+SIMCOMATI
Manufacturer: INCORPORATED
Model: A7670G-LLSE
Revision: A011B17A7670M7
A7670M7_B17V01_230621

I need to check with SIMCOM

SIMCOM replied that the following are supported
0 SSL3.0
1 TLS1.0
2 TLS1.1
3 TLS1.2

No EC384


Fix symfony version

Unable use if your symfony components version are > 3.0.0 ...

@ProPheT777 hm. these changes didn't result in a change to composer.lock? That seems somewhat... surprising to me.

@simensen nope nothing, I remove it and try again.
 Problem 1
    - Conclusion: don't install stack/builder v1.0.3
    - Conclusion: don't install stack/builder v1.0.2
    - Conclusion: don't install stack/builder v1.0.1
    - Installation request for stack/builder ^1.0 -> satisfiable by stack/builder[v1.0.0, v1.0.1, v1.0.2, v1.0.3].
    - Conclusion: remove symfony/http-foundation v3.0.1
    - stack/builder v1.0.0 requires symfony/http-foundation ~2.1 -> satisfiable by symfony/http-foundation[v2.1.0, v2.1.1, ..., v2.8.2].
    - Can only install one of: symfony/http-foundation[v3.0.1, v2.8.0].
    - Can only install one of: symfony/http-foundation[v3.0.1, v2.8.1].
      ..... blablabla
    - Can only install one of: symfony/http-foundation[v3.0.1, v2.7.9].
    - Installation request for symfony/http-foundation == <IP_ADDRESS> -> satisfiable by symfony/http-foundation[v3.0.1].

I'm agree that should work but ... and composer seem's to try against this version <IP_ADDRESS>
In all case we should extend the support to upper level, symfony is strictly following semver.


Mango bug

Description
Fixes # (issue)
intermittent bug in connection script for Mongo
Type of change
import certifi module
add tlsCAFile=certifi.where() in MongoClient:
return MongoClient(getenv("MONGO_URL"), tlsCAFile=certifi.where())[self.cluster][collection]
Please delete options that are not relevant.

[x] Bug fix

Checklist:

[x] My code follows the PEP8 style guide
[x] I have removed unnecessary print statements from my code
[x] I have made corresponding changes to the documentation if necessary
[x] My changes generate no errors
[  ] No commented-out code
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Looks really good!

It would be good if u describe more about the type of bug changes you made. Other than that everything looks good.

Hi, what is the issue with mongo we are having right now?

Hi,
I requested a new PR based on Ryan's suggestion and added detailed
information about the issue in the PR. Thanks for the reviews and comments
from Rodrico, Annapurna and Ryland.
On Fri, Feb 11, 2022 at 11:09 AM ulloa @.***> wrote:

Hi, what is the issue with mongo we are having right now?
—
Reply to this email directly, view it on GitHub
https://github.com/BloomTech-Labs/underdog-devs-ds-a/pull/29#issuecomment-1036529478,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFHWEUUVG4RXWXJ3Z47EO3DU2VNGVANCNFSM5OEUKFHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message
ID: @.***>


feat: add storage_type parameter

what
Amazon has announced IO-optimized storage type for DocumentDB. Support for it has been added since HashiCorp AWS provider version 5.29.0
why
Keep standard as default but also add ability to create IO-optimized DocumentDB clusters.
references
https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-documentdb-i-o-optimized/
https://registry.terraform.io/providers/hashicorp/aws/5.29.0/docs/resources/docdb_cluster#storage_type

@Gowiem @florian0410
Hi!
Could you please reconsider this request, as the changes are minimal, but this feature is quite important for cost optimization.
Thanks!

Hi! Any estimation when this will be ready? Thanks

We urgently need this PR to be merged and really would appreciate if progress can be made.
Thank you.

/terratest

Hey folks, quick update: We're looking into why our CI didn't run and then we'll get this approved and merged. Apologies for the delay and thanks for the pings. Going forward if you do want some functionality like this merge, feel free to ping us in the SweetOps slack via the #pr-reviews channel and someone will be faster to get to you.
Side note -- @adubeniuk, since this is being asked for by a few folks I just want to move it along, but I would normally request that you add a validation block to your new variable since it has an explicit set of values. See here for an example: https://github.com/cloudposse/terraform-aws-documentdb-cluster/blob/main/context.tf#L86-L89. If you can add that in the near term before we get the CI check figured out... that may kick the CI check when you do a push which would be a win-win

hi @Gowiem
added the necessary validation
thanks

/terratest

Hey @adubeniuk, unfortunately, we need to run some automation to pass our tests. Mind doing the following locally, committing the result, and pushing to your branch?
make init
make readme

Thanks!

hi @Gowiem, updated Readme, thanks

/terratest

@adubeniuk thanks for the hard work! This has been released as https://github.com/cloudposse/terraform-aws-documentdb-cluster/releases/tag/0.25.0 👍
cc @awb-i4o @cbonilla-liquid @vsenk0as

@Gowiem
thanks!


Update README.md

Add link to Keras documentation

PR on wrong repo (my fork). Just made another on upstream


[Fix #1343] False negatives for Rails/EnumSyntax

Fix #1343. I don't believe there is any issue with just looking at all value types. It just translates foo: bar into :foo, bar.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

I apologize for not explaining myself clearly.
If you are going to address _instance_methods in this PR, please squash the commits into one.
Or, If it seems better to separate the commits due to the user impact, it might also make sense to have a separate changelog entry, so it would be better to open it as a separate PR.
Could you handle it in the way you prefer?

I squashed, seems fine to just do here. This only really matters with the previous change anyways, since it now specifically looks at what the option key looks like.

Thanks!


Sleep for TIMEOUT if job was throttled

We sleep for TIMEOUT if no job was received (from redis, or queues list
was empty), thus it makes sense to sleep for same amount of time when
we got job but it was throttled.
This especially makes sense if you have a single queue that is hardly
throttled and has bazillions of jobs in it.

@mnarayan01 your input is highly appreciated, my friend! :D

I think this is a probably a good trade-off, though note commit 3727998dae8bd7e9e239f9279897d399179da6fb.

Referenced commit was introduced actually because the idea of "local cache of recently throttled queues" was giving no real benefit. It was pretty impossible to get queues empty. Thus sleep was never reached, and we were just running synchronize with queues list handling for no good. :D


Update build.gradle to point to next SNAPSHOT

Releasing 0.42.3 today, bumping up snapshot.

I'm just following what the Wiki page here says https://wiki.mesosphere.com/display/ENGINEERING/Releasing+the+SDK
I have no preference either.

Updated the page, may as well go with bumping to 0.43.0-SNAPSHOT

+1 to 0.43-SNAPSHOT, it gives you room to work on features for the next release while being able to patch if necessary. If you update the patch number then you're kind of implying that youre fixing another bug. Then again, isn't sdk042 in maintenance mode or are there still features planned?


(maint) Include facts necessary for "warn" type

The provider for the warn type in the basic module used for testing apply is confined to agents with the another fact. Bolt spec tests currently only test that an apply block containing the warn type will compile. If the apply block is actually attempted to be run on an agent the warn type will not actually raise the warning because the another fact is not bundled in the plugin targball that is shipped to the agent. This commit includes the fact so that the warn type would raise the warning if applied to an agent.

As we look at adding acceptance tests in orch for apply in PE plans we will be looking to the basic module for test content https://tickets.puppetlabs.com/browse/PE-28597
Having this fact will allow us to test not only compilation but also application.

CLA signed by all contributors.


Bug: Superset permissions cached indefinitely

The security manager uses an LRU cache on LMS calls to get a user's courses, on a small site it may never expire leading to old permisisons such as not being able to log in to Superset or having instructor access when it has been revoked: https://github.com/openedx/tutor-contrib-aspects/blob/90a8afd161b4664352a3553b919a73a5ad8a4b98/tutoraspects/templates/aspects/apps/superset/pythonpath/openedx_sso_security_manager.py#L193C1-L194
We should either make this a time based cache or remove it altogether.

We're seeing reports of this on the beta server again, even though I've confirmed it's got the fix for the LRU cache, so I'm going to reopen it. Waiting to hear if bouncing the server fixes it like it did last time. So far it's persisted over an hour without getting new permissions.


chore(main): release 0.8.0

:robot: I have created a release beep boop
0.8.0 (2023-04-02)
Features

status: 完成 section{国内外\app 现状} 的文本部分 (c0e0a72)
status: 添加插图 (c2d2028)

Bug Fixes

appendix: add space before ref (3c2a173)
background: add spaces around ref (9ab1048)

Documentation

abstract: update todos (938f70a)
readme: remove wiki link (#49) (4ebd684)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/thesis/releases/tag/v0.8.0 :sunflower:


Wrong checking return type from function

type A = {
  a: boolean;
}
type B = (v: A) => A

const c: B = (a) => {
  return { a: true, asd: 235 }
}

Why I don't have error?
But if I will write such code, then I get error:
const f = (v: A): A => {
  return { a: true, asd: 235 }
}

Duplicate of #241/#29390/#30198. (The first issue might not look immediately related but its the root cause).

@jack-williams how i understand, this problem will not be solved, becouse first post was in 2014, right?


JSON Output for Type::none Fields

Currently, when a field of type Type::none is encountered, its value is not printed -- as we return an empty string
https://github.com/bpftrace/bpftrace/blob/c14a2ce8b7afa3950e7263d509bd869cb1284b97/src/output.cpp#L417-L419
This leads to invalid JSON formatting because the fields with missing values are not represented.
It would be an easy fix to return ”null” for json outputs in these cases.

@amiremohamadi Do you have an example script that outputs this?

for instance in this case:
$ bpftrace -e 'kprobe:vfs_write {print(*(struct file *)arg0); exit()}'

I see some missing values (E.g. f_count)
{ .f_llist = { .next = 0x0 }, .f_rcuhead = { .next = 0x0, .func = 0x0 }, .f_iocb_flags = 0, .f_lock = { .rlock = { .raw_lock = { .val = , .locked = 0, .pending = 0, .locked_pending = 0, .tail = 0 } } }, .f_mode = 135135239, .f_count = , .f_pos_lock = { .owner = , .wait_lock = { .raw_lock = { .val = , .locked = 0, .pending = 0, .locked_pending = 0, .tail = 0 } }, .osq = { .tail =  }, .wait_list = { .next = 0xffff931c675f6b30, .prev = 0xffff931c675f6b30 } }, .f_pos = 0, .f_flags = 2050, .f_owner = { .lock = , .pid = 0x0, .pid_type = 0, .uid = , .euid = , .signum = 0 }, .f_cred = 0xffff931b9f4a2180, .f_ra = { .start = 0, .size = 0, .async_size = 0, .ra_pages = 0, .mmap_miss = 0, .prev_pos = 0 }, .f_path = { .mnt = 0xffff931b8141c660, .dentry = 0xffff931bc3b1b900 }, .f_inode = 0xffff931b804fdb80, .f_op = 0xffffffff88287d80, .f_version = 0, .f_security = 0xffff931c0eb5ed50, .private_data = 0xffff931ba836e340, .f_ep = 0xffff931bc52eac10, .f_mapping = 0xffff931b804fdcf8, .f_wb_err = 0, .f_sb_err = 0 }

in this specific case, we should find a way to print the values since they aren't truly null. but i'm not sure about other scenarios, so IMO generally returning "null" in JSON outputs instead of empty strings would be reasonable.
@jordalgo

Yeah, I guess bpftrace's None type is equivalent to NULL in C. Not sure if we've discussed it much because we have a bunch of checks to prevent the use of the raw None type in a lot of cases. Let me think on it a bit more but printing "null" for JSON output sounds reasonable.

I guess bpftrace's None type is equivalent to NULL in C.

I didn't look, but is that true? I'd have thought C NULL in bpftrace is a pointer type with value 0x0.
I also thought there should not be any Type::none in AST past semantic analysis. To me Type::none was always tech debt for not using std::optional.
Should look into if we even expect none in types first.

Also we should make sure that whatever value we print here is a valid JSON value.


docs: Add a note about historical wheel use in requires

Summary of changes
Add a note explaining that the wheel requirement that used to be historically used in documentation was incorrect.  This also explains why it can frequently be found in existing projects, and what problems it causes.  I find myself repeatedly explaining it, so I think having a single official source would be better.
Pull Request Checklist

[ ] Changes have tests
[x] News fragment added in changelog.d/.
(See documentation for details)

Thank you very much for the contribution.


So many errors while compiling

It used to work fine, I did a factory reset on my PC and reinstalled VS2019 with the correct workloads & latest windows sdk, why does it output so many errors? Tried googling but can't find a fix.

23 Errors left, after #include
How do I fix this?

@icemotione Did you fixed it?