Detect memory leaks

Adding the usage of jest-leak-detector to the environment object. Whenever the experimental --detectLeaks flag is passed, a LeakDetector will be created for the environment object, and it will be checked later. If the result is positive, the test suite fails.
There are future plans to try improving the feedback we give to the user; I'm currently talking to someone on the V8 team see if we can do some really cool stuff parsing a heap snapshot taken immediately after. But what we currently have is just the ability of knowing if the global object got leaked.
Side note 1: please review only the last commit. This branch is put on top of the jest-leak-detector branch so that I can already use it, and the changes shown also include that other branch. Once we merge the first, I will rebase that one onto master.
Side note 2: if you are curious, some Jest tests actually leak. I haven't looked at them that much, but they mainly look related to file watchers.

Codecov Report

Merging #4895 into master will decrease coverage by 0.13%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##           master    #4895      +/-   ##
==========================================
- Coverage   60.01%   59.88%   -0.14%
==========================================
  Files         198      198
  Lines        6555     6568      +13
  Branches        4        3       -1
==========================================
- Hits         3934     3933       -1
- Misses       2621     2635      +14

Impacted Files
Coverage Δ

packages/jest-config/src/defaults.js
100% <ø> (ø)
:arrow_up:

packages/jest-config/src/index.js
23.8% <ø> (ø)
:arrow_up:

.../src/legacy_code_todo_rewrite/jest_adapter_init.js
0% <ø> (ø)
:arrow_up:

packages/jest-cli/src/test_result_helpers.js
12.9% <ø> (ø)
:arrow_up:

packages/jest-config/src/normalize.js
92.68% <ø> (ø)
:arrow_up:

packages/jest-runner/src/run_test.js
2.22% <0%> (-0.16%)
:arrow_down:

packages/jest-cli/src/test_scheduler.js
26.81% <75%> (-0.81%)
:arrow_down:

packages/jest-leak-detector/src/index.js
65% <0%> (-35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57efef0...c75cec8. Read the comment docs.

I'm almost sure the coverage report is wrong. According to it, the jest-leak-detector/src/index.js file dropped by 35%, and it reports as non-covered line 65, which is unconditionally called from line 29. How can we re-trigger the build?

Does ./jest --coverage disagree locally?

@thymikee Yeah,graceful-fs leaks because it modifies native modules. I'm working on a fix to re-inject native modules as well inside the vm context, so even if the code modifies them, they can be released at the end.
@SimenB Regarding tests, since this measures Jest leaks, the goal is to never have any test leaking; so I don't think it makes sense to make a test for that. In other words, if we create a test that leaks, we should fix what causes the leak instead of keeping it, so the test will become useless after some time.

Codecov Report

Merging #4895 into master will decrease coverage by 0.15%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #4895      +/-   ##
==========================================
- Coverage   60.36%   60.21%   -0.16%
==========================================
  Files         198      198
  Lines        6608     6620      +12
  Branches        4        4
==========================================
- Hits         3989     3986       -3
- Misses       2619     2634      +15

Impacted Files
Coverage Δ

packages/jest-config/src/index.js
23.8% <ø> (ø)
:arrow_up:

packages/jest-config/src/normalize.js
92.94% <ø> (ø)
:arrow_up:

packages/jest-cli/src/test_result_helpers.js
12.9% <ø> (ø)
:arrow_up:

.../src/legacy_code_todo_rewrite/jest_adapter_init.js
0% <ø> (ø)
:arrow_up:

packages/jest-config/src/defaults.js
100% <ø> (ø)
:arrow_up:

packages/jest-runner/src/run_test.js
2.22% <0%> (-0.16%)
:arrow_down:

packages/jest-cli/src/test_scheduler.js
25.54% <60%> (-2.07%)
:arrow_down:

packages/jest-leak-detector/src/index.js
65% <0%> (-35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4883838...11f995f. Read the comment docs.

There's definitely something wrong with the coverage shown by codecov. After executing it locally with the lcov reporter, by doing yarn jest --coverage packages/jest-leak-detector, the results show that everything is fully covered:

Running full coverage locally agrees with you - it's fully covered. Not sure what's up...
I tried to run without -i, but it just hangs infinitely on the last test

@SimenB have you tried on Node 8?

I'm using node 8.9.1

The import thing could be due to inlining requires? That would not explain why results don't match between codecov and local executions, though.

So excited to get this in to track down memory leaks in Jest.


Starting a vote once a vote completes starts a second vote

Fixed with 5ff55a0a88d8aaa0bdd4c9828f20817e5480cc52. Vote now has a cool down once the time animation completes.


How to disable colored output

Hello,
I'm using detekt via CLI and I sometimes want to disable colored output for machine readability:

Is there a good way to disable colored output via CLI?
Thank you for reading.

If it’s really a dealbreaker for you, you can use a terminal that doesn’t support colorization (Windows cmd) or deactivate this feature completely.
The value/effort ratio isn’t given for realizing configuration options here, sorry.

I understand. Thanks.


Cleanup style for buttons

What does this implement/fix?
The buttons sylesheet had a TODO part of code that was now unnecesary
since we'll rely on the button class. This also adds that class to
the delete button on the file
Does this close any currently open issues?
No

@VzqzAc I wrote this comment to remember myself to make this html/css right. On show.html.erb you can see that one button is a link and other is a real button tag. Can you make both links or buttons?

@VzqzAc are you still up for this?

Yes @MatheusRich, I'll tackle it this weekend, it has been a busy week at work

@VaqzAc My bad! I didn't want to bother. There's some nice work that you've done, so I didn't want to lose it. I'm here for any help you want to. Take your time!

Not bothering at all! Also about this PR, @MatheusRich I think it should remain as is, keeping so under the following premise:

Buttons Do Things, Links Go Places

It should remain a link I think, just with a button-ish design, also, I could change the parent id from buttons to actions in order to have a proper description of what the contet is, what do you think?
https://css-tricks.com/building-good-download-button/

@VzqzAc Thanks! Merged!


Update and rename README.md to README.mdgithub.com/community/dawnawhs…

_https://github.com/community/dawnawhsihsi

https://github.com/community/dawnawhsihsi

_https://github.com/community/dawnawhsihsi

_


Fix issue #36 and #44

This issue was related to Lua not handling coroutines iterators right, the function being recursive generated multiple coroutine iterators and they didn't resume right.
The solution is to make the first loop non-recursive and create a secondary loop where the recursive function is called.
As proposed over at #36

Thanks to @egordorichev that helped me test this over at #44
Also the linting issue is probably due to an update in Luacheck and not because of my change, I didn't even touch line 151

I ignored the linter warning in the specified line, table.unpack is not available in either Lua 5.1 nor LuaJIT, yet it's used as a fallback for unpack. This is not an error on itself, but is listed as an error by Luacheck.
An alternative solution would be to remove the line 151 entirely since it's not needed if we always work in Lua 5.1/LuaJIT

Coverage increased (+0.1%) to 25.225% when pulling 8797d0be587dcff7464c46c038b2734a19a55dcc on Positive07:patch-1 into 339cbe7b42ccd838b25bc93fd189c87cbbfd082b on MisterDA:master.

Thanks !

No problem 😃


fixed some typos.

A few things jumped out to me so I thought I'd help for the next reader.  Thx!

Thanks for the corrections!


Fix install dependencies for GitHub packages

This fixes #128.
The above issue was cause by the fact that for packages installed from GitHub no package info and hence no dependencies were provided. It was fixed by updating package info (and in consequence .bower.json file) with the data from package's bower.json.

Missing tests

Thanks


feat: add world listing and world search

This is currently being worked on. The main body of this PR will be updated as progress is made. Please feel free to provide any feedback on the information provided in this PR or the changes being made.
This PR adds the following features to go.resonite.com based on #17:

[X] World Listing
[ ] Paging Controls for World Browsing
[ ] World Search Box

Items marked as completed are in this PR.
World Listing
Currently, the look and feel of the world listing page mimics that of what you would typically see when performing a web search via a search engine. This is how the current listing looks currently:

Resolves #17

This is looking great!
I see lots of design decisions being made and that's ok. We'll likely re-unify any of those decisions after the PR.
I've been thinking about more long term structure too, but essentially for now, just continue!

Thank you for the comment, @ProbablePrime.

I see lots of design decisions being made and that's ok. We'll likely re-unify any of those decisions after the PR.

No problem! I am just showing what is possible and providing a different option for the search portion based on some examples of search results pages I looked at.

I've been thinking about more long term structure too, but essentially for now, just continue!

Page and URL structure, look and feel structure, project structure, or all of the above?

Pretty much all up.
I built this very quickly and generally like my strategy for micro sits of keeping things simple. The features we're adding make sense though. So I just want to do some cleanup once we have session and world viewing.
I've been looking for an excuse to use https://htmx.org/ too, and this might be that.
But basically anything other than React lol :D

Progress was made yesterday to complete the last main item. The "Featured Ribbon" was also added to the individual listing items. I will write a more detailed response after work.

The PR body has been updated with the rest of the information.


Add plotInset parameter to style

https://nbviewer.org/github/JetBrains/lets-plot-kotlin/blob/master/docs/examples/jupyter-notebooks/f-4.7.1/theme_plot_inset.ipynb

Hello, if this issue is still available may I please try to solve it?

Yes, you are welcome.
You need to add the inset property to the PlotCanvas custom style configuration.

I have implemented an API that is very similar to the existing one that handles margins. However, I read in [CONTRIBUTING.md] (https://github.com/Kotlin/kandy/blob/main/CONTRIBUTING.md) that all new APIs must come with documentation. Is it appropriate to add documentation in the docs folder or the examples folder in this case?


Error: TSAnalysis.get_bounded_log

Trying to run Estimation of state-space models example. Call to res = Optim.optimize(θ_unbound->fmin(θ_unbound, Y, s=12), ... returns with error TSAnalysis.get_bounded_log. Help.

I am aware there are some compatibility issues with the most up-to-date version of Julia. I suppose that you should install the LTS version and pin a few packages to make it work for now. I have been working on a major update for a while, but it is taking a bit longer than expected to release it.


Template functions in content

Hello,
I couldn't find anything in the issues or website regarding using template functions in post/page content. Is this possible?
Cheers,
Chris

Please use http://discuss.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.

Because this question is not covered in the documentation, and indeed is something that Hugo does not do, i think it should have been treated like a feature request (albeit one that probably would have been marked "won't fix").  Here is a good treatment of the question ("Is it possible to use template parameters in the content of a post with Hugo") with alternatives / workarounds on Stack Overflow:
https://stackoverflow.com/questions/42023687/how-to-use-template-parameters-in-page-content-in-hugo

Because this question is not covered in the documentation, and indeed is something that Hugo does not do, i think it should have been treated like a feature request

We do support it, and it is covered in the documentation. Use the forum for further questions, please.

Because this question is not covered in the documentation, and indeed is something that Hugo does not do, i think it should have been treated like a feature request

We do support it, and it is covered in the documentation. Use the forum for further questions, please.

Maybe a pointer to the correct spot in the documentation would be helpful then.


Passing gradient between 2 networks

Hello,
I'd like to use a LSTM in combination with a CNN as a feature extractor to classify videos. I am using mxnet -cu80 0.10.0.post2 in python 2.7.9. I have a pretrained resnet-50 which is loaded and then I chop off the final classification layer:
    symbol, arg_params, aux_params = mx.model.load_checkpoint(model_prefix, load_epoch)
    all_layers = sym.get_internals()
    fe_sym = all_layers[last_layer + '_output']
    fe_mod = mx.mod.Module(symbol=fe_sym, data_names=('data',), label_names=None, context=cnn_dev)
    data shape = [('data', (batch_size*sequence_length, 3, 224, 224 ))]
    fe_mod.bind(for_training=True, data_shapes=data_shape)
    fe_mod.init_params(arg_params=arg_params, aux_params=aux_params, allow_missing=False)
    return fe_mod

The LSTM expects an input in the NTC format, thus my forward pass first puts the entire sequence through the CNN and then  reshapes the extracted features to match the LSTM. The LSTM bind looks like this (All sequences have the same length in my model so I don't use bucketing):
    lstm_mod = mx.mod.Module(symbol=sym, context=lstm_dev, data_names=['data'], label_names=['softmax_label'])
    data_shape = [('data', (batch_size, sequence_length, feature_dim ))]
    label_shapes =[('softmax_label',(batch_size,))]
    lstm_mod.bind(for_training=True, data_shapes=data_shape, label_shapes=label_shapes, inputs_need_grad=True)

And here is the forward backward pass:
    #Feature extraction
    cnn_mod.forward(cnn_batch, is_train=True)
    cnn_output = cnn_mod.get_outputs()[0]

    #NTC layout
    features = mx.nd.reshape(cnn_output, shape=(batch_size,sequence_length,feature_dim))

    lstm_batch = mx.io.DataBatch([features], [labels])

    lstm_mod.forward(lstm_batch, is_train=True)
    lstm_mod.backward()
    lstm_mod.update()

    lstm_grad = lstm_mod.get_input_grads()[0]
    lstm_grad = mx.nd.reshape(lstm_grad, shape=(batch_size*sequence_length,feature_dim))

    cnn_mod.backward(lstm_grad)
    cnn_mod.update()

However this only works up the cnn backward pass where I get the following error which I really do not understand as the output of the CNN has exactly the same dimension as the gradient of the LSTM after reshaping and I tried to follow the dcgan example which uses a similar technique.
[21:46:24] /home/travis/build/dmlc/mxnet-distro/mxnet-build/dmlc-core/include/dmlc/logging.h:304: [21:46:24] src/ndarray/ndarray.cc:299: Check failed: from.shape() == to->shape() operands shape mismatchfrom.shape = (20,) to.shape=(20,2048)

Stack trace returned 10 entries:
[bt] (0) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x19fd3c) [0x7f636ba53d3c]
[bt] (1) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(+0xe20105) [0x7f636c6d4105]
[bt] (2) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(+0xd4c5a3) [0x7f636c6005a3]
[bt] (3) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(MXExecutorBackward+0x1c8) [0x7f636c59f108]
[bt] (4) /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c) [0x7f6392eb1f60]
[bt] (5) /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2f8) [0x7f6392eb19c8]
[bt] (6) /home/max/venv/venv_caffe/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x495) [0x7f63930c2055]
[bt] (7) /home/max/venv/venv_caffe/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x119b2) [0x7f63930c69b2]
[bt] (8) /home/max/venv/venv_caffe/bin/python(PyEval_EvalFrameEx+0x104b) [0x4c9e8b]
[bt] (9) /home/max/venv/venv_caffe/bin/python(PyEval_EvalCodeEx+0x3c9) [0x4c7a59]

Traceback (most recent call last):
  File "/opt/pycharm-2017.1.3/helpers/pydev/pydevd.py", line 1585, in <module>
    globals = debugger.run(setup['file'], None, None, is_module)
  File "/opt/pycharm-2017.1.3/helpers/pydev/pydevd.py", line 1015, in run
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/home/max/hlcv_project/mxnet_network/finetuning_sequenceCombined.py", line 304, in <module>
    main()
  File "/home/max/hlcv_project/mxnet_network/finetuning_sequenceCombined.py", line 301, in main
    train_model(model, model_dir, load_subdir, load_epoch, batch_size, gpu1, gpu2, epochs, lr)
  File "/home/max/hlcv_project/mxnet_network/finetuning_sequenceCombined.py", line 182, in train_model
    feature_dim, batch_metric, epoch_metric)
  File "/home/max/hlcv_project/mxnet_network/finetuning_sequenceCombined.py", line 82, in combined_model_forward_backward
    cnn_mod.backward(grad_cpu)
  File "/home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/module/module.py", line 559, in backward
    self._exec_group.backward(out_grads=out_grads)
  File "/home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/module/executor_group.py", line 528, in backward
    exec_.backward(out_grads=out_grads_slice)
  File "/home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/executor.py", line 217, in backward
    ndarray))
  File "/home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/base.py", line 84, in check_call
    raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: [21:46:24] src/ndarray/ndarray.cc:299: Check failed: from.shape() == to->shape() operands shape mismatchfrom.shape = (20,) to.shape=(20,2048)

Stack trace returned 10 entries:
[bt] (0) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(+0x19fd3c) [0x7f636ba53d3c]
[bt] (1) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(+0xe20105) [0x7f636c6d4105]
[bt] (2) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(+0xd4c5a3) [0x7f636c6005a3]
[bt] (3) /home/max/venv/venv_caffe/local/lib/python2.7/site-packages/mxnet/libmxnet.so(MXExecutorBackward+0x1c8) [0x7f636c59f108]
[bt] (4) /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c) [0x7f6392eb1f60]
[bt] (5) /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2f8) [0x7f6392eb19c8]
[bt] (6) /home/max/venv/venv_caffe/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x495) [0x7f63930c2055]
[bt] (7) /home/max/venv/venv_caffe/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x119b2) [0x7f63930c69b2]
[bt] (8) /home/max/venv/venv_caffe/bin/python(PyEval_EvalFrameEx+0x104b) [0x4c9e8b]
[bt] (9) /home/max/venv/venv_caffe/bin/python(PyEval_EvalCodeEx+0x3c9) [0x4c7a59]

Process finished with exit code 1

I should mention that 2048 is the feature dimension of the last resnet layer, the sequence lenght is fixed to 10 and batch_size (in this case the number of sequences per batch) is 2, so this explains the 20 and 2048. So lstm_grad is an NDArray of size 20x2048 and so is the cnn_output.
Thank's for your help,
Max

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


Add support to allow CRD conversion webhooks from outside of the cluster

Related to #3876
What this PR does / why we need it:
See #3876
Special notes for your reviewer:
Very similar to #3876, just addition for CRD conversions.
Release note:

NONE

/ok-to-test

/ok-to-test
/approve
/lgtm

/kind feature

/test pull-cert-manager-bazel


Add patch for retries

Adds a patch to allow for retries. Associated https://github.com/PrefectHQ/prefect/pull/5946

Closing as this is no longer an issue.


tools/stellar-key-gen: add tool to generate keys at command line

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
Add tool to generate keys at command line.
Why
When I'm running and testing services like webauth and recoverysigner either manually or when I'm writing Go tests I find myself needing to go to the lab to generate keys frequently. It would be helpful if there was a quick command to run to grab a new key. We might have something that does this already but I couldn't find anything. If there is I'm happy to discard this, otherwise this would be helpful.
Known limitations
This tool is pretty limited scope, it doesn't do anything else other than output a random key. This is intentional, I'm not trying to start some new massive tool suite with it.

To test the cobra.Command properly I needed to update the cobra version. I haven't reviewed the cobra changes yet to understand if that and the other dependencies are safe. I'll circle back on that before merging.

Do you mean change the way it is tested instead of updating cobra? I can do that. Although we are four years behind on the latest version of cobra. I think it could be worth considering upgrading independent of this.

Makes sense. AFAIR, you had script testing dependency updates, right?

I think it will be much simpler to make gen return a string which is later printed

@bartekn I agree. It's a little more code but simpler and back to first basics without a reader needing to know so much about Cobra mechanics. I also think upgrading Cobra to the latest version would force an upgrade of Cobra in any application that is importing code in this repo which could be painful. I've updated the PR to not require a dependency change. Thanks!


Django 1.8.2 problem

I set up a clean Django project:
Django==1.8.2
django-extensions==1.5.5
django-organizations==0.5.2
psycopg2==2.6
six==1.9.0

When I run ./manage.py migrate I get following error:
Operations to perform:
  Synchronize unmigrated apps: staticfiles, organizations, messages
  Apply all migrations: admin, auth, contenttypes, organizations, sessions
Synchronizing apps without migrations:
  Creating tables...
    Creating table organizations_organization
    Creating table organizations_organizationuser
    Creating table organizations_organizationowner
    Running deferred SQL...
Traceback (most recent call last):
  File "/Users/developer/Django/project/lib/python3.4/site-packages/django/db/backends/utils.py", line 62, in execute
    return self.cursor.execute(sql)
psycopg2.ProgrammingError: relation "auth_user" does not exist

It's similar in MySQL.

The migrations were not being loaded as the migrations module included build artifacts from previous versions. Tested latest version with PostgreSQL and the migrations run cleanly. Thank you for reporting this.

Forgot - it's in version 0.5.3 now.

Just tested in Postgres and MySQL ... works fine.


Write build logs to staging-failed

We just put a dummy file there. It would be nice if it contained the build logs instead so it''s easy to see why a package ended up there.

Alternative: write the URL of the github actions job there

Alternative: write the URL of the github actions job there


geometry: 1.11.8-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository geometry to 1.11.8-0:

upstream repository: https://github.com/ros/geometry.git
release repository: https://github.com/ros-gbp/geometry-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 1.11.7-0

eigen_conversions
* eigen_conversions: Add conversions for Eigen::Isometry3d
* Contributors: Maarten de Vries

geometry

No changes

kdl_conversions

No changes

tf
* Update assertQuaternionValid to check for NaNs
* Remove outdated manifest loading in python files
* update unit tests to catch https://github.com/ros/geometry_experimental/issues/102
* Contributors: Chris Mansley, Michael Hwang, Tully Foote

tf_conversions
* tf_conversions: Add conversion functions for Eigen::Isometry3d
* Remove outdated manifest loading in python files
* Contributors: Maarten de Vries, Michael Hwang

hold for coordinated release


Add Rail Pool

This PR introduces a new genre: Rail Pool by Menderbug.
For some example puzzles, check out Menderbug's twitter: https://twitter.com/menderbug/status/1521766920453771265

Rules: Draw a single orthogonal, non-intersecting loop that visits every cell. If a region contains any numbers, those numbers are the set of lengths of all line segments contained fully or partially within that region (for segments contained partially in the region, the number still refers to the total length of the segment).
In other words, all line segments have to have one of the given lengths, and each given length matches at least one line segment.
It's a very young genre, but I think it shows great promise, and having a specific player for it might help it reach a wider audience.
This is my first time working with pzprjs; I've mostly copy-pasted stuff from several different genres, not always 100% understanding everything. In addition, there are some extra genre-specific problems that I'm not sure how to solve (see below).
TODO:

[x] Encoding/Decoding (i could use some help from @x-sheep)
[x] Add rules
[ ] Better wording on error messages
[ ] Japanese translations of everything
[ ] Tests
[ ] Fix input?

This genre's cluing has two particularities I haven't seen together on any other pzprjs genre: each region might contain up to 2*N clues (with N being the size of the region), and each clue can be a number up to S (with S being the board size).
Since the clues are per-region, I originally took yajilin-regions as a base. However, having all the clues cramped into a single cell wont visually work in the general case, due to the first particularity. In addition, Menderbug himself prefers being able to put the clues anywhere (for aesthetics). Switching to tapa-style clues allows placing up to 4*N clues per region, which solves the first problem.
However, multiple clues per region make it hard to input big numbers: both "1, 2" and "12" might be valid inputs. To solve this, clues are artifically limited to be between 1 & 9. For real-world puzzles I don't think it's a problem, but still seems like an inelegant solution.

Thanks to you for maintaining this repo!
I hadn't noticed that Lohkous has the same clues, it could have saved me quite a bit of time 😓
Both Lohkous and Rail Loop allow arbitrarily many clues per cell, with clues being arbitrarily big. However, Lohkous encoding is limited to arbitrarily many numbers in the 0-9 range. I think this could be solved by using a-k as single digits signaling that the number still goes on (so 5b78abc4 would decode to 5, 27, 8, 1234). I see two options:

Reuse Lohkous's encoding and decoding (maybe moving them to a common file?)
Use the other future-proof encoding. In this case, would there be a way to include it in Lohkous without breaking existing puzzles?
In any case, I will change the current input style to the one Lohkous for consistency

I think having a Lohkous puzzle with a number above 9 are even less likely than a Rail Pool puzzle with a number above 9. It's safest to leave the Lohkous encoding as-is.

Everything ready for review!

Alright, this looks good to me. Since I'd like to not release new genres too closely together, I'm planning to merge this on the 24th (one week after Statue Park).
The only thing this type is missing is an entry in rules.en.yaml, but I can also do this if required. Unlike with the failcodes, it's preferred to not touch rules.ja.yaml unless there's an actual translation available.


Remove panopticon registration.

This was done to preserve the base URL, which is
now handled via publishing special routes to the
publishing API.
This depends on https://github.gds/gds/alphagov-deployment/pull/1043 having been merged.

Looks fine, except that the tests failed.  Looks like you need to upgrade uglifier.

@rboulton upgraded.


Merged yaml, create_doc.sh and install.sh to master

documentation will be deployed to /stable and /dev after commit.
Therefore, circle_install and push_doc isn't necessary.

It is already implemented in the development branch

Merged in #183


Fixed Typo and Grammatical errorrs

Fixed a typo and several grammatical errors

Summary

Ticket Link

Hello @Sayanta66,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@justinegeffen @cwarnermm is this PR available to merge?

@justinegeffen @cwarnermm is this PR available to merge?

Unfortunately it's not possible to merge this PR as the originating repository has been deleted.


[Youtube] Support stats w/o dislikes

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @pzygielo!

  Generated by :no_entry_sign: dangerJS against f74e75575019e5acf5308c5df1505f5d396291df

Replaced with

#7410

combined with

#7409


setup.py: fix python_requires

Fix python_requires to specify a valid version.  Apparently, combining
>= and .* is disallowed, and I'm pretty sure 'just' >=3.5 means
the same.
To reproduce the problem, you can:
$ pip install nltk distlib
$ python -c "import distlib.database; \
  distlib.database.DistributionPath().get_distribution('nltk')"

which yields a (not very readable) error of:
ValueError: '.*' not allowed for '>=' constraints

Precisely. Thanks @mgorny


ADALM-PLUTO playbook

Many thanks for posting your ADALM-PLUTO notebook.  I have a very similar setup (OpenSUSE, etc.) and I am seeing exactly the same issues you had.  I've already ordered my hub.  I hope that gets this thing working since I've been wanting to tinker at home on SDR for a while.

Glad to hear it! I just got 2 new Pluto boxes from the second butch. Will start playing with latest OpenSUSE Tumbleweed and SDR once have some more time.


Laravel Mix dependency not installing correctly via NPM on Vagrant Box on Windows 10

Description:
Hi, there. I'm having issues getting NPM to install Laravel Mix dependencies specifically within a Vagrant Box in Windows.
By having
"laravel-mix": "^1.0", and "cross-env": "^5.0.5",
in a brand new project's package.json causes issues when running any sort of npm install (I tried, sudo, --no-bin-links, etc). I did this via a Vagrant Box I had built by using PuPHPet. I can confirm all works as expected on our Mac OS, and even Windows natively.
Natively in WIndows, we can install latest Node and NPM (tested for Node 8.4.0 and NPM 5.3.0), run npm install, run npm install -g cross-env, and then we are able to use the Mix NPM scripts (npm run (prod|dev|watch))
Unfortunately, we develop in a Vagrant Box on Windows across a few computers.
The fsevents module seems to cause some issues. I also ran into some etxtbsy text file is busy issues too.
I had our senior dev confirm this issue we are having across multiple windows computers.
Steps To Reproduce:

Go to puphpet.com, create an archive for your Vagrant built (with composer, node, etc)
Extract your build, navigate to it, run vagrant up
SSH into your build vagrant ssh and install a Laravel project via composer
In your package.json, in devDependencies, add:

"devDependencies": {
    "cross-env": "^5.0.5",
    "jquery": "^3.2.1",
    "laravel-mix": "^1.0",
  }

run npm install

This is potentially a npm issue rather than Laravel Mix issue. Npm v5 has problems with installing packages and dependencies. Try using yarn?

I haven't yet, but I certainly can try. I'll keep you posted

Well, Yarn is an NPM tool.   GitBash on windows. rather than Vagrant

Same, fresh install of laravel broken.


Coordinate Transformations

This PR implements all coordinate transformation methods used in GeoTIFF:

Tie Point and Pixel Scale
Affine Transform
Multiple Tie Points (Ground Control Points)

In addition, the implementation considers the raster type (RasterPixelIsArea or RasterPixelIsPoint) to determine the origin of the raster space coordinate system.
The Tie Point and Pixel Scale and Affine Transform methods are relatively straightforward. The Multiple Tie Points transformation roughly works as follows:

Create a Delaunay triangulation of the tie points in raster space
Apply the resulting triangulation to the tie points in model space
When doing coordinate transformations, use the containing triangle of a coordinate to determine the three points to be used for the transformation
Determine the relative position of the coordinate within the triangle in the model space coordinate system
Use the relative position to linearly interpolate the coordinate within the corresponding triangle in the raster space coordinate system

@weiji14 please have a look.

I'm not familiar with how GCPs work, so if @weiji14 has time to review I'll defer to him

Thanks @weiji14 for your comments. I've been busy the last two weeks, but hopefully, I'll find time to address the remaining issues next week.

@weiji14 Let me know if you want any further changes; otherwise, I will merge this PR.

Let's go ahead and merge, thanks for adding the extra docs and bug fixes!


Image file attribute is missing randomly

Hi guys,
we have a strange bug. Our factory looks a like this
FactoryGirl.define do

  factory :sequence, :class => Sequence do
    new_image { File.new("#{Rails.root}/app/assets/images/fav.png") }
    old_image { File.new("#{Rails.root}/app/assets/images/fav.png") }

  end
end

and our spec file looks similar to this
  before do
    @seq = FactoryGirl.create(:sequence)
  end

  it 'test 1' do
  end

  it 'test 2' do
  end

  it 'test 3' do
  end

new_image and old_image are both mandatory. 'test1' and 'test2' worked fine but in 'test 3' the following error got raised
ActiveRecord::RecordInvalid: Validation failed: New image can't be blank

We put some puts statements in the new_image {} block and through this we could ensure that the image exists and that a file image object was returned. But somehow factory girl doesn't assign it to the new sequence object and then this error is raised by the model validator.
It is important to note that this error happens highly random. Maybe every fifth run and it also happens in different tests. It doesn't matter if it is a capybara test, request test or controller test. This is just an example spec where we just experienced this error again.

Hi,  I am struggling to replicate your issue, and have a few questions.

Are you still seeing this problem?(I know its been a few months)
What versions of Ruby, Rails, RSpec and Factory Girl are you using?

Thanks
Andrew

Hi Andrew,
thanks for replying. We don't have this problem anymore since we changed the two attributes to use two different image files.
It would be still interesting why this sometimes happened. I understand that it is very difficult to reproduce. It was the same for us too. Wie use
Ruby 2.2.0
rspec 3.1.0
factory_girl 4.5.0
Johannes

Hi,    I spent a few hours this morning trying to reproduce this issue, without much success.  Given that this does not appear to be a problem for the user any longer. I believe its safe to close this defect as unable to reproduce. It can always be reopened, if the problem manifests itself again in the future.

Ok, no problem.


Functional?

Hi! I just wanted to let you know that there are some big auction communities revolving around Enjin Coin, a cryptocurrency that allows the creation of virtual tokens, and we could use this bot if we understood how to use it.
I'm thinking of t.me/EnjinAuctionHouse
Thanks!

Hello Diego,
your idea seem interesting, I wanted to take resume the project since a while so this could be the occasion. If you use slack I can send an invitation to talk about this topic there.

Hi Fabrizio,
Thanks, I do have Slack, so feel free to invite me and we can see if it's
implementable and good!
El sáb., 30 mar. 2019 a las 10:25, Fabrizio Guglielmino (<
<EMAIL_ADDRESS>escribió:

Closed #1 https://github.com/guglielmino/astone-bot/issues/1.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/guglielmino/astone-bot/issues/1#event-2240962928, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ao5ws3f8-dQGacFwpqeReW9BRWptU34aks5vbzt9gaJpZM4cTeYi
.

Give me your email address  ...


Inject context and refactor interface

Job context is now provided to the operation using a Context object. Also, the project was becoming cluttered so I reorganized it into 3 directories and two files.

SimulationService.jl - remains the same. mostly managed by TA4
Settings.jl - remains the same as well. managed by julia.
service - this is where TA4 concentrates its work on scheduling, handling api requests, etc.
contracts - handshake between julia and TA4. valid inputs for operations are defined here.
operations - this defines the operations available to the service. Currently, the contract looks at the functions exported from operations/Operations.jl and automatically serves thoughs using the calls endpoint.

Codecov Report

Merging #35 (15e7715) into main (d41d2eb) will increase coverage by 0.88%.
The diff coverage is 40.00%.

:exclamation: Current head 15e7715 differs from pull request most recent head baee191. Consider uploading reports for the commit baee191 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   17.29%   18.18%   +0.88%
==========================================
  Files           8       11       +3
  Lines         185      198      +13
==========================================
+ Hits           32       36       +4
- Misses        153      162       +9

Impacted Files
Coverage Δ

src/SimulationService.jl
0.00% <0.00%> (ø)

src/contracts/ProblemInputs.jl
0.00% <0.00%> (ø)

src/contracts/SystemInputs.jl
0.00% <0.00%> (ø)

src/service/ArgIO.jl
0.00% <0.00%> (ø)

src/service/AssetManager.jl
0.00% <0.00%> (ø)

src/service/Queuing.jl
0.00% <ø> (ø)

src/contracts/Interface.jl
40.00% <40.00%> (ø)

src/operations/Operations.jl
65.21% <65.21%> (ø)

src/operations/Utils.jl
94.44% <94.44%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Svelte REPL PermaSharing.

There have been issues raised about sharing REPL contents. Currently REPL sharing relies on the author ideally forking their REPL and not deleting it or modifying it at some point in future.
#339 Encapsulated URL Sharing
#113 Changing content if not forked
I got the idea from Shawn Wang @swyx, where he was talking about using the URL for state management. I thought this might be a great way to share Svelte REPL code without server storage requirements, and the content would be permanent rather than relying on author keeping the code unmodified and available. In fact it would mean less server requirements as the forking would be less. It could also be possible to run the generated link through a shortener service to make it's length more reasonable.  However this may limit the permanence factor relying on another service.
The general idea would be during onMount of the REPL, it would look for data and name params in the URL, and if present loads that data instead of the stock hello world.
To give live illustration of the premise is tough. This is because services such as the Svelte REPL itself, Stackblitz etc make it hard to see/change the URL. The code represents a bare bones proof of concept, and talking point on whether is worthwhile to pursue a PR.
If you wanted to run the code you can fork it here
https://github.com/cycle4passion/https---github.com-cycle4passion-svelte-repl-permashare
but you can get the idea with this.

On my quest to find the source code for the Svelte5 REPL I ended up here. I think this issue can be closed now? https://svelte-5-preview.vercel.app/ stores state in the hash.
I'd be glad for any pointers where I can find the current hash-based implementation.

https://svelte-5-preview.vercel.app/ is temporary and will go away when Svelte 5 is launched

There's an open question about what the nature of the more permanent REPL for Svelte 5 will be. There are definitely benefits to encoding the whole thing in the URL (permalinks, no database), but the Svelte 4 mechanism also has benefits. If we could come up with a good way to combine these two (maybe default to automatically creating hash fragment permalinks, but let the user save/overwrite a given version in the database?), then that would be nice.

This exists on the new site


[UIU - 2852] - Implemented permission required exception response

Purpose

https://issues.folio.org/browse/UIU-2852
Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all the appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Did you modify code to call some additional endpoints?

[ ] If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Example for Missing permission exception case
{
  "errors": [
    {
      "message": "Access for user 'ss_admin' (b82b46b6-9a6e-46f0-b986-5c643d9ba036) requires permission: users.item.get",
      "type": "-1",
      "code": "PERMISSION_ERROR"
    }
  ]
}

some temporarily changes https://github.com/folio-org/mod-consortia/pull/35/commits/794c6fcda8406da0b1becbd7a1150fc3233715ae


changed round icon

i updated the testnet app icon

Verified resolved in latest build.

closes https://github.com/decred/dcrandroid/issues/29


Remove no personal information checkbox on request description for Personal requests

As an Intake analyst
I want to be able to include personal information in request descriptions for personal requests
so that the request is accurately captured and the Ministry can locate the records requested

Assumptions & Scope

Request descriptions for Personal requests will often contain personal information as this is required to locate the records requested
Ministry users will need to see the full request description complete with personal information in order to fulfill a Personal request, and any subsequent changes to the request description in the Description History
Request descriptions for Personal requests are not published so there is no need to protect personal information in the same way as General requests
The "Description contains NO Personal Information" checkbox should continue to function as is for General requests

What is IN scope?

Removing the "Description contains NO Personal Information" checkbox for Personal requests only

What is NOT in scope?
Acceptance Criteria
Scenario 1: Personal request from webform in Unopened state

GIVEN an Intake analyst is logged in
WHEN the analyst clicks on a Personal request in Unopened state
THEN the "Description contains NO Personal Information" will not be visible
AND the analyst will be able to save the request once all other mandatory fields have been inputted

Scenario 2: Use Add Request button for Personal request

GIVEN an Intake analyst has clicked the Add Request button to create a new request
WHEN the analyst selects Personal as the request type
THEN the "Description contains NO Personal Information" will no longer be visible
AND the analyst will be able to save the request once all other mandatory fields have been inputted

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

@lmullane @m-prodan @mpilchar @JHarrietha-AOT please review when you have time and let me know your thoughts

Validation will be needed. Estimate of 3

@arielleandrews as per discussion ministry users will now be able to see full history for personal request descriptions

All AC passed - nice job @nkan-aot


Add Model Component section in Developer Guide

This pull-request adds the following sections:

[added to the Design section]

a Class Diagram providing an overview of the Model, StudentBook, LessonBook classes,

the classes associated with them and the interfaces that they implement

[added to the Implementation section]

an overview of how the addlesson command was implemented

Fixes #119
Fixes #123

Codecov Report

Merging #96 (ffa6913) into master (af29099) will not change coverage.
The diff coverage is 72.50%.

@@            Coverage Diff            @@
##             master      #96   +/-   ##
=========================================
  Coverage     53.09%   53.09%
  Complexity      512      512
=========================================
  Files           108      108
  Lines          2228     2228
  Branches        240      240
=========================================
  Hits           1183     1183
  Misses          965      965
  Partials         80       80

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/logic/LogicManager.java
66.66% <ø> (ø)

src/main/java/seedu/address/model/LessonBook.java
46.42% <ø> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
10.34% <0.00%> (ø)

...a/seedu/address/storage/JsonLessonBookStorage.java
47.61% <ø> (ø)

...du/address/storage/JsonSerializableLessonBook.java
26.66% <ø> (ø)

src/main/java/seedu/address/ui/LessonCard.java
0.00% <ø> (ø)

src/main/java/seedu/address/ui/StudentCard.java
0.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
67.05% <78.57%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af29099...ffa6913. Read the comment docs.

wym man it's 100% solid documentation top of the line stuff no kidding 😤

@jamesyeap ok buddy 👌


随便聊聊 - Distiny的博客 | 且听风吟

https://distiny-cool.github.io/2017/02/14/随便聊聊/
Actions speak louder than words.

评论实验终于成功了！！！


[Playlist] Make the playlist name editable

The playlist name should be editable

changePlaylistName in spotifySource.js is where you should check for api calls btw!

I have a low effort fix for this (changes name in model every letter you write) over at branch persist-firebase as I needed to check if firebase updated correctly. Note that it does not update the name of the actual spotify-list if the user has added it to their account (the call Julia mentioned)

Diggermodel fn also only update the name that is stored in the current generated object, not the name that is stored in the prevGeneratedList which also needs to be fixed


Make NetworkAgentRegistry Transient

For New Contributors
How to contribute
Description

Enforce only using singleton in patches. In patches allow for null singltons.
Intended Design

N/A
Location

N/A
Related Issues

N/A
Requirements

N/A
Additional information

N/A
Definition of Done

[ ] Class level comments exist for all new classes.
[ ] XUnit tests exist for every method that does not require the game to be ran.

Only used in patches and special cases now. Having this singleton pattern allows for the faster processing of some patches so we have decided to keep this functionality.


sky.exr

The "fill" pattern y. is causing a file called sky.exr to be treated as a sequence.

This looks to be resolved as of the 1.0.0 release


Update README.md

Added README title, as well as list of publications and talks.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


String to Curie method

At the moment you have methods for going from Curie to IRI, but there is not method from going from a string to a curie. So, I can use this for parsing, but not for rendering!
Would it be possible to add this?

I think you meant for going from a Curie to a string, since you mentioned rendering ... if so, I've fixed this and published a new release (0.0.6).
If not, then please re-open with more detail.

Sorry, if I wasn't clear. Given a string, I need to generate a curie.  In memory I am storing an ontology with entities stored as an IRI (since the IRI is the thing, while the curie is an feature of the serialisation). When I serialize, I need to go back from a string to a curie, based on a prefix mapper of some sort.
I can send a PR if you like!

A PR sounds great!

This was resolved by your pull request #3, right?

Yes!


Cannot find header files when editing ASIO in Visual Studio Code

Clangd cannot find header files in the folder asio/include when editing asio.
Output of clangd --version:clangd version 11.0.0
Editor/LSP plugin:Visual Studio Code
Operating system:macOS 11.1 Big Sur

Do you have a compilation database telling clangd to look at asio/include as an include directory? see https://clangd.llvm.org/installation.html#project-setup for details. If you believe you've set your project correctly, please include clangd logs so that we can help more, see https://clangd.llvm.org/troubleshooting.html#gathering-logs for gathering logs.


HDDS-1332. Add some logging for flaky test testStartStopDatanodeState…

…Machine. Contributed by Arpit Agarwal.
Also remove an overaggressive clause in DatanodeStateMachine#isDaemonStopped,
Change-Id: I4f9dc6aeff7f4502956d160e35f2c4caadccb246

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1076
trunk passed

+1
compile
40
trunk passed

+1
checkstyle
18
trunk passed

+1
mvnsite
34
trunk passed

+1
shadedclient
784
branch has no errors when building and testing our client artifacts.

+1
findbugs
51
trunk passed

+1
javadoc
28
trunk passed

_ Patch Compile Tests _

+1
mvninstall
36
the patch passed

+1
compile
26
the patch passed

+1
javac
26
the patch passed

-0
checkstyle
14
hadoop-hdds/container-service: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
29
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
808
patch has no errors when building and testing our client artifacts.

+1
findbugs
54
the patch passed

+1
javadoc
25
the patch passed

_ Other Tests _

-1
unit
81
container-service in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

3257

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.TestDatanodeStateMachine

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-649/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/649

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 5e9db77ed771 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / fe29b39

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-649/1/artifact/out/diff-checkstyle-hadoop-hdds_container-service.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-649/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-649/1/testReport/

Max. process+thread count
403 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service U: hadoop-hdds/container-service

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-649/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


Tenent-Level Analytics: "Get Insights" Error

Hello,
The "Get Insights" feature returns a window stating a PPU is required.
The user is a Power BI Admin with PPU license and still receives this message.
When clicking "Try Free" an error message is returned instead. "Sorry, we are unable to start trial at this time."

Is this feature meant to be available for these reports?
If so, is there any reason why Users cannot use this feature when they have full Power Platform Admin Access & are Power BI PPU?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c237709a-db62-a57b-838c-5ee6c004bb55
Version Independent ID: 3157a6e5-9a05-74b1-12b0-cd563817d327
Content: Preview: Tenant-level analytics - Power Platform
Content Source: power-platform/admin/tenant-level-analytics.md
Service: power-platform
Sub-service: admin
GitHub Login: @TJVass
Microsoft Alias: tjvass

@NathanMTMSFT
Sorry for the delayed response. For product-related feedback, visit https://aka.ms/ppac-ideas. If this issue still exists, please contact support: https://powerapps.microsoft.com/support/


Remove old code

Fixes #718 Remove VS 2013 support
Fixes #720 Remove old code from source tree
Adds support for VS "15" and removes support for VS 2010, 2012 and 2013.
Don't look at the diff for this - it will likely crash any browser. Instead, add .diff to the URL, save it as plain text, then open it in something that understands diff format.

Alternatively, pull the changes and compare using your favourite git diff tool:
git checkout -b zooba-remove-old-code master
git pull https://github.com/zooba/PTVS.git remove-old-code

<IP_ADDRESS>5
<IP_ADDRESS>

Is there a reason for the version number difference with Dev15?

In Debugger.csproj we used to default to 11 with old version of 4.0.  Now it is 14 with old version 14.  This is probably fine but I am not entirely sure where OldToolsVersion is all used?

In DebuggerHelper.vcxproj
<When Condition=" '$(VisualStudioVersion)'=='15.0'  Or '$(TargetVisualStudioVersion)'=='VS145' ">
This is the only place I found VS145 alongside 15.0. Shouldn't we have VS150 here?  If there is something in VS145 we should still call out VS150.

The VS145 was a typo.
I'm not sure where OldToolsVersion is used either, though I suspect it's a VS thing for undoing upgrades. That whole block is there to avoid popups when opening the projects, so I'm cautious about removing anything even if it appears unused.
The assembly version is different because the assemblies may be incompatible.

I noticed the HPC stuff all stripped out.  Is that unsupported right now?  It just wasn't 100% clear it is necessary with all the other changes being about stripping out dead code. Same question for the diff differences for Repl (I think your merge from master might resolve that) and the removal of the smart tag provider.
In CloudServiceWizard +#elif DEV15 const string AzureToolsDownload = "about:blank";.  We could probably make this point to the dev14 go.msft.com link but I am alright with blank.  Do we know that the download will be different?  the dev11 and dev12 ones were, but I don't know the compatibility story now vs then.

Reading your previous comment about compatibility is a good reason to keep about:blank.
:+1: LGTM


I can't install openspiel

when I was installing openspiel，some errors raise：
ERROR: Command errored out with exit status 1: /home/mlj/venv/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-wfyikrao/open-spiel_27b15f01be044bb49384b9b6a08727a8/setup.py'"'"'; file='"'"'/tmp/pip-install-wfyikrao/open-spiel_27b15f01be044bb49384b9b6a08727a8/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(file) if os.path.exists(file) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /tmp/pip-record-wqmxrk1f/install-record.txt --single-version-externally-managed --compile --install-headers /home/mlj/venv/include/site/python3.8/open-spiel Check the logs for full command output.

Are you installing via pip?

Did you follow the instructions here? https://github.com/deepmind/open_spiel/blob/master/docs/install.md#python-only-installation-via-pip
If so can you please show the versions of cmake and clang++ by running the commands in the installation instructions and post them here?

Did you follow the instructions here? https://github.com/deepmind/open_spiel/blob/master/docs/install.md#python-only-installation-via-pip
If so can you please show the versions of cmake and clang++ by running the commands in the installation instructions and post them here?

Yes，I follow the instruction.
camke=3.12.2
clang++=10.0.0
ubuntu=18.04.2
python=3.8.9

You have the python dev files? Does python3-config --help run for you?
If so, maybe try outside of the virtual environment? i.e. try skipping these two lines:
virtualenv -p python3 venv
source venv/bin/activate

You have the python dev files? Does python3-config --help run for you?
If so, maybe try outside of the virtual environment? i.e. try skipping these two lines:
virtualenv -p python3 venv
source venv/bin/activate

Edit: you ran the install/upgrade to setuptools command, right?

Thank you, lanctot. I have solved this problem by updating clang7 to clang10 then following the instructions again.

Great!


What did you expect to see?
success fetch the image
What did you see instead?

rkt fetch --insecure-options=image,http --no-store docker://localhost:5000/tgres:v0.2.11

Flag --no-store has been deprecated, please use --pull-policy=update
Downloading sha256:5d5ea212b70 [=============================] 17.1 MB / 17.1 MB
panic: runtime error: index out of range

goroutine 1 [running, locked to thread]:
panic(0xbe3de0, 0xc4200140f0)
	/nix/store/w5fc8874fj71wy65nb54p4k39743vz4a-go-1.7.4/share/go/src/runtime/panic.go:500 +0x1a1
github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal.GenerateManifestV22(0xc4201586c0, 0x5c, 0xc42014d3b0, 0x47, 0xc42014cf50, 0x47, 0xc420256fa0, 0xc42038e070, 0x0, 0x0, ...)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/internal.go:396 +0xe2e
github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal.GenerateACI22TopLayer(0xc420256fa0, 0xc42014d3b0, 0x47, 0xc42038e070, 0xc42014cf50, 0x47, 0xc4204961c0, 0x3e, 0xc4201421e0, 0x0, ...)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/internal.go:119 +0x258
github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/backend/repository.(*RepositoryBackend).buildACIV22(0xc4201ae580, 0xc42036e220, 0x1, 0x1, 0xc42014d3b0, 0x47, 0xc420256fa0, 0xc4204961c0, 0x3e, 0xc420478510, ...)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/backend/repository/repository2.go:272 +0xfbe
github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/backend/repository.(*RepositoryBackend).buildACIV2(0xc4201ae580, 0xc42036e220, 0x1, 0x1, 0xc42014d3b0, 0x47, 0xc420256fa0, 0xc4204961c0, 0x3e, 0xc420478510, ...)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/backend/repository/repository2.go:70 +0x10c
github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/backend/repository.(*RepositoryBackend).BuildACI(0xc4201ae580, 0xc42036e220, 0x1, 0x1, 0xc42014d3b0, 0x47, 0xc420256fa0, 0xc4204961c0, 0x3e, 0xc420478510, ...)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/internal/backend/repository/repository.go:156 +0x24b
github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib.(*converter).convert(0xc4204d1448, 0x0, 0x0, 0x0, 0x0, 0x0)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/docker2aci.go:176 +0x34b
github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib.ConvertRemoteRepo(0xc420478579, 0x1c, 0x1, 0xc420478510, 0x29, 0xc420478510, 0x29, 0x0, 0x0, 0x0, ...)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/appc/docker2aci/lib/docker2aci.go:105 +0x500
github.com/coreos/rkt/rkt/image.(*dockerFetcher).fetch(0xc4204d1880, 0xc4203a0100, 0x0, 0x0, 0x0)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/dockerfetcher.go:118 +0x285
github.com/coreos/rkt/rkt/image.(*dockerFetcher).fetchImageFrom(0xc4204d1880, 0xc4203a0100, 0xc420256f00, 0x0, 0x0, 0x0, 0x0)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/dockerfetcher.go:68 +0x159
github.com/coreos/rkt/rkt/image.(*dockerFetcher).Hash(0xc4204d1880, 0xc4203a0100, 0x1b, 0xc4204d1860, 0x1, 0x1)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/dockerfetcher.go:58 +0xfc
github.com/coreos/rkt/rkt/image.(*Fetcher).maybeFetchDockerURLFromRemote(0xc4204d1c00, 0xc4203a0100, 0x0, 0x0, 0x0, 0xc4204726f0)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:268 +0x153
github.com/coreos/rkt/rkt/image.(*Fetcher).fetchSingleImageByDockerURL(0xc4204d1c00, 0xc42047c200, 0x5bfb64, 0xc420256550, 0x1277e40, 0xc420014330)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:229 +0xfa
github.com/coreos/rkt/rkt/image.(*Fetcher).fetchSingleImage(0xc4204d1c00, 0xc4204d1a50, 0xc4204d1a10, 0xc4204765a0, 0xc4204765a0, 0xc42044e038, 0x0)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:178 +0x235
github.com/coreos/rkt/rkt/image.(*Fetcher).FetchImage(0xc4204d1c00, 0x127c8c0, 0xc42047c200, 0x7fffbd352167, 0x25, 0x0, 0x0, 0xc420476580, 0x1f, 0xc4204d1b58)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:74 +0x14e
github.com/coreos/rkt/rkt/image.(*Fetcher).FetchImages.func1(0xc420242180, 0x0, 0x15)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:53 +0xa3
github.com/coreos/rkt/common/apps.(*Apps).Walk(0x12b3d60, 0xc4204d1b48, 0xc42047a010, 0x10)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/common/apps/apps.go:169 +0x62
github.com/coreos/rkt/rkt/image.(*Fetcher).FetchImages(0xc4204d1c00, 0x12b3d60, 0x0, 0xc420472000)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:59 +0x54
main.runFetch(0x12677c0, 0xc42044b0e0, 0x1, 0x3, 0x0)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/fetch.go:130 +0x331
main.runWrapper.func1(0x12677c0, 0xc42044b0e0, 0x1, 0x3)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/rkt.go:242 +0xe8
github.com/coreos/rkt/vendor/github.com/spf13/cobra.(*Command).execute(0x12677c0, 0xc42044b020, 0x3, 0x3, 0x12677c0, 0xc42044b020)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/spf13/cobra/command.go:565 +0x411
github.com/coreos/rkt/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x12657c0, 0x0, 0x0, 0x0)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/spf13/cobra/command.go:651 +0x367
github.com/coreos/rkt/vendor/github.com/spf13/cobra.(*Command).Execute(0x12657c0, 0xcb41c9, 0xc420000340)
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/vendor/github.com/spf13/cobra/command.go:610 +0x2b
main.main()
	/build/rkt-v1.25.0-src/build-rkt-1.25.0/gopath/src/github.com/coreos/rkt/rkt/main.go:32 +0x93

This seems to be due to a valueless environmental flag PG_PASSWORD. The runtime panic can be easily worked around by explicitely setting it to some value (including an empty string, i.e. PG_PASSWORD=. I'm not sure if this allowed by docker spec, but docker2aci should react more gently in this case here. We should either handle it as an implicit empty value or just filter out the entry.

According to the spec: Entries are in the format of VARNAME="var value". So it looks like this configuration is out of spec and whatever tool produced this should be fixed.
That said, @yuchangyuan is your config trying to set an empty value on purpose?

That's my fault, I generate the image with dockerTool in NixOS, and try to generate the image with env var PG_PASSWORD without default value(I want a placeholder), below is the code snippet(unrelated lines are ommited) that create the problem.

with pkgs.dockerTools; {
  tgres = buildImage {
      Env = [
        "PG_PASSWORD"
        "PG_USER=tgres"
        "PG_HOST=localhost"
      ];
    };
  };
}

I hope that docker2aci or rkt can generate an error message than just crash, which hard to understand for anyone not familiar with source code.

PS, this image is OK for docker.

And what is the result of using this image? Is the variable set to an empty value or just silently dropped?

Just silently dropped.

@yuchangyuan thanks for the feedback, I think we can follow the same behavior.
For anybody interested, this should be an easy first contribution. The code below in docker2aci needs to be adjusted to check for len(parts) and skip the entry if it is not equal to 2:
https://github.com/appc/docker2aci/blob/9cec4de013fd566dd30e789f33bb5f85723ede85/lib/internal/internal.go#L395-L396

Is this still Open? I see a merged PR that points to this issue.

Is this still Open? I see a merged PR that points to this issue.

https://github.com/appc/docker2aci/pull/249 was included in v0.17.0 of docker2aci and we vendor v0.17.1 so we can close this.
Thanks!

I retroactively added a milestone for reference, the fix has been released as part of rkt 1.29.0.


Inheritance support

One thing: Please try to write commit messages in the imperative mode, so in this case something like "add support for inheritance". This will improve readability, and makes it easier to review and view the history of this project.
Apart from that: great work, I really appreciate the effort!

I added a pre and post signal to the bulk create and some intermediate methods to give more control over what the created M2M table looks like


Install issue

Hi,
I want to try prez-ui en have downloaded the sources.
Followed by:
npm install
npm run build
gives:
E:\prez\prez-ui-3.5.0>npm run build

<EMAIL_ADDRESS>build E:\prez\prez-ui-3.5.0
run-p type-check build-only; shx cp dist/index.html dist/404.html

ERROR: Task not found: "build-only;", shx", cp", dist/index.html", dist/404.html"
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: run-p type-check build-only; shx cp dist/index.html dist/404.html
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\richa\AppData\Roaming\npm-cache_logs\2023-08-11T13_27_23_417Z-debug.log
What is going wrong?
regards, Richard

Thanks for the report @RichDijk. I can see you're running the build task on Windows. I just tested it on my Windows machine and can confirm the issue. It works fine on macOS and Linux.
The issue is on Windows, it interprets build-only; with the semicolon as part of the command, rather than as a separator for commands like on macOS and Linux.
I've created a PR to fix it here https://github.com/RDFLib/prez-ui/pull/92.
In the meantime, you can edit your local copy of package.json and make the following change.
{
    "name": "prez-ui",
    "version": "3.0.1",
    "private": true,
    "scripts": {
        "dev": "vite",
--        "build": "run-p type-check build-only; shx cp dist/index.html dist/404.html",
++        "build": "run-p type-check build-only && shx cp dist/index.html dist/404.html",
        "preview": "vite preview",
        "test:unit": "vitest --environment jsdom --root src/",
        "build-only": "vite build",
        "type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
    },
    "dependencies": {
        "@fawmi/vue-google-maps": "^0.9.79",
        "@terraformer/arcgis": "^2.1.2",
        "@terraformer/wkt": "^2.1.2",
        "@triply/yasqe": "^4.2.28",
        "@triply/yasr": "^4.2.28",
        "axios": "^1.3.4",
        "n3": "^1.16.3",
        "pinia": "^2.0.26",
        "vite-plugin-rewrite-all": "^1.0.1",
        "vue": "^3.2.45",
        "vue-router": "^4.1.6"
    },
    "devDependencies": {
<EMAIL_ADDRESS>"^3.52.3",
        "@types/jsdom": "^20.0.1",
        "@types/n3": "^1.10.4",
        "@types/node": "^18.11.9",
        "@types/terraformer__arcgis": "^2.0.2",
        "@vitejs/plugin-vue": "^3.2.0",
        "@vue/test-utils": "^2.2.4",
        "@vue/tsconfig": "^0.1.3",
        "events": "^3.3.0",
        "jsdom": "^20.0.3",
        "npm-run-all": "^4.1.5",
        "sass": "^1.55.0",
        "shx": "^0.3.4",
        "typescript": "~4.7.4",
        "vite": "^3.2.4",
        "vite-plugin-vue-type-imports": "^0.2.4",
        "vitest": "^0.25.3",
        "vue-tsc": "^1.0.9"
    }
}

Thank you that works :)
prez-ui is running, next is prez configuration en data loading in  Fuseki.
On Fri, Aug 11, 2023 at 4:15 PM Edmond Chuc @.***>
wrote:

Thanks for the report @RichDijk https://github.com/RichDijk. I can see
you're running the build task on Windows. I just tested it on my Windows
machine and can confirm the issue. It works fine on macOS and Linux.
The issue is on Windows, it interprets build-only; with the semicolon as
part of the command, rather than as a separator for commands like on macOS
and Linux.
I've created a PR to fix it here #92
https://github.com/RDFLib/prez-ui/pull/92.
In the meantime, you can edit your local copy of package.json and make
the following change.
{
"name": "prez-ui",
"version": "3.0.1",
"private": true,
"scripts": {
"dev": "vite",--        "build": "run-p type-check build-only; shx cp dist/index.html dist/404.html",++        "build": "run-p type-check build-only && shx cp dist/index.html dist/404.html",
"preview": "vite preview",
"test:unit": "vitest --environment jsdom --root src/",
"build-only": "vite build",
"type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
},
"dependencies": {
@./vue-google-maps": "^0.9.79",
@./arcgis": "^2.1.2",
@./wkt": "^2.1.2",
@./yasqe": "^4.2.28",
@./yasr": "^4.2.28",
"axios": "^1.3.4",
"n3": "^1.16.3",
"pinia": "^2.0.26",
"vite-plugin-rewrite-all": "^1.0.1",
"vue": "^3.2.45",
"vue-router": "^4.1.6"
},
"devDependencies": {
@./google.maps": "^3.52.3",
@./jsdom": "^20.0.1",
@./n3": "^1.10.4",
@./node": "^18.11.9",
@./terraformer__arcgis": "^2.0.2",
@./plugin-vue": "^3.2.0",
@./test-utils": "^2.2.4",
@.***/tsconfig": "^0.1.3",
"events": "^3.3.0",
"jsdom": "^20.0.3",
"npm-run-all": "^4.1.5",
"sass": "^1.55.0",
"shx": "^0.3.4",
"typescript": "~4.7.4",
"vite": "^3.2.4",
"vite-plugin-vue-type-imports": "^0.2.4",
"vitest": "^0.25.3",
"vue-tsc": "^1.0.9"
}
}
—
Reply to this email directly, view it on GitHub
https://github.com/RDFLib/prez-ui/issues/91#issuecomment-1674866146, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC3L3BVDA62T7UZJEGTYP4LXUY5BNANCNFSM6AAAAAA3M55ZTM
.
You are receiving this because you were mentioned.Message ID:
@.***>

If you are familiar with Docker, there's a docker-compose.yml which you can use as a starting point.


Azure B2C IdP Assertion failure due to timestamp parsing

Hi,
We are running into an assertion response issue from Azure B2C IdP in the ACS process_response. We get an ['invalid_response'] exception with the following error:  time data '2021-07-22T16:52:26.7628553Z' does not match format '%Y-%m-%dT%H:%M:%S.%fZ'.
Looking at the python3-saml assertion validation, the error is from parsing  of the SAML2 timestamp of the SubjectConfirmationData in the response as seen here.
  <saml:SubjectConfirmationData NotOnOrAfter="2021-07-22T16:39:53.0743956Z" ...>
This is because the time format as specified in the validation only accepts 6 digits for the microseconds using the %f specifier.
Can the timestamp parsing be fixed as it prevents our move to using Azure B2C as an IdP?!
Thanks in advance!

The datetime 2021-07-22T16:39:53.0743956Z will be parsed by the regex
try:
            data = datetime.strptime(timestr, OneLogin_Saml2_Utils.TIME_FORMAT)
        except ValueError:
            try:
                data = datetime.strptime(timestr, OneLogin_Saml2_Utils.TIME_FORMAT_2)
            except ValueError:
                elem = OneLogin_Saml2_Utils.TIME_FORMAT_WITH_FRAGMENT.match(timestr)
                if not elem:
                    raise Exception("time data %s does not match format %s" % (timestr, r'yyyy-mm-ddThh:mm:ss(\.s+)?Z'))
                data = datetime.strptime(elem.groups()[0] + "Z", OneLogin_Saml2_Utils.TIME_FORMAT)

As you see the TIME_FORMAT_WITH_FRAGMENT = re.compile(r'^(\d{4,4}-\d{2,2}-\d{2,2}T\d{2,2}:\d{2,2}:\d{2,2})(.\d*)?Z?$')
matches the datetime, so it should be parsed properly.

Thanks @pitbulk. We were using python3-saml version earlier than v1.9.0. Upgraded to v1.9.0 and it works fine.
Closing this issue. Thanks!


Next

Codecov Report

Merging #5 (eb604ad) into master (feae2ab) will increase coverage by 0.16%.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   93.68%   93.84%   +0.16%
==========================================
  Files          68       68
  Lines        2786     2844      +58
==========================================
+ Hits         2610     2669      +59
+ Misses        176      175       -1

Flag
Coverage Δ

unittests
93.84% <91.89%> (+0.16%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aiopenapi3/v31/schemas.py
96.03% <ø> (-0.04%)
:arrow_down:

tests/api/v1/main.py
100.00% <ø> (ø)

tests/linode_test.py
51.72% <ø> (ø)

aiopenapi3/v20/glue.py
88.28% <50.00%> (+0.09%)
:arrow_up:

aiopenapi3/v30/glue.py
88.57% <50.00%> (+0.16%)
:arrow_up:

aiopenapi3/openapi.py
89.13% <89.47%> (+0.08%)
:arrow_up:

aiopenapi3/model.py
91.26% <94.02%> (+2.13%)
:arrow_up:

aiopenapi3/__init__.py
100.00% <100.00%> (ø)

aiopenapi3/base.py
89.31% <100.00%> (+0.69%)
:arrow_up:

aiopenapi3/errors.py
100.00% <100.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feae2ab...eb604ad. Read the comment docs.


Add Alerts, Logging, Channels Factories

Checklist

I applicable, I acknowledge that I have:

[x] Read the contributing guide
[x] Ran terraform fmt on all modified files
[x] Regenerated the relevant README.md files using tools/tfdoc.py
[x] Made sure all relevant tests pass

@joshw123 this is great stuff!
I left comments below, but besides that:

We need to update project/README.md to include examples the new variables and factories
FAST tests need to be updated

I have a few more things, but let's start with this batch.

Thank You, Ill look at the above, Im checking through all the fields too to ensure optional and required match the docs, and to include validation where necessary :)

@ludoo @juliocc The only two tests that are still not passing are Module Examples Test report
examples.test_plan.test_example[terraform:modules/project-factory:Example:1]
AssertionError: wrong number of resources
assert 56 == 59
examples.test_plan.test_example[terraform:modules/project-factory:Tests:1]
AssertionError: wrong number of resources
assert 22 == 25
I don't know if its just me, but I can't seem to see where it is getting them values, could you point me in the right direction please? :)
Thank You.

examples.test_plan.test_example[terraform:modules/project-factory:Example:1] AssertionError: wrong number of resources assert 56 == 59

Look at the #tftest tag at the end of the code block in this section.

examples.test_plan.test_example[terraform:modules/project-factory:Tests:1] AssertionError: wrong number of resources assert 22 == 25

Same thing here.
Take a look at the contributing guide for more details.

Can you sign the CLA from the<EMAIL_ADDRESS>account?

Can you sign the CLA from the<EMAIL_ADDRESS>account?

That address is mine. Should be fixed now.

@joshw123 I'll do my second pass today. Apologies for the delay.


mounting into an express app

I'm exploring migrating a large production Express app to koa v2 (so all of this applies to the promise API of v2). The koajs.com docs say for app.callback():

"You may also use this callback function to mount your koa app in a Connect/Express app."

However, it seems like you must mount a koa app at the "bottom" of your Express app since koa will never call next() to yield control back to express (like in the 404 case). I can't see an obvious work around for this currently. If the function returned by callback returned the promise, I think something like the following would work:
const koaCallback = koaApp.callback();
expressApp.use(function (req, res, next) {
  koaCallback(req, res)
    .then(function () {
      // not sure exactly how to detect this but seems doable
      if (!koaSentResponse(res)) {
        next() // let express keep processing this request
      }
   });
});

Perhaps somewhat related -- what's the use case for setting ctx.respond to false?

You probably want res.finished.
I'm not quite sure what ctx.respond = false would be used for, as a custom responder at the beginning of the chain should do the same job. It shouldn't be used, it's not officially supported and it's bound to break stuff.

I think the docs for you're looking at would assume that Koa would be used to handle a subdirectory like /api/... or similar, as opposed Koa being the default and Express filling in the gaps.

Huh. The ctx.respond = false line even has a comment saying "allow bypassing koa". Just for some background, the use case here is I want to move routes in an existing application over to koa incrementally, without affecting clients.

@nickb1080 Yep, I figured so. I don't think you want ctx.respond = false here though, I think you're initial solution is good with if (!res.finished) (instead of if (!koaSentResponse(res))). You could also manually assign routes to Koa of course, but that might be a pain depending on how many routes you have.

Wait, I just realized you're going to get a 404 response from Koa of course. I'll see how that can be prevented.

It looks like ctx.respond = false might be useful after all. Try making your first middleware return next().then(() => ctx.respond = (ctx.body == null)); or similar (double equal sign as undefined == null but '' != null).

Yeah I that'll work for avoiding the automatic 404 but I still see no way of calling the next provided by express/connect that would give control back to the enclosing app. In particular, callback returns a function of signature (req, res) -- the (possible) next provided by express/connect isn't even referenced. If it returned the promise I think we'd be in business though.

@nickb1080 Ooh, that's a tricky one, I thought handleRequest returned the promise. I'll make a PR for that now.

In case you didn't get a notification, I opened #847 for this.

@PlasmaPower has a PR open. if anyone else would like to put in their 2 cents, that would be great!

Wow, that would solve a lot of integration issues and smoothen transitions to Koa.

The test case for PR #847 appears to address all my concerns!

I'm glad! @jonathanong anything holding it up? The name of the variable might not be great, but it's fine IMO. I have tests for it too.

My just app.middleware()? IMO it's kind of related to current naming scheme of app.callback() and app.listen(). Highly subjective of course.

@fl0w Hmm, maybe. The difference of course is that it doesn't accept ctx, next, it accepts req, res.

This is resolved in https://github.com/koajs/koa/commit/e6539e1cf28e5cb5418d9dd3c364c03198610cf1


Add microbiology examples for licensed data

Add microbiology examples for licensed data and explain the licensed used there.

Possible examples from Zenodo:
Metagenome-assembled genomes (MAGs), colorectal cancer (CRC) (https://zenodo.org/records/7008911) - CC BY 4.0
Metagenome assemblies and metagenome-assembled genomes from the Daphnia magna microbiota
Creators (https://zenodo.org/records/4435010) - CC BY 4.0
Data from: Mining for NRPS and PKS genes revealed a high diversity in the Sphagnum bog metagenome - (https://zenodo.org/records/4976456) - CC0
Data from: Generational conservation of composition and diversity of field-acquired midgut microbiota in Anopheles gambiae sensu lato during colonization in the laboratory - (https://zenodo.org/records/5001400) - CC0


Balance issues open automatically

          Balance issues open automatically

_Originally posted by @COPILOTXI in<EMAIL_ADDRESS>### Tasks
- [ ] https://github.com/MicrosoftDocs/azure-devops-docs/issues/13431
- [ ] https://github.com/MicrosoftDocs/azure-devops-docs/issues/13432
- [ ] https://github.com/MicrosoftDocs/azure-devops-docs/issues/13281
- [ ] https://github.com/MicrosoftDocs/azure-devops-docs/issues/13371
- [ ] https://github.com/MicrosoftDocs/azure-devops-docs/issues/13428
- [ ] https://github.com/MicrosoftDocs/azure-devops-docs/issues/11759
- [ ] https://github.com/MicrosoftDocs/azure-devops-docs/issues/13424

Opensource

Balance issues

Enviado desde mi iPhoneEl 22 jun 2023, a las 10:23, William Anton Rohm @.***> escribió:
Open #13433 as completed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


docs: update COPYING

What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
Missing the copyright line into the license file.
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: leodido
If they are not already assigned, you can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 90ba93e06f8795f9011380d74097ea2c7a3261bf


 Can you confirm @hermanschaaf ?

@crazy-max It is possible to specify the style on the Go Report Card image, the same as on shields.io, e.g.
https://goreportcard.com/badge/github.com/gojp/goreportcard?style=flat-square

or
https://goreportcard.com/badge/github.com/gojp/goreportcard?style=plastic

@hermanschaaf Thanks :)


Fix paper url in README

Codecov Report

Merging #13 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   61.63%   61.56%   -0.08%
==========================================
  Files          79       79
  Lines       11118    11118
==========================================
- Hits         6853     6845       -8
- Misses       4265     4273       +8

Impacted Files
Coverage Δ

.../envs/mujoco/sawyer_xyz/sawyer_pick_out_of_hole.py
73.42% <0%> (-0.97%)
:arrow_down:

.../mujoco/sawyer_xyz/sawyer_reach_push_pick_place.py
70.96% <0%> (-0.72%)
:arrow_down:

...orld/envs/mujoco/sawyer_xyz/sawyer_button_press.py
81.16% <0%> (-0.65%)
:arrow_down:

...orld/envs/mujoco/sawyer_xyz/sawyer_handle_press.py
81.16% <0%> (-0.65%)
:arrow_down:

...taworld/envs/mujoco/sawyer_xyz/sawyer_box_close.py
76% <0%> (-0.5%)
:arrow_down:

...orld/envs/mujoco/sawyer_xyz/sawyer_assembly_peg.py
77.88% <0%> (-0.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a543f0...b879947. Read the comment docs.


wallet-ext: qredo integration UI flow

enables UI to show a qredo connection request and allows the user to accept or reject the connection
qredo connect is only enabled in dev mode (at wallet interface)

https://github.com/MystenLabs/sui/assets/10210143/8cf4f79f-256e-4d81-a40c-d8fa1a04797a
https://github.com/MystenLabs/sui/assets/10210143/ea8e780c-a4cc-4cca-b94c-841d16cfb97e
closes APPS-760

@pchrysochoidis in general looking good. Don't see the Qredo logo in the Accounts list though?

yeah trying to save time and since we have the redesign of the accounts probably will leave to be done there


options.ignore support

This PR enhances #2417 by keeping backward compatibility to support more customizable ignore patterns like *.test files. (#2592).
Something to mention is it is not covering require.context ignores (For store and middleware) but it can be considered as enough for basic support as our regexes already exclude things like *.test.* for store and middleware.
For future, we may have to refactor require.context into glob patterns inside builder module. This helps many perf improvements too.

There is no information about ignoring pages neither in https://nuxtjs.org/guide/views#pages nor https://nuxtjs.org/guide/routing
What is the prefix used to ignore pages in the pages folder?


Can I see AP during training?

Not as of right now. Would be nice to have though.

Not as of right now. Would be nice to have though.
Oh, thank you. That's a pity.

We do not support this since it will greatly slow down the training process.
A potential strategy is to run a test.py with --eval_all simultaneously and you could see the AP curve from tensorboard.

We do not support this since it will greatly slow down the training process.
A potential strategy is to run a test.py with --eval_all simultaneously and you could see the AP curve from tensorboard.

Thank you，got it. That‘s different from using a small val set when i was training a 2D model.

We do not support this since it will greatly slow down the training process.
A potential strategy is to run a test.py with --eval_all simultaneously and you could see the AP curve from tensorboard.

I forgot about that option. I think this approach is enough to track the process while training and no further coding is required.


RPC refactor, continued

As per #536 but with a few extra changes on top.
Extra changes:

Replaces ServiceProxy and MethodProxy chain with a simpler single object (Proxy)
Removes now unused wait_for_worker_idle

The diff is hard to follow on this change, but the end-state is easier to understand.
See https://github.com/mattbennett/nameko/compare/rpc-refactor...rpc-refactor-p2?expand=1 for a comparison of just the extras.

Included in #542


Update Homenavbar.css

Related Issue

Issue No. 163

Changes you made :

In the navigation bar (updated it)

Describe the changes :

Updated the nav-bar style to make it look more good

Check list :

[ x] I have followed code style of this project.
[ x] I have read the CONTRIBUTING document.
[ x] All the aspects mentioned in the issue are covered.
[ x] The website is properly working after my changes.
[ x] 🌟 ed the repo

Type of change :

[ ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)

Output Screenshots :

@priyanshu070702 Thank you for this issue
But plz mention issue number, changes you made, description, screenshots and complete the checklist.

I have updated it.
Please check.
On Sun, 9 Oct, 2022, 7:16 pm Arun G Nayak, @.***> wrote:

@priyanshu070702 https://github.com/priyanshu070702 Thank you for this
issue
But plz mention issue number, changes you made, description, screenshots
and complete the checklist.
—
Reply to this email directly, view it on GitHub
https://github.com/Arun9739/Paryatana/pull/163#issuecomment-1272546366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS3OAZFC4GWEDWOABX3NIJLWCLEEFANCNFSM6AAAAAARAL7PIU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@priyanshu070702 I appreciate your contribution
But it looks that you haven't created an issue.
Plz create an issue and make sure that it is assigned to you only.
Please read the contributing guidelines 🌟


Packages doc on pxt.microbit.org/packages points to 404

On https://pxt.microbit.org/packages there's a link to a CPP example
https://github.com/Microsoft/pxt-microbit-cppsample
This 404s

Link is fine, repro is private.

Well, I guess then either we should change the link to a public repo or make the existing repo pubic :). To all intents and purposes it's still a 404!

Sorry @jaustin that response wasn't really pointed at you :) I was more trying to add more info to the bug (for @abchatra and @pelikhan).

Any news on this? It's still 404 for me.

@abchatra @pelikhan can we make this public:
https://github.com/Microsoft/deprecated-pxt-microbit-cppsample
or remove the reference to it from the docs.

Removed reference.


function revokeToken() on null in /path/www/XXXXXXXXXXX

Hello, after calling the function to revoke the Oauth session, an error is displayed:
"Fatal error: Uncaught Error: Call to a member function revokeToken () on null in '/ path / www / my_path / xxxxxxxxxxx' ...."
I have called the function like this:
$google_client->revokeToken ();
For having created it like this:
$google_client->setAccessToken($token['access_token']);
Thank you!

This error indicates that $google_client does not contain an instance of Google_Client like you expect that it does. Often that can be an issue of variable scope, where the variable is used in a context where it does not exist. Also check that you haven't accidentally unset the variable or perhaps even forgot to define it.

I'm going to close this issue out. If you're still having trouble, please feel free to re-open!


Fix enable

I'm sorry, I forgot to update a couple of things, now should be all right ;)

@EnoahNetzach  thanks for contribution!
I have some questions.
Why you setup driver = null? It is null by default as i see.
Why you use best match instead of wildcard? If you use 1.* wildcard then any new stable version will be pulled.


More information for code completion options

This PR is also aimed to solve some problems we faced in the GDScript LSP implementation which is one of project of this GSoC.

Parse more informations for code completion all options
Only display identifies of options
Inserted content could be different with display tiltle of options

Edited:
* Show different icons for different type of completion options moved to #29744

@akien-mga Rebased

Thanks a lot!


Rust rewrite

[x] heartbeat Lambda
[x] get-strip Lambda
[x] gen-feed Lambda
[x] CI
[x] README
[x] Makefile

🎉🎉🎉


secrets

Currently we are mounting over /run/secrets if the user mounted something there.  This patch causes the secrets patch to be mounted before any volume mounts are mounted, also makes /run/secrets read/writable.
Signed-off-by: Dan Walsh<EMAIL_ADDRESS>

@runcom PTAL.
This should fix https://github.com/openshift/origin/issues/6981

The pull request is wrong since it is fedora against rhel, but it still works.

If we mount this before anything else, then we mount something over it, does this overwrite everything in /run/secrets or just merge the contents of the two?
BTW, I'll take care of applying this correctly to rhel and Fedora branches

If someone mounted on /run/secrets then we loose.  If they mount on a subdir like k8s is doing, they will merge.
I tested this by doing the following command.
docker run -ti -v /etc:/run/secrets/etc --rm fedora sh

alright, I'll fix our rhel super secret patches in both *-1.10 branches and  *-1.11

Should go in Fedora also.

sure, I've pushed fedora and rhel 1.10, closing this, I'll fix *-1.11 branches (both rhel and fedora)
I'll run all integration tests after I fix 1.11 branches and hopefully @lsm5 can build rc3 as soon as he comes online

The fix LGTM.


fix: make codecov push action occur within test step

Codecov Report

Merging #25 (d8f8d8a) into master (971cc51) will increase coverage by 5.48%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   92.16%   97.65%   +5.48%
==========================================
  Files          21       21
  Lines         600      597       -3
  Branches      102      102
==========================================
+ Hits          553      583      +30
+ Misses         41        7      -34
- Partials        6        7       +1

Impacted Files
Coverage Δ

src/PoolClient.ts
100.00% <ø> (ø)

src/const.ts
100.00% <ø> (ø)

src/types.ts
100.00% <ø> (ø)

src/Pool.ts
97.91% <97.05%> (+68.12%)
:arrow_up:

src/util/LinkedList.ts
94.11% <100.00%> (-0.62%)
:arrow_down:

src/error/PoolError.ts
100.00% <0.00%> (+50.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c625f04...d8f8d8a. Read the comment docs.