Seemingly inconsistent behaviour around H2Configuration objects

Spotted while trying to write tests for #261. Spinning this out as a separate issue because I don’t think it’s related to my changes, and I can readily reproduce it on master (commit d840a63).
We have the following test in test_invalid_headers.py:
def test_transfer_encoding_trailers_is_valid(self, frame_factory):
    """
    Transfer-Encoding trailers is allowed by the filter.
    """
    headers = (
        self.base_request_headers + [('te', 'trailers')]
    )

    c = h2.connection.H2Connection(client_side=False)
    c.receive_data(frame_factory.preamble())

    f = frame_factory.build_headers_frame(headers)
    data = f.serialize()

    events = c.receive_data(data)
    assert len(events) == 1
    request_event = events[0]
    assert request_event.headers == headers

Passing on CI and locally, which is fine. But then I replace this line:
    c = h2.connection.H2Connection(client_side=False)

with this, which I think should have the equivalent behaviour:
    config = h2.config.H2Configuration(client_side=False)
    c = h2.connection.H2Connection(config=config)

Splat:
================================================================ FAILURES =================================================================
___________________________________ TestInvalidFrameSequences.test_transfer_encoding_trailers_is_valid ____________________________________

self = <test_invalid_headers.TestInvalidFrameSequences object at 0x104b7e2e8>, frame_factory = <helpers.FrameFactory object at 0x104b7e278>

    def test_transfer_encoding_trailers_is_valid(self, frame_factory):
        """
            Transfer-Encoding trailers is allowed by the filter.
            """
        headers = (
            self.base_request_headers + [('te', 'trailers')]
        )

        config = h2.config.H2Configuration(client_side=False)
        c = h2.connection.H2Connection(config=config)
        c.receive_data(frame_factory.preamble())

        f = frame_factory.build_headers_frame(headers)
        data = f.serialize()

        events = c.receive_data(data)
>       assert len(events) == 1
E       assert 0 == 1
E        +  where 0 = len([])

test/test_invalid_headers.py:86: AssertionError
======================================================== 1 failed in 0.03 seconds =========================================================

I’m going to keep digging and see if I can get to the bottom of this, because I can’t see any obvious reason why the change in approach would lead to different behaviour.
(Context is that my changes add several new fields to the config object, which can’t be passed as kwargs to H2Connection. I need to pass in an H2Configuration object for my test, but keep hitting this error.)

Ding: we’re still using the client_side kwarg to H2Connection (which has been deprecated) in parts of the constructor:
self.local_settings = Settings(
    client=client_side,
    initial_values={
        MAX_CONCURRENT_STREAMS: 100,
        MAX_HEADER_LIST_SIZE: self.DEFAULT_MAX_HEADER_LIST_SIZE,
    }
)
self.remote_settings = Settings(client=not client_side)

# ...

self.incoming_buffer = FrameBuffer(server=not client_side)

This kwarg defaults to True, and we get a mismatch.


Help wanted using RTSP stream instead of Pi cam

Hello Jacob,
many thanks for your work!
My TP-Link Tapo C320WS provides an "AI detection", including people detection and also provides ONVIF services BUT does not send notifications regarding people detection because this seems to be a cloud feature and is not proccessed by the cam itself, I guess. But it does provide a local RTSP stream, wich I do already use for my doorbell. Hence, I was looking for a solution enabling people detection, without any cloud vendor and do it myself locally.
tl;dr:
Is it possible to use a local RTSP stream instead of the local Pi cam as device / source for detection?
Best regards,
Patrick

You can change the image feed from pi camera to anything you desire, try modify this to your requirements:         self.cap = cv2.VideoCapture(0)


nixos/libvirtd: add ${cfg.qemu.package}/libexec to PATH

Fixes #113172. This is needed to get libvirt to find the virtiofsd
binary through PATH, working around systemPackages only adding things in
/bin to PATH.

Example usage in libvirtd domain configuration
<filesystem type="mount" accessmode="passthrough">
  <driver type="virtiofs"/>
  <binary path="/run/current-system/sw/bin/virtiofsd" xattr="on"/>
  <source dir="/mnt/chonk"/>
  <target dir="data"/>
  <alias name="fs0"/>
  <address type="pci" domain="0x0000" bus="0x05" slot="0x00" function="0x0"/>
</filesystem>

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary filesI just checked virtiofsd was added to PATH . It was.
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Hi, sorry it's taken me so long to get to this.  I've opened https://github.com/NixOS/nixpkgs/pull/162635, which I think is a better solution as it's not libvirt-specific.


Example of using RelayManagementClient

Is there an example or any documentation for using the RelayManagementClient from the Microsoft.Azure.Management.Relay nuget package.
I am unsure how to initially authenticate,  I've tried passing an instance of Microsoft.Rest.BasicAuthenticationCredentials to the ctor but I only seem to get an 401 response code.
thanks
David

I've got it working by creating an Application Registration in  Azure AD and then using that to create a token via the authenticationContext.AcquireTokenAsync method.
I then pass the token into the ctor of Microsoft.Rest.TokenCredential
Is this the correct way of working?

@DavidBetteridge, glad to hear that you have it working. I will close this issue.

I'm upgrading relay management code from classic service bus management library to the new relay management library. I've tried acquiring a token using Microsoft.Azure.Relay.TokenProvider.CreateSharedAccessSignatureTokenProvider(keyName, key) but this token is of course a SharedAccessSignature token intended for the service bus namespace endpoint.
Is there a similar library like the service bus Microsoft.Azure.ServiceBus.Management.ManagementClient(connectionString)that can be used to manage Azure Relay on dotnet standard?
My reason for asking is that we have legacy code that we don't want to issue certificates and create app registrations for so that we can acquire token from AAD.


report forecast catch with and without 40:10 adjustment (or equivalent)

The 2021 lingcod south area assessment estimates current spawning biomass slightly below the B40% target leading to the additional impact of the 40:10 adjustment used in the harvest control rule for U.S. west coast groundfish.
We have been told "The 40-10 rule adjusts the ACL, not the ABC.  In this case, ABCs and ACLs should be reported.". Currently the ForeCatch_2021 value in derived quantities includes both the Pstar buffer and the 40:10 adjustment. We can remove the 40:10 adjustment by shifting the reference points and re-running the model but it would be nice if both quantities could be reported from the same model.

The PFMC uses somewhat incorrect terminology relative to the NS1 Guidelines.
SS reports OFL, which is the overfishing level and I think it corresponds
to the PFMC's ABC.
SS reports ABC, which includes the 40:10.  ACL is an additional management
adjustment below the ABC and is not calculable from any model.  So, take
SS' ABC as max ACL.
However, SS' OFL does not include the effect of recent input catches.
Rick
On Thu, Aug 12, 2021 at 6:12 AM Ian Taylor @.***> wrote:

The 2021 lingcod south area assessment estimates current spawning biomass
slightly below the B40% target leading to the additional impact of the
40:10 adjustment used in the harvest control rule for U.S. west coast
groundfish.
We have been told "The 40-10 rule adjusts the ACL, not the ABC. In this
case, ABCs and ACLs should be reported.". Currently the ForeCatch_2021
value in derived quantities includes both the Pstar buffer and the 40:10
adjustment. We can remove the 40:10 adjustment by shifting the reference
points and re-running the model but it would be nice if both quantities
could be reported from the same model.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/stock-synthesis/issues/193, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPV4IFEFFD4Q2TPY3UVTBDT4PCEZANCNFSM5CBFI63A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Thanks @Rick-Methot-NOAA for the additional information.
@chantelwetzel-noaa pointed me to the 2015 sablefish assessment as an example where OFL, ABC, and ACL are all reported (see screenshot below). However, reading through NS1 guidelines at https://ecfr.federalregister.gov/current/title-50/chapter-VI/part-600/subpart-D/section-600.310#p-600.310(f)(2)(ii), I understand what you're saying that the ABC should include both the Pstar and 40:10 adjustments. I've asked Pacific council staff for documentation of how these terms are defined within the PFMC context.
Regardless of terminology and what values need reporting for management by the PFMC, it could be helpful to be able to understand the relative impact of each element of the harvest control rule. However, given the availability of a work around (turning off one piece or the other in the forecast file), there's no rush on this. If it would be hard to implement within the current structure of the forecast module, we can assign this a "wont-fix" label and close the issue.

Let's keep this on the wishlist because I see merit in getting a report of
OFL conditioned on taking fixed catches in the first few years, but this
will be a biggish deal to implement.  Right now OFL is calculated
conditioned on catching OFL in all years of the forecast.
Other major forecast improvements are:

recruitment based on random draws (with correlation) from past recdevs
long forecasts just to get equilibrium that accounts for all the
allocation features (big deal for SEFSC)

On Thu, Aug 12, 2021 at 10:23 AM Ian Taylor @.***>
wrote:

Thanks @Rick-Methot-NOAA https://github.com/Rick-Methot-NOAA for the
additional information.
@chantelwetzel-noaa https://github.com/chantelwetzel-noaa pointed me to
the 2015 sablefish assessment as an example where OFL, ABC, and ACL are all
reported (see screenshot below). However, reading through NS1 guidelines at
https://ecfr.federalregister.gov/current/title-50/chapter-VI/part-600/subpart-D/section-600.310#p-600.310(f)(2)(ii),
I understand what you're saying that the ABC should include both the Pstar
and 40:10 adjustments. I've asked Pacific council staff for documentation
of how these terms are defined within the PFMC context.
Regardless of terminology and what values need reporting for management by
the PFMC, it could be helpful to be able to understand the relative impact
of each element of the harvest control rule. However, given the
availability of a work around (turning off one piece or the other in the
forecast file), there's no rush on this. If it would be hard to implement
within the current structure of the forecast module, we can assign this a
"wont-fix" label and close the issue.
[image: image]
https://user-images.githubusercontent.com/4992918/129236162-46c539f3-3f60-49fa-b122-28ee14065526.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/stock-synthesis/issues/193#issuecomment-897822344,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPV4IE3VNPK46RJ27QP2U3T4P7RLANCNFSM5CBFI63A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Disraptor: Update Documentation/Schema/Conventions/Standards

[ ] Update the documentation to the new disraptor frontend: e.g. create a new admin/reviewer user.
[ ] Standards/Schema regarding groups names etc: https://docs.google.com/document/d/1Jh0tyEOpHou1YiN3P1JLOVCmqPOjY-f17_PHJI_CSn8/edit?usp=sharing
[ ] Recipies for Debugging/etc. of vms in the new dockerized host

I find this issue not specific enough.
Disraptor docs should be in the disraptor repo.
Webis/webis-tira conventions should be in the KB.
Debugging guidelines should be created on the fly. Ask in DC if in doubt.


Remove line at top of page

Remove the line at the top of the page above the menu section.

Please visit - https://github.com/gwengibbes/com6338-module10-assignment10-gibbes-longo-avery/issues/40  - Suspicious line will be removed when all changes are approved.


[REGRESSION][PC][bazzite-deck] Graphics corruption under gaming mode since 20240224

Describe the bug
Graphics under gaming mode is corrupted on bazzite-deck since build 20240224, and all subsequent builds.
This affects both Steam itself, and all games subsequently launched (screenshots: [1] and [2] ).
However, games launched from Steam via the desktop (KDE) work fine, even when launching them using the gamescope command option in steam - so it appears that only gaming mode is affected.
Builds 20240223 and earlier (20240220 etc) are all fine.
These were the changes when upgraded to 20240224:
  discover-overlay 0.6.9-1.fc39 -> 0.7.0-1.fc39
  tuned 2.22.0.ublue.0.0.git.1331.8483cdb3-1.fc39 -> 2.22.1.ublue.0.0.git.1335.8ff17bce-1.fc39
  tuned-gtk 2.22.0.ublue.0.0.git.1331.8483cdb3-1.fc39 -> 2.22.1.ublue.0.0.git.1335.8ff17bce-1.fc39
  tuned-ppd 2.22.0.ublue.0.0.git.1331.8483cdb3-1.fc39 -> 2.22.1.ublue.0.0.git.1335.8ff17bce-1.fc39
  tuned-profiles-atomic 2.22.0.ublue.0.0.git.1331.8483cdb3-1.fc39 -> 2.22.1.ublue.0.0.git.1335.8ff17bce-1.fc39
  tuned-profiles-cpu-partitioning 2.22.0.ublue.0.0.git.1331.8483cdb3-1.fc39 -> 2.22.1.ublue.0.0.git.1335.8ff17bce-1.fc39
  tuned-utils 2.22.0.ublue.0.0.git.1331.8483cdb3-1.fc39 -> 2.22.1.ublue.0.0.git.1335.8ff17bce-1.fc39
  ublue-update 1.1.3+8a926c5-1.fc39 -> 1.2.3+1e670f0-1.fc39

This is on a Zen 3+ / Radeon 680M APU. Full system details in the Hardware section below.
What did you expect to happen?
Graphics should not be corrupted.
Output of rpm-ostree status
State: idle
Deployments:
  ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:39-20240223
                   Digest: sha256:07073dc8dfb92a470209d30329c50d50675c27d26359736cc0593c6cd97bc804
                  Version: 39.20240223.0 (2024-02-23T16:58:54Z)
                     Diff: 54 downgraded, 2 removed, 2 added
          LayeredPackages: gnome-boxes libvirt libvirt-client libvirt-daemon-config-network libvirt-nss virt-manager
                Initramfs: '-I /etc/crypttab /etc/modprobe.d/amdgpu.conf /etc/modprobe.d/deck-blacklist.conf'
                   Pinned: yes

  ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:39-20240224
                   Digest: sha256:3dd38fb5fc1c847a8ac2d3716ca1beb4c7efeb213e3e78b720015ce5fbb86987
                  Version: 39.20240223.0 (2024-02-24T00:48:19Z)
          LayeredPackages: gnome-boxes libvirt libvirt-client libvirt-daemon-config-network libvirt-nss virt-manager
                Initramfs: '-I /etc/crypttab /etc/modprobe.d/amdgpu.conf /etc/modprobe.d/deck-blacklist.conf'
                   Pinned: yes

● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:latest
                   Digest: sha256:4151c51fe4e5e394de97987a47600a09b0866a38569baeadccd88b146ea9875c
                  Version: 39.20240224.0 (2024-02-25T07:25:06Z)
          LayeredPackages: gnome-boxes libvirt libvirt-client libvirt-daemon-config-network libvirt-nss virt-manager
                Initramfs: '-I /etc/crypttab /etc/modprobe.d/amdgpu.conf /etc/modprobe.d/deck-blacklist.conf'
                   Pinned: yes

Hardware
Machine:  Lenovo ThinkPad Z13 Gen 1
CPU: AMD Ryzen 7 PRO 6850U
GPU: Radeon 680M (RDNA 2 / Rembrandt)
Display: Integrated (2880x1800~60Hz)
Extra information or context
No response

I just wanted to weigh in to confirm that I've also been seeing this issue since the 20240224 update (bazzite-deck-gnome on a Steam Deck LCD). At first I was terrified that it was a hardware failure, but several observations point to it being a software issue instead:

First, as the original post above states, the issue seems to be specific to game mode - I've never seen it happen when launching games from desktop mode.
Second, the visual corruption appears to be tied to individual processes. That is, if the visual corruption appears within a game, fully exiting the game and restarting it (hence spawning a new process) usually makes the issue go away.
Related to the above, the issue (which, to be clear, is sporadic) seems to either affect a process from the moment of startup, or not at all. That is, I've never had the visual corruption pop up in the middle of gameplay - if a process is affected, the visual corruption will be there from the moment the process starts. As an aside, it appears that while the corruption seems to be triggered once a game starts, it can randomly affect either the game process itself or the entire steam process. In the latter case, the corruption will of course persist after quitting the game (since the steam process is the one affected), but can be cleared by restarting steam (either by rebooting, switching to desktop mode then back, or using the "restart steam" menu option that is made available through developer mode).

I'm hoping that these observations, alongside all the data in the original report, can be of use with debugging. I might anticipate this being a hard one to debug since it seems pretty inconsistent...

So the issue appears to have been resolved with the latest stable (20240303). Not that I've tested extensively mind you, but I've rebooted a few times, played a couple of games in game mode, and it all seems to work fine. I'll continue my testing for a bit and will close the ticket if it's all good now.

So the issue appears to have been resolved with the latest stable (20240303). Not that I've tested extensively mind you, but I've rebooted a few times, played a couple of games in game mode, and it all seems to work fine. I'll continue my testing for a bit and will close the ticket if it's all good now.

Very odd, no kernel updates or gamescope updates during this time frame, would love to know exactly what broke.


support for cookie

hi well i view in other template this,
for the config of the template, example if you expand or collapse the left menu
when i collapse the menu and when i press f5 or enter to other view, this continue collapsed,etc

Hello
Please review issue #315
We decided that this feature should be implemented by backend developers.


[Event Parameter Change] Page 682 Schedule a Report - Procedure SetParameters - Event OnGetReportDescription

We would like the parameter/-s JobQueueEntry and Sender added to the following event.
Page 682 Schedule a Report - Procedure SetParameters - Event OnGetReportDescription
Original:
OnGetReportDescription(ReportDescription, RequestPageXml, ReportId, IsHandled)

[IntegrationEvent(false, false)]
    local procedure OnGetReportDescription(var ReportDescription: Text[250]; RequestPageXml: Text; ReportId: Integer; var IsHandled: Boolean)
    begin
    end;

Change:
Added sender and Parameter JobQueueEntry (Rec)
OnGetReportDescription(ReportDescription, RequestPageXml, ReportId, IsHandled, Rec);

[IntegrationEvent(true, false)]
    local procedure OnGetReportDescription(var ReportDescription: Text[250]; RequestPageXml: Text; ReportId: Integer; var IsHandled: Boolean; var JobQueueEntry: Record "Job Queue Entry")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


Updated channel and documentation to Rubocop v0.80.0

Most of this PR is pretty straightforward, and I'll leave some PR comments where I've got questions. At a minimum, this branch should provide a solid base for updating the channel.

@filipesperandio

I should also note that the RSpec suite does run, but with some additional noise in the output from the following Rubocop warning:
The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file:
 - Style/HashEachMethods
 - Style/HashTransformKeys
 - Style/HashTransformValues

@DanielWright that's expected due to https://github.com/rubocop-hq/rubocop/pull/7567

Is it desirable to handle or suppress the warnings in this PR?

I guess the Code Climate team need to make a decision here on whether upgrading the channel should make the newer cops available by default or not.

cc @pirj @bbatsov in case of any concerns about this.

No concerns here. As state earlier, we switched to a policy where RuboCop will enable cops only at major releases and the rest of the time it'd be up to users to decide if they want to enable/disable some new cop. I view the message you mentioned as purely informational, not a warning. :-)


'taskkill' is not recognized as an internal or external command

Trying to download some videos I get this error.

It used to work well some months ago.
Can anyone help me?

If you type in CMD where taskkill what do you get?

I get an error:
'where' is not recognized as an internal or esternal command

That's really weird.
Please check manually if you have these files:
C:\Windows\System32\taskkill.exe
C:\Windows\System32\where.exe

Yes, I have both of them.

Check if you have C:\Windows\System32 in the Path under Environment Variables

It wasn't in the path (not sure how it happened) and that solved the problem!
Thanks a lot!


[Feature Request] Count relation fields for access control

Is your feature request related to a problem? Please describe.
It would be nice, if its possible to count a relation field in a model and create access policies with it. This way the access control could be extended even more, e.g. deny create permissions on the Space model, if the auth() already has 3 spaces.
Describe the solution you'd like
@@allow("create", auth().spaces < 10)

// with filtering
@@deny("create", auth().spaces[type == "pro"] >= 2)

// limit a space to have only have 10 members max
@@deny("update", future().members > 10)

Hi @baenie, Thanks for filing this. I agree that it's very useful to be able to use relation's count to define policies. There will be some challenges to having a generic implementation (supporting both read and write policies) due to Prisma's limitations.
Meanwhile, I'm also wondering if we should provide a more generic extensibility for policies. My current thoughts go in the direction of allowing developers to define custom functions to participate in the policy evaluation. For the case of checking "create" rules, the function is passed with the Prisma transaction used to do the create, the auth() value, and the newly created (but not committed yet) entity value. This will allow one to make extra database queries and checks and finally determine if the operation should be granted or rejected. I'm showing some pseudo-code below:
model Foo {
  @@deny('create', !spaceCountCheck())
  ...
}

// function declaration in ZModel
function spaceCountCheck() {}

const db = enhance(prisma, { user: ... },
  {
    customFunctions: {
      // function implementation in TS
      async spaceCountCheck(tx: PrismaClient, user: User, entity: unknown) {
        // `tx` is the transaction used to create the entity
        // `user` is the `auth()` value
        // `entity` is the created (but uncommitted) new database entity
        // the function return a boolean value to indicate if the operation should be granted or rejected
        return user.spaces.filter(space => space.type === 'pro').length <= 1
    }
  }

I feel this should be  able to cover your needs, although more complicated than your original proposal. I'd love to hear your thoughts about this direction.

Thank you @ymc9 for your response!
I really like the idea of having a generic extensibility with custom functions for the access control! This could help making it as secure as possible, without having issues with Prisma limitations after all (and sadly there are a few of them 😅).


ORDER BY OBJECT_NAME, Error Message = ORA-00904: "V"."TEXT_VC": identificativo non valido

	at oracle.jdbc.driver.T4CTTIoer11.processError(T4CTTIoer11.java:710)
	at oracle.jdbc.driver.T4CTTIoer11.processError(T4CTTIoer11.java:608)
	at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:1248)
	at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:1041)
	at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:443)
	at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:518)
	at oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:251)
	at oracle.jdbc.driver.T4CPreparedStatement.executeForDescribe(T4CPreparedStatement.java:1059)
	at oracle.jdbc.driver.OracleStatement.prepareDefineBufferAndExecute(OracleStatement.java:1205)
	at oracle.jdbc.driver.OracleStatement.executeMaybeDescribe(OracleStatement.java:1135)
	at oracle.jdbc.driver.OracleStatement.executeSQLSelect(OracleStatement.java:1472)
	at oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1343)
	at oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:3728)
	at oracle.jdbc.driver.OraclePreparedStatement.executeQuery(OraclePreparedStatement.java:3832)
	at oracle.jdbc.driver.OraclePreparedStatementWrapper.executeQuery(OraclePreparedStatementWrapper.java:1099)
	at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCPreparedStatementImpl.executeQuery(JDBCPreparedStatementImpl.java:233)
	at org.jkiss.dbeaver.ext.oracle.model.OracleStructureAssistant.searchAllObjects(OracleStructureAssistant.java:308)
	at org.jkiss.dbeaver.ext.oracle.model.OracleStructureAssistant.findObjectsByMask(OracleStructureAssistant.java:116)
	at org.jkiss.dbeaver.ext.oracle.model.OracleStructureAssistant.findObjectsByMask(OracleStructureAssistant.java:1)
	at org.jkiss.dbeaver.ui.search.metadata.SearchMetadataQuery.run(SearchMetadataQuery.java:96)
	at org.eclipse.search2.internal.ui.InternalSearchUI$InternalSearchJob.run(InternalSearchUI.java:94)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Inside Dbeaver Log view:

DBeaver Version
Version <IP_ADDRESS>403091004 [Community]
Operating System
Windows 23H2
Database and driver
Oracle Database 11g Enterprise Edition Release <IP_ADDRESS>.0 using Oracle JDBC Driver ojdbc11 <IP_ADDRESS>
Steps to reproduce

Click on Search dropdown menu
Click on "Search..."
Choose connection
Type any string in textbox
Match type: contains
Max results 500
Case-insensitive: FALSE
Search in comments: FALSE
Search in definitions: FALSE
Object type must have TABLE selected (the combination that provokes the error is TABLE + "Search in definitions"
Run the search, the error should be presented instantly

Additional context
No response

Thank you for the bug report.
I can't reproduce it on Oracle 12.2. Probably, it's reproducible on Oracle 11 and older versions only

I saw that the query it shows in log:
SELECT DISTINCT OWNER, OBJECT_NAME, OBJECT_TYPE
FROM(
SELECT OWNER, OBJECT_NAME, OBJECT_TYPE
FROM ALL_OBJECTS
WHERE OBJECT_TYPE IN ('TABLE', 'VIEW', 'PACKAGE', 'PACKAGE BODY', 'CONSTRAINT', 'FOREIGN KEY', 'INDEX', 'PROCEDURE', 'FUNCTION', 'SEQUENCE', 'TRIGGER')
AND UPPER(OBJECT_NAME) LIKE '%FOO%'
UNION ALL SELECT OWNER, VIEW_NAME, 'VIEW' AS OBJECT_TYPE
FROM ALL_VIEWS v
WHERE UPPER(v."TEXT_VC") LIKE '%FOO%'
UNION ALL SELECT DISTINCT OWNER, name, TYPE
FROM ALL_SOURCE
WHERE UPPER(TEXT) LIKE '%FOO%')

does look for V.TEXT_VC while this field does not exist on catalog view ALL_VIEWS, but it has "TEXT" instead.
Is it possible that the query run by DBeaver upon search has been changed?
I've tried with Oracle v 19c 19.22 and it does not happen.

We haven't changed this query for a long time.
Thanks for your investigation! We will modify this query for old Oracle versions


Add support for Azure authentication using Azure AD Tokens

Description
Adds support for Azure authentication using Azure AD Tokens
Pull request checklist

[x] Support from environment variable
[x] Support from model YAML config
tests

[ ] Do we have tests? Should we add more?
[ ] Should we parametrize tests?
[ ] Should we add hypothesis tests?

documentation

[ ] add docstrings
[ ] if a module is new: add API reference file for Sphinx in docs/source/api-reference
[ ] check API doc of Sphinx - build and show with make sphinx && make open-sphinx

[ ] fix checks

start locale checks with make check
fix formatting with make format

Python type info

[ ] check and improve Python type info
[ ] double check if return types are specified - including -> None

[ ] check TODO comments in code
[ ] check FIXME comments in code
[ ] check if we want to increase the version or rc number
[ ] check if the copyright needs an update

file header
README.md
LICENSE file

@alaeddine-13 many thanks for thos PR.
Can you please add a copyright line to every file you touched.
Like this:
# Copyright (c) 2024 your_name_here, Deutsche Telekom AG

@alaeddine-13 please use the formatter. can do that with make format and make check.
That should fix some CI problems.
A very detailed guide is here: https://github.com/telekom/mltb2/blob/main/CONTRIBUTING.md

@alaeddine-13 please also add your copyright to the README.md and the LICENSE file.

Please increase the rc number in pyproject.toml.

Hi @alaeddine-13 ! To fix the CI issue with ruff: please do a rebase upstream/main. I fixed the issue there.

Hi @alaeddine-13 ! To fix the CI issue with ruff: please do a rebase upstream/main. I fixed the issue there.

done

We have this remaining mypy issue:
 Found 3 errors in 1 file (checked 28 source files)
mltb2/openai.py:369: note:          @classmethod
mltb2/openai.py:369: note:          def from_yaml(cls, yaml_file: Any, api_key: Optional[str] = ..., **kwargs: Any) -> Any
mltb2/openai.py:369: note:      Subclass:
mltb2/openai.py:369: note:          @classmethod
mltb2/openai.py:369: note:          def from_yaml(cls, yaml_file: Any, api_key: Optional[str] = ..., azure_ad_token: Optional[str] = ...) -> Any

Should we change back to "kwargs everywhere" or ignore this issue?

@alaeddine-13 mypy now fails with:
mltb2/openai.py:364: error: Argument "azure_endpoint" to "AsyncAzureOpenAI" has incompatible type "Optional[str]"; expected "str"  [arg-type]

The azure_endpoint is now optional in your PR. This is the reason for this issue. But AsyncAzureOpenAI expects it.
It is not optional there.
What is the reason to make azure_endpoint optional? Can that be changed back?

@PhilipMay can you run again the CI ? I implemented this workaround here in order to make azure_endpoint a positional argument


[testing] Add an option to make FLUTTER_STORAGE_BASE_URL warning non-fatal

Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.
This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.
Bug: #127683
Pre-launch Checklist

[X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X ] I signed the [CLA].
[X ] I listed at least one issue that this PR fixes in the description above.
[X ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is [test-exempt].
[ ] All existing and new tests are passing.

Could you add a test to https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart that verifies adding the flag at the top level successfully modifies the Cache.fatalStorageWarning field?

Yes, will add the test. Are you saying that we should use this approach, with a flag, and drop the other PR that unconditionally suppresses the failure?

Yes please :)

Removed the top-level option, as suggested.  There is no longer a top-level option to test.


Not transpiling ES2015

Hey there,
I love the package and I'm excited to use it for my project. There's something odd happening with my node v6.3 and npm 3.10.6 configuration where I clone the app, $ npm install, and then $ npm run hot-server but I'm getting an error:
import express from 'express'; SyntaxError: Unexpected token import
Clearly this means that babel isn't working somehow, for some reason this must be an issue with babel-register. I've had the issue occur on two separate machines. I'm sure it must be something I have misconfigured, but if we can work together on this I would love to help update your documentation or perhaps create a pull-request for a .babelrc if y'all would like.
Whatever the best route to go here is, I'm happy to accommodate. Please let me know. Thank you!

Never mind, this was totally my fault, I somehow goofed and removed all your dot files! Thanks!


Project-wide find and replace with regex does not replace

The find and replace with the project-wide tool (Cmd-Shift-F) is refusing to make replacements. I can replace with a standard find and replace, but not with the regex option enabled.
Atom 0.145.0, OS X 10.10
No errors were logged in the Atom console, or in Console.app.

Still having this issue with complex regexes in 1.0.19 (Mac OS X 10.10). The specific regex I've been using is as follows.
Find: \((->[^\u0000]*?)\n\s*\)\.observes[( ](.*?)[) ]?$
Replace: Ember.observer $2, $1

Same here.
I tried to use following regex table-responsive.*(.|[\r\n])\s+<table simply to find files having matching text.
With Find in Project it doesn't work. However, when I use Find in Buffer in a file that has the matching text, it finds the matching text.
Atom 1.1.0
Mac OS X 10.10

The issue is the new line in both @bbasic and @marnen's comments. See https://github.com/atom/scandal/issues/5 for more info

Project find and replace is not working for me with the following expressions.
Find:  ("\+[a-z,A-Z]*)" \);$
Replace:  $1+"" );


CLI prompt is missing

Enable CLI prompt for valenok CLi interface

Didn't know how to do it, enabling it also raises concerns of spending valuable MCU time on reading in data. I don't know much about how the serial connection works and if there is a hardware buffer. If this turns out to be a performance hog then perhaps it could be first enabled by a Cyphal request and then used.

Resolved with 33040b0f86fe3b52393894b9a387e802fee2aa85


Temporarily point to custom location for storage-initializer

#327 changed the image name for the initializer. However the new one is not available in GCR. Point to a custom one for now. Have opened an issue to revert this..
Fixed commits from #330
/assign @yuzisun

This change is

Fixed problems with branch :)

/lgtm
/approve


uploadFile not resolving promise on PWA, isSafari incorrect value

We have a Cordova Angular Ionic app using this plugin.
We noticed that after selecting an image, it's hit or miss if the uploadFile() function returns on the promise.
Even more odd, if we opened up the Safari inspector from my Macbook and tried to inspect the app, while the inspector is open, the uploadFile() function will never return on the promise.
After investigating we saw in the image-compress.ts file there is a regex that checks if the browser isSafari.
When setting this to be permanently  true, the plugin works perfectly on our app.
I think the regex needs to be updated to account for PWAs running on iPhones.
Maybe instead of checking for "safari" in the regex, check for AppleWebKit?
Here is the output of my navigator.userAgent for each device:
Safari from MacBook:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Safari/605.1.15
isSafari = true
Safari browser from iPhone:
Mozilla/5.0 (iPhone; CPU iPhone OS 16_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.3 Mobile/15E148 Safari/604.1
isSafari = true
Our Ionic APP running on an iPhone:
Mozilla/5.0 (iPhone; CPU iPhone OS 16_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148
isSafari = false (ONLY WORKS PROPERLY IF THIS IS TRUE)

Is there even a purpose for the whole logical switch with isSafari?
It looks like the only difference that's doing is adding the file input element to the DOM or not. Wouldn't this work in all scenarios by ALWAYS going the isSafari route?

Thank for the detailed issue explanation.
The difference is not adding in DOM or not, it's which web api used.
At first we wanted to use Renderer provided by angular only, but because of issues in Safari we went on using native Js for it.
I will investigate your case within next week.

@saggio89 if fact I think you can already submit a PR for changing the regex, I think your are right. Let's check AppleWebKit instead. Great idea!

Fixed in this commit https://github.com/dfa1234/ngx-image-compress/commit/e0fe90f158ec1b84becaa40a94480a652899106a

Hello @dfa1234! Thank you for putting together such an awesome package!
I also am seeing an issue in my Ionic app. When I run my app on the browser everything works as expected,  but when I build to an iPhone / Android the uploadFile() promise never gets hit.
I read through your documentation and it seems like it should work for native iOS / Android because you're using Renderer2, but maybe I'm misunderstanding something.  Should this package work natively or is that not supported? If it is supported, I might be doing something wrong and I can send you code snippets to help diagnose.
Thanks in advance!

@hunterjenkinsenzy your welcome.
Can you elaborate what do you mean it's not working on iPhone or Android?
We have a browser stack account and we tested several real device, with success.
Please give us a reproducible scenario (what is the browser and OS you use)

Here you can see it working on a real Iphone 13 (Safari)
Closing awaiting any further explanation

Please use the demo website image-library.app


Field "model_id" has conflict with protected namespace "model_".

Describe the bug
after make build, creating the config, make start-backend or make run i get this error
(base) stratte@stratte-MS-7D08:~/Schreibtisch/AI/OpenDevin5$ make start-backend
Starting backend...
/home/stratte/.cache/pypoetry/virtualenvs/opendevin-juECaYuY-py3.11/lib/python3.11/site-packages/pydantic/_internal/_fields.py:151: UserWarning: Field "model_id" has conflict with protected namespace "model_".

You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
/home/stratte/.cache/pypoetry/virtualenvs/opendevin-juECaYuY-py3.11/lib/python3.11/site-packages/pydantic/_internal/_fields.py:151: UserWarning: Field "model_name" has conflict with protected namespace "model_".

You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
/home/stratte/.cache/pypoetry/virtualenvs/opendevin-juECaYuY-py3.11/lib/python3.11/site-packages/pydantic/_internal/_fields.py:151: UserWarning: Field "model_info" has conflict with protected namespace "model_".

You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
INFO:     Started server process [16214]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:3000 (Press CTRL+C to quit)
^[[B^Z
[1]+  Angehalten              make start-backend
(base) stratte@stratte-MS-7D08:~/Schreibtisch/AI/OpenDevin5$ make run
Running the app...
Waiting for the backend to start...
Backend started successfully.
Starting frontend with pnpm...

><EMAIL_ADDRESS>start /home/stratte/Schreibtisch/AI/OpenDevin5/frontend
> vite "--" "--port" "3001"

failed to load config from /home/stratte/Schreibtisch/AI/OpenDevin5/frontend/vite.config.ts
error when starting dev server:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'vite' imported from /home/stratte/Schreibtisch/AI/OpenDevin5/frontend/vite.config.ts.timestamp-1712369748800-e12a0132ae811.mjs
    at packageResolve (node:internal/modules/esm/resolve:845:9)
    at moduleResolve (node:internal/modules/esm/resolve:918:18)
    at defaultResolve (node:internal/modules/esm/resolve:1148:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
    at link (node:internal/modules/esm/module_job:86:36)
 ELIFECYCLE  Command failed with exit code 1.
 WARN   Local package.json exists, but node_modules missing, did you mean to install?
make: *** [Makefile:95: run] Fehler 1
(base) stratte@stratte-MS-7D08:~/Schreibtisch/AI/OpenDevin5$

Setup and configuration
Current version:
latest

ubuntu
LLM_API_KEY="na"
LLM_BASE_URL="http://<IP_ADDRESS>:5000/v1"
LLM_MODEL="openai/Mistral"
LLM_EMBEDDING_MODEL="lokal"
WORKSPACE_DIR="./workspace"
MAX_ITERATIONS=20000

Logs, error messages, and screenshots:
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
/home/stratte/.cache/pypoetry/virtualenvs/opendevin-juECaYuY-py3.11/lib/python3.11/site-packages/pydantic/_internal/_fields.py:151: UserWarning: Field "model_name" has conflict with protected namespace "model_".

You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
/home/stratte/.cache/pypoetry/virtualenvs/opendevin-juECaYuY-py3.11/lib/python3.11/site-packages/pydantic/_internal/_fields.py:151: UserWarning: Field "model_info" has conflict with protected namespace "model_".

You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
INFO:     Started server process [16288]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
ERROR:    [Errno 98] error while attempting to bind on address ('<IP_ADDRESS>', 3000): address already in use
INFO:     Waiting for application shutdown.
INFO:     Application shutdown complete.

Thank you for the report. The model_id issue is just a warning, it works just fine. It just looks scary or annoying. Tracked here: https://github.com/OpenDevin/OpenDevin/issues/797
The actual error you got last has nothing to do with it: it means that you already run something, probably opendevin, on the same port, so it can't start another.
For that, in console:
 lsof -i :3000
To see what is running on 3000, then kill -9 followed by the pid of that process, like kill -9 53040.

Thank you for the report. The model_id issue is just a warning, it works just fine. It just looks scary or annoying. Tracked here: #797
The actual error you got last has nothing to do with it: it means that you already run something, probably opendevin, on the same port, so it can't start another.
For that, in console:  lsof -i :3000 To see what is running on 3000, then kill -9 followed by the pid of that process, like kill -9 53040.

Ok, but the frontend wont start either
(base) stratte@stratte-MS-7D08:~/Schreibtisch/AI/OpenDevin5$ make start-frontend
Starting frontend...

<EMAIL_ADDRESS>start /home/stratte/Schreibtisch/AI/OpenDevin5/frontend
vite

failed to load config from /home/stratte/Schreibtisch/AI/OpenDevin5/frontend/vite.config.ts
error when starting dev server:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@vitejs/plugin-react' imported from /home/stratte/Schreibtisch/AI/OpenDevin5/frontend/vite.config.ts.timestamp-1712370515232-8ebd11aa7bd28.mjs
at packageResolve (node:internal/modules/esm/resolve:845:9)
at moduleResolve (node:internal/modules/esm/resolve:918:18)
at defaultResolve (node:internal/modules/esm/resolve:1148:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
at ModuleWrap. (node:internal/modules/esm/module_job:87:39)
at link (node:internal/modules/esm/module_job:86:36)
 ELIFECYCLE  Command failed with exit code 1.
 WARN   Local package.json exists, but node_modules missing, did you mean to install?
make: *** [Makefile:84: start-frontend] Fehler 1
(base) stratte@stratte-MS-7D08:~/Schreibtisch/AI/OpenDevin5$

I would try this: git pull, to make sure you have the latest version, then make build and see if it does succeed to rebuild opendevin.

worked thank you


Unused variable

https://github.com/eclipse/rdf4j/blob/6ac2054b4f9bcbb94dc9250eebca3d76d76b20e5/core/spin/src/main/java/org/eclipse/rdf4j/spin/function/spif/ConvertSpinRDFToString.java#L56
This variable is never used.

This is in the deprecated spin module.


Will you support translations in the future?

If you start translation work, I can help with Chinese.

Unofficial response incoming: while this is a nice idea, it's most likely a very low priority compared to more often requested features, such as a "Remember Me" option or bar charts, and bStats is a low priority project anyway. So probably don't expect this any time soon.
P.S. Every user who uses custom charts would have to translate them tok, which would be a bit of a hassle.

Thank you for the suggestion and offer to help with translation.
It would be cool to have these kind of translation, but considering the amount of work to translate the website in other languages (and keep them up to date!) I don't think this would be worth the work.


Task - biocurations - update UI/UX - add style/layout

@jlpereira can you minimally style this up (Manage biocuration types and groups)?
/tasks/controlled_vocabularies/biocuration/build_collection

Mock-up link here:
https://docs.google.com/drawings/d/1qKg4_pM284O4nr6kl5j1c_igmdEta1E52KUtHOj0chA/edit

It's done

@debpaul I think this was already shown, it was done months ago.


feat: add cloud provider disruption reasons

Fixes #N/A
Description
Add Cloud Provider DisruptionReasons() cloud provider method.
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 77.845%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cloudprovider/fake/cloudprovider.go
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/disruption/consolidation.go
4
87.25%

Totals

Change from base Build<PHONE_NUMBER>4:
0.02%

Covered Lines:
8921

Relevant Lines:
11460

💛  - Coveralls

/lgtm


[svengbr] npm: Browserslist: caniuse-lite is outdated

Where to find the issue
package.json
Describe the issue
Executing
npm run build
as documented in the README.md causes the following warning to be shown:
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

This is a minor issue affecting website testing only. It does not affect the production website.
Suggested change
Run
npx browserslist@latest --update-db
against the master branch of the repo.

According to PR https://github.com/corona-warn-app/cwa-website/pull/686 an npm update was carried out on Dec 17, 2020 which caused caniuse-lite to be updated.
I'm no longer seeing this issue.

According to PR https://github.com/corona-warn-app/cwa-website/pull/686 an npm update was carried out on Dec 17, 2020 which caused caniuse-lite to be updated.
I'm no longer seeing this issue.


[notification hubs] Adding Xiaomi support

Packages impacted by this PR

@azure/notification-hubs

Issues associated with this PR
Describe the problem that is addressed by this PR
Adds Xiaomi support for Track 2 SDKs with registration, installation, send and send outcome operations.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
yes
Provide a list of related PRs (if any)

https://github.com/Azure/azure-notificationhubs-dotnet/pull/261
https://github.com/Azure/azure-notificationhubs-dotnet/pull/260
https://github.com/Azure/azure-notificationhubs-dotnet/pull/259

Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-notification-hubs

/check-enforcer evaluate

/check-enforcer override


Debugging

Description of bug
I need to capture the data send to robot controller while running communication/program in "debugging mode".
There is great possibility to capture data from controller (using ex. mycobot.get_angles() ) but there is no possibility to see what is send:
angles = [0, 20, 0, 0, 0, 0]
mycobot.send_angles(angles, 50)
Is the simple way to capture this data (while running command: mycobot.send_angles (...) ?

The support was delivered.


Use a single shared connection pool for GCM pushes, set timeouts on gcm requests

instead of creating a lingering connection for every push.
Doing this greatly reduces the number of open connections for GCM, and the number of connections. It also decreases CPU usage noticeably when there are active GCM PSPs, and should decrease latency.
Previously, uniqush-push was creating http.Clients every time a push request was made. Each http.Client has its own instance of a connection pool.
https://golang.org/pkg/net/http/#pkg-overview

Clients and Transports are safe for concurrent use by multiple goroutines and for efficiency should only be created once and re-used.

Add a timeout of 10 seconds for pushes to GCM servers. It's undesirable to wait forever for a request to finish if there are network errors.

:+1:  :sheep: :it:


Text shadows

Codecov Report

Merging #72 (6fbdd0a) into master (1deba02) will decrease coverage by 0.07%.
The diff coverage is 26.80%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   31.83%   31.76%   -0.08%
==========================================
  Files          62       62
  Lines       12061    12118      +57
  Branches      196      197       +1
==========================================
+ Hits         3840     3849       +9
- Misses       8025     8072      +47
- Partials      196      197       +1

Impacted Files
Coverage Δ

src/clj/skylobby/fx/battle.clj
63.79% <9.09%> (-1.48%)
:arrow_down:

src/clj/skylobby/fx/players_table.clj
4.33% <12.82%> (+1.63%)
:arrow_up:

src/clj/spring_lobby.clj
13.07% <52.77%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1deba02...6fbdd0a. Read the comment docs.


tech(common): multi line log utility added

#9
Added multi-line log utility to support multi-line console output.

@shangan23 can we squash the commits to one. seems like second one is duplicate

I tried to squash but I’m getting merge error. E need to look into it
tomorrow
On Sun, 21 Mar 2021 at 12:15 AM, Venkat.R @.***> wrote:

@shangan23 https://github.com/shangan23 can we squash the commits to
one. seems like second one is duplicate
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/web-slate/react-chef/pull/10#issuecomment-803442697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2RIDT5UBXAYQGKLGZQAITTETUMVANCNFSM4ZQTGDKA
.

@shangan23 can we squash the commits to one. seems like second one is duplicate

done

lgtm 👍


[REQUEST Membership]: New membership for felix0080

GitHub Username
felix0080
Organization you are requesting membership in

openyurtio
Sponsors
China Unicom
Requirements

[ yes] I have joined in the community [Dingding] and [WeChat]
[ yes] I often attend Openyurt Community Week
[ yes] I have reviewed the [community membership docs]
[ yes] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
[ yes] I have checked my affiliation in [devstats] (if it's not correct, please fix in [cncf/gitdm])
[ yes] I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

PRs reviewed / authored:
https://github.com/openyurtio/openyurt/pull/296
Issues :
https://github.com/openyurtio/openyurt/issues/285
[devstats]: https://openyurt.devstats.cncf.io/d/56/company-commits-table?orgId=1
[community membership]: https://github.com/openyurtio/community/blob/main/community-membership.md
[dingding]: 31993519
[cncf/gitdm]: https://github.com/cncf/gitdm#addingupdating-affiliation

welcome @felix0080 as member of OpenYurt community.

+1

+1

+1

@felix0080 congratulations you to become a member of OpenYurt community. We have sent a github message to invite you as member of OpenYurt, please check the message and keep the member public.

@felix0080 congratulations you to become a member of OpenYurt community. We have sent a github message to invite you as member of OpenYurt, please check the message and keep the member public.

thanks!


Page Break not working in .html() method.

Feature requests, bug reports etc. are very welcome as issues. But questions are directed to stackoverflow with the tag jspdf.
If you are facing issues with utf-8 characters, please refer to #2677.
Note that bug reports should follow these guidelines:

A bug should be reported as an mcve
Make sure code is properly indented and formatted (Use ``` around code blocks)
Provide a runnable example.
Try to make sure and show in your issue that the issue is actually related to jspdf and not your framework of choice your setup.

Please follow the issue template. Thanks.

did you get any solution?
@arjunprakash211

@Karthik-PlantSense  yes, set the page height in CSS precisely  like,  height: 20.64mm;


Add GraphQL scripts for the trait association search web component

These scripts will basically be a copy of the trait association search example in the dev/ directory of the web-components repo. However, due to limitations in the current Intermine data model, the genus and species parameters of the traits GraphQL query actually have no effect. This will be fixed when support for the <IP_ADDRESS> Intermine data model is added to the GraphQL server. Until then this issue should be considered blocked.

Done in PR #72.


jarek/7962: upgrade groovy version to 2.5.6

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Ability to edit header/labels

Overview
Currently, there is no way to fix this error:

Blocked by https://github.com/okfn/opendataeditor/issues/587


Make installable via upip?

I also would like to see this

Is it only possible to cross-install? Is it possible to use Thonny package manager?

MicroPython upip


Added support for sk6812RGBW leds (ab)using the SPI interface.

1. Tell us something about your changes.
Added support for sk6812RGBW leds (ab)using the SPI interface. right now it only uses RGB - white is set to zero
2. If this changes affect the .conf file. Please provide the changed section
"device" :
{
"name"       : "MyPi",
"type"       : "sk6812spi",
"colorOrder" : "grb",
"output"     : "/dev/spidev0.0",
"rate"       : 3800000,
}

nice one. Hopefully you find a way to use the CW/WW led.
i thought about something like:
If the values for R/G/B are near the same (which is by defintion white), white could be enabled. Now depending on average val (0-255?) the brightness of CW/WW could be set.
OT1: If i imagine right the SPI interface needs a (real)root class to remove code duplication (like RS232). @redPanther : yes? maybe i missed this.
OT2: I am highly interested at your clock effect, may we see a PR soon? :)

OT2: I am highly interested at your clock effect, may we see a PR soon? :)
its optimized for my special matrix lamp. Have to make it general before releasing

That white algorithm is already implemented in the 281x based device and I need to port that (and other alohirthms) to this device.
How would a new root class look and feel compared with the existing LedSPIDebice class that this uses ?


export NavigationComponentService in public_api

The NavigationComponentService is not exported in the public_api of the storefront library. This means customer cannot use it.

Those who facing this problem, for time being till its not fixed here is workaround:
import { ɵbj as NavigationComponentService } from '@spartacus/storefront';

Here is workaround:
import { ɵbm as NavigationComponentService } from '@spartacus/storefront';
and now in constructor
 constructor(s:NavigationComponentService){
    super(s);
  }

Please careful in import its not a ebm or 0bm there is special character here its ɵbm

i don't know why they put special char here. It took sometime to figure out that its ebm but ɵbm.


Markdown Code/CodeBlock -> Lexical doesn't work

Describe the Bug
We have some old string MD files where we have a lot of code examples.
Either using single line small Code sections
like so
or CodeBlocks
const like = "so"

Using
  const yourEditorConfig = {
    ...defaultEditorConfig,
    features: [...defaultEditorFeatures],
  }

  const yourSanitizedEditorConfig = await sanitizeServerEditorConfig(
    yourEditorConfig,
    payloadConfig,
  )

  const headlessEditor = createHeadlessEditor({
    nodes: getEnabledNodes({
      editorConfig: yourSanitizedEditorConfig,
    }),
  })

  headlessEditor.update(
    () => {
      $convertFromMarkdownString(ContentPart1, [
        ...yourSanitizedEditorConfig.features.markdownTransformers,
      ])
    },
    { discrete: true },
  )

The code parts of the md file just get converted to strings. If we add in the CODE export from '@lexical/markdown' we get the correct nodes but then payload isn't able to interprete these so it errors out. I'm guessing we'd need to build a custom lexical feature but this should really be covered out of the box.
Link to the code that reproduces this issue
You can reproduce with the above
Reproduction Steps

copy paste whats above.

Thats it

Which area(s) are affected? (Select all that apply)
plugin: richtext-lexical
Environment Info
Beta Payload, Latest next, react 19

Like i suspected. this fixes it
import { CodeNode } from '@lexical/code'

  const headlessEditor = createHeadlessEditor({
    nodes: [
      ...getEnabledNodes({
        editorConfig: yourSanitizedEditorConfig,
      }),
      CodeNode,
    ],
  })

        if (node.type === 'code') {
          console.log(node)
          return <Code key={index} code={node.children[0].text} language={node.language} />
        }

This should be standard in the payload library


EQC tests not failing

Problem
Failing EQC tests don't fail the CI step
Possible Solution(s)
Fix CI to fail and fix tests to pass

Fixed by #700

Fixed by #700


fix: Update HeaderRoutePredicateFactory to use getValuesAsList

This PR resolves #3446

@ohprettyhak Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@ohprettyhak Thank you for signing the Contributor License Agreement!

Unfortunately you just added dozens of commits that aren't relevant

Unfortunately you just added dozens of commits that aren't relevant

I'll fix it after I wake up.


Handle unexpected error when the test is aborted

When the conformance test is aborted by Jenkins, the results log is actually an incomplete file, we need also to check if there is a complete text for e2e test result. Otherwise, the result will show All tests passed. when the test is actually running and aborted unexpectedly, which is misleading.

/test-all
/test-windows-all

/test-all


Prefer action for response descriptions

Replaces #817

I recently upgraded a project to 3.0.0 and found that the response descriptions for my project had changed.
I have a base controller that defines some baseline SwaggerResponse attributes for various HTTP status codes, but derived controllers and actions would re-define the response for certain status codes if the documentation needed to be different, such as to be more specific based on action or controller specific implementation details.
For example:
[SwaggerResponse(400, "The value of the foo header is invalid.")]
public abstract class MyBaseController : Controller
{
}

[SwaggerResponse(400, "The value of the foo or bar header is invalid.")]
public abstract class MyController : MyBaseController
{
    [SwaggerResponse(400, "The value of the foo, bar or baz header is invalid.")]
    public IActionResult MyAction()
    {
        return Ok(new{ foo = "bar" });
    }
}

With 3.0.0, all responses gave the description for 400 as The value of the foo header is invalid., instead of using the more-derived response description where available.
This PR adjusts AnnotationsOperationFilter to only set the Description if a value has not already been set so that precedence is retained, rather than the current last-one wins behaviour.
I've also fixed the compiler warning generated by the obsolete property usage from IDocumentFilter in its implementation in DocumentFilterContext.

@domaindrivendev Any chance of this being merged soon for inclusion in the next minor release?

I think you've correctly identified an issue with the order of precedence. However, the solution you've proposed makes an assumption that the most specific attributes will always appear first in the actionAndControllerAttributes list. This is a reasonable assumption for controller vs action attributes because further up the call stack, we know that the filter combines attributes as follows:
var actionAttributes = context.MethodInfo.GetCustomAttributes(true);
var controllerAttributes = context.MethodInfo.DeclaringType.GetTypeInfo().GetCustomAttributes(true);
var actionAndControllerAttributes = actionAttributes.Union(controllerAttributes);

However, I don't believe there is any guarantees about the ordering of inherited vs direct attributes returned in the calls to GetCustomAttributes(true) above.
So, to move forward and at least solve the controller vs action attribute precedence, I'd like to simply reverse the Union call above so that action attributes, being more specific, are applied last:
var controllerAttributes = context.MethodInfo.DeclaringType.GetTypeInfo().GetCustomAttributes(true);
var actionAttributes = context.MethodInfo.GetCustomAttributes(true);
// Action attributes have higher specificity and so they're applied last
var controllerAndActionAttributes = controllerAttributes.Union(actionAttributes);

Please let me know if that makes sense and if it would work for your case?

Sure, I'll update that latest this morning. I've probably just called them the wrong way around to be honest. As long as the tests still pass once I've updated it then I think my use-case is still fixed.

To be clear though, you have some tests which may still pass but are based on assumptions about the order in which GetCustomAttributes(true) returns attributes. Specifically, it doesn't guarantee that the order in which they're declared will be retained AND it doesn't guarantee any ordering wrt direct vs inherited attributes. So, I would recommend you update this PR, to only solve/test the action vs controller precendence as we don't really have control over the other cases.

So if I swap the order of the arguments as you suggested, it breaks the use case I'm trying to fix as the controller's response takes precedence over the action's.

If you reverse the Union, then you need to remove the check on description. That is, I’m suggesting we revert to last-one-wins, but fix the ordering so the last ones are action attributes

I've updated the code as suggested, the only thing I had to change was to call Reverse() on the controller attribute getting so that the most-derived type's response attribute was last, as otherwise it was being overwritten with the base class'.

Thanks so much for your patience - nearly there, just a few minor comments.

FYI, it looks like this code builds the list by walking the class hierarchy from the top down, hence why the Reverse() was needed. While it's probably unlikely to change as it appears to be the "obvious" way to do it, I'll do it manually to guarantee it anyway in the other PR.
https://github.com/dotnet/coreclr/blob/e95c1f8fe6ae185b90b807170445c2e26cfbed66/src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs#L1287-L1295

I've done the other change here. I can either open a new PR and rebase it onto this one once it's merged, or I can just push it onto this branch for this PR.

@domaindrivendev Any further feedback on this before I fix up the merge conflicts that now exist?

@domaindrivendev Any further feedback on this change? If not I'll look at re-doing it against the latest changes in master.

Merge conflicts with 5.0.0 fixed - could this be merged for inclusion in a future RC or the final release please?

@domaindrivendev Can this be merged now please?

I'd like this to get in for 5.0.0 as I guess that's going to ship imminently with ASP.NET Core 3.0 shipping on Monday - can this be merged now please? This PR has been open for a year now.

Thank you @domaindrivendev 😃


concordance fix on first section

It's more readable to Brazilian Portuguese this way.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


strip, lstrip and rstrip operations implementation

This PR is implements strip, rstrip and lstrip operations.
Tests are added into the group of similar operations: strip, rstrip and lstrip.
This PR is ready for review.

Thanks for the patch. I've scheduled it for review.

@shssf thanks for the patch, I've completed an initial review and made a few suggestions.

@shssf I thought about this some more yesterday, and I think this will need some more work. I would propose to replace the runtime switches (the constants) with a set of composable functions. Let me sketch out what I had in mind, pseudocode follows:
def check_type(chars):
    # check the type of chars and raise if mismatch

def left_bound(string, chars):
    for i in range(len(string)):
        if string[i] not in chars:
            return i
    else:
        return len(string)

def right_bound(string, chars):
    # as above but for right

@overload_method
def unicode_lstrip(string, chars):
    check_type(chars)
    def lstrip_impl(string, chars):
        return string[left_bound(string, chars):]

Also, you could consider turning chars into a typed dictionary for speed and so you don't incur the O(n) penalty every time you check if a char is in chars. It might only make sense for larger chars but only profiling/timing will tell.
BTW: I am also available on the Numba channel on gitter, in case you want to discuss in real-time.

@esc I tried to address your comments except converting chars into dictionary.
Also, you might want me to move
    chars = ' ' if chars is None else chars
    str_len = len(string)

into unicode_strip_types_check()

@shssf no, it turns out that moving that won't work because it needs to happen in the implementation rather than in the typing phase.

@shssf it looks pretty good sofar! Let's wait for CI to complete.

@shssf I just notices, you may need to use OptionalTypes here:
http://numba.pydata.org/numba-doc/latest/reference/types.html?highlight=optional#optional-types

@esc Since all tests are passed, could you please change label on this PR?

@shssf apologies if I wasn't clear enough about this. From what I can tell, this function will allow None to be passed in. From what I understand, to do this correctly, you will need to use optional types:
http://numba.pydata.org/numba-doc/latest/reference/types.html?highlight=optional#optional-types
I'll see if I can dig out an example for you, but feel free to grep the code-base in the meantime.

@shssf I think the use case that @esc is alluding to is like:
from numba import njit

@njit
def foo(x):
    opt = 'z'
    if len(x) > 0:
        opt = None
    return x.strip(opt)

string = 'a'
assert foo(string) == foo.py_func(string)

which is not handled by the current implementation. In the code above opt is typed as an OptionalType (essentially a type union of "None or <some other type>"). As the .*strip() methods all have a default value of chars=None the code above is a perfectly acceptable use but is not handled. I think checking if the type of chars is an instance of types.Optional and then ensuring that if it is the type member is an instance of types.Unicode would work.

@esc Is this change expected?
def unicode_strip_types_check(chars):

    chars = chars.type if isinstance(chars, types.Optional) else chars

    if not (chars is None or isinstance(chars, (types.Omitted, types.UnicodeType, types.NoneType))):
        raise TypingError('The arg must be a UnicodeType or None')

@shssf that looks like the change I'd expect.

This looks good, @stuartarchibald shall we mark it for merge?

@esc Perhaps it might be a good idea to test optional types do indeed work?

@stuartarchibald yes, that makes sense, @shssf can you take care of it?

@shssf thanks for all your work on this. With view of getting it merged in time for the 0.44 release candidate I've pushed the missing tests for optional types onto your branch. Hope this is ok?
@esc please could you check the diff from 6cd0866 to HEAD and make sure you are happy with the changes. Thanks.

@stuartarchibald Thank you

@shssf no problem :)

This looks ready to merge.


It is not working and it is consuming huge amounts of memory

Hello,
This code is consuming tens of gigabytes of RAM and VRAM (more than 40GB of RAM and 35GB of VRAM) even though I only have one image in the folder.
Any reason why?
Then I get this following error;
(gaussian_grouping) C:\nerf\OmniSeg3D-GS>python run_sam.py --ckpt_path segment-anything\sam_ckpt\sam_vit_h_4b8939.pth --file_path data\teknikrum\images_2
Traceback (most recent call last):
File "run_sam.py", line 81, in
process_images(ckpt_path, files)
File "C:\Users\hu.conda\envs\gaussian_grouping\lib\site-packages\torch\utils_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "run_sam.py", line 62, in process_images
imwrite(paths[1], cm[indices].view_as(image).add_(image).cpu().numpy())
RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)
Any suggestions?

Hi, thanks for your interest in our work! I hope the following tips could help.

During running run_sam.py, it's common that images with high resolution may lead to high memory consumption. You can try to downsample the input images to 1920x1080 or similar resolution to see if the memory problem can be alleviated.

The device related RuntimeError can be fixed by changing the line 62 shown below. I have corrected this in the main branch.

# Before the change
imwrite(paths[1], cm[indices].view_as(image).add_(image).cpu().numpy())

# After the change
imwrite(paths[1], cm[indices.cpu()].view_as(image).add_(image).cpu().numpy())

Hope you have solved the bug! I will close this issue then.


[feature request] add line number for cmd/amtool output

What did you do?
amtool check-config
amtool check-config --verbose alertmanager.yml

What did you expect to see?
Showing error message with line number would be great
What did you see instead? Under which circumstances?
Checking 'alertmanager.yml'  FAILED: unsupported scheme "" for URL

amtool: error: failed to validate 1 file(s)

Environment

System information:
Darwin 19.4.0 x86_64

Alertmanager version: (this is the result of amtool --version)
amtool, version  (branch: , revision: )
build user:
build date:
go version:       go1.13.8

For example, this error happens when loading the config file.
https://github.com/prometheus/alertmanager/blob/a9d4a714943aa9b66145a43a5569e822dc2669b0/cli/check_config.go#L66-L72
Internally, it tries to parseURL(s string) but it fails with the error (in my case, it is because the string is an empty string and is not a valid URL schema). Those functions return error types.
https://github.com/prometheus/alertmanager/blob/a9d4a714943aa9b66145a43a5569e822dc2669b0/config/config.go#L86-L98
In order to pass along line numbers, I guess we should create a new struct as a wrapper for storing error context (e.g. line number, stack trace, file path, error itself, etc.). It'll require so many places to be changed for the current codebase.
What do you think?

This would depend on switching to the YAML v3 library, which we're not sure is a good idea yet as it seems that re-marshalling configs requires duplicating our many many config structs.

re-marshalling configs requires duplicating our many many config structs.

Yes that's what I am wondering so I've asked you before working on it.

This would depend on switching to the YAML v3 library,

It seems like v3 is now under active development 🚧  and the line number feature is still in discussion.

https://github.com/go-yaml/yaml/tree/v3
https://github.com/go-yaml/yaml/issues/626

The line numbers are there already with v3, the problem we're running in to is the re-marshalling if you use them.


docs: Adds reference docs for the Aspects dashboards and charts

Fleshes out the Instructor and Operator report reference documentation.
Uses existing "description" fields where found for charts and dashboards.

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.


Check build and deploy status

After the set up, deploy and teardown actions, check that the AWS state is what we expect.

Current DigitalOcean gives most of this (and has nice auto-fallback).


Add StorageProcess

Addresses issue: https://github.com/microbiomedata/nmdc-schema/issues/1908

move slots contained_in , temperature , duration to MaterialProcessing instead, so we don't create a separate class.

Thanks for working on this

Does storage satisfy the spirit of the textual description?

A process that takes one or more samples as inputs and generates one or more samples as outputs.

How about the definition of the broad mapping to OBI:0000094, 'material processing'

A planned process which results in physical changes in a specified input material

Maybe storage should be instantiated as a PlannedProcess and not a MaterialProcessing

In any case, the title of the PR should be changed

Well, my suggestion to instantiate PlannedProcess wasn't a solution, since PlannedProcess is abstract. I'm inclined to say that MaterialProcessing should be abstract, too. But that doesn't help close this PR.
I would like to move the ownership of duration and temperature up to PlannedProcess. (That doesn't help close this PR either)

I'm still not really happy with the semantics of MaterialProcess contained_in something. It seems like we're trying to say that something was contained_in somethign else during the course of the MaterialProcess, or at the end of the MaterialProcess

I'm looking for instantiations of MaterialProcess or usages of contained_in in MongoDB now.

I have a strong urge to say that we should have a Storage class, and that it should be a subclass of PlannedProcess.
What are the use cases for this class in terms of querying or informing workflows?

I have a strong urge to say that we should have a Storage class, and that it should be a subclass of PlannedProcess.
What are the use cases for this class in terms of querying or informing workflows?

Did you happen to check out the initial commit on this PR that modeled a "StorageProcess"?

@mslarae13 Based on the discussion, I think it is best to revert the commit that removed the StorageProcess class.

"spirit"?  I'm not sure what you mean here @turbomam. I think yes? You have 1 or more samples, and when you store them you're noting that it's a stored sample. Is it the generates? Cuz maybe aside from being 'later in time' there may be no changes?

Does storage satisfy the spirit of the textual description?

A process that takes one or more samples as inputs and generates one or more samples as outputs.

I don't like "results in physical changes" there's not always a physical change. You can air dry your soil and store it for years. The re-use it.

How about the definition of the broad mapping to OBI:0000094, 'material processing'

A planned process which results in physical changes in a specified input material

In any case, the title of the PR should be changed

To? "Modify Material Process to account for storage"?

I'm still not really happy with the semantics of MaterialProcess contained_in something. It seems like we're trying to say that something was contained_in something else during the course of the MaterialProcess, or at the end of the MaterialProcess

So, maybe we should put these on processed sample? but we still need something to indicate HOW we go from sample1 to sample2, which requires a process. I don't think NMDC needs the level of granularity that 'stored in' provides as a process. The use of this slot will be to identify "the data from this sample looks weird, oh because they stored it in a plastic that leeches" that's the only use I can find for this field.
So with how NMDC needs to use this metadata, what is the right choice?

I still disagree with a whole class for storage, because of how NMDC will use this data... It seems like added complication. But I will defer to @cmungall , @sierra-moxon , and @turbomam .
Additional class, or provide slots on existing class.

A problem from a data retrieval standpoint in moving the slots to MaterialProcesing and not creating a separate class is instantiating an entry for a MaterialProcess to indicate storage is not explicit, all we have to go off of is a material process that used a container for a certain amount of time. Is it good data handling to store data that is specifically indicating storage as an entry of a non-distinct class?

To do based on metadata meeting

[ ] provide a slot usage for substances_used
[ ] make this class a child of PlannedProcess instead of MaterialProcessing
[ ] use start_date instead of duration


rely less on macros

This makes the tool easier to maintain and extend for the future. Also, the future of GATs might allow some flexibility.

I solved this borrow issue by leaking


Use the random_name function on the name argument of the identity create command

Current behavior
The name argument of the ockam identity create command is calling hex::encode() to generate the random name in the default_value_t attribute.
Desired behavior
The name argument of the ockam identity create command should be calling the random_name() function.
Implementation details
Don't forget to import the random_name() function with use ockam_api::cli_state::random_name;.
This is the argument that must be changed, where default_value_t = random_name():
https://github.com/build-trust/ockam/blob/656f03e53415267ae9017f37dca8f44a04113b95/implementations/rust/ockam/ockam_command/src/identity/create.rs#L25-L26

Some tips for newcomers:

Create a new branch for the issue you are working on (don't push directly to your fork's develop branch)
Run cargo fmt. You can configure the editor to run it automatically everytime a file is saved
Run cargo clippy to make sure the code compiles + follows rust standards/best practices
You don't need to keep your branch updated with develop until there is a merge conflict. If you still want to update it, use git rebase develop instead of gir merge develop

We love helping new contributors! ❤
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

I want to contribute. Please assign me.


[WIP] Add RFC for MIT Learn data flows

What are the relevant tickets?
N/A
Description (What does it do?)
Adds an RFC for migrating data flows from Learn to the data platform

A few things to keep in mind:

While most "learning resources" are read-only as far as the end user is concerned, and created/updated/deleted only by the ETL pipelines, there is one exception: learning paths.  A learning path has child learning resources determined by the user (but only admins and a select group of users should have permission to create/update them).  The other resource types are: course, program, video, video_playlist, podcast, podcast_episode.

Admin users have the ability to edit any learning resource (or news/event object) directly in the django admin interface.  Not typically used except locally, but we should probably make this read-only if we go forward with the data platform approach.

MIT Learn allows users to subscribe to certain queries (like courses provided by OCW, for example), ie the PercolateQuery model in django (postgres.public.learning_resources_search_percolatequery tables in the db).  Whenever a learning resource that would be returned by this query is upserted, an email is sent to subscribing users.  Currently this is implemented as a pluggy function that is triggered whenever a resource is upserted.

Closing in favor of https://github.com/mitodl/hq/pull/5687


exporter incompatible with cassandra trunk (4.0)

When trying to collect metrics from trunk I've run into this:
WARN  [prometheus-netty-pool-0] 2019-05-01 15:22:18,501 Slf4JLogger.java:151 - An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.lang.NoSuchMethodError: org.apache.cassandra.utils.FBUtilities.getBroadcastAddress()Ljava/net/InetAddress;
	at com.zegelin.prometheus.cassandra.InternalMetadataFactory.localBroadcastAddress(InternalMetadataFactory.java:85)
	at com.zegelin.prometheus.cassandra.Harvester.globalLabels(Harvester.java:280)
	at com.zegelin.prometheus.netty.HttpHandler.sendMetrics(HttpHandler.java:283)
	at com.zegelin.prometheus.netty.HttpHandler.channelRead0(HttpHandler.java:91)
	at com.zegelin.prometheus.netty.HttpHandler.channelRead0(HttpHandler.java:36)

The call FBUtilities.getBroadcastAddress() was removed in process of making C* run multiple instances on one machine.  It should be replaced with FBUtilities.getLocalAddressAndPort

Yes, support for multiple newer & older versions of Cassandra is pretty much non-existent at this point.
We've been working on building a test framework that lets us verify that changes to the exporter codebase don't effect the output. Once that's complete we hope to refactor the code to support multiple versions.

OK.  Happy to help test it out once you've got something to hammer on.

Are there any plans to merge this exporter changes in to the main branch, so that it would be compatible with cassandra version 4.0?


Search with "not in" will act as "in" in 1.5rc1

I'm submitting a ...
[X] bug report
[ ] feature request
[ ] question about the decisions made in the repository

What is the current behavior?
I use multiSearch and a field with enum/items and I provide a list. When I select the items in the enum, the "in" works correctly, i.e. it keeps only the records that match the selected items in the enum. But when I select "not in", it behaves exactly like the "in" rather than keeping the records that don't match the selected items.

If the current behavior is a bug, please provide the steps to reproduce and if possible a screenshots.

Original list or records

Searched list with "in": expected behavior

Searched list with "not in": inverted behavior. I expected to get the "MyTest_2" as they are "not in" the selected set in the box.

The filtered records must be those that don't match the searched items in the enum because we ask for "not in" the items...
w2ui 1.5rc1
jQuery 2.2.4
Chrome 52.0.2... (not the last one, I'm working in a private/isolated network.)

fixed it in commit https://github.com/vitmalina/w2ui/commit/13a277a0f8ab04f3f5ff9941dab0e5f7f6b58226

Closing issue, related PR #1742 has been merged


Iban should not be mandatory when charging customer again for SEPA Direct Debit payments

Is your feature request related to a problem? Please describe.
According to the flow:
https://stripe.com/docs/payments/ideal/set-up-payment#submit-payment-method it is not needed to again provide the IBAN. However when confirming a payment intent for SEPA, IBAN is mandatory.
 private fun createSepaPaymentConfirmParams(): ConfirmPaymentIntentParams {
    val billingDetails = billingDetailsParams?.let { it } ?: run {
      throw PaymentMethodCreateParamsException("You must provide billing details")
    }
    val iban = getValOr(params, "iban", null)?.let { it } ?: run {
      throw PaymentMethodCreateParamsException("You must provide IBAN")
    }
    val setupFutureUsage = mapToPaymentIntentFutureUsage(getValOr(params, "setupFutureUsage"))
    val params = PaymentMethodCreateParams.create(
      sepaDebit = PaymentMethodCreateParams.SepaDebit(iban),
      billingDetails = billingDetails
    )

    return ConfirmPaymentIntentParams
      .createWithPaymentMethodCreateParams(
        paymentMethodCreateParams = params,
        clientSecret = clientSecret,
        setupFutureUsage = setupFutureUsage
      )
  }

Describe the solution you'd like
Support for the workflow of above

IBAN is mandatory for SEPA payments, otherwise the request will fail (and it's documented here), but the docs you linked are for Ideal. Let me know if I've misunderstood something here!


fuzz ParseAKV

Further fuzz tests could test round trip etc

This does only add the entry point for fuzzing, not the actual fuzzing, correct?
I haven't kept fully task of recent fuzzing changes in Go.

@AnomalRoil Shall we try to get covered by oss-fuzz? I'm not sure if we meet the bar, but we can try.


SCC: caption management refactoring

SCC reader refactoring proposal, addressing https://github.com/sandflow/ttconv/pull/383 & https://github.com/sandflow/ttconv/pull/385 issues

@atsampson @rktcc Your feedback would be welcome on this PR.

@atsampson @rktcc Did you have the opportunity to review? The plan is to merge this PR sometime next week.


Bump version to 1.12.0

Update the Rust client to the latest Qdrant release.

Before we merge I'd like to fix this protos panic first, because I think it's more annoying than helpful

We shall merge https://github.com/qdrant/rust-client/pull/191 first. Then cherry-pick it into master and rebase this PR.


Support channel definitions from /file/list_homepage

Modify doFetchFeaturedUris to support working for channels.
Currently, the following URL returns the content to be displayed on the app homepage:
https://api.lbry.io/file/list_homepage
If the object key begins with an @ (indicating a channel) and the listed content array is empty, doFetchFeaturedUris should call channel_list to return the 10 most recent items in that channel.
Additionally, if the object key begins with an @, the subscribe button should be shown next to the channel name.

@reillysmith

So I dug into doFetchFeaturedUris and got down to lbry.js and jsonrpc.js and now understand much better what all is going on. It took me a while to grok that Proxy mechanics are handling methods not explicitly stated in lbry.js. I think @kauffj meant claim_list_by_channel rather than channel_list as I was able to hit that endpoint on the daemon with Postman. I see two ways of doing this.

A) modify doFetchFeaturedUris to also include channelsToResolve; use an if statement to update URI and channel lists accordingly
B) use Lbry.claim_list_by_channel to get URIs for each channel name
C) put relevant data into urisToResolve
D) and let doResolveUris get the claim info for channel content along with the rest of the featured content it's already grabbing
or 2) call doFetchClaimsByChannel in the 1A if statement when the category is a channel and sort it all out in the view
I think 1 is simpler from a data model perspective but would be slower because there may be multiple channels each of which would make its own RPC before making the one big RPC for all the info. I think 2 would be faster but more complex putting the data back together.
I also think I may be overthinking this. Please advise.
@seanyesmunt @liamcardenas

@daovist yes, I did mean claim_list_by_channel.
I agree these are the two approaches. Approach 2 is probably more "proper" or "React-like".
That is:

Refactor FeaturedCategory to be a standalone component.
If FeaturedCategory receives a channel name but no URIs, call out to doFetchClaimsByChannel to receive them.

It may make sense to refactor other names here a bit as well (e.g. FeaturedCategory takes "names" currently, but "uris" is a more appropriate term).
You can look at page/channel for inspiration.

Fixed in : https://github.com/lbryio/lbry-app/pull/1267


Trying to use PhysicalMaterial without lights crashes the program

I was trying to get some three_d code to work by copying and pasting different bits of your examples together (employing the rightfully disdained "cargo cult programming").  In the process I copied some code using PhysicalMaterial from the shapes demo into a rendering main loop that's mostly based on the screen demo, and my code started crashing with this error message:
the attribute normal is sent to the shader but not defined or never used
(from src/core/program.rs:621)
It took me a while of debugging, but stepping through, I can see that the vertex shader defines USE_NORMALS and looks correct; but my code (based on the screen demo) never adds any lights, which means that the fragment shader output doesn't actually depend on the "nor" input, which I think means the driver decided that there's no point in computing "nor" or reading "normal" in the vertex shader.  And indeed, the compiled vertex shader only reads one attribute, "position".
I'm not sure if there's anything you want to fix; after all, the problem was arguably my fault.  But how about adding something like this in physical_material.rs:fragment_shader_source() (untested):
if lights.is_empty() {
panic!("PhysicalMaterial does not work with no lights defined");
}

Thanks for reporting. I guess you're on Linux? The Linux shader compiler is a bit more aggressive than on other platforms and since I'm not using Linux it's hard for me to test.
It is actually an easy fix, we should just not send normal attribute when there's no lights. The easy solution would be to use Program:: requires_attribute to check whether the normal attribute is required before sending it. If you can do a PR with that change, I'll be happy to merge it.


build: migrate ngx-deploy-npm to v8

Updating ngx-deploy-npm to v8 to support nx19.
ngx-deploy-npm v8 introduced some breaking changes. This PR applies the migration scripts and other necessary changes to adapt version 8 properly.
More information about V8 changes can be found in the blog post What's coming to ngx-deploy-npm V8
Here you can find another PRs upgrading ngx-deploy-npm to v8
https://github.com/jscutlery/semver/pull/772
https://github.com/ngworker/lumberjack/pull/198
https://github.com/code-pushup/cli/pull/427

Thanks for this PR! I just have one remark that is unfortunately blocking the PR, could you take a look?


Commit with branchName=None

Expected vs. Actual Behavior
When a commit is fetched using client.commit.get(), it gets assigned a proper value for the branchName attribute. However, when it is fetched using client.commit.list(), branchName is only set to the default value None.
Reproduction Steps & System Config
specklepy v2.4.2

Create commits in one or more branches on a stream.
Fetch the commits on the stream, e.g. commits = client.commit.list(stream_id=stream_id).
Print the branchName attribute, e.g. for commit in commits: print(commit.branchName)

Proposed Solution
The branchName attribute is missing in the gql query in client.commit.list().
I have added it and tested it locally, and am happy to create a PR.

hey morten, nice to see you around here 😊
oopsie good spot - totally just missed it in the query! i've just popped it in and added it to the commit model repr for fun.
you should be able to install v2.4.3 with this fix very soon. thanks a lot for spotting and reporting this issue! 🚀


Register GuardRails programmatically

Currently, we can only (or as far as I know) register guardrails with annotations. This is great, but some guardrails might need to register programmatically for better reusing. For example:
new BanTopicGuardRail("politics");

In one model but in another model, we might want to add a GuardRail like
new BanTopicGuardRail("politics", "economics")

Both models are in the same project.
The same is true for a threshold. In one case, you might want a more restrictive threshold than in another, so the only thing you might change is the value of the constructor.
There are some workarounds, like creating one subclass for each topic to ban, but I think it is better to use a programmatic approach.
One option could be to provide a default method in the @RegisterAi interface, so if you provide an implementation, these guardrails are appended to the ones defined declaratively. I know that here, the default method affects all the defined methods, and you cannot programmatically create guardrails for specific methods, but at least you can register guardrails programmatically.
Moreover, this default method should add the beans into the CDI container.
It is just an idea on how to implement it, but I wanted to put the problem users might face.

I need to think about it. The programmatic approach you propose would add guardrails that are not CDI beans (you instantiate them), so I would instantiate them on every call (like a request scope guardrail).
I'm wondering if we cannot achieve something similar with pure configuration.

One potential approach (that we use elsewhere in the AiService registration) is to use a supplier which is itself a CDI bean, this allowing you to create whatever you want easily

@geoand  If we start taking two approaches (supplier and direct bean) to register guardrails, how can we preserve the order? (The order is very important.)
@lordofthejars If you can produce the guardrails like this, why do you need a programmatic approach? You just need a custom class name. No?

If we start taking two approaches (supplier and direct bean) to register guardrails, how can we preserve the order? (The order is very important.)

We could have a Supplier<SomeTypeThatIncludesAPriority> or something like that

No because the class is always the same, what changes are the parameters. For example the threshold, the ban topics, ...

We could have a Supplier or something like that

It would require guardrails to also include a priority, and also provide a quite confusing experience:
@OutputGuardrails(a.class, b.class, c.class)

may end up being (based on priority):
c.class, a.class, b.class

That would require a large API change, as it would need a repeatable @OutputGuardrail taking a single parameter instead of an array with a defined order.

No because the class is always the same, what changes are the parameters. For example the threshold, the ban topics, ...

Then, I don't see how I can register them as CDI beans. It will be ambiguous for the given type (2 beans exposing the same classname).

IMO, the result, should not be a CDI bean - we should follow the same approach as we do with the suppliers that can be used in @RegisterAiService

That would require a large API change, as it would need a repeatable @OutputGuardrail taking a single parameter instead of an array with a defined order

But that shouldn't be a problem given the API is still experimental, right?

No it's not a problem to change it right now.

Ah, I remember something (well, my notebook did remind me) - I did not use priority to avoid having a dependency on jakarta common annotations (in order to contribute this back to langchain4j)

That shouldn't be a problem really because @Priority is in jakarta.annotation which only contains annotations, no logic.

I said CDI as an idea but of course al of you know better the details on what is the best way to implement.
About Priority, is it a problem to create a custom annotation?