KeyError: "name='csrftoken', domain=None, path=None

I've authorized the gcloud default-application login through
gcloud auth application-default login
But when I run python3.11 -m memrise_audio_uploaderploader
It still gives me the error in the title.
Error printout:
Using stored password
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in _run_code
File "/usr/local/lib/python3.11/site-packages/memrise_audio_uploader/main.py", line 16, in
main()
File "/usr/local/lib/python3.11/site-packages/memrise_audio_uploader/cli.py", line 141, in main
memrise_client = memrise_login()
^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/memrise_audio_uploader/cli.py", line 37, in memrise_login
memrise_client = memrise.MemriseClient(settings.memrise_username, settings.memrise_password)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/memrise_audio_uploader/lib/memrise/client.py", line 176, in init
self._login(username, password)
File "/usr/local/lib/python3.11/site-packages/memrise_audio_uploader/lib/memrise/client.py", line 212, in _login
"csrfmiddlewaretoken": response.cookies["csrftoken"],
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/requests/cookies.py", line 334, in getitem
return self._find_no_duplicates(name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/requests/cookies.py", line 413, in _find_no_duplicates
raise KeyError(f"name={name!r}, domain={domain!r}, path={path!r}")
KeyError: "name='csrftoken', domain=None, path=None"

Hi @aodecipher! It seems that Memrise has updated their login API and removed some old endpoints. I'll need to reverse engineer the new API endpoints to get this working again.

Memrise had updated the login code and removed the endpoint that was used for listing courses. The latest release fixes these issues.


Mismatch between design and development on organizm components (cards & lists) on mobile iOS and android

Duplicates ❌

[X] I have searched the existing issues

Which Figma library is concerned?
Vitamin Web UI Kit
Current behavior 😯

On android they decided to just give the container of the card while on development side we have differents variants.
So it's more restricted on the design side. (

Moreover on some variants there are differences between the platforms like on side image variants :

Expected behavior 🤔
We should be ISO dev<>design.
The card can be hard to use on the figma side, whereas if in mobile development it's hyper permissive it's not fair!
We need to decide and discuss @Sabrinavigil and @SimonLeclercq.
I propose to add a container variant on the 3 platforms to help designers consume the card better.
Context 🔦
No response
Screenshots / Videos 📸
No response

@Sabrinavigil @MARIEDELATTRE any news on this topic?

We need to add a basic container on the 3 platforms and keep others variants like on web for this version.

Grooming session decision:
We close this and this will be took in the next major release.


fix(e2e): Improve max build limit E2E test

Wait for IntegrationPlatforms in user namespaces to become ready before starting new builds
Avoids racing conditions on build and integration platform reconciliation loops
Avoids 1st build to succeed before 3rd build has been scheduled (skips the max build limit)

@squakez can we please merge this one? 🙏  I would need it for other PRs


Create: 1512-number-of-good-pairs.go

File(s) Modified: 1512-number-of-good-pairs.go
Language(s) Used: go
Submission URL: _https://leetcode.com/problems/number-of-good-pairs/submissions/1273619463/_

@galfudim Thanks for your contribution 👍


#2301 Unable to set minimum TLS version

https://github.com/mysqljs/mysql/issues/2301
Since Node 9 and before don't support min/max version these won't be set and the tests won't fail for those versions.
Node default TLS version is set to 1.2 for tests as Node 10 has not enabled support for 1.3 by default.
Tested against mysql 5.5 and mysql 8 servers

@dougwilson Do you know when we'd be able to get this merged?

Apologies, I will review today.

@dougwilson Thx for review 👍 Making some ammendments now, not sure if I understand what you mean about how i'm generating the test SSL config

@alexburley

@dougwilson Any luck?

@dougwilson Any update on when this can be merged?

Hello,
Can anyone review this PR @alexburley @dougwilson ? It seems that a lot of people have the same problem and this PR is going to solve it!

Sorry this fell off my radar. Thanks for the ping I will push it forward tonight

Just found this -- excited to see the work done already!
It has come up as an issue with our mysql integration in Beekeeper Studio. Think it's the cause of https://github.com/beekeeper-studio/beekeeper-studio/issues/254

@dougwilson Is there anything I can do to help get this PR merged?

@alexburley @dougwilson Can you please provide an update about whether this PR is going to be merged or not?
Thanks. Again...I am happy to help out if needed.

@dougwilson Hey, is there a chance this could be looked at? If you need some help with it, I'm happy to help out


Why does PG sometimes break and have to re-build Turing to resolve?

I haven't seem this problem before. Maybe this is caused by #247? Do you have a reproducible example?

I have seen this problem before that PR, from time to time. I will show you next time I get into that again.

NOTE:
signal (11): Segmentation fault
while loading /home/kai/projects/Turing-exps/amazon-talk/HMM.jl, in expression starting on line 22
jl_eh_restore_state at /home/centos/buildbot/slave/package_tarball64/build/src/julia.h:1506 [inlined]
jl_pop_handler at /home/centos/buildbot/slave/package_tarball64/build/src/builtins.c:236
wait at ./event.jl:170
schedule_and_wait at ./event.jl:116
unknown function (ip: 0x7f1c6425282a)
jl_call_method_internal at /home/centos/buildbot/slave/package_tarball64/build/src/julia_internal.h:210 [inlined]
jl_apply_generic at /home/centos/buildbot/slave/package_tarball64/build/src/gf.c:1950
produce at /home/kai/.julia/v0.5/Turing/src/trace/taskcopy.jl:68
unknown function (ip: 0x7f1c6c0fdb26)
jl_call_method_internal at /home/centos/buildbot/slave/package_tarball64/build/src/julia_internal.h:210 [inlined]
jl_apply_generic at /home/centos/buildbot/slave/package_tarball64/build/src/gf.c:1950
macro expansion at /home/kai/.julia/v0.5/Turing/src/core/compiler.jl:34 [inlined]
#HMM_model_##35079#4 at /home/kai/projects/Turing-exps/amazon-talk/HMM.jl:18
unknown function (ip: 0x7f1c64250c9d)
jl_call_method_internal at /home/centos/buildbot/slave/package_tarball64/build/src/julia_internal.h:210 [inlined]
jl_apply_generic at /home/centos/buildbot/slave/package_tarball64/build/src/gf.c:1950
#HMM_model_##35079 at ./<missing>:0
#3 at /home/kai/.julia/v0.5/Turing/src/trace/trace.jl:65
jl_call_method_internal at /home/centos/buildbot/slave/package_tarball64/build/src/julia_internal.h:210 [inlined]
jl_apply_generic at /home/centos/buildbot/slave/package_tarball64/build/src/gf.c:1950
jl_apply at /home/centos/buildbot/slave/package_tarball64/build/src/julia.h:1392 [inlined]
start_task at /home/centos/buildbot/slave/package_tarball64/build/src/task.c:254
unknown function (ip: 0xffffffffffffffff)
Allocations: 113757045 (Pool: 113547491; Big: 209554); GC: 309


fix(tests/falco): invalid rule names must return error when described

This change unblocks https://github.com/falcosecurity/falco/pull/2934. That PR makes the behavior of the description feature consistent in case of invalid rule by always returning an error. Before, we used to return an error with JSON output and an empty output with text output.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Tests for EVP KEM API (positive and negative tests).

Adds tests for EVP KEM API (positive and negative tests).
Adds a negative tests for EVP Signature API.
Fix in hybrid KEM registration -> don't register X448 hybrids with 256 bit security (as already done with the TLS groups).
One thing I noticed while running the negative KEM tests (with modified ciphertext): HQC is the only KEM that returns an error code when decapsulation fails. The other KEMs only allow an implicit check if decapsulation was successful by comparing the original with the decapsulated message, while the return code is always OQS_SUCCESS. This is mainly to prevent leaking information.
As with the negative KEM tests in liboqs, the tests here let both behavior pass. But we may want to document this behavior or add an extra test for it.
Fixes #57

Would it be reasonable to add an explanation (explicit list?) to the README regarding the hybrids supported by oqsprovider (as for L1 & L3 there's now still the additional X... hybrids that are not supported/mentioned at https://github.com/open-quantum-safe/openssl#supported-algorithms that we otherwise link to)?

I added a description to the README about the additional x25519/x448 hybrids, similar to the description in OQS-OpenSSL.

Finally, I'd definitely suggest adding wording/warning that the algorithms (except HQC as you state) effectively don't support the OpenSSL API (not returning an error code when they failed) -- I'd be fine not mentioning this if there'd be wider agreement that "silent failure" is an acceptable security feature, e.g., by adding an explicit statement to this effect to https://www.openssl.org/docs/manmaster/man3/EVP_PKEY_decapsulate.html) .

Yes I agree. For now I added a note to the README. Will open an issue in OpenSSL about the specification of the decaps API.


Vscode Settings for Runner don't work

Hey Franneck, I hope I didn't bother!
I want to add gcc args "-fexec-charset" and "-mwindows"  as a default setting in the .vscode auto-generated by C/C++ Runner.
But I found it not working to set Compiler Args and Warnings of C/C++ Runner in Settings of Vscode.
I don't know if it's a bug or the way I configured it was wrong.
And here are the imgs of my configurations:

You must edit the local .vscode/settings.json file and not the user settings

Thanks for your attention!
So I request for the functionality of editing default configuration which could be loaded to generate local .vscode files if possible.
Thank you for providing such a convenient extension to the c/c++ programmers with vscode.

Should be fixed in 4.0.0


Reduce dependency on loop

As shown in aiohttp, Server can be coupled with loop in a looser way, so that it is easier to write code with loop-replace-ability in mind, like creating Server instance at module level without specifying a loop instance and only pass in one when needed (make_handler).
Also added a Flask-style handy route decorator

@fantix aiorest project is abandoned, sorry.
If you need asyncio-compatible web server please use aiohttp.web directly.
Flask-style global application object and @app.route will never appear in aiohttp though. I consider the both as sings of bad software design.


About the training process of spatial guidance

Hello, I have a question about the training of spatial guidance.
The sampling process of spatial guidance is well described in your paper.
But I'm confused on the training process.
The function is as follows：
def guide():
x_t = self.q_sample(x_start, t, noise=noise)
x_t = self.guide(x_t, t, model_kwargs=model_kwargs, train=True)
model_output = model(x_t, t)
Could you explain why you put  self.guide here?
Is that a theoretical approach or empirical approach?
Waiting for you reply.   Thank you

Hi, Thanks for your interest in our work. It's more like an empirical approach. As mentioned in the paper, the spatial guidance only amends the position of the controlled joints and pelvis, and the learnable realism guidance is used to amend all other joints to ensure natural and reasonable human motion. So during training, we put spatial guidance before realism guidance to enforce the realism guidance can learn to amend the human motion which has been edited by spatial guidance.

Thank you very much ~!


Error expanding database nodes disconnects entire session

Version: 1.44.0-insider (user setup)
Commit: a9951e977c8a706930171149de5e12d281059b38
Date: 2023-04-20T16:11:04.794Z
VS Code: 1.70.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
(not a regression it seems)

Connect to a server with multiple databases
Try to expand database that you don't have access to

The connection errors out, but then the whole server connection is put in a sort-of disconnected state.

Related issue: https://github.com/microsoft/azuredatastudio/issues/22211

Closing as duplicate of https://github.com/microsoft/azuredatastudio/issues/22211


GCMDevice.send_message() returns after 2 minutes

Lately I am having issues with sending messages. The call takes about GCMDevice.send_message(mySerializedJsonString) takes about two minutes to complete.
I debugged it down to(gcm.py):
urlopen(request).read()

So it really seems Google not responding or the request being somehow wrong. I send about 10 messages / day / device in a test environment (about 2-3 devices). Therefore I assume it can not be the Android throttling.
After urlopen returns, the message is delivered almost instantly.
Is anyone else experiencing this issue? Does someone have any idea how to debug this further?
I am on 1.2.1

Closing old unanswered questions.


DRY up how attribute keys are decamelized

Once https://github.com/elwayman02/ember-data-github/pull/53 lands we should refactor all the serializers such that the base github serializer overrides keyForAttribute and calls decamelize on each attribute, removing the need to do it for each property one-by-one in each model's serializer.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37628576-dry-up-how-attribute-keys-are-decamelized?utm_campaign=plugin&utm_content=tracker%2F15732968&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F15732968&utm_medium=issues&utm_source=github).

👍


[Misc] Add quantization config support for speculative model.

Currently, we are not able to specify the quantization method for the draft model. Yet when we set up an INT4 gptq-based draft model, vllm will automatically use gptq_marlin to config the quantization and may raise some errors such as
ValueError: Marlin does not support weight_bits = uint4b8. Only types = [] are supported (for group_size = 128, min_capability = 70, zp = False).
This pr adds a config arg so that we can explicitly specify the quantization method for the draft model.

I think (#7240) is a related issue. The difference is that this is about the draft model and we are not able to explicitly specify the quantization method for the draft model to work around currently.
I believe whether (#7264) address this bug of marlin or not, we still need this feature in case anything happens again.
@robertgshaw2-neuralmagic  Do you have time to check on this pr?

Can you update to latest main? We fixed this issue so it should automatically detect that marlin is not supported on 75

Can you update to latest main? We fixed this issue so it should automatically detect that marlin is not supported on 75
otherwise, what is the use case for explicitly setting the quantization ?

Yes, the main branch version is back to normal. Awesome work for the quick fix.
Regarding explicit specification of the quantization method for the draft model, it is not a must since there is an automatic detection mechanism for now, but being able to explicitly specify it can be a fallback plan in the production environment version compared to not being able to do so. In addition, when vllm supports configurable quantization of the full-precision model at runtime, the draft model can also have such flexibility since the draft model is way more latency-sensitive.
Finally, there is a 'TODO' in the source code of config.py, informing us that we might need this.
        # TODO: The user should be able to specify revision/quantization/max
        # model len for the draft model. It is not currently supported.

I think the quantization config is the most urgent one since we cannot work around this issue for v0.5.4 this release version and have to revert to the earlier stable version.

Sounds reasonable. Can you add a test case?

Sounds reasonable. Can you add a test case?

Sure. But I am not sure where I should put the test code in. Is it suitable to add this in the tests/test_config.py?

You can add a test here: https://github.com/vllm-project/vllm/blob/main/tests/spec_decode/e2e/test_integration.py

Can you add a test case?

@robertgshaw2-neuralmagic The test has been added. Since the changed code simply passes the user's configuration during the initialization process of draft_model_config, these tests of e2e integration should be sufficient.

@DarkLight1337 Sorry to bother you. Do you know how to retrigger only the test for 'ci-aws/pr/2-node-tests-4-gpus-in-total'? I can't find a way to do this. Some 'ci-aws' tests seem to be unstable, and retriggering all the tests might be a bit of a waste of money.

The test is broken right now, I'll ask someone to force-merge the PR.


Add SQS Sample (#508)

A simple example sending and receiving a message with SQS and CDK infrastructure.
Fixes #508.

We can add more samples later if that's the case - at least everything is set up. Let me know if you have any suggestions!


Cross-mod problem with Dr Cyanos' Lootable Bodies

Dr. Cyanos' Lootable Bodies
With "Drop as Block on Death" enabled, the backpack will spawn next to the corpse, but a duplicated backpack will be in the corpse's inventory.
With it disabled, the items in the backpack can be destroyed if their inventory doesn't have enough room for its contents.

This doesn't seem to be a problem in the latest version. If it re-occurs, please reproduce with 3.1.3.


Show the exact point of conflict instead of making the world path red

Pre- requisite
Have the websocket server use an API to determine the time of conflict and communicate this to the front end. With the time of conflict, you should be able to determine the position of conflict for each of the conflicting trajectories
Discussion
Two trajectories from participants A & B  are in conflict if A's Profile::footprint when swept along A's trajectory overlaps with B's vicinity swept along B's trajectory or vice versa. This can be checked using this API
Checking for matching pair of (x,y) segments between two trajectories is not a good approach

Trajectories are represented as a collection of cubic splines which are interpolated between these segment knots. Hence, two trajectories can intersect in between these segment knots.
While a set of segments may overlap in position, they may not do so in the time domain which can lead to incorrect conflict assumption with the above approach.

Afik the time of conflict is not reported in any of the messages published by the rmf_traffic_schedule.
As a solution, we have have the websocket server use the above mentioned API to determine the time of conflict and communicate this to the front end. With the time of conflict, you should be able to determine the position of conflict for each of the conflicting trajectories. Let me know what you think.
Originally posted by @Yadunund in https://github.com/osrf/romi-dashboard/pull/40#issuecomment-649438833

iirc, this requires support in the trajectory server and there is nothing we can do for now. There hasn't been any updates for a long time so I'm closing this now.


fix bandwidth kbps caculate bug

Fix issue #2519
fix kbps bandwidth calculate bug

Codecov Report

Merging #2648 (9666608) into 4.0release (9d54bcd) will not change coverage.
The diff coverage is 0.00%.

:exclamation: Current head 9666608 differs from pull request most recent head fcb66c3. Consider uploading reports for the commit fcb66c3 to get more accurate results

@@             Coverage Diff             @@
##           4.0release    #2648   +/-   ##
===========================================
  Coverage       59.52%   59.52%
===========================================
  Files             122      122
  Lines           51722    51722
===========================================
  Hits            30788    30788
  Misses          20934    20934

Impacted Files
Coverage Δ

trunk/src/app/srs_app_bandwidth.cpp
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d54bcd...fcb66c3. Read the comment docs.


Copy from template if the entry is empty

This PR is related to the feature request on issue #7
if diary-manager-template is defined, use that specified file as a reference for a new diary entry.
Requirements:
The filename defined on diary-manager-template will have to use the same extension defined at diary-manager-entry-extension; if it doesn't exist, then the new entry will be empty

I'm using it with encryption. The way I have defined it, the template is with the same format (extension); I mean encrypted, too, in my case.
Inserting the content instead of copying the file will make the template format independent from the diary entry.

Ah, fair enough. I do like making it format-independent, though, so thanks for the update. I made some further changes in https://github.com/radian-software/diary-manager/pull/8/commits/602ae15f4960207775a733c44141c71aa41f161a for style.


feat(cli,recs,std-client): update RECS components with v2 key/value schemas

and move custom RECS schema type default from undefined to unknown
pulled out of #1113

Is this a breaking change in any way?

I don't think so? If you're using plain RECS, this shouldn't have any impact. It was only Sky Strife (they overloaded component.id and other things) that would break.


Added optional symbol param in fetch_open_orders

Certain exchange requires symbol as mandatory parameter and currently ccxtbt does not permit user to pass in symbol parameter.
The fix is to address "Param validation for 'symbol' failed on the 'required' tag".

Looks good and low risk - so accepting. Thanks!


update figure captions

(note that figure caption edits don't show up in the rich diff)

Good catch. I forgot we made those route numbers ourselves.  Merging now.


Update: HSQ questions init data

Hello, this PR aims to update the questions for Humor Style Questionnaire.
What's changed:

backend/questionnaires/migrations/0003_initial.py: update migration file for initial questions for HSQ questionnaire
backend/questionnaires/migrations/0007_auto_20230309_1630.py: add function update_humor_style_questionnaire() to update HSQ questions

@all Hello, I've tested again with production env in my computer and as Piotr said last time it's correct that if I change the init migration files, it could be not updated and required delete the whole table to migrate again. Since when we run migration there is nothing change in the model, but only changes in data. I forgot that case :sweat_smile:
Therefore, I created a new migration file to alter the rows needed to be update and replace those rows with new data. Then when we deploy the new version, the python manage.py migrate will recognize the new file to be migrated and execute the changes.

Thank you for the changes xD  I have tested it as well and it works, so approved :3


⚠ Bofrost.es has degraded performance

In 73469ec, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1597 ms

Resolved: Bofrost.es performance has improved in 14b708e after 6 minutes.


LAPACK++ Doxygen link is broken in README.md

Currently the link LAPACK++ Doxygen in the README points to icl.bitbucket.io/lapackpp/ which is no longer online. Is there an up-to-date repository with the Doxygen build for this library?

I don't know what happened, but the website is working again now. Apparently an issue at Bitbucket.


Invalid formatter value

Invalid first value in formatter with datapicker field
Similar formatter with text input works fine
Short example
Look console logs
P.S.
In this example I noticed one more bug:
initial value datepicker is not formatted
I got Tue May 17 2016 18:25:03 GMT+0300 (EEST) but have to 2016
I check datapicker same version without formly and it works fine (example)
I suppose formatters not calling first time when template initializing.
For example input[type=number] throw error if initial value is a string

In this example I noticed one more bug:
initial value datepicker is not formatted
I got Tue May 17 2016 18:25:03 GMT+0300 (EEST) but should 2016
I check datapicker same version without formly and it works fine (example)

I suppose formatters not calling first time when template initializing.
For example input[type=number] throw error if initial value is a string

Somebody fix it? I published this issue a week ago and no activity yet!

Two weeks...
Nobody care?

Month... Support are worse that I ever met!
Good idea, but bad implementation.

Bug with datepicker: the reason in order of formatters.
Datepicker from angular-ui add own formatter (which parse date).
Angular-formly formatters add after that and get value already formatted by datepicker's formatter.
My solution is remove formatter/parser from formly and do transformation in controller
I hope this will help somebody.

@Blaze34 - sorry for being late to the party. I have written a provider and use that to do my parsing. In the provider I do date validation and formatting with MomentJS.
In my formly field setup:
parsers: [(value) => { return this.regexProvider.formatDate(value) }]

and then in the provider:
formatDate(value) {
        // validation checks etc...
        return this.moment(value).format('DD/MM/YYYY');
}

@david-potgieter thank you for sharing!
@Blaze34 this is an open source project, people dedicate their free time to contribute. You can always solve the bug yourself and submit a PR, that'd be much appreciated. Thanks!


#930 - split cars evenly

This is the functionality requested on the issue #930 .
I didn't do it on the "championship" functionnality, only custom race.
It's my first lines of code with Go, I hope I have not done any mistakes.

Hi! Thanks for your contribution. I have spotted that your build currently is not working. If you click on "details" next to the "continuous-integration/travis-ci/pr" field (on this page) it will show you what is not working with your build, so you can fix it. When you've got a passing build, we can take a look at the code and review it!

Hi,
Sorry, there was still some things I did not know about the compilation. It should be good now. All checks passed. I have added some comments so you can understand the algorithm and check if everything is fine for you.

I've gone ahead and put these changes into #990 which will fix #930. Thanks for your contribution!


Draw Marine Labels by Hand

We should draw the marine lines for the labels by hand.

I have drawn 30+ lines.
Sadly a lot of marine labels are not present in OSM data. For these ones I just searched for the local name and added them by hand (but no other translations).
The red circles are not in OSM for example. http://rastertiles.osm2vectortiles.org/osm-bright/#6/16.541/-72.861

There is one bug #85 occuring that perhaps because the line is too long.
But apart from that I think lines are ok. We can still add more improvements later on.


Fix bug allowing the selection of a date after the max date when swit…

Fix a bug that would allow the user to select a date later than the maximum possible date when switching to the next month.
This issue was brought up as the issue #98.

Thanks, will release an npm of it right now.


Undefined stanzaObj on raw:incoming event

I am getting an Uncaught TypeError: Cannot read property '_name' of undefined that is thrown at this line https://github.com/legastero/stanza.io/blob/master/lib/transports/websocket.js#L68 because stanzas.parse(data) in https://github.com/legastero/stanza.io/blob/master/lib/transports/websocket.js#L58 returns undefined and doesn't throw an error.
When inspecting the event data I get this:
<iq type="get" from="<host>" to="<user>@<host>" id="tigase-ping">
  <ping xmlns="urn:xmpp:ping"/>
</iq>

Is there any possible way to fix this issue?

@ianngiaw did you find a solution to this issue?

I've seen this a lot. stanza.io throws this when it's unable to parse a xml stanza. It does not throw an error where it should be, the code goes further and it tries to access properties of undefined.
I'll find the code path quickly.

This is where it fails: https://github.com/legastero/stanza.io/blob/adbf184ae1df57d7c94dd8b00eee01e04514cabf/lib/transports/websocket.js#L57-L68
Notice that we are in a try / catch. The try failed, but stanzaObj remains undefined

ok. I just checked out this https://github.com/legastero/stanza.io/blob/master/lib/transports/websocket.js#L68 as referenced by @ianngiaw. I'm using https://github.com/xmppjs/xmpp.js/ as my xmpp server

@Robophil I still haven't been able to find a solution to this issue.

No problem @ianngiaw. I ended up using this worked fine for me.


no exception catched from Django management command

according to this example:
https://github.com/getsentry/raven-python/blob/master/examples/django_110/app/management/commands/example.py
there is nothing special to do when creating a management command, but my exceptions are not logged :/
im using Django 1.11.1 and the example command above

adding those two lines to my command:
from raven.contrib.django.raven_compat.models import client
client.captureException()
results into this exception:
Traceback (most recent call last):
File "manage.py", line 27, in
execute_from_command_line(sys.argv)
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/django/core/management/init.py", line 367, in execute_from_command_line
utility.execute()
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/django/core/management/init.py", line 359, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/django/core/management/base.py", line 294, in run_from_argv
self.execute(*args, **cmd_options)
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/django/core/management/base.py", line 345, in execute
output = self.handle(*args, **options)
File "/Users/andy/projects/GuK/core/management/commands/run_msb_client.py", line 11, in handle
client.captureException()
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/raven/base.py", line 799, in captureException
'raven.events.Exception', exc_info=exc_info, **kwargs)
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/raven/contrib/django/client.py", line 292, in capture
result = super(DjangoClient, self).capture(event_type, **kwargs)
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/raven/base.py", line 615, in capture
elif not self.should_capture(exc_info):
File "/Users/andy/.virtualenvs/GuK-WKWTomJd/lib/python3.6/site-packages/raven/base.py", line 803, in should_capture
exc_name = '%s.%s' % (exc_type.module, exc_type.name)
AttributeError: 'NoneType' object has no attribute 'module'

This looks like you're trying to capture an exception when there is no exception to be captured.

@mattrobenolt im raising the Exception right after
client.captureException()
putting the capture command below the possible exception position aint making any sense since that position wont ever be reached by the python interpreter.
Like i said im using the example command, which i linked above, and since its not working in the vanilla version i put those two lines in the middle .. so we got the following result:
from django.core.management.base import BaseCommand

class Command(BaseCommand):
    help = 'Examples'

    def handle(self, *args, **options):
        from raven.contrib.django.raven_compat.models import client
        client.captureException()
        raise Exception('oops')'''

Right, and the code you posted won't work becasue there's not a current exception happening. You'd need to do that inside of an except.
Something like:
try:
  raise Exception('oops')
except Exception:
  client.captureException()

As for why it's not happening automatically, I'm not sure. I don't think we've tested against 1.11 to see if behavior has changed any. I'd have to spend some time to investigate.

Okay, your solution works, but this kind of defeats the whole purpose of automatically catching  any exception :/
I just downgraded my installed Django version to 1.10.7 with the same result of not reporting the error. Inside a view it works tho.

Yeah, agreed. :) What version of raven do you have installed? At some point, we did have this broken, then we fixed it.

i have version 6.0.0


Be more tolerant with clock annotations and tags

See mliebelt/PgnViewerJS#269.
This came from an invalid format due to the spec of [TimeControl "60 mins"].
Do the following:

[ ] Ensure that any TimeControl can be specified without an error.
[ ] Emmit an error message, that allows to handle those games later when doing strict / sloppy parsing

I had to tryout the new feature about checkboxes in the details section. Cool new feature of GitHub!


Property 'defaultProps' does not exist on type ConnectedComponent

What is the current behavior?
Property 'defaultProps' and children does not exist on type ConnectedComponent.

What is the expected behavior?
It should have expected types.

We don't maintain the types in this repo. Please consult the support resources for DefinitelyTyped


To Do List

[x] Authenticate Account
[ ] Add Droplet
[ ] Remove Droplet
[x] Select Droplet

[x] Create Snapshot
[ ] Enable Backups
[ ] Disable Backups
[ ] Shutdown Droplet
[ ] Reboot Droplet
[ ] Power Cycle Droplet
[ ] Power On Droplet
[ ] Power Off Droplet
[ ] Reset Root Password
[ ] Resize Droplet
[ ] Enable IPV6
[ ] Enable Private Networking

Currently planning on splitting this into various classes such as

DigitalOcean/Client
DigitalOcean/Droplets
DigitalOcean/Account
etc.


[context] build package files are not accessible

Which package(s) are affected?
Context (@lit/context)
Description
The build files in the lib/directory of the package can't be used when using modern import because they are not provided in the exports section of package.json.
In my case I try to use the following, which fails when building.
import { ContextProviderEvent, type Options } from<EMAIL_ADDRESS>
Adding "./lib/*": "./lib/* to "exports" in package.json would allow any file in the lib/to be imported.
  "exports": {
    ".": {
      "types": "./development/index.d.ts",
      "development": "./development/index.js",
      "default": "./index.js"
    },
    "./lib/*": "./lib/*"
  },

Reproduction

Set up a standard typescript project using Vite or similar.
Import something from a file in the lib directory of @lit/context in a .ts file in the project.

import { ContextProviderEvent, type Options } from<EMAIL_ADDRESS>

Build the project by running vite build.

Workaround
Specify an alias for the file in vite.config.js.
    resolve: {
      alias: {
<EMAIL_ADDRESS><EMAIL_ADDRESS>      },
    },

Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
<EMAIL_ADDRESS>Browser/OS/Node environment
Lit 3.1.3
Typescript 5.4.5
Node v20.10
Vite v5.2.9

I wasn't as involved at the creation of this package but I'd imagine omitting /lib/ from package exports is intentional and things meant for end-user consumption are only exposed via the package root pointing to index.js. It's also (subjectively) easier for the user not having to worry about internal package structure.
It's a valid point though whether ContextProviderEvent and Option should also be exported from the package and I think the answer is yes?
Option types are useful for users wanting to pre-construct. We might do that for both ContextProvider and ContextConsumer which would require aliasing the the interface to something like ContextProviderOptions and ContextConsumerOptions.
I can't imagine why you'd want to manually create the ContextProviderEvent but I suppose it's possible to manually dispatch those instead of using the controller. I see the package already exports ContextRequestEvent albeit with an alias (not sure why) so I don't see the harm in exporting the provider event.
@justinfagnani might have more context (😉) on what the intended exports were.

I'm guessing it's non-intentional since it's a rather new feature/effect connected to moduleResolution in typescript. The files are totally accessible if you are using an older build system, that only use the main field or similar instead of the exports. Like Webpack 4 vs Webpack 5.
In our project it took a while to discover that this addition is needed in the "exports" since it's a rather new limitation that is only respected by some build systems. But now we have everything in our package available and usable. The things we want to restrict for some reason are not included in the package at all and available in the source repo instead.
Why I want to import these is because I'm extending the ContextProviderclass with some minor custom functionality (related to #4414). To be able to provide a proper constructor in the extending class, I need some of the exports in context-provider.
My current workaround (since the alias-workaround not fully worked unfortunatley) is actually just copying some of the raw files from the lib directory in the npm package instead.
I would be totally fine if everything was exported in the index instead, but I guess it would be very easy to miss something.


TypeScript definitions for event handlers

Currently, event handlers are not part of map or layer props. When used in a strict TS project, adding event handlers to props fails type checking. I also wasn't able to augment module declarations probably due to props types not being originally declared as interfaces.
Maybe I'm missing something since this project is written in TypeScript. I also noticed that mapbox-gl is typed in Flow and you don't use @types/mapbox-gl in the project. Just wonder what's your main use case for the library and how you go about typings.

Hi Sergey,
I added the missing TypeScript events in the latest release. Please let me know if this fixes your issue.
I will have a look into using @types/mapbox-gl in the future.


Add Account: Scrolling behaviour of Account Pick screen

Hide scroll Indicator has implemented.This wont let scroller to overlay on "Add
new account " button.

Fixes: #3903

First: it's a little difficult to review this PR because there are about 10 commits in it. These need to be squashed into 2. (I almost said 1; but see below.) You may want to take a look at our git documentation. (In particular, @gnprice notes that having a graphical client set up can often prevent this sort of issue, by making the branch structure visible.)
Second, this PR has an additional change – making the entire Account Pick screen scrollable – that's not clearly indicated in the PR text. It's a good change, though, and would be accepted if it were separated out rather than being buried among several similar-looking commits.
Third, the new property on Screen is named verticalScrollIndicatorEnabled, but the underlying ScrollView prop is named showsVerticalScrollIndicator, but there's no indication given of why this rename is necessary or helpful. It's probably best to keep it aligned with the underlying prop names, otherwise.

Thank you @ray-kraesig ,
I am a little unclear about

Second, this PR has an additional change – making the entire Account Pick screen scrollable – that's not clearly indicated in the PR text. It's a good change, though, and would be accepted if it were separated out rather than being buried among several similar-looking commits.

So if i need to do any change please tell me..


Add Features?

I'm wanting to use this, but would like to see if you can add some features that will make it a little more useful for me.
In the build.html:

Add the ability to Add Tile Layer HTML. I have a tile layer that shows engineered routes and would like show them on the map.

Add C3/D3 Charts (which would need alasql to work I suppose) (would be in the navbar)

Add Refresh Button in the navbar

If these cannot be implemented, can you help me with the build out that I have?
I like the way you use:

Filter the markers on map to filtered table
Legend markers on the Table
Legend popup on the navbar

These feature requests are out of the scope of this project, which is meant to be super simple with configuration via URL parameters.

I understand. Can you help me add a couple features on mine as its not URL based? I'll pay you if it's too much of an issue. Or is this something I can go through my Fulcrum Support to get help with?
Sent from my Verizon, Samsung Galaxy Tablet
-------- Original message --------
From: Bryan McBride<EMAIL_ADDRESS>Date: 2/27/18 2:55 PM (GMT-07:00)
To: "mapzap/mapzap.github.io"<EMAIL_ADDRESS>Cc: Tanner Anz<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mapzap/mapzap.github.io] Add Features? (#3)
These feature requests are out of the scope of this project, which is meant to be super simple with configuration via URL parameters.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/mapzap/mapzap.github.io/issues/3#issuecomment-369040233, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ai470wM57gK3oY07FGuE5yv0Lfs6y1_1ks5tZHm9gaJpZM4SUKVf.


Empty open AgreementDataField after reopening

Reproduce:

Open connection
Click "Show Agreement Data"
Field with text: "No Agreement Data found" appears
Switch to another connection
Switch back -> message field ist still there, but no text shown (picture)

agreement ui changed -> no longer relevant, closing this issue


Bio Weekly - Update Table/Figure Titles and Numbering

Update each table and figure title and number in the weekly report. The original titles and their corresponding updated titles are listed in this document --> Issue #113 - Table:Figure Titles and Numbering.docx
Please note that each page of the document above lists the tables/figures that are supposed to be in each "Contents" section listed in #114. The bolded titles are the updated titles. The two titles highlighted in yellow indicate that the table/figure's order has been changed (Figure 4.3 [3.3] and Table 26 [4.11])
Refer to #88 for updated titles/numbering for section 7, Home Mouthwash Collections.

@HopkinsDC  It looks like only Table 28 and Table are included. But right now we have Table 28a, Table 28b, Table 29a, and Table 29b. Do some of these need to get deleted?

@KELSEYDOWLING7 Sorry about that, not sure what happen to those. Here's the updated file: UPDATED_Issue #113 - Table:Figure Titles and Numbering.docx (I also replaced the linked file in the main issue comment above).

@HopkinsDC  No problem! This and #114 are basically done. Do you have a list of what the new row/column Totals should be named for each table?

@KELSEYDOWLING7 Great! The additional edits for all the tables can be found in Box: https://nih.app.box.com/folder/244754020093. Let me know if you'd rather have an actual list of them, and I can make one.

@HopkinsDC  All set!
Testing-Restructure-of-Weekly-Biosec-Report.pdf
I also noticed some tables didn't have SD requested to be removed something like 'SS Tube 1" to "SS T1" (ex: Table 2.7)like others did. Please let me know if these also need to be fixed

@KELSEYDOWLING7 , Michelle and I will look through this.

@erincschwartz  Hi Erin, do you know if these changes will be put into affect soon?
Also I was notified by Mia of an updated requirement for color use in plots based on color blindness. We are now limited to 7 colors, each with 5 saturation levels.
CGOV-20456_Color-Palette-Charts.pdf
I've tried to use the variations as best as possible to still be able to distinguish the difference for Site, Collection location, and Setting. before I apply this to the restyled version of the report, please let me know if there are any concerns.
Weekly_Biospecimen_Metrics.pdf

@erincschwartz  Here is the updated version with the color changes, additional/updated Tables 2.7 and 2.8 from issue #118 , additional/updated Tables 4.9 and 4.10 from issue #124 , and the additional/updated Figures 5.9 and 5.10 to split the F Collections into two plots by setting. I also found a missing footnote requested in section 2 that's been added, and corrected Figure 3.1's title.
Testing-Restructure-of-Weekly-Biosec-Report.pdf

@KELSEYDOWLING7 Here is the PDF with the comments embedded for the updates. Thanks!
Testing-Restructure-of-Weekly-Biosec-Report_ES comments_03.21.2024.pdf

@erincschwartz  Thanks, let me know if I missed anything! Or typos, unfortunately R doesn't catch those
Testing-Restructure-of-Weekly-Biosec-Report.pdf

@KELSEYDOWLING7, here is the list of those minor changes we just reviewed:
Table 3.2-3.4 remove the - after Baseline
Table 3.5 Baseline Biospecimen Survey Completion Time from Dashboard Entry of Clinical Collection Dashboard Entry
Table 4.11 Remove HFH and update Note: Table includes information for Kaiser sites only, other clinical collection sites are excluded
Figure 5.8- update title "Baseline- Collection-To-Receipt Time (in Hours), HealthPartners Research Setting"
Figure 5.9- update title "Baseline- Collection-To-Receipt Time (in Hours), HealthPartners Clinical Setting"
Figures 5.10 and 5.11, swap these to keep consistent with showing research information first, clinical second and update titles "Baseline- Collection-To-Receipt Time (in Hours), Henry Ford [Research/Clinical] Setting"
Figure 6.2 and 6.7 update title, take out "at"
Figure 6.8- update title "Baseline- Weekly Research Biospecimen Collections by Collection Location, Marshfield Clinic Health System"
Figure 6.10- update title "Baseline- Weekly Research Biospecimen Collections by Collection Location, Sanford Health"
Figure 6.13- 6.16 update titles, take out "at"

Please let me know if I missed anything! @erincschwartz
Testing-Restructure-of-Weekly-Biosec-Report.pdf

@KELSEYDOWLING7, just a few minor fixes left:

I realize now that the title I proposed for Table 3.5 is redundant, please update to: Baseline Biospecimen Survey Completion Time from Clinical Collection Dashboard Entry
The titles for Figures 6.8, 6.10 and 6.15 all seem to get cutoff
Figure 6.15 remove "at"

@erincschwartz  Thanks for catching that. Here's the updates.
Testing-Restructure-of-Weekly-Biosec-Report.pdf

@KELSEYDOWLING7 I just reviewed these final edits. Look good, thank you! Changing status to Ready for Automation.

@erincschwartz  Based on this week's report is this good to close?


New Contribution

Contributor: [contributor information - Optional]
SSH Public key: [contributor SSH public key (if you don't have one, submit the issue to receive instructions)"- Required]
Attestation: [any form of attestation for contribution (e.g., signature) - Optional]

ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIIqbHP6c79P9WJLamE/3YU8QRCBGRog+/goAJUWP2MYn


Run commands in quiet mode

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[ ] Use the notebook template as a starting point.
[ ] Follow the style and grammar rules outlined in the above notebook template.
[ ] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[ ] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
[ ] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

If you are opening a PR for Community Notebooks under the notebooks/community folder:

[ ] This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
[ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

If you are opening a PR for Community Content under the community-content folder:

[ ] Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
[ ] The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
[ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

Ran the Cli test for multiple notebooks mentioned in test_notebook_vm.txt.
As an example of logs for metrics_viz_run_compare_kfp.ipynb, which logs after using quiet is shorter... we can still move the download link up:
logs before changes
logs after changes


Consider 'print visualization' option

Changes in #1127, especially removing the legend given better hover interaction, make me think about the use case of screenshotting/saving/printing visualizations, and how this conflicts with organizing information optimized for interaction.
I wonder if it would be good to have a "print visualization" button that activates a few other options, like:

Showing 'year' and perhaps 'Geography' in the map title or subtitle
Adding the legend to the trend spec
...and perhaps other information.

Upon print button click, we could even open a modal with a bit of information on how to click the actions menu and save as PNG or SVG, with the visualization rendered in the modal.

Potential implementation:

have a global variable called printSpec or something
upon calling vegaEmbed(...) in any of the chart view functions, make that spec the value of printSpec
upon print function, manipulate printSpec as needed

@cgettings - branched off of hotfix-DE-pallette to work on a chart printer. Overall this works by having a printSpec variable, and on any given vegaEmbed(...) call, map.js or comparisons.js defines printSpec with the contents of the spec it's drawing (I threw var printSpec at the top of data.js but there may be a better place for it.), so we can pass it in to another vegaEmbed call later.
Also,

Added a print.js file to keep things separate, since this will include some additional logic to modify the specs for printing
Button (on map and trend chart rn) fires a modal
using setTimeout, that code draws the chart in the modal. Trying to do this at the same time caused some bugs and failures - seems that the modal needs to be fully rendered before we can draw a chart in there reliably.

No rush on this but I'd love your thoughts on this approach.
Stil to come is adding some logic to print.js that modifies the spec - adding year and neighborhood to the map, adding the legend to the trend chart... This stuff actually may have to happen with renderMap and renderComparisons in order to use the indicator metadata, so I might wind up writing alt-specs in those functions.

hey @etorem when you have a moment can you serve up this branch and take a look at a DE map or trend chart, and let me know what you think about the "print" option? curious for your take on the ux.

I think this looks nice!

Rolling up work in #1127 which itself rolled up work in #1080  and developing a fairly significant release branch, this includes:

Save vis option that launches a modal that includes all the info necessary for somebody to screenshot, save, etc - this includes adding data source into the vis, adding a legend into the trend (which was dropped for the page in favor of hover), and more
Placing the Save Vis button in the footer
Revising the footer to clean up the Notes and the Data Source
De-Duping data sources by testing in renderAboutSources to see if sources is an array full of identical things, and only taking one if that's the case
And, of course, all of the axis work - which includes, on trend, converting to Vega to add interactive: false to several layers


Clean up intall instructions

Hi there,
I just upgraded to 1.1 and really like that frontend and backend-php are now separated out since I customized my frontend UI a bit. However, this is a bit unclear in the README.MD

Copy everything in the "backend-php" and "frontend" folders in this repository to somewhere in your web root.

Previously I pointed the web root to /html/backend and everything worked. Since both frontend and backend-php are required it seems no longer possible to point to a single folder. I ended up copying everything in backend-php and frontend to /app then pointing my webroot to this folder.  Everything is now working as expected. Is this the intended method?
I'm happy to submit a PR for documentation improvements once I know how this is suppose to work.
Perhaps another method would be to have a main index.php file that includes the required files, much like an auto-loader? Help figuring out how this is suppose to work would be great.

Hi,
The change was made to split the static frontend code away from the PHP backend as part of an upcoming merge of PR #10 that will introduce an alternate non-PHP backend to the project. This was done so that the browser frontend and assets aren't duplicated between them. The correct manual installation procedure now is to do as you did; copying the contents of backend-php and frontend into the same folder and using that as the web root. Though I guess the installation procedure isn't totally clear on that matter.
I could write a simple install.sh script that does the work of copying everything correctly to a specific web root directory, e.g. ./install.sh /var/www/html. This could then be the preferred way to do a non-Docker install. An improved version of the current installation procedure could then be included as a means to do a fully manual install without having to run a script.
If you have suggestions for improvements, that'd be much appreciated :-)

That makes sense, for now, I submitted https://github.com/bilde2910/Hauk/pull/23 which I hope makes things a bit clearer. These will need to be adjusted with Ruby is an option.

Thanks for the contribution. I've merged #23 and will update the README once the Ruby backend is an option, and when an install.sh script is in place.
Issue closed: Fixed by author in #23.


Add PropTypes and props.compareChildren

This PR adds PropTypes and defaultProps and adds props.compareChildren (I need it in case using ReactRouter v4, when this.props.children === nextProps.children, because children is single instance of Switch element).
#24

Thank you :)
Can you submit another PR to explains the compareChildren props in the README?


modify getthumbnailurl to receive a minWidth

Summary
Modifies getThumbnailUrl to receive a minWidth.
Relevant Technical Choices
Ignores thumbnail as that is cropped. Ideally there should be a cropped attribute in that sizes value.
To-do
None.
User-facing changes
None. Improves rendering in the row-based gallery when the rowBasedGallery flag is on.
Testing Instructions
Enable rowBasedGallery and verify that wide thumbnails are no longer pixelated.

Fixes #3323

Yep, this chnge is compatible with both approaches, it's just that the column layout didn't trigger the bluriness


Spike Extraction parameters

Hi @mdenker
I am using elephant.spike_train_generation.spike_extraction function for my MEA 96-channel signal.
I have following questions:

Why default values are selected as [-2ms, 4ms]

What is exactly the time_interval here?
When I set it to [-10 ms,10 ms] or [0 ms, 10 ms] or [5 ms,15 ms] I get the same results of spike times as below. Could you explain me if I am doing something wrong?

spikes for [-10 ms,10 ms] =  [0.4288     5.9382     6.91823333 6.91963333 6.9386     7.71603333
 7.73576667 8.18213333 8.29553333 8.3024     8.30493333 8.31963333] s

spikes for [0 ms, 10 ms] = [0.4288     5.9382     6.91823333 6.91963333 6.9386     7.71603333
 7.73576667 8.18213333 8.29553333 8.3024     8.30493333 8.31963333] s

spikes for [5 ms,15 ms] = [0.4288     5.9382     6.91823333 6.91963333 6.9386     7.71603333
 7.73576667 8.18213333 8.29553333 8.3024     8.30493333 8.31963333] s

Thank you

Hi @mytrjp ,
both questions relate to the spike waveforms which are extracted from the signal, i,e., the cutout of the signal around each spike.
The time_interval specifies the cut-out interval around each spike. -2 and 4 is of course somewhat arbitrary, however, many spike sorting tools choose values in this range: the spike is about 1-2 ms in length, and then you take a bit before the spike peak, and a bit more after the spike peak (to catch the dynamics after the spike).
If you set the time_stamps to None, peaks are extracted using numpy's peak finder. Therefore, the spike times will always be the same. However, the waveforms stored in the spike train (in spikes.waveforms, an NxM matrix for the N spikes, each row containing a waveform) should be different: In the first example, they should range from -10ms to 10ms, in the last example they should be from 5 to 15 ms. Thus, as an example, if the sampling frequency is 10KHz, and 123 spikes where detected, then spikes.waveforms should be size 123x200 for the first example.
I hope this helps. Thanks for asking this, I will keep this issue open as a reminder to augment the documentation to better explain this.


Updating causes custom sounds to be replaced.

What version of Node.js are you using?
16.13.2
What version of npm are you using?
8.1.2
What operating system are you using?
Windows
What version of SnailyCAD are you currently using?
1.49.0
Describe the Bug
When you update the CAD to a newer version, custom sounds will be replaced with default sounds.
Expected Behavior
Ignore custom sounds or not try and install sounds during update, only first time install.
To Reproduce

Install CAD
Replace sounds and test
Update CAD
Sounds will now be replaced

These are already in the gitignore so should not be overwritten. There isn't much I can do about this :/


Pretrained model

Can you provide pretrained model please.

Please read the README

Sorry. I am search for ".pth files" as mentioned in eval_singlevideo.py. I am use ".pt" file instead and this is work.


Non-base language events are being dropped in the pipeline

It looks like we're writing a mix of both english and spanish terms to cassandra. For example, if ataque is a watchlist term for a Fortis site, where the primary language is spanish with english translation support.
If ataque is mentioned in a spanish tweet we archive that term in cassandra. We do the same if attack is mentioned in an english tweet. A data sample is listed below. This presents a problem in the Fortis interface as the services expect content to be aggregated based on terms in the base language. We need to enhance the keyword extraction analyzer to properly normalize this where attack is detected as ataque.
      month | ataque |                   |                   |    11 |     Twitter |    EmbVZLA_enEsp |   11_917_648 | 2017-10-01 00:00:00.000000+0000 |                     0 |            1
        day | ataque |                   |                   |     6 |     Twitter |  RaicesPeronista |      6_28_20 | 2017-10-03 00:00:00.000000+0000 |                     0 |            1
        day | ataque |                   |                   |    13 |     Twitter |          sutpmcu | 13_3670_2592 | 2017-10-03 00:00:00.000000+0000 |                     0 |            1
      month |       attack |                   |                   |    13 |     Twitter |              all | 13_3670_2581 | 2017-10-01 00:00:00.000000+0000 |                     0 |            1
       hour |       attack |                   |                   |    13 |     Twitter |              all | 13_3670_2581 | 2017-10-03 01:00:00.000000+0000 |                     0 |            1

Resolving as we're now tracking this elsewhere.


Latest release of magenta is out of sync with latest sketch_rnn model data (resulting in AttributeError when running sketch_rnn.ipynb)

To repro:

perform an 'automated install' of Magenta (using install script)
download and run magenta/magenta/models/sketch_rnn/sketch_rnn.ipynb
cell 8 (the call to load_env) fails with AttributeError: 'list' object has no attribute 'startswith'

In dabe10468e6664cbdfde19e594327bfb5bfbc579 and 8b6151754c6010d9cb1bd48ab765d2b3ffa51f66 the data_set parameter was changed from a string to a list. The problem is:

the latest version of magenta on pip (0.1.12) does not include these changes
the latest model data at http://download.magenta.tensorflow.org/models/sketch_rnn.zip, which the ipython notebook automatically downloads, does use this convention. It includes a model_config.json file which has a list value for data_set (which overwrites the default string value in the source).

@hardmaru if we just release a new pip package, will that fix this?

Yes, I believe an updated pip package would fix this.

So how to overcome this ?

@gautam1858 the simplest workaround is to just manually edit the model_config.json file for the model you're using (by default, they'll save under /tmp/sketch_rnn/models). Just replace "data_set": ["foo.npz"], with "data_set": "foo.npz",.
(You could also install the latest Magenta from source, but that's more work.)

Magenta v0.1.13 has been released and should resolve this issue.


Update cmakebuild.js to spawn with shell: true

This fixes #324 - I've tested on a Windows x86_64 and on my MacBook M3 (arm64).
I considered adding it here as well: https://github.com/prebuild/prebuild/blob/af905c75861d6692d63ef3cc386a7682b41a0941/util.js#L20
But it seems the only code (currently) calling this of that util is disabled on Windows: https://github.com/prebuild/prebuild/blob/af905c75861d6692d63ef3cc386a7682b41a0941/strip.js#L6

I support this fix and agree to it. The reason for this is new security measures in windows itelf. many project run against this these days, including node-red, iobroker and others.

@lovell @ralphtheninja @vweevers Thank you for considering a time near merge and release becaise this blocks many windows useages !

v13.0.1

Thank you very much!!

PS: Validated: Solves the problem


VSE Bug - Crash on removing Graph Resource

Reproduce:
Simple scene:

Spatial

Test Cube

Add Shader Resource to Cube
Add Graph Resource to Shader Resource
In Shader Resource click Clear the recently added Graph Resource
Crash

Can you still reproduce this in the current master branch?

Followed the above steps but couldn't reproduce the crash, so I guess it has been fixed.


Update dvc studio integration to use dvc studio login

Should we update this to use dvc studio login?
Originally posted by @dberenbaum in https://github.com/iterative/dvc.org/pull/5064#discussion_r1441956465

@amritghimire @dberenbaum
I don't think we will use the new auth flow for CI/CD script.
Is it okay to leave those as it is or do we have another workaround for that case?
Current Usage:
run: |
     dvc config --global studio.token ${{ secrets.DVC_STUDIO_TOKEN }}

You could leave it as is, or there's an environment variable that could be set:
env:
  DVC_STUDIO_TOKEN: ${{ secrets.DVC_STUDIO_TOKEN }}


OSX instructions

For info, here is how I installed dataserv-client on OSX:
brew install python3
rehash
pip3 install dataserv-client

(this presumes that brew is already installed.) Could someone add this to the readme?

Mind doing a pull request?

Thanks for doing this.


refactor ConcurrentMapPartitionUpsertMetadataManager constructor

refactor
cleanup

Refactor ConcurrentMapPartitionUpsertMetadataManager constructor to pass less params.
Directly pass upsert config to avoid cramming too many args in this constructor.

lgtm! Thanks for refactoring the code.

thanks @navina for review!

Codecov Report

Merging #10836 (6401df6) into master (8468857) will decrease coverage by 56.64%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10836       +/-   ##
=============================================
- Coverage     70.23%   13.59%   -56.64%
+ Complexity     6585      439     -6146
=============================================
  Files          2170     2116       -54
  Lines        116665   114172     -2493
  Branches      17656    17358      -298
=============================================
- Hits          81942    15526    -66416
- Misses        29014    97375    +68361
+ Partials       5709     1271     -4438

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
13.59% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cal/upsert/BasePartitionUpsertMetadataManager.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...t/local/upsert/BaseTableUpsertMetadataManager.java
0.00% <0.00%> (-78.95%)
:arrow_down:

...t/ConcurrentMapPartitionUpsertMetadataManager.java
0.00% <0.00%> (-80.96%)
:arrow_down:

...psert/ConcurrentMapTableUpsertMetadataManager.java
0.00% <0.00%> (-33.34%)
:arrow_down:

... and 1710 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I don't think we want to make this change. The constructor for the TableUpsertMetadataManager takes the UpsertConfig from TableConfig, and process the value if needed (e.g. use time column as comparison column if not configured). We don't want to repeat the same steps in PartitionUpsertMetadataManager, so we directly pass the value

@Jackie-Jiang Can I assign the comparisonColumns value to upsertConfig and pass it to PartitionUpsertMetadataManager? then we don't need to repeat the same steps in partitionlevel upsert metadata managers.
The purpose of the change is to address a comment from @KKcorps. https://github.com/apache/pinot/pull/10047#discussion_r1189404582

@Jackie-Jiang Can I assign the comparisonColumns value to upsertConfig and pass it to PartitionUpsertMetadataManager? then we don't need to repeat the same steps in partitionlevel upsert metadata managers.
The purpose of the change is to address a comment from @KKcorps. #10047 (comment)

That can fix the issue, but also means it is harder to manage (next person might make the same mistake). I'd suggest keeping the constructor as is without overriding the config. @KKcorps wdyt?

@Jackie-Jiang Is an instance of UpsertConfig meant to be mutable after its creation? Meaning once the upsert config object is instantiated, it seems acceptable to override a member variable with the setters.
I don't think this is a good practice, in general, as a config should be immutable once created. It might be convenient for testing purposes. Can we follow a builder pattern with UpsertConfig if it makes sense? Or at least, disallow setters on config objects?

@Jackie-Jiang Is an instance of UpsertConfig meant to be mutable after its creation? Meaning once the upsert config object is instantiated, it seems acceptable to override a member variable with the setters.
I don't think this is a good practice, in general, as a config should be immutable once created. It might be convenient for testing purposes. Can we follow a builder pattern with UpsertConfig if it makes sense? Or at least, disallow setters on config objects?

That is basically the point I'm trying to make. We should not modify the config read from the ZK because that can cause confusion, and certain dependency on how the code is executed. The current code doesn't modify the config but the new code does, thus I'm suggesting not making this change.

@Jackie-Jiang Can I assign the comparisonColumns value to upsertConfig and pass it to PartitionUpsertMetadataManager? then we don't need to repeat the same steps in partitionlevel upsert metadata managers.
The purpose of the change is to address a comment from @KKcorps. #10047 (comment)

That can fix the issue, but also means it is harder to manage (next person might make the same mistake). I'd suggest keeping the constructor as is without overriding the config. @KKcorps wdyt?

Yeah overriding the configs is a big no no. They are supposed to be immutable.
I do want this constructor to be cleaned though using some way.
Otherwise more and more args will just keep on adding here

@Jackie-Jiang Can I assign the comparisonColumns value to upsertConfig and pass it to PartitionUpsertMetadataManager? then we don't need to repeat the same steps in partitionlevel upsert metadata managers.
The purpose of the change is to address a comment from @KKcorps. #10047 (comment)

That can fix the issue, but also means it is harder to manage (next person might make the same mistake). I'd suggest keeping the constructor as is without overriding the config. @KKcorps wdyt?

Yeah overriding the configs is a big no no. They are supposed to be immutable.
I do want this constructor to be cleaned though using some way.
Otherwise more and more args will just keep on adding here

One way is to create a different wrapper class to hold the modified configs

One way is to create a different wrapper class to hold the modified configs

Why do you need a wrapper class?  wouldn't a builder pattern like this be sufficient?
I don't see a real need to modify the upsert configs anywhere.

comparisonColumn might not be set in the upsert config, and we want to use time column as the comparison column if it is not configured. If we pass the UpsertConfig to the partition level metadata manager, we need to apply the same logic again for each partition

I see. And looks like we don't have access to the time column in the code paths since it comes from schema? crap.
Ok internal wrapper class is one option. an alternative could also be to re-create a new instance with the comparison column set. The latter will prevent future misuse of the UpsertConfig class by preventing mutability after config object creation. This is my 2 cents.
Thanks for clarifying @Jackie-Jiang

thanks for discussion @Jackie-Jiang @navina @KKcorps
do you think i should add a wrapper for upsertConfig or just close this PR?

per offline discussion with @Jackie-Jiang i will close this PR for now. We may revisit if the constructor becomes more complicated.


Start discovering the device but nothing is in response

I have added this library in my app and tried to search device via service type. I have exactly followed the documentation. When i started device searching I got this message on the log "Starting discovery" but after that, I am not getting anything. And even I checked my server side I am not getting any packet from my app. How to solve this problem??

Did you find any solution ?

Android emulator does not support multicast

this is even not working in real device too

I believe it has something to do with closing socket. Whenever I encounter this problem, it is after a lot of tests so probably there are many unclosed sockets. In the other hand when app is working, logging shows that app does not close opened sockets successfully.

I believe it has something to do with closing socket. Whenever I encounter this problem, it is after a lot of tests so probably there are many unclosed sockets. In the other hand when app is working, logging shows that app does not close opened sockets successfully.

Not working on above android 8 version

Router discovery not working on Android TV


Fix drag preview not displaying text in TableView

Closes https://github.com/adobe/react-spectrum/issues/4895
The fix ensures that when rowHeader is not present, the drag preview displays the content of the first element, excluding checkboxes and dragButtons.
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[x] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Visit http://localhost:9003/?path=/story/tableview-drag-and-drop--drag-out-of-table-without-table-header&args=selectionStyle:highlight&providerSwitcher-express=false&strict=true
In the Table, drag a row.
Verify that the text from the first column ("First name") of the dragged row is displayed in the drag preview.

🧢 Your Project:

GET_BUILD


has_std is disabled on WSL

I think you should just handle nostd like everyone else: default enabled std feature so we can opt out of std via default-features = false

Thanks for the report. Do you have any more info about how it works on WSL? Your conclusion is certainly likely given the problems we've had with this. Already on the 2.0 list.

No idea.
A friend was having issues with compiling a crate on wsl and we tracked it down to indexmap not having has_std enabled.

The precise error I had in WSL is this (compiling naga, which depends on indexmap):
error[E0107]: this struct takes 2 generic arguments but 1 generic argument was supplied
   --> /home/jay/.cargo/registry/src/github.com-1ecc6299db9ec823/naga-0.7.1/src/arena.rs:392:10
    |
392 |     set: IndexSet<T>,
    |          ^^^^^^^^ - supplied 1 generic argument
    |          |
    |          expected 2 generic arguments
    |
note: struct defined here, with 2 generic parameters: `T`, `S`
   --> /home/jay/.cargo/registry/src/github.com-1ecc6299db9ec823/indexmap-1.7.0/src/set.rs:67:12
    |
67  | pub struct IndexSet<T, S> {
    |            ^^^^^^^^ -  -
help: add missing generic argument
    |
392 |     set: IndexSet<T, S>,
    |                    +++

For more information about this error, try `rustc --explain E0107`.
error: could not compile `naga` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed

The culprit is that I was building on the mountpoint for the host FS, which doesn't have write access by default:
[indexmap 1.7.0] error: could not copy "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe0.probe0.3041c4be-cgu.0.rcgu.ll" to "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe0.ll": Operation not permitted (os error 1)
[indexmap 1.7.0]
[indexmap 1.7.0] error: aborting due to previous error
[indexmap 1.7.0]
[indexmap 1.7.0] error: could not copy "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe1.probe1.56ebf6f4-cgu.0.rcgu.ll" to "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe1.ll": Operation not permitted (os error 1)
[indexmap 1.7.0]
[indexmap 1.7.0] error: aborting due to previous error
[indexmap 1.7.0]
[indexmap 1.7.0] warning: autocfg could not probe for `std`
[indexmap 1.7.0] error: could not copy "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe2.probe2.a8400cd7-cgu.0.rcgu.ll" to "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe2.ll": Operation not permitted (os error 1)
[indexmap 1.7.0]
[indexmap 1.7.0] error: aborting due to previous error
[indexmap 1.7.0]
[indexmap 1.7.0] cargo:rerun-if-changed=build.rs

This is output from the build script by cargo build -vv.

The culprit is that I was building on the mountpoint for the host FS, which doesn't have write access by default:
[indexmap 1.7.0] error: could not copy "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe0.probe0.3041c4be-cgu.0.rcgu.ll" to "/mnt/c/Users/jay/projects/pixels/target/debug/build/indexmap-1683d57664f31640/out/probe0.ll": Operation not permitted (os error 1)

If it doesn't have write access, how did the temp *.rcgu.ll get written? Or even the compiled build script? Cargo is supposed to set a writable OUT_DIR environment variable, which autocfg uses for rustc --out-dir.

Got me... How did anything get written to allow most of the crate to build successfully?
I'm not sure if WSL is doing something magical with FS permissions or if there is a bug. Using the WSL VHD is much less problematic.

@parasyte the actual error you showed above is not necessarily related to how this crate detects std or no_std.
It just so happens I have submitted PR #207 that unifies the std and no_std API for IndexMap and IndexSet, which would solve your problems:

Also, FWIW the std/no_std detection works for me personally, but I do agree it'd be nice to have a typical std feature like most other crates offer.

We did add a std feature later. The historical problem is that we started with an assumption of using std, which means it would have worked even with default-features = false, which makes adding a no_std mode harder. Enter the detected has_std in #106, and then the forced std feature in #145, striving for backward compatibility the whole way.

Ah I missed that std feature. Either way, it works for me, so I have no qualms with how std detection is done. :+1:

Duplicate of #184
I'll file this as a duplicate. On track for 2.0.


Failed to execute 'objectStore' on 'IDBTransaction': The specified object store was not found.

Hello, where am I doing wrong I would be glad if you could help;
I get an error like this :

But the problem disappears when I take out the getStep function as below.

Within the each() callback, you're code is executing within a transaction that only has 'options' table in it. When you call getStep(), it won't find the 'step' table in the ongoing transaction.
Solution: Start a transaction in optClick that includes both 'options' and 'step'.
Tip: I would suggest to change the code so that all DB related things are done separate from GUI interactions and communications. Create a function that does the transaction and returns a result to act upon and perform the GUI interactions and call adminSend() / userSend() from outside that DB-facing code. Also avoid .each() and use toArray() instead which is easier to follow and also more performant as it allows Dexie to use a more optimized way of fetching the data from the db (using IDBIndex.getAll() rather than IDBIndex.openCursor()).

Within the each() callback, you're code is executing within a transaction that only has 'options' table in it. When you call getStep(), it won't find the 'step' table in the ongoing transaction.
Solution: Start a transaction in optClick that includes both 'options' and 'step'.
Tip: I would suggest to change the code so that all DB related things are done separate from GUI interactions and communications. Create a function that does the transaction and returns a result to act upon and perform the GUI interactions and call adminSend() / userSend() from outside that DB-facing code. Also avoid .each() and use toArray() instead which is easier to follow and also more performant as it allows Dexie to use a more optimized way of fetching the data from the db (using IDBIndex.getAll() rather than IDBIndex.openCursor()).

@dfahlander Thank you so much. I made arrangements according to your suggestions, it works very well. Thank you also for this nice plugin :)

@dfahlander Thank you so much. I made arrangements according to your suggestions, it works very well. Thank you also for this nice plugin :)


Undo/redo, bulk edit and onWill-file events

This PR makes it possible that additional workspace edits from an onWill[Create|Rename|Delete]Files are added to the same undo/redo groups as the initiating operation. The sample is the Java file rename which makes a text edit before the actual rename. Those should only require a single undo.
This is PR is kinda large but simple. It spreads data because

all onWill-events are triggered from the working copy service
that service doesn't know anything about undo/redo (on purpose)
the bulk edit service does know about undo/redo and consumes the working copy service
some undo/redo information needs to travel to onWill-event listener
therefore the bulk edit service can now pass data about undo/redo which the working copy service simply forwards to its event handlers

fyi - the alternative would have been to move all onWill-event logic into the bulk edit service but since there are still direct consumer of the working copy service it would have meant that the API now fires less event, like for "save as".
Somewhat open questions

on the ext host the onWill-events will not fire anymore when undoing/redoing. That's to safe the undo-stack but might be unexpected?
should the same happen for onDid-events that are caused by undoing/redoing? Those cannot piggy-bag extra edits tho.

@bpasero please check the changes in the working copy service

fyi @isidorn

@jrieken Thanks for looking into this. Once this lands I can double check the Java rename flow.

related/tackles https://github.com/microsoft/vscode/issues/107740

but would it make sense to put undoRedoGroupId: number | undefined, isUndoing: boolean | undefined into a single object to keep it together?

I was also wondering about that but I didn't wanna make the undo/redo world more prominent in the working copy service. When more flags come I will do.


Added REST API and example

Hello mate,
I didn't mean to close the other pull request I was deleting some of my remote branches after merging back to master.
Anyway, let me know what you think of the changes.
Thanks.
Closes #122

This looks excellent! Nicely done!
Cheers 🍻

We can split it up into a Service in ./shared/users/user.service.ts later, otherwise looks great

Good idea mate, I will sort that out later. I will make the table a bit prettier as well I think amd throw some extra angular validation on there as well maybe.

What's the highest priority work for this do you think atm?

I have AoT "basically" working, but I need to figure out one issue it's throwing that seems to be something overall going wrong with @ngtools/webpack, but I'm investigating now.
I wanted to get ng2-bootstrap with bootstrap4 & SASS (for themeing) in there, but feel like that might be a next step for after AoT is finished.
Maybe some type of basic Authentication would be nice? ala #59?
Also not sure if #149 is fixed, but guessing so.


Upgrade jackson-annotations

Closes #231
This PR consists of two changes:

The first upgrades jackson-annotations to 2.14.2
The second moves the dependency version declarations into a shared version catalog. This is not strictly necessary to address my raised issue, but as both client and service use retrofit, this change future-proofs the dependency management, so that all subprojects are guaranteed to use the same dependency versions.

Thank you!


Inefficient use of std::make_unique

There seems to be an inefficiency in sparse_set::assure. std::make_unique will value initialize (zero initialize) the memory. Immediately after that, it's being filled with entt::null. Apparently, the compiler isn't smart enough to optimize away the zero init (compiler explorer). Notice that c contains a call to memset while d does not.
The solution is to default initialize using new directly or with std::make_unique_for_overwrite (formerly known as std::make_unique_default_init).
I haven't looked around for other instances of this.

Good catch. So, what you suggest is to use sparse[pos].reset(new entity_type[entt_per_page]); instead, right?

Yes, that’s what I’m suggesting.

Upstream on master.


Fixed #40

Fixed issue #40

@panickervinod Have made the suggested changes.

@panickervinod  Closing this pr


能转成其他格式文件就好了!

老大,出个联系方式?～

Please express clearly,I don't your issue meaning.File?

What if outputting different formates of  image,for example png,gif,jpg,as we could have to convert by ourself on .bmp,which is two steps!
Especially,for me,i really want ".tif extension" pic in my application
Really appreciate for your excellent work!:)

you can save .tif,but convert you need get bitmap,save again.

I will think about or add a method.

I add it.I will close it.


Bash does not detect a TTY when using pty

I'm trying to use pty to start a bash shell in a way that will allow me to pass the --rcfile flag. Because Bash in its infinite wisdom decided not to respect --rcfile unless you're in a TTY.
Problem is that even when using pty it does not detect a tty.
This is the pty specific code I've written (keep in mind this is proof of concept code)
func (p *Process) start() error {
	var err error
	if p.pty, err = pty.Start(p.cmd); err != nil {
		return err
	}

	go func() {
		_, err := io.Copy(p.cmd.Stdout, p.pty)
		if err != nil {
			panic(fmt.Sprintf("Error while copying stdout: %v", err))
		}
		_, err = io.Copy(p.pty, p.cmd.Stdin)
		if err != nil {
			panic(fmt.Sprintf("Error while copying stdin: %v", err))
		}
	}()

	return nil
}

Keep in mind the above is used to basically run bash --rcfile /some/file. Once started I use stdin to send it additional commands. In this case I've sent it the "tty" command and it returns not a tty.
Any idea what I might be missing, or does this package not fully set up a tty?
Thanks

After looking into this, I don't think there is an issue with the lib. I see multiple issue with the sample code you provided:
p.cmd  is the exec.Cmd getting started, so p.pty and p.cmd.Stdout are equal, so are p.pty and p.cmd.Stdin. (see run.go from the lib).
The copy goroutine will not consume p.cmd.Stdin as it is blocked by the copy to p.cmd.Stdout.
Following your snippet, here is a working example of bash loading a rcfile in tty mode.
package main

import (
        "fmt"
        "io"
        "log"
        "os"
        "os/exec"

        "github.com/kr/pty"
)

type Process struct {
        cmd    *exec.Cmd
        pty    *os.File
        stdout io.Reader
        stdin  io.Writer
}

func (p *Process) start() error {
        stdinR, stdinW := io.Pipe()
        stdoutR, stdoutW := io.Pipe()

        p.stdin = stdinW
        p.stdout = stdoutR

        var err error
        if p.pty, err = pty.Start(p.cmd); err != nil {
                return err
        }

        go func() {
                defer stdoutR.Close()
                _, err := io.Copy(stdoutW, p.pty)
                if err != nil {
                        log.Printf("Error while copying pty to output pipe: %v", err)
                }
        }()
        go func() {
                defer stdinW.Close()
                _, err = io.Copy(p.pty, stdinR)
                if err != nil {
                        log.Printf("Error while copying input pipe to pty: %v", err)
                }
        }()

        return nil
}

func main() {
        p := &Process{
                cmd: exec.Command("bash", "--rcfile", "hello.rc"),
        }
        p.start()

        go func() {
                fmt.Fprintf(p.stdin, "cat hello.rc\n")
                fmt.Fprintf(p.stdin, "tty\n")
                fmt.Fprintf(p.stdin, "hello\n")
                fmt.Fprintf(p.stdin, "exit\n")
        }()

        io.Copy(os.Stdout, p.stdout)
}

Resulting in:
$> go run main.go
cat hello.rc
tty
hello
exit
$ cat hello.rc
hello() {
        echo "hello from rc file" >&2
}
$ tty
/dev/pts/25
$ hello
hello from rc file
$ exit
exit
2019/06/17 11:02:45 Error while copying pty to output pipe: read /dev/ptmx: input/output error

Bash properly loads the hello function from hello.rc.
Note that the final error is expected as the copy routine does the final read on the closed pty.
Closing for now as it doesn't seem related to the lib.

D'oh, I did not realize Copy was blocking, that makes sense in retrospect.
Thanks a lot for the very helpful response @creack, you went above and beyond!

Hi @creack, I wonder if you can help me shed some light on why my use-case does not appear to be working. I'm trying to hook things up in such a way that I can read and interpret the stdout "live". I've repurposed the code you shared above to reproduce my particular issue:
package main

import (
	"fmt"
	"io"
	"log"
	"os"
	"os/exec"

	"github.com/kr/pty"
)

type Process struct {
	cmd   *exec.Cmd
	pty   *os.File
	stdin io.Writer
}

func (p *Process) start() error {
	stdinR, stdinW := io.Pipe()

	outWriter := &stdWriter{}
	p.stdin = stdinW

	var err error
	if p.pty, err = pty.Start(p.cmd); err != nil {
		return err
	}

	go func() {
		_, err := io.Copy(outWriter, p.pty)
		if err != nil {
			log.Printf("Error while copying pty to output pipe: %v", err)
		}
	}()
	go func() {
		defer stdinW.Close()
		_, err = io.Copy(p.pty, stdinR)
		if err != nil {
			log.Printf("Error while copying input pipe to pty: %v", err)
		}
	}()

	return nil
}

type stdWriter struct {
}

func (w *stdWriter) Write(p []byte) (n int, err error) {
	fmt.Printf("Writing: %s", string(p))
	return len(p), nil
}

func main() {
	p := &Process{
		cmd: exec.Command("bash", "--rcfile", "hello.rc"),
	}
	p.start()

	go func() {
		fmt.Fprintf(p.stdin, "tty\n")
		fmt.Fprintf(p.stdin, "echo $PATH\n")
		fmt.Fprintf(p.stdin, "exit\n")
	}()
}

Everything here is the same as in your code, except for the way stdout is being handled. I mocked my own writer and using that to interpret stdout. When I do this with a regular process stdout it works fine, but when used with pty I get no output.
I'm a little confused because as far as I can tell this is not dissimilar from how your code above is handling it; you're just passing it a writer.
Any idea what's going wrong here?
Thank you

If the issue is with that exact piece of code, then it is just a problem of timing.
Add a time.Sleep(1 * time.Second) at the end of the main and you will see output. When main() returns, the program returns, without waiting on goroutines.
If you don't need a goroutine, you can also just call Wait() on the command.
If you do need it, you can use a channel.
Examples:
package main

import (
        "fmt"
        "io"
        "log"
        "os"
        "os/exec"

        "github.com/kr/pty"
)

type Process struct {
        cmd   *exec.Cmd
        pty   *os.File
        stdin io.Writer
}

func (p *Process) start() error {
        stdinR, stdinW := io.Pipe()

        outWriter := &stdWriter{}
        p.stdin = stdinW

        var err error
        if p.pty, err = pty.Start(p.cmd); err != nil {
                return err
        }

        go func() {
                _, err := io.Copy(outWriter, p.pty)
                if err != nil {
                        log.Printf("Error while copying pty to output pipe: %v", err)
                }
        }()
        go func() {
                defer stdinW.Close()
                _, err = io.Copy(p.pty, stdinR)
                if err != nil {
                        log.Printf("Error while copying input pipe to pty: %v", err)
                }
        }()

        return nil
}

type stdWriter struct {
}

func (w *stdWriter) Write(p []byte) (n int, err error) {
        fmt.Printf("Writing: %s", string(p))
        return len(p), nil
}

func main1() {
        p := &Process{
                cmd: exec.Command("bash", "--rcfile", "hello.rc"),
        }
        p.start()
        errChan := make(chan error, 1)
        go func() {
                errChan <- p.cmd.Wait()
                close(errChan)
        }()

        go func() {
                fmt.Fprintf(p.stdin, "tty\n")
                fmt.Fprintf(p.stdin, "echo $PATH\n")
                fmt.Fprintf(p.stdin, "exit\n")
        }()

        if err := <-errChan; err != nil {
                panic(err)
        }
}

func main() {
        p := &Process{
                cmd: exec.Command("bash", "--rcfile", "hello.rc"),
        }
        p.start()

        fmt.Fprintf(p.stdin, "tty\n")
        fmt.Fprintf(p.stdin, "echo $PATH\n")
        fmt.Fprintf(p.stdin, "exit\n")

        if err := p.cmd.Wait(); err != nil {
                panic(err)
        }
}

Thank you @creack, that was the missing link :)


Fix type defs for Credential interface

@hiranya911 before I go any farther:

Was there a reason getCertificate() is not in the .d.ts?
Are these typedef files normally hand-written?
Many implementations return null from getCertificate() get the typedef says Certificate not Certificate | null or Certificate | undefined ... why does that even compile?

Hi @samtstern.

Certificate is not part of our public API. So anything related to it doesn't appear in the typings.
Yes. Both Admin SDK's and JS SDK's typings are hand-written.
That's not something TypeScript enforces by default. You have to explicitly request it with --strictNullChecks.

So the reason I think we should expose this (I may misunderstand):

You can pass the credential field when you do admin.initializeApp() and we expect an admin.credential.Credential
If you do this and then use Firestore, it will explode because it calls getCertificate() on the credential object which is not guaranteed by the interface.  See code for details

So if credential is part of our public API then I think the API should express all of the properties and methods you need to make sure nothing crashes.

Then we ought to fix that in the admin Firestore code. Let's not add "Certificate" to the public API. For one thing it's a terrible (and incorrect) name. I've let it remain in the code because it's considered an internal API. Secondly there's no equivalent concept in any of the other GCP libraries.


first commit for BWTEST

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

I can help stop wasting your time refer this: #13481

I've created a test token on DevNet is there a seperate token-list to
update the name or does it use the main-net token list?
On Tue, Jan 11, 2022 at 4:42 AM zakimzf @.***> wrote:

I can help stop wasting your time refer this: #13481
https://github.com/solana-labs/token-list/pull/13481
—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/13412#issuecomment-1009767975,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWGXHMAPHLEJHLODK7VK3ZDUVP3QTANCNFSM5LU2C5JQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Trying to type destructured params using JSDoc throws

Code
/**
 * @param {object} options
 * @param {number} options.size
 * @param {string} [options.colour]
 */
function widget({size, colour = "red"}) {
  //
}

Actual behavior:
Type-checking a file with the above code throws
[js] JSDoc '@param' tag has name 'options', but there is no parameter with that name.

The example in the OP should be working in latest. the example in the second comment is not correct, since the function does not have a parameter called size or colour.
Try it with typesript@next. VSCode ships with an older version of TypeScript. Please see Using Newer TypeScript Versions documentation for more details on updating your VSCode to use a different version of TypeScript.

Uh, I did use a local build, but it was still checked out to an older tag because of #23479.
Thanks and sorry for the spam.


The diamond operator ("<>") should be used

No description provided.

No description provided.

Hello dear tasosstot,
2 years ago we were discussing the Connect-4 that I've uploaded to GitHub.
Take a look at how it is right now:
https://github.com/chriskormaris/Connect4
Also, since then, I've implemented my own Chess game completely from
scratch and I want your support.
Please give me a star if you can, right here:
https://github.com/chriskormaris/MyChessGame
All the best,
Christos Kormaris
On Mon, Jan 25, 2021 at 1:20 AM tasosstot @.***> wrote:

Closed #1.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Added Mega, Eonet, EPIC, TamTam

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[ ] All changes have been squashed into a single commit

sorry for the spam :(

We accept one API per PR @byt3h3ad
Please make sure you follow the guideline given in Contribution Guide and open the new PRs