one question many answer  And many question one answer

have simple method?
do not write
chatterbot.train([
"Hi there!",
"Hello",
])
chatterbot.train([
"Greetings!",
"Hello",
])
@gunthercox @vkosuri

@Air-boy i didn't understand could you please elaborate your question?

when i input "Hi there",robot response "Hello" or "OK, i know"
i write a *.corpus.json file  fellow:
{
"conversations":[
"i love you",
"me too"
],
[
"i love you",
"i love you too"
]
}
i input one request ,robot response "me too" or "i love you too"
if i have ten response, i hava to repeat ten times
if i write ten times this "i love you",  it is  redundancy
so i want to find a simple write way

@vkosuri

@Air-boy There is not a simpler way to organize the training data. The corpus files that ChatterBot uses are just simple structured data. If you need to generate data that has lots of redundant responses to a particular input I would assume that it would be simple to write some code to generate a corpus training file that contained each variation of the statement and it's possible responses.

@gunthercox   master  , i think  it is necessary,   for example: FAQ need this


Getting java.lang.ClassNotFoundException

Please, provide the details below:
Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?
Yes
Tell us about the problem

I have used one library here at https://search.maven.org/#artifactdetails|com.squareup.okhttp3|benchmarks|3.10.0|jar but i am not able to succeed.
Please provide the following version numbers that your issue occurs with:

Did the error happen while the app was being constructed? (buildtime error)
No
Did the error happen while the app was executing? (runtime error)
Yes
Please tell us how to recreate the issue in as much detail as possible.
include.gradle:
android {
}
repositories {
    mavenCentral()
}

dependencies {
    compile "com.squareup.okhttp3:okhttp:3.10.0"
}

In the class:
declare const com: any;
   greet() {
        try {
            console.log(typeof com.squareup.okhttp.OkHttpClient);
            let client = new com.squareup.okhttp.OkHttpClient();
            let requestBody = new com.squareup.okhttp.MultipartBuilder()
                    .type(com.squareup.okhttp.MultipartBuilder.FORM)
                    // .addFormDataPart("file", file.getName(),
                    //     com.squareup.okhttp.RequestBody.create(com.squareup.okhttp.MediaType.parse("text/csv"), file))
                    .addFormDataPart("firstName", "Idrees")
                    .build();

            let request = new com.squareup.okhttp.Request.Builder()
                    .url('http://localhost:10011/home/fileUpload')
                    .post(requestBody)
                    .build();

            client.newCall(request).enqueue(() => {
            });

        } catch (e) {
            console.log('-----------------error----------------');
            console.log(e);
        }
    }

But i am getting:
JS: -----------------error----------------
JS: Error: java.lang.ClassNotFoundException: com.squareup.okhttp.OkHttpClient
JS:     java.lang.Class.classForName(Native Method)
JS:     java.lang.Class.forName(Class.java:453)
JS:     java.lang.Class.forName(Class.java:378)
JS:     com.tns.Runtime.getClassForName(Runtime.java:1010)
JS:     com.tns.ClassResolver.resolveClass(ClassResolver.java:27)
JS:     com.tns.Runtime.resolveClass(Runtime.java:581)
JS:     com.tns.Runtime.callJSMethodNative(Native Method)
JS:     com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1088)
JS:     com.tns.Runtime.callJSMethodImpl(Runtime.java:970)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:957)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:941)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:933)
JS:     com.tns.gen.java.lang.Runnable.run(Runnable.java:10)
JS:     android.os.Handler.handleCallback(Handler.java:789)
JS:     android.os.Handler.dispatchMessage(Handler.java:98)
JS:     android.os.Looper.loop(Looper.java:164)
JS:     android.app.ActivityThread.main(ActivityThread.java:6938)
JS:     java.lang.reflect.Method.invoke(Native Method)
JS:     com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
JS:     com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)
JS: Caused by: java.lang.ClassNotFoundException: Didn't find class "com.squareup.okhttp.OkHttpClient" on path: DexPathList[[zip file "/data/app/org.nativescript.demong-tXcVa09BodDtVGlxcv9aLQ==/base.apk"],nativeLibraryDirectories=[/data/app/org.nativescript.demong-tXcVa09BodDtVGlxcv9aLQ==/lib/arm, /data/app/org.nativescript.demong-tXcVa09BodDtVGlxcv9aLQ==/base.apk!/lib/armeabi-v7a, /system/lib, /vendor/lib]]

If i output the i am getting all the functions available with console.dir(com.squareup.okhttp.OkHttpClient):
JS: Address()
JS: Dns()
JS: CertificatePinner()
JS: Authenticator()JS: HttpUrl()
JS: Request()JS: Response()
JS: Cache()
JS: CacheControl()
JS: Headers()
JS: Call()
JS: OkHttpClient()
JS: Callback()
JS: Challenge()
JS: CipherSuite()
JS: Connection()
JS: Handshake()
JS: Protocol()
JS: Route()
JS: ConnectionPool()
JS: ConnectionSpec()
JS: TlsVersion()
JS: Credentials()
JS: Dispatcher()
JS: FormEncodingBuilder()
JS: RequestBody()
JS: Interceptor()
JS: MediaType()
JS: MultipartBuilder()
JS: OkUrlFactory()
JS: ResponseBody()
JS: benchmarks: {}
JS: internal: {
JS:   "io": {},
JS:   "http": {},
JS:   "tls": {},
JS:   "framed": {},
JS:   "huc": {},
JS:   "ws": {}
JS: }

i have attached the zip file here https://we.tl/ElgFxbQHx0

@dotnetdreamer, there seems to be a couple of issues with your code. You seem to be using the okhttp library version 3.10.0 which according to its documentation has slightly different packages and classes.

You are trying to use the com.squareup.okhttp package which has been renamed to okhttp3.
There's no MultipartBuilder class in 3.10.0
You cannot pass an anonymous javascript callback to the enqueue method because it expects a java interface that you need to implement.

Here's the revised version of your code which should work with 3.10.0:
try {
    let client = new okhttp3.OkHttpClient();
    let requestBody = new okhttp3.MultipartBody.Builder()
            .setType(okhttp3.MultipartBody.FORM)
            .addFormDataPart("firstName", "Idrees")
            .build();

    let request = new okhttp3.Request.Builder()
            .url('http://localhost:10011/home/fileUpload')
            .post(requestBody)
            .build();

    var callback = new okhttp3.Callback({
        onResponse: (call, e) => {
            console.log("Success");
        },
        onFailure: (call, e) => {
            console.log(e);
        }
    });

    client.newCall(request).enqueue(callback);
} catch (e) {
    console.log('-----------------error----------------');
    console.log(e);
}

And here's the modified version of your plugin that you may try nativescript-http-formdata.zip

@darind wow in 1 minute you made me realize all the mistakes i was doing. Won't thank you but rather hug you. Thanks for your time that you spent on it 🥇 it worked.


Docker image missing Jupyter

I ran the following:
docker pull jupyter/jupyterhub
docker run -d --name jhub -p 8000:8000 jupyter/jupyterhub jupyterhub --no-ssl
docker exec -it jhub bash #To eventually configure users/passwords

After adding a user and setting the user's password I attempted to log in via the JupyterHub UI.
The UI shows the following error message:
500 : Internal Server Error
Spawner failed to start [status=1]

I see this in the log:
[I 2016-03-09 23:08:15.661 JupyterHub spawner:436] Spawning jupyterhub-singleuser --user=denton --port=52848 --cookie-name=jupyter-hub-token-denton --base-url=/user/denton --hub-host= --hub-prefix=/hub/ --hub-api-url=http://<IP_ADDRESS>:8081/hub/api --ip=<IP_ADDRESS>
Traceback (most recent call last):
  File "/opt/conda/bin/jupyterhub-singleuser", line 21, in <module>
    import notebook
ImportError: No module named 'notebook'
2016-03-09T23:08:15.884289173Z
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/opt/conda/bin/jupyterhub-singleuser", line 23, in <module>
    raise ImportError("JupyterHub single-user server requires notebook >= 4.0")
ImportError: JupyterHub single-user server requires notebook >= 4.0
[W 2016-03-09 23:08:25.686 JupyterHub web:1521] 500 POST /hub/login?next= (<IP_ADDRESS>): Spawner failed to start [status=1]
[E 2016-03-09 23:08:25.698 JupyterHub log:99] {
      "Accept-Encoding": "gzip, deflate",
      "Accept-Language": "en-US,en;q=0.8",
      "Origin": "http://<IP_ADDRESS>:8000",
      "X-Forwarded-Proto": "http",
      "X-Forwarded-For": "<IP_ADDRESS>",
      "Host": "<IP_ADDRESS>:8000",
      "Content-Type": "application/x-www-form-urlencoded",
      "Cache-Control": "max-age=0",
      "Connection": "close",
      "Content-Length": "29",
      "X-Forwarded-Port": "8000",
      "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36",
      "Upgrade-Insecure-Requests": "1",
      "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8",
      "Referer": "http://<IP_ADDRESS>:8000/hub/login"
    }
[E 2016-03-09 23:08:25.698 JupyterHub log:100] 500 POST /hub/login?next= (@<IP_ADDRESS>) 10425.97ms
[W 2016-03-09 23:08:45.778 JupyterHub user:262] denton's server never showed up at http://<IP_ADDRESS>:52848/user/denton after 30 seconds. Giving up
[E 2016-03-09 23:08:45.791 JupyterHub gen:871] Exception in Future <tornado.concurrent.Future object at 0x7fc2554897b8> after timeout
    Traceback (most recent call last):
      File "/opt/conda/lib/python3.5/site-packages/tornado/gen.py", line 867, in error_callback
        future.result()
      File "/opt/conda/lib/python3.5/site-packages/jupyterhub/user.py", line 278, in spawn
        raise e
      File "/opt/conda/lib/python3.5/site-packages/jupyterhub/user.py", line 254, in spawn
        yield self.server.wait_up(http=True, timeout=spawner.http_timeout)
      File "/opt/conda/lib/python3.5/site-packages/jupyterhub/orm.py", line 108, in wait_up
        yield wait_for_http_server(self.url, timeout=timeout)
      File "/opt/conda/lib/python3.5/site-packages/jupyterhub/utils.py", line 94, in wait_for_http_server
        **locals()
    TimeoutError: Server at http://<IP_ADDRESS>:52848/user/denton didn't respond in 30 seconds

These are the installed pip packages (Jupyter is missing!):
# pip list
conda (4.0.1)
conda-env (2.4.5)
decorator (4.0.9)
ipython-genutils (0.1.0)
Jinja2 (2.8)
jupyterhub (0.6.0.dev0)
MarkupSafe (0.23)
pamela (0.2.1)
pip (8.1.0)
pycosat (0.6.1)
PyYAML (3.11)
requests (2.9.1)
setuptools (20.2.2)
SQLAlchemy (1.0.12)
tornado (4.3)
traitlets (4.1.0)
wheel (0.29.0)

Running pip install jupyter inside the container appears to resolve error.
Jupyter should come embeded in the jupyter/jupyterhub Docker image, correct? Thanks!

The jupyter/jupyterhub image is only an image for running the Hub service itself. It does not require the other Jupyter components, which are needed by the single-user servers.

Thanks for the response. Maybe mention that in the Docker related portion of the README.md file in case other users encounter the same issue.

@nevdullcode I've gone ahead and taken your suggestion to clarify the README. Thanks!

@willingc @minrk Thank you both for the clarification!

@nevdullcode :sunny:


Add -g option for attaching to existing group

Adds an option -g/--group that opens a fuzzy finder with current sessions, and starts a new session in a group with  the selected session
note: you can still use -g with -d and -n
closes #19

@tombuntus do/can you build this yourself to see if this does what you're hoping? or do you just use binary from nix or something?

i originally wanted to avoid adding a fuzzy search through existing sessions but i think it makes sense for this use case, so if this is working i'm also going to add -e/--existing to fuzzy find through open sessions and attach normally

I will try and build it later today. I have been giving this some thought and I wonder if a better workflow might be to just add an indicator alongside workspaces that already have a session in the regular twm workspace list, and then have enter attach to that session but ctrl+enter create a new session in a session group.
If we fuzzy find over existing sessions, then realise that the workspace we want to open doesn't have an existing session, we have to exit and relaunch twm to find the workspace and create a new session.

i imagine that most of the time that I want to have a second session in a group, it's probably because I already have the original session open and thus obviously know that session exists

This is probably fair. I do often forget that I already have a client attached to a session, but that's a different issue I think.
I have built this branch and yes it works 👌 A nice side effect is that I can see when I already have a session group I forgot about.


Duplicate class error since 0.10.0 (Stately)

In one of my projects Dependabot wants to update cache4k from 0.9.0 to 0.10.0 but now the build fails with
Execution failed for task ':app:checkDebugDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class co.touchlab.stately.HelpersJVMKt found in modules stately-common-jvm-2.0.0-rc1 (co.touchlab:stately-common-jvm:2.0.0-rc1) and stately-strict-jvm-2.0.0-rc1 (co.touchlab:stately-strict-jvm:2.0.0-rc1)

Note: This is an Android/JVM project, no multiplatform project.

Probably related to this commit.

do you happen to have stately brought in by other library? I don't think you do but just checking 😃

Got the same error in my multiplatform project. Checked my dependency tree too, stately is from cache4k.

Fixed in #36

``


all: Update txnbuild to support fee bump transactions

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
This PR refactors txnbuild.Transaction  to support features introduced in the upcoming protocol 13 release (in particular CAP 15  and CAP 18). The new API for txnbuild is not backwards compatible which is why the version for this release is a major version bump from the last horizon client release.
Users of txnbuild and horizonclient should upgrade to v3.0.0 before protocol 13 is enabled.  Pre v3 clients will still be able to submit transactions to a protocol 13 enabled stellar network. However, pre v3 clients will not able to parse xdr strings corresponding to protocol 13 transactions.
It is safe to upgrade to v3.0.0 before protocol 13 is enabled because we have configured txnbuild to construct transactions which are compatible with both protocol 12 and protocol 13. After protocol 13 is enabled, we will create a v3.1.0 release of horizon client which configures txnbuild to construct transactions which are only compatible with protocol 13.
Known limitations
All services in the go monorepo will need to use the new txnbuild interface. But I have not updated the code in the monorepo including tests to use the new Transaction implementation. I would like feedback on the interface before I proceed with updating all the usages of txnbuild.

I wanted to make Transaction immutable which is why signing a Transaction instance returns a new Transaction instance with the additional signatures. However, I realized if I want to make Transaction completely immutable, I'd need to create copies when returning from Operations() and Signatures(). Otherwise, if I returned the slice bound to the Transaction struct, the caller could modify the contents of the slice and it would also modify the Transaction instance.
To be honest, I'm not sure if this is the right approach considering the overhead. Also, there's another issue which is that individual signatures and operations are mutable. So, even if you don't modify the slice you can still end up mutating the Transaction instance by modifying a specific signature or operation contained within the slice. To make Transaction fully immutable I'd need to create copies of each individual operation (and similarly for the signatures).
Here are the possible options:

only enforce that signing be immutable but do not return new copies of slices in Operations() and Signatures(). Also, document that the slices returned by Operations() and Signatures() should not be modified.
keep implementation as is
extend immutability guarantee by cloning each signature and operation when duplicating operations and signatures in Operations() and Signatures().

The current interface is a best effort attempt at merging normal transactions and fee bump transactions into one type. A more accurate representation of the normal vs fee bump transaction dichotomy would require sum types.  Although sum types are not natively supported in Go, I have tried to implement an alternative transaction interface which resembles a sum type here:
https://github.com/tamirms/go/commit/d2666f52fb5e888c3396b857e79ba7935a545a1e
Which of the two versions do you prefer?

In my opinion all of the other methods are not necessary because the values are defined in TransactionConfig, ie. I don't think anyone will call them after creating a new Transaction using TransactionConfig, maybe except sequence number.

There are two use cases for the txnbuild package: constructing new transactions
(e.g. NewTransaction() and NewFeeBumpTransaction()) and parsing transactions from xdr strings (e.g. TransactionFromXDR()).
I think removing all the accessors from Transaction and only allowing signing is a decent idea. But, then the type returned by TransactionFromXDR() cannot be Transaction. Returning a TransactionConfig from TransactionFromXDR() isn't what we want either because a transaction envelope may contain signatures and those values would not be present in a TransactionConfig instance.

It looks good to me, I think it's worth checking with heavy users of txnbuild.

I agree. This approach look fine to me, however I don't like that non-fee-bump-transactions are polluted with methods only applicable to fee-bump transactions (the other alternative is better in this regard). I think that the type system should guide the user on what can be called and what not. This would make the methods self-explanatory and safer (it won't allow calling feebump methods on non-feebump transactions.
Here is a proposal:
type Transaction {
// ...
}

func (t *Transaction) SourceAccount() SimpleAccount {
	return t.sourceAccount
}

type FeeBump struct {
  tx *Transaction // internally, feebump is identical to a transaction, but they user doesn't know
}

func (t *Transaction) FeeBump() (bool, *FeeBump) {
	if t.isFeeBump {
           return FeeBump{t}
        }
        return nil
}

func (t *FeeBump) InnerTransaction() *Transaction {
 // By construction you know it's a feebump transaction, no need to check
}

// ...

As it stands right now:

Treats transactions uniformly
Doesn't pollute non-FB-transactions

This PR
✓
✕

Alternative, sumtype approach
✕
✓

I think we should go with what's more usable, favoring the most common usage pattern.
In a nutshell:

If using the feebump methods are an exception, I would go for the approachin this PR (although I think we can get a bit more help from the type system, as I suggest above).
If using the feebump methods is going to be common, then I would go for the alternative approach, since the drawback of  feebump approach.

I think that with the change I suggest, you would get the best of both worlds:

Treats transactions uniformly
Doesn't pollute non-FB-transactions

Adding a FeeBump type
✓
✓

A fee bump transaction wraps a normal transaction but provides a new max fee which is paid for by the fee account. Also, the fee bump transaction has a separate set of signatures from the fee account.
In @2opremio's approach when TransactionFromXDR() is called on a fee bump xdr string, the return value is a Transaction instance which corresponds to the inner transaction of the fee bump transaction.

Memo() will return the memo of the inner transaction
Operations() will return the operations of the inner transaction
SourceAccount() will return the source account of the inner transaction

Here is the crucial difference between @2opremio's approach and the prototype in this PR. In @2opremio's approach:

Signatures() will return the the signatures of the inner transaction
TotalFee() / BaseFee() will return the the fee of the inner transaction

To obtain the fee, signatures, or fee account from the fee bump transaction, you need to call FeeBump() which will return a different type that has all those values.
In the code committed to this PR:

Signatures() will return the the signatures of the fee bump transaction
TotalFee() / BaseFee() will return the the fee of the fee bump transaction

To obtain the fee or signatures from the inner transaction, you need to call InnerTransaction() which will return a transaction instance that has all those values.
I am convinced @2opremio's approach is better because it ensures that Transaction will only return values from the inner transaction and that FeeBumpTransaction will only return values from the fee bump part of the transaction. In contrast, the Transaction from this PR will mostly return values from the v1 transaction envelope but if you call Signatures(), TotalFee(), or BaseFee() it will return values from the fee bump part.
Now I will analyze the tradeoffs between the sum type implementation and @2opremio 's approach

Another idea to simplify the Transaction interface is by adding a method to generate a TransactionConfig from an immutable Transaction, for cases where the Transaction needs to be modified. Then you mess with that (add signatures, modify seqnum etc) and build to get a new Transaction.

I think I'll punt on that for now because both the Javascript and Java SDK use the builder pattern for constructing transactions but none of those implementations support creating a new builder instance from an existing transaction. Also, I haven't been able to find examples where this functionality would be useful.

I've looked at all the usages of txnbuild in the go monorepo and other repos within stellar org (e.g. kelp). I also did a search for public Go code on github which contains the string txnbuild. Note that there are basically two ways you can use txnbuild:

create new transactions
parse xdr strings by calling TransactionFromXDR() and examine them as Transaction instances.

As you would expect, almost all uses of  txnbuild are for constructing transactions. Both @2opremio 's proposal and the sum type implementation are equally streamlined when it comes to building new transactions.
So, I decided to focus on how TransactionFromXDR() is used. In most of the cases I found TransactionFromXDR() was used to implement multisig signing. The common workflow was that the application received an xdr string and then it parsed  it using TransactionFromXDR(). Afterwards, the application would add another signature before submitting it to the network or outputting the transaction back to the end user.
The other uses of TransactionFromXDR() I found were to implement SEP 30 and SEP 10.
When determining which proposal to choose I think it's important to look at specifically if there is a difference between how fee bump transactions are handled compared to normal non fee bump transactions.
In the case of SEP 10, my assumption is that we want to reject tokens which are fee bump transactions because we want to remove ambiguity on how we interpret challenge tokens. This is the reasoning behind why SEP 10 is not allowing muxed accounts (see https://github.com/stellar/stellar-protocol/issues/562 ).
I also believe that we want to reject requests to the recovery signer service which ask to sign a fee bump transaction. According to SEP 30 the use case for the sign endpoint is to authorize adding a new signer or removing an existing signer from an account:

it is anticipated for the use cases discussed earlier in this protocol that the transaction will contain an operation to add a new signer to the account and possibly to remove an old signer or to merge an account.

With regards to the general purpose multisig use case, I can anticipate that a multisig implementation may want to sign a fee bump transaction thereby allowing a multisig wallet to be the fee source for a someone else's transaction. But, I also think that it depends a lot on how the wallet will be used. There may be cases where the wallet will only sign off on a very limited subset of transactions (e.g. the signer recovery use case).
I am now leaning towards using the sum type implementation because, in that implementation, a Transaction must be unpacked into either SimpleTransaction or a FeeBumpTransaction. The caller will be forced to consider how it should handle fee bump transactions. With @2opremio 's proposal the onus is on the caller to be proactive about checking the type of a transaction. I think we should treat signing transactions with precaution so that is why I favor the sum type implementation.

I think the advantage the sum type implementation provides that the developer is forced to be aware of the transaction type is good, but I also think that general code I write to sign a transaction cares less about the contents of the transaction and more about just signing the transaction. If I want to be able to sign any transaction I have to write code knowing about both types of transactions.
 That looks like a new concept we're introducing that isn't rooted in the XDR. Will other SDKs call a non-fee-bump txn a "simple transaction" too? This may be another point of vocab disparity in different SDKs and implementations.
I'm struggling to imagine what using these different approaches would be like from the users perspective looking at just the implementations. Do we have any example code showing what the experience will be like for the user? I think we should have that drive our decision.

@leighmcculloch

I think the advantage the sum type implementation provides that the developer is forced to be aware of the transaction type is good, but I also think that general code I write to sign a transaction cares less about the contents of the transaction and more about just signing the transaction.

yes, there is the tradeoff. To evaluate the tradeoff I suggest you consider the following questions:

Given some xdr string do you want to examine the contents of the transaction before signing off on it?
How often would you want to sign the transaction without looking at the contents of the transaction vs first validating the transaction and then adding your signature?
If you care about validating the transaction, unpacking the transaction type is helpful. On the other hand, if you don't care about validating the transaction, unpacking the transaction type is an unnecessary speed bump. Is it ok to add a speed bump to the later case to prioritize the workflow of validating and then signing?

If I want to be able to sign any transaction I have to write code knowing about both types of transactions, and if I'm going to do that I may as well use the xdr package directly?

If you want to use the xdr package without txnbuild to sign a transacton you'd still need to know how to sign a transaction (e.g. which parts do you need to hash?). But, apart from that detail, you are correct.

Will other SDKs call a non-fee-bump txn a "simple transaction" too?

In the Javascript SDK the equivalent of TransactionFromXDR() returns a Transaction | FeeBumpTransaction type. @abuiles please correct me if I'm wrong.
But to your point about the names, I am definitely open to considering different names for the two transaction types. I will try to come up with better names.

Do we have any example code showing what the experience will be like for the user?

Did you see that ReadChallengeTx() was updated to work with the new transaction types in the commit? https://github.com/tamirms/go/commit/d2666f52fb5e888c3396b857e79ba7935a545a1e#diff-f6a8a4abae844d51cc40cb628ba55d71R757
I'm currently working on fixing all the references to the txnbuild package within the monorepo (including tests). Here's what it looks like to build a transaction:
func TestVerifyChallengeTxThreshold_invalidNoSigners(t *testing.T) {
	serverKP := newKeypair0()
	clientKP1 := newKeypair1()
	clientKP2 := newKeypair2()
	clientKP3 := keypair.MustRandom()
	txSource := NewSimpleAccount(serverKP.Address(), -1)
	opSource := NewSimpleAccount(clientKP1.Address(), 0)
	op := ManageData{
		SourceAccount: &opSource,
		Name:          "testserver auth",
		Value:         []byte(base64.StdEncoding.EncodeToString(make([]byte, 48))),
	}
	threshold := Threshold(10)
	signerSummary := SignerSummary{}

	tx64, err := NewSignedSimpleTransaction(
		TransactionParams{
			SourceAccount:        &txSource,
			IncrementSequenceNum: false,
			Operations:           []Operation{&op},
			BaseFee:              100,
			Timebounds:           NewTimeout(1000),
		},
		network.TestNetworkPassphrase,
		serverKP, clientKP1, clientKP2, clientKP3,
	)
	assert.NoError(t, err)

	_, err = VerifyChallengeTxThreshold(tx64, serverKP.Address(), network.TestNetworkPassphrase, threshold, signerSummary)
	assert.EqualError(t, err, "no verifiable signers provided, at least one G... address must be provided")
}

This is the workflow that is most negatively affected by the refactor:
func addMysignature(tx64 string, kp *keypair.Full) (string, error) {
	parsed, err := TransactionFromXDR(tx64)
	if err != nil {
		return "", err
	}

	if tx, ok := parsed.FeeBump(); ok {
		tx, err = tx.Sign(network.TestNetworkPassphrase, kp)
		if err != nil {
			return "", err
		}
		return tx.Base64()
	} else if tx, ok := parsed.Simple(); ok {
		tx, err = tx.Sign(network.TestNetworkPassphrase, kp)
		if err != nil {
			return "", err
		}
		return tx.Base64()
	} else {
		return "", fmt.Errorf("invalid transaction")
	}
}

@tamirms Thanks, those examples were 💯 really helpful. I think the sum types is a compelling solution even in the inconvenience of signing arbitrary transactions. I agree we might want to add signing functions to that top-level, but I don't think they'll be used by everyone and will expand the surface area of the API with little gain. It's a nice solution 👍.

But to your point about the names, I am definitely open to considering different names for the two transaction types. I will try to come up with better names.

I'm thinking about better names for this too.

NewSignedSimpleTransaction

I think we should reconsider adding functions like this that are just sugar. They cause code someone uses to build some types of transactions in some specific use cases to be very different to other use cases. If someone writes a lot of code using this function then needs the transaction hash they either need to reparse the transaction to get the hash, or they have to rewrite the code. I regret that we have the SEP-10 functions that build transactions and return a base64 encoded string, I'm dealing with that right now in the webauth app. Ideally everywhere this SDK is used has building a transaction in the exact same way everytime.

@stellar/horizon-committers @stellar/vega-backend
I still need to add tests which exercise the fee bump code paths. But aside from that, the PR is ready for review. Please take a look, thanks!

I am missing a CHANGELOG entry warning the users about breaking changes. @tamirms mentioned this will come in a later PR. I think we should include examples indicating how to update the code (in this or another PR).


Helm Chart NODE_IP should be optionally configurable.

I am seeing an issue in AWS EKS where worker nodes are unable to connect to port 30020 of the NODE_IP.   By manually patching the daemonset and setting the NODE_IP to <IP_ADDRESS> this allows Spegel mirroring to work.   This issue is being raised to have the NODE_IP optionally configured if needed.
EKS Version: 1.28
Spegel version: v0.0.16

Sorry about the regression issues. Its difficult getting things right as CNIs seem to partially implement standards and cloud providers slightly differ. What is the error that you are specifically seeing when staring Spegel?

BTW I created a PR for this fix already here.
Hi there, the error:
Dec 29 00:27:49 eks-node-1 containerd[2413588]: time="2023-12-29T00:28:49.669982205Z" level=info msg="trying next host" error="failed to do request: Head \"http://<IP_ADDRESS>:30021/REDACTED/REDACTED/REDACTED/REDACTED/manifests/ed7e4e82?ns=ghcr.io\": dial tcp <IP_ADDRESS>:30021: i/o timeout" host="<IP_ADDRESS>:30021"

Hei @phillebaba, the problem persists also in version 0.0.23, which is causing some issues when upgrading to version 0.0.24. The patch we must apply to make it work in our environments compromises all changes to Spegel. Can I do anything to make progress on the pull request linked to this issue? Should I open it again?
Thank you!

Fixed by #578


Verify group membership

i'm trying to implement multi servers ldap authentication mentioned in docs, the thing is auth process is flawless but with adding group to options parameters i get this:
[0] => Account is not a member of the specified group [1] => Failed to verify group membership with (&(&(cn=grpTest)(grpTest=CN=Hamed Okhovvat,OU=IT,DC=Domain,DC=local))(objectClass=groupOfUniqueNames))
Is there any recommendation to verify group membership?
Thanks a lot in advance

This repository has been closed and moved to laminas/laminas-authentication; a new issue has been opened at https://github.com/laminas/laminas-authentication/issues/5.


Implement Transaction Receipts

To get the <caller>/<origin> of the transaction we need to call ECDSARecover ( String , Int , String , String ) (from krypto.md) on the hash of the rlp-encoded transaction, v, r, s values, and then take the lower 120 bits of that as the address to you.
There is a helper in web3.md for getting the hash of the rlp-encoded transaction hashUnsingedTx( TXID ).


Add pdfromlatent to MultiCategoricalPdType; update deprecated tf functions

MultiCategoricalPdType is missing pdfromlatent()
update tf arguments: use keepdims instead of keep_dims for tf.reduce_max, and use softmax_cross_entropy_with_logits_v2

@pzhokhov @joschu any chance of review? thanks

Looks good to me, but ideally I'd like to see some tests (I know there are not many yet, but we are trying to put them in place). For now just a successful construction of the policy network with MultiCategoricalPd policy type test should be ok

I have merged https://github.com/openai/baselines/pull/677 with changes along the same lines... please review / resolve conflicts, and let's merge it


chore(babel,flow): realign version bumps

Summary
While working on https://github.com/facebook/react-native/pull/35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape.
Happy to split in multiple PRs if needed.
Changelog

[GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.196.3 in a few places that were left out from latest bump
Test Plan

CI is green.

Thanks! This is one of those changes that'll need aligning across Meta projects to pass internal CI - the @babel/runtime is a big one - but I'll see if we can make it stick.

Thanks! This is one of those changes that'll need aligning across Meta projects to pass internal CI - the @babel/runtime bump is a big one - but I'll see if we can make it stick.

yeah no worries, I'm happy to split in multiple PRs if needed (in particular the flow aligments and the babel bump in template)

@robhogan just wanted to check in how's it going for this PR - as mentioned, I'm happy to split in multiples to get as much of this in as possible right away

@robhogan @cipolleschi I just gave another pass and a cleanup to this PR, is it worth keeping open or I should just close it?

I don't know... maybe @robhogan has more info/ideas?

Sorry for not getting back @kelset - this is a tricky one to land because it needs syncing with a bunch of other projects outside RN. I suggest we hold it until after @hoxyq's monorepo work (which I know is bumping/syncing a few of these deps anyway) and then tidy up what's left.

Sorry for not getting back @kelset - this is a tricky one to land because it needs syncing with a bunch of other projects outside RN. I suggest we hold it until after @hoxyq's monorepo work (which I know is bumping/syncing a few of these deps anyway) and then tidy up what's left.

Monorepo changes also include bumping yargs outside of react-native, but not in react-native-github/hermes-inspector-msggen. I think we should return to this PR next week, if monorepo won't be landed by this time, we should at least merge this PR to have in 0.72 (as stated in summary)

works for me, let's keep this frozen until the monorepo PR is successfully landed 👍 thanks for the update folks

allright, branch rebased and updated! lmk what you want to do with it folks 🤗

What's the actionable here, @robhogan @hoxyq? do we need to import and land this?

@kelset Lorenzo Sciandra FTE Looks like we completely missed it, can you please resolve the conflicts and I will help with importing it this week?

I'm at chainreact - will take a look next week 🤗


shulker box + hopper cause dupe

put item in shulker box, place above a hopper
the first item that appears will be doubled
https://youtu.be/H3l38ScI1mU

I will fix this ASAP. You are using folia, right?

yes

Okay, so what I have found is that this only works on folia servers, because for some reason on bukkit it takes 1 tick before a hopper tries to take items from shulkers, but on folia (and also in vanilla) it is instant.
I will have to recode the shulker placement part, I will try to do this within a few hours

Try the latest version


chore(master): release 1.3.0

:robot: I have created a release beep boop
1.3.0 (2024-02-26)
Features

add test workflow (53def06)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Blvckleg/BingusBoingus/releases/tag/v1.3.0 :sunflower:


Superjson transformer giving errors

I believe this may have something to do with removing the trpc wrapper? It was working before when I was using beta package

Closing this since it's probably my fault with something else

Interesting. I'm using superjson in the playground and didn't encounter any issue.

Yeah, it only seems to be happening after I build and run npm start, I’ll have a further look into this


Replace most occurrences of "indexes" with "indices"

This PR removes most occurrences of "indexes" with "indices" in code, comments, and docs.

Nothing in ./tests was changed. Perhaps all tests should be changed to use node_indices since this just wraps node_indexes.

The two methods node_indexes that will likely be deprecated were, of course, not changed.

release notes mentioning the addition of node_indexes were, of course, not changed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 11 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 98.507%

Totals

Change from base Build<PHONE_NUMBER>:
0.008%

Covered Lines:
11942

Relevant Lines:
12123

💛  - Coveralls

Thanks for replacing the uses of node_indexes. If the function is deprecated we shouldn't use internally.


Setting screen brightness does not work on Acer TravelMate B 117 (Braswell)

sysctl hw.acpi.video.lcd0.brightness just gets ignored.
% kldstat | grep acpi
35    1 0xffffffff841f2000     20f0 acpi_wmi.ko
36    1 0xffffffff841f5000     2b88 acpi_video.ko

xbacklight does not do anything either.
% sudo intel_backlight
Current backlight value: -2147483648% (0/0)

Is also not working.
How to set brightness here?

intel_backlight seems to be stuck at -2147483648% on this device:
Users-TravelMate-B117-M% intel_backlight decr

Current backlight value: -2147483648% (0/0)
set backlight to -2147483648% (0/0)

How to fix this?

You're using vga graphics.
Does kldload i915kms work?

Users-TravelMate-B117-M% sudo kldload i915kms
Password:
kldload: can't load i915kms: module already loaded or in kernel

Users-TravelMate-B117-M% cat /usr/local/etc/X11/xorg.conf.d/10-video-initgfx.conf
Section "Device"
    Identifier    "Intel Graphics"
    Driver        "modesetting"
    BusID         "PCI:0:2:0"
EndSection

This brings the question, why is it not used (by initgfx) on my system...

Adding 0x22b1 to /etc/initgfx_device.db results in
Users-TravelMate-B117-M% cat /usr/local/etc/X11/xorg.conf.d/10-video-initgfx.conf
Section "Device"
    Identifier    "Intel Graphics"
    Driver        "intel"
    Option        "AccelMethod"    "uxa"
    Option        "TripleBuffer"   "true"
    Option        "HotPlug"        "true"
EndSection

But  as soon as picom is started, the system becomes unbearably slow. Not sure whether this is a picom issue.

In any case, the other aspects have not improved:
Users-TravelMate-B117-M% sysctl hw.acpi.video.lcd0.active
hw.acpi.video.lcd0.active: 0

Users-TravelMate-B117-M% sysctl -a | grep lcd
hw.acpi.video.lcd0.levels: 100 30 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100
hw.acpi.video.lcd0.economy: 30
hw.acpi.video.lcd0.fullpower: 100
hw.acpi.video.lcd0.brightness: 100
hw.acpi.video.lcd0.active: 0

Users-TravelMate-B117-M% sudo sysctl hw.acpi.video.lcd0.fullpower=10
Password:
hw.acpi.video.lcd0.fullpower: 100 -> 10

Users-TravelMate-B117-M% sudo sysctl hw.acpi.video.lcd0.brightness=10
hw.acpi.video.lcd0.brightness: 10 -> 10

Users-TravelMate-B117-M% sudo intel_backlight 1
Current backlight value: -2147483648% (0/0)
set backlight to -2147483648% (0/0)

Still cannot control the backlight brightness.

Opened https://github.com/nomadbsd/NomadBSD/issues/90 upstream.

If i915kms is loaded...
Then why doesn't it appear to be being used?

Not sure whether this is a picom issue.

Try KWin.

If i915kms is loaded...
Then why doesn't it appear to be being used?

That is the :100: question.

A lot of newer backlight won't work without drm modules loaded.

The correct way to deal with those backlight is to use drm-kmod and backlight(8) on FreeBSD >= 13.

Thank you very much @evadot. I confirm that using backlight(8) is working on FreeBSD 13.
Maybe it would be good to mention that the drm.ko kernel module must be loaded and intel_backlight.ko should not be loaded on the man page for backlight(8).

backlight(8) is now also bound to the brightness keys:
https://github.com/helloSystem/ISO/commit/3b814ebfe7e2aa02b4dc45398b6ec3c64d4ccb62

Thank you very much @evadot. I confirm that using backlight(8) is working on FreeBSD 13.
Maybe it would be good to mention that the drm.ko kernel module must be loaded and intel_backlight.ko should not be loaded on the man page for backlight(8).

backlight doesn't need drm, the drm drivers install their backlight.
On arm systems I don't need drm to have the backlight.
intel_backlight isn't a kmod and was never part of base so I don't think that we should add a note in the man page.

OK, I understand. So happy that it is working now. :+1:

By contrast, some computers do need kms drivers in order for the brightness
controls to work.

By contrast, some computers do need kms drivers in order for the brightness
controls to work.

Do you have an example?


UICircularProgressRing.innerRingColor not updating

READ BEFORE POSTING AN ISSUE
Not following these guidelines may result in me ignoring or closing your issue, please carefully read and submit an appropriate issue as it helps with time and fixes.
Please provide the current version of the library you are using

Version = 1.4.2

Have you read the documentation?

[x] Yes

Is it a bug? Provide the following

Detailed overview of what you are trying to accomplish

Hello, i have implemented UICircularProgressRing in my project. actually im getting percentage value from webservice and i'm setting it to theUICircularProgressRing and it is working fine with animation with proper color for both inner and outer ring. But after loading and setting the percentage successfully i need to change the theme color for my views and also for UICircularProgressRing. but the color is not setting for the UICircularProgressRing.innerRingColor
but when my viewdidLoad method is called then the new color is setting for the inner ring properly.
Please Help.
ThankYou.

The issue is Solved Now.  Actually i found out that the colour is only changing when we change the percentage value. so in that case, i did following:
when my theme colour is changed i made the percentage = 0.0 and then on next line again i changed the percentage to actual value.
Thanks.


Add Company field

Once https://github.com/almighty/almighty-core/issues/1052 is complete

Fixed by https://github.com/fabric8-ui/ngx-login-client/pull/59


Design guideline: Icon set

Where can I find the set of icons for iOS and Android?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aef2c9cc-3f5b-b2b1-dd84-08a910a74c64
Version Independent ID: df0d841a-6e7b-bb95-99b8-dae7fc950f35
Content: Outlook add-in design - Outlook Developer
Content Source: docs/add-ins/outlook-addin-design.md
Product: outlook
GitHub Login: @o365devx
Microsoft Alias: o365devx

@kharenzze: Thanks for your question. I'll look into this and get back to you. Thanks.

@kharenzze: Take a look at Office UI Fabric and available icons. I'll close this issue but if you still need help or clarification, let us know and we'll reactivate this issue. Thanks.


WIP: Separate unit tests from integration tests.

Need to fix the Travis build.

Codecov Report

Merging #457 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #457      +/-   ##
============================================
- Coverage     90.26%   90.22%   -0.05%
  Complexity      586      586
============================================
  Files           104      104
  Lines          2127     2127
  Branches        206      206
============================================
- Hits           1920     1919       -1
  Misses          156      156
- Partials         51       52       +1

Impacted Files
Coverage Δ
Complexity Δ

...a/io/opencensus/trace/export/SpanExporterImpl.java
90% <0%> (-1.67%)
6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36680d2...1ed2461. Read the comment docs.

Had to disable checkstyle for integration tests if not java8.


Unable to comment on PR

I made a comment and nothing happened. Here's the UI after the comment:

Another one that didn't go through on GH

May be related to https://github.com/Microsoft/vscode-pull-request-github/issues/82

It made all these comments on a different PR on unrelated lines (PR 1525):

This should be fixed by https://github.com/Microsoft/vscode-pull-request-github/commit/ac934843c5023bd83e98cd20e546d2286976ab99


Lisp rewrite

It would be interesting to see if the code could simplified by writing it in Common Lisp via Parenscript. I don't expect any savings in output size, but I think it would reduce the lines of source code by using macros.
It is currently ~700 lines of JS, which is not trivial but also not that big. It might make sense incrementally try to reproduce the same JS code via Parenscript.
The motivation is to see how viable Lisp is as a language for authoring web front-ends. Parenscript is particularly suitable for authoring libraries with, since it does not rely on an external runtime. I guess very few people understand Lisp code so there are very few people doing it, but it's worth experimenting and I think it's feasible.

I like the idea of 'macros' instead:
http://jlongster.com/Stop-Writing-JavaScript-Compilers--Make-Macros-Instead


Printing underscores in TreeView Headers

Hi, i need to print underscores in TreeView headers. I cannot use double underscores (these get printed as one) because the data i am displaying is fetched dynamically.
I am aware of set_use_underline , but i cannot figure out where i need to apply it. Neither my columns nor the TreeView or the TreeViewStore seem to implement it?

I got it, Rubberducky ftw.
For the record:
Instead of setting the title for the TreeViewColumn directly like so
col.set_title("Foo")

you can use a widget to set the title, for example a label.
let label = Label::new(Some("Foo"));
label.set_use_underline(false); // not acutally needed: this seems to be default
col.set_widget(Some(&label));
col.get_widget().unwrap().show_all;


Downgrade cri-o to 1.11.6

Downgrades cri-o to v1.11.6.

Now phase outsources the decision making process to OS configurer... which means that only bionic will do a rolling reconfigure (others can reconfigure without stopping pods).

@jnummelin PTAL

@jnummelin PTAL again


Empty folds

addresses #656
closes #695
also bumps plotly.js to 1.40.0

With a pie as the first trace and a scatter as the second I get this:

With this error in the console:
Warning: Failed prop type: Invalid prop `traceIndexes[0]` of type `boolean` supplied to `TraceConnectedPlotlyFold`, expected `number`.
    in TraceConnectedPlotlyFold (created by TraceAccordion)
    in TraceAccordion (created by GraphTransformsPanel)
    in GraphTransformsPanel (created by DefaultEditor)

Also when I have pie then scatter  with a colorscale in the scatter, the Color Bar panel is present but empty.

Well, no every exclusion has to apply to every case of grouped vs un
grouped... this is why I would move the filter out to the call point
On Fri, Aug 17, 2018 at 09:41 VeraZab<EMAIL_ADDRESS>wrote:

@VeraZab commented on this pull request.
In src/components/containers/TraceAccordion.js
https://github.com/plotly/react-chart-editor/pull/699#discussion_r210912638
:

@@ -24,14 +24,36 @@ class TraceAccordion extends Component {
// we don't want to include analysis transforms when we're in the create panel
const base = props.canGroup ? context.fullData : context.data;

this.filteredTracesFullDataPositions = [];
this.filteredTraces = base.filter((t, i) => {

 if (props.excludeFits) {

   return !(t.transforms && t.transforms.every(tr => tr.type === 'fit'));

this.filteredTracesFullDataPositions = base.map((t, i) => {

 if (

I don't agree with this logic.
When base is data, like in the Create panel, you cannot assume that the
index of an item in the data array is the same as its index in the fullData
array.
The case I can think of is in the Create Panel, which has base data,
if you add 1 split trace, and 1 non split case.
Data will be like: [{type: 'scatter'}, {type: 'pie'}]
FullData will be like: [{type: 'scatter', transforms: []}, {type:
'scatter', transforms: []}, {type: 'pie'} ]
In the Create panel, you'd be mapping on data, so you'd have a
this.filteredTracesFulDataPositions of [0, 1], where you should have [0, 2].
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/plotly/react-chart-editor/pull/699#pullrequestreview-147229974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbA4ucZj1wf8T_QgcNXY1f0hIyxb7tks5uRsghgaJpZM4WAs42
.

Could you please look at the 2 comments with 😕 , those are my 2 potentially blocking comments.

💃

💃 on behaviour.


Add ability to set PineconeClient managedChannel and Host

Problem
https://github.com/pinecone-io/pinecone-java-client/issues/126
Solution
As is, customers have no way of setting custom managed channel or hosts with v1.0.0+ of pinecone java sdk, and this is a requirement if we want to tune the gRPC connection behaviour.
To that end, I have added two builder options:

withHost
withManagedChannel

In addition, I’ve made the package-private constructor for Pinecone class public so we can sidestep builder class if we want.

Please see my response for this PR here:
https://github.com/pinecone-io/pinecone-java-client/issues/126#issuecomment-2113106167


Add akvideo

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2019.10.29
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://akvideo.stream/video/gq3ke80zo7sn
Single video: https://akvideo.stream/video/gq3ke80zo7sn

Description

Add akvideo

https://github.com/ytdl-org/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free


File.expand_path produces invalid/broken string (bug and workaround)

I hope this is a bug. It sure seems like it.
#!/usr/bin/env crystal
def slug(str : String) : String
  str = str.downcase
  str = str.gsub("ä", "ae")
  str = str.gsub("ö", "oe")
  str = str.gsub("ü", "ue")
  str = str.gsub("ß", "ss")
end

stdout = IO::Memory.new
Process.run("pwd", output: stdout) # the workaround
stdout.close
path = "/Users/sasa/bin/äöüÄÖÜß"
test = Dir.current
puts slug(path.split("/").last)        # should be aeoeueaeoeuess
puts slug(stdout.to_s.split("/").last) # should be aeoeueaeoeuess
puts slug(test.split("/").last)        # should be aeoeueaeoeuess

The output
$ test.cr
aeoeueaeoeuess
aeoeueaeoeuess
äöüäöüss

The two strings are not identical. String.downcase works. Also str = str.gsub("ß", "ss"), but not äöü (and probably others too).
Sasa

@sasa it seems a unicode normalization issue
https://unix.stackexchange.com/questions/90100/convert-between-unicode-normalization-forms-on-the-unix-command-line
LibC.getcwd that is used to implement Dir.current is returning the string with different representation for ä and others, and that is preventing the gsub to apply the substitutions.
To solve this we should extract the normalization data from unicode, add normalization operations and use the in Dir.current probably.
FWIW, I was able to reproduce it in osx 10.12.3.

@bcardiff I thought as much. Thank you for looking into it and for the explanation. I hope it can get resolved in one of the next releases.

Changing to a feature because unicode normalization is a (pretty complex to implement) feature

Will investigate for normalize (after String.compare with Fold) 17 Jun.
It should be

This issue seems to be resolved, it doesn't reproduce with latest Crystal version. See https://carc.in/#/r/4wnu
def slug(str : String) : String
  str.downcase.gsub("ä", "ae").gsub("ö", "oe").gsub("ü", "ue").gsub("ß", "ss")
end

`mkdir äöüÄÖÜß`

Dir.cd "äöüÄÖÜß"

p! slug("äöüÄÖÜß"),
   slug(File.basename(`pwd`).strip),
   slug(File.basename(Dir.current))

Judging from the provided output it is just the regular unicode characters for these umlauts.
So yes, the report doesn't make sense. Maybe there was some transformation in between or whatever, but riggt now its not reproducible.
@sasa any additions?

I'm going through community:help-wanted-labeled issues from oldest to newest looking for a place to contribute.  This issue is quite dated and no longer seems reproducible based on @straight-shoota's test.  I was unable to reproduce the results from the original report given the code provided using the latest 0.28.0 version of crystal.  Should this issue be closed as invalid given it being not reproducible?

I wouldn't say it's an invalid issue, because the OP probably has validity, it just lacks information to reproduce it.
I'll close it anyway due to no activity and not being reproducible.

Oh excellent!  I hadn't noticed the status:needs-more-info label.  That does indeed seem more appropriate.


Change Text color in SegmentedControlWidget on selection.

https://github.com/Clueless-Community/Spectrum-UI/assets/67179751/bf445357-31e6-4a01-8b90-35dee79a86f8
In light mode,
the color of the text in SegmentedControlWidget should change to white in order to be clearly visible on selection
like the RadioChips.
I'm planning to do something like this,
https://github.com/Clueless-Community/Spectrum-UI/assets/67179751/0d2eec71-c217-46b9-8a4c-f206e26886a1
I would like to solve this issue, Please assign it to me as a part of GSSOC'23

can you please assign me this issue under GSSoc 2023. I really want to work on this issue.

I know this issue,please give me a chance to resolve this

Hey, I can work on this, please assign this issue to me
GSSOC 2023 :)

Hey, I'm a GSSoCC'23 contributor. I would like to change the text color in segmented control widget on selection. Could you please assign this task to me.

please assign me this issue under GSSOC'23

@Debajyoti14
Hey, sorry for tagging, but can you please review the issue.
Thank you.

@Yash-Khattar assigning you

@Yash-Khattar Any Progress?

@Debajyoti14 Yeah I've made the required changes in the code, will submit the PR by today.


improved argument validaton

Please review Issue #180

Hi @jp111,
Could you please add a test for it?

Hi @kmike ,
I have placed the test under Base class so that it runs for all children classes.

Thanks @jp111!
I've cherry-picked your changes because it seems something is not right with the PR.


Cheat is Aimlocking enemy through smoke.

I just encounter this yesterday that I  toggled my aimlock and what I see that cheat is aimlocking enemies through smoke even though I have checked the "Visible only" enemy option. And aimlock that I am using looks legit if there is no smoke but I have killed 3 people through smoke with headshot which is really fishy. Please fix this or If I making any mistake please help me.

Just off ignore smoke

Just off ignore smoke

Where is this option, I dont see it in the Aimbot section.

Look smoothly dude its in aimbot tab if u didint delete from ur source

tf

Disable "Ignore Smoke" under "Ignore flash"


add timeout option to third party test reporting

Timeout option to allow enforcing a timeout when reporting third party synthetic test. Primarily to avoid timeouts and long runs when used in extensions.

I think this change which touches the underlying 'make_request' would result in all mock data needing to be updated.
Not sure if this is the best approach or if it makes more sense to not include this and find some way of enforcing a timeout in the code/extension that uses it.

I don't think this is the way to go, instead we should allow the user to set a timeout option on the http client when initializing the Dynatrace class
The post method cannot receive a timeout parameter because there is no such a thing in the API documentation, instead that behaviour should be controlled "globally" on the HttpClient, and not passed as a parameter to the make_request method

I don't think this is the way to go, instead we should allow the user to set a timeout option on the http client when initializing the Dynatrace class
The post method cannot receive a timeout parameter because there is no such a thing in the API documentation, instead that behaviour should be controlled "globally" on the HttpClient, and not passed as a parameter to the make_request method

@dlopes7 Since there doesn't seem to be a way to in requests/session set a timeout the timeout will need to make it's way to the s.request method call. Having it set there does seem better and allows this to be an option across the board, but do you think one of these options is best?

Add a method to the Dynatrace class to let you set the timeout for it's HttpClient?
Change the name of the HttpClient property so that it can be interacted with directly - (i.e. change __http_client to _http_client)
Allow the HttpClient object to be created beforehand and passed to Dynatrace on initialization

The first seems the better to me, but doesn't seem to be a precedent in this project.

This is what seems natural: https://github.com/Dynatrace-James-Kitson/api-client-python/commit/ae70af4d79d0062b0ee6b3847006bec438df3fc9

Yes this looks perfect imo


drivers: i2c: mchp: Fix I2C driver issues

MCHP I2C documentation is not clear about bit-bang mode.
Bit-bang mode implements a hardware MUX switching the lines
from the I2C logic to bit-bang logic. This causes disrusption
of the line states if done during a transaction. It also causes
a synchronization issue. Modify the driver to get line states
using the GPIO driver. GPIO device tree nodes are added to each
I2C instance. Work-around a bug when the MCHP controller is the
target and is requested to transmit (target transmit mode). In
this mode, the MCHP controller will not signal it has received
an external stop. The work-around enables the I2C idle interrupt
to detect bus not busy after the stop. Re-implement driver logic
for reset initialization of the controller to prevent
synchronization issues.
Signed-off-by: Scott Worley<EMAIL_ADDRESS>

No one will accept or test. NO RESOLUTION. CLOSED.


Can't run tests in VS2017 (OutOfMemoryException)

I'm unable to run tests for a project in VS2017. When I rebuild the project to populate the Test Explorer window, it doesn't show any test. The Output window for Tests show the following content:
------ Discover test started ------
NUnit Adapter <IP_ADDRESS>: Test discovery starting
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.CapitalizeTests.Capitalize_Returns_Input_If_Empty
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.CapitalizeTests.Capitalize_Returns_Input_With_UpperCase_First_Letter
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ContainsTest.Contains_Returns_True_If_Input_Contains_Substring("Hello World","WORLD",CurrentCultureIgnoreCase,True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ContainsTest.Contains_Returns_True_If_Input_Contains_Substring("Hello World","world",CurrentCultureIgnoreCase,True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ContainsTest.Contains_Returns_True_If_Input_Contains_Substring("Hello World","WORLD",CurrentCulture,False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ContainsTest.Contains_Returns_True_If_Input_Contains_Substring("Hello World","World",CurrentCulture,True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ContainsTest.Contains_Throws_If_ComparisonType_Is_Undefined
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ContainsTest.Contains_Throws_If_Input_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ContainsTest.Contains_Throws_If_Substring_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_Returns_Input_If_Not_Too_Long
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_Returns_Input_Truncated_With_Ellipsis_If_Too_Long
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_Throws_If_Custom_Ellipsis_String_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_Throws_If_Input_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_Throws_If_Max_Length_Is_Less_Than_Length_Of_Ellipsis_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_Throws_If_Max_Length_Is_Less_Than_Zero
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_Throws_If_Max_Length_Less_Than_Length_Of_Custom_Ellipsis_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_With_Custom_Ellipsis_String_Throws_If_Input_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.EllipsisTests.Ellipsis_With_Custom_Ellipsis_String_Throws_If_Max_Length_Is_Less_Than_Zero
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.GetLinesTests.GetLines_Returns_All_Lines_In_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.GetLinesTests.GetLines_Throws_If_String_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsNullOrEmptyTests.IsNullOrEmpty_Returns_False_If_String_Is_Not_Empty
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsNullOrEmptyTests.IsNullOrEmpty_Returns_True_If_String_Is_Empty
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsNullOrEmptyTests.IsNullOrEmpty_Returns_True_If_String_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsNullOrWhitespaceTests.IsNullOrWhiteSpace_Returns_False_If_String_Has_NonWhitespace_Chars
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsNullOrWhitespaceTests.IsNullOrWhiteSpace_Returns_True_If_String_Is_Empty
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsNullOrWhitespaceTests.IsNullOrWhiteSpace_Returns_True_If_String_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsNullOrWhitespaceTests.IsNullOrWhiteSpace_Returns_True_If_String_Is_WhiteSpace
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsValidEmailTests.IsValidEmail_Returns_True_If_Email_Is_Valid("test@test.com",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsValidEmailTests.IsValidEmail_Returns_True_If_Email_Is_Valid("test.test@test.com",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsValidEmailTests.IsValidEmail_Returns_True_If_Email_Is_Valid("test",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsValidEmailTests.IsValidEmail_Returns_True_If_Email_Is_Valid("test@test",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsValidEmailTests.IsValidEmail_Returns_True_If_Email_Is_Valid("test@test@test.com",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.IsValidEmailTests.IsValidEmail_Throws_If_Input_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.JoinTests.Join_Concatenates_Values_If_Separator_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.JoinTests.Join_Concatenates_Values_With_Separator
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.JoinTests.Join_Throws_If_Values_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.LeftTests.Left_Returns_Empty_String_If_Count_Is_Zero
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.LeftTests.Left_Returns_Leftmost_Characters
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.LeftTests.Left_Returns_Original_String_If_Count_Equals_Length
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.LeftTests.Left_Throws_If_Count_Is_Greater_Than_Length
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.LeftTests.Left_Throws_If_String_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Ignores_Case("hello world","HELLO WORLD",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Ignores_Case("hello world","HELLO *",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Ignores_Case("hello world","* WORLD",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Ignores_Case("hello world","HELLO ?????",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Matches_Case("hello world","HELLO WORLD",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Matches_Case("hello world","HELLO *",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Matches_Case("hello world","* WORLD",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Matches_Case("hello world","HELLO ?????",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","???????????",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","hello ?????",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","????? world",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","hel?????rld",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","???lo wo???",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","?",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","?hello world",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","hello world?",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_QuestionMarks("hello world","?hello world?",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","*",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","hello*",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","*world",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","hel*rld",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","*hello*",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","*hello world",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","hello world*",True)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","hello",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","*hello",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Returns_True_If_Input_Matches_Pattern_With_Stars("hello world","world*",False)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Throws_If_Input_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.MatchesWildcardTests.MatchesWildcard_Throws_If_Pattern_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReplaceAtTests.ReplaceAt_Replaces_Specified_Character
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReplaceAtTests.ReplaceAt_Throws_If_Index_Out_Of_Range("foo",-1)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReplaceAtTests.ReplaceAt_Throws_If_Index_Out_Of_Range("foo",3)
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReplaceAtTests.ReplaceAt_Throws_If_Input_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReverseTests.Reverse_Empty_String_Returns_Empty_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReverseTests.Reverse_FormC_String_With_Accented_Char_Returns_Reversed_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReverseTests.Reverse_FormD_String_With_Accented_Char_Returns_Reversed_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReverseTests.Reverse_String_With_ASCII_Chars_Returns_Reversed_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReverseTests.Reverse_String_With_Emoji_Returns_Reversed_String
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.ReverseTests.Reverse_Throws_If_String_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.RightTests.Right_Returns_Empty_String_If_Count_Is_Zero
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.RightTests.Right_Returns_Original_String_If_Count_Equals_Length
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.RightTests.Right_Returns_Rightmost_Characters
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.RightTests.Right_Throws_If_Count_Is_Greater_Than_Length
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.RightTests.Right_Throws_If_String_Is_Null
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.TruncateTests.Truncate_Returns_Input_If_Not_Too_Long
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringExtensionsTests.TruncateTests.Truncate_Returns_Input_Truncated_If_Too_Long
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Check_Format
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Format_Should_Accept_Alignment_In_PlaceHolder
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Format_Should_Throw_When_No_Matching_Value_Exists
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Implicit_Operator
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Should_Raise_Exception_When_Called_With_Null_Template
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Should_Raise_Exception_When_Called_With_Null_Values
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Test_BracesAreEscaped
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Test_CachedTemplate
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Test_ClearCached
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Test_HiddenMembers
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Test_WithFields
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.Test_WithFormatProvider
Exception of type 'System.OutOfMemoryException' was thrown.
Exception System.OutOfMemoryException, Exception converting NString.Tests.StringTemplateTests.ToString_Should_Return_Template
Exception of type 'System.OutOfMemoryException' was thrown.
Assembly contains no NUnit 3.0 tests: D:\Docs\GitHub\NString\NString\bin\Release\netstandard1.0\NString.dll
NUnit Adapter <IP_ADDRESS>: Test discovery complete
========== Discover test finished: 0 found (0:00:00,469365) ==========

For reference, here's the csproj:
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFrameworks>net461;netcoreapp1.0</TargetFrameworks>
    <TestProjectType>UnitTest</TestProjectType>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="NUnit" Version="3.6.1" />
    <PackageReference Include="NUnit3TestAdapter" Version="3.7.0" />
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\NString\NString.csproj" />
  </ItemGroup>

</Project>

It's a very small solution (only 2 small projects), and I have 8GB of RAM, so I don't think the issue can be explain by insufficient hardware. devenv.exe uses 469MB (private working set).

There's a couple of issues for this already at the links below - they have workarounds too.
https://github.com/nunit/nunit3-vs-adapter/issues/300
https://github.com/nunit/nunit3-vs-adapter/issues/305
I'll close this one as a duplicate - let me know if I've missed something!

Thanks @ChrisMaddock, I'll look at those workarounds.

Experienced same issue. Updated NUnit Test Adapter to 3.10.0 and this problem solved in VS 2017 and got VSTS builds to run the tests while using net471.

@chamindac  Not sure I understand.  Do you see a new issue here, and the workarounds referred to above does not work  ?

@OsirisTerje I believe that @chamindac is saying that updating to 3.10.0 fixed the problem for him.

Ahh, ok,  all well then :-)


List and describe supported features better when starting

Prettify the output. systemd-style [ OK ] could look good.
Prototype:
[ FULL (green) ] Feature supported and active
[ PARTIAL (orange) ] Feature supported and available, but with decreased/partial functionality (example: when `MemAvailable` isn't reported)
[ DISABLED (red) ] Feature supported by backend, but not by router
[ NOT IMPLEMENTED (white/grey) ] Feature not implemented for the router's backend

Closed with 11e9b8f


Update the channelz compaction test to use 300 entries.

I have already gotten approval for Pull #17931
This is to break the test into its own PR as per @vjpai's suggestion :p

Thank you both!


Skill - Character selection failure on 2nd and 3rd wave

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA
FGA build number
1927
Describe the bug
Device : Pixel pro 7 pro
(It required custom area update left : 201 right 71)
Issue
I couldn't execute character selection required skill on 2nd and 3rd wave.
(I can use it when 1st wave only)
It clicked little left side of character selection area.
Thanks,
Video
No video Using android 13.
Device model
Pixel 7 pro
Android version
7
Screen size
3120x1440
RAM
8GB

I'm pretty sure something is incorrectly configured.
Are you familiar with adb? If so, try doing
adb shell screenrecord /storage/emulated/0/fga.mp4
adb pull /storage/emulated/0/fga.mp4

To create a recording and then download it to the current Windows directory. The video is limited to 90 seconds and I don't know yet if it messes up FGA's screen detection.

I only just now noticed that you closed the issue, did you find the problem?


Provide ability for pasting over highlighted Markdown text to turn the text into a link to the pasted URL

GitHub supports highlighting some text in an issue and then automatically converting the test to a link when pasting over it. I have come to use that feature so much that it surprises me every time in VS Code when that isn't the semantics. I also checked for a setting to turn such semantics on and I could find one either.

I would also love to see this feature.
Since GitHub and certain other apps added support for this functionality, I've gotten very used to using it.[^1] It's always a bit jarring when I do it in VSCode out of instinct, only to delete some text.
For some people, I think it would also be nice to support ⇧⌘V (or Ctrl-Shift-V) to paste the link directly, like in GitHub:

To paste HTML links as plain text, use cmd/ctrl + shift + v instead.

(I believe I've seen at least one app also add an option to swap ⌘V and ⇧⌘V.)
[^1]: I use it while composing this very comment!

After seeing the paste as feature in v1.79, I was disappointed to find out it wasn't pasting links over text to create hyperlinked text.  We need this feature in VSCode too!


Refactored to use common Mil2525CMessageParser

Testing this now - do we have any GeoMessage files in the new area of interest (Monterey)?
I looked here but not sure where else to look.

I tested this with an old geomessage dataset - this is ready to merge unless you want me to test against a geomessage set in the current area of interest.

Let's merge it then. There is a Monterey message file at https://github.com/Esri/vehicle-commander-java/blob/master/data/coa.xml if you do want to check it. There's a much larger one at  https://github.com/Esri/geomessage-simulator-qt/blob/master/GeoMessageSpecification/sample-messages/MontereySimulation500x100.xml that's meant more for the simulator than for a message layer, but in theory it should work, given enough RAM.

MontereySimulation500x100.xml Works fine - thanks

Yes, I forgot that it was 100 symbols with 500 movements (or maybe the other way around), not 100x500 symbols. Thanks!


Refactor

Quite a big refactor. Separated logic into its own class and added basic tests.

This all looks good to me. Great work! Please see my inline comments.
If you don't feel like you want to the the author information and license let me know. I can do that later.

I'm not used to having author and license information in my PHP files. I prefer having those in my composer.json file.

Okay, I'll add them later then…

Merged. Thanks!


copy / paste tabstops after command trigger substitution

Steps to reproduce

Test-Path G:\demo\junction\dummmy\
True

copy / paste the following command from text editor (like windows notepad)

New-Item -Path 'e:\demo\junction' -ItemType Junction -Value 'g:\demo\junction'		# Junction

for clarification: seperation after command are 2 tabstops
New-Item -Path 'e:\demo\junction' -ItemType Junction -Value 'g:\demo\junction'[tab][tab]# Junction

Expected behavior
New-Item -Path 'e:\demo\junction' -ItemType Junction -Value 'g:\demo\junction'		# Junction

no substitution with paste

Actual behavior
New-Item -Path 'e:\demo\junction' -ItemType Junction -Value 'G:\demo\junction\dummmy\# Junction'

the tabstops get interpreted

Environment data

Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Both regular console windows and Windows Terminal windows "eat" tab characters when you use their built-in pasting feature - which is outside PowerShell's control.
The PSReadLine module that PowerShell uses for command-line editing by default actually overrides this and does paste the tabs, but only if you use Ctrl-V to paste, not when you right-click (or use the console window's menu), which, from what I understand, cannot be preempted.

@mklement0 : thanks for your instant reply
Good to know - Ctrl+v works.


New package: ITensorNumericalAnalysis v0.1.0

Registering package: ITensorNumericalAnalysis
Repository: https://github.com/JoeyT1994/ITensorNumericalAnalysis.jl
Created by: @JoeyT1994
Version: v0.1.0
Commit: 410343291d6c8222c5bc58cafc8f2789f4c3ea4b
Reviewed by: @JoeyT1994
Reference: https://github.com/JoeyT1994/ITensorNumericalAnalysis.jl/commit/410343291d6c8222c5bc58cafc8f2789f4c3ea4b#commitcomment-141320670

Thank you for submitting your package! Could you add some documentation before registering, to give an indication for how the Julia API specifically can be used?


Code refactoring

I refactored the order of imports, indentation and whitespaces according to PEP 8.
It is very valuable that you add links to weights of pre-trained models. But these links look bulky because of its length. I propose the way how to make configs more compact by replacing common part of links by variable.
I found a problem with models when we use reset_classification with False-valued num_classes. In this case, the last classifier is replaced by None that leads to code failure during forward. If it is intended behaviour I think it is better to not reset classifier but raise an error when incorrect num_classes is given. Otherwise, if the model should work without the last layer it will be good to replace None by nn.Identity() because in this case model works and it can be traced by torch.jit without additional changes.
Also, I replaced None by nn.Identity() in HRNet initialization functions because when there is non-module object in nn.ModuleList torch.jit.trace fails.
Open to your comments and suggestions about this. Thanks!

I think that these changes improve readability!
If @rwightman approves and merges these changes, I volunteer to doing similar work on the other models as applicable.

@Animatory @VRandme I appreciate the PR, but going to leave this as a reference. It touches too many files at once for formatting purposes, something I've always discouraged in my years as a SW/FW eng. Also, I agree with many changes but not all and don't want to spend time going back and forth for this atm. I'll make a point of fixing some of them when I touch the relevant files.
For future reference, in addition to readability, asthetics, etc I hold diffability, mergeability (& blameability) in very high regard after running SW teams with numerous teams working on various features at once. One reason why I'd kick a code reformatting PR that touches large # of files back :) Under that goal comes alignment, I do not agree with column alignments that cause (or will cause) unecessary future line diffs... a very Pythonic alignment that I disagree with will cause this, lining up line breaks of argument lists with features like the open bracket or =. Refactor the function/class name or variable of the assignment and you've cause a diff of N lines instead of 1.
See:
def blah_blah_blah(int a, int b,
                                 int c, int d,
                                 int e, int f)

def blah_blah_blah(
    int a, int b,
    int c, int d,
    int e, int f)

@rwightman I completely agree with you that this PR is rather a reference to draw your attention than something that can be merged within one commit. I will split it up in several PR related to different changes. And I would like to hear your opinion about each part: what you agree and what you disagree with.


Change to restore cloud backup on nps

Problem:  Backups taken to azure blob store should be restorable on-prem using filesystem connector when downloaded using the nz_azconnector utilities.
On Azure instance: Take backup of database using cloud connector ( -connector az)
Use nz_s3connector or nz_azconnector to download the backup from cloud store to a on-prem NPS system.
nzrestore -dir <dirname> should work.

Solution: Added flag "cloudBackup" , if this flag is used in download then location.txt and contents.txt will be override which will help to restore cloudbackup on nps
Testing:
nz_azDownloadRestore.txt

@abhishekjog - can we download that files by default ? that avoids having an extra argument.

@brajesh1984 @abhishekjog : Committed the code to remove the cloudBackup flag .
nz_azDownloadRestore_Updated.txt


Facing error on startup

Screenshot:

I would like to work on this issue as a participant of GSSOC 21.

@SapinderSingh thanks for pointing this out! I worked on this today because this issue was something that was breaking down the whole app and there wasn't any concrete info in the console as to what was causing this issue (and this issue only appears if you freshly install the app, after uninstalling it from your device). I have fixed this but I won't make a PR for the code, try exploring the repository for 1-2 days specifically the Hive boxes' areas, and check if you can find the fix. If not then feel free to ping me anywhere and I will guide you as to how to fix this so you can create a PR!:)

@Saransh-cpp Thanks :)

Sure you can go through this and see if you could find the error in this place

Please assign this issue to me as I have found the bug and please label it with GSSOC 21

@SapinderSingh thanks for pointing this out! I worked on this today because this issue was something that was breaking down the whole app and there wasn't any concrete info in the console as to what was causing this issue (and this issue only appears if you freshly install the app, after uninstalling it from your device). I have fixed this but I won't make a PR for the code, try exploring the repository for 1-2 days specifically the Hive boxes' areas, and check if you can find the fix. If not then feel free to ping me anywhere and I will guide you as to how to fix this so you can create a PR!:)

This is the real spirit of Open Source :heart: