chore: upgrade jest

Durign tests, we are seeing warnings from ts-jest instability with the current version of TypeScript. In preparation for its upgrade, this first upgrades jest.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
501

Relevant Lines:
676

💛  - Coveralls


Issues with valgrind

I'm using single include version 1.3.0-develop.4. Running catch shows following:
==9156== Memcheck, a memory error detector
==9156== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==9156== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info
==9156== Command: ./build/run_tests [types]
==9156==
==9156== Conditional jump or move depends on uninitialised value(s)
==9156==    at 0x5142BF: Catch::TestRegistry::getAllTestsSorted(Catch::IConfig const&) const (catch.hh:6271)
==9156==    by 0x4FEA47: Catch::getAllTestCasesSorted(Catch::IConfig const&) (catch.hh:6246)
==9156==    by 0x4FE1CF: Catch::runTests(Catch::Ptr<Catch::Config> const&) (catch.hh:6025)
==9156==    by 0x513D1A: Catch::Session::run() (catch.hh:6138)
==9156==    by 0x513C1B: Catch::Session::run(int, char const* const*) (catch.hh:6117)
==9156==    by 0x50667A: main (main.cc:10)
==9156==

This happens every time.

...I just noticed 1.3.1 is already out :+1: The issue on that version seems to be gone.


iso surface extends above topo

When I create an isosurface using the Create Iso Surfaces geoapps notebook, the surface is extrapolated above topography

.
Is this related to the Max Interpolation distance?  For this example I used 1000m Max Interpolation Distance.
Can the interpolation be limited to not go above the topo (i.e. into inactive cells)?
Alternatively if the topo was available as a slicing surface I could just chop it off.

Which notebook Craig?  Looks pretty cool.

This is the Create Iso Surfaces notebook in geoapps.

Update that this issue occurs when the cells above topo have been set to a "no data value" i.e. cells are blank in the Analyst cell table.  If those cells are filled with a numerical value i.e -99999 then the isosurface forms correctly.


Enable building an ensemble model from the cross validation checkpoints of a BYO Lightning model

Closing #527
The method MLRunner.run_inference_for_lightning_models takes a list of checkpoint paths as an argument, but then makes sure that there is only one used (here):
    if len(checkpoint_paths) != 1:
        raise ValueError(f"This method expects exactly 1 checkpoint for inference, but got {len(checkpoint_paths)}")

We want to change this so that the checkpoints gleaned from a BYOL cross validation run can be used as an ensemble model.

This will use the methods defined in the InnerEyeInference abstract class. We expect that these methods are sufficient, but an extension or redesign may be required.
Use the simple linear regression model as the basis of an exemplar.
It would be great to use another, more realistic model. The UHB Covid-19 model is not a lightning model, how about the Single Cell model?

AB#4219

Replaced by #549


Implement [ScrollView] properties

Name
Type
Default Value
Description

scrollBarVisibility
string

Sets the visibility mode of any attached scrollbars. The visibility mode affects the visibility of any attached scroll bars.

scrollMask
number

Applies the texture resource as a mask for ScrollView content.

scrollOffset
vec3

Sets the scroll content offset manually.

scrollSpeed
number

Sets the scroll speed in scene units per second.

scrollValue
number

Sets the scroll content position manually with a normalized value between 0 and 1.

MXSCOMP-80

The scrollMask requires the texture resources support on mobile.


Python 3.4 support not working

Here is the link to the gist.
https://gist.github.com/d3prof3t/285fefcf2aa4ae68b444

please in your project folder, with the same virtualenv enabled, and run:
pip uninstall environ --yes
./install_python_dependencies.sh

after, if the problem stops happen, please close this issue.
ps.: my guess is that you used your IDE to install the python packages, and IDE mistakenly installed the wrong package.

Thanks!
It did work.
ps.: I didn't use any IDE I was working on the terminal.
And just one more question, when wil be the use of install_os_dependencies.sh, and why did we run the install_python_dependencies.sh.
Just want to know about this.


Optimization: Leb128 implementation is too pure and innocent

Why?
Our pure implementation is honest to spec (it reads one to one as the algorithm steps in the spec).
Pure binary crunching implementations tend to be slow.
Other implementations use binary manipulation tricks. See python implementation, JS implementation and Rust implementation.
They use the same trick, we should figure out how to do bitmaps in Lean and do it too.
What?

[ ] Learn how to write "dirty" code in Lean.
[ ] Port dirty implementations to Lean.

Clarification question: do you think Int bitwise arithmetics in YatimaStdLib and now the new LEB128 implementation in #50 closes this too or did you mean something else?

Yes, exactly what I needed, thank you!


Context cancel func is private

The recent addition of cancel func to the main context makes it hard to reuse the context since cancel is private yet required in https://github.com/chromedp/chromedp/blob/5641ebbffced776b8cdf0d6d31ff9408527d5037/chromedp.go#L199
Example of the problem: https://github.com/gadelkareem/faloota/blob/master/faloota.go#L57

Sorry, I don't follow why you need access to that at all. It's unexported on purpose, and it shouldn't be needed for any chromedp users. The example link you gave doesn't really clarify what use case there is.

Yes, I do not need the cancel function but if I can chromedp.Run() then it will fail with "Invalid Context" error because there is no cancel in the context. I save all contexts in a map to reuse them later https://github.com/gadelkareem/faloota/blob/master/faloota.go#L27

And how did you create said context?
I won't debug your codebase; if you want me to debug a potential bug, please write a short Go program to reproduce the error.

No debugging needed, these are all the functions, and the context is created in Faloota.Ctx()

you're using the API wrong. see the examples, you need NewContext. the error you're getting is intended.

But then it will have to create a new context every time I am making a request which is not what I want to do.

You can reuse contexts if you want. You just have to create them with NewContext.

But if I use again NewContext then it will add generate new cancel, goroutines watching the context, ...etc. And I am trying to avoid all this overhead.

This supposed overhead is only when you create a new context, not when you reuse it.
If that's what you mean, then there's just no avoiding this "overhead". For one thing, an extra allocation or goroutine makes practically no difference when chromedp uses Chrome, which tends to take vastly more CPU and time.
And the extra work is necessary. For example, there's a goroutine that watches for the websocket connection being dropped and stops all other chromedp goroutines.
If you still think that's too wasteful with resources, you're welcome to use the Chrome devtools protocol directly with raw commands. In that case, you want to use cdproto directly, but bear in mind that you'll deal with a much lower-level API.

Yes and I am trying to reuse the context Which was already created and injected into the context that I already saved. Why would you add a private property to the main context if you intend to reuse it. I think this rather a design mistake.

Once again, the only officially supported way to create a context is with NewContext. I don't see the point of this issue.


Error launching after update. Cannot read properties of undefined (reading 'dockerhub')

I receive the below error when launching my MqDockerUp container. Testing version 1.0.2 exhibits the same, while 1.0.1 runs with a "TypeError: Cannot read properties of undefined (reading 'split')" warning, but otherwise appears to work.
When reverting back to 0.16.4 the system runs as expected.
My docker compose references the config.yaml file that's identical to the documentation, but with my own values.
Starting MqDockerUp V1.0.3 ...

TypeError: Cannot read properties of undefined (reading 'dockerhub')
    at ConfigService.getConfig (/app/dist/src/services/ConfigService.js:48:152)
    at Object.<anonymous> (/app/dist/src/services/HomeassistantService.js:18:40)
    at Module._compile (node:internal/modules/cjs/loader:1257:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1311:10)
    at Module.load (node:internal/modules/cjs/loader:1115:32)
    at Module._load (node:internal/modules/cjs/loader:962:12)
    at Module.require (node:internal/modules/cjs/loader:1139:19)
    at require (node:internal/modules/helpers:121:18)
    at Object.<anonymous> (/app/dist/src/index.js:18:48)
    at Module._compile (node:internal/modules/cjs/loader:1257:14)
TypeError: Cannot read properties of undefined (reading 'dockerhub')
    at Function.getConfig (/app/src/services/ConfigService.ts:47:107)
    at Object.<anonymous> (/app/src/index.ts:9:30)
    at Module._compile (node:internal/modules/cjs/loader:1257:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1311:10)
    at Module.load (node:internal/modules/cjs/loader:1115:32)
    at Function.Module._load (node:internal/modules/cjs/loader:962:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47
/app/src/index.ts:10
const client = mqtt.connect(config.mqtt.connectionUri, {
                                   ^
TypeError: Cannot read properties of undefined (reading 'mqtt')
    at Object.<anonymous> (/app/src/index.ts:10:36)
    at Module._compile (node:internal/modules/cjs/loader:1257:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1311:10)
    at Module.load (node:internal/modules/cjs/loader:1115:32)
    at Function.Module._load (node:internal/modules/cjs/loader:962:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)

Please make sure you have the following config structure:
https://raw.githubusercontent.com/MichelFR/MqDockerUp/main/config.yaml
Dont forget
accessTokens:
  dockerhub:
  github:

even if you dont want to set an accessToken

Ah, that solved it.
I had presumed those accessTokens were only necessary if you actually had them. Thank you.


String: Add Reverse Words in a String in Go

https://leetcode.com/problems/reverse-words-in-a-string/

#624


npm error : Failed to parse package.json data

Can anyone help me please i tried npm cache clean but didn't work for me... this is what my package.json looks like
{     "name": "app-name",     "version": "0.1.0",     "description": "My Description",     "engines": {       "node": "6.11.1"     },     "main": "server.js",     "scripts": {       "start": "node server.js"     },     "dependencies": {       "body-parser": "^1.15.2",       "cors": "^2.8.0",       "del": "2.2.0",       "express": "^4.14.0",       "http": "0.0.0",       "method-override": "^2.3.6",       "morgan": "^1.7.0"     }   }
and this is the error occured after npm install
`
npm ERR! file C:\Users\Toshiba\Desktop\ionicproj\server\package.json
npm ERR! code EJSONPARSE
npm ERR! Failed to parse json
npm ERR! Unexpected token   in JSON at position 4 while parsing near '{npm ERR!     "name": "app-name"...'
npm ERR! File: C:\Users\Toshiba\Desktop\ionicproj\server\package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! Tell the package author to fix their package.json file. JSON.parse
npm ERR!      C:\Users\Toshiba\AppData\Roaming\npm-cache_logs\2018-01-30T14_34_29_827Z-debug.log
`

If some other lost soul lands here... try deleting the package-lock.json file. That worked for me. It's not npm that is the problem even though it seems like it. The super cryptic error message isn't too helpful.


bug: $ionicPlatform.ready not firing on Android when app delivered over the web

Type: bug
Platform: android 5.1 webview
I'm trying to deliver my Ionic hybrid app over the web so in config.xml I have pointed to index.html on my web server

The web delivered app works great on iOS but the app is not starting up on Android.
I experimented this case with the default "starter" app that is part of the ionic framework and I'm seeing the same behavior.
It turns out that when the app is delivered over HTTP the $ionicPlatform.ready event is NOT firing on Android.
The events fires properly on iOS though.
I have tried numerous experiments but no success.
To summarize:
Local version of app runs fine on both iOS and Android
Remote(http) version of the app runs fine only on iOS but fails on Android.
Android version: 5.1.1
Cordova version: 5.0.0
Ionic Version: 1.0.0

Greetings @ranjitpandit!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

I get this in the logs when the app is loaded from the webserver.
deviceready has not fired after 5 seconds.
cordova.js:1178 Channel not fired: onCordovaInfoReady

any ideas?

Greetings @ranjitpandit!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


[IDL-123] When there are finished threads, pause work to re-sync

When a consumer has either received an error from kinesis, or finished
draining its queue, it stops.
When other threads are busy, the idle thread will not resume (the
outer loop waits for all threads to finish).
Before requesting the next batch of work, 10% of the time, check
threads in the peer group (excludes the main thread, only includes
shard processing threads) for idle threads, and stop this thread when
that's seen.
The main loop timer will restart all threads (and start processing
shard batches on all shards) once all threads have completed.
This is an alternative to #3 which may be more general (there are other reasons that a thread might go idle than an error, and we probably want to keep threads busy in those cases as well).

closed in favor of #6 which incorporates this and #5


LiftIO Instances for Future and Rerunnable

Would LiftIO instances for Future and Rerunnable be welcomed? I couldn't find laws for LiftIO but these rough implementations seemed to work after some limited testing I did.
implicit val rerunnableLiftIO: LiftIO[Rerunnable] = new LiftIO[Rerunnable] {
  override def liftIO[A](ioa: IO[A]): Rerunnable[A] =
    Rerunnable.fromFuture(LiftIO[Future].liftIO(ioa))
}

implicit val futureLiftIO: LiftIO[Future] = new LiftIO[Future] {
  override def liftIO[A](ioa: IO[A]): Future[A] = {
    val p = Promise[A]

    ioa.unsafeRunAsync {
      case Left(ex) => p.setException(ex)
      case Right(a) => p.setValue(a)
    }

    p
  }
}

Hi, thanks for the suggestion!
If there aren't any laws or other constraints, we should probably piggy back the implementation on the existing functions here:
https://github.com/travisbrown/catbird/blob/master/effect/src/main/scala/io/catbird/util/effect/package.scala
Your implementation will convert the types but stays on the thread pool and we have to clarify what the intended behavior of LiftIO is regarding thread pool shifting.
Concretely: Should it just convert the types from IO while staying on the thread pool of the IO or also shift to the thread pool of the type we converting into (e.g. ContextShift[Rerunnable]).
I'd argue that the latter is what people expect but I couldn't find a definitive answer in the docs. I'll have to double check how cats-effect and monix behave in this regard.

In my previous message I might have made some wrong assumptions. One of which is that we already have a function IO[A] => Future[A], but we only have the reverse afaik.
I wrote a message to the cats-effect folks on their opinion but in the meantime I've looked into it more.
It should be noted that Rerunnable already has an instance of LiftIO[Rerunnable] as Effect[Rerunnable] implies Async[Rerunnable] and that implies LiftIO[Rerunnable]. So something like IO.pure("foo").to[Rerunnable] should already work.
For Future the situation is a bit more complicated. We cannot piggyback on Async[Future] as it doesn't exist and one of the laws is that the type may not memoize its result but (to my knowledge) Future does memoize. That's one of the reasons why Rerunnable exists.
Now, we could just implement LiftIO[Future] and ignore Async[Future]. There are pros and cons to it, let's go though some that came to my mind:
Cons:

IO[A] is lazy, but Future[A] is eager. So the implementation would have to start evaluating the computation, which is a bit more than a simple type-conversion. In your example this is made clear by the use of .unsafeRunAsync. This might not be a dealbreaker, as you'll see further below.
Depending on whether we need to consider any thread pool shifting the LiftIO[Future] instance might have a depenency on something like ContextShift[Future], which doesn't exist (yet). This might also not be a dealbreaker, just complicates things a bit more.

Pros:

People which work a great deal inside of applications based on Twitter libraries like Finagle might want to use something that's based on IO[A], so an instance of LiftIO[Future] would provide a default conversion implementation that's likely more robust than any ad-hoc implementation they'd otherwise construct. I'm not being condescending here, I'm one of those people (and we have dozens of those conversion functions lying around in the codebase).

I'd like to wait for comments from the cats-effect folks before a final conclusion but currently I think that the practical benefit of having a default conversion implementation (at least for the direction IO[A] => Future[A]) outweighs the cons.
If an application is written in terms of Future[A] there is no expectation that it is referentially transparent, so losing the laziness semantics is not a huge deal in that case.
Running an IO[A] on a future-pool is a bit iffy but I also think this is not a huge problem in practice. I want to do some more research on that but I have a feeling we don't need the context shifting here.

After some discussion on gitter (link) I'd suggest we start with a simple conversion function "unsafeAsyncToFuture" which takes an F[_]: Async and turns it into a Future.
We can document why this function can be unsafe (regarding laziness and thread pool shifting) and what it should be used for. The "unsafe" prefix will hopefully be enough to stop careless usage.
This should be something that works for the tagless-final use-case you described in gitter, @bpholt. Once you verified that it solves your problem, I'd be happy to add it to the project (alongside futureToAsync and the like). What do you think?

Yep, that makes sense to me, except that I think it may need to be Effect instead of Async? This seems to work in place of the LiftIO[Future] I suggested earlier, but I don't see how it can be implemented with only F[_] : Async.
def unsafeEffectToFuture[F[_] : Effect, A](fa: F[A]): Future[A] = {
  val p = Promise[A]

  Effect[F].runAsync(fa) {
    case Left(ex) => IO(p.setException(ex))
    case Right(x) => IO(p.setValue(x))
  }.unsafeRunSync()

  p
}

Yeah, you're right. I wrote Async because that's what we use for the other direction (e.g. futureToAsync).


How to show what has already been uploaded from one Teldrive to another?

Hello everyone. I wonder if anyone knows if this is possible. The thing is that I have Teldrive on a Windows 11 machine, everything works fine and I've already uploaded some files. But I've also mounted Teldrive on another machine that is more powerful, so to speak, with Linux. On both systems I use DBeaver and the same user and everything else.
So when I enter the Linux teldrive, everything works but it's empty. I've tried to enter the data by importing data from one DBeaver to another and it worked, the bots and channels load without errors but the "files" table even though enter the data with errors, the files are shown in the database. But, If I go to Teldrive they still don't appear on the home screen, with their folders and ordered as I have it on my Windows, only the files appear and are playable from "storage", but not on the home, it comes up empty.
Is there any way to have the same start with everything ordered? I don't mind starting from scratch since I've tried with few files. I hope I've explained myself well. And sorry for my English. Regards.

I am using Postgrasql installed on an Oracle free VPS. No matter which computer you connect to, the DB is the same.


version UP to 1.9.6

Description
Please include a summary of the change and which is fixed.

Fixes

How has this been tested?
Please describe the tests that you ran to verify your changes.

[x] UnitTest
[x] Benchmark

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.37%. Comparing base (59f6e71) to head (b4c04b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #630   +/-   ##
=======================================
  Coverage   91.37%   91.37%
=======================================
  Files         146      146
  Lines        5032     5032
  Branches      777      777
=======================================
  Hits         4598     4598
  Misses        286      286
  Partials      148      148

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


GPflow2.0 notebook update: coregionalisation.ipynb

@st-- , I updated the notebook using the latest version from develop

Changing the scipy optimizer method to CG seemed to make it work - though it's still a bit worrisome that we can't get it to behave as well as in GPflow 1 (develop). Should we merge this into develop-2.0 anyways and leave addressing #1090 until later?


Dyslexic pairs

http://dyslexia.learninginfo.org/symptoms.htm

Thanks Tom.  I added a few other characters from the linked article to make the line lengths match.  Looks good.

Thanks Tom.  I added a few other characters from the linked article to make the line lengths match.  Looks good.


Create B1_Bukala

add B1 log files
Node ID: 3364bdd17abb5d65
Log files:
https://github.com/bukala/Testnet3-Challenges/blob/logfiles/concordium-testnet-node-5061bd63175a16ebf77b10f38a3b182a0b731f787e62cd48618ca03b04a70c6b.log
https://github.com/bukala/Testnet3-Challenges/blob/logfiles/concordium-testnet-system-report.log
https://github.com/bukala/Testnet3-Challenges/blob/logfiles/concordium-testnet-node.log

confirmed:B1
node:3364bdd17abb5d65

Form Submitted utc +3


Fate of the Norns Character Sheet

This is a character sheet for Fate of the Norns. The images are not currently referenced by this sheet, but as soon as they are on the roll20 github I will update the sheet to use the image files local to roll20.
Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

This is a new character sheet for Fate of the Norns
FotN.html FotN.css
Not a bug fix
I think I followed the Building Character Sheets standards? Honestly, this is my first sheet and my first attempt at HTML/CSS, so I might have screwed something up. It passed all the testing I could do from my end.

I want to say if this is your first time building a sheet you did a wonderful job and should be proud!

Thanks! I had a lot of help from GoG on the forums
Sent from my iPhone

On Jun 22, 2020, at 7:45 AM, Corey J<EMAIL_ADDRESS>wrote:

I want to say if this is your first time building a sheet you did a wonderful job and should be proud!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Provide devenv binary install for other package managers

In some setups, we would want to install devenv directly from existing package managers. Therefore, please support:

https://aur.archlinux.org (devenv, devenv-bin)
https://brew.sh (it allows distributing binary)

Especially a binary install would be very helpful to quickly get started.

Could you open package requests in repos?

Could you open package requests in repos?

I am sorry, what do you mean by that?

@pksunkara this doesn't make much sense as the devenv binary has a runtime dependency on the presence on the Nix package manager. You will always to have to install Nix as well, at which point you might as well use it for getting the binary.

@thenonameguy Your argument is talking about extremes. Please don't force people, especially programmers.

In some CI setups,  you will have to configure your bin paths to point to nix profile before using devenv. We should allow people to skip that step by supporting this.
What about the people who want to use devenv for projects but do not want to completely move their entire system over to the Nix ecosystem? They would still want to install their system tools using their preferred package managers.

IMHO, adding this support is not costly and is a good middle ground to allow the end users a variety of options.
FWIW, https://www.jetify.com/devbox support this.

The Devbox binary supports installing Nix when invoked.
Devenv does not have this feature at the moment.
If it gets added, then we could achieve feature parity and complete this task, which I support by the way :)
Adding devenv to package managers as-is would just lead to users getting nix not found on $PATH errors, which goes against the original intent of providing a seamless experience for users who are not familiar with the Nix ecosystem.

Adding devenv to package managers as-is would just lead to users getting nix not found on $PATH errors

In aur, the package can depend on arch linux's nix.
In homebrew, the install step can check for nix and fail to install if not present.

This kind of issue is already solved in package managers.


chore(main): release 0.0.25

:robot: I have created a release beep boop
0.0.25 (2024-08-23)
Bug Fixes

embedding structs related to validationrule.Interface (#261) (cfbcca0)

Other

assert that PluginSpec is implemented (#259) (f0ad07e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.25
:sunflower:


prisma cli's endpoint parser is wrongly parsing the URLs other than localhost

Describe the bug
Prisma CLI is parsing regular local private URLs as cloud workspace URLs and deploy to any server other than localhost is broken right now with the following error if you are logged in. When you are logged out it is just asking you to login:
ERROR: No cluster could be found for workspace '*' and cluster 'default'
  1 # Specifies the HTTP endpoint of your Prisma API.

{
  "data": {
    "generateClusterToken": null
  },
  "errors": [
    {
      "message": "No cluster could be found for workspace '*' and cluster 'default'",
      "locations": [
        {
          "line": 3,
          "column": 9
        }
      ],
      "path": [
        "generateClusterToken"
      ],
      "code": 222
    }
  ],
  "status": 200
}

This is regression is introduced by the following commit: https://github.com/prisma/prisma/commit/67bb5094010e76e23849458fc211a474e1a40479#diff-6fed8e800217d7823362a8550f1047a2R50
To Reproduce
Steps to reproduce the behavior:

Make the following prisma.yml file

# Specifies the HTTP endpoint of your Prisma API.
endpoint: http://prisma:4466

# Defines your models, each model is mapped to the database as a collection.
datamodel: datamodel.prisma

Run `prisma deploy
See error

Expected behavior
CLI should parse the URLs correctly for non localhost urls as well
Versions (please complete the following information):

Prisma Server: 1.28.5
prisma CLI: 1.28.5
OS: MacOS 10.14.3

@pantharshit00  Checking your PRISMA_MANAGEMENT_API_SECRET and endpoint path. If you use DigitalOcean, Please check your endpoint have a PORT.
I try to add env PRISMA_MANAGEMENT_API_SECRET and edit port on endpoint prisma.yml.

@vistriter I am not sure what are referring from that comment. This is a confirmed bug regarding the parser. If you version lower than 1.28.4 it will work fine

Thanks @pantharshit00, I was losing my mind trying to debug this one. Great time to start dabbling in setting up a prisma server!

With Prisma Server and Prisma CLI 1.29.0, when prisma deploy:
Authenticating...
Opening https://app.prisma.io/cli-auth?secret=[SECRET] in the browser

Could not open the authentication link, maybe this is an environment without a browser. Please open this url in your browser to authenticate: https://app.prisma.io/cli-auth?secret=[SECRET]

Is this related?
With Prisma CLI 1.28.5, the deploy worked!

Assuming that server is always protected by a secret, this is the current behavior:
Logged in with management secret
Local server + localhost - Invalid token is currently thrown - which is correct behavior
Local server + proxy or prisma:4466 - ERROR: Workspace * does not exist ❌ correct: Invalid token is currently thrown
Demo server - works as expected
Private server hosted by Prisma
Self hosted server - works as expected
Logged in with management secret
Local server + localhost - Works as expected
Local server + proxy or prisma:4466 - ERROR: Workspace * does not exist ❌ correct: should work
Demo server - works as expected
Private server hosted by Prisma - ERROR: Token is issued in the future (iat). ❌ correct: should work 🤔 but this is a separate issue from 4125
Self hosted server - works as expected
Logged out with management secret
Local server + localhost - works
Local server + proxy or prisma:4466 - Asks to login ❌ correct: should work
Private server hosted by Prisma - Asks to login ❌ correct: should work
Self hosted server  - Asks to login ❌ correct: should work

This breaks two things:

localhost servers not deployed using localhost i.e. either using http://prisma:466 or a proxy using nginx or something and the workaround is to use localhost for now while we fix it.

CI setups where login is not possible, there is no workaround except downgrading to a stable version.

We would fix these issues shortly.

For anyone looking at the same issue looking for a workaround, restoring "prisma" package version alone might not work. These versions in my package.json worked for me:
    "prisma": "1.26.6",
    "prisma-cli-engine": "1.26.6",

For anyone looking at the same issue looking for a workaround, restoring "prisma" package version alone might not work. These versions in my package.json worked for me:
    "prisma": "1.26.6",
    "prisma-cli-engine": "1.26.6",

1.28.3 works fine too

This is fixed in 1.29.1, please install it using npm install -g prisma

Unfortunately, I am still getting an error with 1.29.1.  A few days ago, after updating prisma and then running prisma deploy, it opened up my web browser to get me to log into prisma.io.  I created an account, though I am currently not using any prisma.io cloud services. prisma deploy then would error.  I reverted my version, and waited for this fix to go through.  I updated to 1.29.1 today and I am still getting the following error.  Is there something trying to connect me to prisma.io, even though I am not using it?  Is there a way to delete the credentials that are being stored if so?  Thanks!
$ prisma deploy
ERROR: No cluster could be found for workspace '*' and cluster 'default'
{
  "data": {
    "generateClusterToken": null
  },
  "errors": [
    {
      "message": "No cluster could be found for workspace '*' and cluster 'default'",
      "locations": [
        {
          "line": 3,
          "column": 9
        }
      ],
      "path": [
        "generateClusterToken"
      ],
      "code": 222
    }
  ],
  "status": 200
}

I am using a plain docker-compose.yml for local development:
version: '3'
services:
  prisma:
    image: prismagraphql/prisma:1.29.1
    restart: always
    ports:
    - "4466:4466"
    environment:
      PRISMA_CONFIG: |
        port: 4466
        # uncomment the next line and provide the env var PRISMA_MANAGEMENT_API_SECRET=my-secret to activate cluster security
        # managementApiSecret: my-secret
        databases:
          default:
            connector: postgres
            host: postgres
            user: prisma
            password: prisma
            # rawAccess: true
            port: 5432
            migrations: true
  postgres:
    image: postgres:10.5
    restart: always
    environment:
      POSTGRES_USER: prisma
      POSTGRES_PASSWORD: prisma
    volumes:
      - postgres:/var/lib/postgresql/data
    ports:
      - "42333:5432"
volumes:
  postgres:

Environment:
Linux
Node: 10.15.3

@ZenSoftware Can you please share your prisma.yml file?

Oh yes of course.  Here is my prisma.yml file:
endpoint: http://<IP_ADDRESS>:4466 # Docker
datamodel: database/model.graphql

# seed:
#   import: database/seed.graphql

generate:
  - generator: typescript-client
    output: apps/api/src/app/prisma/client
  - generator: graphql-schema
    output: database/generated/

@ZenSoftware : Is there a specific reason that you are referring to localhost as <IP_ADDRESS>? That looks incorrect to me.

@divyenduz  Ah yes, you are correct.  Changing it to localhost or <IP_ADDRESS> resolved the issue for me.  My apologies.  I only started using docker over the last 2 weeks.  I actually had suspicions that using <IP_ADDRESS> was incorrect. Strange that it worked for me using prisma < 1.28.3.  But everything is working smoothly now.

Yes, < 1.28.3 had a code path that would make this work incorrectly till the token resolution at least, I am not sure how it resolved to localhost correctly though, if it did.

i encounter this with a specific reason:
deploy prisma on one machine, but development with another pc in a local network.
set the endpoint with ip address, so the playground works fine without manual adjust.

I have the issue that if I set anything other than endpoint: http://<IP_ADDRESS>:4466 I get the error:

Could not connect to server at http://<IP_ADDRESS>:4466. Please check if your server is running.

The fact that <IP_ADDRESS> works indicates that the container is at least running correctly (as docker ps would confirm).
This is why I had hoped that keeping <IP_ADDRESS> would be supported for local installations / installations to one's own server.
NOTE: I'm using Windows + WSL. That might make some things more complicated. :)

Why did this ticket close? My ci/cd broken since (and including) 1.28.4
My .gitlab-ci.yml:
server test:
  stage: test
  image: docker
  services:
  - docker:dind
  before_script:
    - apk add --no-cache py-pip nodejs nodejs-npm
    - pip install docker-compose
    - "echo \"DOCKER_HOST: $DOCKER_HOST\""
    - cd server && docker-compose up -d
    - echo "Hacky waity for 33 s" && sleep 33
  script:
    - NODE_ENV='test' npm run test
  after_script:
    - ls && cd server && docker-compose down -v

$DOCKER_HOST shows as tcp://docker:2375
my package.json > scripts:-
"test": "cross-env-shell PRISMA_ENDPOINT=http://docker:4466/test/default \"prisma deploy -f && jest\"",

Outputs
Authenticating...
Opening https://app.prisma.io/cli-auth?secret=$2a$08$RLMtZlfgFhCWChiDPBbgO. in the browser

Could not open the authentication link, maybe this is an environment without a browser. Please open this url in your browser to authenticate: https://app.prisma.io/cli-auth?secret=$2a$08$RLMtZlfgFhCWChiDPBXXX.

but works in 1.28.3 and below.

@ViableClanMember Can you please try version 1.29.1? We have fixed the bug in that version

What about deployment to a server that is not localhost?
My ci is deploying to my servers which are of course not in localhost and i get the same error with 1.29.1

Yep, same error 1.29.1 here. Sorry I didn't specify that earlier.

BTW http://docker is how to access running services in "dind" (docker-in-docker) service that gitlab-ci provide. I believe it resolves to a 10.x.x.x IP.

Confirmed this issue is still apparent in the most recent versions. Issue should be re-opened. I had to downgrade to 1.28.3 as mentioned by @ViableClanMember

Everyone who is still facing this issue, can you please share your prisma.yml file or the Prisma server endpoint (ok to obfuscate it but I need the endpoint pattern).

Nothing fancy
endpoint: https://my.server.url
datamodel: prisma-datamodel.graphql

generate:
  - generator: javascript-client
    output: ../graphql-server/src/generated/prisma-client/

@brafdlog and where is this server hosted? If possible, can you write out the actual URL?

pretty simple, running 1.29.2 (same error with 1.29.1 as well)
`endpoint: ${env:PRISMA_ENDPOINT}
datamodel: datamodel.prisma
generate:

generator: javascript-client
output: ./generated/prisma

hooks:
post-deploy:
- prisma generate
secret: ${env:PRISMA_SECRET}`
The endpoint is deployed to digitalocean via docker-machine, and the endpoint format is https://<ip address>:<port>

@divyenduz

The server is hosted on AWS
I don't want to share the URL on github, but it looks like this: http://xxxxxxxxxxxx.eu-central-1.elasticbeanstalk.com
The output of prisma account isEmail<EMAIL_ADDRESS>Name:  Jonathan

no

@msmedes @brafdlog : Last question would be, are these servers connected to your Prisma cloud account?

@divyenduz I have the same issues as @brafdlog, same scenario. How do you connect prisma cloud account with server on aws?

Ah! so, I think that you Prisma server is protected by a management secret and there are two ways for the CLI to resolve this management secret:

Either you provide it explicitly in the shell environment
Or you connect your server to Prisma cloud and are logged in with the CLI, then this secret is automatically resolved

When you are not providing this secret in the shell environment or not logged in or logged in but the server is not connected to the Prisma cloud, CLI will fail to resolve this secret. Does that make it clear?
Here is how you can connect any self-hosted Prisma server with Prisma cloud:

Please let me know if this works for any/all you?

@divyenduz Unless I am missing something my servers are not connected to prisma cloud and they don't have a management secret defined.
I also don't see a need to connect them to prisma cloud at the moment.

@brafdlog : Thanks, that looks like a bug indeed, for unsecured servers, this PR fixed everything in context of secured servers only.
I am trying a reproduction now.

There is a PR that would fix this issue for insecure servers. I will notify here once the release is available in beta.
For anyone else running into this or a related issue, please fill out this form: https://prisma-io.typeform.com/to/C1JBOT to help us triangulate the issue/code path.

The fix for insecure servers is available in 1.30.0-beta.6, please install it using npm install -g prisma@beta.
Again, for anyone else running into this or a related issue, please fill out this form: https://prisma-io.typeform.com/to/C1JBOT to help us triangulate the issue/code path.

The fix for insecure servers is available in 1.30.0-beta.8, please install it using npm install -g prisma@beta.
Again, for anyone else running into this or a related issue, please fill out this form: https://prisma-io.typeform.com/to/C1JBOT to help us triangulate the issue/code path.

I am trying to use prisma deploy in a CI environment with kubernetes, i am running prisma deploy from within the namespace using a helm-hook. My prisma.yml looks like this:
endpoint: ${env:PRISMA_ENDPOINT}
datamodel: datamodel.prisma
generate:
  - generator: javascript-client
    output: ./app/generated/prisma-client/

calling PRISMA_ENDPOINT=http://prisma.mynamespace:4466  yields in
Opening https://app.prisma.io/cli-auth?secret=xxxxx. in the browser

Could not open the authentication link, maybe this is an environment without a browser. Please open this url in your browser to authenticate:

same when i put PRISMA_ENDPOINT in a .env file and pass it as --env-file .env
HOWEVER, if I call prisma deploy --new and just pass the endpoint, it works! So its clearly a bug. The server currently has no secret and i also not using prisma-cloud.
The error happens in 1.29 and in 1.30.0-beta.8 as well.

@macrozone : Thanks for the information, that is indeed strange that same endpoint works with two separate code paths, are you sure that your environment is correct? You can confirm so by dropping to an older version like 1.25 and see if this works there?
Would you mind filling this: https://prisma-io.typeform.com/to/C1JBOT that would give me all the info I need to debug this, thank you :)

@macrozone : Thanks for the information, that is indeed strange that same endpoint works with two separate code paths, are you sure that your environment is correct? You can confirm so by dropping to an older version like 1.25 and see if this works there?
Would you mind filling this: https://prisma-io.typeform.com/to/C1JBOT that would give me all the info I need to debug this, thank you :)

already did the later, i now try to downgrade to 1.25!

@macrozone : I am unable to reproduce, can you please share your Prisma server version as well?

@macrozone Thanks for the detailed repro and filling out the form, I was able to reproduce and fix it, can you please try out the latest beta CLI 1.30.0-beta.9, please install it via npm install -g prisma@beta

@divyenduz Works now. Thanks!

[ooooo@stealth: prisma-datamodel]$ prisma deploy
Opening https://app.prisma.io/cli-auth?secret=XXXXXXXXXXXXXXXXXXXXX. in the browser
Could not open the authentication link, maybe this is an environment without a browser. Please open this url in your browser to authenticate: https://app.prisma.io/cli-auth?secret=XXXXXXXXXXXXXXXXXXXXXXXX.
Prisma CLI version: prisma/1.31.2 (linux-x64) node-v10.15.3
to use the materials in accordance with the terms of the Agreement.
endpoint: http://stealth_prisma_1:4466
datamodel:
user schema

../../oasismetamodel/generated/prisma/oasis/user.prisma

system configuration

../../oasismetamodel/generated/prisma/oasis/systemconfig.prisma

terminal schema

../../oasismetamodel/generated/prisma/stealth/demo-terminal.prisma
../../oasismetamodel/generated/prisma/stealth/terminal.prisma

generate:

generator: typescript-client
output: ./generated/prisma/
generator: graphql-schema
output: ./generated/graphql/prisma.graphql

Docker ENV
[oasis@stealth: prisma-datamodel]$ docker ps
CONTAINER ID        IMAGE                       COMMAND                  CREATED             STATUS              PORTS                                                                    NAMES
b7dab874a2c6        prismagraphql/prisma:1.31   "/bin/sh -c /app/sta\u2026"   18 minutes ago      Up 18 minutes       <IP_ADDRESS>:4466->4466/tcp                                                   stealth_prisma_1

@kshenes
Can you please share some information about your environment?
Also, this seems to be a new issue(warning is different), so feel free to open a new issue with a minimal reproduction

We have multiple docker containers three of them run prisma. two with Yoga and mySql, and one with timescale and postgres. We were running 1.27.3 without issue. When I upgraded to 1.31, now 1.32 prisma deploy was forcing login.  So it appears there was a change prisma deploy that confuses private endpoints with public endpoints. https://github.com/prisma/prisma/commit/7928f41b9729ee39882bae8990dd09ffe0d43104#diff-c458e90af2ed9c4b67c3020170a56aa9.  I was able to get past this problem by adding a .env file with a secret and add it to docker-compose file.

cc @divyenduz

@divyenduz @kshenes
I can confirm this.
with account logged in:

without account logged in:

Reproduction Repository: https://github.com/pantharshit00/prisma-issue-4215

Closing in favour of https://github.com/prisma/prisma/issues/4483

Closing in favour of #4483

I am also getting this error now with use of prisma 1.34.0

ERROR: No cluster could be found for workspace '*' and cluster 'default'

{
  "data": {
    "generateClusterToken": null
  },
  "errors": [
    {
      "message": "No cluster could be found for workspace '*' and cluster 'default'",
      "locations": [
        {
          "line": 3,
          "column": 9
        }
      ],
      "path": [
        "generateClusterToken"
      ],
      "code": 222
    }
  ],
  "status": 200
}

--

Hello, I'm facing this issue as well
`
ERROR: No cluster could be found for workspace '*' and cluster 'default'
{
"data": {
"generateClusterToken": null
},
"errors": [
{
"message": "No cluster could be found for workspace '*' and cluster 'default'",
"locations": [
{
"line": 3,
"column": 9
}
],
"path": [
"generateClusterToken"
],
"code": 222
}
],
"status": 200
}`
prisma.yml
`endpoint: http://<IP_ADDRESS>:4466
datamodel: datamodel.prisma
secret: "123"
generate:

generator: javascript-client
output: ./generated/prisma-client/`

docker-compose.yml
`version: '3'
services:
prisma:
image: prismagraphql/prisma:1.34
restart: always
network_mode: "host"
ports:
- "4466:4466"
environment:
PRISMA_CONFIG: |
port: 4466
# uncomment the next line and provide the env var PRISMA_MANAGEMENT_API_SECRET=my-secret to activate cluster security
managementApiSecret: 123
databases:
default:
connector: mysql
host: host.docker.internal
user: root
password: prisma
rawAccess: true
port: 3306
migrations: true
mysql:
image: mysql:5.7
restart: always
# Uncomment the next two lines to connect to your your database from outside the Docker environment, e.g. using a database GUI like Workbench
# ports:
# - "3306:3306"
environment:
MYSQL_ROOT_PASSWORD: prisma
MYSQL_ROOT_HOST: '%'
volumes:
  - mysql:/var/lib/mysql

volumes:
mysql:
`


Malformed OpenType vendor table causes beautifulsoup to process partial sections

Observed behaviour
The fontbakery-microsoft-vendorlist.cache shipped with fontbakery contains a broken entry for the MDIV font vendor (it has a </a> for which no opening <a href=...> tag is present). Beautifulsoup stops processing all entries after this one, so vendors MDSN through MYFO are missing from the registered_vendor_ids. I will report the root issue to the maintainers of that list; the online version at https://docs.microsoft.com/en-us/typography/vendors/ contains the same error.
Expected behaviour
Either skip the broken entry or silently ignore this minor infraction against HTML syntax.
Resources and exact process needed to replicate
Run fontbakery against a font from any vendor between MDSN and MYFO, such as Datto D-DIN, which was derived from a Monotype font.

I reviewed my workaround and with the benefit of 20/20 hindsight I noticed that a cleaner solution would be to use a more lenient beautifulsoup parser. This would, however, add 200 ms to each invocation of registered_vendor_ids(), which on my laptop already takes 400ms wall clock time.
Would it make sense to convert the fontbakery-microsoft-vendorlist.cache file to JSON format at package build time? On my system, it takes registered_vendor_ids() down from 400ms+ to just 40ms. It would move some code to a script under Lib/fontbakery/commands, add one line and 600ms to the manual build process, and result in the registered_vendor_ids() becoming trivial code. It would shift the extra requirement of the html5lib to the package build process, the new production code would use the already included json package.
The fontbakery run is the longest wait of my workflow, so even presuming registered_vendor_ids() is called but once per font, it would shave 5% off the runtime according to a back-of-the-envelope calculation.
I'm willing to do the legwork, copious spare time permitting.


How to package common code between multiple webparts to a separate bundle?

Category
[X] Question
[ ] Typo
[ ] Mistake
[ ] Additional article idea
Expected or Desired Behavior
The Wiki contains instructions on how to share a library among multiple webparts in order to reduce the resulting bundle sizes. However this approach seems to work only for external libraries.
Is it somehow possible to generate a separate bundle for code, that is shared among multiple webparts but which is not written as an external library?
If this is not currently possible, then could you consider supporting it in the future. Perhaps the yeoman generator could support adding "internal libraries" to the project in addition to adding just new webparts.
Example
Currently if a project has the following structure where both webparts import the veryLargeModule, then the end result is two large bundles (webpartOne.bundle.js and webpartTwo.bundle.js) because the common code is copied to both of those bundles.
If the veryLargeModule could somehow be bundled separately, the end result would be three separate bundles (webpartOne.bundle.js, webpartTwo.bundle.js and veryLargeModule.bundle.js) and the total size of those bundles would be smaller.
src/
|-- libraries/
|   +--veryLargeModule/
|       +--veryLargeModule.ts
+-- webparts/
     |--webpartOne/
     |  +--WebpartOneWebpart.ts
     +--webpartTwo/
       +--WebpartTwoWebpart.ts

Workaround
As a workaround the common code can of course be written as a separate npm module which is then added to the externals section of the config.json.  This approach will however require quite a bit of extra work as both of these projects (shared code and the webparts) need to built and packaged separately.

@artokai - have you gone down the path of a single bundle for the group of webparts?  Ie, one bundle contains the source code for a set of webparts.
You are correct though that you don't want to bundle the code into your webpart.  We have hit this issue as well internally, with webparts that have a file picker bundling that code into the webpart itself, causing them to all increase in size.  The easiest solution was to put the various webparts into a single bundle, but that might not be the right solution for you.  Your workaround is valid.
Digging into the actual enhacement / feature request, would it something along the lines of
Add library sub project
contents of the subproject gets its own bundle
when you deploy, this bundle gets deployed separately, and is loaded as if it was an external library?
One slightly confusing thing here (in my mind), is the question of "how do I have multiple web parts leverage this"?  As soon as I create a new project and want to use the library, don't I need to consume it as if it was an external npm module?  (I could be missing something here)

Thanks for the suggestion @patmill!
Packaging all of the related webparts in the same bundle might actually be a better way to handle this than extracting all shared code to a separate npm package. Does the spfx-tooling and its configuration files already support this or do you need to create custom build steps to do it?
And your understanding about the feature request is the same as I had in my mind. After the Library sub-project would have been added, it would then be compiled to a separate bundle. This would allow us to place code, that is shared between various webparts, to the library subproject where it would not bloat the size of all of those individual webpart bundles.
I confess that I did not think very much about how these internal libraries would then be referenced from the webpart side. From the developer perspective it would be nice if we could just import them using the relative path of the module. This would allow the IDE to find the module and for example Intellisense-features would just work.  Unfortunately I'm not sure how and if the webpack could be configured to bundle these "internal libraries" to separate bundles.

Yes - if you run the yo generator again in the same root folder, you can add an additional webpart, and it will create the webpart manifest, etc.
One caveat though - it doesn't let you chose a different framework for the additional webparts at the moment.
@waldekmastykarz has a blog post on this (although I think it is based on Drop 1.  The latest drop fixes the issues around mystrings) - https://blog.mastykarz.nl/add-second-web-part-sharepoint-framework-project/

I've actually already added two separate webparts to the same project, but this results in two separate JavaScript bundles (one for each webpart). I haven't yet figured out how to combine multiple webparts together in the same JavaScript bundle.

@patmill I think there are two scenarios we could distinguish:

Multiple Web Parts in the same project reuse some code. A library bundle stored in the same project as Web Parts, that could be referenced as an external resource in the different Web Parts would be a great solution here.
Multiple Web Parts from multiple projects reuse some code. I guess that in this case the preferable way would be to have the shared code deployed to a central location and refer it from there as an external module. If we used it as an npm package then it would be included in the bundle by default, wouldn't it? Developers would need to take care of typings which they could install from a central location to their project.

How does that sound?

I see that @waldekmastykarz has solved this issue in his blog post. It would be great if the spfx would support this kind of thing natively by allowing users to add internal libraries to the project via yeoman.
Perhaps webpacks's CommonsChunkPlugin could also somehow be used to split the internal libraries to separate bundles. That might remove the need for generating and updating a separate typings-file for the internal library (as described in Waldek's blog post).

Today we allow a single solution to have multiple components / webparts.  This is the best way to have code shared.  If you need the idea of manifests, and not just a solution that shares all of your code, see this user voice entry - https://sharepoint.uservoice.com/forums/329220-sharepoint-dev-platform/suggestions/19224202-add-support-for-library-packages-in-the-sharepoint


Bugfix: add a default limiter to received request bodies

additionally, partially address a bug in which polling a chunked body with a long chunk size and a short buffer never completes.

It is unclear to me if the unbounded allocations are in fact a bug, but this has come up twice now as a potential concern. Note that trillium does not read request bodies from untrusted connections outside of application code.
However, now that there is a http tuning configuration struct, it will be straightforward to set a maximum received body length for an entire server.


Docker: Add a Dockerfile and Makefile targets

Hey!
I wrote a Dockerfile and an entrypoint (inspired by the Redox ones) to build the kernel via Docker.
What do you think?
Cheers :)
Edit: see #369 for discussion/more information

I decided to merge this as is. The duplication of the  run target can still be removed in a follow-up PR if desired. Thanks a lot for the PR, @Sh4d1! And thanks to @andre-richter for reviewing!


feat(code): width = block

When opts.code.width = 'block'
With an optional opts.code.pad_right

I really like this UI change as well :)
Could we

@MeanderingProgrammer rebased on main.

I had to refactor the code a bit, since the Normal block on the right had a higher priority than the diagnostics and would cut them off.
Fixed by setting priority to 0 and by changing the thin border to only render up to width of the block when width = "block"

Looks good, thanks for the details!

Thank you for merging!
I also just merged the LazyVim PR, so markdown.nvim is now the default LazyVim renderer for the markdown extra :)


fix: y-axis scrolling jump on heatmap download

#3569

Reviewers
Functional: @tihuan
Readability: @tihuan

Changes

add
remove
modify

Scrolling back to y-axis position after downloading image

QA steps (optional)
Notes for Reviewer

@signechambers1 Preview for the current solution for this, please take a look when you can!
You can see there's still a "jump" but it goes back to the original position. I also added the Loading indicator when downloading the image to make it more clear that something is happening
https://images.zenhubusercontent.com/228681195/8e0201d9-3808-4d72-ba3f-0fbdb9b018cc/_3569_preview_screen_recording.mov

Also now thinking about it, we can restore the scroll position as soon as we call the HTML to image function too, instead of waiting until the download starts. So hopefully that will reduce the time the scroll top is misplaced?

Done!
https://github.com/chanzuckerberg/single-cell-data-portal/pull/3691/files#diff-a884e74868313637f94b1225899c391e1b3f2e550c648e0f6a9a871a6ee4f91eR113

Hmm I was experimenting with when to restore the scroll position and different options don't seem to make any visible difference, since the jump happens when the convert happens 🤔
I guess if it helps, we could also temporarily at a tinted screen over the viewport to make the app not interactive on top of the loading state, so the scroll jump is less noticeable or matters? Up to Signe!

Thanks y'all, this is definitely better but the jump is still a little jarring. Would the tint be easy to add? fyi @hthomas-czi

Thanks for checking it out already, Signe!
Yeah the tint is super easy to add, if Andrew doesn’t have time because of
all the meetings he has, I can add it some time today!
On Thu, Dec 8, 2022 at 9:55 AM signechambers1 @.***>
wrote:

Thanks y'all, this is definitely better but the jump is still a little
jarring. Would the tint be easy to add? fyi @hthomas-czi
https://github.com/hthomas-czi
—
Reply to this email directly, view it on GitHub
https://github.com/chanzuckerberg/single-cell-data-portal/pull/3691#issuecomment-1343089504,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQEOW4QAHIJVJZ4MHSPNTDWMIOJ7ANCNFSM6AAAAAASXEKWIQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Timmy Huang (he/him)
Front End Software Engineer
https://chanzuckerberg.com/?email
c: +1<PHONE_NUMBER> <+16267156079>
@.***
https://chanzuckerberg.com https://chanzuckerberg.com/?email
https://www.instagram.com/chanzuckerberginitiative/
https://twitter.com/ChanZuckerberg
https://www.facebook.com/chanzuckerberginitiative/

@signechambers1 @hthomas-czi @tihuan
How does this look with the tint?
https://user-images.githubusercontent.com/109984998/207400696-41d9154b-d5ea-4a22-b4ac-a05a2583b111.mov

Nice tint!! Probably defer to @signechambers1 and @hthomas-czi , but I'm wondering if we should make the tint darker and/or with filter: blur to hopefully obscure the scroll top change more?

Nice tint!! Probably defer to @signechambers1 and @hthomas-czi , but I'm wondering if we should make the tint darker and/or with filter: blur to hopefully obscure the scroll top change more?

Were you thinking of blurring just the Y-axis? Or the whole screen?

I was thinking the whole screen along with the tint lol Not sure if that's too much ahaha

Unfortunately I think it would be a little difficult to get rid of the jump entirely as it's required for the image download (the y-axis height increases to capture the full height in the screenshot). @tihuan I added the tint on my side as well with the blur! Just waiting for confirmation from Signe or Harley on how to proceed!

Yeah the UI change for the screenshot is what's causing the page to jump, because the element that's scrolling is now different, the browser has to go to the top of the page
Awesome thanks so much, Andrew!!

Prod and design (me and karen) signing off on the blur! thanks


Hyperlinks in alert have incorrect colour

After creating a data source, the alert bar fades from green to grey but the links are left with incorrect colours.

You are using Chrome, right? If so, this is a duplicate of #1008 and a known Chrome bug that has already been fixed in the latest development builds.

Already logged and closed/fixed as #1008.
Is this still a problem?

Yes – and it will be until the next major Chrome version is released, I suppose.

Oops didn't see #1008, apologies.


Emit Finalizers and OptionalFields for partial EETypes

EETypes that are not constructed do not have VTables / Interface maps.
Correctly write out the 0 entry count for virtuals and interfaces when
emitting a partial EEType.
Always write the finalizer, optional fields, and nullable type parameter
if these components are used when emitting a partial EEType.

@jkotas PTAL
Fixes issue https://github.com/dotnet/corert/issues/668.

LGTM


Password reset - confirmation message

Add the ability to turn password reset confirmation messages on/off on a per client basis:
{
  "features" : {
    "reset": {
      "notify": true
    }
  }
}

When this value is true, we must send an email to the account which has had its password reset.

Done and pushed into latest.


When empty folders are sent to trash, they are not removed from the project list

Describe the bug
When empty folders are selected on the project explorer and sent to trash, they still appear in the project list when the page is reloaded.
Affects

[ ] Designer
[ ] Blocks editor
[X] Projects Explorer
[ ] Companion
[ ] Compiled apps
[ ] Buildserver
[ ] Debugging
[ ] Other... (please describe)

Expected behavior
Empty folders should be deleted. Currently, folders can't be restored from trash, though more sophisticated folder-trash handling could be a feature in the future.

Hi @SusanRatiLane,
Could you please assign this issue to me? I'd like to start working on it.

Hi @SusanRatiLane, Could you please assign this issue to me? I'd like to start working on it.

Certainly. This should be a good starter task.

Hi @SusanRatiLane,
I'm encountering an issue where changes I make to the code are not being reflected on the server side. Here’s what I’ve been doing:
I followed the steps outlined in the Hot Reloading GWT Code with Super Dev Mode section of the README.
After clicking the "Dev Mode On" bookmarklet, a popup appears with a button to compile the code module.
I press the button, and the GWT CodeServer compiles the module incrementally.
However, after the compilation, instead of the expected result, I get a completely blank (white) page.
Environment Details:
OS: macOS
IDE: IntelliJ IDEA
Browser: Chrome
Server: Running locally
Is there something I might be missing in the setup or execution process? Any guidance would be greatly appreciated.
Thanks!

Hi @SusanRatiLane,
I'm encountering an issue where changes I make to the code are not being reflected on the server side. Here’s what I’ve been doing:
I followed the steps outlined in the Hot Reloading GWT Code with Super Dev Mode section of the README.

You should start at the beginning of the Running the Server(s) section. You can skip "Running the build server," but you do need to follow "Running the main server" and "Accessing your local server".
Hot reloading is not necessary.

Hi @SusanRatiLane,
Could you please help me? My changes are not working as expected. Here's the discussion link for more details: [Assistance Needed: Resolving Issue #3222 in MIT App Inventor](https://community.appinventor.mit.edu/t/assistance-needed-resolving-issue-3222-in-mit-app-inventor/134679).
Thank you so much for your attention.

Hello @SusanRatiLane,
I'm working on resolving this issue, but I'm finding it quite challenging as it involves multiple files, which is a bit overwhelming. Could you please guide me or provide a concise roadmap to help me navigate through this?
I suspect the issue might lie in this folder:
src/com/google/appinventor/client/explorer/folder.
For reference, here's a related discussion:
https://community.appinventor.mit.edu/t/assistance-needed-resolving-issue-3222-in-mit-app-inventor/134679.
Thank you!

I'm sorry. Our responses can be delayed. Posting to the forum was the right way to reach us.


Fix progress bar display issue

There is an issue with a Uiprogress runtime error during "nats bench" when the number of publishers exceeds the number of messages. This results in some publishers being assigned 0 messages, which is set as the total for the progress bar. However, Uiprogress does not accept zero as a valid total and throws a runtime error.
To prevent this error, the progress bar can be shown as already completed when there are no messages to publish.
Issue: https://github.com/nats-io/natscli/issues/1134

Thank you


Regression in 4.44.0: minified code error

Bug report

What is the current behavior?
seeing this error in minified version of code:
console error: Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

code works fine in:

non-minified version
when compiled with 4.43.0 of webpack

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
no exceptions

Other relevant information:
webpack version:  4.44.0
Node.js version:
Operating System:
Additional tools:

Thanks for your report. It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

I think here problem with something new with react and terser, without reproducible test repo, we can't help

FWIW I've just had an upgrade to 4.44.0 (from 4.43.0) begin causing failed production builds.. in my project complaints about the aws-amplify module. Sorry for the anecdotal response.

Please create reproducible test repo, otherwise issue will be closed

Duplicate of #11243


fix(flow-design):  fix save button at flow design page's issue (#288)

PR checklist
This would fix the issue #288 , which caused by targeting the wrong element.
Looks like there's an 'overlay' suppose to be triggered, however, the target element exist neither.
Further improvement can be made by adding tests cases to prevent the issue from occurring.
Docs

[x] If you added new code; is it self documenting? (all the variable names clear, comments added where appropriate)
[x] If you touched existing code; did you refactor existing naming, added comments where necessary?

Tests

[ ] If your ticket adds new functionality; have you added unit tests to verify behaviour?
[ ] If your ticket alters user interaction with the UI; have you added integration tests?
[ ] Do your tests check for every convievable user behabviour? (all behaviours the user can perform)

Typing

[ ] If you added new code; have you added typing?
[ ] If you touched existing code; have you improved its typing?

Styling

[ ] If new styles were created; Did you refactor/add more styles in css-in-js style?

nice PR!


ENHANCEMENT branch alias for dev-master

Current coverage is 65.83% (diff: 100%)

Merging #119 into master will not change coverage

@@             master       #119   diff @@
==========================================
  Files             4          4
  Lines           240        240
  Methods          24         24
  Messages          0          0
  Branches          0          0
==========================================
  Hits            158        158
  Misses           82         82
  Partials          0          0

Powered by Codecov. Last update 81cd401...bd73f8a


ChannelFinderByPopularity becomes aggressive when owned funds jumps significantly

Fixes: #81
This allows the use-case where the user slowly trickles in money rather than give it a one-time big-time deposit.

Good thing I tested this, I caught a bug, ha.
Fixed bug and rebased.


Docker Push on 0.12 always fails on same layer

vwoo@ubuntu:~/coderpad-tty/docker$ docker push coderpad/base
The push refers to a repository [coderpad/base] (len: 1)
Sending image list
Pushing repository coderpad/base (1 tags)
Image 511136ea3c5a already pushed, skipping
Image 663644853bf8 already pushed, skipping
Image e3c9f99b6410 already pushed, skipping
Image 431aaca25584 already pushed, skipping
Image ae8682f4ff20 already pushed, skipping
Image 3bd27d369a9b already pushed, skipping
Image 72abd99222bb already pushed, skipping
Image 2ca33e09132a already pushed, skipping
Image 672a14c7a1e2 already pushed, skipping
Image f2f294a205f3 already pushed, skipping
Image 723986c07441 already pushed, skipping
Image 860b17df91a8 already pushed, skipping
Image 0dfd48b2eb18 already pushed, skipping
Image 0bafe2fe8eb5 already pushed, skipping
dd7b3d876aaa: Pushing [===============================================>   ] 228.6 MB/242.4 MB 3s
2014/06/07 03:57:27 Failed to upload layer: Put https://registry-1.docker.io/v1/images/dd7b3d876aaaeaab145cd3b9a8a19754e6ce748310ab8d598cb471c7506c12ba/layer: read tcp <IP_ADDRESS>:443: i/o timeout
vwoo@ubuntu:~/coderpad-tty/docker$ docker --version
Docker version 0.12.0, build 14680bf
vwoo@ubuntu:~/coderpad-tty/docker$ docker info
Containers: 1
Images: 107
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Dirs: 109
Execution Driver: native-0.2
Kernel Version: 3.11.0-12-generic
Username: coderpad
Registry: [https://index.docker.io/v1/]
WARNING: No swap limit support

Hi.  I'm generating this error
The push refers to a repository [arcolombo/artemisunlayer] (len: 1)
3b15a479aa85: Image already exists
f43a789562e2: Image already exists
20895e1cb336: Image already exists
8bf26c72ef69: Image already exists
90e1f131e119: Image push failed
FATA[1416] Error pushing to registry: Put https://registry-1.docker.io/v2/arcolombo/artemisunlayer/blobs/uploads/4accb54c-a964-4153-ac24-7a8610662ec0?_state=gx-cY2jt1fzbwLyOcnLYZKxt_e4-1cCJ8bK8WUvQwiV7Ik5hbWUiOiJhcmNvbG9tYm8vYXJ0ZW1pc3VubGF5ZXIiLCJVVUlEIjoiNGFjY2I1NGMtYTk2NC00MTUzLWFjMjQtN2E4NjEwNjYyZWMwIiwiT2Zmc2V0IjowLCJTdGFydGVkQXQiOiIyMDE1LTEwLTEyVDE4OjQ1OjQxLjAyMDAwNDg5N1oifQ%3D%3D&digest=sha256%3A1da5e7d6dc4f04d8038b88fe7fd4e726d71e24fc98f4095c711d63b67d760979: use of closed network connection
anthonycolombo@quigonjinn:~/Documents$ sudo docker -D info
[sudo] password for anthonycolombo:
Containers: 1
Images: 129
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 131
Dirperm1 Supported: true
Execution Driver: native-0.2
Kernel Version: 3.16.0-50-generic
Operating System: Ubuntu 14.04.3 LTS
CPUs: 4
Total Memory: 7.712 GiB
Name: quigonjinn
ID: U5LV:PN5L:LQZY:B36M:IJF7:LYRS:LEQB:2NMY:RNVY:IYYV:GWRI:YRBO
Debug mode (server): false
Debug mode (client): true
Fds: 12
Goroutines: 19
System Time: Mon Oct 12 11:51:20 PDT 2015
EventsListeners: 0
Init SHA1: 7f9c6798b022e64f04d2aff8c75cbf38a2779493
Init Path: /usr/bin/docker
Docker Root Dir: /var/lib/docker
Username: arcolombo
Registry: [https://index.docker.io/v1/]
WARNING: No swap limit support
anthonycolombo@quigonjinn:~/Documents$
anthonycolombo@quigonjinn:~/Documents$ sudo docker -v
Docker version 1.6.2, build 7c8fca2


Link to XO-Chip specs inline

I find navigating to the docs folder in github from Octo on github pages somewhat annoying, figured a direct link was useful since this doc also gets converted to HTML by github pages.

Sure, that makes sense!


Removing unwanted styles from swagger

@lakmali would you mind explaining why we are removing these CSS files? Are those not used? Thanks!

@imesh The reset.css contains font styles and they conflict with the wso2 theme fonts. So importing reset.css will reset the font styles and messes the wso2 theme.
print.css contain styles that get applied in the print preview mode of the web page. So if we are to import it, uuf should support importing styles in media=print option which is not supported currently. Since this is not required for a useful functionality and also not having print.css will not mess the print preview, we can go without it. I will raise a future improvement for importing print styles.

@lakmali Thanks for the explanation!


⚠ Bofrost.lu has degraded performance

In 49a1d5c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 997 ms

Resolved: Bofrost.lu performance has improved in 94a14af after 8 minutes.