textfield icons via style

Would be great to have textfield icon styles like:
https://design.gs.com/input-icon-variations.png
https://media.geeksforgeeks.org/wp-content/uploads/20210327231910/materialdesigntextinputfieldgfg-588x660.jpg
https://static.vecteezy.com/system/resources/thumbnails/004/141/447/small/search-bar-horizontal-linear-border-with-text-input-field-magnifying-glass-icon-in-frame-simple-flat-searching-button-design-for-seo-networking-technology-web-ui-internet-navigation-web-browser-free-vector.jpg
https://assets.justinmind.com/wp-content/uploads/2019/04/web-form-design-validation.png
We could use styles:
f_textfield_lefticon_
f_textfield_righticon_
e.g. f_textfield_righticon_address, f_textfield_righticon_search
The name could be a fonticon name/constant?
f_textfield_valid (also changes border color)
f_textfield_error (also changes border color)
f_textfield_warning (also changes border color)
f_textfield_info (also changes border color)
With this feature, we could remove some label e.g. Search

{} => mandatory
[] => optional, can be cut out -> dont add the "_" before or after either!
Icon syntax:
f_icon_{prefix/suffix}{FontAwesome.}{iconName}{ColorInHex}_[OptionalColorForDarkMode]
Examples:
f_icon_prefix_search_#ff0000
f_icon_suffix_FontAwesome.search_#ff0000_#ff00ff
Bordersyntax:
f_border_[focused]color{ColorInHex}_[ColorForDarkMode]
If no colors for the dark mode are specifically set, uses the normal color.

please post a list of valid icon names

color should be optional anf dhould start with # I guess

It already is, i just posted it wrong.

please post a list of valid icon names

https://github.com/sibvisions/flutter_jvx/blob/main/lib/src/util/font_awesome_util.dart
Every string in the map "ICONS" is possible. With or without "FontAwesome."


feat(server-sidebar): enable vps section for US accounts

ref: MANAGER-3090
:rocket: Feature
Enable VPS section for US accounts

Hello @JeremyDec,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3

Hello @JeremyDec,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3


Memory issue in training code

Hello.
I have tried to run your code for the S3DIS dataset. However, with 128GB of memory, the process keeps getting killed when the shuffle buffer for the evaluation of the 2nd epoch is getting filled. When monitoring the memory, it seems that the buffer never gets cleared, it just keeps filling up at the beginning of each epoch.

The problem is resolved by building the dataset initializer outside the training loop.

Hi, I followed the official tensorflow website of tf.Data to prepare the data feeding, and did not encounter this problem in the experiments. Just curious. When you move the initializer outside the training loop, is the dataset still shuffled differently in every epoch?

Here is what I did and it seems to work fine.
Outside the training loop:
trainset = input_fn(trainlist, BATCH_SIZE, 10000)
train_iterator = trainset.make_initializable_iterator()
init_train_iterator = train_iterator.make_initializer(trainset)
next_train_element = train_iterator.get_next()

Inside the training loop:
sess.run(init_train_iterator)
train_one_epoch(sess, ops, next_train_element, train_writer)

Then you can do the same thing for the test set.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_aa58f578-3436-4f42-a09d-05f17b05edb0/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_aa58f578-3436-4f42-a09d-05f17b05edb0.git

Docs Build status updates of commit 604e018:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_main_2022-02-21-10-11-41 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


When i aded node plugin try to change id node

When I added the plugin node is trying to change the node ID and error appears. At the same time I do not want to plug changed node ID.
Error: Uncaught TypeError: Cannot read property 'toString' of undefined
/**
		 * set (change) the ID of a node
		 * @name set_id(obj, id)
		 * @param  {mixed} obj the node
		 * @param  {String} id the new ID
		 * @return {Boolean}
		 */
		set_id : function (obj, id) {
			obj = this.get_node(obj);
			if(!obj || obj.id === $.jstree.root) { return false; }
			var i, j, m = this._model.data;
			id = id.toString(); //THIS APPEARS ERROR
			// update parents (replace current ID with new one in children and children_d)
			m[obj.parent].children[$.inArray(obj.id, m[obj.parent].children)] = id;
			for(i = 0, j = obj.parents.length; i < j; i++) {
				m[obj.parents[i]].children_d[$.inArray(obj.id, m[obj.parents[i]].children_d)] = id;
			}

What is the "node plugin"? From what I see set_id is invoked without the second id parameter. If it is your code that is calling set_id - make sure you pass in the second parameter.
I am closing this, if you think it is jstree's own code that is calling set_id - please provide more info so that I can reproduce the issue.
Best regards,
Ivan

What is the "node plugin"?

Sorry for spelling. When i aded node, jstree plugin try to change id node

if you think it is jstree's own code

Yes it is jstree code

please provide more info so that I can reproduce the issue.

If it can help i maked screenshoot
https://www.dropbox.com/s/70g9xx5kpd4ts1t/Безымянный.png?dl=0

I think it is obvious from the screenshot that it is NOT jstree's own code.
Please, take a look at the stack trace and fix the function call from the anonymous inline function in your page.
Best regards,
Ivan

It is jstree's own code.
But it does'not matter. The problem was that i returned id after add node, simple id, but the correct was returm array {'id':1}.
Thanks for help.


Tutorial or documentation on pycolmap

I hope to use colmap in Python, so I found this project. Where can I find the documentation for this project, or the introduction of its functions/classes

Hi @jhzgjhzg, the current repo indeed lacks good documentation. Until we find time to add proper documentation, I suggest having a look into hloc or pixsfm. Both projects use pycolmap extensively.
YOu can also try help(pycolmap.Reconstruction), which provides some documentation about functions and classes (a lot of them have useful docstrings and strongly typed parameters).

In hloc I got an error during visualization (viz_3d.plot_reconstruction)
'pycolmap.Image' object has no attribute 'rotmat'
Seems like they tried to get rotation matrix from the Image object. Could you suggest how to fix such issue?

https://github.com/colmap/colmap/pull/2749 adds API docs for PyCOLMAP, available at https://colmap.github.io/pycolmap/index.html


Cop crashing after updating use_packwerk to latest version

In our project we don't explicitly use rubocop-packs, but we do use use_packwerk.
After updating use_packwerk from v0.55.0 to v0.58.1, we started getting the following issue while running Rubocop:
An error occurred while Packs/NamespaceConvention cop was inspecting path/to/file.rb.
undefined method `include?' for nil:NilClass

            package_enforces_namespaces = cop_config['IncludePacks'].include?(package_for_path.name)
                                                                    ^^^^^^^^^
.../rubocop-packs-0.0.12/lib/rubocop/cop/packs/namespace_convention.rb:60:in `on_new_investigation'

The interesting bit is that we are not requiring rubocop-packs in our .rubocop.yml file, so I'm unsure as to why this cop is even running to begin with.
I've nonetheless attempted to explicitly require it, but to no avail.

Thanks for reporting this @iMacTia . Let me get this fixed for you.

@iMacTia So I am in the mist of trying to migrate package_protections to rubocop-packs and I think this is a fallout from that.

@iMacTia So I am in the mist of trying to migrate package_protections to rubocop-packs and I think this is a fallout from that.
Can you try bundle update rubocop-packs --conservative to update to 0.0.13 which should fix this for ya? Apologies for this -- since we're still in the early stages of some of this toolchain there is some turbulence but I'm hoping to land on something more stable at some point in the future.

Hey @alexevanczuk, thank you for the quick reply! I completely understand, I'm merely reporting to help identifying possible bugs 🙌
I'll try your suggestion and report back ASAP 👍

All good, getting the new cop offenses correctly now. I'll look into them 👍!
Closing this issue now, though I have a follow-up question if you don't mind 🙏

I am in the mist of trying to migrate package_protections to rubocop-packs

We had already configured package_protections cops in our project, is rubocop-packs a superset or should we keep both for the time being?


support all line endings in shader preprocessor

Objective

Advance uses of shaders seems to often fail for Windows users
Bevy split lines on '\n' which messes with windows line endings

Solution

Uses Rust built in https://doc.rust-lang.org/std/primitive.str.html#method.lines

Well. Approved aside from it breaking tests. :)

fixed!

bors r+


Refactor setting config from argv

Summary
This PR aims to refactor how we translate config from CLI.
Notes:

Set default CLI boolean options to undefined, so yargs doesn't default them to false (defaults are handled in defaults.js so I put watchman and cache there)
Thanks to that setFromArgv is now more generic, translating any value (with some exceptions) to new config before normalizing (makes some weird hacks around config/argv unnecessary).
Renamed setState within jest-cli to updateArgv because that's what it does.
Types within normalize are a bit loosened now (they didn't really work fully, which we need to update in a followup)

Fixes #3403.
Test plan
jest

Codecov Report

Merging #3424 into master will increase coverage by 0.36%.
The diff coverage is 70.58%.

@@            Coverage Diff            @@
##           master   #3424      +/-   ##
=========================================
+ Coverage   64.04%   64.4%   +0.36%
=========================================
  Files         177     177
  Lines        6570    6541      -29
  Branches        4       4
=========================================
+ Hits         4208    4213       +5
+ Misses       2361    2327      -34
  Partials        1       1

Impacted Files
Coverage Δ

packages/jest-config/src/defaults.js
100% <ø> (ø)
:arrow_up:

packages/jest-cli/src/runJest.js
0% <0%> (ø)
:arrow_up:

packages/jest-config/src/utils.js
95.74% <100%> (+0.18%)
:arrow_up:

packages/jest-cli/src/watch.js
76.11% <100%> (ø)
:arrow_up:

packages/jest-cli/src/lib/updateArgv.js
95.45% <100%> (ø)

packages/jest-config/src/index.js
26.08% <33.33%> (ø)
:arrow_up:

packages/jest-config/src/setFromArgv.js
55% <52.63%> (+52.56%)
:arrow_up:

packages/jest-config/src/normalize.js
90.2% <77.77%> (+0.66%)
:arrow_up:

packages/jest-runtime/src/index.js
76.35% <0%> (+0.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0817d64...1d8dacf. Read the comment docs.

I tested this branch, and it doesn't work for me.
yarn jest -- --coverage --testPathPattern eslint --coverage-reporters html
yarn jest v0.23.3
$ node ./packages/jest-cli/bin/jest.js --coverage --testPathPattern eslint --coverage-reporters html
/Users/simen/Development/jest/packages/jest-util/build/validateCLIOptions.js:62
    throw createCLIValidationError(unrecognizedOptions, allowedOptions);
    ^

● Unrecognized CLI Parameters:

  Following options were not recognized:
  ["coverage-reporters", "coverageReporters"]

  CLI Options Documentation:
  http://facebook.github.io/jest/docs/cli.html

error Command failed with exit code 1.

I'm still planning more testing for this tomorrow, forgot to mention that. Right now I just wanted to have feature parity. Thanks for looking into it!

@thymikee this is super awesome, I didn't think we'd get this done before Jest 20. I really appreciate you taking this on and will give a more thorough review tomorrow.
One thing that I like about all of the rewrites we did for Jest 20 is that the entire codebase became a lot more approachable and everything makes much more sense. We now have a clear flow from:
DefaultOptions + User specified options + Argv -> InitialOptions -> ProjectConfig & GlobalConfig
That's beautiful.

@cpojer Addressed all the requests
@SimenB can you test it now?

It does work now. Should support kebab in addition to camel cased, though 😄
$ yarn jest-coverage -- --testPathPattern eslint --coverage-reporters html
yarn jest-coverage v0.23.3
$ yarn run jest --silent -- --coverage --testPathPattern eslint --coverage-reporters html
/Users/simen/Development/jest/packages/jest-util/build/validateCLIOptions.js:63
    throw createCLIValidationError(unrecognizedOptions, allowedOptions);
    ^

● Unrecognized CLI Parameter:

  Unrecognized option "coverage-reporters". Did you mean "coverageReporters"?

  CLI Options Documentation:
  http://facebook.github.io/jest/docs/cli.html

error Command failed with exit code 1.
error Command failed with exit code 1.

Especially since I got this before:
  Following options were not recognized:
  ["coverage-reporters", "coverageReporters"]

YES. Great work @thymikee.


Class methods lost when object passed to a scoped slot

Version
2.5.3
Reproduction link
https://jsfiddle.net/smyv26u2/
Steps to reproduce
Uncomment the price with VAT.
What is expected?
The second list should also display the price with VAT
What is actually happening?
There is an error in the console:
TypeError: product.priceWithVat is not a function

It works using a plain JS object instead of a class: https://jsfiddle.net/7tfvoctd/

I just took a quick look at the renderSlot function and found this:
if (scopedSlotFn) { // scoped slot
  props = props || {}
  if (bindObject) {
    ...
    ...
    props = extend(extend({}, bindObject), props)
  }
  ...
}

And the extend function:
export function extend (to: Object, _from: ?Object): Object {
  for (const key in _from) {
    to[key] = _from[key]
  }
  return to
}

So, my best guess is that as the product instance of Product class is being merged with an object literal, all of its prototype's methods are being discarded because of the for in iterating over the enumerable properties of the object, and the constructor & any defined methods are non-enumerable properties of the class's prototype object.
Using an object literal instead of a class instance would be the best workaround if possible.

This is expected behavior, because scoped slot props are not passed directly, it's always copied as a plain object. Just imagine if you have another v-bind:foo="123" alongside the v-bind="product", foo needs to be merged with the keys found in product.

Wrapping your class instance in an object bypasses this problem.

What do you mean? Can you give me an example?

Instead of:
<slot v-bind="MyClassObject"></slot>
You do something like this:
let MyWrappedClassObject = {'object': MyClassObject}
<slot v-bind="MyWrappedClassObject"></slot>

<template slot-scope="MyWrappedClassObject">
  {{ MyWrappedClassObject.object.value }}
</template>

That works, thanks.
You can also utilise shorthand properties and object destructuring to make it cleaner.
In component:
<slot v-bind="{product}"></slot>

In parent:
<template slot-scope="{product}">
    {{ product.priceWithVat() }}
</template>


Organization List Scene

Depends on #95 #111

After discussing with @prutherford we are going to skip this for initial release. v2 doesn't even have this, and Patrick wants 1+ lists that are relevant to the user.


Assign pre-existent IP to bastion - fixed_ips doesn't work

I've noticed that is only possible to assign the bastion_vip which is used for keepalived when 2 HA bastion servers are set.
the fixed_ips is ignored at bastion, only fixed_ip_v4 which is used by bastion_vip and keepalived is used, is possible to add the possibility to assign a pre-defined IP to bastions when use HA?

@cs-zhang

An issue I see when assign pre-existent IPs to masters, bootstrap and workers, there's a risk to bastion gets the IP that should be reserverd to OCP cluster and builds stop since IP is already in use, so a good practice would be have the possibility to determine the IP the bastion(s) will have as well.

That is caused by the static IP is not support the bastion HA,  I'll add it.  In this case, all VMs created by TF need to use static IP, or not use it at all.


add ipv6 support

add ipv6 support

Thanks for the PR! Could you split the IPv6 into a separate callback from the IPv4 (e.g., creating a new local function register_both_src_dest_IPv6(menu_title, url), so that way a function can be registered for only IPv4 or only IPv6, without being registered for both?
The reason I ask for that is because some services have different endpoints for IPv4 and IPv6 and I'd like to avoid introducing broken context menu actions.

yep, you got it. Will do.
On Fri, Sep 15, 2023 at 11:11 AM Moshe Kaplan @.***>
wrote:

Thanks for the PR! Could you split the IPv6 into a separate callback from
the IPv4 (e.g., creating a new local function
register_both_src_dest_IPv6(menu_title, url), so that way a function can
be registered for only IPv4 or only IPv6, without being registered for both?
The reason I ask for that is because some services have different
endpoints for IPv4 and IPv6 and I'd like to avoid introducing broken
context menu actions.
—
Reply to this email directly, view it on GitHub
https://github.com/moshekaplan/wireshark_investigators_pack/pull/5#issuecomment-1721441160,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4C2IACFSEU4AGODFQC6ULX2RV33ANCNFSM6AAAAAA4Z5ED5U
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
!Dmitry
https://www.infosecog.com


No color on suggest icon with ipynb

Does this issue occur when all extensions are disabled?: Yes/No

version: 1.79.2 (user setup)
: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
日期: 2023-06-14T08:57:04.379Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Steps to Reproduce:

you can see this is no color in suggest icon even the lightbulb is no yellow,but it work fine in .py file:

It might be list view color override

It might be list view color override

do you mean the theme color of vscode?

This is yet another issue with list widget's css rules being too generic. With the introduction of https://github.com/microsoft/vscode/commit/f07184772ad02eaa06ab1641714deee2bbb3853f#diff-a1e616a504f30625266d85e2b1c082a0e4811404775786b684aa1dbfcef19422 , we always set all codicon to be "inactive" if it's inside a focused list item, other than asking each list view user to set the CSS rules themselves. This means when we have nested list view, all inner list view's codicon's color are removed.
In this issue, we have a suggest widget inside a monaco editor, which is embedded in a list item. The css rules being applied:
.monaco-list .monaco-list-row.focused .codicon {
    color: var(--vscode-list-inactiveSelectionIconForeground);
}

.monaco-editor .codicon.codicon-symbol-constructor, .monaco-workbench .codicon.codicon-symbol-constructor {
    color: var(--vscode-symbolIcon-constructorForeground);
}

Unfortunately .monaco-list .monaco-list-row.focused .codicon always takes effect ;( @joaomoreno any suggestion for how we can handle this properly, from https://github.com/microsoft/vscode/issues/126514 it doesn't seem to be trivial at all.

Still same issue. No colors of method, properties when coding Python in notebook files ..

Also having this issue.

Main suggest icon colors should be fixed by https://github.com/microsoft/vscode/pull/228173

Need to confirm but I think the lightbulb is still incorrectly colored


[UIKit] Object details page: Styles (font, font size, spacing) don't match the mockup in Figma

Tested area:
iOs 14.6 (iPhone 7)
Steps to reproduce:
Run Radzima app
Check the main page
Expected result
Main page matches the mockup (paragraphs are of the same seize between images and text)
Actual results
Main page doesn't match the mockup (paragraphs are not of the same seize between images and text)
Reference: https://www.figma.com/file/YzFdb8zP5n5QNVWMmquRdX/Radzima?node-id=246%3A0

Reproduced the issue on iPhone 7 (iOS 15.0.2) and iPhone 7+ (iOS15.1):


Hard-coded targets

The Prosper Rating targets are hard-coded. We should allow them to be customized either via config or command-line args.

Fixed in https://github.com/grahamtt/prosper-bot/commit/ba23d27f0a49369680c02e22ad80e480f9dc14d5


unable to load PMML model because call_string in undefined.

flerp= vp.learn.tools.load_model("POSTPAID_CHURN_v2.POSTPAID_CHURN_v2")
QueryError                                Traceback (most recent call last)
 in
----> 1 flerp= vp.learn.tools.load_model("POSTPAID_CHURN_v2.POSTPAID_CHURN_v2")
/usr/local/csapps/csjupyter/venv/jupyterhub/lib64/python3.6/site-packages/verticapy/learn/tools.py in load_model(name, input_relation, test_relation)
340                 + "', attr_name = 'call_string')",
341                 method="fetchfirstelem",
--> 342                 print_time_sql=False,
343             ).replace("\n", " ")
344         if "SELECT " in info:
/usr/local/csapps/csjupyter/venv/jupyterhub/lib64/python3.6/site-packages/verticapy/toolbox.py in executeSQL(query, title, data, method, path, print_time_sql)
219             cursor.copy(query, fs)
220     else:
--> 221         cursor.execute(query)
222     elapsed_time = time.time() - start_time
223     if verticapy.options["time_on"] and print_time_sql:
/usr/local/csapps/csjupyter/venv/jupyterhub/lib64/python3.6/site-packages/vertica_python/vertica/cursor.py in execute(self, operation, parameters, use_prepared_statements, copy_stdin, buffer_size)
236             if parameters:
237                 operation = self.format_operation_with_parameters(operation, parameters)
--> 238             self._execute_simple_query(operation)
239
240         return self
/usr/local/csapps/csjupyter/venv/jupyterhub/lib64/python3.6/site-packages/vertica_python/vertica/cursor.py in _execute_simple_query(self, query)
656         self._message = self.connection.read_message()
657         if isinstance(self._message, messages.ErrorResponse):
--> 658             raise errors.QueryError.from_error_response(self._message, query)
659         elif isinstance(self._message, messages.RowDescription):
660             self.description = [Column(fd) for fd in self._message.fields]
QueryError: Severity: ERROR, Message: Error calling getReturnType() in User Function get_model_attribute at [src/Common/JsonUtil.cpp:176], error code: 0, message: Cannot find attribute: [call_string]. Run get_model_attribute(USING PARAMETERS model_name='model-name') without the attr_name parameter to get a list of all (case-sensitive) model attributes., Sqlstate: VP001, Routine: getReturnType, File: /data/jenkins/workspace/RE-ReleaseBuilds/RE-Jackhammer/server/vertica/Catalog/LanguageSupport.cpp, Line: 579, Error Code: 5861, SQL: "SELECT GET_MODEL_ATTRIBUTE (USING PARAMETERS model_name = 'POSTPAID_CHURN_v2.POSTPAID_CHURN_v2', attr_name = 'call_string')"

looks like this loops over a standard list of model attributes and prints them all, however the PMML model we imported didn't define call string on creation, and it's not clear from the vertica documentation that there is a method for editing model attributes to work around this.  we are currently on Vertica 11, and will be moving to 12 soon.

Hi @meatcomputer, load_model does not support PMML yet. This functionality is only available in SQL for the moment. If needed, we can prioritise it for 0.12.1. Can you please explain us the use-case?

We will soon implement it, for any follow up we will use the following issue:
https://github.com/vertica/VerticaPy/issues/347


login with microsoft stuck load

when I did the login with microsoft it put me on a windows page where it auto logged me in the wrong account the one without minecraft and now its stuck forverer on login with microsoft and the windows page says The code has been received. You may now close this window.

Yeah, this is a known issue. The current way the microsoft login is a little unsatisfactory, and there's not a lot I can do about it if I want the launcher to support java 8 and onward (which I do). The workaround for now would be to log into the "wrong" microsoft account, revoke OLauncher's access, and try again, this time choosing another account if possible.
Sorry for the weirdness.

Tracked in #21


Food post

Pulling all updates into master branch and closing the other branch.

Sorry it wasn't intended to be pull requested here


Feature request: Re-add indicators on panel

Add a way to add back the indicators that were removed previously. For example, by mistake I had removed the App Name indicator, now it has moved completely to the front and is not visible on the list, and hence can't be moved. Re-adding the indicator would be helpful. Also, disabling could be added so that the indicator doesn't show up in the panel but is still there in the list (and is greyed out) and can be enabled any time we want. This would allow us to delete the indicators without losing the order they were previously present.

I think I won't implement this. reason is that I don't think it is necessary. If you by mistake click the delete button, just close the settings window and open it again, then the icon should be there again. Removing icons from the list is just to remove clutter when there are so many icons from old apps that are not used anymore


OYO Topics

Here we can keep track of On Your Own (OYO) topics that deserve attention, but not as a part of the core RR workshop. If we have consensus on topics, I'll append then to a list in this comment.
OYO Topics

Statistical modeling primer
More complex / cool / interactive visualizations e.g.: here

Version control with Git

Issues around sharing data (e.g. confidentiality, university data-sharing restrictions, grant requirements for sharing)


Events / Triggers

I'd like to help make events (or at minimum sql triggers) a thing for pocketbase. Being able to fire off in process/async tasks based on data changes would be a really nice application to get this closer to a low code solution. I understand that you can write your own Go code and build a single file binary, but what I'm talking about is more dynamic in nature. It could open up some interesting applications for admins to define 3rd party calls, web hooks, and be the building block for advanced functionality. I have no Go experience, so I'd like someone who is more familiar with the internals of the VM to help me understand what the limitations would be.
I have a question that may be incredibly novice, but hopefully is helpful for other beginners looking at pocketbase.

Could Javascript or Go be written in admin, serialized into the db, and executed at runtime? Something to the tune of https://github.com/svaarala/duktape. What executing admin written Go/etc would open up is the ability to write cloud lambdas that are arbitrarily complex for long running processes. I also appreciate that this may overcomplicate the project.

My gut is that there is no way to build Go code dynamically, but I wonder if there is a javascript (https://github.com/svaarala/duktape) or lisp like language (https://github.com/glycerine/zygomys) that could be embedded in the binary.

My gut is that there is no way to build Go code dynamically, but I wonder if there is a javascript (https://github.com/svaarala/duktape) or lisp like language (https://github.com/glycerine/zygomys) that could be embedded in the binary.

there is way if you brave enough, I already build similiar in dart(flutter) so its parses the UI to the json, but Yeah its a hell hole

Ha, I would imagine embedding a lisp into this would be the simplest option, but very few users would know how to use it. Javascript events are probably the best from a market size perspective.

PocketBase already has event hooks (https://pocketbase.io/docs/event-hooks/), but they are not dynamic (aka. you need to build your app).
There are several existing scripting interpreters for Go that allows executing dynamic code (eg. anko), but they always will have some performance impact and will be more restrictive compared to what you could do by just embedding PocketBase in your Go app (eg. you have to specify what external libraries are allowed to be imported, global functions and variables visibility, etc.).
A more safer and user friendly alternative could be to implement a workflow builder with some prebuilt configurable filter/action blocks that users can manage from the admin UI.
Adding support for something like this is possible, but it will take a lot of time to implement it properly and therefore at least for now it is out of the PocketBase scope.

@elamje Just to let you know that I've outlined a new feature for integrating simple triggers in the prebuilt executable. You can share your feedback in https://github.com/pocketbase/pocketbase/issues/317.

Async-api works well with Pocketbase.
the async-api is golang and code generated. Then you just hook into Pocketbase.
makes it easy to then built real time gui and api with the gui or api using the async-api layer being the glue between the 2 systems.


Change YAML Util File to Blob the Multiple YAML Resource Files Into One File

In support of #53, #54, and #55 - we'll need to blob all the individual YAML files into one for ease of processing and filtering.


Fixing OsgiBundleTest

Motivation:
Twitter hpack is no longer a dependency so the test fails.
Modifications:
Removed the reference to twitter hpack.
Result:
It builds.

ship it!

cherry-picked as 40fd997

@nmittler thanks so much!


chore: add atom

JIRA TASK (Eightfold Employees Only):
ENG-20643

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@136d9e1). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage        ?   76.07%
=======================================
  Files           ?       65
  Lines           ?     1680
  Branches        ?      650
=======================================
  Hits            ?     1278
  Misses          ?      392
  Partials        ?       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136d9e1...8796fa7. Read the comment docs.


please provides one requirements.txt

方便提供一个requirements安装环境，不然会有各种报错，
例如：
File "/home/sam_road-main/model.py", line 102, in forward
src_features = point_features[batch_indices, pairs[:, :, 0]]
IndexError: tensors used as indices must be long, byte or bool tensors
python3.8/site-packages/torch/nn/modules/transformer.py", line 437, in forward
return torch._transformer_encoder_layer_fwd(
RuntimeError: expected scalar type BFloat16 but found Float

另外咨询一下单卡v100-32G训练速度怎么会这么慢，

Hello, I have also encountered the above error, may I ask how you solve it?


Incorrect Usage Instructions

./base16 default.yml silently fails while ./base16 -s schemes/default.yml works as expected.

Thanks, have updated the readme.


Lacey/feature4

Recipe Page - Added error text for absent instruction data,  added icon code for favorites button (currently disabled), updated bootstrap link
Nutrition Page - Added some styling to nutrition fact cards

looks good


Config values other source

I think it will be good to have ability override default behavior for IConfiguration indexer.In my case, this will give options to control from remote runtime configuration values.Please have a look at my suggest.
Regards,
Anton Putau.

Hi @anton-putau, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@anton-putau, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


rotation_vectors with opposite vectors

Looks like it'll return identity, should probably do an 180 around perp

Indeed. Will fix soon


Fix error for ellipse geometry center position with height

I was seeing weird behavior if the center position of the circle had a height.  It looked like it was drawn on the surface, but would disappear if I zoomed in too far.  This adds the height of the center position to the height parameter, then resets the center position to have a height of 0.

This is ready, right?  @bagnell can you merge.


Query filter by date range

Hi!
I am trying to build a query filter by date, assuming that I want to display records after the following service date, i.e. 2016-03-01, I set the filter as
filters: [{"service_date": {"$gt": "2016-03-01"}}],
But the result is always empty even there are records after 2016-03-01 service_date
I have tried using ISODate function following the Mongo manual, it does not work.
Just wonder how this can be done

Did you tried `"$gt": "new Date('...')" ?

Cannot remember but I will try later in the evening.
Thanks for the tips
Sent from my iPhone

On 22 Feb 2016, at 4:31 PM, Petar Korponaić<EMAIL_ADDRESS>wrote:
Did you tried `"$gt": "new Date('...')" ?
—
Reply to this email directly or view it on GitHub.

too bad, does not seems to work

On 22 Feb 2016, at 4:31 PM, Petar Korponaić<EMAIL_ADDRESS>wrote:
Did you tried `"$gt": "new Date('...')" ?
—
Reply to this email directly or view it on GitHub https://github.com/perak/kitchen-site/issues/252#issuecomment-187068285.

@chiacy fixed and will be available in next version v0.9.58 (next week).

thanks !!


Fixed the indentation

It is fine
I will fix it

okay

My bad, but I already added todo to add the localizations for other languages but I should done it myself


Zse42 1.5 Firmware update

@TSHAdmin please review this.

@AlCalzone can you kick off the workflows for this please?

Closing and reopening to trigger workflows


build: Update k8s and openshift go modules to sync with openshift-4.16

This updates the github.com/openshift/* modules to release-4.16 and k8s.io/* to v0.29.3.

o it's a bit early for this change.
This could go in the same PR as the one switching the Makefile to 4.16.

Yes, we can put it on hold till then, I don't think it break current master because from bundle side it is not going to break (no specific code at bundle side).

/hold

/unhold
Updated the bundle to 4.16 also.


OLM need work on aggregation API but it's disabled by Virtual Cluster

What steps did you take and what happened:
[A clear and concise description on how to REPRODUCE the bug.]
OLM need work on Aggregation API for extension apiserver packageserver, but it's disabled by Virtual Cluster.
Please enable the aggregation layer via the following kube-apiserver flags, follows a example:
       - --enable-aggregator-routing=true
       - --requestheader-client-ca-file=/etc/kubernetes/pki/root/tls.crt
       - --requestheader-allowed-names=""
       - --requestheader-username-headers=X-Remote-User
       - --requestheader-group-headers=X-Remote-Group
       - --requestheader-extra-headers-prefix=X-Remote-Extra-
       - --proxy-client-key-file=/etc/kubernetes/pki/apiserver/tls.key
       - --proxy-client-cert-file=/etc/kubernetes/pki/apiserver/tls.crt

Otherwise，
# oc get apiservice v1.packages.operators.coreos.com
NAME                                          SERVICE                     AVAILABLE                      AGE
v1.packages.operators.coreos.com              olm/packageserver-service   False (FailedDiscoveryCheck)   3h38m

Please reference more from: https://kubernetes.io/docs/tasks/extend-kubernetes/configure-aggregation-layer/
What did you expect to happen:
The OLM can be installed successfully.
# oc get apiservice v1.packages.operators.coreos.com
NAME                               SERVICE                     AVAILABLE   AGE
v1.packages.operators.coreos.com   olm/packageserver-service   True        7h33m

# oc get csv packageserver -n olm
NAME            DISPLAY          VERSION   REPLACES   PHASE
packageserver   Package Server   0.18.1               Succeeded

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
I validated the solution by the following workaround:
oc edit sts apiserver -n default-394ccf-vc-sample-1
Then, to add the following flags in args:
        - --enable-aggregator-routing=true
        - --requestheader-client-ca-file=/etc/kubernetes/pki/root/tls.crt
        - --requestheader-allowed-names=""
        - --requestheader-username-headers=X-Remote-User
        - --requestheader-group-headers=X-Remote-Group
        - --requestheader-extra-headers-prefix=X-Remote-Extra-
        - --proxy-client-key-file=/etc/kubernetes/pki/apiserver/tls.key
        - --proxy-client-cert-file=/etc/kubernetes/pki/apiserver/tls.crt

Also need delete apiserver-0 in default-394ccf-vc-sample-1 to enable Aggregation API feature.
Environment:

cluster-api-provider-nested version: built from master branch
Minikube/KIND version: OpenShift 4.7.13
Kubernetes version: (use kubectl version): 1.20.0
OS (e.g. from /etc/os-release):  Red Hat Enterprise Linux 8

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-provider-nested/labels?q=area for the list of labels]

@Fei-Guo @christopherhein @gyliu513 @vincent-pli

I don't have objection to add this to the default apiserver template if it has no side effect for normal usage. @christopherhein What do you think?

@Fei-Guo @christopherhein Aggregation API is the feature of standard Kubernetes for extending Kubernetes: https://kubernetes.io/docs/tasks/extend-kubernetes/configure-aggregation-layer/


Add a Makefile and Analogue Pocket support.

Hi! This is an awesome game, thanks for providing the source too!
I added a Makefile to your project to make compilation a little bit easier and also added support for the Analogue Pocket.
If you could provide a .pocket file along with the regular GB file, people can play it natively on the Analogue Pocket without a flash card.
Thanks again for the great game!

No worries! Happy to help :) You should make a post on r/AnaloguePocket as well to get the word out!


Non-http/ssh traffic between pods?

I am trying to perform ssh between pods and the sidecar envoy proxy is denying it with
ssh_exchange_identification: Connection closed by remote host
If I understand well the sidecar proxy iptables(?) rules redirect all incoming traffic and denies the ssh traffic.
Is there a way to work around that / tweak the configuration?

Not an issue, i found my way around this

Not an issue, i found my way around this

What was your workaround?

Not an issue, i found my way around this

Please let know what was the workaround? I am struggling to find a solution.


Start implementing smoke testing

Where there's smoke, there's fire!
See https://www.atlassian.com/continuous-delivery/software-testing/types-of-software-testing

Lot's more to do here. We want to implement a bare minimum set of sanity tests, like integrating a potential, generating a stream, etc. If anything fails the smoke test we don't need to run the whole test matrix.

To do in a followup. For now it's good to have the framework.


Run demo app tests on travis builds

Now that we've added a sample app (in #7), we can write tests for the project. We should be running those tests on every travis build. This will require a way to install the Test Butler app on the emulator in travis before running tests.

:+1: And it will provide an example for the users of the library on how to use it for their Travis builds.


⚠ Bofrost.at has degraded performance

In 7b3c080, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 943 ms

Resolved: Bofrost.at performance has improved in 85f1c09 after 32 minutes.


[IDE] Handle OpenExistentialExpr in SemaAnnotator

As for OpenExistentialExpr, normal ASTWalker walks into the existential expression first, then walks into sub expression. However, SourceEntitiyWalker must walk AST tree by source order. Handle OpenExistentialExpr and its OpaqueValueExpr so that SourceEntityWalker walks to them in "outer to inner" manner.
rdar://problem/41147733

@swift-ci Please smoke test

@DougGregor Thanks for reviewing! Fixed as per your comments.
Also, added a commit to handle MakeTemporarilyEscapableExpr too. How does it look?


GeneratedPluginRegistrant.java:20: error: non-static method registerWith(Registrar) cannot be referenced from a static context

  String path = file.path;
  int location = WallpaperManager
      .HOME_SCREEN; // or location = WallpaperManager.LOCK_SCREEN;
  String result;
  try {
    result = await WallpaperManager.setWallpaperFromFile(path, location);
  } on Exception {
    result = 'Failed to get wallpaper.';
  }

Hi. This issue has been reported previously without much information. It is related to the plugin-system in Flutter being migrated due to an internal API change. (https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration)
What it means for you as the user is, (your) Flutter, while generating the plug-in files is using the older version (v1) for generating the plug-in files. I'm currently writing a fix for this, but meanwhile, you can try the following:

Inside your android\app\src\main folder, open the AndroidManifest.xml and add
      <meta-data           android:name="flutterEmbedding"           android:value="2" />
at the end of this file, but inside the application tag (i.e. before )
If that does not help, or if that value was already existing/set to "2", you should look at migrating your code to AndroidX.

Let me know if changing the value from "1" to "2" or if migrating to AndroidX helps.

Hi, @Flaccuss I have updated the plug-in to version 1.0.6 today. You should take a look at it again & let me know if the problem still persists. I'm closing this issue for now. Thank you!

Hi, @Flaccuss I have updated the plug-in to version 1.0.6 today. You should take a look at it again & let me know if the problem still persists. I'm closing this issue for now. Thank you!

I am just updated version 1.0.6. It's working.


HHH-16608 literal predicates can match against any type

https://hibernate.atlassian.net/browse/HHH-16608
After #6189 some queries against MariaDB/MySQL (and also on H2 with either mode) are broken because those engines accept predicates against values that are enclosed in literal, such as SELECT * FROM table t WHERE t.some_date = '2023-01-01' and hence that type cannot be refused by Hibernate.
Maybe that should be something configurable from the Dialect :thinking:

@beikov I just saw your comment about the migration of p.dateField > '2023-01-01' to p.dateField > date 2023-01-01 but that would imply some huge migrations in some codebase.
Instead of simply reenabling the literal beahavoir as this PR, maybe it would be also interesting to add a new configuration property (in the persistence.xml) that allow to keep the old behavoir (eg comparing dates against string, but also on other values) ? :thinking:

We decided that this kind of usage was not documented to be supported, but acknowledge the usefulness of it, so we created the improvement issue HHH-16769 for this.
You're very welcome to contribute this general HQL improvement in the way how it is described in the JIRA issue. Join us on v if you want to discuss the design.


Adding a section for user to add a new button and attaching it to firebase backend.

This is a(n):

[ ] Update to an existing Animated Button
[ ] Any Error
[x] Proposal to the Repository
[ ] Documentation / README.md changes

Details:

I wanted to add a section for users to add a new button on the website itself. The HTML, CSS, and js code will be taken as input and stored in the backend and then will be retrieved dynamically from there in the already existing card format.
Firebase will be used as the database.
Please assign this issue to me under the GSSoC'23 label:)

@Akanksha-202 It's a great idea. Assigned to you.
I want to know your approach!
Can we connect on discord for this?
Ping me asap.


Matching whole text instead of first letter only

I think it would be good to have an option to match what user types instead of just taking the input letter by letter. I'm implementing this to pick Country and user almost always types in his country, but ends up on a country that matches the last letter he typed.

Have you considered using liveSearch?


Change outputText to completion in stream mode.

Currently the respective cell is throwing a KeyError with outputText. In stream mode, using claude-v2, each line starts with the keyword completion and not outputText.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

A cleaner solution would be to have a map of keys to models probably. I suggest you test this with a model other than claude before considering merge.

@alkayahan we merged an example of streaming with Claude to highlight the difference. As you mentioned the keyword is different. Please let me know if happy to close this PR.

The changes have already been added in another PR.


Check if some parameter is not set as guess when fitting

See issue #43 -- if you do not set guesses manually, the error message is not easy to parse.

Thanks @kdund . Before fitting, the lack of parameters has already yielded error:
from alea.examples import gaussian_model

simple_model = gaussian_model.GaussianModel()
simple_model.parameters.mu.nominal_value = 0.
simple_data = simple_model.generate_data()

Traceback (most recent call last):
  File "/opt/miniconda3/envs/XENONnT_2023.07.1/lib/python3.9/pdb.py", line 1726, in main
    pdb._runscript(mainpyfile)
  File "/opt/miniconda3/envs/XENONnT_2023.07.1/lib/python3.9/pdb.py", line 1586, in _runscript
    self.run(statement)
  File "/opt/miniconda3/envs/XENONnT_2023.07.1/lib/python3.9/bdb.py", line 580, in run
    exec(cmd, globals, locals)
  File "<string>", line 1, in <module>
  File "/home/xudc/tt.py", line 1, in <module>
    from alea.examples import gaussian_model
  File "/home/xudc/alea/alea/statistical_model.py", line 125, in generate_data
    return self._generate_data(**generate_values)
  File "/home/xudc/alea/alea/examples/gaussian_model.py", line 27, in _generate_data
    hat_mu = stats.norm(loc=mu, scale=sigma).rvs()
  File "/opt/miniconda3/envs/XENONnT_2023.07.1/lib/python3.9/site-packages/scipy/stats/_distn_infrastructure.py", line 468, in rvs
    return self.dist.rvs(*self.args, **kwds)
  File "/opt/miniconda3/envs/XENONnT_2023.07.1/lib/python3.9/site-packages/scipy/stats/_distn_infrastructure.py", line 1029, in rvs
    cond = logical_and(self._argcheck(*args), (scale >= 0))
TypeError: '>=' not supported between instances of 'NoneType' and 'int'

I think it is better to check the needed arguments(signatures) of StatisticalModel._generate_data and show an error when the needed pars is None. What do you think? Will this violate the degrees of freedom of _generate_data? My concern here is that there might be parameters that are arguments of StatisticalModel._generate_data but actually not used. So it is not accurate to judge which parameters are 'needed' only given arguments of StatisticalModel._generate_data.

I also think that it is better to handle all parameters:

who is needed in which function
raise an error when lack of pars
...

just in Parameters class. Because in our context once the likelihood is defined, the parameters needed for each function are defined. But of course, we can leave some freedom for debugging.

Hi, @dachengx do you mean that the error occurs also when calling generate_data?
We cannot do code introspection to get the signature, sadly, since we need **kwargs to be the signature for the purposes of the xenon+blueice-from-config likelihood

Is it better, you think, to check this in the parameters call function?

Hi, @dachengx do you mean that the error occurs also when calling generate_data? We cannot do code introspection to get the signature, sadly, since we need **kwargs to be the signature for the purposes of the xenon+blueice-from-config likelihood

Do you mean this fucntion? https://github.com/XENONnT/alea/blob/257ab91ac09293a2fc5514560f80c13ac34d5369/alea/blueice_extended_model.py#L175-L183

Looks great. I will merge it.


Error is not thrown if token that is provided is invalid

If an invalid feathers-jwt token exists in the localStorage of a browser and app.authenticate() is called, the Promise on the client side always resolves, whether or not the token was valid on the server.
I'm assuming that this is because an error isn't thrown on the server side when authentication fails via the JWT authentication strategy.
This has obvious implications on the client side, because now error handling has to be done via .then as opposed to .catch.
Again, the Promise always ends up resolving whether or not the JWT token that is passed to the server is valid.

I think we should move this issue to https://github.com/feathersjs/feathers-authentication-client. Either way, you are right, an invalid JWT shouldn't resolve. I'd have to double check why that is.

This shouldn't be happening. I will look into this a bit but @elfey it would help a ton if you can post a reproducable example or a PR with a breaking test. We do have tests to test this case already that are passing. https://github.com/feathersjs/feathers-authentication-client/blob/master/test/integration/rest.test.js#L88-L132

Will do, I'll get an example in here within the next few days.

After speaking with Marshall and doing some more thorough debugging, it looks like this actually isn't a problem of feathers; it's a problem specific to my project.


Log file level exception

If user specifies invalid log file level, v1.0.10 catches it but attempts to write the error to the log which has not yet been successfully created thus causing an additional exception for invalid object.

Fixed in build 1.0.11.


Kibana Improvement

This included the following improvements:

Support for Config Kibana via ConfigMaps
Prevent Kibana Failure by Adding Liveness/Readiness

@pires just squash the commits, and remove livenessProbe
please review again, and let me know if there's anything missing

Closed by https://github.com/pires/kubernetes-elasticsearch-cluster/commit/2f432d3666db73dfca86435bae71bde707683ab4! Thank you very much for your contribution.


Revert commit e74a1ec that remove CodeReview

I am asking to revert commit e74a1ec
I rewrote the installation doc, and it should be easily installable on Linux, where Python and a C compiler is nearly available by default.
However, I need help on Windows and OSX to write an installation procedure or make an installer.
https://github.com/FabriceSalvaire/CodeReview

hey @FabriceSalvaire . feel free to submit a PR adding the GUI client to the list :)
There are some instructions here: https://github.com/git/git-scm.com#adding-new-gui
if you still need some help let us know so that we can help you on that

are you interested in doing it @FabriceSalvaire ?


fix: update local runner for sf functions

What does this PR do?
Bumps the version of @heroku/functions-core to 0.3.1 and updates the local functions runner to be compatible with library changes.
What issues does this PR fix or reference?
https://github.com/heroku/sf-functions-core/pull/45, @W-10819415@

@colincasey I ran into the same issue with running the test suite. I had to sign out of Circle then sign back in and auth salesforcecli org again. Then push another commit to prompt the tests to run.

thanks for the guidance @RasPhilCo.  logging back into CircleCI did the trick


Review request for Microsoft.Security to add version stable/2024-08-01

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Hey @mentat9,
We read your comments and fixed/commented on them.

Please fix the LintDiff error PutRequestResponseSchemeArm
You can ignore the BodyTopLevelProperties that are tagged for value and nextLink properties as they are due to a bug in the tool

@ramoka178 - please approve & merge

@ramoka178 can you please approve & merge?

/pr RequestMerge


Rename color constants

Fix naming of certain constants and color name strings in C++ and C#.
Advise on how to parse constants in UPPERCASE_NAMING style for gdscript Color Constants.

Advise on how to parse constants in UPPERCASE_NAMING style for gdscript Color Constants.

Color constants are registered here:
https://github.com/godotengine/godot/blob/ec678c5e94ac1c91c099c15fabc398e80ede7bfe/core/variant_call.cpp#L2334-L2337
In order for the color name to be uppercase, the second argument to add_variant_constant (currently color->key()) should be an uppercase string.
To do this you might (a) modify _populate_colors() to use upper-case color names or (b) use String::to_upper to transform the color name.

I just added the entire bunch of names as new entries. Old code needn't break.

However this doesn't follow the consistency that @aaronfranke wanted to provide (Colors.Red in C# and Color.RED in GDScript).

I don't see why Colors.RED or for that matter all of these constants can't be added in as a plugin instead

They could be, but this is a very simple feature so it's easy enough to just have it built-in, and arguably commonly used (the colors are used less othen than the constants like Vector2.UP, but they are both sets of standardized constants so we should treat them the same).
When it comes to Color.RED vs Colors.RED, the former isn't terrible, but IMO with the sheer amount of constants it makes sense to separate them. In C# there is also the concern of Color.Red etc obscuring unrelated methods like Color.Color8, and in GDScript these are just defined as global methods, but perhaps they should be moved to Color in GDScript too (and if so, that's a strong case for Colors.RED).

When it comes to Color.RED vs Colors.RED, the former isn't terrible, but IMO with the sheer amount of constants it makes sense to separate them. In C# there is also the concern of Color.Red etc obscuring unrelated methods like Color.Color8, and in GDScript these are just defined as global methods, but perhaps they should be moved to Color in GDScript too (and if so, that's a strong case for Colors.RED).

Would this be done by adding another Variant Type in variant_call.cpp?

Instead of duplicating the color name list, wouldn't it be easier to change this:
_VariantCall::add_variant_constant(Variant::COLOR, color->key(), color->value());

to this:
_VariantCall::add_variant_constant(Variant::COLOR, color->key().to_upper(), color->value());

Instead of duplicating the color name list, wouldn't it be easier to change this:
_VariantCall::add_variant_constant(Variant::COLOR, color->key(), color->value());

to this:
_VariantCall::add_variant_constant(Variant::COLOR, color->key().to_upper(), color->value());

No, it would miss out on the added underscores that denote spacing.

As for the constants, I'm not sure of the best way to implement them. Take a look at the PR that added them. If you can't figure something out, I'll try myself later.

I believe we'll need to remove ColorN and introduce a Colors built-in dictionary/variant type which supports the in operator, if needed.

As for the constants, I'm not sure of the best way to implement them. Take a look at the PR that added them. If you can't figure something out, I'll try myself later.

Do you mean adding a new paceholder for the Color constants or just updating them in the editor? The latter is done by
https://github.com/godotengine/godot/blob/ec678c5e94ac1c91c099c15fabc398e80ede7bfe/core/variant_call.cpp#L2334-L2337

Any updates on this?

Overall, looks good to me.

I think if we do attempt to do Colors.RED we'll need a new Variant class to hold the constants, or we could end up making the constants global (not the intended effect of this PR, and although following the design of the Error codes and related constants, in sharp contrast with the C# implementation).

Should we move forward this then?

You forgot about C#'s ColorN. The behavior should match GDScript's ColorN. I'm also concerned about ColorN requiring underscores, since that would mean "seagreen" doesn't work anymore which is fine I guess, but also "SeaGreen" wouldn't work either which isn't good because that's the property name in C# so it should work.
Perhaps we would need some kind of mapping system so that ColorN strips out underscores and looks for either SEAGREEN or seagreen in the dictionary, but the exposed constants can have slightly different names like SEA_GREEN.

ColorN uses Color::named underneath. I'll need to change the normalisation rule back to the previous one for this to work.

Why don't we use this to disambiguate spelling errors in Color names?
https://github.com/godotengine/godot/blob/a6916d1f179f760f015f385c01729d205af97abe/core/ustring.cpp#L2734

@bojidar-bg @aaronfranke any way to let the linker know that my new function is being used and needed to be linked?

I kinda believe that this implementation can make its way to 3.2.

@Vivraan This pull request breaks backwards compatibility since it renames color constants. Old scripts that rely on those constants will cease to work until they've been fixed. Therefore, we won't cherry-pick this pull request to the 3.2 branch if it's merged in master.

Yeah I missed that when I made the comment. I'm fine with it going to 4.0.
However, one of these commits consists of using both uppercase and lowercase constants, and can be adopted into 3.2 if needed.

Every build test apart from Static and Windows is failing because they're treating _to_uppercase_name as unused where it is called in variant_call.cpp. Could someone please look into this?

Every build test apart from Static and Windows is failing because they're treating _to_uppercase_name as unused where it is called in variant_call.cpp. Could someone please look into this?

I guess it fails because you made it static, so it's copied into color.cpp, but when compiling color.cpp it's unused.

That solves the linker errors.
Now, the last thorn:
DEEP_SK_Y_BLUE = Color( 0, 0.75, 1, 1 )

is the only name which isn't coming up properly - should I add this to the edge cases list?

Can we move forward this as it is right now?

@Vivraan Be patient, some PRs sit waiting for years. I haven't been at my main computer for the past 2 weeks, and my current one can't run Vulkan, so I haven't been able to test this yet or do a proper review.

Indeed, this is a cosmetic change, it can wait.

Requesting review.

@Vivraan Sorry for the delay, I forgot about this. Anyway, this needs to be rebased on the latest master before it can be reviewed.

Should I reintroduce the old names for 3.2 compat? I guess a commit with that can go into the 3.2 branch but one without it can go into 4.0 only.

@Vivraan Sorry for the delay, I forgot about this. Anyway, this needs to be rebased on the latest master before it can be reviewed.

I'm confused about the files I'm modifying not being there in the master branch. Could you confirm if they have been removed or not?

@reduz could you review this? Seems you were the author of the moving change.

As for the constants, I'm not sure of the best way to implement them. Take a look at the PR that added them. If you can't figure something out, I'll try myself later.

I believe @reduz has addressed this in the latest changes relating to code reorganisation.

Looks like my transformation code is wasteful. I'll need to provide the names directly in color_names.inc, or wherever the colour names are registered.

@Vivraan This can't be done to 3.2 because it breaks compatibility.
What you have here is a merge, but you need a rebase (and ideally squash). See this article for more information.

@Vivraan This can't be done to 3.2 because it breaks compatibility.
What you have here is a merge, but you need a rebase and ideally squash, where it says "Commits 29" it should say "Commits 1". See this article for more information.

It looks like this because the files I was trying to change have been (re)moved. Atm I'm waiting for Reduz to review this change, since it looks like the way these constants are defined or introduced has been completely redone.

@Vivraan I opened alternative PR #45144 and listed you as a co-author.

@Vivraan I opened alternative PR #45144 and listed you as a co-author.

@Vivraan I opened alternative PR #45144 and listed you as a co-author.

Amazing! I'm glad the named corrections have been updated to the latest API!
Are the C# colours handled in the same way as GDScript or are they named in PascalCase?

@Vivraan I opened alternative PR #45144 and listed you as a co-author.

Amazing! I'm glad the named corrections have been updated to the latest API!
Are the C# colours handled in the same way as GDScript or are they named in PascalCase?

Are the C# colours handled in the same way as GDScript or are they named in PascalCase?

GDScript: Color.LIGHT_SEA_GREEN
C#: Colors.LightSeaGreen

Are the C# colours handled in the same way as GDScript or are they named in PascalCase?

GDScript: Color.LIGHT_SEA_GREEN
C#: Colors.LightSeaGreen

For the record: #45144, which replaces this PR, has been merged.


Sort buildings and upgrades by PP

This pull request adds the ability to sort buildings and upgrades based on PP.
The buildings part has been taken from #219, but with changes to solve the conflicts.
Also note issue #151, which is about the sorting of buildings.

Thanks, I feel really bad for taking so long =(

I like this! Any idea when it might get merged?

No idea really, just be patient with me, sorry =(

Will this be merged soon? It has been several months now :)

@DanielNoord I reviewed the code and it looks good, should I go ahead and merge it?


Translation in Russian language

Hello Phillip!
It's me Alexey again. I understand a little bit about your project ecosystem and translated first post in new branch russian, i decided to help you also with all back stuff like some markdown elements and smth else. I followed suit japan translation and english version and in base of those make russian one.
I hope i chose the right decision.
With respect, Alexey.

Awesome, thanks a lot! I'll try to find someone that can review the translation through our next Rust OSDev newsletter.
Some small things that still need to be done to add the new language to our static site generator:

Add the new ru language here: https://github.com/phil-opp/blog_os/blob/c2d66453926e86f36d61b58e552ce00cc6e640cb/blog/config.toml#L10-L15
Add a new translations.ru section that translates the rest of the site into Russian. You need to translate these strings: https://github.com/phil-opp/blog_os/blob/c2d66453926e86f36d61b58e552ce00cc6e640cb/blog/config.toml#L36-L47 (see the translation table entries for the other languages for examples).

Let me know if you need help with these steps.

Now, i think everything should work.

Looks like it works now :+1: . Don't worry about the zola check error, that's unrelated to this PR.

Okay, i'm happy 💯 . I hope soon i will translate second post. Thank you for help. Have a nice day!

Thanks, you too!

I finished second post and extra post: "Red Zone" "Disabling SIMD"

Let's test

@phil-opp Should I translate comments in code examples?

@SnejUgal  Я просмотрел все ревью, и с теми, которые я не принял, с ними сейчас поработаю отдельно и сделаю сейчас еще один коммит со всеми изменениями, которые указаны тобой. чекнишь их тогда

Ok, nice.
Can we test it for building now?
And should i translate comments in code examples?

Thanks a lot for all your work @MrZloHex! And thanks to @SnejUgal and @vdjagilev for reviewing!
I just tested it locally with the Zola static site generator and there are still two boilerplate files missing:

A content/edition-2/posts/_index.ru.md file that describes the templates and ordering that should be used. You can use the same content as the _index.md file in the same folder (no need to translate anything), i.e.:+++
title = "Posts"
sort_by = "weight"
insert_anchor_links = "left"
render = false
page_template = "edition-2/page.html"
+++

A content/_index.ru.md file with the translated frontpage text. The English file looks like this:+++
template = "edition-2/index.html"
+++

Writing an OS in Rust

This blog series creates a small operating system in the [Rust programming language](https://www.rust-lang.org/). Each post is a small tutorial and includes all needed code, so you can follow along if you like. The source code is also available in the corresponding [Github repository](https://github.com/phil-opp/blog_os).

Latest post:

Regarding translating the comments in code examples: I'm fine with both variants (translating them or keeping them in English), so feel free to decide this yourself. The actual code (e.g. variable and function names) should stay in English though to be compatible with the code in the repo.

Thanks for the update, looks good now! Please let me know when the reviews are finished and it's ready for merging.

@vdjagilev @SnejUgal Are reviews finished?

That's all?

Well, I've reviewed everything, so far so good; there's nothing I can add to my previous reviews.

lgtm

@phil-opp I think we can merge now!

Awesome, thanks a lot everyone!

Published at https://os.phil-opp.com/ru/


Update FetchRequest

Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I have resolved any merge conflicts.
[x] I have followed the coding style, and reviewed the contributing guidelines.

This fixes issue #___.
What's in this pull request?
Uses a cleaner FetchRequest.

[Current coverage][cc-pull] is 90.11%

Merging [#86][cc-pull] into [develop][cc-base-branch] will increase coverage by 0.02%

@@            develop        #86   diff @@
==========================================
  Files            13         13
  Lines           434        435     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            391        392     +1
  Misses           43         43
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [5413b36...1bf6f9e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/jessesquires/JSQCoreDataKit/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/jessesquires/JSQCoreDataKit/compare/5413b36fa9bd935d40ae5c4e58721ccd50f434de...1bf6f9ef2deab17d360930db54881b076388bd7d
[cc-pull]: https://codecov.io/gh/jessesquires/JSQCoreDataKit/pull/86?src=pr

Thanks @MaxHasADHD ! 😄
This isn't quite the direction that I think we should take the library.

I think FetchRequest should continue to be initialized with an entity description. Initializing a fetch request with a context is really awkward considering we have context.fetch(request: r)

I would like to see improvements around initializing an entity description. Using "\(self.self)" is close, but not quite there. I'd like to use the approaches that Daniel outlines here: https://realm.io/news/tryswift-daniel-eggert-modern-core-data/

I've opened #87 to track this. 😊

I'm watching the talk right now! I'm currently reading his book as well. Just wondering though, would "\(self.self)" ever be wrong? Or just maybe in the future it could change to not be the entities name like I expect?

Or just maybe in the future it could change to not be the entities name like I expect?

Exactly.
With Daniel's approach, we can have the classes provide an entityName.
Then, we might be able to provide a default implementation that returns "\(self.self)" (or similar). This way, we could provide good defaults, but allow clients to override. 😄

I like that idea! I'm going to implement this into my project :) Thanks

We'll provide more of these kinds of things in this library soon 😊

safer to use "\(self.dynamicType.self)" also get rids of the module name and will leave you with the class name which is in most case is the entity name


genpy: 0.5.10-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository genpy to 0.5.10-0:

upstream repository: git@github.com:ros/genpy.git
release repository: https://github.com/ros-gbp/genpy-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.21
previous version for package: 0.5.9-0

genpy
* add __ne__ magic method (#62 <https://github.com/ros/genpy/pull/62>)

Waiting for Indigo rebuild to finish before merging Jade PRs.


Error posting comment

Steps:

Clicked a question to answer on Jamaican Psalm 100
Highlighted some text
Entered a comment
Clicked "Done"
My comment vanished, and the following red dialog appeared:
Oh. Error.
RPC Error
Click for details
Server Status Code 500
Report this bug to the developers
Please copy error above and include screenshot

closed as server issue now resolved.


problem retreiving thumb stored on kodi file system

Kodi panel cannot retreive artwork when it is stored on kodi filesystem. (inside storage)
I used kodi 18.9 on libreelec
Eg
"VideoPlayer.Cover":"/storage/backup/xbmc_videodb_2017-05-20/movies/Django_Unchained_2012-poster.jpg"}}will not display
but "VideoPlayer.Cover":"https://artworks.thetvdb.com/banners/series/253573/episodes/6005a5f5959c7.jpg"} will display fine
<EMAIL_ADDRESS>will also display fine

Is kodi_panel running on the same host or a different host than Kodi?  The filesystem path in the first example (/storage/backup/...) is, of course, not naturally accessible over the network.  Some step is necessary to make it accessible, and this section of code
https://github.com/mattblovell/kodi_panel/blob/6b0fe6b3126e46a0285c3afb54437eeeadbbd485/kodi_panel_display.py#L1151-L1159
is the Files.PrepareDownload JSON-RPC call that get_artwork() tries.
There are debug print() statements within get_artwork(), including one at the end of the above excerpt.  Please uncomment all of those, restart kodi_panel, and provide the output.

Is kodi_panel running on the same host or a different host than Kodi?  The filesystem path in the first example (/storage/backup/...) is, of course, not naturally accessible over the network.  Some step is necessary to make it accessible, and this section of code
https://github.com/mattblovell/kodi_panel/blob/6b0fe6b3126e46a0285c3afb54437eeeadbbd485/kodi_panel_display.py#L1151-L1159
is the Files.PrepareDownload JSON-RPC call that get_artwork() tries.
There are debug print() statements within get_artwork(), including one at the end of the above excerpt.  Please uncomment all of those, restart kodi_panel, and provide the output.

With the print() statements uncommented, this is the output for music playback from a USB drive (newlines added):
image_path :  /var/media/Music/iTunes/Enya/A Day Without Rain/Folder.jpg
Prepare Response:  {"id": 5, "jsonrpc": "2.0",
  "result": {"details":
   {"path": "vfs/%2fvar%2fmedia%2fMusic%2fiTunes%2fEnya%2fA%20Day%20Without%20Rain%2fFolder.jpg"},
    "mode": "redirect", "protocol": "http"}}

That's the closest I can get with the current setup of my media library.  The above does work.
Note that the filesystem source for artwork must be a path that Kodi is willing to share.  For the AirPlay cover art, for instance, I was stymied retrieving art over the network until I added special://temp to the list of media sources.  Until I made that addition, the attempt at downloading never succeeded.  The Files.PrepareDownload JSON-RPC call would behave perfectly normally, but the final retrieval URL never worked!  My Kodi forum post on that topic:
Airplay thumbnail and JSON-RPC
https://forum.kodi.tv/showthread.php?tid=359040
I don't know the status of /storage/backup.  Is that a standard media source for Kodi?

With the print() statements uncommented, this is the output for music playback from a USB drive (newlines added):
image_path :  /var/media/Music/iTunes/Enya/A Day Without Rain/Folder.jpg
Prepare Response:  {"id": 5, "jsonrpc": "2.0",
  "result": {"details":
   {"path": "vfs/%2fvar%2fmedia%2fMusic%2fiTunes%2fEnya%2fA%20Day%20Without%20Rain%2fFolder.jpg"},
    "mode": "redirect", "protocol": "http"}}

That's the closest I can get with the current setup of my media library.  The above does work.
Note that the filesystem source for artwork must be a path that Kodi is willing to share.  For the AirPlay cover art, for instance, I was stymied retrieving art over the network until I added special://temp to the list of media sources.  Until I made that addition, the attempt at downloading never succeeded.  The Files.PrepareDownload JSON-RPC call would behave perfectly normally, but the final retrieval URL never worked!  My Kodi forum post on that topic:
Airplay thumbnail and JSON-RPC
https://forum.kodi.tv/showthread.php?tid=359040
I don't know the status of /storage/backup.  Is that a standard media source for Kodi?

Augmenting my post above...
Using the returned path in the response above to form the URL
http://<IP_ADDRESS>:8080/vfs/%2fvar%2fmedia%2fMusic%2fiTunes%2fEnya%2fA%20Day%20Without%20Rain%2fFolder.jpg
works to retrieve the cover art from the USB drive for a normal web browser.  If you capture the PrepareDownload response for your file, you can try the same.  If the web browser isn't able to retrieve the image, the problem is on the Kodi side of things.

Augmenting my post above...
Using the returned path in the response above to form the URL
http://<IP_ADDRESS>:8080/vfs/%2fvar%2fmedia%2fMusic%2fiTunes%2fEnya%2fA%20Day%20Without%20Rain%2fFolder.jpg
works to retrieve the cover art from the USB drive for a normal web browser.  If you capture the PrepareDownload response for your file, you can try the same.  If the web browser isn't able to retrieve the image, the problem is on the Kodi side of things.

I use a remote kodi (kodi with libreelec 9.2.5) and kodi panel on remote rpi with pi is (buster)
I have the folowing output for the debug
2021-01-31 08:34:01.870462 Starting
2021-01-31 08:34:02.006816 Trying ping...
2021-01-31 08:34:02.021038 Connected with Kodi.  Entering update_display() loop.
Response:  {"id": 5, "jsonrpc": "2.0", "result": {"details": {"path": "vfs/%2fst                                                                                orage%2fbackup%2fxbmc_videodb_2017-05-20%2fmovies%2fDjango_Unchained_2012-poster                                                                                .jpg"}, "mode": "redirect", "protocol": "http"}}

The urls do not work:
http://<IP_ADDRESS>/storage/backup/xbmc_videodb_2017-05-20/movies/Django_Unchained_2012-poster.jpg or http://<IP_ADDRESS>/vfs/%2fstorage%2fbackup%2fxbmc_videodb_2017-05-20%2fmovies%2fDjango_Unchained_2012-poster.jpg or http://<IP_ADDRESS>/%2fstorage%2fbackup%2fxbmc_videodb_2017-05-20%2fmovies%2fDjango_Unchained_2012-poster.jpg
I then added /storage to my kodi source  (in the video section but I am not sure it matters) and everything work (above URLS and retreiveing in kodi panel
Resulting video section sources.xml file in Userdata:
- <source>
  <name>storage</name>
  <path pathversion="1">/storage/</path>
  <allowsharing>true</allowsharing>
  </source>

In conclusion: for thumb stored on kodi filesystem , one need to add a source in kodi to make this file system accesible via the http method
In  my case (Libreelec) I added /storage as thumb may be available in other folder than /storage/Backup
Normaly on libreelec thumbs should be stored and retreived in /storage/.kodi/userdata/Thumbnails/ but my kodi setup is pretty old and I have made backup/migration form openelec so maybe is is because of that thumbs are stored in incorrect folder.
@mattblovell  I believe this topic should be mentionned in the documentation.
So I do not close it even if there is no issue with kodi_panel itself.
Feel free to close it if you think it is better.

I use a remote kodi (kodi with libreelec 9.2.5) and kodi panel on remote rpi with pi is (buster)
I have the folowing output for the debug
2021-01-31 08:34:01.870462 Starting
2021-01-31 08:34:02.006816 Trying ping...
2021-01-31 08:34:02.021038 Connected with Kodi.  Entering update_display() loop.
Response:  {"id": 5, "jsonrpc": "2.0", "result": {"details": {"path": "vfs/%2fst                                                                                orage%2fbackup%2fxbmc_videodb_2017-05-20%2fmovies%2fDjango_Unchained_2012-poster                                                                                .jpg"}, "mode": "redirect", "protocol": "http"}}

The urls do not work:
http://<IP_ADDRESS>/storage/backup/xbmc_videodb_2017-05-20/movies/Django_Unchained_2012-poster.jpg or http://<IP_ADDRESS>/vfs/%2fstorage%2fbackup%2fxbmc_videodb_2017-05-20%2fmovies%2fDjango_Unchained_2012-poster.jpg or http://<IP_ADDRESS>/%2fstorage%2fbackup%2fxbmc_videodb_2017-05-20%2fmovies%2fDjango_Unchained_2012-poster.jpg
I then added /storage to my kodi source  (in the video section but I am not sure it matters) and everything work (above URLS and retreiveing in kodi panel
Resulting video section sources.xml file in Userdata:
- <source>
  <name>storage</name>
  <path pathversion="1">/storage/</path>
  <allowsharing>true</allowsharing>
  </source>

In conclusion: for thumb stored on kodi filesystem , one need to add a source in kodi to make this file system accesible via the http method
In  my case (Libreelec) I added /storage as thumb may be available in other folder than /storage/Backup
Normaly on libreelec thumbs should be stored and retreived in /storage/.kodi/userdata/Thumbnails/ but my kodi setup is pretty old and I have made backup/migration form openelec so maybe is is because of that thumbs are stored in incorrect folder.
@mattblovell  I believe this topic should be mentionned in the documentation.
So I do not close it even if there is no issue with kodi_panel itself.
Feel free to close it if you think it is better.

I added a new "Kodi Setup" section to README.rst.  Closing issue.

I added a new "Kodi Setup" section to README.rst.  Closing issue.


Prevent HoloLens from going to sleep

Prevent HoloLens from going to sleep

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae1ab644-ee7d-3dec-cd0f-cbb1e4d8b6ac
Version Independent ID: 97eecc36-8e2e-d4c7-1ecb-948e0846bda5
Content: Device Portal core API reference - UWP app developer
Content Source: windows-apps-src/debug-test-perf/device-portal-api-core.md
Product: windows
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

Hi @kknsy -- please let us know if you have some specific feedback on our Windows developer docs. Thank you!


✅ Gmail xmpp was dismissed, use jabber

I think this needs to be backported on 3.18.x and 3.14.x too

I think this needs to be backported on 3.18.x and 3.14.x too

Oh yeah, I'll backport it, thanks


Int64 idx [pr]

~index op will have a max value, we check if that exceeds int32 and if so do the upcast. Upcast is done by just rendering a dtype of long in the code.~
~There's an edge case with symbolic. Because the max end of Variable is inclusive, but the kernel gidx is exclusive, the calculated max value by shapetracker is bigger than the shape, in the tests I subtracted it by one in the tests.~
~Also webgpu has no int64, so it just renders int32 and upcast becomes a no-op~
Update:
The strategy is to  pre-check all Ops.VIEW in the AST to see if any may overflow
Upcast is done on the IndexContext and the returned value of .to_indexed_uop because they render using int by default.
Checking the overflow require first folding all the symbolic (in case some can be simplified before rendering), then checking recursively in the tree (in case some intermediate overflows)
Added a invalid_dtype for renderer. Upon rendering if Ops.INDEX's src has the unsupported int64, raise a runtime error

this looks very complex, can it be simpler? what's wrong with the old approach
also don't test based on custom r, e functions, it's hard to maintain

the old approach (upcast in to_index_op) could result in partial upcasting when only 1 Ops.VIEW overflows. But I'll revisit and try to simplify things

Turns out I shouldn't be replacing all idx with long, but should instead do an explicit cast when it actually exceeds limit. This should be on the right track, will look for a better way to test this instead of hard coding UOps


Fix boost::function streaming error

@raffienficiaud The PR for your patch

Thank you @mborland . I just pushed a tiny warning removal.


Update bash script for Mac / Unix

Update bash script for Mac / Unix

Hi @pythonmagic thanks for the PR.
First, to clarify everything, is this in addition to #216?  Or should we close #216?

i can close #216 and we can use #219 for update , sorry for confusion.

@pythonmagic can you PLEASE stop creating new pull requests?
Here's how it works:

Create a new branch.
Make all changes on that branch.
Submit the PR from that branch.
Later, if you push new changes in the branch, these automatically update the PR here.

Try it, it works  😸

@StevenBlack I using this simple code:
#!/usr/bin/env bash

cmd_run() {
    ${TERM} -e '/usr/bin/python updateHostsFile.py -a --replace --flush-dns-cache'
}

for TERM in konsole gnome-terminal lxterminal mate-terminal; do
    if [ -f /usr/bin/${TERM} ] ; then cmd_run ; fi
done

I using KDE Plasma @ Manjaro, so file launched from Dolphin File Browser will run in new Konsole window and it will be closing after end job. KISS

I'm not a Mac/Unix person, but it seems to me this PR has been here since last year and the last comment from Steven was less than positively reinforcing this to get approved. I think the changes proposed in this may have already been worked through by other means, anyway, but I can't say that for sure. Can this be closed?


fetchFile step

Add step fetchFile to fetch file from remote URL. supported protocols: http, https, ftp and sftp. Also supported http basic auth, ftp and sftp authentication.
Example:
steps:
  - name: pypyr.steps.fetchfile
    comment: fetch file from URL and save.
    in:
      fetchFile:
          url: https://www.example.com/files/file.tar.gz
          path: /home/user/Downloads

wow, thanks so much for this @mofm! This looks like a very nifty useful step. 🎉
You're very right that pypyr absolutely needs something like this - I currently use curl or wget etc. with pypyr.steps.cmd for this sort of thing, but it's not ideal. So you've spotted exactly a good use case to fill 🙌 !
As it stands, though, and I hate to be the party pooper, but I have to pump the brakes a bit here.
I'm sure the step as it stands works great for your personal use-case, but http/s especially is a complicated topic and I want to be sure that we get it architecturally right for everyone else too - partly to be sure that it is extensible enough as a foundation that we can build more cool things (#55) on top of it in the future, and also partly because I take pypyr semver pretty seriously and I try to maintain backwards compatibility as much as possible - which means that casually introducing something today leads to maintenance headaches in the future if it needs re-working to make other new things work.
Which is not to say we shouldn't add new things. I would just like to take a careful think about future use-cases and how it fits into the over-all ecosystem before rushing in a complicated new feature with its own set of dependencies. (You can see that I do this to myself also - see the ADRs for the process of evaluating options for architecturally significant decisions docs/adr.
pypyr maintains 100% test coverage, so this code would also need to be unit-tested thoroughly - which is a significant amount of work in itself gauging by the quick review I did (there's a lot of conditional & looping logic in there, conditional imports etc.) But please DON'T start with a lot of work doing unit tests on it as it is now, because I think the code itself probably could do with a pretty big refactor to make it fit as a foundation into the future path of pypyr.
So until my thoughts are clear on the subject, I don't want to mess you around and waste your time by pointing you in one direction and then another if it turns out I didn't think it through carefully enough.
I'm not exactly clear myself on where this should go yet, and I would love to hear your thoughts since you have the experience of doing this step already, so please feel free to educate me, if you would!

Did you have a particular reason for using stdlib httpclient rather than stdlib urllib.request? The reason I ask is that urllib wraps up a lot of the functionality that you had to code by hand instead (e.g 300 redirects). . . and also has some others that your stripped down "essentials only" implementation doesn't (proxies, cookies, data urls, 401 auth required, ssl context for certs, custom headers, checking download against content-length header, "localhost" special name etc.).
Rather than have one big monster class doing everything, I might well think of splitting it into modules pypyr.http and pypyr.ftp instead - the underlying functional calls are different enough that I'm not too sure we'd gain much by trying to put it all behind the same interface. (Also, in retrospect, I'm not too fond of the utils namespace - this was the result of me just looking for somewhere to put "random" things in the past, but now It think I prob should've tried to keep the namespace hierarchy flatter.)
Similarly, rather than one fetchfile step that tries to do everything, maybe have pypyr.steps.httpget (for generalised GET requests, and an option to save result to file or just directly to context) and pypyr.steps.ftpget or ftpdownload or similar. Part of me thinking this is then we can have some regularity if you have pypyr.steps.ftpdownload vs pypyr.steps.ftpupload, and pypyr.steps.httpget vs pypyr.steps.httppost vs pypyr.steps.httpput etc. Or maybe in the case of http you just need one pypyr.steps.http step with an input arg method.

what do you think?
I hope this is not discouraging - I don't mean to be! Thanks again for all your work, I really appreciate it & it is an exciting step in the right direction! This does look like very nifty, and I'll happily use & test it myself on my private pipelines until we've hardened it enough to become part of the pypyr core!

Hi @yaythomas ,
Thank you for your kindness.

I chose to use the httplib(python3 - http.client) module because I didn't need complex functions. Also urllib uses it to handle URLs that use HTTP and HTTPS. [1]
May be possible. But I prefer to focus on fetching files rather than focusing on specific protocols. "fetchFile step" is already fetching  from generally used protocols. (it works like this on similar tools)
i think it would be more complicated to parse it into even smaller pieces. however, a separate modular structure may be considered for specific protocol operations.

I totally understand and appreciate your concerns. Maybe a more modular structure can be created. so it can be easier to add a new step and maintenance, backward compatibility. I will think more about it too.
I'm little sick. Sorry I couldn't give a more detailed answer.

Thanks for your clarifications @mofm, this is helpful! I'm busy tidying up a pretty big commit myself (the configencodings branch), and I'll give this my full attention after that is done.
Hope you feel better soon!

Sorry I took a while to get back to you, the queue of pypyr work with config need doing 1st and then re-work of the cmd+shell step (coming soon, currently cleaning up and documenting!) ended up taking priority. So thank you for your patience, I really appreciate it!
I don't fully have answers for all the above, but some of my thoughts are a bit more settled:

I'm likely to go for urllib rather than http.client. Reasons:

I'd rather rely on the well-tested/known "wrapper" functionality in there than have to reimplement it ourselves in pypyr.
The "extra" functionality is going to be useful for more pipeline authors - proxies/cookies/http headers etc. I'd rather not bake a more restrictive use case into pypyr and then have difficulties in the future when trying to extend/enhance the functionality.

I'm likely to split out http vs ftp steps, rather than trying to do it in one big mono-step. Reasons:

When discussing the more "advanced" features (custom headers, cookies etc.) the protocols are sufficiently different that the same inputs won't apply to both, and (from experience) it gets annoying pretty quick from an input validation perspective when the same step is trying to cater for too many mutually exclusive conditions at the same time. I'd rather have each step's input remain intuitive and directly applicable/understandable within the step context.
In the case of ftp, some concept of session/connection and changing directory is prob going to be useful to download/upload multiple files at a time.
Certainly the sftp lib is deffo going to into its own separate project to install as an add-on (similar to pypyr-aws and pypyr-slack). I try hard to keep the pypyr core light - I don't want to make a habit of allowing any/every external dependency in if it's now essential to the core.
Also thinking of async http and making a separate plug-in for that at some point if it's not as easily do-able as it should be with stdlib.

I've not fully thought through what the step breakdown for each should be yet.

But I've a suspicion there's going to be pypyr.steps.http with a verb/action input defaulting to GET:

- name: pypyr.steps.http
  in:
    http:
      verb: POST
      url: https://blah
      headers:
         BLAH_TOKEN: blahvalue
      body:
        key1: value1
      out: ./response.json

FTP is prob going to have an upload vs download step.
Warning this very provisional and likely to change. Feedback welcome!

So given all this, I'm going to close this PR because the amount of re-work that would be necessary is pretty much going to be an entirely fresh change-set. I can't promise how quickly I'm going to get to this, though, aforementioned next release for cmd and then async cmds is next on the roadmap. And then, at last, this - so reast assured it will happen, given time :-)
Thanks for all your effort, I really appreciate it - the step you've coded is truly cool for your use-case & I totally see the point of it! It's just not quite right for the pypyr core because I'm having to think of a broader scope of use-cases/features rather than just putting something "temporary" in that then ends up needing maintenance in itself in the future as it ends up being replaced by something else while keeping backwards compatibility.
If you don't mind, please don't delete your fork/branch, I'm sure your work will be useful to others as a guide/example! (certainly it will be useful to myself while I'm getting through the implementation to see how you solved the various problems!)
Thanks again for contributing to pypyr! I hope we can work together in the future!


Added extension api datasets

1. Why is this change necessary?
To make more datasets available to the admin extension sdk.
2. What does this change do, exactly?
Used the code snippet provided by shopware(product detail) as template to make datasets available for several detail pages.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-22782
Please use this issue to track the state of your pull request.

Can you have a look at the Jest tests? There are some failing tests which need to be fixed before we can merge it

Can you have a look at the Jest tests? There are some failing tests which need to be fixed before we can merge it

@jleifeld which test exactly are you talking about?
I haven't noticed dependencies to any test.

Can you have a look at the Jest tests? There are some failing tests which need to be fixed before we can merge it

@jleifeld which test exactly are you talking about? I haven't noticed dependencies to any test.

You can execute the admin jest tests by following composer command:
composer run admin:unit or (for the watcher) composer run admin:unit:watch
Then you see the failing tests which needs to be fixed or updated

I updated the tests and merged it to the platform.


icons not shown correctly in rst toctree

Describe the bug
context
When I write icons in rst toctree:
..  toctree::
    :caption: Table of content
    :maxdepth: 2
    :titlesonly:

    Quick Start :octicon:`rocket;1em` <quick_start/quick_start>

expectation
I expected icon to occur in the side bar.
bug
But instead the raw text is shown.
Reproduce the bug
write toctree as above
List your environment
myst-parser                   0.18.1
furo                          2022.12.7
pydata-sphinx-theme           0.8.1
sphinx-basic-ng               1.0.0b1
sphinx-book-theme             0.3.3
sphinx-copybutton             0.5.1
sphinx_design                 0.3.0
sphinx-hoverxref              1.3.0
sphinx-notfound-page          0.8.3
sphinx-rtd-theme              1.1.1
sphinxcontrib-applehelp       1.0.2
sphinxcontrib-devhelp         1.0.2
sphinxcontrib-htmlhelp        2.0.0
sphinxcontrib.jquery          3.0.0
sphinxcontrib-jsmath          1.0.1
sphinxcontrib-qthelp          1.0.3
sphinxcontrib-serializinghtml 1.1.5

I just came here to report the same thing. Would be GREAT to get this working.

I suspect that this has the same root cause as #66, namely it is a limitation of sphinx that has been raised upstream (https://github.com/sphinx-doc/sphinx/issues/8068) and milestoned for "some future version" of sphinx (i.e., probably not supported anytime soon)


Find or create vendoring and validation tool for platform components

Is your feature request related to a problem? Please describe.
There are multiple ways of vendoring and validation platform components depending on how its released:

Validate Checksums (e.g. sha256)
Check signatures (e.g. GPG, Cosign)
Check attestations (e.g. stored in Rekor)

There is going to inevitably be overlap depending on the components we use, e.g. Tekton Pipeline and Chains allows you to validate using attestations stored in Rekor.

We have been using @trmiller's vendorme tool