[Doc Feature][Mute and unmute apps in meeting stage][2507281]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
87
39
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit e3a9872:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
88
38
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 8652b19:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
88
38
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit e895e3d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a4e93f5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
88
40
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 37846a5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
90
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 01cb1ec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
90
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b6a84db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
90
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
90
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 5f7c227:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
90
36
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit c864912:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
92
30
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 96e5ec5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
92
29
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit ac1daa5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
92
29
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f59f171:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
93
28
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit de10409:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
93
26
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 8a7c631:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
93
26
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 4a6482a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
93
26
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
93
26
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 4e5c948:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
92
28
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 9daf0bd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
92
28
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit da74b9a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ace2ff1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
92
28
link
:white_check_mark:

msteams-platform/whats-new.md
91
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b9feb02:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update sponsor image URLs in readme

In the rich diff, one can see that some of the images are still broken:

Codeberg returns an error 500 for these.

Thanks for letting me know @Alexander-Wilms, seems like either archiving the website repo, or being at GitHub LFS limits broke these links.
I also updated these to now just use the Bookstack website instead, rather than involving other platforms.

Yes, https://codeberg.org/bookstack/website/media/branch/main/static/images/sponsors/cloudabove.png shows
version https://git-lfs.github.com/spec/v1
oid sha256:8a45011ad86493b0718ee9628947e1ad9363c26c9291122a70956f6494474bb9
size 21923

@Alexander-Wilms Yeah, currently a bit stuck. Don't think I had all LFS data pulled locally, so it's not all on Codeberg yet, but I can't pull from GitHub due to being over the LFS bandwidth limit (which you can't control on a public repo). Waiting for that limit to reset in a few days time :cry:


MultiGet calls onGot with nil item and no error.

https://github.com/rs/rest-layer/blob/48c11e50091e8c988780853a3aaa8af25cf98d42/resource/resource.go#L288.
MultiGet may call onGot with a nil item and nil error. If I adjust all my hooks to not only test for errors, but also for nil items, things work -- but is the current behavior intentional?
I am using latest master and the rest-layer-mongo backend.

BTW, the MultiGet call will also return the nil items in it's list of items.

// If one or more item(s) is not found, their slot in the response is set to nil.

Isn't it that case?

That is in deed the case.
My question is if it's intentional to call the hooks in this case (when the item isn't fond, and there is no error).

Isn't the hook called too in the same condition on a simple Get?

For Geterr is set, so if you do a:
func (hook Hook) OnGot(ctx context.Context, item **resource.Item, err *error) {
	if *err != nil {
		return
	}
	...
}

at the top, you are good (err would be resource.ErrNotFound in the case where the ID isn't found).
For MultiGet, you need to extend the check to:
func (hook Hook) OnGot(ctx context.Context, item **resource.Item, err *error) {
	if *err != nil || *item == nil {
		return
	}
	...
}

Either way, I think it's fine. I am planning to go through all 0.2 labeled documentation, and do a larger update to the README. I will document it as it works now.

Oh I see. Is your suggestion to set the error to resource.ErrNotFound in such case? That’d be fine with me.

This was mainly raised as a question. I don't know what is best, so will leave it as is for now. We can revisit it later if relevant. Documentation for how to write hooks has been update in PR #201 to recommend:
func (hook Hook) OnGot(ctx context.Context, item **resource.Item, err *error) {
	if *err != nil || *item == nil {
		return
	}
	...
}


Documentation: Fixed broken links for images and docs

Hi, the links for images and other docs at https://mesos.apache.org/documentation/latest/ are broken, the problem is doxygen interprets FULL_IMAGE_PATHS in .md files relative to current page, not the parent page.
so what should have been
/documentation/latest/images/architecture3.jpg
becomes
/documentation/latest/architecture/images/architecture3.jpg
when looked from architecture.md page.
The fix simply corrects the relative links so that Doxygen interprets in desired way.
(I'm sorry if I'm doing something wrong with this code review process, this is my first ever pull request)

Closing per request at https://s.apache.org/V8r3


Correctly handle jenkins restart while hosting in Docker

https://www.jenkins.io/blog/2022/05/27/docker-image-new-lifecycle/
If you can see adding safeRestart in URL will not correctly restart Jenkins anymore if main node is hosted in Docker.
This article described the policy and configurations required for restoring the behavior.
Thanks.

https://user-images.githubusercontent.com/28733332/173608278-fa4e923c-1d1a-425a-a7ee-2effede5a172.mov


Feature: Add Open in Gateway

Is your feature request related to a problem? Please describe.
In #1813, the user wants a feature which is showing the downloading progress in the WebUI. However, If users can download through the browser, they can get the download progress they want. So if we can add a new Button called Open in Gateway orOpen in Browser, it will be convenient.
Describe the solution you'd like
Before:

After:

Describe alternatives you've considered
Or Add a Button to help users copy the gateway URL of a file.
Additional context
We can use ipfs config Addresses.Gateway to get Gateway address.

Notes from triage:

right now the Download button uses JS API and a blob:  as a source
fix here is to switch to HTTP link at a local gateway

single file would have /ipfs/{cid}?filename=foo&download=true to ensure proper `content-disposition
a directory – tbd, either /api/v0/ or ?format=tar (whichever is available when this is tackled)

I agree with changing the Download button instead of adding a new action.
About directory downloading,?format=tar needs ipfs/go-ipfs#8234. However, Windows doesn't support tar unarchive. Maybe using zip is a better choice?

Support for tar has been included in Microsoft Windows since Windows 10:
https://techcommunity.microsoft.com/t5/containers/tar-and-curl-come-to-windows/ba-p/382409

@lidel Yes, I just tested it. Windows still doesn't support the *.tar in GUI.

I believe this should be fixed with https://github.com/ipfs/ipfs-webui/pull/1894. Please let us know if you continue to have issues.


Long filename problem with Windows

Hi,
just wanted to understand better how/if Electron apps can be packaged "smarter" to work in a Windows environment. (I don't like Windows, but some PCs in offices and labs use that unfortunately).
The example I tried was similar to https://gist.github.com/jedthehumanoid/a7f8278e0a37d259adca
Where I integrate some node modules for the serial port. After packaging and installing the binary, I saw quite a number of problems related to long filenames.
Feel free to close this issue, since it might lead to a discussion on a meta-level.
Thanks in any case!

It has been a long time headache for Node.js apps on Windows (https://github.com/nodejs/node-v0.x-archive/issues/6960), in Electron you can package your app into asar archive to work around it.


⚠ ClamAV has degraded performance

In ff1fbe4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 248 ms

Resolved: ClamAV performance has improved in c1ed861 after 20 minutes.


Do a "hole in the wall" demo

we, @blq and i, already started and already got a swiming pool - source is currently in hole-in-the-wall.html
How could we improve it ? maybe more realism or more efficient.

Various ideas:

animating the water and the ball
put some shadow, maybe a palm tree to cast shadow.
a sun with a lens flare ?

ok some may be costly from a webgl pov :) especially on phone

fix UV in the pool texture

Yeah, the UVs are just defaults now, not modeled. Either build the inside box manually (as you did in your tests once)  ..or switch to a non-directional texture ;)
Seen many cool water shaders of course. Not my speciality but just some noise ripple with bump would probably look cool?

Here Evan Wallace explains his epic water shader http://madebyevan.com/webgl-water/
<EMAIL_ADDRESS>

Link and close?

The link at the top is dead — could even a simple version of this be put back up? Seems like the sort of example that would really get people excited about marker-based AR, because you can do things with the marker!

@AndresCuervo you are going deep into github issues :) yeah code moves fast
i got them somewhere. there is quite a bit of mess in there. but i could drop it somewhere. please ping me if i forget. please please :)

That I am @jeromeetienne — I'll bug you in a few days on Twitter if I don't see anything — would be cool to put it up on glitch.com so people can see the source more easily & play around with it!

have you already started bugging him? i just sent a tweet hoping he would have forgotten to upload it

https://github.com/jeromeetienne/AR.js/tree/dev/aframe/examples/demo-portal-door is the portal door. this is like the hole-inthewall but vertical :)
Take it while its hot. those kind of demo are moving fast as you can see

Here's a link to the file from the 1.5.1 version, so it'll stick around for longer
And, here's a link to the file hosted on Rawgit's CDN :)

owh thanks

Links are broken again. Can please re-up hole-in-the-wall? Thanks

Yes please, the code of the example at the top would be incredibly useful.
Many thanks.

I dug through the git history for this repo to figure out how it was done: the basic idea is to create the inside box using a material that uses side:THREE.BackSide, and to create a second box (an "invisibility cloak") to hide the parts of the inside box not visible from the top (splice out the top side and use a material with colorWrite:false). There is a simplified example posted at https://stemkoski.github.io/AR-Examples/ .

update the readme with @stemkoski examples. they are very good and helpful. close as obsolete and not needed anymore


upgrade husky to v8

See https://github.com/TerriaJS/terriajs/pull/6408 for details, this is the same just for TerriaMap

One important note for husky v8 is that it requires node 14 or later


Add support for reactions

Discussed in https://github.com/d99kris/nchat/discussions/213
Reporting issue from discussion to track implementation of the feature request.

Support for reactions has been added in above commit. Select a message and press alt-s to add/change/remove reaction for a message. Reactions for messages are displayed below them, similar to mobile messaging apps. Note that color themes (except the default) have been updated to have a slightly different background color for reactions, so it may make sense to apply/copy themes again (or modify ones own accordingly).


MAUI - Sample / Support

I'm not sure if this package is compatible with MAUI.
I tried to use on my android app and couldn't debbug.
Would be nice if we have a sample for MAUI.

This needs new targets to be defined in Microsoft.Datasync.Client - most notably net6.0-android, net6.0-ios, net6.0-maccatalyst and net6.0-windows.  The Android/iOS stuff uses Xamarin.Essentials, so I'll need to write new platform specifiers for that.  Will see what I can do today and tomorrow to do this.

So - for folks wanting to follow along, check out https://github.com/adrianhall/azure-mobile-apps in feat/maui branch - you'll have to build from source.  Right now, the code is done but the build doesn't work.  That is because VS 17.2.2 contains Xamarin reference assemblies and VS 17.3.1 contains MAUI reference assemblies - neither VS version contains both.
Once I've solved that issue, I'll have something that can target both Xamarin and MAUI.   There will be a problem if I can't have both sets of references.  I'll have to basically have a MAUI version and a Xamarin version.  So, fingers crossed I can find a solution.

Merged .NET MAUI Library Support.  That's not to say I think it's ready yet - just that stuff compiles.  Next up is an end-to-end tutorial (based on the Xamarin.Forms one), then I'll see what else needs to be done.

Update on what is required for offline - there is a new SQLite bundle_green library (v2.1.0) that supports MAUI deployments.  I'm going through the change now and will release a 5.0.3 with the update soon.

Released v5.0.3 which has support for MAUI
Tutorial is in editorial right now and will be published on the next cycle.

One thing I haven't done is try out iOS - the Visual Studio stuff for iOS really only works on Mac, so I have to re-do all the tutorials with that in mind.  That will take some time.

@adrianhall thank you!


Implement timeout for server-side web sockets

Constructor parameter.
Should be None (disabled) by default.
If there is no activity from client-side peer for timeout seconds -- terminate the connection.

Write a doc describing why TCP transport has no guarantees for delivering socket disconnection event and why sending client-side pings (by ping frame or explicit message) is crucial for making connection reliable.

implemented in master


Learn New Words

This PR exposes an add API for all platforms, so that users can improve their dictionary over time. Also went ahead and updated some documentation.

[x] Verify on Mac
[x] Verify on Windows (using Hunspell)

Do these adds persist for >1 session on all platforms? Where does Hunspell store the custom dictionary?

@paulcbetts: Using Mac and Windows 8, you're all good. But when using Hunspell, the adds do not persist. Currently this is an Exercise For The User- Hunspell doesn't do anything on its own. Do you think we should manage the custom dictionary in this module?

@CharlieHess We should save it somewhere - I bet Hunspell lets you specify a user dictionary path that they'll maintain

@paulcbetts: Not AFAICT. We can create a new dictionary file and pass that to Hunspell, but it's on us to maintain it.

Thanks for this

Published in 2.2.0


Title cell exapanded should collapse as user clicked on an other Tile cell section

Only one cell should be expandable at a time while other are collasped

I have added a new property to NAExpandableTableController to indicate whether you'd like to enforce only 1 cell being expanded at a time. Just add the following line of code:
expandableTableController.exclusiveExpand = true
Let me know if you have any other issues.

@narciero Thanks, It is working now.


Refactor (split) rule model

Work towards #86 and #227. While this is a draft PR, it might frequently be rebased or otherwise force-pushed, please don't base other code on this yet.

This does the bare minimum of splitting out a chase variant of the rule model, with the adapted versions of Program and Rule from #220, and TryFrom implementations to convert from the canonical rule model.


SunEditor: does not remove newline characters (CR, LF, CRLF)

Describe the bug
I am using the pe:sunEditor component to publish content in my application. Copying and pasting from a Microsoft Word document works fine, but when the document is opened with LibreOffice (https://www.libreoffice.org/download/download/), the SunEditor fails to remove newline characters (CR, LF, CRLF). Could you help me with this issue? I thought about using the onPaste event, but I’m not sure how to implement it with the pe:sunEditor component.
The issue occurs across all browsers, but in Firefox, it happens immediately, while in other browsers it only happens when I submit the form.
I will attach images showing how the text looks after pasting it into the SunEditor.

document libreoffice

SunEditor content that was pasted

content pasted into the primefaces-extensions showcase

SunEditor source code

Reproducer
No response
Expected behavior
No response
PrimeFaces Extensions version
14.0.6
JSF implementation
Mojarra
JSF version
No response
Browser(s)
No response

Thanks for responding so quickly!
I can capture the onpaste event through the Extender functionality. If you can help me with an example, it would be a great help. Thanks!

you just need this example: https://www.primefaces.org/showcase-ext/sections/sunEditor/extender.jsf

Thanks again. I tried to follow the example, but my code didn't work for the onPaste event. Could you point out where I'm going wrong?
function editorExtender() {
        console.log("editor extender!");
        const editor = this;

        editor.onPaste = function (e, cleanData, maxCharCount) {
                console.log("onpaste event detected!");
    };
}

Ahh the extender is for changing the configs before the SunEditor gets created the editor itself doesn't exist yet at this point.   Try this..
<pe:sunEditor id="sunEditor" widgetVar="sunEditor" value="#{basicSunEditorController.html}">
        <f:attribute name="widgetPostConstruct" value="widget.editor.onPaste = function (e, cleanData, maxCharCount) {
                console.log("onpaste event detected!");
    };" />
    </pe:sunEditor>

I just tested the above and it works!

Yes, it worked here too. Thank you very much!


Infer author_name, email, license from knife.rb if it exists when generating a new cookbook.

This will read from cookbook_copyright, cookbook_email, and cookbook_license for config is present.
Please note these are not new config values, and are already defined in the docs.

@chef/client-core can you guys check this out?

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@elliott-davis

Please sign the CLA here.

@elliott-davis I'm closing since we haven't heard from you in a while. If you're still interested but need help with the mixlib stuff, you can create a new request and at-mention me with any questions.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.


Set Up Email Address to use with Mailer

We want ProgBot to send emails to users when they first sign up, when they try to sign up with an email that already exists in our database, etc.
We need an email address for this purpose. We want an email address completely for progbot because its credentials will have to be stored. maybe<EMAIL_ADDRESS>or something

We can do this, but I'm wondering how to set it up for e-mails to go out automatically.  Perhaps we can discuss this in the channel, @sdklos?

update: going to pursue using zapier/actionnetwork integration for sending emails from progbot

update: now going to pursue setting up google mail smtp

update: we have implemented the sendgrid heroku add-on


Pull request instructions

I created a pull request with a small fix, but I don't think it worked (at least I can't see any evidence of it!) Are there any instructions to follow to successfully do this?

I don'tt see the PR. Can you send me a screenshot (make sure you redact any personal info)
Alternatively, email me the content ("ill contact you directly with the info).

 This issue is more focused on having a set of step by step instructions for people who are new to contributing (to MS Projects) on Github

Let's leave the issue open and I'll try to find an expert on PRs to write instructions for me.


Show thumbnail on the left

Hi,
first of all, it's a great library and I really like it.
is there a way how I can show the thumbnail on the left hand side of the notification? Just like with the profile image in a chat application:

@EddyVerbruggen any idea?

up


Current HLK failures on vioscsi

I'm trying to pass the HLK test suite for Windows 10/Server 2016 and have a few failures that seem to be code-related, rather than setup.

Storage Query Property (both Win10 and 2k16): Error is "0 is an invalid value for SerialNumberOffset".  This test doesn't have any parameters.
Static Tools Logo Test (2k16): This requires running of the Static Driver Verifier in Visual Studio, but it fails the "MustFix Defect" rules in storportfindadapter and storportspinlock3.  If I go ahead and install the DVL files on my HLK test machine, the STL test fails, mentioning the "MustFix" failures.
Storage Firmware Update: I imagine this can be made to pass.  What do you put as a firmware file for this test?

In addition, the CHAOS tests fail on both targets for "Reliability" and "Development and Integration", but when I look in the test logs, there are no failures.  I expect this is an HLK problem, not a code problem, so will ask MSFT for clarity.
Note that I'm testing code very close to top-of-tree (commit 7b4c78b), and am compiling on VS15.  I've used your scripts for partitioning the hard disks (Thanks!)
If you know how to get around the above-mentioned failures, I'd love to hear it.  If not, I'll try to fix them in code, but will take some time to familiarize myself to the code base.

For SerialNumberOffset test did you specify serial number (name) in the command line?

Command line of what?  Compile-time or test-time?

test-time. should be something like this
"-device ...,serial=xxxxxxxxxxx,..." (up to 12 symbols iirc)

Thanks Vadim.  Sorry, but I'm a little dense.  This is the command line when instantiating the device (through pnputil maybe?) or some kind of HLK command line?  I'm running HLK from the GUI, and don't see any options on this particular test for command line or test parameters.

Hi Ben,
This is part of the QEMU command line. You need to specify serial number to disk device.
Best regards,
Yan.

On Jul 25, 2017, at 20:20, Ben Warren<EMAIL_ADDRESS>wrote:
Thanks Vadim. Sorry, but I'm a little dense. This is the command line when instantiating the device (through pnputil maybe?) or some kind of HLK command line? I'm running HLK from the GUI, and don't see any options on this particular test for command line or test parameters.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Yan,
OK, that makes sense.  Thanks a lot.
--Ben

Thanks again for your help on this guys.  Do you have any thoughts on the other failures?  I assume for the firmware that you either tag the device somehow as not being firmware-upgradeable or have a dummy file?  For the static analysis failure, have you seen this?  Is it a setup problem on my side, or do we need to do some development work to fix this up?

I will ask our QE engineers to take a look at that. To the best of my knowledge both recent storage drivers (viostor and vioscsi) successfully passed HLK testing and MS WHQL submission.

Hi Vadim,
I'm down to one test left - 'Storage Firmware Update':
http://msdn.microsoft.com/en-us/library/windows/hardware/bba16fe1-2164-4a15-8b6a-75a967c5e6c3
There's only one parameter to supply: FirmwareImageFile, which is the path to a firmware file on the test machine.  I've tried leaving this blank, and providing a dummy file, but the test fails
Start Test 8/7/2017 11:29:34.821 PM Download firmware to device using IOCTL_STORAGE_FIRMWARE_DOWNLOAD.
Error 8/7/2017 11:29:34.829 PM DeviceStorageFirmwareUpgrade - firmware download IOCTL failed. Error code: 1

I don't see any handling of this ioctl in the driver, nor do I see any configuration for stating that this driver doesn't have upgradeable firmware.
Any ideas?
thanks,
Ben

Hi Ben,
That's strange. In my understanding, we shouldn't be there with IOCTL_STORAGE_FIRMWARE_DOWNLOAD request. Give me some
time to figure out what is wrong here.
Best regards,
Vadim.

Hi Ben,
QE pass all the certification submissions.
When we ran vioscsi/viostor whql job for win10/2016,we didn't run job "Storage Firmware Update".
Did you load the playlist when you submit jobs in HLK?I guess this job is removed after playlist loaded.
The playlist we used is https://sysdev.microsoft.com/en-US/Hardware/compatibilityplaylists/
For "Storage Query Property" and "Static Tools Logo Test",this two jobs passed easily during our test.
Anything else,please let me know.

Hi,
Yes, I re-downloaded this playlist and it's the same, see here:

Pay no attention to the failing "Storage Query Property" tests, I just haven't had time yet to change the QEMU command line for drive serial number but will hopefully get to that today.
As for the "Static Tools Logo Test", I was able to get it to pass after changing the "Rules Set" in SDV to "VirtualStorport".  If set to "All", there's one spinlock test that can only pass by essentially removing all multi-queue capabilities, and that seems like a really stupid and intrusive thing to do in order to pass a test.
Thanks again for all the help!
--Ben

Hi Ben,
Your playlist is for 1703,I think you should use "HLK Version 1607 CompatPlaylist".
Because your HLK and win10/2016 is 1607 version,1703 is for latest windows 10 version.

Hi Li Jin,
Do we have any plans for running 1703 in the nearest future?
Thanks,
Vadim.

Hi Vadim,
We did use 1703 for windows 10 during rhel7.4 release.
For win2016,HLK 1607 is required;
For win10,we used latest 15063 build,so HLK 1703 is required.
Ben's win10 is still 14393 build,so he also need to load 1607 playlist,same with win2016.
https://blogs.msdn.microsoft.com/windows_hardware_certification/2017/04/05/submissions-using-windows-10-version-1703-are-now-being-accepted/

Hi Li Jin
Thank you for the clarification.
Vadim.

Thanks a lot for the clarification!  This is pretty confusing and annoying stuff!  It looks like the firmware update test only applies to Windows 2k16, so all the Win10 tests passed using the 1703 HLK.  I'll stash these results, install the 1607 HLK and re-run on the 2k16 images only.  Too bad the 1703 HLK can't load 1607 playlists or I'd be done :(

Update: Once running the correct version of HLK and playlist, I was able to get all HLK tests to pass for vioserial, vioscsi and balloon.  I'm still working on the NetKVM driver, but setup is a bit trickier there.  Thanks a lot for the help.
Separately, how do you know which tests are necessary in HCK to get WHLK certification?  I filter on 'Certification', but some of the SCSI tests fail (all of the LUN reset and bus reset tests), but the test description for them says "these optional tests...."  In your experience, are they truly optional?

use latest msft playlist,hlk will load the needed tests automatically.
"The Windows Hardware Compatibility Program uses an official playlist to determine which devices meet the requirements for compatibility with Windows 10."
https://msdn.microsoft.com/en-us/library/windows/hardware/dn914993(v=vs.85).aspx

Hi Li Jin,
Thanks for responding.  I probably didn't phrase my question well enough.  I'm working with the HCK, which is used for Win7/Server2k8 and Win8/Server2k12, not HLK.  HCK doesn't have playlists, only categories, and my confusion is that some of the tests under the 'Certification' category are described as "optional".  I'm asking if, in your experience, these tests need to pass or if thy really are optional.
thanks,
Ben

Sorry for misunderstanding.
For HCK,all the loaded tests must pass if you want get the certification.So bus rest and lun reset tests are actually not optional.

Closing this issue.  I was able to get all HLK tests to pass.


Update hongfuzz to ~2.0 (current master)

fixes #30

Perfect!
Thanks @Mrmaxmeier for taking the time to do this PR :-)
bors r+

bors r+


new techniques

Dear all,
Would it be possible to add following as new techniques to KG?

GPU based white matter phantom generator
Nerve fiber modelling

Best,
Sara

@lzehl What is the status here? Any techniques that need to be added or did you reach a conclusion with @szafarnia offline?

I did not yet reviewed the respective dataset. I'll get back to it as soon as I can.


Update HTML fundamentals

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Hey @ChaitanyaZunzurkar,

[x]  I have read and followed the how to open a pull request guide.

Checking again all ticks in the checklist won't fix problems with PR, which make obvious linked guidelines are not followed.


feat(command): Pass command from experiment spec to runner

Closes #152

Thanks for this PR @jnodorp-jaconi ! Just curious - are you building out your own version of the experiment image?

Just curious - are you building out your own version of the experiment image?

Yes, exactly. I am currently chaos testing an application that uses GCP (Google Dataproc to be specific), so I built a custom image providing GCP specific experiments (shutdown VM instance, reboot VM instance, ...).

Rebased...


Maintaining allocated numbers

On the videos, where you showed how to use Ninja, we can see how easy is to allocate new id of the object.
What about de-allocation?
Let's consider some scenarios:

I started new object and instead of Query I created Page, then I realized the mistake and corrected the type ang get new id for it
I am re-working/removing part of the functionality so instead of 10 objects used earlier, it now uses 3 only (and no, those ones which I removed are not consecutive at the end - they sit randomly in the middle of the pool)
my autistic child figured out how to use ninja and "aligned" all pools so they end with 5
my cat run through the keyboard allocating an object accidently ;) etc..
at the same time 20 other developers are doing their work - allocating new numbers (with or without mistakes) - so I would rather not refresh whole repo to match the allocation currently present in my local branch.

For now our plan, not perfect, would be:
when creating stable new release - re-sync repo with id's to match master.
But obviously allocations done in "work in progress" (in any branches not yet committed) will be lost and could cause overlapping...
Any suggestions how to handle this?

This is one of the most important features in my TODO list already (from the beginning of Ninja, in fact). I have some ideas around how to make this as simple as possible.
These are (sub)features I have in mind:

Undoing last allocation
Reviewing any allocations which are known not to be pushed and are no longer associated with existing objects
Range Explorer will include object IDs as well, and you will be able to deallocate from there by right-clicking

Regarding your proposed workflow of resyncing when creating a stable new release, this is obviously a manual process that you can already do with auto-sync feature. I don't see how I could automate it beyond this, because "creating stable new release" is something very different for different teams.

I made my comment about 'stable release' just to show that we can, with some limitation, handle the maintenance right now - so this is not super critical...
But the features you suggested above would be absolutely brilliant! That was exactly what I was hoping for :)

Range Explorer will include object IDs as well, and you will be able to deallocate from there by right-clicking

When you will be developing this particular one could you show somehow differently (colors/font/etc) three types of allocations:

IDs which are allocated and which exist in current branch - so they are essentially OK (****)
IDs which are allocated and which do NOT exist in current branch - potentially allocated by other people / require review
IDs which are NOT allocated and do exist in current branch - so the update is required for them

(****) this part could also be not reported at all, or potentially hidden by default - when we are talking about hundreds / thousands of objects already present in the solution - it will be not very helpful to see them...

I think the latest changes do fulfill all the things I mentioned in my original email. I am happy to close this one - great job!


Krohnkite script makes kwin crash

We (KWin upstream) have received a substantial number of crash reports from users who use Krohnkite script https://crash-reports.kde.org/organizations/kde/issues/36968
The culprit seems to be that Krohnkite can access window properties after the window has been closed. It's not supported behavior. Ideally, when a window is closed, a script should drop all its window references.

I have a question. Krohnkite uses windowRemoved(KWin::Window *window) signal.
https://github.com/anametologin/krohnkite/blob/3c546f45065d1b47a0ef077446fa04f91f972eaa/src/driver/kwin/kwindriver.ts#L355-L361
Can I use a given window reference  inside signal's callback function?

Can I use a given window reference inside signal's callback function?

Yes, but you should not do anything about the window, e.g. resize it or make it fullscreen, etc. The windowRemoved() signal indicates that the window is already removed.

https://invent.kde.org/plasma/kwin/-/merge_requests/6424 addresses the kwin crash, but in general, judging by the crash, the window is used some time after the windowRemoved signal has been emitted

https://github.com/anametologin/krohnkite/issues/79#issuecomment-2380588026

https://github.com/anametologin/krohnkite/issues/79#issuecomment-2393189472

f25caab97f979975e696912cdd65bd83d3f58b6a


Weird walking animation on turtles

Might want to look into renaming #4 to also include these weird animations, leaving this open for now though.

Mungkin ingin melihat penggantian nama #4 untuk juga menyertakan animasi aneh ini, biarkan ini terbuka untuk saat ini.

ok, I'll leave it open for now

Hey there! This project has been moved to a new repository, and as such this issue will be closed. Feel free to reopen any bugs in the new location


Update Querying.md

The AbstractSolrQuery operator is &, not &&
Similarly, it's |, not ||

It is && and || , check out https://github.com/SolrNet/SolrNet/blob/26d2103bddb944cc61b463191b5b76e70f0cc203/SolrNet.Tests/OperatorOverloadingTests.cs#L42-L54 :slightly_smiling_face:

Sorry, you're right.
&& and || are indirectly overloaded by & | true() false()


[WIP]armdev: sys_exit

Tracking #1098
NOTE: contains additional commits, that will be dropped when finished:

76c36ab07da0e815d4fbf59555e0c06ea46e9f82
fd29f1752f054670efe104c94c52f6b3f0d77c0d
b14c96194e4001266783ffb20fcac55a93878bda

NOTE: it will be rebased against armdev-brach when finished.

@QuarkContainer Current testing background
Running

docker run --rm --runtime=quark_d hello-world

Results in:
-A) Terminal

....Normal execution - Omited ....
For more examples and ideas, visit:
https://docs.docker.com/get-started/
thread '0' panicked at 'misaligned pointer dereference: address must be a multiple of 0x8 but >is 0x9', src/qlib/backtracer.rs:49:32

-B) Log
quark.log

I just realized that the fn PageMgr::Clear() is not implemented for aarch64.

I just realized that the fn PageMgr::Clear() is not implemented for aarch64.

But it seems to me that it is unrelated to this issue as we don't set up vsyscall pages at all to begin with in armdev.

@QuarkContainer
I got a new error-log for the same issue: 'misaligned pointer dereference' caused in uring_mgr.rs - armdev branch. Can you give me some context about the usage of fn IOUring() call?

@QuarkContainer I got a new error-log for the same issue: 'misaligned pointer dereference' caused in uring_mgr.rs - armdev branch. Can you give me some context about the usage of fn IOUring() call?

Although it does not seem to repeat, maybe it was a one-time thing...

@chl337 This is related to the old io_uring implementation in which the host io-uring pages are mapped to guest kernel to improve performance. But since Linux 6.x, the io-uring pages can't be mapped to guest kernel because of Linux kernel non-backward compatible change. So the code is removed. The issue is related to https://github.com/QuarkContainer/Quark/issues/1045.
In the latest code, there is no such uringsAddr. Could you please rebase to avoid this issue?

In the latest code, there is no such uringsAddr. Could you please rebase to avoid this issue?

On our testing machine it's still a 5.15 kernel:

Linux arm1 5.15.0-67-generic #74-Ubuntu SMP

In the latest code, there is no such uringsAddr. Could you please rebase to avoid this issue?

On our testing machine it's still a 5.15 kernel:

Linux arm1 5.15.0-67-generic #74-Ubuntu SMP

If there is no more 'misaligned pointer dereference' repro, it is also ok to keep the old code so far. :-)

@chl337 This is related to the old io_uring implementation in which the host io-uring pages are mapped to guest kernel to improve performance. But since Linux 6.x, the io-uring pages can't be mapped to guest kernel because of Linux kernel non-backward compatible change. So the code is removed. The issue is related to #1045.
In the latest code, there is no such uringsAddr. Could you please rebase to avoid this issue?

Running on Linux 5.15, so as I thought, it was a one-time thing and not necessarily related to the current issue...

I think this is already merged, should we close this PR?  https://github.com/QuarkContainer/Quark/commit/dfe3b3962d02522efa94637df9da691f202c08e2

https://github.com/QuarkContainer/Quark/pull/1119/commits/4370bea53c8511216c3e42776b61f7a207aea788
NOTE: This is a trick(/safeguard) and not a proper solution. Still stops the undesired unmapping of the MMIO Page (only relevant to armdev) - The container exits properly.

thanks, LGTM.

The container exits properly.

It works for me, nice.
so the sys_exit problem is indeed because of hypercalls after unmapping MMIO regions.
While it's possible to directly operate on PA, that could involve EL2+ firmware. Also once we move towards CC, we could replace the MMIO interface with HVC. Anyways that's for another topic.


PHP:Migrate php:unit_tests to  latest version PHPUnit 8

For PHPUnit 8:
PHPUnit\Framework\TestCase::setUpBeforeClass()
PHPUnit\Framework\TestCase::setUp()
PHPUnit\Framework\TestCase::tearDown()
The methods listed above now must be declared void.
The @expectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9. Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageRegExp() instead.
@stanley-cheung

Sorry for not noticing earlier. But this won't work. Looks like PHPUnit 8 requires PHP 7.2 or above. This is not something we can catch up easily. We need to be a little more lenient for supporting older PHP versions. We need to revisit this later. In the meantime, please try to change all the references to PHPUnit 4.8 to PHPUnit 5.7 for now.


Data Caching

FEATURE REQUEST:
When using Argo for ML, data caching would be an very useful feature.
For instance:

Workflow 1 starts
Workflow 1 executes container image 5 as its 10th step.
Argo somehow would be able to figure out whether container image 5 already executed with the exact same inputs previously. (It could have been as part of another workfow).
If the same image was already executed with the same inputs, the output of the previous execution would be reused, the image would not be re-executed.
If the container is storing data in an artifact repository, the old data would somehow be associated with the old (completed) as well as the new (bypassed) execution.

Is this something that Argo would support?
If not, would you have suggestions/ideas on whether it would be possible to support this use case? Would need necessarily require big changes to Argo? Or do you think there is a way to support this with the current implementation?

@vicaire It's an interesting feature but I'm not sure if thats something Argo will offer.
But if you need the feature in near future you could have a look at Pachyderm which tries to improve the processing with caching and special data management.

DSchmidtDev@, ideally, we would like something that is integrated with Argo. We would also like the caching logic to be separate from the containers that handle the ML computations.

+1. We use Luigi and consider migrating to Argo.
Luigi is "able to figure out whether container image 5 already executed with the exact same inputs previously. (It could have been as part of another workfow)" and it would be great if Argo provides it as well.

What is the goal please - to execute workflows faster by not running steps that have already been computed?

While the goal to execute faster is part of it, it also involves better resource usage and the ability to use Argo as a generic ETL/Data/ML workflow engine. Some workflows might be really costly in time and money, say workflows that require GPU and big CPU/RAM requirements, and might take several hours to compute.

Would you consider calling this feature memoization instead of data caching?

Can I propose a new name for this issue - "step memoizing"? I think it captures the problem and potential solution in a way that makes it easy to to understand.
E.g. "Reduce cost and workflow execution time by memoizing previously run steps"?
This is a large feature as we'd need a data store to memoize the results.

+1 to step memoizing

This is something I've been manually implementing in the container's logic itself. For ML workflows in particular, I've been resorting to checking if the output dataset exists then exit early. Wonder if a simple solution to some of this problem is something like
mytask:
   - name: data-stuff
     when:
        - pathNotExists:
             - s3://mybucket/key1
             - s3://mybucket/key2

For example, it'd be really lovely to do stuff like this to check for the existence of spark's _SUCCESS files for big ETL job caching

See #1054

@ecurtin2 I'm doing the same, on an NFS share volume. Manually checking at each step whether the output exists and skipping the step if it does. It would be great to have a solution built-in to Argo.

See #3066

Had some discussion about this. This is how we propose this feature will will work:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: memoize-
spec:
  entrypoint: whalesay
  arguments:
    parameters:
    - name: message
      value: hello world

  templates:
  - name: whalesay
    memoize:
      maxAge: 3d
      cache:
        configMapName: whalesay-cache
    inputs:
      parameters:
      - name: message
    container:
      image: docker/whalesay:latest
      command: [sh, -c]
      args: ["sleep 10; cowsay {{inputs.parameters.message}} > /tmp/hello_world.txt"]
    outputs:
      parameters:
      - name: hello
        valueFrom:
          path: /tmp/hello_world.txt

---

apiVersion: v1
kind: ConfigMap
metadata:
  name: whalesay-cache
data:
  # cache key would be hash combination of:
  # - template definition
  # - inputs
  # allows cache to be invalidated if template changes or inputs change
  whalesay.abc123def4567890: |
    {
      "exipiresAt":"2020-06-18T17:11:05Z",
      "nodeID":"memoize-abx4124-123129321123", # do we need this?
      "outputs":
        {
          "parameters":
            [
              {
                "name":"hello",
                "value":"hello world"
              }
            ]
        }
    }

Future improvements would include:

syntax to allow this to happen for all steps of the workflow (i.e. spec.memoize)
ability to control what inputs can control the cache key (e.g. allowing only some of the N inputs to affect the cache key, and ignore others)
ability to use other stores as a cache (other than a ConfigMap), e.g. redis

I'd like to comment that I think being able to use an artifact-like store for this is particularly useful for me. We are often doing ETL + ML tasks that are long-lived and in namespaced deployments of workflows, and every once in a while depend on external tasks. If there was a way to maybe do some sort of cache key as a file artifact I think it could really help.
In your example I'm thinking of something like
  - name: whalesay
    memoize:
      cache:
        key: "{{memoize.template}}-{{memoize.params}}"
        ~OR~
        key: ""   # Spark does empty _SUCCESS files so we can skip in that circumstance
        artifact:
          s3:
            endpoint: aws.whateveritis.com
            bucket: my-bucket-name
            key: path/in/bucket

I am not familiar with the internals of Argo so am not sure if this is hard for some reason I don't understand.

@jessesuen Thanks for implementing this. One question, should we include the actual container  hash in the cache key computation because there are cases the actual container image changes but the tag keeps the same

@lilida The way we are handling this is by allowing custom keys - so that users can pass in their own input to use as a key in the instance where the tag is constant but the container image change, or other use cases where the workflow spec might stay the same but outputs change. Does this address what you were thinking?

@rbreeze  Customized key can probably address it but extra effort is required. An alternative can be some easy api or way to invalidate the cache so the invalidation be integrated with the image publishing process

@lilida That's a good idea, for the first draft we are going to stick to using custom keys only, but this might be something we explore more down the line

ICYMI Looks like @rbreeze is working on this in https://github.com/argoproj/argo/pull/3356.

@jessesuen
Thank you for your work on designing this.
In KFP we've recently implemented execution caching on top of Argo using a Kubernetes Mutating admission controller webhook. Having native support in Argo would be much better.
We have cache reuse turned on by default.
The cache key is calculated based on certain parts of Argo template (inputs, container.{image,command,args,env, volumeMounts}, volumes`). When pod succeeds we record Argo's outputs to a DB. When new pod comes and we find a viable cache DB entry we skip the execution by hacking the pod using the output data from the DB so that Argo thinks that the pod actually ran.
The way to control the cache reuse: We have an annotation called max_cache_staleness. It's per-task/step, not per-template like in your proposal. (The template authors cannot know which value to use, so it's not their responsibility - it's the responsibility of the workflow author.)
The cache selection logic is as follows:

Calculate the cache key
Query the DB and try to use the latest viable (same cache key, not too old) DB entry with with the same max_cache_staleness
Else query the DB and try to use the latest viable (same cache key, not too old) DB entry. If found, then copy that entry adopting the task's max_cache_staleness.
Else submit the pod for execution and when it succeeds record the outputs in the DB including the max_cache_staleness in the entry.

Here is the reason for this more complicated logic: Suppose you have two different workflows - "fast" (max_cache_staleness=1 day) and "slow" (max_cache_staleness=1 month). We do not want the "fast" workflow to constantly break the cache for the "slow" workflow. With the logic above the fast workflow does not affect cache queries for the slow workflow.
Some other aspects:
It might be useful to allow specifying cache_seed which is used when calculating the cache_key. This way it's possible to "break" the cache while still using the same maxAge/max_cache_staleness.
In the future you might also want to add the "execution latching" feature: Suppose there are no completed results for your task but the same task is already being executed at this moment. Then you could just "latch" to that execution - wait for it to complete and use its outputs instead of launching a new execution.

2. ability to control what inputs can control the cache key

Do you think it would be useful to have some sensible default like container + inputs?

@Ark-kun are you free to Zoom with @jessesuen @rbreeze and myself about your use case please?

@Ark-kun are you free to Zoom with @jessesuen @rbreeze and myself about your use case please?

Sounds good. What's the good date/time for you?

Available for testing in v2.10.0-rc1.

What is the actual solution?  How do we use this (or is it automatic somehow?)


[Image Resizer] ComboBox UI

Summary of the Pull Request
Replacing the ListView (that doesn't scroll) with a ComboBox. This improves accesibility navigation and is more scalable when having a lot of sizes configured).

Quality Checklist

[X] Linked issue: ##13283
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

I don't like the combo box solution. I think we should have a scroll viewer and show at least 4 sizes without scrolling.
But if we go with drop down it maybe make sense to not reserve the space for custom boxes fixed. These empty space looks a bit odd.

should have a scroll viewer

Using RadioButtons for more than 3 items is considered bad practice. Using a ComboBox
Agree on the white space - however, the application window will jump/resize when switching to between items which is a bit annoying.

should have a scroll viewer

Using RadioButtons for more than 3 items is considered bad practice. Using a ComboBox
Agree on the white space - however, the application window will jump/resize when switching to between items which is a bit annoying.

Lets only disable the controls for custom config. Then we don't have a white space.

should have a scroll viewer

Using RadioButtons for more than 3 items is considered bad practice. Using a ComboBox
Agree on the white space - however, the application window will jump/resize when switching to between items which is a bit annoying.

Lets only disable the controls for custom config. Then we don't have a white space.

Regarding only disabling the controls, my main concern is that they'll show incorrect information that way. The empty space seems preferable to that.

should have a scroll viewer

Using RadioButtons for more than 3 items is considered bad practice. Using a ComboBox
Agree on the white space - however, the application window will jump/resize when switching to between items which is a bit annoying.

Lets only disable the controls for custom config. Then we don't have a white space.

Regarding only disabling the controls, my main concern is that they'll show incorrect information that way. The empty space seems preferable to that.

This sounds logical. But in the old ux they were only disabled too.

@jaimecbernardo , @niels9001
If you like to merge the PR I am okay with let it as is.


initialize extended stack frame on RV32M1 ri5cy core

The optional SOC_CONTEXT carries processor state registers that need to
be initialized properly to avoid uninitialized memory read as processor
state.
In particular on the RV32M1 the extra soc context stores a state for
special loop instructions, and loading non zero values will have the
core assume it is in a loop.
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/26030

Rebased on master and checked again, still works :-)

Hi, not sure how to have this proceed further. The PR mostly tagged RISC-V maintainers, but should be fairly understandable to other platforms as well, as it is just missing initialization on part of the stack frame that is required. @MaureenHelm do you know if there is anybody else I could tag on this? RV32M1 is sort of a niche thing, but still a very interesting platform

Hi, not sure how to have this proceed further. The PR mostly tagged RISC-V maintainers, but should be fairly understandable to other platforms as well, as it is just missing initialization on part of the stack frame that is required. @MaureenHelm do you know if there is anybody else I could tag on this? RV32M1 is sort of a niche thing, but still a very interesting platform

Sorry for the delay. These changes look ok to me, but would like one of the RISC-V maintainers to review.
@kgugala @pgielda @nategraff-sifive please review.


Duplicate projects in ingest

Description of the task:
https://embl-ebi-ait.slack.com/archives/C01360XN04S/p1636481936082700
There are duplicate projects in ingest:
A single-cell atlas of the healthy breast tissues reveals clinically relevant clusters of breast epithelial cells / Single cell atlas of the healthy breast

https://data.humancellatlas.org/explore/projects/a004b150-1c36-4af6-9bbd-070c06dbc17d
https://data.humancellatlas.org/explore/projects/9bab0f03-a725-4a13-9ab1-196e46cd80ed

Single-cell analysis of Crohn’s disease lesions identifies a pathogenic cellular module associated with resistance to anti-TNF therapy.

https://data.humancellatlas.org/explore/projects/504e0cee-1688-40fa-b936-361c4a831f87
https://data.humancellatlas.org/explore/projects/992aad5e-7fab-46d9-a47d-df715e8cfd24

[ ] Where have the datasets come from?
[ ] which ones are more up-to-date?
[ ] why were the datasets duplicated?
[ ] Next steps to fix??

Acceptance criteria for the task:

Preliminary Investigation is complete and we have clear steps and responsibilities for next steps to fix the duplicate projects
Have clear steps for documenting / meeting on how to prevent this on happening again

@Wkt8 took a look, will get an answer by noon about UCSC/EBI wrangled dataset

For the Single cell atlas of the healthy breast, the two projects are from Lattice and UCSC. Going by the seed-network funding rules, we should remove the one curated by Tiana Pereira.

[ ] Remove https://data.humancellatlas.org/explore/projects/9bab0f03-a725-4a13-9ab1-196e46cd80ed

For the Crohn's disease lesions EBI/UCSC dataset, there are some missing metadata from both sides. However, the UCSC dataset is more up-to-date, and includes analysis_file and analysis_protocol as it was exported after we made those metadata changes. Should delete the EBI dataset.

[ ] delete https://data.humancellatlas.org/explore/projects/992aad5e-7fab-46d9-a47d-df715e8cfd24

Have added this to the agenda for the ucsc-stanford catchup. There's two issues, one of which is checking for seed network funding, the other which is ensuring that EBI and UCCSC dont wrangle the same datasets which is already in place due to the changes in using ingest as our back-office.
These were duplicated because of the lack of QC and checking for seed-network funding, checking in the browser, and lack of a shared wrangling list between UCSC and EBI - but now we have one.

@gabsie to send the email request to Dave, to arrange the redirects. Then inform @ESapenaVentura to go on with soft deletion request.

I have now requested the redirect arrangement, waiting for go-ahead by Dave & Trevor

When re-direction is confirmed we can move this ticket to done.

Dave has confirmed this will be re-directed.


Runtime dynamic forms from GraphQL schemas

Hi Juan,
Thanks for your great work on this so far!
I'd like to propose a new feature where you could add a list of forms/layouts for all queries/mutations in a GraphQL introspection schema simply by providing a uri to the schema.
These dynamic forms would be ready for immediate use by being data-bound and having the basic validations already in place. As such they would serve primarily two use cases:

In many projects users (or often us the developers) have to perform simple CRUD operations directly against databases and so on many iterations into development. A reasonably user-friendly way of manipulating backend data using these dynamic forms would prevent this.
Starting the design-work on basic but already working forms and manipulating these using the editor considerably lowers the complexity and effort to create a large number of forms.

There are many interesting challenges to solve here, for example:
*matching of queries and mutations to forms
*managing which forms (dynamic vs customized) should be available to "viewers".
I would be happy to try and do some work on this if you think FormQL is the right place for it?

Thanks so much for proposing this feature, it's a great idea!
I originally created this library with the Apollo client but then I decided to make the service implementation up to the developer in case they want to use it with a normal RESTFul API (I documented the service in here). I always wanted to make sure the editor remains separated from the core library, this is to try to make @formql/core as smaller as possible so when running in production you don't need to carry the overhead of the editor.
Back to your question, I think FormQL is definitely the right place for your idea. I did look at how GraphQL Editor work and checked how I could integrate it with the FormQL editor, I thought user being able to write a query and then perhaps "drag" fields from the result into the form, the FormQL editor can automatically sort out the binding to the field selected. The editor is not strongly typed at the moment, I always thought about getting everything wired up first and then introduce as much validation as possible like the ability to select the schema from a list of fields, I also thought at some point to integrate with something like swagger for normal RESTful API.
I have to admit that I left the library a bit unattended since COVID started but I really want to get back to it this month, I have a few PRs that I've been testing locally but didn't get to finish yet. I've also been actively looking for people that want to get involved on building FormQL so if you are interested then you are more than welcome.
How do you envision your feature being implemented? Would the user select the data source type in the editor, add the uri and then have a list of fields that can be added to the form? (e.g. I show below where you select the data source in a form, the type of data source is something I wanted to make an enum with RESTful and GraphQL as options (see FormDataSource model here)

I sense you want something even more programmatic than that, it looks like you are proposing to have a list of predefined queries that you can use in your form?
In any case, I can definitely point you in the right direction, if you can elaborate then we can put some thoughts on how to build it
Juan

I'm trying to standardize the query by dynamodb, which should be simple queries and must meet the creation of a form for a product category for example we have json:

como explica o blog: da amazon: https://aws.amazon.com/pt/blogs/database/how-sgk-simplified-the-data-structure-of-a-highly-dynamic-workload-by-migrating-from-an-rdbms-to-amazon-dynamodb/
and if you can give me the direction as you said in the previous conversation I would be grateful.

@LucianViana
Not sure if I understand what you are trying to do but I put a very simple example in stackblitz
This example has 2 fields and a save button. Worth noting in the example below the save button to save the form definition and the save button that is on the form to save your data

I made that example to store the data in local storage, this is simply to "simulate" as if your local storage was your webservice.
The idea with FormQL is that you design your form by dragging and dropping "components" in the form, you do that by dragging the third button on the left hand side (if you hover over the buttons, it tells you what they do)

once you build your form, you click on the pencil button and define what component you want to use (simple field, date picker, picklist, etc) and then define your "schema", that is the mapping to a JSON Data object

if I now type something in the form and press save, the data is stored in local storage

you might have also noticed that if I press the save button on the top to save my form definition, it will push the change to the local storage too

this specific example has been configured in a way that your parameters determine the name of the form you are editing and the id of the record you want to save

if you then remove the word edit, you can see the form in view mode (that's how your users will see/use your form)

FormQL doesn't force you to pass the form name and id through the URL all the time, I've just configured this specific example in that way to explain how FormQL works.
Back to your question, how would you implement the integration with DynamoDB? you just need to create a class that implements the IFormQLService interface and implements the getData/saveData and getForm/saveForm to connect to your backend of choice (you can see the implementation of the local storage here, it's also documented in this wiki). getData will be called when the form attempts to get the data to populate on the form and saveData when the user presses the Save button. In the same way getForm will be called when FormQL attempts to load the form definition and saveForm when the user clicks on the button on the top to save the form definition.
The philosophy behind FormQL is to help you build forms quickly by using the editor without having to write tons of code (you can read here how the editor works). It also gives you the ability to write your own componentes and build more complex scenarios (see this Mortgage Calculator implemented in FormQL which I also explained it in this blog
I hope it helps

Unbound breakpoint "problem debug in Visual Studio":
Hi, I can't debug in visual studio, do you have any tips to help?
The files cannot find the path, could it be because the compiled files are in another path?
My lauch.json:
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "chrome",
"request": "launch",
"name": "Launch Chrome",
"url": "http://localhost:4200/",
"webRoot": "${workspaceFolder}",
"sourceMaps": true,
"sourceMapPathOverrides": {
"": "${webRoot}/apps/angular/app/src/"
}
},
{
"type": "node",
"request": "launch",
"name": "Jest Test",
"program": "${workspaceFolder}/node_modules/jest/bin/jest",
"args": [
"--runInBand"
],
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen"
}
]
}
note:
Other people have reported the same problem, but it seems that I am not alone in this problem.
example:
https://github.com/microsoft/vscode/issues/102493

Now I found that I can only select if it is a "js" file, as shown in the image below, it seems that there may be a solution out there, maybe if we change the build structure, but here is a tip to help other people who may have same problem to debug:

Hi Juan,
I know it can be support but I didn't find it on formql.io where to ask, but I'm trying to access an external http and the error happens below, would it be any restrictions that formql still has or not?
Error:
"TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functio"
this.http.get(http://api.openweathermap.org/data/2.5/weather?q=London,uk&APPID=7facebd2cd201249fb820ac63ed905e5);
> 40 |     expect(actualDataReturned).toEqual(mockData);
     |                                ^
  41 |     done();
  42 |   });
  43 |     //service.getProducts().subscribe((products) => {

  at apps/angular/app/src/app/product.service.spec.ts:40:32
  at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:391:26)
  at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (node_modules/zone.js/dist/proxy.js:129:39)
  at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:390:52)
  at Zone.Object.<anonymous>.Zone.run (node_modules/zone.js/dist/zone.js:150:43)
  at Object.<anonymous> (node_modules/jest-preset-angular/zone-patch/index.js:53:29)

thanks.

I'm not sure about your setup, looks like you are trying to mock some data with jest? in any case, formql shouldn't have any problem to work with that API. Maybe something related to the API called as in this StackOverflow question?
I just created a quick example in stackblitz
https://stackblitz.com/edit/simple-form-weather-api?file=src%2Fapp%2Fapp-service.ts
You can see below I added your URL using SSL (e.g. https otherwise stackblitz will block it) and the data is populated correctly in the form

I've just had to get the mapping aligned with the API response

hope it helps


refactor: molecules

Related issue
Closes #1348
Scope of work
Molecules with new design

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: AdamPawlinski:x: justyna-13You have signed the CLA already but the status is still pending? Let us recheck it.


make gogs integration honor skip_verify

Currently the skip_verify option for the gogs client has no effect.
This change adds TLSClientConfig: &tls.Config{InsecureSkipVerify: true}
to the Client's Transport.

 You should sign our Contributor License Agreement in order to get your pull request merged.Michael Gibson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account ([for further information, click here] (https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user)).

:-1: Do not manipulate a vendored lib. This needs to be added to the upstream client first.

@michaelgibson thanks for taking the time to send a patch! As mentioned, we should make the change upstream at gogits/go-gogs-client and then refresh the vendored copy

ok I think I see how things work here:
Looks like you already requested this change to the client.
https://github.com/gogits/go-gogs-client/issues/8
Which is now exposed via SetHTTPClient:
https://github.com/gogits/go-gogs-client/commit/8068507b500ea3ededecacc9d53c10da5f6ddd01#diff-0ec5cf868d4c7c045eb43e57a1b06419R37
I'll re-work it to use that instead and re-submit.
Thanks!


not seeing a menu and  view for newly created bread

Laravel Version: #.#.#
Voyager Version: #.#.#
PHP Version:
Database Driver & Version:

Description:
i can not see a menu and  view for newly created bread, is this an error ? if not please help future users and i to appreciate this package better by providing good documentation. thanks
Steps To Reproduce:

Have you give your current role permissions to new bread? It's done in "Roles"

i think i have figured it out thanks, i watched the youtube explanation


[Botskills] Update disconnect command description

Purpose
What is the context of this pull request? Why is it being done?
We noted an inconsistency on the disconnect's command description.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
We changed the description to show what Botskills actually need to remove a Skill, that is the id of the Skill.
Tests
Is this covered by existing tests or new ones? If no, why not?
-
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the appropriate tests
[x] I have updated related documentation

The change is OK, however, this will impact to the disconnect document? We should update this too in the document PR

I've reviewed the disconnect document and it is fine. It seems that the removed information was only on the code.

I'll close this as it was merged in MS


Gcp-pubsub-source

What changed, and why it matters
Missing examples for Google pubsub

Yeah, let's keep things as are now (pointing to the old repo). Once we move to the new repo I'll update
Thanks for the speedy review @encima