Adds Nepal Sanskrit University

Though we do not provide tech degrees to the students. We provide courses that needs an access to a handful tools to work on the coursework designed. Furthermore, the coursework of Mathematics wants the students to provide assessment/project work based on whatever programming language they wish to,henceforth we need access to tools provided by Jetbrains.
Couse link: Nepal Sanskrit Univesity Bachelors Course

@ravisharmaa First stage of verification passed, official domain for Nepal Sanskrit University is nsu.edu.np as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@ravisharmaa Pull request merged. Please start requesting the licenses in about an hour, to let the changes to propagate through our system. Thank you.


react/prop-types validation using typescript

Summary
In a Typescript project it would be very useful if react/prop-types could validate that apart from the TS definitions the PropTypes definitions are made, so that both work together.
This would help a lot to achieve a better development experience in cases where it is required, the differences between the two must be taken into account since they serve different purposes.
Typescript validates types at compile time, while PropTypes are checked at runtime. the latter is very useful when testing how components interact with external data etc.
Current behavior:
Just adding the typescript type to it stops throwing a PropTypes error.
interface HelloProps {
  name: string
  lastname: string
}

export default function Hello({ name, lastname }: HelloProps) {
  return (

      Hello {name} {lastname}

  )
}

Expected behavior:
With the new rule enabled this should throw a PropTypes error.
Incorrect code
interface HelloProps {
  name: string
  lastname: string
}

export default function Hello({ name, lastname }: HelloProps) {
  return (

      Hello {name} {lastname}

  )
}

interface HelloProps {
  name: string
  lastname: string
}

export default function Hello({ name, lastname }: HelloProps) {
  return (

      Hello {name} {lastname}

  )
}

Hello.propTypes = {
  name: PropTypes.string.isRequired,
}

interface HelloProps {
  name: string
  lastname: string
}

export default function Hello({ name, lastname }: HelloProps) {
  return (

      Hello {name} {lastname}

  )
}

Hello.propTypes = {
  name: PropTypes.number.isRequired,
  lastname: PropTypes.bool.isRequired,
}

Correct code
interface HelloProps {
  name: string
  lastname: string
}

export default function Hello({ name, lastname }: HelloProps) {
  return (

      Hello {name} {lastname}

  )
}

Hello.propTypes = {
  name: PropTypes.string.isRequired,
  lastname: PropTypes.string.isRequired,
}

interface HelloProps {
  name: string
  lastname?: string
}

export default function Hello({ name, lastname = "" }: HelloProps) {
  return (

      Hello {name} {lastname}

  )
}

Hello.propTypes = {
  name: PropTypes.string.isRequired,
}

Idea:
In the options of the react/prop-types rule, a new option could be added to enable this behavior.

This isn't something that's possible with static analysis - propType functions are massively more broad than just what's in React.PropTypes, and only the types of the prop-types package are statically knowable.
I completely agree that any component without propTypes is suffering a huge loss of protection, that TS is incapable of fully replacing - but i don't think there's anything except typechecked tests (that actually run) to keep props types and propTypes in sync.


How did you get Xcode to generate you an XPC Service with Swift boilerpate?

When I add a new XPC target it generates my files in Obj-C

Thanks to both of you! This helped me to get started with my first XPC service and keep my project in pure Swift!

Glad to help.

That time on the internet, when almost 2 years later you google for a problem you are experiencing and then end up back at your own answer that solves your problem. =)

Hi, just wanted to confirm that putting shared code into SharedFrameworks works nicely.
I currently have architecture consisting of 1 main app [Foo], 1 LoginItem [FooHelper] (which has UI, so it can't be an XPC target), and then 1 XPC service [FooAgent] they both talk to.
Shared code is in a private framework called FooCore, and all targets link to this framework.

Hi guys, do you have some ideas about how to use this for privileged tasks? i need to do some operations which requires running an external executable which requires to be run using the root user, something i can achieve only using sudo + user's password for now which is really unsafe, someone told me to use an xpc service to do this kind of privileged operation because xpc services runs on top of launchd which is a process of the root user, my question is how should i do that xpc service to perform a privileged operation thing? Thank you very much for you patience

can any one update this code to swift 5? I tried but getting major build errors


[BUG] nvidia mode not working

Describe the bug
Nvidia mode doesn't work properly (specifically for lightdm in my case)
To Reproduce

fresh install of arch linux with base base-devel linux linux-firmware xorg-server qtile lightdm lightdm-gtk-greeter
boot into lightdm
Install envycontrol. Run sudo envycontrol -s nvidia
reboot
there will be a black screen with a cursor blinking.
However if you're on a dual screen setup, the login manager will be there on the secondary display instead of the primary display

Expected behavior
There should be a login screen (and if plugged into an extra display it should show up on the primary display)
Screenshots
Excluded because pretty self explanatory
System Information:

Model: [ASUS ROG Zephyrus G15 2022]
Distro: [Arch Linux]
DE/WM and Display Manager (if applicable): [qtile lightdm]
EnvyControl version: [3.3.0]
Nvidia driver version: [535.113.01-4]

same issue here. Im using Arch with xfce and when I switch to NVIDIA mode, my environment switch to the second monitor instead of my laptop one.
xrandr detects only the second monitor:
Screen 0: minimum 8 x 8, current 3840 x 2160, maximum 32767 x 32767
HDMI-0 disconnected (normal left inverted right x axis y axis)
DP-0 connected 3840x2160+0+0 (normal left inverted right x axis y axis) 700mm x 390mm
   3840x2160     60.00*+  59.94    50.00    29.97    25.00    23.98
   2560x1440     59.95
   1920x1080     60.00    59.94    50.00    29.97    25.00    23.98
   1680x1050     59.95
   1440x900      59.89
   1366x768      59.79
   1280x1024     75.02    60.02
   1280x960      60.00
   1280x800      59.81
   1280x768      59.87
   1280x720      60.00    59.94    50.00
   1152x864      75.00
   1024x768      75.03    70.07    60.00
   800x600       75.00    72.19    60.32    56.25
   720x576       50.00
   720x480       59.94
   640x480       75.00    72.81    59.94    59.93
DP-1 disconnected (normal left inverted right x axis y axis)

Furthermore, glxinfo | grep OpenGL does not return NVIDIA but `LLVM``:
OpenGL vendor string: Mesa
OpenGL renderer string: llvmpipe (LLVM 16.0.6, 256 bits)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 23.2.1-arch1.2
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL core profile extensions:
OpenGL version string: 4.5 (Compatibility Profile) Mesa 23.2.1-arch1.2
OpenGL shading language version string: 4.50
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile
OpenGL extensions:
OpenGL ES profile version string: OpenGL ES 3.2 Mesa 23.2.1-arch1.2
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20
OpenGL ES profile extensions:

Despite by running hwinfo it finds both iGPU and NVIDIA GPU:
28: PCI 100.0: 0300 VGA compatible controller (VGA)
  [Created at pci.386]
  Unique ID: VCu0.0lI7h2uReU3
  Parent ID: vSkL.+qP7vwNkUf8
  SysFS ID: /devices/pci0000:00/0000:00:01.0/0000:01:00.0
  SysFS BusID: 0000:01:00.0
  Hardware Class: graphics card
  Model: "nVidia TU106M [GeForce RTX 2060 Mobile]"
  Vendor: pci 0x10de "nVidia Corporation"
  Device: pci 0x1f11 "TU106M [GeForce RTX 2060 Mobile]"
  SubVendor: pci 0x1462 "Micro-Star International Co., Ltd. [MSI]"
  SubDevice: pci 0x126a
  Revision: 0xa1
  Driver: "nvidia"
  Driver Modules: "nvidia"
  Memory Range: 0xa4000000-0xa4ffffff (rw,non-prefetchable)
  Memory Range: 0x90000000-0x9fffffff (ro,non-prefetchable)
  Memory Range: 0xa0000000-0xa1ffffff (ro,non-prefetchable)
  I/O Ports: 0x5000-0x507f (rw)
  Memory Range: 0xa5000000-0xa507ffff (ro,non-prefetchable,disabled)
  IRQ: 148 (3324088 events)
  Module Alias: "pci:v000010DEd00001F11sv00001462sd0000126Abc03sc00i00"
  Driver Info #0:
    Driver Status: nouveau is not active
    Driver Activation Cmd: "modprobe nouveau"
  Driver Info #1:
    Driver Status: nvidia_drm is not active
    Driver Activation Cmd: "modprobe nvidia_drm"
  Driver Info #2:
    Driver Status: nvidia is active
    Driver Activation Cmd: "modprobe nvidia"
  Config Status: cfg=new, avail=yes, need=no, active=unknown
  Attached to: #24 (PCI bridge)

38: PCI 02.0: 0300 VGA compatible controller (VGA)
  [Created at pci.386]
  Unique ID: _Znp.OrdtUzJTPd3
  SysFS ID: /devices/pci0000:00/0000:00:02.0
  SysFS BusID: 0000:00:02.0
  Hardware Class: graphics card
  Device Name: "Onboard - Video"
  Model: "Intel CoffeeLake-H GT2 [UHD Graphics 630]"
  Vendor: pci 0x8086 "Intel Corporation"
  Device: pci 0x3e9b "CoffeeLake-H GT2 [UHD Graphics 630]"
  SubVendor: pci 0x1462 "Micro-Star International Co., Ltd. [MSI]"
  SubDevice: pci 0x126a
  Driver: "i915"
  Driver Modules: "i915"
  Memory Range: 0xa3000000-0xa3ffffff (rw,non-prefetchable)
  Memory Range: 0x80000000-0x8fffffff (ro,non-prefetchable)
  I/O Ports: 0x6000-0x603f (rw)
  Memory Range: 0x000c0000-0x000dffff (rw,non-prefetchable,disabled)
  IRQ: 146 (974 events)
  Module Alias: "pci:v00008086d00003E9Bsv00001462sd0000126Abc03sc00i00"
  Driver Info #0:
    Driver Status: i915 is active
    Driver Activation Cmd: "modprobe i915"
  Config Status: cfg=new, avail=yes, need=no, active=unknown

@kamperemu I had nvidia-exec package installed on my system. I uninstalled it and now envycontrol works correctly.

@D3vil0p3r don't have nvidia-exec installed. So, I think my issue is completely different.

@D3vil0p3r don't have nvidia-exec installed. So, I think my issue is completely different.

Can you share the content of your /etc/mkinitcpio.conf and /etc/default/grub and the list of files in /etc/modprobe.d directory?
What is the output of the following commands?
echo "$XDG_SESSION_TYPE"

glxinfo | grep "OpenGL render"

lspci | grep VGA

@D3vil0p3r
I'm using systemd boot instead of grub
/etc/mkinitcpio.conf
`
vim:set ft=sh
MODULES
The following modules are loaded before any boot hooks are
run.  Advanced users may wish to specify all system modules
in this array.  For instance:
MODULES=(usbhid xhci_hcd)
MODULES=(nvidia nvidia_modeset nvidia_uvm nvidia_drm)
BINARIES
This setting includes any additional binaries a given user may
wish into the CPIO image.  This is run last, so it may be used to
override the actual binaries included by a given hook
BINARIES are dependency parsed, so you may safely ignore libraries
BINARIES=()
FILES
This setting is similar to BINARIES above, however, files are added
as-is and are not parsed in any way.  This is useful for config files.
FILES=()
HOOKS
This is the most important setting in this file.  The HOOKS control the
modules and scripts added to the image, and what happens at boot time.
Order is important, and it is recommended that you do not change the
order in which HOOKS are added.  Run 'mkinitcpio -H ' for
help on a given hook.
'base' is required unless you know precisely what you are doing.
'udev' is required in order to automatically load modules
'filesystems' is required unless you specify your fs modules in MODULES
Examples:
This setup specifies all modules in the MODULES setting above.
No RAID, lvm2, or encrypted root is needed.
HOOKS=(base)

This setup will autodetect all modules for your system and should
work as a sane default
HOOKS=(base udev autodetect modconf block filesystems fsck)

This setup will generate a 'full' image which supports most systems.
No autodetection is done.
HOOKS=(base udev modconf block filesystems fsck)

This setup assembles a mdadm array with an encrypted root file system.
Note: See 'mkinitcpio -H mdadm_udev' for more information on RAID devices.
HOOKS=(base udev modconf keyboard keymap consolefont block mdadm_udev encrypt filesystems fsck)

This setup loads an lvm2 volume group.
HOOKS=(base udev modconf block lvm2 filesystems fsck)

NOTE: If you have /usr on a separate partition, you MUST include the
usr and fsck hooks.
HOOKS=(base udev autodetect modconf keyboard keymap consolefont block filesystems fsck)
COMPRESSION
Use this to compress the initramfs image. By default, zstd compression
is used. Use 'cat' to create an uncompressed image.
#COMPRESSION="zstd"
#COMPRESSION="gzip"
#COMPRESSION="bzip2"
#COMPRESSION="lzma"
#COMPRESSION="xz"
#COMPRESSION="lzop"
#COMPRESSION="lz4"
COMPRESSION_OPTIONS
Additional options for the compressor
#COMPRESSION_OPTIONS=()
MODULES_DECOMPRESS
Decompress kernel modules during initramfs creation.
Enable to speedup boot process, disable to save RAM
during early userspace. Switch (yes/no).
#MODULES_DECOMPRESS="yes"
/etc/modprobe.d/nvidia.conf
Automatically generated by EnvyControl
options nvidia-drm modeset=1
options nvidia NVreg_UsePageAttributeTable=1 NVreg_InitializeSystemMemoryAllocations=0
echo "$XDG_SESSION_TYPE"
x11
glxinfo | grep "OpenGL render"
OpenGL renderer string: NVIDIA GeForce RTX 3070 Ti Laptop GPU/PCIe/SSE2
lspci | grep VGA
01:00.0 VGA compatible controller: NVIDIA Corporation GA104 [Geforce RTX 3070 Ti Laptop GPU] (rev a1)
07:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Rembrandt [Radeon 680M] (rev c7)
xrandr
Screen 0: minimum 8 x 8, current 1920 x 1080, maximum 32767 x 32767
DP-0 disconnected primary (normal left inverted right x axis y axis)
DP-1 disconnected (normal left inverted right x axis y axis)
DP-2 disconnected (normal left inverted right x axis y axis)
HDMI-0 connected 1920x1080+0+0 (normal left inverted right x axis y axis) 527mm x 296mm
1920x1080    143.98*+ 119.98   119.88    99.93    60.00    59.94    50.00
3840x2160     59.94    50.00    29.97    25.00    23.98
1280x1024     75.02
1280x720      59.94
1024x768     119.99    75.03    60.00
800x600      119.97    75.00    60.32
720x576       50.00
720x480       59.94
640x480      120.01    75.00    59.94    59.93
`
There are two displays btw... it is only saying one is connected
All of this is in nvidia mode of course. In hybrid mode, both displays are shown as connected

I don't think it is a envycontrol issue. It seems to set it correctly. Can you run pacman -Qs nvidia and giving me the output?

Currently Nvidia mode is only supported under Xorg sessions
On Tue, Oct 31, 2023, 10:37 Vedang Patel @.***> wrote:

@D3vil0p3r https://github.com/D3vil0p3r
egl-wayland 2:1.1.13-1
envycontrol 3:3.0-1
libvdpau 1.5-2
nvidia 535.113.01-8
nvidia-utils 535.113.01-2
Currently on tty2 so I can't copy and paste the output. I have typed the
output from another device.
—
Reply to this email directly, view it on GitHub
https://github.com/bayasdev/envycontrol/issues/140#issuecomment-1787470549,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALY7IYMXR3NK5WZYEU745BDYCELKPAVCNFSM6AAAAAA53PDCDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGQ3TANJUHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm using an xorg session... the Wayland stuff is automatically installed with nvidia. I'm using qtile xorg.

@kamperemu I see, then you need to setup your display manager or xinitrc to do the xrandr thing that's documented on the project wiki

I'm using lightdm which is supported by envycontrol if I'm not wrong.

@D3vil0p3r egl-wayland 2:1.1.13-1 envycontrol 3:3.0-1 libvdpau 1.5-2 nvidia 535.113.01-8 nvidia-utils 535.113.01-2
Currently on tty2 so I can't copy and paste the output. I have typed the output from another device.

Here you have these packages but in your first post you reported to have:
local/nvidia-open-dkms 535.113.01-6
    NVIDIA open kernel modules

Which kernel are you using?
PS: you are using "conflicting" packages if my assumption here is true.

@D3vil0p3r I haven't mentioned a dkms kernel anywhere in this thread. I have tried both the regular and dkms kernels on fresh installs for debugging at one point. Currently, I don't have any conflicting packages.

@D3vil0p3r I haven't mentioned a dkms kernel anywhere in this thread. I have tried both the regular and dkms kernels on fresh installs for debugging at one point. Currently, I don't have any conflicting packages.

So what is your kernel?

The base kernel

The base kernel

I think you can try to remove nvidia package and install nvidia-open and use again envycontrol to check what happens.

After switching to another OS for a while (had some university work to do), the issue just randomly fixed itself when I returned today. I'm no longer able to reproduce the bug so I'm going to close this issue.

I am having same problem here, till yesterday everything was working fine, i reinstalled my arch and set up everything exactly like it was before, but now my main screen is not being used when using nvidia mode and the output is only being given to the monitor i have connected to hdmi port of my laptop.


[NoQA] [Lint] Enable no-invalid-this eslint rule

Details

With this PR, we are enabling the use of the no-invalid-this eslint rule. Related slack thread and context: https://expensify.slack.com/archives/C049HHMV9SM/p1682089468352009
Related PR: https://github.com/Expensify/eslint-config-expensify/pull/67
Fixed Issues

$ https://github.com/Expensify/App/issues/17971
PROPOSAL: https://github.com/Expensify/App/issues/17971#issuecomment-1522070175
Tests

Clone the fork.
Run npm install.
Run the command npx eslint --print-config files.json > config.json.
This will output all the eslint configuration in the config.json in the same directory.
Open the config.json file and ensure that the configuration for no-invalid-this is 'error'.

Additionally, you can also undo the changes made in the index.js file the run the npm run lint command to ensure that any issues are reported.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

N/A. This is for dev.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
N/A.

Can you run npm install and include both changes from package.json and package-lock.json

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@Prince-Mendiratta It's from https://github.com/Expensify/eslint-config-expensify/commit/5b216ccbc885d7e9e26dbd69de4efc4bdc5e2695 Let's fix the lint rule

It's weird that we didn't upgrade eslint-config-expensify since 2.0.31

I can create a thread on #expensify-open-source to discuss the issue and possible resolutions, what say?

That would be great. I'm sure I seen this brought up before.

Can you fix the unsigned commits

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.7-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.7-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Remove component.json and bower.json

I wonder if it makes sense to remove component.json and bower.json from the root of this repo. Component is no longer maintained and Bower recommends to use yarn + webpack.
Would this be too disruptive? Is the UMD build from unpkg.com CDN enough?

Maybe, I don't really care because I don't use it :/ but we probably don't want to break legacy apps that still use component.json so that might just be a major bump somehow.

Yeah same here. Maintaining those two files is actually not a big burden but I think they are useless these days. Cutting a new major version only for this doesn't make sense so maybe it's better to revisit later when there are other breaking changes (this will probably never happen 😄).


Set HOME

This won't work for development.  Just running HOME=/ go generate on my laptop will give me:
failed to initialize build cache at /.cache/go-build: mkdir /.cache: permission denied
main.go:1: running "go": exit status 1


ASCAT runs multiple times for normal/tumor/relapse

Anders Lundmark wrote: "when there is more than one tumour sample from a patient, alleleCounter will run on the normal sample once for each tumour sample"

Ah, ok. Thanks for letting me know. I will look into this, but it will be in January.
Cheers,
Malin

On 21 Dec 2016, at 11:38, Szilveszter Juhos<EMAIL_ADDRESS>wrote:
Assigned #155 https://github.com/SciLifeLab/CAW/issues/155 to @malinlarsson https://github.com/malinlarsson.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/SciLifeLab/CAW/issues/155#event-901408192, or mute the thread https://github.com/notifications/unsubscribe-auth/ADGC5fp3IJ3SCDiPG7FEfBWDXYJId2prks5rKQGvgaJpZM4LSzaA.

Malin Larsson, PhD
SciLifeLab Bioinformatics Long-term Support (WABI)
Department of Physics, Chemistry and Biology
House B, Room 2B:586, Campus Valla
581 83 Linköping
Telephone:<PHONE_NUMBER>
E-mail<EMAIL_ADDRESS>

Change input settings in RunAlleleCount so that it runs on single bam files instead of tumor-normal pairs. RunAlleleCount for normal, tumor1, tumor2 etc are independent jobs. So, input should be defined as for MarkDuplicates for example.

We need to check this as well:
The output of RunConvertAlleleCounts is tumor.BAF, tumor.LogR, normal.BAF and normal.LogR.
We want the output from RunConvertAlleleCounts in the VariantCalling/Ascat output folder.
But if there is more than one tumor, do we need to separate between the normal.BAF generated with tumor1 and tumor2, so that we have something like normal_tumor1.BAF and normal_tumor2.BAF etc?
Regarding normal.logR
We probably don't need to separate between the files generated from comparisons to different tumors, because we set all values in this file to 0.
Regarding normal.BAF
I dont think think normal.BAF is not affected by normalization (the values are calculated within the single bam file by #reads_alternative_allele/#total_reads_at_position.
so perhaps there is no need for separate normal.BAFs for the individual tumors.


T.proc doesn't match method(:bar).proc

This should match, but it doesn't.
→ View on sorbet.run
# typed: true
extend T::Sig

sig {params(b: T.proc.void).void}
def foo(b); end

sig {void}
def bar; end

foo(method(:bar).proc)
# Expected T.proc.returns(Sorbet::Private::Static::Void) but found Proc for argument b

This is intentional.
T.proc.returns(Sorbet::Private::Static::Void) is a Proc of known arity - it takes 0 arguments.
While method(:bar).proc is known to be a Proc but it's arity isn't known.

This is intentional.
T.proc.returns(Sorbet::Private::Static::Void) is a Proc of known arity - it takes 0 arguments.
While method(:bar).proc is known to be a Proc but it's arity isn't known.

I understand :-/
Is there another way than manually building a proc, where Sorbet can work? Because manually building a proc really gets ugly if there are parameters.
sig {params(s: String, i: Integer).void}
def bar(s, i); end

foo(proc { |a,b| bar(a, b) })

# This also seems to be not possible for Sorbet.
foo(proc { |*a| bar(*a) })

As said, I understand why.
I'm just asking if there's maybe a more beautiful alternative I didn't thought of.


EwmhDesktops: Set _NET_WM_ALLOWED_ACTIONS

Description
According to the "Extended Window Manager Hints" spec, _NET_WM_ALLOWED_ACTIONS is supposed to be set by the Window Manager to indicate to the clients, which operations are supported for a given window.
EwmhDesktops was only declaring supported operations on the root window via _NET_SUPPORTED, giving a superset of everything it supports.  But individual windows may have different operations.
For now, only _NET_WM_ACTION_CLOSE is added to _NET_WM_ALLOWED_ACTIONS.  Assuming that other operations, such as movement, resizing, etc. are handled by the layouts.  But it is not fully correct.  For example, it seems perfectly fine to allow floating windows to resize themselves.
ewmhFullscreen adds _NET_WM_ACTION_FULLSCREEN to _NET_WM_ALLOWED_ACTIONS for all managed windows, indicating that windows could request a full screen mode.
TOOD: Ideally, XMonad should remove the _NET_WM_ALLOWED_ACTIONS property from all windows when it is restarting or shutting down.  I could not figure out how to do it.
This change also fixes Firefox full screen, as suggested in this bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1273746#c7
Checklist

[X] I've read CONTRIBUTING.md

[X] I've considered how to best test these changes (property, unit,
manually, ...) and concluded: manually

[X] I updated the CHANGES.md file

This looks incomplete to me. For example, minimize is allowed and works; to manipulate it from xmonad you need a module, but you can do it from e.g. a panel applet just fine. We should probably review all the states to see which ones should be marked as supported. (For example, maximize should probably not be marked as supported even though you could use e.g. Multitoggle or X.L.Maximize, since neither one allows a window to request it.)

I can add more operations to the initial value of _NET_WM_ALLOWED_ACTIONS if you think they should be marked as supported as well.
One can look at this PR as a first step.  It does not prevent more operations to be added later.
So, I probably would not call it “incomplete”, if you just mean that more can be done.
At the moment, no operations are marked as supported at all.

One part that is actually missing is the removal of the _NET_WM_ALLOWED_ACTIONS property when XMonad exits.
It should not be a big problem, but, ideally, it would be nice to clean up.
Layouts receive ReleaseResources LayoutMessage, but there seems to be no hook for non-layout extensions.
Would it make sense to add a shutdownHook into XConfig, or did I miss something?

Would it make sense to add a shutdownHook into XConfig, or did I miss something?

There's no shutdown hook currently. I agree it would be useful; not particularly in this case though as I don't see the problem of keeping the properties set when xmonad exits/restarts.

I figured, if there is no active window manager, then it would seem right for _NET_WM_ALLOWED_ACTIONS to be absent.
If the user switches to a new window manager, this new WM will be responsible for setting the _NET_WM_ALLOWED_ACTIONS, if it supports the spec.  If it is just XMonad restarting, then _NET_WM_ALLOWED_ACTIONS  will be set again if ewmh is in the config.
It is an edge case, I agree.  Most users will never be in this situation.
For XMonad users, it might only matter when the user removes ewmh from their config and does not reboot the machine.
In any case, I think, advertising operations that are not really supported by the WM is unlikely to cause big UX issues.


Hero: Amon Koth Adjustment

Increase MS from 28 to 34
Increase WalkDistance from 0.85 to 1 to keep the speed of the walking animation about the same

Decided to keep 28MS, so closing issue


Need support for ignore https invalid cert

tm should generate playwright to ignore https invalid certificate.
https://playwright.dev/docs/api/class-testoptions#test-options-ignore-https-errors

Available in testman version 3.0.0


Python match/case keyword syntax coloring.

It's not a huge deal, but I think it would be nice to have match and case show up in purple.
Thanks.

Alrighty, I've opened it 👍

The PR has been approved. I don't know if you need to update anything, but here it is.

Cool, I'll update when the new version is released.


fix: s/repositiry/imageRepo to avoid auto replace in pipelines with cluster GCP registry

/approve


Project status

Hi, I'm just wondering what the status is regarding this project?
Seems exactly what I'm looking for. :)

Would appreciate an update, thanks.

Anyone?

Project assumed dead.


CC Support Certificate DACUM Prep

get DACUM supplies
prepare orientation including samples
define pre-work in advance of arrival
review Sprout Fund process and outcomes

Send out logistics and agenda for CC Certificate meeting this week


Use of Win32_Product WMI class causes msiinstaller to reconfigure all installed programs.

The two setup resources uses the Win32_Product WMI class which is not recommended for use because it causes the msiinstaller to reconfigure every installed application registered. This is very slow and risks issues with other applications.
https://support.microsoft.com/en-nz/kb/974524
The use of this class should be replaced with an alternative class.

Win32_Product still presents in:
MSFT_xSQLServerFailoverClusterSetup\MSFT_xSQLServerFailoverClusterSetup.psm1

That resource is deprecated. It will be deleted when the cluster functionality has been verified working in xSQLServerSetup.
So no more work should be done to this resource. I'm closing this issue since it is fixed in all others.
Thanks for catching this @luigilink


Add How to Use  Section  in Side Nav

Hi! I am Malavika , a GSSOC'21 Participant .
I would like to  add how to use section  to sidenav in homepage . Maybe add a heading "How to use too " above the steps to make it clear to the user.
Kindly assign this task to me.

This project is primarily meant to be used on larger screens like PC or MaC


ServerRequest getQueryParams doesn't allow to unset all QueryParams using withQueryParams

Hi,
I have a middleware which parses the lang query parameter and set's the language in the container. Afterwards it removes the lang parameter from the query array and gives this new request to the next handler. This works aslong as you have at least another query parameter.
if you don't have a query parameter this psr-7 implementation automatically parses Uri directly.
    public function __invoke(Request $request, RequestHandler $handler): Response
    {
        $query = $request->getQueryParams();

        // do somthing with the $query['lang] entry

        // cleanup Parameters
        unset($query['lang']);
        $request = $request->withQueryParams($query);

        return $handler->handle($request);
    }

When I later validate the request for "unwanted" parameters with something like:
public function __invoke(Request $request, Response $response)
{
  $params = $request->getQueryParams();
  if (isset($params['lang'])) {
    // throw exception or what ever.
  }
}

The $params has the lang parameter set again because of this line
https://github.com/slimphp/Slim-Http/blob/master/src/ServerRequest.php#L220
Not sure why slim/http does it this way but I think it's wrong, because then Request::withQueryParams([]) is pretty useless and doesn't work.
Not sure if there is a workaround...
thanks

I think the issue stems from this condition:
https://github.com/slimphp/Slim-Http/blob/master/src/ServerRequest.php#L215
It checks to see if the underlying array is empty. It is debatable whether we should do this or not to trigger the reparsing of the query params. @akrabat do you believe an empty array should retrigger parsing of the query params? I have no strong position on this.
A workaround would be to ensure the array is not empty when you modify it with your middleware:
    public function __invoke(Request $request, RequestHandler $handler): Response
    {
        $query = $request->getQueryParams();

        // do something with the $query['lang] entry

        // cleanup Parameters
        unset($query['lang']);

        // setup workaround flag to ensure array is not empty
        $query['QUERY_PARAMS_PARSED'] = true;

        $request = $request->withQueryParams($query);

        return $handler->handle($request);
    }

A workaround would be to ensure the array is not empty when you modify it with your middleware:
public function __invoke(Request $request, RequestHandler $handler): Response
{
    $query = $request->getQueryParams();

    // do something with the $query['lang] entry

    // cleanup Parameters
    unset($query['lang']);

    // setup workaround flag to ensure array is not empty
    $query['QUERY_PARAMS_PARSED'] = true;

    $request = $request->withQueryParams($query);

    return $handler->handle($request);
}

of course I can add a dummy parameter, but later in the code I validate all parameters and if we get an invalid parameter we drop the request. In this case the API endpoint as no GET parameters which are not globally handled (language in this case) so I wouldn't expect a GET parameter reaching the API endpoint controller. I would expect that's a middle ware is used for, preparing the request for the controller.


add resolvable identifiers for BEPs

it would be useful if there was a way to resolve individual BEPs to their appropriate page (be it on google docs or wherever).  e.g.:
https://bids.neuroimaging.io/BEP003 which would resolve to <google doc>
I'm not sure if github pages has a way to do this but it would be nice to have a more permanent identifier for each BEP.

indeed, that would be very useful. This jekyll plugin might be able to do the job: https://github.com/jekyll/jekyll-redirect-from#redirect-to
see this stackoverflow answer: https://stackoverflow.com/a/39735194/5201771

That plugin does allow for redirecting to external URLs. To redirect your example URL, create a file called tmwtga.html and add the following front matter:

---
permalink: /tmwtga
redirect_to:
  - http://www.example.com
---


Subset is not hidden when removeFromParent is called

I have followed the examples regarding subsets and hiding and have created my own code to create subsets per storey to hide and show storeys. The subsets are created correctly, as far as I can tell. If I set a material, the material is removed when I deselect a storey, and added when I select a storey. However, if I do not set a material for the subsets, the subsets are not hidden from view when I deselect a storey. That puzzles me, because I use nearly the same code as in the examples. The only difference is that I use the IfcViewerAPI, whereas in the examples IfcLoader is used.
These are the lines I have for adding and removing subsets:
if (checked) {
viewer.IFC.context.scene.add(subset);
} else {
await subset.removeFromParent();
}
And I create the subsets in this way:
const subset = viewer.IFC.loader.ifcManager.createSubset({
modelID: modelID,
scene: viewer.IFC.context.scene,
ids: childIDs, // ids of the child elements of the storey
removePrevious: false,
customID: storeyName,
});
An extract of my code can be found in commit 849284e9ed73798e446493e303c96f96b9b7ae3b on my repo ProtoIfcViewer. I wonder if I missed something.

You can delete a subset with subsetManager.removeSubset(modelID: number, material?: Material, customID?: string), or remove individual entities from a subset using subsetManager.removeFromSubset(modelID: number, ids: number[], customID?: string, material?: Material).

You can delete a subset with subsetManager.removeSubset(modelID: number, material?: Material, customID?: string), or remove individual entities (i.e. hide them) from a subset using subsetManager.removeFromSubset(modelID: number, ids: number[], customID?: string, material?: Material).

@brifitz thank you for the reply 😊 However, I'm not sure I follow:

First of, is subsetManager the IFC manager object in this scenario or are you accessing the subset manager with const subsetManager = ifcManager.subsets;? Is there a difference between the two and if so, what?
Secondly, I've tried both of these (removeSubset and removeFromSubset) before. But all that does is manipulate a subset I created. They don't seem to have any effect on the actual model. The methods ifcManager.showItems and ifcManager.hideItems were very clear on the purpose (+ they worked as expected 😅).

Just to clarify what I'm trying to achieve (which was easily done with the deprecated web-if from ThreeJS) is to hide/show parts of an existing model (I'm not looking to change colors for highlight, I already have a working function for that).
So far using the removeSubset and removeFromSubset hasn't worked. Granted I'm surely missing something in my logic, I just can't get see what that is.
Here are examples of what I've tried (see my initial post for details on the entire function):
const subset = ifcManager.createSubset({
  modelID: modelId,
  scene,
  ids,
  removePrevious: true,
  customID: itemId.toString(),
});
scene.add(subset);

ifcManager.removeSubset(modelId, undefined, itemId.toString());

ifcManager.removeFromSubset(modelId, ids, itemId.toString());

I've tried these, without the isHidden check. The expected result would be that the selected ids should not show, but they persist. Commenting out the "remove" functions and simply logging the ifcManager I can see that the subset is created correctly.
scene.add(subset);
console.log(ifcManager);

Then in the log IFCManager > subsets (SubsetManager) > subsets I have an object 0 - DEFAULT - 183 with:
bvh: false,
ids: Set(252), // 3 arrays
mesh: Mesh, // mesh object

Using removeSubset removes the subset as expected and with removeFromSubset the subset stays but the ids (set) is empty. Both of these seem to work as intended. The problem is that the subset has no effect on the model itself, compared to the showItems and hideItems methods, which hides and shows the items in ids (and array of express ID numbers).
Any thoughts on what could be missing/going wrong here? 🤓

You should replace the entire model with subsets at the start of your code and from then on only work with subsets instead of the model. You can see an example of how this is done here here - https://github.com/IFCjs/hello-world/tree/main/examples/web-ifc-viewer/visibility

@brifitz ok, thank you again for your reply! 👍
I will try that then, but overall that makes it a lot more complicated to just show/hide than with the previous methods that were available. Do you know why they were removed?
This way I have to know in advance what subsets the user will want... that might not always be feasible 🤔
Take for example a large building model, with multiple storeys with walls, windows, floors etc.  ThreeJS web-ifc showItems and hideItems methods)  with a set of ids.
Just so I understand correctly 🤓

If you turn the model into a subset at the start, then passing a set of ids to of entities to hide to removeFromSubset is effectively the same as hideItems and it can be used to hide items on the fly for example hiding a set of entities that the users has selected by passing their expressIds to removeFromSubset. To undo the hiding, just recreate the subset with the full set of ids.
I'm not aware of why showItems and hideItems were removed, maybe it was to standardize the way of doing things around subsets, rather than allowing operations with both the model and subsets.

@brifitz yes, I realized that this must be the way to use it just after writing my previous reply.
The only thing that's unclear at this point is how to "turn the (entire) model into a subset" 🤔
Below is an excerpt of my attempt to "turn the model into a subset" in my IFC loading method. It doesn't work, and I wasn't expecting it to either, I just wanted to show the initial test. The only issue I can see here is if I have to include all express IDs of all children, i.e. doing a recursive ids.push(child.expressID) type function. That ids array could get ridiculously big on real world building models. Then this doesn't seem very feasible anymore 😅
[...]
const modelId = model.modelID;
const ifcModel = await ifcManager.getSpatialStructure(modelId);
const ids = [ifcModel.expressID];

console.log(modelId); // 0 for now since there is currently only one (1) model in scene for dev
console.log(ids); // one id (120) in an array

ifcManager.createSubset({
  scene,
  modelID: modelId,
  ids,
  applyBVH: true,
  removePrevious: true,
  customID: `model-${modelId}`,
});

scene.add(model);
[...]

This would effectively produce a subset, with a custom id of model-0. So it can be properly identified. However, the subset only contains the IFCPROJECT id (120). In turn creating a new subset to "hide", again, does nothing here. Since, from what I'm starting to gather, I would have to temporarily remove the ids from that subset, which at the moment is just one number (the IFC Project express ID).
The only way I see this working now is if the model has a subset of all available express IDs in the entire model.
I haven't found any existing method for getting all recursive children express IDs with the web-ifc.
I've made my own recursive child express ID function which works for highlighting, but I don't think that would work on the entire model (if I'm looking ahead when there will be real world models... the array of IDs could get in the tens of thousands or more maybe).
Regarding removing the "show/hide" methods, if any developers get wind of this... please bring that back 😂 It was an extremely clean and clear way of dealing with this very scenario (showing/hiding parts of the model).
PS. @brifitz thank you for the feedback/dialogue 🙌

See this for an example of how you turn the entire model into a subset. I believe that example does everything you need.
As you can see, the ids for the entire model are taken directly from the internal expressID array in getAllIds() so there is no need for recursive parsing of the tree.
By the way, there is no need to use the model id as part of the customID, as internally the model id you passed in during the call to createSubset() is already being used to identify subsets. You could use something like 'full-model' for the customID instead. Internally, subsets are identified using strings with the following format - {modelID} - {material.uuid} - {customID}

@brifitz that looks like a good approach 👍 However when I tested it and logged out the result of getAllIds I noticed that there were ids missing.
What I'm doing is showing the model as expandable groups in a sidebar when selecting the model in a list of items from the ThreeJS scene, on the side (this list is also in a sidebar and it switches to the model content when selecting the model).
It's divided in the following way:
[MODEL_NAME_FROM_SECENE_ITEMS_LIST]

storeys

grouped types (e.g. walls, windows etc)

group items (i.e. all individual walls, windows ets)

I'm also filtering out all IFCSPACE types. All of these have express IDs but some don't have any geometry data. ifcModel.geometry.attributes.expressID.array seems to only get ids of items that have geometry data.
I did however find something in the ifcApi that allowed me to get the express ID of every single item in the model, ifcAPI.LoadAllGeometry(modelId). The reason for wanting all ids is so you can click one item in the list and from there recursively get all child ids, to hide/show/highlight etc 🤓
interface ModelGeometry {
  _data: Vector<FlatMesh>;
  _size: number;
}

const loadModelGeometry = await ifcManager.ifcAPI.LoadAllGeometry(modelId);
const modelGeometry = loadModelGeometry as unknown as ModelGeometry;
const geometryData = modelGeometry._data;
const ids = Array.from(Object.values(geometryData), (item: FlatMesh) => item.expressID);

// ids now has all ids in model, including those without any data in geometry.

ifcManager.createSubset({
  modelID: modelId,
  ids,
  applyBVH: true,
  scene,
  removePrevious: true,
  customID: "model-subset",
});

model.removeFromParent(); // taken from https://github.com/IFCjs/hello-world/blob/main/examples/web-ifc-viewer/visibility/app.js#L34
scene.add(model);

While this does create a subset with all the ids in the model, still, nothing happens when removing ids from the subset. My best guess is because the model in itself hasn't changed, so I'm still just removing ids from a subset, but the original is still there.
model.removeFromParent(); doesn't seem to have any effect 🤷♂
The only difference for me with the example is that I'm using the web-ifc-three and my scene ("viewer" in example) is a ThreeJS scene, so I can't do the same as in the function replaceOriginalModelBySubset.
This is getting close though, I can almost taste it 😅 So far all thanks to the help of @brifitz 🙌

Hey @m1900 I just uploaded a hiding example for web-ifc-viewer. You can check it out here, and the deployed version here. Regarding the rest, feel free to open new issues for other questions / problems. 🙂 Soon we'll focus our resources into web-ifc-three and web-ifc-viewer, so hopefully all the issues will go away. Cheers!


Fix Health API

Coverage decreased (-0.01%) to 96.246% when pulling d11c7621e6227b45bcf6cc4504b53c68c06a2f84 on fix_health_api into 25abdfa3499de9634f15f5fa89910293744db924 on master.

Coverage decreased (-0.01%) to 96.46% when pulling fdaa67fec34f42a21085e06b67c4931b099d067d on fix_health_api into 4e6c6210f56b65972a0a9ae5af61022404e6a665 on master.

Coverage decreased (-0.01%) to 96.46% when pulling 86853c0117020958b17dd4249a70d3d887534e56 on fix_health_api into 4e6c6210f56b65972a0a9ae5af61022404e6a665 on master.


fix(forge): create decode constructor args

Motivation
Closes #8995
when we populate the CREATE tx and attempt to decode args from constructor we assume that the constructor args start after bytecode len:
https://github.com/foundry-rs/foundry/blob/3ff3d0562215bca620e07c5c4c154eec8da0f04b/crates/script/src/transaction.rs#L170
In mentioned issue, for https://github.com/isle-labs/isle-contract/blob/fix-audit-issue/scripts/DeployGlobals.s.sol which deploys an uups proxy
contract UUPSProxy is ERC1967Proxy {
    constructor(address _implementation, bytes memory _data)
        ERC1967Proxy(_implementation, _data)
    {}
}

the sliced data contains extra (assume constructor sig) which results in
65676174652063616c6c206661696c6564
000000000000000000000000663f3ad617193148711d28f5334ee4ed07016602
0000000000000000000000000000000000000000000000000000000000000040
0000000000000000000000000000000000000000000000000000000000000000

Since the first constructor arg is address 663f3ad617193148711d28f5334ee4ed07016602, decoding input fails with "Failed to decode constructor arguments"  at
https://github.com/foundry-rs/foundry/blob/3ff3d0562215bca620e07c5c4c154eec8da0f04b/crates/script/src/transaction.rs#L173-L180

Solution

proposed solution is to padd &creation_code[bytecode.len()..] and then remove first 32 bytes, e.g. in sample above:

65676174652063616c6c206661696c6564
000000000000000000000000663f3ad617193148711d28f5334ee4ed07016602
0000000000000000000000000000000000000000000000000000000000000040
0000000000000000000000000000000000000000000000000000000000000000

padded as
00000000000000000000000000000065676174652063616c6c206661696c6564
000000000000000000000000663f3ad617193148711d28f5334ee4ed07016602
0000000000000000000000000000000000000000000000000000000000000040
0000000000000000000000000000000000000000000000000000000000000000

and then resulting in
000000000000000000000000663f3ad617193148711d28f5334ee4ed07016602
0000000000000000000000000000000000000000000000000000000000000040
0000000000000000000000000000000000000000000000000000000000000000

wasn't able to find a minimal repro without using the uups / ERC1967 proxies

looks like the actual issue is that UUPSProxy is identified as ERC1967Proxy?
code:
function deployGlobals() internal broadcast(deployer) returns (IsleGlobals globals_) {
    globals_ = IsleGlobals(address(new UUPSProxy(address(new IsleGlobals()), "")));
    globals_.initialize(governor);
}

trace:
  [1442215] DeployGlobals::run()
    ├─ [0] VM::startBroadcast(0x3C44CdDdB6a900fa2b585dd299e03d12FA4293BC)
    │   └─ ← [Return]
    ├─ [1248187] → new IsleGlobals@0x663F3ad617193148711d28f5334eE4Ed07016602
    │   └─ ← [Return] 6223 bytes of code
    ├─ [51501] → new ERC1967Proxy@0x2E983A1Ba5e8b38AAAeC4B440B9dDcFBf72E15d1
    │   ├─ emit Upgraded(implementation: IsleGlobals: [0x663F3ad617193148711d28f5334eE4Ed07016602])
    │   └─ ← [Return] 136 bytes of code
    ├─ [68824] ERC1967Proxy::initialize(0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266)
    │   ├─ [68441] IsleGlobals::initialize(0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266) [delegatecall]
    │   │   ├─ emit Initialized(governor_: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266)
    │   │   └─ ← [Stop]
    │   └─ ← [Return]
    ├─ [0] VM::stopBroadcast()
    │   └─ ← [Return]
    └─ ← [Return] ERC1967Proxy: [0x2E983A1Ba5e8b38AAAeC4B440B9dDcFBf72E15d1]

error:
Failed to decode constructor arguments contract=Some("ERC1967Proxy") signature=constructor(address,bytes) is_create2=false constructor_args=65676174652063616c6c206661696c6564000000000000000000000000663f3ad617193148711d28f5334ee4ed0701660200000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000000

looks like the actual issue is that UUPSProxy is identified as ERC1967Proxy?

Ah, thank you, yep, doesn't look right. Going to check why this happen

related to deploying with cbor_metadata set to false, no code change required


Update availability-region.md

Moved to private repo: https://github.com/MicrosoftDocs/ai-builder-pr/pull/1000. Closing this PR.


Feature: dependencies for fluttermergebot

The merge bot works pretty well, but it would be nice if we could tell it about dependencies between PRs using text in the description or an issue tag.  For example:  https://github.com/flutter/engine/pull/13986 was auto-merged before https://github.com/flutter/engine/pull/14076 which caused some problems and necessitated further reverts.
Some sort of dependency expression like AFTER: 14076 would have been great here
@liyuqian @dnfield

Oh no.  What have I started.

More seriously, that's entirely doable.  The code mainly lives here:
https://github.com/flutter/cocoon/blob/master/app_dart/lib/src/request_handlers/check_for_waiting_pull_requests.dart

\cc @keyonghan related to the new scheduler and cq implementation.

Isn't it sufficient for humans to just not label the PR autosubmit until the dependencies have landed? This seems like a lot of code for something that really requires human supervision anyway.


Use local font if available

Closes #20

@lijunle Does this look fine for you?

Thanks @choffmeister , it is awesome!


kubevirt.kubevirt.io/kubevirt   hangs in deleting

just following the intro here:
https://kubevirt.io/user-guide/docs/latest/administration/intro.html

It is probably this custom resource that was causing the namespace to not clean up

Namespace is hung again. kv was patched to no affect, what else can I look at?

This worked, this should be added to the documentation imo (:
@azaiter you're a hero
https://github.com/kubevirt/kubevirt/issues/1491

I will leave this open until KubeVirt lets me know if they want to take any action as a result (:

@mjschmidt see https://github.com/kubevirt/kubevirt/issues/2605#issuecomment-522447858
A PR on improving docs (waiting for KubeVirt undeployment after deleting the CR) would be great.
Not sure if want to make such a cleanup script as mentioned in the other issue "official" though... @fabiand ?

This is related to kubernetes/kubernetes#60807 and it seems that finally somebody is looking at it.
Until then it's probably worth it to at least link to the script from our user-guide.

So yeah honestly, I am not really sure either. I just know when I ran this guy's script it did actually go through and clean everything up

The PR is here:
https://github.com/kubevirt/user-guide/compare/master...mjschmidt:patch-1

Seems that this is still happening
Welcome to KubeVirt Push Button Trial

Kubernetes and KubeVirt have been pre-installed for you. You may use
the guide at https://kubevirt.io/labs/ to explore more.

Found a problem? Please report it to
https://github.com/kubevirt/cloud-image-builder/issues.

Versions
--------
OS:         CentOS Linux release 7.7.1908 (Core)
Kubernetes: v1.16.3
KubeVirt:   0.23.0

[piranzo@instance-5 ~]$ sudo .-i
sudo: .-i: command not found
[piranzo@instance-5 ~]$ sudo -i
[root@instance-5 ~]# su .- cent^C
[root@instance-5 ~]# su - centos
Last login: Fri Nov 15 10:26:03 UTC 2019 from <IP_ADDRESS> on pts/0
[centos@instance-5 ~]$ kubectl -n kubevirt patch kv kubevirt --type=json -p '[{ "op": "remove", "path": "/metadata/finalizers" }]'
kubevirt.kubevirt.io/kubevirt patched
[centos@instance-5 ~]$ export RELEASE='v0.23.0'
[centos@instance-5 ~]$ kubectl delete -f https://github.com/kubevirt/kubevirt/releases/download/${RELEASE}/kubevirt-cr.yaml
kubevirt.kubevirt.io "kubevirt" deleted
[centos@instance-5 ~]$ kubectl delete -f https://github.com/kubevirt/kubevirt/releases/download/${RELEASE}/kubevirt-operator.yaml
namespace "kubevirt" deleted
customresourcedefinition.apiextensions.k8s.io "kubevirts.kubevirt.io" deleted
clusterrole.rbac.authorization.k8s.io "kubevirt.io:operator" deleted
serviceaccount "kubevirt-operator" deleted
clusterrole.rbac.authorization.k8s.io "kubevirt-operator" deleted
clusterrolebinding.rbac.authorization.k8s.io "kubevirt-operator" deleted
deployment.apps "virt-operator" deleted

And the console 'hangs'
If pressing CTRL-C and attempt to delete the kubevirt 'ns' it complains too:
[centos@instance-5 ~]$ kubectl delete ns kubevirt
Error from server (Conflict): Operation cannot be fulfilled on namespaces "kubevirt": The system is ensuring all content is removed from this namespace.  Upon completion, this namespace will automatically be purged by the system.

I met the same problem, is there any solution for this?

 This works for some people locally,
but not for others (incl the kubevirt/demo)


Docker continues writing to rotated container log files

First, I'd appreciate if someone could verify they see the same behavior.
It appears that once the daily logrotate of the docker container logs runs, docker continues to write logs to the rotated file instead of the current log. This is the behavior whether or not logrotate is configured with copytruncate.
e.g.
-rw------- 1 root root           0 May 30 03:33 ed5c737c96c0f50ee5632ff28634da64276daaa659bdcae8fbfa4331598f4edc/ed5c737c96c0f50ee5632ff28634da64276daaa659bdcae8fbfa4331598f4edc-json.log
-rw------- 1 root root<PHONE_NUMBER> Jun 17 16:23 ed5c737c96c0f50ee5632ff28634da64276daaa659bdcae8fbfa4331598f4edc/ed5c737c96c0f50ee5632ff28634da64276daaa659bdcae8fbfa4331598f4edc-json.log-20150530

-rw------- 1 root root          0 May 30 03:36 e28ddc4a010b6878d74b687eb43e9a2241ac12949180982bc4868344f2b313c2/e28ddc4a010b6878d74b687eb43e9a2241ac12949180982bc4868344f2b313c2-json.log
-rw------- 1 root root<PHONE_NUMBER> Jun 17 16:24 e28ddc4a010b6878d74b687eb43e9a2241ac12949180982bc4868344f2b313c2/e28ddc4a010b6878d74b687eb43e9a2241ac12949180982bc4868344f2b313c2-json.log-20150530

In both cases a container was started on May 30, the log was rotated that night, and the container continues to write to the May 30 log file instead of the rotated one.

Thanks for brining this to our attention. We're investigating.

This is a known issue: https://github.com/docker/docker/issues/7333. The underlying problem is that there is no way of signalling to docker to stop writing to a file and start a new one. This means when logrotate moves the file the FD is still the same and so it just carries on writing to the now moved file.
The suggestion seems to be that you need to use the syslog driver, but it looks like this needs to be configured on a per-container basis which is obviously not idea.

I tell a lie, you can use the syslog driver as an option when starting the docker daemon (-log-driver="syslog"). There is also support for fluentd, gelf (logstash) and journalctl drivers.

Seems like fluentd is a good option, I saw some writings in their blog. Btw fluentd itself has a good performance and smaller footprint then logstash. Also primarily fluentd is log shipper.

14 авг. 2015 г., в 21:12, SillyMoo<EMAIL_ADDRESS>написал(а):
I tell a lie, you can use the syslog driver as an option when starting the docker daemon (-log-driver="syslog"). There is also support for fluentd, gelf (logstash) and journalctl drivers.
—
Reply to this email directly or view it on GitHub.

I figure a good short term fix is to use syslog+logrotate (as it's not far off what is there already) and maybe logstash later (as it looks like there is plenty of enhancements mentioning logstash). If the project owners are ok with it I'm happy to take on this issue and put together a pull request for the syslog+logrotate solution.

Created a pull request that does the syslog based immediate solution, tested it with logrotate --force and seems to work. Puts logs in /var/log/docker/docker.log, and archives them (as per mesos) to /var/log/docker/archive.

Merged #648 with docker syslog driver to address this issue for now. More discussion on improving logging infrastructure happening in #646


always report unable to find xxx in remotes

The above picture discribe the question for example

Hi @zhangjinpeng66
Thanks for your report.
I think you are adding the wrong endpoint URL. You are adding https://conan.io/center, but this is not correct, please check:

https://docs.conan.io/2/reference/config_files/remotes.html
https://github.com/conan-io/conan-center-index

Also, by default it is not necessary to add the ConanCenter remote, because it comes configured by default. But if you want to add it is:
conan remote add conancenter https://center.conan.io

Note the API enpoint is center.conan.io but not conan.io/center (that is the Web app only)

This has been closed by https://github.com/conan-io/conan/pull/14531, but please don't hesitate to ask if you have any further question, you can also create new tickets.


Defect: Failed images support not enabled during tests

Sorry for not using the template but I believe this issue should be mostly used for discussion.
Is the --disable-auto-cleanup string passed at runtime for the failed images tests?
Is the --enable-error-checking=all string passed at configure time for mpich?

Interesting...

yes -disable-auto-cleanup is passed to mpiexec when running failed images tests. Do you have evidence to the contrary?
As for --enable-error-checking=all being passed at configure time for MPICH, I'm not 100% sure. The only circumstance under which we install MPICH as part of the installation process is when using install.sh. I'm guessing, as of right now, that we don't pass --enable-error-checking=all at configure time for MPICH.

Is MPICH being built with --enable-error-checking=all a required condition for failed images to work properly? Do you know how to detect if MPICH was built this way?
Right now, the logic for enabling failed images is:

GCC/GFortran >= 1? Yes: try to enable failed images & proceed to 2. No: disable failed images
Are the required proposed/experimental MPI functions available? Yes: Enable failed images, No: do not enable failed image support

In addition, failed images tests are only run if OPENCOARRAYS_DEVELOPER=TRUE (or 1 or YES or ON)

According to the MPICH wiki --enable-error-checking=all is on by default: https://wiki.mpich.org/mpich/index.php/Fault_Tolerance#Usage .. double checking the output of ./configure for MPICH now, to confirm

  --enable-error-checking=level
      Control the amount of error checking.
        no        - no error checking
        runtime   - error checking controllable at runtime through environment
                    variables
        all       - error checking always enabled (default)


Fail when reading large symbols

Fails for len > 8 with com.amazon.ion.IonException: value too large for Java long
see

https://github.com/amzn/ion-java/blob/master/src/com/amazon/ion/impl/IonReaderBinaryRawX.java#L875
https://github.com/amzn/ion-tests/blob/master/iontestdata/good/typecodes/README.md
good/typecodes/T7-large.10n

in which package does tthe function is present??

Your question is unclear to me.  The first link in this issue is to the line where the exception is thrown.  Symbol IDs larger than 8 bytes however seem like very uncommon scenario, so this issue will rarely be encountered in production systems.

protected final long readULong(int len) throws IOException
{
long    retvalue = 0;
int b;
switch (len) {
default:
throw new IonException("value too large for Java long");
case 8:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 7:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 6:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 5:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 4:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 3:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 2:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 1:
if ((b = read()) < 0) throwUnexpectedEOFException();
retvalue = (retvalue << 8) | b;
case 0:
// do nothing, it's just a 0 length is a 0 value
}
return retvalue;
}
here the maximum number of test cases is 8 than how you are expecting to be len > 8

to are givin

Fails for len > 8 with com.amazon.ion.IonException: value too large for Java long
see
* https://github.com/amzn/ion-java/blob/master/src/com/amazon/ion/impl/IonReaderBinaryRawX.java#L875

* https://github.com/amzn/ion-tests/blob/master/iontestdata/good/typecodes/README.md

* good/typecodes/T7-large.10n

you are trying to enter the number which is greater than than the number of test cases

Could you clarify what you mean by this?:

you are trying to enter the number which is greater than than the number of test cases

The default case handles len values that are larger than 8.

Could you clarify what you mean by this?:

you are trying to enter the number which is greater than than the number of test cases

The default case handles len values that are larger than 8.

yeah i was telling that in  functionthe maximum len >=8 otherwise it will default case will handle it

Could you clarify what you mean by this?:

you are trying to enter the number which is greater than than the number of test cases

The default case handles len values that are larger than 8.

yeah i was telling that in  functionthe maximum len >=8 otherwise it will default case will handle it

sry its len <= 8 other wise default case will handle


Update the codegen scripts to use the repos from the workspace rather than the local GOPATH

This is not a pretty solution, but until there is good enough support for generating code with genrules, this makes the building a bit easier and means that we're using the same versions as the rest of the code is being built against. This should also allow the cluster-registry repository to live anywhere, not just in GOPATH/src/k8s.io/cluster-registry
I attempted to test this with clean and dirty repositories, but if you have time to patch in and test, I would appreciate it. You may want to bazel clean --expunge first.
cc @madhusudancs @font

Note that this currently has an issue with generated defaults and deepcopies which I'm looking into.

OK, this should work for all generated files now.

/assign @madhusudancs

Is this exercised in CI?

It is not exercised in CI; we haven't set up CI for this repository yet. It's on my todo list.

@font @madhusudancs @ericchiang I'm planning to submit this today if there are no additional comments.

@madhusudancs PTAL, I updated the script structure a bit to make the temporary directory deletion cleaner.

/lgtm


NETOBSERV-1017 extract timebased indexKeys

In order to get top Pod / Service talkers this PR implements IndexKeys as an array for timebased stage.
It also add the capability to index on non string fields using ConvertToString utils

Thanks @KalmanMeth :partying_face:

/approve

@KalmanMeth @jpinsonneau should we mark that as a breaking change? (the API is preserved however the output fields are different if I understand correctly (operation_key and operation_result being removed)
I'm not concerned for netobserv, but other FLP users

@KalmanMeth @jpinsonneau should we mark that as a breaking change? (the API is preserved however the output fields are different if I understand correctly (operation_key and operation_result being removed)
I'm not concerned for netobserv, but other FLP users

Added the label on that PR. Check https://github.com/netobserv/flowlogs-pipeline/pull/450#discussion_r1264665272 discussion

@jpinsonneau For completeness we should mark it as a breaking change (although you did maintain back compatibility for the current implementation, indicating deprecation).


Add link to shared jenkinslib repo

This is with added credentials, but these may not be needed as the jenkinslib repo is public.
This change facilitates the use of our new jenkinslib of functions so we can utilise groovy functions across all TDR Jenkins jobs and keep code DRY.
This was done with help from @TomJKing

Looks OK

Thanks! Should I leave this un-merged for now so it doesn't potentially interfere with the testing or can I merge since it needs explicitly deployed from DockerHub anyway?

Merging on behalf of Loki.


⚠ ClamAV has degraded performance

In 91d20b4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in 1151ee2.


superdns in error loop

My superdns container logs have tens or hundreds of MBs of entries:
[ERROR] Recovered from panic in server: "dns://:53" runtime error: invalid memory address or nil pointer dereference

The router (Clearfog) has a working Internet connection and DNS. Clients can route traffic to the Internet but cannot resolve DNS via the router.
; <<>> DiG 9.10.6 <<>> @<IP_ADDRESS> google.com
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 710
;; flags: qr rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;google.com.                    IN      A

;; Query time: 18 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Mon Jul 10 20:27:49 PDT 2023
;; MSG SIZE  rcvd: 39

Restarting the container, the full docker compose stack, or the entire router did not resolve the issue.

After rebooting my device clock was wrong. After syncing the clock DNS started working for clients.
I do not know if this was the initial problem.

@rgov i think so as the  configuraiton uses dns over https which is time sensitive for certificate dates. i think we need to ensure the clearfog buildroot is running ntpdate to stay online.

the panic is fixed now at least and theres stacktraces with errors from dns if there is a panic now in the default config.


WW-5503 Removes unused dependencies

WW-5503

Looks like the byte-buddy dependency management may still be required

Yeah, looks like. Trying to use mvn dependency:analyze to figure out what can be removed


New release with bug fix

I had mentioned a bug to support around mid-June which was promptly fixed in your code base during this commit:
https://github.com/PaymentRails/php-sdk/commit/3f529ed3e60b35ff8261dbbba80f34980bd94799
Just wondering if there will be a tagged release with this fix that we can update through composer? I am not sure if using the master branch of your package on our production server is the best idea since it may be prone to future bugs.

If you don't want to use master, you should be able to use a specific
version like 2.0.4 (latest) or an older version that contains that fix
On Tue, Jul 30, 2019 at 6:39 PM harpster604<EMAIL_ADDRESS>wrote:

I had mentioned a bug to support around mid-June which was promptly fixed
in your code base during this commit:
3f529ed
https://github.com/PaymentRails/php-sdk/commit/3f529ed3e60b35ff8261dbbba80f34980bd94799
Just wondering if there will be a tagged release with this fix that we can
update through composer? I am not sure if using the master branch of your
package on our production server is the best idea since it may be prone to
future bugs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PaymentRails/php-sdk/issues/10?email_source=notifications&email_token=ADZ6VQ4OFFY2JH72QX7LGVDQCC7ITA5CNFSM4IIA5O32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCNWADQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADZ6VQ2WMHR5BPU5DVD2Y73QCC7ITANCNFSM4IIA5O3Q
.

But 2.0.4 does not contain the fix does it?
https://github.com/PaymentRails/php-sdk/compare/2.0.4...master

You are right it does not contain the fix, for now you can use
paymentrails/php-sdk:2.0.5.x-dev
On Thu, Aug 1, 2019 at 1:16 PM harpster604<EMAIL_ADDRESS>wrote:

But 2.0.4 does not contain the fix does it?
2.0.4...master
https://github.com/PaymentRails/php-sdk/compare/2.0.4...master
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PaymentRails/php-sdk/issues/10?email_source=notifications&email_token=ADZ6VQ6CEQBTXTNU4QEJQZTQCMK53A5CNFSM4IIA5O32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3LJGFI#issuecomment-517378837,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADZ6VQ4U2TSS75PVEKGE4JDQCMK53ANCNFSM4IIA5O3Q
.


Investigate: dropdown -> dropup when at end of page or end of table

The last two/three action menus in tables often break out of the page container.
Pagination bottom dropdown often breaks out of page section

Both examples are visibility/accessibility issues.

Do we have a way to manually override this? I've been trying to apply styling to the page but without success.
At a glance I suspect it's an issue of grid display and absolute elements since the grid becomes scrollable. Using overflow or z-index has no effect, nor can I make it drop up due to it being in a PF4 React Table.

In core, nothing is self-aware as we can't use JS. [Popover] (https://patternfly-react.surge.sh/documentation/react/components/popover) has already figured this out. The issue should be resolved in a similar way to pf-c-popover. Need to move to react.
Having said that, this issue exposes and bug. The footer pagination dropdown needs to be a .pf-c-dropdown.pf-m-top 2726

Issue moved to patternfly/patternfly-react #3784 via ZenHub


Integrating UIkit

Hi,
just planning to integrate uikit-frontend (https://github.com/uikit/uikit) but I dont know what is best way to do it. What is your suggestion?
Thanks!

Hi @regisaih
I'm guessing you need to remove angular material first and everything that depends on it.
This involves (at least) running bower uninstall angular-material.
Then you have to remove the module from angular/main.js.
Other services such as toast.service.js and dialog.toast.js also need to be removed.
Then you'd just need to follow the installation steps for uikit!
Let me know if this answers your question

Thanks @jadjoubran. Perhaps angular/material folder have to remove aswell. Maybe I create angular/uikit folder and copy all needed less and js files there. Jquery is dependency and is easiest to install with bower. And font files I can copy directly to public/fonts.

yep!
But if you're not using Angular then I don't think this starter package will be useful for you. Especially that you'll be loosing the gulp tasks and other features

Ok, I'm not going to remove angular. But there is not much pure angular frontend frameworks(?) Angular material is too limited for my needs.

@regisaih I totally understand.. I just don't want to recommend my starter if you're not going to use Angular
Good luck :smile:


Time-series data

Great work! I enjoyed reading your paper.
I am just wondering whether this can be applied to time-series data?
thanks

@gireeshkbogu
Did you try with time-series data?


chore(main): release 1.5.0

:robot: I have created a release beep boop
1.5.0 (2024-08-22)
Features

utiliza o endpoint da object store diretamente (3db4bd1)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.5.0
:sunflower:


Random play, "playlist radio" and no songs recommendations after playlist ends

🧐 Have you read the FAQ and viewed similar issues?

[X] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
Germany
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify: <IP_ADDRESS>3.ge7902f05
- Windows: Win 10 pro 22h2
- PowerShell: 5.1.19041.2364

📝 Description
Random play in liked songs issue

Turn on random play on liked songs
Play thru around 5-6 songs (sometimes doesn't work at all)
It stops the music - it is not possible to fix it by hitting the play button and it looks like no next song got picked

The playlist radio issue

Turn on "playlist radio" function on any playlist
Play button doesn't work at all.

No songs recommendations after playlist ends

Go thru whole playlist
Music stops playing instead of spotify starting to play songs based on playlist

"playlist extension" seems to be breaking the liked songs playlist too.
Those issues seems to be related to each other that's why im reporting them as one bug report.
I just updated the spotify from old version (older GUI) - did the clean install of the spotify so i think those function should work without the premium account.
Edit: Radio function when turned on from song instead of playlist works - which makes this even more weird.
Have a nice day
📸 Screenshots
No response

none of your problems can be reproduced for me, try to check the result on the same version but without spotx
or use a version downgrade

I have the same issue, also occurs when trying to play songs directly from artists' pages.

I think this problem is related or similar to this


fix(app): npm script for clean syntax corrected

corrects the syntax for the npm clean script
fixes #78

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   99.43%   99.43%
=======================================
  Files           6        6
  Lines         353      353
  Branches       56       56
=======================================
  Hits          351      351
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97b45c...f72108c. Read the comment docs.


Comments misplaced for unified diff view

Steps to Reproduce:
On this PR - https://github.com/arjun27/Miniblog.Core/pull/2 - a comment is not positioned correctly on the unified diff view. Changing to side-by-side view fixes the issue.

Extension version: 0.6.0
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:22:55.268Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 2, 4

Memory (System)
8.00GB (0.32GB free)

Process Argv

Screen Reader
no

VM
0%

@arjun27 This looks like a duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/160, let's track it there.


Consider for next news letter:  Rust gamedev interviews

https://rustgamedev.com/episodes  Saw this and was surprised that it wasn't included in the newsletter already, then realized it was brand new.  Haven't actually listened to it yet though, so maybe it's not good.  XD  Will listen to it and see how it is.

Moving to the next newsletter's coordination issue.


Clear Cache doesn't clear cache?

I have a site using APC with the c5 cache, the /files/cache folder had over 11k files in it, hitting the clear cache button in the dashboard did nothing, so im not sure whats going on (not familiar with zend cache)

Any chance you had the site running with the default file backend for the cache before you switched to APC (ie. actually declared 'apc' in site_config.php)? If so, those files you're seeing in the file-system might have been generated pre-switch, and now 'clear cache' is only clearing the cached files in memory (APC), and not touching the old, defunct files in the actual cache folder.
Are the 'last modified' dates on the files in the /cache folder all v. old? That would confirm that they were pre APC-switch, and therefore not being hit by the clear cache function when you run it.

Nope, it is all recent,  and apc has been on since the site went live
On Dec 18, 2011 4:53 PM, "Ant Rodgers" <
<EMAIL_ADDRESS>wrote:

Any chance you had the site running with the default file backend for the
cache before you switched to APC (ie. actually declared 'apc' in
site_config.php)? If so, those files you're seeing in the file-system might
have been generated pre-switch, and now 'clear cache' is only clearing the
cached files in memory (APC), and not touching the old, defunct files in
the actual cache folder.
Are the 'last modified' dates on the files in the /cache folder all v.
old? That would confirm that they were pre APC-switch, and therefore not
being hit by the clear cache function when you run it.

Reply to this email directly or view it on GitHub:
https://github.com/concrete5/concrete5/issues/375#issuecomment-3197185

Weird. I'd say that maybe you haven't actually got APC specified correctly in the config and it's still defaulting to file system cache but, if that were the case, hitting clear cache should clear all files out then.
Do you have access to the apc.php diagnostic script? Will be wherever APC was installed on the server. Usually you need to copy this from this folder to somewhere publicly accessible, then load it up in your browser. This should tell you if APC is actually doing its job properly and caching stuff + if hitting the clear cache button in C5 is actually doing anything.

Apc is being used by c5, it didn't clear that entire cache either actually,
had to manually clear it
On Dec 18, 2011 5:48 PM, "Ant Rodgers" <
<EMAIL_ADDRESS>wrote:

Weird. I'd say that maybe you haven't actually got APC specified correctly
in the config and it's still defaulting to file system cache but, if that
were the case, hitting clear cache should clear all files out then.
Do you have access to the apc.php diagnostic script? Will be wherever APC
was installed on the server. Usually you need to copy this from this folder
to somewhere publicly accessible, then load it up in your browser. This
should tell you if APC is actually doing its job properly and caching stuff

if hitting the clear cache button in C5 is actually doing anything.

Reply to this email directly or view it on GitHub:
https://github.com/concrete5/concrete5/issues/375#issuecomment-3197472

Right....just took a leap and upgraded one of my <IP_ADDRESS> sites to 5.5beta3 (latest in Github) and, first off, the upgrade worked perfectly (phew) and, second, clearing cache works fine for me. I do run APC on the server, but only as opcode cache...for full page caching, block caching, etc... i've got Memcache set up, and it seems to be respecting the cache clears just fine. No phantom files popping up in the files/cache either (save images).

I think its an issue with huge caches (11k files is a lot)


Panicking and checked push methods

Hi,
I've added push_(front|back)_or_panic and try_push_(front|back) methods that panic or return error instead of overwriting the buffer.
Panicking allows to validate the expected invariant that the buffer shouldn't overflow. Checked versions could be used to implement backpressure and postpone elements queuing.

Hi, thanks for your contribution! I always thought about adding a try_push_back/try_push_front variant, I was just waiting for somebody to express interest in it before implementing it, so I'm definitely accepting your proposal!
I'm not fully sold on push_back_or_panic/push_front_or_panic though. Is buffer.push_back_or_panic() really much more convenient than buffer.try_push_back().unwrap() to deserve its own method?

Hi, thanks for your contribution! I always thought about adding a try_push_back/try_push_front variant, I was just waiting for somebody to express interest in it before implementing it, so I'm definitely accepting your proposal!
I'm not fully sold on push_back_or_panic/push_front_or_panic though. Is buffer.push_back_or_panic() really much more convenient than buffer.try_push_back().unwrap() to deserve its own method?

I think panic variants are questionable but they allow to express intention in concise form.
In non test code I use .expect instead of unwrap to document the expected condition.
Besides in my current project I'm experimenting with unstable `#[expect(..., reason="...")] attributed and enabled the majority of lints in "clippy::restrictions" - to try them. The category includes expect_used lint.
So to use expect in non test code I have to write something like
fn not_fallible_send(send_queue: &mut CircularBuffer[Message; MAX_MESSAGE_BUFFERS_IN_POOL], message: Message) {
       #[expect(clippy::expect_used, reason = "we don't use error because we expect that message pool size equals to send queue capacity")
        send_queue.try_push_back(message).expect("send_queue capacity is not exceeded")
}

This approach is good for documentation purposes but if try_push_back is used multiple times per module it becomes a burden.

@andreacorbellini , I've updated the PR.

@andreacorbellini , could you review the updates in this PR?

Hey apologies for the silence during these weeks. I've been quite busy with a lot of things. I'm going to take another look at this PR now

Hi, thanks for your contribution! I always thought about adding a try_push_back/try_push_front variant, I was just waiting for somebody to express interest in it before implementing it, so I'm definitely accepting your proposal!
I'm not fully sold on push_back_or_panic/push_front_or_panic though. Is buffer.push_back_or_panic() really much more convenient than buffer.try_push_back().unwrap() to deserve its own method?

I think panic variants are questionable but they allow to express intention in concise form.
In non test code I use .expect instead of unwrap to document the expected condition.
Besides in my current project I'm experimenting with unstable `#[expect(..., reason="...")] attribute and enabled the majority of lints in "clippy::restrictions" - to try them. The category includes expect_used lint.
So to use expect in non test code I have to write something like
fn not_fallible_send(send_queue: &mut CircularBuffer[Message; MAX_MESSAGE_BUFFERS_IN_POOL], message: Message) {
       #[expect(clippy::expect_used, reason = "we don't use error because we expect that message pool size equals to send queue capacity")
        send_queue.try_push_back(message).expect("send_queue capacity is not exceeded")
}

This approach is good for documentation purposes but if try_push_back is used multiple times per module it becomes a burden.

I do not think this is the right approach to the problem: if you check the Rust standard library, there are many foo() methods with a try_foo() variant, but you do not see any foo_or_panic() variant. For example, HashMap has insert() and try_insert(), but there's no panicking equivalent. Having a panicking method in a library to signal anything other than a bug is generally an anti-pattern, and I would like to stick with the patterns from the standard library (in particular, the patterns from std::collections) as much as possible, to keep the learning curve low for those who are already familiar with Rust.
I understand you're using Clippy's expect_used lint, but I think that adding an _or_panic() method is a workaround to make life with that lint easier, more than anything that actually helps with simplifying code logic. Perhaps disabling that lint is a good option in your case: there's nothing inherently wrong with using expect() in production code, if all you want is a panic.
The documentation for expect() says: "Because this function may panic, its use is generally discouraged", so the use of expect() is discouraged because it panics, but a panic is exactly what you want, so the use of expect() is justified. The point of the Clippy lint is to detect those cases that cause a panic, where better error handling may be possible. If Clippy was smarter, it would also flag uses of push_back_or_panic() and encourage you to use try_push_back() for the same reason.
In any case, you could also come up with your own utility method that can be called from anywhere in your code:
fn push_back_or_panic<const N: usize, T>(buf: &mut CircularBuffer<N, T>, item: T) {
    #[expect(...)]
    buf.try_push_back(item).expect(...)
}

And that can also be done via a trait, or via a newtype.

@andreacorbellini , I've removed _or_panic methods and formatting changes.

Thank you for your contribution!


Return key value on read and modify

Fixes #101

I noticed that on modify, terriform still shows this
~ key          = "i9bzPw.xaTJvw:PgatfRwoImndQzm-qwBtB9_JoaCi0Aj7brpP5aIq6qQ" -> (known after apply)
```

We probably need a modifier to say it wont change.


Remove fuse

Coverage remained the same at 87.652% when pulling 1264f5d2801a8d315d20298341087a955652f082 on remove-fuse into 04ec3f71d546a53727072d4f808cadae3dc617b9 on master.