Fail to authenticate user with Multiple LDAP Connections

Laravel Version: 5.4
Adldap2-Laravel Version: 3.0.0
PHP Version: 7.0.11

Description:
Follow the instructions in Using Multiple LDAP Connections, the user within the other-connection will failed to authenticate.
Steps To Reproduce:

Follow the instructions in Using Multiple LDAP Connections.
Try to login with an user within the other-connection.

Reason
The resolver is cached for the first connection setting. See the code. So that the resolver with the first connection setting will always be returned even you change the connection config later:
Config::set('adldap_auth.connection', 'other-connection');

Solution suggestion

Return new resolver every time:

trait UsesAdldap
{
    ...

    public function getResolver()
    {
        $resolver = config('adldap_auth.resolver', Resolver::class);

        return new $resolver($this->getLdapProvider());
    }

    ...
}

Find some way to call setResolver(null) after change the config value of  adldap_auth.connection.

Thanks @superbull, looking into this now.
I believe this is due to not creating a new resolver every time it's called:
https://github.com/Adldap2/Adldap2-Laravel/blob/master/src/Traits/UsesAdldap.php#L50-L60
Will have a fix out soon.

This might be difficult to implement... Using multiple connections could break other features.
For example, if you're using the NoDatabaseUserProvider, and you authenticated through a second connection, you'd be logged out on the second request because it would utilize your default resolver to retrieve the user by their ID:
https://github.com/Adldap2/Adldap2-Laravel/blob/master/src/Auth/NoDatabaseUserProvider.php#L9-L21

Any progress on this?

@ethanhann No unfortunately. Haven't been able to spend much time on implementing this, but definitely accepting PRs!

@stevebauman
Any updates on this ?

Hi @psraghul, no unfortunately. still nothing yet. This is difficult to implement and document. Accepting PR's as always though if someone has time to take a crack at this.

I am going to take a stab at this. I think the only way would be to save the connection used in the session store.
For the record, the old documentation can be found here: https://github.com/Adldap2/Adldap2-Laravel/blob/f025d674c3573e97a43a15d5efca1279e9d7e90e/docs/auth/multiple-connections.md

@stevebauman any progress on this issue?

My boss decided we should move this down the priority list. I am still trying to get to it.

I think you'll first have to determine what user is authenticating and set the authentication connection at run-time before calling Auth::attempt() in the build in Laravel LoginController.
After authentication has been successful, as @yakatz has said, you'll need to store the connection name in the session, and set it at run-time depending on the authenticated user (using a middleware likely).
LoginController:
public function login(Request $request)
{
    $connection = str_contains($request->email<EMAIL_ADDRESS>? 'connection-b' : 'connection-a';

    Config::set('ldap_auth.connection', $connection);

    if (Auth::attempt($request->only(['email', 'password'])) {
        // ...

        Session::put('ldap.connection', $connection);

        return redirect('/');
    }
}

Middleware:
/**
 * Handle an incoming request.
 *
 * @param \Illuminate\Http\Request $request
 * @param \Closure                 $next
 *
 * @return mixed
 */
public function handle($request, Closure $next)
{
    if ($connection = Session::get('ldap.connection')) {
        Config::set('ldap_auth.connection', $connection);
    }
}

I haven't tried this, but it should work :tm:

It is more complicated than that for us because one of our LDAPs is IPA and the other is Windows, so the entire ldap_auth config needs to be made multi-connection aware. (In the mean time, I need to override each config item manually.)

@yakatz Oh definitely, that would be much harder to manage...

Closing this one out. I could allow this and have configuration values for it, but there's so many things that would need to be configurable. It would be extremely hard to offer this type of configuration with different scenarios. In my mind it's better to develop this on the application side.
For example, say we have multiple LDAP auth points.

What if one isn't reachable / goes down?
Should both LDAP auth points be used in the same request? Or should they have separate endpoints to authenticate against?
What if a dev is using just a username for authentication and there's a username conflict? How would we handle this in the backend when synchronizing / importing users?
How would we determine who belongs to which domain?
How would we debug each LDAP auth point? (This is already a pain for current users with one domain, as they currently find it difficult to debug as is)

I'll absolutely consider PR's and any suggestions on implementation, but I can't invest time into this myself because I personally wouldn't be able to test it easily, have it configurable and document the entire process so it's easier for other developers.


Dialog Disappears on Device Rotation

When I perform these sequences of events, the dialog on screen disappears:
Sequence 1:

Long Click on code item in list
Click on Rename
Orientation Change

Sequence 2:

Long Click on code item
Click on Remove
Orientation Change

Confirmed on Play store version.


SceneGraph

Are there any plans to get this to work in SceneGraph, where all network traffic has to happen in Task nodes, instead of messageport while loops?
Although quite a bit can be reused, it would require significant re-architecturing, so I can imagine that you might not be inclined if you don't have a specific need for it yourself.

I think it would be good addition to the library.  It originally came from a non-SceneGraph implementation, so assumes 'm' is the GlobalAA reference.  It wouldn't be difficult to refactor that part out and wrap the whole of the library into a Task.
The open issue is which Task pattern to use...  I've implemented both short-lived Task threads which launch and exit, as well as long-lived Task threads that have a messageport and while loop.  I've even implemented events going from SceneGraph UI thread to the main BrightScript thread.  Also, there is a question of whether to have a global instance of the Task, perhaps referenced by m.global, or to give each component a local instantiation of the task.  There are pros and cons to each approach.
Perhaps the most flexible would be a long-lived thread listening to field events from a messageport.  Tracking events would be serialized by the firmware and sent off one at a time.  This will reduce the task management overhead and risk of garbage collection before a finished tracking request.

We've got our own internal Google Analytics library which I wrote a while back, which is also based on non-SceneGraph. I think I'll rewrite that to SceneGraph and let you know which approach I took there. Might be useful if you ever decide to modify this library.

PR #10 adds a simple wrapper which invokes GAMP from scene graph

Cool! I'll be sure to check it out.


fail to run the application

Steps to reproduce the problem

clone the default branch
follow Readme to try running the application, which way(npm start/docker run/docker compose) doesn't matter

What is the expected result?
successfully running the application
What happens instead?
fail to run the application, error:
ssertion failed: You must provide either mongoUrl|clientPromise|client in options
/home/ubuntu/cla-assistant/node_modules/connect-mongo/build/main/lib/MongoStore.js:119
            throw new Error('Cannot init client. Please provide correct options');
            ^

Error: Cannot init client. Please provide correct options
    at new MongoStore (/home/ubuntu/cla-assistant/node_modules/connect-mongo/build/main/lib/MongoStore.js:119:19)
    at Function.create (/home/ubuntu/cla-assistant/node_modules/connect-mongo/build/main/lib/MongoStore.js:136:16)
    at /home/ubuntu/cla-assistant/src/server/src/app.js:170:31
    at /home/ubuntu/cla-assistant/node_modules/async/dist/async.js:3638:28
    at replenish (/home/ubuntu/cla-assistant/node_modules/async/dist/async.js:443:21)
    at /home/ubuntu/cla-assistant/node_modules/async/dist/async.js:448:13
    at eachOfLimit$1 (/home/ubuntu/cla-assistant/node_modules/async/dist/async.js:474:34)
    at awaitable (/home/ubuntu/cla-assistant/node_modules/async/dist/async.js:211:32)
    at eachOfSeries (/home/ubuntu/cla-assistant/node_modules/async/dist/async.js:810:16)
    at awaitable (/home/ubuntu/cla-assistant/node_modules/async/dist/async.js:211:32)

Used browser and browser version?
Any other tested browsers/devices(OK/FAIL):

It's my fault to use a malformed mongoUrl. But it's a pity the error is not obvious.

@zhangyangyu good point and thanks for providing the solution.
Let me reopen the issue to either:

better document this
or provide a better error message

Hmm, trying to catch the error for mongoose.connect. But strangely, either try to catch it in the callback or use then/catch works. Doesn't learn Node but doing a lot of search, all doing the same but the methods just not work. :(


Replace old console

Description
This PR replaces the old console with a much better one.
It adds the following features to the new console:

Ability to resize the console window.
Ability to close the console via a button on the top-right.
Ability to clear the console via a button left of the close button.
Cleaner look(?)
Removes the hacked method of adding spacing to the "Console" title.

Missing the coloring feature. A future PR will address this.
Testing
Ver. 0.25.0
Did actions to prompt the console as before. Successfully shows console with past logs. Resizing UI in any way works successfully. The text also adjusts to accommodate the new size. Sizes the UI to be narrow. Using the commandline, type "for i = 1, 40 do print(i) end". Can use the scroll wheel to use to see the parts of the string that is hidden. Press the return key, successfully ran and printed 1, 2, 3 ... and is visible on the console. Scrolling in the console works successfully. Pressing the clear button clears the console. Pressing the close buttons successfully close the console.

Okay, I'm prepared to merge this as it is most certainly an improvement over the current console.
A future enhancement could be changing the mouse cursor somehow over the edges to indicate that it scales and that somehow the 'edge' draggable area is a bit wider.
I haven't studied exactly how resizing works but it can be a bit difficult to catch the 'edge' to drag it.
Other than those possible enhancements, this is fantastic work. Thanks a lot for your contribution!


Added redshift support & added Dialect.SupportLastInsertID interface method

What

Added a new "redshift" dialect
Added interface method Dialect.SupportLastInsertID, redshift does not support LastInsertId
Updated create_callback to check if the dialect supports LastInsertId: scope.Dialect().SupportLastInsertID()

Why

Redshift is very useful large scale data storage, but the create table syntax is not compatible with Postgresql
Only a subset of data types are supported
Redshift doesn't support LastInsertId so we need to check for that when inserting new records.

Example usage
package main

import (
    "os"
    "fmt"
    "github.com/jinzhu/gorm"
    _ "github.com/jinzhu/gorm/dialects/redshift"
)

type Product struct {
    ID uint `gorm:"DISTKEY IDENTITY(1, 1)"`
    Code string
    Price uint
}

func main() {
    // Get the database connection from the environment
    // Ex:
    //   db_connection_string := "postgres://root:password@products.crtfrkqszbch.us-east-1.redshift.amazonaws.com:5439/products?sslmode=verify-ca&sslrootcert=./redshift-ssl-ca-cert.pem"
    //
    // The redshift PEM is stored here:  https://docs.aws.amazon.com/redshift/latest/mgmt/connecting-ssl-support.html#connect-using-ssl
    //
    db_connection_string := os.Getenv("DB_CONNECTION")
    db, err := gorm.Open("redshift", "postgres", db_connection_string)
    if err != nil {
        panic("failed to connect database: " + db_connection_string + "\n" + err.Error())
    }
    defer db.Close()
    // db.LogMode(true)

    db.DropTable(&Product{})

    // Migrate the schema
    db.AutoMigrate(&Product{})

    // Create
    db.Create(&Product{Code: "L1212", Price: 1000})

    // Read
    var product Product
    db.First(&product, 1) // find product with id 1
    db.First(&product, "code = ?", "L1212") // find product with code l1212

    // Update - update product's price to 2000
    db.Model(&product).Update("Price", 2000)

    // Delete - delete product
    db.Delete(&product)
}

Hi @jinzhu!
Please merge this pr into gorm!
Thanks,
Glenn

Closing this PR out

Why was this not merged? This is exactly what I need aswell.

@gnagel Found an issue with the redshift implementation. When it creates a table it throws an error when it creates the indexes:
(pq: SQL command "CREATE INDEX idx_example_deleted_at ON "example"(deleted_at) " not supported on Redshift tables.)


Pull Request: East Mississippi Community College

@JMTaylorDev Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


S10 Plus Does not work L1

Bug report
Your Environment

Netflix add-on version: <v1.12.2-Leia>
Operating system version/name: <Android 10>
Device model:

Used Operating system:

[X] Android
[ ] iOS
[ ] Linux
[ ] OSX
[ ] Raspberry-Pi
[ ] Windows

Describe the bug

L1 widevine does not work, My phone accepts netflix in full hd and this addon does not work HD
Expected behavior

Actual behavior

Steps to reproduce the behavior

I open the video and this message appears
Link : https://drive.google.com/file/d/1Aton4LFinzeqc0YqIQyC8MI-Vyuz3HyN/view?usp=drivesdk

Possible fix

Debug log
<!--- MANDATORY ATTACH/LINK A LOG:

 https://drive.google.com/file/d/1Aw82pu2NtMjQdfblR_GPHTWEMEUTcl-d/view?usp=drivesdk

Bug report
Your Environment

Netflix add-on version: <v1.12.2-Leia>
Operating system version/name: <Android 10>
Device model: S10 Plus - SM-G975F

Used Operating system:

[x]  Android
[ ]  iOS
[ ]  Linux
[ ]  OSX
[ ]  Raspberry-Pi
[ ]  Windows

Describe the bug
L1 widevine does not work, My phone accepts netflix in full hd and this addon does not work HD
Expected behavior
Actual behavior
Steps to reproduce the behavior

I open the video and this message appears
Link : https://drive.google.com/file/d/1Aton4LFinzeqc0YqIQyC8MI-Vyuz3HyN/view?usp=drivesdk

Possible fix
Debug log

Bug report
Your Environment

Netflix add-on version: <v1.12.2-Leia>
Operating system version/name: <Android 10>
Device model: S10 Plus - SM-G975F

Used Operating system:

[x]  Android
[ ]  iOS
[ ]  Linux
[ ]  OSX
[ ]  Raspberry-Pi
[ ]  Windows

Describe the bug
L1 widevine does not work, My phone accepts netflix in full hd and this addon does not work HD
Expected behavior
Actual behavior
Steps to reproduce the behavior

I open the video and this message appears
Link : https://drive.google.com/file/d/1Aton4LFinzeqc0YqIQyC8MI-Vyuz3HyN/view?usp=drivesdk

Possible fix
Debug log

Apply wiki instructions:
Video Stream only at 540P (SD) on Android device https://github.com/CastagnaIT/plugin.video.netflix/wiki/FAQ-(Audio%2C-Video%2C-Subtitle%2C-Other)#video-stream-only-at-540p-sd-on-android-device

Apply wiki instructions:
Video Stream only at 540P (SD) on Android device https://github.com/CastagnaIT/plugin.video.netflix/wiki/FAQ-(Audio%2C-Video%2C-Subtitle%2C-Other)#video-stream-only-at-540p-sd-on-android-device

Thanks for responding, I just needed to change the ESN as you said, thanks.

Thanks for responding, I just needed to change the ESN as you said, thanks.


vuex-persistedData()

I'm using the vuex-persistedstate plugin, but for some reason i18n is not stuck in the store, any ideas?

Hi @viktorvillalobos,
Thank you for your request. I did take a quick look at the vuex-persistedstate plugin, but did not yet really understand how the plugin achieves its functionality.
The problem might arise due to us using a separate vuex store module (i18n by default) to save the translation data. This might not be handled by the reducer introduced with the vuex-persistedstate plugin and thus not saved in the local storage.
However, I will have to get back to you at a later time, as I am going to be off for some days in the mountains.

Hi @tikiatua , thanks for response.

The problem might arise due to us using a separate vuex store module (i18n by default) to save the translation data.

This is the problem, anyway happy holidays.

Closing this, as the problem arises due to the way huex-persistedstate handles persistence.


Repurpose cf-typography?

Or at the least we should slap a warning on it that cf-core has replaced the need for it. Done
At some point we should convert this repo into more advanced typographic patterns.

Status update: this is in progress by @virginiacc :smile:

What's the status of this issue?

I think this is done, in that everything we wanted to move to cf-typography has been moved there. That said, I think that much of the stuff that was moved to cf-typography still remains in the various Less files of cfgov-refresh, from which it needs to be culled.

Sounds like this issue should be moved to cfgov-refresh and closed here?

Agreed.

Living on DF-1405 task in Jira!


Reversing a nested drop

I'm having trouble figuring out how to move something that's was a root into inside an item back out again.
My storage locations start out as all roots.  I can nest them pretty easily:

For example, how do I move "box" to be a root again?    I guess I can do that, just wanted to ask here if there's a way to do that.  Seems like an operation should be reversable.
Thx.

You can drag it above or below an existing root node - while dragging hover the node but place your mouse near the top or bottom of the node. When you drop the node will be positioned above or below the hovered node.

I have not been able to do that using Chrome or Firefox.
On Tue, May 25, 2021 at 9:14 AM Ivan Bozhanov @.***>
wrote:

You can drag it above or below an existing root node - while dragging
hover the node but place your mouse near the top or bottom of the node.
When you drop the node will be positioned above or below the hovered node.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vakata/jstree/issues/2529#issuecomment-847859379, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEXIQNI7LCC42Z7VWN3KG3TPOPCFANCNFSM444TI7FA
.


Class translation.cache.repository does not exist

Hello. I use laravel 5.5, after install waavi/translation 2.3.x and try to appla publish command i see error
$ php artisan vendor:publish --provider="Waavi\Translation\TranslationServiceProvider"
[ReflectionException]
Class translation.cache.repository does not exist
Please help me.

Tried on a fresh install of laravel 5.5 and it worked fine. Here is what I did:
laravel new fresh
cd fresh
composer require waavi/translation
php artisan vendor:publish --provider="Waavi\Translation\TranslationServiceProvider"

Did not get any errors.


gridsome create is not working for default theme

Description
cli create is not creating a new site from default theme
Steps to reproduce
gridsome create
Expected result
New Site
Actual result
Error
Environment
Node 12.16.1
Paste the information here as shown by gridsome info
➜ gridsome create site
❯ Clone https://github.com/gridsome/gridsome-starter-default.git
❯ Update project package.json
❯ Install dependencies
Error: Command failed: git clone https://github.com/gridsome/gridsome-starter-default.git /Users/james/Projects/gridsome/site --single-branch
nullnull
    at Object.task (/usr/local/share/.config/yarn/global/node_modules/@gridsome/cli/lib/commands/create.js:42:17)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

@JWeis Could you share the output of gridsome info?

Sorry about that. Here it is:
  System:
    OS: macOS 10.15.3
    CPU: (4) x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
  Binaries:
    Node: 12.16.1 - ~/.nvm/versions/node/v12.16.1/bin/node
    Yarn: 1.22.0 - /usr/local/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v12.16.1/bin/npm
  Browsers:
    Chrome: 80.0.3987.132
    Firefox: 71.0
    Safari: 13.0.5

I got it working.   Thanks!

I'm getting the same error, uninstalled / reinstalled xcode CLI, still have the same issue. Here is my gridsome info:
  System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    npm: 6.9.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 77.0.3865.75
    Firefox: 68.6.0
    Safari: 13.0.3
  npmGlobalPackages:
    @gridsome/cli: 0.3.2

is there a solution for this? i have the exact same problem. i removed xcode cli completely, nothing.

is there a solution for this? i have the exact same problem. i removed xcode cli completely, nothing.

is there a solution for this? i have the exact same problem. i removed xcode cli completely, nothing.
brew doctor

I am having the same issue on windows.
`
System:
OS: Windows 10 10.0.19042
CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
Binaries:
Node: 14.15.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.14.8 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Spartan (44.19041.906.0), Chromium (89.0.774.77)
`


[FLINK-30812][yarn] Fix uploading local files when using YARN with S3

What is the purpose of the change
Hadoop versions starting from 3.3.2 have reworked copying local files to remote using S3AFileSystem. Now it requires the passed local Hadoop Path to have a scheme specified.
Brief change log
YarnApplicationFileUploader will append file:// scheme for local path if none specified
Verifying this change
I manually tested on a local single-node Hadoop 3.3.4 cluster with fs.defaultFS pointing to a local Minio S3 server. Creating a Flink YARN session failed before the fix, but worked after.
Also added new unit test in YarnApplicationFileUploaderTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
The serializers: (yes / no / don't know) no
The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) yes
The S3 file system connector: (yes / no / don't know) no

Documentation

Does this pull request introduce a new feature? (yes / no) no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not applicable

@gaborgsomogyi Can you take a look?

I'm having vacation on the whole week w/o computer. Next week I can start w/ this...

Rebased to fix failing CI tests

@MartijnVisser are you fine w/ the PR? I'm merging if you say to...

@flinkbot run azure


Add default configuration file locations

Is your feature request related to a problem? Please describe.
How to add extra rules if necessary with false-positives without scripting.
Describe the solution you'd like
If and when there are configuration files found relative to the --path,  automatically override without having to use the --config-path or --additional-config parameters. Proposegitleaks.toml or gitleaks-additional.toml respectively.
Describe alternatives you've considered
When running against several repositories, using the --additional-config=gitleaks.toml requires every repo to have those files, and causes an exception if missing:

no such file or directory

Additional context
Ideally, the gitleaks --path <working_directory> would find configuration file(s) if they exist and apply them.
cc @zricethezav

@scottschreckengaust great suggestion. This will be added in the upcoming version 8.
  -c, --config string          config file path
                               order of precedence:
                               1. --config/-c
                               2. (--source/-s)/.gitleaks.toml
                               if --config/-c is not set and no .gitleaks.toml/gitleaks.toml present
                               then .gitleaks.toml will be written to (--source/-s)/.gitleaks.toml for future use

available in v8.0.0


Lost styling, wanted or not ?

First I want you to know that Squire is very great, clean et simple.
But,I experienced 2 space behaviour and I don't know if it's wanted or not.
Lost styling when removing all line chars.

Set specific font styling, like red color and bold.
Write many lines
Choose one of them, press backspace to remove all chars
=> Now if you type again, you lost the red color and bold styling

Lost styling when double press enter in bullet list.

Set specific font styling, like red color and bold.
Write many lines and make a bullet list
Then, press 2 times "enter"
=> Now if you type again, you lost the red color and bold styling

You can see what I mean here: http://g.recordit.co/K5ZsMO9x0D.gif
So, is it wanted behaviours ? :)

I can see arguments both ways. I'm quite happy with the current behaviour, and changing it to the other behaviour is tricky in WebKit/Blink due to their inability to focus empty text nodes.

Ok so, it's wanted behaviours ;)
Thanks for the reply. I'll close this issue.


FileAppend serialize and deserialize breaks freezing

Description
When you have a File Append Transaction and want to send it somewhere unfrozen, you will serialize it and deserialize it afterward.
Then when you try to freeze it, it won't get frozen and the transaction id will be lost.
Maybe the issue can be connected with: #2167
Steps to reproduce

Run the following snippet:

/* imports */
const {
  Client,
  AccountId,
  Transaction,
  FileAppendTransaction,
  TransactionId,
  Timestamp,
} = require('@hashgraph/sdk');

async function run() {
  const accountId = AccountId.fromString('0.0.2159149');
  const client = Client.forTestnet();

  // Create a File Append Transaction
  let transaction = new FileAppendTransaction().setTransactionId(
    TransactionId.withValidStart(accountId, Timestamp.fromDate(new Date()))
  );

  // Serialize
  const transactionBytes = transaction.toBytes();

  // Deserialize
  transaction = Transaction.fromBytes(transactionBytes);

  // Freeze
  transaction = transaction.freezeWith(client);

  // Verify the bug
  console.log(transaction.isFrozen() === false);
  console.log(transaction.transactionId === null);

  client.close();
}

run();

Additional context
No response
Hedera network
No response
Version
2.51.0
Operating system
None

According to HIP-745 freeze should work like what you experienced.

Freezing a transaction in a dApp merely sets a flag against the transaction object, the network is not aware of the transaction at this point. Developers are sometimes confused, believing that if the transaction is frozen, it can’t ever be modified, but this isn’t strictly true. A wallet (or anyone receiving the serialised transaction) can deserialise the transaction and create a new one from the serialised data, this new transaction will be unfrozen and subject to being modified by the wallet. When the purpose of freezing a transaction is misunderstood, it leads to a false sense of security.

Keeping the transactionId of the transaction is tricky. The implementation of the chunked transactions is not the same as the standard transaction. When you call toBytes of transaction with chunks in the SDK, you create an empty transaction list and populate it with n chunk transaction. We generate the real transaction IDs in that transaction list. The one of the original "main" transaction is mostly used like a dummy transaction id. You can also get the transactionId from the receipt when you execute the transaction. I think this is implemented the same way across all the SDKs and it's not just a JS SDK issue.
Will this be a blocker for the transaction tool team. If so I will talk with our team how we can resolve this.

If we deserialize a transaction, it will not be frozen, which is okay. The problem is that the freezeWith method is not freezing the transaction. As you can see in the snippet, the transaction is frozen after the deserialization but when I check if it is frozen, false is returned. This blocks the signing functionality.
For the transaction id, I understand, it is empty, because I don't set any content so no chunks are created.

It is a blocker for our functionality as we cannot use the File Append, which is used together with File Create and File Update.

fixed in https://github.com/hashgraph/hedera-sdk-js/pull/2532


2.0.3 Performance Regression

Please see https://github.com/vapor/vapor/issues/1101

Just to confirm, this does not appear to be happening on macOS Sierra.
Engine: 2.1.3
Vapor: 2.1.2
~$ wrk -t 4 -c 128 -d 10 http://localhost:8080/hello
Running 10s test @ http://localhost:8080/hello
  4 threads and 128 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     0.90ms  130.49us  13.97ms   92.81%
    Req/Sec    17.66k     3.60k   23.53k    54.46%
  710091 requests in 10.10s, 56.89MB read
Requests/sec:  70303.63
Transfer/sec:      5.63MB
~$

Looks right to me

As far as I can tell, this appears to be an issue w/ wrk not properly handling multiple writes to the stream. @vzsg @vi4m were you able to recreate this issue on tools other than wrk?

Hm, I think @vzsg did it with multiple versions of Engine though? I'm not sure why different versions would cause different results with wrk in particular

But it's totally possible I'm missing something too.

@mcdappdev Prior to Engine 2.0.3, if the response was less than 2048 bytes in length, it would be sent entirely in one call to libc.send().

Running wrk on macOS sierra against Vapor running in Linux VM:
~$ wrk -t 4 -c 128 -d 10 http://<IP_ADDRESS>:8080/hello
Running 10s test @ http://<IP_ADDRESS>:8080/hello
  4 threads and 128 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   109.77us   34.20us   5.30ms   95.09%
    Req/Sec    16.18k     3.62k   18.64k    82.79%
  196749 requests in 10.10s, 22.70MB read
  Socket errors: connect 0, read 0, write 0, timeout 1
Requests/sec:  19480.57
Transfer/sec:      2.25MB

Running wrk from inside the Linux VM Vapor is running in:
parallels@ubuntu:~/Desktop/Speedtest$ wrk -t 4 -c 128 -d 5 http://localhost:8080/hello
Running 5s test @ http://localhost:8080/hello
  4 threads and 128 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency    41.91ms   43.22ms   1.00s    99.80%
    Req/Sec   100.38     35.86   161.00     60.00%
  501 requests in 5.03s, 59.99KB read
  Socket errors: connect 0, read 0, write 0, timeout 4
Requests/sec:     99.70
Transfer/sec:     11.94KB

Seems likely that the implementation of wrk on Linux is not continuing to read from the socket until it gets the entire response.

Ah, that makes a lot of sense.

Well I'm sorry it turned out to be a glitch in the tool not in your code!

Closing this issue since all indication I can find points to this being a bug in wrk. I'd attempt to find a workaround so that Vapor's wrk scores on Linux still look good, but this seems like a waste of time considering Server APIs will hopefully be coming soon anyways.

I was running wrk on macOS in all tests, never inside the container, or perhaps I'm misunderstanding something about the experiments above.
(Those Swift Server APIs cannot arrive soon enough.)

I just tried to benchmark using Apache Benchmark (ab), the results got even weirder. It seems that ab gets stuck after each sent response, waiting 30 seconds until timeout – rendering this benchmark pretty useless.
What's really strange is that Node doesn't have this symptom.

Another benchmark tool, vegeta works fine however, and shows the slowdown between 2.0.2 and 2.1.3:
Latencies     [mean, 50, 95, 99, max]  2.173735ms, 2.313166ms, 2.78579ms, 2.878385ms, 5.671501ms  // 2.0.2
...
Latencies     [mean, 50, 95, 99, max]  33.34679ms, 50.587758ms, 50.835336ms, 50.937763ms, 61.981379ms  // 2.1.3

Just to clarify @tanner0101 - I run my tests using wrk client on macOS, not linux, same as @vzsg
Also, I see, that you run your vapor server on parallels - could you try with ubuntu docker image too? Our production servers run on docker, so for me it's the only way to scale it in production.

@tanner0101 I think the issue is related to the fact you don't init your socket with TCP_CORK or you don't call send with MSG_MORE.
tcp(7)
TCP_CORK (since Linux 2.2)
              If set, don't send out partial frames.  All queued partial
              frames are sent when the option is cleared again.  This is
              useful for prepending headers before calling sendfile(2), or
              for throughput optimization.

send(2)
MSG_MORE (since Linux 2.4.4)
              The caller has more data to send.  This flag is used with TCP
              sockets to obtain the same effect as the TCP_CORK socket
              option (see tcp(7)), with the difference that this flag can be
              set on a per-call basis.

@vzsg seems like that ab also expects the entirety of the response to arrive in one TCP frame
@vzsg @vi4m wrk works fine on macOS for me (I got 70303.63 req/s in https://github.com/vapor/engine/issues/153#issuecomment-320771021). The only problem I had with wrk was running the Linux compiled version. Are you saying you're getting bad benchmark results with wrk for macOS?
@BrettRToomey I haven't been able to read anywhere that sending HTTP req/res in multiple write calls is not allowed (in fact it is required for stuff like SSE). Does anyone know of any documentation about what behavior should be expected in terms of number of calls to send? Perhaps even though it's not specifically mentioned in the HTTP spec, it's become a standard because of how much simpler it is to implement an HTTP parser the doesn't need to handle that edge case.
I'll take a look at implementing socket flushing using the MSG_MORE option and see if that fixes

Yes, I've been continuously testing with wrk (and ab and vegeta) running on macOS, while the Vapor helloworld was running inside Docker.

WRK seems to be buggy on macOS high Sierra here. I read the HTTP docs lately, didn't see anything about specific requirements for sending data on a socket.

TCP_NODELAY may be of use too, sounds like Nagle algorithm is definitely reducing throughput by delaying small packets.

This isn't a TCP issue. If it's the blocking on small packets, it's a TCP issue, a layer below.

@robertjpayne Yeah, seems something like that. It may be easier to check in Wireshark or something and see the actual packets being sent out.

I ended up running it in virtual box myself. It looks like it comes in as two TCP packets (as expected) and then it gets reassembled into a single packet and then interpreted as HTTP, as expected. I'll try running this again with wrk and try to filter through the noise.

@vi4m I think Docker has something to do with it too -- running Vapor inside Docker on macOS (Regular Docker.app install) A simple "Hello World" plain text benchmark caps at about 200/req/s.
This is with docker set to use 10GB of ram and 6vCPU since it does run inside a VM.

I'd be interested to see if this fixes the issue https://github.com/vapor/engine/pull/168 (for anyone who can recreate it). That PR modifies the basic server in engine to send the entire response as one libc.send() (unless it's chunked of course)

Doesn't compile for me :(
/code/.build/checkouts/engine.git-3458089043233217718/Sources/HTTP/Server/BasicServer.swift:156:44: error: cannot convert value of type 'UnsafeRawBufferPointer' to expected argument type 'UnsafeBufferPointer<UInt8>'
    static let empty = DispatchData(bytes: UnsafeRawBufferPointer(start: nil, count: 0))
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/code/.build/checkouts/engine.git-3458089043233217718/Sources/HTTP/Server/BasicServer.swift:110:48: error: cannot convert value of type 'UnsafeRawBufferPointer' to expected argument type 'UnsafeBufferPointer<UInt8>'
                let data = DispatchData(bytes: buffer)
                                               ^~~~~~
/code/.build/checkouts/engine.git-3458089043233217718/Sources/HTTP/Server/BasicServer.swift:122:48: error: cannot convert value of type 'UnsafeRawBufferPointer' to expected argument type 'UnsafeBufferPointer<UInt8>'
                let data = DispatchData(bytes: buffer)
                                               ^~~~~~

Ah looks like a Swift 4 change.


feat(tls): add root_cas string field

Currently, the only way to pass a root certificate authority for trusted communication is through the tls.root_cas_file parameter.
This means, the .pem certificate file must be available on the machine/container where Benthos is running. That, however, is not versatile in those cases where the secret might be instead injected in a Kubernetes Pod using environment variables (maybe through Helm charts + Vault... maybe... not saying that's my use case... :eyes:).
This PR adds support for a tls.root_cas string field, where the certificate can be passed explicitly, or through an environment variable instead.
The high number of modifications are due to make docs updating all inputs/outputs documentation files. I suggest to check the first commit for analyzing the changes 😄

Awesome, looks good, thanks @ar3s3ru! Bonus thanks for sorting the docs out, that's 53 files now blessed with your avatar.

Passing the certificate content as an env variable using this field (e.g. CA_PEM="$(cat root.pem)" and tls.root_cas: "${CA_PEM}") is not working as expected (testing it with a kafka input).
Maybe it's the \n or the formatting of cat 👀
Might also be the type casting from string to []byte.
You just merged while I was typing this message, so I guess I'll figure it out and create a follow-up PR later 😄
Thanks for reviewing @Jeffail ❤

Haha no worries, I can take a look this evening as well. The env var replace is a simple byte swap so it might be that the line breaks need escaping in order for them to be interpreted correctly during the YAML parse (https://github.com/Jeffail/benthos/blob/5b2eecee82ce5ec5602ebb35d579e4a054371bb8/lib/util/text/env_vars.go#L31).


Update versions.md

Updating the Versions Help page (versions.md) to indicate support for the 10.3 release.

This now has conflicts with HEAD -- want to update it and resubmit?


footer to match catalog / library site

see https://github.com/pulibrary/pomegranate/issues/287#issuecomment-399095033


fix: mongo real time data check

Fix sysUpTime comparison (mismatched host _id), add upsert for static data

Codecov Report

Merging #107 (344269b) into develop (c01fb4d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #107   +/-   ##
========================================
  Coverage    55.30%   55.30%
========================================
  Files           29       29
  Lines         1253     1253
========================================
  Hits           693      693
  Misses         560      560

Impacted Files
Coverage Δ

...onnect_for_snmp_poller/manager/poller_utilities.py
0.00% <0.00%> (ø)

splunk_connect_for_snmp_poller/mongo.py
36.53% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01fb4d...344269b. Read the comment docs.

:tada: This PR is included in version 1.5.0-develop.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Adding maxLength rule under v1.9.0 will cause all validation to fail

We just upgraded our project to v1.9.0 with Nuget (using jQuery v1.7.1).  When we added a maxLength rule to any field, the validation would completely break down.  After the first submit the form would evaluate to being valid even though it wasn't.  Also entering any value in a field that had a maxLength rule associated with it would cause the form to be evaluated as valid.

There is no maxLength method, it has been "maxlength" for a few years now. I guess you've been using a really old version. To fix, just replace maxLength with maxlength.


[NPM Lite] Added DefaultDeny in PNI + MTPNC CRD's

Reason for Change:

As part of adding default deny so pods can't communicate with one another when network policies are not present, this pr is part 1 which updates the pni crd and mtpnc crd with adding a default deny acl bool field.
Test:
Confirmed when default deny is not added as a field or is added as a field and set to false, mtpnc displays Default Deny ACL : false as shown below

Confirmed when default deny is added as a field and set to true, mtpnc displays Default Deny ACL : true as shown below

Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] relevant PR labels added

Notes:

/azp run Azure Container Networking PR


Create SimpleRegressor class

Description of feature/enhancement
This class should handle generating the most accurate model for for any given regression problem.
Description of implementation
The class should have a function called fit which creates the most accurate regression model for any given data set.
Why this is a good feature/enhancement
This will allow users to simply pass in data and be returned the most accurate model without having to worry about fine tuning the hyper-parameters themselves.
Additional context
n/a

Hey @skekre98 I would like to help with this issue and writing tests for it while i'm writing the class ( #11 ).
I thought about adding the following regressors to param_grid (in another dictionary) for a start :
"SGDRegressor"
"KNeighborsRegressor"
"DecisionTreeRegressor"
"RandomForestRegressor"
"GradientBoostingRegressor"
"AdaBoostRegressor"
They seem to cover easier to harder cases of data. Then We can see how they work out and improve from there.
Let me know what you think.

Hey @skekre98 I would like to help with this issue and writing tests for it while i'm writing the class ( #11 ).
I thought about adding the following regressors to param_grid (in another dictionary) for a start :
"SGDRegressor"
"KNeighborsRegressor"
"DecisionTreeRegressor"
"RandomForestRegressor"
"GradientBoostingRegressor"
"AdaBoostRegressor"
They seem to cover easier to harder cases of data. Then We can see how they work out and improve from there.
Let me know what you think.

Hi @eranns, sorry about my absence. I think it would be a great idea to start with these regressors. Instead of adding the regressor param_map to the current file, let's go ahead and create a separate directory for regressors and add another file called param_grid.py there.

Hi @eranns, sorry about my absence. I think it would be a great idea to start with these regressors. Instead of adding the regressor param_map to the current file, let's go ahead and create a separate directory for regressors and add another file called param_grid.py there.

Hi @eranns, sorry about my absence. I think it would be a great idea to start with these regressors. Instead of adding the regressor param_map to the current file, let's go ahead and create a separate directory for regressors and add another file called param_grid.py there.
I'll go ahead and assign this and #11 over to you 😄

alright I created separate directory for regressors.
I wrote the class and the tests and made it similar to the classifiers code.
There are few things I changed  :

metrics and that does not apply to regression but to classifications
added raise exception in gridsearch once model failed and used try/except
gridsearch scoring is rmse (can choose another) but gridsearch try to maximize this value so instead it returns it as negative so I handled it

I will make a pull request so we can discuss on the code in a better way.

Hi @eranns, sorry about my absence. I think it would be a great idea to start with these regressors. Instead of adding the regressor param_map to the current file, let's go ahead and create a separate directory for regressors and add another file called param_grid.py there.
I'll go ahead and assign this and #11 over to you 😄

alright I created separate directory for regressors.
I wrote the class and the tests and made it similar to the classifiers code.
There are few things I changed  :

metrics and that does not apply to regression but to classifications
added raise exception in gridsearch once model failed and used try/except
gridsearch scoring is rmse (can choose another) but gridsearch try to maximize this value so instead it returns it as negative so I handled it

I will make a pull request so we can discuss on the code in a better way.


JavaScript QA projects cannot retrieve source files

The JavaScript QA projects  contain some (apparently unused) routes to fetch source code files in file fcctesting.js .
Those routes do not appear to work, because they search files as if the source file was located in the project root. I created a sample patch to illustrate the problem and propose a fix.
(The patch also addresses another small issue in file server.js for which I will open another bug report.)

As that's not used for anything anyway it might be better to just remove it all together.

Thank you for reporting this issue.
This is a standard message notifying you that the issue has become stale, so we are going to close it.
If you think we're wrong in closing this issue, please request for it to be reopened. Thank you and happy coding.


Support working without a System Console

X-Ref: #17
Enable the use of the library in an application that doesn't have access to System.Console.
This is for scenarios where a Console type output is useful for debugging but no actual Console is available.
Implementation note: Add a VSDebugConsole that is the same as VSConsole but doesn't have the internal calls to System.Console.*

If you now upgrade to the 1.1.0 version of the VSConsole NuGet library you can use using Console = VSDebugConsole.Console; and  this will do everything as before but with no dependency on System.Console and so can be used in any app.
/cc @hguptauk

Thank You @mrlacey!


no root user + docker ignore dockerfile

Description
security recommendations are to avoid root in containers
Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

thanks, let's also change this file https://github.com/openflagr/flagr/blob/main/integration_tests/Dockerfile-Integration-Test

thanks, let's also change this file https://github.com/openflagr/flagr/blob/main/integration_tests/Dockerfile-Integration-Test

done

Codecov Report

Merging #52 (cc3cbfe) into main (1694d8e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   81.55%   81.55%
=======================================
  Files          27       27
  Lines        2174     2174
=======================================
  Hits         1773     1773
  Misses        314      314
  Partials       87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1694d8e...cc3cbfe. Read the comment docs.


refactor: using monorepo mange vueposu project

@glitchboyl need more information describe this pr.

Can we auto generate changelog to proejct ?

I need to modify the circle config, because test have some change, it look like will effect the coverage report .

compile output look stranger ... missing the package.json and build the __test__, __test__ should be ignore i think.

Codecov Report

Merging #4 (665b8c5) into develop (beb88a0) will decrease coverage by 0.15%.
The diff coverage is 84.00%.

@@             Coverage Diff             @@
##           develop       #4      +/-   ##
===========================================
- Coverage    85.56%   85.41%   -0.16%
===========================================
  Files           35       37       +2
  Lines          776      802      +26
  Branches       198      203       +5
===========================================
+ Hits           664      685      +21
- Misses          70       74       +4
- Partials        42       43       +1

Impacted Files
Coverage Δ

packages/shared/utils/debounce.ts
100.00% <ø> (ø)

packages/shared/utils/emitter.ts
100.00% <ø> (ø)

packages/shared/utils/throttle.ts
100.00% <ø> (ø)

packages/vueposu/index.ts
0.00% <0.00%> (ø)

packages/vueposu/src/useClickAway.ts
94.44% <ø> (ø)

packages/vueposu/src/useClipboard.ts
85.71% <ø> (ø)

packages/vueposu/src/useCounterInterval.ts
100.00% <ø> (ø)

packages/vueposu/src/useDebounce.ts
100.00% <ø> (ø)

packages/vueposu/src/useDebounceFn.ts
100.00% <ø> (ø)

packages/vueposu/src/useDynamicList.ts
93.75% <ø> (ø)

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb88a0...665b8c5. Read the comment docs.

We need to add auto update version method in now release scripts.


Also pass caret index in edit event.

Can you please elaborate?

html --------------

js -----------------
update: function (text, index) {
console.log(text);
console.log(index);
}

This should not be too complicated. Can you create a PR?

I don't have idea how to do.

Here is a great tutorial on pull requests.
https://yangsu.github.io/pull-request-tutorial/

@alfredobarron If I understand correctly, you also wish to receive the current caret index during the edit event. Is that correct?
My thoughts are the following: This is a quite specific use case. The API of MediumEditor is quite exhaustive. I did not see a concrete API section that would allow to pass the current caret position. If this is what you need, you should create an issue over at https://github.com/yabwe/medium-editor and link it to this one.
Generally, I think the API of vue-medium-editor could be extended nicely if we would just pass the element with each edit event. Like this any user can react to changes in whatever way they desire.
As this is currently the only issue requesting such a feature I consider closing it soon. However, if you still need help we can work on this together.
Reference:
https://github.com/yabwe/medium-editor/blob/master/API.md

Please see: https://github.com/yabwe/medium-editor/issues/730 for viewing or manipulating selections.


Re-Streaming HLS

Hello,
With the RTMP module is it possible to ingest RTMP and proxy_pass HLS to an upstream server expecting an HLS stream?

If I understand the question correct, this is surely possible. HLS are just http requests so you can spread them easily using another nginx instance or whatever webserver you use.


Palettes not loading

Ever since I updated to Version 39.1, palettes are not loading or clearing.

Same here. Can't save palettes either.

@ladyheatherly @Niknam I pushed a newer version of the plugin when Sketch 39.1 was released. If you haven't yet, can you give that a shot?

@andrewfiorillo The new version works good! Sorry, my bad, should have checked if theres was a new version out or not. Thanks a lot!

No worries! I wish there were a more streamlined way of updating and being alerted of new versions of plugins.

That works. Thanks very much!


Fix Edit Command Bug

EventList, DeadlineList and FloatingTaskList should add reference instead of making copies in their add method.

Bug is still not completely removed. In-progress.


[readdb] indexing Fast5/ Error: no fast5 files found

So I have have all my fast5 files in a directory called Fast5 and all my fastq file cat together in a file called output.fastq.
When I run:
Nanopolish index -d Fast5/ output.fastq
I get this output:
[readdb] indexing Fast5/
Error: no fast5files found
I am not sure what to do to fix this problem.

I have now also tried to do a test run on just 10 Fast5 and Fastq from a different organism and am getting the same error.
Nanopolish index -d Fast5/ output.fastq
I get this output:
[readdb] indexing Fast5/
Error: no fast5files found
It create the index files:
output.fastq.index         71M
output.fastq.index.fai    2.5M
output.fastq.index.gzi    60K
But when I go to run nanopolish I get the error:
error: can not load the index files for input file output.fastq
Please run nanopolish index on your reads (see documentation)

Hi,
Can you run ls Fast5 and paste the output?
Jared

Here is the 11 that I am using for my test run.
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_0.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_10.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_1.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_2.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_3.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_4.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_5.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_6.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_7.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_8.fast5
FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_9.fast5

Can you run this exact command, and paste everything that is printed to the terminal?
find . -name "*.fast5"

./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_5.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_2.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_3.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_8.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_10.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_1.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_9.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_0.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_6.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_4.fast5
./Fast5/FAL18771_6f89527d9b9722df12e130826ac0682ad600a037_7.fast5

Can you try to follow the first steps of this tutorial to see if indexing works on our example data?
https://nanopolish.readthedocs.io/en/latest/quickstart_call_methylation.html

Yeah I tryed that and it run fine. I just dont understand why it can't read mine.

Are the files readable by a different program?
Hannah

Hi Hannah,
I'm sorry but I think that since h5dump is unable to read the files too, then the problem is beyond nanopolish. I'm not sure what the problem could be since the permissions look OK, and the files look to be the right size. Were you able to basecall these reads?
Jared

Yes I have one individual that was recalled with guppy V5 and another that was called with sequencing with V3.

Would you be able to send me one of the fast5 files, and the corresponding fastq?

It seems to not support that file type here. Can I get an email for you or you can email me<EMAIL_ADDRESS>

Moved to our other computer and it runs fine. Must be something weird with our system.

Glad to hear it, thanks for reporting back!

On Aug 4, 2021, at 10:45 AM, Hannah1746 @.***> wrote:

Closed #917.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Support configuring dashboard with one endpoint for browser and OTLP

Fixes https://github.com/dotnet/aspire/issues/2756
If the dashboard was started with the same port for OTLP and browser endpoints, two endpoints were started and the dashboard fails because of a port conflict.
This PR changes the dashboard:

Check if configured endpoints are the same, and if they are then only one endpoint is started. This allows the dashboard to be hosted in a single port environment such as Windows Azure App Service - https://github.com/Azure/app-service-linux-docs/blob/master/HowTo/gRPC/Windows/README.md
Checks single endpoint for HTTPS. If it isn't secured with HTTPS, then a warning is logged that browser access is only possible via a proxy that terminates TSL.

TODO: Update dashboard readme.

Doe the auth code need a fixup?

I don't think so. You could configure something that isn't useful by having a single endpoint that requires client certificate auth - which isn't possible from a browser.


Revert "Test type_sequence fails on incremental bot"

I cannot reproduce this locally. Using this to see if it still hits our infrastructure
rdar://86744286

@swift-ci test

preset=buildbot_incremental,tools=RA,stdlib=RA
@swift-ci Please test with preset macOS

⛵


sysbench threads ceiling

Sysbench thread count has a ceiling -- protecting against failures for VMs with high CPU count by setting a max threads value.

Also please help make sure we have unit test covering this usage. Also add one-liner in our document


New sample repo refers to 'The debugger's target composition API' and DbgServices.h. How can these be acquired?

I have the latest Windows SDK installed with debugging tools but this header is not present. Not seeing anything searching the web. Where can we find the headers, etc... for this API?

The header is not yet present in the SDK.  It is available in a NuGET package (https://www.nuget.org/packages/Microsoft.Debugging.TargetModel.SDK).  You should be able to just build the "TextDump" sample in this repo if you open the solution in Visual Studio.  It should already reference that NuGET package.

Ok, I had only been browsing the readme and the source. Thanks for your help.


Ability to use to CSI plugin for Velero. Supports AWS EBS CSI driver.

This adds the ability to create backup and restore with Velero using CSI plugin when Lokomotive is installed on AWS and aws-ebs-csi-driver component is used to dynamically provision volumes

@ipochi component name is aws-ebs-csi-driver, not aws_ebs_csi_driver :wink:

@ipochi what's the progress on this? Is this being worked on actively?

@ipochi what's the progress on this? Is this being worked on actively?

@surajssd  yes.
This would not be part of the 0.6.0 release. I didn't get much time to address the review comments as I am focussing on baremetal platform missing features.

@surajssd  yes.
This would not be part of the 0.6.0 release. I didn't get much time to address the review comments as I am focussing on baremetal platform missing features.


Question about image conversion in person detection example

Hi,
I want to use my own image to test person detection so I need to convert my images to a (96 * 96) C array. I follow the instructions below, but the byte array I get is too long.
https://github.com/tensorflow/tflite-micro/blob/f583f92992c3c9dfb8e10f36d66b2fe7267cf7bc/tensorflow/lite/micro/examples/person_detection/person_image_data.h#L17-L20
For instance, I test it with my Github avatar:

Here are the instructions I use to generate C array file

convert -colorspace Gray avatar.png avatar_g.png (to convert it to grayscale img)
convert -resize 96x96! avatar_g.png avatar.bmp3
xxd -s 54 -i avatar.bmp3 > avatar.cc

The result C array is of length 27648 (96 * 96 * 3) I do not figure out how to convert it to single-channel since the expected input is (96 * 96). I tried but failed. Could you help take a look at this and update the instructions? Thanks in advance!

You might try asking on an imagemagick forum. The exact sequence of commands is dependent on the version of imagemagick (the "convert" command) that you are using.

Closing, since I believe this is outside the scope of the project.


[FEAT] Auto accept bounty like blessings at shrine npcs

Would be great to auto accept it instead of clicking it. Im lazy :)
https://wiki.guildwars.com/wiki/Bounty-like_blessing#Guild_Wars_Eye_of_the_North

Nope, bind a hotkey to /dialog take


Shared icon appears only after browser refresh

In chat context menu select Share icon
On the pop-up click on Copy button and close the pop-up
Check the chat -> there is no shared icon -> bug

Note: Shared icon appears after browser refresh
Note the same is for prompts. folders
Expected: Shared icon appears if user click on copy icon, or copy the link using hot keys and closes the pop-up

Not a bug, because share icon appearing only after other user accepting invite


simple pronoun edits

Hello @nicks,
Please review the following commits I made in branch nicks/edits:
52ef267fffbbd4e63d851c99cf9f7c734bdb57d5 (2021-03-18 17:41:35 -0400)
simple pronoun edits
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

also updated the date, which was a mistake


Implement yapf formatting

Since 90% of the code is actually managing UI - formatter selection and installation + packaging, there is very little to do in the LS. VS Code extension already implements formatting with formatter selection and we suggest PTVS to do the same something similar. The remaining code is basically save file to temp, call formatter, read the result back.


How to represent Stillborn in GEDCOM 7

As far as I can tell, FamilySearch GEDCOM removed the ability to record in any interoperable way the fact that an individual was stillborn.   One cannot rely on TYPE Stillborn, since that is freeform text and could be entered in any language.  One cannot rely on DEAT AGE 0y since the spec explicitly says 0y can be used for anyone who died less than an year old.   So if one needs to, say, determine whether a SLGC should be performed, one can tell with GEDCOM 5.5.1 but cannot tell with GEDCOM 7, which is a disincentive to switch to GEDCOM 7.
See https://github.com/FamilySearch/GEDCOM.io/issues/26 for more discussion.

What definition of "stillborn" are you assuming? The modern US English version "dead at birth"? The 19th century UK English version "born alive but not breathing"? The Roman Catholic traditional use "died before the parents could baptize it"? The Jewish traditional use "died before circumcision"?
There may be others too; the OED has this in its etymology quotes in the entry "still-born, adj. (also stillborn)":

1955   W. P. D. Logan in Holland & Bourne Brit. Obstetr. & Gynæcol. Practice: Obstetrics xxxix. 1140   In certain countries children born alive but dying within a stipulated number of days are registered as stillborn.

5.5.1 certainly doesn't make it clearer in it's definition "died just prior, at, or near birth, 0 years" nor it's example of DEAT.AGE STILLBORN "meaning this person died at age approximately 0 days old". The definition is broad, inclusive of all of the various "died very young" meanings of stillborn without giving any indication which was meant, while the example is narrow and in contradiction of the definition.
I believe that removing STILLBORN from 7.0 improved clarity by removing an under-defined tag with culturally-specific interpretation that caused more misunderstanding than it did accuracy. DEAT.AGE 0d is more precise than DEAT.AGE STILLBORN and appropriate in most cases; but when it was a before-a-rite version I'd prefer to see DEAT.AGE <8d than DEAT.AGE STILLBORN and have to guess that STILLBORN meant <8d not 0d because of the parent's INDI.RELI Jew.
I oppose bringing back AGE STILLBORN.

So if one needs to, say, determine whether a SLGC should be performed, one can tell with GEDCOM 5.5.1 but cannot tell with GEDCOM 7

We intentionally kept SLGC.STAT STILLBORN for this reason. Note that STAT STILLBORN and AGE STILLBORN were never equivalent; the former is defined by a specific church's current policy while the latter by an author's culturally-specific interpretation of a word.

If we do wish to make a normative path to representing some type of stillbirth, we need to

clearly define which type we mean; I think the most common that are not simply numbers of days are:

late-term miscarriage
died during labor or delivery
died after birth but before breathing

add a normative structure for the one we pick

If we decide that there's one most-important definition to include, I'd favor adding it as a new kind of individual event in 7.1. If we decide that there are several all worth defining, I'd favor an enumerated value substructure of BRIT or DEAT (whichever more naturally encompasses all of the definitions we pick) instead.
It is not clear to me that we have enough demand to warrant this kind of addition.

What definition of "stillborn" are you assuming? The modern US English version "dead at birth"?

Yes

I'd favor an enumerated value substructure of BRIT or DEAT (whichever more naturally encompasses all of the definitions we pick)

Yes.  Note that GEDCOM 5.5.1 allowed "AGE STILLBORN" under any event, not just DEAT.   I don't think that's necessary though, either BIRT or DEAT is sufficient in my view.
BTW, I think this same question was asked in

https://genealogy.stackexchange.com/questions/3795/how-to-record-a-stillbirth-as-a-genealogical-event

Discussed 2022-01-12
Agreed there is a problem, namely: (a) neither 5.5.1 nor 7.0 can reliably record "born dead" in source data, only sealing status data, but (b) the Church does check for stillbirth in some way to decide ordinance permissions.

Proposed recording BIRT.DATE XYZ and DEAT.DATE BEF XYZ (this would not work with ABT/CAL/etc in BIRT.DATE)
Could add a hint like "Programmatic checks for stillbirth should check for BIRT.TYPE Stillborn".
Could add a new in-grammar rule, like defining AGE < 0d to mean "strictly before being born" (currently AGE < 0d would mean under 24 hours
Could  add a new structure in 7.1, such as

a new Event type "deadborn"
a new enumerated-payload substructure of BIRT and/or DEAT

Proposed:

Add a STILLBIRTH individual attribute (to match gedcom-x's stillbirth fact)

could alternatively be an event

Add an optional enumerated substructure to define what type of stillbirth it was:

Miscarriage
Dead before birth
Born alive but never breathed
Died shortly after birth
Died before a near-birth rite like Christening could be performed


Issue with Single Quotes on Windows

Hi,
The plugin has worked well on MacOS, running the gradle script on a Windows machine using GitBash, the following error results.   Is this an issue with the use of Single Quotes rather than Double Quotes?  If so, what recommendations do you have for resolving this?
Thanks!
:releaseerror: pathspec 'version.txt' did not match any file(s) known to git.
FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':release'.

Process 'command 'git'' finished with non-zero exit value 1

Please try "chmod 777 version.txt" in git bash on windows.

Hello,
I tried that and I get the same result.
Perhaps your plugin needs to use a cross-platform plugin for the Exec command: https://github.com/jlouns/gradle-cross-platform-exec-plugin [https://github.com/jlouns/gradle-cross-platform-exec-plugin]
On Mon, Nov 13, 2017 at 2:18 AM, Stefan<EMAIL_ADDRESS>wrote:
Please try "chmod 777 version.txt" in git bash on windows.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/netzwerg/gradle-release-plugin/issues/38#issuecomment-343844194] , or mute the thread [https://github.com/notifications/unsubscribe-auth/ACL6UbRgGZqkZFMeFTf2PrUkH94Fmt-yks5s1_tBgaJpZM4QbEVL] .

Sorry for not getting back to you earlier – did you have any success in the meantime? Unfortunately, I personally only use the plugin on OSX and Linux, but afaik others are successfully using it on Windows...


Azle 0.18.0 Release

Must Have

[ ] The Azle Book
[ ] remove ledger wasm from git history
[ ] run all examples to update candid
[ ] simplify all tsconfig.json files
[ ] Change examples dfx.json ordering, main,then candid, then build
[ ] update the new command
[ ] update azle hello world
[ ] Make sure all type inference is working in all situations
[ ] #1287
[ ] Double-check typings for Record, Variant, etc to ensure that users can only put in correct types
[ ] Probably get rid of the cycles at the end of the call...maybe turn this on with an environment variable or dfx.json property...yeah, I like the idea of the dfx.json property
[ ] we absolutely must have one central location to do encoding and decoding and just use that everywhere, causing many errors
[ ] add common deployment issues link to all hello world, new command, etc places

Nice To Have

[ ] Create frontend example or gather other examples for the hackathon: https://github.com/Code-and-State/typescript-bootcamp/tree/main/templates
[ ] rewrite the basic_bitcoin library using actual bitcoin npm packages
[ ] If there is an error during azle installation/deployment, we need to show the error to the user
[ ] Make http types
[ ] Remember plugins
[ ] type the canister, as in make those types tight on the input object to the canister
[ ] do inline types actually work? Look at the recursive example, sure looks like inline types to me
[ ] add func and service tests to the stable_Structures example and tests
[ ] Work on an unwrap syntax?
[ ] Resolve this if possible: https://github.com/demergent-labs/azle/issues/1326
[ ] Everything in our GitHub account, rewrite it all to the newest syntax
[ ] Rewrite examples without tests
[ ] Use only lambdas for recursion, check the name property, empty string on lambda, all AzleDid classes we can just put a property name on them

All dfx.json files can now look like this:
{
    "compilerOptions": {
        "strict": true,
        "target": "ES2020",
        "moduleResolution": "node",
        "allowJs": true,
        "outDir": "HACK_BECAUSE_OF_ALLOW_JS"
    }
}


[SPARK-47484][SQL] Allow trailing comma in column definition list

What changes were proposed in this pull request?

When experimenting with SQL queries, it's common to accidentally leave a trailing comma after the last column in a table definition, resulting in syntax errors. This often happens when developers comment out the last column and forget to remove the trailing comma, leading to unexpected syntax issues when creating tables.
This pull request addresses this issue by allowing trailing commas in column lists when creating tables, thus preventing syntax errors caused by inadvertent comma placement.
CREATE OR REPLACE TABLE test_tbl (
    c1 STRING,
    c2 INT,
--    c3 INT,
)
USING PARQUET;

I see no reason why the above query should fail.
I explored a similar idea but for SELECT statement in #45541, but it turned out that making from a reserved keyword would break compatibility with older code using the word.
Why are the changes needed?

These changes are needed because it's a handy feature already found in other databases like SQL Server and DuckDB. Bringing it to Spark would be a nice improvement for everyone.
Does this PR introduce any user-facing change?

Yes, having a trailing comma will not result in a syntax error like it used to.
How was this patch tested?

New unit tests
Was this patch authored or co-authored using generative AI tooling?

No

Sorry for being late, @MaxGekk .

Is this ANSI SQL syntax?
Do you have any reference for this syntax in other references?

I only know of this for the SELECT list, where it is popularized by duckDB and now Snowflake.
This is NOT ANSI SQL syntax and I'm not in favor of starting down this path for two reasons:

This will increase pressure on trailing commas in SELECT which we cannot do without a hard breaking change
Generally I think "nothing" after a comma is associated with an unset value (i.e. a NULL). E.g. (,,) should, if we were to support this be parsed as (NULL, NULL, NULL).

Ya, I also believe this is not good for Apache Spark community in a long term perspective.


[Feature Request] Add function to access showManageSubscriptions. Enables Subscription upgrades.

Purpose: This is needed to support in app prompts to upgrade from a basic to a premium plan, a fairly mainline pricing pattern these days. Since the subscription can only be upgraded in the app store, there needs to be a way to send the user our of the flutter app to the app store, just like with the initial purchase.
I don't believe showManageSubscriptions or the Android equivilant exists in the chargebee library.
I'm listing as a feature request, but it really is an issue, as offering the users the ability to manage their subscriptions or upgrade is an essential part of managing mobile subscriptions.

@cb-haripriyan
Great to hear. I know that flutter support is newer, and you guys have a lot of other priorities. But I think this is key to making ChargeBee's mobile service competive with other billing platforms in the market and key to ChargeBee customers being competitive in their sphere's.
Currently in our App, I have a prompt to upgrade, but no way to provide a button / link for users to actually do so. It's a pretty shoddy UX experience and adds friction to upgrade. The only alternative is to drop Chargebee for mobile, but we're very satisfied with the web platform, so I'd rather let you guys know what we need and grow together.

Hi @DylanCross Thank you for raising this concern and also your confidence in our solution. We will surely help you out. As mentioned by @cb-haripriyan we will discuss this and get back to you next week.
Also wanted to keep you posted that though we currently don't have a method for upgrade in SDK, we are handling all upgrade & downgrade server notifications sent by store at our backend. So if you can handle the upgrade part in UI, you can view the corresponding changes in Chargebee.

Hi @DylanCross We had a discussion on this and we are coming up with a method for upgrade in all our SDKs. Please note that this will be available in Q3'23. Thanks for the suggestion.


Bump version to v7.0.0b1

jenkins, test this please

Jenkins CI test (for commit f9a0fe5f6cf45d1f6d41ee1b84075188b9b8e031, target branch master) failed with status FAILURE.

LGTM


tests: Remove support for preinstalled images

What this PR does / why we need it:
Drop support for FLAVOR=preinstalled in our CI. This never worked and the image in question is no longer available.
Which issue this PR fixes(if applicable):
N/A.
Special notes for reviewers:
This is test-only.
Release note:
NONE

/ok-to-test

/test openstack-cloud-csi-cinder-e2e-test
try a CI to test the code

/lgtm

/approve

weird not merge automatically..


⚠ Young Discoverers has degraded performance

In 51b6e57, Young Discoverers (https://youngdiscoverers.org.au) experienced degraded performance:

HTTP code: 200
Response time: 5851 ms

Resolved: Young Discoverers performance has improved in 383b4ca.


evap trend :: code rerun

Rerun evap trend code

Why is there 03_c_<> and 03_c_v2_<>?
The 03_m_map_ipcc_hexagon_uncertainty.R script need tidying up
The 03_map_coverage.R script doesn't follow naming convention of the rest of the scripts
In 03_<> scripts it would be best to do pxx <- ggplot(...); ggsave(plot = pxx, ...) to guarantee the right plot is being saved
Below see specific warning/error messages
01_d_global_grid_calculate_dci_uncertainty_per_grid.R
Warning message:
In points2grid(points, tolerance, round) :
grid has empty column/rows in dimension 1
01_e_global_grid_calculate_uncertainty_per_grid_dataset_contribution.R
Warning message:
In points2grid(points, tolerance, round) :
grid has empty column/rows in dimension 1
01_g_global_trend_correlation.R (when sourcing)
Error in Math.data.frame(x = list(fldas = c(0, 1.09210179987872e-169,  :
non-numeric-alike variable(s) in data frame: rn
In addition: Warning message:
In melt.data.table(as.data.table(cor_data, keep.rownames = T)) :
id.vars and measure.vars are internally guessed when both are 'NULL'. All non-numeric/integer/logical type columns are considered id.vars, which in this case are columns [rn, ...]. Consider providing at least one of 'id' or 'measure' vars in future.
02_a_masks_cumulative_trend_direction.R
Warning message:
In points2grid(points, tolerance, round) :
grid has empty column/rows in dimension 2
02_b_masks_mean_slopes.R
Warning message:
In points2grid(points, tolerance, round) :
grid has empty column/rows in dimension 1
02_g_masks_correlation.R
There were 50 or more warnings (use warnings() to see the first 50)

warnings()
Warning messages:
1: In melt.data.table(as.data.table(cor(dcast(.SD, formula = lon +  ... :
id.vars and measure.vars are internally guessed when both are 'NULL'. All non-numeric/integer/logical type columns are considered id.vars, which in this case are columns [rn, ...]. Consider providing at least one of 'id' or 'measure' vars in future.

03_c_plot_mean_slopes_masks_by_product.R
10 Warning messages:
geom_abline(): Ignoring mapping because slope and/or intercept were provided.
03_c_v2_plot_mean_slopes_masks_by_product.R
10 Warning messages:
geom_abline(): Ignoring mapping because slope and/or intercept were provided.
03_j_plot_change_in_probability_groups_per_dataset_leftout.R
Warning messages:
1: Removed 1 row containing missing values or values outside the scale range (geom_bar()).
2: Removed 76 rows containing missing values or values outside the scale range (geom_bar()).

Code checked


TS Account Management (Old 238)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:08
User's should be able to register a new identity on the TS server (capped at 3 maximum).
Old registrations should not be deleted - make use of the softDelete trait.
Ideally follow the current setup of click the button and then register using a link sent to you within TS (use the library in #237).  Offer an alternative for those who don't wish to do it that way.
Also allow members to delete their registrations (ensuring this identity is also removed from the TS server).

In gitlab by @A-Lawrence on Aug 31, 2015, 01:13
Marker commit: resolves #488469 (238) and #239.
ÔåÆ <>
NFarrington - 2015-03-11T00:31:49.299141+00:00


Compilation error of TensorFlow Lite on Windows

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 64bit
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): I don't use python since building TensorFlow Lite
Python version: See above
Bazel version (if compiling from source): See above
GCC/Compiler version (if compiling from source): gcc (Rev2, Built by MSYS2 project) 8.3.0
CUDA/cuDNN version: No
GPU model and memory: No

Describe the current behavior
Compilation error
tensorflow/lite/experimental/c/c_api.cc:80:29: error: function 'void TFL_InterpreterOptionsSetErrorReporter(TFL_InterpreterOptions*, void (*)(void*, const char*, va_list), void*)' definition is marked dllimport
 TFL_CAPI_EXPORT extern void TFL_InterpreterOptionsSetErrorReporter(
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Describe the expected behavior
Success to compile
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
See tensorflow/lite/experimental/c/c_api.cc This is broken C syntax when TFL_CAPI_EXPORT is __declspec(dllimport)
This is small step to way to reproduce on Windows.
foo.cc
__declspec(dllimport) extern void foo() {
}

$ g++ foo.cc
foo.cc:1:35: error: function 'void foo()' definition is marked dllimport
 __declspec(dllimport) extern void foo() {

Other info / logs
See above
I created pull-request https://github.com/tensorflow/tensorflow/pull/26615

Closed by #26615


Upgrade to Laravel 6

Laravel 6 is releasing soon. Would be good to align BookStack to a later release. Should be a fairly straightforward upgrade code-wise. The bigger concern will be the change in PHP version requirements (php7 to php7.2). Laravel 6 looks to be an LTS release which will be ideal since staying on Laravel 5.5 has kept things steady for the last two years.
Considerations

Install scripts will need to be updated to install php7.2 by default (Perhaps skip to latest stable version at time of changes).
PHP upgrade guide would be ideal for those that have already installed with official install scripts.
We'll need to warn popular BookStack service/container maintainers of the change in order to ensure a quick and stable upgrade for their users.
PHP dependencies will need to be reviewed to ensure compatibility with Laravel 6.

The good thing is that even debian is with the latest version at php 7.3.

Ah, That's good news. Think the mains ones will be debian stretch, Ubuntu 16.04 & Centos 7. If we provide some instructions for those then we should be covered. Potentially debian Jessie also? But that is nearing EOL.

Debian stable is Buster (php 7.3)
Debian old stable is Stretch (php 7.0)
Ubuntu is 18.04 prefered but 16.04 is still supported. But both have php 7.3

This is only missing a docs update for Debian stretch (how to get PHP 7.3 running) and updating system requirement lists eventually, right?

@timoschwarzer Yeah, Docs and install script updates for Debian Stretch, Ubuntu 16.04 & Centos 7. Leaving this issue open as a reminder for that.
And also need to check the docker images and warn if they are on a lower PHP version. Might be alright there though.

Docs update is ready @ https://github.com/BookStackApp/website/pull/49
Now updating the install scripts.


Update signup page content

Description
Content update - signup form edition
This PR updates the layout and content of the signup form. Unfortunately it required a new component so that's been bundled in here as well. I'm sorry this is so huge.
Acceptance Criteria
The signup page matches what is in the designs.
Test Instructions

Navigate to the signup form
Verify that the content/layout matches the designs in Figma

Help Requested

There is something not working quite right with spacing in one checkbox lists - please advise

Checklist

[x] Strings use placeholders for translation (No hard coded strings)
[x] Unit tests have been added/updated

Product and Sprint Backlog
Trello

Sorry I didn't explain well, only the first list has spacing the rest doesn't.

Good call Ephraim I'll rescind my review.


Global logger API

Currently we have a logging call that are tied to an instance of the LMS7002M driver code, but we use a fair bit of prints and logging outside of that. I think that there should be a global logger that has a default printf handler, but can be swapped out by a GUI handler, etc...

@myriadrf/lime-suite-committers We really should get those printfs out of the code so they can be redirected to guis, files, etc; or not interfere with certain applications. I got started on a logging API - https://github.com/myriadrf/LimeSuite/blob/logging/src/Logger.h
//replace a printf like this
- printf("libusb error so and so %s", libusb_error(code));
+ lime::error("libusb error so and so %s", libusb_error(code));

Since we have a logger API for LMS7002M class, but it misses all of the messages for the connection instance and others stuff in the library -- I would like to remove the LMS7002M logger entirely and call directly into the global Logger.h. This implies

[ ] Removing logger API in LMS7002M
[ ] Change printf and LMS7002M log calls to Logger.h
[ ] wx top level frame needs hooks for global logger callback (just like it did for LMS7002M)
[ ] implies lime/API.h changes for the logger callback

Thoughts about any of this before continuing? Global logger vs per LMS7002M instance?


Reconfigure Dart away from stale grammer repo

Description
Reconfigure the highlighter for Dart away from Dart Atom which is no longer being maintained to a new highlighter under the dart-lang org.
Checklist:

[X] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/?utf8=✓&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fgithub.com%2Fdart-atom%2Fdart%2Fblob%2Fmaster%2Fgrammars%2Fdart.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fgist.githubusercontent.com%2Fmit-mit%2Fb8549d317f24e8b9cdd618fc92c11aa7%2Fraw%2Fe13f789d71b55c9767030bd448eefc2d49e4ff23%2Fnewfeatures.dart&code=

New: https://github-lightshow.herokuapp.com/?utf8=✓&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fgithub.com%2Fdart-lang%2Fdart-syntax-highlight%2Fblob%2Fmaster%2Fgrammars%2Fdart.json&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fgist.githubusercontent.com%2Fmit-mit%2Fb8549d317f24e8b9cdd618fc92c11aa7%2Fraw%2Fe13f789d71b55c9767030bd448eefc2d49e4ff23%2Fnewfeatures.dart&code=

There are not a lot of changes right now (if any), but we're about to deprecate the dart-atom repo, and it will no longer be maintained.

Replaced by https://github.com/github/linguist/pull/4820

Please use the script provided in the contribution guidelines to change the grammar.
Done in #4820

Also, note that the new grammar repository doesn't have a license.
Fixed


Firefox Theme

Hello, first of all thanks for making this, I found it perfect for system-wide usage so i made a firefox theme using your color palette. I made sure to credit you in the theme summary and link to this github page. I'd like for it to be added to the README if possible. Any suggestions or fixes on the design are welcome!
If you prefer distribution by an xpi file and/or want me to remove it from the firefox store just mention it.
Link: https://addons.mozilla.org/en-US/firefox/addon/mountain_theme/

Hey, this looks awesome! I'd love to put the.xpi file in the repo, so feel free to add a PR for that :) Within the PR you submit, I'd prefer for you to follow the format I use for all the other themes, and then make a README inside of the subfolder with a small description about your theme. This isn't really an ISSUE per se, so I'm gonna close it, but I'm looking forward to distributing your theme!

Hey, this looks awesome! I'd love to put the.xpi file in the repo, so feel free to add a PR for that :) Within the PR you submit, I'd prefer for you to follow the format I use for all the other themes, and then make a README inside of the subfolder with a small description about your theme. This isn't really an ISSUE per se, so I'm gonna close it, but I'm looking forward to distributing your theme!


Mulit click issue

When I click  button1 and did't touch up, another click   button2 down and up.
Unfortunaly, button2 work.
How can I do to solve the situation in global project

I think you're talking about touching and holding on button 1, meanwhile tapping button 2 with another finger.  In that case, I see that both Flutter and native Android register the tap on button 2.
What do you expect to happen?  Can you provide a sample app that demonstrates the problem?

I wish tapping button2 is not work when I hold on button1.
Another, what can I do if tap button1 an button2 at same time.I don't wish both work

I'm going to close this because Flutter seems to behave the same way that both native iOS and Android do for both of your cases.
However, it's probably possible to create the behavior that you want manually in Flutter.  If you want really fine grained control over the tap events that happen to your buttons, you could try wrapping them in GestureDetectors.  Then you could use onTapDown and onTapUp to set and unset a flag that prevents other buttons from being pressed.

I try the both way:

"android:splitMotionEvents=”false”"
2.
Howerver, it doesn't work in flutter through android native. @justinmc


[Discussion]: Project Becoming Dead!

Overview
Hi!
Thanks for this Awesome smooth experience KeePass Client app!
I love this app look,design,smoothness,data history everything!
But the thing i fear is KeePass client projects get unmaintained or dead soon!
That's why i am asking you about this project future!

Hi,
Initially I've created this project for myself, as I need an application that can read KeePass database and keep it in sync with some server. Mostly because KeePassDX didn't allow to do that and other apps were outdated. So, the main driving force of this project is my personal need to use KeePass database.
There is a board with all features that I'm going to implement in the future. But as I'm the only one active maintainer it is moving forward slowly.


xtensa/esp32s3: Support multiple PHY init data bin

Summary

Support partition and OTA device
Support multiple PHY init data bin

Impact
Testing
If CONFIG_ESP32S3_PHY_INIT_DATA_IN_PARTITION and CONFIG_ESP32S3_SUPPORT_MULTIPLE_PHY_INIT_DATA are enabled, PHY initialization data (PHY initialization data is used for RF calibration) will be loaded from a partition, make sure that PHY data partition is included (type: 'data', subtype: 'phy').
The corresponding PHY init data type can be automatically switched according to the country code, China's PHY init data bin is used by default, country code can be modified through the wapi command: wapi country <ifname> <country code>.
Successful execution of wapi country <ifname> <country code> in esp32s3-devkit:wifi with CONFIG_ESP32S3_PHY_INIT_DATA_IN_PARTITION=y and CONFIG_ESP32S3_SUPPORT_MULTIPLE_PHY_INIT_DATA=y

I'm running some local testing. Please don't merge it yet.


Fix bug in AtomicWaker

The original implementation of AtomicWaker required calls to
register to be coordinated. As such, there could be no concurrent
updates to the waker.
This requirement was removed by adding some additional internal
coordination to allow concurrent calls to register. However, this
change left an instance of the waker handle being used outside of the
coordination logic.
This patch fixes the bug by moving the usage of the waker instance
inside the lock's critical section.
This patch also reduces spurious notifications by removing the waker
once it has been notified.

Thanks for the fix to that race!

This patch also reduces spurious notifications by removing the waker
once it has been notified.

This breaks existing code that I've written in the past which assumes that a task will be re-notified without needing to reregister so long as the task hasn't changed. I think it's fine to sacrifice that optimization for the sake of preventing redundant wakeups, but we should definitely take care to document the behavior here. Would you mind adding some comments to the docs explaining the new behavior?
cc @alexcrichton have you written anything else that made the same assumption?

The current docs say:

Consumers should call register before checking the result of a computation and producers should call notify after producing the computation (this differs from the usual thread::park pattern).

I agree this is isn't clear. what do you think would be clearer?

Maybe something like this? "Users should call register with a new Waker each time they require a wakeup. When notify is called, the current Waker is awoken and deregistered."

Updated w/ an example.

Thanks!


Doc: update the switcher conf to pyansys-action-v4 layout.

Update the switcher config for gh-pages layout.
Update the dependabot location for package manifest

LGTM.


Fix debug logging of stream refcounts.

Ever since @arjunroy's #18407, the stream_refcount tracer (which, confusingly, is also used for channel refcounting) has stopped actually including the refcount in its logging, which severely limits its usefulness.  I've had a couple of different occassions when I've needed to manually change it in order to get useful output while debugging a channel ref-counting problem, so I think we need to fix this so that that stops being an issue.
This PR attempts to fix this in a slighty sub-optimal way: it passes the stream refcount tracer into grpc_core::RefCount, which results in duplicate log messages, each with a slightly different subset of information: one from grpc_stream_refcount and another from the underlying grpc_core::RefCount object.  This is not ideal, because it would be better to include all the information in a single log message, but I don't see a reasonable way to do that without breaking API boundaries.  I'd be open to better suggestions here.
This change only affects debug builds, so I don't think there will be any performance impact that we care about, but please confirm that seems correct.
Thanks!

This change only affects debug builds, so I don't think there will be any performance impact that we care about, but please confirm that seems correct.

Thank you for the patch @markdroth ! For my understanding, grpc_client_channel_routing_trace is not a debug-only flag, so this would change the non-debug builds, right?
Since grpc_client_channel_routing_trace is per channel data, I don't think it would make any performance diff at least for our benchmarks.

This actually affects the stream_refcount tracer more than the client_channel_routing tracer.
I agree that the performance impact of the two additional trace lines I added for the client_channel_routing tracer will not have any performance impact that we care about.

We can also change reason to include the other info in the first log and pass the augmented reason to RefCount.

I thought about that, but that would require memory allocation for the new combined reason string, which seems less efficient.

But it's already debug build, if it can help to debug more easily, it's worthwhile.

It looks like the main additional piece of information here is the address of the destruction function.  I think we're probably better off logging that when we actually invoke it, rather than as part of each ref and unref.
In any case, future improvements here can be done in a separate PR.  I think this one is good enough to solve the immediate problem.

Alternatively, we can change RefNonZero() to return the new refcount so that the user of RefCount will be responsible for refcount logging. But that's a bigger change because Unref() will change the return type from bool to size_t.

Known issues: #19338 #19005 #18616

I don't think it's a good idea to change RefIfNonZero() to return the refcount, since that information should really not be leaked to the caller.  I don't want to open the door to cases where the caller does different things based on the current ref-count.


SAA-642: Updated attendance description for "NOT_REQUIRED"

Overview
Updates "NOT_REQUIRED" attendance description to "Not required or excused"

Codecov Report
Patch and project coverage have no change.

Comparison is base (aacfcba) 85.65% compared to head (422f4b5) 85.65%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #397   +/-   ##
=========================================
  Coverage     85.65%   85.65%
  Complexity     2017     2017
=========================================
  Files           273      273
  Lines          7625     7625
  Branches        426      426
=========================================
  Hits           6531     6531
  Misses          862      862
  Partials        232      232

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Reformat signal into a list

Make Dataset contain a dictionary
Extend signal into a list of strings
Align NLopt and SciPy optimisers with set_max_iterations
Parameterise test_spm_optimisers and add test_multiple_signals
Update Changelog

Thanks very much for the review @BradyPlanden! It would be great if you could double check the 3 conversations above and either add more info or mark as resolved.