Add Multi-Dimentional LSTM

implementation of Multi-Dimentional LSTM described in https://www.cs.toronto.edu/~graves/nips_2008.pdf

Can one of the admins verify this patch?

I signed it!

Hi, what's the difference between this and ndlstm?
https://github.com/tensorflow/tensorflow/blob/r1.1/tensorflow/contrib/ndlstm/python/__init__.py
On Jun 11, 2017 9:28 AM, "Shanqing Cai"<EMAIL_ADDRESS>wrote:

Assigned #10615 https://github.com/tensorflow/tensorflow/pull/10615 to
@ebrevdo https://github.com/ebrevdo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/10615#event-1118575505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtim7uy8WDV7J1R_wPj9TdNm9hTWP-Oks5sDBWWgaJpZM4N2LmH
.

It splits images in blocks(rectangles). Lstm cell get states from both neighbors at once.  ndlstm just run bidirectional rnn on lines and columns.

Jenkins, test this please.

Jenkins, test this please.

Jenkins, test this please.

This failed the sanity test, please try to build on your end.
ERROR: /workspace/tensorflow/contrib/mdlstm/BUILD:12:1: no such target '//tensorflow/contrib:rnn_py': target 'rnn_py' not declared in package 'tensorflow/contrib' defined by /workspace/tensorflow/contrib/BUILD and referenced by '//tensorflow/contrib/mdlstm:mdlstm'.
ERROR: /workspace/tensorflow/contrib/mdlstm/BUILD:12:1: no such package 'tensorflow/python/framework': BUILD file not found on package path and referenced by '//tensorflow/contrib/mdlstm:mdlstm'.
ERROR: Analysis of target '//tensorflow/contrib/mdlstm:mdlstm' failed; build aborted.
INFO: Elapsed time: 7.597s

can someone help me with including dependencies in the BUILD file?

It's //tensorflow/contrib/rnn:rnn_py and //tensorflow/python/core:framework respectively.

Jenkins, test this please.

Jenkins, test this please.

Jenkins, test this please.

what does it mean?
[Set GitHub commit status (universal)] PENDING on repos [] (sha:905bfc7) with context:tensorflow-pull-requests-cpu Unable to get pull request builder trigger!! Setting status of 954d61d3002774b373b2f698c93c27bf8d4d5ab4 to FAILURE with url https://ci.tensorflow.org/job/tensorflow-pull-requests-cpu/5532/ and message: 'FAILURE

@tensorflow-jenkins test this please

The sanity check fails because of formatting errors in BUILD files and Python code:
==== Summary of sanity check results ====

do_pylint PYTHON2: Python 2 pylint
FAIL
do_pylint PYTHON3: Python 3 pylint
FAIL
do_buildifier: buildifier check
FAIL

https://ci.tensorflow.org/job/tensorflow-pull-requests-sanity/5358/consoleFull

thanks for information, i will fix the build as sugested and the pylint errors!

@tensorflow-jenkins test this please

@johnsmithm It looks like there are a few more errors to resolve.
https://ci.tensorflow.org/job/tensorflow-pull-requests-multijob/6413/

i do not know how to add dependencies to pip_packages:
Missing dependency: //tensorflow/contrib/mdlstm:mdlstm
also buildifier failed, and i do not know what to change.
is there a documentation how to write BUILD file?

@johnsmithm You should be able to add a dependence on //tensorflow/contrib/mdlstm:mdlstm to what ever target needs it in your new code.
You can format the BUILD file with the buildifier tool. There is a script to install it here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/install/install_buildifier.sh
It might also add the missing dependency for you, but make sure it doesn't make unintended changes to other targets.

@tensorflow-jenkins test this please

@drpngx @ebrevdo can you help @johnsmithm fixing the missing pip dependency? Thanks.
https://ci.tensorflow.org/job/tensorflow-pull-requests-sanity/5855/console

I would try to add the dependency here:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/pip_package/BUILD#L155
Does this build under windows? If so, try this too:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/pip_package/BUILD#L88

@johnsmithm Any luck with this?

@johnsmithm ping

i still don't know how to sort the dependencies, what is the correct order.

You can use buildifier to automatically format your BUILD file. https://github.com/bazelbuild/buildtools#buildifier

I'll close this PR due to inactivity. If you continue working on it, I'm happy to reopen it, or you can just start a new one.


Teamcity

Integration tests passing
1 Unit test still failing, will need help on figuring out why...

Danger has errored
[!] Invalid Dangerfile file: Failed to open TCP connection to lgtm.in:80 (getaddrinfo: Name or service not known). Updating the Danger gem might fix the issue. Your Danger version: 5.5.3, latest Danger version: 5.5.12
 #  from Dangerfile:45
 #  -------------------------------------------
 #
 >  lgtm.check_lgtm
 #
 #  -------------------------------------------

  Generated by :no_entry_sign: Danger

Restarting the build. Only failing due to lgtm.in being unavailable as far as I can tell.


python client pre-registered in jumpscale

Pull request in jumpscale core:
https://github.com/Jumpscale/jumpscale_core8/pull/316/files

Readme:
https://github.com/Jumpscale/jumpscale_core8/blob/master/lib/JumpScale/clients/itsyouonline/readme.md

Added to the technical introduction as well


HTTP ERROR 500 when trying to save

I'm experiencing some HTTP ERROR 500 when i try to save my changes. I've been using the blacklist in other wordpress installations and this is the first time that these happen. Could you give me some recommendations of why this may be happening. Thank you very much.

The 500 code indicates an “Internal Server Error” which could mean many things.
Is the WordPress installation where you are seeing this error on the same server (or web host) as the other installations which are working? If it’s a different server or host, then it could be something to do with the server configuration for timeouts or the size of data allowed to be submitted in a form (which is how the WordPress settings are handled).
For example, Media Temple lists one of the possible causes of a 500 error as PHP code timing out or taking too long to execute.
Media Temple: Why am I getting a 500 Internal Server Error message?

Where is this WordPress installation hosted?

Hello, sorry for the late response. Thank you for your support. It was a simple fix, as you commented, the error was due to PHP code timing out. So, i just increased the PHP memory to 256M. And that was it. So, thank you again for the support and for compiling this list.

Happy to hear that you solved the issue.


[WIP] Porting manual parsing to Jackson.

This may need redefining or modifying current data structures of Escher components. Once complete, the EscherParser can be removed safely, delegating all the parsing work to Jackson's ObjectMapper.

Since there were some issues with the old models, they can't be used to deserialize using Jackson's ObjectMapper. Therefore, I've added some new models in jc_models package. And also for just now, an EscherDeserialize class is also made to read an Escher file and dump it again. Current issues are:

void setter methods are also getting serialized (weird).
Some extra properties are also added.
Written map can't be read by Escher.

Done in #11.


Add Footer

We can have a footer at the end saying "copyright reserved" or something else you find more suitable. We can also add contacts so that developers/users can reach out to us and give feedback.
I would like to implement this feature. Please assign it to me.
Thanks.

i want to work on this issue can you please assign it to me

I have already issued it to someone else

Ok Sir It's Fine


HADOOP-17894. CredentialProviderFactory.getProviders() recursion loading JCEKS file from S3A

CredentialProviderFactory to detect and report on recursion.
S3AFS to remove incompatible providers.
ITest for this.

Tested: s3a london; new test done, full test in progress

testing :  mvit -Dparallel-tests -DtestsThreadCount=8 -Dmarkers=keep

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 27s

trunk passed

+1 :green_heart:
compile
23m 56s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 11s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 49s

trunk passed

+1 :green_heart:
mvnsite
2m 28s

trunk passed

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 55s

trunk passed

+1 :green_heart:
shadedclient
15m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 32s

the patch passed

+1 :green_heart:
compile
23m 49s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m 49s

the patch passed

+1 :green_heart:
compile
20m 51s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
20m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 19s
/results-checkstyle-root.txt
root: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)

+1 :green_heart:
mvnsite
2m 38s

the patch passed

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 24s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 19s

the patch passed

+1 :green_heart:
shadedclient
17m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 54s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 33s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

211m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3393/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 1880c3e4d604 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a3e63d24fa63678c478a5b4f67301bed22f6109e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3393/1/testReport/

Max. process+thread count
3152 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3393/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 33s

trunk passed

+1 :green_heart:
compile
24m 16s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m  0s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 57s

trunk passed

+1 :green_heart:
mvnsite
2m 36s

trunk passed

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 25s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m  4s

trunk passed

+1 :green_heart:
shadedclient
17m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 41s

the patch passed

+1 :green_heart:
compile
22m  8s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m  8s

the patch passed

+1 :green_heart:
compile
18m 34s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
18m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 33s

the patch passed

+1 :green_heart:
mvnsite
2m 34s

the patch passed

+1 :green_heart:
javadoc
1m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m  8s

the patch passed

+1 :green_heart:
shadedclient
14m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m  8s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 31s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

210m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3393/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c6fcc718d83d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3854552e8273c2665526f9643f58d23d9d0dd656

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3393/2/testReport/

Max. process+thread count
1267 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3393/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


@page @model IndexModel @{     ViewData["Title"] = "Home page"; }   Welcome Hello, world! The time on the server is @DateTime.Now

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.


Stream Processing Workflow

Summary
Streaming Workflow is consuming every record from the stream and flow through the DAG/STEP workflow defined in YAML.
Each step or task is a long-running container so it will process the data immediately. Step/task can be horizontally scale based on stream partitions.
The controller will manage the entire stream flow orchestration between steps/tasks.
What change you think needs making.
Motivation
Real-time Data processing workflow
Please give examples of your use case, e.g. when would you use this.
Proposal
TBD (might be a separate project)
How do you think this should be implemented?

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

Very High-level  Architecture thought:

It's an interesting idea. Could you share the real-world use case so we can get your idea more clearly? And I also want to know, why the current Argo workflow doesn't cover such use case.

I might have one. We are producing some data into Kafka and there are a set of ML models that could be executed by the same data and we would like to combine those model outputs in some way (say, a linear combination of all the model's output) then return the value into another kafka topic so our down stream consumer can use the output.

@mac9416 @Naveenlbg @nopanderer @gethinzhang @ptitpoulpe @andaag @terrytangyuan @xianlubird  @mfasanya
Thanks for your support and interest in Stream processing Workflow. I am looking for a multiple  use-cases or requirements to start this project. Can you please let us know your requirements for stream processing?

I might have one. We are producing some data into Kafka and there are a set of ML models that could be executed by the same data and we would like to combine those model outputs in some way (say, a linear combination of all the model's output) then return the value into another kafka topic so our down stream consumer can use the output.

Airflow or StreamSets + Spark Streaming might be better option, we have the same use case with you.

People wanting to do stream processing might want to take a look at Argo Dataflow PoC:
https://github.com/argoproj-labs/argo-dataflow


【Windows】The problem of GPU usage being too high.

Just loading a static page, but the GPU usage is still around 10%, and it feels like the components are constantly refreshing internally.

Some of our important clients keep giving feedback on this, please take a look.

Have you tried passing --disable-gpu-vsync to WebviewController.initializeEnvironment?
example:
WebviewController.initializeEnvironment(additionalArguments: '--disable-gpu-vsync')

Have you tried passing --disable-gpu-vsync to WebviewController.initializeEnvironment?
example: WebviewController.initializeEnvironment(additionalArguments: '--disable-gpu-vsync')

I'm having the same problem and I tried @jnschulze suggestion but it did not work for me. GPU usage remains unexpectedly high


tour:packages.go bug in code

This line of code is missing the param in the print statment. It does not print correctly when I tried it locally.
fmt.Println("My favorite number is", rand.Intn(10))
It should be
fmt.Printf("My favorite number is %d\n", rand.Intn(10))

I think there's a slight confusion between fmt.Println & fmt.Printf. Println doesn't require the %d verb:

Spaces are always added between operands and a newline is appended.

from the docs
So in fmt.Println("My favorite number is", rand.Intn(10)), a space will be added between the string "My favorite number is" and the result of rand.Intn(10) and then appended with a newline and printed out.
The line of code above works fine in the Go Playground
I believe this issue can be closed @pmoh @adg

Thanks I was still using the Printf from hello world program. Thanks.


Update index.md

add modulo next to remainder since that is what it is referred to in javascript

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi,
Thanks for this pull request (PR).
Unfortunately, we are marking this PR invalid for hacktoberfest. We believe it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details
In JavaScript, the % is the remainder operator and not to be confused with the modulo available in other languages.


Allow Hardhat to deploy smart contracts

Problem
Currently, users will get Internal error when using Hardhat to deploy a smart contract. The transaction contains INVALID_SOLIDITY_ADDRESS error as shown in https://hashscan.io/#/testnet/transaction/0.0.46030734-1655918065-252797715?t=1655918078.085442000
Please feel free to use the following script to reproduce the problem
https://github.com/pathornteng/hedera-hardhat
Note: I can use Truffle to deploy a smart contract to Hedera network just fine.
Solution
Hardhat might be using different formats or values. Further investigation is required.
Alternatives
No response

Likely related to #193
Let's investigate why truffle works fine, does it just not check for a valid contract id?

@natanasow You are right. I removed the console.log and it works!
Thanks for the answer :)


Mrustc 0.11.0's rustc-1.74.0-src.patch does not apply cleanly

$ git clone https://github.com/thepowersgang/mrustc --branch=v0.11.0
$ cd mrustc
$ export RUSTC_VERSION=1.74.0 MRUSTC_TARGET_VER=1.74
$ make RUSTCSRC

Output on Ubuntu 24.04 (GNU patch 2.7.6):
make -f minicargo.mk RUSTCSRC
make[1]: Entering directory '/git/tmp/repro/mrustc'
[CURL] rustc-1.74.0-src.tar.gz
tar -xf rustc-1.74.0-src.tar.gz
touch rustc-1.74.0-src/extracted
cd rustc-1.74.0-src/ && patch -p0 < ../rustc-1.74.0-src.patch;
patching file compiler/rustc_parse_format/src/lib.rs
patching file compiler/rustc_ast/src/ast.rs
patching file compiler/rustc_hir/src/hir.rs
patching file compiler/rustc_errors/src/lib.rs
patching file compiler/rustc_const_eval/src/interpret/operand.rs
patching file compiler/rustc_const_eval/src/interpret/place.rs
patching file compiler/rustc_index/src/bit_set.rs
patching file library/std/src/sys_common/wtf8.rs
patching file compiler/rustc_ast/src/tokenstream.rs
patching file compiler/rustc_middle/src/mir/consts.rs
patching file compiler/rustc_middle/src/mir/interpret/value.rs
patching file compiler/rustc_middle/src/mir/syntax.rs
patching file compiler/rustc_middle/src/mir/mod.rs
patching file compiler/rustc_middle/src/ty/consts/kind.rs
patching file vendor/hex/src/lib.rs
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 239 with fuzz 1.
touch rustc-1.74.0-src//dl-version
make[1]: Leaving directory '/git/tmp/repro/mrustc'

Output on macOS 15.1.1 (patch 2.0-12u11-Apple):
/Library/Developer/CommandLineTools/usr/bin/make -f minicargo.mk RUSTCSRC
[CURL] rustc-1.74.0-src.tar.gz
tar -xf rustc-1.74.0-src.tar.gz
touch rustc-1.74.0-src/extracted
cd rustc-1.74.0-src/ && patch -p0 < ../rustc-1.74.0-src.patch;
patching file 'compiler/rustc_parse_format/src/lib.rs'
patching file 'compiler/rustc_ast/src/ast.rs'
patching file 'compiler/rustc_hir/src/hir.rs'
patching file 'compiler/rustc_errors/src/lib.rs'
patching file 'compiler/rustc_const_eval/src/interpret/operand.rs'
patching file 'compiler/rustc_const_eval/src/interpret/place.rs'
patching file 'compiler/rustc_index/src/bit_set.rs'
patching file 'library/std/src/sys_common/wtf8.rs'
patching file 'compiler/rustc_ast/src/tokenstream.rs'
patching file 'compiler/rustc_middle/src/mir/consts.rs'
1 out of 1 hunks failed--saving rejects to 'compiler/rustc_middle/src/mir/consts.rs.rej'
patching file 'compiler/rustc_middle/src/mir/interpret/value.rs'
1 out of 1 hunks failed--saving rejects to 'compiler/rustc_middle/src/mir/interpret/value.rs.rej'
patching file 'compiler/rustc_middle/src/mir/syntax.rs'
patching file 'compiler/rustc_middle/src/mir/mod.rs'
patching file 'compiler/rustc_middle/src/ty/consts/kind.rs'
1 out of 1 hunks failed--saving rejects to 'compiler/rustc_middle/src/ty/consts/kind.rs.rej'
patching file 'vendor/hex/src/lib.rs'
1 out of 1 hunks failed--saving rejects to 'vendor/hex/src/lib.rs.rej'
make[1]: *** [rustc-1.74.0-src//dl-version] Error 1
make: *** [RUSTCSRC] Error 2

The content of the .rej files, in the same order as the log above:
@@ -73,2 +73,2 @@
-#[cfg(all(target_arch = "x86_64", target_pointer_width = "64"))]
+#[cfg(all(target_arch = "x86_64", target_pointer_width = "64", not(rust_compiler = "mrustc")))]
 static_assert_size!(ConstValue<'_>, 24);

@@ -37,2 +37,2 @@
-#[cfg(all(target_arch = "x86_64", target_pointer_width = "64"))]
+#[cfg(all(target_arch = "x86_64", target_pointer_width = "64", not(rust_compiler = "mrustc")))]
 static_assert_size!(Scalar, 24);

@@ -75,2 +75,2 @@
-#[cfg(all(target_arch = "x86_64", target_pointer_width = "64"))]
+#[cfg(all(target_arch = "x86_64", target_pointer_width = "64", not(rust_compiler = "mrustc")))]
 static_assert_size!(Expr<'_>, 24);

@@ -239,2 +239,2 @@
-#[cfg(target_pointer_width = "64")]
+#[cfg(all(target_pointer_width = "64", not(rust_compiler = "mrustc")))]
 from_hex_array_impl! {
\ No newline at end of line

Odd, it works in CI (and locally)... although, I've seen issues attempting with patch not realizing that the files have already been patched.
Most of those patches are hand-crafted, so maybe there's something subtly wrong with them...

Probably the Apple patch wants to see at least 1 line of context before and after the lines changed. The hunks that failed to apply are exactly the ones without any context.

That could be it, silly apple

Hopefully fixed in bb8b59f16c3cd234f4f08102b57558748766dec0

Confirmed fixed. Thank you.


[release/1.7] Bump tags.cncf.io/container-device-interface to v0.7.2

This includes migrating from cdi.GetRegistry() to cdi.Configure() and using top-level cdi Refresh and InjectDevices functions as applicable.
This backports the changes from #10041 to support the v0.7.0 CDI spec version.

Looks like this can be updated to v0.7.2 now to get the updated/lowered dependency

Updated the PR. PTAL.


[LLM Runtime] OOM when running Llama2-70B, but not having this issue with llama.cpp

Current Behavior:

Doing a benchmark between llama.cpp and LLM Runtime to compare the speed-up I get. When running the llama2-70B model in ggml format int8 precision (weights + computation), with llama.cpp the model works fine, and take about 56% of my memory @2.43 tokens/sec. However, when I take the int8 ggml file to run it with LLM Runtime code, I get an OOM after getting stuck here:

Expected Behavior:

Naturally, I expect the int8 ggml file to work for LLM Runtime as well, and not have the OOM issue, since it worked with llama.cpp

In the documentation, u say that we can run the LLM Runtime with ggml format, so I don't even need to convert the model using your scripts. Am I right or I need to re-do the conversion + quantization starting from the HF model ?

Steps To Reproduce:

For llama.cpp, I just followed the instructions in the official documentation, and I run the following commands:

python convert.py <model-path> # to F16
quantize.exe ggml-model-q8_0.bin q8_0
main.exe -m ggml-model-q8_0.bin -p "Building a website can be done in 10 simple steps:" -n 512 -gqa 8 --no-mmap --ignore-eos

For LLM Runtime, I took the int8 ggml file obtained before, and run it directly with the inference script:

python scripts/inference.py --model_name llama2 -m ggml-model-q8_0.bin -n 512 -p "Building a website can be done in 10 simple steps:"

Environment:

OS: Windows 11
HW: SPR w9-3595X E5 128GB

Hi aahouzi
You can’t feed ggml bin to our framework directly.
we can only support the bin file generated by us, we have our format of bin.
In the feature we will support GGUF format model, at that feature, you can use llama.cpp gguf as well.
Regards,
Bo

Hi @aahouzi
Two tips~~
Please re-do the conversion + quantization q4_0 to check the pipeline on your machine.
Please use the  --model_name llama rather than llama2 when inference, but it works for llama & llama2. Llama & Llama2 have the same model structure, here we only accept the 'llama'.

I tried doing the conversion with your scripts, and now it's working. Thanks for ur help !


Support connecting to UNIX sockets

version: current git as of 20180210
MPD_HOST=/home/moonwind/.config/mpd/socket
MPD_PORT=6600
ls /home/moonwind/.config/mpd includes
srw-rw-rw- 1 moonwind moonwind    0 Jan  4 15:54 socket
My debug gives me:
[1.01009] Establishing MPD IDLE connection to /home/moonwind/.config/mpd/socket:6600...
[1.01097] ERROR: Error connecting to MPD: MPD connection error: dial tcp: lookup /home/moonwind/.config/mpd/socket: no such host
Ncmpcpp uses that socket just fine, so i'm not sure what's happening here. Is pms unable to use sockets?

That's right, unfortunately. Connecting to a socket is not supported presently.

Thank you. I hope that it's supported someday. In the mean time, I realized that I can activate both  the socket and the http port. It seems to lose that connection from time to time, and the elapsed time doesn't reset when going to a new track. These may or may not be related issues.

Thank you. I hope that it's supported someday. In the mean time, I realized that I can activate both  the socket and the http port. It seems to lose that connection from time to time, and then the elapsed time doesn't reset when going to a new track. These may or may not be related issues.

Thank you!


Develop additional tests (Galata and axe-core)

Gabriel to work on how to mush together axe-core with Playwright tests

@gabalafou  has worked on this - will close in favour of a tracking of tests in the roadmap


Segmentation Fault in GNOME

Hi,
I am running into seg fault when using GNOME (using hyprland works fine). Here is the debug output:
jaime@jaime-laptop:~/Downloads/tofi (master) $ ./build/tofi-run -c themes/dmenu
[    real,      cpu,   maxRSS]
[0.000000, 0.003660,  5920 KB][DEBUG]: This is tofi.
[0.000247, 0.003895,  8312 KB][DEBUG]: Loading config file themes/dmenu.
[0.000277, 0.003924,  8312 KB][DEBUG]: Config done.
[0.000289, 0.003936,  8312 KB][DEBUG]: Connecting to Wayland display.
[0.000321, 0.003968,  8312 KB][DEBUG]: Creating xkb context.
[0.000342, 0.003989,  8472 KB][DEBUG]: First roundtrip start.
[0.000607, 0.004036,  8472 KB][DEBUG]:     Bound to compositor 1.
[0.000615, 0.004044,  8472 KB][DEBUG]:     Bound to shm 3.
[0.000620, 0.004048,  8472 KB][DEBUG]:     Bound to output 4.
[0.000623, 0.004052,  8472 KB][DEBUG]:     Bound to data device manager  6.
[0.000628, 0.004056,  8472 KB][DEBUG]:     Bound to wp_viewporter 11.
[0.000631, 0.004060,  8472 KB][DEBUG]:     Bound to wp_fractional_scale_manager_v1 12.
[0.000635, 0.004064,  8472 KB][DEBUG]:     Bound to seat 15.
[0.000642, 0.004070,  8472 KB][DEBUG]: First roundtrip done.
[0.000644, 0.004072,  8472 KB][DEBUG]: Second roundtrip start.
[0.000812, 0.004111,  8472 KB][DEBUG]:     Output configuration done.
[0.000820, 0.004119,  8472 KB][DEBUG]:     Got keyboard from seat.
[0.000823, 0.004122,  8472 KB][DEBUG]:     Got pointer from seat.
[0.000827, 0.004125,  8472 KB][DEBUG]: Second roundtrip done.
[0.000829, 0.004127,  8472 KB][DEBUG]: Determining output.
zsh: segmentation fault (core dumped)  ./build/tofi-run -c themes/dmenu

Let me know if you need more information. Thanks!

Have you tried without the dmenu theme?

Oh actually, this is wlroots based so I think it'll work with Gnome.


Debranding

using a variable for the branding... fixes #41

TODO render the variable value of help rather than the {{}}

@jrwdunham  this one is ready for review

same deal for htis one, i cherry picked the old commits onto your master, resolved conflicts but you need to merge #114 because this has the same build problem as your master


Provide Grape auto-reloading via Railtie

We now have working code for #131. Maybe that can be provided automatically as a Railtie?

10 year anniversary soon!


Update README.md

Added useState and useCallback import to the example code in README.md file.

Thank you


SVD threading issue (lapack.dgesdd)

Hi
I noticed SVD decomposition retuns wrong results when
invoking this method concurrently on the multithreaded environment:

fails on: com.github.fommil.netlib.NativeRefLAPACK (netlib-native_ref-win-x86_64.dll)
fails on: com.github.fommil.netlib.NativeSystemLAPACK (netlib-native_system-win-x86_64.dll)
success on: com.github.fommil.netlib.NativeSystemLAPACK (netlib-native_system-linux-x86_64.so)
success on: com.github.fommil.netlib.F2jLAPACK

Not sure if this is matter of glue code or LAPACK itself. Wrapping SVD method invocation
in the synchronization block helps (produces same results as when running single-threaded).
I noticedthat this issue affects only left/right vectors,
singular values seem to be fine.
Please take a look at sample code below:
object BreezeMultiThreading extends App {
  implicit val ec: ExecutionContextExecutor = scala.concurrent.ExecutionContext.global
  val x = Seq.tabulate(1000) { i =>
    Future /*.successful*/ { // uncomment to run single-threaded
      println(s"Iteration $i")
      val rnd = new scala.util.Random(12345 + i)
      val input = DenseMatrix.tabulate[Double](100, 100)((_,_) => rnd.nextDouble())
      val svdec = svd(input)
      // val sum = svdec.singularValues.valuesIterator.sum
      val sum = svdec.leftVectors.valuesIterator.sum + svdec.rightVectors.valuesIterator.sum
      sum
    }
  }

  val sum = Await.result(Future.sequence(x).map(_.sum), Duration.Inf)
  // val exp =<PHONE_NUMBER>4463 // singular values
  val exp = -19997.446618756203 // left/right vectors
  if (abs(sum - exp) < 0.00001)
    Console.out.println(s"Success: $sum")
  else
    Console.err.println(s"Failed: $sum, expected: $exp")
}

marcin

sorry for being slow. it's suspicious to me this only happens on windows so i doubt it's the glue code. I can add a lock if we're running on windows, i guess?


[benchmark] migrate to fsdp/ddp after jit, from fsdp/ddp before jit

Llama-2-7b-hf & fsdp
container of 20240804. 8 H100 80GB HBM3.
command: torchrun --nproc_per_node=8 thunder/benchmarks/benchmark_litgpt.py --compile=thunder_inductor_cat --model_name=Llama-2-7b-hf --distributed_mode=fsdp --shard_mode=zero2 --bucketing_mode=none

main 0f34c06
pr 158e3ac

token/s
82717.33
82626.89

tokens/s/GPU
10339.67
10328.36

Memory
40.99 GB
54.47 GB

cc @mpatel31415

There may already be a plan for this since this is still a draft and apologies if I am jumping ahead but given the big increase in memory consumption with this change and many workloads from @mpatel31415's benchmarks already failing with OOM error, do you think we can make this change optional?

Just so I understand the snapshot above, the blue markers are memory allocation during the training step right? Do we know the reason why fsdp(jit(model)) has higher consumption? Is it because once the model is jit, it cannot shard all the parameters as some get hidden inside fusion blocks? Or perhaps, fsdp after jit means it has to AllGather larger buckets due to fusion blocks?

Just so I understand the snapshot above, the blue markers are memory allocation during the training step right? Do we know the reason why fsdp(jit(model)) has higher consumption? Is it because once the model is jit, it cannot shard all the parameters as some get hidden inside fusion blocks? Or perhaps, fsdp after jit means it has to AllGather larger buckets due to fusion blocks?

The piled layers that's spanning horizontally in the bottom capture seem to indicate that materialize and/or sharding of fsdp(jit(model)) leaves some parameters dangling somewhere while they are not used.
I do think it's because fsdp(jit(model)) copies params before sharding, after materializing while jit(fsdp(model)) directly applies sharding to params.
#932 would be a workaround when a model is initialized with torch.device("meta").


HTTP Error 401: Unauthorized (caused by HTTPError()) - Xfinity SSO?

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'--ap-mso', u'Comcast_SSO', u'--ap-username', u'PRIVATE', u'--ap-password', u'PRIVATE', u'https://www.nbc.com/american-ninja-warrior-junior/video/grand-finale/4177393']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.06.06
[debug] Python version 2.7.17 (CPython) - Linux-4.15.0-101-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg N-50726-g20c5f4d835-static, ffprobe N-50726-g20c5f4d835-static
[debug] Proxy map: {}
[NBC] 4177393: Downloading JSON metadata
[NBC] 4177393: Downloading Provider Redirect Page
[NBC] 4177393: Logging in
[NBC] 4177393: Retrieving Session
ERROR: Unable to download webpage: HTTP Error 401: Unauthorized (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 627, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2238, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

Description

I've tried this on 2 URLS which are different companies and url types. Both using Xfinity SSO
https://www.nbc.com/american-ninja-warrior-junior/video/grand-finale/4177393
https://disneynow.com/shows/mira-royal-detective/season-01/episode-11-mikku-and-chikku-doll-detectives-the-case-of-the-moving-day-meddler/vdka18668903
This episode didn't require auth, so it worked.
https://disneynow.com/shows/mira-royal-detective/season-01/episode-10-mystery-at-the-marketplace-mystery-in-the-sand-dunes/vdka18259064

I tried again, got a different error this time. Will close and open a new issue with different error


Disable the CrapMetric

This rule requires a Cobertura XML coverage file, which we should
provide with the coberturaXmlFile property. We don't have such a file,
so actually, this rule has never been working with groovylint.
Therefore we should just silence it.

ping @AbletonDevTools/gotham-city

How come is this popping-up only now?

@ala-ableton Because I only started paying close attention to CodeNarc's logging output when implementing https://github.com/AbletonDevTools/groovylint/pull/55. 😅 Codenarc has always emitted the following warning:
WARN org.codenarc.rule.size.CrapMetricRule - The Cobertura XML file [null] is not accessible; skipping this rule

...we just never bothered to do anything about it until now.

LGTM :+1:


Added section about using multiple SQL statements

As discussed in https://discuss.elastic.co/t/sql-last-value-doesnt-reiterate-with-multiple-jdbc-inputs/63523, this PR represents a doc update to include some guidance on using multiple SQL statements and the importance of last_run_metadata_path parameter when multiple statements also use the sql_last_value parameter for storing state.

LGTM


Change process for contributing a new standard:

Using Discussions is painful for many reasons:

Reviewers cannot easily reference or comment on specific lines of the spec.
Revisions are not accessible using common tools (e.g. git).
Standards tend to languish as Discussions indefinitely, even after they have been thoroughly discussed, and often fully implemented and deployed in production.
It it hard to see who has approved of a document because, unlike pull requests, a Discussion does not have recorded code reviews.
Search and sorting does not work as well as if the Drafts were present directly in a git repository.

This proposal changes the process to a simple code-review-like system where documents are encouraged to become PRs earlier:

Spec writers may collect community feedback in Discussions and/or conversations with others.
Drafts are created by adding a Markdown file to the repository and opening a pull request.
An XLS can be promoted to a Candidate Specification by a call for review from the community. This happens in the same manner as the vast majority of open source projects: by simply opening a PR that requests the change.

Let's figure out the most inclusive process where also "non-techies" have an easy way to interact on the XLS drafts. Moving to PRs too soon, will make interaction more difficult for a lot of people.
So I think the XLS should live as discussions until the discussion has largely settled – then from there the discussion can be archived and closed for further comments, and the contents can be moved to a PR for fine-tuning and alignment with e.g. implementation (if an amendment) and finally review as you outline.
Included in this update to the process should also be a markdown template for use, and in connection with https://github.com/XRPLF/xrpl-dev-portal/issues/1779 so final XLS's can easily be parsed and be included on xrpl.org.
CC @amarantha-k

So I think the XLS should live as discussions until the discussion has largely settled – then from there the discussion can be archived and closed for further comments, and the contents can be moved to a PR for fine-tuning and alignment with e.g. implementation (if an amendment) and finally review as you outline.

@Silkjaer - I like the intent of your comment, though I personally prefer PRs over GH Discussions for the reasons outlined in the description of this PR by @intelliot. Does Line 28 of the proposal seem like it leaves enough room for what you had in mind?

Does Line 28 of the proposal seem like it leaves enough room for what you had in mind?

No, as the proposal seems open an opportunity to "fast track" standard proposals, by skipping public discussions and going straight to PR. The discussion format is much more welcoming to non-developers, and the public discussion is, in my opinion, a much needed process for any standard proposal.
I agree that the features of PRs are much superior in terms of nitty gritty corrections and line-by-line comments and suggestions. There is no question in my mind whether they have to go there eventually. The original intent of the repo was for standards to be merged to code when they were no longer drafts – by moving to PR earlier that will be better enforced.

Have we reviewed the other tools on the market like discourse? I realize its "another platform" but they, and competitors, aim to solve the exact problems we may face here. So I think we should review those.
A community member really shouldn't have to know any code/git to put in an XLS and I would even view this part of XRPLF as a DAO with 2 parts. A open community interaction and a more advanced developer interaction.
Just some thoughts.

Have we reviewed the other tools on the market like discourse? I realize its "another platform" but they, and competitors, aim to solve the exact problems we may face here. So I think we should review those.
A community member really shouldn't have to know any code/git to put in an XLS and I would even view this part of XRPLF as a DAO with 2 parts. A open community interaction and a more advanced developer interaction.
Just some thoughts.

This is a great idea imo and i agree with @Silkjaer as well!
I think if anything we will have more community involvement in the future, lowering the entry barrier to participate could also encourage more users to move good discussions/suggestions to GH.

All feedback has been addressed.
It's fine to review other tools, but that is beyond the scope of this PR.

Thank you; feedback has been addressed.

Overall I feel like the template we have for future XLS specs can use some refinement, perhaps we can propose this as a separate addition in a future PR?

I'm not sure what you mean; are you referring to xls-template.md?
Yes, we can certainly propose any additions/refinement in future PR(s).

Feedback has been addressed.

xls-template.md

Yes I meant xls-template.md

xls-template.md

Yes I meant xls-template.md

Yes, you can/should propose any additions/refinement in future PRs. Thanks!

@Silkjaer Is there anything left from your perspective before you approve this PR?
I think we can always offer changes in future PRs, and this PR has been waiting quite a long time (so would like to merge it before it gets stale).
WDYT?

I'll do a full read through ASAP and merge unless anything pops up 👍🏻


Added Nav Hover as theme and added button to list

Changes proposed

Made the navbar sticky on the y-axis scroll by adding the sticky class to the outermost div element and setting top-0 and bg-black classes for styling.

Updated the structure of the navbar by moving the image and text into a div with the flex and items-center classes to align them horizontally.

Added a hover effect to the navbar links by modifying the className of the Link component to include text-white hover:text-[#194fbc] duration-500.

Added the "Join Us" button to the list

Screenshots

Hey there you were not assigned for the issue kindly wait until you get assign before creating a PR


peerDependency warning for<EMAIL_ADDRESS>

Hi there!
Pleased to be using your library in our project, however I keep receiving peerDep warnings from npm
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

We're using<EMAIL_ADDRESS>and this library still works a treat. Would it be alright if the peerDep was changed to "^4.1.3" to catch the other minor versions in sinon v4? Submitting a PR for this one now

Great idea, thanks!


Convert all specs from Specs2 to MUnit

This is a step to converting to CE3.

@ChristopherDavenport anything else you'd like to see to get this one merged?


show workspace id too, instead of just workspace name

Is your feature request related to a problem? Please describe.
I'm always frustrated when workspace have same name.
Describe the solution you'd like
A clear diference between workspaces names
Describe alternatives you've considered
Show workspace id + name
eg:
-----------------------
wrk_qwer MyWorkspaceOne
-----------------------
wrk_asdf MyWorkspaceOne
-----------------------
wrk_zxcv MyWorkspaceOne
-----------------------

or just give different color indicator for other workspace that have the same name


AltarNanotrasen-parented altars, which are thief objectives, are not mapped in every chapel

Description
The thief's objective AltarNanotrasenStealObjective requires you to steal any altar parented from AltarNanotrasen (e.g. druid altar, satan altar, toolbox altar). However, on Origin and Marathon, an AltarConvertRed (red altar) is mapped instead, and on Atlas, a wooden table is mapped instead. Reach doesn't have any altars, but I'm not sure if thieves can even trigger on Reach.
This makes achieving thief's objective on those maps much harder if not impossible. Yes, you may find one in maints or on the salvage wreck, but former requires an unreasonable amount of luck or experience to pull off and the latter doesn't mesh with the idea of what thief should be doing.
What should be done
One of the following:

Either AltarBase or AltarConvertFestival should get stealTarget as well, making all altars eligible for theft. The objective description should be changed to reflect that.
The altar theft objective should not trigger on maps where required altar is not mapped in the chapel
An AltarNanotrasen-parented altar should be mapped in the chapel on the affected maps instead of the current one.

~In any case:~
~0. An altar should be mapped in the Atlas chapel~
Atlas is being removed, so no need for this one I guess.
I am not sure why the objective didn't include those altars at all - are they reserved for some future event/antagonist, e.g. cult?
If there are no conflicts like this, I will implement p.1 once I have access to my desktop.
Screenshots
Marathon

Origin

Atlas

Oasis (correct altars)

UPD: I am working on this, will PR it in a few hours

I'm 90% sure most maps use the random altar spawner which includes all altars.
Probably best to just make the steal target be to steal any altar (though I'm not super sure this objective is very fun, but we'll see ig).


Modifying the header

Want to work on the header (Adding some CSS Effects) and linking the pages to one another.Will also add Favicon.

Go ahead @2024-SANDHYA.


stop publlishing sdists (fixes #162)

Fixes #162.
This is a pure-Python project supporting a wide range of Python versions, so I don't think there's any value in uploading both source distributions and wheels.
pip install pydistcheck should be able install pydistcheck-{version}-py3-none-any.whl on a very wide range of platforms.
benefits of this change
Slightly faster builds and releases in this repo.
A bit less surface area for packaging issues (and therefore maintenance burden).
A bit less storage and data transfer for PyPI.

Based on the discussions in https://discuss.python.org/t/purpose-of-an-sdist/4639/7, I think I've missed some important considerations. Like, for example, the the sdist may be used by re-packagers like conda.
And especially this comment: https://discuss.python.org/t/purpose-of-an-sdist/4639/14

[PyPI doesn't] encourage “binary only” projects, or even “binary available on PyPI, go here for the source”

And this one: https://discuss.python.org/t/purpose-of-an-sdist/4639/2

Many enterprise/OS distributions environments don’t allow installation of wheels due to auditing reasons

I looked around and saw that other python-only CLI projects also tend to produce both wheels and sdists.
I'm going to close thiis.


Custom hovers should hide when context menu shows

At least that is what native hovers do:

This is up to whoever is using the hover service to hide it when the context menu is triggered

@Tyriar isn't that a bad design choice though, everyone would need to listen to context menu visibility to hide the hover? I would think the hover service itself should listen on context menu visibility and then hide?

:+1: I'll add a IContextMenuService.onDidShowContextMenu and listen to that.


[openssl] Update openssl to 1.1.1d

This PR will upgrade vcpkg openssl to 1.1.1d and may not consider openssl-uwp. In any case, this work is still in progress.
Since openssl is dependent on many libraries, this PR faces more difficulties.

OS
OpenSSL Version
Details

Windows Desktop
1.1.1d
build ok, other ports no test

Windows UWP
1.1.1d
build ok. other ports no test

Unix
1.1.1d
grpc ok, curl ok.

Ports that need to be upgraded:

libpq
libssh

reference: https://github.com/microsoft/vcpkg/issues/4267

How is this going?

Slowly but we'll be done before the end of the year.

/azp run

@illera88  Since openssl is dependent on many other ports, there may be more ports that need to be fixed, which requires the help of others.

/azp run

/azp run

@fcharlie do you know what is going on with uwp builds? If I do dumpbin libcrypto.lib /SYMBOLS i dont see any symbols
Also #8566 fixes most regression except for the UWP ones which might be false positives in the sense that those ports should never worked in UWP in the first place.

@Neumann-A try dumpbin libcrypto.lib /EXPORTS ?

/azp run

@ras0219-msft Maybe you should try to accept another PR https://github.com/microsoft/vcpkg/pull/8566

/azp run

/azp run

The purpose of this PR is to throw out a brick to attract a jade, and the purpose has been achieved, so it is closed. Thanks https://github.com/microsoft/vcpkg/pull/8566


Template 2.9

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/metatdenovo branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

I updated the template and tested the pipeline. I can be merged!

Many tests fail. Yesterday I think I saw that they plan a hotfix release (i.e. 2.9.1) to deal with urgent problems in the new release. Could it be this that cause the problems and you should wait until 2.9.1 is out?

It seems the module fastq_cat failed and I forgot to run prettier. the first one is odd as I didn't touch that module while updating the template.

I fixed the issue. we should merge it @erikrikarddaniel


[Info] Error executing task on Server

https://pastebin.com/fEsKPZ04

Hmmm not much to go off of besides some network issues sending a packet. Will need to investigate.

Ok found the problem and will get such fixed.

Fix uploaded to Modrinth and Curseforge.


show a tooltips on closing braces

a tooltip on a closing brace would be helpful displaying the line of the opening brace so that you see what it belongs too
                      }
                 } // <-- tooltip: switch (state) {
            }
      }

This is a VS Code feature now


Error matching 250 and 254

Aug 28 06:55:11 mehdie-gui gunicorn[2901438]: Internal Server Error: /datasets/254/recon/
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]: Traceback (most recent call last):
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/exception.py", line 34, in inner
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     response = get_response(request)
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/base.py", line 115, in _get_response
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     response = self.process_exception_by_middleware(e, request)
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/usr/local/lib/python3.9/dist-packages/django/core/handlers/base.py", line 113, in _get_response
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     response = wrapped_callback(request, *callback_args, **callback_kwargs)
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/usr/local/lib/python3.9/dist-packages/sentry_sdk/integrations/django/views.py", line 87, in sentry_wrapped_callback
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     return callback(request, *args, **kwargs)
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/home/macbookpro/whgazetteer-mehdie/datasets/views.py", line 731, in ds_recon
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     raise e
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/home/macbookpro/whgazetteer-mehdie/datasets/views.py", line 727, in ds_recon
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     d2 = DatasetFile.objects.get(dataset_id=p_dataset)
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/usr/local/lib/python3.9/dist-packages/django/db/models/manager.py", line 82, in manager_method
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     return getattr(self.get_queryset(), name)(*args, **kwargs)
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:   File "/usr/local/lib/python3.9/dist-packages/django/db/models/query.py", line 406, in get
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]:     raise self.model.DoesNotExist(
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]: datasets.models.DatasetFile.DoesNotExist: DatasetFile matching query does not exist.
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]: [DEBUG] task_id is set to d40958b6-eb02-48f6-b145-7462ed2d275f
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]: [DEBUG] task is ready
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]: [DEBUG] task has succeeded with result [{'detail': {'dataset1': ['id', 'title'], 'dataset2': ['id', 'title']}}, 400]
Aug 28 06:55:11 mehdie-gui gunicorn[2901438]: Exception in ds_recon when trying to fetch dataset files for 250 and 0

Problem seems to be related to p_dataset being set to 0. p_dataset is the selected dataset if it is from the public list but the user selected from their own list.

A problem was isolated in the error reporting mechanism of the ds_recon routine in the views.py file. Now fixed so that error reporting is more meaningful.

Error seems to be emanating from mehdie-er-service. Issue continued there.


Selecting Seekbar to move video time freezes controls

Seeking on content by selecting bar before would allow you to move throughout video.
Now since this change, it is broken and doing so freezes controls and any action until controls become not visible.
Looks like after this PR was merged: https://github.com/android/tv-samples/pull/168
At commit fc5dcc0ec50da71e188b72fc4ff6ddca39b57402
Seekbar works as expected
https://github.com/android/tv-samples/assets/13984190/99ce79f2-eaa2-4428-8230-8198816f48c2
Post those changes:
https://github.com/android/tv-samples/assets/13984190/4481a986-d54c-4ff2-8796-20d239e9680e

@chikoski I believe this to be related to the most recent pr change: https://github.com/android/tv-samples/pull/168

@dgocoder Thanks for reporting this issue. This issue could be related to #159.

At first I thought so but confirmed that did not cause the issue.


make links more visibles

Gitea version (or commit ref): 1.9.0+dev-191-g2933ae4e8
Git version: not relevant
Operating system: linux
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite
[x] Not relevant

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
Actually all different link in a commit have no differences
maybe it could be changed to underline the current link like what github does
Screenshots

This behavior will change after #6842 is merged where the text will only link to the commit in the list view

oh ok so links will only go to the commit after taht ?

Yes, in the list view it only goes to the commit now. See:
https://try.gitea.io/mrsdizzie/linktesting
When you click the commit you still get a link to the issue/PR in the summary on the commit view

OK thanks !


fix: Support time zones in agenda.txt; restore agenda-utc.txt

Fixes #5207

Note: after merging this, the agenda note for 116 should be updated to remove the notice "Please note that times on the text agenda are in UTC."


Active labels do not render properly for form elements.

.active labels do not render properly with form elements that are empty and not focused (see image below).
It's also quite noticeable that there are two lines overlapping each other. It's a little bit, but it's quite noticeable.
<EMAIL_ADDRESS>

Hi @ciukstar ,
When you use the active helper on label, you need to add the active helper on input too.
You don't need to add active helper when you are loading the JS file.
If you not use the JS file you can add a placeholder=" " on input to do the job (a pure CSS solution).
More about trigger helpers here:
https://github.com/beercss/beercss/blob/main/docs/INPUT.md#triggers

Are you loading another css that could be affected the borders of fields?
Could you provide a codepen with this issue?

I noticed that in your example your label is positioned a bit upper.

Hi @ciukstar ,
When you use the active helper on label, you need to add the active helper on input too. You don't need to add active helper when you are loading the JS file. If you not use the JS file you can add a placeholder=" " on input to do the job (a pure CSS solution).
More about trigger helpers here: https://github.com/beercss/beercss/blob/main/docs/INPUT.md#triggers

Thanks. Everything works fine if I add active to the class list of the input.

Are you loading another css that could be affected the borders of fields? Could you provide an codepen with this issue?

No longer an issue.
This issue only seems to occur in Chrome Developer when the device toolbar is enabled, at 75% zoom or less (on Ubuntu).
...at least now I realize that I work in this Chrome Developer mode most of the time.
Thank you for considering this "issue".

Issue resolved


Utility class for nudging

Positioning needs a nudge class for gap spaces. Suggesting gt-1 & using margins going from 0-12px.

:) https://github.com/atav1k/fortune/pull/32


Adding Opera Crypto Wallet connector

Description
Hi we would like to Opera Crypto Wallet connection to your library according to the official integration guide: https://help.opera.com/en/crypto/opera-wallet-integration-guide/
The code updates are based on wagmi's MetaMask/Injected wallet connectors and are officially supported by the Opera Crypto Browser team.
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Thanks for doing this work! We can discuss adding this to the core in the future, but I'm going to close this for the moment. Adding new built-in connectors right now adds more surface area for the core team (me and @jxom) to manage. If anything changes in the future, we can re-open this PR.

Feel free to share this code in the GitHub Discussion area or package it up as a standalone package. More info here.
(Also, I added the isOpera flag as part of https://github.com/tmm/wagmi/pull/435 so there's coverage in InjectedConnector at least.)


Multiple playlist example

I am developing an electron based app, that delegates all audio control to node-groove.
I have multiple tabs, each holding a different GroovePlaylist:

My control flow is:

create a GroovePlayer;
create a GroovePlaylist;
load some file into playlist;
when I double click on some entry of such playlist, or on the play button -> attach playlist to the player;
when I double click on another playlist entry -> detach player -> attach the new playlist.

I can see correct playback information on top, but I get no audio output, nor playback progress information.
Relevant parts of the code:
Player.js:
attach(){
  return new Promise((resolve, reject)=>{
    if(this.attached){
      resolve()
    }else if(!this.playlist){
      reject(new Error('No playlist set!'))
    }else{
      this.player.attach(this.playlist, (err)=>{
        if(err){
          reject(err)
        }else{
          this.attached = true
          resolve()
        }
      })
    }
  })
}
detach(){
  return new Promise((resolve, reject)=>{
    if(!this.attached){
      resolve()
    }else if(!this.playlist){
      reject(new Error('No playlist to detach!'))
    }else{
      this.player.detach((err)=>{
        if(err){
          reject(err)
        }else{
          this.attached = false
          resolve()
        }
      })
    }
  })
}
play() {
  this.attach().then(()=>{
    this.playlist.play()
  })
}
goto(id) {
  var item = _.findWhere(this.playlist.items(), { id: id })
  if(item){
    this.playlist.seek(item, -1)
    !this.playlist.playing() && this.play()
  }
}

PlaylistStore.js:
// this is the PLAY_FILE action - I detach player, then I seek to the desired item
if(action.playlist.groovePlaylist !== _player.playlist){
  _player.detach().then(()=>{
    _player.playlist = action.playlist.groovePlaylist
    _player.goto(action.id)
  }).catch((error)=>{

  })
}else{
  _player.goto(action.id)
}

Did I get anything wrong, with how do playlists work? Should I instead have just a single playlist, from whom constantly inserting and removing?

Yes you should have a single playlist and do inserting and removing. Does the playlist example js file work in node-groove?

Yes it does ^^
At the moment, I changed it to work with a single groovePlaylist, that I clear and refill every time I switch context - works like a charm so far.
Perhaps it wouldn't harm to add a comment in the README about the management of multiple playlists.
Btw I really appreciate your work, I can finally work on a reliable player that suits my needs, after many years!

Here is how Groove Basin manages the groove playlist: https://github.com/andrewrk/groovebasin/blob/84d77ce10ea9e7a50b304bfb6cabd23acde7e493/lib/player.js#L2439
It's rather complicated, but I think it's as simple as it can be while still being correct and avoiding gaps/glitches in playback at edge cases.
That said, I think I encourage you to implement your own code and see where it goes.
Fair point about the README, I'll do that.


Server received himself message

when the server publish the message, it received his(this) message? why ?

Hi this is correct because the event is fired for all received messages. Thus also the ones from the server itself.
Best regards
Christian


Text on the choice line is not counted

In this example:
test
+ hello
    -> END

"test" is counted but "hello" is not but it's content since it's printed.

Thanks again @floriancargoet, that one should have been obvious! This just goes to show how the (unpublished) material I'm working with is very specific to a particular use-pattern. :-)


restore panics

Output of restic version
restic 0.7.1
compiled with go1.8.3 on darwin/amd64
How did you start restic exactly? (Include the complete command line)
restic restore 11c28025 -r /Volumes/Backup --target /Users/user/Downloads/
What backend/server/service did you use?
local storage
Expected behavior
fulfill restore without panic
Actual behavior
restoring <Snapshot 11c28025 of [/Users/user/Documents] at 2017-08-06 08:42:24.989499082 +0200 CEST by user@Users MacBook> to /Users/user/Downloads/
panic: runtime error: index out of range

goroutine 1 [running]:
github.com/pkg/xattr.Set(0xc4202632c0, 0x57, 0xc420bbcea0, 0x19, 0x195dd58, 0x0, 0x0, 0x0, 0x0)
	src/github.com/pkg/xattr/xattr_darwin.go:47 +0x20a
restic.Setxattr(0xc4202632c0, 0x57, 0xc420bbcea0, 0x19, 0x195dd58, 0x0, 0x0, 0x0, 0x0)
	src/restic/node_xattr.go:34 +0x71
restic.Node.restoreExtendedAttributes(0xc420bc6031, 0xb, 0xc420bb7fc8, 0x4, 0x1a4, 0xecdf0a6a0, 0x0, 0x1941220, 0xed117b3e9, 0x0, ...)
	src/restic/node.go:198 +0x103
restic.Node.restoreMetadata(0xc420bc6031, 0xb, 0xc420bb7fc8, 0x4, 0x1a4, 0xecdf0a6a0, 0x0, 0x1941220, 0xed117b3e9, 0x0, ...)
	src/restic/node.go:186 +0x31d
restic.(*Node).CreateAt(0xc42040d2c0, 0x19098c0, 0xc420117700, 0xc4202632c0, 0x57, 0x190dee0, 0xc4201115c0, 0xc420013700, 0x1c, 0xc420266bc0)
	src/restic/node.go:154 +0x344
restic.(*Restorer).restoreNodeTo(0xc4204eadb0, 0x19098c0, 0xc420117700, 0xc42040d2c0, 0xc420bba090, 0x2a, 0x7fff5fbffc2a, 0x22, 0xc420013700, 0x0, ...)
	src/restic/restorer.go:91 +0x286
restic.(*Restorer).restoreTo(0xc4204eadb0, 0x19098c0, 0xc420117700, 0x7fff5fbffc2a, 0x22, 0xc420bba090, 0x2a, 0x2b8ad8f5b9673bbc, 0xb133a20dd0c60470, 0xf474f3ef3da129d6, ...)
	src/restic/restorer.go:54 +0x83d
restic.(*Restorer).restoreTo(0xc4204eadb0, 0x19098c0, 0xc420117700, 0x7fff5fbffc2a, 0x22, 0xc420233240, 0x1d, 0x45251327b69e5d4c, 0xe2c4ae637f30874e, 0x788f2bfa74733458, ...)
	src/restic/restorer.go:66 +0x4f1
restic.(*Restorer).restoreTo(0xc4204eadb0, 0x19098c0, 0xc420117700, 0x7fff5fbffc2a, 0x22, 0xc4200e27c0, 0xa, 0x39cf294968fda4a9, 0x33888d0532d33257, 0x28124d3ec00e9ba6, ...)
	src/restic/restorer.go:66 +0x4f1
restic.(*Restorer).restoreTo(0xc4204eadb0, 0x19098c0, 0xc420117700, 0x7fff5fbffc2a, 0x22, 0x165ff45, 0x1, 0xcefdf2c34a47223b, 0x6c81432b1e406974, 0xbd7e91089b6dc35c, ...)
	src/restic/restorer.go:66 +0x4f1
restic.(*Restorer).RestoreTo(0xc4204eadb0, 0x19098c0, 0xc420117700, 0x7fff5fbffc2a, 0x22, 0x2178edcfb3c147dc, 0xc4204eadb0)
	src/restic/restorer.go:124 +0x12b
main.runRestore(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x7fff5fbffc2a, 0x22, 0x0, 0x0, ...)
	src/cmds/restic/cmd_restore.go:141 +0x7a6
main.glob..func17(0x193a180, 0xc42011cf00, 0x1, 0x5, 0x0, 0x0)
	src/cmds/restic/cmd_restore.go:23 +0xb5
github.com/spf13/cobra.(*Command).execute(0x193a180, 0xc42011ceb0, 0x5, 0x5, 0x193a180, 0xc42011ceb0)
	src/github.com/spf13/cobra/command.go:647 +0x3f8
github.com/spf13/cobra.(*Command).ExecuteC(0x1937d60, 0xc4201e6818, 0x1585960, 0xc4201e6840)
	src/github.com/spf13/cobra/command.go:726 +0x339
github.com/spf13/cobra.(*Command).Execute(0x1937d60, 0x25, 0xc42017feb8)
	src/github.com/spf13/cobra/command.go:685 +0x2b
main.main()
	src/cmds/restic/main.go:63 +0x268

Steps to reproduce the behavior
Do you have any idea what may have caused this?

Thanks for the report! Hm, this is interesting, the panic occurs in the package we use for extended attributes. I think it's a bug.

I was able to replicate this issue years ago, but it looks to be fixed now 🙌 . Not only does a restore of my Downloads directory work, but xattrs look to be preserved (just by running xattr -l * in the restored directory). I'm using restic from homebrew, which currently is restic 0.9.6 compiled with go1.13.4 on darwin/amd64.

Well, closing this then, feel free to reopen it if the problem happens again. Thanks for reporting back!


Update transformers for pip audit

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


feat: Add lhapdf6, gzip, and mg5mes support to PYTHIA8 build

Resolves #37
Requires PR #38 to go in first and then should be rebased.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge/pythia8 This is ready for review.

@henryiii after merge the linux linux_64_python3.12.____cpython job failed 4 seconds into the build for some reason unrelated to the code (https://github.com/conda-forge/pythia8-feedstock/runs/28780312155). Is it possible to restart individual jobs on the conda-forge CI?

Sure. Would you like me to add you as a maintainer, BTW?

Sure.

Thanks!

Would you like me to add you as a maintainer, BTW?

Sure. I'll add myself in PR #41 that I'm about to rebase.

Okay, sounds good.

Ah whoops, seems that this didn't properly fix --with-gzip:
$ micromamba list | head -n 4 && micromamba list | grep pythia8
List of packages in environment: "/root/micromamba/envs/local-build-pythia-debug"

  Name                                  Version   Build               Channel
───────────────────────────────────────────────────────────────────────────────────
  pythia8                               8.310     py312hca68cad_2     conda-forge
$ pythia8-config --with-lhapdf6 --with-gzip --with-python --with-mg5mes
true false true true

PR #41 is already in so I won't fix this for PYTHIA 8.310 but I'll make sure to fix this for PYTHIA 8.311 and add some tests to catch this. I might do this in a separate PR following the one to remove the zlib lower bound that @chrisburr caught in https://github.com/conda-forge/pythia8-feedstock/pull/39#discussion_r1717462110.


feat(ops): namespacing support for custom node type registry

Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Add namespace isolation for custom node type registry.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[X] I have read the CONTRIBUTION guide. (required)
[X] My change requires a change to the documentation.
[X] I have updated the tests accordingly. (required for a bug fix or a new feature)
[X] I have updated the documentation accordingly.
[X] I have reformatted the code using make format. (required)
[X] I have checked the code using make lint. (required)
[X] I have ensured make test pass. (required)

Codecov Report
Base: 92.93% // Head: 93.85% // Increases project coverage by +0.91% :tada:

Coverage data is based on head (a0ad40b) compared to base (f2b31a4).
Patch coverage: 96.05% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   92.93%   93.85%   +0.91%
==========================================
  Files           4        4
  Lines         269      309      +40
==========================================
+ Hits          250      290      +40
  Misses         19       19

Flag
Coverage Δ

unittests
93.85% <96.05%> (+0.91%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

optree/__init__.py
100.00% <ø> (ø)

optree/ops.py
90.85% <90.32%> (+0.22%)
:arrow_up:

optree/registry.py
96.80% <100.00%> (+1.29%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Added Invoiced to list of examples on README

We love using Slate. Thanks for the kick-ass tool!

Glad you like it! And thanks for submitting to dev. :smile:


Provided own keys results to AssertionError

When trying to use key with 33B length derived from HDKey I have stumbled on
if (!t) throw new Error(m || 'AssertionError') on nanoassert/index.js:21:17) ... is it due to different key length or I have to use always noise.keygen for key generation? Are there any supported curves that may work? Is length to only limitation?
it crashes on the client connection - server seems to be listening ...
anyway - Thank you for the great work!

Ok, I was struggling a lot to write generateKeypair with the same length size ... but all I need was noise.seedKeygen(mySeed) ... which turns out provide the exact feature i was looking for!
Closing ...

Ok, I was struggling a lot to write generateKeypair with the same length size ... but all I need was noise.seedKeygen(mySeed) ... which turns out provide the exact feature i was looking for!
Closing ...


Different positioning for identical images?

I have 2 SVGs which are identical apart from the fill being a different colour. Im using one as the default style for a link and the other as a hover style. I noticed that one of the icons is about 1px off, creating a jarring affect when you hover over it.
As part of my debugging I tried duplicating the image and changing nothing about it apart from the file name. Ive used a diff program to confirm they are identical. However they are still not positioned in the same place, creating the jarring affect again.
Is this a known bug? Ive updated from 1.2.19 to 1.3.1 but its still occurring.

Setting the padding to 1px fixes this as a workaround.

@jameschetwood To me this very much sounds like https://github.com/jkphl/svg-sprite/issues/147 and / or https://github.com/jkphl/svg-sprite/issues/142. What do you think?

In case this is still an issue for you: I will address this in the upcoming generation of svg-sprite.


completedVaccinationNumber isn't defined in i18n for vaccination graph

In English, Estonian and Russian translation.

Thanks for reporting this. This has now been fixed.


installation failed

i run this code: npm install --save react-native-snap-carousel
and get this error:
code ERR_TLS_CERT_ALTNAME_INVALID
npm ERR! errno ERR_TLS_CERT_ALTNAME_INVALID
npm ERR! request to https://registry.npmjs.org/react-native-snap-carousel failed, reason: Hostname/IP does not match certificate's altnames: Host: registry.npmjs.org. is not in the cert's altnames: DNS:a.sni.fastly.net, DNS:a.sni.global-ssl.fastly.net

npm: 6.2.0
react-native: 0.56
os: macOs high sierra

Useful link: http://lmgtfy.com/?q=npm+"ERR_TLS_CERT_ALTNAME_INVALID"

⚠ You did not follow the contributing guidelines!
As stated in these:

You need to fill out the issue template completely. This step is mandatory! Not doing so will result in your issue getting closed. Don't take this personally if this happens, and feel free to open a new issue once you've gathered all the information required by the template.

Thank you so much for solution.. i didnt realize its that simple.. i thought its library problem..
i solved by using yarn add react-native-snap-carousel, you should add this line in documentation.


Url.PluploadHandler throws NullReferenceException when PluploadFileCollection is null

This happens when you don't initialize a PluploadFileCollection in a viewmodel with a new PluploadFileCollection.

thanks!
----- Original Message -----
From: "Marcel Wijnands"<EMAIL_ADDRESS>To: "mwijnands/PluploadMvc"<EMAIL_ADDRESS>Sent: Friday, January 2, 2015 10:50:38 AM
Subject: [PluploadMvc] Url.PluploadHandler throws NullReferenceException when PluploadFileCollection is null (#13)
This happens when you don't initialize a PluploadFileCollection in a viewmodel with a new PluploadFileCollection.
—
Reply to this email directly or view it on GitHub .

Will throw an ArgumentNullException now with a descriptive message.


optimize Filterable instances (Array, StrMap)

@raveclassic working on a PR for Either

@gcanti Oups I've just pushed all updated ADTs

@raveclassic no problem, I just wanted to help you out ;)

@gcanti Thanks a lot anyway :)


Various fixes for kanji workbook review exercises

This pull requests fixes some minor typos. For example, in a few cases a kanji is used before it has been introduced in Tobira. There was also one case of an underlined line being too short. Lastly, one sentence in lesson 1, kanji workbook review exercise 11 differs from my book. I'm not sure if it's a typo or if the sentence has been changed in a reprint.

Fixed a typo in lesson 1, kanji workbook review exercise 2
Fixed a typo in lesson 1, kanji workbook review exercise 5
Fixed a typo in lesson 1, kanji workbook review exercise 10
Fixed a seemingly wrong sentence in lesson 1, kanji workbook review exercise 11
Adjusted wrong underlining in lesson 1, kanji workbook review exercise 13

No problem, I'm happy to hear it's been helping you!
Hopefully by next week I should have the final lesson's exercises finished, after which I'll do some touch ups and possibly add some additional contents. That aside, Tobira has been a big help in improving my Japanese, so I hope it'll have the same effect for you as well.
All the best on your studies! 頑張れ！


Enable multi file support option in the flash plugin

This is something I required - but also an outstanding issue on this repo.

Thanks!


Search - Start over button

In the case of unsuccessful search the startover button leads to full listing of records for MST I guess?
The button should be directing back to the front page I think.

This is a duplicate of #57 so I'm closing it


How to display the full referrer?

https://s.natalian.org/2017-01-17/1484619788_2558x1393.png
How can I see what pages were referred to? Isn't it better also to show the full URL of the referring page?
I'm using for i in logs/*.gz; do zcat < $i; done | goaccess --log-format=CLOUDFRONT -o report.html & GoAccess - 1.1.1

It seems like you need to enable the referrers panel. Commenting this line out in your config file should do it.

Thanks, I prefer not to mess around with external configs since I use the same script on multiple environments. Why isn't --enable-panel=REFERRERS say the default with CLOUDFRONT? Anything else that should be typically enabled to make best use of the CloudFront logs I have?
Furthermore I find it very confusing I see a "Geo location" panel when for example #enable-panel GEO_LOCATION is commented out in the system config.

There's no way right now to have a set of default options based on the select log-format. A simple solution  is to have a config file (e.g., /etc/goaccess.cloudfront) specific to your log format, e.g., CLOUDFRONT and just specify that config file from the command line, e.g.,
for i in logs/*.gz; do zcat < $i; done | goaccess --log-format=CLOUDFRONT -o report.html -p

/etc/goaccess.cloudfront
I agree. It's confusing having both, enable-panel  and ignore-panel . I think I'll make ignore-panel  an alias of enable-panel  just for backwards compatibility and use enable-panel  only to avoid confusion.

I am still trying to avoid external configuration files. I don't follow. ignore-panel === enable-panel?! What the?
My complaint is that I am seeing these panels in report.html despite them being commented out the config.

See #407 for details on why --enable-panel was added.
I'm not sure I follow, in the screenshot you posted, the REFERRERS panel is not shown, so I assumed you wanted to enable it and thus you need to make sure ignore-panel REFERRERS is commented out. If ignore-panel is commented out, the panel will be displayed regardless the status of enable-panel REFERRERS.

Let me summarise my state:
https://s.natalian.org/2017-01-17/1484619788_2558x1393.png has 'referring sites' showing.. misses details like who the referrers are. To fix IIUC I set ignore-panel REFERRERS, which confusingly shows a new panel with the referrers.
https://s.natalian.org/2017-01-17/1484624085_2558x1393.png shows "Geo location" despite #enable-panel GEO_LOCATION being set in my configuration.

By the default and regardless a config file exists, goaccess enables all panels. So in order to allow the user to ignore parsing and displaying some panels, the option --ignore-panel was added.
However, since the REFERRERS panel is disabled by default at the config file level, then you need to comment that line out so it can be shown.
For your second point, and as mentioned on the first line, goaccess enables all panels, so it doesn't matter if you uncomment --enable-panel since it's already enabled by default.
enable-panel becomes useful if you have panels ignored and you would like to enable them in the command line.

Ok so I'm set with for i in logs/*.gz; do zcat < $i; done | goaccess --enable-panel=REFERRERS --log-format=CLOUDFRONT -o report.html Ok!

Glad that did it. I should've mentioned that on my first comment :)


Wider use of Bootstrap

Maybe a good idea to buy a nice bootstrap template and start using it throughout the application in order to give it a more crisp and modern look
https://themes.getbootstrap.com/products/marketing
Also, probably good to start using version 4

For the most part, styling has been updated to use bootstrap 4.  If you see any specific areas that are not, please open a new ticket


[Fix #27] - Add Contents for "Vision" and "Next Plan" Buttons

Description
This pull request introduces the functionality for the "Vision" and "Next Plan" buttons under the "Why Choose Us" section on the website. The current implementation only supports the "Mission" section, and this update aims to enhance user engagement by providing additional context regarding our goals and future plans.
Fixes #27
Before:

After:
https://github.com/user-attachments/assets/73a6e318-ff8c-4b8d-ac5f-8c2717a59ccc
Code Changes
Created about.js to include functions for handling button clicks and displaying content.
Modified index.html to integrate new button functionalities.
@anuragverma108
Please Merge it and give a hacktoberfest accepted label
Thank You!

Conflicting files
index.html
Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Web site data not sending to the bot framework for conversational update

Hey I am building my chat bot using bot framework v4
I am passing user data from the website by passing variables like this from web chat
user: { id: model.id, name: model.userName, token:model.token,url:model.url, source: "SP"},
The issue is i am not able to get this data before user sending a message.
for example:
in bot framework for (message.type == conversational update) I am sending welcome message.There i am not able to welcome the user using his name.
But i can use this name after user sends some query like for hi! I am able to send hi username welcome to our site.

This is a known issue, thank you for sharing with us! A fix is already in the works. You can track that progress in #1286.


                      Support diskover on Patreon or PayPal :)

2018-03-07 20:55:57,885 [INFO][diskover] Connecting to Elasticsearch
2018-03-07 20:56:06,093 [WARNING][diskover] Not running as root, you may not be able to crawl all files
2018-03-07 20:56:06,093 [INFO][diskover] Checking ES index: diskover-index
2018-03-07 20:56:06,129 [INFO][diskover] Creating ES index
2018-03-07 20:56:06,177 [WARNING][elasticsearch] PUT https://url:443/diskover-index [status:400 request:0.047s]
Traceback (most recent call last):
  File "diskover.py", line 2860, in <module>
    index_create(CLIARGS['index'])
  File "diskover.py", line 1835, in index_create
    ES.indices.create(index=indexname, body=mappings)
  File "/mnt/biodesk/software/anaconda/lib/python3.5/site-packages/elasticsearch/client/utils.py", line 73, in _wrapped
    return func(*args, params=params, **kwargs)
  File "/mnt/biodesk/software/anaconda/lib/python3.5/site-packages/elasticsearch/client/indices.py", line 107, in create
    params=params, body=body)
  File "/mnt/biodesk/software/anaconda/lib/python3.5/site-packages/elasticsearch/transport.py", line 312, in perform_request
    status, headers, data = connection.perform_request(method, url, params, body, ignore=ignore, timeout=timeout)
  File "/mnt/biodesk/software/anaconda/lib/python3.5/site-packages/elasticsearch/connection/http_requests.py", line 90, in perform_request
    self._raise_error(response.status_code, raw_data)
  File "/mnt/biodesk/software/anaconda/lib/python3.5/site-packages/elasticsearch/connection/base.py", line 125, in _raise_error
    raise HTTP_EXCEPTIONS.get(status_code, TransportError)(status_code, error_message, additional_info)
elasticsearch.exceptions.RequestError: TransportError(400, 'illegal_argument_exception', 'Rejecting mapping update to [diskover-index] as the final mapping would have more than 1 type: [file, crawlstat, diskspace, directory]')

The same command and config upload to a ES 5.5 cluster with no issues.

Notes at the single mapping types https://www.elastic.co/guide/en/elasticsearch/reference/6.0/removal-of-types.html

diskover does not currently support ES 6.

@shirosaidev Is there a tracking ticket for ES 6 support in Diskover?

@victorhooi no plans currently to get diskover working with ES 6 until maybe after final release of 1.5.0.

Hello! :)  cool project...... Any news on version 6  support?

@LordBonkerz ...or ES7 for that matter? There were some hiccups in early releases, but v7.3.0 was recently released (~1wk ago), and so far I've had it running without issue in production.
Just wondering if it makes sense to update to an already-outdated version — v5.x was already EOL'd in 2019 March, while the latest 7.3.0 will be supported until 2021.
@shirosaidev, you proposed holding off until the 1.5 release of diskover, which I see went GA a little over a month ago. Would this be a good time to revisit this question? If you're open to it, I think creating a new umbrella issue with low-hanging-fruit / action-items would allow contributors to assess what needs to be done and get the ball rolling on this. 🚀
Thoughts?

fyi, to update everyone about this, es 7.x support is being worked on by me... hopefully released in September sometime...

@shirosaidev how's it going? Anything that other developers can help with? Is there a dev branch somewhere?

AFAIK, elasticsearch 7 is available but in the enterprise version: https://diskoverspace.com/#compare

Which september :-)  ??

AFAIK, elasticsearch 7 is available but in the enterprise version: https://diskoverspace.com/#compare

Good bye, then, to this trap

@shirosaidev Just checking - is the ElasticSearch 5.x limitation for the community thing just a temporary thing, or is that a permanent thing?
As in, will the community DiskOver be updated to support the current ElasticSearch version at some point?

Eventually I'm hoping to put these updates for es7 into the community edition, this is not to force people to buy diskover enterprise (@q2dg comment above), just it comes down to my available time and motivation and hopefully some additional sponsors of the community project to update the code

shame its not CE from the beginning! with ES7 support :(

Eventually I'm hoping to put these updates for es7 into the community edition, this is not to force people to buy diskover enterprise (@q2dg comment above), just it comes down to my available time and motivation and hopefully some additional sponsors of the community project to update the code

Hey @shirosaidev,
thanks for providing this great tool! :D
Could you possibly outline what work would be needed for the migration to ES7? Maybe that will make it easier for possible sponsors of work / contributors to judge whether they want to try to tackle that work?

We did a quick patch to get it to work with es7, been running it for a few months and works for our current purposes.
https://github.com/ilpvfx/diskover/tree/ilp
https://github.com/ilpvfx/diskover-web/tree/ilp
cheers


createCassandraTable with Counter columns

Currently, creating tables using the createCassandraTable API on a dataframe maps long columns to bigint by default. Is it possible to create a table with "counter" type columns instead for some fields? I don't see an example for this in the documentation or tests.

#546


Add issue to organization project board

v3.0.0 added the ability to add issues to repository project boards. It'd be nice to also be able to add issues to organization project boards.

Thanks @colebemis, I'll take a look!
Via the docs:


create lean builds that only support artoolkit tracking

What kind of change does this PR introduce?
Most usages of AR.js uses artoolkit as backend. It seems better-supported overall as well.
Dropping the scripts necessary to support aruco as backend would reduce build size, allowing users to access the AR contents faster.
There are some examples that utilizes aruco still (multi-tracker), so we don't want to completely cleanse the project of aruco. Therefore we offer ar.lean.js as additional build choice.
Can it be referenced to an Issue? If so what is the issue # ?
N/A
How can we test it?
Run a working artoolkit example with the lean build.
Does this PR introduce a breaking change?
No.

I modified the makefile, I tried to rebuild it. When I was ready to keep your changes, I found that the code was not new. Do you need to check it?

And such modifications are not convenient to rebuild.

Hey @Ouyang-Zhaoxing ! Not sure if I understand you. Are you wondering if this change breaks things since it's old? I recall having used this lean build before when the pull request is created, but have not tested it recently. Either way, the "main build" produced here should be the same as the build produced without this PR.
可以中文交流，有什么问题么？

@lcb931023 我喜欢精简的东西。因为我的一个PR修改了jsartoolkit5，我重新构建代码的时候才发现你是对输出文件进行了单独的更改，而不是简单的构建而已，这不利于在以后在代码改动后对lean部分的重新构建。并且你提交的代码可能不是最新的，其中有一行更改带有版本号，而这个版本号有1.6.2变成了1.5.1。


Can you do the same for xbox games / xbox gamepass pc ?

Can you do a project to prefill  xbox games / xbox gamepass pc ?

There certainly is some demand for one!  I've heard from others that they would be interested in it.
Unfortunately I don't have the time to take on another one of these, I have my hands full supporting the 3 that already exist.  Perhaps sometime in the future 😄