[Enhancement] reduce meaningless join transformation

Fixes #issue
Problem:

Version 2.5, without outer join reorder, 3 inner joins, 4 left outer joins and join transformation takes about 1.5s
Version 3.1, with outer join reorder enabled, 1 inner join, 4 left outer joins and join transformation takes about 114s

root cause:
join transformation generated a large number of new groups due to split projection, but did not generate more valuable join orders.
how to fix:

reduce meaningless join transformation by checking transformation mask
only rewriting the new on predicate like A.col = B.col + C.col to A.col = add when (B, C) is the bot join.
when computesize is smaller update group statistics
combine the SemiReorderRule with JoinLeftAsscomRule

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 40 / 42 (95.24%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinAssociativityRule.java
5
7
71.43%
[169, 175]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/task/DeriveStatsTask.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinLeftAsscomRule.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleSet.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/join/JoinReorderProperty.java
10
10
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinAssociateBaseRule.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 51 / 62 (82.26%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/Memo.java
0
7
00.00%
[357, 358, 359, 360, 361, 363, 364]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinAssociativityRule.java
5
9
55.56%
[172, 177, 182, 227]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/task/DeriveStatsTask.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinLeftAsscomRule.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleSet.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/join/JoinReorderProperty.java
11
11
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinAssociateBaseRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinCommutativityRule.java
6
6
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 53 / 64 (82.81%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/Memo.java
0
7
00.00%
[358, 359, 360, 361, 362, 364, 365]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinAssociativityRule.java
6
10
60.00%
[170, 175, 180, 225]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/task/DeriveStatsTask.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalJoinOperator.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinLeftAsscomRule.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleSet.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/join/JoinReorderProperty.java
11
11
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleType.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinAssociateBaseRule.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/JoinCommutativityRule.java
6
6
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


QR not returned as expected

I am trying to run your sample in ubuntu 18 with docker, i follow all the steps.
I get the message "Waiting for qr" but i do not get any qr, i also tried to wait more than 1 minute.
I also connected to remote server with vnc and saw that the browser is loaded and see the qr, but none qr is returned.
Code:
root@docker-s-2vcpu-4gb-ams3-01:~/WebWhatsapp-Wrapper# docker run --network selenium
-it -e SELENIUM='http://firefox:4444/wd/hub' -v $(pwd):/app  webwhatsapi /bin/bash -c "pip install ./;pip list;python sample/remote.py"
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Processing /app
Requirement already satisfied: python-dateutil>=2.6.0 in /usr/local/lib/python2.7/site-packages (from webwhatsapi==2.0.3) (2.8.1)
Requirement already satisfied: selenium>=3.4.3 in /usr/local/lib/python2.7/site-packages (from webwhatsapi==2.0.3) (3.141.0)
Requirement already satisfied: six>=1.10.0 in /usr/local/lib/python2.7/site-packages (from webwhatsapi==2.0.3) (1.13.0)
Requirement already satisfied: python-axolotl in /usr/local/lib/python2.7/site-packages (from webwhatsapi==2.0.3) (0.2.3)
Requirement already satisfied: cryptography in /usr/local/lib/python2.7/site-packages (from webwhatsapi==2.0.3) (2.8)
Requirement already satisfied: python-magic in /usr/local/lib/python2.7/site-packages (from webwhatsapi==2.0.3) (0.4.15)
Requirement already satisfied: urllib3 in /usr/local/lib/python2.7/site-packages (from selenium>=3.4.3->webwhatsapi==2.0.3) (1.25.7)
Requirement already satisfied: protobuf>=3.0.0.b2 in /usr/local/lib/python2.7/site-packages (from python-axolotl->webwhatsapi==2.0.3) (3.11.0rc2)
Requirement already satisfied: python-axolotl-curve25519>=0.4.1 in /usr/local/lib/python2.7/site-packages (from python-axolotl->webwhatsapi==2.0.3) (0.4.1.post2)
Requirement already satisfied: enum34; python_version < "3" in /usr/local/lib/python2.7/site-packages (from cryptography->webwhatsapi==2.0.3) (1.1.6)
Requirement already satisfied: ipaddress; python_version < "3" in /usr/local/lib/python2.7/site-packages (from cryptography->webwhatsapi==2.0.3) (1.0.23)
Requirement already satisfied: cffi!=1.11.3,>=1.8 in /usr/local/lib/python2.7/site-packages (from cryptography->webwhatsapi==2.0.3) (1.13.2)
Requirement already satisfied: setuptools in /usr/local/lib/python2.7/site-packages (from protobuf>=3.0.0.b2->python-axolotl->webwhatsapi==2.0.3) (41.6.0)
Requirement already satisfied: pycparser in /usr/local/lib/python2.7/site-packages (from cffi!=1.11.3,>=1.8->cryptography->webwhatsapi==2.0.3) (2.19)
Building wheels for collected packages: webwhatsapi
Building wheel for webwhatsapi (setup.py) ... done
Created wheel for webwhatsapi: filename=webwhatsapi-2.0.3-cp27-none-any.whl size=29677 sha256=d17729f96e11b6bace6ec4ca27c1c90be70db2e00e66c6d424e31ca2e34f1305
Stored in directory: /tmp/pip-ephem-wheel-cache-kENNNZ/wheels/4b/1c/59/a69d3cb46a693578104e640ef6e42bbb128292df4586f1cb10
Successfully built webwhatsapi
Installing collected packages: webwhatsapi
Successfully installed webwhatsapi-2.0.3
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Package                   Version

cffi                      1.13.2
cryptography              2.8
enum34                    1.1.6
ipaddress                 1.0.23
numpy                     1.16.5
pip                       19.3.1
protobuf                  3.11.0rc2
pycparser                 2.19
python-axolotl            0.2.3
python-axolotl-curve25519 0.4.1.post2
python-dateutil           2.8.1
python-magic              0.4.15
selenium                  3.141.0
setuptools                41.6.0
six                       1.13.0
typing                    <IP_ADDRESS>
urllib3                   1.25.7
virtualenv                16.7.8
webwhatsapi               2.0.3
wheel                     0.33.6
Environment {'LANG': 'C.UTF-8', 'PYTHONIOENCODING': 'UTF-8', 'TERM': 'xterm', 'GPG_KEY': 'C01E1CAD5EA2C4F0B8E3571504C367C218ADD4FF', 'PYTHON_VERSION': '2.7.17', 'PYTHON_GET_PIP_URL': 'https://github.com/pypa/get-pip/raw/ffe826207a010164265d9cc807978e3604d18ca0/get-pip.py', 'SHLVL': '1', 'PYTHON_PIP_VERSION': '19.3.1', 'HOSTNAME': '6974cb4a854a', 'SELENIUM': 'http://firefox:4444/wd/hub', 'PYTHON_GET_PIP_SHA256': 'b86f36cc4345ae87bfd4f10ef6b2dbfa7a872fbff70608a1e43944d283fd0eee', 'PWD': '/app', 'PATH': '/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin', 'HOME': '/root', '_': '/usr/local/bin/python'}
Waiting for QR
And this is the message i get after long waiting,
Traceback (most recent call last):
File "sample/remote.py", line 20, in
driver.wait_for_login()
File "/usr/local/lib/python2.7/site-packages/webwhatsapi/init.py", line 276, in wait_for_login
EC.visibility_of_element_located((By.CSS_SELECTOR, self._SELECTORS['mainPage']))
File "/usr/local/lib/python2.7/site-packages/selenium/webdriver/support/wait.py", line 80, in until
raise TimeoutException(message, screen, stacktrace)
selenium.common.exceptions.TimeoutException: Message:
Do i miss something?

You need to scan that QR with your phone by using the Whatsapp WEB option

But I do not get any qr
On Tue, Nov 26, 2019, 16:30 Frangel Hernandez<EMAIL_ADDRESS>wrote:

You need to scan that QR with your phone by using the Whatsapp WEB option
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mukulhase/WebWhatsapp-Wrapper/issues/757?email_source=notifications&email_token=ABXZDOV3H7GDDYBXENAMQBTQVUXIXA5CNFSM4JRDSSJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFGGMDA#issuecomment-558654988,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXZDOXQT6XX2OENAZ3OTTDQVUXIXANCNFSM4JRDSSJA
.

same problem here

"I also connected to remote server with vnc and saw that the browser is loaded and see the qr, but none qr is returned."
Two options: a) scan qr from whatsapp page (you can see with vnc as you say); b) use get_qr function to save qr code to file, need to pass file as parameter. Then you can scan png file but you need to open with background in white (could be a browser pointing to a local index.html with image inserted

can you give me the full example how to do it,
it will also help others,
thank you.

Also have to mention, i tried to scan the qr from the vnc window, but i it throw error and stopped


Configuration Management - User and central configuration

After the sample application from Watching POC we want to deduce some base CRs necessary for all Components and then decide wether we want additional Configuration Overrides. Right now, the overrides can be left out for simplicity, but it is still pending where we want to allow a configuration override from SKR
AC:

Conceptualise base CRs necessary for all Components
Assess additional Configuration Overrides

Done, let's close it. :)


proposal: Go 2: move math/rand to x/math/rand

math/rand has several known and documented problems (see https://github.com/golang/go/issues/21835) and it's easily mistaken for crypto/rand (see https://github.com/golang/go/issues/20661). This is a proposal to move it out of the standard library, which would give several advantages.

Easier ability to implement other sources and tweak it's performance or space usage
Removal accidental use (when developer should have used crypto/rand)

The go fix tool could rewrite imports to x/math/rand or default to crypto/rand. There are real use cases for a deterministic generator (jitter, tests, etc) so we shouldn't remove it entirely. We should gather uses of math/rand that crypto/rand doesn't satisfy.

Are you suggesting that for Go 2 we not implement #21835, and instead move math/rand out of the standard library?  Or do you think it would be OK to adopt #21835 for Go 2?

Easier ability to implement other sources and tweak it's performance or space usage

This same argument applies to literally every other package in the standard library; and yet you need to have something in it, right? : ) Unless go2 goes in the "move everything outside of the main repository" direction, I don't see how it could be reasonable to move a fundamental package like the one that generates random numbers out of stdlib, while still having a lot of other much less fundamental packages in it.
While it's true that we have been bitten in the past by the impossibility to fix fundamental deficiencies in the package's underling randomness source without breaking retro-compatibility, a new, clean implementation that fixes the most glaring issues with the package, like Rob proposed in #21835, could very well fit into the go2 standard library.

Removal accidental use (when developer should have used crypto/rand)

There's a (very prominent) warning at the top of the doc, in the package overview, about this:

For random numbers suitable for security-sensitive work, see the crypto/rand package.

And frankly, I doubt that a user that doesn't understand the difference between secure and non-secure random number generation will be able to write a cryptographically-secure application, even if we move math/rand outside the standard library.

@ianlancetaylor I have no problems with implementing https://github.com/golang/go/issues/21835 in Go 2.
@ALTree I agree with you, but why does the stdlib even need to offer two random number generators?
I (want to) assume anyone really needing math/rand over crypto/rand can find and use it from x/math/rand, but that the stdlib default is usable (and secure) for most uses.

Thanks.  I'm going to close this issue in favor of #21835.
Discussions of why we need both math/rand and crypto/rand are perhaps best held on golang-dev.


981 filter by location

dev
GitHub Project

Main GitHub Project ticket

Code reviewers

[ ] @iuriikhrystiuk
[ ] @sand0

Second Level Review

[ ] @idontwannawakeup

Summary of issue
Was the requirement to implement filtering by location.
Summary of change
Was implemented filtering by location.
Testing approach
ToDo
CHECK LIST

[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

/azurepipelines run ita-social-projects.EventsExpress

/azure-pipelines run ita-social-projects.EventsExpress

/AzurePipelines run ita-social-projects.EventsExpress

/AzurePipelines run

/AzurePipelines run ita-social-projects.EventsExpress


Deprecated code

This line
 bgModel = cv2.BackgroundSubtractorMOG2(0, bgSubThreshold)

should be
cv2.createBackgroundSubtractorMOG2(0, bgSubThreshold)

and
contours, hierarchy = cv2.findContours(thresh1, cv2.RETR_TREE, cv2.CHAIN_APPROX_SIMPLE)

should be
x, contours, y = cv2.findContours(thresh1, cv2.RETR_TREE, cv2.CHAIN_APPROX_SIMPLE)

Thank you for pointing this out. But I don't have time to make modify the code.
Could you please change the code and then create a pull request?
Thx~

Done,
uw

I suggest that you swap the python3 branch to be master. Thanks a lot :+1:

@shakram02 I agree with you, done.


Update connection status to work for local, CCloud and direct connections

Continuation of #96 and #122, and followup to #116 that added initial and limited direct connections (with GraphQL support) but did not support credentials nor unify the status to work for all kinds of connections. (The status is heavily oriented around CCloud connections.)
Note that direct connections do not yet support credentials, so direct connections will only work with Kafka clusters and SR that have no authentication. We'll track adding support for other credential types in subsequent issues:

basic authN (#124)
mTLS authN (#125)
OAuth authN (#126)
Kerberos authN, or SSL/GSSAPI (#127)

Every Connection resource includes a spec field and status field. The spec is the user-defined information about the connection, and the status is the system-generated information. The status field is defined in the OpenAPI spec as the ConnectionStatus schema:
    ConnectionStatus:
      required:
      - authentication
      type: object
      properties:
        authentication:
          $ref: "#/components/schemas/Authentication"

with the Authentication schema:
    Authentication:
      required:
      - status
      type: object
      properties:
        status:
          $ref: "#/components/schemas/Status"
        requires_authentication_at:
          $ref: "#/components/schemas/Instant"
        user:
          $ref: "#/components/schemas/UserInfo"
        errors:
          $ref: "#/components/schemas/AuthErrors"

and the Status schema:
    Status:
      enum:
      - NO_TOKEN
      - VALID_TOKEN
      - INVALID_TOKEN
      - FAILED
      type: string

New connection resources always have an "initial" status of (in a simplified not-quite-JSON representation):
status: {
  authentication: {
    status: NO_TOKEN
  }
}

and successfully-connected CCloud connections have this status:
status: {
  authentication: {
    status: SUCCESS,
    user_info: ...
    errors: ...
  }
}

The errors field is used only if the status is FAILED or INVALID_TOKEN.
This design was added for CCloud connections and the structure and terminology of the Status enum literals is very much oriented around CCloud and/or OAuth.
Meanwhile, the spec for connection resources is defined in the OpenAPI spec as:
    ConnectionSpec:
      description: The connection details that can be set or changed.
      type: object
      properties:
        id:
          description: The unique identifier of the connection resource.
          maxLength: 64
          minLength: 1
          type: string
        name:
          description: The user-supplied name of the connection resource.
          maxLength: 64
          type: string
        type:
          description: The type of connection resource.
          type: string
          allOf:
          - $ref: "#/components/schemas/ConnectionType"
        ccloud_config:
          description: The details for connecting to CCloud.
          type: object
          allOf:
          - $ref: "#/components/schemas/CCloudConfig"
        local_config:
          description: The details for connecting to Confluent Local.
          type: object
          allOf:
          - $ref: "#/components/schemas/LocalConfig"

Note the ccloud_config and local_config objects used for CCloud and local connections, respectively.
The ccloud object, with the CCloud organization is to be used. The CCloudConfig schema is defined as:
    CCloudConfig:
      description: Configuration for Confluent Cloud connections
      required:
      - organization_id
      type: object
      properties:
        organization_id:
          description: The identifier of the CCloud organization to use. The user's
            default organization is used when absent.
          maxLength: 36
          minLength: 36
          type: string

As part of adding support for direct connections, the Connection spec was expanded to include a spec.kafka_cluster and spec.schema_registry:
    ConnectionSpec:
      description: The connection details that can be set or changed.
      type: object
      properties:
        id:
          description: The unique identifier of the connection resource.
          maxLength: 64
          minLength: 1
          type: string
        name:
          description: The user-supplied name of the connection resource.
          maxLength: 64
          type: string
        type:
          description: The type of connection resource.
          type: string
          allOf:
          - $ref: "#/components/schemas/ConnectionType"
        ccloud_config:
          description: The details for connecting to CCloud.
          type: object
          allOf:
          - $ref: "#/components/schemas/CCloudConfig"
        local_config:
          description: The details for connecting to Confluent Local.
          type: object
          allOf:
          - $ref: "#/components/schemas/LocalConfig"
        kafka_cluster:
          description: "The details for connecting to a CCloud, Confluent Platform,\
            \ or Apache Kafka cluster."
          type: object
          allOf:
          - $ref: "#/components/schemas/KafkaClusterConfig"
        schema_registry:
          description: The details for connecting to a Schema Registry.
          type: object
          allOf:
          - $ref: "#/components/schemas/SchemaRegistryConfig"

Now, local connections include a local_config object, CCloud connections include a ccloud_config object, and direct connections include a kafka_cluster object (when directly connecting to a Kafka cluster) and/or a schema_registry object (when directly connecting to a Schema Registry).
The status needs to change so that we can adequately reflect the connected-ness (and other errors) for each of the one or more local_config, ccloud_config, kafka_cluster and/or schema_registry objects in the spec. To do this, we will slowly evolve away from the status.authentication object and instead introduce an object in status for each spec configuration object:
    ConnectionStatus:
      required:
      - authentication
      type: object
      properties:
        ccloud:
          $ref: "#/components/schemas/CCloudStatus"
        kafka_cluster:
          $ref: "#/components/schemas/KafkaClusterStatus"
        schema_registry:
          $ref: "#/components/schemas/SchemaRegistryStatus"
        authentication:
          $ref: "#/components/schemas/Authentication"

where CCloudStatus is essentially the same as Authentication:
    CCloudStatus:
      description: The status related to CCloud.
      required:
      - state
      type: object
      properties:
        state:
          description: The state of the connection to CCloud.
          type: string
          allOf:
          - $ref: "#/components/schemas/ConnectedState"
        requires_authentication_at:
          description: "If the connection's auth context holds a valid token, this\
            \ attribute holds the time at which the user must re-authenticate because,\
            \ for instance, the refresh token reached the end of its absolute lifetime."
          type: string
          allOf:
          - $ref: "#/components/schemas/Instant"
        user:
          description: "Information about the authenticated principal, if known."
          type: object
          allOf:
          - $ref: "#/components/schemas/UserInfo"
        errors:
          description: Errors related to the connection to the Kafka cluster.
          type: object
          allOf:
          - $ref: "#/components/schemas/AuthErrors"

and the KafkaClusterStatus and SchemaRegistry status are defined similarly:
    KafkaClusterStatus:
      description: The status related to the specified Kafka cluster.
      required:
      - state
      type: object
      properties:
        state:
          description: The state of the connection to the Kafka cluster.
          type: string
          allOf:
          - $ref: "#/components/schemas/ConnectedState"
        user:
          description: "Information about the authenticated principal, if known."
          type: object
          allOf:
          - $ref: "#/components/schemas/UserInfo"
        errors:
          description: Errors related to the connection to the Kafka cluster.
          type: object
          allOf:
          - $ref: "#/components/schemas/AuthErrors"
...
    SchemaRegistryStatus:
      description: The status related to the specified Schema Registry.
      required:
      - state
      type: object
      properties:
        state:
          description: The state of the connection to the Schema Registry.
          type: string
          allOf:
          - $ref: "#/components/schemas/ConnectedState"
        user:
          description: "Information about the authenticated principal, if known."
          type: object
          allOf:
          - $ref: "#/components/schemas/UserInfo"
        errors:
          description: Errors related to the connection to the Schema Registry.
          type: object
          allOf:
          - $ref: "#/components/schemas/AuthErrors"

The major difference in these schemas compared to Authentication is the new ones use state rather than status (to avoid having a status.authentication.status object) and to use more generic enum literals for ConnectedState:
    ConnectedState:
      enum:
      - NONE
      - ATTEMPTING
      - SUCCESS
      - EXPIRED
      - FAILED
      type: string

where:

NONE means no connection has been established yet.
ATTEMPTING is a transient state while the sidecar is trying to validate the corresponding configuration
SUCCESS means the connection to the corresponding system was successfully established
EXPIRED means the connection was previously successfully connected but any credentials have expired
FAILED means the connection to the corresponding system could not be established

The extension needs to transition from using status.authentication to status.ccloud. In the short term, both will be kept (the former will be generated from the latter) so the extension can migrate in the near future, as it adds support for status.kafka_cluster and status.schema_registry.
Once that migration has been completed and the extension is no longer using status.authentication, the status.authentication object will be removed.


Migrate DatePicker to CSS Modules.

Summary
Closes #551.
Note: I did not convert date-rage to css modules since the implementation is not currently in use and there is no css styling applied.
@cerner/terra

@emilyrohrbough could you resolve the conflicts on this branch?

Should the date format MM/DD/YYYY auto format dates entered manually to include the forward slashes ' / '?

@benbcai Do you have the answer to Paul's question?

@PaulSolDev The DatePicker currently does not support any text entry masking. It is just a free text input. The entry is accepted/validated only when entered correctly according to the format. the There is an enhancement (https://github.com/cerner/terra-core/issues/303) to enforce formatting during entry.

@benbcai Thank you for the clarification.  So long as there is something logged then we should be good.  I will comment back again when we have completed the remaining browser testing.

Functional review complete.  No issues identified outside of the need to include date formatting in the future.


UnicodeDecodeError

app.py", line 51, in
template = f.read()
UnicodeDecodeError: 'gbk' codec can't decode byte 0x99 in position 1814: illegal multibyte sequence

Whats the python version that you are using,
You can check it with  python --version

Whats the python version that you are using, You can check it with python --version

3.9.12

Can you try with python 3.10 please?


Export didc check as rust function

close this in favor of https://github.com/dfinity/candid/pull/309


Update main.c

Update main.c according to opened issue

I haven't touched this project in about 10 years. At this point I don't
think there's any value in it, and that it isn't worth salvaging. I only
keep it around for posterity, to look back at where I was at this point
in my programming career. So I just want my repository frozen like it
was, flaws and all.
If you find this interesting and want to run with it yourself, go ahead!
Make it your own. I'll even change the license if you like, since I use
the public domain for all much open source stuff now-a-days.
However, a few years ago I made a far more interesting project that
directly generates machine code. You might want to look at that instead:
https://github.com/skeeto/bf-x86

It would be nice if you would permit me to license work based on it under MIT license.


Custom implementation of CacheKey?

Good  day :octocat:
I'm working on smart cache for MyBatis with external Redis storage based on my domain.
How can I change implementation of default CacheKey? I want to use combination of path to method in mapper and list of function arguments and smth else.
It looks like it's hard-coded in BaseExecutor. Can I inherit and change implementation for createCacheKey only? Without reflection of forking this project?

Hello, @binakot !
This may be related to #1541 .
Could you elaborate on 'smth else' ?
If I understand correctly, 'path to method in mapper' and 'list of function arguments' are already added to CacheKey and I would like to know what kind of extra data you want to add.
The reporter of #1541 , for example, wanted to add 'client id' retrieved from ThreadLocal.

Hello, @binakot !
This may be related to #1541 .
Could you elaborate on 'smth else' ?
If I understand correctly, 'path to method in mapper' and 'list of function arguments' are already added to CacheKey and I would like to know what kind of extra data you want to add.
The reporter of #1541 , for example, wanted to add 'client id' retrieved from ThreadLocal.

In fact I want to remove everything from cache key result string except method name and parameters list. I have an idea to use mybatis cache in redis as distributed cache between few applications.
If I load some data from one application, it's going to cache. After the second application will get data from cache, because both applications will have same cache key in common Redis instance.
Thanks for the related issue, it looks close to this one. But it's still opened and there are no any suggestions :(

#1541 is a feature request and we are still investigating its possibility.

I want to remove everything from cache key result string except method name and parameters list.

There is nothing conclusive yet, but it seems unlikely that we allow users to create a custom CacheKey implementation like that because it will prevent MyBatis from functioning properly.
Have you considered managing your cache outside of MyBatis?

#1541 is a feature request and we are still investigating its possibility.

I want to remove everything from cache key result string except method name and parameters list.

There is nothing conclusive yet, but it seems unlikely that we allow users to create a custom CacheKey implementation like that because it will prevent MyBatis from functioning properly.
Have you considered managing your cache outside of MyBatis?

At this moment I'm looking for possibility to manage my cache inside MyBatis, because we are really hard depending on this layer in our applications. You can provide default implementation, but let to developers do custom implementations. And if it will break functionality of MyBatis, it is the problem of developers, isn't it? 😄Because now we have to hack the MyBatis with reflection...

Default implementation of CacheKey gives that:

Our custom implementation gives that:


Fix: Retry integration when node is back online

The fix should result in :

Meanwhile the sensors data are Unavailable:

But after node is ready you get:

Fixes #41

Thank's @VeeeneX!


Frontend Fix Unnecessary Requests

I noticed that the UI makes more requests than necessary to load data:
Public Profile -  requests all credentials separately even though the data is already available with the list /credential call
Wallet - requests the /document 2x

Will potentially be fixed by switching to Vuex at some point


Package name

I have the feeling that LikelihoodFunctions is a bit too general for this package. If I understand correctly, this package aims at propose models with Gaussian and non-Gaussian likelihoods. Shouldn't the name be then GPLikelihoods, NonConjugateGPs or something like this?

NonConjugateGPs sounds sensible: it reflects well what the package provides, and is self-descriptive I think.


Adding index coalescing script

Usage:
python -m colbert.utils.coalesce --input=/pathto/msmarco.index/
--output=/pathto/msmarco_single.index/

@santhnm2 this should be ok to merge too, I have filled in the gaps to move/create the other required files.


85 Allow suppliers to edit their submitted applications

Trello: https://trello.com/c/kQpbazwt/85-allow-suppliers-edit-submitted-application-if-opportunity-is-still-open

New title and button style for application start page
Fixed styling on 'Evidence structure' header (by wrapping in <div class="dmspeak">
'Check your answers' page (with Edit links and application deadline shown if the Brief is still live)
Reorganised/renamed headers, removed summary tables and view opportunity link from 'What happens next' page as per prototype
Suppliers can now edit a submitted application (as long as the Brief is still live). This uses the same forms as the first time they go through the flow, but with /edit appended to the URLs.
Editing an answer redirects back to 'Check your answers'
Opportunity list page links to 'Check your answers' instead of 'What happens next'
Fixes pytest deprecation warnings
Analytics event to track whether a supplier is editing a draft or submitted application
Support suppliers with legacy applications (they will see the Check Your Answers page instead of the What happens next page - see screenshot below).

Check Your Answers page (before submission):

What happens next

Check Your Answers page (after submission but before the brief closes):

Check Your Answers page (once the brief has closed):

(Legacy flow - as above but with the sections in a different order and slightly different copy).
Ready for review but should not be merged until a) frontend toolkit changes are merged (https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/387) b) functional tests are sorted.

@idavidmcdonald I've just added you on to this for context with what we're doing with the new supplier edit flow (though if you want to do a proper review by all means go for it!)
@benvand - I think all your comments have been addressed now.

@idavidmcdonald I've had a chat with Tobi about this and we're going to see how the Check Your Answers (CYA) page looks for a legacy application, and point suppliers there if they want to view details of the application (instead of the 'view result' page) assuming it's all OK. It should just be a case of 1) making sure we use the right manifest on the CYA page 2) redirecting legacy application users from the result page to the CYA page 3) making sure that flow is tested. Obviously the supplier won't be able to edit a legacy application, which simplifies things. We can also remove a bunch of legacy stuff from the 'result' page (tests, template includes).

Oh I also thought it would be great if we had functional tests that covered the old legacy brief responses work with our pages (would be a nice easy way to maintain high level functionality and make sure they don't fall over plus it self documents)... but realise we run into the same problem of setting data in the DB to do that.


HDFS-17508. RBF: MembershipStateStore can overwrite valid records when refreshing the local cache

Description of PR
When the MembershipStore refreshes its cache, it will also call the overrideExpiredRecords() method, which will write the Expired state back to the state store. Due to a race condition this logic can overwrite valid records. overrideExpiredRecords should first check if the state of the record is already set to "EXPIRED" before it writes the record to the state store.
How was this patch tested?
Added unit test "TestStateStoreMembershipState#testRegistrationExpiredRaceCondition"
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 48s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 22s

trunk passed

+1 :green_heart:
shadedclient
33m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 46s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 21s

the patch passed

+1 :green_heart:
shadedclient
33m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
36m 35s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

166m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6783/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c7a95554dfb3 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7712c303c800709859864f950af23dbb88fc5648

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6783/1/testReport/

Max. process+thread count
4485 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6783/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Fix Issue 13572: etc.c.zlib must be nothrow

Yay, more attributes! LGTM

AIU, zalloc and zfree are used by zlib to initialize the stream state. Now they can't allocate from GC?

@d-random-contributor nothrow is not @nogc

Auto-merge toggled on


Taal: Enable AD

We probably need to introduce something like uEltype which might be different from RealT aka real(solver) to allow efficient computations and AD in Taal. I'll open this issue since I'm not sure whether we want to have this as a blocking issue for Taal or whether it's okay to look into this later.

I'd strongly argue against making this a blocking issue. The possibility for AD is something I am excited about, but there are still so many fundamental things we need to port (without even considering new features), that I would strictly limit ourselves to the current features in master.


Add codesign to gitian

Nice, this is upstream changes?

Nice, this is upstream changes?

Changes look like they make sense, I will test when I get home.

Changes look like they make sense, I will test when I get home.

@aguycalled can you send me a sample signature-osx.tar.gz

@aguycalled can you send me a sample signature-osx.tar.gz

Is the build bot running for this PR?

Is the build bot running for this PR?

A new build of a8c7b38f356fb708a61958394697f9666c92c46d has completed succesfully!
Binaries available at https://build.nav.community/binaries/codesign

A new build of a8c7b38f356fb708a61958394697f9666c92c46d has completed succesfully!
Binaries available at https://build.nav.community/binaries/codesign

signature.tar.gz

signature.tar.gz

got it working
https://build.nav.community/binaries/codesign/navcoin-osx-signed.dmg

got it working
https://build.nav.community/binaries/codesign/navcoin-osx-signed.dmg


Gonzales 3.2 - Fix rule nesting-depth

This fixes the rule nesting-depth.
Node type simpleSelector has been removed.
Currently only the scss part is fixed, sass throws Fatal.
DCO 1.1 Signed-off-by: Daniel Tschinder<EMAIL_ADDRESS>

As of gonzales 3.2.6 also the sass tests now work.


Updating CU5 note

Including in the note that scenarios with SQL Server SP2 can be executed using a single Availability Group.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/high-availability-using-sql-server-always-on-availability-groups.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@wsilveiranz Great addition! Thank you for making the CU5 note more clear.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/high-availability-using-sql-server-always-on-availability-groups.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Latest version is <IP_ADDRESS> instead of 7.1.0

Fix documentation in README

Sorry about that - had an issue with the release of the gradle plugin...  We're already at 7.1.2 so this is no longer needed.


fix(scheduler): correct skip policy for affinity and taints

What this PR does / why we need it:
Fix blow errors:

hwameistor.io/skip-affinity-annotations specified in pvc but not take effect
node that has PrefferNoSchedule taint but being filtered out

Special notes for your reviewer:
Does this PR introduce a user-facing change?

/lgtm

/lgtm


Add autocmd for DirChangedPre to enable doing some work before the cwd changes

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
As the plugin author of https://github.com/rmagatti/auto-session/ I'd like to be able to do some session related work before the cwd changes.
In the context of this issue for example https://github.com/rmagatti/auto-session/issues/102 when :cd is called, I'd like to be able to save the current session and clear the current session tracking from the plugin before the cwd changes. Then on DirChanged I'd want to evaluate if the now current cwd has a mapped session or not. Today I can only do the DirChanged portion of this.
Describe the solution you'd like
Ideally I'd have a DirChangedPre to work with. It would be an autocmd called right before the actual cwd change.
Describe alternatives you've considered**
Right now there's no real alternative. At least not one that enables me to save the session before anything happens to the cwd. The only real workaround is stopping the plugin from tracking the current session when a DirChanged happens, but that isn't really enough.
Additional context
N/A

Oh nice, thanks!


Enhance template engine support to allow multiple engines for different file extensions

I think the latest Error enum declaration needs some work, especially around error messages.

@shmuelk so what should be improved? I have committed a missing whitespace in commit https://github.com/IBM-Swift/Kitura/commit/545f957b462fdf51c6d1a3043c8010f61ec03be9 .

I was mistaken. The code is fine.


Release version <IP_ADDRESS>

Hi @klochowicz!
This PR was created in response to a manual trigger of the release workflow here: https://github.com/itchysats/itchysats/actions/runs/2279467916.
I've bumped the versions in the manifest files in this commit: 16b58d39523c8a166d6cfd29950edec154212191.
Merging this PR will create a GitHub release!

closing this as we released manually


[Docs] Very poor performance

In this issue you can find some tips/fixes/etc for fixing bad performance.
First, you should get this:

[x] Good 5Ghz WiFi
[x] iPhone 11+
[x] Actual build of iPhoneVR

ALVR video configuration

Set Framerate to 60 FPS.
Set all resolutions to actual for your device. (width / 2, because 2 eyes)

Example:

Download
https://www.mediafire.com/file/ynhx37qmyqek881/fix.zip/file
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."


Logging an empty set of points doesn't work as expected

Describe the bug
It appears that calling rr.log_points() with any empty set of point is discarded instead of properly recorded as a zero-point entry. I haven't checked if the other rr.log_XXXs() calls have the same behaviour.
To Reproduce
import rerun as rr

rr.init("mp_pose")
rr.spawn()

for i in range(10):
    rr.set_time_sequence("frame_nr", i)
    rr.log_points("points", [[5, 7], [1, 2], [3, 4]], radii=1.0)
    rr.log_rect("rect", [0, 0, 10, 10])

for i in range(10, 20):
    rr.set_time_sequence("frame_nr", i)
    rr.log_points("points", [])
    rr.log_rect("rect", [0, 0, 10, 10])

Expected behavior
When setting the time to frame 10 or more, the "points" entity should be:

showing up in the time line as empty
not shown in the viewer, since 0 points are explicitly logged

Actual behaviour

Note that adding the rr.log_rect() calls was necessary. Commenting them out means that the timeline actually stops at frame 10 and the bug cannot be observed.
Rerun version
rerun_py 0.7.0-alpha.0 [rustc 1.69.0 (84c898d65 2023-04-16), LLVM 15.0.7] aarch64-apple-darwin jleibs/static_store_hub 7412e0e, built 2023-06-08T14:06:12Z

Back story is:

it's impossible to tell if an empty array is a null point2d or null point3d
this will become a non-issue with the codegen'd api


clean up RUNTIME_DIR_PARENT handling

I build tested this PR from Alpine Linux.
It also includes a few small fixes: it doesn't assume uid_t fits an int, doesn't use the assert to avoid abort()ing from a library, removes an unused header, and uses a trick to at least try to check that the macro RUNTIME_DIR_PARENT is a string although it's a macro so you can ultimately insert any C code you want in there.

-D_GNU_SOURCE is necessary if asprintf() is used, otherwise no.

-D_GNU_SOURCE is necessary if asprintf() is used, otherwise no.

Thanks for confirming.
Since I've fixed the formatting of the uid_t slightly differently now, the rest of this patch seems to be largely stylistic changes that I happen to disagree with. If you have any further fixes or functional improvements to contribute please feel free to open a new PR!


Remove uses of Autohook from dedicated.cpp

Code review:

The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

Check logs to make sure that all of the changed hooks are being created properly
Make sure that dedicated servers still gracefully close on script error instead of hard crashing.

Make sure that dedicated servers still gracefully close on script error instead of hard crashing.

Do we have an easy way to script crash via some script function? Or do we need to write like a broken mod to test this >.<

Do we have an easy way to script crash via some script function? Or do we need to write like a broken mod to test this >.<

The latter I think. Iirc any error induced by a simple script command is non-fatal, so youd have to introduce a logic (not compile) error into the scripts and trigger it


Update Jenkinsfile

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/test kyma-integration

/retest

/test kyma-integration

@suleymanakbas91: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kyma-integration
93a8b11f40f2d2427df8b7fc3ce7aed558f24529
link
/test kyma-integration

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test kyma-integration

/test kyma-integration

/test kyma-integration

/test kyma-integration

@suleymanakbas91: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kyma-integration
93a8b11f40f2d2427df8b7fc3ce7aed558f24529
link
/test kyma-integration

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test kyma-integration

@suleymanakbas91: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kyma-integration
93a8b11f40f2d2427df8b7fc3ce7aed558f24529
link
/test kyma-integration

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test kyma-integration

@suleymanakbas91: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kyma-integration
93a8b11f40f2d2427df8b7fc3ce7aed558f24529
link
/test kyma-integration

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test kyma-integration

/test kyma-integration

/test kyma-integration

/test kyma-integration

/test kyma-integration

/test kyma-integration

/test kyma-integration

/test kyma-integration

@suleymanakbas91: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kyma-integration
93a8b11f40f2d2427df8b7fc3ce7aed558f24529
link
/test kyma-integration

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test kyma-integration

/test kyma-integration


Support 'resource_group_id' parameter and add README-CN docs.

Hi @zql-tqy @xiaozhu36  I'm seeing this after upgrading to 1.8.0 . Can you please have a look?
Error: Missing resource instance key

  on .terraform/modules/network.vpc/terraform-alicloud-vpc-1.8.0/outputs.tf line 54, in output "this_resource_group_id":
  54:   value       = alicloud_vpc.vpc.resource_group_id

Because alicloud_vpc.vpc has "count" set, its attributes must be accessed on
specific instances.

For example, to correlate with indices of a referring resource, use:
    alicloud_vpc.vpc[count.index]

Thanks!

@joec4i
I'm very sorry that this is my mistake, thank you for your problem, this problem has been fixed.


plunker samples are broken

multiple plunkers seem to have the same error:
(SystemJS) TypeError: ctorParameters.map is not a function

Plunker samples are now fixed. Thanks!


When using data how does this improve performance?

Hi quick question, Laravel already creates a view cache on the file system and it is effective when not dynamically using data, and it will be the same with any dynamically content that requires data. Hence the question I'm not sure if there would be a huge performance improvement? Personally I think OpCache might give you even better improvement without the need for this. But I would love your feedback and background on this and if you have noticed big improvements?
Thanks!

laravel cache is just caching the rendering part of the templates php rendered files. this package allows you to cache the output of another view as static html.
usecase: imagine having a dropdown menu with many inherits in it. you will need to render the tree each time page is loaded. with laravel different caches you can cache the rendered template php file, the data coming from the db but still need that the framework go through all cached data to output a dropdown menu which never changes and is always the same unless the data is changed.
with this package you can cache the output as static html and invalidate based on the same logic when you invalidate the data coming from your controller. if new data is coming then cache is dumped in it's generated once.


Sharing video on iOS to Instagram Stories

@aarajput Hi,
Is it possible to share a local video file to Instagram stories in iOS?
I tried all the other libraries (including Google's share_plus) and they only share to Instagram Feed not Instagram Stories.

You might need to use instagram sdk for that.

Seems like there is no need for the sdk
https://developers.facebook.com/docs/instagram/sharing-to-stories


Call coffee compiler directly from node_modules in Makefile

Noticed the Makefile didn't work for me because of an implicit global dependency

Fair enough! Usually only I use the makefile as it's only for publishing, but I'll take it anyway :grinning:


Numbers being Returned as Strings

It appears that any number fields are being returned as strings, so I can't use sum() in the query. Is there someplace I can add a PDO option to possibly change that?

Hello, I have not been able to support this library for a long time.
Now I'm back.
I tried to execute the SELECT SUM (id) FROM Table1 statement and it worked perfectly for me.
Can you teach them the SQL and the structure of the table?
Is it possible that you are trying to SUM a field of text type?

From what I’m reading maybe just the way pdo works with  access, you may not be able to do anything about it.
Thanks
Here is the Access table
<EMAIL_ADDRESS>Here is the query I’m trying to run.
return self::wherebetween('DateOfSummary',[$startDate, $endDate])
->sum('TotalManifests')
->sum('TotalFunJumps')
->sum('TotalJumpMasterJumps')
->sum('TotalTandemJumps')
->sum('TotalBlockJumps')
->sum('TotalVendorJumps')
->sum('TotalStaffJumps')
->sum('TotalManifestValue')
->sum('TotalJumpCharge')
->sum('TotalJumpDiscount')
->sum('TotalJumpTax')
->sum('TotalAdditionalServiceCharge')
->sum('TotalAdditionalServiceDiscount')
->sum('TotalAdditionalServiceTax')
->sum('TotalEquipmentCharge')
->sum('Total EquipmentDiscount')
->sum('TotalEquipmentTax')
->sum('TotalPaymentAmount')
->sum('TotalPaymentSurcharge')
->sum('TotalTransfersIN')
->sum('TotalTransfersOUT')
->sum('TotalCreditsIssued')
->sum('TotalCashAmountIssued')
->sum('TotalStaffPaymentIssued')
->sum('TotalRefundsIssued')
->sum('TotalDebitsIssued')
->sum('TotalRentals')
->sum('TotalMembershipCharges')
->sum('TotalGearstoreSales');
And here’s the error I get
<EMAIL_ADDRESS>From: Zoilo Mora<EMAIL_ADDRESS>Sent: Monday, June 17, 2019 3:57 PM
To: zoilomora/laravel-msaccess<EMAIL_ADDRESS>Cc: Rob Szabo<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [zoilomora/laravel-msaccess] Numbers being Returned as Strings (#5)
Hello, I have not been able to support this library for a long time.
Now I'm back.
I tried to execute the SELECT SUM (id) FROM Table1 statement and it worked perfectly for me.
Can you teach them the SQL and the structure of the table?
Is it possible that you are trying to SUM a field of text type?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/zoilomora/laravel-msaccess/issues/5?email_source=notifications&email_token=AAHHGT6NS5BCGASX6JPFLKTP27T7NA5CNFSM4HYZAGC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4IWHI#issuecomment-502827805, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAHHGTZSZ2H5Y4KC42AXBH3P27T7NANCNFSM4HYZAGCQ.

@robs007 Try uploading the image directly on github.
By email they are not published.
https://github.com/zoilomora/laravel-msaccess/issues/5

Looks like the simple solution is to just use the laravel cast method in the model and set them there and sum them after. Would still be nice to be able to do the suming on the DB side, but I guess this is a work around.

I am currently focusing on separating the DBAL part of the integration with Laravel and testing it as much as possible.
When that part has it ready, it will be easier to obtain a more stable version of this library that will inherit from DBAL.


Memory leaks using local rendering device

Hello! I have also been working with compute shaders recently and came across this this bug in Godot engine: issue#71003. I have not tested Your extension, but from the first look it seems that it is vulnerable to this bug, because You create local rendering device once on class initialization and do not free() it manually. This can potentially lead to the following:

The engine will crash on reaching certain number of ComputeWorkers (199 in my case, see example project in the mentioned issue).
Each ComputeWorker will leak memory on destruction.

I hope this will save some of Your time. :)

Thanks for the info! I was not aware of this bug when I submitted this extension to the asset library. I will take a look at it and see if I can find a workaround if there is one. Else, I'll update the README to include mention of this bug until it is fixed.

Commit #11649dd8 fixes the memory leak issue. On _exit_tree() the ComputeWorker will now free all RenderingDevice resources before freeing the RenderingDevice itself.

A comment regarding crashes on too many of ComputeWorkers: may be it is worth creating local rendering device only on shader execution and destroying it after it (i.e. not having it as a class member)?

I've updated the initialize() and destroy() functions to make the ComputeWorker able to start and stop at will. Calling destroy() will free all the RenderingDevice resources and the RD itself, setting var initialized to false. Then you can swap out shaders, uniforms, etc. and start it back up again with a new RD by calling initialize().


refactor: split up ASDF step from the build/test

No Asana ticket.
Taken from https://github.com/mbta/.github/pull/4.

@paulswartz Leaving an idea for you here because it's too late in the day for Slack. Re my question about propagating workflow template updates to projects, this is the "simplest possible solution" that's come to me. Maybe it's better than nothing until we come up with something better.
The thing it hinges on that I just learned, is that you can stick .patch on the end of a GitHub PR URL to get a patch file. So maybe you could post to the engineering channel that a new PR got merge, anyone who's using the "report coverage" workflow in your project, maybe you'll want to download this patch and apply it like:
git apply -p2 --directory=.github/workflows/ <path/to/4.patch>


Set up Gemini

Add workspace extensions to AARC repo

Used direct to Google Cloud Code for Gemini instead https://cloud.google.com/code/docs/vscode/write-code-gemini

https://github.com/josephrkramer/dotfiles


<EMAIL_ADDRESS>fix download/autoupdate urls

Relates to #369. Should hopefully close it too. Tested with aria2 active.

[x] I have read the Contributing Guide.

It's been 3 weeks now. What's going on?


Add charts for the overall LP data

I think this is done, if not, please let me know what charts I've missed :)


refactor extension types and begin remote (runtime) extension support

This should be a considered a POC but I would like comments on the direction. I refactored the types to streamline the 2 types of extensions (local/remote(runtime)). If an extension provides a url for a remote extension, we are expecting it to be a module with a default export that is a function that begins the execution of its code. The import/execution will occur after its first activation event. There are certainly some cons and fragility to this approach, and even if accepted it needs some optimization and cleanup, which is why I am looking for feedback.
This PR would be required to support dynamic remote imports with Webpack and commonjs: https://github.com/imodeljs/create-react-app/pull/69
This shows an example of a local and remote extension being provided to the Viewer with this approach: https://github.com/iTwin/viewer/pull/150

Looks like the doc generation removed some of the APIs from the doc for appui-react and appui-layout-react. Perhaps npm run build && npm run extract-api in those two directories to correct it? (Rush sometimes fails to do this correctly after a merge, though I don't know why.)

Looks like the doc generation removed some of the APIs from the doc for appui-react and appui-layout-react. Perhaps npm run build && npm run extract-api in those two directories to correct it? (Rush sometimes fails to do this correctly after a merge, though I don't know why.)

Recent changes in common/api/core-geometry.api.md are also not showing up in the diff...

Looks like the doc generation removed some of the APIs from the doc for appui-react and appui-layout-react. Perhaps npm run build && npm run extract-api in those two directories to correct it? (Rush sometimes fails to do this correctly after a merge, though I don't know why.)

nice catch. Not sure what happened there. I re-ran and updated this PR. Can you verify that everything looks ok now?

There are certainly some cons and fragility to this approach

Can you elaborate please?

There are certainly some cons and fragility to this approach

Can you elaborate please?

@pmconne @kckst8 @johnnyd710 I have the same question. What cons do you see with this approach? I listed some in my other comment but feel like I'm missing something here when reading through the code.

If I'm reading this correctly, the main change is that each Extension is going to require the creation of an instance of a Provider class that will be implicitly kept around to know exactly where to get the Extension from. This is instead of the alternative where we previously iterated over each of the Loaders that an Extension could be gathered from which ended up in potentially useless server calls. Please correct me if I'm mis-stating anything there.
It puts a bit more onerous on whoever is adding the Extension in that they need to know exactly where it's coming from but still not let it come from two different places. This may have ramifications on what the API needs to look like when you're wrapping this in an application to allow the local development workflow, and side-loading, in the Viewer. Unless the iTwin Viewer always either loads from one or the other. I need to think this part through some more...

This is correct. @johnnyd710  proposed this provider architecture and it made sense to me. We've been lumping a group of related but contractually different items into a single somewhat ambiguous item called an "Extension" and then attempting to decipher what each actually is internally, like you mentioned. I believe this adds more confusion for the user and is more fragile for the API, as we are essentially guessing and making assumptions as to what the user wants in the current architecture. While this adds an extra step for consumers, it makes it abundantly clear to them and our API what they are attempting to load. Unless I am missing something, I don't know that there is a case where an application developer would be attempting to load an extension without knowing its source. We just need to make sure that we document each clearly.
As for the viewer, currently it accepts an array of instances of ExtensionProviders, which could be local, remote, or from the service. We could overload its type and have the user just pass in extensions and a type and let the Viewer create the provider instances, but I'm not so sure that we want to hide the differences from the user. Its very declarative.

There are certainly some cons and fragility to this approach

Can you elaborate please?

@pmconne @kckst8 @johnnyd710 I have the same question. What cons do you see with this approach? I listed some in my other comment but feel like I'm missing something here when reading through the code.

Listed most of my thoughts in my comment below. I don't know of anything that makes this more fragile, other than the potential for dynamic import to fail based on build system and module format. However, @johnnyd710  implemented a fallback for that case that I believe is sound. @johnnyd710 was previously working on a solution that involved script tags. Possibly this comment was leftover from that?

If I'm reading this correctly, the main change is that each Extension is going to require the creation of an instance of a Provider class that will be implicitly kept around to know exactly where to get the Extension from. This is instead of the alternative where we previously iterated over each of the Loaders that an Extension could be gathered from which ended up in potentially useless server calls. Please correct me if I'm mis-stating anything there.
It puts a bit more onerous on whoever is adding the Extension in that they need to know exactly where it's coming from but still not let it come from two different places. This may have ramifications on what the API needs to look like when you're wrapping this in an application to allow the local development workflow, and side-loading, in the Viewer. Unless the iTwin Viewer always either loads from one or the other. I need to think this part through some more...

This is correct. @johnnyd710 proposed this provider architecture and it made sense to me. We've been lumping a group of related but contractually different items into a single somewhat ambiguous item called an "Extension" and then attempting to decipher what each actually is internally, like you mentioned. I believe this adds more confusion for the user and is more fragile for the API, as we are essentially guessing and making assumptions as to what the user wants in the current architecture. While this adds an extra step for consumers, it makes it abundantly clear to them and our API what they are attempting to load. Unless I am missing something, I don't know that there is a case where an application developer would be attempting to load an extension without knowing its source. We just need to make sure that we document each clearly.
As for the viewer, currently it accepts an array of instances of ExtensionProviders, which could be local, remote, or from the service. We could overload its type and have the user just pass in extensions and a type and let the Viewer create the provider instances, but I'm not so sure that we want to hide the differences from the user. Its very declarative.

@kckst8 okay, that makes sense to me. It took me about 5 reads through the code to understand exactly how of it all worked due to the multiple execute methods and how they're invoked :) However, now that I know I get the reasoning for doing it.
In the Viewer are you going to introduce a prop for a host url to be added? That's one of the strange parts about the API, that function is only valid in the case that you're configuring your own Extension Service. I couldn't think of a better way to do it though in order to avoid people trying to load Extensions from just any random url.

If I'm reading this correctly, the main change is that each Extension is going to require the creation of an instance of a Provider class that will be implicitly kept around to know exactly where to get the Extension from. This is instead of the alternative where we previously iterated over each of the Loaders that an Extension could be gathered from which ended up in potentially useless server calls. Please correct me if I'm mis-stating anything there.
It puts a bit more onerous on whoever is adding the Extension in that they need to know exactly where it's coming from but still not let it come from two different places. This may have ramifications on what the API needs to look like when you're wrapping this in an application to allow the local development workflow, and side-loading, in the Viewer. Unless the iTwin Viewer always either loads from one or the other. I need to think this part through some more...

This is correct. @johnnyd710 proposed this provider architecture and it made sense to me. We've been lumping a group of related but contractually different items into a single somewhat ambiguous item called an "Extension" and then attempting to decipher what each actually is internally, like you mentioned. I believe this adds more confusion for the user and is more fragile for the API, as we are essentially guessing and making assumptions as to what the user wants in the current architecture. While this adds an extra step for consumers, it makes it abundantly clear to them and our API what they are attempting to load. Unless I am missing something, I don't know that there is a case where an application developer would be attempting to load an extension without knowing its source. We just need to make sure that we document each clearly.
As for the viewer, currently it accepts an array of instances of ExtensionProviders, which could be local, remote, or from the service. We could overload its type and have the user just pass in extensions and a type and let the Viewer create the provider instances, but I'm not so sure that we want to hide the differences from the user. Its very declarative.

@kckst8 okay, that makes sense to me. It took me about 5 reads through the code to understand exactly how of it all worked due to the multiple execute methods and how they're invoked :) However, now that I know I get the reasoning for doing it.
In the Viewer are you going to introduce a prop for a host url to be added? That's one of the strange parts about the API, that function is only valid in the case that you're configuring your own Extension Service. I couldn't think of a better way to do it though in order to avoid people trying to load Extensions from just any random url.

@calebmshafer same thoughts and I don't know that I have a great solution yet. Basically I expect that the Viewer will iterate and register the hosts, but we should be explicit that it is being done and allow the user to potentially even disallow, though I'm not sure why they would

@johnnyd710 what are we waiting on before merging this?


Add InstallApps

Towards https://github.com/giantswarm/giantswarm/issues/13206
Checklist

[x] Update changelog in CHANGELOG.md.

This is a new library for creating app CRs in integration tests.
It will be used in projects with Go integration tests and in apptestctl to install chartmuseum.


Minitest support?

Hello, this looks like an awesome project. Our test base is incredibly slow, probably because of all the DB calls. I would like to integrate this tool, but ... we use minitest. Is it possible to use this with minitest?

Thanks for your interest. Because it’s just ruby you can use it just fine with minitest.  The only thing you won’t get is the automatic constant stubbing. You’ll need to use ‘UserMock’ instead of ‘User’. An intergration for auto stubbing is also possible but the code needs to be written. I’d be  willing to work with anyone to make a PR.


Add support for RTC from the HIB peripheral

Was this related to https://github.com/rust-embedded-community/tm4c-hal/commits/add_hibernate_rtc_module or just a co-incidence??

I wrote that because tracking time in Neotron with the frame tick is not good if your frame tick is only 59.9 Hz.


Remove all fs.existsSync calls

They have been officially recommended against for a long time

Who is "they"?

The calls :|

https://nodejs.org/api/fs.html#fs_fs_existssync_path

Oh, I see.


fix: Report turns to skeleton after deleting expense with comments offline

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/45461
PROPOSAL: https://github.com/Expensify/App/issues/45461#issuecomment-2232525425
Tests

Go to DM with any user that has no unsettled expense.
Submit an expense.
Click on the expense preview.
Send a few comments.
Go offline.
Click on the report header.
Click Delete expense.
Delete the expense.
Verify that: Report will not turn to skeleton after deleting the expense offline.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to DM with any user that has no unsettled expense.
Submit an expense.
Click on the expense preview.
Send a few comments.
Go offline.
Click on the report header.
Click Delete expense.
Delete the expense.
Verify that: Report will not turn to skeleton after deleting the expense offline.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/0fd44ccb-e99a-4dda-95b4-35c9c1685d68

Android: mWeb Chrome

https://github.com/user-attachments/assets/69315473-83fd-4410-89f3-294269a1bccc

iOS: Native

https://github.com/user-attachments/assets/ee80781b-ff44-43ec-ab2a-812b7bf938e8

iOS: mWeb Safari

https://github.com/user-attachments/assets/565af60b-8d42-4494-9851-5762b95755c3

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/98e28503-5fd6-4de4-b889-319307c3860f

MacOS: Desktop

https://github.com/user-attachments/assets/43780e76-0cd7-4a8b-8330-0e9d190937c0

@parasharrajat I see that in cases with regular messages, it doesn't show the [Deleted message]. In this case, I think it shouldn't be shown for consistency

@parasharrajat In here, we don't show [Deleted message] while offline

Seems like that's intended offline UX behavior based on that comment, so yeah that is okay

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.15-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


pypy: fix FFI definition of Py_Buffer

Fixes #1736
Looks like PyPy has extra fields for the Py_Buffer struct - https://foss.heptapod.net/pypy/pypy/-/blob/branch/default/pypy/module/cpyext/parse/cpyext_object.h#L78
Needs a CHANGELOG entry and also tests (in pyo3-pytests, because this is PyPy) before this can be merged. Will write them later, got to go to work now! 💼

Confirmed, this fixes the crash on my box!


Fix focus of dialog inputs within shadow DOM (#189)

Thank you. I normally rev the release version myself but thanks for bumping it too. I can publish this soon.

As as a bit of a side note, and I'm not sure where else to put this: I'm glad folks are interested in polyfilling dialog inside a shadow root, but I actually don't think it's the right answer long-term.
I have an "element" branch of this repo which creates the <x-dialog> element (you can check it out, serve the directory, and load this file for a test). It uses Web Components (and Shadow DOM) to either polyfill (or use the native if supported).
It's much easier to use—just add <x-dialog> to your pages. But, it's no longer a polyfill. (Custom Elements must be in the form "x-y", so I can't just create one for <dialog>). So I wonder if users of this library might be frustrated to be told that <dialog> is for native (and... poor-ish SD support), but use <x-dialog> if you're targeting modern browsers (non-IE11).

I, for one, am in favor of native elements (and APIs) whenever possible. I recently switched from a web-components-based custom dialog to the native dialog because I think that web components shouldn't be used to reinvent basic / native HTML functionality. So, when I target modern evergreen browsers I expect to be able to explore the full potential of HTML5 - while plugging in polyfills when needed, but unplugging them as soon as browser support is there.
With a custom dialog, the plug-in and unplug actions are not so straightforward anymore. If I make a heavy use of x-dialog in my app and at some point I find out that the native one has full support, I need to refactor / change quite a bit.
I guess a good use case for a custom dialog is an enhanced (not just style-wise) or specialized type of dialog, such as a non-blocking confirmation dialog.
Other than that, I hope that Firefox and Safari get up to speed with the "living standard" soon :)

I totally agree re: using native components, although <dialog> has unfortunately languished for over ~7 years now (since I took over the polyfill at least). Firefox has a basic implementation IIRC but that's about it. It's been saved from being cut from the spec at least once.
The big challenges with a polyfill are basically; interaction with stacking context (which a lot of folks do get right, but is pretty frustrating), and the remarkably odd rules around static positioning for modals (since the element remains "in-place" on top, even if you scroll).
With x-dialog, I tried to make an element which deals with those issues (... by forcing position: fixed for the polyfill and native support case) and also simplifies the instantiation process (there is none—and no issues with CSS insertion—you just add the CE), but which otherwise matches the spec. I appreciate that it could feel like "bait-and-switch" though, so thank you for your feedback. My decision at this point though becomes:

do I ship x-dialog separately
or do we include it as a 'secondary option' for modern browsers in this repo.

@samthor was this fix published? Seems I cannot get version 0.5.2

No, sorry. It's published now.
On Mon, 3 Aug 2020 at 22:01, Adrian Nita<EMAIL_ADDRESS>wrote:

@samthor https://github.com/samthor was this fix published? Seems I
cannot get version 0.5.2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/dialog-polyfill/pull/198#issuecomment-667983881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5DEDV2I5CWQXAHWMXULTR62RKRANCNFSM4NBPBN7A
.


Copper

https://www.getcopper.com/

Fixed in https://github.com/jplock/awesome-fintech/commit/8abc238bbf2378cde9a322dc6ad164f0d5cbea70


Creating Multiple ports in service-per-pod, Not working

I have created service-per-pod for statefulset, its working for single 80/udp port. but I needed for multiple ports like 80/udp, 30000/tcp...
Please help, how to create multiple ports in service-per-ports

Please provide some examples

Closing, please re-open with additional input


How to build project

Hello
Can someone please help me with the build steps to run the project on local ? I could compile the project successfully but unsure how to run it on local . Some documentation in read me will be a great help.

Hi @samir-ware . Please see this wiki page for information on how to get help: https://github.com/jamesagnew/hapi-fhir/wiki/Getting-Help


X-Request-Start header

Hi folks,
Looking at the headers documentation (https://fabiolb.net/feature/http-headers/), we can't figure out if Fabio supports setting a dynamic header based on micro/milliseconds since epoch.
Example with Nginx:
proxy_set_header X-Request-Start "t=${msec}";

or Apache:
RequestHeader set X-Request-Start "%t"

By setting the header, it allows visibility into request queuing to the app from farther upstream (Fabio in our scenario).
It's also needed for APM vendors (New Relic, Scout, Instana, etc):

https://docs.newrelic.com/docs/apm/applications-menu/features/request-queue-server-configuration-examples
https://docs.scoutapm.com/#http-header

Let us know if it's possible.
Thanks in advance ✌

@scalp42 There isn't any current dynamic header support other than the specific documented cases.  There is an open issue though with ongoing discussion: https://github.com/fabiolb/fabio/issues/168
Going to close this as a duplicate of #168 as jippi actually mentions this exact case in that issue.
Feel free to re-open if the solutions discussed there wouldn't resolve your issue.


Make sure that all events associated to an object are observed in tests

By specifying on the ObjectEventWatcher in the functional tests a start
resourceVersion, we can first create an object and then establish a long
polling collection. This way we get all events which might have occoured
between the object modification and the watch start.
Signed-off-by: Roman Mohr<EMAIL_ADDRESS>

retest this please

retest this please

retest this please

@stu-gott thx. Do you have an idea for shorther method names which are still descriptive enough?

I assume you're talking about functions such as "SinceWatchedObjectResourceVersion"? I don't mind them, honestly. These are inside a test suite and not exposed in an API in any way--so we're always free to change them later.


#34: Added test for FetchAddressStatement

@rultor merge

@rultor merge

@gilraenburland OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@gilraenburland Done! FYI, the full log is here (took me 4min)


22677 Deleted Benefit Company Statement

Issue #: bcgov/entity#22677
Description of changes:

app version = 4.10.6
replaced @volar-plugins/vetur by volar-service-vetur
deleted obsolete title and description from resource interface
deleted title and description from resource files (8)
deleted title and description from HTML template

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-edit-dev--pr-583-rvsgx801.web.app


Improve unlock behaviour

Unlock button in extension when signing tx first time is hidden, didnt know where to look, maybe point an arrow at it?
When hitting the unlock button (as above) can you guys auto-focus in the field? I kept typing my password elsewhere

whoever's coming up with these is a beast

Done.
Will be included in the next release.
Thank you!


model loading

I received the file Mistral-1.566301941871643-69 at the end of the model's training, and I was wondering if there is a way to convert this save file to model.bin or load it to tpu to see if it works.
Thank you for the support!

I thought my scheduler is linear sorry for the confusing. I was dumb :|

yes you can use JaxServer For that

link to JaxServer Docs

Additionaly I have 2~3 v3-8 tpu vms. Can I use these tpu vms together for bigger model?

yes you can use JaxServer For that

I got error with below code
config = MistralConfig(rotary_type="complex")
model = FlaxMistralForCausalLM(config, _do_init=False)

tokenizer = AutoTokenizer.from_pretrained('mistralai/Mistral-7B-v0.1',model_max_length=4096,padding_side="left",add_eos_token=True)
tokenizer.pad_token = tokenizer.eos_token

server = JAXServer.load(
    path='/root/.cache/huggingface/hub/models--jin05102518--KoMistralTest/snapshots/cca71d6a59a1b1ea81e9eb6096f24fdd93f6d9fe/Mistral-Test',
    model=model,
    tokenizer=tokenizer,
    config_model=config,
    add_params_field=True,
    config=None,
    init_shape=(1, 1)
)

Error:
Traceback (most recent call last):
  File "test.py", line 12, in <module>
    server = JAXServer.load(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/serve/serve_utils.py", line 414, in load
    server.compile(verbose=verbose)
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/serve/serve_utils.py", line 475, in compile
    for r, a in self.process(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/serve/serve_utils.py", line 615, in process
    predicted_token = self.greedy_generate(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/serve/serve_utils.py", line 506, in greedy_generate
    return self._greedy_generate(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/serve/serve_utils.py", line 286, in greedy_generate
    predict = model.generate(
  File "/usr/local/lib/python3.8/dist-packages/transformers/generation/flax_utils.py", line 417, in generate
    return self._greedy_search(
  File "/usr/local/lib/python3.8/dist-packages/transformers/generation/flax_utils.py", line 636, in _greedy_search
    state = greedy_search_body_fn(state)
  File "/usr/local/lib/python3.8/dist-packages/transformers/generation/flax_utils.py", line 612, in greedy_search_body_fn
    model_outputs = model(state.running_token, params=params, **state.model_kwargs)
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/modules/mistral/modelling_mistral_flax.py", line 561, in __call__
    outputs = self.module.apply(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/modules/mistral/modelling_mistral_flax.py", line 784, in __call__
    outputs = self.model(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/modules/mistral/modelling_mistral_flax.py", line 708, in __call__
    outputs = self.layers(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/modules/mistral/modelling_mistral_flax.py", line 638, in __call__
    output = layer(
  File "/usr/local/lib/python3.8/dist-packages/flax/linen/partitioning.py", line 553, in inner
    return rematted(variable_groups, rng_groups, *dyn_args)
  File "/usr/local/lib/python3.8/dist-packages/flax/linen/partitioning.py", line 550, in rematted
    y = fn(scope, *args)
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/modules/mistral/modelling_mistral_flax.py", line 432, in __call__
    attention_output = self.self_attn(
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/modules/mistral/modelling_mistral_flax.py", line 347, in __call__
    q, k, v, attention_mask = self.concatenate_to_cache_(q, k, v, attention_mask)
  File "/usr/local/lib/python3.8/dist-packages/EasyDel/modules/mistral/modelling_mistral_flax.py", line 316, in concatenate_to_cache_
    attention_mask = nn.combine_masks(pad_mask, attention_mask)
  File "/usr/local/lib/python3.8/dist-packages/flax/linen/attention.py", line 506, in combine_masks
    assert all(
AssertionError: masks must have same rank: (4, 2)

Additionally, can you let me know how to convert the flax model into pytorch_model_bin?

use mistral_flax_to_pt in transform functions (I don't know if I said the right name for that func ;\ )
right now mistral models have a computing problem that I'm trying to fix them as soon as I can

Additionally, can you let me know how to convert the flax model into pytorch_model_bin?

use mistral_flax_to_pt in transform functions (I don't know if I said the right name for that func ;\ ) right now mistral models have a computing problem that I'm trying to fix them as soon as I can

By any chance, can you show an example of loading and applying a flax model to use the mistral_flax_to_pt function? I'm having trouble as I'm not familiar with flax... Sorry for the many requests.

Additionally, can you let me know how to convert the flax model into pytorch_model_bin?

use mistral_flax_to_pt in transform functions (I don't know if I said the right name for that func ;\ ) right now mistral models have a computing problem that I'm trying to fix them as soon as I can

By any chance, can you show an example of loading and applying a flax model to use the mistral_flax_to_pt function? I'm having trouble as I'm not familiar with flax... Sorry for the many requests.

use mistral_convert_flax_to_pt
and that's fine you can ask any question that you want

Is this code right to convert ckpt to torch.bin?
 _, flax_params = StreamingCheckpointer.load_trainstate_checkpoint(path)
flax_params = flatten_dict(flax_params['params'], sep='.')
mistral_convert_flax_to_pt(flax_params, MistralConfig())

I'm wondering if it's ok to use MistralConfig as is as a config for mistral_convert_flax_to_pt

yes the code is correct but use the config of the model you want to convert from EasyDel to torch or hf to cause the number of elements like num_hidden_layers or ... to be taken from the given config

Hmm... so I can't just use the mistralconfig class? Also, if I have to use a custom config, I wonder if I can use the one I used for train.

yes
you should use the config that used to train mode (saved in W&B project if you don't remember that)

Also, are there any plans to create a linear scheduler with a warm up step?

Is the only finetune method currently supported is full-fintune?

RLHF is supported too for finetuning models but only for llama1 and falcon and mpt models right now

Also, are there any plans to create a linear scheduler with a warm up step?

ill create that for you in next update on main branch

Also, are there any plans to create a linear scheduler with a warm up step?

I just made a warmup_linear scheduler function
def get_adamw_with_warmup_linear_scheduler(
        steps: int,
        learning_rate_start: float = 5e-5,
        learning_rate_end: float = 1e-5,
        b1: float = 0.9,
        b2: float = 0.999,
        eps: float = 1e-8,
        eps_root: float = 0.0,
        weight_decay: float = 1e-1,
        gradient_accumulation_steps: int = 1,
        mu_dtype: Optional[chex.ArrayDType] = None,

        warmup_steps: int = 500

):
    """

    :param gradient_accumulation_steps:
    :param steps:
    :param learning_rate_start:
    :param learning_rate_end:
    :param b1:
    :param b2:
    :param eps:
    :param eps_root:
    :param weight_decay:
    :param mu_dtype:

     # New parameter for warmup
     @warmup_steps (int): Number of steps for the warmup phase

     # return Optimizer and Scheduler with WarmUp feature
   """

    scheduler_warmup= optax.linear_schedule(init_value=5e-8, end_value=learning_rate_start, transition_steps=warmup_steps)
    scheduler_decay= optax.linear_schedule(init_value=learning_rate_start, end_value=learning_rate_end, transition_steps=steps-warmup_steps)

    scheduler_combined= optax.join_schedules(schedules=[scheduler_warmup, scheduler_decay], boundaries=[warmup_steps])

    tx = optax.chain(
        optax.scale_by_adam(
            b1=b1,
            b2=b2,
            eps=eps,
            eps_root=eps_root,
            mu_dtype=mu_dtype
        ),
        optax.add_decayed_weights(
            weight_decay=weight_decay
        ),
        optax.scale_by_schedule(scheduler_combined),
        optax.scale(-1)
    )
    if gradient_accumulation_steps > 1:
        tx = optax.MultiSteps(
            tx, gradient_accumulation_steps
        )
    return tx, scheduler_combined

thank!
update Fjtuils to 0.0.20 and reinstall EasyDel and you then you can use warm_up_linear