Preserve SelectableText's selection on setState

setState() is called for changing the text style in this example when the mouse pointer enters the region of the decorated TextSpan and when it exits there.  If it occurs while part of SelectableText is already selected, the selection is cancelled unexpectedly.
The yellow circle in the GIF animation means the mouse is being left-clicked.
Steps to Reproduce

Copy and paste the code below to an editor.
Run the app.
Select part of the text and then hover the mouse pointer over the blue text.

import 'package:flutter/material.dart';

void main() => runApp(const App());

class App extends StatelessWidget {
  const App();

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Padding(
          padding: EdgeInsets.all(16.0),
          child: _Text(),
        ),
      ),
    );
  }
}

class _Text extends StatefulWidget {
  const _Text();

  @override
  _TextState createState() => _TextState();
}

class _TextState extends State<_Text> {
  var _isHovered = false;

  @override
  Widget build(BuildContext context) {
    return SelectableText.rich(
      TextSpan(
        children: [
          TextSpan(
            text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, ',
          ),
          TextSpan(
            text: 'sed do eiusmod tempor incididunt',
            onEnter: (_) => setState(() => _isHovered = true),
            onExit: (_) => setState(() => _isHovered = false),
            style: TextStyle(
              color: Colors.blue,
              decoration: _isHovered ? TextDecoration.underline : null,
            ),
          ),
          TextSpan(
            text: ' ut labore et dolore magna aliqua.',
          ),
        ],
      ),
    );
  }
}

Expected results:
Text selection is kept unchanged even if setState() is called.
Actual results:
Text selection is lost every time SelectableText is rebuilt (or redrawn?).

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.1, on Microsoft Windows [Version 10.0.19042.1023], locale ja-JP)
    • Flutter version 2.2.1 at D:\tool\dev\flutter
    • Framework revision 02c026b03c (8 days ago), 2021-05-27 12:24:44 -0700
    • Engine revision 0fdb562ac8
    • Dart version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at D:\tool\dev\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_SDK_ROOT = D:\tool\dev\Android\sdk
    • Java binary at: D:\tool\dev\java\jdk8u292-b10\bin\java
    • Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.4)
    • Visual Studio at D:\tool\dev\Microsoft\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30517.126
    • Windows 10 SDK version 10.0.18362.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] IntelliJ IDEA Ultimate Edition (version 2021.1)
    • IntelliJ at D:\tool\dev\JetBrains\apps\IDEA-U\ch-0\211.6693.111
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code, 64-bit edition (version 1.56.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.1023]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 91.0.4472.77
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 91.0.864.37

! Doctor found issues in 1 category.

Hi @kaboc
This doesn't look like a bug, setState rebuilds the layout, and as a result, the selection is lost.  Please correct me if I am mistaken.

@TehaTesser
If it's not a bug, is there a non-hanky solution to update the text style without losing selection? If not, I think it means there's something that can be improved on Flutter side.

I wanted to make my package compatible with SelectableText in addition to Text because text selection is more important as Flutter is more widely used for web, but it looked impossible, which is why I filed the issue.

You should be able to do this using SelectionArea instead of SelectableText, but let me know if I'm wrong. This looks like a legitimate use case for SelectableText, but given that we are trying to replace that widget with SelectionArea where possible, supporting this hasn't been a priority.

I think I had filed this issue before SelectionArea was introduced. I needed a fix or workaround back then so that SelectableText and text decorations would go well together in one of my packages, but later on, gave up the idea of supporting it and instead recommended the users combine the package with SelectionArea. So it is fine for me that this won't be fixed, given SelectableText will be deprecated, but SelectionArea is still missing some features. Just hoping it becomes better soon.


Open in Browser: the url is wrong when working with non ascii words

The hosts is gitlab and I use OSX.
When I have non ascii words in my directory name, the url is wrong.
需求 means requirement in Chinese.
When I open in git host with 0928.sql in folder 需求0920-2017.
tree -N .
.
└── 需求0920-2017
    └── 0928.sql

1 directory, 1 file

The generated url in browers is 需求0920-2017/0928.sql%23L15
And the right version should be 需求0920-2017/0928.sql#L15.
It seems there is a wrong url encoding converting # to %23.

Also the result of Copy to Clipboard is right: 需求0920-2017/0928.sql#L15
Thanks.

Thanks! This should be fixed in v2.0.1 which has just been released. Let me know if that fixes the issue for you.

@ben-gibson  The bug is fixed, thanks.


Where is the php.ini?

How can i configure apache or nginx? I am a newbie and i am starting to learning php without xampp... someone can help me?

I can't found the php.ini...


xp globe: add a toggle for the orb background

add a config option to disable/enable the orb background color

As mentioned in Discord earlier, we should instead try to fix the missing alpha scrollbar from the color picker.


Architecture and terminology

Architectural changes with respect to stochastic providers and analyzers
More friendly and scientific consistent terminology

Please elaborate on both points. A list with some bulletpoints would be perfect in order to have something at hand.

@GoatOfRafin @odyred
My two cents on the matter, with respect to stochastic elements (I am not an expert on the issue, so the following are merely suggestions up for discussion):
I think that composition fits better than inheritance for elements that are used in optimization or stochasticity. For example, right now there is a class Hexa8WithStochasticMaterial (that inherits from Hexa8) and Hexa8u8pWithStochasticMaterial (that inherits from Hexa8u8p). Instead of having two/three N separate classes, each of which inherits from a non-stochastic element class, we could have a general class pertaining to stochastic analysis, that accepts as input an element of some type (which concrete type is indifferent to us), whose material parameters could be modified.


Support pre-emptive Basic authentication

Closes #636
Add a new builder method which doesn't check the 401-response header and attempts to use basic auth. I also did some cleanup of the return type of the __test_connection() method, since it returns Literal[True] instead of bool.
I thought about the best way to implement this. We could have used an undocumented environment variable, but given that this is an open-source project it seemed wiser to implement this function, but to be very clear in the documentation that it should not be used in almost all cases.
I did think about marking the method as deprecated, but I think we can only really get away with this once Basic is included in the 401-response alongside Bearer from MI.

Re-implemented this for with_autologon and with_credentials, with an enum that allows the authentication method to be chosen with each method. This rapidly gets complicated with different modes supported on different platforms.
Still TODO:

[ ] Fix a failing kerberos test
[ ] Document the Enum
[ ] Perform some manual testing


feat: added markdown support

Now that treesitter supports markdown officially, it is possible to use autotag for HTML tags in Markdown with this PR.

Thank for PR
i check and  rename tag is not working.

Hi which part is not working? It seems to be working for me.
https://user-images.githubusercontent.com/62098008/146425389-29decf7b-445c-4077-8a42-0493aef21ffb.mp4

it is not working on some case. but i can merge it


Add Move cron parser library

Description
Library for parsing cron expression written in Move language

@villesundell Created another PR!

@tin-snowflake Good job, thank you! :+1: Merging this


fix(storage-resize-images): file name extraction

related #130
I'm not sure if it is the expected behavior or not, and if so, please disregard this PR.
Issue
As someone has pointed out in this comment, when a user uploads an image to the storage with a ref name without an extension, resized image's name gets to be trimmed like _200x200.
Below is a sample code that reproduces this.
const storageRef = firebase.storage().ref('RANDOM_PATH')
const folderRef = storageRef.child('my_beautiful_cat')
await folderRef.put(e.target.files[0]) // got this from File API

Root Cause
It seems like the problem is happening where it extracts the file name without extension.
The current implementation is based on the premise that the ref would always have an extension, in other words, fileExtension.length is never 0. But, as it is not a restriction that firebase SDK enforces, when the file ref does not contain an extension, it should simply use the ref name, I guess.
Fix
Node.js's path.basename can extract filename without extension.
reference: https://nodejs.org/docs/latest-v8.x/api/path.html#path_path_basename_path_ext

#135

Currently, if a user uploads an image called image.jpg, it would get resized to say image_200x200.jpg, as expected.
With this change, although it would correctly handle images without an extension, wouldn't it always output an image with no extension name, which is different than the current implementation? For example:
image.jpg -> image_200x200.jpg
vs
image.jpg -> image_200x200
My thinking is if the user uploads an image with an extension, we should persist it when resizing, if not we don't add it. What do you think?

Also I think issue #130 is unrelated to this.

Hi @Ehesp , thank you for your review.
My thinking is if the user uploads an image with an extension, we should persist it when resizing, if not we don't add it.
I completely agree with you, and I believe this PR does abide by that!
As far as I understand, fileNameWithoutExtension, which literally refers to the file name without an extension,  is passed on to the resizeImage function along with fileExtension.
https://github.com/firebase/extensions/blob/947d533eb4531dc311b10f8a94e1c60fde9e12cc/storage-resize-images/functions/src/index.ts#L92-L105
The resizeImage function then reconstructs the output file name like below,
https://github.com/firebase/extensions/blob/947d533eb4531dc311b10f8a94e1c60fde9e12cc/storage-resize-images/functions/src/index.ts#L158
So, when the image does not have a file extension, in other words fileExtension is '',  resizedFileName does not have a file extension but the original file name with size suffix, and when the image does have a file extension, it preserves the file extension.
I haven't written unit tests for above since it kind of exceeds the scope of this topic, but if it's desirable, I guess I can provide one.
Btw, are there anyways I can actually use my local version of this extension with an actual Firebase project? I couldn't find a way to confirm that everything works in harmony 🤔

Also, my apologies for mentioning an unrelated issue! Edited the description.

Ah yes you are correct, thanks for explaining. I also didn't realise that a .slice with a -0 value totally removes the string ("foo".slice(0, -0) = "").
Let me give it a go and I'll get back to you.

Tested this out and it's working:

Funnily enough, I added an image through gsutil & then realised I hit issue #130. So although this works, https://github.com/firebase/extensions/pull/142 needs merging too :)


CSS Error > Unexpected token . [react-flexbox-grid & next-css]

When I use react-flexbox-grid, This error shows up. This is my nextjs config
const withCSS = require('@zeit/next-css')
const withBundleAnalyzer = require('@zeit/next-bundle-analyzer')
module.exports = withCSS(
  withBundleAnalyzer({
    analyzeServer: ['server', 'both'].includes(process.env.BUNDLE_ANALYZE),
    analyzeBrowser: ['browser', 'both'].includes(process.env.BUNDLE_ANALYZE),
    bundleAnalyzerConfig: {
      server: {
        analyzerMode: 'static',
        reportFilename: '../bundles/server.html'
      },
      browser: {
        analyzerMode: 'static',
        reportFilename: '../bundles/client.html'
      }
    }
  })
)

Ref: https://github.com/zeit/next-plugins/issues/145
I see the fixed commit but still not working

Step to reproduce

Clone my repo: https://github.com/iammarkps/openhouse
yarn install
yarn dev

same problem

I had a similar issue and solved it by generating a postcss config file in the 👍

Hi, thanks for creating an issue. We currently recommend using https://nextjs.org/docs/basic-features/built-in-css-support as the plugins have been deprecated in favor of the built-in support.


Textarea value is not available to innerHtml/outerHtml

I think that the Textarea value attribute is does not work as expected. In a browser setting, the textarea value (eg content of the textarea) can be read and set using the value attribute which also makes it available as part of the document content, but in AngleSharp (0.9.1) it will not be available in the document content.
This test illustrates the issue:
[Test]
        public void CanPopulateTextareaRaw()
        {
            var htmlDoc = new HtmlParser().Parse("<textarea id='txt1' name='textarea1'></textarea>");
            var txtArea = (IHtmlTextAreaElement)htmlDoc.GetElementById("txt1");
            txtArea.Value = "textarea1value";
            Assert.AreEqual("textarea1value", txtArea.Value); //value is set ok

            var text = htmlDoc.DocumentElement.InnerHtml;
            Assert.That(text.Contains("textarea1value"), "textarea not populated");
        }

Setting the value using TextContent works fine, but I believe setting value should have the same effect.
Btw, AngleSharp is a great library, thanks!

Thanks for reporting this issue. I will investigate this.
Here's a MWE to reproduce this behavior in the browser.
<!DOCTYPE html>
<html>
<body>
<textarea>Test</textarea>
<script>
var t = document.querySelector('textarea');
console.log('before', t.outerHTML);
t.value = 'Foo bar';
console.log('after', t.outerHTML);
</script>
</body>
</html>

What I see is the following:

I guess this is the behavior of AngleSharp at the moment. Am I doing something wrong here? Does the presented MWE align with your report or did I miss something?

You're right, I'm wrong. Sorry about that. So setting TextContent is actually the right way to do it (for my scenario).
The one thing that threw me off is this though: After setting TextContent, Value will equal TextContent, which I also thought was inconsistent, but after browser testing it turns out that the same behavior applies there.
This is obviously the desired behavior :)
<!DOCTYPE html>
<html>
<body>
<textarea>Initial</textarea>
<script>
var t = document.querySelector('textarea');
console.log('does setting textContent affect value?');
console.log('value before:', t.value);
t.textContent = 'Foo bar';
console.log('value after:', t.value)

console.log('does setting value affect textcontent?');
console.log('textContent before:', t.textContent);
t.value = 'Finally';
console.log('textContent after:', t.textContent)

</script>
</body>
</html>´´´

Glad to hear that! But keep posting such potential issues, the spec. is vast and implementation mistakes can happen.


Environment issues

I get this following error running inference on OTB sequences dataset.
Couldn't load custom C++ ops. This can happen if your PyTorch and torchvision versions are incompatible, or if you had errors while compiling torchvision from source. For further information on the compatible versions, check https://github.com/pytorch/vision#installation for the compatibility matrix. Please check your PyTorch version with torch.__version__ and your torchvision version with torchvision.__version__ and verify if they are compatible, and if not please reinstall torchvision so that it matches your PyTorch install. Traceback (most recent call last):   File "tracking/../lib/test/evaluation/running.py", line 138, in run_sequence     output = tracker.run_sequence(seq, debug=debug)   File "tracking/../lib/test/evaluation/tracker.py", line 88, in run_sequence     output = self._track_sequence(tracker, seq, init_info)   File "tracking/../lib/test/evaluation/tracker.py", line 143, in _track_sequence     out = tracker.track(image, info)   File "tracking/../lib/test/tracker/jointnlt.py", line 130, in track     out_dict = self.network.forward_test(self.text_dict, self.template_dict, search_patch, temporal)   File "tracking/../lib/models/JointNLT.py", line 196, in forward_test     return self.forward_joint(text_src, text_mask, template_src, template_mask, search_src, search_mask, temporal)   File "tracking/../lib/models/JointNLT.py", line 168, in forward_joint     roi_feature = self.get_target_feature(search_tokens, pred_boxes)   File "tracking/../lib/models/JointNLT.py", line 210, in get_target_feature     target_roi_feature = self.roi(opt_feat, boxes)   File "/anaconda/envs/joint/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl     return forward_call(*input, **kwargs)   File "/anaconda/envs/joint/lib/python3.7/site-packages/torchvision/ops/roi_align.py", line 86, in forward     return roi_align(input, rois, self.output_size, self.spatial_scale, self.sampling_ratio, self.aligned)   File "/anaconda/envs/joint/lib/python3.7/site-packages/torchvision/ops/roi_align.py", line 55, in roi_align     _assert_has_ops()   File "/anaconda/envs/joint/lib/python3.7/site-packages/torchvision/extension.py", line 34, in _assert_has_ops     "Couldn't load custom C++ ops. This can happen if your PyTorch and " RuntimeError: Couldn't load custom C++ ops. This can happen if your PyTorch and torchvision versions are incompatible, or if you had errors while compiling torchvision from source. For further information on the compatible versions, check https://github.com/pytorch/vision#installation for the compatibility matrix. Please check your PyTorch version with torch.__version__ and your torchvision version with torchvision.__version__ and verify if they are compatible, and if not please reinstall torchvision so that it matches your PyTorch install.
I prepared a conda env with joint.yml.
It had two issues, so I had to change their versions manually.
external=2.0 version doesn't exist.
clip=1.0

I apologize for the delay in responding. It appears that you encountered an issue when calling 'roi_align'. This may be due to a compatibility issue between PyTorch and torchvision. To resolve this, you will need to reinstall torchvision to ensure that it matches your PyTorch installation.

Thank you! I have resolved it by using this wheel
pip install torchvision-0.12.0+cu113-cp37-cp37m-linux_x86_64.whl


Branch 155393864

Jenkins, test this please.

@tensorflow-jenkins test this please

The "Linux CPU Test" failed due to the following reason:
ERROR: /workspace/bazel_pip/tensorflow/contrib/util/BUILD:65:1: Target '//tensorflow/python:framework' is not visible from target '//bazel_pip/tensorflow/contrib/util:util_py'. Check the visibility declaration of the former target if you think the dependency is legitimate.
ERROR: /workspace/bazel_pip/tensorflow/contrib/util/BUILD:65:1: Target '//tensorflow/python:platform' is not visible from target '//bazel_pip/tensorflow/contrib/util:util_py'. Check the visibility declaration of the former target if you think the dependency is legitimate.
ERROR: /workspace/bazel_pip/tensorflow/contrib/util/BUILD:65:1: Target '//tensorflow/python:util' is not visible from target '//bazel_pip/tensorflow/contrib/util:util_py'. Check the visibility declaration of the former target if you think the dependency is legitimate.

Is this related to this commit, @ringw ? https://github.com/tensorflow/tensorflow/pull/9874/commits/733bff53926717bb9583d4833ba062c58f27960futil

Yes that must be the culprit--weird that our open source presubmits passed. Rolling back.


Is the rust-toolchain.toml file necessary?

Problem
I get a lot of proc macro not expanded errors from rust-analyzer in my editor when working in ibc-rs. This turns out to be because the repo's rust-toolchain.toml file overrides the toolchain I'm using when I'm in the repo to 1.63-aarch64-apple-darwin. In every other context, my toolchain defaults to x86_64-apple-darwin such that I don't get any errors regarding proc macros not being expanded.
I suppose there are a couple of ways this could be addressed:

Figure out how to configure the rust-toolchain.toml file such that it sets the version of Rust to 1.63-x86_64-apple-darwin when I'm in the ibc-rs repo.
Remove the file entirely. I don't know whether this is a good idea or not, i.e. would issues arise as a result of everyone possibly developing using different versions of Rust?

As it stands, I have to delete the file and rebuild the project every time it gets pulled in again from GitHub. Adding the file to the repo's .gitignore doesn't seem to make sense; at that point I suspect we might as well remove it entirely.
Acceptance Criteria

[ ] Figure out the most acceptable way to address this problem.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

I think this can help in your particular issue:
USAGE:
    rustup set default-host <host_triple>

Besides that, I don't know if there is a benefit in fixing the toolchain override.
The MSRV is maintained through Cargo.toml and clippy.toml.

Yeah let's remove it then


Add support for pass-by-ref parameters

Compiles to out / inout in HLSL and GLSL, and & in MetalSL. I haven't run the tests on a Mac - I really should set myself up to be able to do that.
(On a related note, it would be really cool to run the HLSL and GLSL tests on AppVeyor, and the Metal tests on a Mac agent on Travis.)
I don't know how you feel about adding in to all pass-by-value parameters in HLSL and GLSL - we obviously don't need to do that.

This looks good to me. I'm always amused at how well and directly C# semantics translate to shading languages.

I don't know how you feel about adding in to all pass-by-value parameters in HLSL and GLSL - we obviously don't need to do that.

I think we can remove it. The code should work fine if you just return string.Empty from those places instead.

Done (finally).

@tgjones Looks good, and everything's passing. Thanks for the great addition!


enhancement replace map with vector for segment handle caches

Proposed changes
Issue Number: close #xxx

Searching in the map incurs significant CPU overhead，replace map with vector for segment handle caches.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


add create_conda_env

Codecov Report
Attention: Patch coverage is 5.88235% with 64 lines in your changes missing coverage. Please review.

Project coverage is 64.35%. Comparing base (4fec22e) to head (7590fe3).

Files with missing lines
Patch %
Lines

src/aiida_pythonjob/utils.py
5.88%
64 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   72.26%   64.35%   -7.91%
==========================================
  Files          14       14
  Lines         512      578      +66
==========================================
+ Hits          370      372       +2
- Misses        142      206      +64

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add sqs service marketplace metadata

What
adds the service icon for the upcoming SQS service alpha so it looks nice when it appears in pazmin marketplace listings for orgs where it is enabled.
How to review
Is that the right icon?
Who can review
Not @chrisfarms

any links to docs, etc?

any links to docs, etc?

GOV.UK PaaS docs are pending ... this service is initially not exposed to all tenants while we preview it privately
Links to AWS SQS service docs are passed through from the service plan data exposed by the marketplace/api, so should automagically appear once the service appears.

👍


chore: update gosnowflake dependency to 1.10.1

closes #1777

Hi, Any ETA for merge this PR, we received some customer reported issue regarding this issue.
CC: @davidhcoe


create basic flow of going from flippers to boxes and back

use this for setting coords: https://stackoverflow.com/questions/6802956/how-to-position-a-div-in-a-specific-coordinates


Module naming conventions

I guess, we should determine a naming convention for module names to avoid cases like https://github.com/rhodricusack/automaticanalysis/issues/83.
I suggest:
aamod_'modality'_'task'[_'stream']

I have mixed feelings about this, because when a module has a number of
wrappers that act on different data, like
aamod_norm_write_{meanepi | cons | spmt | nodif ...}
or the many
aamod_bet_*
It seems elegant (and more memorable) to keep the connection to the
underlying module.
So my vote would be to follow Tibor's proposal, except where there are many
.xmls pointing to a single .m, where the root of the xml should be the m
filename
On Apr 14, 2015 6:16 AM, "Tibor Auer"<EMAIL_ADDRESS>wrote:

I guess, we should determine a naming convention for module names to avoid
cases like #83
https://github.com/rhodricusack/automaticanalysis/issues/83.
I suggest:
aamod_'modality''task'['stream']
—
Reply to this email directly or view it on GitHub
https://github.com/rhodricusack/automaticanalysis/issues/84.

Now, there is also an option to change the name of the input/outputstreams on-demand, so those many .xmls differing only in data they process may not be needed any more.

As a step towards solving this issue, I am planning to rename a few modules according to the following rules:

Modality labels and stream names should be all lowercase.
Stream names at the end of the module name should be prefixed with an "_".
Task/approach (e.g. ANOVA, ANTS, GIFT, fieldmap2VDM) can still be with uppercase.

These module (and other similars) will be affected:

aamod_bet_meanEPI -> aamod_bet_meanepi
aamod_coreg_extended_2meanepi -> aamod_coreg_extended_2_meanepi
aamod_diffusion_coreg_extended_2DKI -> aamod_diffusion_coreg_extended_2_dki
aamod_MTI_coreg_extended_2 -> aamod_mti_coreg_extended_2
aamod_tSNR_EPI -> aamod_tSNR_epi

Hi Tibor,
Don't know if you want more to do, but here's a few other inconsistencies I've noticed:

is "epi" plural (e.g., aamod_convert_epis.xml) or singular (e.g., aamod_bet_epi_masking.m)?
shouldn't bet be uppercase? (e.g., aamod_BET_meanepi)
some FSL functionality is prefaced with fsl (e.g., aamod_fsl_FAST.m) and some not (aamod_melodic.m)
also, shouldn't "fsl" be uppercase?

Mike

I am about to submit another PR refining the MEEG, updating the PPI (making it working), adding The Decoding Toolbox (great stuff!), and updating the EEGLAB interface to the new EEGLAB release. Plus some minor changes. :)
Then I jump on the module names. :)

#221


DeprecationWarning from jax.core.pp_eqn_rules with jax version 0.4.30 when using latest version of interpax

In a code which uses interpax as a dependency for interpolation, we find a Deprecation warning is being emitted:
Warning Traceback:
tests/conftest.py:12: in <module>
    from desc.coils import (
desc/coils.py:10: in <module>
    from desc.compute import get_params, rpz2xyz, rpz2xyz_vec, xyz2rpz, xyz2rpz_vec
desc/compute/__init__.py:31: in <module>
    from . import (
desc/compute/_curve.py:1: in <module>
    from interpax import interp1d
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/interpax/__init__.py:6: in <module>
    from ._ppoly import (
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/interpax/_ppoly.py:41: in <module>
    import equinox as eqx
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/equinox/__init__.py:3: in <module>
    from . import debug as debug, internal as internal, nn as nn
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/equinox/internal/__init__.py:46: in <module>
    from ._finalise_jaxpr import (
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/equinox/internal/_finalise_jaxpr.py:186: in <module>
    from ._noinline import noinline_p
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/equinox/internal/_noinline.py:3[79](https://github.com/PlasmaControl/DESC/actions/runs/9568396025/job/26378504793?pr=1058#step:7:80): in <module>
    jax.core.pp_eqn_rules[noinline_p] = _noinline_pretty_print
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/jax/_src/deprecations.py:53: in getattr
    warnings.warn(message, DeprecationWarning, stacklevel=2)
E   DeprecationWarning: jax.core.pp_eqn_rules is deprecated.

This is an upstream issue with equinox and should be fixed in their next release: https://github.com/patrick-kidger/equinox/pull/767


Correction for raw affiliation Laboratory of Biology and Modeling of the Cell, CNRS UMR 5239, INSERM U1210, University of Lyon, Lyon, France

Correction needed for raw affiliation Laboratory of Biology and Modeling of the Cell, CNRS UMR 5239, INSERM U1210, University of Lyon, Lyon, France
raw_affiliation_name: Laboratory of Biology and Modeling of the Cell, CNRS UMR 5239, INSERM U1210, University of Lyon, Lyon, France
new_rors: 029brtt94;02vjkv261;02feahw73;01bj4fd12
previous_rors: 029brtt94;02vjkv261;02feahw73
works_examples: W3125730687
contact: 3c84f2dcb7ec1db3279a47e34e11c6f6:efe33a4a0c95fe85ff2dc5ad009e @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-21. The new affiliations should be visible within the next 7 days.


Add website icons?

Hey thanks for the extension, looking really good!
I feel like adding the site icon (maybe as an option) would help a lot to see at a glance the source of a search result.
Basically, I consider more relevant a reddit icon at the left than the whole reddit url (I would keep it to see the matching substring etc).
Is it for a technical reason? I just like bookmarks with icons :)

Another comment (I didnt want to open multiple issues, but feel free to do so). Could the wheel click open tabs in the background directly without having to ctrl+click? It would be consistent with the rest of chrome.

Cheers

Hi Dimateos,
thanks!
Yes, I see your point and it would be a good addition to the extension.
First I didn't add it because I did not want the extension to do any outside requests and keep it very minimalistic and fast. I would like to avoid that opening the search bar results in dozens of HTTP requests.  But maybe those icons are already somewhere available in a cached form? At least it's worth a try, when I have some time to look into it.

Great!
I dont know much about web/chrome, maybe the url site/favicon is already cached and it is just solved instantly. It could also be an option unset by default if it worries you.
Anyway thanks for looking into it whenever you have time!

@dimateos : I've played around with this a little, but unfortunately there are quite a few challenges to make this work nicely.
First, I  can't add a new permission 'favicon' without having the extension be disabled for all users after the update. I can make it an optional permission, but then I need to implement logic to ask for permission on demand (which would be a fair approach, though).
For tabs, I got it working, but for bookmarks and history it's a bit weird. Haven't found any official API documentation for this. Generally, if this extension is to work for all browsers, I'm not sure how well (and similar) the favicon feature would work across those.
This is how it could look like:

I'll keep this feature in mind, as it would be very nice. But unfortunately, to get this done properly I would need to invest more time.

I'm expecting the icon feature, too! Thank you!

I'm expecting the icon feature, too! Thank you!

Yeah, it would be really nice. Would like to have it myself :)
But it looks like it might take some more time for the major browser makers to support this stable with the new Manifest v3 standard.
But other people are also asking for it. Seems like API documentation is completely missing. I could also just try around with examples, which were also not always in sync with each other. Confusing situation.
https://stackoverflow.com/questions/65846725/i-cant-find-any-documentation-for-chrome-favicon-api

I'm expecting the icon feature, too! Thank you!

Yeah, it would be really nice. Would like to have it myself :)
But it looks like it might take some more time for the major browser makers to support this stable with the new Manifest v3 standard.
But other people are also asking for it. Seems like API documentation is completely missing. I could also just try around with examples, which were also not always in sync with each other. Confusing situation.
https://stackoverflow.com/questions/65846725/i-cant-find-any-documentation-for-chrome-favicon-api

I wonder if you could get some insights from this similar extension, github page. I used this ext before switching to yours, it's super fast and good to use, too.

I often have a project that uses a gdoc for the summary, and gsheet for the data. I name them almost identically. This feature would really help clarify which match is the gdoc and which one is the gsheet.

I'll keep this feature in mind, as it would be very nice. But unfortunately, to get this done properly I would need to invest more time.
I would love to code to contribute my I also lack the time. I've seen other open source projects successfully attract talent with time available through bounties or tipjars. I'm not sure if this is something you're willing to consider.

Cheers!


Update setup-deploy-on-premises-latest.md

I just deleted "SSRS" line 458 because it doesn't have to be installed on the SQL server ? a customer was a bit confused reading this !

:white_check_mark: Organization membership check passed
Requester is not a member of the MicrosoftDocs organization.


Illegal instruction start.sh

Describe the bug
When attempting to start a new node I receive the following error.
To Reproduce
symbol-bootstrap start -p mainnet -a peer

This is the error output.
Attaching to node
node    | RUNNING server NORMAL node
node    | !!!! Starting server....
node    | /symbol-commands/start.sh: line 126:    10 Illegal instruction     (core dumped) $catapultAppFolder/bin/$processName "$config"

Expected behavior
Node starts and syncs
Illegal instruction makes me think the source is compiled for never CPUs only.
Desktop (please complete the following information):
Ubuntu 18.04
CPU supports x86-64-v2

@dekm Can you provide more information on your CPU?
Currently, the server image requires skylake (2015) SSE4.2, AVX2

@dekm Can you provide more information on your CPU?
Currently, the server image requires skylake (2015) SSE4.2, AVX2

It's a dual Intel(R) Xeon(R) CPU           X5670  @ 2.93GHz server
  [Created at cpu.465]
  Unique ID: Jk7M.j8NaKXDZtZ6
  Hardware Class: cpu
  Arch: X86-64
  Vendor: "GenuineIntel"
  Model: 6.44.2 "Intel(R) Xeon(R) CPU           X5670  @ 2.93GHz"
  Features: fpu,vme,de,pse,tsc,msr,pae,mce,cx8,apic,sep,mtrr,pge,mca,cmov,pat,pse36,clflush,dts,acpi,mmx,fxsr,sse,sse2,ht,tm,pbe,syscall,nx,pdpe1gb,rdtscp,lm,constant_tsc,arch_perfmon,pebs,bts,rep_good,nopl,xtopology,nonstop_tsc,cpuid,aperfmperf,pni,pclmulqdq,dtes64,monitor,ds_cpl,vmx,smx,est,tm2,ssse3,cx16,xtpr,pdcm,pcid,dca,sse4_1,sse4_2,popcnt,aes,lahf_lm,pti,ssbd,ibrs,ibpb,stibp,tpr_shadow,vnmi,flexpriority,ept,vpid,dtherm,ida,arat,flush_l1d
  Clock: 1600 MHz
  BogoMips: 4800.52
  Cache: 12288 kb
  Units/Processor: 32
  Config Status: cfg=new, avail=yes, need=no, active=unknown

This seems to an older processor which is currently not supported with our current build.
https://ark.intel.com/content/www/us/en/ark/products/47920/intel-xeon-processor-x5670-12m-cache-2-93-ghz-6-40-gt-s-intel-qpi.html

@dekm Officially, we don't support westmere architecture (it's too old), but if you really want there is an image that you might want to use:
docker pull symbolplatform/symbol-server:gcc-<IP_ADDRESS>-westmere
docker pull symbolplatform/symbol-server:tools-gcc-<IP_ADDRESS>-westmere

@dekm ,  I haven't tried those images, but if you want to use them you need to add this to your custom preset:
symbolServerToolsImage: symbolplatform/symbol-server:tools-gcc-<IP_ADDRESS>-westmere
symbolServerImage: symbolplatform/symbol-server:gcc-<IP_ADDRESS>-westmere

I'm closing this issue, let us know if you need further assistance


Implement EthereumEip712Signature2021

Implement Ethereum EIP712 Signature 2021.
The Ethereum EIP712 Signature Suite specification is a work item proposal in W3C CCG: https://github.com/w3c-ccg/community/issues/194
This signature suite is like ssi's Eip712Method2021 and EthereumPersonalSignature2021, but uses EIP-712 structured data as a data model rather than RDF.
A proof option is added, "eip712Domain", for the corresponding proof property from the specification. This is not ideal because it's a breaking change and not standard in vc-http-api, but I don't know how else to pass this information currently. The eip712Domain object contains the EIP712 type definitions (messageSchema) as a dereferencable URI or object, domain object, and primaryType string. These three values are meta-data which are combined with the document and proof to create the signing input. After signing, the eip712Domain object is placed into the proof object along with the signature (proofValue).
Remote loading of type definitions is not implemented currently but some may be bundled in ssi. Using the object form of messageSchema may therefore be preferred. However, if a document using EthereumEip712Signature2021 with such form is embedded in another one, e.g. a verifiable presentation, the complexity of the types is increased, since a type definition is needed for the type definitions in the embedded message.
A JSON-LD context file is added. Even though this signature suite does not use JSON-LD and the term definitions in the context do not affect signing input, the context file is intended to assist embedding verifiable credentials using this format in verifiable presentations using linked-data-based signature suites. This context file is not from the specification, however.
This signature suite maps currently does not allow arrays of values of different types, so putting objects alongside URIs in @context will not work.
I was not able to verify the signature from the specification's test vector example 5 (non-normative); more information may be needed to verify it.

[x] Add initial scaffolding for signature suite.
[x] Draft JSON-LD context.
[x] Implement JSON conversion for LinkedDataDocument.
[x] Support remote and/or bundled loading of type definitions.
[x] Construct TypedData from LinkedDataDocument, proof, and type definitions.
[ ] Verify test vector from specification.
[x] Add test vector for verifiable credential.
[x] Disallow properties not in types

Screenshot

Please rebase and fix conflicts. Thanks!

Rebased and squashed


CI for Node

✕ Contains the compiled JavaScript (9 ms)
Game
Game
✕ Initializes with two players (3 ms)
✓ Initializes with an empty board
✕ Starts the game with a random player (1 ms)
turn
✓ Inserts an 'X' into the top center
✓ Inserts an 'X' into the top left
nextPlayer
✕ Sets the current player to be whoever it is not (1 ms)


feat: Robot constructor to take an object of properties

Previously, Robot took positional arguments. This is fine for internal
use, but when programatically building, it looks weird because you have
a bunch of null and boolean values which don't make sense on their own.
It is bad for the reasons having multiple positional arguments is bad,
lack of readability.
Instead of positional arguments, this updates Robot to take an options
object, so the parameters are named and it is clear to a reader what
each does.
This continues to support the old positional arguments, but emits a
deprecation message with depd. Internal use of has been updated to use
the options object, and there probably aren't a ton of uses of Robot
directly in the wild (although there is definitely at least
hubot-test-helper). This support can be considered for removal during
the next breaking release.
This is part of https://github.com/hubotio/evolution/pull/3

package.json
src/robot.js

package.json
src/robot.js

package.json

programaticly-configured-hubot-js


fix pending update state clean when discarding Update

--When application trigger DiscardUpdate with WEAVE_NO_ERROR, pending
set state needs to be reset.

Nit: minor changes to commit message:

whitespace after the two leading dashes, and before When
replace trigger with triggers

the result should read
-- When application triggers `DiscardUpdate` with `WEAVE_NO_ERROR`, reset pending set state.

Done, thanks

Codecov Report

Merging #405 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   54.44%   54.44%   +<.01%
==========================================
  Files         342      342
  Lines       58463    58464       +1
==========================================
+ Hits        31830    31832       +2
+ Misses      26633    26632       -1

Impacted Files
Coverage Δ

...les/data-management/Current/SubscriptionClient.cpp
7.51% <0%> (-0.01%)
:arrow_down:

src/lib/profiles/security/WeaveCert.cpp
88.96% <0%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c933cd...d7dfb79. Read the comment docs.


Fix flaky SegRep test testScrollCreatedOnReplica

Description
This change fixes flakiness with segrep test for scroll requests.  The flakiness was with an assertion that all segments snapshotted by the scroll were deleted from disk after the scroll was cleared.  The failures were caused because the snapshotted segments were still referenced by the latest on-disk commit point that is always preserved.
The test was doing a lot of crazy random merges/deletes etc that made it difficult to follow why those files were sneaking in as part of the latest commit.
To make this easier to reason about I've simplified the test flow to:

Index 1 doc
Create the scroll
Index a few more docs
Refresh to create segments
Copy out segments
force merge to 1 segment
Copy out post force merge
Assert segments still exist on-disk
Clear scroll & assert segments are cleared

I've run this ~6k times without failure.
This PR also contains a bug fix to ReplicaFileDeleter to take a Consumer instead of a BiConsumer<String, String>.  We use Store::deleteQuiet to purge files from disk which accepts a varargs of file names and does not have a reason parameter.  This ensures we aren't passing the literal "delete unreferenced" as a file to be deleted.  This would get passed to deleteQuiet and a NoSuchFileException would get swallowed.
Related Issues
Resolves #10769
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Grr, hit a failure here locally after about ~1k more iterations for the remote store version of this test where segments are still part of the latest local commit on the replica.  I see this error in logs but i'm not sure its related... debugging:
[2024-01-30T01:03:06,153][ERROR][o.o.i.s.RemoteStoreRefreshListener] [node_t2] [test-idx-1][0] Exception in RemoteStoreRefreshListener.afterRefresh()
java.lang.AssertionError: already started
	at org.opensearch.indices.replication.common.ReplicationTimer.start(ReplicationTimer.java:51) ~[classes/:?]
	at org.opensearch.index.seqno.ReplicationTracker.lambda$startReplicationLagTimers$22(ReplicationTracker.java:1285) ~[classes/:?]
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) ~[?:?]
	at java.base/java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1850) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:?]
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) ~[?:?]
	at org.opensearch.index.seqno.ReplicationTracker.startReplicationLagTimers(ReplicationTracker.java:1277) ~[classes/:?]
	at org.opensearch.index.shard.IndexShard.onCheckpointPublished(IndexShard.java:1936) ~[classes/:?]
	at org.opensearch.indices.replication.checkpoint.SegmentReplicationCheckpointPublisher.publish(SegmentReplicationCheckpointPublisher.java:39) ~[classes/:?]
	at org.opensearch.index.shard.RemoteStoreRefreshListener.onSuccessfulSegmentsSync(RemoteStoreRefreshListener.java:309) ~[classes/:?]
	at org.opensearch.index.shard.RemoteStoreRefreshListener$1.onResponse(RemoteStoreRefreshListener.java:229) ~[classes/:?]
	at org.opensearch.index.shard.RemoteStoreRefreshListener$1.onResponse(RemoteStoreRefreshListener.java:220) ~[classes/:?]
	at org.opensearch.action.LatchedActionListener.onResponse(LatchedActionListener.java:58) ~[classes/:?]
	at org.opensearch.index.shard.RemoteStoreRefreshListener.uploadNewSegments(RemoteStoreRefreshListener.java:378) ~[classes/:?]
	at org.opensearch.index.shard.RemoteStoreRefreshListener.syncSegments(RemoteStoreRefreshListener.java:254) [classes/:?]
	at org.opensearch.index.shard.RemoteStoreRefreshListener.performAfterRefreshWithPermit(RemoteStoreRefreshListener.java:152) [classes/:?]
	at org.opensearch.index.shard.ReleasableRetryableRefreshListener.runAfterRefreshWithPermit(ReleasableRetryableRefreshListener.java:160) [classes/:?]
	at org.opensearch.index.shard.ReleasableRetryableRefreshListener.afterRefresh(ReleasableRetryableRefreshListener.java:66) [classes/:?]
	at org.apache.lucene.search.ReferenceManager.notifyRefreshListenersRefreshed(ReferenceManager.java:275) [lucene-core-9.9.2.jar:9.9.2 a2939784c4ca60bc28bf488b5479c02fc2e5e22c - 2024-01-25 09:51:09]
	at org.apache.lucene.search.ReferenceManager.doMaybeRefresh(ReferenceManager.java:182) [lucene-core-9.9.2.jar:9.9.2 a2939784c4ca60bc28bf488b5479c02fc2e5e22c - 2024-01-25 09:51:09]
	at org.apache.lucene.search.ReferenceManager.maybeRefreshBlocking(ReferenceManager.java:240) [lucene-core-9.9.2.jar:9.9.2 a2939784c4ca60bc28bf488b5479c02fc2e5e22c - 2024-01-25 09:51:09]
	at org.opensearch.index.engine.InternalEngine.refresh(InternalEngine.java:1771) [classes/:?]
	at org.opensearch.index.engine.InternalEngine.flush(InternalEngine.java:1886) [classes/:?]
	at org.opensearch.index.engine.InternalEngine.forceMerge(InternalEngine.java:2025) [classes/:?]
	at org.opensearch.index.shard.IndexShard.forceMerge(IndexShard.java:1521) [classes/:?]
	at org.opensearch.action.admin.indices.forcemerge.TransportForceMergeAction.shardOperation(TransportForceMergeAction.java:113) [classes/:?]
	at org.opensearch.action.admin.indices.forcemerge.TransportForceMergeAction.shardOperation(TransportForceMergeAction.java:60) [classes/:?]
	at org.opensearch.action.support.broadcast.node.TransportBroadcastByNodeAction$BroadcastByNodeTransportRequestHandler.onShardOperation(TransportBroadcastByNodeAction.java:495) [classes/:?]
	at org.opensearch.action.support.broadcast.node.TransportBroadcastByNodeAction$BroadcastByNodeTransportRequestHandler.messageReceived(TransportBroadcastByNodeAction.java:469) [classes/:?]
	at org.opensearch.action.support.broadcast.node.TransportBroadcastByNodeAction$BroadcastByNodeTransportRequestHandler.messageReceived(TransportBroadcastByNodeAction.java:456) [classes/:?]
	at org.opensearch.transport.RequestHandlerRegistry.processMessageReceived(RequestHandlerRegistry.java:106) [classes/:?]
	at org.opensearch.transport.InboundHandler$RequestHandler.doRun(InboundHandler.java:480) [classes/:?]
	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:913) [classes/:?]
	at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52) [classes/:?]
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
	at java.base/java.lang.Thread.run(Thread.java:840) [?:?]

Don't think that trace is the cause here.  The issue is the replica is not making a new local commit after receiving the new segments.  I think this may be that we need a force flush.  Going to leave this running overnight to confirm.

Ok the issue here is the refresh upon force merge is refreshing on the newly created segments but the reader is not refreshing on the latest commit gen.
With some added logs in InternalEngine ---
[2024-01-30T16:16:19,237][INFO ][o.o.i.e.Engine           ] [node_t2] [test-idx-1][0] After refresh Segments gen: 4 Segments version: 23 Files: [_5.kdm, _5.fdt, _5_Lucene90_0.dvm, _5_Lucene99_0.tmd, _5.kdi, _5.fdm, _5.kdd, _5.fnm, _5_Lucene90_0.dvd, _5_Lucene99_0.tip, _5_Lucene99_0.tim, _5_Lucene99_0.doc, _5.si, _5.fdx]

Segment 5 is our newly force merge'd down to 1 segment, but commit gen is still 4.  A competing refresh is running after the new segments are created but the flush has not finished. The replica will see commit gen is not yet updated so it has no reason to commit locally.
The fix here is to disable scheduled the scheduled refresh.  We can also repro this more consistently by reducing refresh interval to 1ms.

❌ Gradle check result for d5002a2:
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

https://github.com/opensearch-project/OpenSearch/issues/9191
https://github.com/opensearch-project/OpenSearch/issues/10755

❕ Gradle check result for d5002a2: UNSTABLE

TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

https://github.com/opensearch-project/OpenSearch/issues/10755
https://github.com/opensearch-project/OpenSearch/issues/9191

❌ Gradle check result for f9184b9: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This one is a bit odd - I don't think this is related to this PR but I don't think its test specific flakiness - cut https://github.com/opensearch-project/OpenSearch/issues/12114 with more


Mask secrets in Playwright traces in CI

Resolves #304
Adds a PS script to CI that masks Playwright traces before they're uploaded.
Now we just need to make sure that we keep the list of secrets that it's aware of up to date.

It seems I'm now forbidden from triggering the Integration Tests workflow on arbitrary branches, because they aren't allowed to use the GitHub "staging" environment, so I just merged it in order to test it 🤷.


Update tdr-generated-graphql to 0.0.233

Updates uk.gov.nationalarchives:tdr-generated-graphql from 0.0.232 to 0.0.233.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "uk.gov.nationalarchives", artifactId = "tdr-generated-graphql" } ]

labels: library-update, early-semver-major, semver-spec-patch, commit-count:1

Superseded by #74.


[SPARK-33742][SQL][2.4] Throw PartitionsAlreadyExistException from HiveExternalCatalog.createPartitions()

What changes were proposed in this pull request?
Throw PartitionsAlreadyExistException from createPartitions() in Hive external catalog when a partition exists. Currently, HiveExternalCatalog.createPartitions() throws AlreadyExistsException wrapped by AnalysisException.
In the PR, I propose to catch AlreadyExistsException in HiveClientImpl and replace it by PartitionsAlreadyExistException.
Why are the changes needed?
The behaviour of Hive external catalog deviates from V1/V2 in-memory catalogs that throw PartitionsAlreadyExistException. To improve user experience with Spark SQL, it would be better to throw the same exception.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
By running existing test suites:
$ build/sbt -Phive -Phive-thriftserver "hive/test:testOnly org.apache.spark.sql.hive.client.VersionsSuite"
$ build/sbt -Phive -Phive-thriftserver "hive/test:testOnly org.apache.spark.sql.hive.execution.HiveDDLSuite"

Authored-by: Max Gekk<EMAIL_ADDRESS>Signed-off-by: Dongjoon Hyun<EMAIL_ADDRESS>(cherry picked from commit fab2995972761503563fa2aa547c67047c51bd33)
Signed-off-by: Max Gekk<EMAIL_ADDRESS>

Test build #132650 has started for PR 30732 at commit 7301fee.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37254/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37254/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37254/

Test build #132650 has finished for PR 30732 at commit 7301fee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132650/


Panic w/podman on Ubuntu

> podman version
Version:      3.4.2
API Version:  3.4.2
Go Version:   go1.15.2
Built:        Wed Dec 31 16:00:00 1969
OS/Arch:      linux/amd64

> uname -a
Linux dev2 5.15.0-48-generic #54-Ubuntu SMP Fri Aug 26 13:26:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

> podman image ls
REPOSITORY                     TAG         IMAGE ID      CREATED         SIZE
docker.io/tfverch/tfvc         latest      aa2863f4a29a  43 minutes ago  41.2 MB

> podman run --rm -it -v "$(pwd):/src" tfverch/tfvc /src
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x91d918]

goroutine 1 [running]:
github.com/tfverch/tfvc/internal/lockfile.decodeProviderVersionConstraintsArgument(0xe06ee0?)
        /home/runner/work/tfvc/tfvc/internal/lockfile/lockfile.go:112 +0x18
github.com/tfverch/tfvc/internal/lockfile.decodeProviderLockFromHCL(0xc00018d450)
        /home/runner/work/tfvc/tfvc/internal/lockfile/lockfile.go:91 +0x33c
github.com/tfverch/tfvc/internal/lockfile.loader(0xc0006efb00, 0xc000011608)
        /home/runner/work/tfvc/tfvc/internal/lockfile/lockfile.go:38 +0x265
github.com/tfverch/tfvc/internal/lockfile.LoadLocks({0xc00003cb10, 0x18})
        /home/runner/work/tfvc/tfvc/internal/lockfile/lockfile.go:16 +0x105
github.com/tfverch/tfvc/internal/checker.Main({0x7ffd092a2f61, 0x4}, 0xb8?, {0x0, 0x0}, {0x0, 0x0})
        /home/runner/work/tfvc/tfvc/internal/checker/main.go:27 +0x11d
github.com/tfverch/tfvc/cmd.glob..func1(0x17e9fc0?, {0xc0006e6aa0?, 0x1, 0x1?})
        /home/runner/work/tfvc/tfvc/cmd/root.go:19 +0x9d
github.com/spf13/cobra.(*Command).execute(0x17e9fc0, {0xc000034050, 0x1, 0x1})
        /home/runner/work/tfvc/tfvc/vendor/github.com/spf13/cobra/command.go:876 +0x67b
github.com/spf13/cobra.(*Command).ExecuteC(0x17e9fc0)
        /home/runner/work/tfvc/tfvc/vendor/github.com/spf13/cobra/command.go:990 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
        /home/runner/work/tfvc/tfvc/vendor/github.com/spf13/cobra/command.go:918
github.com/tfverch/tfvc/cmd.Execute()
        /home/runner/work/tfvc/tfvc/cmd/root.go:44 +0x25
main.main()
        /home/runner/work/tfvc/tfvc/main.go:6 +0x17

@staranto thanks for testing this out! I think this is a massive oversight on my part in that I'm assuming a .terraform.lock.hcl file will exist. Can you confirm if you do or do not have this file generated before running tfvc?

Actually @staranto ignore my last comment. It is clear you have a lock file but the issue is decoding the version constraints. Any chance you could provide a copy of your .terraform.lock.hcl file for me to test with?

This file is maintained automatically by "terraform init".
Manual edits may be lost in future updates.
provider "registry.terraform.io/hashicorp/aws" {
version     = "4.27.0"
constraints = "~> 4.0"
hashes = [
"h1:JjDRnFkYnMTgW1OJclVkE7ucHPFXwhNzrdexhtj97Lo=",
"h1:w3j7YomUQ9IfRp3MUuY0+hFX1T1cawZoj0Xsc1a46bU=",
"zh:0f5ade3801fec487641e4f7d81e28075b716c787772f9709cc2378d20f325791",
"zh:19ffa83be6b6765a4f821a17b8d260dd0f192a6c40765fa53ac65fd042cb1f65",
"zh:3ac89d33ff8ca75bdc42f31c63ce0018ffc66aa69917c18713e824e381950e4e",
"zh:81a199724e74992c8a029a968d211cb45277d95a2e88d0f07ec85127b6c6849b",
"zh:9b12af85486a96aedd8d7984b0ff811a4b42e3d88dad1a3fb4c0b580d04fa425",
"zh:a2e2c851a37ef97bbccccd2e686b4d016abe207a7f56bff70b10bfdf8ed1cbfd",
"zh:baf844def338d77f8a3106b1411a1fe22e93a82e3dc51e5d33b766f741c4a6a3",
"zh:bc33137fae808f91da0a9de7031cbea77d0ee4eefb4d2ad6ab7f58cc2111a7ff",
"zh:c960ae2b33c8d3327f67a3db5ce1952315146d69dfc3f1b0922242e2b218eec8",
"zh:f3ea1a25797c79c035463a1188a6a42e131f391f3cb714975ce49ccd301cda07",
"zh:f7e77c871d38236e5fedee0086ff77ff396e88964348c794cf38e578fcc00293",
"zh:fb338d5dfafab907b8608bd66cad8ca9ae4679f8c62c2435c2056a38b719baa2",
]
}
provider "registry.terraform.io/hashicorp/null" {
version = "3.1.1"
hashes = [
"h1:71sNUDvmiJcijsvfXpiLCz0lXIBSsEJjMxljt7hxMhw=",
"h1:Pctug/s/2Hg5FJqjYcTM0kPyx3AoYK1MpRWO0T9V2ns=",
"zh:063466f41f1d9fd0dd93722840c1314f046d8760b1812fa67c34de0afcba5597",
"zh:08c058e367de6debdad35fc24d97131c7cf75103baec8279aba3506a08b53faf",
"zh:73ce6dff935150d6ddc6ac4a10071e02647d10175c173cfe5dca81f3d13d8afe",
"zh:78d5eefdd9e494defcb3c68d282b8f96630502cac21d1ea161f53cfe9bb483b3",
"zh:8fdd792a626413502e68c195f2097352bdc6a0df694f7df350ed784741eb587e",
"zh:976bbaf268cb497400fd5b3c774d218f3933271864345f18deebe4dcbfcd6afa",
"zh:b21b78ca581f98f4cdb7a366b03ae9db23a73dfa7df12c533d7c19b68e9e72e5",
"zh:b7fc0c1615dbdb1d6fd4abb9c7dc7da286631f7ca2299fb9cd4664258ccfbff4",
"zh:d1efc942b2c44345e0c29bc976594cb7278c38cfb8897b344669eafbc3cddf46",
"zh:e356c245b3cd9d4789bab010893566acace682d7db877e52d40fc4ca34a50924",
"zh:ea98802ba92fcfa8cf12cbce2e9e7ebe999afbf8ed47fa45fc847a098d89468b",
"zh:eff8872458806499889f6927b5d954560f3d74bf20b6043409edf94d26cd906f",
]
}
provider "registry.terraform.io/hashicorp/random" {
version = "3.3.2"
hashes = [
"h1:Fu0IKMy46WsO5Y6KfuH9IFkkuxZjE/gIcgtB7GWkTtc=",
"h1:H5V+7iXol/EHB2+BUMzGlpIiCOdV74H8YjzCxnSAWcg=",
"zh:038293aebfede983e45ee55c328e3fde82ae2e5719c9bd233c324cfacc437f9c",
"zh:07eaeab03a723d83ac1cc218f3a59fceb7bbf301b38e89a26807d1c93c81cef8",
"zh:427611a4ce9d856b1c73bea986d841a969e4c2799c8ac7c18798d0cc42b78d32",
"zh:49718d2da653c06a70ba81fd055e2b99dfd52dcb86820a6aeea620df22cd3b30",
"zh:5574828d90b19ab762604c6306337e6cd430e65868e13ef6ddb4e25ddb9ad4c0",
"zh:7222e16f7833199dabf1bc5401c56d708ec052b2a5870988bc89ff85b68a5388",
"zh:78d5eefdd9e494defcb3c68d282b8f96630502cac21d1ea161f53cfe9bb483b3",
"zh:b1b2d7d934784d2aee98b0f8f07a8ccfc0410de63493ae2bf2222c165becf938",
"zh:b8f85b6a20bd264fcd0814866f415f0a368d1123cd7879c8ebbf905d370babc8",
"zh:c3813133acc02bbebddf046d9942e8ba5c35fc99191e3eb057957dafc2929912",
"zh:e7a41dbc919d1de800689a81c240c27eec6b9395564630764ebb323ea82ac8a9",
"zh:ee6d23208449a8eaa6c4f203e33f5176fa795b4b9ecf32903dffe6e2574732c2",
]
}

@staranto thanks for this. I think I've resolved the issue. Could you test again with the new version I just released?

New release works like a champ!  Congrats on the start of a nice utility!


How to record rtsp stream using this player ?

How can i record the rtsp player stream and save it locally ..
Is there any way to do it in this project..?

📎 https://github.com/piemonte/Player/issues/118


What could be causing unexpected word (expecting ")")?

👋 Hello - thanks for your work on goss! I'm attempting to use dgoss (at 54a77a9) and consistently runing up against a /goss/goss: line 2: syntax error: unexpected word (expecting ")") error. I can reproduce this error across multiple Docker images, and it occurs in scenarios where I expect passing tests as well as in scenarios where I expect failing tests. For example...
A simple goss.yaml file:
---
file:
  /bin/hugo:
    exists: true

...used with an example dgoss invocation:
dgoss run --tty --entrypoint sh klakegg/hugo
INFO: Starting docker container
INFO: Container ID: 263917ca
INFO: Sleeping for 0.2
INFO: Container health
INFO: Running Tests
H__PAGEZEROx__TEXTǐ__text__TEXT: not found
/goss/goss: line 2: syntax error: unexpected word (expecting ")")
INFO: Deleting container

This is occurring on an Apple M1 Pro running macOS Ventura 13.4.1 using Docker version 20.10.23, build 7155243. Am I overlooking something obvious? Thanks!

My guess would be you may be attempting to run a Mac binary in Linux.
Download the proper Goss binary somewhere on your Mac. Set GOSS_PATH env var to that binary.
For debugging, you can just manually copy the Goss binary you have today into the container and run it to see if it gives the same error.
My guess is you need the Linux-amd64 or Linux-arm* versions.. to be honest, I'm not up to date on the latest m1/m2 Mac docker story.
If you find a binary that works, can you report back on this issue.. I'd love to update the docs for others.. m1/m2+ chips seem like they'll be a common developer setup for the future.

Thanks @aelsabbahy - That clarifies a lot. Admittedly, I wasn't expecting dgoss to rely on a goss binary living on the host; I was expecting its sole dependency to essentially be docker itself.
So, to resolve the error I describe above, I first downloaded a goss-linux-amd64:
curl \
  --fail \
  --silent \
  --show-error \
  --location \
  "https://github.com/goss-org/goss/releases/download/v0.3.23/goss-linux-amd64" \
  --output goss

Then, I used this goss as the value of GOSS_PATH when running dgoss:
$ GOSS_PATH=goss dgoss run --tty --entrypoint sh klakegg/hugo
INFO: Starting docker container
INFO: Container ID: 7f820b06
INFO: Sleeping for 0.2
INFO: Container health
INFO: Running Tests
File: /bin/hugo: exists: matches expectation: [true]

Total Duration: 0.015s
Count: 1, Failed: 0, Skipped: 0
INFO: Deleting container

Feel free to submit a PR updating the documentation if you feel it would help the next person.
Thank you for validating this!


Update VS Code metrics for 'coreclr' mode

OpenDebugAD7 is being changed to read more configuration from the metrics. This adds
these metrics to the .json file.

:+1:


Temps coming back as integer, not float

Describe the bug
When running si.cpu() and parsing the result, the speeds are reported as integers and not floats. Or at least, they have no decimal points and are all the same value.
To Reproduce
const si = require("systeminformation");

si.cpu()
  .then(data => {
    const { speed, speedMin, speedMax } = data;
    console.log({ speed, speedMin, speedMax });
  })
  .catch(error => {
    console.error(error);
  });

Current Output
$ node info-test.js
{ speed: 3, speedMin: 3, speedMax: 3 }

Expected behavior
I would expect these to be floats, like 3.2, 3.4, and 3.7
Environment (please complete the following information):

systeminformation package version: 5.17.16z
OS: Windows 11 v10.0.22621
Hardware: Custom Build PC

Motherboard: ASRock Z790 Pro RS
CPU: Intel Core i9-13900K

Additional context
I'm also having issues with CPU temps returning null

So in windows, the speed is determined by querying Win32_processor and the result is a constant value and does not reflect the current speed of the processor. In your case this value is 3.0 which is (as a number) 3 ... hope this clarifies the issue. But just to be sure: can you provide the output of:
From PowerShell
Get-CimInstance Win32_processor | select Name, Revision, L2CacheSize, L3CacheSize, Manufacturer, MaxClockSpeed, Description, UpgradeMethod, Caption, NumberOfLogicalProcessors, NumberOfCores | fl

@JoePShoulak ... I provided an answer without referencing your name - please have a look on GitHub ;-) ... sorry

@sebhildebrandt No problem, thank you for your response! So what is the proper way to query the current speed of the processor, if that's available?
I like this tool a lot, I'm trying to make a local web server I can run to view some of my sys info on a tablet near my PC!
I'm also curious, the only other property I'd like to find but seem to be missing is GPU usage, is that available using this API?
Here's the code output you requested:
Name                      : 13th Gen Intel(R) Core(TM) i9-13900K
Revision                  :
L2CacheSize               : 16384
L3CacheSize               : 36864
Manufacturer              : GenuineIntel
MaxClockSpeed             : 3000
Description               : Intel64 Family 6 Model 183 Stepping 1
UpgradeMethod             : 1
Caption                   : Intel64 Family 6 Model 183 Stepping 1
NumberOfLogicalProcessors : 32
NumberOfCores             : 24

@JoePShoulak ... as you can see: max clock speed is 3000 (MHz) which is then 3 GHz ...
As Windows does not provide that much detailed information for CPU and GPU like other platforms, we are kind of limited here. The only option would be to write a bunch of C code (which then needs to be adapted for all hardware variations). This is not what we intended to do.
For Linux and Mac OS the information you would get is much more accurate as those operating systems provide much more possibilities to gather system information.
Closing this issue for now. But if you have any further questions, do not hesitate to open a new issue.


Sometimes fail to start container

In our integration test, we sometimes fail to start container with following error:
OCI runtime state failed: invalid state transition from stopped to paused: unknown

In cri-containerd, we never use Pause, so I don't quite understand what is happening here. I've hit this 2 times since last night.
/cc @crosbymichael

Ref https://github.com/kubernetes-incubator/cri-containerd/issues/259.

Its probably coming from the killAll when a process exits.  It pauses everything in the cgroup and kills it.
https://github.com/containerd/containerd/blob/master/linux/shim/service.go#L398
This probably needs to be smarter or better synchronized ( both maybe ).
#1525 may actually fix this as I rewrote some of the locking code for process operations.

@Random-Liu @crosbymichael Still having problems?

@stevvooe Not till now. I'm working on enabling more integration test with cri-containerd. That may expose this issue again. If not, I think it's fine to close.

@Random-Liu Closing this for now. If we see the issue again, we'll reopen.


Fix win port

Built on windows. Prepared to developening.

@petrovigor  please read :

https://stackoverflow.com/questions/37276413/default-move-constructor-assignment-and-deleted-copy-constructor-assignment
https://en.cppreference.com/w/cpp/language/noexcept_spec


Allow local_archive paths to be labels

If a local_archive path looks like a label, interpret it as such.

Looks good to me. Should you also consider it a path if it starts with // ?

Yes, good catch. (I assume you mean "consider it a label if it starts with //).


Updated image did not get pushed on submit

I believe I did the following:
docker build -t my-image .
naacl-utils submit my-image test-1

# The job failed, so I modified my Dockerfile, then repeated the submission process
docker build -t my-image .
naacl-utils submit my-image test-2

The utils did not push any image and the old image ran. After I retagged my image with a new name and submitted that tag, it worked as expected.
I haven't tried to reproduce this so I may have just messed up somewhere.

Ah, you're right. This is a bug. PR coming soon.


⚠ Visual-Crew_Builder has degraded performance

In cc2e428, Visual-Crew_Builder (https://visual-crew-builder.ai) experienced degraded performance:

HTTP code: 200
Response time: 1038 ms

Resolved: Visual-Crew_Builder performance has improved in 81b65f6 after 6 minutes.


Fixed support for --yes when using cloud commands

Added fix for --yes support
Updated shared command parsing to consume command items
https://github.com/spark/particle-cli/issues/382

The issue this fixes is the flash command won't accept --yes at all no matter which position on the command line its placed. e.g.
$ particle --version
1.16.0
$ particle flash --yes three-sim-card firmware.bin
I couldn't find that file: three-sim-card
Flash device failed
undefined

Where three-sim-card should be the device name.

Hi, this has been updated as requested, how does it look now?


basehub: update jupyterhub chart from 3.2.1 to 3.3.6 (Scheduled for 9nd April)

This update brings in jupyterhub 4.1.0 and oauthenticator 16.3.0.
Two bugfixes upstream
This early adoption of z2jh's new release led to catching two bugs.

First 3.3.0 failed because of a pycurl regression (observed when using oauthenticator to sign in)
https://github.com/jupyterhub/zero-to-jupyterhub-k8s/issues/3366
Then 3.3.1 failed because of a iptables regression (observed when starting a user pod)
https://github.com/jupyterhub/zero-to-jupyterhub-k8s/issues/3368

Compatibility fix in jupyterhub-configurator

[x] The jupyterhub-configurator's web-server made use of HubOAuthenticator that now requires xsrf tokens when receiving javascript fetch requests. This is resolved by https://github.com/yuvipanda/jupyterhub-configurator/pull/19 which is backported to an old enough commit in a branch we now build from. This branch can be adopted without introducing breaking changes.
[x] Closes https://github.com/2i2c-org/infrastructure/issues/3197, let's not try to migrate to use the latest jupyterhub-configurator commit as it has introduced breaking changes that we would need to migrate config to handle.

About JupyterHub 4.1.1 - 4.1.4 releases
Several (all?) of the issues patched related to jupyterhub code executed in the user servers, which are unaffected by this PRs upgrade of the server side part of jupyterhub.

In 4.1.1, https://github.com/jupyterhub/jupyterhub/pull/4745
In 4.1.2, https://github.com/jupyterhub/jupyterhub/pull/4750
In 4.1.3, https://github.com/jupyterhub/jupyterhub/pull/4753
In 4.1.4, https://github.com/jupyterhub/jupyterhub/pull/4759

Verifications

[x] jupyterhub-configurator works
[x] rstudio works
[x] nbgitpuller works (nbgitpuller 1.2.1+ is required if jupyterhub 4.1 is used in the user env)
[x] jupyter-resource-usage works
[x] jupyter-remote-desktop-proxy works (2.0.0+ is required if jupyterhub 4.1 is used in the user env)
[x] jupyter notebook 6
[x] jupyter notebook 7 (jupyter_server based, like jupyter lab)

Related

z2jh changelog: https://z2jh.jupyter.org/en/stable/changelog.html
jupyterhub changelog: https://jupyterhub.readthedocs.io/en/stable/reference/changelog.html
oauthenticator changelog: https://oauthenticator.readthedocs.io/en/latest/reference/changelog.html

z2jh 3.3.0 is broken because pycurl is broken due to a regression in a patch release, working to fix it now.

Okay, two z2jh patch releases later things work it seems!
Will merge tomorrow when I'm starting my workday

@yuvipanda I'm getting pulled into needing to understand how jupyterhub-configurator works etc since its broken against jupyterhub 4.1.0 - likely due to CORS related changes.
I'd like to bite the bullet and catch up with misc maintenance:

https://github.com/2i2c-org/infrastructure/issues/3197
review stale PRs in https://github.com/yuvipanda/jupyterhub-configurator/pulls
get it jupyterhub 4.1.0 compatible
maybe make a 1.0.0 release to PyPI because its notable work to pin and communicate about commits compared to do releases with changelogs etc

Are you OK with granting me maintainer rights and going for it quite swiftly?

@consideRatio I've added you as maintainer. However, there are no users of that outside of 2i2c (especially after it was taken out of tljh), and it is an architectural dead end. I think it's ok to do the work that unblocks z2jh upgrades, but i don't think it should have any other work done on it at all.
I've closed or merged PRs as appropriate.

I'd also think it's appropriate to rollback jupyterhub-configurator to the commit that was known good and worked here, do whatever fix is needed for 4.1, and just get that going.

I'm planning this to be deployed next tuesday - 2nd April.

That schedule looks good to me, @consideRatio. I'd like at least the following things to be tested before this is deployed everywhere:

[ ] nbgitpuller (server extension with its own UI)
[ ] RStudio (complex proxied app)
[ ] jupyter-remote-desktop-proxy (simpler proxied app, with its own server extension)
[ ] Make sure the resource usage display in the status bar of JupyterLab works (pure API extension)
[ ] Classic Notebook (because I don't fully know how this does xsrf, and how it interacts with possible changes to jupyterhub-singleuser)

This should give us enough confidence that most things will work.

I agree @yuvipanda, note though that I expect a lot of these issues to arise independent on what is done server-side, but in the user images using a modern jupyterhub version.

@yuvipanda I've verified that a server-side change doesn't cause issues in any of the things you listed.

Beyond this because its related, I've considered the user environments. I've concluded that jupyterhub 4.1.4, nbgitpuller 1.2.1, and jupyter-remote-desktop-proxy 2.0.0, jupyter-resource-usage 1.0.2 (no patch needed), and utoronto's classical UI from notebook 6, Lab UI, and RStudio UI works when jupyterhub-singleuser 4.1.4 is used in the user environment - use of jupyterhub 4.0 or 4.1 server side doesn't change this.

jupyter/docker-stacks latest published images have jupyterhub 4.1.4
pangeo/pangeo-docker-images latest tagged image has jupyterhub 4.0.2, and will when release is made go straight to 4.1.4 with nbgitpuller 1.2.1 as its part of the master branch already.
rocker/binder images have jupyterhub 4.1.3 currently which makes rstudio work

@consideRatio thanks for doing that. My suggestion is to do this next week, given we still have a bunch of things that we had committed to this sprint not done yet. We can schedule this during the sprint planning meeting for the next one.

@yuvipanda rescheduled to 9th april!

Ask @GeorgianaElena to spend some cycles on this one next week.


Version 2.0.2 with lodash-es added 7kB to the bundle size

I read that the reason to switch to lodash-es was that few other libs use this version. However, let me highlight that for people like me that use lodash (as the majority of Lodash users based on npm stats) this change increased the build size by 7kB (minified).
Moreover, looks like babel-plugin-lodash and lodash-webpack-plugin have no effect on lodash-es.
As lodash@5 will probably make lodash-es deprecated (as it will be like it out of the box) is this change really worth it?

@webholics can you respond?

@albertogasparin I should have researched this further. If you could post some convincing statistics, I'd be happy to revert. In general, it would be great to have more active participation in PRs (anyone can comment I believe), since front-end is less of a focus for me these days.

@yangmillstheory - this is absolutely a beneficial technique accepted by the community.
redux, redux-react, redux-persist, etc (there are more) all use this technique, and being able to share methods with them WILL reduce package size. Some back story on the issue can be found here: https://github.com/reactjs/redux/pull/1369
@albertogasparin - Sorry that the change has temporarily increased your bundle size. Implementing lodash-es within your project may be beneficial, as it is already in use by the libraries mentioned above (one of them being a direct dependency). There is no reason to include lodash and lodash-es methods.
* If you do not want to change files manually, perhaps you could implement the same shim the libraries do https://github.com/reactjs/redux/blob/master/build/use-lodash-es.js ?

As lodash@5 will probably make lodash-es deprecated (as it will be like it out of the box) is this change really worth it?

This seems like a problem we can deal with when lodash@5 comes out.

I don't know about all other libs, but both redux and react-redux are using a single lodash method (isPlainObject). For people not using lodash at all, the es-version is smaller than the standard one and for people using it the additional cost is ~500B, so negligible.
redux-actions on the over side uses several lodash methods, so the amount of duplicated code jumps to nearly 7kB (worst scenario). I don't have specific stats about people using redux-actions + lodash vs redux-actions + lodash-es, but @jaridmargolin let me disagree with your "absolutely beneficial" statement.
Anyway, I've opened the issue just to be sure that you guys are conscious of the effects of #206. On my end I've solved the duplication problem with Webpack:
new webpack.NormalModuleReplacementPlugin(
  /^lodash-es(\/|$)/, (res) => {
    res.request = res.request.replace(/^lodash-es(\/|$)/, 'lodash$1');
  }
)

So I leave it here just in case someone else looks for a solution.

@albertogasparin I do appreciate your perspective andI think it is great to have a track record for anyone else who bumps up against this. I saw around a 6KB reduction in my case. This solution provides the opportunity for people utilizing additional libraries to notably cut down on unnecessary bloat.
I am by no means the MOST qualified to speak on the pros/cons of the technique. @jdalton - Do you have any insight into the implications of using lodash vs lodash-es?

if the versions of both lodash and lodash-es are ^4 then you should be fine as the lodash-es package is just the lodash one with import/exports. I know @TheLarkInn has done some work to consolidate lodash and lodash-es and other packages into a single set.


How to diable hover windows and underline?

How to diable hover windows and underline(like uiWidgetListview class)?

find it in setting.
underline is provided by your theme.

find it in setting.
underline is provided by your theme.

Sorry, I never express it well. Can I hide the hover windows when cursor on "uiWidgetListview", and the underline on "uiWidgetListview" don't show.

Do you mean disable previewing fields inside uiWidgetListview?
The underline is provide by the theme you are using. If you dont want it, you have to change to another theme.

Do you mean disable previewing fields inside uiWidgetListview?
The underline is provide by the theme you are using. If you dont want it, you have to change to another theme.

Can I disable previewing fields inside uiWidgetListview?

I will work on it.


Fix path separator

Fix path separator: from / to \\ on Windows:
PS C:\dev\vcpkg\> vcpkg.exe integrate install
Error: Failed to copy file: C:\dev\vcpkg\vcpkg\scripts\buildsystems\tmp\vcpkg.user.targets -> C:\Users\helpdesk\AppData\Local\vcpkg/vcpkg.user.targets

Fixse https://github.com/microsoft/vcpkg/issues/22413

Why will this fix 22413? Windows should treat \ the same as /

There are two possibilities here:

The vcpkg directory is not created before or created failure,
Can't handle / using exec.

Since 2. would mean it should fail for everybody, I would bet on 1.

I don't think this change will affect anything about the "failed to copy file" but it will improve the diagnostic so I'm all for it.


ignore upcoming warnings in  webview_flutter_wkwebview.

Following up on #5852 for changes in webview_flutter_wkwebview.
This PR will prevent warnings once https://github.com/flutter/flutter/pull/104231 has landed.

PTAL


Update screenshot. AKS on Azure Stack Hub HCI no longer in a preview

Update this screenshot https://docs.microsoft.com/en-us/azure-stack/aks-hci/media/create-kubernetes-cluster/add-connection.png it's no longer up-to-date

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9eab013e-9d8b-6a9a-a7cc-91254cea0e5f
Version Independent ID: 1307b887-14cd-cf0d-ff02-715c55bb8db7
Content: Quickstart to create a Kubernetes cluster using Windows Admin Center - AKS-HCI
Content Source: azure-stack/aks-hci/create-kubernetes-cluster.md
Service: azure-stack
Sub-service: aks-hci
GitHub Login: @davannaw-msft
Microsoft Alias: dawhite

@SychevIgor - Thanks for brining this to our attention. We will investigate it further and update you shortly.

@SychevIgor -
Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


dpkg: error processing package opencv-python:armhf

I am building a docker using raspberrypi base image
https://hub.docker.com/r/dtcooper/raspberrypi-os
first issue I was getting is  failing to install these libs
libjasper1 libjasper-dev
spend some hours finding a workaround without luck.
so I have skipped  that part from your manual.
then when running
 dpkg -i OpenCV*.deb &&
I have got this
`Unpacking opencv-scripts:armhf (4.4.0) ...
dpkg: dependency problems prevent configuration of opencv-dev:armhf:
opencv-dev:armhf depends on libc6 (>= 2.4).
opencv-dev:armhf depends on libgcc1 (>= 1:3.5).
opencv-dev:armhf depends on libstdc++6 (>= 5.2).
dpkg: error processing package opencv-dev:armhf (--install):
dependency problems - leaving unconfigured
Setting up opencv-licenses:armhf (4.4.0) ...
dpkg: dependency problems prevent configuration of opencv-libs:armhf:
opencv-libs:armhf depends on libavcodec58 (>= 7:4.0).
opencv-libs:armhf depends on libavformat58 (>= 7:4.1).
opencv-libs:armhf depends on libavutil56 (>= 7:4.0).
opencv-libs:armhf depends on libc6 (>= 2.28).
opencv-libs:armhf depends on libcairo2 (>= 1.2.4).
opencv-libs:armhf depends on libfreetype6 (>= 2.2.1).
opencv-libs:armhf depends on libgcc1 (>= 1:4.0).
opencv-libs:armhf depends on libgdk-pixbuf2.0-0 (>= 2.22.0).
opencv-libs:armhf depends on libglib2.0-0 (>= 2.31.8).
opencv-libs:armhf depends on libgtk-3-0 (>= 3.0.0).
opencv-libs:armhf depends on libharfbuzz0b (>= 0.9.9).
opencv-libs:armhf depends on libjasper1.
opencv-libs:armhf depends on libjpeg62-turbo (>= 1.3.1).
opencv-libs:armhf depends on libpng16-16 (>= 1.6.2-1).
opencv-libs:armhf depends on libstdc++6 (>= 7).
opencv-libs:armhf depends on libswscale5 (>= 7:4.0).
opencv-libs:armhf depends on libtbb2.
opencv-libs:armhf depends on libtiff5 (>= 4.0.3).
opencv-libs:armhf depends on zlib1g (>= 1:1.2.0).
dpkg: error processing package opencv-libs:armhf (--install):
dependency problems - leaving unconfigured
Setting up opencv-scripts:armhf (4.4.0) ...
dpkg: dependency problems prevent configuration of opencv-main:armhf:
opencv-main:armhf depends on libc6 (>= 2.4).
opencv-main:armhf depends on libgcc1 (>= 1:3.5).
opencv-main:armhf depends on libstdc++6 (>= 5.2).
dpkg: error processing package opencv-main:armhf (--install):
dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of opencv-python:armhf:
opencv-python:armhf depends on libc6 (>= 2.4).
opencv-python:armhf depends on libgcc1 (>= 1:3.5).
opencv-python:armhf depends on libstdc++6 (>= 5.2).
dpkg: error processing package opencv-python:armhf (--install):
dependency problems - leaving unconfigured
Errors were encountered while processing:
opencv-dev:armhf
opencv-libs:armhf
opencv-main:armhf
opencv-python:armhf
The command '/bin/sh -c cd Faster_OpenCV_4_Raspberry_Pi/debs &&     dpkg -i OpenCV*.deb &&     ldconfig' returned a non-zero code: 1
`
ca you please help ?
Dockerfile
FROM dtcooper/raspberrypi-os:bullseye
RUN apt-get update && sudo apt-get upgrade -y && apt-get -y install libglib2.0-0; apt-get clean
RUN apt install -y python2
RUN apt-get install -y curl
RUN curl https://bootstrap.pypa.io/pip/2.7/get-pip.py  --output get-pip.py
RUN python2.7 get-pip.py
RUN apt-get install -y python2-dev
RUN apt-get install -y zip
RUN apt-get install -y wget
RUN apt-get install -y
libjpeg-dev libpng-dev libtiff-dev libgtk-3-dev
libavcodec-extra libavformat-dev libswscale-dev libv4l-dev
libxvidcore-dev libx264-dev
libatlas-base-dev gfortran libeigen3-dev libtbb-dev
RUN apt-get install -y libatlas-base-dev gfortran
RUN pip2 install numpy
RUN apt-get install -y git
RUN git clone https://github.com/dlime/Faster_OpenCV_4_Raspberry_Pi.git
RUN cd Faster_OpenCV_4_Raspberry_Pi/debs &&
dpkg -i OpenCV*.deb &&
ldconfig`
I am desperately trying to build a docker for a big program I have  build years ago
It runs python2.7 and  opencv 4 over raspberry pi 3+.
After a week of failing to build or finding any ready source I cam across your git
please help

UPDATE
was adding these lines to docker before with no success
` RUN apt-get install -y libavcodec58
RUN apt-get install -y libavformat58
RUN apt-get install -y libavutil56
RUN apt-get install -y libcairo2
RUN apt-get install -y libfreetype6
RUN apt-get install -y libgcc1
RUN apt-get install -y libgdk-pixbuf2.0-0
RUN apt-get install -y libglib2.0-0
RUN apt-get install -y libgtk-3-0
RUN apt-get install -y libharfbuzz0b
RUN apt-get install -y libjasper1
RUN apt-get install -y libjpeg62-turbo
RUN apt-get install -y libpng16-16
RUN apt-get install -y libstdc++6
RUN apt-get install -y libswscale5
RUN apt-get install -y libtbb2
RUN apt-get install -y libtiff5
RUN apt-get install -y zlib1g
`
output
`Step 35/49 : RUN cd Faster_OpenCV_4_Raspberry_Pi/debs &&     dpkg -i OpenCV*.deb &&     ldconfig
---> Running in 17332af97197
Selecting previously unselected package opencv-dev:armhf.
(Reading database ... 32794 files and directories currently installed.)
Preparing to unpack OpenCV-4.4.0-armv7l-dev.deb ...
Unpacking opencv-dev:armhf (4.4.0) ...
Selecting previously unselected package opencv-libs:armhf.
Preparing to unpack OpenCV-4.4.0-armv7l-libs.deb ...
Unpacking opencv-libs:armhf (4.4.0) ...
Selecting previously unselected package opencv-licenses:armhf.
Preparing to unpack OpenCV-4.4.0-armv7l-licenses.deb ...
Unpacking opencv-licenses:armhf (4.4.0) ...
Selecting previously unselected package opencv-main:armhf.
Preparing to unpack OpenCV-4.4.0-armv7l-main.deb ...
Unpacking opencv-main:armhf (4.4.0) ...
Selecting previously unselected package opencv-python:armhf.
Preparing to unpack OpenCV-4.4.0-armv7l-python.deb ...
Unpacking opencv-python:armhf (4.4.0) ...
Selecting previously unselected package opencv-scripts:armhf.
Preparing to unpack OpenCV-4.4.0-armv7l-scripts.deb ...
Unpacking opencv-scripts:armhf (4.4.0) ...
dpkg: dependency problems prevent configuration of opencv-dev:armhf:
opencv-dev:armhf depends on libc6 (>= 2.4).
opencv-dev:armhf depends on libgcc1 (>= 1:3.5).
opencv-dev:armhf depends on libstdc++6 (>= 5.2).
dpkg: error processing package opencv-dev:armhf (--install):
dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of opencv-libs:armhf:
opencv-libs:armhf depends on libavcodec58 (>= 7:4.0).
opencv-libs:armhf depends on libavformat58 (>= 7:4.1).
opencv-libs:armhf depends on libavutil56 (>= 7:4.0).
opencv-libs:armhf depends on libc6 (>= 2.28).
opencv-libs:armhf depends on libcairo2 (>= 1.2.4).
opencv-libs:armhf depends on libfreetype6 (>= 2.2.1).
opencv-libs:armhf depends on libgcc1 (>= 1:4.0).
opencv-libs:armhf depends on libgdk-pixbuf2.0-0 (>= 2.22.0).
opencv-libs:armhf depends on libglib2.0-0 (>= 2.31.8).
opencv-libs:armhf depends on libgtk-3-0 (>= 3.0.0).
opencv-libs:armhf depends on libharfbuzz0b (>= 0.9.9).
opencv-libs:armhf depends on libjasper1.
opencv-libs:armhf depends on libjpeg62-turbo (>= 1.3.1).
opencv-libs:armhf depends on libpng16-16 (>= 1.6.2-1).
opencv-libs:armhf depends on libstdc++6 (>= 7).
opencv-libs:armhf depends on libswscale5 (>= 7:4.0).
opencv-libs:armhf depends on libtbb2.
opencv-libs:armhf depends on libtiff5 (>= 4.0.3).
opencv-libs:armhf depends on zlib1g (>= 1:1.2.0).
dpkg: error processing package opencv-libs:armhf (--install):
dependency problems - leaving unconfigured
Setting up opencv-licenses:armhf (4.4.0) ...
dpkg: dependency problems prevent configuration of opencv-main:armhf:
opencv-main:armhf depends on libc6 (>= 2.4).
opencv-main:armhf depends on libgcc1 (>= 1:3.5).
opencv-main:armhf depends on libstdc++6 (>= 5.2).
dpkg: error processing package opencv-main:armhf (--install):
dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of opencv-python:armhf:
opencv-python:armhf depends on libc6 (>= 2.4).
opencv-python:armhf depends on libgcc1 (>= 1:3.5).
opencv-python:armhf depends on libstdc++6 (>= 5.2).
dpkg: error processing package opencv-python:armhf (--install):
dependency problems - leaving unconfigured
Setting up opencv-scripts:armhf (4.4.0) ...
Errors were encountered while processing:
opencv-dev:armhf
opencv-libs:armhf
opencv-main:armhf
opencv-python:armhf
The command '/bin/sh -c cd Faster_OpenCV_4_Raspberry_Pi/debs &&     dpkg -i OpenCV*.deb &&     ldconfig' returned a non-zero code: 1
`

Unfortunately raspbians(arm debians 9-11) missing some dependencies.
Adding
deb http://ports.ubuntu.com/ubuntu-ports xenial-security main
deb http://ports.ubuntu.com/ubuntu-ports focal main restricted universe multiverse

to /etc/apt/sources.list
then sudo apt update
then, in keys of unsigned keys errors sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys <key>
will allow you to install libjasper-dev which already includes libjasper1 as dependency
And finally:
sudo apt update
sudo apt install build-essential cmake libjasper-dev

^ Did the trick for my on raspbian 11.


fix: bump core and okhttp3 to avoid CVE

PR summary
This PR bumps the versions of the java core and okhttp3 dependencies to avoid a CVE.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.24.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use generation to track update

/assign pmorie
/assign deads2k

/retest

/approve
/lgtm

I think the scenarios covered here make sense to validate with an e2e. The integration tests are pretty thorough - I don't think we need e2e coverage of every single scenario covered by those tests, but a key scenario or two will be useful to validate against a real system. Maybe registration with and without cluster name change?


Feature: add the feature to mergecell

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.18%. Comparing base (90b0a1c) to head (3c3066e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   97.97%   94.18%   -3.79%
==========================================
  Files           7        1       -6
  Lines         444       86     -358
==========================================
- Hits          435       81     -354
+ Misses          7        3       -4
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[New Feature]: Adding a favicon Icon

🎮 feature Request

By adding a Favicon icon  enchances its overall apperrance
Point down the features
-It will give website its logo and acts as hallmark for the users
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

@Durgesh4993 Sir, Its my pleasure to work on it
kindly assign the work

If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)

Assign me for the same

@Durgesh4993 Sir, I would like to work on this issue. Please assign it to me.

@Durgesh4993 being an designer too, I can make a good favicon for the website , so I request you to kindly assign this to me


onPageInit for popup pages

Hello!
I'm trying to apply onpageinit on a page that I set up in a separate html in what is called through a function and get right after myApp.popup (html);
Thus it seems to me that the f7 can not interpletar that the page was started and run in turn onpageinit event.
Am I doing something wrong or is it a bug / feature?
myApp.onPageInit('login', function(page) { 	console.log("teste"); });
FUNCTION:
this.pageLoad = function(page) {     $$.get(config.local + page,         function (template) {             myApp.popup(template);         }     ); }
HTML:
`

                    

`

You should have full View HTML structure there with .views > .pages > .page > .... to have this event


Update readme examples

This updates the examples to remove the ipfs peer-id component, since afaict no projects are actually using that format. I also updated the protocol strings to their current versions to more closely reflect real-world usage.
I also added a note that both sides might simultaneously send the initial multistream header, since that was also surprising to implementors after reading the docs.
The other big change is the removal of the example that lists and selects http/multiproto.io protocols - we could bring it back, but I think it needs at least some kind of call out that multiproto.io doesn't exist today, and that the example is there to illustrate things you could build with multistream-select. As it is, I think it reads as a description of an existing system, which is a bit confusing.
Tagging @Warchant, since this was prompted by some feedback from their work on a C++ implementation of multistream-select & libp2p. If I could send this PR back in time a few weeks, would it have helped you out?

@Akvinikym


Favicon

Need to add a favicon

Resolved in https://github.com/ssuds/ssuds.github.io/commit/17895200eadb6ddb988b770026733a4ccee1a8e9


libs/libxx: remove redundant code

Summary
As https://github.com/apache/nuttx/pull/9151 merged,  that is no need to deal with zero size in C++ allocator.
The discuss is from https://github.com/apache/nuttx/pull/9143#issuecomment-1529395957
Impact
None
Testing
Pass CI. Test new int[0] in sim.

please add commit message describing the change


[change] Chenged some files

Pull Request Type

change

Description
Removed unnecessary task and added some ci badges
Pre-Review Checklist for the Pull Request Author

[x] Code follows coding-guidelines
[x] Assign Pull Request to reviewer

Checklist for the Pull Request Reviewer

[x] Commits are properly organized and messages are according to the guideline
[x] Code follows coding-guidelines
[x] (Optional) Unit tests have been written for new behavior
[ ] Pull Request title describes the changes

Post-Review Checklist for the Pull Request Author

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

@nakajima-john-shotaro https://github.com/nakajima-john-shotaro/AIcon_dev/milestone/1

@nakajima-john-shotaro A human being can live for 11 days without sleep.


yaxis axisBorder not showing

Description
Cant show axisBorder only for yaxis for horizontal bar chart
Steps to Reproduce

Set xaxis:{axisBorder:{show:false;}}
Set yaxis:{axisBorder:{show:true;}}

Expected Behavior
Show the yaxis border at left to the labels
Actual Behavior
Not showing yaxis border
Screenshots

Reproduction Link
https://codepen.io/denislav-parvanov/pen/xxPjJZP

I'm having the same issue. @dparvanov were you able to solve this?


Logged stats show incorrect failure percentage

Description of issue
The failure percentage stats printed to stdout are calculated incorrectly.
Seen here
fail_percent = (self.num_failures/float(self.num_requests + self.num_failures))*100
Expected behavior
If something fails every request made, the failure percentage should show 100%.
The calculation should be
fail_percent = float(self.num_failures/self.num_requests)*100
Actual behavior
It shows 50% if a request fails every attempt.
Environment settings

OS: Fedora 29
Python version: 3.6.8
Locust version: latest source

Steps to reproduce (for bug reports)
Create a locust file with any failing requests. You can see the number of failures don't match up with the failure percentage.

Fixed in: 7ce7ca5507be98eac2d345a1f8ac9d1cfb744a02