[STAL-2781] Build release Linux binary on Ubuntu 20.04

What problem are you trying to solve?
We currently compile our Linux release binaries on GitHub's ubuntu-latest runner, which resolves to ubuntu 24.04. Because 24.04 uses a newer version of glibc, it compiles binaries that expect more recent versions of glibc (currently, v8 expects pthread_getattr_np@GLIBC_2.32). This leads to an error when trying to run the binary on older versions of Linux (specifically Ubuntu 20.04, which ships with glibc 2.31)

What is your solution?
Building on Ubuntu 20.04 generates a binary that now expects glibc 2.2.5:
❯ greadelf -a datadog-static-analyzer-server | grep pthread_getattr_np
000003efe688<PHONE_NUMBER>06 R_X86_64_GLOB_DAT<PHONE_NUMBER>000000<EMAIL_ADDRESS>+ 0

And thus the binaries now work on Ubuntu 20.04.
You can confirm that this modification to the release workflow functions correctly by looking at a pre-release that I just generated to test it:

We need to add an extra step to set up the container, as the base image is missing the packages that GitHub installs by default on a non-containerized runner (curl, gh, etc).
Alternatives considered
What the reviewer should know

I only modified the release.yml to build on Ubuntu 20.04 -- all of the integration tests will still build/run on ubuntu-latest (currently 24.04). Assuming glibc doesn't have forward-compatibility issues, this setup is fine.

Thank you @jasonforal for your nice words ❤  and for your  thorough work on this issue 🙌🏻 . It's always a pleasure to collaborate with you!


add ability to use System.Diagnostics.Activity

to simplify event tracing Microsoft introduce Activity
this commit allow us to enable activities on MT level using DiagnosticSource

do not merge it now, found an issue
we have to extract activity from context to prevent activity mess

fixed, now it is ready for merge

I'll get this in today.


Change output requirements

Currently we have our API linked up to integromat.com, they measure service costs based on operations and data (MB)
Been testing out Screeenly and we only need the temp URL, would it be possible to select which outputs are required, ie
URL, base64, base64_raw.
Thus change the size of the received data
Secondly, the ability to resize, adjust compress of the PNG as its outputted would be amazing :)

In addition, ability to Crop the output image

top x pxels / x%
bottom x pxels / x%
left x pxels / x%
right x pxels / x%

@TornMarketing Thanks for the feedback. I'm currently working on the last, finishing touches of v3 of screeenly. That new version no longer returns base64 or base64_raw; just the URL to the image. That solves the output size ;)
In addition, you will be able to crop an image in exactly the way you mentioned (top, bottom, left, right).
However, for the start, v3 won't be open source. It will be a hosted SaaS which requires users to subscribe to one of our many plans. (I might also add a credit system, so you don't have recurring costs and only pay for what you use)
The plan is to maybe port some features back to the current open source version, or make v3 open source in the distant future. The goal with v3 for me is, to generate a small bit of revenue, to offset the server costs for the last 6 years 😅
I will mark your issue as a feature here.

If you're self hosting screeenly and you want to remove the base64-output, you can remove the following 2 lines from the code to make this work.
https://github.com/stefanzweifel/screeenly/blob/master/modules/Screeenly/Http/Controllers/Api/v1/ScreenshotController.php#L47-L48

@TornMarketing Thanks for the feedback. I'm currently working on the last, finishing touches of v3 of screeenly. That new version no longer returns base64 or base64_raw; just the URL to the image. That solves the output size ;)
In addition, you will be able to crop an image in exactly the way you mentioned (top, bottom, left, right).
However, for the start, v3 won't be open source. It will be a hosted SaaS which requires users to subscribe to one of our many plans. (I might also add a credit system, so you don't have recurring costs and only pay for what you use)
The plan is to maybe port some features back to the current open source version, or make v3 open source in the distant future. The goal with v3 for me is, to generate a small bit of revenue, to offset the server costs for the last 6 years 😅
I will mark your issue as a feature here.

Hey mate,
Managed service with a credit per unit sounds good (assuming its economical),
Be keen tho to see the 500 errors be resolved which I have experienced a few today from the testing environment.
Unsure if that server or software related tho

title	An error accoured
message	An internal error accoured.
errorCollection
status	500
detail	The process "PATH=$PATH:/usr/local/bin NODE_PATH=npm root -g node '/home/forge/screeenly.com/vendor/spatie/browsershot/src/../bin/browser.js' '{"url":"https://domain.com","action":"screenshot","options":{"type":"png","path":"/home/forge/screeenly.com/storage/app/public/5f14466c8b6a6_LmjFpckTRooHieUIPuANnVoudjU3mB.png","args":[],"viewport":{"width":1920,"height":1080},"ignoreHttpsErrors":true,"timeout":30000,"delay":10000,"userAgent":"screeenly-bot 2.0"}}'" exceeded the timeout of 30 seconds.

The pricing structure is economical :)
It seem‘s the error isn‘t properly handled by the app itself.  The chrome browser timed out before creating a screenshot.
One of the many things I would like to fix.

ahh so its an outstanding issue, so going to be a little longer than a day to fix haha.
ok, I might tap out and find something that can help me out today

@TornMarketing This is often not a reproducable issue. Most of the time a subsequent request to the API will result in a correct screenshot being generated.
Like with the browsers we use to browse the web, sometimes things break and a simple page refresh works wonders. 😅
But the goal is to make the API response more useful, so that you as a consumer of the API now what do to next.


Question - can TACCO examine regions of a Visium slide

I am analysing a 10x Visium dataset and I would like to examine 2 different areas or regions of the same Visium slide (image below). The data is from a mouse colon and some of the tissue is tumour and some is not. We would like to examine and compare the spots / genes in both regions (tumour vs non).
Can TACCO assist with this task?
Thanks

Yes, it can.
It seems that you have the two regions already annotated. Then you could use tacco.tools.enrichments to get lists of potentially interesting genes for the two regions and after that tacco.tools.setup_goa_analysis and tacco.tools.run_goa_analysis to get pointers about potentially interesting biology that is going on.
You could also check out the examples in particular slideseq_mouse_colon for additional ideas about what analyses you might want to do with your data. While there are no Visium examples in the documentation, yet, the Slide-Seq based examples should be informative, as they also cover the analysis of spatial expression data on pixels.
I hope this helps!

Ok, but the regions I have annotated is just a drawing - drawn on by a pathologist. Can I input co-ordinates of those areas in the enrichments function? thanks

Not in the enrichments function.
Making drawings machine-readable is nothing which tacco can help you with. But as you suggested using coordinates, which sounds quite manual anyway: You could identify a few "seed" observations via their coordinates, mark them manually in an obs column of your Anndata object and fill the remaining observations using the spatially nearest "seed" observations with tacco.tools.fill_regions, basically expanding the annotation manually with a Voronoi diagram of the number of "seed" observations.
But as it works with regular Anndata objects, you can use your favorite method to attach this information to the Visium dataset. As soon as you have regions annotated in the dataset, you can use them for enrichment.
Alternatively you can create regions data-driven instead of pathologist-driven using the tacco.tools.find_regions.


EditText with text layout.

Migrate EditText draw and metters for TextLayout a like TextView.
That allow:

Break text.
Gravity.

Implemented in (a7ce7ba99a21ffb6475c4873b03ce2d3b169dbc8)


Merge quidel flu and quidel covid indicators

They share substantial functionality.

Closed by https://github.com/cmu-delphi/covidcast-indicators/pull/277#issue-487681886


AuthGuard should ensure both ends are authenticated

Only the 'Connect To Server' screen #24 should be available if the server is not authenticated. The rest of the application requires both the frontend and the backend to be authenticated.

I've been working on this one today, I should have PR ready sometimes tomorrow.


Collect and report polyX trim statistics.

Count reads trimmed and bases removed, and add to JSON report (totals and per base). Also a minor tweak to the Makefile to allow modifying compiler settings.

Sorry, I didn't notice this PR.
I would like to merge it, but it has conflicts now.
Could you please resolve the conflicts?

Should merge now.


Allowing for resolvers to return multiple errors to errorbuilder

Attempting to fix #141 by allowing you to pass an error that includes an Errors() function.
Maybe not the nicest solution as it requires a lot of work from the consumer's point of view, but this gets people unblocked in the meantime.
In the future, I'd want to see the ErrorBuilderor even the graphql.Response opened up to some kind of formatter somehow.

Closing in favour of #186. Let me know if I've missed anything.


mockWithCallback: improve types for request handler

Please rebase so that the pipeline can run correctly and this PR can be merged

This has been fixed in another code change, so closing here.

I think you haven't pulled the latest changes into your fork, see here: https://github.com/mock-server/mockserver-client-node/blob/master/mockServerClient.d.ts#L36


feat(server): ack after response

Currently there are issues with message acking multiple times in the server, still working on it to fix it, do not merge this branch yet

Aside from the e2e test will fail when you run it all at once, the core functionality is ready to be reviewed and merged now

everything for the tests are fixed now, should be able to run the tests all at once fine


Make codebase pycodestyle compliant

Right now, there are a handful of changes that need to be done.
Check this out :

Hi.Does this mean making the code PEP8 compliant?

@andela-jngatia I believe pycodestyle was just renamed from PEP8.
If either of you would like to make those changes, I'd be happy to merge a pull request for it. Otherwise, thank you. I can take a look and make those changes.

@mattgd, I have made a PR (#5). Please review.


[BUG] Maybe disambiguate variable names in Scatter pop-up

For example, both variables are called "Incremental Count", but one is covid19 cases vs. deaths.

With the new tree widget, this is no longer a problem


[BUG] The beanie is off on mobile browsers,... and in the downloaded svg

Hi, this is a really awesome project! Thanks for putting it out here!
I'm using your this library in https://epic-notes.vercel.app/react/advanced-hooks/4
And I noticed two bugs.
1. The beanie is off in the downloaded svg

2. The beanie is also slightly off on mobile (iphone, safari, chrome, firefox)

(I'm using in on a react project) But it's okay on the web browser.
Just thought you should know! Thanks!

Hi @mithi,
I don't see this issue on Windows and Android, so I suspect an iOS issue with some of the SVG properties use.
Thanks for letting me know, I'll investigate on iPhone!


Dart SDK shipped with Flutter exposes statically linked libc++ on Linux

The Linux Flutter SDK contains a Dart SDK which exposes symbols of the statically linked libc++ library. This is a problem when calling other libraries with C++ implementations with incompatible C++ runtimes through FFI. The standalone Dart SDK already does not expose those symbols.
This is an issue similar to this one.
Steps to Reproduce

On a Linux machine, install the Flutter SDK and the Dart SDK.

Inspect the dart binary in the Flutter SDK for the existence of a symbol from the C++ ABI:

objdump -T ~/lib/flutter/stable/bin/cache/dart-sdk/bin/dart | grep __dynamic_cast
0000000001d7a0c0 g    DF .text<PHONE_NUMBER>0000f4  Base        __dynamic_cast

Inspect the dart binary in the Dart SDK for the existence of a symbol from the C++ ABI:

objdump -T /usr/lib/dart/bin/dart | grep __dynamic_cast

Logs

[✓] Flutter (Channel stable, 2.2.3, on Linux, locale en_US.UTF-8)
    • Flutter version 2.2.3 at /home/gabriel/lib/flutter/stable
    • Framework revision f4abaa0735 (9 days ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/gabriel/Android/Sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /home/gabriel/Android/Sdk
    • Java binary at: /home/gabriel/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7199119/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 4.1)
    • Android Studio at /home/gabriel/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7199119
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at /home/gabriel/.local/share/JetBrains/Toolbox/apps/IDEA-C/ch-0/203.7717.56
    • Flutter plugin version 58.0.2
    • Dart plugin version 203.8292

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Linux
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

• No issues found!

Hi @blaugold

Inspect the dart binary in the Flutter SDK for the existence of a symbol from the C++ ABI:

I am not familiar with this process, can you please tell me how to inspect this and which file exactly?
Thnak you

@TahaTesser
objdump -T <some binary> prints the symbol table of a given binary file and grep __dynamic_cast filters for one of the symbols which should not be exposed. Inside the Flutter SDK the dart tool can be found at bin/cache/dart-sdk/bin/dart.
So, the overall command line to execute is objdump -T $FLUTTER_HOME/bin/cache/dart-sdk/bin/dart | grep __dynamic_cast, where $FLUTTER_HOME is the location of the Flutter SDK on your machine.
Within the Dart SDK, the dart tool is at bin/dart.

Hi @blaugold
Thanks for the details,
When trying Flutter's dart
taha@pop-os:~/Code/dart-sdk/bin$ objdump -T /home/taha/Code/flutter_stable/bin/cache/dart-sdk/bin/dart | grep _dynamic_cast
0000000001d7a0c0 g    DF .text<PHONE_NUMBER>0000f4  Base        __dynamic_cast
taha@pop-os:~/Code/dart-sdk/bin$

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on Linux, locale en_US.UTF-8)
    • Flutter version 2.2.3 at /home/taha/Code/flutter_stable
    • Framework revision f4abaa0735 (11 days ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/taha/Code/android-sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_SDK_ROOT = /home/taha/Code/android-sdk
    • Java binary at: /home/taha/Code/android-studio-preview/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 12.0.0-3ubuntu1~21.04.1
    • cmake version 3.18.4
    • ninja version 1.10.1
    • pkg-config version 0.29.2

[✓] Android Studio (version 4.2)
    • Android Studio at /home/taha/Code/android-studio
    • Flutter plugin version 58.0.1
    • Dart plugin version 202.8531
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/taha/Code/android-studio-preview
    • Flutter plugin version 58.0.2
    • Dart plugin version 203.8292
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.57.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Linux
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

• No issues found

taha@pop-os:~$ objdump -T /home/taha/Code/flutter_master/bin/cache/dart-sdk/bin/dart | grep _dynamic_cast
0000000001f899e0 g    DF .text<PHONE_NUMBER>0000f4  Base        __dynamic_cast
taha@pop-os:~$

flutter doctor -v
[✓] Flutter (Channel master, 2.4.0-1.0.pre.200, on Pop!_OS 21.04
    5.11.0-7620-generic, locale en_US.UTF-8)
    • Flutter version 2.4.0-1.0.pre.200 at /home/taha/Code/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 81a85b8939 (5 hours ago), 2021-07-12 22:01:02 -0400
    • Engine revision a984a833ba
    • Dart version 2.14.0 (build 2.14.0-301.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/taha/Code/android-sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_SDK_ROOT = /home/taha/Code/android-sdk
    • Java binary at: /home/taha/Code/android-studio-preview/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 12.0.0-3ubuntu1~21.04.1
    • cmake version 3.18.4
    • ninja version 1.10.1
    • pkg-config version 0.29.2

[✓] Android Studio (version 4.2)
    • Android Studio at /home/taha/Code/android-studio
    • Flutter plugin version 58.0.1
    • Dart plugin version 202.8531
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/taha/Code/android-studio-preview
    • Flutter plugin version 58.0.2
    • Dart plugin version 203.8292
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.57.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Pop!_OS 21.04
      5.11.0-7620-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

• No issues found!

and stable Dart SDK (nothing prints)
taha@pop-os:~/Code/dart-sdk/bin$ objdump -T /home/taha/Code/dart-sdk/bin/dart | grep _dynamic_cast
taha@pop-os:~/Code/dart-sdk/bin$

dart --version
Dart SDK version: 2.13.4 (stable) (Wed Jun 23 13:08:41 2021 +0200) on "linux_x64"

Starting with the 2.5 beta of Flutter, the shipped Dart SDK is the same as the standalone Dart SDK.


Match IDs?

Can commitlint validate numerical IDs?
 There is a PR taking a stab at it: https://github.com/marionebl/commitlint/pull/76, where I added an outline how this could work:
// commitlint.config.js
module.exports = {
  parserPreset: './parser-preset',
  rules: {
     'references-empty': [2, 'never'],
     // extended use case, check if id is present
     'references-enum': getIssueIds().then((ids) => [2, 'always', ids])
  }
}

// parser-preset
module.exports = {
  paserOpts: {
    issuePrefixes: ['PRJ-', 'MFB-']
  }
};

@AustinMatherne Would the feature match your use case?

What is the value of ids?  Is it a RegEx, or an array of all possible IDs?
I'm matching against thousands of numerical IDs. Generating an array of them is easy enough, but seems less than ideal.
Thanks!

This would work in two steps:

given references-empty:  [2, 'never'], commits without issue id would fail as outlined in your examples
optionally, given 'references-enum': [2, 'always', someArray] you could fetch the actual list of available/allowed issue ids (say by fetching them from JIRA) and check if the given ID is present

I'd like to keep parsing/regexp matching out of commitlint. If the current conventional-commits-parser capabilities are not enough to distinguish between valid and invalid references we can work on improving it.

In theory validating the ID against a real Jira story would be nice, but there's no way my team would accept an online requirement in order to make commits. Instead I'd have to create an array for every value between "0" and at least "99999".

@AustinMatherne  I created a plugin and a config special for JIRA commit messages style commitlint-jira  ;) I think this will be useful for you :)


Tabular: Added transform_labels function to TabularPredictor

Issue #, if available:
#428, #432
Description of changes:
Added transform_labels function to TabularPredictor
Now users can also transform the labels of the data to the internal representation and back, including the probabilities.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-435-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-435/1/index.html


cannot import name 'pad' from 'skimage.util'

Hi! In colab I noticed this error while downloading from demo import load_checkpoints
Making pip install -r requirements.txt or just !pip install -U scikit-image==0.14.2 did not help. As far as I know we should use np.pad instead of skimage.util.pad in file augmentation.py, and this issue will be fixed.
If not, maybe you know how try demo in colab different way?

Hi, it worked for me using after using this, !pip install -U scikit-image==0.18.0

i have the same problem

Hi, it worked for me using after using this, !pip install -U scikit-image==0.18.0

how?
please explain how did you fix it

just change pad(...) to numpy.pad(...)

Hi, it worked for me using after using this, !pip install -U scikit-image==0.18.0

how?
please explain how did you fix it

For me it was just a dependency issue I guess, so I just downloaded the previous scikit-image version.

@AliaksandrSiarohin Fixed by #565.


Update lab 1 content

Module: 00
Lab/Demo: 01-Explore-Azure-Synapse
Fixes # .
Changes proposed in this pull request:

0568f78fd7970d3e009dd4949e882f8a51776fec the Develop page isn't empty after running the setup.ps1 script. It is pre-populated with the ingest-data KQL script.

5bc92a3c80a1bd260b79f7476d6bbbaf538d57bc I'm not sure what the "Product Files hierarchy" refers to. "Azure Data Lake Storage Gen 2 hierarchy" seems like clearer instructions.

88cfda169d57332384cdd8169aa7a13c76d082c2 fix a capitalization typo

@Thanks @markpatterson27
The KQL file issue should have already been resolved - re-clone the repo before running setup (we had to remove the step to upload it because of an intermittent issue with the API)
I updated the description of the container in the Data tab.


ce6931e0e51096c5b6f1fc23ac939fb95ee70bc1 buffer leak in EpollSocketCh…

…annelTest
Motivation:
ce6931e0e51096c5b6f1fc23ac939fb95ee70bc1 introduced a buffer leak in EpollSocketChannelTest.
Modifications:

Fix buffer leak

Result:
No more buffer leak.

@normanmaurer - PTAL

@Scottmitch looks good.. you can just cherry-pick this as this fix a regression in an already approved pr

@Scottmitch ship it

4.1 (a55df36) master (386c42b)


Save and load from local store

Resolves https://github.com/NASA-IMPACT/nasa-apt-frontend/issues/340

I implemented the functionality into a React component LocalStore, which is added to each of the Formik instances of the editor. Placing the component inside Formik allows us to listen to value changes in any of the form's fields and act accordingly.
When a form is initialised, we look for a value in local storage and merge with the values taken from the form state, with values from local storage taking precedence.

If the values from local storage are for a different step, we take the original form values without merging and we clear the local storage. This is in line with the current behaviour where you lose changes when moving to another step without saving.

If the current form is dirty, ie. values have changed, then we save the form values to local storage.
If the current form is not dirty, ie. no values have changed or the form has been saved, then we clear any values from local storage.
Each stored value expires after 15 minutes. This should be enough time to recover from an error or accidental reload. Whenever the page is reloaded, the expiry is extended by another 15 minutes, which is expected since we want to give editors time to continue editing and to save their changes.
I encapsulated any interaction with local storage into it's own class LocalAtbdStorage so the React component does need to deal with constructing the right keys, unpacking values and timing out stored values.

@danielfdsilva I made a couple of changes following your comments:

We're now storing data for each step individually and never automatically delete and data from local storage, unless the data is expired
I added a toast that is displayed whenever data was found in local store, prompting the user to either restore or discard the data. Restoring will populate the form with data from local store, discarding will remove the data for the current step from local store.
I'm also checking if the data from the API has seen an updating since the local store was created and add an extra warning to the toast that the newer data will be overwritten

Perhaps this could be solved by implementing some step based field diffs to check this case, but I don't think it is worth it but wanted to make a note. The main use case will be to recover from page errors, so this is more than enough.

I agree, this is something we should tackle later if we find this is necessary


🐛 [Crashlytics] Adding "firebaseCrashlytics" section to "build.gradle" file breaks the build

Bug report
Adding "firebaseCrashlytics" section to "android/app/build.gradle" causes application build error.
Steps to reproduce
Steps to reproduce the behavior:

Add "firebaseCrashlytics" section to "android/app/build.gradle" as follows:

firebaseCrashlytics {
     mappingFileUploadEnabled true
}

Try to build it for Android:

flutter build appbundle

and it fails:
> flutter build appbundle

💪 Building with sound null safety 💪

FAILURE: Build failed with an exception.

* Where:
Build file '/private/tmp/flutterfire/packages/firebase_crashlytics/firebase_crashlytics/example/android/app/build.gradle' line: 27

* What went wrong:
A problem occurred evaluating project ':app'.
> No signature of method: build_9bpps43ypp26ulsy6o9ezqbnf.android() is applicable for argument types: (build_9bpps43ypp26ulsy6o9ezqbnf$_run_closure2) values: [build

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3s
Running Gradle task 'bundleRelease'...                              5,3s
Gradle task bundleRelease failed with exit code 1

Expected behavior
The app is built
Sample project
https://github.com/4ntoine/flutterfire/tree/crashlytics-issue

Additional context
In the documentation the "apply" section must be at the bottom of the file:
// This section must appear at the bottom of the file
apply plugin: 'com.google.gms.google-services'
apply plugin: 'com.google.firebase.crashlytics'

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
> flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 3.1.0-0.0.pre.1354, on macOS 11.6 20G165 darwin-x64, locale ru-RU)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[!] Xcode - develop for iOS and macOS (Xcode 13.0)
    ! CocoaPods 1.10.2 out of date (1.11.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[✓] Android Studio (version 2021.1)
[✓] Android Studio (version 3.1)
[✓] Android Studio (version 4.2)
[✓] IntelliJ IDEA Community Edition (version 2021.2.4)
[✓] IntelliJ IDEA Community Edition (version 2019.1)
[✓] IntelliJ IDEA Community Edition (version 2019.3.1)
[✓] VS Code (version 1.68.1)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
> flutter pub deps -- --style=compact
Dart SDK 2.18.0-216.0.dev
Flutter SDK 3.1.0-0.0.pre.1354
firebase_crashlytics_example 0.0.0

dependencies:
- firebase_analytics 9.1.10 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_core 1.18.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.8.2 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]

dependency overrides:
- firebase_core 1.18.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_core_platform_interface 4.4.1 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 1.6.5 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics 2.8.2 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_crashlytics_platform_interface 3.2.8 [collection firebase_core flutter meta plugin_platform_interface]

transitive dependencies:
- async 2.9.0 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.2.1
- clock 1.1.1
- collection 1.16.0
- fake_async 1.3.1 [clock collection]
- firebase_analytics_platform_interface 3.1.8 [firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.4.0+15 [firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection matcher material_color_utilities m
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- js 0.6.4
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.5
- meta 1.8.0
- path 1.8.2
- plugin_platform_interface 2.1.2 [meta]
- sky_engine 0.0.99
- source_span 1.9.0 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.1 [source_span]
- term_glyph 1.2.1
- test_api 0.4.9 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- vector_math 2.1.2

A fix/workaround is to move the following:
apply plugin: 'com.google.gms.google-services'
apply plugin: 'com.google.firebase.crashlytics'

before "android" section (to the top of the file):
> git diff
diff --git a/packages/firebase_crashlytics/firebase_crashlytics/example/android/app/build.gradle b/packages/firebase_crashlytics/firebase_crashlytics/example/andrd/
index 06f614f0..9d5dabc9 100644
--- a/packages/firebase_crashlytics/firebase_crashlytics/example/android/app/build.gradle
+++ b/packages/firebase_crashlytics/firebase_crashlytics/example/android/app/build.gradle
@@ -23,6 +23,8 @@ if (flutterVersionName == null) {

 apply plugin: 'com.android.application'
 apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
+apply plugin: 'com.google.gms.google-services'
+apply plugin: 'com.google.firebase.crashlytics'

 android {
     compileSdkVersion 31
@@ -62,7 +64,4 @@ dependencies {
     androidTestImplementation 'androidx.test:runner:1.2.0'
     androidTestImplementation 'androidx.test:rules:1.2.0'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
-}
-
-apply plugin: 'com.google.gms.google-services'
-apply plugin: 'com.google.firebase.crashlytics'
\ No newline at end of file
+}
\ No newline at end of file

But currently i'm having not deobfuscated stacktraces (issue which is closed but not solved actually) and i'm not sure whether it's the reason.

@darshankawar see "Additional context" section link

Thanks for the update. I see same behavior after adding as mentioned in the document:

 console error log

dhs@Dhss-MacBook-Pro example % flutter build appbundle

💪 Building with sound null safety 💪

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/dhs/Documents/NCFlutter/flutterfire/packages/firebase_crashlytics/firebase_crashlytics/example/android/app/build.gradle' line: 27

* What went wrong:
A problem occurred evaluating project ':app'.
> No signature of method: build_b36g7rvkos80zmfmtx5x45gsd.android() is applicable for argument types: (build_b36g7rvkos80zmfmtx5x45gsd$_run_closure2) values: [build_b36g7rvkos80zmfmtx5x45gsd$_run_closure2@11770f81]

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 754ms
Running Gradle task 'bundleRelease'...                           1,345ms
Gradle task bundleRelease failed with exit code 1
dhs@Dhss-MacBook-Pro example %

https://firebase.google.com/docs/crashlytics/get-deobfuscated-reports?platform=flutter
https://firebase.google.com/docs/crashlytics/get-deobfuscated-reports?platform=android

Hey @4ntoine, are you aiming to de-obfuscate stack traces on your Firebase console? I was able to do it without editing the build.gradle file. See this comment for context.

Closing out as it is not needed to have this property set in the build.gradle as illustrated here.


Enable additional linters: bodyclose, noctx, dup, forbidigo,godot,gomnd

Description
This PR enables new linters: ~bodyclose~, noctx, dup, forbidigo,godot,gomnd.
bodyclose has some false positives, and I decided to not include it.
How can this be tested?
unit-tests, CI
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (4c2eebc) 65.19% compared to head (2085d2a) 65.19%.
Report is 2 commits behind head on main.

Files
Patch %
Lines

pkg/clients/edgeconnect/client.go
58.82%
5 Missing and 2 partials :warning:

cmd/support_archive/builder.go
0.00%
2 Missing :warning:

pkg/api/v1beta1/dynakube/properties.go
0.00%
2 Missing :warning:

pkg/clients/dynatrace/oneagent_connection_info.go
0.00%
0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2642   +/-   ##
=======================================
  Coverage   65.19%   65.19%
=======================================
  Files         252      252
  Lines       16518    16542   +24
=======================================
+ Hits        10769    10785   +16
- Misses       4915     4921    +6
- Partials      834      836    +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


 stand for?
Thank you :)

Hi @KuenzelIT
It's short of serial(serial number)
What do you prefer to be there?

I'm used to having the "id" there. But it's fine, I just didn't get it. :)


Hide version

It would be cool if we could hide the version. This is a potential security risk if a public version number has a known security issue. Maybe only show the version to logged in users or administrators? Or remove it completely...
I would like to contribute a PR, but unfortunately I have no idea about Python.

I'm working on this, seems easy to implement using the .env itslef.


feat: env variables into rc file

Suggested here: https://github.com/DannyBen/bashly/discussions/542#discussioncomment-10212180
Read the environment variables from a .rc file
This feat will be added to the roadmap.

Implemented in #6


onLongPress are not working properly in nested Text components

Description
What I did:

Install AwesomeProject
removed the default text
make a new Text component inside another Text component as follow:

export default class AwesomeProject extends Component {
  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.instructions}>
          <Text style={styles.welcome} onPress={() => Alert.alert('It\'s a short Press, not long one')} onLongPress={() => Alert.alert('Long Press')}>
            Click Here
          </Text>
        </Text>
      </View>
    );
  }
}

Run the app in iPhone 7 (must be with 3DTouch)
Long press on 'Click Here'

Expected result:
Open an alert.
Actual result:
Do nothing
Reproduction
The bug aren't reproduce in simulator, only in real device with 3DTouch
Sample App
Additional Information

React Native version: 0.38+
Platform: iOS (3DTouch supported devices)

Bump. Having the same issue and its causing a lot of pain for me. I've spent a few days now trying to fix this and I don't have a solution.
RN 0.40, iPhone 7

https://github.com/facebook/react-native/issues/11462

@evollu has a fix with https://github.com/facebook/react-native/pull/11530. I made these changes locally and nested text onPress and onLongPress fires correctly.
Still waiting on this merge into master. I'd say this is a pretty critical bug for anyone wanting to use links in nested text, which should be a lot of people.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/onlongpress-are-not-working-properly-in-nested-text-components


Emissions Regression Testing: Import and Data Types

[ ] Perform more granular testing of the emissions import module with focusing on more edge cases

EmissionsImportsForAllDTOs.zip
The attached file has facilities, configurations, and quarters that if all are imported, then all of the emissions data are hit.


Supported RHEL version for Qualys extension

[Enter feedback here]
According to Qualys ref doc: up to RHEL 8.3 is supported (https://www.qualys.com/docs/qualys-cloud-agent-getting-started-guide.pdf)
However, this Microsoft reference doc is not updated (still showing upto RHEL 8.1 is supported).
Hence, can you please update supported RHEL version for Qualys extension?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4fdbbf80-92cd-d6b2-85fd-a830589a8ed9
Version Independent ID: d89d9eef-daed-636d-7414-0b15f3195734
Content: Security Center's integrated vulnerability assessment solution for Azure and hybrid machines
Content Source: articles/security-center/deploy-vulnerability-assessment-vm.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@sreza-msft Thank you for sharing this info . We will investigate and update the thread.

Hi @sreza-msft, thanks for the feedback and for taking the time to help us improve the docs.
I've made this minor change and the update should go live within 24hrs. I'm going to close this issue, but feel free to comment again here or open a new one if you have additional requests.
This documentation page is going to get completely refreshed in the coming weeks, so stay tuned!
#please-close


Hotel reservation support for kubernetes

As there is a need for supporting Kubernetes. I've made some changes to use the DNS in Kubernetes. Also I added deployments for kubernetes and a build script for docker images. Currently all deployments are using my personal repository.
Maybe it can close #69 .

https://github.com/delimitrou/DeathStarBench/issues/69#issuecomment-734474007
The issue mentioned in the above link is being encountered by me for social network .
Is there anyway we can use kubernetes for social network ?

https://github.com/delimitrou/DeathStarBench/issues/69#issuecomment-734474007
The issue mentioned in the above link is being encountered by me for social network .
Is there anyway we can use kubernetes for social network ?

I'm not sure about this. But I guess you can use the helm chart in social network for deploying on kubernetes.
checkout here

I'm not really sure about the recent updates. You can open an issue or ask about it using the email provided in the readme. Also, I found this old version which has the support for k8s. https://github.com/delimitrou/DeathStarBench/tree/6970bda1235bcc74ee798d1e8fef97bab6c902a2/socialNetwork

Can you please explain this part of  README given for older version
" Set the resolver to be the FQDN of the core-dns or kube-dns service of your cluster in /socialNetwork/nginx-web-server/conf/nginx-k8s.conf and /socialNetwork/media-frontend/conf/nginx-k8s.conf  "

If you look at the following line:

I got rid of the above error by removing .conf extension in both nginx-thrift and media-frontend file.
Now theses pods are running but still i have the same issue that i had with the new-version of Deathstarbench that is:
when i try
$ minikube -n social-network service --all
and see the URL of nginx-thrift ,media-frontend and jaegar-out
The URL for jaegar-out works properly and opens ups the jaeger UI
but when i try going to URL of nginx-thrift or media-frontend they show :
<IP_ADDRESS> refused to connect.
Please help.

I'm not sure about the error you are getting. I guess you should discuss it with the main contributors

Thank you for your help though.


Add config.Server option to expose metrics via expvar endpoints

We should create an flag in config.Server to tell Server implementations to expose metrics via JSON endpoints via expvar using the subpackage from go-metrics: https://godoc.org/github.com/rcrowley/go-metrics/exp
This will enable users to utilize metrics stacks based around 'pulling' data instead of just the 'push' style of Graphite.

This was resolved by #59 and the new config.Metrics configurations.


Use var for compatibility with Android 4.x

Hi!
Thanks for a great plugin! I just got a couple of user reports that our app started crashing on Android 4.3 and traced the error to the use of let in the JS code for this plugin. It seems that support for let and const was introduced in Android 5. While the user share for Android 4.x is declining there are still a lot of phones out there that cannot be upgraded further than that.
Would you consider reverting to using plain "var" as in this pull request?
All the best!
Johan

Thank you for your contribution!
Please install for now the dev version, see the installation procedure.
I'll publish a new version of the plugin in the near future.

Wow! That was quick :) Many thanks 🙏


Adding Collapsibility to ExpandableText

Adding ability and switch for ExpandableView to be collapsed by tapping on expanded text body.

Thanks @JThramer nice work! Looks good to me


HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate

Please check out the description of jira https://issues.apache.org/jira/browse/HDDS-5542

Thank you to investigate this issue @smengcl

In rare cases, applications will not seemingly trigger OzoneConfiguration#loadDefaults

Can you please explain how this "rare" cases can happen?
As far as I see, the loadDefaults is part of both the constructors with one exception:
    if (!(conf instanceof OzoneConfiguration)) {
       loadDefaults();
    }

My main concern is this part. IF (!) the first line here false in these rare cases, it's not only a problem with ozone-site.xml but a problem with all the defaults coming from the fragmented XML files. Therefore, the patch couldn't fix all the problems: some defaults will be missing.
Can you please check if this is case (as far as I understood the problem can be reproducible). We may need to fix the condition itself instead of adding the config to the defaults...

/pending Can you please explain how this "rare" cases can happen?


slurm 22.05 support and multiple-slurmd

Version updates

update some versions for openssl, tini and python
update slurm to 22.05

Multiple node support
Compiles slurm with --multiple-slurmd. Without this option, you cannot correctly operate multiple nodes on a single host. Multiple nodes were previously configured in the slurm.conf, but this was always yielding lots of errors (even though it appeared to be working when requesting the nodes). But doing something like srun in a multi-node job would always fail - which now works correctly with --multiple-slurmd.
Therefore supervisord.conf has also been adapted to start, by default, 3 instances of slurmds.
Changes is the entrypoint file

removed the check_port_status thing. Don't really see a specific use case for it.
remove the check_running_status function. when doing supervisorctl start, it will already report whether the service has started or failed. No need to repeatedly spam the state.

Other changes
gres.conf and the GPUs attached to the nodes have been removed for now - same reason as above with the multiple nodes - You can request it, but it will probably yield some errors, since there is no GPU device file available (maybe need to do some more testing and perhaps could add it back later)
cgroup.conf has been added, with explicity setting the cgroup version to be used to v1. Without it, slurm did not want to start.
Also enable config_overrides in the slurm.conf for the slurmd, so we can declare an arbitrary amount of resources for the node, e.g 56 CPUs and 512GB of RAM, even though it isn't physically available.

Also enable config_overrides in the slurm.conf for the slurmd, so we can declare an arbitrary amount of resources for the node, e.g 56 CPUs and 512GB of RAM, even though it isn't physically available.

@tazend thank you for this PR!  We are testing it for our use case.  Would you be so kind to also add to README.md some instructions on how to make use of parametrisations you have added and to provide those config_overrides when needed?

@tazend would you mind updating the README in a follow up PR? Thanks!

@tazend I'm happy to give an unfamiliar-eyes-review for a README update, I'm excited to try out config_overrides :)

Hi @giovtorres,
yeah I will try to update the README soon


Event log compaction

This issue is to discuss event log growth currently being unbounded. In order prevent OOM errors, the event log must be rolled up with some regularity.
etcd's approach to this problem appears to be compacting based on a combination of max allowed entries and elapsed time - https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/maintenance.md#raft-log-retention. Each of these approaches seem desirable to cover most situations.
Initial thoughts on possible options would be:

snapshot at max_sequence_id and delete from there back
snapshot at x events back and delete from there back
delete back from the sequence id on the last snapshot

I propose we implement each of these approaches with sane defaults. Users can adjust these configuration options and pick a strategy that best suits their needs.

To document a few things we discussed out of band, I do think that compaction is essential to the long term success of an event sourced application.
Your proposal for snapshotting periodically seems reasonable and fits into the GenServer approach that we have.
Deleting events should definitely be disabled by default, but having an operation that allows for it both in the store and more importantly on the aggregate is a good idea as well.

Developing a solution for dealing with max_sequence_id or even warning when that's getting close is probably a separate concern since we're actually talking about the max for the integer type in postgres.


Convert current project into lerna mono repo

As per our conversation convert this project into a monorepo in preparation of adding new packages.

Pull Request Test Coverage Report for Build 98

19 of 24 (79.17%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.364%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/measured-core/lib/Collection.js
5
10
50.0%

Totals

Change from base Build 96:
0.0%

Covered Lines:
358

Relevant Lines:
416

💛  - Coveralls


sanitize fields for android key and keystore passwords

What do you think about sanitizing the passwords in the step log??
https://github.com/bitrise-community/steps-generate-cordova-build-configuration/blob/047eb7987d21aa9ddc4b4e6de3d8618197c7a50a/main.go#L65
https://github.com/bitrise-community/steps-generate-cordova-build-configuration/blob/047eb7987d21aa9ddc4b4e6de3d8618197c7a50a/main.go#L218

Good question @blackjid
We already discussed this a bit internally but will bring it up again. The main reason we print the values there is mainly for debugging as based on the support tickets we received typos in passwords and similar are quite a frequent issue unfortunately.
What do you think about an additional option for the step? Something like "Don't print sensitive configs", which would be turned off by default so that during the configuration it's easier to debug issues, but once it works you could turn it on and remove the values from the logs?

In any case we'd be open to something like what I described above (an option to hide these debug infos); if anyone would have some time to send us a PR we'd be happy to review it ;)

hey sorry for the radio silence...  That sounds great...
What do you think going the other way around? Adding a "Debug" option which is turn off by default... and when turned off, all extra info is printed??  For me sound more logical that way, but I understand if that doesn't really cut it for solving your support problem.... let me know... I might be able to get a PR for this :)

We'll discuss it with the team, but I'd rather go with the opt-out (debug on by default) behaviour simply because we have to provide user support and it helps a lot to see which configs are actually / correctly provided and which ones are not (if any).


Milestone value doesn't appear in Firefox

Steps to reproduce in Firefox 74 with latest Refined GitHub (20.3.22):

Open an issue with a milestone set on a repo where you have edit access for milestones. For me it's https://github.com/jquery/jquery/issues/4453.
See that the milestone value doesn't show up. Only if you press the edit button you can see it on the list (see the screenshot).

The issue doesn't exist in Chrome 80 (with Refined GitHub 20.3.16) or in Firefox with the extension disabled.

Due to #2916

firstElementChild maybe...

Is there a simple workaround until a new version is published to the Chrome Store?

Yes... download from the latest master build and load it your self
Here is the direct link
https://github.com/sindresorhus/refined-github/suites/558475923/rtifaacts/3598735

That method works well, thanks! (The direct link didn't work due to a typo, but I found my way to it -- https://github.com/sindresorhus/refined-github/suites/558475923/artifacts/3598735)

This was published a while ago, 20.3.26 is on Chrome's store


GH-39122: [C++] [Parquet] FLBA reader reading preallocs and null count check

We can reserve memory before running loops in reading.
Also we can put check on zero null count, because this function can get it despite called Spaced
This code is run here if column descriptor HasSpacedValues
https://github.com/apache/arrow/blob/ef3797d997bd7a283ddf19055bc69441ae3e7a16/cpp/src/parquet/column_reader.cc#L1194-L1227
But this function does not look on actual values
https://github.com/apache/arrow/blob/ef3797d997bd7a283ddf19055bc69441ae3e7a16/cpp/src/parquet/column_reader.cc#L77-L93
In my case i have many optional decimal fields, but they can be null only in the beginning and the ending and i think that this scenario is not rare
For now i have a flamegraph of my reading looking like this(even I don't only have decimals in schema their parsing takes most of the time). And I optimize that part of FLBA record reader appends

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Closes: #39122

This looks ok to me.
Note this could probably be improved still. The silly part in this code is that we are generating a bitmap in valid_bits, then read it again bit by bit and append bit by bit into the final bitmap... The alternative would be to build the buffers separately (one BufferBuilder for the data and one TypedBufferBuilder<bool> for the null bitmap).

Also, did you run any benchmarks?

LGTM, waiting for Bitmap part finished

I opened #39124 for an alternative.

I did a quick-and-dirty benchmark on PLAIN-encoded uncompressed FLBA columns:

on git main: 465 MB/s
with this PR: 600 MB/s
with PR #39124: 715 MB/s

Since https://github.com/apache/arrow/pull/39124 is merged, would you mind close this pr?


fix countryCode typing in ProductCommon interface

This fixes a type in the ProductCommon interface.
As long as I have tested in IOS, the ProductCommon does not receive countryCodeIOS but countryCode and none in Android.

LGTM


NgxControlError Usage with FormGroup

This is what I'm doing for a FormGroup:
form = new FormGroup({
  name: new FormControl('', Validators.required),
  address: new FormGroup({
    city: new FormControl('', Validators.required),
  }),
});

<form [formGroup]="form">

    Name
    <input formControlName="name" />

      Name is required.

  <ng-container [formGroup]="address">

      City
      <input formControlName="name" />

        City is required.

  </ng-container>
</form>

I would suggest adding support for an id which would work similar to lodash.get or pass in an array:

  Name is required.

  City is required.

  City is required.

cc @RobbyRabbitman

Seems like a good addition 😄


Train, validation, and test

For now, we are only dividing in training and testing. Adding the validation set will give us "one more opportunity" to test the model in unseen data!
Suggestion:

We split in training and testing
The training, we split again (K times) and find the best hyper-parameters using these splits.
As soon as we have the best model here (and the K accuracies we collected from the Grid/Random search), we then test it again in the never seen training. We will have one more accuracy number here.
At the end, we have 10 accuracy numbers for the model tuning, and one for the unseen data.

Also: Unseen projects

@Dahny after our talk today:
We should:

Split the model in 80%-20%. (We discussed about doing it inside the _run_single_model, but that's not a good idea; we want all the different models to be trained on the same training and test set, so this needs to be done one layer before... Who calls this method?)
Call the search, with k=10. (From here on, all changes are in the _run_single_model method.
Extract the best estimator as well as its scores on the 10 folds.
Use the best estimator to predict results in the unseen test set.
Collect precision, recall, accuracy, and the confusion matrix (TP, TN, FP, FN)
Re-train the model on the full 100% dataset, so that we have a "production-ready" model.


Enhance plugin test

add Plugin class

@MartinHjelmare Here I want to import a imjoy module into tests, not sure how to do it.

It's not finished yet, we are going to use it for performing RPC calls and
also test the ImJoy apis.
I will continue tomorrow, but feel free make changes on this branch.
On Sat 1 Jun 2019 at 23:33, Martin Hjelmare<EMAIL_ADDRESS>wrote:

@MartinHjelmare commented on this pull request.
In tests/test_client.py
https://github.com/oeway/ImJoy-Engine/pull/63#discussion_r289618907:

   self._plugin_message_handler = []

   @sio.on("message_from_plugin_" + secret)

   async def on_message(msg):  # pylint:disable=unused-variable

       _LOGGER.info("Message from plugin: %s", msg)

       self.message_handler(msg)

async def _init(self, id, secret):

   class Options:

       id = id

       secret = secret

   opt = Options()

   self._site = PluginConnection(opt, client=self)

   # self._site.set_interface(self.imjoy_api)

What should happen here? Can we remove this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oeway/ImJoy-Engine/pull/63?email_source=notifications&email_token=AADU3S7H44OWETOYP6JLCHDPYLTIZA5CNFSM4HSBKLGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2KFI4A#pullrequestreview-244601968,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADU3SZ6KX6LEO33YHBO3KDPYLTIZANCNFSM4HSBKLGA
.

Note that only module carrying tests should be named test_*. We should name helper modules that contain fixture etc something else. We can also put all those into common.py if we don't fear clutter.

The conftest.py module is specifically named to enable global fixtures. Each package can have its own conftest.py module.

There is still issue in this PR, but I will just merge it for now.


Check if tweet is pinned

How would I check to see if a tweet is pinned?

Hi, @FroostySnoowman.
What api method you use? Actually is no flags about it any model now.
If you scrape user profiles, ids should be in chronological order expect 1-3 first which can be pinned. So you can write some code to detect this

Added in v0.13
import asyncio

from twscrape import API

async def main():
    api = API()

    async for doc in api.user_tweets(2244994945, limit=10):
        print(doc.url, doc.id in doc.user.pinnedIds)

if __name__ == "__main__":
    asyncio.run(main())


Release 4.0.0 incubating db bugfix

bugfix, as the code shows.
stackTrace:
2017-05-09 18:38:55 ERROR SendMessageThread_4 - do sync transfer other node, wait return, but failed, topic: BenchmarkTest tags: null client address: <IP_ADDRESS> 2017-05-09 18:38:55 WARN SendMessageThread_4 - putMessage not in lock eclipse time(ms)=1000, bodyLength=130 2017-05-09 18:38:55 WARN GroupTransferService - GroupTransferService service has exception. java.lang.NullPointerException: null         at org.apache.rocketmq.store.ha.HAService$GroupTransferService.doWaitTransfer(HAService.java:278) ~[rocketmq-store-4.1.0-incubating-SNAPSHOT.jar:4.1.0-incubating-SNAPSHOT]         at org.apache.rocketmq.store.ha.HAService$GroupTransferService.run(HAService.java:301) ~[rocketmq-store-4.1.0-incubating-SNAPSHOT.jar:4.1.0-incubating-SNAPSHOT]         at java.lang.Thread.run(Thread.java:745) [na:1.8.0_121]

This issue has been fixed in the develop branch, could you please double-check?


Azure Network Plugin is Hardcoded

Describe the bug: The azure network plugin is hardcoded in the AKS terraform module which does not permit the developer to choose kubenet instead of Azure VNets.
Additional context:
https://github.com/microsoft/bedrock/blob/d3614358bb7af51adf71119199d5d5950abdf139/cluster/azure/aks/main.tf#L35
Does this require updates to documentation?: Yes

Turning this into a feature request. @jmspring thoughts on allowing this?

It’s a relatively simple change.  I think we would need to look at what the impacts may be for things like load balancer a, ingress, etc


Added AutoFilter functionality.

This way, an autofilter header can be added to each sheet.

Added AutoFilter.


Add LibreX

Issue to track adding LibreX
@hnhx feel free to edit this chart and change anything you feel was misrepresented since I haven’t looked at this repo in awhile, also feel free to add LibreX and any areas it excels at otherwise I should be able to have this done in a week or so

Just added everything, lmk if there's anything I need to change


ng test much slower than ng build/serve

OS?
Linux (Ubuntu 16.04)
Versions.
@angular/cli: 1.0.0-rc.1
node: 6.10.0
os: linux x64
@angular/common: 2.4.9
@angular/compiler: 2.4.9
@angular/core: 2.4.9
@angular/forms: 2.4.9
@angular/http: 2.4.9
@angular/platform-browser: 2.4.9
@angular/platform-browser-dynamic: 2.4.9
@angular/router: 3.4.9
@angular/cli: 1.0.0-rc.1
@angular/compiler-cli: 2.4.9
Repro steps.
ng test is much slower than ng build and ng serve on both first build (60s vs 20s), and on retriggered builds (20s vs 1s).
It's spending alot of time on chunk asset optimization, so this looks like the previous problems with build performance discussed in #1980. Is it the same problem, and the fix for build and serve hasn't been implemented in test yet?
Also ng test seems to build the entire app-folder even though my tests are confined to pure functions in spec-files. This seems to go against what's defined in test.js, where only spec.ts-files are gathered. I've tried running ng test --build false, but it doesn't make a difference.
Mention any other details that might be useful.
If I run ng test --sourcemap false I get comparable performance, but this is puzzling to since build/serve runs with sourcemaps enabled...

Same here. In fact, after the first run, a save triggers a rebuild which gets stuck for even longer until webpack crashes with an out of memory error.

Tracking in https://github.com/angular/angular-cli/issues/5423.


Rename Adapter\Null to Adapter\NullAdapter

Fast! Thanks @mlocati
On Wed, Apr 6, 2016 at 6:16 AM, Michele Locati<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/concrete5/ZendQueue/pull/1
Commit Summary

Rename Adapter\Null to Adapter\NullAdapter

File Changes

R library/ZendQueue/Adapter/NullAdapter.php
https://github.com/concrete5/ZendQueue/pull/1/files#diff-0 (2)
M library/ZendQueue/Queue.php
https://github.com/concrete5/ZendQueue/pull/1/files#diff-1 (4)
M tests/ZendQueue/Adapter/NullTest.php
https://github.com/concrete5/ZendQueue/pull/1/files#diff-2 (2)
M tests/ZendQueue/MessageTest.php
https://github.com/concrete5/ZendQueue/pull/1/files#diff-3 (2)
M tests/ZendQueue/Queue2Test.php
https://github.com/concrete5/ZendQueue/pull/1/files#diff-4 (2)
M tests/ZendQueue/QueueBaseTest.php
https://github.com/concrete5/ZendQueue/pull/1/files#diff-5 (2)

Patch Links:

https://github.com/concrete5/ZendQueue/pull/1.patch
https://github.com/concrete5/ZendQueue/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/concrete5/ZendQueue/pull/1


About noise

Hello,
Thank you for sharing your code and making it accessible. I truly appreciate your efforts.
I’m a bit unclear about the use of noise in your implementation. Could you please explain what “noise” and “noise_mode” refer to and how they are used?
Thank you for your time and assistance.

Thank you for your interest.
noise_mode is a variable that was used during the model ideation process and will be deleted in a later version. You can ignore it and run, where this parser will be set to a default value.
We will also be adding a concept for noise in the future.


Remove Google intermediary links

The conversion added in lots of Google links. This change makes all links point to original sources.

LGTM

I've also just committed changes to remove t.co links as well.

This is a converter i used.  Needs to be in Word format first but took minor formatting afterwards.

@edent thanks for helping me tidy up :)


How to ignore some lclasses or choose some specific classes in the VOC dataset?

My own dataset is in the format of VOC. I want to train some specific classes(more than 1) and ignore other classes, how to do?

the tutorial
Adding New Dataset
last section maybe help


Feature Request: i cant find websocket kline api

Is your feature request related to a problem? Please describe.
I am a transaction developer and need to use the websocket api of coinbase kline but I can't find it. Can you help me?
Describe the solution you'd like
I'm sorry, there are a lot of abandoned warehouses, and I don't know where to ask
Describe alternatives you've considered
No response
Additional context
No response

Hi @keene-dalveytech, unfortunately this is not the correct place to ask, this repo is for the coinbase wallet sdk.  It sounds like you're looking for help with coinbase cloud apis (possibly this one?)
If you can't find what you're looking for there, you can try asking your question in the dev forums.


tcp exception enhancement

Thanks for cleaning things up, I'm not a huge fan of _variables though :)

This had errors for me so i have updated it and pushed. I am on VS2013 so may not be compatible with some of the code you use.

thanks!


[DatePicker][TimePicker] onChange function triggers too frequently

I'm trying to use the new feature in v4 of MUI that allows you to disable certain time ranges and I am facing an issue where the onChange function is triggering when it's not supposed to.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

I have a controlled component that uses the Time Picker and receives it's value and change function from a parent component. When I click to open the time picker, the modal opens up showing hours and minutes (as expected), when I click on a new hour, this change is instantly submitted and the onChange function runs and my component re-renders with the new value and the modal closes. The sane happens when I click to change from AM to PM, the onChange function runs re-rendering my component and closing the modal as a result. This actually happens for any time change.
Expected Behavior 🤔

What I expected to happen is something similar to the v3.2.10 release where the onChange function is  only triggered when the user submits their value by clicking the "ok" button, and is able to discard the pending changes they made by clicking the "cancel" button, meaning the onChange function would only run when the user has submitted their final time choice.
Steps to Reproduce 🕹

Steps:

Context 🔦

Your Environment 🌎

Tech
Version

@material-ui/core
v4.11.0

@material-ui/pickers
v4.0.0-alpha.12

React
16.13.1

Browser
Chrome

TypeScript

etc.

We got the same issue reported in https://github.com/mui-org/material-ui-pickers/issues/2101.

Encountered this issue while working on https://github.com/mui-org/material-ui/pull/24315. Can't say yet  if https://github.com/mui-org/material-ui/pull/24315 and this issue are two symptoms of the same problem but fixing this issue helps with https://github.com/mui-org/material-ui/pull/24315 so I'm looking into it now.

Encountered this issue while working on https://github.com/mui-org/material-ui/pull/24315. Can't say yet  if https://github.com/mui-org/material-ui/pull/24315 and this issue are two symptoms of the same problem but fixing this issue helps with https://github.com/mui-org/material-ui/pull/24315 so I'm looking into it now.

is there any plan to impl an onChangeComitted?


feat: generate relationship docs

Notes for Reviewers
This PR fixes #

Generate Relationship docs.

Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 65440ab5b0c4c8b6071bfc95b842fae5fdc2c0e9 at: https://660d362dd5d159cd4bac97f6--meshery-docs-preview.netlify.app


Publish TypeScript types for this package

Self-explanatory. It'd be nice to have types delivered natively with this package, but we could also go the DefinitelyTyped route, as well.

@blimmer I've taken a stab at adding the appropriate .d.ts files. VS Code's Intellisense is picking up the types nicely in my tests, but since I'm a bit new at combining JS code and TS types in a single package, would you mind referencing the branch from a project and seeing if it's behaving as you'd expect?
"dependencies": {
  "iiif-processor": "github:samvera/node-iiif#35-add-typescript-types"
}

Thanks! Looking good so far. I tried this on a repo using this package and found only one issue with the streamResolver.


Setting Google ReCaptcha data-size="compact"

😄 Is there any way to configure the compact display of google captcha - have site where it's overflowing on mobile....?
data-size="compact"
RE: https://developers.google.com/recaptcha/docs/display#render_param

Ignore me, I should really learn to read ❤

Actually maybe I spoke too soon.... I don't seem to be able to get the specific data size data atrribute to flow through.... anything I seem to be doing wrong below? (have cleared application, stache & static cache)

Hi @sjclark, thanks for reporting this one -- there was a special case for data-size which stopped the attribute from merging into the rendered tag.
Just released v1.9.1 which fixes this issue!

Thanks! I can't even remember the site I was trying to implement this in now! 😂


get_target_property() called with non-existent target "Sophus::Sophus"

CMake Error at CMakeLists.txt:101 (get_target_property):
get_target_property() called with non-existent target "Sophus::Sophus".
https://github.com/dongjing3309/minisam/issues/1
I have the same question,  which version of sophus is necessary ?  my sophus is a621ff2e56c56c839a6c40418d42c  .

when i do with readme, cmake with:

-- Search Dependency: Sophus
CMake Error at CMakeLists.txt:101 (get_target_property):
get_target_property() called with non-existent target "Sophus::Sophus".

when i ignore the line of 101 in CMakeLists.txt..   camke with error

[ 43%] Building CXX object minisam/CMakeFiles/minisam.dir/geometry/projection.cpp.o
In file included from /home/yhzhao/test_git/minisam/minisam/geometry/projection.cpp:9:0:
/home/yhzhao/test_git/minisam/minisam/geometry/projection.h:13:26: fatal error: sophus/se3.hpp: No such file or directory
compilation terminated.

According to my installation experience of minisam, Sophus is not optional, however necessary.
And Sophus needs 'eigen3' dependency of version 3.3.0+. On ubuntu, eigen3 must be installed with source code manually, which means not even with cmake or something, but just move it to /usr/include.
Sophus git version 0c84aed is fine btw.

you probability built your Sophus library with an older version, simply modify your code to #include <sophus/se3.h> rather than #include <sophus/se3.hpp>

After tried to refactor this whole project, I found it's impossible to migrate into older Sophus version, simply build a newer Sophus and don't waste your time.

@log00544 is right, and please note that if you want to build Sophus against Eigen 3.3, remember to build ceres against eigen3.3 first.

After attempting to use the current version of sophus, I receive several undefined reference errors. For example:
[ 60%] Linking CXX executable bundle_adjustment_bal /usr/bin/ld: CMakeFiles/bundle_adjustment_bal.dir/bundle_adjustment_bal.cpp.o: in function Sophus::SO3Base<Sophus::SO3<double, 0> >::normalize() [clone .part.380]':
bundle_adjustment_bal.cpp:(.text+0x1c0): undefined reference to fmt::v6::vprint(fmt::v6::basic_string_view<char>, fmt::v6::format_args)' /usr/bin/ld: CMakeFiles/bundle_adjustment_bal.dir/bundle_adjustment_bal.cpp.o: in function fmt::v6::internal::numeric_specs_checker<fmt::v6::internal::dynamic_specs_handler<fmt::v6::basic_format_parse_context<char, fmt::v6::internal::error_handler> > >::require_numeric_argument() [clone .isra.363] [clone .part.364]':
bundle_adjustment_bal.cpp:(.text.unlikely+0x10): undefined reference to fmt::v6::internal::error_handler::on_error(char const*)' /usr/bin/ld: CMakeFiles/bundle_adjustment_bal.dir/bundle_adjustment_bal.cpp.o: in function unsigned long long fmt::v6::internal::width_checkerfmt::v6::internal::error_handler::operator()<float, 0>(float) [clone .isra.404]':
bundle_adjustment_bal.cpp:(.text.unlikely+0x23): undefined reference to fmt::v6::internal::error_handler::on_error(char const*)' /usr/bin/ld: CMakeFiles/bundle_adjustment_bal.dir/bundle_adjustment_bal.cpp.o: in function unsigned long long fmt::v6::internal::precision_checkerfmt::v6::internal::error_handler::operator()<float, 0>(float) [clone .isra.415]':
bundle_adjustment_bal.cpp:(.text.unlikely+0x37): undefined reference to fmt::v6::internal::error_handler::on_error(char const*)' /usr/bin/ld: CMakeFiles/bundle_adjustment_bal.dir/bundle_adjustment_bal.cpp.o: in function void fmt::v6::print<char [2], , 0>(char const (&) [2])':`
After proceeding to use the Sophus git version 0c84aed suggested by @log00544 and following the previous instructions above I still receive the error:
minisam/minisam/geometry/projection.h:14:10: fatal error: sophus/se3.h: No such file or directory  #include <sophus/se3.h>
Has anyone else overcome and faced these issues? @rancheng


Update index.html

@Prajeshpuri  contribute to https://github.com/Ishaan28malik/Get-Dev-Resources instead.


TestUtil#assertThrows(): support checked exceptions as well

TestUtil#assertThrows() currently does not support functions which throw checked exceptions.
e.g.
TestUtil.assertThrows(IllegalValueException.class, () -> { throw new IllegalValueException(""); });

does not compile.
It would be useful if it did.

Marking as low priority since we do not actually need it now. Just putting this down as an issue so that we do not forget it.

Fixed in 21a1955a4c0b4cd085107a092dec13f66e86af66


Make caching embeddings optional for evaluation scripts

Hi @caroteu,
This PR makes caching embeddings as optional, i.e. for our evaluations, we can now compute the embeddings on the fly. I'll merge this later we have tested this.

Okay, @caroteu tested this, and seems to have resolved the hiccups (of mismatch in embedding signatures). Now, we always compute embeddings on the fly for benchmark evaluations. GTG from my side!


removeIndex needs save(), but...

removeIndex() needs save(), but it is written in the document that "There is no need to call the save() method when using removeIndex(). The index will be removed immediately."
And it is called save() for tests of removeIndex().

Would you be kind to add that to the documentation?

Thank you for your response.
Is it correct to save () when calling removeIndex ()?
If so, I will try to fork it and propose my changes.
(just delete the description in the document.)

Yes, save() is required

Anyone wants to make an update to docs?

https://github.com/cakephp/phinx/pull/1659


Dask array Slicing doesn't conform to Numpy conventions.

A dask.array cannot be sliced with standard numpy notation. This is a contrived example
x = dask.array.ones(10, chunks=(5,))
y = np.ones(10)
# works, no error
print(y[[None]])
# fail
print(x[[None]])

Output is:
[[ 1.  1.  1.  1.  1.  1.  1.  1.  1.  1.]]
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-30-b84fdab9de16> in <module>()
      2 y = np.ones(10)
      3 print(y[[None]])
----> 4 print(x[[None]])

C:\Anaconda3\lib\site-packages\dask\array\core.py in __getitem__(self, index)
   1259             return self
   1260
-> 1261         dsk, chunks = slice_array(out, self.name, self.chunks, index)
   1262
   1263         dsk2 = sharedict.merge(self.dask, (out, dsk))

C:\Anaconda3\lib\site-packages\dask\array\slicing.py in slice_array(out_name, in_name, blockdims, index)
    137
    138     # Pass down to next function
--> 139     dsk_out, bd_out = slice_with_newaxes(out_name, in_name, blockdims, index)
    140
    141     bd_out = tuple(map(tuple, bd_out))

C:\Anaconda3\lib\site-packages\dask\array\slicing.py in slice_with_newaxes(out_name, in_name, blockdims, index)
    159
    160     # Pass down and do work
--> 161     dsk, blockdims2 = slice_wrap_lists(out_name, in_name, blockdims, index2)
    162
    163     if where_none:

C:\Anaconda3\lib\site-packages\dask\array\slicing.py in slice_wrap_lists(out_name, in_name, blockdims, index)
    200         raise IndexError("Too many indices for array")
    201     for bd, i in zip(blockdims, index):
--> 202         check_index(i, sum(bd))
    203
    204     # Change indices like -1 to 9

C:\Anaconda3\lib\site-packages\dask\array\slicing.py in check_index(ind, dimension)
    710     if isinstance(ind, list):
    711         x = np.array(ind)
--> 712         if (x >= dimension).any() or (x <= -dimension).any():
    713             raise IndexError("Index out of bounds %s" % dimension)
    714     elif isinstance(ind, slice):

TypeError: unorderable types: NoneType() >= int()

What is x[[None]] supposed to me? NumPy currently interprets this as equivalent to x[(None,)] (which is syntactically the same as x[None,] and by numpy convention the same as the more conventional x[None, ...] or x[None]), but I don't think Dask should follow with loose (and undocumented) behavior of interpreting lists as tuples when they contain invalid elements for advanced indexing.

It looks like tuples work fine, so I can just cast lists to tuples before using them as slicers.


BVTCK-178 Using new assert framework where possible

https://hibernate.atlassian.net/browse/BVTCK-178

Same thing as for HV tests - replaced usage of some methods with
assertThat( constraintViolations ).containsOnlyViolations(
	violationOf( SomeConstraint.class )
....
);

I also have run HV build against this updated TCK version - all tests passed.

Wow. This is huge and a very good thing, thanks for that.
We are in the final stretch for releasing BV 2.0 (we submit the final artifacts on Tuesday) so it's a bit late to merge this one for this release. I marked it for 2.1, we will merge this as soon as we're done with the 2.0 release.
What would be interesting now that we use it everywhere is to have a regression test for the testing utility itself i.e. triggering a violation and validating that for each tested element (path, constraint...), we have an error if we compare to an incorrect value.
Typically, if it wasn't testing anything, we would currently have everything green, whereas the whole purpose of the TCK would be defeated.
Do you think you could add this test? It shouldn't be too hard nor too long.

Hi @gsmet, yes I'll add the tests for this utility. Should it be a separate PR, or can it go together with this one ?
As for the merging part - I think it'll be fine, as you've said it's almost final so there will be no huge changes, so no conflicts later when merging this, right ? :)

Yes, basically, I have a few tests to add regarding a clarification of the getLeafBean method for container elements and we're done.
We might have to make changes if other implementations detect issues in the TCK but it should be limited so I don't expect any merge issue.
Fingers crossed :)

@marko-bekhta sorry missed you question. Depends :). If it arrives before we cut the final, make it a separate issue and PR. as I'll probably include it in this release.

@gsmet We can probably move forward with that one, now?

@gunnarmorling yes, don't worry, I have it on the radar. Sharing my time between OGM and HV now.

Cool, thanks!

Forgot to close this one.


Get periodic unit cell.

Currently, periodic molecules (equivalent to .ConstructuedMolecule) do not have an easy way of accessing the periodic unit cell. It is used in the construction stage.
Suggesting ConstructedMolecule.get_enclosing_cell():
for periodic molecules, the topology graph._periodic is True: this is the unit cell.
else (i.e. for all other Molecule): This is just some enclosing cube, which does have its uses (can be calculated by projecting atom positions along basis vectors).
An alternative is to have PeriodicConstructedMolecule subclass, which handles this and any future periodic only properties.
I prefer option one; two features for the price of minor ambiguity. But I am unsure of how much overlap is results from it.

#182


'framework not found FBSDKLoginKit for architecture x86_64' after updating to FirebaseUI 0.7.0

I updated to FirebaseUI 0.7.0 and I now have this error when building the project I am working on:
"framework not found FBSDKLoginKit for architecture x86_64"
Before updating I used to have the following pod versions:
FBSDKCoreKit 4.15.1
FBSDKLoginKit 4.15.1
FBSDKShareKit 4.15.1
and after performing pod install to update to FirebaseUI 0.7.0, the FBSDLoginKit was updated to 4.17.0 and then the errors started appearing. I updated all three pods to 4.17.0 but the error persists. Also tried to use 4.15.1 for all pods but again the error persists.
Has anyone seen something similar?
I am using Xcode 8.1 and Cocoapods 1.1.0 (was using 1.0.0 and updated to 1.1.0 to see if it helped but it didn't).

If you go into your Pods/ folder, can you find the framework there? I suspect CocoaPods is building it and dropping it in your Pods folder and then just not making it visible to xcodebuild.

The FBSDLoginKit is in the Pods/ folder alright. So, something else is wrong I guess. Any help is appreciated!

You can work around this by dropping the directory in your FRAMEWORK_SEARCH_PATHS in your xcodeproj file.
FRAMEWORK_SEARCH_PATHS = $(inherited) "${PODS_CONFIGURATION_BUILD_DIR}/FBSDKLoginKit"

This is something we should probably put in our podspec

@morganchen12 I tried this but it doesn't seem to work. I see you committed this change, so it might be fixed when I update to the next version. Any other ideas how to fix this in the meanwhile?

I wasn't able to repro this in our sample apps or test targets, do you have a project you can share?

I'll see if it is reproduced in a project I can share. Cheers.

@morganchen12 I haven't resolved this issue yet. Unfortunately, I cannot share a project with this happening. I tried this at another computer and same exact thing happens. First, when I update the pod from 0.5.5 to 1.0.0 the same error happens for GoogleAuthUtilities, but because the pod is missing. I add it to the podfile and then next thing the same error takes place for FBSDKLoginKit.
The commit you did yesterday is not in 1.0.0, right?

Yeah, I didn't merge that commit. You're free to cherry-pick it to see if it fixes your issue.

Hi again @morganchen12 , this actually did help. I used a local podspec with your commit and that error went away! Cheers for that!
However, after now updating to FirebaseUI 1.0.0, I see that the classes are not renamed to the FUI prefix. I still have the FIR... files under the FirebaseAuth framework. Any ideas?
I know have the following pod versions:
Using Firebase (3.9.0)
Using FirebaseAnalytics (3.5.1)
Using FirebaseAuth (3.0.6)
Using FirebaseCore (3.4.4)
Using FirebaseDatabase (3.1.0)
Using FirebaseInstanceID (1.0.8)
Using FirebaseMessaging (1.1.1)
Using FirebaseStorage (1.0.4)
Using FirebaseUI (1.0.0)

FirebaseAuth is a Firebase framework, so it should be using the FIR prefix. Only the FirebaseAuthUI classes should be using FUI.

@morganchen12 the reason I am saying I don't have the classes is because I am trying to use FUIAuthPickerViewController by importing the following:
@import FirebaseAuth;
@import FirebaseAuthUI;
but Xcode says FirebaseAuthUI module is not found.
About adding this line into xcodeproj, I have tried adding it to framework search path through Xcode but it didn't work. I am not sure exactly where to add it in the xcodeproj file.

Hm, if Xcode can't find the framework module after cleaning/deleting DerivedData that probably means your framework search paths are messed up again. Can you make a sample project that reproduces this? If not, try adding ${PODS_ROOT}/FirebaseUI/FirebaseUIFrameworks/** to your framework search paths.

Hi again @morganchen12 , as it turns out, for some reason I was not getting version 1.0.0 of the pod, even though it was supposed to be installing version 1.0.0. I noticed that I didn't have the latest frameworks under the FirebaseUIFrameworks folder. I ended up manually adding them in that folder, and now I have the "framework not found FBSDKLoginKit for architecture" error again. So, still struggling. Thanks for all your help.

Can you share your podfile and any xcconfigs you have?

Ok so I'm having the same issue @yorgosg did to begin with: Linker can't find the FBSDKLoginKit when it's definitely there. I've tried adding the SDK to my framework search paths manually but I'm still having issues. I know that I have the kit installed correctly via pods. I've cleared out all my derived data and no dice still.
I can't really share my project but I will mention that it's a pre-existing project that I'm trying to plug FirebaseUI into... to no success. I looked at the mentioned commit and didn't see anything in it besides just a change to that one file so I'm not sure how yorgosg managed to get his build running.
Any ideas?

Can you share your podfile?

target 'BeaconWatch' do

pod 'Reachability'
pod 'CocoaAsyncSocket'
pod 'RestKit', '~> 0.20.0'

# Backend pods
pod 'Firebase/Core'
pod 'Firebase/Database'
pod 'FirebaseUI', '~> 1.0'
# Firebase dependencies
pod 'FBSDKCoreKit'
pod 'FBSDKShareKit'
pod 'FBSDKLoginKit'

# Testing and Search are optional components
pod 'RestKit/Testing', '~> 0.20.0'
pod 'RestKit/Search',  '~> 0.20.0'

I was able to repro this issue with your Podfile, thanks 👍
The issue goes away if you add use_frameworks! to your Podfile. If you for whatever reason are unable to use frameworks, it looks like CocoaPods is adding -framework arguments to the OTHER_LDFLAGS build setting. You can work around it at the cost of CocoaPods producing ugly warnings by avoiding inheriting settings under Other Linker Flags.
Possibly related to https://github.com/CocoaPods/CocoaPods/issues/6065, though this could also be misconfiguration on our part.

Fantastic. I had seen adding that flag was necessary for swift, good to
know you need it for Obj-C as well.
On Tue, Nov 8, 2016 at 4:33 PM, Morgan Chen<EMAIL_ADDRESS>wrote:

I was able to repro this issue with your Podfile, thanks 👍
The issue goes away if you add use_frameworks! to your Podfile. If you
for whatever reason are unable to use frameworks, it looks like CocoaPods
is adding -framework arguments to the OTHER_LDFLAGS build setting. You
can work around it at the cost of CocoaPods producing ugly warnings by
avoiding inheriting settings under Other Linker Flags.
Possibly related to CocoaPods/CocoaPods#6065
https://github.com/CocoaPods/CocoaPods/issues/6065, though this could
also be misconfiguration on our part.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/firebase/FirebaseUI-iOS/issues/194#issuecomment-259293427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMW-tcSLxbSD_G-HvQoOYAdvpDAZUa3Gks5q8Qa_gaJpZM4Kp8f_
.

--
Matthew D. Bahr

This is great, it finally worked!! After adding use_frameworks! to my pod file I also had to remove all the pod libraries from the other linker flags in build settings.
@matthewbahr  for your previous question, I managed to get it to work for a little while by using a local podspec for the Firebase pod, but now it is not needed.
@morganchen12 I appreciate all the help! Thanks a million! I am closing the issue.

Yeah the use_frameworks! seems to work for FirebaseUI but it's broken my RestKit. So it looks like I'll have to work around like suggested. Good to know though, thanks.

Pls add FBSDKCoreKit.framework
Adding just FBSDKLoginKit will give you error

Unable to avoid this problem. Have got O-C project. My Podfile:
target 'FirebaseTest' do

pod 'FirebaseCore', '~> 3.5'
pod 'FirebaseDatabase', '~> 3.1'
pod 'FirebaseUI', '~> 3.1'

pod 'Typhoon', '~> 3.5'
pod 'RamblerTyphoonUtils/AssemblyCollector', '~> 1.5'

pod 'Firebase/Auth'
pod 'FBSDKLoginKit', '~> 4.15'
pod 'FBSDKShareKit', '~> 4.17'
pod 'VK-ios-sdk', '~> 1.4'
pod 'InstagramKit', '~> 3.0'
pod 'InstagramKit/UICKeyChainStore'

pod 'AWSS3', '~> 2.4'
pod 'AWSCognito', '~> 2.4'

pod 'DBCamera', '~> 2.4'
pod 'SDWebImage', '~> 4.0'

pod 'Nimbus/Models', :git => 'https://github.com/rambler-ios/nimbus'

pod 'Fabric', '~> 1.6'
pod 'Crashlytics', '~> 3.7'

pod 'PureLayout', '~> 3.0'
pod 'CrutchKit/Proxying', :git => 'https://github.com/CognitiveDisson/CrutchKit', :tag => '0.0.10'
pod 'EasyMapping', '~> 0.18'
pod 'libextobjc', '~> 0.4'

pod 'pop', '~> 1.0'

end

use_frameworks! breaks Nimbus. Also I tried to avoid problem with -framework flag in Other linker flag build setting of Pods project

What CocoaPods and Xcode versions are you using?

xcode 8.2.1, cocoapods 1.2.0

You may need to go into your project file and manually add the pods paths into your FRAMEWORK_SEARCH_PATHS.

I tried to add "{PODS_ROOT}" and "${PODS_ROOT}/FBSDKLoginKit/FBSDKLoginKit/FBSDKLoginKit" manually to my project file, but received the same error. Also I tried to set OTHER_LDFLAGS as -framework for FBSDKLoginKit target.

I'll have to take a closer look later--can you open a new issue regarding using FirebaseUI without use_frameworks!?

I have the same error, your solution didn't help me. any other ideas how to fix that?

@Luckygirlllll can you open a new issue with your Podfile and pod install output?


Apply project level policies to standalone Harbor

The following features are only enabled in integration mode, this commit moves
these to standalone Harbor:

Content trust policy: only signed images can be pulled
Vulnerability policy: only images whose severity is below the threshold can be pulled
Automatic scan policy: automitic scan pushed images

Coverage decreased (-22.6%) to 32.912% when pulling 0cbfeac6021d1c349f3eca34159e53cae814b5a0 on ywk253100:171019_pro_policy into a1b89697932193aa8c132aaa03ef98a5d8d7ed76 on vmware:master.


wal: add metrics to track corruption on recovery

I'm not sure I follow why a CounterVec would be a better option. As far as I understand it's basically adding dimensions to a counter (so you can record stuff like error or success). What would the labels be?
The intention is that the number of repairs is looked at independently. Ideally it stays at 0 but otherwise we have a general idea of whether we are truncating data to repair a WAL.

Ah, do you mean we would have one counter wal_repairs and the CounterVec would be wal_repairs{value="truncations"} and wal_repairs{value="lost_records"}?

Hmm, but it doesn't make sense to me what wal_repairs would be in that case though


Neurolab Sample2_fixed.hl7 correction.

Neurolab sent a new Sample3_fixed.hl7 for us to verify and give feedback.

https://app.zenhub.com/files/304423150/8e5f75bc-3f89-42a6-a584-6e3c70123341/download


Support regex filter

Hey, this PR is still under WIP and I’ll address your mentioned concern
before making it ready for review ☺
tis 31 aug. 2021 kl. 07:34 skrev XAMPPRocky @.***>:

@.**** approved this pull request.
Thank you for your PR! This mostly looks good to me, I've left a one
comment. Once that is addressed this should be good to merge.
In src/filters/regex_bytes.rs
https://github.com/googleforgames/quilkin/pull/387#discussion_r698995008
:

+impl RegexBytes {

fn new(base: &Logger, config: Config, metrics: Metrics) -> Self {

   RegexBytes {

       log: base.new(o!("source" => "extensions::RegexBytes")),

       //capture: config.strategy.as_capture(),

       metrics,

       regex_expression: Arc::new(config.regex_expression),

       //metadata_key: Arc::new(config.metadata_key),

   }

}
+}

+impl Filter for RegexBytes {

fn read(&self, ctx: ReadContext) -> Option {

   let re = Regex::new(self.regex_expression.as_str()).unwrap();

The Regex type should be created in create_filter, stored, and re-used
here. This implementation will compile the Regex for each packet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googleforgames/quilkin/pull/387#pullrequestreview-742291067,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXAGUV2HT6DOPNOXEGSFMDT7RSURANCNFSM5DCXD2JQ
.

--
Med vänliga hälsningar, Haris Kljajic.
070 297 78 75
http://devharis.com

Thanks for the PR! We have a capture bytes that does something pretty similar to this from what I can tell, could we enhance that filter with a new regex Strategy instead of implementing this as a new filter? https://github.com/googleforgames/quilkin/blob/main/src/filters/capture_bytes/capture.rs#L2-L7

I was looking at this as well first, but realised pretty soon that the description/idea of how this regex should work differs from what CaptureBytes does today. It will also introduce complexity to configuration, e.g different supporting properties, errors/unsupported combinations.
Example
config:
 strategy: PREFIX
 metadataKey: myapp.com/myownkey
 size: 3
 remove: false

vs
config:
 strategy: REGEX
 metadataKey: myapp.com/myownkey
 expression: "^quilkin"
 on_success: "capture | pass"
 on_error: "drop"

We probably could try to align and merge logic of these two filters, for example PREFIX/SUFFIX drops today as default if size req is not met, but for the rest it is different. I see this more as regex filter utilises capture as a partial feature but also has support for pass.
An idea on how we could align these two filters to one is to support a configuration like this
config:
 strategy: PREFIX | SUFFIX | REGEX
 metadataKey: myapp.com/myownkey
 on_success: "capture | pass"
 on_error: "drop"

 expression: "^quilkin" <-- Req strategy REGEX
 size: 3  <-- Req strategy PREFIX | SUFFIX
 remove: false <-- Req strategy PREFIX | SUFFIX

Required properties throws validation errors on startup if missing to set strategy, wdyt?

Ah I see, yeah the only difference I can seems to be the pass feature while all other things seem common to capture filter. in which case we can merge it into the capture filter and make the 'pass' part configurable.
Config-wise, we can ensure that only one of them is provided and that strategy arguments aren't mixed with each other using a one-of schema type (we currently do something similar for the static/dynamic fields of a config).
So a config would look like:
# prefix
config:
  metadataKey: myapp.com/myownkey
  prefix:  # deserialization ensures that exactly one of prefix,suffix,regex is provided
    size: 3
    remove: false

or
# regex
config:
  metadataKey: myapp.com/myownkey
  regex:
    expression: ".*"
    remove: false
    capture: true # or maybe e.g `passthrough: true` since capturing the bytes makes more sense as a default given the filter name

For the on_error: drop, I'd say we ignore that field config-wise since that's already what all filters do when things go wrong (we can introduce options for all affected filters when we do in fact have options in such scenarios)

Ah I see, yeah the only difference I can seems to be the pass feature while all other things seem common to capture filter. in which case we can merge it into the capture filter and make the 'pass' part configurable.
Config-wise, we can ensure that only one of them is provided and that strategy arguments aren't mixed with each other using a one-of schema type (we currently do something similar for the static/dynamic fields of a config).

I just came here to say that I like this idea 👍🏻

Ah I see, yeah the only difference I can seems to be the pass feature while all other things seem common to capture filter. in which case we can merge it into the capture filter and make the 'pass' part configurable.
Config-wise, we can ensure that only one of them is provided and that strategy arguments aren't mixed with each other using a one-of schema type (we currently do something similar for the static/dynamic fields of a config).

I just came here to say that I like this idea 👍🏻

Thanks @markmandel, tbh I've been swamped at work and private latley. However, I'm now in a state where I'm fighting the language more than anything.
Two initial things I'd like your help with

As how I've refactored the configuration, we now support a dynamic strategy property which turns the enum to a struct with properties over a enum variant. This breaks the map_proto_enum in config.rs. Is there a nice alternative to parse this without compromising the nice configuration structure @iffyio proposed?

I'm trying to use composition to handle both something now called SizeCapture and RegexCapture joined under Capture trait. How can I get these to work in harmony in as_capture?

Last but not least, feel free to contribute if you feel it is taking to much time... It is totally understandable. Rust is a new language for me and this turned out to be bigger than I anticipated in the first place! 😅

Hi @devharis!

I'm trying to use composition to handle both something now called SizeCapture and RegexCapture joined under Capture trait. How can I get these to work in harmony in as_capture?

I think the simpler route would be have to all three strategies implement the Capture trait rather than introduce a new trait. The CaptureBytes filter would no longer need to know about things like remove or size etc, rather those belong to the implementation now that they differ - so something like
struct Suffix {
  remove: bool,
  size: usize,
}
struct Regex {
  regex: Regex,
  remove: bool,
}
impl Capture for Suffix {}
impl Capture for Regex {}

struct CaptureBytes {
  log: Logger,
  capture: Box<dyn Capture>,
  metadata_key: Arc<String>,
}
impl Filter for CaptureBytes {
  fn read(&self) {
    // I think this part works largely the same
    ...
    // Except no extra parameters needed in the `capture()` call
    // since the `self.capture` implementation already has all the
    // needed configuration.
    let token = self.capture.capture(ctx.contents)
    ...
  }
}

This breaks the map_proto_enum in config.rs

the map_proto_enum implementation only converts proto enums to plain rust enums that don't contain any data so likely we won't be able to use it anymore for this filter. We can instead do the mapping ourselves with e.g:
let strategy: Strategy = match protoconfig.strategy {
  ProtoStrategy::Suffix => {
     Strategy::Suffix {
        size: protoconfig.size,
        ...
     }
  },
}

(also sorry about the delayed feedback)

Since this has bitrotted with little activity, and I wanted to add support for regex to test something, I've continued this work in #458 and am going to close this. Thank you for your PR!