crashes happen when used DZNEmptyDataSet and SVPullRefresh together

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'An instance 0x7fad6c061a00 of class UITableView was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x7fad6b734a70> (
<NSKeyValueObservance 0x7fad6b732980: Observer: 0x7fad6b432ac0, Key path: contentOffset, Options: <New: YES, Old: NO, Prior: NO> Context: 0x0, Property: 0x7fad6b7326c0>
<NSKeyValueObservance 0x7fad6b734b90: Observer: 0x7fad6b432ac0, Key path: frame, Options: <New: YES, Old: NO, Prior: NO> Context: 0x0, Property: 0x7fad6b734a40>
)'
*** First throw call stack:
(
	0   CoreFoundation                      0x0000000107874c65 __exceptionPreprocess + 165
	1   libobjc.A.dylib                     0x000000010750dbb7 objc_exception_throw + 45
	2   CoreFoundation                      0x0000000107874b9d +[NSException raise:format:] + 205
	3   Foundation                          0x00000001070e9332 NSKVODeallocate + 317
	4   Foundation                          0x00000001070bac23 __delayedPerformCleanup + 46
	5   CoreFoundation                      0x00000001077d7ec5 CFRunLoopTimerInvalidate + 581
	6   CoreFoundation                      0x00000001077dbd6b __CFRunLoopDoTimer + 1099
	7   CoreFoundation                      0x000000010779dd3d __CFRunLoopRun + 1901
	8   CoreFoundation                      0x000000010779d366 CFRunLoopRunSpecific + 470
	9   GraphicsServices                    0x0000000109827a3e GSEventRunModal + 161
	10  UIKit                               0x0000000105d9b900 UIApplicationMain + 1282
	11  MyTestProject                       0x0000000105a62c8f main + 111
	12  libdyld.dylib                       0x0000000109384145 start + 1
	13  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

i find in function dzn_original_implementation it did not call origin dealloc method.
and It work fine when i use under code
    ...
    if ([key rangeOfString:kEmptyDataSetDealloc].location != NSNotFound) {
        [self dzn_dealloc];

        // If found, call original implementation
        if (impPointer) {
            ((void(*)(id,SEL))impPointer)(self,_cmd);
        }
    }
   ...

Is these some reason that do not call origin dealloc?

it still crash with 0def0f8
There is a demo

run on Simulator with iPhone 5s (8.3)
click Button push a new controller
click Back, crash happen

@dzenbot same for me as well, using a tableView

@dzenbot  nope...i am using PHFRefreshControl with a tableview.

If enable Diagnostics -> Enable Zombie Objects option, it will still crash.


State will be saved when using two same components with v-if

Version
2.5.16
Reproduction link
https://jsfiddle.net/50wL7mdz/208710/
Steps to reproduce

A component with state
Render two same components with v-if

What is expected?
The two components should be different.
What is actually happening?
State will change.

v-show is ok

https://vuejs.org/v2/guide/conditional.html#Controlling-Reusable-Elements-with-key

@LinusBorg I remember components are not reused by default, at least for versions prior to 2.5.16... If this
behavior change was intentional it probably should be documented.

This is not new behaviour. vue always re-used components in this situation, just like it does in a v-for where you splice the array.

Right... I tested with older versions and the behavior is the same, though I still think this is surprising behavior because component state is reused - instead of just DOM state, as indicated by the document.

Yes, it can be surprising to new users, but is expected for anyone familiar with the virtual dom implementation, I also think we talk about it in the section that explains when to use key with v-for, but not in the context of v-if.
So we should improve the docs about this effect in the vuejs.org repository.
Here, the issue can be closed.


Fix saving output variables with dtype=object

…able dtype is object or np.object. It works at runtime and the variable is successfully saved in the Dataset, but it fails at sabing to file Closes #144

[x] Closes #144
[x] Tests added
[x] Passes black . && flake8
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

LGTM, I pushed some commits to update an existing test for this.
Thanks again @bgailleton!


Incorrect merge diff found with inner Data Classes inside Versioned Folder

Describe the bug
Assume that a Versioned Folder branch contains:

A Data Model
That then contains a Data Class
That Data Class then gets another Data Class added as a child

If merging point 3 into the main branch, the diff returned is a deletion instead of an addition. Why is this?
To Reproduce

Create a Versioned Folder, then inside a Data Model, then inside a Data Class.
Finalise the Versioned Folder to 1.0.0
Branch off version 1.0.0 to create a main and another branch - "test-branch"
In "test-branch", add another Data Class inside the existing Data Class (to produce a parent-child relationship). The structure should then look like the screenshot below.
Go to merge the Versioned Folder from "test-branch" to "main"

Expected behavior
Because the child Data Class is new and does not exist in the main branch yet, I would have assumed the diff would say it is being "added", not "deleted".
Screenshots
Note the structure below. A child Data Class was added to the test branch, where is does not exist in the main branch:

This is the result of the merge diff on this structure:

Additional context
If you commit this change to the main branch, nothing actually happens - the child Data Class still exists in the test branch, and the main branch still does not include it.

I've now found a similar issue related to Data Elements.
Here is my test branch of a VF. The highlighted DC contains a new DE called "First Data Element":

To confirm, this does not exist in the main branch:

But this is the merge diff returned:

And one final thing... Adding a DE to the child DC like this:

The merge diff does not return this one at all:

odd...

this is odd as the tests we have cover this exact scenario
{
      "path": "vf:Functional Test VersionedFolder 3$source|dm:Functional Test DataModel 1$source|dc:existingClass|dc:addLeftToExistingClass",
      "isMergeConflict": false,
      "isSourceModificationAndTargetDeletion": false,
      "type": "creation"
    },

@pjmonks can you retest this please, I have locally run up your branch plus mdm-app-build and I'm getting the creation as id expect
 http://localhost:8080/api/versionedFolders/5a42c7e8-da87-462e-bc61-8c95e094409e/mergeDiff/7af7fe25-968a-4985-aa49-6cc68f606a8f?isLegacy=false
{
    "sourceId": "5a42c7e8-da87-462e-bc61-8c95e094409e",
    "targetId": "7af7fe25-968a-4985-aa49-6cc68f606a8f",
    "path": "vf:test$test",
    "label": "test",
    "count": 1,
    "diffs": [
        {
            "path": "vf:test$test|dm:pdf$test|dc:dfgdfgdf|dc:hghfgf",
            "isMergeConflict": false,
            "isSourceModificationAndTargetDeletion": false,
            "type": "creation"
        }
    ]
}

I think you had the url sending the ids in the wrong order when you tested this and got this error...thats the only explanation I can think of

Sorry @olliefreeman , but I must have the sourceId and targetId the right way round, otherwise the other diffs I see wouldn't be right either.
Look at this structure:

Everything I've highlighted in green would be additions when I merge testBranch into main. But this is the diff I see:

If I had the source and target IDs the wrong way round, then all of them would be wrong, but I'm finding that 3 are correct and 2 are wrong. I can't understand why.
Another example to prove that I can replicate it on my system:

this is really bizarre ... why does it work fine for me but not for you ....

and we have in our tests ... we have an "existing class" DC which we add a DC to and the json comes back
{
      "path": "vf:Functional Test VersionedFolder 3$source|dm:Functional Test DataModel 1$source|dc:existingClass|dc:addLeftToExistingClass",
      "isMergeConflict": false,
      "isSourceModificationAndTargetDeletion": false,
      "type": "creation"
    },

@olliefreeman I have been retesting this issue with the scenarios I've described previously. My original issues don't seem to happen anymore, so it can now diff:

Data Model with Data Class and inner Data Class
Data Model, Data Class which contains Data Element

But I can still reproduce a bizarre situation around Data Elements added to child Data Classes. I'm not sure how edge-case this is though.
Steps to reproduce
From the UI:

Create a VF called "VF Data Models"
Then create a DM inside the VF called "DM Test"
Then create a DC inside the DM called "DC Test"
Finalise the VF to version 1.0.0
Create a new branch off of VF 1.0.0 called "test-branch"
Under "test-branch", create a child DC under "DC Test" called "DC Test Inner"
Create a DE and DT under "DC Test" called "DE Test" and "DT Test".
Merge-diff "test-branch" compared to "main" now and merge the changes made - these should be the new child DC, DE and DT. But keep the source branch!
Now, under "test-branch", create a DE under "DC Test Inner" using the same DT
Merge-diff again.

At this point I'm able to see this diff:

This is wrong - the DE added to the inner DC is an addition, not a deletion.
Additional context
I have tried to debug the diff operation happening, but cannot easily see the point where a deletion is listed in the diffs. Inspecting most of the variables shows that a new DE is seen as an addition, but maybe it is related to the common ancestor - I've seen that source and target are first compared against common ancestor, then somehow compared to each other (though I couldn't track that point in the code).
Also, unless this is relevant, the MergeDiff.flatten() method shows me the final diff tree between source and target, but I can expand the tree and see a NullPointerException happening down towards the point where the inner DE is. Is this relevant at all?


Static ports (instead of random)

This tool has been super useful! Feature request: It'd be nice if there was a way to generate the same, unique port for each pod every time. I'm using a StatefulSet with 5 replicas and would like to guarantee that pod-0 through pod-5 always get the same unique port. I don't really care what the external ports are, as long as they stay the same.

Interesting use case, I assume that your client software cannot handle dynamic ports?
In general, I think your idea is possible.
The tool just needs to allocate the Service and add an internal annotation to the StatefulSet.
When new pods are created, this tool takes a free Service and assigns the Endpoint to the pod.
I am not quite sure how rolling upgrades behave and if there is the possibility of more than 5 (your example) nodes running at the same time.
Unfortunately, I don't have time to implement such a feature current.

It's just a nice-to-have for the project I'm working on. The software can handle it... it creates a P2P connection with another client (outside the cluster) and when the pod needs to restart, would be nice to maintain the same IP:port for the P2P network it's connecting to.
Thanks for considering it!


fixes issue where simple linear gauge assumes min value=0

Fixes https://github.com/mxtommy/Kip/issues/140 where simple gauge doesn't show properly if min!=0.

Thanks for the fix. We should have an updated version soon and it will include other features.

Hi @amirlanesman  Not sure how else to reach out.I need help beta testing the latest Kip Master branch code. Can you help?
This release will have major changes and I need support testing before releasing. Could you run the latest Master and see how it goes in general?
Thanks

Hey, sorry, not at the boat and not sure when I will be, don't think it
will be relevant by then.
On Sat, Sep 23, 2023, 06:47 David G @.***> wrote:

Hi @amirlanesman https://github.com/amirlanesman Not sure how else to
reach out.I need help beta testing the latest Kip Master branch code. Can
you help?
This release will have major changes and I need support testing before
releasing. Could you run the latest Master and see how it goes in general?
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/mxtommy/Kip/pull/142#issuecomment-1732200106, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQZYD4Z7FVX6YCBF3QESH3X3ZLWVANCNFSM6AAAAAAQ3CJMQY
.
You are receiving this because you were mentioned.Message ID:
@.***>


frontend: data-pipelines e2e tests

A prerequisite is a control-service instance running.
Auth configured with CSP STG provisioned OAuth app, redirect URLs and
TTL set common to the prior app configs.
e2e tests sync to freezepoint -
Had to fetch the latest changes from the internal repo contributed,
to unify the diverged with the public repo.
Added test_e2e_data_pipelines.sh script for cicd/local dev purposes.
Added Gitlab job to run.
Provisioned the clientId with CSP STG.
Synced the frontend/data-pipelines/gui/e2e/*
This PR is dependent on syncing the functional changes in the scope of:
https://github.com/vmware/versatile-data-kit/pull/1746
Testing done: ci/cd; run locally npm start and node --max_old_space_size=4096 ./node_modules/cypress/bin/cypress open --env OAUTH2_API_TOKEN=$VDK_API_TOKEN,CYPRESS_TERMINAL_LOGS='./e2e/logs' where auth is successful
Testing the e2e tests functional changes will be additionally done.

This PR remains for transferring diverged e2e tests code, and will most probably be closed - due the diverged e2e tests code had been meanwhile coupled with another non-VDK service.

Agreed with @gorankokin to take a look and resolve Team service (internal) dependencies with current PR


Display gif in a spawned engine crashes after parent engine destroyed

It can be solved by this PR: https://github.com/flutter/engine/pull/29915
Steps to Reproduce

Open the app
Click the "Next" button
Click the second "我知道了" in the flutter instance of half of the bottom screen
Click the "RemoveFirst" button then it will crash.

Expected results: It's ok and don't crash.
Actual results:  It crashed.

Code sample

It's as same as https://github.com/flutter/samples/tree/master/add_to_app/multiple_flutters
if (needShow)
          Padding(
            padding: const EdgeInsets.only(left: 24, right: 24),
            child: Image.asset(
                'images/mabaoguo.gif', // <-- here a gif
                fit: BoxFit.fill),
          ),

        button.text = "RemoveFirst"
        button.setOnClickListener {
            fragmentManager.beginTransaction().remove(firstFragment!!).commitNow()
            FlutterEngineCache.getInstance().remove(0.toString())
            topBindings.detach()
            isFirstRemove = true
        }

    /**
     * This tears down the messaging connections on the platform channel and the DataModel.
     */
    fun detach() {
        // TODO: Uncomment after https://github.com/flutter/engine/pull/24644 is on stable.
         engine.destroy();
        DataModel.instance.removeObserver(this)
        channel.setMethodCallHandler(null)
    }

Logs

2021-11-24 21:30:20.221 11369-11451/dev.flutter.multipleflutters A/libc: Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 11451 (1.io), pid 11369 (ultipleflutters)
2021-11-24 21:30:20.268 11481-11481/? A/DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: Build fingerprint: 'Xiaomi/umi/umi:11/RKQ1.200826.002/21.7.28:user/release-keys'
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: Revision: '0'
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: ABI: 'arm'
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: Timestamp: 2021-11-24 21:30:20+0800
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: pid: 11369, tid: 11451, name: 1.io  >>> dev.flutter.multipleflutters <<<
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: uid: 10350
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG: Cause: null pointer dereference
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG:     r0  00000000  r1  00000000  r2  00000000  r3  00000000
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG:     r4  ba4661a0  r5  c04e6da8  r6  c4d936c5  r7  c04e6dc0
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG:     r8  00000001  r9  c2b6df80  r10 00000000  r11 00000069
2021-11-24 21:30:20.269 11481-11481/? A/DEBUG:     ip  c533d230  sp  c2b6df00  lr  c4d8c87f  pc  c5061a3c
2021-11-24 21:30:20.315 920-2330/? E/CamX: [ERROR][NCS    ] camxncsintfqsee.cpp:2208 FillSensorData() Invalid sensor index -1
2021-11-24 21:30:20.331 11481-11481/? A/DEBUG: backtrace:
2021-11-24 21:30:20.331 11481-11481/? A/DEBUG:       #00 pc 0151da3c  /data/app/~~2IpoKhzv3XH25FXTfH4Bcw==/dev.flutter.multipleflutters-KgF_VwKmEzFMIkqNVCogNg==/base.apk!libflutter.so (offset 0x107b000) (BuildId: 88f02ec203436ab8cdb69e38b00ff4c9f2d66dc0)
2021-11-24 21:30:20.331 11481-11481/? A/DEBUG:       #01 pc 000fbf96  [anon:stack_and_tls:11451]

[✓] Flutter (Channel master, 2.6.0-12.0.pre.789, on macOS 12.0.1 21A559 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.6.0-12.0.pre.789 at /Users/eggfly/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6ae721de3d (3 days ago), 2021-11-21 15:22:37 -0500
    • Engine revision ad00d12833
    • Dart version 2.16.0 (build 2.16.0-35.0.dev)
    • DevTools version 2.8.0
    • Pub download mirror https://dart-pub.byted.org

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/eggfly/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/eggfly/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.0.1 21A559 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.55

• No issues found!

Thanks @eggfly

Do you have the symbolicated stacktrace of the crash?
In your "code sample" can you format the difference with the flutter sample as a diff so it's easy to apply and reproduce?
This happens on iOS as well, right?

I suspect what is happening is that the first engine is being killed but it has an existing task on the io thread.  Typically this isn't a problem since the thread will usually be shut down right away.  In the case where there are multiple engines, it doesn't happen though.  So, we probably just need to check for a null weak reference.
Something like:
diff --git a/lib/ui/painting/multi_frame_codec.cc b/lib/ui/painting/multi_frame_codec.cc
index 07c341953e..32b723835a 100644
--- a/lib/ui/painting/multi_frame_codec.cc
+++ b/lib/ui/painting/multi_frame_codec.cc
@@ -207,7 +207,7 @@ Dart_Handle MultiFrameCodec::getNextFrame(Dart_Handle callback_handle) {
        ui_task_runner = task_runners.GetUITaskRunner(),
        io_manager = dart_state->GetIOManager()]() mutable {
         auto state = weak_state.lock();
-        if (!state) {
+        if (!state || !io_manager) {
           ui_task_runner->PostTask(fml::MakeCopyable(
               [callback = std::move(callback)]() { callback->Clear(); }));
           return;

Okay, I looked through your PR and I think I understand what the issue is.  Shell.io_manager_ isn't shared between spawned engines.  It wasn't something that Xiao or I identified as being of significant size.  We started sharing it unsafely.  Our option here is to not share it (what your PR does) or to start sharing it.  It's probably just as much work to start sharing it correctly and it will have better performance.  Did you look into that?

Okay, I looked through your PR and I think I understand what the issue is. Shell.io_manager_ isn't shared between spawned engines. It wasn't something that Xiao or I identified as being of significant size. We started sharing it unsafely. Our option here is to not share it (what your PR does) or to start sharing it. It's probably just as much work to start sharing it correctly and it will have better performance. Did you look into that?

@gaaclarke  Yes, The shell's io_manager_ can be shared. I totally agree with you. Let me do it.

Hi @eggfly, Thanks for filing the issue.

Steps to Reproduce
Open the app
Click the "Next" button
Click the second "我知道了" in the flutter instance of half of the bottom screen
Click the "RemoveFirst" button then it will crash.

Could you please share the complete code sample that aligns with your reproducible steps, I ran the multiple flutters sample on Android and it works fine. Or at least specify the changes that should be made in multiple Flutters sample in order to reproduce the crash.

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0.1 21A559 darwin-arm, locale en-GB)
    • Flutter version 2.5.3 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (6 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.1, Build version 13A1030d
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.61.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.0.1 21A559 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 96.0.4664.55

• No issues found!

Thanks


Fix footer link to correct one

Right now, the link on the footer links to manishprivet.github.io which is a dead link.

Change it to https://manish.codes

I want to work on this project

Assigned to you @sejaljain123 :)


Missing setting of CURLINFO_HEADER_OUT option

The CURLINFO_HEADER_OUT option is not set in the curl adapter which results in Client::getLastRawRequest to be empty

@bashofmann Hi!
I'm looking at the PHP documentation, and CURLINFO_HEADER_OUT's documented use is "to track the handle's request string," which contradicts your request. :)
In looking in the cURL adapter, I see we are setting the CURLOPT_HEADER option, which is for including the headers in the output. We disable it in one circumstance: if an output stream is defined for the adapter (i.e., if you are going to stream the response body). Is it possible you're doing that?

I'm talking about the request headers. In
https://github.com/zendframework/zend-http/blob/master/src/Client/Adapter/Curl.php#L421
this is called
        $request  = curl_getinfo($this->curl, CURLINFO_HEADER_OUT);

so that later on the complete send request including request headers and (if available) request body will be available in Client::getLastRawRequest.
The documentation says:
CURLINFO_HEADER_OUT - The request string sent. For this to work, add the CURLINFO_HEADER_OUT option to the handle by calling curl_setopt()
This curl_setopt is missing.
This has nothing to do with the response headers.

Same problem here. Since last upgrade we are missing Request Headers in tracking data.. see http://php.net/manual/en/function.curl-getinfo.php -> Return Values:

"request_header" (This is only set if the CURLINFO_HEADER_OUT is set by a previous call to curl_setopt())

I've converted this issue into a pull request, and it provides a fix. I have zero idea how to test this other than doing an integration test; @bashofmann or @benjaminradtke - can one of you test with one of your apps?

I enabled the online tests locally, and discovered that adding this fixes several existing test failures.
I'll get this merged and released ASAP. Thanks for the report and the clarifications!

Hey @weierophinney thanks for your quick reply. Of course I will test it with our app, to remove our workaround.

Works like a charm - but I am not sure if you should put that statement in the later else path:
if ($this->outputStream) {
    // headers will be read into the response
    curl_setopt($this->curl, CURLOPT_HEADER, false);
    curl_setopt($this->curl, CURLOPT_HEADERFUNCTION, [$this, "readHeader"]);
    // and data will be written into the file
    curl_setopt($this->curl, CURLOPT_FILE, $this->outputStream);
} else {
    // ensure headers are also returned
    curl_setopt($this->curl, CURLOPT_HEADER, true);
    curl_setopt($this->curl, CURLINFO_HEADER_OUT, true);

    // ensure actual response is returned
    curl_setopt($this->curl, CURLOPT_RETURNTRANSFER, true);
}

This is, where it was placed before since ZF 1.12.8

but I am not sure if you should put that statement in the later else path

Considering we always call curl_getinfo later to retrieve the raw request, having it outside the conditional makes sense.


Make text configurable

Fix conflicts from https://github.com/choyiny/afullstop/pull/10

Thanks! Merged.


API Url - HTTP vs. HTTPS vs. Unsigned Certificates

If you use a self signed certificate, e.g. while development, the api request during an export will always fail because of a empty response body in http request.
I could fix it by either using a HTTP url instead HTTPS or by adding "verify_peer" => false, "verify_peer_name" => false to the request context in the doPutRequests and doGetRequest methods of lib/LizardsAndPumpkins/src/Api/PhpStreamHttpApiClient.php.
This might not be a typical setting for production but could be a bit confusing while development.

We should implement a debug/developer mode which turns off checking.

I suggest adding a PhpStreamHttpApiClient::insecure() named constructor which will instantiate the client and set flags that disable the certificate verification.
Then in \LizardsAndPumpkins_MagentoConnector_Helper_Factory::createLizardsAndPumpkinsApi() either new or the new constructor can be used depending on a Magento system config setting.
Instead of calling it debug mode, lets call it Disable HTTPS certificate verification for API requests.


[Extensibility Bug / Event Request] table 83 "Item Journal Line" OnAfterCreateDimTableIDs

In Table table 83 "Item Journal Line" you obsoleted the event OnAfterCreateDimTableIDs.
#if not CLEAN20
    [Obsolete('Temporary event for compatibility', '20.0')]
    [IntegrationEvent(false, false)]
    local procedure OnAfterCreateDimTableIDs(var ItemJournalLine: Record "Item Journal Line"; CallingFieldNo: Integer; var TableID: array[10] of Integer; var No: array[10] of Code[20])
    begin
    end;
#endif

This event was called on multiple places before the procedure PickDimension was called.
Now you Replaced the procedure PickDimension somehow by the procedure CreateDim(DefaultDimSource: List of [Dictionary of [Integer, Code[20]]]; InheritFromDimSetID: Integer; InheritFromTableNo: Integer).
    procedure CreateDim(Type1: Integer; No1: Code[20]; Type2: Integer; No2: Code[20]; Type3: Integer; No3: Code[20])
    var
        TableID: array[10] of Integer;
        No: array[10] of Code[20];
    begin
        CreateTableArray(TableID, Type1, Type2, Type3);
        CreateCodeArray(No, No1, No2, No3);
        OnAfterCreateDimTableIDs(Rec, CurrFieldNo, TableID, No);   //HERE
        PickDimension(TableID, No, 0, 0);
    end;

    local procedure CreateDimWithProdOrderLine()
    var
        ProdOrderLine: Record "Prod. Order Line";
        InheritFromDimSetID: Integer;
        TableID: array[10] of Integer;
        No: array[10] of Code[20];
    begin
        if "Order Type" = "Order Type"::Production then
            if ProdOrderLine.Get(ProdOrderLine.Status::Released, "Order No.", "Order Line No.") then
                InheritFromDimSetID := ProdOrderLine."Dimension Set ID";

        CreateTableArray(TableID, DATABASE::"Work Center", DATABASE::"Salesperson/Purchaser", 0);
        CreateCodeArray(No, "Work Center No.", "Salespers./Purch. Code", '');
        OnAfterCreateDimTableIDs(Rec, CurrFieldNo, TableID, No);  //HERE
        PickDimension(TableID, No, InheritFromDimSetID, DATABASE::Item);
    end;

To keep the code working we would need a new EVENT that is called before the event OnBeforeCreateDim.
procedure CreateDim(DefaultDimSource: List of [Dictionary of [Integer, Code[20]]]; InheritFromDimSetID: Integer; InheritFromTableNo: Integer)
    var
        ItemJournalTemplate: Record "Item Journal Template";
        SourceCode: Code[10];
        IsHandled: Boolean;
    begin
//>>>Missing EVENT without Handled pattern as replacement for the event `OnAfterCreateDimTableIDs`.
        OnBeforeCreateDimProcedure(Rec, CurrFieldNo, DefaultDimSource, InheritFromDimSetID, InheritFromTableNo);
//<<<Missing EVENT without Handled pattern
        IsHandled := false;
        OnBeforeCreateDim(Rec, IsHandled, CurrFieldNo, DefaultDimSource, InheritFromDimSetID, InheritFromTableNo);
        if IsHandled then
            exit;
#if not CLEAN20
        if RunEventOnAfterCreateDimTableIDs(DefaultDimSource, InheritFromDimSetID, InheritFromTableNo) then
            exit;
#endif

        SourceCode := "Source Code";
        if SourceCode = '' then
            if ItemJournalTemplate.Get("Journal Template Name") then
                SourceCode := ItemJournalTemplate."Source Code";

        "Shortcut Dimension 1 Code" := '';
        "Shortcut Dimension 2 Code" := '';
        "Dimension Set ID" :=
          DimMgt.GetRecDefaultDimID(
            Rec, CurrFieldNo, DefaultDimSource, SourceCode,
            "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code", InheritFromDimSetID, InheritFromTableNo);
        DimMgt.UpdateGlobalDimFromDimSetID("Dimension Set ID", "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");

        if "Entry Type" = "Entry Type"::Transfer then begin
            "New Dimension Set ID" := "Dimension Set ID";
            "New Shortcut Dimension 1 Code" := "Shortcut Dimension 1 Code";
            "New Shortcut Dimension 2 Code" := "Shortcut Dimension 2 Code";
        end;
    end;

Replacement for the event OnAfterCreateDimTableIDs
[IntegrationEvent(false, false)]
local procedure OnBeforeCreateDimProcedure(var ItemJournalLine: Record "Item Journal Line"; CurrFieldNo: Integer; var DefaultDimSource: List of [Dictionary of [Integer, Code[20]]]; InheritFromDimSetID: Integer; InheritFromTableNo: Integer)
begin
end;

@AlexanderYakunin this is mostly an event request, that is need because of refactoring of the base application.
Can i provide you with any information to clarify this issue?

I checked the latest code for BC21 and no change was made.
In previous version we could subscribe to the event OnAfterCreateDimTableIDs to add additional Tables and values to the the following arrays: var TableID: array[10] of Integer; var No: array[10] of Code[20].
In most of the other Tables like "Sales Header"/"Purchase Header", I can refactor my code, to use the event OnAfterInitDefaultDimensionSources instead of the event OnAfterCreateDimTableIDs - and everything is alright.
My current problem with the refactoring is, that in the table "Item Journal Line" the event OnAfterCreateDimTableIDs has been called two times.
What I'm mostly missing is an event in procedure CreateDimWithProdOrderLine. Then I could replace my current subscriber with two new subscribers:
//OLD Code
/*
    local procedure CreateDimWithProdOrderLine()
    var
        ProdOrderLine: Record "Prod. Order Line";
        InheritFromDimSetID: Integer;
        TableID: array[10] of Integer;
        No: array[10] of Code[20];
    begin
        if "Order Type" = "Order Type"::Production then
            if ProdOrderLine.Get(ProdOrderLine.Status::Released, "Order No.", "Order Line No.") then
                InheritFromDimSetID := ProdOrderLine."Dimension Set ID";

        CreateTableArray(TableID, DATABASE::"Work Center", DATABASE::"Salesperson/Purchaser", 0);
        CreateCodeArray(No, "Work Center No.", "Salespers./Purch. Code", '');
        OnAfterCreateDimTableIDs(Rec, CurrFieldNo, TableID, No);
        PickDimension(TableID, No, InheritFromDimSetID, DATABASE::Item);
    end;
*/

//NEW Code
    local procedure CreateDimWithProdOrderLine()
    var
        ProdOrderLine: Record "Prod. Order Line";
        InheritFromDimSetID: Integer;
        DefaultDimSource: List of [Dictionary of [Integer, Code[20]]];
    begin
        if "Order Type" = "Order Type"::Production then
            if ProdOrderLine.Get(ProdOrderLine.Status::Released, "Order No.", "Order Line No.") then
                InheritFromDimSetID := ProdOrderLine."Dimension Set ID";

        DimMgt.AddDimSource(DefaultDimSource, Database::"Work Center", Rec."Work Center No.");
        DimMgt.AddDimSource(DefaultDimSource, Database::"Salesperson/Purchaser", Rec."Salespers./Purch. Code");
        //Missing Event Similiar to OnAfterInitDefaultDimensionSources to replace the previous called event OnAfterCreateDimTableIDs
        CreateDim(DefaultDimSource, InheritFromDimSetID, Database::Item);
    end;

@AlexanderYakunin I'm really looking forward for feedback from you side.

We plan to fix it in early December

@AlexanderYakunin i have checked the latest BC21.3 Release, but I didn't see any change in the code base.

@AlexanderYakunin can I hope for something in BC22?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 53886.

Availability update: We will publish a fix for this issue in the next update for release 22.
Build ID to track: 53932.


bug: return a proper 400 error for too-long xmlFormIds

as seen here: https://sentry.io/organizations/opendatakit/issues/862023665/?project=1298632
postgres error 22001 indicates that a value is too long for the field. we limit xmlFormId to 64 bytes so we should inform the user if they have selected too long of a name.

@opendatakit-bot claim


In UWP app if the option compile with .Net native toolchain is enabled , an unhandled exception in windows.ui.xaml.dll is thrown.

In UWP app when trying to access .xaml files from a uwp class library and if the option compile with .Net native toolchain is enabled , an unhandled exception in windows.ui.xaml.dll is thrown. Kindly let me know if there is any fix for this issue. Note: If the option compile with .Net native toolchain is disabled the app runs normally without throwing an unhandled exception.
Please find below the error displayed
Unhandled exception at 0x00007FFF5936E831 (Windows.UI.Xaml.dll) in [ProjectName].exe: 0xC000027B: An application-internal exception has occurred (parameters: 0x0000013429F4BF50, 0x0000000000000003).

This repo is not the right place to report UWP .NET Native issues.
Could you please report it via https://developercommunity.visualstudio.com/ ?


Long-press and drag on buttons drags the map, but shouldn't

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce
Long-press and move the mouse around within any button (e.g., the zoom buttons) and you will see the map move underneath button as though you were dragging the map. This should not happen. This happens with native Leaflet buttons, leaflet-draw buttons (which are like native buttons, using anchors not true buttons), and leaflet-easy-button buttons (which are true buttons).

Leaflet version I'm using: 0.7.7 and 1.0.3
Browser (with version) I'm using: Chrome Version 55.0.2883.87 m
OS/Platform (with version) I'm using: Windows 7

What behaviour I'm expecting and which behaviour I'm seeing
Map should not drag/move, but it does.
Minimal example reproducing the issue
See above.

[x] this example is as simple as possible
[x] this example does not rely on any third party code

Using http://playground-leaflet.rhcloud.com/ or any other jsfiddle like site.

Hi,
thanks for reporting. These problems comes from not properly disabling propagation of mousedown and click events from those controls.
For the zoom buttons, I've submitted #5318 to address this, but we can't do much about the controls in other plugins: these plugins must disable click propagation themselves, and you should open issues on the individual plugins.

Isn't disabling event propagation dangerous? For example, stopping the propagation of pointerdown events causes problems for Leaflet 1.0.3's management of pointer events. Wouldn't a better solution be to change the map's mousedown listener to see if the target matches the map div and only act on it if the two match.

@hanginwithdaddo hm, no, disabling propagation from controls is standard, and is already done by almost all controls. In this specific case, the zoom control didn't disable all the necessary events, though.
Leaflet's event design relies on events propagating from child elements to the map container in a lot of cases - in fact, having a mouse event with the map div (the container) as target is almost impossible, since you will almost always have multiple child elements covering the entire container (tile pane, vector overlay pane, etc.). So ignoring events with another target will not work.
Exactly what pointerdown stop problems are you referring to?

@perliedman I see that the current implementation of DomEvent.disableClickPropagation() stops mousedown and touchstart, but does not stop pointerdown - maybe this is causing some issues?

@IvanSanchez I noticed the same thing and thought about adding pointerdown - I didn't see any issues on Chrome 55/Ubuntu with a touch enabled laptop, though.

I just know that in integrating our stuff with Leaflet 1.0.3, Leaflet's internal pointer logic got messed up when I stopped the propagation of pointer events. This was running Leaflet 1.0.3 under the latest version of Chrome (Version 56.0.2924.87 (64-bit)) on both OSX and Windows See the following methods:
_globalPointerDown: function (e) {
	this._pointers[e.pointerId] = e;
	this._pointersCount++;
},

_globalPointerMove: function (e) {
	if (this._pointers[e.pointerId]) {
		this._pointers[e.pointerId] = e;
	}
},

I would think checking the target in the map's mousedown handler to see if it matches the map (or draggable element) would be a better solution since it's more central and would take care of the problem for buttons, including 3rd party plug-ins (i.e., in Draggable._onDown() -- I think this is the place).

Yes, stopping propagation of all pointerdown/pointermove events will certainly break a lot of stuff, since a lot of the event logic is built under the assumption that events will propagate to the map container; in this particular case however, that is exactly what we want to prevent: we do not want the map to assume this is a drag event on the map.
I don't know how familiar you are with the Leaflet event handling, but you should read up on #3307 for some of the reasoning behind the current implementation - quite a lot of thought has gone into this, so while we're of course happy to see suggestions for improvement, we're also a bit reluctant to change this critical piece.

Have you tested your change (stopping the propagation of only mousedown events) with Chrome Version 56.0.2924.87? Just curious, because I believe it was between versions 55 and 56 that Chrome changed to fully support pointer events, dispatching pointerdown, followed by mousedown for non-touch devices, and pointerdown, touchdown, and mousedown for touch devices.
Yes, I do understand that stopping the propagation of pointerdown/pointermove events will cause problems, which is why I raised my concerns earlier. The area where I know we caused problems for Leaflet was stopping the propagation of pointerdown events on SVGs when we didn't want the map to respond to the pointerdown events. All of this was at the raw DOM event level, not the leaflet level, similar to the mousedown solution that you've implemented under #5318.
Thanks for the additional reference.

I tested the mousedown/touchdown change using a class that we have sitting on top of the EasyButton() support and this works (stops the map from dragging). Looks like we don't need to stop the propagation of pointerdown events. Sorry for any confusion/raising additional concerns.

I tested your solution of stopping the propagation of just the mousedown/touchdown events using Chrome Version 56.0.2924.87 and a class that we have on top of the EasyButton plugin support  and it works. There is no need to stop the propagation of the pointerdown events. Sorry for causing any additional concern/confusion.

For IE, pointerdown events must be stopped as well. mousedown/touchdown are sufficient for Chrome and Firefox.
You need to apply a similar change to the layer widget, since long-pressing the layer widget as it is expanded causes the same problem.


"Uncaught TypeError: Cannot read property 'pfValue' of null" error

This bug is reproduced when the following steps are performed in order,

Open the default graph
Add a bend point to any edge
Remove that bend point
Undo last action
Redo last action

This bug seems to be fixed now.


request to add CameraUpdate.newLatLngBounds

Hi there, thanks for your awesome library.
I have just added a suggestion about adding new CameraUpdate.newLatLngBounds to animate camera to a bounds list but I can't push to create a Pull Request.
What should I now. Thank you.

Nvm, I just forked it.


download source for packages in different ecosystem

[x] Cargo
[ ] Composer
[x] Go
[x] Maven
[x] npm
[x] NuGet
[x] pip
[x] RubyGems

https://rubygems.org/gems/pony/versions/1.13

https://www.nuget.org/api/v2/package/Newtonsoft.Json/13.0.1

https://repo.packagist.org/p2/psr/log.json


Adds host and locales config variables to enable support for the free…

… maxmind geolite2 web service.

Do you mind reviewing this and merging into your next release? It would be a very helpful feature, otherwise I'll have to fork/maintain my own release to support this.


Simpler tokenizer

Groundwork for discussed simpler tokenizer that is agnostic of current html/angular state as discussed in 'Simpler Lexer Proposal'. It has minimal states just for better tokenizing results, but none that determines the validity of an html tag, comment, or text.
This can be easily merged into the existing scanner implementation by parsing through tokens instead of raw string. The existing scanner can be kept as a fail-fast version. A different version can be implemented that will not fail-fast but attempt to recover and inject synthetic nodes while also reporting errors.

recent changes look good! Still approved


Branch yuluan

Pull Request Template:
If you are merging in a feature or other major change, use this template to check your pull request!
Basic Info
What's this pull request about?

Add other_LIWC_features.py

Feature Documentation
Did you document your feature? Make sure you do the following before you pull request!

[ ] Copy the Template. Go to the Feature Wiki and Copy/Paste the Feature Template into a new page.
[ ] Fill out the Template. Fill out the basic information for the feature in the template. Use the template to document your plan for implementation and major design decisions; if anything changes along the way, update the documentation as you go.
[ ] At the top of my feature, I indicate whether the feature is conversation level or chat level.

Code Basics

[ ] My feature is a .py file.
[ ] My feature uses snake case in the name. That means the name of the format is my_feature, NOT myFeature (camel case).
[ ] My feature has the name, NAME_features.py, where NAME is the name of my feature.
[ ] My feature is located in feature_engine/features.

Testing

[ ] I have thought about test cases for my features, with inputs and expected outputs.
[ ] I have linked to a location (e.g., .py or .ipynb) where I can run my test cases and show they work (inputs match expected outputs).

The location of my tests are here:

[PASTE LINK HERE]

If you check all the boxes above, then you ready to merge!

Please ignore this PR. I will close this branch and make all the updates under branch_Yuluan_after_restructuring


feat(addition): add mostly adequate guide

Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource
For resources
Description
Professor Frisby’s Mostly Adequate Guide to Functional Programming
Why is this valuable (or not)?
A great intro to FP concepts and ideas written in Javascript so many can understand.
How do we know it's really free?
GitBook maintained by open source
For book lists, is it a book? For course lists, is it a course? etc.
Its a book.
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

Thanks, and welcome to free-programming-books!


Remove Rollup

Since everyone is using a module bundler/loader anyway, we shouldn't care about creating a separate UMD bundle

Coverage remained the same at 100.0% when pulling 2e099a6b6e74c8942bd781474b506a63f7b7a703 on no-rollup into bb4b4ac7c53d3be3b50bdd6dec74c648f7015fb4 on master.


Update documentation for newer Vault versions

The documentation for the Datastax Vault plugin is using a syntax for registering plugins that a bit outdated. Newer versions of Vault support vault plugin ... CLI commands. This PR reflects these updated commands.
Also added a section about upgrading the plugin (from binary distribution).

@olafz , my apologies because I just noticed this PR 25.  Coincidentally, I was making edits for the addition of standard and sidecar caller modes.  I've copied your edits from this PR into my slightly later PR.  I would have merged but noticed yours too late, and this might be a way to get both sets of edits without merge conflicts.

@olafz , please see https://github.com/datastax/vault-plugin-secrets-datastax-astra/pull/26.  We'll use this one instead of your PR 25 (my apologies) and THANK YOU for your contributions in this PR 25.  I've manually edits PR 26 with your contributions.  Again, sorry, done without merge - I didn't notice your PR in time.

We will keep your PR 25 open for now but eventually "Close with comment" and no merge.

@johnsmartco Your PR https://github.com/datastax/vault-plugin-secrets-datastax-astra/pull/26 seems to incorporate the changes in the documentation, so feel free to close this PR without merging.

Olaf's edits have been incorporated into PR #26.  (Thanks Olaf.). Closing this PR #25 without merge.


Updating Root Class for 'Documentation' Thumbnail

@d45

Thanks, @greg-fix. We fixed this a while back when we added more tiles.


startTest & start Deploy from script

Hi
I see in https://github.com/Strider-CD/strider/blob/master/lib/views/partials/_dashboard_row.html#L22 the mechanism to startDeploy with ng-click="startDeploy(job)" attribute on an html span.  I would like to do it from
 cy.on('cxttap', 'node', function(evt){
  //console.log( "hey!" ); // 'bar'

  var node = evt.cyTarget;
  node.animate({
      style: { backgroundColor: 'red' }
    }, {
      duration: 1000
    });
//kick a manual test of project and DAG tree algorithm if successful
 ???   startTest(node.data('job'));
});

Trying to get familiar with the code and dependent technologies.
I see $scope.startTest = function (job) at https://github.com/Strider-CD/strider/blob/master/client/dashboard/controllers/dashboard.js#L24
but not finding how to trigger from script code. Howto?

If you have access to $scope, then you can do $scope.startTest(job)

Thank you


⚠ Bofrost.nl has degraded performance

In 1a18c6d, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1344 ms

Resolved: Bofrost.nl performance has improved in 2fbd7a6.


storage: Expand semanticID Query

Currently, the semanticID query functionality only remembers the Identifiable in which the semanticID appeared. This should be expanded to also keep track of the AssetAdministrationShell object in which the Identifiable (for example the Submodel) is, since Submodels do not have a reference to the AssetAdministrationShell they're in.

Fixed with https://github.com/acplt/aas_repository_server/pull/9


Puzzle naming system

Note: This is functional, there are currently some holes in the system that can result in obtaining dummy items. This is currently a low-priority issue though because it shouldn't effect any functionality.


Add standard.js to package.config

https://standardjs.com/

A little too much crappy code to fix for now.


Publish helm chart version 0.6.1

The documentation in https://docs.cert-manager.io/en/latest/getting-started/install.html references version 0.6.1 of the cert-manager helm chart. But you have not actually released that version, the latest one in the stable repos is 0.6.0.

I've had a PR open for a while now: https://github.com/helm/charts/pull/11168
I also want to cut v0.6.2 today, and we're already a patch version behind. I'm going to be moving us over to using charts.jetstack.io for chart publishing today, as it's not really manageable to be this far behind.
In the meantime, you'll need to clone a copy of this repo in order to use the new version of the chart.

Guessing the PR might be lagging since some tests are failing.
It's not important for me which version of the chart I use as long as it works ;)

This is now done 😄

@munnerz the documentation itself is still wrong. Latest shows the helm command with an attribute --version v0.6.2 which throws an error.


Intl.NumberFormat.prototype.formatToParts support

Proposal
Chrome: Flagged since ?, default since 64
Firefox: Flagged since 53, default since 58
Safari: Flagged since ?, default since TP 88

Closed in favor of https://github.com/Fyrd/caniuse/issues/5045#issuecomment-629593653


QA Testing and Performance Enhancements

Run test cases
List all crashes and do root cause
Final performance enhancements

Any SemanticSearch key errors should be investigated for cache coherency

execve to srop after cache clear caused a key error

Clean up constants and improve speed


Missing information

🚨 Looks like you arrived from the internal review site
🚨 Do not enter Microsoft confidential information here
[Enter feedback here]
There is missing information on how to disable this feature...
If you see the link, it states is enabled by default, then it says... to disable this feature... and does not explain how.
https://review.learn.microsoft.com/en-us/power-bi/enterprise/service-premium-scale-out?branch=pr-en-us-8660#disable-power-bi-query-scale-out

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b3d4befd-cdb9-2add-1b27-114166b21526
Version Independent ID: b3d4befd-cdb9-2add-1b27-114166b21526
Content: Power BI Premium Scale-out - Power BI
Content Source: powerbi-docs/enterprise/service-premium-scale-out.md
Service: powerbi
Sub-service: powerbi-premium
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Thanks for your comment, @prvillal. This issue has been assigned to the doc author for review.

Hi @prvillal,
Thanks for letting us know. This article was accidently published prematurely. I'll remove this section and republish the article with the required information shortly.
Thanks,
Kesem


Dashboard: Functionalities page

This ticket continues on #307. You can continue working on that branch.

Remove the functionalities from the new /customers/signup page

Automatically add these 5 modules

BROADCAST
BULK_INVITE
QR_CODES
STATIC_CONTENT
WHEN_WHERE

Remove the Coaching Sessions / News (Dashboard) page from the dashboard
Replace it by the new Functionalities page

This button has the same style as the inbox / news / ... navigation buttons
Show the 6 major functionalities in tiles

News & Actions
Loyalty
E-Shop (= advanced order)
Sandwich reservations
Restaurant reservations
Menu Card
Agenda

A tile contains

the functionality name (clickable)
a fa-cog icon to go to the settings of that functionality
a video

in case the functionality is enabled, this will be a tutorial video
in case the functionality is not enabled, this will be a video which shows why people would use this functionality

a description
at last, a line which say "Enabled" or "Disabled" on the left, and a switch (like an ios switch) to enable/disable the functionality

News cannot be disabled

Roel will create a design for the tiles at Tuesday, you can already start on the basic layout of the page, the modelling, the bizz methods to enable/disable functionalities etc.
On this sketch I've put 2 tiles next to each other, but there will be 3 tiles next to each other.

I think that we need to merge #320 first.

Ok, no problem. Because we're falling behind in reviewing your work, you can always create your branches from an existing branch that needs review, if you need stuff from that branch.

you can implement #340 first

I received the mockups from Roel.
New-dash-OSA.pdf
OSA mockedup-CSS.txt


Slightly confusing step in the Getting Started guide

Hi!
I started yesterday with some of the VL tutorials and I found a slightly confusing step in the Getting Started guide. It's very basic and easy to understand but I just wanted to share it as for a completely noob like me was not crystal clear at first.
In the step when the user defines the layer
const layer = new carto.Layer('layer', source, viz);
layer.addTo(map);
there is a link to an example with the result where you can see the map with all the dots. But what the user gets at that point with the code examples is an empty map as the dots don't render until you declare viz, that is in the next section and that should be above it in the users code.

Sorry, if I misunderstand something. Yesterday was my first try and the documentation was super helpful :)

Yes, I agree this is confusing. I think we could move the style definition to be above the layer definition.
cc: @IagoLast @arianaescobar

@kukukaka thank you for the feedback!
@davidmanzanares What about moving the map example to the style definition instead? In my mental model, you can't define a style if you don't have a layer to style, so changing the order might make it confusing as well.

What about moving the map example to the style definition instead?

What do you mean? :confused:
I think of a style/viz as a requirement for creating the layer, which I think it's a common pattern.
However, I just spotted another problem, it says "Defining the style", but it should say "visualization".

IMO we should move the defining the viz step just before defining the layer

@arianaescobar Yes, I see what do you mean. Could we have a final section that summarizes it all, and says something like "with all those steps together you get this example map"?

@davidmanzanares Yes, definitely!
But if you guys are sure about reordering the steps, go ahead.

so... what do we do here?

Move the viz step on top of the layer step and only keep the final example at the end.


add back built-ins and add exit. (first pull to start implementing v coreutils)

It adds back the built-ins and fixes the missing exit command.  I think the only coreutil that we need to implement in this is pwd so we can put full functionality.  I'll open another pull to implement it if you want me to.

I also found out that V is not planning on making the cd command in there coreutils.

Thanks.  I'll look this over


How to purge Index?

How would one go and delete either portions of the index or all entries?  I am looking to reharvest my geoportal index.  Do I do this directly with elastic search?  Or is there a simple way through geoportal?

to wipe the index you'd run this command line (using curl) against your elasticsearch:
curl -XDELETE http://localhost:9200/<indexname>

Be warned: it is gone!

Thanks.  Just to be sure this does not affect the originally harvested XMLs correct?  Just the index record within Geoportal?


Check that triggered has changed

good catch ;) I think the breaking build isn't related to your change - I'll figure it out!

Can you rebase on the latest master? That should fix the build.

Sorry I am not great at git. Will try to fix all the commits


Requre a finalize step

DoD:

When the finalize step is missing, the step fails with an error indicating the missing step.

Figured out it's much simpler to just assume that the last step is the finalized step. This requires no change in the code and pretty much a pattern for writing scripts anyway.


Experiment: Allow using pip 23.1.x with Python 3.12

This adjusts the Python version upper bounds for the pip 23.1.x series, since they seem to work with Python 3.12 locally, but this was excluded by the range.
In #2172, support for Python 3.12 was added to pex. At that time, it seemed like pip 23.1.x didn't work with Python 3.12, but, some naive tests suggests it does, now:
python3.12 -m venv /tmp/venv-3.12
. /tmp/venv-3.12/bin/activate

python -m pip install -U pip==23.1 setuptools==67.6.1 wheel==0.40.0
python -m pip --version # pip 23.1 from /private/tmp/v312/lib/python3.12/site-packages/pip (python 3.12)

# example:
python -m pip install pandas

Does pex's CI agree? Is there background to the ranges chosen #2172 that isn't recorded somewhere I could find?

CI gave you at least 1 answer, pkgutil.ImpImporter is gone in 3.12 and that Pip needs it: https://docs.python.org/3.11/library/pkgutil.html#pkgutil.ImpImporter
@huonw perhaps a good question is why you're trying to search for a mistake here. Is there some need driving wanting older Pip to work with 3.12? I could've messed up but I also sunk alot of time into this transition to be ready on time for Pants, etc since I initially thought it would require cutting Pex 3 / dropping Python 2.7 support.

Brief reply to start with because I'm on mobile: I'm investigating behaviour here because pip 23.1 is apparently working for me on arm macOS with Python 3.12, as you can see in the description (and, for instance, the same steps with an earlier version do not work, and fail with errors similar to CI here).
I'm not looking for a mistake (I apologise if it came across that way) or demanding more of your time. In fact, it's an attempt at the exact opposite: I'm doing the debugging/experimenting myself so I'm more informed before asking you any questions/getting reviews etc.

Ok. Well, perhaps most simply, your quick check used pip install. There are 3 types to check there: wheel, sdist PEP-517/518 & sdist setup.py. More direct though is pip debug, which Pex uses to implement --platform:
(venv-3.12) jsirois@siroisdesign:~$ pip debug
WARNING: This command is only meant for debugging. Do not use this with automation for parsing and getting these details, since the output and options of this command may change without notice.
pip version: pip 23.1 from /tmp/venv-3.12/lib/python3.12/site-packages/pip (python 3.12)
sys.version: 3.12.1 (main, Jan  1 2024, 16:01:25) [GCC 9.4.0]
sys.executable: /tmp/venv-3.12/bin/python
sys.getdefaultencoding: utf-8
sys.getfilesystemencoding: utf-8
locale.getpreferredencoding: UTF-8
sys.platform: linux
sys.implementation:
  name: cpython
'cert' config value: Not specified
REQUESTS_CA_BUNDLE: None
CURL_CA_BUNDLE: None
pip._vendor.certifi.where(): /tmp/venv-3.12/lib/python3.12/site-packages/pip/_vendor/certifi/cacert.pem
pip._vendor.DEBUNDLED: False
vendored library versions:
  CacheControl==0.12.11
  colorama==0.4.6
  distlib==0.3.6
  distro==1.8.0
  msgpack==1.0.5
  packaging==21.3
  platformdirs==3.2.0
  pyparsing==3.0.9
  pyproject-hooks==1.0.0
  requests==2.28.2
  certifi==2022.12.07
  chardet==5.1.0
  idna==3.4
  urllib3==1.26.15
  rich==13.3.3 (Unable to locate actual module version, using vendor.txt specified version)
  pygments==2.14.0
ERROR: Exception:
Traceback (most recent call last):
  File "/tmp/venv-3.12/lib/python3.12/site-packages/pip/_internal/cli/base_command.py", line 169, in exc_logging_wrapper
    status = run_func(*args)
             ^^^^^^^^^^^^^^^
  File "/tmp/venv-3.12/lib/python3.12/site-packages/pip/_internal/commands/debug.py", line 195, in run
    show_vendor_versions()
  File "/tmp/venv-3.12/lib/python3.12/site-packages/pip/_internal/commands/debug.py", line 101, in show_vendor_versions
    show_actual_vendor_versions(vendor_txt_versions)
  File "/tmp/venv-3.12/lib/python3.12/site-packages/pip/_internal/commands/debug.py", line 81, in show_actual_vendor_versions
    actual_version = get_vendor_version_from_module(module_name)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/venv-3.12/lib/python3.12/site-packages/pip/_internal/commands/debug.py", line 61, in get_vendor_version_from_module
    module = get_module_from_module_name(module_name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/venv-3.12/lib/python3.12/site-packages/pip/_internal/commands/debug.py", line 56, in get_module_from_module_name
    __import__(f"pip._vendor.{module_name}", globals(), locals(), level=0)
  File "/tmp/venv-3.12/lib/python3.12/site-packages/pip/_vendor/typing_extensions.py", line 1174, in <module>
    class TypeVar(typing.TypeVar, _DefaultMixin, _root=True):
TypeError: type 'typing.TypeVar' is not an acceptable base type
(venv-3.12) jsirois@siroisdesign:~$

Okay, thanks for the fish.

For completeness, when trying to get a gut feel for this sort of thing, know Pex actually uses all of pip {download,wheel,install,debug} in one form or another (at least historically, pip install use just got dropped in the last few releases).

Right, that's helpful gut feel.


Mention the example Jar URI earlier

As I was going through the getting started guide when creating the deployment I needed to enter the Jar URI. In the screenshot I saw a long, non-copyable URL and I felt lost at whether I should copy it or what I would have to provide. Only after a little bit I noticed the info box which is way below.
I think there are two improvements to be made:

The list with explanations for each required input (name, deployment target, …) should come before the screenshot.
This description for Jar URI should already mention the example URI.

Thank you. Done. Change will go live with the next release.


[Feature] Option to set a downloaded file size limit for rule provider

Verify Steps

[X] Tracker 我已经在 Issue Tracker 中找过我要提出的问题
[X] Latest 我已经使用最新 Dev 版本查看过，并不包含该功能特性或者还不完善
[X] Relevant 我知道 OpenClash 与 内核(Core)、控制面板(Dashboard)、在线订阅转换(Subconverter)等项目之间无直接关系，仅相互调用
[X] Definite 这确实是 OpenClash 应包含的特性
[X] Contributors 我有能力协助 OpenClash 开发或完善此功能特性
[X] Meaningless 我提交的是无意义的催促更新或修复请求

Describe the Feature
Hi and thanks for the program!
On some routers there is a need to conserve resources heavily and sometimes updates of rule lists can cause unforeseen problems. It would be easier to solve them by noticing a warning in the logs rather than looking for the cause of performance problems. So I want to suggest an option to set a downloaded file size limit for rule provider.
For example, something like this:
rule-providers:
  example:
    type: http
    behavior: classical
    url: "https://..../file.yaml"
    path: "./ruleset/file.yaml"
    format: yaml
    proxy: Proxy
    interval: 86400
 size-limit: 100kb
Describe Alternatives
If file size checking is problematic, then it can be a script as an option to create and use a temp directory with a limited size (e.g. using tmpfs).

Please go to the mihomo project to resubmit your proposal

Please go to the mihomo project to resubmit your proposal

Sorry for a silly clarification: is github.com/MetaCubeX/mihomo/ the correct repository?

yes


Fix properties.Property.equal bug

Since properties.Property.equal simply used == it could return an array of booleans given certain input type (eg. numpy array). This fix now causes properties.Property.equal to return a single bool if == returns an iterable.
This PR also includes a bit of constraint on equal and change notification input. Namely None/properties.undefined should never be passed to equal, and properties.undefined will be used as previous and value in the change notification dictionary if no value is defined (as opposed to None).

Codecov Report

Merging #151 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #151      +/-   ##
==========================================
+ Coverage   96.64%   96.64%   +<.01%
==========================================
  Files          14       14
  Lines        1756     1761       +5
==========================================
+ Hits         1697     1702       +5
  Misses         59       59

Impacted Files
Coverage Δ

properties/handlers.py
98.93% <ø> (ø)
:arrow_up:

properties/base/base.py
98.65% <100%> (+0.01%)
:arrow_up:

properties/basic.py
97.23% <100%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52e2d4...4980992. Read the comment docs.


Fixed binding of dispatchCustomEvent function

What changed in this PR:
Using an arrow function to properly bind this inside the dispatchCustomEvent function.

Sorry I haven't seen that there already is a PR for this bug #115.

@fbring I'd like to merge this but you'll need to increase the bundle size slightly like in #115


Example and docs update

Bring examples up to date with #133 and #136
Add rhino-shapley-interop to docs dependencies
Miscellaneous updates

@robbievanleeuwen I was hoping that the requirements file would be a quick fix. I checked locally that the requirements file does work. From the failed build logs it looks like rhino3dm needs CMake to build. I found a possible solution in the readthedocs documentation: Configuration File V2. I plan to read up on this further.

Ok looks good! Let me know if you need me to make any changes to the admin settings :+1:

@robbievanleeuwen @connorferster @Spectre5 I'm out of idea on getting the docs to build. To me, it seems the current build error is in Triangle and caused by an environmental variable. Interestingly enough it affects only one example. Any ideas are welcome.

You might try printing the value of locale.getlocale(locale.LC_NUMERIC) before running the docs (maybe in the conf.py file), just to see exactly what it is returning.  I'd expect it to be (None, None), which should be fine to pass to setlocale: locale.setlocale(locale.LC_NUMERIC, (None, None)).
Another idea would be to set the locale before the examples run.  Again in the conf.py file, you could do locale.setlocale(locale.LC_ALL, '').
It might be an issue with the configuration of the readthedocs server setup.  I'm not really sure why it only happens in the 1 example though.
Note also that setting the locale is not thread-safe, but I don't think meshpy, sphinx, sphinx-gallery, nor sectionproperties are using threads here.  Further, it isn't really recommended to change the local settings more than once (per Python docs), though I can see why the meshpy team may need to here since they call the C code.
If the above suggestion does not help, I'd suggest opening an issue with the meshpy project and ask them to take a look since the error ultimately comes from the meshpy call to setlocale.  Perhaps they have seen similar issues in the past.

@normanrichardson Does it build if the first example is excluded? If so, what could be in the first, simple, example that causes this problem?

If meshpy continues to cause too many headaches do you think it might be worth jumping on #24 and implementing this for v2?
It shouldn't be a whole lot of work now that calculate_plastic_properties() is not mesh reliant.

I tried:

ignore 01_simple.py => fails in 02_nastran_section.py
set LC_NUMERIC in conf.py => fails in config.py
set LC_ALL in conf.py => fails in 01_simple.py

I took a quick look at the build logs...off the top of my head I don't have another great suggestion.  I think it only reports that failure on the first one run (i.e. it reported it on 02_ instead of _01 when you removed the 01_simple script).  The locale ('en_US', 'UTF-8') is valid, at least on Linux.  Some locales won't work well on Windows that do work on Linux.  But whatever gets reported by getlocale should be fine on the same system.  I wonder if readthedocs does something unusual?
Removing meshpy in favor of triangle is a potential option, but again I see why they do make sure it is a C locale when triangle runs, so we'd maybe want to consider doing it ourselves anyway.  Or else we could just document that unexpected results may occur if you don't ensure it is C locale first (and/or add more tests to ensure other locales work).
One more thing I would try --- is printing the result of getlocale again in the 01_*.py file itself, just to remove the possibility of it changing between conf.py being run and the example python file running.  A new Python process probably does start for running the example files.

@normanrichardson we've merged the triangle branch into v2 now with #153. Not sure what the best way to merge those changes into this branch is, but maybe worth having a shot with using triangle over meshpy for building the docs?

@normanrichardson we've merged the triangle branch into v2 now with #153. Not sure what the best way to merge those changes into this branch is, but maybe worth having a shot with using triangle over meshpy for building the docs?

Yes, you can pull the v2 changes into your branch and then (hopefully) the docs should build nicely.

I will try merging the v2 branch into @normanrichardson's branch and see what happens...

Nice! The docs builds!

Alright! Now we are cooking with gas! It looks like all tests pass (except the black).
Do you think we are good to merge this @robbievanleeuwen?

Awesome! Yeah probably worth just merging straight to v2 instead of docs/examples.

Great to see it coming together


Generated Python project references "Readme.md" in package.xml, but file is actually "README.md".

This causes package build issues on Linux / MacOS (case-sensitivity); this is most obvious when trying to package a plugin a Ubuntu runner in a Github action.
Recommendation is to fix case sensitivity to README.md in package.xml.

This was fixed by: https://github.com/opentap/OpenTap.Python/commit/ed7c3682b484f74a7251da931573b1cf3789c314


How do you generate libreoffice sources?

I can't figure out how to run generate-libreoffice-srcs.sh.
There's a comment at the top that seems to be a hint, but I don't know what it means:
# Take the list of files from the main package, ooo.lst.in

# This script wants an argument: download list file

This is some very... advanced... bash for me, and I'm not making much progress trying to read the code. Should we consider rewriting this is something that might be easier to read?
cc @7c6f434c

I can't figure out how to run generate-libreoffice-srcs.sh.

You get the source package, you unpack download.lst from the source
package, you pass the full path to download.lst as the only parameter to
the script, you redirect the output of the script to a .nix file.

This is some very... advanced... bash for me, and I'm not making much progress trying to read the code. Should we consider rewriting this is something that might be easier to read?

Given that most such rewrites end up being rewrites into Perl, the
result will not be necessarily easier to read.
download.lst doesn't have fully consistent format, so the code parsing
it doesn't really have an option of being straightforward…

Given that most such rewrites end up being rewrites into Perl

I was probably going to suggest Python.

Note that we should change the script to not use md5. The upstream doesn't plan/want to move away from it, so it will be tedious for us a bit.

to not use md5

(That's why I'm looking into this script, by the way.)

/cc #4491.

With #18682, the answer to this question should be clear now.


Upgrade node version in actions

When running GitHub Actions displays a warning message :
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

We should fix it.

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

With React 15.5, importing PropTypes from React is deprecated in favour of importing from the new 'prop-types' package.
Please substitute the following:
import React, { PropTypes } from 'react';
With:
import React from 'react';
import PropTypes from 'prop-types';
You obviously need to install the package prop-types

This should handle it, as well as prepare it for use after 16.0.0

Thanks to @awitherspoon, this is now in master. Will do a release soon!

@Raathigesh congratulations on relocation!
Sorry for bothering. Would you be able to release new version with React 15.5+ support, please?

Hey @hudochenkov
Thank you and here is the release https://github.com/Raathigesh/dazzle/releases/tag/1.2.6.
Let me know if you run into any issues.


event ordering bug

compare by startTime and endTime, not startTime.hour and endTime.hour

Fixed with latest commit


Codelens keeps jumping around as user types

Does this issue occur when all extensions are disabled?: Yes

I'm using react-monaco-editor v0.54.0, which uses vscode packages mentioned here: https://github.com/microsoft/monaco-editor/blob/main/package.json.

OS Version: macOS Sonoma 14.0

Steps to Reproduce:

Render few simple codelens in the editor window with a YAML Document.
Press newline line/hit enter.Edit codelenses keep disappearing and reappearing.

https://github.com/microsoft/vscode/assets/48940704/5dca4ea6-ce27-40d2-a7ef-2d038dcdb22d

Hi thank you for filing this issue. This appears to likely be caused/related to the gitlens extension. This issue should be filed directly in the extension repo here: https://github.com/gitkraken/vscode-gitlens. I will close this issue.

I checked our document on the working areas, indeed you are right, code-lens is a built in feature. I will assign this issue to the person responsible.

@vardanbansal-harness What code is computing the code lens? Is that you? Can you share this? Can you guarantee that it never errors nor returns something empty during typing?

Thanks for taking a look here, @jrieken. To give some context, I have a monaco editor instance rendering some yaml, and I'm making editor.getModel().findMatches() call to obtain some Positions, against which I register code lenses based on the occurrence of - name: token. What I see happening is as I type, I see the code lenses flickering, they disappearing and reappear. From what I could debug, the underlying editor model change seems to be causing it but unable to fix it.

Hey @jrieken, this issue might need further attention.
@vardanbansal-harness, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Pomcp doesn't work in MOS

So I wanted to run the multi_object_search with pomcp. I changed sensor from proximity to laser.
problem = MosOOPOMDP(
        robot_char,  # r is the robot character
        sigma=0.05,  # observation model parameter
        epsilon=0.95,  # observation model parameter
        grid_map=grid_map,
        sensors={robot_char: laserstr},
        prior="uniform",
        agent_has_map=True,
    )

and belief_rep to particles
def __init__(
        self,
        robot_id,
        env=None,
        grid_map=None,
        sensors=None,
        sigma=0.01,
        epsilon=1,
        belief_rep="particles",
        prior={},
        num_particles=100,
        agent_has_map=False,
    ):

at first it gave me this error:
File "/home/pomdp-py/pomdp_py/problems/multi_object_search/agent/belief.py", line 74, in initialize_belief
    return _initialize_particles_belief(
TypeError: _initialize_particles_belief() missing 1 required positional argument: 'robot_orientations'

since robot_orientations isn't used in the function, I just set it to None. Then it gave me this:
  File "/home/pomdp-py/pomdp_py/problems/multi_object_search/agent/belief.py", line 139, in _initialize_particles_belief
    init_robot_pose = list(prior[robot_id].keys())[0]
AttributeError: 'int' object has no attribute 'keys'

Now I'm not exactly sure what to do. From what I saw, when initalize_histogram_belief did it, the output of prior is {-114: {(7, 9, 0): 1.0}} while in initialize_particles_belief, the output of prior is {-114: 0}.

Hmmm, this may be a bug. I am not exactly sure what's happening here (it's been a while ...)

I've been trying to debug it, but I'm still new to pomdp_py and the MOS concept. I notice that in multi_object_search/agent/belief.py, for particle, it didn't input prior to particles.
if representation == "histogram":
        return _initialize_histogram_belief(
            dim, robot_id, object_ids, prior, robot_orientations
        )
    elif representation == "particles":
        return _initialize_particles_belief(
            dim, robot_id, object_ids, robot_orientations, num_particles=num_particles
        )

so I'm not sure where the priors are coming from, but it shouldn't just be 0. I tried putting prior in but it just leads to another problem.

Oh, nice catch. I do notice the way _initialize_particles_belief is used is different from how it's declared. Code reef: https://github.com/h2r/pomdp-py/blob/main/pomdp_py/problems/multi_object_search/agent/belief.py#L122
I think I haven't run MOS with particle belief in a long while, and almost always used histogram + POUCT.  That's why this was not fixed. Should not be difficult to fix though - feel free to give it a try!
Also, why use POMCP / particles? It's not going to work well because of particle depletion.

Well because in the MOS 2019 paper it said to use POMCP. Is POUCT better in this situation? Also, could you elaborate on particle depletion?

You should read the paper more closely. OO-POMCP actually uses a histogram belief. Regarding particle deprivation, check out particle filters.
In short, if you’d like to try the algorithm from that paper, the closest approximation in this library is the POUCT + histogram planner in MOS.

When I ran it with POUCT histogram, its reward is 3923 so it only found 4 targets even though there are 5 set targets.
Also, is it possible to run histogram belief with POMCP? I only did particle filters because it said that's how you can run POMCP.
Another thing I notice is in multi_object_search/env/env.py when I set occlusion to True in make_laser_sensor(90, (1, 4), 0.5, True) it gave me error.

It's not perfect :) do you expect robots to be able to find objects 100% of the time?
Yes, POMCP expects particle filters. POUCT can work with any belief representation.
Occlusion is implemented here in the Laser2DSensor in components/sensor.py. I believe it was working at some point. You could try installing an older version of pomdp-py, like pip install pomdp-py==1.2.1. Note that occlusion implemented here is not ideal. See note here: https://github.com/h2r/pomdp-py/blob/main/pomdp_py/problems/multi_object_search/models/components/sensor.py.
Besides, check out this repo which implements a different style of occlusion by walls (not perfect still, but is more appropriate than the grid-based method here):

Just a reminder that you might have to dig through some debugging to get it working... I haven't run it in years. I don't have the time now to test / fix things. Feel free to fork and build on these repos.

You can try to post the error message. I'll see if I can help. In any case this is good information for others.

Thank you for the detailed response. I have a few more questions:

This might be a bit of a nitpick. If OO-POMCP actually uses a histogram belief, how does that work since POMCP requires particle beliefs. In the ICRA2019, as I understand it OO-POMCP uses explicit, extract belief update per object distribution to eliminate particle decay. Is that the histogram belief?
So I don't expect the robot to find objects 100% of the time. In the paper, it was able to find most if not all the object over many trials simulations as shown in the cumulative reward vs number of objects graph. Does that mean that if I run MOS multiple times, it should find most if not all on average (I ran it a few times and it is usually able to find 4/5 objects)?
If I get POMCP working with particle in the code, it would still have particle decay problem since it uses POMCP belief, not OO-POMCP belief?
Is there an implementation of Iterative OO-POMCP?

Those are good questions. Thanks @khuechuong.
I'm not representing the authors, but I personally think the naming of OO-POMCP is unfortunate. It should be "OO-POUCT", since the paper used histogram beliefs. I had the same questions years ago when I started.
In short: When you run MOS in pomdp_py with a histogram belief (for the object beliefs in the agent's OOBelief), you are running "OO-POMCP" -- so the code is here. It is not the original code behind that paper (which was in Java), but it should capture the same ideas. Also, the original paper used a room-based representation which isn't in pomdp-py's MOS domain, but that's not the main point.

Okie. OO-POUCT ;) Also for the transition state probability, I notice that of them are fixed numbers. Is that simulation only or also in real life?
Is this 1 version of the ICRA 2019 code: https://github.com/awandzel/multiobject_search_oopomdp

regarding the POUCT. It seems that to be able to use the POUCT, it requires me to give it the number of objects. Is there a way to formulate it without giving the the number of targets? A way I could think of is maybe up the number targets so agent can find max number of target it could, but I feel that's a bandage solution.

POUCT is independent of the domain. I am not sure what you are talking about. Where do you specify the number of objects?
And yes of course, that’s possible. But you would need to change state representation to be e.g. coverage; this requires your own implementation . Or, you could set the number of targets to be 1, or some other fixed number, and keep re-creating/running them pomdp agent until times up.

So basically in MOS, the belief is always set with size of number of target + robot. So if there are 5 targets, the size of agent.cur_belief.object_beliefs is 6. So basically the agent knows how many objects are available. I was just wondering an elegant way of object search without knowing how many objects are in the environment.

Mmm, what is elegant to you?  It's possible to estimate the number of targets as well - Check out the GM-PHD filter for multi-target tracking that can deal with time-varying number of targets. My collaborator Yoon also worked on this regarding searching and tracking: https://yoonchangsung.com/pub/gm-phd-tase-2021.pdf  But to me, practically, being able to apply a simple POMDP (single/fixed-number of targets) in the unknown case seems elegant as we didn't need to come up with something more complicated.
Regarding the second question, check out the gif above. You could come up with a belief scheme over known locations and frontiers. This is also a worthwhile research direction.

Mmm, check out the GM-PHD filter for multi-target tracking that can deal with time-varying number of targets. Also check out this work regarding searching and tracking of unknown number of targets: https://yoonchangsung.com/pub/gm-phd-tase-2021.pdf But to me, practically, being able to apply a simple POMDP (single/fixed-number of targets) in the unknown case seems elegant as we didn't need to come up with something more complicated.
Regarding the second question, check out the gif above. You could come up with a belief scheme over known locations and frontiers. This is also a worthwhile research direction.

I noticed that implemented it in ROS also. did u have the histogram belief over all costmap cells or did u guys lower the resolution of costmap cells.
Also, regarding the sensor observation model, what's the point of event B? The observation is like event A where it is within the field of view, but from other sources? As far as I can tell, since event B has extremely low probability of getting chozen, it almost never happens and if argmax is True, it never happens. It just adds a random point.

Yes that's a valid idea. 3D-MOS updates belief only within the field of view but ensures normalization.

Hey @zkytony I have a question regarding the simulate of pouct. I'm not sure if I understand this correctly, but for MOS does the _simulate for pouct just use the environment given? If so, it wouldn't be partially observation since simulation just simulate what happens in the actually environment. Or am I misunderstanding something.


candlestick datetime

Hi Im trying to plot a candlestick chart and im getting an error that the date time parameter does not exist. I've tried the examples, can any one tell me were I'm going wrong. I'm using c#.
// foreach (var price in klines)
{
            var ohlc = new ScottPlot.OHLC(
                open: (double)price.OpenPrice,
                high: (double)price.HighPrice,
                low: (double)price.LowPrice,
                close: (double)price.ClosePrice,
               DateTime: price.CloseTime,
                timeSpan: 1.0 / 60 / 24);
            ohlcs.Add(ohlc);
        }  //

Thank you.

Hi, Ive resolved it. I changed datetime to timestart, and added  price.OpenTime.ToOADate().
//foreach (var price in klines)
{
            var ohlc = new ScottPlot.OHLC(
                open: (double)price.OpenPrice,
                high: (double)price.HighPrice,
                low: (double)price.LowPrice,
                close: (double)price.ClosePrice,
               timeStart: price.OpenTime.ToOADate(),
                timeSpan: 1.0 / 60 / 24);
            ohlcs.Add(ohlc);
        } //

Thankyou.


"GameManager"

Jira-Issue: GER-54

We need a script that controls when to show what, the loading of new Biomes, stores stuff (like which biome is currently being played) and also enables us to just... keep the player

Done in 1e04794


feat(web-app): sanitze remote mdx

Closes #692
@francinelucca is the real MVP of this PR! 🏆
Changelog
New

Added core Carbon components that are being used across mdx pages
UnknownComponent
mdx sanitizer plugin

checks components in AST against our list of components, and list of all html components, and replaces them with UnknownComponent if they aren't available.
Removes import / export statements
Removes any unknown variables

Error checking for improperly formatted mdx

Testing / reviewing
Inside of /pages/samples/remote-mdx-test.js replace line 34 with various pages and test.
'/src/pages/components/accordion/style.mdx'
'/src/pages/community/component-index.mdx'
'/src/pages/all-about-carbon/partners.mdx' /
'/src/pages/community/patterns/chatbot/overview.mdx'
'/src/pages/components/dropdown/code.mdx'
'/src/pages/data-visualization/complex-charts/index.mdx'
'/src/pages/components/date-picker/accessibility.mdx'

@francinelucca and I are going to work on splitting this out into its own package so we can hammer it with unit tests! 🔨

@francinelucca found another page that "breaks"
https://github.com/carbon-design-system/carbon-website/blob/main/src/pages/help/contact-us/index.mdx

./pages/assets/contact/index.mdx
Unexpected character @ (U+0040) in name, expected a name character such as letters, digits, $, or _; whitespace before attributes; or the end of the tag (note: to create a link in MDX, use [text](url))

The Carbon team can also be reached on Twitter:
[@\_carbondesign](https://twitter.com/_carbondesign?lang=en)

closing: we're starting over


Update Readme for Netlify's updated Next.js runtime

Netlify does support next/images and other new features of next.js now

Sorry for the late reply but nice to see Netlify has catched up!


Windows build flake: "Failed to connect to github.com port 443: Timed ou"t -- for multiple submodules

I don't think there's much that can be done about these timeouts.


[BUG] WHERE on a non-existent field should report the column doesn't exist

The below query, where the table does not have a 'size' column:
SELECT * FROM $satellites
WHERE size = 1

reports
Type mismatch, unable to compare OTHER (NoneType) with NUMERIC

rather than the field not existing

fixed


Update for CUDA12.6.1

xref: https://github.com/conda-forge/cuda-feedstock/issues/46

@conda-forge-admin, please restart ci


setup test/staging site with gatsby cloud

See the link below
https://www.gatsbyjs.com/docs/tutorial/getting-started/part-1/#build-your-site-with-gatsby-cloud
this staging site is mainly for the purpose of testing and demonstration

@laurilano  @cpalfonso
Any volunteer for this? The main purpose is to connect this repository to gatsby Cloud for a staging server.

@cpalfonso could you please look into this? thanks

@michaelchin all done, it's currently up and running at https://websitemain60061.gatsbyjs.io.


Change StringView constructor to take signed length.

Currently, It is possible to pass a negative size to StringView which due to implict casting creates bad values. We change signature to ensure we dont get passed bad values.
Fixes #4331.
Note, that we do not add this check for the user defined literal _sv since it's guaranteed to be non negative (https://en.cppreference.com/w/cpp/language/user_literal) .

Here are results of benchmark, they are almost similar :
With SV changes:

/Users/kpai/src/Velox/cmake-build-release/velox/type/tests/velox_string_view_benchmark
============================================================================
[...]ox/type/tests/StringViewBenchmark.cpp     relative  time/iter   iters/s
============================================================================
runStringViewCreate(INLINE_SIZE)                           11.14ns    89.76M
runStringViewCreate(NON_INLINE_SIZE)                        8.24ns   121.36M

without VELOX_CHECK in StringView:

/Users/kpai/src/Velox/cmake-build-release/velox/type/tests/velox_string_view_benchmark
============================================================================
[...]ox/type/tests/StringViewBenchmark.cpp     relative  time/iter   iters/s
============================================================================
runStringViewCreate(INLINE_SIZE)                           11.13ns    89.86M
runStringViewCreate(NON_INLINE_SIZE)                        8.24ns   121.36M

Validated that the call to StringViewConstructor is inlined.


Add support for game object particles

As unity particle systems cannot collide with each other, it is impossible to implement breakable bullet.

Game object particle has been already added.


Fix raw_reads count extraction.

Simplest fix. Assumes we can always multiply the number of reads by 2. Does not pull raw_reads from fastp JSON files.
raw_reads count extraction previously was accounting only for half of the reads.

@antgonza @mmbryant23 ready for review!

Fantastic, thank you! I'll wait to the qiita PR to be merged (after files are renamed) and this PR is cleaned up accordingly!


[Integration test]Add diskUsageThreshold to prevent bookie exit.

Motivation
The current GitHub action test will show that the disk space exceeds 95%, and then the bookie will detect that bookie exits, so fix this problem.

Modifications

Configuration parameter disUsageThreshold is 0.99 to prevent bookie exit.


https://github.com/FadeMind/hosts.extras/issues

Hi, I think you're the upstream for this... if not can you let me know? Thanks.
Citrix are a IT provider, their TLD is being blocked :-(
Match found in https://raw.githubusercontent.com/StevenBlack/hosts/master/data/UncheckyAds/hosts:
www.citrix.com

Please report issue directly to: https://unchecky.com/contact
This is only copy of used by app hosts file.
Regards