Add a generic error in failureData of AddComment

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/14735
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

Modify the backend so that AddComment throws an unexpected error (I just added a call to an unexisting function right after } elseif ($command === 'AddComment') {)
Send a comment
Check the comment shows with opacity, with the RBR dot and message and with the X in it
Check the LHN also has a red dot
Click on the X check it clears the comment, the error and the red dots

Offline tests

Same, but go offline before posting the comment and go online afterwards

QA Steps

I don't think this can be QAed since there's not a good way to force an error in the server
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Do we have testing steps? if not, I think this can be reproduced inserting a fake report in Onyx and then sending a comment on it, that will cause an error in the API

I added them above, but not sure how we will test in QA

It is not that easy, but web QA can be done the following way:

Block a user from talking to Concierge
Go to the Concierge chat with the blocked user
Inspect element and find the <textarea> of the composer and remove the disabled attribute

Type something and hit enter to submit

This is based on this check in the backend: https://github.com/Expensify/Web-Expensify/blob/1c6fc73e9e0ad01818d9b6ea22771ee319455fff/lib/ReportAPI.php#L414-L418

ok this is ready for reviewing.

It is not that easy, but web QA can be done the following way:

Ah cool, thanks for that. Added to the description

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

The red dot in the chat list remains there even after the error message clears:

I can't reproduce that, what was your backend change exactly?

The red dot in the chat list remains there even after the error message clears:

I can't reproduce that, what was your backend change exactly?

Sent you the details on new dot.

ok, yeah, talked 1:1 and the problem comes from the server, which is using clientID and not reportActionID, will send another PR for that, but there's another problem I saw with it, so will start a discussion in slack

I was also able to reproduce this issue.

The red dot in the chat list remains there even after the error message clears:

The red dot goes away only after Signing out and Signing in again.
https://user-images.githubusercontent.com/25876548/216554563-43cb5760-9f1a-4b5d-8685-272d4359fa68.mov

Thanks for reviewing @sobitneupane !

I was also able to reproduce https://github.com/Expensify/App/pull/14736#pullrequestreview-1281912569.

Don't worry about this one, it is being handled by another PR for the backend.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.2.65-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@iwiznia @aldo-expensify Good day! Can you please share the account credentials with QA team for testing this PR?
Thank you in advance.

@iwiznia RedDot in LHN only disappears after re-login. Is it ok?
https://user-images.githubusercontent.com/43995119/217039823-ac9c7678-1f6b-46c0-94d5-cee5e88c68b8.mp4

Yes, tha requires the server side fix that's not yet deployed.

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.65-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Cannot work on Windows.

is this meant to happen?
debugger config:

Add "terminal": "console", to your configuration and the error will go away. There are no dependencies on the python 3.8 version of sublime so the integrated terminal will not work.

thank you! what must i set up to get what is in the screenshot?

i can't seem to step through the code, what must i do to turn on disassembly?

i can't seem to step through the code, what must i do to turn on disassembly?

Did you compile your program with -g so it includes debug information?

oh, that solved the problem. thank you!


Write the #VIDEO content from USDB to #LINKS

Hello
Anyone or you bohning know how i can set int usdb_syncer i have the source code and can run it with python
Want write from the original USDB TXT file the:
#VIDEO:v=2wkekZpikbY,co=https://m.media-amazon.com/images/I/51XjAPo+HEL.jpg,co-crop=42-0-431-431,bg=2raumwohnung-503a7395adf6f.jpg
And in ready created TXT file from usdb_syncer
want it like
#LINKS:v=2wkekZpikbY,co=https://m.media-amazon.com/images/I/51XjAPo+HEL.jpg,co-crop=42-0-431-431,bg=2raumwohnung-503a7395adf6f.jpg
in the TXT file then of the Song
i tryed in song_loader.py  but after hours not find a way   dont knwo why or how
thanks
rgrads

The next release will support format versions 1.0.0 (#MP3), 1.1.0 (#MP3 and #AUDIO) and 1.2.0 (#AUDIO, #AUDIOURL, #COVERURL, #BACKGROUNDURL and #VIDEOURL) which are the agreed upon new tags to store that information. There will be no support for custom tags (see https://usdx.eu/format/).

thanks when next release ?
but how can use USDB Synvcer to only download the Text FIle from USDB ?
As want download more from USDB but only the Text Files without changes   if needed
or can you set in USDB Synce in settings options that can only download TXT or not remove the #VIDEO:v=2wkekZpikbY,co=https://m.media-amazon.com/images/I/51XjAPo+HEL.jpg,co-crop=42-0-431-431,bg=2raumwohnung-503a7395adf6f.jpg   from the ready file if need like the Original file from USDB  but want download with USDB Syncer   infos ?
hope  you can help thanks
regrads


token size with groups

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.23.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.0.0
Description
authentication works fine and I get Access token and ID Token. but in some cases the ID token is too long. greater than 11 thousand characters and causes me that when sending it to my backend, I get a 413 error for being too large. I saw what happens because it returns all the groups to which the user belongs, if he belongs to many, the token is too long and I can't use it.
Is there a way to select the groups I need or to generate a smaller token?
thanks
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
No response
Source
External (Customer)

@SimonManfredo you can configure group claims to contain only the groups that are assigned to the application (though you won't be receiving nested groups that way). More on this here. Also, you normally shouldn't pass the id token to another application -group claims can also be added to access tokens if that's what you are after.

Closing this assuming to be resolved, but let us know if you have a follow-up.


Optionally Update manifest.json version with package.json version

when the loader is out, it should have the ability to get VERSION from env vars provided by the webpack.
Currently, the manifest version is automatically updated from the package.json, but some users update it with certain packages, so it should be either provided with version as a option or just to read from env

Released in 1.1.2


Bump Dependencies #12527576131

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/12527576131

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Identity changes can be detected by comparing the container blocks

While there is no data leak, it is possible to see where the changes started to happen. Need a way to randomize or pad the first few bytes of the Blowfish encryption function. https://github.com/c3ypt1c/PasswordManager/blob/81c357fdbe70d4e308964ab8e37d2c6b3f699f2b/src/crypto/CryptoFunctions.ts#L68

This explains the problem better than I can:
https://crypto.stackexchange.com/questions/57645/is-using-the-same-iv-in-aes-similar-to-not-using-an-iv-in-the-first-place/57646


Initial implementation of payment endpoint. Payment Grain code includ…

…ed if we ever want to use it.

To keep things clean, I think the OrderGrain should have a reference to the user grain, and for each item in stock. This way, the checking out procedure would be 100% done in the order_grain.
Possible "issue": We still got the payment controller logic, which is needed because the lecturers may test that endpoint directly, but this logic would be also integrated within the checkout method in the order.
For now, we have two possible architectures, and we should choose one:
1)Allow the grain know of other grains, and allow direct communication between them. (The solution that I gave)
Caveat: The grain code will get slightly more complex, but more straightforward.
Every time a grain gets called it may need to call other grains (we can use lazy loading), which means that the "load" procedure will get slower.
2)Each grain only handles what it is made to do, and the top-layer (microservices) call whatever grains it needs to call.
Caveat: When we need to interchange information between grains, we always need to return the necessary information for the other grain to do whatever it has to do. It allows for more decoupling, and it follows the idea of microservice architecture.
I think that there is no need for the payment grain as discussed.
The payment data model might be needed if we want to save a history of payments to an order (we can have N number of failed payments). If not, I think that it can be incorporated in the order model itself for simplicity. (It depends on the number of attributes and methods that the payment entity should have)


[bug fix] Ensure that StopEvent gets cleared from Context._in_progress["_done"] after a Workflow run

Description
With the addition of Checkpointing feature, we added the Context._in_progress field that marks which steps/events are in progress at the time of the snapshot. (The purpose being that if you reload from a Checkpoint that had some steps/events in progress, then these would have to re-started from scratch when re-running the Workflow.)
In doing so, I introduced a bug that didn't clear (_done step, StopEvent) from the _in_progress attribute when a Workflow has successfully ran. This PR fixes this.
Fixes issues that were observed in llama-deploy:

https://github.com/run-llama/llama_deploy/issues/401 (see related discussion https://github.com/run-llama/llama_deploy/discussions/400)

Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

[x] I added new unit tests to cover this change and adapted an existing one with a new assertion

merging despite anthropic tests not passing -- this should be resolved in https://github.com/run-llama/llama_index/pull/17299


fix: version bump

:tada: This PR is included in version 6.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use curl --fail for retrieving e-mails

This option causes cURL to exit with non-zero status when server returns an HTTP error, like 403.
This prevents confusing errors when token is invalid:
$ git-burn --rev-list "origin/$CI_MERGE_REQUEST_TARGET_BRANCH_NAME..$CI_COMMIT_SHA"
jq: error (at <stdin>:0): Cannot index string with string "email"

And will return the error like this instead:
curl: (22) The requested URL returned error: 401

The CI is broken because something tries to upgrade pip on unsupported Python 3.5.
Fetching and installing pip...
Collecting pip
  Downloading https://files.pythonhosted.org/packages/fe/ef/60d7ba03b5c442309ef42e7d69959f73aacccd0d86008362a681c4698e83/pip-21.0.1-py3-none-any.whl (1.5MB)
    100% |████████████████████████████████| 1.5MB 955kB/s
  Saved ./parts/dependencies/python-packages/pip-21.0.1-py3-none-any.whl
Successfully downloaded pip
Ignoring indexes: https://pypi.python.org/simple
Collecting pip
Installing collected packages: pip
Successfully installed pip-8.1.1
Traceback (most recent call last):
  File "/build/parts/dependencies/install/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "/build/parts/dependencies/install/usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/build/parts/dependencies/install/lib/python3.5/site-packages/pip/__main__.py", line 21, in <module>
    from pip._internal.cli.main import main as _main
  File "/build/parts/dependencies/install/lib/python3.5/site-packages/pip/_internal/cli/main.py", line 60
    sys.stderr.write(f"ERROR: {exc}")
                                   ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/build/parts/dependencies/install/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "/build/parts/dependencies/install/usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/build/parts/dependencies/install/lib/python3.5/site-packages/pip/__main__.py", line 21, in <module>
    from pip._internal.cli.main import main as _main
  File "/build/parts/dependencies/install/lib/python3.5/site-packages/pip/_internal/cli/main.py", line 60
    sys.stderr.write(f"ERROR: {exc}")
                                   ^
SyntaxError: invalid syntax
Failed to run '/build/parts/dependencies/install/usr/bin/python3 -m pip list': Exited with code 1.
Makefile:8: recipe for target 'build' failed
make: *** [build] Error 2
The command "make build" exited with 2.


Minor grammatical changes and updates to author and ms.author

Per prior arrangement, if this PR needs approval, or if the commits need to be pulled into the private repo, only @eriklindeman should be notified. Thanks.

#unassign:brendansco

#unassign:sinnypan

#unassign:faterceros

#sign-off


Unable to sign up CLA

I´ve already signed CLA at project
https://github.com/TheThingsNetwork/arduino-device-lib/pull/205
But it's 3 days showing that I was not... Why ?

CLA assistant checks committers of the PR, so in your case @IntelliDust have to sign the CLA.


[Security patch] Upgrade go.opentelemetry.io/contrib to v1.21.1 to fix CVE-2023-47108

This PR upgraded the go.opentelemetry.io/contrib lib to v1.21.1 to fix a high vulnerability found in the CVE Database (https://devhub.checkmarx.com/cve-details/CVE-2023-47108/)

Thanks for the PR. I'll check it on days

@amansulaiman thank you for your contribution. It has been merged.


0.13.6 Homebridge doesn't start

0.13.6 Homebridge doesn't start. I had to roll back to the previous version.
———————————-
Homebridge ver. 1.2.3
Raspberry Pi4, 4Gb

Hi @sergoo-lbt
I'm running the same version myself and it's working fine. What's the error that you get on your end?

Hi @sergoo-lbt
I'm running the same version myself and it's working fine. What's the error that you get on your end?

Hi @sergoo-lbt
I'm running the same version myself and it's working fine. What's the error that you get on your end?

With autoroom turned off, everything is fine. When enabled, homebridge does not start.

Oh! Yes! There's a validation where autoroom and rooms cannot be set at the same time. If rooms are set, autoroom shouldn't be set, so the plugin rejects the configuration and fails.

With autoroom turned off, everything is fine. When enabled, homebridge does not start.

Oh! Yes! There's a validation where autoroom and rooms cannot be set at the same time. If rooms are set, autoroom shouldn't be set, so the plugin rejects the configuration and fails.

I understand! Thanks! Close...


robotraconteur: 1.2.2-3 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository robotraconteur to 1.2.2-3:

upstream repository: https://github.com/robotraconteur/robotraconteur.git
release repository: https://github.com/robotraconteur-packaging/robotraconteur-ros-release.git
distro file: noetic/distribution.yaml
bloom version: 0.12.0
previous version for package: 1.1.1-1

I'll go ahead an merge this one since apparently the ros-gbp content is informally managed and became a lot of a burden and in general it seems that the recommendation is to self host for ROS 1.


Add resource mappings for cloud run, cloud functions, and GAE

Adds support for gae_instance, cloud_run_revision, and cloud_function monitored resources, but disallow their use for monitoring since those resources are not writable.  This is required to add e2e tests on those platforms.
This maintains the mappings if using the service.* labels (e.g. for cloud run).

This is ready for review. It is a subset of the changes in https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/551, which now passes the gae/cloud run presubmits.


prawn-table support

Related to #34

Ha! I was just starting to develop this, but you beat me to it 🙈
Let me know if you need help putting this through its paces.

Ha! I was just starting to develop this, but you beat me to it 🙈
Let me know if you need help putting this through its paces.

Hey @julianrubisch.
Thanks for your contribution about the table closing tag.
I'm still evaluating the approach of this PR BTW.
The integration with prawn-table works but it's not as flexible as I would expect.
I'm going to try to implement my own version of table and see how it works.

gotcha, I can see why :-)
I'll keep playing around on my fork as I need some type of table support, however rudimentary, at the moment.

I'll keep playing around on my fork as I need some type of table support, however rudimentary, at the moment.

Ok, feel free to share when you have something to show. I'm curious.


[1pt] PR: New Tools to create a list of hucs and folder copy them

This PR includes a couple of tools for finding and coping HUC folders. The first tool creates a list of HUCs that have test case data, then the another tool copies the selected HUC folders from one folder to another.  When the full GMS BED run was done in Jan, 2022, not all folders are applicable for test_cases. The run output folders were split across multiple machines where developer could not access them to run alpha testing on.
See Issue 586.
Additions

tools/find_test_case_folders.py

scans through a stated directory as an argument (likely test_cases ) looking for all first level folders following the convention of ** _test_cases*. ie) usgs_test_cases.  Then scans through each applicable child folder looking for a pattern of 8 numbers, underscore, then 3 to 7 characters. ie) 01020304_usgs.  The HUC value, ie) 01020304, is extract and added to a unique HUC value list, line delimited.

tools/copy_test_case_folders.py

Using any .text or .lst list using values with line delimiters, can scan through a root directory, submitted as an argument, looking for matching folder. ie) 01020304 folder in /outputs/jan_gms_run.  Note. While it will usually be a HUC list against a FIM3 or FIM4/GMS output folder, it is not mandatory. It simply looks for a folder name match at the first level under the root defined folder.  As that folder is found, it is copied including sub-files/folders, to another folder defined as a parameter. ie) /outputs/jan_gms_run_test_hucs.

@RobHanna-NOAA It looks like the PR title is cut off with a "..."?

Does this work (title)?


Using TAO Toolkit for training/pruning

While looking through Nvidia's NGC catalog where the ESS DNN resides, I started reading about the TAO Toolkit and the ability to take pre-trained models and augment them with additional data, perform pruning, and other such operations in order to fully optimize them.

In my desired use case, I'd like to train further on a custom dataset, one that is captured on the stereo camera hardware I intend to later perform inference on. In theory, this would allow the network to perform even better. The ability to prune and thus further decrease the computational cost is also appealing.
My problem is that I'm having a difficult time reading about whether this is possible with .etlt files. There are Jupyter notebooks available to perform this type of work on more commonly used deep learning tasks (object detection, semantic segmentation), and while there isn't one for the ESS DNN, I'm wondering if it's even possible based on resources currently available, and if not, if that is something that intends to be supported in the future.
Thanks!

ESS is a custom DNN which is not supported for transfer learning, and pruning in TAO.

Closing.


enable_constant_velocity not working well

CARLA version: 0.9.12
Platform/OS: Windows
Problem you have experienced: By setting the car velocity with "enable_constant_velocity" at 20 / 30 km/h the velocity behavior shows some noise.

But by 10 km/h or higher velocties (> 30 km/h) i don't have the problem:

The problem appears in sync and async mode. I saw that using enable_constant_velocity the follow function is called:
UPrimitiveComponent::SetPhysicsLinearVelocity
Is this problem from Unreal Engine itself or can i set something in CARLA/UE4 to solve it?
Thanks

I have the same problem, may I ask if you have solved this problem? I found that if I turn up the fixed_delta_seconds parameter, such shaking will be relieved, could this be a problem with the carla pid control?


create "autotune"-like acquisition module for TOPAS-C tuning

Closing in favor of #241, #242, #243, and #244 and using a replace queue structure.


Failed when trying to install the package

I get the error when trying to install the package:
"Failed to install library: 'AsyncEspFsWebserver:1.0.1'. No valid dependencies solution found: dependency 'ESPAsyncWebserver' is not available"

Hello @allyssonmast  and thank you for your interest.
Yes, unfortunately, the library in question does not exist in the Arduino repository and therefore is not automatically retrieved.
In any case, I have included the sources directly in the src folder so you just need to install the async-esp-fs-webserver library and everything else comes accordingly.
I just committed, so you can directly download the zip file and manually add it to the Arduino IDE libraries folder.
Anyway, later I will create a new release.


semitransparent white areas gets grey on transparent background

hello,
when rendering pixels with opacity (like backgrounds, fill-areas, halos, ..) as the first layer, the color-values are multiplied by the opacity factor. e.g.
rgba(255,255,255,0.5) gets to rgba(128,128,128,128)
rgba(255,0,0,0.8) gets to rgba(204,0,0,204)
testscript and style-file is attached:
node test.js style.json
convert image.png -define histogram:unique-colors=true -format %c histogram:info:-
this happens with the current @mapbox/mapbox-gl-native module. when i render a staticmap in mapbox-studio all is done correct!
thanks for help!
regards. max.
opacitytest.zip

ups. wrong project! correct one is:
https://github.com/mapbox/mapbox-gl-native/issues/9124


FeaturedChannels: commentron remake

Status

Ready for QA @ kp.  Submit issues here, or in this PR for code-comments.
:warning: If the API is changed from featured_channels to section, an update will be required.  Search for // @REPLACE.  Did not make it a variable.

Behavioral Changes

Enabled support for multiple Featured Channel slots.
Added ability to sort the slots.

Code-change Walkthough

In general, we just switch from using Collection to setting.List :: featured_channels to store the JSON data.
Note that the application needs to be careful not corrupt the data.  Unlike following/subscriptions in the preferences where it's just a flat array, this is a nested JSON.
Format:

Example...
{
	"featured_channels": {
		"entries": [
			{
				"id": "717307f6-387a-4b83-9487-904ab5b9091d",
				"value_type": "featured_channels",
				"value": {
					"title": "The Jeremies",
					"uris": [
						"lbry://@kauffj#f3da2196b5151570d980b34d311ee0973225a68e",
						"lbry://@jeremycook#9826a0c0a781ce1beed3067202f8677a2740e3ba",
						"lbry://@jeremyleik#ab3c81d2e518a512c248c50d5138ba7137ddeec4",
						"lbry://@JeremyS#fc95fd56a8c73e9a6421751a2896dded35242c4e",
						"lbry://@Kauffman#9cdac17982bfacfab30050f8e5275457162e0dbc",
						"lbry://@KaNinja#b074b3372f4a757e71595072536dd1b9a6683ad4",
						"lbry://@jeremypoole#bd914d9324fd1764bb5d789e96b7d50ad864ea1e",
						"lbry://@engineering#5547d725cf7db06e2c6a271a9d1630a2fc739ef1",
						"lbry://@Jeremy'W#f1a9764a881bf65e2ab32bc5d26e26b018f96fa6",
						"lbry://@JeremyRush#a1e3691becffebb23f1d7a78a722df839b247cc5",
						"lbry://@jlizzotte04#0b30fa2e47d4e099c3d7d1dc659222a3dd016780",
						"lbry://@JeremyHay#2ff16d14cc5b769b195017b8421279dec2650425",
						"lbry://@JeremyHambly#3a4c5766ea857d4ae759901225ffa28b2d7d38ed"
					]
				}
			},
			{
				"id": "1fd95d65-5bff-4e5c-be45-1a692859fc23",
				"value_type": "featured_channels",
				"value": {
					"title": "Longer Title<PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER> ",
					"uris": [
						"lbry://@dev-test#898c901e7f39b44c5b3f52b1d67a22b185fb3e15",
						"lbry://@TEST#219937611e374b1e9ac7535b2b61c9413373f887",
						"lbry://@Design-Prototype-Test#9a311e766fcbc69bd9f37fd068843a1a8b1aeb02",
						"lbry://@marcosgamedev#d3e9fc6a34eab5417d5f8f2efd7f871a866c3d6d",
						"lbry://@an00bis#72782ecd89e1a2e6195b28b15d4eacdfbdcdc38c",
						"lbry://@WebDevSimplified#892a016cd83fb9af964ef1f870ab62aaaa45c3fa",
						"lbry://@FreeTimeDev#c990cff4ad423ace88ddc909d2745a928aee23ff"
					]
				}
			},
			{
				"id": "09fe51c4-0032-442f-bf09-d3f4c16de98e",
				"value_type": "featured_channels",
				"value": {
					"title": "The Toms",
					"uris": [
<EMAIL_ADDRESS>						"lbry://@tom#293c59fd1203bffe9d0afece55f7f9386eb633c2",
<EMAIL_ADDRESS>						"lbry://@TomAntosFilms#2f229d3ac26aa655c5123c29f1f7352403279ca3",
						"lbry://@Tom#96c0b85eb0927186d6c234fbf31f17942107e2a7",
						"lbry://@TomSparkReviews#daee28584931020d59f18f250853ba16e2e4f4bf",
						"lbry://@AlienTom#f13c0fc8f0ba5bb901ef8579425b98cdbbaedbcc"
					]
				}
			}
		],
		"version": "1.0"
	}
}

Some of the legacy items are retained, such as the filtering of FC Collections in the Playlists tabs.  Those will no longer be accessible, unless they use Desktop or something similar to delete it.

Postponed

Use a JSON schema validator to ensure the data written follows the spec.

updated the field,m and pushed the commit. The backend does validate it's correct json, but nothing with the conts.

[ ] when no title, show error (submit greyed out)
[ ] remove from behind premium (open it up to all)


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.4.9

from: https://github.com/jenkins-x/jx

Test passed
Ran 1 of 1 Specs in 1042.413 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestSuite (1042.41s)
PASS
ok  	github.com/jenkins-x/bdd-jx/test/suite/spring	1042.485s
pod jx-bdd-lffb7 has Succeeded
job jx-bdd has Succeeded
POD RESULT: OK

/override gsm


Enable building docs in the CI pipeline

First fix all the docs build errors then enable docs build in CI, as we do in other crates in our stack.

Would need rebase again


starting kubernetes: preparing server: start managed database: snapshot missing hash but --skip-hash-check=false

Environmental Info:
K3s Version:

k3s version v1.21.11+k3s1 (4eb3a488)
go version go1.16.10
Node(s) CPU architecture, OS, and Version:

Linux rancher1 5.4.0-120-generic #136-Ubuntu SMP Fri Jun 10 13:40:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Cluster Configuration:

Describe the bug:

root@rancher1:/opt# k3s server --cluster-reset --cluster-reset-restore-path=/opt/etcd/snapshots/etcd-snapshot-rancher1-1699876800.part
INFO[2023-11-14T04:00:06.743009747Z] Starting k3s v1.21.4+k3s1 (3e250fdb)
INFO[2023-11-14T04:00:06.743378976Z] Managed etcd cluster initializing
INFO[2023-11-14T04:00:06.759546564Z] Pre-restore etcd database moved to /var/lib/rancher/k3s/server/db/etcd-old-1699934406
{"level":"info","msg":"restoring snapshot","path":"/opt/etcd/snapshots/etcd-snapshot-rancher1-1699876800.part","wal-dir":"/var/lib/rancher/k3s/server/db/etcd/member/wal","data-dir":"/var/lib/rancher/k3s/server/db/etcd","snap-dir":"/var/lib/rancher/k3s/server/db/etcd/mem
ber/snap"}
FATA[2023-11-14T04:00:06.788439007Z] starting kubernetes: preparing server: start managed database: snapshot missing hash but --skip-hash-check=false

Steps To Reproduce:

Installed K3s:

rm -rf /var/lib/rancher/k3s/server/db
k3s server --cluster-reset --cluster-reset-restore-path=/opt/etcd/snapshots/etcd-snapshot-rancher1-1699876800.part

Expected behavior:

restore success
Actual behavior:

root@rancher1:/opt# k3s server --cluster-reset --cluster-reset-restore-path=/opt/etcd/snapshots/etcd-snapshot-rancher1-1699876800.part
INFO[2023-11-14T04:00:06.743009747Z] Starting k3s v1.21.4+k3s1 (3e250fdb)
INFO[2023-11-14T04:00:06.743378976Z] Managed etcd cluster initializing
INFO[2023-11-14T04:00:06.759546564Z] Pre-restore etcd database moved to /var/lib/rancher/k3s/server/db/etcd-old-1699934406
{"level":"info","msg":"restoring snapshot","path":"/opt/etcd/snapshots/etcd-snapshot-rancher1-1699876800.part","wal-dir":"/var/lib/rancher/k3s/server/db/etcd/member/wal","data-dir":"/var/lib/rancher/k3s/server/db/etcd","snap-dir":"/var/lib/rancher/k3s/server/db/etcd/mem
ber/snap"}
FATA[2023-11-14T04:00:06.788439007Z] starting kubernetes: preparing server: start managed database: snapshot missing hash but --skip-hash-check=false

Additional context / logs:

k3s server --cluster-reset --cluster-reset-restore-path=/opt/etcd/snapshots/etcd-snapshot-rancher1-1699876800.part

I'm not sure what a .part file is, but the name and error message both suggest that this is not a complete snapshot file. Please try again, using a regular snapshot file, one with either no extension, or a .zip extension (if you enabled snapshot compression).

ls -alh /var/lib/rancher/k3s/server/db/snapshots/
total 138M
drwx------ 2 root root 4.0K Nov 14 12:00 .
drwx------ 6 root root 4.0K Nov 15 01:44 ..
-rw------- 1 root root  46M Nov 13 12:00 etcd-snapshot-rancher1-1699876800.part
-rw------- 1 root root  46M Nov 14 00:00 etcd-snapshot-rancher1-1699920000.part
-rw------- 1 root root  46M Nov 14 12:00 etcd-snapshot-rancher1-1699963200.part

etcd-snapshot-rancher1-1699876800.part is k3s's auto snapshot

Check the logs. There should be no .part suffix. Have there been errors saving the snapshots that have left you with partial files?


UI is too low-contrast

In dark mode, the greys are way too light, making much of the text illegible to my eyes. The background could be a pure black, or close to it.

Got a screenshot you can annotate?


fix Caching to boost the performance of ZookeeperDiscoveryClient.getInstances #154

fix Caching to boost the performance of ZookeeperDiscoveryClient.getInstances #154

Sorry for the delay. We're a bit confused why the ServiceCache needs to be cached itself.

Closing this due to inactivity. Please re-open if there's more to discuss.


Building initial module for 4.19.0-16-amd64

The server is always hanging while installing the script on Building initial module for 4.19.0-16-amd64

Well, I am going to need more than that if you want to troubleshoot the issue.
At the very least, provide the full installation log, say which distribution are you using (I assume it is Debian) and it would also be helpful to know what is your hosting provider and if this server is low on RAM.


Feature: Form Values Selector that is easier to use with reselect

Are you submitting a bug report or a feature request?
Feature Request
What is the current behavior?
When you use formValueSelector you create a function that then takes the state as its first argument and the rest of the arguments are the fields whose values you want to select.  When you use this with reselect's createStructuredSelector it feels a bit awkward.
const selector = formValueSelector('myForm');
const mapStateToProps = createStructuredSelector({
  firstValue: (state) => selector(state, 'firstValue')
});

What is the expected behavior?
I would love if there was a new api that effectively did the same thing but provided an interface that is a little cleaner and easier on the eyes.
Something like this would do the trick.
const mapStateToProps = createStructuredSelector({
  firstValue: makeSelectFormValueSelector('myForm', 'firstValue'),
});

If this is something that seems agreeable to you then I would be willing to submit the PR myself.  I just wanted to discuss it first before I submitted anything.

Makes sense, though current userland solution isn't that bad.
const makeValueSelector = valueName => state => formValueSelector('myForm')(state, valueName)

const mapStateToProps = createStructuredSelector({
  firstValue: makeValueSelector('firstValue')
});


OnPush strategy with structural directive can skip the initial change detection

The following code is minimal reproduction of a case when a structural directive skips the initial change detection, but if I remove the changeDetection: ChangeDetectionStrategy.OnPush setting from the AppComponent the initial detection happens as intended.
@Component(
    selector: 'app-cmp',
    template: '<container *ngIf="true"><item *myStructuralDirective></item></container>',
    directives: [ContainerComponent, ItemComponent, MyStructuralDirective, NgIf],
    changeDetection: ChangeDetectionStrategy.OnPush)
class AppComponent {}

@Component(selector: 'item', template: 'Text')
class ItemComponent implements OnInit {
  @HostBinding('style.color')
  String color = "red";

  @override
  void ngOnInit() => print('oninit');
}

@Component(selector: 'container', template: '<ng-content></ng-content>')
class ContainerComponent implements AfterContentInit {
  @ContentChild(MyStructuralDirective)
  MyStructuralDirective myStructuralDirective;

  @override
  void ngAfterContentInit() => myStructuralDirective.activate();
}

@Directive(selector: '[myStructuralDirective]')
class MyStructuralDirective {
  final TemplateRef _templateRef;
  final ViewContainerRef _viewContainer;

  MyStructuralDirective(this._viewContainer, this._templateRef);

  void activate() => _viewContainer.createEmbeddedView(_templateRef);
}

Dart: 2.1.0
Angular: 5.2.0
OS: Linux
Browser: Chrome

It's not missing the initial change detection. You're creating the embedded view during the initial change detection, after the view container has been checked.

Your example, when using ChangeDetectionStrategy.Default, throws a debug error we use to validate that change detection is stable and has no side effects that would immediately invalidate another change detection cycle:

Expression has changed after it was checked. Previous value: 'null'. Current value: 'red'

Using a ChangeDetectionStrategy.Default component within a ChangeDetectionStrategy.OnPush component isn't officially supported, and will likely not function as expected.

To fix your example

Make all of the children of AppComponent OnPush as well.
Schedule the work done in ngAfterContentInit to be performed after the framework is done with the current change detection cycle using runAfterChangesObserved.
Call markForCheck() after embedding the view.

@Component(
  selector: 'app-cmp',
  template: '<container><item *myStructuralDirective></item></container>',
  directives: [ContainerComponent, ItemComponent, MyStructuralDirective],
  changeDetection: ChangeDetectionStrategy.OnPush,
)
class AppComponent {}

@Component(
  selector: 'item',
  template: 'Text',
  // This should be `OnPush` as well.
  changeDetection: ChangeDetectionStrategy.OnPush,
)
class ItemComponent implements OnInit {
  @HostBinding('style.color')
  String color = "red";

  @override
  void ngOnInit() => print('oninit');
}

@Component(
  selector: 'container',
  template: '<ng-content></ng-content>',
  // This should be `OnPush` as well.
  changeDetection: ChangeDetectionStrategy.OnPush,
)
class ContainerComponent implements AfterContentInit {
  ContainerComponent(this._zone);

  final NgZone _zone;

  @ContentChild(MyStructuralDirective)
  MyStructuralDirective myStructuralDirective;

  @override
  void ngAfterContentInit() {
    // Schedule this work to be performed after this change detection cycle.
    _zone.runAfterChangesObserved(myStructuralDirective.activate);
}

@Directive(selector: '[myStructuralDirective]')
class MyStructuralDirective {
  final ChangeDetectorRef _changeDetector;
  final TemplateRef _templateRef;
  final ViewContainerRef _viewContainer;

  MyStructuralDirective(this._changeDetector, this._viewContainer, this._templateRef);

  void activate() {
    _viewContainer.createEmbeddedView(_templateRef);
    // Tell the framework that this directive's host should be change detected next cycle.
    _changeDetector.markForCheck();
  }
}

Thank for the anwser. I missed the unAfterChangesObserved in my original code, actually never used before.


"A SMALL TASTE" button does nothing

O.S: Windows 10
Browser: Chrome
URL: https://zephir-lang.com/
The  "A SMALL TASTE" "See what zephir can do!" button does nothing. No Javascript errors got thrown.

This is https://github.com/phalcon/zephir-website issue

https://github.com/phalcon/zephir-website/issues/9


Add PYSEC importer

This would be a first OSV-based importer

As a follow up, we need to check the schema version (and eventually fail if this is not what is expected)
Also we should contemplate using the https://github.com/pypa/advisory-database/ separately and directly as this and the OSV two may not be exactly in sync

See https://github.com/nexB/vulnerablecode/issues/774 for followup. This is all imported and merged otehrwise.
@ziadhany Thank you ++ :bow:


Create ca.json

Requesting to translate Catalan. No previous experience with translating websites, but both developers are native Catalan speakers and have full professional proficiency in English.

Hi! Thanks for vounteering. @pepjo, could you also confirm that you're available to help maintain?

Hi! Yes, I can confirm 😊

Thanks! Here is your repo: https://github.com/reactjs/ca.reactjs.org/issues/1
Please follow the instructions there and let me know if you need any help!


Move core ObjC classes into their own library

For example NSObject and NSString. This makes sense from a modularisation perspective, and also solves the problem where 2 different code genned ObjC libraries are incompatible.

I'm starting work on this now. Gonna call it package:ffigen_objc, unless anyone objects.

I'm starting work on this now. Gonna call it package:ffigen_objc, unless anyone objects.

How about:

package:ffi_objc or package:ffi_objectivec or package:ffi_objective_c? It's a helper package that doesn't do any generation but is targetted by code gen. It's like the helpers in package:ffi and package:jni but for the context Objective-C.
(package:objective_c. I like this slightly less, because it does not refer to FFI in any way. E.g. it could be a package that generates Objective-C instead of that interops with Objective-C.)

I don't see many guidelines for package names (besides https://dart.dev/tools/linter-rules/package_names).
cc @mit-mit @jonasfj @lrhn for package name

How will the package be imported? Will the user have to import it, or will ffi_gen inject an import?
(In the latter case, the user still needs a non-dev dependency on the package.)
Could it be a separate libraries of package:ffi, as package:ffi/objective_c.dart. If nothing else, the user presumably has a dependency on package:ffi already. (The title says "its own library", not "its own package", so ....?)

How will the package be imported? Will the user have to import it, or will ffi_gen inject an import? (In the latter case, the user still needs a non-dev dependency on the package.)

The latter. (It is similar to package:jni, the generated code will import it.)

Could it be a separate libraries of package:ffi, as package:ffi/objective_c.dart. If nothing else, the user presumably has a dependency on package:ffi already. (The title says "its own library", not "its own package", so ....?)

It could. However, I am slightly worried about breaking changes. Objective C support is still experimental. package:ffi is used all over the place, and users are already using dependency overrides because they have dependencies using v1.x.x and v2.x.x. I'd like to avoid having to bump package:ffi's major version because we update package:ffi/objective_c.dart in a breaking way. @liamappelbe Do you expect us to do breaking changes to package:ffi_objective_c while iterating on it?

The latter. (It is similar to package:jni, the generated code will import it.)

Which means that the code using ffi_gen needs to have a non-dep dependency on the package.
In that case, I think it's better to put the files inside package:ffi and only have one package dependency.
The breaking change for experimental code is an issue, but that should end eventually. Could you just mark the library as @experimental, and break it with abandon?
If we expect breaking changes post experiment stage, then linking things that evolve independently is an issue, since it can introduce too many major-version increments. Then separate packages is probably the right thing.
In that case, I'd go with package:ffi_objective_c if the package cannot be used directly, only through ffi_gen.
If it can be used directly as well, then package:objective_c is fine.
(Can package:jni be used by itself, or should it be called package:ffi_jni?)

Gonna call it package:ffigen_objc, unless anyone objects.

Having gen in the name might suggest that it is a code generator.

If we expect breaking changes post experiment stage.

I would personally expect that based on my experience.

(Can package:jni be used by itself, or should it be called package:ffi_jni?)

It can be used by itself. We have a package:jni/internal_helpers_for_jnigen.dart as well (I know, long name, but I kept it the way it was!) that exposes certain functionalities that only package:jnigen needs.
The thing about package:jni is that we might decide to decouple it from some future package:java_core and package:kotlin_something. Where package:jni only has the very basic classes like JReference and JObject and all the other classes exist in a different package. But again it's a good default for jnigen and ffigen to use the classes inside package:java_core by default.

JNI is already "Java native interface", so it is inherently FFI related.

Am I the only one who doesn't really mind not directly implying the fact that these packages are ffi related in the name?

@liamappelbe Do you expect us to do breaking changes to package:ffi_objective_c while iterating on it?

Definitely. My experience has been that generated code changes more often and more drastically than normal code.
Based on everyone's feedback, I'm leaning towards package:ffi_objc.

@liamappelbe Do you expect us to do breaking changes to package:ffi_objective_c while iterating on it?

Definitely. My experience has been that generated code changes more often and more drastically than normal code.

👍

Based on everyone's feedback, I'm leaning towards package:ffi_objc.

I'd prefer package:ffi_objective_c, because I believe it would be better to avoid abbreviations. (Although, we do have ffigen where generator is abbreviated to gen. So maybe this isn't the strongest argument. 😆)

@liamappelbe Do you expect us to do breaking changes to package:ffi_objective_c while iterating on it?

Definitely. My experience has been that generated code changes more often and more drastically than normal code.

👍

Based on everyone's feedback, I'm leaning towards package:ffi_objc.

I'd prefer package:ffi_objective_c, because I believe it would be better to avoid abbreviations. (Although, we do have ffigen where generator is abbreviated to gen. So maybe this isn't the strongest argument. 😆) Happy with either of the two.

I like package:objective_c.
As @lrhn said:

If it can be used directly as well, then package:objective_c is fine.

And I think it can be used directly.

And I think it can be used directly.

Fair enough. @dcharkes any objections to package:objective_c? I would prefer package:objc, but I don't think I'm going to win that argument 😛

And I think it can be used directly.

Fair enough. @dcharkes any objections to package:objective_c? I would prefer package:objc, but I don't think I'm going to win that argument 😛

sgtm!


homepage pic added

Description
Homepage design created using Figma has been added to assets/homepage/rutuja folder for review.
Solves #14
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

Screenshots

@codewithvk Hope you will like this design, thank you for this opportunity.

Looks good for me :)


Added RunOnce option to check build status only once and exit

Addresses issue #10.

Don't we want to reverse this by making run once the default?

Making it run once by default would break the current behaviour. Also, I would expect a build light monitor to continuously run and monitor builds by default. Being able to run the check only once is a feature that is only convenient for command-line usage when checking the results manually to me.
And RunOnce seemed like a good name for the option, inspired by the Windows RunOnce Registry key.

Solves #10


More airlocks and airlocks sprite fixes.

About the PR
Gives to already existing airlocks directional sprites.
Adds preparation airlocks for all four squads.
Why / Balance
Resolves #695
Media

Preparations door

Directional sprites

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

can you also look into the squad coloured doors?

#695

need help with double-tile doors. Is there a way to make them spawn anchored to the 2 tiles?

airlock purge.


Can't create a town with Towny, have both Vault, Gringotts and Towny

[21:25:18] [Server thread/INFO]: Onionus issued server command: /town new Tokio [21:25:18] [Server thread/ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'town' in plugin Towny v<IP_ADDRESS>         at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at org.bukkit.craftbukkit.v1_15_R1.CraftServer.dispatchCommand(CraftServer.java:711) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.PlayerConnection.handleCommand(PlayerConnection.java:1657) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:1497) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:1) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(SourceFile:144) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(SourceFile:118) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.MinecraftServer.ba(MinecraftServer.java:918) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:911) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(SourceFile:127) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:895) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:828) [spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222] Caused by: java.lang.NoSuchFieldError: accountHolderFactory         at net.milkbowl.vault.economy.plugins.Economy_Gringotts.hasAccount(Economy_Gringotts.java:126) ~[?:?]         at com.palmergames.bukkit.towny.TownyEconomyHandler.getBalance(TownyEconomyHandler.java:257) ~[?:?]         at com.palmergames.bukkit.towny.TownyEconomyHandler.hasEnough(TownyEconomyHandler.java:280) ~[?:?]         at com.palmergames.bukkit.towny.object.EconomyAccount.canPayFromHoldings(EconomyAccount.java:189) ~[?:?]         at com.palmergames.bukkit.towny.object.EconomyAccount._pay(EconomyAccount.java:63) ~[?:?]         at com.palmergames.bukkit.towny.object.EconomyAccount.pay(EconomyAccount.java:53) ~[?:?]         at com.palmergames.bukkit.towny.command.TownCommand.newTown(TownCommand.java:2305) ~[?:?]         at com.palmergames.bukkit.towny.command.TownCommand.parseTownCommand(TownCommand.java:397) ~[?:?]         at com.palmergames.bukkit.towny.command.TownCommand.onCommand(TownCommand.java:314) ~[?:?]         at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[spigotmc-1.15.2.jar:git-Spigot-800b93f-8160e29]         ... 17 more

My players cannot access the /town command either
Caused by: org.bukkit.command.CommandException: Unhandled exception executing command 'towny:town' in plugin Towny v<IP_ADDRESS>

Hello @Darklom,
https://github.com/nikosgram/Gringotts/releases/tag/2.11.2-SNAPSHOT-ref98c00
Try this pre-release version. Please remember, this is a pre-release version, only for testing purposes.


Removed bus from dbus compilation.

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   21.21%   21.21%
=======================================
  Files          12       12
  Lines        2819     2819
  Branches      356      356
=======================================
  Hits          598      598
  Misses       2183     2183
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1a2db...aa59f7a. Read the comment docs.


bumped version to 0.5

Coverage remained the same at 100.0% when pulling 517e769eda8cbe72f1c2076cf79a66b5119fcc61 on ready-0.5 into 4156577e635932c870dfa17769fa2f5b57fb7afb on master.


Add LC state change API

Purpose
Sample curl:
curl -k -X POST "http://localhost:9443/api/am/backoffice/apis/change-lifecycle?apiId=01ed7552-b30b-18c8-89f2-25da7a7c46cw&action=Demote to Created"
Supported actions are [ Publish, Deploy as a Prototype, Demote to Created, Block, Deprecate, Re-Publish, Retire ]

Fix https://github.com/wso2/apk/issues/348


Jest hangs after all tests have run when using socket.io redis adapter

I have a Node.JS server that is using Socket.IO with the Redis Adapter. When running Jest tests, the Jest process hangs after all tests have run. I have minimized the code down to the following to be able to reproduce. It is the Redis Adapter that causes the problem. What else do I need to do to cleanup?
app-test.ts
import express from 'express';
import fse from 'fs-extra';
import * as http from 'http';
import socketIo from 'socket.io';
import SocketIORedis from 'socket.io-redis';
import { CONFIG_TYPE, CONFIGS_PATHS } from '../../constants';

class Server {
  // Bootstrap the application.
  public static bootstrap(): Server {
    return new Server();
  }

  public app: express.Application;
  public server: http.Server;
  private io: SocketIO.Server;

  constructor() {
    // Create expressjs application
    this.app = express();

    // Create server
    this.createServer();
  }

  public shutdown(): void {
    this.io.close();
    this.server.close();
  }

  private async createServer() {
    this.server = http.createServer(this.app);
    this.io = socketIo(this.server, { transports: ['polling', 'websocket'] });
    const redisConfig = await fse.readJson(CONFIGS_PATHS[CONFIG_TYPE].REDIS);
    const redisAdapter = SocketIORedis(redisConfig);
    this.io.adapter(redisAdapter);

  }
}

// Bootstrap the server
const server = Server.bootstrap();
export default server;

app-test.spec.ts
import app from './app-test';

describe('test', () => {
  afterAll((done) => {
    app.shutdown();
    done();
  });

  it('fake test', () => {
    expect(true).toBeTruthy();
  });
});

Figure it out?

Took me about a week but I think I got it. redisAdapter has 2 clients that are running in the background that you have to quit.
pubClient & subClient
try in the shutdown function (before closing io & server):
await Promise.all([
            new Promise ((res, rej) => {
                redisAdapter.pubClient.quit(()=>{
                    console.log('RedisAdapter pubClient Closed!')
                    res()
                })
            }),
            new Promise ((res, rej) => {
                redisAdapter.subClient.quit(()=>{
                    console.log('RedisAdapter subClient Closed!')
                    res()
                })
            })
])

Also take a look at this template which helped me:
https://medium.com/@tozwierz/testing-socket-io-with-jest-on-backend-node-js-f71f7ec7010f

By call quit these two objects I was able to make jest stop barking at me.
"Jest did not exit one second after the test run has completed."
  const port = 3000;
  const http = app.listen(port);
  const io = SocketIO(http);
  const redisAdapter = RedisSocketIO(config.redis);
  io.adapter(redisAdapter);

afterAll(() => {
    httpServer.close();
    redisAdapter.pubClient.quit();
    redisAdapter.subClient.quit();
});

Does any of this solution still work?
I have just tried with 2.3.0 and it hangs. If I don't use socket.io-redis adapter it will close properly.

Does any of this solution still work?
I have just tried with 2.3.0 and it hangs. If I don't use socket.io-redis adapter it will close properly.

For future readers, the fact that you now have to create the Redis clients (since release 7.0.0) instead of letting the library create them should mitigate this issue:
const io = require('socket.io')(3000);
const { createClient } = require('redis');
const redisAdapter = require('@socket.io/redis-adapter');

const pubClient = createClient({ host: 'localhost', port: 6379 });
const subClient = pubClient.duplicate();
io.adapter(redisAdapter(pubClient, subClient));

describe('Jest Redis Socket IO Shutdown Example', () => {
 afterAll(() => {
     httpServer.close();
     pubClient.quit();
     subClient.quit();
 });
})


Environment variable not ignored

we introduced config.env should be ignored in the .gitignore file why is it pushed to github ????!!!!!!
if it's on github ( and github is open for everyone ) then people can just come take your database url either delete everyhing in it or crash it or even fill it up with random shizz
Never ever push your enviroment variables

@Karyum you need to chillax bro!!!!!!!!!!!
You don't actually have access to our database because its stored locally.
We know that and we added it to .gitignore file..but for some reason it got pushed to github.


fix(compat): do not auto invoke scoped slots when accessed via $slots

The problem
If the component has a render function and uses this.$slots.name expression somewhere, this usage might throw if name is used as a scoped slot and the data the slot passes is destructured.
Why this happens?
If RENDER_FUNCTION compat feature is enabled and the component is using a render function (_compatWrapped), all $slots.name accesses will be intercepted by a proxy which will auto-invoke the corresponding function with no arguments:
https://github.com/vuejs/core/blob/c0c9432b64091fa15fd8619cfb06828735356a42/packages/runtime-core/src/compat/instance.ts#L96-L105
If these arguments are destructured by a component user, this weird runtime error will occur: (destructured parameter) is undefined in Firefox or Cannot destructure property '<property name>' of 'undefined' as it is undefined in Chromium.
The fix
This PR attempts to resolve the issue by avoiding invoking the slot if it has _ns (non-scoped slot) flag.
Real-world examples

I'm trying to migrate to Vue 3 a legacy project with<EMAIL_ADDRESS>using @vue/compat. This line, for example, is only intending to check the slot presence, but ends up invoking it with no arguments and undefined is ended up being destructured in user code.

The other one: https://github.com/SortableJS/vue.draggable.next/issues/122

I think this fix should not break the existing code which is written and used correctly because

If a slot was never intended to be used as a scoped slot but is used as such, that is a component user's mistake - and runtime errors in this case are a possibility (for example caused by non auto-invoking $slots.name)
If a slot can be used as a scoped and a non-scoped one, it is lib author's responsibility to use $slots or $scopedSlots respectively (which vuetify actually does).

Why not use 'slotName' in this.$slots as the condition?


[Question] Can we add files programmatically, without the interface?

Hi,
Is there a way where we can add files to vue-dropzone through code ( without the browser dialogue for drag and drop), so that it automatically starts uploading and triggering all success and error events.
I explored the existing methods but the manuallyAddFile seems to only create a mock file for display and doesn't initiate the auto upload events.
Thanks and great work!

Sorry for the slow reply @e0lithic
You can probably do something with the processFile(file) method exposed by dropzone.
this.$refs.myVueDropzone.dropzone.processFile(myRealFile)

Unfortunately there isn't much documented on the dropzone website about how it works but hopefully it gets you on your way.

Thanks for the pointer.


Upgraded to Rust 2018 edition

Upgraded to the 2018 edition of Rust
Fixed module imports and relative imports
Removed extern crate usages
Removed #[macro_use] imports where possible (log would be an entirely different PR in of itself)

Apart from log, all macro usages are localized

I'm so sorry, that was an accidental push. In response to your question though, the 'unused' macros are actually used because prometheus's macro scoping is really bad, and they don't canonically import their own macros but opt to take macros from the use-site environment.

Ouch, ok as long as they're being used that's fine. If you can add back the 'Missed one' commit this will be good to merge once CI passes.

Alright, added back the commit, I have a funny feeling that whenever we get around to updating prometheus this problem will be solved for us


Fail to refresh decompiled file opened window upon subsequent decompiling attempts.

VSCode seems to have a bug/limitation where await window.showTextDocument(javaDoc, { preview: false })? needs a certain amount of time to elapse for it to be able to be refreshed?
This makes the decompiling experience on VSCode with this extension really really bad. I have to open Notepad++ and use it to monitor for file changes to remedy this at the moment. Furthermore, the force-open of decompiled file makes this method really annoying, wish we could disable it via parameters or something :/
Anyways, it would be cool to find a solution for this :)

Thanks for your feedback, I tried to fix this issue in version 0.0.4, please check for plugin updates.

Can confirm that version 0.0.4 has resolved the issue. Good job.


[ENH]: CLI optional parameter to turn off persistent mode

Refs: https://github.com/chroma-core/chroma/issues/1674
Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Added optional persistent paramter to CLI.

Test plan
How are these changes tested?
Tested locally with  --persistent, --no-persistent and without the parameter
Documentation Changes
TBD

@nepeee can you tell me more about the use case here? what is the use case to run the server, but not need persistence?

I use chrome for real time text grouping. Basically i push messages to the db and query the similar ones to group them for analysis.

Closing this for now until we see further demand for this


feat(worfklows): Allow server side pagination and filtering for workflows

This pull request introduces offset-based pagination to the control plane API, alongside other enhancements. The most important changes include the addition of new pagination request and response types, updates to the workflow service to support filtering and pagination.
Pagination Enhancements:

Added OffsetPaginationRequest and OffsetPaginationResponse types to handle offset-based pagination.
Updated pagination.proto to include definitions for OffsetPaginationRequest and OffsetPaginationResponse.

Workflow Service Enhancements:

Enhanced WorkflowServiceListRequest to support additional filtering options and included OffsetPaginationRequest for pagination.
Added OffsetPaginationResponse to WorkflowServiceListResponse to return pagination information.
Introduced WorkflowActivityWindow enum to represent the time window for the last known workflow activity.

Possible filters:

workflow_name
workflow_team
project_names
visibility of a project
workflow run runner type
last known workflow run status
last known activity of an associated workflow run

Other changes
Removes the parameter project_reference from WorkflowServiceListRequest since it was not used anywhere.
Default behavior
This changes ensures backwards compatibility by making the pagination options, optional and if not provided only returning a specific number of workflows instead. It's advised to update to most recent version of Chainloop once released to leverage the pagination feature.
Ref: https://github.com/chainloop-dev/chainloop/issues/1503

Thanks @javirln for getting back to my questions. LGTM!


Add support for Rocky Linux

Description
This allows the cookbook to be used on Rocky Linux.
If for any reason there'd be no appetite to support Rocky Linux in the sc-mongodb OSS cookbook, we'd be happy to "pivot" the approach and instead expose the "package_repo_url" as an attribute (default nil) and only get it filled out by the existing case logic if it's nil.
It'll keep the cookbook up and running for the currently supported OSs and we then set the attribute specifically for our Rocky purposes...
Thanks in advance for your feedback!
Kind regards,
David @ Escape Technology

@estedev can you please update the changelog?

Sure, I've just updated CHANGELOG.md  to suggest a bump to v5.2.0 for the "Add support for Rocky Linux" PR.
Thanks in advance for your feedback!
Kind regards,
David @ Escape Technology


Unknown regions - fixes a bug in caching mechanism

Fixes #4893
The Backend for unknown regions would be recreated for every request, effectively resetting it every time.
This PR ensures a previously created cache entry is actually used
Also removes some unrelated warnings from S3Control

Codecov Report

Merging #4895 (412361c) into master (58ff549) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4895      +/-   ##
==========================================
- Coverage   95.26%   95.25%   -0.02%
==========================================
  Files         610      610
  Lines       65328    65330       +2
==========================================
- Hits        62233    62227       -6
- Misses       3095     3103       +8

Flag
Coverage Δ

servertests
36.11% <100.00%> (+<0.01%)
:arrow_up:

unittests
95.19% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/s3control/urls.py
100.00% <ø> (ø)

moto/core/utils.py
93.33% <100.00%> (+0.05%)
:arrow_up:

moto/resourcegroupstaggingapi/models.py
83.66% <0.00%> (-0.58%)
:arrow_down:

moto/route53/responses.py
97.18% <0.00%> (-0.41%)
:arrow_down:

moto/sns/models.py
96.83% <0.00%> (-0.40%)
:arrow_down:

moto/sqs/models.py
96.76% <0.00%> (-0.18%)
:arrow_down:

moto/config/models.py
99.21% <0.00%> (-0.14%)
:arrow_down:

moto/ssm/models.py
94.42% <0.00%> (-0.11%)
:arrow_down:

moto/awslambda/models.py
92.45% <0.00%> (ø)

moto/s3control/models.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ff549...412361c. Read the comment docs.


Config Feature - cell background color

Hi man
Any chances to add background color "cell" to allow some dark mode support?
Best

Hi, could you kindly explain a bit more? What is background color "cell"?

Hi @kizitonwose I've submitted PR for cell background and title color customization, please check it out
https://github.com/kizitonwose/CountryPickerView/pull/144
@umwelt you can use my fork if still need ability to customize cell colors.

Hi @kizitonwose @akovalov - thanks for the input


feat(cmd-api-server): trusted execution environment support

Is your feature request related to a problem? Please describe.
I want to be able to run the Cactus API server (and consequently the plugins in it) on a TEE (trusted execution environment).
Describe the solution you'd like
Ideally this would not change anything in the code of Cactus itself because we do not want an abstraction leak where the underlying CPU architecture creeps into the code executing transactions on the connectors for example.
My guess is that since we are a NodeJS project and have kept this up so far as well (meaning we don't run additional JVM processes or anything else) we should already be compatible with TEE that can run NodeJS itself and if this is indeed the case then to complete this issue all one would need to do is write a test that verifies it being so and call it a day.
Describe alternatives you've considered
Nothing, I'm confident we want this as an option.
Additional context
Meeting notes where we discussed this:
https://wiki.hyperledger.org/display/cactus/2020-11-12+Meeting+notes?focusedTaskId=13
cc: @takeutak @sfuji822 @jonathan-m-hamilton

https://github.com/openenclave/openenclave

This would be a great feature to have but will definitely be out of scope for a few more releases based on the complexity of it all: The only way we can run code in the enclave is if we compile the Typescript code down to wasm (or we can use some other language that compiles down to wasm or C).
Compiling down to wasm is non-trivial because a lot of the dependencies we use are not workable due to the wasi interface not being fully matured yet.


TTL function

Is your feature request related to a problem? Please describe.
TTL is a great function for time series data.
Describe the solution you'd like
Describe alternatives you've considered
Additional context

@liuruiyiyang  pls edit this issue when you finish your design.


edge2261: remove extraneous event models

Signed-off-by: Jonathan Holloway<EMAIL_ADDRESS>Description
Removing deprecated event model definitions
Fixes # (issue) THEEDGE-2261
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[x] Refactor

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 36.24% // Head: 36.30% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (98224f8) compared to base (71aa4b4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   36.24%   36.30%   +0.05%
==========================================
  Files          67       67
  Lines        9030     9024       -6
==========================================
+ Hits         3273     3276       +3
+ Misses       5348     5340       -8
+ Partials      409      408       -1

Impacted Files
Coverage Δ

pkg/models/events.go
0.00% <ø> (ø)

pkg/services/devices.go
49.88% <0.00%> (+0.33%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This PR deletes 108 lines of code and... we don't have unittests for this module?

This PR deletes 108 lines of code and... we don't have unittests for this module?

These lines are related to the first pass struct for adopting the standard cloud event model and are no longer needed.
Tests for lines not covered in existing EDA code will be covered in subsequent PR(s) specific to tests.


Wayland support?

Hey. Been using this since it was released. Enabling Wayland socket on Flatseal and running the application with flatpak run io.github.mimbrero.WhatsAppDesktop --enable-features=UseOzonePlatform --ozone-platform=wayland  makes it run on Wayland fine, except for these two noticeable bugs.

No window decoration (might be gnome known CSD policy, don't if KDE handles this better) and naturally no resizing.
Minimizing and restoring from tray completely crash the application. This is what the console says.

flatpak run io.github.mimbrero.WhatsAppDesktop --enable-features=UseOzonePlatform --ozone-platform=wayland
[3:0215/155108.936036:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No existe el fichero o el directorio
[3:0215/155108.936222:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No existe el fichero o el directorio
[50:0215/155109.057605:ERROR:gpu_init.cc(521)] Passthrough is not supported, GL is egl, ANGLE is
[3:0215/155340.010884:ERROR:wayland_event_watcher.cc(36)] libwayland: wl_surface@32: error 0: gtk_shell::get_gtk_surface already requested
/app/bin/whatsapp-desktop-linux: línea 3:     3 `trap' para punto de parada/seguimiento (`core' generado) zypak-wrapper.sh /app/whatsapp-desktop-linux/whatsapp-desktop-linux "$@"

Now that Wayland is getting to be the default session in prominent distros and DE, it could be a good idea to patch this application to fully support Wayland. Is it possible to do this? Would it require a new electron version? I apologize if I sound unpolite or demanding, my english is a bit rough.
Thanks

FWIW, I don't have either bug on KDE Plasma 5.27.10 when running under Wayland (using the same flags and enabling the Wayland socket using Flatseal).

Running on wayland works, but it crashes after i hid the app then tried to show the app through the appindicator

Same issue with Fedora 40:
flatpak run --socket=wayland io.github.mimbrero.WhatsAppDesktop --enable-features=UseOzonePlatform,WaylandWindowDecorations [3:0903/180417.215934:ERROR:ozone_platform_x11.cc(240)] Missing X server or $DISPLAY [3:0903/180417.215993:ERROR:env.cc(255)] The platform failed to initialize.  Exiting. /app/bin/whatsapp-desktop-linux: line 3:     3 Segmentation fault      (core dumped) zypak-wrapper.sh /app/whatsapp-desktop-linux/whatsapp-desktop-linux "$@"
I had to specifically allow Wayland on Flatseal, otherwise it'd still run on XWayland, as xlsclients reports:
xlsclients  orion  gsd-xsettings orion  ibus-x11 orion  whatsapp-desktop-linux orion  mutter-x11-frames
Fedora doesn't have Electron on the repositories, so I think it just uses the version bundled with the app itself.


Feature Request: Grid Background Stripping; for debugging

Susy has a useful feature that allows adding background stripping to the core grid for debugging. I can't seem to find a similar feature for foundation. Nice to have. Thanks.
http://susy.oddbird.net/guides/reference/#ref-grid-background
(click button on top right of the site to see it active)

Because I keep googling this in successive projects and finding myself here, I finally decided to write a debug mixin.
Hopefully some people find this useful, if so maybe we could look at a pull request...
$debug-on: true;
$debug-bg: grey;
$debug-gutter: $primary-color;

@mixin debug-grid {
    @if $debug-on == true {
        .column,
        .columns {
            position: relative;

            &:before {
                content: '';
                display: block;
                position: absolute;
                top: 0;
                left: 0;
                right: 0;
                bottom: 0;
                background: transparentize($debug-bg, 0.5);
                outline: 1px solid transparentize($debug-gutter, 0.5);

                @each $gutter-key in map-keys($grid-column-gutter) {
                    @if map-get($breakpoints, $gutter-key) != 0px {
                        @media (min-width: map-get($breakpoints, $gutter-key)) {
                            box-shadow: 0.5 * map-get($grid-column-gutter, $gutter-key) 0 0 transparentize($debug-gutter, 0.5) inset,
                                        -0.5 * map-get($grid-column-gutter, $gutter-key) 0 0 transparentize($debug-gutter, 0.5) inset
                        }
                    } @else {
                        box-shadow: 0.5 * map-get($grid-column-gutter, $gutter-key) 0 0 transparentize($debug-gutter, 0.5) inset,
                                    -0.5 * map-get($grid-column-gutter, $gutter-key) 0 0 transparentize($debug-gutter, 0.5) inset
                    }
                }
            }
        }
    }
}

@include debug-grid;

Looks like this:

@tbredin That looks awesome, would love to see a PR for that as I think it would be pretty useful.


Disp s1 triggering grace period

Implements grace period triggering logic for DISP_S1 processing
Fixes many small issues with DISP_S1 processing

All data type query and download have been tested and good to go. Must be used w the latest develop branch of opera-sds-lambda


Gray side panel with console errors.

ng-inspector fails to start, and shows only a gray side bar.  the errors in the console are the following:
Uncaught TypeError: fn.apply is not a function
invoke @ angular.js:3869
Service @ ng-inspector.js:738NGI.Service.Service.parse
Queue @ ng-inspector.js:841
Module @ ng-inspector.js:1058
NGI.Module.Module.register @ ng-inspector.js:1068
NGI.Module.Module.register @ ng-inspector.js:1073
App @ ng-inspector.js:929
NGI.App.App.bootstrap @ ng-inspector.js:979
traverse @ ng-inspector.js:247
reinstall of extension and chrome had no effect.  running latest version of chrome.
thanks for the help!

Hey @jimbler, sorry to hear the extension isn't working.
Do you have a publicly accessible link to the Angular app that you can share with us?

Hi Andrew,
At the moment I don’t have a public facing version, but I can tell you that the app was set-up using Yeoman and generator-angular.
https://github.com/yeoman/generator-angular
From the outset I was unable to use ng-inspector.
Thanks!
From: Andrew<EMAIL_ADDRESS>Sent: Wednesday, April 15, 2015 8:32 AM
To: rev087/ng-inspector
Cc: Jared Imbler
Subject: Re: [ng-inspector] Gray side panel with console errors. (#96)
Hey @jimblerhttps://github.com/jimbler, sorry to hear the extension isn't working.
Do you have a publicly accessible link to the Angular app that you can share with us?
—
Reply to this email directly or view it on GitHubhttps://github.com/rev087/ng-inspector/issues/96#issuecomment-93423936.

@jimbler Thanks! I built and tested one of the example apps built from that generator (link to in the README of the link you sent), and was not able to replicate the issue.

Is there any other info you'd be able to provide that could help me to replicate this behavior?

Andrew,
Here’s a public facing version of the site I’m having issues with:
http://ncioa.cancer.gov/oa-internet/fnlcr/index.html#/home
Same gray window, console errors appear to be different though…
From: Andrew<EMAIL_ADDRESS>Sent: Wednesday, April 15, 2015 9:01 AM
To: rev087/ng-inspector
Cc: Jared Imbler
Subject: Re: [ng-inspector] Gray side panel with console errors. (#96)
@jimblerhttps://github.com/jimbler Thanks! I built and tested one of the example apps built from that generatorhttps://github.com/addyosmani/yeoman-examples/tree/master/angular-localStorage-todos (link to in the README of the link you sent), and was not able to replicate the issue.
[Image removed by sender.]https://camo.githubusercontent.com/d0d8434ce4aa7c879a2de5dc617c3812c190356b/687474703a2f2f692e696d6775722e636f6d2f613476375930762e706e67
Is there any other info you'd be able to provide that could help me to replicate this behavior?
—
Reply to this email directly or view it on GitHubhttps://github.com/rev087/ng-inspector/issues/96#issuecomment-93435091.

Very interesting -- that app is working for me on the latest ng-inspector release (0.5.9) on Chrome Version 42.0.2311.90 (64-bit, OSX).

What version of Chrome are you using, and do you have any other extensions installed that relate to Angular?

Chrome: Version 42.0.2311.90 m (64-bit)
Ng-inspector: 0.5.8
I’ve disabled all other Chrome extensions and the issue continues….
Update: Updated ng-inspector to 0.5.9 and things seem to be working smoothly.  It looks like extension updates were disabled in Chrome.  Doh.
Thanks for the help
From: Andrew<EMAIL_ADDRESS>Sent: Wednesday, April 15, 2015 10:24 AM
To: rev087/ng-inspector
Cc: Jared Imbler
Subject: Re: [ng-inspector] Gray side panel with console errors. (#96)
Very interesting -- that app is working for me on the latest ng-inspector release (0.5.9) on Chrome Version 42.0.2311.90 (64-bit, OSX).
[Image removed by sender. screenshot]https://camo.githubusercontent.com/8dda6f8acc3a62d42165b092a6e96e0d6d047591/687474703a2f2f692e696d6775722e636f6d2f353835355845442e706e67
What version of Chrome are you using, and do you have any other extensions installed that relate to Angular?
—
Reply to this email directly or view it on GitHubhttps://github.com/rev087/ng-inspector/issues/96#issuecomment-93474818.


Allow a pack to specify Python 3 and have corresponding virtualenvs use Python 3

As part of #3233 the pack (and/or) the user needs to be able to specify the minimum Python version required for the pack to operate.
In the case of Python 3, this requires another Python binary in the config.
This PR adds support for the st2common.virtualenv module to specify another Python binary path when building the env.
st2.conf now has a python3_binary setting to specify the default Python 3 binary path. This defaults to /usr/bin/python3 in both Ubuntu and Redhat. For newer versions of ubuntu, /usr/bin/python3 is a symlink to python3.5.
Python 3 has to be explicitly specified in the pack meta file.
If the user does not have a Python 3 binary installed it will fail on Pack Installation, virtualenv will raise an error.
https://github.com/StackStorm/st2/pull/3922/files#diff-4572714cfd795436cbea16dff51e3231R18
The configuration is such:
[actionrunner]
...
# Python binary which will be used by Python actions.
python_binary = /data/stanley/virtualenv/bin/python
python3_binary = /data/stanley/virtualenv/bin/python

The configuration of Python 2 binaries would default to the one running the script, but since this won't be the case in 3, it defaults again to /usr/bin/python3 https://github.com/StackStorm/st2/pull/3922/files#diff-f7f00f2d9fa85d6b39dc2def0f872561R222
pack.yaml now has a flag to specify the creation of the virtualenv using a Python 3 binary
python3: true

TODO :

[x] write tests to check the integration
[ ] update pack.yaml meta template

Notes:
The dev Makefile now explicitly specifies python 2.7 in the virtual env. Some modern distributions will default to 3.x
https://github.com/StackStorm/st2/pull/3922/files#diff-b67911656ef5d18c4ae36cb6741b7965R273
There is now a switch to change the default Python version from 2 to 3. This is not configurable since it would likely break everything! https://github.com/StackStorm/st2/pull/3922/files#diff-1672fdd913c3ff338b3d0f9285d2fa81R59
Packs without meta files would not fail at the virtualenv stage, which is the same behaviour as before https://github.com/StackStorm/st2/pull/3922/files#diff-1672fdd913c3ff338b3d0f9285d2fa81R59

Just tested against a dev instance by:

Cloning the libcloud pack
Changing pack.yaml to have python3: true at the bottom
Installing the pack from git
Checking the Python version installed in the virtualenv

(virtualenv) ubuntu@ubuntu-xenial:~/st2$ /opt/stackstorm/virtualenvs/libcloud/bin/python --version
Python 3.5.2

Integration tested and added unit tests as well. This is now done.

@Kami It's all yours now 🎁

Nice work :+1:

Also @Kami is the meta model typed anywhere? It seems a bit shonky to just hardcode the dictionary keys into the virtualenv logic.

Sorry, didn't have time to dig in yet and take it across the finish line.
Sadly this PR is just a small part of much bigger change to get it into "fully done" state - first I need to figure out how to finalize this PR so everyone will be happy, then documentation, then hooking it up against StackStorm Exchange CI to make sure tests correctly use Python 3 when needed, etc.
But as far as you original question goes - it will still take some time to get everything running under Python 3 and even when that is the case, we will probably still need change like that to allow users to run Python runner actions under different version of Python (e.g. 3 when platform is using 2 and also vice versa).

@Kami What's the plan for this PR?

It would be rad to have it in place, today I was trying to have ansible 2.5.0rc1 and python3 but failed and found this PR... I think I'll just create a virtualenv with py3 manually for now, but it would be great to have it in, keep the good work @Kami!

@brainstorm It's actually @tonybaloney who did the most work on this PR :)
And yeah, manually creating a virtualenv using python3 binary should work for now.
Last time we couldn't come up with a compromise on how to make this work in a robust and straight forward manner and get it merged.
Perhaps a good middle of the ground approach would be to just add use_python3 (or similar) parameter to pack install action and CLI command. This way it would be opt-in and allow and easy way for user to switch back in case there are issues with Python 3.
What do others think?

Closing - continuation in #4076.
Hopefully we can resolve some of those issues which were uncovered yesterday and get it shipped in v2.8.0.


UDS paths result in invalid GRPC authority

What version of gRPC and what language are you using?
Any version after 1.57.0.
What operating system (Linux, Windows,...) and version?
MacOS and Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
Python 3.11.7.
What did you do?
When using the client with a unix domain socket, the default :authority pseudo header is the %-encoding of the socket path. However, this results in a hostname that contains % characters which are invalid. (I'm using tonic + hyper in rust which rejects this request)
with grpc.insecure_channel("unix:/run/sock.sock") as channel:

What did you expect to see?
The authority in the case of a UDS should just be interpreted as localhost or something else without invalid characters. This was done until this commit: https://github.com/grpc/grpc/pull/33571.
What did you see instead?
My gRPC server rejects the request as malformed. I know that I can manually set the authority through channel options, but this is not always possible with libraries that use grpc and I believe the underlying issue is here.
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
See TROUBLESHOOTING.md for how to diagnose problems better.

As discussed in #33571, this is working as intended.  If you are encountering a server that doesn't like the authority that we are sending, you can have the client explicit set the authority to "localhost" via the GRPC_ARG_DEFAULT_AUTHORITY channel arg.