Confusion from "Error: missing update value/file or path"

$ gnmic version
version : 0.26.0
 commit : ba387ba
   date : 2022-06-29T06:52:10Z
 gitURL : https://github.com/karimra/gnmic
   docs : https://gnmic.kmrd.dev

I was confused by an error message from gnmic.
The following works (action is performed, response is returned):
gnmic ... -e json_ietf set --update-path '/interfaces/interface[name="Bundle-Ether2"]/subinterfaces' --update-value '{"subinterface":[{"index":9876}]}'

The following doesn't work:
gnmic ... -e json_ietf set --update-path '/interfaces/interface[name="Bundle-Ether2"]/subinterfaces' --update-value '{"subinterface":[{"index":9876,"config":{"index":9876}}]}'

Instead this returns "Error: missing update value/file or path". And yet I've provided both a path and a value, and jq confirms the JSON value is valid:
$ echo '{"subinterface":{"index":9876,"config":{"index":9876}}}' | jq .
{
  "subinterface": {
    "index": 9876,
    "config": {
      "index": 9876
    }
  }
}

Looking for this error message in the code, I find it here:
        if len(c.LocalFlags.SetUpdatePath) != len(c.LocalFlags.SetUpdateValue) && len(c.LocalFlags.SetUpdatePath) != len(c.LocalFlags.SetUpdateFile) {
		return errors.New("missing update value/file or path")
	}

These are []string. But from the point of view of a dumb user like me, I think I've provided 1 path and 1 value.  Adding -d flag seems to confirm this:
2022/08/20 14:42:49.968783 /home/runner/work/gnmic/gnmic/app/app.go:264: [gnmic] set-update-path='[/interfaces/interface[name="Bundle-Ether2"]/subinterfaces]'([]string)
2022/08/20 14:42:49.968802 /home/runner/work/gnmic/gnmic/app/app.go:264: [gnmic] set-update-value='[{"subinterface":[{"index":9876,"config":{"index":9876}}]}]'([]string)
...
2022/08/20 14:42:49.969326 /home/runner/work/gnmic/gnmic/config/config.go:343: [config] cmd=set, flagName=update-path, changed=true, isSetInFile=true
2022/08/20 14:42:49.969341 /home/runner/work/gnmic/gnmic/config/config.go:343: [config] cmd=set, flagName=update-value, changed=true, isSetInFile=true

Note that it says that set-update-value is []string, with apparently one element in the list.
After digging through the code, I believe the issue is introduced in SanitizeArrayFlagValue.  First, it strips off any outer pairs of [ and ].  Then it breaks the string on comma, unconditionally.  In my case, I have a comma in there, but it's part of a compound value, and it didn't occur to me that it would be split here. The debug output shows the value before the split, and the error message seemed to be telling me I hadn't provided a value, when I had.
I suggest the error message could be clarified like this:
"number of update-paths (1) does not match number of update-values (2) or update-files (0)"
Other ideas:

The help could say --update-value stringArray (comma separated)
The debug output could be shown after the string splitting, and with %#v instead of %+v
In an ideal world, I'd like to be able to provide any valid JSON value inline, with repeated args if necessary: --update-value foo --update-value bar. But I realise that would be an incompatible change to the CLI.

Anyway, I hope you don't mind this feedback - thanks for an otherwise great tool!

Just to throw one more into the pot, here's a different confusing error message which may not be gnmic's fault, but if it's a server error response it could be displayed more clearly.
This works:
$ gnmic -a <IP_ADDRESS>:57400 -u ... -p ... --insecure -e json_ietf \
    get --path '/interfaces/interface[name="Bundle-Ether2"]/subinterfaces/subinterface[index=9876]'

Now I add something invalid to the end of the path:
$ gnmic -a <IP_ADDRESS>:57400 -u ... -p ... --insecure -e json_ietf \
    get --path '/interfaces/interface[name="Bundle-Ether2"]/subinterfaces/subinterface[index=9876]/ipv4'
error marshaling message: invalid character ':' after top-level valuetarget "<IP_ADDRESS>:57400": invalid character ':' after top-level value
Error: one or more requests failed

I didn't add a colon though. Looking at tcpdump, some communication does take place, and I can see the path in cleartext.
"Marshaling" to me normally means "encoding".  However i's not clear to me whether the issue is client side with encoding the request, or the Cisco's response is somehow invalid (this is IOS-XR 7.2.2, BTW) in which case the problem is in decoding the response.

Now I add something invalid to the end of the path:

Hi
can you try using another formatting option by adding -f prototext to see what cisco returns
it seems that whatever it returns in a gnmi message can't be marshalled to json string that is used by default

Sure (it's --format not -f).  This is the bad one with /ipv4 on the path:
notification: {
  timestamp:<PHONE_NUMBER>069334955
  update: {
    path: {
      elem: {
        name: "interfaces"
      }
      elem: {
        name: "interface"
        key: {
          key: "name"
          value: "\"Bundle-Ether2\""
        }
      }
      elem: {
        name: "subinterfaces"
      }
      elem: {
        name: "subinterface"
        key: {
          key: "index"
          value: "9876"
        }
      }
      elem: {
        name: "ipv4"
      }
    }
    val: {
      json_ietf_val: "\"index\":9876"
    }
  }
}
error: {}

And the good one without:
notification: {
  timestamp:<PHONE_NUMBER>664384155
  update: {
    path: {
      elem: {
        name: "interfaces"
      }
      elem: {
        name: "interface"
        key: {
          key: "name"
          value: "\"Bundle-Ether2\""
        }
      }
      elem: {
        name: "subinterfaces"
      }
      elem: {
        name: "subinterface"
        key: {
          key: "index"
          value: "9876"
        }
      }
    }
    val: {
      json_ietf_val: "[{\"index\":9876,\"state\":{\"index\":9876,\"name\":\"Bundle-Ether2.9876\",\"enabled\":true,\"admin-status\":\"UP\",\"oper-status\":\"UP\",\"last-change\":\"1661012733839605487\",\"counters\":{\"in-unicast-pkts\":\"0\",\"in-pkts\":\"0\",\"in-broadcast-pkts\":\"0\",\"in-multicast-pkts\":\"0\",\"in-octets\":\"0\",\"out-unicast-pkts\":\"0\",\"out-broadcast-pkts\":\"0\",\"out-multicast-pkts\":\"0\",\"out-pkts\":\"0\",\"out-octets\":\"0\",\"out-discards\":\"0\",\"in-discards\":\"0\",\"in-unknown-protos\":\"0\",\"in-errors\":\"0\",\"in-fcs-errors\":\"0\",\"out-errors\":\"0\",\"carrier-transitions\":\"0\",\"last-clear\":\"2022-08-18T11:55:34.737+01:00\"},\"ifindex\":129,\"logical\":true},\"openconfig-if-ip:ipv4\":{\"state\":{\"counters\":{\"in-octets\":\"0\",\"in-pkts\":\"0\",\"out-octets\":\"0\",\"out-pkts\":\"0\"}}},\"openconfig-if-ip:ipv6\":{\"state\":{\"counters\":{\"in-octets\":\"0\",\"in-pkts\":\"0\",\"out-octets\":\"0\",\"out-pkts\":\"0\"}}}}]"
    }
  }
}
error: {}

Hmm, so the bad one really is bad (a JSON object without {...} ?!)
Might be nice to display this as part of the error though.

Hi,
The comma issue in flags --update-value and --replace-value is a known issue, it ultimately comes from the underlying packages used to parse the flags and set the config values (pflag and viper).
Instead if trying to figure out how different shells and different repeated flags will behave, there are a few other options that can be used to set a more complex value.
If you would like to set a compound json value you have a couple of options:

Use --update-file instead of --update-value:
You can create a file with the desired value and run the same command with --update-file.
Or set the value using stdin to --update-file: gnmic .... --update-file - | echo '{JSON_BLOB_HERE}'
Use --request-file:
This flag allows you to set the whole request (updates, replaces and deletes) in a single file (YAML or JSON).
As a bonus, the request-file can be a Go Text template that will be rendered per target, so a single file can result in different set requests for each target. See here.
As an example, your request above would be:

$ cat req_file.yaml

updates:
  - path: /interfaces/interface[name="Bundle-Ether2"]/subinterfaces
    encoding: json_ietf
    value:
      subinterface:
        index: 9876
        config:
          index: 9876

$ gnmic ... set --request-file req_file.yaml

Hmm, so the bad one really is bad (a JSON object without {...} ?!)
Might be nice to display this as part of the error though.

Yes and the error is displayed: error marshaling message: invalid character ':' after top-level value

I got it working with --update-file, thanks.

it ultimately comes from the underlying packages used to parse the flags and set the config values (pflag and viper).

There is StringArray:
package main

import flag "github.com/spf13/pflag"
import "fmt"

func main() {
	uvp := flag.StringArray("update-value", nil, "set update request value")
	flag.Parse()
	fmt.Printf("%#v\n", *uvp)
}

$ go run main.go --update-value foo --update-value bar
[]string{"foo", "bar"}

Yes and the error is displayed: error marshaling message: invalid character ':' after top-level value

Of course, although it doesn't show the actual value it's complaining about (I didn't know about --format prototext)
The confusion for me as a user was from seeing "error marshaling message", when to me the problem is unmarshaling the response.  Looking at code, I think this is an implementation detail, with a marshal and unmarshal pair. Also, "message" could refer to either the request or the response.
Perhaps "error decoding response", or even "error decoding json_ietf_val in response", would be clearer?
Cheers,
Brian.

I got it working with --update-file, thanks.

it ultimately comes from the underlying packages used to parse the flags and set the config values (pflag and viper).

There is StringArray:
package main

import flag "github.com/spf13/pflag"
import "fmt"

func main() {
	uvp := flag.StringArray("update-value", nil, "set update request value")
	flag.Parse()
	fmt.Printf("%#v\n", *uvp)
}

$ go run main.go --update-value foo --update-value bar
[]string{"foo", "bar"}

StringArray is what is used right now because StringSlice did too many things under the hood (e.g reading the flag as a CSV line).
The flags can also be set from ENV or from a config file, viper does not handle string arrays and slices properly (returns them as a string of comma separated values in both cases), hence the usage of StringArray and SanitizeArrayFlagValue func.

Yes and the error is displayed: error marshaling message: invalid character ':' after top-level value

Of course, although it doesn't show the actual value it's complaining about (I didn't know about --format prototext)
The confusion for me as a user was from seeing "error marshaling message", when to me the problem is unmarshaling the response. Looking at code, I think this is an implementation detail, with a marshal and unmarshal pair. Also, "message" could refer to either the request or the response.
Perhaps "error decoding response", or even "error decoding json_ietf_val in response", would be clearer?
Cheers,
Brian.

The error does not happen when reading the value from the received message, it happens when trying to marshal it to JSON to print it out on the terminal. gNMIc reads the json/json_ietf values as []byte, it does not validate that the bytes are valid json on reception.
I'm not against adding the name of the message to the logged error.


[semantic-dom-diff] TypeScript typings aren't available

When I import @open-wc/semantic-dom-diff, TypeScript complains that it can't find the module. The .d.ts file is installed with the package, though I don't see a "typings" entry in package.json.

@bennypowers I think you fixed this one?

in c8a3b18936de43cba0227c146e77b60a04327e41


Break down the article task

when I add an item to my quote line, I want to be able to import the item's stains


Copy frame opens with no messages

Description
If you leave the game client open in the background and return to it after some time and try to open the copy frame, there are occasionally no messages.
Addon Version
2.0.2-release
World of Warcraft Game Version
1.14.3
World of Warcraft Region
Americas.
Lua Error
Not applicable.
Reproduction Steps

Launch World of Warcraft.
Minimize the client for 5 to 10 minutes.
Return to the game and try to open the copy frame for a chat frame it is enabled for.

Fixed with https://github.com/drzewieckinicholas/ChatFramePlus/commit/a4ee8630cccf5f816ae92ce1a241d96bd3b46c0f
Maybe it would be helpful to create some simple examples from the following link and revisit this: https://github.com/tomrus88/BlizzardInterfaceCode/blob/master/Interface/SharedXML/Pools.lua


Government Of British Columbia | Update to lowercase "of" to align with BC Government web standards |1|

https://trello.com/c/DOIt8ARy/839-government-of-british-columbia-update-to-lowercase-of-to-align-with-bc-government-web-standards-1
For consistency with the BC Government Web Style Guide; see https://www2.gov.bc.ca/gov/content/governments/services-for-government/policies-procedures/web-content-development-guides/writing-for-the-web/web-style-guide/capitalization#government
Adjust organization name of government from "Government Of British Columbia" to "Government of British Columbia"

 Government Of British Columbia | Update to lowercase "of" to align with BC Government web standards |1|


When will the new update come out?

When will the new update come out? Regarding the community settings issue

already out.


Empty benthos -version on v3.3.1

v3.2.0 was correctly giving:
✗ benthos -version
Version: 3.2.0
Date: 2019-10-11T04:49:51Z

but the latest v3.3.1 gives an empty version and date:
✗ benthos -version
Version:
Date:

Hey @stephanebruckert, thanks for raising this, should be fixed in v3.4.0 and beyond.


Feature/documentation

@yulrizka I think this is good to go now. Could you merge if you agree?

@Tubyhes Could you merge after checking the revision commit? Thanks!

Removed the generated output, The final documentation will be available in release page and gh-pages branch (when we release new version).

I'll merge this because the story is accepted by @Tubyhes


Plugin is not applied to modules (library projects)

There is not way to generate strings from templates inside submodules (com.android.library)

Hi @danaimset, that's as expected at the moment, only strings in the project are used and the ones in the project's dependencies are ignored. I'm planning to add support for strings in dependencies too for the next release.

Hi @danaimset you can now use strings from your app's dependencies by turning on in your app's build.gradle file the new flag useDependenciesRes added on 1.2.0 like so:
stringXmlReference {
    useDependenciesRes = true
}

Hope that gets it sorted for you.
Cheers.

@LikeTheSalad cool, that last option makes the lib feasible for our project. We will try It out to generate URIs to be used by android jetpack navigation deeplink property. making uris ://<host_name>

Glad to hear it @Voto I hope it works as you need it, in case you find a problem please raise a ticket 🙂


Create playbook for TUF root issues

Description

Manually syncing preprod to prod
Manually creating new snapshot/timestamp

cc @asraa
Context: https://github.com/sigstore/root-signing/issues/422


Customize presentation with material-ui (or any other visual framework)

Summary
Look and feel customization, at first blush, is a mystery to me as a new user of react-stripe-elements
I hope react-stripe-elements would be integratable with semantics of any input (with value masking).  Without such semantics, it does not easily integrate with any other visual framework available.  I hope I am missing something.
I found this discussion and answer: https://github.com/stripe/react-stripe-elements/issues/130#issuecomment-346509248

For PCI DSS SAQ A compatibility, you need Stripe to handle sensitive card information, which means the actual inputs for sensitive card information need to be hosted in Stripe iframes.
I'm not familiar with that particular library. However, while you won't be able to use their  directly, you should be able to lightly wrap Stripe Elements with whatever other components you need. If there's something specific that's blocking that, please let us know!

@jenan-stripe how exactly would you be able to lightly wrap a stripe-element with material-ui for visuals?  I'm a material-ui committer, so I know the internals intimately and it is very flexible.  The problem is that react-stripe-elements produces an unusable structure - it does not produce an element that behaves like an input,  does it?

Therefore, how does one wrap it with semantics to produce a material ui element? https://material-ui-next.com/demos/text-fields/
For use as a material-ui input element, the react-stripe-element needs to bubble the following events at a minimum:

onChange to calculate isDirty (filled with anything) - to determine the label placement/animation.  We don't need the actual value, you could propagate * for each keystroke
onFocus to animate label up and set underline animation
onBlur to set label placement/animation based on isDirty and set underline

Does an individual react-stripe-element bubble events such as this?
Is there a react example that shows using these elements like an input?
/cc @nareshbhatia (original issue)

TL;DR
I guess the biggest help with be a code snippet that created a React.Component for a cardNumber that propagated onChange, onFocus, and onBlur.
After some time looking (which feels like a fair bit of wasted time, I was brought in after a day of research), it does seem like Element accepts handlers/propagates these events, though the flow definition on these is not helpful in determining if it is a standard handler or not.
https://github.com/stripe/react-stripe-elements/blob/master/src/components/Element.js#L7
So can you confirm that Element behaves like a standard input in regards to onChange|onBlur|onFocus?
Thanks in advance.

👋 You might want to take a look at #116 (How to style react-stripe-elements with Bootstrap). There's a JSFiddle that shows how you use react-stripe-elements with Bootstrap without needing any upstream changes to Bootstrap itself.
Some tips to help understand how to add custom styles to Elements:

All block-level styles should be applied to the Element container:

https://stripe.com/docs/stripe-js/reference#the-element-container
These are classes like .StripeElement, .StripeElement--focus, etc.

All inline / text-level styles should be passed as configuration options to the Element itself.

https://stripe.com/docs/stripe-js/reference#element-options
See in particular: the style property.

Be sure to check out the JSFiddle to see the interplay between these special class names and the options that are passed in with the style property.

@jez covers some of the styling details above!
To expand on how Elements work and the event handlers: each Element is an abstraction over an input and some associated DOM nodes within an iframe, and exposes a limited API on the this abstraction. Elements must be rendered within iframes hosted on a Stripe domain for PCI DSS SAQ A compatibility.
The list of event handlers you can register, and the shape of the returning payload, are documented at the Stripe.js reference: https://stripe.com/docs/stripe-js/reference#element-on.
Specifically for the onChange, onFocus, and onBlur handlers, the payload is limited (and a small subset of the DOM event), but should be enough for your use-case. Note also that these event handlers may be fired with a tiny delay after the DOM actually fires the event, since the event needs to bubble up from within the iframe to the outside page.
To focus on your use-case:

onChange to calculate isDirty (filled with anything) - to determine the label placement/animation. We don't need the actual value, you could propagate * for each keystroke

You can do this by attaching an onChange handler, and mark isDirty = true when the payload contains empty: false, and mark isDirty = false when the payload contains empty: true.

onFocus to animate label up and set underline animation
onBlur to set label placement/animation based on isDirty and set underline

Both of these should work with the allowed onFocus and onBlur handlers.

Thanks @jez and @atty-stripe - it seems like I can get the events.
I'll close this and give it a shot and try to share the result in a codesanbox.  If I have any issues I'll reopen.

That sounds great, thank you!

That is exactly what I am looking for.
@rosskevin did you find a solution for this and would be able to share your code?

@lfalke what exactly are you looking for? Styling an Element, or listening for events? Both topics are covered in the README and in our reference documentation here: https://stripe.com/docs/stripe-js/reference.
Feel free to post more details here or create a new issue if you have questions with react-stripe-elements.

I was looking for an example on how to use react-stripe-elements with the material-ui styling.
But after a bit of trial and error I came up with a solution that works perfectly.

@lfalke would you share your solution?
I can't even get point

Thanks a lot. @lfalke 👍  I now know what I have to do

I have been using an approach very close to @lfalke's gist. It's a great starting point 👌.

We have a dedicated thread to this problem in https://github.com/mui-org/material-ui/issues/16037.


HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x

Note that is includes duplicating the protobuf generated file shading setup from hbase-shaded-protocol.
Another option is to move the protobuf processing to hbase-shaded-protocol, and avoid doing the shading in two modules. (as done on branch-3+)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s

branch-2 passed

+1 :green_heart:
compile
6m  4s

branch-2 passed

+1 :green_heart:
checkstyle
1m 17s

branch-2 passed

+1 :green_heart:
spotbugs
10m  5s

branch-2 passed

+1 :green_heart:
spotless
0m 47s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  6s

the patch passed

+1 :green_heart:
compile
5m 56s

the patch passed

+1 :green_heart:
javac
5m 56s

root generated 0 new + 1232 unchanged - 1 fixed = 1232 total (was 1233)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 14s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
10m 29s

the patch passed

+1 :green_heart:
hadoopcheck
17m  8s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 46s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

64m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux 80c610fce765 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 99ad3e28041397bdafb5064f5f79c92544007de2

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
181 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 14s

branch-2 passed

+1 :green_heart:
compile
2m 13s

branch-2 passed

+1 :green_heart:
javadoc
2m 24s

branch-2 passed

+1 :green_heart:
shadedjars
5m 59s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  3s

the patch passed

+1 :green_heart:
compile
2m 12s

the patch passed

+1 :green_heart:
javac
2m 12s

the patch passed

-0 :warning:
javadoc
0m 15s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
1m 58s
/results-javadoc-javadoc-root.txt
root generated 10 new + 101 unchanged - 0 fixed = 111 total (was 101)

+1 :green_heart:
shadedjars
6m  0s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
275m  2s

root in the patch passed.

310m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cdd666dc3825 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 99ad3e28041397bdafb5064f5f79c92544007de2

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/testReport/

Max. process+thread count
8791 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s

branch-2 passed

+1 :green_heart:
compile
7m  8s

branch-2 passed

+1 :green_heart:
checkstyle
1m 31s

branch-2 passed

+1 :green_heart:
spotbugs
10m  9s

branch-2 passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  9s

the patch passed

+1 :green_heart:
compile
6m  8s

the patch passed

+1 :green_heart:
javac
6m  8s

root generated 0 new + 1232 unchanged - 1 fixed = 1232 total (was 1233)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 10s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
10m 23s

the patch passed

+1 :green_heart:
hadoopcheck
17m  2s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 47s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

66m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux a68e764fbb94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
181 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  9s

branch-2 passed

+1 :green_heart:
compile
2m 13s

branch-2 passed

+1 :green_heart:
javadoc
2m 23s

branch-2 passed

+1 :green_heart:
shadedjars
5m 59s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 10s

the patch passed

+1 :green_heart:
compile
2m 13s

the patch passed

+1 :green_heart:
javac
2m 13s

the patch passed

-0 :warning:
javadoc
0m 15s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
1m 58s
/results-javadoc-javadoc-root.txt
root generated 10 new + 101 unchanged - 0 fixed = 111 total (was 101)

+1 :green_heart:
shadedjars
5m 56s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
231m 42s
/patch-unit-root.txt
root in the patch failed.

265m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 09ca1ee441dc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/testReport/

Max. process+thread count
5069 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

-0 :warning:
yetus
0m  9s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 40s

branch-2 passed

+1 :green_heart:
compile
2m 56s

branch-2 passed

+1 :green_heart:
javadoc
3m 36s

branch-2 passed

+1 :green_heart:
shadedjars
7m 21s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 21s

the patch passed

+1 :green_heart:
compile
3m  6s

the patch passed

+1 :green_heart:
javac
3m  6s

the patch passed

-0 :warning:
javadoc
0m 20s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
2m 16s
/results-javadoc-javadoc-root.txt
root generated 10 new + 187 unchanged - 0 fixed = 197 total (was 187)

+1 :green_heart:
shadedjars
8m 35s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
342m 17s
/patch-unit-root.txt
root in the patch failed.

387m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 20bcb4bbb50f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/testReport/

Max. process+thread count
4847 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  9s

Docker mode activated.

-0 :warning:
yetus
0m  9s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  1s

branch-2 passed

+1 :green_heart:
compile
2m 15s

branch-2 passed

+1 :green_heart:
javadoc
3m  6s

branch-2 passed

+1 :green_heart:
shadedjars
6m 33s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
2m 43s

the patch passed

+1 :green_heart:
javac
2m 43s

the patch passed

-0 :warning:
javadoc
0m 21s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
2m 21s
/results-javadoc-javadoc-root.txt
root generated 10 new + 84 unchanged - 0 fixed = 94 total (was 84)

+1 :green_heart:
shadedjars
6m 50s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
503m 54s

root in the patch passed.

542m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4cbccc07188c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/testReport/

Max. process+thread count
8050 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

The reported javadoc issues are in the generated protobuf code, @Apache9 .
Looking at hbase-protocol, javadoc generation is completely disabled there.
We are also excluding generated file in the report generation javadoc phase, but that's not an option hbase-rest.
Should I add the same exclude settings to the normal (build) javadoc settings in the root pom ?
Or should I override the javadoc plugin config in the hbase-rest module ?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s

branch-2 passed

+1 :green_heart:
compile
5m 55s

branch-2 passed

+1 :green_heart:
checkstyle
1m 15s

branch-2 passed

+1 :green_heart:
spotbugs
9m 50s

branch-2 passed

+1 :green_heart:
spotless
0m 47s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 10s

the patch passed

+1 :green_heart:
compile
5m 58s

the patch passed

+1 :green_heart:
javac
5m 58s

root generated 0 new + 1232 unchanged - 1 fixed = 1232 total (was 1233)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  9s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
10m 18s

the patch passed

+1 :green_heart:
hadoopcheck
17m  6s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 46s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

63m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux fc0dd6901746 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 87620c8d5c45999841336ce077c781481351bea2

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
179 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

I have moved the javadoc exclusions from the report section to the dependencyManagement section, so that they also apply in the build section.
Can you take another look @Apache9 ?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 29s

branch-2 passed

+1 :green_heart:
compile
2m 20s

branch-2 passed

+1 :green_heart:
javadoc
2m 38s

branch-2 passed

+1 :green_heart:
shadedjars
6m  6s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 15s

the patch passed

+1 :green_heart:
compile
2m 22s

the patch passed

+1 :green_heart:
javac
2m 22s

the patch passed

-0 :warning:
javadoc
0m 15s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
2m  0s
/results-javadoc-javadoc-root.txt
root generated 10 new + 89 unchanged - 12 fixed = 99 total (was 101)

+1 :green_heart:
shadedjars
6m  7s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
234m  9s
/patch-unit-root.txt
root in the patch failed.

269m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 811ba6b0c135 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 87620c8d5c45999841336ce077c781481351bea2

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/testReport/

Max. process+thread count
5032 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s

branch-2 passed

+1 :green_heart:
compile
2m 11s

branch-2 passed

+1 :green_heart:
javadoc
2m 26s

branch-2 passed

+1 :green_heart:
shadedjars
6m  9s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s

the patch passed

+1 :green_heart:
compile
2m 14s

the patch passed

+1 :green_heart:
javac
2m 14s

the patch passed

-0 :warning:
javadoc
0m 14s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
1m 46s
/results-javadoc-javadoc-root.txt
root generated 36 new + 149 unchanged - 38 fixed = 185 total (was 187)

+1 :green_heart:
shadedjars
6m 10s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
242m 53s
/patch-unit-root.txt
root in the patch failed.

277m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 11dda869f04b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 87620c8d5c45999841336ce077c781481351bea2

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/testReport/

Max. process+thread count
5083 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for branch

-1 :x:
mvninstall
2m 31s
/branch-mvninstall-root.txt
root in branch-2 failed.

+1 :green_heart:
compile
1m 44s

branch-2 passed

-0 :warning:
javadoc
1m 26s
/branch-javadoc-root.txt
root in branch-2 failed.

+1 :green_heart:
shadedjars
5m 19s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 21s

the patch passed

+1 :green_heart:
compile
1m 41s

the patch passed

+1 :green_heart:
javac
1m 41s

the patch passed

-0 :warning:
javadoc
0m 14s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
1m 32s
/results-javadoc-javadoc-root.txt
root generated 10 new + 84 unchanged - 0 fixed = 94 total (was 84)

+1 :green_heart:
shadedjars
5m 16s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
412m 54s

root in the patch passed.

442m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 837acfe5a760 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 87620c8d5c45999841336ce077c781481351bea2

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/testReport/

Max. process+thread count
7885 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  3s

branch-2 passed

+1 :green_heart:
compile
2m 14s

branch-2 passed

+1 :green_heart:
javadoc
2m 38s

branch-2 passed

+1 :green_heart:
shadedjars
5m 30s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 59s

the patch passed

+1 :green_heart:
compile
2m 10s

the patch passed

+1 :green_heart:
javac
2m 10s

the patch passed

-0 :warning:
javadoc
0m 16s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
2m  0s
/results-javadoc-javadoc-root.txt
root generated 10 new + 89 unchanged - 12 fixed = 99 total (was 101)

+1 :green_heart:
shadedjars
5m 32s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
300m 29s

root in the patch passed.

335m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0e502c43a1de 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4549bf2eb224874b77977113678de014ae6124b4

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/testReport/

Max. process+thread count
9055 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 21s

branch-2 passed

+1 :green_heart:
compile
2m 10s

branch-2 passed

+1 :green_heart:
javadoc
2m 20s

branch-2 passed

+1 :green_heart:
shadedjars
6m 10s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  5s

the patch passed

+1 :green_heart:
compile
2m 10s

the patch passed

+1 :green_heart:
javac
2m 10s

the patch passed

-0 :warning:
javadoc
0m 14s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
1m 47s
/results-javadoc-javadoc-root.txt
root generated 36 new + 149 unchanged - 38 fixed = 185 total (was 187)

+1 :green_heart:
shadedjars
6m 10s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
315m 44s

root in the patch passed.

351m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 365d2adc94f8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4549bf2eb224874b77977113678de014ae6124b4

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/testReport/

Max. process+thread count
8499 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

-1 :x:
mvninstall
1m 19s
/branch-mvninstall-root.txt
root in branch-2 failed.

+1 :green_heart:
compile
1m 46s

branch-2 passed

-0 :warning:
javadoc
0m 57s
/branch-javadoc-root.txt
root in branch-2 failed.

-0 :warning:
javadoc
0m  9s
/branch-javadoc-hbase-rest.txt
hbase-rest in branch-2 failed.

+1 :green_heart:
shadedjars
5m 17s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s

the patch passed

+1 :green_heart:
compile
1m 42s

the patch passed

+1 :green_heart:
javac
1m 42s

the patch passed

-0 :warning:
javadoc
1m 32s
/results-javadoc-javadoc-root.txt
root generated 40 new + 54 unchanged - 0 fixed = 94 total (was 54)

-0 :warning:
javadoc
0m 14s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

+1 :green_heart:
shadedjars
5m 16s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
410m  5s

root in the patch passed.

438m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7619c89d7655 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4549bf2eb224874b77977113678de014ae6124b4

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/testReport/

Max. process+thread count
7962 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . hbase-rest U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

rebased to current branch-2

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s

branch-2 passed

+1 :green_heart:
compile
6m 10s

branch-2 passed

+1 :green_heart:
checkstyle
1m 11s

branch-2 passed

+1 :green_heart:
spotbugs
10m  1s

branch-2 passed

+1 :green_heart:
spotless
0m 47s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 11s

the patch passed

+1 :green_heart:
compile
6m 10s

the patch passed

+1 :green_heart:
javac
6m 10s

root generated 0 new + 1237 unchanged - 1 fixed = 1237 total (was 1238)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 32s

the patch passed

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
12m 22s

the patch passed

+1 :green_heart:
hadoopcheck
18m 36s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 46s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

69m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti

uname
Linux 23d5e25613ae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
178 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Can you take another look, @Apache9  ?
Are the new javadoc generation changes acceptable ?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  6s

branch-2 passed

+1 :green_heart:
compile
2m 12s

branch-2 passed

+1 :green_heart:
javadoc
2m 38s

branch-2 passed

+1 :green_heart:
shadedjars
5m 28s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 57s

the patch passed

+1 :green_heart:
compile
2m 10s

the patch passed

+1 :green_heart:
javac
2m 10s

the patch passed

-0 :warning:
javadoc
0m 16s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
2m  0s
/results-javadoc-javadoc-root.txt
root generated 10 new + 89 unchanged - 12 fixed = 99 total (was 101)

+1 :green_heart:
shadedjars
5m 27s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
248m 20s
/patch-unit-root.txt
root in the patch failed.

282m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a75c144ead5b 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/testReport/

Max. process+thread count
4841 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 11s

branch-2 passed

+1 :green_heart:
compile
2m  4s

branch-2 passed

+1 :green_heart:
javadoc
2m 18s

branch-2 passed

+1 :green_heart:
shadedjars
5m 56s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 56s

the patch passed

+1 :green_heart:
compile
2m  5s

the patch passed

+1 :green_heart:
javac
2m  5s

the patch passed

-0 :warning:
javadoc
0m 13s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
1m 46s
/results-javadoc-javadoc-root.txt
root generated 36 new + 149 unchanged - 38 fixed = 185 total (was 187)

+1 :green_heart:
shadedjars
5m 50s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
310m 39s

root in the patch passed.

346m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 52522665afb3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/testReport/

Max. process+thread count
8959 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s

branch-2 passed

+1 :green_heart:
compile
1m 46s

branch-2 passed

+1 :green_heart:
javadoc
1m 59s

branch-2 passed

+1 :green_heart:
shadedjars
5m 21s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s

the patch passed

+1 :green_heart:
compile
1m 43s

the patch passed

+1 :green_heart:
javac
1m 43s

the patch passed

-0 :warning:
javadoc
0m 15s
/results-javadoc-javadoc-hbase-rest.txt
hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-0 :warning:
javadoc
1m 33s
/results-javadoc-javadoc-root.txt
root generated 10 new + 84 unchanged - 0 fixed = 94 total (was 84)

+1 :green_heart:
shadedjars
5m 18s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
415m 54s

root in the patch passed.

447m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6075

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 28272bc62f88 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/testReport/

Max. process+thread count
8005 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Refactor Engine Logging and Add Natvis Diagnostic Logging

This PR refactors how logging works for the MIEngine repo and adds a second logger for Natvis.

Status: Still working on this PR, just getting things rebased and some issues addressed.

OSX test is flaky.


Unincognito command

Client:
Prettified the Client code to make it appealing.
Implement IncognitoPlayers table
Admins:
Prevent left players from incognito
HeadAdmins:
Implement UnIncognito command to make players visible again.
Process:
Implement check to prevent players who have left or are not inside the players parent (Sanity check) from being shown.

Fixed the indentation abomination.

Finally, Franky Cartilage, Louis Tendon, Skylar. Took you long enough


[Feature]: Map chrome extension frame into puppeeter frame

Feature description
I don't think there is an easy way to find puppeter frame by chrome extension frame. Example:
const currentChromeFrame = await chrome.webNavigation.getFrame({ tabId, frameId });
const puppeterFrame = page.frames().find((x) => x.url() === currentChromeFrame.url);
This is an example to find it by url, but what if we have multiple iframes with the same url?
Is there a way to map it by id? FrameId in chrome frame is a number in the format of 1234, whereas puppeeter is a string.

So CDP operates on a lower level (e.g., CDP still works if a browser implementation does not ship with extensions like chrome-headless-shell) and has its own identifiers. I think it's fairly unlikely that those will be aligned but it might be possible that we implement some sort of lookup mechanism via the extensions domain in the future https://chromedevtools.github.io/devtools-protocol/tot/Extensions/.


ansible2: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
Bump version to latest upstream release. Also disable Python 3, as that's explicitly not supported upstream. Also added the readline lib as a dependency so the new ansible-console tool will work.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] OS X
[x] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

in the future please prefix the name of the package you use in the commit with pythonPackages., so for example pythonPackages.ansible2.


Revert changes to ArrayPropertyOpt to avoid address phis

rdar://101095704

@swift-ci please build toolchain Windows platform

@swift-ci please build toolchain Windows platform

@swift-ci test

@swift-ci please build toolchain Windows platform

@swift-ci test

The changes could cause invalid SIL in a few cases with operands not dominating their instruction. I am reverting this, because the fix isn't looking quick. I'll merge it back when I have a fix.

cc @atrick


Bug in function setLed()

You can set only one LED in the same row. If you set another LED in the same row the other turns off!

Sorry, but can't confirm this behaviour. Here is stripped down version of the LedControl matrix example that blinks/lights up all of the leds on the matrix one after the other. Do you see a different result when you run this code with your hardware?
//We always have to include the library
#include "LedControl.h"

/*
 Now we need a LedControl to work with.
 ***** These pin numbers will probably not work with your hardware *****
 pin 12 is connected to the DataIn
 pin 11 is connected to the CLK
 pin 10 is connected to LOAD
 We have only a single MAX72XX.
 */
LedControl lc=LedControl(12,11,10,1);

/* we always wait a bit between updates of the display */
unsigned long delaytime=75;

void setup() {
  /*
   The MAX72XX is in power-saving mode on startup,
   we have to do a wakeup call
   */
  lc.shutdown(0,false);
  /* Set the brightness to a medium values */
  lc.setIntensity(0,8);
  /* and clear the display */
  lc.clearDisplay(0);
}

/*
 This function will light up every Led on the matrix.
 The led will blink along with the row-number.
 row number 4 (index==3) will blink 4 times etc.
 */
void single() {
  for(int row=0;row<8;row++) {
    for(int col=0;col<8;col++) {
      delay(delaytime);
      lc.setLed(0,row,col,true);
      delay(delaytime);
      for(int i=0;i<col;i++) {
        lc.setLed(0,row,col,false);
        delay(delaytime);
        lc.setLed(0,row,col,true);
        delay(delaytime);
      }
    }
  }
}

void loop() {
  single();
  lc.clearDisplay(0);

}

No update on the issue from the OP.
Closing as "invalid"


make buffer view optional with a flag

toward https://github.com/tinygrad/tinygrad/issues/5097

Can process replay run on this?

yeah, but process replay just takes asts and puts them into Linearizer. i tried it but ran into #5127

Yeah process replay is for codegen/*, though the infra can support lazy/schedule with some work to get master's ASTs for the comparison.
I ran process replay in CI right now and #5127 didn't come up - seems to be a non-deterministic Variable deduping failure.


Command History Implementation

It is needed to implement a command history, to perform this the GNU data structures (glib) can be used:
https://www.ibm.com/developerworks/linux/tutorials/l-glib/

This was solved long time ago...


Ground blending breaks farming guild tiles

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
When the Ground Blending option is enabled and you are located in the Farming Guild, the floor tiling produces an unexpected result.
To Reproduce
Steps to reproduce the behavior:

Go to the Farming Guild
Make sure Ground Blending is enabled in the plugin settings
See error

Expected behavior
The tiling to be maintained instead of blank white texture
Screenshots

Environment (please complete the following information):
OS: Windows 10
RuneLite version: 1.9.1
Launcher version: 2.1.0
Additional context
client.log

Thanks for reporting this, though this has been fixed already. If you restart RuneLite or update 117HD through the plugin hub panel, this should be back to how it used to be. Here is the commit that fixes it: https://github.com/117HD/RLHD/commit/720957fc92dd0232550a0b539915e7d09bb9e75f


[DOCFIX] Fix wrong file name in k8s doc

What changes are proposed in this pull request?
Fix wrong file name in docs, e.g. https://docs.alluxio.io/os/user/stable/en/deploy/Running-Alluxio-On-Kubernetes.html#posix-api. The file name in command should be alluxio-nginx-pod.yaml.template.

alluxio-bot, merge this please


enhanced documentation on adyen deployment on cloud infrastructure

Description

Moved k8s yaml files in to deployment-examples directory
Remove redundant stuff module specific documentation files.

Could not reason the changes for the contribution guide, I think we should not combine development guides, imo it was better before, maybe you add it because of lots of duplicate content, I think it is not an issue, it's not a code though

The intuition behind this, people who use this project are mainly developers. When they see, development guide, they tend to think it is how to configure. And we also have another read me for integration guide. To clear out what exactly meant by "DevelopmentGuide", I moved it out and renamed it to "ContributionGuide" which is more clear for new developers who look at the repository for the first time.


Fix Navbar design

fix first part of #102.

Hi @1t1e1 thanks for the pr!
tACK. Tested on mobile.


Navigation should be an action in navbar, Location

Right now, we just report every location change as an action, and no action for actually navigating.
We should make navigating an action, and optionally the incremental typing in the location bar may send info to the main process for frecency, etc.

Should also ensure it handles redirect scenarios so we can keep distinct records for both entered and actual URL in a Reacty way.

Along with this, many things access  directly, changing the nav; the {Page} should be the sole owner of  and purely reflect state changes

I guess GH markdown filters out <WebView>, which what I was referencing in https://github.com/mozilla/tofino/issues/119#issuecomment-210868899


Usage section of README

Usage section of README says:

run gulp for building / watcher
gulp test for test / watcher

I think it's explicitly implied that I have to run also npm install (which in my opinion should also be documented)
After doing following:
$ npm install
$ gulp

gulp fails with following output:
[14:42:39] Using gulpfile ~/dev/js/components/gulpfile.js
[14:42:39] Task 'default' is not in your gulpfile
[14:42:39] Please check the documentation for proper gulpfile formatting

gulp test fails with following:
$ gulp test
[14:56:16] Using gulpfile ~/dev/js/components/gulpfile.js
[14:56:16] Starting 'test'...
11 04 2017 14:56:16.849:ERROR [config]: File /Users/alibin/dev/js/components/build/tasks/../../karma.conf.js does not exist!

Either you run gulp build to build the components or to run the demo page with react npm run start or with preact npm run start:preact

Thank you @fragsalat but this doesn't help :(
Both npm run start and npm run start:preact show the error:
ERROR in ./~/css-loader!./~/sass-loader/lib/loader.js!./demo/index.scss
Module build failed:
      margin-top: $space-l;
                 ^
      Undefined variable: "$space-l".
      in /Users/alibin/dev/js/components/src/ws-header/ws-header.scss (line 230, column 19)
 @ ./demo/index.scss 4:14-117
 @ ./demo/demo_app.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./demo/demo_app.js
webpack: Failed to compile.

:man_shrugging:
FYI: my node version is v7.7.4 and npm 4.1.2

@qlibin Can you pls run npm i -D https://github.com/wholesale-design-system/scss.git
I guess the latest master of scss repo isn't installed.

There was one warning during the npm i -D https://git...:
npm WARN<EMAIL_ADDRESS>requires a peer of file-loader@* but none was installed.

But it helped! Thank you


[fix][doc] fix client-libraries table style

Motivation
The libraries table in the client libraries Overview documentation has the wrong format, so it does not render correctly on the site, this PR will fix it.

Modifications
Modify Markdown formatting to render correctly. site2/docs/client-libraries.md
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation

[x] doc

Hi, @Anonymitaet.
Sorry for the late reply. I lacked the time to explore how to build the site before, and now I've solved it. Here is the new effect:


Log in by cookie error

Hi all,
I posted the error here. Do you have any solution for this ?
http://www.yiiframework.com/forum/index.php/topic/60797-login-by-cookie-error-when-using-mongodb/page__gopid__270753#entry270753
Thanks,
Dong

The reason for this error is that $id is an array when it comes from the cookie. You can fix this by overriding the LoginByCookie function and by adding this line
$id = $id['$id']
before the $id gets used. But I don't know why this only happens when MongoDB is used.

You need to typecaset \MongoId object into a string at your Identity::getId().
There is already note about \MongoId specifics:
https://github.com/yiisoft/yii2-mongodb/blob/master/docs/guide/usage-mongoid.md

Hi guys.
@kakalos12, @coldice4 is right, the id value coming from the cookie is an array, not a single value! Something like this:
array(3) {
  [0]=>
  array(1) {
    ["$id"]=>
    string(24) "568823f5900293c818000029"
  }
  [1]=>
  string(32) "6aeL770pSq5J8m-Q5oTJQoGZVHya1iUe"
  [2]=>
  int(2592000)
}

From here to here you can see the root of the problem.
I am having a headhache with and had to add the following piece of code after line 292:
if (is_array($id)) {
    $id = $id[0];
}

"It works" but It seems I am not logged in:

@samdark, @klimov-paul any idea? Can you fix it? Thanks.

I've changed the actionLogin() on SiteController:
        ...
        if ($model->load(Yii::$app->request->post()) && $model->login()) {
            // return $this->goBack();
            return $this->render('login', [
                'model' => $model,**
            ]);
        } else {
        ...

I dunno why commentig $this->goBack() makes It "works":

But after clicking on Contact, for example, kaput session!

Please, I need help on this. I lost a lot of time trying to debug it.

@zorobabel shouldn't it be
if (is_array($id)) {
    $id = $id[0]['$id'];
}

@df2 no, it should be (correcting the above code I posted):
if (is_array($id)) {
    $id = $id['id'];
}

BTW, this is my environment:
Windows 8.1 64 bit
Apache 2.4.9 64 bit
MongoDB 3.2.0 64 bit
PHP 5.5.12 64 bit

Based on the array you posted this is not correct...

it should be

Well did you verify $id['id'] equals string(24) "568823f5900293c818000029" ??

@kidol, yes

@zorobabel please share the result of this:
if (is_array($id)) {
    var_dump($id);
    exit;
    //$id = $id['id'];
}

@kidol, I copied it above:
  array(1) {
    ["$id"]=>
    string(24) "568823f5900293c818000029"
  }

@zorobabel ok. Notice the dollar sign in the index. You need to use single quotes to get it:
if (is_array($id)) {
    $id = $id['$id'];
}

@df2, oh! thanks, I see it

@zorobabel you bet!

@df2 haha! :+1:

My "fix" does not work

Is the forum alive?
http://www.yiiframework.com/forum/index.php/topic/69154-yii2-advanced-template-login-with-yii2-mongodb-doesnt-work/

That forum branch isn't.

Ok, someone could move it to the right place?
I would like to see this issue in status resolved
Thx!

https://github.com/yiisoft/yii2/issues/6742#issuecomment-91513690 ?

But I did it =D

When cookie is created User component uses getId() method of the identity to fetch the value that would be put into the cookie: https://github.com/yiisoft/yii2/blob/master/framework/web/User.php#L541
Having non-string in a cookie is a clear sign that you didn't override getId() of the identity to return scalar value.

Ok, I know it but the login with MongoDB is not working, is it hard to understand?

Have you properly overridden getId() of the identity?
Without overriding getId() it's not expected to work. That's documented as @klimov-paul noted above when closing the issue.

Let me check it, I need to dust off my code, thanks

Made an improvement to docs: https://github.com/yiisoft/yii2-mongodb/commit/b1b718ad3d6bf1dae220c51f445bdfd2869fa2d0

@samdark Excellent!


semantic map based tracking

use prediction trajectory to help semantic map tracking
currently experimental mode

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.weidezhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@weidezhang seems like CLA check failed.

@weidezhang seems like CLA check failed.


Add Sub Circle members to Slack

I guess there are two decisions to make:

Do we pay for the Pro level account?
How many sub-circle members will we add to Slack.

Once that is decided, it will be a simple task to invite the right people to come to the workspace.

This is still a pending conversation. The emerging direction is likely to pay for a Pro Slack account, reduce the active users to the current circle and admin team and IOG people, and move everyone else to "guest" access to certain channels so we keep control of the costs. I have it on my to do list to discuss with Joey and other Circle members.

Hi Nori,
I don't wish to put anyone under any financial stress. At this point I will
be sharing my Telegram and Discord accounts and SubCircle emails so that
all the Circle v3 can connect with the SubCircle folks I have put in place
to represent the entire Circle in Town Halls and Social Media Groups.
If the SubCircle outreach idea is to continue beyond this CCv3 then maybe
the cost should be included in future proposals.
Hope this helps everyone.
Regards,
Joey
On Mon, Apr 4, 2022 at 3:30 PM Nori Nishigaya @.***>
wrote:

@ChessherJoey https://github.com/ChessherJoey was asking if we could
upgrade our Slack account to Pro as it has aliases and other features to
make the experience smoother and better. The pricing to go from the free
tier to the Pro tier is $6.67 per person per month. As shown here:
https://app.slack.com/plans/T02MA0UQ4RE
If we open Slack up to sub-circles and other community members, this cost
will rise pretty quickly so we need some agreement as to where the funds
will come from as they are not currently in any of the budgets. We could
use the F7 Rapid funding each circle member has as a short-term solution.
Dividing the cost amongst the Circle would be a small portion of each
person's treasury. There are currently ~30 active accounts on Slack. 30 *
6.67 * 12 months = $2401.20 total, which could be spread out amongst you
all for $480.24 per person from your rapid funding funds. This amount would
go up a few dollars for each person we add from sub-circles. There are also
a few inactive accounts we should clean up (there are 3 or 4 people no
longer active) that will save a bit, but these are the ballpark numbers.
—
Reply to this email directly, view it on GitHub
https://github.com/Catalyst-Circle/Catalyst-Circle-Admin-Coordination/issues/94#issuecomment-1087932827,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AX3HIQHOSMFIN6AWVFKVO4DVDM7O3ANCNFSM5SQF7LHA
.
You are receiving this because you were mentioned.Message ID:
<Catalyst-Circle/Catalyst-Circle-Admin-Coordination/issues/94/1087932827@
github.com>


Add ThumbprintString property to mgmt

Resolves https://github.com/Azure/azure-sdk-for-net/issues/33804
Add ThumbprintString to return the hexadecimal string representation of the SHA-1 hash of the certificate, Thumbprint is hidden but still available.
The affected RPs are:

websites
automation
batch
iothub
notificationhubs

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.NotificationHubs


Default start page

Dear @volkanceylan,
I would like to know which is the proper way to change the default start page...
I'm trying to set "Northwind/Order?shippingState=0" as default page, but without any luck...
I was playing with the route attribute:
...Route("~/")...
in the DashboardPage.cs, but clearly I'm doing something wrong because when I open the application the default page is still the Dashboard (and also when I click on the Serenity logo).
Thanks (as always) for your support
Best Regards

You should put Route("~/") on OrderPage Index action and remove one in DashboardPage Index action.

This is exactly what I have done, but still I'm not able to add url parameter (shippingState for example).
Any idea?

So use Route("~/{shippingState=}")

You shouldnt add shippingState default to url. It should be a nullable parameter that defaults to 0

Uhm only with a single route is working fine, but my custom navigation link has stopped working...
In fact, in the left navigation menu I have added a couple of navigation link with a custom url:
[assembly: NavigationLink(1100, "Inbox", url: "~/CSH/Ticket?isInbox=1", permission: "Inbox", icon: "icon-envelope-letter")]
[assembly: NavigationLink(1200, "My Tickets", url: "~/CSH/Ticket?isCurrentUser=1", permission: "MyTickets", icon: "icon-user")]

And to make it works I had to add two route directive:
namespace eService.CSH.Pages
{
	using Serenity;
	using Serenity.Web;
	using System.Web.Mvc;

	[RoutePrefix("CSH/Ticket"), Route("{action=index}")]
	public class TicketController : Controller
	{
		[Route("~/")]
		[Route("~/CSH/Ticket")]
		[PageAuthorize(CSH.PermissionKeys.Ticket.View)]
		public ActionResult Index()
		{
			return View("~/Modules/CSH/Ticket/TicketIndex.cshtml");
		}
	}
}

But what I'm still trying to achieve is that the default page is the "Inbox" one or, in other words, that the default url is the same of the "Inbox" navigation link.
If this is not possibile I'll take the nullable parameter way as per your suggestion...
Thanks again
Best Regards

This should go into logic of your inbox page not url. When user types "/" he expects to get default page. Anyway if you insist, change links directing to "~/" everywhere to "~/?x=inbox etc, e.g. in layout.

Copy that!
Thanks for your support
Best Regards


about tx2

convert onnx to trt8， The following error occurred:
Beginning ONNX file parsing [11/19/2022-14:21:40] [TRT] [W] onnx2trt_utils.cpp:366: Your ONNX model has been generated with INT64 weights, while TensorRT does not natively support INT64. Attempting to cast down to INT32. Completed parsing of ONNX file Building an engine from file onnx/laneatt_r18_llamas.onnx; this may take a while... python3: /root/gpgpu/MachineLearning/myelin/src/compiler/./ir/operand.h:166: myelin::ir::tensor_t*& myelin::ir::operand_t::tensor(): Assertion is_tensor()' failed.
Aborted (core dumped)
`
The following error occurred？thanks

cuda-10.2      trt-8.2


How to test Lookup function Scenario with helm unittest

I've stumbled upon this closed issue - 108 asked in year 2020 which refer to use older code base. Did we introduced the same functionality in this repo?  If so, can someone point me towards related documentation.

Interested in this too :)

Hello @atulsingh0, @wilmardo,
Please look at this comment, it relates a lot to your situation.
Unless you are trying to lookup data which is not part of the helm chart, then a mock suggested as result, could solve the situation.
Greetings,
@quintush


[BEAM-3773][SQL] Add EnumerableConverter for JDBC support

This adds a converter from BeamRelNode to EnumerableRel. The calcite JDBC engine can execute any plan with a root node of the EnumerableRel type.

Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[X] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.

[X] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @kennknowles
cc: @akedin

run java precommit

run java precommit

run java precommit

run java precommit

run java precommit

run java precommit

run java precommit

Fixed the issues from the comments and added tests at the toEnumerable layer. There are still some missing pieces for a functional calcite JDBC test, so that will have to come once those features are added.


Add Yourwass take on the challenge

Uses vector api for city name parsing and for hash index collision resolution
Uses lookup tables for temperature parsing

Check List:

[x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[x] Output matches that of calculate_average_baseline.sh
[x] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number) 226

Execution time: 1.4s
Execution time of reference implementation: 2m16s
Execution times measured on a Ryzen-7 5800X, with 6 cores/12 threads, 16GB RAM and NVMe disk.

Could you rebase this to latest main please? Thx!

00:02.984, nice! Also doing well on the 10K keyset test.
Benchmark 1: timeout -v 300 ./calculate_average_yourwass.sh 2>&1
  Time (mean ± σ):      2.986 s ±  0.024 s    [User: 19.875 s, System: 0.733 s]
  Range (min … max):    2.952 s …  3.029 s    10 runs

Summary
  yourwass: trimmed mean 2.9842469369199995, raw times 3.0060280159199997,2.99326810492,2.97294792792,2.9856206899199997,2.98136352292,2.95228724092,3.0289457929199997,3.0053064569199996,2.95376781292,2.9756729639199997

Leaderboard

| # | Result (m:s.ms) | Implementation     | JDK | Submitter     | Notes     |
|---|-----------------|--------------------|-----|---------------|-----------|
|   | 00:02.984 | [link](https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_yourwass.java)| 21.0.1-open | [yourwass](https://github.com/yourwass) | uses Unsafe |


change(test): cleanup the getblocktemplate test

Motivation
This is a follow-up to https://github.com/ZcashFoundation/zebra/pull/6091 that corrects/explains constants and removes excess logs.
Solution

Removes excessive logs or moves them to failure cases.
Adds better explanations to timing constants
Updates BLOCK_PROPOSAL_INTERVAL to 1 second

Review
Anyone can review.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

It takes a little longer with the extra iterations but isn't currently a bottleneck for CI:


Fixed clean up old compact chunks when compact starts

Signed-off-by: jojohappy<EMAIL_ADDRESS>
Changes

fixes: #470
Related discussion: comment
Clean up the temporary directory before compactor beginning.
Verification

We can actually do it as soon as we go into the compact method as we do not care at all about the existing blocks when we run a compaction loop.

I would also add clearing up of the downsample dir in this pr somewhere as this would have pulled down all the compacted blocks. It will clean it up when it starts a downsample run but if the machine is already done that it may not succeed in doing the original compaction.

@domgreen Do you mean we should clean up the temporary directory before every compaction loop?
I have check the code that the downsample temporary dir will be cleaned at the beginning of processing downsampling.

@domgreen Thank your for your detail explain. I have changed my code to clean up the temporary directory at the beginning of every compaction loop.

@domgreen I have rollbacked the code and clean up the downsampling temporary directory before processing compaction. Does it make sense?

Yes, I have tested that it will remove the temporary dir itself. (:

it breaks backward compatibility:
compact command failed: clean working temporary directory: remove /var/thanos/data: device or resource busy

I use data-dir the same as the mount path of volume in k8s, hence dir couldn't be deleted.
The workaround is to set data-dir as nested dir. I.e. in my case this's: /var/thanos/data/compact

Urgh, missed that case :( let me add a ticket and we can get someone to fix asap.


MVKQueue: Make sure waitIdle waits for all commands to be encoded before enqueuing its own waitUntilCompleted.

That seems to be causing mysterious crashes with asynchronous queue submissions. I've been debugging one where it'd crash the encoding thread because we destroyed the swap chain right after calling vkQueueWaitIdle, and it wasn't done encoding the Present.
For what it's worth in my case the bug bisected to f0cb31a12b59f05177f07ab5a46bc9084ba5fbc9.
Ping #2295, possibly others..

#2031 looks possibly related.


Always persist a high watermark for source table

Current high watermark links to the partition locator. During incremental compaction, we expect two source of data as input. One is the compacted table, the other is the new delta. In rare cases, where no new delta exist. Only compacted table will go through the delta discovery and entire compaction. In the end, the high watermark recorded in round completion file is only from the compacted table.
In next round, when we retrieve the high watermark from round completion file, we are not able to get the high watermark of the source table, in some cases, we call it old_parent_stream_position.
Two options:

get the high watermark from delta property when rcf doesn't have it
persist the high watermark for source table in rcf

Since there's nothing to update aside from metadata in the case of no new deltas, are we also ensuring that we're not running through all data processing steps of hash bucketing, dedupe, and materialize?

Currently, it'll still go through the steps. We don't have a direct copy route yet. It seems to be a corner case.


VSCode very laggy and dependent on window size

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T17:16:27.618Z)
OS Version: Linux x64 3.10.0-514.6.1.el7.x86_64
Extensions:

Extension
Author (truncated)
Version

bracket-pair-colorizer
Coe
0.10.9

vscode-eclipse-keybindings
alp
0.9.6

Doxygen
bbe
1.0.0

cpptools
ms-
0.12.4

funclist
qrt
7.0.0

(1 theme extensions excluded)

Steps to Reproduce:

Open any file, maximise window to fill desktop.
Feel keyboard lag and slowly increase frustration levels ;)

Reproduces without extensions: Yes
Basically, if I have the vscode window open in full screen the gui response lag for vscode is really quite bad. If I make the window smaller the lag time is reduced, and if the window is postage stamp sized the lag is useable.
Please ask for any specific info you may need to help resolve this issue.

This might be a dup of #9432

I have just upgraded to 1.16.1 to see if the issue was resolved, but it still seems to be evident. Using a smaller window still reduces the UI lag.
For reference my desktop resolution is 3834x2052 pixels

@ewantowie any change with 1.17 release?

It has improved, although there is still a lag difference between maximised and small window sizes.
I don't know if it is connected, but I have also discovered that I cannot get another window to show in front of VSCode. I have to minimise VSCode in order to use any other window, very odd!

@ewantowie that is weird indeed, can you file a separate issue.

@bpasero I have created a separate issue #36218 for the window maximise problem.

I've tried the suggestions above, but I experience lag, too. Running Code with Optirun doesn't help much, either. I'm scaling with xrandr (2x2) because my laptop is 4k and my external monitors are not. My current environment:

Arch Linux 4.13.9-1-ARCH
Dell Precision 5520
8 Cores, 32GB RAM (neither seems particularly taxed while running code)

We are building exploration builds that use a much newer version of our UI framework (Electron version 6.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux (DEB): Download
Linux (RPM): Download
Windows: Download

Could you prepare a tarball for Linux as well?

Yes: https://az764295.vo.msecnd.net/exploration/a715df3459718a501686bd03414f69929bf6e9a2/code-exploration-1568356741.tar.gz

Thanks! I tried the tarball on my workstation but unfortunately I can't run the binary as it dumps the following error:
./VSCode-linux-x64-exploration/code-exploration
[185008:1011/095219.694227:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /remote/gb12tcad3/ewan-nis/Apps/VSCode-linux-x64-exploration/chrome-sandbox is owned by root and has mode 4755.
Trace/breakpoint trap
I am not comfortable in making executables root owned for what is a local installation. Can you implement a work around so I can test this for you?

@ewantowie you can run with "--no-sandbox"

Ok, doing a very simple test (scrolling a long text file) I can see no real difference in performance between this version and 1.38.1 with a maximised window on a 4K dekstop. I am running these on a CentOS 7.3 box.
Certainly, the full screen performance in 1.38.1 is much better than in 1.15.1 for scrolling a text file.
Is there any particular test or metric you would like to see?

@bpasero
I can certainly repeat the issue in Electron, but I cannot get the web based client to show anything. The newest version of Chromium I have available is 14.0, so could this be the issue?

@ewantowie you should see a browser open and show something like this:

Do you get a browser tab to open? If the page is empty, do you see anything in the developer console?

I get a browser tab with an empty page, and the developer console has a lsit of syntax errors.

Strange, is that Chrome browser latest? I think your browser does not support running VSCode web.

Apologies, didn't get a notification that you had responded here. The version of Chrome is probably quite old, we predominantly use Firefox on our linux boxes.
I mentioned above that we are running Chromium 14.0.785.0 (Developer Build 87778 Linux).

@bpasero The bot has closed this issue, not sure it really wants to :)

This is probably the same cause as https://bugs.chromium.org/p/chromium/issues/detail?id=1016329

If it's any help, we don't run any GPUs on the machine I use as they are all VMs running off a single node. I believe all the graphics for Xorg is software based.

This is not actionable from our end, closing.