HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

backport HBASE-25439 to branch-2

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
branch-2 passed

+1 :green_heart:
checkstyle
1m 12s
branch-2 passed

+1 :green_heart:
spotbugs
1m 53s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 14s
the patch passed

-0 :warning:
checkstyle
0m 26s
hbase-common: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

-0 :warning:
rubocop
0m  9s
The patch generated 5 new + 354 unchanged - 5 fixed = 359 total (was 359)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 42s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

35m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux c3aaee376b08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
branch-2 passed

+1 :green_heart:
checkstyle
1m 12s
branch-2 passed

+1 :green_heart:
spotbugs
1m 53s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 14s
the patch passed

-0 :warning:
checkstyle
0m 26s
hbase-common: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

-0 :warning:
rubocop
0m  9s
The patch generated 5 new + 354 unchanged - 5 fixed = 359 total (was 359)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 42s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

35m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux c3aaee376b08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 56s
branch-2 passed

+1 :green_heart:
compile
1m 24s
branch-2 passed

+1 :green_heart:
shadedjars
7m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 53s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 25s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 52s
hbase-shell in the patch passed.

42m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 36c427d16d9c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/testReport/

Max. process+thread count
2668 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 56s
branch-2 passed

+1 :green_heart:
compile
1m 24s
branch-2 passed

+1 :green_heart:
shadedjars
7m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 53s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 25s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 52s
hbase-shell in the patch passed.

42m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 36c427d16d9c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/testReport/

Max. process+thread count
2668 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 52s
branch-2 passed

+1 :green_heart:
compile
1m 14s
branch-2 passed

+1 :green_heart:
shadedjars
7m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
7m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 40s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 26s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m  7s
hbase-shell in the patch passed.

42m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 86c2c3cde1cf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/testReport/

Max. process+thread count
2392 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 52s
branch-2 passed

+1 :green_heart:
compile
1m 14s
branch-2 passed

+1 :green_heart:
shadedjars
7m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
7m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 40s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 26s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m  7s
hbase-shell in the patch passed.

42m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 86c2c3cde1cf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/testReport/

Max. process+thread count
2392 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s
branch-2 passed

+1 :green_heart:
compile
1m 24s
branch-2 passed

+1 :green_heart:
shadedjars
6m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 10s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
6m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 27s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 51s
hbase-shell in the patch passed.

41m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux<PHONE_NUMBER>de 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/testReport/

Max. process+thread count
2408 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s
branch-2 passed

+1 :green_heart:
compile
1m 24s
branch-2 passed

+1 :green_heart:
shadedjars
6m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 10s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
6m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 27s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 51s
hbase-shell in the patch passed.

41m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux<PHONE_NUMBER>de 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/testReport/

Max. process+thread count
2408 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
branch-2 passed

+1 :green_heart:
checkstyle
1m 19s
branch-2 passed

+1 :green_heart:
spotbugs
2m  6s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

-0 :warning:
checkstyle
0m 27s
hbase-common: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

-0 :warning:
rubocop
0m 11s
The patch generated 5 new + 354 unchanged - 5 fixed = 359 total (was 359)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

41m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux 008e08da20ff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
branch-2 passed

+1 :green_heart:
checkstyle
1m 19s
branch-2 passed

+1 :green_heart:
spotbugs
2m  6s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

-0 :warning:
checkstyle
0m 27s
hbase-common: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

-0 :warning:
rubocop
0m 11s
The patch generated 5 new + 354 unchanged - 5 fixed = 359 total (was 359)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

41m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop

uname
Linux 008e08da20ff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
branch-2 passed

+1 :green_heart:
compile
1m 11s
branch-2 passed

+1 :green_heart:
shadedjars
6m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 45s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 33s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 16s
hbase-shell in the patch passed.

47m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d1aedb3e03de 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/testReport/

Max. process+thread count
1615 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
branch-2 passed

+1 :green_heart:
compile
1m 11s
branch-2 passed

+1 :green_heart:
shadedjars
6m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 45s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 33s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 16s
hbase-shell in the patch passed.

47m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2840

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d1aedb3e03de 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e517bf7058

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/testReport/

Max. process+thread count
1615 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Create bridge with string name start with number fail

Issue

create bridge with name start with number as shown ,fail with weird error message

The name now accepts values starting with one. Validation was added to make sure it is not longer than 15 characters and is not equal to "default".

Software Version
5e2a9594e0843cea4cbcbe1355e48f42bf5db0a7


Plugin for Perceptual Diffing

It would be cool if drone.io had perceptual diffing support. Perceptual diffing is the act of diffing two rendered user interfaces to check if there are any differences that shouldn't be there. Here are some resources:

http://mattjibson.com/blog/2013/06/11/perceptual-diffs-at-stack-overflow/
https://github.com/bslatkin/dpxdt

I'm going to close this in favor of pushing this behavior to a plugin and external system, similar to what we've done with coverage. This should be much easier now that Drone supports a rich plugin model.


Is it possible to add official pre-built files in repo?

So that we can apply the auto-update mechanism on cdnjs.com, we now have this lib on https://cdnjs.com/libraries/angular-ui-calendar, but without official pre-built files, we can not automatically add the new versions, thanks. cc https://github.com/cdnjs/cdnjs/issues/7559

Interesting. Any reference docs indicating what works for you?

@martin-langhoff not sure if I got your point, a dist folder including all the files for distribution will be great. Thanks.

Cool, just checking whether there was anything else you'd need.

Thanks @martin-langhoff

@martin-langhoff want me to take a look at this ?


Wrapping not available

Overview
Python wrapping is not built with the project and is not available as a CMake parameter.
Details
I am seeking to wrap Mesh3DProcrustesAlignFilter class for Python. The external module contains a CMakeLists.txt and .wrap file in the wrapping folder, but no Wrapping folder with Python binaries is built in the ITK-build directory. When setting configuration variables in CMake-GUI there is no WRAP_PYTHON parameter available, and attempting to explicitly set this variable with the CMake CLI has no noticeable impact on the build.
Expected behavior

Mesh3DProcrustesAlignFilter_WRAP_PYTHON (or a similar parameter) is available for configuration with CMake
Python wrapping is built in ITK-Build/Wrapping

Observed behavior
No wrapping is built

@thewtex Per our earlier discussion this was a local environment issue rather than a build issue. After rebuilding ITK with Python wrapping enabled the CMake wrapping parameter for the external module is available.


TODO LIST: subclasses with missing features for next DLC

College of Wardancer 14
Path of the Spirits 14
Acrobat 17
Opportunist 17
Sorr-Akkath 18

Question: Are you looking for assistance with the coding?  Or with the coming up with ideas?

Above is to ensure I don’t forget about them before the DLC.
I still plan to write 3 more subclasses as well: Artillerist, one more path and one more circle.
We can certainly use help on leveling up each mod sub all the way to 20, ensure everything works as described as well as improve the translation terms.
Anyone could help with that and would allow the mod to be even better.

Well, I’m not going to be much help with the coding, but I’ll help wherever else I can


Admin prize worklist

When a user picks a prize, their info (email) and the prize they selected are added to a worklist that the admins can reference. Once an admin has sent out the prize, they should be able to remove the record from the worklist.
Needs to coordinate with #25, maybe be done in same PR.

It's either this or #188 so if we get that done then we can close this w/out fixing.


Lost connection to the socket server. Reconnecting...

⚠ Please verify that this bug has NOT been reported before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
After logging out from the Dockge UI in my browser, I typically move on to another site in that same tab. When I do, I get thus nuisance pop-up:

Since I've logged out this is of no concern.
Notable, if I close the Dockge browser tab after logging out, there is no notification.
👟 Reproduction steps

Open Dockge login UI in browser tab.
Log out from Dockge
Enter new destination URL in the same browser tab (now showing the Dockge login screen)
Pop-up notification appears

👀 Expected behavior

Open Dockge login UI in browser tab.
Log out from Dockge
Enter new destination URL in the same browser tab (now showing the Dockge login screen)
No pop-up notification appears. Browser quietly loads new site.

😓 Actual Behavior

Open Dockge login UI in browser tab.
Log out from Dockge
Enter new destination URL in the same browser tab (now showing the Dockge login screen)
Pop-up notification appears

Dockge Version
1.4.2
💻 Operating System and Arch
Win10 x64
🌐 Browser
LibreWolf 124.0.1-1
🐋 Docker Version
Docker 26.0.0
🟩 NodeJS Version
No response
📝 Relevant log output
No response

Same here,
Here's log from console
2024-04-11T11:27:03Z [SERVER] INFO: Socket connected (direct)
2024-04-11T11:27:03Z [AUTH] INFO: Login by token. IP=<IP_ADDRESS>
2024-04-11T11:27:03Z [AUTH] INFO: Username from JWT: kdpuvvadi
2024-04-11T11:27:03Z [AUTH] INFO: Successfully logged in user kdpuvvadi. IP=<IP_ADDRESS>
2024-04-11T11:27:03Z [AGENT-MANAGER] INFO: Connecting to all instance socket server(s)...
2024-04-11T11:27:03Z [AGENT-MANAGER] INFO: Connecting to the socket server: <IP_ADDRESS>:5001
2024-04-11T11:27:03Z [AGENT-MANAGER] INFO: Connected to the socket server: <IP_ADDRESS>:5001
2024-04-11T11:27:03Z [AGENT-MANAGER] INFO: Logged in to the socket server: <IP_ADDRESS>:5001
2024-04-11T11:27:05Z [SERVER] INFO: Socket disconnected!
2024-04-11T11:27:05Z [AGENT-MANAGER] INFO: Disconnected from the socket server: <IP_ADDRESS>:5001
2024-04-11T11:27:06Z [SERVER] INFO: Socket disconnected!
2024-04-11T11:27:06Z [AGENT-MANAGER] INFO: Disconnected from the socket server: <IP_ADDRESS>:5001
2024-04-11T11:27:07Z [AUTH] INFO: Origin is not set, IP: ::ffff:<IP_ADDRESS>

Here's message from dom
{
    "ok": true,
    "agentList": {
        "": {
            "url": "",
            "username": "",
            "endpoint": ""
        },
        "<IP_ADDRESS>:5001": {
            "url": "http://<IP_ADDRESS>:5001/",
            "username": "kdpuvvadi",
            "endpoint": "<IP_ADDRESS>:5001"
        }
    }
}

Deleted everything in the data directory including data/db-config.json and sqlite db file.
It worked for 2 minutes and then same error.
my compose looks like this
---

services:
  dockge:
    container_name: dockge
    image: louislam/dockge:1
    restart: unless-stopped
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - /home/kd/compose/dockge/data:/app/data
      - /home/kd/compose:/home/kd/compose
    environment:
      - DOCKGE_STACKS_DIR=/home/kd/compose
    networks:
      - proxy
    labels:
      - "traefik.enable=true"
      - "traefik.docker.network=proxy"
      - "traefik.http.routers.dockge.entrypoints=https"
      - "traefik.http.routers.dockge.rule=Host(`dockge.local.puvvadi.net`)"
      - "traefik.http.routers.dockge.middlewares=default-headers@file, https-redirectscheme@file"
      - "traefik.http.routers.dockge.tls=true"
      - "traefik.http.routers.dockge.service=dockge"
      - "traefik.http.services.dockge.loadbalancer.server.scheme=http"
      - "traefik.http.services.dockge.loadbalancer.server.port=5001"

networks:
  proxy:
    external: true

I also use traefik and I ran into a similar problem. When I access the dockge page via the reverse proxy, the page constantly reloads and shows the same error. When I don't go through the revers proxy everything works fine.  The funny thing is that I had all of this running without issues before. But after I reinstalled my system it somehow broke. I copy pasted everything from the old install, so there is no reason why it suddenly shouldn't work anymore.

I ran into this as well.  It looks like this is related to traefik 2.11.1, and has possibly been fixed in 2.11.2.  For now I've reverted to traefik 2.11.0 and it seems to solve the issue (the official docker image for 2.11.2 is not available yet)
https://github.com/traefik/traefik/issues/10598

Thanks for the tip, upgrading traefik solved the problem as well !

Unfortunately all above posts relating to Traefik are off topic to the OP. I am not using Traefik, and no solution has yet been proposed.

Same here. I am not using a reverse proxy and Dockge keeps displaying that error message to a point it has become unusable. I cannot edit a single line in a docker-compose.yml and save it, because of the recurring connection error.

Same here. I am not using a reverse proxy and Dockge keeps displaying that error message to a point it has become unusable. I cannot edit a single line in a docker-compose.yml and save it, because of the recurring connection error.

ok I have rebooted everything. Works perfectly right now, so sorry for bothering you... 🤷🏼♂

same here, no traefic used...
cannot install any container :(

all my dockge dockers in my proxmox LXC container now give me error msg below.
dockge has not been updated since january. it just doesnt make sense it suddenly stop working.
'Connecting to the socket server…'
then
Lost connection to the socket server. Reconnecting...
Using a Reverse Proxy? Check how to config it for WebSocket


Does this support logging to an HTTP endpoint on my server?

Is this just a local logging client?

@light24bulbs
Hey, thanks for the suggestion. I will look into making this configurable and come back to you.
Regards,
Justin

@light24bulbs
I've looked into it and for now this is not a priority, so I'm closing the issue. You can always submit a pull request with this functionality.


Add limitation of table name on PostgreSQL

PostgreSQL throws error when table name is over 63chars.
Add a option that cut long table names.

The problem is somewhere else than knex if you are running to an issue like this. Converting invalid table names to valid  table names for certain dialect should not be knex's responsability to fix. Just use shorter table names?
If there is a really good use case supporting this, I might change my opinion though.

The reason is compatibility.
Some application work on Sqlite but not on PostgreSQL.I acknowledge that this is not knex's responsibility,but I thought it will be a good util for transition.


[stdlib] @available attributes for intervals

Explanation: IntervalType protocol as well as HalfOpenInterval and ClosedInterval types have been removed from the standard library in favor of ranges. However no guidance is provided for the existing code that uses those removed types. This patch provides the necessary @available attributes.
Scope of Issue: Purely additive.
Origination: Omission during the new collections indexing model implementation.
Risk: None
Reviewed By: Dmitri Gribenko
Testing: tested in REPL
Directions for QA: N/A

@swift-ci Please test

LGTM.


Can't edit job name

Hi,
I can't edit job name. Is it known issue?

Duplicate issue, closing this


Wait for weaviate

Closes https://github.com/weaviate/weaviate-go-client/issues/112.
Implements the WaitForWeaviate function which automatically waits for weaviate to start before initializing the client.
Due to the existing architecture of the client, there are two places where a first connection to weaviate happens:

When creating the config with authentication: Here the weaviate OIDC config is queried before the client is created.
After creating the client, before a user makes the first connection.

Due to this I added the WaitForWeaviate in two places:

In a new function AddAuthClient, that creates the correct http-client
In a member function of the client, eg client.WaitForWeavaite(time) that users can call after creating the client

I agree with the CLA.

I also fixed that WaitForWeavaite always waited a second even if a connection could be established right away.


IC-1926 Singularise names of action plan session appointments table and column

What does this pull request do?
Made table name action_plan_session_appointments and column name singular in line with all the other tables.
What is the intent behind these changes?
Technical debt

Nice one!
I think there may be one more place that needs a change:
V99_2_2__assigned_referrals has an insert statement referring to the old name

Needs rebase to kick off ci/circleci: validate_db introduced in #341


umo.edu addition

added umo.edu to domain list

@stephenbs First stage of verification passed, official domain for University of Mount Olive is umo.edu as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@stephenbs Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Add BeforeUnload event support

Add beforeunload event for addEventListener
https://developer.mozilla.org/en-US/docs/Web/Events/beforeunload

Could you link to the spec that backs up this chagne?

Added link to mdn

Feel free to reopen if you would still like to get this in. For now I'm closing since I have not yet seen a response.


Add helper for boolean attributes

One that takes a boolean and returns the attribute, or nil.

Fixed in #57.


metrics-windows-network.rb bug

Believe me now, hear me later ... yah ...
Line 60 of sensu-plugins-windows/bin/metrics-windows-network.rb should read ...
name = [config[:scheme], ifz_name, metric].join('.').gsub(' ', '_').tr('{}', '').tr('[]','')
... adding the additional .tr at the end.
This is because if an Intel Network Adapter stupidly has a [R] trademark in the name/description it will break the metric showing up in Graphite/Grafana.
Enjoy.

Wow, that's nutty. Can you open a pull request with the fix and we'll get that updated.

Sure, also to add, that [R] can sometimes be seen as a (R).  More specifically that can be the actual issue but removing the [] fixes it.

Fixed in 0.0.7. Thanks again for the report and the fix.


Bug: Keysight N5249A PNA-X network analyzer trace error

Regardless of which qcodes release(tried with 4 different qcodes version)  I use whenever I  want to have trace data of network analyzer, N5249A, I get could not convert string to float: 'S21' error. My code is simple. I first set the required parameter for the network analyzer and then try to get trace data: data=qc.Measure(vna.trace).run(name='test')
my code is:
vna.sweep_mode('CONT')
vna.start(150.1e6)
vna.stop(350.1e6)
vna.power(-23)
vna.points(1601)# 1601
vna.if_bandwidth(1000)
vna.trace("S21")
data=qc.Measure(vna.trace).run(name='test')

and it returns this error:
ValueError                                Traceback (most recent call last)
<ipython-input-8-48831a7c8d52> in <module>
----> 1 data=qc.Measure(vna.trace).run(name='test')
      2
      3 # plot
      4 #plot = MatPlot(data.vna_magnitude, data.vna_phase)
      5 #plot.save()

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\measure.py in run(self, use_threads, quiet, station, **kwargs)
     83
     84         # run the measurement as if it were a Loop
---> 85         self._dummyLoop.run(use_threads=use_threads,
     86                             station=station, quiet=True)
     87

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\loops.py in run(self, use_threads, quiet, station, progress_interval, set_active, *args, **kwargs)
    745             if not quiet:
    746                 print(datetime.now().strftime('Started at %Y-%m-%d %H:%M:%S'))
--> 747             self._run_wrapper()
    748             ds = self.data_set
    749         finally:

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\loops.py in _run_wrapper(self, *args, **kwargs)
    794     def _run_wrapper(self, *args, **kwargs):
    795         try:
--> 796             self._run_loop(*args, **kwargs)
    797         finally:
    798             if hasattr(self, 'data_set'):

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\loops.py in _run_loop(self, first_delay, action_indices, loop_indices, current_values, **ignore_kwargs)
    882                     # log.debug('Going through callables at this sweep step.'
    883                     #           ' Calling {}'.format(f))
--> 884                     f(first_delay=delay,
    885                       loop_indices=new_indices,
    886                       current_values=new_values)

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\actions.py in __call__(self, loop_indices, **ignore_kwargs)
    165                 out_dict[param_id] = param_out
    166
--> 167         self.store(loop_indices, out_dict)
    168
    169

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\data\data_set.py in store(self, loop_indices, ids_values)
    404          """
    405         for array_id, value in ids_values.items():
--> 406             self.arrays[array_id][loop_indices] = value
    407         self.last_store = time.time()
    408         if (self.write_period is not None and

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\data\data_array.py in __setitem__(self, loop_indices, value)
    339         self._update_modified_range(min_li, max_li)
    340
--> 341         self.ndarray.__setitem__(loop_indices, value)
    342
    343     def __getitem__(self, loop_indices):

ValueError: could not convert string to float: 'S21'

I'm not very much familiar with that driver/instrument but i think vna.trace is just the particular S-parameter that you are interested in. The actual data is available in .magnitude and .phase parameters, see the example notebook here https://qcodes.github.io/Qcodes/examples/driver_examples/Qcodes example with Keysight Network Analyzer.html.

I'm not very much familiar with that driver/instrument but i think vna.trace is just the particular S-parameter that you are interested in. The actual data is available in .magnitude and .phase parameters, see the example notebook here https://qcodes.github.io/Qcodes/examples/driver_examples/Qcodes example with Keysight Network Analyzer.html.

thank you for your comment. Actually, in that way, I could get data but since I am sweeping voltage from some other instruments, I have 2D loop, to be able to make all my instrument work at the same time I need VNA to work via qcodes.Measure function

to be able to make all my instrument work at the same time I need VNA to work via qcodes.Measure function

i'm not sure i understand why. I wanted to suggest that instead of data=qc.Measure(vna.trace).run(name='test') one needs to use data=qc.Measure(vna.magnitude).run(name='test') because vna.magnitude parameter acquires the data while vna.trace parameter jsut allows you to select which S parameter you're interested in.

anyway, did this issue get resolved? if so, please close it :)

I agree with using  vna.magnitude. However, this time I get unhashable type: 'numpy.ndarray' error.
data=qc.Measure(vna.magnitude).run()
ypeError                                 Traceback (most recent call last)
<ipython-input-35-4a14ea72942f> in <module>
----> 1 data=qc.Measure(vna.magnitude).run()
      2

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\measure.py in run(self, use_threads, quiet, station, **kwargs)
     75         """
     76
---> 77         data_set = self._dummyLoop.get_data_set(**kwargs)
     78
     79         # set the DataSet to local for now so we don't save it, since

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\loops.py in get_data_set(self, *args, **kwargs)
    656         """
    657         if self.data_set is None:
--> 658             data_set = new_data(arrays=self.containers(), *args, **kwargs)
    659             self.data_set = data_set
    660

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\loops.py in containers(self)
    466                 # note that this supports lists (separate output arrays)
    467                 # and arrays (nested in one/each output array) of return values
--> 468                 action_arrays = self._parameter_arrays(action)
    469
    470             else:

~\anaconda3\envs\qcodes10\lib\site-packages\qcodes\loops.py in _parameter_arrays(self, action)
    548             for j, (vij, nij, lij, uij) in enumerate(zip(sp_vi, sp_ni, sp_li, sp_ui)):
    549                 sp_def = (shape[: 1 + j], j, setpoints, vij, nij, lij, uij)
--> 550                 if sp_def not in all_setpoints:
    551                     all_setpoints[sp_def] = self._make_setpoint_array(*sp_def)
    552                     out.append(all_setpoints[sp_def])

TypeError: unhashable type: 'numpy.ndarray'

@bugusan a side question - do you absoltely need to use qcodes.Measure? Couldn't you use qcodes.data_set.measurements.Measurement context manager as described in this doc https://qcodes.github.io/Qcodes/examples/DataSet/Performing-measurements-using-qcodes-parameters-and-dataset.html ?

I couldn't figure out why the "unhashable type: 'numpy.ndarray'" occurs, perhaps, Loop and Measure are not smart enough about parameters which return numpy arrays of data. You could ask this question on our Slack channel, perhaps other people from our community know - do you know how to access the Slack channel?

would you please advise me of how to access the Slack chann?
On Mon, Jul 27, 2020 at 20:26 Mikhail Astafev<EMAIL_ADDRESS>wrote:

I couldn't figure out why the "unhashable type: 'numpy.ndarray'" occurs,
perhaps, Loop and Measure are not smart enough about parameters which
return numpy arrays of data. You could ask this question on our Slack
channel, perhaps other people from our community know - do you know how to
access the Slack channel?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/QCoDeS/Qcodes/issues/2093#issuecomment-664339888, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHW2IEHZFPQPFVTVLAKDC5DR5VP6XANCNFSM4PEJCCLQ
.

--
Best Regards
Sinan Bugu
Department of Electrical & Electronic Engineering
Graduate School of Energy Science & Engineering
Tokyo Institute of Technology,  Japan

@bugusan just send an email to Mikhail.Astafev(at)microsoft.com and I will invite you to the Slack channel


Can't install open3d

I'm trying to install this project on an iPad-Pro.
I'm using Pyto to run python code
Whenever i try to install open3d it says:
This package cannot be installed because it needs to be compiled, and iOS app cannot dynamically load external binaries
What should i do?

might be difficult to run open3d on iPad, use a PC

Oh ok, i thought this project was running Open3D on iPad, but it is actually just using the iPad as an input device for the PC, correct?

but it is actually just using the iPad as an input device for the PC,
Yes!


Stripped out OrderStatusLog functionality.

This functionality has not been used, tested or maintained for some time, and can be added in at a later stage, perhaps by a sub-module.

-1 We use sendStatusChange() for our store. If it is going to be stripped out then a module would be good to setup before it lands.

I've never used this feature, but it seems like it makes sense to have. How much work would it take to make this a first-class citizen? Is it just a matter of writings some tests? Is there currently a way to make the status notification changes happen automatically or do you have to write that yourself?

@wilr ok cool, thanks for sharing. Yeah, I agree that if this is part of 1.0 functionality, then we need to keep it in.
@markguinn I'm not sure. I've never used it either, but I have imagined that it would be automated.
A basic implementation could be that whenever the Status field changes, a new log entry is created. Its almost like the Order table should be versioned.
I think I'll continue pull requesting instead of just making changes to shop from now on. I already see its going to prevent hassles.

@jedateach Yeah, happy to review PRs. Of course, my experience is limited to a couple of projects but will try and help anyway possible.

@wilr if you're actively using this could you fill us in on how you use it? Are you extending Order and calling sendStatusChange from onAfterWrite or something?
I agree that automatically created log entries seems like a good plan. I wonder too about having a config option on order that would be an array of statuses for which the status email gets sent automatically. If this was empty by default you'd maintain backwards compatibility but make using this feature simple to opt in on.

@markguinn calling sendStatusChange() in a function which is called when an order has been shipped to send a notification to the user.

Hey guys, I assume making this code into a 'module' has still not been done. Just so it doesnt get removed before an equivalent module is made I also plan to use it. How, I am not sure but once I figure it out I will let you know.

ON a side note I found this module: https://github.com/milkyway-multimedia/ss-shop-order-history which looks like they hook into the class as well.

Oh, that milkyway-multimedia module looks brilliant. That might just solve this issue. We could deprecate everything here and remove it in 2.0 (assuming we evaluate that module in depth and determine that it does everything needed). Thanks for pointing that out @adrian-stein!

I'm not likely to work on this PR any time soon, so closing.


Tree cleanup

Added error propagation (instead of bare panics). This will allow us to do later fancy thing, e.g like having a way to recover from strange errors with a soft reset.
Moved more things out of tree.rs

Added workspace to actions

More concise error names.

Please merge in after #107

Coverage decreased (-0.9%) to 64.534% when pulling ca6b00a36da287bc6d20f9d6727acca714001eed on tree-cleanup into f14d8eea29acb78651737cefbf5619cf69925089 on master.

Coverage decreased (-0.5%) to 64.534% when pulling f2ce35e57c66874c6262f1e00854cbf226547ca6 on tree-cleanup into 53fb8f0175773e905480a937c234ccb4fb100298 on master.

Coverage decreased (-0.5%) to 64.534% when pulling ee88ab2f45e2feded920415b27f5750448ce5add on tree-cleanup into 53fb8f0175773e905480a937c234ccb4fb100298 on master.

Coverage decreased (-0.5%) to 64.534% when pulling 6541a8bc17eedc7e0ab0e65b2eb6bf37ab025b36 on tree-cleanup into 53fb8f0175773e905480a937c234ccb4fb100298 on master.


Set mysql2 to "~> 0.3.18" as 0.4.1 is failing with rails 4.2.4

This should fix the failing mysql Travis builds until the latest mysql2 + rails get along. http://stackoverflow.com/a/32466950

mysql jobs passed, but the tests are failing with a particular seed. Reproducible with any DB so I created a separate issue #687.


Is deleting a account a valid option to delete a Bookings Calendar

Hello,
Do I have to delete the user so that it deletes the calendar. Am i reading correctly these instructions ? There should be a warning before doing that you are deleting an account and not just the calendar ? Am I right ?
The rest of the solution state to execute powershell commands to delete the calendar which is ok.
But the first solution seems to be a bit too strong to just delete a calendar.
I am happy to see that there's a powershell solution.
Thanks,
Bruno

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa612c0e-c089-8b3e-8e2e-dd12b6fc382c
Version Independent ID: fa014ea6-7aa2-b2bd-d913-165c3241675f
Content: Delete a booking calendar
Content Source: microsoft-365/bookings/delete-calendar.md
Service: bookings
GitHub Login: @kwekuako
Microsoft Alias: kwekua

@deuxpointzero Thank you for your feedback. You are correct, There are only two options to delete a booking calendar (Admin GUI to delete the account and the PS method). The  GUI option is strong and we got to delete the entire mailbox /user account. There has been a design request(user voice) to delete the calendar alone at the user/admin level (GUI) -https://outlook.uservoice.com/forums/314907-microsoft-bookings/suggestions/18203092-delete-a-bookings-calendar-test
You can vote for this design change and will be notified when it is approved. We will also update the document when there are feature changes made on Bookings.
Hope this helps! @yogkumgit There are no changes required on this document and the issue  can be closed.
Thanks
Sri

@deuxpointzero  Thank you very much for your kind feedback. Considering your valuable feedback, as advised please log this issue as a User Voice. Concerning team will evaluate and take the appropriate action, as per their schedule. We proceed here to close it. Thanks again for taking out some time and sharing your feedback.


Bump CoreOS AMI to v1745.7.0

High-level description
Bump CoreOS AMI to v1745.7.0 allowing for 5th generation of EC2 instances. The AMIs are taking from the CoreOS documentation page
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-20093
DCOS_OSS-381
DCOS-38403

Checklist for all PRs

[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

This repo has @mesosphere-mergebot integration. You can interact with the following commands.
@mesosphere-mergebot bump-ee
@mesosphere-mergebot merge-it
@mesosphere-mergebot label [Request For Comment |Work In Progress |Holding |Ship It |Ready For Review]
@mesosphere-mergebot override-status

PR creators can apply one of  [Ready For Review |Work In Progress]. Owners can apply any label.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple https://jira.mesosphere.com/browse/DCOS_OSS-2115

@mesosphere-mergebot bump-ee

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

@mesosphere-mergebot bump-ee

@zen-dog, an owner other than the PR creator needs to issue that command.

@zen-dog, an owner other than the PR creator needs to issue that command.

@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple https://jira.mesosphere.com/browse/DCOS_OSS-2115

Hi @zen-dog  - I think, your bump-ee after the final change was not successful. You might have do the bump-ee again after updating your branch will changes from master.

Apologies. This was not your mistake, and it was not obvious. The bump-ee command had not registered and did not give you response by updating the EE PR.
Trying bump-ee again should be okay, you will have to update your branch against the master because master has moved. (more info on why, etc)

Please update this branch with changes from master, and do a bump-ee again, I will approve both the open and EE PRs again. Thank you!

@mesosphere-mergebot bump-ee

Hey @zen-dog  - It looks like the networking failure in the CloudFormation Testsuite is directly related to the changes from this. - Please look at these tests consistently failing on this PR when the master branch is stable - We should not be merging this PR without the corresponding networking fix.
The previous override I did was a mistake. We could have avoided the unfortunate mechanical churn if we had identified the real issue that observed since the origin of this PR.

Update to CoreOS v1745.7.0 is leading to networking failures in DC/OS

Isn't that the usual flakiness of the networking tests?

:wave: This PR has been inactive for 3 days. Please review the status checks to see what needs to be done to move it forward or change the label to Work in Progress. Thank you!

Hi Aleksey - Nope, it isn't the usual flakiness. There is networking issue and it is assigned to the networking team at the moment - https://jira.mesosphere.com/browse/DCOS_OSS-3707

@mesosphere-mergebot label work in progress


Fixing bug that would cause "max_results" param to be ignored when se…

As stated in the title.
Yt::Collections::Videos.new.where(q: 'video title', max_results: '5', order: 'relevance')
would return 50 results instead of the requested 5.

+1
I cannot get max_results params to work

Hi there,
My name is Derek and I'm now one of the maintainers of the Yt gem. I want to both thank you for your contribution and apologize for the lack of feedback on your pull request. Maintaining an open source project like Yt is a pretty big job, and we're taking steps to prioritize maintenance and development of the project. We're hoping to review community contributions on a regular basis, as well as provide a roadmap for our development plans.
As part of this process we're going through the open PRs and taking action on each one, and for this PR we've chosen to close it. Unfortunately due to the sheer number of PRs and amount of time that's passed, we can't address your PR individually. If you'd like our thoughts, feel free to comment on your PR, and we'll try and get back to you in a timely manner. In lieu of that, some of the reasons we've closed PRs are:

a lack of tests. We strive for comprehensive coverage; this is important to us
the passage of time: things that were relevant when the PR was opened might not be as important anymore
feature need. Since adding features requires us to maintain them, we want to add features that many people will use

Thanks again for your contribution, and please let us know if you have any questions or comments.


include module does not include macros

Crystal 0.23.0 [3c3d3e2] (2017-06-28) LLVM 3.8.1
The following code no longer compiles under Crystal 0.23
module A
  macro test(msg)
    def message
      {{msg}}
    end
  end
end

class B
  include A

  test("macro test")
end

print B.new.message

$ crystal a.cr
Error in a.cr:12: undefined method 'test'

  test("macro test")
  ^~~~

Is this intended behavior?

already reported as #4639, sorry for the duplicate


Missing prefiltering of Customer No. for custom Customer Statement running from Customer Card

Currently the code assumes that Customer Statement can be selected only on Custom Report Selection, leaving behind Report Selections and suggesting only Standard Statement report as default despite it can be substituted by other report in Report Selections. This leads to custom reports for Customer Statement defined in Report Selections, are run without prefiltered Customer's No. as it would be for Standard Statement.
I suggest to include Report Selections as the second stage of checking before setting default Standard Statement.
page 21 "Customer Card"
{
...
    actions
    {
...
        area(reporting)
        {
...
            action("Report Statement")
            {
                ApplicationArea = Basic, Suite;
                Caption = 'Statement';
                Image = "Report";
                ToolTip = 'View a list of a customer''s transactions for a selected period, for example, to send to the customer at the close of an accounting period. You can choose to have all overdue balances displayed regardless of the period specified, or you can choose to include an aging band.';

                trigger OnAction()
                var
                    Customer: Record Customer;
                    CustomReportSelection: Record "Custom Report Selection";
                    CustomLayoutReporting: Codeunit "Custom Layout Reporting";
                    ReportSelections: Record "Report Selections";
                    RecRef: RecordRef;
                begin
                    RecRef.Open(Database::Customer);
                    CustomLayoutReporting.SetOutputFileBaseName(StatementFileNameTxt);
                    CustomReportSelection.SetRange(Usage, "Report Selection Usage"::"C.Statement");
                    if CustomReportSelection.FindFirst() then
                        CustomLayoutReporting.SetTableFilterForReportID(CustomReportSelection."Report ID", "No.")
                    // Change Start
                    // else
                    //     CustomLayoutReporting.SetTableFilterForReportID(Report::"Standard Statement", "No.");
                    else begin
                        ReportSelections.SetRange(Usage, "Report Selection Usage"::"C.Statement");
                        if ReportSelections.FindFirst() then
                            CustomLayoutReporting.SetTableFilterForReportID(ReportSelections."Report ID", "No.")
                        else
                            CustomLayoutReporting.SetTableFilterForReportID(Report::"Standard Statement", "No.");
                    end;
                    // Change Stop
                    CustomLayoutReporting.ProcessReportData(
                        "Report Selection Usage"::"C.Statement", RecRef, Customer.FieldName("No."),
                        Database::Customer, Customer.FieldName("No."), true);
                end;
            }
...

@AlexanderYakunin is there any ETA if this simple change is going to be implemented?

Sure, the problem is not this request but total number of requests we have. Unfortunately I cannot give you ETA, as RFH and ICM works goes first. If you have special urgency and need this for specific version (not only 23x), please let me know.

If you have special urgency and need this for specific version (not only 23x), please let me know.
We have at least one customer already asking us why our custom Statement is not filtering Customer No. correctly.
Current workaround is to add at least for one customer the entry in Custom Report Selection entry with our report (as here is no checking if Custom Report Selection is defined for the specific customer). But I believe it is not the best solution.

So, now I see the correct code would be the following:
page 21 "Customer Card"
{
...
    actions
    {
...
        area(reporting)
        {
...
            action("Report Statement")
            {
                ApplicationArea = Basic, Suite;
                Caption = 'Statement';
                Image = "Report";
                ToolTip = 'View a list of a customer''s transactions for a selected period, for example, to send to the customer at the close of an accounting period. You can choose to have all overdue balances displayed regardless of the period specified, or you can choose to include an aging band.';

                trigger OnAction()
                var
                    Customer: Record Customer;
                    CustomReportSelection: Record "Custom Report Selection";
                    CustomLayoutReporting: Codeunit "Custom Layout Reporting";
                    ReportSelections: Record "Report Selections";
                    RecRef: RecordRef;
                begin
                    RecRef.Open(Database::Customer);
                    CustomLayoutReporting.SetOutputFileBaseName(StatementFileNameTxt);
                    CustomReportSelection.SetRange(Usage, "Report Selection Usage"::"C.Statement");
                    // Change Start
                    CustomReportSelection.SetRange("Source Type", Database::Customer);
                    CustomReportSelection.SetRange("Source No.", "No.");
                    // Change Stop
                    if CustomReportSelection.FindFirst() then
                        CustomLayoutReporting.SetTableFilterForReportID(CustomReportSelection."Report ID", "No.")
                    // Change Start
                    // else
                    //     CustomLayoutReporting.SetTableFilterForReportID(Report::"Standard Statement", "No.");
                    else begin
                        ReportSelections.SetRange(Usage, "Report Selection Usage"::"C.Statement");
                        if ReportSelections.FindFirst() then
                            CustomLayoutReporting.SetTableFilterForReportID(ReportSelections."Report ID", "No.")
                        else
                            CustomLayoutReporting.SetTableFilterForReportID(Report::"Standard Statement", "No.");
                    end;
                    // Change Stop
                    CustomLayoutReporting.ProcessReportData(
                        "Report Selection Usage"::"C.Statement", RecRef, Customer.FieldName("No."),
                        Database::Customer, Customer.FieldName("No."), true);
                end;
            }
...

If you had contacted technical support earlier, this error would have already been corrected! This is not related to extensibility.

If you had contacted technical support earlier, this error would have already been corrected! This is not related to extensibility.

No, I did not. And according to the source code of BC 22.0, it is still unchanged in the Customer Card page.

Submitted bug request in Ready! program.
Hope, it will be fixed soon :)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


"filtered" label broken.

When searching the devices table, the total of the filtered devices is
not updated.
(See attachment)

Is the label broken? Or, is the filtered count broken.
Or both?


[TASK] Increases verbose output when debugging (-vvv) is set

To debug https://github.com/TYPO3-Documentation/render-guides/issues/83 we need more verbose output what directories/files are used.
Sadly, $output isn't available within this file (yet) and I don't know how to properly detect the "-vvv" argument at this point. This would be vital before merging this PR.

https://github.com/TYPO3-Documentation/render-guides/pull/119 Is needed for this, too.

One more problem with this.
The github action calls the binary like this:
- uses: TYPO3-Documentation/render-guides@main
      id: render-guides
      if: steps.enable_guides.outputs.GUIDES == 'true'
      with:
        working-directory: t3docsproject
        config: ./Documentation/
        output: ./RenderedDocumentation/Result/project/0.0.0
```

but we can't put `vvv: something` nor `verbose: vvv` into the action, because it's a short-hand command.

How could we then access verbose output when being called within the github action? Do we need to "invent" a new `guides`  parameter like `--debugging=yes` here, so that we could use a github action like this:

uses: TYPO3-Documentation/render-guides@main
id: render-guides
if: steps.enable_guides.outputs.GUIDES == 'true'
with:
working-directory: t3docsproject
config: ./Documentation/
debugging: yes
output: ./RenderedDocumentation/Result/project/0.0.0

?

Setting this on draft so it is not accidently merged while still containing echo


Anyclip bidder dev doc

🏷 Type of documentation

[x] new bid adapter
[ ] update bid adapter
[ ] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[x] Related pull requests in prebid.js or server are linked -> (https://github.com/prebid/Prebid.js/pull/11200)
[x] For new adapters check submitting your adapter docs

part of 8.43


Windows Network Sharing

What feature or improvement do you think would benefit Files?
When you right click on a folder in the default windows explorer you can press "Give Access to" or in Properties>Sharing you can share the folder over the network. I do not see this in this files app.
Requirements

Add a "Give Access To" button for folder context menus
In the properties window of folders add a "Sharing" tab

Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.3227
Comments
Here is Microsoft's documentation with pictures and more information

Thanks for the feedback, We're tracking this in #5941 and #13761 . You can check there or click subscribe in the right sidebar for updates.


Packaging cope

Motivation for this change
I'm trying to package cope, a colourful wrapper for terminal programs. (This is my first time packaging something)
I added the IOStty perl dependency, but it is not found in the tests. What am I doing wrong?
building path(s) ‘/nix/store/858bnxnzn1dq76bkg5m0kc9ipqn5klwg-perl-cope-devdoc’, ‘/nix/store/yii3zklcrlwkcjppmiy8zziyxn5i27na-perl-cope’
unpacking sources
unpacking source archive /nix/store/mql2nsdzbq71y6429vrz5vy6sr8biiql-cope-0dc82a939a9498ff80caf472841c279dfe03efae-src
source root is cope-0dc82a939a9498ff80caf472841c279dfe03efae-src
patching sources
configuring
patching ./t/20-scripts.t...
patching ./t/12-buffering.t...
patching ./t/11-cope.t...
patching ./t/10-get.t...
patching ./t/00-load.t...
patching ./scripts/xrandr...
patching ./scripts/who...
...
patching ./install.sh...
patching ./depends.sh...
patching ./cope_path.pl...
patching ./config.sh...
patching ./build.sh...
*** Module::AutoInstall version 1.03
*** Checking for Perl dependencies...
[Core Features]
- Test::More          ...loaded. (1.001014)
- ExtUtils::MakeMaker ...loaded. (7.1002 >= 6.11)
- Env::Path           ...loaded. (0.19)
- File::ShareDir      ...loaded. (1.03)
- IO::Handle          ...loaded. (1.36)
- IO::Pty             ...loaded. (1.12)
- IO::Stty            ...missing.
- List::MoreUtils     ...loaded. (0.413)
- Regexp::Common      ...loaded.<PHONE_NUMBER>)
- Term::ANSIColor     ...loaded. (4.04)
- Regexp::IPv6        ...loaded. (0.03)
*** Module::AutoInstall configuration finished.
Warning: prerequisite IO::Stty 0 not found.
Generating a Unix-style Makefile
Writing Makefile for Cope
Writing MYMETA.yml and MYMETA.json
no configure script, doing nothing
building
build flags: SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash
Installing blib/lib/auto/share/dist/Cope/acpi
Installing blib/lib/auto/share/dist/Cope/aptitude
...
Installing blib/lib/auto/share/dist/Cope/wget
Installing blib/lib/auto/share/dist/Cope/who
Installing blib/lib/auto/share/dist/Cope/xrandr
cp lib/App/Cope/Manual.pod blib/lib/App/Cope/Manual.pod
cp lib/App/Cope/Pty.pm blib/lib/App/Cope/Pty.pm
cp lib/App/Cope.pm blib/lib/App/Cope.pm
cp lib/App/Cope/Extra.pm blib/lib/App/Cope/Extra.pm
cp cope_path.pl blib/lib/cope_path.pl
Manifying 4 pod documents
running tests
check flags: SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash VERBOSE=y test
PERL_DL_NONLAZY=1 "/nix/store/raylbbdkg4yz21c44fwcv63bzvj7a1i1-perl-5.24.2/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/10-get.t t/11-cope.t t/12-buffering.t t/20-scripts.t
# Testing App::Cope 0.99, Perl 5.024002, /nix/store/raylbbdkg4yz21c44fwcv63bzvj7a1i1-perl-5.24.2/bin/perl
t/00-load.t ....... ok
t/10-get.t ........ ok
t/11-cope.t ....... ok
Undefined subroutine &IO::Stty::stty called at /tmp/nix-build-perl-cope.drv-0/cope-0dc82a939a9498ff80caf472841c279dfe03efae-src/blib/lib/App/Cope/Pty.pm line 76.

#   Failed test at t/12-buffering.t line 48.
#          got: ''
#     expected: 'Opening--Closing
# '
Undefined subroutine &IO::Stty::stty called at /tmp/nix-build-perl-cope.drv-0/cope-0dc82a939a9498ff80caf472841c279dfe03efae-src/blib/lib/App/Cope/Pty.pm line 76.

#   Failed test at t/12-buffering.t line 48.
#          got: ''
#     expected: 'Opening--Closing
# '
# Looks like you failed 2 tests of 2.
t/12-buffering.t ..
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/2 subtests
t/20-scripts.t .... ok

Test Summary Report
-------------------
t/12-buffering.t (Wstat: 512 Tests: 2 Failed: 2)
  Failed tests:  1-2
  Non-zero exit status: 2
Files=5, Tests=89,  3 wallclock secs ( 0.05 usr  0.00 sys +  2.36 cusr  0.58 csys =  2.99 CPU)
Result: FAIL
Failed 1/5 test programs. 2/89 subtests failed.
make: *** [Makefile:796: test_dynamic] Error 255
builder for ‘/nix/store/r8343sddlnpi0ymgw7k6vfkiwl0pi4z6-perl-cope.drv’ failed with exit code 2

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

I am not familiar with the Perl tooling, but maybe you have to set
PERL5LIB = with perlPackages; stdenv.lib.makePerlPath [EnvPath FileShareDir IOTty IOStty ListMoreUtils RegexpCommon RegexpIPv6 perl ];

Does the program need Perl during runtime with these tools? In that case it may need some patching or wrapping.

Stalled


DNN-6865 updating username affects portals without emailAsUserName

This is a duplicate of PR #472 - so I am closing this one.


Typo - Server Settings Description

It's just a small typo.
Please see the attached screen capture.  It looks like you duplicated the description for an option in the config.
ZombieFeralMove  >>> Zombie BM Move. <<<   0-4 (Walk, Jog, Run, Sprint, Nightmare)
ZombieBMMove  >>>Zombie BM Move. <<<<    0-4 (Walk, Jog, Run, Sprint, Nightmare)
Thinking the description ZombieFeralMove should be Zombie Feral Move
Scott

Thank you for your feedback, this typo will be corrected in the next version, you can contribute translations here


xGroup fails with cross forest account

Environment:
WMF 5.0, Windows 2012 R2
2 forests with a one way forest trust between them.  User accounts in Forest A, Forest B created with outbound Forest Trust to Forest A.  DSC run on Forest B Domain Controller.  Forest A is in subnet <IP_ADDRESS>/24 and Forest B in <IP_ADDRESS>/24.
I have allowed winrm to remote from <IP_ADDRESS>/24 into Forest A through GPO.
Using the following DCS where the Credential is for Forest A where the labadmins group exists.
xGroup AddToAdministrators
{
Ensure = "Present"
GroupName = "Administrators"
MembersToInclude =<EMAIL_ADDRESS>Credential = $DomainCreds
}
Error:
Resolving<EMAIL_ADDRESS>in the mylab domain.\r\n[2016-04-15T01:34:17] [VERBOSE] [DC1-TEST]:                            [[xGroup]AddToAdministrators] Resolving labadmins as a user.\r\n[2016-04-15T01:34:17] [VERBOSE] [DC1-TEST]:                            [[xGroup]AddToAdministrators] Resolving labadmins as a group.\r\n[2016-04-15T01:34:22] [ERROR] The network path was not found.\r\n\r\n[2016-04-15T01:34:22] [VERBOSE] [DC1-TEST]: LCM:  [ End    Test     ]  [[xGroup]AddToAdministrators]  in 9.5730 seconds.\r\n[2016-04-15T01:34:22] [ERROR] The PowerShell DSC resource '[xGroup]AddToAdministrators' with SourceInfo 'C:\Packages\Plugins\Microsoft.Powershell.DSC\<IP_ADDRESS>\DSCWork\dsc_trust.0\DomainController.ps1::83::3::xGroup' threw one or more non-terminating errors while running the Test-TargetResource functionality. These errors are logged to the ETW channel called Microsoft-Windows-DSC/Operational. Refer to this channel for more details.
Adding the security group manually on the Forest B DC works fine.

I had exactly the same issue...  and if I manually removed the group from a security group it couldn't re-add it because of the error. However I did notice that the time was slightly off between the 2 forests... My issue occurred after a while...
I fixed my issue by syncing time from the same source using the GPO and the NTP Client settings...
Also i promoted one of the DCs as a "reliable" time source: w32tm /config /reliable:yes /update
So the bug here in my case is that this resource doesn't have error handling around authentication, resource resolving and time diff.

I've hit the same issue - 2 domains, 2way trusts. Adding user to local groups - works. Removing it (1 minute later) fails with:

Error: PowerShell DSC resource MSFT_xGroupResource  failed to execute Set-TargetResource functionality with error message: Exception calling "Remove" with "1" argument(s): "The network path was not found.
"
Error: /Stage[main]/Win_manage/Dsc_xgroup[Administrators]/ensure: change from 'absent' to 'present' failed: PowerShell DSC resource MSFT_xGroupResource  failed to execute Set-TargetResource functionality with error message: Exception calling "Remove" with "1" argument(s): "The network path was not found.

Even switching to more verbose output I am unable to find a reason. Time and domains are in sync (adding works), user for dsc has proper rights to do so.


Add missing ways of closing Component Browser

This task is automatically imported from the old Task Issue Board and it was originally created by Adam Obuchowicz.
Original issue is here.

Why
As Enso IDE user
**I want ** to have various ways of opening/closing searcher
**So that ** I can use what meet my needs.
Scope

Section about closing.
Section about accepting suggestions and expressions.

Acceptance Criteria
Scenario:
Given
When
Then

Notes:

The old design is more-or-less covered (for things which weren't later changed).


\setmathfont optional argument and fontspec v2.4 syntax

Currently, \setmathfont follows the old fontspec syntax for \setmainfont, i.e.
\setmathfont[<font features>]{<font name>}

but as of v2.4 the preferred syntax  for \setmainfont is
\setmainfont{<font name>}[<font features>]

It seems reasonable that unicode-math should switch to the new syntax, too (with backwards compatibility). This is an easy fix: in unicode-math.dtx one could simply apply
@@ -2298 +2298 @@
-\DeclareDocumentCommand \setmathfont { O{} m } {
+\DeclareDocumentCommand \setmathfont { O{} m O{} } {

@@ -2313 +2313 @@
-  \keys_set_known:nnN {unicode-math} {#1} \l_um_unknown_keys_clist
+  \keys_set_known:nnN {unicode-math} {#1,#3} \l_um_unknown_keys_clist

Please make a pull request with the proposed changes.


FlatList scrolls to beginning at data refresh

Version
styled-components: 2.2.1
react-native: 0.49.2
Steps to reproduce

Set up styled FlatList, for example const StyledFlatList = styled.FlatList`height: 200px;`;
Set up data refreshing..
Render it with some data so it's possible to scroll list.
Scroll list (a little bit is enough, start can't be visible).
Refresh data. For example add some button to refresh under list, in make case it's Apollo data polling. It also work when I refresh on pull and while it's still refreshing I scroll list a little bit down.

Expected Behavior
Data should refresh in place without list automatically scrolling anywhere.
Actual Behavior
List scrolls to beggining.
Comment
I'll be able to setup some sample project if there will be problem reproducing this bug, but I wouldn't be able to do that before the weekend.

This is probably a usage problem, but we'll need some source code to be able to help you

Cannot reproduce. Maybe the issue is not being cause by styled components?
https://snack.expo.io/BJNKLcTzf

I've expanded example a little to add refreshing I've used in my app and in expo it works as it's supposed to.
https://snack.expo.io/HknxLTaMM
The only thing missing in the example is apollo/redux - instead of local state my component used apollo query to update data when list was pulled down.
We decided to go with different way of styling components, so I won't be able to prove any other example soon.

@XenorPLxx hiya, sorry to hear that it hasn’t worked out for you 😉 in general all hints at a small usage problem, since it’s not reproducible. I myself am using a FlatList with Apollo and SC in a project, and there’s nothing fancy we’re doing that would cause this behaviour.
All in all, I’m forced to close this. Sorry again 😅 I hope that you’ll try it out again sometime. Feel free to reopen/comment on this issue if you experience it again and can create a reproduction.
In general, please read the template carefully. It does ask for some reproduction code for the reason of us being able to experience and debug the problem.
I wish you awesome holidays! ✨

Happy holidays to you too!
I hope I'll have time in the future to check this out again, and for now thank you for trying to solve this thing despite the shortages in my description.


[e2e] SASL/TLS with implicit CA Kafka Broker test

Proposed Changes

:gift: e2e test for Kafka Broker connecting to Kafka with SASL/TLS without explicitly setting a CA (using an implicit CA from the system/container)

For the purpose of the test, we simulate a system truststore by mounting the knative-eventing-bundle ConfigMap to the data-plane and the kafka-controller (and setting -Djavax.net.ssl.trustStore / SSL_CERT_DIR accordingly) and generate a Certificate for Kafka signed by the knative-eventing-ca-issuer ClusterIssuer

/test upgrade-tests

/test upgrade-tests

I1126 10:35:52.425973    3627 common.go:70] No GCP projects provided, acquiring from Boskos [1] project/s
Error: init failed to get project from boskos: failed to get a "gke-project" from boskos: resources not found

/test upgrade-tests

/test upgrade-tests


Revert "[ul] Recover API compatibility with 0.7.1"

Reverts Enet4/dicom-rs#582, because the pull request does not fulfill a complete compatibility with users of the previous users. To be decided whether to move forward with this.

#592


Translate lit_tests/incrParse with assertIncrementalParse

This should make it easier to read and run test cases in lit_tests/incrParse with assertIncrementalParse.

I've also opened a separated pr (#1807) to delete all the old incremental parse test utils and lit-based test cases.

@swift-ci Please test

@swift-ci Please test Windows


Failed to init storage implementation

Password to my mongodb is nothing, and username is root. The port is not exposed outside of localhost
the error is:
https://pastebin.com/K31v8PA5

I can see multiple issues here

Not having a password is bad practice and should be avoided. Always set a password, so that you have some protection agains people accessing the database.

This is also the main cause of the issue, as it seems that the password can't be null/empty

Don't use root. This user is only meant for you (the administrator) and shouldn't be used by plugins at all. Reason behind this is, that root can access all databases, so a malicious plugin could abuse this, or someone could take advantage of this.
Always create a separate user (with password) that only has access to specific databases. This reduces the risk of someone harming your database a lot.

Fixed this by changing the user, thanks.


Log4j vul (CVE-2021-44228) patches required?

Is there anything we as users of the DataDog agent Helm chart and Docker containers need to patch related to the Log4j vulnerability?
Running DataDog agent versions [7.26.0, 7.30.1, 7.31.1, 7.32.1]

7.32.2 was released with a mitigation https://github.com/DataDog/datadog-agent/releases/tag/7.32.2

@darend thanks for the reply. So just to confirm, previously versions are vulnerable?

@nodesocket I would assume any 7.x release is vulnerable but I have not seen an official statement from them

There is a blog post at https://www.datadoghq.com/log4j-vulnerability/


[BUG]: Cannot Login

Description
When logging in, I get to this page:

The page only gives a favicon error in the debugger and clicking "Sign in with GitHub" does nothing.

(optional) What browsers are you seeing the problem on?
Firefox
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This is resolved


INSERT with SetOperations

Simplify the INSERT production
Use SetOperations for Select and Values
Better Bracket handling for WITH ... SELECT ...
Fixes #1491
Following statements will work now:
(
    with a as (select * from dual)
    select * from a
);

insert into table1 (tf1,tf2,tf2) (
    (select sf1,sf2,sf3 from s1)
    union (select rf1,rf2,rf2 from r1)
);

please resolve conflicts

After merging I am not able to compile anymore.

After merging I am not able to compile anymore.

What is the challenge please?
Have you tried gradle build? The CI passed before.

Confirmed, I get the same problem -- very strange. How did the CI succeed?
I will fix that tomorrow morning, whatever it is.

I am not able to correct this since
Select SelectWithWithItems( ):
{
    Select select;
    List<WithItem> with = null;
}
{
    LOOKAHEAD(2) (
        "(" with=WithList()  select = Select( with ) ")" { select.withUsingWithBrackets(true); }
    )
    |
    (
         [ with=WithList() ] select = Select( with )
    )

    {
        return select;
    }
}

yields
Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project jsqlparser: Compilation failure: Compilation failure:
/C:/work/java/JSqlParser/target/generated-sources/javacc/net/sf/jsqlparser/parser/CCJSqlParser.java:[5631,9] unreachable statement
/C:/work/java/JSqlParser/target/generated-sources/javacc/net/sf/jsqlparser/parser/CCJSqlParser.java:[5639,1] missing return statement
-> [Help 1]

This one I know from switching to modern JavaCC templating. Very strange.

I pushed a running version. To get this state I had to remove the changes from
SelectWithWithItems production
and disabled tests in InsrtTest (testInsertOutputClause, one assert in testInsertWithSelect)

Here only the Codacy and Merge checks were presented. Your change was perfectly mergeable, but this means not automatically compilable.

Corrected grammar. It was semantically incomplete.

Tests reactivated again.
deparser and toString for OutputClause implemented

so this seems to be complete now

Good Morning,
thank you for sorting this out. I am really sorry for this mess, no idea what happened.
I build and test every single time, before I push -- however, checking out this PR, I found those missing part myself and was able to reproduce the problem. Very odd. I can only imagine, that I merged wrongly when resolving conflicts after the previous PR has been accepted.
Sorry again and cheers!

Maybe its time to switch to Github Actions.

Yes please, I'd like to support that, because I really do not like it when things suddenly stop to work -- without notice.
This commit should have been rejected and sent me a message at least.


Instructions on how to compile in Centos7

I am able to install the yosys-systemverilog pluging on Ubuntu 22.04 and it works great. I would like to compile on a Centos7 machine.

I cloned the repository using git clone https://github.com/antmicro/yosys-systemverilog.git --recurse-submodules
I installed the build dependencies using sudo yum install flex-devel tcl-devel pkgconfig readline-devel libffi-devel ant java-11-openjdk java-11-openjdk-devel google-perftools gperftools-devel uuid uuid-devel
I did git submodule update --init --recursive Surelog yosys yosys-f4pga-plugins UHDM-integration-tests
when I run ./build_binaries.sh -y ( I already have Yosys running on my system), I get the following error message

+ '[' -z '' ']'
+ INSTALL_PATH=/home/gkamendje/tmp_compile/UHDM/yosys-systemverilog/image
+ SKIP_YOSYS=0
+ BUILD_SV2V=0
+ for arg in '$@'
+ echo -y
-y
+ case "$arg" in
+ SKIP_YOSYS=1
+ cd Surelog
+ cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/gkamendje/tmp_compile/UHDM/yosys-systemverilog/image -DCMAKE_POSITION_INDEPENDENT_CODE=ON -S . -B build
CMake Error: The source directory "/home/gkamendje/tmp_compile/UHDM/yosys-systemverilog/Surelog/build" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.

I tried to cd Surelog && make but hen I get the following error
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local -DBUILD_SHARED_LIBS=OFF  -S . -B build
CMake Error: The source directory "/home/gkamendje/tmp_compile/UHDM/yosys-systemverilog/Surelog/build" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
make: *** [run-cmake-release] Error 1

I am not very familiar with cmake. Any hint on what I am missing here and how to proceed?

Here is a recipe on how to compile and install systemverilog-plugin on Centos 7. The recipe also illustrates how to integrate it with Yosys installation within the OpenROAD-flow-scripts.
1.
Download and extract the latest version of cmake (at least cmake 3.20 is required) from https://cmake.org/download/ into a local directory
2.
Make sure you have Java 11 installed and If required, change the default Java version to be Java 11
sudo alternatives --config java

There are 4 programs which provide 'java'.

  Selection    Command
-----------------------------------------------
   1           java-1.7.0-openjdk.x86_64 (/usr/lib/jvm/java-1.7.0-openjdk-<IP_ADDRESS>1-<IP_ADDRESS>.el7_8.x86_64/jre/bin/java)
*+ 2           java-1.8.0-openjdk.x86_64 (/usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>2.b07-1.el7_9.x86_64/jre/bin/java)
   3           /usr/lib/jvm/jre-1.6.0-openjdk.x86_64/bin/java
   4           java-11-openjdk.x86_64 (/usr/lib/jvm/java-11-openjdk-<IP_ADDRESS>.8-1.el7_9.x86_64/bin/java)

Enter to keep the current selection[+], or type selection number: 4

clone the plugin using git clone https://github.com/chipsalliance/systemverilog-plugin.git

Update the surelog submodule using git submodule update --init --recursive third_party/surelog

Modify lines 33, 34 and 35 of the script build_binaries.sh to use the local installation of cmake (at least 3.20 is required) that was downloaded in step 1 something like this:

c_bin=/my_path/cmake/cmake-3.27.4-linux-x86_64/bin/cmake
#Surelog
cd third_party/surelog
${c_bin} -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$INSTALL_PATH  -DCMAKE_POSITION_INDEPENDENT_CODE=ON -S . -B build
${c_bin} --build build -j $(nproc)
${c_bin} --install build
cd ../..

Modify line 46 of the script build_binaries.sh to include the path to your OpenROAD-flow-scripts YOSYS installation. Something like:

export PATH=$INSTALL_PATH/bin:${PATH}:~/my_path/OpenROAD-flow-scripts/tools/install/yosys/bin/

Create a build directory in the directory third_party/surelog using

cd third_party/surelog/
mkdir build
cd ..

Now run ./build_binaries.sh -y

If everything goes well you should see an output similar to the following at the end of the compilation and installation procedure:
install -D ../../build/systemverilog-plugin/systemverilog.so /my_path/OpenROAD-flow-scripts/tools/install/yosys/share/yosys/plugins/systemverilog.so


Change the lower bound of type annotations tag to 0x80

This way it's easy to test if a tag is an annotation or not
with a simple bitwise check: 0x80 & tag == 0x80.

Also, please fix protocol docs!

Also, please fix protocol docs!

I think I did, there's a change in the docs/internals/protocol/typedesc.rst file. Anything else?

Also, please fix protocol docs!

I think I did, there's a change in the docs/internals/protocol/typedesc.rst file. Anything else?

No as long as I know. Was it originally there, and I've just missed that? Ah, nevermind.


make recipe.py

Short description of what this resolves:
Changes proposed in this pull request:

Fixes: #

Thank you for taking the time to contribute! This is sincerely appreciated. 😇
(Powered by GitMate.io)


Feature request: Ability to identify differences between two JObjects

JToken.DeepEquals() allows a user to compare two JObjects which can be quite useful for unit tests. Unfortunately, when you compare objects that are more than a few lines it can be tricky to spot the differences when they are not equal.
I would like to propose a new method (or alternative signature e.g. with an out parameter) which would help users to identify any keys that are present in one but not the other and any differences within values.

It sounds kind of useful but pretty niche. I think that is something that can be part of a third party helper library.