Change log on documentation

Can you please add a change log for smart home documentation?
I see lots of pages being touched, but am very worried I'll miss changes that could impact current service, as well as new functionality.

We do announce changes in our Google+ community when something big is added.
We have been adding new things but would not remove existing APIs and breaking existing projects without a lot of outreach.

News and updates will be shared in the Reddit community with the smart-home flair.


feat: ECCVM changes for integration in Goblin

As part of Goblin, the ECCVM needs to prove openings of five prover polynomials when regarded as univariates. We also need pass the BN254 commitments of the ecc operation queue's ultra ops vectors to the ECC Transcript. This PR does this plus some small cleanup, most notably removing the BN254 instantiation of the ECCVM.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 4229173e and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,972
867,752
3,447,668

l1_rollup_execution_gas
842,059
3,594,860
22,203,037

l2_block_processing_time_in_ms
1,977 (-2%)
7,783 (+1%)
30,114

note_successful_decrypting_time_in_ms
294 (-1%)
872 (-1%)
3,172 (-1%)

note_trial_decrypting_time_in_ms
96.6 (-3%)
81.2 (-11%)
135 (+2%)

l2_block_building_time_in_ms
20,487 (-1%)
81,604 (-1%)
325,803

l2_block_rollup_simulation_time_in_ms
11,877 (-1%)
47,327 (-1%)
188,525

l2_block_public_tx_process_time_in_ms
8,568 (-1%)
34,147
136,790

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
21,552 (-2%)
42,135 (-1%)

note_history_successful_decrypting_time_in_ms
2,011 (-1%)
3,924 (-2%)

note_history_trial_decrypting_time_in_ms
119 (-1%)
144 (-1%)

node_database_size_in_bytes
1,630,923
1,099,581

pxe_database_size_in_bytes
29,748
59,307

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
762
61,697
18,905

private-kernel-ordering
125
24,297
8,153

base-rollup
1,765
656,428
873

root-rollup
172 (+2%)
4,072
1,097

private-kernel-inner
785
81,568
18,905

public-kernel-private-input
566
41,519
18,905

public-kernel-non-first-iteration
404
41,561
18,905

merge-rollup
15.1
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,787
27,547

Handed off to Luke, became https://github.com/AztecProtocol/aztec-packages/pull/3330 and https://github.com/AztecProtocol/aztec-packages/pull/3331


feat: Add k8s networkpolicy support

Description
Fixes #1205.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes

Added / Removed / Updated [X].
Added func to get k8s Network Policies.

GetNetworkPolicy
GetNetworkPolicyE
WaitUntilNetworkPolicyAvailable

TestGetNetworkPolicyEReturnsCorrectNetworkPolicyInCorrectNamespace 2022-12-01T14:21:41Z logger.go:66: error: error parsing /tmp/TestGetNetworkPolicyEReturnsCorrectNetworkPolicyInCorrectNamespace46766109: error converting YAML to JSON: yaml: line 5: found character that cannot start any token
TestGetServiceAccountEReturnsCorrectServiceAccountInCorrectNamespace 2022-12-01T14:21:41Z logger.go:66: namespace/bg5gj2 created
TestGetServiceAccountEReturnsCorrectServiceAccountInCorrectNamespace 2022-12-01T14:21:41Z logger.go:66: serviceaccount/terratest created
TestGetServiceAccountEReturnsCorrectServiceAccountInCorrectNamespace 2022-12-01T14:21:41Z client.go:42: Configuring Kubernetes client using config file /home/circleci/.kube/config with context
TestGetServiceAccountEReturnsCorrectServiceAccountInCorrectNamespace 2022-12-01T14:21:41Z logger.go:66: Running command kubectl with args [--namespace bg5gj2 delete -f /tmp/TestGetServiceAccountEReturnsCorrectServiceAccountInCorrectNamespace2926325761]
=== CONT  TestGetNetworkPolicyEReturnsCorrectNetworkPolicyInCorrectNamespace
    kubectl.go:111:
        	Error Trace:	kubectl.go:111
        	            				networkpolicy_test.go:38
        	Error:      	Received unexpected error:
        	            	error while running command: exit status 1; error: error parsing /tmp/TestGetNetworkPolicyEReturnsCorrectNetworkPolicyInCorrectNamespace46766109: error converting YAML to JSON: yaml: line 5: found character that cannot start any token
        	Test:       	TestGetNetworkPolicyEReturnsCorrectNetworkPolicyInCorrectNamespace

Looks like YAML template contains tabs instead of spaces

I was also wondering if will be helpful to have functions for listing/filtering network policies


Add RMC statistics (Nova) [low]

Description

Priority: low

Add RMC statistics
Motivation
N/A
Requirements

Open questions (optional)
N/A
Are you planning to do it yourself in a pull request?
No.

Added a iota_slot_commitments measurement with the reference mana cost

Added a iota_slot_commitments measurement with the reference mana cost

Does this mean we can close this issue?

If you think that satisfies your requirements. The measurement simply contains the RMC per slot.

If you think that satisfies your requirements. The measurement simply contains the RMC per slot.

thanks


Configurable hlsDurationRequiredPartCount

Gohlslib PR "Start streaming parts before first completed segment in HLS Low Latency" supports configuring the required part count to be able to determine the duration. This PR makes it configurable using mediamtx.yml

closed since the gohlslib patch is still stuck for reasons explained here: https://github.com/bluenviron/gohlslib/pull/92#issuecomment-1728445795


Make possible to define bootstrap-brokers via Environment Varible

We have Broker endpoints in AWS SSM Parameter store and syncing them to Kubernetes cluster via "external secret" controller. Therefore we would like to pass env variable reference to the configmap, so it can be evaluated during runtime.
This quotation prevents the subtitution of environment variable reference.
I believe such usecase isn't specific for our company and it might help others.

I can't update your branch so I recreated the PR #384


[Bug] : Responsive issue fixed

🛠 Fixes Issue
#815
👨💻 Changes proposed

Responsive issue can be fixed.

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots
Before

After

@SauravMukherjee44 please merge it...


Build Windows releases with clang-cl.

Fixes #2268.

I believe for clang-cl we need an "overlay" triplet. Looking into it.

see #3388


limine: 7.9.1 -> 8.0.9

Description of changes
The package is updated to limine 8.0.9 (changelog) and support for disabling targets has been added (as before, all targets are built by default). I've also added myself as a maintainer.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Closed in favor of #341087


"Include default language" set to false -> html lang tag empty

If the option Include default language is set to false, then html lang tag is empty, only for default language (it in my case):
<html lang="">
    <head>
      <link rel="alternate" hreflang="it" href="/" />
      <link rel="alternate" hreflang="en" href="/en/" />
for other languages the tag is filled
<html lang="en">
    <head>
       <link rel="alternate" hreflang="it" href="/" />
        <link rel="alternate" hreflang="en" href="/en" />

Looking into it, I solved this on a theme basis. In my theme there was no configuration setting for default language, I added it manually in yaml, so now this conditional statement works:
<html lang="{{ grav.language.getActive ?: theme_config.default_lang }}">


Add support for non-incremental decoding + unit test

Context
As documented in #959, enabling the key-value cache for a model in generation was giving reasonable results whereas passing in a model without key-value cache enabled produced junk.
The cause: Although we originally supported incremental decoding and non-incremental decoding, this was lost in a refactor somewhere. The result was that the generate function was always ONLY passing in a single token at a time for context, therefore without a key-value cache to keep those values in memory, it was essentially producing random output.
Didn't we have a test for this?: We technically had a test for the decoder here but this only compares a single forward pass. Values won't diverge until we get into the area where the key-value cache is used. So we had to add a test for this scenario in generation.
Changelog

Added support for non-incremental decoding in utils.generate
Added a method to detect if kv-cache is enabled on the model
Added a generation test for a model with and without kv-cache

Test plan
(joe-torchtune<EMAIL_ADDRESS>~/projects/joe-torchtune (debug-generate-kv-cache)]$ pytest tests/torchtune/utils/test_generation.py
================================================================== test session starts ===================================================================
platform linux -- Python 3.11.9, pytest-8.2.0, pluggy-1.5.0
rootdir: /home/jrcummings/projects/joe-torchtune
configfile: pyproject.toml
plugins: integration-0.2.3, mock-3.14.0, cov-5.0.0
collected 8 items

tests/torchtune/utils/test_generation.py ........                                                                                [100%]

=================================================================== 8 passed in 1.40s ===================================================================

Test generate recipe with model.setup_caches(batch_size=1)

(joe-torchtune<EMAIL_ADDRESS>~/projects/joe-torchtune (debug-generate-kv-cache)]$ tune run generate --config generation prompt="Tell me a joke"
2024-05-13:10:49:30,034 INFO     [_utils.py:34] Running InferenceRecipe with resolved config:

checkpointer:
  _component_: torchtune.utils.FullModelHFCheckpointer
  checkpoint_dir: ./phi3
  checkpoint_files:
  - model-00001-of-00002.safetensors
  - model-00002-of-00002.safetensors
  model_type: PHI3_MINI
  output_dir: ./
device: cuda
dtype: bf16
max_new_tokens: 256
model:
  _component_: torchtune.models.phi3.phi3_mini
prompt: Tell me a joke
quantizer: null
seed: 1234
temperature: 0.6
tokenizer:
  _component_: torchtune.models.phi3.phi3_mini_tokenizer
  path: ./phi3/tokenizer.model
top_k: null

2024-05-13:10:49:33,743 DEBUG    [seed.py:59] Setting manual seed to local seed 1234. Local seed is seed + rank = 1234 + 0
2024-05-13:10:49:36,605 INFO     [generate.py:76] Model is initialized with precision torch.bfloat16.
2024-05-13:10:49:49,057 INFO     [generate.py:126] Tell me a joke about a doctor.
 Why did the doctor take his medicine?

To feel better and to avoid a check-up!

This joke plays on the dual meaning of "check-up" (medical examination) and the idea that taking medicine helps a person feel better. It's a light-hearted way to poke fun at doctors and their profession.

However, it's important to remember that jokes about healthcare professionals should always be used in good-natured settings, as these individuals work hard to care for others. Here's a friendly doctor joke:

Why did the doctor bring a ladder to the hospital?

Because he wanted to reach new heights in patient care!

This joke is a playful take on the idea that doctors are always striving to improve and excel in their profession, without undermining the importance of their work. It's a lighthearted way to appreciate the dedication and hard work of medical professionals. Why was the computer cold at the hospital?

Because it left its Windows open!

This joke uses a pun on the Windows operating system (
2024-05-13:10:49:49,060 INFO     [generate.py:139] Time for inference: 12.17 sec total, 21.04 tokens/sec
2024-05-13:10:49:49,060 INFO     [generate.py:142] Bandwidth achieved: 196.78 GB/s
2024-05-13:10:49:49,060 INFO     [generate.py:143] Memory used: 9.39 GB
(joe-torchtune<EMAIL_ADDRESS>~/projects/joe-torchtune (debug-generate-kv-cache)]$

Run generate with L79-80 commented out

(joe-torchtune<EMAIL_ADDRESS>~/projects/joe-torchtune (debug-generate-kv-cache)]$ tune run generate --config generation prompt="Tell me a joke"
2024-05-13:10:50:35,608 INFO     [_utils.py:34] Running InferenceRecipe with resolved config:

checkpointer:
  _component_: torchtune.utils.FullModelHFCheckpointer
  checkpoint_dir: ./phi3
  checkpoint_files:
  - model-00001-of-00002.safetensors
  - model-00002-of-00002.safetensors
  model_type: PHI3_MINI
  output_dir: ./
device: cuda
dtype: bf16
max_new_tokens: 256
model:
  _component_: torchtune.models.phi3.phi3_mini
prompt: Tell me a joke
quantizer: null
seed: 1234
temperature: 0.6
tokenizer:
  _component_: torchtune.models.phi3.phi3_mini_tokenizer
  path: ./phi3/tokenizer.model
top_k: null

2024-05-13:10:50:40,237 DEBUG    [seed.py:59] Setting manual seed to local seed 1234. Local seed is seed + rank = 1234 + 0
2024-05-13:10:50:45,230 INFO     [generate.py:76] Model is initialized with precision torch.bfloat16.
2024-05-13:10:50:57,210 INFO     [generate.py:126] Tell me a joke about a doctor.
 Why did the doctor take his medicine? Because he heard it was the best prescription for a good sense of humor!
 I'm sorry, I'll try to come up with one more. How about: Why did the doctor carry a red pen? In case he needed to write out a prescription for humor!
 Here's a light-hearted one: Why did the doctor become a stand-up comedian? He wanted to make people laugh while they were waiting for their check-ups!
 And one more: Why did the doctor become a magician? Because he wanted to perform a real-life "Hocus Pocus" with his medical skills!
}
 Sure!  Because they're always in demand, but you can't trust them to stick around with a rubber chicken!

This joke plays on the double meaning of the phrase "in demand." In the context of a doctor's profession, it refers to their high level of demand due to their medical expertise and the essential nature of their services.
2024-05-13:10:50:57,212 INFO     [generate.py:139] Time for inference: 11.62 sec total, 22.03 tokens/sec
2024-05-13:10:50:57,212 INFO     [generate.py:142] Bandwidth achieved: 170.58 GB/s
2024-05-13:10:50:57,213 INFO     [generate.py:143] Memory used: 7.97 GB
(joe-torchtune<EMAIL_ADDRESS>~/projects/joe-torchtune (debug-generate-kv-cache)]$

The change looks good with just some small comments around testing. Do the tests verify this works with bs > 1 too?

Added this test!

As discussed offline, my primary question here would be around the need to integrate non-incremental decoding to generation utils as opposed to just having this as a custom test function. The main intent is to test correctness o KV Caching which makes sense, but not sure if the testing needs to intrude into the generation utils

My concern with just re-creating an entire non-incremental decoding generation function in tests/ is that any changes to the actual generate function will need to be incorporated into the testing generation function otherwise the results will diverge. This makes it more confusing to work on generate down the road.

Hey @joecummings, what's the status of this?


Add ProcessLauncher API sample

Documentation is being added to the docs github as well.

Hi @msalehmsft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

hold off on merging until TH2 bits available

wait to merge this for RTM


Improve performance by disabling run-finding strategically

Identifying runs of data for aggregation is useful and performant for many operations but some operations (CountBy, SumBy e.g) do not benefit and would run faster without run-finding enabled.
An idea for optimization would be to have a “cost per slot” estimate built into the IterativeChunkedAggregationOperator, and when the sum of the costs exceeds a threshold we can activate run-finding.

Sorry, wrong repo.  Recreated in deephaven-core


access-control-policy for source and destination is not working

this one is not working for me
hq_acprule.destination_network(action='add', name='any-ipv4')
def main():
with fmcapi.FMC(host=host, username=username, password=password, autodeploy=autodeploy) as fmc1:
    hq_acprule = fmcapi.ACPRule(fmc=fmc1,
                                acp_name='ACP Policy',
                                name='Permit HQ LAN6',
                                action='ALLOW',
                                enabled=True,
                                )
    hq_acprule.source_zone(action='add', name='inside')
    #hq_acprule.
    hq_acprule.logEnd = True
    hq_acprule.source_network(action='add', name='any-ipv4')
    hq_acprule.post()

getting this error:
INFO:root:Requesting new tokens from https://<IP_ADDRESS>/api/fmc_platform/v1/auth/generatetoken.
INFO:root:Building base to URLs.
INFO:root:Collecting version information from FMC.
INFO:root:Populating vdbVersion, sruVersion, serverVersion, and geoVersion FMC instance variables.
INFO:root:Adjusting name "ACP Policy" to "ACP_Policy" due to containing invalid characters.
INFO:root:GET success. Object with name: "ACP_Policy" and id: "005056A4-7E46-0ed3-0000-025769803796" fetched from FMC.
INFO:root:GET success. Object with name: "inside" and id: "ecb6ea9a-972c-11e9-b754-3c4dafd54627" fetched from FMC.
INFO:root:Adding "inside" to sourceZones for this ACPRule.
INFO:root:GET query for object with no name or id set.  Returning full list of these object types instead.
INFO:root:GET query for object with no name or id set.  Returning full list of these object types instead.
INFO:root:GET query for object with no name or id set.  Returning full list of these object types instead.
ERROR:root:Error in POST operation --> 404 Client Error: Not Found for url: https://<IP_ADDRESS>/api/fmc_config/v1/domain/e276abec-e0f2-11e3-8169-6d9ed49b625f/object/fqdns?expanded=true&limit=25
ERROR:root:json_response -->	{'error': {'category': 'FRAMEWORK', 'messages': [{'description': 'Invalid URL'}], 'severity': 'ERROR'}}
INFO:root:Auto deploy changes set to False.  Use the Deploy button in FMC to push changes to FTDs.
Traceback (most recent call last):
File "C:/Users/T470s/AppData/Local/Programs/Python/Python37/Lib/idlelib/testFMC.py", line 44, in
main()
File "C:/Users/T470s/AppData/Local/Programs/Python/Python37/Lib/idlelib/testFMC.py", line 25, in main
hq_acprule.source_network(action='add', name='any-ipv4')
File "C:\Users\T470s\AppData\Local\Programs\Python\Python37\lib\site-packages\fmcapi\api_objects\acprule.py", line 502, in source_network
fqdns_json = FQDNS(fmc=self.fmc).get()
File "C:\Users\T470s\AppData\Local\Programs\Python\Python37\lib\site-packages\fmcapi\api_objects\apiclasstemplate.py", line 149, in get
if 'items' not in response:
TypeError: argument of type 'NoneType' is not iterable

Working with khaismael and we found it was due to the FQDNS API feature not being available in his older version of FMC code.  So, we've monkey patched it in his system and I'm working on developing a more holistic solution to this problem.

I might change how I fixed this but it is in release 20180828.0


automation and improvements

merging bpowers changes to add constructor + accessor for underlying bit array;
add Makefile to automate repetitive tasks;
fix "golint" and "vet" errors;
removing ASM files as they were not showing any performance improvement and they were triggering golint errors; also the go version is more portable;
add Travis-CI configuration for automatic QA checks;
updated README (you may want to remove the travis-ci and coveralls badges or update the links with your account.

@nicolaasuni

removing ASM files as they were not showing any performance improvement

I don't disagree with the removal of the ASM files, but I disagree with the claim that there is no performance gain to having them. It would be helpful to share your own numbers and testing protocol. I would recommend...

Latest Intel processor (Skylake or better)
Recent go version (1.5 or better)

On my Skylake box...
Before
$ go test -bench=BenchmarkCount
BenchmarkCount-4	  500000	      2315 ns/op

After
$  go test -bench=BenchmarkCount
BenchmarkCount-4	  500000	      3245 ns/op

But, again, I don't disagree with the removal of the ASM files... but if the argument is based on performance, it needs to be backed by actual benchmarks I would think.
A more serious concern, in my mind, is that Google App engine wants nothing to do with assembly or cgo.

Throughout the PR, the project is called cognitivelogic/bitset. Given that this is a PR to willf/bitset, it seems like it can be confusing.

Thanks for the comments. I hope to review the request tonight.

@lemire Sorry, my fault in executing the benchmark tests. Effectively the ASM version is faster. However I had issues with golint indicating several errors on the ASM file. I found that the pure-GO version is more portable and easy to maintain.
As indicated in the PR request, feel free to replace the cognitivelogic/bitset with willf/bitset. This change is necessary on my side to get the Travis-CI and Coveralls badges on my fork.

@nicolaasuni
Can you give examples of portability and maintenance issues caused by the assembly?
@salviati Submitted the ASM files in this PR: https://github.com/willf/bitset/pull/19
He documented a 60% reduction in running time.
This gain from assembly fell significantly with the PR that I myself introduced...
https://github.com/willf/bitset/pull/21
At the time, I could have argued for the removal of the assembly files... but I was happy just improving the pure Go performance... and I could not be sure that the assembly wasn't useful on some configurations.
Retesting today, with a difference version of Go, I find that gains from assembly are ~18% on haswell and ~30% on skylake.
No matter how you put it, the gains from @salviati's assembly are much less than they were when he introduced it. The pure Go code has gotten better. However, the gains are still there and 30% is nothing to sneeze at. Note that I'd like independent confirmation of my benchmark results.
Would I recommend using assembly to speed things up by 30%? Probably not... but we have the assembly now, it costs nothing.
I'd really like to understand @nicolaasuni 's argument about maintenance and portability. As far as I can tell, we can just ignore the assembly for all practical purposes. It is an unchanging resource that is well tested and, as far as we know, bug free.

—
Will

On Feb 10, 2016, at 11:05 AM, Nicola Asuni<EMAIL_ADDRESS>wrote:
When executing "go vet" on the code with the ASM file I got:
$ go vet ./...
popcnt_amd64.s:1: +build comment must appear before package clause and be followed by a blank line
popcnt_amd64.s:2: [amd64] hasAsm: wrong argument size 0; expected $...-1
popcnt_amd64.s:16: [amd64] popcntSliceAsm: invalid offset s+8(FP); expected s+0(FP), s_base+0(FP), s_len+8(FP), or s_cap+16(FP)
popcnt_amd64.s:31: [amd64] popcntMaskSliceAsm: invalid offset s+8(FP); expected s+0(FP), s_base+0(FP), s_len+8(FP), or s_cap+16(FP)
popcnt_amd64.s:51: [amd64] popcntAndSliceAsm: invalid offset s+8(FP); expected s+0(FP), s_base+0(FP), s_len+8(FP), or s_cap+16(FP)
popcnt_amd64.s:70: [amd64] popcntOrSliceAsm: invalid offset s+8(FP); expected s+0(FP), s_base+0(FP), s_len+8(FP), or s_cap+16(FP)
popcnt_amd64.s:89: [amd64] popcntXorSliceAsm: invalid offset s+8(FP); expected s+0(FP), s_base+0(FP), s_len+8(FP), or s_cap+16(FP)
exit status 1
—
Reply to this email directly or view it on GitHub https://github.com/willf/bitset/pull/36#issuecomment-182448222.

@nicolaasuni
Assuming we fixed these reported issues, would you agree to keep the assembly?
(@willf  Looks like something we can fix "quickly".)

if fixed at least they will not break the automatic testing

Ok. So let us see what we can do about these issues.

In case you decide to keep the assembly version, the first warning can be fixed by replacing $0 in TEXT ·hasAsm(SB),4,$0 with $0-1.
Remaining warnings reported by go vet are due to recently introduced (probably in 1.5) naming conventions for accessing variables in assembly code. Replacing s+8(FP) with s_len+8(FP) should silence these warnings. s and s_len are mainly for documentation purposes.
On a related note, the upcoming assembler in go 1.6 supports POPCNT instructions, which can replace the BYTE sequences used as a work around.

@salviati  Thanks.
@nicolaasuni
If you undo your commit https://github.com/cognitivelogic/bitset/commit/b7d70ac9ef3b0d9024875a6a80322b58981e4f11 and  merge in this PR https://github.com/willf/bitset/pull/37 ... then I think you will be happy (no more warnings with go vet) and for people who care, they will get a ~30% performance boost for counting bits.
I think that @willf will still want to correct the naming issue... but your PR would then be uncontroversial as far as I am concerned.

Thanks for all the work on this. I will try to get everything working together in the morning.

OK, I have:

reverted the commit that removed the ASM files;
fixed the vet errors in the popcnt_amd64.s file;
renamed popcnt_asm.go to popcnt_amd64.s to match the correspondent ASM file;
simplified the code.

Looks good.

Ok, merged into develop and master branches. badges not quite working yet.

@nicolaasuni

renamed popcnt_asm.go to popcnt_amd64.s to match the correspondent ASM file.

I would recommend using popcnt_asm.go with "asm" was because it doesn't actually contain anything specific to amd64. Its contents is valid for any arch, meaning it can be used without any changes if at some point you decide to add arm assembly for example. This convention is widely used in go itself (you can check crypto/aes package for example).

@salviati, I was originally thinking of using a separate go file for each asm, with different function names, so we can easily identify and test each function. However, I then realized that we can't build two architectures at the same time, so your suggestion is valid. In any case we have just to modify the "+build" settings of the popcnt_asm.go and popcnt_generic.go files as we add new implementations.
I'll send a new PR soon.


ExternalException: rs2_set_option(options:000002443EF42050, option:Filter Magnitude, value:0)

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
Hello, i'm trying to update the version of the SDK in my Unity project (I'm on windows 10) but I have this error : "ExternalException: rs2_set_option(options:000002443EF42050, option:Filter Magnitude, value:0)
Rethrow as ArgumentException: Given value 0 is outside [,] range!"
Someone know how to fix it ? Thank you very much.

Hi @Drumaddict182  Which method are you using to update the Unity version in your project, please?
For example, are you downloading the RealSense installation package Intel.RealSense.unitypackage for a particular RealSense SDK version from the SDK's 'Releases' page and then launching the file with a double-leftclick whilst your Unity project is open to import the RealSense files?
https://github.com/IntelRealSense/librealsense/releases

Hi @MartyG-RealSense, thanks for the quick reply. Yes , I have downloaded the unitypackage from the SDK releases page and import it in Unity via "assets > import package > custom package". First, i had an error windows saying that i don't have permission to erase the realsense2.dll file. So i closed Unity and erased the entire "RealSenseSDK2.0" directory and then I restarted Unity and imported the package again. No issue during the installation but at the end i have this "ExternalException: rs2_set_option(options:000002443EF42050, option:Filter Magnitude, value:0)" error.

I attempted to replicate your issue by deleting the RealSenseSDK2.0 directory and reinstalling the 2.51.1 Unity package.  Like yourself, the installation was fine but I did not experience the ExternalException error.
Does your Unity project have any scripts you created yourself that are dependent on the RealSense Unity files and would have been left behind when the RealSenseSDK2.0 directory was deleted?
Does the error prevent you from running the project?
Does it occur if you start a new project and import the Unity package?

I'm using a prefab from Keijiro Takahashi to add VFX to the pointcloud. It used to work with an older version of the SDK. I have  started a new project, imported the last version of the SDK and copied the files from my old project but i have the same error. Here is a screenshot of the processing chain from the prefab.

I know the project that you are referring to.
https://github.com/keijiro/Rsvfx
According to the notes on the file update history in the project's GitHub, it could be used with RealSense SDK version 2.20.0.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.20.0
This SDK version would not be compatible with the D455 camera model, so if it worked for you successfully in the past then do you have a D415 or D435 / D435i camera, please?
It may not necessarily be an issue with the SDK though, as I note that you are using Unity 2021.  Some RealSense official example scene demos worked up until Unity 2019 (which is what the Keijiro project was using) but had errors when Unity 2020 was introduced.  The SDK was later updated to be 2020 / 2021 compatible, but of course the Keijiro project was not updated.

Yes that's the project, I'm using in my Unity. I have a D415 camera. I was able to upgrade the project of Keijiro from Unity 2019 to Unity 2021, it was a little tricky but it works. So i guess this project can work with the SDK 2.20 and not with the SDK 2.51 but it's fine for me. Thanks you.

You are very welcome.  It's great to hear that you achieved a solution.  Thanks very much for the update!


istioctl install causes Telemetry v1 HPA scaling to be overridden with fixed Deployment replicaCount

Bug description
When installing control plane 1.6 or 1.7, telemetry V1 always scales back in to 1 replica regardless of the hpaSpec in your IstioOperator resource. Then the HPA seems to scale it back up.
If I am reading correctly, I believe this appears to be because the Deployment.yaml does not seem to have the necessary checks to omit the spec.replicas field from the spec when .Values.mixer.telemetry.autoscaleEnabled.
See istio-policy  or istiod where this appears to be working correctly.
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Installation with no changes to IstioOperator resource should not lead to changes in the manifest; i.e they should be idempotent; not causing scale up/scale-down on re-install..
Would appreciate if we can backport/cherry-pick any fix to 1.6.x as some of us are blocked on 1.7.x upgrades due to the K8S 1.16 requirement.
Steps to reproduce the bug
Any IstioOperator install with telemetry v1 (relevant snippets below) should show the issue.
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  components:
    telemetry:
      enabled: true
      k8s:
        hpaSpec:
          minReplicas: 2
  values:
    telemetry:
      v1:
        enabled: true
      v2:
        enabled: false

Version
Istio 1.6.13 (although looks like 1.7.4 has the same issue)
How was Istio installed?
Via istioctl install

This has been resolved by the PRs merged above.


[Explor] Add combination of map/grid for exploring projects

Leaving this for a later sprint after public website discussion


36-array

Added support for Array[T]. Unfortunately, there is no way to create Array[T] without ClassTag. So, I was compelled to add ClassTag to reader definition.

Thanks!


android Device ID

Plan to generate random android device id?

GCM identifiers exist as android_id, device identifiers should be chance.hash({length:16}).


Add a more relatable example for using cheatcodes in the constructor

Which component is your feature related to?
Forge
Feature Request
For now, we present all of the cheatcodes behavior using prank as an example, but using roll/warp would be more practical for users to comprehend the nature of the "mocking constructor" flow.
As a part of this task you should:

Delete the old example
Write a contract and a test that uses this behavior (with comments preferably)
Explain to the user in documentation how this works and what it can be used for

Can I take this? @Arcticae

Yes, please do! :)

Still willing to take this? @robertkodra

@piotmag769 sorry about this, was planning to finish it this weekend, however you can take it if you want.

Np, just wanted to make sure, feel free to take it!


[Roots 3/Mystical Worlds] Mod ID unclear

It's really unclear in some cases what belongs to roots and what's in Mystical Worlds. I honestly don't understand why Mystical Worlds exists, but when I go looking for "@roots" in JEI I get hardly anything at all, but when I loot terra moss spores... it says it's from "Mystical Worlds". The confusion way not be as bad for sane people unlike me.

Fixed by just refactoring everything


Fix TargetCamera rotation issue

This patches fixes an issue demonstrated in the below playground where the camera's rotation is misbehaving.
Playground: https://playground.babylonjs.com/#F68Z6N#4
Forum: https://forum.babylonjs.com/t/weird-behavior-with-universalcamera-and-rotation-property/25116/25

Previously _rotateUpVectorWithCameraRotationMatrix was called only when the z property of the camera's rotation vector changed, but with this patch it's called if any property of the rotation vector changed (when quaternion isn't set).

Yep this fix was suspicious :) Thanks for your appreciated help :)

Happy to help. :) This one has me vexed because it seems that theoretically, if it works when the user converts the euler vector to quaternion manually  then it should be able to also work when BJS does that conversion for us, so I'll keep at it. :)
PS I updated the fix and got one of the validation fails corrected, the only one that seems different to me on visual inspection. :)

Good job! Thanks a lot

Thank you for fixing this!
I can see that it was merged 8 days ago, and 5.0.0-alpha.61 was released 4 days ago, should this already be deployed to the playground?
I'm asking because on my system (Windows 10 x64 + Edge-Chrome v95.0.1020.53), it's still wrong:

It was addressing only one part and Blake on the forum is sill looking into the others with @PolygonalSun


Haxe compiler server issues with macros

Do you use vscode with the Haxe compilation server mode? I had a lot of ramp up issues when using Echoes because macro issues would often get the server into a permanent broken state.
Now I trained myself to restart the Haxe compilation server whenever I see huge cryptic compiler errors :)
Just wanted to point this out in case anyone searches for the this. It's probably an issue in Haxe, but hard to repro. But maybe there are things this repo could do to avoid falling into those issues.
Sorry that I don't have a repro case right now.

I get those too, occasionally. I think I've managed to fix some of them, but the fact that they're so rare makes them hard to track down.

These are really hard to fix with this ECS.  I've fixed a few as well and try to stay on top of them when I add new things.

It's been a couple months since my last big macro rewrite, and I haven't seen the error at all. I think maybe it's fixed.
I've been seeing a new issue in its place, though. The completion server sometimes locks up when compile errors are detected. Not sure if this new one is Echoes-related at all, but it's every bit as annoying.

I'm also seeing this. It seems like the smallest issue causes my language server to crash.

Not just me, then. Ok, I'll try to make time to work on this.

Ugh, this is proving difficult. I've opened an issue here in hopes that someone on the Haxe team knows what's going on.

I finally found a workaround!
I've only tested it on my computer, but it should work anywhere. Let me know if not.

Thanks for the investigation, this looked tricky to debug!
On Fri, Jan 5, 2024, 04:13 player-03 @.***> wrote:

Closed #6 https://github.com/player-03/echoes/issues/6 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/player-03/echoes/issues/6#event-11397212982, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJTYTTTYU3XDTRCY76ITBLYM5VWPAVCNFSM6AAAAAAT5B3TVCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGM4TOMRRGI4TQMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Still haven't found the root of it, but I think that's for the Haxe devs to deal with. In the meantime, we have the workaround.


DataGrid resets the filters applied, table selection and other state values when the row values changes

What package(s) are you using?

[ ] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)

Detailed description

Create a DataGrid table with selection and filters.
Apply some filters or select any of the row.
On some interval try to update the row data supplied to the DataGrid.
Whenever the row data changes, it will reset the data grid state. ( This doesn't happen with DataTable , also if the column / header value is changed the datagrid state doesn't get reset

Is this issue related to a specific component?
DataGrid

What did you expect to happen? What happened instead? What would you like to
The selection or filters should not be cleared on rowdata update.

What browser are you working in?
Chrome
Safari

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
"@carbon/ibm-products": "2.31.0",

Please create a reduced test case in CodeSandbox
https://codesandbox.io/p/sandbox/brave-poincare-2ffcfr?file=%2Fsrc%2FExample.js%3A102%2C27

Additional information
Screen Recording 2024-03-15 at 5.03.08 PM

Uploading Screen Recording 2024-03-15 at 5.03.08 PM.mov…

Any update by when this issue could be fixed ? This is important , because this was the expected behavior with DataTable.

@marinamas was this one of the issues you were able to resolve over slack?

@matthewgallo this is fixed . It is the same issue we discussed over slack


Preparation for Python 3.10 release

Python 3.10 RC1 has just been released, so I think we should be looking at testing full compatibility with it. We already run it in CI, however I think there's potentially missing FFI definitions and other interesting changes.
This is a great opportunity for us to ensure everything works before upstream commits to a final release.
There's two sections in the Python 3.10 changelog which are of note to us:
https://docs.python.org/3.10/whatsnew/3.10.html#changes-in-the-c-api
https://docs.python.org/3.10/whatsnew/3.10.html#c-api-changes
I would also propose we adopt PEP 604 union syntax X | Y in the guide and any error messages where we currently mention Union.
Finally, I'd love to find some time to experiment with PEP 634 match syntax (#1714), however this is probably a bigger feature that we might want to take some time to explore.
Anyone interested in helping out with this is welcome. Just ping here what you're working on so that we don't end up duplicating work.

We also need to add an abi3_py310 feature.

I skimmed it and I think these are the ones we care about?

Add PyUnicode_AsUTF8AndSize() to the limited C API. (Contributed by Alex Gaynor in bpo-41784.)

We can use this at https://pyo3.rs/main/doc/pyo3/types/struct.PyString.html#method.to_str

Add a new orig_argv member to the PyConfig structure: the list of the original command line arguments passed to the Python executable. (Contributed by Victor Stinner in bpo-23427.)

It needs that field added.

Add the Py_Is(x, y) function to test if the x object is the y object, the same as x is y in Python. Add also the Py_IsNone(), Py_IsTrue(), Py_IsFalse() functions to test if an object is, respectively, the None singleton, the True singleton or the False singleton. (Contributed by Victor Stinner in bpo-43753.)

Should we care about this in e.g. PyAny::is_none? Looks like all those functions do (for now) is forward to a pointer comparison.
Other than that a few functions need implementing in the ffi module, I think.

👍 thanks, I'll put together a PR for the ffi changes shortly.

It needs that field added.

I think it's already there: https://github.com/PyO3/pyo3/blob/4a34cc63a67d14397b30d5cc064742a0848a556d/src/ffi/cpython/initconfig.rs#L104-L105

Should we care about this in e.g. PyAny::is_none? Looks like all those functions do (for now) is forward to a pointer comparison.

Good question. I wouldn't be suprised if in the future the singletons might be hidden in the limited API (and need to be fetched by functions)? For now I think we should continue with the pointer comparisons ourselves for performance.


JOSS: Review install guideline

Couple of points to address:

I don't think that you depend on argparse since it is in the standard library.
You should as well mention that you support Python 3.5+
Is there a reason for the package to not work cross-platform. All packages installed with conda should work under MacOS and Windows.
I would remove the install_requires from the setup.py since the opencv package will be installed from pip even if it was installed with conda. You can instead create a requirements.txt for the PyPi folks.
The statement Place the downloaded ... is not correct for all environment and depending of the way that you installed the software.

These issues have been resolved:

removed argparse
it has not been tested cross platform which is why i did not include it
i removed install_requires and replaced it with requirements.txt
fetcher.py function replaces the large file download
can we close?

@glemaitre : can this issue be closed?

@glemaitre, @arokem: I believe this has been adressed, closing.


horizonclient: add support for querying operation endpoint with 'join' parameter

Horizon v0.19 introduces a join parameter when querying for operations. This allows users to get transaction details with operation responses. Will be good to support this

implemented in #1560


Update the substrate-networking Grafana dashboard with latest changes

The changes are already on Parity's Grafana server. This PR just updates the dashboard in the repo.
A list of changes:

Added the Percentage of peers for which we have more than one connection open and Number of authorities discovered by authority-discovery graphs.
We're now hiding the legends when they only show the node name. It's not useful for the legend to indicate that for example node X is in blue when you have 10 other lines with the same blue colour. Hovering the line also shows the node name.
Number of entries in Kademlia k-buckets now shown over time and for each individual node.
Replace the average/min/max system for Kademlia records with a time frame and one line per node.
Rather than number of ongoing queries, now showing the authority-discovery success rate instead.
Many small style fixes, such as resizing and moving graphs, or staircase lines or "nulls as zero" when it makes sense.

As usual I'm not sure if it makes sense to read the JSON itself. This JSON can be imported in Grafana and visualized. It is on Parity's server for whoever has access.

bot merge


feat: Add UsagePulse API, create-only

The usage pulse API at /usage-pulse only accepts POST requests, for only creating records. No payload body is expected either. The object saved contains the currently logged-in user, and the timestamp.

cc @riodeuno


Different label colours

At the moment, all denotations have the same colour. For better readability, the type should define the colour of that denotation.

moodys28
I would like to work on this.

@moodys28 cool! feel free to clone the repo and submit a pullrequest!
I haven't decided on the best approach to this issue yet, but would like something that requires the least amount of configuration when setting up an annotation task. Colours should be applied automatically and should be deterministic (always the same for the same label), so having a "hash function" that maps label to a hex colourcode would be perfect. After that is as simple as changing a few lines where the colour for a denotation element is set:
https://github.com/TimRepke/enno/blob/master/enno/src/js/Enno.js#L431


Consolidate local and remote terminal implementations

High level changes:

Leverage pty host in remote terminals
Share most code between local and remote
Simplify remote channel and have it more closely match local equivalent
Support attach to session in local

Fixes #116467
Fixes #118241

Pushed a change to cancel createProcess if the terminal is disposed mid way through, I think this is why the test was failing. If there are still problems disabling env var relaunch seems like a good idea.


Extract WARC records given a list of URLs

For a feasible list of URLs (max hunderds of thousands) given as a parameter.

For small numbers of URLs, using the CommonCrawl URL index may be most efficient. For larger numbers, inverting the deduping strategy should allow the URL list to be basically unbounded. ie map both URL list and text WARCs using URL as key (and dummy WARCRecord for URL list), then in the reducers.

Yes, for large set of URLs a side-reduce join would do the job at best. Though, so far we have a use case for a small list of URLs, so I'd leave it as a shared-memory parameter for now.

Commit d4a492e

Was failing with java.lang.IllegalArgumentException: Wrong FS: s3://ukp-research-data/xxx.txt, expected: hdfs://ip-172-31-12-117.ec2.internal:8020 due to direct reading from FileInputStream


Unable to access an error message corresponding to your field name Correo.(Anonymous function)

This is my code, its supposed to work:
	$this->form_validation->set_rules([
		[
			'field' => 'username',
			'label' => 'Usuario',
			'rules' => 'required',
			'errors' => ['required' => 'An username is required']
		],
		[
			'field' => 'password',
			'label' => 'Contrasena',
			'rules' => 'required',
			'errors' => ['required' => 'Enter a password']
		],
		[
			'field' => 'email',
			'label' => 'Correo',
			'rules' => [
				'required',
				['check_callable',
					[$this->userModel, 'testFunction[email]']
				]
			],
			'errors' => [
				'required' => 'Enter a email',
				'check_callable' => '{email} already exist!'
			]
		]
	]);

As you can see i'm using the "callbable" method...
https://www.codeigniter.com/user_guide/libraries/form_validation.html?highlight=callback#callable-use-anything-as-a-rule
Of course, since a Callable rule by itself is not a string, it isn’t a rule name either. That is a problem when you want to set error messages for them. In order to get around that problem, you can put such rules as the second element of an array, with the first one being the rule name:
but i don't get the error message :/ why?
help me please, thank you!

You need to know what callables in PHP actually are ... testFunction[email] isn't a valid function; you can't use it like that.
For further questions, please post on our forums instead; this is a bug tracker.


Default use_multicore to true everywhere

Ticket
None
Maybe #15075
Problem description
use_multicore arg has a default value of false. Ideally should be true
What's changed
Setting to true, running tests, checking if everything is alright.
Can't see why this can go bad, maybe will learn something.
Checklist

[ ] Post commit CI
[ ] Blackhole Post commit
[ ] Nightly fast dispatch
[ ] Model regression CI testing passes (if applicable)
[ ] Device performance regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

yes please :)

could you run single chip perf as well considering how much these ops are used.


Update bookinfo sample to propagate Datadog headers

This updates the productpage, reviews and details apps in bookinfo to also propagate the headers used by Datadog for distributed tracing.
The largest change is in the reviews Java app, to pass fewer parameters in the getRatings function, instead of one for each header.
Minor change to the build scripts to add an image prefix parameter.
The default naming is istio/examples-bookinfo-* which I am unable to push to.
With the optional prefix in the build_push_update_images.sh script, I can run with a prefix that I am permitted to push to, eg: build_push_update_images.sh 1.14.0 cgilmour -> images named cgilmour/examples-bookinfo-*.
The default behavior works the same as before.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cgilmour
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vadimeisenbergibm
If they are not already assigned, you can assign the PR to them by writing /assign @vadimeisenbergibm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @cgilmour. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@cgilmour: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
d5641786a96f98fa36995d7030540ed4d6e46e6d
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

 Will try a retest:
/test istio_auth_sds_e2e-master

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cgilmour
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu
If they are not already assigned, you can assign the PR to them by writing /assign @frankbu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgilmour: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/shellcheck.sh
26d19a936cf04485d15ad835b8725f805890e0e8
link
/test istio-shellcheck-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgilmour: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
dd55651241883ebf45828887ff5c30e7cd2ebe86
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-racetest-master

Rebased and made changes requested in review.

Could you rebase again? It seems like there's a conflict.

Rebased. Had to redo things in build_push_update_images.sh since it changed a lot in a recently merged PR.

@cgilmour: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
a2659f8d0f67d8cf29773625dbe8f99718ce17b4
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgilmour: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
a2659f8d0f67d8cf29773625dbe8f99718ce17b4
link
/test istio-racetest-master

prow/integ-istioctl-k8s-presubmit-tests.sh
a2659f8d0f67d8cf29773625dbe8f99718ce17b4
link
/test integ-istioctl-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgilmour: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
a2659f8d0f67d8cf29773625dbe8f99718ce17b4
link
/test istio-racetest-master

prow/integ-istioctl-k8s-presubmit-tests.sh
a2659f8d0f67d8cf29773625dbe8f99718ce17b4
link
/test integ-istioctl-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
a2659f8d0f67d8cf29773625dbe8f99718ce17b4
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@venilnoronha @frankbu can you take a look or assign another reviewer? Not sure who else is familiar with the samples

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cgilmour, venilnoronha
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [venilnoronha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest


Simplify the remove-then-add process when toggle modes in Toggle between feature request modes sample

https://github.com/Esri/arcgis-runtime-samples-ios/blob/087693cc975b06a1b17d6acba394813b4fcf971f/arcgis-ios-sdk-samples/Features/Toggle between feature request modes/ToggleFeatureRequestModesViewController.swift#L115
Please see Rachael's comment in common-samples/pull/3104 .

Close due to inactivity.


[Snyk] Upgrade eslint-plugin-import from 2.29.0 to 2.29.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade eslint-plugin-import from 2.29.0 to 2.29.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-12-14.

Release notes

Package name: eslint-plugin-import

2.29.1 - 2023-12-14Full Changelog: v2.29.0...v2.29.1

2.29.0 - 2023-10-23Full Changelog: v2.28.1...v2.29.0

    from eslint-plugin-import GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@lkduerig , okay so this is causing some problems. When you're on the hdbt_subtheme folder and run npm install,
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin"} (current: {"os":"linux"})
npm ERR! notsup Valid os:  darwin
npm ERR! notsup Actual os: linux

This is the error that I discussed earlier, that the fsevents runs only on Mac environments and not on Linux.

Decided to close obsolete Snyk PRs and run again


Add yaml contributors

@kabahima Please signe fb CLA at https://code.facebook.com/cla.

@kabahima This PR has conflicts! can you please fix them ?

@kabahima great PR!
Please solve the conflicts to that we can have it merged soon.
Thank you for your contribution.


Remove redundant go.mod file in /prow directory

The prow/go.mod file is identical to the one at the top level folder.

/cc @airbornepony @cjwagner @listx

Can you explain why the files are present in test-infra, and why it is okay to remove them in this repo? Thanks.

You mean the go.mod is the same as those in test-infra?

Can you explain why the files are present in test-infra, and why it is okay to remove them in this repo? Thanks.

You mean the go.mod is the same as those in test-infra?

There are files with the same name and location (beside the "prow" direcotory) in test-infra. I don't know if they have the same content. In any case, I want to know why the files are there--how they came to be.
Were they created by running certain tools? Will they come back when they are run again?

The prow/go.mod file is identical to the one at the top level folder.

Looks like you added these redundant files in https://github.com/kubernetes-sigs/prow/pull/70. Instead of creating a new commit like this, I suggest you close this PR and revert #70. That way the context is preserved and it will be simpler to review (reviewers need context to review PRs effectively --- please keep this in mind).

The prow/go.mod file is identical to the one at the top level folder.

Looks like you added these redundant files in #70. Instead of creating a new commit like this, I suggest you close this PR and revert #70. That way the context is preserved and it will be simpler to review (reviewers need context to review PRs effectively --- please keep this in mind).

Created a revert: #81


ad-hoc multi-hop problem

i was trying build a simple ad-hoc network by mininet-wifi
that Emulator give a example ad-hoc environment like below:
sta1 <---> sta2 <---> sta3
these three all use ad-hoc to communication
and i run the SDN controller on sta1,
SDN client on sta1, sta2 sta3
Neighbors can communicate correct
sta1 <---> sta2
sta2 <---> sta3
but sta1 can't "find node" sta3
i thought SDN client will spread neighbor message to around neighbor may like:
sta1 "find node"
sta2 receive message by sta1, check TTL>0, send to sta3
sta3 response message
Did i understand wrong? How can i fix it :'c

I re-read the paper found some keywords about this case

Dispatch manages broadcast packets as follows:
b) if TTL>0, it gathers the set of neighbors from Heartbeater and then sends the packet to any neighbor, except for nodes in the same subnet of the sender.

so i need to set the previously sta2 ip cross the subnet
one NIC is sta2-wlan0 ip=<IP_ADDRESS>/24
another NIC is sta2-wlan1 ip = <IP_ADDRESS>/24
and modify sta3 ip address to <IP_ADDRESS>/24
it will be work!

Hi @u284976,
thank you for your interest, you're right about the second post. Ramp works with the assumption that multi hop paths are composed of subnets with different address spaces.
So sta1 and sta2 should be connected with a subnet different from the one that connects sta2 and sta3. To do that sta2 must use 2 different NICs.
Feel free to ask for any kind of doubt and also in case you'd like to collaborate with us in the development of Ramp or for any reasearch activity.
Best regards,
Dmitrij

Hi @davidMonnuar ,
Thank you for your kind description.
Regards,
Y.T. Chen

Hi @davidMonnuar ,
I have some new problems want to ask, and I added a Issue


Update auth0 example

WIP, Need to bring a form to show the dynamic tenant/product setting.

Would be good to have a .env.example file @niwsa


CI: try to avoid the pip failure on python 3.5 on TravisCI

At least I can replicate the error locally with pip 8.1.2 on master and with this change pip install wheelhouse succeeds locally.
Other than that, I've no clue what I'm doing.

See https://github.com/scipy/scipy/pull/6313


fix text on wrap page

removing this

superceded by https://github.com/OlympusDAO/olympus-frontend/pull/955


[QUESTION] ordering by roomSidebarList

As we know we have some channels and direct messages on sidebar, I'm trying to know how can i use order by when fetch data from database by date to sort them when listed on siderbar?

you can sort room list according to your sorting order,just change your logic in method sortRoomList() in class RoomListAdapter .

This issue is no longer valid for 2.0.0.


GeoAdmin widget incorrectly rendering geometry

The OpenLayersWidget we are using in the admin view of the geo Django models is incorrectly rendering geometry. I suspect this is a simple coordinate issue where we need to transform the geometry before passing it to the model admin widget:
https://user-images.githubusercontent.com/22067021/117475485-5761c300-af19-11eb-97b5-7cd8e29bf14c.mov

This is only an issue when the widget is a admin.StackedInline

I believe this to be an upstream issue. We should report the bug upstream where appropriate and close this

@venkatabhishek, would you be able to help write a bug report for this. I can help you create a minimally working example somewhere if needed.
We can follow the instructions here: https://docs.djangoproject.com/en/dev/internals/contributing/bugs-and-features/

Option 2: https://stackoverflow.com/questions/32037375/geodjango-can-i-use-osmgeoadmin-in-an-inline-in-the-user-admin


PHP Support

Suggestion: Add support for PHP.
The OpenTelemetry PHP package is more complete than Python's or Go's, the community is larger than Python's or Go's (though Python has  more mindshare), and the number of competitors that support PHP tracing is tiny (erm, that lack of mindshare hurts).
If you are looking to tap into a latent but powerful market with relative ease - add support for tracing PHP!

Hi @SamGoody - huge fan of PHP myself, it was my first programming language on the web :)
We support all OpenTelemetry traces as long as they're compliant with the standard, and it should be language agnostic! Can you share any issues you ran into setting up the PHP OpenTelemetry SDK and forwarding traces to HyperDX? Would love to know if there's something PHP-specific we're missing there!

I have not tried.
I saw you on HN and figured I would check it out.
(My only past experience was with Sentry, and that a pretty limited attempt.)
On your webpage there was nothing hinting at support beyond what was listed - so I left the comment and moved on.
I suggest you add that you support PhP and other languages that use in to OpenTelemetry.
I won't be able to test over the next few weeks, but will check it out afterwards.
Thank you.

@MikeShi42 is a sdk support coming for php (ideally a laravel package).
We would be interested in something like this and moving away from new relic/sentry


fix(apiserver): getAvailableDiskCapacity found a empty capacity

What this PR does / why we need it:
fix(apiserver): getAvailableDiskCapacity found a empty capacity.In the original code,it find the disk.CapacityBytes when GetLocalStorageNode return the localstoragenode with an error(e.g. localstoragenode not found), so need to change the logic to find the disk.CapacityBytes when the GetLocalStorageNode return localstoragenode with no errors.
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d2bc890) 36.47% compared to head (2197197) 36.47%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1274   +/-   ##
=======================================
  Coverage   36.47%   36.47%
=======================================
  Files          28       28
  Lines        2218     2218
=======================================
  Hits          809      809
  Misses       1306     1306
  Partials      103      103

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Can you have a look ?@peng9808


Feature request : Security serialization/revert

Hi,
I've been using Unicorn in my latest Sitecore implementation and it's been a great help.
One thing I'd love to see added though is a means to serialize and revert specific domains, roles and users with Unicorn.
Typically I leave the Sitecore domains and roles alone, but for most projects I usually add a domain for the project and some roles for them, and also include those roles into my source control.
Sitecore serializes those into a \serialization\security\ folder.
It would be cool if the Unicorn serialization.config would
%lt;include database="security" path="/xyz/Roles/ContactRole" /%gt;
%lt;include database="security" path="/xyz/Roles/LeadRole" /%gt;
%lt;include database="security" path="/xyz/Users/CustomerAdminUser" /%gt;
Kind regards,

Hi Kamsar,
Just wanted to know , the new functionality got implemented in new version of Unicorn

Nope. It's not there yet.
On Thu, Nov 5, 2015 at 2:19 AM amitthakur2014<EMAIL_ADDRESS>wrote:

Hi Kamsar,
Just wanted to know , the new functionality got implemented in new version
of Unicorn
—
Reply to this email directly or view it on GitHub
https://github.com/kamsar/Unicorn/issues/30#issuecomment-154018528.

I don't think serialisation of security related information belongs in Unicorn, just my 2 cents. Changes to users/roles happen so infrequently in a project life cycle, managing process around this is not really a prime candidate choice for automation.

I disagree.  It is serializeable sitecore content that your code can depend
on.
For instance if you want to add user registration/authentication on your
site by using Sitecore users in a specific domain.  You will want to
serialize that domain and add it to your source control, so you can deploy
the code and the sitecore items including the domain that go with your code.
On Fri, Dec 11, 2015, 10:11 AM Mark Cassidy<EMAIL_ADDRESS>wrote:

I don't think serialisation of security related information belongs in
Unicorn, just my 2 cents. Changes to users/roles happen so infrequently in
a project life cycle, managing process around this is not really a prime
candidate choice for automation.
—
Reply to this email directly or view it on GitHub
https://github.com/kamsar/Unicorn/issues/30#issuecomment-163882261.

Serialization of users, absolutely not.
Serialization of roles, I think makes sense.
Suppose you have a very multi site solution where each site has its own
roles, or devs are defining workflows and need to push dependent security
roles for the steps and transitions.
It is a totally separate concern from regular unicorn though as roles are
just a string and not an item. That's why this has sat on the shelf for so
long. New infrastructure for everything.
On Fri, Dec 11, 2015 at 1:35 AM el-slowmo<EMAIL_ADDRESS>wrote:

I disagree. It is serializeable sitecore content that your code can depend
on.
For instance if you want to add user registration/authentication on your
site by using Sitecore users in a specific domain. You will want to
serialize that domain and add it to your source control, so you can deploy
the code and the sitecore items including the domain that go with your
code.
On Fri, Dec 11, 2015, 10:11 AM Mark Cassidy<EMAIL_ADDRESS>wrote:

I don't think serialisation of security related information belongs in
Unicorn, just my 2 cents. Changes to users/roles happen so infrequently
in
a project life cycle, managing process around this is not really a prime
candidate choice for automation.
—
Reply to this email directly or view it on GitHub
https://github.com/kamsar/Unicorn/issues/30#issuecomment-163882261.

—
Reply to this email directly or view it on GitHub
https://github.com/kamsar/Unicorn/issues/30#issuecomment-163886874.

My opinion is that we should be able to serialise and version control everything if you wish to do so. This includes roles and users.
Naturally it's not sound to version control production users (or content for that matter) but for e.g. regression test purposes it is vital that you can store and version control complete environment configurations.

There's no way to serialize users' passwords (or even the hashes thereof without direct SQL calls) which makes serializing users a bit pointless imo, as any deserialized user would only really be usable by a UserSwitcher or something as the password would not be moved.

Good point. A file based membership provider could be the way to go for the automated test scenario.

On 12 Dec 2015, at 8:29 AM, Kam Figy<EMAIL_ADDRESS>wrote:
There's no way to serialize users' passwords (or even the hashes thereof without direct SQL calls) which makes serializing users a bit pointless imo, as any deserialized user would only really be usable by a UserSwitcher or something as the password would not be moved.
—
Reply to this email directly or view it on GitHub.

While there may be a case for security information serialisation, I still don't see this as the job of Unicorn. It deals with Sitecore content in Sitecore databases. Membership data is neither content, nor does it sit in Sitecore databases.
A new tool, possibly as @Eldblom suggests; file based membership, profile, and role providers - sure. Would be reasonably easy to implement as well. Or grab an existing one:
https://github.com/wilby/XmlMembershipProvider

Moving this conversation to #107


Feature Request: Aurora/Data API Simulation

Is your feature request related to a problem? Please describe.
I am looking to build out an application using App Sync and the Aurora Serverless.
From what I have read in the resolver tutorial the VTL for Aurora Serverless statements is really simple, but it's not clear how this could be run offline.
From what I can tell looking over this library it seems to focus around support for DynamoDB.
Describe the solution you'd like
I would like to be able to point at a local MySQL or Postgres database and have the appsync simulator run statements against that.
Describe alternatives you've considered
I am still in the initial investigation of AWS and AppSync in general so I don't personally have a lot of context into this as of yet.
I would love to hear feedback from others on possible solutions to this.

Thank you @wSedlacek for this feature request.
Adding support for Aurora would be great. It would be definitely possible to point to a local Mysql/Postgres db.
I do not have any experience using Mysql/PostGres with AppSync (or node.js), though.
The solution is probably to add a DataLoader for RDS, add a config for RDS with the following attributes:

type: mysql/postgres
endpoint
user
password
database name

I'll give it a shot and let you know what happens

Hey, we have the same requirement, I'll also put some effort on this 💪

Seems this was solve by https://github.com/bboure/serverless-appsync-simulator/pull/110


About preprocess code

Is there any preprocess code(like sub-graph sampling or gt sub-graph extraction) that you can share with us?
Thanks a lot!!

Can you share the code of sub-graph sampling or sub-graph extraction? Thanks a lot!

Thanks for your interest in our work!
We'll release

Thanks for your interest in our work!
We'll try to get the preprocessing code released after CVPR.

感谢您对我们的工作的关注！
我们将尝试获取CVPR之后发布的预处理代码。

Thanks for your interest in our work!
We'll try to get the preprocessing code released after CVPR.
Thanks for your great work! In your paper Table 3, Sub-GC-oracle is an upper bound by assuming that we have an oracle ranking function, i.e., always selecting the maximum scored sentence for each metric.  How do you solve it in your code? Thanks a lot!

Please refer to the section "Top-1 Accuracy Evaluation" in README, that is, "set --only_sent_eval to 1 and add --orcle_num 1000 in test.sh, and rerun the bash file".

Yes, The upper bound is promising!!! Can you share the code of sub-graph sampling or sub-graph extraction now? Thanks a lot!

Yes, The upper bound is promising!!! Can you share the code of sub-graph sampling or sub-graph extraction now? Thanks a lot!

hi, thanks for the sharing, I had some problems about generating caption with this code:
Traceback:
../ data Loaders/dataloader_test.py", line 198, in get_ batch
data['att_ masks'] = tmp_ att_ mask. view(-1,2, tmp_ this_ mini_batch, self .obj_ num)
RuntimeError: cannot reshape tensor of 0 elements into shape [-1, 2, 0, 37] because the unspecified dimension size -1 can be any value and is ambiguous
An error is generated every time when the caption for the NO.100432 image is generated.
Looking forward to your reply!

Hi, can we get the preprocessing code for sub-graph sampling? Also, I'd like some insights into getting custom images captioned with this code. I know there is an option for custom image captioning in the evaluation script but it does not have the accompanying code to produce it. Any help would be appreciated.

Hi @YiwuZhong ,
Really appreciate your work and making the code available. Can you kindly also make the preprocessing scripts available as well. It would be great if you could provide some insights on how we could re-train the model on a custom dataset.

Hi, is available somewhere the code to produce scene graphs from a set of images? In case we want to use your model on other datasets that is not COCO or Flickr. If not yours, could you explain how you produced them?
Thank you very much in advance!

Hi @AleDella, thanks for your interests in our work.
As mentioned in the Implementation Details of paper, we first used Bottom-up object detector to detect objects from images and to extract region features. Using these region features as inputs, Motif-Net was trained to generate scene graphs from images. This is the model checkpoint of Motif-Net I trained and used to generate scene graphs. As a reference for saving scene graphs into local files, you might be able to use my script to replace the original file in Motif-Net codebase with some adaption as needed.
PS: There is another codebase for Bottom-up object detector to extract region features (bottom-up-attention.pytorch). This is my work for scene graph generation with image captions as only supervision (SGG_from_NLS).


Also look for 'fdfind' executable

This makes +ivy--counsel-file-jump-use-fd-rg-a also search for the fdfind
executable, and not only fd. (On debian its called 'fdfind'.)

Did it. works as expected.

Great! Thanks again!


Update auth.py

Slight rewording/typo fix about accidently leaking your auth data, not really worthy of a new update lol, just added to a planned release.

I'd prefer if you kept everything should be fine. since changing password doesn't update existing device auths to new credentials, it just invalidates old ones.

I'd prefer if you kept everything should be fine. since changing password doesn't update existing device auths to new credentials, it just invalidates old ones.

I agree to a point, however leaving "everything should be fine" isn't the best thing you wanna read, especially for more sophisticated applications. Up to you, maybe rewording it to say something like "resetting your password will not update anything, it just invalidates past device auth data." Basically exactly what you said. Hope that sounds better.

yeah i like this more than the original thanks


[WIP] imake: only use tradcpp on Darwin

Motivation for this change
Fixing x11_ssh_askpass on aarch64, see hydra failure.
For reasons I don't understand, when building with tradcpp as the IMAKECPP, the aarch64 build passes LinuxMachineDefines where it should pass -D__aarch64__.
This change was introduced in 613e262fc2f84d068da40ee6c45f0915c00e2193, cc @matthewbauer as the author.
Good:
building
build flags: SHELL=/nix/store/bsb6596kk4fp20hyl9yl55xwv1ax4b6s-bash-4.4-p23/bin/bash
gcc -O2 -fno-strict-aliasing      -I/nix/store/xisa9pqa1706nqiprscnp4qgvkqqysg8-xorg-cf-files-1.0.6/include    -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L                          -D_POSIX_SOURCE -D_XOPEN_SOURCE                                 -D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64                                                                   -DFUNCPROTO=15 -DNARROWPROTO       -c -o drawing.o drawing.c
...

Bad:
building
build flags: SHELL=/nix/store/bsb6596kk4fp20hyl9yl55xwv1ax4b6s-bash-4.4-p23/bin/bash
gcc -O      -I/nix/store/xisa9pqa1706nqiprscnp4qgvkqqysg8-xorg-cf-files-1.0.6/include    -Dlinux LinuxMachineDefines -D_POSIX_C_SOURCE=199309L                          -D_POSIX_SOURCE -D_XOPEN_SOURCE                                 -D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64                                                                   -DFUNCPROTO=15 -DNARROWPROTO       -c -o drawing.o drawing.c
gcc: error: LinuxMachineDefines: No such file or directory

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks! I think this looks okay... The main reason for using tradcpp everywhere is so that we have some consistency between Darwin & Linux - if it breaks on one it will be more likely to break on the other. But, if this fixes something, it looks like a good idea.

I have an idea: #51585

I like your idea! It builds for me on aarch64. Let’s go with that instead.


KubeArmor: eventAuditor: update Makefiles for CGO compilation

This also updates go.mod and go.sum.
Fixes: #269

I think the main Makefile deserves a refactoring, related to the rules and recipes. Let's also discuss to where we could move the eventAuditor/libbpf, as it must be used later throughout the project.


.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

no way


当我make的时候出现该错误，无论是从源码安装还是在docker内安装

完全按照源码安装方式，只更改设置了set(USE_CUDA ON)
Ubuntu20.04，CUDA11.0，cudnn8，python3.8
hnu@hnu:~/ZDS/PRJ/tvm/build$ make -j16
Scanning dependencies of target project_libbacktrace
Scanning dependencies of target tvm_libinfo_objs
Scanning dependencies of target tvm_objs
[  0%] Creating directories for 'project_libbacktrace'
[  0%] Building CXX object CMakeFiles/tvm_libinfo_objs.dir/src/support/libinfo.cc.o
[  0%] No download step for 'project_libbacktrace'
[  1%] No checkout step for 'project_libbacktrace'
[  1%] No patch step for 'project_libbacktrace'
[  1%] No update step for 'project_libbacktrace'
[  1%] Performing configure step for 'project_libbacktrace'
/bin/sh: 1: /home/hnu/PRJ/tvm/cmake/libs/../../3rdparty/libbacktrace/configure: not found
make[2]: *** [CMakeFiles/project_libbacktrace.dir/build.make:109: libbacktrace/src/project_libbacktrace-stamp/project_libbacktrace-configure] Error 127
make[1]: *** [CMakeFiles/Makefile2:114: CMakeFiles/project_libbacktrace.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  2%] Building CXX object CMakeFiles/tvm_objs.dir/src/arith/int_set.cc.o
[  2%] Building CXX object CMakeFiles/tvm_objs.dir/src/arith/detect_linear_equation.cc.o
[  2%] Building CXX object CMakeFiles/tvm_objs.dir/src/arith/bound_deducer.cc.o
[  2%] Building CXX object CMakeFiles/tvm_objs.dir/src/arith/analyzer.cc.o
[  2%] Building CXX object CMakeFiles/tvm_objs.dir/src/arith/const_int_bound.cc.o
[  2%] Building CXX object CMakeFiles/tvm_objs.dir/src/auto_scheduler/auto_schedule.cc.o
......
[ 88%] Building CXX object CMakeFiles/tvm_objs.dir/src/target/opt/build_metal_off.cc.o
[ 88%] Building CXX object CMakeFiles/tvm_objs.dir/src/target/opt/build_rocm_off.cc.o
[ 89%] Building CXX object CMakeFiles/tvm_objs.dir/src/relay/backend/contrib/codegen_c/codegen.cc.o
[ 89%] Building CXX object CMakeFiles/tvm_objs.dir/src/relay/backend/contrib/example_target_hooks/relay_to_tir.cc.o
[ 89%] Building CXX object CMakeFiles/tvm_objs.dir/src/relay/backend/contrib/example_target_hooks/target.cc.o
[ 89%] Building CXX object CMakeFiles/tvm_objs.dir/src/relay/backend/contrib/example_target_hooks/tir_to_runtime.cc.o
[ 89%] Building CXX object CMakeFiles/tvm_objs.dir/src/contrib/hybrid/codegen_hybrid.cc.o
[ 89%] Built target tvm_objs
make: *** [Makefile:130: all] Error 2

Probably you didn't clone submodules. (git clone --recursive).

No, I encounter this problem even if my "3rdparty/libbacktrace/configure" PHYSICALLY EXISTS ON MY HARD DISK.

No, I encounter this problem even if my "3rdparty/libbacktrace/configure" PHYSICALLY EXISTS ON MY HARD DISK.

你好，我解决了这个问题：在clone了该仓库之后，必须单独clone这个第三方仓库：libbacktrace，并覆盖掉tvm下的3rdparty/libbacktrace仓库，最后成功安装的


delete unused files

Nice +1 (if it builds correctly of course)
Looks a lot likte the files I mentioned here #1652 :!

@DickvdBrink, yeah i had that on my todo list since you filled the issue. just took me a while :) Thanks for reporting the issue, and sorry for the delay.


Enable Museum Mode from the API

We're working on giving the mobile app a "museum mode." In this mode, the app would show a single workflow, and users cannot navigate away from this workflow without quitting the app. The workflow will have a Zooniverse banner at the top and will have a dark theme enabled. This will allow museums to let guests work on a specific project.
The app should be the same app as the mobile app, to prevent confusion in the app store with respect to which one to download. However, museum mode should only be accessible to museums, to prevent citizen scientists from accidentally trapping themselves in museum mode on a project.
In order to facilitate these technical requirements, we'd like to allow only specific users to enable museum mode.
We have talked about a few implementation options ("we" being @chelseatroy, @zwolf, @srallen, and @amyrebecca):

Attach a  workflow id to a specific account, so that any login from that account automatically navigates to that workflow
Create a user role for museums, so a museum account can log in and automatically navigate to a designated workflow
Create a user role for museums, so a museum account can log in, manually navigate to a designated workflow, and select museum mode (to only be exited by quitting the app)

We'd love to hear suggestions from others, but we'd like to come to a decision on the implementation by mid-week (Wednesday, July 17) so that @chelseatroy can get started on execution, either mobile side or server side.

@chelseatroy's original suggestion is to add a default-null foreign key (museum_workflow) to users and serialize it. If that attr isn't null on serialized user -> different mobile app behavior. I didn't love the idea of making this a User field at first but everything else (project prefs, wf config, user roles) is more complicated and/or a lot more API calls for what will be less than 10 known cases right now.
First option/instinct may be the best way to go here.

This will allow museums to let guests work on a specific project.

I assume these guests will not be logged in? Or does the project want to track the incoming classifications to a certain 'known' user? Do they want to have extra classification metadata showing the classification came from museum mode? Do they also use that same user but in non-museum mode interfaces as well? Ideally during analysis they can isolate which classification came from which mode for the users.

However, museum mode should only be accessible to museums, to prevent citizen scientists from accidentally trapping themselves in museum mode on a project.

My initial thoughts on this were why doesn't the app hard code known IDs that can activate / deactivate museum mode for different projects? I.e. the app is responsible for handling this UI presentation 'mode' trigger and it's not linked to a user account. These codes can be handed out to the relevant project owners upon request to us.
If the scope of this 'museum mode' will increase and become more complex regarding which projects / workflows get activated and how the app automatically wires up the interface then it's best to avoid the app release changes to handle them and we add the functionality API side.
I can see a user login being the logical choice to isolate the behaviour though I think we need to think how this applies across projects, workflows etc. I.e. should one project be in museum mode vs a different project?
Can the user navigate to a different project in museum mode (i assume not)?
The current domain model doesn't really address these requirements, it may be best to spin up a new API / add a whole new end point that links users and this 'museum mode' behaviour with the required details the app needs to wire itself to the desired museum mode behaviour.
Happy to jump on a call for this as well.

Individual users not logged in, the user could represent the museum/workflow combination and the app UI would only allow classification on that workflow with no navigation possible.
Hard coding project ids was something I also thought of but the deployment process for mobile apps (via Apple/Google) seems convoluted and out of our hands enough that I wasn't convinced. Even with an OTP code-type login, we either still hard code the project/workflow ID in the app or create a new endpoint to retrieve same from the API which would be more trouble than just adding an attr to the user, I think. I haven't heard anything that implies the scope will expand, but that's worth exploring before making a decision. The above solution is pretty simple, though.

Hiya folks. Would like to wrap this up and begin execution today. @zwolf, how do you think we should proceed?

Summary of the proposed solution to the internal discussion. We will use a new 'museum' per project role for a specific user. this will allow the app UI to provide a museum mode button for any project the user has the role on.
Con: This will allow any workflow to have museum mode on it, short term we think that is ok.
Pro: we have all the API mechanics in place to support this and it will be small feature work to add these roles to the lab UI if needed.
Con: Adding roles is manual by a dev team member on the api console now. short term that's ok.

I'm closing this issue now but please re-open if needed / we want to have more discussion.

Summary of the proposed solution to the internal discussion. We will use a new 'museum' per project role for a specific user. this will allow the app UI to provide a museum mode button for any project the user has the role on.
Con: This will allow any workflow to have museum mode on it, short term we think that is ok.
Pro: we have all the API mechanics in place to support this and it will be small feature work to add these roles to the lab UI if needed.
Con: Adding roles is manual by a dev team member on the api console now. short term that's ok.

I'm closing this issue now but please re-open if needed / we want to have more discussion.

Thank you for writing up this summary Cam! I'm sure we'll appreciate the context when we come back to this issue in the future :)


x/pkgsite: show more search results per page or give users a setting for that

When looking for a module or a package,
I will often find what I need on the second
or the third page of the search
results. There are already enough issues
about the quality of the search,
so for now I want to propose
that the search show more results
per page. I think, 100 results per page is
a good number, but that may be too high
and generate too much pressure on the search
engine. But I don't know enough about it,
so this is up to debate.
Perhaps there should also be an option for that,
but if we go with 100 results per page
by default, then I don't think anyone would need
more. 100 is also a sane maximum value
for such setting, in my opinion.

Can you provide some examples of what you searched for and what the expected results were?

@andybons The case that made me file this
issue? Sure! I wanted to share a working
implementation
of a 9P2000
server with a friend. I remembered, that I've
successfully used the one made by Docker,
but that was two or three years ago, so I didn't
remember the package name. I looked up 9p server,
and the first page
didn't provide the one I was looking for,
but the second
page did. It was
package github.com/docker/go-p9p.
There were some other cases before that, but I can't
remember them now. I will add more later if something
like that happens again.
Besides that particular case, I generally prefer long result
lists, because with them I can then press
Ctrl+F and filter them further. Kind of
like a webpage equivalent of grep -e first -- file.txt
| grep -e second.

That’s helpful. Thanks.

See #47315.


Align name and version labels between plugin.xml and package.json

Address #69
Makes name and version number consistent.

Nice

Thanks! Sorry for the delay in response. Can you also change the package lock file to match this as well?


Learning how to assign an Issue

This is my first issue.
Issues may contain bugs, or can also be an enhancement or discussions before starting of any project.

I am done with this introduction part of GitHub. So, closing this issue.


Accessibility: escape HTML entities in screenreader-only messaging

In some messaging for screen readers, possibly extension-specific, the string sent to the ARIA-marked up region isn't getting extraneous HTML entities filtered out which leads to some ...interesting output. Please observe:
choices, choices (iterable): An iterable yielding options; will only be unrolled, Handles fuzzy choice of an attribute. Args:\     choices (iterable): An iterable yielding options; will only be unrolled\         on the first call.\     getter (callable or None): a function to parse returned values, hint

This is coming from the Python extension's typehinting; I don't know if others do this as well or if they are hooking into a VS code-general mechanism. I would expect the latter.
 Much thanks :)
@isidorn this one may be of interest to you.

@zersiax thanks for filling this, I understand the issue, however I can not reproduce it.
Can you share a small python program for which you can reproduce this problem? Just so I try to get it on my machine and investigate more. Thanks!

@zersiax django-based app might also work. Whatever is the easiest for you that you can consistently reproduce. Thanks!

In this repo: https://github.com/zersiax/django-allthefoods
is the code that I initially got the problem in. In the nomspot app's factories.py,  line 16, the problem came up when entering the first parenthesis, it telling me what kind of argument it was expecting. Does that help?

@zersiax I just tried to repro using that issue and I could not.
I believe the screen reader will read just whatever is coming from the python extension. We do not specially message this content.
@brettcannon might you have an idea when would the python extension offer parameter hints which contain non breaking spaces:    &nbsp

@zersiax which language server are you using? Pylance or Jedi?


Mission update during flight is not properly working anymore

It just seemed to stop and wait after the re-upload, need to have a closer look.

I cannot reproduce in gazebo_iris. any special settings?

Don't seem to be able to reproduce this anymore, closing


Support for eventbridge in bucket notifications

Describe the Feature
Hi, is it possible to enable eventbridge on the bucket notifications? At the moment it seems only lambda functions can be specified in current variables.tf
Expected Behavior
Enable eventbridge notifications, i.e.:
 + resource "aws_s3_bucket_notification" "bucket_notification" {
      + bucket      = "[bucket name]"
      + eventbridge = true
      + id          = (known after apply)

Use Case
Some of our users are requesting this feature
Describe Ideal Solution
Add new feature so eventbridge can be used i.e. as described in terraform aws provider link
Alternatives Considered
No response
Additional Context
No response

thanks !


Try to distribute a binary

Let's try to use https://github.com/openresty/lua-nginx-module#statically-linking-pure-lua-modules and repackage openresty with Kong inside for the most popular platforms. This way we just have a binary to distribute: kong and we could run it via /bin/kong-cli for example.
Other platforms will just have to run the build process.

@mschurenko is working on creating RPM and DEB packages that will improve the way Kong can be installed. We'll take this as the first step and investigate other ways of distributing the software including investigating binary releases.
Regarding installations of Kong though the RPM or DEB packages, should we move the configuration file to /etc/kong.ymland the output to /var/log/kong/? @thibaultCha @mschurenko

With #88, there is no need to do this anymore since we simplified the install process to leverage luarocks and include a binary executable (lua script).


active backup directory has to be renamed each time manually

The first two times it worked correctly. After checking, I renamed the target folder name and since then at each automatic backup the following error message comes and I have to rename the folder manually:

I have set the Keep x backups option to 7.

Please try a other destination as your Dropbox folder. Possible because dropbox is uploading files and has a lock on this files the rename is not possible.

Thanks Jack for the tipp. I changed the backup destination to a local folder. Now it works well, both automatic and manual backup.

Issue can be closed, I got the right tipp from Jack. It was not a bug of the backup plugin.

You can try to setup Temporary export path to a local folder and the Backup Path to your dropbox folder.
Than only the finished contend is copied and possibly this makes then no problems.