migration from version 2.9.0 doesn't work

I want to update Defectdojo from v 2.9.0 to the latest.

I'm backup MySQL DB.
./dc-stop.sh
docker pull defectdojo/defectdojo-django:latest
./dc-up-d mysql-rabbitmq
Got the latest version, but I can't enter to system_settings - Server Error (500)

django-defectdojo-initializer-1  | Initializing.
django-defectdojo-initializer-1  | [30/Sep/2022 11:49:59] INFO [dojo.models:4056] enabling audit logging
django-defectdojo-initializer-1  | Waiting for database to be reachable
django-defectdojo-initializer-1  | Making migrations
django-defectdojo-initializer-1  | [30/Sep/2022 11:50:02] INFO [dojo.models:4056] enabling audit logging
django-defectdojo-initializer-1  | No changes detected in app 'dojo'
django-defectdojo-initializer-1  | Migrating
django-defectdojo-initializer-1  | [30/Sep/2022 11:50:09] INFO [dojo.models:4056] enabling audit logging
django-defectdojo-initializer-1  | Operations to perform:
django-defectdojo-initializer-1  |   Apply all migrations: admin, auditlog, auth, authtoken, contenttypes, django_celery_results, dojo, sessions, sites, social_django, tagging, watson
django-defectdojo-initializer-1  | Running migrations:
django-defectdojo-initializer-1  |   Applying auditlog.0010_alter_logentry_timestamp... OK
django-defectdojo-initializer-1  | Traceback (most recent call last):
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
django-defectdojo-initializer-1  |     return self.cursor.execute(sql, params)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/mysql/base.py", line 73, in execute
django-defectdojo-initializer-1  |     return self.cursor.execute(query, args)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 206, in execute
django-defectdojo-initializer-1  |     res = self._query(query)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 319, in _query
django-defectdojo-initializer-1  |     db.query(q)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/MySQLdb/connections.py", line 254, in query
django-defectdojo-initializer-1  |     _mysql.connection.query(self, query)
django-defectdojo-initializer-1  | MySQLdb.OperationalError: (1022, "Can't write; duplicate key in table '#sql-1_14'")
django-defectdojo-initializer-1  |
django-defectdojo-initializer-1  | The above exception was the direct cause of the following exception:
django-defectdojo-initializer-1  |
django-defectdojo-initializer-1  | Traceback (most recent call last):
django-defectdojo-initializer-1  |   File "manage.py", line 11, in
django-defectdojo-initializer-1  |     execute_from_command_line(sys.argv)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/core/management/init.py", line 419, in execute_from_command_line
django-defectdojo-initializer-1  |     utility.execute()
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/core/management/init.py", line 413, in execute
django-defectdojo-initializer-1  |     self.fetch_command(subcommand).run_from_argv(self.argv)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 354, in run_from_argv
django-defectdojo-initializer-1  |     self.execute(*args, **cmd_options)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 398, in execute
django-defectdojo-initializer-1  |     output = self.handle(*args, **options)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 89, in wrapped
django-defectdojo-initializer-1  |     res = handle_func(*args, **kwargs)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/core/management/commands/migrate.py", line 244, in handle
django-defectdojo-initializer-1  |     post_migrate_state = executor.migrate(
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/migrations/executor.py", line 117, in migrate
django-defectdojo-initializer-1  |     state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/migrations/executor.py", line 147, in _migrate_all_forwards
django-defectdojo-initializer-1  |     state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/migrations/executor.py", line 230, in apply_migration
django-defectdojo-initializer-1  |     migration_recorded = True
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/base/schema.py", line 118, in exit
django-defectdojo-initializer-1  |     self.execute(sql)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/base/schema.py", line 145, in execute
django-defectdojo-initializer-1  |     cursor.execute(sql, params)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 66, in execute
django-defectdojo-initializer-1  |     return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
django-defectdojo-initializer-1  |     return executor(sql, params, many, context)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
django-defectdojo-initializer-1  |     return self.cursor.execute(sql, params)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/utils.py", line 90, in exit
django-defectdojo-initializer-1  |     raise dj_exc_value.with_traceback(traceback) from exc_value
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
django-defectdojo-initializer-1  |     return self.cursor.execute(sql, params)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/django/db/backends/mysql/base.py", line 73, in execute
django-defectdojo-initializer-1  |     return self.cursor.execute(query, args)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 206, in execute
django-defectdojo-initializer-1  |     res = self._query(query)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 319, in _query
django-defectdojo-initializer-1  |     db.query(q)
django-defectdojo-initializer-1  |   File "/usr/local/lib/python3.8/site-packages/MySQLdb/connections.py", line 254, in query
django-defectdojo-initializer-1  |     _mysql.connection.query(self, query)
django-defectdojo-initializer-1  | django.db.utils.OperationalError: (1022, "Can't write; duplicate key in table '#sql-1_14'")
django-defectdojo-initializer-1  |   Applying dojo.0157_vulnerability_reference...Admin user: admin
django-defectdojo-initializer-1  | [30/Sep/2022 11:50:13] INFO [dojo.models:4056] enabling audit logging
django-defectdojo-initializer-1  | Admin password: Initialization detected that the admin user admin already exists in your database.
django-defectdojo-initializer-1  | If you don't remember the admin password, you can create a new superuser with:
django-defectdojo-initializer-1  | $ docker-compose exec uwsgi /bin/bash -c 'python manage.py createsuperuser'
django-defectdojo-initializer-1  | Initialization of test_types
django-defectdojo-initializer-1  | [30/Sep/2022 11:50:14] INFO [dojo.models:4056] enabling audit logging
django-defectdojo-initializer-1  | Creation of non-standard permissions
django-defectdojo-initializer-1  | [30/Sep/2022 11:50:17] INFO [dojo.models:4056] enabling audit logging
django-defectdojo-initializer-1  | [30/Sep/2022 11:50:18] INFO [dojo.management.commands.initialize_permissions:28] Non-standard permissions have been created

I have the same problem... I migrated from version 2.6 to 2.13 without problem... but when I go from 2.13 to 2.14 it generates this error 500 when I want to see the findings... it is strange it is as if something had changed in that part of the database...

I have the same problem... I migrated from version 2.6 to 2.13 without problem... but when I go from 2.13 to 2.14 it generates this error 500 when I want to see the findings... it is strange it is as if something had changed in that part of the database...

I guess this release so so old that this issue is deprecated @mtesauro

Closed as stale


Show "Library XYZ: Coming Soon" tiles

On the main index page, it would be useful if we showed a tile for libraries that are coming soon. The tiles would be the same size/shape as the current library tiles, but they could be grayed out. Clicking a contribute icon on the tile could link you to a the repo for that work-in-progress library.
Thoughts?

I like the idea! :+1:

Totally. Great idea because, in fact, some awesome libraries are coming.

@rafaparadela That's exactly how I had this "idea"!
@israelperezglez Any idea how difficult it would be to get a "coming soon" tile design?

Is easy. Tomorrow I will coordinate with @jorgegalindocruces or @raulraja for implement this idea ;)


⚠ SolarOscp has degraded performance

In 9c9e321, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 227 ms

Resolved: SolarOscp performance has improved in e28ad67 after 9 minutes.


Nick: Watch cottonconnection.com

Nick requests the watch of the watch_keyword cottonconnection\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

cottonconnection\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


can i use it with react-redux  or  it will support redux？？

my project use v3 with redux，but i want upgrade to v4. i find it can`t work with react-redux.so,i have a question,v4 can support redux by some other method?????

v4 (latest 4.0.0-beta.15) provides full redux support (v3 provided partial, 'read-only' support, it was not possible to provide external redux state). PR about new integration is welcome. For now check #2115 and rnrfSample repo provided there.

thank u


Suggestions for data2spike

Hi Tom,
I think the script is very well done!  I have made some minor changes in the script.
Please find below some suggestions:

Make the design table compatible with our other design tables (i.e. no spike column).
Rather, add column names or a regex for selecting the columns to be "spiked" (default is all?).
This way users need not create separate spike design file.

Rename. "Data" is too generic, spike too specific. counts2counts? The script runExpression.py
is going that way as well. Additional operations on counts tables are filtering or other transformations.

Best wishes,
Andreas

data2spike.py now takes a standard format design table (as per runExpression.py). A seperate issue has been raised to merge data2spike.py and runExpression.py into counts2counts.py


Draft bases on load

[ ] make all tiles neutral at start
[ ] Show whose turn it is when the game starts
[ ] let that player draft a base
[ ] let the next player draft the next two bases
[ ] let the first player draft the fourth base

With the small initial tile set it's not actually possible to place 4 bases according to the "no orthogonal adjacency" rule, so also make it so the base drafting responds to configuration of how many bases each player should get

Why you gotta be like that actions bot


fetch api &  image

fetch api &  image

fetch image url

https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Checking_that_the_fetch_was_successful

    fetch("http://example.com/movies.json")
    .then(function(response) {
        return response.json();
    })
    .then(function(myJson) {
        console.log(myJson);
    });

    //  https://cdn.xgqfrms.xyz/logo/icon.png
    fetch("http://example.com/flowers.jpg")
    .then(function(response) {
        if(response.ok) {
            return response.blob();
        } else {
            throw new Error('Network response was not ok.');
        }
    }).then(function(myBlob) {
        var objectURL = URL.createObjectURL(myBlob);
        myImage.src = objectURL;
    }).catch(function(error) {
        console.log('There has been a problem with your fetch operation: ', error.message);
    });

canvas & image
https://stackoverflow.com/questions/164181/how-to-fetch-a-remote-image-to-display-in-a-canvas

https://cloudinary.com/documentation/fetch_remote_images
https://www.quora.com/How-do-I-fetch-image-from-a-MySQL-database-in-PHP

https://medium.com/front-end-hacking/fetching-images-with-the-fetch-api-fb8761ed27b2
https://scotch.io/tutorials/how-to-use-the-javascript-fetch-api-to-get-data
http://techstream.org/Bits/Uploading-Image-using-fetch-api
https://stackoverflow.com/questions/164181/how-to-fetch-a-remote-image-to-display-in-a-canvas
https://davidwalsh.name/fetch

css3 & linear-gradient

background

https://www.w3schools.com/css/css3_gradients.asp
https://developer.mozilla.org/en-US/docs/Web/CSS/linear-gradient
https://css-tricks.com/snippets/css/css-linear-gradient/
https://css-tricks.com/css3-gradients/

Content-Type: image
https://msdn.microsoft.com/en-us/library/ms527550(v=exchg.10).aspx

image placeholder
https://placeholder.com/


Set fast compaction as default compaction performer for cross space compaction and unseq space compaction

Set performer to read_point and read_chunk in CompactionSchedulerTest, because there is already existed CompactionSchedulerWithFastPerformerTest.


feat(libify): added the ability to use as library

Current coverage is 42.50% (diff: 0.00%)

Merging #29 into master will decrease coverage by 1.57%

@@             master        #29   diff @@
==========================================
  Files            16         18     +2
  Lines           431        447    +16
  Methods          76         76
  Messages          0          0
  Branches         79         79
==========================================
  Hits            190        190
- Misses          241        257    +16
  Partials          0          0

Powered by Codecov. Last update 148904c...3b265fe


Why does GHC sometimes print Type and sometimes *?

This is an uber-detail but such things tend to block me from learning stuff. Referring to the docs, section on Plutarch Types. Will add it myself if I know the answer, thank you.
Also, if I am misusing github with this issue please correct me. Thank you.

This has nothing to do with Plutarch but rather with GHC. By default GHC shows the kind Type as *, but it doesn't if -XNoStarIsType is enabled, then it prints it as Type. You want to look at whether -XNoStarIsType is enabled in your repl/ cabal file/ at the top of the module.


Create All programming books for free

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
   All programming books under one roof. And the best thing is that it's available free in pdf format.
   So grab any book you want and achieve another milestone of yours.

Why is this valuable (or not)
How do we know it's really free?
For book lists, is it a book?
Checklist:

[ ] Not a duplicate
[ ] Included author(s) if appropriate
[ ] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

Please read CONTRIBUTING.md guidelines


Blog List pagination appears to be broken in Grav v1.7.15

[Apologies.  I originally posted this in the grav-plugin-admin project, as I am typically in Grav Admin and just click the link at the bottom which reads "Found an issue? Please report it on GitHub."  I keep forgetting each piece is separate.  So hopefully this is right right place for this.]
Subject line says it all. Using my site as an example, I have 7 posts. The Blog List page is configured to show 5 posts. And it does. And that's it. No next/previous buttons at the bottom of the page. Even though it has pagination enabled.
If you drill down into a blog post itself, you do then see next/prev buttons. In my case I have things ordered by date in descending order, so if you click the bottom-most post, you can then get to the 6th post by clicking the [Previous] button.
To be clear, this was not the way it was the last time I looked. I've only been using Grav since v1.7.10, but this was working earlier.

Never mind.    I thought pagination was built-in.  Didn't realize 'til I pulled down the Gantry5/Helium skeleton and ran it side-by-side with my own site.  Took awhile, but eventually noticed that the skeleton had a Pagination plugin. 🤦♂
Added that, and all's as I expect now.  My bad.  Sorry to bother you all.


Add post-processing to MovieLens data generation

Adds a post-processing script to produce the data as a user/item/rating csv file.
Fixes bug in run_expansion.py
Adds requirements.txt

Why is there such an exhaustive requirements.txt? This would be rather disruptive to install in an existing environment (since the packages are pinned as == rather than >=), and github is complaining that several packages are out of date and have known security vulnerabilities. (pyyaml, pycrypto, and paramiko)

Looks like it was a pip freeze, since I see things like goobuntu-config-tools==0.1.

Fair points.  Perhaps worth reverting just the requirements.txt.  @bellettif -- Is it possible to quickly fine tune the dependencies here?  I was able to execute run_expansion using the previous requirements list, but maybe other scripts have more requirements

I am trying to scale the dataset with the data_gen.sh  from the ml-20m dataset and could generate both train and test npz files. Since I need to have the csv file consisting of userID, movieID, rating to run my Spark benchmark (CloudSuite), I have tried to use the post_process.py script, but it doesn't work as I expect because it is supposed to have pickle files. It seems like I have to convert the npz files to pickle files first and then use the script. Please correct me if my understanding is wrong.

@Jeongseob I don't know the details of your Spark environment, but it seems correct to me. There seems to be one caveat -- the expansion script generates synthetic interactions (user<->item) but does not assign any ratings. You may need to augment the post_process.py script to add ratings, if needed.


Semantic error: : Variable length array of non-POD element type 'b2Vec2'

Got the following error message
Semantic Issue: Variable length array of non-POD element type 'b2Vec2' in ofxBox2dPolygon.cpp line 217: b2Vec2 verts[size()-1];
Related post in the OF forum http://forum.openframeworks.cc/index.php/topic,7258.0.html

fixed using a vector now...

Hi, getting the same error with the box2dexample for ios ... do you have a recommended fix? Thank you!


Cannot stop adapter that cannot start

Describe the bug
I have an adapter that cannot be started because of some missing property. As this adapter is no longer used and will be removed in a next release, there is no need to fix it or have it start anymore. However, every 5 minutes an attempt is done to start the adapter again, resulting in errors in the logging. There is no option to stop the adapter in the interface.
Reporter
Ricardo
Category

Frank Console

To Reproduce
Steps to reproduce the behavior:

Have an adapter that cannot start (missing connections)
See that there is no stop button
The adapter will attempt to be started every 5 minutes

Expected behavior
A stop button so I can stop the adapter from being started every 5 minutes
Screenshots

Environment:

Application server (f.e. Tomcat/WebSphere/JBOSS/Jetty): WebSphere
Browser [e.g. chrome, safari]: Chrome
IAF Version [e.g. 7.5 RC3, 7.6]: 7.5-RC3

Additional context
N/A

The real error is that the adapter should not be in a 'recovering loop' when it cannot configure.


jax.ops.index_update of int array silently promotes nan to large integer

jax.ops.index_update of int array silently promotes nan to a large integer (i.e. machine capacity for 32 bit int). Is this desired behavior ? The analogous op in numpy throws a ValueError instead.
import jax
import jax.numpy as np
import numpy as onp

a = np.array([0, 47, 0])
b = a.astype(float)

print(jax.ops.index_update(a, a == 0, np.nan)) # [-2147483648          47 -2147483648]
print(jax.ops.index_update(b, b == 0, np.nan)) # [nan 47. nan]

oa = onp.array(a)
oa[oa == 0] = np.nan # ValueError: cannot convert float NaN to integer

This is the expected behavior; it's similar to the case of out of bound indexing. Due to its execution model, JAX cannot raise errors dependent on non-static values, which means it's an all-or-nothing prospect: if JAX accepts any floats in this context, it has to accept all possible floats, and NaN is one of the possible float values.
The alternative would be to raise errors for all floats in this context, and I suspect that when this decision was made the convenience of the typical case was felt to outweigh the strange behavior of the rare corner case.

Ah, got it. Thanks for the clear explanation! I assume automatically casting to float in this case would be similarly problematic then? FWIW I think masking zeros is more than a corner case -- but I'll be more careful (:

I assume automatically casting to float in this case would be similarly problematic then?

Yes - that kind of logic cannot depend on the value – we could make the choice to always cast the entire array to float when a float is encountered in index_update, or always raise an error, but we can't condition the error or the casting on the values being updated.

As of #10924, this behavior emits a warning, and in a future release it will be an error:
>>> import jax.numpy as jnp
>>> jnp.zeros(10, dtype=int).at[3].set(4.5)
jax/jax/_src/ops/scatter.py:87: FutureWarning: scatter inputs have incompatible types: cannot safely cast value from dtype=float32 to dtype=int32. In future JAX releases this will result in an error.
  warnings.warn("scatter inputs have incompatible types: cannot safely cast "
DeviceArray([0, 0, 0, 4, 0, 0, 0, 0, 0, 0], dtype=int32)

Same with the original issue:
>>> jnp.array([0, 47, 0]).at[0].set(jnp.nan)
/jax/jax/_src/ops/scatter.py:87: FutureWarning: scatter inputs have incompatible types: cannot safely cast value from dtype=float32 to dtype=int32. In future JAX releases this will result in an error.
  warnings.warn("scatter inputs have incompatible types: cannot safely cast "
DeviceArray([ 0, 47,  0], dtype=int32)


Mismatched columns created after get_dummies() [ValueError: Order of columns does not match]

This may be related to 6865
What happened: I called get_dummies() and then called head() to check results. I got a ValueError: Mismatched columns
What you expected to happen: Top 5 rows of new version are printed
Minimal Complete Verifiable Example:
my_dd = dd.read_csv('repro.csv')
my_dd = my_dd.categorize(my_dd.columns)
my_dd = dd.reshape.get_dummies(my_dd)
print(my_dd.head())

Anything else we need to know?: The order of the E columns is switched between actual and meta. When using pycharm debugger to inspect columns, prior to calling head(), the columns are in the correct order, but somehow the two E columns (E_1.0 and E_0.0) get switched in actual at some point without being switched in meta.
Environment:

Dask version: 2022_7.0
Python version: 3.9
Operating System: Windows (WinPython)
Install method (conda, pip, source): pip
repro.csv

@DRudel Welcome, and thank you for reporting!
This is the same as #9258 and the fix (#9264) was merged just this week. :)
Closing as resolved!


Could not create DC

Run the script for a long time, run for more than 12 hours, it will report this error.
File "F:\myself\apprunner_client\apprunner_client\venv\lib\site-packages\desktopmagic\screengrab_win32.py", line 365, in getScreenAsImage
return _getRectAsImage(None)
File "F:\myself\apprunner_client\apprunner_client\venv\lib\site-packages\desktopmagic\screengrab_win32.py", line 328, in _getRectAsImage
dc, bitmap = getDCAndBitMap(rect=rect)
File "F:\myself\apprunner_client\apprunner_client\venv\lib\site-packages\desktopmagic\screengrab_win32.py", line 223, in getDCAndBitMap
mfcDC  = win32ui.CreateDCFromHandle(hwndDevice)
win32ui.error: Could not create DC.

Which script are you running? Python version? OS? Graphics driver? Number of monitors? Doing anything unusual? Thanks.


Lazy loading using performUpdate() ?

I'm trying to implement lazy loading by loading data while a banner is inside the viewport. The strange thing is that when I ask for "banner.getBoundingClientRect().y" it stays 0 and all data is being loaded from the backend.
  performUpdate() {
    super.performUpdate()

    // Lazy loading
    var banner = this.shadowRoot.querySelector('.more')
    if(banner.getBoundingClientRect().y<window.innerHeight && store._pointer != store._count) {
      console.log(banner.getBoundingClientRect(),window.innerHeight)
      await store.push(1)
    }

This causes all the data to be loaded (until store._pointer == store.count).  This happens every time I reload the page. I thought super.performUpdate() would first re-render the component before continuing execution of the function? I get the same behavior when I use async and await:
  async performUpdate() {
    await super.performUpdate()

    // Lazy loading
    var banner = this.shadowRoot.querySelector('.more')
    if(banner.getBoundingClientRect().y<window.innerHeight && store._pointer != store._count) {
      console.log(banner.getBoundingClientRect(),window.innerHeight)
      await store.push(1)
    }

Next I found the function updated. I figured maybe that would work as I would expect that the new data is rendered first and then updated is called again which will add more data if needed.
  async updated(changedProperties) {
    // Lazy loading
    var banner = this.shadowRoot.querySelector('.more')
    if(banner.getBoundingClientRect().y<window.innerHeight && store._pointer != store._count) {
      console.log(banner.getBoundingClientRect().y,window.innerHeight)
      await store.push(1)
    }
  }

However this results in the same problem when reloading the page where banner.getBoundingClientRect().y equals 0 many calls in a row until store._pointer == store._count. And thus all data is loaded.

We can't really diagnose this as-is - there are a number of reasons why the top of the element might be at the top of the viewport. When the element renders visually, where does DevTools say it's positioned?

Your assumption is correct that both after super.performUpdate() and in updated() the element DOM has rendered and naively, I'd expect getBoundingClientRect to return reasonable data. As Justin said, it's hard to diagnose with the info provided. If you can make a minimal repro and link it here, we can try to give more info.

Closing due to inactivity. Please feel free to re-open or open a new issue with more info if needed. Thanks.


Ability to paste into Maccy search?

Hello,
Hopefully this doesn't already exist in another ticket. I tried to search and didn't see anything.
When I try to paste into Maccy's search bar I get a "donk" error sound and then the Maccy window hides itself. It would be nice to be able to start a search based on what's in the clipboard so you don't have to type it again. This doesn't come up that often but when it does it always surprises me, so I thought I'd ask about it.

Fixed in 40efe5b4da6b182b71d8b55a4643fff7bdb4d03a

Can we still comment on a closed issue? Will you still see this message? I'm not sure. I'll post here but if I don't get a response in a few days, I'll post a new item instead.
First of all, thanks for adding in the paste into search functionality! Just wanted to provide some feedback about the new version 18.2. The way it is implemented currently works fine for my needs (once I figured out how it works), but I just wanted to mention a few things that you might want to refine in the future:

I love that you can just paste immediately without giving focus to the search bar! However, that may be unintuitive to some users. Is there a way to make the cursor show up in the search bar by default? Because otherwise some users may wonder what is the correct way to give focus to the search bar before you paste?

On that same note, giving focus with the mouse (by clicking) does not work. If I try to paste after that, I just get the "donk" error sound. This is not a huge issue once I realized I didn't need to give it focus. But just letting you know.

Also, if you type any characters and then paste, the paste replaces anything you already typed instead of adding it to the end. I think that's fine though, especially because it's just a search box. In fact, at first when I thought I needed to give focus to the search bar I would type any key and then paste, so I was happy that the key I typed first was not included in the search. So no problem, just not what I expected at first.

However, that does bring up another question about the ability to edit your search terms. Right now the only key that works in the search bar is backspace. You can't move the cursor left or right with the arrow keys to fix a typo or make a change and the other normal Mac behaviors don't work either, like moving a word at a time (⌘ + arrow key), or the whole line  or (⌥ + arrow key). All of that would probably be overkill for the purposes of the search bar. But just wanted to mention it because if it's not difficult to add and it doesn't take more resources, then it would be more refined to have the search bar act like most text input fields on the Mac. That leads me to the next question:

What is the desired behavior when pushing left and right arrows (or tab and shift-tab) when the Maccy menu is showing? On my machine it's inconsistent. Most of the time it tries to move focus to the next (or previous) item in the menu bar (I guess technically that's called the status menu?) and then the window closes immediately. Sometimes though the window stays open. Also, the Maccy menu does not show if you scroll through the status menu items. In other words if the status menu has the focus (either by clicking up there or ctrl+F8) and then I use my arrow keys to move left and right, it skips right over Maccy (and one other app I have, oh and also the Notification Center I just noticed). Not a big deal, but I didn't expect that behavior. I'm not sure how often I would try to get to Maccy that way, but it might be nice if it did work.

Lastly, and this is a little off-topic, what is the search logic? It has probably always been this way and I just never noticed but searching finds lots of results that do not contain my query. But the ones that I'm looking for always show up on top, so I guess it's working. Just wondering why all the other results are showing as well?

Sorry for the LONG post. Thanks for all your hard work!

Thank you for all the comments, I'll reply later.

I love that you can just paste immediately without giving focus to the search bar! However, that may be unintuitive to some users. Is there a way to make the cursor show up in the search bar by default? Because otherwise some users may wonder what is the correct way to give focus to the search bar before you paste?

My idea is that "type to search..." is enough to indicate you can do that. Also, it should be possible to click on the search field and paste (see point below).

On that same note, giving focus with the mouse (by clicking) does not work. If I try to paste after that, I just get the "donk" error sound. This is not a huge issue once I realized I didn't need to give it focus. But just letting you know.

This needs to be fixed for sure.

Also, if you type any characters and then paste, the paste replaces anything you already typed instead of adding it to the end. I think that's fine though, especially because it's just a search box. In fact, at first when I thought I needed to give focus to the search bar I would type any key and then paste, so I was happy that the key I typed first was not included in the search. So no problem, just not what I expected at first.

It seems counterintuitive to me because I'd expect paste to append, but as long as it is good for you, let's keep the current behavior.

However, that does bring up another question about the ability to edit your search terms. Right now the only key that works in the search bar is backspace. You can't move the cursor left or right with the arrow keys to fix a typo or make a change and the other normal Mac behaviors don't work either, like moving a word at a time (⌘ + arrow key), or the whole line or (⌥ + arrow key). All of that would probably be overkill for the purposes of the search bar. But just wanted to mention it because if it's not difficult to add and it doesn't take more resources, then it would be more refined to have the search bar act like most text input fields on the Mac. That leads me to the next question:

Implementing editing in the search field is a little bit more complicated than it looks. The main problem here is that after you change search term, the first matching result should be selected (i.e. have focus). This implies that search field loses focus, so pressing arrow one more time should either remember its last position or start over again from the end of the search term. Implementing this behavior can become even more tricky once we start taking into account Option/Cmd + arrow modifiers, or removing a character and then appending new characters to the search (where the arrow should now begin?).

What is the desired behavior when pushing left and right arrows (or tab and shift-tab) when the Maccy menu is showing? On my machine it's inconsistent. Most of the time it tries to move focus to the next (or previous) item in the menu bar (I guess technically that's called the status menu?) and then the window closes immediately. Sometimes though the window stays open. Also, the Maccy menu does not show if you scroll through the status menu items. In other words if the status menu has the focus (either by clicking up there or ctrl+F8) and then I use my arrow keys to move left and right, it skips right over Maccy (and one other app I have, oh and also the Notification Center I just noticed). Not a big deal, but I didn't expect that behavior. I'm not sure how often I would try to get to Maccy that way, but it might be nice if it did work.

I wasn't aware of this. It is likely skipping because Maccy status item is not the usual one, but I'll try fixing it.

Lastly, and this is a little off-topic, what is the search logic? It has probably always been this way and I just never noticed but searching finds lots of results that do not contain my query. But the ones that I'm looking for always show up on top, so I guess it's working. Just wondering why all the other results are showing as well?

I love that you can just paste immediately without giving focus to the search bar! However, that may be unintuitive to some users. Is there a way to make the cursor show up in the search bar by default? Because otherwise some users may wonder what is the correct way to give focus to the search bar before you paste?

My idea is that "type to search..." is enough to indicate you can do that. Also, it should be possible to click on the search field and paste (see point below).

On that same note, giving focus with the mouse (by clicking) does not work. If I try to paste after that, I just get the "donk" error sound. This is not a huge issue once I realized I didn't need to give it focus. But just letting you know.

This needs to be fixed for sure.

Also, if you type any characters and then paste, the paste replaces anything you already typed instead of adding it to the end. I think that's fine though, especially because it's just a search box. In fact, at first when I thought I needed to give focus to the search bar I would type any key and then paste, so I was happy that the key I typed first was not included in the search. So no problem, just not what I expected at first.

It seems counterintuitive to me because I'd expect paste to append, but as long as it is good for you, let's keep the current behavior.

However, that does bring up another question about the ability to edit your search terms. Right now the only key that works in the search bar is backspace. You can't move the cursor left or right with the arrow keys to fix a typo or make a change and the other normal Mac behaviors don't work either, like moving a word at a time (⌘ + arrow key), or the whole line or (⌥ + arrow key). All of that would probably be overkill for the purposes of the search bar. But just wanted to mention it because if it's not difficult to add and it doesn't take more resources, then it would be more refined to have the search bar act like most text input fields on the Mac. That leads me to the next question:

Implementing editing in the search field is a little bit more complicated than it looks. The main problem here is that after you change search term, the first matching result should be selected (i.e. have focus). This implies that search field loses focus, so pressing arrow one more time should either remember its last position or start over again from the end of the search term. Implementing this behavior can become even more tricky once we start taking into account Option/Cmd + arrow modifiers, or removing a character and then appending new characters to the search (where the arrow should now begin?).

What is the desired behavior when pushing left and right arrows (or tab and shift-tab) when the Maccy menu is showing? On my machine it's inconsistent. Most of the time it tries to move focus to the next (or previous) item in the menu bar (I guess technically that's called the status menu?) and then the window closes immediately. Sometimes though the window stays open. Also, the Maccy menu does not show if you scroll through the status menu items. In other words if the status menu has the focus (either by clicking up there or ctrl+F8) and then I use my arrow keys to move left and right, it skips right over Maccy (and one other app I have, oh and also the Notification Center I just noticed). Not a big deal, but I didn't expect that behavior. I'm not sure how often I would try to get to Maccy that way, but it might be nice if it did work.

I wasn't aware of this. It is likely skipping because Maccy status item is not the usual one, but I'll try fixing it.

Lastly, and this is a little off-topic, what is the search logic? It has probably always been this way and I just never noticed but searching finds lots of results that do not contain my query. But the ones that I'm looking for always show up on top, so I guess it's working. Just wondering why all the other results are showing as well?

Created #234 to track status item skip. I guess the rest of the issue can be concluded as done.


update 98% to 97% of consumers

Fixes outdated 98% number on homepage to match the current number on the CCDB landing page: 97%.
Changes

change static text from 98% to 97% to match CCDB landing

Review

@jimmynotjim

Todos

this is a short-term fix in the static content. the permanent fix would update the homepage to reuse the same code that gets this number from the database in the CCDB landing.

Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests
[x] New functions include new tests
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged
[x] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

👍  Want to update the changelog and I'll merge.

Based on my in-depth statistical review of this PR, it LGTM 👍

Merging to get it in the next release. I'll update the changelog manually


Bug: PR does not automatically go to Highlights

Describe the bug
Whenever I click on "Add PR to highlights" to place a merged PR in that section, it goes there, but the chosen PR does not automatically appear there.
Steps to reproduce

Sign in to the Chrome Extension
Go to a merged PR
Click on the OpenSauced icon
Click on the Add PR to the Highlights section

Browsers
Chrome
Additional context (Is this in dev or production?)
Video of the problem
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[x] I agree to follow this project's Contribution Docs

@CBID2, can you share the link to the PR that's not working for you?

We just redirect to the highlights page right now if I remember correctly. No information is auto filled for now.

It's about the 'Post a highlight' autofill I think.

It's about the 'Post a highlight' autofill I think.

Yeah that's the one

@CBID2, can you share the link to the PR that's not working for you?

It's a issue I have with all my PRs.

I tried posting a highlight. The auto-fill worked for me as expected. Can you share a recording?

Was it a draft PR @CBID2?

Was it a draft PR @CBID2?

No a merged one @bdougie

I tried posting a highlight. The auto-fill worked for me as expected. Can you share a recording?

Yup, just posted one in the Additional information section of the issue @Anush008. Feel free to check it out too @bdougie

We need to change this altogether. This PR https://github.com/open-sauced/insights/pull/1487 changes how we will link to highlighting creation moving forward.
I suggest fixing the links to https://highlight.new and passing in query params to populate the opened input.

Just saw the recording. I thought it was about posting a highlight from the extension's pop-up page which has auto-fill.

We need to change this altogether. This PR https://github.com/open-sauced/insights/pull/1487 changes how we will link to highlighting creation moving forward.
I suggest fixing the links to https://highlight.new and passing in query params to populate the opened input.

Okay where can I find that @bdougie?

Start with search in the repo for the copy, "add to highlight"

Start with search in the repo for the copy, "add to highlight"

Is it this one @bdougie: https://github.com/open-sauced/ai/blob/beta/src/utils/dom-utils/addPRToHighlights.ts
Or these two?
https://github.com/open-sauced/ai/tree/beta/src/content-scripts/components/AddPRToHighlights
https://github.com/open-sauced/ai/blob/beta/src/content-scripts/components/AddPRToHighlights/AddPRToHighlightsButton.ts

@CBID2, https://github.com/open-sauced/ai/blob/beta/src/utils/dom-utils/addPRToHighlights.ts handles adding the button to GitHub.
https://github.com/open-sauced/ai/blob/beta/src/content-scripts/components/AddPRToHighlights/AddPRToHighlightsButton.ts controls the button behaviour. Your changes need to go here.


Proposal: compute module format based on package.json visible to declarationDir/outDir

Note: there are good reasons not to publish dual CJS/ESM npm packages. This is not a blanket endorsement of the practice. However, we’ve noticed that many existing dual packages ship types that don’t correctly describe the JS contents of the package. I believe this is in no small part because doing dual CJS/ESM emit with tsc is a cumbersome UX (and completely undocumented). This is a small change that significantly improves the experience.
In --module nodenext, we decide whether a file index.ts is ESM or CJS by looking up through its containing directories for the nearest package.json file so we can see whether it includes "type": "module". With this PR, we instead begin that search with the file’s declarationDir or outDir. This allows the developer to pre-seed an outDir per module format with a package.json, and run a compilation into each:
dist/esm/package.json:
{ "type": "module" }

dist/cjs/package.json:
{}

# Produce an ESM build with types
tsc --module nodenext --outDir dist/esm --declaration index.ts

# Produce a CJS build with types
tsc --module nodenext --outDir dist/cjs --declaration index.ts

These builds can be linked with a solution-style tsconfig.json:
// tsconfig.json
{
  "files": [],
  "references": [
    { "path": "./tsconfig.cjs.json" },
    { "path": "./tsconfig.esm.json" },
  ]
}

Note that in this configuration, where the input files are covered by two different tsconfigs, TS Server picks uses the second one in the array for errors and intellisense. #54476 discusses ideas for improvements to the editor and orchestration experience.

@typescript-bot pack this

@typescript-bot test top100

As you know - I'm not a fan of dual packages so I'm not really advocating here anyhow on their behalf, I'm not invested in the game. I have some thoughts on the DX of this improvement though.

I feel that something like this is a step in the right direction when it comes to enabling dual package emits. Since src is singular - you need to find a way to "fork" it into two somehow.
I don't think that pre-seeding a directory will work super well with existing workflows:

a super popular setup involves using a Rollup-based library builder (there are a couple of them, such as tsup and more). Those tools often don't use TS directly to do the declaration emit (or at the very least they don't typecheck sources and what they generate). In those situations, typechecking usually happens in parallel or something and it's using noEmit: true. They also often clean the dist dir before doing a fresh build. I assume that you envision that those tools would pre-seed the appropriate directories with those package.json files so TS could pick them up. I think this introduces an unneeded waterfall dependency between those jobs here. What if one would like to do JS emit and DTS emit completely in parallel? This would require a third script that would just pre-seed this for tsc.
people might actually use tsc for emitting both JS and DTS. In this case, the pre-seeding script would be required but I honestly have a hard time justifying the need for it. I think that the tsc command should be able to do this on its own (without noEmit: true). The motivation for all of this here is to smooth the DX - I feel that requiring additional scripts isn't that.

One thing I think I'd like to see (which maybe overlaps with @Andarist's commentary) is some way to do this that doesn't involve pre-seeding a package.json (allowing it to come later as a part of a final build step); if we already need multiple tsconfig files to emulate this, I feel like it would make sense to have some sort of config that can specify whether or not .js/.ts files are to be interpreted as commonjs or module. That way, you could still "just clone" a repo and get a working setup without committing what feel like build artifacts. But, maybe that's unsound given a single compilation may actually contain many package.jsons and so it'd be difficult to properly scope to the "right" code. And maybe it's sorta moot as without actually putting down the package.json file, the code tsc just emitted wouldn't even run, or may not even work when loaded by other projects?
That being said, I do like the proposal, given it effectively makes safe the packaging method that @isaacs is now using for his packages (e.g. https://unpkg.com/browse/glob@10.2.6/dist/).

That being said, I do like the proposal, given it effectively makes safe the packaging method that @isaacs is now using for his packages (e.g. https://unpkg.com/browse/glob@10.2.6/dist/).

The existence of<EMAIL_ADDRESS>in this form... so confusing 🙈 Can't wait for some resolvers to be tripped over non-root exports in this package.json.

I don't have any strong feelings about the details in this approach, but my overall response to the idea is that it feels like y'all are going out of your way to address my niche use case in particular without me even having asked, and I rarely feel so loved in OSS, so thank you very much for making my day ❤
Shipping hybrid TS modules is indeed a bit of a house of cards currently, but enough people are using CJS (and will continue for the foreseeable future) that it is a worthwhile endeavor imo, whether it's ill-advised or not.  It would be really awesome if I could have some set of configs so that I just run tsc and get all the right kinds of files in predictable places. I don't see any way around having two separate tsconfig files (or at least, separate config objects), because sometimes you do have to change other settings between the two.
For example, https://github.com/tapjs/processinfo is a hybrid module, but some of the files are cjs only, and some are esm only, so they have different include/exclude lists.  Anything that uses require.resolve() needs to have entirely separate implementations, because import.meta.url is radioactive outside of ESM, and require needs to be loaded using import.meta.url outside of CJS, requiring this kind of post-build step to work properly.

The existence of<EMAIL_ADDRESS>in this form... so confusing 🙈 Can't wait for some resolvers to be tripped over non-root exports in this package.json.

Hah, oof. Yeah, that's a bug. When I added a bin script, I made it import from package.json to get the current version, and didn't notice that meant picking up the actual entire package.json. Thanks for bringing it to my attention :)

Hah, oof. Yeah, that's a bug. When I added a bin script, I made it import from package.json to get the current version, and didn't notice that meant picking up the actual entire package.json. Thanks for bringing it to my attention :)

Here I had thought that was part of the trick (back when I saw it originally), oops.

In this case, it was likely just creating a CJS package scope and nothing else. exports are ignored in non-root package.json files (unless you self-import).

Hah, oof. Yeah, that's a bug. When I added a bin script, I made it import from package.json to get the current version, and didn't notice that meant picking up the actual entire package.json. Thanks for bringing it to my attention :)

Nice! ❤ When re-reading my comment now - I think that it could be taken as snarky or smth, it definitely was not my intention, just noting down something I noticed ;p It's super cool that you addressed this

Thanks for the feedback. I take all these points, but to clarify my suggested workflow, I assume that the outDir package.json files will be committed, while the rest of the outDir contents would typically gitignored. This could be done with scripts, but there’s little reason not to just commit them IMO. So if using other tools in combination with tsc, they don’t need to add package.jsons, they just need to not delete the non-gitignored one that’s already there.

I feel like it would make sense to have some sort of config that can specify whether or not .js/.ts files are to be interpreted as commonjs or module

The only version of this I could see is something that would emit the appropriate package.json into the outDir. That would eliminate the need to commit them, and might make it easier for other tsconfig-reading tools to understand what’s about to happen. If we did something like that, I would suggest it as an addition to what I have in this PR, not a replacement for it.

I can't see any tests around this so I'm curious if a package.json in the outDir/declarationDir thing would also be used for resolving with the imports field (& exports field for self-reference)? I would imagine it should since that's how it would work after emit, right?

In theory, all module resolution should happen from output files, but in practice, it never does. https://github.com/microsoft/TypeScript/issues/37378 is essentially a feature request for that.

That would also imply that this should be allowed too then right?
// tsconfig.json
{
  "compilerOptions": {
    "module": "nodenext",
    "outDir": "./dist"
  }
}
// src/index.ts
import { a } from "./a";

console.log(a);

// dist/a.d.ts
export declare const a: string;

Which seems quite unintuitive and frustrating if e.g. there used to a file at src/a.ts and you deleted it but there's now a stale .d.ts file in the dist folder (and running tsc won't delete that) so you're still allowed to import ./a from src/index.ts as if src/a.ts exists
(I'm leaving this comment here rather than on the issue you linked since from my (maybe incorrect?) reading of that, it seems like the consensus there was to not change module resolution like this PR is doing?)

This PR doesn’t change module resolution at all. The only outDir-based logic applied is finding package.jsons for purposes of module format detection.

I take all these points, but to clarify my suggested workflow, I assume that the outDir package.json files will be committed, while the rest of the outDir contents would typically gitignored. This could be done with scripts, but there’s little reason not to just commit them IMO.

There might be little reason to not commit them but it's usually just way simpler to not commit them which also extends to...

So if using other tools in combination with tsc, they don’t need to add package.jsons, they just need to not delete the non-gitignored one that’s already there.

It's just way easier to just rm -rf dist (explicite or conceptually).
So overall, I think that it's a somewhat big ask for other tools to tweak how they work today so those files don't get removed.

The only version of this I could see is something that would emit the appropriate package.json into the outDir. That would eliminate the need to commit them, and might make it easier for other tsconfig-reading tools to understand what’s about to happen. If we did something like that, I would suggest it as an addition to what I have in this PR, not a replacement for it.

Playing devil's advocate - if emitting them is not the table here, what exact value the current proposed approach would have (or rather, under what circumstances one would like to use/it would kick in)? I wonder if you need it if you'd go with emitting those package.jsons. If I understand correctly, the emitting mode~ would assume replacing the potentially existing package.jsons - so it's not exactly just an addition on top of what is proposed here.

The value here is mostly for people who won’t use a third-party tool at all, or will only use a third-party tool to post-process what tsc builds.

it's a somewhat big ask for other tools to tweak how they work

I don’t really expect other tools to change, which reinforces why I’m making this PR. If tsc makes it reasonably easy to do type-accurate and runtime-safe dual emit, and it can be shown that every third party tool is runtime-unsafe and/or produces broken/unchecked type declarations, then I think new projects will adopt this, and a small number of existing projects with fairly simple builds that only leverage other tools to do dual emit might switch.

If I understand correctly, the emitting mode~ would assume replacing the potentially existing package.jsons - so it's not exactly just an addition on top of what is proposed here.

I don’t really see a problem with that. It’s not hard to say the package.json that matters is the hypothetical emitted one ?? the one that's there.
Is there something in particular you would suggest instead?

@Andarist

It's just way easier to just rm -rf dist (explicite or conceptually).

This is why I love git clean -xdf, as it honors gitginore.  You do have to be careful about untracked files though.

I think the most significant problem with this approach is that it ignores the possibility of TS bundlers and runtimes that consume input files and also care about package.json "type". By analyzing only the output file structure, we solve things for Node, but break them for ts-node. Any solution here needs to ensure the input and output structures agree. I talked through some ideas with @DanielRosenwasser and have an alternative proposal that addresses that problem as well as some of the usability concerns raised in this PR. I’ll open a fresh issue shortly.

Any solution here needs to ensure the input and output structures agree.

Maybe I’m just not using my imagination enough but this constraint sounds like it would prevent you from doing dual packages from the same source entirely

#54593
@fatcerberus yeah kind of—the main thing I’m thinking is we need to not make agreement a huge pain for projects that aren’t doing dual emit.

I'm a fan of the intent here for sure. I'm not a fan of the idea of needing two package.json files, especially when that's what exports is supposed to preclude. I've been noodling away at dual packages in Babel (babel-dual-package) and TypeScript (duel) over the past month, and in regards to tsc I believe I've mostly got it working by generating a second tsconfig.json file for the dual build, so that all one has to do is update the exports field to match the build output. However, I could not find a set of compiler options to allow this to happen seamlessly without one of the new file extension's module system being corrupted, so I had to copy files over from one build into the other to preserve the module system. Updating the package.json type field dynamically also created compiler errors, and the road from there just added more complexity I wasn't interested in dealing with. Overall, a second package.json seems like an anti-pattern.
I'd love to see this happen, one way or another.

To my understanding, conditional exports in a package.json are supposed to properly map a file to any module system based on the condition applied, i.e. import or require. The particular package I've been working on @knighted/duel chooses to explicitly define file extensions for each condition where relevant (because that's the world we're in now) to distinguish the CJS variant from the ESM variant, or vice versa. I do this by updating specifiers via @knighted/specifier.
I've added a test to @knighted/duel to ensure the runtime behavior of CJS-first packages work as expected with the conditional exports defined in package.json. The commit is referenced above. You should be able to check that out and run something like npm test and then node node test/__fixtures__/cjsProject/dist/index.js to see that there are no runtime errors thrown. I'm on the latest Node.js, v20.5.0.
In short, my approach does update file extensions and associated specifiers.

conditional exports in a package.json are supposed to properly map a file to any module system based on the condition applied

“supposed to” by convention, not by any magic in the implementation. Your example works only because the file extensions agree. Conditions are only used during module resolution; they have zero impact on module format detection. Conditions are really just arbitrary strings, but Node applies the import and require conditions to its resolution process based on the requesting syntax, so conventionally configured exports can ensure that they don’t feed an ES module to require. But exports are free to mix it up and cause require(esm) errors, or on the other hand feed a CJS module to an import ("import": "./cjs.cjs"), which would be unconventional but won’t actually cause errors, since you can always import a CJS module in Node.js.

I will invoke your stated design goals 4 here. Whether you want to support his or not is up to you. I don't particularly need it.


Bugfix twilio/bird convert first to string befor matching

Description:
Bugfix for twilio and bird notify platform.
Related issue (if applicable): fixes #3473

🐬


ConcurrentModificationException when node.remove

When I manipulate childnodes, ConcurrentModificationException will appear through node.remove, and UnsupportedOperationException will appear through iterator. How should I delete the node of childnodes, this is very important to me, thanks for the answer
public static void f(List<Node> nodes) {
       for (Iterator<Node> iterator = nodes.iterator(); iterator.hasNext(); ) {
             Node node = iterator.next();
            if (node instanceof Element) {
                f(node.childNodes());
            } else if (node instanceof TextNode) {
                if (node.outerHtml().contains("some")) {
                    iterator.remove();//1.
                    node.remove();//2.
                }
            }
        }
    }

Can you add a snippet of the HTML you're testing with, and a description of what you're ultimately trying to do / what you want the final DOM to be?

I along with my group will be fixing this issue in this semester.

Currently, I use another delete list to store that i want to delete node, and delete node at another loop

您能否添加您正在测试的 HTML 片段，以及您最终尝试做什么/您希望最终 DOM 成为什么的描述？

Can you add a snippet of the HTML you're testing with, and a description of what you're ultimately trying to do / what you want the final DOM to be?

sorry i didnt reply in time, the HTML testing snippet just simple a web page data


[release/1.3] Prepare v1.3.1 release

Update the runc vendor to v1.0.0-rc9 which includes an additional mitigation for CVE-2019-16884.

More details on the runc CVE in opencontainers/runc#2128, and the additional mitigations in opencontainers/runc#2130.

Add local-fs.target to service file to fix corrupt image after unexpected host reboot. Reported in containerd/containerd#3671, and fixed by containerd/containerd#3745.

Fix large output of processes with TTY getting occasionally truncated. Reported in containerd/containerd#3738 and fixed by containerd/containerd#3754.

Fix direct unpack when running in user namespace. Reported in containerd/containerd#3762, and fixed by containerd/containerd#3779.

Update Golang runtime to 1.12.13, which includes security fixes to the crypto/dsa package made in Go 1.12.11 (CVE-2019-17596), and fixes to the go command, runtime, syscall and net packages (Go 1.12.12).

Add Windows process shim installer containerd/containerd#3792

CRI fixes:

Fix shim delete error code to avoid unnecessary retries in the CRI plugin. Discovered in containerd/cri#1309, and fixed by containerd/containerd#3733 and containerd/containerd#3740.

Signed-off-by: Sebastiaan van Stijn<EMAIL_ADDRESS>

Generated release notes:
containerd 1.3.1
Welcome to the v1.3.1 release of containerd!
The first patch release for containerd 1.3  includes updated vendors/build runtimes that fix reported CVEs in runc and the Golang 1.12 runtime respectively.
Notable Updates

Update the runc vendor to v1.0.0-rc9 which includes an additional mitigation for CVE-2019-16884.

More details on the runc CVE in opencontainers/runc#2128, and the additional mitigations in opencontainers/runc#2130.

Add local-fs.target to service file to fix corrupt image after unexpected host reboot. Reported in containerd/containerd#3671, and fixed by containerd/containerd#3745.

Fix large output of processes with TTY getting occasionally truncated. Reported in containerd/containerd#3738 and fixed by containerd/containerd#3754.

Fix direct unpack when running in user namespace. Reported in containerd/containerd#3762, and fixed by containerd/containerd#3779.

Update Golang runtime to 1.12.13, which includes security fixes to the crypto/dsa package made in Go 1.12.11 (CVE-2019-17596), and fixes to the go command, runtime, syscall and net packages (Go 1.12.12).

Add Windows process shim installer containerd/containerd#3792

CRI fixes:

Fix shim delete error code to avoid unnecessary retries in the CRI plugin. Discovered in containerd/cri#1309, and fixed by containerd/containerd#3733 and containerd/containerd#3740.

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.
Contributors

Michael Crosby
Sebastiaan van Stijn
Phil Estes
Akihiro Suda
Derek McGowan
Lantao Liu
Wei Fu
Ameya Gawde
Eli Uriegas

Changes

94bcf3f2 Prepare v1.3.1 release
0aeaac03 Merge pull request  #3792 from ameyag/windows-shim-backport
067be946 windows process shim installer
d6f0c29b Merge pull request  #3779 from AkihiroSuda/disable-mknod00-in-userns-1.3
f3c48daf apply: use naive applier when running in UserNS
7af311b4 Merge pull request  #3769 from thaJeztah/1.3_backport_bump_golang_1.12.x
c3450507 Merge pull request  #3772 from estesp/update-vndr-1.3
03361219 Catch up vndr with state of vendor/ dir
7f6f2c7d [release/1.3] pin travis to go 1.12.12
23b0ca70 Update Golang 1.12.12 (CVE-2019-17596)
aa98dc6e Merge pull request  #3754 from estesp/cp-1.3-3743
0f6aab18 Handle large output in v2 shim with TTY
7aaa8fc6 Merge pull request  #3751 from AkihiroSuda/native-copydir-allow-xattr-errors-1.3
1c3929e5 Merge pull request  #3748 from seemethere/fix_man_1_3
f6a32a79 snapshots/native: ignore xattr errors during CopyDir
3866900d Merge pull request  #3745 from crosbymichael/localfs3
ffb05aeb build: Fix manpage generation
d168e8eb Add local-fs.target to service file
0b43a311 Merge pull request  #3740 from estesp/cp-1.3-3736
b3e9ded8 Fix delete error code on the containerd daemon side.
ea86733a Merge pull request  #3733 from Random-Liu/cherrypick-#3730-release-1.3
6746ae3e Fix shim delete error code.
efd38f48 Merge pull request  #3724 from thaJeztah/1.3_backport_bump_runc_1.0.0-rc9
6cbad878 bump runc v1.0.0-rc9
dfc256fc Bump runc to 1b8a1eeec3f337ab5d94f28980

Dependency Changes
Previous release can be found at v1.3.0

github.com/opencontainers/runc  3e425f80a8c9 -> d736ef14f028

note that the Go 1.12.13 bump wasn't merged yet, but I anticipated it to be merged before a release is done 🤗

Before we release, we should consider if anything needs to be done re: #3556. It turns out that changes in this area broke registries that did work in 1.2.x and as people upgrade, clusters that used to work can't pull images anymore. It is correct that JFrog has a fix in process, but rolling out registries may take some time.

I think @dmcgowan also mentioned another change desired for 1.3.x
Happy to keep this open, and update, while those are being worked on

@thaJeztah one more ticket is for https://github.com/containerd/containerd/pull/3822 :P
thanks!

Let's get this in https://github.com/containerd/containerd/pull/3825

Updated release notes for deadlock fix
Generated preview https://gist.github.com/dmcgowan/df64155e14fbe7933f8611f8d966a341

Codecov Report

Merging #3812 into release/1.3 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.3    #3812   +/-   ##
============================================
  Coverage        45.59%   45.59%
============================================
  Files              116      116
  Lines            11465    11465
============================================
  Hits              5227     5227
  Misses            5338     5338
  Partials           900      900

Flag
Coverage Δ

#linux
45.59% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d3753...7fb78c1. Read the comment docs.

LGTM


Image captions/descriptions

Describe the feature you'd like
Although Bookstack collects the Image Description field, it is not used clearly I believe. The description could be used as the caption for the image, and displayed under it.
Describe the benefits this would bring to existing BookStack users
Images having captions is an important feature, users can avoid writing description for the image separately.
Can the goal of this request already be achieved via other means?
Probably, with some custom Javascript, but this should be available to all users by default.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
0 to 6 months
Additional context
No response

Thanks for the request @rounakdatta,
Alt text vs Captions

Although Bookstack collects the Image Description field, it is not used clearly I believe. The description could be used as the caption for the image, and displayed under it.

The current input is specifically "Alternative Description" (Or commonly known as "Alt text"), this is intended to be used when the image cannot be viewed, such as when the image fails to load or by users using a screen-reader. Your core request appears to be for visible captions, which I think would in reality have a slightly different use-case. Alt text if often used to describe the contents of an image whereas a caption is often used to add additional context or meaning.
Benefits

Describe the benefits this would bring to existing BookStack users
Images having captions is an important feature, users can avoid writing description for the image separately.

It would be good to know why this is an important feature. How would this be used? What would this achieve?
Achieving via other means

Can the goal of this request already be achieved via other means?
Probably, with some custom Javascript, but this should be available to all users by default.

If you wanted to use the alt-text as caption text, then yeah, you could add some JavaScript to the "Custom HTML Head Content" settings to allow this for all.
In addition, I guess you can technically achieve simulating captions with current text and formatting options. Placement may be tricky to keep aligned with the image though.
Implementation Challenges
If we were to add captions I'd want to use semantic HTML for the structure, in which using <figure> and <figcaption> would best suit. We don't currently support these elements within the editor, could be a pain in the WYSIWYG as that becomes quite a significant structure to support. Within our Markdown editor, there is no commonmark standard for captions so we'd have to resort to HTML yet again which is not ideal.

Hi,
Adding a caption is essential to specify the copyright of the image. This is what keeps me from using BookStack publicly today.
Thanks for the job.

Within our Markdown editor, there is no commonmark standard for captions so we'd have to resort to HTML yet again which is not ideal.

Why not leave the <figure> and <figcaption> html in the markdown page as [Markdown supports inline HTML](https://daringfireball.net/projects/markdown/syntax#html) ?
Then the more complicated thing will be to add a button to the WYSIWIG editor to "Add image with caption" and a form to capture the caption.

TinyMCE does provide a sample for using captions:
https://tinymce.github.io/tinymce-demos/images/toggle-image-size-context-toolbar.html

I see at least three solutions...

add a special button, add caption, that activate when you select a non-text item, like an image, table, drawig, youtube etc, Or
add a caption attribute in the image dialogue under description, or
add new style with a different look then the regular Paragraph and center-align.

I prefer the first option.

For our decade-spanning DND campaign Wiki,  image labels on longer pages would be a great way to describe - not only see - our player's heroic deeds.


BiostructureViewer doesn't open files

BiostructureViewer does not open files after upgrade to 1.21.3, Biostructure plugin 1.2.1. If the structure is embedded into a CSV, it still works. But selecting a random PDB file does not trigger drawing.  Please see screenshot video for behavior.

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16968

fixed in BiostructureViewer package version 1.2.2


How to read from IRandomAccessStreamReference?

Found this #598, but IByteBufferAccess doesn't exist anymore? Nothing implements TryIntoParam<IBuffer>, even Buffer.
I'm trying to read a thumbnail of a track from GlobalSystemMediaTransportControlsSessionMediaProperties.

Discovered #1431, but getting error: future cannot be sent between threads safely, because IRandomAccessStreamWithContentType which is not Send

In this specific case, you can send the GlobalSystemMediaTransportControlsSessionMediaProperties across threads.
Generally, you can use an agile reference wrapper.

So, I'm just playing around windows api and trying to display a thumbnail of a currently playing song in egui, I'm currently subscribing to MediaPropertiesChanged events, and sending cloned GlobalSystemMediaTransportControlsSession through a channel to background tokio::spawned function that changes the Mutex inside my app with with current track. Getting the current track from the session pulled from the channel. I'm try to condense my code a little to show the outline of what is going on and why I can't figure it out.
struct App {
    current_track: Arc<Mutex<Track>>,
    manager: GlobalSystemMediaTransportControlsSessionManager,
    session: GlobalSystemMediaTransportControlsSession
}

impl App {
    fn listener(&self) {
        let (tx, mut rx) = /* basic channel */;
        self.session. /* subscribing and sending cloned session */

        let mutex = self.current_track.clone();
        tokio::spawn(async move {
            while let Ok(session) = /* receiving a cloned session  */ {
                let track = Track::from_session(&session).await?;
                /* changing the mutex */
            }
        });
    }
}

struct Track {
    pub thumbnail: Vec<u8>
}

impl Track {
    pub async fn from_session(session: &Session) {
        let props = session.TryGetMediaPropertiesAsync()?.await?;
        let stream = &props.Thumbnail()?.OpenReadAsync()?.await?;

        let stream = &props.Thumbnail()?.OpenReadAsync()?.await?; /* problem is here */

        let length = stream.Size()?;
        let mut thumbnail = vec![0u8; length as usize];

        let buf = Buffer::Create(length as u32)?;
        let buf = stream.ReadAsync(&buf, length as u32, InputStreamOptions::None)?.await?; /* and here */

        let reader = DataReader::FromBuffer(&buf)?;
        reader.ReadBytes(&mut thumbnail)?;
        stream.Close()?;

        /* creating the track struct and returning it */
    }
}

Code is not meant to compile, I have skipped some of parts. This is basically the outline of my code. What I need to wrap around AgileReference to get it to work? I wrapped the AsyncOperation on IRandomAccessStreamReference and it worked, but didn't for ReadAsync.

Doing these operations using .await hides a bit of detail. Essentially, the tokio runtime can send your future (when using tokio::spawn) between its threads in between await-points. This is why the future must be Send. You can use a LocalSet if you need to spawn futures that aren't Send.
In this specific case, it's (in my opinion) easier to make this code synchronous and use spawn_blocking. I've done that in my wrapper, which uses tokio as well, here.

I see, thanks for the fix. Looking at it, should it be Send after all? Is there winapi limitations for unsafe impling it?

Closing as there's no actionable work here for windows-rs but feel free to keep the conversation going.


Fluent Bit Process doesn't restart automatically if killed

If due to some reason, the fluent bit process is killed internally, it doesn't restart automatically. Ideally, pod should restart if the process dies.

If due to some reason, the fluent bit process is killed internally, it doesn't restart automatically. Ideally, pod should restart if the process dies.

Don't worry, the FB process will be started whenever it's detected dead https://github.com/kubesphere/fluentbit-operator/blob/master/cmd/fluent-bit-watcher/main.go#L60

Thank you!! That sounds OK to me. I was facing this issue since yesterday.
Fluent bit exited" error="signal: killed"

After this, It was not restarting. but when I removed the limits from the resources, It works.


Windows PHPIZE path issues resolved

@umermalik129 doesn't seem to work, tests (appveyor) are failing.

@steffengy where code is breaking? I will try to fix it

https://ci.appveyor.com/project/phalcon/zephir/build/1.0.628

@steffengy what is this fatal error? "Fatal error: Class 'Test\Arithmetic' not found in C:\projects\zephir\unit-tests\Extension\ArithmeticTest.php on line 28"

I think you should probably take a look at the context
C:\projects\zephir\ext\test\testinterface.zep.c : fatal error C1083: Cannot open compiler generated file: 'Release_TS\projects\zephir\ext\test\testinterface.zep.obj': No such file or directory
which hints that compilation fails ^^

To test the code after changing I have to create PR or there is other way? I don't want to setup own CI server

@umermalik129
you could try to compile the zephir test extension yourself (appveyor.yml should hint at that)
any commit you add to the PR (push to your winfix branch) also gets automatically tested by the CI.

@steffengy I reverted processAddSources related changes and now the build is successful
I think we only need to change the paths that will go inside release directory

@steffengy will it work?

yeah sure tests work, but phpize builds are broken, just as before, without patching the configure script.

You mean Travis CI? appveyor builds successfully and I think it is related to windows build

No I mean by reverting the changes you did you effectively get appveyor to work, but
break in case of #1202.
Anyways the current state in master works in all cases I'm aware of,
and you really shouldn't waste your time in fixing something that isn't broken,
atleast if not being done systematically.


Compilation issues on Fedora

On Fedora 26, CMake fails with the following output: (note: i'm using libclangmm as a submodule -- not that it should make any difference)
Searcing for libclang
CMake Error at libclangmm/src/CMakeLists.txt:12 (find_package):
  By not providing "FindLibClang.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "LibClang",
  but CMake did not find one.

  Could not find a package configuration file provided by "LibClang" with any
  of the following names:

    LibClangConfig.cmake
    libclang-config.cmake

  Add the installation prefix of "LibClang" to CMAKE_PREFIX_PATH or set
  "LibClang_DIR" to a directory containing one of the above files.  If
  "LibClang" provides a separate development package or SDK, be sure it has
  been installed.

-- Configuring incomplete, errors occurred!
See also "clang-experiments/CMakeFiles/CMakeOutput.log".

Curiously enough, Fedora provides ClangConfig.cmake (without the Lib). After modifying libclangmm's CMakeFiles to find_package(Clang), the build is successful, though I assume that breaks it for other distros.
For some reason, ClangConfig.cmake also pulls in static libLLVM as a dependency (130 MB!), although this isn't required if I link against libclang manually. Is there a way to bypass the find_package altogether and specify libclang include/lib paths manually? (preferably without modifying libclangmm's CMakeLists)

You need to run cmake against the top level CMakeLists.txt file of a project. For instance, this will result in the above error:
git clone https://github.com/cppit/libclangmm
cd libclangmm
mkdir build
cd build
cmake ../src

However, this is the correct way:
git clone https://github.com/cppit/libclangmm
cd libclangmm
mkdir build
cd build
cmake ..

Consider this:
mkdir my_project && cd my_project
git submodule add https://github.com/cppit/libclangmm
echo 'add_subdirectory(libclangmm)' >CMakeLists.txt
cmake .

What's the solution in that case?

I am not a CMake expert, but this is one way to do it:

Yeah, but that's a very non-CMake way to do it.
I guess that adding
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake/Modules")

to clangmm's top-level CMakeLists would fix the error.
In the end I just went with the plain libclang.

Thank you, I did a cleanup of the CMakeLists.txt files now


Split the runtime project in two parts

Now we have one project, which is an application and a library in the same time. Make:

A project library, containing the runtime
A test runner application to run the test.

done with 85beaba56933851d794ff5de175657c25d0294ca


[Feature Request] use Stackstorm automation for RPA

Dear team,
can we use (now or in the future) the power of stackstorm in order to perform RPA task and smart automation assist by IA ?
as it is done by tools like UIPath and autopilot
Thanks for your highlight

There were a few demo robot automations in the past (can't find the links anymore though), like a real robot arm doing operations based on chatops command or other external event. We found that ActionChain workflow engine better fits low-latency tasks.
In short, if something has an API, - it could be integrated and automated with StackStorm. So you already can do stuff.
There is nothing on smart assist though.


Fix ownProps type signature

I incorrectly made ownProps a Maybe type in #190. It should be Object at the very least, or preferably pass along the actual Props type (see https://flow.org/en/docs/react/hoc/)
I also cleaned up the default argument for propName so that flow wouldn't complain.

@KevinGrandon @ganemone ping

Bump @KevinGrandon @ganemone

(agreed on the flow fixtures... kinda needs to be an e2e test for some of the underlying fusion-rpc stuff though)

!merge


[SVGMap] Add Russia map

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #12   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           7      7
  Branches        1      1
=====================================
  Hits            7      7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d6f7c...a08c1cf. Read the comment docs.

@spb-web Thanks for your PR! I'll try to review/test it this weekend.
Could you also add your map in the documentation in alphabetical order please?

@spb-web  since v2.0.0 the maps have been moved to another package.
So if you still want to add the Russia map, could you re-create this PR on v1 branch or create a new one on svg-maps please?


chore: replaced map with forEach

Description :

Removed the map function with forEach in examples/angular/src/test.ts
Related issue(s) :

Resolves Remove this commented out code. https://github.com/asyncapi/EDAVisualiser/issues/32

/rtm

@all-contributors please add @ShashwatPS for code

If possible can you add the Hacktoberfest label too ?


react-native module conflict between android support and androidx [Android]

I have multiple modules in my react-native project but I just update react-native version from 0.57.8 to 0.59.9 and after resolving all issue I am facing the issue with android support and androidx library. Most modules are using android support but react-native-video using androidx and it's creating issue but I need to use react-native-video with latest version (4.x). I have tried with many research and try to check with different version of react-native-video but no luck.
Can any one assist me that how can I use both andriodx and android support libraries with different modules simultaneously in a project?
Or any other solution of this issue.

Can you check you app dependencies with ./gradlew app:dependencies. I faced similar issue in my project due to react-native-device-info since it was using "com.google.android.gms:play-services-gcm:${safeExtGet('googlePlayServicesVersion', '+')}" as dependency which was pulling the androidx as its dependencies .
for me the resolution was adding below to app/build.gradle
configurations.all {
resolutionStrategy.force 'com.google.android.gms:play-services-gcm:16.1.0', 'com.google.android.gms:play-services-basement:15.0.1'
}

see https://github.com/zlei123456/toAndroidX
I solved this problem in this way, based on online solutions and official documentation.

I solved by excluding some files from my notification module.


UI development in progress

Scheduling

1 or 2 hours after work
Notify working time to google calendar before 1 or 2 days

Check out dev progress kanban board in Projects tab

don't work


HAML dependency

Suggest eliminating the haml dependency.

Makes sense to me. The gem should not force that preference on others.


[ambari-plugin]change version 1.3.2 to 1.3.3

What is the purpose of the pull request
[ambari-plugin]change version 1.3.2 to 1.3.3
Brief change log
[ambari-plugin]change version 1.3.2 to 1.3.3

LGTM


conda install open_spiel

What does the team think about having a conda-forge feedstock for open_spiel? That would enable seamless installation with something similar to the following:
conda install open_spiel -c conda-forge

I think this would be great, but we don't have the resources to put into setting it up nor maintaining it (e.g. we don't regularly test the Docker or Windows installations either, for similar reasons). If someone were to contribute it, we would be happy to include it in our installation instructions with the same caveats as the other installation methods that we can fix as problems come up.

Closing due to inactivity. Please re-open if you're still interested.


[rapids] add rapids to base environment for dask installations

When using RAPIDS with Dask, we want to install these libraries directly into the base environment of the cluster. RAPIDS is a rather large + finicky installation. The changes here:

Update the Dask service provider to use dask-cuda-workers when using dask service as a  standalone (relying on itself for orchestration instead of YARN)
Install RAPIDS and cudatoolkit into the environment using an external mamba environment. This reduces the installation time of just the RAPIDS init action from around 40 minutes to around 5 minutes, on average.
2.0:

RAPIDS relies on specific version of PyArrow for each release, and also that pyarrow is built with CUDA support. Unpinning PyArrow in the environment does not break other installations, so this is unpinned pre-installation and repinned post-installation with the new version that the environment is able to locate.

1.5:

Still broken, still working through why.
Currently, there is a temporary bandaid fix to a mismatch in conda pin / version available on the cluster. Should be fixed in next Dataproc release.

@medb @mengdong I've been unable to successfully install Dask into the base environment of 1.5. It hangs indefinitely (one hour+) using conda install, mamba install doesn't appear to be working either.
We already suggest in our documentation to use 2.0 if using Dask (which I was able to get working with Mamba). Maybe we should proceed with dropping support for 1.5 outright with Dask?

@mengdong I'm trying to install RAPIDS into the base environment of Dataproc 1.5. I recall you mentioning you ran into conflicts with RAPIDS and Anaconda on Dataproc 1.5. Do you remember what those issues were and what you were able to learn? I've been unable to successfully install it into the base environment myself.

Hi Brad, I think we have agreed on that it is better to create dask environment on 2.0 dataproc images?
We noticed the install rapids on dataproc 1.x images take crazy amount of time (~45 minutes to 1 hour)
If you need to get it work with 1.5 dataproc images, I recommend to upgrade miniconda version that shipped with 1.5 image.

Hmmm ok, it may make sense to drop support for 1.5 altogether. Do you happen to have updates as to whether or not there are Spark 2.x / Scala 2.12 jars available?

/gcbrun

Please, rebase this PR on latest master branch because there are merge conflicts during presubmit.

@medb Rebased!

Ack error, working on it.

Hmmm ok, it may make sense to drop support for 1.5 altogether. Do you happen to know whether or not there are Spark 2.x / Scala 2.12 jars available in #784?

H Brad, I will let you know asap, asking internally

Ack error, working on it.

@medb fixed!

H Brad, I will let you know asap, asking internally

@mengdong thanks!

@medb all comments should be addressed


Minimap doesn't respect visibility settings in diff editor

monaco-editor version: 0.10.0
Browser: Safari 11
OS: macOS
Steps or JS usage snippet reproducing the issue:
I'm constructing a monaco diff editor using roughly the following code. With the minimap setting's enabled property set to false, a minimap is still shown in the editor. Anything I can try?
        const editor = monaco.editor.createDiffEditor(
            document.getElementById("container"),
            {
            lineNumbers: "off",
            minimap: {
                enabled: false
            },
            scrollbar: {
                horizontalScrollbarSize: 5,
                verticalScrollbarSize: 5
            },
            scrollBeyondLastLine: true,
            wordWrap: "off",
            fontFamily: "SFMono",
            fontSize: 12,
            theme: "vs-dark",
            renderSideBySide: false,
            readOnly: true,
            }
        );

        editor.setModel({
            original: monaco.editor.createModel(file1Value, undefined, monaco.Uri.parse(file1)),
            modified: monaco.editor.createModel(file2Value, undefined, monaco.Uri.parse(file2))
        });

Upon further investigation, this is not a minimap, but instead a "diff overview ruler". It's working as intended.

@IMcD23 did you find a way to disable or edit this diff ruler somehow?


python memory_profiler: 0.27 -> 0.39

Tested. Caused no problems.

licenses.bsd doesn't exist, causing an evaluation error. We have various variants in there.

@vcunat thanks for noticing. Fixed in #11189 11189


popover-template directive - addresses issue #220

Addresses feature request "support template url for partial" #220
Improved over @joshdmiller PR #369
Updated from @jbruni PR #1046 for version 0.7.0
Resolves properly the ng-model binding issue seen at http://plnkr.co/edit/cbqOnktHhxSjeLIBE1w7?p=preview

+1

+1


How to diable animation?

Description
I want to disable animation in Files bc it makes my computer slower.
Steps To Reproduce
.
Steps to fix

eg. Fix crash that occurs when...
eg. Correct action happens when clicking...

Files Version
<IP_ADDRESS> OS Version: 10.0.19045.2251
Windows Version
Edition	Windows 10 Pro Version	22H2 Installed on	11/7/2022 OS build	19045.2251 Experience	Windows Feature Experience Pack 120.2212.4180.0
Relevant Assets/Logs
.

You can disable them in Windows settings > ease of access > Animations. It may be under one of the sidebar options.


MultiGrid examples are missing

https://bvaughn.github.io/react-virtualized/#/components/MultiGrid
The links to docs/source are gone but the demo is exactly what I'm trying to do.  Where did these go?

MultiGrid is a new component introduced in the upcoming 8.8 release. It's currently in a preview release (8.8.0-alpha.1) for users to test and give feedback. You can see its branch here: https://github.com/bvaughn/react-virtualized/tree/multi-grid
Once it's done, docs and stuff will be merged into master. Until then, please with the branch and give me feedback. There are a few known issues (that I'll be addressing with an alpha-2 release this evening).


Add contribution section to README

Outlines the way that one can contribute to the project or get help when needed.
Includes a link to a discord server as suggested in #30.

I accidentally branched off the wrong branch. Fixed it by rebasing.

I accidentally branched off the wrong branch. Fixed it by rebasing.

Ok, cool.

Ok, cool.

Can you separate the contribution section commit to merge?

Can you separate the contribution section commit to merge?


[Sema][SR-15161] Be more conservative when emit warning for bridge downcast

Just not emit such warning for conditional downcast when bridging from an optional type. As seen in the example
func f(e: Error?) {
  if let _ = e as? NSError { // warning: conditional downcast from 'Error?' to 'NSError' is a bridging conversion; did you mean to use 'as'?
    print("non-nil")
  } else {
    print("nil")
  }
}
enum MyError: Error {
  case fail
}

let nserror = NSError(domain: "domain.com", code: -1, userInfo: nil)

f(e: MyError.fail) // non-nil conditional down cast and bridge
f(e: nserror) // non-nil just conditional down cast
f(e: nil) // nil

this should be valid and a warning is not correct in this case.

Resolves SR-15161.

@swift-ci Please smoke test


Missing new schemas (e.g. uap13)

There are multiple new schemas that are missing from the list of schemas and related Windows version.
For example, uap13.

Thanks for catching this. This page has been neglected for a while. I've updated the list with the most recent schemas and verified the releases against the source code.


Disk Drive takes control of keyboard input

Please make it so the Priority box is not selected automatically when you open the DD GUI and can you also make it so that it's deselectable (click anywhere off the priority box).  As it stands you have to press ESC to close the GUI and I'm always typing e in the priority box.
Same with "grid"

There are some more blocks that have the priority field autoselected, will change that.
For the grid, I am not too sure. It is very handy that that field is autoselected, but I might make it an option.

Yeah could always give the JEI button a 3rd option to not search.

Fixed in master

I released a 0.5.6 version on Curse that fixes this error.


Add overload for OpenSentEmails

@mazhelez Which tests should be foreseen? I think there are currently no tests for the OpenSentEmails.

@mazhelez Which tests should be foreseen? I think there are currently no tests for the OpenSentEmails.

There's at least OpenRelatedEmailsForRecord test :)
And even if there weren't any tests, do not shy away to be the first one to add some!

PR has been uptaken for BC version 20 :)


P-ResNet Architecture

Create a ResNet architecture where instead of using a Linear layer as the output, use a PAGNN.

Currently in the works under the p-resnet branch.

CIFAR:
Epoch: 349
[============================ 391/391 ===========================>]  Step: 17ms | Tot: 7s763ms | Loss: 0.017 | Acc: 99.482% (49741/50000)
[============================ 100/100 ===========================>]  Step: 6ms | Tot: 1s253ms | Loss: 0.556 | Acc: 87.970% (8797/10000)

ImageNet:
P-ResNet50:
75.5% top-1 | 92.7% top-5
Normal ResNet50:
76.2% top-1 | 93% top-5


cdk deploy Applications fails with error: no endpoints available for service "aws-load-balancer-webhook-service"

Description
cdk deploy Applications fails with the following error:
Received response status [FAILED] from custom resource. Message returned: Error: b'serviceaccount/petsite-sa created
service/service-petsite created deployment.apps/petsite-deployment created Error from server (InternalError): error
when creating "/tmp/manifest.yaml": Internal error occurred: failed calling webhook "mtargetgroupbinding.elbv2.k8s.aws":
Post "https://aws-load-balancer-webhook-service.kube-system.svc:443/mutate-elbv2-k8s-aws-v1beta1-targetgroupbinding?timeout=10s":
no endpoints available for service "aws-load-balancer-webhook-service"'
Logs: /aws/lambda/Applications-ApplicationsMyCluster-Handler886CB40B-8Jm2SKKdx3fi at invokeUserFunction (/var/task/framework.js:2:6)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at async onEvent (/var/task/framework.js:1:302) at async Runtime.handler (/var/task/cfn-response.js:1:1474)
(RequestId: 33613a8c-ea0a-4d60-b3c7-4131a54df851)

so we couldn't really make much progress, as this setup step is needed, before getting into the more interesting content of the workshop

Can you please try redeploying the app?


create server error: failed to set boot order

reproduction steps

create server with the following options:

{
    "datacenter": "IL",
    "image": "ubuntu_server_18.04_64-bit",
    "cpu": "1A",
    "ram": "1024",
    "disk": "size=10",
    "dailybackup": "no",
    "managed": "no",
    "network": "name=wan,ip=auto",
    "quantity": 1,
    "billingcycle": "hourly",
    "monthlypackage": "",
}

wait for command to complete

expected

server created, command completes successfully

actual

command failed with error status:

{
  'id': 529044823,
  'status': 'error',
  'server': '',
  'description': 'ktb-6BADvHo-202008160912 - Create Server',
  'added': '2020-08-16 09:13:36',
  'executed': '2020-08-16 09:14:24',
  'completed': '2020-08-16 09:21:42',
  'log': '2020-08-16 12:14:24: Zone: IL\nName: ktb-6BADvHo-202008160912\nCPU: 1 Availability\nRAM: 1024MB\nImage Name: ubuntu_server_18.04_64-bit\nDisk #1: 10GB\nNetwork #1: wan-il - <IP_ADDRESS> @ 00:50:56:0b:20:0f\nDaily Backup: No\nManagement Services: No\nBilling: Hourly\n2020-08-16 12:14:43: creating filesystem\n2020-08-16 12:14:43: generating hard disks\n2020-08-16 12:15:24: registering with host\n2020-08-16 12:17:48: adding networks\n2020-08-16 12:18:19: connecting hard disks\n2020-08-16 12:18:21: configuring operating system\n2020-08-16 12:21:41: failed to set boot order\n2020-08-16 12:21:42: ERROR: failed to set boot order \nThis might be due to an internal error,\nPlease try again or contact support.'
}

https://github.com/Kamatera/cloudcli/runs/990077674#step:3:712

{'id': 529044823, 'status': 'error', 'server': '', 'description': 'ktb-6BADvHo-202008160912 - Create Server', 'added': '2020-08-16 09:13:36', 'executed': '2020-08-16 09:14:24', 'completed': '2020-08-16 09:21:42', 'log': '2020-08-16 12:14:24: Zone: IL\nName: ktb-6BADvHo-202008160912\nCPU: 1 Availability\nRAM: 1024MB\nImage Name: ubuntu_server_18.04_64-bit\nDisk #1: 10GB\nNetwork #1: wan-il - <IP_ADDRESS> @ 00:50:56:0b:20:0f\nDaily Backup: No\nManagement Services: No\nBilling: Hourly\n2020-08-16 12:14:43: creating filesystem\n2020-08-16 12:14:43: generating hard disks\n2020-08-16 12:15:24: registering with host\n2020-08-16 12:17:48: adding networks\n2020-08-16 12:18:19: connecting hard disks\n2020-08-16 12:18:21: configuring operating system\n2020-08-16 12:21:41: failed to set boot order\n2020-08-16 12:21:42: ERROR: failed to set boot order \nThis might be due to an internal error,\nPlease try again or contact support.'}

https://github.com/Kamatera/cloudcli/runs/990077674#step:3:814

{'id': 529044823, 'status': 'error', 'server': '', 'description': 'ktb-6BADvHo-202008160912 - Create Server', 'added': '2020-08-16 09:13:36', 'executed': '2020-08-16 09:14:24', 'completed': '2020-08-16 09:21:42', 'log': '2020-08-16 12:14:24: Zone: IL\nName: ktb-6BADvHo-202008160912\nCPU: 1 Availability\nRAM: 1024MB\nImage Name: ubuntu_server_18.04_64-bit\nDisk #1: 10GB\nNetwork #1: wan-il - <IP_ADDRESS> @ 00:50:56:0b:20:0f\nDaily Backup: No\nManagement Services: No\nBilling: Hourly\n2020-08-16 12:14:43: creating filesystem\n2020-08-16 12:14:43: generating hard disks\n2020-08-16 12:15:24: registering with host\n2020-08-16 12:17:48: adding networks\n2020-08-16 12:18:19: connecting hard disks\n2020-08-16 12:18:21: configuring operating system\n2020-08-16 12:21:41: failed to set boot order\n2020-08-16 12:21:42: ERROR: failed to set boot order \nThis might be due to an internal error,\nPlease try again or contact support.'}

https://github.com/Kamatera/cloudcli/runs/990077674#step:3:864