runspace.ps1 fails comparing versions when running with arguments

Describe the bug
Running runspace.ps1 w/ arguments on a fresh installation w/o winget gives the following output.
====Chris Titus Tech=====
=====Windows Toolbox=====
VERBOSE: Arguments Detected, Running Args
VERBOSE: Installing Microsoft.WindowsTerminal,Git.Git.
WARNING: 10/23/2022 22:01:59 | Warning | Winget is not supported on this version of Windows (Pre-1809). Stopping installs
Thank you for using winutil!
The GUI version runs correctly.
To Reproduce
Steps to reproduce the behavior:

New installation - I  used a fresh Win10 sandbox that is still on "2004".
$env:args="Install:Microsoft.WindowsTerminal,Git.Git"
[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12;iex(New-Object Net.WebClient).DownloadString('https://raw.githubusercontent.com/ChrisTitusTech/winutil/[main¦test]/runspace.ps1')
See error

Expected behavior
winget shall be installed
Screenshots
.
Additional context
Started ISE / set breakpoint at - if (($sync.ComputerInfo.WindowsVersion) -lt "1809")
The value of $sync.ComputerInfo.WindowsVersion is "2004" and it compares and runs as expected.
Ended debugger and tried once more - issue is still there.
[later]
Could it be asynchronous processing and bad timing? Yes!
Added a "sleep -s 3" just before "if (($sync.ComputerInfo.WindowsVersion) -lt "1809")" and it works fine.
I run it at least 20 times, always sucessful as below.
====Chris Titus Tech=====
=====Windows Toolbox=====
VERBOSE: Arguments Detected, Running Args
VERBOSE: Installing Microsoft.WindowsTerminal,Git.Git.
VERBOSE: 10/23/2022 22:02:43 | INFO | WinGet was not detected
VERBOSE: 10/23/2022 22:02:43 | INFO | Installing WinGet

Nice find! Most likely a timing issue.
I pull the computer info via a runspace to populate this info without delaying the GUI. However looks like the arguments allow the install process to start before that info is completed.
https://github.com/ChrisTitusTech/winutil/blob/7adfb649d4ad8c5d7e6235dc876903961808cd03/runspace.ps1#L1262
Going to have to update the runspace.ps1 soon as I made an update to the applications json to work better with winutil.ps1 #326 so I will include a fix with that.

I am unable to replicate it, can you try adding this to the if($env:args) block and see if that helps?
$x = 1
do{
    Start-Sleep -Seconds 1
    $x++
}until($sync.ComputerInfo -or $x -eq 5)
if($x -eq 5){Invoke-command $sync.WriteLogs -ArgumentList ("WARINING","Failed to pull computer info after 5 seconds, this cause cause some scripts to fail.", $sync.logfile)}

Should look like this

That works for me.   But normally it was 1 to 3 seconds. I did add two messages with time stamp for local testing.
#Ensure Computer Info is populated before continuing
Invoke-command $sync.WriteLogs -ArgumentList ("INFO","Waiting for computer information", $sync.logfile)
$x = 0
do{
    Start-Sleep -Seconds 1
    $x++
}until($sync.ComputerInfo -or $x -eq 5)
if($x -eq 5){Invoke-command $sync.WriteLogs -ArgumentList ("WARINING","Failed to pull computer info after 5 seconds, this cause cause some scripts to fail.", $sync.logfile)}
else {Invoke-command $sync.WriteLogs -ArgumentList ("INFO","What took you so long", $sync.logfile)}

There was a little flaw in the logic. Counting from 1 to 5 gives 4 seconds only.

Good deal, I updated the time out to 10 seconds and updated the logic ($x = 0 instead of 1)

Durp fixed this in the last update closing issue.


Only throw deprecation when user explicitly sets option

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
fixes #37

Documentation
/

License
MIT

What's in this PR?
This pr fixes the issue so the deprecation notice is only throw when the users sets the "respect_cache_headers" option.

Thank you


DBZ-1958 MongoDB driver 3.12.3 upgrade

https://issues.redhat.com/browse/DBZ-1958

LGTM, awaiting CI:

Applied, thx!


It stopped working fine all of the sudden and I get this error  IErrorInfo.GetDescription failed with E_FAIL(0x80004005).

I get the following error most of the times and sometimes it works with one file but then it doesn't work anymore and I get the same error. Can anyone help? I don't know what else to do.
at System.Data.OleDb.OleDbConnectionInternal..ctor(OleDbConnectionString constr, OleDbConnection connection)
   at System.Data.OleDb.OleDbConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningObject)
   at System.Data.ProviderBase.DbConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionFactory.CreateNonPooledConnection(DbConnection owningConnection, DbConnectionPoolGroup poolGroup, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at System.Data.ProviderBase.DbConnectionInternal.OpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory)
   at System.Data.OleDb.OleDbConnection.Open()
   at LinqToExcel.Query.ExcelUtilities.GetWorksheetNames(ExcelQueryArgs args)
   at LinqToExcel.Query.ExcelUtilities.GetWorksheetNames(String fileName, ExcelQueryArgs args)
   at LinqToExcel.ExcelQueryFactory.GetWorksheetNames()
   at Brenock.Excel.ExtendedExcelHelper.GetDynamicWorksheetData(String fileName, String sheetName) in C:\Users\amartinez\Documents\IMS_4.0\Brenock.IMS.BL\Excel\ExtendedExcelHelper.cs:line 37
   at Brenock.IMS.BL.Logic.OnboardRevenueLogic.ImportActuals(String fullFilePath) in C:\Users\amartinez\Documents\IMS_4.0\Brenock.IMS.BL\Logic\OnboardRevenueLogic.cs:line 637

0x80004005 is not a very specific error. Without more details, I can only guess. The excel file could be open in another program, or maybe anti-virus is interfering, or perhaps the file is corrupt?


Bump knative 1.4

Insert JIRA Issue number and update link
PR owner checklist
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] The layers in the kustomize folder have been updated accordingly.
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Deploy BOT
Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

Should you add a (temporary, or non-invasive) change to a pom.xml on this too; to confirm GHA's are OK?

In the original PR from @matzew there are also other small changes on an annotation.
See

https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1090/files#diff-282358aebc55f845bd533b6c3aa89c5aea1d011ce8aae3fcd6293dc9eb2908f7
https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1090/files#diff-dbeb6861d2c2c1812b0722a98b2b494a2ada725a8c300724d3f5b1edca1b1d70
https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1090/files#diff-a8ccce23b8ed8e5b4a92c012fb2f5d0f51d66764542bf0c5e245a99a2c17ee95

As far as I know it is only deprecated so it should work also without that change

error: from storage-version-migration-eventing-: cannot use generate name with apply

In the original PR from @matzew there are also other small changes on an annotation. See

https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1090/files#diff-282358aebc55f845bd533b6c3aa89c5aea1d011ce8aae3fcd6293dc9eb2908f7
https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1090/files#diff-dbeb6861d2c2c1812b0722a98b2b494a2ada725a8c300724d3f5b1edca1b1d70
https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1090/files#diff-a8ccce23b8ed8e5b4a92c012fb2f5d0f51d66764542bf0c5e245a99a2c17ee95

As far as I know it is only deprecated so it should work also without that change

We already migrated to the new annotations

trying to install 1.5 according to the official docs.. https://knative.dev/v1.5-docs/install/

Upgrade test fail is expected - as the CI tries to install dependencies using scripts from main branch.


Fix twitter link

cdk-dev isn't a valid twitter name. cdkdev and cdk_dev are taken.
Happy for suggestions for better naming than cdkdev_ :)

Merging for now to fix the link. Still curious if someone has a better name idea though :)


Removed parameters.yml and sqlite database files from repo

@norzechowicz thanks for your pull request. I was expecting a PR like this, but I didn't expect it that soon!
Sadly I must close this PR without merging it. The reason? This demo application must work out-of-the-box without configuring anything or executing any command. That's why we link compiled CSS/JS instead of using Assetic, we provide a SQLite database with the sample data instead of forcing the user to create the database and load fixtures, etc.
This application is for the absolute Symfony beginner, so everything must work right without doing anything. I hope you understand it :)

Yea I see the point of keeping the database file but not the parameters.yml, even absolute Symfony beginner needs to install dependencies and this will trigger generating parameters.yml  but correct me if I'm wrong.

@norzechowicz when installing this application via the symfony demo command, the installer will download a ZIP/TGZ package with all the vendors and everything included. Composer won't even be necessary to download, install and test the demo application.

Why not configure database in config.yml? You don't have to store database connection parameters in parameters.yml.
It is a bad practice to keep parameters.yml in VCS repository.

It's also bad practice to keep whole database in repository.

@michalpipa you are right (and @norzechowicz) is also right. It's a good practice to not put parameters.yml in the repository. That's what we explain in the Best Practices book.
But this application is a very special piece of software. It's designed as a learning tool for the absolute beginner. What we want is that you execute the "symfony demo" command in the Symfony Installer ... and 10 seconds later you have downloaded and installed a full Symfony application that works without executing any command or doing any change.

Hi guys!
I totally agree with Javier :). But what we can do is add comments in the code to help guide the beginners as they're discovering things.
@javiereguiluz I do have one idea I'd like your thoughts on. What if we didn't commit parameters.yml nor the database. But we did have a parameters.yml.dist (we already do) and a app/data/blog.sqlite.dist. We could then have 1 very simple "prep" step that copied both of these to parameters.yml and blog.sqlite respectively right before creating the tar. I want to keep things simpler, but this might be a nice way to keep things very very easy, but include more examples of good practices.

@weaverryan I propose you something: let me finish the symfony demo command and all the other things to make this a reality. And once we test the actual command and the experience, let's see how we can improve it, or how much can we change it without degrading it. We won't have to wait long, because everything should be finished very soon.

:+1: Love that we'll be able to iterate and improve the demo very easily. So yea, no rush to do this


Quick 180 degree flip

My setup only allows me to use 2 cameras, so was wondering if it were possible to map a button to one of the controllers so i could quickly turn 180 degrees. Perhaps i could configure the steamvr.vrsettings file but wouldn't know how to map the rotation as a button. If anyone has any idea on how you can get this to work, please let me know. This would really help.
Thanks

you can use walkinvrdriver.com


Bug 1704767: S2I incremental build not working

S2I incremental builds were failing due to not having the correct authoration
to pull the previously built image.

/assign @adambkaplan

/lgtm

/retest


[Docs] Clarify ClusterMesh troubleshooting steps when KVStoreMesh is enabled

when the KVStoreMesh is on, I find the debug steps are not in line with the facts, the hostAliases does not exist in Cilium DaemonSet, but exist in the clustermesh-apiserver deployment
the chart code
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: cilium
  namespace: {{ .Release.Namespace }}
  labels:
    k8s-app: cilium
    .....
      {{- if and .Values.clustermesh.useAPIServer .Values.clustermesh.config.enabled (not .Values.clustermesh.apiserver.kvstoremesh.enabled) }}
      hostAliases:
      {{- range $cluster := .Values.clustermesh.config.clusters }}
      {{- range $ip := $cluster.ips }}
      - ip: {{ $ip }}
        hostnames: [ "{{ $cluster.name }}.{{ $.Values.clustermesh.config.domain }}" ]
      {{- end }}

apiVersion: apps/v1
kind: Deployment
metadata:
  name: clustermesh-apiserver
  .......
      hostAliases:
      {{- range $cluster := .Values.clustermesh.config.clusters }}
      {{- range $ip := $cluster.ips }}
      - ip: {{ $ip }}
        hostnames: [ "{{ $cluster.name }}.{{ $.Values.clustermesh.config.domain }}" ]
      {{- end }}

and the remote cluster address does not exist in the secret cilium-clustermesh, but exist in the secret cilium-kvstoremesh
[root@master1 ~]# kubectl get secret -n kube-system cilium-clustermesh -o yaml | yq '.data' | awk '{print $2}' | base64 -d
endpoints:
- https://clustermesh-apiserver.kube-system.svc:2379
trusted-ca-file: /var/lib/cilium/clustermesh/common-etcd-client-ca.crt
key-file: /var/lib/cilium/clustermesh/common-etcd-client.key
cert-file: /var/lib/cilium/clustermesh/common-etcd-client.crt

[root@master1 ~]# kubectl get secret -n kube-system cilium-kvstoremesh -o yaml | yq '.data' | awk '{print $2}' | base64 -d
endpoints:
- https://cluster2.mesh.cilium.io:32379
trusted-ca-file: /var/lib/cilium/clustermesh/common-etcd-client-ca.crt
key-file: /var/lib/cilium/clustermesh/common-etcd-client.key
cert-file: /var/lib/cilium/clustermesh/common-etcd-client.crt

/test

@weizhoublue Could you maybe update the CODEOWNERS file to add sig-clustermesh as an owner of the docs you changed? That is:
Documentation/operations/troubleshooting_clustermesh.rst @cilium/sig-clustermesh @cilium/docs-structure

But it's only tangentially related to the change, so it's fine to merge the change as is IMO.

my pleasure, and updated

/test

the PR seems to have no business failing the connectivity test of the check
should I rebase the main branch ?

@weizhoublue yeah, the CI fail seems completely unrelated, it shouldn't block the merge I think

some connectivity case failed, I try to rebase again

/test

@weizhoublue It was probably a flake, don't worry about it. The checks relevant to your change passed, so once there is an approve from contributing the PR can be merged.

thanks

@weizhoublue It looks like this PR needs to be rebased to pick the latest CI changes

@weizhoublue It looks like this PR needs to be rebased to pick the latest CI changes

ok

/test


Plugin is not added when using import

Description
When using imports, the plugin is not registered on video.js
Steps to reproduce

Create a new project with create-react-app.
Add video.js and video.js-offsest
In a VideoPlayer component (https://docs.videojs.com/tutorial-react.html) add this at the top:

import React from "react";
import videojs from "video.js";
import "videojs-offset";

Results
Expected
The plugin should work ok.
Error output
TypeError: this.offset is not a function
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
^7.3.0
I could make this work by registering the plugin manually:
import offset from "videojs-offset";

videojs.registerPlugin("offset", offset);

I've also tried to select a video.js version that corresponds with the one in videojs-offset package.json.
I think what happens is that the plugin is registered for its own version of video.js.

Hi @nicu-chiciuc, yeah I'm experiencing this issue as well in my projects and it is probably related to this issue as well #38.
I don't have a fix for that but I'm investigating.


Bump snappy-java version to support Apple silicon

To fix issue
https://github.com/clj-commons/byte-transforms/issues/8
bum snappy-java to a compatible version
https://github.com/xerial/snappy-java/releases/tag/<IP_ADDRESS>

@zac1st1k Thanks for this PR.
I can't personally verify it, since I don't have an ARM mac. Maybe @slipset knows how to set up CircleCI to test on Apple silicon, but I don't want to hold you up, so I'm approving.

Fixes #8

Hey @zac1st1k , I was going to credit you in the new changelog. How would you like to be listed? Github username, just Zac, Zac Lastname (I'll need your last name), or something else?
If it's faster, I can be reached at kingmob on the Clojurians slack.

I found your last name from your email, it's Xu, correct?

Hey @KingMob , yes, it's Xu! Thanks a lot!
I have verified the PR as screenshot shows below.


Missing files!

Where is dist folder mentioned in samples! how this thing works!?

If you want to build the library locally, you can do:
npm i

to install all the dependencies and
gulp js

to build the un-minified version.

Thanks Sepand
I know that, I'm going to use it in a ASP.NET project. I'm interested neither in nmp/nodejs nor gulp!

I kind of agree with this.

I'm working on updating the CDN version (which was last updated at 0.2.0 :cry:). I think that is the most logical place if you just want to grab the pre-built version. 0.2.0 is available at:
https://ajax.googleapis.com/ajax/libs/incrementaldom/0.2.0/incremental-dom.js
Once updated, 0.5.0 will be available at:
https://ajax.googleapis.com/ajax/libs/incrementaldom/0.5.0/incremental-dom.js
I'll close this bug once it has been updated.

Version has been updated, you can grab it via CDN or download and rehost:
https://ajax.googleapis.com/ajax/libs/incrementaldom/0.5.0/incremental-dom.js
https://ajax.googleapis.com/ajax/libs/incrementaldom/0.5.0/incremental-dom-min.js
Updated the README with links to version 0.5.0

You can also use unpkg: https://unpkg.com/incremental-dom
On Sat, 17 Sep 2016, 07:04 Sepand Parhami<EMAIL_ADDRESS>wrote:

Closed #276 https://github.com/google/incremental-dom/issues/276.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/incremental-dom/issues/276#event-792676386,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIVbOtZ9RHSax1CH7bY75YDxmGvDT98ks5qqwRrgaJpZM4Iuso-
.


Fusionstorage driver support for Fusionstorage storage device version 8.0

What this PR does / why we need it:
This pr implements fusionstorage driver in hotpot support for the fusionstorage storage device version 8.0.
Special notes for your reviewer:
@wisererik @leonwanghui please take a look at this pr.

Coverage decreased (-0.1%) to 30.125% when pulling cedc97526bd308c90d4ed70a8155833f1153bcc8 on jackhaibo:fusionstorage into e8037398d7af5c9fed568d5bf7e10c66336e5fad on opensds:development.

previous
Test passed, while supporting versions 6.3 and 8.0.

Please update your code to latest version.


[Feature] Non-Time-Series "Measure"

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
I propose introducing a non-time-series "measure" for storing certain types of data where the time dimension is irrelevant. The primary aim of this measure is to improve performance, particularly for service, instance, endpoint, and process traffic.
Currently, time-series data structures are used even when the time component is not significant, which results in unnecessary overhead when querying and storing data. By implementing a new non-time-series measure where all relevant data is stored in the series index, we can optimize performance and reduce complexity for specific use cases.

Add "non-time-series" field to "Measure"  that focuses on the series index for storing the necessary data fields.
Series Index as Primary Storage. Instead of storing values in a time-series format (i.e., with timestamps), the data could be stored primarily in the series index.

Use case
No response
Related issues
No response
Are you willing to submit a pull request to implement this on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please submit an issue to track OAP side changes. We should adopt this as validate it on demo env.
This should be a significant change in 0.8.


Change add_noise to match the target variance by scaling by its sqrt.

Resolve issue #281.
Add a test for this noise scaling which fails prior to this change.

Edited to avoid sqrt after type casting.

It's probably just a matter of changing the parameters
I've rebased and changed eta to match the previous initial variance. It survives the test with the different decay rate.

but we should make sure this is indeed the reason.
The test passes now (and also passed if just removing the noisy_sgd line.


test: overwrite feathers with secret for testing

Notify TestWebhook1
Testing testing 1 2 3

/test peacock-release-test

/test peacock-release-test

/test peacock-release-test

/test peacock-release-test


Is DPCM supported?

(Sorry for machine translation.)
Is DPCM channel supported?
The Famistudio 4.1.0 sound driver used in the software supports DPCM, but when I build the ROM, only the DPCM channel sound timing information works, the DPCM instrument information does not play correctly and is noisy.
Sorry if this is an entry level problem due to my lack of ability to solve it, but is there any chance that this problem can be solved by including the dmc file data to the proper address?
Thanks.

Sorry, DPCM is not really supported yet. A big reason for that is the fixed code bank is nearly full in the alpha release.
Even if you could make it work, I don't think you'll have enough space in the fixed bank to do much interesting stuff with so little sample data.
The text dialog support also uses somewhat strict cycle timing to avoid PPU glitches, and DPCM would throw that off, requiring a rethink of that part.
But DPCM support is planned for future versions. It will just take some time to get there.

Thanks for the reply!
In any case, it is a great software and I thank you for supporting the famistudio sound driver and will actively use it!

Thanks for the reply!
In any case, it is a great software and I thank you for supporting the famistudio sound driver and will actively use it!


feat: implemented RAG system with support for multiple document uploads

Implement RAG system with support for multiple document uploads
This PR implements a RAG (Retrieval-Augmented Generation) system that supports uploading up to 2 documents.
Related Issues
Updates #7
Changes Made

Limiting file uploads to a maximum of 2 documents
Processing and extracting content from uploaded files
Creating a vector store from the extracted contents
Setting up a RAG chain using the vector store and LLM
Modifying the response generation to use the RAG system when documents are uploaded

@Sammybams Kindly review my PR

Thank you very much @Firdous2307 for your contribution. At this moment we will not be able to merge because we plan to use The DocArrayInMemorySearch as the vector store based on how Streamlit works. You would find this in one of the other issues opened. And the implementation of the chunking function has already been done in the functions.py script so didn't need to be implemented in the main script. The function from there could have been called.
Also you removed some of the logging functions that were already part. Please, we would appreciate appropriate testing of your implementation as the project is now getting to a critical stage and would be needed sample screenshots/snippets of your PRs. Thank you very much once again.

@Sammybams Thank you for the feedback! I understand the direction you're taking with DocArrayInMemorySearch and will review the other issues for more context. I'll also make sure to utilize existing functions like chunking from functions.py and keep the logging intact in future implementations. I'll focus on thorough testing and include relevant screenshots/snippets in my PRs moving forward. Thanks for the guidance!


docs: add banner and toggle config for previous versions

Updated style and HTML to always have previous versions banner available.
Added toml config to disable by default. This can be changed to enable when newer release is available.
Updated readme with correct instructions

Signed-off-by: Zach Rhoads<EMAIL_ADDRESS>

Feedback from @keithmattix reminded me to remove old release versions from the versions list in main. This avoids carrying unsupported versions when we cut a release branch


:robot: Triggering CI on branch 'release-next' after synching to openshift/master

/retest

/approve
/lgtm

OCF Webhook is merging this PR

OCF Webhook is merging this PR


C++ Support

hi,
is the c++ support is available with current infer release?
I can see issues #24, #261 and #528 had the similar request, so I just wanted to know if there is any existing release or any plan for the C++ support release in near future!

Yes, the current release has already C++ support. Current master has even better support as it's been a few months since the last release.


[Caching] Fix stack-use-after-scope in CachedDiagnostics

Fix a stack-use-after-scope in the CachedDiagnostics when the DiagnosticInfo entry that is getting deserialized has ChildDiagnostics.
There are some fields in the DiagnosticInfo are not owned by the DiagnosticsInfo itself. While the callback during the deserialization ensures those fields are still alive for the top level DiagnosticInfo when it gets used, it is not true for any child diagnostics info inside.
rdar://123846525

@swift-ci please smoke test


Bug fixing : validation for term and type payment

Coverage increased (+0.007%) to 72.091% when pulling 68e4838af2cd6c619aeb211f10d07eb1c0ca62cd on indriHutabalian:dev into f86e61c466123390679b331c330c8e5dd9c62ac9 on danliris:dev.

Coverage increased (+0.007%) to 72.091% when pulling a30ebf766111687ec809777247a5bd5187f083fb on indriHutabalian:dev into f86e61c466123390679b331c330c8e5dd9c62ac9 on danliris:dev.

Coverage increased (+0.007%) to 72.091% when pulling 4a759e46fd415cd840e46137ab2d67a6b80e901e on indriHutabalian:dev into f86e61c466123390679b331c330c8e5dd9c62ac9 on danliris:dev.


Best way to wrap Japanese and Thai text?

Hello,
This library is amazing. It is so fast. Using it I was able to check large sets of data by writing to the same canvas to test draw_text_wrapped function. Unfortunately, as the title implies, I found one small gap: text wrapping for Japanese isn't perfect. When I try to write out Japanese strings which contain 、 glyphs (and possibly others), they do not wrap and end up exceeding beyond the bounds of the canvas. I don't know if there is a better library in Python which can handle this. I couldn't find one and the built-in textwrap function doesn't work great on Thai language.
Do you know what the best way to implement Kinsoku Shori support? https://en.wikipedia.org/wiki/Line_breaking_rules_in_East_Asian_languages#Line_breaking_rules_in_Japanese_text_(Kinsoku_Shori)
Using something like https://github.com/google/budou won't work for my application, since I want to distribute it to work with minimal setup/configuration (no web credentials). I don't know if there is a better regex-based approach which would allow me to pre-split my strings/insert spaces/hyphens.

Hey, currently the library does not break words but I'll look into adding support for that. The draw_text_wrapped overflows because of this limitation.
I think it might be out of the scope of the project to implement specific line-breaking rules, and I'm not too sure the best way to go about implementing something like what google's budou provides. If you do need better line breaking you can always split the lines beforehand and pass it to draw_text_multiline.

I added a WrapStyle to the base rust library which supports both word and character boundaries, I'll be adding support for it in this library now.

That's great.
I thought about alternative solutions for my project, I'm not as concerned at proper language-specific wrapping, but would rather have wrapping which is 'good enough'. Maybe my solution might be good enough for other users...
I am using a 300 pixel wide x 450 pixel tall area with monospace fonts (sarasa-cl, notosans, and JetBrainsMono). I realized I'm essentially treating my printed text as a terminal, so for me the solution might be to use tabulate to layout all my text in a grid pattern (including empty white space characters) and add it to the canvas. Tablulate seems to work better since it uses wcwidth to calculate the unicode character width rather than len(). I'm not 100% sure what font my IDE (PyCharm) is using to print in the terminal; it's not clear what Pycharm/Windows is falling back to. Hopefully the chosen font matches close enough to the Sarasa font I'm using to print my image. Issue #20 in the JetBrainsMono repo discusses CJK font width issues (1:2 versus 3:5) compared to other monospace fonts. I might be overthinking this and be totally wrong (wcwidth should have nothing to do with fonts, right?). At least with tabulate I'm able to print text which wraps better and doesn't overrun the canvas.
The next challenge is figuring out when I can increase the font size, or if need decrease it, to make the most of my printable area. I also need to reserve some space for ruby characters (pinyin and bpmf) at the top and left sides of the canvas. Previously, when I was using Pillow's drawtext method, I tested rendering these text elements at different font sizes until the x1, y1, and x2, y2. I'd then use these numbers as the x offset to determine the starting positions of different elements. Running those loops took a lot of cycles. imagetext-py doesn't return the size information; trying to assign a draw_text_wrapped to a variable returns in None. I don't know if that is worthy of a feature request. I can probably make multiple tables and just use zip() to join each line of the strings to make the 'final' image.
I think in my case I can test how many characters I can fit in my printable area at different font sizes (by using the maxcolwidths argument) and counting the total number of line breaks to see if it exceeds the printable area.

imagetext-py does have text_size and text_size_multiline which u can use along side with draw_text_multiline, to get the sized of ur text before you draw.
If you are not using emojis, simply looping over different font sizes when checking the text size is fast enuf for finding the max font that can fit ur boundaries
ex.
    cv = Canvas.from_image(...)

    mw = 512
    mh = 512
    for size in range(200, 1, -1):
        lines = word_wrap(text, mw, size, font)
        w, h =  text_size_multiline(lines, size, font)

        if h < mh and w < mw:
            draw_text_multiline(canvas=cv,
                                lines=lines,
                                x=0, y=0,
                                ax=0, ay=0,
                                width=mw,
                                size=size, font=font,
                                fill=BLACK, stroke=2.0,
                                stroke_color=RAINBOW,
                                align=TextAlign.Center)
            break

As for the better text wrapping, I am completely rewriting the pipeline for wrapping, measuring text size, and creating text layouts. This will bring some minor speed improvements for regular text, and a massive speed increase for text containing emojis.

Awesome.
I may have uncovered a bug in text_size. It should return the width and height in pixels, right?
`from PIL import Image
from imagetext_py import *
import os
from pathlib import Path
root_folder = Path(os.getcwd()).absolute()
primary_font = str(Path(root_folder / "fonts" / "JetBrainsMono-Regular.ttf"))
f = Font(primary_font, fallbacks=None)
wx = 150
hy = 35
c = Canvas(wx, hy, (0, 0, 0, 255))
black = Paint.Color((255, 255, 255, 255)) # white
input_text = 'Sample Text'
w, h = text_size(input_text, size=30, font=f)
print(w, h) # printing "149 5", but it should be much taller.
draw_text(canvas=c,
text=input_text,
x=0, y=0,
size=30, font=f,
fill=black,)
im: Image.Image = c.to_image()
im.show()`

Yeah, there seems to be an issue with the text_size function, for now, use text_size_multiline and it should work.
I'll open an issue for this.


Installing v3.0.0 from Asset Library tries to add the whole repository

When installing v3.0.0 from the Asset Library, I noticed that all files and folders can be imported:

It's possible to uncheck some of the file/folders, but even then they will be placed widly in project root. It would be nice if files not needed in other projects were ignored, and others rearranged under addons/ or alternatively some sub-folder with a more specific name.

root files: .gitattributes, .gitignore, LICENSE.md, README.md, project.godot: just ignore them
documentation: ignore it, it's meant for GitHub (if you really want to distribute it then move it under addons/yet_another_behavior_tree together with the README.md/LICENSE.md)
examples: move it under addons/yet_another_behavior_tree, or at yet_another_behavior_tree/examples, or at examples/yet_another_behavior_tree so it's not confused with other add-ons with their own examples placed at the root. Generally speaking, I'd prefer having everything under the addons sub-folder
script_templates: this one is the standard path for Godot, so this can be kept. Besides, BTNode/ tells us what we're dealing with.

Note that I don't know how other add-ons like GUT manage to ignore files and folders. I've heard of .gdignore but GUT doesn't seem to use it, and it would only work for folders.

Should be okay now. Documentation and examples or ignored when exported from Github

Thanks. Just a minor issue: LICENSE.md is still exported.
I noticed it's duplicate with the one in add-ons, but maybe you want to keep a copy at the root so it applies to examples too, and GitHub detects it properly.
In this case, you could just add it to export-ignore.

I also realize the examples were quite useful, we'll have to think about a way to restore them in a clean way.
Either we keep them at the root and do not export-ignore them, but we add some sub-folder yet_another_behavior_tree as I suggested above. Or we move them completely under addons to follow the possibly incoming new standard where everything is under addons. I started a discussion on https://github.com/godotengine/godot-proposals/issues/554 to see what structure they prefer.
In the meantime, I'll just clone the repo and copy the examples.

OK, the issue you see just above (Examples bad zoom) has a discussion containing an argument against importing the examples by default (they may not work out of the box with certain game window settings).
I'll try to discuss this further with the Godot team, as allowing standalone examples would be great.


[#159730005] Update cf-deployment to v3.6.0

What
We updated our upstream, cf-deployment, to v3.6.0 from v2.6.0.
This PR must not be merged&deployed before alphagov/paas-bootstrap#182, and must be merged&deployed immediately after it. This is because the combination of these 2 PRs moves bosh-dns from paas-cf to paas-bootstrap and, unless their their deployment is tightly coupled, significant breakage will occur. Bosh-dns being moved from per-deployment to per-BOSH-director, via the runtime-config mechanism, is a requirement of cf-deployment v3.0.0+.
Bosh-dns being moved to the director's runtime-config means that a deployment's bosh-dns aliases can't be configured at the bosh-dns addon level. Instead, we include the bosh-dns-aliases job in the CF deployment (as an addon) and use its more verbose syntax [1].
All CF components are at the same version that cf-deployment v3.6.0 defines - we don't use any later versions. We removed some ops files which are either no-ops or irrelevant, and started using some of those which upstream consolidated (dc945ca). We removed our previous vendoring of ops files which install log-cache, since after cf-deployment v3.0.0 it's included by default.
We added our usual CA rotation tactic, and updated some of our tests to allow for some BOSH packages having -<stack> suffixes not surfaced in their containing jobs or releases. e.g. staticfile-buildpack-cflinuxfs2 instead of staticfile-buildpack.
[1] https://bosh.io/jobs/bosh-dns-aliases?source=github.com/cloudfoundry/bosh-dns-aliases-release&version=0.0.2#p%3Daliases
Review
This was paired on throughout, and is being released by @richardTowers, @tlwr and myself, with FIXME donating their access to prod.
Deployment plan: https://hackmd.cloudapps.digital/nZAnzvldRLqtxcEXbXoa6w?view#Deloyment-to-Production

As of https://github.com/alphagov/paas-cf/pull/1523 this is ZDD, as above: deploy and run https://github.com/alphagov/paas-bootstrap/pull/182 first


fix: stop npm from swallowing exit signals; run migrations on launch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
507

Relevant Lines:
507

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
507

Relevant Lines:
507

💛  - Coveralls


user12986714: Watch sachinajmeraclasses.com

user12986714 requests the watch of the watch_keyword sachinajmeraclasses\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

sachinajmeraclasses\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Nisse Engström in Charcoal HQ


Removing unicode whitespace and various lints

Hello,
Thank you for the package. Our group is very interested in it! I was unable to install the package due to the presence of an "ideographic space" character (0xE3 0x80 0x80) in the source code. I have removed instances of the character and have also made some additional changes to help it pass R CMD check.
I have several ideas to build upon the package and would be glad to send more PRs your way if your group is interested.
Thanks!

Looks good without conflicts.

Hi Paul,
Thank you for helping us! Let us know if you have any other suggestions.
Best,
Lili


HTML frontEnd webPage with controls

Hello,
Good work!
Is it possible to have an example with webPage (HTML) with buttons controls ? for changing current layer, etc.
I'm not so familiar with JS...
Thank you.

That's very nice!
thank you


[mini.test] Ability to ignore screenshot attributes

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.test
Description
Screenshots give the ability to compare what is displayed on the screen and how it is displayed. But sometimes I only care of what is displayed, not how it's displayed. The latter can change from the external changes like colorscheme or something. I think in some cases an additional option to ignore screenshot attributes can be useful.

Thanks for the suggestion!
The use case seems more or less valid, but an actual implementation would require a bit messy source code changes. Mostly because for completeness it would also require to allow users to ignore text in favor of comparing only attributes, which is not ideal for my taste.
In general, I think that validating screenshots in full (both text and attributes) is a good practice for a reliable test. Here is what you can do to make comparing only text less painful:

Manually set custom color scheme. The one over which you have full control. This is what is done in 'mini.nvim'.
If troubles come from only a certain known lines (which don't contain tested text), then you can use opts.ignore_lines. This is commonly useful to ignore command line text/attributes or lines that contain text varying on testing instance (like full paths).
Resort to testing buffer text explicitly via comparing child.api.nvim_buf_get_lines(0, 0, -1, false) to a reference array.

Closing as not planned.


Demo Kit: image thumbnail and caption clickable but nothing happens

Visit a Demo Kit documentation page that contains an image thumbnail with a caption. E.g. https://ui5.sap.com/#/topic/239b1922758645e7b451e01ded7f56bc (Scroll down to the "Additional Features in SAP Fiori Elements for OData V4" section to see them).
Click on "Message Popover: Chevron Navigation to Message Details" or the image thumbnail.

Apart from nothing happening on click, the layout seems to be incorrectly rendered too.
It is also unclear where the image thumbnails actually come from. The source https://github.com/SAP-docs/sapui5/blob/b33d3c0b11a6b7f5883bf9aea8ab14ceeae051e8/docs/06_SAP_Fiori_Elements/using-messages-239b192.md has no references to the thumbnails.

Hello @boghyon ,
thanks for spotting this. I checked the feature map, and expanding thumbnails generally works. But definitely not in this topic. I will try to correct this for the upcoming release. I'll also correct the layout.
But I don't quite understand what you mean in your last statement: "It is also unclear where the image thumbnails actually come from. The source https://github.com/SAP-docs/sapui5/blob/b33d3c0b11a6b7f5883bf9aea8ab14ceeae051e8/docs/06_SAP_Fiori_Elements/using-messages-239b192.md has no references to the thumbnails."
The topic simply wants to show that you can navigate to the details of a message from the message popover. That's what the thumbnail is showing.
The source of our documentation isn't on GitHub, but on UI5.sap.com. The topic there contains the thumbnail, GitHub apparently simply isn't displaying this one. I checked other topics such as https://github.com/SAP-docs/sapui5/blob/b33d3c0b11a6b7f5883bf9aea8ab14ceeae051e8/docs/06_SAP_Fiori_Elements/confirmation-popups-9a53662.md and the images there work fine (though they are not thumbnails).
So I hope that by updating the layout and providing the image your issue will be resolved.
Please note that the change won't become visible until the release of 1.110.
Thanks!

Hi @boghyon ,
Just so you don't think I've forgotten this: I haven't ;-)
This is a very puzzling issue, since in our internal test system where I checked everything looks perfectly fine. Just not in the external system. So I'm creating a ticket for this now myself.
As soon as this is fixed I'll let you know.
My apologies for not being able to provide a solution yet.

Hello @boghyon,
could you please check whether you are now able to expand the thumbnail?
(Please note that apparently, clicking on the arrow icon in the right-hand corner isn't how you open it; you need to click somewhere on the thumbnail itself (like in the middle)).
For me it works now. I checked multiple examples we use in the topic SAP Fiori Elements Feature Map (https://ui5.sap.com/#/topic/62d3f7c2a9424864921184fd6c7002eb), and all of them worked.
Could you please verify and if now hopefully everything works for you as well, close this issue?
If not, then please report back!
Thanks very much.

@JannaLisa I can confirm that the thumbnails can be now expanded to a LightBox. Thanks a lot! There is one issue left I mentioned in the issue description:

Click on "Message Popover: Chevron Navigation to Message Details" or the image thumbnail.

When clicking on the caption "Message Popover: Chevron Navigation to Message Details" nothing happens. Maybe it's not supposed to be clickable?

Hi @boghyon ,
what we're doing is using an attribute called 'minimized-small'. My initial assumption was that this is what's causing the title/caption to look like it's a link. But we use this attribute all over the place in the topic SAP Fiori Elements Feature Map (https://ui5.sap.com/#/topic/62d3f7c2a9424864921184fd6c7002eb) as well, and there the titles are fine.
I've now asked a colleague to investigate, let's hope he's able to come up with a solution.
I'm sorry, I'm simply stuck.
But I'll keep you posted.

Hi @JannaLisa, I also can't find any difference in our CCMS between the minimized image in https://ui5.sap.com/#/topic/239b1922758645e7b451e01ded7f56bc and in the Feature Map (https://ui5.sap.com/#/topic/239b1922758645e7b451e01ded7f56bc. So I tend to see this as a bug in the Demo Kit and nothing we can fix in the documentation source.
@boghyon: We will address this with the Demo Kit team and close this issue for now.


[Question] Update IDL

What I want to know is what command should I execute to update the server side template code after I have modified the idl file

Hello, if you want to update the idl version, you can use volo idl update.
However, the template cannot be updated (the lib.rs file), you need to manually add new functions you need.

Ok, tks~ By the way what does volo idl update command do. I found out that just the volo.yaml file had changed,

Yes, the command only update the git revision of idl, and when you execute cargo check or cargo build, the code will be re-generated.

Ok～


Source for example

Can you please provide the source for your example Modal test site?

No worries. Found it under resources/assets

@liftyourgame Closing as you found what you where looking for. 😄


TMPO Update simplification

Coverage increased (+0.6%) to 67.848% when pulling db1fd0d274b5a80830660c64487eb51d3b74de57 on JrtPec:develop into 42bf70a7e8c0312300d794027ec69ae7b6b22cd1 on opengridcc:develop.


Update js-untar

fix https://github.com/treasure-data/digdag/issues/1652
I updated js-untar to v2.0.0.
js-untar v0.1.4 doesn't terminate Web Worker after completing untar.
see: https://github.com/InvokIT/js-untar/pull/17

I confirmed when I access each workflow like 'http://localhost:65432/projects/4/workflows/no_error_arn, "Dedicated Worker" is added and never reduced in v0.10.4` and this PR fixed it.


[SimpleStyle] Smoother FlyingNotes...

...By changing the "Sine" from 220 to 229, set "IsUsingEasing" to 1.

Hello, do you have a video to show the difference between before/after ?


first item in breadcrumb has margin unless it belongs to an org

after discussion with @xavijam

Love this issue :tmwc:

https://github.com/CartoDB/cartodb/commit/48e1e32fa24b3a74796952cccd53f3d28e2062db


RFIs support

Hello, is it planed to add support for the RFIs API?
https://aps.autodesk.com/en/docs/bim360/v1/reference/http/rfis-v2-rfis-GET/

Hi, Although it's not on our immediate roadmap, I'll add it to the request list. Thanks!


Helm chart does not work with readonly filesystem

Describe the bug
The helm chart set the root file system to read only. But when starting off it wants to write cache-files.
I did a work around like https://github.com/nordeck/matrix-poll/compare/main...yncyrydybyl:matrix-poll:main
Environment:
I did that in an openshift cluster.

We set the writable folders as volumes in the Dockerfile. At least Docker and a containerd-based Kubernetes automatically creates temporary volumes for those folders. But we didn't tested it with OpenShift yet.
We could explicitly add emptyDir volumes for the required folders so CRI-O should also work.


Tests fail for the latest master build on macOS

The tests for "Code gen: debug" fail on macOS Sierra with an LLVM assertion:
Code gen: debug
  codegens abstract struct (#3578)Assertion failed: (!Filename.empty() && "Unable to create file without name"), function createFilePathPair, file DIBuilder.cpp, line 130.
make: *** [spec] Abort trap: 6

Steps to reproduce:

git clone https://github.com/crystal-lang/crystal.git
cd crystal; make clean crystal spec verbose=1

Expected output: a passing test suite.
Actual output:
rm -rf .build
rm -rf ./doc
rm -rf src/llvm/ext/llvm_ext.o
rm -rf src/ext/sigfault.o src/ext/libcrystal.a
c++ -c  -o src/llvm/ext/llvm_ext.o src/llvm/ext/llvm_ext.cc `/usr/local/bin/llvm-config-3.6 --cxxflags`
cc -fPIC    -c -o src/ext/sigfault.o src/ext/sigfault.c
ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
CRYSTAL_CONFIG_PATH=`pwd`/src ./bin/crystal build  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
./bin/crystal build  -o .build/all_spec spec/all_spec.cr
Using compiled compiler at .build/crystal
.build/all_spec -v
Compiler
  compiles a file
  runs subcommand in preference to a filename
Code gen: alias
  invokes methods on empty array of recursive alias (1)
  invokes methods on empty array of recursive alias (2)
  invokes methods on empty array of recursive alias (3)
  casts to recursive alias
  casts to recursive alias
  doesn't break with alias for link attributes
  doesn't crash on cast to as recursive alias (#639)
  lazyly solves aliases (#1346)
  codegens cast to alias that includes bool
  overloads alias against generic (1) (#3261)
  overloads alias against generic (2) (#3261)
Code gen: and
  codegens and with bool false and false
  codegens and with bool false and true
  codegens and with bool true and true
  codegens and with bool true and false
  codegens and with bool and int 1
  codegens and with bool and int 2
  codegens and with primitive type other than bool
  codegens and with primitive type other than bool with union
  codegens and with primitive type other than bool
  codegens and with nilable as left node 1
  codegens and with nilable as left node 2
  codegens and with non-false union as left node
  codegens and with nil union as left node 1
  codegens and with nil union as left node 2
  codegens and with bool union as left node 1
  codegens and with bool union as left node 2
  codegens and with bool union as left node 3
  codegens and with bool union as left node 1
  codegens and with bool union as left node 2
  codegens and with bool union as left node 3
  codegens and with bool union as left node 4
  codegens assign in right node, after must be nilable
  codegens assign in right node, inside if must not be nil
  codegens assign in right node, after if must be nilable
Code gen: array literal spec
  creates custom non-generic array
  creates custom generic array
  creates custom generic array with type var
  creates custom generic array via alias
  creates custom generic array via alias (2)
  creates custom non-generic array in nested module
Code gen: asm
  codegens without inputs
  codegens with one input
  codegens with two inputs
Code gen: block
  generate inline
  passes yield arguments
  pass arguments to yielder function
  pass self to yielder function
  pass self and arguments to yielder function
  allows access to local variables
  can access instance vars from yielder function
  can set instance vars from yielder function
  can use instance methods from yielder function
  can call methods from block when yielder is an instance method
  nested yields
  assigns yield to argument
  can use global constant
  return from yielder function
  return from block
  return from yielder function (2)
  union value of yielder function
  allow return from function called from yielder function

  return from block that always returns from function that always yields inside if block
  return from block that always returns from function that conditionally yields
  call block from dispatch
  call block from dispatch and use local vars
  break without value returns nil
  break block with yielder inside while
  break from block returns from yielder
  break from block with value
  returns from block with value
  doesn't codegen after while that always yields and breaks
  break from block with value
  doesn't codegen call if arg yields and always breaks
  codegens nested return
  codegens nested break
  codegens call with block with call with arg that yields
  can break without value from yielder that returns nilable (1)
  can break without value from yielder that returns nilable (2)
  break with value from yielder that returns a nilable
  can use self inside a block called from dispatch
  return from block called from dispatch
  breaks from while in function called from block
  allows modifying yielded value (with literal)
  allows modifying yielded value (with variable)
  it yields nil from another call
  allows yield from dispatch call
  block with nilable type
  block with nilable type 2
  codegens block with nilable type with return (1)
  codegens block with nilable type with return (2)
  codegens block with union with return
  codegens if with call with block (ssa issue)
  codegens block with return and yield and no return
  codegens while/break inside block
  codegens block with union arg (1)
  codegens block with union arg (2)
  codegens block with virtual type arg
  codegens call with blocks of different type without args
  codegens dispatch with block and break (1)
  codegens dispatch with block and break (2)
  codegens block call when argument type changes
  returns void when called with block
  executes yield expression if no arg is given for block
  codegens bug with block and arg and var
  allows using var as block arg with outer var
  allows initialize with yield (#224)
  uses block inside array literal (bug)
  codegens method invocation on a object of a captured block with a type that was never instantiated
  codegens method invocation on a object of a captured block with a type that was never instantiated (2)
  codegens bug with yield not_nil! that is never not nil
  uses block var with same name as local var
  doesn't crash on untyped array to_s
  codegens block which always breaks but never enters (#494)
  codegens block bug with conditional next and unconditional break (1)
  codegens block bug with conditional next and unconditional break (2)
  codegens block bug with conditional next and unconditional break (3)
  codegens block bug with conditional next and unconditional break (4)
  returns from proc literal
  does next from captured block
  codegens captured block with next inside yielded block (#2097)
  codegens captured block that returns union, but proc only returns a single type
  yields inside yield (#682)
  yields splat
  yields more exps than block arg, through splat
  uses splat in block argument
  uses splat in block argument, many args
  uses block splat argument with union types
  auto-unpacks tuple
  unpacks tuple but doesn't override local variables
  codegens block with multiple underscores (#3054)
  breaks in var assignment (#3364)
  nexts in var assignment (#3364)
  dispatches with captured and non-captured block (#3969)
Code gen: c enum
  codegens enum value
  codegens enum value 2
  codegens enum value 3
  codegens enum value 4
  codegens enum with 1 + 2
  codegens enum with 3 - 2
  codegens enum with 3 * 2
  codegens enum with 10 / 2
  codegens enum with 1 << 3
  codegens enum with 100 >> 3
  codegens enum with 10 & 3
  codegens enum with 10 | 3
  codegens enum with (1 + 2) * 3
  codegens enum with 10 % 3
  codegens enum that refers to another enum constant
  codegens enum that refers to another constant
Code gen: struct
  codegens struct property default value
  codegens struct property setter
  codegens struct property setter via pointer
  codegens struct property setter via pointer
  codegens set struct value with constant
  codegens union inside struct
  codegens struct get inside struct
  codegens struct set inside struct
  codegens pointer malloc of struct
  passes struct to method (1)
  passes struct to method (2)
  codegens struct access with -> and then .
  yields struct via ->
  codegens assign struct to union
  codegens passing pointerof(struct) to fun
  builds struct setter with fun type (1)
  builds struct setter with fun type (2)
  allows using named arguments for new
  does to_s
  can access instance var from the outside (#1092)
  automatically converts numeric type in struct field assignment
  automatically converts numeric union type in struct field assignment
  automatically converts nil to pointer
  automatically converts by invoking to_unsafe
  sets instance var to proc
Code gen: c union
  codegens union property default value
  codegens union property default value 2
  codegens union property setter 1
  codegens union property setter 2
  codegens union property setter 1 via pointer
  codegens union property setter 2 via pointer
  codegens struct inside union
  codegens assign c union to union
  builds union setter with fun type
  does to_s
  automatically converts numeric type in field assignment
  automatically converts numeric union type in field assignment
  automatically converts by invoking to_unsafe
  aligns to the member with biggest align requirements
  fills union type to the max size
  reads union instance var
Code gen: case
  codegens case with one condition
  codegens case with two conditions
  codegens case with else
  codegens case that always returns
  codegens case when cond is a call
  codegens case with class
  codegens value-less case
  codegens case when constant bug (#1028)
  does case when with metaclass
Code gen: cast
  allows casting object to pointer and back
  casts from int to int
  casts from union to single type
  casts from union to single type raises TypeCastError
  casts from union to another union
  casts from union to another union raises TypeCastError
  casts from virtual to single type
  casts from virtual to single type raises TypeCastError
  casts from pointer to pointer
  casts to module
  casts from nilable to nil
  casts from nilable to nil raises TypeCastError
  casts to base class making it virtual
  casts to bigger union
  allows casting nil to Void*
  allows casting nilable type to Void* (1)
  allows casting nilable type to Void* (2)
  allows casting nilable type to Void* (3)
  casts (bug)
  can cast from Void* to virtual type (#3014)
  upcasts from non-generic to generic
  upcasts type to virtual (#3304)
  upcasts type to virtual (2) (#3304)
  casts with block var that changes type (#3341)
  casts between union types, where union has a tuple type (#3377)
  codegens class method when type id is available but not a virtual type (#3490)
  casts from nilable type to virtual type (#3512)
Code gen: class
  codegens call to same instance
  codegens instance var
  codegens recursive type
  codegens method call of instance var
  codegens new which calls initialize
  codegens method from another method without obj and accesses instance vars
  codegens virtual call that calls another method
  codgens virtual method of generic class
  changes instance variable in method (ssa bug)
  calls method on Class class
  uses number type var
  calls class method without self
  calls class method without self (2)
  assigns type to reference union type
  does to_s for class
  allows fixing an instance variable's type
  codegens initialize with instance var
  reads other instance var
  reads a virtual type instance var
  runs with nilable instance var
  runs with nil instance var when inheriting
  codegens bug #168
  allows initializing var with constant
  codegens class method
  codegens virtual class method
  allows using self in class scope
  allows using self in class scope
  makes .class always be a virtual type even if no subclasses
  does to_s for virtual metaclass type (1)
  does to_s for virtual metaclass type (2)
  does to_s for virtual metaclass type (3)
  builds generic class bug
  resolves type declaration when accessing instance var (#348)
  gets class of virtual type
  notifies superclass recursively on inheritance (#576)
  works with array in variable initializer in non-generic type (#855)
  works with array in variable initializer in generic type (#855)
  doesn't crash on instance variable assigned a proc, and never instantiated (#923)
  does to_s on class
  invokes class method inside instance method (#1119)
  codegens method of class union including Int (#1476)
  can use a Main class (#1628)
  codegens singleton (#718)
  doesn't crash if not using undefined instance variable in superclass
  codegens virtual metaclass union bug (#2597)
  doesn't crash on #1216
  doesn't crash on #1216 with pointerof
  doesn't crash on #1216 (reduced)
  doesn't crash on abstract class never instantiated (#2840)
  can assign virtual metaclass to virtual metaclass (#3007)
  transfers initializer from module to generic class
  transfers initializer from generic module to non-generic class
  transfers initializer from generic module to generic class
  doesn't skip false initializers (#3272)
  doesn't skip zero initializers (#3272)
  codegens virtual generic class instance metaclass (#3819)
Codegen: class var
  codegens class var
  codegens class var as nil
  codegens class var inside instance method
  codegens class var as nil if assigned for the first time inside method
  codegens class var inside module
  accesses class var from proc literal
  reads class var before initializing it (hoisting)
  uses var in class var initializer
  reads simple class var before another complex one
  initializes class var of union with single type
  initializes class var with array literal
  codegens second class var initializer
  initializes dependent constant before class var
  declares and initializes
  doesn't use nilable type for initializer
  codegens class var with begin and vars
  codegens class var with type declaration begin and vars
  codegens class var with nilable reference type
  initializes class var the moment it reaches it
  gets pointerof class var
  gets pointerof class var complex constant
  doesn't inherit class var value in subclass
  doesn't inherit class var value in module
  reads class var from virtual type
  reads class var from virtual type metaclass
  writes class var from virtual type
  declares var as uninitialized and initializes it unsafely
  doesn't crash with pointerof from another module
  codegens generic class class var
Code gen: closure
  codegens simple closure at global scope
  codegens simple closure in function
  codegens simple closure in function with argument
  codegens simple closure in block
  codegens closured nested in block
  codegens closured nested in block with a call with a closure with same names
  codegens closure with block that declares same var
  codegens closure with def that has an if
  codegens multiple nested blocks
  codegens closure with nested context without new closured vars
  codegens closure with nested context without new closured vars
  codegens closure with nested context without new closured vars but with block arg
  unifies types of closured var
  codegens closure with block
  codegens closure with self and var
  codegens closure with implicit self and var
  codegens closure with instance var and var
  codegens closure with instance var
  codegens closure with instance var and block
  codegen closure in instance method without self closured
  codegens closure inside initialize inside block with self
  doesn't free closure memory (bug)
  codegens nested closure
  codegens super nested closure
  codegens nested closure with block (1)
  codegens nested closure with block (2)
  codegens nested closure with nested closured variable
  codegens super nested closure with nested closured variable
  codegens proc literal with struct
  codegens closure with struct
  codegens closure with self and arguments
  codegens nested closure that mentions var in both contexts
  transforms block to proc literal
  transforms block to proc literal with free var
  allows passing block as proc literal to new and to initialize
  allows giving less block args when transforming block to proc literal
  allows passing proc literal to def that captures block with &
  allows mixing yield and block.call
  closures struct self
  doesn't form a closure if invoking class method
  doesn't form a closure if invoking class method with self
  captures block and accesses local variable (#2050)
  codegens closured self in block (#3388)
Codegen: const
  define a constant
  support nested constant
  support constant inside a def
  finds nearest constant first
  allows constants with same name
  constants with expression
  finds global constant
  define a constant in lib
  invokes block in const
  declare constants in right order
  uses correct types lookup
  codegens variable assignment in const
  declaring var
  initialize const that might raise an exception
  allows implicit self in constant, called from another class (bug)
  codegens two consts with same variable name
  works with variable declared inside if
  codegens constant that refers to another constant that is a struct
  codegens constant that is declared later because of virtual dispatch
  doesn't crash if constant is used, but class is never instantiated (#1106)
  uses const before declaring it (hoisting)
  uses const before declaring it in another module
  initializes simple const
  initializes simple const via another const
  initializes ARGC_UNSAFE
  gets pointerof constant
  gets pointerof complex constant
  gets pointerof constant inside class
Code gen: debug
  codegens abstract struct (#3578)Assertion failed: (!Filename.empty() && "Unable to create file without name"), function createFilePathPair, file DIBuilder.cpp, line 130.
make: *** [spec] Abort trap: 6

Additional details:
alex:~/A/crystal:master> uname -a
Darwin Sapiens.48hs.co 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64
alex:~/A/crystal:master> crystal -v
Crystal 0.21.0 (2017-02-21)
alex:~/A/crystal:master> /usr/local/bin/llvm-config-3.6 --version
3.6.2

Both the Crystal compiler and LLVM are installed using homebrew.

I've opened a PR wit a fix for the problem: https://github.com/crystal-lang/crystal/pull/4074.

Please don't use LLVM 3.6 when compiling the compiler, use LLVM 3.9

@asterite I would like some clarity on the llvm versions we intend to support, and the llvm versions we support at the moment.

We need to support LLVM 3.9. Older versions have serious bugs, like the bug we found that generates incorrect code in release mode. That's a very good reason to drop support for older LLVM versions.

I was about to say that the bug wasn't in 3.8 and that 3.8 is the current stable, but since 4.0 should be released in the coming weeks, then 3.9 is about to become the current stable. Yet, maybe we could still support 3.8 for some time? It's likely to stay the default version on a number of Linux distributions for some more months.

But we distribute LLVM with the releases, and the compiler statically link it. I think we should upgrade to 3.9 and distribute that, and stop supporting older, buggy versions.

I think there are some issues with LLVMContextDispose which I wasn't able to reproduce in 3.9, but happen in older versions...

@asterite I'll try to build it with LLVM 3.9. Can you please update https://github.com/crystal-lang/crystal/blob/master/CONTRIBUTING.md? I was under the impression that 3.6 was required for builds. As for the issues with LLVMContextDispose, yes, they're happening with 3.6.

I think we should support LLVM releases until they become hard to maintain, or we find bugs in them. For that reason increasing the minimum to LLVM 3.8 seems like a good call but what's the benefit of requiting 3.9+?

I've recently started to build Crystal and its applications on Alpine Linux. I believe that Crystal is very very suitable for building Docker-based microservices.
However LLVM 3.8 is buggy to compile the Crystal compiler with --release and, unfortunately, the default LLVM version is still 3.8 on Alpine. So, currently, I'm compiling the compiler with --cross-compile on Mac with LLVM 3.9 first and then link the .o file and libraries on Alpine.
Actually, I don't need you to support LLVM 3.8. I would like you to provide more official prebuilt compilers for the modern Linux distributions like Ubuntu.
In my opinion, there's no problem for most of users even if you dropped the support for LLVM 3.8. Only the contributors have to avoid the buggy LLVM versions for compiling the compiler. I would not like you to do the waste of time for fixing such a bug now.

LLVM 3.8 is one of the working versions actually. If you get segfaults/bugs on 3.8 please report them.

Compiles and works fine with llvm 3.8 on macOS for me. Feel free to close this issue. Thanks for th help.

@mosop I have no problem compiling Crystal in release mode with LLVM 3.8 on Alpine Linux. What error do you have?

@ysbaddaden Accidental close?

No, the initial issue is solved: use LLVM 3.8 or later.

@ysbaddaden Really? So, it might be my misunderstanding. I forgot how I reached that conclusion, but everything went well once I stopped to use 3.8. Anyway thank you for letting me know that.


feat: Improve performance of rd_to_weekday

A "proof" that the new algorithm works on the full range of rata die values: https://godbolt.org/z/5G7ThMEr9
My measurements show 45% performance improvement.
To the best of my knowledge, this is an original algorithm. If so, this is the first library to feature it. :slightly_smiling_face:
Please, feel free to make changes, especially, in the documentation and make your own measurements.

My own testing:

func
change

rd_to_weekday
-46.6%

date_to_weekday
-22.7%

rd_to_isoweekdate
-13.6%

isoweekdate_to_rd
-15.2%

date_to_isoweekdate
-17.9%

isoweekdate_to_date
-8.0%

isoweeks_in_year
-23.7%

These are impressive numbers, and the knock-off effect to ISO week calculations is very nice!
I'll make some cleanups and reorgs in a subsequent pull, but this is gold as it is!


Adds base config for circleci

Thank's for providing this project.
I've added a basic configuration for CircleCI as well as a base test to ensure that CircleCI will build.

Prematurely opened, sorry

Cool! Thank you


Adding pinot file system command

Adding Pinot FS command into tooling.
Example usage:
pinot-admin.sh FileSystem -scheme s3 -command LIST_FILE_RECURSIVE -args s3://<my-bucket>/

Codecov Report

Merging #8659 (538a1d3) into master (328c0c2) will decrease coverage by 4.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8659      +/-   ##
============================================
- Coverage     70.34%   66.15%   -4.20%
+ Complexity     4406     4321      -85
============================================
  Files          1690     1270     -420
  Lines         88185    64117   -24068
  Branches      13190     9947    -3243
============================================
- Hits          62038    42414   -19624
+ Misses        21858    18702    -3156
+ Partials       4289     3001    -1288

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
66.15% <ø> (-0.01%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328c0c2...538a1d3. Read the comment docs.


Fix for issue when single quotes are contained in the playlist name

Add function to either use quotes or double quotes to wrap the string or use xpath concat function
This should be able to support a mixture of quotes and double quotes in one string using the concat function.
I added it for the playlist field. Could be useful for other xpath selectors?

This change is

Thanks for the PR


double readScratchPad() in DallasTemperature::begin()

in version 3.7.1 in DallasTemperature::begin()
There are the following lines (DallasTemperature.cpp:56-60):
//scratchPad is never actually used
ScratchPad scratchPad;
readScratchPad(deviceAddress, scratchPad);
//here getResolution() reads scratchPad again internally....
bitResolution = max(bitResolution, getResolution(deviceAddress));
recommendation:
remove the following unused, double called code from method
ScratchPad scratchPad;
readScratchPad(deviceAddress, scratchPad);

Had a quick look and seems to be a correct observation

Agreed. Corrected


Doc issue: confusing use of - in {%-

Looking at [https://jinja.palletsprojects.com/en/2.11.x/templates/] Why is there a dash used after the {% in the recursive section ?

{% for user in users %}

{{ user.username|e }}

{% else %}

no users found

{% endfor %}

Note that, in Python, else blocks are executed whenever the corresponding loop did not break. Since Jinja loops cannot break anyway, a slightly different behavior of the else keyword was chosen.

It is also possible to use loops recursively. This is useful if you are dealing with recursive data such as sitemaps or RDFa. To use loops recursively, you basically have to add the recursive modifier to the loop definition and call the loop variable with the new iterable where you want to recurse.

The following example implements a sitemap with recursive loops:

{%- for item in sitemap recursive %}

{{ item.title }}
    {%- if item.children -%}

{{ loop(item.children) }}

    {%- endif %}

{%- endfor %}

I have seen {{- also. What is the undocumented dash for?

See the docs on whitespace control.


Commands for generate

I think is important makes life easier, a generate component tool can be a awesome feature.
For example:
$ react-static-boilerplate component MyComponent
.
├── /components/                # Shared or generic UI components
│   └── /MyComponent   #New Component
│       └── /Files              # etc.

$ react-static-boilerplate page MyPage

@credondocr yep, that will be a great feature to have, e.g. node run new:component MyComponent creates /coponents/MyComponent; node run new:route /tasks/:id TaskDetails creates /pages/tasks/TaskDetails.js or something like that.

@koistya another way to implement that can be:

yo react-static component MyComponent
yo react-static route MyRoute
I really like Yeoman

Yep, I need to update generator-react-static with the latest version of RSB from master and these scaffolding tools.

@credondocr just scaffolded the bare minimum Yeoman generator here:
https://github.com/kriasoft/react-static-boilerplate/tree/generator-react-static
Next step is to add sub-generators for components and pages.


Generalize shift below merge to multi left shift

I'm just going to leave this right here…
select a[*][*][*] + b - c[*] / d[*][*] from foo

QScript: https://gist.github.com/7024e91afdcaeee9b016ef427d5d5117
Cmd-F theta
No Results Found
:tada:
Ping @jdegoes @alissapajer

Ok this is an extremely bizarre commit list.  Also I was excited and filed my PR and didn't wait for @edmundnoble's conflict resolution.  So uh… don't merge yet.

I think this is failing because of the ShiftArray issue.

select a[][][] + b - c[] / d[][] from foo

Sweeeet! 🎉

@wemrysi If you can do a final review and merge on this tonight, that would be greatly appreciated.  I'd like to get it into master asap so we can get the build cycles through and have time tomorrow morning to run the downstream builds, which also take a fair amount of time.

The other comments are basically re @edmundnoble. Flagging for later attention


mekanism crash in creative menu

Please use the search functionality before reporting an issue. Also take a look at the closed issues!
Issue description:
Minecraft Client crashes when you scroll to the Mekanism section of the mod items.
Steps to reproduce:

Load Mekanism
Scroll to Mekanism section of items in the creative menu
Crash...

Version (make sure you are on the latest version before reporting):
Forge: 1.12.2-<IP_ADDRESS>07
Mekanism: 1.12.2-<IP_ADDRESS>5
Other relevant version: Tinkers Construct (TConstruct): 1.12.2-<IP_ADDRESS>
Full mod list: https://www.dropbox.com/sh/lllqnrha4dqibzz/AADWg9QoGvLDnIpEyUeLHhwGa?dl=1
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
https://hastebin.com/aqojanulux.coffeescript

Problem solved. It's due to an incompatibility with ProjectRed-1.12.2-4.90.86-mechanical. Good to keep in mind for future modpacks.
You guys should create an incompatible document with all of the known incompatible mods. (Just a suggestion).
Issue closed.


PR jenkins for contributors without collab access

Add https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin to jenkins to allow admins to run the full test suite on pull requests.

Jenkins is gone, we run CircleCI and Travis for pull requests


Update existing comment in place

Hey, I love this thing! It's just what I needed.
It would be nice if the action updated the comment in place as actions are re-run for a given PR (maybe as a configurable option). Historical comments are a little interesting but mostly just noisy.

hey @cdata, you can do something like below. This will hide previous comments and give you a clean view. Updating existing comment is not the best idea as your commit and comment may get out of sync.
PS: ive been running a fork of this action with some added features.
      - uses: int128/hide-comment-action@v1
        with:
          contains: |
            Terraform Plan Summary: <b>${{ env.STACK }}</b>

      - uses: liatrio/terraform-change-pr-commenter@main
        with:
          json-file: tfplan.json
          expand-comment: "true"
          include-plan-job-summary: "true"

@cdata We have added a feature to v1.6.0 that will hide all previous comments made by this action to reduce the noise.
      - uses<EMAIL_ADDRESS>        with:
          json-file: envs/dev/plan.json
          hide-previous-comments: "true"

Which will result in a history like this

In testing I did notice that I had to refresh the tab for the minimize to take effect FYI.


ember-cli-rails does not work with ember 1.9

I made an ember-cli-rails app, and it automatically installed ember 1.8.1.  It is a very simple app, and you can see the repository here.  It runs quite well.
However, when I tried to upgrade to ember 1.9, it stopped working.  These are the changes I made.
The following error ActionController::RoutingError (No route matches [GET] "/javascripts/frontend/vendor.js"): started to alternate with this big block of text:
============================= WARNING! =============================

  Seems like Ember frontend application takes more than 5
  seconds to compile.

  To prevent race conditions consider adjusting build timeout
  configuration in your ember initializer:

    EmberCLI.configure do |config|
      config.build_timeout = 10 # in seconds
    end

  Alternatively, you can set build timeout per application like this:

    EmberCLI.configure do |config|
      config.app :frontend, build_timeout: 10
    end

============================= WARNING! =============================

My page never loaded.
Is there a known solution for this?  If not, I'm willing to start looking.  Any pointers on where to dig would be appreciated.

What happens when you manually cd into EmberCLI app directory and run ember build?

ember build has worked continually, but I've gotten some interesting further results
In the small linked app, I was able to get it working.  How?  By unpacking the gemfile and linking directly to it.  But when I linked back to the rubygems gem, it... still worked.  The gem equivalent of kicking the machine.
On the larger app where the problem first arose, it's more complicated but less mysterious.  In app.rb in ember-cli-rails, I set ember_path to just return 'ember', and then my builds started working.  This works, but has the significant disadvantage of requiring that ember-cli be installed either globally or in the directory from which the command is run.
I'm not sure the exact relation to upgrading to 1.9; in the larger app, it was already at 1.9, and it didn't work right out of the box.  In the smaller app, I noticed that it started at 1.8.1 and when I upgraded to 1.9, that's when it stopped working (before mysteriously starting working again).

Weird. I assume it's NPM acting weird and having version mismatch all around. Next time you experience something like this, try running the following in an app dir: rm -rf node_modules bower_components && npm cache clean && npm install && bower install

Resetting all the npm and bower stuff, sadly, did not help.
On my hacked-up version, on the first try, I see BuildingBuilding.Building..Building..., then the usual output of running ember s or ember build.  However', in the console it gives me GET http://org.lvh.me:3000/javascripts/enterprise/vendor.js  org.lvh.me/:62 GET http://org.lvh.me:3000/javascripts/enterprise/enterprise.js 404 (Not Found).  When I refresh the page, it works.
On the standard version, it shows no evidence of building, and just outputs sh: clients/enterprise/node_modules/.bin/ember: No such file or directory before the long line of errors.
More clues: running node_modules/.bin/ember build from within the clients/enterprise folder works, but running clients/enterprise/node_modules/.bin/ember build from the rails app returns an error, saying that I must be within an ember-cli folder.
This led me to replace ember_path with
    def ember_path
      @ember_path ||= Pathname.new("node_modules/.bin/ember")
    private

It was previously trying to use app_path.join("node_modules", ".bin", "ember"), but exec had already cd'ed to the app_path, so it was doubling up on the app_path.  This was not a problem on the smaller app because the app_path was '../client', which you can run as many times as you want without it changing the effect.
(I also removed the path.executable? check because for some reason, the new path is not recognized as an executable.  However, it does execute, and works (every time except the first, because of the same error as above).

tl;dr: it was doubling up on app_path, but you wouldn't notice it if you had an app_path that followed the pattern of "../ember_folder".

PR associate with this issue: https://github.com/rwz/ember-cli-rails/pull/76

Ok, I think I see the problem. Sadly, that means that I'd need to reject your PR, though.
The problem is that when you override that path, the gem assumes you're using the full absolute path. When you use relative path instead, the stuff you described happens.
So, as a quick solution, instead of doing path: "../client", do path: Rails.root.join("..", "client").
We'll make the gem account for that in the next version!

thanks, that sounds like a good solution!

Hello, I'm having the same issue I think: using ember 1.10, and with an ember folder in AssessUp/frontend (while my rails app is in AssessUp/app), I get a "not found" error looking for a file in "javascripts/frontend/vendor" when I firststart the server. After I reload the page several times the error disappears (and ember build in the command line on folder AssessUp/frontend works).
This is my ember initializer:
EmberCLI.configure do |c|
c.app :frontend, path: Rails.root.join('frontend').to_s#, exclude_ember_deps: ["jquery","handlebars"]
en
and I'm using the last ember-cli-rails version, which includes changes in https://github.com/rwz/ember-cli-rails/commit/d10c8c08a176830387959576c5a9bef0922fe0c2.
Any idea how to solve this? Thanks

@Leooo - while there's still no solution, there's a conversation going on in an open issue here: https://github.com/rwz/ember-cli-rails/issues/120


Update readme.md and further links in rm project material

What type of PR is this?
Add one of the following kinds:

cleanup
documentation

What this PR does / why we need it:

Corrects links in README.md and in other RM documentation files.
Moves CHANGELOG_TEMPLATE.md to SupportingDocuments folder

Which issue(s) this PR fixes:
Fixes #40
Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

Thanks Herbert ! local links are much better indeed.
Let's close and merge this on the RM call tomorrow.


Support for other platforms? (Hulu, Netflix, etc.)

Would it be possible to add support for other video streaming sites? I've been using Ambient Light to help even wear on my ultrawide OLED while watching YouTube content, and I'd love to be able to do the same with Netflix and Hulu.

Duplicate of #112


If the embedded post is a reply, it cannot be displayed.

Describe the bug
When embedding a post in an article using nostr:~, if it is a reply, the display shows 'The note does not seem to be found'.
To Reproduce
Steps to reproduce the behavior:

Create an article
Embed a reply post to someone using nostr:~ in the article
Preview the article or publish it to check
"The note does not seem to be found" is displayed

Expected behavior
Display the post even if it is a reply
Video and Screenshots
The post above is a regular post, and the one below is a reply post

https://yakihonne.com/notes/nevent1qgswcsk8v4qck0deepdtluag3a9rh0jh2d0wh0w9g53qg8a9x2xqvqqqyzu0q8lu9fqetpy9tgh25zyh7v0ey0jc79h5jrw6c6508q4zhyysc6dtl2v
Device (please complete the following information):

Windows 11
Google Chrome 129.0.6668.101

Checked, sorry for the late reply 🙏


x/review/git-codereview: make 'git codereview mail' run 'git push' using --no-follow-tags

I have the push.followTags = true option set in my global gitconfig because it's convenient for my typical git workflows on non-Go projects. But it breaks git codereview mail:
$ git mail
remote: Processing changes: refs: 9, done
To https://go.googlesource.com/tools
 ! [remote rejected]   HEAD -> refs/for/master (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.0 -> gopls/v0.1.0 (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.1 -> gopls/v0.1.1 (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.2 -> gopls/v0.1.2 (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.3 -> gopls/v0.1.3 (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.4 -> gopls/v0.1.4 (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.5 -> gopls/v0.1.5 (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.6 -> gopls/v0.1.6 (cannot combine normal pushes and magic pushes)
 ! [remote rejected]   gopls/v0.1.7 -> gopls/v0.1.7 (cannot combine normal pushes and magic pushes)
error: failed to push some refs to 'https://go.googlesource.com/tools'
(running: git push -q origin HEAD:refs/for/master)

Of course, I can set push.followTags = false for all my Go repos on all the machines I use, but it's hard to remember to do that. git-codereview could warn if the option isn't set. But better yet, it could just supply the flag --no-follow-tags to the git push command.
(I didn't check how long the --no-follow-tags flag has existed and whether we need to care about git versions older than that.)

CC @rsc, @kevinburke.


Feature/issue 841 on rows expand

Adds onRowsExpand callback that works similarly to onRowsSelect.

Coverage increased (+1.3%) to 76.519% when pulling 57f6814ae8a078edc5670618852d5e69a7b4ef31 on feature/issue-841-on-rows-expand into d1914e4156aea4ff7d6d8ad9794da3ca4b156758 on master.


Encrypt Concourse S3 resources

In order to have a fully encrypted at rest system to satisfy auditor requirements:

[x] Concourse 's3' resource types have encryption enabled for all pipelines

Done.


Fix wrong paradigm key check

I believe that the way the keys are checked is wrong... (this is my first github-pull-request - so sorry if I did it wrong  - you may want a different way to fix this ... but I thought I'd make a note since I ran into it...)

Indeed!
But the logic should be the opposite: remain silent if this is all right, and  raise an Error when the conventions are broken and a warning if the events descriptor is not well-structures. So, I just took a look at BIDS specification and it turns out that onset and duration are required. Hence

raise an error of onset id not provided
raise an error if duration is not provided
raise a warning if trial_type is not povided (I think it should)
print a comment if modulation is found as this is currently used to
and that's all.
Can you do that ?

i tried to - need get more savvy with github and nistats (didn't understand all re: modulation).

Do you need help on that one ?
FYI we're going to release early next week, and we absolutely need this improvement in. If you don't have time to work on it, I can contribute the missing parts.

@bthirion I will try to understand and do it tonight and tomorrow, but I can't guarantee since I am still a newbie. If you want to be sure, you can do it. Otherwise, I'll sent sth by tomorrow night.

the checks are still failing - it seems because the fetched example design matrices also don't contain the bids-duration - e.g. fetch_localizer_first_level. I may fix those as well - but only if I am on the right track and not creating a mess.

All right, it is fixed now !
Reviews welcome. If no issue is raised we'll merge it during the week end.

OK, merging since this is fixed.


[WIP] Explain text predictions of Keras classifiers

https://github.com/TeamHG-Memex/eli5/pull/325/ by @teabolt
TODO:

[x] make sure build is passing
[ ] double-check if anything needs to be updated / adjusted

Hey @lopuhin
I checked out the docs that were built by tox and didn't find any issues. Added one small comment above but it might not even be an issue.
I also re-ran the keras notebooks using the py35-extra and py36-extra environments and didn't run into any issues. So I think the PR is ready

Hey @lopuhin
I checked out the docs that were built by tox and didn't find any issues. Added one small comment above but it might not even be an issue.
I also re-ran the keras notebooks using the py35-extra and py36-extra environments and didn't run into any issues. So I think the PR is ready

Hey @lopuhin. Let me know if there's anything blocking this PR that I could fix. Maybe we are sticking with https://github.com/TeamHG-Memex/eli5 for now?

hi @teabolt I also think it's ready, just need to double-check everything and merge. We're sticking to this repo for now.


Adds the plan command

shows what packages would be affected by an invocation of turbo run with equivalent arguments
can use --json flag to produce output as a pretty-printed json array

Do you think we should make this a flag on run? If we think about what we would need to use --plan to clean up e2e tests, I think we would need payload of package in scope, task ids + hashes. What do you think?

I think it would make sense to add it to the run-command as it is related to it? I would assume otherwise you would have something?
turbo plan build --scope=blah --ignore=blah --since=orgin/main --json=generated-plan.json
turbo run build --scope=blah --ignore=blah --since=orgin/main

or is the idea to offer something like:
turbo run --planning-file=./generated-plan.json

@weyert serialized graph is a different matter which we are going to support. The goal here is to increase observability and unblock folks using Ignore Command on Vercel/Netlify and also ppl using dynamic pipelines in CircleCI and GitLab CI

@jaredpalmer  re: cleaning up e2e tests, I think we need to be able to check "packages in scope", "tasks to be run", and "what was run from cache".
As currently implemented, plan gives us "packages in scope". Maybe plan is not the best term for that functionality, since it suggests "things that will be run", which is more like "tasks to be run". Perhaps the command here is better described as affected? It answers the question of "given these flags (--since, --scope, etc.), what packages are in scope?". Then a true plan would be "tasks to be run", a superset of "packages in scope". We don't technically need both, could even have a --packages-only flag to the "tasks to be run" command. What do you think, should we implement that instead?
I'm not sure I have a strong opinion on a separate command vs flag to run. Internally we can make the code sharing work out either way. My inclination is towards separate command because not all of the flags for run apply and that could lead to some documentation or parsing awkwardness, but that's not necessarily a strong argument. If there's a better DX reason either way, that should probably take precedence.

As a user I think I'd prefer turbo run --dry or an variation of that. --dry/--dry-run is quite common in other tools so might be easier to understand compared to --plan

Agree with @alexandernanberg —dry makes sense. Obvs let’s keep the abstraction needed to get the graph and scope outside of run command. These will be useful for the query commands we chatted about in our sync yesterday.

Closing in favor of #862


Feature copy G prompt to L

Hello,
I did add a feature on my fork of sdxl_prompt_styler adding a new option to the advanced node. It is used to copy the content of G text to L, deduplicating existing tokens found on both prompts.
This is used mostly by convenience because some models behave better with the same text in G and L. It kinda acts as a "overpowered text control" option.
Do you want a PR of this feature ?

Sometimes I have some styling words in the L prompt only : some words like "professional" that can really mess the picture if put in the G prompt because instantly your picture becomes one of a man in business suit. 😅
So having the option to copy the G prompt content to L without having to worry about duplicates feels nice. I'll do a branch and a PR.

Merged now. Thanks! I've found it fun to sometimes only style the positive or the negative prompt. That's why I've added that to the normal styler.


Added failures per second as a series in the chart

As a user of locust it's very useful to know how many requests are failing in the chart. The failure % is useful but when pushing heavy loads against an API in my case it's common the autoscaling can't cope up with the demand and a lot of fails start to happen. Having those represented in the chart is very valuable to understand how the scaling overall is working.

Too sad this PR is not merged since 2 years :'(

Too sad this PR is not merged since 2 years :'(

My default installation of locust still points to this branch. I find it much more useful that way....

@heyman I think this is a very useful contribution (although I dont use the web ui myself). Ok to merge, if someone fixes the conflicts?

Would be nice if we could make the line red.

@cyberw PR is too old. I'll drop this one and create a new PR fresh from master in a couple days.

@alercunha Awesome!

I'm +1. I wonder if it's best to have the failure line in the same graph, or if it's better to have a separate graph for failures (as suggested in #952)? I also think that the color of the line should be red.

@alercunha Is your new PR on the way? :)

@cyberw sorry I've been quite busy in the past few days. I'll try to get this done during the weekend.

@cyberw @heyman I posted a new PR. @heyman based on my experience having the failure line in the same graph makes more sense. Being able to see the correlation between the two lines in the same chart helped me figuring out the root cause of degradation of my service some years ago.


⚠ Cioos National CKAN Sitemap has degraded performance

In a4e8919, Cioos National CKAN Sitemap (https://catalogue.cioos.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 10744 ms

Resolved: Cioos National CKAN Sitemap performance has improved in f59e5cf after 4 minutes.


Refactoring Get() function to improve concurrency and performance

Refactor: Utilized goroutines and channels to minimize mutex contention and reduce lock holding time, significantly enhancing performance in scenarios with high load.
Timeout handling: Introduced timeout management using select, allowing for more efficient waiting when no connections are available.
Unit test: Added a unit test covering normal connection retrieval, handling of timeouts, and concurrent requests to ensure that the pool scales and reuses connections correctly under load.

Thank you!


fix(icons): fixed send-horizontal icon name typo

What is the purpose of this pull request?

[ ] New Icon
[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other:

Description

Icon use case

Alternative icon designs

Icon Design Checklist
Concept

[ ] I have provided valid use cases for each icon.
[ ] I have not added any a brand or logo icon.
[ ] I have not used any hate symbols.
[ ] I have not included any religious or political imagery.

Author, credits & license

[ ] The icons are solely my own creation.
[ ] The icons were originally created in # by @
[ ] I've based them on the following Lucide icons:
[ ] I've based them on the following design:

Naming

[x] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[x] I've read and followed the icon design guidelines
[ ] I've made sure that the icons look sharp on low DPI displays.
[ ] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[ ] I've made sure that the icons are visually centered.
[ ] I've correctly optimized all icons to three points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

See https://github.com/lucide-icons/lucide/pull/2297#issuecomment-2213061548