Dialog takes over focus on Stripe checkout input elements.

I'm trying to use the stripe checkout (react-stripe-checkout package) on top of a Dialog. Before I upgraded to the new version of material-ui (previous was 0.19.4) it worked fine. I upgraded to 4.9.2. Now when the dialog is open and Stripe checkout is on top, if you click any of the inputs, they will focus for a split second, and then lose focus. I've tried to look at events happening on the page and it looks like some events are added to the inputs when on top of the dialog. When not over the dialog, the checkout works as expected. This happens on the latest versions of Chrome, Firefox, and Safari. Any help or input is very much appreciated.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When the Stripe Checkout modal is on top of a dialog, the Stripe inputs gain focus on click, and then immediately lose focus.
Expected Behavior 🤔
On 0.19.4 everything works as expected. I have a Stripe Checkout modal above the material ui dialog and I can interact with the form.
Steps to Reproduce 🕹
Steps:

Install react-stripe-checkout.
Install the latest @material-ui/core
Open a dialog and then stripe checkout on top of it.
Click on a form input to see it gain and then lose focus.

Context 🔦

Tech
Version

Material-UI
v4.9.2

React
v16.12

Browser
Latest Chrome, Firefox, Safari

react-stripe-checkout
v2.6.3

I was able to get this to work but only with a specific setup using the Modal component instead of the Dialog component
    <Modal       open={open}       onClose={onClose}       className={classes.modal}       closeAfterTransition       BackdropComponent={Backdrop}       BackdropProps={{ timeout: 500 }}       {...rest}     >       <Fade in={open}>         <>
{children}
         </>       </Fade>     </Modal>
Without the "<> </>" wrapping the div/children inside the Modal, it had the same problem as the Dialog. I'm not sure what that is doing but it works.

Thanks  for opening this issue and providing some context.
Could you include a reproduction (perferably a codesandbox).
The Dialog is trapping focus inside itself. If there's another modal window and the dialog isn't aware that it is inert it will steal focus. But we need an actual example to debug this issue.

I can't reproduce it either: https://codesandbox.io/s/stripe-vuzyv.
However, I think that it would be interesting to push https://github.com/mui-org/material-ui/issues/17497#issuecomment-579200539 further, it feels like that the interval we have introduced doesn't match the scale of the problem we wanted to solve with it in the first place: an element that has focus and that is unmounted.

Stealing the focus from iframes can be very frustrating. For instance, It seems to be a common use case to have a chatbot on a webpage. Or try working in codesandbox with the Dialog open, impossible 😆.
The 50ms interval doesn't leave any room for developers to understand that there is a trap focus. It's moving too quickly. I would be curious to try 500ms out (still enough for the users?). It would also reduce the "noise" for developers the interval introduces:

Closing this since it's been incomplete for over 7 days. While there are come inconveniences with trapping focus they're not on the level of a bug as far as we know.


Add 1910 2912 options

Only two call strikes for 2912 due to how far away in the future it is.

class hash 0x00773afdcdbb53033f2eefce2bb97ea449e9a9306a29e82a71404c5040a423b4


Fix broken links

Thanks @yulyugin for the PR.  I removed the en-us from the links because we want the user's browser to take them to the correct language/locale


Join club

Users can apply to join clubs from the club list

Three things we need to consider immediately with this request:

This includes Rav's club and club membership models, untested. We probably should wait for that to be finished before merging.
When are we going to set the club value in the session id? If we redirect to a club view, then we should set it immediately(I can add this code to any features that we need, or provide a helper to do it for you guys in the future)
This code isn't class based, so will need to be refactored before we can accept.


Skip instead of Fatal since Service is implemented only for kne binding

Pull Request Functional Test Report for #2473 / f1308e7fc318fc868def2780201c60cfbf2d3dc1
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

System-1: System testing
2f10fcd7
Log

Cisco 8000E

System-1: System testing
b299268a
Log

Cisco XRd

System-1: System testing
edbd4a31
Log

Juniper cPTX

System-1: System testing
00d0d16f
Log

Juniper ncPTX

System-1: System testing
f436eb1e
Log

Nokia SR Linux

System-1: System testing
997ada76
Log

Openconfig Lemming

System-1: System testing
ff4a527f
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

System-1: System testing

Cisco 8808

System-1: System testing

Juniper PTX10008

System-1: System testing

Nokia 7250 IXR-10e

System-1: System testing

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.168%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1643

Relevant Lines:
3275

💛  - Coveralls


Support --allowUnlimitedContractSize parameter

fixes: https://github.com/runtimeverification/firefly/issues/927
Sister PR: https://github.com/runtimeverification/blockchain-k-plugin/pull/111

@gtrepta please update the submodule to the newest master then put automerge on this one.


Document how to migrate a cluster from vintage to CAPA (internally)

Tool used for current PoC for the migration https://github.com/giantswarm/capi-migration-cli
docs:
https://github.com/giantswarm/capi-migration-cli#steps

Documented steps are in the tool readme, this is current state:
Requirements

there has to be pre-created AWS IAM role of the WC AWSAccount called giantswarm-{CAPI_MC_NAME}-capa-controller

This tools executed folowing steps
Steps:

Init Phase

get Vintage MC kubeconfig via opsctl login
get WC cluster kubeconfig via opsctl login
get CAPI MC kubeconfig via opsctl login
generate AWS credential neceseery to work with the WC cluster AWS account - via opsctl credentials aws
create a vault client to Vintage Vault via opsctl create vaultconfig

Prepare Migration Phase

fetch all vintage CRs  representing infrastructure of WC cluster in VIntage MC
migrate secrets to CAPI mc

migrate CA certs - fetching CA private key from vault via hacked vault - https://github.com/giantswarm/vault-hack/tree/v1.7.10-hack, create CA secret on MC
copy encryption provider secret for encrypting ETCD to CAPI MC
copy service account v2 secret to CAPI MC

create migration scripts as secret in the CAPI MC, these are later injected on machines via file reference in cluster-aws
migrate aws credentials for the cluster by create a AWSClusterRoleIdentity in the CAPI MC
disable machine health check on the Vintage CRs to avoid aws-operator to terminate nodes during migration
scale down app operator for the migrated WC on the vintage MC to avoid issues of overwriting apps

[optional] Stop Vintage CR reconciliation

[optional part - needs to be set via flag]
stop vintage Reconcilion on CRs remove all aws-operator labels on the vintage CRs to avoid reconciliation
it is optional becasue for testing purposes we still wanna delete the cluster afterwards and removing the cluster labels will make it hard

Provision CAPI Cluster Phase

generate CAPI cluster templates - generates APP CRs and the configmaps
applies the generated templates to the cluster to start the migration
wait until 1 CAPI control-plane node join the cluster and is in Ready state and add it to all vintage API ELBs - to ensure the old kubeconfigs are still working
clean migration configuration for etcd - remove hardcoded initial etcd cluster value - from configmap in WC and from cluster values cm and reapply to save the state
stop control-plane components on the vintage cluster - stop kube-apiserver, kube-controller-manager, kube-scheduler via job that removes the manifests from the static dir
cordon all vintage Control-planes to avoid scheduling new pods there
delete chart-operator pod in the WC to reschedule it on the new CAPI control-plane node
wait until all CAPI control plane nodes join the cluster and are in Ready state
add all CAPI control plane nodes to the vintage ELBs

Clean Vintage Cluster Phase

drain all vintage control-plane nodes
delete vintage ASG groups for control-plane nodes (tccpn) and terminate all instances in that ASG groups
drain all vintage worker nodes
delete all vintage ASGs

@T-Kukawka is there anything left here?

this is ongoing basically based on any new developments

i will close this - we are documenting things as we go - the basics and the must-have features are already there


[Chat][Feature] Detect and Handle Local Participant removed

Purpose

Detect Local Participant removed
Handle Chat eviction event

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull Request Checklist

[ ] Public API changes
[ ] Verified for cross-platform
[ ] Synced with iOS, Web team
[ ] Internal review completed
[ ] UI Changes

[ ] Screen captures included
[ ] Tested for Light/Dark mode
[ ] Tested for screen rotation
[ ] Tested on Tablet and small screen device (5")
[ ] Include localization changes

[ ] Tests

[ ] Memory leak analysis performed
[ ] Tested on API 21, 26 and latest
[ ] Tested for background mode
[ ] Unit Tests Included
[ ] UI Automated Tests Included

How to Test

Open...
Click on...

ok, so I had a discussion with @JoshuaLai  on this story. we are basically breaking it down into 2 parts:

as a Contoso user, I wanted to see notification that i am no longer in chat -> public preview
[new] as a Contoso developer, I want to be notified when remote + local participant being removed from the chat -> GA

let me know if you need more details on this.
PR on iOS side: https://github.com/Azure/communication-ui-library-ios/pull/450/files


Update to dwm 6.3

Thank you for your participation! Without your pull request I don't even notice dwm 6.3 was released.
Unfortunately upgrading to 6.3 on a git tree is far more complicated than a single merge, and I have done it just now :D


Remove the IAM Policy Controller

Ensure that the governance-policy-addon-controller removes the existing ManifestWork deploying the IAM policy controller. This should lead to the IAM policy controller being removed.

Delete all iam-policy-controller deploying procedure

Ref: https://issues.redhat.com/browse/ACM-10859

Should I add an e2e- test about cleaning clusteramangementAddon?

Yes, I think so.

/hold while we discuss this with the Hub installer team on if multicluster-hub should handle deleting the CMA.

/hold while we discuss this with the Hub installer team on if multicluster-hub should handle deleting the CMA.

@yiraeChristineKim Would you move the delete changes over to a separate PR? The other changes could get merged as-is in my opinion.

/unhold


IconImage: new IconSize Property

Hi!
First of all let me say great project!
I've played with your components a little and I thought that the IconImage was missing a way to let the user set the Icon size.
I use this little customization to have an Image with a placeholder icon, and then replace it with a real image when the user wants to (example: "add photo", I use as placeholder the fa-camera, a tapgesture recognizer for the action and then use the IconImage object to display the shot).
Let me know if this PR meets your standards.
Cheers,
Riccardo.
PS I tried to fix the code formatting, but I lost the battle with Xamarin Studio 6.

Hey, thanks for the PR and the kind words. I have added the IconSize property to IconImage but won't be accepting your PR due to formatting changes. For future PRs, please try to keep the formatting the same. I've also added you to the list of contributors.


refactor Makefile to easily support generation of multiple docs

At least one spec, has multiple output docs.   Rather than adding them individually to the existing Makefile structure, it could be refactored to easily support this.
PR to follow will do following:

add variable at top to allow for multiple src docs
parallelize builds (both pdf/html and mulitiple docs)
remove duplication

done with #36


Instructions lead to an error:  module 'mlflow' has no attribute 'xgboost'

Hi
Following the examples on this page gives you this error when the job runs:
if flavor_name == mlflow.xgboost.FLAVOR_NAME:

AttributeError: module 'mlflow' has no attribute 'xgboost'
I assume because of:  https://mlflow.org/docs/latest/python_api/mlflow.xgboost.html states:
"Autologging is known to be compatible with the following package versions: 1.4.2 <= xgboost <= 2.0.1. Autologging may not succeed when used with package versions outside of this range"
and the conda file references:

mlflow== 2.4.1

be great if you could confirm this is the problem and if so fix the documentation.
Thanks in advance.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ccf83708-46f5-aa23-3f59-c90ca4c4b8ca
Version Independent ID: 7c65eb09-fe59-039b-bf64-ab516f983b3a
Content: Tutorial: Train a model - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-train-model.md
Service: machine-learning
Sub-service: core
GitHub Login: @ssalgadodev
Microsoft Alias: ssalgado

@sikfink
Thanks for your feedback! We will investigate and update as appropriate.

@sikfink
Thank you for bringing this to our attention.
I've delegated this to content author @ssalgadodev, who will review it and offer their insightful opinions.

@sikfink Thanks so much for your feedback! I am trying to find the listed line of code so I can recreate the error. Would you mind double checking if the listed article the correct article you were referring to? I am unable to find the line of code in question in the current article. Thanks so much again!

I have the same issue here is the link to MSFT Learn exercise https://learn.microsoft.com/en-us/azure/machine-learning/tutorial-train-model?view=azureml-api-2  I have to train a MSFT customer on this next week, and I am at a loss on how to fix it.

And here is my notebook if you are an MSFT employee you can access it https://microsoft-my.sharepoint.com/:u:/p/johannorvik/EdlMXIRemc9HnvikhW6FuDABsSz56AQAAESMAWQl1lXpiA?e=iqo5Zq

This is the job command
from azure.ai.ml import command
from azure.ai.ml import Input
registered_model_name = "credit_defaults_model"
job = command(
inputs=dict(
data=Input(
type="uri_file",
path="https://azuremlexamples.blob.core.windows.net/datasets/credit_card/default_of_credit_card_clients.csv",
),
test_train_ratio=0.2,
learning_rate=0.25,
registered_model_name=registered_model_name,
),
code="./src/",  # location of source code
command="python main.py --data ${{inputs.data}} --test_train_ratio ${{inputs.test_train_ratio}} --learning_rate ${{inputs.learning_rate}} --registered_model_name ${{inputs.registered_model_name}}",
environment="aml-scikit-learn@latest",
#environment="azureml:AzureML-sklearn-1.0-ubuntu20.04-py38-cpu:latest",
compute="cpu-cluster", #delete this line to use serverless compute
display_name="credit_default_prediction",

this is the cell to create the environment
from azure.ai.ml.entities import Environment
custom_env_name = "aml-scikit-learn"
custom_job_env = Environment(
name=custom_env_name,
description="Custom environment for Credit Card Defaults job",
tags={"scikit-learn": "0.24.2"},
conda_file=os.path.join(dependencies_dir, "conda.yaml"),
image="mcr.microsoft.com/azureml/openmpi3.1.2-ubuntu18.04:latest",
)
custom_job_env = ml_client.environments.create_or_update(custom_job_env)
print(
f"Environment with name {custom_job_env.name} is registered to workspace, the environment version is {custom_job_env.version}"
)

and this is the yaml from the intructions
name: model-env
channels:

conda-forge
dependencies:
python=3.8
numpy=1.21.2
pip=21.2.4
scikit-learn=0.24.2
scipy=1.7.1
pandas>=1.1,<1.2
pip:

inference-schema[numpy-support]==1.3.0
mlflow== 2.4.1
azureml-mlflow==1.51.0
psutil>=5.8,<5.9
tqdm>=4.59,<4.60
ipykernel~=6.0
matplotlib

Thanks for finding this.  It turns out that another package is needed in the yaml that is used to build the environment.  Add:
- mlflow-skinny==<same version number as mlflow>
to the cell that creates the conda.yaml file, and the job will run successfully.  Originally, we were getting the correct version when the environment built, but then recently we weren't.
I'll update the tutorial to add this. At the same time, I'll use more recent versions for a few of the packages.  You'll see the new version of the tutorial later today or tomorrow.
But in the meantime, if you add - mlflow-skinny==2.4.1  to your current code, you'll no longer get this error.

Thanks.  Here is another option.  I set scikit-learn == 1.0.2 and mlflow == 2.8.0 and it worked.  I got there by first using a curated environment, which worked, and then checking the yaml that the registered model used.

I have the same issue. Likewise with training MSFT customer. Please update both the documentation and Azure ML Notebook sample: tutorials/azureml-in-a-day to use the following scikit-learn and mlflow versions on the conda environment

The changes have been made, I used the code in a workshop this morning
From: charlienguyen409 @.>
Sent: Monday, November 20, 2023 3:01 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Comment @.***>
Subject: Re: [MicrosoftDocs/azure-docs] Instructions lead to an error: module 'mlflow' has no attribute 'xgboost' (Issue #116764)
I have the same issue. Likewise with training a MSFT customer. Please update both the documentation and Azure ML Notebook sample: tutorials/azureml-in-a-day to use the following scikit-learn and mlflow versions on the conda environment

Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/116764#issuecomment-1819797217 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWBSWNKMWRF2L3WN35VTY23YFPAKVBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVE3DINRVGUZTENZWURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SOBTGY3TAMRXGQZKI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJHAZTMNZQGQ4DEM5ENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWUTQMZWG4YDIOJZGSSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRRGI4TENRVGEZDINVENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDCNBQGQ4DSNJVGYYKI3TBNVS2S2DBONPWYYLCMVWKY43VMJVGKY3UL52HS4DFVREXG43VMVBW63LNMVXHJJTUN5YGSY3TTCBKI5DZOBS2U4TFOBXXG2LUN5ZHTJLWMFWHKZNIG4ZDMOBVGAZDNAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCOJXG42DENJTGQYYFJDUPFYGLJLMMFRGK3FFOZQWY5LFVE3DINRVGUZTENZWQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJYGM3DOMBSG42DFAVEOR4XAZNFNRQWEZLMUV3GC3DVMWUTQMZWG4YDIOBSGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJHAZTMNZQGQ4TSNECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UMJSHEZDMNJRGI2DNAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDCNBQGQ4DSNJVGYYKO5DSNFTWOZLSUZRXEZLBORSQ.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


fix(window): properly fire WindowEvent::Destroyed on macOS

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information
This is an extension to #349, I wrote it as separate PRs to be reviewed individually. We can use a single change file later if you want.

Seems like the NSWindowDelete's windowWillClose hook is not called when the Window is dropped, so I had to fire the Destroyed event manually.


Nov 14 19 UltiSnips update

Not quite done with this section but I will need more time to work on it. Then I will head into neovim after this.

UltiSnips update

Merged marevebro's Nov. 14th pull request.


Continue bundle

Codecov Report

Merging #596 (5ca48d3) into master (889325d) will decrease coverage by 0.26%.
The diff coverage is 1.69%.

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   71.07%   70.80%   -0.27%
==========================================
  Files         118      124       +6
  Lines       10812    10774      -38
==========================================
- Hits         7685     7629      -56
- Misses       3127     3145      +18

Impacted Files
Coverage Δ

assemblyline/common/bundling.py
0.00% <0.00%> (ø)

assemblyline/odm/models/replay.py
0.00% <0.00%> (ø)

assemblyline/odm/models/submission.py
84.61% <100.00%> (+0.17%)
:arrow_up:

assemblyline/odm/base.py
88.28% <0.00%> (-0.91%)
:arrow_down:

assemblyline/odm/randomizer.py
92.24% <0.00%> (-0.44%)
:arrow_down:

assemblyline/datastore/helper.py
31.39% <0.00%> (-0.38%)
:arrow_down:

assemblyline/odm/models/submission_tree.py
100.00% <0.00%> (ø)

assemblyline/datastore/stores/es_store.py

...blyline/datastore/support/elasticsearch/schemas.py

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889325d...5ca48d3. Read the comment docs.

tests failed

Just one of those github reporting test result for the wrong branch...


feat(clerk-js): Notify admins for pending requests in OrganizationSwitcher

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[x] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[ ] npm test runs as expected.
[ ] npm run build runs as expected.

This PR is an improvement for the notification badge in OrganizationSwitcher

Include the number of pending requests in the active organization in switcher (for organization admins)
Add the same number to the "Requests" tab  in OrganizationProfile

https://github.com/clerkinc/javascript/assets/19269911/03e91fdd-2dd2-497d-9baa-96cf3ea3ce42

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


nixos/slurm: <IP_ADDRESS> -> <IP_ADDRESS>, improve security

Motivation for this change

Bugfix update: https://github.com/SchedMD/slurm/blob/slurm-20.11/NEWS
Security fix in module. See https://github.com/NixOS/nixpkgs/issues/121293

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121336 at d07185f9 run on x86_64-linux 1

2 packages marked as broken and skipped:

python38Packages.pyslurm
python39Packages.pyslurm

2 packages built successfully:

slurm
slurm-spank-x11


Already seen flags not showing when loading an inactive workflow when already classified all the subjects in that workflow

I just loaded workflow 2063 It's inactive but we're using for the science team review of data. I have classified all the data live on there from the annotations, but it didn't give me an 'already seen' when I loaded the url. I have previously gotten already seen on that workflow.

@mschwamb was this a new workflow? or the set of newly linked data on an old workflow?

old workflow with no new subject sets on it.
We do have a new workflow and a subject set attached to it, but this new subject set is not linked to 2063


Rename module suffixes from  .pm to .pm6

I am :+1: considering style implications, but keep in mind that it'll ruin github's file history feature, which is very neat when you need to find where, why and by who some changes were made.
It still can be traced locally, of course, but might be not so handy sometimes as web interface.
Moving "virtually"(for web-view) erases file history and new starting point will be moving commit, which is LTA, so we may want to consider it.

Doing git mv preserves history; the ony thing is that whoever does the
history shows up as "original author". Still, all the commits are there and
show up with "blame"

@JJ That sound good enough.

I’ll take the action but it will be awhile before I can get to it. I’ll not self-assign yet.

Closed with merge commit 4d6918a.


Assertion failure in JavascriptOperators::IsUndefinedObject()

Hello, running following code in ch 1.11.24(debug), an assertion will be thrown.
var start;
var end;
function opt(buffer) {
    var sc = WScript.LoadScript('', 'samethread');
    buffer += 0;
    var result = buffer.slice(start, end);
    return sc;
}

for (var i = 0; i < 2; i++) {
    var buffer = new ArrayBuffer(8);
    end = opt(buffer);
}

output:
ASSERTION 25452: (c:\users\sunlili\documents\workspace\jsenginesfordebug\chakracore-1.11.24\lib\runtime\language\javascriptoperators.cpp, line 10982) !RecyclableObject::Is(instance) ? TRUE : ((RecyclableObject*)instance)->GetScriptContext()->GetLibrary() == library
 Failure: (!RecyclableObject::Is(instance) ? 1 : ((RecyclableObject*)instance)->GetScriptContext()->GetLibrary() == library)
FATAL ERROR: ch.exe failed due to exception code c0000420

This assertion is triggered in the second time executing buffer.slice(start, end). The end is redefined after first calling opt, and it becomes a Js::CrossSiteObject<Js::GlobalObject>. So when checking in JavascriptString::EntrySlice(), the assertion is triggered.
ISec Lab.
2020.12.16

Thanks for the report. Whilst this is an issue in 1.11 it has been fixed in master for some time.


Getting ERR! Error: Command failed: node-gyp rebuild --jobs max. Error: Could not find any Visual Studio installation to use.

Complete log
C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs>if not defined npm_config_node_gyp (node "C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max )  else (node "C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max )
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files"
gyp ERR! find VS - will only use this version
gyp ERR! find VS unknown version "undefined" found at "C:\Program Files\Microsoft Visual Studio\2022\Community"
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:372:16
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:315:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1048:16)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\\Users\\TestingAccount\\nodejs\\node.exe" "C:\\Users\\TestingAccount\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--jobs" "max"
gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
ERR! Error: Command failed: node-gyp rebuild --jobs max
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files"
gyp ERR! find VS - will only use this version
gyp ERR! find VS unknown version "undefined" found at "C:\Program Files\Microsoft Visual Studio\2022\Community"
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:372:16
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Users\TestingAccount\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:315:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1048:16)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\\Users\\TestingAccount\\nodejs\\node.exe" "C:\\Users\\TestingAccount\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--jobs" "max"
gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok

OS : Windows 10
Error getting while installing opencv4nodejs

gyp ERR! node-gyp -v v5.1.0

Please upgrade to https://github.com/nodejs/node-gyp/releases using https://github.com/nodejs/node-gyp/blob/master/docs/Updating-npm-bundled-node-gyp.md

Thank you for the response. I have changed the npm-gyp refernce and ran the installation command again. But still getting the same error.
C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max )  else (node "C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max )
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files"
gyp ERR! find VS - will only use this version
gyp ERR! find VS checking VS2022 (17.0.31919.166) found at:
gyp ERR! find VS "C:\Program Files\Microsoft Visual Studio\2022\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v143
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:122:47)
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:75:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:363:14)
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:71:14
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:384:16
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:315:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1048:16)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--jobs" "max"
gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok
ERR! Error: Command failed: node-gyp rebuild --jobs max
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files"
gyp ERR! find VS - will only use this version
gyp ERR! find VS checking VS2022 (17.0.31919.166) found at:
gyp ERR! find VS "C:\Program Files\Microsoft Visual Studio\2022\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v143
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS checking VS2017 (15.9.28307.1745) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v141
gyp ERR! find VS - found Windows SDK: 10.0.17763.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:122:47)
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:75:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:363:14)
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:71:14
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:384:16
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:315:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1048:16)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--jobs" "max"
gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok

The version of npm-gyp is now v8.4.1. But the VS is not getting detected.
I have vs 2017 installed under : C:\Program Files (x86)\Microsoft Visual Studio\2017
C:\Program Files\Microsoft Visual Studio\2017
2019 installed under : C:\Program Files (x86)\Microsoft Visual Studio\2019
2022 installed under : C:\Program Files\Microsoft Visual Studio\2022\Community

The often-repeated line msvs_version does not match this version seems to be the problem but I am not a Windows user.

The often-repeated line msvs_version does not match this version seems to be the problem but I am not a Windows user.

The version gets picked from the .npmrc file. Not sure it cant detect the Visual Studio.

Have these installations of VS in the system.

Are you aware of which Visual Studio installation file node-gyp looking for.
![image](https://user-images.githubusercontent.com/71168111/144739307-58248b48-1633-4c8e-921f-762b018461ca.png
If we know the path "this.configPath" node-gyp looking for the we can try to set that manually and run to check whether it will work or not

findVisualStudio: function findVisualStudio() {
this.configVersionYear = null
this.configPath = null
if (this.configMsvsVersion) {
this.addLog('msvs_version was set from command line or npm config')
if (this.configMsvsVersion.match(/^\d{4}$/)) {
this.configVersionYear = parseInt(this.configMsvsVersion, 10)
this.addLog(
- looking for Visual Studio version ${this.configVersionYear})
} else {
this.configPath = path.resolve(this.configMsvsVersion)
this.addLog(
- looking for Visual Studio installed in "${this.configPath}")
}
} else {
this.addLog('msvs_version not set from command line or npm config')
}
If we know the path "this.configPath" node-gyp looking for (In the file E:\Software\npm-gyp\node-gyp-8.4.1\lib\find-visualstudio) the we can try to set that manually and run to check whether it will work or not

Look thru your log output above for lines that start with gyp ERR! find VS checking VS20 to see all the versions that it is finding.  The problem is that after finding them, the code does not like their msvs_version.

https://github.com/nodejs/node-gyp/blob/master/docs/Common-issues.md

I have installed VS from location mentioned in the above link and set the version as 2017 but for some reason still not picking the vs installation.

The "envVcInstallDir" gets the value "c://Program files" and the "vsPath "  gets the actual installation path. The because of this
the "return true" never gets execute. That is why the visual studio installation is not getting detected. On hard coding the path
"MSBuild.exe" is getting detected.

But still fails with below error.
C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max )  else (node "C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max ) C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs\build\opencv4nodejs.vcxproj(21,3): error MSB4019: The imported project "C:\Program Files (x86)\Microsoft Visual Studio\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. gyp ERR! build error gyp ERR! stack Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exefailed with exit code: 1 gyp ERR! stack     at ChildProcess.onExit (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\build.js:194:23) gyp ERR! stack     at ChildProcess.emit (events.js:315:20) gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12) gyp ERR! System Windows_NT 10.0.19042 gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\TestingAccount\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--jobs" "max" gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs gyp ERR! node -v v14.15.4 gyp ERR! node-gyp -v v8.4.1 gyp ERR! not ok ERR! Error: Command failed: node-gyp rebuild --jobs max gyp ERR! build error gyp ERR! stack Error:C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe failed with exit code: 1 gyp ERR! stack     at ChildProcess.onExit (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\build.js:194:23) gyp ERR! stack     at ChildProcess.emit (events.js:315:20) gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12) gyp ERR! System Windows_NT 10.0.19042 gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\TestingAccount\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--jobs" "max" gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs gyp ERR! node -v v14.15.4 gyp ERR! node-gyp -v v8.4.1 gyp ERR! not ok

Any one know how to sort this out

Anyone know whether this package require any additional tools to run in the AMD based system. Why I am asking because I just installed the opencv4nodejs (Which uses node-gyp) on my old intel based system just now. Not sure if it works. But the installation completed without error. So confuse if the issue is with my Ryzen processor. Both the systems have windows 10 installed and intel one(successful) have node v14.16.1 and amd one have 14.15.4. Not much difference.

I'm getting the same error when installing @tensorflow/tfjs-node

But still fails with below error.
C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max )  else (node "C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild --jobs max )
C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs\build\opencv4nodejs.vcxproj(21,3): error MSB4019: The imported project "C:\Program Files (x86)\Microsoft Visual Studio\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\TestingAccount\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--jobs" "max"
gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok
ERR! Error: Command failed: node-gyp rebuild --jobs max
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\lib\build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\TestingAccount\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--jobs" "max"
gyp ERR! cwd C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\opencv4nodejs
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok

guys am Having the same Issue on an Intel processor, amd64  have installed vs version but still can't wrap my head around why its not detecting visual studio, like i therer no human that has got a clue on how to solve this issue.
I had to re-install my OS just to make sure i do not have any conflicting  programs. need help.

gyp ERR! node-gyp -v v8.4.1

https://github.com/nodejs/node-gyp/releases

Had a similar issue when installing danfojs-node which is dependent on @tensorflow/tfjs-node. This is how I fixed the issue,

Went into node_modules/@tensorflow/tfjs-node directory and ran the command that was failing, in the case of this particular error log in this issue, it would be

"C:\Program Files\nodejs\node.exe" "C:\Users\TestingAccount\AppData\Roaming\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--jobs" "max"

In my case, it mentioned that a particular SDK was missing The Windows SDK version 10.0.18362.0 was not found.

I modified the installation of VS build tools 2019 to contain the missing SDK, using Visual studio installer, I think finding the SDK on the Microsoft archive will give an equivalent result. I also had to remove any other SDK so that node-gyp can find the particular SDK it was looking for. npm install now works

This StackOverflow answer was a guide https://stackoverflow.com/a/50606326

Please use the updated Windows setup... https://github.com/nodejs/node-gyp?tab=readme-ov-file#on-windows

试试把visual studio community 的C++桌面开发的这几项勾选上，保险起见全部勾选上也行，感觉应该是windows sdk造成的问题


CU-27phxeh Adding notebook for some adhoc analyses

@NatHillardUSDS -- Alicia had asked for some adhoc analysis on percentage of tests that are PCR vs antigen (see Slack Thread here). I figured can add notebooks like these to GitHub for transparency. I imagine that this repo will have some adhoc notebooks moving forward so thought it could fit here?

Task linked: CU-27phxeh test


Add csvs-to-sqlite

Thanks for adding csvs-to-sqlite. Love your datasette work / tool. Keep it up.  Awesome. Cheers. Prost.


Updated Contribution Guide to be More Detailed

Added step-by-step instructions to get started developing in ADE, including:

Additional prerequisites for development
System setup required for pulling and developing code
Docker Run adjustments to mount local code into the running container
Branching strategy and pull requests
Edge scenarios for development (e.g., Custom Script Extensions)

Fixes #222

Added step-by-step instructions to get started developing in ADE, including:

Additional prerequisites for development
System setup required for pulling and developing code
Docker Run adjustments to mount local code into the running container
Branching strategy and pull requests
Edge scenarios for development (e.g., Custom Script Extensions)

Fixes #222


make tests run faster

TestRebuildIndex & TestRestore slowness make Debian reproducible builds fail:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/restic.html (TestRebuildIndex)
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/i386/restic.html (TestRestore)
The package is also not buildable on mips & mipsel because TestCheckRestoreNoLock & TestParallelSaveWithDuplication are too slow (this prevents the package from migrating to testing) :
https://buildd.debian.org/status/fetch.php?pkg=restic&arch=mips&ver=0.8.3%2Bds-1&stamp=1519747618&raw=0 (TestParallelSaveWithDuplication)
https://buildd.debian.org/status/fetch.php?pkg=restic&arch=mipsel&ver=0.8.3%2Bds-1&stamp=1519748266&raw=0 (TestCheckRestoreNoLock & TestParallelSaveWithDuplication)

Soo, what can we do for that? Does Debian need to run the tests, is that really necessary?

I looked into this a little bit and noticed that setting TMPDIR=$(mktemp -d /dev/shm/restic.XXXXXX) helped tremendously to reduce the test time on our ARM porter box, where /tmp is not tmpfs.
However, the 4G of tmpfs are exhausted during a restic test run:
[…]
=== RUN   TestBackup
Copy: write /dev/shm/restic.2KFSRL/restic-temp-check-796600311: no space left on device
[…]

This seems excessive. Why do the tests require so much disk space and I/O?

I'll take a look. The particular test hasn't been modified in a long time though...

Hm. I can't reproduce it. In my manual tests here (on amd64 though), the data stored in the temp dir does not exceed 200MiB.
We have several (sort of) "end to end" tests where we extract a tar with some test data, make several backups of it while simulating error conditions or special cases with file permissions. Afterwards, the checker is run and all data is verified. This all uses temp files where possible to reduce memory usage. The temp files are removed as soon as they aren't needed any more, typically when the test function returns.
These tests were never meant to be run by distributions...

Hm. I can't reproduce it. In my manual tests here (on amd64 though), the data stored in the temp dir does not exceed 200MiB at each point in time.

What’s your parallelism level? The command line which was used on the Debian porterbox is:
go test -vet=off -p 4 github.com/restic/restic/cmd/restic github.com/restic/restic/internal/archiver github.com/restic/restic/internal/backend github.com/restic/restic/internal/backend/azure github.com/restic/restic/internal/backend/b2 github.com/restic/restic/internal/backend/gs github.com/restic/restic/internal/backend/local github.com/restic/restic/internal/backend/location github.com/restic/restic/internal/backend/mem github.com/restic/restic/internal/backend/rest github.com/restic/restic/internal/backend/s3 github.com/restic/restic/internal/backend/sftp github.com/restic/restic/internal/backend/swift github.com/restic/restic/internal/backend/test github.com/restic/restic/internal/cache github.com/restic/restic/internal/checker github.com/restic/restic/internal/crypto github.com/restic/restic/internal/debug github.com/restic/restic/internal/errors github.com/restic/restic/internal/filter github.com/restic/restic/internal/fs github.com/restic/restic/internal/fuse github.com/restic/restic/internal/hashing github.com/restic/restic/internal/index github.com/restic/restic/internal/limiter github.com/restic/restic/internal/list github.com/restic/restic/internal/migrations github.com/restic/restic/internal/mock github.com/restic/restic/internal/options github.com/restic/restic/internal/pack github.com/restic/restic/internal/pipe github.com/restic/restic/internal/repository github.com/restic/restic/internal/restic github.com/restic/restic/internal/test github.com/restic/restic/internal/walk github.com/restic/restic/internal/worker

We have several (sort of) "end to end" tests where we extract a tar with some test data, make several backups of it while simulating error conditions or special cases with file permissions. Afterwards, the checker is run and all data is verified. This all uses temp files where possible to reduce memory usage. The temp files are removed as soon as they aren't needed any more, typically when the test function returns.

Even 200 MB strikes me as much. Why are the files to back up not just 1 byte files?

These tests were never meant to be run by distributions...

How else can we verify your code runs on all our release architectures? :)

By the way, here are the timings:
Without TMPDIR on tmpfs:
started at Fri Mar  9 21:45:58
exited abnormally with code 1 at Fri Mar  9 22:01:35
With TMPDIR on tmpfs:
started at Fri Mar  9 23:17:11
exited abnormally with code 1 at Fri Mar  9 23:24:26
The latter is more than twice as fast as the former. The more disk i/o you can avoid, the faster the tests will get.

Even 200 MB strikes me as much. Why are the files to back up not just 1 byte files?

For a backup program, archiving directories containing only 1 byte files is a rare corner case. For example, this means that each file as archived in the repository would consist of exactly one data blob. And there'd be only one or two pack files in the repo, which is also uncommon.
I agree though that most tests probably won't need a large data set. I'll have a look.

How else can we verify your code runs on all our release architectures? :)

That is an excellent argument I haven't thought about, thanks! :)
Sometimes Go making cross-compilation so easy tricks me into forgetting that just because it compiles and the tests pass on my architecture does not imply it runs correctly on other architectures.

What’s your parallelism level? The command line which was used on the Debian porterbox is: [...] go test -p 4

I did not set the parallelism level by hand, which means it's set to GOMAXPROCS, which is 4 on my machine (real quad-core, not hyper-threading). We don't use t.Parallel() anywhere, so it's only tests for separate packages run in parallel by go test.
I've tried to reproduce the issue on a Raspberry Pi3 (running 32 bit Arch Linux on 4.14.24, Go 1.10, 1GiB RAM). Using the command line you pasted above (running through time and setting a TMPDIR manually and using -p 1), this is the result I get:
$ TMPDIR=/dev/shm/restictest /usr/bin/time go test -vet=off -p 1 github.com/restic/restic/cmd/restic github.com/restic/restic/internal/archiver github.com/restic/restic/internal/backend github.com/restic/restic/internal/backend/azure github.com/restic/restic/internal/backend/b2 github.com/restic/restic/internal/backend/gs github.com/restic/restic/internal/backend/local github.com/restic/restic/internal/backend/location github.com/restic/restic/internal/backend/mem github.com/restic/restic/internal/backend/rest github.com/restic/restic/internal/backend/s3 github.com/restic/restic/internal/backend/sftp github.com/restic/restic/internal/backend/swift github.com/restic/restic/internal/backend/test github.com/restic/restic/internal/cache github.com/restic/restic/internal/checker github.com/restic/restic/internal/crypto github.com/restic/restic/internal/debug github.com/restic/restic/internal/errors github.com/restic/restic/internal/filter github.com/restic/restic/internal/fs github.com/restic/restic/internal/fuse github.com/restic/restic/internal/hashing github.com/restic/restic/internal/index github.com/restic/restic/internal/limiter github.com/restic/restic/internal/list github.com/restic/restic/internal/migrations github.com/restic/restic/internal/mock github.com/restic/restic/internal/options github.com/restic/restic/internal/pack github.com/restic/restic/internal/pipe github.com/restic/restic/internal/repository github.com/restic/restic/internal/restic github.com/restic/restic/internal/test github.com/restic/restic/internal/walk github.com/restic/restic/internal/worker

restic/restic/internal/worker
ok      github.com/restic/restic/cmd/restic     363.582s
ok      github.com/restic/restic/internal/archiver      90.480s
ok      github.com/restic/restic/internal/backend       10.573s
ok      github.com/restic/restic/internal/backend/azure 0.019s
ok      github.com/restic/restic/internal/backend/b2    0.018s
ok      github.com/restic/restic/internal/backend/gs    0.043s
ok      github.com/restic/restic/internal/backend/local 6.685s
ok      github.com/restic/restic/internal/backend/location      0.037s
ok      github.com/restic/restic/internal/backend/mem   5.801s
ok      github.com/restic/restic/internal/backend/rest  0.120s
ok      github.com/restic/restic/internal/backend/s3    0.048s
ok      github.com/restic/restic/internal/backend/sftp  12.737s
ok      github.com/restic/restic/internal/backend/swift 0.111s
ok      github.com/restic/restic/internal/backend/test  9.690s
ok      github.com/restic/restic/internal/cache 6.551s
ok      github.com/restic/restic/internal/checker       24.832s
ok      github.com/restic/restic/internal/crypto        2.766s
ok      github.com/restic/restic/internal/debug 0.073s [no tests to run]
?       github.com/restic/restic/internal/errors        [no test files]
ok      github.com/restic/restic/internal/filter        1.419s
ok      github.com/restic/restic/internal/fs    0.035s
ok      github.com/restic/restic/internal/fuse  33.905s
ok      github.com/restic/restic/internal/hashing       0.660s
ok      github.com/restic/restic/internal/index 260.385s
?       github.com/restic/restic/internal/limiter       [no test files]
?       github.com/restic/restic/internal/list  [no test files]
?       github.com/restic/restic/internal/migrations    [no test files]
?       github.com/restic/restic/internal/mock  [no test files]
ok      github.com/restic/restic/internal/options       0.024s
ok      github.com/restic/restic/internal/pack  0.111s
ok      github.com/restic/restic/internal/pipe  0.087s
ok      github.com/restic/restic/internal/repository    41.658s
ok      github.com/restic/restic/internal/restic        44.791s
?       github.com/restic/restic/internal/test  [no test files]
ok      github.com/restic/restic/internal/walk  4.662s
ok      github.com/restic/restic/internal/worker        0.014s
1208.29user 62.11system 7:05.20elapsed 298%CPU (0avgtext+0avgdata 270616maxresident)k
36165inputs+85024outputs (17major+2146775minor)pagefaults 0swaps

Max storage used in /dev/shm/restictest was 238MiB total (Go build result plus restic test), with 57MiB for Go build result and 178MiB for restic tests.
I've identified one test (in internal/archiver, TestParallelSaveWithDuplication, which I disabled above) which uses a large amount of memory (> 800MiB). Disabling that allowed me to successfully run all tests on my smaller Pi3
So, from my point of view, there are several things we could do:

Remove/Rework the TestParallelSaveWithDuplication, exclude/remove it in the Debian package
Have a look at all tests and decide if they really need a repo and/or files stored on the disc, and then reduce the size where possible
In order to keep extensive tests which use a lot of i/o in the code base (we will probably have at least one or two of those), skip extensive tests when testing.Short() is set. Then, downstream distributions could use go test -short to skip those extensive tests. Would that work for you?
We could also mark several tests as "integration" tests which are not run by default. Maybe that's better?

Thoughts?

Thanks for looking into this.
I would recommend to proceed as follows:

Make tests use less resources and complete faster. This should suffice to fix the problem entirely.
If required (e.g. as a short-term workaround, or because certain tests can’t be made less resource-intensive), exclude them from -short runs as you mentioned. We can use this in Debian, but would prefer not to.

Marking tests as not running by default seems like a last-resort thing to me, so I’d recommend against that for now.
The machine I tested on was https://db.debian.org/machines.cgi?host=eller, which is mipsel, not ARM (I misspoke earlier).

Thanks for the clarification and your recommendation, I'll have a look at the tests.

I've implemented first measures in #1669, it should already be much faster now. I've reduced the amount of data that is generated/processed in the test and even removed two tests. All without reducing code coverage :)

Since 0.9.1 is already migrated to testing, I think the tests run fast enough. Can we close this issue @legrostdg?

You're right, let's close this.


Enable SSL

In order for us to allow people to include the Schedule and in the future create a inline embedded proposal form we need to have SSL for sites who already runs on https to include our iframes.

Why we dont use let's encrypt certificate?

We should use Let's encrypt or Cloudflare.

@luanfonceca how is the issue going? There is a thing called certbot that installs automaticaly an SSL certificate on Apache2/Nginx/whatever!

Anyone get this issue yet, did you already used it? If you do and want to fix this i can give you access to the server and other stuffs.

I’m working on this issue.

DONE

installed certbot (~/certbot/)
generated certificates with certbot (auth via standalone server)
apt-get update has been fixed (missing keys)
nginx have been updated to version 1.6.2 (apt-get update && apt-get -t wheenzy-backports install)
default site configured to use ssl certificates

TODO

renew the certificates via crontab
replace hardcoded http links (we may probably create another issue for this)

Note: there was another nginx installed with http_ssl_module installed but its version was too old (1.2.1)


TypeError: environment.teardown is not a function

node scripts/test.js --env=jsdom
FAIL  src/App/App.test.js
● Test suite failed to run
TypeError: environment.teardown is not a function

  at node_modules/jest-runner/build/run_test.js:230:25

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        1.244s
Ran all test suites.
help me ! thanks ,how do ? environment.teardown is not a function

Properly install latest Jest, this will fix it.


modify copyright year

Ⅰ. Describe what this PR does
This pr is to modify copyright year of pkg/ddc/alluxio/deprecated_label.go
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/lgtm


KB/MB/GB units are rounded to the nearest integer

The higher units aren't shown with decimal point. The values are shown as integers, which are rounded, e.g. '1 GB' will be shown for a balance of 500 MB (if you have set GB unit).
This issue is the same for Bytes and Blackbytes.

Fixed https://github.com/byteball/byteball/commit/2b4d75e7b56830aa813af1cef79bbeee6f78673c

Will be included in 1.3


WIP: add libiconv port

Here is a working port of libiconv.
Potential issues (not really road blockers more of style):

patch instead of using a custom file? I chose to use a custom file as the config.in since the file() command in CMake doesn't overwrite filenames. The vcpkg apply patch doesn't seem to work as it takes the out parameter as an input parameter (I can file an issue on this), and overwriting the file doesn't require git.
patch-ify everything? The idea being that one patch would need to be applied instead of several copy commands.

I can adjust this PR based on your feedback.

Hi @ethanhs, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@ethanhs, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

This looks pretty perfect as-is 👍 . My thoughts are

If you only need to add files, don't use a patch.
Do not modify files by checking in a modified copy -- always use a patch.
If you need to add files and modify files, you're welcome to select the mix that works the best for you (I generally find patches easier to work with in this case).

Thanks. I will start working on a libxml2 port with those guidelines in mind.


Tab completion slow and raises warnings

Apologies if this was already spotted/fixed, I am using 0.6.2.
The typer command-line interface allows shell completions to be installed for a nicer interactive experience. However, when I try to use these, or run the --help command:
a) the response is quite slow, which negates the workflow improvement
b) sometimes minor deprecations warnings are raised by dependencies such as e3nn/pytorch.
This could probably be avoided by delaying the import of these modules so that it is possible for typer to do whatever it wants to do without loading a lot of dependencies.

spotted yes, fixed not yet.


demo not working

is it only me or the demo link is actually not responding http://demo.c006.us/ , i get the following

The connection has timed out
The server at demo.c006.us is taking too long to respond.
The site could be temporarily unavailable or too busy. Try again in a few moments.
If you are unable to load any pages, check your computer’s network connection.
If your computer or network is protected by a firewall or proxy, make sure that Firefox is permitted to access the Web.

i do not have any firewall installed.

Hi Oman.
It's down for now.
Thanks for the reminder, I need to remove the links.
Jon
On Sat, Jun 17, 2017 at 8:56 AM, Omer Aslam<EMAIL_ADDRESS>wrote:

is it only me or the demo link is actually not responding
http://demo.c006.us/ , i get the following
The connection has timed out
The server at demo.c006.us is taking too long to respond.
The site could be temporarily unavailable or too busy. Try again in a few moments.
If you are unable to load any pages, check your computer’s network connection.
If your computer or network is protected by a firewall or proxy, make sure that Firefox is permitted to access the Web.
i do not have any firewall installed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/c006/yii2-migration-utility/issues/26, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AHVHsFjD9QPHbiXEqdBsMh07K-mPTyslks5sE_dGgaJpZM4N9Qrn
.

cool

Added a screen capture


[HybridApp] Add patch for expo-av required to run HybridApp

cc: @AndrewGable
Details

The patch is required to build HybridApp for Android devices. It adds a simple logic, which will look for reactNativeProject variable defined in gradle.properties. If the variable is not defined it will fallback to the default path to see where react native code is located in node_modules.
The PR should not introduce any changes in NewDot. The changed code is located in build.gradle file, which means that it will affect only native android build.
Fixed Issues

AFAIK there hasn't been an issue created for the bug yet cc: @AndrewGable
$
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console
[x] Build the app
[x] (optional) See if video works - the change doesn't affect video implementation in any way, though

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console
[x] Build the app
[x] (optional) See if video works - the change doesn't affect video implementation in any way, though

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/75020057/075cfe26-ab25-4610-8edc-828267d66991

Android: mWeb Chrome
N/A

iOS: Native
N/A

iOS: mWeb Safari
N/A

MacOS: Chrome / Safari
N/A

MacOS: Desktop
N/A

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Release 3.2.0

Release 3.2.0

Stability fixes
Support Gift cards

CI is updated, conducted with grumphp (dev dep)


Bump Python version to 3.10 - 3.12

Support for Python version from 3.10 to 3.12.

@tanwarsh The changes look good. Please resolve the merge conflicts. This will need to be brought into v1.7.x for consistency with the latest documentation that states support for python 3.10-3.12


Does it support DNSSEC?

Didn't find any option to query DNS Server with DNSSEC on. Can provide an example if it is supported?

Any comments on this?

Hey @deepak-nawathe - yes and no. The library itself supports any resource record that still matches the original RFCs etc, which means it can pull back the appropriate data, albeit some cases will be more cumbersome to query as the DnsType enum won't contain RRSIG, DNSKEY etc.
What the library won't do is provide basically everything described here in terms of using the information from a server with DNSSEC.
I'd love to have a DNSSEC-compatible resolver that does do all of that but I haven't had the time to do so.

Thanks @Turnerj! I would wait for DNSSEC-compatible resolver capability.


does Rapidoc really support Oauth2?

i'm trying to implement Oauth2 to my documentation but in rapidoc it does not requests any key, just shows the link that i set in authorization Url, am i doing something wrong?
code example =

how it looks like :

how it should looks like :

To allow oAuth functionality, you need to implement the authorization flow on your own end, and once you receive the token transfer it to RapiDoc element using setAttribute() method
check #54 for more info on this.


[meteo.apb.es] Show numeric temperature value in thermometer widget

Invalid or already done? There's an  showing "Temperatura: xx Cel"


feat: Add capabilities for protocol and types of accessories

:tada: This PR is included in version 0.12.0-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.12.0-main-ci-test.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Moving CONTRIBUTING into a separate file

Main README is a bit shorter
Bonus: Github shows a prompt: "Please review the guidelines for contributing to this repository." when people are creating issues

Cheers @GBH


Bugfix copy style

Bug: Using the copy button does create a new style and works as long as the game is running. Since it does not save the changes to disk, the new style is empty after reloading the game.

@AndreasMayer1  can you clarify what is the bug? and what is this trying to fix?

Hi jk2l, for me copy styles does only works as long as I don't restart the game. How to reproduce:

Copy a style
Save and close the game
Start and load the saved game
The copied style contains no assets

A copied style is empty after restarting the game, cause the created style file doesn't contain any buildings.
This PR just uses the same method that is used by the include all button to add all buildings to the new style.


Updating to Nom 7 has broken double("NaN")

╰─$ rustc -V
rustc 1.54.0 (a178d0322 2021-07-26)

Given the following code:
use nom::{error::Error, number::complete::double};
fn main() {
    println!("{:?}", double::<_, Error<_>>("NaN"));
}

In Nom version 6,  this runs and returns:
Ok(("", NaN))

In Nom version 7, this returns:
Err(Error(Error { input: "NaN", code: Float }))

Maybe this is intentional? I'm not seeing anything in the release notes about it, however.

https://github.com/Geal/nom/issues/1309:

Does not handle special values (NaN, Infinity).

Personally I do not understand why we take Minimal-Lexical there are soo many con, unfortunatly I see the change when it was already done, Rust 1.55 just landed and have a new float parser that is expected to be fast https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html#faster-more-correct-float-parsing we should maybe considering use it instead.

#1309:

Does not handle special values (NaN, Infinity).

Personally I do not understand why we take Minimal-Lexical there are soo many con, unfortunatly I see the change when it was already done, Rust 1.55 just landed and have a new float parser that is expected to be fast https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html#faster-more-correct-float-parsing we should maybe considering use it instead.

I'm the author of that PR, and the author of minimal-lexical. Geal/nom isn't supporting only v1.55, only v1.48+, but ideally, once the MSRV increases, yes, this dependency should be removed. Also, NaN parsing isn't what's handled by minimal-lexical, but I can submit a PR here to fix that.

Ok I know where this is a bug: the implementation does not check for special values right now, which minimal-lexical doesn't handle internally. I'll submit a PR shortly.

I'm concern with perf penalty this do, cause Gael compare bench with different feature it was an unfair benchmark.

I'm concern with perf penalty this do, cause Gael compare bench with different feature it was an unfair benchmark.

I haven't seen Geal's exact benchmarks, but I can tell you the performance is a fair bit faster prior to 1.55.0 for a relatively comprehensive suite of floats. After 1.55.0, standard should be a bit faster if we don't have to tokenize the float (but this isn't the case), so minimal-lexical should actually still be faster, since core does a lot of duplicate work.

My problem is that while I don't want to say your work is not amazing but I would like a more neutral argument, since you are the creator of minimal-lexical your have praise your own crate, that not wrong but that make me vigilant to what you claim, in the original issue your said:

Stable on no_std (coming to lexical-core in v0.8).
Uses the Eisel-Lemire algorithm, providing faster float parsing (coming to lexical-core in v0.8).

But lexical-core is now 0.8, mean your list of pro become small add that I don't really agree with some

Faster compile times.

I don't care rust is slow anyway and cargo check do the job. Also lexical-core claim to be faster now

Stable API with a single exported trait and function.

I don't know much so no opinion I expect lexical-core have similar.

Dependency-free when disabling no_alloc feature.

Why dependency would be a problem specially https://crates.io/crates/lexical-core/0.8.0/dependencies only dependency are internal tool to split crates.

Easier support for custom float formats (may be useful to support parsing JSON-conforming floats, which could be a valid use-case).

double purpose of nom is to parse standard float (I think same of std) so not a pro for nom

Larger version support (minimal-lexical supports 1.31.0+, while lexical-core requires 1.37.0+).

lexical-core 0.8 require 1.51.0, can't say it's not a pro but personally that a meh, the nom 7 would just have require a little more.
And we end with two cons:

Must tokenize the float in Nom.
Does not handle special values (NaN, Infinity).

I add one

much less used and less maintained power

The main pro was benchmark, but what if are the number versus lexical-core 0.8 (obviously with NaN and Infinity)? If the number with the special value handle show lexical-core is better I will see no reason to not pick lexical-core again. If number show minimal-lexical win well nice.

I don't mind either way to use lexical-core vs minimal-lexical (hi 👋👋 I maintain both, and I'm happy to ensure that people don't have to use my crates, which is why I implemented the PR into Rust core, and have made numerous PRs to fast_float (the C++ implementation) and fast-float-rust because I want the ecosystem to win.

My problem is that while I don't want to say your work is not amazing but I would like a more neutral argument, since you are the creator of minimal-lexical your have praise your own crate, that not wrong but that make me vigilant to what you claim, in the original issue your said:

Stable on no_std (coming to lexical-core in v0.8).
Uses the Eisel-Lemire algorithm, providing faster float parsing (coming to lexical-core in v0.8).

But lexical-core is now 0.8, mean your list of pro become small add that I don't really agree with some

minimal-lexical is different than lexical-core. lexical-core v0.8 is certainly faster to compile than v0.7, but it can't compete with a dedicated, small, isolated crate.

Faster compile times.

I don't care rust is slow anyway and cargo check do the job. Also lexical-core claim to be faster now

Many people do care about compile times.

Stable API with a single exported trait and function.

I don't know much so no opinion I expect lexical-core have similar.

lexical-core does have a relatively simple API, but once again, it's not possibl

Dependency-free when disabling no_alloc feature.

Why dependency would be a problem specially https://crates.io/crates/lexical-core/0.8.0/dependencies only dependency are internal tool to split crates.

Because dependencies add compile time issues? I added libm as a dependency to lexical-core v0.7 for stable on no_std and it alone added 2s to every build time.

Easier support for custom float formats (may be useful to support parsing JSON-conforming floats, which could be a valid use-case).

double purpose of nom is to parse standard float (I think same of std) so not a pro for nom

I mean, sure, but it's also a useful potential feature later.

Larger version support (minimal-lexical supports 1.31.0+, while lexical-core requires 1.37.0+).

lexical-core 0.8 require 1.51.0, can't say it's not a pro but personally that a meh, the nom 7 would just have require a little more.

nom7 has already maintained to supporting v1.48+, and lexical-core 0.8 cannot be re-written to support versions older than 1.51, due to the use of const generics integral to the new implementation.

And we end with two cons:

Must tokenize the float in Nom.
Does not handle special values (NaN, Infinity).

I add one

much less used and less maintained power

minimal-lexical is actually used in a private fork by serde-json, so it's unquestionably more used. The maintainers are the same for both lexical-core and minimal-lexical, and maintenance plans have been put into motion if I cannot maintain.

The main pro was benchmark, but what if are the number versus lexical-core 0.8 (obviously with NaN and Infinity)? If the number with the special value handle show lexical-core is better I will see no reason to not pick lexical-core again. If number show minimal-lexical win well nice.

Sure, but there is a compile time difference. minimal-lexical compiles on my computer in ~0.5s, while lexical-core v0.8 with only the float-parsing is ~1.5s. This is substantially faster than the nearly 3.5s of v0.7, but it's worth considering there's a tradeoff for both cases.

Anyway, I'm fine with any of the options:

Patching this bug (already doing that) and keeping minimal-lexical.
Moving to fast-float-rust, which is like lexical-core but much leaner (although it currently has a significant slower slow-path algorithm, since it uses a decimal class rather than big-integer arithmetic).
Moving back to lexical-core, but v0.8 cannot be used which negates many of the upsides of the migration.

Sure, but there is a compile time difference. minimal-lexical compiles on my computer in ~0.5s, while lexical-core v0.8 with only the float-parsing is ~1.5s. This is substantially faster than the nearly 3.5s of v0.7, but it's worth considering there's a tradeoff for both cases.

I'm not talking about compile time here, but benchmark in actually doing the job. That in my opinion is what matter the most in crate like nom.

nom7 has already maintained to supporting v1.48+, and lexical-core 0.8 cannot be re-written to support versions older than 1.51, due to the use of const generics integral to the new implementation.

you didn't understand what I wanted to said, I mean that nom 7 would have require a most recent rust version if needed. that was not a big deal.

Patching this bug (already doing that) and keeping minimal-lexical.

Moving to fast-float-rust, which is like lexical-core but much leaner (although it currently has a significant slower slow-path algorithm, since it uses a decimal class rather than big-integer arithmetic). I've opened an issue so this can be fixed, and am currently implementing a PR for both core and fast-float-rust to ensure these algorithm improvements benefit everyone.

Moving back to lexical-core, but v0.8 cannot be used which negates many of the upsides of the migration. v0.7 has some notable dependencies, such as arrayvec and libm, which do substantially increase build times. There's also slower algorithms used, which is partially why it was such a major re-write.

Depend is that what gael want for number ? since there is no test for that maybe it's not the case, I think nom should handle the same of what std guarantee to handle. So the EBNF grammar
without good reason I don't see why we should do that
for nom 8 maybe. for nom 7 is too late, but again we need benchmark to choice and bench that take into account all features. Now we use minimal-lexical I will want a good reason to change to lexical-core :p

I'm not talking about compile time here, but benchmark in actually doing the job. That in my opinion is what matter the most in crate like nom.

I understood, I pointed out numerous times I don't agree. Although compile time isn't the only factor, minimal-lexical is also fairly performant.

but again we need benchmark to choice and bench that take into account all features. Now we use minimal-lexical I will want a good reason to change to lexical-core :p

I appreciate that. Anyway, I'll do my best to ensure float parsing is viable for everything. In the future, if the new slow-path algorithms are implemented in fast-float-rust, that might be the most logical option.

so, to sum up here:

the new float parser in libstd is great, but as @Alexhuszagh pointed out, it is not compatible with nom's MSRV, so we'll use minimal-lexical for now
we could go back to lexical-core, but that could only happen on the next MSRV raise, ie nom 8
maybe it's faster with minimal-lexical, or lexical-core, or fast-float-rust. We won't know until an actual benchmark is done

I think we can wait a bit before considering a change of float parsing library.
Personally, I am not fond of arguing about the right way to parse floats in nom: the parsers were added for convenience (and for benchmarks, unfortunately), but there's no guarantee that they would parse exactly like people expect in their formats. So they have to provide a minimal feature set for prototyping, then users can make their own tokenizer and pass to something like minimal-lexical or libstd's new float parser, or rely directly on lexical-core and its various format options.

For the record, I have worked around this issue in our app so there is no urgency on my part to resolve this. Nor do I have a particularly strong opinion on the correct way it should be done.


WebRTC without STUN server (local network)

Hey:)
I tried to start a local webRTC connection without a STUN server.
I just started the webcam.py file and connected to the webserver (without ROS and everything).
With the STUN server everything works flawlessly and I get the following messages in the console:

ICE connection state is checking
ICE connection state is complete

But when I disable the STUN Server I only get:

ICE connection state is checking

and it is constantly in this state.
Both PCs are in the same network.
Any idea what could go be wrong?:c

nvm it was a bug in the aiortc package.
An upgrade solved it.