Conversion.ps1 localAssetDirectoryPath read as empty

The Conversion.ps1 gives me bunch of errors after running it.
arrconfig.json appears to pass all json validators I ran it through, but I noticed the path shows up as an empty string? I don't really have any powershell script knowledge to fix this or know why it would do this.
The example Unity application runs fine for me, I am now trying to convert and run my own model.
Command:
powershell -ExecutionPolicy Bypass .\Conversion.ps1 -UseContainerSas
arrconfig.json:
{   "accountSettings": {     "arrAccountId": "-removed-",     "arrAccountKey": "-removed-",     "region": "eastus2"   },   "renderingSessionSettings": {     "vmSize": "standard",     "maxLeaseTime": "24:00:00"   },   "assetConversionSettings": {     "resourceGroup": "RemoteRendering",     "storageAccountName": "remoterendertest",     "blobInputContainerName": "arrinput",     "blobOutputContainerName": "arroutput",     "localAssetDirectoryPath": "D:/AzureRemoteRendering/azure-remote-rendering/Unity/Quickstart/Assets/Arena_Optimised_CutInHalf",     "inputFolderPath": "",     "inputAssetPath": "D:/AzureRemoteRendering/azure-remote-rendering/Unity/Quickstart/Assets/Arena_Optimised_CutInHalf/Arena_Optimised_CutInHalf.FBX",     "outputFolderPath": "D:/AzureRemoteRendering/azure-remote-rendering/Unity/Quickstart/Assets/Arena_Optimised_CutInHalf/Output",     "outputAssetFileName": ""   } }
Output (errors):
`Successfully Loaded Configurations from file : D:\AzureRemoteRendering\azure-remote-rendering\Scripts\arrconfig.json ...
Populating Storage Account information ...
Could not retrieve storage account key for storage account named: 'remoterendertest' in resource group 'RemoteRendering'
Azure settings not valid. Please ensure the required values are filled in correctly in the config file D:\AzureRemoteRendering\azure-remote-rendering\Scripts\arrconfig.json
Uploading asset directory from  to blob storage input container ...
The property 'localAssetDirectoryPath' cannot be found on this object. Verify that the property exists and can be set.
At D:\AzureRemoteRendering\azure-remote-rendering\Scripts\Conversion.ps1:74 char:9
$assetSettings.localAssetDirectoryPath
    CategoryInfo          : InvalidOperation: (:) [], RuntimeException
    FullyQualifiedErrorId : PropertyNotFound

Test-Path : Cannot bind argument to parameter 'Path' because it is null.
At D:\AzureRemoteRendering\azure-remote-rendering\Scripts\Conversion.ps1:77 char:40
 ... utDirExists = Test-Path  -Path $assetSettings.localAssetDirectoryPath
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     CategoryInfo          : InvalidData: (:) [Test-Path], ParameterBindingValidationException
     FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.TestPathCommand

Uploading 4 files to input storage container
Uploading file D:\AzureRemoteRendering\azure-remote-rendering\Scripts\arrconfig.json to input blob storage container
Set-AzStorageBlobContent : The term 'Set-AzStorageBlobContent' is not recognized as the name of a cmdlet, function, script file, or
operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At D:\AzureRemoteRendering\azure-remote-rendering\Scripts\Conversion.ps1:97 char:17
         $blob = Set-AzStorageBlobContent -File $fileToUpload.FullName ...
                 ~~~~~~~~~~~~~~~~~~~~~~~~
     CategoryInfo          : ObjectNotFound: (Set-AzStorageBlobContent:String) [], CommandNotFoundException
     FullyQualifiedErrorId : CommandNotFoundException

Unable to upload file arrconfig.json from local asset directory location  ...
Upload failed - exiting.`

Excuse the formatting I am having some troubles getting this output to look readable...

Hi,
Did you follow the steps from
https://docs.microsoft.com/en-us/azure/remote-rendering/samples/powershell-example-scripts ?
(mainly installing the Az Module and calling Connect-AzAccount).
Your json config migh be fine

Alright I missed that page, it is running now.

Mh now running it for the second time I get a 400 Bad Request when using the -UseContainerSas option?
`Unable to start conversion of the asset ...

Response's MS-CV is 'PNV83Ui//02aAbRyl4o6SQ.0'
{
"IsMutuallyAuthenticated":  false,
"Cookies":  [
            ],
"Headers":  [
                "X-Content-Type-Options",
                "MS-CV",
                "Content-Length",
                "Content-Type",
                "Date"
            ],
"SupportsHeaders":  true,
"ContentLength":  281,
"ContentEncoding":  "",
"ContentType":  "application/json; charset=utf-8",
"CharacterSet":  "utf-8",
"Server":  "",
"LastModified":  "\/Date(1586940715081)\/",
"StatusCode":  400,
"StatusDescription":  "Bad Request",
"ProtocolVersion":  {
                        "Major":  1,
                        "Minor":  1,
                        "Build":  -1,
                        "Revision":  -1,
                        "MajorRevision":  -1,
                        "MinorRevision":  -1
                    },
"ResponseUri":  "https://remoterendering.eastus.mixedreality.azure.com/v1/accounts/*-*-*-*/conversions/createWithSharedAccessSignature",
"Method":  "POST",
"IsFromCache":  false

}

Invoke-WebRequest : {"error":"Unable to start conversion: Invalid request - the following errors occured:\n\tInvalid input path - check input.inputAssetPath for
errors.\n\tInvalid input folderPath - check input.folderPath for errors.\n\tInvalid output folderPath - check ouput.folderPath for errors."}
At D:\AzureRemoteRendering\azure-remote-rendering\Scripts\Conversion.ps1:171 char:21

... $response = Invoke-WebRequest -UseBasicParsing -Uri $url -Method POST ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebException
FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand`

The formatting of the powershell output is not optimal. But if you look closely you see the following error message:
"Unable to start conversion: Invalid request - the following errors occured:
Invalid input path - check input.inputAssetPath for errors.
Invalid input folderPath - check input.folderPath for errors.
Invalid output folderPath - check ouput.folderPath for errors."
This indicates that in your configuration you did not enter valid values. Please note that you also need to remove values marked as optional from the config. An example walkthrough is given in https://docs.microsoft.com/en-us/azure/remote-rendering/quickstarts/convert-model

    "resourceGroup": "RemoteRendering",     "storageAccountName": "remoterendertest",     "blobInputContainerName": "arrinput",     "blobOutputContainerName": "arroutput",     "localAssetDirectoryPath": "D:\\AzureRemoteRendering\\azure-remote-rendering\\Unity\\Quickstart\\Assets\\Arena_Optimised_CutInHalf",     "inputFolderPath": "arenaConversion",     "inputAssetPath": ".\\Arena_Optimised_CutInHalf.FBX",     "outputFolderPath": "arenaOutput",     "outputAssetFileName": "output.arrAsset"
No matter what I do it always throw the invalid path errors for multiple fields. So no idea what is expected here.

Additional Documentation around the example scripts (in addition to the quickstart can be found here):
https://docs.microsoft.com/en-us/azure/remote-rendering/samples/powershell-example-scripts
It states:
"Make sure to properly escape backslashes in the LocalAssetDirectoryPath path by using double backslashes: "\" and use forward slashes "/" in all other paths like inputFolderPath and inputAssetPath."
I can see that inputAssetPath contains "\" (also no need for the .)  - remove the slashes and dot please and turn your inputAssetPath into "Arena_Optimised_CutInHalf.FBX"
which other path errors occur? also can you please provide your arrconfig.json structure? (censor sensitive information like arraccount, key etc )

Alright this is my arrconfig
{   "accountSettings": {     "arrAccountId": "-",     "arrAccountKey": "-",     "region": "eastus2"   },   "renderingSessionSettings": {     "vmSize": "standard",      "maxLeaseTime": "00:30:00"   },   "assetConversionSettings": {     "resourceGroup": "RemoteRendering",     "storageAccountName": "remoterendertest",     "blobInputContainerName": "arrinput",     "blobOutputContainerName": "arroutput",     "localAssetDirectoryPath": "D:\\AzureRemoteRendering\\azure-remote-rendering\\Unity\\Quickstart\\Assets\\Arena_Optimised_CutInHalf",     "inputFolderPath": "D:/AzureRemoteRendering/azure-remote-rendering/Unity/Quickstart/Assets/Arena_Optimised_CutInHalf",     "inputAssetPath": "D:/AzureRemoteRendering/azure-remote-rendering/Unity/Quickstart/Assets/Arena_Optimised_CutInHalf/Arena_Optimised_CutInHalf.FBX",     "outputFolderPath": "D:/AzureRemoteRendering/azure-remote-rendering/Unity/Quickstart/Assets/Arena_Optimised_CutInHalf/Output",     "outputAssetFileName": "output.arrAsset"   } }
And is the error I receive with while running Conversion.ps1
{"error":"Unable to start conversion: Invalid request - the following errors occured:\n\tInvalid input path - check input.inputAssetPath for errors.\n\tInvalid input folderPath - check input.folderPath for
errors.\n\tInvalid output folderPath - check ouput.folderPath for errors."}

inputFolderPath inputAssetPath and outputFolderPath are relative paths in the storage containers and are not paths not on your local disk.
The only path on your local disk is localAssetDirectoryPath.
Looking at the example given in:
https://docs.microsoft.com/en-us/azure/remote-rendering/quickstarts/convert-model
your config should look something like this:
{
	"accountSettings": {
		"arrAccountId": "-",
		"arrAccountKey": "-",
		"region": "eastus2"
	},
	"renderingSessionSettings": {
		"vmSize": "standard",
		"maxLeaseTime": "00:30:00"
	},
	"assetConversionSettings": {
		"resourceGroup": "RemoteRendering",
		"storageAccountName": "remoterendertest",
		"blobInputContainerName": "arrinput",
		"blobOutputContainerName": "arroutput",
		"localAssetDirectoryPath": "D:\\AzureRemoteRendering\\azure-remote-rendering\\Unity\\Quickstart\\Assets\\Arena_Optimised_CutInHalf",
		"inputFolderPath": "Arena_Optimised_CutInHalf",
		"inputAssetPath": "Arena_Optimised_CutInHalf.FBX",
		"outputFolderPath": "Arena_Optimised_CutInHalf_Output"
	}
}

This will:

upload the contents of your local directory "D:\AzureRemoteRendering\azure-remote-rendering\Unity\Quickstart\Assets\Arena_Optimised_CutInHalf" to your blob container "arrinput" under a path of "Arena_Optimised_CutInHalf"
Look for a model  inside this path called "Arena_Optimised_CutInHalf.FBX" to convert
If conversion suceeds output a model into the output container "arroutput" under a path of "Arena_Optimised_CutInHalf_Output"
i removed the outputAssetFileName param and the service will deduce the output file name

Ah okay I was confused because the script appears to already start uploading, but I am not sure what that is meant for then. I manually created the folder and now it does not give me the path errors anymore.
Thank you for the help.

With no additional command line parameters the script will always upload the files from the localAssetDirectoryPath - if you do not want this you can look at how to run individual stages of the script https://docs.microsoft.com/en-us/azure/remote-rendering/samples/powershell-example-scripts#run-the-individual-conversion-stages
I also recommend to look at the source of the script and see how it is calling the REST API for conversions and rendering sessions
If the issue has been resolved for you can you close the issue?

Mh yes, seems like I was a little bit too hasty. It now appears to keep adding the path to folder it tries to read from? I already restarted powershell as I thought it was caching the previous configuration.
I have a folder named Arena_Optimised_CutInHalf and the config is the same as the one you posted.
The stderr contains:
Error: ERROR: Failed to load file: Unable to open file "Arena_Optimised_CutInHalf/Arena_Optimised_CutInHalf/Arena_Optimised_CutInHalf.FBX".

can you provide the used arrconfig.json please?

Yeah I have no idea what is going on here the input path is set as Arena_Optimised_CutInHalf but just appears as Arena_Optimised_CutInHalf/Arena_Optimised_CutInHalf/Arena_Optimised_CutInHalf every time.


$id begning with # causes panic

Hi,
We use https://www.jsonschema.net/ as an interactive tool to generate JSON schemas, its very productive especially for non technical team members.
One of our team members configured the system to use following schema:
{
    "definitions": {},
    "$schema": "http://json-schema.org/draft-07/schema#",
    "$id": "http://example.com/root.json",
    "type": "object",
    "title": "The Root Schema",
    "required": [
      "firstName",
      "lastName",
      "username"
    ],
    "properties": {
      "firstName": {
        "$id": "#/properties/firstName",
        "type": "string",
        "title": "The Firstname Schema",
        "default": "",
        "examples": [
          "Amit"
        ],
        "minLength": 2,
        "pattern": "^(.*)$"
      },
      "lastName": {
        "$id": "#/properties/lastName",
        "type": "string",
        "title": "The Lastname Schema",
        "default": "",
        "examples": [
          "Dave"
        ],
        "pattern": "^(.*)$"
      },
      "avatar": {
        "$id": "#/properties/avatar",
        "type": "string",
        "title": "The profile picture",
        "description": "The picture is used at multiple places in the frontend",
        "default": "",
        "examples": [
          "https://lh3.googleusercontent.com/-bI-uHAaXyKk/AAAAAAAAAAI/AAAAAAAAAAA/ACHi3rdOVryMbEIxiHnO81R8gvWjJeQ33A/s32-c-mo/photo.jpg"
        ],
        "pattern": "^(.*)$",
        "format": "uri"
      },
      "username": {
        "$id": "#/properties/username",
        "type": "string",
        "title": "The Username Schema",
        "default": "",
        "examples": [
          "root"
        ],
        "pattern": "^(.*)$"
      }
    }
  }

Everything seems okay with it, but still when the system tried to Unmarshal above mentioned schema to RootSchema program would exit with a panic panic: runtime error: slice bounds out of range.
So I started investigating the issue and I found that following was causing the issue
link to code
				// For the record, I think this is rediculous.
				if u, err := url.Parse(sch.ID); err == nil {
					ids[u.Path[1:]] = sch
				}

especially the line ids[u.Path[1:]] = sch. Though url.Parse is able to parse relative paths without hostname and protocol, if the relative path started with #, i.e. #/properties/firstName, the desired path will be present in Fragment and Path will be empty hence while trying to slice an empty path from 1: causes the panic.
I was able to resolve this by replacing above code with following:
				// For the record, I think this is ridiculous.
				if u, err := url.Parse(sch.ID); err == nil {
					// This is if the identifier is defined as a reference (with #)
					// i.e. #/properties/firstName
					// in this case, u.Fragment will have /properties/firstName
					if strings.HasPrefix(sch.ID, "#") {
						ids[u.Fragment[1:]] = sch
					} else {
						ids[u.Path[1:]] = sch
					}
				}

This fix is already present in my clone here
If you feel that this fix is an appropriate fix, I'd be more then happy to submit a PR. If not, please provide some feedback.
Thanks.
PS: Love this lib for its simplicity.

Thanks so much for your PR @daveamit, and for the clear feedback in this issue. Now that your PR is merged, would you mind checking if this fixes the issue your team member was facing, and if so close this issue?

@b5 thanks for accepting the PR, I can confirm that the issue my team was facing has been resolved.


feat(pixels): add my new pixel (23, 0)

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

done

done


[HTTP Option support] Add HTTPOption into Kingress spec

This is the first part of the httpOption support work. We need to add httpOption into Kingress spec.
Full design: https://docs.google.com/document/d/1yVOGo-j1hI7oCpuWVIi5iBJwX1wKbOzWaV0QNJxCbaY

/assign

/reopen

@ZhiminXiang so how do we take this forward? What was the issue with previous PR?

@arghya88 sorry for not making it clear in the code review of the previous PR.
So there are several issues:

We should not add the default value for httpOption (i.e. this section) as it will break the downgrade (i.e. the httpOption cannot be parsed after downgrading knative networking as the downgraded version does not know about httpOption). If it is empty, then we just leave it as it is.
Accordingly, we cannot add Validate for this field like this. Maybe we just completely drop the Validate function.
We should drop the "Disabled" I think as it will involve the problem about how to handle HTTP01 challenge https://github.com/knative/networking/pull/306/files#r544360203. (Sorry about back-and-forth for this part).

Would you mind modifying the PR?

@ZhiminXiang Yes I will modify the PR accordingly


Make docarray explicit dep

Poetry is not working for me. Instead I'm using the usual requirements.txt file.


feature: lesscode 内置项目支持，且页面不可见

Codecov Report

Merging #696 (547860a) into v2.6.x_develop (1e43c90) will increase coverage by 0.02%.
The diff coverage is 81.48%.

@@                Coverage Diff                 @@
##           v2.6.x_develop     #696      +/-   ##
==================================================
+ Coverage           61.87%   61.89%   +0.02%
==================================================
  Files                 441      441
  Lines               28003    28074      +71
==================================================
+ Hits                17327    17377      +50
- Misses              10676    10697      +21

Impacted Files
Coverage Δ

itsm/project/apps.py
80.95% <62.50%> (-6.55%)
:arrow_down:

itsm/project/models/project.py
87.50% <87.50%> (ø)

itsm/component/constants/builtin.py
100.00% <100.00%> (ø)

itsm/project/views.py
62.83% <100.00%> (+0.33%)
:arrow_up:

itsm/openapi/ticket/serializers.py
78.30% <0.00%> (-1.58%)
:arrow_down:

itsm/trigger/views.py
63.82% <0.00%> (-0.50%)
:arrow_down:

itsm/openapi/ticket/views.py
45.85% <0.00%> (-0.22%)
:arrow_down:

itsm/ticket/models/ticket.py
55.51% <0.00%> (-0.20%)
:arrow_down:

itsm/component/notify.py
46.51% <0.00%> (ø)

itsm/trigger/models/action.py
46.55% <0.00%> (+0.06%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e43c90...547860a. Read the comment docs.


ammending procfile to capture logs

Per slack conversation on 1/8 #RackHD, debugging Pasu's issues
really needed to see the logs - and what was missing from them,
so I thought it might be beneficial to capture them in the procfile
setup on a per-run basis, hence this update.

ahhhh! damnit - will fix unintended submodule updates

:+1:

:+1:


white_check_markwhite_check_mark

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

js version: 16, 14, 12

Enforcement Responsibilities

files.exclude


Preserve block indentation when commenting

This change allows the comment keyboard shortcut to be used to comment out lines of a recipe without requiring a manual fixup afterwards. Without this change, the pound sign # gets introduced at the start of the line, which confuses the Just parser if there are additional recipe lines after the commented-out line.

Great spot, thank you!


chore: start with data store workspace id and fetch plugins info

Description
This PR stores the workspaceId in appropriate redux state for start with data, and it also fetches list of plugins which are required to show list of datasources during onboarding.
Workspace id is further required to fetch plugins, test and save the datasource
PR fixes following issue(s)
Fixes #28730
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[x] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test


Add Claude LLM option

Add Anthropic Claude models: Haiku, Sonnet, and Opus.
Chat and tool usage

API key configuration

Thank you very much for your contribution to the access implementation of the claude model. In the new version, I changed the supported models from hard-coded to obtained from the llm api.


Treemap legend boxes disappear

I believe this issue has been fixed with the last couple of minor releases. If not, please post a jsfiddle showing the error.


Authentication examples

Hi,
Thanks for the V2 API implementation!
I have checked examples provided, but I can't find the whole process that includes authentication (including getting the access token - with and without redirection to paste the token back into app asking for access). Am I missing something?
Milan

Hi.
The SDK does not cover authentication and only acts as a wrapper for API calls. The authentication workflow is fairly simple - essentially make a link to your app's authorisation URL and, when the user is redirected back to your site, store the token for future use.

Thanks!


Compile error on Windows

Getting this both with GO111MODULE set to on and off
C:\Users\***>set "GO111MODULE=off"

C:\Users\***>go get -u -v github.com/haya14busa/goplay/cmd/goplay
github.com/haya14busa/goplay (download)
github.com/skratchdot/open-golang (download)
github.com/skratchdot/open-golang/open
# github.com/skratchdot/open-golang/open
go\src\github.com\skratchdot\open-golang\open\exec_windows.go:10:2: imported and not used: "syscall"

C:\Users\***>set "GO111MODULE=on"

C:\Users\***>go get -u -v github.com/haya14busa/goplay/cmd/goplay
go: finding github.com/haya14busa/goplay/cmd/goplay latest
go: finding github.com/haya14busa/goplay/cmd latest
go: finding github.com/skratchdot/open-golang/open latest
go: finding github.com/skratchdot/open-golang latest
github.com/skratchdot/open-golang/open
# github.com/skratchdot/open-golang/open
go\pkg\mod\github.com\skratchdot\open-golang@v0.0.0-20190331143844-1a48294fa5dd\open\exec_windows.go:10:2: imported and not used: "syscall"

Closed in https://github.com/skratchdot/open-golang/issues/21


Please ban Melong Temporary email mmomekong

Saw one user abusing this temp service from Vietnam. They have a list of domains on the website, so prob a scraper should be good to keep the list updated.

implemented. thanks for that submission! those domains will appear tomorrow

Thanks!

@ferreiro lol they bought this service: https://codecanyon.net/item/tmail-multi-domain-temporary-email-system/20177819

Lol! So they bought that service and use their own email domain? That’s
hilarious, how did you notice that? These guys keep surprising!
On Tue, 6 Dec 2022 at 00:47, Daniel @.***> wrote:

@ferreiro https://github.com/ferreiro lol they bought this service:
https://codecanyon.net/item/tmail-multi-domain-temporary-email-system/20177819
—
Reply to this email directly, view it on GitHub
https://github.com/7c/fakefilter/issues/38#issuecomment-1338374286, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXIJT3AJ4GVQ5FN4AEXUX3WLZ5JLANCNFSM6AAAAAASPOG2MQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
⎯⎯⎯⎯
*Jorge Ferreiro *
Programmer, Entrepreneur, Digital Nomad.
☕  Virtual Coffee with me? virtualcup.io/jorge
https://www.virtualcup.io/jorge
🌍  Website: jorgeferreiro.com
http://jorgeferreiro.com


Replace keys_one by Array() call

(Not tested, contribution on the fly) Array(o) return o if o is already an Array and [o] otherwise.

specs failing for serialized attributes.


Filtered logging to file to support logging for every long time

The logfile now contains all (unfiltered) messages, but when running for very long periods of time, it might useful to only log the filtered messages

related to #163


The token you provided is invalid

Hi ,
I upload CSV via API but failed and received a message
{     "message": "The token you provided is invalid" }
i created API key follow the instruction - https://jtlreporter.site/docs/guides/administration/api-token and and upload file via API in postman - https://jtlreporter.site/docs/guides/api-data-upload.
Tried to get the token in web it work :).
thanks for your support

Hi @tuyenlq, did you use the token generated here https://jtlreporter.site/docs/guides/administration/api-token or the one returned from /api/auth/login-with-token ? Because the latter (JWT) token wont work in this case, it serves as auth token for listener-service.

Hi @ludeknovy.
Looks like I followed the instructions wrong, i used token return from /api/auth/login-with-token :) to be exact is to use token generated in https://jtlreporter.site/docs/guides/administration/api-token
Thank you so much!


Firestore implement/document emulator support

@dmitry-s shall we expect something like LocalDatastoreHelper from https://github.com/googleapis/google-cloud-java?

Wondering if the test in the sample is using the real database.

@p595285902 Yes it does. Are you looking for instructions on how to run it with an emulator?

Yeah, or something guide on how to run my end to end tests without impacting the real data. Was thinking if I need set the spring.cloud.gcp.firestore.project-id to a test only project.

You can definitely set a different project id for the tests, until we add the emulator support/documentation.


Confusing links in readme

“MNIST-pytorch” and "MNIST-tensorflow" in Readme leads to "distributed training" example, this is confusing for new users

Pr#1522 fixed this issue


Application Integration Monte Carlo

[ ] Write download and build script (figure out dependencies, compile)
[ ] Execute the workload with and without GEOPM on the command line
[ ] Create AppConfig python object which captures the steps to run an application
[ ] Determine how to obtain the figure of merit and parse after run
[ ] Verify optimal configuration by confirming figure of merit and settings used with application expert.
[ ] Insert barriers in front of all collective calls for build of special binary that can be selected with AppConfig as was done for nekbone
[ ] Insert epoch call in outer loop
[ ] Add a run script for each experiment and execute them on two nodes and run at least two trials
[ ] Add a configuration for 8 - 12 nodes and collect data from those runs (night-time runs preferred sbatch --begin=20:00 for post 8 PM PDT start time), if GPU workload, one node only required.

Won't do


Uncaught TypeError: tc.querySelector(...) is null

Uncaught TypeError: tc.querySelector(...) is null
    <anonymous> http://<IP_ADDRESS>:5500/js/main.js:23
    <anonymous> http://<IP_ADDRESS>:5500/js/main.js:12
    EventListener.handleEvent* http://<IP_ADDRESS>:5500/js/main.js:1
main.js:23:30
    <anonymous> http://<IP_ADDRESS>:5500/js/main.js:23
    forEach self-hosted:203
    <anonymous> http://<IP_ADDRESS>:5500/js/main.js:12
    (Async: EventListener.handleEvent)
    <anonymous> http://<IP_ADDRESS>:5500/js/main.js:1

https://github.com/VAggrippino/todo_core/blob/66dbdd1f3a7ba0019b99bc4e0dc22ceaeda38b4e/js/main.js#L23
list.type becomes either ol or ul.
Although .list ol and .list ul are definitely both present in the template content, the ol element is empty. It seemed redundant to put a list item there that was identical to the one in the ul, but this may be causing or related to the problem.

This only seems to happen when refreshing after adding a new list.

Fixed by 1e2417a


Update get-networkcontrolleraccesscontrollist.md

Added example and modified some content for the cmdlet

@AnirbanPaul,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


The back button brings you back to the channel configurator even if the order has been successfullly executed.

The back button doesn't really make sense when the order got executed.
https://github.com/get10101/10101/assets/382048/eb8d3cd9-ea98-49e4-a03b-3ac821f15e04

@bonomat @luckysori @SXBT69 How about automatically navigating to the trade screen when the order got executed successfully?

@bonomat @luckysori @SXBT69 How about automatically navigating to the trade screen when the order got executed successfully?

I wanted to navigate to the trade screen when clicking on the button in the confirmation dialog, but I failed doing so.


Syntax error in src/lib/libDefs.js

The changes in src/lib/libDefs.js in commit #d9339f8 breaks the build of cli for me.
Error output:
SyntaxError: src/lib/libDefs.js: Unexpected token (19:22)
  17 | const P = Promise;
  18 |
> 19 | export type LibDef = {|
     |                       ^
  20 |   pkgName: string,
  21 |   pkgVersionStr: string,
  22 |   flowVersion: Version,

Diff:
diff --git a/cli/src/lib/libDefs.js b/cli/src/lib/libDefs.js
index 4941642..29cff96 100644
--- a/cli/src/lib/libDefs.js
+++ b/cli/src/lib/libDefs.js
@@ -16,14 +16,14 @@ import type {Version} from "./semver.js";

 const P = Promise;

-export type LibDef = {
+export type LibDef = {|
   pkgName: string,
   pkgVersionStr: string,
   flowVersion: Version,
   flowVersionStr: string,
   path: string,
   testFilePaths: Array<string>,
-};
+|};

Tested on Mac OS 10.11.6. Using Node 4.6.0 and Node 6.7.0.
What does this {| syntax mean? I couln'd find any information about it.

It's new Flow "exact type" syntax (we haven't announced it yet but it's ready for use).
Try deleting your node_modules directory and re-npm install-ing. It requires the latest version of Babel.
Exact types are just object types that have exactly the properties specified (no less and no more). Normal objects support subtyping, so they only guaratee that they have at least the properties specified (but they may also have more). There are some benefits of using exact types when they're appropriate like guaranteeing that property typos get caught.
Please re-open if you still have issues after npm installing

Aah, thank you very much! That worked!


Empty release changelog

I have introduced the action heinrichreimer/action-github-changelog-generator prior to release v0.4.1 (See bf64bed). However, the action did not create a changelog and the body of the release page was empty.

This seems to be the cause: heinrichreimer/action-github-changelog-generator#23

This seems to be the cause: heinrichreimer/action-github-changelog-generator#23


Update CI GHA workflow to use reusable components

This updates the CI workflow to use the individual reusable workflows from govuk-infrastructure, instead of using inputs to skip steps. This allows workflows to be less noisey with steps that aren't relevant for a particular app. Also allows more flexiblity in configuration, as extra jobs can easily be added directly without modifying a shared workflow.

Hey @theseanything this stuff looks cool. What's the scope of this work? Is this intended to be a full future CI configuration or is this experimenting?
I wondered at what point would be good to feedback on things? I have a few thoughts but didn't know what stage you were at?

Hey @theseanything this stuff looks cool. What's the scope of this work? Is this intended to be a full future CI configuration or is this experimenting?
I wondered at what point would be good to feedback on things? I have a few thoughts but didn't know what stage you were at?

Hey @kevindew - currently on working implementing CI in GHA for the publishing apps.  Any feedback you have would be great, so feel free to leave comments!

Hey @theseanything this stuff looks cool. What's the scope of this work? Is this intended to be a full future CI configuration or is this experimenting?
I wondered at what point would be good to feedback on things? I have a few thoughts but didn't know what stage you were at?

Hey @kevindew - currently on working implementing CI in GHA for the publishing apps. Any feedback you have would be great, so feel free to leave comments!

Great stuff, ok let's see feedback wise.
So it'd be good to involve people in the teams a bit more than previous, I think people were quite blindsided by the initial introduction of the Whitehall GHA CI, so seeking more input or informing of changes and why could be useful for the code owners.
At a fundamental level, I feel that perhaps the drive to have heavy re-use is potentially adds more complexity than it saves. GHA files are generally low on the amount of config needed to achieve an action and the re-use patterns are rather rigid with low flexibility. I do somewhat wonder if life would be simpler starting from a place without re-use (as per: https://docs.publishing.service.gov.uk/manual/test-and-build-a-project-with-github-actions.html#gov-uk-rails-application-with-postgres-redis-yarn-and-gov-uk-content-schemas-dependencies) and then see where the pain points appear to embrace re-use. Not that I don't see any advantages to re-use but do worry it'll cause my headaches than it solves.

On the embracing re-use front, if we do go down that path, I feel like it could be better to have one generic action that can run an app task rather than lots of specific ones. For example, the test ruby one, made a bit more generic could be used for a few scenarios with a bit of tweaking:
  app-js-test:
    name: Javascript Tests
    needs: cache-dependencies
    uses: alphagov/govuk-infrastructure/.github/workflows/ci-govuk-ruby-app-task.yaml@main
    with:
      task: bundle exec jasmine:ci

  app-test:
    name: Minitest
    needs: cache-dependencies
    uses: alphagov/govuk-infrastructure/.github/workflows/ci-govuk-ruby-app-task.yaml@main
    with:
      enableMySQL: true
      enableRedis: true
      setup: bundle exec rails db:reset
      task: bundle exec test

  app-cucumber:
    name: Cucumber
    needs: cache-dependencies
    uses: alphagov/govuk-infrastructure/.github/workflows/ci-govuk-ruby-app-task.yaml@main
    with:
      enableMySQL: true
      enableRedis: true
      setup: bundle exec rails db:reset
      task: bundle exec cucumber

and could imagine you could use that to also cover most of the other tasks with that one task (it'd also mean we could have the pact-verify action use it too.

It'd be good to have a think about how things with fit with the govuk-saas-config that sets up the required jobs checks. At the moment all of the replatforming GHA test repos files have been exepmpt as they use ci.yaml rather than the convention of ci.yml which I assume was unintentional. I'd guess we'd want a way to specify which jobs are required if we go down the multiple task routes. I'd guess we could do the same thing we do in gems of having a test action that GitHub requires which requires other jobs to pass though it's a bit clunky.

Another area that I think would be good looked at, especially in the case of Whitehall is utilising a different test runner so we can try keep the performance the same or better than Jenkins with more CPUs. I imagine we'd have some set-up faff getting a runner set-up (I don't have the access to turn one on myself) but I imagine that's where we could really save some time and would be good that a design can utilise them.

Then on the more more minor side a few things come to mind:

We're missing cucumber from this job
Great to see the env var to set db versions. I'm sure it won't be long until we have some divergence, particularly when we need to update a db
The filenames of the reusable actions seem rather generic for rather specific things that seems like could be hinderance. For example: ci-test-javascript is very much just something for a Ruby app and wouldn't be usable by a Javascript project of ours, ci-test-ruby seems rather GOV.UK Rails specific (is that a search-api concession) - I think they could be clearer in scope
It'd be good to test production asset precompiling, as that catches people out: https://github.com/alphagov/whitehall/pull/7150 - we lost it from Jenkins CI as part of an optimisation and seems to have caught people out a bunch since: https://github.com/alphagov/govuk-jenkinslib/commit/a6d8f52b5951c874c07a5e52750d4303f2972014

Thanks Kevin!

So it'd be good to involve people in the teams a bit more than previous, I think people were quite blindsided by the initial introduction of the Whitehall GHA CI, so seeking more input or informing of changes and why could be useful for the code owners.

Yup. Will do better a job at letting teams know!

At a fundamental level, I feel that perhaps the drive to have heavy re-use is potentially adds more complexity than it saves ….

Whilst I agree there is a little added complexity in re-use, from the experience we’ve had building out the initial CI workflow for frontend apps and implementing the deployment pipeline, the toil involved updating 45~ individuals repos is significantly more time consuming. The re-use is more valuable when rolling out the initial implementation, where tweaks and updates to shared logic are more common (e.g. backing service configuration, dependency versions, job configuration etc…). Tho this shouldn’t prevent us from switching to individual configuration in future.
Thanks for pointing out those dev docs - will add a reminder to make sure we keep them up to date and make sure we’re consistent in what we actually do vs what’s written down.

On the embracing re-use front, if we do go down that path, I feel like it could be better to have one generic action that can run an app task rather than lots of specific ones …

Good suggestion about the generic app task job. Still investigating how varied our app jobs are - currently considering GitHub’s composite actions to capture some of the shared logic like configuring backing services. Could remove the need for re-usable workflows altogether and bring back that type flexibility in configuration.  - https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

It'd be good to have a think about how things with fit with the govuk-saas-config that sets up the required jobs checks …

Thanks for heads up on govuk-saas-config, didn’t know it configured the required checks. For right now, we probably don’t want make these CI jobs (in GHA) required checks - as they’re only used for the EKS platform, and we don’t want to get in the way of the existing development process during implementation. But we’ve got a note make sure they’re eventually required.

Another area that I think would be good looked at, especially in the case of Whitehall is utilising a different test runner so we can try keep the performance the same or better than Jenkins with more CPUs …

Yup - we’ve got a goal to make CI tests in GHA at least as fast as our existing infra and conscious that Whitehall tests are slower right now. Larger test runners is one of the possible solutions, something will come back too after the initial implementation.

We're missing cucumber from this job

Yup - on the todo list.

Great to see the env var to set db versions …

Yup - on the iteration todo list

The filenames of the reusable actions seem rather generic for rather specific things that seems like could be hinderance …

Yup agree - will have a look at better naming

It'd be good to test production asset precompiling …

We currently precompile the assets during image build - so at the moment, we have some safety from trying deploy a release where it doesn’t work. But yup on the iteration todo list.

This is excellent work, this will help us identify exactly where things are failing.

Thanks Sean.

Whilst I agree there is a little added complexity in re-use, from the experience we’ve had building out the initial CI workflow for frontend apps and implementing the deployment pipeline, the toil involved updating 45~ individuals repos is significantly more time consuming. The re-use is more valuable when rolling out the initial implementation, where tweaks and updates to shared logic are more common (e.g. backing service configuration, dependency versions, job configuration etc…). Tho this shouldn’t prevent us from switching to individual configuration in future.

Sure, it has certainly looked painful when you've had to update all the deploy workflows. On the other hand, with the gems we've had some of the individual workflows for years without much toil - so I imagine it might not be as bad as you fear. I do think this approach you've taken for re-use seems better than the previous iteration as it offers some escape routes of rolling own actions for more bespoke app needs.
The other thing I wonder about is what the plan for ownership of these are? It doesn't seem ideal to me that Replatforming are implementing these (aside from a consistency benefit) as they're not the team that'll have to deal with any challenges/longer term maintenance. Is the plan that replatforming will hand over ownership to teams or would it be considered the teams from the point of merging?

Good suggestion about the generic app task job. Still investigating how varied our app jobs are - currently considering GitHub’s composite actions to capture some of the shared logic like configuring backing services. Could remove the need for re-usable workflows altogether and bring back that type flexibility in configuration. - https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

Yup, composite actions sound pretty neat. 👍
It seems such a pain how you can't seem to share services easily as they seem the most verbose part of actions overall.

It'd be good to have a think about how things with fit with the govuk-saas-config that sets up the required jobs checks …

Thanks for heads up on govuk-saas-config, didn’t know it configured the required checks. For right now, we probably don’t want make these CI jobs (in GHA) required checks - as they’re only used for the EKS platform, and we don’t want to get in the way of the existing development process during implementation. But we’ve got a note make sure they’re eventually required.

Yeah, I assumed you didn't want them required but probably hadn't realised it was only down to a file extension spelling. It's annoying that the world hasn't agreed on yaml or yml.

It'd be good to test production asset precompiling …

We currently precompile the assets during image build - so at the moment, we have some safety from trying deploy a release where it doesn’t work. But yup on the iteration todo list.

Yeah that was how @dnkrj found out the failure of the build I referenced - which is kinda the same boat with Jenkins where it fails on deploy. It'd be good to catch them pre-merge, it's a shame we lost that from our Jenkins CI - I guess we used to have it lingering until only recently when we used to build docker images in Jenkins CI for e2e tests.

The other thing I wonder about is what the plan for ownership of these are? ...

Ownership will probably eventually fall back to teams? (unclear what GOV.UK's long term intention is for who supports infra/dev tooling/processes)  - but at the very least don't think teams should need to feel fully responsible before we migrate to EKS. We absolutely do not want to be building something, then immediately dump the maintenance burden onto teams and give zero support.
For right now, Replatforming needs a CI/CD pipeline as part of building out the infrastructure. We definitely don't want to be obstructing teams' current development processes and existing work, and we have no plans for changing the existing Jenkins CI/CD process. Realistically having Replatforming set up an initial working CI pipeline for all the applications will be far quicker than putting the onus on each team to do (they have their own priorities and might not yet have the knowledge to do so). Having said that, we don't want to exclude teams from this process - should be part of communicating the changes and allowing opportunity to give input. Replatforming do plan on providing support and training for teams as we migrate towards EKS, including the CI/CD processes.

It seems such a pain how you can't seem to share services easily as they seem the most verbose part of actions overall.

Yeah absolutely - tho they're essentially a neat way of spinning up a container. Which composite action might be a good replacement to allow reusability.

Yeah, I assumed you didn't want them required but probably hadn't realised it was only down to a file extension spelling. It's annoying that the world hasn't agreed on yaml or yml.

Ahah yah, defo a fluke that we weren't caught out by sass config!

Great thanks @theseanything all sounds positive.
With regards to ownership:

Ownership will probably eventually fall back to teams? (unclear what GOV.UK's long term intention is for who supports infra/dev tooling/processes)

The direction we're aiming towards is ownership boundaries are defined by repositories (with hopefully minimal cases of multiple teams working in same repository). So how'd that pan out with things like this is that Publishing Experience own the actions in this repo, which may utilise workflows part of by govuk-infrastructure (and therefore owned by Platform Reliabality) - they offer something of a public API to services govuk-infrastructure look after. So teams would fulfil a similar model to an open source project maintainer role.

Closed in favour of https://github.com/alphagov/whitehall/pull/7197


Submit Ontoneo to Obo-discuss

Submit Ontoneo registry to Obo-discuss list evaluation.

Submitted to OBOFoundry/OBOFoundry.github.io by the issue "OntoNeo prefix request #334"


Negative numbers in countdown

During the hour after the event start-moment, and after the finish-moment, the front page counter is in a strange state, with negative numbers. This may also be due to an incorrectly (or inconveniently) configured end-date. See if the JS component could be improved in this.

This should be revisited with changes in https://github.com/loleg/dribdat/pull/1

This has been fixed with #253


Moved the exception for angular units being surveyor units

I encountered a DXF with the setting, but no angular measurements (or at least I wasn't writing a DXF). I wanted to be able to read it, so I moved the exception from DimensionStyle.DimAngularUnits to DimensionBlock.FormatDimensionText. It could be done with a setting, but this way seemed cleanest. Please let me know if you'd like a different approach.

The root of the problem is that you cannot define the angular units as "Surveyor Units" for a dimension style, there is no option for that in the AutoCad UI; and, although, that option is available in its equivalent DIMAUNIT according to the official DXF documentation for the header variables. In the AutoCad reference documentation that option is nowhere to be found but you can change that value through the command line. So, who to trust.
In any case you cannot use surveyor units to create angular dimensions, so my only suggestion is to change that value to the default Decimal Degrees when reading the dimension styles, or perhaps to Degrees, Minutes, and Seconds; since it is closet thing to the surveyor units description shown in the documentation for the AUNITS system variable.

I agree that it's a problem that Surveyor Units got in there, and that there's probably no option in the AutoCad UI. Yet somehow this file had it selected. I am unsure how to do that when calling public static DxfDocument Load(string file, IEnumerable<string> supportFolders) with a file given by a customer. I'd really like to be able to read the rest of the file, so would you please reconsider or suggest an alternative?


[Nox.Ui] Agree YAML settings for Config, Search and Results within Cryptocash sample Ui project(s)

Need to agree how to add following example config to design YAML:
{
  "AzureAd": {
    "Instance": "https://login.microsoftonline.com/",
    "Domain": "ENTER DOMAIN HERE",
    "TenantId": "ENTER TENANTID HERE",
    "ClientId": "ENTER CLIENTID HERE",
    "CallbackPath": "/signin-oidc",
    "SignedOutCallbackPath": "/signout-callback-oidc"
  },
  "ApiUiService": [
    {
      "Name": "Currencies",
      "PageLink": "Currencies",
      "IsDefault": true,
      "Url": "https://localhost:ENTER PORT HERE/api/Currencies",
      "Icon": "<path d=\"M0 0h24v24H0V0z\" fill=\"none\"/><path d=\"M11.8 10.9c-2.27-.59-3-1.2-3-2.15 0-1.09 1.01-1.85 2.7-1.85 1.42 0 2.13.54 2.39 <IP_ADDRESS>.<IP_ADDRESS>h.3c.66 0 1.13-.65.9-1.27-.42-1.18-1.4-2.16-2.96-2.54V4.5c0-.83-.67-1.5-1.5-1.5S10 3.67 10 4.5v.66c-1.94.42-3.5 1.68-3.5 3.61 0 2.31 1.91 3.46 4.7 4.13 2.5.6 3 1.48 3 2.41 0 .69-.49 1.79-2.7 1.79-1.65 0-2.5-.59-2.83-1.43-.15-.39-.49-.67-.9-.67h-.28c-.67 0-1.14.68-.89 1.3.57 1.39 1.9 2.21 3.4 2.53v.67c0 .83.67 1.5 1.5 1.5s1.5-.67 1.5-1.5v-.65c1.95-.37 3.5-1.5 3.5-3.55 0-2.84-2.43-3.81-4.7-4.4z\"/>"
    }
  ]
}

Also need to discuss and agree how these settings for each entity property are set in design YAML to enable search, filter, order etc on entity properties
Nox.UiApiDashboard Filters.xlsx

@rochar we probably need a workshop on this - with YAML experts @

From Meeting 16/Aug/23 agreed the following for AzureAd Auth Nox.Generator config:
AzureAuth = Infrastructure.Security.ApplicationIdentity
infrastructure:
security:
userIdentity:
provider: AzureAd
azureAdOptions:
instance: https://login.microsoftonline.com
domain: xxx
tenantId: xxx
clientId: xxx
callBackPath: /signin-oidc
signedOutCallBackPath: /signout-callback-oidc
job1: update Nox.Solution support & validate settings - see NoxSimpleTypeDefinition = expects instance, domain etc - validation

List of App Api config:
Infrastructure.EndPoints.ApiServer
config switch - read api to get - non-owned entities include agg roots / standalone entity = referred to as main entities - show all these on ui nav links
phase2 - exclusions - set in EntityPersistence like create, update etc
Check - odata No.Entity links? builds querystring urls for Odata

Also agreed:
TypeUserInterface new Ui hints for Cryptocash.Ui datagrid search results
//showInSearchResults - always, optionalOn, optionalOff, never (defaultValue = optionalOn)

//canSort - yes, no, default (defaultValue = no)

//canSearch - yes, no (defaultValue = no)

//canFilter - yes, no (defaultValue = if 'Id, Name' then yes)

//showOnAddForm - yes, no (defaultValue = yes for all except database generated keys and guids)

//showOnEditForm - yes, no (defaultValue = yes)


[Ubuntu] Alpine 3.14 & 3.15 docker image will be removed on July, 24

Breaking changes
We are going to remove alpine:3.14 and alpine:3.15 docker image from the list of pre-cached images on VM.
Target date
Image deployment will start July, 24 and will take 3-4 days.
The motivation for the changes
According to our Software and images support policy we support not more than 3 latest LTS versions of images.
Possible impact
If your pipelines depend on any of these images they may become slower due to time needed to download images in runtime.
Platforms affected

[X] Azure DevOps
[X] GitHub Actions

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Mitigation ways
Nothing is required — if there is no local image docker will pull it automatically from the docker hub.

rolled out

node-version: 16
always-auth: false
check-latest: false
token: ***


158 update adlerpy

Fixes #158. Also integrates changes from #119 which implement colour finding functions (currently PR #154).
I have added diaSourceId to the AdlerPlanetoid observations sql query, this is to make sure we have a unique identifier for each obs.
Review Checklist for Source Code Changes

[ ] Does pip install still work?
[ ] Have you written a unit test for any new functions?
[ ] Do all the units tests run successfully?
[ ] Does adler run successfully on a test set of input files/databases?
[ ] Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt looks like I've fixed the unit test issue, I just saved the test dataframes with the diaSourceId column as int64. So this is ready to review, there is just that annoying linting issue which you said we could maybe just ignore?


a13 15.7.2

I'm on iPhone SE 2020, iOS 15.7.2 (I know this version haven't been released officially for this phone, installed via OTA + Some other things, don't remember). Trollstore doesn't install via TrollinstallerX. It says:
Running on an iPhone12,8 on iOS 15.7.2
Downloading kernel
libgrabkerne12: ERROR: Failed to find a firmware URL!
libgrabkerne12: ERROR: Failed to get a firmware URL!
Failed to download kernel
Failed to get kernel
I tried to reboot by phone, clear cached kernel, landa-physpuppet - didn't help, unfortunately.

My apologies, please test [this IPA}(https://www.swisstransfer.com/d/3068fc5f-c5c7-491c-99c9-cf43591c92d8) and let me know whether it can download the kernel correctly.

My apologies, ~please test this IPA~ and let me know whether it can download the kernel correctly.
Edit: use this one instead.

Hello, it stucks on "Downloading kernel" (tried landa and physpuppet)

The fact that it fails to fetch the API data is unlikely to be related to TrollInstallerX. Are you able to download https://api.appledb.dev/ios/main.json.xz in Safari?

The fact that it fails to fetch the API data is unlikely to be related to TrollInstallerX. Are you able to download https://api.appledb.dev/ios/main.json.xz in Safari?

When i paste it, I receive a notification: "Do you want to download "main.json.xz"?". Press download - and it downloads it

Have you changed networks at all since trying TrollInstallerX? Could you try again?

Have you changed networks at all since trying TrollInstallerX? Could you try using it again?

Yes, I've tried different networks and vpns, same issue
Could you add verbose log, to see what's going on? So I will send you it
"Failed to fetch api" happened, because my vpn went down

I don't believe this is an issue with TrollInstallerX. There isn't really much more logging I can add, but when I changed libgrabkernel2 to think it is running iOS 15.7.2 (on iPhone12,8) it was able to download the kernelcache without issue.

我不认为这是 TrollInstallerX 的问题。我真的没有更多可以添加的日志记录，但是当我更改 libgrabkernel2 以认为该设备运行的是 iOS 15.7.2（它也是 iPhone12,8）时，它能够毫无问题地下载 kernelcache。

Running on an ipad8.10（A12Z） on ios 15.7.2 ----- The kernel was successfully downloaded
Running on an iphone11.2（A12） on ios 15.7.2 ----- got “Downloading kernel”


Start migration subdirectories at multiples of 50

Make the database migration subdirectories start at multiples of 50 rather than at
multiples of 50 plus one. It's a little more intuitive if, e.g., migration 100 is
in the same directory as migration 101.
No changes to the contents of any migrations here, just renaming the directories
and moving the multiple-of-50-numbered migrations to their new homes.

Current dependencies on/for this PR:

main

PR #1197

PR #1198   👈

PR #1199

This comment was auto-generated by Graphite.

@sgrimm started a stack merge that includes this pull request via Graphite.

Graphite rebased this pull request as part of a merge.

@sgrimm merged this pull request with Graphite.


Injecting error deletes value on change

Whenever I use a $broadcast with schemaForm.error.:
$scope.$broadcast('schemaForm.error.name','usernameAlreadyTaken','The username is already taken')
The key name in the $scope.model object becomes undefined when I change the value in the input.
However, when I switch the error off with:
$scope.$broadcast('schemaForm.error.name','usernameAlreadyTaken',true)
The error becomes a 'required' error and when I type and change the value in the input, the value is bound again in $scope.model.
Is this a bug or am I using the $broadcast wrong?

#642 is reported as fixing this issue

It doesn't seems this is 100% fixed.
Using the development branch, this is what I do:
if (form.$valid) {
    var data = angular.copy($scope.model);
    $http.post(path, data)
        .then(function(response) {
            console.log(response.data);
        })
        .catch(function(responseError) {
            $scope.$broadcast('schemaForm.error.title', 'rejected', 'The username is already taken');

            var unregister = $scope.$watch('model1.title', function(value, oldValue) {
                if (value != oldValue) { // from now on $scope.model.title will always been undefined
                    unregister();
                    // Reset the error
                    $scope.$broadcast('schemaForm.error.title', 'rejected', true);
                }

            });
        });
}

I'm watching changes in the model field that caused the async validation, and if the value has changed just reset the async validation.
The problem is that (similarly to  @Zundrium) after setting the field 'title' as invalid the $scope.model.title property will always be undefined

@LeonardoGentile in the example you have model1 instead of just model for the watcher, is that how it is in your app or a typo in the example?

That was a typo, I corrected it.
I think that it is an angular default behavior to set the model value as undefined if it is not valid.
I made the previous example work by passing this attribute to the form directive in the html
sf-options="{ formDefaults: { ngModelOptions: { allowInvalid: true } }}"


limit() in filter is not effect in the command get_events_of

Describe the bug
I've simple code like
let filter = Filter::new()
      .kinds(vec![Kind::TextNote, Kind::Repost])
      .limit(limit)
      .until(as_of)
      .hashtags(hashtags),
  };

if let Ok(events) = client
    .get_events_of(vec![filter], Some(Duration::from_secs(15)))
    .await
{
    println!("total events: {}", events.len());
    Ok(events)
} else {
    Err("Get text event failed".into())
}

In the above query, I've set LIMIT = 20 and until(as_of) = Timestamp::now(), but I still received total 23 events instead of 20

Expected behavior
Receive total events match limit() tag
Build environment

Library:nostr-sdk
Language: Rust
Language version: v1.71
Tag/commit: latest
OS+version: macos

Hey, the "issue" is that some of the relay you are querying not have the same events of others. All relays send you at least 20 events, but since relays could have different events from others, the aggregated result could be bigger than limit.
Ex. Query relay A and B asking fro the last 3 events. Relay A return event 1, 2 and 3. Relay B return event 1, 3 and 4. The aggregated result will be 4 events.

I can try to "fix" this when the filter is one, but I can't with multiple ones.

Fixed in nostr-relay-pool v0.29.3
Update it in your Cargo.lock with:
cargo update -p nostr-relay-pool


Adds Welcome and + tab experiments, moves grid out (Chromium docs 5590130)

Docs Build status updates of commit 1db38d7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/experiments-more-tools-button.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/experiments-plus-button.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/experiments-welcome.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/flexbox-hover.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/flexbox-layout.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/flexbox-overlay.msft.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off and merged.


[standby] Add INF2 CI

Add CI for running inference tests on INF2

Merge as some tests can be successfully run (failed ones are due to outdated precompiled artifacts on the hub, will fix them soon).


Add Camera Zoom event doesn't zoom out

Describe your bug here.
The Camera stays static when zoomed until you press a note in 0.5.1 (current stabile build)
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Nothing.

also could you please fix the issue when you can't exit from the game the moment you get an error in lua code (issue for fullscreen players only)

also could you please fix the issue when you can't exit from the game the moment you get an error in lua code (issue for fullscreen players only)

they can't fix that

also could you please fix the issue when you can't exit from the game the moment you get an error in lua code (issue for fullscreen players only)

they can't fix that

what about the Camera zoom though?

The Camera stays static when zoomed until you press a note in 0.5.1 (current stabile build)

im pretty sure this is intentional

The Camera stays static when zoomed until you press a note in 0.5.1 (current stabile build)

im pretty sure this is intentional

what i'm trying to say is that the camera zooms and doesn't zoom out until you press a note.

that's stupid now i have to do it complicated way by making the bf press a note while stunned

Or you can use defaultCamZoom like you're supposed to

lmao no i got ratiod 😭😭


Increase Unit Test Coverage

Current test coverage is low, with overall instruction coverage at 23% and branch coverage at 27%
Intend to increase test coverage to help catch potential issues before release.
Areas to focus on

Controller Layer - (Currently at 5% instruction and 9% branch coverage.) Can focus on testing the UI logic, user actions, and flow control.

Service Layer - (Currently at 0% coverage). Can test functionality, such as functions in ReportGenerator and other core services.

Repository Layer - (Currently at 68% instruction coverage and 33% branch coverage). Ensure CRUD operations are thoroughly tested, especially edge cases and exceptions.

Utility Layer -  (Currently at 52% instruction and 64% branch coverage.)  Improve coverage for helper methods, JSON backup, and notification logic.

Target Coverage Goals

Instruction Coverage : At least 60%
Branch Coverage: At least 50%

Have added AddHabitViewController test and EditHabitViewController tests which has increased Controller Instruction coverage from 5% to 19% and Branch coverage from 9% to 26%

Have added MainControllerTest which has increased Controller Instruction coverage from 19% to 57% and Branch coverage from 26% to 41%
Have added HabitServiceIntegrationTest, HabitServiceTest, and ReportGeneratorTest to significantly increase test coverage. Overall org.habittracker.service package coverage increased from 0% to 90% instruction and 85% branch coverage.
Overall test coverage: 63% Instruction and 53% Branch coverage. Original coverage goals have been achieved.

Issue successfully resolved. I've achieved an overall test coverage of 76%, as shown in the attached coverage report screenshot. I plan to maintain coverage above 70%


Enhanced the Contact Section

Description
Enhanced the contact secction by making the the form and contact elements responsive.
Related Issues

Closes #859

Type of PR

[X] UI Enhancement

Screenshots / videos (if applicable)
BEFORE :

AFTER :

Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

Hello @varshith257, can you please assign the PR to me and add the labels.
It took me more than 2 hour to find the issue, can you please consider the label accordingly.
Thank you!!


Drawing on the maps

Just wanted to suggest the ability to be able to draw some lines on the maps to go along with your notes. Perhaps it could be tied to a note, where once you create a note, there's a button option to draw on the map and once complete and saved, you could see the drawing when hovering over the note.
Thanks so much for the site. It is so useful and so well done. Simple and effective. Your hard work is appreciated.

I would add that the vertices of the lines should be per shot.  That is not consistently the case.

A nice idea @towelie444. I'm full up at the moment will keep this task in mind once I get some free time.