Huntercombe-slot-update

Description
<Huntercombe prison Christmas slot update (zendesk ref https://ministryofjustice.zendesk.com/agent/tickets/193544.>
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Prison details update (e.g. slot updates)

Checklist:

[x] My commit message follows the GDS git style standards we have adopted.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the deployment repo accordingly.
[ ] I have added tests to cover my changes.

This change has already been deployed to production: https://github.com/ministryofjustice/prison-visits-2/pull/2567 so closing the PR


Cannot destructure property 'media' of 'theme.sanity' as it is undefined.

Error: Cannot destructure property 'media' of 'theme.sanity' as it is undefined.
TypeError: Cannot destructure property 'media' of 'theme.sanity' as it is undefined.
at responsiveStackSpaceStyle (http://localhost:3333/node_modules/.sanity/vite/deps/sanity-plugin-google-translate.js?v=2eee4417:30946:11)
at Ne (http://localhost:3333/node_modules/.sanity/vite/deps/sanity-plugin-google-translate.js?v=2eee4417:491:14)
at e2.generateAndInjectStyles (http://localhost:3333/node_modules/.sanity/vite/deps/sanity-plugin-google-translate.js?v=2eee4417:359:19)
at http://localhost:3333/node_modules/.sanity/vite/deps/sanity-plugin-google-translate.js?v=2eee4417:610:88
at http://localhost:3333/node_modules/.sanity/vite/deps/sanity-plugin-google-translate.js?v=2eee4417:612:8
at O (http://localhost:3333/node_modules/.sanity/vite/deps/sanity-plugin-google-translate.js?v=2eee4417:616:6)
at renderWithHooks (http://localhost:3333/node_modules/.sanity/vite/deps/chunk-MIB3JJOG.js?v=2eee4417:12171:26)
at updateForwardRef (http://localhost:3333/node_modules/.sanity/vite/deps/chunk-MIB3JJOG.js?v=2eee4417:14327:28)
at beginWork (http://localhost:3333/node_modules/.sanity/vite/deps/chunk-MIB3JJOG.js?v=2eee4417:15934:22)
at beginWork$1 (http://localhost:3333/node_modules/.sanity/vite/deps/chunk-MIB3JJOG.js?v=2eee4417:19749:22)

@kapyar Hey there. Running into the same error. Did you ever get past it?

Any solution here?

Any solution for this?

We just solved this by downloading the source code
https://github.com/sanity-io/sanity-plugin-google-translate/releases
and injecting it inside of our project.

Using https://www.npmjs.com/package/yarn-deduplicate helped in my case.

Using https://www.npmjs.com/package/yarn-deduplicate helped in my case.

What if I'm not using yarn? Has anyone figured this out?

Using https://www.npmjs.com/package/yarn-deduplicate helped in my case.

What if I'm not using yarn? Has anyone figured this out?

If you're using npm, you can try npm dedupe instead.
https://docs.npmjs.com/cli/v8/commands/npm-dedupe

Using https://www.npmjs.com/package/yarn-deduplicate helped in my case.

What if I'm not using yarn? Has anyone figured this out?

If you're using npm, you can try npm dedupe instead.
https://docs.npmjs.com/cli/v8/commands/npm-dedupe

Thank! tried it but still not working.

Using https://www.npmjs.com/package/yarn-deduplicate helped in my case.

What if I'm not using yarn? Has anyone figured this out?

If you're using npm, you can try npm dedupe instead.
https://docs.npmjs.com/cli/v8/commands/npm-dedupe

Thank you! tried it but still not working.

Having the same bug. Tried including like suggested by @norio-org, but this didn't resolved the error. Also tried updating google translate package to the latest version of styled-components and @sanity/plugin-kit, but this did not resolve the error. @runeb  Any ideas how to make this compatible with the latest Sanity version?


Webpack 3 dependencies

I  am getting an error when trying to add this package via NPM to my angular app
in doing some research, it looks like some of Spotcrime's dependencies are built in to webpack now (crypto, net, tls, etc). is there hope for an update?
Error

ERROR in ./node_modules/aws-sign2/index.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\aws-sign2'
[ng] ERROR in ./node_modules/aws4/aws4.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\aws4'
[ng] ERROR in ./node_modules/ecc-jsbn/index.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\ecc-jsbn'
[ng] ERROR in ./node_modules/http-signature/lib/signer.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\http-signature\lib'
[ng] ERROR in ./node_modules/http-signature/lib/verify.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\http-signature\lib'
[ng] ERROR in ./node_modules/oauth-sign/index.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\oauth-sign'
[ng] ERROR in ./node_modules/request/lib/hawk.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\request\lib'
[ng] ERROR in ./node_modules/request/lib/oauth.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\request\lib'
[ng] ERROR in ./node_modules/request/lib/helpers.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\request\lib'
[ng] ERROR in ./node_modules/sshpk/lib/key.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/dhe.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/utils.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/fingerprint.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/signature.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/private-key.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/certificate.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/identity.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib'
[ng] ERROR in ./node_modules/sshpk/lib/formats/pem.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib\formats'
[ng] ERROR in ./node_modules/sshpk/lib/formats/ssh-private.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib\formats'
[ng] ERROR in ./node_modules/sshpk/lib/formats/openssh-cert.js
[ng] Module not found: Error: Can't resolve 'crypto' in 'Z:\ionic\app\node_modules\sshpk\lib\formats'
[ng] ERROR in ./node_modules/request/lib/har.js
[ng] Module not found: Error: Can't resolve 'fs' in 'Z:\ionic\app\node_modules\isstream'
[ng] ERROR in ./node_modules/request/request.js
[ng] Module not found: Error: Can't resolve 'zlib' in 'Z:\ionic\app\node_modules\request'
[ng] i ｢wdm｣: Failed to compile.

package.json

"dependencies": {
"@angular/common": "~7.0.2",
"@angular/core": "~7.0.2",
"@angular/forms": "~7.0.2",
"@angular/http": "~7.0.2",
"@angular/platform-browser": "~7.0.2",
"@angular/platform-browser-dynamic": "~7.0.2",
"@angular/router": "~7.0.2",
"@ionic-native/core": "5.0.0-beta.21",
"@ionic-native/splash-screen": "5.0.0-beta.21",
"@ionic-native/status-bar": "5.0.0-beta.21",
"@ionic/angular": "4.0.0-beta.15",
"core-js": "^2.5.7",
"rxjs": "6.3.3",
"spotcrime": "^1.0.1",
"zone.js": "^0.8.26"
},
"devDependencies": {
"@angular-devkit/architect": "~0.10.4",
"@angular-devkit/build-angular": "~0.10.4",
"@angular-devkit/core": "~7.0.4",
"@angular-devkit/schematics": "~7.0.4",
"@angular/cli": "~7.0.4",
"@angular/compiler": "~7.0.2",
"@angular/compiler-cli": "~7.0.2",
"@angular/language-service": "~7.0.2",
"@ionic/angular-toolkit": "^1.0.0",
"@types/jasmine": "~2.8.6",
"@types/jasminewd2": "~2.0.3",
"@types/node": "~10.12.0",
"codelyzer": "~4.5.0",
"jasmine-core": "~2.99.1",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~3.0.0",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~2.0.0",
"karma-jasmine": "~1.1.1",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.4.0",
"ts-node": "~7.0.0",
"tslint": "~5.11.0",
"typescript": "~3.1.6"
},

Pushed a 2.0.0 that should solve this


chore: restore google-cloud-examples

Restoring the directory https://github.com/googleapis/google-cloud-java/tree/main_202208/google-cloud-examples to the main branch.

The check fails
+ for path in $(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort --dictionary-order | xargs dirname)
+ module_name=google-cloud-examples
+ version_file=./google-cloud-examples/versions.txt
++ grep -E '^((google-.*|grafeas|gapic\-libraries)).*:[0-9]+\.[0-9]+\.[0-9]+.*:[0-9]+\.[0-9]+\.[0-9]+.*$' ./google-cloud-examples/versions.txt
grep: ./google-cloud-examples/versions.txt: No such file or directory

@suztomo If you rename pom.xml to pom.xml.bak, you shouldn't have to make any changes to generation\.

I now think it’s better to remove the pom.xml altogether.

I now think it’s better to remove the pom.xml altogether.

When these get migrated to java-docs-samples, they might want to use something from pom.xml to start running the tests again, but I'm not sure how much in it is useful.

It looks like pom.xml is still there.


feat(sink): handle stream key sink pk mismatch

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

blocked on https://github.com/risingwavelabs/risingwave/issues/12460

Could you add some context for the problem that would be helpful for future reference?


Image Link Issue

Links around images are not persistent after viewing code. This is also an issue when loading previous text to edit.
Steps to reproduce:

Insert image with URL
Select the Link tab and link to page
Submit
Select View Code button
Select View Code button again
Edit image and select Link tab.
Link is no longer available

The <a> tags appear to be stripped when inside <figure> tags

The 2.36.4 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Make renderer run even if the same file was selected

Hello:
I have installed this per you sample OnChange handler code.  This works great but, what if the user were to select the same file again?  When selecting file "a.xlsx" the code runs great, but when selecting file "a.xlsx" again, the code does not run, probably because of the OnChange handler.   What would I do to allow your code to run each and every time even if the same file was selected over an over again?
Thank you for your time.

Hello:
Use the attribute "value" in your input in order to "reset" the file


Arc & Mutex (and RwLock, RC, RefCell)

#[derive(Serialize)]
#[typeshare]
struct MyStruct {
  arc_mutex: Arc<Mutex<SomeOtherStruct>>,
  box: Box<SomeOtherStruct>
}

The above currently outputs (in typescript)
export interface MyStruct {
  arc_mutex: Arc<Mutex<SomeOtherStruct>>,
  box: SomeOtherStruct,
}

Similar to how Box is handled, should typeshare omit Arc and Mutex from the output? (serde automatically handles this too).

I'm working around this like...
#![allow(unused)]

use typeshare::typeshare;

#[typeshare]
type Arc<T> = T;

#[typeshare]
type Mutex<T> = T;

#[typeshare]
type RwLock<T> = T;

I've just seen #134 nice!


Preserve array order, and pg_format

Please merge if/when time allows.

Please merge if/when time allows.


Update changelog for #156

I'm going to merge this even though Travis is failing since it's obviously not failing due to this change and is really failing on master already. Chao is going to investigate the failures and follow up with a separate PR to fix them.


Implement COMGR V2 support with cmake -DUSE_COMGR=1 guard

Re-add the previous COMGR changes, but use a macro guard enabled by cmake option -DUSE_COMGR=1.
We can work on fixing PSDB with this guard.

@wkwchau I fixed the bug we were seeing with hipcc built binaries not properly defining the macro USE_COMGR as 1.

@wkwchau has resolved the conflicts in his PR https://github.com/ROCm-Developer-Tools/HIP/pull/1100


Update how-to-remove-account.md

Description

Fixes

Thank you for the PR! If you pop in our chat on chat.lbry.com, give me a holler and we'll get some LBC over as appreciation!


Save button appears without any functionality

🎇 Description
The save button should only appear when editing the record
🖼 Screenshots

Currently the save button is appearing immediately after adding new record.

Please assign me this issue , I can fix this.

Good highlight! Sure, please go ahead.✨


[Bug] Savepoints is not the path of the last checkpoint file.

Search before asking

[x] I had searched in the issues and found no similar issues.

What happened
Sometimes it is not the path of the last checkpoint file that is saved, but the penultimate one, which results in an error when the checkpoint file cannot be found at startup.
StreamX Version
1.2.2
Java Version
1.8
Flink Version
1.13.6
Scala Version of Flink
2.11
Error Exception
Stack trace: ExitCodeException exitCode=2:
at org.apache.hadoop.util.Shell.runCommand(Shell.java:933)
at org.apache.hadoop.util.Shell.run(Shell.java:844)
at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:1123)
at org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.launchContainer(DefaultContainerExecutor.java:237)
at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:317)
at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:83)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Container exited with a non-zero exit code 2
Failing this attempt. Failing the application.

Screenshots

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

i will fix this bug


fix(build): create index.html for sub-nav items with tabs

(Please use Diff settings - Hide whitespace changes for review)
Debugging how redirects.json (the file created by Gatsby's createRedirect() API) as well as issue 5329 at gatsbyjs/gatsby and Gatsby author's comments at issue 2511 gave me an impression that we need .html file representing from-redirect path so Gatsby's client-side redirect feature to work in static file build, and it seems the case as adding such .html file fixed the redirects, e.g. from /getting-started/developers to /getting-started/developers/vanilla.
This change also fixes an issue where redundant items were created in redirects.json.
Refs #176, #209.
Changelog
New

Static file build .index.html for sub-nav items with tabs, e.g. /getting-started/developers/index.html.

Changed

Fix for an issue where redundant items were created in redirects.json.

Removed

The first tab from the sub-nav keys in navigation.json.

Was thinking about this over the weekend, could we do a custom nginx buildpack that basically tries to serve the file at the path and then falls back to just distributing our index bundle? Then we could have client-side route kick-in (I think). Could also help with deployments so that we could write nginx rules for /design/product without having to change our build folder.

@alisonjoseph Yes.
@joshblack I thought about that option, but I also see team's plan to use GH pages in some way, IIRC. I took a route without a backend-dependency therefore, but feel free to choose an alternate approach to solve this problem.


[AVM Module Issue]: var.routes should be a map not a list?

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
(Optional) Module Version
0.1.0
(Optional) Correlation Id
No response
Description
As per this video; https://www.youtube.com/watch?v=Bat0sY06jz4
Lists have a position index rather than a named one.  If you remove an item from the middle of the list, the position of other items gets changed, leading them to be dropped and re-created.
I think the routes should be supplied as a map, not a list

Thanks @kewalaka you are correct, according to TFNFR7 I should be using maps as the type and not convert the list to map during deployment.
This is addressed in PR
PR raised and waiting for review.


Fix typos in SortedSetOps.cs

Closes #202
Where should I add regression test for this? It seems the testing coverage for this layer of the API is minimal (I only see couple overloads tested in TestProcedureSortedSets

Closes #202
Where should I add regression test for this? It seems the testing coverage for this layer of the API is minimal (I only see couple overloads tested in TestProcedureSortedSets

SortedSet tests are located here: Garnet.test/RespSortedSetTests.cs


Issue1480 Add option to prevent time adjustments from affecting other date/time elements

… date/time elements
Added a noRollTime option (defaults false) that prevents time
adjustments from affecting other date/time elements. e.g. adjust hours
past 23 or below 0 will not affect the date.  Same code is applied to
minutes (not affecting hours) and seconds (not affecting minutes).  In
the case of minutes the stepping option is accounted for.
JSFiddle: https://jsfiddle.net/dflickcb/Lkrtga7g/

Hold:  I missed adding this functionality to the up/down, ctrl-up/ctrl-down keyBinds default functions.

OK, now it is ready to merge @Eonasdan


Wire up Profile Pic so its consistent

Task: Right now when you set a profile picture and you navigate to a different page, when you return your profile picture will reset.
Screen recording:
https://user-images.githubusercontent.com/93608357/216182350-aa8c094e-0d97-431d-a5bb-7415c4ae2f1e.mov

this was never implemented to begin with. we probably want to save the image somewhere, such as in the .uplink folder.

done as of https://github.com/Satellite-im/Uplink/pull/378


Property validation

Stop warning when null property values are instrumented
Allow for objects nested within arrays

Does this mean we officially support objects in arrays?

They show up in the analytics UI now under user activity in a way they didn't before. It's hard to do any interesting useful analysis on them yet without some special object flattening feature that is being worked on.

Also is silencing null warning messages considered a breaking change?

Ugh. I'll poll the team.


cdk-virtual-scroll-viewport mat-table sticly column Virtual Scroll Jumps around

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I'm using cdk-virtual-scroll-viewport with mat-table. I have the first and last column as a sticky(sticky for first and stickyEnd for last). Also, I have row selection. So when the user clicks the row it's highlighted.  And when I select some row and then start to scroll virtual scroll starts jumping around
Reproduction
https://github.com/angular/components/assets/133750432/2b77658c-92ec-41a0-970f-c1d9e5dff737
Expected Behavior
not jumping
Actual Behavior
start jumping
Environment

Angular: 16
CDK/Material: 16
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

cdk-virtual-scroll-viewport has been unusable for years and Angular team just don't care.


UI Shell right panel: Style tab

Acceptance criteria
Update the UI Shell right panel Style tab documentation on the website using the new content template.
Style tab
Overall page tasks

[ ] Update the Style tab with the content template.
[ ] Update images to follow our image guidelines.

Pre-work inference
Figma reference file
Pre-work issue and comment.

UI shell right panel

Style tab
[ ] Color: Update Panel's border spec as - border-left, border-right, border-bottom
[ ] Color: Should we be adding shadow specs in our docs?
[ ] Item: Add border spec for Selected state - border-left | $focus-interactive


Deprecate Python-jose and migrate okta to python_social_auth

Python-jose can be deprecated if we switch to python_social_auth

I just saw that python-jose is used https://github.com/DefectDojo/django-DefectDojo/blob/f66e6dbb07bcddfb607ab81e76cca073080a6c2b/dojo/okta.py#L8
We also have PyJWT in requirements.txt How about migrating okta.py to PyJWT?
What is your opinion @Maffooch and @cneill ?

https://nvd.nist.gov/vuln/detail/CVE-2024-33664
https://nvd.nist.gov/vuln/detail/CVE-2024-33663

We could probably get rid of our version of the okta backend and instead use https://github.com/python-social-auth/social-core/blob/master/social_core/backends/okta.py
At the time, the PR to add the okta backend https://github.com/python-social-auth/social-core was not getting in quick enough for DefectDojo, so we copied the code, and pasted it in here

Done @Maffooch. Could you give me feedback here?

As soon as you start reviewing it, I will resolve the conflicts here @Maffooch. Otherwise, I might have to resolve conflicts multiple times.

@manuel-sommer Mind fixing the merge conflicts on this one so we can work on getting the remaining approvals?

Done @mtesauro

Awesome, that we can get this on the road :-)

@manuel-sommer Was about to merge this since it has 4 approvals - mind fixing the merge conflicts

Done @mtesauro

@manuel-sommer
Thank you sir!


How are top-level securityDefinitions defined?

It appears that there is no way to define a securityDefinition at the root level.
This ApiOperation ...
@RestController
@RequestMapping("/test")
@Api(value = "test")
public class test{
    @RequestMapping(
        value = "/testing",
        method = RequestMethod.GET,
        produces = MediaType.TEXT_PLAIN_VALUE)
    @ApiOperation(
        value = "testing",
        authorizations = @Authorization(value = "basicAuth", type = "basicAuth")
    )
    public String testMethod() {
        return "testing";
    }
}

... yields this json ...
  "paths" : {
    "/test/testing" : {
      "get" : {
        "tags" : [ "test" ],
        "summary" : "testing",
        "description" : "",
        "operationId" : "testMethod",
        "produces" : [ "text/plain" ],
        "responses" : {
          "200" : {
            "description" : "successful operation",
            "schema" : {
              "type" : "string"
            }
          }
        },
        "security" : [ {
          "basicAuth" : [ ]
        } ]
      }
    }
  }

However, there is no securityDefinition defined at the root level, so the spec is not valid.
Here is the relevant section in the Swagger 2.0 spec definition: https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#security-definitions-object

There's no corresponding annotations to do that, do you have any good ideas for that info?
My intuition is to provide a separate json file to define the securityDefinition and configure its path in pom.xml.

I think an external JSON file would work well for complex securityDefinitions, but it would also be nice to be able to define this inside the apiSource node of the plugin xml.  For more basic securtyDefinitions, only two strings (name, type) are needed.
I propose something flexible, like so:
<apiSource>
...
    <securityDefinitions>
        <securityDefinition name="basicAuth" type="basic" />
        <securityDefinition>/path/to/securityDefinition.json</securityDefinition>
    </securityDefinitions>
...
</apiSource>

That makes sense.

Hi, plese check https://github.com/kongchen/swagger-maven-plugin#security-definitions to see how to define it.
It's not possible to read xml node's attribute in pom.xml for a maven plugin, so I did not follow the way you suggested.
Also, try 3.0.1-SNAPSHOT.

Thanks, this works!


Upgrade to forester v4.3

The release notes suggest that the theme needs to be upgraded, which will take a little work since we have made a few modifications. Perhaps we should generate a patch from v4.2 to v4.3 and then apply the patch to this repo. Hopefully there won't even be any conflicts.

Relatedly, forester v4.3 now includes the upstreamed static builds for Linux, which we should use in our CI.


Some optimizations

Assuming this code will be ran rather frequently in most scenarios, it won't hurt to optimize it.

Looks good, not sure what I was thinking with that pcall lol.


chore: Fix some porting notes and make some defs computable again.

These are some auxiliary definitions for the monoidal structure on a category induced by binary products and terminal objects.

Thanks!
bors merge


Update MD file on new branch 2017-17-17_13-11-38

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


stop 'possible EventEmitter memory leak detected' from printing in th…

…e logs
If there are more than 10 tests added, there will be a 'possible EventEmitter memory leak detected' message and stacktrace printed in the logs. It's not a big deal but kind of annoying.
This PR will prevent that message from printing.
To verify:
Run the test and there should be no such messages printed anymore.

ping @evanshortiss

@wei-lee Reviewed change.
I know that this was not part of this issue, but I also see excessive logs in supercore:
{code}
"Check fh-messaging" finished running
...
{code}
Do you think that we can we change logging level for this type of messages to debug?

@wei-lee @wtrocki I never saw this until now. Is it still something to merge. Also I think maybe we can remove this repo and just use evanshortiss/fh-health instead?


How to understand the bit operations in parser.go

I would suggest using play.golang.org and executing snippets that you're interested about. You can print things in binary to make it easier to see what's happening:
fmt.Printf("%#b", num)

Happy to answer any specific questions. Thanks for your interest


How to output the POST request content?

From @stefaniebrunner on June 9, 2014 20:45
Hi, do you know how I can print or get out the content of a json-formatted POST request? My API received a json, but I don't know exactly how the structure of that json is. I tried a lot but I always reveive an error (a message body reader for Java class ... and Java type class was not found).
What can I do to find out what is in the request body? Thanks a lot.
Copied from original issue: krasserm/grails-jaxrs#49

From @davidecavestro on June 10, 2014 7:39
I'd try declaring a Map parameter in the resource method - instead of your specific type - then see the map contents.

From @stefaniebrunner on June 11, 2014 20:41
yes thanks, that was what I was looking for.
Now I've got another problem. I have a POST request like
@POST
@Path('/check')
Response checkLocation(Map loc) {
. .
ok 'something'
}
if I don't have to respond an object, only to say all is fine with Status ok. How can I do that? All i tried to write after the "ok" I get the error message:
HandlerInterceptor.afterCompletion throw exception cannot create a session after the response has been committed
Does anybody know what is wrong?

Closing due to the age of the issue.


STX-20 Zero balances still displayed in wallet

Token balance of 0 is still being displayed for two STX20 tokens in our wallet. This is mirrored on STX20.com. We should investigate with the STX20 team why a 0 balance is displaying at all, and maybe add a filter to not display these tokens with 0 balance.
Wallet: SP3QKE2BE9JX52759E9C30V5C60RKK2DBFRF6NVPV

I've inquired with the Asigna team here.

we tested balances on our end and everything works perfectly and displays in Leather
https://explorer.hiro.so/txid/0x6b84453477f63f9994e8eeb9a72944bc14378e7ddde2f782d7762e759ebdb289?chain=mainnet
https://explorer.hiro.so/txid/0x2bf5bfda1016b9a80ca90d7c2a68a70f5f9c04316a99185ccfb54537e01e7cff?chain=mainnet
seems like you sent your tokens some time ago, that's why it doesn't show up in the wallet anymore
@markmhendrickson @brandonmarshall-tm

I think the question here is whether the API could return null for empty balances in general, whereas it seems to return null in some instances (presumably for addresses that have never had a particular STX-20 token?) and 0 for others (for those that have in the past?).

nudge @fess-v


GitHub cred req

We only need the user name
Remove email

Hey @ainvoner
Is this still relevant, or can we close? Thanks


ignore hint when meet unknow token in hint

Current, when we meet unknow hint token whole sql will be failure.
This PR will ignore whole hint when meet unknow hint to compatible to SQL that generate by tool and target to other database.

This change is

LGTM


Bot answers associated with numbers are wrong

Every question associated with Formulars or numbers will get a wrong answer from the bot. Even if it's just a number in a text. ChatGPT website and playground is right at the same question but the bot swapped numbers. Formulars are wrong and numbers are wrong. How to fix it?

Try changing the prompt to be "AI assistant".


Improve test coverage

Our test coverage is lacking for some contracts/methods. This PR addresses this and attempts to get our coverage to 100% for all critical source files.
For reference, our initial foundry coverage report:
| File                                             | % Lines          | % Statements     | % Branches     | % Funcs         |
|--------------------------------------------------|------------------|------------------|----------------|-----------------|
| script/DeployERC4337Factory.s.sol                | 0.00% (0/8)      | 0.00% (0/12)     | 100.00% (0/0)  | 0.00% (0/2)     |
| src/CoinbaseSmartWallet.sol                      | 95.65% (44/46)   | 96.92% (63/65)   | 90.91% (20/22) | 92.31% (12/13)  |
| src/CoinbaseSmartWalletFactory.sol               | 100.00% (10/10)  | 100.00% (10/10)  | 75.00% (3/4)   | 75.00% (3/4)    |
| src/ERC1271.sol                                  | 85.71% (12/14)   | 89.47% (17/19)   | 100.00% (2/2)  | 100.00% (6/6)   |
| src/MultiOwnable.sol                             | 100.00% (27/27)  | 100.00% (38/38)  | 80.00% (8/10)  | 100.00% (13/13) |
| src/utils/ERC1271InputGenerator.sol              | 0.00% (0/9)      | 0.00% (0/14)     | 0.00% (0/6)    | 0.00% (0/1)     |
| test/CoinbaseSmartWallet/SmartWalletTestBase.sol | 0.00% (0/16)     | 0.00% (0/18)     | 0.00% (0/1)    | 0.00% (0/6)     |
| test/CoinbaseSmartWallet/UpgradeToAndCall.t.sol  | 100.00% (1/1)    | 100.00% (1/1)    | 100.00% (0/0)  | 50.00% (1/2)    |
| test/MultiOwnable/MultiOwnableTestBase.t.sol     | 0.00% (0/3)      | 0.00% (0/3)      | 100.00% (0/0)  | 0.00% (0/1)     |
| test/mocks/MockCoinbaseSmartWallet.sol           | 50.00% (1/2)     | 66.67% (2/3)     | 100.00% (0/0)  | 50.00% (1/2)    |
| test/mocks/MockEntryPoint.sol                    | 40.00% (2/5)     | 33.33% (2/6)     | 0.00% (0/2)    | 33.33% (1/3)    |
| test/mocks/MockMultiOwnable.sol                  | 100.00% (1/1)    | 100.00% (1/1)    | 100.00% (0/0)  | 100.00% (1/1)   |
| test/mocks/MockTarget.sol                        | 80.00% (4/5)     | 100.00% (4/4)    | 0.00% (0/1)    | 66.67% (2/3)    |
| Total                                            | 69.39% (102/147) | 71.13% (138/194) | 68.75% (33/48) | 70.18% (40/57)  |

Review Error for wilsoncusack @ 2024-03-18 19:48:43 UTC
User failed mfa authentication, see go/mfa-help


[CLOUD-1665] chore: add doc for smoke tests setup

:tada: This PR is included in version 0.20.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Graph View: Allow closing the expand graph by clicking outside of it

This should be fixed in 1.8.0. Let me know if it still does not work as expected and reopen the issue. If you find any new issues please submit a new issue :)
Thanks!


Explain how to use it on the website

When on https://project-open-data.cio.gov/datajson-builder/, I don't readily see how to actually use the tool.

Assigning myself to build out a blog like listview & add documentation on emulating how to create a _dataset directory and data.json for use on any Jekyll template...

To be clear of intention... The concept here is that any agency could quickly standup a light-weight, no-security headache, website immediately where each "blog/page" === a dataset -> all posts/pages collectively then automatically compile together in single data.json file that can be harvested by data.gov... Where the github pages 'front matter' (ie YAML attributes) can concurrently feature/filter content for the agencies specfic need and as a indirect/secondary effect compile valid data.json v1.1

Yeah, we'll want to add dataset "detail pages".  The MVP to start the conversation was just the data.json template.


Added constexpr modifiers for C++14 mode and some tests

I like this change. But the tests are incomplete. There's no constexpr tests for mismatch, for example. (or power)

OK. I'll add more tests soon. Anyway, this PR must be merged after constexpr for for begin()/end() PR

Ok; I'll wait for your update.

Looks like https://github.com/boostorg/range/pull/44 hasn't been merged yet.

This pull request is superseded by https://github.com/boostorg/algorithm/pull/35


Nested media-queries

I've found no mention of media-queries here so I've got a question.
If I'm using SCSS or PostCSS Nested plugin, does Airbnb styleguide allow to use nested media-queries (media query bubbling, saying more precisely)? And if so, how much more preferable to use it in comparison with using regular media-queries?

Can you assign this to task to me

@deepanshu1334 assignments aren't needed for tasks; if you'd like to submit a PR, do so - but this isn't a task, it's a question.


Add helpers for kando stream push

Change Overview

Required functions to create a virtual fs and kopia snapshots

Pull request type
Please check the type of change your PR introduces:

[x] :sunflower: Feature

Test Plan

[x] :muscle: Manual

Okay, now the CI is failing with go1.14 issue:
# github.com/kopia/kopia/internal/apiclient
/go/pkg/mod/github.com/kopia/kopia@v0.4.1-0.20200608151401-25934a544df4/internal/apiclient/apiclient.go:60:14: undefined: http.NewRequestWithContext
/go/pkg/mod/github.com/kopia/kopia@v0.4.1-0.20200608151401-25934a544df4/internal/apiclient/apiclient.go:142:48: http.DefaultTransport.(*http.Transport).Clone undefined (type *http.Transport has no field or method Clone)
note: module requires Go 1.14

This will be dependent on #693

Fixed go1.14 issue. This is ready for review

I will merge and iterate


Fix inheritance

This demonstrates the problem described in #31

Coverage remained the same at 100.0% when pulling 0a89947d41f4ed6412d979280d1e1ebd1714d52a on infoxchange:method-override-31 into a9ac2cf4e9a6d29d2d5e4ea62b0c0645243719da on clarkduvall:master.

Ugh, my bad, had my MRO confused.


Adding possibility extension of Client

This enhancement allows you to extend communication with the API.
Examples of applications:

Customization of events.
Use of multiple services running on the same application.

Thank you for the PR, could you clarify what use-cases this patch solves?

This PR makes it possible to create alternative client:
e.g:
defmodule Report.Client do
  use Rollbax.Api

  defoverridable [handle_cast: 2, emit: 4]

  def emit(lvl, msg, meta, item, module_name \\ __MODULE__) do
    module_name = module_name || __MODULE__
    event = {Atom.to_string(lvl), msg, unix_timestamp(), meta, item}
    GenServer.cast(module_name, {:emit, event})
  end

  def handle_cast({:emit, _event}, %{enabled: false} = state) do
    # ...
  end

  def handle_cast({:emit, event}, %{enabled: :log} = state) do
    # ...
  end

  def handle_cast({:emit, event}, %{enabled: true} = state) do
    # ...
  end
end

My motivation to create this PR is to own a service (called Report) that you receive bugs from other applications (including desktop applications).
The Report application does what is needed and sends the "item" for Rollbar on a specific project.
Without this PR I can not extend the functionality of Client method, and the only alternative would be to duplicate it.

As I see you'd like to "plug" into emit function to reformat/rewrite event payload.
It depends on your specific implementation of course (if you could share this bits I think it will help), but I believe it should be solved in a different way. Rather than doing that much code generation in __using__ (it is usually a bad design sign) which together with defoverridable seems too magical, it'd be better to provide extra argument for start_link that represents Formatter (not sure about the name) behaviour.

Do not know.
I do not think misuse __using__, after all, is used in ECTO for it to be extensible.
But I agree that we can think of a better alternative to defoverridable (Formatter or callbacks).
it's just my opinion. :smiley:

@lexmag, I have work to implement the Rollbax.Plug
(code here: https://github.com/gullitmiranda/rollbax/tree/feature/plug).
To do this I've been thinking about how to leave the extensible Rollbax. Do you have any suggestion?

Hey @gullitmiranda, that's wonderful, I think the proper way of making Rollbax.Plug would be using same logic as Plug.ErrorHandler uses.

The branch mentioned above, I've done the whole thing work. Before closing this PR and make a new, I intend to solve the extensibility problem.
But I had an idea how to do. I want to use an option called otp_app well as in ECTO, Gettext and others.
eg:
defmodule MyApp.Report do
  use Rollbax.Client, otp_app: :my_app
end

@gullitmiranda my apology for responding late to this issue.
I think otp_app approach is really nice one. It seems natural and many people are familiar with it. :+1:

great. I'm currently doing rebase from master and making a small correction: https://github.com/elixir-addicts/rollbax/compare/master...gullitmiranda:feature/plug?expand=1
review if possible, because once finished I will do PR.


Issue with wordlist in startBruteForce

cat "$SUBS"/hosts | parallel -j 5 --bar --shuf gobuster dir -u {} -t 50 -w wordlist.txt -l -e -r -k -q -o "$DIRSCAN"/"$sub".txt
/home/admin/go/bin/gobuster dir -u "$line" -w "$WORDLIST"/wordlist.txt -e -q -k -n -o "$DIRSCAN"/out.txt
the wordlist.txt is not copied to the wordlists folder found in the resultdir anywhere in the recon.sh script

Yes I don't think enabling directory bruteforcing as part of reconpi  is good since it takes lot of time, command is given just for a reference, feel free to change the name of wordlist file or path as per your convenience in your local change


Repository: https://github.com/wabbajack-tools/wabbajack-tools.github.io/actions

I get same error

I seem to be hitting this as well:

Run actions/setup-node@v1
  with:
    node-version: 13.x
    always-auth: false
##[error]
<title>522 Origin Connection Time-out</title>

522 Origin Connection Time-out

cloudflare-nginx

This is probably issue of Cloudflare, they seem to have some breakdown: https://www.cloudflarestatus.com/

Seems to be working oncevagain

Works sometimes

Seems to be working again


Sync with latest stable/mitaka development branch

Changes Unknown when pulling f93806c153f4257e10becae66608dc1a83bcbebb on alvarolopez:stable/mitaka into ** on IFCA:stable/mitaka**.


Showcase Submission for code/7-arrays/8-objects-images

Thank you Grem for your contribution! A member of the Coding Train team will review it shortly.

Pixel Grass
Grem

Thank you for sharing your work!


Update example script to 3.2.0

Coverage remained the same at 89.986% when pulling ff49da449e0af88d5187dbb3799617270801e34c on AlanCoding:ex_updates into 996e2d96af06cd0951c0af6ea31f5593e1ec69bf on ansible:master.


Execute Indirect: Only rendering third frame

Execute indirect will only render every third frame. Likely to be related to versioning.

Tried this, Seems to work fine. Maybe only when the GPU can't finish execution fast enough.

Looking at the code it would make sense if execute indirect works inconsistently on slower hardware. Updating only the 3e frames seems weird to me though.

This has changed with the introduction of the dxr fallback layer. In the third frame, it now crashes when Transition is called on the render target.

Error is: D3D12 WARNING: ID3D12CommandQueue::ExecuteCommandLists: Execution of Command List 0x00000255402C19C0:'Unnamed Resource (line: 32 file: D:\School\IGAD Y3\Procedural-Ray-Tracing\src\d3d12\d3d12_command_list.cpp', contains a shader op (Draw/Dispatch/ExecuteIndirect) recorded while using Shader Patch Mode NONE, or contains an ExecuteIndirect that changes VB/IB/Root bindings. Hence, all further GPU-based validation may undervalidate or produce true GBV errors with imprecise tracked state (labelled with 'Possibly imprecise') for resources in the COMMON state or Promoted-from-COMMON state at the time of execute. [ EXECUTION WARNING #1044: GPU_BASED_VALIDATION_RESOURCE_STATE_IMPRECISE]
D3D12: Removing Device.

Removed execute indirect.


Observable: Fix single fire events not working sometimes

See https://forum.babylonjs.com/t/scene-ready-observable-not-firing-with-v5-35-0/36166/23
Fix bug introduced by #13283

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13465/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13465/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13465/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13465/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13465/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13465/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13465/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13465/merge#BCU1XR#0


Simplified methods

Codecov Report

Merging #4 into release-0.1 will increase coverage by 0.77%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release-0.1       #4      +/-   ##
===============================================
+ Coverage        92.64%   93.42%   +0.77%
===============================================
  Files                1        1
  Lines               68       76       +8
===============================================
+ Hits                63       71       +8
  Misses               5        5

Impacted Files
Coverage Δ

src/ape/dnabin.jl
93.42% <100%> (+0.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc35db...1f08a3c. Read the comment docs.


automation: Fix Fedora29 dev image

Udev has stopped working in the Fedora dev image.
It seems that the source is related to a missing systemd-udev package.
The container dockerfile has been updated to include systemd-udev.
In addition, an update has been included to confirm with the systemd
container enablement instructions:
https://hub.docker.com/r/fedora/systemd-systemd/
systemd-udevd is also being started when the container is run and NM is
restarted in order to confirm it loads with udev activated already.

Coverage increased (+0.1%) to 68.937% when pulling cbc4d5011f37cc3f73088f18e4c6c7bb7fdb41a1 on EdDev:fix-fe29-dev-container-image into ad9e212a9c956e084cf70c3ac3574f69703ed845 on nmstate:master.

Since this indicates a packaging/configuration error in NetworkManager, I filed https://bugzilla.redhat.com/show_bug.cgi?id=1704456
I am not sure about what you mean about updating in regard to the systemd docker recommendations - is it the dnf update?

Since this indicates a packaging/configuration error in NetworkManager, I filed https://bugzilla.redhat.com/show_bug.cgi?id=1704456

Ok, but I am not sure if applications should depend on udevd in this manner. Only dracut seemed to have depended on it.

NetworkManager depends on udevd, otherwise we would not have this problem. The problem is that the package does not express this dependency properly. Also I am not sure why it would be wrong for an application to depend on udevd.

I am not sure about what you mean about updating in regard to the systemd docker recommendations - is it the dnf update?

Yes, but I think we should do this change in a separate PR, it is not a direct fix to the current problem. I will try to drop it.

I am very confident that this is not really a requirement to run systemd.


Fixing dates and exposing placeholders

I did both changes i mentioned - i really think that at least placeholders should be built in feature here.
Unfortunately i didn't manage to change template for adding placeholder to deal with it without putting braces around var - it may cause some issues for users (say with Django if somebody screw templates up). I think there is no other way, but if im wrong i'd really like to know how ;)
Thanks and enjoy

Why not just use placeholder property of fsSelect (i.e. fsPlaceholder => placeholder)?

well, i wanted to mark that this is coming from the directive - im not especially attached to it to be honest

I think, placeholder is better remember-able and transparent.
Another question: do you need dynamic binding for it or bind-once enough?

Well, personally i just needed way to put my own text there, as i said, for purely i18n reasons. I can imagine somone wanting to dynamically changin placeholder, but i think it would be a bit of a stretch to forsee it in library. But then again i guess the same could be said about me wanting to have custom one.
What i wanted, and what i did, is simply to pull out 'placeholder' attribute to place where i would be able to set it to my liking

Ups, build is broken after pull
@4rlekin  could you try to fix specs?

Sure, i will look into it tomorrow


Components instead of globals

I like how apistar and vibora implemented components and I would like to see something similar in Sanic, in stead of using globals.
More information: https://docs.vibora.io/initial
There is no need to reinvent whole dependency injection thing and components can be injected using https://github.com/ivankorobkov/python-inject for example.
Components also could be used for things like authentication.

This is likely not something that is on the near term development list (while I do agree that component injection is awesome). On the other hand @vltr is working on something just like this as a plugin. I'll let him explain further.
+1  for the idea though!

I don't see anything needs to be global if request has attached app.

Thanks! Gonna close this issue.


Mime fix

closes #64
Essentially there was one thing we missed: to ensure that files are properly served, they need to be accompanied by a header that indicates the MIME type.
Luckily, Mux was doing this and using a file that had a massive list of file extensions and corresponding mime types which I just copied and pasted.
Anyway so this fix should ensure that SVGs are rendered properly but also a bazillion other file types should be ok too.
(I'll merge this myself provided the tests pass, passed locally so should be all good)

Codecov Report

Merging #65 into master will increase coverage by 0.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   81.16%   81.49%   +0.33%
==========================================
  Files           5        5
  Lines         223      227       +4
==========================================
+ Hits          181      185       +4
  Misses         42       42

Impacted Files
Coverage Δ

src/LiveServer.jl
100% <ø> (ø)
:arrow_up:

src/server.jl
91.76% <100%> (+0.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a1e0e...666686d. Read the comment docs.


Incorrect pin assignment for cs in sd/spi.rs on git master branch

Hi, trying to work out why my sdcard wasn't working, I was noodling through the source (i'm using the git [pathc.crates-io] in my Cargo.toml) and found the fololowing for spi_driver::new():
  pub fn new(
       spi_driver: T,
       cs: Option<impl Peripheral<P = impl OutputPin> + 'd>,
       cd: Option<impl Peripheral<P = impl InputPin> + 'd>,
       wp: Option<impl Peripheral<P = impl InputPin> + 'd>,
       int: Option<impl Peripheral<P = impl InputPin> + 'd>,
       #[cfg(not(any(
           esp_idf_version_major = "4",
           all(esp_idf_version_major = "5", esp_idf_version_minor = "0"),
           all(esp_idf_version_major = "5", esp_idf_version_minor = "1"),
       )))] // For ESP-IDF v5.2 and later
       wp_active_high: Option<bool>,
   ) -> Result<Self, EspError>
   where
       T: Borrow<SpiDriver<'d>>,
   {
       let dev_config = sdspi_device_config_t {
           host_id: spi_driver.borrow().host(),
           gpio_cs: cs.map(|cd| cd.into_ref().deref().pin()).unwrap_or(-1), <----------- this line!!
           gpio_cd: cd.map(|cd| cd.into_ref().deref().pin()).unwrap_or(-1),
           gpio_wp: wp.map(|wp| wp.into_ref().deref().pin()).unwrap_or(-1),
           gpio_int: int.map(|int| int.into_ref().deref().pin()).unwrap_or(-1),

Appears the card detect pin is being mapped into the gpio_cs AND gpio_cd. Doesn't seem to effect functionality in my case as only sdcard is on this bus, but might stymie people with multiple spi devices?
Best, Jim

oh yeah that looks wrong, do you want to PR a quick fix?

I've actually just realised it's "right" - looking at it again as the gpio.cs is mapped as|cd| in the closure, so it's actually dereffing the right pin anyway, just the captured variable name is wrong!
I've been looking at misbehaving code all day, now it's all starting to look naughty to me!

yeah its "right" that is technically correct but well it's still a "typo" overall  ;P

https://github.com/esp-rs/esp-idf-hal/pull/492
1st one I've done, so hoping it's right!


Azure Enable this puppy

@ferventcoder Let me know if you have any questions about what adding S3 would look like, but I expect you'll know what you want to do. It might be interesting down the road to have a way to plug in to the container so we could keep the Azure blob and S3 stuff in their own assembly beside the main one, but right now we have more important things to work on. I can't speak for Phil et. al., but I'd have no problem pulling in an S3-based package file service.


[en]update middleware-compatibility

Updated en version according to #5409

Preview: https://deploy-preview-5426--daocloud-docs.netlify.app/en/middleware/compatibility


[MCM 2/3] How-to: Dynamic circuits with mid-circuit measurements

Title:
How to create dynamic circuits with mid-circuit measurements
Summary:
This how-to is a walkthrough of creating a QNode that contains mid-circuit measurements, logical processing of the measured values, and conditioning functions on these processed measurements.
As a warmup task, we implement a T-gadget, which showcases a single MCM without processing that conditions a single follow-up gate.  This serves the purpose to have a minimal example of a dynamic circuit, in addition to the more contrived QNode example.
Relevant references:
Possible Drawbacks:
Related GitHub Issues:

If you are writing a demonstration, please answer these questions to facilitate the marketing process.

GOALS — Why are we working on this now?
This how-to promotes mid-circuit measurement functionality in PennyLane, which has been extended in recent releases.
In addition, this how-to is part of the broader goal of emphasizing MCMs and dynamic circuits in our contents.

AUDIENCE — Who is this for?
Typical how-to audience: Fundamental concepts of measurements and quantum computing are known, but the audience may not yet be familiar with PennyLane's syntax for MCMs and conditioning circuit parts on their outcomes, or they may want to consult this how-to as a reference of how to realize their dynamic circuit with MCMs.
Anyone really with the goal of coding up a circuit that uses MCM values and feedforward can be in the audience.

KEYWORDS — What words should be included in the marketing post?

Dynamic circuit
Mid-circuit measurements
Feedforward control
[optional] Measurement value processing

Which of the following types of documentation is most similar to your file?
(more details here)

[ ] Tutorial
[ ] Demo
[x] How-to

(Even if It doesn't use new features, I will target dev to ensure that there are no unexpected problems on Monday)

Thanks for that last change @dwierichs ! Once It pass the CI, if there is not issues,  I will do the merge. Is it ok for you? or anything else I should keep in mind?

Thanks for that last change @dwierichs ! Once It pass the CI, if there is not issues, I will do the merge. Is it ok for you? or anything else I should keep in mind?

Oh I see the auto-merge, I'll consider it as a yes 😄


chore: migrate to @babel/eslint-parser

Fixes #10636
I am not familiar with the codebase, let me know I misses something. Thanks!

The CI reports that react-app can not be loaded by eslint, likely because @babel/eslint-parser is not provided in certain e2e fixture package.json. However I don't know where are these package.json, help will be appreciated.
/cc @ianschmitz

Thanks @JLHwung, I've made a few updates as discussed, and this should be good to go now.
CC @ianschmitz @iansu.

Thanks!

I don't understand why the version of package.json was not updated after fixing this bug, which caused me to pull 6.0.0 or 6.0.0-next.117 from npm, which did not solve the current problem! But it is indeed merged on github. 😂
I hope I can get an explanation about this problem, and then I want to ask if fix bug is a minor version iteration?
Thanks！

我不明白为什么修复这个bug之后没有更新package.json的version，这导致我从npm上拉取6.0.0或者6.0.0-next.117都没有解决当前这个问题！但是github上确实合并了。😂
希望可以得到关于这个问题的一个解释，其次就是想问一下fix bug算是一个小版本的迭代吗？
谢谢！

I am using a tool, so it might be a bit crappy to read. ^ - ^

@JLHwung Thanks!

We are using eslint-config-react-app in our eslint config -
It seems like babel-eslint is still a peerDep somewhere in the tree..
➤ rm -rf node_modules && yarn install
yarn install v1.22.15
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[5/5] 🔨  Building fresh packages...
✨  Done in 12.78s.

➤ yarn add babel-eslint --dev
yarn add v1.22.15
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
warning<EMAIL_ADDRESS>babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
[5/5] 🔨  Building fresh packages...

Using v6.0.0 of eslint-config-react-app
Opening up ./node_modules/eslint-config-react-app... it's clearly still needed inside this npm package:

I don't know if this change was accidentally reverted, or if this piece (inside eslint-config-react-app) was never actually done


k3s 1.24.7 -> helm renders wrong kubeVersion

Environmental Info:
K3s Version:

root@d11:~# k3s -v
k3s version v1.24.7+k3s1 (7af5b167)
go version go1.18.7

Node(s) CPU architecture, OS, and Version:

root@d11:~# lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 11 (bullseye)
Release:	11
Codename:	bullseye

Cluster Configuration:

root@d11:~# kubectl get nodes
NAME   STATUS   ROLES                       AGE    VERSION
d11    Ready    control-plane,etcd,master   344d   v1.24.7+k3s1
d12    Ready    control-plane,etcd,master   327d   v1.24.7+k3s1
d13    Ready    control-plane,etcd,master   497d   v1.24.7+k3s1

Describe the bug:

The cluster is provisioned with ArgoCD and Helm.
When I try to install longhorn 1.3.2 off-the-shelf helm-chart, i get following error
time="2022-11-02T11:20:31Z" level=info msg="Normalized app spec: {\"status\":{\"conditions\":[{\"lastTransitionTime\":\"2022-11-02T11:20:31Z\",\"message\":\"rpc error: code = Unknown desc = Manifest generation error (cached): `kustomize build .dev/misc/longhorn --enable-helm --load-restrictor LoadRestrictionsNone` failed exit status 1: Error: Error: chart requires kubeVersion: \\u003e=1.18.0-0 \\u003c1.25.0-0 which is incompatible with Kubernetes v1.25.0\\n\\nUse --debug flag to render out invalid YAML\\n: unable to run: 'helm template longhorn --namespace longhorn-system .dev/misc/longhorn/charts/longhorn --values /tmp/kustomize-helm-1430322709/longhorn-kustomize-values.yaml' with env=[HELM_CONFIG_HOME=/tmp/kustomize-helm-1430322709/helm HELM_CACHE_HOME=/tmp/kustomize-helm-1430322709/helm/.cache HELM_DATA_HOME=/tmp/kustomize-helm-1430322709/helm/.data] (is 'helm' installed?)\",\"type\":\"ComparisonError\"}]}}" application=argocd/longhorn-dev

I expected this to be an issue of the longhorn chart, because the top border of compatible versions (v1.25.0-0) was introduced with chart version 1.3.2.
Fiddeling around with the chart raising the top border to < 1.25.1 , the problem went away
Steps To Reproduce:

Installed K3s:

Expected behavior:

helm renders kubeVersion to v1.24.7
Actual behavior:
helm renders kubeVersion to v1.25.0
Aditional context:
Created an issue for longhorn as well (https://github.com/longhorn/longhorn/issues/4811)

I'm not sure how this is a k3s or longhorn issue. ArgoCD is running kustomize build command that is apparently setting the  Kubernetes cluster version to v1.25.0 when running helm template despite the cluster being on v1.24.7. Can you try installing via helm directly?


Default settings are susceptible to weak DH/logjam attack on SSL

When I run the default website against the ssl analysis website:
https://www.ssllabs.com/ssltest/analyze.html
I get this warning:
This server supports weak Diffie-Hellman (DH) key exchange parameters

This is as a result of weak keys being used for the DH key exchange and is what is responsible for the Logjam attack:
https://weakdh.org/
https://en.wikipedia.org/wiki/Logjam_(computer_security)
As this is preliminary find I feel this is too early to create a check in with a pull requests as I am not too sure the best place to put this fix.
The details of the fix to a server are captured here:
https://www.howtoforge.com/tutorial/how-to-protect-your-debian-and-ubuntu-server-against-the-logjam-attack/
For me I added this extra line to the nginx.conf.template file:
%(ssl_disabled)s ssl_dhparam /etc/ssl/private/dhparams.pem;

And added this extra task to the fabfile, and called the task out independently of install or deploy.  Maybe this piece of code can be merged into the location where the keys for the server are generated. The final upload_template_and_reload can probably be removed, it was just required as a function the task, dh, being on its own.
@task
@log_call
def dh():
    ssl_private = "/etc/ssl/private"
    if not exists(ssl_private):
        sudo("mkdir -p %s" % ssl_private)
        sudo("chmod 710 %s" % ssl_private)
    dh_file = ssl_private + "/dhparams.pem"
    if not exists(dh_file, use_sudo=True):
        sudo("openssl dhparam -out %s 2048" % dh_file)
        sudo("chmod 600 %s" % dh_file)

    for name in get_templates():
        upload_template_and_reload(name)

I think it's ok to go ahead with the PR - the location of the code for generating the key sounds good too. Please ensure there are some comments in the code explaining what's going on, even if it's just a sentence with a link to this issue.
Thanks a lot for your help.

OK I have created a PR.  However I am a little concerned this is only of use for new projects and the lessons learned are not being percolated into existing projects.  This where my reticence to just add it straight to the fabfile.
I think I will type up some of my findings and recommendations on the google group should any existing users find they need to fix these security related issues.

Closing as we no longer support Fabric deployments


Optimize PackedRowStoreValueAccessor & BasicColumnStoreValueAccessor by removing redundant computations and clearly exposing a strided memory access pattern

This PR proposes to optimize the way value accessors are currently used to read values from a storage block. Code profiling revealed that almost 10%-15% of the execution time was being spent in making redundant method calls to CatalogRelationSchema to find out properties that are anyway always constant when iterating over a given column. A simple caching of these values could give significant improvements. Moreover, during code analysis it was found that even more opportunities for compiler induced optimization and vectorization exist, if a simple semantics of a strided memory access pattern is exposed to the compiler & the runtime. After all, most iterations over a column in a relation can be expressed by as simple equation as: base_address + tuple_id * offset, where base_address and offset are constant. Exposing this semantics opens a whole lot of interesting opportunities, which otherwise have been obscured in the existing design of ValueAccessors. Rewriting the entire set of ValueAccessors is a mammoth  task. Therefore, this PR and few subsequent PRs will propose to do this incrementally, always making sure that each PR addresses end-to-end functionality for some subset of features.
This PR specifically optimizes PackedRowStoreValueAccessor & BasicColumnStoreValueAccessor only. To demonstrate the end-to-end benefit of this optimization, predicate evaluation involving relational operators, regular expressions & literal comparison have been refactored to be cognizant of such optimizations.
Tests:

Tests for changes to PackedRowStoreValueAccessor have been added in PackedRowStoreTupleStorargeSubBlock_unittest.cpp
BasicColumnStoreTupleStorageSubBlock_unittest.cpp has existing tests which test various code paths that invoke the new functionalities for BasicColumnStoreValueAccessor.

Performance Numbers:
A simple selection query select count(*) from lineorder where lo_discount > 5 on SSB Scale Factor 100 improves by almost 18-20%. Following lists the query completion time for 20 trials for SSB-SF-100 done on the standard Cloudlab machine with and without the current patch:

Trial #
w/o ColumnAccessors  (in seconds)
w/ ColumnAccessor (in seconds)

1
293
218

2
267
222

3
254
227

4
255
230

5
256
193

6
244
214

7
244
207

8
235
198

9
226
189

10
225
182

11
226
184

12
223
181

13
222
177

14
224
174

15
225
173

16
219
170

17
219
161

18
220
164

19
217
161

20
219
159

Mean
236
189

@navsan Could you please review?

@saketj Can you restart Travis to make sure the tests come back green.
@navsan If this looks good to you, can we close this?
Thanks!

@pateljm Thanks Jignesh. Have updated the patch and also added the performance numbers in the PR description.

It is strange that only one of the Travis build tasks for [clang++ compiler, build=release and vector_copy_ellision_level=selection] is repeatedly failing due to a compiler error.  (Reproduced below) .
The same code compiles perfectly for clang++ release (vector_copy_ellision_level=joinwithbinaryexpression) and for all configurations of g++.
I don't think it is related to changes of current PR. I tried running it multiple times, but still the same error. Does anyone else has also faced the same issue before, or might know what is causing it?

Building CXX object types/operations/comparisons/CMakeFiles/quickstep_types_operations_comparisons_GreaterComparison.dir/GreaterComparison.cpp.o
error: unable to execute command: Killed
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Ubuntu clang version 3.7.1-svn253571-1~exp1 (branches/release_37) (based on LLVM 3.7.1)
Target: x86_64-pc-linux-gnu
Thread model: posix
clang: note: diagnostic msg: PLEASE submit a bug report to http://bugs.debian.org/ and include the crash backtrace, preprocessed source, and associated run script.
clang: note: diagnostic msg:
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.cpp
clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.sh
clang: note: diagnostic msg:

The compiler is probably running out of memory. Can you try turning down
the level of parallelism?
On Mon, Oct 3, 2016, 08:48 Saket Saurabh<EMAIL_ADDRESS>wrote:

It is strange that only one of the Travis build tasks for [clang++
compiler, build=release and vector_copy_ellision_level=selection] is
repeatedly failing due to a compiler error. (Reproduced below) .
The same code compiles perfectly for clang++ release
(vector_copy_ellision_level=joinwithbinaryexpression) and for all
configurations of g++.
I don't think it is related to changes of current PR. I tried running it
multiple times, but still the same error. Does anyone else has also faced
the same issue before, or might know what is causing it?
Building CXX object
types/operations/comparisons/CMakeFiles/quickstep_types_operations_comparisons_GreaterComparison.dir/GreaterComparison.cpp.o
error: unable to execute command: Killed
clang: error: clang frontend command failed due to signal (use -v to see
invocation)
Ubuntu clang version 3.7.1-svn253571-1~exp1 (branches/release_37) (based
on LLVM 3.7.1)
Target: x86_64-pc-linux-gnu
Thread model: posix
clang: note: diagnostic msg: PLEASE submit a bug report to
http://bugs.debian.org/ and include the crash backtrace, preprocessed
source, and associated run script.
clang: note: diagnostic msg:
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.cpp
clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.sh
clang: note: diagnostic msg:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-quickstep/pull/101#issuecomment-251143502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACZB64ofKH1SUORDDVv1CF96p_rYXoTWks5qwSPBgaJpZM4KCnYW
.

LGTM. Merging. Thanks @saketj.

@saketj Next time, please squash all the commits into one before merging. Thanks!

@zuyu Thanks, sure will do that.


The bot dies when many people use commands

I limited the length of the events list to 10, disabled the pydirectinput Failsave and removed the separate window

I added Mutex to prevent possible problems with the input handler reading and writing at the same time

It works now


Add OMEMO info	 to intro-part of main page and to about.

This info IMHO has to be at the top, too. Otherwise one will read "OTR" and think: "Hmm, no OMEMO then." This was what happened to me while waiting for OMEMO support in Chatsecure.

@chrisballinger Chatsecure supports OMEMO for quite some time, but the info is still missing at teh top of the page. Would you mind merging this simple documentation change? Thanks!

Oh thanks! I must have missed this pull request.

Thanks :-)


Synfony 5 Support

Q
A

Bug?
no

New Feature?
yes

Version
N/A

Can you please tag a new release, looks like master has Symfony 5.
Thanks!


Support multiple aca-py versions

In order to facilitate performance comparisons and testing of new changes, multiple aca-py versions should be supported, handled by the implementation and selectable by the user  (see also #12 ).

AcaPy version can be configured via ./setup/.env


contributing: Add OME Files CI jobs

Drop old Bio-Formats C++ jobs and add a new page for OME Files C++ jobs.

Apart from the 2 minor comments, this renders good and fixes the broken links post shelving of the 5.1 jobs.

@sbesson Should all be fixed up now.

Staging pages updated btw

Indentation should be fixed now.

Last fix


New Rebus

Associated Issue: #
Summary of Changes

Adding a new rebus ''Pokemon"

Pull Request Test Coverage Report for Build 821

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.143%

Totals

Change from base Build 514:
0.0%

Covered Lines:
158

Relevant Lines:
180

💛  - Coveralls


Add image build steps in makefiles (with branch)

Signed-off-by: Alberto Morgante Medina<EMAIL_ADDRESS>Description
Add the possibility to build images from latest and from branch instead to fetch and clone from repo
Fixes #96
Type of change
Please select the appropriate options:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change is a documentation update

Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Test Makefile in local to make it before pushing to quay organization
[ ] Test B

Test Configuration:

Versions: linux
Hardware: x86_platform

Checklist

[X] I have performed a self-review of my own code
[ ] If a change is adding a feature, it should require a change to the README.md and the review should catch this.
[ ] If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
[ ] A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
[X] PRs should not be merged unless positively reviewed.

Pipeline passed, merging

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Access denied finding property "vendor.camera.aux.packagelist"

plz can you help me, on android when i try to publish a video i get
Access denied finding property "vendor.camera.aux.packagelist"     Access denied finding property "vendor.camera.aux.packagelist2"
thanks

Hi @hamdiwanis did you find any solution for this ? For me it is happening if app goes in pause mode then resumes again and not happening all the time it is happening randomly.


Implement proper ConsensusParams handling

Consensus params can be changed with regards to ABCI during EndBlock.  This logic is not yet ready.
Updates may be processed in a similar way as validator set updates, in updateState method.

Handled in https://github.com/rollkit/rollkit/pull/1367


RefinementList internal filters do not maintain

Description
Using  with attribute = 'category' in algolia, when creating an internal filter in it, it kept all the filters of that facet, thus being able to click on other internal filters in it and follow the logic of operator 'or', but when I changed for typesense with 'typesense-instantsearch-adapter ', when doing this same internal filter all the filters that have no results disappeared, making it impossible to do internal 'or' filtering in the RefinementList.
Is there a setting that adjusts this?
Typesense Version:
"typesense-instantsearch-adapter": "^2.8.0"

Could you elaborate on what you mean by "when creating an internal filter in it"?
If you can share a standalone repo with actual code, showing the issue, that would help.

Sorry, it was my implementation error.


Select.Item lacks an API to customize the styles of the selected state.

I'm trying to change the background of the selected item inside the bottom sheet of list items, but I can't style the item accordingly because I don't have access to the selected state of Select.Item.
I want to change the background color of the selected item or any preferred style.
Tamagui version: ^1.75.4Ï

Select take a value and onValueChange prop using that you can keep track of select item
<Select.Item value={itemValue}  bc={selectedValue === itemValue ? 'red' : 'gray' }>

@TheEhsanSarshar I need this in styled variants not as inline comparison

@TheEhsanSarshar why did you close this one?

styled is supposed to take static props while open value is tied to a specific component state and it's not possible to access it that way, although you can create an open variant and then change the style according to that
const SelectItem = styled(Select.Item, {
     open: {
          true: {
             backgroundColor: 'red'
          }
     }
})

<SelectItem open={seletedValue === itemValue} />

Hey @TheEhsanSarshar, I was looking forward to this type of solution: #1793
So I guess there is no possible way, The same question goes for Tabs component as well


Error running powershell command

I am doing this all on the On-Premise Server 2019 Data Center box that Azure AD Connect is setup on.
When running $env:programfiles"\Microsoft Azure Active Directory Connect" in PS 5, under How can I roll over the Kerberos decryption key of the AZUREADSSO computer account? I get this.
PS C:\Windows\system32> $env:programfiles"\Microsoft Azure Active Directory Connect"
At line:1 char:18

$env:programfiles"\Microsoft Azure Active Directory Connect"

             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Unexpected token '"\Microsoft Azure Active Directory Connect"' in expression or statement.
+ CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : UnexpectedToken
I already did the steps at https://docs.microsoft.com/en-us/powershell/azure/active-directory/install-adv2?view=azureadps-2.0 which I think the Connect part might want to be higher up since it states this has to be done before any of the commands here can be run.
I ran this:
$AzureAdCred = Get-Credential
Connect-AzureAD -Credential $AzureAdCred
Then this
Install-Module AzureAD
Not sure why Install-Module AzureAD comes up as coming from an unsecure location.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9eb97eff-d72e-ffa6-1365-5419e93ed82a
Version Independent ID: 5c8b677b-f4cd-0bb5-c7d6-9b1ef903dad4
Content: Azure AD Connect
Content Source: articles/active-directory/hybrid/how-to-connect-sso-faq.yml
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

Hi @rconiv,
Thanks for your feedback! We will investigate and update as appropriate.

Can you navigate to the file separately under %programfiles%\Microsoft Azure Active Directory Connect? It sounds like it's having trouble finding that file.
Can you access it with the following?
cd 'C:\Program Files\Microsoft Azure Active Directory Connect'
To update the Kerberos keys you need to follow the steps in Update the Kerberos decryption key on each AD forest that it was set it up on
There is also a related post showing a slightly different methodfor rolling over the Kerberos keys for a Seamless SSO computer account in Azure AD.
Based on the error it also sounds like the issue could be related Powershell formatting, so if you share a screenshot I will be able to better assist. https://stackoverflow.com/questions/48438231/get-parsererror-parentcontainserrorrecordexception-when-executing-pyt
If you have further questions, I also recommend posting to Microsoft Q&A since this is more of a product question than documentation feedback. https://docs.microsoft.com/answers/topics/azure-active-directory.html?filter=unanswered

I can get there using cd 'C:\Program Files\Microsoft Azure Active Directory Connect'
I posted it here since the error made it look like the PowerShell coding didn't like the first " before the \ and wanted to make sure the error wasn't due to a coding error that got published.
Update the Kerberos decryption key on each AD forest that it was set it up on is where I published this page comment from.  That is where the $env:programfiles"\Microsoft Azure Active Directory Connect" PowerShell command is.


Please provide a QA/unittest script for colorschemes.

After some discussions in #2307 and #1665 it turned out that we should have some automated quality assurance script for colorschemes. I propose a QA script that would check a colorscheme for things like:

respecting the value of background or setting
are all highlight groups defined
support for the various color modes (gui, termguicolors, 265, 16, ...)
common errors and pitfalls
etc

And returns errors and warnings.
This script could be used:

as a tool for developers of new colorschemes to validate
to unittest all existing colorschemes shipped with vim during the test pipeline so we automatically update them when for example a new highlight group was introduced.

I might look into it. Can you be a bit more specific what exactly needs to be checked? I suppose all those highlighting groups mentioned at :h highlight-groups need to be defined, right? What exactly means, respecting background setting?  What are other common errors and pitfalls?
Sorry, I did not follow the complete discussion here and the related issues.

The most important check is probably if all highlight groups are defined and if the colorscheme works with the various color modes of a terminal. If vim introduces a new highlight group, we'd only have to update that test and it will be obvious that all colorschemes need to be updated.
The background check was Bram's idea: https://github.com/vim/vim/pull/2307#issuecomment-343679634, with common errors and pitfalls I mean, that we could include tests for things that are not allowed in colorscheme definitions.

As a guy who is working for the GUIs, I'd highly appreciate it if every colorscheme would be made sure that it's free from this issue: Vim colorscheme leaves a wake of destruction when switching away.  That would absolutely help people who have to manually test several gvim's, colorschemes or various permutations of both to see if each of them works properly for its own.  Quick switching from colorscheme to colorscheme definitely matters to them.  Also, that would be welcome by the users who frequently switch their colorscheme for a change.

This is the advice I give in the help of my plugin to avoid wreakinf havoc when switching colorschemes:

Avoid defining filetype-specific highlight groups as much as possible. They
override ftplugin definitions causing highlighting to be messed up after
switching colorschemes. For example, suppose that the Vim filetype defines
vimCommand to be a link to Statement. If your colorscheme sets vimCommand's
attributes, after switching away from your colorscheme vimCommand will be
cleared, and not restored to a link to Statement as you might expect. Even
resetting the filetype will not fix that. If you link vimCommand instead, the
linking will persist after switching to another colorscheme (so, again, the
default link will not be restored), which will likely result in a different
highlighting than expected. If you absolutely need filetype-specific highlight
group definitions in your colorscheme, define an option that allows the user to
turn them on/off (the default should be off)

I'd like to hear if you have better ideas.

Christian wrote:

I might look into it. Can you be a bit more specific what exactly
needs to be checked? I suppose all those highlighting groups mentioned
at :h highlight-groups need to be defined, right? What exactly
means, respecting background setting?  What are other common errors and pitfalls?

Mainly that all important highlight groups are defined, including diff
mode, status line, etc.  And for each that both cterm and gui properties
are set.
It would be good if we have a start, we can make further improvements if
we find a colorscheme that's doing something wrong.

Sorry, I did not follow the complete discussion here and the related
issues.

Blame it on the train?  Considered moving to Switzerland?
--
Sometimes you can protect millions of dollars in your budget simply by buying
a bag of cookies, dropping it on the budget anylyst's desk, and saying
something deeply personal such as "How was your weekend, big guy?"
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I am sitting in a train again (and no, moving to Switzerland is no alternative):
How about the following check script: https://gist.github.com/chrisbra/5c6fae340dbae1471f281258fee110fa

Nice! I had a quick try, and I have some issues:

I get Should not issue :syn on, although my colorschemes do not use syn on. The snippet in my colorschemes is:

if exists('syntax_on')
  syntax reset
endif

I get init: No initialization: what does that mean?

I get t_Co: Does not check terminal for capable colors, although my colorschemes do check t_Co. This is the snippet I use in my colorschemes:

if !(has('termguicolors') && &termguicolors) && !has('gui_running')
      \ && (!exists('&t_Co') || &t_Co < 256)
  echoerr '[Dark] There are not enough colors.'
  finish
endif

I get No highlight group definition for… for all the highlight groups checked by the script, although they are all defined.

I get Normal: Missing background color for Normal, although Normal has a defined background color. RE this point, a colorscheme may use a transparent background, possibly conditional to a user's setting. E.g., in my colorschemes you find:

if !has('gui_running') && get(g:, 'dark_transp_bg', 0) " Do not define a background color
  hi Normal ctermfg=255 ctermbg=NONE guifg=#ebebeb guibg=NONE guisp=NONE cterm=NONE gui=NONE
  " Possibly other highlight groups with ctermbg and guibg set to NONE
else
  hi Normal ctermfg=255 ctermbg=16 guifg=#ebebeb guibg=#000000 guisp=NONE cterm=NONE gui=NONE
  " ...
endif

Christian wrote:

I am sitting in a train again (and no, moving to Switzerland is no
alternative):
How about the following check script:
https://gist.github.com/chrisbra/5c6fae340dbae1471f281258fee110fa

Thanks for getting this started.
A header is missing, I suppose we can figure out later how to use this
script.  For now I assume it's to be sourced when editing a color
scheme.
It warns for setting 'background', but that is OK, so long as it's
before any highlight commands.  The rule is that the script either sets
'background' (when it defines the Normal background color) or respects
it (contains a check for the 'background' value).
LineNr: Missing background color for LineNr
I don't think it is needed to check for setting background. Using the
default background should be OK.  When ctermbg is used there should
probably also be a guibg entry.  Not sure about the other way around.
There will be some warnings that are known to happen.  E.g. checking
default.vim most groups are missing. Perhaps we can supporess known
warnings?  We could do:
finish

" @suppress Visual: No highlight definition for Visual
" @suppress Title: No highlight definition for Title

This avoids having to check the output for new errors/warnings.
--
hundred-and-one symptoms of being an internet addict:
84. Books in your bookcase bear the names Bongo, WinSock and Inside OLE
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I suggest to run this test in the testsuite for all color schemes  in runtime/colors -- this way we'll get automatic checking when someone provides a pull request for a new color scheme.

I get Should not issue :syn on, although my colorschemes do not use syn on. The snippet in my colorschemes is:

The script searches for:  syn\%[tax]\s\+on Do you have that somewhere perhaps in a comment?

if exists('syntax_on')
syntax reset
endif

shouldn't match

I get init: No initialization: what does that mean?

It means you are missing this block https://gist.github.com/chrisbra/5c6fae340dbae1471f281258fee110fa#file-check_colors-vim-L61-L65:
hi clear
if exists("syntax_on")
  syntax reset
 endif

I get t_Co: Does not check terminal for capable colors, although my colorschemes do check t_Co. This is the snippet I use in my colorschemes:

if !(has('termguicolors') && &termguicolors) && !has('gui_running')
\ && (!exists('&t_Co') || &t_Co < 256)
echoerr '[Dark] There are not enough colors.'
finish
endif

Yeah, this is an error. It only checks for &t_Co >= https://gist.github.com/chrisbra/5c6fae340dbae1471f281258fee110fa#file-check_colors-vim-L56
I should loosen that one.

I get No highlight group definition for… for all the highlight groups checked by the script, although they are all defined.

Can you share the script?

I get Normal: Missing background color for Normal, although Normal has a defined background color. RE this point, a colorscheme may use a transparent background, possibly conditional to a user's setting. E.g., in my colorschemes you find:

Yes, I thought, if it would make sense to check for the background color. Bram has mentioned a similar point. So perhaps we should remove it.

if !has('gui_running') && get(g:, 'dark_transp_bg', 0) " Do not define a background color
hi Normal ctermfg=255 ctermbg=NONE guifg=#ebebeb guibg=NONE guisp=NONE cterm=NONE gui=NONE

I'd like to have a check for variables that should be documented somewhere. However I don't know how to check that.

Bram wrote:

A header is missing, I suppose we can figure out later how to use this
script.  For now I assume it's to be sourced when editing a color
scheme.

correct.

It warns for setting 'background', but that is OK, so long as it's
before any highlight commands.  The rule is that the script either sets
'background' (when it defines the Normal background color) or respects
it (contains a check for the 'background' value).

I'll add a check that no :hi  command comes before the :set bg line, not sure how to test the second part (contains a check for background value).

LineNr: Missing background color for LineNr
I don't think it is needed to check for setting background. Using the
default background should be OK.  When ctermbg is used there should
probably also be a guibg entry.  Not sure about the other way around.

okay, will change it.

There will be some warnings that are known to happen.  E.g. checking
default.vim most groups are missing. Perhaps we can supporess known
warnings?  We could do:
finish
" @suppress Visual: No highlight definition for Visual
" @suppress Title: No highlight definition for Title
This avoids having to check the output for new errors/warnings.

Not sure what you are suggest here, you mean skip the check, if a line @suppress group is present?

I suggest to run this test in the testsuite for all color schemes in runtime/colors -- this way we'll get automatic checking when someone provides a pull request for a new color scheme.

Makes sense. However lets first get the check script into shape so that it is actually usable for any colorscheme.

Okay version 2 of the script: https://gist.github.com/chrisbra/5c6fae340dbae1471f281258fee110fa
Changes:

short header on how to use the script
check that when a background color is given it should be available for gui and terminal
checks only for a defined foreground color for selected groups
check that there is no :hi  command before a :set bg command (except for :hi clear)
check for t_Co [<>=] number
Skip checks for @suppress groupname

The script searches for: syn%[tax]\s+on Do you have that somewhere perhaps in a comment?

Mmh, no.

Can you share the script?

Solarized 8 is a relatively complex one (dark and light background, ANSI and 256 colors, in the same file). It is generated by my Colortemplate plugin. Other examples are in the colors folder of that plugin.

This line:
if search('hi \U\w\+\s\+\S', 'cbnW')

matches a line of the form License: This file is placed in the public domain.

Sorry, forget that. I need some sleep.

Solarized 8 is a relatively complex one (dark and light background, ANSI and 256 colors, in the same file).

I do not get the output Should not issue :syn on Other then that, I only get the error about not checking t_Co (where the test is questionable) and that some filetype specific highlighting groups are defined like vimCommand which shouldn't be defined I thought.

I made some slight changes to the script again (e.g. skipping the if  for the &t_Co test).

Christian wrote:

There will be some warnings that are known to happen.  E.g. checking
default.vim most groups are missing. Perhaps we can supporess known
warnings?  We could do:
finish

" @suppress Visual: No highlight definition for Visual
" @suppress Title: No highlight definition for Title

This avoids having to check the output for new errors/warnings.

Not sure what you are suggest here, you mean skip the check, if a line
@suppress group is present?

You would first create a list with all the error messages.  And along
the way also collect messages after @suppress.  Then in the end, before
producing the list of warnings and errors, filter out the suppressed
messages.
So when I write a color script, run the check script, see the errors and
think "that's OK", then I can suppress those warnings.  So the next time
I check I only see new warnings, not the ones that I deemed are OK.
For others, they can see what warnings will be ignored.  Eventually it
would be possible to run the check script over the distributed color
schemes.
--
From "know your smileys":
¯_(ツ)_/¯   Shrug
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Has check_colors.vim been removed from Vim? The file $VIMRUNTIME/colors/Readme.txt still mentions it, but I do not seem able to find it.

@lifepillar it has been moved to the tools subdirectory:
(check_colors.vim)[https://github.com/vim/vim/blob/master/runtime/colors/tools/check_colors.vim]

So, maybe it depends on my Vim version (8.0.1750, installed with Homebrew in macOS), because it's not there.

I can confirm that it's not present in Homebrew's "bottle" for vim; in fact, it's missing the "tools" subdirectory of colors altogether.  That's a bug in Homebrew, and they should be notified.

It is actually not being installed at all. Not sure where to put the check script, something like this perhaps:
diff --git a/src/Makefile b/src/Makefile
index d15a2dc76..bbdb9bbba 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -2484,7 +2484,8 @@ installrtbase: $(HELPSOURCE)/vim.1 $(DEST_VIM) $(DEST_RT) \
        cd $(PRINTSOURCE); $(INSTALL_DATA) *.ps $(DEST_PRINT)
        cd $(DEST_PRINT); chmod $(FILEMOD) *.ps
 # install the colorscheme files
-       cd $(COLSOURCE); $(INSTALL_DATA) *.vim README.txt $(DEST_COL)
+       cd $(COLSOURCE); $(INSTALL_DATA) *.vim tools/*.vim README.txt $(DEST_COL)
+       cd $(COLSOURCE); $(INSTALL_DATA) tools/*.vim $(DEST_TOOLS)
        cd $(DEST_COL); chmod $(HELPMOD) *.vim README.txt
 # install the syntax files
        cd $(SYNSOURCE); $(INSTALL_DATA) *.vim README.txt $(DEST_SYN)

That would install below $VIMRUNTIME/tools.

(patch was slightly wrong, re-edited the previous comment)

Alternatively, we could install it into the colorscheme directory directly:
diff --git a/src/Makefile b/src/Makefile
index d15a2dc76..f40f31ce7 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -2484,7 +2484,7 @@ installrtbase: $(HELPSOURCE)/vim.1 $(DEST_VIM) $(DEST_RT) \
        cd $(PRINTSOURCE); $(INSTALL_DATA) *.ps $(DEST_PRINT)
        cd $(DEST_PRINT); chmod $(FILEMOD) *.ps
 # install the colorscheme files
-       cd $(COLSOURCE); $(INSTALL_DATA) *.vim README.txt $(DEST_COL)
+       cd $(COLSOURCE); $(INSTALL_DATA_R) *.vim tools README.txt $(DEST_COL)
        cd $(DEST_COL); chmod $(HELPMOD) *.vim README.txt
 # install the syntax files
        cd $(SYNSOURCE); $(INSTALL_DATA) *.vim README.txt $(DEST_SYN)

As long as the script itself doesn't go directly in colors.