SQL Server support?

According to the "applies to" section at the top of the page this feature is only available in Azure SQL Database and Azure SQL Managed Instance.
However, the description shows it's also available for SQL Server 2012+ in Azure VMs.
Can you please update the article to provide clarity?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c7eb289f-1abb-3254-b1c1-3b2fa20eddc7
Version Independent ID: ffa6089a-4cc1-a7fe-b631-c15180941629
Content: Monitor your SQL deployments with SQL Insights (preview) - Azure SQL Database
Content Source: azure-sql/database/sql-insights-overview.md
Service: sql-db-mi
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

@VitalyMCT
Thanks for your feedback! We will investigate and update as appropriate.

Hi @WilliamDAssafMS,
Could you please look into this document update where "Applies To" section needs to be updated as according to the description under "Supported Version"

Hi @VitalyMCT! Thanks for taking the time to provide this feedback on our Docs. You are correct, and this change has been implemented. Great catch! Your suggestions help improve our documentation.
#please-close


python311Packages.cyclonedx-python-lib: 6.3.0 -> 6.4.0

Diff: https://github.com/CycloneDX/cyclonedx-python-lib/compare/refs/tags/v6.3.0...v6.4.0
Changelog: https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v6.4.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 283273 run on x86_64-linux 1

8 packages built:

checkov
checkov.dist
pip-audit
pip-audit.dist
python311Packages.cyclonedx-python-lib
python311Packages.cyclonedx-python-lib.dist
python312Packages.cyclonedx-python-lib
python312Packages.cyclonedx-python-lib.dist


Add support for Net Standard 2.0

When I attempt to bring this package into a .netstandard Xamarin application, I get errors around the platform not being supported.  This made sense once I looked at the fact the only valid targets are net45 and netcoreapp3.0.
I resolved this issue by adding a netstandard2.0 target.
I also added a sample application that mirrors the current samples and shows Prism logging written to a Serilog Sink.

Awesome contribution @RLittlesII! Thank you for going the extra mile and implementing the demo projects too!


Add accounts to list of addresses to send Ark to

When sending Ark, the list of addresses/names that popup now shows your accounts and contacts, not just contacts. They are also sorted by account label / contact name.
Partially addresses #368

Sounds good! +5 👍🏻


The last letter is cut off in motionlayout

with the demo of https://developer.android.com/training/constraint-layout/motionlayout/examples#coordinatorlayout_12
it shows different display styles.
in 2.1.0-beta01, it shows like that:

in 2.0.1:

it's very strange that the last letter was dropped.

any progress？

Maybe related to #232?

2.1 fixed


Literally taking one minute to render on Android

The library is nice but it takes too much time to render on Android.
Any solutions?

I have this problem too.


ec/asm/x25519-x86_64.pl: remove redundant carry chain.

Why is it redundant? We're looking at carry from addition of small,
11-bit number to 256-bit one. And carry would mean only one thing,
first limb being small number and remaing ones - zeros. Hence adding
38 to first limb can't carry.

Improvement is 6% on Ryzen and 2-3% on Intel. 6% difference on Ryzen is "pathologically" large, but that's one of the things assembly programming is about, working around "pathologies". At times you hit a trade-off, i.e. something that is good for one processor is not so good for another. For example, in this module Bulldozer result is actually such trade-off, it's possible to improve it, but it hurts few others. But as long as it's improvement on all [involved] processors, it's to be judged by highest coefficient, 6% in this case :-)


Fix the computation of knot multiplicity (issue #10)

The for-loop counting the same knot values did not use its incremented value. The for-loop was also updated accordingly to not exceed the vector size. Finally, since the loop counts the number of relations (and not occurrences), the multiplicity is initialized to 1.

Looks great. Thanks for the PR!
I will start adding proper unit tests when I get some time.


Error building under Arch Linux

I'm currently getting Unknown option -lm when trying to build under Arch Linux. Full output below:
mick@mick-pc ~/D/xi-gtk (master)> mkdir build
mick@mick-pc ~/D/xi-gtk (master)> cd build/
mick@mick-pc ~/D/x/build (master)> meson ..
The Meson build system
Version: 0.41.0
Source dir: /home/mick/Development/xi-gtk
Build dir: /home/mick/Development/xi-gtk/build
Build type: native build
Project name: xi-gtk
Native c compiler: cc (gcc 7.1.1)
Native vala compiler: valac (valac 0.36.3)
Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Native dependency gtk+-3.0 found: YES 3.22.15
Native dependency json-glib-1.0 found: YES 1.2.8
Native dependency gio-unix-2.0 found: YES 2.52.2
Library m found: YES
Native dependency glib-2.0 found: YES 2.52.2
Build targets in project: 3
mick@mick-pc ~/D/x/build (master)> ninja
[1/16] Compiling Vala source ../src/Application.vala ../src/Blinker.vala ../src/CoreConnectio...otebook.vala ../src/Style.vala ../src/StyleMap.vala ../src/Utilities.vala ../src/Window.vala.
FAILED<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>valac -C --debug -lm --pkg gio-unix-2.0 --pkg json-glib-1.0 --pkg gtk+-3.0 -d xi-gtk@exe --gresources=../resources/gresource.xml ../src/Application.vala ../src/Blinker.vala ../src/CoreConnection.vala ../src/EditView.vala ../src/Line.vala ../src/LineCache.vala ../src/Notebook.vala ../src/Style.vala ../src/StyleMap.vala ../src/Utilities.vala ../src/Window.vala
Unknown option -lm
Run 'valac --help' to see a full list of available command line options.
[3/16] Generating resources_c with a custom command.
ninja: build stopped: subcommand failed.
mick@mick-pc ~/D/x/build (master) [1]> valac --version
Vala 0.36.3
mick@mick-pc ~/D/x/build (master)> uname -r
4.11.3-1-ARCH
mick@mick-pc ~/D/x/build (master)> lsb_release -a
LSB Version:    1.4
Distributor ID: Arch
Description:    Arch Linux
Release:        rolling
Codename:       n/a

Have had a bit of a search around valac and -lm but I can't actually see the flag documented as one or as separate character flags.

This seems to be a regression with Meson version 0.41.0

See mesonbuild/meson#1939

I've just confirmed that's the version I'm on:
mick@mick-pc ~/D/b/acquire (master)> meson -v
0.41.0

See mesonbuild/meson#1939

Looks like it, shall we close this issue?

Let's keep this issue open until the problem is fixed in Arch.

Just tested and builds fine now 👍
The frontend is looking great by the way, keep up the great work!

Thanks for the kind words :)


[Feature] Add a Minesweeper Game

Is your feature request related to a problem? Please describe.
I often find myself frustrated when I need a quick and engaging activity to pass time while on the website. A game like Minesweeper would provide a fun and mentally stimulating option for users who need a short break or want to challenge their problem-solving skills.
Describe the solution you'd like
I would like to see a classic Minesweeper game added to the website. The game should have a user-friendly interface, customizable difficulty levels (e.g., beginner, intermediate, expert), and should be easily accessible from the main navigation menu. The game should include features such as a timer, a counter for the number of mines, and the ability to flag suspected mines.
Additional context
Adding a Minesweeper game could increase user engagement and time spent on the website, offering a quick mental break and a reason to return to the site more frequently. Including high score tracking or a leaderboard could further incentivize users to play and improve their skills.
What problem is this feature trying to solve?
This feature aims to provide users with an engaging and quick activity to enjoy during their time on the website. It addresses the need for short breaks and mental stimulation, enhancing the overall user experience.
I would be really thankful if you assign me this issue as a part of GSSoC'24 .

Already added to my repository #187. Closing this


In the Drag-and-Drop plugin, add the possibility to copy an event by pressing  when we drag it

Is your feature request related to a problem? Please describe.
When we drag an event, it is frustrated to not be able to copy it. The only possibility is to move it
Describe the solution you'd like
Pressing the crtl key when we drag an event should duplicate the event.
Additional context
Things that could speed up the process

[ ] I can picture implementing at least parts of this feature
[X] I believe I know how to do this, and am willing to implement the whole thing.
[ ] I have a Schedule-X premium license

On Outlook, it like like that: We drag to move an event and press ctrl key to copy it.
If we use crtl+v, we'll have to open a modal window to allow the user to set the dates. I don't like this very much.
My vision is the following:

for quick copy/duplication, use the mouse/touch and the crtl key in day/week/month view
if you need more (change title, description or copy outside the current view), use the event's modal window with a duplicate button 'à la' Google calendar

While I'm not adding any insight or opinion to this issue, I just want to say that this QoL feature would be fantastic. Hopefully this is something truly considered as I'd find use from it as well!

Closing this due to breaking changes added in the PR. Would be open to a PR that does not introduce any breaking changes


Image Compression Performance Time

Question about an existing feature
What are you trying to achieve?

I have a list of images that I can not reduce its size when storing, so I need to reduce it on demand when I receive the request to generate a report.
These images are usually at least 2mb each but can go up higher.
So what I need to do is "compress" the image's total size without losing too much of the quality and having it remain the same visual size.
PS: This is doing as expected, its just taking a long time and I was wondering if I could be doing something wrong with the code.

When you searched for similar issues, what did you find that might be related?

I didn't find anything related

Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question

The canvas here is my "image", it is in svg format

    const compressCanvasPromise = sharp(canvas.toBuffer())
      .resize(1500)
      .trim(10)
      .jpeg({
        mozjpeg: true,
      })
      .toBuffer()
      .then((data) => `data:image/jpeg;base64, ${data.toString('base64')}`);

Then after I have these promises I will execute them with Promise.all() to run them in parallel.

await Promise.all(
    data.map((sheet) => sheet.compressCanvasPromise),
  ).then((arrOfImages) =>
    arrOfImages.forEach((image, index) => (data[index].image = image)),
  );

Please provide sample image(s) that help explain this question

I saw that the sharp lib already uses background threads, I even tried adding my own threads but it didn't improve any performance since this is already being done.
I know that everything in programming hits a limit, so if there is no room for me to improve my code, I guess it's okay since there is not much to be done in that case anyways. There is the natural limitation that the bigger the image the longer it will take to compress.
BTW, congrats on this lib, it is really awesome to work with :)

Enabling the mozjpeg features will slow things down quite a bit, so that's probably the first thing to remove if greater performance is required.

I see, I had done that because of the size since it seems like it brings the size a little more down. I have a performance x size problem.
Is there any better way of resizing an image that I might have missed?

@lovell do you know if the mozjpeg  slows down exponentially?  I ran with 5 images and it didn't seem to change too much the time.
Let me share the results
{
  "timeOfExecutionInSeconds-WITH-MOZJPEG": 12.719,
  "timeOfExecutionInSeconds-WITHOUT-MOZJPEG": 12.09,
  "image1": {
    "compressedWithMozjpegSizeInKb":<PHONE_NUMBER>2416655,
    "compressedSizeInKb":<PHONE_NUMBER>2983915,
    "originalSizeInKb":<PHONE_NUMBER>172168
  },
  "image2": {
    "compressedWithMozjpegSizeInKb":<PHONE_NUMBER>519987,
    "compressedSizeInKb":<PHONE_NUMBER>9087746,
    "originalSizeInKb": 1185.3456543373695
  },
  "image3": {
    "compressedWithMozjpegSizeInKb": 97.22520816055732,
    "compressedSizeInKb":<PHONE_NUMBER>7628134,
    "originalSizeInKb":<PHONE_NUMBER>27003
  },
  "image4": {
    "compressedWithMozjpegSizeInKb":<PHONE_NUMBER>9087746,
    "compressedSizeInKb":<PHONE_NUMBER>0140987,
    "originalSizeInKb": 1062.052426604744
  },
  "image5": {
    "compressedWithMozjpegSizeInKb": 46.920635262896006,
    "compressedSizeInKb": 62.26085254602754,
    "originalSizeInKb":<PHONE_NUMBER>036822
  }
}

I've made a bunch of other tests here with more images, (10, 15, and 30 images) and the diff in time between having or not having the mozjpeg: true is acceptable. In 30 sheets it takes 10s more
Based on the amount of size if reduces with that option I would say the extra time is acceptable.
Other than this would there be anything else I could try?

If you need further help, perhaps you could provide a complete, standalone repo with all code and images that allows someone else to reproduce the same results as you.

Sure, I will do that. I'll send the link as soon as I get it ready

Hi @lovell sorry for the delay in giving feedback to you, the link to the repo with the code is https://github.com/melogustavo/compress-image.
I have done something similar to what I'm doing on the real project, which is getting an image, drawing something on it using canvas, and then compressing it. At first sight, it seems like the processing time is okay, but on the real project, the images are a lot bigger.
Like I said in the beginning, I know that sometimes we get into the limitation of the software/hardware, so maybe my code is already close to the best it can be and the problem is just that there it hit the natural limit, so I would just love feedback to see if there is any room for improvment. Thanks alot :)

Thanks, the majority of the processing time is spent on the trim() operation.

I see, thank you @lovell for the feedback. In my case, I do need this or the image has some lines on the generated final image (when I put it in a PDF).

If you're using a CPU with more than 4 cores, try setting UV_THREADPOOL_SIZE to match the number of cores for potentially increased parallelism.
https://sharp.pixelplumbing.com/api-utility#concurrency

Yeah, that sounds like the remaining plan for this. Thanks again. I'm gonna close this issue :)


winSplitViewCommand with PNG Icon

Hey there,
How can I use png icons in the SplitView?
I tried with:

Where FontIcon() is a KnockoutObservable<string> with a url for png or just the icons enum name like "home" for the rest.
Thanks for your time!

stale means it was fixed or it can't be done? :smile:
I tried with the new version and still the same problem


Refactoring influxql package to enable golint

Cleaned up the influxql package so that there are no errors when running golint. Mainly this meant adjusting and/or adding comments, but also involved changing some variable names as you can see below.

[x] CHANGELOG.md updated
[x] Rebased/mergable
[x] Tests pass
[x] Sign CLA (if not already signed)

@gabelev Can you rebase?

@jwilder rebased.

A couple of small things, but looks good.

@jwilder: awesome, thanks. made the changes. Also added my credit to a previous merge I had in the changelog as well.

@gabelev Can you remove the is an exported method that from the those two Godocs?  All set to merge after that.

whoops. must have gotten caught up in the rebase. ok. done.
thanks!

@jwilder: is this ok to merge?

LGTM.  @benbjohnson

@benbjohnson: Cool. I made those two comments a little more helpful/descriptive in this latest patch.

:+1:


Inconsistent include path load/readDocumentStructure

There is a inconsistency on including files by using asciidoctor.load and asciidoctor.readDocumentStructure.
If i use asciidoctor.load to get a string (line based reading) converted to a Document, then i have to define the include path relative from the base of my project.
But if i use  asciidoctor.readDocumentStructure to convert a file to a StructuredDocument, then i have to define the include path relative to the directory where the given file is located.
The project is maven based and is using version 1.5.4 of asciidoctorj.
// Example for asciidoctor.load:
String lines = "";
String tmpString = "";
if (file.canRead())
{
System.out.println("File: " + file + " is readable");
try {
FileReader fileReader = new FileReader(file);
	BufferedReader bufferedReader = new BufferedReader(fileReader);

	while( (tmpString = bufferedReader.readLine()) != null )
	{
		lines = lines + "\n" + tmpString;
	}
	bufferedReader.close();
} catch (FileNotFoundException e) {
	// TODO Auto-generated catch block
	e.printStackTrace();
} catch (IOException e) {
	// TODO Auto-generated catch block
	e.printStackTrace();
}

}
Document document = asciidoctor.load(lines, options);
// Example for asciidoctor.readDocumentStructure:
Map<String, Object> structOptions = new HashMap<String, Object>();
// STRUCTURE_MAX_LEVEL notwendig, da sonst nicht komplette Dokumentenstruktur gelesen wird
structOptions.put(Asciidoctor.STRUCTURE_MAX_LEVEL, 50);
structOptions.put("attributes", attributes);
structOptions.put("in_place", true);
structOptions.put("header", true);
structOptions.put("footer", true);
structOptions.put("safe", 0);
StructuredDocument structuredDocument = asciidoctor.readDocumentStructure(file, structOptions);

Hi Axel,
I don't know if I understood you correctly, so please let me rephrase your problem.
You load a document in two ways and see that different include paths are used:

you pass some String content to Asciidoctor.load(). There's no hint where this content is coming from.
you pass a java.io.File  to Asciidoctor.readDocumentStructure().

If I understood you correctly, I think there is no inconsistency!
In the first case Asciidoctor only gets some String content, that could come from a file, but could come from anywhere else as well, like being the result of a computation.
So Asciidoctor can make no assumption on where included files could be lying around.
In the second case Asciidoctor knows where the file is coming from and can set for example the docdir attribute. IMO it is very elegant that you can refer to included documents that are in the same directory without configuring any include paths or whatever.
Another point I'd like to mention, but that has nothing to do with the difference you are seeing, is that you are using two different types of APIs the Asciidoctor interface offers:

You can load and convert files via Asciidoctor.load, convert etc. These method directly go to there Asciidoctor Ruby equivalents.
The method Asciidoctor.readDocumentStructure goes a bit further: It loads the document the same way the methods above do, but then analyzes the returned document in Java and provide a document structure that gives another view on this document via the StructuredDocument classes.

Also keep in mind that the plan for 1.6 (as I remember it) is that we are folding the readDocumentStructure functionality back into load so that we don't have two competing APIs. We weren't able to accomplish this before 1.6 because we needed to have a more complete AST onto which the nodes can map. That's a large part of the work Robert has done on 1.6 and something very exciting to look forward to.

In the first case Asciidoctor only gets some String content, that could come from a file, but could come from anywhere else as well, like being the result of a computation. So Asciidoctor can make no assumption on where included files could be lying around.

Exactly. When working with String content, it's always a good idea to set the base_dir option. This tells Asciidoctor where the root is. Otherwise, it falls back to the current working directory, which is not something you really want to rely on.

Ok,
then there is no problem.
I was only using the load() because the problem of loadFile (#434) ;-).
Thanks.


Reorganize into easier directories; add .help() quick reference.

Files were scattered in a slightly weird way. This pull request reorganizes into directories organized by what the outputs of the method are: actions/ make rainbows, wavelike_summaries/ make summaries of quantities with one per wavelength, and visualizations/ make visualizations.
This also adds a small .help() function that gives a quicker summary of what functions are available than having to scroll through all the docstrings. The user can now call r = Rainbow(); r.help() to get something like the following:
Hooray for you! You asked for help on what you can do with this 🌈 object.
Here's a quick reference of a few available options for things to try.

-----------
| actions |
-----------

🌈🧺🧱 | .bin()                       | Bin to a new wavelength or time grid.
🌈🫓😑 | .normalize()                 | Normalize by dividing through by a typical spectrum (and/or light curve).
🌈🍱💇 | .trim()                      | Trim away wavelengths or times that contain no good data.
🌈🚧🌊 | .align_wavelengths()         | Align spectra with different wavelength grids onto one shared axis.
🌈🧮📝 | +                            | Add two Rainbows together.
🌈🧮📝 | -                            | Subtract one Rainbows from another.
🌈🧮📝 | *                            | Multiply two Rainbows together.
🌈🧮📝 | /                            | Divide one Rainbows by another.

------------------
| visualizations |
------------------

🎨🖌📺 | .imshow()                    | Paint a map of flux across wavelength and time.
🎨🖌🧶 | .plot()                      | Plot a sequence of light curves with vertical offsets.
🎨📽⏰ | .animate_lightcurves()       | Animate a sequence of light curves across different wavelengths.
🎨📽🌊 | .animate_spectra()           | Animate a sequence of spectra across different times.
🎨🗂📺 | .imshow_quantities()         | Show multiple 2D (wavelength and time) quantities as imshow maps.
🎨🗂🧶 | .plot_quantities()           | Show multiple 1D (wavelength or time) quantities as scatter plots.

----------------------
| wavelike_summaries |
----------------------

🌊🔭🌈 | .get_spectrum()              | Get the median spectrum.
🌊💎🌈 | .get_spectral_resolution()   | Get the spectral resolution (R=w/dw).
🌊🃏🌈 | .get_typical_uncertainty()   | Get the typical uncertainty for each wavelength.

@will-waalkes , this is relevant for the .shift function you're working on. Once you write it, you should add an appropriate line to chromatic/rainbows/actions/descriptions.txt so it shows up in this help.


Configure Dependabot using a YAML config file

Description

For this repository, Dependabot is enabled but not configured. Adding a .github/dependabot.yml file should fix that. Using the file we can configure things like the update schedule and the labels to attach to the PRs made by Dependabot.
Expectation

Dependabot should make regular, well-labeled PRs to the repository.
Additional context

You can use the config from the API repo as a reference. Also see the GitHub docs describing this config file.
Resolution

[ ] 🙋 I would be interested in resolving this bug.

Part of the reason we don't have dependabot set up on this repo is that Airflow is very particular about its dependencies. So much so that the installation instructions from PyPI specifically describe using the provided constraints file for a given version. This constraints file dictates all of the dependencies that Airflow interacts with; it does not pin dependencies for everything available in PyPI. I think we can look into using dependabot here, but we might need to restrict it to only the dev dependencies (or even just a subset of our dependencies) as it's likely that the versions dependabot suggests will conflict with the provided constraints file.

Unassigning myself from this issue because I'm not sure how to proceed. We are using Renovate for the other repositories now. Should we close this issue altogether?


Poor reception with RFM69HWC

I'm running example scripts with an RFM69HWC. The code works but I am getting only intermittant reception with communication between two radios running on modified M0 arduinos. When I use the radiohead library reception is perfect (so the hardware is OK). But I would prefer to use plainRFM69 so I can have control over interrupts. I just can't figure out what I need to do to get the transmission to work properly. I've got a high power version of the radio, and I've tried several variations on rfm.setTxPower(14, true), but there's no effect on reception. I will note that touching one of the antennas improves reception, which imples hardware issues. But again, everything works with the example scripts in radiohead. I'm just wondering if there's some incompatibility with RFM69HWC that I'm unaware of.

Which frequency of chip? I wonder if you run into https://github.com/iwanders/plainRFM69/pull/13  I never got word back from testing of that, but an overflow in the frequency could affect the results. Can you try that branch?

I'm using 434mHz modules, so a 32bit overflow is probably not the issue.

By the way, thanks for responding....
I pulled out all the RFM69 registers from a plainRFM69 script and from radiohead (see below). There might be a clue among the differing registers. For instance, I was surprised to see the carrier frequency bytes (RegFrf...) were different. I'm not sure I have time to parse all of these registers out, but I suspect the difference in performance is explained in there somewhere.
PlainRFM69     |   Radiohead       |  register description
reg no: value     reg no: value.       reg no, name, defaults, description
0x0: 0x0 | 0x0: 0x0 | 0x00 RegFifo 0x00 FIFO read/write   access
0x1: 0x10 | 0x1: 0x4 | 0x01 RegOpMode 0x04 Operating modes of the transceiver
0x2: 0x0 | 0x2: 0x1 | 0x02 RegDataModul 0x00 Data operation mode and Modulation   settings
0x3: 0x1A | 0x3: 0x0 | 0x03 RegBitrateMsb 0x1A Bit Rate setting, Most Significant   Bits
0x4: 0xB | 0x4: 0x80 | 0x04 RegBitrateLsb 0x0B Bit Rate setting, Least Significant   Bits
0x5: 0x0 | 0x5: 0x10 | 0x05 RegFdevMsb 0x00 Frequency Deviation setting, Most   Significant Bits
0x6: 0x52 | 0x6: 0x0 | 0x06 RegFdevLsb 0x52 Frequency Deviation setting, Least   Significant Bits
0x7: 0x6C | 0x7: 0x6C | 0x07 RegFrfMsb 0xE4 RF Carrier Frequency, Most Significant   Bits
0x8: 0x90 | 0x8: 0x80 | 0x08 RegFrfMid 0xC0 RF Carrier Frequency, Intermediate Bits
0x9: 0x2 | 0x9: 0x0 | 0x09 RegFrfLsb 0x00 RF Carrier Frequency, Least Significant   Bits
0xA: 0x41 | 0xA: 0x41 | 0x0A RegOsc1 0x41 RC Oscillators Settings
0xB: 0x40 | 0xB: 0x40 | 0x0B RegAfcCtrl 0x00 AFC control in low modulation index   situations
0xC: 0x2 | 0xC: 0x2 | 0x0C Reserved0C 0x02 -
0xD: 0x92 | 0xD: 0x92 | 0x0D RegListen1 0x92 Listen Mode settings
0xE: 0xF5 | 0xE: 0xF5 | 0x0E RegListen2 0xF5 Listen Mode Idle duration
0xF: 0x20 | 0xF: 0x20 | 0x0F RegListen3 0x20 Listen Mode Rx duration
0x10: 0x24 | 0x10: 0x24 | 0x10 RegVersion 0x24
0x11: 0x9F | 0x11: 0x7F | 0x11 RegPaLevel 0x9F PA selection and Output Power control
0x12: 0x9 | 0x12: 0x9 | 0x12 RegPaRamp 0x09 Control of the PA ramp time in FSK mode
0x13: 0x1A | 0x13: 0x1A | 0x13 RegOcp 0x1A Over Current Protection control
0x14: 0x40 | 0x14: 0x40 | 0x14 Reserved14 0x40 -
0x15: 0xB0 | 0x15: 0xB0 | 0x15 Reserved15 0xB0 -
0x16: 0x7B | 0x16: 0x7B | 0x16 Reserved16 0x7B -
0x17: 0x9B | 0x17: 0x9B | 0x17 Reserved17 0x9B -
0x18: 0x88 | 0x18: 0x8 | 0x18 RegLna 0x08 0x88 LNA settings
0x19: 0x55 | 0x19: 0xE0 | 0x19 RegRxBw 0x86 0x55 Channel Filter BW Control
0x1A: 0x8B | 0x1A: 0xE0 | 0x1A RegAfcBw 0x8A 0x8B Channel Filter BW control during the   AFC routine
0x1B: 0x40 | 0x1B: 0x40 | 0x1B RegOokPeak 0x40 OOK demodulator selection and control in   peak mode
0x1C: 0x80 | 0x1C: 0x80 | 0x1C RegOokAvg 0x80 Average threshold control of the OOK   demodulator
0x1D: 0x6 | 0x1D: 0x6 | 0x1D RegOokFix 0x06 Fixed threshold control of the OOK   demodulator
0x1E: 0x10 | 0x1E: 0x10 | 0x1E RegAfcFei 0x10 AFC and FEI control and status
0x1F: 0x0 | 0x1F: 0x0 | 0x1F RegAfcMsb 0x00 MSB of the frequency correction of the AFC
0x20: 0x0 | 0x20: 0x0 | 0x20 RegAfcLsb 0x00 LSB of the frequency correction of the AFC
0x21: 0x0 | 0x21: 0x0 | 0x21 RegFeiMsb 0x00 MSB of the calculated frequency error
0x22: 0x0 | 0x22: 0x0 | 0x22 RegFeiLsb 0x00 LSB of the calculated frequency error
0x23: 0x0 | 0x23: 0x2 | 0x23 RegRssiConfig 0x02 RSSI-related settings
0x24: 0xBE | 0x24: 0xFF | 0x24 RegRssiValue 0xFF RSSI value in dBm
0x25: 0x0 | 0x25: 0x0 | 0x25 RegDioMapping1 0x00 Mapping of pins DIO0 to DIO3
0x26: 0x5 | 0x26: 0x5 | 0x26 RegDioMapping2 0x05 0x07 Mapping of pins DIO4 and DIO5,   ClkOut frequency
0x27: 0xD8 | 0x27: 0x80 | 0x27 RegIrqFlags1 0x80 Status register: PLL Lock state,   Timeout, RSSI > Threshold...
0x28: 0x0 | 0x28: 0x0 | 0x28 RegIrqFlags2 0x00 Status register: FIFO handling flags...
0x29: 0xE4 | 0x29: 0xFF | 0x29 RegRssiThresh 0xFF 0xE4 RSSI Threshold control
0x2A: 0x0 | 0x2A: 0x0 | 0x2A RegRxTimeout1 0x00 Timeout duration between Rx request   and RSSI detection
0x2B: 0x0 | 0x2B: 0x0 | 0x2B RegRxTimeout2 0x00 Timeout duration between RSSI   detection and PayloadReady
0x2C: 0x0 | 0x2C: 0x0 | 0x2C RegPreambleMsb 0x00 Preamble length, MSB
0x2D: 0x3 | 0x2D: 0x4 | 0x2D RegPreambleLsb 0x03 Preamble length, LSB
0x2E: 0x98 | 0x2E: 0x88 | 0x2E RegSyncConfig 0x98 Sync Word Recognition control
0x2F: 0x1 | 0x2F: 0x2D | 0x2F-0x36 RegSyncValue1-8 0x00 0x01 Sync Word bytes, 1 through   8
0x30: 0x1 | 0x30: 0xD4 |
0x31: 0x1 | 0x31: 0x0 |
0x32: 0x1 | 0x32: 0x0 |
0x33: 0x0 | 0x33: 0x0 |
0x34: 0x0 | 0x34: 0x0 |
0x35: 0x0 | 0x35: 0x0 |
0x36: 0x0 | 0x36: 0x0 |
0x37: 0x50 | 0x37: 0xD0 | 0x37 RegPacketConfig1 0x10 Packet mode settings
0x38: 0x4 | 0x38: 0x40 | 0x38 RegPayloadLength 0x40 Payload length setting
0x39: 0x0 | 0x39: 0x0 | 0x39 RegNodeAdrs 0x00 Node address
0x3A: 0x0 | 0x3A: 0x0 | 0x3A RegBroadcastAdrs 0x00 Broadcast address
0x3B: 0x85 | 0x3B: 0x0 | 0x3B RegAutoModes 0x00 Auto modes settings
0x3C: 0x1 | 0x3C: 0x8F | 0x3C RegFifoThresh 0x0F 0x8F Fifo threshold, Tx start   condition
0x3D: 0x0 | 0x3D: 0x2 | 0x3D RegPacketConfig2 0x02 Packet mode settings

Thanks for providing comparison!

I'm not sure I have time to parse all of these registers out

I think the difference (ignoring some register that I think don't matter) boils down to:
RegFrf
  plainRFM:  0x6c9002 -> 0x6c9002 * 61 = 433999994 Hz
  radiohead: 0x6c8000 -> 0x6c8000 * 61 = 433750016 Hz
RegFdev:
  plainRFM:  0x0052 -> 0x0052 * 61 = 5002  Hz
  radiohead: 0x1000 -> 0x1000 * 61 = 249856  Hz
RegPacketConfig1
  plainRFM:  0x50=0b01010000 -> fixed length, whitening, crc
  radiohead: 0xD0=0b11010000 -> variable length, whitening, crc
RegSyncConfig
  plainRFM:  0x98=0b10011000 -> SyncSize:3 + 1 = 4,SyncOn
  radiohead: 0x88=0b10001000 -> SyncSize:1 + 1 = 2,SyncOn
RegSyncValue{0..8}
  PlainRFM: [0x1, 0x1, 0x1, 0x1] = [0b00000001, 0b00000001, 0b00000001, 0b00000001]
  RadioHead: [0x2D, 0xD4] = [0b00101101, 0b11010100]
RegDataModul:
  PlainRFM: no shaping
  Radiohead: 01, Gaussian filter BT=1.0
RegBitrate{Msb,Lsb}:
  plainRFM:  0x1a0b = 6667 -> 32e6(FXO_SC) / 6667 = 4799.7600119994 bit/s
  radiohead: 0x0080 =  128 -> 32e6(FXO_SC) / 128 = 250000.0 bit/s
RegPaLevel:
  plainRFM:  0x9F = 0b10011111 -> Pa0: on, pa1: off, pa2: off
  raiodhead: 0x7F = 0b01111111 -> Pa0: off, pa1: on, pa2: on
RegRssiThresh:
  plainRFM: 0xe4 -> -114 dbm
  radiohead: 0xff -> -128 dbm
RegRxBw:
  plainRFM:  0x55
  radiohead: 0xe0
RegAfcBw:
  plainRFM:  0x8b
  radiohead: 0x1a
RegPreamble :
  plainrfm: Preamblesize: 3 bytes
  radiohead: Preamblesize:  4 bytes
RegPayloadLength:
  plainrfm: fixed 4 bytes
  radiohead: variable
RegPacketConfig2:
  plainrfm: nothing
  radiohead: restart Rx after receipt.
RegFifoThresh:
  plainRFM: fifolevel, with 1
  radiohead; fifo not empty, with 0b1111

For instance, I was surprised to see the carrier frequency bytes (RegFrf...) were different.

The difference isn't that large, just multiply the register with 61 to get the frequency in Hz; 433999994 for plainRFM, 433750016 for radiohead. You could use setFrequency  with 433750016 to get the exact same as radiohead.
One thing that does stand out to me is the SyncValues; RegSyncValue in the above, for plainRFM this is set to 0x01, but this data is not whitened (page 52 of the datasheet), so those may actually be bad values... I know that's set by this section but it may be worth changing to what radiohead uses.
Another; RegPaLevel, see above comparison, switch that to be the same as Radioheads, I'm not sure if all chips support the power amplifier options used here.
In this comparison, the baudrates are vastly different, with 4.8kb/s vs 250kb/s, that means transmissions take a pretty significant different duration, if there's any (periodic) interference in the environment plainRFM would be much more affected by that, you could try running setRecommended() followed by baud300000(), that sets it up for 300kb/s, which may set things up more similar to radiohead. Maybe even try this first, depending on the environment this may make a world of difference.
When I developed this library years ago I only really tested with three radios and short ranges. That project (not on github) used the following in the initialization;
    this->rfm->setRecommended(); // set recommended paramters in RFM69.

    this->rfm->setPacketType(true, true); // set the used packet type.
    this->rfm->setBufferSize(this->buffer_size);   // set the internal buffer size.
    this->rfm->setPacketLength(64); // set the packet length.
    this->rfm->setFrequency(this->frequency); // set the frequency.

    this->rfm->setNodeAddress(this->kernel->getPlatformAddress());
    this->rfm->setBroadcastAddress(PLATFORM_ADDRESS_BROADCAST);

    this->rfm->baud153600();
    this->rfm->setPreambleSize(10);

    // tell the RFM to represent whether we are in automode on DIO 2.
    this->rfm->setDioMapping1(RFM69_PACKET_DIO_2_AUTOMODE);

    // set pinmode to input.
    pinMode(this->dio2_pin, INPUT);

    // Tell the SPI library we're going to use the SPI bus from an interrupt.
    SPI.usingInterrupt(this->dio2_pin);

    // hook our interrupt function to any edge.
    attachInterrupt(this->dio2_pin, interrupt_RFM, CHANGE);

    // start receiving.
    this->rfm->receive();

I only needed like 3 meters of range and for that it seemed to work well. But it's like 10 years ago, so I probably forgot countless weeks of frustration trying to get it to work reliably ;)
Hope this gives you some pointers on what you could try and what the differences are. Remember that plainRFM subclasses from bareRFM69, so you can call any of those methods to directly modify registers.

Thank you for all of this informaiton.
I tried just changing just the baud rate as you recommended ("baud(300000)"), but that resulted in no messages being recieved.
So I moved writeRegister() to make it a public function, and just set registers to match the settings in Radiohead as follows.
rfm.writeRegister(1, 4);
rfm.writeRegister(2, 1);
rfm.writeRegister(3, 0);
rfm.writeRegister(4, 0x80);
rfm.writeRegister(5, 0x10);
rfm.writeRegister(6, 0);
rfm.writeRegister(8, 0x80);
rfm.writeRegister(9, 0);
rfm.writeRegister(0x11, 0x7F);
rfm.writeRegister(0x18, 0x08);
rfm.writeRegister(0x19, 0xE0);
rfm.writeRegister(0x1A, 0xE0);
rfm.writeRegister(0x23, 0x0);
rfm.writeRegister(0x24, 0xBE);
rfm.writeRegister(0x27, 0xD8);
rfm.writeRegister(0x29, 0xFF);
rfm.writeRegister(0x2D, 0x04);
rfm.writeRegister(0x2E, 0x88);
rfm.writeRegister(0x2F, 0x2D);
rfm.writeRegister(0x37, 0x00);
rfm.writeRegister(0x38, 0x04);

With those settings reception is good but I get random messages (see below). It's not missing any packets (despite the "packetloss" messages), so I guess I am in a pretty noisy environment. I have CRC checking turned off and there are no sync words so I think using those features would get rid of some of the mess. Unfortunately, this is all the work I can do today. I'll post more progress soon.
Packet (4): 146
Packetloss detected!
Packet (4): 147
Packet (4): 447749699
Packetloss detected!
Packet (4): 148
Packetloss detected!
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4): 149
Packetloss detected!
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4): 466365913
Packetloss detected!
Packet (4): 150
Packetloss detected!
Packet (4): 151
Packet (4): 152
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4): 153
Packetloss detected!
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4): 244994896
Packetloss detected!
Packet (4): 154
Packetloss detected!
Packet (4): 155
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4):<PHONE_NUMBER>
Packetloss detected!
Packet (4): 903718780

I have CRC checking turned off and there are no sync words so I think using those features would get rid of some of the mess

Without both of these, you have nothing that will prevent noise from being decoded as data. Especiall with RegRssiThresh at -128 dBm, that is a very low detection threshold, so if you have any 443 MHz background noise, it'll likely be able to decode data from it. But as you can see, that data is just wrong. Adding crc and sync words will likely allow you to reduce the spurious receptions significantly, perhaps even completely.
I'm still surprised that you didn't get reliable reception with lower baud rates, I recall testing lower baudrates and getting reasonably reliable reception through multiple concrete walls, but that environment likely had very little background noise.

Got stuck today trying to write my own writeRegister routine (so I can use plainRFM69 unaltered). Seems simple but I could not get this to work:
void writeRFM69Register(uint8_t RFM_Reg, uint8_t RFM_Val) {  //write a byte to a radio register.
pinMode(SLAVE_SELECT_PIN, OUTPUT);
SPI.beginTransaction(SPISettings(10000000, MSBFIRST, SPI_MODE0));  // gain control of SPI bus
digitalWrite(SLAVE_SELECT_PIN, LOW);
SPI.transfer(0x80 | (RFM_Reg & 0x7F));
SPI.transfer(RFM_Val);
digitalWrite(SLAVE_SELECT_PIN, HIGH);
SPI.endTransaction();    // release the SPI bus
}
So I gave up and used the function in bareRFM69.cpp. Is there a reason for it to be a private function?
I changed the RSSI threshold and got perfect transmission and reception within a range of register values from 0x50 to 0x78. Next I will implement CRC and syncwords.

Just one more appeal for help, I think. I found that the automode and interupt systems would not work for me (I'm working toward something that will use interrupts and SPI elsewhere). So what I need is to just poll an interrupt pin (DIO0) to see if a message has come in, and if so, read it. I've got that working, and I now have a much simplified radio interface that just uses functions to read and write to the radio registers, to reset the radio, and to fill and read the FIFO. I've taken these functions out of plainRFM69 and I have my own versions in the main sketch. It all works so long as I still create an instance of plainRFM69 with:
plainRFM69 rfm = plainRFM69(SLAVE_SELECT_PIN);
BUT...If I don't create the instance, then the code compiles and runs but there's no communication with the radio -- all register reads come back as 0xFF. So I'm trying to find the magic button that gets pushed when creating an instance. Any ideas?
In case you are wondering why I don't just keep the instance...I'm coding for a device that will have lots of non-programmer as users, and I'm trying to keep the overhead low. The fewer libraries to download and update the better.
Thanks again for all of your help.  Here's the sketch in case it is useful to others:

/*
 *  Modified from code by Ivor Wanders
 *  MIT License, see the LICENSE.md file in the root folder.
*/

#include <SPI.h>
#include <Arduino.h>
#include <plainRFM69.h>

// slave select pin.
#define SLAVE_SELECT_PIN 8

// connected to the reset pin of the RFM69.
#define RESET_PIN 7

#define LED_RFID      43  // (PA27) Pin to control the LED indicator.
#define RADIO_INT     9  //

// define serial com parameters
#define Serial SerialUSB // SerialUSB

//create instance of plainRFM69 = why is this necessary???
plainRFM69 rfm = plainRFM69(SLAVE_SELECT_PIN);

uint32_t counter = 0; // to count the messages.
bool gotMessage = 0;

void setup(){
    pinMode(RADIO_INT, INPUT);
    Serial.begin(9600);
    SPI.begin();
    blinkLED(LED_RFID, 3, 200);
    delay(3000);
    Serial.println("POWER ON!!");
    radioReset(RESET_PIN); // send the RFM69 a hard-reset.

    //settings rendered by rfm.setRecommended(), with modifications
    radioWriteRegister(0x18, 0x08); //Set regLNA to turn on LnaZin and have  gain set by the internal AGC loop
    radioWriteRegister(0x2D, 0x04); //4 LSB for preamble bytes. default = 3; MSB defaults to 0
    radioWriteRegister(0x2E, B10011000);  //Sync on; FifoFillCondition = 0;  3 sync bytes, no tolerance
    radioWriteRegister(0x2F, 0x2D); // Sync value: Set to arbitrary value - same across network
    radioWriteRegister(0x29, 0x64); //setRSSIThreshold (trial & error)
    radioWriteRegister(0x6F, 0x30); //setContinuousDagc                   0               0
    radioWriteRegister(0x02, 0x01); //set DataModul to one to turn on guassan filter
    radioWriteRegister(0x3C, 0x7F & 15 ); //FIFO threshold; first bit zero -> TX when fifo over threshold. other bits = threshold (need to experiment)
    radioWriteRegister(0x19, 0xE0);  //Channel filtering?? DccFreq = B010; RxBwMant = B10, RxBwExp = B101
    radioWriteRegister(0x1A, 0xE0);  //Channel filtering?? DccFreqAfc = B111, RxBwMantAfc = B01, RxBwExpAfc = B000
    radioWriteRegister(0x13, 0x1A); //setPALevel...
    radioWriteRegister(0x11, 0x7F); //setPALevel: power almost at max
    radioWriteRegister(0x07, 0x6C);  //Frequency MSB for 434,000,000 Mhz
    radioWriteRegister(0x08, 0x80);  //Frequency MidSB for 434,000,000 Mhz
    radioWriteRegister(0x09, 0x00);  //Frequency LSB for 434,000,000 Mhz

    //Settings from radioHeand and trial & error.
    radioWriteRegister(1, 4);
    radioWriteRegister(3, 0);
    radioWriteRegister(4, 0x80);
    radioWriteRegister(5, 0x10);
    radioWriteRegister(6, 0);
    radioWriteRegister(0x23, 0x0);
    radioWriteRegister(0x24, 0xBE);
    radioWriteRegister(0x25, 0x40); //RFM69_DIO_MAPPING
    radioWriteRegister(0x27, 0xD8);
    radioWriteRegister(0x30, 0x1);
    radioWriteRegister(0x31, 0x1);
    radioWriteRegister(0x32, 0x1);
    radioWriteRegister(0x2F, 0x3D);
    radioWriteRegister(0x37, 0xD0); //packet config, Variable length, whitening on, CRC on
    radioWriteRegister(0x38, 0x20); //RFM69_PAYLOAD_LENGTH

    //Final settings
    radioWriteRegister(0x3D, 0); //no interpacket delay, no auto RX restart, no AES (encryption)
    radioWriteRegister(0x3C, 0x01); //minimum package threshold
    radioWriteRegister(0x3B, B00000000);  //Automode setting - turn it off
    radioWriteRegister(0x5A, 0x55); // RFM69_TEST_PA1: Normal mode and Rx mode
    radioWriteRegister(0x5C, 0x70); //RFM69_TEST_PA2: Normal mode and Rx mode

    radioWriteRegister(0x01, B00010000); //set to receiver mode

    radioDumpRegisters(); // view all registers

    delay(5);
}

void loop(){
char choose = 'R'; //Change to something other than "R' before loading to transmitter
    if (choose == 'R'){
        Serial.println("Going Receiver!");
        receiver();
        // this function never returns and contains an infinite loop.
    } else {
        Serial.println("Going sender!");
        sender();
        // idem.
    }
}

void sender(){
    uint32_t counter = 0; // the counter which we are going to send.
    uint8_t tx_buffer[13];  //buffer is 1 more than message. First byte is length
    //Send 12 numbers but change the 11th one each time...
    tx_buffer[12] = 1; tx_buffer[1] = 2; tx_buffer[2] = 3; tx_buffer[3] = 4;
    tx_buffer[4] = 5; tx_buffer[5] = 6; tx_buffer[6] = 7; tx_buffer[7] = 8;
    tx_buffer[8] = 9; tx_buffer[9] = 0; tx_buffer[10] = 1; tx_buffer[11] = 2;

    while(true){
      delay(2000);
      tx_buffer[11] = counter;
      tx_buffer[0] = 12;
      Serial.print("Send:");Serial.println(counter);
      radioWriteRegister(0x01, B00000100);  //First Set mode register to receive mode
      //(0b010<<5) + (0b110<<2) + (0b11) = B01011011
      radioWriteRegister(0x3B, B01011011);  //set to automode - start transmitting when FIFO level is above the thresshold
      radioWriteFIFO(tx_buffer, 12);
      radioWriteRegister(0x01, B00000100); // Back to recieve mode.

      counter++; // increase the counter.
      blinkLED(LED_RFID, 3, 200);
    }
}

void receiver(){
    uint8_t rx_buffer[66] = {0};
    uint32_t* rx_counter = (uint32_t*) &rx_buffer;
    while(true){
        delay(1000);
        uint8_t rd = digitalRead(RADIO_INT);
        Serial.println(rd);
        if(rd) {
          SPI.beginTransaction(SPISettings(10000000, MSBFIRST, SPI_MODE0));  // gain control of SPI bus
          digitalWrite(SLAVE_SELECT_PIN, LOW);
          //this->chipSelect(true); // assert chip select
          //SPI.transfer((RFM69_FIFO % RFM69_READ_REG_MASK));
          SPI.transfer((0 % 0x7));
          uint8_t len = SPI.transfer(0);
          //len = len > (max_length-1) ? (max_length-1) : len; //Contain max value of len
          for (uint8_t i=0; i < len; i++){
              rx_buffer[i] = SPI.transfer(0);
          }
          digitalWrite(SLAVE_SELECT_PIN, HIGH);
          SPI.endTransaction();    // release the SPI bus

          Serial.print("Received Packet ("); Serial.print(len); Serial.println("): ");
          for (byte i=0; i<len; i++) {
             Serial.print(rx_buffer[i]); Serial.print(" ");
          }
          Serial.println();
          gotMessage = 0;
        }
    }
}

void blinkLED(uint8_t ledPin, uint8_t repeats, uint16_t duration) { //Flash an LED or toggle a pin
  pinMode(ledPin, OUTPUT);             // make pin an output
  for (int i = 0; i < repeats; i++) {  // loop to flash LED x number of times
    digitalWrite(ledPin, LOW);         // turn the LED on (LOW turns it on)
    delay(duration);                   // pause again
    digitalWrite(ledPin, HIGH);        // turn the LED off (HIGH turns it off)
    delay(duration);                   // pause for a while
  }                                    // end loop
}                                      // End function

void radioReset(uint8_t pin){ // function to send the RFM69 a hardware reset.
    pinMode(pin, OUTPUT);
    digitalWrite(pin, HIGH);
    delayMicroseconds(150); // pull high for >100 uSec
    pinMode(pin, INPUT); // release
    delay(10); //  wait 10 milliseconds before SPI is possible.
}

void radioWriteRegister(uint8_t reg, uint8_t data){
    SPI.beginTransaction(SPISettings(10000000, MSBFIRST, SPI_MODE0));  // gain control of SPI bus
    digitalWrite(SLAVE_SELECT_PIN, LOW);
    //this->chipSelect(true); // assert chip select
    //SPI.transfer(RFM69_WRITE_REG_MASK | (reg & RFM69_READ_REG_MASK));
    SPI.transfer(0x80 | (reg & 0x7F));  // send write instruction (high byte = 1)
    SPI.transfer(data);
    digitalWrite(SLAVE_SELECT_PIN, HIGH);
    //this->chipSelect(false);// deassert chip select
    SPI.endTransaction();    // release the SPI bus
}

uint8_t radioReadRegister(uint8_t reg){
    uint8_t foo;
    SPI.beginTransaction(SPISettings(10000000, MSBFIRST, SPI_MODE0));  // gain control of SPI bus
    digitalWrite(SLAVE_SELECT_PIN, LOW);
    //SPI.transfer((reg % RFM69_READ_REG_MASK));
    SPI.transfer(reg % 0x7F); //use modulo of 0x7F to ensure read instruction (high byte of address = 0)
    foo = SPI.transfer(0);
    digitalWrite(SLAVE_SELECT_PIN, HIGH);// deassert chip select
    SPI.endTransaction();    // release the SPI bus
    return foo;
}

void radioWriteFIFO(uint8_t *buf, uint8_t len){
    for(byte i = 0; i < len; i++) {
      Serial.print(buf[i]); Serial.print(" ");
    }
    Serial.println();
    //uint8_t* r = reinterpret_cast<uint8_t*>(buffer);
    SPI.beginTransaction(SPISettings(10000000, MSBFIRST, SPI_MODE0));  // gain control of SPI bus
    digitalWrite(SLAVE_SELECT_PIN, LOW); // assert chip select
    //SPI.transfer(RFM69_WRITE_REG_MASK | (RFM69_FIFO & RFM69_READ_REG_MASK));
    SPI.transfer(0x80);  //high bit = 1 to indicate write instruction - reg address is 0x00 for FIFO
    for (uint8_t i=0; i < len ; i++){
        // Serial.print("Writing to FIFO: "); Serial.println(r[i]);
        SPI.transfer(buf[i]);
    }
    digitalWrite(SLAVE_SELECT_PIN, HIGH); // deassert chip select
    SPI.endTransaction();    // release the SPI bus
}

void radioDumpRegisters() { //View all radio registers
  uint8_t val;
  for (int i = 0; i <= 0x3d; i++) {
    Serial.print("0x");
    Serial.print(i, HEX);
    Serial.print(": 0x");
    val = radioReadRegister(i);
    Serial.println(val, HEX);
  }
  int j = 0x58;
  Serial.print("0x");
  Serial.print(j, HEX);
  Serial.print(": 0x");
  Serial.println(radioReadRegister(j), HEX);
  j = 0x5A;
  Serial.print("0x");
  Serial.print(j, HEX);
  Serial.print(": 0x");
  Serial.println(radioReadRegister(j), HEX);
  j = 0x5C;
  Serial.print("0x");
  Serial.print(j, HEX);
  Serial.print(": 0x");
  Serial.println(radioReadRegister(j), HEX);
  j = 0x6F;
  Serial.print("0x");
  Serial.print(j, HEX);
  Serial.print(": 0x");
  Serial.println(radioReadRegister(j), HEX);
  j = 0x71;
  Serial.print("0x");
  Serial.print(j, HEX);
  Serial.print(": 0x");
  Serial.println(radioReadRegister(j), HEX);
}

Cool, I'm glad you're getting it all working!

So I'm trying to find the magic button that gets pushed when creating an instance. Any ideas?

Absolutely, thanks for sharing your code. I think the missing bit is the pinMode call, by default pins are in high impedance mode (INPUT), in your sketch it is not set to OUTPUT mode.
The plainRFM69 constructor delegates here to the bareRFM69 constructor, which performs that pinMode(this->cs_pin, OUTPUT); call. If you add pinMode(SLAVE_SELECT_PIN, OUTPUT); to your setup, I have no doubt you can eliminate the instance of plainRFM69.


Replace stdlib write/read with send/recv

https://github.com/netty/netty/issues/12673 ditto as before

@chrisvest this is still valid in the 'main` branch of the Netty repo right?

@franz1981 that version uses recv for reading, and writev for sending, but I suspect we'll soon change that writev to sendmsg - Norman has some ideas for changing the IO loops that will require that.

@chrisvest on the pr for Netty 5 io_uring it seems it's using read/write and not recv/send (writev is for mutile writes, while here I mean for single one)

For writev (on epoll) I didn't spot any improvement by using sendmsg, no idea if it still holds for io_uring in its recent iterations, but we can ask the io_uring folks to clarify that

The recv is here: https://github.com/netty/netty/blob/main/transport-classes-io_uring/src/main/java/io/netty5/channel/uring/AbstractIOUringChannel.java#L214-L215
We also use read, but only for the eventfd. Maybe that's what you saw.

Uhm, very likely (I should not use the phone to read prs, bad habit, I apologize)!


optimize train/4

use reduce_while to stop the training when the new computed error is no longer smaller than the current error

Merged! Thank youuuu ❤


Moved over Generalised Fixed Fee Estimator

Context:

As part of generalisation efforts, we plan to integrate fixed fee estimator with Cosmos. This is based on the PR https://github.com/smartcontractkit/chainlink/pull/10003

Changes:

Moved over fixed fee components
Moved over big math libraries
Wrote generic dummy tests for fixed fee components

Tickets:

https://smartcontract-it.atlassian.net/browse/BCI-1638

This PR is currently blocked by https://github.com/smartcontractkit/chainlink-starknet/pull/317 which fixes the integration tests for starknet


Extra leading space in spans containing TypeScript types causes underlines to start early

Describe the bug
When converting TypeScript code to HTML, Shikiji creates a span that contains a leading space followed by the type name, for example  LogLevelStrings. This behavior differs from Shiki which uses one span for the space and another one only for the type name.
Ultimately, this bug causes some themes, for example monokai, to be applied incorrectly since the underline under the type name starts early, being present also under the space.

Packages versions.

shiki: 0.14.7
shikiji: 0.9.12

Highlighting code with Shiki.

// shiki.cjs
const shiki = require("shiki");

shiki
  .getHighlighter({
    theme: "monokai",
  })
  .then((highlighter) => {
    console.log(
      highlighter.codeToHtml(`type LogLevelStrings = keyof typeof LogLevel;`, {
        lang: "ts",
      })
    );
  });

Highlighting code with Shikiji.

// shikiji.mjs
import { getHighlighter } from "shikiji";

const highlighter = await getHighlighter({
  themes: ["monokai"],
  langs: ["typescript"],
});

const code = highlighter.codeToHtml(
  "type LogLevelStrings = keyof typeof LogLevel;",
  {
    lang: "typescript",
    theme: "monokai",
  }
);

console.log(code);

HTML output from Shiki and Shikiji.

type LogLevelStrings = keyof typeof LogLevel;

type LogLevelStrings = keyof typeof LogLevel;

HTML output differences visualized.

Bug reproduced on Shikiji Playground by selecting TypeScript and Monokai; type names after enum, type and key: are affected.

VSCode rendering the same playground code with Monokai.

Reproduction
https://shikiji.netlify.app
System Info
System:
    OS: Linux 6.6 Fedora Linux 38 (Workstation Edition)
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 10.18 GB / 15.51 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 20.10.0 - /run/user/1000/fnm_multishells/28509_1703779162622/bin/node
    npm: 10.2.3 - /run/user/1000/fnm_multishells/28509_1703779162622/bin/npm
    pnpm: 8.12.1 - ~/.bun/bin/pnpm
    bun: 1.0.20 - ~/.bun/bin/bun
  Browsers:
    Chrome: 120.0.6099.129

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

This was an optimization trying to provide smaller HTML as possible, where you can turn it off by setting mergeWhitespaces: false.
I made the fix to not merge them when the underlined style is presented. Thanks

Thanks!


Workflow and use-cases

This issue is to list out the possible way the cli can help in enabling project deployments and working in general
Expectation
As a user, one should be able to download a project from webstudio using a command line tool and deploy the generated build to any desired hosting provider. (Although if the cli is capable enough to deploy that would be great. But that can be a little out of scope at the moment. As it needs cli to have implementations with all possible providers. Eg: Or a leat wrap the existing one like vercel to deploy them)
Stages
With the requirement, we should ideally able to complete this whole process with a series of commands. Like
init / login
webstudio init <share-url>

The current approach is  to load a project and save the apiKey in the config path. So the subsequent usage of sync and build can just use the API keys from the config. This is the current implementation too.
build
webstudio build <project-id>

When ran, should create a new project and load the data of the project and build it at the same time.  During build time, the templates are being copied from the local path to the BUILD_DIR here. Here is the place that needs improvement.

First, the cli's are usually installed globally. So, the same with this use-case too. So, we can't run cp ./ with relative paths. As the templates are not bundled with the current setup as it is. There are multiple things that can be considered to solve this.

We can save the templates as a JSON file. That stores the file name and content as key-value pairs. These JSON's can be parsed and  populated into the BUILD_DIR using fs.
The first approach looses syntax highlighting  when maintaining, so the approach will be to bundle these files as those JSON's at the build time and maintain them. But it's too much of a setup things, and slows down in dev iteration.
Save all the templates in a new project in GitHub. We can use something like this and load all the files from the github using commitId. Just in case if the cli want to be safe of the future template updates.  It helps in syntax highlighting, no relative path issues and makes the cli lightweight by not bundling all of them into it.

sync
webstudio sync

The command sync can be ran inside a existing webstudio project. So, there is no need to pass the projectId once again. This can be picked from app/app.json where the data is stored when the project is built for the first time.  Then it fetches the new content from the project and runs the build once again. Because sync was supposed to keep the existing project with the current state in the UI.
Example flow

User runs webstudio init ${url} a project
Runs webstudio build ${projectId} to build the project
Can use webstudio sync to sync with new changes.
Can use vercel deploy or something. inside the project to upload the built files for deployment.

We can save the templates as a JSON file. That stores the file name and content as key-value pairs. These JSON's can be parsed and populated into the BUILD_DIR using fs.

Lets keep the templates on a file system inside the source. You can turn them into template literals as a build step for the CLI, here is an example of how we do such build steps https://github.com/webstudio-is/webstudio-builder/blob/main/packages/css-data/package.json#L13

if build is supposed to be run only once, shouldn't this actually be part of the "init"? Is vercel, remix or any other scaffolding CLI calling it build?

I think we can have a webstudio deploy and depending on the configured destination it will call the right script, this way you don't have to use a new command depending on the target every time.
Similar to turborepo


Support for private repositories for pub

Is there an existing issue for this?

[X] I have searched the existing issues

Feature description
Support for private repositories for pub
When enabling dependabot support for a pub project there should be a way to configure the credentials for accessing private third-party repositories.
From discussion here: https://github.com/orgs/community/discussions/14200#discussioncomment-4050762
The authentication pub uses is documented here:
https://github.com/dart-lang/pub/blob/master/doc/repository-spec-v2.md#authentication
Basically dependabot needs to run dart pub token add <repository-url> and give it a credential token on stdin for each private repository.
It will then pass that token to the repository in a 'Authorization: Bearer ' header when doing version listings and downloading packages.

Re mirroring:
A third party repository at  can be set up to mirror the official repository pub.dev.
In that case one would like to run the resolution with the environment variable $PUB_HOSTED_URL set to , that will then be used as the default url for fetching packages.

cc @jonasfj

Hi I would love to see this functionality. Currently dependabot fails to run on a dart/flutter project which has any 'private' dependencies as they cannot be resolved.
Relevant log lines:
  proxy | 2023/09/14 07:26:20 [555] 401 https://xxx.xxxx.xx:443/xxx-test-org/test-repo/api/packages/providerpackage
  proxy | 2023/09/14 07:26:20 [555] {"error": {"code": "UNAUTHORIZED", "message": "Invalid authentication provided."}}

updater | 2023/09/14 07:26:24 ERROR <job_721850595> Error processing providerpackage (NoMethodError)
updater | 2023/09/14 07:26:24 ERROR <job_721850595> undefined method `match?' for nil:NilClass
updater |
updater |         version_string.match?(/^[0-9a-f]{6,}$/)
updater |                       ^^^^^^^
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/pub/lib/dependabot/pub/update_checker.rb:112:in `git_revision?'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/pub/lib/dependabot/pub/update_checker.rb:97:in `version_unless_ignored'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/pub/lib/dependabot/pub/update_checker.rb:15:in `latest_version'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:166:in `all_versions_ignored?'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:79:in `check_and_create_pull_request'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:60:in `check_and_create_pr_with_error_handling'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:35:in `block in perform'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:35:in `each'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:35:in `perform'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:64:in `run'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:39:in `perform_job'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:53:in `run'
updater | 2023/09/14 07:26:24 ERROR <job_721850595> bin/update_files.rb:24:in `<main>'
updater | 2023/09/14 07:26:24 INFO <job_721850595> Finished job processing
updater | 2023/09/14 07:26:24 INFO Results:
updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | +---------------------------------+
updater | |  Dependencies failed to update  |
updater | +-----------------+---------------+
updater | | providerpackage | unknown_error |
updater | +-----------------+---------------+

@mctofu just a small ping. I believe this issue contains the information you requested in https://github.com/orgs/community/discussions/14200#discussioncomment-4050762 .
What are next steps if we want to implement this?

@sigurdm Yes, that is the info we needed. For this to work on Dependabot running on github.com our team will need to implement:

Adding support/docs for pub registries to dependabot.yml
Adding support for pub registries to our authentication proxy. This will attach the Authorization: Bearer header to outgoing requests to the pub registry without making the credentials available to the code in this repo.

Additionally, it would be helpful for us to get access to a private pub repository for testing or at least some assistance in verifying the added support works.
At the moment we don't have this on our roadmap but I'll surface this internally as a feature that is blocked on us.

hi @mctofu do maybe already have some news on this one? I'm happy to contribute if that would help but as far as I could see the proxy seems to be a private project.

I added support for private Pub repos to our proxy but I don't have access to a private pub repo so I haven't tested it. It's currently available to try via the Dependabot CLI and I'm hoping someone can validate it works.
To try it out, first install the CLI.
Create a job.yml file as follows. Replace the source repo with your own as well as the hosted-url and token for the pub credentials.
---
job:
  package-manager: pub
  allowed-updates:
  - dependency-type: direct
    update-type: all
  source:
    provider: github
    repo: dependabot-fixtures/pub_with_git_dependency
    directory: "/."
    branch: main
    api-endpoint: https://api.github.com/
    hostname: github.com
credentials:
  - type: pub_repository
    hosted-url: https://example-private-pub-repo.dev/optional-path
    token: not-a-real-token

If the source repo is private, set an env variable named LOCAL_GITHUB_ACCESS_TOKEN to a github PAT which can read the repo.
Run dependabot update -f job.yml and verify you can get updates to the private dependency.
This is not yet available to configure via dependabot.yml but that would be the next step if we can confirm this works.

@bsutton runs https://onepub.dev/, he might be able to assist.

@mctofu the free version of OnePub should give you want but if you need anything extra happy to a donate some extra licences to the cause. Reach out if you have any issues.

I ran a test on my test project  (https://github.com/lazytesting/flutterpackagetest/tree/main)
with this config:
job:
  package-manager: pub
  allowed-updates:
    - dependency-type: direct
      update-type: all
  source:
    provider: github
    repo: lazytesting/flutterpackagetest
    directory: /consumertest
    branch: main
    api-endpoint: https://api.github.com/
    hostname: github.com

credentials:
  - type: pub_repository
    hosted-url: https://dart.cloudsmith.io/maarten-test-org/test-repo/
    token: xxx

And it works, it both 'resolves' public packages as well as my private package which is hosted at CloudSmith
log:
updater | +-----------------------------------------------------+
updater | |         Changes to Dependabot Pull Requests         |
updater | +---------+-------------------------------------------+
updater | | created | cupertino_icons ( from 1.0.5 to 1.0.6 )   |
updater | | created | flutter_lints ( from 2.0.2 to 3.0.1 )     |
updater | | created | providerpackage ( from 1.0.0+2 to 1.2.1 ) | <==== this is a private package
updater | +---------+-------------------------------------------+
  proxy | 2023/12/09 16:28:29 130/396 calls cached (32%)

@mctofu is there anything else I can help with to get this one merged?

@lazytesting This isn't officially supported yet and is subject to change but if you want to test this out you can configure it via dependabot.yml like:
version: 2
registries:
  my-pub-registry:
    type: pub-repository
    url: https://example-private-pub-repo.dev/optional-path
    token: ${{secrets.MY_PUB_TOKEN}}
updates:
  - package-ecosystem: "pub" # See documentation for possible values
    directory: "/" # Location of package manifests
    schedule:
      interval: "weekly"
    registries:
      - my-pub-registry

Note that hosted-url has been renamed to url.

Two other enhancements we could consider on the dependabot-core side before closing this out:

When we fail to access a package because of missing or incorrect credentials, it'd be helpful to raise a Dependabot::PrivateSourceAuthenticationFailure so we can surface this to the user in a friendly manner (example)
I saw it's possible to override the default package repository. If we wanted to support this in Dependabot, one approach we've been taking is to look for a registry configured with the replaces-base flag set (example). If found, it could be used to set the PUB_HOSTED_URL env var when checking for updates?

@sigurdm What do you think? The PrivateSourceAuthenticationFailure would be helpful to guide users but I'm not sure how common it is to change the default repository?

When we fail to access a package because of missing or incorrect credentials, it'd be helpful to raise a Dependabot::PrivateSourceAuthenticationFailure

We should be able to do that. When we have a failed authentication we output either "authentication failed"(401) or "authorization failed" (403):
https://github.com/dart-lang/pub/blob/23edb4522177ecff180225228e6c1323ca58967d/lib/src/source/hosted.dart#L1616

I'm not sure how common it is to change the default repository?

I don't think it is common numerically. But I have heard of large companies that replicate the parts of pub.dev they need on a third-party host.
Also people in countries with restricted internet access might override to use a local mirror: https://docs.flutter.dev/community/china#configure-your-machine-to-use-a-mirror-site

Is it possible to ignore the private repo in the meantime? I have a dependency to a private gitlab repo in my project, and it's the only private dependency in the entire pubspec.yaml. Since auth for this is not yet supported, I was hoping to just skip it while checking for updates.
I see here that this isn't recommended, and I can confirm that trying to ignore it in my dependabot.yml does not work. Any other ideas on how I could do this ? Thanks!

Is it possible to ignore the private repo in the meantime?

No - darts dependabot integration only works if you can do a full resolution.

Is this not supported already? I'm getting mixed signals here & here


chore: Cleanup shared test utils package.

Move @css-blocks/build => @css-blocks/test-utils.
Move @css-blocks/test-utils to devDependencies in JSX integration.
Clean up exports API of test-utils so we don't need deep requires.
Clean up typings of mock function in test-utils so we don't need Object.apply.
Add README for test-utils.
Rename transient-fs to mock-fs.
Move _files and _directories private properties to truly private module scoped contants.

@css-blocks/build was a misnomer :) Also, made some small package structure and typing changes for cleaner APIs. Now that we have a shared test-utils package, I plan to also use it for the upcoming perf smoke testing infrastructure 👍


on-hold directive not working in ion-slide-box

With the recent update to Android 4.4.4, the on-hold directive is no longer working consistently.  I am using the nightlies with the refactored slide-box (as of yesterday), this does not solve the issue.
I am able to engage the tap-hold only maybe 1 in 5 tries, or even 1 in 20 to 30 in some cases.  I have put together a sample project with an ng-repeat of a number of items within a single slide.  I suspect that vertical scroll may have something to do with it, but I don't see any docs on disabling the scroll within a slide to test.
You can find the project here:
https://drive.google.com/file/d/0B1ClGdseCfJdS09XN3JfbXp2Ykk/view?usp=sharing
Thanks.

I noticed that some of the other touch event issues are being closed with recent updates.  This one is still open, and it is my primary problem with my app right now.  Basically halted development for several months.  Any updates?  If there is a fix by moving to latest nightly and Crosswalk, etc, I will make the effort to upgrade (I'm stuck in Beta13, I believe).
Thanks,
Marc

@marcsyp Suggest using mnTouch if updates dont' work. We are using that for on-hold right now and it works great.

Thanks.  Any specific notes on implementing this in Ionic?  Do I need to rip out anything from the Ionic bundle that will conflict?  I'm not an expert, still working my way around these kinds of custom mods.
Thanks,
Marc

No. We just got an mnTouch from its git repository and used the appropriate attribute on the tag we were interested in listening to. I think if you have an additional event such as a click on the same element you want to use mnTouch for both events. We didn't touch Ionic at all, just used mnTouch where we had problems.
-----"Marc Syp"<EMAIL_ADDRESS>wrote: -----
=======================
To: "driftyco/ionic"<EMAIL_ADDRESS>From: "Marc Syp"<EMAIL_ADDRESS>Date: 02/11/2015 07:27PM
Cc: SashaGeekette<EMAIL_ADDRESS>Subject: Re: [ionic] on-hold directive not working in ion-slide-box (#2373)
Thanks.  Any specific notes on implementing this in Ionic?  Do I need to rip out anything from the Ionic bundle that will conflict?  I'm not an expert, still working my way around these kinds of custom mods.
Thanks,
Marc

Reply to this email directly or view it on GitHub:
https://github.com/driftyco/ionic/issues/2373#issuecomment-73994752
This message has been scanned and no issues discovered.
To report this email as SPAM, please forward it to<EMAIL_ADDRESS>

Please see: https://github.com/driftyco/ionic/issues/1729#issuecomment-73750595
-----"Marc Syp"<EMAIL_ADDRESS>wrote: -----
=======================
To: "driftyco/ionic"<EMAIL_ADDRESS>From: "Marc Syp"<EMAIL_ADDRESS>Date: 02/11/2015 07:27PM
Cc: SashaGeekette<EMAIL_ADDRESS>Subject: Re: [ionic] on-hold directive not working in ion-slide-box (#2373)
Thanks.  Any specific notes on implementing this in Ionic?  Do I need to rip out anything from the Ionic bundle that will conflict?  I'm not an expert, still working my way around these kinds of custom mods.
Thanks,
Marc

Reply to this email directly or view it on GitHub:
https://github.com/driftyco/ionic/issues/2373#issuecomment-73994752
This message has been scanned and no issues discovered.
To report this email as SPAM, please forward it to<EMAIL_ADDRESS>

This issue has been fixed with the most recent updates to nightly. Tested Android 4.4.4.

Great!  This actually worked for me, too.  It requires some messing with the default thresholds to get right when you're inside a slide box and using other interactions, but it is MUCH better than the broken interactions I had before.
Thanks!
Marc

This seems to still be broken.  I tested this today on an s5 running 4.4.4.  Using mnTouch still solved the issue for us.
Codepen here:
http://codepen.io/dellingsworth/pen/JopVRB
-Don


Load config from /etc by default

It'd be nice to try loading the needed config files from /etc/lyrebird and then override them by ~/.config/lyrebird if they exist there.
I wanted to throw it on AUR but this is making it hard.

sure, we will do this in half an hour or something :)

@C0rn3j I've made the change in v1.0.1 (369a7e8), let me know if this works for you.


docs: one year of PRQL

This is a great one-year retrospective!

Should we add something on "the way forward" or "what we're struggling with" or some call-to-action to contribute? Or maybe this is nicely self-contained?

I wanted to add a call for contributors at the bottom, but there already the footer doing the same thing.
The way forward it the roadmap.


Add Wind Information

Hello,
Thank you very much for your work om this excellent application. It is really great for flying in VR!
As an additional feature in the future, would it be possible to display wind speed and wind direction over the map?
For example, the old application Vfrma-enhanced had this type of information displayes in a bar at the top of the window (see screenshot attached) and it was very useful when landing at uncontrolled airports without ATIS.

Thank you very much and greetings from Spain!

HEy @aduboy - Thanks for the suggestion. Yes, that is something I already put on my TODO-List recently! :-) I'll leave the issue open until I have implemented it to avoid duplicates!

done!


Make Runic Tablet (Roots) recognisable by Enchiridion

Again, don't know if that's fixable in the configs but it would be appreciated if I could add my Roots "book" to my Enchiridion Library.

Poke me to re-open this issue if we re-add roots.


Red Hat is the provider and maintainer

/lgtm
On Fri 7. Jun 2019 at 22:07, Sergey Yedrikov<EMAIL_ADDRESS>wrote:

@syedriko https://github.com/syedriko requested your review on: #19
https://github.com/openshift-knative/knative-kafka-operator/pull/19 Red
Hat is the provider and maintainer.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/openshift-knative/knative-kafka-operator/pull/19?email_source=notifications&email_token=AABGPTQ2WZFFRR7RNAL3NMLPZK5YNA5CNFSM4HVZ6LTKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR3ZQCLA#event-2398290220,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABGPTVFJ43GKEC4YVF47XLPZK5YNANCNFSM4HVZ6LTA
.

--
Sent from Gmail Mobile

once merged, run the release script
On Fri 7. Jun 2019 at 22:48, Matthias Wessendorf<EMAIL_ADDRESS>wrote:

/lgtm
On Fri 7. Jun 2019 at 22:07, Sergey Yedrikov<EMAIL_ADDRESS>wrote:

@syedriko https://github.com/syedriko requested your review on: #19
https://github.com/openshift-knative/knative-kafka-operator/pull/19
Red Hat is the provider and maintainer.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/openshift-knative/knative-kafka-operator/pull/19?email_source=notifications&email_token=AABGPTQ2WZFFRR7RNAL3NMLPZK5YNA5CNFSM4HVZ6LTKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR3ZQCLA#event-2398290220,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABGPTVFJ43GKEC4YVF47XLPZK5YNANCNFSM4HVZ6LTA
.

--
Sent from Gmail Mobile

--
Sent from Gmail Mobile

release.sh ran


libquvi-scripts: init at 0.9.2

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

We already have this package under the name quvi_scripts


Bump to Twig 3

While updating to Twig 3 had to remove outdated TwigExtensions. This brought changes in translator which have other format of 'trans' filter. Templates updated to short form {{ 'Hello'|trans }}.
Despite the large number of modified files, don't should be critical changes.

Please update composer to no longer include the unused packages Edit: ignore this, I just realized the GitHub app isn't loading a complete list of files that were modified

enable in Preview Features -> Pull Request File Tree
Really usefull Preview Feature

Please update composer to no longer include the unused packages Edit: ignore this, I just realized the GitHub app isn't loading a complete list of files that were modified

enable in Preview Features -> Pull Request File Tree
Really usefull Preview Feature

I have it enabled. I'm just on the mobile app

If anybody has no protest, I merge this PR?


Connect the repo to Reviewable

Please connect this repo at https://reviewable.io/repositories#youtube so that all PRs get linked to reviews. Thanks!

reviewable.io probably automatically created this for you ;-)
For now, we don't want to do this. Instead, just login on reviewable.io and select the pull request you want to comment on.

Oh I see. Sugu please disregard. You can just login to reviewable.io and
reply to my comments.
On Wed, Feb 10, 2016 at 5:51 PM, Michael Berlin<EMAIL_ADDRESS>wrote:

reviewable.io probably automatically created this for you ;-)
For now, we don't want to do this. Instead, just login on reviewable.io
and select the pull request you want to comment on.
—
Reply to this email directly or view it on GitHub
https://github.com/youtube/vitess/issues/1500#issuecomment-182670571.


Dynamic Code Evaluation (e. g. 'eval', 'new Function', 'WebAssembly.compile') not allowed in Edge Runtime

Describe the Bug
Hello, this is the one I was referring to to in the other ticket @gabrielmfern,
I have a monorepo with an auth package, an email package and my main app that consumes both of them.
My desire is for users to login through next-auth and have next-auth send out an email with resend of a login link that is styled with react email.
I have been trying to have the next-auth middleware run on edge in order to make it faster.
The problem that I'm experiencing is that the project works well on dev, but when trying to build and deploy to vercel, it fails with
./node_modules/.pnpm/@react-email+tailwind@0.0.14-canary.0_react<EMAIL_ADDRESS>Dynamic Code Evaluation (e. g. 'eval', 'new Function', 'WebAssembly.compile') not allowed in Edge Runtime
Learn More: https://nextjs.org/docs/messages/edge-dynamic-code-evaluation

Import trace for requested module:
./node_modules/.pnpm/@react-email+tailwind@0.0.14-canary.0_react<EMAIL_ADDRESS>./node_modules/.pnpm/@react-email+components@0.0.14-canary.0_@types+react@18.2.39_react<EMAIL_ADDRESS>./src/vercel-invite-user.tsx
./src/auth.ts

I've been using the canary versions of both @react-email/components & @react-email/render cause they contain fixes that I need to run on edge : https://github.com/resend/react-email/pull/1079
I'm not sure if it's a regression or a problem caused by a different library eg. NextAuth or Next itsself.
It took me a while to create the reproduction because I have attempted:

See if the problem occurs in a NextJS API route. It works without a problem ✅
See if the problem occurs when having the renderAsync function in a RSC. It works without a problem ✅
Have the function in the NextAuth configuration. It fails ❌

Which package is affected (leave empty if unsure)
@react-email/components
Link to the code that reproduces this issue
https://github.com/VaniaPopovic/react-email-repro
To Reproduce

pnpm install
pnpm run dev -> everything works as expected
pnpm run build it fails with the aformentioned error

Expected Behavior
For it to render the email without a problem
What's your node version? (if relevant)
20.6.1

Dude, I have the exact same problem. After installing each component individually and removing the tailwind component this error stopped.

Dude, I have the exact same problem. After installing each component individually and removing the tailwind component this error stopped. :(

Thanks for this, it on my side still not building. Maybe your solution will help

Same problem, unusable on edge runtime

You can use this hack until the PR is merged. In unstable_allowDynamic replace with the path that you get from the next error.
export const config = {
  matcher: ["/business/:path*", "/join"],
  unstable_allowDynamic: [
    "**/node_modules/.pnpm/@react-email+tailwind<EMAIL_ADDRESS>// use a glob to allow anything in the function-bind 3rd party module
  ],
};

We're running into the same issue. It's unusable on the edge.
We are rendering emails through inngest.

I managed to figure out a work around by uninstalling react-email/components and just using the individual packages. I'm fairly sure it's the tailwind package that's causing the issue.
To the maintainers of this project: I really would fix this one because it is extremely common to use this package in an edge environment. Typically you're sending emails from a job queue like ingest and the only way that ingest is going to work is if it's streaming and so it needs to be in an edge environment.
So I would really give this one some attention. Just my two cents.

I wonder if the new engine for Tailwind will just magically fix it because it's such a big rewrite.

I got similar issue I fix it by adding this to my middleware
  unstable_allowDynamic: [
<EMAIL_ADDRESS>  ],

Hey there!
unstable_allowDynamic did not help me, although I figured out the way to fix it:

I followed this guide of next-auth@v5 https://authjs.dev/getting-started/migrating-to-v5#edge-compatibility
But Isolated events from the config, keeping sendEmail function inside auth.ts file, but with no import to the middleware.

Not sure, if events property is important to be in middleware.

Hey there!
unstable_allowDynamic did not help me, although I figured out the way to fix it:

I followed this guide of next-auth@v5 https://authjs.dev/getting-started/migrating-to-v5#edge-compatibility
But Isolated events from the config, keeping sendEmail function inside auth.ts file, but with no import to the middleware.

Not sure, if events property is important to be in middleware.

Same problem using next-auth@5. Your solution helped, thanks!

I managed to figure out a work around by uninstalling react-email/components and just using the individual packages. I'm fairly sure it's the tailwind package that's causing the issue.
To the maintainers of this project: I really would fix this one because it is extremely common to use this package in an edge environment. Typically you're sending emails from a job queue like ingest and the only way that ingest is going to work is if it's streaming and so it needs to be in an edge environment.
So I would really give this one some attention. Just my two cents.

This was the solution that worked for me as well, but it would be a lot nicer if this was fixed so I could just use the single package.

It would also be great to explicitly document that the tailwind package is not usable in the Edge Runtime and to provide some documentation about styling emails without Tailwind (especially when it comes to using media queries 😅).

Dude, I have the exact same problem. After installing each component individually and removing the tailwind component this error stopped. :(

Worked for me

I got similar issue I fix it by adding this to my middleware
  unstable_allowDynamic: [
<EMAIL_ADDRESS>  ],

Thanks buddy it works for me

I got similar issue I fix it by adding this to my middleware
  unstable_allowDynamic: [
<EMAIL_ADDRESS>  ],

Thanks a lot. Worked for me too!

<EMAIL_ADDRESS>
Hi, may I ask which version of Next.js you are using?

Hi, may I ask which version of Next.js you are using?

I got similar issue I fix it by adding this to my middleware
  unstable_allowDynamic: [
<EMAIL_ADDRESS>  ],

Thanks a lot. Worked for me too!

Hi, may I ask which version of Next.js you are using?

I managed to figure out a work around by uninstalling react-email/components and just using the individual packages. I'm fairly sure it's the tailwind package that's causing the issue.
To the maintainers of this project: I really would fix this one because it is extremely common to use this package in an edge environment. Typically you're sending emails from a job queue like ingest and the only way that ingest is going to work is if it's streaming and so it needs to be in an edge environment.
So I would really give this one some attention. Just my two cents.

+1

I managed to figure out a work around by uninstalling react-email/components and just using the individual packages. I'm fairly sure it's the tailwind package that's causing the issue.
To the maintainers of this project: I really would fix this one because it is extremely common to use this package in an edge environment. Typically you're sending emails from a job queue like ingest and the only way that ingest is going to work is if it's streaming and so it needs to be in an edge environment.
So I would really give this one some attention. Just my two cents.

+1

The middleware did not work for me, but I also changed the imports and no problems 👍

I managed to figure out a work around by uninstalling react-email/components and just using the individual packages. I'm fairly sure it's the tailwind package that's causing the issue.
To the maintainers of this project: I really would fix this one because it is extremely common to use this package in an edge environment. Typically you're sending emails from a job queue like ingest and the only way that ingest is going to work is if it's streaming and so it needs to be in an edge environment.
So I would really give this one some attention. Just my two cents.

+1

The middleware did not work for me, but I also changed the imports and no problems 👍

I did the same and it's working! The problem was the Tailwind package

I managed to figure out a work around by uninstalling react-email/components and just using the individual packages. I'm fairly sure it's the tailwind package that's causing the issue.
To the maintainers of this project: I really would fix this one because it is extremely common to use this package in an edge environment. Typically you're sending emails from a job queue like ingest and the only way that ingest is going to work is if it's streaming and so it needs to be in an edge environment.
So I would really give this one some attention. Just my two cents.

+1

Just to share a few cents on this: we are also using Inngest and we try to use the Edge Runtime as much as possible. However, we also really want to use Tailwind.
One thing you can do with Inngest is create 2 apps, each one served on a dedicated endpoint. Therefore, we have an edge app and a node app. The Node app is used to serve all functions that are not runnable on the Edge runtime. Events can still be sent between each app though.
The function rendering the React emails is on the Node.js app.

你可以使用这个 hack 直到 PR 被合并。替换为您从错误中获得的路径。这适用于中间件，例如，如果您有自定义验证电子邮件并使用 auth.js。unstable_allowDynamic
export const config = {
  matcher: ["/business/:path*", "/join"],
  unstable_allowDynamic: [
    "**/node_modules/.pnpm/@react-email+tailwind<EMAIL_ADDRESS>// use a glob to allow anything in the function-bind 3rd party module
  ],
};

Thanks, it works! pnpm

Unistalling this package @react-email/components
and installing Individual components works
import { Body } from "@react-email/body"; import { Button } from "@react-email/button"; import { Head } from "@react-email/head"; import { Html } from "@react-email/html"; import { Hr } from "@react-email/hr"; import { Preview } from "@react-email/preview"; import { Section } from "@react-email/section"; import { Text } from "@react-email/text"; import { Img } from "@react-email/img"; import { Container } from "@react-email/container";

When using next-auth and edge config, react-email is massive and causing Vercel edge function to reach its limits when deploying to Vercel infra. This is due to the verify request email being used in auth config, which is necessary (it's not possible for email-only passwordless login without verify-request, so not possible to split the config).
I have tried running email build command with the CLI and get .react-email directory not found. Anyone got any suggestions for reducing bundle size in production build?

We just merged #1383 and released it under canary<EMAIL_ADDRESS>should fix it


Editor crashes when AtlasTexture resource has C# script attached

Godot version
3.4.2 mono
System information
Windows 10
Issue description
I was creating an AtlasTexture derived script to allow for quick grid-based icon displays. If you then create an AtlasTexture in res and add the script to it, the editor will then crash when you next open it with no output as to the issue.
I had to compile the editor and attach a debugger to even narrow down that that was indeed the issue.
Exception Deets:
Exception thrown at 0x00007FFA3567D057 (mono-2.0-sgen.dll) in godot.windows.tools.64.mono.exe: 0xC0000005: Access violation reading location 0x00000000000000BC.

Call stack (without the unintelligible mono stuff.)
godot.windows.tools.64.mono.exe!GDMonoField::get_value(_MonoObject * p_object) Line 526
	at D:\repos\godot\modules\mono\mono_gd\gd_mono_field.cpp(526)
godot.windows.tools.64.mono.exe!CSharpScript::instance_create(Object * p_this) Line 3036
	at D:\repos\godot\modules\mono\csharp_script.cpp(3036)
godot.windows.tools.64.mono.exe!Object::set_script(const RefPtr & p_script) Line 1018
	at D:\repos\godot\core\object.cpp(1018)
godot.windows.tools.64.mono.exe!Object::set(const StringName & p_name, const Variant & p_value, bool * r_valid) Line 432
	at D:\repos\godot\core\object.cpp(432)
godot.windows.tools.64.mono.exe!ResourceInteractiveLoaderText::poll() Line 573
	at D:\repos\godot\scene\resources\resource_format_text.cpp(573)
godot.windows.tools.64.mono.exe!ResourceFormatLoader::load(const String & p_path, const String & p_original_path, Error * r_error) Line 193
	at D:\repos\godot\core\io\resource_loader.cpp(193)
godot.windows.tools.64.mono.exe!ResourceLoader::_load(const String & p_path, const String & p_original_path, const String & p_type_hint, bool p_no_cache, Error * r_error) Line 262
	at D:\repos\godot\core\io\resource_loader.cpp(262)
godot.windows.tools.64.mono.exe!ResourceLoader::load(const String & p_path, const String & p_type_hint, bool p_no_cache, Error * r_error) Line 376
	at D:\repos\godot\core\io\resource_loader.cpp(376)
godot.windows.tools.64.mono.exe!EditorResourcePreviewGenerator::generate_from_path(const String & p_path, const Vector2 & p_size) Line 63
	at D:\repos\godot\editor\editor_resource_preview.cpp(63)
godot.windows.tools.64.mono.exe!EditorResourcePreview::_generate_preview(Ref<ImageTexture> & r_texture, Ref<ImageTexture> & r_small_texture, const EditorResourcePreview::QueueItem & p_item, const String & cache_base) Line 162
	at D:\repos\godot\editor\editor_resource_preview.cpp(162)
godot.windows.tools.64.mono.exe!EditorResourcePreview::_thread() Line 261
	at D:\repos\godot\editor\editor_resource_preview.cpp(261)
godot.windows.tools.64.mono.exe!EditorResourcePreview::_thread_func(void * ud) Line 102
	at D:\repos\godot\editor\editor_resource_preview.cpp(102)
godot.windows.tools.64.mono.exe!Thread::callback(Thread * p_self, const Thread::Settings & p_settings, void(*)(void *) p_callback, void * p_userdata) Line 78
	at D:\repos\godot\core\os\thread.cpp(78)
[External Code]
godot.windows.tools.64.mono.exe!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97
	at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(97)
[External Code]

Steps to reproduce

Create a CSharp script that inherits from AtlasTexture. Can be simple as:

using Godot;
[Tool] public class CustomTexture : AtlasTexture
{
  private CustomTexture() {}
}

In the Godot editor, compile.
In the Godot file explorer, create a new blank AtlasTexture resource.
In the Godot inspector, drag the CustomTexture.cs onto the script field.
(Editor is usually fine at this point. Can recompile and keep working with no errors. CustomTexture and its script will work as expected.)
Close Godot and re-open it. The editor will crash. (You may have to open a scene to get it to crash.)
You will get no info on the command line. If you delete the .mono folder and open the editor, it will once again run even after compiling. Once you restart, it will again crash.

Minimal reproduction project
bug_CustomTexture.zip

It seems the crash happens when Godot instantiates the custom class (since it's a Tool), specifically when trying to get the value of the nativeName field. I don't know why this would crash since the field is there in the AtlasTexture class. I've also noticed the same crash with other resource types.


Get travis working or switch to another CI system that works with github

Could you investigate?

I turned travis off because ember-collection doesn't build with phantomjs, as it uses requestAnimationFrame. I tried a polyfill but it didn't work. I also opened an issue with ember-collection.
We may want to try circle-ci ... also we may move away from ember-collection. I'm going to try to improve scrolling performance this weekend -- hopefully will be decisive one way or another.
I'll change title to track need for CI.
How did you're talk go?

Turned travis back on as we've dropped ember-collection


Tables in K8s docs use GitHub-flavored Markdown

This is a...

[x] Feature Request
[ ] Bug Report

Problem: It's not clear in our contribution guidelines that K8s docs use GitHub-flavored Markdown. A user encountered difficulty with table formatting.
Proposed Solution: Add a note to the style guide indicating that K8s docs use GitHub-flavored Markdown.
Page to Update:
https://kubernetes.io/docs/home/contribute/style-guide/

@zacharysarah I can handle this one if you like.

@bradtopol Awesome. Go for it!

Hey @bradtopol are you still working on this? If not can I take this?

Closed by #6229


Support for date-only string field

Are there plans for implementing in the near future?
I read up on https://github.com/colinhacks/zod/issues/126 and was delighted to hear about the z.string().datetime() update, however as @colinhacks mentioned at the end of his final reply in the thread, this does not cover date-only scenarios. Also, something to keep in mind is that while the string regex approach is trivial, it does not account for invalid dates in the right format (ex. 2020-15-01).
I am currently implementing via a custom transform function:
import { z } from "zod";
import moment from "moment";

export const date = () =>
  z.string().transform((date, ctx) => {
    if (!/^\d{4}-\d{2}-\d{2}$/.test(date)) {
      ctx.addIssue({
        code: "invalid_date",
        message: mustBeDateOnlyFormatMsg,
      });
      return z.NEVER;
    } else if (!moment(date).isValid()) {
      ctx.addIssue({
        code: "invalid_date",
        message: invalidDate,
      });
      return z.NEVER;
    }

    return new Date(date);
  });

However I feel that this should be natively supported as it is a common use case:
import { z } from "zod";

/**
* Valid date only string field.
* Has the same effect as the transform function mentioned previously.
* Would be nice also to parameterize the format i.e DD/MM/YYYY, MM/DD/YYYY etc.
*/
z.string().date()

/**
* Valid time only string field.
* Would have to solve the same issue mentioned but w/ invalid times.
* i.e 12:79 should not be accepted.
*/
z.string().time()

Just saw a previous issue and a pull request already approved for this. Is there an ETA on its release?