Convert to integer type of property value when sorting.

sort_by_* methods will return expected results when serialization values type is numeric string, too

Looks great I merged it into my fork dsmorse/gridster.js


Buttons have dark left top and bottom corners

Bug, feature request, or proposal:
Buttons have dark left top and bottom corners.
What is the expected behavior?
To be like right ones.
What is the current behavior?
Dark left top and left bottom corners
What are the steps to reproduce?
Just test the newest stable version of Angular Material.
What is the use-case or motivation for changing an existing behavior?
Better look
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular: 6.0.4
Angular Material: ^6.2.1
Is there anything else we should know?

Can you show an example of where you're seeing the error? The buttons look good to me.

I have posted screenshot.

Can you also post your markup?

Ok, I can see now what is wrong. Left top and bottom corners are dark when I attach mat-elevation-z0 class to mat-button like so:
<button class="mat-elevation-z0" mat-button color="primary">Renew</button>

so it is my fault I guess?

It looks like you might have something else at play in your styling for you app.  You can see a reproduction here that does not seem to have the corner issues that you mentioned.


Disable dockable figure option when matplotlib is not patched

From pierre.raybaut on 2010-04-07T12:59:42Z
---
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=190

From pierre.raybaut on 2010-04-08T23:04:25Z
Status: Fixed


Move to 64bit images

Pros

more performant CPU
more software support

Cons

more memory use, up to 50% more.
doesn't work with RPi Zero
wheels from piwheels are not available, so we requiring building wheels locally
(longer custopizer build, and anything that is pip installed)

Starting from next release, we are including 64 bit images on the CustoPizer release page: https://github.com/Pioreactor/CustoPiZer/releases


Tabs only

I want to show Tabs only, is this possible?

Solution
<ScrollableTabView style={{ flex: 0 }}>
  <View tabLabel="Tab 1" />
  <View tabLabel="Tab 2" />
</ScrollableTabView>

Above solution is working fine, but has only underline issue on Android. Underline animation is not working on if ScrollableTabView's flex is 0
<ScrollableTabView style={{ flex: 0 }}>
  <View tabLabel="Tab 1" />
  <View tabLabel="Tab 2" />
</ScrollableTabView>

Ran into the same issue, solved it by wrapping ScrollableTabView in a View and setting the height.
<View style={{ height: 50 }}> // can also use flex
  <ScrollableTabView>
    <View tabLabel="Tab 1" />
    <View tabLabel="Tab 2" />
  </ScrollableTabView>
</View>

@miguelc1221 Is tab underline animation working?


Question regarding thread safety

I would like to use yara-java in a multithreaded environment. Which classes can be reused across multiple threads and which cannot? I am using the same rules for all files that I scan. In a simple performance test I get close to a 50% performance increase when reusing the YaraScanner object. I just don't know if it is safe to do so.

I just submitted a pull request #15 for enabling multithreaded reuse

Merged pull request, thanks!


How to fix "httpheader.conf" problem in GatewayServer

In this year's GatewayServer code, there's a configuration file named httpheader.conf in TarsGateway/conf folder.
However, when we compling and install the GatewayServer , this file is not upload, and in webpage the massage "[fail] get remote config 'httpheader.conf' error:remote config file is empty:httpheader.conf" is shown.  Even when we manually put  httpheader.conf into BasePath: tarsnode/data/Base.Gateway/bin ,the error massage is still shown.
Please help us to resolve.

Add httpheader.conf on tarsweb management platform


Postgres databse for gateway - psycopg2 missing in dependencies

We wanted to use a postgres database instead of the default sqlite for the gateway and the nodes. For the nodes it was not a problem but for the gateway. When comparing the two dockerfiles I found, that the node installs the but the gateway is not.
In the gateway's network/pyproject.toml the dependency psycopg2-binary = "^2.8.5" is missing ([tool.poetry.dependencies]) while in the node/pyproject.toml it is available. That led to my mistake, that psycopg2 module is missing.
Assuming that was by mistake, it would be great to fix that and include psycopg2 for both.
Additional Context
I fixed it for myself by updating the pyproject.toml, (installing poetry), poetry update (to update the lock file) and building my own container-version.

Resolved with SQLAlchemy.


Update version to 42.1.0, add CHANGELOG (#12986)

Which issue does this PR close?
Part of https://github.com/apache/datafusion/issues/12813
Rationale for this change
I am making a 42.1.0 release and main should also reflect the release
What changes are included in this PR?
Port changes from https://github.com/apache/datafusion/pull/12986

Update main to be 42.1.0
Add release notes

Are these changes tested?

Are there any user-facing changes?

Perhaps we can merge this once we have completed the actual release

FYI @andygrove


Fix typo in masthead.html

utilites -> utilities
Thanks to adb on Slack for the report.

Ha! @thevipinmishra was faster. Duplicate of #36658.


Revert on dn404Fallback if fn selector is not recognized.

This tripped us up as it causes incorrect method calls to succeed silently rather than revert:
Incorrect call: https://sepolia.etherscan.io/tx/0x1383a9632316ab2b8f8d505422aeead15ba15d041534de53765b2e4739d8cf29
Correct call: https://sepolia.etherscan.io/tx/0x6933ad54b8c372f6b003a09cf02be6c3cee40b7b7fe3bfca2d6fa6723bbddc06
My proposed solution:
https://github.com/guminc/contracts/pull/76/commits/72dd9c38df50e45c40ff429416061b3d04d09451

Looks good. We might add it.


Joints Order

@weigq  Hello! I've run train_2d_ft.pth.tar and test_2d_ft.pth.tar on other models, whose performance is very poor. So I want to know if the train_2d_ft.pth.tar contains the same kind of joints and the same order of joints as it did on train_2d.pth.tar and train_3d.pth.tar ? Thanks!

Yes


swift 2.2

Hello, could you put back the swift 2.2 version of your code please?
Best regards

@tirrorex , I'm attaching a zip file of the last version of Threading.swift before it was converted to swift 3. It is commit 9de5eebbe5a6347266816e0cf80d79a2717e73ae.
Can you closed this if this answers your request, or if this issue no longer applies?
Thanks,
David
Threading.swift.zip


Nil the tableview delegate and data sources when dealloc

We were having an issue with what seems like the table view's delegates being retained. This should prevent that from happening now.

Thanks @ericlewis!
dataSource and delegate are declared with assign semantics in both UITableView and UICollectionView, so they should never be retained and you might have something else going on in your app. This is still a good addition though!

@ericlewis I'm making one small tweak to remove references here to delegate. SSDataSources does not serve as the table or collection's delegate, so it doesn't seem right to have a data source deallocating cause the delegate property to be nil'd out.

It could be something else, but we basically tracked it down to the core data portion of this frame work acting kind of funny with trying to fire a delegate method which no longer exists on the table view.
—
Sent from Mailbox
On Mon, Apr 27, 2015 at 5:24 PM, Jonathan Hersh<EMAIL_ADDRESS>wrote:

@ericlewis I'm making one small tweak to remove references here to delegate. SSDataSources does not serve as the table or collection's delegate, so it doesn't seem right to have a data source deallocating cause the delegate property to be nil'd out.
Reply to this email directly or view it on GitHub:
https://github.com/splinesoft/SSDataSources/pull/52#issuecomment-96856544

@ericlewis Okay, but hopefully you mean a dataSource method, as SSDataSources is most assuredly not serving as your delegate :)

Yeah, a data source method. :) quite odd indeed!
—
Sent from Mailbox
On Mon, Apr 27, 2015 at 5:27 PM, Jonathan Hersh<EMAIL_ADDRESS>wrote:

@ericlewis Okay, but hopefully you mean a dataSource method, as SSDataSources is most assuredly not serving as your delegate :)
Reply to this email directly or view it on GitHub:
https://github.com/splinesoft/SSDataSources/pull/52#issuecomment-96856806


[Screengrab] Can't get screenshot when debuggable is false

New Regression Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Regression Information

Breaking version: 2.156.0
Last working version: 2.155.3

Regression Description
In version 2.155.3 screengrab was able to pull screenshot taken on a not debuggable build but in all newest version it can't.
It's seems to be because of use of run-as implemented here https://github.com/fastlane/fastlane/pull/17006
Complete output when running fastlane, including the stack trace and command used

INFO [2020-10-30 17:08:38.24]: Pulling captured screenshots for locale en-US from the device
DEBUG [2020-10-30 17:08:38.24]: Starting screenshot count is: 0
INFO [2020-10-30 17:08:38.26]: ▸ run-as: package not debuggable:
run-as: package not debuggable:
ERROR [2020-10-30 17:08:38.26]: Exit status: 1
INFO [2020-10-30 17:08:38.28]: ▸ run-as: package not debuggable:
run-as: package not debuggable:
ERROR [2020-10-30 17:08:38.28]: Exit status: 1
INFO [2020-10-30 17:08:38.29]: ▸ run-as: package not debuggable:
run-as: package not debuggable:
ERROR [2020-10-30 17:08:38.29]: Exit status: 1
INFO [2020-10-30 17:08:38.31]: ▸ run-as: package not debuggable:
run-as: package not debuggable:
ERROR [2020-10-30 17:08:38.31]: Exit status: 1
INFO [2020-10-30 17:08:38.33]: ▸ run-as: package not debuggable:
run-as: package not debuggable:
ERROR [2020-10-30 17:08:38.33]: Exit status: 1
DEBUG [2020-10-30 17:08:38.33]: Ending screenshot count is: 0

I don't know if faslane env is really needed for this issue, if you need more informations, don't hesitate to ask :)

I had the same issue, the temporary fix is:
In app/build.gradle
buildTypes {
release {
// Fastlane needs the app to be debuggable when making screenshots
debuggable project.hasProperty('DEBUGGABLE') ? project.getProperty('DEBUGGABLE').toBoolean() : false

///...
}
}

and in the Fastfile
      gradle(
        task: 'assemble',
        build_type: 'Release',
        flavor: org,
        properties: {
          'versionCode' => versionCode,
          'versionName' => versionName,
          # Used for Fastlane capture_android_screenshots
          'DEBUGGABLE' => true
        }
      )


Names above Messages, Styling Upgrades

names above messages
refactor on text avatars
refactor on operator avatars
sticky footer
responsive cards
trash can icon for delete

@kgang I'm pulling messages by created_at from the DB, but since it's of type datetime | None mypy is unhappy with it. Are we able to convert the type?

Oh yeah sorry, I don't think we're doing anything with created at in particular. Could remove the nullable


CORS-2517: migrate from ADAL to azidentity

ADAL is being deprecated, so use the new authentication library azidentity with an adapter so it works with old SDK clients.

/hold
while I try to understand what's different about the e2e-azure-operator job.

/test e2e-azure-operator

that error does look odd, perhaps it is just a flake.

/retest-required

Had a quick scan through the logs and the machine controller appears to be working relatively ok, lets try those tests again
/retest-required

/retest-required
A single cluster autoscaler test failed, I think we are probably OK to skip as I don't think this PR is causing that, but will try once more

Rebased to fix merge conflicts.

/approve
/retest-required

The test failed this time on an autoscaler test, which we have been seeing sporadically across the board, I don't think it's related to the changes here
@elmiko @RadekManak did you have any additional feedback or are you happy to LGTM this?
/retest-required

@r4f4 Do we still need a hold on this?

Ops, no we don't.
/hold cancel

/retest-required

Rebased to fix merge conflicts.

@elmiko if this looks good, you'll need to stamp it again. Tks.

/lgtm


Bulk Update Progress Logs

It would be nice to be kept up-to-date with the progress that the bulk update is doing using logs to the console. For example:

Which page is currently being worked on.
Total number of rows updated.
Timings (if you're updating 100 batches of 10,000 rows getting a time estimate of the first page gives you a reference for the whole job).
Log and display any errors (this could probably be a separate issue).

Just a couple of suggestions for a great library, cheers!

That would be very useful. However I'm not familiar with logs.
Do you think you would be able to implement it in a PR?


Same point cloud input - different numeric results

Hi, @HuguesTHOMAS
First of all - great work, and extremely well documented!
After training your model using the ModelNet40 config, I am doing some testing on new dataset (the remarks and readme were very helpful).
I receive 2 different outputs for the same point cloud as input to the network (using ModelNet40 config, deformable conv, output is the layer before the classification head).
The differences are significant in values (up to 0.25 of the vectors Norm)
run command is
sess.run(ops, {model.dropout_prob: 1.0})
Is it a normal behavior of the model? is any part of the computation is non-deterministic?
Thanks,
Ran

Edit:
Found it might be a bug in another place (my modifications).
closing, will re-open after further investigation if needed

HI @RanBenIzhak,
The only non deterministic part in the computations is the data augmentation process. You can disable it by changing the related parameters in the config after loading it and before starting the model. if you have already done that, the result should be the same for two identical input point clouds.
Best,
Hugues


evaluator: syntax accepts bytes literal for field name but should not

What version of CUE are you using (cue version)?

$ cue version
cue version v0.0.0-20230211165554-7d89acd5c44b

go version devel go1.21-a4d5fbc3a4 Thu Feb 9 21:14:00 2023 +0000
      -buildmode exe
       -compiler gc
     CGO_ENABLED 1
          GOARCH amd64
            GOOS linux
         GOAMD64 v1
             vcs git
    vcs.revision 7d89acd5c44bca0c756f76089436ee9913818b03
        vcs.time 2023-02-11T16:55:54Z
    vcs.modified false

Does this issue reproduce with the latest stable release?
Yes
What did you do?
testscript -continue on the following script:
! exec cue eval bytes-field-name.cue
! exec cue eval bytes-field-name-invalid-unicode.cue
! exec cue eval string-field-name-invalid-unicode.cue
stdout 'invalid syntax'
! exec cue eval multiline-field-name.cue

-- bytes-field-name.cue --
'foo': 1
-- bytes-field-name-invalid-unicode.cue --
'foo\xff': 1
-- string-field-name-invalid-unicode.cue --
"foo\xff": 1
-- multiline-field-name.cue --
"""
foo
""": 1

What did you expect to see?
A passing test.
What did you see instead?
> ! exec cue eval bytes-field-name.cue
[stdout]
foo: 1
FAIL: /tmp/testscript437841562/x.txtar/script.txtar:1: unexpected command success
> ! exec cue eval bytes-field-name-invalid-unicode.cue
[stdout]
"foo�": 1
FAIL: /tmp/testscript437841562/x.txtar/script.txtar:2: unexpected command success
> ! exec cue eval string-field-name-invalid-unicode.cue
[stderr]
cannot use _ as label:
    ./string-field-name-invalid-unicode.cue:1:1
[exit status 1]
> stdout 'invalid syntax'
FAIL: /tmp/testscript437841562/x.txtar/script.txtar:4: no match for `invalid syntax` found in stdout
> ! exec cue eval multiline-field-name.cue
[stdout]
foo: 1
FAIL: /tmp/testscript437841562/x.txtar/script.txtar:5: unexpected command success

The spec seems fairly clear that only a simple double-quoted string literal should be allowed as a field name, not a bytes literal or a multiline literal:
Field           = Label ":" { Label ":" } AliasExpr { attribute } .
Label           = [ identifier "=" ] LabelExpr .
LabelName       = identifier | simple_string_lit  .
simple_string_lit    = `"` { unicode_value | interpolation } `"` .

This means that none of the examples above should be allowed.
One outlier in those examples is the error message produced when there's an invalid unicode sequence inside a simple string literal inside a field. It does fail, but the error message (cannot use _ as label) is abstruse.

Per chat with @mpvl and @myitcv, we think it would be a nice transition to use cue fix to rewrite any fields using byte literals to using string literals instead. This should work fine for any such fields which use valid UTF-8 values. Any which aren't valid UTF-8 can be an error, which would surface any potentially valid use case we would be breaking. We could fully remove support for bytes as fields in a later release.


Support creating notes given location on staff

Dependent on #91. Given the clef information, you should be able to take a location (line/space) on the staff and convert it into a Tone. This should be a new initializer on Tone. Also, you should be able to get the (noteLetter, accidental, octave) or staff location for any Tone.
I think you will need to pass the Clef into the Tone initializer in order for this to work.

Dependent on #95


add missing security rulse about NULL check to doc

Checklist

[x] documentation is added or updated

Thanks for the feedback. I'll fix the issues.

Typo : rulse in Commit Message

ping @openssl/committers for the second review

BTW, why do we have ABI label for doc-only changes?..

This pull request is ready to merge

Merged to the master branch. Thank you for your contribution.


Add experimental CFG recovery frontend based on Dyninst

Dear McSema maintainers,
arguably, one of the greatest obstacles to using McSema today for many people is its dependency on IDA Pro. In an effort to attack this problem, I (together with a fellow student as part of a laboratory course in computer science at the University of Erlangen-Nuremberg) have started to implement an alternative control flow recovery frontend for McSema based on the Dyninst API.
Of course, at this point, this frontend is not nearly as refined as the IDA Pro frontend and has to be considered experimental, but we have already been able to use it to successfully lift and recompile a variety of smaller applications, some of which we have included as test cases in this pull request.
We have also included a README.md file with information regarding how to build and run mcsema-dyninst-disass. In particular, it is necessary to build and install DyninstAPI before this frontend can be built. The actual build process uses CMake and is integrated with the McSema build.
Given the experimental state of this frontend, there are still quite a few limitations. This frontend currently only supports 64-bit ELF binaries, has only been tested on Linux, does not yet support external data symbols properly, can't handle unstripped binaries and, of course, still needs lots of debugging and further development.
We hope that this pull request will enable other developers to contribute to this effort or at least help explore possible alternatives to IDA Pro as a disassembler and control flow recovery engine.
We'd be glad if you could have a look at this. Thank you!
Regards,
Fabian Wolff (and Chris Baller)

Can this be made to work with the use_remill_semantics branch? We have a milestone to make this branch into the new master. The protobuf should be a bit simpler there :-)

FYI: I know this is still here and I will get around to it :-)

What do we need to do to merge this?

I have attempted to modify my code to use the new Protobuf format from the use_remill_semantics branch, but it does not currently seem to work for any non-trivial binaries yet. In essence, in order to merge this, somebody would have to fix this.
However, it is hard for me to find the time to work on this, which is why I have pushed the old code (that uses the old Protobuf format) to a different branch. That way, if anybody wants to help, they can look at how the necessary information was retrieved in the old version and then port that to the new version.

Would love to see this updated / fixed and merged.  It's a real shame the project is currently locked to the proprietary IDA tool -- normally I'd try to do something about this but just don't have time right now.


YBaseDoc as abstract class

Should we use an abstract class instead of:
https://github.com/jupyter-server/jupyter_ydoc/blob/ac934c369b1b5776d2981cd42a9a3b6fc08df145/jupyter_ydoc/ydoc.py#L41-L48
At least the Python practice is such case advice to raise the more specific NotImplementedError (that derives from RunTimeError).

Do you mean to make these methods abstractmethod? That would require an implementation of them, but we can imagine that a document doesn't implement all of them, right?

Do you mean to make these methods abstractmethod?

Yes

That would require an implementation of them, but we can imagine that a document doesn't implement all of them, right?

Not having them is not consistent with the current implementation as the source property is calling get and set and unobserve calls for an implementation of observe. So I would consider a class that does not implement them as broken; the main proof being that it will break the server handler that assumes source (getter and setter) and observe are implemented.
https://github.com/jupyter-server/jupyter_server_ydoc/blob/201bd2ebdb8e618d07f0f1125b746c51007ffe19/jupyter_server_ydoc/ydoc.py#L269-L277
https://github.com/jupyter-server/jupyter_server_ydoc/blob/201bd2ebdb8e618d07f0f1125b746c51007ffe19/jupyter_server_ydoc/ydoc.py#L171

unobserve calls for an implementation of observe

I think you meant the opposite: observe calls for an implementation of unobserve.

the main proof being that it will break the server handler that assumes source (getter and setter) and observe are implemented.

I see your point, I'm just thinking what would be the best solution. I think requiring an implementation of get is the minimum, but maybe set could have a "no-op" default implementation? That would correspond to a document that is read-only. Similarly observe could have "no-op" default implementation?
Or should a consumer of jupyter-ydoc (e.g. the server) try to call these methods, and handle exceptions?

set could have a "no-op" default implementation? That would correspond to a document that is read-only.

No-op is bad; raising an error is better (let's not do forgiving JavaScript :wink: ).
I'm not sure we should consider the read-only case because for instance if we keep the public ydoc this will never be truly possible.

Similarly observe could have "no-op" default implementation?

Same here, I would rather raise an error that doing nothing. As a dev, I would get a hard time figuring out why my callback is not called.
For me it should definitely be mandatory as there is no point of being unable to observe a collaborative document.
And again as the ydoc is public, there is a way around not-implemented observe. But we should prefer to enforce a homogeneous interface rather than plenty of workarounds.

I agree, I'll open a PR to make YBaseDoc an abstract base class.
Thanks for the feedback!


Generate and validate also the non-geometry columns of geopackages

Currently only the geometry columns are generated with generate-definitions. This has to be expanded to all the columns.
These columns also need to be validated in the validate step.

Register column_name and column_type for non geometry columns


Adding Musicoin back to MEW

Musicoin recently had a hardfork which enables EIP 155 and that should ideally make it work with MEW .(ref. #912) I can PR back with the code if the MEW devs are okay with adding Musicoin back, so do let me know reg this. Thanks!

@Varunram go ahead and make a PR for it. I'll close this issue now. Don't hesitate to open it.


Obsidian Version Mismatch

As I stated on the Forums, I attempted to use BRAT to install your plugin.
Expected result:
Install the plugin, see if it works.
Achieved result:
an error message from BRAT saying, "Your plugin says that Obsidian must be version 1.16.  Please update your Obsidian and try again."  I imagine this is an oversight either here or elsewhere... I wanted to point it out so that you can get this lovely plugin off the ground.  Can't wait!
Thank you for your hard work. Can't wait to see what happens.

Thanks for checking out the plugin and providing feedback!
This was indeed a typo. Looking into how BRAT works revealed the git tags were also formatted incorrectly. I've patched these problems and was able to get it installed with BRAT after the fixes. Please feel free to give it another go and let me know if you hit any further snags.

That absolutely worked. Thank you.  Looking forward to using this especially in conjunction with Obsidian's new "Importer" plugin to bring in my old EN notes.


Crash on multiplayer server

Hi! I'm using version 2.0 of the mod, but unfortunately my server won't start up when the mod is on it.
crash-2023-12-17_12.24.33-fml.txt

Thanks for reporting!
Looks like it's loading some GUI files which don't exist on the server. Should hopefully be easy to reproduce.

The latest version should fix the crash: https://github.com/doc-bok/Butterflies/releases/tag/2.0.1
Enjoy and feel free to report any other problems you may find.


Logger filter tree view

Finished Log Tree View:

Added Logger Frequency
Added Log Tree View to Preferences

Logger Name Panel doesn't dynamically swap when preference is changed.
Currently need to select the Log Tree preference & open a system log file to use this functionality.

Summary of previous two commits:

Tree nodes should be sorted, and/or support the same sorting options as the list view
Tree nodes are now sorted alphabetically

Tree nodes need a better icon. It should be consistent between 'leaf' and 'folder' nodes, because there's no distinction to the logger system and many cases where a 'folder' logs messages as itself
Removed the icons entirely. There's no point in having them.

We should install a Searchable so that you can quickly type to select the thing you want if you already know its name
Done

Expand/collapse all buttons are always nice on trees
Added right-click to the tree to expand/collapse all. (Doesn't collapse the root node).

In addition to the inclusive/exclusive filters on the context menu, a 'locate this logger in the tree' context menu option would be appreciate
Added right click menu to table: "Focus In Tree".

6.. I'm not sure this needs to be a dependent setting. I think I'd rather have it be a top level setting that's independent of 'show full logger names', which should only apply to the 'regular' list view.
As much as I really wanted to used my dependent preference idea, this is a fair point. I removed the dependency and now they can be toggled separately. This lets the user view compact names in the table while still browsing in the tree.
7.. Along those lines, I think it would be nice if the right click menu on the sidebar gave you an option to switch presentation style (and maybe, if you right click in the regular list, gives you an option to switch to full names/short names)
Implemented

@paul-griffith It might be worth taking another look at the filter() function in LoggerNamePanel one more time.
filter() is called on every log event. In tree mode, this means that depthFirstChildren is called for every log event to get the current selected leaf nodes.
The current impl after your changes has a dynamic getter which calls back to the depthFirstChildren for each log event. Our original impl had a var which was reassigned every time the tree filter changed, which let us calculate the selectedLeafNodes only once per filter change, instead of once per log event per filter change.
The performance increase seems noticeable with the original impl.


Provide trained checkpoints for the examples.

It would be great if Flax provided trained checkpoints for the models in the examples/ directory. Some of these models are quite useful by themselves or could be made even more useful with some fine-tuning, but the training cost is substantial.

This is a duplicate of #707


make localintegration hang + timeout on test 73

Description
Seemingly randomly, when running CI tests on PRs, RHEL systems are "hanging" after integration test 72.  I haven't seen this on any Fedora systems.
Steps to reproduce the issue:

Configure a RHEL system as per integration test README
Run playbook with 'setup' tag
Shutdown VM - take snapshot
Start VM, run playbook with 'integration' tag

Describe the results you received:
...humming along fine...
ok 70 Check for valid pod netns CIDR
ok 71 Ping pod from the host
ok 72 Ping pod from another pod

Describe the results you expected:
Tests should continue running
Additional information you deem important (e.g. issue happens only occasionally):
see pd_notes.txt
Output of crio --version:
crio version 1.10.0-dev
commit: "545f30e889017eaea66c911280c54ad47be58764-dirty"

Additional environment details (AWS, VirtualBox, physical, etc.):
RH-internal VM has been 'paused',  I can provide access to poke around as needed.

@rhatdan @mrunalp @wking When you get a moment, PTAL attached-file in description.  I'm happy to provide any other details from the VM as needed, just let me know.

Previous discussion on this issue starts here, although it has come up in a number of pull requests before.

@cevich Can you get the kernel version? (Looks like it could be a kernel bug).

@mrunalp / @wking yep, one sec...
[root@cevich-crio-testing ~]# uname -a
Linux cevich-crio-testing 3.10.0-693.17.1.el7.x86_64 #1 SMP Sun Jan 14 10:36:03 EST 2018 x86_64 x86_64 x86_64 GNU/Linux
[root@cevich-crio-testing ~]# rpm -q kernel
kernel-3.10.0-693.el7.x86_64
kernel-3.10.0-693.17.1.el7.x86_64

Dunno what 8001 was, it's gone now, but crio is there and sleeping (expected, under the circumstances)
[root@cevich-crio-testing ~]# ps waux | grep crio
root      7973  0.0  0.1<PHONE_NUMBER>4 ?        Sl   13:58   0:00 /go/src/github.com/kubernetes-incubator/cri-o/bin/crio --log-level debug --config /tmp/tmp.D3iBmtQziC/crio.conf
root      8447  0.0  0.0<PHONE_NUMBER>0 ?        Sl   13:58   0:00 /usr/bin/crictl -r /tmp/tmp.D3iBmtQziC/crio.sock -i /tmp/tmp.D3iBmtQziC/crio.sock runp /go/src/github.com/kubernetes-incubator/cri-o/test/testdata/sandbox_config.json

Dunno what 8001 was, it's gone now…

Maybe grepping for it in the logs will turn something up?

Maybe grepping for it in the logs will turn something up?

Tried :(  even looked in the hoards of files under /tmp and all of /var/log.  Are we sure that's a PID?  Does CRI-O daemon fork/exec child processes, b/c it's pid (above) is only 7973.  Seems odd it would have wrapped around so quickly.

I should add, those kernel messages have stopped now (since pausing/unpausing the VM).  Though that could/maybe because I suspended the ansible procs(?).  Here're all the recent stuff:
root      9446  0.0  0.0 151064  1800 pts/1    R+   15:10   0:00 ps waux
root     12741  0.0  0.0 151204  4252 ?        T    13:52   0:00 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1520362321.92-189924
root     12742  0.0  0.0 151204  4452 ?        T    13:52   0:00 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1520362321.92-189924
root     12743  0.0  0.0 189640  8120 ?        T    13:52   0:00 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1520362321.92-189924
root     12744  0.0  0.0<PHONE_NUMBER>8 ?        T    13:52   0:00 /usr/bin/python /tmp/ansible_q4wa3Y/ansible_module_command.py
root     12745  0.0  0.0 113128  1216 ?        S    13:52   0:00 /bin/sh -c CGROUP_MANAGER=cgroupfs STORAGE_OPTIONS='--storage-drive
root     12746  0.0  0.0 108848  1756 ?        S    13:52   0:00 make localintegration
root     14102  0.0  0.0 113264  1604 ?        S    13:52   0:00 bash ./test/test_runner.sh
root     14127  0.0  0.0 113128  1552 ?        S    13:52   0:00 bash /usr/local/bin/bats --tap .
root     14159  0.0  0.0 113132  1536 ?        S    13:52   0:00 bash /usr/local/libexec/bats-exec-suite /go/src/github.com/kubernet
root     14160  0.0  0.0 107924   352 ?        S    13:52   0:00 cat
root     16409  0.0  0.0      0     0 ?        S    13:52   0:00 [kworker/6:3]
root     16947  0.0  0.0      0     0 ?        S    13:54   0:00 [kworker/3:6]
root     22984  0.0  0.0      0     0 ?        S    13:52   0:00 [kworker/0:3]
root     27078  0.0  0.0      0     0 ?        S    13:53   0:00 [kworker/4:3]
root     29859  0.0  0.0      0     0 ?        S    13:53   0:00 [kworker/0:4]
root     31161  0.0  0.0      0     0 ?        S    13:53   0:00 [kworker/1:7]
root     31162  0.0  0.0      0     0 ?        S    13:53   0:00 [kworker/1:8]
root     31530  0.0  0.0      0     0 ?        S    13:53   0:00 [kworker/2:3]
root     32344  0.0  0.0 113132   632 ?        S    13:58   0:00 bash /usr/local/libexec/bats-exec-suite /go/src/github.com/kubernet
root     32345  0.0  0.0 113396  1800 ?        S    13:58   0:00 bash /usr/local/libexec/bats-exec-test /go/src/github.com/kubernete

Possibly relevant patches since v3.10:
linux$ git log --oneline --grep=cleanup_net v3.10..origin/master
fb07a820fe3f net: Move net:netns_ids destruction out of rtnl_lock() and document locking scheme
0c06bea919f3 net: Fix possible race in peernet2id_alloc()
21b594435005 net: Fix double free and memory corruption in get_net_ns_by_id()
681648e67d43 rds: tcp: correctly sequence cleanup on netns deletion.
623859ae06b8 Merge branch 'net-sched-race-fix'
e4b95c41df36 net_sched: introduce tcf_exts_get_net() and tcf_exts_put_net()
8ca712c373a4 Merge branch 'net-speedup-netns-create-delete-time'
84657984c26f netfilter: add and use nf_ct_unconfirmed_destroy
52a623bd6189 Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next
34158151d2aa netfilter: cttimeout: use nf_ct_iterate_cleanup_net to unlink timeout objs
b0feacaad13a netfilter: conntrack: don't call iter for non-confirmed conntracks
9fd6452d67fb netfilter: conntrack: rename nf_ct_iterate_cleanup
723b929ca0f7 ip6mr: fix notification device destruction
b768b16de58d openvswitch: Fix refcount leak on force commit.
3d3d18f086cd drm/i915: Avoid rcu_barrier() from reclaim paths (shrinker)
bd784b7cc41a drm/i915: Avoid rcu_barrier() from reclaim paths (shrinker)
ec7cb62d18d8 net/dccp: fix use after free in tw_timer_handler()
12d656af4e3d l2tp: Avoid schedule while atomic in exit_net
cfc44a4d147e net: check dead netns for peernet2id_alloc()
002d8a1a6c11 net: skip genenerating uevents for network namespaces that are exiting
1f461dcdd296 ppp: take reference on channels netns
bd678e09dc17 netfilter: nfnetlink: fix splat due to incorrect socket memory accounting in skbuff clones
0a15afd2eace vrf: fix a kernel warning
0838aa7fcfcd netfilter: fix netns dependencies with conntrack templates
f13b1689d753 vxlan: do not exit on error in vxlan_stop()
ad88d0513638 fib_trie: Fix warning on fib4_rules_exit
4762fb980465 ipv6: fix possible deadlock in ip6_fl_purge / ip6_fl_gc
21e81002f978 nfs: fix kernel warning when removing proc entry
41a212859a4d slub: use sysfs'es release mechanism for kmem_cache
8142b227ef43 netfilter: nf_conntrack: flush net_gre->keymap_list only from gre helper
b4ef4ce09308 netfilter: xt_hashlimit: fix proc entry leak in netns destroy path
0c3c6c00c696 netfilter: nf_conntrack: decrement global counter after object release
905a6f96a1b1 ipv6: take rtnl_lock and mark mrt6 table as freed on namespace cleanup

Although I'm not sure if any of those have been backported to your kernel.  Any chance of trying this on a more recent kernel?

Are we sure that's a PID?

No, maybe it was something else.

Possibly relevant patches since v3.10:

Jeepers! Look at all the networking-related items.

Jeepers! Look at all the networking-related items.

v3.10 was cut in 2013, I'm not surprised that a few bugs have been fixed in the past five years ;).

For RHEL, we would have been backporting all the important ones, but it's still possible we missed the one causing this problem.  I could try booting another VM from snapshot, updating to a RHEL 7.5 kernel, and try again.  But the hit/miss nature of this problem would translate into doing lots and lots of runs :confounded:

/me goes wandering around bugzilla and google...

This is interesting (though WAY above my pay-grade)
Specifically, the call trace at the end seems to very closely resemble that of the CRI-O process in this case.  Maybe the next step could be to try and see if that patch exists in the RHEL kernel...

...oh, and I found it interesting the problem scales w/ number of CPUs.  This VM has 8 setup, and I know that our origin-ci setup allocates a bunch as well.  That could also maybe explain why the traces in the journal have since stopped.  Total guess though.

ref: actual submitted/proposed patch  Still way out of my league here though, stabs in the dark really.

On Tue, Mar 06, 2018 at 09:35:38PM +0000, Chris Evich wrote:

ref: actual submitted/proposed patch

Looks like that landed in torvalds/linux@e88a276 as part of v4.9-rc7.
Has it been backported to the Red Hat kernels?  It may also be fixing
a bug added since 3.10 (the commit message references 4.5), although I
guess the bug might have been backported too ;).

@rhvgoyal Any thoughts?

There has been previous discussion about bumping the current 5400s timeout.  But the history for integration tests is around 20 minutes on Fedora (excepting errors like this hang).  It's been 5400s since  e160796d4 (#927), before which it was two hours.  The two-hour value is from 78c400ccd (#928), before which it was one hour.  I'm not sure what was causing the one-hour timeouts referenced in #928, but with consistent 20 minute success we may want to adjust the integration timeout back down to an hour to catch the hangs a bit quicker.
The RHEL integration times are also around 20 minutes on success, although those are hanging quite frequently due to this issue.  It may be worth comparing the Fedora and RHEL kernels to see if that sheds light on the underlying kernel issue.

comparing the Fedora and RHEL kernels to see if that sheds light on the underlying kernel issue

I can say without looking, the Fedora kernels are going to track upstream much more closely.
Regarding timeouts, I'm in half-agreement.  There needs to be a balance struck between:

Likely to survive occasional random networking/service SNAFUs
Burning engineer-time waiting for a PR run to complete

That said, the current situation is way way way off-kilter for the second item (IMHO).  All else being equal, I'd call that the elephant in the room.  I'd really like to see all the tests broken up across additional VMs, so they can all complete w/in 45-minutes (or so) total.  That would support having a timeout close to about 60min (each), which is far more cost-effective from a trouble-shooting-speed standpoint - def. the most costly engineer-time.
Unf. I lack the knowledge (of the tests themselves) to even know where to begin :confounded:

How is crio logging configured?  I see a --log argument, but no associated entry in cmd/crio/config.go.  And logrus defaults to info-level logging.  Yet journals/crio.service is empty in the integration_rhel tests.  I think seeing a bit more detail from crio about what it was up to would help us figure out where it was locking up.

We could try updating the kernel in the ami and see if it fixes the problem.

Interesting idea, since we already know it doesn't reproduce in Fedora.  Though I hate to mess with the AMI if it's going to affect ALL tests (some are working).  Unless I'm misunderstanding some magic involved.

Well we would need to update to the RHEL7.4.* kernel, I have no idea what kernel we are testing with now.

FYI: Mrunal's following up on the "is kernel-bug in RHEL" thread, internally.

Yet journals/crio.service is empty in the integration_rhel tests.

This is because the integration tests are spinning crio up and down internally, and aren't launching it as a systemd service.  So any crio logs are held by bats, and bats is blocked on the kernel deadlock.  Perhaps we should set --log pointing at somewhere for integration tests that do not involve parsing crio's logs, and then collect that file as part of openshift/aos-cd-jobs?  That should get us access to the crio logs without having bats as a middleman.

In general, I'm of the opinion the test-subject should always have the MOST amount of logs/details captured/archived.  Where would that be set in this context, in the playbook somewhere?  Would it prevent bats from doing it's job or just be additional logging for crio?  If it would block, maybe we could run it through tee first (somehow)?

#1446 doesn't hit this issue as I suspected.

/me goes digging...

@mrunalp interesting...no clue what those changes do :smile: but I'll rebase my PRs and re-run, let's see if they all pass now...

Update: I'm not seeing the kernel messages I saw before when testing manually from #1437

Closing, assuming this was fixed given how old it is.  Can re-open if not.


update the deprecated CountMinSketchMonoid function to TopPctCMS function

http://twitter.github.io/algebird/index.html#com.twitter.algebird.legacy.CountMinSketchMonoid$
The CountMinSketchMonoid has been deprecated since 0.8.1. Newer code should use TopPctCMS.monoid().

Can one of the admins verify this patch?

ok to test

We're on 0.8.1, so if it compiles, that seems OK

Test build #30749 has started for   PR 5629 at commit 4c0dfd1.

Test build #30749 has finished for   PR 5629 at commit 4c0dfd1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30749/
Test FAILed.

package orange.fr.scalaTest
import com.twitter.algebird._
import com.twitter.algebird.CMSHasherImplicits._
import org.apache.spark.SparkConf
import org.apache.spark.SparkContext._
import org.apache.spark.storage.StorageLevel
import org.apache.spark.streaming.{Seconds, StreamingContext}
import org.apache.spark.streaming.twitter._
// scalastyle:off
/**

Illustrates the use of the Count-Min Sketch, from Twitter's Algebird library, to compute
windowed and global Top-K estimates of user IDs occurring in a Twitter stream.

Note that since Algebird's implementation currently only supports Long inputs,
the example operates on Long IDs. Once the implementation supports other inputs (such as String),
the same approach could be used for computing popular topics for example.

<a href=
"http://highlyscalable.wordpress.com/2012/05/01/probabilistic-structures-web-analytics-data-mining/">
This blog post has a good overview of the Count-Min Sketch (CMS). The CMS is a data
structure for approximate frequency estimation in data streams (e.g. Top-K elements, frequency
of any given element, etc), that uses space sub-linear in the number of elements in the
stream. Once elements are added to the CMS, the estimated count of an element can be computed,
as well as "heavy-hitters" that occur more than a threshold percentage of the overall total
count.

Algebird's implementation is a monoid, so we can succinctly merge two CMS instances in the
reduce operation.
*/
// scalastyle:on
object TwitterAlgebirdCMS {
def main(args: Array[String]) {
StreamingExamplesLogging.setStreamingLogLevels()

val Array(consumerKey, consumerSecret, accessToken, accessTokenSecret) = args.take(4)
// Set the system properties so that Twitter4j library used by twitter stream
// can use them to generat OAuth credentials
System.setProperty("twitter4j.oauth.consumerKey", consumerKey)
System.setProperty("twitter4j.oauth.consumerSecret", consumerSecret)
System.setProperty("twitter4j.oauth.accessToken", accessToken)
System.setProperty("twitter4j.oauth.accessTokenSecret", accessTokenSecret)

// CMS parameters
val DELTA = 1E-3
val EPS = 0.01
val SEED = 1
val PERC = 0.001
// K highest frequency elements to take
val TOPK = 10

val filters = args.takeRight(args.length - 4)
val sparkConf = new SparkConf().setAppName("TwitterAlgebirdCMS").setMaster("local[*]")
val ssc = new StreamingContext(sparkConf, Seconds(10))
val stream = TwitterUtils.createStream(ssc, None, filters, StorageLevel.MEMORY_ONLY_SER_2)

val users = stream.map(status => status.getUser.getId)

//val cms = new CountMinSketchMonoid(EPS, DELTA, SEED, PERC)
val cms = TopPctCMS.monoid[Long](EPS, DELTA, SEED, PERC)
var globalCMS = cms.zero
val mm = new MapMonoid[Long, Int]()
var globalExact = Map[Long, Int]()

val approxTopUsers = users.mapPartitions(ids => {
  ids.map(id => cms.create(id))
}).reduce(_ ++ _)

val exactTopUsers = users.map(id => (id, 1))
  .reduceByKey((a, b) => a + b)

approxTopUsers.foreachRDD(rdd => {
  if (rdd.count() != 0) {
    val partial = rdd.first()
    val partialTopK = partial.heavyHitters.map(id =>
      (id, partial.frequency(id).estimate)).toSeq.sortBy(_._2).reverse.slice(0, TOPK)
    globalCMS ++= partial
    val globalTopK = globalCMS.heavyHitters.map(id =>
      (id, globalCMS.frequency(id).estimate)).toSeq.sortBy(_._2).reverse.slice(0, TOPK)
    println("Approx heavy hitters at %2.2f%% threshold this batch: %s".format(PERC,
      partialTopK.mkString("[", ",", "]")))
    println("Approx heavy hitters at %2.2f%% threshold overall: %s".format(PERC,
      globalTopK.mkString("[", ",", "]")))
  }
})

exactTopUsers.foreachRDD(rdd => {
  if (rdd.count() != 0) {
    val partialMap = rdd.collect().toMap
    val partialTopK = rdd.map(
      {case (id, count) => (count, id)})
      .sortByKey(ascending = false).take(TOPK)
    globalExact = mm.plus(globalExact.toMap, partialMap)
    val globalTopK = globalExact.toSeq.sortBy(_._2).reverse.slice(0, TOPK)
    println("Exact heavy hitters this batch: %s".format(partialTopK.mkString("[", ",", "]")))
    println("Exact heavy hitters overall: %s".format(globalTopK.mkString("[", ",", "]")))
  }
})

ssc.start()
ssc.awaitTermination()

}
}
I test this code on my local machine it works, while you test it you should set the twitter anthentication part.

@caikehe It failed style tests actually:
Scalastyle checks failed at following occurrences:
[error] /home/jenkins/workspace/SparkPullRequestBuilder/examples/src/main/scala/org/apache/spark/examples/streaming/TwitterAlgebirdCMS.scala:71:4: Insert a space after the start of the comment
[error] (examples/compile:scalastyle) errors exist
[error] Total time: 6 s, completed Apr 22, 2015 3:09:11 AM
[error] /home/jenkins/workspace/SparkPullRequestBuilder/examples/src/main/scala/org/apache/spark/examples/streaming/TwitterAlgebirdCMS.scala:71:4: Insert a space after the start of the comment
[error] (examples/compile:scalastyle) errors exist

Yes, or just add a space before the comment. Now it should work.

Test build #30754 has started for   PR 5629 at commit 5653351.

Test build #30754 has finished for   PR 5629 at commit 5653351.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30754/
Test FAILed.

@AmplabJenkins, I checked the build results, access rights to CI server needed? While it is mergeable.

Click the results above -- this does not compile.
[error] /home/jenkins/workspace/SparkPullRequestBuilder/examples/src/main/scala/org/apache/spark/examples/streaming/TwitterAlgebirdCMS.scala:21: object CMSHasherImplicits is not a member of package com.twitter.algebird
[error] import com.twitter.algebird.CMSHasherImplicits._
[error]                             ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/examples/src/main/scala/org/apache/spark/examples/streaming/TwitterAlgebirdCMS.scala:72: not found: value TopPctCMS
[error]     val cms = TopPctCMS.monoid[Long](EPS, DELTA, SEED, PERC)
[error]               ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/examples/src/main/scala/org/apache/spark/examples/streaming/TwitterAlgebirdCMS.scala:79: missing parameter type for expanded function ((x$1, x$2) => x$1.$plus$plus(x$2))
[error]     }).reduce(_ ++ _)
[error]               ^

http://twitter.github.io/algebird/#com.twitter.algebird.CMSHasherImplicits$
http://mvnrepository.com/artifact/com.twitter/algebird-core_2.10
On the pom.xml file, it needs add the latest version:

com.twitter

algebird-core_2.10
0.9.0

Test build #30756 has started for   PR 5629 at commit e8aa06f.

I think that's fine, since this is an example, though this is not related to SPARK-7056?

SPARK-7056 is just a new commit, after updating the pom.xml file, the CMSHasherImplicits compatibility problem can be solved as well.

The changes look OK; Jenkins will double-check. I am still not sure what you mean about SPARK-7056, which is about the streaming write-ahead log. Typo?

It means nothing, first I intend to update the pom.xml file and give it a new name [spark-7056], while it is a part of this pull request.

Normally we do make JIRAs for changes unless it would be pretty redundant with a simple, self-evident pull request. This is borderline. But SPARK-7056 is a real, unrelated JIRA: http://issues.apache.org/jira/browse/SPARK-7056  To avoid confusion: there is no JIRA associated with this pull request at the moment.

It makes sense.

Test build #30756 has finished for   PR 5629 at commit e8aa06f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30756/
Test PASSed.


Log injection test flakiness

Sometimes the log injection tests can fail due to injection happening when it should not. Needs investigating, possibly the order of tests is leaking some config values

While building and testing start-stop stuff, I've fixed a few places where the tests were not setup or cleaned up properly.


reinventarlasorganizacioneswiki domain

Encountered problem
In some places, the old Spanish domain ( http://www.reinventarlasorganizacioneswiki.com/ ) is still present.
It turns out that this area has been bought.
Expected Solution
It is necessary to remove the old Spanish domains and replace it with the new address ( https://reinventingorganizationswiki.com/sp/ ).

As indicated in pull request #144 , some links on the Spanish version remain invalid (in the form .../index.php?title= "...", instead of .../theory/...) . You have to take the time to come and update these links to solve the problem entirely.


Remove password_hash from returned user object in user controllers.

Both user objects returned by getUserById and getUserByEmail no longer
have the password_hash as a property.+

I would consider using the delete operator (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/delete) to delete the password_hash key instead of rewriting the entire object out?
Also, in the interest of DRY, maybe write that as a one-line function cleanUserObject()?

@perfectlynormalbeast I've moved it into a helper function that uses the delete operator, but this shouldn't pass linting because the air-bnb config disallows functions that modify or reassign parameters per this rule: http://eslint.org/docs/rules/no-param-reassign. But we can configure eslint with an option for this rule that will allow property modification.

Does the linter still complain if you do something like
let cleanUser = user;
delete cleanUser.password_hash;
return cleanUser;

?

Ah no, if we remove the single line constraint this becomes much easier.


feat: auto-update changelog files

Related to #13
This PR should not be merged until #23 is fixed.
With the appendFile flag the changelog is appended to the start of the file

Thanks for this PR 💯 One small thing, we need to kinda parse the readme to add new version to the top of the readme (before first ##). See this example changelog: https://github.com/unjs/changelogen/blob/main/CHANGELOG.md

Thanks for this PR 💯 One small thing, we need to kinda parse the readme to add new version to the top of the readme (before first ##). See this example changelog:

Do you think we should read the new version from package.json and then include it in the changelog?

I think we can introduce the version bump feature to package.json in next iteration.

Are you working on it?

No but plan to. With this pr, you can use to prop as version. It works on versioned HEAD.

@pi0 Any updates on the version bump feature?

Hi @Intevel. Sorry it took long to be back on this. I've pushed few changes to this feature and preparing for next major version. We by default will update CHANGELOG.md and (preprend) the latest version in entry. I've also added new option of --output to specify changelog file. Using changelogen --no-output it will do as before behavior.
Until supporting --bump, the title entry is config.to which is latest ref.


managedZones creation not covered in the doc

Description

Tried to follow along the detailed docs (thanks!). Faced an error - which I think was not an intended experience ?
bash-3.2$ ./gcloud dns record-sets create rekor.xxx.com. \
> --rrdatas=$(./gcloud compute instances describe sigstore-rekor --format='get(networkInterfaces[0].accessConfigs[0].natIP)') \
> --type=A --ttl=60 --zone=xxx-com
API [dns.googleapis.com] not enabled on project [xxxxxxx]. Would you like to enable and retry (this will take a few minutes)? (y/N)?  y

Enabling service [dns.googleapis.com] on project [xxxxxxx]...
Operation "operations/acat.p2-314840182640-21001061-d775-40c6-8263-2775502ef2a6" finished successfully.
ERROR: (gcloud.dns.record-sets.create) HTTPError 404: The 'parameters.managedZone' resource named 'xxx-com' does not exist.

After creating the managedZone - I was able to proceed with the rest of the documentation.

Weird, I never had this issue just running through again. I will keep this open in case its seen again.


Should the check command be removed?

The check command is a rather complicated piece of code and is not even complete without #46 (which would make it even more complex). Additionally it is slow, since it has to connect to the remote upstream to check for updates.
I do not use this command very much myself and was wondering whether a depreciation would be in order?

You are wondering if there is anything you have not pushed upstream yet.

Scenario # 2 is very much an edge case and not enough of a feature to warrant an entire command.

@andsens, @squaresurf : i too desired a way to avoid the network hit when doing a check. see  blech75/homeshick@9aee26a for something quick i whipped up.
lemme know what you think of the approach. it seemed reasonable enough, though i don't love the LOCAL_ONLY "flag". it would be nice to send an actual param into the check call, but i didn't have time to trace how subcommand-specific arguments work. maybe later.


Preserve sort/skip/limit for aggregations

Fix FindMany.aggregate to preseve any set sort/skip/limit stages.

Thank you for the PR! I'll check it very soon

Merged! It will be published by the end of this week together with others. Thank you!


Specify Adstock-function for each channel?

Contributing to FB NextGen MMM R script
Issue
Say I have 4 media channels where for two of them the geometric adstock would assumed to be appropriate and for the other two, weibull.
Is there a way to include that in ROBYN? As far as I understand the code, we apply the same adstock-function to all media-channels (with media dependent hyperparameters)

Hi, please run f.plotAdstockCurves(T) for weibull to see the shape transformation. Weibull can take on both S and L shape. The larger the "shape" parameter, the more S-shape. The smaller, the more L-shape.

My question is more if we can have specific adstock for specific channels i.e using Geometric for e.g Google and FB and Weibull for e.g TV?
Med venlig hilsen
Jakob Henning Jensen
+45 26200713

From: gufengzhou @.>
Sent: Tuesday, August 24, 2021 11:40:18 AM
To: facebookexperimental/Robyn @.>
Cc: Jakobhenningjensen @.>; Author @.>
Subject: Re: [facebookexperimental/Robyn] Specify Adstock-function for each channel? (#141)
Hi, please run f.plotAdstockCurves(T) for weibull to see the shape transformation. Weibull can take on both S and L shape. The larger the "shape" parameter, the more S-shape. The smaller, the more L-shape.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/facebookexperimental/Robyn/issues/141#issuecomment-904487401, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI5C5K5I65UYEOY6PLYD5DLT6NSIFANCNFSM5CWJ42GA.

Then no you can't. But weibull is intended to also cover the geometric like shapes and thus takes longer to run too.

Exactly - thus I hoped to save some computation time by specifying Geometric for the ones.
Thanks for the swift replies!


PHP 8 compatibility for the 6.x branch

As upgrading to 7.x is not really straight forward AND there is no stable release for 7.x yet, it would be great to see PHP 8 compatibility for the 6.x branch.
It might just be as simple as just replacing   "^7.2" by "^7.2 || ^8.0" in https://github.com/deployphp/deployer/blob/6.x/composer.json
I get the focus is on 7.x but if this idea is supported I could open a PR and see what the impact on the rest of the codebase would be (if any)

if any

You can try. But there will be much more problems. One solution is to use phar v6

Thanks for the quick reply, and the suggestion!
Our main issue is that we do a composer require deployer/deployer in a lot of places to get the phar installed
Will just give it a try and let you know

@rutgerrademaker hi, we also can't upgrade php version because deployer v6 is stuck to php7.
Did you have any trouble removing deployer from composer and using the phar on PHP8 ?

@kiropowered I did not try to go the phar way yet, as in our situation it's not really easy to accomplish
Instead I'm trying to figure out how much work it would be to actually make 6.x compatible
You can see my progress over here >  https://github.com/deployphp/deployer/compare/6.x...rutgerrademaker:deployer:6.x

I gave it a try and openened this PR > https://github.com/deployphp/deployer/pull/3189
Great chance I missed something, but for me this seems to do the trick until we have adopted deployer 7

Some Symfony dependencies also only php7.


Scenario&Mockups: Acceptance Criteria Review for Scenario 2

To Do:  Requirements elicitation phase may introduce new requirements, or modify the existing ones. The layout of the requirements may change, therefore article numbers may change. A review of the acceptance criteria of the second scenario is required. Please comment down below the changes you made if any.

[x] @mumcusena
[x] @kostanya
[x] @BElifb

Deadline:
14.04.2022 @23.59

Changed the requirement <IP_ADDRESS> to <IP_ADDRESS>, because during requirements elicitations the mentioned requirement was changed.

Updated acceptance criteria in accordance with the new bidding system.
Added Requirements <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> through <IP_ADDRESS> and <IP_ADDRESS>.
Added active user precondition.
Highlighted the criteria that is directly related, left others as normal.

Changed the requirement <IP_ADDRESS> to <IP_ADDRESS> as it is updated.
Updated requirements <IP_ADDRESS>, <IP_ADDRESS> and <IP_ADDRESS> as their definitions are revised.
Transformed the requirement 1.2.1 to <IP_ADDRESS> as our notification system is updated.
Added the requirement <IP_ADDRESS> .
Deleted 1.2.4 (payment system) as it does not exist anymore.

Thank you for the reviews. No additional action taken. Closed the issue.


Stream motor state, joint torques and PID state in SensorBridge

This PR is meant to add the possibility to log motor encoders, current sensors, WBD torque estimates, motor PWMs, PID references.

General comment from a first pass,
I don't think individual attach methods for current sensors and motor sensors are necessary as implemented in this PR.
We can add only a few lines in
https://github.com/dic-iit/bipedal-locomotion-framework/blob/dba32d34b46ccd4400349fc2e8f7a447d980e232/src/RobotInterface/YarpImplementation/include/BipedalLocomotion/RobotInterface/YarpSensorBridgeImpl.h#L849-L858
to view the corresponding interfaces according to the desired configuration.

General comment from a first pass,
I don't think individual attach methods for current sensors and motor sensors are necessary as implemented in this PR.
We can add only a few lines in
https://github.com/dic-iit/bipedal-locomotion-framework/blob/dba32d34b46ccd4400349fc2e8f7a447d980e232/src/RobotInterface/YarpImplementation/include/BipedalLocomotion/RobotInterface/YarpSensorBridgeImpl.h#L849-L858
to view the corresponding interfaces according to the desired configuration.
Because, all of these interfaces, if available are supposed to be read from the same device which is the attached Remote Control Board Remapper.

@prashanthr05 thanks for the suggestion, I modified the code accordingly.

Thank you @prashanthr05 for the review and @isorrentino for iterating 😃
Merging!


[investigate] Clean up owned resources in Finalizer

When a Terraform object is deleted, ConfigMaps and Secrets are not deleted, while they have OwnerReference to the deleted Terraform objects.
It's possibly a bug as we should clean up after ourselves. If someone uses that leftover garbage (as the gc should clean it up), that feels like they use something they shouldn't.

It's an issue as we leave garbage behind
It's an issue if someone creates a new Terraform object with the same ref, should we keep the existing one (with all history) and update OwnerReference? Should we nuke and create one?

Possible resolution:

Delete all objects we created.
If a ConfigMap / Secret was there before we did nothing (user already created it), don't set owner reference (as we are not the owner, we did not create it)

@squaremo what is your opinion on this?

When a Terraform object is deleted, ConfigMaps and Secrets are not deleted, while they have OwnerReference to the deleted Terraform objects.

The Kubernetes API should take care of removing dependent objects. Any idea why it's not?

Now I wonder which controller handles deletion of ConfigMaps
Can't find anything obvious in https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/
Maybe it doesn't have a controller at all as it's just a bunch of key/values without runtime behaviour so it just gets stored in etcd
by @yiannistri (on Slack)

I don't know, but it's worth a try to dig deeper in that hole, for example k8s IRC/Matrix/Slack channels.

I'm unclear on whether we have direct evidence that ConfigMap object with ownerships don't get garbage-collected -- can we do an experiment?

This is related: https://github.com/weaveworks/tf-controller/issues/538

Worth considering this: https://github.com/weaveworks/tf-controller/issues/538#issuecomment-1448204835

I can confirm, secrets get deleted when OwnerReference is set, it gets deleted even when I have my own finalizer and it does not delete the secret: https://github.com/yitsushi/controller-ownref-experiment
So somewhere we set something that prevents secrets and configmaps to be deleted.

I'm unclear on whether we have direct evidence that ConfigMap object with ownerships don't get garbage-collected -- can we do an experiment?

I can confirm (), secrets get deleted when OwnerReference is set, it gets deleted even when I have my own finalizer and it does not delete the secret: https://github.com/yitsushi/controller-ownref-experiment
So somewhere we set something that prevents secrets and configmaps to be deleted.

Descriptions needs some loving touch. Last time we talked about it, we said we turn this issue into an investigation about what resources:

we want to delete, but it's not deleted now, so we can fix it
we don't want to delete, and it's not deleted now, so we can verify
we don't want to delete, and it's deleted not, so we can fix it (i don't think we have such resource now)

All resources should be documented if they are deleted with the Terraform resource or not and why.


Merge pull request #907 from derek-ho/enable-windows-macos

feat: enable ci for windows and macos
(cherry picked from commit 0699baa2ae47fb72af9721986df669e786655cd2)
Signed-off-by: Derek Ho<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #962 (ac5cc2e) into main (e733e7b) will increase coverage by 2.95%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #962      +/-   ##
============================================
+ Coverage     94.83%   97.78%   +2.95%
  Complexity     2916     2916
============================================
  Files           291      281      -10
  Lines          7795     7137     -658
  Branches        568      449     -119
============================================
- Hits           7392     6979     -413
+ Misses          349      157     -192
+ Partials         54        1      -53

Flag
Coverage Δ

query-workbench
?

sql-engine
97.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ublic/components/QueryResults/QueryResultsBody.tsx

workbench/public/components/PPLPage/PPLPage.tsx

workbench/public/components/SQLPage/SQLPage.tsx

workbench/public/components/Header/Header.tsx

...ch/public/components/QueryResults/QueryResults.tsx

workbench/public/utils/PanelWrapper.tsx

workbench/public/components/Main/main.tsx

...h/public/components/QueryLanguageSwitch/Switch.tsx

workbench/public/application.tsx

workbench/public/components/app.tsx

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update search to use v2 API endpoint

v1 has been disabled on most instances by now.
The change is minor: hash-tags are now reported as proper structs
instead of a simple string-array.

Could you please fix tests?

@mattn Done! Sorry, I keep forgetting the tests in cmd/mstdn.

Thank you

Codecov Report

Merging #128 into master will decrease coverage by 0.39%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #128     +/-   ##
========================================
- Coverage    80.1%   79.7%   -0.4%
========================================
  Files          29      29
  Lines        1503    1503
========================================
- Hits         1204    1198      -6
- Misses        205     211      +6
  Partials       94      94

Impacted Files
Coverage Δ

mastodon.go
70.22% <ø> (ø)
:arrow_up:

status.go
85.62% <100%> (ø)
:arrow_up:

cmd/mstdn/cmd_stream.go
59.09% <0%> (-3.04%)
:arrow_down:

cmd/mstdn/main.go
65.81% <0%> (-1.46%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021f5d0...72a2d4f. Read the comment docs.


Presentation: Unskip a test that was failing due to localization files not being found (fixed in addon)

We use active locale as 'en-PSEUDO' and the directory containing pseudo-localized strings is 'en-pseudo'. That's not an issue on Windows and Mac, but on Linux we need casing to match exactly for paths. The addon now tries ['en-pseudo', 'en-PSEUDO', 'EN-pseudo', 'EN-PSEUDO'].

@calebmshafer, any specific reason these two directories in CODEOWNERS aren't split into specific package owners?
/common/api/summary @imodeljs/core @imodeljs/display
/common/changes @imodeljs/core @imodeljs/display

As far as I understand core, display and mgooding got included into this PR as reviewers just because of these summary / change files. Seems wrong...

@calebmshafer, any specific reason these two directories in CODEOWNERS aren't split into specific package owners?
/common/api/summary @imodeljs/core @imodeljs/display
/common/changes @imodeljs/core @imodeljs/display

As far as I understand core, display and mgooding got included into this PR as reviewers just because of these summary / change files. Seems wrong...

@grigasp those two lines should now only have @imodeljs/core because the display team has been made a sub-team under core. This should hopefully reduce the notifications the display team receives.  Not sure if that change has been merged into the imodel02 branch yet.
I put those two as the largest group possible so that people aren't directly added for them and to avoid an even larger codeowners file. Any change to those files is already going to be covered by other changes. For example, the approval to common/changes is a product of a change in another package and the common/api/summary will only be changes if something in common/api is changed as well since it's a subset.

@calebmshafer, any specific reason these two directories in CODEOWNERS aren't split into specific package owners?
/common/api/summary @imodeljs/core @imodeljs/display
/common/changes @imodeljs/core @imodeljs/display

As far as I understand core, display and mgooding got included into this PR as reviewers just because of these summary / change files. Seems wrong...

@grigasp those two lines should now only have @imodeljs/core because the display team has been made a sub-team under core. This should hopefully reduce the notifications the display team receives. Not sure if that change has been merged into the imodel02 branch yet.
I put those two as the largest group possible so that people aren't directly added for them and to avoid an even larger codeowners file. Any change to those files is already going to be covered by other changes. For example, the approval to common/changes is a product of a change in another package and the common/api/summary will only be changes if something in common/api is changed as well since it's a subset.

I understand. But I'd say notifying people about changes they don't care about is worse than having a large codeowners file.


Support stream: true for the completions endpoint

The completions endpoint supports a streaming configuration, which may be valuable in situations where low latency is a priority and a stream of partial values to the caller is useful (i.e. for a chat client).  This configuration uses server-sent events (SSEs) to incrementally provide updates to the caller.
I'm not entirely sure how to use the underlying HTTParty stack with server-sent events, assuming that's even possible.  Needs further research and thought.

@bf4 Interesting suggestion.  I don't have time to work on it right now, but I'd welcome a PR if you're so inclined.

Took a stab at running through the connection set up.. not sure if the difference in assumption with how Net::HTTP builds a connection with the uri, while HTTP waits until the actual request is easy to resolve.  Faraday wrapping HTTP might be a better match since the adapter needs to mimic Net::HTTP

investigative spike
    def connection
      # https://github.com/jnunemaker/httparty/blob/30f2ec15917ef75934e7e7b139d9c92c22141093/lib/httparty/connection_adapter.rb
      # https://github.com/httprb/http/blob/462d711040735be3661068e9e52eb14a4269f1f4/spec/lib/http_spec.rb#L14
      # HTTP::Client.new
      http = ::HTTP
      # host = clean_host(uri.host)
      # port = uri.port || (uri.scheme == 'https' ? 443 : 80)
      if options.key?(:http_proxyaddr)
        http = http.via(
          options[:http_proxyaddr],
          options[:http_proxyport],
          options[:http_proxyuser],
          options[:http_proxypass]
        )
      #   http = Net::HTTP.new(
      #     host,
      #     port,
      #     options[:http_proxyaddr],
      #     options[:http_proxyport],
      #     options[:http_proxyuser],
      #     options[:http_proxypass]
      #   )
      # else
      #   http = Net::HTTP.new(host, port)
      end

      # http.use_ssl = ssl_implied?(uri)

      attach_ssl_certificates(http, options)

      timeout_options = {}
      if add_timeout?(options[:timeout])
        # http.open_timeout = options[:timeout]
        # http.read_timeout = options[:timeout]
        timeout_options[:connect] = options[:timeout]
        timeout_options[:read] = options[:timeout]

        from_ruby_version('2.6.0', option: :write_timeout, warn: false) do
          # http.write_timeout = options[:timeout]
          timeout_options[:write] = options[:timeout]
        end
      end

      if add_timeout?(options[:read_timeout])
        # http.read_timeout = options[:read_timeout]
        timeout_options[:read] = options[:read_timeout]
      end

      if add_timeout?(options[:open_timeout])
        # http.open_timeout = options[:open_timeout]
        timeout_options[:connect] = options[:open_timeout]
      end

      if add_timeout?(options[:write_timeout])
        from_ruby_version('2.6.0', option: :write_timeout) do
          # http.write_timeout = options[:write_timeout]
          timeout_options[:write] = options[:write_timeout]
        end
      end
      if timeout_options.any?
        http = http.timeout(**timeout_options)
      end

      # if add_max_retries?(options[:max_retries])
      #   from_ruby_version('2.5.0', option: :max_retries) do
      #     http.max_retries = options[:max_retries]
      #   end
      # end

      # if options[:debug_output]
      #   http.set_debug_output(options[:debug_output])
      #
      #   logger = Logger.new(STDOUT)
      #   http = HTTP.use(logging: {logger: logger})
      # end

      # if options[:ciphers]
      #   http.ciphers = options[:ciphers]
      # end

      # Bind to a specific local address or port
      #
      # @see https://bugs.ruby-lang.org/issues/6617
      # if options[:local_host]
      #   from_ruby_version('2.0.0', option: :local_host) do
      #     http.local_host = options[:local_host]
      #   end
      # end

      # if options[:local_port]
      #   from_ruby_version('2.0.0', option: :local_port) do
      #     http.local_port = options[:local_port]
      #   end
      # end

      http
    end


AFK time

I have some suggestion about afk time calculation.
There are 2 types of getting "away" status:

player typed /afk into the chat. In this case "away" status immediately appears and this time do not count as "played" time. And this implemented already.
player does not make any action and after 5 mins (or 10 i don't know for sure) his status automatically set as "away". In this case 5 (or 10) mins should not be counted as "played" time.
Is it possible to separate afk from user input and afk with taking no action?

Also it would be good for some players to know how much time do they afk in statistic section.

Sounds good, thanks for your suggestion.
I don't know if it is possible to detect whether the AFK status has been triggered by typing /afk or by not making any action for 5 minutes. In case it is not, maybe there is some workaround, but I cannot guarantee it.
Still, it is worth trying. I'll tackle it as soon as I have some free time.
About the AFK time in the statistic section, sure, it could be added and I think it is a good idea, thanks again!


Transaction preview with Tenderly

Description

It is very difficult to tell the user what is going on in the backend
So we are going to implement Tenderly preview to tell the result of the transaction

I mistakenly closed this. I was confused with Defender implementation.


 The ServiceMonitor activates
itself on embark:engine:started and practically monitors registered services
until the process has been explicitly stopped.
There are some commands that don't actually need service monitoring like build and
a future exec command that's in the making. For those cases it's useful to have them
disable the service monitor when coreComponents() is used.
This commit introduces configuration options to coreComponents() with currently one
supported option: disabledServiceMonitor which defaults to false.
Usage:
engine.registerModuleGroup('coreComponents', {
  disableServiceMonitor: true
});

What did you refactor, implement, or fix?

How did you do it?

Is there anything that needs special attention (breaking changes, etc)?

Questions

Review

Cool Spaceship Picture
<!-- Star Trek/Wars, n/BSG, Voltron, Transformers... all welcome, but not all equally cool ;-) ->

@michaelsbradleyjr So what you're describing is pretty much what this PR does except that disableServiceMonitor only prevents it from setting up a monitor listener.
The same condition can be put around the ServiceMonitor instantiation.
What @jrainville is describing though, is to move the ServiceMonitor component out of coreComponents and have commands explicitly set it up as they need it (instead of it coming implicitly with core components).
I'm fine to go either way.

This is now updated.


Support GPIO pull-ups

The pull-up and down functionality is currently unimplemented in the generic host. I would really like this functionality to be available for rpi.
My current workaround is using github.com/stianeikeland/go-rpio only to set the pull-ups. I'd really rather stick to embd only because I need the i2c and other awesome features.
Their implementation is at https://github.com/stianeikeland/go-rpio/blob/master/rpio.go#L232. It involves some tricky memory mapping of a register file that I am not super comfortable with.

I will give it a shot :)
Sent from my iPhone

On 29-Jun-2015, at 4:19 pm, Craig Peterson<EMAIL_ADDRESS>wrote:
The pull-up and down functionality is currently unimplemented in the generic host. I would really like this functionality to be available for rpi.
My current workaround is using github.com/stianeikeland/go-rpio only to set the pull-ups. I'd really rather stick to embd only because I need the i2c and other awesome features.
Their implementation is at https://github.com/stianeikeland/go-rpio/blob/master/rpio.go#L232. It involves some tricky memory mapping of a register file that I am not super comfortable with.
—
Reply to this email directly or view it on GitHub.

Hey @kidoman  - did you ever get a chance to have a look up pull up/down?

+1

Just as a notice to anyone in 2017: pullups are still not implemented.
Basically this library cannot be used for driving buttons.


docs: Update k8s version to be 1.30 instead of 1.3 on preview

Fixes #N/A
Description

Update k8s version to say 1.30 instead of 1.3 on the preview page of the docs

How was this change tested?

make website

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.121%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
5942

Relevant Lines:
7510

💛  - Coveralls


fix(tsc): fix record body bug in tracing

Read the body stream instead of synchronization.
if body size is less or equal 200k, tracing will record body ,else record in log with base64 encoding.

6 Code Smells


Output Mismatch in ARM mult , scale and other mult cases for q31 in CMSIS 5.9 version

Here, As shown in the image above (https://github.com/ARM-software/CMSIS_5/blob/5.9.0/CMSIS/DSP/Source/BasicMathFunctions/arm_mult_q31.c) For q31 case, we are first right shifting and then left shifting by a bit which results in precision loss of LSB.
When this is run multiple times, It can result in a huge loss of data.
For q15, q7 it is handled correctly like below.
image

The issue also exists for mult, scale, and other cases where q31 mult operations are involved.
Please let us know the plans for fixing this.

@BhaskarsarmaP It is done to have correct saturation. You need to consider the bit 32 (counting from 0) to be able to detect a potential saturation.
So it won't be fixed because having correct saturation is important.
The function is a tradeoff between saturation / accuracy and speed.
We could make a different implementation with correct saturation and full accuracy but it would be more complex and use more cycles.
What's the use case you have in mind where this loss one of LSB would cause an issue ?
Generally, long sequences of multiplies are used in multiply and accumulate. And in this case, the saturation and shift is only done at the end of the sequence so accuracy is kept (and you don't use this mult function but a dedicated mac function).
Perhaps you'd like a Multiply/accumulate function in the BasicMath folder ?

Could you explain why it's different from the q15 and q31 case?
Why it's the issue for only q31 and not q15?
Here is the code, when the block count < 4.
I tried using the below code for q31 similar to q15
 *pDst++ =  (q31_t) __SSAT((((q63_t) (*pSrcA++) * (*pSrcB++)) >> 31), 32);
For q15
*pDst++ = (q15_t) __SSAT((((q31_t) (*pSrcA++) * (*pSrcB++)) >> 15), 16);
q15 case is working when both inputs are -1.
q31 case which I modified is not working when both inputs are -1 and the output is -1 which is wrong.
Please elaborate and explain this case.

In Q15, you'll compare a int32 value with 0x07FFF and you can detect if it is > 0x07FFF and in that case SSAT is saturating (0x07FFF is (1<<15)-1).
In Q31, if you use 32 in SSAT you compare with (1<<31)-1 = 0x7FFFFFFF but you can't check if it is > 0x7FFFFFFF because 0x80000000 is negative.
So, you need to use SSAT with 31 and it gives a comparison with 0x3FFFFFFF. You can check x > 0x3FFFFFFF in int32 since the value just above is 0x40000000 and is still positive.

Thanks for the info. Do you have an optimized version without having LSB precision loss.
Inputs and Outputs must be in q31 format.

@BhaskarsarmaP In practice, you use the multiply as part of other kernels like arm_dot_prod_q31 or arm_mat_mult_q31.
If the multiply is used alone, the LSB is generally not an issue. It is only if you use long sequence of multiplies and in those case there are other kernels that can be used.
With 30 accurate bits, you still have 180 dB of SNR.


⚠ Roblox Devforum has degraded performance

In e878e31, Roblox Devforum (https://devforum.roblox.com) experienced degraded performance:

HTTP code: 504
Response time: 10178 ms

Resolved: Roblox Devforum performance has improved in a012953.


Effective not working

Mod Name
Effective
Mod Homepage
https://modrinth.com/mod/effective
Minecraft version
1.20.1
Describe the bug
Effective is being ignored when loading
Steps to reproduce
Simply loading the mod.
Logs
https://gist.github.com/Aulberon/cdb258889ea55da5f6cd6c37e82b36f6
Additional context
[16:46:12] [main/INFO]: Fabric mod metadata not found in jar effective._1._20._1, ignoring

it's normal it's a quilt mod to a fabric mod there is a forge port here https://github.com/hlysine/Effective-Forge-/tree/1.20.1

I have no idea how to turn that into a usable mod file.

Connector does not support running Quilt mods

Use this: https://modrinth.com/mod/particular it works fine with sinytra

OMG! Thank you! This mod is awesome!


Added a substitution for single quotes in the footnote content.

Footnote content that contained a single quote character was being truncated at the quote. This replaces the single quote with an ' when the double quote and less than/greater than signs are replaced.

@lemonmade Can you merge this PR? I experienced this issue myself.

Sorry, never saw this originally. Looks great!

Awesome! :)

@lemonmade Thanks for the merge. Could you release this under a new version number and update bower.json and package.json too?

:+1:


ChemProt processded data missing some instances

Hello,
thank you for sharing the processed dataset !
When downloading it from the repo, i can not find the whole dataset. For example, the train set for TreeLSTM is only 16,522 (positive + negative instances) where in the paper, There are actually 4133 positive instances and 16, 522   negative instances
Am I missing something ?
Thanks in advance for answering my question.

Hello,
I am sorry for your confusion. The column "Negative" in table 3 is actually "whole" data. Other than the error, the ratio remains true. The actual negative number for the training is 12389, and 12389/4133 is 2.99.


Margin's trap

Hi, thx for awesome lib. I spent few hours in "profiling perfomance adventure" until reliazed that problem is in android:margins which cause invalidating.
Imho, in readme should be warning that users should prefer special API (setMonthPadding, setMonthMargins) instead of default ones.

android:margins are applied on the entire view but month margins are applied on each item view. These are two different things.


About mjpeg rtsp stream

Error or warnning

Fixed: https://stackoverflow.com/questions/53207692/libav-mjpeg-encoding-and-huffman-table

Add -huffman 0

Fixed: https://lists.ffmpeg.org/pipermail/libav-user/2015-December/008715.html

Add -force_duplicated_matrix 1
it maybe just warning

Fixed: https://stackoverflow.com/questions/30782771/what-does-past-duration-x-xxx-too-large-mean

Add -force_duplicated_matrix 1
timestamp over than 0.6s or somtimes start first time, it maybe just warning

That's all about mjpeg issue

Sorry but I didn't get what is this issue about. Are having this issue while using the relay? Would you like to have this fix on this project?


"afterValidateAttribute" attribute.value is empty

What steps will reproduce the problem?
$('body').on('afterValidateAttribute', "form", function(event, attribute, messages) {
    console.log(attribute.value);
});

What is the expected result?
Attribute's value
What do you get instead?
Empty value
Additional info
afterValidateAttribute event is triggered before setting the value at line 726
attribute.value = getValue($form, attribute);
https://github.com/yiisoft/yii2/blob/master/framework/assets/yii.activeForm.js#L705
https://github.com/yiisoft/yii2/blob/master/framework/assets/yii.activeForm.js#L726
What about calling the trigger after setting attribute value. This would enable the checking of form.find(".has-error").length

It makes sense to adjust it.


TF -> Caffe. KeyError: 'worker_0/resnet_v2_50/conv1/weights' for resnet_v2_50

Platform (like ubuntu 16.04/win10):
win10
Python version:
3.6
Source framework with version (like Tensorflow 1.4.1 with GPU):
tried with tf 1.8.0 and 1.10 (newest)
Destination framework with version (like CNTK 2.3 with GPU):
Caffe
Pre-trained model path (webpath or webdisk path):
resnet_v2_50
Running scripts:
mmconvert -sf tensorflow -in model-0.ckpt.meta -iw model-0.ckpt.index --dstNodeName worker_0/resnet_v2_50/logits/BiasAdd -df caffe -om tf_resnet
I get the KeyError: 'worker_0/resnet_v2_50/conv1/weights', but when I check the layers of the model, the
one in the keyerror is present:
worker_0/resnet_v2_50/conv1/weights/Initializer/random_uniform/shape
worker_0/resnet_v2_50/conv1/weights/Initializer/random_uniform/min
worker_0/resnet_v2_50/conv1/weights/Initializer/random_uniform/max
worker_0/resnet_v2_50/conv1/weights/Initializer/random_uniform/RandomUniform
worker_0/resnet_v2_50/conv1/weights/Initializer/random_uniform/sub
worker_0/resnet_v2_50/conv1/weights/Initializer/random_uniform/mul
worker_0/resnet_v2_50/conv1/weights/Initializer/random_uniform
worker_0/resnet_v2_50/conv1/weights
worker_0/resnet_v2_50/conv1/weights/Assign
worker_0/resnet_v2_50/conv1/weights/read
3rd from the bottom.
It should also be noted that I tried running mmconvert -sf tensorflow -in model-0.ckpt.meta -iw model-0.ckpt --dstNodeName worker_0/resnet_v2_50/logits/BiasAdd -df caffe -om tf_resnet
^^removed .index from -iw file^^
but this results in "AttributeError: 'NoneType' object has no attribute 'name'" for     self.set_weight(source_node.name, 'mean', self.ckpt_data[mean.name]).
Any help would be greatly appreciated!

@namizzz here are the files:
https://ufile.io/p5jb5

Hi @Shadowspyes , I have checked your model files. It's caused by name of the moving_mean and moving_variance. You can fix this in tensorflow_parser.py  . Add:
node_name = '/'.join(source_node.name.split('/')[:-1]) + '/'

to get your node name (eg. worker_0/resnet_v2_50/block2/unit_1/bottleneck_v2/preact/)
Then you can comment Line 703 and 704. Add:
self.set_weight(source_node.name, 'mean', self.ckpt_data[node_name + 'moving_mean'])
self.set_weight(source_node.name, 'var', self.ckpt_data[node_name + 'moving_variance'])

Thanks!

@namizzz Thank you for your assistance!


Encoders and MotorEncoders readings

Hi,
I used iEncoders and iMotorEncoders to read the encoders of the robot, as I wanted to test the effect of the springs in the joints.
However, I'm not sure about how to interpret the readings from iMotorEncoders. I thought it is enough to divide by the gear ration (100), but the numbers I obtained are not the same as iEncoders even when the springs are not mounted.
And as I've understood, iEncoders and iMotorEncoders should read the same values (almost?) when no spring is mounted.
What is the correct way to interpret the readings of iMotorEncoders?
@DanielePucci was also interested in this.
Thanks!

@randaz81

Have you tried to see what  getGearboxRation returns?

Nope, can try that.

Yes, indeed you have to divide the position returned by iMotorEncoders by the gear ratio obtained by getGearBoxRatio, considering also the sign. Additionally, you have to remove the offset which affects the motor encoder (indeed they are relative encoder, not absolute encoders). check opticalEncoders-consistency in icub-tests for an example

I get false from getGearboxRatio and so nonsense gear ratio, is the integer number m of the arguments ranging from 0 to 5 for example in the case of left_leg?
getGearboxRatio (int m, double *val)

yes, it is. For the legs legs it should return *val= +-100

Ok, but it return false and val = 0. And also the function getNumberOfMotors (int *num) returns false and num is 0.
But this part did not give any error:
    Property options;
    options.put("device", "remote_controlboard");
    options.put("local", localPorts.c_str());
    options.put("remote", remotePorts.c_str());
    PolyDriver robotDevice(options);
    IMotor *motors;
    if (!robotDevice.view(motors)) {
        printf("Problems acquiring interfaces\n");
        return 0;
    }

And the iEncoders and iMotorEncoders seem to work fine.

Looking at git history, icub-main has be updated at least at 04 July to properly manage getGearboxRatio. Is it so?

Ok, we'll talk about the update after IROS and I'll try then. Thanks!

icub-main is updated up to 04/09/2015, as well as yarp. But the firmware is from June.

@hu-yue any progress on this?

@pattacini not yet, sorry, I just got back from Hamburg but have to leave for Delft already so I did not have time to check the firmware issue with @randaz81, maybe we can do it next week?

there's no hurry, was just a ping :smirk:

After the last firmware and software update now it's possible to read the gear ratio using getGearboxRatio (int m, double *val).
The motor encoders values were converted into encoders values as
(m_encoders - enc_offsets)/gear_ratio

yes 10^-2 deg is ok.
btw, the module opticalEncoders-consistency has been recently renamed to motorEncoders-consistency. This test is more complete in the sense that checks also for the consistency between the joint velocity and the motor velocity.

Ok thanks!

fyi @fjandrad


fix(threat) tolerate empty namespace URI in namespace declaration

@alerque Makes total sense, sorry for not thinking about it myself.

@alerque @Tieske I'd appreciate a review & merge.  I've got the release stuff on a separate branch that I'll open a PR for once this one is merged.

I added #39 with an additional test


Assuming we got green CI to reach main#HEAD, no need to DO IT MOAR.

Also, @jcrossley3 vehemently agrees.
i hesitantly agree as long as the compilation artifacts are identical.


Many changes and improvements

Can now be used on Pre Icecream devices, albeit without animations.
Added OnFloatingToolbarListener interface, which you set via setFloatingToolbarListener, which gets called before menu is shown, so that menu can be customized based on current view.
Fixed setMenu function. Old version used to cause empty menu.
Removed mOriginalX variable, and using getLeft() in its place. mOriginalX got corrupted if onMeasure was called again.
Removed mMenu variable, as it is wrong to keep two matching arrays. In addition, the match was wrong, if a MenuItem was set as not visible. * * We now store the MenuItem in the View getTag().
Changed so that MenuItemID is used as the ViewID, in cases where the MenuItemID is set. This makes it easier to find MenuItems.
Added function setItemVisible(int itemID, boolean visible), which allows you to change MenuItem visibilty. This is useful for when Menu items have to change based on current view showing.
Added the isInEditMode() check, to prevent rendering issues in GUI
Changed to use addOnLayoutChangeListener rather than globalLayoutListener
Moved measuring of mFab from onMeasure to a listener. Sometimes onMeasure was called before mFab was measured.
Many other bug fixes and improvements

Hi, thanks for making a new pull request that includes all the changes.
I'm just against these:

Backport to API 9. I want to keep the minimum API as 14.
You've added a check for isInEditMode() that makes the xml preview not show the menu items.

Like I told in you in the other pull request, I prefer keeping the mMenu member variable and add a method to notify menu changes.
Can you revert back the changes above? If not, I'll merge this and take care of it later.

Why would you be upset about the backport? You were anyways using ViewCompat, This way you are allowing users to use it, even when they are supporting API 9. (For example, my project).
The correct way is that isInEditMode should just show a blank menu (when wanted). Not sure how to implement it. Without isInEditMode it did not render at all.
The problem with the mMenu variable is that it was very unsafe and unprofessional to match by array index. For example, if one menu item was marked as hidden, it was not added to the view, so now the view index does not match the menu index. There is no reason to hold on to the mMenu variable, and my way of  holding the individual MenuItem in the Tag, is much safer and cleaner.

Either way it's your call, as I have done all the changes for my use, and am just passing it back to you in appreciation of your releasing it.
Good Luck!

I wouldn't be upset. It's just that it's kind of pointless to keep supporting older version when most users are already at 15 or above. Take it as a force to update action.

Why would you want to see a blank menu? We can do this with a custom attribute. Something like previewMenu or something, that defaults to true.

I was matching by index since at the beginning I wasn't supporting hidden items. I agree that I need to change that, but the idea of keeping the variable is that you can change it directly, after using getMenu() and then calling notifyMenuChanged() so that the toolbar redraws the views accordingly.

You are correct, but I would rather not estrange users, when I can support them minimally.
I meant a preview menu, with just an outline, so that you can see through it. Sorry for that. The custom attribute is a good idea, but may be complicated for user.
Sounds like a good idea. You can do both. Save the mMenu for future changes, and save the MenuItems in the TAG, so that there is no need to compare index.
Good Luck!

Yes, I'll do both. The menu items in the tag will be used for the click listener :)


[WIP] Upgrade to Terraform 0.9.11

This gets us slightly further up to the latest version (0.11.7) and
the
changelog
isn't too scary, and indeed the features and bug fixes might make our
lives easier, especially the 0.9.5 changelog entry of "fix string
quoting for splitting on long TXT records".

(We've not tested this at all, I'll do some testing soon (with and without our string splitting hacks - I'll take a copy of the statefile before I do so), I'm opening this for comments and so I don't forget about it.)

Closing in favour of... one coming soon...


[Statie] A post must have and id

Recently I tried to update Statie from v3 to v4.4. I had to add id parameter to every post file. What's the reason for that?

See: https://github.com/Symplify/Symplify/pull/813
It related to inner working if generators and related filter in latter, sorting and interdependencies in general

We'll thats it the way it worked before, but there was lot glue code with "ifs" everywhere and it often lead to bugs.
I didn't manage to implement it nicely and without bugs, so I rather decided to remove it.

Sure, understood. Thanks.

Thank you!

+1 On making ID optional.


problems about train.py

Nice work! When I read the code of train.py, I found that both static tensor and dynamic tensorf are forwarded four times, and each forward gets a different output. What is the purpose of doing this? I feel that this will greatly reduce the training speed. Why not just forward once and get all the desired output.

Thank you so much for being interested in our work!
The four forward passes serve different purposes. The first is to render the frame for single-frame loss, such as the RGB and monocular depth loss. The second is to render novel view and novel time results to regularize the density and blend masks to close to zeros. The third and fourth are to render neighbor frames for pair-wise losses such as the reprojection loss and the disparity loss.
We agree the current implementation is not optimized for speed and could potentially speed up with a reformation.


firmware drivers does not have standard method get_by_uri and get_by_name

oneview_client.firmware_drivers does not support get_by_name nor get_by_uri
Example of code:
\ thisfw = oneview_client.firmware_drivers.get_by_uri('/rest/firmware-drivers/SPP_2018_11_20190405_for_HPE_Synergy_Z7550-96678')
AttributeError: 'FirmwareDrivers' object has no attribute 'get_by_uri'

Provided support for the requested methods in latest release. v5.2.0