[Slider] Port component

Added implementation of the Slider component according to the Google guidelines

PS: Something happened to my previous PR so I created a new one.
#Closes #4793

Thank @mbrookes for this, when can we expect this merge?

Okay, this is starting to take shape!
Keyboard input in the basic slider is 💯👌 , however mouse / touch input has the same granularity (1% step) as keyboard input, rather than being continuous, which gives a course feel to the movement. v0 had the same issue, so it would be good to address that here. It isn't a show-stopper, but I fear if we don't fix it now, it might get left like this.
Since you're using ButtonBase for the thumb, it would be preferable to use the focus ripple when keyboard focussed rather than a custom style.
The vertical slider seems backwards - I think the default should be from bottom-to-top, with reverse being top-to-bottom.
@Pajn pointed out that the use of top, left etc. for positioning is causing a performance hit. Did you have an opportunity to look at using transform: translate() and transform: scale()?
The testsh ave been renamed from .spec.js to .test.js
Once we get these last bits sorted, we can dig into code review (I have been focussing mostly on functionality).
Thanks for all your hard work! 👏

@mbrookes Thanks for review.
First of all I would like to note that the ripple effect is not according to the google guidelines.
About performance issue I will try to check.
About mouse / touch behavior I have a question. Right now I round value to step. if you do not do this, then which sign is worth rounding? For example: I clicked roughly in the middle of the slider and got value 0.5987654321. Now I will return the value 0.59. But it same value, which you can get by keyboard.

@epodivilov You're right, no ripple in the spec, or the MCW (or other) implementations. I'm a little surprised at that, as the ripple is designed as a visual affordance to make the focused component more obvious.
Regarding rounding the value - MCW don't round the value returned, so the developer can decide what precision to apply: https://material-components-web.appspot.com/slider.html
However unlike MCW, I believe we should round aria-valuenow to a sensible level of precision (3 digits?), so that a screen-reader user isn't potentially faced with an unending list of spoken digits if the screen-reader doesn't truncate it.

One other thing you can do as part of this PR is to update the Supported Components oage. You can follow the SpeedDial example, but I think it would be a good idea to add the checkmark to both Slider and SpeedDial.

@epodivilov are you still working on this? It feels like we're very close to final review.

@mbrookes Yes, I still working on this PR. I had a small vacation. I'll try to fix it this weekend.

Thanks @epodivilov Hope you had a nice break! ☺

@mbrookes I fixed rounding of values and updated the Supported Components page. Please, review last updates

@epodivilov Looks like something's gone wrong with the branch. You don't need to create a new PR, just clean up the brach and force push.

@mbrookes What does you mean "clean up the branch"? Like this https://stackoverflow.com/a/25357146 ?

I would personally rebase and squash but that is of coursee up to you what you are most comfortable with. The end result is a nice simple commit on top of the current v1-beta in both cases :)

Just tried this again with<EMAIL_ADDRESS>works great! (except for the onKeyboardFocus thing) Thanks for the work!

@goto-bus-stop Great news.  And when you plan to merge the PR?

Oh I don't know, I'm not a maintainer, just a user excited for this PR :stuck_out_tongue:

@epodivilov Yes please, if you could rename that prop as @goto-bus-stop pointed out, that would be great! Sorry I missed it.

@oliviertassinari Any last comments?

@mbrookes None :)

@epodivilov Thanks for all your hard work, and sticking with it! An amazing contribution for your first!

found a small bug and filed it: onMouseDown is calling onDragEnd instead of onDragStart (so it works in touch environments but not desktop/mouse only). should be an easy patch.


Demo site not working

I have been trying to connect to your demo site: http://www.riccardotartaglia.it/jkanban/
but keeping getting a connection failed/timed out error.

It's working :)


When I sat "Max" on Numeric Field and click the arrows, the value changes to 0

Bug type
Component
Component name
NumericField
What happened?
Add a numeric field with Max set, run and then on the field click the up arrow. Value goes to 0 or whatever the minimum is set to.
Expected behavior
Clicking the up arrow increases the number by 1 (or the step if specified)
Reproduction link
none
Reproduction steps
1.Create a numeric field with a max set (we have a generic component which wraps around a NumericField)
2.Click up arrow on the fiel
3.
...
Relevant log output
No response
Version (bug)
6.0.9
Version (working)
No response
What browsers are you seeing the problem on?
Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Could you please provide a try.mudblazor.com link

I wasn’t able to figure it out but I’ve provided sufficient repo steps hopefully
Thanks,
Shazia Babar.

On 24 Nov 2022, at 12:43, Mike Surcouf @.***> wrote:

Could you please provide a try.mudblazor.com link
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

I cant repro on this
https://try.mudblazor.com/snippet/mawcvbcJdvohBfNr

I get this when I try to use TryMudblazor:
blazor.webassembly.js:1 System.AggregateException: One or more errors occurred. (Could not resolve type with token 0100006c from typeref (expected class 'Try.UserComponents.__Main' in assembly 'Try.UserComponents, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'))
---> System.TypeLoadException: Could not resolve type with token 0100006c from typeref (expected class 'Try.UserComponents.__Main' in assembly 'Try.UserComponents, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null')
at TryMudBlazor.Client.Program.Main(String[] args)
--- End of inner exception stack trace ---

Got it working. Here's a snippet https://try.mudblazor.com/snippet/caGcvlwpyAYmiVil

I'm using a generic method and the type is generic so can't set the default value on the property

This might be a better (but not working) example https://try.mudblazor.com/snippet/cYGmlFmJyWlvKQed.
I've also tried having the Min and Max properties as nullable

Ok let me know when you get it working 👍


Stack recovery command

Have a CLI to re-integrate stacks in AMP.
When ETCD as been deleted and stacks still there, then command could take a tack name, verify it exist and re-create the entries in ETCD
Could be useful if we won't stop a stack for any reason, but have to restart amp or etcd after a crash

etcd is using a named volume, it should retrieve the data even when the container is killed. And when deploying at least 3 workers is deployed HA, so the loss of a node should not cause loss of data.
Which leads me to think that we should recommend not to deploy clusters with less than 3 workers.
Local deployment is also not an issue, if you lose your laptop, restoring etcd won't be your priority...

fixed in 0.12


Fix bug when application changes after round release

form.state does not exist all the time. This happens in a situation when an applicaiton is created and we add a new section after its creation.

thank you for adding test coverage 🙏


Error when compiling tokenizers for AMD with HIP C++ compiler (hipcc)

I'm running in the error below when attempting to compile the tokenizers using hipcc. Any tips?
In file included from /root/tokenizers-cpp/sentencepiece/third_party/protobuf-lite/repeated_field.cc:35:
/root/tokenizers-cpp/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/repeated_field.h:923:13: error: reference to __host__ function '~RepeatedPtrFieldBase' in __host__ __device__ function
  constexpr RepeatedPtrField();
            ^
/root/tokenizers-cpp/sentencepiece/third_party/protobuf-lite/repeated_field.cc:133:48: note: in instantiation of member function 'google::protobuf::RepeatedPtrField<std::basic_string<char>>::RepeatedPtrField' requested here
template class PROTOBUF_EXPORT_TEMPLATE_DEFINE RepeatedPtrField<std::string>;
                                               ^
/root/tokenizers-cpp/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/repeated_field.h:582:3: note: '~RepeatedPtrFieldBase' declared here
  ~RepeatedPtrFieldBase() {
  ^
1 error generated when compiling for gfx906.
make[2]: *** [tokenizers/sentencepiece/src/CMakeFiles/sentencepiece-static.dir/build.make:272: tokenizers/sentencepiece/src/CMakeFiles/sentencepiece-static.dir/root/tokenizers-cpp/sentencepiece/third_party/protobuf-lite/repeated_field.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:289: tokenizers/sentencepiece/src/CMakeFiles/sentencepiece-static.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

To reproduce:
git clone --recursive https://github.com/mlc-ai/tokenizers-cpp.git
cd examples
mkdir -p build
cd build
cmake .. -DCMAKE_CXX_COMPILER='/opt/rocm/bin/hipcc' -DCMAKE_CXX_LINKER='/opt/rocm/bin/hipcc'
make -j8

Thanks!

likely you don't want to use hipcc but instead use gcc to compile  this, and hipcc to compile everything else then link together


Expose Job.pendingInvocations

Hi,
Would it make sense exposing Job.pendingInvocations to better instrument this module? Adding something like this after Job.nextInvocation definition
this.pendingInvocations = function(){
  return pendingInvocations;
};

Hmm, I think you're right! Feel free to send in a PR, confirming that the tests pass, and if it follows what is declared here, I'll merge it in.

See https://github.com/mattpat/node-schedule/pull/82


Why is this happening?

What's the problem you are having while you are using C-REAL?
After I finish the builder step and put the .json file next to the application file and open it it comes up:
Traceback (most recent call last):
File "c-realv2.py", line 128, in
File "c-realV2.py", line 83, in readJson
File "json_init_.py", line 293, in load
File "c:\planguages\python\lib\encodings\cp1252.py", line 23, in decode
UnicodeDecodeError: 'charmap' codec cant't decode byte 0x9d in position 559: character maps to
[11024] Failed to execute script c=realV2
Then it crashed
I have a feeling it may be due to me adding unicode fonts for in the after area but i have yet to test it
Have you checked the errors in the console?
No

From the error, it does looks like it's cost by some Unicode characters. Can you reply below the Unicode you used?

I have fixed the issue by removing everything in the after section since it was only 1 command


No way to differentiate between RecordRef.Copy when using Variant

When using a variant for generic code, there doesn't seem to be a way to differentiate between overloaded RecordRef.Copy()-function calls.
If the variant was a recordref, I could do
sourcerecref:=variant;
recordref.copy(sourcerecref);

But in this case the variant is a Record, which is precisely why I need recref.copy.
"The call is ambiguous between the method 'Copy(var Table, [Boolean])' defined in Class 'RecordRef' by the extension '' and the method 'Copy(RecordRef, [Boolean])' defined in Class 'RecordRef' by the extension ''.AL[AL0196]"
A type "Table" does not exist and we cannot do a cast, so this can probably not be done unless the Copy-function is split into two..?

This probably requires a new overload for the copy function to handle the record. There's no generic record type to cast to

Hi, I think what you are looking for is this:
var
     MyTable: Record "My Table";
     MyTableRecordRef: RecordRef;

MyTableRecordRef.GetTable(MyTable);

GetTable is equivalent to Copy.

This works with both normal records and temporary records (table gets shared).
table 50100 "My Table"
{
    fields
    {
        field(1; K; Integer)
        {
        }
    }
}

report 50100 "Test My Table"
{
    UsageCategory = Tasks;
    ApplicationArea = All;
    ProcessingOnly = true;

    trigger OnPreReport()
    var
        MyTable: Record "My Table";
        TempMyTable: Record "My Table" temporary;
    begin
        GlobalLanguage(1033);

        MyTable.Reset();
        MyTable.DeleteAll(true);

        MyTable.Init();
        MyTable.K := 1;
        MyTable.Insert(true);

        MyTable.Init();
        MyTable.K := 2;
        MyTable.Insert(true);
        MyTable.Mark(true);

        MyTable.Init();
        MyTable.K := 3;
        MyTable.Insert(true);
        MyTable.Mark(true);

        MyTable.SetFilter(K, '>%1', 0);
        MyTable.MarkedOnly(true);

        TempMyTable.Init();
        TempMyTable.K := -1;
        TempMyTable.Insert(true);

        TempMyTable.Init();
        TempMyTable.K := -2;
        TempMyTable.Insert(true);
        TempMyTable.Mark(true);

        TempMyTable.Init();
        TempMyTable.K := -3;
        TempMyTable.Insert(true);
        TempMyTable.Mark(true);

        TempMyTable.Init();
        TempMyTable.K := -4;
        TempMyTable.Insert(true);
        TempMyTable.Mark(true);

        TempMyTable.SetFilter(K, '<%1', 0);
        TempMyTable.MarkedOnly(true);

        Message(
            'Normal: %1\\Temporary: %2',
            GetRecordInfo(MyTable),
            GetRecordInfo(TempMyTable));
    end;

    local procedure GetRecordInfo(
        RecordVariant: Variant): Text
    var
        _RecordRef: RecordRef;
    begin
        _RecordRef.GetTable(RecordVariant);
        exit(StrSubstNo(
            'IsTemporary: %1; Count: %2; Filters: %3',
            _RecordRef.IsTemporary,
            _RecordRef.Count,
            _RecordRef.GetFilters()));
    end;
}

Output:
Normal: IsTemporary: No; Count: 2; Filters: Marked: Yes, K: >0

Temporary: IsTemporary: Yes; Count: 3; Filters: Marked: Yes, K: <0

Thanks for the suggestion. Since this is an improvement and not a bug, you can post this to our Ideas forum at https://aka.ms/BusinessCentralideas, or vote up the idea if its already there. We're constantly monitoring top Ideas and will consider them for a future release.


nixos/gitlab: Fix services.gitlab.enableStartTLSAuto

Motivation for this change
toString false results in an empty string, which, in this context,
is a syntax error. Use boolToString instead.
Fixes #86160

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg test gitlab


Try redesigning for a better homepage

Signed-off-by: Celeste Horgan<EMAIL_ADDRESS>

Never let the nit picky be the enemy of the good :)


panda-client 1.5.5 github action

automatic pull request

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add the packaging metadata to build the metalsmith snap

This is a package for the secure installation of apps that works in most Linux distributions.
Landing it upstream will enable builds for adventurous users.

You can find more information about snapcraft here: http://snapcraft.io/
If we upload the snap to the ubuntu store we will get a great way to deliver the software, and get transactional automatic updates. I've been testing the snap and it seems to me good enough to publish in the edge channel, which will make it really easy to do crowd-testing before the stable release.
If you have any doubts or comments, please let me know :)
[1] https://gist.github.com/elopio/2aacc0a2fe66dc9cbdce7cf25bc5dd4f

Coverage remained the same at 94.304% when pulling<PHONE_NUMBER>a82faefe558a65a8375758bd139fbe on elopio:snapcraft into 296a95328697183bdaae041461fcca05c468616e on metalsmith:master.

Coverage remained the same at 94.304% when pulling<PHONE_NUMBER>a82faefe558a65a8375758bd139fbe on elopio:snapcraft into 296a95328697183bdaae041461fcca05c468616e on metalsmith:master.

Hi, seems like a reasonable PR for the Metalsmith-CLI however I wanted to find out about how Metalsmith will behave with snapcraft.
Metalsmith doesn't do very much by its self, it requires plugins (npm packages or custom code) and a config file to coordinate how they behave. Is that something that could be done with Snapcraft?

Hey @woodyrew, thanks for reviewing this. As you said, this is for the CLI, which mostly serves as a showcase, it's not useful for people using metalsmith as a library. I had some fun trying the other examples and I think there are some potential uses. For example, you could bundle metalsmith, together with your plugins, npm, node and your content into a snap. Then you have your whole site + it's dependencies in a package that's installable in many linux distros. You probably wouldn't want to publish this in the store, but the store has a feature for private snaps that makes sense for this case. However, I'm not sure how compelling this would be for your current users who are used to npm to install everything.
The other use case I thought was packaging a bundle of node+metalsmith+npm packages. So people could make and deliver products on top of metalsmith. The users of those products just add their content, maybe tweak the theming a little, and deploy their site without having to install any additional plugins by themselves.
What do you think? Makes sense?
pura vida.

I'm a little bit skeptical of how useful a Snap version of metalsmith would really be in either of those use cases. Then again I'm not really all that familiar with Snaps, so maybe you can clarify.

You could bundle metalsmith, together with your plugins, npm, node and your content into a snap. Then you have your whole site + it's dependencies in a package that's installable in many linux distros.

How would Metalsmith existing as a Snap make this easier? They'd still have to use NPM for all the other dependencies, right? And if they're creating their own Snap to bundle other non-Metalsmith NPM packages with their site, why couldn't they just use that same process to include Metalsmith in their bundle? Based on the content of this PR, wouldn't bundling Metalsmith already be as simple as including plugin: nodejs in their Snapcraft file?
Also, if users want to publish their site as a Snap, why would they include Metalsmith as part of that package? Static sites are just that - static. Building them (which is the part that requires Metalsmith) is usually something that happens prior to deployment, not in the production environment.

The other use case I thought was packaging a bundle of node+metalsmith+npm packages. So people could make and deliver products on top of metalsmith. The users of those products just add their content, maybe tweak the theming a little, and deploy their site without having to install any additional plugins by themselves.

That's actually a pretty interesting use case. But again, how does Metalsmith existing as a Snap make this sort of thing any easier to develop? Snapcraft already seems to have really good support for bundling NPM packages as part of the Snap, why would you want to use a separate part for that?

Hello @Ajedi32. You are right, metalsmith as a snap is useful only for the CLI. I was just trying to reply to the question about the most common use of metalsmith as a library, not related to this PR.
The other use cases involve making another snap, with metalsmith only as a part of the bundle. Reading your comment makes me realize that my first example is actually not that useful, you might want your site to be installable everywhere, not buildable everywhere. So yes, it doesn't make a lot of sense to have metalsmith and the dependencies together with the content, and if you strip out the content is the same as the second scenario. What might be useful is to ship the generated content + a web server in a snap.

You are right, metalsmith as a snap is useful only for the CLI

That kinda comes back to @woodyrew's original point though. Metalsmith (including the CLI, not just the library) is almost entirely reliant on plugins - it's not very useful on it's own.
So with that in mind, how would this Snap version of the Metalsmith CLI handle Metalsmith plugins? Does it work with npm packages installed through the usual means? Or does it have its own isolated environment for npm packages? If the latter, how would a person using this Snapped version of Metalsmith install a plugin for it?

It will work with npm packages installed through the usual means. And as npm and node are bundled in the snap, you can use those.
Take a look at how I build the example site in my gist: https://gist.github.com/elopio/2aacc0a2fe66dc9cbdce7cf25bc5dd4f

In that case, this seems fine to me. Anyone else have any objections/questions/concerns?

None from me either.
On a side note: What are the differences between Snapcraft and Docker?

Well, the approaches are pretty different. Docker images include the operating system, and the communication between apps is generally through the network. Snaps instead use well-defined interfaces to decide which services provided by the host operating system and by other snaps can be consumed, so you can communicate in many different ways like network, unix socket, dbus. That is the plugs section in the yaml file. In this case, the snap has the home interface, so it can read and write to the home directory. In order to do that in docker you would have to mount the directory. So snaps are a lighter way to isolate apps, and offer the user and the developer more control about what's allowed and what is not.
In the end, you can mix and match depending on your requirements and your preference. We have snaps for docker and lxd, so even in an ubuntu all-snap installation, you could have snaps talking to services in containers.
We are writing snaps because we need a solution that works for phones, laptops, metal servers, the cloud and iot devices. Write one yaml, work everywhere.

Sounds interesting. Thanks for taking the time to explain. :smile:

Thanks to you for the review. Here's how you can push the snap to the store, let me know if you need a hand with that:
http://snapcraft.io/docs/build-snaps/publish
And we are all trying to make snapcraft a pleasure for all developers. If you have any complaints or suggestions, they will be highly appreciated.

Hello. I noticed that the Metalsmith snap didn't make it into the snappy store yet. Is there a problem we can help with to get it uploaded?

See #270. I haven't quite gotten around to creating a shared account for the Metalsmith Org yet. I'll give it a try sometime tomorrow...

Hiya, did you manage to get this pushed to the store? If there are problems in the sign-up process I'd like us to get them reported and fixed with the store team.

Well, I think I have the name registered now. Still need to experiment with getting the Snap built on my development environment though. Looks like I'm going to need a Linux VM? (I'm currently running Windows.)

That's certainly one option. The other alternative is to let it build in Launchpad (our build service) which would probably work out easier for you and better in the long run. That way you can have it auto-build on any changes landing, and auto-upload to the store for you. The documentation is at the link below under "Using Launchpad":-
https://snapcraft.io/docs/build-snaps/ci-integration
If however you do want to build locally, I'd recommend an Ubuntu 16.04.2 server iso from the link below. That way it will be leaner (no GUI) and you can use the snapcraft commands directly in it. If using bridged networking in the virtual machine (like VirtualBox) you can access any running services (like metalsmith) from outside the VM over the network.
http://releases.ubuntu.com/16.04/ubuntu-16.04.2-server-amd64.img

I think we may end up doing it with Travis, since we've already got a build going for that on #270, and it's nice to have everything consolidated in one tool.
That said, I'll probably try it out locally first just to get a feel for what the CI should be doing.

@Ajedi32 hello again! I'm came back because we have great new service that I think you will like. Take a look at https://build.snapcraft.io/
With a couple of clicks you can set up the metalsmith package, and it will take care of building and continuous delivery to the store.
It's in beta, so please let me know what do you think.

Thanks, I'll take a look. Sorry for taking so long to get to this; I've had other projects I've been working on lately so I haven't had much time to work on Metalsmith.

no need to apologize, we appreciate a lot your time and comments so far.


"Save copy of output data" not working in ASL or CEST widgets

This was reported and observed during a practical session however have not been able to reproduce it yet.

Cannot reproduce - closing until example found


Magic spells are passing through Sentinels

Hello,
Magic (Magic) spells are passing through Sentinels without causing any damage like you can see in this video below :
https://cf-e2.streamablevideo.com/video/mp4/ibio0.mp4?token=1523199630-Pq%2BVcf%2BEIZycls711%2BkF01bzjevyf3O04Dp8iTqtyY4%3D
Our Sentinel configuration : Sentinel configuration gist
Can you check that please ?
Thanks.

That is not a solid entity, that's a particle effect with damage / impact / etc. logic 100% local to the "Magic" plugin. It's up to them to explicitly support NPC targets.
You may be benefited from toggling settings like "/npc playerlist" which may increase the chances of the plugin believing that NPC to be a real player target.

@mcmonkey4eva Okey thanks, I created a new issue on the Magic GitHub

Magic does not target NPCs by default.
You can change this in the config, but I’m wondering - is there a simple way (metadata?) to differentiate between a Sentinel and other NPC?

@NathanWolf there's no reason to. If the NPC accepts damage, damage it.

I am currently doing nothing more complex than checking for “NPC” metadata.
The majority of users have asked for spells to ignore NPCs. It’s not just about damage, it’s about pushing them around. Most people don’t use NPCs this way, it’s really just Sentinel that changes the dynamic of what an NPC is used for.

Citizens has its own data helper (npc.data()) that most info is on. If you're able to hook into Citizens, using that and checking against NPC.DEFAULT_PROTECTED_METADATA would suffice (default value for it is true for reference). If it is true, the NPC is an invulnerable static NPC. If it is false, the NPC is able to take damage and be pushed around. These are checked against to ensure that standard Minecraft-given push/damage/etc. calls are blocked appropriately.
If possible at all, I would suggest ensuring damage/pushing calls are done through standard calls. Where not possible, a direct Citizens hook would be ideal. Might be other ways to test for that but I'm not sure offhand.

Thank you for that info! I will take a look and consider adding some better integration, I already have custom traits so it shouldn’t be a problem.
I have found that checking for entity metadata is surprisingly expensive, maybe this will be a performance improvement as well?
For what it’s worth I am just using Entity.setVelocity to push entities around, so it’s odd that works on NPCs, by the sound of it. Maybe it doesn’t, it’s been a long time since I turned NPC targeting on in my own plugin.

setVelocity is not restricted, as that's not a minecraft call, that's a Bukkit call (which doesn't interact with Minecraft's checking). Minecraft calls in this regard would be the logic path that fires when a player stands in the NPC's spot and it gets slowly pushed back, which is an entirely separate thing from setVelocity, which basically just edits the velocity value without verifying validity (on the assumption that the plugin calling it really does want that to happen).
Also yeah Bukkit entity metadata is concerningly weird in implementation and using a simpler call (that can be shortened to a single boolean check when Citizens hook is disabled) will very likely be a lot faster.

Awesome, sounds totally worth doing then. Thanks!


API calls from a custom filter after getting the response

Please share if it is possible to make an api call from a "post" filter after getting the actual response. Seems not working.
spring-cloud.version: Hoxton.SR4
spring-cloud-starter-gateway: 2.2.3.RELEASE
Something Like:
public class CustomFilter extends AbstractNameValueGatewayFilterFactory {

@Override
public GatewayFilter apply(Config config) {
	return new GatewayFilter() {
		@Override
		public Mono<Void> filter(ServerWebExchange exchange,
				GatewayFilterChain chain) {
			return chain.filter(exchange).then(Mono.fromRunnable(
					() -> callanotherservice(exchange, config, chain)));
		}

private Mono<Void> callanotherservice(ServerWebExchange exchange, NameValueConfig config, GatewayFilterChain chain) {
        TcpClient tcpClient = TcpClient.create().option(ChannelOption.CONNECT_TIMEOUT_MILLIS, 800)
                .doOnConnected(connection -> {
                    connection.addHandlerLast(new ReadTimeoutHandler(1000, TimeUnit.MILLISECONDS));
                    connection.addHandlerLast(new WriteTimeoutHandler(1000, TimeUnit.MILLISECONDS));
                });
        WebClient webClient = WebClient.builder()
                .clientConnector(new ReactorClientHttpConnector(HttpClient.from(tcpClient)))
                .baseUrl("http://localhost").build();

        MyRequest myrequest = prepareRequest(exchange); //another method to prepare request body
        WebClient.RequestHeadersSpec requestHeadersSpec = webClient.post().uri("/myapi.php")
                .bodyValue(myrequest);
        Mono<ClientResponse> clientResponseMono = requestHeadersSpec.exchange();
        return clientResponseMono.flatMap(clientResponse -> {
            return clientResponse.bodyToMono(String.class).flatMap(body -> {
                return chain.filter(exchange);
            });
        });
    }

No reason why it shouldn't work.
Can you provide a sample the demonstrate the problem you are seeing?

Sure. Let me add one in a while.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


4.I ¦M: Making it easy for users to identify errors and Correct them within the client

QOL/Feature: instead of exiting, prompt the user to provide an input file #34


Restore installing DevSupport to all the config

Summary:
CircleCI was broken because we changed how the React-Core/DevSupport pod is installed.
Changelog:
[Internal] - Restore the installation of React-Core/DevSupport
Differential Revision: D46734714

Committed in 875f6a70861a4e48c9bc001d30a55f24d87443ed


Direct connection stopped

The update to 0.22.0 made my exit node have a direct connection, which was great.
The recent 0.22.1 has reverted it back to relayed connections

My mistake, it is only doing relay connections from one device, it's ok on my phone


Matrix Multiplication

Do the checklist before filing the issue:

[x] Do you have Node.js and all the relevant dev-dependencies installed?
[ ] Is this a bug fix?
[x] Is this an enhancement?
[x] Is this a feature request?

NOTE: Provide a clear and concise description of the feature that needs to be added! Or if its a bug, then provide the necessary steps to reproduce it along with screenshots.

Matrix Multiplication, under validation check for dimensions of matrix and whether they match or not.
M.matrixMul( [ [1, 2], [3, 4] ], [ [1], [2] ] )        // [ [5, 11] ]

Validation -
M.matrixMul( [ [1,2,3],[1,2] ], [ [1],[2] ] )     // Error incorrect matrix
M.matrixMul( [ [1,2],[3,4] ] , [ [1],[2],[3] ] )  // Error dimensions don't match, columns of 1st to rows of 2nd

Also, validate whether there are only floats and ints in the matrix.

Will the data type of the elements of the matrices matter in JavaScript?
Because all variables are of type float/double.

Will the data type of the elements of the matrices matter in JavaScript?
Because all variables are of type float/double.

The number of columns (ie. number of elements in each row) must be same.
The number of rows is the number of arrays in the main root array.
The contents of each array can be any number or float, positive or negative, it can't be a string or a boolean or another array (for now, dealing with 2D matrices here)

I will work on this

@sateslayer you're assigned


Display full Kustomize errors instead of a simple error message

This is resolved by https://github.com/onepanelio/cli/pull/19


Add authors to citation cff

Description

Closes #2524
Link to documentation:

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Documentation is available
[x] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

~### New or updated recipe/diagnostic~

[ ] 🧪 Recipe runs successfully
[ ] 🧪 Recipe is well documented
[ ] 🧪 Figure(s) and data look as expected from literature
[ ] 🛠 Provenance information has been added

~### New or updated data reformatting script~

[ ] 🛠 Documentation is available
[ ] 🛠 The dataset has been added to the CMOR check recipe
[ ] 🧪 Numbers and units of the data look physically meaningful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

@remi-kazeroni you want to add yourself as well here?


Typing a new character throws an error when auto-completion gets called

Please read through this section before posting a bug report.

My testing minimal init.vim
Post your init.vim to help me reproduce this issue
aesthetics.vim:
https://pastebin.com/p5eDf1ZE
general.vim:
https://pastebin.com/aCvdEmSs
mapped.vim:
https://pastebin.com/PVry35Dt
initial_plugins.vim:
https://pastebin.com/SBYT7pjf
lsp_config.vim:
https://pastebin.com/PekTjkRE
init.vim:
https://pastebin.com/jxb5gcK6
How to reproduce
Detailed step to reproduce this issue.
-Load all .vim config files
-With any of the following Lsp servers:  sumneko_lua, tsserver, vimls, jsonls
-open a correspondent *.ts , *.lua, *.vim, *.js, or *.json file
-type a new character in a new line
-completion nvim will attempt to trigger, but fail with the following error:

Expected behavior
The expected behaviour should be: No errors should be thrown from completion-nvim when typing new characters.
Surprisingly, this does not seem to happen at all with *.vim files.

I can't reproduce on my side though. Have you updated completion-nvim to the latest master branch?

I guess it seems caused by old nvim.

@hrsh7th Ahh you're right I remember that. @tr0b consider update your neovim to the latest master.

@haorenW1025 Oh, I haven't updated neovim in a while. I will try updating it!

Seems like updating neovim to the latest nightly release and updating completion nvim fixed the problem. Thank you @haorenW1025 and @hrsh7th !


Error when creating "newwebapp" with "project" generator

Easy-Ui5 version:
3.6.2
OS/version:
Windows 11 Enterprise 22H2
Browser/version (+device/version):
Not yet run on browser as project is not getting created
Steps to reproduce the problem:
Create newwebapp using the project generator
What is the expected result?:
project/newwebapp should be created successfully
What happens instead? Error in creating the newwebapp -
An error occured while running ui5-project:newwebapp#writing
Error easy-ui5
Cannot read properties of undefined (reading 'includes')
Any other information? (attach screenshot if possible)

Hey there 👋
Have you, by any chance, tried to directly call the sub generator "newwebapp" without previously selecting "app" and creating an app in the first place? If I remember correctly, "newwebapp" is not supposed to be called standalone. All the sub generators with "new" in their name are usually called from within an already existing project to ease creation of new development artifacts.
I think what you're looking for is simply running the "app" generator (which internally uses the newwebapp sub generator to generate the new app). :)

Hi @wridgeu
You are absolutely right. I did directly call "newwebapp". However, If it is not supposed to be called standalone, then why there is a prompt for the project creation? Additionally, the error that comes up, clearly does not highlights the same.
Regards,
Prashant

Hi @sonip1992
true that! There is some room for improvement. You'd have to first figure out if you're in an environment/context where a project already exist or not and based on that maybe adjust the options shown. Let's see what @petermuessig (not sure who to directly tag here, sorry 😅) thinks.
Anyway, were you able to resolve the initial issue?

Including also @nicoschoenteich into the loop. I have to follow-up with him first.

@sonip1992 - can you verify with the latest update whether it works? Just run the template again, it should update automatically and let us know what happens. What I've learned today is that the sub-templates require a proper configuration from the original execution which is stored in the ´.yo-rc.json` and in case of it is missing a configuration due to a newer version of the template the sub-templates may fail.
@nicoschoenteich this is an architectural issue of the project generator template as it is not prepared for such cases. For a re-design of the project template one should be aware to ensure that the plugin works properly even if parameters are missing an may question them again. Maybe also a proper version check should be introduced...

@petermuessig thanks for suggesting this. However, i now get a new error:

With the new version of the generator (PR https://github.com/ui5-community/generator-ui5-project/pull/75) this issue is fixed. You can now create new uimodules inside and existing project. The project overalls follows a monorepo approach.


LLVM usage

Brief Description
I have two problems with current use of LLVM inside CppSharp.

The version is from trunk and not a released version
Use of private (not installed) headers such as CodeGen/CodeGenModule.h and others.

These issues prevent getting LLVM from a package manager which in my opinion is a serious downside.
Moreover, the private headers, I believe, can change without notice and break the library.
Do you agree this is problematic and if so do you plan to fix them one day?

Historically we've never used official LLVM releases because we've always depended on trunk for bug fixes (at some point we even had to apply custom patches).

I believe at this point we could switch to a tagged release, but it does limit us in the future in case we need to depend on a recent commit (like we did recently for VS2017 support).
Since this is related to using LLVM from a package manager, another issue related to this is that Clang does not support shared library exports for its API on Windows, so we need to link statically anyway, which would mean we'd only get the benefit from a shared library on non-Windows platform (Linux presumably?).

I think this might could cause issues in the future yes, but it's not been an issue ever since we introduced usage of those APIs. They seem pretty stable at this point in Clang history and unlikely to change. If they do, we'll just update to their equivalents.

I was checking why need them (it's been a while) and it's to get ABI codegen information for return and parameter types. Not using them is not an option since it would mean generating code that crashes at runtime.
Getting the Clang developers to put those APIs under public headers would be an option, but we've been that road before for other APIs and it's a huge waste of our limited time.
We've put a lot of effort and time over the years to make our usage of LLVM as painless as possible to both developers and users, with build scripts for getting, building and packaging pre-compiled LLVM packages for our supported platforms.
If you want to package CppSharp for a package system (which one, by the way?) just do not depend on the package manager's built-in version of LLVM/Clang. All this does really is add a few extra MB of code to the package, and since this is a developer's tool and not a library to be distributed to end-users, I don't think that's an issue to be concerned about.
And it means we can make sure our own version of LLVM is fully-tested and works properly. As we depend on such a heavy set of APIs in Clang, re-using a package manager's version might mean compatibility issues.

Indeed I thought of adding CppSharp to Hunter and I would like to get LLVM from Hunter as well.
The problem with having CppSharp downloading LLVM by itself is described here.

What I recommend doing is just packaging CppSharp by itself, without any dependency on the package manager's LLVM/Clang library. That should work fine. In the end, all of the LLVM/Clang's code will be statically linked in CppSharp.CppParser.dll.
Another issue I forgot to talk about, is that Clang releases (at least on Windows) only provide the C API for linking, while we depend on the C++ API.

Closing, let us know if you have any other issues creating the package.


Client telemetry should provide better error identification

Description
When looking at our client telemetry at errors, we have a few values:

Command executed (if parsed and known)
Message text
Stack trace
Fault type

But these values make it impossible to collate down to a specific error condition.  For example, identifying login errors or polling state failures can only be investigated via manual processes.
Is it possible to provide some invariant error names (FaultName)?

@fengzhou-msft  add to S162.


Valorant New Act rank yoinker errors out in party+game

ss of console. After new Act rank yoinker just doesnt work. how to recreate it? launch it.

This is very likely due to the new agent Chamber being added, but unactivated until November 16.

Use the latest version with python

Still doesn't work, using Python 3.10 and the source from https://github.com/isaacKenyon/VALORANT-rank-yoinker/commit/a3bf92308fd5a11b3ed8adc17a0e4dffd40784bb . When checking the API's agent list , there are no mentions of Chamber, so the issue is probably on their end.

most apps are experiencing Api problems due to the update. current theory is that a url changed, we'll see what we can do.

https://github.com/isaacKenyon/VALORANT-rank-yoinker/commit/f4446fbf83da022722118694ad93ea90f714f0c4 seems to have fixed it. Thank you for the quick fix.


HW 1, Question 3

I'm confused how question three can be calculated without any data. Is there a missing dataset, or are we supposed to pull from an online source?

Going to go with Catherine Ross's dataset from 1990. Has all of the data mentioned: http://www.icpsr.umich.edu/icpsrweb/ICPSR/studies/6666. See https://github.com/IamGianluca/arm/blob/89c43c8c9f630908f2a21e2b7d09fdf588e2dc5b/ch4/arm_ch4p2.md for easily cleaning the data.

There in no dataset; you must imagine one. You are supposed to make up
reasonable output.
On Feb 2, 2017 1:52 PM, "William Fry"<EMAIL_ADDRESS>wrote:

Going to go with Catherine Ross's dataset from 1990. Has all of the data
mentioned: http://www.icpsr.umich.edu/icpsrweb/ICPSR/studies/6666. See
https://github.com/IamGianluca/arm/blob/89c43c8c9f630908f2a21e2b7d09fd
f588e2dc5b/ch4/arm_ch4p2.md for easily cleaning the data.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kapelner/Wharton_Stat_422_722/issues/1#issuecomment-277047146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoK-A7mow5Szh-h4EAXR-lezM9qgKHLks5rYiXugaJpZM4L1dDw
.


add http config for kickstart

No longer serving kickstart files over nfs. Now using http. So, add to http config
    location /kickstart/ {
        alias /srv/kickstart/;
    }

This probably should be off of /kickstart. There is a question about whether this should be public information. Kickstart should have restricted IPs.

off of /kickstart

What does that mean? A subpath of /kickstart (ex /kickstart/foo)?


Problem with divs animated

Hi! If you have a div in a left position and when you click it if change the position, the hint it's not in the correct position!
Nice works!! Regards!!

Sorry for late answer, can you give example where this issue happened?

Yes, sure.
Imaging you have a div in left position -120px, and when you click other div, it goed to left 20px, ok?
The hint is in the old position, not the new...

As I understand, you doing following things:

Creating some blocks, divs or anything else
Creating instance of EnjoyHint
Updating div's position, size or maybe shape
As result, Hint uses old position and size, yes?

Exactly!!
El martes, 27 de enero de 2015, Alex Saskevich<EMAIL_ADDRESS>escribió:

As I understand, you doing following things:

Creating some blocks, divs or anything else
Creating instance of EnjoyHint
Updating div's position, size or maybe shape
As result, Hint uses old position and size, yes?

—
Reply to this email directly or view it on GitHub
https://github.com/xbsoftware/enjoyhint/issues/3#issuecomment-71662780.


Remove secret file after sourcing env vars from it

Change-type: patch
Signed-off-by: Giovanni Garufi<EMAIL_ADDRESS>

@balena-ci I self-certify!


Tracking pipeline and task execution time

Expected Behavior
As a user/pipeline developer, I would like to be able to track how long my pipeline execution takes over a period of days/months, at the individual Task level and at the Pipeline level.
Actual Behavior
There is no way to see this

@tejal29 had pointed out in slack that we already have this in the Build step states:
    stepStates:
    - terminated:
        containerID: docker://4cb2c0b027c8441a22c39f48ce4c3a1d60e6529b10341d08abfa3d5854477d30
        exitCode: 0
        finishedAt: 2018-10-16T23:03:29Z
        reason: Completed
        startedAt: 2018-10-16T23:03:29Z
    - terminated:
        containerID: docker://cdf53948f5871e18cc1ce00f6a385d02446332823e7ec66bbccdce263ddf6459
        exitCode: 0
        finishedAt: 2018-10-16T23:03:31Z
        reason: Completed
        startedAt: 2018-10-16T23:03:30Z
    - terminated:
        containerID: docker://49dfc0d9498d02557a8f35f0e81d9e5517e2b7f537836604c727ccf399bc244a
        exitCode: 0
        finishedAt: 2018-10-16T23:04:06Z
        reason: Completed
        startedAt: 2018-10-16T23:03:31Z

(startedAt and terminatedAt)
Is this the same info you're looking for in this issue? (Is this issue about adding those fields to TaskRun + PipelineRun?)

Closing this in favour of #164 - they are so closely related it doesn't make sense to have both. I'll address your comment there.

kk, thanks @tanner-bruce !


Pipeline yaml files for youth ui main branch

Description :sparkles:
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

This will cause deployments of all UIs regardless of changed UI. This is accepted by the dev team as long as it doesn't make deployments hang (long deployment time is not an issue as PLATTA is not used for DEV style use).


Support for extract-text plugin bundles

Webpack docs describes the use of ExtractTextPlugin to embed stylesheets to JS bundles, and it also guides the generation of a separated CSS bundle. This plugin is really useful to generate the manifest of the bundled assets but it is creating an invalid version when ExtractTextPlugin is configured to generate a separated bundle.
With the version 0.1.0, the following configuration will generate a .js value instead of .css:
{
  entry: {
    app: './src/app.js',
    styles: './src/styles.js'
  },
  module: {
    loaders: [
      {test: /\.css$/, loader: ExtractTextPlugin.extract('style-loader', 'css-loader')}
    ]
  },
  output: {
    filename: 'app-bundle.js'
  },
  plugins: [
    new ExtractTextPlugin('app-bundle.css', {allChunks: true})
  ]
}

output:
{"app":"app-bundle.js", "styles":"app-bundle.js"} // it should be: "styles":"app-bundle.css"

I did a small change to consider the last value (the most updated bundle) when chunk value is an array and deal with the exceptions when devtool is used. I believe this will be useful for everybody but I do understand if you want to keep the manifest just for JS files.
This pull request includes the "fix" and the tests for this use case, thanks.

Thanks


Return 404 if accessing unpublished dataset aka entity list

Backend part of https://github.com/getodk/central/issues/467

What has been done to verify that this works as intended?
Tested it with frontend and added a specific test.
Why is this the best possible solution? Were any other approaches considered?
When getting metadata about a dataset/entity list, it doesn't even seem to include the publishedAt timestamp, so it makes sense to only return published datasets at the /datasets/:name url and return 404 resource not found otherwise.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Limits access to unpublished datasets but makes some parts of frontend more consistent.
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
Writing this out in the API would be a good idea. Tagging https://github.com/getodk/central-backend/issues/949
Before submitting this PR, please make sure you have:

[x] run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
[x] verified that any code from external sources are properly credited in comments or that everything is internally sourced

This issue was actually fixed by #934 and now this PR is just a new test :D


Cannot send incoming emails to HTTP Endpoint

When attempting to forward incoming emails from the Postal mail server to an HTTP endpoint, the operation fails with a timeout error, and the following message is logged: 'Timed out after 5s. Time: 5.01s. Support Ref: QW3MRAGD'.
To Reproduce

Create Mail Server
Add Domain
Create HTTP Endpoint (Encoding: Sent in the body as JSON, Format: Delivered as the raw message, Strip Replies: Try to seperate replies/signatures from plain body, Attachments: include, Timeout: 0)
Create route with the HTTP endpoint as the endpoint

Expected behaviour
Upon receiving an email, the Postal server should successfully send the JSON data to the specified endpoint. If the endpoint returns a 200 response, the operation should be marked as complete, and no further action should be taken.
Screenshots

The error details provided by Postal are included in the description. It's worth noting that the API endpoint used for testing is a demo one, and the issue persists even after testing with an alternative endpoint.
Environment details

OS: Ubuntu 18.04.3 LTS
Browser: Chrome

@willpower232 - it works as expected and receive a successful response. I can also use Postman to the endpoint and that is working, but for some reason it will throw an error in Postal.

Found these logs but not enough information for me to debug the issue:
worker_1    | [8] [2023-12-04T16:54:50.332] INFO -- : [IGF88KUOKJ] Lock acquired for queued message 665
worker_1    | [8] [2023-12-04T16:54:50.338] INFO -- : [IGF88KUOKJ] Found 0 associated messages to process at the same time (batch key: incoming-rt:5-ep:4-HTTPEndpoint)
worker_1    | [8] [2023-12-04T16:54:50.339] INFO -- : [IGF88KUOKJ] [21::1 665] Got queued message with exclusive lock
worker_1    | [8] [2023-12-04T16:54:50.347] INFO -- : [PBLH6GKM] Sending request to http://webhook.site/0702ccd8-93d0-46f5-9cb7-6426114ac666
worker_1    | [8] [2023-12-04T16:54:55.351] INFO -- : [PBLH6GKM]   -> Received: -1
worker_1    | [8] [2023-12-04T16:54:55.351] INFO -- : [PBLH6GKM]   -> Body: Timed out after 5s
worker_1    | [8] [2023-12-04T16:54:55.358] INFO -- : [IGF88KUOKJ] [21::1 665] Message requeued for trying later.

Wait is your webhook set up in Postal for http or https?

It is set to https, however http is the same result
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Will Power @.>
Sent: Tuesday, December 5, 2023 5:12:19 PM
To: postalserver/postal @.>
Cc: Joshua J. Cadman @.>; Author @.>
Subject: Re: [postalserver/postal] Cannot send incoming emails to HTTP Endpoint (Issue #2717)
CAUTION: Please note this message has arrived from an external sender.
Be careful when opening any links or attachments especially if logging in or providing data.
If you require any assistance, please contact the Service Desk.
Wait is your webhook set up in Postal for http or https?
—
Reply to this email directly, view it on GitHubhttps://github.com/postalserver/postal/issues/2717#issuecomment-1841255683, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDFWTGPHT7BKOFAGOQVYRDLYH5IXHAVCNFSM6AAAAABAFFCR26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRGI2TKNRYGM.
You are receiving this because you authored the thread.Message ID: @.***>

Did a reset of the server and this is now sending emails to the endpoint, not sure what the issue was.

Back again with this issue, and it appears that this is the case on two of my servers running Postal. This happens a lot so there must be something wrong with the configuration or a bug within Postal. I can do a curl request from the terminal and that works no problem.

I have tried to use https://webhook.site to give me a temporary URL just to see if it is anything to do with the domain I try to send to, but seems like that is also timing out.

Just thought I would give an update, after a long week of this intermittent issue, it seems that the DNS server that configured by default to our hosting providers DNS, could not locate any domain. After updating the DNS server on our mail servers, it seems that I can now send requests to an HTTP Endpoint.


feat: add pluto export and import database functionality

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update dependencies

npm audit detected issues

@thomasrockhu Can you review?
@hootener can you add me to the Codecov GitHub Org? SOC-334


Update catalog-private-link-faqs.md

fix spelling mistake

@isdataninja - thank for helping keep our documentation cleanly edited.


mj-raw incorrectly omits closing tag

<mjml>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-raw></mj-raw>
        <mj-text>
          Hello World!
        </mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

mjml.io output fragment:

mrml output fragment
</mj-raw>

which causes the end tag to remain when rendering using mrml. This is however inconsistent with the behaviour of mjml.io.
(Before someone tells me not to include script tags in emails, I'm not! 😄  But I am displaying rendered content in a browser, where I use script tags)

Yeah, the implemented html renderer will write a closing element if there is no children. I understand that it's not consistent in term of html but in term of visual, it should stay the same.
I should mention that in the readme though 👍
If you have another point of view about it, feel free to share it with me, I'd be happy to reconsider my choice 😉

Chrome (and Safari, I guess WebKit, haven't tried Firefox) disagrees on the visual side 😄  (sorry I should have added this to the original ticket)
Here is the HTML that Chrome constructs when rendering the HTML generated by mrml from the above snippet:

The browser tries to close the script tag, but in doing so captures the rest of the content. The html generated by mrml therefore renders as a blank page instead of showing "Hello World".

interesting! I will move that up then.
I should also put in place some browser testing on the CI


Typo fix in model.md: reccomend->recommend

Line 12: reccomend->recommend

I signed it!

recreate this PR


RFC 0008: Pod Templates

Comments due by Monday, December 9th.

the implementation is staged in https://github.com/projectriff/system/pull/234 and https://github.com/projectriff/cli/pull/155


Add function 'groupByNodes' to group on several indexes

Add a new function 'groupByNodes' that support multiple indexes like the function 'aliasByNode'.
This avoids to add a new graph target for each new metric/node created.
Ex:
&target=groupByNodes(ganglia.server*.*.cpu.load*,"sumSeries",1,4)
Will "generate" the following formula :

sumSeries(ganglia.server1.*.cpu.load5)
sumSeries(ganglia.server1.*.cpu.load10)
sumSeries(ganglia.server1.*.cpu.load15)
sumSeries(ganglia.server2.*.cpu.load5)
sumSeries(ganglia.server2.*.cpu.load10)
sumSeries(ganglia.server2.*.cpu.load15)
...

Will produce the following legends :

server1.load5
server1.load10
server1.load15
...
server2.load5
server2.load10
server2.load15
...

I can see how this would be useful, but could it be achieved by adding the functionality to groupByNode() and maybe aliasing groupByNodes() to groupByNode()?

Yes, it would be possible to merge some code, but due to the callback parameter being not at the same place, we must either :

keep the function groupByNodes and modify the function groupByNode to call groupByNodes

def groupByNode(requestContext, seriesList, nodeNum, callback)
  groupByNodes(requestContext, seriesList, callback, nodeNum)

def groupByNodes(requestContext, seriesList, callback, *nodes)
  ...

or we can keep only the groupByNode function and accept parameters in several orders by detecting their types, etc (a bit ugly IMO)

def groupByNode(requestContext, seriesList, *args)
  if isinstance(args[0], int)
    ...

Any preference/other  idea ?

Possibly use *args and require that the callback always be the last parameter or alternatively do it the way you have proposed, but strip the code from groupByNode() and convert it to a wrapper of groupByNodes() so that it's backwards compatible but we avoid code duplication.
What do you think @obfuscurity ?

@steve-dave Yeah, :+1: on your proposed change. That seems like the "least ugly" of all choices. But we need some very solid test coverage for this merged function to cover both use cases.

@gboily can you please convert groupByNode() to a wrapper of groupByNodes() and ensure there are good tests?

@steve-dave I've updated groupByNode and added tests.
I was not able to use "sumSeries" (nor other *Series I guess) so I used "keepLastValue" instead.
So, tests only test aliases computation and not really calculation results as keepLastValue does not change the values in that case.
Here is the error when using "sumSeries" :
ERROR: test_groupByNodes (tests.test_functions.FunctionsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/src/graphite-web2/webapp/tests/test_functions.py", line 291, in test_groupByNodes
    verify_groupByNodes(expectedResult, 1)
  File "/usr/local/src/graphite-web2/webapp/tests/test_functions.py", line 281, in verify_groupByNodes
    results = functions.groupByNodes({}, copy.deepcopy(seriesList), "sumSeries", *nodes)
  File "/usr/local/src/graphite-web2/webapp/graphite/render/functions.py", line 2855, in groupByNodes
    metaSeries[key])[0]
  File "/usr/local/src/graphite-web2/webapp/graphite/render/functions.py", line 191, in sumSeries
    name = "sumSeries(%s)" % formatPathExpressions(seriesList)
  File "/usr/local/src/graphite-web2/webapp/graphite/render/functions.py", line 157, in formatPathExpressions
    [pathExpressions.append(s.pathExpression) for s in seriesList if not pathExpressions.count(s.pathExpression)]
AttributeError: 'TimeSeries' object has no attribute 'pathExpression'

I also got a timezone problem and temporaly disabled test_render.test.
It may be due to running tests in a docker container (I tried changing my timezone to GMT and GMT+1 without success) :
# tox -e py27-django14 -- /usr/local/src/graphite-web2/webapp/tests/test_functions.py:FunctionsTest
GLOB sdist-make: /usr/local/src/graphite-web2/setup.py
py27-django14 inst-nodeps: /usr/local/src/graphite-web2/.tox/dist/graphite-web-0.10.0-alpha.zip
py27-django14 runtests: PYTHONHASHSEED='1309592725'
py27-django14 runtests: commands[0] | django-admin.py test
/usr/local/src/graphite-web2/webapp/graphite/settings.py:233: UserWarning: SECRET_KEY is set to an unsafe default. This should be set in local_settings.py for better security
  warn('SECRET_KEY is set to an unsafe default. This should be set in local_settings.py for better security')
Creating test database for alias 'default'...
....................................F.../usr/local/src/graphite-web2/.tox/py27-django14/local/lib/python2.7/site-packages/django/db/models/fields/__init__.py:808: RuntimeWarning: DateTimeField received a naive datetime (1970-01-01 01:00:00) while time zone support is active.
  RuntimeWarning)
.............
======================================================================
FAIL: test_correct_timezone (tests.test_render.RenderTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/src/graphite-web2/webapp/tests/test_render.py", line 122, in test_correct_timezone
    self.assertEqual(data, expected)
AssertionError: Lists differ: [[12,<PHONE_NUMBER>], [12, 139339... != [[12,<PHONE_NUMBER>], [12, 139340...

First differing element 0:
[12,<PHONE_NUMBER>]
[12,<PHONE_NUMBER>]

- [[12,<PHONE_NUMBER>], [12,<PHONE_NUMBER>]]
+ [[12,<PHONE_NUMBER>], [12,<PHONE_NUMBER>]]

----------------------------------------------------------------------
Ran 53 tests in 0.251s

FAILED (failures=1)

This would be very useful. What needs to happen to make this mergeable?

@robertclancy We'd need to first rebase it, then resolve the issues reported by @gboily and put it through some actually test use.

looks good to me. i need this. i applied the patch to functions.py and am already using it in prod :+1:

@gboily Thanks for your PR! We've had a few similar PRs and seem to have settled on yours to solve the problem. Would you mind dropping by this thread and rebasing so we can look towards merging this?
Thank you!

@gboily One last ping on this; otherwise we'll probably take over this PR / patch and make it mergable.
@Dieterbe perhaps you'd be best positioned to turn this into a mergable PR given that you've already done it against your system?

I am also willing to help if @gboily and @Dieterbe are busy.

@ctrochalakis go for it :-)


doc: use cargo readme to update

...why is GitHub detecting README.md as a BIN?

congrats, @attila-lin, this PR was the 500th commit on miette! 🎉


Keyboard Interruption checkpoint saving?

Hi.
Do you plan to implement checkpoint saving and then exiting on keyboard interruption officially? Now the program just ignores keyboard interruptions. Great appreciate on that if so.

Good suggestion. Currently the runner will only save a checkpoint after each epoch, and we will add the requested feature later.

Does it support the keyboard interruption checkpoint saving?

Not yet，but we have put this feature to our plan

Does it support the keyboard interruption checkpoint saving?


Openshift - file with multilines not working as defined in included example

What happened: I configured the pickup of a separate log file with multi lines. I defined this per the included example in the helm chart and run into a config error.
2022-01-27 19:45:00 +0000 [info]: parsing config file is succeeded path="/fluentd/etc/fluent.conf"
2022-01-27 19:45:00 +0000 [info]: gem 'fluentd' version '1.14.2'
2022-01-27 19:45:00 +0000 [info]: gem 'fluent-plugin-concat' version '2.4.0'
2022-01-27 19:45:00 +0000 [info]: gem 'fluent-plugin-jq' version '0.5.1'
2022-01-27 19:45:00 +0000 [info]: gem 'fluent-plugin-kubernetes_metadata_filter' version '2.9.2'
2022-01-27 19:45:00 +0000 [info]: gem 'fluent-plugin-prometheus' version '2.0.1'
2022-01-27 19:45:00 +0000 [info]: gem 'fluent-plugin-record-modifier' version '2.1.0'
2022-01-27 19:45:00 +0000 [info]: gem 'fluent-plugin-splunk-hec' version '1.2.9'
2022-01-27 19:45:00 +0000 [info]: gem 'fluent-plugin-systemd' version '1.0.2'
2022-01-27 19:45:08 +0000 [error]: config error file="/fluentd/etc/fluent.conf" error_class=Fluent::ConfigError error="Invalid regexp '': No named captures"
What you expected to happen: no errors in config
How to reproduce it (as minimally and precisely as possible): use below log config in values.yaml
logs:
tomcat:
from:
file:
path: /var/log/tomcat//.log
multiline:
firstline: /.{3}\s\d{2},\s\d{4}\s\d{1,2}:\d{2}:\d{2}\s.{2}/
separator: "\n"
sourcetype: tomcat
Anything else we need to know?: I added the seperator, which is supported.  error still occurs if you remove that line.
Environment:

Kubernetes version (use kubectl version): Openshift 4.8 OKD
Ruby version (use ruby --version): see error msg for container versions
OS (e.g: cat /etc/os-release): fluentd container referenced in helm chart 1.4.11
Splunk version: 8.1.7
Splunk Connect for Kubernetes helm chart version: 1.4.11
Others:

@shane-emery Error in the log refers to invalid regex, can you please share a sample log event for which you trying to apply this regex?

Closing the issue as it has been inactive for a long time. Feel free to reopen this issue or create a new one if needed.


[assemble] Failure to assemble with -Djreleaser.assemblers=nativeImage

From https://github.com/jreleaser/jreleaser/issues/655#issuecomment-1414315060
I seem to have run into the same or a related issue, using jreleaser-maven-plugin:1.4.0. This call here gives me a warning:
mvn -Djreleaser.assemblers=nativeImage jreleaser:assemble

...
[INFO] Included assemblers: [nativeimage]
[WARNING] Unsupported assembler nativeimage
...

While this works, i.e. it starts the native image assembler:
mvn -Djreleaser.assemblers=native-image jreleaser:assemble

Environment Information

Operating System: N/A
JReleaser Version: 1.4.0
JDK Version: N/A

Released in v1.5.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.5.0


Add visited stoarge entries methods to execution objects.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dc5e3f4) 67.42% compared to head (dc5e3f4) 67.42%.

:exclamation: Current head dc5e3f4 differs from pull request most recent head b3ab6d0. Consider uploading reports for the commit b3ab6d0 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           main-v0.13.0    #1302   +/-   ##
=============================================
  Coverage         67.42%   67.42%
=============================================
  Files                53       53
  Lines              6837     6837
  Branches           6837     6837
=============================================
  Hits               4610     4610
  Misses             1815     1815
  Partials            412      412

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Status inquiry on v0.5.10(?) release for key rewrite bug with Secrets Manager

https://github.com/external-secrets/external-secrets/issues/1488
https://github.com/external-secrets/external-secrets/issues/1447
It has been addressed and merged, is there any possible ETA on v0.5.10? I consume ESO via the helm chart.
It's blocking my work integrating some standard key rewrites in an internal helm chart of my own.
Thank you!

Hey! Sorry to hear that youre blocked :(
We want to do a release soon, tomorrow would be suboptimal due to a DNS migration. I believe Monday should work.
CC @gusfcarvalho

I want to get #1525 in before i do a release.
@gusfcarvalho is the DNS migration done?

DNS migration is still ongoing;

What is the "DNS migration"? Out of curiosity. Thanks for the quick updates here.

Hey, we're moving our domain to the linux foundation, that's part of the CNCF Sandbox onboarding :)

DNS Migration is done :heavy_check_mark:, gonna do another round of reviews and prep a release :+1:


How do I trigger a Media Player input

I'll start this by saying that I am very new at HA - I am however a Crestron veteran.
I was able to configure HA with the instructions provided, and my Crestron system is connecting successfully to HA.
Now for the part that should be very easy: How do I create a card on a dashboard that changes the volume, input, mute, etc...? I get this message whenever I try and do just about anything with the object:

Thanks in advance.

Hello,
I have the sam problem
did you find the solution because I have the same problem?
Thank you for your feedback.

No, I haven't been able to make it work yet (to be honest, I haven't had that much to dedicate to it)

@marty6001
thank you for your feedback.
Unfortunately no one is replying to me on the various forums.

here are the two mistakes.
On my toolbox my TCP/IP is properly connected


Suggestion for registering collection

Hello,
I've created this extension after using your library. Perhaps you would be interested ? Up to you to decide if you do something with it or not.
https://gist.github.com/timemaster67/6135f0a04225d348b598187e0c04d88d
This allow you to receive a ILiteCollection instance in the constructor of your class, instead of a LiteDatabase instance.
The first method was designed so that I can add as many call to collection.AddTransient as I have LiteDb entity. I would have one call to AddLiteDbRegistries in my startup. Thought it might not be library friendly....
I've added the second method, where you can easily add all your entity to the startup like this
services.AddLiteDbRegistries<Persistence.Entity.xxxxx>(); services.AddLiteDbRegistries<Persistence.Entity.yyyy>();
Do note that I am still new to LiteDb and I am unsure if those should be Transient, scoped or Singleton. You're experience here might know the answer it so I will still share this unfinished idea.

Could you provide a sample of how your are fetching the ILiteCollection instance please.

Sure, take a look at https://github.com/timemaster67/LiteDbExtensionExample
on how I retrieve a ILiteCollection
basically instead of retrieving the LiteDatabase, then the collection, you directly get the collection. If you need two collection, get two dependencies in your constructor. Most of the time, you don't need the whole db in 1 class.
changes : I've renamed the AddLiteDbRegistries from the gist to AddLiteDbCollection in example to be more consistent with litedb, which I think is more important. At work we uses the repository pattern and we get our EntityRepository kind of like this. Also note that I've deleted one of the method, it was not useful once the other was done.
Again, I'm fine with keeping this small piece of code on my side if it does not fit your plan. At the time, I thought that I would make all the suggestion if I was to anyway support the case of no connection string.
And by the way thanks for the update of the library, I've pulled your latest version in my project.

Hi @timemaster67
thanks for the sample.
Personally, I think AddLiteDbCollection<>() is not ideal as it requires that AddLiteDatabase() is also called. As an implementor, I would not expect an extension method having a dependency on another extension method.
That said, AddLiteDBCollection<>() should be an extension method for AddLiteDatabase().
Something like: services.AddLiteDatabase().AddLiteDBCollection<T>().
This would require AddLiteDatabase() to return a builder instead of the service collection so that AddLiteDBCollection() can only be called on AddLiteDatabase() to make it consistent. What do you think?
Many thanks again for pointing out the issue with the ConnectionString, I hope it works out for you now.
And thanks for using my library! Let me know if you have any other suggestions or comments.
Cheers
Alexander

I did not know about the builder design pattern, it was a nice read, thanks.
I've thought about that during the week and I think I will close this issue without change. I don't see the builder design fitting when you have only one method in it (ie the new suggestion).
If we need to put time to make a builder, I would instead go to the complete/proper solution of registering my component by convention/by interface and scanning the assembly. I would inherit each of my entity inside of LiteDb with a ILiteDbEntity interface, and would create a method so that the DI container/method scan the assembly, find all the types that implement ILiteDbEntity, and register them with the ILiteCollection like I did previously in the extension method.
This extension was to keep things simple when not going overboard with the full assembly scanning. Going though the builder with only one method, does not seems that useful. I can simply call services.AddLiteDBCollection<Persistence.Entity.xxxxx>();  multiple times.
Perhaps this library configuration might have been a better fit for the builder than this AddLiteDBCollection. You expressed in my previous pull request that you wanted the core function to always be there, and it could be overwritten by other calls to add options, connection string, and etc. This seems by design compatible with a builder.
AddLiteDb()
.WithConnectionString(":memory:")
.WithConfiguration( new LiteDatabaseServiceOptions() {  // oops connection string would be overwritten with null } );
?
Anyway, I won't need this builder, so I leave you to close this issue.
I'm still open to suggestion. If you do really want a builder I can try doing one just for fun even if there is no full use case.
Thanks for you time ! :)


Synchronize Simplified Chinese and Traditional Chinese translations with the English README

I actually haven't finished this PR https://github.com/erg-lang/erg/pull/43 yet, I've marked it as a draft and you just merged it

@mtshiba

Thank you!


Running cdxgen in a virtualenv messes it up

It's really an edge case that someone will run a node project inside a python virtualenv but I happened to stumble on it anyway.
This happens because cdxgen tries to use a virtualenv if it's already there:
https://github.com/CycloneDX/cdxgen/blob/da0eff52348e706e1e3c0bd3cd32aafc515f2395/utils.js#L5457-L5461
I suppose this is built in order for the tool to reuse venv at multiple places once activated at any place. Although, if you already have a venv activated, that gets messed up.
It's not a big deal, although I believe it should be communicated somehow, so maybe

Close this issue and link from a readme or troubleshooting docs or
Check if venv starts with a tmpdir name and then only reuse it

@Hritik14 You can pass --no-install-deps to disable installation
https://github.com/CycloneDX/cdxgen#getting-help
only recently the behaviour got changed to do pip install in all venv including non temp ones for consistency.
Is an update to the readme enough or would you prefer avoiding installation for existing venvs?

@prabhu I do not want to disable installation. Disabling installation yields much lesser findings.

Is an update to the readme enough or would you prefer avoiding installation for existing venvs?

It would be nice if a check is implemented to make sure the reusable (activated or not) venv comes from cdxgen and not somewhere else

@Hritik14 It was exactly like this with a condition. Let's keep this issue open and see what others think.

Related issue #362


chore: Automated cherry pick of #752: upgrade to driver v1.0.1 release

Cherry pick of #752 on release-1.0.
#752: helm: upgrade to driver v1.0.1 release
For details on the cherry pick process, see the cherry pick requests page.

/azp run pr-e2e-azure


[ 🚧 WIP ] Fixed bug in rename.py script

Why:
Closes #5809
Same as pull request #5811
Closes #5513
Closes #5426
Closes #5253
Closes #5340
Closes #5405
Closes #5079
What's being changed:
Added a new feature to check for duplicate files in a program folder and added an option for the organizer to delete the duplicate file if he wishes to.
As you can see in this image there is a duplicate file named simply.cpp

After running the rename.py script, The terminal looks like this:

After confirming to delete the duplicate file

The file gets deleted :)

Contributed by:
Kartikeya Saini

Thanks for the solution with the explanation 👍🏻
This is very helpful as if the original files get deleted and the newly created file will exist then the original contributor will not get the credit as we are using files to fetch contributors.
Thanks a lot 🤗

This PR will be merged shortly

Hi @harshraj8843,
Can you test it out and let me know if it's meeting the requirement? Glad to contribute :)

@hi-Kartik2004 will test ASAP 👍🏻

Works perfectly 👍🏻


Develop DOD process for Design Guide

Resolve checklists git issues vs tickets

Reviews
Code
Content
Design
Ally

@gazhands @joolswood Do we have these added to .github/ folder as template files yet? :)

@dominikwilkowski Hey, we should finish this as I think it might help us work better. (:

My bad, I just haven't got back to this. Happy to draft something, or work with you fine people.

@joolswood let’s just get a PR up together when you’re back — it’ll take us all of 5mins.

I’ve added PRs for both — see above. Please review. (:


Slider handler component displayed behind slider-track

The handler of the slider is displayed behind the slider track component it should be the other way around (handler always on the front)

Note: They have the same background color so is hard to see on the screen

Could you please assign me this?

@hugonxc  no need to assing`, just leave a comment that you are working on it ^^

Awesome... so I'm working on.

Not sure if this was introduced on: https://github.com/btzr-io/Villain/commit/36190013de45acecaf4a807788d9045f36cd3ea4, but it maybe good to look at it.
Let me know if you have any questions :v:

@btzr-io I think this issue is already solved by the commit you tagged.

@hugonxc  please read the note: mentioned on the issue description

Note: They have the same background color so is hard to see on the screen

you will need to change the colors to see  the bug.


[Enhancement]: Conditionally register @TestContainers

Module
Core
Proposal
The TestcontainersExtension class is currently not public. Because of this, there is no way to conditionally apply the extension.
Consider this example
abstract class MyBaseTest {
    companion object {
        @JvmField
        @RegisterExtension
        val someExtension = if (someCondition) {
            TestcontainersExtension()
        } else {
            DoNothingExtension()
        }
    }
}

follow https://github.com/testcontainers/testcontainers-java/issues/2045


grpc: Unavailable response when gRPC server run in Docker

My code (written in Go, which just creates a Bucket via gRPC) succeeds when the storage_testbench server is run directly in a virtualenv, but fails when the server is running inside of a Docker container. The error reads rpc error: code = Unavailable desc = connection closed before server preface received.
The container was started with the following command:
docker run --name storage_testbench --rm -d -p 9000:9000 -p 8888:8888 gcr.io/cloud-devrel-public-resources/storage-testbench
The gRPC server was started with the following command:
curl -s "http://localhost:9000/start_grpc?port=8888"

docker ps produces the following:
CONTAINER ID   IMAGE                                                    COMMAND                  CREATED         STATUS        PORTS                                            NAMES
2759b71c6cff   gcr.io/cloud-devrel-public-resources/storage-testbench   "gunicorn --bind 0.0…"   2 seconds ago   Up 1 second   <IP_ADDRESS>:8888->8888/tcp, <IP_ADDRESS>:9000->9000/tcp   storage_testbench

Worth noting, I am testing on macOS

After a bit of diagnostics on a linux host I've found the following:
Run the image
docker run -it --rm --net=host gcr.io/cloud-devrel-public-resources/storage-testbench:v0.15.0

Start grpc
curl http://localhost:9000/start_grpc?port=9001

List bound ports:
$ sudo netstat -ntplv | grep '900'
tcp        0      0 <IP_ADDRESS>:9000            <IP_ADDRESS>:*               LISTEN      4008468/python3
tcp6       0      0 ::1:9001                :::*                    LISTEN      4008484/python3
tcp6       0      0 <IP_ADDRESS>:9001          :::*                    LISTEN      4008484/python3

The grpc server being started by gunicorn is only listening on localhost. We'll need to figure out some way to get it to use the same interface it's started with via --bind so that the server will be accessible from the Docker bridge network.

Maybe we should just replace localhost here:
https://github.com/googleapis/storage-testbench/blob/a5217169b6738b1b66712168d08be9200094134a/testbench/grpc_server.py#L697
With the wildcard address [::]:%d' % port


Multiplayer instability Soul Hex

The ability Soul Hex from the warlock subclass Soulblade will always fail to apply the proficiency to damage for both clients in a multiplayer game leading to consistent instabilities.
Not sure if this is fixable, but I will try to upload a good save where this can be consistently reproduced next time I play a multiplayer session with my friend. Just wanted to give a headsup in case it can be easily detected in the code.

Save please

Followup: Quick saving -> Load makes both client ignore Soul Hex now. Janky

fixed the health piece.


Fix subclasses of string. (Fixes #130)

Codecov Report

Merging #674 into master will decrease coverage by 0.01%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   40.17%   40.15%   -0.02%
==========================================
  Files          79       79
  Lines       17453    17457       +4
  Branches     4467     4468       +1
==========================================
- Hits         7011     7010       -1
- Misses       8610     8613       +3
- Partials     1832     1834       +2

Impacted Files
Coverage Δ

vm/src/obj/objstr.rs
34.63% <56.25%> (-0.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcea92...40081e0. Read the comment docs.

The remaining discussions are beyond the scope of this PR, so I think this should be ok to merge?


fix miri errors

Miri checks fail due to errors in main

BoolIterator seems to be the only issue that caused miri to fail. I have added an issue to remove the dead code flag: https://github.com/private-attribution/ipa/issues/1126.


Changed MaterialDesignCheckBox default VerticalContentAlignment to "Center"

This makes it look aligned with any font size

Thanks!


Support pauseProperties with null values

What does this PR do?
Adds support for pauseProperties with null values. This is useful for pausing the cluster until a value has been set.
What is the effect of this change to users?
How does it look like?
(Please add anything that represents the change visually. Screenshots, output, logs, ...)
Any background context you can provide?
Ref: https://gigantic.slack.com/archives/C0559SH3RJ4/p1721749122430959
What is needed from the reviewers?
Do the docs need to be updated?
Should this change be mentioned in the release notes?

[x] CHANGELOG.md has been updated (if it exists)

I have tested this using this PR and it functions exactly as expected. When the host value is null then the Cluster is paused, and when the host value contains an IP then the cluster is unpaused.


refactor HistoryTest.cpp to test the history using HistoryViewModel

Fixes #783
Description of the changes:

Modify HistoryTest.cpp to use HistoryViewModel instead of CalculatorHistory. in order to test the full stack and not only the CalcManager part.

⚠ one of the big difference is how the history items collection is ordered.

Also:

Expose some methods from CalcManager (a native library) via StandardCalcViewModel, making them accessible from another windows runtime library.
make PropertyNames public instead of internal so other (dynamic) libraries can use them.
move Utils::GetStringValue from CalcViewModel to CalculatorUnitTests

How changes were validated:

Manually

!rebased


Linux kernel elimination

There is the possibility of eliminating the linux kernel in the future? it seems more complicated than help in several cases also slows the installation. look this: Python without an operating system http://lwn.net/SubscriberLink/641244/5d1d6d20aeb0a647/

Thank you, but no. Why you think it's more complicated? What alternatives are you thinking about?
Probably what you are looking for is runtime.js, an OS kernel written in Javascript. NodeOS is mostly kernel agnostic and I was thinking about doing a FreeBSD port just for the sake of it, so probably in the future we use runtime.js as the default kernel of NodeOS and make use of its advantages.
The link that you posted is interesting (and the fact that they were doing the demo directly on BITS by using the EFI Graphics Protocol is really cool :-D ), but they haven't done anything that has been done before, only paste the CPython code to the GRUB2 code and add some glue code. They could have been able to do the same by using directly CPython and NewLib so it could run baremetal (I did something similar in the past using PyMite instead, but today I would use MicroPython instead). This could be done with NodeOS too, but you missed one important point: drivers. Linux provides drivers for almost all hardware available today, and it's frequently updated. By using a raw system like runtime.js, you need to write drivers for everything, that's definitely not something easy to do...

Thx piranna.