allow dashes in date and more

yt-dlp allows one to modify the upload date using %(upload_date>%Y-%m-%d)s
but youtube-dl only allows %(upload_date)s
e.g., 2022-01-01 vs 20220101
I use these interchangeably because sometimes yt-dlp doesn't properly convert some files so I have to use youtube-dl. I use it in automation so having the date format mismatch is unpleasant.  yt-dlp allows for more configuration along these longs across the board. Maybe could copy and paste the code from it?

But if you stuck to %(upload_date)s it would work for both ...

But if you stuck to %(upload_date)s it would work for both ...

But if the code was updated to be more congruent to reality it would work for both too.

I don't really care for OPs tone, but it seems they are right. According to RFC 3339 [1], the dashes are required:
2006-01-02T15:04:05Z07:00

https://datatracker.ietf.org/doc/html/rfc3339

According to RFC 3339 [1], the dashes are required:

youtube-dl has never claimed upload_date to be RFC 3339 compliant. What it does claim is that it will be in YYYYMMDD format. It would be a compatibility nightmare to change this.
It would technically be possible to create a new field for this, but then the same has to be done for release_date, and maybe even timestamp/release_timestamp. This is not to even mention the problem that people will keep asking for other formats

youtube-dl has never claimed upload_date to be RFC 3339 compliant. What it does claim is that it will be in YYYYMMDD format. It would be a compatibility nightmare to change this.

Instead of choosing a standardized format, YouTube-DL choose some random format. The format has some good properties, in that its less bytes, and still sortable. Regardless OP has a case here. RFC 3339 should be, if not the default format, one of the possible formats.

It would technically be possible to create a new field for this, but then the same has to be done for release_date, and maybe even timestamp/release_timestamp.

Nothing "has to be done", ever. Thing only need to be done when people decide they are important to do. For OP, the only thing they care about is upload_date. The YouTube-DL maintainer, can make their own decision as to how far down the rabbit hole they want to go.

This is not to even mention the problem that people will keep asking for other formats

Straw man. We are not talking about some random format (which ironically is whats being used now). We are talking about a format that has existed since the 1980s, arguably the most common date format in existence.

The reason for the existing format is doubtless that YT sends the value like that. yt-dl carried it over to all supported sites.
If a change were to be made it would be in the direction originally suggested by OP, and not by changing the structure to '-'.join([x[:4], x[4:6], x[6:]]), because of the "compatibility nightmare". But not in the immediate, or even foreseeable, future.
An upload_date_with_dashes metadata item, while simple to implement, wouldn't solve OP's problem (and would also be a bad idea).

I don't really care for OPs tone, but it seems they are right. According to RFC 3339 [1], the dashes are required:

My tone? You haven't seen nothing yet! There is nothing in my tone in my OP.   Oh sure, you'll be protected for the sociopath you are but that's ok.   You could have just ignored it if you thought it was offensive rather than being antagonistic. The only difference is I make it explicit and put you in your place and know I will be punished for it because I'll be damned if I let you lunatics get away with your BS... of course you will but at least it wasn't a walk in the park]

The reason for the existing format is doubtless that YT sends the value like that. yt-dl carried it over to all supported sites.
If a change were to be made it would be in the direction originally suggested by OP, and not by changing the structure to '-'.join([x[:4], x[4:6], x[6:]]), because of the "compatibility nightmare". But not in the immediate, or even foreseeable, future.
An upload_date_with_dashes metadata item, while simple to implement, wouldn't solve OP's problem (and would also be a bad idea).

No one is asking for the format to be forced upon people. The entire point is that yt-dl lets one configure the output. There is no way to configure it with youtube-dl. Why force people to choose one or the other? Why not give them the option? It's a few lines of code and surely there will be more than one person that will find it useful. It's moronic(yes, it is... at the very least it is authoritative) to claim that "YOU HAVE TO DO IT MY WAY" when everyone can be made happy and the best of both worlds can be achieved with only a few lines of code. It's not like one has to spend 3 years writing a million lines of code to allow make it happen and I'm not asking for it to override current behavior.

 Oh sure, you'll be protected for the sociopath you are but that's ok.

Hoo boy. I was the one person defending you in this thread. While I agreed with your underlying proposal, you presented in a rude fashion. This isn't a deal-breaker per se, but since you aren't a maintainer, its probably a good idea to be nice to the people that you want to change something.
However its become very clear that you aren't interested to do that. Good luck to you.


Do not autoclose $ after an escaping slash

Currently the autoclosing pairs in the VSCode language configuration lists $ and $. This is slightly annoying when dealing with money. Is this possible with the language configuration alone? A quick glance at the documentation suggests that it is unlikely. We might perhaps achieve this by hacking the notIn option, putting the character behind a backslash in a comment region.
Another way might be to declare "\$" and "" as an autoclosing pair. I haven't tested whether it works, but it does behave correctly when dealing with \( and ( simultaneously in TeX language configurations, so maybe it's worth a try.

It is not possible to get fixed easily in language configuration.
To fix it, we can remove the auto-closing $ pair from language configuration and handle it by some customized handler, like https://github.com/CFiggers/typst-companion/blob/main/src/listEditing.ts.


Add support for native Bicep parameter files

Bicep parameter files are soon to be released. We need to update the functionality in PSBicep to generate bicep parameter files instead of ARM parameter files. We need to discuss how we should do this.
Thoughts:

We should implement functionality to generate bicep param files and set this as the default behavior for all ways we can generate param files with PSBicep(New-BicepParameterFile, Build-Bicep). It should still be possible to generate an ARM parameter file.
Update-BicepParameterFile should support both formats.

We should add this to BicepNet using the same logic as bicep generate-params

Closes as this was implemented in Build-BicepParam a long time ago


Revert "Fix for RUBOCOP_CONFIG environment variable"

Reverts prontolabs/pronto-rubocop#72

@ashkulz Thank you!!! Will you release a new version of the gem that has this fix soon? That would be super helpful.

@keithrbennett I've done that, had to figure out what was causing the tests to fail.


[SW-1002] add back arrow icon to "back to main accounts" button

Yeah, last commit should be removed.


Please confirm these before moving forward

[x] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[x] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installer hash mismatch.
Brief description of your issue
Installer hash does not match with the hash that's defined in the package manifest.
The manifest file includes the following info:
PackageVersion: 2.138.1203.0
InstallerSha256: 4EEDE896947E13029EE3E3CA8CE8DDC53B7673DAA2436102DF45C3F98E35CB52
InstallerUrl: https://download.microsoft.com/download/8/8/0/880BCA75-79DD-466A-927D-1ABF1F5454B0/PBIDesktopSetup-2024-11_x64.exe
When manually downloading the installation file from the InstallerUrl URL the actual version and hash of the installer are as follows:
PackageVersion: 2.138.1452.0
InstallerSha256: fd9f842844a26b4ea87b63eb4e0fcc11613be5bc52e2b9e0c1c8f67d43fc2e46
Link to package manifest: https://github.com/microsoft/winget-pkgs/blob/master/manifests/m/Microsoft/PowerBI/2.138.1203.0/Microsoft.PowerBI.installer.yaml
Steps to reproduce
Install the latest version of Power BI with the command winget install Microsoft.PowerBI --accept-package-agreements --accept-source-agreements.
Actual behavior
Installation fails with the error "Installer hash does not match.".
Expected behavior
Successful installation.
Environment
Windows Package Manager v1.9.25200
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.4460
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.25200.0

Screenshots and Logs
PS C:\> winget install Microsoft.PowerBI --accept-package-agreements --accept-source-agreements
Found Microsoft PowerBI Desktop [Microsoft.PowerBI] Version 2.138.1203.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Agreements for Microsoft PowerBI Desktop [Microsoft.PowerBI] Version 2.138.1203.0
Version: 2.138.1203.0
Publisher: Microsoft Corporation
Publisher Url: https://www.microsoft.com/
Publisher Support Url: https://support.fabric.microsoft.com/support/
Author: Microsoft Corporation
Homepage: https://www.microsoft.com/power-platform/products/power-bi/
License: Proprietary
License Url: https://powerbi.microsoft.com/desktop-eula/
Privacy Url: https://privacy.microsoft.com/privacystatement
Copyright: Copyright (c) Microsoft Corporation. All rights reserved.
Copyright Url: https://www.microsoft.com/legal/intellectualproperty/trademarks
Purchase Url: https://www.microsoft.com/power-platform/products/power-bi/pricing
Agreements:
  Microsoft Software License Terms: https://powerbi.microsoft.com/desktop-eula/

Downloading https://download.microsoft.com/download/8/8/0/880BCA75-79DD-466A-927D-1ABF1F5454B0/PBIDesktopSetup-2024-11_x64.exe
  ██████████████████████████████   544 MB /  544 MB
Installer hash does not match.

Note
It's currently in progress ❤.
* Will be resolved by [@SpecterShell](https://github.com/SpecterShell) in [New version: Microsoft.PowerBI version 2.138.1452.0 #197516](https://github.com/microsoft/winget-pkgs/pull/197516)

That's great to hear. Thank you. I didn't know to look for that pull request.


Exception: Request Failed

Hi!
First thank you very much for the tutorial, it is great to have something super clear!
I tested the process from the beginning, I was able to process all the steps until the login (number 11.) When I try to login, I get the following mistake, any idea how to resolve it?
Exception: Request failed for https://www.salesforce.com/services/Soap/u/22.0 returned code 500. Truncated server response: <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:sf="urn:fault.partner.soap.... (use muteHttpExceptions option to examine full response)
Thank you,
Luca

This exception can happen for various reasons. So you need to look at the fault message from the SOAP Envelope. Firstly, add this "parameters.muteHttpExceptions = true" in the method login, after creating the var parameter.
Secondly run only the login function(select function) from the script editor in debug mode. After catching the exception in the lines "Logger.log(e);" search for the "real" Exception message in the debug window.
soapResult =>Envelope => Body => Fault => FaultString for example. Here you can find out what the real problem is.


Connection pool

Hi
Just wondering if it's necessary to use connection pooling within the code?
Is it possible to provide a setting to disable connection pooling so one can use another service for this (eg. Pgbouncer)?
Kind regards
Xander

It was necessary because It was used to reduce the overhead of connecting to the Database by reusing freed-up connections
But at the moment it isn't because I started closing the connections immediately to fix a bug (Due to the way Django's Async works).
For now, It should be okay to use an external connection pool because connections are closed and reopened every time and it behaves like there's no DB pool.
The code is still there because I plan to introduce a setting to control it.
See this MR for more info: https://github.com/danidee10/channels_postgres/pull/18

Also, note that PgBouncer will not allow you to Scale and handle more NOTIFY/LISTEN connections (If that's what you had in mind) because NOTIFY/LISTEN is only supported for Session pooling Not Transaction pooling.
NOTIFY/LISTEN requires a Persistent connection
https://www.pgbouncer.org/features.html
It's on the Roadmap but it's not Implemented yet: https://github.com/pgbouncer/pgbouncer/issues/655


Bot Requests DB Before Users Put Tokens

In main.js, we are calling db.fetchGit to fetch a GitHub token for users who run -github-info. This causes problems to new users who do not yet have a token, which would cause errors like this
TypeError: Cannot read property 'token' of undefined
    at /home/damir/Git/pod-3.1.3-team-4/database.js:49:25
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async fetchGitHubToken (/home/damir/Git/pod-3.1.3-team-4/database.js:44:12)
    at async Object.fetchGit (/home/damir/Git/pod-3.1.3-team-4/database.js:4:20)
Message is: -github-info new_token
Command is: github-info

I will put the github-info command in the exceptions in main.js among lighthouse, tech-stack, and help so that the bot wouldn't fetch tokens for those who are just trying to set it up.

Closed as of #81.


Postgres UUID columns not working?

Hi,
Thank for continuing development of Flask-Security: appreciated :-)
I tried to use Flask-Security-Too as a 'drop in' replacement. Forms, templates etc. work, but I think I am running into a problem with postgres UUID fields.
User model:
from sqlalchemy.dialects.postgresql import UUID

class User(db.Model, UserMixin):
    __tablename__ = 'user'
    id = Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4, index=True)
    email = Column(String(255), unique=True)
    first_name = Column(String(255), index=True)
    last_name = Column(String(255), index=True)
    username = Column(String(255), unique=True)
    password = Column(String(255))
    active = Column(Boolean())
    created_at = Column(DateTime, default=datetime.datetime.utcnow)
    confirmed_at = Column(DateTime())
    roles = relationship('Role', secondary='roles_users', backref=backref('users', lazy='dynamic'))

Console:
sqlalchemy.exc.DataError: (psycopg2.DataError) invalid input syntax for uuid<EMAIL_ADDRESS>Looks as it doesn't see the UUID pk field correctly?
Configuration:
https://github.com/acidjunk/improviser/blob/flask-security-too/improviser/main.py
Travis CI:
https://travis-ci.com/acidjunk/improviser/jobs/222120290
Or do I miss some new configuration stuff, somewhere?

Thanks for the report - this is an area I spent a bunch of time on - there were many old issues around querying for different keys - along with the fact that psycopg2 is very picky about type mismatches. So I know just where to start looking :-)

Hi Chris,
I can confirm that the login etc. now works as advertised when I pull it from master branch with commit SHA: 560a401
Small/Offtopic but, not sure if this is intended: Commit 33e7c4f breaks it, at least for my app:
from flask_security.decorators import _get_unauthorized_response
I will probably fix this on my side as it seems a bit hacky to rely on _get_unauthorized_response
Thanks for the quick fix :)

Glad that is fixed.
That fix is available now on pypi as 3.3.0rc2
As for breaking - hmm - I usually consider _xxx as private - I changed the name as part of overhauling handling of authentication/authorization failures - which were sort of mushed together (please read the CHANGES since there is a backward incompatability change).
Note also that I have now made sure that ALL public/documented methods etc are exposed from the flask_security module - so you shouldn't have to import ANYTHING from flask_security.xyz. If you find some things you are using that aren't exposed or have '_' that you think SHOULD be useful public APIs - please let me know.


Single GPU training

hi, thanks for sharing your model, is it possible to train this model on custom dataset with single GPU?, whenever i try to do that, getting this error(im using tools/train.py script):
Traceback (most recent call last):   File "CBNetV2/tools/train.py", line 188, in <module>     main()   File "CBNetV2/tools/train.py", line 184, in main     meta=meta)   File "/content/CBNetV2/mmdet/apis/train.py", line 185, in train_detector     runner.run(data_loaders, cfg.workflow)   File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 127, in run     epoch_runner(data_loaders[i], **kwargs)   File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 50, in train     self.run_iter(data_batch, train_mode=True, **kwargs)   File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 30, in run_iter     **kwargs)   File "/usr/local/lib/python3.7/dist-packages/mmcv/parallel/data_parallel.py", line 67, in train_step     return self.module.train_step(*inputs[0], **kwargs[0])   File "/content/CBNetV2/mmdet/models/detectors/base.py", line 237, in train_step     losses = self(**data)   File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 1051, in _call_impl     return forward_call(*input, **kwargs)   File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/fp16_utils.py", line 128, in new_func     output = old_func(*new_args, **new_kwargs)   File "/content/CBNetV2/mmdet/models/detectors/base.py", line 171, in forward     return self.forward_train(img, img_metas, **kwargs)   File "/content/CBNetV2/mmdet/models/detectors/two_stage.py", line 266, in forward_train     **kwargs)   File "/content/CBNetV2/mmdet/models/roi_heads/cascade_roi_head.py", line 248, in forward_train     rcnn_train_cfg)   File "/content/CBNetV2/mmdet/models/roi_heads/cascade_roi_head.py", line 146, in _bbox_forward_train     bbox_results = self._bbox_forward(stage, x, rois)   File "/content/CBNetV2/mmdet/models/roi_heads/cascade_roi_head.py", line 136, in _bbox_forward     cls_score, bbox_pred = bbox_head(bbox_feats)   File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 1051, in _call_impl     return forward_call(*input, **kwargs)   File "/content/CBNetV2/mmdet/models/roi_heads/bbox_heads/convfc_bbox_head.py", line 155, in forward     x = conv(x)   File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 1051, in _call_impl     return forward_call(*input, **kwargs)   File "/usr/local/lib/python3.7/dist-packages/mmcv/cnn/bricks/conv_module.py", line 201, in forward     x = self.norm(x)   File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 1051, in _call_impl     return forward_call(*input, **kwargs)   File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/batchnorm.py", line 731, in forward     world_size = torch.distributed.get_world_size(process_group)   File "/usr/local/lib/python3.7/dist-packages/torch/distributed/distributed_c10d.py", line 748, in get_world_size     return _get_group_size(group)   File "/usr/local/lib/python3.7/dist-packages/torch/distributed/distributed_c10d.py", line 274, in _get_group_size     default_pg = _get_default_group()   File "/usr/local/lib/python3.7/dist-packages/torch/distributed/distributed_c10d.py", line 358, in _get_default_group     raise RuntimeError("Default process group has not been initialized, " RuntimeError: Default process group has not been initialized, please make sure to call init_process_group.

I removed automatic mixed precision by changing runner to epochbasedrunner  then it works fine for me .


inputsourceschange event support

From #37. This PR adds inputsourceschange event support. The algorithm is based on https://github.com/immersive-web/webxr-polyfill/issues/37#issuecomment-531427849

Oops, seems like I did misoperation. I'll create a new one.


 In addition, it has some
problems. For example, it doesnt even recognize underscore in integer literals.
Here is an alternative that is popular and up to date:
https://github.com/fatih/vim-go

are you really saying that once a file is put here:
https://github.com/vim/vim/tree/master/runtime/syntax
that it must stay forever and never be changed?

No, that's not at all what's being stated.  Your suggestion is understood, but that's not how runtime updates work.
When a runtime file maintainer has updated their file(s) and considers the updates ready to be in Vim proper, then they push the updated file(s) to Bram for inclusion.
It's not up to Bram to poll every maintainer to see if they have updates.  There are over 300 syntax files.  That doesn't scale well.

Explicit permission from the maintainer is required for inclusion.
And the files should be sent to Bram from the maintainer (via an email or a PR).
Please ask the maintainer about them.


Using DeferredLayer along with MarkerClusterGroup plugin issue

Hi,
I am trying to use Deferred Layer plugin along with MarkerClusterGroup plugin.
https://github.com/Leaflet/Leaflet.markercluster
I made a jsfiddle case to illustrate the issue, you can check it here.
http://jsfiddle.net/wSytj/156/
The problem is that I get this error message in the console.
Uncaught Map has no maxZoom specified
This error is thrown by the Clustering plugin when it is trying to get the MaxZoom of the map. I guess it is thrown because Google API will be not fully loaded yet.
Here is the code where the problem occurs.
if (!isFinite(this._map.getMaxZoom())) {
	throw "Map has no maxZoom specified";
}

You can check it in their repository here: https://github.com/Leaflet/Leaflet.markercluster/blob/master/src/MarkerClusterGroup.js#L495
I wonder if you ever used the Deferred loading with Clustering, or may I missed something in my code.
I will be very grateful if you take a look at this issue.

Sorry but i've never used deferred script :\ Since clusterer plugin needs a maxzoom, adding at least one layer without deferrer should fix the bug.

Adding a default maxZoom to the map itself solved the issue, thank you :)

you're welcome :)


App doesn't load on actual device

App working (c1f0c8f6e8c51b3ad8e3dff1421277e7c9a96ca0) on emulator and webpage but not on @hacaravan actual device.

App loads on physical devices.


sending Email

how i can use it for send email for other server like @gmail.com

If you mean you want to use this library to send an email from Go code, that's not what it does - it receives emails. It does not send them. If you just want to send emails, have a read of the Go SendMail function documentation.
If you want to use this library to create your own mail forwarder program, have a look at my Mailrouter project for an example of how to do it.


I127 create a button to redirect to visit add page in the home page

Change Summary

Added button to redirect to add visit page
Removed unused components

Change Form

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
Requires #103 to be merged first as it uses visit/set page
Related Issue

Resolve #127

Something is broken in the visit page

Something is broken in the visit page

Branch needs to pull from #119 as it has a fix for crashing when fields are undefined. The duration field does not exist in the db for old data as main currently stores endTime instead

Is this PR still being worked on?

No, the PR is ready to be reviewed

@NicholasChoong the issues are fixed :) pls let me merge


should use encode() to get hidden_emb

I found that in train.py mu.data.numpy() is used to get hidden_emb, but it would get None when using GCNModelAE as model, hidden_emb should be got from model.encode() instead.

In the model.py, mu, logvar = self.encode(x, adj), after defined recovered, mu, logvar = model(features, adj_norm) in train.py, you can easily get embedding with mu.data.numpy().


NETOBSERV-771 POC Location map

Description
Add location map

Dependencies
https://github.com/netobserv/network-observability-operator/pull/712
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[X] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[X] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Closing that PR for now as the FLP coordinate correlation is not satisfying as is.


[ALGO/DS] Name : Data Structures Algorithms

Algorithm:

[x] HashMap
[x] Doubly Linked List
[x] Queues
DS:

Languages Supported:

[x] Javascript

I want to work on Queues. Can I be assigned with this issue?

@Jyotika999 Sure. I hope you have gone through, https://github.com/TesseractCoding/NeoAlgo#contributing-guidelines

Yes Sir

Can I work in C language?

Can I work on HashMap
Doubly Linked List
Queues In Javascript?

Can I work in C language?

@Jyotika999 Queue implementation is already been done in C.

@iamrajiv Can you assign me for
HashMap
Doubly Linked List
Queues In Javascript?

@howdyAnkit  Queue implementation is already been done in JavaScript, you can work on the implementation of HashMap and Doubly Linked List in  JavaScript.

Can you assign me the same? @iamrajiv

Please assign me the doubly linked lists in C

I want to take up this issue.
Sorting Algorithm

Insertion Sort
2.Selection Sort
3.Bubble Sort

Language Supported: JAVA
I have read all the contributing guidelines. Please assign this task.


Added fastobo to implement file conversions

Addresses #1

[x] Added fastobo asa dependency
[x]  Implemented fastobo for file conversions

Work halted because of: https://github.com/fastobo/fastobo-py/issues/342


How to pause/resume job?

how to do?

When your job has been started , you can pause/restart the job.It likes below.


A possible bug in HypreParMatrix::LeftDiagMult

In the function HypreParMatrix::LeftDiagMult(const SparseMatrix &D, HYPRE_Int* row_starts), the output HypreParMatrix will use the same 'RowStarts' array of this if the number of rows of the input matrix D and the number of rows of this are the same. This makes sense because this somehow means the row and column 'starts' of D (if we think of it as a HypreParMatrix) are the same.
However, the function checks the above condition by checking the local number of rows only:
const bool same_rows = (D.Height() == hypre_CSRMatrixNumRows(A->diag));
If this is true in some processors, but not the others, then different processors will use different definitions for row_starts and global_num_rows, which may result in some mismatch (even if row_starts is not NULL).
This can happen if globally D is a rectangular matrix, but locally it is a square matrix in some processor (although this may be rare, I have encountered this situation).
To fix the issue, I think either do a 'MPI_LAND' to same_rows or change the if statement
if (same_rows) to if (same_rows && !row_starts)

Hi Chak,
I see your point, and I think we should fix this.
I suggest the following simple logic to keep this method communication-free:

If row_starts == NULL, each processor checks that D is square and has the right size and uses the row starts of this as row starts for the new matrix. Here, it is natural to assume that row_starts == NULL returns the same result on every processor.
If row_starts != NULL, check if row_starts is the same pointer as the row starts pointer for this (this condition should give the same result on all processors unless row_starts or the row starts of this are created in some non-standard way); if the pointers are the same, then treat this case as the case when row_starts == NULL. If the pointers are different, then treat this as the general rectangular case: check that the dimensions of D are correct and use row_starts as the row starts for the new matrix and the column starts of this as the column starts for the new matrix.

What do you think about this solution?

Hi Veselin,
Yes, your suggestion makes a lot of sense to me, and it's nice that it does not require communication.

Resolved by 3c6b857e768fe9b42e13fd7c42ca0f0c4e8297e0.


[Level Up - Advanced 5th Edition] New Features - Advantage/DisAdvantage

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[X] I have followed the Character Sheets Standards when building this sheet.

[X] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

**2022-05-04 ** v.12 Paul V
Major changes to the Skills rolls added a skill settings window for each skill. moved Expertise dice on to that window
Added a whole swave of modifiers to the rolls
Moved Jack of all trades into the Global skill settings window
Moves all Expertise Dice and Proficient into the skill specific setting windows
Added Standard / Advantage / Disadvantage buttons on to the sheet allowing to rolls with advantage or disadvantage

Character Sheet Info Roll20 Internal Use only.


Examples use graphics commands that don't output anything to PyFluent user executing them

See https://github.com/ansys/pyfluent/pull/2102#discussion_r1363879683 and discussion
Other examples that do this:
https://fluent.docs.pyansys.com/version/stable/examples/00-fluent/exhaust_system.html#create-contours-of-velocity-magnitude
https://fluent.docs.pyansys.com/version/stable/examples/00-fluent/mixing_elbow.html#create-definition-for-velocity-magnitude-contours
https://fluent.docs.pyansys.com/version/stable/examples/00-fluent/mixing_elbow_settings_api.html#create-velocity-vectors

Yeah that's a fair point.  We could include the equivalent commands in these examples to generate the required static images.

An example of how this can be unintuitive to customers: https://github.com/ansys/pyfluent/discussions/2297#discussioncomment-7838251
@ansjsia

@dnwillia @raph-luc Perhaps as part of the 24R1 example upgrades, we should add commands to save images to disk after calling display() for examples that don't use PyFluent Visualization, as I did for the species transport example: https://github.com/ansys/pyfluent-examples/pull/100
I'm happy to take the lead on making the required changes.

Sounds like a big improvement to me. Ideally, in the long term, we'd have a method to stream the image data from the server directly to a Python display window without having to write to disk, but what you suggest is much better than not showing anything to the user.
Thanks @ansjsia!

@raph-luc I imagine that would involve more integration with PyVista/PyFluent Visualization?

Ideally, yes


Tooltip click and long hover interaction

🐛 Bug Report
While testing ActionGroup, the with tooltip story I noticed that clicking on a button a leaving the hover seems to keep the timer running because I move the mouse pointer away from hover and back over the button quickly and the tooltip immediately pops up.
🤔 Expected Behavior
After clicking the tooltip doesn't open.
Quickly mousing away and hovering again should start the tooltip show timer.
😯 Current Behavior
Tooltip immediately shows up if there was a long hover after clicking.
💁 Possible Solution
Wondering if the timer is running even when the tooltip shouldn't show.
🌍 Your Environment

Software
Version(s)

react-spectrum
master branch pr build

Browser
Firefox

Operating System
OSX

🧢 Your Company/Team
RSP

Can I start working on this as my first PR ?

Please do! Here's the guide for contributions https://react-spectrum.adobe.com/contribute.html

I cannot reproduce on the latest, appears to have been fixed. https://codesandbox.io/p/sandbox/awesome-liskov-h3x38k


Mongodb: sync_rules with parameters not working

Hello & thank all of you powersync team!
I'm testing PowerSync with MongoDB &
I've encountered an issue where sync rules don’t seem to work as expected when adding parameters.
Here’s a quick summary
Working Example
bucket_definitions:

  user_data_bucket:

    data:
      - SELECT _id as id, * FROM messages

Not Working with Parameters

bucket_definitions:
  user_data_bucket:
    accept_potentially_dangerous_queries: true
    parameters:
      - SELECT request.user_id() as user_id
    data:
      - SELECT _id as id, * FROM messages WHERE user = bucket.user_id

Logs
I got fatal errors Failed to update sync rules from configuration keyword not supported here
powersync-1      | {"errors":[{"location":{"end":797,"start":793},"source":{"location":{"end":44,"start":40},"sql":"SELECT _id as id, * FROM messages WHERE user = bucket.user_id","type":"fatal"},"type":"fatal"}],"level":"error","message":"Failed to update sync rules from configuration keyword not supported here","name":"Replicator:mongodb-database-test","stack":"Error: keyword not supported here\n    at SqlSyncRules.throwOnError (file:///app/packages/sync-rules/dist/SqlSyncRules.js:138:19)\n    at SqlSyncRules.fromYaml (file:///app/packages/sync-rules/dist/SqlSyncRules.js:132:19)\n    at MongoBucketStorage.updateSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:120:37)\n    at MongoBucketStorage.configureSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:74:53)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async ChangeStreamReplicator.runLoop (file:///app/packages/service-core/dist/replication/AbstractReplicator.js:113:34)","timestamp":"2024-11-05T13:08:08.845Z"}

Rest of logs
powersync-1      | {"level":"info","message":"Configuring telemetry.","timestamp":"2024-11-05T13:08:08.824Z"}
powersync-1      | {"level":"info","message":"Attention:\nPowerSync collects completely anonymous telemetry regarding usage.\nThis information is used to shape our roadmap to better serve our customers.\nYou can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:\nhttps://docs.powersync.com/self-hosting/telemetry\nAnonymous telemetry is currently: enabled","timestamp":"2024-11-05T13:08:08.824Z"}
powersync-1      | {"level":"info","message":"Sharing anonymous telemetry","timestamp":"2024-11-05T13:08:08.824Z"}
powersync-1      | {"level":"info","message":"Telemetry configuration complete.","timestamp":"2024-11-05T13:08:08.827Z"}
powersync-1      | {"level":"info","message":"service started","timestamp":"2024-11-05T13:08:08.828Z"}
powersync-1      | {"level":"info","message":"Sync rules updated from configuration","timestamp":"2024-11-05T13:08:08.829Z"}
powersync-1      | {"errors":[{"location":{"end":797,"start":793},"source":{"location":{"end":44,"start":40},"sql":"SELECT _id as id, * FROM messages WHERE user = bucket.user_id","type":"fatal"},"type":"fatal"}],"level":"error","message":"Failed to update sync rules from configuration keyword not supported here","name":"Replicator:mongodb-database-test","stack":"Error: keyword not supported here\n    at SqlSyncRules.throwOnError (file:///app/packages/sync-rules/dist/SqlSyncRules.js:138:19)\n    at SqlSyncRules.fromYaml (file:///app/packages/sync-rules/dist/SqlSyncRules.js:132:19)\n    at MongoBucketStorage.updateSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:120:37)\n    at MongoBucketStorage.configureSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:74:53)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async ChangeStreamReplicator.runLoop (file:///app/packages/service-core/dist/replication/AbstractReplicator.js:113:34)","timestamp":"2024-11-05T13:08:08.845Z"}
powersync-1      | {"level":"info","message":"Initial replication already done","timestamp":"2024-11-05T13:08:08.860Z"}
powersync-1      | {"level":"info","message":"Resume streaming at new Timestamp({ t:<PHONE_NUMBER>, i: 4003 }) / 672a16c200000fa3","timestamp":"2024-11-05T13:08:08.866Z"}

Hey @amjadbouhouch, could you try messages.user instead of user?

hey @Chriztiaan  and thanks for your quick response!
I change it but no luck
this is what I got now
powersync-1      | {"errors":[{"location":{"end":444,"start":443},"source":{"offset":12,"token":{"_location":{"end":55,"start":54},"col":55,"line":1,"lineBreaks":0,"offset":54,"text":"=","type":"op_eq","value":"="}},"type":"fatal"}],"level":"error","message":"Failed to update sync rules from configuration Syntax error at line 1 col 55:\n\n1  SELECT _id as id, * FROM messages WHERE messages.user = bucket.user_id\n                                                         ^\nUnexpected op_eq token: \"=\". Instead, I was expecting to see one of the following:\n\n    - A \"dot\" token\n    - A \"lparen\" token\n    - A \"kw_array\" token\n    - A \"lbracket\" token\n    - A \"string\" token\n    - A \"eString\" token\n\n","name":"Replicator:mongodb-winshot-29-10-2024","stack":"Error: Syntax error at line 1 col 55:\n\n1  SELECT _id as id, * FROM messages WHERE messages.user = bucket.user_id\n                                                         ^\nUnexpected op_eq token: \"=\". Instead, I was expecting to see one of the following:\n\n    - A \"dot\" token\n    - A \"lparen\" token\n    - A \"kw_array\" token\n    - A \"lbracket\" token\n    - A \"string\" token\n    - A \"eString\" token\n\n\n    at SqlSyncRules.throwOnError (file:///app/packages/sync-rules/dist/SqlSyncRules.js:113:19)\n    at SqlSyncRules.fromYaml (file:///app/packages/sync-rules/dist/SqlSyncRules.js:107:19)\n    at MongoBucketStorage.updateSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:105:37)\n    at MongoBucketStorage.configureSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:59:53)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async ChangeStreamReplicator.runLoop (file:///app/packages/service-core/dist/replication/AbstractReplicator.js:61:34)","timestamp":"2024-11-05T15:50:18.034Z"}

Do you get the same issue for where "user" = ...?

powersync logs show the user id I even hardcoded it
powersync-1      | {"client_id":"26b89308-f244-467e-a2b7-f254b6e3265b","data_synced_bytes":11070470,"level":"info","message":"Sync stream complete","operations_synced":21000,"timestamp":"2024-11-05T15:57:21.767Z","user_agent":"powersync-js/1.20.1 powersync-react-native react-native/0.74 android/34","user_id":"65aa47430c13e7254cc186c1"}
# https://docs.powersync.com/usage/sync-rules/example-global-data
bucket_definitions:

  user_data_bucket:
    accept_potentially_dangerous_queries: true
    # https://docs.powersync.com/usage/sync-rules/advanced-topics/client-parameters
    #parameters: SELECT request.parameters() ->> 'user_id' as user_id
    # parameters:
    #   - SELECT request.user_id() as user_id
    data:
      - SELECT _id as id, * FROM messages where user='65aa47430c13e7254cc186c1'

output
powersync-1      | {"errors":[{"location":{"end":437,"start":433},"source":{"location":{"end":44,"start":40},"sql":"SELECT _id as id, * FROM messages where user='65aa47430c13e7254cc186c1'","type":"fatal"},"type":"fatal"}],"level":"error","message":"Failed to update sync rules from configuration keyword not supported here","name":"Replicator:mongodb-winshot-29-10-2024","stack":"Error: keyword not supported here\n    at SqlSyncRules.throwOnError (file:///app/packages/sync-rules/dist/SqlSyncRules.js:113:19)\n    at SqlSyncRules.fromYaml (file:///app/packages/sync-rules/dist/SqlSyncRules.js:107:19)\n    at MongoBucketStorage.updateSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:105:37)\n    at MongoBucketStorage.configureSyncRules (file:///app/packages/service-core/dist/storage/MongoBucketStorage.js:59:53)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async ChangeStreamReplicator.runLoop (file:///app/packages/service-core/dist/replication/AbstractReplicator.js:61:34)","timestamp":"2024-11-05T16:00:44.583Z"}

Sorry I mean:
data:
      - SELECT _id as id, * FROM messages WHERE "user" = bucket.user_id

now it works fine!
but why!

 Unlucky that you had that column/key name. I am glad to hear it works :)
Personally, I would name these as user_id anyway but I realise that might not always be possible.

Thank you again for your time & your explanation & all powersync.
I'll keep that in mind. :)


Sibling count mixin

Following these posts, I wrote this mixin for styles specific to the number of children (or multiples of the number of children) of a parent element.
It's had enough applications in the work I've done so far that it seems like it might be generally useful to have in a mixin library like Bourbon.

Thanks for the PR!
Isn’t this technique quickly becoming obsolete now that we have flexbox [gaining traction and support[(http://caniuse.com/#feat=flexbox)? I find myself using flexbox on projects a lot these days and it’s made for these types of situations.

That's a good point... especially for things like column width, flexbox is the way to go.
There are still some cases where it's necessary to have styles specific to number of siblings. If you have a three element-per-row data-driven list, and you want to apply a specific style only to the last row (which might have one, two, or three elements), I think something like this is required. More generally, if you want to have styles other than width/height change based on sibling count, then flexbox alone won't do it. So I think it's useful, but it is true that flexbox is a better solution to the most common problem for which you'd be tempted to use this :)

We appreciate the PR, but I’m going to close this for now. I think this mixin is solid, but I think it’s such a rare case that you need something like this, and I don’t want to clutter up Bourbon. I would encourage authors to add it to a project on an as-needed basis.
Thanks again for the PR!


jsonlint removes internal spaces in array values on validating array-as-value bracketed by "s

If instead of the valid JSON
{
"key1": [
"key2",
"key2 value with spaces"
]
}
we instead ask JSONlint to validate
{
"key1": "[
"key2",
"key2 value with spaces"
]"
}
we are duly informed that the " before [ is an error, but with that validation we see also that JSONlint has collapsed the value
"key2 value with spaces"
to
"key2valuewithspaces"
--a behavior that's especially hazardous should the JSON snippet under test be sufficiently large and/or complex to disallow our eyes catching the collapse.
Best regards,
David Newkirk

This issue is fixed in new version of jsonlint.com. Thanks for reporting.


June 21st release

This should be v1.6.0

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Mixed Content Warning Error on SVG Images in Next 11

Describe the bug
When using an SVG image in <Image/>  it throws mixed content warning error in Next 11.
Mixed Content: The page at 'https://site.netlify.app/' was loaded over HTTPS, but requested an insecure image 'http://site.netlify.app/img/graphic.svg?url=%2Fimg%2Fgraphic.svg&w=1920&q=75'. This request has been blocked; the content must be served over HTTPS.

I have created a demo to replicate the issue, the SVG is not loading, instead of throwing 502 error this time.
https://nostalgic-mcnulty-ff9b66.netlify.app/
To Reproduce
Steps to reproduce the behavior:

Create new Next 11 App
Add <Image/> with src pointing to an svg file (*.svg)
Upload to Netlify.app
See the error in the console.

Expected behavior
It has something to do with HTTPS to HTTP error,
Versions

Next.js: 11
plugin : 3.6.0

We are having the exact same problem.

The error on that site is because you're deploying from your local machine, and pushing your local sharp module:. Do you have a build deployed from a build on the Netlify server?
See https://nostalgic-mcnulty-ff9b66.netlify.app/nextimg/%2Fimg%2Fbg-graph.svg/1920/75?url=%2Fimg%2Fbg-graph.svg&w=1920&q=75

@ascorbic Thanks.
I was now able to replicate the Mixed content issue.
Demo: https://dazzling-lamarr-f47862.netlify.app/
Repo: https://github.com/surjithctly/netlify-svg-test

I also experienced this issue. The following meta tag can be used as a workaround in the meantime:
<meta
  httpEquiv="Content-Security-Policy"
  content="upgrade-insecure-requests"
></meta>

I also experienced this issue. The following meta tag can be used as a workaround in the meantime:
<meta
  httpEquiv="Content-Security-Policy"
  content="upgrade-insecure-requests"
></meta>

Thanks :) That helped. I was still facing this issue.But yeah this one worked for me.

@nitindutta5 This has been fixed in v3.6.1, so it will be good if you upgrade the package instead.

@surjithctly, Is there an option to upgrade the plugin from the UI? I uninstalled and installed the plugin but it didn't work. I was still getting the "Mixed content" warning error.
I ended up using the meta tag workaround.

@evojewel You can install this plugin in your project root, then netlify will use that instead of default (old) version.


Change Log / Activity Log

Is your feature request related to a problem? Please describe.
Currently a user could remove or stop all containers and there would be no way to tell what user did it. This will help for debugging/accountability with many users who have access to portainer. This will allow admin users to see what users have done within portainer.
Describe the solution you'd like
A change log or general activity log would be great to have so admin/leaders could see that UserX create Container1 but UserY stopped it.

Duplicate of #696


Remove patterns_version argument

@mirkan1 Now that we require the product argument, the patterns_version argument should be unnecessary, and we should remove it.
For example, in the below, we say product = 'weekly_patterns' and then require the user to also specify patterns_version = 'weekly', which is redundant.
example_weekly_patterns = sgql_client.lookup(product = 'weekly_patterns', placekeys = example_pk, columns = '*', date = '2021-08-05', patterns_version = 'weekly')

I changed a major line.
pytest passed but I think you might want to test it as well
https://github.com/echong-SG/API-python-client-MKilic/commit/a350f6b361a6f0f54a50d6c1ffd64d3e80552c50#diff-bbe34bd5f41f00a48b348f62a944221d0b79ed9887359a144e6b747682983a10L209

looks good


Sets up the core to use the prod binary, rather than debug

Also updates the README to reflect this change.
Adds instructions for how to install the prod version of the core, and get it in your path

thank you!


turn off data verification service when in debug

This resolves some issues with transport security as well as error messages/other misleading messages when the server is not available.

r=me


Enhancement/Feature Request-Algolia Netlify plugin

Would this work for searching?
https://github.com/algolia/algoliasearch-netlify#readme
I use Algolia on a few sites, but it was always built in. All I did was supply the API keys. I don't know how to make the search field/box own each page. I'm not a developer.
It seems to be Netlify only, but a lot of users use that site.
Thanks
Paul

@theapplegates I'm definitely planning to integrate the Algolia search plugin! 😃

I've decided NOT to implement Algolia at this time. Others are invited to implement that if they feel search is important to their implementations.


media player not playing live video streams

good day I'm looking for help we currently use my media player and local so that for an RP busness  can play their own stuff  where we are running into an issue is one of my r p business ideas I would like to Rana air quotes radio station or TV station so to do that I look to utilize YouTube live streaming because shoutcast just takes you to a dead Gmod tower link  when you try and load my personal life stream or a random one-off Youtube it just says it can't be played in this browser any help would be greatly appreciated is that something I should be talking with  the servers development team or is that just a physical limitation of the media player that can't be worked around thank you in advance for any information you can offer

This fix enabled live youtube videos for me https://github.com/solsticegamestudios/GModCEFCodecFix


RFC: WASM based ResourcePipeline

Description
This RFC supersedes  #195.
We propose a change to the architecture of the ocm-controller that will introduce Web Assembly (WASM) middleware in order to transform OCM resources.
In #195 we proposed modifying the existing Resource   controller to achieve this aim. However because the functionality of WASM lends itself to transformation pipelines we propose to introduce a new Kubernetes resource ResourcePipeline .  This will allow for the delivery of resources to arbitrary environments using WASM based delivery modules. This enables us to generalize the utility of the ocm-controller beyond Kubernetes.
Context
One of the design guidelines for the ocm-controller is that it should support arbitrary transformation of resources. Standard transformations such as Localization and Configuration are provided "in-tree" as part of the controller.
We currently perform transformation using code that is common to both Localization and Configuration controllers. In addition we share resources using Snapshots. Snapshots provide a generic way to pass OCM resources between different Kubernetes controllers.
Whilst this works it requires operators to manage a large number of Custom Resources generating additional complexity meaning it can be difficult to build a mental model of the transformation sequence. It also leads to a somewhat large and complex codebase.
WASM Solution
WASM produces tiny binaries that execute in a sandboxed runtime environment. These properties make it ideal for the execution of untrusted code in a dynamic way. We propose that rather than using discrete controllers to perform transformation of OCM resources we can use WASM binaries to execute the transforms. WASM binaries can be executed from the ocm-controller and specified by the operator in the Resource CR.
In order for this solution to work we need to define a contract that WASM binaries and the ocm-controller must observe:

1: The WASM binary must be stored as a resource in an OCM component with type webAssembly
2: By default the ocm-controller will mount a file-system at the path /data  in which resources files will be available (this can be disabled if desired)
3: Any transformations should be performed on the filesystem
4: The ocm-controller will provide host calls that can be used to call ocm library functions such as GetResourceBytes, GetResourceMeta, GetResourceAccess. These host calls will be documented on the ocm website.
5: Configuration can be passed to the WASM guest process using the values or valuesFrom fields.

The OCM project would provide a component that publishes official / first-party modules.
These modules could offer functionality such as spiff based localization and configuration, ocm:// prefix based localization and other transformations.
End-users could provide their own modules by publishing the component and specifying the details in the ResourcePipeline manifest.
Delivery & Secrets Integration
In order to support off-Kubernetes systems the ResourcePipeline spec can specify a set of delivery targets. The mechanics for transferring a resource to a target are the the responsibility of the delivery modules. The output of the workflow process can be transferred to multiple targets.
In order to access target we provide access to secrets which are retrieved from secret stores and passed to the WASM module at the time of execution. In order to realize this functionality we will leverage the SecretStores API provided by the External Secrets Operator.
API Object
apiVersion: delivery.ocm.software/v1alpha1
kind: ResourcePipeline
metadata:
  name: podinfo-deployment
  namespace: ocm-system
spec:
  interval: 10m0s
  serviceAccountName: blue-team
  sourceRef: # the source must be a Kubernetes API object of kind ComponentVersion
    name: podinfo
    namespace: default
    resource: manifests
  secrets:
  - name: kubeconfig
    secretStoreRef: # ideally we can use ESO here
      name: vault
      namespace: default
    remoteRef:
      key: /kv/prod/kubeconfig
  - name: sshkey
    secretStoreRef:
      name: vault
      namespace: default
    remoteRef:
      key: /kv/prod/sshkey
  # parameters can be used to provided configuration that is
  # shared across multiple workflow steps
  parameters:
    replicas: 2
# parameters could also come from a configmap
# parametersFrom:
#   kind: ConfigMap
#   name: params
#   namespace: default
# workflows could be templated and re-used
# workflowRef:
#   name: release-workflow
  workflow:
    steps:
    - name: resolver
      module: delivery.ocm.software/middleware:v1.0.0@resolver
      # configuration values can be validated using cue policy that is part of the component
      values:
        prefix: ocm://
    - name: configure
      registry: ghcr.io/phoban01 # registry is optional, defaults to ghcr.io/open-component-model
      module: delivery.ocm.software/middleware:v1.0.0@configure
      values:
        replicas: $parameters.replicas
    - name: label
      module: delivery.ocm.software/middleware:v1.0.0@labeler
      values:
        owned-by: "ocm.software"
        managed-by: "weaveworks"
  delivery:
    targets:
    - name: local
      module: delivery.ocm.software/ssa:v1.0.0@ssa
      values:
        targetNamespace: default
        createNamespace: true
    - name: remote
      module: delivery.ocm.software/ssa:v1.0.0@ssa
      values:
        kubeconfig: $secrets.kubeconfig
    - name: oci
      module: delivery.ocm.software/oci:v1.0.0@push
      values:
        name: my-resource
        tag: release
        kubeconfig: $secrets.regcred
    - name: git
      module: delivery.ocm.software/git:v1.0.0@push
      values:
        repository: my-resource
        sshkey: $secrets.gitssh
        message: "[ocm-controller] add resources"
    - name: lambda
      module: delivery.ocm.software/aws:v1.0.0@lambda
      values:
        credentials: $secrets.aws

Could use a bit better explanation on the workflow part:
workflow:
    steps:
    - name: resolver
      module: delivery.ocm.software/middleware:v1.0.0@resolver
      # configuration values can be validated using cue policy that is part of the component
      values:
        prefix: ocm://
    - name: configure
      registry: ghcr.io/phoban01 # registry is optional, defaults to ghcr.io/open-component-model
      module: delivery.ocm.software/middleware:v1.0.0@configure
      values:
        replicas: $parameters.replicas
    - name: label
      component: delivery.ocm.software/middleware:v1.0.0@labeler
      values:
        owned-by: "ocm.software"
        managed-by: "weaveworks"

So module appears to be optional, right? What's the module, if not defined? You define component instead. Did you just leave off module? Or would be somehow auto-discovered?
What is the purpose of component if defined? What is it if not defined? :)

What is the purpose of component if defined? What is it if not defined? :)
Component was a typo 😄 . Module is required, it points at a WebAssembly resource and the reference is<EMAIL_ADDRESS>
Parameters are for configuration that might be used across many workflow steps.

As a side note, all of the pipeline items will need be executed by the same controller on the same pod. Otherwise we might end up in a situation where one of the items runs on a different mount and will fail to find an output. In our previous implementation this sync point was the registry. Here it will be the mount. And we don't want to bother with NFS.


Nested unplugins: Is there a way to reuse existing third-party unplugins?

Clear and concise description of the problem
Hello! First, thank you so much for your fantastic work with unplugin! A unified plugin system is so valuable!
Baseline:
I'm currently developing an unplugin that provides an entire "design system" for other websites of the same vendor. Imagine a large association with lots of tiny websites and lots of dev teams working on them, and they all need the exact same look & feel, but depending on the use case, they might use different frameworks. It has a highly sophisticated Tailwind setup, many CSS files, and a custom icon set based on SVGs. The project this design system started on already uses unplugin-icons, so creating an unplugin for the design system basically suggested itself.
The challenge I'm facing:
My custom unplugin first adds Tailwind + config and PostCSS config. This works like a charm. However, I have yet to find an elegant way to include the icon set with existing unplugin-icons behaviour.
The documentation has a section on "Nested plugins" (https://unplugin.unjs.io/guide/#nested-plugins), which, from my understanding, should be what I want. After all, I'm trying to nest the unplugin-icons into my custom unplugin. The documentation shows how to define two custom plugins within the same unplugin but doesn't mention reusing third-party unplugins.
A possible solution that came to my mind was to import the source config of unplugin-icons and reuse this as a "custom" second unplugin. That could look something like this:
// my/custom/unplugin/src/index.ts
import unpluginIcons from 'unplugin-icons'

export const unpluginFactory: UnpluginFactory<Options | undefined> = (options, meta) => {
  return [
    unpluginIcons,
    { /* My custom unplugin */ },
  ]
}

However, the version installed via NPM only offers the pre-built plugins for all build tools and, sadly, not the source config I'd potentially need to "recreate" the plugin in my unplugin config.
So, my current solution, for example, for the webpack plugin, is something along these lines:
// my/custom/unplugin/src/index.ts
import unpluginIcons from 'unplugin-icons'

export const unpluginFactory: UnpluginFactory<Options | undefined> = (options, meta) => {
  return [
    {
      name: 'my-custom-unplugin',
      enforce: 'post',
      webpack (compiler) {
        // More code to introduce Tailwind, etc.

        // v That's the interesting bit
        const iconsPlugin = unpluginIcons.default.webpack({ /* my config here */ })
        iconsPlugin.apply(compiler)
      }
      // More plugin defs
    }
  ]
}
export const unplugin = /* #__PURE__ */ createUnplugin(unpluginFactory)

export default unplugin,

To me, this seems cumbersome.
Suggested solution
If an elegant way to reuse third-party unplugins already exists, I suggest documenting it in the "Nested unplugins" section of the documentation.

If there is no such way, I suggest adding a way to reuse third-party unplugins, similarly to this code snippet:

// my/custom/unplugin/src/index.ts
import unpluginIcons from 'unplugin-icons'

export const unpluginFactory: UnpluginFactory<Options | undefined> = (options, meta) => {
  return [
    unpluginIcons,
    { /* My custom unplugin */ },
  ]
}

(EDIT: Thinking about it, perhaps adding a utility function that takes a built unplugin and returns a reusable version for other unplugin configs to use could work. This would also simplify passing options to the unplugins. Something like: useThirdPartyUnplugin(unpluginIcons, { /* Some hardcoded options + user options */ }))
I'd be happy to contribute here where necessary, but I don't know if I would be re-implementing existing functionality or documenting things that don't exist... If this would need implementation, in my opinion, the functionality could go into the starter, as people who create new unplugins will likely profit the most from this.
Alternative
If this functionality doesn't exist yet and is deemed unnecessary (I'd perfectly understand that, too), perhaps a note in the documentation that this isn't possible and a recommended way of handling these situations would be beneficial for people running into the same issues as me.
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I just realised that this might be the wrong repository to have reported this to. If that's the case, we can move it.

I think I found a solution! A built plugin (i.e. an UnpluginInstance) has a key raw, which takes options and returns the UnpluginFactory needed to nest it. The full example would be:
import { UnpluginFactory } from 'unplugin'
import { createUnplugin } from 'unplugin'

// Import custom plugin
import unpluginIcons from 'unplugin-icons'

export const unpluginFactory: UnpluginFactory<Options> = (options, meta) => {
  return [
    unpluginIcons.raw(/* Some options */),
    {
      name: 'Your plugin'
      // ...
    }
  ]
}

I'd be very happy to contribute this to the documentation. Please expect a PR in the coming 1 to 2 weeks! And again, thank you for your brilliant work!


Update sourcetree to 2.7c

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Apparently this has been out for some time already: https://www.sourcetreeapp.com/update/releasenotes/2.7.html#version-2.7


Generating mask in training

Hello,
first of all thanks for the great work!
I was going through your work and what I find missing is how the masks are generated. I'm asking because according to the latent diffusion paper, they used a similar approach as in LaMa, in which for the training, parts of the image are randomly taking out and used as masks. My question is when you generated the masks for training did you do that randomly or did you chose masks of specific objects?
Thanks in advance!

Hello,
thanks for appreciating!
Yes that's correct, in this case I just provided a simple method to fine-tune stable diffusion having already the mask generated (in a custom way).
However, I have also implemented llama mask generation for my dataset and i will soon upload this feature in the repo.
Meanwhile, you could easily integrate it referring to the yaml configuration file and the main generating script (https://github.com/advimman/lama/blob/7dee0e4a3cf5f73f86a820674bf471454f52b74f/bin/gen_mask_dataset.py). I will close this issue when i will be able to test and integrate here :)


Add an example app instead of only example dart files

The goal of this pull request is to add an example app which provides the possibility to instantly start and use the example.
The structure is based on the shared_preferences example.

Thanks. I will need some time to review this. I should have time next week depending on what I have on the go. But thanks for contributing


CORE-20139: Refactorings and LB 4.27.0 upgrade

The dependabot upgrade of Liquibase had some deprecated functions that need to be removed, so this PR changes to the new framework liquibase uses.
Linked to https://github.com/corda/corda-runtime-os/pull/5892 as it could not be reopened

build e2e

build e2e


Incorrect API response for repositories without avatar

Description
For repositories without an avatar, we now get this in the API response:
"avatar_url": "https://demo.gitea.com/"
In 1.21 this was "avatar_url": ""
Gitea Version
1.23.0+dev-151-gc93cbc991e
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
docker
Database
PostgreSQL

Regression from #30885 maybe?

Still broken in recently released 1.22.1, missing backport?


The Bot response time "A minute ago" is not announced by screen reader NVDA in both Focus and Browse mode.

Is it an issue related to Adaptive Cards?
No.
What is the PWD impact?
Visually challenged users who rely on screen readers will be impacted if the bot response time is not announced by screen reader NVDA in both Focus and Browse mode.
What browsers and screen readers do this issue affect?
Windows: Edge with Windows Narrator
Are there any code-based customization done to Web Chat?
No, I am using Web Chat without any customizations except "styleOptions".
What version of Web Chat are you using?
Latest production
Which area does this issue affect?
Others or unrelated
What is the public URL for the website?
https://airtuserexpdev.azurewebsites.net/Dashboard
How to reproduce the issue?
Step 1: Open the URL: https://airtuserexpdev.azurewebsites.net/Dashboard in Edge Browser.
Step 2: AIRT Dashboard page will appear, Navigate to “Chat with Sage” chat box at the bottom of the page.
Step 3: Enable browse mode and navigate to "A minute ago" using down arrow key.
Step 4: Verify whether the Bot response time "A minute ago" is announcing by screen reader NVDA in both Focus and Browse mode or not.
What do you expect?
The Bot response time "A minute ago" should be announced by screen reader NVDA.
NVDA should announce as "A minute ago" upon focusing on the "A minute ago" text in browse mode.
Note: Issue repro with all screen readers
What actually happened?
The Bot response time "A minute ago" is not announced by screen reader NVDA in both Focus and Browse mode.
Do you have any screenshots or recordings to repro the issue?

Did you find any DOM elements that might have caused the issue?
No response
MAS reference
MAS 1.3.1 – Info and Relationships
WCAG reference
No response
WAI-ARIA reference
No response
Adaptive Card JSON
No response
Additional context
No response

Bug copied from Accenture team: BUG 11645889

#A11yMAS;#A11ySev3;#MAS1.3.1;#HCL;#Accessibility;#FeatureBotframeworkwebchat-Apr23;

We discussed with accessibility team and they suggested narrating an absolute timestamp, rather than a relative timestamp. This is because the relative timestamp will change from time to time.
Instead of narrating "a minute ago", we narrate the time, for example "three twenty P-M" for (3:20 PM).


Web Analytics support

Description
Add Web Analytics Support.
CC @cf-ypark
Has your change been tested?
Unit tests have been added that align with the documented API spec.
I have locally tested the changes with a personal zone.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

Public API documentation will be coming soon, just wanted to get this out for a review first.

GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Detected hardcoded secret in your pull request
Guidelines to remediate hardcoded secrets
owl GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

All of the tokens/ids are random and not from an actual account.

yeah, ignore the GitGuardian stuff. it's really blunt at finding "issues".

Codecov Report

Merging #1348 (1cd322e) into master (b9ac804) will increase coverage by 0.12%.
Report is 102 commits behind head on master.
The diff coverage is 52.96%.

@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
+ Coverage   48.33%   48.45%   +0.12%
==========================================
  Files         133      136       +3
  Lines       13023    13372     +349
==========================================
+ Hits         6295     6480     +185
- Misses       5201     5309     +108
- Partials     1527     1583      +56

Files Changed
Coverage Δ

device_posture_rule.go
61.80% <ø> (ø)

load_balancing.go
59.40% <ø> (ø)

teams_accounts.go
53.84% <ø> (ø)

rulesets.go
30.14% <22.58%> (-4.50%)
:arrow_down:

regional_tiered_cache.go
43.75% <43.75%> (ø)

web_analytics.go
45.29% <45.29%> (ø)

logpush.go
51.81% <46.15%> (-0.30%)
:arrow_down:

images.go
44.70% <47.82%> (-0.12%)
:arrow_down:

pages_deployment.go
38.88% <61.76%> (+4.64%)
:arrow_up:

workers_bindings.go
67.90% <71.05%> (+0.46%)
:arrow_up:

... and 4 more

... and 3 files with indirect coverage changes


Cannot retrieve scripts from some servers

XMLHttpRequest cannot load http://code.famo.us/famous/0.3/famous-global.min.js.
No 'Access-Control-Allow-Origin' header is present on the requested resource.
Origin 'http://localhost:3000' is therefore not allowed access.

The exception you're seeing indicates there's a cross-domain issue caching/loading the resource. You need to ensure you're caching files on the same origin, which the browser considers a different domain (so it blocks the overall flow). Try caching the library from your own domain (for testing purposes, this would also be localhost).


Social media clickable link on photo

Actual Behaviour
There should be a clickable link on photo of team members so that visitors and interact with the members directly and can get a wide idea regarding the respective project.
Expected Behaviour
Social media link should be provided on photo which should appear after hover.
Screenshots of the issue

Would you like to work on the issue?
yes

Not the right place. We are focusing on the actual software project. Please help and focus on the software or hardware only atm.

Thanks @mariobehling working on that....


Move schema to its own package and add unit testing

This commit moves the code that handles datatype and table schemas from the main package to the schema package and adds unit testing for it.
This commit also adds fake GCS downloader and uploader functions to both main_test.go and schema_test.go.
There are some readability changes in function and/or variables names but the core logic hasn't changed.
This commit passes both golangci-lint and go test.  Coverage is around 90% for both main and schema.

This change is

cmd/jostler/main.go line 104 at r1 (raw file):
Previously, robertodauria (Roberto D'Auria) wrote…
Typo: compatible

Corrected.

Thank you Roberto.


Revise AAD baseline policy 2.14 based on feedback and prototyping

💡 Summary
Modify Azure AD baseline policy 2.14 as per the instructions below. See issue #254 for details.
Implementation notes

[x] Change the first policy bullet to "Permanent active role assignments SHALL NOT be allowed for highly privileged roles except for break-glass accounts or service accounts that require perpetual access."
[x] Remove the policy sentence "Active assignments SHALL have an expiration period." from the first policy bullet.
[x] Add guidance that a conditional access policy can be created for service accounts (e.g. Azure AD Connect account) to restrict them to trusted source locations.
[x] Modify the Implementation steps to align with the new policy.

@ssatyapal123 Wanted to provide some details on the changes in this issue to be as precise as possible and make it easier for you to decipher some of my earlier notes. There is a fundamental change to how this policy is interpreted by the Rego and therefore will also change the step-by-step implementation instructions in the baseline document too.
We are changing the 1st policy bullet in the 2.14 baseline as per below
Old policy: "Permanent active role assignments SHALL NOT be allowed for highly privileged roles. Active assignments SHALL have an expiration period."
New policy: "Permanent active role assignments SHALL NOT be allowed for highly privileged roles except for break-glass accounts or service accounts that require perpetual access."
Respective ScubaGear changes

In ScubaGear, remove the checks for the PIM configuration settings "Allow permanent active assignment" and " Expire active assignments after 15 days". We will no longer be checking those configs.
In ScubaGear, replace those checks with code that examines if there are any permanent active assignments (see screenshots below) to highly privileged roles? If there are, we will show a Fail in the report unless the user ID for those assignments are in a config file exclusion.

The screenshot below shows several users that have a permanent active assignment and therefore would produce a Fail in the report unless there a config file exclusion for each user in that list.

The screenshot below shows a user that has an active assignment that is NOT permanent and therefore would produce a Pass in the report. Notice that there is a specific End time for the assignment.

Additional general changes
The following change applies to this policy and others.
All references to the recommended list of highly privileged roles, should point to a section at the front of the document instead of referring to the baseline statement "Highly Privileged User Accounts SHALL be Cloud-Only". We are moving the list of privileged roles to the front of the document because it makes more sense to have it in a central location.

Updates made to AAD policy 14.
@tkol2022 does it make sense to combine policies 2.14-2.16 into one group and call it "Highly Privileged User Provisioning" or something, as many of the implementation steps take place in the same PIM dialog boxes?
https://github.com/cisagov/ScubaGear/blob/203-adjudicate-aad-comments/baselines/aad.md#14-permanent-permissions

Yes, I like that idea! You can probably include 2.11, 2.12 and 2.13 as well because all of those are related to highly privileged user policies. If you decide to do that, then maybe name the section something like Highly Privileged User Management and Monitoring.

@tkol2022 I updated the grouping to include 10 policies in group number 11.
https://github.com/cisagov/ScubaGear/blob/203-adjudicate-aad-comments/baselines/aad.md#11-highly-privileged-user-management-and-monitoring

Nice. Looks good.

Closing since it was addressed in 379.


failed to create field name ‘中文汉字’：cannot convert to ISO-8859-1

When I downloaded the data for China, I found that Chinese characters could not be successfully encoded.

Please fill out all the details in the new issue template according to its full instructions, and we can take a look. Without that, this issue will be automatically closed as we need those details to proceed.


fix(jest-dev-server): fix port detection

Fix #460, #281, #233

Hi @gregberge did these changes build correctly into<EMAIL_ADDRESS>I'm still seeing the old isPortTaken (vs isPortBusy) via the npm code tab:
https://www.npmjs.com/package/jest-dev-server?activeTab=explore
Thanks

@colinrotherham just redeployed, I checked the code and it is correct.

@gregberge That's great, thank you. Appreciate it
We had a Dependabot update for<EMAIL_ADDRESS>but didn't realise jest-dev-server needed a bump too


Php7.3 Import Excel Error Reporting

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /www/wwwroot/bamboo.2418.cn/vendor/phpoffice/phpexcel/Classes/PHPExcel/Shared/OLE.php on line 288

Are you sure you're using the latest version? In your error message, you're talking about PhpExcel which we no longer support (because it's an abandoned package). Laravel Excel 3.1 uses PhpSpreadsheet.

Closing due to resolved/inactivity. Please feel free to reopen if you need additional support.
Include your code in that case.


Abstract parser registration for compilation

This allows the parser to control more of the logic for things such as generating code and identifying dependencies. To add a new "parser" now just requires registering it in the PageCompilationOptions

@birojnayak this should also help with enabling user controls

taking a look


Commvault integration with Azure Sentinel- V.1.0

Change(s):

Created the Commvault Integration Solution that features the following:

Runbooks: Three of which are use cases for making API calls to Commvault/Metallic, and one for cycling access tokens
Analytic Rules: These query for manually created Sentinel Incidents with specific names and descriptions
A detailed Readme file that walks the user through creating the remainder of the integration assets through the GUI

Reason for Change(s):

Initial integration PR.

Version Updated:

Yes
Initial pull request.

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

@v-prasadboke Please validate if the files are in correct format or not. I see Analytics Rule are in JSON format.

@microsoft-github-policy-service agree company="Commvault"
Best Regards,
Jitin Jindal
From: microsoft-github-policy-service[bot] @.>
Sent: Monday, July 3, 2023 10:08 AM
To: Azure/Azure-Sentinel @.>
Cc: svc.Cv-securityIQ @.>; Mention @.>
Subject: Re: [Azure/Azure-Sentinel] Commvault integration with Azure Sentinel- V.1.0 (PR #8426)
External email. Inspect before opening.
@Cv-securityIQhttps://github.com/Cv-securityIQ please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/Azure-Sentinel/pull/8426#issuecomment-1618375322, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAHC3D55HISSQOVV23ZXQULXOLG27ANCNFSM6AAAAAAZ4QK7EA.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @Cv-securityIQ we are waiting for you to update analytic rules files to yaml type, thanks!

Hi @Cv-securityIQ we are waiting for you to update analytic rules files to yaml type, thanks!

Hi, the required change has been made.

Hi @Cv-securityIQ we are waiting for you to update analytic rules files to yaml type, thanks!

Hi, the files have been updated.

Hi @Cv-securityIQ thanks for the update, we will work with the concerned team on reviewing the code changes, thanks!

Hi @Cv-securityIQ we don't have native support for automation Runbooks, so you can try to use Playbooks for automation activities (since we don't support Runbooks in solutions, it will not be included in final package). If you want to check-in those in the current form you can add-in Tools folder as Tools/CommvaultAutomation scripts, please accommodate these changes in the PR and update accordingly, thanks!

Hi @Cv-securityIQ we don't have native support for automation Runbooks, so you can try to use Playbooks for automation activities (since we don't support Runbooks in solutions, it will not be included in final package). If you want to check-in those in the current form you can add-in Tools folder as Tools/CommvaultAutomation scripts, please accommodate these changes in the PR and update accordingly, thanks!

Hi, I've moved the runbooks to Tools/CommvaultAutomationScripts.

Thanks for the updates @Cv-securityIQ can you please adjust the query format in the yaml files and remove the characters '\r\n' you can add the newline directly, for reference please check the file - AADHybridHealthADFSNewServer.yaml

Thanks for the updates @Cv-securityIQ can you please adjust the query format in the yaml files and remove the characters '\r\n' you can add the newline directly, for reference please check the file - AADHybridHealthADFSNewServer.yaml

Hi, I've made the changes to the yaml and pushed the files. Let me know if more changes are required.

Thanks for the updates @Cv-securityIQ can you please adjust the query format in the yaml files and remove the characters '\r\n' you can add the newline directly, for reference please check the file - AADHybridHealthADFSNewServer.yaml

Hi, I've made the changes to the yaml and pushed the files. Let me know if more changes are required.

Hi @Cv-securityIQ thanks for the updates, we will check the content and provide you update by Thursday 27th July 2023, thanks!

Hi @Cv-securityIQ, entityMappings are kept blank, is there any reason for it?

Hi @Cv-securityIQ, entityMappings are kept blank in all analytical rules, is there any reason for it?

Hi, the entityMappings will be done when the syslog and webhook is integrated. For now we manually create the incident so we are not mapping any entities.

Hi @v-rbajaj, All the required changes have been made for the analytic rules and I've updated the PR.

Hi @Cv-securityIQ, thanks for making these changes.
Please make the description of all the three Analytical Rules a bit more descriptive, you can refer to query style guide or the examples of analytical rules shared here.

Hi @v-rbajaj, All the required changes have been made and I've updated the PR.

Hi @Cv-securityIQ, Validation for analytical rules is failing, please structure all the analytical rules correctly. Compare all properties in this analytic rules with our existing analytic rule files. For eg: I saw that the "tactics" are not correctly written compared it with FailedLogonToAzurePortal.yaml (https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Azure Active Directory/Analytic Rules/FailedLogonToAzurePortal.yaml).
You can refer any analytical rule from the repo or you can refer to ones shared here as example.

Hi, I've made the changes, please let us know if any other changes are required.

Hi @v-rbajaj, All the required changes have been made and I've updated the PR.

Hi @Cv-securityIQ, Validation for analytical rules is failing, please structure all the analytical rules correctly. Compare all properties in this analytic rules with our existing analytic rule files. For eg: I saw that the "tactics" are not correctly written compared it with FailedLogonToAzurePortal.yaml (https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Azure Active Directory/Analytic Rules/FailedLogonToAzurePortal.yaml).
You can refer any analytical rule from the repo or you can refer to ones shared here as example.

Hi, I've made the changes, please let us know if any other changes are required.

Hi @Cv-securityIQ, thanks for making these changes, we will get back to you by 7 Aug 2023.

Hi @Cv-securityIQ, can you please fix the validation failure for "No valid tactic corresponding to the technique T1578 was provided in the tactics field"?
I think Tactics should be  Defense Evasion
Refer :- https://attack.mitre.org/versions/v11/techniques/T1578/
Please remove the readme.md file from the PR as we can't have any other files in the detections/solution folder

Hi @Cv-securityIQ, can you please provide update on this PR?

Alright, thanks for sharing the update.

Alright, thanks for sharing the update.

Hi, I've made all the required changes and updated the PR.

Hi @Cv-securityIQ,
Since you are adding these contents as a solution please make the following changes:

Move the entire "Runbooks" folder inside "Solutions/Commvault Security IQ/Playbooks/" folder

Package the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V3
Please go through the readme.md file and follow the instructions mentioned there.

Please do add release note as well, follow below mentioned link for the same.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

Each playbook folder must contain azuredeploy.json file and readme.md (mandatory) and a folder with name "images"
To understand the folder structure you can have a look at this playbook - https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/ThreatXCloud/Playbooks/ThreatXPlaybooks/ThreatX-BlockIP-URL

Hi @Cv-securityIQ, Are you done required changes because we are waiting for you to work on all the points mentioned in this comment?

Alright, thanks for sharing the update.

Hi, I've made all the required changes and updated the PR.

Hi @Cv-securityIQ, Since you are adding these contents as a solution please make the following changes:

Move the entire "Runbooks" folder inside "Solutions/Commvault Security IQ/Playbooks/" folder
Package the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V3
Please go through the readme.md file and follow the instructions mentioned there.
Please do add release note as well, follow below mentioned link for the same.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md
Each playbook folder must contain azuredeploy.json file and readme.md (mandatory) and a folder with name "images"
To understand the folder structure you can have a look at this playbook - https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/ThreatXCloud/Playbooks/ThreatXPlaybooks/ThreatX-BlockIP-URL

Hi @Cv-securityIQ, Please work on these following changes:

In logo, please remove the  tag
(Click on code of the svg file to remove the tag)

In entire solution wherever just "Sentinel" is mentioned, please change it to "Microsoft Sentinel".

Hi @Cv-securityIQ, Please work on these following changes:

In logo, please remove the  tag
(Click on code of the svg file to remove the tag)
In entire solution wherever just "Sentinel" is mentioned, please change it to "Microsoft Sentinel".

And as mentioned earlier, do add release notes. (https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md)

Hi @v-rbajaj, I've made the required changes, the logoValidator is still failing, what could be the issue here?

Hi @Cv-securityIQ, for logo, please generate a GUID using  https://guidgenerator.com/ and update the GUID in ID.

Hi @Cv-securityIQ, This commit on readme.md is going to remove the readme file from here - https://github.com/Azure/Azure-Sentinel/blob/master/README.md

Please revert this commit.