Fix ingress.yaml service/port, make custom domain more obvious

Just set this up today so two things would make this easier for others to understand:

Made MY_EXTERNAL_DOMAIN for unique subdomain in YAML files.
Noticed that service for ingress.yaml should be juice-balancer, not just balancer, and needed port 3000, not 8080.

Feel free to reject these edits if they aren't helpful but it took me a bit to figure some of this out so figured this might help others as well.

@J12934 I reverted the ingress.yaml change but left MY_EXTERNAL_DOMAIN in this PR.


Bitstream command line cleanup operation - huge running time and potentially missing a DB commit

Describe the bug
I am currently running the "dspace cleanup" operation in our test environments to delete about 275K bitstreams flagged as deleted in our DB and I am observing huge differences in behaviour in DSpace 7.4 compared to our current DSpace 5.10.
In fact, I have not managed to get the script to complete in DSpace 7. Command run is "dspace cleanup -l -v" (with allocate 5GB or RAM just in case)

In our current DSpace 5.10 it has completed successfully in a couple of hours, and has only reported 12 errors out of more than 275K iterated items
In our test DSpace 7.4 it's been running for days and has not yet completed.

I have also noticed that there are no intermediate Committing to DB messages in the log files so this has prompted me to look at difference in the code in the cleanup method (BitstreamStorageServiceImpl.java). Could it be that a context.commit() statement is missing in that method within the commitCounter IF statement?
To Reproduce
Steps to reproduce the behavior:

In DSpace 7 run dspace cleanup -l -v

Expected behavior
The script completes in a couple of hours (for DBs with a large number of files to be deleted)
Related work
Link to any related tickets or PRs here.

@amgciadev : While I cannot say with 100% certainty, it does look to me like there could be a missing context.commit(); here: https://github.com/DSpace/DSpace/blob/main/dspace-api/src/main/java/org/dspace/storage/bitstore/BitstreamStorageServiceImpl.java#L299-L306
(At least the inline code comments imply it should be committing changes, but it obviously is not doing so)
If you wanted to test if adding a simple context.commit(); within that if (commitCounter % 100 = 0) works, that'd be a huge help.  It definitely won't hurt anything.  If it works, you could even send us a quick PR.
I'll also pull this over to our 7.5 board to see if anyone else has time to look at it quickly.

@tdonohue I can confirm that the commit was missing. Just linked the PR for this now. When testing the script in our large test instance I think I have uncovered another bug which causes the script to crash when the bitstream being deleted is the primary bitstream (constraint failed in table bundle). I am opening a separate issue for this one, once I have replicated in my local environment


Function created in deconstruction in catch clause cannot access other vars from catch clause

Input:
let fn;
try {
  throw new Error('foo');
} catch ( { message, x = (0, () => message) } ) {
  fn = x;
}
export default fn;

Output:
export default () => message;

message has not been recognised as a var in scope of the function.
Appears to be in part due to a bug in Babel. identifierPath.scope.getBinding('message') returns undefined.

Babel issue: https://github.com/babel/babel/issues/14024

I think fixed in b2a0a097b8c0c4a37c1ca38ef3f8085b60b1d3ec. Needs tests.


Cannot bind parameters to a circuit in the IBMSampler

Describe the bug
This fails:

from qiskit.circuit.library import TwoLocal
qc = TwoLocal(4, rotation_blocks =['rx', 'rz'])

with ibm_sampler(circuits=[qc], skip_transpilation=False) as sampler:
    params = np.random.random(qc.num_parameters)
    sampler(
        circuit_indices=[0],
        circuit_parameters=[params],
        shots=1e4,
    )

with
The number of values (0) does not match the number of parameters (32) for the 0-th circuit.

However I can do:

bind_qc = qc.bind_parameters(params)

and it works just fine.
Steps to reproduce
Try above
Expected behavior
It should work
Suggested solutions
Additional Information

qiskit-ibm-runtime version: 0.2
Python version:
Operating system:

@nonhermitian You have a non-existent parameter circuit_parameters in your code. The correct name is parameter_values. Could that be the issue here?

I think this issue is fixed in qiskit-ibm-primitives pull request 11. Just not deployed yet.

This looks to be resolved.


Joe Dirt 2 detected as being from year 0

http://www.imdb.com/title/tt4126340/
Is being parsed as "Joe Dirt 2: Beautiful Loser (0)"

What version you on?

Newest versions finds it just fine.
2016-01-11 12:53 VERBOSE  imdb_lookup   testing         Parsing imdb for `Joe Dirt 2`
2016-01-11 12:53 DEBUG    requests      testing         Fetching http://www.imdb.com/title/tt4126340/
2016-01-11 12:53 DEBUG    utils.imdb    testing         No rating found for tt4126340
2016-01-11 12:53 DEBUG    utils.imdb    testing         No original title found for tt4126340
2016-01-11 12:53 DEBUG    exec          testing         phase_name: on_output operation: for_accepted cmd: echo 'IMDB_NAME':' Joe Dirt 2: Beautiful Loser - IMDB YEAR':' 2015'
2016-01-11 12:53 VERBOSE  exec          testing         Executing: echo 'IMDB_NAME':' Joe Dirt 2: Beautiful Loser - IMDB YEAR':' 2015'
2016-01-11 12:53 INFO     exec          testing         Stdout: IMDB_NAME: Joe Dirt 2: Beautiful Loser - IMDB YEAR: 2015\n

Reopen if you think its needed


Eddystone beacons not listed

I have 4 Estimote beacons and I have enable Eddystone-UID, Eddystone-EID, Eddystone-URL, Eddystone-TLM broadcasting. They all share the same namespace, that I have used to filter the beacons as per your instruction. Unfortunately the script scanner_eddystone_example.py doesn't return any result. No error is returned, the script just goes in timeout.
If I use instead the iBeacon protocol with the script scanner_ibeacon_example.py I get all the beacons regularly filtered using their UUID, which is the same for them all.
I'm on a Raspberry Pi with Raspbian Lite and I have updated BlueZ from source to the version 5.50. Python is compiled with Bluetooth support. The command is executed with root privileges.

Maybe your specific beacons use some identifiers that the library does not recognize yet. Please do the following:
"""
sudo apt-get install bluez-hcidump
sudo hcitool lescan --duplicates &
sudo hcidump --raw
"""
This will dump the raw ble packets to the console. Please post them here so we can have a look at the issue.

Thanks, I will look into it. What is the exact model you are using?

It's the Proximity Beacon, the first one on the left in the list that you can find at the bottom of the products. The website claims it support both iBeacon and Eddystone simultaneously. But I have tried to enable even just Eddystone without success. There is an app that you can use to configure them, pretty straightforward. You can even set which frames to include in the broadcasting: UID, URL, EID, TLM, etc.

Could it be related to https://github.com/citruz/beacontools/issues/10?

It could.

On 8 Aug 2018, at 06:38, eltoro81<EMAIL_ADDRESS>wrote:
Could it be related to #10 https://github.com/citruz/beacontools/issues/10?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/citruz/beacontools/issues/25#issuecomment-411291183, or mute the thread https://github.com/notifications/unsubscribe-auth/AAS_0B0y1IAUSF4ZgKK2W4zRGKXhToJgks5uOnlvgaJpZM4VpxbQ.

I found the issue, why the Eddystone packets were not captured. In your dump are also some Estimote specific packets. I will add these as a completely new class of packets to the parser. You need to give me a few days, though.

Sure thing, thank you very much for the prompt response. I’m glad the dump has been helpful.

On 8 Aug 2018, at 21:40, citruz<EMAIL_ADDRESS>wrote:
I found the issue, why the Eddystone packets were not captured. In your dump are also some Estimote specific packets. I will add these as a completely new class of packets to the parser. You need to give me a few days, though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/citruz/beacontools/issues/25#issuecomment-411544971, or mute the thread https://github.com/notifications/unsubscribe-auth/AAS_0M53Zu9_-C75tPuhvLF5qZLVyO8pks5uO0zUgaJpZM4VpxbQ.

I have somewhat a same issue, I can see Eddystone TLM and URL frames, as well as IBeacon Frames, but Eddystone UID frames elude the scan. How do I know they are broadcasting UID? I have a smartphone app that picks up every bluetooth packet around it, and on it I can see my beacon broadcasting UID frames. Using beacons from kontakt.io

I just pushed the branch for the next release. It is still work in progress but I already implemented some changes:

relaxed the parsing constraints (RFU and flags field) -> that should solve @dedalozzo and @eltoro81 's problems.
added Estimote Telemetry packet (only subframe B at the moment)

With these changes I already see EddystoneURLFrame, IBeaconAdvertisement, EddystoneUIDFrame, EddystoneTLMFrame and EstimoteTelemetryFrameB packets in the dump @dedalozzo provided.
EddystoneURLFrame<tx_power: -22, url: https://twitter.com/estimote>

IBeaconAdvertisement<tx_power: -71, uuid: b9407f30-f5f8-466e-aff9-25556b57fe6d, major: 42782, minor: 64526>

EddystoneUIDFrame<tx_power: -22, namespace: edd1ebeac04e5defa017, instance: 47a038d5eb03>

EddystoneTLMFrame<voltage: 2991 mV, temperature: 26 Celsius, advertising count: 5093979, seconds since boot: 48741845>

EstimoteTelemetryFrameB<identifier: 47a038d5eb032640>

Also added subframe A of the Estimote telemetry packet spec.

Thank you very much @citruz, can you please make a release so I can get it from pip and test your changes?

Hi @citruz, I have tested it and it's working properly, thank you:
<fc:30:17:20:34:2a, -67> EddystoneTLMFrame<voltage: 3047 mV, temperature: 49178 Celsius, advertising count: 5899888, seconds since boot: 24763922> {'namespace': 'edd1ebeac04e5defa017', 'instance': '5d124ce70ec5'}
<e7:78:c6:dc:67:04, -36> EddystoneTLMFrame<voltage: 2966 mV, temperature: 16409 Celsius, advertising count: 7370726, seconds since boot: 55750462> {'namespace': 'edd1ebeac04e5defa017', 'instance': '47a038d5eb03'}

One last thing. Are you parsing even VBATT[1] 0x02 and all the other non standard parts of the TLM frame? I'm trying to find out is some beacon manufacturer is broadcasting the battery life (not just the voltage), or if I have to determine it myself based on some assumptions.

Yes, VBATT[0] and VBATT[1] are treated together as a 16 bit integer. I'm not sure what other parts you are referring to. This is the specification I use for parsing:  https://github.com/google/eddystone/blob/master/eddystone-tlm/tlm-plain.md

No, you can just pass a list as the packet_filter argument like this:
scanner = BeaconScanner(callback,
    packet_filter=[EddystoneTLMFrame, EddystoneUIDFrame]
)

Maybe I should add this to the examples :)

Good to know. Are you planning to support GATT as well to configure the beacons?

No sorry.

Every time the scanner receive a frame, it triggers the callback, so packet holds one frame at the time. Since each frame might have a different broadcasting interval, that's the only way I guess.

You can get the class of a certain packet using isinstance(packet, EddystoneTLMFrame). Or what is your question exactly?

Not a question, really, I was just describing the way it works. :-)
I guess we can close this. Thank you for the prompt response.

I just released the new version on PyPi (as 1.3.0 and not as 2.0.0, though).
https://pypi.python.org/pypi/beacontools/

Thank you.


Group by usecase

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
✔

Fixed issues
-

 Group classes by use-case · Issue #3 · yiisoft/app-api


Bump github.com/sacura from 1.27 to 1.28

Problem
We need to bump the Sarama library, see release notes: https://github.com/Shopify/sarama/releases/tag/v1.28.0
Exit Criteria
Bump Sarama from 1.27.0 to 1.28.0
Additional context (optional)
/good-first-issue
/area control-plane

This is done!


server: update diff score for adding leader peer.

@siddontang @shenli  PTAL

PTAL @shenli @siddontang

LGTM

LGTM


#42841 - Unknown user profile loads infinitely

Details
Fixed Issues
$ 42841
PROPOSAL: #42841 (comment)
Tests

Tap profile -> General -> Troubleshoot
Enable Force offline
Tap on Create -> Split expense -> Scan
Add Receipt
Add Any Dummy Email ID and Link to That expense
Click On Added Email Profile (will Not Show Profile Of that Email)

Offline tests

Tap profile -> General -> Troubleshoot
Enable Force offline
Tap on Create -> Split expense -> Scan
Add Receipt
Add Any Dummy Email ID and Link to That expense
Click On Added Email Profile (will Not Show Profile Of that Email)

QA Steps

Tap profile -> General -> Troubleshoot
Enable Force offline
Tap on Create -> Split expense -> Scan
Add Receipt
Add Any Dummy Email ID and Link to That expense
Click On Added Email Profile (will Not Show Profile Of that Email)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/68138940/59b46d2a-49d0-4d39-9e1d-277560f9d71c

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Desktop

I have read the CLA Document and I hereby sign the CLA


Minor changes

Changes made:

Clipped PD1 surrogates' results by metric's max bounds
Changed minimum fidelity values of MFHartmann, JAHSBench, PD1 imagenet and PD1 cifar100 to 1
Corrected surrogate names of PD1 cifar100 and PD1 translate_wmt
Changed jahs_bench.Benchmark(task=self.task_id) to (task=task)

Looks good.
Has this been tested with a clean download?

Hey, yes. I've run all tests and tested that the surrogates return valid values as well


Flutter

SteamDB app page links to a few games using this
https://steamdb.info/app/2495180/
https://steamdb.info/app/1858060/
https://steamdb.info/app/1918130/
https://steamdb.info/app/1229490/
https://steamdb.info/app/2550370/
https://steamdb.info/app/2009510/
Brief explanation of the change
Detect Flutter, a portable runtime and web engine.

seems like flutter_windows.dll isn't only used for the engine, it's also used for the SDK bc it matches https://steamdb.info/app/1229490/ which uses unity so that app doesn't use flutter engine, simply the sdk.
So putting this rule as a container seems wrong to me

After running changed rules in this pull request (this bot only tests rules.ini changes):
Changed technologies: Container.Flutter
These apps now match: (19)<PHONE_NUMBER>490 1858060 1918130 1933040 2009510 2253470 2285160 2341030 2414910 2484220 2484670 2495180 2533970 2550370 2550380 2716190 2717600 2839660
Please confirm that all these changed apps are correct.


Deploying WebApp with WebJob to virtual application not deploying webjobb correctly

I’m facing an issue when deploying my application to a virtual application that has webjobs associated with it using AzureRmWebAppDeployment. The webjob under the app_data folder is unpacked and deployed under the virtual application, but it should actually be moved one level up to the root, in order for it to be picked up and deployed as well.
Is this a known issue or could this be fixed somehow?

I'm also seeing issues with the WebApp WebDeploy.
My issue is not the same as yours, but it seems some rolling updates are causing issues.

Did you use Visual Studio to 'Add Existing Project as WebJob"?
This will install Microsoft.Web.WebJobs.Publish into the WebApp & Console App.
It will also create WebApp/Properties/webjobs-list.json & /Properties/webjobs.props
(.props in both Web & Console)
Not sure if that would solve your problem.
Perhaps the issue you are seeing is related to the new 2.0.1 version, which has been causing other issues like #2719

Can you please elaborate on what do you mean saying "to a virtual application"?
Deploying WebJobs to default location using the latest version of the task (2.0.2 I believe) works fine for us.

I used visual studio to add the webjob and it created all the mentioned files.
@abatishchev see the screenshot to what I mean by installing to a virtual application.

I see, I have blank line in that field.

Based on the responses in the thread, I am marking it closed. Feel free to re-open the issue if you need further assistance.

How can you close it based upon the comments. The issue is still not resolved. The deploy job is not deploying the WebJob correctly

I tried this right now and can confirm that it doesn't work to deploy WebJobs to a virtual application, while running the same release script and deploy to the root of another Azure WebSite works fine.

@gwendo, I believe @kmkumaran is referring to https://github.com/Microsoft/vsts-tasks/pull/2744#discussion_r81733928 ..
That said, fwiw, I'm not sure WebJobs outside the scope of deploying to the root of a site makes sense.
So deploying to a VirtualDirectory might simply be impossible. But if so, this should be called out explicitly by documentation.


Regex Options/Case Insensitive Comparison

I'd like to submit a pull request to allow case insensitive comparing in regex-based paths filters.  If you are open to this, there are two potential approaches I could submit for review:

I can add a regex_options string field that supports passing in any of the options supported for ngx.re.find
I can add a regex_case_insensitive boolean field that will just pass i to the call to ngx.re.find when it is true.

I do not have a strong opinion about the two approaches, although the regex_options approach allows more flexibility.  On the other than, regex_case_insensitive is much more straight-forward to understand and document.

push your merge  request

I reconsidered,
I think the path should follow lowercase and should not appear uppercase。
So support Case Insesitive is not a strong opinion


Remote Storage: string interner should not panic in release

Need to dig a bit more to find the call stack that lead to the panic but this will mean we don't panic at least.
@brian-brazil @beorn-
Signed-off-by: Callum Styan<EMAIL_ADDRESS>cc @tomwilkie

PTAL
cc @simonpasquier I needed the testutil package from client_golang, which wasn't already vendored.  Let me know if it doesn't look correct. I've noticed that our go.mod says that we're using client_golang at v0.9.3 for some commit even though the latest actual release was v0.9.2. I assume go mod updates the version in the files itself.

fixes #5480

I needed the testutil package from client_golang, which wasn't already vendored.

You wouldn't even need to go get .../client_golang as it was already present. Importing the testutil package and running go mod tidy/go mod vendor would have been enough to update the vendor directory.

I've noticed that our go.mod says that we're using client_golang at v0.9.3 for some commit even though the latest actual release was v0.9.2. I assume go mod updates the version in the files itself.

This is because we're referencing a commit after the last known tag, see https://tip.golang.org/cmd/go/#hdr-Pseudo_versions.

I'd like to make the interner and it's metric not package level variables but I'll do that later in another PR

Thanks!

Thank you very much !


[SPARK-37357][SQL] Create skew partition specs should respect min partition size

What changes were proposed in this pull request?

Make ShufflePartitionUtil.createSkewPartitionSpecs respect spark.sql.adaptive.coalescePartitions.minPartitionSize in case we get small reduce partition.
Why are the changes needed?

For example Rebalance provide a functionality that split the large reduce partition into smalls. However we have seen many SQL produce small files due to the last partition.
Let's say we have one reduce partition and six map partitions and the blocks are:
[10, 10, 10, 10, 10, 10]
If the target size is 50, we will get two files with 50 and 10. And it will get worse if there are thousands of reduce partitions.
It should be helpful if we can control the min partition size.
Does this PR introduce any user-facing change?

probably yes, the skew partition size may be changed.
How was this patch tested?

add test in

org.apache.spark.sql.execution.adaptive.AdaptiveQueryExecSuite
org.apache.spark.sql.execution.ShufflePartitionsUtilSuite

Test build #145340 has started for PR 34634 at commit 5f4f607.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49811/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49811/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49811/

Test build #145340 has finished for PR 34634 at commit 5f4f607.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145340/

cc @yaooqinn @cloud-fan @wangyum

I think you can work around this issue by setting spark.sql.adaptive.coalescePartitions.minPartitionSize to a higher number. By default it's 1mb.

Good reminder. We should respect minPartitionSize at skew partition side.

Test build #145389 has started for PR 34634 at commit ec76e4a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49862/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49862/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49862/

Test build #145397 has started for PR 34634 at commit a6ea23c.

Test build #145389 has finished for PR 34634 at commit ec76e4a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145389/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49870/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49870/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49870/

Test build #145397 has finished for PR 34634 at commit a6ea23c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145397/

Test build #145583 has started for PR 34634 at commit 7593140.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50056/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50056/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50056/

Test build #145583 has finished for PR 34634 at commit 7593140.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145583/

can you update the PR title?

updated the title and description

Test build #145601 has started for PR 34634 at commit e13f1fa.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50073/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50073/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50073/

Test build #145601 has finished for PR 34634 at commit e13f1fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145601/

thanks, merging to master!

thank you @cloud-fan


Failed to acquire token for client credentials..... was not found in the directory 'botframework.com'.

Getting the following error when sending
Failed to create conversation with teams user: 29:1PYk9BzSRAVKfbea2odcqVNW7MOqbmocfQzWYcKY2ZK5rqSSS8U_pN3ht8BXiRJVoCV-r8lXDDDA1mltsrazd3Q. Exception: Failed to acquire token for client credentials. (AADSTS700016: Application with identifier 'e0e02112-82a7-42a8-a4ad-8b792bbeass' was not found in the directory 'botframework.com'. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You may have sent your authentication request to the wrong tenant.
I tried everything that I can think of (ie. Resync Functions & App Service, double check that I followed the authentication setup correctly, double check the uploaded manifests in teams, regrant admin consent in API permissions for the registrations, double checked the configurations in the associated App Service).

Hi, I had the same issue. Please check your secret at the app registration and at your web bot configuration.

Solved this by deleting my app registrations and resource group..then reinstalling it again


cypress testing is not executed in the deploy

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
/d2wao2oyvt6nan
AWS Region
us-east-1
Amplify Hosting feature
E2E Cypress tests, Frontend builds
Describe the bug
We have an angular front-end hosted in aws amplify.
Recently we tried to add cypress e2e testing.
(using "ng add @cypress/schematic " in the proyect)
We create 3 tests inside the folder : "/cypress/e2e"
We followed this guide:
https://docs.aws.amazon.com/amplify/latest/userguide/running-tests.html
And deployed the app in amplify (using a git commit).
But, this doesnt work:

The compilation ends, but with no testing "stage". We read under it: "Test is still pending or has been cancelled for this build."
Expected behavior
We expect to see a execution of the e2e test and a "verify" tab with the results.
Reproduction steps

adding the suggested cypress configuration in the amplify.yml
deploying the app.

Build Settings
version: 0.1
frontend:
  phases:
    preBuild:
      commands:
        - npm install
        - npm ci
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: dist/cmsmedios-ux
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*
test:
  phases:
    preTest:
      commands:
        - npm ci
        - npm install wait-on
        - npm install pm2
        - npm install<EMAIL_ADDRESS>mochawesome mochawesome-merge mochawesome-report-generator
        - npx pm2 start npm -- start
        - 'npx wait-on --timeout 60 http://localhost:3000'
    test:
      commands:
        - 'npx cypress run --reporter mochawesome --reporter-options "reportDir=cypress/report/mochawesome-report,overwrite=false,html=false,json=true,timestamp=mmddyyyy_HHMMss"'
    postTest:
      commands:
        - npx mochawesome-merge cypress/report/mochawesome-report/mochawesome*.json > cypress/report/mochawesome.json
        - npx pm2 kill
  artifacts:
    baseDirectory: cypress
    configFilePath: '**/mochawesome.json'
    files:
      - '**/*.png'
      - '**/*.mp4'

Log output

# Put your logs below this line

Provision:
-----------------

# Use the standard Amazon Linux base, provided by ECR/KaOS
# It points to the standard shared Amazon Linux image, with a versioned tag.

                                 You are in 'detached HEAD' state. You can look around, make experimental
                                 changes and commit them, and you can discard any commits you make in this
                                 state without impacting any branches by switching back to a branch.
                                 If you want to create a new branch to retain commits you create, you may
                                 do so (now or later) by using -c with the switch command. Example:
                                 git switch -c <new-branch-name>
                                 Or undo this operation with:
                                 git switch -
                                 Turn off this advice by setting config variable advice.detachedHead to false
                                 HEAD is now at d3b5c70e Merge pull request #2228 from hmarsili/roma-mdf
2023-01-12T19:19:27.934Z [INFO]: Successfully cleaned up Git credentials
2023-01-12T19:19:27.934Z [INFO]: # Checking for Git submodules at: /codebuild/output/src335772648/src/cmsmedios-ux/.gitmodules
2023-01-12T19:19:27.949Z [INFO]: # Retrieving environment cache...
2023-01-12T19:19:28.462Z [INFO]: # Retrieved environment cache
2023-01-12T19:19:28.462Z [INFO]: ---- Setting Up SSM Secrets ----
2023-01-12T19:19:28.462Z [INFO]: SSM params {"Path":"/amplify/d2wao2oyvt6nan/2FA/","WithDecryption":true}
2023-01-12T19:19:28.498Z [WARNING]: !Failed to set up process.env.secrets
2023-01-12T19:19:40.506Z [INFO]: # Node version 14 is available for installation
2023-01-12T19:19:40.605Z [INFO]: # Installing Node version 14
2023-01-12T19:19:48.057Z [INFO]: # Now using Node version 14
2023-01-12T19:19:48.141Z [INFO]: # Retrieving cache...
2023-01-12T19:19:56.604Z [INFO]: # Extracting cache...
2023-01-12T19:20:05.500Z [INFO]: # Extraction completed
2023-01-12T19:20:05.663Z [INFO]: # Retrieved cache

==========================
Front end:
--------------------

2023-01-12T19:20:08.401Z [INFO]: # Starting phase: preBuild
                                 # Executing command: npm install
2023-01-12T19:20:31.576Z [WARNING]: npm notice created a lockfile as package-lock.json. You should commit this file.
2023-01-12T19:20:31.587Z [WARNING]: npm
2023-01-12T19:20:31.587Z [WARNING]: WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
2023-01-12T19:20:31.595Z [WARNING]: npm
2023-01-12T19:20:31.595Z [WARNING]: WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^6.0.0 but none is installed. You must install peer dependencies yourself.
2023-01-12T19:20:31.604Z [WARNING]: npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^6.0.0 but none is installed. You must install peer dependencies yourself.
2023-01-12T19:20:31.610Z [WARNING]: npm
2023-01-12T19:20:31.610Z [WARNING]: WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
2023-01-12T19:20:31.617Z [WARNING]: npm WARN
2023-01-12T19:20:31.617Z [WARNING]<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><10.0.0 || >9.0.0-beta <10.0.0 || >9.1.0-beta <10.0.0 || >9.2.0-beta <10.0.0 but none is installed. You must install peer dependencies yourself.
2023-01-12T19:20:31.626Z [WARNING]: npm WARN
2023-01-12T19:20:31.626Z [WARNING]<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><10.0.0 || >9.0.0-beta <10.0.0 || >9.1.0-beta <10.0.0 || >9.2.0-beta <10.0.0 but none is installed. You must install peer dependencies yourself.
2023-01-12T19:20:31.626Z [WARNING]:
2023-01-12T19:20:31.627Z [INFO]: added 2 packages from 2 contributors, updated 2 packages and audited 1250 packages in 22.905s
2023-01-12T19:20:32.023Z [INFO]: 100 packages are looking for funding
                                 run `npm fund` for details
2023-01-12T19:20:32.023Z [INFO]: found 49 vulnerabilities (3 low, 6 moderate, 35 high, 5 critical)
                                 run `npm audit fix` to fix them, or `npm audit` for details
2023-01-12T19:20:32.063Z [INFO]: # Executing command: npm ci
2023-01-12T19:20:32.406Z [WARNING]: npm
2023-01-12T19:20:32.407Z [WARNING]: WARN
2023-01-12T19:20:32.407Z [WARNING]: prepare removing existing node_modules/ before installation
2023-01-12T19:20:57.631Z [INFO]: ><EMAIL_ADDRESS>install /codebuild/output/src335772648/src/cmsmedios-ux/node_modules/nice-napi
                                 > node-gyp-build
2023-01-12T19:20:57.781Z [INFO]: ><EMAIL_ADDRESS>postinstall /codebuild/output/src335772648/src/cmsmedios-ux/node_modules/esbuild
                                 > node install.js
2023-01-12T19:20:57.852Z [INFO]: ><EMAIL_ADDRESS>postinstall /codebuild/output/src335772648/src/cmsmedios-ux/node_modules/core-js
                                 > node -e "try{require('./postinstall')}catch(e){}"
2023-01-12T19:20:57.901Z [INFO]: Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
                                 The project needs your help! Please consider supporting of core-js:
                                 > https://opencollective.com/core-js
                                 > https://patreon.com/zloirock
                                 > https://paypal.me/zloirock
                                 > bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz
                                 Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)
2023-01-12T19:20:58.122Z [INFO]: ><EMAIL_ADDRESS>postinstall /codebuild/output/src335772648/src/cmsmedios-ux/node_modules/cypress
                                 > node index.js --exec install
2023-01-12T19:20:58.621Z [INFO]: Installing Cypress (version: 12.3.0)
2023-01-12T19:20:58.621Z [INFO]:
2023-01-12T19:20:58.624Z [INFO]: [STARTED] Task without title.
2023-01-12T19:21:00.958Z [INFO]: [SUCCESS] Task without title.
2023-01-12T19:21:00.960Z [INFO]: [STARTED] Task without title.
2023-01-12T19:21:06.362Z [INFO]: [SUCCESS] Task without title.
2023-01-12T19:21:06.366Z [INFO]: [STARTED] Task without title.
2023-01-12T19:21:06.381Z [INFO]: [SUCCESS] Task without title.
2023-01-12T19:21:07.383Z [INFO]: You can now open Cypress by running: node_modules/.bin/cypress open
2023-01-12T19:21:07.383Z [INFO]: https://on.cypress.io/installing-cypress
2023-01-12T19:21:07.552Z [INFO]: ><EMAIL_ADDRESS>postinstall /codebuild/output/src335772648/src/cmsmedios-ux/node_modules/@angular/cli
                                 > node ./bin/postinstall/script.js
2023-01-12T19:21:07.925Z [INFO]: added 1246 packages in 35.534s
2023-01-12T19:21:07.946Z [INFO]: # Completed phase: preBuild
                                 # Starting phase: build
                                 # Executing command: npm run build
2023-01-12T19:21:08.125Z [INFO]: ><EMAIL_ADDRESS>build /codebuild/output/src335772648/src/cmsmedios-ux
                                 > npm run config -- --environment=prod && ng build --aot --configuration production
2023-01-12T19:21:08.302Z [INFO]: ><EMAIL_ADDRESS>config /codebuild/output/src335772648/src/cmsmedios-ux
                                 > ts-node ./scripts/setenv.ts "--environment=prod"
2023-01-12T19:21:09.885Z [INFO]: SE ESCRIBIÓ VARIABLES PARA:  ./src/environments/environment.prod.ts
2023-01-12T19:21:12.361Z [WARNING]: - Generating browser application bundles (phase: setup)...
2023-01-12T19:21:14.201Z [WARNING]: Warning: Entry point '@ckeditor/ckeditor5-angular' contains deep imports into '/codebuild/output/src335772648/src/cmsmedios-ux/node_modules/@ckeditor/ckeditor5-watchdog/src/editorwatchdog'. This is probably not a problem, but may cause the compilation of entry points to be out of order.
2023-01-12T19:21:14.202Z [WARNING]: Processing legacy "View Engine" libraries:
2023-01-12T19:21:14.708Z [WARNING]: - @ngx-translate/core [es2015/esm2015] (git+https://github.com/ngx-translate/core.git)
2023-01-12T19:21:15.372Z [WARNING]: - ngx-toastr [es2015/esm2015] (scttcper/ngx-toastr)
2023-01-12T19:21:16.278Z [WARNING]: - ngx-loaders-css [es2015/esm2015] (https://github.com/t7yang/ngx-loaders-css.git)
2023-01-12T19:21:16.983Z [WARNING]: - @ngx-translate/http-loader [es2015/esm2015] (git+https://github.com/ngx-translate/http-loader.git)
2023-01-12T19:21:17.456Z [WARNING]: - ngx-select-ex [es2015/esm2015] (git+ssh://git@github.com:optimistex/ngx-select-ex.git)
2023-01-12T19:21:18.252Z [WARNING]: - @techiediaries/ngx-qrcode [es2015/esm2015] (https://github.com/techiediaries/ngx-qrcode)
2023-01-12T19:21:18.539Z [WARNING]: - ng2-charts [es2015/esm2015] (git+https://github.com/valor-software/ng2-charts.git)
2023-01-12T19:21:18.556Z [WARNING]: - @ckeditor/ckeditor5-angular [es2015/esm2015] (https://github.com/ckeditor/ckeditor5-angular.git)
2023-01-12T19:21:18.591Z [WARNING]: - angular-cropperjs [es2015/esm2015] (https://github.com/matheusdavidson/angular-cropperjs)
2023-01-12T19:21:19.239Z [WARNING]: Encourage the library authors to publish an Ivy distribution.
2023-01-12T19:23:49.934Z [WARNING]: ✔ Browser application bundle generation complete.
2023-01-12T19:23:49.941Z [WARNING]: ✔ Browser application bundle generation complete.
2023-01-12T19:23:49.947Z [WARNING]: - Copying assets...
2023-01-12T19:23:49.983Z [WARNING]: ✔ Copying assets complete.
2023-01-12T19:23:49.983Z [WARNING]: - Generating index html...
2023-01-12T19:23:50.729Z [WARNING]: - Generating index html...
2023-01-12T19:23:50.729Z [WARNING]: 1 rules skipped due to selector errors:
                                    .custom-file-input:lang(en)~.custom-file-label -> unmatched pseudo-class :lang
2023-01-12T19:23:50.730Z [WARNING]: ✔ Index html generation complete.
2023-01-12T19:23:50.730Z [WARNING]: - Generating service worker...
2023-01-12T19:23:50.818Z [WARNING]: ✔ Service worker generation complete.
2023-01-12T19:23:50.825Z [INFO]: Initial Chunk Files           | Names                                                                |  Raw Size | Estimated Transfer Size
                                 main.a8daac597a362de9.js      | main                                                                 |   5.29 MB |                 1.03 MB
                                 styles.65de2da46e6fa215.css   | styles                                                               | 615.52 kB |                66.83 kB
                                 scripts.386f624b4d4f2be1.js   | scripts                                                              |  91.84 kB |                29.64 kB
                                 polyfills.d26b32b9cb8a4a54.js | polyfills                                                            |  36.23 kB |                11.48 kB
                                 runtime.33f7b58a692c98ef.js   | runtime                                                              |   3.52 kB |                 1.69 kB
                                 | Initial Total                                                        |   6.01 MB |                 1.13 MB
                                 Lazy Chunk Files              | Names                                                                |  Raw Size | Estimated Transfer Size
                                 107.2396a80a724f6d57.js       | admin-admin-module                                                   |   2.05 MB |               196.98 kB
                                 263.d0fa6def4602f07e.js       | components-pages-post-post-module                                    | 723.50 kB |                65.13 kB
                                 222.60c7f1716cbd80fb.js       | components-pages-change-password-change-password-module              | 675.39 kB |                57.48 kB
                                 259.ddf81d0de2542254.js       | components-pages-login-login-module                                  | 675.14 kB |                57.56 kB
                                 772.ced7370da495e109.js       | components-pages-recover-password-recover-password-module            | 674.09 kB |                56.92 kB
                                 152.5b54360ca056d552.js       | components-pages-password-locked-password-locked-module              | 673.87 kB |                56.79 kB
                                 912.598e9ed1fbc769de.js       | security-security-module                                             | 671.84 kB |                56.34 kB
                                 79.47bb9907e5a89a93.js        | admin-components-pages-new-post-new-post-module                      | 597.50 kB |                87.70 kB
                                 938.4c3b3c7e8cf4b985.js       | components-pages-post-post-module                                    | 207.42 kB |                38.24 kB
                                 258.2ddd4ff2e5e543cb.js       | components-pages-images-images-module                                | 124.00 kB |                24.04 kB
                                 537.26bcf3db81b646fd.js       | components-pages-videos-videos-module                                |  93.54 kB |                19.03 kB
                                 654.2d04869337041540.js       | security-components-pages-mdf-authenticator-mdf-authenticator-module |  69.13 kB |                17.62 kB
                                 101.d979421154fa08f3.js       | components-two-factory-two-factory-module                            |  45.71 kB |                 7.74 kB
                                 575.1df46179b843d726.js       | components-pages-tags-tags-module                                    |  44.11 kB |                 9.02 kB
                                 82.ad142f83908be267.js        | components-pages-contributions-contributions-module                  |  44.01 kB |                 8.86 kB
                                 503.8d947a5bdc36550c.js       | components-pages-polls-polls-module                                  |  43.06 kB |                 9.96 kB
<PHONE_NUMBER>3e0216b0d.js       | admin-components-pages-new-post-new-post-module                      |  37.08 kB |                 8.14 kB
                                 317.c0650ce472cbc2bf.js       | components-pages-zones-zone-module                                   |  32.88 kB |                 7.40 kB
                                 956.aca88131eef00e69.js       | components-pages-contributions-contributions-module                  |  32.31 kB |                 7.06 kB
                                 883.98cc9c25664ee757.js       | components-pages-profile-profile-module                              |  26.15 kB |                 6.42 kB
                                 296.5e714e36a1489c4b.js       | components-pages-recipes-recipes-module                              |  22.50 kB |                 5.67 kB
                                 200.558dd79e7c024921.js       | components-pages-people-people-module                                |  17.14 kB |                 4.64 kB
                                 268.dafd4fa6779ba313.js       | components-pages-tags-tags-module                                    |  16.66 kB |                 4.59 kB
                                 232.74e9810eef73eb57.js       | components-pages-trivias-trivias-module                              |  13.48 kB |                 3.83 kB
                                 732.cc053d7cd17882df.js       | components-pages-post-post-module                                    |  12.40 kB |                 3.29 kB
                                 common.2c9e7c52c41cf7d4.js    | common                                                               |   5.18 kB |                 1.51 kB
                                 110.b85237208b12c45c.js       | components-pages-forgot-password-forgot-password-module              |   4.88 kB |                 1.63 kB
                                 901.14a74ba300709bdc.js       | components-pages-forgot-user-forgot-user-module                      |   4.78 kB |                 1.64 kB
                                 23.e498e2b576645df7.js        | admin-components-pages-edit-video-edit-video-module                  | 654 bytes |               338 bytes
                                 593.fbad782df1cb8e9b.js       | admin-components-pages-edit-image-edit-image-module                  | 641 bytes |               327 bytes
                                 241.c49ad6d35fc73c61.js       | admin-components-pages-new-poll-new-poll-module                      | 624 bytes |               315 bytes
                                 Build at: 2023-01-12T19:23:50.821Z - Hash: 5320e6cb8ebf061a - Time: 158320ms
2023-01-12T19:23:50.918Z [INFO]: # Completed phase: build
2023-01-12T19:23:50.921Z [INFO]: ## Build completed successfully
2023-01-12T19:23:50.922Z [INFO]: # Starting caching...
2023-01-12T19:23:50.935Z [INFO]: # Creating cache artifact...
2023-01-12T19:24:07.820Z [INFO]: # Created cache artifact
2023-01-12T19:24:07.951Z [INFO]: # Uploading cache artifact...
2023-01-12T19:24:12.301Z [INFO]: # Uploaded cache artifact
2023-01-12T19:24:12.463Z [INFO]: # Caching completed
2023-01-12T19:24:12.470Z [INFO]: # No custom headers found.
2023-01-12T19:24:12.519Z [INFO]: # Starting build artifact upload process...
2023-01-12T19:24:13.209Z [INFO]: # Uploading build artifact '__artifacts.zip'...
2023-01-12T19:24:13.249Z [INFO]: # Uploading build artifact '__artifactsHash.zip'...
2023-01-12T19:24:13.452Z [INFO]: # Build artifact upload completed
2023-01-12T19:24:13.452Z [INFO]: # Starting environment caching...
2023-01-12T19:24:13.452Z [INFO]: # Uploading environment cache artifact...
2023-01-12T19:24:13.535Z [INFO]: # Uploaded environment cache artifact
2023-01-12T19:24:13.536Z [INFO]: # Environment caching completed
Terminating logging...

=======================
Deploy:
-------------------------------------
2023-01-12T19:24:19 [INFO]: Beginning deployment for application d2wao2oyvt6nan, branch:2FA, buildId<PHONE_NUMBER>
2023-01-12T19:24:19 [INFO]: Got archive: 6636260 bytes
2023-01-12T19:24:21 [INFO]: Deployment complete

</details>

### Additional information

_No response_

Hi @vpode, apologies for the delay here. There is an amplify.yml file in the root of your repository and it doesn't include a test phase. The amplify.yml file is going to take precedence over the build commands that are defined in the console. This is why you have successful builds without the test phase completing.
To resolve this, you should either remove the amplify.yml file in your repository or update the file with the desired test phase.

Hi @hloriana,
Thanks for your answer.
I deleted the repository file and now the error message is different. A message box indicates "One or more tests have failed". I copy the error from the log:
2023-02-17T19:48:25.487Z [INFO]: # Executing command: npx wait-on --timeout 60 http://localhost:3000
2023-02-17T19:48:25.850Z [WARNING]: Error: Timed out waiting for: http://localhost:3000
at /codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/lib/wait-on.js:132:31
at doInnerSub (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:22:31)
at outerNext (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:17:70)
at OperatorSubscriber._this._next (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/OperatorSubscriber.js:33:21)
at OperatorSubscriber.Subscriber.next (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/Subscriber.js:51:18)
at AsyncAction.work (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/observable/timer.js:28:28)
at AsyncAction._execute (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncAction.js:79:18)
at AsyncAction.execute (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncAction.js:67:26)
at AsyncScheduler.flush (/codebuild/output/src951633968/src/cmsmedios-ux/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncScheduler.js:38:33)
at listOnTimeout (internal/timers.js:557:17)
2023-02-17T19:48:25.855Z [ERROR]: !!! Test execution failed, one or more tests are not passing

Hi @vpode 👋 , thanks for reaching out. I observed that the latest build (164) on your Amplify app d2wao2oyvt6nan has succeeded. If you are running into issues with Cypress tests, I'll recommend reviewing their troubleshooting guide and also any related issues on their GitHub repository.


[WIP] CORTX-29979: Support Node group as a failure domain during hare-motr configuration

TODO:
Currently using formula which is being used for node failure.
Need to come-up with formula for rack failure
Signed-off-by: Swapnil Gaonkar<EMAIL_ADDRESS>

Can one of the admins verify this patch?

Changes in the PR are no more required due to change in approach.


Add support for resetting a column to it's default value.

Problem
Given a column which has a default value; i.e.:
quantity   Int   @default(0)

Sometimes it is desirable to reset that column to it's default value.
Right now, I'm doing the following workaround:
prisma.$executeRaw`UPDATE "MyTable" SET "quantity" = DEFAULT WHERE "id" = ${id};`;

Suggested solution
It would be nice if Prisma supported this out of the box. For example:
prisma.myTable.update({ where: { id }, data: { quantity: prisma.$$default } });

Actually, this would be a more generic feature, allowing the use of any keyword or SQL function call within an update. For example:
UPDATE "MyTable" SET "startedAt" = CURRENT_TIMESTAMP WHERE "id" = 1;
UPDATE "MyTable" SET "startedAt" = NOW() WHERE "id" = 1;


Added Swiftful Thinking and DesignCode to the list

Added two new YouTube channels.

Swiftful Thinking: This YouTube channel helps you to learn about SwiftUI related thinks

DesignCode: This channel helps you to build complex user interface in SwiftUI

Thank you!


Support image filtration by objects

I think it would be useful to allow intersection operation outside square brackets in filters, similar to what we can do with the union operator |
Example of what I mean:
objectA & objectB & objectC[attr/status="valid"]
This filter would ignore all images in which objectC is not present or does not have the "valid" status. However, for such images it would display objectC as well as objectA and objectB

I will close the issue as outdated. Filters were significantly redesigned.

https://openvinotoolkit.github.io/cvat/docs/manual/advanced/filter/


[QUESTION] How to properly set colors in Neovim?

Description
Reproduction steps
Hello, I'm using it with Neovim 0.10 and the colors look a bit odd:

So how can I set the colors instead of that black background? Is there anything I need to modify to make it use theme colors?

Start the Ruby LSP using a certain editor
Open a Ruby file
Do something
See unexpected behavior

Code snippet or error message

Thank you so much, @KaanOzkan 🎆

The image above relates to the following section for catppuccin neovim theme:
custom_highlights = function(colors)
        return {
          -- ColorColumn = { bg = colors.flamingo },
          Pmenu = { bg = colors.mantle, fg = colors.overlay2 },
          PmenuSel = { bg = colors.surface1, style = { "bold" } }, -- Popup menu: selected item.
          PmenuSbar = { bg = colors.surface1 },                    -- Popup menu: scrollbar.
          PmenuThumb = { bg = colors.overlay0 },                   -- Popup menu: Thumb of the scrollbar.
          NormalFloat = { bg = colors.crust, fg = colors.text },
        }
      end,


Allow nvm to use latest Node.js LTS ‘Gallium’ versions

This PR updates .nvmrc to use LTS aliases lts/gallium rather than version numbers
What's the problem?
We're seeing issues running npm link to add a locally-installed govuk-frontend into a new prototype
This is because Node.js version managers like nvm partition globally installed (and linked) packages, by Node version, into an npm get prefix prefixed directory:
{prefix}/lib/node_modules/<package>

When preparing govuk-frontend for "linking" via npm link we will see a symbolic link added to one of many places, depending on the Node.js version set by .nvmrc config:
/Users/username/.nvm/versions/node/v16.18.0/lib/node_modules/govuk-frontend
/Users/username/.nvm/versions/node/v16.14.2/lib/node_modules/govuk-frontend
/Users/username/.nvm/versions/node/v16.16.0/lib/node_modules/govuk-frontend

lts/gallium → https://github.com/alphagov/govuk-frontend/blob/main/.nvmrc
16.14.2 → https://github.com/alphagov/govuk-design-system/blob/main/.nvmrc
16.16.0 → https://github.com/alphagov/govuk-prototype-kit/blob/v13/.nvmrc
What's the fix?

Temporarily align .npmrc in both projects each time we npm link
Or, ensure .nvmrc always uses LTS aliases like lts/gallium not version numbers

Note: For 1) we'll see EBADENGINE without also setting engine-strict=false as we've enabled stricter checks

Hey Colin, thanks for the PR.
I'm a little confused about why the .nvmrc file is causing EBADENGINE warnings with npm link, I don't see why npm would care about what is in that file... can you elaborate more?

Hey Colin, thanks for the PR.
I think this change makes sense, I'm just a little confused about why the .nvmrc file is causing EBADENGINE warnings with npm link, I don't see why npm would care about what is in that file... can you elaborate more?

No problem, updated the description @lfdebrux

Thanks for the more detailed description @colinrotherham. While I understand your use case, I am a little worried about the requirement for the Node version used by the Design System team and Prototype Kit team to be coupled. To be more specific, we're about to start recommending our users run the kit with Node 18, as that is soon going to be the current LTS; would you be happy to update the GOV.UK Frontend .nvmrc files to match?

@lfdebrux That sounds perfect

@lfdebrux That sounds perfect

Cool. Thinking about it further, because for us new users will always be using the latest LTS, we should probably be doing the same, so maybe the .nvmrc file should just read lts/*. Would you be happy to update this PR to that?

@lfdebrux I like the idea, won't package.json engines (at some point) get out of sync and chuck warnings?

@lfdebrux I like the idea, won't package.json engines (at some point) get out of sync and chuck warnings?

Yes, but we want that. If that happens to us it will happen to users too.

@lfdebrux I like that. Updated and pushed 👍
I've removed the GitHub Action node-version-file: .nvmrc suggested change. Your workflow might pass on Node.js 18 but then fail when deployed to a Node.js 16 Heroku stack

Update now https://github.com/alphagov/govuk-frontend/pull/2939, https://github.com/alphagov/govuk-prototype-kit/pull/1712 and https://github.com/alphagov/govuk-design-system/pull/2399 are merged:
lts/gallium → https://github.com/alphagov/govuk-frontend/blob/main/.nvmrc
lts/gallium → https://github.com/alphagov/govuk-design-system/blob/main/.nvmrc
lts/* → https://github.com/alphagov/govuk-prototype-kit/blob/v13/.nvmrc
Once development environments are upgraded, package.json engines field changed, GitHub workflows bumped up, tests pass (and Heroku stacks upgraded to match) etc we may also want the lts/* alias everywhere


[Runtime] NULL check shared cache calls.

Avoid a dynamic linker failure if the calls aren't available at runtime.
rdar://74965969

@swift-ci please test

LGTM

Build failed
Swift Test OS X Platform
Git Sha - 118d1708a7d1a203440e46c11ac6a85382ff5c72

Is the null check considered an availability check by the compiler? I'm thinking that the compile might fail if the API has availability annotations and we build for an older deployment target.

@swift-ci smoke test macOS

@fredriss Good thinking. A quick test here shows that it still produces a warning when guarded with a NULL check. In fact, it produces two warnings, because the NULL check also warns about availability! I'll switch it to do a proper version check.

Updated to wrap the call in a __builtin_available check.

@swift-ci please test


I made auto installer. However gradio app using more than 24 GB vram and animate_dist giving below error

I made an auto installer script and it works on Windows 10 python 3.10.11
I am trying gradio_animate.py and it is using ridiculously more than 24 GB VRAM
when your pre shared motion sequence used it works
https://github.com/magic-research/magic-animate/assets/19240467/8cfef26b-63c2-42b5-8a36-38b1e28c3865
When I try to below video no matter what it gives out of VRAM error on my RTX 3090 machine
https://github.com/magic-research/magic-animate/assets/19240467/2a7d5814-6c8f-4723-85f1-1649376866cf
So I tried to run gradio_animate_dist.py but it is giving below error no matter what. I even fixed pathing errors
To create a public link, set `share=True` in `launch()`.
Traceback (most recent call last):
  File "G:\magic_animate\magic-animate\venv\lib\site-packages\gradio\routes.py", line 488, in run_predict
    output = await app.get_blocks().process_api(
  File "G:\magic_animate\magic-animate\venv\lib\site-packages\gradio\blocks.py", line 1434, in process_api
    data = self.postprocess_data(fn_index, result["prediction"], state)
  File "G:\magic_animate\magic-animate\venv\lib\site-packages\gradio\blocks.py", line 1335, in postprocess_data
    prediction_value = block.postprocess(prediction_value)
  File "G:\magic_animate\magic-animate\venv\lib\site-packages\gradio\components\video.py", line 281, in postprocess
    processed_files = (self._format_video(y), None)
  File "G:\magic_animate\magic-animate\venv\lib\site-packages\gradio\components\video.py", line 355, in _format_video
    video = self.make_temp_copy_if_needed(video)
  File "G:\magic_animate\magic-animate\venv\lib\site-packages\gradio\components\base.py", line 226, in make_temp_copy_if_needed
    temp_dir = self.hash_file(file_path)
  File "G:\magic_animate\magic-animate\venv\lib\site-packages\gradio\components\base.py", line 190, in hash_file
    with open(file_path, "rb") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'G:\\magic_animate\\magic-animate\\demo\\demo\\outputs\\2023-12-05T04-34-44.mp4'

here the fixed gradio_animate_dist.py
import argparse
import imageio
import os, datetime
import numpy as np
import gradio as gr
from PIL import Image
from subprocess import PIPE, run

base_dir = os.path.dirname(os.path.abspath(__file__))
demo_dir = os.path.join(base_dir, "demo")
tmp_dir = os.path.join(demo_dir, "tmp")
outputs_dir = os.path.join(demo_dir, "outputs")

os.makedirs(tmp_dir, exist_ok=True)
os.makedirs(outputs_dir, exist_ok=True)

def animate(reference_image, motion_sequence, seed, steps, guidance_scale):
    time_str = datetime.datetime.now().strftime("%Y-%m-%dT%H-%M-%S")
    animation_path = os.path.join(outputs_dir, f"{time_str}.mp4")
    save_path = os.path.join(tmp_dir, "input_reference_image.png")
    Image.fromarray(reference_image).save(save_path)
    command = f"python -m demo.animate_dist --reference_image {save_path} --motion_sequence {motion_sequence} --random_seed {seed} --step {steps} --guidance_scale {guidance_scale} --save_path {animation_path}"
    run(command, stdout=PIPE, stderr=PIPE, universal_newlines=True, shell=True)
    return animation_path

with gr.Blocks() as demo:

    gr.HTML(
        """

MagicAnimate: Temporally Consistent Human Image Animation using Diffusion Model

If you like our project, please give us a star ✨ on Github for the latest update.

        """
    )
    animation = gr.Video(format="mp4", label="Animation Results", autoplay=True)

    with gr.Row():
        reference_image  = gr.Image(label="Reference Image")
        motion_sequence  = gr.Video(format="mp4", label="Motion Sequence")

        with gr.Column():
            random_seed         = gr.Textbox(label="Random seed", value=1, info="default: -1")
            sampling_steps      = gr.Textbox(label="Sampling steps", value=25, info="default: 25")
            guidance_scale      = gr.Textbox(label="Guidance scale", value=7.5, info="default: 7.5")
            submit              = gr.Button("Animate")

    def read_video(video, size=512):
        size = int(size)
        reader = imageio.get_reader(video)
        frames = []
        for img in reader:
            frames.append(np.array(Image.fromarray(img).resize((size, size))))

        save_path = os.path.join(tmp_dir, "input_motion_sequence.mp4")
        imageio.mimwrite(save_path, frames, fps=25)
        return save_path

    def read_image(image, size=512):
        img = np.array(Image.fromarray(image).resize((size, size)))
        return img

    # when user uploads a new video
    motion_sequence.upload(
        read_video,
        motion_sequence,
        motion_sequence
    )
    # when `first_frame` is updated
    reference_image.upload(
        read_image,
        reference_image,
        reference_image
    )
    # when the `submit` button is clicked
    submit.click(
        animate,
        [reference_image, motion_sequence, random_seed, sampling_steps, guidance_scale],
        animation
    )

    # Examples
    gr.Markdown("## Examples")
    gr.Examples(
        examples=[
            ["inputs/applications/source_image/monalisa.png", "inputs/applications/driving/densepose/running.mp4"],
        ],
        inputs=[reference_image, motion_sequence],
        outputs=animation,
    )

demo.launch(share=False,inbrowser=True)

It runs without any problems on a 3060 video card.  I never got an error message.

animation_path

are you able to provide raw video? when I provide raw video I get out vram error
when I use pre shared motion sequence it works

Both startup methods worked for me. I never got an error message.

did you see my message? can you try with this input video and input image
https://github.com/magic-research/magic-animate/assets/19240467/3940a67e-3bd3-4a60-bd33-4adff501d9b0

ok looks like we have to generate DensePose  video ourselves
i will update patreon post and add scripts to make that
i wish your repo had already that automatically

Hi everyone, thanks for your interest. You can refer to #18 for generating your own DensePose seuqnces.


Fix Gumshoe related JavaScript error on pages without a TOC

This is a bug fix.
Summary
I've wrapped Gumshoe in an if statement. This prevents a console error on pages without a TOC.
The console error occurred when you scroll to the bottom of a page without a TOC.

Thanks for discovering and fixing this bug @Jeckari.


vgg model fine-tune problem

The code directly use the model download from the internet. If fine-tune the model by CelebA data, the generated image maybe much better, I guess.
Have you tried to train the vgg model yourself?

Hey,
Great question. I did not try to train the vgg model myself. I don't know how much gain you would get by doing this yourself...
The content loss idea is that you measure how much a network trained to see "things" sees things differently between the original image and you generated image.... On what task would you train the VGG model if you would train it yourself?


M3-1665 Show maintenance notifications on Dashboard

Coverage increased (+0.08%) to 32.02% when pulling<PHONE_NUMBER>195997ccf89487b13f8b19ebd4df69 on johnwcallahan:M3-1665 into 778ca06739608b7a772253e83bd741df28d94fd6 on linode:develop.


Rework copy/paste widget

Description
Let's simplify the copy/paste widget and avoid non solicited Host clipboard modification.
This will just represent the device clipboard and user will just copy/paste onto it or modify it freely.
We might rework the widget later, but this will help users understand its mechanism.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I've read & comply with the contributing guidelines
[ ] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
[ ] I have made corresponding changes to the documentation (README.md).
[x] I've checked my modifications for any breaking changes.

We could deploy the saas webapp to use this branch in order to test on SaaS


table response

Mobile device table response style scheme should be included in the framework
At present, the form CSS in the framework cannot support the form response
My own table response scheme doesn't work well with the framework

The library solution should satisfy most needs. At the moment I do not have such a solution. You can use the data-horizontal-scroll and data-horizontal-scroll-stop attributes to create horizontal scrolling of the table under given conditions.


SQL CRUD & OTHER ISSUES

ISSUES:

we don't have a field for activity in the Invitation table yet
we need a field in the Event table that stores if the event is archived or not, and one that stores if the event is active or not (its date passed or not)
will the events be automatically archived after some days? probably yes. still thinking of that.

SQL CRUD:
MAKE STORED PROCEDURES FOR:
GET:

[x] all events
[ ] event by event id
[ ] events created by a user
[ ] events
[ ] invitations for a user
[ ] invitations sent by a user
[ ] requests for an event
[ ] requests sent by a user

INSERT:

[ ] event
[ ] invitation
[ ] request
[ ] city
[ ] user city
[ ] place
[ ] event participant
[ ] comment

UPDATE:

[ ] event
[ ] invitation status (Accepted)
[ ] invitation IsActive field(for the ability to cancel it). Note: see issue 1
[ ] event IsActive field(in the app it will be updated automatically when the date passes). Note: see issue 2
[ ] event IsArchived field(that will allow users archive their events so they don't show on the explore page). Note: see issue 3
[ ] comment (probably editing comments won't be available in V1 but it's good to have it there)

I can work on this issue, if you want to assign it to me.


Limited redis connection possibilities

First of all, thank you for open sourcing this!
I am a bit sceptical about limiting the user to pass in a redis_host and redis_port.
It does not allow for using a different database than /0, or supplying a password, for instance.
If one could pass in a redis connection string, that would in itself open up for more possibilities for the redis connection, otherwise, mirroring its args in the constructor is another option.

Hi, thanks for your suggestion.
It's been a while since I checked on this project.
I will keep this in mind when I am updating the repo.
Also, You are welcome if you want to make a pull request.


VSCode extension / Color theme: differentiate enum name and key

This is how enum.key looks in the theme now:

i.e. both white. However, the should be different like in other themes:
"Dark Modern":

"Monokai":

"Solarized Dark":

I'm not able to reproduce this it shows up like this for me:

That's strange. Let me do additional checks.

Fixed! It will appear the same as a normal property in version 3.5.2


Add video utils

Fixed Issues
$ https://github.com/Expensify/App/pull/30829/files/2c877a1a00930148b6b2c468d8beb3661fb0dcff#r1465658915
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?

QA

What does QA need to do to validate your changes?
What areas to they need to test for regressions?

I have read the CLA Document and I hereby sign the CLA

Small lint errors, otherwise looks good.


Spread assumed_state love

This weekend we added support for assumed states in #1247. This is made available to any entity via the assumed_state property.
The frontend has been updated to support this for any entity that used to be toggled (blue color indicates the state we assume it is).

Assumed states are currently only implemented by the demo switch. It is not being used by platforms or components, yet.
These are the components that I can think of of the top of my head that support should be added to:

[ ] Group should have assumed_state = True if any child state is assumed
[ ] MQTT Light should have assumed_state = True if optimistic
[ ] MQTT Switch should have assumed_state = True if optimistic

If you're going to add this to your platforms, please also add the ha_iot_class: "Assumed State" to your documentation on the website (example)

Can this property be set via the customization of functionality?
mån 15 feb. 2016 10:14 Paulus Schoutsen<EMAIL_ADDRESS>skrev:

This weekend we added support for assumed states in #1247
https://github.com/balloob/home-assistant/pull/1247. This is made
available to any entity via the assumed_state
https://github.com/balloob/home-assistant/blob/dev/homeassistant/helpers/entity.py#L119-L122
property.
The frontend has been updated to support this for any entity that used to
be toggled (blue color indicates the state we assume it is).
[image: screen shot 2016-02-15 at 1 01 34]
https://cloud.githubusercontent.com/assets/1444314/13043978/63e90bbc-d380-11e5-8b22-7a9903a0a935.png
Assumed states are currently only implemented by the demo switch. It is
not being used by platforms or components, yet.
These are the components that I can think of of the top of my head that
support should be added to:

Group should have assumed_state = True if any child state is assumed
MQTT Light should have assumed_state = True if optimistic
MQTT Switch should have assumed_state = True if optimistic

If you're going to add this to your platforms, please also add the ha_iot_class:
"Assumed State" to your documentation on the website (example
https://raw.githubusercontent.com/balloob/home-assistant.io/master/source/_components/light.limitlessled.markdown
)
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/1263.

Yes, it's just an attribute like anything else
On Mon, Feb 15, 2016, 07:15 Stefan Jonasson<EMAIL_ADDRESS>wrote:

Can this property be set via the customization of functionality?
mån 15 feb. 2016 10:14 Paulus Schoutsen<EMAIL_ADDRESS>skrev:

This weekend we added support for assumed states in #1247
https://github.com/balloob/home-assistant/pull/1247. This is made
available to any entity via the assumed_state
<
https://github.com/balloob/home-assistant/blob/dev/homeassistant/helpers/entity.py#L119-L122
property.
The frontend has been updated to support this for any entity that used to
be toggled (blue color indicates the state we assume it is).
[image: screen shot 2016-02-15 at 1 01 34]
<
https://cloud.githubusercontent.com/assets/1444314/13043978/63e90bbc-d380-11e5-8b22-7a9903a0a935.png
Assumed states are currently only implemented by the demo switch. It is
not being used by platforms or components, yet.
These are the components that I can think of of the top of my head that
support should be added to:

Group should have assumed_state = True if any child state is assumed
MQTT Light should have assumed_state = True if optimistic
MQTT Switch should have assumed_state = True if optimistic

If you're going to add this to your platforms, please also add the
ha_iot_class:
"Assumed State" to your documentation on the website (example
<
https://raw.githubusercontent.com/balloob/home-assistant.io/master/source/_components/light.limitlessled.markdown
)
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/1263.

—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/1263#issuecomment-184249775
.


GUI Real time Filters

Dear team ,
Is there a GUI filter for dates - log files hostnames ?

It will be able available soon. I'm working on #117 as we speak. Stay tuned!

Closing this. Stay tuned for this feature.


Add box shadows

Fixes: #13

Let's worry about border compensation as we merge borders, shouldn't be too hard, and we need to support shadows without borders anyway

Q: why the increased complexity over the initial stencil buffer implementation in the https://github.com/WillPower3309/swayfx/pull/64?

Good point! I'll simplify the stencil init function :)


Fixed Sugarizer issue #414: Add a fullscreen button in ColorMyWorld activity

Added Fullscreen and Unfull Screen button


api: dont accept two soc's with the same address

SOCs are not content addressed, therefore SOCs with different content addressed chunks in their payload can result in the same SOC address.
This PR adds a check in the API, to verify that a chunk with the same address does not exist in the localstore before inserting it.
addresses #1247

@janos having a lock inside the API does not necessarily mitigate the data race completely no? As it might potentially be put from another source. So if I understand correctly we might need a new ModePut here to do the check in localstore during the Put, and avoid the Has call altogether.

Yes, the lock would protect this case in this handler. This goes along with this PR changeset only addressing the problem in the handler. Basically, this PR adds a check in the handler, and my comment is about the completeness of that approach only within the scope of solution here. As you suggested, a Put that would prevent overwrite would be a more general solution, and probably more correct and safer.

@janos I started updating the PR to have a new mode for putting an soc, but then realised we lose the ability to support upload and atomically pin a chunk. socs will require two calls to upload and pin and I feel that this is a deviation from the current API. I am leaning towards keeping this solution, as it is good enough for now. If a client chooses to put two same soc chunks then this is a bit of an edge case and maybe for now with our current design supporting more might be a bit more difficult. Would be happy for your opinion

This PR is ready for review, but not connected to an issue. The issue which belongs to the PR is still in the needs confirmation pipeline. Please properly manage your issues.


Label the Images

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images

Fixed in 1.9.1-3.11-1.


when moving the tjaplayer3 window from first screen to the second one it crashes.

as the title says, can't use it on second screen in a multi screen environment.

I'm afraid this is a long-standing issue with TJAPlayer (both 3 and earlier/later forks) which won't be addressed without someone wanting to take on a significant overhaul of its graphics subsystem. There is a partial workaround which might work for you, however:
If you open the Config.ini file you can manually set the window location, width, and height in order to place TJAPlayer3 onto the screen you prefer.


Different style/design needed for namespace selector masthead

as discussed here:
https://github.com/kiali/kiali-ui/pull/870
cc @serenamarie125

Mary's proposals can be found here: https://redhat.invisionapp.com/share/DZPMB5ZA6HT#/screens/337090340

I am completely out of this issue and probably my comment can miss some context but in this approach

It is not better to put all the controls on same level as namespace to adjust better the layout ?
I mean the namespace control is great, but there are a lot of space for more controls at same level.

@lucasponce afaik the pattern of namespace separate control is because:

openshift has the same separate toolbar, so this is for consistency with openshift
other pages (not graph) have different controls than graph, and it all looks different on every page, so this is for consistency as well
the namespace selection is saved when navigating between pages and visible at all times, while other controls/selections can change based on the selected page purpose.
But it's best to get the official explanation on this from @serenamarie125 :)

@josejulio @jmazzitelli @pilhuhn please see the proposals in the invision link a few comments up

My favourites are Option 2/2 (the one with the blue bar), 4 and 5.
Option 2/1 is too "invisible" for my taste.

@serenamarie125 can we remove the word "Graph" from below the namespace selector? the tab on the left already says it's graph

During the weekly meeting, we decided to implement Option 2.  Mary will deliver the high fidelity specs for implementation.

I've updated the invision with the spec, but you can also view it here

visual-spec.pdf
Please let me know if there's anything that needs clarification or if anything seems off :)

@josejulio @jmazzitelli @pilhuhn please review the design one comment up

I am not excited about any of those designs... sorry :) It just seems the look-and-feel of the drop down is very different from any other drop down menus in the UI and the location seems ad-hoc (for lack of a better word) - so example, why not put it at the very top in the big blue horizontal bar? Or move the hamburger menu icon down and put the namespace menu next to that like OKD console? I guess another reason for my reservation is that I was expecting the end result to look closer to what the OKD console namespace drop down looks like.
I won't ask to block this change, but you did ask me to review it, so I did. :-} I am curious what other people think.

@jmazzitelli sorry I started shutdown early :) This temporary solution is getting closer to OpenShift 4.  The ultimate goal is to change to PF4 L&F for the masthead and once that occurs, Kiali will match OpenShift.

@abonas can this be closed?

yep, I believe so :)


NoScript author's sites shouldn't be whitelisted

These are the ones of his that I've found so far:
noscript.net
maone.net
hackademix.net
informaction.com

I normally close every request without any explanation but I'm curious - why should this not be whitelisted? External ressources like e.g. flattr are already blocked so I see no reason to do this.

As far as I can tell, the websites work without being on the whitelist. More importantly though, the NoScript dev doesn't have a good reputation. They have put ads on their site that ask users to install malicious software, and they at one point made it so their was built-in anti-adblock in the NoScript addon specifically for their site.


Connect to custom server?

I tried connecting to a cracked minecraft server(no Mojang acc needed) but it got stuck on loading terrain. The server was mc.herobrine.org at port 25565. Any help would be appreciated!

it supports currently max 1.16.5 servers

btw your server is working on webmc

interesting, I haven't dealt with such a problem yet
i will try to fix this

I'm smelling a blocked school network

We have a Paper server, and webmc just hangs when trying to connect.


aws-device-farm-file-deploy 0.0.1

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
Note: This test requires additional configuration to pass:

AWS_ACCESS_KEY and AWS_SECRET_KEY must be set in .bitrise.secrets.yml
An Amazon device farm project must be set up in the target region, and its ARN must be specified in the device_farm_project input (see step.yml for more info on obtaining the ARN)
upload_file_path input must be set to the path of any local file

[ ] I did run stepman audit --step-yml ./step.yml (in the step's repository - note, stepman is part of the Bitrise CLI, you don't have to install it separately)

I was unable to locate the stepman tool on my PATH even though bitrise is installed and works OK.

[x] I read and accept the Abandoned Step policy

Awesome, looks good - we sent a couple of minor change PRs, but those are non blocking for this version to be accepted, just would be great to have in the next version ;)