Add support for RN 0.71.0

This PR is based on https://github.com/mrousavy/react-native-mmkv/pull/480 and https://github.com/mrousavy/react-native-mmkv/pull/499. Tested it in my own app and confirmed it's working. Closes #3.

@mateioprea please merge this PR ASAP

Hi @mmmoussa and @jahglow. I've been away for the past week. Let me review this quickly and merge it.

Sorry, but your PR doesn't work on older versions of RN. You can test it with the example app. Do you want to fix these issues?

't work on older versions of RN. You can test it with the example app.

@mmmoussa ?

@mateioprea I'm not good at native code, maybe major upgrade will do the thing and have a division for pre 0.71 react and post? That's what is usually done to resolve backward incompatibility especially there were no changes to the lib for a year.

Sorry, but your PR doesn't work on older versions of RN. You can test it with the example app. Do you want to fix these issues?

I don't believe it's trivial to support 71 as well as prior RN versions, as most libs do you should note in the readme which versions support which RN version.
does this PR fixes this error ?

I can confirm that a lot of libs that support RN 71 have dropped support for older versions. I'd bump the major version and drop a deprecation warning. Users can still use a lower version when they need support for < 0.71 imho.

@hirbod exactly.

I can confirm that a lot of libs that support RN 71 have dropped support for older versions. I'd bump the major version and drop a deprecation warning. Users can still use a lower version when they need support for < 0.71 imho.

@hirbod and that means that unless I’m using new arch, I won’t be able to get latest updates?

No, @mateioprea, when you follow the PR like done in react-native-mmkv, or this open PR (which does base on the mmkv one) https://github.com/mrousavy/react-native-blob-jsi-helper/pull/11 - your library will still work on Paper, but it requires RN 0.71.
The template and the build steps got much better and faster with 0.71 and supporting older versions is just tedious work.

Sorry, but this doesn't work for me. I get this error:  java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libhermes.so caused by: dlopen failed: cannot locate symbol
I don't know if its me or the new implementation, but i won't release this until i can run it successfully.

Found the issue. I'm gonna release this later today.

@mmmoussa @jahglow released under v2.0.0: https://www.npmjs.com/package/react-native-random-values-jsi-helper


i18n(zh-cn): Update supabase.mdx

Description (required)
Update supabase.mdx

Related issues & labels (optional)

#8129

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
guides/backend/supabase.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[Feature 8] Statistics

Statistics package handles stat entry and aggregators, such as riders entering and leaving the station, number of train delays, ticket sells, and long-term customer growth. (Grace)

done

done


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#800 fcea256 Thanks @threepointone! - create: Add chat room option

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add Changing kde icons

you can use the plasma-changeicons
as the executbale was added in the cmakelist.txt of kcm icons [here](https://github.com/KDE/plasma-desktop/tree/master/kcms/icons
it is not added in PATH by default in kde
its path is in /usr/bin/plasma-changeicons
or you can use "locate plama-changeicons" to find the path in the distro
would have made a pull request but don't know c++ to make the ui
script showing how it was used https://github.com/Da-Viper/kde_theme_script/blob/master/dark.sh

You do not need to know c++ to edit the GUI, in fact you will only need to Download QT and QT Designer. Open the UI File, edit it and run the buildUi.py file this will automatically convert the ui into a .py file. There is some manual fixing involved for the image paths.
I will have a look, but currently I am really busy.

If you create a global theme, which Yin-Yang uses, than you can set the icon theme in there.

Merging with #177


Problem to make DARK Frames

Hello,
I am embarking on this adventure with an ASI120MC-S USB3.0 camera.
(Raspberry pi 4 serie B 8Go / SD 32Go with allsky portal).
For the moment, I have managed to install everything and make it work, but I have a problem with the DARK frames.
Indeed, after disconnecting the camera, modifying the parameters by activating the capture of DARK, then by reactivating the camera, I have the message "Currently capturing dark frames. You can turn this off on the camera settings page." in the "live view" tab.
After more than an hour of waiting, nothing happens. I still have the same message. CAMERA IS TAKING DARK FRAMES.
Thank you in advance for your help.

Is your camera taking pictures?
Did you refresh the web browser for the GUI?
You don't need to disconnect the camera unless it's to take it off and cover it.  After you were done taking darks, did you reset the variable in config.sh (DARKFRAME ?) To false, then restart allsky?

Sorry, the configuration setting is called " Dark Frame" and it's on the GUI Camera Settings page.

To restart allsky to read the configuration file changes you only have to
do the following.
sudo service allsky stop
sudo service allsky start
OR
sudo service allsky restart
On Sat, Aug 14, 2021 at 4:36 PM EricClaeys @.***> wrote:

Sorry, the configuration setting is called " Dark Frame" and it's on the
GUI Camera Settings page.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thomasjacquin/allsky/issues/422#issuecomment-898971075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEELBXVDK4SQ7RDEHNHP7S3T434ZDANCNFSM5CFQDGRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

I succeeded by going to modify the config.sh file in the editor menu.
It was necessary to put "true" at the level
Set to true if you want to enable dark frame subtraction on your night time images
DARK_FRAME_SUBTRACTION=true

There are two settings related to dark frames.  To TAKE dark frames you set the "Dark Frame" option on the GUI to Yes.
Once done taking them, set it to No.  Then, to USE the dark frames, set DARK_FRAME_SUBTRACTION=true in config.sh.
If you have DARK_FRAME_SUBTRACTION=true but don't actually have any dark frames, you'll get a message in /var/log/allsky.log.

Sounds like this issue is resolved and things are working normally.
We do aim to have options easier to edit and better explanations in the future via a unified config / all editable via the WebUI ( vs using the editor ).  Keep an eye on this project for more updates.


API prefix colors??

So i use the API in my plugin but now i have a problem..
PermissionUser user = PermissionsEx.getUser(player); 			String prefix = user.getPrefix(); 			event.setJoinMessage("" + ChatColor.BLUE + ChatColor.BOLD + "Welcome back " + prefix + ChatColor.WHITE + player.getName());
this is my code.
this is what i get ingame ;l

Thanks for your help!
Yours sincerely,
Robpizza

Nobody know how to fix this ;l?

& is not the chat color character, § is. Most chat plugins just convert automatically, yours would have to as well.

Thanks ill try this one 👍


Plotly/Pie Chart Integration. Add customizable data object.

Hello,
A lot of the customization in Plotly is done at the data object level.
For example, to customize the colors of the pie chart (  such as 'marker' : {'colors' : ["rgb(183,101,184)", "rgb(236,77,216)", "rgb(176,164,216)", "rgb(255,168,255)"]}  )  , it needs to be added in the data object, and not in the Layout (provided by plotly:) nor in the Config (provided by plotlyConfig) .
Would it be possible to be able to add customizable parameters in a data object ?
Thanks

Hi!
My recommendation would be to use the layout object keys such as colorway or template, which let you customize most chart aspects, without needing to edit keys in data directly.
See https://plot.ly/javascript/layout-template/ for advanced examples
It's very difficult to provide a good API that lets you manipulate data given that the number and content of entries in that array is highly dependent on user choices in the UI...


exclude img.badgesize.io

What: Fix badge-size size on advanced
Why: Because right now they are REALLY HUUUUUGE
How: Excluding the source img.badgesize.io
Note: Removed markdown-wrapper.js because it isn't being used (thought the issue was there and after some minutes I discovered this file isn't being used :frowning:).

👍


discussion: sync

here's what we currently have
/* 0380: disable sync [SETUP] ***/
user_pref("services.sync.enabled", false); // (hidden pref)
/* 0381: disable WebExtension sync
 * [1] https://wiki.mozilla.org/WebExtensions/chrome.storage.sync ***/
user_pref("webextensions.storage.sync.enabled", false);
user_pref("webextensions.storage.sync.serverURL", "");

First of all, we should add [SETUP] to 0381. Now lets talk about this. These settings are useless unless the user has set up an account for syncing. I'm not saying remove them, but lets consider deactivating them.
Also, WE syncing can be used to sync more than just extension preferences. IMO, it can be used by developers to track users across devices.
Class discuss!

As for me, it's best to leave it as it is. Those who use synchronization do not even have an idea of the existence of ghack-user.js. Any attempt to leak the data must be terminated. Is not this the philosophy of the project?

I agree @kaliostro2 . Syncing is bad enough (I know you can choose what to sync, but eek, all your bookmarks in the cloud, among other things - some people have no idea, and others are OK with that). But it really only happens if a user sets up sync. For those who do, the user.js should be more user friendly - because clearly they wanted and chose sync. We shouldn't just then break that choice they made.
Nothing will sync if you don't have a sync account, so deactivated is fine for everyone who doesn't have a sync account (which would be most people using this user.js and setting up hardened versions etc) - so no harm no foul making them deactivated. If you do have a sync account, then currently it just disrupts/breaks syncing and upsets people.
IDK .. whatever I do, I upset people :) I'm now tempted to leave it activated so people learn! :) Wonder what earthlng says

Remove services.sync.enabled preference - VERIFIED FIXED in Firefox 47
but it's still used at least once here
Either keep 0380 until the code gets cleaned up, then move it to deprecated/removed, or move it already because it's not "supposed" to do anything anymore anyway.
As for the other ones, they definitely don't fit under 0300 because it's not "auto-phoning home".
Because the "phoning home" only happens for users who "clearly they wanted and chose sync"
Due to the controversy maybe we should (if we want to keep it) move it to the Personal Settings.
I'd say commented out so it won't break parts of Sync by default, and the more privacy interested users are more likely to read the user.js in detail and can un-comment it if they feel inclined to do so.
If we wanted to make sure Sync will never do anything we should also be looking at other prefs fe. services.sync.engine.* but since we're not doing that (yet?), the 2 prefs feel a bit out of place.

@Thorin-Oakenpants  wrote:

But it really only happens if a user sets up sync. For those who do, the user.js should be more user friendly - because clearly they wanted and chose sync. We shouldn't just then break that choice they made.

@earthlng wrote:

maybe we should (if we want to keep it) move it to the Personal Settings.
I'd say commented out so it won't break parts of Sync by default, and the more privacy interested users are more likely to read the user.js in detail and can un-comment it

These perfectly match my opinion. Agreed.

I am was tempted to set up a sync section - i..e create an account and map the UI to about:config and add anything else relevant, most likely as all inactive. The section header would contain a short description. But now I can't be bothered. It's all so common sense (people should know what they're doing). Also, @earthlng said sync is being overhauled/changed (unless I misread that).
I'd rather remove them, maybe stick em on the to watch list, and forget about it

Also, @earthlng said sync is being overhauled/changed (unless I misread that)

you misread that. Idk where you think I said that. I know nothing about Sync except for what I wrote above

FYI: WE syncing has been archived to items to keep an eye on


[RFC] Accessibility architecture proposal

What is accessibility

sufficient contrast in standard themes
high contrast theme
zoom
keyboard navigation / focus handling / focus highlighting
screen reader support for virtual cursor and narration

Goal

each component must be accessible
each component should have correct color contrast and high contrast theme defined
accessibility behavior should be separated from the component
accessibility behaviors should be extendable and reusable
component should have its own default accessibility behavior, which can be overridden from parent component, if needed
accessibility behavior should be easy to use

Stardust and accessibility

Stardust is a flexible UI library that allows composition of components. Accessibility patterns are much more restrictive. We need a way of applying the restrictive patterns to the flexible UI components
Stardust should provide accessibility by default, but the developer using Stardust should be able to modify/override the behavior to fit his specific needs
All components need to be semantically correct
RTL has impact on keyboard navigation as it switches right/left arrow key functionality

Statement
Component uses behavior to apply event handlers and aria properties to HTML elements.
The behavior of a component is initially determined by the component type and properties.
User of the component (developer) can override this default behavior by providing a different behavior type in the properties of the component.
There are two parts of accessibility, which should be encapsulated in the behaviors:

aria-* attributes - specifies the set of attributes necessary for correct narrating by screen readers.
keyboard navigation - the way how to use application without mouse, whenever user navigates with keyboard he/she should be able to see where the focus is. The focus can be trapped in some areas (e.g. modal dialogs).

Elements respond to HTML keyboard events by calling corresponding methods specified by the behavior.
Behavior can execute an action (for example move focus to the next child component), and/or create an intent and propagate this intent to the parent component behavior.
Parent component behavior can react to this intent by executing an action and/or propagating the intent to its parent component behavior.
Intent propagation is explicit (as opposed to HTML event propagation). Behavior needs to explicitly send the intent to the parent behavior.
For HTML events, once the element responds to an event by calling behavior method, the event propagation should be stopped.
Accessibility in HTML

semantically correct HTML, to support Screen Reader's virtual cursor navigation
proper use of aria-* attributes and tabindex attributes, to support Screen Readers narration
keyboard handling implemented in JavaScript, for the dynamic content, such as popup menus, menus, lists, dialogs, etc.

Themes and color contrast

each component should have at least two themes: standard and high contrast, to support this we use CSS -in-JS technique
each component's color palette should be verified for sufficient contrast

Behaviors
The idea behind behaviors is to decouple accessibility logic from the component and make it reusable, easy overridable and extendable.
Base component should expose the strongly typed accessibility behavior property, which has to be assigned by each component.
export class UIComponent<P, S> extends React.Component<P, S> {
  …
  public accBehavior: IAccessibilityBehavior<P, S>
  …
}

The behavior should take properties and state as a parameters, to generate correct aria-* attributes and set proper tabindex.
export interface IAccessibilityBehavior<P, S> {
  readonly name: string
  generateAriaAttributes(props: P, state: S): object
  // the following line might not be needed after component state management is introduced
  changeState(newState: ComponentState): void
}

Stardust framework should provide a set of predefined behaviors, which can be easily extended if needed. Very simplified version, just to show the idea behind it, how it might look like:
export class ButtonBehavior implements IAccessibilityBehavior<{}, {}> {
  private attributes = {
    'ms-acc-behavior': this.name,
    role: 'button',
    'aria-hidden': false,
	// child: {
	//   'ms-acc-behavior': this.name,
	//   role: 'menu-item',
	//   'aria-hidden': false,
	//   'tab-index': 0,
	// },
  }

  public get name(): string {
    return 'button'
  }

  public generateAriaAttributes(): object {
    return this.attributes
  }

  public changeState(newState: ComponentState): void {
    if (newState === ComponentState.disabled) {
      this.attributes['aria-disabled'] = true
    } else if (newState === ComponentState.enabled) {
      delete this.attributes['aria-disabled']
    }
  }
}

The component should instantiate its behavior:
constructor(p, s) {
  super(p, s)
  this.accBehavior = new ButtonBehavior()
}

and render component with generated attributes:
renderComponent({ ElementType, classes, rest }) {
  const { children, content } = this.props

  return (
    <ElementType
      {...this.accBehavior.generateAriaAttributes(this.props, this.state)}
      {...rest}
     className={classes.root}
   >
     {childrenExist(children) ? children : content}
    </ElementType>
  )
}

{…rest} goes after behavior generated attributes, to give more flexibility and allow to override anything generated by the behavior if developers need it.
Whenever component changes its state, the new aria-* attributes will be provided back to the component by behavior.
// TODO: extend the proposal for keyboard navigation and focus management
Supported client/screen reader combinations

Win/Desktop - JAWS
Win/Chrome - JAWS
Win/Edge - Narrator
Win/Firefox - NVDA
Mac/Desktop - VoiceOver

Glossary
Component - Stardust (react) component
Behavior - Javascript function,object or class that defines the behavior of a component
Element - HTML element rendered by the component
Event - HTML event (for example keydown)
Intent - operation to be performed. Behaviors understand intents.

Please look at the Examples section in https://github.com/stardust-ui/react/pull/105/files which was left out from this particular description but provides a concrete example of how the parts tie together

closing as this will be moved to the new repo


Restructure the usage of bootstrap package.

Removed the reference of bootstrap css from head tag and assign it in angular-cli config file, styles section . Angular-cli takes on the responsibility to bundle any declared styles to the page.

@sjmf This will justify also a new release.


Server Error (500) when logging in/creating account

This error does NOT occur when using a google account.

The solution will be to either enable email logins (this might require some infrastructure), or to disable it

Hello,
Any update on this error . I noticed its still on, I tried log in or create a new account but always getting "Server error 500". I tried with my gmail, institution email and hotmail.
With all, am getting the same error message.

Hello, you need to do the oauth login. We will not be storing passwords with this application


ensure 64bit alignment of atomically accessed field in ChannelAcceptor

help lnd avoid a bug in the sync/atomic package which requires 64-bit alignment of atomically accessed fields

Addresses: https://github.com/lightningnetwork/lnd/issues/4886
Pull Request Checklist

[ ] If this is your first time contributing, we recommend you read the Code
Contribution Guidelines
[ ] All changes are Go version 1.12 compliant
[ ] The code being submitted is commented according to Code Documentation and Commenting
[ ] For new code: Code is accompanied by tests which exercise both
the positive and negative (error paths) conditions (if applicable)
[ ] For bug fixes: Code is accompanied by new tests which trigger
the bug being fixed to prevent regressions
[ ] Any new logging statements use an appropriate subsystem and
logging level
[x] Code has been formatted with go fmt
[ ] Protobuf files (lnrpc/**/*.proto) have been formatted with
make rpc-format and compiled with make rpc
[ ] New configuration flags have been added to sample-lnd.conf
[ ] For code and documentation: lines are wrapped at 80 characters
(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
[x] Running make check does not fail any tests
[x] Running go vet does not report any issues
[x] Running make lint does not report any new issues that did not
already exist
[x] All commits build properly and pass tests. Only in exceptional
cases it can be justifiable to violate this condition. In that case, the
reason should be stated in the commit message.
[x] Commits have a logical structure according to Ideal Git Commit Structure

Was this the bug in question:
https://golang.org/src/sync/atomic/doc.go?s=1206:1668#L36
?


Add a method to add URos/declining.

It might be worth looking into a way to add URos/declining.  Currently you can check the balance of these accounts and pay tuition, but there doesn't seem to be a way to add URos/declining.

We should probably deal with #30 first.

I agree, but I was thinking more long-term.


[GHSA-5j33-cvvr-w245] Apache Tomcat Time-of-check Time-of-use (TOCTOU) Race Condition vulnerability

Updates

Affected products
CVSS v3
CVSS v4
Severity

Comments
Affected components are present in maven package and should also be considered affected.
Obs: CVSS 4.0 calculator does not accept Exploit Maturity (E) metric. So the form it rejects original GHSA CVSS string as a valid value.

Hi @biehl1, per https://github.com/search?q=repo%3Aapache%2Ftomcat+catalina.webresources+path%3A%2F^res\%2Fbnd\%2F%2F&type=code, org.apache.tomcat.embed:tomcat-embed-core embeds code from catalina/webresources such as that changed in the fix commit https://github.com/apache/tomcat/commit/05ddeeaa54df1e2dc427d0164bedd6b79f78d81f. Thank you for your contribution and have a nice day!


Enable everything

How it works:
On each push to the main branch, all files in synced-files/ will be copied to all Exercism track repos.
A PR will be opened on each repo, which will (in the future) be automatically merged by a webhook integration.
After pushing, you have 5 minutes to abort the workflow, in case there are any errors in the files that should be synced.


Setup UI test with Wallaby

https://github.com/nimblehq/elixir-templates/issues/11
What happened
Setup UI test with Wallaby
Insight
1/ Setup Wallaby

Running with ChromeDriver and Chrome Headless as default

Disable Chrome Headless by export the CHROME_HEADLESS = false

Take a screenshot of failing automatically and upload it to Github Action artifact

2/ Modify the CI workflow to run asset compile.
Proof Of Work
I added 1 UI test to the template, the test is passed on CI now.
For testing the screenshot on failing UI test, I have trigger a failing test here from there we could download the screenshot

@anduonghien Looks good to me other than a small comment. Also, rebase required  🚀


IconButton are displayed with wrong size on Safari

Describe the bug
IconButtons are not displayed correctly. They appear to have a to big size and are misaligned.
Screenshots/Videos

Operating System
No response
What browsers are you seeing the problem on?
No response
Browser version
No response
What device are you using?
No response
Additional context
No response

I've made a change, and it seems to work in my browser now. Can you please re-test in safari?


Possible fix: Response transformed for each interceptors

Looping on each interceptors while applying the response's configured
transformResponse (array of fn or single closure) applies those
transform many more times than expected.

Ref: https://github.com/atecarlos/protractor-http-mock/issues/59

This was fixed in version 0.2.0


Allow local vcap options to be supplied in a file, not just an object

Would it be possible to load everything defined under env: in the manifest.yml to be loaded into process.env in the constructor when isLocal is true?
This would allow me to access my environment variables defined in the manifest.yml without having to use another library or any additional code.

@jsmoorman I have an implementation of this in PR https://github.com/cloudfoundry-community/node-cfenv/pull/33 ; see notes there about testing with this implementation.  I'd like to find out if this works for you.

So I've just tested it and it works amazingly!
I've exported the VCAP_SERVICES from my Cloud Foundry App on Bluemix and just wrapped it with:
{
  "services": "<exported VCAP_SERVICES>"
}

The only possible suggestion I have is to allow users to use the exported json itself as the VCAP_SERVICES instead of as the whole app environment so that users don't have to wrap the export as I did above -- but then you would lose the ability to customize the VCAP_APPLICATION.
That is, unless you allowed them to use it in tandem with the vcap field in the options argument, but then you have the possibility of users providing VCAP_SERVICES through the vcapFile and through the vcap fields.

But to answer your original question, this works exactly as expected and provides the functionality I needed.
Thank you!

The only possible suggestion I have is to allow users to use the exported json itself as the VCAP_SERVICES instead of as the whole app environment so that users don't have to wrap the export as I did above

Ya, I can see that, but I think only if such a 'services-only' JSON file would be useful in some other environment.  Otherwise, it's kinda a one-off thing anyway, so I don't see the extra services property indirection as too bad.
It would also not be parallel to the existing vcap option.
Probably worth noodling on whether there should be vcapServices and vcapServicesFile options that would just have the "services" bits and not "application" bits, especially if it turns out the application bits rarely need to be set like this given the default processing.
But let me go ahead and publish what I have now, I think this weekend or next week.  Tied up for now and I want to have some time ready if for some unknown reason this causes existing users problems, so I can fix that.
Thanks a bunch for trying this out!


Add wasm targets

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   77.41%   77.41%
=======================================
  Files           8        8
  Lines          93       93
  Branches       18       18
=======================================
  Hits           72       72
  Misses         12       12
  Partials        9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix a few error cases when using :i, :k and :t from the repl

Fixes a few things from https://github.com/Marwes/gluon/issues/58#issuecomment-234916434

Rebased and addressed all comments (except the qualification of String which would require more extensive changes).


Move validate tests to base

In this PR we move some of the tests for io.spine.validate from smoke-tests back to base.
The only 2 kinds of tests retained in smoke-tests are tests for external validation rules and for ValidatingBuilders generation.
 And see my only comment.

@armiol, PTAL again.


GCP directory and .yaml files not included in v1.0.0-alpha.2 tar balls

The current downloads of v1.0.0-alpha.2 tar balls did not have the necessary gcp directory or .yaml files. I used the files from v1.0.0-alpha.1 to continue my backup but they need to be restored so the otherwise stellar docs can be followed.

hey @AndyBaird thanks for trying out our alphas! We're moving away from including static YAML for deployment, and have replaced it with the velero install command, which can either apply YAML directly to your cluster or can output it for you to review/modify/apply using the --dry-run -o yaml flags.  Please see our updated docs at https://heptio.github.io/velero/v1.0.0-alpha.2/gcp-config and let us know if you have any questions/issues!

Closing as this is by design - please reopen if you need any further assistance!


"cannot insert multiple commands into a prepared statement" even thought I use interp False ...

I'm getting the following error:
SessionUsageError (QueryError "DROP TYPE IF EXISTS gender_identity CASCADE;CREATE TYPE gender_identity AS ENUM ('abinary', 'agender', 'ambigender', 'androgyne', ...removed for brevity...)" [] (ResultError (ServerError "42601" "cannot insert multiple commands into a prepared statement" Nothing Nothing Nothing)))

However, I use interp False, which the docs say means if the statement should be prepared or not, but the error seems to say it is prepared. So either I'm misunderstanding, or there's a bug in the library perhaps?

The docs aren't very precise, and when combined with that error message I see how that would be confusing. Perhaps more detail should be added here and to hasql's docs.
That boolean argument is just passed along and becomes the boolean in hasql's Statement. That bool controls whether a prepared statement will be made and arranged to be reused for the same query in the future of this session, instead of issuing another parse message. What is specifically relevant to this issue is that it controls which libpq call is issued (PQsendQueryPrepared or PQsendQueryParams). Either way, postgresql's extended query protocol is used, and consequently a prepared statement must be created. PQsendQueryParams just uses the "unnamed" prepared statement which is a special prepared statement in postgresql's extended query protocol for ephemeral usage (you can read about it here).
The extended query protocol does not allow multiple sql statements to be made in a single prepare message, and that is the error you are seeing here. The simple query protocol does, and hasql allows you to use the simple protocol through sql.
So, you could use sql here instead of interp if you don't actually want to interpolate any arguments, or you break that multi statement string up into multiple interp calls.

I see! Thank you. The docs are indeed confusing, but essentially if I want multiple statements in one I have to use sql, anything that goes strough a Statement won't allow multiple statements.
Before I was indeed using sql, but moved from hasql-th to hasql-interpolate and so moved this query from using uncheckedSql to the sql quasiquoter.
Thank you!


Windows MSI beta.8 pkg on Windows 10 requires VC++ runtime redist

The installer didn't require this previously (beta.7) on Win10 but now it does.  We should revisit the dependency check in the msi.

This issue causes docker build for windows server core (docker/release/windowsservercore) to fail.

Did it come after adding new icon?

@iSazonov I think it was #4745

Thanks! Clear - we don't check OS version.

I think better check Universal runtime.

The check for ucrtbase.dll is to make sure Univeral C Runtime is available.


Adding a CLI for LDAP

Because I want to have everything under control in the docker-container, I'm currently writing a kopano-ld CLI (written in go), which will be able to control the LDAP entries just like the kopano-cli for DB backends.
Maybe we can integrate it into the LDAP docker image
It can be found at https://github.com/nupplaphil/kopano-ldap (It's not ready yet, I'm working on it)

I like that idea

Closing here for the moment.


Running without GPU

I want to test this on my local machine. Is it possible to config and run it without GPU. Please specify detailed steps of you can.

Hi @harishkhollam,
at the moment a GPU is mandatory. For running without GPU, you have the modify the source code. You might want to check the chainer API. In case I find some free time in the next weeks, I will try to come up with a PR.
(sorry for the late response, I was quite busy the last months and I had no time for maintaining this project)


fix Norway region data -- duplicated data

`"Norway", "NO", "Norway", "NO" (repeat) related to #2

Good catch, thanks @sventech! I'll wait another day or so to do another release, just in case anything else shakes loose.


ODS - Component - Radio Buttons

Requirements
Variants & options

Unselected
Selected
Disabled
?? Error

Related Tasks

[x] #101
[x] #102

I have logged the following issue: #192


Use fstrings instead of string concatenation for error strings

This makes the error-constructing code a bit easier to read at a glance.

Yep, I did, and the workflow ran here as well. Merging!


Don't allow PersonalisablePage to be created directly as a page type

Ref: https://github.com/LabD/wagtail-personalisation/issues/72#issuecomment-305142593

This isn't required anymore when we merge #113 I think?

Correct - as mentioned on https://github.com/LabD/wagtail-personalisation/issues/72#issuecomment-305140008 though, I have major doubts about whether an abstract model is going to work for this.

Closing as #113 is now merged instead


CSI snapshotter implementation

This is a straight forward implementation of the csi snapshotter based on the current backup interaction pattern.
There are some concerns about the volume.BackupStatus since longhorn has a 1 - many relationship from snapshot to backup.
While the csi snapshotter assumption is a 1-1 relationship.
The csi snapshot restore part on the uses the same mechanism as the previous storageClass fromBackup approach.
Currently there is an issue with that part longhorn/longhorn#1754 but it's unrelated to the CSI snapshotter implementation.
The csi snapshots require a prefix, I changed the default form snapshot to csi, this unfortunately makes the longhorn snapshot ui look bad, @yasker maybe we should consider prefixing the longhorn snapshots with snapshot as well then have the UI strip the prefix for displaying the name?
Prerequisite:

make sure your cluster contains the below crds, rancher rke did not deploy them for me.
https://github.com/kubernetes-csi/external-snapshotter/tree/master/client/config/crd

make sure your cluster contains the snapshot controller, rancher rke did not deploy it for me.
https://github.com/kubernetes-csi/external-snapshotter/tree/master/deploy/kubernetes/snapshot-controller

modify the above yaml files for the snapshot controller if you don't want it in the default namespace.
Testing:

create a volume + pvc + pv named test-vol
you can trigger snapshots via the below snapshot.yaml
you can trigger restores via the below restore.yaml

snapshot.yaml
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
  name: test-vol-snapshot
spec:
  volumeSnapshotClassName: longhorn
  source:
    persistentVolumeClaimName: test-vol

restore.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: test-vol-restore
spec:
  storageClassName: longhorn
  dataSource:
    name: test-vol-snapshot
    kind: VolumeSnapshot
    apiGroup: snapshot.storage.k8s.io
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 2Gi

longhorn/longhorn#304

Btw, what's the usage for the prefix? Is it suppose to be vendor specific?

No it's just used as a prefix, for the final snapshot name, this might be used by google/aws to filewatch a directory for snapshots then upload them to final resting place.

In regard to updating the images, we use the following csi images:
quay.io/k8scsi/csi-attacher:v2.0.0
quay.io/k8scsi/csi-node-driver-registrar:v1.2.0
quay.io/k8scsi/csi-provisioner:v1.6.0
quay.io/k8scsi/csi-resizer:v0.3.0
quay.io/k8scsi/csi-snapshotter:v2.1.1

The csi-resizer could be updated, but is independent and not required for the csi snapshot functionality.
It also introduced a change in behavior in version 1.0 which is the latest version of it.

I changed the snapshot prefix back to the default snapshot since whether we use csi or snapshot makes no difference from the ui perspective, by using snapshot we keep it generic and could change the longhorn snapshot scheme to fit in the future but is not required.
For the ui we can filter out the snapshot prefix if we want to do so.


April 2024 CPU - JDK17 Triage

Release Summary Report for release-openjdk17-pipeline
Warning: The release summary report is not yet complete. Currently, it only contains partial results.
Report generated at: Wed, 17 Apr 2024 11:22:41 GMT - aggregated to temurin/issue/38
TRSS Build and TRSS Grid View
Jenkins Build URL https://ci.adoptium.net/job/build-scripts/job/release-openjdk17-pipeline/62/
Started by upstream project "build-scripts/utils/releaseTrigger_jdk17u" build number 4690 at 4/17/2024, 1:43:25 AM

✔ results in these Tables means the activity has successfully completed.
⏳ results means that we are actively working on closing off the runs needed for this version, platform, binaryType.
⛔ means there is no build planned for that version/platform combination.
⏸ means activity not yet started.

Platform
Status
Results
Actions

x86-64_mac
✔
all pass

x86-64_linux
⏸
comment

x86-64_windows
⏸
comment

aarch64_linux
✔
all pass

aarch64_mac
✔
all pass

arm_linux
⏸
comment

x86-64_alpine-linux
⏸
comment

x86-32_windows
⏸
comment

ppc64le_linux
✔
comment
ACTION: raise issues relating to 3 failures

s390x_linux
⏸
comment

ppc64_aix
⏸
comment

Rerun tap files
Test_openjdk17_hs_extended.openjdk_ppc64le_linux_rerun.tap.txt

arm_linux
Test_openjdk17_hs_extended.openjdk_arm_linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_arm_linux_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode, sharing)

Test_openjdk17_hs_extended.openjdk_arm_linux_testList_0 ⚠ UNSTABLE ⚠
jdk_io_2 => deep history 0/16 passed | possible issues
Test_openjdk17_hs_extended.openjdk_arm_linux_testList_1 ⚠ UNSTABLE ⚠
jvm_compiler_2 => deep history 2/17 passed | possible issues
jdk_net_2 => deep history 26/33 passed | possible issues

ppc64_aix

x86-64_linux

x86-64_alpine-linux
Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode, sharing)

Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux_testList_1 ⚠ UNSTABLE ⚠
jdk_nio_0 => deep history 23/29 passed | possible issues
Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux_testList_2 ⚠ UNSTABLE ⚠
jdk_nio_1 => deep history 19/28 passed | possible issues

x86-64_windows
extended.openjdk sees the following failures:
not ok 21 - jdk_tools_0
  ---
    output:
      |
        Failed test cases:
        TEST: sun/tools/jhsdb/JShellHeapDumpTest.java
        TEST: tools/jmod/hashes/HashesOrderTest.java
        Test results: passed: 226; failed: 2
    duration_ms: 689685
  ...
not ok 22 - jdk_tools_1
  ---
    output:
      |
        Failed test cases:
        TEST: sun/tools/jhsdb/JShellHeapDumpTest.java
        TEST: tools/jmod/hashes/HashesOrderTest.java
        Test results: passed: 226; failed: 2
    duration_ms: 693289

all other top-level test targets pass

ref x86-64_alpine-linux triage, the failing java/nio/file/DirectoryStream/SecureDS.java test in jdk_nio_0 and _1 passes on test-docker-alpine314-x64-1
https://ci.adoptium.net/job/Grinder/9688/console

s390x_linux
Test_openjdk17_hs_extended.openjdk_s390x_linux ⚠ UNSTABLE ⚠
Test_openjdk17_hs_extended.openjdk_s390x_linux_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode, sharing)

Test_openjdk17_hs_extended.openjdk_s390x_linux_testList_0 ⚠ UNSTABLE ⚠
jdk_net_0 => deep history 4/22 passed | possible issues
jdk_imageio_0 => deep history 9/29 passed | possible issues
Test_openjdk17_hs_extended.openjdk_s390x_linux_testList_1 ⚠ UNSTABLE ⚠
jdk_management_0 => deep history 12/29 passed | possible issues
Test_openjdk17_hs_extended.openjdk_s390x_linux_testList_2 ⚠ UNSTABLE ⚠
jvm_compiler_0 => deep history 12/16 passed | possible issues
jvm_compiler_1 => deep history 12/16 passed | possible issues
jdk_net_1 => deep history 3/16 passed | possible issues
jdk_security3_1 => deep history 17/31 passed | possible issues
jdk_nio_1 => deep history 15/31 passed | possible issues
jdk_tools_0 => deep history 12/15 passed | possible issues
jdk_jmx_0 => deep history 24/33 passed | possible issues
jdk_tools_1 => deep history 11/14 passed | possible issues
jdk_imageio_1 => deep history 6/15 passed | possible issues
Test_openjdk17_hs_extended.perf_s390x_linux ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode, sharing)

renaissance-movie-lens_0 => deep history 24/37 passed | possible issues
Test_openjdk17_hs_extended.perf_s390x_linux_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode, sharing)

Test_openjdk17_hs_sanity.system_s390x_linux ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode, sharing)

TestJlmRemoteClassAuth_0 => deep history 42/56 passed | possible issues
TestJlmRemoteClassAuth_1 => deep history 42/56 passed | possible issues
TestJlmRemoteClassNoAuth_0 => deep history 42/56 passed | possible issues
TestJlmRemoteClassNoAuth_1 => deep history 42/56 passed | possible issues
TestJlmRemoteMemoryAuth_0 => deep history 42/56 passed | possible issues
TestJlmRemoteMemoryAuth_1 => deep history 41/56 passed | possible issues
TestJlmRemoteMemoryNoAuth_0 => deep history 42/56 passed | possible issues
TestJlmRemoteMemoryNoAuth_1 => deep history 42/56 passed | possible issues
TestJlmRemoteNotifierProxyAuth_0 => deep history 42/56 passed | possible issues
TestJlmRemoteNotifierProxyAuth_1 => deep history 42/56 passed | possible issues
TestJlmRemoteThreadAuth_0 => deep history 41/56 passed | possible issues
TestJlmRemoteThreadAuth_1 => deep history 41/56 passed | possible issues
TestJlmRemoteThreadNoAuth_0 => deep history 42/56 passed | possible issues
TestJlmRemoteThreadNoAuth_1 => deep history 42/56 passed | possible issues
NioLoadTest_5m_0 => deep history 42/56 passed | possible issues
NioLoadTest_5m_1 => deep history 42/56 passed | possible issues
Test_openjdk17_hs_sanity.system_s390x_linux_rerun ✅ SUCCESS ✅
Rerun all
java -version
openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode, sharing)

x86-32_windows
Ran from https://ci.adoptium.net/job/build-scripts/job/release-openjdk17-pipeline/63/


Appears pure white

When I equip this shader, my screen goes pure white.

Are you using the latest Iris 1.6.10? Optifine is not supported, and Oculus may not be up-to-date with Iris enough for the features I use.

I use OptiFine.


which n-gram BLEU metric do you report in your paper?

This is Table 1 in Result and Analysis section in your paper, which BLEU do you use here, BLEU-1, BLEU-2, BLEU-3 or BLEU-4？

BLEU-4


Discord 401 unauthorized

Details
I have frequent 401 unauthorized events in the log and I guess it is the discord notification. I copied my account token using web developer console in a web browser and the channel ID from the discord app. Entered the details via new GUI and saved. Restarted app, restarted vm etc. Still getting 401 unauthorized.
The channelID seems to be "closed" with ", for example - channelid: "123456789". But the token is not. I have tried to add "closing" symbols to the token but still getting the same error.
Telegram notifications works. Is something wrong with the discord authentication or just my configuration? Anyone that could give me some hints? Thanks
Version
v0.4.0-beta5

Figured it out. You need to create a discord bot and use the bot's token.


Grafana UI Authentication failing while connecting grafana UI using HAProxy Ingress

We are using Grafana V3.5.0 . Our grafana UI with configured user/passwd is working fine when we expose this as LoadBalancer.
But when we configure grafana for Ingress type, configure grafana ui user /passwd in grafana yaml and use HA proxy as ingress, then we are able to reach the UI web page using HA Proxy Ingress but user authentication is failing for garfana.
Please suggest what we need to configure to make this work.

Hi Team... Your suggestion/ fix would be highly appreciated....please suggest.

Hi Team... Your suggestion/ fix would be highly appreciated....please suggest.

@pb82  Might have a better idea

@pb82  Might have a better idea

@shantpschauhan

using HA Proxy Ingress
How are you setting this up? Is this different than the Ingress support via the operator?

but user authentication is failing for garfana
How is it failing? Is there an error in the UI or the logs of grafana?

@shantpschauhan do you have any more information so we can help you debug this?
Else we will close this issue in the mean time.

Thanks.
Please close this issue.
On Wed, 7 Jul 2021, 12:52 Edvin N, @.***> wrote:

@shantpschauhan https://github.com/shantpschauhan do you have any more
information so we can help you debug this?
Else we will close this issue in the mean time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/grafana-operator/grafana-operator/issues/331#issuecomment-875356128,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOLVHC34CC35NUK3FT4LLTTWP6ETANCNFSM4WG44MUQ
.


ConfigurationBinder should allow instantiation via non-public constructors

I'm am trying to do bind a configuration section to a collection of objects that have public constructor which accepts parameters and a private parameterless constructor but ConfigurationBinder will only invoke public parameterless constructors.
There's already an option in BinderOptions that allows binding of non-public properties.
It'd be great if you could add an option that tells the binder it can use non-public parameterless constructor to create an instance of an object.

any updates on this?


VideoNode Size Problem

What determines the actual size of VideoNode when displayed in space? Besides adjusting the Scale, are there any other methods to change this size?

If I only want to display a portion of the VideoNode, such as half of it, is there a way to control that? thx


Bug: React Decorator nodes constantly remounting

I've noticed that Decorator nodes seem to remount on React state update. I can't reproduce the behavior in the Playground in the Lexical monorepo but was able to do it in a code sandbox. Pressing the "Click Me" button causes the ImageNode to remount.
To reproduce:
https://codesandbox.io/p/sandbox/sad-thunder-lkt6sr?file=%2Fsrc%2FApp.tsx%3A83%2C1
Debugging:
Note you need to view the console to see the "mounted" message, full screen version here https://lkt6sr-5173.csb.app/

This is generally by design. Lexical isn't a React framework, it's a vanilla JS framework with React bindings. If you want to preserve state after an editor update, you can store values directly on the decorator node itself and then pass them down to the component within the decorate method. A good example of this is the ImageNode: https://github.com/facebook/lexical/blob/main/packages/lexical-playground/src/nodes/ImageNode.tsx

The reason decorators are getting remounted is your ErrorBoundary is defined as an inline function. So either wrap it into useCallback/useMemo or extract from the component to avoid re-creating new function on each composer re-rendering


IsAudioBufferProcessed -> IsAudioStreamProcessed

It appears that you've missed renaming this function here, which makes trying to compile standalone raudio.c error out.

Ouch! Good catch @zatherz! :D


can i use pusher-websocket-flutter to send notification to android and ios

now i wanna use real time data base and send notification to android and ios
pusher-websocket-flutter can do this

I would checkout the official Pusher website and see if it fits your needs.
https://pusher.com/
However pusher does not offer a realtime database. Firebase does. https://firebase.google.com/docs/database


Git Credential Manager for Windows keeps appearing when launching VS Code

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:20:36.315Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: none

Steps to Reproduce:

Open visual studio code
Login
App Keeps asking for your credential, despite having entered them or cancel the action.

What are you logging in to? Can you post a screenshot?

I'm logged in at github with this account. I enter my credentials in here

But keeps asking me for the user and password. This used to dissapear once I hit cancel but with latest version keeps appearing and does not go away.

Similar problem, but related to the GitHub authentication window. I opened a folder that is a GitHub repo, and this dialog keeps popping up constantly even though I dismiss it or cancel it.

#26573

I updated to VS Code 1.16.0 just now and now I'm getting this window spamming me. It opens up 7 of them at a time. I close them all, then in a few minutes it spams them out again.

Hi, i have the same issue.

Samesies

I'm having the same issue and I never do anything git related from vs code

+1 is there anyway to uninstall this credential manager i'd rather just set it in CLI.

Same here!!! It's very annoying. I just updated to the latest release, but it just started again. It used to do it a long time ago, then it quit, but now it's going again

I am having the exact same issue. Is there a way to disable the credential manager through VS Code?

I found out a way to get rid of it on Stack Overflow, here is a link to the solution. It worked for me, there are a few options, just play around and see which one works for you. If you don't want to permanently disable, here is another link that might help, i didn't try it tho.

Having the same issue. Updated to VS Code 1.16.1, and the popup shows regardless of if I enter my credentials or click cancel

@kgriffiths , did you try the solution on Stack Overflow that i posted?

Fresh install of VS code, Git for windows, ... on a Windows 10 machine and the Git cred management flow is still broken. Happens on my other machine as well.

start VS code on a repo previously cloned from GitHub
in the git source control window click the refresh/sync button at the bottom
Notice the GitHub cred window come up. Enter username and PAT
Nothing useful happens
Notice little tiny drop down at the top of the VS code window asking for GitHub username, and then password.  Enter username and PAT
Operation seems to succeed.
randomly go back to step 3

Sometimes the creds entered directly into VS Code work for a while (days), sometimes it is minutes until you have to do the dance again. The answers suggested above basically involve turning off syncing or the cred manager. That seems to just defer the problem. Is there a real answer here?

Now I managed to disable the auto fetch and got rid of the popup that never accepted user / PAT ...
And so far I couldn't make VSCode work with github at all although the repo works terrific with github through eclipse and github desktop. If I recall right this issue has been there since last year.  What's on here ?

I managed to disable and now it asks me in PowerShell for login details. So it's working perfectly now.

Things to check when this occurs:

Output of: git config credential.helper
Check if the OS's Credential Manager / Keychain has an entry for github.com
Output/behavior of (when on Windows, run from Powershell): echo "url=https://github.com/Microsoft/vscode\n\n" | git credential fill (run with your repository URL)

I did the echo at a point when my system was prompting me for creds and there were none. I did not get a chance to check the OS (Windows in my case) cred manager before ending up entering my creds in the prompts directly in VS Code. After entering the creds into the VS code prompts, the echo and Windows Cred Manager both had values. Next time it happens (seems random) I'll check the Windows Cred Manager first to see if somehow the creds are getting dropped.

The problem came back and it appears that the GitHub creds are gone from the windows cred manager. So, the cred prompt is legit but that leaves two questions

why are the creds disappearing
why do I get a GitHub branded login prompt that does not actually work

On the first I did some poking around and found @whoisj talking about debugging cred manager issues in https://github.com/Microsoft/Git-Credential-Manager-for-Windows/issues/58. Seems like some good steps. I have not had a chance to try but wanted to let others know so they can do so as well. One possibile theory is that this happens when waking up my machine with VS Code running. Code attempts git fetch and fails as the internet may still be connecting. Then the creds get removed from the store.
For the second one I am puzzled. At one point I was clearly getting a GCM prompt (it said Git Credential Manager) but now I get one that is clearly GitHub branded. That (ironically) may be after having installed GCM separately (as opposed to what may have come with VS Code). That GitHub one simply does not appear to do anything. It happily takes my creds but auth does not succeed.

@jeffmcaffer the creds are likely being dropped at Git's request. Git requests that credentials get erased if a network operation using them fails with a 400 class error. I personally hit an issue where GitHub was throttling me (or at least it seemed like they were) because VSCode was being so aggressive with git-fetch operations. Disabling auto-fetch stopped this from happening.
Regarding the branding change, there are many Git credential helpers - but only one Git Credential Manager for Windows [GCM]. The GCM was granted GitHub branding and multi-factor authentication support by GitHub a little over a year ago. If you're GCM was older than that, or if you were using another helper then the branding change seems expected.

Thanks @whoisj. This clarifies a number of things.

the GitHub branding is expected and that is "the right thing". I'm not sure how I got in a situation of seeing the unbranded version of the dialog at one point in there.
The GitHub plugin for GCM actually requires the real password and then does the 2fa dance. I was erroneously putting my PAT in there expecting that to work. It does not.
Disabling auto-fetch is an option but I still actually do Git operations and would be prompted then anyway so that just masks it for a bit
The core problem of credentials being dropped seems like it is a networking thing I see. Perhaps when my machine wakes up and has WIFI but not actual internet connectivity (happens when I get to work and the machine is doing the corp net auth dance). For that, I'm am trying git config --global credential.preserve 1 in the hopes that that will stop Git from telling GCM to drop its creds.

Here I found the solution to my problem => stackoverflow
Seems modifying "git.enabled" option to false at settings.json file does the trick.  You can modify it in File=>Preferences=>Settings; Then you can do a quick search by pressing shift + f with git.enabled.
Thanks everybody that took the time to answer my question.

@milodude Setting git.autofetch to false would keep the Git integration enabled and might be a better workaround.
The preferred solution is still to fix the problem without disabling the feature. If @jeffmcaffer 's approach works, we might just pass that config property with -c on each fetch command.

@chrmarti if credential.preserve is passed, then any git credential erase commands will get ignored, and the user will just receive a wash of fetch failure notices, never being prompted for a new credential.
On Windows, the better solution might be to use credential.preserve = 1 until you've reached two failed attempts. Then on the third omit the option and let Git ask the user for updated values.
OR VSCode could run git credential-manager get and send the request info via stdin to the process. In this way VSCode would completely control the experience and timing of things.

@whoisj I think it would be fine if the commands we run automatically never remove the credentials. We would run user triggered commands unchanged, so when the credentials indeed expire these commands will have the credentials removed and the user will be asked for new credentials at a time when the user's attention already is on running a git command.
That should be a much better user experience than currently where the user is asked for credentials at a random point in time.

That seems pretty reasonable. So far I have not been prompted for creds so it is looking promising. This is lending credence to the idea that creds are being removed as a result of automated operations while my network is not fully up. In essence VS Code's automated activity should never CAUSE my creds to be removed so @chrmarti approach has the right user semantics as well.
Side note, this issue is marked Closed yet we are actively talking about approaches/solutions. There are several other related issues. Might want to triage these into one...

Thanks @jeffmcaffer! Reopening this one for the discussed approach.

The git credential manager have deleted my credentials many times when using VSCode, I have to input password again and again. I will try to use "credential.preserve = 1".
https://github.com/Microsoft/vscode/issues/26154

I have set "git config --global credential.preserve 1",  but just now the window pops out again

here is my git log:
git.log
20:33:11.922374 ...zureAuthority.cs:184 trace: [ValidateCredentials] server returned: 'Unable to connect to remote server

@kzhui125 For how long have you run with that setting? Does it prompt you as often as it did without?

@chrmarti
just now, I opened 7 repositories, two window pop out.

This is what I do for now:

Adding "git.autofetch": false to setting.json
Whenever my credentials change I set it back to true "git.autofetch": true
On git push the credential manager pops up and I set my new credentials
Then go back to setting.json and set autofetch back to false: "git.autofetch": false.

The GCM accepts several configuration settings, one of them turns of interactivity. If you're confident that you do not want to see the prompts you can set git config credential.interactive never and the GCM won't ask. However, if you do not have valid credentials set the authentication will just fail.
Another option, and I'm not certain this is possible, is to have VSCode inject an environment variable on your behalf which tells the GCM to not prompt when VSCode is asking. This can be done by setting GCM_INTERACTIVE to NEVER.

We will disable auto fetching in November.
Closing this as once that is done, the issue is with each credential manager, not Code.


setRef is possibly leaky

Did some experimenting after reading reactjs/reactjs.org#834 and it turns out that changing a *ref prop can indeed cause a memory leak if it is handled by utils/reactHelpers#setRef. React will automatically clean up every ref attached to a node on update/unmount but every ref that is not attached to the node will still hold a reference to that node.
Live example: https://codesandbox.io/s/pkm11r8kjx
We would need to bookkeep every *ref prop that is passed to one of our components during its lifecycle and clean it up on cDU and cWU.
Not sure if this has any actual impact. Just documenting it in case someone actually encounters this issue.

A fix naturally emerges by using a custom hook:
// useForkRef.js
export default function useForkRef(refA, refB) {
  /**
   * This will create a new function if the ref props change.
   * This means react will call the old forkRef with `null` and the new forkRef
   * with the ref. Cleanup naturally emerges from this behavior
   */
  return useCallback(
    refValue => {
      setRef(refA, refValue);
      setRef(refB, refValue);
    },
    [refA, refB]
  );
}
// usage.js
function Component({ buttonRef: buttonRefProp }) {
  const buttonRef = React.useRef();
  const handleRef = useForkRef(buttonRef, buttonRefProp);

  React.useEffect(() => buttonRef.current.focus(), []);

  return <button ref={handleRef} />
}

The codesandbox is updated.
Once every component that uses setRef is a function component we can use this hook instead and make setRef private.

@eps1lon I believe that we solve the problem correctly now. Do we need the issue to be open? Is there any work left to be done?

I'll take a look.

Menu and RootRef still use it. Menu looks safe but RootRef is not. Until we remove this component we should keep this open for visibility.

I could not reproduce this error with functional components. There is my try - draft
Everything seems to work correctly.


Deconz integration stops updating sensors

Home Assistant release with the issue:
0.96.5
Last working Home Assistant release (if known):
unknown
Operating environment (Hass.io/Docker/Windows/etc.):
hass.io on top  of debian
Component/platform:
https://www.home-assistant.io/components/deconz/
Description of problem:
Last night  when everybody was asleep deconz stopt getting updates via the websocket and sensors where no longer updated.
Switching on lights worked, but home-assistant is not showing the right status
things tried to get it working again in order of attempt

restart deconz addon
trigger a deconz refresh service call
restart deconz addon again
restart homeassistant ( Configuration -> General -> Restart )

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
Integration, without entries in the config
Filtered log:
cut to the first 160 chars due to the very long lines. filtered on related log line
2019-07-29 05:03:10 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"config":{"battery":100,"on":true,"reachable":true,"temperature":2800},"e":"changed
2019-07-29 05:03:10 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"8","r":"sensors","state":{"lastupdated":"2019-07-29T03:03:10","
2019-07-29 05:06:48 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"1","r":"sensors","state":{"dark":true,"daylight":false,"lastupd
Jul 29 09:28:36 johnny5 hassio-supervisor[27023]: 19-07-29 07:28:36 INFO (SyncWorker_4) [hassio.docker.interface] Stop addon_core_deconz application
Jul 29 09:28:41 johnny5 hassio-supervisor[27023]: 19-07-29 07:28:41 INFO (SyncWorker_4) [hassio.docker.interface] Clean addon_core_deconz application
Jul 29 09:28:42 johnny5 hassio-supervisor[27023]: 19-07-29 07:28:42 INFO (SyncWorker_19) [hassio.docker.addon] Start Docker add-on homeassistant/amd64-addon-deconz with version 3.1
2019-07-29 09:32:32 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{"on": true}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/action
2019-07-29 09:32:32 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'/groups/1/action/on': True}}]
2019-07-29 09:32:37 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{"on": true}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/action
2019-07-29 09:32:37 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'/groups/1/action/on': True}}]
2019-07-29 09:32:39 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{"on": true, "bri": 86}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/action
2019-07-29 09:32:39 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'/groups/1/action/on': True}}, {'success': {'/groups/1/action/bri':
2019-07-29 09:32:42 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{"on": true, "bri": 2}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/action
2019-07-29 09:32:42 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'/groups/1/action/on': True}}, {'success': {'/groups/1/action/bri':
2019-07-29 09:32:43 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{"on": true}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/action
2019-07-29 09:32:43 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'/groups/1/action/on': True}}]
2019-07-29 09:33:30 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{"on": true}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/action
2019-07-29 09:33:30 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'/groups/1/action/on': True}}]
2019-07-29 09:33:34 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/scenes/2/recall
2019-07-29 09:33:34 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'id': '2'}}]
2019-07-29 09:33:35 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/scenes/1/recall
2019-07-29 09:33:35 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'id': '1'}}]
2019-07-29 09:33:37 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/scenes/3/recall
2019-07-29 09:33:37 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'id': '3'}}]
2019-07-29 09:36:39 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/scenes/2/recall
2019-07-29 09:36:39 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'id': '2'}}]
2019-07-29 09:36:45 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/scenes/3/recall
2019-07-29 09:36:45 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'id': '3'}}]
Jul 29 09:38:31 johnny5 hassio-supervisor[27023]: 19-07-29 07:38:31 INFO (SyncWorker_16) [hassio.docker.interface] Stop addon_core_deconz application
Jul 29 09:38:41 johnny5 hassio-supervisor[27023]: 19-07-29 07:38:41 INFO (SyncWorker_16) [hassio.docker.interface] Clean addon_core_deconz application
Jul 29 09:38:45 johnny5 hassio-supervisor[27023]: 19-07-29 07:38:45 INFO (SyncWorker_17) [hassio.docker.addon] Start Docker add-on homeassistant/amd64-addon-deconz with version 3.1
2019-07-29 09:41:46 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{"on": true}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/lights/2/state
2019-07-29 09:41:46 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'/lights/2/state/on': True}}]
2019-07-29 09:43:12 DEBUG (MainThread) [pydeconz.utils] Sending {} to http://<IP_ADDRESS>:40850/api/09FD313F66
2019-07-29 09:43:12 DEBUG (MainThread) [pydeconz.utils] HTTP request response: {'config': {'UTC': '2019-07-29T07:43:12', 'apiversion': '1.16.0', 'backup': {'err
2019-07-29 09:43:12 DEBUG (MainThread) [pydeconz] {'config': {'UTC': '2019-07-29T07:43:12',
2019-07-29 09:46:19 INFO (MainThread) [pydeconz] Shutting down connections to deCONZ.
2019-07-29 09:46:19 DEBUG (MainThread) [pydeconz.websocket] Websocket stopped
2019-07-29 09:46:29 ERROR (MainThread) [homeassistant.components.hassio.handler] Timeout on /homeassistant/restart request
2019-07-29 09:47:29 DEBUG (MainThread) [pydeconz.utils] Sending {} to http://<IP_ADDRESS>:40850/api/09FD313F66
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.utils] HTTP request response: {'config': {'UTC': '2019-07-29T07:47:31', 'apiversion': '1.16.0', 'backup': {'err
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz] {'config': {'UTC': '2019-07-29T07:47:31',
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] All created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Kitchen created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] TRADFRI remote control 2 created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Light 1 created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Light 2 created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Light 3 created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Daylight created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Slaapkamer created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Slaapkamer created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Zolder created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Zolder created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] TRÅDFRI remote control created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Woonkamer knop created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Woonkamer created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Woonkamer created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] Window / Door Sensor created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.deconzdevice] CLIP-Sensor TOOGLE-ON-OFF created as
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.websocket] Websocket starting
2019-07-29 09:47:32 DEBUG (MainThread) [pydeconz.websocket] Websocket running
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz.utils] Sending {'data': '{}'} to http://<IP_ADDRESS>:40850/api/09FD313F66/groups/1/scenes/3/recall
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz.utils] HTTP request response: [{'success': {'id': '3'}}]
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"2","r":"lights","state":{"alert":null,"bri":254,"on":false,"rea
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"3","r":"lights","state":{"alert":null,"bri":254,"on":false,"rea
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"1","r":"groups","state":{"all_on":false,"any_on":false},"t":"ev
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz] Unsupported event {'e': 'scene-called', 'gid': '1', 'r': 'scenes', 'scid': '3', 't': 'event'}
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"scene-called","gid":"1","r":"scenes","scid":"3","t":"event"}
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz] Unsupported event {'e': 'changed', 'id': '65520', 'r': 'groups', 'state': {'all_on': False, 'any_on': False},
2019-07-29 09:48:39 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"65520","r":"groups","state":{"all_on":false,"any_on":false},"t"
2019-07-29 09:56:19 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"config":{"battery":95,"offset":0,"on":true,"reachable":true},"e":"changed","id":"1
2019-07-29 09:56:19 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"10","r":"sensors","state":{"lastupdated":"2019-07-29T07:56:19",
2019-07-29 09:56:19 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"config":{"battery":95,"offset":0,"on":true,"reachable":true},"e":"changed","id":"1
2019-07-29 09:56:19 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"11","r":"sensors","state":{"humidity":5704,"lastupdated":"2019-
2019-07-29 09:58:00 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"10","r":"sensors","state":{"lastupdated":"2019-07-29T07:58:00",
2019-07-29 09:58:00 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"e":"changed","id":"11","r":"sensors","state":{"humidity":5686,"lastupdated":"2019-
2019-07-29 09:58:43 DEBUG (MainThread) [pydeconz.websocket] Websocket data: {"config":{"battery":100,"on":true,"reachable":true,"temperature":2600},"e":"changed

Additional information:
setup is:

deconz stick
2 ikea lights
1 TRADFRI remote
3 xiaomi temperature sensors
1 xiaomi dual button switch

Hi! Thanks for reporting.
It is hard to do anything here, there are no errors or any weird stuff and I have seen no other reports similar to this behaviour. If web socket goes down it should automatically try to reconnect, that didn't happen here. The problem might be in the deconz add-on or an instability in your system or an error did occur in the integration but no logs to support that unfortunately.
Unless this is reproducible I recommend we close this issue.
/R

I have the exact same issue with deCONZ and IKEA bulbs (RPi3 on HASS.IO with ConBee II).
If the payload of the light.turn_on service has both (brightness and color_temp) inside, the color_temp changes, but the brightness does not. It flickers briefly as if it was trying to set the requested brightness but then goes back to current brightness.
If the payload has only of them it works without any issues. Very weird.
Are there dependencies which are the same for ZHA and deCONZ? Maybe it's a problem in a common dependency... If I can help please let me know what I should do.
@frenck As you also have deCONZ with ConBee II and IKEA lights: Do you also face the same issue? Thanks in advance.

@Kane610 i had some ideas for reproducing this issue after a talk with frenck, i hope to have time this evening to try them out, if it works i'll add a scenario which would trigger the same problem

Scenario what we had in mind was

block all traffic to the websocket
iptables -I INPUT -s <IP_ADDRESS> -p tcp --sport 40860 --jump DROP
restart deconz
unblock websocket traffic
iptables -F INPUT

It didn't work, a reconnect happened like it should have.. atm i don't have a idea howto reproduce the issue.
I agree that closing it is the best option

Thanks for trying to reproduce it @mjrider!


Add leading_fractional_zeros method to APyFixed

This method should be replaced with something that directly considers the binary representation:
https://github.com/apytypes/apytypes/blob/5ea5a4632b7dd98ef71526ff83b1602736249592/src/apyfloat.cc#L1153-L1162

Maybe one should also add larger_than_equal_one and larger_than_equal_two methods to APyFixed (C++, not Python) which checks that on a bit level. Should be more efficient that comparing with another fixed-point one and two with all the casting involved.

The following methods were added in #218:

APyFixed.leading_zeros() -> int
APyFixed.leading_ones() -> int
APyFixed.leading_signs() -> int
APyFixed.leading_fractional_zeros() -> int

When replacing APyFloat::leading_zeros_apyfixed() with APyFixed::leading_fractional_zeros, a single unit test failed in lib/tests/apyfloat/test_arithmetic.py. @Theodor-Lindberg promised to have a look at the failing unit test.

@miklhh The failing unit test we looked at yesterday was due to what I believe is a bug in leading_fractional_zeros, see issue  #224. However I ended up not using that particular function, so APyFloat::leading_zeros_apyfixed has now been updated in PR #223.

@Theodor-Lindberg, good catch, thank you. Fixed in #232. Closed.


5.1 VPC Block Template Jan 24

The new version of block driver i.e v5.1.19 which fix CVEs
CVE-2023-3446      Active          openssl-libs and openssl-libs   Upgrade 2 packages. Re-run command with --extended to view.
CVE-2023-3817      Active          openssl-libs and openssl-libs   Upgrade 2 packages. Re-run command with --extended to view.
CVE-2023-5678      Active          openssl-libs and openssl-libs   Upgrade 2 packages. Re-run command with --extended to view.

Please make following changes in PR:

Mark 5.0 version as deprecated here: https://github.com/IBM/ibm-satellite-storage/blob/develop/config-templates/ibm/ibm-vpc-block-csi-driver/5.0/metadata.json#L5
Change the default version of vpc block template to 5.1 here
https://github.com/IBM/ibm-satellite-storage/blob/develop/config-templates/template_list.json#L126

@mssachan Updated


Add missing test to test added commit stage is added if enabled.

Add missing test to test added commit stage is added if enabled.
There was a bug introduced in 9cbdda1. Added missing tests that would have caught that error.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @scwhittle for merge approval


fix typo

missing the @ in the import 🙃

Please refer to #1463

Ah gotcha, there may still need to be something done here though as in the astro config vs code is complaining with the message "Cannot find module 'unocss/astro' or its corresponding type declarations."

啊，尽管在 astro 配置 vs 代码中的通知消息中出现了“找不到模块”，但这里可能仍然需要做一些事情。

Yes, i make a new PR at #1484, maybe can resolve it.

Great thanks 🙏


Declare IDs as Any in API docstrings

… so we can change our mind about their type in the future.

@hannes-ucsc just to clarify, this is so we could do something like make job store ID an object?

Yes.


Update cra-guide.mdx

Closes #
📝 Description

Add a brief description

using yarn
yarn create-react-app my-app --template [template-name]
⛳ Current behavior (updates)

Please describe the current behavior that you are modifying
at create"-"react-app, it need to add "-"

🚀 New behavior

Please describe the behavior or changes this PR adds
correct a wrong command

💣 Is this a breaking change (Yes/No):

Yes for beginner
📝 Additional Information

The docs are correct here. Please try the command and you'll see that it works.


Possible to pass through the hostname and the tag fields to the remote syslog?

I have an architecture where I get parsed fields to fluentd. I then have a requirement to send these events to a remote syslog in addition to sending to ES. I tested with your plugin and it works well except that I was interested in sending the original hostname and the tag (program) to the remote syslog. Is that possible?

Ok, playing a bit more with the configs, it seems all I had to do is set place holders for program and hostname.

program ${ident}
hostname ${host}
<buffer ident,host>

I'm closing the issue.

@samitpal can you share your config?


freebayes running for > 4 weeks over tandem repeat region

Hi,
I am calling variants over a 12  Kb region for about 700 individuals. It seems to have stuck at a region which includes short tandem repeats. I am also including the reference genome sequence of this region below. The process has been running for about 4 weeks now and the vcf file has not been updated after a few days after it was started. This seem to depend on the number of samples and the depth of data as I have run the same command before with a smaller data set without issues (took  ~3-4 days).
the exact command I am running is:
freebayes -r chr1:189723-201721 \
-v /opt/analysis/contig_vcfs/chr1_0.vcf \
--pooled-continuous \
--min-alternate-fraction 0.01 \
--min-alternate-count 2 \
--min-alternate-total 10 \
-f genome.fa -L bamlist.txt

Read depth in the region is on average ~100 and maximum ~2000.
Region sequence:
GGTGGTGATAATAAAGGTGGTGATAAAAAGGGTGGTGATAATAAAGGTGGTGATAAAAAGGGTGATGATAAAAAGGGTGATGATAATAAAGATGACGATAACGATGACGATGATGATGACGATGACAATGATGATGATGATGATGACGAAAGCACCATTAG
freebayes version 1.3.1

--min-repeat-entropy 0 option might work.

What version of freebayes is this?
I resolved this issue in 1.3.1.
On Sun, Jan 12, 2020, 03:27 zhangrengang<EMAIL_ADDRESS>wrote:

--min-repeat-entropy 0 option might work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQENP63F67WWHHAZYPKLQ5J5YZA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWQFAY#issuecomment-573375107,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQELJP4RMNLO6FNCR7YTQ5J5YZANCNFSM4KC5WB2Q
.

What version of freebayes is this? I resolved this issue in 1.3.1.
…
On Sun, Jan 12, 2020, 03:27 zhangrengang @.***> wrote: --min-repeat-entropy 0 option might work. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#582?email_source=notifications&email_token=AABDQENP63F67WWHHAZYPKLQ5J5YZA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWQFAY#issuecomment-573375107>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQELJP4RMNLO6FNCR7YTQ5J5YZANCNFSM4KC5WB2Q .

Using v1.3.1-dirty

--min-repeat-entropy 0 option might work.

It did not help.
I also tried --limit-coverage 100, -E 1, -B 1  as well as removing --pooled-continuousto no avail so far.

Is the coverage 2000x per sample?
On Sun, Jan 12, 2020, 17:00 aydemiro<EMAIL_ADDRESS>wrote:

--min-repeat-entropy 0 option might work.
It did not help.
I also tried --limit-coverage 100, -E 1, -B 1 as well as removing
--pooled-continuousto no avail so far.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQENAKGSMPMTA6MTZMALQ5M5C3A5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5MHA#issuecomment-573429276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEKSJVERDMSG6SM2V5TQ5M5C3ANCNFSM4KC5WB2Q
.

Is the coverage 2000x per sample?
…
On Sun, Jan 12, 2020, 17:00 aydemiro @.***> wrote: --min-repeat-entropy 0 option might work. It did not help. I also tried --limit-coverage 100, -E 1, -B 1 as well as removing --pooled-continuousto no avail so far. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#582?email_source=notifications&email_token=AABDQENAKGSMPMTA6MTZMALQ5M5C3A5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5MHA#issuecomment-573429276>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEKSJVERDMSG6SM2V5TQ5M5C3ANCNFSM4KC5WB2Q .

Yes, some samples have 2000x coverage in the region. But limiting coverage to 100 also did not help.

That's a lot of depth in total.
Do you want to have full calls for everything? You might want to set
--use-best-n-alleles to something small, say 4 to 7 to try to get through
the region.
If you just want to be able to process the region, you can use -g
--skip-coverage. This is for the total coverage among all samples. If
coverage goes above this, the reads are only counted until coverage goes
back below the threshold.
On Sun, Jan 12, 2020, 17:10 aydemiro<EMAIL_ADDRESS>wrote:

Is the coverage 2000x per sample?
… <#m_2838097485362195424_>
On Sun, Jan 12, 2020, 17:00 aydemiro @.***> wrote: --min-repeat-entropy
0 option might work. It did not help. I also tried --limit-coverage 100, -E
1, -B 1 as well as removing --pooled-continuousto no avail so far. — You
are receiving this because you commented. Reply to this email directly,
view it on GitHub <#582 https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQENAKGSMPMTA6MTZMALQ5M5C3A5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5MHA#issuecomment-573429276>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEKSJVERDMSG6SM2V5TQ5M5C3ANCNFSM4KC5WB2Q
.
Yes, some samples have 2000x coverage in the region. But limiting coverage
to 100 also did not help.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQEJNDWGWV2R2LVUOA3TQ5M6HBA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5T5I#issuecomment-573430261,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEP5MS6RJETDQZAZC7LQ5M6HBANCNFSM4KC5WB2Q
.

That's a lot of depth in total. Do you want to have full calls for everything? You might want to set --use-best-n-alleles to something small, say 4 to 7 to try to get through the region. If you just want to be able to process the region, you can use -g --skip-coverage. This is for the total coverage among all samples. If coverage goes above this, the reads are only counted until coverage goes back below the threshold.
…
On Sun, Jan 12, 2020, 17:10 aydemiro @.> wrote: Is the coverage 2000x per sample? … <#m_2838097485362195424_> On Sun, Jan 12, 2020, 17:00 aydemiro @.> wrote: --min-repeat-entropy 0 option might work. It did not help. I also tried --limit-coverage 100, -E 1, -B 1 as well as removing --pooled-continuousto no avail so far. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#582 <#582>?email_source=notifications&email_token=AABDQENAKGSMPMTA6MTZMALQ5M5C3A5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5MHA#issuecomment-573429276>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEKSJVERDMSG6SM2V5TQ5M5C3ANCNFSM4KC5WB2Q . Yes, some samples have 2000x coverage in the region. But limiting coverage to 100 also did not help. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#582?email_source=notifications&email_token=AABDQEJNDWGWV2R2LVUOA3TQ5M6HBA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5T5I#issuecomment-573430261>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEP5MS6RJETDQZAZC7LQ5M6HBANCNFSM4KC5WB2Q .

-g allows the process to finish but does not call any variants in that region.

That's a lot of depth in total. Do you want to have full calls for everything? You might want to set --use-best-n-alleles to something small, say 4 to 7 to try to get through the region. If you just want to be able to process the region, you can use -g --skip-coverage. This is for the total coverage among all samples. If coverage goes above this, the reads are only counted until coverage goes back below the threshold.
…
On Sun, Jan 12, 2020, 17:10 aydemiro @.> wrote: Is the coverage 2000x per sample? … <#m_2838097485362195424_> On Sun, Jan 12, 2020, 17:00 aydemiro @.> wrote: --min-repeat-entropy 0 option might work. It did not help. I also tried --limit-coverage 100, -E 1, -B 1 as well as removing --pooled-continuousto no avail so far. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#582 <#582>?email_source=notifications&email_token=AABDQENAKGSMPMTA6MTZMALQ5M5C3A5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5MHA#issuecomment-573429276>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEKSJVERDMSG6SM2V5TQ5M5C3ANCNFSM4KC5WB2Q . Yes, some samples have 2000x coverage in the region. But limiting coverage to 100 also did not help. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#582?email_source=notifications&email_token=AABDQEJNDWGWV2R2LVUOA3TQ5M6HBA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW5T5I#issuecomment-573430261>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEP5MS6RJETDQZAZC7LQ5M6HBANCNFSM4KC5WB2Q .

I thought --limit-coverage 100 option would help with reducing the total coverage to a reasonable number. I was also thinking --limit-coverage would subsample the reads per sample to 100, but the DP values for samples were still above 100 when I used this option. Is that expected?

Do you want to have full calls for everything? You might want to set --use-best-n-alleles to something small, say 4 to 7 to try to get through the region.

I would like to have full calls, but I'll try to set --use-best-n-alleles to 4 just to see what happens.
I am actually more interested in the variant set rather than the actual genotypes. So if you think calculating genotypes is the time consuming part and there is a way to somehow eliminate that step, that could work.

It's just slow to process million-order depth. It will make it go faster to
consider fewer alleles.
You might also try to limit the haplotype window. That is probably taking a
lot of time. It's not a cheap algorithm, but it is usually applied at much
lower depths. --haplotype-length 0
On Sun, Jan 12, 2020, 17:46 aydemiro<EMAIL_ADDRESS>wrote:

Do you want to have full calls for everything? You might want to set
--use-best-n-alleles to something small, say 4 to 7 to try to get through
the region.
I would like to have full calls, but I'll try to set --use-best-n-alleles
to 4 just to see what happens.
I am actually more interested in the variant set rather than the actual
genotypes. So if you think calculating genotypes is the time consuming part
and there is a way to somehow eliminate that step, that could work.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQEN5O4QVRS7QJUXNNW3Q5NCO7A5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIW6QUY#issuecomment-573433939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEIQI3USHK64DMRD3Z3Q5NCO7ANCNFSM4KC5WB2Q
.

It's just slow to process million-order depth. It will make it go faster to consider fewer alleles.
I am a little confused about the --limit-coverage option. Even if I set a per sample coverage limit to 100 here, will freebayes still try to process the million-order depth?

Limiting allele number to 4 resolved the issue, but obviously this is not optimal as it likely means we are missing most of the alleles in the sample set.

You might also try to limit the haplotype window. That is probably taking a lot of time. It's not a cheap algorithm, but it is usually applied at much lower depths. --haplotype-length 0
--haplotype-length 0, or -1 did not help.

Is the depth in this region expected?
You can set this higher until things slow down too much. Try 10, 20...
On Mon, Jan 13, 2020, 03:02 aydemiro<EMAIL_ADDRESS>wrote:

It's just slow to process million-order depth. It will make it go faster
to consider fewer alleles.
I am a little confused about the --limit-coverage option. Even if I set a
per sample coverage limit to 100 here, will freebayes still try to process
the million-order depth?
Limiting allele number to 4 resolved the issue, but obviously this is not
optimal as it likely means we are missing most of the alleles in the sample
set.
You might also try to limit the haplotype window. That is probably taking
a lot of time. It's not a cheap algorithm, but it is usually applied at
much lower depths. --haplotype-length 0
--haplotype-length 0, or -1 did not help.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQEIHWD66BK726RC4CULQ5PDSRA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXLBRY#issuecomment-573485255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEOAX5TGYIQK3BVQEOLQ5PDSRANCNFSM4KC5WB2Q
.

This is targeted sequencing data, so this type of coverage is not unexpected for most of the regions. Other regions of similar or higher coverage go through just fine.
So when we restrict the number of alleles this way, what happens to samples with another allele. So let's say there are 5 samples each having a unique allele and we limit the calls to 4 alleles. Would the 5 sample be called reference or assigned the best fitting allele of the 4 best?

They'll be assigned the best-fitting genotype composed of the given alleles.
On Mon, Jan 13, 2020 at 4:49 PM aydemiro<EMAIL_ADDRESS>wrote:

This is targeted sequencing data, so this type of coverage is not
unexpected for most of the regions. Other regions of similar or higher
coverage go through just fine.
So when we restrict the number of alleles this way, what happens to
samples with another allele. So let's say there are 5 samples each having a
unique allele and we limit the calls to 4 alleles. Would the 5 sample be
called reference or assigned the best fitting allele of the 4 best?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQEO77JST2EOJSL7VTR3Q5SEPFA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZGXSA#issuecomment-573729736,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEMTQEN2CX7VPA3PGL3Q5SEPFANCNFSM4KC5WB2Q
.

OK. I'll run with different numbers and share the results.
Do you have a good idea what is causing the problem when allele numbers are high? Maybe I can help addressing it.

The problem is usually that there will be regions of low complexity or
clusters of variants in single reads where the haplotype calling is
attempted. This is kind of expensive, because the algorithms used to set up
the call can have quadratic costs in read depth and haplotype window size.
But without profiling, it's hard to know. The problem could be genotyping
complexity.
In either case, restricting the number of alleles can help.
It occurs to me that another way to address this is to set a higher number
of observations to consider an allele. If your depth is really high, then
you should be requiring a lot of observations to consider anything. Try
setting -C 10 or something similar. This is more data-driven and may
achieve the same result. You might want to try high still, such as 20, 30,
etc.
On Mon, Jan 13, 2020 at 4:58 PM aydemiro<EMAIL_ADDRESS>wrote:

OK. I'll run with different numbers and share the results.
Do you have a good idea what is causing the problem when allele numbers
are high? Maybe I can help addressing it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/582?email_source=notifications&email_token=AABDQEMCRQSHVZKFBHZUYITQ5SFSLA5CNFSM4KC5WB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZH4DQ#issuecomment-573734414,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEKV6GHMBKTAMFDD3RTQ5SFSLANCNFSM4KC5WB2Q
.


Test typings

Improve typings for mockClient and mockRequest.

Looks like this breaks the tests for return type string. We could add a type type Predicate = (value: any) => boolean and add it to the url union.

I think this has been fixed in #170


feat:Issue #96 Highlighting new cases in last 3 days

Any reason why this is limited last 3 days? Maybe a slider setting to select how many days back to select? That would be really helpful.


Redesign: Update page background panel

Feature Description
See Figma

[ ] Merge with page background size position
[ ] Update title
[ ] Update toggles for media bg
[ ] Update media display for media bg
[ ] Update color for shape bg

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


⚠ Thumbnails API Endpoint has degraded performance

In bb29516, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1848 ms

Resolved: Thumbnails API Endpoint performance has improved in 83c6cde after 1 day, 8 hours, 52 minutes.


Made ETIT logo background transparent

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Added here https://github.com/TrustWallet/tokens/commit/2125df20e570f2a8f01e5c1515dc22a0b2700b5d


Add "Render Rect Clip"

In SDL, there is a function called SDL_RenderSetClipRect.
As explained on a gamedev stackexchange answer, this function sets a "clip rectangle" where anything that would be rendered within this rectangle will be in fact rendered, while anything outside this rectangle will be discarded.
This is very useful for many contexts, especially on UI (for instance, this function is required to use nene with micro-ui library)

implemented at 0a3e1d1111fbdc85a3fac3190fcfdfa252892c4a


Added #o (octal) and #b (binary) to the supported external representa…

…tions.
I needed octal to conveniently deal with some Unix file permissions code, and added binary while I was at it.

Merged. Thanks!


Don't sort as this prevents randomization

Fixes #390

Codecov Report

Merging #391 into master will decrease coverage by 0.32%.
The diff coverage is 100%.

Good spot!