Dropdown not Exact width of Select Container (Simple Solution)

I noticed when using this that the dropdown width would always be about 1px off either wider or narrower than the select. Not really a big deal but when using 1px borders, it just looks "wrong".
This seems to happen when you have the select set to a percentage in a responsive layout.
The solution is easy. Since .outerWidth rounds the pixels, you can use a different means of getting the exact width.
On line 4249 I changed this...
  AttachBody.prototype._resizeDropdown = function () {
    var css = {
      width: this.$container.outerWidth(false) + 'px'
    };

To this....
  AttachBody.prototype._resizeDropdown = function () {
    var css = {
      width: this.$container.get(0).getBoundingClientRect().width + 'px'
    };

This is an easy fix for those interested :)

Thanks for working that out! Looks now perfectly smooth!

Any chance to have this fix also in the distributed source code?

This is a duplicate of #1692.


fix(vm): update color picker binding

Fixes #1419

Pull Request Test Coverage Report for Build 1358

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.554%

Totals

Change from base Build 1356:
0.0%

Covered Lines:
8263

Relevant Lines:
13552

💛  - Coveralls


Large file render slowly and confused range request.

Attach (recommended) or Link to PDF file here:
https://drive.google.com/file/d/17K-xn1hCAA1wzoG69DnfXhScfK1XrXr5/view?usp=sharing
Configuration:

Web browser and its version: Chrome Firefox Safari
Operating system and its version: mac m1 12.6
PDF.js version: 2.2.228

Steps to reproduce the problem:
const loadingTask = this.getDocument({
    url,
    disableStream: true,
    disableAutoFetch: true,
})
 loadingTask.promise.then(function (pdf) {
   pdf.getPage(1).then(function (page) {
    // Simple codes draw canvas...
    const context = canvas.getContext('2d')
    const scale = (vm.viewerWidth / 2 /  viewport.width).toFixed(2)
    const scaledViewport = page.getViewport({
      scale: scale * 2
    })
    const renderContext = {
      canvasContext: context,
      viewport: scaledViewport
    }
    const renderTask = page.render(renderContext)
    renderTask.promise.then(function (e) {
        // Here, the end of render is very slow
    }
  }
}

What is the expected behavior?
Render quickly. Or reasonable range request.
What went wrong?
We are loading the pdf in pages.
As the second page has 37mb, resulting in a very slow loading, also its range request is also very strange, with the default chunkSize: 64kb but it is the last fetch has 37.2mb.
Try to use cdn to introduce pdfjs but the result is the same, in chrome safari Firefox result is also the same fetch is very slow.
What do you suggest? Thanks!

PDF.js version: 2.2.228

That version is over three years old and thus no longer supported, please update to a supported release before reporting a bug or asking for help; please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

Steps to reproduce the problem:

Please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


all: test that all examples run on golang.org, i.e. the playground

Right now, examples are only run via go test by the trybots. That checks whether or not they run as tests, but it doesn't check if they run in the playground.
For instance, see #19823. That example depends on its own test file, example_test.go. That will be available if one runs go test, but not if one presses "Run" in https://golang.org/pkg/go/parser/#example_ParseFile which will run it in the playground.
There should be a mechanism to ensure that all of the examples run on the golang.org docs too. In other words, that they pass when executed in the playground.

Perhaps there could be a separate trybot for this, similar to how there are race trybots. Not sure how the playground could be hooked up - not familiar enough with it.
CC @josharian

We have a nacl builder, which should run the examples. That should cover this, although I'm obviously wrong about that somehow.

But I understand the nacl builder just does go test like the rest, correct?

go test runs examples, though.

Yes, but if I understand correctly the nacl builder will still have example_test.go when it runs that particular example via go test.

I'm still obviously wrong somewhere, but each executed nacl process should not have access to the filesystem once started.

Ah, that makes sense and should do the trick. But it obviously doesn't :)
Perhaps we should add a test that only runs on nacl that checks that its own test file doesn't exist in disk, or that it cannot be opened?

I'd say the first step is figuring out exactly why #19823 was passing on nacl.

As to why it passes, src/naclmake.bash packages up a fake file system for nacl tests according to misc/nacl/testzip.proto. On line 127 there it includes everything beneath src/go/parser which includes example_test.go.
Maybe the playground should use the same packaged filesystem?

Do we know how many examples fail to run in Playground? Have anyone tried to calculate that?

Do we know how many examples fail to run on playground?
@jimmyfrasche

This isn't up to date, but I did a run through earlier this year: https://github.com/golang/go/issues/9679#issuecomment-374062421
Since there have been improvements to how go/doc extracts examples, allowing more to be playable, some fixed examples, and more examples overall, someone's just going to need to run through each example and hit play (preferably a trybot).
I don't have a count but it's more than 1, so it's enough to warrant attention and action.


Preview of wrong file is opened in Sharepoint

Description
Preview of wrong file is opened, only index page Preview can be opened from folder.
To Reproduce
Steps to reproduce the behavior:

Install AEM sidekick extension to Chrome browser https://chrome.google.com/webstore/detail/aem-sidekick/ccfggkjabjahcjoljmgmklhpaccedipo
Go to project folder in Sharepoint
Right Click on extension icon > Add this project
Create new file and edit it
Select the file from Sharepoint folder > Preview

Expected behavior
Selecting file and clicking Preview opens Index page
Screenshots

:tada: This issue has been resolved in version 6.23.0 :tada:
The release is available on:

GitHub release
v6.23.0

Your semantic-release bot :package::rocket:

Issue is no longer reproducible, verified on 30.06.2023


miden-stdlib docs failing to build for docs.rs

Looks like the custom build script for miden-stdlib is failing to run on the docs.rs pipeline due with an error stating that the filesystem is read-only: https://docs.rs/crate/miden-stdlib/0.8.0/builds/1140597
As a consequence, the client docs are also failing to build as well: https://docs.rs/crate/miden-client/0.1.0/builds/1159375

related: https://github.com/0xPolygonMiden/miden-vm/issues/1208

Ah - seems like this is an exact duplicate of #1208. So, I'll close this one in favor of that one.


Remove PRIMITIVES from public API

This is very unlikely to have been used in any third party code so I don't think this needs to be tagged as a breaking change.

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

  Generated by :no_entry_sign: dangerJS against 656dc1129a38b5d7e2335ddb2df84fd61b61809f


While fetching offsets on startup metadata is not refreshed on error

When the application is unable to fetch offsets due to the following error
[ERROR] aiokafka.consumer.fetcher Failed fetch offsets from 2: [Error 6] NotLeaderForPartitionError: TopicPartition(topic='xyz`)
it does not force a metadata update and instead just keeps retrying

When this happens on startup faust is unable to recover by setting highwater offsets as -1


Performance monitoring test

Performance is an important strength of CuPy.
For better quality assurance, it is nice to have a way to "fixed-point observation" of performance.
By having a baseline set of benchmarks, we can:

Correctly evaluate performance improvement for each pull-requests
Detect unexpected performance regression

NumPy has a set of benchmark codes to run on Airspeed Velocity.
https://github.com/numpy/numpy/tree/master/benchmarks
I haven't tested them yet, but NumPy benchmark code seems so simple that we can borrow them and then do s/np/cp/.  It may be a good start point.
https://github.com/numpy/numpy/tree/master/benchmarks/benchmarks
We may however want some additional metrics like:

memory allocation performance
comparison with NumPy

We will also need to measure both GPU and CPU time.
FYI, I wrote a tool called cupy-perf (I think it's similar to NumPy's benchmark above) and using it personally.
https://github.com/niboshi/cupy-perf

Thank you for pointing it out and introducing a tool!
We'll need to extend existing performance framework as they don't support measuring GPU time.


DTFS2-4414 - TFM GEF mapping

Summary

TFM mapping for GEF deal
TFM mapping for GEF facilities
TFM mapping for GEF facilities in a deal
TFM mapping for GEF deals combined with BSS/EWCS deals

Refactoring/improvements

refactor some deal/facility field mapping functions to be more generic and not tied to BSS/EWCS specific fields
split up deals reducer, functional
improve/add test coverage for deals and facility reducers

Template improvements for GEF variation in TFM

add ‘dash if empty’ logic to various templates
fix some template issues where things like currency code or percentage symbols would render even if there is no value

Note
This won't be able to be tested by QA as it's new mappings for GEF deals and facilities manually added to the DB. Would be great if PR reviewer could add these deals to DB and make sure TFM loads.

Thank you so much for reviewing this beast of a PR


Typo in browser isolation docs

https://github.com/cloudflare/cloudflare-docs/blob/e54ca77d4a228c2b7ecb050d629fa619a90016ce/products/cloudflare-one/src/content/policies/browser-isolation/configuration.md?plain=1#L44
I believe this sentence is a typo?

Right-click context menu be simplified

Howdy @ryan-mars, thanks for the comment!
That's actually a repo that's no longer maintained and we will be removing shortly. The updated docs are https://developers.cloudflare.com/cloudflare-one/policies/browser-isolation


Modify to work on node 4

Basically just remove all destructuring assignments/params. A lot of
services still run on Node 4, our internal policy on libs is to make
them work on whatever LTS is

ah sorry, didn't know anything other than app was using this.
what still uses node 4?


VCS: Allow to stage and commit all files with Ctrl + Enter

Closes godotengine/godot-proposals#2988.
See 3.x version of this PR: #50432.

Would probably work but I tested this anyway on my Win 10. It would be nice if this shortcut was also configurable i.e. used ED_SHORTCUT() but I can't seem to find how it can be used on a TextEdit so, for now, this might be the only way to get this functionality in.

Defined shortcut in editor settings as discussed at Godot contributors chat:

Still using signal callback, as in CodeTextEditor.

Reminder: this PR has one approval, would be nice for this to get merged before Godot 3.4 is out, see #50432 for 3.x. Note that Godot beta 2 already includes a couple of enhancements and fixes to VCS I've made in the past weeks.

Note that I've initially attempted to make this enhancement in goostengine/goost#98, but it would take me to write three times more code via modules compared to this PR. I'd like to avoid writing the type of code which is prone to crashes in case of Godot's internal API changes in some way.

Thanks!


Add style tab styling for Darkbrewery

Actually, Talking to @G-Ambatte we realized more than HALF of the original styles of darkbrewery were not being applied, for a missed class that changed when codemirror themes were introduced, so the theme is barely existing.
Will do a full work to change that.

been too long, no longer interested in the theme anyway, may pick it up later on


docs: Exclude files from TOC warnings

Sphinx was displaying "WARNING: document isn't included in any toctree"
for files we just don't want in the TOC.
This commit excludes files from such warnings, hides these docs from the
navigation sidebar, moves password-strength.md under docs/production, and
excludes _templates/layout.html from lint and template checks.
Note: _templates/layout.html is the same as the original readthedocs
layout file. Except that the value of the "includehidden" setting is now
set to False so that hidden index entries are not displayed in the nav bar.
Fixes #7417.

This change is

Hmm, when I tried this, I see them all appearing in the TOC:

hmmm I could've sworn it was working... I'll look into it

So they were not being displayed on their index.html file, and I just assumed they were not being displayed in the nav bar either. Normally, the :hidden: option would have worked.
But it turns out that the readthedocs sphinx theme adds files that were hidden from the TOC to the nav bar by default. Once I learned that it was just a matter of finding where this was happening and setting includehidden=False.

Well, this definitely works; Is that not a setting we can just set in docs/conf.py?
If we do need to include that large block of copied template code, maybe it's worth adding a comment at the top of it explaining where we got it from and how to update it (or put a link to such a description there)?  Might be good idea to do 2 commits, first one that just imports it verbatim, and then one that makes the change, so it's easier to track.  And we may want to open a bug against the default sphinx theme to make this something that can be configured in docs/conf.py, since this doesn't seem like something one should need to pull in a large template for.

No, unfortunately there's no setting for it in docs/conf.py, but I agree, it should be exposed. I'll open up an issue. Having the template there allows us to customize the theme a bit more though, so it might end up being a good thing.
Yeah, I think it's worth adding a comment. But I think the comment should go in conf.py right above the _templates line, for better visibility, since anyone looking to change that sort of setting is most likely going to look in conf.py first. I think I'll just put a link to this PR, and I'll also split the commit in two.

travisCI is failing for some reason, but it did pass all tests last night https://travis-ci.org/rosatamsen/zulip/builds/305108062 so it should be good to go.

Yeah, travis seems to be having network flakes.

Here's the issue to suggest making includehidden configurable in conf.py
https://github.com/rtfd/sphinx_rtd_theme/issues/485

Cool.  The code looks good, but the commit structure for this seems a bit off.  I think the first commit should add docs/_templates/layout.html and add all the exclude rules needed for that to not break tests.  And then second should move the files around, updated indexes, and do the patch to layout.html.  That way, each commit is correct alone, which helps both with making things incrementally mergable and also with making the history nice and readable :).

(And thanks for opening the issue!  Your report looks good.)

That makes more sense :) and the commit structure is much better now. Thanks!

Looks great, merged, thanks @rosatamsen!
I think the next thing to think about (I'm not sure what the right answer is) is how to organize "subsystems" better...


Chrome deprecation notices

Thanks a lot for this great lib! 👍
Just a question. I've got some deprecation notices in Chrome.
All seem related to same setTargetAtTime() thing.
Do you plan to make some update?
Cheers,
GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around
January 2018. Please use setTargetAtTime() instead if smoothing is needed.
See https://www.chromestatus.com/features/5287995770929152 for more details.

AudioParam value setter will become equivalent to AudioParam.setValueAtTime() in M65,
around March 2018  See https://webaudio.github.io/web-audio-api/#dom-audioparam-value
for more details.

BiquadFilterNode.frequency.value setter smoothing is deprecated and will be removed in
M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed.
See https://www.chromestatus.com/features/5287995770929152 for more details.

BiquadFilterNode.Q.value setter smoothing is deprecated and will be removed in M64,
around January 2018. Please use setTargetAtTime() instead if smoothing is needed.
See https://www.chromestatus.com/features/5287995770929152 for more details.

StereoPannerNode.pan.value setter smoothing is deprecated and will be removed in M64,
around January 2018. Please use setTargetAtTime() instead if smoothing is needed.
See https://www.chromestatus.com/features/5287995770929152 for more details.

Hey thanks for raising this issue. I'll look into it. Normally in most places we don't really rely on the automatic smoothing, but maybe we should switch to a different way of setting the audio params.

I also experienced it and can't play input live audio because of it.

I'm unable to reproduce these warnings with Pizzicato 0.6.4 on Chrome 70. Feel free to re-open if you still see them.


Copy contents of the screen between the last two vertical marks

With shell integration of the SetMark feature, one may want to copy the output of the last command into the clipboard via shortcut.
Checklist

[ ] add new Action, maybe with name CopyPreviousMarkRange - or anything better?
[ ] Implement that action in TerminalWindow::executeAction(...).
[ ] it may be that you need to implement a helper in Screen / ScreenBuffer to accesses the vertical mark indices.
[ ] maybe add a unit test for the last action point.

@uspasojevic96  wants to give this a try.

Merged


[Insights & Questions] About MIPROV2

Firstly, thanks for the amazing package! I've done a sharing session with senior tech managers in my company, and they were quite convinced. I have some interesting insights to share and also some questions to discuss.
Background
My task is quite simple: I need to optimize a signature for intention classification (only a couple of classes).

Maybe I can contribute an example use case? As text classification is one of the most common daily use cases. But unfortunately, I found the link to https://github.com/stanfordnlp/dspy/blob/main/CONTRIBUTING.md is missing...

I've done some simple ablation studies:

Optimizer: MIPROV2 0-Shot, LM: gpt-4o-mini or gpt-4o
Optimizer: MIPROV2 Few Shots, LM: gpt-4o-mini or gpt-4o

After the optimization, I did inference with the optimized prompts using gpt-4o-mini or gpt-4o and evaluated the results. I used accuracy as the metric.
Insights and Questions

Generally speaking, MIPROV2 Few Shots yields better results than MIPROV2 0-Shot.

I was a bit confused here, as the final optimized version from MIPROV2 Few Shots actually didn't contain any few-shot examples, regardless of the LM used. Although they yielded almost the same results for gpt-4o-mini inference, MIPROV2 Few Shots yielded significantly better results than MIPROV2 0-Shot when inferencing with gpt-4o.

It's quite weird, because if there were no few-shot examples in the final prompt, why would optimization using few-shot settings yield better instructions?

When inferencing with gpt-4o-mini: Using gpt-4o-mini for prompt optimization yields significantly better results than using gpt-4o, regardless of optimizer.

When inferencing with gpt-4o: When it's under 0-Shot setting, using gpt-4o-mini for prompt optimization is significantly better; when it's under Few Shots setting, using gpt-4o-mini or gpt-4o for prompt optimization yields similar results.

This could be a significant finding, as it means that we can potentially use a more cost-effective model for prompt optimization that will perform well even when applied to a much larger model.

I guess it might be because if you can write clear instructions for a small model, it naturally becomes clearer for a larger model, but not reverse. I don't know whether it makes sense or not. I will continue the study with llama 3.2 to gain more insights, I guess.

Hey thanks so much for the thoughtful questions and exporation! This is super cool. I'm tagging @XenonMolecule on this (MIPRO's co-first author).

This is really great!  Thanks for trying out these settings!

It's quite weird, because if there were no few-shot examples in the final prompt, why would optimization using few-shot settings yield better instructions?

MIPROv2 fewshot should still include fewshot examples in your prompt unless (1) your data has too few examples compared to the number of fewshot demos that you specified, or (2) Our search process finds that your program works better zeroshot than with any demos we include.  Perhaps that is the case for your program though and this could explain why it was left without fewshot demos.
In this case optimizing with fewshot demos is still possibly better because we include the fewshot demos that we've bootstrapped in the instruction proposal step.  If you are doing zeroshot we still try to bootstrap 3 demos to inform our instruction proposal model, but if you are doing fewshot we use the max number of demos you specified.  We loop over each of these demos and propose and instruction with each, so this can create a greater number of instructions and a greater diversity of instructions.

When inferencing with gpt-4o-mini: Using gpt-4o-mini for prompt optimization yields significantly better results than using gpt-4o, regardless of optimizer.

Great finding!  This doesn't fully surprise me that the model would write prompts that are good for itself.  Someone put it nicely when I was talking to them the other day that prompts written by the same model you test on will put them in a "low perplexity" space.  Essentially making the prompt more "in-distribution" for that model.

When inferencing with gpt-4o: When it's under 0-Shot setting, using gpt-4o-mini for prompt optimization is significantly better; when it's under Few Shots setting, using gpt-4o-mini or gpt-4o for prompt optimization yields similar results.

This is cool!  Some people have told me that gpt-4o-mini is better at prompt proposal than gpt-4o.  I'm not certain why, but this is fascinating!  We are building out a benchmark to sweep across models both as task models and prompt proposal models so hopefully we have a benchmark to point to soon with findings like this!

@XenonMolecule thanks for the comprehensive explanation! It's really a great learning. 😸
Looking forward to the benchmark, it would be extremely helpful for real-world application.


Update README.md with the new references to the project's URL

This just replace ocurrences of https://github.com/andyk/termproxy with https://github.com/andyk/ht

Thanks @mandx!


Does moto have support in rds-data?

asking a question
Hi,
Does moto have support in rds-data?
or more specifically at execute_statement?
In the documentation, I saw that there is no support but I wanted to make sure because it is essential for me.
Thanks

Hi @noahgrad, rds-data is not supported at all at the moment. Will mark it as an enhancement.
PR's are always welcome if you want to contribute!

Hey all, any good ideas for implementation of this? I've found some libs like local-data-api that mocks an entire service, not sure if there's a more streamlined way of doing this?

Hi @michaelhelmick, the local-data-api seems quite heavy for Moto's purpose - the implementation should be as lightweight as possible, so that rules out any Docker/Kotlin/Postgres dependencies.
There are a few operations in AWS where the user can query data, but none of them have been implemented in Moto yet, so there is no existing formula that we can follow here.
Some architectural solutions that I can think of out the top of my head:

Use SQLite, and use the query provided by the user
Pros: in-memory, light-weight
Cons: SQL dialect is different between PostGres/Aurora/etc, so only trivial queries would work
Hardcoded responses
Pros: low-maintenance, lightweight
Cons: Only usuable for a subset of users
Configurable responses - let the user supply the exact response for each query
Pros: complete flexibility
Cons: Unusual (un-moto-like) mechanism, needs user training, makes mocking much more of a pain
..?

(Disclaimer:  I don't have a preference for any of them at the moment - just braindumping to get some feedback.)
@bpandola Do you have any ideas/suggestions on how we could approach this?

Right, I didn't think local-data-api was a proper solution either. Will try to brainstorm some things and review your ideas too!

Any traction on this one?
May be a fourth option be,
Configurable connector - let the user supply the exact connector to the db
Pros: complete flexibility
Cons: Unusual (un-moto-like) mechanism, needs user training, makes mocking much more of a pain

The execute_statement is now part of moto >= 4.1.7.dev26.
By default, this will not return any records, but it is possible to configure exactly the response that you'd expect. See the documentation here: http://docs.getmoto.org/en/latest/docs/services/rds-data.html

hey @bblommers i tried the exactly whatever is mentioned in the doc but not able to get the expected result.
if you have any sample that you can share that will be very helpful
thanks


[Mac] Weird scaling when resizing the window.

Whenever I resize the window, the content stretches or squishes until you release the cursor.

Thanks for the gif and logging the issue, @mhanberg !
This is SDL2's 'default' handling for resize - it stretches the framebuffer, and then once the resize gesture is compelte, it gives us a WindowResized event.
We'll need to hook into a handler that updates us as the window is resized - looks like there is a suggestion here: https://stackoverflow.com/questions/34967628/sdl2-window-turns-black-on-resize/34996764

The weird scaling seems to be fixed on macOS for me, although it's still present on Windows. Should this issue be closed or is there more investigation needed?

Thanks @SeparateRecords for the update! Indeed, this should be fixed on Mac now with @zbaylin 's change: https://github.com/revery-ui/revery/pull/1077


Support Multiple Consoles

Hello,
So I have two consoles connected to one weather station. Since the console will publish a temperature and humidity setting, if I have two consoles both reporting to AWNET2MQTT, the values get updated to the same published entity. What ends up happening is the recorded temperature swings back and forth between the two values as each is published.
Is there a way to make it so each console gets its own sensor entity?
Thanks

Can you explain your weather station setup in more detail? You have just one weather station but two display consoles? When you configured the reporting URL did you do it on both consoles or just one?
The only identifying information I receive in the data is a "passkey", and that is used to create separate entities already. If you are seeing the values flip back and forth with two consoles it sounds like it's because they are both sending data using the same passkey (which I believe is unique to the weather station, not the console).

Sorry it took me so long to get back to you.
My setup is ONE outdoor unit, but two WS-2902 consoles. One in the kitchen and one in the garage. Essentially, the only value that would differ between the two is the "indoor" temp each reports. I had both consoles configured to report, which is probably why I was seeing the temp cycle back and forth. If each is sending the same "passkey" then the integration would assume the "indoor" temp is coming from the same console.
Is there a way for the console to report a unique value that would allow both "indoor" temp entities to co-exist?

I don't receive any data that indicates consoles. I only receive data that indicates which weather station (the passkey).
In your situation I suggest configuring only one console to send data, not both.

I figured as much, which is what I've done. Thanks for the help!


Extend NetworkInfoResponse with more P2P info

This is a backport of #285 over v1.21.0

build fails b/c the changes are "breaking" against master, but against v1.2 they're not


Does Clangd support Pull diagnostics ?

Does Clangd support Pull diagnostics - textdocument/diagnostic?

No, this is not currently implemented.

Ok, Any plans for implementing this feature?

Hey, I'm a young programmer and I want to contribute to clangd. I'm trying to get my way around it. maybe implementing this might be my first issue fix. anyone to mentor me?


Feat/configurable cert path

Before submitting this PR, please make sure:

[X] Your code builds clean without any errors or warnings
[X] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing:

PR update:

As per discussion last maintenance meeting, the error showing on the terminal of no file or directory.. gateway/conf/ssl.yml for both source and docker build should be considered as a warning and fixed after gateway has been successfully setup on the client.  Faouzi acknowledged the task and will add update to quietly not display it

Setup for source client and gateway:

Successfully installed client
Confirmed hummingbot-gateway-xxx instance only has cert folder
New directory for conf and log are now within the ../gateway/ folder
Ran gateway generate certs but getting the prompt below. It seems that it assumes the client was running on docker

Successfully setup client + gateway source build
Successfully setup AMM-Arbitrage
Tests gateway create

Did not prompt us about the command but it forced it self to create a docker image. See screen recording source-1 below
This command is designed to automate Gateway setup when you have installed Hummingbot using Docker, but it looks like you have installed Hummingbot from source. Do you want to continue?” (Yes/No)

Setup for docker client and gateway:

Successfully build docker image for client/gateway for local tests
Ran gateway create successfully
Test gateway generate_cert on docker build

Need to confirm @Faouzijedidi1 if this is the expected behavior? I haven't ran gateway create yet

For Error displaying and handling we have observed that for the client side it still displays the full error. Current commit does not support to only display the endpoint and error message in the client and leave the details on the log file

Attached:
Screen recording source-1
https://user-images.githubusercontent.com/73840223/205567370-7e430fd3-ce72-4e1e-b67d-51eeffb80a1a.mp4

Docker installation:
Issue fixed no the error showing on the terminal of no file or directory.. gateway/conf/ssl.yml
Gateway generated certs, created in ubuntu/instance_files/hummingbot_certs,
logs and config created in gateway_logs and gateway_conf
1.) Bot showed SSL configuration file not found. Please use gateway/setup/generate_conf.sh to generate it. after initial gateway generate certs for Docker installation
Steps:

clone and install feature branch
create docker image manually
./create.sh / ./start.sh docker instance of the bot
run gateway generate certs

Actual:
Bot showed promts/hints for Docker installation
(Bot showed SSL configuration file not found. Please use gateway/setup/generate_conf.sh to generate it.after initialgateway generate certs)
certs created in ubuntu/instance_files/hummingbot_certs
Expected:
Bot showed promts/hints for Docker installation
certs created in ubuntu/instance_files/hummingbot_certs

2.) then restarted the bot, bot can't find that certs already created

3.) After certs created, ran gateway create bot can't see that we use Docker installation (started with ./start.sh)

Bot showed installation from source, however it was started with ./start.sh (so that's docker installation)


Code Quality

clean the code
increase maintainability
move code out of JsPlot3D.js into modules
make a module that returns min and max values for standard cases
move normalization code into the modules in src/plotModes/*.js. (The x2 normalization in src/plotModes/Barchart.js is already there)
be vault tolerant for user input, but not for internal code. use === and !==, don't check everything for == undefined, if it has to be defined: assume it is defined. if not: fix the bug

added eslint
point 6 is pretty much done

point 3 done
point 4 done
point 5 done

and the other points probably can be considered done aswell


Throwing "Module parse failed: Unexpected token (49:38) You may need an appropriate loader to handle this file type..."

react-to-pdf not working for me. I'm using react (18.0.0), webpack bundler(4.43.0) and babel transplier(7.9.6).
It throwing

ERROR in ./node_modules/react-to-pdf/dist/module.js 49:38
Module parse failed: Unexpected token (49:38)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|             format: this.options.page.format,
|             orientation: this.options.page.orientation,
>   ...this.options.overrides?.pdf,
|             unit: "mm"
|         });

Dup of #97  and we are also getting the exact same message  React "react": "^17.0.2",   babel core 7.18.10"


Issue with infinite scroll

At times, the infinite scroll feature does not work, and in order to load the next set of images, we have to navigate to a different page and then return to the gallery.

It seems there was a misunderstanding in the description of the issue. The problem is actually the opposite. Navigating to a different view and then returning to the timeline is what breaks the infinite scroll. To fix it, you need to reload the page (e.g., Cmd-R in Safari), not navigate away and come back :)


Fails to load gem 'responsive_active_admin'

Hey just wanted to let you know the this gem can't be loaded at all. I'm running ruby 2.3.0 and rails <IP_ADDRESS> if that helps. Stack trace:
[my home folder]/.gem/ruby/2.3.0/gems/bundler-1.11.2/lib/bundler/runtime.rb:80:in `rescue in block (2 levels) in require': There was an error while trying to load the gem 'responsive_active_admin'. (Bundler::GemRequireError)

Hi @Silvertale,
Did you restart your rails server after adding the gem to your Gemfile and running bundle install?
I've not come across this myself, and I'm running a very similar setup...

Yes, the error happens when I try to start my rails app. I'll try creating a fresh (empty) rails app next week and see if that makes a difference. I'll let you know if that works
-------- Original message --------
From: Hayden Ball<EMAIL_ADDRESS>Date: 04/16/2016 1:39 PM (GMT-05:00)
To: ball-hayden/responsive_active_admin<EMAIL_ADDRESS>Cc: nicholas sallis<EMAIL_ADDRESS>Subject: Re: [ball-hayden/responsive_active_admin] Fails to load gem 'responsive_active_admin' (#7)
Hi @Silvertalehttps://github.com/Silvertale,
Did you restart your rails server after adding the gem to your Gemfile and running bundle install?
I've not come across this myself, and I'm running a very similar setup...

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/ball-hayden/responsive_active_admin/issues/7#issuecomment-210862227

Removed activeadmin 1.0.0pre1 and added newest (github) version (1.0.0pre2). Works fine now! seams like it was just an issue with pre1 :)

Strange.
Glad that upgrading ActiveAdmin sorted it though...


Integrate tlshc library, calculate telfhash and import hash in ELF module

This PR integrates the tlshc library https://github.com/avast/tlshc that provides a C implementation of the TLSH hashing function https://github.com/trendmicro/tlsh, calculates Telfhash using the TLSH hashing function, and also creates a simple MD5 hash of imported symbols for ELF files.

Some tests were failing due to the usage of md5_ctx in import_md5 not being hidden in case there is no crypto lib to support it.

The current tlsh library of Avast is missing important feature: calculate 2 hashes and give the score.
The original code has this method int totalDiff(const Tlsh *, bool len_diff=true) const;. However, there's no function like that in https://github.com/avast/tlshc/blob/main/include/tlshc/tlsh.h. Therefore, current hash comparison in Yara module is based on exact hash matching. It's not good IMO.
To use this method / function with Yara, the tlsh module needs to convert a hash from text to a struct's data. Therefore the method int fromTlshStr(const char* str); is required. It's also missing in Avast's module.
I created 2 issues on Avast's repository about 2 missing functions. Hope they update this soon.
https://github.com/avast/tlshc/issues/1
https://github.com/avast/tlshc/issues/2


adds Pipette.air_gap(vol, height)

Small PR, creates a pipette command Pipette.air_gap(), which takes two optional arguments: volume and height.

Pipette.air_gap() will automatically move 20mm above the current well, and then aspirate air until the tip is full
Pipette.air_gap(10) will automatically move 20mm above the current well, and then aspirate 10uL of air
Pipette.air_gap(10, 7) will move 7mm above the current well, and then aspirate 10uL of air

Coverage decreased (-0.06%) to 94.907% when pulling 7e1fda327894e551a9993daec8b98fbca97e35ee on 406-air-gap-function into a738c1dcbcab4263c7880026ab8f3a206ca3568c on master.

Coverage increased (+0.1%) to 95.088% when pulling 6422dc89bb48926d38d8b42009f87ed6fc900fd8 on 406-air-gap-function into a738c1dcbcab4263c7880026ab8f3a206ca3568c on master.


Add myself

Didn't test it locally, hope I didn't mess it up 🕺

Swing and a miss :smile: Your main branch is named differently from what we set as the default. I will fix it.

Thanks!


Coder: Class Name Editor should Allow Underscore

It is allowable in Pharo class names but can't be currently typed in

@seandenigris: Do you mean like this one?:

I am able to create such a class in GToolkit v0.8.278.

Yes in that editor, but when renaming; sorry should've mentioned that.

Thank you for the clarification! It should work now (in a next release):


Nuget restore breaks if a source in nuget.config specifies relative local paths

I'm using version 2.0.5 of the nuget task and version 4.3.0-preview3 of nuget.exe via the NuGet Tool Installer task.
I encountered a build break because my nuget.config specifies a source that points to a (relative) local path within my source repo:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
    <add key="Local" value="LocalPackages" />
  </packageSources>
  <disabledPackageSources />
</configuration>

In my solution, nuget.config and the LocalPackages folder are both within the 'src' folder.
When the nuget task runs, it copies my nuget.config to a temporary file under the _work\1\Nuget folder:
E:\A\_work\1\Nuget\tempNuGet_876538.config
Because it's no longer under 'src', this causes a failure when nuget tries to connect to the LocalPackages feed. Here's the error:
2017-07-21T15:51:36.1825770Z NuGet.Protocol.Core.Types.FatalProtocolException: Failed to retrieve information about 'NETStandard.Library' from remote source 'E:\A\_work\1\Nuget\LocalPackages'.
2017-07-21T15:51:36.1825770Z    at NuGet.Protocol.LocalV3FindPackageByIdResource.GetVersionsCore(String id, ILogger logger)
2017-07-21T15:51:36.1825770Z    at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
2017-07-21T15:51:36.1825770Z    at NuGet.Protocol.LocalV3FindPackageByIdResource.GetVersions(String id, SourceCacheContext cacheContext, ILogger logger)
2017-07-21T15:51:36.1835773Z    at NuGet.Protocol.LocalV3FindPackageByIdResource.GetAllVersionsAsync(String id, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken)
2017-07-21T15:51:36.1835773Z    at NuGet.Commands.SourceRepositoryDependencyProvider.<GetAllVersionsAsync>d__24.MoveNext()

I was able to work around it by adding a task to update the LocalPackages feed to an absolute path using 'nuget sources remove' followed by 'nuget sources add')

Thanks for reporting this.
We recommend using Team Services Package Management  instead of checking your packages into your source tree.
An alternate work around is to add the absolute path to the folder on the build agent via environment variable - e.g.
<add key="Local" value="%BUILD_SOURCESDIRECTORY%\LocalPackages" />
The environment variable will be resolved in the build, but not resolved on your local machine.

@jotaylo In my case I am consuming a private nuget package from another team that is not available on our VSTS packaging feed. In the long term, I agree - getting them to use VSTS packaging would be appropriate.
I'll try the environment variable workaround (I think it needs an extra dot to avoid making the local machine case an absolute path from root). Thanks for the suggestion.

Ran into this same issue the other day with a NuGet package containing a hotfix that had to be included in the repo. The environment variable workaround didn't work for me so I had to add an extra build step to run a shell script (I'm on a macOS agent):
nuget sources update -Name Local -Source "%BUILD_REPOSITORY_LOCALPATH%/LocalPackages"


add rocksdb memory usage metric

reference: https://github.com/facebook/rocksdb/wiki/Memory-usage-in-RocksDB

I think we can show rocksdb memory usage metrics in built in web server monitor: https://github.com/XiaoMi/rdsn/issues/130


Add psalm linter for PHP

This adds the PHP linter psalm. Probably I should customize it to add specification of additional variables, but at least it's a start and would help anybody who uses this linter.

Closing due to inactivity.


Satoshi X PFP collection

This collection has been included and can be accessed at the following link. https://www.okx.com/cn/web3/marketplace/nft/collection/btc/satoshi-x-pfp


The ol-marker Clearing not disappear div tag of popup

Hi @tombatossals,
when you clear the ol−marker, it seems to remain div tag that you created in the pop-up.
Please check since the sample was prepared.
https://jsfiddle.net/mfdev1/48zujvdh/6/
div tag will continue to increase with each additional marker.
In destroy the timing , it may be necessary to clear the overlay.

You're totally right @mfdev1, thanks for reporting, I have solved it in the last commit


Inference of floating tflite model in armnn

Documentation have source code for running inference on quantized tflite model. I want to know how to run floating tflite model in armnn.

Hi @krn-sharma,
Thank you for reaching out. I am guessing you are following this guide? You should be able to load your floating point model in the same way as the guide armnn::INetworkPtr network = armnnparser->CreateNetworkFrom BinaryFile(yourModelPath);. The only difference might be how you prepare the inputs. "For floating-point models, you must scale the input image values to a range of -1 to 1. For example, if the input image values are between 0 to 255, you must divide the image values by 127.5 and subtract 1." This has been taken from point 2 in the "Load and pre-process an input image for the quantized model" section of this guide so more information can be found there.
Have you tried running it with your floating point model, if so did you get any errors? Thanks!
Kind regards,
Matthew

getting the following error when I replace uint8_t to float
mobilenetv1_quant_tflite.cpp: In function ‘int main(int, char**)’:
mobilenetv1_quant_tflite.cpp:127:5: error: no matching function for call to ‘std::vector<boost::variant<std::vector > >::vector()’
};
^
In file included from /usr/include/c++/8/vector:64,
from /usr/include/boost/filesystem/path_traits.hpp:26,
from /usr/include/boost/filesystem/path.hpp:25,
from /usr/include/boost/filesystem.hpp:16,
from model_output_labels_loader.hpp:4,
from mobilenetv1_quant_tflite.cpp:6:
/usr/include/c++/8/bits/stl_vector.h:543:2: note: candidate: ‘template<class _InputIterator, class> std::vector<_Tp, _Alloc>::vector(_InputIterator, _InputIterator, const allocator_type&)’
vector(_InputIterator __first, _InputIterator __last,
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:543:2: note:   template argument deduction/substitution failed:
mobilenetv1_quant_tflite.cpp:127:5: note:   candidate expects 3 arguments, 1 provided
};
^
In file included from /usr/include/c++/8/vector:64,
from /usr/include/boost/filesystem/path_traits.hpp:26,
from /usr/include/boost/filesystem/path.hpp:25,
from /usr/include/boost/filesystem.hpp:16,
from model_output_labels_loader.hpp:4,
from mobilenetv1_quant_tflite.cpp:6:
/usr/include/c++/8/bits/stl_vector.h:515:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(std::initializer_list<_Tp>, const allocator_type&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >; std::vector<_Tp, _Alloc>::allocator_type = std::allocator<boost::variant<std::vector > >]’
vector(initializer_list<value_type> __l,
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:515:7: note:   no known conversion for argument 1 from ‘std::vector’ to ‘std::initializer_list<boost::variant<std::vector > >’
/usr/include/c++/8/bits/stl_vector.h:490:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>&&, const allocator_type&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >; std::vector<_Tp, _Alloc>::allocator_type = std::allocator<boost::variant<std::vector > >]’
vector(vector&& __rv, const allocator_type& __m)
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:490:7: note:   candidate expects 2 arguments, 1 provided
/usr/include/c++/8/bits/stl_vector.h:480:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&, const allocator_type&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >; std::vector<_Tp, _Alloc>::allocator_type = std::allocator<boost::variant<std::vector > >]’
vector(const vector& __x, const allocator_type& __a)
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:480:7: note:   candidate expects 2 arguments, 1 provided
/usr/include/c++/8/bits/stl_vector.h:476:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>&&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >]’
vector(vector&& __x) noexcept
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:476:7: note:   no known conversion for argument 1 from ‘std::vector’ to ‘std::vector<boost::variant<std::vector > >&&’
/usr/include/c++/8/bits/stl_vector.h:458:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >]’
vector(const vector& __x)
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:458:7: note:   no known conversion for argument 1 from ‘std::vector’ to ‘const std::vector<boost::variant<std::vector > >&’
/usr/include/c++/8/bits/stl_vector.h:427:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>::size_type, const value_type&, const allocator_type&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >; std::vector<_Tp, _Alloc>::size_type = long unsigned int; std::vector<_Tp, _Alloc>::value_type = boost::variant<std::vector >; std::vector<_Tp, _Alloc>::allocator_type = std::allocator<boost::variant<std::vector > >]’
vector(size_type __n, const value_type& __value,
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:427:7: note:   candidate expects 3 arguments, 1 provided
/usr/include/c++/8/bits/stl_vector.h:415:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>::size_type, const allocator_type&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >; std::vector<_Tp, _Alloc>::size_type = long unsigned int; std::vector<_Tp, _Alloc>::allocator_type = std::allocator<boost::variant<std::vector > >]’
vector(size_type __n, const allocator_type& __a = allocator_type())
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:415:7: note:   no known conversion for argument 1 from ‘std::vector’ to ‘std::vector<boost::variant<std::vector > >::size_type’ {aka ‘long unsigned int’}
/usr/include/c++/8/bits/stl_vector.h:402:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector(const allocator_type&) [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >; std::vector<_Tp, _Alloc>::allocator_type = std::allocator<boost::variant<std::vector > >]’
vector(const allocator_type& __a) _GLIBCXX_NOEXCEPT
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:402:7: note:   no known conversion for argument 1 from ‘std::vector’ to ‘const allocator_type&’ {aka ‘const std::allocator<boost::variant<std::vector > >&’}
/usr/include/c++/8/bits/stl_vector.h:391:7: note: candidate: ‘std::vector<_Tp, _Alloc>::vector() [with _Tp = boost::variant<std::vector >; _Alloc = std::allocator<boost::variant<std::vector > >]’
vector()
^~~~~~
/usr/include/c++/8/bits/stl_vector.h:391:7: note:   candidate expects 0 arguments, 1 provided
inference_test_image.cpp:9:10: fatal error: ../third-party/stb/stb_image.h: No such file or directory
#include "../third-party/stb/stb_image.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:10: mobilenetv1_quant_tflite] Error 1

Hi @krn-sharma
have you been able to overcome this issue? We have removed Boost from Arm NN
Kindest Regards

Hi @krn-sharma,
I am going to close this issue as it has been over one month when the latest activity has occurred. If you are still experiencing problems, please do not hesitate to reopen this ticket or create a new issue.
Kind Regards, Cathal.


Fix inconsisten vendoring issue due the self replace

Fix for in go1.18 during the make build action:
go: inconsistent vendoring in /home/xarbulu/Workspace/sap_squad/trento-stack/runner:
	github.com/trento-project/runner: is marked as replaced in vendor/modules.txt, but not replaced in go.mod

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
make: *** [Makefile:45: trento-runner] Error 1

Some related external discussions:
https://github.com/containerd/containerd/issues/6586
https://github.com/golang/go/issues/34417
Apparently the self replace thing is not supported anymore in golang 1.18, since it doesn't make many sense.
@stefanotorresi Could you have a special look on this, since I don't really know why we started having this thing in the code

I think that line was originally in the monolithic repo. If removing it doesn't break anything, go with it.


Binary IO tests are not supported properly by IOTestCase and Formatter

Direct use of test.actual_stdout, test.expected_stdout, test.actual_stderr, test.expected_stderr,  and test.test_input in formatter.py:basic_io_output causes errors when calling str.join for constructing test summary, because these variables evaluate to type bytes instead of type str.
Example line is
https://github.com/tritongrader/tritongrader/blob/master/src/tritongrader/formatter.py#L121
A related issue is that IOTestCase assumes that all inputs are pure text and does not handle binary input properly.
See https://github.com/tritongrader/tritongrader/blob/master/src/tritongrader/test_case/io_test_case.py#L100

Fixes for both are added in branch cse30-pa7
https://github.com/tritongrader/tritongrader/blob/cse30-pa7/src/tritongrader/formatter.py
https://github.com/tritongrader/tritongrader/blob/cse30-pa7/src/tritongrader/test_case/io_test_case.py


Link mentioned user in markdown only if they are visible to viewer

We need to make sure a user can't confirm the existence of a user with private visibility

Follow up on #21533

Before
User

Admin

After
User

Admin

giteaCtx.Doer maybe nil which should be check out of IsUserVisibleToViewer
https://github.com/go-gitea/gitea/pull/21554/files#r1002631586

No need. I have written the test to cover this case. IsUserVisibleToViewer can work with nil doer

make L-G-T-M work


⚠ Bofrost.es has degraded performance

In f8c672c, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1445 ms

Resolved: Bofrost.es performance has improved in 3acabcb after 6 minutes.


Expose limit API.

Cadical offers five user-configurable solver limits.  In the C API these limits are selected using ccadical_limit(solver, "conflicts", 10), etc.  This PR exposes them as separate functions, which has two advantages:

You don't have to guess the parameter name.
We can avoid dynamic allocation by unsafely producing a &CStr from a slice literal.

Hmm, this looks perfect, no idea why the windows build is failing. I will merge it then investigate.

I am not sure if this brings in some parts of the c++ library which was not needed before, or more likely the new compiler somehow brakes (it wants to use unistd.h, which is not present on windows).

I have reworked the interface and exposed the plain set_limit with string name. I know that this allocates (but a solver is much more heavy weight to be concerned about this), but is easier to use when you want to switch between solvers in a generic way (I do). I expose the validation of the limit name done by cadical. Thanks for submitting the initial commit.


Removed.

@XVincentX please use semantic release commit format for next work.


Tolerate 0-RTT by default

As discussed in  #6647, OpenSSL will abort by default if a client attempts to send it early_data, rather than skip over it as you might expect. This is because the default amount of max_early_data is 0. If a client has a stale ticket for the server which advertises more than that then it could attempt to send early data anyway.

Pushed. Thanks.


feat: support publicDir from vite

Hi! 👋🏽
I found this package today and started to evaluate it as a replacement for Storybook.
During my first look at it, I didn't find a way to serve files statically like the -s, --static-dir in Storybook.
vite has the publicDir config option, currently not supported.
It defaults to public but it can be false to disable the behaviour.
The root directory for ladle is inside the node_modules folder.
Therefore, I used the process.cwd() to figure the absolute path.
With this, users can use only publicDir: 'myFolder' as in vite itself.
❗ I'll work on a documentation update tomorrow but decided to open the PR for feedback.
If you have any opinions or suggestions about this change, let me know below.

Better - we should add
publicDir: join(process.cwd(), 'public')

into https://github.com/tajo/ladle/blob/master/packages/ladle/lib/shared/default-config.js#L9
just to simplify the code and types.

publicDir: join(process.cwd(), 'public')

into https://github.com/tajo/ladle/blob/master/packages/ladle/lib/shared/default-config.js#L9

If I understand your suggestion correctly, that would require users to specify the full path instead of only myFolder since we'd only resolve the path with process.cwd() in the default config. Is that preferred?

You can check if the path provided by the user is absolute or relative. If relative, it will get combined with process.cwd.

@tajo, sorry for the delay but I've pushed some changes now.
Please have a look and let me know what you think.

LGTM but tsc needs to get fixed.

@tajo, my bad. It should be fixed now.


NIFI-11047 - Issue when upgrading dataflow with external service

Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[x] JDK 11
[x] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

+1 LGTM, verified the version state is as expected after removing references to a parent service. Thanks for the fix! Merging to main


[Fix-14729]  fix problem with the command generated by the flink task

Purpose of the pull request
fix #14729

Brief change log
1、The determinedYarnQueue method in the FlinkArgsUtils class and the switch statement of the doAddQueue method lack a break, adn I fix it.
2、 put the -Dyarn or -yqu parameter before -c,  put the determinedYarnQueue method on line 284 before line 261

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #14902 (9eab65e) into dev (2f2884f) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

:exclamation: Current head 9eab65e differs from pull request most recent head f503e10. Consider uploading reports for the commit f503e10 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14902      +/-   ##
============================================
- Coverage     38.81%   38.80%   -0.02%
+ Complexity     4588     4587       -1
============================================
  Files          1234     1234
  Lines         43385    43328      -57
  Branches       4794     4777      -17
============================================
- Hits          16841    16812      -29
+ Misses        24680    24652      -28
  Partials       1864     1864

Files Changed
Coverage Δ

...hinscheduler/plugin/task/flink/FlinkArgsUtils.java
64.58% <66.66%> (-0.21%)
:arrow_down:

... and 48 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Do you think this pr needs cherry-picked to 3.1.9? @zhuangchong


Support circuit breaker group name

Fixes gh-514

This changes required the latest version of Spring Cloud Commons

@OlgaMaciaszek

this. removed
I added @ author tags to all changed classes (except for classes that don't have @ author tag)
Documentation updated


fix: use by rfl instead of rfl to bypass new compiler bug

This is a workaround for a bug reported on the zulip thread

awaiting-review

This works and it's simple but the ideal is an upstream solution, so we should wait a bit for a better solution. Otherwise, I would approve.

I think by rfl will always be more robust than rfl regardless of core changes. I am inclined to merge this but want to check with @fgdorais

I can't reproduce the original bug since v4.13-rc1. I'm not sure why the issue isn't closed upstream.

I went out to 68 and the problem is gone so let's close this.
It would be informative to ping on leanprover/lean4#5502 to see if any changes directed at this landed.


feat: Introduce jni catalog to support all catalogs

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close #13900.
We introduced a jni catalog to support all catalogs except rest/storage.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

I think this pr is ready to merge. cc @chenzl25 @BugenZhao @xxchan @wenym1


Added the OrderQueueName to api/template.yml

Issue #, if available:
The application fails to deploy, because OrderQueueName parameter doesn't exist in the template.

Description of changes:
Added
  OrderQueueName:
    Type: String
    Description: Order Queue Name

Also, i added a bash command for the order post. The one on the aws blog missed an open curly brace, so when you use it, all messages move to DLQ and not Step functions workflow is started.
curl -s --header "Content-Type: application/json" \
  --request POST \
  --data '{"quantity":5,"name":"Rellenos","restaurantId":"San Miguels"}' \
  https://xxxxxxxxxx.execute-api.us-east-1.amazonaws.com/Dev/orders  | python -m json.tool

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Nice. Done


Pushdown SQL queries with dot notation

Description
Closes #1841.

Readiness checklist

[ ] I added/updated unit tests.
[x] I added/updated integration/compatibility tests.
[x] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

@w84thesun That's actually a great idea thanks! I'm bit worried about the time of implementation, but I can start from basic test cases and add more in next issues.


ENH: RML Tabular Views do not work through Morph KGC command line

Is your Feature Request Related to a Problem?
RML Tabular Views are not processed via the command line.
Describe the Solution you'd Like
I want to have RML Tabular Views in my mapping file (on top of CSV files) and run morph kgc from the command line:
python -m morph_kgc config.ini
Right now this does not process and gets stuck in the following state:
INFO | 2023-03-21 11:25:14,822 | 1 mapping rules retrieved. INFO | 2023-03-21 11:25:14,831 | Mapping partition with 1 groups generated. INFO | 2023-03-21 11:25:14,831 | Maximum number of rules within mapping group: 1. INFO | 2023-03-21 11:25:14,832 | Mappings processed in 0.381 seconds.
Describe Alternatives you've Considered
I am able to run Morph KGC via code when I have RML Tabular Views in my mapping files.
Additional Context
It would be great if this can be processed with parallelization.

Hi @nilbro ,
If I understood correctly, the problem is that Morph-KGC does not finish, is this right?

Hi @arenas-guerrero-julian ,
yes, that is right

I think that this is related to #156
Can you provide your Operating system and Python version?

I am closing this as this is actually similar to #156 (where the machine is also macOS)


Fix vendor

/cc @sttts @deads2k

/lgtm
will merge on good images and unit

/lgtm

/lgtm

/approve

Image test is good. We don't use these yet.


Updated 4k-video-downloader 3.1 → 3.4, added license

Updated 4k-video-downloader 3.1 → 3.4, added license

Looks good, thanks! :+1:


Add ability for a user to delete themselves

Add service and controller for deleting a user
This will mostly be useful for now for postman testing purposes

also theres a lot of onDelete=CASCADE additions in models/schema that arent related to the rest of this change. whats the rationale behind that?

just need those once we start deleting, so i added them


NoFormatter log message does not include ContentTypes from result

When MVC fails to select an output formatter based on ObjectResult.ContentTypes (Response.ContentType has not been set), it logs the following warning:

No output formatter was found for content type '' to write the response.

This is pretty unhelpful and confusing. I suggest the warning also includes the content types considered from the ObjectResult.

This seems like a good thing to have. Wanna send a PR?

Wanna send a PR?

Yup 👍

@ryanbrandenburg please look for a PR to review.


Could not see any directories and files when use Distributed Filer mode.

i start Distributed Filer Service use command like this :
weed -log_dir=/var/logs/filer filer -master="192.168.x.x:9333" -redis.server="192.168.x.x:6379" -redis.database=10 -defaultReplicaPlacement="001"
when i put some file to directory
curl -F "filename=@Makefile" "http://localhost:8888/path/to/sources/new_name"
filer service could not list any directories,  then redis data
`
<IP_ADDRESS>:6379[10]> keys *

"/path/to/sources/new_name"
"..."
`

when i use standlone mode and try again, it's work . can list directories and files . it is any problem here ?
something mismatch with wiki

restfull api add pretty=true does not work  should add request header "accept=application/json".
lastest version is "0.75" but weed --version show  "version 0.74 linux amd64"

Is this using the redis pull request?

Sorry, i do not know redis pull request  .
distributed filer mode server response ：
{   "Path": "/path/",   "Files": null,   "Directories": null,   "Limit": 100,   "LastFileName": "",   "ShouldDisplayLoadMore": false }
standlone filer mode server response ：
{   "Path": "/path/",   "Files": null,   "Directories": [     {       "Name": "to",       "Id": 2     }   ],   "Limit": 100,   "LastFileName": "",   "ShouldDisplayLoadMore": false }

dir listing is not supported.
The PR https://github.com/chrislusf/seaweedfs/pull/254 is trying to address this. But not tested yet.

123


Dev

Looks like master needs to be merged with dev to me. The code currently on http://farcx.ev3.pw/ is from dev. Thoughts?

It's still in development (see: the movement log), but there's nothing saying that the master branch has to be not-in-development. Your choice

The pre-merge contents of master are way outdated, so I'm going to merge this pull request.


Examples - move user dependant variables to .env

suggestion:
move all variables that need to be replaced in .env.template file (all values are set with comment to replace it user .env file)
add .gitignore in this directory with this content:

.env.*
!.env.template
this way user don't have to modify anything in code and is safe for comitting private data to some repo

Already done and improved in https://github.com/NethermindEth/starknet.go/pull/579/


Documentation creation failure - parameter has no default value

Sent via email ->

I discovered one more “bug” – if policy definition does not have a default value for a property (for some strange reason 😊), documentation creation will fail – part where “convertto-csv” creates *-compliance-initiatives.csv will error “Object reference not set to an instance of an object”.
This happens within the Out-PolicySetsDocumentationToFile.ps1 script at line 177. That is as far as I could get in troubleshooting.

File to reproduce has been sent to me.


Allow users to install pre-releases from the app

It would be great if you had two tracks and that users could opt in to automatically install pre-releases. This should be managed in the settings tab.

At the current time, pre-releases is going to be a discontinued service. The program isn't large enough to be at a scale where new features aren't thoroughly tested before being released, thus there's no point in releasing features to some users if they're already proven to be bug-free.


HTTPS Everywhere Crashes

Currently using the newest build of UC on an ARM Macbook Air HTTPS Everywhere crashes when I start it, doesn't produce any logs in the chrome://extensions but I was able to get this from console: https://gist.github.com/stfnhh/93828c8de989cbfee125de252b71e6fa
Any ideas?

Possibly related various other sites like beta.protonmail.com also crash with a similar error.

Possibly related various other sites like beta.protonmail.com also crash with a similar error.

Did you compile it yourself? It says ARM-64 (Native)
Maybe try the newer .141 Chromium version (macOS patches don't need updating)
Also, updating your macOS to ≥11.1 might help.

Did you compile it yourself? It says ARM-64 (Native)
Maybe try the newer .141 Chromium version (macOS patches don't need updating)
Also, updating your macOS to ≥11.1 might help.

@kramred Thanks for responding, I didn't compile it myself, using this build by Marmaduke https://github.com/macchrome/macstable/releases, unfortunately I can't get my build setup to work for the life of me (https://github.com/stfnhh/ungoogled-chromium-macos/runs/1674636118?check_suite_focus=true).  I've updated to 11.1 but the issue still persists.

@kramred Thanks for responding, I didn't compile it myself, using this build by Marmaduke https://github.com/macchrome/macstable/releases, unfortunately I can't get my build setup to work for the life of me (https://github.com/stfnhh/ungoogled-chromium-macos/runs/1674636118?check_suite_focus=true).  I've updated to 11.1 but the issue still persists.

Ideas:

You could try an empty profile – backup your profile directory then delete or move it and start Chromium, install the extension again or visit a site that currently crashes the browser
You can wait for an updated ARM64 version from @macchrome or open an issue in their repo
For building an ARM64 version with GitHub Actions you probably will have to use the default clang/LLVM from Xcode ≥12.2 (which seems to be included in the GitHub Actions VM); i.e adjust the build scripts to do that; I wanted to look into that but have not yet found the time to do so… and I saw that you've already added the flag target_cpu="arm64"

Ideas:

You could try an empty profile – backup your profile directory then delete or move it and start Chromium, install the extension again or visit a site that currently crashes the browser
You can wait for an updated ARM64 version from @macchrome or open an issue in their repo
For building an ARM64 version with GitHub Actions you probably will have to use the default clang/LLVM from Xcode ≥12.2 (which seems to be included in the GitHub Actions VM); i.e adjust the build scripts to do that; I wanted to look into that but have not yet found the time to do so… and I saw that you've already added the flag target_cpu="arm64"

@kramred I was finally able to get it to compile locally on a M1 using .141 but the issue persists.  From what I can tell the problem stems from the renderer.

@kramred I was finally able to get it to compile locally on a M1 using .141 but the issue persists.  From what I can tell the problem stems from the renderer.

From what I can tell the problem stems from the renderer.
Have you tried forcing software rendering (and vice-versa)?

From what I can tell the problem stems from the renderer.
Have you tried forcing software rendering (and vice-versa)?

HTTPS Everywhere was removed in 7fc57bdc9404e6ede6eb60b03da5c102b0106e37. Closing.


socklen_t is not always u32

VsockStream.connect calls:
            connect(
                socket,
                &vsock_addr as *const _ as *const sockaddr,
                size_of::<sockaddr_vm>() as u32,
            )

However, the len argument of connect isn't guaranteed to always be u32 (for example, some android platforms use i32).
Instead, it is likely more robust to cast size_of::<sockaddr_vm>() to socklen_t. Eg:
            connect(
                socket,
                &vsock_addr as *const _ as *const sockaddr,
                size_of::<sockaddr_vm>() as socklen_t,
            )

Good catch @powturns , would you mind filing a pull request for this?


rss

great extension. is it possible to make it work for rss feed accounts as well? (you'll find it in account settings > account actions>add feed account, in case you didnt know)
also, any chance you could add a script example for showing icon1 when there are no new messages, and icon2 when there are new messages (and back to icon1 again when the new message(s) are marked read? i quite dislike new icons popping up in the tray and moving things around so always having an icon is better imo
thanks for this extensions, its pretty great

Adding Feeds as an "inbox" is a good idea, I'll see what I can do!
For the script examples, sadly it would be endless if I started to write one for every need... It is actually the goal of this add-on to give each user the possibility to write his own!
But I'm of course open to pull requests to add interesting examples.
Thanks for the kind words.

I added support for "Feeds" accounts.
Before I release the change, could you please try the master branch, with your own feeds, to see if they work properly?
Just uninstall the add-on, restart Thunderbird and follow the "Installation / From Source" section:
https://github.com/electrotype/thunderbird-addon-scriptable-notifications#from-source

hey
seems to work well as far as i can see :)
thanks

Thanks for your test.
Version 3 released with support for Feeds accounts.


Galaxyscore.py with paperaccount - error: Fetching 3Commas account failed

Describe the bug
Hello,
First of all thank you for sharing this amazing tools!
I tried to use galaxyscore.py using docker with paper account on 3 commas.
When I start the container, I get this error message:
2021-12-20 11:03:28 - galaxyscore.py - 3Commas bot helper galaxyscore!

2021-12-20 11:03:28 - galaxyscore.py - Started at Monday 11:03:28 20-12-2021

2021-12-20 11:03:28 - galaxyscore.py - Loaded configuration from 'config/galaxyscore.ini'

2021-12-20 11:03:28 - galaxyscore.py - Notifications are enabled

2021-12-20 11:03:28 - galaxyscore.py - Reloaded configuration from 'config/galaxyscore.ini'

2021-12-20 11:03:28 - galaxyscore.py - Fetched 3Commas pairs blacklist OK (0 pairs)

2021-12-20 11:03:28 - galaxyscore.py - Fetched 3Commas BTC price OK (45938.02 USDT)

2021-12-20 11:03:29 - galaxyscore.py - Fetched LunarCrush ranking OK (100 coins)

2021-12-20 11:03:29 - galaxyscore.py - Bot base currency: USDT

2021-12-20 11:03:29 - galaxyscore.py - Bot minimal 24h BTC volume: 0.0

Traceback (most recent call last):

  File "galaxyscore.py", line 651, in <module>

    find_pairs(botdata)

  File "galaxyscore.py", line 430, in find_pairs

    marketcode = get_threecommas_account(thebot["account_id"])

  File "galaxyscore.py", line 309, in get_threecommas_account

    logger.error("Fetching 3Commas account failed with error: %s" % error["msg"])

KeyError: 'msg'

Environment:

Python version: v 3.9.9
Operating System: Windows 10 + Docker Destop v4.3.0

Additional context
I am using paper account on 3 commas
Thanks for your help

tried with release 0.7.9 it worked. but not with main branch. I close this issue

Why close an issue which isn't fixed?
I think you need to read the documentation and add AccountRead rights to your 3Commas API key

Hi,
sorry for closing it too early, mistake on my side.
Regarding your suggestion, I already set 3Commas API Key with this parameter.
my API key - BotsRead, BotsWrite, AccoundsRead:

Ok will check, thanks

Hi,
in the function named def get_threecommas_account(accountid):
this piece of code seems to cause the issue (line 299):
additional_headers={"Forced-Mode": "real"}
I commented it and it worked
Did a quick check and it's also present in the code of the following scripts:

galaxyscore.py
altrank.py
compound.py
coinmarketcap.py
watchlist.py
watchlist_100eye.py

Repoduced the issue  on galaxyscore.py, altrank.py, compound.py, coinmarketcap.py
After commenting the concerned line it worked.
Did not test with watchlist.py, watchlist_100eye.py

But without it real mode doesn't work correctly when you put the webinterface in paper mode I think (it was an issue a while ago)
Can you test this?
If this is the case we need to reinstate the old accountmode setting and use that, but it means we cannot run mixed bots (paper/real)

Maybe they (3Commas) changed this behavior to work with all modes now, since it was strange behavior anyway.

Hi,
Scenario tested with galaxyscore.py (commented the line additional_headers={"Forced-Mode": "real"}):

switched on paper account on web interface, launched galaxyscore.py with botids of real account in galaxyscore.ini
--> Result: Bot id in real account successfully updated with the right pairs.
switched on real account on webinterface, launched galaxyscore.py with botids of paper account in galaxyscore.ini
--> Result: Bot id in paper account successfully updated with the right pairs.

From the official documentation of 3commas API:
" By default, API mode(real or paper) synchronized with mode in web/app.
You can set a forced mode for public API through the request header "Forced-Mode" with values "real" or "paper"."
(speculation) It's probably true and matters for other actions through this api, but in our case, because we specify botids, it looks like it doesn't matter to be in real or paper account in webinterface. Ids are unique

@mthad I know about that text.
But the issue is to determine the correct mode I have to get the market_code of an account_id linked to a botid.
And if this request also needs the correct mode for that account (which it the case, it turns out) We have a chicken and egg problem.
I cannot rely on the account_name in the bot for this, this can be "Paper account 12345" or "Test account" or something else.
To recap:
I use the get_threecommas_account(accountid) code to get the market_code which tells me which market the bot is connected too, 'binance' for binance and 'paper_trading' if link to paper account.
I would expect I can read both ids (from paper and real botid) with mode is 'real' but this fails sometime as you pointed out, and without it the reading of the 'real' account fails if web interface is in paper mode.
There is other code, but this switched the mode (not only for a webcall) this is also unwanted...

@mthad Working solution it seems: I first read account data in paper mode, if this doesn't give me the market_code for theaccount_id I read it again using real mode ;-)

@mthad can you test with latest version?

Hi,
@cyberjunky, tested with new version (main branch), worked successfully in scenario below.
Scenario tested with galaxyscore.py:

switched on paper account on web interface, launched galaxyscore.py with botids of real account in galaxyscore.ini
--> Result: Bot id in real account successfully updated with the right pairs.

switched on real account on webinterface, launched galaxyscore.py with botids of paper account in galaxyscore.ini
--> Result: Bot id in paper account successfully updated with the right pairs.

Thanks for the fix ;-).
Happy new year :-)!

@mthad Thank you for reporting and testing, have a happy new year too! :champagne:


Incomplete Rename Range Resolver

Rename functionality supported over LSP must work differently then 'change all occurrence' it renames symbol anywhere present within that document without looking within the current scope. The scraped implementation of rename functionality works fine and matches symbol within scope however it fails to achieve the result while renaming symbols which are reference from other files.
For other gdscript file to use that symbol it must either utilize the export - get function in that case it is a different function variable name will be handled
export (Texture) var texture setget _set_texture
Other way to do it is through: get_node("yourNode").get("yourVariable") This case is not handled and I wonder to implement this functionality we have to search for the node_name along with variable in all files present in the project. However doing this will be inefficient. Maybe modifying the current symbol pool to include both it's scope and also external reference will solve this problem

I was thinking we can try to build a node tree and figure out the external reference between nodes. So instead of creating external symbols in symbol pool, we can just dispatch a rename into other GDScriptTextDocument.
VScode workspace can be opened everyone, we may not able to create the whole node tree, but we may get a subtree that reference the editting script file. If we utilize as many information we can find (i.e. all the node tree or subtree we can find), it looks a compact implementation to me.

has this been abandoned?

has this been abandoned?


MST in O(m log log* n)

Efficient algorithms for finding minimum spanning trees in undirected and directed graphs

No need, simpler ones are better in practice


[docs] Add a real world example of an async validation

Motivations

Facilitate the use of the library for new users
Have a reference implementation

This is a bit too verbose for documentation. I think the current docs on it is pretty straightforward


Make script configurable, add examples and LICENSE

Updated the script to be configurable without touching the actual source of the script.
This PR also includes .editorconfig and LICENSE file which was missing from your repo. Added your info to the license.

Big thanks to Ismo for taking the time to improve the project!


Fix broken search JavaScript

What

update the local dev docs copy of the modules initialisation code from the gem to include handling of modules that have a start function and expect a jQuery element to be passed to them (like the Search JavaScript - the tech docs modules are old and still rely on jQuery)
update this whole thing to actively fully replace not only the modules.start code from the gem but also from the tech docs - this is still included earlier in the JS stack (slightly inefficient, but I think we're stuck with it until a change is made upstream) but then we overwrite it. It's later called by the tech docs JS in a document.ready
include a copy of the dependencies.js code from the gem, to initialise the GA4 code

Why
Recent changes to how modules are initialised in the gem meant that the tech docs modules weren't being initialised anymore, and therefore the dev docs search stopped working properly.
Visual changes
None.

@MartinJJones just raised this to check I understood your solution - we've basically arrived at the same conclusion, so I'm going to close this one 😁


Add package tlv

You seem to have renamed the repo, so you need to change the links here as well. The CI passed because you changed the link after it passed

Oops, fixed it!


Add environment variables to advanced config view

Is your feature request related to a problem? Please describe.
Advanced config TUI view should have the option to customize environment variables in a form of something similar to a
Describe the solution you'd like

Describe alternatives you've considered
This feature is currently only available by calling the API directly

Closes with #516


UndocumentedPublicClass: Fix enum support

Correctly report missing documentation for enum classes, and stop reporting
missing documentation for enum constants as UndocumentedPublicClass.

Thanks for the PR !

Thanks for Detekt!


Feat: Google Auth and validation using Firebase on login and Signup

Describe the feature
@anuragverma108 please assign this issue to me

I propose integrating Google Authentication via Firebase to enhance the website's security and user experience.
Add ScreenShots

would change the authentication system only, since the UI/UX is already assigned to other contributors.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@anuragverma108 is this issue already assigned to someone else?

Yes it already exists


Move Money Dialog feature CSS Slector too broad at the moment

Just doing some further testing and noticed that the .modal-popup .modal-actions selector is too broad. This is from the budget screen...

Could you tighten this up a bit? I'm going to back this feature out until it's more specific so it'll miss the release tonight but should be able to make the next one.
@johde looks like it's in this commit: cf5b09a25ee36b8915e06d9fec8ed41ec92570ef

I'll fix it.

Fixed, see: https://github.com/blargity/ynab-enhanced/pull/19

Thanks!


Fixed Direction Math

The math for calculating the display direction was off by 90 degrees.

:+1:

<3 thanks


<EMAIL_ADDRESS>decompress error

Failed to extract files from C:\Users\Administrator\scoop\apps\authy\2.2.3\authy-2.2.3-full.nupkg.
Log file:
~\scoop\apps\authy\2.2.3\7zip.log

Duplicate with #10532, please consider closing this issue and leaving a comment under the previous issue.

Dupcalite of #10532


Add SuperFast connectors as an extension.

Julia has a feature called "extensions" where we can have code that is only available when two packages are loaded at the same time. This will allow us to have code that connects the wet and dry deposition code to SuperFast without always having to load the GasChem Package. The documentation is here: https://docs.julialang.org/en/v1/manual/code-loading/#man-extensions
Basically, the idea is that we can create a file named /ext/GasChemExt.jl (not /src/ext/GasChemExt.jl) in this repository, then in that file put:
module GasChemExt

... connector code from here: https://github.com/jialinl6/box_model/blob/c65a56a328d865c119f2148efabb9d72bc5641b7/s_f_d.jl#L6

end

The, in Project.toml we can add:
[weakdeps]
GasChem = "58070593-4751-4c87-a5d1-63807d11d76c"

[extensions]
GasChemExt = "GasChem"

(Also add tests and documentation)

 Gov4Git notices
On Friday, 23-Feb-24 21:17:04 UTC by Gov4Git dev
Notice 47hnvb
Started managing this issue as Gov4Git concern 22 with initial priority score of 0.000000.
This project is managed by Gov4Git, a decentralized governance system for collaborative git projects.
To participate in governance, install the Gov4Git desktop app.
Notice tly7fl
This issue's priority score is now 0.000000.
The cost of priority is 0.000000.
The projected bounty is now 0.000000.
Notice t5s2y5
The set of eligible proposals claiming this issue is empty.

 Gov4Git notices
On Monday, 26-Feb-24 23:30:51 UTC by Gov4Git dev
Notice nswd5b
This issue's priority score is now 3.000000.
The cost of priority is 9.000000.
The projected bounty is now 6.000000.
Notice rygh5q
The set of eligible proposals claiming this issue is empty.


type error when set date null and focused false of SingleDatePicker props

Error in console:
React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components). Check the render method of SingleDatePickerWrapper.
code is:
 import React from 'react';
import SingleDatePicker from 'react-dates';

class SingleDatePickerWrapper extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      focused: false,
      date: null,
    };

    this.onDateChange = this.onDateChange.bind(this);
    this.onFocusChange = this.onFocusChange.bind(this);
  }

  onDateChange(date) {
    this.setState({ date });
  }

  onFocusChange({ focused }) {
    this.setState({ focused });
  }

  render() {
    const { focused, date } = this.state;

    return (
        <SingleDatePicker
            {...this.props}
            id="date_input"
            date={date}
            focused={focused}
            onDateChange={this.onDateChange}
            onFocusChange={this.onFocusChange}
        />
    );
  }
}

export default SingleDatePickerWrapper;

Newer to React and have no idea why this happened

If you change the line import SingleDatePicker from 'react-dates'; to import { SingleDatePicker } from 'react-dates';, your code should work. :)
react-dates exports an object of various components and methods right now so you have to destructure it.

@majapw thank you very much


Update to latest conformance image

This updates the repo to use the latest conformance image, which uses the new organization on Dockerhub as well as the new proto packages (connectrpc.conformance.v1 instead of grpc.testing).
As a part of this update, this attempts a fix at decoding the ErrorDetails value, which is returned as a base64-encoded string. The Connect protocol states that implementations should emit unpadded values and that downstream implementations should accept both padded and unpadded values. This adds padding to this string if needed as part of the ConnectError decode logic.

Would be nice to add tests for unpadded ConnectErrors in a follow-up PR

Agreed. I'll put a PR together for that. Thanks for reviewing!


Why gcem is much slower than cmath?

I have some functions in my library that need to be called at both compile-time and runtime, and cmath has varying degrees of support for constexpr on different platforms, so I chose to use gcem.
But in using it, I found that many of gcem's functions are an order of magnitude slower than cmath under O3 optimization. I know that I can write two versions that are called at compile time and at runtime, but I'm wondering why gcem is so much slower at runtime?

I've tested this under x86 linux, windows and mac, compiling with g++, msvc and apple clang respectively, and all get roughly the same results.

I believe there is a lot of room to optimise the runtime performance of gcem. I was able to reduce the time consumption by about 40% by simply changing the recursion in the tan operation to a loop.

template<int max_depth, typename T>
constexpr
T
tan_cf_loop(const T xx)
noexcept
{
    T ans = T(2*max_depth - 1);
    for(int depth = max_depth - 1; depth > 0; --depth) {
        ans = T(2*depth - 1) - xx / ans;
    }
    return ans;
}

template<typename T>
constexpr
T
tan_cf_main(const T x)
noexcept
{
    return( (x > T(1.55) && x < T(1.60)) ? \
                tan_series_exp(x) : // deals with a singularity at tan(pi/2)
            //
            x > T(1.4) ? \
                x/tan_cf_loop<45>(x*x) :
            x > T(1)   ? \
                x/tan_cf_loop<35>(x*x) :
            // else
                x/tan_cf_loop<25>(x*x) );
}

And, I don't really understand why gcem uses tan(x/2) for calculating sine and cosine. Using Chebyshev polynomials to approximate sine and cosine should be a better choice.
See here: https://stackoverflow.com/a/394512/24175656

I have created a pull request optimised for trigonometry calculations #46
I'll try to optimize other functions


Weird error with pug template in volar 0.29.0

When open the pug template with volar 0.29.0, it reports the incorrect error.
Previous versions (e.g. 0.28.10) do not have this problem.
<template lang="pug">
div
  div.foo(v-if="cond")

  div.bar(v-else)
</template>

In the above code, the following error occurs
v-else/v-else-if has no adjacent v-if or v-else-if.vue(30)

Remove the blank line between foo and bar, and the error disappears.
<template lang="pug">
Foo
  template(v-slot:header)
    div FOO

  template(v-slot)
    div Bar
</template>

In the above code, the following error occurs
Extraneous children found when component already has explicitly named default slot. These children will be ignored.

Remove the blank lines in the two template tags, and the error disappears.
I created a repository to reproduce the problem.
https://github.com/sinbino/issue-volar-0.29.0

Are you sure (cleaned node_modules and so on) that it works with 0.28.10? Otherwise I would assume that it could have something to do with the fix for me: https://github.com/johnsoncodehk/volar/issues/636
I will try to reproduce this in my company project in some minutes/hours and look if I also got affected by this.

@johnsoncodehk I can confirm this 👍


Pkl package using private repo (using authentication)

We were trying to host our pkl releases in a private gitlab repo. However according to this discussion
https://github.com/apple/pkl/discussions/632 that's not possible.
Could I suggest adding a method to allow for using authentication with packages?

This definitely makes sense to have, and is something that we plan on supporting in a future release.


IIS troubleshooting topic update (Stage 3A)

Addresses #5100
Addresses #5135
Internal Review Topic

Only the troubleshooting topic is on this PR, which is our most important item to address.
Instead of having devs get event log and stdout log info and then heading over to the common errors topic, this version goes step-by-step in anticipation of the event log receiving more info from the ANCM for startup failures. Although that might be mostly for 2.1, we can still safely tell devs today to just look at the event log and see if it helps before going on to the stdout log. Need feedback: Is this approach likely going to be better?
Running the app at a command prompt is maintained and polished up a bit. Wondering: Should we instruct to set the detailed errors env var there?

@shirhatti @Tratcher When running the app at a command prompt on the server, does an IIS env var configure for capturing startup errors and detailed errors? If so, then there is no need to instruct the reader to manually set ASPNETCORE_CAPTURESTARTUPERRORS and ASPNETCORE_DETAILEDERRORS env vars and turn them off afterward. I understand these enable when the ANCM starts the app, but what happens when running from a command prompt on the server?

Rubber :duck: says add the info for ASPNETCORE_DETAILEDERRORS and assume ASPNETCORE_CAPTURESTARTUPERRORS doesn't need to be set explicitly. Correct me if not the case.

Do we have plans for an Azure App Service version of this? Many of the steps are relevant, but you perform them differently. I.e. the event logs are still useful, but you access them differently.

We just merged it a few days ago. https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/azure-apps/troubleshoot

@shirhatti Did u want to take a final look?
@scottaddie A pass, too?

@Rick-Anderson Do u have time to look this evening? I'm anxious to get on with my next one, and I'd like to merge this set one PR at a time. If ur busy ... no worries ... a short wait won't kill me. ⌚ :smile:

@guardrex  on it now.


Rename Widget.root to Widget.renderObject

The name root is confusing because this value isn't the root of anything.
It's just the associated RenderObject instance.

looks legit. LGTM


[Feature Request] Requiring at least one from a given set of options

Kindly consider adding feature to validate that atleast one of given options must be provided. Example: either --config-file or --config-string must be specified. But if --config-file is specified, --config-string is not needed and vice-versa.

Hi, thank you for raising this!
Is this similar to this ticket: "Add support for mutual exclusive options" #199 ?

Thanks for this awesome library. Its the best arg parser there is.
Yes its the same thing.

Cool!
#199 is in progress. It won't be in the 3.0.0-alpha-1 release, but in one of the subsequent releases. Please be patient! :-)


Cannot add the -ObjC linker flag when integrating Firebase Analytics via SPM

Step 1: Describe your environment

Xcode version: 12.5.1
Firebase SDK version: 8.6.0
Installation method: Swift Package Manager
Firebase Component: Analytics

Step 2: Describe the problem
The SPM integration guide mentions the -ObjC linker flag which must be added when Firebase Analytics is used.
However, when Firebase is integrated via a Swift package and once this flag is added to the package’s target, it’s no longer possible to use the package in the iOS app due to the The package product 'MyPackage' cannot be used as a dependency of this target because it uses unsafe build flags error.
Steps to reproduce:

Declare a Swift package in an iOS app project and add it to the app target;
In Package.swift, add Firebase Analytics as one of the package’s targets’ dependency;
Specify the -ObjC flag in linkerSettings for that target (see below);
The app target builds with the aforementioned error.

.target(
    name: "MyAnalyticsTarget",
    dependencies: [
        .product(name: "FirebaseAnalytics", package: "Firebase"),
    ],
    linkerSettings: [.unsafeFlags(["-ObjC"])]
),

The -ObjC option needs to be added to the app's build settings. It should not be added to a Package.swift. See the screenshot in https://github.com/firebase/firebase-ios-sdk/blob/master/SwiftPackageManager.md


more strong mode fixes

change from using markd to markdown to fix several strong mode errors.
add a ddc grinder task to check the source code with the ddc

https://github.com/dart-lang/dart-pad/issues/694