[CMake] Warn about not using libcxx

For example, pull request: #15191

@swift-ci please smoke test

Please don't. We don't want to require libcxx; it's an error if our tests do.

We could have just as much of a problem between libcxx versions.

That's why I used WARNING and the word "untested". As a warning, do you still object to this? If yes, then how do you feel about just printing the status of LLVM_ENABLE_LIBCXX as a hint that Swift mildly cares and for help in debugging other people's configurations?

Also, unless I'm missing something, the build-script always sets LLVM_ENABLE_LIBCXX, therefore as the only blessed way to build swift, LLVM_ENABLE_LIBCXX is effectively required.

Does LLVM_ENABLE_LIBCXX fail on systems that don't have libc++ present, though? We probably already get a warning just from that.

Swift doesn't do anything other than pass -DLLVM_ENABLE_LIBCXX=TRUE as a part of the build script; and LLVM ToT seems to assume that LLVM_ENABLE_LIBCXX=TRUE will work if set, but it fails by accident if libcxx is not installed (Host compiler must support std::atomic! on Fedora Linux 27).
I happy to close this PR if you think LLVM should just error out and then Swift can rely on that check.

That sounds like it would work if you had a newer libstdc++.
I'm not sure why you're pushing for this. We had a test failure because the C++ standard library was different on different platforms. That's a problem with the test. We fixed it. Why would you want to warn here?

Right now, unified builds "just work", but there are minor configuration differences. While I'd prefer to make those differences disappear, I don't think that unified builds need to be intentionally hard either. It seems reasonable to me to warn unified build users about important differences. Of course, reasonable people can disagree about whether untested C++ standard libraries count as an important difference.
You know, come to think about it, why is build-script force enabling LLVM_ENABLE_LIBCXX? I'd wager that dates back to when macOS had both C++ standard libraries installed. Can we just delete it from the build-script? That would also make me happy. :-)

@davezarzycki I definitely use three different C++ runtimes: libstdc++, msvcprt, and libc++.

Let's take this to the forums; maybe someone there will remember why LLVM_ENABLE_LIBCXX was added in the first place.

Which forum? Compiler? something else?

Compiler is fine. There's theoretically a distinction between the C++ stdlib we use for the compiler and the one we use for the runtime as well, but…that's probably a separate issue.

https://forums.swift.org/t/rfc-remove-hard-coding-of-libc-from-the-build-script/10958

I'm abandoning this PR in favor of no longer hard coding the use of libcxx by the build script. See #15233


Add Other Rectangular Picker

Please add this style of rectangular picker.

Why is it needed? Reasons?
Btw. you can do add it yourself by subclassing ColorPaleteControl. No need to to change FlexColorPicker code for that. See https://github.com/RastislavMirek/FlexColorPicker#extending--overriding. You will also need Hue slider to go with that kind of palette (subclass ColorSliderControl). Hue slider is a planned feature so push request would be very welcome.

Why? I thought it would be a nice enhancement. I will see what I can do.


Unreadable messages when LANG is ru_RU.UTF8

When Bash locale is ru_RU.UTF8 all messages are unreadable because they are written in Russian language with invalid codepage:

Actually I don't want Russian messages. I want English UI with Russian formatting for dates and numbers - the same way as I use my Windows.
Microsoft Windows [Version 10.0.14393]

And Midnight Commander shows Cyrillic characters instead of pseudographics even when LANG is en_US.UTF8:

This is the same as #564.
To update your locale to en-US use the below command.
sudo update-locale LANG=en_US.UTF8

It would be the same issue if messages were written with Cyrillic characters, but they are written with pseudographics, thus unreadable.
I know how to switch locale and I did it, but Midnight Commander still uses invalid characters to draw its tables.

My issue is about character encoding/codepage/font and not about language.


Added a Blueberry Muffin / Cake recipe

Allright, i think that's about it! :)
I make this draft ready for review, but please do add commentary if there is something wrong!


Reconsider regex syntax match

As #449 showed, specifying single-keyword syntax names to match against any part of the syntax path is bound to create false positives.
Intuitively, it feels like only the filename part of the syntax path should qualify for wild-card matching, but this feels like a lot of logic (especially considering the existing complexity) for a lookup that should be fast and is rarely changed once correct.

Removed this for now, an alternative match would be more restrictively wrapping the search string, like \/Javascript[\s\w()]*\.\b, which would not accidentally match /JavaScript/JSON.sublime-syntax


Change kubectl download url, update README

Latest version v0.11.1 cannot download kubectl in version 1.30.5 and fails with error.
I have changed download url for the official docs and it works correctly even for older versions.
chore: fix missing version change in package.json
Fixes #62

@mmalyska  I apologize for not responding for so long 🙏


Ssotomayor feature/532 content type hard not send

closes #532
closes #534
@dougwilson @fundon @ssotomayor how about this?

Seems in the same direction as this, however as i pointed out before, i'm not sure why is application/octet-stream as the default option, there are even tests checking that. If there is no logical reason i support the option of setting null as any header option to NOT send it, then the user decides.

LGTM

anyone else?

LGTM. agree w/ @dougwilson's comment on the previous PR for this fix

+1

+1

LGTM

@ssotomayor octet stream is a reasonable default I think, everything is an octet stream haha, but :+1:  for this

Just closed the other PR, i agree with the fixes. :+1:

Hi. Is there a way to respond with an undefined body and DO NOT set a content-type.
I'm trying to make an internal redirect by nginx depend on the headers that returned from koa's backend. All I need is only one field X-Accel-Redirect; but Koa appends Content-Type: text/plain header which will be transparently proxied through nginx. But if content-type were absent in koa's respond Nginx automatically decides what type it is and sets it correctly.
I found the code where the magic happened application.js#L218:
  // status body
  if (null == body) {
    body = ctx.message || String(code);
    if (!res.headersSent) {
      ctx.type = 'text';
      ctx.length = Buffer.byteLength(body);
    }
    return res.end(body);
  }

according to this I will always get non empty body?

Right after posting prev comment I found that if I explicitly set body to null ctx.body = null; I receive 204 status code as expected. Wonder why it is not default behavior. When I don't set the body shouldn't it be treated as if I set it to null


EB-293: Decide when links should and should not open in new tabs

Hi!
I've made some edits to the Hugo content files to change all internal links (excluding opening the genome browser) to open in the same tab by default. I have not edited any external links that were already set to open in a new tab by default.
Looking at various UX guides/articles online it seems to be preferred to have as few links as possible open in a new tab by default and there is some debate about whether external links should by default open in a new tab too. Regardless, I think this first commit is a good starting point (and potentially "good enough" already).
Feel free to state your opinions or make a commit to this branch. We can also discuss this briefly in the meeting later today

Great, thanks for both taking a look! I will merge now.

I realized that I had not considered how opening of links affect the genome browser page. I clicked around a bit, and it seems that the state of the JBrowse session is cached, so if a user accidentally clicks on an internal link while working in the genome browser, they can return to the state of the session by using the back-button the their browser. That's all good, I think. But if they go back to the species page and click on the genome browser button, the defaultSession will be launched, loosing the previous state. This is the expected behavior, but I wonder if it is clear to the users. Anyway, I have no good answer for this myself, so I'm throwing it out there for discussion.

Thanks for bringing this up, I can confirm I experience the same thing and I'm not sure how easy this would be to "fix" or if we should either if it is the expected behavior?


Modal doesn't appear in IE10/EDGE

Modal works great in Chrome and Firefox, but not IE10/EDGE. When I click the button to display the modal nothing happens. I don't have any console errors or nothing visible to investigate.
Not sure what info you need- I'm new at posting issues.

I tried adding this to no avail:
<meta http-equiv="X-UA-Compatible" content="IE=Edge">


Rancher-K3s Bootstrap Mechanism

In order to be able to provision K3s or RKE2 from within Rancher, a bootstraping mechanism is needed. As we consider design and iterate on this we can update this issue with more information.

Bootstrapping has been moved into the scope of the Rancher agent that @Oats87 is working on.

Bootstrapping has been moved into the scope of the Rancher agent that @Oats87 is working on.

Close in favor of https://github.com/rancher/rancher/issues/31379 which more accurately describes the work being done in the agent.


kctrl package installed delete has no --wait option

Describe the problem/challenge you have
I want to handle myself the waiting for both installation and removal of a package.
During installation I can provide the --wait=false flag to the kctrl package install command, but unfortunately such an option is not available to the kctrl package installed delete command.
Describe the solution you'd like
The same --wait flag should be made available to kctrl package installed delete command, too, and make the command behave accordingly:
true (default): the command returns only after the package has been completely removed, like it's behaving as of today;
false: the command returns immediately with exit code 0 and should completely detach from the uninstall process that's been taken care of by kapp-controller.
Anything else you would like to add:

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Thanks, @matteo-magni for reporting the issue. We will discuss and update the issue with next steps.

Hi @100mik ,
the kapp-controller is actually the one doing the heavy-lifting for both installing and removing packages, and therefore the presence or lack of the --wait flag in kctrl CLI would not affect it. This is to say that I think it could (or should) take care of the RBAC resources anyways.
I don't mind (too much) about this feature when running kctrl interactively, but my main use case is in a CI workflow, where I'd like to have the CLI return immediately. This would allow me to:

run other commands whilst kapp-controller gets rid of the resources included in the package;
not getting flooded by verbose deletion messages at intervals specified via --wait-check-interval, which would end up "polluting" the workflow logs;
wait at my own discretion for everything to be cleaned up via kubectl wait --for=delete packageinstalls.packaging.carvel.dev my-install-name.

Cheers

I see the use case you have.
kctrl simply translates/creates kapp-controller CRs. The PackageInstall resource created by kctrl on the cluster is refers to the ServiceAccount that kctrl creates.
The controller itself does not treat other resources created by kctrl differently.
From our perspective, we are trying to avoid cases where users use the --wait flag without realising that there might be resources left behind.
In theory, we could have something like --dangerous-deactivate-wait>
However, I wonder if this could be resolved by some bash magic that can solve this. Something along the lines of "pipe output for this command to a file and check for completion at the end". Gonna dig in a bit.


Expense Tracker

Aim

I would like to create an Expense Tracker python project

I am a GSSOC'21 participant and would like to work on this issue.

Hi @nidhivanjare, We already have this issue: https://github.com/avinashkranjan/Amazing-Python-Scripts/issues/779 and the assigned person has also made the PR but she hasn't updated it yet. Today is her last day for this. If she fails to do so, then I will assign that issue to you. For now, this issue will be closed.


Verus-Desktop v0.7.1-4 doesn't allow custom chain location

When setting a custom chain location for Verus, copying the data to it and starting Verus-Desktop and adding Verus, the error chainTicker not defined pops up and Verus cannot be added, until you have removed the custom location and restarted Verus-Desktop.

Users that use custom locations on older Verus Desktop versions and upgrade to 0.7.1-4 are confronted with no wallets loaded in their wallet. They can't add their existing wallets, it results in the same chainTicker not defined error

This issue has been resolved in v0.7.1-5


fix: LargeMessageIdempotentE2ET Flaky

Issue #, if available:
n/a
Description of changes:
The test fails intermittently. If you look at the state of the world after the test fails, the data it is looking for in the DynamoDB table is there. This indicates that the test is failing because we are not giving the Lambda enough time to complete.
Bumping out timing magic numbers is not very satisfying but I can't see another way of doing this.

Checklist

[ ] Meet tenets criteria
[ ] Update tests
[ ] Update docs
[ ] PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2602ea7) 79.38% compared to head (c7754cc) 79.49%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1518      +/-   ##
============================================
+ Coverage     79.38%   79.49%   +0.10%
  Complexity      755      755
============================================
  Files            93       93
  Lines          2877     2877
  Branches        307      307
============================================
+ Hits           2284     2287       +3
+ Misses          494      492       -2
+ Partials         99       98       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HOSTEDCP-1073: enforce blocked rollout of HCP

https://issues.redhat.com/browse/HOSTEDCP-1073
After this PR, the HCP reconciliation rolls out in the following runlevels, in line with what the CVO would do, where all components in each runlevel must be fully rolled out before reconciling the next runlevel.

etcd
kube-apiserver
kube-controller-manager, kube-scheduler, openshift-apiserver
everything else

This fixes both the Jira issue and the issue where previously IsDeploymentReady didn't actually work because the Get did not get the just create/updated version of the resource.
Timing looks like this:

2m30s etcd rollout
6m KAS rollout
3m30 for KCM, KS, OAS
4m for everything else

Total HCP upgrade time is 16m.
Before this change upgrade time was ~10m.  It could be faster if the race in IsDeploymentReady is hit, bypassing the KAS and OAS check that already exists.

/lgtm

/cherry-pick release-4.13


chore(parser): move import specifier parsing to list.rs

Self explanatory, but moving the parsing of import declaration specifiers into js/list.rs as the TODO said 😛

Thank you!


Multiple faces gaze detection

Hi there! is there a way to access several eyes gaze at the same time?
I see in the analyses methode that it only uses the first one landmarks = self._predictor(frame, faces[0]) how could I modify the script to save a pair of eyes for every faces detected?
Thanks!!

I'm looking solution for same problem

I am as well.


Add Mathematic Book

What does this PR do?
Add resource
For resources
Guide to discrete mathematics 2016 -  David Gries,Fred B. Schneider
Description
The objective of this book is to give the reader a flavor of discrete mathematics and
its applications to the computing field. The goal is provide a broad and accessible
guide to the fundamentals of discrete mathematics, and to show how it may be
applied to various areas in computing such as cryptography, coding theory, formal
methods, language theory, computability, artificial intelligence, theory of databases,
and software reliability. The emphasis is on both theory and applications, rather
than on the study of mathematics for its own sake.
There are many existing books on discrete mathematics, and while many of these
provide more in-depth coverage on selected topics, this book is different in that it
aims to provide a broad and accessible guide to the reader, and to show the rich
applications of discrete mathematics in a wide number of areas in the computing
field.
Each chapter of this book could potentially be a book in its own right, and so
there are limits to the depth of coverage for each chapter. However, the author
hopes that this book will motivate and stimulate the reader, and encourage further
study of the more advanced texts.
Why is this valuable (or not)?
valuable
How do we know it's really free?
actually it's free knowledge
For book lists, is it a book? For course lists, is it a course? etc.
yes this is a Book
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

The repo does not host books. Please read docs/CONTRIBUTING.md guidelines. If the book is free licensed, consider depositing in archive.org or unglue.it


Text interactions break on transformed layers

Description
When working on a transformed layer, selecting a region of text by dragging on egui::TextEdit or egui::Label doesn't work properly.
Clicking on a transformed egui::TextEdit doesn't focus the widget. Holding the button for a bit before releasing works for some reason. Interestingly, this also happens when clicking the edge of the widget, even without transformation.
https://github.com/emilk/egui/assets/43807375/59a8a2c3-8534-4b77-8584-e47e49e02d9e
Steps to reproduce

use emilk/eframe_template@d168539c2232ad520a0c38d6e45864489b55e513
update egui and eframe to emilk/egui@bf7ffb982a6e8c0a40d0871c38bccacef9ee8efb
remove all ui code and add the following inside egui::CentralPanel:

use egui::{emath::TSTransform, Label, LayerId, Pos2, Rect, TextEdit, Vec2};

// let transform = TSTransform::IDENTITY;
// let transform = TSTransform::from_translation(egui::Vec2::new(50., 0.));
let transform = TSTransform::from_translation(egui::Vec2::new(150., 0.));

let layer_id = LayerId::new(egui::Order::Middle, ui.id().with("child"));
ui.ctx().set_transform_layer(layer_id, transform);

ui.with_layer_id(layer_id, |ui| {
    let mut rect = Rect::from_min_size(Pos2::new(20., 30.), Vec2::new(100., 20.));
    ui.put(rect, Label::new("this is a test label"));

    rect.min.y += 20.;
    rect.max.y += 20.;
    static mut STR: String = String::new();
    ui.put(rect, TextEdit::singleline(unsafe { &mut STR }));
});

Thoughts
It seems like when handling these interactions, the transformation isn't applied properly.
For the focus issue, I think I have identified the relevant code snippet:
https://github.com/emilk/egui/blob/bf7ffb982a6e8c0a40d0871c38bccacef9ee8efb/crates/egui/src/response.rs#L181-L191
In line 188, the untransformed rect is checked against the untransformed pointer position.
When the widget is transformed away, the click happens outside the original area and the focus is removed.
I tried accessing the transform from this function using self.ctx.memory(), however this freezes the app, probably because the memory is already being accessed at this point?
I don't know the code well enough yet to be able to fix this.

I also encountered this and I posted a comment on the PR that introduced the set_transform_layer method: https://github.com/emilk/egui/pull/3906#issuecomment-2166817300

Rather then opening a new issue I will update here:
The relevant line of code causing this I believe is here
https://github.com/emilk/egui/blob/93d458bb68a5c6e1fd05cbebfd64701463e7ab61/crates/egui/src/widgets/text_edit/builder.rs#L546-L548
Changing it to something like this
if let Some(pointer_pos) = ui.ctx().pointer_interact_pos() {
    let t = ui.ctx().memory(|m| {
        m.layer_transforms
            .get(&ui.layer_id())
            .cloned()
            .unwrap_or_default()
    });
    let pointer_pos = t * pointer_pos;
    if response.hovered() && text.is_mutable() {
         ui.output_mut(|o| o.mutable_text_under_cursor = true);

I'm a bit afk atm but I will see about opening a PR when I have time


Make name property clearer in docs

As suggested in https://github.com/tim-evans/ember-file-upload/issues/151

Thanks! It looks like the docs website could use some more love with regard to this, but it's there, so this is a good step! ❤


Container-fix

[ ] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.814%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
105599

Relevant Lines:
117575

💛  - Coveralls


Error On Initialization

Hello,
I'm having a problem running your bot. After configuring the config.example.php and renaming it to config.php, and also after permitting write permissions to the directory, I then try and launch the bot by php -f twitchbot.php, however I am greeted with the following error:
PHP Parse error:  syntax error, unexpected '[' in /home/user/twitchbot/twitchbot.php on line 117

When I check line 117 on twtchbot.php, this is the line of code:
            $this->username = explode('!', ltrim($this->data[0], ':'))[0];

Any idea what could be happening?

hi which php version are you using? you could check logs directory and post its content here (without the passwd)


Prevent empty div when editing comment (#12404)

Backport #12404
close #12895

was not first .. -> #12991


[BugFix]support disable ssl for poco_http_client for aws sdk

Why I'm doing:
What I'm doing:
every http client need support disable ssl seperately, so we need to support it in poco.
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/aws/aws-sdk-cpp/issues/3111|
as described above, disable ssl should not be used without overrided endpoint


Fix example in README

Thank you for porting this project over to Ruby!

No problemo! Thanks for the fix.


Updating carbon via pip removes older data

I am not 100% sure this is a bug but I would appreciate if anyone could shed more light on this weird behaviour.
I had a running graphite-1.0.0 instance which is managed using pip-9.0.1
Today I ran a pip install carbon==1.0.2 and it logged the following entry
Installing collected packages: carbon
  Found existing installation: carbon 1.0.0
    Uninstalling carbon-1.0.0:
DEPRECATION: --allow-all-external has been deprecated and will be removed in the future. Due to changes in the repository protocol, it no longer has any effect.
Exception:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/usr/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/commands/install.py", line 342, in run
    prefix=options.prefix_path,
  File "/usr/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_set.py", line 778, in install
    requirement.uninstall(auto_confirm=True)
  File "/usr/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_install.py", line 754, in uninstall
    paths_to_remove.remove(auto_confirm)
  File "/usr/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_uninstall.py", line 115, in remove
    renames(path, new_path)
  File "/usr/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/utils/__init__.py", line 267, in renames
    shutil.move(old, new)
  File "/usr/lib64/python2.7/shutil.py", line 299, in move
    rmtree(src)
  File "/usr/lib64/python2.7/shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "/usr/lib64/python2.7/shutil.py", line 256, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/usr/lib64/python2.7/shutil.py", line 254, in rmtree
    os.rmdir(path)
OSError: [Errno 39] Directory not empty: '/opt/graphite/storage/whisper/collectd'

Managed to update to 1.0.2 after a couple of tries, but all my older metrics are no longer there.
I think this has something to do with the fact that storage dirs are a part of data_files directive and the fact that pip will remove data_files while updating the packaging.

Well, this just bit me and destroyed the data. All of it.
Thankfully it's not of high value, being home metrics and all that. But wow. As far as surprises go, this one got me. Changing my configuration to point to a different storage path.

I haven't done any work on the packaging side of things yet, but I will dig into this asap

storage/whisper directory is in the list of data_files for a long time already - https://github.com/graphite-project/carbon/blob/master/setup.py#L61
looks like something was changed in setuptools for processing existing files in subdirs.
Maybe we should change storage/whisper to e.g. storage/whisper/dummy.txt

That’s a good idea. It makes sense that pip/setuptools would remove package data directories and files. A reasonable expectation would be that pip would remove the file (storage/whispher/dummy.txt) but leave the directory intact if it wasn’t empty.

@deniszh This is a great idea. In the interim, removing the ../../storage entries from the following files ensures the update does not remove the stored metrics
For carbon:
/opt/graphite/lib/carbon-VERSION-pyVERSION.egg-info/installed-files.txt
For graphite-web:
/opt/graphite/webapp/graphite_web-VERSION-pyVERSION.egg-info/installed-files.txt
Probably the next release can use the dummy.txt idea and users can ensure data safety by manually changing these files before they upgrade to the next (corrected) version.

@redbaron4 :
Good idea, will do exactly that!

This was fixed in carbon-1.1.3


URL scheme and deeplinking

As a desktop application, eSteem Surfer should have support for steem:// url scheme.
for example:
steem://@username/permlink opens post
steem://@username opens profile of user
and any other possible combination, mainly get requests for now, later we will work on post queries to submit transaction to the blockchain and their schemes, popup screen to perform/confirm any action quickly

Follow this standard or use this package: https://github.com/steemit/steem-uri-spec

Read or get part is done. 👍
Write or post (broadcast) part is next...


The delete Operator behaviour in Firefox

In "Global code and Function code" it says in the example that in global scope the following will happen:
// global variable:
var a = 1; // DontDelete is set
delete a; // false
This is not true for Firefox v. 22; you CAN delete global variables using its engine.

Can we add a ES5 tiny tip on the side that this examples doesn't work anymore?


metrics for prometheus.io itself

any plan to expose https://prometheus.io/metrics ?
today http://prometheus.io was quite slow and I thought it would be fun and nice that if this website dog-fooding prometheus and expose metrics so people can see (what's happening) and maybe learn from it as well.

The website is served by 3rd parties, not by us running our own home-grown software, so such metrics simply aren't available to us. You can always look at the metrics of a Prometheus itself.

I see thanks for the reply and understood. And I'm aware of prometheus exposing itself which is pretty cool.

The main host for the site is cloudflare, we could try out our new cloudflare_exporter.
I was considering add this to the demo site metrics.


docs: cleanup docker update docs

move the "kernel memory" examples to the "examples" section,
and fix some formatting and grammar.
note: this should NOT be cherry-picked into the release branch, unless we decide to include https://github.com/docker/docker/pull/24504 in docker 1.12

LGTM

@thaJeztah Two small nits 👼

@vdemeester updated! Should we merge this now, or wait until 1.12 GA?

@thaJeztah can we have a milestone for this - either v1.13.0 or v1.12.1?

@SvenDowideit the related PR will be 1.13, so I'll add it to that milestone

LGTM 👼


Fix some documentation errors

CLA: trivial
The APIs changed in commit depend on BIO_ctrl, which will return negative values.
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Agreed, trivial.

This pull request is ready to merge

Merged to 3.0 and master, thanks for the fix.


Cursor files removed from Gmail

I suppose Gmail removed the cyrsor files:
"NetworkError: 410 Gone - https://mail.google.com/mail/images/2/openhand.cur"
openhand.cur
"NetworkError: 410 Gone - https://mail.google.com/mail/images/2/closedhand.cur"
closedhand.cur
Best regards, keep on the very good work, Ringo

The cursors appear to be at:
http://www.google.com/intl/en_ALL/mapfiles/openhand.cur
http://www.google.com/intl/en_ALL/mapfiles/closedhand.cur

Should likely incorporate these into this repo locally just in case those files get moved again. Google does this all the time. Don't rely on their ability to be stable with anything.


TLFS: Fix off-by-one bug in hypercall parameters definition

TLFS has an off-by-one bug for the last reserved field, which it defines as
being bits 64:60.  The same section states "The input field 64-bit value
called a hypercall input value.", i.e. bit 64 doesn't exist.
Note: published TLFS versions up to 6.0b don't have this issue.
Reported-by: Sean Christopherson<EMAIL_ADDRESS>Signed-off-by: Vitaly Kuznetsov<EMAIL_ADDRESS>

Thanks for fixing!


Fix #59: stop cross-origin objects from throwing in harness when creating failed assertion messages

Fixes #59.

@zcorpan @Ms2ger r?


Consider the addition of a Try.WithResources*#run(CheckedConsumer*) method

There are cases when we want to run some function that returns void.
While there is a Try.run that accepts a CheckedRunnable, when using the new Try.WithResources* API there is no equivalent method.
I see that there is only CheckedConsumer that accepts one argument but Try.WithResources* accepts up to 8 arguments so it'll require creating CheckedConsumers1..8 that accepts up to 8 arguments.

Possibly duplicate of https://github.com/vavr-io/vavr/issues/1263 ?

@anaumidis thx!
@flopezlasanta yes, indeed - I've updated the referenced issue and will close this as duplicate


iOS project with mockolo 1.6.2 fails to build.

Details
I use mockolo in iOS project with using Mint, and manage mockolo version with Mintfile .
With version 1.6.1 of mockolo, the iOS project builds successfully, but if specify the version to 1.6.2, an error occurs and the build does not succeed.
Error Message
MockoloFramework/SourceParser.swift:101: Fatal error: The operation couldn’t be completed. (SwiftSyntax.ParserError error 1.)

Environment
OS version
macOS 11.6.1
Swift version installed on my machine
Apple Swift version 5.4.2 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Xcode version
Xcode 12.5.1
PMs version
$ brew --version
Homebrew 3.3.6
Homebrew/homebrew-core (git revision df0e94b2a93; last commit 2021-12-02)
Homebrew/homebrew-cask (git revision 6c3d470278; last commit 2021-12-02)

$ brew info mint
mint: stable 0.17.1 (bottled)

mockolo Version
https://github.com/uber/mockolo/releases/tag/1.6.2
Compare 1.6.1 and 1.6.2
https://github.com/uber/mockolo/compare/1.6.1...1.6.2

@betat
I have not changed SwiftSyntax in 1.6.2, so I think there is another cause.
Could you please delete the cache of Mint etc. and try again?

@uhooi
Thank you for your reaction!
I solved this issue!!
I took the following actions.

Check the current Xcode version -> $ xcode-select -p
Delete Devived Data of Xcode 12.5.1
mint uninstall mockolo and mint bootstrap
Rebuild (and Build Succeeded!)

@betat
I'm happy because you solved the problem :)
The reporting of the problem was very clear.
I'll be referring to it as well!!


Fire off eds update on pod label change

Signed-off-by: dddddai<EMAIL_ADDRESS>Please provide a description of this PR:
Now the control plane does not fire off an eds update when pod label changes, which may lead to inconsistency, please refer to https://github.com/istio/istio/issues/36056#issue-1052149403
Fix #36056
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @dddddai. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dddddai: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hello @howardjohn @hzxuzhonghu, any ideas?

As a short term fix, i think it is viable. But long term fix we need to support meta label update.
Need another look though

/ok-to-test

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6587ab0ddee9c2b3cd3192d5eade9ece2419a9d1
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Generally in favor of the change directionally, just not sure it is sufficient to cover all cases and the test coverage is not high enough to prove this as is. Maybe this is step 1 though and we can followup.
Just high level review, I haven't had a chance to review the code yet but plan to soon.

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c8b1ccc0e45cadeff240d796d96703f56c80d293
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Generally in favor of the change directionally, just not sure it is sufficient to cover all cases and the test coverage is not high enough to prove this as is.

Thanks! I added some negative tests to cover more cases

@dddddai: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
84e3dcefd065ab1e2a4bfac26413706aa4fb2e1e
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5643babfbddbee1688b7b268dfb6e143d96251ed
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your review! pods selected by SE are handled by ServiceEntryStore.WorkloadInstanceHandler
https://github.com/istio/istio/blob/bc83862fbc62ca83493545ab332bdd68fe4b7e6b/pilot/pkg/serviceregistry/serviceentry/servicediscovery.go#L468

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e0d7e4ebd1a73d47697ef43ba862a6530bcfa92c
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn sorry to bother you, could you please take a look?

Sorry have been on holiday. Would be great to have a test that applies a config with workloadSelector, verifies it has no impact, then labels pod, verifies it has impact, then removes label and verifies it no longer has impact.
Will take a closer look soon

Would be great to have a test that applies a config with workloadSelector, verifies it has no impact, then labels pod, verifies it has impact, then removes label and verifies it no longer has impact.

Thanks for the suggestion, I've added a test for se

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8bc9ddaa445f786f729c9047412d7ae4df80f2ec
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai  thanks for the PR. We have tested this locally as well to check if the problem mentioned in #36056 is solved according to our usecase. And seems to work fine. @howardjohn @hzxuzhonghu

@dddddai: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
38fb03b9377e29f387ce612b9b688cb9b4a289db
link
true
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
38fb03b9377e29f387ce612b9b688cb9b4a289db
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

I am a bit worried that this PR only partially address the problem. This gives the mistaken idea that dynamic pod labels are supported. For example, this policy will not support dynamic updates even with this PR:
apiVersion: security.istio.io/v1beta1
kind: AuthorizationPolicy
metadata:
  name: name
spec:
  selector:
    matchLabels:
      custom: label
  action: DENY
  rules:
  - to:
    - operation:
        methods: ["GET"]
        paths: ["/user"]

I have no problem adding support for dynamic pod labels, but only if we do it completely. We also need integration tests that do things like:

Apply Config X with label selector Y not matching pod
Send request, assert config is not applied
Label pod with Y
Send request, assert config is applied
Unlabel pod
Send request, assert config is not applied

We would need this test for a variety of types as well - Dest rule, authz policy, etc.

@dddddai: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


ci(pr-build): integrate check runs to report build status

Background

Integrate check runs to report build status.
References:

Github API - Check Runs
About GitHub status checks
Github checks API vs check runs vs check suites

Checklist

[x] The Pull Request has been fully tested
[ ] There's an entry in the CHANGELOGS
[ ] There is a user-facing docs PR against https://github.com/daeuniverse/dae

Full changelogs

ci(pr-build): integrate check runs to report build status
ci(pr-build): integrate individual check run per stage
chore: add title for check-run step
ci(pr-build): add instantiate-check-runs stage

Issue reference

Closes https://github.com/daeuniverse/daed/issues/161
Test Result

https://github.com/daeuniverse/daed/actions/runs/5549917316

The proposed solution has already been tested. Ready for review.

Working like a charm 🤟


not allocated lock in store

hi. i use openssl in c++ for curl.i set CURLOPT_SSL_CTX_FUNCTION option to a function then curl call my ctx function. on ctx fucntion my code is `X509_STORE *store;
X509 *cert = NULL;
BIO *bio;
char *mypem =
"-----BEGIN CERTIFICATE-----\n"
"MIIDxTCCAq2gAwIBAgIBADANBgkqhkiG9w0BAQsFADCBgzELMAkGA1UEBhMCVVMx\n"
"EDAOBgNVBAgTB0FyaXpvbmExEzARBgNVBAcTClNjb3R0c2RhbGUxGjAYBgNVBAoT\n"
"EUdvRGFkZHkuY29tLCBJbmMuMTEwLwYDVQQDEyhHbyBEYWRkeSBSb290IENlcnRp\n"
"ZmljYXRlIEF1dGhvcml0eSAtIEcyMB4XDTA5MDkwMTAwMDAwMFoXDTM3MTIzMTIz\n"
"NTk1OVowgYMxCzAJBgNVBAYTAlVTMRAwDgYDVQQIEwdBcml6b25hMRMwEQYDVQQH\n"
"EwpTY290dHNkYWxlMRowGAYDVQQKExFHb0RhZGR5LmNvbSwgSW5jLjExMC8GA1UE\n"
"AxMoR28gRGFkZHkgUm9vdCBDZXJ0aWZpY2F0ZSBBdXRob3JpdHkgLSBHMjCCASIw\n"
"DQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAL9xYgjx+lk09xvJGKP3gElY6SKD\n"
"E6bFIEMBO4Tx5oVJnyfq9oQbTqC023CYxzIBsQU+B07u9PpPL1kwIuerGVZr4oAH\n"
"/PMWdYA5UXvl+TW2dE6pjYIT5LY/qQOD+qK+ihVqf94Lw7YZFAXK6sOoBJQ7Rnwy\n"
"DfMAZiLIjWltNowRGLfTshxgtDj6AozO091GB94KPutdfMh8+7ArU6SSYmlRJQVh\n"
"GkSBjCypQ5Yj36w6gZoOKcUcqeldHraenjAKOc7xiID7S13MMuyFYkMlNAJWJwGR\n"
"tDtwKj9useiciAF9n9T521NtYJ2/LOdYq7hfRvzOxBsDPAnrSTFcaUaz4EcCAwEA\n"
"AaNCMEAwDwYDVR0TAQH/BAUwAwEB/zAOBgNVHQ8BAf8EBAMCAQYwHQYDVR0OBBYE\n"
"FDqahQcQZyi27/a9BUFuIMGU2g/eMA0GCSqGSIb3DQEBCwUAA4IBAQCZ21151fmX\n"
"WWcDYfF+OwYxdS2hII5PZYe096acvNjpL9DbWu7PdIxztDhC2gV7+AJ1uP2lsdeu\n"
"9tfeE8tTEH6KRtGX+rcuKxGrkLAngPnon1rpN5+r5N9ss4UXnT3ZJE95kTXWXwTr\n"
"gIOrmgIttRD02JDHBHNA7XIloKmf7J6raBKZV8aPEjoJpL1E/QYVN8Gb5DKj7Tjo\n"
"2GTzLH4U/ALqn83/B2gX2yKQOC16jdFU8WnjXzPKej17CuPKf1855eJ1usV2GDPO\n"
"LPAvTK33sefOT6jEm0pUBsV/fdUID+Ic/n4XuKxe9tQWskMJDE32p2u0mYRlynqI\n"
"4uJEvlz36hz1\n"
"-----END CERTIFICATE-----\n";
bio = BIO_new_mem_buf(mypem, -1);
PEM_read_bio_X509(bio, &cert, 0, NULL);
if(cert == NULL)
printf("PEM_read_bio_X509 failed...\n");
store = SSL_CTX_get_cert_store((SSL_CTX *)sslctx);
if(X509_STORE_add_cert(store, cert) == 0)
printf("error adding certificate\n");
X509_free(cert);
BIO_free(bio);`
on call to X509_STORE_add_cert the application open crash dialog Access violation reading location 0x00000000. i open store in visual studio see

then change all 0x00000000 to number from 1 to 11 for detect what 0 is my problem then resume program and error occurred on

11 means

lock is 0x00000000 as you can see in my first image. 1.why lock is important and 2.why is not allocated? 3. why error occurred on X509_STORE_add_cert. tnx. this is a long story such as Harry Potter.

No response from OP so closing.


Remove version requirement from h5py.

I needed to do this in order to pip install TorchMeta on Mac OS X (python 3.8.2 installed with conda).

Thank you! On a similar note I should definitely add Python 3.8 to the tests.


Fix CMake build

rdar://38387074

@swift-ci test

Thanks Adrian! My only nitpick would be that [0-2] should suffice to match dictionary 'indices', but this lgtm.


Core: create persistent storage

Importing data from raw osm format is expensive. Better to convert to custom spatial index.

already in master


docs: update documentation to use player objects

Followup to #5861.

Is it uncertain whether this is the right place to ask, but I wanted to inquire .
If there are any plans to remove the data.shortName method in the future, or will it be retained indefinitely?

Is it uncertain whether this is the right place to ask, but I wanted to inquire . If there are any plans to remove the data.shortName method in the future, or will it be retained indefinitely?

In general if I remove something, I'll add some warning about it. Since people are writing their own triggers, I try to keep backwards compatibility as much as I can. In other words, I'm not planning to remove it, but I am planning to add tests so that people don't add more uses of this to cactbot built-in triggers.


add_data_layer guesses wrong lat/lon columns for my Earth-centered dataset

I have been playing around with visualizing the "Kent Puget Sound Flow Model" dataset, available as an Excel spreadsheet here, with pywwt.
Here's the header and first row as CSV:
lat,lon,depth,color,datetime,mag
48.157,-122.79,0.261287460327148,cyan,1/1/2010 0:00,0.01

If I load this up as a table and add it as a data layer through pywwt without explicitly assigning lat_att and lon_att, the code ends up guessing lat_att = 'lon' and 'lon_att = 'lat'! Kind of a funny failure mode.
I believe the problem is here in the code. If the column names aren't given, it defaults to assigning lon_att to the first (well, zero'th) column and lat_att to the second. That makes sense if your data start ra,dec,..., but it doesn't here.
IMO the best fix would be to look at the actual column names and apply some simple heuristics: e.g., set the longitude column to anything name lon, longitude, ra, etc. Perhaps also issue a warning, and use the current guessing scheme, if none of the heuristics come through.

I agree it would be good to have some kind of heuristics 👍


Training code for TrackQuery

Hi,
Thank you for your great work. I have noticed that the repo contains the description about TrackQuery.
Could you please release the code for TrackQuery at your convenience?
Thank you!
Best,
Fan

Hi @Flowerfan, thanks for your interest in our work!
The code of QueryTrack (paper) may not be released recently.
Now we are working on a journal version of QueryInst & beyond, which may includes QueryTrack.
After that, we may release the code of QueryTrack.


Configure SystemD Timer for Snapshots

Adds documentation and sample files for creating a systemd service and timer ran under a non privileged user as required by https://github.com/NebraLtd/hm-block-tracker/issues/46

@robputt Please also add the staging version (i.e. w/out PRODUCTION=1) and make sure to clear the old cronjobs.


Add support for scroll-margin and scroll-padding

Documented in this spec: https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-margin
This is how it'll be possible to set custom offsets without reimplementing the default scrolling behavior or changing the HTML structure to add wrapping elements with padding to accomplish the same thing.

Hi! I've been wondering about how to implement this. Trying to get things to scroll correctly with a sticky header has been uneven, and I like the idea of supporting these properties to achieve consistency.
Here's a rundown of my thoughts so far; I'd love your input if you have time!
Things affected
Scroll padding and margin would affect two things:

The amount to scroll, depending on scroll-margin on the element, or scroll-padding on an ancestor;
Whether the element should be considered "in view", for the purpose of that scrolling behaviour.

Communicating those properties
Reading the spec, it seems that eventually we'd be able to read the computed style, same as concurrently done in compute-scroll-into-view. Until browsers implement it, that seems unlikely. Similarly, as a polyfill, I think this means we have to pass those properties as function arguments?
Code bits
If the above is true, it seems that we'd have to modify both scroll- and compute-into-view. I see perhaps how scroll-margin would work. Since the polyfill works only on the element, is it even possible to implement scroll-padding?

Hey @fpapado! I appreciate your thoughtful feedback! I'll do my best to respond here.
When I set out to refactor this package into what became v2 more complicated things like sticky + fixed positioning were one of the things I had in mind. It's difficult to get things like that right, as it depends on more information than the computed style of the element you are wanting to scroll, or the offset parent. You have to walk up the full tree to properly scroll the element into view, on possibly multiple scroll boxes.
That's why the compute-scroll-into-view package is actually calculating possible scroll coordinates for anything that isn't within the boundary.
It runs this check today to decide wether something can overflow = scroll boundary: https://github.com/stipsan/compute-scroll-into-view/blob/b850561acfb87b7b67a52f863f4c029bcad6f894/src/index.ts#L56-L77
I haven't dived into the spec on scroll-padding yet so I can only assume that scroll padding only makes sense on elements that are scrollable. If that's the case then it's possible to implement scroll-padding using the work that's already done to implement border-width correctly. In fact, border widths appear to affect scrolling on children elements much the same way scroll padding does.
scroll-margin would also need to be implemented similar to how border widths are taken into account with the scroll target.
You're also right that reading these new CSS property can prove to be a challenge. Unlike border widths it's unlikely they'll show up in getComputedStyle in browsers that don't implement them.
I really hope we can avoid needing to pass these values as properties in function call itself. Especially since today's API don't let you specify other elements than the target element and the boundary. Specifying scroll margins and paddings on elements between the boundary and scroll target would require the API to be much more complex. I hope it's possible to somehow have it stay in CSS so that the migration path away from this polyfill stays is as simple as: scrollIntoView(target) => target.scrollIntoView().
Another question is wether compute-scroll-into-view should try to implement scroll-margin and scroll-padding directly, or if it should expose the hooks necessary for scroll-into-view-if-needed to do the bulk of the work to keep the compute-scroll-into-view package as small as possible.
Since the bundlesize of downshift is directly affected by this I'd like to hear what @kentcdodds thinks, and perhaps ask for feedback from the downshift community as well 🙂

How much will this impact the bundle size?

I don't know yet what the impact will be. I'll run a POC and ping you when I have some numbers to look at 🙂

Hey, @stipsan! Loved that response, it matches much of my own dilemmas when considering where and how this could be supported. I think exposing hooks in compute-scroll-into-view might be nice, in case some other consumer of the library wants to add more custom calculations/offsets.
A random thought that came to mind: could we use a custom property as a halfway point between the "real" CSS properties and the ponyfill? Those would show up in getComputedStyle iirc. Something like --scroll-into-view-padding, --scroll-into-view-margin. It wouldn't "work" on IE11, but it acts as a progressive enhancement, and would not regress wrt the current behaviour anyway. That might allow us to keep things declarative and forward-looking, without extra parameters on the function.
I need to think a bit more about the other constraints, but I'm hopeful!

A scroll-padding css property would be a pretty beautiful to achieve a lot of this. That way it could be reflective of specific elements, and also react to a css-custom property that might be updated as fixed things sit on top of other things...
It might make the Standards cry, though.

The best way to support IE11 is to use a markup structure that can accomplish the same things without using scroll-padding or scroll-margin.
With that in mind I think it's fine to rely on custom properties to "bridge the gap". As in we can use getComputedStyle to first check for scroll-margin-* and scroll-padding-* properties first, and if there isn't any it can fall back to --scroll-margin-* and --scroll-padding-*.
You could even write a post-css plugin that emits the custom properties for you based on the native properties so you don't need to manually keep duplicates in sync.
Again, this would mean you can't use this feature if you need to support IE11. But I don't believe we can make it work in IE11 without ending up with an unacceptable bundle size or impractical complexity.
With regards to making standards cry... I'd rather use custom properties than introduce even more properties in the JS API that isn't in the spec if you know what I mean 😅

I need either this, or an offset I can supply. 😕

The draft spec has signaled this is coming in the if-needed spec, I'll work on this soon 😄

Hi @stipsan :).
Is there any progress on supporting scroll-padding/margin to this library? It seems to work pretty well, but we have a use case where we need to actually "flush" the container to fill the whole width, and adding the scroll margin/padding is currently necessary.

Hi @stipsan ,
Thanks for the amazing work on this lib, any news on this topic ?

I also needed this. (Chrome supports scroll-padding with scrollIntoView but has some bugs preventing me to use it.)
Here's my implementation (supporting top and bottom padding). For scrollPaddingTop, we can just subtract it from the computed top. For scrollPaddingBottom, we then need to make sure that the computed top doesn't put the target too low.
Would be happy to see support for this in scroll-into-view-if-needed.
import { compute } from "compute-scroll-into-view";

const getScrollPaddings = (target: Element) => {
  const computedStyle = window.getComputedStyle(target);
  return {
    top: parseFloat(computedStyle.scrollPaddingTop) || 0,
    right: parseFloat(computedStyle.scrollPaddingRight) || 0,
    bottom: parseFloat(computedStyle.scrollPaddingBottom) || 0,
    left: parseFloat(computedStyle.scrollPaddingLeft) || 0,
  };
};

export function scrollIntoView<T = unknown>(
  target: HTMLElement,
  options: Parameters<typeof compute>[1] & { behavior: ScrollBehavior },
): T | void {
  for (const { el, top, left } of compute(target, options)) {
    // Get scrolling element's scroll-padding
    const scrollPaddings = getScrollPaddings(el);

    // Subtract padding from computed top
    const topWithPadding = top - scrollPaddings.top;

    // Make sure to not scroll too far down
    const safeMin =
      target.offsetTop +
      target.getBoundingClientRect().height +
      scrollPaddings.bottom -
      el.clientHeight;

    const adjustedTop = Math.max(topWithPadding, safeMin);

    el.scroll({ top: adjustedTop, left, behavior: options?.behavior });
  }
}


DBD::SQLite before 1.71_07 / 1.72

CVE-2022-35737 affects SQLite 1.0.12 through 3.39.x before 3.39.
After 1.71_07 it was upgraded SQLite to 3.39.4

I filled out the reports for sqlite. So far I think only DBD::SQLite distributes it. Alien::sqlite downloads whatever the latest version is.

Thanks.

Alien::sqlite downloads whatever the latest version is.

It makes me wonder if there should be an option to flag "unknown but possible" issues in the database, that are normally ignored by the scanning tool unless an option is set.  That might be useful to advise people to manually check.  I'm not (yet) sure how that would work in practice.


Expose calendar kwargs via get_calendar and handle out-of-bounds dates

Partially covers #31 by exposing ExchangeCalendar kwargs via get_calendar.
Cache maintained on basis:

only one copy of any calendar is cached.
cached copy will be returned if calendar is requested with start and end dates that parse to the same values as those for which the cached version was created. Otherwise cached copy is overwritten with newly created calendar.

@GerryManoim, could I ask that you consider the appropriateness of the 'Notes' section that I've included to the ExchangeCalendar class documentation here. Please offer any suggestions / revisions as you may see fit. Separately, please note this PR includes all commits of #35)
I intend to raise separate PRs for:

#33 (which has required new bounds test test_start_bound to be marked xfail on a few calendars).
the side option part of #31.

I was looking to push something that would resolve the conflicts that have cropped up but I can see I'm just going to make a hash of it.
All conflicts in calendar_utils should be resolved as on the master branch. Also, 3 lines above the first conflict require deleting (253-255, from def get_calendar_names...), no idea why they aren't included within the conflict.
The conflict in test_calendar_dispatcher should be resolved as the start_end branch.


Tweet Tokenizer - preserve_case does not lowercase always

When the preserve_case argument of TweetTokenizer is set to True we should expect that it lowercases examples like 'Ok' or 'A' but it doesn't.

preserve_case is supposed to keep the original capitalization of the input if it already there. By default, it's set to True. E.g.
>>> from nltk.tokenize.casual import TweetTokenizer
>>> tt = TweetTokenizer()
>>> tt.tokenize("OK, I've to go")
['OK', ',', "I've", 'to', 'go']
>>> tt.tokenize("A, I've to go")
['A', ',', "I've", 'to', 'go']
>>> tt.tokenize("A, I've to go A")
['A', ',', "I've", 'to', 'go', 'A']

If it's set to False, it will start lowercasing everything except for emoticons, see https://github.com/nltk/nltk/blob/develop/nltk/tokenize/casual.py#L308. E.g. :
>>> from nltk.tokenize.casual import TweetTokenizer
>>> tt = TweetTokenizer()
>>> tt.tokenize("OK, I've to go")
['OK', ',', "I've", 'to', 'go']
>>> tt.tokenize("A, I've to go")
['A', ',', "I've", 'to', 'go']
>>> tt.tokenize("A, I've to go A")
['A', ',', "I've", 'to', 'go', 'A']
>>> tt = TweetTokenizer(preserve_case=False)
>>> tt.tokenize("A, I've to go A")
['a', ',', "i've", 'to', 'go', 'a']
>>> tt.tokenize("A, I've to go OK")
['a', ',', "i've", 'to', 'go', 'ok']


ROX-20541: Fix/probe build 6.6

Description
Newer linux versions have a different inode->c_time name. Upstream has commits to deal with kernels >=6.6.
Grab those commits.
Checklist

[ ] Investigated and inspected CI test results

Testing performed
The 6.6 drivers are built: https://github.com/stackrox/collector/actions/runs/6732458773/job/18307783357?pr=1402#step:5:24

LGTM! I'll approve once stackrox/falcosecurity-libs#63 is merged and this PR is updated to point to master.


fix: override default image

Signed-off-by: Kambui Nurse<EMAIL_ADDRESS>

@Siafu I'm guessing you might have an update to this PR now.

Talked with @Siafu and it's good to close this one now. He's using the universe package.


Allow backend.proxy parameterization

Added new console flag --paramBackendProxy. Flag set to true includes such a complex-object parameter in the output template file and sets the same settings to all of backend resources extracted.

Closes #622

Is it needed on all backend proxies, or just the logic apps ones?  If a customer has two logic app flows (in different logic apps), is the backend proxy the same?

@adrianhall, as I undestood from the discussion, clients wanted to have a proxy parametirization, because they are having only logic apps under the hood of the APIM.
As I see from the documentation of APIM API, we can not identify type of backend resource (view https://docs.microsoft.com/en-us/rest/api/apimanagement/current-ga/backend/get#backendcontract). So I can not determine, if backend resource is a logic app, and set proxy parametrization for it and in the other case just ignore proxy section.
So that is why I decided to put parametrization of proxy section for each backend resource, if proper console flag is set.
What do you think? (sorry if I misunderstood the question)

I'm not disagreeing with the approach just yet.  Just asking the question about our API.  Can the customer set a different proxy on each backend, or do they set a single proxy for all APIs.  Your proposed solution is good for the latter and will cause issues in the former.

I think they can set different proxy on each backend, because we can create 2 or more backend entities from Azure Resources -> Logic Apps, which can have different proxy settings. So by default from the possibilities of user, I think it could be possible.

If that is the case, then I don't like this solution.   Customers will use multiple logic apps so will have multiple proxies.

It is hard to control the settings just using some console-boolean flags. So this complex scenario could be supported in this way.
User has to create a configuration for extractor, specifying proxy-parameterization section
{
    ... ,
    "backend-proxy-settings": [
         {
             "proxy-settings-section-name": "my-backend-group-1-name", // unique name of group of backend resources, that need to have the same proxy settings section linked
             "backend-resources-names": [ "my-backend-resource-1", "my-backend-resource-2" ]
         },
         {
             "proxy-settings-section-name": "my-backend-group-2-name", // unique name of group of backend resources, that need to have the same proxy settings section linked
             "backend-resources-names": [ "my-backend-resource-3", "my-backend-resource-4" ]
         }
    ],
    ...
}

This allows to specify anything you want really. Also I like that we will be declining exposing a lot of boolean flag console app arguments, which are very hard to maintain because of their amount. Configurations are always better in my opinion (more code to handle the flow, but much more maintainable and understandable).
What do you think?

Per discussion, we will extract the backend proxy without additional configuration (including no additional boolean command line arg - if backend parameterization is requested, then proxies will be parameterized too).  We will determine which proxies are unique and provide a separate parameter for each unique proxy.  Care to be taken around "what happens if we add a new proxy" to ensure that existing proxies continue to work with a parameter file.  Perhaps by using the URL as part of the parameter name?

I believe we can close this PR, to not take time in resolving conflicts, and change the approach here, PR: #787 introduced which includes agreed changes and ready for review

Closing a PR due to another implementation in #787. Thanks, @f-alizada


This project does not rely on DeepSpeed and Megatron？

Correct, this project does not rely on DeepSpeed nor Megatron.


unperfect screenshots (do not match a photo of the screen).

I followed the guide ( https://learn.adafruit.com/saving-bitmap-screenshots-in-circuitpython/overview ) to take a screencapture.
However the result does not match exactly what is in screen.
My code to demonstrate this problem is in this repo:
https://github.com/dglaude/CircuitPython_MLX90640_PyGamer_Plus

mlx90640_pygamer_plus+sd.py is the program that use BitmapSaver.
Photo_of_screen.png is the kind of thing displayed on the screen.
screen.bmp is the offending image generated.

I believe there are two problems with the above image:

The last column of pixel from the picture are duplicated to the edge.
The three temperature (min, center, max) are not text but colour blob.

Unfortunately this code require a MLX90640 thermal camera, but I am sure the camera output can be faked to trigger this problem without that hardware.
PS: Notice that 'picture.bmp' is an OK output, but that specify a bitmap and a palette (rather that full screen version without those parameter).

While I did not narrow down what is wrong, I made a demo that does not require a MLX90640 and just require a PyGamer. This code is 'fake_mlx90640_pygamer+sd.py' and it produce a valid 'picture2.bmp' and a faulty 'screen2.bmp'.
It might be possible to make an even smaller example of code that produce that leaking of pixel and unreadable text.

Here is a small code sample exposing the first problem = the leaking the last column of pixels.
There is another problem with the label.
### Adafruit_CircuitPython_BitmapSaver_minimal.py

import time
import board
import busio
import displayio
import adafruit_fancyled.adafruit_fancyled as fancy
import digitalio
import adafruit_sdcard
import storage
from adafruit_bitmapsaver import save_pixels

spi = busio.SPI(board.SCK, MOSI=board.MOSI, MISO=board.MISO)
cs = digitalio.DigitalInOut(board.SD_CS)
sdcard = adafruit_sdcard.SDCard(spi, cs)
vfs = storage.VfsFat(sdcard)
storage.mount(vfs, "/sd")

number_of_colors = 64                          # Number of color in the gradian
palette = displayio.Palette(number_of_colors)  # Palette with all our colors

# gradian for fancyled palette generation
grad = [(0.00, fancy.CRGB(0, 0, 255)), (1.00, fancy.CRGB(255, 0, 0))]    # Blue - Red
fancy_palette = fancy.expand_gradient(grad, number_of_colors)
for c in range(number_of_colors):
    palette[c] = fancy_palette[c].pack()

image_bitmap = displayio.Bitmap(32, 24, number_of_colors)
image_tile= displayio.TileGrid(image_bitmap, pixel_shader=palette)
image_group = displayio.Group(scale=4)
image_group.append(image_tile)
group = displayio.Group(max_size = 8)
group.append(image_group)
board.DISPLAY.show(group)

for h in range(24):
    for w in range(32):
        image_bitmap[w, (23-h)] = h + w

save_pixels('/sd/picture5.bmp', image_bitmap, palette)
save_pixels('/sd/screen5.bmp')

while True:
    time.sleep(1)

screen5.bmp.pdf
picture5.bmp.pdf

Hi @dglaude were you ever able to figure out why this was happening?

I did not try to reproduce anymore, and I did not check in the code of the
library either.
I made code to reproduce the problem, it should be easy to reproduce.
Le jeu. 18 juin 2020 à 01:51, dherrada<EMAIL_ADDRESS>a écrit :

Hi @dglaude https://github.com/dglaude were you ever able to figure out
why this was happening?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver/issues/8#issuecomment-645685102,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEUJDHHM7I524VXPJSOASSDRXFJGJANCNFSM4KSFYM3A
.

I ran into something similar to what @dglaude mentions above.  I found a way around it, and maybe that hints to the issue.
I am using the bitmap save directly from the display.
Here is what I got initially, that shows a "streaky" error above the graphics:

I added a black bitmap background to the display behind the image and got this:

To me, it looks like if the display doesn't have any content (transparent?), then it repeats the pixel color values from the previous row.  That is a hint into what is going on.
Whenever the data is written into result_buffer from the display, if there is no Group, TileGrid or VectorIO object at that pixel location, then nothing gets overwritten, so the buffer is not updated in that location and the previous buffer value is retained at that pixel position.
The fundamental issue is in the CircuitPython displayio core functions for fill_area.  If an area isn't "owned" by a Group, TileGrid or VectorIO object, then nothing is written into the buffer with fill_area.

A quick fix inside of this library is to reinitialize the result_buffer to all zeros before each call to fill_area.  I added a single line:
result_buffer = bytearray(2048)

as the first line in the else statement.
Here's my updated code for _write_pixels in the file adafruit_bitmapsaver.py:
def _write_pixels(output_file, pixel_source, palette):
    saving_bitmap = isinstance(pixel_source, Bitmap)
    width, height = _rotated_height_and_width(pixel_source)
    row_buffer = bytearray(_bytes_per_row(width))
    result_buffer = bytearray(2048)
    for y in range(height, 0, -1):
        buffer_index = 0
        if saving_bitmap:
            for x in range(width):
                pixel = pixel_source[x, y - 1]
                color = palette[pixel]
                for _ in range(3):
                    row_buffer[buffer_index] = color & 0xFF
                    color >>= 8
                    buffer_index += 1
        else:
            result_buffer = bytearray(2048)
            data = pixel_source.fill_row(y - 1, result_buffer)
            for i in range(width):
                pixel565 = (data[i * 2] << 8) + data[i * 2 + 1]
                for b in _rgb565_to_bgr_tuple(pixel565):
                    row_buffer[buffer_index] = b & 0xFF
                    buffer_index += 1
        output_file.write(row_buffer)
        gc.collect()

Great, this issue is more than one year old and you found an explanation.

Solution was merged in: https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver/pull/14

Solution was merged in: #14

It appears that this issue should be closed as resolved from the previous comment.

@hugodahl Thanks
@kmatch98
closing


Removing class name in serializing an object

Hi,
I would like to minimize the data storage in Redis. When putting an Object in a list, I found that the object is serialized and stored in JSON. However, for every field in the json string, it has a class name info "java.lang.String" next a field for example.
Looking at the source code, https://github.com/redisson/redisson/blob/master/redisson/src/main/java/org/redisson/codec/JsonJacksonCodec.java#L140, realized that this is added by default. Passing my object mapper to initialize won't work either.
Is this necessary? Is there a way to disable this?
Alternatively, I serialized myself an object into a string and put the string into RList. However, then it seems the library serialize one extra time as follow:
from "\{\"stepId\":1}\" (application serialize) to "\"{\\\"stepId\\\":1}\"" (how it looks in Redis)

The class information is necessary for deserialising non-Jackson-annotated classes. If you want to safe space in Redis, please consider a different codec other than JSON based ones.

Thank you for your reply. In other words, does that mean the class names are unnecessary if all of my applications use Jackson annotation? Could you please recommend one which I can save space and fast?

Does that mean the class names are unnecessary if all of my applications use Jackson annotation?

No

Could you please recommend one which I can save space and fast?

Please refer to  this section in the wiki: https://github.com/redisson/redisson/wiki/4.-data-serialization
In general, binary codecs outputs are considered more concise than JSON structures. However each has its own problems while bringing in other features. i,e. compression codec can produce smaller result but in expense of some performance. You have to evaluate them yourself based on your own needs.

I'm unclear why this is a limitation. JsonTypeInfo is only needed for polymorphism. If I know the type I am reading into when deserializing, the additional @class property is redundant.


update machine driver exoscale TOC entry

Proposed changes
Update TOC entry in Machine docs for Exoscale driver to be initial caps on the side menu
Related issue
#46
Please take a look
@johndmulhausen @marcaurele
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

LGTM, tested locally

Thanks!


weex-loader cann't work with other webpack loaders elegantly

when I use webpack pack my weex file, I can only use weex-loader. if I need to use other webpack loaders, I must separate the weex file to tpl file, style file and javascript file, I don‘t think it's a good way to manage my modules, so would you support more elegantly

the weex-devtool can only support watch the changes about the weex file,when the saparated files changed, I must restart the debug serve,so the current way is not apply to debug on native。

https://github.com/weexteam/weex-loader/pull/6 solved

more discussions please go to https://github.com/weexteam/weex-loader/
thx


[NFC] Suppress warnings in third_party subprojects.

This PR adds clang & gcc options to suppress warnings when C/C++ code is compiled in the third_party subprojects.
In addition it fixes an issues in the Runtime onnx-mlir code.  Warnings continue to be emitted for C/C++ code in the onnx-mlir project proper.

Jenkins Linux ppc64le Build #1417 [push] Suppress warnings in thi... started at 14:27

Jenkins Linux ppc64le Build #1417 [push] Suppress warnings in thi... passed after 1 hr 20 min

Passing CI is necessary but not sufficient condition for merging, particularly for potentially controversial changes. When a PR generates a lot of discussions, it should only be merged after concerns from all parties are reasonably addressed, and alternatives suggested by others have been adequately considered.


Which 3D Visualization Tool/Code Do You use?

I'm wondering which visualization tool/code do you use to show those 3D textured meshes in this repo and in the paper? Could you please provide some sources/code/link? Thanks!!!

Most of the visualizations in the paper/repo were rendered using the script itself (e.g. you can modify the code that exports results to Tensorboard). In the repo you can also find the wireframe texture that was used to render the wireframe meshes: https://github.com/dariopavllo/convmesh/blob/master/mesh_templates/wireframe_16rings.png
Tips: render on a white background and at a higher resolution (e.g. 1024x1024 instead of 256x256), then resize the image to 256x256 for anti-aliasing.
Alternatively, you can export the generated meshes as .obj files and open/render them with Blender. The instructions are in the readme.

I was not aware of that feature of Tensorboard. For our visualizations during training, we simply render the meshes from random viewpoints using the renderer. This is done in the function that computes the FID.
It looks like that TensorBoard function doesn't support textures, only vertex colors. This might result in blurry results.


TreeView added

TreeView has been added by using the library vuejs-tree. Checkbox, add and delete functionalities are present.

Hey @adityagoel28, we'll have a conversation regarding the various things we need in this component. We'll take PR's only when the component is completely ready


OSError: Could not connect to socket

When creating a lot of clients, It seems that plasma can not connect all of them to the store. I got the following error:
File "pyarrow/_plasma.pyx", line 852, in pyarrow._plasma.connect
File "pyarrow/_plasma.pyx", line 288, in pyarrow._plasma.plasma_check_status
File "pyarrow/error.pxi", line 99, in pyarrow.lib.check_status
OSError: Could not connect to socket /scratch/tmp/11192359/test_plasma-mm2shz2g/plasma.sock

Could you open a JIRA issue and describe in more detail the scenario that leads to this error?


Exception when integrating into VS Code

Using<EMAIL_ADDRESS>

Interesting. I had pulled back on some of the error swallowing down at those levels which is probably what's causing this to pop up. I'm betting there's a font installed on your system that it doesn't like.
It's maps back here, which only throws if the font has no OS/2 table, which is required per the OpenType spec:
https://github.com/princjef/font-finder/blob/56f21b22a1524cabcec99fd009c414d2887ac9e9/src/tables/os2.ts#L51

There are probably lots of little issues like this that will crop up when fonts are structured a little bit differently than expected/specified. I'm not sure of a good way to guarantee safety without just ignoring fonts that error out for any reason. This would cause the stream.destroy() error from before to get swallowed again.

@Tyriar if you can drop a breakpoint in the js output for this line you should be able to at least see what file is causing the problem

Switched over to mac and I'm seeing it now. Looking into it

Yep there seem to be a few fonts in there that don't have any OS/2 table. I'll have to dig into why and what to do in that case, but for now I'll just have it skip those fonts because they're invalid anyway. It'll take a couple publishes to plumb it but I'll have a PR soon.
An example of one of the fonts on my mac that triggers it: /Library/Fonts/AppleGothic.ttf. It only has these tables:

cmap
cvt
fpgm
glyf
hdmx
head
hhea
hmtx
loca
maxp
meta
morx
name
post
prep
prop
vhea
vmtx

FYI currently looking into how to surface the correct information for these fonts via https://github.com/princjef/font-finder/issues/5. Once I have it I'll plumb it through separately.
These mac-specific fonts aren't a huge concern for this package because to my knowledge there aren't any platform-specific fonts supporting programming ligatures at the moment.

@princjef this seemed to be happening on all fonts on macOS (though it worked fine in the past). I tried "Hack" (no ligatures), "Hasklig" and "Fira Code"

@Tyriar yeah that's because to find the font that's being used I have to scan all of the system fonts until I find it. The font family name and the file name don't necessarily have to be correlated, so I have to parse parts of the font file to extract the name from it.
The issue popped up when I stopped swallowing certain types font loading errors. I had previously tested the font loading on mac, but hadn't noticed that a couple of the fonts were being skipped due to missing OS/2 tables. I had tested the newer code without exception swallowing on Windows and Linux (via WSL), but Mac has some different font rules it follows that caused the issue.
The deeper problem is that passing up errors opens up a certain level of risk to stability. Because I have to load all fonts to find the one being used, any font that is sufficiently malformed might cause the entire call to fail.


Application doesn't run on startup nor keep running in the background

Microsoft PowerToys version
0.79.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
Application doesn't run on startup nor keep running in the background when the PowerToys Settings window is closed consistently.
✔ Expected Behavior
With the "Run at startup" set to "On" that this would happen consistently.
When closing the PowerToys Settings window that the application would consistently remain running in the background.
❌ Actual Behavior
PowerToys only runs sometimes upon startup (I turn my computer off every weekday night and turn it on every weekday morning).
When I open the PowerToys Settings window, all the features work as expected, viz. Always On Top, Color Picker, and the Find My Mouse in the Mouse utilities; but once I close the PowerToys Settings window sometimes, these feature cease to function.
Other Software
No response

/bugreport


[Nativescript] Android Router Problem

hey,
i am just testing the nativescript app on an android device.
if i tab the About Button, the About Page is opened in a Modal.
when i hit the android back button, it flickers shortly, and then the About Page is opened again in the Modal and the console logs: JS: Language change: en.
So, no way of coming back home.
Besides that, the "About Page Modal" does not show the navigation directive nor the language chooser.
I tested it on two different devices.
any hint on that?

On things like this, I would recommend checking posted issues here as well as here. First see if it has been reported and then you may post an issue if you don't find one.

ok


Got OOM error when calculating the gt_unity_index_volume

Thanks for sharing your great work. The proposed loss is very valuable for my work.
But I always got the OOM error when calculating the gt_unity_index_volume. The shape of gt_index_volume: torch.Size([24, 118, 12, 40]) and depth_gt_volume size: torch.Size([24, 118, 12, 40]). Do you know what's the reason for this error? The batch size and depth channel are too big?
https://github.com/prstrive/UniMVSNet/blob/7c1c9862cc6f2eb0b74c0569d58826d9416195b5/loss.py#L67
gt_unity_index_volume[gt_index_volume] = 1.0 - (depth_gt_volume[gt_index_volume] - depth_values[gt_index_volume]) / interval
RuntimeError: CUDA out of memory. Tried to allocate 573.65 GiB (GPU 0; 39.59 GiB total capacity; 2.81 GiB already allocated; 16.61 GiB free; 3.42 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

Solved. It is caused by the data type issue.


Connection Loss Whenever Istiod Configmap is Updated

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Whenever I update my Istiod configmap, such as editing the accessLogFormat, my service pods suddenly lose connection to Redis and the database for 1 or 2 minutes. My cluster is relatively small, with only 4 services running Istio sidecars, but it's set up as a multi-master with 6 clusters joined in the mesh.
I tried to check istiod logs and sidecar but has no error log.
Version
$ istioctl version
client version: 1.18.1
control plane version: 1.18.2
data plane version: 1.18.2 (8 proxies)

$ kubectl version
Client Version: v1.29.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.7-gke.1026001

$ helm version --short
v3.14.3+gf03cc04

Additional Information
Helm chart istiod
pilot:
  autoscaleEnabled: true
  autoscaleMin: 1
  autoscaleMax: 5
  replicaCount: 1
  rollingMaxSurge: 100%
  rollingMaxUnavailable: 25%
  resources:
    requests:
      cpu: 500m
      memory: 2048Mi
  cpu:
    targetAverageUtilization: 80
  nodeSelector:
    cloud.google.com/gke-preemptible: "true"
  tolerations:
    - effect: NoSchedule
      key: cloud.google.com/gke-preemptible
      operator: Equal
      value: 'true'
  serviceAnnotations:
    prometheus.io/scrape: "true"
  deploymentLabels: {}
  configMap: true

sidecarInjectorWebhook:
  neverInjectSelector: []
  alwaysInjectSelector: []
  injectedAnnotations: {}
  enableNamespacesByDefault: false
  rewriteAppHTTPProbe: true
  templates: {}
  defaultTemplates: []

istiodRemote:
  injectionURL: ""
  injectionPath: "/inject"

telemetry:
  enabled: true
  v2:
    enabled: true
    metadataExchange:
      wasmEnabled: false
    prometheus:
      enabled: true
      wasmEnabled: false
      configOverride:
        gateway: {}
        inboundSidecar: {}
        outboundSidecar: {}
    stackdriver:
      enabled: false
    accessLogPolicy:
      enabled: false

meshConfig:
  accessLogEncoding: JSON
  accessLogFile: /dev/stdout
  accessLogFormat: |
      {
      "@timestamp": "%START_TIME%",
      "protocol": "%PROTOCOL%",
      "upstreamProtocol": "%UPSTREAM_PROTOCOL%",
      "method": "%REQ(:METHOD)%",
      "path": "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%",
      "responseCode": "%RESPONSE_CODE%",
      "duration": "%DURATION%",
      "responseCodeDetails": "%RESPONSE_CODE_DETAILS%",
      "connectionTerminationDetails": "%CONNECTION_TERMINATION_DETAILS%",
      "responseDuration": "%RESPONSE_DURATION%",
      "requestDuration": "%REQUEST_DURATION%",
      "requestTXDuration": "%REQUEST_TX_DURATION%",
      "responseTXDuration": "%RESPONSE_TX_DURATION%",
      "downstreamHandshakeDuration": "%DOWNSTREAM_HANDSHAKE_DURATION%",
      "upstreamName": "%UPSTREAM_CLUSTER%",
      "traceId": "%REQ(X-B3-Traceid)%",
      "XforwardedFor": "%REQ(X-Forwarded-For)%",
      "responseFlags": "%RESPONSE_FLAGS%",
      "routeName": "%ROUTE_NAME%",
      "downstreamRemoteAddress": "%DOWNSTREAM_REMOTE_ADDRESS%",
      "downstreamDirectRemoteAddress": "%DOWNSTREAM_DIRECT_REMOTE_ADDRESS%",
      "upstreamHost": "%UPSTREAM_HOST%",
      "upstreamLocalAddress": "%UPSTREAM_LOCAL_ADDRESS%",
      "upstreamRemoteAddress": "%UPSTREAM_REMOTE_ADDRESS%",
      "upstreamTransportFailureReason": "%UPSTREAM_TRANSPORT_FAILURE_REASON%",
      "downstreamTransportFailureReason": "%DOWNSTREAM_TRANSPORT_FAILURE_REASON%",
      "downstreamLocalURISan": "%DOWNSTREAM_LOCAL_URI_SAN%",
      "downstreamLocalAddress": "%DOWNSTREAM_LOCAL_ADDRESS%",
      "connectionId": "%CONNECTION_ID%",
      "streamId": "%STREAM_ID%",
      "requestHeaders": "%DYNAMIC_METADATA(envoy.lua:request_headers)%",
      "requestBody": "%DYNAMIC_METADATA(envoy.lua:request_body)%",
      "responseHeaders": "%DYNAMIC_METADATA(envoy.lua:response_headers)%",
      "responseBody": "%DYNAMIC_METADATA(envoy.lua:response_body)%",
      "requestAttempts": "%REQ(X-ENVOY-ATTEMPT-COUNT)%",
      "requestHeadersBytes": "%REQUEST_HEADERS_BYTES%",
      "responseHeadersBytes": "%RESPONSE_HEADERS_BYTES%",
      "responseTrailersBytes": "%RESPONSE_TRAILERS_BYTES%",
      "bytesReceived": "%BYTES_RECEIVED%",
      "bytesSent": "%BYTES_SENT%",
      "upstreamRequestAttemptCount": "%UPSTREAM_REQUEST_ATTEMPT_COUNT%",
      "upstreamWireBytesSent": "%UPSTREAM_WIRE_BYTES_SENT%",
      "upstreamWireBytesReceived": "%UPSTREAM_WIRE_BYTES_RECEIVED%",
      "upstreamHeaderBytesSent": "%UPSTREAM_HEADER_BYTES_SENT%",
      "upstreamHeaderBytesReceived": "%UPSTREAM_HEADER_BYTES_RECEIVED%",
      "downstreamWireBytesSent": "%DOWNSTREAM_WIRE_BYTES_SENT%",
      "downstreamWireBytesReceived": "%DOWNSTREAM_WIRE_BYTES_RECEIVED%",
      "downstreamHeaderBytesSent": "%DOWNSTREAM_HEADER_BYTES_SENT%",
      "downstreamHeaderBytesReceived": "%DOWNSTREAM_HEADER_BYTES_RECEIVED%"
      }
  ingressService: istio-ingress-gateway
  defaultConfig:
    proxyMetadata:
      ISTIO_META_DNS_CAPTURE: "true"
      ISTIO_META_DNS_AUTO_ALLOCATE: "true"
      EXIT_ON_ZERO_ACTIVE_CONNECTIONS: "true"
    terminationDrainDuration: 30s
  enablePrometheusMerge: true
  enableTracing: false
  enableAutoMtls: true
  rootNamespace: istio-system
  trustDomain: "cluster.local"
  defaultHttpRetryPolicy:
    retries:
      attempts: 0

global:
  istioNamespace: istio-system
  certSigners:
    - clusterissuers.cert-manager.io/cloud-dns-issuer
  defaultPodDisruptionBudget:
    enabled: false
  defaultResources:
    requests:
      cpu: 10m
  hub: gcr.io/istio-release
  tag: 1.18.2
  variant: ""
  imagePullPolicy: ""
  imagePullSecrets: []
  istiod:
    enableAnalysis: false
  logAsJson: false
  logging:
    level: "default:info"
  omitSidecarInjectorConfigMap: false
  oneNamespace: false
  operatorManageWebhooks: false
  priorityClassName: ""
  proxy:
    image: proxyv2
    autoInject: enabled
    clusterDomain: "cluster.local"
    componentLogLevel: "misc:error"
    enableCoreDump: false
    excludeInboundPorts: ""
    includeInboundPorts: "*"
    includeIPRanges: "*"
    excludeIPRanges: ""
    includeOutboundPorts: ""
    excludeOutboundPorts: "15090"
    logLevel: warning
    privileged: false
    readinessFailureThreshold: 30
    readinessInitialDelaySeconds: 1
    readinessPeriodSeconds: 2
    resources:
      requests: null
      limits: null
    statusPort: 15020
    tracer: "zipkin"
    holdApplicationUntilProxyStarts: false
  tracer:
    zipkin:
      address: <zipkin_address>
  proxy_init:
    image: proxyv2
  remotePilotAddress: ""
  caAddress: istiod.istio-system.svc:15012
  externalIstiod: false
  configCluster: true
  jwtPolicy: "third-party-jwt"
  meshID: "<mesh_id>"
  mountMtlsCerts: true
  multiCluster:
    enabled: true
    clusterName: "<mycluster>"
  network: "<mycluster_network>"
  pilotCertProvider: istiod
  sds:
    token:
      aud: istio-ca
  useMCP: false
  caName: ""
  autoscalingv2API: true
base:
  enableIstioConfigCRDs: true
  validateGateway: false

Maybe related to https://github.com/istio/istio/issues/48305 which has solid explanation for why connections get dropped during this type of update.

I see that’s most likely the case. I hope there’s documentation on which configurations trigger the listeners reset and which ones do not. So we can be better prepared if any connection terminations occur.


Add a class to an attribute..

	companyId: orion.attribute('hasOne',
		label: 'Company'
	,
		collection: Company
		titleField: 'title'
		publicationName: 'hasOneCompany'
	)

I have a HasOne relationship linking to a Company.  This results in a dropdown like so

The company here is called "oneLife"...  i want to add a class "active" to  the input field..  Can i add a class to the schema?

We are waiting here
https://github.com/djhi/meteor-autoform-materialize/issues/18

This is fixed now at source?


OpenAPIWorkspace

This PR contains a new OpenApiWorkspace class that is used to hold a set of OpenAPI documents, fragments and artifacts that reference each other.
This PR contains the object model and provides ResolveReference methods that will resolve references from the OpenApiWorkspace.
This is only a partial solution.  Additional work needs to be done on the OpenApiWorkspaceLoader to provide a way to automatically read referenced documents and load them in the the workspace when referenced.

The following code will load a stream into an OpenApiDocument and all related documents will be loaded into a common OpenApiWorkspace.
            var reader = new OpenApiStreamReader(new OpenApiReaderSettings()
            {
                ReferenceResolution = ReferenceResolutionSetting.ResolveAllReferences
            });

            var result = await reader.ReadAsync(stream);


staging build: fetch all commits

The staging build is using dynamic versioning, but not setting the version correctly:

I'm guessing that's because GH actions only fetches the latest commit by default. So lets fix that!
(see https://github.com/actions/checkout#checkout-v3 )

Coverage: 86.609%. Remained the same when pulling c981bd752557299160e092e0c07994e6659a4dac on staging-dynamic-version into 2a354c0ffef22497c984e9336f1d6b486a807ac0 on main.


on CNN Data set

Could you let me know that the results would look like when you use the CNN Dataset instead ? If there are pre-trained models for it, please let me know

Hi, I haven't trained the model with CNN dataset :(


Firefox loose the value on focusout

Step to reproduce:

Open the live demo in Firefox
Type seven
Select the value in the combobox -> Model: { "num": "seven" }
Click elsewhere on the page -> Model: "seven"

I'm having the same issue, have you found any work arounds yet?


#Test is important and often left out due to budgetery/time constraint reasons

@mai-soup I'm a big fan of good testing. Meaning

Not a = b test
Test for bugs, edge cases, and some standard flows
Any tests at all

With your current code base it might not yet seem relevant. But I've experienced projects with 10.000 and more lines of code scattered across domains, where u hardly able to understand anything. Especially in bigger projects and bigger teams, it saves a lot of nerve, time, and money on the de long run. I guess this is something u have to experience on your own to truly understand. Just want to mention it though 😆

What does "Not a = b test" mean?
But yeah, I agree on the importance. Along with more refactoring, it's one of the to-do items for the next week or two. As you said, less headaches in De Long run :laughing:

Achieved 80%+ coverage over the last couple weeks (#127), will consider this completed for now (though, obviously more to test)


[DISSCUSS] Use github disscussion to ask and answer questions

Issue is designed for the bug tracker, not the questions. We should migrate question discussion to a specific place. GitHub discussion is a collaborative communication forum for the community. It's a better place for communication and announcement. See Homebrew for example.
cc @RongtongJin @aaron-ai @lollipopjin @zhouxinyu @lizhanhui

@ShadowySpirits Nice proposal!
I created a jira ticket to track this issue: https://issues.apache.org/jira/browse/INFRA-24021.

GitHub discuss has been enabled.

GitHub disscussion has been enabled.

How about adding a pined issue to announce this and guide users to ask questions in GitHub discussion?

GitHub disscussion has been enabled.

How about adding a pined issue to announce this and guide users to ask questions in GitHub discussion?

Good idea!


Add GHIssue, GHLabel, GHMilestone and extend GHRepo

Yet another step at making the GH API more general-purpose (more PRs to come)
This basically just adds more type serialization.

Question, what happens when a field is added by GitHub? Will it just not be deserialized?

Will it just not be deserialized?

Yep as currently (we only parse about half of the payload).

Merging as this just adds improves out GH API mapping and brings us one step closer to a extracting github_api into a separate package ;-)

BTW I reviewed the code a couple of weeks ago, don't know what happened with my approval. Probably lost in the > 300 open tabs I have on my PC and phone combined :D


Use all defined environment variables.

The current version only read a subset of environment variable.
This leads to this issue: https://github.com/vapor/toolbox/issues/109
Using all the defined environment variables solves the issue.
A similar PR has been done on the `swift-package-manager': https://github.com/apple/swift-package-manager/pull/400

Current coverage is 7.41% (diff: 0.00%)

Merging #24 into master will increase coverage by 4.36%

@@            master       #24   diff @@
========================================
  Files           28        30     +2
  Lines          690       715    +25
  Methods          0         0
  Messages         0         0
  Branches         0         0
========================================
+ Hits            21        53    +32
+ Misses         669       662     -7
  Partials         0         0

Powered by Codecov. Last update 2bb03a0...b40d059

@yageek looking into this today 👍

Makes sense. The code originally came from SPM.

@tannernelson I'm good w/ this, you go for merge?


Admin can upload a group picture.

Currently the group photo is just Enspiral by default.

Related to group settings (no ticket yet).


User creation failure seen in test due to race condition

In addition to the failed test, this could potentially manifest itself as an error seen in the UI or API when trying create local users.
 If the controller goes firest, when the store calls it, the calls to create the bindings will fail.
Fix should be simply to check for and ignore alreadyExists errors in that function

@dramich your cluster eject feature is still more important than this one. Between you and me, whoever gets to it first can fix it.

This was only observed in the integration tests, but if it could be reproduced, it would be on the create user page. You would see that page return an error upon user creation