DateTime component not showing the active date when using onPush as ChangeDetectionStrategy

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x ] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ x ] bug report
[ ] feature request
Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When a component is using OnPush as a change detection strategy, the default value of the DateTime component is not showing until the user chooses another date
Expected behavior:
When a component is using OnPush as a change detection strategy, the default value of the DateTime component should be shown immediately without having the user to choose another date
Steps to reproduce:
Check attached stackblitz link
Related code:
https://stackblitz.com/edit/ionic-oxa8ss
The code change is done in home.ts and home.html

Hello! Thank you for opening an issue with us!
I have marked this as something to have a look at after the initial Ionic v4 release.
Thank you for using Ionic


Remove all usage of dynamic_cast<>

Hi,
This removes usage of dynamic_cast from the library.
As all the nodes already hold E57 type information, we don't need to rely on RTTI. dynamic_cast<> is much slower (especially on MSVC) than custom simple type checks as it must be much more generic. Moreover, there are already those checks in place so usage of dynamic_cast<> is redundant.
This also fixes a couple of warnings reported when compiling with Xcode.
I have formatted the changes with the new .clang-format style.
Cheers,
Jiri

Jiri Hörner
Software Development Engineer, Vuforia
<EMAIL_ADDRESS>vuforia.com

Parametric Technology Gesellschaft m.b.H., Operngasse 17-21, 1040 Wien, Austria. Firmensitz: Wien, FN: 111171 m, Firmenbuchgericht: Handelsgericht Wien.
The information contained in this email transmission is confidential and may be privileged. If you are not the intended recipient, any use, dissemination, distribution, publication, or copying of the information contained in this email is strictly prohibited.  If you have received this email in error, please immediately notify me by calling the above number and delete the email from your system. Thank you for your co-operation.
Copyright © 2020 PTC Inc. and/or all its affiliates or subsidiaries. All rights reserved

Thank you for your contribution!


Add tutorial pages to Wiki tab

We have some resqpy tutorial pages on the internal bp Wiki – these can be transferred with minor edits to the Wiki tab of this github project.

@connortann Despite our discussion where we agreed to focus on readthedocs for resqpy  documentation, I've decided to port the tutorial pages to the github Wiki tab as it is so quick to do.

@andy-beer I think there may actually be an automated solution to convert from MediaWiki to RST, which should make this process a lot easier: https://pandoc.org/
I tested out the online demo converter, it seems to work well - although the web demo has a character limit, so suggest we use the command line tool.

I shall post to my team to see if someone would like to get involved and help out!

i can try picking this up - any tips on getting clean html data from wiki pages?

On Wiki pages, try clicking "edit" and then use the plaintext editor. This will enable to you grab nice and clean wikimarkup.

See merged #51


[change] aria2: allow entry setting set

Motivation for changes:
Allow the use of path and filename from the entry to set into aria2
Detailed changes:

added the mapping of entry 'path' to aria2 options
added the mapping of entry 'filename' to aria2 optioss
added the option to retrieve the file extension from a url and append to the filename

Config usage if relevant (new plugin or updated schema):
  test_aria2:
    set:
      path: "/home/downloader/test"
      filename: "{{movie_name}}_new"

    aria2:
      server: test
      secret: my_secrep
      path: /home/downloader/

I think this is still waiting on those couple changes I commented earlier on?

@soloam I'd use aria2 over transmission so I'm willing to get this working sooner than later. Do you have examples of sites which are returning 404 on HEAD requests? Everything I've tested works so far, but I might just have a smaller pool of types sites I'm visiting.
@gazpachoking I have a working version based on requests.head though I would want to get more tests in from soloam's 404'ing head requests. I can easily implement the body-content-workflow fix if needed, but I've yet to encounter the 404 error.

@stranger-danger-zamu I started using aria2 more now and was planning on closing this issue to wrap up all the changes (at the moment I'm using a custom plugin that is the version on my repo, but changed the name to aria2x).
I'll review this PR and improve it so that it can be closed.
The 404 errors that I sometimes get are very sporadic, and strange, because sometimes I get the error, and if I call it gain it works. I'm going to change the code to use "get" to see if it improves! And probably the plugin should fail the entry if it's not able to return the file header (and it's required). So that the entry could be retried in a latter run!

I did the changes and the PR is ready to approval! All is working using the task get, that should work with plugins like the ignore certificates!

I added the ability to set the extension by entry property.
The config could be:
Get Extension from the original file and add it to the new name
    aria2:
      server: "<< server >>"
      secret: "<< secret >>"
      path: "<< download folder>>"
      add_extension: yes
      filename: my_name

Force the extension to mkv
    aria2:
      server: "<< server >>"
      secret: "<< secret >>"
      path: "<< download folder>>"
      add_extension: mkv
      filename: my_name

Force the extension to mkv with set

    set:
      content_extension: "mkv"

    aria2:
      server: "<< server >>"
      secret: "<< secret >>"
      path: "<< download folder>>"
      filename: my_name

I would definitely change that name from add_extension/set_extension to something more explicit or spin that type of functionality out to something else (eg. a proper MIME type post processing step).

Please explain better, or talk with me in discord!
I can change the name of the property, but I don't understand what you mean by change the functionality!
I would avoid adding more functionality to this PR. It will only delay further the merge.

Ah, I meant moving the extension manipulation out of this. I would only have this download entry that it gets. Something else (like a different component/plugin/etc) should deal with the extension manipulation. Separation of responsibilities and concerns.

Pulling the extension from the file is a must have. Most of the link's to download are coded, and provide little to no information regarding the file name or file type! The download plugin should be able to rename the file, and to do that it needs to pull the extension so that it's able to rename it and keep it's extension!

@gazpachoking any comments on this?

LGTM, thanks!


Properly return salt of argon2 hashes in decode/safe_summary.

Argon2 encodes the salt as base64 for representation in the final hash
output. To be able to accurately return the used salt from decode we
now b64decode it and decode from latin1 (for the remote possibility that
someone supplied a custom hash consisting solely of bytes -- this would
require a manual construction of the hash though, Django's interface
does not allow for that).
I ran into this while working on #12553 just now.

I have pushed a followup commit which uses decode in must_update like the other hashers do. This will give #12553 access to the needed salt then.


Fix print issues with py3

and also add the sample data downloading to tox.

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #43   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           4      4
  Lines          50     50
=====================================
  Hits           50     50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640eaed...2443fd0. Read the comment docs.

Thank you very much @luizirber!


Cannot add image

Hello, thank you for your feedback. What were your steps? I just tried methods like copy and paste, dragging and dropping to add images, and found that the functions are working properly.

I click on the image button (9), drag where to place the image, but no picker is shown.
I'm on Sonoma 14.4.1 MacBook Pro M1

Hello, @nank1ro. The new alpha test version of ExcalidrawZ has fixed this issue. You can download here or you can wait for the formal version.
Don't forget to achive your files before you updating to the alpha version

here

Yep, it worked perfectly.
Thank you so much 🙏
Feel free to close it


Custom Metrics in Metrics UI

Summary of the problem (If there are multiple problems or use cases, prioritize them)
Multiple users have expressed the need to add custom links to resources on inventory, specifically attaching a dashboard, or adding a reference to another page. We already provide custom links in APM, Security apps, but there's no such capability in Metrics UI.
User stories
As an admin, I want to be able to link to other sources from Metrics UI, so that i didn't have to manually keep an inventory of related URLs that could help me with my troubleshooting workflows.

Related issue: https://github.com/elastic/kibana/issues/21884

This could be part of the node details enhancement. The context menu is maybe going to be replaced by a flyout.
Do we have any data on the usage of this feature in APM?


Fix adding/dropping columns with Oracle

This PR addresses https://github.com/brianc/node-sql/issues/332 by changing the way the SQL statement is generated when adding/dropping tables using the Oracle dialect.

Thanks a lot for your work on this!  Sorry it took me a while to get to it - life got in the way & I got really busy tending to some things.  I'll merge this now & push a new minor version to npm here in just a few minutes. ❤


Dark Mage Exdeath build issue

It seems like Exdeath's lvl 101 equip robe passive doesn't work, not sure if it's recent or was always the case
It is listed in his skills though

       if (this.unit.enhancements) {             this.unit.enhancements.forEach(skill => {                 if (skill.allowUseOf && (!skill.levelCondition || skill.levelCondition <= this._level)) {                     skill.allowUseOf.forEach(a => {                         if (!equip.includes(a)) {                             equip.push(a);
code looks like it's already written. it's just inside a block that, if i'm reading it correctly, excludes ex death's unique "allow use of" skill, since it's not an enhancement.
starts at static/builder/unitBuild.js, line 192.

more babbling and prodding for this one.
function getEquip(equipIn) {
    var equip = [];
    for(var equipIndex in equipIn) {
        if (equipIn[equipIndex] != 60) {
            equip.push(typeMap[equipIn[equipIndex]]);
        }
    }
    return equip;
}

if i understand this correctly, it's grabbing the unit's equipable items list from aenigma, and pushing every type except for accessories into an array.
looking at DM ExDeath's equip robes passive (passive5: [1.3] [53]), and how the builder is currently treating it, i'm getting the feeling that the passive needs to be able to push the equip type to the equipIndex.
currently, the passive works for manually equipping a robe, but the builder is not considering them at all when auto-building. block the armor types he can equip before gaining the passive, and it leaves the armor slot blank.
there's this,
            if (effect.allowUseOf) {
                if (!effectList[0].allowUseOf) {
                    effectList[0].allowUseOf = [];
                }
                for (var i = 0, len = effect.allowUseOf.length; i < len; i++) {
                    if (!effectList[0].allowUseOf.includes(effect.allowUseOf[i])) {
                        effectList[0].allowUseOf.push(effect.allowUseOf[i])
                    }
                }
            }

and this,
    // allow use of
    else if (rawEffect[2] == 5) {
        result.allowUseOf = rawEffect[3].map(n => typeMap[n]);
        return [result];
    }

but i don't see where either of them affects the equipIndex to add the item to auto-building.
i don't know why i'm picking on this, when there are other things to pick on. curiosity, probably, since it's unique. but exdeath is probably a bench warmer at this point.

This issue also applies to Veritas of the Dark's ability to Equip Guns when he is awakened to NV level


PHPUnit testing for invalid arguments in ScanService scan and index()

If this is an invalid argument it will work on lover php versions < 7 but not on php >= 7.0. This should be fixed. The test is now commented out.

This issue is now clossed.


iter-err: add ForEachErr and ForEachIdxErr

Adding error returning iterators

Fixed linter issues

Codecov Report

Merging #104 (8bde958) into main (8e5ba59) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   99.30%   99.36%   +0.05%
==========================================
  Files          12       12
  Lines         433      474      +41
==========================================
+ Hits          430      471      +41
  Misses          3        3

Impacted Files
Coverage Δ

iter/iter.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

We should probably make Mapper respect the FailFast flag as well since we already have a MapErr and we don't want that to have different behavior.

Is this still on the radar?

Yeah, I will refine the pr


RDSInstance can't get into Sync=True state with an warning  'api error InvalidParameterCombination: No modifications were requested'

What happened?
RDSInstance MR can't get into SYNC=True state
This issue might be related to: #1795
How can we reproduce it?
I have below RDS Instance MR
apiVersion: database.aws.crossplane.io/v1beta1
kind: RDSInstance
metadata:
  annotations:
    crossplane.io/composition-resource-name: rds
    crossplane.io/external-name: us1-ekswac001-rdswac001
  creationTimestamp: "2023-03-23T14:43:16Z"
  finalizers:
  - finalizer.managedresource.crossplane.io
  generateName: wac-ekswac001-rdswac001-
  generation: 129675
  labels:
    crossplane.io/claim-name: ekswac001-rdswac001
    crossplane.io/claim-namespace: wac
    crossplane.io/composite: ekswac001-rdswac001-4tshm
  name: wac-ekswac001-rdswac001-h58tx
  ownerReferences:
  - apiVersion: rds.aws.crossplane.sinch.com/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: XMySQLInstance
    name: ekswac001-rdswac001-4tshm
    uid: a8211232-ea1e-429e-b477-ebfbecc20058
  resourceVersion: "446399353"
  uid: 05a94c62-ddaf-4ee7-b885-a3704f782091
spec:
  deletionPolicy: Orphan
  forProvider:
    allocatedStorage: 333
    applyModificationsImmediately: false
    autoMinorVersionUpgrade: true
    availabilityZone: us-east-1a
    backupRetentionPeriod: 1
    caCertificateIdentifier: rds-ca-2019
    copyTagsToSnapshot: true
    dbInstanceClass: db.r5.4xlarge
    dbName: db
    dbParameterGroupName: rdswac001-db-parameter-group
    dbSubnetGroupName: private_subnets_vpc-xxx
    deletionProtection: false
    enableCloudwatchLogsExports:
    - audit
    enableIAMDatabaseAuthentication: false
    enablePerformanceInsights: true
    engine: mysql
    engineVersion: 5.7.38
    kmsKeyId: 6a1a9e12-xxx-xxx-xxx-xxx
    licenseModel: general-public-license
    masterPasswordSecretRef:
      key: password
      name: ekswac001-rdswac001-master-password
      namespace: wac
    masterUsername: root
    maxAllocatedStorage: 1000
    monitoringInterval: 60
    monitoringRoleArn: arn:aws:iam::xxx:role/rds-monitoring-role
    multiAZ: true
    optionGroupName: sinch-default-mysql-5-7
    performanceInsightsKMSKeyId: arn:aws:kms:us-east-1:xxx:key/6a1a9e12-xxx-xxx-xxx-xxx
    performanceInsightsRetentionPeriod: 7
    port: 3306
    preferredBackupWindow: 14:00-16:00
    preferredMaintenanceWindow: mon:02:30-mon:03:00
    publiclyAccessible: false
    region: us-east-1
    skipFinalSnapshotBeforeDeletion: true
    storageEncrypted: true
    storageType: gp2
    tags:
    - key: crossplane-kind
      value: rdsinstance.database.aws.crossplane.io
    - key: crossplane-name
      value: wac-ekswac001-rdswac001-h58tx
    - key: crossplane-providerconfig
      value: crossplane-provider-aws
    vpcSecurityGroupIds:
    - sg-0fxxx
    - sg-09xxx
  providerConfigRef:
    name: crossplane-provider-aws
  publishConnectionDetailsTo:
    configRef:
      name: default
    metadata:
      labels:
        secret.crossplane.io/owner-uid: 05a94c62-ddaf-4ee7-b885-a3704f782091
    name: wac-ekswac001-rdswac001-rdsinstance
status:
  atProvider:
    allocatedStorage: 333
    backupRetentionPeriod: 1
    dbInstanceArn: arn:aws:rds:us-east-1:xxx:db:us1-ekswac001-rdswac001
    dbInstanceStatus: available
    dbParameterGroups:
    - dbParameterGroupName: rdswac001-db-parameter-group
      parameterApplyStatus: in-sync
    dbResourceId: db-xxx
    dbSubnetGroup:
      dbSubnetGroupDescription: This is a private subnet group for AWS RDS instances.
        Only containing our regular private subnets in vpc-xxx
      dbSubnetGroupName: private_subnets_vpc-xxx
      subnetGroupStatus: Complete
      subnets:
      - subnetAvailabilityZone:
          name: us-east-1c
        subnetIdentifier: subnet-5xxx
        subnetStatus: Active
      - subnetAvailabilityZone:
          name: us-east-1b
        subnetIdentifier: subnet-0xxx
        subnetStatus: Active
      - subnetAvailabilityZone:
          name: us-east-1a
        subnetIdentifier: subnet-exxx
        subnetStatus: Active
      vpcId: vpc-xxx
    endpoint:
      address: us1-ekswac001-rdswac001.xxx.us-east-1.rds.amazonaws.com
      hostedZoneId: Z2R2ITUGPM61AM
      port: 3306
    enhancedMonitoringResourceArn: arn:aws:logs:us-east-1:xxx:log-group:RDSOSMetrics:log-stream:db-xxx
    instanceCreateTime: "2022-08-04T06:34:53Z"
    latestRestorableTime: "2023-08-30T11:00:00Z"
    optionGroupMemberships:
    - optionGroupName: sinch-default-mysql-5-7
      status: in-sync
    pendingModifiedValues:
      pendingCloudwatchLogsExports: {}
    performanceInsightsEnabled: true
    secondaryAvailabilityZone: us-east-1c
    vpcSecurityGroups:
    - status: active
      vpcSecurityGroupId: sg-0fxxx
    - status: active
      vpcSecurityGroupId: sg-09xxx
  conditions:
  - lastTransitionTime: "2023-07-18T04:28:07Z"
    message: 'update failed: cannot modify RDS instance: api error InvalidParameterCombination:
      No modifications were requested'
    reason: ReconcileError
    status: "False"
    type: Synced
  - lastTransitionTime: "2023-06-02T06:06:53Z"
    reason: Available
    status: "True"
    type: Ready

I get an event cannot modify RDS instance: api error InvalidParameterCombination: No modifications were requested:
kubectl describe rdsinstances.database.aws.crossplane.io wac-ekswac001-rdswac001-h58tx
Events:
  Type     Reason                        Age                    From                                            Message
  ----     ------                        ----                   ----                                            -------
  Warning  CannotUpdateExternalResource  79s (x9917 over 3d1h)  managed/rdsinstance.database.aws.crossplane.io  cannot modify RDS instance: api error InvalidParameterCombination: No modifications were requested

In AWS CloudTrail I can see:
    "errorCode": "InvalidParameterCombinationException",
    "errorMessage": "No modifications were requested",
    "requestParameters": {
        "allowMajorVersionUpgrade": false,
        "dBInstanceIdentifier": "us1-ekswac001-rdswac001",
        "applyImmediately": false
    },

Provider Logs
kubectl logs -n crossplane-system pod/crossplane-provider-aws-447dacb385f5-d6f4645df-6rqfx

{"level":"info","ts":"2023-09-04T09:53:00.064Z","logger":"provider-aws","msg":"Alpha feature enabled","flag":"EnableAlphaExternalSecretStores"}
Setup endpointgroup
W0904 09:53:00.918953       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 09:53:00.920521       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
[controller-runtime] log.SetLogger(...) was never called, logs will not be displayed:
goroutine 3936 [running]:
runtime/debug.Stack()
        runtime/debug/stack.go:24 +0x65
sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
        sigs.k8s.io/controller-runtime@v0.15.0/pkg/log/log.go:59 +0xbd
sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithValues(0xc0008d2080, {0xc0065effa0, 0x2, 0x2})
        sigs.k8s.io/controller-runtime@v0.15.0/pkg/log/deleg.go:168 +0x54
github.com/go-logr/logr.Logger.WithValues(...)
        github.com/go-logr/logr@v1.2.4/logr.go:323
sigs.k8s.io/controller-runtime/pkg/builder.(*Builder).doController.func1(0xc0065eff80)
        sigs.k8s.io/controller-runtime@v0.15.0/pkg/builder/controller.go:398 +0x182
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0005fbf40, {0x749d9a0, 0xc0004b9700}, {0x625de60?, 0xc0065eff60?})
        sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:305 +0x1b9
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0005fbf40, {0x749d9a0, 0xc0004b9700})
        sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265 +0x1d9
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
        sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226 +0x85
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2
        sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:222 +0x333
W0904 10:02:47.922518       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:07:48.924422       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:12:54.926296       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:19:22.928934       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:26:00.932433       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:32:34.934234       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:38:29.935659       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:45:13.940025       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:52:38.941015       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 10:59:48.944220       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 11:09:45.946386       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 11:16:10.949184       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 11:26:01.952099       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 11:32:02.953704       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 11:41:57.955356       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 11:47:20.957188       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 11:53:46.958749       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:01:47.962187       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:09:17.964217       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:16:02.967047       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:22:45.968958       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:27:48.970744       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:34:03.973531       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:41:08.975225       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.
W0904 12:48:53.978472       1 warnings.go:70] BucketPolicy has been deprecated. Use spec.forProvider.policy in Bucket instead.

What environment did it happen in?
Crossplane version: 1.13.2
provider-aws: 0.43.0

I seem to hit into similar issue on multiAZ setup. For some reason, the availabilityZone will be populated with some default value e.g. us-east-1a. but backend was trying to creating db in us-east-1b.
As for multiAZ setup with true, should we not populating the availabilityZone with any value at all?
RDS API doc mention about leaving this param as empty: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html

We have the same Issue. Crossplane constantly tries to modify the RDSInstance after creation when the Availability Zone changes on the AWS Side (e.g. Failover or stop/starting the Instance). The RDSInstance is configured as Multi AZ


HUB-853 add welsh translation to IDP warning page

Adds welsh warning text to the IDP warning page for decommissioning IDPs.

Weirdly unable to test locally - so don't review until tests pass.

✅ John's right the build completed ok - safe to review!


Add WY script to sum cumulative values when new outbreaks open

Still verifying everything, but I think this is it

The test is failing on circleci (and not my local machine just yet) because it's now Thursday in UTC, which means it's expecting a row 20210225 when filling in missing dates. I'll fix it for this week, and then we should comment out that test eventually since it seems like it will break on a weekly basis.


Hi,

Hi,
Last time I encountered an error, I found that it was about GPU memory. So I changed a GPU to TitanXP and solve it, but this time I got a "std::bad_alloc", was it because I didn't have enough memory? (32G)

Can you provide more details regarding the error? It shouldn't use that many memory.


nested-data-reporting-plugin no longer works when updating echarts-api plugin from 5.4.0-3 to 5.4.0-4

Jenkins and plugins versions report

Environment

Jenkins v2.387.3, nested-data-reporting-plugin v5.2.1, echarts-api plugin 5.4.0-4

What Operating System are you using (both controller, and any agents involved in the problem)?
any
Reproduction steps
update echarts-api plugin from 5.4.0-3 to 5.4.0-4
Expected Results
nested-data-reporting-plugin must display trend graph
Actual Results
nested-data-reporting-plugin no longer works
Anything else?
Trend graph are no longer displayed.
Jobs using Nested Data Reporting plugin, are loaded with the following warning :
WARNING hudson.model.Run#onLoad: failed to load io.jenkins.plugins.reporter.ReportAction@1415692a from C:\Jenkins\jobs\test\jobs\test-nested-data-report\builds\10\build.xml
java.lang.NullPointerException
Jobs using Nested Data Reporting plugin, fails to run with the following error :
java.lang.ClassNotFoundException: org.eclipse.collections.impl.factory.Sets
Could you fix this problem, please?
Thanks in advance

which version of plugin are you using? (official release or last commit)?
Which version of jenkins?
I confirm this issue but i don't know if it comes from jenkins 3.400 or from plugin

I have these informations -
This merge might solve the problem
Bump echarts-api from 5.4.0-3 to 5.4.0-4 #196
Need some tests with hpi version and release 5.2.2 in case of test is ok

Test with following hpi
https://ci.jenkins.io/job/Plugins/job/nested-data-reporting-plugin/job/master/

I tested, the latest master works. Needs to make a new release.
Unfortunately, historic graph seems to be lost

#196 caused some removed dependencies un echart plugin. Missing dependencies were added to this plugin. Issue is correcte


Unable to nvm install

Any ideas why?
~/dir-with-nvmrc> nvm install
N/A version is not installed yet
~/dir-with-nvmrc> nvm install 4.2.3
N/A version is not installed yet

.nvmrc has the following contents:
4.2.3

If I run the nvm install 4.2.3 outside of the dir that has the .nvmrc then installation proceeds normally.

@jeromecovington does nvm use work inside the directory? What shell are you using, and what does nvm debug print out?

Hi @ljharb - yes nvm use does work inside the directory, once the install step has succeeded.
I am using...dum da da dum...the fish shell, with the nvm fish wrapper (need to transition my setup to bass).
Here's the output of nvm debug:
> nvm debug

Node Version Manager

Usage:
  nvm help                              Show this message
  nvm --version                         Print out the latest released version of nvm
  nvm install [-s] <version>            Download and install a <version>, [-s] from source. Uses .nvmrc if available
  nvm uninstall <version>               Uninstall a version
  nvm use <version>                     Modify PATH to use <version>. Uses .nvmrc if available
  nvm run <version> [<args>]            Run <version> with <args> as arguments. Uses .nvmrc if available for <version>
  nvm current                           Display currently activated version
  nvm ls                                List installed versions
  nvm ls <version>                      List versions matching a given description
  nvm ls-remote                         List remote versions available for install
  nvm deactivate                        Undo effects of `nvm` on current shell
  nvm alias [<pattern>]                 Show all aliases beginning with <pattern>
  nvm alias <name> <version>            Set an alias named <name> pointing to <version>
  nvm unalias <name>                    Deletes the alias named <name>
  nvm reinstall-packages <version>      Reinstall global `npm` packages contained in <version> to current version
  nvm unload                            Unload `nvm` from shell
  nvm which [<version>]                 Display path to installed node version. Uses .nvmrc if available

Example:
  nvm install v0.10.32                  Install a specific version number
  nvm use 0.10                          Use the latest available 0.10.x release
  nvm run 0.10.32 app.js                Run app.js using node v0.10.32
  nvm exec 0.10.32 node app.js          Run `node app.js` with the PATH pointing to node v0.10.32
  nvm alias default 0.10.32             Set default node version on a shell

Note:
  to remove, delete, or uninstall nvm - just remove ~/.nvm, ~/.npm, and ~/.bower folders

aha - i'd file an issue on the fish wrapper, since nvm doesn't work in fish :-/ it's entirely likely there's some issue with nvm ls-remote in fish that doesn't crop up with other code paths.

@jeromecovington You can use bass, which is BTW nvm-agnostic and can reuse with other bash utilities you may be used to. Basically you create a function to wrap nvm and add  it to your config or wherever you keep your dotfiles / functions.


dbt-oracle 1.3.1 problem "oracle adapter: Oracle error: ORA-00972: identifier is too long" on dbt snapshot

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Same project:
dbt-oracle 1.3.0 Works fine
root@new-airflow-dbt:~/airflow/dags/SALES_ORDERS_MANAGEMENT/snapshots# dbt snapshot
05:54:07  oracle adapter: Running in cx mode
05:54:08  Running with dbt=1.3.0
05:54:08  Found 1 model, 0 tests, 3 snapshots, 0 analyses, 324 macros, 2 operations, 0 seed files, 15 sources, 0 exposures, 0 metrics
05:54:08
05:54:08
05:54:08  Running 1 on-run-start hook
05:54:08  1 of 1 START hook: dbt_project.on-run-start.0 .................................. [RUN]
05:54:08  1 of 1 OK hook: dbt_project.on-run-start.0 ..................................... [OK in 0.00s]
05:54:08
05:54:08  Concurrency: 8 threads (target='prod')
05:54:08
05:54:08  1 of 3 START snapshot psofa.sales_orders ....................................... [RUN]
05:54:08  2 of 3 START snapshot psofa.sales_orders_appog ................................. [RUN]
05:54:08  3 of 3 START snapshot psofa.uniters_orders ..................................... [RUN]
05:54:14  1 of 3 OK snapshotted psofa.sales_orders ....................................... [OK in 5.32s]
05:54:14  2 of 3 OK snapshotted psofa.sales_orders_appog ................................. [OK in 5.90s]
05:54:22  3 of 3 OK snapshotted psofa.uniters_orders ..................................... [OK in 13.28s]
05:54:22
05:54:22  Running 1 on-run-end hook
05:54:22  1 of 1 START hook: dbt_project.on-run-end.0 .................................... [RUN]
05:54:22  1 of 1 OK hook: dbt_project.on-run-end.0 ....................................... [OK in 0.00s]
05:54:22
05:54:22
05:54:22  Finished running 3 snapshots, 2 hooks in 0 hours 0 minutes and 14.15 seconds (14.15s).
05:54:22
05:54:22  Completed successfully
05:54:22
05:54:22  Done. PASS=3 WARN=0 ERROR=0 SKIP=0 TOTAL=3```

dbt-oracle 1.3.1 gives the following output:

root@new-airflow-dbt:~/airflow/dags/SALES_ORDERS_MANAGEMENT/snapshots# dbt snapshot
05:43:33  oracle adapter: Running in cx mode
05:43:33  Running with dbt=1.3.1
05:43:33  Found 1 model, 0 tests, 3 snapshots, 0 analyses, 325 macros, 2 operations, 0 seed files, 15 sources, 0 exposures, 0 metrics
05:43:33
05:43:34
05:43:34  Running 1 on-run-start hook
05:43:34  1 of 1 START hook: dbt_project.on-run-start.0 .................................. [RUN]
05:43:34  1 of 1 OK hook: dbt_project.on-run-start.0 ..................................... [OK in 0.00s]
05:43:34
05:43:34  Concurrency: 8 threads (target='prod')
05:43:34
05:43:34  1 of 3 START snapshot psofa.sales_orders ....................................... [RUN]
05:43:34  2 of 3 START snapshot psofa.sales_orders_appog ................................. [RUN]
05:43:34  3 of 3 START snapshot psofa.uniters_orders ..................................... [RUN]
05:43:34  oracle adapter: Oracle error: ORA-00972: identificativo troppo lungo
05:43:34  3 of 3 ERROR snapshotting psofa.uniters_orders ................................. [ERROR in 0.46s]
05:43:35  oracle adapter: Oracle error: ORA-00972: identificativo troppo lungo
05:43:35  2 of 3 ERROR snapshotting psofa.sales_orders_appog ............................. [ERROR in 0.84s]
05:43:39  1 of 3 OK snapshotted psofa.sales_orders ....................................... [OK in 4.96s]
05:43:39
05:43:39  Running 1 on-run-end hook
05:43:39  1 of 1 START hook: dbt_project.on-run-end.0 .................................... [RUN]
05:43:39  1 of 1 OK hook: dbt_project.on-run-end.0 ....................................... [OK in 0.00s]
05:43:39
05:43:39
05:43:39  Finished running 3 snapshots, 2 hooks in 0 hours 0 minutes and 5.84 seconds (5.84s).
05:43:39
05:43:39  Completed with 2 errors and 0 warnings:
05:43:39
05:43:39  Database Error in snapshot uniters_orders (snapshots/uniters_orders.sql)
05:43:39    ORA-00972: identificativo troppo lungo
05:43:39
05:43:39  Database Error in snapshot sales_orders_appog (snapshots/sales_orders_appog.sql)
05:43:39    ORA-00972: identificativo troppo lungo
05:43:39
05:43:39  Done. PASS=1 WARN=0 ERROR=2 SKIP=0 TOTAL=3```
Expected Behavior
It is logical to expect the same behaviour.
Steps To Reproduce

pip install --upgrade dbt-oracle==1.3.1
dbt snapshot

Relevant log output using --debug flag enabled
root@new-airflow-dbt:~/airflow/dags/SALES_ORDERS_MANAGEMENT/snapshots# dbt debug
05:58:19  Running with dbt=1.3.1
dbt version: 1.3.1
python version: 3.8.10
python path: /root/dbt/bin/python3
os info: Linux-5.4.17-2136.307.3.5.el8uek.x86_64-x86_64-with-glibc2.29
Using profiles.yml file at /root/.dbt/profiles.yml
Using dbt_project.yml file at /root/airflow/dags/SALES_ORDERS_MANAGEMENT/dbt_project.yml

05:58:19  oracle adapter: Running in cx mode
Configuration:
  profiles.yml file [OK found and valid]
  dbt_project.yml file [OK found and valid]

Required dependencies:
 - git [OK found]

Connection:
  user: psofa
  database: psdb
  schema: psofa
  protocol: tcp
  host: <IP_ADDRESS>
  port: 1521
  tns_name: PSDBPROD
  service: psdb
  connection_string: None
  shardingkey: []
  supershardingkey: []
  cclass: None
  purity: None
  retry_count: 1
  retry_delay: 3
  Connection test: [OK connection ok]

All checks passed!

Environment
- OS: Ubuntu 20.04.5 LTS
- Python: Python 3.8.10
- dbt: 1.3.1

What Oracle database version are you using dbt with?
<IP_ADDRESS>
Additional Context
No response

Hi @gbonazzoli
Could you run the dbt snapshot command with --debug option? This will show the SQL and identifier which raises this error.
dbt --debug snapshot
I think from version 12.2 SQL identifiers can be 128 bytes long
Also, could you let me know the dbt snapshot strategy (timestamp or check) configured ?

Hi @aosingh
You can find the debug file attached to the present message.
dbt-31-error.txt
The strategy is:
{{
    config(
      target_database='psdb',
      target_schema='psofa',
      unique_key='ID',

      strategy='check',
      check_cols='all',
      invalidate_hard_deletes=True
    )
}}

Hi,
I'm getting the same error when trying to materialize an incremental model,
It looks like the assigned names for when creating temporary tables are too long now.
example with 1.3.0: create global temporary table o$pt_132935
example with 1.3.1: create global temporary table o$pt_133255833329

@Mirko-T @gbonazzoli
This will be an issue with older versions of Oracle Databases. I think from version 12.2 SQL identifiers can be 128 bytes long
To resolve this, include the following macro in your dbt project.
{% macro oracle__make_temp_relation(base_relation, suffix) %}
    {% set dt = modules.datetime.datetime.now() %}
    {% set dtstring = dt.strftime("%H%M%S") %}
    {% set tmp_identifier = 'o$pt_' ~ base_relation.identifier ~ dtstring %}
    {% set tmp_relation = base_relation.incorporate(
                                path={"identifier": tmp_identifier, "schema": None}) -%}

    {% do return(tmp_relation) %}
{% endmacro %}

@aosingh It works! What I have done is:
In every dbt project, I have created a file named macros/make_temp_relation.sql with the content you suggested me.
Do you think the "Oracle identifier's length problem" will be directly fixed in a future version of the oracle adapter ?

@gbonazzoli
Starting from database version 12.2 the identifiers can be 128 bytes long and hence the identifier length will not be problem.
You do not need the macro override for newer Database versions (12.2, 18c, 19c, 21c). The macro override is only needed for older versions (<IP_ADDRESS> in this case).

@aosingh this same problem was fixed upstream for PostgreSQL (https://github.com/dbt-labs/dbt-core/issues/2869). Do you think a similar fix could be officially included on the Oracle adapter too?
I understand we are talking about very old Oracle versions, but it's an annoying limitation. I was putting cryptic alias for all my materializations until I found this issue.

Btw, my particular case is when using views. It seems like at some point a backup view is created and then deleted:
DECLARE
     dne_942    EXCEPTION;
     PRAGMA EXCEPTION_INIT(dne_942, -942);
     attempted_ddl_on_in_use_GTT EXCEPTION;
     pragma EXCEPTION_INIT(attempted_ddl_on_in_use_GTT, -14452);
  BEGIN
     SAVEPOINT start_transaction;
     EXECUTE IMMEDIATE 'DROP view ********.********************__dbt_backup cascade constraint';
     COMMIT;
  EXCEPTION
     WHEN attempted_ddl_on_in_use_GTT THEN
        NULL; -- if it its a global temporary table, leave it alone.
     WHEN dne_942 THEN
        NULL;
  END;


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1961

Questions ?
Please refer to the Backport tool documentation


Multi Level Menu -> Level 2 not working on responsive

On hamburger menu I can't navigate to Multi Level Menu -> Level 2
When clicking on "Level 1    v" the menu closes (with no navigation working)

Duplicate of #490
Please at least look up at older issues, just a few issues back was the same, only 3 issues back....


Include using unpkg.com

I am trying to use highlight.js via the unpkg.com CDN. My HTML file has the following in the <head> section
    <link<EMAIL_ADDRESS>rel='stylesheet'/>
    <script src='//unpkg.com/highlight.js@latest' type='text/javascript'/>
    <script<EMAIL_ADDRESS>type='text/javascript'/>
    <script<EMAIL_ADDRESS>type='text/javascript'/>
    <script<EMAIL_ADDRESS>type='text/javascript'/>
    <script<EMAIL_ADDRESS>type='text/javascript'/>
    <script type='text/javascript'>
      hljs.initHighlightingOnLoad();

All the files above, including jQuery, are successfully fetched from the CDN. However, highlight.js cannot run with the following error:
index.js:1 Uncaught ReferenceError: require is not defined
gradle.js:1 Uncaught ReferenceError: module is not defined
python.js:1 Uncaught ReferenceError: module is not defined
scala.js:1 Uncaught ReferenceError: module is not defined
r.js:1 Uncaught ReferenceError: module is not defined
create-and-publish-new-python-package.html:256 Uncaught TypeError: Cannot read property 'initHighlightingOnLoad' of undefined
    at create-and-publish-new-python-package.html:256

Am I missing something?

I don't think you can use these files directly from the lib folder. (I've tried myself)
If you want to use languages that aren't included in the default release of highlightjs, like Scala, I suggest you to go and check the custom download page here: https://highlightjs.org/download/
Sadly I don't think it is possible to get custom highlightjs packages from any CDN.

You actually can @hanxue using unpkg.
<EMAIL_ADDRESS>for example works.
Go to
<EMAIL_ADDRESS>to see all.

Sadly I don't think it is possible to get custom highlightjs packages from any CDN.

No reason it wouldn't be possible but you'd have to package them correct for the browsers you were targeting and whatever JS module system you were using.

Ping.  Can someone still advise is there is an issue here or not?  You can use the files on a CDN, but they need to be built for CDN usage (ie, the same as the files we publish at the official URLs mentioned in the documentation).  You cannot just use the raw files from the GitHub repo or NPM. Well, maybe in some green-field browsers there is a way - but you'll have better luck using the existing CDN stuff I think.
You can build CDN packages from a git checkout with:
node tools/build.js -t cdn

The files you need at then in the build folder.  You could also just download all the files from the CDN, but that might be harder.  Or you need to use a build pipeline such as webpack, etc... that knows how to take the raw files and turn them into deployable assets.

Closing this issue from inactivity.  If there is still a question or issue we're happy to help and can reopen them.  (trying to close out all the stale issues that have long since been solved)


Add support for std::io::Read

It would be helpful to have support for using std::io::Read types directly as input sources when parsing BGP data.
For example, one use-case of this would be parsing BGP messages from non-local or memory sources.
let mut http_stream = ureq::get("https://data.ris.ripe.net/rrc00/2022.01/bview.20220126.1600.gz").call()?.into_reader();
process_bgp_msgs(http_stream)?;

// Generic over any given read source
fn process_bgp_msgs<R: Read>(source: R) -> io::Result<()> {
    let mut reader = BgpkitParser::for_reader(source);
    for message in reader {
        // Propogate reader errors
        do_foo(message?);
    }
}

Additionally, it would be helpful if this extended to individual BGP messages as well. Functions such as parse_ris_live_message, parse_bmp_msg, parse_openbmp_header, parse_openbmp_msg, and parse_mrt_record already exist, but take inconsistent or non-standard inputs (&mut DataBytes, &str, and T: Read). Ideally these would all be standardized to accept T: Read and/or &[u8].
This change will likely require the complete redesign or removal of DataBytes due to its current requirement on reading the entire source into memory before parsing. Supporting a generic Read interface could greatly improve memory usage by only loading the data source as it is needed. One possible replacement for DataBytes would be using the byteorder crate to read big-endian values from a Read source and std::io::Read::take for limits.
Support for std::io::Write could also be helpful, but there are far fewer use-cases for that functionality.

Hey @jmeggitt thanks for the comment!
I have a preliminary patch that changes the BgpkitParser to takes in std::io::Read as input.
https://github.com/bgpkit/bgpkit-parser/blob/d30bf6f0c6f308276cc060e5877c2df7ec94f8a5/bgpkit-parser/src/parser/mod.rs#L113
The new constructor function BgpkitParser::new_with_reader(reader) takes in a Box<dyn Read> as the parameter. The example linked above tests both raw reader with uncompressed file, and a bzip decoder with compressed updates file.
I intent to go replace the usage of DataBytes with more standard traits, but as you noticed, the change could be quite significant. I will investigate further and get onto it soon.

Sounds like a good improvement, but I would lean towards taking (and possibly using) Read as a generic. By requiring that the input be a boxed anonymous trait without a lifetime, it means we have to give the parser ownership of the value. In most cases this is not an issue, but in some cases it may require buffering a message before use.
As a hypothetical, lets say I have a couple systems logging notable groups of BGP messages to be investigated later. In addition to the BGP messages, the log also contains some additional metadata on the state of the system at the time. However, since new_with_reader requires that requires the reader be a 'static owned value, I would need to read the entire message section to a buffer before being able to pass it to BgpkitParser. This takes additional time to allocate and copy the data and there is a small chance that there would not be enough space to fit a large group of messages.
Ideally it would be possible to do something like this and be able to process log files directly or when received by some controller.
use std::net::Ipv4Addr;
use byteorder::{ReadBytesExt, BigEndian};
use std::io;
use std::io::Read;
use std::io::ErrorKind::UnexpectedEof;

pub fn parse_bgp_log<R: Read>(reader: &mut R) -> io::Result<()> {
    loop {
        let header = match read_header(reader) {
            Ok(header) => header,
            // Reached end of file
            Err(e) if e.kind() == UnexpectedEof => return Ok(()),
            Err(err) => return Err(err),
        };

        let message_parser = BgpkitParser::from_reader(reader.take(header.bytes));

        for record in message_parser {
            // Do something with record and header information
        }
    }
}

/// Header with metadata about the data collection proceeding a group of bgp
/// messages
struct Header {
    bgp_server: Ipv4Addr,
    timestamp: u64,
    bytes: u64,
}

fn read_header<R: Read>(reader: &mut R) -> io::Result<Header> {
    // Read the IPv4 address as big endian bytes
    let mut server_address = [0u8; 4];
    reader.read_exact(&mut server_address)?;

    // Use the byteorder crate to extract the other values
    Ok(Header {
        bgp_server: Ipv4Addr::from(server_address),
        timestamp: reader.read_u64::<BigEndian>()?,
        bytes: reader.read_u64::<BigEndian>()?,
    })
}

To give a better idea of what I am describing, I created a gist with the modified file with what I am proposing for bgpkit-parser/bgpkit-parser/src/parser/mod.rs.

Additionally, I noticed 2 minor issues in bgpkit-parser/bgpkit-parser/src/parser/mod.rs. I suspect cargo clippy would have found at least one of them, but I thought it may be worth mentioning.
Inside new_with_reader, it creates a second unnecessary box.
pub fn new_with_reader(reader: Box<dyn Read>) -> Result<BgpkitParser, ParserErrorWithBytes>{
    Ok(
        BgpkitParser {
            // reader is already boxed so boxing it again just adds unnecessary indirection
            reader: Box::new(reader),
            core_dump: false,
            filters: vec![],
            options: ParserOptions::default()
        }
    )
}

Also, since Box<dyn Read> is not Send this introduces the possibility of undefined behavior by allowing non-send values to be moved and subsequently accessed on different threads. It should be simple to remove the need for this line by replacing Box<dyn Read> with Box<dyn Read + Send> to the anonymous trait be Send as well.
https://github.com/bgpkit/bgpkit-parser/blob/d30bf6f0c6f308276cc060e5877c2df7ec94f8a5/bgpkit-parser/src/parser/mod.rs#L40

Hey @jmeggitt, here is my current attempt on getting rid of DataBytes in favor of [u8] and std::io::Cursor<&[u8]> directly. The code change is quite large as it revolves changes all over the places.
https://github.com/bgpkit/bgpkit-parser/pull/80
Per your point above:
However, since new_with_reader requires that requires the reader be a 'static owned value, I would need to read the entire message section to a buffer before being able to pass it to BgpkitParser.

You do not need to read entire message section to a buffer before passing it to parser. In fact, none of the current examples require one to read all the bytes first before parsing. For example, currently when reading from a remote source, it takes a reqwest::Response which starts as soon as the connection establishes. In this way, you can start parsing a 1+GB RIB dump files immediately without waiting for it to download.
I hope that makes sense.

@digizeph, That sounds like a great improvement. A single message at a time should not be an issue for memory. Being able to parse a message from a &[u8] without allocating a new Vec<u8> every time is also be a great improvement since it allows a single buffer to be re-used for messages.
My concern above was that BgpkitParser consumes the reader so it is not possible to then take the reader back and read non-MRT data. By allowing it to consume a mutable reference to a Read type (via reader.take(header.bytes) in the example), it would allow the caller to take back control of the reader after the reference expired. As you stated, this would not be an issue for RIB dump files which do not contain non-MRT data mixed in. I believe this change will be simple to apply and will largely only require changes to bgpkit-parser/bgpkit-parser/src/parser/mod.rs when combined with your work in #80. Later today I will try to implement this functionality and create a pull request for it.
Additionally, I was trying to see how easy it would be to remove/replace DataBytes with a completely generic Read instance a while ago. I ran into a couple issues (mostly due to not being able to rewind the Read position) and did not get very far, but I did re-implement ReadUtils to be a bit more efficient. I'm not sure if this will be helpful, but you can find that work at https://github.com/bgpkit/bgpkit-parser/compare/main...jmeggitt:bgpkit-parser:read-api. Thankfully, I think you can avoid the issues I encountered though due to your usage of Cursor<&[u8]>.


Web Worker Support

Currently, this package calls web_sys::window() to get the IndexedDB factory. This fails in Web Workers because the global object is not a Window but instead a subclass of WorkerGlobalScope.
This change modifies src/idb_database.rs to support Web Workers.

Sorry for the late merge - didn't notice the PR. That's it merged and published as v0.2.3, thanks!


Implemented dynamic screen rotation and swap/flip xy axes

Cal:
I've added the necessary code to implement dynamic screen rotation and swap/flip xy axes. Working great with my counter project. Somehow my Atom editor changed some tabs, so there's lots of spurious diffs. Not really much in the way of real code changes.  I also added ADAGFX_Rotation to the config file so that the default rotation value can be altered easily there.
Thanks!
.....Andrzej

Thanks very much for this Andrzej!
As the commit has a large number of deltas due to removal of trailing whitespace, here is a summary of the fundamental changes:

Add: DrvRotateSwapFlip() to support dynamic rotation of display
Change: replace hardcoded display setRotation(1) to use GUI nRotation flag
Add: nRotation, nSwapXY, nFlipX, nFlipY to tsGui struct
Change: Use pGui flags instead of defines for rotation / flip
Add: Config define ADAGFX_ROTATE (default orientation)


[Ready for review] Angular refactor

Refactor based on #262
From the issue:

Currently, Angular is working based off how AngularJS itself keeps up their code style; however, it doesn't follow some of the best practices for Javascript in general or what people have found useful. John Papa has a great styleguide and Todd Motto has another one.

To dos:

[x] abstracting out interchange
[x] move components into /components with template and JS
[x] move foundation init to a more proper module. FoundationInit works directly with dynamic routes, no need to keep it as a general init.
[x] Move default controller into dynamic routes module
[x] make everything work in new structure
[x] fix tests
[x] add .jshint and fix errors.

Styleguide:

[x] IIFE

[x] use strict

[x] function declarations over function expressions (urgh, not looking forward to trying to do this)

[x] manual deps injection (rather than using the array notation, using the injector, not a fan but can't have declarations instead of expressions without array notation)

[x] using require on more complex directives (tabs, accordion, etc.). Use ^^ for parent requirements
.
Finally:

[x] merge master

And the status of this then is "on hold" or "forgotten" ?

@jaysonminard This refactor has been in place since 1.0.2. A big thing to put in a patch number, yes, but it was very early in the framework's life, and we needed it out anyway. We're putting out 1.1 tomorrow most likely.

@AntJanus nice work! One question, how the heck does one write unit tests for custom controllers? I wrote a dead-simple controller;
(function () {
    'use strict';
    angular.module('application')
        .controller('HomeController', HomeController)
    ;
    HomeController.$inject = ['$scope', '$stateParams', '$state', '$controller'];
    function HomeController($scope, $stateParams, $state, $controller) {
        angular.extend(this, $controller('DefaultController', {
            $scope: $scope,
            $stateParams: $stateParams,
            $state: $state
        }));
        $scope.test = "test1";
    }
})();

And what I thought was an appropriate karma test to match;
'use strict';

describe('Unit: HomeController', function() {
    beforeEach(module('application'));

    it('should exist', inject(function(FoundationApi) {
        expect(FoundationApi).not.toEqual(null);
    }));

    var ctrl, scope;

    beforeEach(inject(function($controller, $rootScope) {
        scope = $rootScope.$new();
        ctrl = $controller('HomeController', {
            $scope: scope
        });
    }));

    it('should have $scope.test set to test1',
        function() {
            expect(scope.test).toEqual("test1");
        });
});

However, I always get;
TypeError: Cannot read property 'replace' of null
	    at Object.init (/Users/hzektser/IdeaProjects/foundationTemplate/bower_components/foundation-apps/dist/js/foundation-apps.js:630:79)
	    at mqInitRun (/Users/hzektser/IdeaProjects/foundationTemplate/bower_components/foundation-apps/dist/js/foundation-apps.js:596:12)
	    at Object.invoke (/Users/hzektser/IdeaProjects/foundationTemplate/bower_components/angular/angular.js:4203:17)
	    at /Users/hzektser/IdeaProjects/foundationTemplate/bower_components/angular/angular.js:4025:71
	    at forEach (/Users/hzektser/IdeaProjects/foundationTemplate/bower_components/angular/angular.js:323:20)
	    at Object.createInjector [as injector] (/Users/hzektser/IdeaProjects/foundationTemplate/bower_components/angular/angular.js:4025:3)
	    at Object.workFn (/Users/hzektser/IdeaProjects/foundationTemplate/bower_components/angular-mocks/angular-mocks.js:2425:52)
	TypeError: Cannot read property 'test' of undefined
	    at Object.<anonymous> (/Users/hzektser/IdeaProjects/foundationTemplate/tests/components/home/HomeController.tests.js:21:25)

@japhar81 http://plnkr.co/edit/tHGew1cst9OYwV6ib4lg?p=preview

can't find the issue, @japhar81 - will check out later :)

If a repro case will help, here's my repo: https://github.com/japhar81/foundationTemplate
git clone https://github.com/japhar81/foundationTemplate
cd foundationTemplate
npm install
bower install
gulp
node_modules/karma/bin/karma start karma.config.js --log-level debug --single-run

@japhar81 I'm not sure why you'd get the error. Have you tried tracking it down the stack? I'll look at it sometime tomorrow or this upcoming week and will let you know what I come up with.

@japhar81 it seems that the issue you're having is related to mqInit.init(); call - this fails, not your tests :-)

@stryju that's good to know, but.. how do i make the tests work :)

@AntJanus Are you still planning on merging this in?


Kernel extension improvements

Description
This PR focus is on refining the Encamina.Enmarcha.SemanticKernel.Extensions.KernelExtensions class to enhance functionality and address specific use cases.
Code Changes
GetKernelPromptAsync:
This method allows users to retrieve the final prompt for a given prompt using the provided arguments.
GetKernelFunctionUsedTokensFromPromptAsync:
This method facilitates the retrieval of the total number of tokens used in generating a prompt from an inline prompt function.
Fix in GetMaxTokensFromKernelFunction:
It now considers whether the arguments are of type OpenAIPromptExecutionSettings when obtaining the MaxTokens. This method is now used in the QuestionAnsweringPlugin to calculate the number of tokens.
How Has This Been Tested?
Tests have been added in KernelExtensionsTest covering different cases.

You have to take into consideration the warnings generated by your new code in the integration process.

Should I only consider the warnings from my code or all of them (boy scouts rule😀)?

You have to take into consideration the warnings generated by your new code in the integration process.

Should I only consider the warnings from my code or all of them (boy scouts rule😀)?

Generally, I would say yes.
But some SonarCloud warnings are outdated and unhelpful. For example, the 200 characters limit per line makes the code harder to read vertically.


Offline chat messages are not received in order

Win7 64 bits v2.0.11
From client A (online) I've sent 4 chat messages to client B (offline):
"A"
"B"
"C"
"D"
When Client B connected it received the following:
"B"
"A"
"D"
"C"

Not sure how that would happen as it uses the timestamp from when the message was sent when saving offline chat messages.

I looks to me like what's happening is the timestamp rounds to the nearest second. So if you sent all those messages within a one second time frame then they would just appear in random order.
Can you confirm that's what happened?
Not sure if there's a need for more precision there or not.

If you send messages like 30 seconds apart, they arrive in order.
If you send like 15 seconds a part, they sometimes arrive in order, sometimes don't.
However, when you close client and open it again, they always start to appear in correct order (see image above, showing chat before and after closing client).


Rename Startness to Startup

@pgunapal can you please check?

@pgunapal thanks, fixed, can you check once more please?


Error when using in iOS

Launching lib/main.dart on Thiran’s iPad in debug mode...
Automatically signing iOS for device deployment using specified development team in Xcode project: 2ZC9XFUVA7
Xcode build done.                                           28.8s
Failed to build iOS app
Error output from Xcode build:
↳
    2022-07-08 18:58:18.225 xcodebuild[73814:345953] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
    2022-07-08 18:58:18.228 xcodebuild[73814:345953] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
    2022-07-08 18:58:19.359 xcodebuild[73814:345989]  DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/DVTiOSFrameworks/DVTiOSFrameworks-20038/DTDeviceKitBase/DTDKRemoteDeviceData.m:373
    Details:  (null) deviceType from 00008030-001965503CC3C02E was NULL when -platform called.
    Object:   <DTDKMobileDeviceToken: 0x7fc923a47f90>
    Method:   -platform
    Thread:   <NSThread: 0x600001564f80>{number = 7, name = (null)}
    Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
    2022-07-08 18:58:19.626 xcodebuild[73814:345989]  DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/DVTiOSFrameworks/DVTiOSFrameworks-20038/DTDeviceKitBase/DTDKRemoteDeviceData.m:373
    Details:  (null) deviceType from 00008030-001965503CC3C02E was NULL when -platform called.
    Object:   <DTDKMobileDeviceToken: 0x7fc923a47f90>
    Method:   -platform
    Thread:   <NSThread: 0x600001564f80>{number = 7, name = (null)}
    Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
    2022-07-08 18:58:19.714 xcodebuild[73814:345989]  DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/DVTiOSFrameworks/DVTiOSFrameworks-20038/DTDeviceKitBase/DTDKRemoteDeviceData.m:373
    Details:  (null) deviceType from 00008030-001965503CC3C02E was NULL when -platform called.
    Object:   <DTDKMobileDeviceToken: 0x7fc923a47f90>
    Method:   -platform
    Thread:   <NSThread: 0x600001564f80>{number = 7, name = (null)}
    Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
    ** BUILD FAILED **
Xcode's output:
↳
    Writing result bundle at path:
    	/var/folders/f0/znzx2gmd17b0kbkzc54sgl3r0000gn/T/flutter_tools.eupIOD/flutter_ios_build_temp_dirqVrVvC/temporary_xcresult_bundle
    Command CompileSwiftSources failed with a nonzero exit code
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:14:50: error: expected expression after '?' in ternary expression
                let state = call.arguments("state") ?: false
                                                     ^
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:14:50: error: consecutive statements on a line must be separated by ';'
                let state = call.arguments("state") ?: false
                                                     ^
                                                     ;
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:14:50: error: expected expression
                let state = call.arguments("state") ?: false
                                                     ^
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:16:46: error: expected '{' after 'if' condition
            } else if (call.method == "hasTorch")
                                                 ^
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:29:14: error: cannot find 'device' in scope
            try! device.lockForConfiguration()
                 ^~~~~~
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:30:9: error: cannot find 'device' in scope
            device.torchMode = state ? .on : .off
            ^~~~~~
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:31:9: error: cannot find 'device' in scope
            device.unlockForConfiguration()
            ^~~~~~
    note: Using new build system
    note: Planning
    note: Build preparation complete
    note: Building targets in dependency order
    note: Removed stale file '/Users/booshana/Library/Developer/Xcode/DerivedData/Runner-gcfvidbfvjdbkvapgdtuxcsdleva/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/GoogleAppMeasurement.build/InputFileList-ABB33747DC4A440FC9EF2E0C94985CB0-GoogleAppMeasurement-xcframeworks-input-files-7377548e42cf9c2c28d387c341606f09-resolved.xcfilelist'
    note: Removed stale file '/Users/booshana/Library/Developer/Xcode/DerivedData/Runner-gcfvidbfvjdbkvapgdtuxcsdleva/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/FirebaseAnalytics.build/InputFileList-030AF0978DB7C9D36E8357CE9D0BE637-FirebaseAnalytics-xcframeworks-input-files-56dcdbe536092d08f430bc03fd564626-resolved.xcfilelist'
    note: Removed stale file '/Users/booshana/Library/Developer/Xcode/DerivedData/Runner-gcfvidbfvjdbkvapgdtuxcsdleva/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/GoogleAppMeasurement.build/OutputFileList-ABB33747DC4A440FC9EF2E0C94985CB0-GoogleAppMeasurement-xcframeworks-output-files-b52bd120c8f52a7ad94fa84c24eb284e-resolved.xcfilelist'
    note: Removed stale file '/Users/booshana/Library/Developer/Xcode/DerivedData/Runner-gcfvidbfvjdbkvapgdtuxcsdleva/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/FirebaseAnalytics.build/OutputFileList-030AF0978DB7C9D36E8357CE9D0BE637-FirebaseAnalytics-xcframeworks-output-files-f31705b33ac336e665ef2c0fbcebd62a-resolved.xcfilelist'
    note: Removed stale file '/Users/booshana/Library/Developer/Xcode/DerivedData/Runner-gcfvidbfvjdbkvapgdtuxcsdleva/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/GoogleAppMeasurement.build/Script-ABB33747DC4A440FC9EF2E0C94985CB0.sh'
    note: Removed stale file '/Users/booshana/Library/Developer/Xcode/DerivedData/Runner-gcfvidbfvjdbkvapgdtuxcsdleva/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/FirebaseAnalytics.build/Script-030AF0978DB7C9D36E8357CE9D0BE637.sh'
    /Users/booshana/Documents/sr/service_request/ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'TOCropViewController-TOCropViewControllerBundle' from project 'Pods')
    /Users/booshana/Documents/sr/service_request/ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'Toast' from project 'Pods')
    /Users/booshana/Documents/sr/service_request/ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'TOCropViewController' from project 'Pods')
    /Users/booshana/Documents/sr/service_request/ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'ReachabilitySwift' from project 'Pods')
    /Users/booshana/Documents/sr/service_request/ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'FMDB' from project 'Pods')
    /Users/booshana/Documents/sr/service_request/ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'surveymonkey-ios-sdk' from project 'Pods')
    Result bundle written to path:
    	/var/folders/f0/znzx2gmd17b0kbkzc54sgl3r0000gn/T/flutter_tools.eupIOD/flutter_ios_build_temp_dirqVrVvC/temporary_xcresult_bundle
Could not build the precompiled application for the device.
Uncategorized (Xcode): Command CompileSwiftSources failed with a nonzero exit code

Swift Compiler Error (Xcode): Expected expression after '?' in ternary expression
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:13:49

Swift Compiler Error (Xcode): Consecutive statements on a line must be separated by ';'
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:13:49

Swift Compiler Error (Xcode): Expected expression
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:13:49

Swift Compiler Error (Xcode): Expected '{' after 'if' condition
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:15:45

Swift Compiler Error (Xcode): Cannot find 'device' in scope
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:28:13

Swift Compiler Error (Xcode): Cannot find 'device' in scope
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:29:8

Swift Compiler Error (Xcode): Cannot find 'device' in scope
/Users/booshana/.pub-cache/hosted/pub.dartlang.org/torch_control-0.3.0/ios/Classes/SwiftTorchControlPlugin.swift:30:8

Error launching application on Thiran’s iPad.

Exited (sigterm)

Flutter: 2.10.5
iOS: 15.5

Sorry, I've no iphone nearby to test the plugin. But you can try the project fork https://github.com/Colton127/torch_control where changes for ios were made. If this helps you.


ARROW-12549: [JS] Table and RecordBatch should not extend Vector, make JS lib smaller

This pull request addresses a number of issues that requires a more substantial refactor.
The main goals are:

Eliminate cruft by dropping support for outdated browsers/environments.
Reduce total surface area by eliminating unnecessary Vector, Chunked, and Column classes.
Reduce the amount of the library pulled in when Table, RecordBatch, or Vector classes are imported.

In this pull request, we have eliminated type specific Vector classes. There is now only one vector that has a data instance and we use type-specific visitors. Record batches don't inherit from vectors anymore. Neither do Tables. Columns are gone. To create vectors and tables, we now have separate methods that can be easily tree shaken.
We also added tests for the bundles, fixed some issues with bundling in webpack, updated dependencies (including typescript and flatbuffers). We also added memoization to dictionary vectors to reduce the overhead of decoding UTF-8 to strings.
A quick overview of Arrow with the new API: https://observablehq.com/d/9480eccb30a21010.

Iterate, dataset: tracks, numRows: 1,000,000
           27 ops/s ±0.28%,   37 ms, 49 samples
Spread, dataset: tracks, numRows: 1,000,000
         8.73 ops/s ±3.7%,   111 ms, 25 samples
toArray, dataset: tracks, numRows: 1,000,000
         8.15 ops/s ±4.9%,   115 ms, 26 samples
get, dataset: tracks, numRows: 1,000,000
         17.2 ops/s ±0.31%,   58 ms, 47 samples
Running "Table Direct Count" suite...
dataset: tracks, column: lat, numRows: 1,000,000, type: Float32, test: gt, value: 0
           74 ops/s ±0.16%,   14 ms, 77 samples
dataset: tracks, column: lng, numRows: 1,000,000, type: Float32, test: gt, value: 0
           74 ops/s ±0.20%,   14 ms, 77 samples
dataset: tracks, column: origin, numRows: 1,000,000, type: Dictionary<Int8, Utf8>, test: eq, value: Seattle
          80 ops/s ±0.060%,   12 ms, 71 samples

This fixes https://issues.apache.org/jira/browse/ARROW-10794 as well, right?

@domoritz yep, looks like it

@ursabot benchmark help

We're getting close to complete here. I think what's left is updating the readme and addressing any comments from reviews.

Something is seriously wrong here. I had to add this hack to make webpack use the .mjs files: 90c3d10 (#10371).
Even after this hack, webpack still does not tree shake.
$ webpack --config test/bundle/webpack-test/webpack.config.js
asset makeTable-bundle.js 310 KiB [emitted] (name: makeTable)
asset vector-bundle.js 310 KiB [emitted] (name: vector)
asset table-bundle.js 310 KiB [emitted] (name: table)
orphan modules 348 KiB [orphan] 46 modules
runtime modules 1.16 KiB 6 modules
cacheable modules 247 KiB
  modules by path ./targets/apache-arrow/ 236 KiB
    modules by path ./targets/apache-arrow/util/*.mjs 52.6 KiB 11 modules
    modules by path ./targets/apache-arrow/*.mjs 119 KiB 9 modules
    modules by path ./targets/apache-arrow/visitor/*.mjs 47.9 KiB 7 modules
    modules by path ./targets/apache-arrow/row/*.mjs 8.07 KiB 2 modules
    modules by path ./targets/apache-arrow/builder/*.mjs 8.14 KiB
      ./targets/apache-arrow/builder/buffer.mjs 5.78 KiB [built] [code generated]
      ./targets/apache-arrow/builder/valid.mjs 2.36 KiB [built] [code generated]
  modules by path ./test/bundle/webpack-test/*.js 124 bytes
    ./test/bundle/webpack-test/table.js 58 bytes [built] [code generated]
    ./test/bundle/webpack-test/makeTable.js 66 bytes [built] [code generated]
  ./node_modules/tslib/tslib.es6.js 11.5 KiB [built] [code generated]
webpack 5.65.0 compiled successfully in 230 ms

[ ] Remove index subscript code
[ ] Update docs
[ ] Apply memoization in iterator visitor

@ursabot please benchmark lang=JavaScript


Unable to update a metric

Guys i am trying to update metric using following command:
curl -k -XPOST 'https://localhost/api/metrics/points' -d '{"_token":"blablabla", "id":1, "value":1}'
Any ideas why it doesn't work?
it says
[2015-02-26 17:31:26] local.ERROR: exception 'CachetHQ\Cachet\Repositories\InvalidModelValidationException' with message 'Validation failed on the model.' in /var/www/html/Cachet/src/Repositories/EloquentRepository.php:151
Stack trace:
#0 /var/www/html/Cachet/src/Repositories/MetricPoint/EloquentMetricPointRepository.php(40): CachetHQ\Cachet\Repositories\EloquentRepository->validate(Object(CachetHQ\Cachet\Models\MetricPoint))
#1 /var/www/html/Cachet/src/Http/Controllers/Api/MetricPointController.php(61): CachetHQ\Cachet\Repositories\MetricPoint\EloquentMetricPointRepository->create(Array)
#2 [internal function]: CachetHQ\Cachet\Http\Controllers\Api\MetricPointController->postMetricPoints()
#3 /var/www/html/Cachet/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(231): call_user_func_array(Array, Array)
#4 /var/www/html/Cachet/bootstrap/compiled.php(5843): Illuminate\Routing\Controller->callAction('postMetricPoint...', Array)
#5 /var/www/html/Cachet/bootstrap/compiled.php(5831): Illuminate\Routing\ControllerDispatcher->call(Object(CachetHQ\Cachet\Http\Controllers\Api\MetricPointController), Object(Dingo\Api\Routing\Route), 'postMetricPoint...')
#6 /var/www/html/Cachet/bootstrap/compiled.php(5036): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Dingo\Api\Routing\Route), Object(Illuminate\Http\Request), 'CachetHQ\Cachet...', 'postMetricPoint...')
#7 [internal function]: Illuminate\Routing\Router->Illuminate\Routing{closure}()
#8 /var/www/html/Cachet/bootstrap/compiled.php(5394): call_user_func_array(Object(Closure), Array)
#9 /var/www/html/Cachet/bootstrap/compiled.php(5061): Illuminate\Routing\Route->run(Object(Illuminate\Http\Request))
#10 /var/www/html/Cachet/bootstrap/compiled.php(5049): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#11 /var/www/html/Cachet/vendor/dingo/api/src/Routing/Router.php(231): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#12 /var/www/html/Cachet/bootstrap/compiled.php(715): Dingo\Api\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#13 /var/www/html/Cachet/bootstrap/compiled.php(696): Illuminate\Foundation\Application->dispatch(Object(Illuminate\Http\Request))
#14 /var/www/html/Cachet/bootstrap/compiled.php(7821): Illuminate\Foundation\Application->handle(Object(Illuminate\Http\Request), 1, true)
#15 /var/www/html/Cachet/bootstrap/compiled.php(8428): Illuminate\Session\Middleware->handle(Object(Illuminate\Http\Request), 1, true)
#16 /var/www/html/Cachet/bootstrap/compiled.php(8375): Illuminate\Cookie\Queue->handle(Object(Illuminate\Http\Request), 1, true)
#17 /var/www/html/Cachet/bootstrap/compiled.php(11038): Illuminate\Cookie\Guard->handle(Object(Illuminate\Http\Request), 1, true)
#18 /var/www/html/Cachet/bootstrap/compiled.php(657): Stack\StackedHttpKernel->handle(Object(Illuminate\Http\Request))
#19 /var/www/html/Cachet/public/index.php(48): Illuminate\Foundation\Application->run()

We are not accepting json input atm on the API can you try like this? curl -H "X-Cachet-Token: YOURTOKEN" -X POST -d 'id=1&value=1' http://cachet.app:8000/api/metrics/points

@joecohens, with your example, I'm getting an wWhoops, looks like something went wrong.web page
(command: curl -H "X-Cachet-Token: MYSECRET" -X POST -d 'id=1&value=1' 'http://MYHEROKUDEPLOYEDAPP/api/metrics/points')

It looks much better but graph still didn't present the values which i am pushing
curl -k -H "X-Cachet-Token: pnUxF5qERmmKhoOJV5wv" -X POST -d 'metric_id=1&value=100' https://localhost/api/metrics/points
{"metric_point":{"metric_id":"1","value":"100","updated_at":"2015-02-27 12:20:57","created_at":"2015-02-27 12:20:57","id":8}}
curl -k -H "X-Cachet-Token: pnUxF5qERmmKhoOJV5wv" -X POST -d 'id=1&value=100' https://localhost/api/metrics/points
{"metric_point":{"value":"100","updated_at":"2015-02-27 12:30:44","created_at":"2015-02-27 12:30:44","id":15}}

If i perform like this:
curl -k -H "X-Cachet-Token: pnUxF5qERmmKhoOJV5wv" -X POST -d 'metric_id=1&value=100' https://localhost/api/metrics/points
{"metric_point":{"metric_id":"1","value":"100","updated_at":"2015-02-27 12:20:57","created_at":"2015-02-27 12:20:57","id":8}}
then it looks like right:
mysql> select * FROM cachet.metrics;
+----+------+----------------------------+----------------------------+---------------+---------------+---------------------+---------------------+
| id | name | suffix                     | description                | default_value | display_chart | created_at          | updated_at          |
+----+------+----------------------------+----------------------------+---------------+---------------+---------------------+---------------------+
|  1 | SDK: | SDK: API SDK RESPONSE TIME | SDK: API SDK RESPONSE TIME |             0 |             1 | 2015-02-26 12:41:57 | 2015-02-27 12:19:35 |
+----+------+----------------------------+----------------------------+---------------+---------------+---------------------+---------------------+
1 row in set (0.00 sec)
mysql> select * FROM cachet.metric_points;
+----+-----------+-------+---------------------+---------------------+
| id | metric_id | value | created_at          | updated_at          |
+----+-----------+-------+---------------------+---------------------+
|  1 |         1 |   100 | 2015-02-27 12:38:35 | 2015-02-27 12:38:35 |
+----+-----------+-------+---------------------+---------------------+
1 row in set (0.00 sec)
but graph still doesn't present the data

I just figure out  why metrics weren't presenting properly on the graph so i found two issues (BTW my time zone is Asia/Jerusalem)

Because %c presents month without 0, so right choose as following ( %m	Month, numeric (00-12) inside actual query)

You should present average and not sum for one hour since sum it is pointless

so i changed from
this src/Models/Metric.php):
$value = (int) $this->points()->whereRaw('DATE_FORMAT(created_at, "%Y%c%e%H") = '.$dateTime->format('YmdH'))->whereRaw('HOUR(created_at) = HOUR(DATE_SUB(NOW(), INTERVAL '.$hour.' HOUR))')->groupBy(DB::raw('HOUR(created_at)'))->sum('value');
to this (src/Models/Metric.php):
$value = (int) $this->points()->whereRaw('DATE_FORMAT(created_at, "%Y%m%e%H") = '.$dateTime->format('YmdH'))->whereRaw('HOUR(created_at) = HOUR(DATE_SUB(NOW(), INTERVAL '.$hour.' HOUR))')->groupBy(DB::raw('HOUR(created_at)'))->avg('value');
Please advise, let me know if u want i'll submit my code.

Please submit a PR and I'll check it out @oovoo :)

and %e replace to %d

ok i will submit

@oovoo any news on this? :)

we will provide an answer, it looks like it about your default date formatting.
details are coming soon.

Ah... Sorry, updating a metric point?

Right, this is done now - get it from master.
PUT /api/metrics/:metric_id/points/:metric_point_id

Then just send through the same information and the metric point will be updated.

Guys i am so sorry we just can't get to this

@oovoo are you still having the same issue?

i didn't have a chance to check it i hope tommorow


Date Picker Reading Incorrect type in Value

Bug, feature request, or proposal:
Typing into the datepicker has the value be read as 1 day less. So 2018-05-31 will be converted to 2018-05-30.
It seems to be only with this particular format.
What is the expected behavior?
That the date be the same.
What is the current behavior?

What are the steps to reproduce?
go to the example site and type in 2018-05-31 into the "Datepicker selected value" section. https://material.angular.io/components/datepicker/examples
What is the use-case or motivation for changing an existing behavior?
So that what is typed in is the actual value
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Existing one.

The NativeDateAdapter only supports dates in mm/dd/yyyy format due to the limitations of JavaScript's Date parsing. I'd suggest using a different date adapter that supports other formats (e.g. https://www.npmjs.com/package/@angular/material-moment-adapter)


Update packaging method

Update for PEP 517 instead of pbr

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@0051647). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   34.31%
=======================================
  Files           ?        6
  Lines           ?      714
  Branches        ?      122
=======================================
  Hits            ?      245
  Misses          ?      439
  Partials        ?       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0051647...15bcbd9. Read the comment docs.


MyAccount and Console - Blank Page

Describe the issue:
I'm trying to login on MyAccount and Console page from WSO2-IS and I'm receiving a blank page.
Browser Console:
Uncaught (in promise) Invalid id_token in the token response: eyJ4NXQiOiJNell4TW1Ga09HWXdNV0kwWldObU5EY3hOR1l3WW1NNFpUQTNNV0kyTkRBelpHUXpOR00wWkdSbE5qSmtPREZrWkRSaU9URmtNV0ZoTXpVMlpHVmxOZyIsImtpZCI6Ik16WXhNbUZrT0dZd01XSTBaV05tTkRjeE5HWXdZbU00WlRBM01XSTJOREF6WkdRek5HTTBaR1JsTmpKa09ERmtaRFJpT1RGa01XRmhNelUyWkdWbE5nX1JTMjU2IiwiYWxnIjoiUlMyNTYifQ.eyJhdF...
How to reproduce:

Change offset from IS on deployment.toml:
[server]
offset = "1"
Put the following configuration on deployment.toml:
[system_applications]
read_only_apps = []
Login to management console and change the Console port of the callback URL to: https://localhost:9444/console/login
Login to management console and change the MyAccount port of the callback URL to: https://localhost:9444/myaccount/login

Expected behavior:
Login on MyAccount or Console page.
Environment information:

Product Version: IS 5.11.0
OS: Ubuntu 20.04.2 LTS
Database: mysql:5.7.34
Userstore: LDAP
Environment: Docker 20.10.7, Docker Compose 1.25.0

Suggested labels:
wso2-is, myaccount, console

It needs to configure Identity Provider Entity ID on Home -> Identity Providers -> Resident -> Inbound Authentication Configuration -> OAuth2/OpenID Connect Configuration:
Identity Provider Entity ID: https://localhost:9444/oauth2/token
Now I can log on MyAccount and Console.


Use tablet instead of mouse when using vnc display

There is the occasional offset between the software and hardware cursor when using mouse with a VNC display...
By using a "tablet" instead of a "mouse", this is avoided. It sends all positions as absolute instead of relative.

Support added to the Lima GUI here:
https://github.com/afbjorklund/lima-gui/commit/367b745e009d107043f4a5b0ed8f584c2490171f


Put go-to position at center of view

Mimics vscode behavior and puts the line at the center of the view vertically, rather than moving the minimal amount to put the line on screen, which can result in the line being in various places (very top, very bottom). We've gotten feedback this is confusing for users.

This seems reasonable, and aligns with what some other tools are doing.


Add my first file

Add my first file

this is the first time Im merging the request into branch

done son


Incorrect [ERR:UH0705]  Unsupported data type / interconnect

On following code:
module a(
input interconnect b
	);
endmodule

The tool with following command:
surelog -parse -d uhdm  ../ipxact-import/build/interconnect.sv
produce :
[ERR:UH0705] interconnect.sv:2:20: Unsupported data type "<n<> u<5> t<Implicit_data_type> p<6> l<2:20> el<2:20>> input interconnect b".
interconnect is not a data type, see chapter: 6.6.8 Generic interconnect
Surprisingly with -nobuiltin the error disappear... This behavior is very odd to me. According to the online help I won't expect this, because it is not buildin classes (array...)
By going through the LRM, I note:

(<IP_ADDRESS>) It shall be illegal to specify signed for a port declared as an interconnect port. (The grammar allow it)
(<IP_ADDRESS>) If the data type is omitted, it shall default to logic, except for interconnect ports, which have no data type.
(<IP_ADDRESS>) If the previous port was an interconnect port, this port shall also be an interconnect port.
(<IP_ADDRESS>) A default shall not be specified for a port declared as interconnect

There is other notes but they refer to elaboration step.
additional legal examples:
module a( n);
  input interconnect n;
endmodule

module b( n);
  input n;
  interconnect n;
endmodule

module c( input interconnect n,m);
endmodule

module d(n,m);
  input n,m;
  interconnect n;
  interconnect m;
endmodule

Illegal examples:
module a(
  input interconnect signed n
);
endmodule

module b(
  input interconnect n = 1'b1
);
endmodule

module c(n);
  input n;
  interconnect signed n;
endmodule

module d(n);
  input interconnect n = 1'b1;
endmodule

module d(n);
  input n;
  interconnect n = 1'b1;
endmodule

It is unsupported. It is parsed but not modeled. I welcome a PR!

I look at that but for the moment I do not understand the code...

I have difficulties to understand the way the antlr ast is used. Apparently you did differently than what is done in hdlConvertor for example.

module dut( input interconnect net);
endmodule

design: (work@dut)
|vpiName:work@dut
|uhdmallModules:
\_module: work@dut (work@dut), interconnect.sv, line:1:1, endln:2:10
  |vpiParent:
  \_design: (work@dut)
  |vpiFullName:work@dut
  |vpiDefName:work@dut
  |vpiNet:
  \_logic_net: (work@dut.net), line:1:32, endln:1:35
    |vpiParent:
    \_module: work@dut (work@dut), interconnect.sv, line:1:1, endln:2:10
    |vpiName:net
<EMAIL_ADDRESS>    |vpiNetType:12
  |vpiPort:
  \_port: (net), line:1:32, endln:1:35
    |vpiParent:
    \_module: work@dut (work@dut), interconnect.sv, line:1:1, endln:2:10
    |vpiName:net
    |vpiDirection:1
    |vpiLowConn:
    \_ref_obj:
      |vpiActual:
      \_logic_net: (work@dut.net), line:1:32, endln:1:35

Is this data structure correct  for provided SV code ? vpiNetType:12 correspond to #define vpiNone which is actually missing net type in generated code.

Yes, that is acceptable. I'm working on it.

Fixed by #3432


Subscribe and publish

I can't get en event to fire when a client subscribe a topic but only when on that topic a message is received. Like if on('subscribe') acts more like on ('publish'). Is there an event that fires just when a user subscribes even if no messages are sent at all ?
I also don't really get how to create a topic with the the dot notation.
for instance, I could send to topic /one/two but not sure if I should listen to subscription to /one.two or one.two´ or /one/two`... could you be more explicit in the documentation or examples maybe ?

+1

+1, seems like there is no callback to tell that the topic has been subscribed. @4ib3r is this project being maintained? I want to implement it.

@Caleb-Bolton @theRenard wondering if you found any workarounds, I want to send some messages to the client as soon as a topic is subscribed.

Not sure 100% but I think I've moved to this https://github.com/stomp-js/stompjs

I was finally able to achieve this using middleware
function onSubscribeMiddleware(socket, args, callNext) {
  // send something to the subscriber
  return callNext(socket, args, callNext);
}

stompServer.addMiddleware('subscribe', onSubscribeMiddleware);
stompServer.subscribe('/topic/messages/#', () => {});


Switch to Puma per Heroku's new recommendation.

Heroku is now officially recommending the use of Puma over Unicorn in production.
https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server

:+1: well, to be fair, just going by name pumas beat unicorns.


Rename errorResponse to align with other RPs

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Can one of the admins verify this patch?

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

@zfchen95 This is seen as a breaking change for SDK. We recommend it more that you create a new tag package.


Composite Elasticsearch Restore script changes

Codecov Report

Merging #505 into release-2.2.0 will decrease coverage by 0.26%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             release-2.2.0     #505      +/-   ##
===================================================
- Coverage            32.36%   32.09%   -0.27%
+ Complexity            1225     1218       -7
===================================================
  Files                  170      170
  Lines                15010    15010
  Branches              2377     2377
===================================================
- Hits                  4858     4818      -40
- Misses                9422     9463      +41
+ Partials               730      729       -1

Impacted Files
Coverage Δ
Complexity Δ

...dex/transformer/AggregationsResultTransformer.java
0% <0%> (-100%)
0% <0%> (-4%)

...p/searchindex/elasticsearch/ElasticSearchUtil.java
43.56% <0%> (-4.39%)
49% <0%> (-3%)

.../ekstep/searchindex/processor/SearchProcessor.java
65.45% <0%> (-0.91%)
99% <0%> (ø)

...org/ekstep/graph/engine/router/ActorBootstrap.java
57.61% <0%> (+1.32%)
16% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85db72c...581c64e. Read the comment docs.


No signature of Method - Can’t Install

Hello.
After installing 30 + packages in my 2 HE devices, I found this package. :-p
I’ve followed the instructions and did some research and read through comments here and in the HE forums as well before posting this issue.
I’m not able to save the Package Manager after importing or manually Copy/Pasting the raw code into the Drivers Code area of the HE UI.   An alert bar appears with this:
No signature of method: Script1.definition() is applicable for argument types: (java.util.LinkedHashMap) values: [[name:Hubitat Package Manager, namespace:dcm.hpm, author:Dominick Meglio, ...]]
I’ve searched for this message all over the web and wasn’t able to figure this out.
It seems like a straight forward install and I’m not sure what the issue is.
Any suggestions or ideas?
Thank you for this. Clearly you and others have put a ton of effort and time into this.

Been on a Drivers installed bender and forgot that this was an App, not a Driver! 🤦🏼♂


-march=native should be a user choice

This part of the build system:
https://github.com/microsoft/mimalloc/blob/92ead2d88061dde1264800b389b744ac1b79cf39/CMakeLists.txt#L194-L199
caused SolveSpace ("us") to trigger an "error" in the Debian QA process build log scanner: see

https://github.com/solvespace/solvespace/issues/934
https://qa.debian.org/bls/packages/s/solvespace.html - with details of why this is scanned and errored: https://qa.debian.org/bls/bytag/E-march-native.html
the pretty trivial patch I applied in the SolveSpace package to fix it: https://salsa.debian.org/science-team/solvespace/-/blob/master/debian/patches/0007-Remove-march-native-from-mimalloc-build.patch

reminds me of a PR merged weeks ago ... wonders if the dev branch works better ?

It's just the existence of the code adding the build flag -march=native that is the problem: not how it's guarded. (It's guarded in master differently than in 2.0.0). Dev has the same thing. That entire chunk of CMake code should go away: it silently optimizes for the build machine.

ah right this is understandable from wide package build for so many possible targets.

Let's continue  this in the PR #362


feature: add a mechanism for clients to store data on the server

This is only supported if security is turned on.
This supports two name spaces, one for global data and one for user specific data. All data is stored in the JSON format.
For example, a client might want to store boat specific gauge configuration globally so that other users have access to it.
Otherwise, it could use the user area to store user specific preferences.
Global storage is at: /signalk/v1/applicationData/global/:appid/:version
User storage is at: /signalk/v1/applicationData/user/:appid/:version
There are two ways to update or add stored data:

You can POST any json data to any path:

POST /signalk/v1/applicationData/user/my-application/1.0/unitPreferences
{
  "shortDistance": "m",
  "longDistance": "km"
}

You can also use json patch format (http://jsonpatch.com):

POST /signalk/v1/applicationData/user/my-application/1.0
[
  { "op": "add", "path": "/unitPreferences", "value": { "shortDistace": "m" } },
  { "op": "add", "path": "/unitPreferences/longDistance", "value": "km"}
]

Use an HTTP GET request to retrieve data from the server:
GET /signalk/v1/applicationData/user/my-application/1.0/unitPreferences/shortDistance

Replaces #643

I can't figure out the test failure. It doesn't fail if you just run that one test...

@tkurki I think I've addressed all your comments

Oh. Missed the comment about multiple apps and versions. I'll add those...


feat: update egypt geojson AB#6627

@gulfaraz I have incorporated this in another PR

#593 for reference


k8s/watchers: Add missing v1 EndpointSlice group on init

The K8sWatcher's InitK8sSubsystem() calls resourceGroups() which returns
a list of resources that should be waited on via WaitForCacheSync(). The
v1 version of EndpointSlice was missing from this list. This commit adds
it.
Signed-off-by: Chris Tarazi<EMAIL_ADDRESS>

@joestringer My guess for why we don't see it in CI is because we probably don't disable the original Endpoints resource, so even if the v1.EndpointSlice group is missing from the wait, then we still have to wait on the former. I imagine that if Cilium ran in a cluster with the former completely disabled, then we would have seen some flakes at the startup.
I found it through regular code inspection while working on https://github.com/cilium/cilium/pull/17714.

/test

/test

Reviews are in. Multicluster has the usual failure and k8s-1.21-kernel-4.19 hit known flake https://github.com/cilium/cilium/issues/13552. Marking ready to merge and merging.


File.Readdir not supported

I was trying to get the size of directories. But since ReadDir (uppercase D) doesn't allow us to access the size, we have to use the File.Readdir() from the File object returned by VFS.Open(). Notice that the latter is Readdir with lowercase D.
So, removing all error checking for simplicity:
func GetDirSize(directory string) int64 {
    dirRead, err := os.Open(directory)
    dirFiles, err := dirRead.Readdir(0)
    sum := int64(0)
    for _, fi := range dirFiles {
        sum += fi.Size()
    }
    dirRead.Close()
    return sum
}

By the way, it appears ReadDir() with uppercase Dir is also not supported.

Hopefully this project gets updated because it has no external dependencies. The others I have examined have a large footprint.