Do not scaffold .jshintrc if a user chooses ES6

See related #56 and #69.

you can probably get your "you should install a linter" message from https://github.com/Esri/generator-esri-appbuilder-js#linting-your-code, or point people there.

@tomwayson after looking through this, I've discovered a problem - the .jshintrc is created in the main generator, but the es5-vs-es2015 decision happens in the widget generator.
At this point, after reviewing #56 and #69, I'm leaning towards just saying "don't scaffold jshint file" and leave linting up to the user. Sound ok?

yeah, I think that's the same conclusion I came to.


email report not working 🐛

When submiting job with spark.sparklens.report.email feature:
spark-submit --jars /tmp/sparklens-0.3.2-s_2.11.jar,/tmp/httpmime-4.5.14.jar --conf spark.extraListeners=com.qubole.sparklens.QuboleJobListener --conf spark.driver.extraJavaOptions=-Dderby.system.home=/tmp/derby --class org.apache.spark.examples.SparkPi --master spark://spark-master:7077 --conf spark.eventLog.enabled=true --conf spark.eventLog.dir=/tmp/spark-events --conf<EMAIL_ADDRESS>/tmp/examples.jar 1000
Getting the following error and email is not sent:
Error while trying to generate email report: Connect to sparklens.qubole.com:80 [sparklens.qubole.com/<IP_ADDRESS>] failed: Connection timed out (Connection timed out)   Try to use sparklens.qubole.com to generate the report manually
The is due to the fact that sprarklens email generation relies on sparklens.qubole.com endpoint which is down.


Metric views registered with register_metric_view are not shown in Grafana metrics browser

Scenario:

Create a continuous aggregate metric view test_metric_delete_me_1m based on Promscale metric
Register the view with SELECT register_metric_view('public', 'test_metric_delete_me_1m');

Expected behavior:
Metric test_metric_delete_me_1m is shown in the Grafana metrics browser.
Actual behavior:
Metric is not shown in the Grafana metrics browser after reloading the page. Note that the issue is only with exposing the metric name, the data itself is properly exposed i.e. I get proper data from a query like test_metric_delete_me_1m{__column__="min"}.
Promscale version is 7ae4fb21a1196a2fde0eed7800dce11c31df899c
Promscale extension version is 0.5.4.

Somehow related: metrics deleted with drop_metric are still visible in the Grafana metrics browser.

@oliora thanks for reporting the issue!

Metric is not shown in the Grafana metrics browser after reloading the page

I can confirm that with no __column__ provided, no values are returned in Grafana. My guess is that this is because Promscale Caggs always expect a column, as there is no default column. With column provided, it works as expected. I will look into this more and try to get a fix or some reason.

metrics deleted with drop_metric are still visible in the Grafana metrics browser

I tried to reproduce this by deleting a metric using select prom_api.drop_metric('go_gc_duration_seconds');. After deleting, I could not find any data in Grafana. Did you do the same, simply dropping the metric using this function, or something else?

@Harkishen-Singh yes, I’ve just called prom_api.drop_metric as you said. I’ll try to reproduce it one more time and come back.
Btw, before you’ve deleted the metric have you seen it in Grafana metrics explorer?

I can confirm that with no column provided, no values are returned in Grafana

@oliora, to get values in PromQL from Caggs without using __column__, you should create a column with name value while creating Caggs. This is because, when Promscale gets a query without any __column__ label, it looks for this value column. If not found, it returns empty result.

Btw, before you’ve deleted the metric have you seen it in Grafana metrics explorer?

Yes. I first visualised go_gc_duration_seconds in Grafana, then dropped using select prom_api.drop_metric('go_gc_duration_seconds'); (had to restart Promscale because drop_metric needs all Promscale connectors off) and then I couldn't find the metric next.

@Harkishen-Singh I have rechecked the behavior of drop_metric and it does not delete metric names for me. To get metric names Promscale executes SELECT value from _prom_catalog.label WHERE key='__name__' and if I run this query manually I see that all the deleted metrics are still there. You behavior may be different because you're deleting cagg metric rather than the original metric itself. I'm sorry if I caused this confusion. I should have created a separate issue for this rather than pegging it back on a metric view issue.

The behavior you see may be different because you're deleting cagg metric (aka metric view) rather than a metric itself

Strange, I deleted the actual metric hyper table using select prom_api.drop_metric('go_gc_duration_seconds');. Will try again but will execute the SQL query you mentioned and see what happens.
Thank you.


TimePicker crash because AM/PM formatting issue in 11.2

This issue is caused by 11.2 incompatibility. We either need to bump Ursa version and make it only compatible with 11.2 starting from this new version, or waiting to see if https://github.com/AvaloniaUI/Avalonia/pull/17398 can be merged and we can add a note that Ursa won't work with the specific 11.2.0 version.

As Avalonia 17398 is merged and will be shipped with 11.2.1, we only need to add a note that Ursa Timepicker is ONLY not compatible with Avalonia 11.2.0.


License?

Hi guys,
Might be worth it to discuss and choose the License for this project, especially for people who are interested in customizing the controller for their own application?
Cheers!
/Luca

Yes, this is a good idea, and not just limited to the motor controller code.
(we can discuss this internally, but tagging @wuphilipp @gbalke @allanzhao for thoughts)

We decided on MIT for everything -- thanks for bringing this up Luca!


Policy state self-verification should refer to previous state for root threshold

What happened?
We verify root role signatures using the prior state when a new state is encountered in gittuf verify-ref. However, policy's state.Verify looks at the same state's root role to determine trusted keys / threshold. This also means that a key can't self-revoke. While this is filed as a bug, due to consecutive state verification in verify-ref, we're still safe.
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm going to work on this.


Freeze and cache pip dependencies on CI

Creates requirements-dev.txt which contains the dependencies needed for running the test suite, and sets up the CI to cache these dependencies.
Once this and #953 are both merged, I'll also setup dependabot to help maintain those dependencies.

Oh, weird, I don't remember doing that.

Thanks!


Incompatible with Spring 4.1.2

The newest release of Spring (4.1.2) and particularly this commit makes this watcher broken:
NoMethodError: undefined method `synchronize' for #<Spring::Watcher::Listen:0x00000001062a2e50 ...
...

/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/spring-watcher-listen-2.1.0/lib/spring/watcher/listen.rb:61:in `changed'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/config.rb:28:in `call'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:117:in `block in _process_changes'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/thread.rb:26:in `rescue_and_log'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:116:in `_process_changes'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:25:in `block in loop_for'
/Users/thierry/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/listen-3.8.0/lib/listen/event/processor.rb:20:in `loop'
...

I believe this call to synchronize should be changed to @mutex.synchronize to mimic what happened in that commit

I just released Spring 4.1.3 which should fix this issue.

Thank you very much for the reactivity 🙏


How to hide SSo client behind ZUUL proxy server?

How to customize redirect URL with compromising security for example my current URI is as below :
Redirecting to 'http://localhost:8765/uaa/oauth/authorize?client_id=acme&redirect_uri=http://localhost:9999/sso/dashboard/login&response_type=code&state=5Qe5XL'
And modified URI will be
Redirecting to 'http://localhost:8765/uaa/oauth/authorize?client_id=acme&redirect_uri=http://localhost:8080/sso/dashboard/login&response_type=code&state=5Qe5XL'
where "http://localhost:8080" is my zuul proxy server.This way I can hide my client behind proxy gateway server

You can register a fixed redirect URI in the auth server. That will work if you always redirect to the same place (you probably need to setspring.oauth2.client.registeredRedirectUri and spring.oauth2.client.preEstablishedRedirectUri on the server and client respectively, and spring.oauth2.client.useCurrentUri=false on the client). Beyond that you would need a change in the auth server itself (so in Spring Security OAuth).


Google Bard Error

Describe the bug
问题描述
Google Bard isn't working, its gives an error
To Reproduce
如何复现
Steps to reproduce the behavior:

Go to 'Bard (Web)'
Type Anything
**Error:

Error parsing response: make sure you are using the correct cookie, copy the value of "__Secure-1PSID" cookie and set it like this:
new Bard("__Secure-1PSID=<COOKIE_VALUE>")
Also using a US proxy is recommended.
If this error persists, please open an issue on github.
https://github.com/PawanOsman/GoogleBard**
Expected behavior
期望行为
Does not respond and gives an error
Screenshots
截图说明

Please complete the following information):
请补全以下内容

OS: Windows
Browser: Brave
Extension Version: v2.4.8

https://github.com/josStorer/chatGPTBox/releases/tag/v2.5.2


[Proposal] Simpify TagHelper value context for types

From @sgjsakura on January 6, 2016 8:24
Hi all,
I'm now working on MVC projects and trying to design new tag helpers. Some tag helper attributes need to input a type as its value. e.g. The TagHelper may defined as:
public class MyTagHelper : TagHelper
{
  [HtmlAttributeName("asp-data-type")]
  public Type DataType {get;set;}
}

In the rozar view page, the current usage should be:
<input asp-data-type="typeof(int)" />
<input asp-data-type="a" /> <!-- a is a C# variable of System.Type -->

I suggest the new grammer be:
<input asp-data-type="int" />
<input asp-data-type="@a" />

Thank you~
Copied from original issue: aspnet/Mvc#3873

This would definitely be interesting. We have a similar (but not duplicate) issue here. Going to move this issue to Razor.

No immediate plans to do this.


lombok plugin overrides diamond-inspection severity

Since version 0.9.8 the lombok plugin hardcodes the severity of the Convert2Diamond inspection to "warning".
If there is no way to preserve the configured severity, a setting to turn the fix to https://github.com/mplushnikov/lombok-intellij-plugin/issues/153 off would be a workaround.

With last changes in original inspection (https://github.com/JetBrains/intellij-community/commit/738850d65f1dfbc6e2e1a9d43857de55d77f9b49)
lombok_plugin will not overwrite diamond inspection any more.
see also #359


Codecov Report

Merging #10842 (67aaed4) into master (dc35068) will decrease coverage by 3.66%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #10842      +/-   ##
============================================
- Coverage     27.45%   23.79%   -3.66%
  Complexity       58       58
============================================
  Files          2154     2154
  Lines        116255   116258       +3
  Branches      17606    17606
============================================
- Hits          31919    27669    -4250
- Misses        81175    85727    +4552
+ Partials       3161     2862     -299

Flag
Coverage Δ

integration1
?

integration2
23.79% <0.00%> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ment/index/readers/text/NativeTextIndexReader.java
0.00% <0.00%> (ø)

... and 265 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Spread operator in JSX causes loss of type information for inline functions defined outside the spread operator

Bug Report
When defining conditional types on a JSX component, using a spread operator causes loss of type information on inline functions while removing the spread operator resolves the issue.

🔎 Search Terms

"jsx spread"
"TS7006"

⏯ Playground Link

Playground link with relevant code
💻 Code

Given the following types and JSX:
/**
 * Either all properties are included, or none of them should be
 * @example
 * type Ex = AllOrNone<{ search: string; onSearchChange: (value: string) => void}>
 *
 * // Ok
 * const t1: Ex = {
 *   search: "hello",
 *   onSearchChange: (value) => console.log(value)
 * }
 *
 * // Error, needs onSearchChange
 * const t2: Ex = {
 *   search: "hello",
 * }
 *
 * // Error, needs search
 * const t3: Ex = {
 *   onSearchChange: (value) => console.log(value)
 * }
 */
export type AllOrNone<T> = T | { [K in keyof T]?: never };

export type OrderHistoryTableProps = {
  data: OrderRow[];
  noDataText?: string;
} & SortParams &
  FilterParams &
  SearchParams;

type SortParams = AllOrNone<{
  sorting: SortingState;
  onSortChange: (state: SortingState) => void;
}>;

type FilterParams = AllOrNone<{
  filter: ColumnFiltersState;
  onFilterChange: (state: ColumnFiltersState) => void;
}>;

type SearchParams = AllOrNone<{
  search: string;
  onSearchChange: (value: string) => void;
}>;

function OrderHistoryTable({
  data,
  noDataText = "No orders to display!",
  onFilterChange,
  onSortChange,
  sorting,
  filter,
  search,
  onSearchChange,
}: OrderHistoryTableProps): JSX.Element {
  ...
}

/* sorting, filter, and search are correct types */
<OrderHistoryTable
  data={rowData}
  {...{ sorting, filter, search }}
  onSortChange={onSortChange}
  onFilterChange={setFilter}
  onSearchChange={(value) => setSearch(value)} // TS7006: Parameter 'value' implicitly has an 'any' type.
/>

However, removing the spread operator resolves the issue:
<OrderHistoryTable
  data={rowData}
  sorting={sorting}
  filter={filter}
  search={search}
  onSortChange={onSortChange}
  onFilterChange={setFilter}
  onSearchChange={(value) => setSearch(value)}
/>

🙁 Actual behavior
While using the spread operator for other props, the inline function loses type information.

🙂 Expected behavior
Given that the values provided in the spread operator are the correct type, the arguments in the inline function should retain type information.

discriminateContextualTypeByJSXAttributes doesn't account for spreads. discriminateContextualTypeByObjectMembers doesn't do it either but It doesn't make a lot of sense to support it there while it makes some sense to support some spreads in discriminateContextualTypeByJSXAttributes.

Hi friends, I also meet a jsx spread issue but am not sure whether it's related to this one and can @Andarist 's PR also fix it.
Here is example:
import React from 'react'

const Component = (props: { a: string }) => <input name={props.a} />

const renderedWithError = <Component a="123" b="will error" />  // error: Property 'b' does not exist on type

const attributes = {
    a: '123',
    b: 'will error'
}
const rendered = <Component {...attributes} />  // expect error but not

Output
import React from 'react';
const Component = (props) => React.createElement("input", { name: props.a });
const renderedWithError = React.createElement(Component, { a: "123", b: "will error" }); // error: Property 'b' does not exist on type
const attributes = {
    a: '123',
    b: 'will error'
};
const rendered = React.createElement(Component, Object.assign({}, attributes)); // expect error but not

Compiler Options
{
  "compilerOptions": {
    "strict": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "alwaysStrict": true,
    "esModuleInterop": true,
    "declaration": true,
    "target": "ES2017",
    "jsx": "react",
    "module": "ESNext",
    "moduleResolution": "node"
  }
}

Playground Link: Provided

This is not an issue. It's a normal (and correct) TS behavior. You can read more about it here.


Libs not included from compiler options

The Problem
Coc-tsserver does not seem to register compilerOptions.lib from local tsconfig.json.
Steps to reproduce

Create a tsconfig.json file populated with the following:

{
  "version": "2.0.2",
  "compilerOptions": {
    "module": "es6",
    "lib": [ "dom" ],
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "target": "es6",
    "noImplicitAny": true,
    "sourceMap": true,
    "outDir": "dist",
    "baseUrl": "./",
    "types": [ "chrome" ],
    "paths": {
      "*": [
        "node_modules/*"
      ]
    }
  },
  "include": [ "src/*" ],
  "exclude": [ "dist/*" ]
}

Create a file with the corresponding path of ./src/main.ts, populated with the following:

const el: HTMLInputElement = document.getElementById("someId");

Expected Action
No tsserver errors should occur
Actual Action
Tsserver throws the following errors:

[tsserver 2304] [E] Cannot find name 'HTMLInputElement'.
[tsserver 2584] [E] Cannot find name 'document'. Do you need to change your target library? Try changing the lib compiler option to include 'dom'.

Additional notes:
I did open the project up in VSCode, and there were no issues. Although I suspect that might be for other reasons, not related.

https://github.com/neoclide/coc-tsserver#troubleshooting


Adsense implementation policies ?

Have you gotten any feedback from the adsense team about violating policies with this script?
Adsense policies have change a bit in the last year so wondering if using this script is dangerous or not ?
Thanks
Chris

Yeah, I have the same question. 🤔

Asked on twitter got an awser "no problems" or something of the sorts... Can't seem to find the link to it...

Is it fine, not dangerous !


Add numbers to paper text for the 4x4 magma search

Adds the numbers to the paper text for the 3x3 and 4x4 magma brute force run. It resolves 13,632,566 implications with 524 distinct magmas.

I don't know how people write math papers and so don't know how much detail to put here about the implementation so I've just left it all out. If it would be worth including some explanation of what's going on for this search I can write that, but it's not super exciting.
(It does take a little bit of work because while it's "just" 10^9 equations tables, you have to run each of these over 4000 equations and checking each equation requires checking every assignment of variables. Doing this brute force would mean ~7*10^16 work.)
I also don't know how you all are handling authorship. I didn't do any of the interesting math so I've left my name off for now.

Thanks for the contribution!
Regarding authorship, following the discussion at https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Drafting.20the.20paper ,what we are doing is asking everyone who has made a non-trivial contribution to the project to submit a PR adding an entry for themselves in https://github.com/teorth/equational_theories/blob/main/paper/contributions.md with some brief commentary in the PR to explain the contributions.  We plan to have quite a broad set of authors in the end.  You can see some examples of previous PRs at #974 #913 #896 #891 #884.  Please feel free to submit such a PR, your contributions were certainly valuable!


Optimize lower()/upper() string function with ASCII fast path

Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/12306
https://github.com/apache/datafusion/issues/12306 has introduced the rationale for ASCII fast path in detail
This optimization has already been implemented on char_length() string function and got some performance improvement
(In PR https://github.com/apache/datafusion/pull/12356)
Describe the solution you'd like
Implement ASCII fast path for lower() and upper() function
Describe alternatives you've considered
No response
Additional context
No response

take

Hi @tshauck, are you working on this issue?

@thinh2 Sorry to leave you hanging. I got started but got busy. If you want to work on it, by all means.

thanks @tshauck . Let me try to do it.

Note that lower/upper likely already does this. See https://github.com/apache/datafusion/blob/f190fc6de6a6171c1cd6aa99233bc647ed8b1377/datafusion/functions/src/string/common.rs#L377 and https://github.com/apache/datafusion/blob/f190fc6de6a6171c1cd6aa99233bc647ed8b1377/datafusion/functions/src/string/common.rs#L400


Document how to pre-populate the catalog more clearly

[EDIT: This whole bug is a somewhat hilarious account of me not understanding what I'm doing.  There's no actual problem here, just jump to the last comment for the explanation.]
I've written the following in three different projects now and was wondering if something like it could be added alongside LocalSource and RemoteSource:
class InMemorySource(jschon.catalog.Source):
    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        self._registry = {}

    def __call__(self, relative_path):
        return self._registry[relative_path]

    def register(self, relative_path, schema_doc):
        self._registry[relative_path] = schema_doc

There are several use cases:

Sometimes I'm building/modifying schemas as Python data structures and they never live anywhere else
If you use URI schemes like tag, urn, or about for your "$id"s, the URI and filesystem (or network URL path) structures are less likely to correlate — it's easier to just manage separately
In higher-security environments, doing any sort of on-demand filesystem or (especially) network I/O on demand during a process like schema validation will not pass audit.  All I/O and parsing would be done up front with specific checks, which might not be easy to integrate into a Source even if doing them on-demand was considered OK
Performance is more consistent when no I/O is done during schema evaluation

Another wrinkle is that usually when I use this source I don't care about associating it with a base URI — I just want it to work for everything, which is not supported by the current Source interface.  And having an InMemorySource like this essentially serves as a manually populated cache for the catalog's automatically managed cache.  So perhaps a public interface to load schemas directly into the catalog would be a better option?  This would be distinct from Catalog.add_schema().
I'm not sure what the best design is here, I just know that it's my most common use case and feels like it involves too much boilerplate for something that's technically even more straightforward than the two supported sources.

OK so in the end all that happened here is that I assumed that since there was a tutorial for reference resolution that talked about Sources, that I needed a source even for an in-memory thing.
Of course this is not true, just instantiating a JSONSchema object caches it in the relevant catalog.  I'll look at the documentation and see if I think there's a way to make this a bit more clear for the workflow of pre-populating the catalog with all relevant schemas.
As usual with jshcon, in the end there is much less of a problem and a much easier solution than I initially feared. 😅 😁

...and I still don't know what I'm talking about.  I'm going to close this, and when I'm absolutely sure I know what I mean I will file an issue grounded in actual use cases and passing/failing tests.


Remove version: qBittorrent.qBittorrent version 4.5.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/qbittorrent-4.5.1/qbittorrent_4.5.1_lt20_qt6_x64_setup.exe/download
OK
(Automated message - build 923)

Close with reason: Package still available.;


fsp run 时出现错误

fsp run 的时候出现如下错误：
⠋ 配置读取完成(node:16680) UnhandledPromiseRejectionWarning: Error: Chromium revision is not downloaded. Run "npm install" or "yarn install"
    at Launcher.launch (/root/.nvm/versions/node/v12.12.0/lib/node_modules/font-spider-plus/node_modules/puppeteer/lib/Launcher.js:119:15)
    at async /root/.nvm/versions/node/v12.12.0/lib/node_modules/font-spider-plus/bin/index.js:148:33
(node:16680) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:16680) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

已安装 chromium……

应该是chromium没有下载成功，用cnpm装应该可以解决这个问题


When I use the splitcap tool to split a bi-directional stream of a vpn_hangouts_audio2 file, I run into an issue that reports an error saying that there is a problem with the magic number..

hello,When I use the splitcap  to split a bi-directional stream of a vpn_hangouts_audio2 file, I run into an issue that reports an error saying that there is a problem with the magic number which says System.IO.InvalidDataException: The stream is not a PCAP file. Magic number is A0D0D0A or A0D0D0A but should be A1B2C3D4.After i change the macgic number, the splitcap still didn't work.May I ask if you have encountered this problem.If you had ,can you tell me how to approach this?

You can try to rename "vpn_hangouts_audio2.pcap" as 'vpn_hangouts_audio2.pcapng" and use pcapng2pcap.py to convert this file and try the SplitCap again (In my impression, it seems to work like this. You can try it first).

OK！Thank you very much.I will try as soon as possible

sorry,it reports that "The file "./data1/VPN-PCAPs-02/vpn_hangouts_audio2.pcapng" contains record data that editcap doesn't support."

This is a temporary link to the vpn_hangouts_audio2.pcap file that you can use.
https://drive.google.com/drive/folders/1uBclitPTqj_wxka5kTsS7wZhstlgbOt6?usp=drive_link
Run "mono SplitCap.exe -r [YOUR_PATH]/vpn_hangouts_audio2.pcap -s session -o [YOUR_PATH] -p 1000"

OK!thank you


Incorrect error message when Thrift session is not found in DB

Description:

When thrift session with given ID is not found in DB, the exception contains an invalid error message.
The call to update last access time and remove session in DBThriftSessionDAO class throws IdentityException with incorrect message.
A pull request has been created to fix the issue here:
https://github.com/wso2-attic/carbon-identity/pull/1758
Since that repository has not been maintained for over 4 years, I am raising the ticket to review/merge the PR here. Please guide me if this is not the right place to report the issue.
Steps to reproduce:
A setup where WSO2 IS (5.7.0) is used as key manager for WSO2 APIM (2.6.0). The communication is set to works via thrift client.
The error was seen intermittently and disappeared after some time. Stacktrace is:
Thrift session with given Session Id already exists.
at org.wso2.carbon.identity.base.IdentityException.error(IdentityException.java:52)
at org.wso2.carbon.identity.thrift.authentication.dao.DBThriftSessionDAO.updateLastAccessTime(DBThriftSessionDAO.java:221)
at org.wso2.carbon.identity.thrift.authentication.internal.ThriftAuthenticatorServiceImpl.isAuthenticated(ThriftAuthenticatorServiceImpl.java:196)
at org.wso2.carbon.apimgt.keymgt.service.thrift.APIKeyValidationServiceImpl.validateKey(APIKeyValidationServiceImpl.java:103)
at org.wso2.carbon.apimgt.impl.generated.thrift.APIKeyValidationService$Processor$validateKey.getResult(APIKeyValidationService.java:379)
at org.wso2.carbon.apimgt.impl.generated.thrift.APIKeyValidationService$Processor$validateKey.getResult(APIKeyValidationService.java:367)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:32)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:34)
at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:176)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Affected Product Version:

APIM 2.6.0 with IS 5.7.0
Environment details (with versions):

OS: Ubuntu
Client:
Env (Docker/K8s): standalone instances

Optional Fields
Related Issues:

Suggested Labels:

Suggested Assignees:

Hi,
We do recommend to use WSClient for API Key validation. You can find the docs related to this in https://docs.wso2.com/display/AM260/Deploying+WSO2+API-M+in+a+Distributed+Setup#DeployingWSO2API-MinaDistributedSetup-Step6.1-ConfigureandstarttheKeyManager. From going forward from API Manager v3.0.0, we have switched default to WSClient.
I am closing the issue as we have a solution here. We don't have any plans to fix thrift related to issues in key validation as the production we use WSCLient and we have moved to WSCLient by default.
Thank you!
Pubudu.


Introducing FHIR audit service

Purpose
Check https://docs.google.com/document/d/1XcwN8oT_IZtcA4zjgM6oo2Oa8Umy4eaPqkkRDvKfFfU/edit#heading=h.kzr4iufn36kp

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(performance): removing tracers every hour

:tada: This PR is included in version 1.27.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


timeout with outlook mail server

Hi,
I'm trying to connect to outlook account to retrieve new emails.. using imap config, but I receive timeout error even when I'm trying to get one email!
my code was OK with gmail mail server, and I could get max 30 emails each time.. but with outlook I don't know what did I miss!
this is part of my code:
$client = new Client([
            'host'          => "outlook.office365.com",
            'port'          => 993,
            'encryption'    => "tls",
            'validate_cert' => true,
            'username'      => $username,
            'password'      => $password,
            'protocol'      => "imap"
        ]);

$client->connect();
$folder = $client->getFolder('INBOX');
$messages = $folder->query()->limit(1)->get();

Hi @maralbe ,
please ta a look at #100 and #189 .
Additional informtion:
https://docs.microsoft.com/en-us/exchange/troubleshoot/connecting-to-the-service/incorrect-settings

thanks for your reply @Webklex
my problem solved, but it wasn't because of the UTF-8 charset, in imap_search, actually I was getting the error while connecting to server not searching.. and it solved when I changed encryption from tls to ssl!
and now it works even without setting null for charset in imap_search.
$client = new Client([
            'host'          => "outlook.office365.com",
            'port'          => 993,
            'encryption'    => "ssl",
            'validate_cert' => true,
            'username'      => $username,
            'password'      => $password,
            'protocol'      => "imap"
        ]);

$client->connect();
$folder = $client->getFolder('INBOX');
$messages = $folder->query()->limit(1)->get();

thanks.


Driver error injection and handling

We now handle all kinds of errors in case a sensor fails.

Usage
If you want to simulate errors, pass a value between 0-1.0 to --error command line option.
A good value is 0.001 (error every 1000 reads)

Very good job overall, but if we are into simulating things, most of the errors happen when the sensors fail to even initialize themselves, how about a flag simulating this as well? could be useful

Very good job overall, but if we are into simulating things, most of the errors happen when the sensors fail to even initialize themselves, how about a flag simulating this as well? could be useful

I think it should be done in another issue, as it is another feature.


ENH: Adds weight reg alpha reduction with batches

Addresses https://github.com/jfkirk/tensorrec/issues/30
Also adds a nice convenience script to run through Movielens with all the loss functions

:shipit:


fix(docs): adds missing end of file new line

What
Adds missing end of file new line in README to test auto update functionality

:tada: This PR is included in version 0.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs: Add logo & split README file

Hi,
It's October and Hacktoberfest just started and I thought this year I'll go throw the repositories that I used during this year in my projects and see if there is any help I can offer. react-native-background-actions helped me in two projects this year as I found it a pretty good solution for running background tasks in RN after a long-term searching for a way to implement such a feature.
This pull request contains two additions to the documentations:
1- a simple logo for the repository as logos gives a high quality impression.
2- splitting the README file to multiple files with links to each file to help keeping things organize. too many information and code snippets in one long file causes the reader to lost track of what he should do to start using the package. splitting the README file to INSTALL and USAGE files will help solving this problem.
thanks for this package and hope you'll find this PR useful. 😀

@uptotec, thanks for the great PR, all the documentation looks very nice.

LGTM!


UI - Reports Dropdown should be refactored

The reports dropdown is a somewhat random list of issue searches.
It should be refactored to be more organized.
Idea:
Break it into multiple (3) dropdowns

Publicly Accessible
-- S3
-- SNS
-- KMS
-- SQS
-- ES
-- SG
-- ANY

Unknown Cross Account
-- S3
-- SNS
-- KMS
-- SQS
-- ES
-- SG
-- IAM Role Trust Policy
-- ANY

Top Issues (?? Misconfigured?)
-- Access Keys (active/inactive/unused)
-- CloudTrail (disabled/not multi-region)
-- ELB TLS Policies (Support SSLv3, old ciphers, etc)
-- SSL (Expired/Revoked, Poorly Created)
-- IAM sensitive actions (user/role/group/policy with things like iam:passrole)
-- VPC (Flowlogs not enabled)
-- SES (email/domain not verified)

Review the auditors for more.

We have some issues we're more worried about than others, so it would be nice to allow users to define their own "Reports" template.  Maybe have a default one in this code base, then make the location configurable in config-*.py.

I wonder if it makes sense to consolidate Unknown Cross Account into Top Issues instead of listing each technology. Is there interest in having Unknown Cross Account exploded per technology?

Maybe it could be related to #535.   After you select an issue score, you could also select whether the issue type should appear as a menu link (and under which heading).  (We have an additional feature where we'd like to select certain issues for special handling like filing a jira or calling out to pager duty.)
Good discussion.

Adding to this issue. The reports drop down doesn't scroll down for me even though once I inspect element I can see there are more options in dropdown available

fyi - as i move to a bigger screen , I can see the entire dropdown (of course)

Fixed in #757


Updated README.md

Dupe of #27 - which I just noticed this was first.
But, note the comment in #27. Either could be merged, or one could fix the casing on the text of the link.

Should have taken this if this was the earlier PR compared to #27. Sorry @pranjit-medhi

On a side note , for following PRs you can make pass using git commit -s

Done in other #27


ADTR workflow proposal

Please can ADTR release be expedited, as several studies require this and we would like to test as soon as possible, Thank you.

Hi All,
Please find 3 documents for review on BOX: https://exbpbox.ent.box.com/folder/154449333406:

ADTR workflow proposal
ADTR questions for discussion/ do add more
ADTR Roche spec - This spec is fairly new in our standards you will see there are some issues noted that will be discussed internally.

Please add comments directly in the word documents.

@pharmaverse/admiralonco , after adding comments to the word documents please add a short comment here regarding which document you commented on. Box does not generate notifications if the documents are changed or comments added.

@bundfussr can you give a bit more idea on how derive_vars_merged_summary() new function would look and what it would provide?
@HinalPat the workflow seems reasonable to me (from my limited knowledge of this ADaM) - look forward to hearing what the others think and whether it's robust for all our co-dev company needs.

@rossfarrugia , derive_vars_merged_summary() should be similar to derive_summary_records() except that the summarized values are not added as new observations but as a new variable.
For example, for the derivations of LSEXP for the TSD parameter something like the following could be called.
derive_vars_merged_summary(
  adtr,
  dataset_add = tu,
  filter_add = TUTESTCD == "TUMIDENT" & TUSTRESC == "TARGET",
  analysis_var = TULNKID,
  summary_fun = function(x) paste(x, collapse = ", "),
  new_var = LSEXP,
  by_vars = vars(USUBJID)
)

For each patient it concatenates the tumor ids of the expected target tumors and stores it in the new variable LSEXP.

I will also check workflow for ADTR next week..

Thanks @bundfussr! Maybe we can tag this example on to the core dev team discussion Wednesday around https://github.com/pharmaverse/admiral/pull/1484. I'm wondering if at times instead of adding more and more functions would it not be simpler just to have the user use 2 existing functions in conjunction, e.g. I guess the above could be achieved with a call to derive_summary_records() then derive_vars_merged(). You'll probably point me to many other examples where we already did it this way by creating a new function, but writing that Generic Functions vignette has got me reflecting, and I do worry that the learning curve for adopting admiral is only rising with every new function.

Technically you could use derive_summary_records() (or better get_summary_records()) and then derive_vars_merged(). But it would be hard to explain why for this derivation two function calls are needed but for others just a single one. And where would we store the information that two calls are needed, in the examples of derive_vars_merged() or in the examples of get_summary_records()?
I would prefer cleaning up admiral such that we remove overlaps and close gaps.

Fair, let's discuss Wednesday! i was thinking you'd just include these 2 calls in the ADTR template itself. It's a bit like the thinking behind how we do partial date imputations only in one place now and then use these in the functions as a next step. We could do similar with creating whatever you need (flag/summary/most extreme etc) from the additional dataset using one function, and then using one single merge function to add it to the original dataset. But we've probably gone too far now with adding many different variations of the "merged" functions, so your solution is probably cleaner at this stage.

@HinalPat @rossfarrugia @bundfussr I have reviewed the adtr workflow and provided the comments in file on box. Please have a look and we can discuss in out next call.

@amitjaingsk , thanks. I have added answers on some of your questions. We can discuss further tomorrow.


Caddy as web server

I noticed that there are only guides for Nginx and Apache (https://github.com/huginn/huginn/blob/master/doc/manual/installation.md#6-nginx) in the manual.
Is it possible to use Caddy as the web server for Huginn?

I am sure that it is possible. I did not test it myself, but this Caddyfile should work (I am not sure of the order of the rules, maybe the assets rule needs to be the first):
example.com {
    proxy / unix:/home/huginn/huginn/tmp/sockets/unicorn.socket {
        transparent
    }
    gzip
}
example.com/assets {
    root /home/huginn/huginn/public
    gzip
}

After some testing:
example.com {
    root /home/huginn/huginn/public
    proxy / unix:/home/huginn/huginn/tmp/sockets/unicorn.socket {
        except /assets/
        transparent
    }
    gzip
}


fix(type): there is no function 'clampData' error in 'getMarkerPosition'

fix no function 'clampData' error in 'getMarkerPosition'  method of BaseBarSeriesModel

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?
fix no function 'clampData' error in 'getMarkerPosition'  method of BaseBarSeriesModel
Fixed issues
Issues 15109
Details
Before: What was the problem?
In that example will generate an error message of 'clampData is not a function'
After: How is it fixed in this PR?
Add an additonal judgement on 'clampData'
Misc

[ ] The API has been changed (apache/echarts-doc#xxx).
[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
NA.
Others
Merging options

[ ] Please squash the commits into a single one when merge.

Other information

For further improvements. We need to implement clampData in the polar coordinate system as well.


Pylance/pyright is not running in IPythonMode

Applies To

[X] Notebooks (.ipynb files)
[X] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
I wrote a notebook that uses a top level await, which is allowed in ipython jupyter notebooks.
However, pylance warns me about an error that is not relevant:
"await" allowed only within async function Pylance

But if I read the source code of pyright, I can see that pyright has an IPythonMode boolean to not wrongly trigger this error.
I'm not an expert at all in python or jupyter, but it seems that the IPythonMode is not set to true when running in vscode-jupyter.
VS Code Version
Version: 1.68.0 Commit: 4af164ea3a06f701fe3e89a2bcbb421d2026b68f Date: 2022-06-08T11:43:24.900Z (1 wk ago) Electron: 17.4.7 Chromium: 98.0.4758.141 Node.js: 16.13.0 V8: <IP_ADDRESS>-electron.0 OS: Darwin arm64 21.5.0
Jupyter Extension Version
v2022.5.1001601848
Jupyter logs
/

Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
N/A or Not sure

with https://github.com/microsoft/pyrx/pull/2570, regardless which experiment group you are in, it should work as expected in next release.

This issue has been fixed in version 2022.7.21, which we've just released. You can find the changelog here: CHANGELOG.md

Thanks 😊


[Feature]: Add example dataset for users to upload to try to tool and to inspect the json output

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Description
Reviewer Said: I find your video tutorial very nice and good to follow. Additionally, I think it would be nice if you'd also have a folder of example data with which new users could directly follow your tutorial. Maybe even with a post-processing example of json data.
Problem
Users may not have access to large datasets of trash images or may want to debug or inspect the json before using the tool.
Proposed Solution
Create an OSF database full of images that a users could upload to the tool to test it and download cache the output of the tool so that users can compare and inspect the output.
Alternatives Considered
Expect users have data already and will use the tool without inspection.

I think this is already done @wincowgerDEV .  When you haven't uploaded any images, there's a "Show Samples" button.

Yup, good catch, closing this issue.


Merge develop to main

I know we have a few changes to the resources that we still plan to make before a numbered release, but let's get all of these quality-of-life fixes out there.  Thanks @juniper-lake for all of the work testing these.

starting to document changes:

Moved small single-threaded tasks to localrules
Updated DeepVariant to v1.3.0
Updated htslib tools to v1.14
Modified input regex to match upgraded Sequel IIe instruments
Explicitly set the memory for GLnexus
Fail on missing cohort id
Prevent divide-by-zero errors in calculations involving coverage
Improvements to setting/using TMPDIR
Don't chunk assembly for alignment
pbsv parameters can be modified in config.yaml
add triobinned assembly for trio kids

Other changes:

updated tutorial
moved resource specification from cluster.yaml files to profiles + rules
added example launch scripts for LSF and local execution
fixed bug preventing singularity TMPDIR specification
added yak trioeval rule to assess trio assembly errors
added CPU-only option for DeepVariant


WIP: try close and hover style for X

@amangoel185 feel free to add to this PR to polish and find some styles/icons that look good. But it does generally seem to work.

In reference to #12


Feature Requests

Hi,
We're using this plugin at our workplace as a replacement for the previous Jira DVCS connector. Got in touch with @andymckay for how to automatically trigger workflows from Github other than using 'smart commits'.
Primarily we are looking for deeper integration between Jira Workflows and Github actions.
More specifically, It'd be interesting if we could see some of the below features:-

Closing a Jira Issue by closing a PR on Github which has that Issue# (can be a setting)
Moving a Jira issue to "in progress" if a branch or commit has an issue# (and it was previously in todo)
Moving a Jira issue to "testing"/"in review" if a PR is opened for that issue# (and it was previously todo/in progress)
Automatically highlight Jira Issue IDs in Github and make them clickable links. If it's not possible (for example in a PR title), it could even just be an additional field/button somewhere that says "open in Jira"
Create/Delete branch from JIRA

Wondering if someone from the team could let me know if any of these are currently being looked into? Or are on the roadmap.

Hey @PuneetKohli! We do not have anything formal to share currently, but there are some new features on the roadmap for both Jira and GitHub that should enable some of these. I like the idea of making some of these configurable options. One idea I had around this is using probot-config, so a repository owner could opt in to certain features. The initial release was aimed primarily at getting feature parity with the DVCS connector, so I'm thinking that anything we add beyond that like other ways to trigger transitions should be something a user can opt in to.
Also we welcome any PRs from users of the integration. I'm definitely willing to offer any review and get things deployed if users are interested in adding the features. Check out the contributing guideliens if you'd like to give it a go.
I'll update this issue when we have more information to share about new features.

I agree with your idea of having them as opt-in features. Thanks for sharing the contributing guidelines, will definitely see if I (or a co-worker) would be interested to contribute alongside our full-time roles.
Thanks!

Hi @PuneetKohli. I'm from a team at Atlassian that is currently in the process of migrating the ownership over to us from GitHub. As a part of this, we're currently going through the backlog of issues and prs to see what can still be addressed and what should be closed.
I've flagged this with the 'to-triage' label so my team can discuss. We'll keep you posted on the status of this.

Hi, have you tried to use Automation to accomplish the same effects? This is a far more powerful mechanism that workflow triggers and the preferred mechanism for DevOps automation.

Hey @PuneetKohli. As we haven’t heard from you in a while, I’m going to go ahead and close this issue. Please feel free to reopen if you still require assistance.


Remove creation of Instance profile & Role if not specified

Remove creation of Instance profile & Role if not specified.
The instanceProfile field in the aws providerConfig is now a required field.
NONE

/lgtm
/approve

/lgtm

/lgtm


__resolveType resolver doesn't return the correct type returns its own type instead

There seems to be an issue on interfaces on apollo link state
instead of me getting a JobSeeker or Employer type it returns a User type instead
here is the snippet of the code
const roles = {
  employers: 'Employer',
  jobseekers: 'JobSeeker'
};

  User: {
    __resolveType: user => roles[user.role],
    name: ({ name = '' }) => name
  },

Any chance you provide a small runnable reproduction that demonstrates this?

I see you provided more details in https://github.com/apollographql/apollo-link-state/issues/316. Closing here.


tart: init at 0.32.1

Description of changes
https://github.com/cirruslabs/tart
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

0.5.0 has been released, and so this PR has been changed to init at that version

tart 0.6.0 has been released, and so this PR has been changed to init at that version

tart 0.7.0 has been released, and so this PR has been changed to init at that version

tart 0.12.0 is out, this PR been updated to that version

tart 0.14.0 is out, this PR been updated to that version

Can you please update to latest version.

@ck3d updated :)

Thanks for the update. During my first look to your PR I missed to recognize that you install a pre-compiled binary. We should always build from source but I have no experience with Swift in Nixpkgs.

Rebase on top of master, and there is a new version available to download.

@smancill thanks for that feedback. I've updated :)

@smancill thanks :) I've rebased, and resolved the whitespace issues

0.32.1 has been released, this PR has been bumped to that version.

What was the reason this PR was closed? I'm interested in tart as a nix pkg. Willing to contribute a PR with these changes as a starting point if someone can confirm.

@Murderlon Tbh it is a boring reason for closing. The need for my use of tart ended (more so paused for an undetermined amount of time). Happy if you'd like to take it over. I think one important change (other than a more recent version) is the updated license.

I've revived this PR for v1.5.0 at #237895


NimBLEClient not processing passkey correctly

It appears that NimBLEClient does not process the passkey correctly for the client callback cases.
           ```
          // Compatibility only - Do not use, should be removed the in future
            if(NimBLEDevice::m_securityCallbacks != nullptr) {
                pkey.passkey = NimBLEDevice::m_securityCallbacks->onPassKeyRequest();
            /////////////////////////////////////////////
            } else {
                client->m_pClientCallbacks->onPassKeyRequest(); // <-- bug here , passkey not assigned to anything
            }

The bold line above should be: pkey.passkey = client->m_pClientCallbacks->onPassKeyRequest();

Actually this [revision ](https://github.com/h2zero/NimBLE-Arduino/commit/1aeb2fed80f64a430d26f1537b9f5811fe33a294#diff-8f692c893f6a420d294d6426dcac9a9c) has a better implementation, which for some reason was removed from the master.

My apologies if I am completely off base!

Thanks for reporting this!
Looks like it's been that way for a long time, introduced this bug when I implemented default callback methods.
Pushing the fix right away.


Change to __builtin_readcyclecounter

Removes an #ifdef on amdgcn version. Need to check what it expands to (hopefully memrealtime) and still need to work out what scaling factor to use to map the result onto seconds.
edit: Seems to be expanding to s_memtime, not s_memrealtime.

Implemented in amd-llvm-project/pull/55, though we should revisit using s_memrealtime later. Perhaps at the same time as working out what the right scaling factor is.

We have a smoke test (schedule) which is fragile with respect to the wtime implementation. Maybe overflows? Doesn't fail for me. That got #55 reverted.
I think we should use readcyclecounter and fix the test. This means get_wtime will use memtime, instead of the more precise memrealtime, until such point as llc targets memrealtime. There's a comment  in SIISelLowering.cpp,
// On SI this is s_memtime and s_memrealtime on VI.
setOperationAction(ISD::READCYCLECOUNTER, MVT::i64, Legal);

which suggests that will be the case at some point in the future, unless there's a problem with memrealtime in which case it's OK that we aren't using it.

Jon, Are we expecting something to be fixed in LC (llvm/lib/Target/AMDGPU) for this ticket?  Please explain in detail so Poorna can the the work scheduled by them.

Not particularly expecting it to be fixed. Don't know of a ticket - would be 'llvm.readcyclecounter should lower to s_memrealtime when supported by the target'.
We have two intrinsics for measuring time. s_memtime is available on lots (all live?) hardware but changes with chip frequency / temperature. s_memrealtime is gfx800ish to present and frequency independent.
The quote above suggests readcyclecounter used to lower to the best one available. At present, it actually always lowers to s_memtime. I don't know why/when that changed. Maybe s_memrealtime has limitations I don't know about.
OpenMP used to check the gfx version string to pick the newer instruction when available, but amd-stg-open rejected that. So now we use the llvm builtin, which always lowers to the baseline.
I think losing capability from aomp to reduce the delta from amd-stg-open is the wrong choice. We should carry the patch until llc fixes isel for readcyclecounter, then change over. I didn't want to have that fight for omp_wtime though, too much else going on.

[AMD Official Use Only - Internal Distribution Only]
The one function that needs this, is still selecting instructions based on a specific test for
Gfx70[012]  , we just restructured it to not have to worry too much about newer gfx definitions.
So I  think we are using the newer instruction when we can.
DEVICE double __kmpc_impl_get_wtime() {
+#if gfx700 || gfx701 || gfx702
uint64_t t = __builtin_amdgcn_s_memtime();
+#else

uint64_t t = __builtin_amdgcn_s_memrealtime();
#endif
return ((double)1.0 / 745000000.0) * t;
}

From: Jon Chesterfield<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 7:00 AM
To: ROCm-Developer-Tools/aomp<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [ROCm-Developer-Tools/aomp] Change to __builtin_readcyclecounter (#98)
[CAUTION: External Email]
Not particularly expecting it to be fixed. Don't know of a ticket - would be 'llvm.readcyclecounter should lower to s_memrealtime when supported by the target'.
We have two intrinsics for measuring time. s_memtime is available on lots (all live?) hardware but changes with chip frequency / temperature. s_memrealtime is gfx800ish to present and frequency independent.
The quote above suggests readcyclecounter used to lower to the best one available. At present, it actually always lowers to s_memtime. I don't know why/when that changed. Maybe s_memrealtime has limitations I don't know about.
OpenMP used to check the gfx version string to pick the newer instruction when available, but amd-stg-open rejected that. So now we use the llvm builtin, which always lowers to the baseline.
I think losing capability from aomp to reduce the delta from amd-stg-open is the wrong choice. We should carry the patch until llc fixes isel for readcyclecounter, then change over. I didn't want to have that fight for omp_wtime though, too much else going on.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FROCm-Developer-Tools%2Faomp%2Fissues%2F98%23issuecomment-633980445&data=02|01|ron.lieberman%40amd.com|c14b5e2f860149c2504c08d8016c450f|3dd8961fe4884e608e11a82d994e183d|0|0|637260911818820785&sdata=79e6qcP%2FQbafnKEf0jTGEXEWsNQr5B%2BqgG8vVT%2FSvfM%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD3EYZZTM6F2U6EXW5LQFV3RTOVKXANCNFSM4MNQF2IQ&data=02|01|ron.lieberman%40amd.com|c14b5e2f860149c2504c08d8016c450f|3dd8961fe4884e608e11a82d994e183d|0|0|637260911818820785&sdata=jUnAQ4lGuAzdldhC5P4jURrRrpUEEBqvY6%2FGOle5yT0%3D&reserved=0.

Ah, I'm out of date then. The multiple checks is not pretty but at least we haven't regressed at runtime.

It has been a year since readcyclecounter changed.  See LLVM review D64369.  Note that the rmemrealtime frequency is quite low, especially compared to memtime.  One can also argue that memtime better matches the expectations of a cyclecounter.

Thanks for the link. It doesn't have much rationale though - was there a problem with memrealtime? Frequency independence seems an important property for a cycle counter.
I haven't been able to find a frequency for either. Measuring suggested 25MHz for memrealtime on a vega 20. D75581 is stalled on not knowing what the right frequency is and reluctance to hardcode one from my local machine.

From my perspective, frequency independence is not an important property for a cycle counter.  There is a big difference in asking for the number of actual cycles and the number of seconds.


Add sortDesc method in collection support

There is already method sortByDesc in Collection class.

@zholus sortByDesc method need parameter and it is the sort of key

@taylorotwell why closed my pull request?


Conflicting dependencies on Raspbian GNU Linux version 11 (Bullseye)

I was able to successfully run the installation on Raspbian GNU Linux version 10 (Buster).
But when I try the exact same installation script on the latest Raspberry Pi OS (GNU Linux version 11 - Bullseye) it crashes.
Looks like a simple python package dependency issue, but I am not savvy enough to understand how to fix it.
Describe the problem
Getting the following error message:
ERROR: Cannot install -r /home/pi/SlowMovie/Install/requirements/txt (line 5) and waveshare-epd 0.0.0 (from git+https://github.com/waveshare/e-Paper.git#egg=waveshare-epd&subdirectory=RaspberryPi_JetsonNano/python) because these package versions have conflicting dependencies.
The conflict is cause by:
The user requested waveshare-epd 0.0.0 (from git+https://github.com/waveshare/e-Paper.git#egg=waveshare-epd&subdirectory=RaspberryPi_JetsonNano/python)
omni-epd 0.2.4 depends on waveshare-epd 0.0.0 (from git+https://github.com/waveshare/e-Paper.git#subdirectory=RaspberryPi_JetsonNano/python&egg=waveshare-epd)
To fix this you could try to:

loosen the range of package version you've specified
remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResulotionImpossible: for help visit https://pip.pypa.io/latest/user_guide/#fixing-conflicting-dependencies
Steps to Reproduce
Install latest Raspberry Pi OS from scratch (Bullseye)
Launch automatic SlowMovie installation:

bash <(curl https://raw.githubusercontent.com/TomWhitwell/SlowMovie/main/Install/install.sh)

Platform Information
RaspberryPi Zero 2W
OS = Raspbian GNU/Linux version 11 (Bullseye)
Python3 = 3.9.2

Looked more closely at the details and was able to fix the problem.
It is a very minor fix to be applied to the file 'SlowMovie/Install/requirements.txt'
I has to do with the order in which # arguments are specified.
I suspect that with RaspberryPi OS 11 (bullseye) the requirements verification got a tad more strict than before. OS 10 (buster) did not complain about the order mismatch, but 11 (bullseye) does...
Here is the fix for the Automatic Installation.
requirements.txt
Step 1 - Initiate automatic installation

bash <(curl https://raw.githubusercontent.com/TomWhitwell/SlowMovie/main/Install/install.sh)

Step 2 - Manually edit requirements file
Manually edit file 'requirements.txt' located in folder SlowMovie/Install
Edit 4th line to read as follows:
git+https://github.com/waveshare/e-Paper.git#subdirectory=RaspberryPi_JetsonNano/python&egg=waveshare-epd
It is a very easy edit (switching the order of the #subdirectory and #egg portions of the line.)
Attaching the fixed requirements.txt file as reference.
Step 3 - Re-Run the installation locally this time
> bash SlowMovie/Install/install.sh
Select option 1
Step 4 - Re-run installation locally for the service portion
> bash SlowMovie/Install/install.sh
Select option 2
That's it!

Thanks so much for the fix, I just got this error too doing this project for the first time and it fixed it too! Thanks, I love this project.

Nice work hunting this down. That's interesting that these are seen as two different versions just based on the URL like that.


The setting value of SVG angle for web page preview does not take effect, and the PDF preview effect is normal

The setting value of SVG angle for web page preview does not take effect, and the PDF preview effect is normal

Hello!
I have created a task
Best regards
Marat

Hello! This bug was fixed


Upgrade mongo libs

Upgrade mongo library and tools version.
Now it supports ssl and ReadPreference option can be passed via conn string.

/lgtm


[Renderer] Ragdoll studio models are not rendered after cl_corpse message

https://user-images.githubusercontent.com/3608544/193424359-eb47b06c-c611-4934-ba5e-79c366288525.mp4

https://user-images.githubusercontent.com/3608544/193623821-3c23eb28-32e2-4cc1-b577-15bb9ab6c2b7.mp4

https://user-images.githubusercontent.com/3608544/194723497-41ed3c99-68a4-47e4-a316-aec51403beeb.mp4

How to repro the bug?

It seems it only happens on dedicated servers and not always.

Tested. Apparently it happens on older server versions. You can test on cs.evogames.ro and cs.oldgods.ro

Ignore the last 2 replies. Further testing concluded that it's a map based problem. It can be reproduced on fy_snow for example and on both listen and dedicated servers.

Disabling renderer plugin fixes this problem.

Update: neither decals or sprites are drawn too. It seems it's a map zone based problem(probably related to https://github.com/hzqst/MetaHookSv/issues/172 / https://github.com/hzqst/MetaHookSv/commit/4b8c9c27f3edb6773e018d761cbc9ee6f8d6284e fix?). If you go in certain zones, issue is not present. Example:
https://user-images.githubusercontent.com/3608544/217622671-7a574143-946a-4629-b0c1-d5437c5cfc76.mp4

Update: neither decals or sprites are drawn too. It seems it's a map zone based problem(probably related to #172 / 4b8c9c2 fix?). If you go in certain zones, issue is not present. Example:
unknown_2023.02.08-20.30_1.mp4

Have you tried latest build?

Yup
https://user-images.githubusercontent.com/3608544/217811314-ac3e7b2b-84cb-4de5-95d5-6eaaa44b1690.mp4

Confirming fix and closing issue.


Need Wildcards or Match by Top Domain

I notice a lot of spammers are using throwaway subdomains on the same TLD, so something like:
bad1.spam.cc
bad2.spam.cc
The problem there is we have to update the list every time, instead of just blocking spam.cc in the email checker list we have setup...

Perhaps something like this?
function strposa($haystack, $needle, $offset=0) {     if(!is_array($needle)) $needle = array($needle);     foreach($needle as $query) {         if(strpos($haystack, $query, $offset) !== false) return true; // stop on first true result     }     return false; }
from https://stackoverflow.com/questions/6284553/using-an-array-as-needles-in-strpos


[scripts] Move musl files to appropriate directory

Related #135
Moved musl files that were on a inappropriate directory to a more appropriate one and edited the paths in the gen_config_pre.cmake file

P.S. [optional] If you want to add more details, just leave the 2nd line as empty and add a commit description starting from the 3rd line. The head line is not supposed to tell everything about a commit ;-)

Thanks and sorry for this incovenient problem, you could also make a specific section in the contributing.md on the commit message side so that you have a starting point for new contributors, or maybe there is another file containing this information that I haven't seen, in case let me know.

Thanks and sorry for this incovenient problem, you could also make a specific section in the contributing.md on the commit message side so that you have a starting point for new contributors, or maybe there is another file containing this information that I haven't seen, in case let me know.

Thanks for the fix. Yeah, I'll definitively add a section in the contributing.md file. The problem is that it's very hard to explain in general terms (e.g. with rules) how to write a good commit message. I'll do my best mentioning the pre-existing tags, the idea of adding a reference to an issue (if any) etc., but that will not be exhaustive. It just takes time and experience to learn how to write a good commit message, in addition to domain knowledge on the specific project of course.


Question : Is it possible to convert a file with that library?

Hello, I'd like to know if that library allows to convert audio files between formats. If so, is there any documentation?
Thanks in advance.

Hi.
Yes. However,  you will only be able to create files that winRT supports.  Our library is decoding only,  no custom converter support,  but you can use builtin winRT apis.
See
https://github.com/ffmpeginteropx/FFmpegInteropX/discussions/256

Hello, my apologies for the delayed response.
How would I decode a file for usage with an encoder? I am using that library: https://github.com/SteveLillis/.NET-Ogg-Vorbis-Encoder to encode the file to ogg.
Thanks in advance.

Currently, the only way to do transcoding is via winRT, using this class: https://docs.microsoft.com/en-us/uwp/api/windows.media.transcoding.mediatranscoder?view=winrt-22621 and this method https://docs.microsoft.com/en-us/uwp/api/windows.media.transcoding.mediatranscoder.preparemediastreamsourcetranscodeasync?view=winrt-22621#windows-media-transcoding-mediatranscoder-preparemediastreamsourcetranscodeasync(windows-media-core-imediasource-windows-storage-streams-irandomaccessstream-windows-media-mediaproperties-mediaencodingprofile)
There is no known way of using this trivially to transcode with other libraries, and quite frankly it would probably be easier to just implementing transcoding within this library instead of trying to adapt to others

I finally solved the problem using MP3Sharp (to decode) and Ogg-Vorbis Encoder to encode again. It works like a charm, it's fast and seems reliable.
All using Stream, so there is no problem with the file access permissions.


Better install instructions

You current instructions is good. But we could do better :).
People will use your tool, then they have some problem in existed build tool. So, they already use some tool: grunt-postcss, gulp-postcss, postcss-loader or postcss-cli.
You should give a install instructions in this way:
postcss-cli

If you have postcss-cli
Install postcss-debug
Replace postcss-cli to postcss-debug in you scrips.

gulp-postcss

If you use Gulp with gulp-postcss
…

@ai Would you say it's ok for now as it is?
(Added a little more documentation yesterday)

Better. But best way will be just a diff — ”replace this to this” (sorry, that I only write bad things, I am Russian we always only talk only about bad things, you do great work, really fast development).

No problem, since it's constructive. I just think it's hard to provide a diff, since PostCSS can be used in so many different ways and setups. And there is some chance people will prefer using the CLI for debugging instead of changing the build process, anyway, I guess.
I re-edited the gulp-postcss example slightly to make it more clear what to change, though.

Yeap, but we can provide diff for easy and popular cases and have API for other cases :)


Add CBOR as a storage format for the JSON data type

In this PR, CBOR is used as a storage format alternative (written to/read from hard drive) for the JSON data type (RedisJSON).
CBOR (RFC 8949) is a binary data format compatible to the JSON data model, hence it has more efficient encoding/decoding performance and more compact data size.
From my observation and simple benchmark, using CBOR instead of JSON as a storage format and JSON document testing datasets from RedisJSON, kvrocks speed up its performance of JSON.GET and JSON.SET by ~5%, and its storage usage is reduced by more than 10%.
NOTE: The default storage format of JSON data type is still JSON.

kvrocks speed up its performance of JSON.GET and JSON.SET by ~5%, and its storage usage is reduced by more than 10%.

wow, that's cool


Update tutorial.md

I came here to make the same change and see you beat me to it. This fixes a formatting error in the tutorial Markdown:


oraswdb-install: Options in oracle executable are configurable for 12.2

The licensed options in the Oracle binaries are configurable.
The following variable could be used to change the default:
oracle_EE_options_122:
- {option: oaa          , state: !!str "disable" }
- {option: olap         , state: !!str "disable" }
- {option: partitioning , state: !!str "disable" }
- {option: rat          , state: !!str "disable" }
To activate an option set state to 'enable'.
More details could be found in Doc ID 948061.1
The task only changes an option, if a file for
$ORACLE_HOME/install/<enable|disable>_.log is not existing!

First of all, thanks for this! Secondly, sorry about the late reply:
Question:

Is there a way to change the !!str "disable" to a simple disable instead? It looks messy.
If the string actually have to look like that, doing some jinja conversion in the background should work?

I could change the task itself. This makes the task messy but the configuration itself looks clean.
I'll try it and correct the PR so it has no conflicts anymore.


Error Creating Key Vault For Azure Stack ADFS Environment

Bug Report
Error thrown from here:
https://github.com/Azure/azure-sdk-for-go/blob/292117ae0883b3b8a8b2e2a06648e7ef09edc99e/services/keyvault/mgmt/2019-09-01/keyvault/vaults.go#L186
Error:
2022/01/12 17:28:56 azure.BearerAuthorizer#WithAuthorization: Failed to refresh the Token for request to <ARM endpoint URL>/subscriptions/<subscription Id>/resourceGroups/azure-sample-golang-keyvault/providers/Microsoft.KeyVault/vaults/azure-sample-keyvault?api-version=2019-09-01: StatusCode=404 -- Original Error: adal: Refresh request failed. Status Code = '404'. Response body: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">
<TITLE>Not Found</TITLE>
<META HTTP-EQUIV="Content-Type" Content="text/html; charset=us-ascii">

Not Found

HTTP Error 404. The requested resource is not found.

 Endpoint <ARM endpoint>/<tenant Id>/oauth2/token?api-version=1.0

go.mod file:
module keyvault

go 1.17

require (
	github.com/Azure/azure-sdk-for-go v61.1.0+incompatible
	github.com/Azure/go-autorest/autorest v0.11.24
	github.com/Azure/go-autorest/autorest/adal v0.9.18
	github.com/Azure/go-autorest/autorest/to v0.4.0
	github.com/gofrs/uuid v4.2.0+incompatible
)

require (
	github.com/Azure/go-autorest v14.2.0+incompatible // indirect
	github.com/Azure/go-autorest/autorest/date v0.3.0 // indirect
	github.com/Azure/go-autorest/autorest/validation v0.3.1 // indirect
	github.com/Azure/go-autorest/logger v0.2.1 // indirect
	github.com/Azure/go-autorest/tracing v0.6.0 // indirect
	github.com/golang-jwt/jwt/v4 v4.2.0 // indirect
	golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3 // indirect
)

Golang version: go1.17.6
The error above occurred when creating Key Vault in Azure Stack ADFS environment. I used the tenant UUID as the tenant Id. Usually for ADFS environments, "adfs" is used. Sample usage code:
https://github.com/Azure-Samples/Hybrid-Golang-Samples/blob/03824a553017f2e3dbc63c3b498ad20a2888896e/keyvault/hybridkeyvault/keyvault.go#L41
Note that this bug might be related to the solution of this other bug that I created:
https://github.com/Azure/azure-sdk-for-go/issues/16819

Have you tried your code with the latest resource manager sdks?
https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/resourcemanager/keyvault/armkeyvault

Hi @RickWinter, we usually don't use the latest SDK resource manager versions for Azure Stack. Profile versions are used for Azure Stack according to this documentation:
https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-version-profiles-go?view=azs-2108

Related with this issue.

@TheOnlyWei It seems related to auth progress. Could you please paste the auth code here?

@tadelesh The auth is also in the sample:
Getting Key Vault Client
https://github.com/Azure-Samples/Hybrid-Golang-Samples/blob/03824a553017f2e3dbc63c3b498ad20a2888896e/keyvault/hybridkeyvault/keyvault.go#L21
Getting Token
https://github.com/Azure-Samples/Hybrid-Golang-Samples/blob/03824a553017f2e3dbc63c3b498ad20a2888896e/keyvault/iam/oath.go#L28

@TheOnlyWei Have you tried to use "adfs" to check whether the token fresh step is success?

@tadelesh that is what I am using.
https://github.com/Azure-Samples/Hybrid-Golang-Samples/blob/03824a553017f2e3dbc63c3b498ad20a2888896e/keyvault/app.go#L59

@tadelesh Seems passing "adfs" as tenant ID resolved the issue. So for that function I needed both versions of tenant ID, the "adfs" string and the tenant UUID. Still not sure why we need both versions, which is related to the issue https://github.com/Azure/azure-sdk-for-go/issues/16819.
https://github.com/Azure-Samples/Hybrid-Golang-Samples/blob/80fc40684cc0b4c0ede358cbc2872b67b53c679c/keyvault/hybridkeyvault/keyvault.go#L33

@TheOnlyWei Thanks for the feedback. We may continue with the discussion of discrepancy at #16819.


Make a release

Find out how to make a release, (.apk) and description how to install (developer options may need to be enabled)

https://github.com/M-Yankov/SimpleTracker/releases


Correcting Migrate Licensing typo from "2012 R2" to "2016"

Addressing Issue made by customer: https://github.com/MicrosoftDocs/windowsserverdocs/issues/1547


Remove version: Insco.FaFaRunner version <IP_ADDRESS>2

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/fafarunner/fafarunner/releases/download/v1.0.1+362/fafarunner_1.0.1+362_windows_x64_en-US.msi
OK
(Automated message - build 923)

Close with reason: Package still available;


smol refactor + slash commands

bot basedness increased from JavaCringe to based snek

Lbtm (I hate snek)

Interesting concept however rewrite it in rust

this still isn't written rust but i suppose it works for now.


Deployment fixes for mainnet

What does this pull request do? Explain your changes. (required)

Update mainnet Inbox address in ARBITRUM_CONTRACTS to be the Delayed Inbox address instead of the Sequencer Inbox address [1]. The Rinkeby Inbox address was correctly updated to the Delayed Inbox address awhile ago, but the mainnet Inbox address was never properly updated until now
Use hardcoded L1 BridgeMinter address for contracts that depend on it (i.e. L1LPTGateway, L1Migrator) when deploying on mainnet because the BridgeMinter is not registered with the L1 Controller yet so its address cannot be fetched from the L1 Controller at this point
Re-deploy L1LPTGateway, L1Migrator and L1LPTDataCache to use the correct Delayed Inbox address on mainnet. Also re-deployed L1Escrow

[1] https://developer.offchainlabs.com/docs/useful_addresses
Specific updates (required)

See commit history.
How did you test each of these updates (required)

Manual.
Does this pull request close any open issues?

Checklist:

[x] README and other documentation updated
[x] All tests using yarn test pass

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
281

Relevant Lines:
281

💛  - Coveralls


Suggest etymology for new names if identical names were already proposed

Propagate the etymology for newly entered species epithets names if they are identical to those present in the registry. We can curate the set of standard translations or have the existing once populating etymology table. This will speed up curation process and avoid manual entering of identical etymologies. Example: L. gen. n. soli, of soil

Hi @uqmchuvo . I believe this is already implemented (if I understand the request correctly).
Try creating a species name with that epithet, set the rank to species, and then go to Edit etymology and click "Automatically fill the etymology". It should already fill-up the etymology.
It also works with compound words. For example, try using poriticola instead of soli.
I'll close it now, but please feel free to reopen if you meant something different.

Nice, it works!
One small comment: I think that it is OK to be able to pre-fill it even if the rank wasn't confirmed yet...spelling won't change and rank confirmation can be done after. Any reasons to have this prerequisite for rank confirmation before autofilling the etymology? :)
Thanks!


rs.DataSet constructor doesn't populate _cache_index_dtypes

The following minimal snippet illustrates how to reproduce the issue. If a DataSet is constructed without an explicit index object, the constructor won't populate self._cache_index_dtypes. This has a lot of nasty side effects, and exposes users to some pretty cryptic error messages.
import reciprocalspaceship as rs
import numpy as np

inFN = 'reciprocalspaceship/tests/data/algorithms/HEWL_SSAD_24IDC.mtz'
mtz = rs.read_mtz(inFN)

mtz = rs.DataSet({
        'I' : mtz['IMEAN'],
        'SigI' : mtz['SIGIMEAN'],
    },
    cell = mtz.cell,
    spacegroup=mtz.spacegroup
)

The issue that tipped me off to this pathology was when i tried to call DataSet.infer_mtz_dtypes.
Traceback (most recent call last):
  File "dtypes_bug.py", line 16, in <module>
    mtz.infer_mtz_dtypes()
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 38, in wrapped
    return f(ds.copy(), *args, **kwargs)
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 658, in infer_mtz_dtypes
    self.reset_index(inplace=True, level=index_keys)
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 271, in reset_index
    _handle_cached_dtypes(self, columns, drop)
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 265, in _handle_cached_dtypes
    dtype = dataset._cache_index_dtypes.pop(key)
KeyError: 'H'

Explicitly passing an index to the constructor doesn't solve the issue. I thought it would, but it doesn't:
import reciprocalspaceship as rs
import numpy as np

inFN = 'reciprocalspaceship/tests/data/algorithms/HEWL_SSAD_24IDC.mtz'
mtz = rs.read_mtz(inFN)

mtz = rs.DataSet({
        'I' : mtz['IMEAN'],
        'SigI' : mtz['SIGIMEAN'],
    },
    cell = mtz.cell,
    spacegroup=mtz.spacegroup,
    index=mtz.index,
)

mtz.infer_mtz_dtypes()

Traceback (most recent call last):
  File "dtypes_bug.py", line 17, in <module>
    mtz.infer_mtz_dtypes()
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 38, in wrapped
    return f(ds.copy(), *args, **kwargs)
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 658, in infer_mtz_dtypes
    self.reset_index(inplace=True, level=index_keys)
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 271, in reset_index
    _handle_cached_dtypes(self, columns, drop)
  File "/home/kmdalton/opt/reciprocalspaceship/reciprocalspaceship/dataset.py", line 265, in _handle_cached_dtypes
    dtype = dataset._cache_index_dtypes.pop(key)
KeyError: 'H'

Yep -- this seems like a bug to me. This is a case where the private attribute for preserving mtz dtypes can get out of sync with the actual index. In my mind this should be fixed by initializing the attribute to something sane, such as the current dtypes of the index. In many cases, this will not be the best possible dtype -- often object dtypes for MultiIndexes -- but it will be the best that can be do without additional information.

For the record, this sort of issue can also result from different methods of calling DataSet.set_index():
import reciprocalspaceship as rs
import numpy as np

mtz = rs.read_mtz("tests/data/fmodel/9LYZ.mtz")
print(mtz._index_dtypes_cache) # prints {'H': 'HKL', 'K': 'HKL', 'L': 'HKL'}

mtz.set_index(np.arange(168), append=True,  inplace=True)
print(mtz._index_dtypes_cache) # prints int64

In the above example, adding a numpy array to the index wiped out the existing cache.

It is worth noting that I don't think there is a general way to handle initializing the DataSet._index_dtypes attribute in the original snippet that started this issue. This is because pandas coerces any ExtensionDtype in an index to an object dtype, so it's not possible to figure out what the original dtype was. This is the main idea for why the DataSet._index_dtypes attribute is used in rs. It is always possible to make this work as expected with a call to __finalize__:
import reciprocalspaceship as rs
import numpy as np

inFN = 'reciprocalspaceship/tests/data/algorithms/HEWL_SSAD_24IDC.mtz'
mtz = rs.read_mtz(inFN)

mtz2 = rs.DataSet({
        'I' : mtz['IMEAN'],
        'SigI' : mtz['SIGIMEAN'],
    },
    cell = mtz.cell,
    spacegroup=mtz.spacegroup
)
mtz2.__finalize__(mtz)

The above PR improves the robustness of reset_index() and set_index() to "fail gracefully" in cases where it hasn't cached the original dtype. In such instances, it defaults to the standard pandas behavior. This compromise avoids the cryptic error messages above.


grid-visual not behaving as expected

Hi,
I just downloaded the latest Beta and am seeing an issue with grid-visual - it was working on the previous beta, now the background isn't displaying properly. I may have an issue with my syntax, or it may be something that is being worked on, in which case just let me know.
Browser
Chrome Version 55.0.2883.95 (64-bit) on macOS Sierra 10.12.2
Code
.container {
  @include grid-container;
  @include grid-visual;
  max-width: 900px;
  background-color: rgba(pink,0.3);
  height: 400px;
  margin: 0 auto;
}

Result

@mikeharrison Chrome recently made changes that broke the 'grid-visual' mixin. Originally it displayed correctly and the mixin itself is functioning correctly. The 'grid-visual' output is very complex and I believe that chrome is basically going... "seems like a lot of work, I'm not going to render that"
If you take a look at the page in safari it will render correctly. I have a couple of thoughts/options here.

Leave it be. If a particular browser decides not to render this feature, it may not be worth addressing, especially for a debugging feature.
Change the mixin to use a more simplified look that may be supported in more browsers.

I'm honestly open to either so let me know your thoughts.

Thanks for the quick reply.
I have now updated my MacOS (to 10.12.3), which in turn has updated my browsers:
Chrome: 56.0.2924.87
Safari: 10.0.3
Chrome is now rendering the visual grid correctly, and Safari is having a freakout. Such is life.
I take your point about it being a debugging feature, my concern would be that you would have to either have a disclaimer in the docs that it may or may not work in the user's chosen browser, or field issues from people who are trying to get it to work in a browser that isn't rendering it correctly.
I love the look of it, and am finding it much better for working over as it distracts less from the layout then the previous incarnation with coloured bars.
So my suggestion would perhaps be an additional argument to the mixin, something like solid, which would flip the visual grid to using the old behaviour, using the color argument to set the fill colour. Then have in the docs that if the default isn't working in your browser, to try the solid (or whatever) version. Best of both worlds, but perhaps additional complexity you would want to avoid?
Would be happy to put in a PR if you think this might be a good route

I think your intuition of doing something that actually works as is correct 😆. For now I think the best course of action is to change the look of grid-visual() to be bars instead of the fancy grid nonsense I made. check out https://github.com/thoughtbot/neat/commit/00a80d565438937b4ec363e6c97941e2c4b1e155 as I believe I implemented color bars before creating the current style.
One other note I might have is that the current implementation has a few extra lines including the top and bottom (see: https://github.com/thoughtbot/neat/blob/master/core/neat/mixins/_grid-visual.scss#L78). This was just done for style points but removing it may resolve the issue. It would be good to try removing this before resorting to other measures.

If you want to post a pr that would be great. fortunately I feel as though changing the display properties is not a 'breaking change', aka I think we can change the look and feel between minor versions and that's fine. If browsers update and are able to handle the current implementation we can always switch it back whenever. 👍

Removing the top and bottom lines don't fix it unfortunately.
OK I concur - back to the bars, though you get to keep the style points for the lines as they looked much cooler 💯

Sweet 🍬! I think this might be the last feature change before the release!
https://youtu.be/XaRkVnysuMU

Rolling back to your bars version fixed the issue in all browsers except IE11 - that didn't like me doing a window resize. But I think you could count on the fingers of one foot how many people will be debugging like that in IE11.
Don't have time to work through a PR at the moment, will leave it to the pros 😄


Typo on download page within Complete Library section

Most appropriate sub-area of p5.js?

[x] Other (On the web client)

Details about the bug:
Just a minor spacing typo within the main docs on the downloads page.

Web browser and version: Google Chrome 86.0.4240.198 (Official Build) (x86_64)
Operating System: MacOSX High Sierra v10.13.6
Steps to reproduce this:

Navigate to downloads
Scroll down to Complete Library
Notice VisitGet Started where it should be Visit Get Started (it's missing a space to separate the anchor element from "Visit")

Here is the
 element that contains the typo.

... VisitGet Started to learn how to setup a p5.js project.

it should be:

... Visit Get Started to learn how to setup a p5.js project.

Where a space is added after "Visit" so the "Get Started" permalink is correctly spaced from its surrounding paragraph text.
This is a very small typo but I wanted to bring it to your attention.

The source code of the website is not stored with the library's source code so I've moved the issue here.
The source of the page you are looking for is here. You can fork this repo, make the edit and file a PR. Thanks.


Issues with latest version

There is no option to "Update a value" without doing a copy and paste on one already there.
The "SEt VAlue To" option is completely different to the one given in the example (for the LCD guage) adn I cannot reproduce what you have added in the button  as there is not a free text box which allows the options to be inputted, only a "+" button which doesn't put the options in correctly.

Original file option - option 2. Me trying to reproduce it Option 1 (top)  This is also the option missing from the menu that i have to cut and paste to get into the button flow

On further investigation - i have determined that one of the above issues, is not actually an issue but a way in which you have to program the button in the flow.
Point #2 above, I stated there was not way to enter the value - this is wrong.  There is a way but its just a really complicated way to do it.  I'll show you how i managed it.
to get the "value:" into the flow and surrounded correctly by the formatting needed to display it you have to do the following

Enter the following       ${""
Place your cursor in the midle of the 2 "'s
Press the "+" to select a value to add.  The value will be correctly formatted and be readable by TP.


Prompt user for node version

Right now, we assume 10.15 (latest LTS). It would be great to prompt the user for the version they would like to use (defaulting to the current version in the shell?)

might have to come back to this...
could do this through hygen


Implement benchmarks for compare_op for GenericBinaryView

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Part of https://github.com/apache/arrow-rs/issues/5374
@XiangpengHao  added very nice support to compare kernels for GenericBinaryArray in https://github.com/apache/arrow-rs/pull/5900
Describe the solution you'd like
We should add benchmark coverage for these kernels to ensure we don't regress their performance and to help with future optimizations
Describe alternatives you've considered
Add tests for = and != in https://github.com/apache/arrow-rs/blob/master/arrow/benches/comparison_kernels.rs
Additional context

take
Also relevant to https://github.com/apache/arrow-rs/pull/5922

label_issue.py automatically added labels {'arrow'} from #5924


Add Dockerfile for UC

Is your feature request related to a problem? Please describe.
We should add a dockerfile so it will be easier for everyone to get up and running with Unity Catalog.

Describe the solution you would like
Short Term
Create Dockerfile to be added into the current unitycatalog repo.
Long Term
Have a standalone unitycatalog/docker repo to run automated builds into dockerHub.

Additional context

There are currently three PRs open for this #18 , #22 , and #42.  Placing all of these PRs into a single issue.

Note, we also have some side convos in the UC Slack such as this thread

This has been addressed with #116


[SIL]/[SILOpt] Thunks and specializations are never public.

The current behaviour of (some) open classes means private members are
forced to be public, but this only applies to the real members, not
thunks or specializations associated with them.
Fixes rdar://problem/40738913.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - dd923dddcd99c0744ec75519543f90644fe7eaec

Linux failure (for future reference):
20:53:10 FAILED: ../buildbot_linux/foundation-linux-x86_64/Foundation/libFoundation.so
...
../buildbot_linux/foundation-linux-x86_64/Foundation/Foundation/NSCFDictionary.swift.o:NSCFDictionary.swift.o:$S10Foundation15_NSCFDictionaryCMf: error: undefined reference to '$S10Foundation12NSDictionaryC14getDescription33_8C53A72A73712D943F7602D2573DFCFBLL2ofSSSgyp_tF'

Mm. What about override thunks, for concrete subclasses of generic classes?
open class Base<T> {
  open func consume(_: T) {}
}

open class Sub: Base<String> {
  open override func consume(_: String) { print("override") }
}

@jrose-apple Override thunks get emitted in each translation unit that has a vtable for a subclass of the class. So you're still relying on the original method having public linkage.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 0c67e56f85370721980f31ead5349fc7183a64fd

@swift-ci please test source compatibility

@swift-ci please test
@slavapestov I've changed to not setting the subclass scope on thunks, except for signature-optimised thunks, since in that case the original entry point to the code gets marked as a thunk, and thus that needs to have the right subclass scope, so that it remains public if it is private.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test source compatibility


iOS tokbox core SDK crashing

Using OpenTok (2.12.1)
iOS 11
We got 207 crashes happen last night during one relative busy streaming session.

@laeroah Could you please provide crash logs and any other relevant information regarding the crashes?

@laeroah I'm going to go ahead and close this issue due to inactivity. Please re-open if you have any questions!


[HOLD for payment 2023-07-14] [HOLD for payment 2023-07-12] Already selected members disappears after you search for new members

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

On staging web chrome > Create a new workspace > Invite members
Click on Invite
Now on search bar, type the email of a new user and select it
Now immediately, remove the previous user email and now try to search with the email of a different user and select it and notice that the old user that you selected on step 3 gets disappeared. Now if you click on invite, only the last user gets selected
If followed the same on production, the old selected users never disappears

Expected Result:
The old selected members should not disappear after you search for new members
Actual Result:
The old selected members disapperas after you search for new members
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.36-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/09340be8-784b-43d1-b2c2-f0494bee8467
https://github.com/Expensify/App/assets/43996225/eb6987c5-671e-4356-81fa-f5e50ac34687
Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688395631136579
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012b0dacfaa4c2503c
Upwork Job ID:<PHONE_NUMBER>209077248
Last Price Increase: 2023-07-12

@s-alves10 can you please check this? https://github.com/Expensify/App/pull/21700#pullrequestreview-1511446993

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

PR is in review here

PR merged, removing the label

@rushatgabhane let me know if we need a regression test for this!

Ready for payment @rushatgabhane do you want to be paid through NewExpensify?
Is there a regression test needed for this?

I'm going to be ooo until July 31st so going to unassign and assign a new teammate.
At this time, we're just waiting on a response to https://github.com/Expensify/App/issues/22123#issuecomment-1636232289

@rushatgabhane is paid outside of Upwork.
@avi-shek-jha, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~012b0dacfaa4c2503c

@rushatgabhane is paid outside of Upwork. @avi-shek-jha, can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~012b0dacfaa4c2503c

@mallenexpensify I have applied. Thank You.

Thanks @avi-shek-jha , I've hired you.

@avi-shek-jha paid!
@rushatgabhane can you please fill out the checklist above?
https://github.com/Expensify/App/issues/22123#issuecomment-1625184077

WIP ⚠

The PR that introduced the bug has been identified. Link to the PR:

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Determine if we should create a regression test for this bug.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

This has been paid on new dot https://staging.new.expensify.com/r/701637755905470
And checklist is complete. This issue can be closed.


eslint update for explicit-function-return-type

I think it would be ok to enable "allowExpressions" for  @typescript-eslint/explicit-function-return-type.
There a few specific cases where I don't think it's necessary to define the return type when it's inferred from the expression for example in some cases the linter complains about this form (taken form the example todo):
      'put': {
        // It wants the lambda function to specify its return type for handler
        handler: async ctx => serviceWrapper(() => {
          if (!ctx.params) {
            throw new NotAvailable();
          }

          const model = new TodoModel(ctx.body as TodoModel);
          return updateTodo(ctx.params.id?.toString(), model);
        }),
        middleware: [
          validateTodoMiddleware
        ]
      },

The return type can be inferred and if it there is a mismatch it will complain so I don't see a need to enforce that there and makes the code a little more verbose. The types for the args are inferred as well so I'm ok with the return type not being specified in these cases.
The change would be:
"@typescript-eslint/explicit-function-return-type": ["error", {
  "allowExpressions":  true
}],

Sounds acceptable to me.

Reopening this issue. I applied it to the eslintrc for the CLI not the stack. :(