Issue with Picker Search Functionality

Current behavior
We have an issue with the picker search function. Even though the picker is listed, searching for it by name doesn't yield any results. After entering the picker's name and hitting enter, the system fails to locate the picker.
Expected behavior
The system should display the picker corresponding to the entered name.
Steps to reproduce the issue

Navigate to the picker search field.
Enter the name of the picker.
Press enter.

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO

Environment details

Browser:
OS:
Code Version:

Additional information
JAM : - https://jam.dev/c/c5004022-695d-4689-9d6c-629bb3f36b0f

Issue verified and working fine in release v2.3.0. Hence, closing this ticket.


Making dpp.rc file

When building, it will show more info for dpp.dll file (on Windows properties selection).
Haven't tried to build yet because my pc crashed :( (testing help)

I want to make it like this btw:

I decide to include #include <winver.h> but CMake thingy so :/

Doesn't the rc file get generated by CMake?

@SirObby  : Doesn't the rc file get generated by CMake?

No.

It does, I sent a screenshot in the discord.

It does, I sent a screenshot in the discord.

No, it does not. CMake generates a .pc file not a .rc file, read the extension carefully.

how is this added to the lib? there's no changes to cmakelists?

how is this added to the lib? there's no changes to cmakelists?

About CMakeLists, I'm working on it and will soon pull on here when it works. I'm sorry for my latecy :(

@braindigitalis I've seen you have provided this on your CMakeLists.txt:

@braindigitalis I've seen you have provided this on your CMakeLists.txt:

I don't get it this is just a screenshot of something already in the cmakelists?


[Feature][task-datax] Added Doris visualization configuration in datax

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Just like configuring the mysql plug-in, you can complete the configuration of doris on the page.
Use case
Just like configuring the mysql plug-in, you can complete the configuration of doris on the page.
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I found the corresponding code path to support Doris
org.apache.dolphinscheduler.plugin.task.datax.DataxTask, the method to generate JSON configuration file is buildDataxJobContentJson(). I reviewed the method and found writer.parameter.* or read.parameter.* many parameters are missing. Therefore, an enhancement should be made to the corresponding code of datax to adapt to more data source plug-in access.

Since I am better at data development in my work, I hope that more capable contributors can receive this task. If not, I'll finish developing the feature.


Error while opening ruleset in mobile

Hello, I've downloaded sentakki, and I've tried it on my pc (linux), and it worked flawlessly, but when I put it on my phone (Realme 8i), it gave me an error

You can't load dlls on mobile versions of osu!lazer, you'd need to make/find a build with the ruleset included.


overlap constrains when lmul<1

As spec_0.10(5.2 section) says:
_A destination vector register group can overlap a source vector register group only if one of the following holds:

The destination EEW equals the source EEW.
The destination EEW is smaller than the source EEW and the overlap is in the lowest-numbered part of the source
register group (e.g., when LMUL=1, vnsrl.wi v0, v0, 3 is legal, but a destination of v1 is not).
The destination EEW is greater than the source EEW, the source EMUL is at least 1, and the overlap is in the highestnumbered
part of the destination register group (e.g., when LMUL=8, vzext.vf4 v0, v6 is legal, but a source of v0,
v2, or v4 is not)._
that means only 3 situations can be allowed, anything else is illegal for overlap. i have 2 questions:
for lmul<1
1.The destination EEW is greater than source EEW(widden).
vsetvli x0, x1, e8, mf2
vwop.vv  v8, v8, v10    // this instruction will be illegal, is it?  (source EMUL is smaller than 1, source and destination EEW are not equal)
vwop.wv v8, v8, v10    // this instruction will be legal, is it?  (source EEW equals destination EEW)
2.The destination EEW is smaller than source EEW(narrow).
vsetvli x0, x1, e8, mf2
vnop.wv  v8, v8, v10    // this instruction will be illegal, is it?  (destination group is lowest-numbered part of source register group)

In general, I recommend running this code on Spike rather than asking for clarification here.  It is more likely to be correct in response to questions about code example than the humans are :)
The first example is indeed illegal because of the third rule.
The second example is indeed legal because of the first rule.
But the third example is legal because of the second rule.

thanks


Registrar prefix updates

Must be 3 symbols
Must start with registrar name unless taken, then rename. Or must be defined during registrar creation.
Contact ID must start with this prefix.

More details in #160


Few questions about amazing Metapoint

@SOVLOOKUP MetaPoint is an amazing project. I have few questions

Is there any plan to maintain this project in the future?
How can a client expose endpoints?
What is the mechanism for peer discovery?

I use my spare time to maintain this project, if there is any way to better promote the sustainable development of this project, please let me know.
Each node can act as both a server and a client, for example you can define endpoints in your “browser client” node and call them in your "nodejs server" node.
P2P features such as peer discovery are based on libp2p.

I use my spare time to maintain this project, if there is any way to better >promote the sustainable development of this project, please let m

We should try to build a community around MetaPoint first. When more people will know and use MetaPoint then more people would like to contribute and may be sponsor the project. Let create a Discord server for community support.

P2P features such as peer discovery are based on libp2p.

I have never used libp2p before. Could you please share an example of peer discovery and creating a channel without a fixed IP address.

@SOVLOOKUP I would also like know how we can listen on a dynamic public address.


Sparrow as a service on Start9 Server

I have seen that this request has already been made to bring Sparrow as a service on a Start9 Server - https://github.com/sparrowwallet/sparrow/issues/969 .
I also found posts on this issue in the Start9 Community Forum - https://community.start9.com/t/sparrow-as-a-service/345/5
Here is a quote from the forum "Check out the Developer Docs 3 for more info. If Craig is interested, we’d love to help get this running and published to our Marketplace such that users can get one-click access to it."
@craigraw it looks like it would be a lot more work to get Sparrow running on a Start9 server. But it looks like the start9 guys are interested to help with it.

I appreciate the sentiment, but I'm not sure how Sparrow Desktop could become available via "one-click access" as it is a native application. Specter can offer this because it is a browser-based wallet, but that comes with it's own issues. Sparrow Server is also a native application, and while that can run on a Start9 server, the terminal interface is not a natural fit for the Start9 UI.
Happy to reopen this if I've missed something.


Render output as a video

Either create a video in the script, or export each frame as an image, and write a separate script to use ffmpeg to create the video using the images.

#9 worked on the computer I tested it on, but not the others. Hopefully #11 will be better...


Fixed several typos and phrasings.

@slmingol Please see the latest updates this issue #2 mentioned by the author.


click in the line number column to set breakpoints

add the ability to click in the line number column to set a breakpoint (fix https://github.com/dart-atom/dartlang/issues/654)
reorder items in the toolbar
when running flutter apps, just show log output from the device we ran on

@danrubel

LGTM


Wait for base to exist before spawning php bin.

We run various apps in a build directory that gets wiped whenever we start up gulp tasks for serving. On every restart kept hitting events.js:72 throw er; // Unhandled 'error' event unless the dir path already existed.

Missing a require declaration, will pull again.


Test ccb tool

Repo

I run the ccb tool with the parameter save_graphs=true and have got a mapping.txt-term-graphs.json file.
We will try to visualise it.

We tried to visualise the created graph online. It looks like that the gaph is a visualisation of the cell ontology and not of the mapping. So we will try to visualise the mapping by ourselfs.


Docker deployment files

Hello,
as you may have noticed, I have uploaded a work-in-progress version of Docker deployment files for WillBoard in the thread on /b/. While I understand that they currently aren't up to the standards which would deem them fit for publishing, I'd like to ask you whether or not would you be interested in merging my pull request, if I were to work on these files a bit more and make them a solid starting point for anyone interested in trying out the engine.
Regards
Anonimas

We can add Docker configuration files to the documentation when the final version is prepared.


[ISSUE #3794] websocket datasync can chose allow origin to avoid CSRF

Dear Community:
I have finished  #3794
please review code.

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

hi，pls check ci

Codecov Report

Merging #3795 (66cf33e) into master (ff3ba3b) will decrease coverage by 0.26%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #3795      +/-   ##
============================================
- Coverage     64.20%   63.94%   -0.27%
+ Complexity     6033     6004      -29
============================================
  Files           898      898
  Lines         24649    24679      +30
  Branches       2232     2238       +6
============================================
- Hits          15827    15781      -46
- Misses         7428     7497      +69
- Partials       1394     1401       +7

Impacted Files
Coverage Δ

...min/config/properties/WebsocketSyncProperties.java
54.54% <0.00%> (-20.46%)
:arrow_down:

.../sync/data/websocket/WebsocketSyncDataService.java
0.00% <0.00%> (ø)

...dmin/listener/websocket/WebsocketConfigurator.java
36.36% <10.00%> (-21.97%)
:arrow_down:

...c/data/websocket/client/ShenyuWebsocketClient.java
56.89% <71.42%> (-6.57%)
:arrow_down:

...in/sync/data/websocket/config/WebsocketConfig.java
93.33% <80.00%> (-6.67%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.25% <0.00%> (-9.58%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@847850277  hi， Can you tell us exactly what allow origin does?

@yu199195  to avoid CSRF, In the case of Internet environment if someone knows admin websocket url,he can connect to ShenYu admin.Then forge the attack.
of course , this config is an option , this just match allow origin , if you dont't want , you can chose old mode.

Thanks， it merged~


Failed get params on StackNavigator

i read tutorial from https://reactnavigation.org/docs/navigators/navigation-prop . and i try in my code, but params always undefined. my question, how to send param when i click a button and change a screen ?
Payment.js
    render() {
        const {navigate} = this.props.navigation
        return (
            <View>
                <Text>Pembayaran</Text>
                <Button
                    onPress={() => navigate('Profile', {balance : 80809})}
                    title="My Balance"/>
            </View>
        )
    }

Profile.js
    render() {
        const {state} = this.props.navigation
        return (
            <View>
                <Text>Your Balance: {state.params.balance}</Text>
            </View>
        )
    }

software
version

react-navigation
1.0.0-beta.11

react-native
0.46.4

node
v8.1.4

npm or yarn
npm 5.0.3

Can you post your navigation setup?

this is
const Drawer = DrawerNavigator({
    Home : {
        screen : Home
    },
    Profile : {
        screen : ProfileScene
    },
    Payment : {
        screen : PaymentScene
    },
})

const App = StackNavigator({
    Drawer : {
        screen : Drawer
    }
}, {
    headerMode: 'none'
})
export default App

now i got a params object, but i can't get key params. example
{
balance : 200
}

when i try to console.log(params) its work fine, but when i try console.log(params.balance) i got undefined. what should i do ?

Seems there may be a bug when passing params & using DrawerNavigator

#1072

Pinging OP @creativefull since this issue has not been active for a while, and it's related to an old version of the lib.
Please let me know if you want this to remain open; if I get no answer in the next 7 days I will close it.

Hi there @creativefull ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue with the latest version (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.


Start implementing the RPNGTemplate library

This PR start the implementation of all the RPNGTemplate instances we might need to implement a spatial junction as a library. It is based on #421 that should be reviewed before.
Summary of what has been done:

Removing a check from RPNG preventing a plaquette with 3 qubits to be created,
Modification of Qubit4WayJunctionTemplate: renaming as QubitSpatialJunctionTemplate, and the implementation is now generic enough to handle all the edge cases (L-shaped spatial junctions, {2,3,4}-way spatial junctions),
Re-introduction of the "border" templates QubitVerticalBorder and QubitHorizontalBorder,
Implementation of a library of RPNGTemplate.

In terms of implementation, here are the pieces that are currently implemented:

[x] Standard memory with optional reset/measurements on data-qubits and both observable orientation (Z observable vertical or horizontal),
[x] Standard vertical/horizontal junctions, with optional reset/measurements on data-qubits and both observable orientation,
[x] Temporal hadamard junction,
[x] Spatial hadamard junction,
[x] Logical qubit at the center of a spatial junction,
[ ] Specific spatial junctions to keep plaquettes border with even parity.

If you want to implement any of the missing piece, feel free to 1) say it in a message here and 2) push it directly on this PR :)
Fixes #416

Notes for future reviews:

The temporal hadamard is the memory with R set to - and M set to h. Is it worth keeping the current implementation, or should I use the memory implementation?
The spatial hadamard junctions could also be implemented from the memory junctions, but this time it would require to edit the RPNG notations in-place and after creation or to make the memory functions even more complex to allow for a basis change inside plaquettes. Is it worth keeping the current implementation, or should I use the memory implementation?
I am not fully satisfied with the parameters of the hadamard spatial junctions. For the functions returning the RPNGTemplate instances for memory operation, the input is the orientation of the Z observable. That is a very error-prone input in my opinion for hadamard junctions, as their main effect is to change observables... The best I could find was a boolean indicating if the top-left part of the top-left-most plaquette in the bulk (i.e., not on the border) is measuring a Z stabilizer or not. I find that description too complex, but could not find a better way to unambiguously define the template.

* The temporal hadamard is the memory with `R` set to `-` and `M` set to `h`. Is it worth keeping the current implementation, or should I use the memory implementation?

* The spatial hadamard junctions could also be implemented from the memory junctions, but this time it would require to edit the RPNG notations in-place and after creation or to make the memory functions even more complex to allow for a basis change inside plaquettes. Is it worth keeping the current implementation, or should I use the memory implementation?

I did not review the implementations yet. But I will vote for decoupling the implementation of hadamard templates and memory templates.

This PR should be ready for review.

On Sun, Dec 22, 2024, 8:49 PM Yiming Zhang @.***> wrote:

@.**** commented on this pull request.
I haven't finished reviewing the spatial junctions yet, but I will
complete it today.
On src/tqec/templates/rpng_test.py
https://github.com/tqec/tqec/pull/422#discussion_r1895179225:
Empty file
In src/tqec/templates/library/memory.py
https://github.com/tqec/tqec/pull/422#discussion_r1895184387:

"""Implementation of standard memory rounds on a junction aligned with the

X-axis.

⬇ Suggested change

"""Implementation of standard memory rounds on a junction aligned with the
X-axis.

"""Implementation of standard memory rounds on a junction arm aligned with the
X-axis.

In src/tqec/templates/library/memory.py
https://github.com/tqec/tqec/pull/422#discussion_r1895184500:

"""Implementation of standard memory rounds on a junction aligned with the

Y-axis.

⬇ Suggested change

"""Implementation of standard memory rounds on a junction aligned with the
Y-axis.

"""Implementation of standard memory rounds on a junction arm aligned with the
Y-axis.

In src/tqec/templates/library/spatial.py
https://github.com/tqec/tqec/pull/422#discussion_r1895229219:

"""Implementation of a logical qubit performing a spatial junction.

This function returns a RPNGTemplate instance representing a logical qubit
that is touched by 2 or more spatial junctions. The returned template is
carefully crafted to avoid hook errors damaging the logical distance.

⬇ Suggested change

"""Implementation of a logical qubit performing a spatial junction.

This function returns a RPNGTemplate instance representing a logical qubit
that is touched by 2 or more spatial junctions. The returned template is
carefully crafted to avoid hook errors damaging the logical distance.

"""Implementation of a logical qubit acting as a spatial junction.

This function returns a RPNGTemplate instance representing a logical qubit
connecting to others in space and forming a spatial junction. The returned template is
carefully crafted to avoid hook errors damaging the logical distance.

In src/tqec/templates/library/spatial.py
https://github.com/tqec/tqec/pull/422#discussion_r1895235257:

   The rationale behind that convention is that the logical qubit at the

   center of the spatial junction is completely aware of all the spatial

   junctions that should be implemented whereas each spatial junction in

   isolation does not know if the others spatial junctions are present or

   not. That means that corners, whose plaquette depends on the presence or

In my view, a spatial junction refers to the logical qubit located at the
center of an "X," "T," or "L"-shaped structure. The terminology used here
in the documentation is not clear to me.

+1, agreed

In src/tqec/templates/library/spatial.py
https://github.com/tqec/tqec/pull/422#discussion_r1895239034:

   ``measurement``: the logical qubit at the center of the spatial junction

   can already be initialised (and so have an incoming temporal junction

   from below), which means ``reset is None`` and ``measurement is None``,

A spatial junction should not have temporal pipes connecting to them.
Otherwise, the boundary conditions will not match.

+1, you can't mix spatial and temporal junctions. It's always either one or
the other.
—

Reply to this email directly, view it on GitHub
https://github.com/tqec/tqec/pull/422#pullrequestreview-2519807574, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAXTGB2LOFDNQE4UFCWT32G6I7DAVCNFSM6AAAAABT3UPOVWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJZHAYDONJXGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Additionally, I believe implementing a graph algorithm to find the shortest logical operator across the spatial junction, based on counting (hook) errors, is feasible and not overly complex given the RPNGTemplate. I might explore creating such an algorithm and incorporating it into the tests to further verify correctness.

I also though about this when implementing the RPNGTemplate. I agree that this would be welcomed, and it might even be a first step toward automatic hook error management.


Update storybook v7

yarn run v1.22.19
$ jest
 PASS  src/index.test.js
  addon Console
    global scope
      check options `setConsoleOptions`
        ✓ should return default options (2 ms)
        ✓ should set options as an object
        ✓ should set options via function
      default options
        ✓ should output `console.log` to panel and console (3 ms)
        ✓ should output HMR log to console but not to panel (1 ms)
        ✓ should output `console.warn` to panel and console
        ✓ should output `console.error` to panel and console (1 ms)
        ✓ should catch error and output to panel and console
      exclude HMR from console via `consoleExclude: [/[HMR]/]`
        ✓ should catch error and not output anywhere
        ✓ should works with multiple args
      include only certain logs via `panelInclude: [/Component/]`
        ✓ should output <Component/> to console and to panel
        ✓ should not output anything else to panel (1 ms)
        ✓ should log if it match to one of included patterns
      exclude everything via `...Include: [/(?!.*)/]`
        ✓ should not log anything at all
        ✓ should not warn anything at all
        ✓ should not error anything at all (1 ms)
        ✓ should not log even objects
    withConsole
      ✓ should work with context (6 ms)
      ✓ should work without context (1 ms)
      React
        ✓ should wrap storyFn (1 ms)
      Vue
        ○ skipped should wrap storyFn
      Covfefe
        ✓ should warn for unknown framework

--------------------|---------|----------|---------|---------|-------------------
File                | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------------|---------|----------|---------|---------|-------------------
All files           |   98.87 |    97.05 |     100 |   98.64 |
 index.js           |   98.79 |    97.05 |     100 |   98.52 | 14
 react-decorator.js |     100 |      100 |     100 |     100 |
--------------------|---------|----------|---------|---------|-------------------
Test Suites: 1 passed, 1 total
Tests:       1 skipped, 21 passed, 22 total
Snapshots:   0 total
Time:        0.909 s, estimated 1 s
Ran all test suites.
✨  Done in 1.27s.

storybook is working on v7


dynamic informer

/area API
/kind feature
Expected Behavior
Would it be possible to add an injector for the dynamic informer?
Actual Behavior
There is one for the dynamic client, but not the informer.
Steps to Reproduce the Problem

Additional Info

I might be wrong, but isn't that what the SharedInformerFactory is for? It has a ForResource function that returns a GenericInformer for the passed type. The SharedInformerFactory is available for injection at knative.dev/pkg/client/injection/kube/informers/factory. Make sure to start the informers generated by ForResource accordingly.

So I did try that, but I thought I had taken a wrong turn as I got the following error:
no informer found for xxx.yyy.zzz

Also, I assumed (perhaps wrongly) that sharedmain.MainWithContext() would start it. Is that true?

Probably not because you're receiving a new Informer "out of bounds" that sharedmain doesn't even know about.


Make it possible to disable hyphenation on labels

I've implemented a few functions to allow the usage of Pango attributes to disable automatic hyphenation on labels.

Apparently, this would break compability with MinGW, as the relevant function is only available in Pango 1.44:
https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-pango/PKGBUILD#L7
Maybe this merge needs to wait for a bit after all.

FYI there's a fairly trivial workaround for this:
<span insert_hyphens="false">Text</span>

Per the Pango Markup documentation.

if I see it correctly now, the version in MinGW was raised, so it should work now.
pkgname="${MINGW_PACKAGE_PREFIX}-${_realname}"
pkgver=1.48.0
pkgrel=1
pkgdesc="A library for layout and rendering of text (mingw-w64)"


test

/kind bug
Please check the FAQ documentation before raising an issue
Please check the FAQ documentation and old issues before raising an issue in case someone has asked the same question that you are asking.
Describe the bug (must be provided)
A clear and concise description of what the bug is.
Your Environments (must be provided)

OS: uname -a
Compliler: g++ --version or clang++ --version
CPU: lscpu
Commit id (e.g. a3ffc7d8)

How To Reproduce(must be provided)
Steps to reproduce the behavior:

Step 1
Step 2
Step 3

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Provide logs and configs, or any other context to trace the problem.

/test


Supervision support for OS X, Windows

[x] OS X
[ ] Windows
[ ] Others?

i've put together a working plist file (for MacOS). i don't know rust, sadly, so i don't think i'll be able to contribute code – but here's the general architecture of said plist that should at least get you started.
these files will go in /Library/LaunchDaemons/<file>. i set them up as com.zerotier.nsd.NETWORKID.plist – following the naming schema for ZeroTier One (com.zerotier.one.plist).
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict>
    <key>Label</key> <string>com.zerotier.nsd.NETWORKID</string>

    <key>ProgramArguments</key>
    <array>
      <string>/absolute/path/to/zeronsd</string>
      <string>start</string>
      <!-- every space in the command appears to need a `<string> ... </string>` block -->
      <string>-t</string>
      <string>/absolute/path/to/token</string>
      <string>-d</string>
      <string>DOMAIN</string>
      <string>NETWORKID</string>
    </array>

    <key>UserName</key> <string>root</string>

    <key>RunAtLoad</key> <true/>

    <key>KeepAlive</key> <true/>

    <key>StandardErrorPath</key> <string>/var/log/zerotier/nsd/NETWORKID.err</string>
    <key>StandardOutPath</key> <string>/var/log/zerotier/nsd/NETWORKID.log</string>

  </dict>
</plist>

also, here's the manpage for plist in case you don't have MacOS.
i have two networks running this way and everything is hunky dory.

Thanks! This is incredibly useful. Yeah, I don't have a mac here but other coworkers do, I will turn them into lab rats! I will circle back when I have something of value; probably in a few days.

looks like this is good to go for MacOS? (also, i you misspelled my github username on the release. 🙂 )

kinda. We need to do homebrew packaging and the windows build was affected by this change so I need to adjust that a little bit. Expect 0.2.1 to land soon.
Sorry about the name; I'll fix it in the 0.2.1 announcement.

not sure if this is helpful, but it seems like both of these are relevant to getting a service developed/installed in windows.

https://docs.microsoft.com/en-us/dotnet/framework/windows-services/
https://docs.microsoft.com/en-us/dotnet/framework/windows-services/how-to-create-windows-services

i might have some time to take a crack at this, but i'm also not too keen on installed visual studio. 😅 (this would be the only reason for me to install it. 😞)

I was looking at some rust stuff to do this, namely centered around the sc tool. I haven't read the URLs above yet; I will try to get to it today.

Since the windows stuff is still well-outstanding I'm going to close this ticket since we have enough of a result.


Simpler Password reset ux

I've noticed a strange effect when certain conditions are true of a user account when said account attempts to reset their [forgotten] password.

configuration RequireAccountVerification is false
account is not verified
account HasPassword()
account logs in at least once

At this point, assume the user forgets their password.
Resetting their password generates a "confirm your email" email (EmailChangeRequestedEvent triggers this). By design the url embedded is required to prompt for the user's password in order to accept the verification key. This is required due to an implementation detail in VerifyEmailFromKey():
if (account.HasPassword() && String.IsNullOrWhiteSpace(password))
{
    // ...
    throw new ValidationException(...);
}

So back to the example. By clicking on this link the user is implicitly verifying her account, however in order to proceed with resetting their password is required to enter their current password, which they have forgotten.
After looking at the code I have a hunch this happens even without the 4th condition being true as well:
if (!account.IsAccountVerified)
{
    // if they've not yet verified then don't allow password reset
    if (account.IsNew())
    {
        // instead request an initial account verification
        // ...
        this.AddEvent(new AccountCreatedEvent<TAccount> { ... });
    }
    else
    {
        // ...
        this.AddEvent(new EmailChangeRequestedEvent<TAccount> { ... });
    }
}

The UX this results in (asking the user for their password when they are trying to reset it) is weird.

The RequireAccountVerification  flag is a bit misleading -- it means that the user can login even if their email is not verified. We never allow a password to be reset if the email is not confirmed. So if you let them login without email confirmation and they forget the password they're in trouble.

Yes I understand what MR is doing.
However, what I'm arguing for: clicking a link in an email implicitly confirms the user's identity (in so far as we're talking email access == verified identity) - yet is prompted for a password simply because user.HasPassword().
What about new account creation? The same logic sits at the end of the verification ux there too.
I believe that the logic in ResetPassword() should be symmetrical to that of VerifyEmailFromKey():
To recap ResetPassword() contains the following logic:
ResetPassword():
if (!account.IsAccountVerified)
{
    // if they've not yet verified then don't allow password reset
    if (account.IsNew())
    {
        // ... account created event -> sends email
    }
    else
    {
        // ... email change event -> sends email
    }
}

Could it not follow that the logic should be reflected in VerifyEmailFromKey()?
VerifyEmailFromKey():
if (account.IsAccountVerified)
{
    // as before, validate given password
}
else
{
    // if they've not yet verified then implicitly verify without password requirement
    if (account.IsNew())
    {
        // check VerificationPurpose == VerificationKeyPurpose.VerifyAccount?
    }
    else
    {
        // check VerificationPurpose == VerificationKeyPurpose.ResetPassword?
    }
}

Otherwise, why support resetting of password for unverified accounts at all (provided RequireAccountVerification = true)? Or if you don't like that logic, why require new account registrations to have to enter their password to verify their account? It's a small but meaningful UX change that may reduce the "barrier of entry" to the application.

Sorry -- was traveling so I got behind on these issues.
However, what I'm arguing for: clicking a link in an email implicitly confirms the user's identity (in so far as we're talking email access == verified identity) - yet is prompted for a password simply because user.HasPassword().
I'd disagree with this statement. Just because you click a link in your email does not confirm your identity. It simply confirms that you control the email that MR sent the message to. Forcing a user to re-enter their password is what really confirms their identity. This protects against incorrect/typo'd email addresses.

I'm running into this password reset conundrum myself. In my case I require email verification, and getting the same outcome. I'm throwing in my 2p to weigh in that this really is problematic.
Here's a scenario:

A user registers. The site doesn't error but for whatever reason the user never gets (or finds) the confirmation email.
The user moves on and forgets about the site for a while. It wasn't a high priority at the time, they got distracted by some other site/event/etc..
The user comes back to the site and tries registering again some time later (they forgot that they ever tried registering).
The user is told "that email address is already in use."
Next they try signing in a couple times to no avail. They can't remember the password they set.
So they try the reset password feature, and receive an email with a link.
They follow the link and are prompted for their password.
They give up and never try again, or they contact support and complain heartily.

Another scenario is the user simply fat fingered their password, and need to go back to zero because they don't know what they did wrong (yes, twice in a row, maybe caps lock was bumped).
How can this scenario be handled? Right now the user is stuck unless they reach out to support.

Yea, at this point it's safe to delete the account because: 1) the account has never been logged into (IsNew extension method can check this), and 2) You don't let them login to the app until email has been confirmed (via RequireAccount Confirmation in MR Config).

Thanks @brockallen I've updated my register action to delete a new account with matching email before allowing CreateAccount to be called in the normal way. The one downside I ran into is that an account closed email is sent at the same time as the account created email. To avoid that email being sent I can delete the user account from the repository and basically replicate DeleteAccount, but was wondering, is there a more elegant way to handle this?
An example of deleting a new account with the same email as part of the user registration process:
// If a new, unconfirmed user already exists with the same email
// address delete the user account and then permit new account creation
// to proceed normally.
var account = this.userAccountService.GetByEmail(model.Email);
if (account != null && account.IsNew())
{
    this.userAccountService.DeleteAccount(account.ID);
}

// Register like normal:
account = this.userAccountService.CreateAccount(model.Username, model.Password, model.Email);
// ...

@brockallen if you have any suggestions for handling this more elegantly I'm all ears but in order to keep things simple I decided to use DeleteAccount as in my previous comment, and display a message to the user letting them know what happened. That kind of double registration should be fairly rare and I guess I'll find out if the closed account notice causes confusion.
Here's how I implemented it for anyone interested. You'll notice that I only do this if account verification is required. I wouldn't want someone to accidentally close their own account because they re-register when they already have an active, valid account. You may notice that this doesn't solve the password reset when account verification is not required problem that started this discussion, unfortunately. This solution is good enough for me for now.
if (this.userAccountService.Configuration.RequireAccountVerification)
{
    // If a new, unconfirmed user already exists with the same email
    // address delete the user account and then permit new account creation
    // to proceed normally.
    var existingAccount = this.userAccountService.GetByEmail(model.Email);
    if (existingAccount != null && existingAccount.IsNew())
    {
        var created = existingAccount.Created;
        this.userAccountService.DeleteAccount(existingAccount.ID);
        ViewBag.AccountDeletedMessage = string.Format("A previous regististration was started {0:g} but never finished for an account with the email address you entered. The old account had to be closed before creating the new account you just registered. You will receive an account closed email very soon that you can safely ignore. Be sure to confirm your email address to finish registering this account.",
            created.ToLocalTime());
    }
}

var account = this.userAccountService.CreateAccount(model.Username, model.Password, model.Email);

You can just configure different MR configs for the delete scenario and don't add an email event handler.

Thank you for the suggestion! In case others will benefit, here's what I ended up with. Note that I'm using a custom user account service and configuration class.
if (this.userAccountService.Configuration.RequireAccountVerification)
{
    // If a new, unconfirmed user already exists with the same email
    // address delete the user account before continuing with account creation.
    var existingAccount = this.userAccountService.GetByEmail(model.Email);
    if (existingAccount != null && existingAccount.IsNew())
    {
        // Use a user account service that is not configured to send emails
        // when the account is deleted.
        var tempUserAccountService = new CityUserAccountService(new CityMembershipRebootConfiguration(), this.userRepository);
        tempUserAccountService.DeleteAccount(existingAccount.ID);

        ViewBag.AccountDeletedMessage = string.Format("A previous registration was started {0:g} but never finished for an account with the email address you entered. The old account had to be closed before creating the new account you just registered. Be sure to check your email, and verify your account to finish registering this account.",
            existingAccount.Created.ToLocalTime());
    }
}

We never allow a password to be reset if the email is not confirmed. So if you let them login without email confirmation and they forget the password they're in trouble.

@brockallen - adding to @CrescentFresh's initial question. Since the user initiated reset password because they have forgotten their password, why even kick off the EmailChangeRequestedEvent if it will never work? Is there an alternate use case where sending the email verification makes sense in this scenario? Even when they are new, they still initiated reset password, so kicking off the AccountCreatedEvent doesn't seem to be helpful either.

@brockallen:

Just because you click a link in your email does not confirm your identity

Yes, it does. That's the point of verification urls via email. You (or Dominic, I'll track it down) even say this in a talk you give. Yes it's one of many verification methods (2fa being another, security questions being another), but in this particular flow access to the email link is implicitly confirming identity.
Otherwise why use email at all for the initial identity verification?

What is the email address on record is incorrect -- for example if you self-register and enter the wrong email (or have a typo)? That's the context for that statement.

BTW, this is why email confirmation in MR also requires re-entering the password. That really confirms that the person whose email was used is the same person that owns the account. Once that's confirmed, then the email can be trusted for things like password reset.

But in the scenario where a password reset is initiated and the email has not been verified, sending the email verification email is pointless as it will leave the user stuck. If you really want to keep the password requirement on verification, doing a password reset when not verified should throw an error, I would think.

Right, and MR does not do that (unless there's a bug).

which "that" are you referring to? It does send the email verification on password reset for an unverified email, are you saying that is the bug?

I'll have to go back thru the code then to trace the logic.
I do recall some path where an email reset is requested but the email is not yet verified. What should happen is the trigger the email that is the initial email (which at this point might be the email verification)... so yes, there's a state you can get into where the user is stuck if they never confirm their email and forget their password. It's a hard problem to solve (if you agree the possibility of invalid emails entering the system).
If the emails being provided are already confirmed (from some other source), then you can just mark the email for that account as being confirmed (there's an API for that).

Ah didn't notice that API - so it looks like we could actually build our own Email Verification without requiring a password (if we disagree with your assessment on requiring password) by calling GetByVerificationKey and SetConfirmedEmail...

absolutely

But I do caution you about making the assumption that an end user will enter the right email address. They often get something like that wrong (believe it or not).

Yep - definitely get that. One other thought on this scenario - I think it would be useful to have a different Event raised when a user is not verified but they do a password reset. I would want to tailor my message to the user differently in that scenario because a standard email verification email will likely be confusing to the user when they have just selected the forgot password option. Something to think about - I'll see if I can find some time to do a pull request on it.
Thanks as always!

Not a bad idea. I think what I've done in the past is in the email verification I check IsNew() to know if the user has logged in or not. I think some of the samples might even show this... but yes, certainly room for improvement and/or clarification.

Given that I don't foresee making this change, I'll close this issue. Thanks.


add v6 files, updated bookmark, renaming files

Docs Build status updates of commit 2b6de93:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:warning:Warning
View
Details

Odata-docs/changelog/odatalib-7x.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/simplified-options.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/batch.md
:white_check_mark:Succeeded
View

Odata-docs/TOC.yml

Line 0: [Warning] Invalid file link:(~/customizable-type-facets-promotion).
Line 0: [Warning] Invalid file link:(~/disable-instance-annotation).
Line 0: [Warning] Invalid file link:(~/simplified-convention).
Line 0: [Warning] Invalid file link:(~/support-untyped-json).
Line 0: [Warning] Invalid file link:(~/capabilities-vocabulary).
Line 0: [Warning] Invalid file link:(~/add-annotations-to-enummember).
Line 0: [Warning] Invalid file link:(~/aggregation-support).
Line 0: [Warning] Invalid file link:(~/parsing-url-template).
Line 0: [Warning] Invalid file link:(~/additional-prefer-header).
Line 0: [Warning] Invalid file link:(~/expanded-navigation-delta).
Line 0: [Warning] Invalid file link:(~/alternate-key-v6).
Line 0: [Warning] Invalid file link:(~/composable-function-in-client).
Line 0: [Warning] Invalid file link:(~/nextpage-link-and-count-for-collection).
Line 0: [Warning] Invalid file link:(~/support-abstract-entity-type-in-client).
Line 0: [Warning] Invalid file link:(~/override-primitive-serialization-deserialization).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 5bf5230:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-7x.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/simplified-options.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/batch.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 12d4299:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-7x.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/simplified-options.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/batch.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


What is REGISTER_COMMANDS_KEY?

In the example .env file, the REGISTER_COMMANDS_KEY value doesn't show up anywhere in the discord developer portal.
I'm also assuming BOT_TOKEN is the "Client Secret", and NEXT_PUBLIC_CLIENT_APPLICATION_ID is supposed to be the Application ID found in the "General Information" tab. Otherwise, these environment variable names seem to be outdated.

@MooKorea

Register Commands Key is something you set on your own. then use it to register your commands on the deployment website. ( i apologive for the bad documentation, added more info)
BOT_TOKEN is this

NEXT_PUBLIC_CLIENT_APPLICATION_ID is now renamed to NEXT_PUBLIC_APPLICATION_ID Thanks <3.


[SR-9956] classes defined inside functions can't be made to conform to Equatable?

Previous ID
SR-9956

Radar
None

Original Reporter
@weissi

Type
Bug

Status
Resolved

Resolution
Duplicate

Environment
c

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
None

Priority
Medium

md5: c2436514a3ae706e9e8ec30597e978fc

duplicates:

SR-3092 Function-level nested types cannot conform to Equatable

Issue Description:
I have this Swift program
func foo() {
    final class Bar: Equatable {
        static func == (lhs: Bar, rhs: Bar) -> Bool {
            return lhs === rhs
        }
    }
}

which I think is totally fine but it claims that Bar doesn't conform to Equatable. Moving Bar outside the function foo however makes it compile.
Also: all works with {{struct}}s.
Error is
$ swift test.swift
test.swift:2:17: error: type 'Bar' does not conform to protocol 'Equatable'
    final class Bar: Equatable {
                ^
Swift.==:1:24: note: candidate would match if 'Bar' conformed to 'RawRepresentable'
@inlinable public func == <T>(lhs: T, rhs: T) -> Bool where T : RawRepresentable, T.RawValue : Equatable
                       ^
Swift.FloatingPoint:2:24: note: candidate would match if 'Bar' conformed to 'FloatingPoint'
    public static func == (lhs: Self, rhs: Self) -> Bool
                       ^
Swift.BinaryInteger:2:24: note: candidate would match if 'Bar' conformed to 'BinaryInteger'
    public static func == <Other>(lhs: Self, rhs: Other) -> Bool where Other : BinaryInteger
                       ^
Swift._Pointer:2:24: note: candidate would match if 'Bar' conformed to '_Pointer'
    public static func == (lhs: Self, rhs: Self) -> Bool
                       ^
Swift.Strideable:3:35: note: candidate would match if 'Bar' conformed to 'Strideable'
    @inlinable public static func == (x: Self, y: Self) -> Bool
                                  ^
Swift.StringProtocol:2:35: note: candidate would match if 'Bar' conformed to 'StringProtocol'
    @inlinable public static func == <RHS>(lhs: Self, rhs: RHS) -> Bool where RHS : StringProtocol
                                  ^
Swift.SIMD:4:24: note: candidate would match if 'Bar' conformed to 'SIMD'
    public static func == (lhs: Self, rhs: Self) -> Bool
                       ^
Swift.Equatable:2:17: note: protocol requires function '==' with type '(Bar, Bar) -> Bool'; do you want to add a stub?
    static func == (lhs: Self, rhs: Self) -> Bool
                ^

@AnthonyLatsis I noticed you closed this as 'not planned'. But this is a bug, no?

Hi, Johannes! Apparently, all Jira duplicates, including this one, had already been closed 'as completed' when the issues were transferred. But when I was about to close some stray open duplicates of this issue I found the other day, I discovered that the 'duplicate' state is in the 'close as not planned' bucket (you can verify this by clicking the droplist next to the 'close' button), so I went ahead and reclosed the duplicates as 'not planned'. I realize this is misleading, and that I probably shouldn't have bothered reclosing them. With hindsight, I think we should mark duplicates using GitHub commands rather than closing them.

Like this:
Duplicate of #45682

@AnthonyLatsis that makes sense, thank you for the explanation. Happy to dupe!


Chams: [FireShader] doesnt work for me unlike WaterShader and GalaxyShader
Waypoints: works actually bad for me ( even range is<PHONE_NUMBER> (?) )

and missing descriptions.

Rechams work for me just fine????

Rechams work.

Rechams work.

stfu they dont

Bro nop0 you're a 2y2c/8b main 2022 who literally asked for newbase configs in comments 🤡 💀

AutoCrystal: multiplace calculations (?)

(?)

Waypoints: works actually bad for me ( even range is<PHONE_NUMBER> (?) )

please elaborate
There's a bug and a feature template, please follow those and provide information which allows me to understand what this means.

AutoCrystal: multiplace calculations (?)

(?)

Waypoints: works actually bad for me ( even range is<PHONE_NUMBER> (?) )

please elaborate
There's a bug and a feature template, please follow those and provide information which allows me to understand what this means.

nope there are no feature template


Switch done() to done-testing()

Rakudo HEAD uses done-testing instead of done, so follow that.
Also add two flat() calls that are necessary after the Great List Refactor in Rakudo
(only a partial fix; two tests still fail in the rakudo "glr" branch)

Thanks!
I'll also update done to done-testing in my other modules.


Document CLI vs tslint.json

The documentation mentions the --type-check CLI flag. Is it possible to specify this in the tslint.json?
I noticed that these may have different spellings, e.g. it is --rules-dir via the CLI but "rulesDirectory" in tslint.json. So there should be documentation for both.

FWIW, --type-check has been removed. Agreed that there could be more specific documentation on other options' casing.

☠ TSLint's time has come! ☠
TSLint is no longer accepting most feature requests per #4534. See typescript-eslint.io for the new, shiny way to lint your TypeScript code with ESLint. ✨
It was a pleasure open sourcing with you all!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


using an object initializer on ApiResource

When using the object initializer on ApiResource and not setting the required Scope explicitly thus the default Scope of the ApiResource.Name is never added.
            new ApiResource
            {

                Name = "APItest"
             }

work around:
            new ApiResource
            {

                Name = "APItest",

                Scopes = new[]
                {
                    new Scope("APItest", "api default scope")
                }

            }

work around #2 use non default constructor.
new ApiResource("APItest")

The ctor that accepts scope name and description is designed as the convenience mechanism if you don't want to set the properties/collections correctly.


build docker image on PR branches, but do not publish

What does this pull request do?
runs circleci build_docker job on all branches, but only publishes to quay.io on main
What is the intent behind these changes?
validate changes to dockerfile in PRs before merging to main

Looks like it needs a token in CircleCI secrets

working now :)
looks like we have to address some known high severity CVEs. will look tomorrow.

🎉
Seems like all of them come from the base image itself https://snyk.io/test/docker/openjdk%3A11-jre-slim?severity=high&policy=open&tab=issues

@sldblog it looks like using the alpine tags of openjdk is not a good idea based on the docs:
What this means is that Alpine based images are only released for early access release versions of OpenJDK. Once a particular release becomes a "General-Availability" release, the Alpine version is dropped from the "Supported Tags"; they are still available to pull, but will no longer be updated.

👍 Indeed. It looks like https://hub.docker.com/r/adoptopenjdk/openjdk11 is unofficial as well.

@sldblog i've disabled the vulnerability scanning on this PR for the time being. just to unblock this until we sort out the base image issues.


Extend WebApplicationFactory

This pull request extends WebApplicationFactory<T> based on some experiences I've had with it while updating some applications to use ASP.NET Core 3.0 using preview 2 from ASP.NET Core 2.2.
First, it adds a new property, public virtual IServiceProvider Services. This is to support the scenario where the test application wants access to the IServiceProvider of the hosted service.
In 2.x, this was possible through the access chain factory.Server.Host.Services, however in 3.0 if the application is using IHostBuilder this access throws the following exception:
System.InvalidOperationException:
  The TestServer constructor was not called with a IWebHostBuilder so IWebHost is not available.

As the IHost vs. IWebHost implementation detail is hidden, rather than expose two different properties for the possible hosts and make the caller choose, instead the new property returns the appropriate IServiceProvider based on the host that is in use.
The property is virtual so that derived instances leveraging the base functionality to use a different host can override the property to change the IServiceProvider. An example of this can be seen in this PR for an application of my own where I build on top of WebApplicationFactory<T> to host the server on an actual HTTP port for use for browser-based UI tests: https://github.com/martincostello/alexa-london-travel-site/pull/252
Secondly, this PR adds a new method protected string GetContentRootPath() that exposes the existing logic to get the content root path for the application being tested. Previously this was private, so if a derived type also needed access to the value for some reason, it had to duplicate the code for itself.
I also considered exposing EnsureServer() in some manner so that derived types don't need to "hack" the services being started up by calling either CreateDefaultClient() or Server so they can ensure the server is running before doing other custom setup actions. I wasn't sure exactly what to call that, so I've left it for now, but if you have any suggestions on the best way to do that, I'd also like to do that either in this PR or a different one.

In 2.x, this was possible through the access chain factory.Server.Host.Services, however in 3.0 if the application is using IHostBuilder this access throws the following exception:
System.InvalidOperationException:
  The TestServer constructor was not called with a IWebHostBuilder so IWebHost is not available.

@Tratcher Is this a bug on TestServer? Is there an alternative to reach the service collection from testserver when using IHost?

@javiercn it's an expected change when we moved to generic host. It wasn't clear how many people used that code path so we hadn't worked on mitigating it yet.

Any further thoughts on this so I can update the branch for the code rearrangement in master since it was opened?

@Tratcher Could we get the ServiceProvider fixed?
@martincostello Based on what you mention it seems to me that what you are most interested in is the ability to find the content root for the app. I would suggest a couple of things. If you are writing E2E tests I suggest you avoid using WAF all together as it doesn't buy you much.
For setting up the app for tests I would simply create a small base class or small fixture targeted for your app specifically. As per the content root, I would simply reference it directly (relative to the app) or using
builder.UseSolutionRelativeContentRoot() to make it more straightforward.
WAF does things in a very complicated way because it aims to work out of the box and doesn't have any knowledge of the app. You don't have that restriction so my recommendation would be to keep it simple.
As an aside, I've been working lately on some E2E testing infrastructure changes for our own E2E tests and there is something that would probably would work better for you and that includes support for finding out the content roots without guessing.
https://github.com/aspnet/AspNetCore/pull/8188/files?utf8=✓&diff=split#diff-c9e49b86b2dd11680a0d4a3fdc22e802R33
https://github.com/aspnet/AspNetCore/pull/8188/files?utf8=✓&diff=split#diff-26eb065f5048f1cf055179dceb6df3a4R40
With that, your fixture simply becomes
public class ServerFactory
{
   public ServerFactory()
   {
        var builder = Program.CreateHostBuilder(args);
       builder.UseContentRoot(FindProject(typeof(Program).Assembly.FullName));
       _host = builder.Build();
   }

   public string FindProject(string projectName)
   {
           return typeof(ServerFactory).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>()
               .Single(m => m.Key == $"TestAssemblyApplication[{projectName}]")).Value;
   }

   public void Dispose()
   {
        _host.Stop();
        _host.Dispose();
   }
}

Would that work for you?

@javiercn Thanks - I'll have a play around with something like that in my 3.0 branch once preview 3 drops and see how I get on.

@javiercn this fix in this PR (https://github.com/aspnet/AspNetCore/pull/7414/files#diff-5f39437e8fa98005e4490f30c05e6b1eR86) is correct. It's up to you if you want to take the GetContentRootPath change as well.

@Tratcher This breaks existing customers code. I would like to avoid forcing customers to change their code if we can. Why not handle it in TestServer directly?

It doesn't break existing code, users have to opt into the new IHostBuilder. Asking them to make a few other changes is not unreasonable.

this was possible through the access chain factory.Server.Host.Services

The Host property type is IWebHostBuilder and changing that to IHostBuilder would break existing apps. The new Services property will work for both scenarios.

If I rebase this onto master and just change the PR to be e1b0564767f6a1dee683bb65a7dc8b455c58ccda, would this be merged?

Yes, and thanks for following through!

Cool, thanks - I'll update the PR later today.

Will merge once the build is happy

Looks like the code check build has failed - is there something I need to update because I've added a new public member?

Ah yes. You need to follow the instructions in /docs to update the reference assembly I believe.

https://github.com/aspnet/AspNetCore/blob/master/docs/ReferenceAssemblies.md#when-changing-public-api

Thanks - I'll fix that now.

Ah, nevermind. It must have been the compilation error. You can ignore the instructions above.

Looks like it was both! I'm just waiting for Visual Studio Enterprise 2019 to install so the generation tool works, as it doesn't seem to like 2019 Professional being installed.

There is a script to make sure your VS has all the prerequisites installed. It should work with professional afaik.

I'm guessing I'm missing a few prerequisites (I'd guess C++ stuff for the IIS hosting module), but it's installing them into a new VS Enterprise installation instead of adding them to VS Professional.

I see. Well, the script will do the right thing I think.

If for some reason it doesn't work, I'll figure out if I can run the tool and put a commit on top of the PR or create a patch you can apply.

@martincostello I'm pretty sure you didn't mean to delete those .csproj files in your last PR, but of course this can't be merged until that is reverted 😄

lol. That is true. Thanks @SteveSandersonMS for catching that!

I misread the instructions and ran dotnet msbuild /t:GenerateReferenceSource from src/Mvc instead of src/Mvc/Mvc.Testing/src, and the result of that included the deletes.

That looks better

Looks OK now apart from two (hopefully) unrelated test failures.

Got there eventually 😎

Merged. Thanks for following through!


GKE no longer supports 1.10

https://cloud.google.com/kubernetes-engine/release-notes#february-18-2019
Versions no longer available
The following versions are no longer available for new clusters or
upgrades to existing cluster masters:

1.10.x

This means GKE currently only supports 1.11.x (masters) :/

While this fixes the issue for now, I was thinking whether it would be better if we simply queried each available k8s version on each cloud and test the builds on all available versions. This would mean that we could be testing bkpr against k8s versions that are not advertised to be supported.

bors r+


IE freezes after clicking on "Select another booking"

When a user clicks on "Select another booking" in IE, loading is shown and browser freezes after a while and "IE to stop responding due to long time running script" warning is shown
Video: https://monosnap.com/file/et7UgzKVtNVbHxa7naqunTHwpV7kFS

possible related issue https://github.com/kiwicom/smart-faq/issues/554


Add converters for ignoring 'diagnostic' and 'genscenes' dev changes

Thanks!

As they are not used yet, where do you plan to use them for?

I'm using them for some empty messages from my Sengled E11-G13 and Osram bulbs
Sengled
3/15/2019, 10:43:56 AM - warn: No converter available for 'E11-G13' with cid 'seMetering', type 'devChange' and data '{"cid":"seMetering","data":{"currentSummDelivered":[null,703]}}'
3/15/2019, 10:43:57 AM - warn: No converter available for 'E11-G13' with cid 'haDiagnostic', type 'devChange' and data '{"cid":"haDiagnostic","data":{"lastMessageRssi":-68}}'
3/15/2019, 10:43:57 AM - warn: No converter available for 'E11-G13' with cid 'haDiagnostic', type 'devChange' and data '{"cid":"haDiagnostic","data":{"lastMessageRssi":-68}}'
Osram
3/15/2019, 1:49:57 AM - warn: No converter available for '73693' with cid 'genScenes', type 'devChange' and data '{"cid":"genScenes","data":{"count":0,"currentScene":0,"currentGroup":0,"sceneValid":0,"nameSupport":128}}'
3/15/2019, 1:49:57 AM - debug: Received zigbee message of type 'devChange' with data '{"cid":"genScenes","data":{"lastCfgBy":"0xffffffffffffffff"}}' of device 'LIGHTIFY A19 RGBW' (0x7cb03eaa00a68b4e)


KAFKA-7660: fix streams and Metrics memory leaks

Backport two memory-leak fixes (#5974 and #5953) (see also 2.1: #5979, 2.0: #5980, 1.1: #5981, 1.0: #5982, 0.11: #5983  )
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3817/
Test FAILed (JDK 7 and Scala 2.10).

Retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3818/
Test FAILed (JDK 7 and Scala 2.10).

Retest please

Retest this please

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3820/
Test FAILed (JDK 7 and Scala 2.10).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3821/
Test FAILed (JDK 7 and Scala 2.10).

QueryableStateIntegrationTest is known to be unstable... Will try again. If we can't get a green build, and test pass locally, we can merge, too, IMHO. Objections?
Retest this please.

@mjsax , ./gradlew clean :streams:test does pass for me locally on this branch.

Might as well try again...
Retest this, please.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3823/
Test FAILed (JDK 7 and Scala 2.10).

Tests passed locally for me. Merging.


docs: release process and adding new packages

Signed-off-by: Timo Glastra<EMAIL_ADDRESS>

@JamesKEbert let me know whether this is helpful, or you're missing someting

Codecov Report

Merging #35 (c41b4f2) into main (7b3073d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   84.98%   84.98%
=======================================
  Files          19       19
  Lines         393      393
  Branches       70       70
=======================================
  Hits          334      334
  Misses         59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3073d...c41b4f2. Read the comment docs.

Yes! Sorry this got lost in the sea of notifications, but again thanks @TimoGlastra for managing and documenting this. :)


Change block names during blueprint construction

The blocks used to have an axial character indicating axial height,
but this is inherently limited. That behavior is now delegated
to the plugins that need it so that more general inputs can be created.
Fixes #233.

The coverage drops are conspicuous, though...

The coverage drops are conspicuous, though...


Documentation

Readthedocs using mkdocs.
http://ericholscher.com/blog/2014/feb/27/how-i-judge-documentation-quality/

Please help me set up readthedocs.org the next time we meet.

Can you first sign up for an account in readthedocs and then I'll add you as a contributor to the mclearn doc?

My username is cong


DGJ 597/600 Add Form page description and change column from operations to actions

Summary
DGJ-597 Add description under title | Form tab
DGJ-600 Change column name from Operations to Actions | Form tab
Changes
Added description and changed column name.
Update CSS to align new changes into exiting component design
Notes
N/A

Looks good!


Is there a way to disable the border shadow?

Trying make the carousel stack float over a page but I can't figure out how to disable the border around the carousel item. I've managed to set the container background to transparent but there is still a shadowy border around the parent.
What I've tried:
          contentContainerCustomStyle={{opacity: 1, backgroundColor: Colors.transparent, shadowOpacity: 0}}
          containerCustomStyle={{opacity: 1, backgroundColor: Colors.transparent, shadowOpacity: 0}}

@Jonarod I assume you're talking about the example since there is no built-in shadow style in the carousel component itself.
The shadow component is rendered here. You can either modify its styles or delete it altogether.

??


Can't tweek the parameters enough for my specific setting

Hello, I'm trying to make the lib work for audio-only recordings of: 11025 Hz, 8 bits and 1 channel, is it supported? I've already tried with MediaStreamRecorder and StereoAudioRecorder - I always get "sample-rate must be under range 22050 and 96000" and my audios seem to slow down as I decrease the frequency. Any advices on how I can record audios with this specific setting and in normal speed? (artifacts and noise in the audio are expected)

"sample-rate must be under range 22050 and 96000"

This is a limitation of RecordRTC, a library this project uses. See https://stackoverflow.com/questions/26301771/webrtc-issue-when-using-recordrtc
A user there mentions you should modify RecordRTC and change these hardcoded values there.


I wantna to know how to perpare the .h5 file?

Hi vv:
i looking  a solution to make the .h5 file,for training my own dataset,but i dont't know how to do, Could you give me a help?

@EthonDeep , check out https://github.com/qianguih/RSNet, it's a very similar task / setup, I believe the tools for data preparation there are shared for SGPN since they're coauthors.

@@EthonDeep，thanks！

@Ziggareto ，thanks！

@Aivision-tang29  Hi，Have you completed the data(h5) preparation work? I have referenced the work of https://github.com/qianguih/RSNet. But the data i got doesnt  exactly match the SGPN. Did u change the  data preparation code in RSNet?
Could you give me a help?


Add 404 and 500 page #446

I found #446 under 'good first issue', the initial pull request was left behind.

the 500 page displays the exact same component with different text

I'm not sure this could be a problem, but the PR is mixed up with past commits. Can this be fixed?

hey @hashrock nice to see you👋
I'm not exactly sure why GitHub is showing those past commits, these are all commits that have been merged to https://github.com/denoland/fresh. My branch says it's 10 commits ahead of the master branch even though it's not, I'll try to figure this out.
We should be fine with merging this though if you look at the https://github.com/denoland/fresh/pull/614/files it won't apply any changes from my prior commits.

I need to redo any changes and make a new PR


Typo causing bug when using ab_test from controller

Now using  @choices instead of @choice, which is always nil. Bug pops up when using ab_test from controller, as the ViewHelper didn't have this typo.

Thanks.


ocamlPackages.cstruct: 6.0.1 -> 6.1.0

Description of changes
Updates cstruct and reverse dependencies.
This is breaking out parts from https://github.com/NixOS/nixpkgs/pull/165661
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Can you please move the update of the dns libraries to a separate PR for easier review & testing? Thanks.
Suggestions: version 6.3.0 is out; there is no need to set useDune2.

@vbgl with all the recent PRs that has landed I've cleaned this PR up to only cstruct, do you have a good idea how I can test this to make sure I didn't break a bunch of packages?
Would be nice if we could find reverse dependencies somehow.

This break ocamlPackages.git. I think that cstruct, git, carton, decompress, bigstringaf must be updated simultaneously.


Interesting behaviour of test cases and merging

So Michelle's updates were still failing the test cases, even after Yiwei's changes were merged. As far as I understand, the reason for this is that the test cases check if commit itself passes the test cases, rather than examining whether the main repo would pass them if the commit was integrated.
Since Michelle's commit lacked some of the more recent files, like the ._internals file, it was failing the test cases. In this case, I decided to merge even though the test cases were failing. Lo and behold, the test cases passed after merging.

The ideal workflow is:
Always keep individual branches updated with main. Eg. after my branch merged to master, Michelle should merge the current main to her own branch, resolve all the conflicts if any, and make sure all test cases and CI/CD checks pass.

I didn't know main could be merged into branches, thanks Yiwei. I'll make sure to do this as well going forward!

It was just a minor issue. Should have shared the knowledge during the meeting. No worry

I didn't know main could be merged into branches, thanks Yiwei. I'll make sure to do this as well going forward!


The Trained yolov5 Weights didn't Load to Model

Hi,
After training, the trained weights didn't load to model in validating process as you see in picture.
This action accrued in export_onnx process too.
thanks to neuralmagic team.

Hi @miladlink could you provide the command used to run the export command? It looks like the model is not getting quantized before weight reload, passing the recipe you used to train could help if not already

Hi @bfineran
Here is my command
sparseml.yolov5.train \
--data dataset.yaml \
 --cfg models_v5.0/yolov5s.yaml \
--weights zoo:cv/detection/yolov5-s/pytorch/ultralytics/coco/pruned_quant-aggressive_94?recipe_type=transfer \
--hyp data/hyps/hyp.finetune.yaml \
--recipe zoo:cv/detection/yolov5-s/pytorch/ultralytics/coco/pruned_quant-aggressive_94

Hi @miladlink this was an issue with an earlier version of our yolov5 fork, where the best model was loaded for validation, but best may not fall within the range of quantization. This was solved 12 days ago. If your version is older than that, I recommend updating it. The easiest way to do so is to run pip uninstall yolov5 and then re-run your sparseml command. The latest version of our yolov5 fork will automatically install on call.

Same issue here at the end fo the train, or the export, I got:
sparseml.yolov5.export_onnx \
--data data/datasets/dataset.yaml --weights yolov5_runs/train/exp14/weights/best.pt

And I got the error
Missing key(s) in state_dict: "model.0.conv.conv.weight", ...
Unexpected key(s) in state_dict: "model.0.conv.conv.quant.activation_post_process.fake_quant_enabled", ...

I have already uninstalled yolo5 and reinstalled sparseml[yolo] as well as installing manually the version of yolov5 from neurlalmagic
Tested with:
torch==1.9.0 and 1.9.1
sparseml==1.2.0

This issue is now resolved. Closing out the ticket, but if the issue persists feel free to re-open the issue.


Polyfill.io breaks legacy polyfill in IE11

Describe the bug
I don't know if I should report this bug to Polyfill.io or Vite. Please pardon me if this should not have been written here.
I'm building a website that needs to run on IE11. I'm using @vitejs/plugin-legacy for it.
If I load the Intersection Observer polyfill from polyfill.io, the legacy code Vite built doesn't work. (The error "System is undefined" seems to mean SytemJS doesn't work, and the client-side app doesn't load)

I tried searching around and debugging it but this is as much information as I could get.
On the reproduction, the important parts are:

Loading the polyfill https://github.com/lucasavila00/vite-polyfill-ie11/blob/main/index.html#L8
The polyfill https://github.com/lucasavila00/vite-polyfill-ie11/blob/main/public/polyfill.js
Vite legacy config https://github.com/lucasavila00/vite-polyfill-ie11/blob/main/vite.config.ts#L8
Async Vite bundle https://github.com/lucasavila00/vite-polyfill-ie11/blob/main/index.html#L12

The use-case of this website requires external JS to be loaded into my website.
I have verified that this Intersection Observer polyfill does not break Vite code: https://github.com/GoogleChromeLabs/intersection-observer but ideally my website should not break if external - non-adversary - JS is loaded.
Reproduction
https://github.com/lucasavila00/vite-polyfill-ie11
Steps to reproduce
npm install && npm run build && cd dist && python -m http.server
System Info
System:
    OS: Linux 6.2 Pop!_OS 22.04 LTS
    CPU: (16) x64 AMD Ryzen 7 3800X 8-Core Processor
    Memory: 44.64 GB / 62.72 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.10 - ~/.npm-global/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
  Browsers:
    Chrome: 113.0.5672.126
    Firefox: 112.0
  npmPackages:
    @vitejs/plugin-legacy: ^4.0.4 => 4.0.4
    vite: ^4.3.9 => 4.3.9

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Also reported to Polyfill.io https://github.com/Financial-Times/polyfill-service/issues/2751

plugin-legacy adds core-js's polyfills and it seems that is incompatible with polyfill.io.
Here's a repro without Vite/plugin-legacy.
https://github.com/sapphi-red-repros/core-js-object-create-polyfill-io-repro
I'll close this issue as I don't think there's something we can do on the plugin-legacy side.


Upgrade to net8.0

Utilize new syntax, e.g. A[3] instead of A.[3]

Time to pick this back up again, but now heading for net8


Chrome/Firefox on OS X and Linux

What would it take to get support for Vue.js on OS X and Linux in both Chrome and Firefox?
I'm currently building a production app with Vue.js and this is kind of a deal breaker.
Any Vue content just silently fails. Just try using the Vue.js site in Chrome on OS X. None of the examples work.

@markrjr So none of the examples in http://vuejs.org/examples work? Are you running any additional plugins? I'm using OS X with Chrome 51 and Firefox 47 and all of them work fine.

Hi!
Please make sure to ask the question on the forums or the gitter chat. We keep questions out of issues :smile:


Handle log file being deleted while being read

Traceback (most recent call last):
File "/home/seanf/Icarus_v2/src/MainWindow.py", line 220, in closeEvent
File "/home/seanf/Icarus_v2/src/DataHandler.py", line 170, in quit
self.period_handler.last_depressurize_bit = None
File "/home/seanf/Icarus_v2/src/Logger.py", line 62, in close
os.remove(self.filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/seanf/Icarus_v2/src/../logs/temp/log_2024-05-22_21-40-19.xz'
QThread: Destroyed while thread is still running
Aborted (core dumped)

ed7110d

ed7110d


Map generation path

Hi again. Simple feature request: A global config setting containing a path for maps to be generated to.

Dont think this 4yo feature is needed anymore


Backport "Disallow ill-staged references to local classes" to LTS

Backports #19869 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-19921.
Reference


[CSS] proprietary CSS, Fx 72 tasks

Trello
https://trello.com/c/ylLyrwja/12-proprietary-webkit-moz-features-fx-72
Acceptance criteria

[ ] Implement  using CSS Grid and remove nsStackFrame (intent to unship is more useful)

I'm not sure what we do here. Are we leaving these in the BCD table at this point?

I'd say this just needs:

marking of https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-stack-sizing with a deprecated notice
Updating of the -moz-stack data at https://developer.mozilla.org/en-US/docs/Web/CSS/display to say it is completely removed in 72. We probably better keep it for now, until we make a decision about what else to do with it.

Cool, just wanted to check I wasn't missing anything as I don't know much about these specific properties.

It looks like this might be reverted, looking at the bug https://www.dropbox.com/sh/1sor2llz3wbaq67/AADCRI1R8Yscmg4Xegv91Z0Sa?dl=0  so I'll hold fire for now and check it in a few days.

@chrisdavidmills this seems to have been reverted https://bugzilla.mozilla.org/show_bug.cgi?id=1576946#c33

this seems to have been reverted

Yup, looks like it. Let's close this for now in that case; nothing to do here.


Remove unsafe asElement and asText dynamic getters

These will crash if the object is not of the right type, and if we need to know the type to prevent crash, we can already do
fun test(node: XmlNode) {
    val element = node as? XmlElement
    val text = node as? XmlText
    TODO()
}

Instead, we should encourage the idiomatic usage of smart cast allowed by the sealed interface.
fun test(document: XmlDocument) {
    document.root.walk().map {
        when (it) {
            is XmlElement -> TODO()
            is XmlText -> TODO()
        }
    }
}

Unless you had something specific in mind for these extensions.

Unless you had something specific in mind for these extensions.

Kind of. Thinking about something like this:
<a>
  <b/>
  <b/>
  <b>
    Foo
  </b>
</a>

I can do something like:
File("index.html").toXmlDocument()
    .root
    .children[0]
    .asElement
    .children[2]
    .asElement
    .textContent

The same thing with as? and parenthesis or when sounds a lot more involved?

This makes perfect sense 👍
Though I'm not really used to having as* throwing.
Kotlin stdlib generally uses the convention to*() throwing and to*OrNull() never throwing.
But that's not a big deal.

FWIW, the Kotlin stdlib has internal Any.cast() that I'd like to have exposed by default.
That would make these two extensions mostly useless because the same thing could be:
File("index.html").toXmlDocument()
    .root
    .children[0]
    .cast<XmlElement>
    .children[2]
    .cast<XmlElement>
    .textContent

Maybe it'd make sense to just copy best that implementation in Xoxo. Feel free to open a PR, else I'll most likely do it at some point.

Thanks for the pointers, I was not aware of these "hidden" utils 💎


V2.0.0

Summary

Add units to plate_scale (backwards-incompatible, thus triggering a major version)
Test Data and/or Report

Enter info here
Related Issues

Enter related issues here

Thanks, but I think we decided to actually close this pull request and create a new one that goes to version 1.1 instead of 2.0.  Even though the addition of units to plate_scale is technically backwards-incompatible, nobody is yet using this LDD for any purpose except Dave, so we can say that the LDD is still "in development" and there's no need to drive up the version numbers at this point.
Please confirm whether this seems good, and then I'll close this PR, delete this branch, and create a new branch and PR with the version incremented to 1.1 and otherwise identical to this.

Oh I see. Yes, that seems good.

I've now created https://github.com/pds-data-dictionaries/ldd-hst/pull/11, so closing this PR and deleting the branch.


Document how to set up the built in LSP for Neovim

Thanks, I hope it would work for neovim users. If not I will either remove it later or ask for your help

closes #38

alright. if I can I would love to help more!


Broken Links on API Documentation

Describe the bug
A handful of the links to specific parameters (on the panel on the left) in the API documentation appear to be broken. They just take you to a blank page rather than navigating to the correct function.
The links with errors are:
Activity List
fields (optional)
sector vocabulary (optional)
Activity Transactions
activity-transaction
Transaction List
Transaction List
Request parameters
Activity Filter

fixed!!

@JoshStanleyDevInit  will you please check it and close this ticket?

@luminhan still getting the same issue!

All good now, thanks @luminhan


NIFI-1866 ProcessException handling in StandardProcessSession

@pvillard31 I got this merged into both master and 0.x baselines. Thanks for knocking this out!!


Fix npmlock2nix import

This changes the npmlock2nix import into a callPackage statement. Using
the import caused npmlock2nix to use its internally pinned version of
nixpkgs

Pre-submit checklist:

Branch

[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

If you updated any cabal files or added Haskell packages:

[ ] $(nix-build default.nix -A pkgsLocal.updateMaterialized) to update the materialized Nix files
[ ] Update hie-*.yaml files if needed

If you changed any Haskell files:

[ ] $(nix-shell shell.nix --run fix-stylish-haskell) to fix any formatting issues

If you changed any Purescript files:

[ ] $(nix-shell shell.nix --run fix-purty) to fix any formatting issues

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

Clean bill of health :1st_place_medal:


TypeError: chunk.isInitial is not a function

versions :
 "webpack": "^2.2.1"
"extract-text-webpack-plugin": "^2.1.0",

error :

\node_modules\extract-text-webpack-plugin\index.js:267
var shouldExtract = !!(options.allChunks || chunk.isInitial());
^
TypeError: chunk.isInitial is not a function
at \node_modules\extract-text-webpack-plugin\index.js:267:55
at \node_modules\extract-text-webpack-plugin\node_modules\async\dist\async.js:3025:16
at eachOfArrayLike (\node_modules\extract-text-webpack-plugin\node_modules\async\dist\async.js:940:9)
at eachOf (\node_modules\extract-text-webpack-plugin\node_modules\async\dist\async.js:990:5)
at Object.eachLimit (\node_modules\extract-text-webpack-plugin\node_modules\async\dist\async.js:3089:3)
at ExtractTextPlugin. (\node_modules\extract-text-webpack-plugin\index.js:265:10)
at Compilation.applyPluginsAsync (\node_modules\gulp-webpack\node_modules\tapable\lib\Tapable.js:71:13)
at Compilation.seal (\node_modules\gulp-webpack\node_modules\webpack\lib\Compilation.js:525:7)
at Compiler. (\node_modules\gulp-webpack\node_modules\webpack\lib\Compiler.js:397:15)
at \node_modules\gulp-webpack\node_modules\tapable\lib\Tapable.js:103:11
at Compilation. (\node_modules\gulp-webpack\node_modules\webpack\lib\Compilation.js:445:10)
at \node_modules\gulp-webpack\node_modules\webpack\lib\Compilation.js:417:12
at \node_modules\gulp-webpack\node_modules\webpack\lib\Compilation.js:332:10
at \node_modules\async\lib\async.js:52:16
at done (\node_modules\async\lib\async.js:246:17)
at \node_modules\async\lib\async.js:44:16

for some reason I could not attach the ZIP to the message, so here a link to simple standalone project : https://ufile.io/596a0

Here's the project - https://github.com/jony89/simple-webpack-extract-plugin .
I tried this on macOS (Node 6.9.1) and it completed without any problems.
I wonder if it's Windows specific.

@bebraw I ran it on win7 & node 6.8.0
updated to node 6.10.0 and same issue. I find it hard to believe it is specific to win7.
to run the project correctly (in case u didnt) :
in console :

npm install
gulp

Ah... You ran it through Gulp. I get the error then too if go through node_modules/.bin/gulp.
If you execute node_modules/.bin/webpack, it builds as you might expect.
I can see you are using gulp-webpack. You probably want to use webpack-stream instead as gulp-webpack isn't actively maintained by the looks of it.

Quick look at gulp-webpack, seems that it has "webpack": "^1.12.9" as a dependency. webpack-stream seems to have the same issue.
Not really familiar with their implementations, but they probably should have webpack as a peer dep.

@kostasmanionis Nice! That explains it.
@jony89 Please open issues at those projects unless they have ones open already. There's nothing we can do about the issue in this plugin as it's an upstream issue.

tnx, temporary solution is to give webpack-stream your own webpack version:
webpackStream(config, require('webpack'))

see https://github.com/shama/webpack-stream/issues/125


Update deps of my_scala_xml_provider

Description
The example didn't work for me, but using io_bazel_rules_scala_scala_xml worked.
Motivation
The example appears to be wrong.

Sorry, I'm not gonna sign the CLA.

@ahe-humio thanks for PR. I know this is confusing, but I don't recommend using rules_scala external names outside rules_scala repository (I mean all deps prefixed with @io_bazel_rules_scala), because they are subject to internal implementation change. Therefore most of the deps in the example should be replaced with something else. Those deps should come from user's WORKSPACE, probably using some maven deps loader, like https://github.com/bazelbuild/rules_jvm_external. Practical example: https://github.com/liucijus/rules-scala-proto-toolchain/blob/main/BUILD.
Regarding the current doc. It needs to be improved to describe better where the deps come from. Maybe it can use Rules Jvm External names, so it's more obvious where these names come from.


Added antlr topic.

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[x] Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])

[x] My folder contains a *.png image (if applicable) and index.md

[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Thanks so much for your first contribution!  You rock, @KvanTTT!


Update README.md

serde-0.9 no longer has this bug;
testing lsd with a zero-byte colors.yaml works just fine showing the default theme.

TODO

[ ] Use cargo fmt
[ ] Add necessary tests
[ ] Update default config/theme in README (if applicable)
[ ] Update man page at lsd/doc/lsd.md (if applicable)

This is a readme only change - how important/possible are the standard todos above?

hi @tomterl, good catch! it's ok to ignore them for a doc update


Sakoe chiba band

This PR implement some way of using the Sakoe-Chiba bands for non-squared matrices. It does so by computing the approximate diagonal: the indices of the smallest input matrix are interpolated onto the indices of the biggest input matrix. This should address #8 and #18.
The case where N=4, M=7 and bandwidth=1 gives something similar to:
D = [
[x, x, -, -, -, -, -]
[-, x, x, -, -, -, -]
[-, -, -, x, x, -, -]
[-, -, -, -, -, x, x]
]
Note that:

the rounding in the interpolation of the indices (for instance, i_sc = i * N / M) could be formalised. I did not look too much into it.
other way of providing the input could be implemented, for example using a relative size as mentioned in the doc linked above.

This was tested like so:
In [1]: import torch

In [2]: import soft_dtw_cuda

In [3]: a = torch.rand((100, 40, 15))

In [4]: b = torch.rand((100, 50, 15))

In [5]: sdtw_cpu_sc3 = soft_dtw_cuda.SoftDTW(False, bandwidth=3)

In [6]: res_a = sdtw_cpu_sc3(a, b)

In [7]: torch.any(res_a == torch.inf)
Out[7]: tensor(False)

In [8]: sdtw_gpu_sc3 = soft_dtw_cuda.SoftDTW(True, bandwidth=3)

In [9]: res_b = sdtw_gpu_sc3(a.cuda(), b.cuda())

In [10]: torch.any(res_b == torch.inf)
Out[10]: tensor(False, device='cuda:0')

In [11]: torch.allclose(res_a, res_b.cpu())
Out[11]: True

Thanks for this great contribution, really appreciate it! :)
I need some time to study and verify it. In the mean time, could you explain this a bit more?

the rounding in the interpolation of the indices (for instance, i_sc = i * N / M) could be formalised. I did not look too much into it.

Rounding, could you explain this a bit more?
There is a proper way of computing the interpolated indices, especially with regards to rounding the result of the division between integers. Should the result be rounded to the closest integer, or floored or ceiled?
There is some source code available in pyts, for example in the function pyts.metrics.sakoe_chiba_band there is a lot of code for that.
The PR as it is now does it in a naive way, but affords OK results for non-squared matrices (instead of returning inf).
This could or should be tested against pyts maybe?


Remove unneeded event-flaker test image import (#2987)

Signed-off-by: Christoph Stäbler<EMAIL_ADDRESS>

https://github.com/openshift/release/pull/36826

/retest


Access json from POST REQUESTS in response by handlebars

It is possible to access the json data from the POST-Requests directly in my response, which i sent to the API?
For example:
I send something like this to the converse-endpoint:
{
"text": "Hello Iam Herbert",
"user_id": "32183"
}
It is possible to get the user_id json field by handlebars in my agent response?
Like {{ request.user_id }}
Its possible for the slots, for the webhook response but i want to access the json data, which i send to the api.

Extra keys that you supply during the post request are available at the top level of the CSO. So if you're incoming request was:
{
  "text": "Hello Iam Herbert",
  "user_id": "32183"
}

You would access the user_id in responses with {{user_id}}


Version 9.0.0 making error while installing with yarn

[x] Review the documentation: https://github.com/oblador/react-native-vector-icons
[ ] Search for existing issues (including closed issues): https://github.com/oblador/react-native-vector-icons/issues

Environment
Windows 10
Yarn 1.22.17
NPM 8.0
react-native-vector-icons 9.0.0

Description
The package is upgraded 2 weeks before, i was using the older version than 9.0.0 and after upgrading the package it started making error while installing the packages with yarn where as it worked fine with the npm, and its not only on my computer i checked other system too but same behavior then i downgraded 1 version of react-native-vector-icons and it worked perfectly, the issue is caused because i am using one other package which also has the dependency of react-native-vector-icons.

Reproducible Demo
error An unexpected error occurred: "could not find a copy of react-native-vector-icons to link in Path\node_modules\react-native-bouncy-checkbox\node_modules"

.

I have the same issue( with react-native-bouncy-checkbox 9.0.0 works not good

same issue, i just uninstalled bouncy-checkbox and the error went away

This is likely due to different versions being included, if still an issue please comment and I'll reopen and assist


refactor: Move "send button" related code from compose_validate.js  to compose.js.

This commit moves "send button" related code from
compose_validate.js to compose.js as it makes more
sense there.

Testing plan:
GIFs or screenshots:

Merged, thanks @Riken-Shah!  I posted one comment on a potential final follow-up to this migration.


Fix & Instruction of adding manual native package

Proper Kotlin syntax and instruction on how to add native package manually.
I followed the official documentation and applied the "Kotlin" syntax. I believe it had the leftover comment/instruction of java syntax, which I replaced with Kotlin syntax.

Summary:
The comment/instruction on manual native package isn't correct. Also the existing code isn't intuitive for developer to easily add a native package manually.
Changelog:
[ANDROID] [CHANGED] - Allowed developer easily add a native package manually, with proper instruction.
Test Plan:
Applied the change from the official docs - https://reactnative.dev/docs/native-modules-android?android-language=kotlin
Also in my own project - I was able to add native package manually using that syntax.

Closing as already another PR with same fix got merged.
https://github.com/react-native-community/cli/pull/2236


Contact mechanics sidebar is too small but doesn't fill all space

This has been completely redesigned and will receive another update in the next version.