Link next/prefetch TypeError

Hi,
I get following error in console while using Link from next/prefetch. Though, the link is working and goes to other page.

Parameter 'url' must be a string, not undefined.

Just installed next and run npm run dev.

Hi @intermundos can you paste the error information from the devtools/provide more information? thanks

url.js?d390d15:112Uncaught (in promise) TypeError: Parameter 'url' must be a string, not undefined     at Url.parse (http://localhost:3000/_next/commons.js:3988:11)     at urlParse (http://localhost:3000/_next/commons.js:3982:5)     at getPrefetchUrl (http://localhost:3000/_next/commons.js:11797:34)     at _callee$ (http://localhost:3000/_next/commons.js:11599:19)     at tryCatch (http://localhost:3000/_next/commons.js:15901:40)     at Generator.invoke [as _invoke] (http://localhost:3000/_next/commons.js:16192:22)     at Generator.prototype.(anonymous function) [as next] (http://localhost:3000/_next/commons.js:15953:21)     at step (http://localhost:3000/_next/commons.js:2647:30)     at http://localhost:3000/_next/commons.js:2665:14     at F (http://localhost:3000/_next/commons.js:1675:28)

Also, please tell me what information you need and I will gladly provide it.
Thanks.

@intermundos Tried to reproduce and couldn't. Is it possible to see the code of your page?

This is index page with the link.
import React from  'react'
import Link        from 'next/prefetch';

export default class extends React.Component {

	render (){
		return (

Hello world!

				<Link>Home</Link>

		)
	}
}

Oh, try to move the href='/home' to the link:
	render (){
		return (

Hello world!

				<Link href="/home">Home</Link>

		)
	}

Oh my eyes. Thanks.

Glad it worked


Edits to new instructions

Description
Updates to the updating instructions. Check that these make sense.
Merges into refactor branch.
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

@Aashiq-J a couple of comments or questions

"...Workspace ID for the project towards the right-hand side of the screen."

I didn't see any workspace IDs there. Did you mean on the Manage page, under ID?

I got rid of the docs link about the API keys because I didn't think it applied. You're not "CRUD-ing" the key here. Let me know if you were trying to provide some other information.

@SirSpidey ,
You missed these steps:

@Aashiq-J @ocofaigh
Pushed up some changes based on your review.
Question
Are the 3.x.x and 4.xx labels meant to indicate any version (as in v3.0.0 and later) or are they placeholders for specific versions that we will change?
If they mean update v3 to v4, let's remove the .x.x and use version 3 and 4. The script can stay as it is as far as i'm concerned.

@SirSpidey it means update v3 to v4, so agree lets remove the .x.x


BasicSub logs core dump when reporting inactive connection following BasicPub suspension

Summary:
The BasicSubscriber core dumps when reporting inactive connection after the BasicPublisher is suspended using Ctrl-Z
Initial Conditions:
Using default values
Procedure:
Start the mediaDriver using the following command:
java -cp samples.jar -Daeron.dir=/dev/shm/ag/aeron uk.co.real_logic.aeron.driver.MediaDriver
Start the BasicSubscriber using the following command:
java -cp samples.jar -Daeron.dir=/dev/shm/ag/aeron uk.co.real_logic.aeron.samples.BasicSubscriber
Start the BasicPublisher using the following command
java -cp samples.jar -Daeron.dir=/dev/shm/ag/aeron uk.co.real_logic.aeron.samples.BasicPublisher
The subscriber received a few messages before the publisher was suspended via Ctrl-Z.  After 5 secs, the publisher was resumed.  From the publisher's console, it appears messages are still being sent. However, the subscriber does NOT receive any messages.
This scenario has been executed ~7 times. The subscriber core dumped twice.
The first time the subscriber did not receive any additional messages after the publisher was resumed, reported the INACTIVE connection, and then core dumped.
The second time the subscriber did not report the INACTIVE connection on the console, however it still did not receive any messages and it core dumped.
Below is the output of the second error:
#  SIGSEGV (0xb) at pc=0x00007f3a74925bf0, pid=6366, tid=139889377175296
#
# JRE version: Java(TM) SE Runtime Environment (8.0_05-b13) (build 1.8.0_05-b13)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.5-b02 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# J 363 C2 uk.co.real_logic.aeron.Subscription$$Lambda$12.apply(Ljava/lang/Object;I)I (9 bytes) @ 0x00007f3a74925bf0 [0x00007f3a74925ae0+0x110]
#
# Core dump written. Default location: /home/agladney/aeron/aeron-samples/build/libs/core or core.6366
#
# An error report file with more information is saved as:
# /home/agladney/aeron/aeron-samples/build/libs/hs_err_pid6366.log
Inactive connection on udp://localhost:40123 streamId 10 sessionId 80e15b90 @ position 640
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.sun.com/bugreport/crash.jsp
#
Aborted (core dumped)

Question regarding the expected results:
Even though the client liveness timeout is 5 secs, when the publisher  resumes, it is NOT a new publisher or session. Therefore, communication should continue and the connection should NOT be declared inactive. Is this correct?
hs_err_pid6366.log | uploaded via ZenHub

Would you be so kind to retest this with the latest and let us know what happens?

I've run this a number of times since @tmontgomery's latest fixes, and I haven't seen any SEGVs on the BasicSubscriber.


Replace parameter_types with ConstU32 &c.

Most simple parameter_types declarations can be replaced with the new ConstU32, ConstU64, ConstU128 and ConstBool, reducing some unneeded verbosity.

Picking this up @gavofyork

@gavofyork i see in your PR here https://github.com/paritytech/substrate/pull/10382 that you have defined the implementation for ConstU64, ConstU128 and ConstBool, as only  ConstU32 is available in master.
Should i wait for your PR to get merged before solving this issue?

You could just start on a branch which brings in that change.

When you say start on a branch, Are you saying i should start off on my own branch which I already started(changing parameter types for ConstU32)?

YEs, you could copy that code in if it's going to be useful (and it probably is).

I have started the implementation as opened in the PR
@gavofyork

Fixed by #10402.

some place could still be replaced https://github.com/paritytech/substrate/pull/10402#issuecomment-995374677

This issue is still open?

@bizzyvinci have you checked the mentioned code?

Yes.
[This] seems resolved already but the issue remains open


fix(html): ensure head tag when injecting

Description
After adding tests for #5315, I saw that when there isn't a <head> tag, Vite injected the script tags at the beginning of the HTML. 'head-prepend', that is the default is currently defined to inject at the start of the <head> tag if present or after <doctype>. But if the user selects 'head', I think we should create a <head> tag if it isn't present. This is also what Vite uses internally to add the script modules, preload tags, etc, and currently, if there isn't a <head> we are not correctly placing these scripts as expected.
This PR modifies the logic for injectTo head to ensure that there will always be a <head> tag when needed.
Additional context
I think we could do the same for 'head-prepend', and always ensure the presence of a <head> tag when injecting. Or maybe I'm missing a drawback explaining why this was not done before.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Closing this, I think it wasn't done because there are several edge cases to consider. It is more robust to ask users to add the <head> tag in their HTML themselves


Flux Points Power Drain

Flux Points are draining power on what ever its set at instead of just power being used
EG. If you set to ignore or 256k limit it drains all the power you have stored even if you only using, say 2krf/t

What Transfer Mode are you using and how many points and other things do you have setup. Also what block is it draining from?

just using the default settings and have it connected to a draconic storage
sphere have 21 points but only using 33.4krf/t and it's draining the whole
256k I had to set the limit to the amount of power using, when I set ignore
limit drains the energy sphere instantly I tried using other forms instead
of connecting directly to sphere same thing happens though, it was fine
till I updated flux a couple days ago, great mod by the way
I didn't really notice till I started producing 8mil RF/t was wondering
where it was going disconnected all point was still doing it so it's the
green flux receiver that drains
On Apr 13, 2017 6:50 PM, "Ollie Lansdell"<EMAIL_ADDRESS>wrote:

What Transfer Mode are you using and how many points and other things do
you have setup. Also what block is it draining from?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SonarSonic/Flux-Networks/issues/95#issuecomment-294050079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APU8fDBcEdzjEJsKjfyYEEalFVzIrxQ8ks5rvrTbgaJpZM4M8_QX
.

This is the case when you remove limit on the controller and allow transmitter mode. It burns energy as though you are always charging even if you are full.

I can confirm. I m having the same issue. It just burned my T7 draconic power storage.

After replacing the same bug in beyond 1.5.3, here is what i've found:

Seems to have no issue putting RF into the Draconic Storage.
Pulling from the Draconic Storage, once you pass 20K RF/T it seems to just vanish.  This means if you put the max default limit, it will drain that much RF instantly.
If you are trying to pull more than 20K rf/t it simply won't pull the energy.  I had machines being non-powered when i tried to pull more than 20K rf/t.
Creating multiple energy networks and limiting them to 20K rf/t seems to be a workaround.

I've made a video demonstrating the energy cell issue when ignoring limit: https://youtu.be/SbzIBkQP-OM

@coneyaw What is your input coming from?

Okay never mind i've recreated now. That's for the video.

Fixed in dev

I'm having this issue again

Also having this issue again

Is it the latest version?

Also having this issue again

The version in Skyfactory 4: 1.12.2-3.0.19-21

That should have been fixed in any 4.x version, and the latest version is 4.0.14

The version in Skyfactory 4: 1.12.2-3.0.19-21

I have a similar issue.
We have a point on an MFSU, that leads to Flux Network storages.
All the power gets drained from the Flux Network storage, even though it is much more than what the MFSU can take.
Using IC2 Classic btw.
Currently latest version of Flux Networks, which is fluxnetworks-1.12.2-4.0.14-31

Having this issue with Ender Energy Conduits from EnderIO, not entirely sure why but a temporary fix that's working so far is to use a flux point on every device that wants power. Tedious, but functional.

Same issue as @dylithian. On version 1.12.2-4.0.14-31. One of my points is trying to draw all 21m of power. I had to limit it to 8k but even then it still draws that full 8k even when the machines attached to it aren't requesting any power.

Made an account just to confirm this is happening. Playing with Draconic evolution on 1.12.2 and it drains all the millions and millions of RF from the core to the flux plug.  Funny thing is it didn't happen before but all of a sudden it started doing that.

Wanted to add to the discussion that this effect seems to be random. One plug will only pull the actual used power while another will pull millions of rf a tick. I've fixed some by breaking the plug, making a new one, and placing that new one.


Avoid to generate path column in queries

MATCH (person:Person)-[e:KNOWS*1..3]-(friend:Person{firstName: "John"})
WHERE id(person) == "p-65504" AND id(friend) != "p-65504"
WITH friend, id(friend) as friendId, min(size(e)) AS distance, friend.Person.lastName AS lastName
ORDER BY distance ASC, lastName ASC, friendId ASC
LIMIT 20
MATCH (friend)-[:IS_LOCATED_IN]->(friendCity:Place)
OPTIONAL MATCH (friend)-[studyAt:STUDY_AT]->(uni:Organisation)-[:IS_LOCATED_IN]->(uniCity:Place)
WITH
  friend,
  collect(
    CASE uni.Organisation.name
      WHEN null THEN null
      ELSE [uni.Organisation.name, studyAt.classYear, uniCity.Place.name]
    END
  ) AS unis,
  friendCity,
  distance
OPTIONAL MATCH (friend)-[workAt:WORK_AT]->(company:Organisation)-[:IS_LOCATED_IN]->(companyCountry:Place)
WITH
  friend,
  collect(
    CASE company.Organisation.name
      WHEN null THEN null
      ELSE [company.Organisation.name, workAt.workFrom, companyCountry.Place.name]
    END
  ) AS companies,
  unis,
  friendCity,
  distance
RETURN
  toInteger(substr(id(friend), 2)) AS friendId,
  friend.Person.lastName AS friendLastName,
  distance AS distanceFromPerson,
  friend.Person.birthday AS friendBirthday,
  friend.Person.creationDate AS friendCreationDate,
  friend.Person.gender AS friendGender,
  friend.Person.browserUsed AS friendBrowserUsed,
  friend.Person.locationIP AS friendLocationIp,
  friend.Person.email AS friendEmails,
  friend.Person.speaks AS friendLanguages,
  friendCity.Place.name AS friendCityName,
  unis AS friendUniversities,
  companies AS friendCompanies
ORDER BY distanceFromPerson ASC, friendLastName ASC, friendId ASC
LIMIT 20

MATCH (person:Person)-[:KNOWS]-(friend)
WHERE id(person) == "p-65504"
WITH person, collect(id(friend)) AS friends
MATCH (person:Person)-[:KNOWS*2]-(friend)-[:IS_LOCATED_IN]->(city:Place)
WHERE id(friend) != "p-65504" AND id(friend) NOT IN friends
WITH person, city, friend, datetime(friend.Person.birthday) as birthday
WHERE (birthday.month==5 AND birthday.day>=21) OR
        (birthday.month==(5%12)+1 AND birthday.day<22)
WITH DISTINCT friend AS f, city AS c, person AS p
OPTIONAL MATCH (f)<-[:POST_HAS_CREATOR]-(post:Post)
OPTIONAL MATCH (p)-[:HAS_INTEREST]->()<-[:HAS_TAG]-(post)
WITH f AS friend,
     c AS city,
     count(*) AS postCount,
     count(post) AS commonPostCount
RETURN toInteger(substr(id(friend), 2)) AS personId,
       friend.Person.firstName AS personFirstName,
       friend.Person.lastName AS personLastName,
       commonPostCount - (postCount - commonPostCount) AS commonInterestScore,
       friend.Person.gender AS personGender,
       city.Place.name AS personCityName
ORDER BY commonInterestScore DESC, personId ASC
LIMIT 10

MATCH (person)-[:KNOWS*1..2]-(friend)-[:IS_LOCATED_IN]->(city:Place)-[:IS_PART_OF]->(country:Place)
WHERE id(person) == "p-8796093163356" AND id(friend) != "p-8796093163356" AND country.Place.name != "Papua_New_Guinea" AND country.Place.name != "Namibia"
WITH DISTINCT friend
MATCH (friend)<-[:POST_HAS_CREATOR|COMMENT_HAS_CREATOR]-(message)-[:IS_LOCATED_IN]->(country)
WHERE country.Place.name IN ["Papua_New_Guinea", "Namibia"] AND
    CASE
    WHEN message.`Comment`.creationDate < datetime(1306886400)+Duration({days:52}) AND message.`Comment`.creationDate >= datetime(1306886400) THEN true
    WHEN message.Post.creationDate < datetime(1306886400)+Duration({days:52}) AND message.Post.creationDate >= datetime(1306886400) THEN true
    ELSE false
    END
WITH friend,
     CASE WHEN country.Place.name == "Papua_New_Guinea" THEN 1 ELSE 0 END AS messageX,
     CASE WHEN country.Place.name == "Namibia" THEN 1 ELSE 0 END AS messageY
WITH friend, sum(messageX) AS xCount, sum(messageY) AS yCount
WHERE xCount>0 AND yCount>0
RETURN tointeger(substr(id(friend), 2)) AS friendId,
  friend.Person.firstName AS friendFirstName,
  friend.Person.lastName AS friendLastName,
  xCount,
  yCount,
  xCount + yCount AS xyCount
ORDER BY xyCount DESC, friendId ASC
LIMIT 20

MATCH (person)-[:KNOWS*1..2]-(friend)-[:IS_LOCATED_IN]->(city:Place)-[:IS_PART_OF]->(country:Place)
WHERE id(person) == "p-8796093163356" AND id(friend) != "p-8796093163356" AND country.Place.name != "Papua_New_Guinea" AND country.Place.name != "Namibia"
WITH DISTINCT friend
MATCH (friend)<-[m:POST_HAS_CREATOR|COMMENT_HAS_CREATOR]-()-[:IS_LOCATED_IN]->(country)
WHERE country.Place.name IN ["Papua_New_Guinea", "Namibia"] AND
      m.creationDate < datetime(1306886400)+Duration({days:52}) AND m.creationDate >= datetime(1306886400)
WITH friend,
     CASE WHEN country.Place.name == "Papua_New_Guinea" THEN 1 ELSE 0 END AS messageX,
     CASE WHEN country.Place.name == "Namibia" THEN 1 ELSE 0 END AS messageY
WITH friend, sum(messageX) AS xCount, sum(messageY) AS yCount
WHERE xCount>0 AND yCount>0
RETURN tointeger(substr(id(friend), 2)) AS friendId,
  friend.Person.firstName AS friendFirstName,
  friend.Person.lastName AS friendLastName,
  xCount,
  yCount,
  xCount + yCount AS xyCount
ORDER BY xyCount DESC, friendId ASC
LIMIT 20


Bug/41 plus feedback

LGTM

Please squash the PR to two commits (one yours and one of @mbovo ) in order to give credit to him


Update nested grid padding

Padding around a nested grid in the Master Detail AG Theme story should be --spacing-300.

Need to figure out the best way to make these examples available in Figma. Should everything be available as a sticker?

Need to update

https://github.com/jpmorganchase/salt-ds/blob/07528aab0178d2611534e7d5c176008d358e0f33/site/src/examples/ag-grid-theme/MasterDetail.tsx#L24
https://github.com/jpmorganchase/salt-ds/blob/07528aab0178d2611534e7d5c176008d358e0f33/packages/ag-grid-theme/src/examples/MasterDetail.tsx#L22


Userstore Password Automatically Resets When Updating Other Properties.

Describe the issue:
When updating another property of the user store, such as modifying Immutable Attributes in advanced properties, if the user store password is also updated simultaneously, it results in an error.
Note: This issue was identified intermittently.

How to reproduce:

Configure an Active Directory/ LDAP
Set it up as a secondary userstore
From your Mangement console
Redirect to Userstore -> Select the Userstore -> Edit -> Advanced
Change Immutable Attributes property value
Update the changes.

Expected behavior:
The Password Should not be updated unless it is actually changed.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

This is not reproducible in the latest pack.
Tried configuring an AD and changing properties through management console and react console. But the password did not get reset and the above error was not reproduced. Therefore closing this issue since it might be fixed with the latest changes.

Can not reporduce in IS side.Hence closing the issue.


fix(app, app-shell): Support protocol backwards app compatibility

Closes RQA-1509

Overview
This PR fixes an issue where users who downgrades their app from v7.0.0 to 6.3.1 or lower whitescreen on startup due to protocols supporting modules not present in previous versions. Because a v6.3.1 and 7.0.0 version of the app must both be supported until OT-2/Flex app parity, there's need for a workaround solution.
The Immediate Problem
In order to solve this issue without deploying a hotfix for 6.3.1, protocols for version 7.0+ are stored in a new protocols folder (within the same directory as the old). A migration occurs on startup where new protocols added in the 6.3.1 app are copied over for use within the 7.0.0 app.
Although customers will not create 7.0+ exclusive protocols in the 6.3.1 app, this has been true for developers until this PR is merged. In order to prevent downgrade issues, a temporary shim is added to delete incompatible protocols with the 7.0.0 app from the old protocols directory. This shim will be removed after the next 7.0 release.
Using a copy rather than a simple folder rename prevents users who have both versions of the app from seeing none of their protocols in the v6.3.1 version.
NOTE: Very large protocol files take a while to transfer and may result in a temporary whitescreen on app startup, however, in practice this should not be an issue in practice- only significantly large protocols made with the purpose of testing protocol size will cause noticeable delay.
The Future Problem
To prevent the need for a stop-gap solution in the future, a simple error boundary is added.

Test Plan

Open the app on this branch.
Observe protocol migration by going to /Users/user_name/Library/Application Support/Opentrons/ and opening the protocols and protocols_v7.0-supported directories. Only protocols before the v6.3.1 release date are present in the former directory, and all protocols are present in the latter directory.
Use the protocol below, which is for a module that doesn't exist (manually add it to the new protocols directory). Observe the error message upon app restart.
34564c7z-f57a-4ca6-9e2f-725aedeb1149.zip

Changelog

Added temporary stop-gap to migrate protocols until app parity.
Added protocol error boundary to prevent this issue from occurring in the future.

Risk assessment

low

Let me test this branch on Windows machine


Support for case format LOWER_CAMEL in naming convention

Currently, thrifty has 2 policies for field name - DEFAULT and JAVA. Checkstyle by default and mostly configured to check for lowerCamelCase in java.
How about a third naming policy for lowerCamelCase? We can use guava's CaseFormatter to determine the current case format. If it is not equal to CaseFormatter.LOWER_CAMEL convert to the same.
Should be very trivial.

FieldNamingPolicy.JAVA already does lower-camel-case, unless the field begins with a capitalized acronym.  This conforms with standard Java naming style.  How would FieldNamingPolicy.LOWER_CAMEL differ?

This particular unit test failed:
    @Test
    public void defaultNamesAreUnaltered() {
        FieldNamingPolicy policy = FieldNamingPolicy.DEFAULT;

        assertThat(policy.apply("SSLFlag"), is("SSLFlag"));
        assertThat(policy.apply("MyField"), is("MyField"));
        assertThat(policy.apply("ssl_field"), is("sslField")); // It fails
    }

java.lang.AssertionError:
Expected: is "sslField"
     but: was "ssl_field"
Expected :sslField
Actual   :ssl_field
 <Click to see difference>

The current FieldNamingPolicy.java just makes first character lower case if it is not part of some acronym.
if (Character.isUpperCase(name.charAt(0))) {
                if (name.length() == 1 || !Character.isUpperCase(name.charAt(1))) {
                    name = Character.toLowerCase(name.charAt(0)) + name.substring(1);
                }
            }
            return name;

Ah, I see - I think it's reasonable for the JAVA policy to convert snake_case to camelCase.

Ideally, Java should handle this case but it will break backward compatibility for anyone using the same in production.  How about deprecating the JAVA policy and introducing a new naming policy?

That's true, but I'm OK with that outcome.  I don't think anyone who has snake-cased thrifts is using the java-style naming policy - as you notice, it simply doesn't do anything useful in that case.  We can call out the breakage in release notes, but I doubt anyone will actually be broken.

Note that guava's case formatting doesn't play nice with acronyms, which forced us to move away from it


Can't get the modal to work

Hey,
I am having some trouble with my modal in my website as it doesn't work properly in my site.  The following is the code:
          Watch a video here of Damian

                   <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button>

                       <video width="560" height="315" src="../library/recognising_why_your_child_cant_talk_or_understand_language.mp4" frameborder="0" gesture="media" class="embed-responsive-item" allow="encrypted-media" allowfullscreen></video>

And this is what it looks like on the website:

Hope that someone can help me with the problem?

Sorry, but we cannot help with how-to or general troubleshooting issues here; only bug reports and feature requests. You'll want to ask around in the official Slack team or Stack Overflow. See our readme for more details.


nginx: /var/spool/nginx/proxy_temp/2/03/0000000032" failed (13: Permission denied)

Describe the bug
I made some change to my config, ran nixos-rebuild switch and I got some permission denied errors.
To Reproduce
Steps to reproduce the behavior:
Note that I don't use proxy_store on on the machine I got the problem with.
  services.nginx = {
    enable = true;
    enableReload = true;

    virtualHosts = {
      "default" = {
        default = true;
        locations."/" = {
          proxyPass = "https://google.com";
          extraConfig = ''
          proxy_store on;
          '';
        };
      };
    };
  };

May 12 19:48:18 nixos nginx[28867]: 2020/05/12 19:48:18 [crit] 28867#28867: *114 open() "/var/spool/nginx/proxy_temp/2/03/0000000032" failed (13: Permission denied) while reading upstream, client: <IP_ADDRESS>, server: default, request: "GET /?c=home HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/?c=home", host: "<IP_ADDRESS>"

Expected behavior
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
It only happens with enableReload = true;.
nobody vs nginx?
[bbigras@nixos:~]$ sudo ls -l /var/spool/nginx/
total 28
drwx------  2 nobody nginx 4096 May 12 15:47 client_body_temp
drwx------  2 nobody nginx 4096 May 12 15:47 fastcgi_temp
drwx------  4 nginx  nginx 4096 May 12 19:30 html
drwxr-x---  2 nginx  nginx 4096 May 12 15:47 logs
drwx------ 12 nobody nginx 4096 May 12 19:30 proxy_temp
drwx------  2 nobody nginx 4096 May 12 15:47 scgi_temp
drwx------  2 nobody nginx 4096 May 12 15:47 uwsgi_temp

If I run sudo chown -R nginx /var/spool/nginx/proxy_temp it temporarily fixes the problem.
[bbigras@nixos:~]$ ps aux | grep nginx
nginx    24991  0.0  0.6  23040  9352 ?        Ss   19:37   0:00 nginx: master process /nix/store/xx2spfxmgzm48x3kx7isba7pqgfbp102-nginx-1.18.0/bin/nginx -c /etc/nginx/nginx.conf -p /var/spool/nginx
nginx    28867  0.0  0.2  23044  4028 ?        S    19:44   0:00 nginx: worker process

Notify maintainers
@thoughtpolice @raskin @fpletz @globin
Metadata

system: "x86_64-linux"
host os: Linux 5.4.39, NixOS, 20.09pre225264.683c68232e9 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.4
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

If you want a nixos test file:
import ./make-test-python.nix ({ pkgs, ... }: {
  name = "nginx-issue-87698";

  nodes = {
    webserver = { pkgs, lib, ... }: {

      services.nginx = {
        enable = true;
        enableReload = true;

        virtualHosts = {
          "default" = {
            default = true;
            locations."/" = {
              proxyPass = "https://google.com";
              extraConfig = ''
          proxy_store on;
          '';
            };
          };
        };
      };
    };
  };

  testScript = ''
    start_all()
    machine.wait_for_unit("nginx.service")

    machine.succeed(
      "curl http://localhost"
    )
  '';
})

Look here https://github.com/NixOS/nixpkgs/pull/85820

Fixed - https://github.com/NixOS/nixpkgs/pull/95264

backported to 20.03 in 300049ca51522a8d74ae5125871e7f85a9eb114e.

Sweet. Thanks everyone!

I just had this issue on a 21.05 NixOS server. /var/cache/nginx/ was owned by nobody after a reload

@aopom how often does this problem occur?

@Izorkin This server runs since ~1 year, and the issue occured ~3 times

@aopom check this fix variant:
diff --git a/nixos/modules/services/web-servers/nginx/default.nix b/nixos/modules/services/web-servers/nginx/default.nix
index be589e42ddd..89a0523e6c5 100644
--- a/nixos/modules/services/web-servers/nginx/default.nix
+++ b/nixos/modules/services/web-servers/nginx/default.nix
@@ -829,6 +829,10 @@ in
       }
     ];

+    systemd.tmpfiles.rules = [
+      "Z '/var/cache/nginx' 0750 ${cfg.user} ${cfg.group} -"
+    ];
+
     systemd.services.nginx = {
       description = "Nginx Web Server";
       wantedBy = [ "multi-user.target" ];

I just encountered this issue migrating a server to a new VM by copying the /srv and /etc/nixos directories into a fresh NixOS install (notably not /var). I guess slightly different, as it was client_body not proxy_temp.
[josephlong@xwcl:~]$ nixos-version
22.05.2167.a9f66ae6401 (Quokka)

[josephlong@xwcl:~]$ stat /var/cache/nginx
  File: /var/cache/nginx
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: 253,1	Inode: 131458      Links: 7
Access: (0750/drwxr-x---)  Uid: (   60/   nginx)   Gid: (   60/   nginx)
Access: 2022-08-12 21:04:13.162905502 -0700
Modify: 2022-08-12 22:17:44.262096750 -0700
Change: 2022-08-12 22:17:44.262096750 -0700
 Birth: 2022-08-12 20:38:36.278589420 -0700

[josephlong@xwcl:~]$ stat /var/cache/nginx/client_body/
  File: /var/cache/nginx/client_body/
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: 253,1	Inode: 282049      Links: 2
Access: (0700/drwx------)  Uid: (65534/  nobody)   Gid: (   60/   nginx)
Access: 2022-08-12 22:17:44.262096750 -0700
Modify: 2022-08-12 22:17:44.262096750 -0700
Change: 2022-08-13 00:44:19.766847375 -0700
 Birth: 2022-08-12 22:17:44.262096750 -0700

I added a tmpfiles rule based on the above suggestion in my configuration.nix and it seems to work.
systemd.tmpfiles.rules = [
    "Z '/var/cache/nginx' 0750 ${config.services.nginx.user} ${config.services.nginx.group} -"
  ];


perf: improve is_ipv4_number_valid

Before
BasicBench_AdaURL            7374 ns         7341 ns        94908 time/byte=9.64605ns

After
BasicBench_AdaURL            7199 ns         7189 ns        97386 time/byte=9.44628ns

Is this a real optimization? I do not see anything in the diff that might explain a performance boost. Note that the benchmark so we can't do a direct comparison.
(The PR itself is fine, I just do not expect it to improve the performance.)

@lemire Reducing the number of branches in the checkers.cpp resulted in 100+ns improvement. There were some unnessary checks.

Let’s merge if there is no objections @lemire

Reducing the number of branches in the checkers.cpp resulted in 100+ns improvement. There were some unnessary checks.

Ah. Yes. I stand corrected. I see the optimization now.


supercollider: Emacs as dependency?

 Is this sane?

From the supercollider expression:
{ # ...
  buildInputs = [
    gcc libjack2 libsndfile fftw curl libXt qt readline ]
    ++ optional useSCEL emacs;
}

Note the use of optional.

/me should look closer.


In Microsoft Teams, what is the maximum number of adaptive cards that can be stacked on a carousel using Bot Framework?

Could you please suggest the maximum number of carousal attachments for Microsoft teams?

@amoyalan20, thank you for opening this issue. For product behavior, how-to, or general understanding questions, please use StackOverflow.


For pages with long pages, the captured images have only black background.

<!--
STEP 1: Are you in the right place?
### Steps to reproduce

**Tell us about your environment:**

* Puppeteer version:
* Platform / OS version:
* URLs (if applicable):
* Node.js version:

**What steps will reproduce the problem?**
For pages with long pages, the captured images have only black background.

**What is the expected result?**
    I hope screenshot page normal
**What happens instead?**
   example: https://mp.weixin.qq.com/s?src=11&timestamp=1540450838&ver=1203&signature=C43EL-z6Xg68yh2jDzcRkXsw1X3D8l8-CPChxHetNHXPIf7--gpBP78U1vzAEBr5E6YUUzn9-quVYNkpM0oif64YgNqkFdk-lCrzJzANJsnysPHGkv0hJ9LM1YgVKQGe&new=1

For pages with long pages, the captured images have only black background.

I guess this is similar to our other screenshot bugs, e.g. #3170


The HTML version is not updated on google.

Description
Is it possible that this version (the last update) is shown on google search?
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
46abb398-618f-409b-9f53-7de5a502f77a
Paper URL
https://arxiv.org/html/2212.04466v12
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

I think that is upto google, apologies. The latest version is available to be indexed.
Out of scope for the repository here, which tracks issues with the HTML format itself.

Thank you for your fast response. You're absolutely right. I must wait for few days to see if google browser will be updated. It's a bit confusing for readers and annoying for authors when google (and researchgate) suggest different versions of the same article, but this is absolutely not upto your team.
Kind regards,Ashkan
On Friday, November 22, 2024 at 08:05:27 PM GMT, Deyan Ginev<EMAIL_ADDRESS>wrote:

Closed #2662 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Add support for flake8 3.8.0

Fixes #35

Thank you!

Is there a chance we could get this in a release soon?

Let me see if I have that power. Somebody else reported this so we better fix it soon :)

https://pypi.org/project/flake8-pyi/#history 20.5.0 is out!


Reworking FBOs

Rework FBOs regeneration: Instead of deleting and creating a new FBO whenever FBOs have to be regenerated (upon resizing), we now only regenerate the attachments of that FBO. Due to this, the fboId is now retained and hence most Nodes and StateChanges now don't need to subscribe to FBOManagers (since no update call is ever issued).
Rework fbo swapping: Instead of maintaining two pre-defined read/write buffers, we now maintain two generic buffers and a logical distinction between the read/write buffers. Due to this, on every invocation of swap, instead of literally swapping two buffers (and therefore causing an update call to all subscribers), we alternate the buffer that we consider read (or write) from now on.
A few minor changes, which have been explained in their own individual comments.

There should be no noticeable visual changes as a side-effect of this PR.

Tagging @emanuele3d for feedback.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Please make sure to check the comments also in the outdated code blocks.

Uh oh, something went wrong with the build. Need to check on that

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

All good now, I reviewed the review (!) and added some more comments/reply in the the previous review, showing as outdated commits.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

I checked the last three commits and they are all good for me. We just have to catch up on any unfinished business.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Even with the latest commits this PR remains approved and I believe it's ready for merge @Cervator.
@vampcat, from the next PRs I'll try to be more strict with the scope and size of the changes. It is very difficult for both of us to deal with a big diff like the one of this PR. Even if a set of changes potentially affects many files, try to find a way to restrict the changes to a dozen or so. Once we work out the issues on those the others will be easier to handle. That's the theory at least.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Poked at it around a while and didn't see anything particularly weird - merged! :-)

Thanks @Cervator for the merge, thanks @vampcat for the hard work!


Fix compositor driven scrolling for twitter ex

This demo seems to expose a bug preventing
compositor driven scrolling. Changing the z
indices works around this issue.

I signed it!


IP check policy shoud check all "client_ip_sources"

I think if a user selects multiple "client_ip_sources", IP check policy should check all "client_ip_sources".
Current behavior is not intuitive.
For example, if the following API request comes with the following configuration, this request should be denied.

API request

"X-Forwarded-For": <IP_ADDRESS>
"X-Real-IP": <IP_ADDRESS>
"last_caller": <IP_ADDRESS>

configuration

{
  "name": "ip_check",
  "configuration": {
    "ips": [ "<IP_ADDRESS>", "<IP_ADDRESS>/4" ],
    "check_type": "blacklist",
    "client_ip_sources": ["X-Forwarded-For", "X-Real-IP", "last_caller"]
  }
}

Current behavior:

whitelist

first "client_ip_source" check
second "client_ip_source" check
third "client_ip_source" check
result

include client ip
-
-
not deny

not include client ip
-
-
deny

blacklist

first "client_ip_source" check
second "client_ip_source" check
third "client_ip_source" check
result

include client ip
-
-
deny

not include client ip
-
-
not deny

Expected behavior:

whitelist

first "client_ip_source" check
second "client_ip_source" check
third "client_ip_source" check
result

include client ip
-
-
not deny

not include client ip
include client ip
-
not deny

not include client ip
not include client ip
include client ip
not deny

not include client ip
not include client ip
not include client ip
deny

blacklist

first "client_ip_source" check
second "client_ip_source" check
third "client_ip_source" check
result

include client ip
-
-
deny

not include client ip
include client ip
-
deny

not include client ip
not include client ip
include client ip
deny

not include client ip
not include client ip
not include client ip
not deny

The list of IP sources cannot be sorted using the current schema of the policy. For some reason, the list becomes sortable in react-jsonschema-form when the uniqueItems attribute is removed: https://github.com/3scale/apicast/blob/3fa1f9eb21f83d41f2b0495014ded2c10df9e8d9/gateway/src/apicast/policy/ip_check/apicast-policy.json#L46
I see 2 options depending on what we want to achieve.

Check whitelisted/blacklisted IPs in all the sources selected. In this case, we just need to modify the code to change its behavior.
Check whitelisted/blacklisted IPs in just the first source that is not empty. In this case, we'll need to modify the schema, remove the uniqueItems attribute so the list becomes sortable, and then, remove duplicates in the code ourselves.

Both options can be implemented easily. I don't have a strong preference. @mikz what's your opinion on this?

After speaking with @mikz , we don't see any strong points in favor of any of the 2 options I described in my previous comment, so we think that introducing a new config param to choose between those 2 options makes sense.

Maybe take 1 option as the default one in the spirit of 'convention over configuration' if that makes sense?

@thomasmaas Yes, I think there should be a default one. Which one would you choose?

Seems #1 is closest to the what's requested at the top of the issue so i would pick #1 as the default. Is there really any reason somebody wouldn't want #1, as in, is #2 really needed as an option?
Maybe we can start by just implementing #1 and only add config param if people ask for it?

I can't think of any strong argument in favor of either, so I prefer to offer both and let the users decide. We can change this later if we receive more feedback.
Regarding the default one, I'm leaning towards option 2. The reason is that it was the original behavior and we do not want to break backwards compatibility. It's true that the policy did not work properly when configured via the admin portal, but it worked using a config file.

Once added, a feature is hard to take away.  That’s why I think we shouldn’t add it if people are not asking for it and our only motivation is that we think both options are valid. The option that puts less mental burden on the user would be the one to pick and it seems to me that is option 1 as it would just always work without any added user actions like re-ordering.
I understand that option 2 reflects the current behavior and that re-ordering would allow the user to fix the problem herself.  But I’m guessing this policy is not that widely used and therefore backward portability should not drive the decision here.
But maybe I’m overlooking a scenario where option 1 is not acceptable. In that case I stand corrected.

@thomasmaas The original way was defined in the requirements of a previous APIcast version and there might be some users with workflows depending on that behavior. I know the risk is low, but as I said before, there are not any strong arguments in favor of any of those 2 options in this issue so I prefer to offer both options.

ok, seems we're repeating ourselves. Maybe @vramosp and @mikz can shine their lights on this. Or we could opt for a sword dual at sunset.

OK. Let's wait for product decision on this one.
There's a JIRA issue where someone asked to fix the original behavior: https://issues.jboss.org/browse/THREESCALE-1692
And the original poster of this issue described an alternative, which in my opinion is valid as well.
/cc @vramosp

From a product perspective, the preference would be to provide a fix without introducing any breaking changes, no matter how low the risk is. So preference would be option 2.


Feat/gh pages deployment

Deployment issue with nightly builds, maybe due to the single quotes present around the artifact name, trying without it and seeing if it solves the problem.

Downgrading to a previous deployment action (version 2.0.7) fixes the deployment bug, Jorge is looking into why current deployment (version 3) is facing this bug. Also, updated the numpy links in the conf.py which was causing doc generation errors.


Automated cherry pick of #6252: fix: panic when disk has no valid storage_id

Cherry pick of #6252 on release/3.0.
#6252: fix: panic when disk has no valid storage_id

Codecov Report

Merging #6254 into release/3.0 will increase coverage by 0.06%.
The diff coverage is 19.00%.

@@              Coverage Diff               @@
##           release/3.0   #6254      +/-   ##
==============================================
+ Coverage         6.85%   6.91%   +0.06%
==============================================
  Files              540     541       +1
  Lines            91509   91667     +158
==============================================
+ Hits              6270    6340      +70
- Misses           84719   84806      +87
- Partials           520     521       +1

Flag
Coverage Δ

#aFlag
6.91% <19.00%> (+0.06%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/baremetal/manager.go
0.50% <0.00%> (-0.01%)
:arrow_down:

pkg/baremetal/tasks/base.go
13.59% <0.00%> (-0.41%)
:arrow_down:

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/modelbase.go
1.44% <ø> (+0.02%)
:arrow_up:

pkg/cloudcommon/policy/policy.go
1.58% <0.00%> (+0.04%)
:arrow_up:

pkg/cloudprovider/cloudprovider.go
1.57% <ø> (ø)

pkg/compute/baremetal/diskconfig.go
60.14% <0.00%> (ø)

pkg/compute/models/cloudregions.go
1.88% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/dbinstance_accounts.go
2.34% <0.00%> (ø)

pkg/compute/models/dbinstance_databases.go
4.24% <0.00%> (ø)

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc3e41...03de298. Read the comment docs.


enable/disable highlighting current line visual studio code

VSCode Version: 1.0.0
OS Version: 10.11.3

It would be very convenient to be able to toggle the line highlight feature. thus far I have not found a way to do this, or an open issue addressing this. apologies if this is a duplicate.
thanks vsc team!

Add enable/disable feature or Remove default line highlighting. That will be better......

Implemented with 0d5d779


Add Project Charter Document

We need to add the project charter documentation to our wiki: Project Charter.docx

I have added and completed the Project Charter documentation in our wiki.


Rust "general" rule ideas

Prefer calling .into() on an impl Into<Whatever> param immediately in the function body (vs "at point of usage") (could be "dirty-fixable" maybe?)
(same thing for other similar eg impl AsRef<Whatever>/impl Borrow<Whatever>)

Flag "redundant" use declarations in nested modules eg:
use foo::Bar;

mod baz {
    use foo::Bar;
}

Flag places where Default::default() could be used (eg in struct field initializers eg some_field: RefCell::new(None),)?


Use OCCT 7.4.0 for ci

Description
This updated OCE 0.17 to OCCT 7.4.0 for continous integration. All platforms compile fine and use our OCCT 7.4.0 patched binaries.

How Has This Been Tested?

Unit tests and manuel TiGL Viewer tests.
Screenshots, that help to understand the changes(if applicable):
Checklist:

[ ] A test for the new functionality was added.
[x] All tests run without failure.
[ ] The new code complies with the TiGL style guide.
[ ] New classes have been added to the Python interface.
[ ] API changes were documented properly in tigl.h.

Codecov Report

Merging #807 (d133e4e) into master (4feb29c) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   62.30%   62.24%   -0.07%
==========================================
  Files         291      291
  Lines       23411    23468      +57
==========================================
+ Hits        14587    14607      +20
- Misses       8824     8861      +37

Impacted Files
Coverage Δ

src/geometry/CTiglMakeLoft.cpp
77.48% <0.00%> (-10.89%)
:arrow_down:

src/boolean_operations/CTrimShape.cpp
68.06% <0.00%> (-0.58%)
:arrow_down:

src/common/tiglcommonfunctions.cpp
54.38% <0.00%> (-0.42%)
:arrow_down:

src/geometry/CTiglBSplineAlgorithms.cpp
96.94% <0.00%> (+<0.01%)
:arrow_up:

src/configuration/CTiglFusePlane.cpp
96.87% <0.00%> (+0.03%)
:arrow_up:

src/geometry/CTiglBSplineFit.cpp
91.75% <0.00%> (+0.04%)
:arrow_up:

src/boolean_operations/CFuseShapes.cpp
92.22% <0.00%> (+0.08%)
:arrow_up:

src/contrib/MakePatches.cxx
85.71% <0.00%> (+0.23%)
:arrow_up:

src/boolean_operations/GEOMAlgo_Splitter.cxx
30.20% <0.00%> (+0.35%)
:arrow_up:

src/boolean_operations/CBopCommon.cpp
81.39% <0.00%> (+0.44%)
:arrow_up:

... and 2 more


Events don't seem to work

I'm adding some code to one of the observers file I have but nothing is happening. I even tried saving comments on the log to see if it was catching the events but didn't work. I wonder if any other step is required or how does it work. Or, if it is just not working.
Thanks!.

I found the missing step:
Go to Providers\EventServiceProvider.php and add in the boot function:
\App\Model\MyModel::observe( new \App\Observers\Models\MyModelObserver );
Note: I have the models in a Model folder, in case anyone tries to follow this step, it may be possible that you don't need the Model in the code.


add bad config

this config fails test_op_fwd[bshd-True-True-1-1-1-512-256-160] on MI300.

It seems to pass on MI200


after validate and/or before submit events

Description
I'm making this form, and on submit if the validation fails I'd like to focus the first element with error. Can I do  this? I'm using a YUP schema for validation.
Additional context
No response

You can achieve this through the @error event on the Form component, you can read more about it here: https://ui.nuxt.com/dev/forms/form#error-event
Be aware that this feature has not been released yet and is only available on the Edge version.


UI-8087 - Add --on-error option to the CLI

Description
This ticket is a prerequisite to UI-7945. The CLI should accept an on-error (name to challenge) optional argument that decides between the following behaviors:

"keep-original": if anything goes wrong during the migration of an item, the CLI from-version of the item is kept.
"keep-latter": if anything goes wrong during the migration of an item between n-version and n+1-version, the n-version of the item is kept.
"keep-going": if anything goes wrong during the migration of an item, keep trying to migrate it, even though it's corrupt, until the CLI to-version.
any other behavior?

Note that an item here is either:

a saved filter
a saved widget
a calculated measure
a widget within a dashboard
a dashboard without its widgets (dashboard or pages specific parts of a dashboard state)

That means if something is wrong with the migration of a widget within a dashboard, the option will only apply to that widget migration and not to the rest of the dashboard state. In such a case, the counters.dashboards.partial variable is incremented.
Review
Aside from introducing the new CLI option, the main goal of this PR is to have the frame for handling the errors challenged:

CLI option name
behavior names
the behaviors themselves

That means if something is wrong with the migration of a widget within a dashboard, the option will only apply to that widget migration and not to the rest of the dashboard state. In such a case, the counters.dashboards.partial variable is incremented.

Widgets within a dashboard won't be affected by the option: it would be like a "keep-going" for them.
The option will only impact errors occuring within migrateDashboard but outside of migrateWidgetsWithinDashboard.

Widgets within a dashboard won't be affected by the option: it would be like a "keep-going" for them. The option will only impact errors occuring within migrateDashboard but outside of migrateWidgetsWithinDashboard.

Why wouldn't they be affected? And why "keep-going" would be the default behavior for them?

Widgets within a dashboard won't be affected by the option: it would be like a "keep-going" for them. The option will only impact errors occuring within migrateDashboard but outside of migrateWidgetsWithinDashboard.

Why wouldn't they be affected? And why "keep-going" would be the default behavior for them?

It's the design that we had agreed on, and that is currently in place for 4.3 to 5.0: you don't stop migrating a dashboard when there is an error in one of the widgets.

Widgets within a dashboard won't be affected by the option: it would be like a "keep-going" for them. The option will only impact errors occuring within migrateDashboard but outside of migrateWidgetsWithinDashboard.

Why wouldn't they be affected? And why "keep-going" would be the default behavior for them?

It's the design that we had agreed on, and that is currently in place for 4.3 to 5.0: you don't stop migrating a dashboard when there is an error in one of the widgets.

Ah yes, you keep migrating the rest of the dashboard state, that okay.
But what version of the widget which migration errored do you keep? The original one or the last successful one?

I slightly reworded the BehaviorOnError type description, let me know if you disagree!

But what version of the widget which migration errored do you keep? The original one or the last successful one?

It's going to be the last successful one

I added some changes to make it clear that the option only has an effect when migrating through several versions in one go.
Also, I removed the alias as this option is pretty niche and I don't think -e is very intuitive: I prefer consumers of the CLI to write --on-error explicitly and know what they're doing.

The diff shows quite a lot of lines added, but what was really added here is:

the introduction of idsOfDashboardsToMigrate, idsOfWidgetsToMigrate and idsOfFiltersToMigrate, which role is to keep track of the items that need to keep being migrated during migration p+1: successful item migration or "keep-going" behavior on error
using behaviorOnError in getMigrateXyz
introduce originalContentServer in case "keep-original" is chosen to be able to retrieve the original version of an item after p migrations
adapt the same logic when the migration starts from 4.3

@eliasinho I pushed a commit, can you review it ?
It looks good to me in this state.


Please update to intl ^0.19.0

error beacause version intl intl 0.18.0

same here

I've just created a pull request with this change.
https://github.com/SebastienBtr/Dash-Chat-2/pull/101

duplicate #91


Switching to PSR-4 and fixing tests

Tested with PHPUnit 4.5.1:

Time: 2.92 seconds, Memory: 4.50Mb
OK (3 tests, 3 assertions)

Hi @Narno
First of all, thank you for your interest in Mailjet!
We are taking note of your pull requests.
However, have you checked the sboo-master branch on this very repo? It doesn't make use of the PSR-4 standard as it still isn't widely spread, but we introduced (thanks to PR #73) namespacing (and generally a better code structure) as well as support for upcoming features regarding the contact & contactslist resources.
 :-/
Lot of wasted time: I'll have to check each of the branches before...
You should add a note about this in the readme of the master branch.

Don't worry, it's still practice :-) Also, we are more than welcome for any suggestion on the dev version !
Regarding that note, we didn't put one as it could mislead people into thinking that the dev version would be the absolute way to go, which isn't the case and could lead to confusion.

No problem, I will contribute to the new version ;-)


Can't assign a name value to SelectField

How can I assign a name value to a select field? I tried using the name tag on both the  and  components, but neither works. When I parse the form output, the value from the select field is not shown. I've noticed the documentation does include the name field for other types of inputs but not the select field.
Here's an example:
    <SelectField name="Type" value="TestVal" floatingLabelText="Select Letter" onChange={handleChange}>
      <MenuItem value="a" primaryText="A"/>
      <MenuItem value="b" primaryText="B"/>
      <MenuItem value="c" primaryText="C"/>
    </SelectField>

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

serialized form output should have a field like {"Type":"TestVal"}
Current Behavior

There is no "Type" field in the form output. However, it does work correctly for material-ui text inputs with a name field.
Steps to Reproduce (for bugs)

create a form
add select field with name
submit form and serialize json
there will be no field for the select value

Context

Your Environment

Tech
Version

Material-UI
0.20.0

React
16.2.0

browser
Chrome

etc

We have been porting the component on the v1-beta branch. We have reimplemented it from the ground-up.
We encourage people starting with Material-UI to go with v1-beta. The master branch is in a low maintenance mode. We don't plan any work on it. However, we still do our best to review and merge pull requests that fix bugs on this branch.


Fix exception info

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8974 (5c59355) into 3.0 (933d2cd) will increase coverage by 0.03%.
The diff coverage is 0.00%.

:exclamation: Current head 5c59355 differs from pull request most recent head 7b5c847. Consider uploading reports for the commit 7b5c847 to get more accurate results

@@             Coverage Diff              @@
##                3.0    #8974      +/-   ##
============================================
+ Coverage     63.33%   63.37%   +0.03%
  Complexity      312      312
============================================
  Files          1183     1183
  Lines         50270    50270
  Branches       7525     7525
============================================
+ Hits          31841    31858      +17
+ Misses        14937    14924      -13
+ Partials       3492     3488       -4

Impacted Files
Coverage Δ

...ava/org/apache/dubbo/config/ServiceConfigBase.java
61.58% <0.00%> (ø)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
60.86% <0.00%> (-4.35%)
:arrow_down:

...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java
66.96% <0.00%> (-3.58%)
:arrow_down:

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
:arrow_down:

.../apache/dubbo/remoting/transport/CodecSupport.java
80.00% <0.00%> (-3.08%)
:arrow_down:

...va/org/apache/dubbo/registry/RegistryNotifier.java
82.05% <0.00%> (-2.57%)
:arrow_down:

...bo/registry/support/CacheableFailbackRegistry.java
77.10% <0.00%> (-1.21%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
66.01% <0.00%> (-0.49%)
:arrow_down:

...ubbo/config/deploy/DefaultApplicationDeployer.java
79.90% <0.00%> (+0.45%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933d2cd...7b5c847. Read the comment docs.


[Question] If parallel iterations also themselves use parallel iteration will the work stealing "just work"?

If I have some parallel iteration that I want to do (eg: process X-many files in parallel) and each of those parallel tasks also has parallel work (eg: within a file, process each item parsed in parallel), do all the tasks at the different "levels" of parallel work still participate in the same work stealing system? Say there's one file that has just one item and so that top level task completes very quickly, but the second file has 1000 items, will all of the second item's work be distributed into the thread pool evenly and it just "works out"?

It works out. From the perspective of the rayon-core pool, a parallel iterator is just a bunch of nested joins, so then nesting iterators just look like more of that.

cool beans


Timeseries: Copy-edits for notebook using Dask for batch imports

About
Building upon GH-293, this patch adds a few copy-edits.

Can you have look at this patch to be able to wrap it up into GH-293?

Fixed with https://github.com/crate/cratedb-examples/pull/293

Fixed with https://github.com/crate/cratedb-examples/pull/293.

Maybe not? I've submitted the patch once more using GH-339.


Updated Adding Sections notebook to not include a dependency for anot…

…her model.  This notebook does not currently appear to do anything meaningful with entities, but rather it shows how sections are detected and accessible at a Doc level.  As such, I've changed this to use the simple English spacy model.  The notebook now runs.  Re-enabling this notebook for execution in our tests.  while I was looking at this, I found another section related notebook which was being skipped in our automated tests.  I verified that this other notebook currently runs successfully, so I have enabled this one as well for our automated testing.
NOTE:  Since there did not appear to be anything in the notebook which required certain entities, I changed the text to make the text very simple and allow the entities in the visualization to be simple DATE entities from a out of the box (non-clinical) English spacy model.
This resolves issue #116

Changing the base of this.  I meant for this to go into develop instead of master.


Dockerfile size is too large

What feature?
The current Dockerfile generates a 2.17 GB image, which is excessively large for container deployment.
I can minimize its size.
Add screenshots

Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

Go ahead @Dhruv-Pattel


support @instruct-lab-bot and @instructlab-bot both the commands

Recently renaming of instruct-lab to instructlab, also required to rename instruct-lab-bot to instructlab-bot. Just to be in sync it makes sense that we use @instructlab-bot as a bot command. But to make sure we do smooth migration, we should support the old command @instruct-lab-bot but spit the warning saying it's going to be deprecated soon.

Fixed through #264


Fix dimension writing in FastMode

A recent refactoring in https://github.com/mini-software/MiniExcel/pull/602 broke excel writing in FastMode if the input collection was an IEnumerable.
The issue was twofold

An incorrect assumption of the position returned after writing the placeholder
A missing call to reset the position after seeking back to overwrite the placeholder

Seems like i have a few things to fix first 😄


[Bug] OpenAPI import does not seem to honor default variables in servers declaration

Insomnia Version: 6.6.2
Operating System: MacOS mojave 10.14.6

Details
I'm trying to import an OpenAPI 3 spec that uses variables in the server url. Default values are provided for these in the variables declaration. This results in an error when i try to import the file: Invalid URL: http://{host}:{port}/{basePath}
If I replace the url with the following string it works: http://localhost:8080/filemanagement
OpenAPI yaml file (parts of it - but it can be used to reproduce the bug and import works after replacing the servers/url part):
openapi: 3.0.2
info:
  description: OpenAPI definition for filemanagment services
  license:
    name: todo
    url: todo
  title: filemanagement
  version: 0.1.0
servers:
  - description: Devserver
    url: http://{host}:{port}/{basePath}
    variables:
      host:
        default: localhost
        description: Various servers (production, local development etc).
      port:
        default: "8080"
        description: Port to reach server on.
        enum:
          - "8080"
          - "9090"
      basePath:
        default: filemanagement
        description: API version, for information on other supported versions see those
          specifications.
tags:
  - description: Operations for managing file storages such as S3.
    name: storages
  - description: Operations for managing files connected to data sources.
    name: files

paths:
  /files:
    get:
      operationId: find_files
      parameters:
        - description: Search for files based on metadata.
          explode: true
          in: query
          name: metadata
          required: false
          schema:
            type: string
          style: form
      responses:
        200:
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/FileDescription'
          description: List of files matching the search criteria. List will be empty
            if no files match the criteria.
      tags:
        - files
      x-openapi-router-controller: filemanagement_service.controllers.files_controller

Looks like an issue with SwaggerParser seeing the template as incorrect syntax.
This is the error I have in the dev tools using your file.
[openapi3] Import file validation failed SyntaxError: Error resolving $ref pointer "//#/components/schemas/FileDescription".
Token "components" does not exist.
    at Pointer.module.exports.Pointer.resolve (bundle.js:73541)
    at $Ref.module.exports.$Ref.resolve (bundle.js:67922)
    at $Refs.module.exports.$Refs._resolve (bundle.js:262539)
    at dereference$Ref (bundle.js:120025)
    at bundle.js:119984
    at Array.forEach (<anonymous>)
    at crawl (bundle.js:119977)
    at bundle.js:119990
    at Array.forEach (<anonymous>)

Sorry for the late reply.. :( I made a temporary fix and forgot about this. Anyway.. that error message is because my example was incomplete. The definitions for the $ref is missing. Here's a more complete file that wont import and don't give that error:
openapi: 3.0.2
info:
  description: This API is for administrating files and file storages.
  license:
    name: Some license
  title: File and Storage API
  version: 0.1.0
servers:
  - description: Devserver
    url: http://{host}:{port}/{basePath}
    variables:
      host:
        default: localhost
        description: Various servers (production, local development etc).
      port:
        default: "8080"
        description: Port to reach server on.
        enum:
          - "8080"
          - "9090"
      basePath:
        default: filemanagement
        description:
          API version, for information on other supported versions see those
          specifications.
tags:
  - description: Operations for managing file storages such as S3.
    name: storages
  - description: Operations for managing files connected to data sources.
    name: files
paths:
  /files:
    get:
      operationId: find_files
      parameters:
        - description: Search for files based on file properties.
          explode: true
          in: query
          name: datasourceId
          required: false
          schema:
            type: string
          style: form
      responses:
        200:
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/FileDescription"
          description:
            List of files matching the search criteria. List will be empty
            if no files match the criteria.
      tags:
        - files
components:
  schemas:
    FileDescription:
      description:
        A metadata representation of a file. I.e. this entity does not
        include the raw file content.
      example:
        path: path
        name: name
        datasourceId: datasourceId
        createdTime: 0
        id: id
        storageId: storageId
      properties:
        id:
          type: string
        name:
          type: string
        path:
          type: string
        storageId:
          type: string
        createdTime:
          format: int64
          type: integer

After replacing the url it works:
url: http://localhost:8080/

I'm seeing this problem too with Insomnia 7.0.5 on macOS 10.15.1
The import failure happens when I use a variable for the server port.
http://petstore.swagger.io:{port}/{basepath} - fails
http://petstore.swagger.io:1234/{basepath} - OK
http://petstore.swagger.io:{port} - fails
http://petstore.swagger.io:1234 - OK
I started with the petstore sample from the OAS specification repo
https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore.yaml
Then modified the servers block to be
servers:
  - url: http://petstore.swagger.io:{port}/{basePath}
    variables:
      basePath:
        default: "v1"
      port:
        default: "1234"

Insomnia shows two errors

Import Failed -  TypeError: result.summary[_models__WEBPACK_IMPORTED_MODULE_11__workspace.type] is not iterable
Failed to import - Import failed - Invalid URL http://petstore.swagger.io:{port}/{basePath}

I don't get any syntax errors about the file and it imports successfully into Postman 7.13.0.  Hoping to get things working with Insomnia though :)
Full modified petstore.yaml showing the problem
openapi: "3.0.0"
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
servers:
  - url: http://petstore.swagger.io:{port}/{basePath}
    variables:
      basePath:
        default: "v1"
      port:
        default: "1234"
paths:
  /pets:
    get:
      summary: List all pets
      operationId: listPets
      tags:
        - pets
      parameters:
        - name: limit
          in: query
          description: How many items to return at one time (max 100)
          required: false
          schema:
            type: integer
            format: int32
      responses:
        '200':
          description: A paged array of pets
          headers:
            x-next:
              description: A link to the next page of responses
              schema:
                type: string
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Pets"
        default:
          description: unexpected error
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Error"
    post:
      summary: Create a pet
      operationId: createPets
      tags:
        - pets
      responses:
        '201':
          description: Null response
        default:
          description: unexpected error
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Error"
  /pets/{petId}:
    get:
      summary: Info for a specific pet
      operationId: showPetById
      tags:
        - pets
      parameters:
        - name: petId
          in: path
          required: true
          description: The id of the pet to retrieve
          schema:
            type: string
      responses:
        '200':
          description: Expected response to a valid request
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Pet"
        default:
          description: unexpected error
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Error"
components:
  schemas:
    Pet:
      type: object
      required:
        - id
        - name
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string
        tag:
          type: string
    Pets:
      type: array
      items:
        $ref: "#/components/schemas/Pet"
    Error:
      type: object
      required:
        - code
        - message
      properties:
        code:
          type: integer
          format: int32
        message:
          type: string

I'm affected by this bug as well.

Exactly in the same situation as @vitalis. Also I just wanted to point out that the bug does not occur when you directly copy&paste your openapi.json inside of the Insomnia Rest Designer text editor.

I recently built functionality to honor default variables in an OpenAPI spec as part of the openapi-2-kong package, but the logic is fairly generic and should be usable by insomnia-importers as well. I believe this would solve the issue?
https://github.com/Kong/insomnia/blob/453745d3e22cb64bb271a2ab7b36df2b8d936892/packages/openapi-2-kong/src/kubernetes/variables.js#L13-L33
@vitaliis, could you please share some reproduction steps for your two issues? (The second is during "Import from File", when is the first happening?) Also, are you facing this with the example specification (https://github.com/Kong/insomnia/issues/1640#issuecomment-533087139) or a different one?

First, I'm on Macos and I use Insomnia Version 7.1.1 (<IP_ADDRESS>50)
Steps to reproduce:

In the data menu, click on "Import data"
Choose any option as long as you use the data given below

From clipboard
Copy the content of data below and choose From clipboard
I get the following error alone and the text is not selectable.
TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined

From url
http://localhost:8000/openapi.json

From file

AND

OpenAPI json schema
It's based of the fastapi doc for Oauth2 bearer token login, so I think it represents a fairly common case.
{
  "openapi": "3.0.2",
  "info": {
    "title": "FastAPI",
    "version": "0.1.0"
  },
  "paths": {
    "/login/access-token": {
      "post": {
        "tags": [
          "Users"
        ],
        "summary": "Login Access Token",
        "description": "Login and get an access token with your credentials.",
        "operationId": "login_access_token_login_access_token_post",
        "requestBody": {
          "content": {
            "application/x-www-form-urlencoded": {
              "schema": {
                "$ref": "#/components/schemas/Body_login_access_token_login_access_token_post"
              }
            }
          },
          "required": true
        },
        "responses": {
          "200": {
            "description": "Successful Response",
            "content": {
              "application/json": {
                "schema": {
                  "$ref": "#/components/schemas/AccessTokenSchema"
                }
              }
            }
          },
          "422": {
            "description": "Validation Error",
            "content": {
              "application/json": {
                "schema": {
                  "$ref": "#/components/schemas/HTTPValidationError"
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "AccessTokenSchema": {
        "title": "AccessTokenSchema",
        "required": [
          "access_token",
          "token_type"
        ],
        "type": "object",
        "properties": {
          "access_token": {
            "title": "Access Token",
            "type": "string"
          },
          "token_type": {
            "title": "Token Type",
            "type": "string"
          }
        }
      },
      "Body_login_access_token_login_access_token_post": {
        "title": "Body_login_access_token_login_access_token_post",
        "required": [
          "username",
          "password"
        ],
        "type": "object",
        "properties": {
          "grant_type": {
            "title": "Grant Type",
            "pattern": "password",
            "type": "string"
          },
          "username": {
            "title": "Username",
            "type": "string"
          },
          "password": {
            "title": "Password",
            "type": "string"
          },
          "scope": {
            "title": "Scope",
            "type": "string",
            "default": ""
          },
          "client_id": {
            "title": "Client Id",
            "type": "string"
          },
          "client_secret": {
            "title": "Client Secret",
            "type": "string"
          }
        }
      },
      "HTTPValidationError": {
        "title": "HTTPValidationError",
        "type": "object",
        "properties": {
          "detail": {
            "title": "Detail",
            "type": "array",
            "items": {
              "$ref": "#/components/schemas/ValidationError"
            }
          }
        }
      },
      "ValidationError": {
        "title": "ValidationError",
        "required": [
          "loc",
          "msg",
          "type"
        ],
        "type": "object",
        "properties": {
          "loc": {
            "title": "Location",
            "type": "array",
            "items": {
              "type": "string"
            }
          },
          "msg": {
            "title": "Message",
            "type": "string"
          },
          "type": {
            "title": "Error Type",
            "type": "string"
          }
        }
      }
    },
    "securitySchemes": {
      "OAuth2PasswordBearer": {
        "type": "oauth2",
        "flows": {
          "password": {
            "scopes": {},
            "tokenUrl": "/login/access-token"
          }
        }
      }
    }
  }
}

Thanks for that @SylannBin! A missing servers declaration wasn't handled by the openapi3 importer previously, resulting in those errors. I'm willing to say @vitaliis is experiencing the same thing as well.
That has been resolved by #2007 though, and will be included in the next release of Insomnia Core. I confirmed by importing that specification successfully while running on the latest develop.

Right. The issue is gone when you add the servers section. I also see the following error, but again it is also resolved after adding the servers section.

Good that it is generally resolved by #2007. Thanks, @develohpanda for the info!


Merging Develop into Master 7.14.2018 - templates tweaks

Hello @ksigler7,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Added mul[(^ _)] => mul

This was proved by Poi before added: https://github.com/advancedresearch/poi/issues/404


call forwarding

Hey there, is it possible to setup call forwarding (a.k.a. call transfers) with this API?

No such APIs within SkPy.  If what you want can be done within Skype for Web, then potentially it can be implemented here too.  I think all the calling stuff requires a browser plugin, unless you refer to configuring stuff within your account, in which case that's (currently?) out of scope here.

OK thanks.

I'll close this for now -- it may be possible to add some account management features, but would require some investigation over how we authenticate to / get data from the portal pages.


Enable Writes to Azure 2

This PR is an extension of #114 by @thovoll . It fixes the broken tests, adds support for ARM and adds a test for Azure Blob Storage using Azurite.

Thanks for the work! Give me some time to review it and compare with the work I had been doing in a branch as well :hugs:

The cargo clippy errors are worth addressing, there are some around futures not being resolved which is definitely a bad runtime behavior. Running the build and tests locally is looking generally good. @mightyshazam do you mind if I pull this into a topic branch on this repository, and then we can collaborate on cleaning it up for merge and release?

The cargo clippy errors are worth addressing, there are some around futures not being resolved which is definitely a bad runtime behavior. Running the build and tests locally is looking generally good. @mightyshazam do you mind if I pull this into a topic branch on this repository, and then we can collaborate on cleaning it up for merge and release?

Sounds good to me.

@mightyshazam I have pushed the azure-writes branch and sent you an invite to act as a collaborator on this repo for that branch. I will close this pull request in favor of the draft: https://github.com/delta-io/kafka-delta-ingest/pull/136


Invalid IBAN Considered Valid

According to https://www.iban.com/testibans the following IBANs are invalid:
GB00HLFX11016111455365
GB01BARC20714583608387
But this library considers these IBANs as valid.

According to https://runkit.com/embed/y2e8cpx51ogy, the bad list is larger:

GB00HLFX11016111455365
GB01BARC20714583608387
GB02BARC20201530093451
GB24BARC20201630093459
GB2LABBY09012857201707
GB68CITI18500483515538

var IBAN = require("iban")
const iban_list = ['GB33BUKB20201555555555', 'GB94BARC10201530093459', 'GB94BARC20201530093459', 'GB96BARC202015300934591', 'GB02BARC20201530093451', 'GB68CITI18500483515538', 'GB24BARC20201630093459', 'GB12BARC20201530093A59', 'GB78BARCO0201530093459', 'GB2LABBY09012857201707', 'GB01BARC20714583608387', 'GB00HLFX11016111455365', 'US64SVBKUS6S3300958879'];
let res = [];
iban_list.forEach(function(iban) {
  res[iban] = IBAN.isValid(iban);
});
res;

Hello,
Thanks for opening this issue.
You're right that this library should probably have the same results as documented on iban.com for the following IBANs:

GB00HLFX11016111455365
GB01BARC20714583608387
GB2LABBY09012857201707

The other examples either give the same answer as iban.com, or expectedly return true when iban.com replies false because of local validation criteria not checked by this library (bank code, bban check-digit).

also lowercase country code is considered valid although standard specifies that all letters in IBAN MUST be uppercase.

Hello,
I found another case that is being considered valid by the library but invalid on iban.com
ES1100753038790600500941
Hope it helps!

Hi
iban is allowing special characters and telling it as valid

This is also a problem in my current customer project where we are using the Iban library. Can you already estimate when this will be fixed?

yeah we also got this problem. Accepting chars like  '?'  ,   '.'   etc in the middle of the iban.

yeah we also got this problem. Accepting chars like '?' , '.' etc in the middle of the iban.

Why you even let user enter those chars, clean it up before sending it to validator? I think this library should not be responsible for cleanup.

yeah we also got this problem. Accepting chars like '?' , '.' etc in the middle of the iban.

Why you even let user enter those chars, clean it up before sending it to validator? I think this library should not be responsible for cleanup.

Hey, yes, we are validating inputs before.
Still, I do not agree with your comment.  In the main page there is this: IBAN.isValid('hello world'); // false      , space is an invalid char , yet, the library works fine, by returning false.   A false positive on the other hand is definitely not a good return , even if input should have been sanitized before.  It is the same as saying   : IBAN.isValid('hello world'); // true   because the input should have been checked for the space.

You're right that this library should probably have the same results as documented on iban.com for the following IBANs:
* GB00HLFX11016111455365
* GB01BARC20714583608387
* GB2LABBY09012857201707

That's mean there is a error in ckecksum calculation ...

There actualy is a problem with the IBAN Checksum:
BE77776593869767
Is also valid, although not by iban.com.

same goes for ES8350210036679521296135 - fails for bank code checksum
iban.com says it is invalid. It seems this library does not count on spec per country.

Perhaps a simple fix is that you run this on your input IBAN string before validating:
input = input.replace(/[^a-zA-Z0-9]/g, '');

This way all weird characters are filtered out, perhaps it could be included in this script as well?


Adds a contributing doc

As recommended by https://github.com/theastropath/turbot/community

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   99.56%   99.56%
=======================================
  Files           1        1
  Lines         691      691
  Branches      133      133
=======================================
  Hits          688      688
  Misses          1        1
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfed641...0cdbb98. Read the comment docs.


Readme broken link

The Readme has a link like this:
http://https://github.com/D-Programming-Deimos/openssl

should be:
https://github.com/D-Programming-Deimos/openssl

Thanks. It's fixed in commit https://github.com/huntlabs/hunt-openssl/commit/b8536685cad843a1fe81a9abf288f38ab0053f9b.


PrestoS3FileSystem breaks read-after-write strict S3 consistency

Method: com.facebook.presto.hive.s3.PrestoS3FileSystem#create
will check for file existence when overwrite==false. File existence check will break read-after-write strict S3 consistency per S3 doc:
Amazon S3 provides read-after-write consistency for PUTS of new objects in
your S3 bucket in all regions with one caveat. The caveat is that if you make a
HEAD or GET request to the key name (to find if the object exists) before
creating the object, Amazon S3 provides eventual consistency for read-after-write.

The existence check itself is weak as the file might be created while data is gathered in staging directory for upload.
I propose to remove the check of use LIST S3 request instead that does not break read-after-write consistency.
FYI: @findepi

This seems to be related to: https://github.com/prestodb/presto/issues/11587
as record parquet writer will create files with override=false mode.

Since this only affects Parquet, and we know that our file names are unique, we might be able to fix this for Parquet by changing the flag when opening the file. Or perhaps we could change the S3 FS to ignore the exists check (since it is only for Presto and is not a general purpose FS).


Bump opentelemetry 0.23 > 0.24

Bump otel to 0.24 which is using http 1.0. No code changes required.

@Miaxos @sunli829  any plans of merging this soon? I'm stuck on older versions of other libraries because async-graphql breaks if I update otel to 0.24 in my project.

@b-dreissigacker Apparently a new otel release is planned for this week, so another trip on the upgrade merry-go-round. IMO otel dependencies (in all projects, not just this one) should be split out into a separate crate; the API is cross-cutting, and too unstable right now.


Command to execute on a Domain Controller

Hello, Please could you precise that the command must be executed on a Domain Controller and not from a domain joined computer using RSAT. Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b169b25-a020-f0cd-1d94-fc1e6c4741af
Version Independent ID: d008e02b-2e6b-5038-e36b-cbcbc4fa8b37
Content: dcgpofix
Content Source: WindowsServerDocs/administration/windows-commands/dcgpofix.md
Product: windows-server
Technology: manage-windows-commands
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

Very well, I will attempt to do so. Just a question before I start working on a PR to add your request:
*
Are there any other /Administration/Windows Commands that this should be specified for, or is it particularly important for dcgpofix?

Hello,
I noticed this prerequisite for dcgpofix , because of using a dedicated server for administration.
Best regards, Cordialement,
Christophe GENSE
Advisor/IT Architecture, France Delivery Services
Dell Technologies | Services
Mobile phone +33661399506tel:+33661399506
christophe.gense<EMAIL_ADDRESS>MCSE Productivity
MCSA Office 365
From: Trond B. Krokli<EMAIL_ADDRESS>Sent: dimanche 24 mai 2020 16:55
To: MicrosoftDocs/windowsserverdocs
Cc: GENSE, Christophe; Author
Subject: Re: [MicrosoftDocs/windowsserverdocs] Command to execute on a Domain Controller (#4384)
[EXTERNAL EMAIL]
Very well, I will attempt to do so. Just a question before I start working on a PR to add your request:
*
Are there any other /Administration/Windows Commands that this should be specified for, or is it particularly important for dcgpofix?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windowsserverdocs/issues/4384#issuecomment-633243066, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHC7JE5U2VRPWANIYD6KXQTRTEYN5ANCNFSM4NHVCCDQ.
Dell S.A, Siège Social 1 rond point Benjamin Franklin 34000 Montpellier.
Capital 1,782,769 Euros, 351 528 229 RCS Montpellier –APE 4651Z -TVA Intracommunautaire FR 20 351 528 229, SIRET 351<PHONE_NUMBER>8
Vat Number : FR<PHONE_NUMBER>9 (France) /  IT00001709997 (Italy) / ESN0012622G (Spain)

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Next and Prev buttons not working

So I am running a tour, and depending on what the user clicks, there is different feedback on the page throughout the tour.
I cut my function out, and have it just to console.log, but basically, if this function happens the next prev do no work.
So if I click on some button on the page, it runs through here:
$('input[name="taskSelection"],.task').on('click', function(){
if(isLastStep === false){
    console.log("skipping");
} else {
    console.log("wrong task");
}
});

this is not triggered on the next or previous buttons of the tour. Rather, completely separate buttons. Yet once this bit is called, the Next and Prev buttons in tour do not function and debug returns nothing.

I have a similar issue, the prev/next buttons are not working, but they are generating click events. The arrow keys still work. There are multiple other click handlers on the page and Im not sure how to figure out which one might be conflicting or why.

As a work around use the onShown function to bind a click handler to the prev/next button that calls the prev()/next() functions:
     onShown: function(tour){         console.log("shown");         $('button[data-role="next"]').click(function(e){             tour.next();             console.log("next click");         });         $('button[data-role="prev"]').click(function(e){             tour.prev();         });       },


Fixes for authenticator app

The pull series enables -Wall as default (if you're using clang or gcc or other compilers that support the  flag) and fixes two issues:
-- a mismatch between %ld in a printf and an unsigned long argument
-- A possible buffer overflow: if the space after string copied by realloc() contains NUL chars, then the strrchr() will pick up the wrong one.  Use strlen() on the original instead.

I don't think that strrchr() is actually an overflow problem. strrchr doesn't know the size of the memory buffer thus will not go beyond the first NUL.
The right solution is to allocate a new buffer for tmp_fn. I'll merge this though.


Implementing BFS over ComputeFramework

This is an attempt at implementing BFS. I managed to get map to work, but I got a convert error on reduce and filter went into a stackoverflow. Not sure what I'm doing wrong.
Design issues I've faced are:

The datastructure to store the graph. @ViralBShah recommended a sparse matrix, but I've found a list of lists to work better for BFS. The graph needs to be accessible by all worker processes. One strategy is to use DistributedArrays, and the second is to use SharedArray. However I couldn't create a SharedArray of type Vector{Int} (it requires a bits type) .
The distance vector must be available to all worker processes, and be write synchronized. I implemented this as a SharedArray. But how do I reference this array in the worker processes (inside filterBFS).
Do I use a single seed vertex or can I use multiple? A single seed vertex wastes the first iteration.

The datastructure to store the graph. @ViralBShah recommended a sparse matrix, but I've found a list of lists to work better for BFS.

There's actually little difference between the two representations - a column in a sparse matrix is a list of non-zero values in the column - which boils down to an adjacency list.
This is a good start, however, I think the point of this exercise is to introduce SparseMatrix layout type(s) which can split and distribute a sparse matrix, just like distribute(array, RowLayout()) splits an array by rows and puts parts on all the processors. Next steps would be to see if we can use the framework to work through BFS, if not, what is missing, and where should they be implemented according to the design. As a good rule of thumb, sorting, distribution or redistribution of data should be implemented as Layouts (used with distribute and redistribute nodes), high-level APIs for algorithms should be implemented as ComputeNodes.

This BFS example uses Map Reduce. This is not efficient and relies on synchronized and shared memory. I've decided to implement it anyways so that we can compare performance later.
Bulk Synchronous Parallel model is the way to go. This is similar to what Apache Giraph(Pregel) and GraphX use. Luckily GraphX is in its alpha stage and Giraph is kind of slow (its built on directly on Hadoop while GraphX is build on Spark).
To implement BSP, we need a form of message passing. I found this article extremely informative. Implementing BFS is pretty straightforward if we use this model.

Also see the GunRock papers for BFS on GPUs.

The Map-Reduce BFS is working. I've added tests for filter and reduce as well.

I'll move this to a different branch.