Create service for finding tariffs between dates

This is still a work in progress.
At various places across the site we want to display what tariff information has been used between two dates.
Currently this information is provided by the analytics, which requires that we create (or fetch from cache) a meter collection. This isn't necessary or desirable for all pages.
This service is the start of implementing an alternative interface for fetching this data directly from the database.
The analytics currently handles the tariff lookup by finding what tariff applies on every day between two dates, then combining the ranges. In this implementation I'm trying to avoid this by:

querying the database to just fetch the tariffs that might apply within the range
then doing further filtering in the service

What makes this complex is that:

there is a hierarchy of tariffs to traverse
tariffs might overlap
there may be "gap" in the date ranges of tariffs which means we need to use a selection of meter, school, school group and system wide tariffs in order to find the applicable tariffs

What works so far:

finding tariffs for simple ranges
finding a mixture of tariffs, some of which are inherited
finding tariff that are overlapping
finding tariffs with "gaps"

What doesn't work currently:

finding tariffs where the inherited ranges have gaps in them, currently its returning some overlapping ranges for some scenarios. These may not arise in practice, but want to make the service handle all cases if possible so we don't have discrepancies between the analytics and the application.

Also needs:

removal of debug code
a proper refactor
some additional test cases being implemented

This could be simplified to iterate through every day as there will be a limited number of tariffs at any time, but if we can do this with less CPU intensive checks, that would be helpful.

Closing, will revert to using existing approach when this is picked up again.


Neon Number

Description
This code will take an input from the user , check and return if the number the number is a Neon number or not.
A neon number is a number where the sum of digits of square of the number is equal to the number.
For example number 9 :
9*9 = 81 and sum of the digits of the square is 9.
Therefore it's a neon number.
Domain
Algorithm
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


Filecoin support

Fixes #20

ensdomains FIL test are included here as well
https://github.com/ensdomains/address-encoder/blob/a938409270d292a0714a34b6671caab5baeecc6d/src/__tests__/index.test.ts#L541


Metrics from GPSI plugin seem to be outdated? DOM Content Loaded instead of First Input Delay

Hello,
I tried to use the Lighthouse and GPSI plugin thanks to the plus1 docker image in order to retrieve the CrUX data for First Contentful Paint and First Input Delay.
When I add the metrics.list parameter, I notice that the FCP is available and everything is working perfectly: gpsi.pageSummary.loadingExperience.metrics.FIRST_CONTENTFUL_PAINT_MS.median
The DCL is also available: gpsi.pageSummary.loadingExperience.metrics.DOM_CONTENT_LOADED_EVENT_FIRED_MS.median
But unless i'm mistaken not the FID.
The FCP - DCL combo available makes me wonder if it isn't the version 4 of the PageSpeed Insights API being used instead of the 5 ? See this doc about the deprecated v4 mentionning FCP and DCL but not FID: https://developers.google.com/speed/docs/insights/faq
What I'm running

docker run --rm -v C:\Git\Budgets-Batch:/sitespeed.io sitespeedio/sitespeed.io:9.8.1-plus1 --config ./config/mobile.json --budget.configPath ./budgets/FP/myBudget.json ./urls/FPbypass.txt --graphite.namespace sitespeed_io.smsFirstView_NoConsent --webpagetest.file ./scripts/WPT_NoConsent.txt --metrics.list

How can we retrieve the FID from GPSI?
Thank you for help
Best regards

Hi Peter, thanks for your answer.
I am looking into it a bit further and gpagespeed returns FCP and DCL, as per the return example given here: https://github.com/zrrrzzt/gpagespeed/blob/HEAD/return-example.md
Here is a return example for the latest pagespeed API (v5) with FCP and FID : https://gist.github.com/fxbtr/b1c2b429776f4967d3df620dec2439ad
Also, this paragraph mentions v4 as default for gpagespeed (instead of the current v5 pagespeed API): https://www.npmjs.com/package/gpagespeed#alternative-api
So I'm not sure either, maybe I can try to reach the creator

I think Google just kept the old one and then launched a new without changing the old :(
https://github.com/GoogleChromeLabs/psi gives the new thing, I'll make a task for updating to that.

I created a branch see https://github.com/sitespeedio/plugin-gpsi/issues/19 for that but I don't have time right now to fix the output (but we do get the right data).

I've merged the fix for using the new API in https://github.com/sitespeedio/plugin-gpsi/pull/20 - if you use the plugin standalone you can use it now. I'm releasing the container in a couple of days.

Looks like it's working great! thanks Peter


InsertQueryBuilder.values() not making type error.

At first, I think it's playground error, but IDE reporduces same problem.
You can pass any value to values.
db.insertInto("user").values(0)
db.insertInto("user").values("")
db.insertInto("user").values(true)
db.insertInto("user").values(new URLSearchParams())

If you wrap argument with array, you can also pass any value.
db.insertInto("user").values([0,0])
db.insertInto("user").values(["",""])
db.insertInto("user").values([true,false])
db.insertInto("user").values([new URLSearchParams(),new HTMLInputElement()])

Playground
"dependencies": {
    "kysely": "^0.23.3",
    "typescript": "^4.9.4"
}

I made minimum reproducible repository

I'm use WebStorm. I found that when I open the project with VSCode, type error shows correctly.  Maybe this is JetBrains related problem.

This is not happening for me..

WebStorm is notoriously weird with typescript. Some of my co-workers use it, and there were a few times it didn't error on things that immediately error with VS Code (if the language server didn't crash haha).
Maybe it uses a non-strict tsconfig other than your project's one?

Maybe it uses a non-strict tsconfig other than your project's one?

This is correct! I think VS Code has default tsconfig settings like strict: true, but playground and WebStrom has not. If I add tsconfig and set strict to true, all problem is gone. Thank you!!


Nullable expression runs without a null check

doctor:

Details
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.4 20F71 darwin-x64, locale en)
    • Flutter version 2.2.3 at /Users/minhtran/fvm/versions/stable
    • Framework revision f4abaa0735 (6 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/minhtran/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at:
      /Library/Java/JavaVirtualMachines/jdk-11.0.12.jdk/Contents/Home/bin/java
    • Java version Java(TM) SE Runtime Environment 18.9 (build
      11.0.12+8-LTS-237)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 59.0.4
    • Dart plugin version 212.4746.57

[✓] VS Code (version 1.59.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (2 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11
      (API 30) (emulator)
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 92.0.4515.131

! Doctor found issues in 1 category.

my code:
final LoyaltyProfile? result = _mapper?.from(response).copyWith(qrCode: request.customerQr);
    return result?.copyWith(
      hasPromotion: result.promotionsResources?.isNotEmpty == true,
      promotionsResources: result.promotionsResources
              ?.takeWhile(
                (value) => value.isApplicable,
              )
              .toList() ??
          [],
    );

linter show error but run fine without warning

when I modified it to result!.... linter no longer show error but when I run, it shows a
warning

Hi @tbm98,
Thanks for filing the issue, please provide the output of flutter doctor -v along with minimal reproducible code sample, and the complete error log (in the form of text), This helps to better investigate the issue.
Thank you.

@maheshmnj here you go
but in the minimal project. after I fix the analysis, the console no longer show warning when I run
and flutter doctor -v already in the description

@tbm98 Thanks for the details, I ran your sample code and I could reproduce the issue on the latest stable and the master channel. A nullable expression can be run without a null check.

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.4 20F71 darwin-arm, locale en-GB)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter
    • Framework revision f4abaa0735 (6 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 92.0.4515.131

• No issues found!

[✓] Flutter (Channel master, 2.5.0-6.0.pre.21, on macOS 11.4 20F71 darwin-arm, locale en-GB)
    • Flutter version 2.5.0-6.0.pre.21 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 40e8620a27 (4 days ago), 2021-08-06 09:14:50 +0430
    • Engine revision 431ac604da
    • Dart version 2.14.0 (build 2.14.0-383.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 92.0.4515.131

• No issues found!

/cc @pq Any idea why the analyzer wants a ! or ? here, but at runtime its determined to not be needed?

Hrmmm...
Maybe @stereotype441 has insight?
FWIW: as a general rule I think we tend to prefer early returns in cases like this:
final LoyaltyProfile? result = _mapper?.from(response).copyWith(qrCode: request.customerQr);
if (result == null) return [];

return result.copyWith(
      hasPromotion: result.promotionsResources?.isNotEmpty == true,
      promotionsResources: result.promotionsResources
              ?.takeWhile(
                (value) => value.isApplicable,
              )
              .toList() ??
          [],
    );

(Or maybe even earlier if _mapper is null.)
Or:
final LoyaltyProfile? result = _mapper?.from(response).copyWith(qrCode: request.customerQr);
if (result == null) return [];

final resources = result.promotionsResources;
if (resources == null) return [];

return result.copyWith(
      hasPromotion: resources.isNotEmpty,
      promotionsResources: resources.takeWhile(
                (value) => value.isApplicable,
              )
              .toList(),
    );

Thanks @pq for the ping, and thanks @tbm98 for the detailed repro.  This is happening due to a bug in the analyzer's implementation of null safety.  I've filed https://github.com/dart-lang/sdk/issues/46937 to track it, and should be able to get to fixing it next week.
In the meantime, @pq's suggested workarounds should all work.  Another possible workaround would be to change result?.copyWith to result?.copyWith.call, i.e.:
final LoyaltyProfile? result = _mapper?.from(response).copyWith(qrCode: request.customerQr);
    return result?.copyWith.call(
      hasPromotion: result.promotionsResources?.isNotEmpty == true,
      promotionsResources: result.promotionsResources
              ?.takeWhile(
                (value) => value.isApplicable,
              )
              .toList() ??
          [],
    );

I hope that helps!

It looks like this issue has since been fixed.
I checked on flutter 2.5.3 where the issue reproduced but it didn't reproduce on flutter 2.8.1.
@tbm98 can you confirm if this has been fixed for you as well?

screenshots

2.5.3
2.8.1

I will try and tell you soon

Yes. this issue has been fixed on 2.8.1. Thanks!


Add Porn section

Add porn section and the PornInvidious project. Some countries block access to porn sites and in some countries you will even face charges when you try to access such sites.

FYI that this could be considered controversial content, which people may want to consider using a separate repository for.

I'm OK with merging this, but could you remove the “Porn” section that is not under Social Media and Platforms?


diffeqsolve terms gives value error from within jax.vmap

Hi,
Thanks for your amazing work!
I have a simple system of odes, which I can solve with diffeqsolve without problems. But when I try to solve it varying parameters and initial conditions within vmap, I get an error:
ValueError:termsmust be a PyTree ofAbstractTerms(such asODETerm), with structure <class 'diffrax._term.AbstractTerm'>
My script below fails on the last line:
from diffrax import diffeqsolve, ODETerm, Tsit5
import jax
import jax.numpy as jnp

def odes(t, y, p):
    vmax, km = p
    return [-y[1] * vmax * y[0] / (km + y[0]), y[1] * 0.09 * vmax * y[0] / (km + y[0])]

solver = Tsit5()
term = ODETerm(odes)

# Generate initial conditions
y0 = [10.0, 0.2]
p = [10.0, 5.0]
y0_array = jnp.array([jnp.linspace(6, 12, 7), jnp.linspace(0.1, 0.7, 7)])

p_array = jnp.array([jnp.linspace(8, 12, 7), jnp.linspace(4, 6, 7)])

# One simulation
onesol = diffeqsolve(term, solver, 0, 120, 0.1, y0, p)

vect_solve_ode = jax.vmap(
    diffeqsolve,
    in_axes=[None, None, None, None, None, 1, 1],
)
sols = vect_solve_ode(term, solver, 0, 120, 0.1, y0_array, p_array)

Is my variable "term" somehow changing when invoked with vmap?
I hope you can point me out to the right direction.
Very best wishes,
Sergio

Hi Sergio,
The issue is that you are defining your single y0 as a list of values, but then try to vmap this over an array of values y0_array. Since the output of your ODE is a list, the types no longer match and diffrax will throw an error.
You do not get the same problem with the parameters, since the list and array can both be unpacked in the same way.
Here is the updated code:
import jax
import jax.numpy as jnp
from diffrax import diffeqsolve, ODETerm, Tsit5

def odes(t, y, p):
    vmax, km = p
    d_y0 = -y[1] * vmax * y[0] / (km + y[0])
    d_y1 = y[1] * 0.09 * vmax * y[0] / (km + y[0])
    return jnp.array([d_y0, d_y1])

solver = Tsit5()
term = ODETerm(odes)

# Generate initial conditions
y0 = jnp.array([10.0, 0.2])
p = [10.0, 5.0]
y0_array = jnp.array([jnp.linspace(6, 12, 7), jnp.linspace(0.1, 0.7, 7)])

p_array = jnp.array([jnp.linspace(8, 12, 7), jnp.linspace(4, 6, 7)])

# One simulation
onesol = diffeqsolve(term, solver, 0, 120, 0.1, y0, p)

vect_solve_ode = jax.vmap(
    diffeqsolve,
    in_axes=[None, None, None, None, None, 1, 1],
)
sols = vect_solve_ode(term, solver, 0, 120, 0.1, y0_array, p_array)

Thank you Johanna,
Your suggested code update solves the issue, and let me understand what I was doing wrong.
Thanks again and very best wishes,
Sergio

Great!


Synthesize Analysis Results and Identify Strategies

Problem Statement
We need to, regularly, evaluate the analysis metric results and identify strategies based on the results.

Closing out, no details in here. Work all looks like App insights work. See #7518


Its correctness is tested in https://github.com/Samsung/ONE-vscode/pull/1543
Fresh draft: https://github.com/Samsung/ONE-vscode/pull/1543
Full draft: https://github.com/Samsung/ONE-vscode/pull/1505
Related: https://github.com/Samsung/ONE-vscode/issues/1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov<EMAIL_ADDRESS>

@seanshpark PTAL :-D


[HTTP] Populate default values when annotation is not initialized

Description:
Even though there are default values for the annotations such as serviceConfig, ResourceConfig, if the user has not init them in the bal, default annotation is not attached. Hence those need to be populated internally at Java level rather skipping[1] them when the annotation is not found
[1] https://github.com/ballerina-platform/ballerina-lang/blob/master/stdlib/http/src/main/java/org/ballerinalang/net/http/HttpService.java#L207
Annotations not defined sample:
service hello2 on testEP {
    resource function info1 (http:Caller caller, http:Request req) {
        http:Response res = new;
        json responseJson = {"echo":"resOnlyCors"};
        res.setJsonPayload(responseJson);
        checkpanic caller->respond(res);
    }
}

If this is solved, we can avoid these null checks regarding configs
https://github.com/ballerina-platform/ballerina-lang/blob/master/stdlib/http/src/main/java/org/ballerinalang/net/http/HttpUtil.java#L1143
Affected Versions:
v1.2.0
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Current behaviour is not a bug, the suggestion is an improvement at code level.


Update Blocks to be able to modify fields displayed on the CMS

I needed to change the fields displayed on the CMS, we weren't using the BlockAreas and want to provide a default without the user actually seeing the option.
Changes made:
For the CMS fields:
added a "beforeExtending" function to Block, to add all the Fields before calling the updateCMSFields extensions, otherwise the extension can't remove Fields from the CMS view.
For the CMS grid view:
Change the displayFields array to BlockManager to be able to extend the function and add/remove grid fields.
Add test coverage for both changes.

ping ping ... I was considering making a similar PR. Is there a reason this wasnt merged?

Was looking for a way to modify the display fields, it would be nice to have this PR merged :)

Sorry all I'm short on time for this project at the moment. If someone wants to put their hand up to merge the conflicts I'll give you admin access

@muskie9 awesome, invites sent, thanks for volunteering!

@lhalaa what branch are you using? This won't go into master as is, but rather 1.0 or 1.1 branch. @sheadawson do you have a preference?

No preference
On 7 July 2017 at 12:26, Nic<EMAIL_ADDRESS>wrote:

@lhalaa https://github.com/lhalaa what branch are you using? This won't
go into master as is, but rather 1.0 or 1.1 branch. @sheadawson
https://github.com/sheadawson do you have a preference?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sheadawson/silverstripe-blocks/pull/28#issuecomment-313554605,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHLOA_pb8PVADPdVVNuw_DsgqyoIeZdks5sLXsogaJpZM4FgKOL
.

--
Shea Dawson
Web Developer
LiveSource
mobile +64 20 4028 5647
skype squatchnz
email<EMAIL_ADDRESS>*web *www.livesource.co.nz

@muskie9 I'm using 1.0


structurizr to grafonnix

It looks like we can do the same way in the structurizr. https://structurizr.com/json
cc @blaggacao

Oops issue, sorry

It would be interesting, indeed!


feat: add ignoreMissing option to allow skip valid language checking

This PR adds ignoreMissing option what allows skipping checking for valid language names.
/cc @zeke @sarahs for GH docs review side

@zeke These changes introduced to fix the randomly broken code blocks in electron-i18n in translate documents. The broken code blocks very hard to track and fix immediately, this option helps to disable the checking for valid language and fix the build on our CI processes.


Fixing tests

Codecov Report

Merging #27 (71ba541) into main (5843349) will increase coverage by 1.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   87.50%   88.63%   +1.13%
==========================================
  Files           6        6
  Lines         352      352
  Branches       58       58
==========================================
+ Hits          308      312       +4
+ Misses         31       29       -2
+ Partials       13       11       -2

Impacted Files
Coverage Δ

src/repositories/recommendation_repository.py
100.00% <0.00%> (+4.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5843349...71ba541. Read the comment docs.


fix(pointcloud_preprocessor): temporarily remove distortion corrector unit test

Description
The threshold in the distortion corrector unit test is a bit higher.
When the point stamps have some jitter, sometimes tests won't pass. (this only happens sometime, but will make the build_and_test_differential fail)
Since there is another PR fixing the unit test https://github.com/autowarefoundation/autoware.universe/pull/7833, I would like to temporarily remove the test to avoid autoware contributor couldn't pass build_and_test_differential
Related links
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@vividf
You told me it is urgent, so I will merge it myself

Link to a failed test:

https://github.com/autowarefoundation/autoware.universe/actions/runs/9803854835/job/27070651289#step:16:13789

🖱Click here to expand🔛
6: Test command: /usr/bin/python3.10 "-u" "/__w/autoware.universe/autoware.universe/install/ament_cmake_test/share/ament_cmake_test/cmake/run_test.py" "/__w/autoware.universe/autoware.universe/build/pointcloud_preprocessor/test_results/pointcloud_preprocessor/distortion_corrector_node_tests.gtest.xml" "--package-name" "pointcloud_preprocessor" "--output-file" "/__w/autoware.universe/autoware.universe/build/pointcloud_preprocessor/ament_cmake_gtest/distortion_corrector_node_tests.txt" "--command" "/__w/autoware.universe/autoware.universe/build/pointcloud_preprocessor/distortion_corrector_node_tests" "--gtest_output=xml:/__w/autoware.universe/autoware.universe/build/pointcloud_preprocessor/test_results/pointcloud_preprocessor/distortion_corrector_node_tests.gtest.xml"
6: Test timeout computed to be: 60
6: -- run_test.py: invoking following command in '/__w/autoware.universe/autoware.universe/build/pointcloud_preprocessor':
6:  - /__w/autoware.universe/autoware.universe/build/pointcloud_preprocessor/distortion_corrector_node_tests --gtest_output=xml:/__w/autoware.universe/autoware.universe/build/pointcloud_preprocessor/test_results/pointcloud_preprocessor/distortion_corrector_node_tests.gtest.xml
6: [==========] Running 14 tests from 1 test suite.
6: [----------] Global test environment set-up.
6: [----------] 14 tests from DistortionCorrectorTest
6: [ RUN      ] DistortionCorrectorTest.TestProcessTwistMessage
6: [       OK ] DistortionCorrectorTest.TestProcessTwistMessage (1040 ms)
6: [ RUN      ] DistortionCorrectorTest.TestProcessIMUMessage
6: [       OK ] DistortionCorrectorTest.TestProcessIMUMessage (1019 ms)
6: [ RUN      ] DistortionCorrectorTest.TestIsInputValid
6: [WARN] [1720172310.535401490] [test_node]: input pointcloud or twist_queue_ is empty.
6: [       OK ] DistortionCorrectorTest.TestIsInputValid (1031 ms)
6: [ RUN      ] DistortionCorrectorTest.TestSetPointCloudTransformWithBaseLink
6: [       OK ] DistortionCorrectorTest.TestSetPointCloudTransformWithBaseLink (1019 ms)
6: [ RUN      ] DistortionCorrectorTest.TestSetPointCloudTransformWithLidarFrame
6: [       OK ] DistortionCorrectorTest.TestSetPointCloudTransformWithLidarFrame (1025 ms)
6: [ RUN      ] DistortionCorrectorTest.TestSetPointCloudTransformWithMissingFrame
6: [WARN] [1720172313.613435184] [test_node]: "missing_lidar_frame" passed to lookupTransform argument source_frame does not exist.
Error: OR] [1720172313.613592131] [test_node]: Please publish TF base_link to missing_lidar_frame
6: [       OK ] DistortionCorrectorTest.TestSetPointCloudTransformWithMissingFrame (1035 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloudWithEmptyTwist
6: [       OK ] DistortionCorrectorTest.TestUndistortPointCloudWithEmptyTwist (1030 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloudWithEmptyPointCloud
6: [       OK ] DistortionCorrectorTest.TestUndistortPointCloudWithEmptyPointCloud (1033 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloud2dWithoutImuInBaseLink
6: [       OK ] DistortionCorrectorTest.TestUndistortPointCloud2dWithoutImuInBaseLink (1034 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloud2dWithImuInBaseLink
6: [       OK ] DistortionCorrectorTest.TestUndistortPointCloud2dWithImuInBaseLink (1042 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloud2dWithImuInLidarFrame
6: [       OK ] DistortionCorrectorTest.TestUndistortPointCloud2dWithImuInLidarFrame (1032 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloud3dWithoutImuInBaseLink
6: [       OK ] DistortionCorrectorTest.TestUndistortPointCloud3dWithoutImuInBaseLink (1035 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloud3dWithImuInBaseLink
6: [       OK ] DistortionCorrectorTest.TestUndistortPointCloud3dWithImuInBaseLink (1036 ms)
6: [ RUN      ] DistortionCorrectorTest.TestUndistortPointCloud3dWithImuInLidarFrame
6: /__w/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/test/test_distortion_corrector_node.cpp:587: Failure
6: The difference between data_ptr[i * 5] and expected_pointcloud[i][0] is 5.340576171875e-05, which exceeds 5e-5, where
6: data_ptr[i * 5] evaluates to 20.010353088378906,
6: expected_pointcloud[i][0] evaluates to 20.010299682617188, and
6: 5e-5 evaluates to 5.0000000000000002e-05.
6: [  FAILED  ] DistortionCorrectorTest.TestUndistortPointCloud3dWithImuInLidarFrame (1036 ms)

@vividf please add links to the problem and also a snippet too (action run logs are deleted after a while). This helps understanding why something was made with concrete evidence, even after a long time has passed.

@xmfcx
It seems the cause was using non-deterministic functions in the unit test.It is being worked here
https://github.com/autowarefoundation/autoware.universe/pull/7833#issuecomment-2212653433

@xmfcx Thanks I added in the description of this PR.


Correctly @-mention users when using msg.reply

When using msg.reply, users would have to have their Slack nickname as a highlight word to receive notifications, because Hubot wasn't sending the special formatting to generate an @-reply. This fixes it so that Hubot generates correct @-replies.

This looks like it should fix #195

I would like this :3

It's been annoying me for the longest time. Seems so basic. >_>

I see this has been merged, any chance of it getting published soon? =) pretty please


Error when api connects to backend

[1] [nodemon] starting `python ./backend/whatsapp_web_backend.py`
[2] Sass is watching for changes. Press Ctrl-C to stop.
[2]
[0] whatsapp-web-reveng API server listening on port 2019
[0] whatsapp-web-reveng HTTP server listening on port 2018
[0] got message  { command: 'api-connectBackend', from: 'client', type: 'call' }
[0] events.js:292
[0]       throw er; // Unhandled 'error' event
[0]       ^
[0]
[0] Error: connect ECONNREFUSED <IP_ADDRESS>:2020
[0]     at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1142:16)
[0] Emitted 'error' event on WebSocket instance at:
[0]     at WebSocket.finalize (C:\Users\Dennis\Desktop\whatsapp-web-reveng-master\node_modules\ws\lib\WebSocket.js:182:41)
[0]     at ClientRequest.<anonymous> (C:\Users\Dennis\Desktop\whatsapp-web-reveng-master\node_modules\ws\lib\WebSocket.js:647:10)
[0]     at ClientRequest.emit (events.js:315:20)
[0]     at Socket.socketErrorListener (_http_client.js:461:9)
[0]     at Socket.emit (events.js:315:20)
[0]     at emitErrorNT (internal/streams/destroy.js:96:8)
[0]     at emitErrorCloseNT (internal/streams/destroy.js:68:3)
[0]     at processTicksAndRejections (internal/process/task_queues.js:84:21) {
[0]   errno: -4078,
[0]   code: 'ECONNREFUSED',
[0]   syscall: 'connect',
[0]   address: '<IP_ADDRESS>',
[0]   port: 2020
[0] }
[0] [nodemon] app crashed - waiting for file changes before starting...

Exactly the same error here! Did you solve that?
It connects to API, but when i try to connect to backend shows this error


Support for files

There should be a possibility to choose a file path instead of typing scripts into field.

Fixed in 19d72e93dd56af87c4d7371bb48cb75bc02b0eb6, although without GUI.


Add Form Liquidity

Fixed major issues and created new branch
Images:

You need to take much more care of everything please. I've done so many review of this PR since the ODHack

You need to take much more care of everything please. I've done so many review of this PR since the ODHack

sorry for the continuous errors, please review my changes i have removed the yup and used the appropriate theme


fix: error on o

fix:wrong align on bottom vertical line

Use api.nvim_win_is_valid whether win = nill is also required

Use api.nvim_win_is_valid whether win = nill is also required

IMHO, with and expression can fail fast, which avoids useless api calling

Use api.nvim_win_is_valid whether win = nill is also required

IMHO, with and expression can fail fast, which avoids useless api calling
IMHO, fix: wrong align on bottom vertical line should create an issue first

I can merge fix for you: error on o

2f0823546c872ea8976a36ebfa2502458e93d983  I'd like to see your minimal reproducible code first

2f08235 I'd like to see your minimal reproducible code first

This turns out to be a theme issue, covering the winbar.
I tried with other configs, just work~
I think we can merge the <C-w>o fix only.

Could you provide a minimal code to reproduce the issue? I'd like to try reproducing it myself first.

Could you provide a minimal code to reproduce the issue? I'd like to try reproducing it myself first.

Okey, I reproduced the issue only with this plug & lazy.nvim
here's the minimal config:
-- [[ Install `lazy.nvim` plugin manager ]]
--    https://github.com/folke/lazy.nvim
--    `:help lazy.nvim.txt` for more info
local lazypath = vim.fn.stdpath 'data' .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system {
    'git',
    'clone',
    '--filter=blob:none',
    'https://github.com/folke/lazy.nvim.git',
    '--branch=stable', -- latest stable release
    lazypath,
  }
end
vim.opt.rtp:prepend(lazypath)

require('lazy').setup({
  {
    "nvim-zh/colorful-winsep.nvim",
    config = true,
    event = { "WinNew" },
  }
})

Could you provide a minimal code to reproduce the issue? I'd like to try reproducing it myself first.

Okey, I reproduced the issue only with this plug & lazy.nvim here's the minimal config:
-- [[ Install `lazy.nvim` plugin manager ]]
--    https://github.com/folke/lazy.nvim
--    `:help lazy.nvim.txt` for more info
local lazypath = vim.fn.stdpath 'data' .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system {
    'git',
    'clone',
    '--filter=blob:none',
    'https://github.com/folke/lazy.nvim.git',
    '--branch=stable', -- latest stable release
    lazypath,
  }
end
vim.opt.rtp:prepend(lazypath)

require('lazy').setup({
  {
    "nvim-zh/colorful-winsep.nvim",
    config = true,
    event = { "WinNew" },
  }
})

The horizontal line is not aligned with the winbar in up window

There is a lingering issue where the status bar is being covered, and I'm sorry, but I don't have any free time to address it.

You can enable WinBar for now, and I'll fix it when I have the time.


Autorest should not inject copyright header to generated files

Describe the issue or request
Autorest csharp v3 injects fixed copyright header to all generated c# files. This licensing and copyright message is unexpected.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

// <auto-generated/>

Describe your ideas for solutions
It would be nice to be able to customize generated files header or at least change it to something more appropriate as v2 generator injected.
// <auto-generated>
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

@dolly22 May I know why do you want to remove these copy right information? Are you using autorest to generate SDK for your own API?

@xboxeer Yes, we are currently using autorest v2 to generate clients (C# and typescript) for our own api. I'm trying to upgrade and use autorest v3.

Can somebody make it clear: is autorest supposed to be used by projects outside of microsoft or not?

@iivmok autorest is an open source project and it can be used outside Microsoft. We are considering to add a new feature to enable/disable Microsoft copy right information

@xboxeer Did you add an option to remove this header from the generates files? I've tried using --license-header=none but it doesnt do anything..

@xboxeer Did you add an option to remove this header from the generates files? I've tried using --license-header=none but it doesnt do anything..

So this issue is discussing whether the generated files should include license headers, but we currently do not support cusotmizing the license headers.
Could you open a new issue as a feature request to supersede this issue?

Thanks @ArcturusZhang , I have created a new issue - https://github.com/Azure/autorest.csharp/issues/5078

I had a fix that allows the user to customize the file header - if you pass in empty string, and it will not have file headers any more.
That does not fixes this issue, but I think it nullifies the issue we are discussing here.


Compile error - macros dependency

Hi, I am trying to compile code on my Ubuntu machine but get an error
checking pkg-config m4 macros... no
I checked all 3 packages and "macros" package is missing. I have on idea how to install macros package on Ubuntu. Any help would be appreciated.

Google is your friend. The system is looking for the file containing m4 macros for pkg-config. On my Linux Mint system (derived from Ubuntu) it's /usr/share/aclocal/pkg.m4 and was installed as part of the pkg-config package.

I will repeat my self one more time. pkg-config and m4 packages are installed. also what you are referring to pkg.m4 file is also on correct location. Not sure why this check is checking for macros package???

It seems that it is required to run autoreconf -i after apt install pkg-config. I've just created simple installation guide and during the process of step by step dependencies installation I've stumpled upon the same issue. See this: https://github.com/Arkq/bluez-alsa/wiki/Installation-from-source
I'm closing this issue, however, it will still occur after autoreconf -i please reopen.


[Brick] Add toggle and toggle group widget

now we have a better toggle widget support

now we have a better toggle widget support

Picture? :)

Picture? :)


Minimum / Maximum values are incorrect

If I have an API definition with a parameter like this:
{
  name: 'limit',
  type: 'Query',
  schema: z.number().positive().default(10),
},

The generated OpenAPI doc shows "minimum":0 for limit. This should be 1, since 0 is invalid input for .positive(). The same issue applies to .negative(), where maximum should be -1 instead of 0

Actually, I think the output is good since it produces also an exclusive minimum :
          {
            "description": "Limit the number of users",
            "in": "query",
            "name": "limit",
            "required": false,
            "schema": {
              "default": 10,
              "exclusiveMinimum": true,
              "minimum": 0,
              "type": "number",
            },
          },

Ah yep, you're right. I think the issue is just with swagger-ui-express not preventing you from sending 0 in that case.


Update README.md

👷 Deploy Preview for golden-faun-061281 processing.

Name
Link

🔨 Latest commit
743335f5aec0253e779c6377360424571b21c8e8

🔍 Latest deploy log
https://app.netlify.com/sites/golden-faun-061281/deploys/653c8afc74ecaa0008dfc0d8


Property chaining can crash due to NSNumber conversion in makeAdditve

Connecting a property to another property can cause a runtime crash due to invalid type conversions. This is due to the introduction of an implicit NSNumber conversion somewhere along the pipeline.

🎊 My diff is ready for review at http://codereview.cc/D2967


The #build alias for import files in server handlers returns error Vue app aliases are not allowed in server runtime

Environment

Operating System: Linux
Node Version:     v18.20.3
Nuxt Version:     3.13.2
CLI Version:      3.14.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>
Reproduction
https://stackblitz.com/edit/nuxt-starter-ra1h6e
Describe the bug
I want to have an utility file to collect some functions that I can use in server endpoints.
Moreover, I wanted to move some functionality from the root utils directory to a module. I followed the official documentation of module creation with example of addTemplate with virtual files. But when I moved the file from the utils directory to the same one in a created module and tried to use the utils file in server handlers, I got the error:
[nitro 15:07:04]  ERROR  RollupError: [plugin impound] Vue app aliases are not allowed in server runtime. [importing #build/utils/custom from server/api/builtin-utils.get.ts]

The main reason that the #build alias is not allowed in the server handlers and there's no way to import the dynamic built file even if the file content is absolutely the same. It doesn't make modules developments flexible enough honestly.
Do you have any advice to solve my issue?
Additional context
Steps to reproduce
Open the app.vue file. There are 2 requests to endpoints via useFetch. I just wanted to check if there's any difference between built-in server handlers and dynamically created ones in a module.
The custom.ts file is created in the root utils directory. And the file import ~/utils/custom is used in the builtin-utils.get.ts server handler.
import { customFunction as customFunctionBuiltinUtils } from '~/utils/custom';

Than I duplicated the custom.ts file to a new created module. That injected via the general index.ts of the module:
addTemplate({
  filename: 'utils/custom',
  src: resolve('runtime/utils/custom.ts'),
});

Now we can jump back to the builtin-utils.get.ts server handler file and replace import from
import { customFunction as customFunctionBuiltinUtils } from '~/utils/custom';

to
import { customFunction as customFunctionModuleUtils } from '#build/utils/custom';

When the import replaced, get the error in the terminal. Try to re-run npm run dev in some cases:
[nitro 15:07:04]  ERROR  RollupError: [plugin impound] Vue app aliases are not allowed in server runtime. [importing #build/utils/custom from server/api/builtin-utils.get.ts]

Logs
[nitro 15:07:04]  ERROR  RollupError: [plugin impound] Vue app aliases are not allowed in server runtime. [importing #build/utils/custom from server/api/builtin-utils.get.ts]

I personally use
addServerImports([
      {
        name: 'functionName',
        from: resolve('./runtime/utils/function-name'),
      },
]);

and then retrieve it from the #imports
Adding it this way you will also see it in the types/nitro-imports.d.ts
Stackblitz: https://stackblitz.com/edit/nuxt-starter-zgtbkd?file=modules%2Fcustom%2Findex.ts

This is deliberate because they are two totally different build contexts - even if it worked it would result in two copies of the same code being bundled.
To create virtual files that can be accessed in Nitro, you can do something like this:
nitro.options.virtual['some-import'] = () => `export default 'some export'`

I think it would be useful to add a helper for this - addServerTemplate.


HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/hbase/pull/3640 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Just saw the new comment added. It is great. Be lated +1.


Use dtype.type when passing to downstream NumPy functions

Description
This works with both NumPy dtypes and data types from other array libraries such as tensorstore.
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Change looks good, but we've got some failing tests

Ugh. Turns out it's pretty finicky to make dtypes work generally across all duck-array types:
In [1]: np.uint8.type
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-1-c60fb0eb7e75> in <module>
----> 1 np.uint8.type

AttributeError: type object 'numpy.uint8' has no attribute 'type'

In [2]: np.dtype(np.uint8).type
Out[2]: numpy.uint8

In [4]: import tensorstore as ts

In [5]: ts.uint8
Out[5]: dtype("uint8")

In [6]: ts.uint8.type
Out[6]: numpy.uint8

In [7]: np.dtype(ts.uint8)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-7-3f2a10f02536> in <module>
----> 1 np.dtype(ts.uint8)

TypeError: Cannot interpret 'dtype("uint8")' as a data type

In [8]: np.dtype(np.uint8)
Out[8]: dtype('uint8')

In [9]: np.dtype(np.uint8).type
Out[9]: numpy.uint8

In [10]: np.dtype(np.dtype(np.uint8))
Out[10]: dtype('uint8')

In [11]: type(np.dtype('uint8'))
Out[11]: numpy.dtype

In [12]: type(np.dtype('uint8').type)
Out[12]: type

In [13]: type(ts.uint8)
Out[13]: tensorstore.dtype

In [14]: type(ts.uint8.type)
Out[14]: type

In [15]: import torch

In [16]: type(torch.uint32)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-16-d7d700eed551> in <module>
----> 1 type(torch.uint32)

AttributeError: module 'torch' has no attribute 'uint32'

In [17]: torch.zeros(5).dtype
Out[17]: torch.float32

In [19]: type(torch.int32)
Out[19]: torch.dtype

In [21]: str(torch.int32)
Out[21]: 'torch.int32'

In [22]: torch.int32.type
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-22-1836c298d59e> in <module>
----> 1 torch.int32.type

AttributeError: 'torch.dtype' object has no attribute 'type'

I'll try to come up with something...

Ok, this should be ready to review, let's see. 🤞 I've added torch and tensorstore test requirements, which I can remove/skipif if people don't like that.
I don't love the dtype-from-string hack I've done here, but I played around with all the relevant libraries (to wit: numpy, dask, zarr, tensorstore, and torch), and this is the only way I could come up with that works with all of them (and probably a few others). If anyone has alternate suggestions, I'm all ears.
Finally, there'll probably be a merge conflict with #2640, happy to fix whichever one comes second.

@jni looks like #2640 might be close too, i'll let you merge and handle conflict when you're ready.

Ooh, CI looking good...! 😊

Merged!!


Project Properties tool window shows "Output Type" twice

The .NET Core project system's properties tool window shows Output Type twice when the project node is selected in Solution Explorer:

The BrowseObject .xaml file probably lists the property twice.

Indeed, two properties are defined with the same display name.
Also, why are integers used as the display text for these property values? That's worse than even the msbuild level property values.

Context on why it was added twice and int #261. This should be fixed as we resolve #389

This should be fixed with #1472


Pix.LoadFromMemory takes time overhead

I see pix.LoadFromMemory() takes an average of 350ms in my cases, How I can increase its performance?

Probably an issue that should be discussed on the Leptonica Github issues list.

I was seeing this too - What I really want is to be able to give it a pointer to the byte array of image memory that is already decoded. The current sample creates an entire copy of it - that's a lot of overhead that could be saved, and it's not uncommon we already have a decoded image.


Implement Processes

There have been several successful implementations of the csp model in JavaScript. One being core.async for clojurescript
http://swannodette.github.io/2013/08/02/100000-dom-updates/
And another in plain JavaScript, js-csp:
https://github.com/ubolonton/js-csp
The CSP model and the actor model are somewhat equivalent and so bringing the actor model to the browser for elixirscript should be possible (hopefully).
An example of an attempt from before would be er.js
http://beatniksoftware.com/erjs/
The code there is based on what looks like an older draft of es6 possibly? Looking through the code, I understand the approach. Maybe gaining ideas from it is a way to go.
The translated code will possibly have to change as well. For instance, we may have to turn all the functions into generators and yield where appropriate.
Another thing I've been thinking about is possibly coming up with some sort of modified or equivalent actor model. The requirements are that processes are the smallest unit of computation, they are isolated from each other, they are identifiable (by id or by name) and they communicate via message passing. Maybe breaking things down to those requirements can open doors to a possible implementation.

This article I think gives a good idea of what could be possible:
http://lucasmreis.github.io/blog/using-csp-as-application-architecture/

This commit adds in the process modules 0e41d4c7b7bdf7067b62878f49e290e346bb9848


Code is being copy/pasted on save with formatOnSave set to true

Describe the bug
Code is being copied from a script tag and pasted inside an if clause.
Impacted Products
Which Antlers Toolbox products does this bug apply to?

[x] Antlers Toolbox for VS Code
[ ] Formatter CLI
[ ] Antlers Prettier Plugin
[ ] Antlers Syntax Highlighting (external systems - not VS Code)

Versions and Other Plugins/Extensions
Antlers Toolbox v2.6.7
Prettier - Code formatter v10.1.0 (issue persists when I disable prettier)
settings.json
  "[html]": {
    "editor.defaultFormatter": "stillat-llc.vscode-antlers",
    "editor.formatOnSave": true,
    "editor.codeActionsOnSave": {
        "source.fixAll.eslint": true
    },
    "editor.quickSuggestions": {
        "strings": true
    },
  }

To Reproduce
Create a new antlers file e.g. _test.antlers.html with the contents below
<script type="application/json">
    {{ if something }}
    {{ /if }}
</script>

{{ if somethingElse }}
    <script></script>
{{ /if }}

Saving the file reformats, but also duplicates code resulting in
<script type="application/json">
    {{ if something }}
    {{ /if }}
</script>
{{ if somethingElse }}
    {{ if something }}
    {{ /if }}
    <script></script>
{{ /if }}

where it for some reason copies the content of the first <script> tag and pastes it inside the {{ somethingElse }} if statement.
If I try to use Alt K + F to format, I get an error saying Antlers Toolbox cannot format HTML (Statamic Antlers)

Expected behavior
That it only formats the file.
If submitting a formatting bug, please include the template contents below as well as an attachment
_test.antlers.txt
Please rename to .html as I could not upload an html file here.

Code duplication in <script> tags has been resolved in the following releases:

prettier-plugin-antlers: 1.2.6
antlers-language-server: 1.2.7
antlers-formatter: 1.2.6
Antlers Toolbox for VS Code: 2.6.8

Hi @JohnathonKoster
Thanks for the fix!
I do experience some other funny behavior after the update.
In my simple test file, when saving it the if statement within the script tag get replaced by a random indentifier e.g.
<script type="application/json">
    < agyfprw4kffub4a >

        <
        /agyfprw4kffub4a>
</script>
{{ if somethingElse }}
    <script></script>
{{ /if }}

In my regular file, where I first saw the original bug, it now indents the contents and the closing tag of the script on every format leading to excessive indentation.

I'm not unable to reproduce either issue with the latest prettier or formatter build (reformatting the same input over 100 times) 🤔
Would you be able to be able to share you prettier configuration, as well as the original file that is experiencing the excessive indentation bug (if you want to keep it private, you can email it to john@stillat.com).
Thanks!

@JohnathonKoster sorry for the radio silence...
It happens to me in this file: https://github.com/studio1902/statamic-peak-seo/blob/c29efae7c2d3e5efdcb0e4a05a57d2dfa6414296/resources/views/snippets/_seo.antlers.html
Lines 81-99, 107-121, 167-175 keeps getting indented on each saving of the file.


Integration test improvements

Explain your changes:
This PR introduces major refactoring and simplification to the Test_common module and all integration tests.

adds a test_name val to the output module of the Integration_test_lib.Intf.Test functor
adds an optional prefix to the Logger for including test names in the logs
eliminates the pesky dsl, network, and node types from tests
refactors the Test_common module to make it more user-friendly
adds comments for all Test_common functions
eliminates a few of the persistent compilation errors in various apps

Explain how you tested your changes:
That's really the problem isn't it... This is the first step in making the testing process more accessible. But, it compiles!

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1204944927668541

https://github.com/orgs/MinaFoundation/projects/2/views/1?pane=issue&itemId=32231489


Project Needs Package Reorganization

There just two main issues that I think should be fixed.

[ ] The plugin configuration files don't have their own separate folder.

This can be fixed by moving them into a new folder called "resources" or whatever at the base of the src.

[ ] The project uses improper package declarations. Usually, you only use .com if you own a website with that top level domain, but since (afaik) you don't the package should be named to me.Turkey2349.zombies

Please correct me if I'm wrong about the second one.

what do you mean the config files don't have their own folder?
also as for the package name, yes your way works to, but it is not that major of an issue and there is no reason for me to change them now.

@AnUnknownMiner is correct - you shouldn't do this. It's quite important as someone that may end up owning that domain (which is entirely possible) may then use it in their package declarations, causing a conflict with anything you may have written here.
Since you're using GitHub, however, the recommendation is com.github.Turkey2349.zombies - You could alternatively use your email address, com.<gmail, hotmail, etc>.Turkey2349, or whatever it is you use, but the former seems better.

Additionally, by convention, your project should be laid out as follows.
- src/
+ - main/
| + - java/ (Main plugin code)
| + - resources/ (Non-code files to be included in the JAR, eg .yml files)
+ - test/
| + - java/ (Unit test code)
| + - resources/ (Non-code files related to unit tests)


(GH-2295) Add 'Generating types' message to module installer

This adds a message to the module installer that informs the user that
Bolt is generating types after installing modules.
!no-release-note

CLA signed by all contributors.


Image window move when close another image window

Describe the bug
When close an image window, another image window have a chance to move to another location.
To Reproduce
Steps to reproduce the behavior:

Open or generate at last two image window.
Close the first one of them.
See error. The second opened window will move.

Expected behavior
The image window shouldn't move.
Desktop (please complete the following information):

OS: Windows 10 x86-64
Version: master branch (at least 2c95d5f)

Additional context
Not sure when the problem started, but at least in 2c95d5f. View the file tree here.

It should call ImGUI::End() before jumping out of the current iteration of the for loop.
here:
https://github.com/shangchiwu/advanced-image-processor/blob/2c95d5f2b841a924a651ba54b5db195c95080850/src/main.cpp#L353-L357

It should call ImGui::End() before jumping out of the current iteration of the for loop. here:
https://github.com/shangchiwu/advanced-image-processor/blob/2c95d5f2b841a924a651ba54b5db195c95080850/src/main.cpp#L353-L357

That's true.
But, nope. it's not the reason causing this bug.

The counter i should be decreased by one before continue the for loop, because the for loop will auto increase the counter i.
here:
https://github.com/shangchiwu/advanced-image-processor/blob/2c95d5f2b841a924a651ba54b5db195c95080850/src/main.cpp#L353-L357

It should call ImGui::End() before jumping out of the current iteration of the for loop. here:
https://github.com/shangchiwu/advanced-image-processor/blob/2c95d5f2b841a924a651ba54b5db195c95080850/src/main.cpp#L353-L357

That issue is also fixed in 0796931 in #28.


[Communication] - Autorest - Updating to point to readme.md

Git Issue https://github.com/Azure/azure-sdk-for-net/issues/18733
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Closing because outdated, phone number was change quite a bit. Going to create a new PR based off of GA


LibWeb: Fix translation from CSS::ImageRendering to Gfx::ScalingMode

Fixes #1170

Superseded by #1208


Allow to use with React 17

The library works perfectly with React 17 so it will allow users to not use npm --legacy-peer-deps

@Aviortheking Thanks, didn't know you need to do that on react 17. Thanks for the addition!


vboxrun.sh should make sure host-only network is defined

With a fresh install of virtualbox vboxrun.sh doesn't work unless you create a host-only network. It's sufficient to just create a default one, using virtualbox->preferences->Network->Host-only Networks and then clicking the little green "+ nic" icon:

#297 duplicate. Close on of these?


Change the cursor hover state of a disabled method tile to not-allowed

While testing I found it odd that the cursor would suddenly disappear when it was over a disabled tile. Using not-allowed in my mind makes more sense to convey that I can't choose that option.

Hey @indygriffiths . The build is failing because you will need to bundle the distribution files with your PR. Can you run yarn build in the repo root and then commit the compiled distribution files with your PR?

@ScopeyNZ Mind sanity checking and doing a build as well? Getting a failure as it can't find the variables file when building the bundle.
            Asset     Size  Chunks             Chunk Names
styles/bundle.css  3.69 kB       0  [emitted]  bundle
   [0] ./client/src/bundles/bundle.scss 1.06 kB {0} [built] [failed] [1 error]

ERROR in ./client/src/bundles/bundle.scss
Module build failed: ModuleBuildError: Module build failed:
@import 'variables';
^
      File to import not found or unreadable: variables.
      in /home/igriffiths/Sites/silverstripe-mfa/client/src/bundles/bundle.scss (line 2, column 1)
    at runLoaders (/home/igriffiths/Sites/silverstripe-mfa/node_modules/webpack/lib/NormalModule.js:192:19)
    at /home/igriffiths/Sites/silverstripe-mfa/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /home/igriffiths/Sites/silverstripe-mfa/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/home/igriffiths/Sites/silverstripe-mfa/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at Object.asyncSassJobQueue.push [as callback] (/home/igriffiths/Sites/silverstripe-mfa/node_modules/sass-loader/lib/loader.js:55:13)
    at Object.done [as callback] (/home/igriffiths/Sites/silverstripe-mfa/node_modules/neo-async/async.js:8067:18)
    at options.error (/home/igriffiths/Sites/silverstripe-mfa/node_modules/node-sass/lib/index.js:294:32)

Right - you need the dev version of silverstripe/admin for your builds to work correctly. Kind of a convoluted requirement. I'll do it for you (and I'll rebase onto 4.0 for you too).

FYI I've cherry picked this fix back to the 3.0 branch for you


Axon-myelin display in mask

As discussed last week, we said we wanted a final display similar to the current AxonSeg version (as_display_label() function). You should be able to close the outer myelin shapes and get a continuous boundary (so you will be able to display the full myelin segmentation (and not only the some outer boundary points).

check issue #9

Actually, it was already implemented but never used in the test.json
We added a
"display":"full"
flag so it would be rendered.
Can you try again ? The git should be up to date now with the correct flag in the default test.json

I tried, but when can I find the display? I dont see any other output image in the output folder, other than the axon-myelin binary result.

Sorry, it wasnt working probperly.
commit  9e473594f9793487018ee459cad6a1627a4489b0 shoud have fied this issue.
For the output file check test.json
It should be :
"outputImage":"../tests/SegTest/Step_2_Initial_AxonSeg_mey.png",

Ok, I tested it. But can I also do it for the axons? If I add 'full' to the display in AxonSeg part of json, will I also get the axon display in colors?

Like this? http://imgur.com/a/fG1bi

Yes, exactly!

BTW, are you using the 3 discrimination params (minsize, solidity, minormajorraio)? I know theyre on the json file, but not sure if youre using them.

THose 3 and the maxSize if it's also present.

Ok good! Theorically, these 4 shouldnt be in the axon segmentation algo part as its mostly axon post-procesing (meaning axons are already segmented, its just like we apply filters to eliminate some of the axons we dont want to keep before launching the myelin step), but its OK, you can leave it like that.

Extended minima will generate a lot of noise to be discarded, that's why it is in that step.


Add crossnote.json (~/.mume)

It's been supported since https://github.com/shd101wyy/crossnote/pull/234.

Thank you!


Char module and FFI

Hi,
I have been working on a rudimentary System.Char module.
But the method names are all capitalized.
I have uncapitalized(?) them for now, but that raises a question.
Do we have any ideas on an FFI for this?
It would also solve the string() operator issue  #6 (dispatch to different functions with same arity but different type signatures) without having to make it a special case in the compiler.

I personally think compiler should handle decapitalizing

@rascala can you raise an early PR so I can see how you've been approaching it?

this code System.Char.IsDigit '1' will generate the following core erlang:
call 'System.Char':'IsDigit'($1)

which means you need to implement an erlang module named 'System.Char' (note single quotes) with a function named 'IsDigit' taking a single argument.

Hadn't done that!
It seems to work fine now.
Thanks

We need to have a discussion on whether / which System.* modules should be part of the core compiler or should ship as an optional library but for now just stick implementations into src like all the others.

Modules like System.Char that refer to core types should probably go in here. At least the static methods and non-mutable apis.


Razor cshtml view doesn't see new property on model

I just had a weird issue after deploying my asp.net core app to azure app service (on full .net 4.6.1).
One of my views Shell.cshtml is using a strongly typed model:
@model NitroCharts.Web.AppModel
And one of the deployed changes was the addition of a new property IsProduction to that model. It ran fine locally however when I deployed it to the azure service, the cshtml file couldn't 'see' the new property, which resulted in a compile error. This was a massive issue because no one could load the site anymore...
What can cause the cshtml view to somehow hang on to an old version of the deployed assembly??? I tried restarting the app service but that didn't help...
The weird thing is that the model and the cshtml are in the same project, the top level asp.net core project, so they must have been deployed...
Am I missing something here???
Shell.cshtml:
...
@if (Model.IsProduction)
...
Error from Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware: An unhandled exception has occurred: One or more compilation failures occurred: /shopify/Shell.cshtml(26,16): error CS1061: ‘AppModel’ does not contain a definition for ‘IsProduction’ and no extension method ‘IsProduction’ accepting a first argument of type ‘AppModel’ could be found (are you missing a using directive or an assembly reference?)
I use VS 2017 and use web deploy for deployment.
Any help would be much appreciated...
Here are the asp.net core packages:
    <PackageReference Include="Microsoft.AspNetCore.Diagnostics" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="1.1.2" />
    <PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="1.1.2" />
    <PackageReference Include="Microsoft.AspNetCore.Rewrite" Version="1.0.1" />
    <PackageReference Include="Microsoft.AspNetCore.Routing" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.Server.IISIntegration" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.SpaServices" Version="1.0.0-beta-000019" />
    <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="1.1.1" />

My csproj has <PreserveCompilationContext>true</PreserveCompilationContext>. What does this do?

@pranavkm could this be an issue with precompilation?

FYI I tried another deploy and the same thing happened again.

@clement911 do you have MvcCompileViewsOnPublish in your application (you're not referencing the view compilation package which makes it seem unlikely)?

No. How does pre-compilation work? Is there a way to flush the cache?
Here is my entire web project .csproj:
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
    <PreserveCompilationContext>true</PreserveCompilationContext>
    <AssemblyName>NitroCharts.Web2</AssemblyName>
    <OutputType>Exe</OutputType>
    <PackageId>NitroCharts.Web2</PackageId>
    <TypeScriptCompileBlocked>true</TypeScriptCompileBlocked>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <PlatformTarget>x64</PlatformTarget>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
    <PlatformTarget>x64</PlatformTarget>
  </PropertyGroup>

  <ItemGroup>
    <None Include="App.config" />
    <None Update="wwwroot\**\*;_content\**\*">
      <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory>
    </None>
    <ProjectReference Include="..\NitroCharts.Domain\NitroCharts.Domain.csproj" />
    <ProjectReference Include="..\ShopifyLib\ShopifyLib.csproj" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="DistributedLock" Version="1.3.0" />
    <PackageReference Include="Microsoft.AspNetCore.Authentication.Cookies" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.Diagnostics" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="1.1.2" />
    <PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="1.1.2" />
    <PackageReference Include="Microsoft.AspNetCore.Rewrite" Version="1.0.1" />
    <PackageReference Include="Microsoft.AspNetCore.Routing" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.Server.IISIntegration" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="1.1.1" />
    <PackageReference Include="Microsoft.AspNetCore.SpaServices" Version="1.0.0-beta-000019" />
    <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="1.1.1" />
    <PackageReference Include="Microsoft.CodeAnalysis.Common" Version="1.3.2" />
    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="1.3.2" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="1.1.1" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="1.1.0" />
    <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="1.1.1" />
    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="1.1.1" />
    <PackageReference Include="Microsoft.Extensions.Logging" Version="1.1.1" />
    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="1.1.1" />
    <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="1.1.1" />
    <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="1.1.1" />
    <PackageReference Include="Microsoft.Net.Http" Version="2.2.29" />
    <PackageReference Include="Microsoft.VisualStudio.Web.BrowserLink" Version="1.1.0" />
    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
    <PackageReference Include="Sendgrid" Version="6.3.4" />
    <PackageReference Include="ShopifySharp" Version="3.6.0" />
    <PackageReference Include="System.ComponentModel.Annotations" Version="4.3.0" />
    <PackageReference Include="System.Interactive" Version="3.1.1" />
    <PackageReference Include="System.Interactive.Async" Version="3.1.1" />
    <PackageReference Include="System.Net.Http" Version="4.3.1" />
    <PackageReference Include="System.Reactive.Linq" Version="3.1.1" />
    <PackageReference Include="System.Security.Claims" Version="4.3.0" />
    <PackageReference Include="System.ValueTuple" Version="4.3.0" />
    <PackageReference Include="TimeZoneConverter" Version="1.0.0" />
  </ItemGroup>

  <ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
    <Reference Include="System" />
    <Reference Include="Microsoft.CSharp" />
  </ItemGroup>

  <Target Name="PrepublishScript" BeforeTargets="PrepareForPublish">
    <Exec Command="_misc/prePublish.bat" />
  </Target>

  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.EntityFrameworkCore.Tools.DotNet" Version="1.0.0" />
  </ItemGroup>

</Project>

@clement911 - precompilation is enabled by referencing the package and setting the property I listed earlier so that's clearly not the case here. Mvc in AspNetCore caches the result of compilation in memory so once you restart your app, there really isn't any cache to flush.
Is there a way for you to determine if the application's binary (presumably NitroCharts.Web2.dll) got updated as part of deployment (For instance via Kudu - https://blogs.msdn.microsoft.com/benjaminperkins/2014/04/01/get-azure-website-deployment-logs-from-kudu/)?

I know it has been updated because the logs are showing messages that didn't exist before.
In other words, it's like the dll was deployed, but the old one is still being picked by Razor...

It's actually NitroCharts.Web2.exe because how asp.net creates an .exe and not a dll...

@davidebbo have you seen other reports of an error like this? I can't think of a reason the views would continue to be compiling against stale binaries.

@pranavkm I'm guessing you didn't mean me?

I did mean you 😄. The issue apparently occured as part of deploying a desktop targeting Mvc application to Azure App Services. We don't have any disk caching for view compilation in AspNetCore, so I can't think of a good reason why the app's executable might have updated (per @clement911), but it ends up being stale when we do our runtime compilation.
Just curious if you've seen other folks run in to similar issues with their AspNetCore applications on App Services.

That doesn't ring a bell. On App Service, we build the app using fairly standard dotnet commands, so usually issues that happen there can be reproed locally when using the same commands.

@clement911 - are you able to reproduce this issue locally (when publishing to a local folder)? There's not much for me to go by since I can't quite reproduce your issue.

So I am quite puzzled by this. I publish a new view this time (new controller, new cshtml file) and I had the same issue.
The controller, which is new, ran and returned the view, but razor failed saying the model type didn't exist.
I deployed again by changing the model to be dynamic (@model dynamic) and the view rendered fine.
Somehow razor is not seeing the model types!
I tried to deploy to a local folder and configure the web site in IIS but all I get so far is "An error occurred while starting the application".

I just noticed that in the web deploy config screen there is a checkbox 'Remove additional files at destination', which is currently unchecked. Should I be checking this box?

I managed to run it locally and it works fine...
But how is this issue even possible? Does razor run in a different context with different loaded assemblies? At this point I have no choice but to type all my view models to dynamic with @model dynamic...

Ok so deploying with 'Remove additional files at destination' fixed the problem!
In the web deploy log I can see the a whole bunch of files were deleted, including a 'NitroCharts\refs\NitroCharts.Web2.exe' so my guess is that this is the one that razor was loading and it was probably old, where the app was loading the most recent one NitroCharts\NitroCharts.Web2.exe
I have no idea what that refs folder is but if someone can she some light that would be appreciated...

The refs folder is the references that are used for compilation by Razor. Basically you are correct, Razor is in a different context. We need to preserve as much information as we can about the compilation environment so that we can compile the views later.

But is the issue I experienced a bug? Why were the 2 dlls out of sync?
I don't understand why Razor needs it own copy.

If you had a mix of content from the refs folder from the current publish and from a previous one this would definitely cause issues. I'd recommend using the Remove additional files at destination option unless you are actually modifying assets on the server (which is kinda crazy).
The ref folder has the facades or reference assemblies from the BCL - these aren't another copy of the dlls, they only have the signatures. The dlls that get loaded when you run your app can be substantially different from what you compiled against (they can be broken up differently or have extra types and members). Using the refs makes the experience consistent between local development and compilation on the server.

To be honest, I didn't really get what you're saying. I guess things became more complicated recently in .net... but thanks for the explanation anyway.
Howver, note that the assembly that caused the issue and was in the ref folder was NOT from the BCL. It was my own project assembly
I don't recall checking 'Remove additional files at destination' off... I'm not sure if the default is on or off but it should probably be on by default...

@clement911 we experience same issue as you describe with refs folder. There was our own EXE from previous release (compiled for net core 1.0) and now when you upgrade to net core 1.1, bin folder has correct version of EXE but refs one has old version of EXE file.
Should we clear 'refs' folder when deploying new version?

@psulek using the Remove additional files at destination option in the VS publish dialog should take care of this. If you're publishing from the cmdline, you can always rm -r the publish directory prior to publishing.

@pranavkm Thanks for suggestion. We added cmd line command to our TFS build process.


Change default branch shown for the repo from master to the current tag that is stable

As apparently we can't do tags ( I could have sworn we could ), we're going to keep anything that is breaking on a develop branch instead.


Could not generate a decorated class for type AppPlugin

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
run flutter app in Android Studio.
Actual results
when I run the flutter app,I got the following errors:
A problem occurred evaluating project ':app'.
> Failed to apply plugin 'com.android.internal.application'.
   > Could not create plugin of type 'AppPlugin'.
      > Could not generate a decorated class for type AppPlugin.
         > com/android/builder/model/v2/ide/ProjectType

Environments:

OS : Windows11
Flutter: 3.10.6-statble
Android Studio: 2022.3.1

Logs

Logs
Caused by: java.lang.NoClassDefFoundError: com/android/builder/model/v2/ide/ProjectType
	at org.gradle.internal.reflect.ClassInspector.inspectClass(ClassInspector.java:70)
	at org.gradle.internal.reflect.ClassInspector.visitGraph(ClassInspector.java:56)
	at org.gradle.internal.reflect.ClassInspector.inspect(ClassInspector.java:36)
	at org.gradle.internal.instantiation.generator.AbstractClassGenerator.inspectType(AbstractClassGenerator.java:274)
	at org.gradle.internal.instantiation.generator.AbstractClassGenerator.generateUnderLock(AbstractClassGenerator.java:214)
	... 319 more
Caused by: java.lang.ClassNotFoundException: com.android.builder.model.v2.ide.ProjectType
	... 324 more

more details
full stacktrace
Flutter Doctor output

Doctor output
[√] Flutter (Channel stable, 3.10.6, on Microsoft Windows [版本 10.0.22621.2070], locale zh-CN)
    • Flutter version 3.10.6 on channel stable at D:\Dev\flutter\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (4 weeks ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at D:\Dev\Android\Sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: D:\Dev\JetBrains\Toolbox\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • CHROME_EXECUTABLE = C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2022.3)
    • Android Studio at D:\Dev\JetBrains\Toolbox\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] Connected device (4 available)
    • M2007J17C (mobile) • 465614e4 • android-arm64  • Android 11 (API 30)
    • Windows (desktop)  • windows  • windows-x64    • Microsoft Windows [版本 10.0.22621.2070]
    • Chrome (web)       • chrome   • web-javascript • Google Chrome 115.0.5790.171
    • Edge (web)         • edge     • web-javascript • Microsoft Edge 115.0.1901.188

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Hi @zygzyg2
Does the issue occur on a newly created Flutter project? Could you share these file contents?

/android/build.gradle
/android/gradle/wrapper/gradle-wrapper.properties
/android/app/build.gradle

This looks like a Gradle issue rather than Flutter issue. Could you check if this issue also happens on a new Android native project as well?

Hi @huycozy
Yes, it is occur on a newly Flutter project.I tried on a native Adroid project,and it happened again. 😔
here's my gradle files:

/android/build.gradle:

buildscript {
    ext.kotlin_version = '1.7.10'
    repositories {
        google()
        mavenCentral()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:7.3.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

allprojects {
    repositories {
        google()
        mavenCentral()
    }
}

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

tasks.register("clean", Delete) {
    delete rootProject.buildDir
}

2./android/gradle/wrapper/gradle-wrapper.properties
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip

3./android/app/build.gradle
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
    localPropertiesFile.withReader('UTF-8') { reader ->
        localProperties.load(reader)
    }
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
    flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
    flutterVersionName = '1.0'
}

apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
    namespace "com.error.flutter_demo"
    compileSdkVersion flutter.compileSdkVersion
    ndkVersion flutter.ndkVersion

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

    defaultConfig {
        // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
        applicationId "com.error.flutter_demo"
        // You can update the following values to match your application needs.
        // For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.
        minSdkVersion flutter.minSdkVersion
        targetSdkVersion flutter.targetSdkVersion
        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
    }

    buildTypes {
        release {
            // TODO: Add your own signing config for the release build.
            // Signing with the debug keys for now, so `flutter run --release` works.
            signingConfig signingConfigs.debug
        }
    }
}

flutter {
    source '../..'
}

Thanks for your response.
You can retry upgrading gradle to newer version to see if it works (8.1 for eg), please see: https://developer.android.com/build/releases/gradle-plugin#android_gradle_plugin_and_android_studio_compatibility. And please also check the compatibility of java version: https://docs.gradle.org/current/userguide/compatibility.html.
You may also get some help if you post it on https://discuss.gradle.org as well.
Since this isn't a Flutter issue, I will close the issue from here.


[python] Fix f-strings variable error

This patch correct create workflow in batch mode I just add in #6659  . I use wrong variable for python f-strings

CI failed but it unrelated to this PR

PTAL @lenboo @CalvinKirs

Codecov Report

Merging #6677 (4961750) into dev (ef9de9d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #6677      +/-   ##
============================================
- Coverage     38.49%   38.48%   -0.01%
+ Complexity     3227     3226       -1
============================================
  Files           646      646
  Lines         25886    25886
  Branches       2808     2808
============================================
- Hits           9964     9963       -1
  Misses        15008    15008
- Partials        914      915       +1

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9de9d...4961750. Read the comment docs.

Thanks


app version #

Is there a way for the SDK to ask "what is the version of the app that I'm in?" and get the version number as it appears in the app store?

The app's version number is now added to the metadata of actions in version 4.1.4


Username and password for default azure setup

So I have now successfully created a default azure kube setup, but I cannot log into https://kube-366aa00.cloudapp.net/api/v1beta1/pods?namespace=default or anything else as it is prompting for a username and password. I have no clue what these default to...
Also, ive imported the azure.pem cert to my login keychain and given it always trust permissions, (im using OSX) but i still get the following error:
x509: certificate signed by unknown authority

Any ideas?

Sweet, after some more code-perusing, I found the .kubernetes-auth file in my local machine's user's $HOME directory.... But what about the cert issues?

Are you trying to log in with your web browser? Have you run kubectl against your cluster to see if it can connect?

i get the
x509: certificate signed by unknown authority
error when i use kubectl

The kubernetes api server uses a self signed certificate, and kubectl should be checking the certificate when connecting to it. If you look at your .kubernetes-auth file, does it reference a certificate file (in addition to containing the username/password)?

nope

If you want to bypass certificate checking in kubectl, you can pass --insecure-skip-tls-verify=true on the command line. This doesn't solve the underlying issue, but will at least allow you to make progress.

By the way, this is the part of the cluster initialization that should be copying the cert files down from the azure VMs: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/azure/util.sh#L439

Right, but i want certs. Whats the missing key for the auth file. My file is thus:
{
  "User": "admin",
  "Password": "illNeverTell"
}

Does ${HOME}.kubecfg.crt exist?

Can you run those ssh commands manually (maybe without redirecting stderr to /dev/null so that you can see if they work properly)?

yep, but its empty

So i manually ssh'd and scp'd the files down and set the values in my auth file. Any clue as to why it failed the first time?

Unfortunately I don't. I'm not very familiar with the azure start up scripts or the reliability of scp'ing files down from VMs (as an aside, all of the provider implementations can fail on the scp step and leave you in this state -- that should definitely be fixed, hopefully by doing something better than scp rather than just wrapping it in retries).

right... well, so far ive got a working instance.... so yay!!!!! ill look into this tomorrow. Thanks for the quick replies!

Sure... feel free to look for help on IRC tomorrow if you get stuck.

What's the url for irc?
On Monday, January 26, 2015, roberthbailey<EMAIL_ADDRESS>wrote:

Sure... feel free to look for help on IRC tomorrow if you get stuck.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/3828#issuecomment-71595422
.

We hang out on the #google-containers channel on freenode.net

Closing for now; please do reopen if there's anything else you'd like us to look into or answer.


Panel notification permissions

At the moment when a user is logged to the main AMP Controller to view all servers they have they receive all notifications as if they were an administrator.
For enterprise purposes, it would be great if a permission to see these notifications would be added, so that only administrator users can see them.

This was implemented some while ago and there is now a separate "View other users tasks" permission.


EKF: Improve in-flight mag error detection, recovery and isolation for fixed wing

This PR improves the handling of in-flight yaw reset and magnetometer error handling   and further develops the functionality introduced by https://github.com/PX4/ecl/pull/294 which was able to recover from yaw errors present at launch/takeoff.
The following functions have been added:
If the EKF rejects GPS data long enough to result in an in-flight reset (which also causes loss of global position validity), then the yaw will be reset to the wind relative GPS course over ground vector.
If two in-flight mag yaw failure and reset events occur, then the mag is declared as unhealthy and magnetometer fusion is halted resulting in a warning message to the console:
"EKF stopping magnetometer use"
and bit position 18 in the filter status message being set to true.
Testing
Testing is ongoing with an initial assessment  performed using replay of the following flight log: http://review.px4.io/plot_app?log=ed369adf-4e46-486a-bc18-14a2ed188bd0 with the magnetometer data rotated in ekf2_main.cpp to simulate a  sensor yaw misalignment.
Testing with a crash log http://review.px4.io/plot_app?log=1c1b7c69-d55c-4f63-a287-85d5be996453 from https://github.com/PX4/Firmware/issues/7609 showed that the changes prevented the GPS rejection being repeated after first in-flight reset and would have enabled the flight to continue given an appropriate failsafe strategy.
velocity innovations just prior to crash - current master

velocity innovations just prior to crash - this PR

Here are a couple more flight logs from today where we intentionally screwed up the magnetometer.
Flight with normal mag orientation, bad mag cal using magnet-https://logs.px4.io/plot_app?log=3f6b5d68-5b03-4825-a0d8-e587dce77269
Flight with wrong mag orientation- https://logs.px4.io/plot_app?log=ca1f903c-8354-4b86-9ee8-910fe206fbc7
@priseborough feel free to use these as test datasets against this PR - they may or maynot be helpful.

@Antiheavy Thanks for that. The vehicle_land_detected message has changed since the version you are using, so I had to remove the maybe_landed filed, but after doing that, bit logs were able to be replayed and triggered the start of flight reset. There is not enough straight line flying in these logs for the bad mag to have enough time to pull the yaw away and cause a second reset.
I was able to exercise the new functionality with replay of http://review.px4.io/plot_app?log=ed369adf-4e46-486a-bc18-14a2ed188bd0 log using this test branch to misalign the mag https://github.com/priseborough/Firmware/tree/ekfReplayTest-wip.
Wiht a 0.5 radian compass misalignment, current ecl master does a yaw reset  on launch, but the misaligned compass pulls the yaw away during the straight legs, resulting in multiple GPS reset events.

With these changes, the  compass is rejected after the second yaw reset event and the flight continues with no further GPS rejection.


Deploy Prometheus

Deploy Prometheus with Helm to monitor the Kafka Cluster and apps.

Follow these docs:
https://docs.confluent.io/current/installation/installing_cp/cp-helm-charts/docs/index.html#monitoring


Basic nix fmt configuration

Motivation
Introduces treefmt-nix and related machinery to enable custom, fast and multi language formatting.
In addition this PR leverages automated creation of Nix actions in GHa to run fast formatting scans.
Changes
Improves the nix config and adds treefmt-nix configuration
Separate PRs exist which run the improved formatter on existing codebase:
Using latest python-black:
https://github.com/DataDog/system-tests/pull/2599
Using shfmt and markdown formatter:
https://github.com/DataDog/system-tests/pull/2602

Could you add this to the unique entry point for formatting : ./format.sh ?

./format.sh --check must not modify any file, and exit with status 1 if any file must be modified
./format.sh should correct files if possible, and exit with status 1 if some file must be modified, and it can't be done automatically

Done - I've modified format.sh to use this stuff.

backported the whitespace checks *and fixes
implemented shellcheck the same way it was done in lint/action.yaml

#cold start which included downloading the dependencies
pawel@pawelthink:~/work/system-tests$ time nix fmt
[INFO ] #alejandra: 3 files processed in 30.67ms
[INFO ] #whitespace: 607 files processed in 74.07ms
[INFO ] #shellcheck: 48 files processed in 874.86ms
[INFO ] #black: 299 files processed in 1.98s
633 files changed in 2s (found 1988, matched 957, cache misses 957)

real	0m16.965s
user	0m29.831s
sys	0m2.962s
pawel@pawelthink:~/work/system-tests$ time nix fmt
warning: Git tree '/home/pawel/work/system-tests' is dirty
0 files changed in 138ms (found 1988, matched 957, cache misses 0)

real	0m1.762s
user	0m1.393s
sys	0m0.371s

pawel@pawelthink:~/work/system-tests$ time nix fmt
warning: Git tree '/home/pawel/work/system-tests' is dirty
0 files changed in 131ms (found 1988, matched 957, cache misses 0)

real	0m0.679s
user	0m0.364s
sys	0m0.217s


Make sure to dispose old params in Adam

Same as we did in Adamax optimizer.

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Short solution needed: "scikit-learn import (usage example)" (python-scikit-learn)

Please help us write most modern and shortest code solution for this issue:
scikit-learn import (usage example) (technology: python-scikit-learn)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

Sklearn usage example (scikit-learn import)


[BUG] Kafka  - Disable debug logging and make this option configurable

Describe the bug
Epiphany delivers Kafka with KAFKA_OPTS=-Djavax.net.debug=all set as default in service configuration
That means debug logging is enabled by default and may impact machine performance (when SSL communication between brokers enabled) - High CPU Usage, generates a lot of logs.
Debug option should be disabled by default and should be configurable in defaults.
To Reproduce

Create Epiphany cluster with Kafka
Configure SSL communication between brokers
See machine utilization

Expected behavior
High CPU usage might be observed
Config files
https://github.com/epiphany-platform/epiphany/blob/develop/core/src/epicli/data/common/ansible/playbooks/roles/kafka/templates/kafka.service.j2
OS (please complete the following information):
any
Cloud Environment (please complete the following information):
any
Additional context
Issue created based on client support request: EP-203.
Should be backported to v. 0.5.x

tested - ok


Support for auto folding non search results...

Hi,
Really great package and useful.
But, it wasn't what I was originally looking for. Maybe you can take this original idea and extended it to your package? I couldn't find any packages to do this.
I simply want to collapse all collapsible portions of a css file at once, so then I can go through that css file and organize it.
Thoughts?

Hi,
I'm not sure I understand what you want.
You already can fold all CSS rules natively (via menu Edit > Folding > Fold All). You need a package to help you organize it?
This package only aims at folding all the search results at once, which was IMO a missing feature, maybe it's an idea for another package.


Convenience names for platform data

This lets you parse traces, using platform data, without having to connect to a target.
from trace import Trace
from libs.utils.platforms import juno # I don't have a juno board here, but I know my trace was collected from one

trace = Trace(juno, 'trace.dat', ['sched_switch'])

Would it be possible to have it generated automatically ? Say, if we give a board name and it isn't in platforms/, we automagically create it for later use. We should be able to get most of the platform data without user interaction.

Yes, I actually copy pasted it from the generated one. I suppose we could automagically do it, but I sort of prefer to know exactly what is in people's source tree, and it isn't very hard to just copy paste it by hand and then add it to the git tree

@bjackman Alright, I agree with you on that. And in any case users can manually do a te.platform_dump() for new platforms.

Just remembered about this, I've pushed a version without the debug noise.

LGTM