gitlab: 16.7.4 -> 16.8.1

Description of changes

https://gitlab.com/gitlab-org/gitlab/-/blob/v16.8.1-ee/CHANGELOG.md

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg eval

NixOS test has finally passed :3

Deployed gitlab-ee on x86_64-linux and seems to be doing fine.

16.8.1 was just released.

Building the NixOS test. If it succeeds, I will hit merge.

Result of nixpkgs-review pr 280837 run on x86_64-linux 1

7 packages built:

gitaly
gitlab
gitlab-ee
gitlab-elasticsearch-indexer
gitlab-pages
gitlab-shell
gitlab-workhorse

I was able to successfully build and install 16.8.1 from b28f41f.  I haven't encountered any issues.

seems like you lost the code that drops the rustc runtime dependency somewhere.
it's basically a copypaste of https://github.com/NixOS/nixpkgs/pull/283982 to gitlab-glfm-markdown.
should I open a new PR for that or do you want to?

Oh, I'm sorry. Probably dropped while squasing everything together by accident. I have opened #285800 to fix that.

no worries. glad I noticed, though. let's maybe try to better keep track of the closure size together, in the future.
thanks again to @yu-re-ka for noticing this initially.


Reporting for ISED

MOU with ISED Section 5.7, 6.7,  7.
Will require user research with ISED team to figure out specific reporting requirements, e.g. cashflow, application status, information sharing, etc.


Tertiary button paddings inconsistent with figma layout.

For Tertiatry button we should use 1px paddings.

It is needed for adequate alignment in layouts. For example:

Usage:
<Button withoutPadding>
  Cancel
</Button>


[HUDI-3530] Update spark bundle version format

Change spark bundle version format from X.Y.Z to X.Y.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Lets wait to resolve the discussion going on in dev thread regarding spark-avro unbundling.


train/val/test cvs files

Hey @aysim,
Thanks for the very nice work.
I am writing to ask if could you kindly provide us the train/val/test CVS files?
I am looking forward to your reply.
Bests

hi：
I really admire your work, can you share the data LIST of CVACT?
best wishes


Support data type string as a returnType argument of UDF

What changes were proposed in this pull request?
Add support for data type string as a return type argument of UserDefinedFunction:
f = udf(lambda x: x, "integer")
 f.returnType

## IntegerType

How was this patch tested?
Existing unit tests, additional unit tests covering new feature.

Test build #72251 has started for PR 16768 at commit 0c851db.

Test build #72251 has finished for PR 16768 at commit 0c851db.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72251/
Test FAILed.

Merged build finished. Test FAILed.


Use s3 head instead of get to retrieve item metadata

Doing container.Item(id) shouldn't send a GetObject request because that actually gets the object bytes and for large objects that might not be the desired behavior.
I changed container.Item(id) to send a HeadObject request instead. It'll still retrieve the same set of properties/metadata it used to.
item.Open() sends a separate Get request anyway to retrieve the io.ReaderCloser which will continue to be the case.

CC @jsteenb2 @Pisush Can you help with the failures? I don't have access to jenkins to see what is failing... and running unit tests in GoLand passes

Dup https://github.com/graymeta/stow/pull/160 ?

Ref: https://github.com/graymeta/stow/issues/181

Will have someone on the team review the PR tomorrow

Thanks @johnmotz!

Maybe today @johnmotz?

hey @EngHabu, thanks for contributing! We have a dependency issue in jenkins that breaking the build. If you can clean up the dependencies we should be good to go once the jenkins build/test pass 👍
dep ensure
Warning: the following project(s) have [[constraint]] stanzas in Gopkg.toml:

  ✗  github.com/Azure/go-autorest

However, these projects are not direct dependencies of the current project:
they are not imported in any .go files, nor are they in the 'required' list in
Gopkg.toml. Dep only applies [[constraint]] rules to direct dependencies, so
these rules will have no effect.

Either import/require packages from these projects so that they become direct
dependencies, or convert each [[constraint]] to an [[override]] to enforce rules
on these projects, if they happen to be transitive dependencies.

grouped write of manifest, lock and vendor: scratch directory /mnt/src/github.com/graymeta/stow/.vendor-new already exists, please remove it
make: *** [deps] Error 1
make: *** [runcontainer] Error 2

💨


Identity as a Bargaining Chip

A suggestion of how to include https://github.com/solid/solid-spec/issues/160 into the Solid spec.
Also included in the test suite criteria suggestions https://github.com/solid/test-suite/blob/master/README.md

The WebID needs to be independent from the data storage i.e. Pod in such a way that it is possible to change Pod provider without needing to change WebID

Any suggestion on how server implementations would implement this in practice? I absolutely agree with the sentiment, but am unsure about the pragmatics of this 🙁

It always comes down to an own domain name, IMHO.

It always comes down to an own domain name, IMHO.

Today.  Soon (relatively, hopefully), some DID system(s) that do not rely on the DNS system will be viable alternative(s).  Of course, this will require some expansion of WebID to permit non-HTTP/S URIs (an expansion which we at OpenLink currently talk about as "NetID").

Good point. DIDs are great there indeed; but then it is a (major) question of what resolvers we want to support.


Viewer should sort checks

Is your feature request related to a problem? Please describe.
The viewer currently displays checks sorted by threat level ("Dangerous", "High", "Medium", "Low"), with all the inconclusive (-1) checks at the bottom. However, the order within each category is seemingly random.
https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard shows the first three High checks as:

Vulnerabilities
Signed-Releases
Token-Permissions

However, for https://securityscorecards.dev/viewer/?uri=github.com/ossf%2Fscorecard-action, the first three High checks are:

Token-Permissions
Binary-Artifacts
Code-Review

Describe the solution you'd like
I'm in favor of sorting by threat level and of moving the inconclusive checks to the bottom. However, checks within a threat category should be displayed alphabetically.

(wrong repo! Posted to scorecard-webapp)


Cannot resolve method 'setBoldFontStyle'

Cannot resolve method(s) used in examples to set custom fonts.
In the docs( here & here) you have given examples to set custom fonts but these methods are not found in the AppviralityAPI class.
AppviralityAPI.setBoldFontStyle()
AppviralityAPI.setNormalFontStyle()
Where to find a use these methods.

Please share your App key and drop an email with your account username and your app name to cs[at]appvirality.com


Deployment with Kubernetes

I am not sure yet if I can deploy a model for prediction using the optimized TensorFlow runtime(TFRT) even though the doc says it is almost identical to TFServing in the perspective of technical setups.
What I am not sure is that if the optimized TFRT is only supported in Vertex AI. Maybe need to experiment, or if you @sayakpaul have found any documents for this, please let me know.

I don't think the Kubernetes way of deployment would support it.


Mock all available location providers

Currently mocking locations is quite unstable. Only the gps provider over LocationManager is mocked. Real location updates on other providers are still delivered.
This implementation mocks all available providers of the LocationManager (except the passive provider since this is not needed), as well as the FusedLocationProvider of google play services.
It also sends regular updates once a mock location is set to trigger location updates.

Thanks!


Extend user interface for customization

Currently, customization of the extraction is very limited in SlicerRadiomics. Moreover, Yaml parsing using PyYaml doesn't work currently on windows (see #23), which means SlicerRadiomics cannot use the parameterfile.
This issue is created to make a list of GUI elements that should be made to expose the most important customization features of PyRadiomics.
Current suggestions:

Resampling
Image normalization
Filters (including Sigma values for LoG filter)

cc @Radiomics/developers

Also need to add wavelets, see this post from a confused user ...

Fixed by #36


antlr2: desc & test added

Unfortunately I can’t test locally because I’m over 3G and Antlr2 is too big.


SQL Table Mysteriously Deletes Rows

I just got a message that this issue was closed because it is about VS Code. That is INCORRECT. This is about a Codespace for Wilmington University for a class on MySQL. Can someone please look into how an entire table was mysteriously deleted/dropped?
When preforming simple quries on the KimTay Databases' SALES_ REP table it does not return row values. The query SELECT REP_ID FROM SALES_REP; only returns the column header REP_ID. And, SELECT * FROM SALES_REP; only returns all Column headers. This one table will not return the row values. I did not DROP or DELETE any data from this table.
I resolved the issue by inserting all of the data for the table. The college has no explanation. How were these rows deleted from this table? Who has control of this database? Someone please look into how an entire table could be effected.
Version: 1.88.1
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
Embedder: codespaces

Please contact the course support channel.

Related - #210522

Please understand that you are using the Web browser variant of VS Code when you interact with the GitHub Codespace that your college provides you. The "Report Issue" option creates issues (tickets) on the GH repository for VS Code.
I think your course support people should be using other channels.
For more context please see https://docs.github.com/en/codespaces/troubleshooting


added background and link color to dropdown in side nav

added background color, border radius, and text color to theme.css file

Thanks @jrya7 ! This fixes the issue with text being invisible in some browsers.


Documentation: Write a blog post to share how we used Zebra and s-nomp to mine on testnet

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn

Waiting on docker image fixes to publish but the blog post itself is done


Bundle caching [wip]

 Use Docker to deploy manage-courses-frontend

The disadvantage to using this method is that we have to mount separate volumes to store the dependencies on. This means we would need to create separate docker containers for said deps, push them separately and then stitch them back using docker compose when we deploy.
I'd like to investigate caching the actual docker layers on a separate branch/PR.

closing in favour of the approach in #29


scheduler: Make fenzo bin packing behavior configurable & pluggable.

@shamsimam  Comments incorporated... I actually found out that type hints aren't enough to ensure that a var implements a specific interface in clojure.  You need to manually check if you want an exception to be thrown in that situation.  I also rebased off of new master to eliminate the conflicts.

This LGTM. @shamsimam, any additional comments?

LGTM.


Some links in a codelab redirect to internal Google sites

Many links from this codelab redirect to https://devsite.googleplex.com which is unreadable to people outside Google.

In 2019, the first step fails due to CORS:
index.html:1 Access to XMLHttpRequest at 'https://www.google.com/finance/historical?q=MSFT&authuser=0&output=csv' from origin 'http://localhost:8000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
The link returns this in the browser:
We're sorry...
... but your computer or network may be sending automated queries. To protect our users, we can't process your request right now.


Gist : Typescript declaration

Hi,
First, thank you for your work.
I created a Typescript declaration because I love Typescript and I needed Admin on Rest, so here is the declaration file : https://gist.github.com/pierre-H/5e61fdeb6e918a2108ab968a16ce4049 .
If you could add it to the official repository it would be great !
There are interfaces which are useless for end user and are helpful for declarations and I don't know how to make them private.
I am still testing it but I think it's complete.

Hi Pierre,
And thanks for your contribution!
We're not users of TypeScript, so we can't add it to the repo because it would get out of date pretty quickly. I don't know if parsers have the option to accept a path for declarations, in which case you could publish these types in a third-party repository?

https://github.com/typings/typings ?

See https://github.com/marmelab/react-admin/issues/1617#issuecomment-595791317


Handling plan/destroy within tests scenarios

When the terraform under test implements life_cycle blocks with prevent_destroy set to true or a module used does the same, the use of plan or destroy after a successful plan/apply will always fail due to these settings resulting in resource being left in place.
While this would override the expected behavior, when testing modules or code intended for production that uses these blocks in a test scenario it causes issues.
I'll put a PR together with a proposed solution to allow a work around.

Fixed in #43


Auto-release new pushes with GitHub Actions

📒 Description
This modifies our GitHub Actions workflow so it doesn't run when a new branch gets created. It also automatically tags and releases everything resulting from a push event on the master branch (that means all commit batches - not individual commits and PRs).
IMPORTANT @IndrekV, For this to work, we need to add the TAGGING_SECRET variable to the Secrets section in the repo settings. It should be a GitHub API token with the rights to modify the repository. I can provide mine, but I think it'll be safer if we use yours. You can generate one in the Settings of your own GitHub profile.
🕶 Types of changes

New feature (non-breaking change which adds functionality)

🔎 Review hints
You can see the results from this in my fork.

https://github.com/MartinBriza/toggldesktop/commit/909ee72a31779918e79393a16e43a6e1f38d0ccc/checks?check_suite_id=286641112 Last build result from this is here

https://github.com/MartinBriza/toggldesktop/commit/909ee72a31779918e79393a16e43a6e1f38d0ccc/checks?check_suite_id=286677178 And after tagging, a release build gets triggered

https://github.com/MartinBriza/toggldesktop/releases/tag/v7.5.16
And finally, this is the release, it should contain Linux and Windows binaries when it finishes.

Tagging secret added.


More caching work, be explicit about paths, use ccache in cibuildwheel

As per title, more work to ensure Linux builds in particular are properly caching vcpkg and ccache artifacts.

Seems to be doing the trick but I'm already anticipating some more caching PRs 😅


Fix Unstable Black Hole gain stuck at 0

When Exotic Atoms aren't unlocked, exoticAEff returns default value 1  -- not an array. Added check to handle this case.

here i put in script!


Potential data race with localNode in NodeDiscovery

As pointed out by Louis, there is a potential data race with the NodeDiscovery module. It protects local node updates via the following mutex:
https://github.com/cilium/cilium/blob/47e936e10996cf79656fb1d6bedbb25c490473b6/pkg/nodediscovery/nodediscovery.go#L650-L658
But the getters of the localNode object are not aware of the lock, and therefore could concurrently read the fields while they are getting updated.
https://github.com/cilium/cilium/blob/b4b750002c229d559aa83b80f7aca30a8084a0bb/pkg/node/types/node.go#L439-L448
To my knowledge, the n.localNode reference is not stored by any consumer at the moment, so I don't think the race can happen in practise at the moment. This is because the lock is held during the call to n.Manager.NodeUpdated(n.localNode) where all the data access happens via getters happens.
But regardless, we should still fix this, for example by creating a copy of the local node object, to ensure that any future consumers will not introduce a data race by accident.

LocalAllocCIDRsUpdated has been removed from the tree. This particular data race here is no longer present. https://github.com/cilium/cilium/issues/21085 looks like it remains though.


Fix a crash when comparing differently sized images

This fixes #14

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Conditions addition to insert_row

Conditions the addition to insert_row within create_historical_record_m2ms in order to respect excluded_field_kwargs via self.field_excluded_kwargs.
This change necessarily undoes the addition of through_model_field_names = [f.name for f in through_model._meta.fields] which is not compatible with the api of self.field_excluded_kwargs.

Description
See #1358
Related Issue
#1358
Motivation and Context
#1358
How Has This Been Tested?
Yes, I run it in prod.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have run the pre-commit run command to format and lint.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have added my name and/or github handle to AUTHORS.rst
[ ] I have added my change to CHANGES.rst
[ ] All new and existing tests passed.

@ddabble FYI


[typespec-python] Cant generate protocol methods

I need to generate an SDK with only the protocol methods, I tried two methods described below but both cases failed to generate the expected result:

Add @protocolAPI over the operations in client.tsp

    @protocolAPI
    ListEnvironments is DevCenter.EnvironmentsOperations.ListEnvironments;

Add @convenientAPI with value false over the operations in client.tsp

    @convenientAPI(false)
    ListEnvironments is DevCenter.EnvironmentsOperations.ListEnvironments;

The SDK is still outputted with models

We currently don't do anything with convenient api, this is something we should look into though

Closing, no plan to support that right now


Update footer

Figma link:

@luciaaaaaaa can you add the Figma link? Thanks!

Hi -- I think we might want to update this to match the overall marketing site.


Improve app name and system permission message localization.

Add localizable string (Dictionary<Lang Code, String>) property editor (based on Dictionary editor)  and property hint.
Add localized "app name" property to the project settings.
Add localized permission and copyright properties to the macOS and iOS export settings.
Remove some duplicated ("app name") and deprecated ("info") macOS and iOS export properties.

Thanks!


Hugging face notebook fail

The hf_interactive notebook (train_fn.remote()) failed with the following message:
ImportError: Datasets requires pyarrow >= 6.0.1, < 7.0.0, but 12.0.1 is installed. Reinstall with `pip install -U "pyarrow<7.0.0"`. If you want to disable this pyarrow version check, set the environment variable RAY_DISABLE_PYARROW_VERSION_CHECK=1.

Edited:
Got it to pass the failure with
runtime_env = {"pip": ["transformers", "datasets", "evaluate","pyarrow<7.0.0","transformers[torch]"]}
but I don't think I can get away with no gpu.
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx

Completed as per @MichaelClifford

This error happened when the runtime_env was set incorrectly in the notebook. This has been addressed in #163 and should no longer be an issue


[typescript-react-query] useQuery Expected 1-2 arguments, but got 3. ts(2554)

Which packages are impacted by your issue?
@graphql-codegen/typescript-react-query
Describe the bug
After upgrading TanStack Query from version 4.29.7 to 5.7, and upgrading the graphql-codegen libraries to the latest versions as well, my generated file does not conform to the latest changes in RQ v5 regarding the arguments to useQuery. As a result, TypeScript is complaining about each instance of useQuery with Expected 1-2 arguments, but got 3. ts(2554).
Your Example Website or App
https://codesandbox.io/p/sandbox/adoring-moon-qthwf8
Steps to Reproduce the Bug or Issue

Go to the CodeSandbox provided
Run yarn generate
Open the generated types.ts file
Notice the TypeScript error on line 75

Expected behavior
The generated file should conform to TanStack Query's latest changes and not contain any TypeScript errors.
Screenshots or Videos
No response
Platform

OS: macOS
NodeJS: 18.8.0
graphql version: 16.2
"@graphql-codegen/add": "^5.0.0",
"@graphql-codegen/cli": "^5.0.0",
"@graphql-codegen/typescript": "^4.0.1",
"@graphql-codegen/typescript-graphql-request": "^6.0.1",
"@graphql-codegen/typescript-operations": "^4.0.1",
"@graphql-codegen/typescript-react-query": "^6.0.0",
"@tanstack/react-query": "^5.7.0",
"graphql": "^16.2.0",
"graphql-request": "5.1.0" // using 5.1.0 here because of a different issue caused by 6.1.0

Codegen Config File
import { CodegenConfig } from "@graphql-codegen/cli";
const config: CodegenConfig = {
schema: "schema.graphql",
documents: "document.graphql",
generates: {
"types.ts": {
plugins: [
"typescript",
"typescript-operations",
"typescript-react-query",
],
config: {
fetcher: "graphql-request",
exposeDocument: true,
exposeQueryKeys: true,
exposeFetcher: true,
addInfiniteQuery: true,
},
},
},
};
export default config;
Additional context
No response

This ended up being my bad. I didn't include the new reactQueryVersion field in my config.ts. Adding that and setting it to 5 fixed this. However, I didn't see any documentation about this new parameter. It took reading through the PR to discover this.

Thank you for this. Had the same issue.


define slog.Logger interface and add zerolog, zap, and logrus adaptor skeletons

this represents what I understood we wanted to the slog.Logger interface and adds the needed skeleton methods to allow the subprojects to build

fixed a typo.

@karasz thoughts?


fixed close.svg and placed it inline to prevent asset issue

Fixes #281

Thanks, merged and a the v4.4.3 will be available shortly


Bug: Resampling not working when using xaxis type='date'

To improve performance I would like to use epoch timestamp in ms as x axis data, but show date in string format.
When I use the parameter type="date" it breaks the resampler I can no longer zoom in the chart
Code to reproduce :
import pandas as pd
import plotly.graph_objs as go
from plotly_resampler import FigureResampler
import random
import datetime

# Generate data
count = 100000
df = pd.DataFrame({
    'dt': pd.date_range(start='2021-01-01', periods=count, freq='S'),
})
df['value'] = df['dt'].apply(lambda x: random.randint(1, 100))
df['timestamp'] = (df['dt'] - datetime.datetime(1970, 1, 1)) // datetime.timedelta(milliseconds=1)

fig = FigureResampler(go.Figure())

fig.add_trace(go.Scatter(x = df['timestamp'], y = df['value'], mode = 'lines'))

fig.update_xaxes(type="date")
fig.show_dash(mode='inline')

Hey @Jeremy38100,
Thx for submitting this issue together with the reproducible code! :+1:
I am able to reproduce this bug on my machine - I narrowed the underlying issue down to plotly-resampler internally using a stateful version of the xaxes type (but as you change this to type "date" - the internal value does not get changed & thus remains "linear" instead of "date")
I hope to solve this bug in the near future :)


Another implementation of image mask generator

Hi,
I would like to propose another type of image mask generator.
I'm aware of this and of 'Example of transforming images and masks together', so I tried to mix both functions (transform image and mask, provide a pipeline of transformations).
Glad to hear any feedback on this proposition and the code.

Can you explain at a high level what you're trying to accomplish with this and why? What are the advantages, drawbacks, etc...

Idea is to give more flexibility to image data generator and cover the case of image/mask augmentation (even it can be done by zipping two Keras ImageDataGenerators). Typical usage is :
def xy_provider(image_ids, infinite=True):
        while True:
            for image_id in image_ids:
                image = load_image(image_id)
                target = load_target(image_id)

                # Some custom preprocesssing: resize
                # ...
                yield image, target
            if not infinite:
                return

train_gen = ImageDataGenerator(pipeline=('random_transform', 'standardize'),
                             featurewise_center=True,
                             featurewise_std_normalization=True,
                             rotation_range=90.,
                             width_shift_range=0.15, height_shift_range=0.15,
                             shear_range=3.14/6.0,
                             zoom_range=0.25,
                             channel_shift_range=0.1,
                             horizontal_flip=True,
                             vertical_flip=True)

train_gen.fit(xy_provider(train_image_ids, infinite=False),
            len(train_image_ids),
            augment=True,
            save_to_dir=GENERATED_DATA,
            batch_size=4,
            verbose=1)

val_gen = ImageDataGenerator(featurewise_center=True,
                                 featurewise_std_normalization=True) # Just an infinite image/mask generator

val_gen.mean = train_gen.mean
val_gen.std = train_gen.std
val_gen.principal_components = train_gen.principal_components

history = model.fit_generator(
        train_gen.flow(xy_provider(train_image_ids), # Infinite generator is used
                       len(train_id_type_list),
                       batch_size=batch_size),
        samples_per_epoch=samples_per_epoch,
        nb_epoch=nb_epochs,
        validation_data=val_gen.flow(xy_provider(val_image_ids), # Infinite generator is used
                       len(val_image_ids),
                       batch_size=batch_size),
        nb_val_samples=nb_val_samples)

Advantages:

User decides how to get images with xy_provider and benefits of random transformations provided by Keras.
User can manage the pipeline of random transformations and add some custom functions (of certain signature) to randomly augment data.
ImageMaskGenerator similarly transforms image and mask (useful for a segmentation task).

Drawbacks:

Need to write some code before it works
Some parts of implementation code are just copied and adapted from keras.preprocessing.image

See also this example

I've got two proposals that I think are related to this in upstream keras, comments would be appreciated:
https://github.com/fchollet/keras/issues/6538#issuecomment-302835861
https://github.com/fchollet/keras/issues/6655


Maybe implementation, magic null value

Wouldn't it be better if Maybe was implemented the same way as Either:
With a generic Maybe interface and 2 specialisations Just and Nothing.
That way we could deal with the actual null value as a real value (which it is).
Thoughts?

Very good point. I'll implement something like this.

@zerkms PR is ready. Could you review it?

Sure, will do that today

@widmogrod it looks great (but I'm not advanced in theory category)
PS: I've left one comment though

@zerkms me neither :)
Thanks for review. I removed duplicated test.
If you are interested in this topic, here is great book (very short and concise): https://www.gitbook.com/book/drboolean/mostly-adequate-guide/details

@widmogrod thanks :-) I've read it and I'm following that repository changes :-)


Add method for setting the alpha component of a color

With this PR users can easily modify the alpha value of a color:
square(fill: teal.with-alpha(50%))

Aren't the other similar functions relative instead of absolute?

Aren't the other similar functions relative instead of absolute?

This inconsistency also concerns me a bit.

Aren't the other similar functions relative instead of absolute?

This inconsistency also concerns me a bit.

But is setting relative alpha useful? I think the name with- implies that the function sets an absolute value.

Aren't the other similar functions relative instead of absolute?

This inconsistency also concerns me a bit.

But is setting relative alpha useful? I think the name with- implies that the function sets an absolute value.

It's definitely useful if the color already has some alpha-value. Sure the name "with-" indicates absolute, but that name isn't set in stone?

Aren't the other similar functions relative instead of absolute?

This inconsistency also concerns me a bit.

But is setting relative alpha useful? I think the name with- implies that the function sets an absolute value.

It's definitely useful if the color already has some alpha-value. Sure the name "with-" indicates absolute, but that name isn't set in stone?

Then we should have both. with-alpha and opacify?

I think setting the alpha value is very much a useful operation in any case, especially if you have an existing color that you just want to set to some specific transparency.
Nevertheless, I also see how relative operations on opacity can be of use.
There are multiple ways of performing relative operations on opacity:

Multiplication would be useful if you want to take colors and make them less opaque, but still visible. For instance, imagine applying an filter to "translucify"/"transparentize" an element.
Note: https://github.com/typst/typst/issues/2049 is one alternate and more generic way of solving this.
I'm afraid I can't think of a good method name here.

Addition appears to be the most popular "opacify" operation when searching through GitHub.
Most of these uses seem to basically be with-alpha, but IMO less clear (as in readable).
Sometimes it is used for fade-in/out animations.
For Typst, the most useful operations appear to be gradients from one opacity to another.

Alternatively, one could do what the de-/saturate operation does: alpha = alpha ± (100% - alpha) * factor. I'm not sure this is useful here, but I wanted to mention it anyway.

I'm closing this for now. We first need to figure out the design on Discord.


ts-web: reflect updates

fixes #822 #922

maintaining the list of types from transaction method bodies is too much work, so let's read from the registered methods list. but unfortunately it's unexported, so it's some kind of ugly go:linkname thing that I found out the idea of online

adding manual client updates too

adding manual module updates too


optimize: add error definition ErrInstanceNotFound which is used in service discovery module

Define instance not found error.
For kinds of registries in kitex-contrib.

@horizonzy Consider using "no instance available" to avoid ambiguity?

It's indeed better.


Add Karmachain network

Hey @HolyGrease, Could you please contact me on Element? Thanks in advance!


Anyone have a simple Buy/Sell % Strategy?

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[ ] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
INSTALLED GEKKO
Expected result (what you hoped would happen)
TRADE VERY SIMPLY
Actual result (unexpected outcome)
GREAT PROGRAM....BUT I CANT FIND A SIMPLE BUY/SELL STRATEGY
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
I JUST WANT TO BUY AT 90% OF CURRENT PRICE, SELL FOR 5% PROFIT...
SIMPLE ENOUGH....BUT I CAN'T SEEM TO DO IT.  WHAT AM I DOING WRONG?

I think you would need to create your own strategy. Gekko doesn't really come with any strategies that are ready to use out-of-the-box, you have to write your own or find ones that others have written and figure out how to get them working. A couple pieces of advice:

Use lowercase. Your use of caps lock may have had something to do with your question going 11 days without an answer.
Check out the simple example strategy here:  which could be modified to suit your description.
Consider asking these sorts of questions in the Strategy Development board at

This is indeed the bugtracker! With those links you should be good.


Added line chart web component

Added line chart web component
Changed statVarDcid to variableDcid
Updated draw functions to accept a DOM element rather than ID because document.getElementById doesn't work when selecting in the shadow dom
Changed web component mount elements from span to div - having them as block level elements seems more natural to me

Screenshot:

New updates:

Renamed placeDcid attribute to place
Renamed variableDcid attribute to variable

i still don't love enclosedPlaceTypes - maybe childPlaceTypes would be better? any opinions?

childPlaceTypes

I feel childPlaceTypes is better too.

childPlaceTypes

I feel childPlaceTypes is better too.

+1.
I quickly looked over our other APIs.  It seems we largely call it just placeType, and in the description say "child" or "contained".  I like childPlaceType over placeType, since it is a bit more self-documenting.

Renamed enclosedPlaceType to childPlaceType


translate of TraceSystem clock during effect translation used in para…

…llel typeclass caused realtime clock to be treated as monotonic.

Reference to #75

going to merge so I can cut an updated rev for @LiuVII


Added support for Crystal language

What does this implement/fix? Explain your changes.
Added support for Crystal language
http://crystal-lang.org/
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.

[ ] Merged with latest master branch
[ ] Added examples for testing to examples/ directory
[ ] Travis CI passes (Mac support)
[ ] AppVeyor passes (Windows support)

Looking great! Please merge the latest changes in the master branch and once Travis CI tests are passing I can merge this. Thanks!

So the tests are failing because the test file is detected as Ruby instead of Crystal.
I have installed the Crystal language package: https://atom.io/packages/language-crystal-actual
And users who are having this problem -- Ruby is detected instead -- then you can use the grammar selector and change to Crystal and use this beautifier.
Thanks @petrui for contributing!

Published to v0.29.3


Error: Failed to collect page data for /404

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Clone github.com/oceanprotocol/market repo
npm i
npm start

Expected
Should see the local instance of Ocean Marketplace
Actual
The following error
wait  - compiling /404 (client and server)...
event - compiled client and server successfully in 679 ms (1923 modules)
error - unhandledRejection: TypeError: Cannot set property Request of # which has only a getter
at /home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:529:18
at /home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:542:5
at /home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:3:3
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:4:3)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3-providers-http/lib/index.js:31:1)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3-core-requestmanager/lib/index.js:45:19)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3-core/lib/index.js:22:24)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3/lib/index.js:29:12)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/@oceanprotocol/lib/dist/lib.js:1:124)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object.@oceanprotocol/lib (/home/ec2-user/ocean/ocean-market/.next/server/pages/_app.js:2010:18)
at webpack_require (/home/ec2-user/ocean/ocean-market/.next/server/webpack-runtime.js:33:42)
at eval (webpack-internal:///./src/components/@shared/FormInput/InputElement/Provider/index.tsx:17:76)
at Function.webpack_require.a (/home/ec2-user/ocean/ocean-market/.next/server/webpack-runtime.js:97:13)
at eval (webpack-internal:///./src/components/@shared/FormInput/InputElement/Provider/index.tsx:1:21)
error - unhandledRejection: TypeError: Cannot set property Request of # which has only a getter
at /home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:529:18
at /home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:542:5
at /home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:3:3
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/abortcontroller-polyfill/dist/polyfill-patch-fetch.js:4:3)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3-providers-http/lib/index.js:31:1)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3-core-requestmanager/lib/index.js:45:19)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3-core/lib/index.js:22:24)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/web3/lib/index.js:29:12)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/home/ec2-user/ocean/ocean-market/node_modules/@oceanprotocol/lib/dist/lib.js:1:124)
at Module._compile (node:internal/modules/cjs/loader:1155:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
at Module.load (node:internal/modules/cjs/loader:1033:32)
at Function.Module._load (node:internal/modules/cjs/loader:868:12)
at Module.require (node:internal/modules/cjs/loader:1057:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object.@oceanprotocol/lib (/home/ec2-user/ocean/ocean-market/.next/server/pages/_app.js:2010:18)
at webpack_require (/home/ec2-user/ocean/ocean-market/.next/server/webpack-runtime.js:33:42)
at eval (webpack-internal:///./src/@utils/ocean.ts:6:76)
at<EMAIL_ADDRESS>(/home/ec2-user/ocean/ocean-market/.next/server/pages/_app.js:1276:1)
at webpack_require (/home/ec2-user/ocean/ocean-market/.next/server/webpack-runtime.js:33:42)

are you using Node.js v18 or some older version?

Yeah, this look like it has been caused by using the wrong version of node.js

Looks like it was related to the node version itself. Thanks !!


Alter filter replace strings with func

add functions FilterStringsWith and ReplaceStringsWith in package basicalter

Codecov Report

Merging #2 (369509a) into main (4299892) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           99       107    +8
=========================================
+ Hits            99       107    +8

Impacted Files
Coverage Δ

basicalter/slice.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4299892...369509a. Read the comment docs.


Quieter directory command

According to the README, the directory command (d) can be used as a replacement for cd.
I would like to try that, but I would like it to be a bit quieter similar to cd. I don't want it to announce what directory I am going to. This is in line with the Unix philosophy of avoiding cluttering output with extraneous information.
I do see benefit in announcing what directory it will change to when an alias is given. This follows the principle of least astonishment, because it might even be ambiguous sometimes what my intentions are, if for instance there is a directory with the same name as my directory alias in the cwd.
So I would like it to not print the directory when using it like cd in the normal way (not going to a tagged directory) and only print the directory name when going to a tag.
Otherwise, I would like a --quiet flag that could disable the output entirely when changing directories.
Thanks.

Hi acrisci,
Good point. Instead of a --quiet flag, however, I will disable the announcement by default and add a flag --verbose which will then display the full path.
Thanks,
Jay

Hi again,
I've removed the Going to message completely. As for the principle of least astonishment, I've decided to instead clearly specify in the technical notes section in the README that if there is a name conflict, the tag is preferred over the subdirectory (and that you can put / at the end of the subdirectory name if you want to go to it).
Thanks for your input.
Jay

:+1:


Unity 2019.3.0f3 Unable to register IMixedRealityInputDeviceManager on HL2

Describe the bug
When I upgrade our 2019.2 project to 2019.3 and build for HoloLens 2 I do not get any gesture/hand input.
To reproduce
Steps to reproduce the behavior:

Take a working 2019.2 project using articulated hands
Upgrade to 2019.3
Build ARM for HL2 with the usual settings
Deploy to HL2 and start the app
Only gaze pointer available, no reaction to hands or gestures

Expected behavior
It works as for 2019.2.
Your setup (please complete the following information)

Unity Version 2019.3.0f3
MRTK Version 2.1

Target platform (please complete the following information)

HoloLens 2

Additional context
Unity log has a few of these:
"Unable to register IMixedRealityInputDeviceManager service with a null concrete type"
I have tried re-creating MRTK configuration settings, and using the default settings, with no luck.
I have tried using both old and new Unity XR SDK systems.
There is so many nice new features in 2019.3 I hope you at MRTK don't take too long to support it.

I have tried using both old and new Unity XR SDK systems.

Work for the new XR SDK system is ongoing and will ship in MRTK 2.3.
As far as the old system not working, that's strange. Can you check your input system data providers in your profiles to see if any types are highlighting red? That's typically what

"Unable to register IMixedRealityInputDeviceManager service with a null concrete type"
is referring to. You should be able to click Repair to try repairing them, if you aren't using the default profiles.

I think you may close this. I can't remember this now, but we do have a project working. It may be that some combination of deleting Unity cache, resetting the profiles or upgrading to MRTK 2.2. solved it.

I'm having the exact same problem in Unity 2019.4.0 on the HoloLens 2 with MRTK 2.4, using the old XR system.


feat: add Byleth as a character

Thanks! Started work on this before Byleth was out and I forgot to add them ;)

No problem! Thanks for merging it in so quickly!


Alternative dependency strategies

Some developers prefer to include their dependencies as submodules in their repo instead of depending on system wide installation of the deps.
It may be helpful to build an extism cpp cmake package as an alternative to pkg-config.

Instructions/Setup for using the cpp-sdk and extism as submodules
CMake package that can found with find_package
https://www.acarg.ch/posts/cmake-deps/

https://github.com/extism/cpp-sdk/pull/10 resolves this


Update to latest gulp-zip and workaround linux issues.

Merge #4705 first.
This updates to the latest gulp-zip and uses gulp-tap to work around issues described in #3531.
With this and #4707, all of our npm dependencies will be on their latest versions.

Looks good on Mac.  I'm sure @mramato tested on Windows.

Please update CHANGES.md in master if any of these npm updates warrant it.


Build Error. Many patches failed

I followed the official guide but failed with error below. This actually also happened to zlib and glib
which I fixed by applying patches manually. But that's too boring to do it for about 30 libs.
Ubuntu 14.04; git 2.6.2
BTW: My main goal is to stream audio (only!) from Chrome to Raspberry Pi (there is no camera device on RPi). Could someone tell me if I'm going the right way of if this is possible to implement with openwebrtc at all?
[(5/37) bzip2 -> extract ]
-----> Extracting tarball to /home/eugene/cerbero/sources/linux_x86_64/bzip2-1.0.6
Unpacking /home/eugene/cerbero/sources/local/bzip2-1.0.6/bzip2-1.0.6.tar.gz in /home/eugene/cerbero/sources/linux_x86_64
Initialized empty Git repository in /home/eugene/cerbero/sources/linux_x86_64/bzip2-1.0.6/.git/
fatal: CRLF would be replaced by LF in dlltest.c.
Applying: Fix Makefiles and add support for Windows and OS X
.git/rebase-apply/patch:128: trailing whitespace.
This Makefile builds a shared version of the library,
.git/rebase-apply/patch:130: trailing whitespace.
at least on x86-Linux (RedHat 7.2),
.git/rebase-apply/patch:131: trailing whitespace.
with gcc-2.96 20000731 (Red Hat Linux 7.1 2.96-98).
.git/rebase-apply/patch:132: trailing whitespace.
Please see the README file for some important info
.git/rebase-apply/patch:142: trailing whitespace.
Please read the WARNING, DISCLAIMER and PATENTS sections in the
error: Makefile: does not exist in index
error: Makefile-libbz2_so: does not exist in index
error: bzip2.c: does not exist in index
Patch failed at 0001 Fix Makefiles and add support for Windows and OS X
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Running command 'rm -rf /home/eugene/cerbero/sources/linux_x86_64/bzip2-1.0.6'
Running command 'mkdir -p /home/eugene/cerbero/sources/linux_x86_64/bzip2-1.0.6'
Running command 'git init'
Running command 'git add --force -A .'
Running command 'git am --ignore-whitespace /home/eugene/cerbero/recipes/bzip2/0001-Fix-Makefiles-and-add-support-for-Windows-and-OS-X.patch'
Recipe 'bzip2' failed at the build step 'extract'

@sdroege any ideas?

Yes, complain to your OS' manufacturer and switch to something usable. That's the problem here that you can see from the screenshot: https://twitter.com/kern/status/657994294029103104

Actually wrong bug, sorry! Can you upload the /home/eugene/cerbero/sources/local/bzip2-1.0.6/bzip2-1.0.6.tar.gz somewhere?

I'm sure the problem is not in the sources tarball but in the build environment.
I can't upload bzip2 now as I deleted the folder. But the same error happens to zlib. I tried to do a fresh build from scratch with the result below.
At first building attempt I got the same problem. I unpacked zlib, applied pathes manually then packed it back and removed patches from recipe. That allowed build to go one step further. Then I did the same for glib etc... At the bzip2 stage I gave up:)
zlib tarball:
https://www.dropbox.com/sh/ybzwxcl8l5o42rz/AABVL3Zk9LevtGUQFiIwBFAYa?dl=0
[(10/14) zlib -> fetch ]
-----> Fetching tarball http://zlib.net/zlib-1.2.8.tar.xz to /home/eugene/cerbero/sources/local/zlib-1.2.8/zlib-1.2.8.tar.xz
[(10/14) zlib -> extract ]
-----> Extracting tarball to /home/eugene/cerbero/sources/build-tools/zlib-1.2.8
Unpacking /home/eugene/cerbero/sources/local/zlib-1.2.8/zlib-1.2.8.tar.xz in /home/eugene/cerbero/sources/build-tools
Initialized empty Git repository in /home/eugene/cerbero/sources/build-tools/zlib-1.2.8/.git/
fatal: CRLF would be replaced by LF in contrib/dotzlib/DotZLib.build.
Applying: win32: fix dll name
error: win32/Makefile.gcc: does not exist in index
Patch failed at 0001 win32: fix dll name
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Running command 'tar -Jxf /home/eugene/cerbero/sources/local/zlib-1.2.8/zlib-1.2.8.tar.xz'
Running command 'mkdir -p /home/eugene/cerbero/sources/build-tools/zlib-1.2.8'
Running command 'git init'
Running command 'git add --force -A .'
Running command 'git am --ignore-whitespace /home/eugene/cerbero/recipes/zlib/0001-win32-fix-dll-name.patch'
Recipe 'zlib' failed at the build step 'extract'
Select an action to proceed:
[0] Enter the shell
[1] Rebuild the recipe from scratch
[2] Rebuild starting from the failed step
[3] Skip recipe
[4] Abort

Ah this might be relevant:  fatal: CRLF would be replaced by LF in contrib/dotzlib/DotZLib.build.
This sounds like something is wrong in your environment with line-endings. Maybe cerbero was checked out with Windows line-endings or something like that. Or in the global GIT config.
Did you configure core.autocrlf at some point in GIT? What's the output of "git config --get core.autocrlf" from inside the cerbero GIT repository?

It was "input". I set autocrlf=false and it's built fine. Thank you much!


Coding Style: Author, License, meta information in files

As a developer, I need some guidelines how while-true-do.io can be represented in script headers, meta files, readmes, etc. At least the following information should be addressed:

author
description
company
license
humans.txt

Bash could look like this:
#!/usr/bin/env bash
#
# name          : <name>
# author         : while-true-do.io
# description  : This script ...
# company     : while-true-do.io
# license        : BSD-3-Clause
# =============================================================================

ansible/meta/main.yml could look like
galaxy_info:
  role_name: <name>
  author: while-true-do.io
  description: This role ...
  company: while-true-do.io
  license: BSD-3-Clause

As you can see, some information are similar and we need to align the inormation there.

I think, I have a solution to address this topic and will work on it. It is quite similar to RedHats Guidelines.

Each file
Gratitude our contributors should be mandatory and therefore we should add some content to each file. This will:

lower the barrier of contact
remind our work to others
protect our work a little better

guideline

Each file should contain the below information
meta files like package.json, .travis.json, meta/main.yml only need to USE the same information, but not add stuff aside the standard format.

Content
mandatory
name: <name_of_the_file>
description: This file ...
author: while-true-do.io
company: while-true-do.io
license: <used_license>

optional
contributors: <name>, <name>, <name>
reference: <reference_link>, <reference_link>
issue_tracker: <issue_tracker_link>, <reference_link>

Examples
Examples will be given in the proper contribution.md.
kudos.txt
kudos.txt will be a new project from WTD to "kudos" contributors and partners properly in a human readable way. It will also have a script to add the headers, which are meant above. Maybe, this will can be a project to address multiple "issues" in contributor mentions.
guideline

kudos.txt must be present in each project
each contributor is free to add information to it
each information is optional

content of a kudos.txt
# kudos.txt - Express gratitude to your contributors.
#
# https://<link-to-kudos-project-page>

## contributors
- name: <name>
  role: <role in the repository>
  site: <url>, <mail>, <social>
  company: <company>
  location: <city>, <country>

- name: <name>
  role: <role in the repository>
  site: <url>, <mail>, <social>
  location: <city>, <country>

## partners and sponsors
- name: <name>
  site: <url>, <mail>, <social>

- name: <name>
  site: <url>, <mail>, <social>
  reason: <reason>

- name: <name>
  site: <url>, <mail>, <social>
  reason: <reason>

## software and tools
- name: <name of the software (please include brand marks)>
  license: <license>

- name: <name of the software (please include brand marks)>
  license: <license>

github.com/kudos-txt created.
working on first implementation in fb-daniel


BMS Charging Update (fixed)

Summary

Relevant Jira: ELEC-41
Changelist
Init State:

If charger is connected, the board waits for a CAN message to enable charging (Enters Pre-Charge)

Pre-Charge State:

Failing Pre-Charge for charging will disable the CAN message . It will also send it back to Init State if Pre-Charge has not failed more than three times and if it is has been more than three times then it is sent into Fault State.

All States:

If the charger is connected, it checks if the charger has thrown a fault it will get fault state.
If the charger is connected and AIRs- opens (Shutdown loop activates), sends BMS to fault state.
If the charger is not connected it checks if the car is in charging state which would indicate that the charger was disconnected midway through charging. It would then go into fault state.

Charge State:

Disabling CAN message for charging and charger has been put into RunOnExit.
Checks all at once if the CAN message is disabled, external shutdown loop has triggered or if charging has completed and enters Init State if any are true.
Checking if charging is complete is done by comparing the current being supplied to 0.05C charging.

Testing Done

With no enabling CAN message to charge while the charger is connected in Init state, the BMS should remain in Init state waiting for charging CAN message.
When the charger is connected in Init state and the CAN message is given, the BMS should go into Precharge state
After charger is connected and the CAN message enabling charging is sent and the system waits for slightly longer, BMS should go into Charge state (Successful precharge should close AIRs+.
Starting in Charge state, with CAN message enabled and the charger connected with less than full charge, the BMS will remain in Charge state.
In Charge state, when current from charger indicates full charge on the cells, the BMS stops charging, switches off the charging CAN message and goes back into Init State and opens AIRs+.
In Charge state, will exit back to Init state in similar manner when false CAN charging message is sent.
In Charge state, will go into fault state if the charger gives a fault. Will also disable CAN charging message.
In Charge state, will go into fault state if charger is connected and the shutdown loop activates (AIRs- is open)
Modified earlier test with charger disconnecting while in Charge state sending BMS to fault state.

Resolved Issues

Checklist
Please change [ ] to [x] when you are ready.

[ ] I have read and followed the code conventions detailed in README.md (This will save time for both you and the reviewer!).
[ ] If this pull request is longer then 500 lines, I have provided explicit justification in the summary above explaining why I cannot break this up into multiple pull requests (Small PR's are faster and less painful for everyone involved!).

@gtaharaedmonds I'd request your review but you're the PR author

Worked on car, battery no go boom 🔥

SICKK


Different logging level for request and response

It would be helpful to have ability to set different log level for request and response in okhttp-logging-interceptor. For example, I would like to log all requests body but I wouldn't log responses body, because, it may be too large.

Please copy+paste the log interceptor and customize to your liking? It’s just there for the basic use cases.
Or use a more sophisticated tool like Chuck.

No action to take on this.


Get the data what we wrangled in our first milestone.

https://github.ubc.ca/MDS-2020-21/DSCI_525_web-cloud-comp_students/blob/master/Milestones/Milestone2.ipynb

Complete in Lab, data in S3 bucket.


feature: Mark all changes in a directory for a commit

Did you check the docs?

[X] I have read all the docs

Is your feature request related to a problem? Please describe.
When opening Fugit2 and you have a lot of changes it would be great, if hitting space on a directory would add all changes in that directory to the commit (similar as lazygit does it)
Describe the solution you'd like
see above
Describe alternatives you've considered
not sure about alternatives though. Maybe another keybinding.
Additional context
No response

Agree, this can easily be done. Can reuse the same code for visual mode staging.
Tips: you can toggle visual mode, select all file under one directory, then press "-", "space" or "s" for staging.

Ah. yes, this is cool But not really what I meant: In your video, it would be a lot easier to just hit space fugit2 and all changes in that directory would be added. But visual mode is of course also helpful, as vimmotions work.

@sboesebeck, I got your point, I think I can reuse the same visual staging code for this feature, please wait for my update

@sboesebeck, implemented this feature on latest changes. Please test :D.


switch the healthy check to use diagnostics call

Is your feature request related to a problem? Please describe
switch the healthy check to use diagnostics call
Describe the solution you'd like
switch the healthy check to use diagnostics call instead of just the zos version

duplicated https://github.com/threefoldtech/tfgrid-sdk-go/issues/891


add mock category relation

@MagicTearsAsunder
May I ask you to PR in different branch, because this PR is first step for hierarchical labels

@MagicTearsAsunder
As we discussed, this PR also should add hierarchical response into /jobs/{job_id}/categories/
May I ask you to check other GET responses, maybe we forgot some places?


Accessibility: Tab through items in the slider

Is there a way to tab through the visible items in the slider when the left/right arrow keys are visible? My ideal tabbing scenario would be that after I tab to focus on the left arrow key, I can tab in the right most item in the slider. I can then tab to each remaining item in the slider until i tab to the right arrow key.

So does react-slick not support tabbing? This is a pretty big thing when it comes to accessibility.

Any update on this? I notice a lot of issues regarding accessibility.


added failing test case for converting complex regex to json

Failing test case for issue #173, "validates format with complex regex generates invalid json". Let me know if there's anything I can do to help you replicate the issue or troubleshoot it. Thanks.

Can you provide a use case for this?

Use case: I've got a model called Link, which lets users attach URLs to Projects. I'd like to validate the format of Link.address, but all the "good" URI regexes I can find die on their way through client_side_validations. I can write a mediocre one of course, and I can write a custom validator to actually check to see if HTTP requests to the link get a 200 response, so there are alternatives.
For the record, Gruber's regex is probably a better test case than URI::regexp, which I used.  Although even Gruber's may need tweaking to be a fair test, since his is designed for plucking URIs out of a larger text, not validating a URI in isolation. I can update my pull request with a more fair challenge for client_side_validations if you're interested.

There are a few problems here.

The tests cases will always fail because you are comparing Regex objects to String objects

The regex being generated cannot cleanly convert to javascript. Specifically, the regex comments and the group options being generated.

I believe this has now been fixed:
https://github.com/bcardarella/client_side_validations/compare/c6ba2f5db3a5238767014974439a71c3a6a9d9fc...master

Thanks, and sorry for the stupid mistake trying to write you a test case. I've tested your code on a variant of Gruber's regex, and it passes with flying colors.
def test_complex_regexp_to_json
  assert_equal '/^([a-z][\w-]+:(?:\/{1,3}|[a-z0-9%])|www\d{0,3}[.]|[a-z0-9.\-]+[.][a-z]{2,4}\/)([^\s()<>]+|\(([^\s()<>]+|(\([^\s()<>]+\)))*\))$/', /^([a-z][\w-]+:(?:\/{1,3}|[a-z0-9%])|www\d{0,3}[.]|[a-z0-9.\-]+[.][a-z]{2,4}\/)([^\s()<>]+|\(([^\s()<>]+|(\([^\s()<>]+\)))*\))$/.to_json
end


Small darkmode error in the Contributions tab

What

Small darkmode error in the Contributions tab

Screenshot

I found the bug.  The TextView has a text color valut that set set to black, android:textColor="@color/black".  Possible solutions, are remove the text color. This view will use materials color.  Define text color in colors.xml file in both colors and colors-night folder. Or. use android:textAppearance with custom style or one inherited from Android platform's default text appearance.
Since the attribute_group_item.xml file uses the textAttribute inplace of textColor, I think the textAttribute solution, using inherited style from Android platform sounds appropriate.  android:textAppearance="@android:style/TextAppearance.DeviceDefault"

Fixed by https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/4628


Specifications for entity variables

Would it be useful to be able to create a specification for an entity variable.
The entity var spec would provide a way of declaring the structure of the entity variable.

I think the most pressing reason for doing this would be to allow compile time checking of updates.


feat: Support instrument in build mode

Allow support for instrument in build mode.
This is usefull when you run cypress in e2e mode for example.

LGTM. Thanks for contributing, well done!.


The app would be exceptionally more convenient out of local network

Basically, I'm seeking for something matching the description of Syncthing Lite, and it's nowhere to be found (while that app seems to be just dead, where full-fledged Syncthing forces on you complete syncing over casual browsing or single file operation). Needing to always be in a local network is a burden that introduces limitations that don't have to exist, and decentralized file sharing over P2P would be crucial to push the wider audience from commercial cloud hosting. This app basically looks like everything what I really need, but I can't VPN to home 24/7 :/ Probably an overkill would be to base it on .onion domain, but even that would improve versatility. For extra reference of decentralized packet transfer, I can also name Tox and Briar communicators. Sorry for bothering if you see this project as permanently based on local network, but just posting my unfulfilled dreams. Thanks!

Random keywords: UDP hole punching, DHT, BitTorrent, ssh-p2p

This apps just a tools could share files for Android devices and PCs, you could do that over local area network or WIFI P2P. It's not a Cloud Disk.

It's more alike a invisible USB cable to connect diffrent devices.

I know what it's able to do, but pretty sure it'd be helpful (at least for me) to make it work out of local network. In my usage it'd handle many of cloud usecases, as for me it's mostly about quick access to files that aren't present on one of my devices (keeping them completely in sync would also clog their storage too much). This idea seems to be targeted by Syncthing Lite, but as I mentioned initially, it seems to be an abandoned project, while classic Syncthing forces complete sync.


Business page bug fix

Fixes for issues Pankaj found in the ticket mentioned below:
Resolves: MWPW-137551
Test URLs:

Before: https://stage--express--adobecom.hlx.page/jp/express/business?lighthouse=on
After: https://jp-business-page-fix--express--adobecom.hlx.page/jp/express/business?lighthouse=on
After: https://jp-business-page-fix--express--adobecom.hlx.page/fr/express/business?lighthouse=on

Codecov Report

Merging #342 (543617d) into stage (1818241) will decrease coverage by 0.04%.
Report is 4 commits behind head on stage.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##            stage     #342      +/-   ##
==========================================
- Coverage   31.30%   31.26%   -0.04%
==========================================
  Files         122      122
  Lines       24887    24907      +20
==========================================
- Hits         7791     7788       -3
- Misses      17096    17119      +23

Files
Coverage Δ

express/blocks/pricing-summary/pricing-summary.js
82.17% <0.00%> (ø)

express/scripts/utils/pricing.js
71.16% <0.00%> (+0.55%)
:arrow_up:

express/scripts/scripts.js
39.19% <8.00%> (-0.37%)
:arrow_down:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add linting (eslint)

Just an idea (not sure how useful, since the whole codebase fits on one screen 😄), but adding some linting could prevent some accidental mistakes, like unused variables and such.

Sounds good to me. I use standard in a number of my other projects - what do you think?

Sounds good! I once sat down, read through all the options and picked the ones I liked. Didn't know eslint configs were composable using "extends"... Oops

#25 but not running on travis yet

Fixed in #25


[WIP] Small test refactor

-bump pytest
-split cluster into conftest so it can be replaced outight
-remove pytest_dir option
-add helper for getting env options
-add helper for session tempfiles

@cmaloney This is all consolidated for ease of testing downstream. Please let me know what you would like to see split into other PRs

One PR looks fine for this

@cmaloney This is ready for review

Just noticed one thing: This should update test_util/run-all / the bash in the same way


Saved weights dimension mismatch

ValueError: Layer #1 (named "conv2d_1"), weight <tf.Variable 'conv2d_1/kernel:0' shape=(3, 3, 32, 32) dtype=float32, numpy=
array[...] has shape (3, 3, 32, 32), but the saved weight has shape (32, 3, 3, 3)

ValueError: Layer #1 (named "conv2d_1"), weight <tf.Variable 'conv2d_1/kernel:0' shape=(3, 3, 32, 32) dtype=float32, numpy=
array[...] has shape (3, 3, 32, 32), but the saved weight has shape (32, 3, 3, 3)

@GeorgianaLoba solution for @Arminkhayati partially works. The 2.0 version works for the full model but If you need the headless model this doesn't work (404 error). The 2.1 version has dimension mismatch between weights and model for both include_top = True and include_top = False
inception_v4.py    lines 39 and 40
WEIGHTS_PATH = 'https://github.com/kentsommer/keras-inceptionV4/releases/download/2.0/inception-v4_weights_tf_dim_ordering_tf_kernels.h5'
WEIGHTS_PATH_NO_TOP = 'https://github.com/kentsommer/keras-inceptionV4/releases/download/2.0/inception-v4_weights_tf_dim_ordering_tf_kernels_notop.h5'

Closing this out after a long hiatus from Github. There have been a lot of updates across many of the utilized frameworks since this was published. Unfortunately I did and do not have the time to update it which is most likely why these issues are cropping up.
I will happily merge in any pull requests if folks have a desire to keep this working. Apologies for such a late response.


Wait for windows' state to be saved before closing the app or any window

This fixes a test failure on #12300 where the new Electron version prevents state from being serialized.
Previously, we used to save the window's state in the renderer process beforeunload event handler: because of the synchronous nature of event handlers and the asynchronous design of IndexedDB, this could potentially not save anything if windows close fast enough to prevent IndexedDB from committing the pending transaction containing the state. (Ref.: https://mzl.la/2bXCXDn)
With this commit, we will intercept the before-quit events on electron.app and the close event on BrowserWindow (which will fire respectively before quitting the application and before closing a
window), and prevent them from performing the default action. We will then ask each renderer process to save its state and, finally, close the window and/or the app when the IndexedDB transaction completes.
/cc: @atom/core @thomasjo

LGTM! 🚀

Quick and awesome work to clear this obstacle @as-cii. ⚡

Why are renderers responsible for writing to disk? A renderer, by definition, is a one-way method. Maybe the entire write-to-disk logic should be moved somewhere else?

Why are renderers responsible for writing to disk? A renderer, by definition, is a one-way method. Maybe the entire write-to-disk logic should be moved somewhere else?

In this case we're borrowing Electron's terminology to draw a distinction between the main process and the windows (render) processes. Each window is responsible for maintaining its own state and, since renderer processes have also access to the IndexedDB API, they just serialize and save state by themselves.
I guess at some point we might let the main process handle serialization/persistence of windows'  state, but that would come with the cost of transmitting potentially big object graphs via IPC and I am not sure it would be worth it. Moreover, I don't think the IndexedDB API is exposed in the main process, which would probably require us switching to a different backing store.


reserve fields prefixed by '@' for plugins.

Initial prototype for #7423

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

r? @alexcrichton
Sorry for the delay @ratmice, but thanks for the PR!
This is a pretty significant change to manifests though, so I think that this needs to go through an RFC first before becoming a PR to Cargo?

I'm going to close this for the reasons specified here https://github.com/rust-lang/rfcs/pull/2776#issuecomment-541262534


Add command to initialize a new config

Be able to let Constyle generate a new .constyblerc file based on CSS that is provided. This should make getting started a lot easier.
constyble init style.css
# or
cat style.css | constyble init

Should generate a .constyblerc file in the current working directory based on the css statistics of the passed CSS.
# Generating a custom file path config
constyble init style.css --config='/path/to/constyle.json'
# or
cat style.css | constyble init --config='/path/to/constyle.json'

To be discussed

What to do when file cannot be written?
What to when file already exists?
Should we implement constyble init --help, displaying an init oriented help message?

Idea credit: @jeroen-severein

@jeroen-severein Could you chime in and give some thoughts on the above?

In case it can’t be written I would expect it to exit with a “can’t write to output file”-error.
If it already exists, I would expect a “overwrite yes or no?” prompt.
What would the init specific help need to explain further? I feel it would be enough if the init option is explained in the general constyble --help option. It would be nice to have explanations in comments of the settings file it generates though.

It could be useful to replace Meow with Sade, to gain support for subcommands (meow lacks them): https://www.npmjs.com/package/sade


Prevent attack on baked-in host keys

We bake a known_hosts file with entries for github.com, gitlab.com and bitbucket.com into the fluxd and helm-operator images, for convenience when using them with these services (it means you don't have to supply a known-hosts of your own).
However, an attacker with some access to the build process could substitute bogus host keys.

So for reference purposes, the fingerprints (against which the ssh keys can be verified) for some of the vendors are outlined in links below:

Vendor
Url

gitlab.com
https://docs.gitlab.com/ee/user/gitlab_com/#ssh-host-keys-fingerprints

github.com
https://help.github.com/articles/github-s-ssh-key-fingerprints/

bitbucket.com
https://confluence.atlassian.com/bitbucket/ssh-keys-935365775.html?_ga=2.218915353.1800597462.1533976560-140885449.1533976560

Added a script to check against pre-baked keys that came from the references above.
Ref: https://github.com/weaveworks/flux/pull/1283

can close now !


Add failsafe version detection, to prevent CLI crash

When building an fmriprep image directly from github, the version is not set correctly, as defaults to ''.
As a consequence the CLI crashes, because it can't parse the version:
Traceback (most recent call last):
  File "/usr/local/miniconda/bin/fmriprep", line 10, in <module>
    sys.exit(main())
  File "/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/cli/run.py", line 312, in main
    opts = get_parser().parse_args()
  File "/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/cli/run.py", line 50, in get_parser
    currentv = Version(__version__)
  File "/usr/local/miniconda/lib/python3.7/site-packages/packaging/version.py", line 221, in __init__
    raise InvalidVersion("Invalid version: '{0}'".format(version))
packaging.version.InvalidVersion: Invalid version: ''

I suggest a failsafe unknown version is set if the version is an empty string.

To consider in conjunction with #1779

What about 'stable'?

When building an fmriprep image directly from github, the version is not set correctly, as defaults to ''.

What did you exactly try? I'll need to replicate to understand what is going on. Only now I understand why you proposed this https://github.com/poldracklab/fmriprep/pull/1829/files#diff-b93ab0122f4b2ac6738b896651cac6ccR49-R50
This apparently simple issue might be masking a deeper problem with versioneer and our version tracking infrastructure.

I believe that I git cloned this repository, cd fmriprep and docker build . -t fmriprep.
Then when I did docker run there version was an empty string.

Okay, then I guess you should've passed the VERSION --build-arg:
https://github.com/poldracklab/fmriprep/blob/2e5a95fc3643f3507209bad18407757989f63c5e/.circleci/config.yml#L61-L67
Can you try the following?
docker build --rm -t fmriprep \
    --build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \
    --build-arg VCS_REF=`git rev-parse --short HEAD` \
    --build-arg VERSION=$( python get_version.py ) .

We probably want to have a Makefile with a build target that includes the build args.

I think the point was just that it's a minor pain and we can probably set it up not to trip people up who don't want to learn about build args just to run a test.

Ah yeah. My internet is too crappy right now to try it, but I'm sure that works.
I agree with @effigies here. Maybe if build-args are missing, it should either throw an error at build time, or (better) throw a warning, but default to a value that is valid (if meaningless) later on.

I think we tried to update the docs for this in #1797, so it'd be great to review if there's more that should be added there, too.
And just explicitly: I'm a strong +1 on throwing a more descriptive error !

Ah, nice. How ironic that I had that very issue for the docusprint.
Docs look good to me. Unfortunately, there's a very good chance I probably wouldn't have read the docs anyways, and there's too many people like me in this world.


React's Higher-order Components documentation needs an example of a component that consumes properties

I read the documentation in https://flow.org/en/docs/react/hoc/ but I have a hard time figuring out how to type higher order components that need specific props, as opposed to the ones that inject props like the documentation says.
Here is my (non working) code, modified from the documentation:
import * as React from 'react';

type NeededProps = {
  bar: number
};

function consumeProp<Props: {}>(
  Component: React.ComponentType<Props>
): React.ComponentType<NeededProps & Props> {
  return function WrapperComponent(props: NeededProps & Props) {
  	if (props.bar < 100) {
	    return <Component {...props} />;
	}
	return null;
  };
}

class MyComponent extends React.Component<{
  a: number,
  b: number,
}> {}

const MyEnhancedComponent = consumeProp(MyComponent);

<MyEnhancedComponent a={1} b={2} bar={42} />;

But I still get errors:
    13: 	    return <Component {...props} />;
                    ^ props of React element `Component`. This type is incompatible with
    8: function consumeProp<Props: {}>(
       ^ some incompatible instantiation of `Props`
    13: 	    return <Component {...props} />;
                    ^ props of React element `Component`. This type is incompatible with the expected param type of
    8: function consumeProp<Props: {}>(
       ^ some incompatible instantiation of `Props`

See the live try.
I tried using utilities like $Diff, or { ...$Exact<Something>, ... SomethingElse } but I couldn't make it work.
Some guidance would be helpful, including maybe some more documentation :)
(Note: my ultimate goal is to type a HOC that both consumes and injects properties).

Here is another try, possibly easier to follow because I used the same terminology for "input" and "output" than in the doc, but gives the same error:
import * as React from 'react';

type NeededProps = {
  bar: number
};

function consumeProp<InputProps: {}, OutputProps: NeededProps & InputProps>(
  Component: React.ComponentType<InputProps>
): React.ComponentType<OutputProps> {
  return function WrapperComponent(props: OutputProps) {
  	if (props.bar < 100) {
	    return <Component {...props} />;
	}
	return null;
  };
}

class MyComponent extends React.Component<{
  a: number,
  b: number,
}> {}

const MyEnhancedComponent = consumeProp(MyComponent);

<MyEnhancedComponent a={1} b={2} bar={42} />;

Here is the error:
    13: 	    return <Component {...props} />;
                    ^ props of React element `Component`. This type is incompatible with
    8: function consumeProp<InputProps: {}, OutputProps: NeededProps & InputProps>(
       ^ some incompatible instantiation of `InputProps`
    13: 	    return <Component {...props} />;
                    ^ props of React element `Component`. This type is incompatible with the expected param type of
    8: function consumeProp<InputProps: {}, OutputProps: NeededProps & InputProps>(
       ^ some incompatible instantiation of `InputProps`

This is really confusing to me. If OutputProps is both InputProps and NeededProps (intersection type), why is there an error when returning <Component {...props} /> when Component needs just InputProps ? Even taking variance into account, shouldn't this be always right, whatever InputProps is ?

Using try's introspection mechanism (in bottom status bar), I see that props is {} & { bar: number }, which is the opposite that OutputProps is (I mean: { bar: number } && {}). I don't know if this is important. The documentation for HOC seems to imply that the order in an intersection is important, but the documentation for intersections says nothing about this.

Component is ComponentType<InputProps> which is expected.
So I think the problem here is that OutputProps has nothing about InputProps: flow replaced InputProps with {} in its defition. I believe this is a bug...

In case anybody is interested, I manage to make flow pass with this:
import * as React from 'react';

type NeededProps = {
  bar: number
};

function consumeProp<Props: NeededProps>(
  Component: React.ComponentType<$Supertype<Props>>
): React.ComponentType<Props> {
  return function WrapperComponent(props: Props) {
  	if (props.bar < 100) {
	    return <Component {...props} />;
	}
	return null;
  };
}

class MyComponent extends React.Component<{
  a: number,
  b: number,
}> {}

const MyEnhancedComponent = consumeProp(MyComponent);

<MyEnhancedComponent a={1} b={2} bar={42} />;

Notice the use of $Supertype. It means that the props for MyEnhancedComponent are extending the props for MyComponent -- which in Flow means that they have more properties, so it makes sense.
I think this could be easier, especially I still think my first approach should work.

And now, here the example of a HOC that both consumes and injects properties (previous example adapted with the good documentation for injected components):
import * as React from 'react';

type NeededProps = {
  bar: number
};

type InjectedProps = {
  foo: string
};

function consumeProp<Props: NeededProps>(
  Component: React.ComponentType<InjectedProps & $Supertype<Props>>
): React.ComponentType<Props> {
  return function WrapperComponent(props: Props) {
  	if (props.bar < 100) {
	    return <Component {...props} foo="string" />;
	}
	return null;
  };
}

class MyComponent extends React.Component<{
  a: number,
  b: number,
  foo: string
}> {}

const MyEnhancedComponent = consumeProp(MyComponent);

<MyEnhancedComponent a={1} b={2} bar={42} />;

@julienw I recently ran into this issue as well, and I might have found a solution that works for your code from https://github.com/facebook/flow/issues/4759#issuecomment-327417887:
See example
function consumeProp<InputProps: {}, OutputProps: InputProps & NeededProps>(
  Component: React.ComponentType<InputProps>
): React.ComponentType<OutputProps> {
  return function WrapperComponent(props: OutputProps) {
    const { bar, ...otherProps } = props;
  	if (bar < 100) {
	    return <Component {...otherProps} />;
	}
	return null;
  };
}

You had an error in your example: you were sending all OutputProps to the Component you were wrapping, but that was declared to only accept InputProps. So you need to desctructure the bar from props and send the rest of the props to Component.

I switched the order of the OutputProps intersection to InputProps & NeededProps and that seems to make Flow happy. If the order is reversed, Flow throws an error still.

Thanks for your comment !

 So you need to desctructure the bar from props and send the rest of the props to Component.

Yeah but because I didn't use Exact objects for the Component props, it should accept useless props too, right ? But I think this still confuses Flow...
I really like your solution because Exact props is something I'd like too. I'm not used to rest object destructuring yet :)

Ah strangely when I make MyComponent props an exact object, I get the following error:
    27: <MyEnhancedComponent a={1} b={2} bar={42} />;
        ^ property `bar`. Property not found in
    20: class MyComponent extends React.Component<{|
                                                  ^ object type

despite the rest operation :)
BTW I see that otherProps is infered as {} by Flow. Not sure what to conclude from this :)

I have a similar issue I believe. Getting some incompatible instantian of Props errors. I opened a stackoverflow post for it.
I'm wondering why this is causing errors:
import * as React from 'react';

function mergeTheme<Props: {}, T: {}>(
    Component: React.ComponentType<{ theme: T } & Props>,
    injectedTheme: T
): React.ComponentType<{ theme: T } & Props> {
    const Themed = (props: { theme: T } & Props) => {
        let theme: T = injectedTheme;
        return <Component {...props} theme={theme} />;
    };
    return Themed;
}

Really I want the returned HOC to be { theme?: $Shape<T> } & Props and then I would merge the themes. I managed to reduce that to the above code while still getting the same error.
This works but isn't correct and causes errors for consumers
function mergeTheme<Props: {}, T: {}>(
  Component: React.ComponentType<{ theme: T } & Props>,
  injectedTheme: T
): React.ComponentType<{ theme: T } & Props> {
  const Themed = (props: { theme: T } & Props) => {
      const baseProps: Props = props;
      let theme: T = injectedTheme;
      return <Component {...props} theme={theme} />;
  };
  return Themed;
}


Get hive root with --bn

** RECmd version # **
<IP_ADDRESS>
Describe the bug
When using --kn, I can successfully use the alias "ROOT\*" to get all keys under the root path, without the need to know the root path name in advance. However, when using --bn, "ROOT" alias does not work.
Within the hive I'm analyzing, the root path is named "CsiTool-CreateHive-{00000000-0000-0000-0000-000000000000}" and the only method in which I was successful in fetching the data I wanted was defining:
KeyPath: CsiTool-CreateHive-{00000000-0000-0000-0000-000000000000}*
The results were:

To Reproduce
Mentioned above
Expected behavior
Mentioned above
Additional context
I hope I made sense

Does a wild card not work for that? A *

What does just

Do

Used KeyPath: *
Got:

If it's in a batch file you'll have to put that single star in single quotes because yaml doesn't like it otherwise

Putting a single star in single quotes only gave me details about the root path itself without detailing the keys it holds, unlike what I get when using "--kn ROOT*"
Again, I truly appreciate your assistance with this issue!!

The reason I'm doing this, is that I want to dump the keys under ROOT to CSV, and it's impossible with --kn unfortunately.

Is there a way to export the keys under "ROOT*" to CSV?

@AndrewRathbun have you ever tried this?

@AndrewRathbun have you ever tried this?

I'll have to give this a go after hours! I'll report back

Alright, sorry for the delay on this.
I made a test Batch file, ROOTtest.reb, as seen below:
Description: ROOT test
Author: Andrew Rathbun
Version: 1
Id: 49ff9762-4dce-413f-928b-786daa8aec5a
Keys:
    -
        Description: ROOT Key Test - SOFTWARE
        HiveType: Software
        Category: ROOT Keys
        KeyPath: ROOT\*
        Recursive: false
        Comment: ROOT test
    -
        Description: ROOT Key Test - SYSTEM
        HiveType: SYSTEM
        Category: ROOT Keys
        KeyPath: ROOT\*
        Recursive: false
        Comment: ROOT test
    -
        Description: ROOT Key Test - SAM
        HiveType: SAM
        Category: ROOT Keys
        KeyPath: ROOT\*
        Recursive: false
        Comment: ROOT test
    -
        Description: ROOT Key Test - SECURITY
        HiveType: SECURITY
        Category: ROOT Keys
        KeyPath: ROOT\*
        Recursive: false
        Comment: ROOT test
    -
        Description: ROOT Key Test - NTUSER
        HiveType: NTUSER
        Category: ROOT Keys
        KeyPath: ROOT\*
        Recursive: false
        Comment: ROOT test
    -
        Description: ROOT Key Test - UsrClass
        HiveType: UsrClass
        Category: ROOT Keys
        KeyPath: ROOT\*
        Recursive: false
        Comment: ROOT test

First things first, I collected my registry hives using this KAPE command:
.\kape.exe --tsource C: --tdest C:\temp\RegHiveTest\tout --tflush --target RegistryHives --debug

and I ran this RECmd command against the aforementioned hives using the following command:
.\RECmd.exe -d "C:\temp\RegHiveTest\tout" --bn "C:\temp\ROOTtest.reb" --nl false --csv C:\temp\RegHiveTest

This resulted in what I believe to be what @DFIR-Purim is looking for:

Nothing beyond ROOT\* was grabbed using the above ROOTtest.reb batch file. If we want this to be in production, I can clean it up a bit and name it better, like ROOTKeyDumpNonRecursive.reb or similar. Thoughts?

@DFIR-Purim any feedback on the above?

@AndrewRathbun we appreciate all your amazing work!
Unfortunately the person with whom you communicated is no longer a DFIR analyst. If our team ever gets to use the new feature you've added, we'll make sure to update you.

Ok xool


Only scrcpy 2.0 is working properly, but the version on TestFlight has already expired.

Other version logs

Please provide your device model, scrcpy version and the system version. Post your detailed logs more better.


Rename Symbol capability throws NPE in LS

Description:
Rename Symbol capability not working in LS.
Steps to reproduce:

Add following code in VS code editor.

import ballerina/http;

@http:ServiceConfig {
    basePath: "/"
}
service<http:Service> hello bind {port:9090} {
    @http:ResourceConfig {
        methods: ["POST"],
        path: "/"
    }
    hi (endpoint caller, http:Request request) {
        string payload = check request.getTextPayload();
        http:Response res;
        res.setPayload("Hello "+payload+"!\n");
        _ = caller->respond(res);
    }
}

Right click on payload and click on "Rename Symbol"
Check the exception thrown.

Affected Versions:
0.97.0
OS, DB, other environment details and versions:
Mac OS
Related Issues (optional):
N/A
Suggested Labels (optional):
N/A
Suggested Assignees (optional):
N/A

This has been fixed hence closing this issue.


[NATS JetStream] allow to sub with wildcard

Fixes #56

Yep, forgot about that. I added a small ref that points the actual example.


Add CODEOWNERS file

Signed-off-by: Sven Trieflinger<EMAIL_ADDRESS>

Subtask of carbynestack/carbynestack#26 for Amphora.


Docs request: linking demo site with button

Hello!  This looks to be an awesome new theme.
https://themes.gohugo.io/themes/lightbi-hugo/
Are you able to add demosite to theme.toml?  That way I think a yellow "Demo" button shows up on the theme's page

Alternate example: https://themes.gohugo.io/themes/hugo-theme-anubis/

Updated the theme.toml. Thank you.


Using options from default config when not specified in user config

App uses options from default config when not specified in user config. That's issue #1588. Now if you won't specify an option in your config, it will be automatically added from default config.

Thank you for your help.
We'll review it ASAP.

I'll create next PR in second

FYI: Next time, you don't have to make another PR.  PR will be automatically updated.

Ok sorry. This is on of my first contributions to open-source. But now there is new PR: #2126

No problem @okonek 👍  🎉

Could you review it?


Fixed bug AssertJ matcher

Fixed bug "unable to find component using matcher".

Pull Request Test Coverage Report for Build #48
Details

277 of 277 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build #40:
0.0%

Covered Lines:
363

Relevant Lines:
363

💛  - Coveralls


textDocumentSync usage - Question

Hello everyone,
i'm implementing a prototype of LSP. I stumb over a problem that the documents manager does not keep in sync with document which i'm editing on the Editor.
I read an article it said "the syncronization should be done out of the box by Documents manager"
I checked the clientCapability it shows
"textDocument": {
      "synchronization": {
        "willSave": true,
        "willSaveWaitUntil": true,
        "didSave": true
      },

and server cabability it shows:
"capabilities": {
    "textDocumentSync": 2,
    "hoverProvider": true,
    "completionProvider": {
      "resolveProvider": false,
      "triggerCharacters": [
        "\"",
        ":"
      ]
    },

Could anyone let me know what's wrong ? in the Language Server code I do. It always show the original state on the disk but not what i'm editing. For sure I do not save the content to the disk yet because i'm doing autocompletion.
const document = documents.get(textDocumentPosition.textDocument.uri);

console.log("Found document [" + document.getText());

When I implement the onDidChange. The content sent here is really real time. This is what I need for my autocompletion. But I can't update the Documents manager with newest content from editor. I was hoping the manager does it on it owns.
connection.onDidChangeTextDocument(handler => {

Thanks a lot. A hint would be very helpful for me.

adding ProposedFeatures.all in to initialize of connection solved the problem.
const connection: Connection = createConnection(ProposedFeatures.all);