Add offboard velocity control with z-axis position control.

The set_position_target_local_ned.type_mask allows for individual bit masks for x,y,z,vx,vy,vz, but px4 only implemented 0x7 for position control OR 0x38 for velocity control.  This change allows you to mix 0x4 for z-axis control with 0x30 for vx,vy control.  The mc_pos_control module will then maintain the specified z-position while honoring the vx,vy velocity control.  This makes it super simple to fly nice curves while not having to worry about implementing a pid-algorithm for managing height.  Besides it is better for mc_pos_control to do that since it has a much tighter loop than an offboard mavlink connection.

Makes a lot of sense overall. Could you please do the suggested changes? @Stifael please review.

Stifael, have you had a chance to look at this yet?  I've been testing it successfully for the last week and it seems good to go.

This featuring is interesting. I am wondering if the vx/vy are in local NED frame, or in body fixed frame. Ca it be used such that when I would like to command the vehicle to mode forwared (command +vx), right (command +vy) w.r.t to vehicle-fixed NED frame?

@mzahana: the velocity setpoints are in local frame coordinate system, so you if you work offboard you can just transform the body fixed velocity vectors to the local frame

please merge it in master asap :) thx

Replaced by rebased https://github.com/PX4/Firmware/pull/5816

Rebased, squashed and merged.


[apr] provides CMake targets

Is your feature request related to a problem? Please describe.
vcpkg install apr,
don't display find_package and target_link_libraries  cmake info
Proposed solution
support and display find_package  and target_link_libraries  config
Describe alternatives you've considered
Additional context.

@JonLiu1993 also add apr_util package CMake targets

@pengliaoye ,Please reopen an issue. Regarding apr_util, this issue only solves apr


fix: AsyncAutocomplete multi-select support

options list is closed after each select
search is cleared after each select
onChange is fired with only the latest selection as a single element array
re-selecting a selected option when the dropdown is open does not de-select
default item component doesn't have indicator for which options are selected in dropdown

Changes from this were added from this to #4858 . Thanks!


Position Embedding in class Resampler

Thanks for your contribution.
In the original LLaVA-UHD, the self.pos_embed in class Resampler is frozen, though they wrongly make it trainable again the in train.py as they fine-tune the whole mm_projector.
In your code, I notice that you directly make it trainable. I wonder whether this should be frozen and how it affects the performance.
Moreover, LLaVA-UHD adds position embedding for q when calculating attention. Is it necessary for your code to add downsampled position embedding for q?

I do take consideration of freeze self.pos_embed. I am currently running model of this configuration. If I verify it is a better design, I will update that code to this repo.
q is learnable query. It is essentially a set of model weights. I think there is no reason to do additional calculation on q before q attending image features.

Looking forward to your results.
I guess q here is to 'downsample' v, and it is more like a learnable pooling strategy. So LLaVA-UHD adds position embedding to q and the position embedding of k is interpolated by it of q, providing a downsample prior knowledge.


docs: Update readme

@larme I believe the Llama 7B readme needs update as well, but before I do that, just wondering why we have an import_model.py file for it? The mistral models do not have it.

@Sherlock113 the llama2 one need import_model.py because we want the bento to include model to avoid huggingface auth problem. I think it's also a good example for users who want to use their own local models. I think we can update llama2's readme in another PR. So let's merge this one for now.


Fix misplaced defer in manifest caching

In #5797, I introduced the outer do-block here, but did not move the existing defer from the now inner do-block.
Related to rdar://101956252

@swift-ci please smoke test

Hm, looks like this isn't working well: Basics/SQLiteBackedCache.swift:66: Fatal error: db should be closed

@swift-ci please smoke test


Feature Request: Command to only show TODOs for Open Files

Is there any way you could create a new command that only shows TODOs for open files?

@jonathandelgado I think it's not an edge case but an use case. Tell me why do you want to see project + open in the same list.
a) Considering open files are outside the project, probably I don't want them in the same todo list (different projects maybe?)
b) Considering open files are inside the project, then it has the same effect as "Current Project" in the command palette.
It seems more useful to have Current project as one option and Open files as a separate option.

I'm using the following Default.sublime-commands:
[
	{
		"caption": "TodoReview: Project Files",
		"command": "todo_review"
	},
	{
		"caption": "TodoReview: Open Files",
		"command": "todo_review",
		"args": { "open_files_only": true }
	}
]


Bug:  Access denied

When trying to download the Linux AppImage we are met with the server message "Access Denied".
URL:  https://open.cachefly.net/downloads/OpenSpeedTest-Server_2.1.8.AppImage

Click here
X86 http://go.openspeedtest.com/AppImage
ARM http://go.openspeedtest.com/AppImageARM

That's what I did. It redirects to the URL I provided above AND it gives Access Denied from your server. It's a permissions issue on your end.

Sorry, you should click the links from this page, https://openspeedtest.com/selfhosted-speedtest

Make sure your browser or extensions will not block refferal headers. Use a different browser or use incognito window.
Let me know if you face any issues.


addEventListener is not implemented in older versions of Safari.

Describe the feature / bug 📝:
Strictly speaking, it's not a bug but a compatibility issue. window.matchMedia().addEventListener does not exist in Safari versions less than 5.0.
next-themes has addressed this issue by using the now deprecated addListener API. https://github.com/pacocoursey/next-themes/pull/24
I'm not sure if you think this issue needs to be resolved?
Steps to reproduce the bug 🔁:

Use sonner in Safari versions less than 5.0.

AFAIK Safari 5.0 > is from 2010, let's stick to addEventListener.

@emilkowalski addEventListener is only supported in Safari on iOS 14.0+. iOS 14 was released 2020 so this is actually quite common. We have over 100 users experiencing a crash because of this.
What other approaches are available? Would it be possible to force a color-scheme for iOS <= 13 somehow?


Add CI and PyPi badges

👋 Just a quick edit to add badges to the readme. I would also suggest to tag release in github

Hey @vincentsarago , thanks for  the badges. :+1:
I made  a simple the tag release. Thanks for the suggestion.


DL: Add alternative options for compile params

Add support for optimizer (string) and loss (objective function)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/822/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/831/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/834/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/835/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/836/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/837/


Slider change event not firing

What is the expected behavior?
A slider's change event is fired as your drag the slider
A slider's change event is fired when you use the arrow keys to manipulate it's value
What is the current behavior?
A slider's change  event is only fired if you drag a slider with your mouse and release the mouse button.
What are the steps to reproduce?
In the following plunkr drag the slider with your mouse and notice that the value binding only updates when you release the slider
Plunker template: https://plnkr.co/edit/MWdB3bsOoNcmslvvyGCP?p=preview
What is the use-case or motivation for changing an existing behavior?
I am trying to use a slider to fade out an audio signal so I need a steady stream of change events as it is being dragged.
Which versions of Angular, Material, OS, browsers are affected?
Angular 2.4.7
Material 2.0.0-beta-1

That's by design. The change event only fires on release (similar as for native ranges).
We have added an input event that fires when moving the thumb. See SHA https://github.com/angular/material2/commit/99963c4fd182b490241e4b25f08e948020d7ced8

great I'll try to input event out when it is released. @DevVersion I think the arrow keys not triggering the event is a bug though

I did provide a plunker. Click the slider and then press left or right and notice that the binding does not update

@robianmcd I see. Just didn't look like a Plunker because you left the Plunker template before :)

Just ran the Plunker against master. It looks like this has been solved: https://plnkr.co/edit/oK9LoHHVFiYWbUCOlBwz?p=preview

ok great


Certificates are not added to GCP load-balancer

Describe the bug:
The whole process up to load-balancer update go perfectly (through DNS-01). My certificates are issued, but the Google Cloud Platform load-balancer is not updated to contain the new certificates.
Conditions:
    Last Transition Time:  2018-09-19T12:22:45Z
    Message:               Certificate issued successfully
    Reason:                CertIssued
    Status:                True
    Type:                  Ready

The issue does not appear on my labs cluster, where I created a new GKE cluster, and installed cert-manager from scratch. I got the issue while migrating from kube-lego, which, incidentally, had the same issue, so I believe this could be an issue with something (authorization?) on GCP, but there is no mention of cert-manager trying to update the load-balancer (or failing thereof).
The load-balancer already had three certificates installed.
Expected behaviour:
The newly issued certificates should be added to the load-balancer after a reasonable processing period.
Anything else we need to know?:
As kube-lego had the same issue, I had to manually set the issued certificate on the load-balancer, could that cause a conflict?
Environment details:

Kubernetes version: v1.10.6-gke.2
Cloud-provider/provisioner: GKE
cert-manager version: 0.5.0
Install method: Static manifests

/kind bug

Just realized this may not be cert-manager's scope. And apparently, this could be a known bug in ingress-gce.
I'll wait until you confirm but I may have jumped the gun here.

I'm seeing this issue too. My new certificate is issued but the ingress lb doesn't seem to pick it up and start using it. I'm on a higher version of ingress-gce than the suggested version in the bug linked above, so not sure where the problem lies.

I'm going to close this, as it's not up to cert-manager to ensure that your ingress controllers picks up your certificate.
That said, there were some regressions introduced into ingress-gce that were probably present around the time of this issue being opened that could cause it to not work properly. These have now been resolved in the latest versions of GKE 😄
(also, 👋 @heldtogether)
/close


Allow for alternate skill names

Could be homebrews or other reasons

Healing
Persuasion
Other ones?

Solved in cf7fc4e0b027fafec9acffddebd38cf4578d2772


Webhook integration

Please describe the feature you would like to see implemented.
We do use New Relic or Tideways for our APM - but many shops can not / do not want to afford that. It would be nice to have a new component Webhook or Alert which is using an interface to use a simple:

webhookUrl (config required)
text (auto generated)
icon (config optional)

This is then integrated in the queue and task health check and can be configured in the plugin config as followed:
froshtoolsWebhookUrl
e.g. Google Chat
https://chat.googleapis.com/v1/spaces/XXXXXXXXX/messages?key=XXXXXXXXXXXXXXXX-WEfRq3CPzqKqqsHI&token=VQPe-XXXXXXXXXXXXXXXXX%3D
e.g. Slack
https://hooks.slack.com/services/XXXX/XXXXX/gwvjCmbDxxxxx9teZjRXH5
froshtoolsWebhookImage
e.g. Google Chat
https://www.iconpacks.net/icons/2/free-click-icon-2384-thumb.png
e.g. Slack
blue_heart
Questions being

Is this a feature being interesting / in the scope of the plugin?

I would create a PR if this is upvoted or discussed

to be honest, I did not  really understand what you want to achieve 🤔

To add a simple alerting in form of a webhook to the plugin.
So if the healthcheck for schedules task fails a webhook is called to create a simple message like
"Some of your scheduled tasks have failed for the past 10 minutes"

The problem I see there is only that, you need a functional queue for reporting that :)
So when the queue is not working, you will not get a report as your trigger is not working 😂

Hmm, now I am not sure what you mean by that :thinking:
https://github.com/FriendsOfShopware/FroshTools/blob/9e529ae0284d2788349fb27ab6a35eedcb7acca3/src/Components/Health/Checker/HealthChecker/QueueChecker.php#L29
https://github.com/FriendsOfShopware/FroshTools/blob/9e529ae0284d2788349fb27ab6a35eedcb7acca3/src/Components/Health/Checker/HealthChecker/TaskChecker.php#L55
Adding it after setting the warning would be enough and called without a functional queue, no?
Offtopic:
I remember there was a question about when the RabbitMQ Support will come for this part -> https://github.com/FriendsOfShopware/FroshTools/blob/9e529ae0284d2788349fb27ab6a35eedcb7acca3/src/Components/Health/Checker/HealthChecker/QueueChecker.php#L23 and there will be a different implementation in 6.5 and therefor not prio now. Did I dream this or was there a slack / github thread on that? :laughing:

Hey @Isengo1989
I think what @shyim means is: when your messenger is down, the webhook won't be called, too.
To be sure: you want a died system to tell others that it's dead 🤔
I'd recommend you to call the api of froshtools. 🤔

@tinect @shyim see the above mentiond code lines. Adding a simple curl request there that can be configured with a URL and a Message.
Since the queuechecker and taskchecker do not need a running queue or messenger (I guess you mean messenger:consumer?) this would work anyways (the health check is called when the admin is open or it is called from outside via controller)

Then anyone would have to be loggedin in admin 24/7 so that the status is queued. 🤔

It was just an idea "Is this a feature being interesting / in the scope of the plugin?"
Next time maybe say from the beginning "not wanted" - saves all of us some time ;)

I guess that could be cool, to have something like Alerts.
The only problems I see is:

When you want to track the Queue. You should not depend on the queue. When the Queue is broken, your own check which uses the queue does not run.
Like a Cron URL/Command/Heartbeat in the Storefront
The alerts needs to be somehow configurable and available for a certain messengers 😅


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/823 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 47dccd1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-05-19-05-05-31 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


transaction authorization - updates

What would you like to be added:

[ ] Bit sluggish now, takes 1-2 seconds delay per type
[ ] If there's an initial error, Transaction Authorization displays for a sec and goes back to error page. Before it won't show up the transaction auth if there's an initial error
[ ] Delay on showing InputPin (1-2 seconds)

Why is this needed:

@ivan-zynesis with all transactions combined into one screen authorizing it. I think it might make sense to recreate the JellyfishWallet once without promise proxying on the AuthorizationScreen itself. I think this will greatly reduce complexity and cut down on code complexity.

@ivan-zynesis with all transactions combined into one screen authorizing it. I think it might make sense to recreate the JellyfishWallet once without promise proxying on the AuthorizationScreen itself. I think this will greatly reduce complexity and cut down on code complexity.

Make sense. Another useMemo do not harm much (single source of truth). Will start on this solution today.

Just to be coherent to what I mean:
With all the transactions moved into a single screen for signing, useWalletContext() should not be used for transaction signing, we can just use it for reading of addresses (xpubkey).
For transaction signing, this allows us to remove the global Authorization Component and use a simple Modal push without nasty View set height tricks.
With the newly pushed component, we can simply recreate the entire wallet after user enters their passphrase and pass that passphrase with promptPassphrase. Once the transaction is fully signed, we can dispose the pushed component all the newly created Wallet within that context. This keep the code relavitely clean.


SignalR Redis Configuration needs update

Description
The existing .net 8 documentation for SignalR horizontal scaling with Redis tells us to configure it like this:
services.AddSignalR()
  .AddStackExchangeRedis(connectionString, options => {
      options.Configuration.ChannelPrefix = "MyApp";
  });

When we use the existing documentation to configure a redis backplane for SignalR, we receive a warning that says:
warning CS0618: 'RedisChannel.implicit operator RedisChannel(string)' is obsolete:
'It is preferable to explicitly specify a PatternMode, or use the Literal/Pattern methods'

Please update the .Net 8 documentation to have a signalr setup that does not produce warnings.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/signalr/redis-backplane?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/signalr/redis-backplane.md
Document ID
bddd7575-422d-4342-af48-f6b0979fb69a
Article author
@bradygaster

Feel free to put up a PR to fix this, it should be as simple as changing "MyApp" to RedisChannel.Literal("MyApp")


Cannot debug electron-quick-start in VSCode

Hello, I am able to run this code with cmd in Windows 8 and also with the integrated cmd in VS Code. But it fails when I try to debug the code. I get the following bug:

Debugger listening on [::]:46522
e:\Projects\BT\electron-quick-start\main.js:40
app.on('ready', createWindow)
^
TypeError: Cannot read property 'on' of undefined
at Object. (e:\Projects\BT\electron-quick-start\main.js:40:4)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Timeout.Module.runMain [as _onTimeout] (module.js:604:10)
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
This happens when the debugger reaches the following line:
app.on('ready', createWindow)

I am using exactly the code and have used exactly the instruction declare here. So it is working the cmd terminal. But I don't know why it fails debugging with VS Code?

Same problem here, except that I'm using Windows 10.

@MbProg  I just upgraded VS Code and debugging is working fine. Maybe it's now working for you as well?

@haschdl  Yes thanks. The new update fixed it. It works for me too.

Now a new update of VS Code came out which destroyed everything. Now again debugging is not possible. It is a disaster

The update of VS Code，1.25.1， still can't debug for electron

Same with Version 1.28.2 (1.28.2) on MacOS Mojave.

I have updated with 1.29.1 but still i am facing the issue.

Same Issue
Version: 1.32.3 (system setup)
Commit: a3db5be9b5c6ba46bb7555ec5d60178ecc2eaae4
Date: 2019-03-14T23:43:35.476Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134


Trying to work from the example app..

Version
Tell us which versions you are using:
Sorry I know this issue is not super relative here but it is driving me nuts.

react-native-router-flux v3.31.1
react-native v0.27.0

Expected behaviour
Want to be able to rename the app from Example in the code to App
I have posted about it here in detail: http://stackoverflow.com/questions/38477020/renaming-react-native-example-app/38477223#38477223
Actual behaviour
When I try to update from Example to App it errors during the build and is still somehow referencing Example.
Steps to reproduce

Rename Example everywhere to App
Try to compiler the App
It errors

Maybe there are changes that need to be made in the Xcode project? I've never re-named a project before.

@cridenour hmmmm I see okay I will keep digging and will post a solution here when I find one :).

After running through this tutorial: http://blog.tylerbuchea.com/renaming-a-react-native-project/
I found the best way to handle this was to just remove the ios and android folders and run react-native upgrade
Cheers.


Add support for multiple columns of data (DiagrammeMultiCirculaire)

Make the function able to create multiple pic charts and place them automatically

Done and committed
Available in version 1.0 (latest release)


GetImageThumbnailAsync null reference exception

GetTumbnailAsync sometimes returns NULL, which your code does not account for.  Do this instead:
    IAsyncOperation<BitmapImage> Photo::GetImageThumbnailAsync() const
    {
        auto thumbnail = co_await m_imageFile.GetThumbnailAsync(FileProperties::ThumbnailMode::PicturesView);
        BitmapImage bitmapImage{};

		// fix for when thumbnail is NULL
		if (NULL != thumbnail)
		{
			bitmapImage.SetSource(thumbnail);
			thumbnail.Close();
		}

        co_return bitmapImage;
    }

This is the fix, but I can't push it because I don't have write access.
    IAsyncOperation<BitmapImage> Photo::GetImageThumbnailAsync() const
    {
        auto thumbnail = co_await m_imageFile.GetThumbnailAsync(FileProperties::ThumbnailMode::PicturesView);
        BitmapImage bitmapImage{};

		// fix for when thumbnail is NULL
		if (NULL != thumbnail)
		{
			bitmapImage.SetSource(thumbnail);
			thumbnail.Close();
		}

        co_return bitmapImage;
    }

GetThumbnailAsync returns NULL when you attempt to open a file that looks to the file system like it might be a picture (it has .jpg or .png extension), but is actually not (ex: it is a text file someone renamed to .jpg).


include user group names for location map

Instead of name, include a comma separated list of unique user groups that held their events at that location.


Colspan table header element (th) for action buttons

Is it possible for action columns to have one (merged) value.
For example, can I easily name table header for two edit buttons action  label without css hacking

Currently it's not possible, unless you make some kind of custom partial.
I usually just remove action header borders with th.action + th.action selector and leave it empty.

Ok, I did the same with borders.
Maybe it could be a good feature to have ActionTitle property for such thing. I used to have it in similar custom grids.

How would an action title help? I'm seeing this as a column grouping feature.
It was requested a few times, but I can't think of a solution which would carry it's own complexity weight.

Ok, you can close this issue.
If I catch some spare time, I could try to create prototype.


host data verification

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Related Issue #
Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Summary by CodeRabbit
Release Notes

New Features

Introduced a new TEE field in the agent configuration to enhance security.
Added a manifest verification process to ensure the integrity of agent configurations.
Enhanced backend information fetching by requiring a computation ID for more accurate data retrieval.
Added a new method to retrieve VM configuration details.
New unit tests added to validate the functionalities of the agent module and backend information fetching.

Bug Fixes

Improved error handling in backend information methods to ensure correct VM configurations are used.

Documentation

Updated method signatures to reflect new parameters and functionality for clarity.
Adjusted CI workflow to require superuser privileges for running tests.
Configured coverage reports to ignore test directory files.

@coderabbitai summary

@coderabbitai summary


Upgrading to qiskit 0.7 removes some mandatory files in the qiskit directory

Informations

Qiskit Terra version: 0.6.1 -> 0.7
Python version: 3.6.7
Operating system: Ubuntu 18.10 (this issue may occur for any platform)

What is the current behavior?
If users upgrade qiskit 0.6.* to 0.7 by pip install -U qiskit, some mandatory files in the qiskit directory (site-packages/qiskit) will be removed while upgrading. It causes unintentional errors like #1582. Such users cannot use qiskit without any workaround.
Steps to reproduce the problem
$ # make a clean environment (you can use any environment management such as pyenv)
$ python3 -m venv ~/envs/test
$ source ~/envs/test/bin/activate
$ pip install -U pip setuptools wheel
$ pip install qiskit==0.6.1
$ pip install -U qiskit  # upgrade to 0.7
$ python
Python 3.6.7 (default, Oct 22 2018, 11:32:17)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import qiskit
>>> qiskit.__version__
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'qiskit' has no attribute '__version__'

What is the expected behavior?
$ # make a clean environment
$ python3 -m venv ~/envs/test
$ source ~/envs/test/bin/activate
$ pip install -U pip setuptools wheel
$ pip install qiskit==0.6.1
$ pip install -U qiskit  # upgrade to 0.7
$ python
Python 3.6.7 (default, Oct 22 2018, 11:32:17)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import qiskit
>>> qiskit.__version__
'0.7.0'

Cause
The main cause is pip install -U qiskit. It installs modules as follows.

Step 1. Install dependencies, qiskit-aer and qiskit-terra
Step 2. Uninstall qiskit==0.6.1
Step 3. Install qiskit==0.7
(I refer the steps later)

The file list of site-packages/qiskit when upgrading 0.6 to 0.7 is as follows.
circuit
converters
mapper
providers
__pycache__
qiskiterror.py
qobj
quantum_info
result
tools
transpiler
unrollers
unroll.py
validation

The file list of site-packages/qiskit when clean installing 0.7 is as follow.
circuit
converters
dagcircuit
extensions
__init__.py
mapper
providers
__pycache__
qasm
qiskiterror.py
qobj
quantum_info
result
schemas
tools
transpiler
unrollers
unroll.py
_util.py
validation
VERSION.txt
wrapper

There are missing files such as __init__.py when upgrading 0.6 to 0.7. The reason is as follows.

Step 1 installs qiskit-terra as dependency
Step 2 uninstalls qiskit==0.6.1. It removes some files such as __init__.py that are included in both qiskit==0.6.1 and qiskit-terra.
Although Step 3 installs qiskit==0.7, it does not have the removed files because they moved to qiskit-terra.

Suggested solutions
I recommend to write a document how to upgrade from qiskit==0.6.* to qiskit==0.7. This behavior of upgrading qiskit is unpredictable for users.
Users need to reinstall qiskit-terra to deal with this issue. Workarounds are as follows.
$ pip uninstall qiskit-terra
$ pip install qiskit-terra

or
$ pip install --force-reinstall qiskit-terra  # it takes a long time to reinstall all dependencies

or
$ pip install --force-reinstall qiskit  # it takes a longer time to reinstall all dependencies

Note that reinstalling only qiskit does not work because some files in qiskit-terra are still missing.
$ pip uninstall qiskit
$ pip install qiskit
$ python
>>> import qiskit
>>> qiskit.__version__
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'qiskit' has no attribute '__version__'

Thanks @t-imamichi  for reporting - it seems indeed that in some case the order of uninstalling and installing qiskit-terra is not correct, rippling in the issue you are experiencing. Indeed, some documentation would help (maybe at https://github.com/Qiskit/qiskit, as it already has a 0.6 to 0.7 stub) - in the meantime, let's leave the issue open during these holiday-ish days in case anyone experiences the same.

I had the same issue while installing qiskit, init.py was missing with several other. I used the workaround and it fixed the issue. thanks for sharing.


Should hint and Toolbox be consistent in "Lemon Leak"

Describe the bug
Should hint and Toolbox be consistent in "Lemon Leak"
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#
2.Tutorials---->Lemon Leak---->Start Tutorial
3.Click Step 4
4.Compare hint with toolbox
Expect behavior
Hint and Toolbox are consistent
Actual behavior
Hint: the value of vy is 100

Toolbox: the default value of vy is 50

Additional context
1.OS: Windows(rs6)
2.arcade version: 0.18.7
3.Microsoft MakeCode version: 6.1.22

Same issue  in "Throw a Bone" step 3.

This is a documentation bug, the hint should be updated

@riknoll
Same issue in "Happy Flower" step 4.

"Lemon Leak" python/JS tutorial step 4

"Free Throw" step 11

"Barrel Dodger" step 8


Local path provisioners is restarting with following error

 F0907 17:44:36.445267       1 controller.go:647] leaderelection lost
goroutine 1 [running]:
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.stacks(0xc00046c300, 0xc000694500, 0x45, 0xf1)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:766 +0xb1
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.(*loggingT).output(0x2009ca0, 0xc000000003, 0xc0002269a0, 0x1f910d1, 0xd, 0x287, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:717 +0x303
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.(*loggingT).printf(0x2009ca0, 0x3, 0x12e0f79, 0x13, 0x0, 0x0, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:655 +0x14e
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.Fatalf(...)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:1145
github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller.(*ProvisionController).Run.func2()
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller/controller.go:647 +0x5c
github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run.func1(0xc0000ce0c0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:148 +0x40
github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run(0xc0000ce0c0, 0x14c7de0, 0xc000171bc0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:157 +0x10f
github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection.RunOrDie(0x14c7e20, 0xc000046060, 0x14d4160, 0xc0000dcc60, 0x37e11d600, 0x2540be400, 0x77359400, 0xc00007f7c0, 0x1358910, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:166 +0x87
github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller.(*ProvisionController).Run(0xc0000c2b60, 0xc00018e600)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller/controller.go:639 +0x36f
main.startDaemon(0xc00032db80, 0x5, 0x4)
	/go/src/github.com/rancher/local-path-provisioner/main.go:134 +0x793
main.StartCmd.func1(0xc00032db80)
	/go/src/github.com/rancher/local-path-provisioner/main.go:80 +0x2f
github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli.HandleAction(0x10fb200, 0x1359218, 0xc00032db80, 0xc00037e600, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli/app.go:487 +0x7c
github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli.Command.Run(0x12d6eca, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli/command.go:193 +0x925
github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli.(*App).Run(0xc00016d6c0, 0xc00003a0c0, 0x4, 0x4, 0x0, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli/app.go:250 +0x785
main.main()
	/go/src/github.com/rancher/local-path-provisioner/main.go:166 +0x2b

hitting the exact same issue

Do you have multiple local path provisioners running at the same time? In that case, they will choose one to run, thus leaderelection lost for the others.

No, we don’t. Only apply the same exact yaml as the README suggested. Restarting 312 times within 12 days.

Any update on this ? Hitting the same issue.

@kumaya What's your Kubernetes version? Local Path Provisioner uses Kubernetes library for leader election. That logic is not even in the provisioner's code. So my guess is Kubernetes version might play a role here.

I am facing an issue when running this on a k3d cluster.  It works fine until I stop and restart the cluster.  The provisioner pod does not restart.  Workaround is to kubectl delete and kubectl apply the install manifest.

not stale

Not stale.

Not stale


Pin docs python

Let's pin all dependencies for our client so we don't run into issues during CI.
Dependabot will upgrade these over time but we will know what upgrades break us and don't outside of CI.
┆Issue is synchronized with this Jira Task by Unito

Not the path I'd choose, and worth noting it would not have prevented the earlier failures, but this is a valid implementation of pinning the dependencies if that's what the armada community wants to do.


Deep data source search

Expected behavior
Searching for data sources (CLI: cate ds list, GUI: search field) should be deep, meaning that also meta-data values should be matched.
Actual behavior
We only match data source names.
Steps to reproduce the problem
In the GUI:
Type land or ocean  to find Land Cover or Ocean Colour data in the search field.
No data sources found.
Type lc or oc  to find tem.
Specifications
0.8.0rc7.dev1

Fixed for GUI. as it uses it does the search in front-end code.


Missing Seeting jupyter.collapseCellInputCodeByDefault in v2021.11.1001550889

Environment data

VS Code version: 1.63.1
Jupyter Extension version (available under the Extensions sidebar): v2021.11.1001550889
Python Extension version (available under the Extensions sidebar): v2021.12.1559732655
OS: Windows
Jupyter server running: Local

Expected behaviour
In Settings, there should be some setting: "jupyter.collapseCellInputCodeByDefault" ( it was there in 1.60)
This setting should define whether Cell input should be collapsed or not.
Actual behaviour
currently this setting is missing, and therefor all Cell Input is shown.

Thanks for the issue. Looks like this regressed again.

As #8616 was closed as a duplicate of this issue, I'm chiming in here. I'm seeing the opposite behaviour described by @Jo5ta, i.e. code is always collapsed in the interactive window, irrespective of the value of jupyter.collapseCellInputCodeByDefault.
Environment data

VS Code version: 1.63.2
Jupyter Extension version (available under the Extensions sidebar): v2021.11.1001550889
Python Extension version (available under the Extensions sidebar): v2021.12.1559732655
OS and version: Windows 10 Enterprise, Version 20H2, Build 19042.1415
Python and/or Anaconda version: 3.6.8
Type of virtual environment used: venv
Jupyter server running: Local

Expected behaviour
Code cells run in the interactive window are expanded by default.
Actual behaviour
Code cells run in the interactive window are collapsed by default.
Steps to reproduce:

Set "jupyter.collapseCellInputCodeByDefault": false
Run code cell (# %%) or code selection in the interactive window by pressing Shift + Enter
Code (cell or selection) runs in the interactive window, but is displayed collapsed


Deploy test server

Either replacing or amending test.openquantumsafe.org with an instance running oqs-provider to also test integrations and OpenSSL3. Would also allow implementing https://github.com/open-quantum-safe/openssl/issues/388#issuecomment-1342703151

@bhess As a follow-up to our email conversation I now assigned this to you as I don't have access to the test server any more. Please confirm that you'll be able to have this complete by the end of next week as part of our liboqs release (confirmation) cycle.

Thanks @baentsch, will look into it next week.

Should there be (or is there already something like) a common.py for oqs-provider?
The script for OpenSSL 1.1.1 contains python structures with the available KEMs, Signatures and helper functions to create keys and certs, which is used by the deployment scripts for the test server. The alternative I see is to load generate.yml and create the algorithm list again, but there seems quite some logic involved in generate.py that I think is better not to replicate. @baentsch

The test server based on liboqs-0.8.0-rc1 is now ready at https://test.openquantumsafe.org.
For now it's based on oqs-provider/main. Will update to a oqs-provider release tag once ready.
I did a test run (https://github.com/open-quantum-safe/oqs-demos/blob/bhe-nginx-serverupd/nginx/fulltest-provider/testrun.sh), and all tests passed.
The ports offered by the test server are now restricted to Signartures+KEMs with matching security levels (exceptions are the pure rsa/ecdsa signatures as baseline).
Not sure if makes sense to advertise the Chromium-ready test ports as there seems to be no build against 0.8.0 at the moment. So I removed the Chromium page for now.

So I removed the Chromium page for now.

Perfect for me: We're not really supporting it, so we should drop the appearance of that, too.

@bhess: Release is tagged. Will mark final if you can close this issue after correct testing.

https://test.openquantumsafe.org is updated with liboqs 0.8.0 and oqs-provider 0.5.0, which includes generating the config using openssl list.
After a run with https://github.com/open-quantum-safe/oqs-demos/blob/bhe-nginx-serverupd/nginx/fulltest-provider/testrun.sh and the oqsprovider/curl image, all tests except the new x25519_kyber768 and p256_kyber768 hybrids pass. It looks like curl in the image doesn't support them yet. I also built a local version of the curl docker image, there everything works fine.

Thanks for integration and test -- https://github.com/open-quantum-safe/oqs-demos/pull/206 added to fix curl docker image for good and https://github.com/open-quantum-safe/oqs-provider/issues/181 to avoid this from happening again. This then closes this issue out.


Fix preemption.findCandidates for Hierarchical Cohorts

What type of PR is this?
/kind bug
What this PR does / why we need it:
Previously, we were only gathering preemption candidates from the nearest Cohort of the ClusterQueue. We update this logic to find ClusterQueues from the entire Cohort Tree.
Which issue(s) this PR fixes:
Fixes #3583
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Fix preemption when using Hierarchical Cohorts by considering as preemption candidates workloads
from ClusterQueues located further in the hierarchy tree than direct siblings.

/lgtm
/assign @mimowo

@gabesaba this looks clearly as a bug and does not entail any schema changes so we can cherry-pick to 0.9. WDYT?

/cherry-pick release-0.9


Refactor to parse code using ast instead of regex

Python comes with a built-in module for parsing its own code called ast for parsing the abstract syntax tree of Python code.
We should use ast instead of regex for creating logic bugs. First, we parse the code into an AST object. Then, we can modify the AST to reflect the logic bug we wish to create. Finally, we use a module like astor to convert the AST object back into Python source code.
Here is an example that can help solve #5 by accurately locating and selectively removing individual variables from global statements:
import ast
import random

def remove_random_global(tree):
    # Find all global statements and their parents in the AST
    globals_and_parents = [(node, parent) for parent in ast.walk(tree) for node in getattr(parent, 'body', []) if isinstance(node, ast.Global)]

    # If there are no global statements, return the original code
    if len(globals_and_parents) == 0:
        return

    random_global, parent = random.choice(globals_and_parents)
    if len(random_global.names) > 1:
        # Remove a single variable from the declaration
        random_var = random.choice(random_global.names)
        random_global.names.remove(random_var)
    else:
        # Remove the entire global statement
        parent.body.remove(random_global)

code = '''
a = 0
b = 1
result = 0
def fib_next():
    """ Computes the next Fibonacci number """
    global a, b
    global result
    a_temp = b
    b += a
    a = a_temp
    result = a
'''

tree = ast.parse(code)
remove_random_global(tree)
print(astor.to_source(tree))

Sample result:
>>> print(astor.to_source(tree))
a = 0
b = 1
result = 0

def fib_next():
    """ Computes the next Fibonacci number """
    global a
    global result
    a_temp = b
    b += a
    a = a_temp
    result = a

Notice that global a, b has changed to global a. Running fib_next() will return an UnboundLocalError: local variable 'b' referenced before assignment.
We can use similar techniques to introduce other types of logic bugs into Python scripts.
Furthermore, ast can also tell us if a Python program is formatted correctly. ast.parse will return the precise parsing error if not:
>>> ast.parse("5 = 5")
  File "<unknown>", line 1
SyntaxError: cannot assign to literal

See https://github.com/furlat/OpenBugger/blob/main/notebooks/ast_notebook.ipynb there is some todo at the end :) thanks for the input again


Breaking changes and samples, oh my

We have a problem that breaking changes to API & configuration can break samples. There are a couple of problems that need to be solved:

Customers should be easily directed to samples that are correct for the latest release of YARP
Customers should be able to build those samples pulling the appropriate package from nuget.org
Sample authoring should be against the current state of the packages build from /src - so if you make API changes, then you need to update the sample to match

To aid with this, I think we need to make the following changes:

[ ] Update the references in the sample to contain both a package reference and a project reference, with a conditional variable that selects which to use
[ ] Add the variable to the build scripts so that it applies for builds of the complete YARP tree, or by the build lab
[x] Add a latest tag to the releases so that we can link to just "latest" - this may be automatic but failing because we have the pre-release flag set.
[x] Add a readme to samples folder pointing users to the versions for the most recent release
[ ] Add a release output which is a zip of just the samples, along with any build.props files to ensure that they reference that version of the release, making it easier to get to the samples
or
[ ] publish the samples to a different project under YarpProxy that has a default branch for the most recent release

@MihaZupan @Tratcher @alnikola

Triage:
Plan discussed:

[x] Samples folder in repo will have project references
[ ] Release branches will reference nuget packages -- need to be part of release checklist


keep cursor at the same screen position after a reflow

This leaves the cursor at the same screen position it was at before the reflow. It fixes issue #22 and makes the behaviour match other editors such as emacs.

Another edge case:

If the Preferred Line Length is 80 and the cursor is at [0, 80], the cursor should end up at [1, 0]

Questions:

Since you're using getCursorScreenPosition, does the cursor position break if there is a fold or soft wrap in the text selection?

Thanks a lot for your comments. I agree, just saving the cursor screen position does not lead to the expected behaviour in the test cases that you mention. Therefore, I have expanded the code: I now search for the position of the cursor in the original text, and then convert this number back to a row and column using the reflowed text. I think this now leads to the expected behaviour. I have added two test cases to the specs, one where the cursor is supposed to move, and one where it isn't.

You may be able to significantly simplify the code by using a marker.

Thanks for pointing me in that direction. Did you have any particular idea in mind? I have played around with markers a little now, and I cannot seem to make them do what I want in this context. Basically, after calling
editor.getBuffer().setTextInRange(range, reflowedText)

markers seem to forget their positions.

Have you tried changing the invalidation scheme? Perhaps never would work?

Yes, I tried that too - it doesn't seem to affect the position remembered by the marker. The marker just moves to the end of the changed text. Or maybe I am missing something?

I'm going to make some time to test this out today and let you know. Thanks!

I have used this myself in production now for quite a while and it does improve my workflow quite a bit. However, it sometimes does not lead to the correct behaviour, namely when the code in reflow changes the length of the text by inserting additional spaces or comment characters. My solution then misses the correct cursor position by the amount of characters that were inserted before the cursor.
However, it is not clear to me how this corner case could be fixed without quite a bit of refactoring. One solution would be to insert a "secret character" at the cursor position before the reflow, then search for this secret character after the reflow and move the cursor towards it. A different solution could be to make reflow return the number of characters that it inserted, but this would add quite a bit of additional complexity to the code.
I would appreciate any opinions or comments on this. Meanwhile, maybe the solution in this PR is still better than the current behaviour?

Hi @sometea, thanks for sending this PR!
The Atom team is currently migrating many core Atom packages back into the main Atom repository.  autoflow is now being moved as a part of this migration!
Because it looks like we never came to a consensus on whether this was the right approach or if markers would indeed simplify the design, I'm going to close this PR for now.  I would highly encourage you to resubmit the PR to atom/atom once the migration is complete so that we can continue iterating on this design and eventually get it merged.
We really appreciate the time and effort you've invested so far!  Thanks again for contributing to Atom! :sparkles: :heart: :atom:


Misc minor code changes

Coverage decreased (-0.05%) to 46.11% when pulling d74f138c90daa69a3912c22dc2e04aec3cf8a4a0 on jitsni:misc into 5d7a56fbaca7ed811d1ba4eb91da80eb27b225b5 on kaazing:develop.

Maybe we shouldn't have coverage/coverails be so strict.  I can turn off the coveralls fail if test coverage decreases?
At the very least I don't think we should hold back this pull request because of this coveralls failure.


forceConsistentCasingInFileNames doesn't work for modules in node_modules

Bug Report

🔎 Search Terms

forceConsistentCasingInFileNames
node_modules

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about forceConsistentCasingInFileNames

⏯ Playground Link
Not available—requires node_modules folder
💻 Code
With forceConsistentCasingInFileNames enabled and fp-ts installed in node_modules:
src/struct.d.ts:
export const foo = 1;

// Expected error, but got none ❌
import * as xs1 from "fp-ts/lib/Struct";
// Expected error, but got none ❌
import * as xs2 from "fp-ts/lib/struct";
// Error as expected ✅
import * as xs3 from "./Struct";
// Error as expected ✅
import * as xs4 from "./struct";

🙁 Actual behavior
See code comments above.
🙂 Expected behavior
See code comments above.

We also have (even worse) trouble under Windows with fs.realpathSync.native() being used again since #44966.
On case-insensitive file systems, modules in node_modules are resolved to all-lower-case paths. tsc then tries to normalize that path, but if the original path contains upper-case letters and symlinks (Windows: junctions), fs.realpathSync.native() throws a "file not found" error, in contrast to fs.realpathSync(), which tolerates case differences and still normalizes the path.
The usage of realpath in sys.ts catches this error and returns the non-normalized path. Thus, in this case, normalization no longer happens!
In our concrete case, this leads to type errors in very subtle ways, because the same module is resolved in two different ways, so tsc regards a class imported from this module as different / incompatible.
Since this happens in a very large and complicated workspace, I am currently trying to set up a minimal example where this problem can be reproduced, which is unfortunately of course only possible under Windows and by using node_modules and junctions, so it cannot be a Playground example.

News on this:

...but if the original path contains upper-case letters and symlinks (Windows: junctions)...

It turned out this was not the root of the problem, but instead, the issue occurs when TypeScript tries to normalize paths with more than 260 characters using fs.realpathSync.native(), despite Windows' 260 character file path limit having been switched off.
So the fix could be to fall back to fs.realpathSync() (which can deal with long file paths) either when the path to resolve is larger than 260 characters, or, more safely, when a "file not found" error is thrown by fs.realpathSync.native().
I could create a dedicated bug report and a PR for that fix, but it would be quite hard to implement a test or even a reproducer, because the error only occurs under such specific, OS-dependent conditions.

@fwienber thank you for getting to bottom of this.. Have PR #50306 up to fix this.. Can you try the build out and see how it is working out for you. Bot should comment on the PR when the build is ready for you to try it out. Thanks

Already fixed and arrived on main branch! 😲
I'm really disappointed as I was hoping do do my first PR for TypeScript... just kidding, I'm thrilled that this is already fixed!
Retesting the fix with our workspace, I can confirm that the problem disappears.
Just one caveat: The logic explicitly checking for the 260 character limit might fail when calling the utility method with a relative path. Such paths are resolved against the current working directory (process.cwd()), and if the resulting absolute path is not within the 260 character limit, the call would still throw an error. But I guess tsc never relies on the current working directory, i.e. uses no relative paths when calling realpath, so everything should be fine.
My proposed alternative fix, catching all "file not found" (e.code === 'ENOENT') errors and then falling back to non-native realpathSync, would be more robust and avoid the "magic number" 260 altogether, but have the downside of "programming by exceptions", slowing down the build process even more when dealing with many long paths. So all in all, I think checking the path length is the better choice.
Thank you again for your fast reaction and fix!

One more thing, are you sure the original issue by @OliverJAsh is also resolved by this fix?
First, I assumed that our problem had to do with case sensitivity, too, but that turned out not to be the case. Maybe @OliverJAsh also used long file names, but it would be good to verify that.

Process question: Will there be a 4.7.x release with this fix? Or only 4.8.x? Or maybe even only 4.9?

My mistake that i somehow thought the additional debugging that @fwienber did was related to original issue. Keeping this open as it is separate issue.

Just one caveat: The logic explicitly checking for the 260 character limit might fail when calling the utility method with a relative path. Such paths are resolved against the current working directory (process.cwd()), and if the resulting absolute path is not within the 260 character limit, the call would still throw an error. But I guess tsc never relies on the current working directory, i.e. uses no relative paths when calling realpath, so everything should be fine.

Yes the paths are expected to be full paths so this should never arise and in almost all cases if this is because of using relative path the issue would need fix somewhere else to make sure path is not relative to current directory

My proposed alternative fix, catching all "file not found" (e.code === 'ENOENT') errors and then falling back to non-native realpathSync, would be more robust and avoid the "magic number" 260 altogether, but have the downside of "programming by exceptions", slowing down the build process even more when dealing with many long paths. So all in all, I think checking the path length is the better choice.

Precisely why we are checking the path length and not handling exceptions so that we dont get perf hit on common scenarios.

@sheetalkamat I can still reproduce this in TS 4.8, with a slightly different test case:
import * as xs1 from "fp-ts/lib/Struct";
// Error as expected ✅
import * as xs2 from "fp-ts/lib/struct";

import * as xs3 from "fp-ts/Struct";
// Expected error, but got none ❌
import * as xs4 from "fp-ts/struct";

@OliverJAsh  i dont think that case ever worked so that isnt regression per say.. This isnt something program can report easily either because package.json path's arent compared for file casing and typings for it points to lower case struct.d.ts so the resulting file will have correct casing.. So opening separate issue to track this


Emit task stats & fix up some assumptions

Split off from https://github.com/bpfkorea/agora/pull/1150

All LGTM but last commit


What is cx

I don't understand short form

CX is the custom search engine ID to use for the request. Here you can find the cx id look for My search engines then choose from the list.
Other link from Google Support.

I can't get the id when I click on the link it shows problem occurred


TS-4045: ts_lua improvements

3 things to accomplish in this jira

add support for TSHttpTxnDebugSet
protect http context pointer access in api calls
fix a spelling mistake from "truncked" to "truncated"

@jpeach , would really appreciate if you can take a look and review.

@bgaff - updated with using macro. thank.


Count the number of throttled log message and print it.

Description
We have recently increased significantly the delay for some throttled messages.
In order to get a better idea of the amount of messages, this PR adds a counter.
Checklist
inspected CI test results for throttled messages:

[x] Seen a message not throttled.
[x] Seen a message which was throttled.

Testing
With a container generating 100 zombie processes, the collector contains:
...
[INFO    2024/07/05 19:12:09] Successfully established GRPC stream for signals.
[INFO    2024/07/05 19:12:09] Found self-check process event.
[ERROR   2024/07/05 19:12:09] Could not determine network namespace: No such file or directory
[INFO    2024/07/05 19:12:10] Found self-check connection event.
[INFO    2024/07/05 19:12:19] self-check (pid=76) exited with status: 0
[INFO    2024/07/05 19:12:39] Flushing thread table
[INFO    2024/07/05 19:12:39] Flushing container table
[ERROR   2024/07/05 19:12:39] [Throttled 99 messages] Could not determine network namespace: No such file or directory
[INFO    2024/07/05 19:13:09] Flushing container table
[ERROR   2024/07/05 19:13:09] [Throttled 99 messages] Could not determine network namespace: No such file or directory
...

I will approve after merge conflicts are fixed.


refactor: setup histoire and workspaces

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[ ] Feature
[x] Refactoring

What's new?

[x] at first https://github.com/kodadot/nft-gallery/commit/bd3127f17a42c3d35bc5626d4f0a2a70be23aa0e, I want to move our nuxt app under the folder. but, to minimize the changes and we don't need turborepo right now. I decided to setup workspaces and histoire only. so, we can start to using it for new redesign page
[x] setup pnpm workspaces
[x] setup histoire
[x] please put newer component under @kodadot/ui
[x] a little example in components/landing/FeaturedArticles.vue

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Looking forward

it miss to link somewhere histoire doc
should we had lorem ipsum instead of actual content?

aahh yes, this is important. I forgot to add histoire doc link in the readme

can we handle Light/Dark mode variant globally? how is it going to work with multiple buttons variant?

need to find a workaround for light/dark mode globally

@preschian we were talking with @yangwao to rename the library to @kodadot/brick

because we are making building blocks
and should evoke the neobrutalism style

it is easy to pronounce

also maybe one thing: on npm we have org @kodadot1

@preschian we were talking with @yangwao to rename the library to @kodadot/brick

because we are making building blocks
and should evoke the neobrutalism style

it is easy to pronounce

also maybe one thing: on npm we have org @kodadot1

noted, will rename it 👍

conflictz :|


Latest version

What is the latest versiónof pivpn , on my pi i am running 1.9 and want to upgrade to latest version , how i do that ?

hi @soydepr
here you have all the info you need:
https://github.com/pivpn/pivpn/releases
https://github.com/pivpn/pivpn/wiki/Upgrading
Closing.

Thanks. Helpful. I do have one question. Which version of OVPN does pivpn uses now


Heading and Main CSS

made a few changes to the html:
I made the checkboxes into a list, the id is now "check-list"
put the main sections into a container titled "main-container"
i disabled the bulma stylesheet cause it was interfering with everything i was trying to do in my own css file, ill ask how to make it not do that on thursday
that should be every change i made to html.
i made a lot of changes to the css but thats my job
how it looks is still a work in progress. its 6am and i don't want to keep trying to figure out the stupid check boxes

I don't have a problem with CSS.
on HTML though, the bieFit button was an "input" of a type "submit". that's how I based my JS. but I see you changed it to a button?
Can you change that back? or is it mandatory for you to have the button element? If yes, I'll have to go and retouch on a few things then.


Asking for MHP-v2 dataset, please.

I download MHP-v2 dataset from offical website, but it's not contructed in COCO format. Could you please upload your processed MHP-v2 dataset? Thanks a lot.

@cool-xuan Hi, Do you have coco format data?


compiler error

compiler message:
Warning: Tried to initialize from a previous compilation (build/app.dill.track.dill), but the file was not self-contained. This might be a bug.
initialize_from.dill.gz

This is addressed in Dart 2.4 by https://dart-review.googlesource.com/c/sdk/+/105240/ .


Get number of remaining batches from iterator

I want to discuss the naming and spec of the iterator expansion, thus this is marked as WIP.
For efficient and correct multi-node evaluation remaining number of batches is an important information for multi-node evaluation coordinator, which behaves like rank==0 process in apply_iterator (although it does not stream batches but just send out all examples). This work is part of https://github.com/chainer/chainer/issues/7305 and will be followed with new multi-node evaluator pull request.
c.f. https://github.com/chainer/chainer/pull/7327

I personally told @beam2d that I concluded last night I can do those work without this change, should have closed this.


Issue with tf.keras.mixed_precision.experimental.LossScaleOptimizer

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.0
Python version: 3.6.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.0, 7.5
GPU model and memory: Titian RTX 24gb

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
When attempting to use tf.keras.mixed_precision.experimental.LossScaleOptimizer it fails to cast a matmul to float16
Describe the expected behavior
Matmul should cast to float16
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf
import numpy as np
from tensorflow.keras.datasets import mnist
gpus = tf.config.experimental.list_physical_devices('GPU')
if gpus:
try:
for gpu in gpus:
tf.config.experimental.set_memory_growth(gpu, True)
logical_gpus = tf.config.experimental.list_logical_devices('GPU')
print(len(gpus), "Physical GPUS,", len(logical_gpus), "Logical GPUS")
except RuntimeError as e:
print(e)
tf.keras.backend.set_floatx('float16')
tf.keras.backend.set_epsilon(1e-4)
model = tf.keras.models.Sequential()
model.add(tf.keras.layers.Conv2D(32, (3, 3), activation='relu', input_shape=(28, 28, 1)))
model.add(tf.keras.layers.MaxPooling2D((2, 2), padding="same"))
model.add(tf.keras.layers.Conv2D(64, (3, 3), activation='relu', padding="same"))
model.add(tf.keras.layers.Flatten())
model.add(tf.keras.layers.Dense(64, activation='relu'))
model.add(tf.keras.layers.Dense(10, activation='softmax'))
model.summary()
(train_images, train_labels), (test_images, test_labels) = mnist.load_data()
train_images = train_images.reshape((60000, 28, 28, 1))
train_images = train_images.astype(np.float16) / 255
test_images = test_images.reshape((10000, 28, 28, 1))
test_images = test_images.astype(np.float16) / 255
train_labels = tf.keras.utils.to_categorical(train_labels, dtype='float16')
test_labels = tf.keras.utils.to_categorical(test_labels, dtype='float16')
opt = tf.keras.optimizers.RMSprop()
opt = tf.keras.mixed_precision.experimental.LossScaleOptimizer(opt, "dynamic")
model.compile(optimizer=opt,
loss='categorical_crossentropy',
metrics=['accuracy'])
model.fit(tf.dtypes.cast(train_images, tf.float16), tf.dtypes.cast(train_labels, tf.float16), epochs=50, batch_size=64, steps_per_epoch=200)
test_loss, test_acc = model.evaluate(test_images, test_labels)
test_acc
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

I could reproduce the issue with Tf 2.0. Please take a look at the colab gist. Thanks!

@mattbernardini Try converting all the inputs to float32 and it should work fine. Please find my github gist here.

Right, that works for float32, but does not work for float16 which was the original issue.

@reedwm Can you PTAL?

@gowthamkpr I'm running into the same issue, trying to run float16 training. Not sure why you're casting to float32 in the .fit() method? Thanks!

I encounter the same problem with float16 training. So far I have figured out that the issue lies in the LossScaleOptimizer, because the issue disappears when you remove it (but then obviously losses are too tiny to be effective).
To be more specific, the error is raised when the LossScaleOptimizer calls its get_scaled_loss() function which simply multiplies (via python operator *) the loss with the loss_scale, which is an instance of tf.train.experimental.LossScale. See the code here.
def get_scaled_loss(self, loss):
    loss_scale = self._loss_scale()
    if callable(loss):
      return lambda: loss() * loss_scale
    else:
      return loss * loss_scale

The error says that the y input of the multiplication is float32 and the x input is float16. Since the multiplication in get_scaled_loss() is done like this: loss * loss_scale, this means that loss_scale is a float32. A few lines above we see that loss_scale = self._loss_scale(), and self._loss_scale is an instance of tf.train.experimental.LossScale.
Now, if we look into the source code of tf.train.experimental.LossScale here we see that the __call__() method of e.g. the DynamicLossScale (which is the one @mattbernardini uses) returns ops.convert_to_tensor(self._current_loss_scale). If we then check the initialization of self._current_loss_scale we see that it is initialized as float32:
self._current_loss_scale = self._add_weight(
    name='current_loss_scale',
    dtype=dtypes.float32,
    initial_value=self._initial_loss_scale)

So this is why the TypeError is thrown when using LossScaleOptimizer in float16 training. I am not exactly sure why LossScales were implemented to only return float32 values. There are also no clear online guides on how to do float16 training in TF 2.0, so it would be nice if someone who knows the details of how Tensorflow implements the optimization process could provide information on proper float16 training, because evidently neither tf.keras.backend.set_floatx('float16') nor     tf.keras.mixed_precision.experimental.set_policy('mixed_float16') seem to work out-of-the-box.

@verrannt, good investigation! In TF 2.1, this will be fixed. Alternatively, you can use the nightly builds with pip install tf-nightly-gpu which has the fix now. This has been fixed by casting the float32 loss scale to the dtype of the loss.
For reference, to do float16 training (typically referred to as mixed precision training), you always want to do the following
tf.keras.mixed_precision.experimental.set_policy('mixed_float16')  # Good

You do not want to set floatx to float16 with the following, unless you also set the policy to 'mixed_float16':
tf.keras.backend.set_floatx('float16')  # Bad!

The reason you want to set the policy instead of floatx is that the policy will keep variables in float32, which is necessary for numeric stability.
As for an online guide to do float16 training, I agree we need one and we will have one in the future. For now, the Policy API documentation has a brief guide on how to do mixed precision training


GH2491: TF build variables

Add additional Azure DevOps build variables

Implements #2491

@flcdrg your changes have been merged, thanks for your contribution 👍


restoring modifications to evaluate_concordance that are needed for hard filtering in joint calling

Evaluate concordance now outputs a table of thresholds per grouping
Parameter that allows extracting performance by info field value (e.g. variant_type)
Parameter that allows sorting variants by other column than TREE_SCORE

@doron-st PTAL - addressed all comments but one


Properly ignore files in chart folder

When calling http://localhost:3000/signalk/v1/api/resources/charts I get
{".DS_Store":{"identifier":".DS_Store","tilemapUrl":"/charts/.DS_Store/{z}/{x}/{y}","type":"tilelayer","scale":"250000"},".gitkeep":{"identifier":".gitkeep","tilemapUrl":"/charts/.gitkeep/{z}/{x}/{y}","type":"tilelayer","scale":"250000"},"NW205_2":{"identifier":"NW205_2","name":"LYSEFJORDEN","description":"LYSEFJORDEN","tilemapUrl":"/mapcache/NW205_2","scale":100000}}
The two former are from OSX (very annoying .DS_Store files popping up) and .gitkeep (I assume from git repo). Files starting with .should be ignored as otherwise they end up in charts listings as undefined

Or we could search through folders looking for tilemapresource.xml. If found, charts in the parent folder is added. That way, the user can structure maps of different types and enable a set of charts at a time, instead of one by one map.


Add integration test for Solrini

We need to create an end-to-end integration testing script written in Python that: sets up Solr, indexes a number of collections, runs search and outputs the trec_eval results, and tears down Solr.
The name of the collections to run on should be configurable (the generator and collection can be fixed like here) and we should be able to either specify an existing Solr server (i.e., via a --solr parameter) or setup/teardown a new one (as above) based on the Solrini instructions.

Ref #922

Closed by #922


scipy.signal.bspline does not work for integer types

scipy.signal.bspline gives zero output for integer types. This also affects quadratic and cubic.
Reproducing code example:
An example of an incorrect result
>>> from scipy.signal import bspline, quadratic, cubic
>>> bspline(np.array([-3,-2,-1,0,1,2,3]), 6)
array([0, 0, 0, 0, 0, 0, 0])

What was expected
>>> bspline(np.array([-3,-2,-1,0,1,2,3]).astype(float), 6)
array([2.17013889e-05, 1.56684028e-02, 2.28797743e-01, 5.11024306e-01,
       2.28797743e-01, 1.56684028e-02, 2.17013889e-05])

Scipy/Numpy/Python version information:
>>> import sys, scipy, numpy; print(scipy.__version__, numpy.__version__, sys.version_info)
1.7.0 1.21.1 sys.version_info(major=3, minor=7, micro=5, releaselevel='final', serial=0)

Thanks @poldap. Would you like to make a PR to fix this? I guess here we can just cast to the correct type as we already try asarray.

The PR is ready for you @tupui

I want to make my first contribution . Can I work on test case?

Sure, please do. Should be easy. Let me know if you need anything from my side.

Hello sir/mam, can I work on this?? If yes then this will be mine first contribution here!!!

PR has been made already at earlier date, your latest response is confusing to me @poldap. Is there anything left to be done?

Hello, is this issue still open? Would be interested to work on if so.

@kitsiosvas there is already an open PR (linked to this issue). Feel free to participate	in the discussion/review.

Is this issue still open? Would love to contribute


Add config for Linux 4.4

[x] Requires rebase after #6 was merged

Manually tested with gobpf, seems to work.

Ready for review / merge.

@schu Did CircleCI really built 2 kernels in 4 seconds? Did you use the "build in parallel" feature on CircleCI?

During the step "mv *.aci $CIRCLE_ARTIFACTS/", I would like the logs to indicate which files were copied exactly, and their size + a hash (sha1sum?).

Did CircleCI really built 2 kernels in 4 seconds? Did you use the "build in parallel" feature on CircleCI?

They have been build + cached before. Currently, stage1-builder only bundles a new aci image then.

Otherwise, the patch LGTM

During the step "mv *.aci $CIRCLE_ARTIFACTS/", I would like the logs to indicate which files were copied exactly, and their size + a hash (sha1sum?).

Done now.
Also includes a new commit d31c9b8 to use actool and not tar.

LGTM


Tabular Views for Comparing Baseline and Test Builds for Selected Platforms & Metrics

Background About Benchmarking
For benchmarking, we always launch several iterations of a benchmark with a specific build to get performance results for various metrics such as throughput and startup time. These relative numbers are not very useful since they could change when benchmark is run on another platform, when the machine state isn't identical or when the configs are slightly different. Hence, we always use a baseline to gauge the performance of a newer test build.
While comparing baseline and test builds, it's important to use a relative number (Build 1 Score/Build 2 Score) instead of an absolute number (Build 1 Score - Build 2 Score) to look at the performance gap since the absolute number doesn't really mean much, could change and could have significantly varying range.
We usually use this formula to comparison:

Scenario
Example   of Metrics
Comparison   Formula

Higher   is better
Throughput
Test   Build/Baseline Build

Lower   is better
Startup   time, Footprint
Baseline   Build/Test Build

Details about the Proposed Feature
Test Result Summary (TRS) should have the ability to create and show tabular views for comparing baseline and test build. Each view should show the relative comparison between baseline and test build in percentages corresponding to one specific metric and platform in a result cell. These result cells should be painted with different colors to classify the performance according to the table shown below.
Color Scheme for Result Cells

These tabular views would be extremely helpful in finding regression. I'm going to show the benefits of these tabular views with 2 examples.
Example 1:
SPEC Benchmarks

The tabular view above shows the results of all the SPEC benchmarks run on different platforms. From the results above, we can identify the following regressions easily:

x64 Regression (OS: Linux, Windows, macOS) for SPECjEnterprise & SPECjbb2015
Multi-benchmark Regression (SPECjEnterprise & SPECjbb2015) for x64 (Same as the 1st)
Single Platform Regression (Linux s390x) for SPECjbb2005

Example 2
Micro Benchmarks

The tabular view above shows the results of all the micro benchmarks run on different platforms. From the results above, we can identify the following regressions easily:

Cross-platform Linux Regression (HW: x64, ppcle64 & s390x) for ILOG ODM
Power Regression (OS: Linux & AIX) for HiBench

Requirements for Tabular Views
Basic requirements of this tabular comparison view:

Should show the relative comparison percent between baseline and test build for all platforms and metrics selected for that specific view.
Should the show the results of the latest test build against the latest runs for the baseline.
Should identify the score ranges with different colors.
Hovering over a result cell should show some basic information such as Java versions, confidence intervals and average scores
Open a new window with an unique URL when a result cell is clicked to show the full details of the runs such as score of each iteration for all metrics from those runs for both baseline and test build. This detailed view should be the same as the one shown when one clicks on the detailed view URL from the graph view, being developed for issue https://github.com/AdoptOpenJDK/openjdk-test-tools/issues/28.
Should be configurable to show different platforms and metrics that are selected by the user for that specific view.
Ability to show the historic data for all previous weeks. This ability would help in finding the first build that showed a regression.
Ability to use one baseline build with different test builds of the same platform, even though that baseline build may not have been interleaved (More details about interleaving here: https://github.com/AdoptOpenJDK/openjdk-tests/issues/850 & https://github.com/AdoptOpenJDK/openjdk-test-tools/issues/24) with any of those test builds. Let's say, you want to have 2 table views: one for comparing OpenJDK8-OpenJ9 GA vs OpenJDK8-Hotspot Latest and another for OpenJDK8-OpenJ9 GA vs OpenJDK8-OpenJ9 Latest. So we have 2 views, both of which use the same baseline OpenJDK8-OpenJ9 GA. While running these 3 builds, we could have interleaved the baseline build with one of the two test builds (i.e. OpenJDK8-OpenJ9), so we wouldn't want to run the baseline again with the second test build (OpenJDK8-Hotspot) since the baseline would essentially give the same score, a move that would save significant machine time.

Advance Requirements for Tabular Views

Ability to show "Best So Far" build from all the data (To be included in Graph Timeline view as well)
Ability to monitor specific cell
Ability to show the difference between current and previous week for all cells
Ability to show only the results cells that have changed since last week
Ability to check and uncheck a specific cell to monitor for possible regression
Ability to link a GitHub issue to one or more cells

Assigned Contributors
My team would work on adding this functionality.

@smlambert  had an excellent suggestion that we could leverage this tabular/matrix view design to display non-performance results as well such as functional and system tests.
I've put down a sample view to show one of the ways of how we could display the aggregate results of all Jenkins runs for various targets currently supported by OpenJDK that are mentioned here: https://github.com/AdoptOpenJDK/openjdk-tests. This view is just one of the options and it should certainly be updated to specifically meet the test team's requirements.
Each result cell could be used to show the percentage of tests that passed for a specific platform and target.
Summary of all Runs for Different Targets & Platforms

The tabular view above shows the results of various build lists run on different platforms. From the results above, we can identify the following issues easily:

Several "functional' failures" on all x64 platforms
Few "thirdparty_containers" failures on Windows x64
Several "openjdk_regression" failures on all Linux platforms
Few "jck" failures on all x64 platforms


add support to handle records with null value

tombstone records currently cause the sink-task to stop, as an exception is thrown. Added a new config property "behavior.on.null.values" to control this behavior in a more granular fashion. The following enum values are allowed:

ignore (default)
fail
log

Also added details (partition,offset) about which record is failing on the given topic.

@bionarkos thanks for the PR! Though I would like to validate first if this feature is actually needed.
Have you considered using transforms (a.k.a SMT) to filter1 tombstones2?
For instance, by adding:
{
    //...
    "transforms": "filter",
    "transforms.filter.type": "org.apache.kafka.connect.transforms.Filter",
    "transforms.filter.predicate": "isTombstone",
    "predicates": "isTombstone",
    "predicates.isTombstone.type": "org.apache.kafka.connect.transforms.predicates.RecordIsTo
mbstone"
}

you may get the same behavior without changes on the connector

Thank you very much @jeqo for the good tip, the filtering possibility solved my issue, so I can close this PR. :bow:


Error doing reasoning step

There are no imports - perhaps it expects some?
Preparing initial release, may take a few minutes, or longer if you depend on large ontologies like chebi
EXECUTING: cd src/ontology && make prepare_release && echo SUCCESS || echo FAILURE
robot  reason -i ontology-metadata-edit.owl -r ELK relax reduce -r ELK annotate -V http://purl.obolibrary.org/obo/ontology-metadata/releases/`date +%Y-%m-%d`/ontology-metadata.owl -o ontology-metadata.owl
robot convert -i ontology-metadata.owl -f obo -o ontology-metadata.obo.tmp && mv ontology-metadata.obo.tmp ontology-metadata.obo
cp ontology-metadata.owl ontology-metadata.obo ../.. &&\
	mkdir -p ../../imports &&\
	cp imports/*{owl,obo} ../../imports &&\
	git add ../../imports/*{obo,owl} &&\
	(test -f subsets/*owl && cp subsets/*{owl,obo} ../../subsets && git add ../../subsets/* || echo "no subsets") &&\
	echo "Release files are now in ../.. - now you should commit, push and make a release on github"
cp: imports/*owl: No such file or directory
cp: imports/*obo: No such file or directory
make: *** [prepare_release] Error 1
FAILURE
EXECUTING: git add src/ontology/imports/*{obo,owl}
fatal: pathspec 'src/ontology/imports/*obo' did not match any files
ERROR RUNNING: git add src/ontology/imports/*{obo,owl}
Exiting. Run with '-f' to force execution and ignore errors at ./seed-my-ontology-repo.pl line 203.

do you recall what your initial command was?

Hey, closing this issue due to long inactivity. Please re-open if necessary.


Integration of multipart

The current multipart-form-parser implementation is broken (because it uses cgi.FieldStorage(), which is broken).There was only a single working implementation (wekzeug) available, but that did not support python 3.x, so I started a new repository to address this issue: http://github.com/defnull/multipart
The new implementation passes all the werkzeug-tests (and some more), works with 3.x, is quite small (300 LoC if you strip out redundant stuff that is already part of Bottle) and already released. I would like to find a way to integrate this into bottle. See #66

The code used a lot of string concatenation. I think using format would be preferred. And I saw stuff like this self.dict.get(key) or [] .. Can't we try self.dict.get(key, []) in the design? And this return [default][index] is a bit hard to comprehend

Is there an update on this?
cgi.FieldStorage() seems still to be broken (with Python 3.4 at least) so an update of bottle on that topic would be great.


while network fails vagrant up suddenly quits without any warnings/report of failure

this may lead to some of the issues like whlie getting pods from the kubemaster-01 will get loaded some of the pods like:
kubectl get pods --all-namespaces
NAMESPACE NAME READY STATUS RESTARTS AGE
kube-system etcd-kubemaster-01 1/1 Running 0 2d
kube-system kube-apiserver-kubemaster-01 1/1 Running 9 2d
kube-system kube-controller-manager-kubemaster-01 1/1 Running 0 2d
kube-system kube-scheduler-kubemaster-01 1/1 Running 1 2d
[these are the only running files]
"couldn't find some of them"

This was an earlier implementation of vagrant where kubeadm init was pulling the kubernetes images from google repos, with the new implementation of vagrant, we are using customized boxes which are pre-packaged with all the kubernetes images and the failure of vagrant up during these image pulls is taken care of.

Closing based on the comment above


Bad rendering when attempting to remove a blockquote - Iss187

Problem
Bad rendering when attempting to remove a blockquote #187
When you clear the editor and start typing something show a text placeholder
But if you use another type of text has a bug

Reproduce

Solution
Draft.js default hides text placeholder with a class and doesn't has spacing style
But, I created a switch case to push a class on each type with a position

@JeanPinzon


Question: Recommended amount of reviews before optimizing?

Is there a minimum recommended amount of reviews one should have before running the optimizer?
For example, if I have 5 cards that have only been reviewed three times each, I imagine that this is not enough to warrant running the optimizer as it could lead to bad weights. If this is the case, what is the minimum amount of reviews before optimization makes sense?

We have considered it here:
https://github.com/open-spaced-repetition/fsrs-rs/blob/ea80c61ac0cfc6847a19d0ea3d63eaae4947e87c/src/training.rs#L211-L227
If the reviews are not enough, the optimizer will just return the default parameters, or just skip training.

Makes sense. Also, I really need to learn Rust at some point!


Core dump enabled on node-disk-manager for debugging

node-disk-manager do not dump core if panic happened. This issue is created to support core-dump in node-disk-manager.

I am closing this issue as I have created another PR #181 for same


Various mem leak fixes

Coverage decreased (-0.05%) to 78.224% when pulling 6f99f517e080284d3d465573d73bcfe4eb834b53 on martinm-memperf into f265c00307d04d9334c38e2aacaa04876e254871 on master.


[CSGO] 404 on update

Hey guys, not sure if this is a huge issue or not, but apparently im getting a 404 on the CSGO update command, is there a way to fix this?
[spoiler][img]https://t.co/ztdzv8E2FY[/img][/spoiler]

I got this until I synced up with github again. There have been some changes and restructuring recently it seems.

Yeah, i have seen that as well in the main files. i just need my server to be able to get updated and running for a stress test that im doing. Worked on it for 3 days and i don't wanna loose my progress.

./csgoserver update-functions

Works! Thanks you! Please close this now as the server is now updating itself :)


Faster validations + add validation for point tag keys

@panghy
The validation is definitely faster.  But now there's more =)  Hopefully it will balance out.

on synthetic benchmark the validation takes 1/3-1/4 of the time it used to.


Ensure Data from lookup is always a hashtable

Right now, the lookup function returns data of different types, depending on the file extension - this makes it very hard to do anything with (e.g. pass into Get-DSCSplattedResource or as ConfigurationData).
The change here ensures complex data from lookup is always a hashtable (or a credential / array / simple type).
This approach resolves issue #4 - you should be able to run
 | ConvertTo-ProtectedDatum -UnprotectOptions $DataOptions | ConvertTo-Hashtable

regardless of the extension, and get the same object back.

In light of #17 , an option would be to drop SecureDatum as a concept and merely run ConvertTo-Hashtable on all data sources. This could then run Unprotect-Datum for any strings that match the encrypted block (and continue to convert any objects apart from PSCredential objects back into hashtables)
I think this might be worth doing to keep things simple. The hidden decryption property & scriptblock property doesn't prevent access to the data without running the scriptblock anyway, e.g.
PS C:\> $datum = @{normal=1;evil='[ENC=s";Write-Host "HACKED";$e="]'} | ConvertTo-ProtectedDatum -UnprotectOptions @{ClearTextPassword='doesntmatter'}
PS C:\> # Access data and decryption secret without executing scriptblock
PS C:\> [Runtime.InteropServices.Marshal]::PtrToStringAuto([Runtime.InteropServices.Marshal]::SecureStringToBSTR($datum.unprotectparams.password))
doesntmatter
PS C:\> $datum.psobject.properties.getterscript

                $Base64Data = "[ENC=s";Write-Host "HACKED";$e="]"
                [SecureDatum]::Unprotect($Base64Data.Trim(),$this.UnprotectParams)


jsonld validation test should allow charset?

My image server is currently failing validation on the jsonld test. Should it be valid to allow a charset to be set along with the content-type? This is the output:
[2] test jsonld FAIL
  url: []
  got: application/ld+json; charset=utf-8
  expected: application/ld+json
  type: json-ld

Fixed


StoredFile image not displayed as background in container component

Describe the bug:
The stored file image is not working properly when used as a background on the container component, but it works fine when used on the image component. When entering the storedFile ID, the image is not instantly pulled for the background.
To Reproduce:
Steps to reproduce the behavior:

Go to 'https://function-adminportal-test.shesha.dev/dynamic/TestModule/Backgroud'
Click on the container to view its properties
Scroll down to Background.
On the background type dropdown, select "image"
On the image source type drop-down, select "storedFile"
Enter the storedFile ID (E.g 97621427-1517-4974-892e-59b9851c8503)

Actual Results:
The background image is not displayed on the container after entering the storedFile id.
Expected Behavior:
The background image should be displayed on the container when using a storedFile image source type. The behavior should be the same as the image component.  Upon entering the storedFile ID the image must be pulled instantly.
Screenshots:

Related to #1789


Update Pod Security Admission docs for graduation to stable

Update the PSA docs for stable release in v1.25
Includes:

Update feature state references, remove feature gate reference.
Remove references to PSP (note this conflicts with https://github.com/kubernetes/website/pull/33512)
Remove webhook instructions, as the built-in controller is now widely available, and the webhook is not well supported.

/assign @liggitt

/lgtm

/sig auth

/milestone 1.25
/assign @didicodes
/cc @kcmartin

/label tide/merge-method-squash

/remove-label tide/merge-method-squash
2 commits are fine.

Changes since https://github.com/kubernetes/website/pull/35618#issuecomment-1201879678 are not material.
/lgtm
/approv

/approve


feat(vcs): Support Sapling in jest-changed-files

feat(vcs): Support Sapling in jest-changed-files
Summary: Currently, jest only supports git and hg repositories.  This commit
adds sl to the support version-control system
Test Plan:
$ yarn jest e2e/__tests__/jestChangedFiles.test.ts e2e/__tests/onlyChanged.test.ts

Co-authored-by: Simen Bekkhus<EMAIL_ADDRESS>
Stack created with Sapling. Best reviewed with ReviewStack.

-> #13941

@SimenB thanks for adding the changelog!  The way Sapling works is it makes a separate PR for each commit in the stack.  It sounds confusing but becomes much simpler to review in ReviewStack.
Given that, I have three options:

absorb my fixes, and then submit my changes.  This will result in three PRs opened (this PR, the PR for removing unintended changes, and the changelog PR)
fold your two commits into this commit.  This will result in one PR, but if intend on doing a merge commit instead of squashing, you'll lose the individual commits (I can add you as a co-author, though)
Abandon using Sapling (ironically) for this PR and just git push to this branch?

Heh 😅 easiest for a GH workflow is to just keep pushing commits to it - we squash on merge anyways. You could collapse the changes, but that makes it harder to review.
I guess you could PR your own branch, but that wouldn't show up here. So yeah... Option 3? 😅

Heh 😅 easiest for a GH workflow is to just keep pushing commits to it - we squash on merge anyways. You could collapse the changes, but that makes it harder to review.
I guess you could PR your own branch, but that wouldn't show up here. So yeah... Option 3? 😅

whoops.  Didn't read this and did did option 2.  I can revert.
By the way, the way Sapling works for forks is that each commit in the stack separately targets main.  On non-forks, the third PR targets the second PR, etc.

Perfectly fine 👍 the diff isn't huge here, so no problem reviewing

You could collapse the changes, but that makes it harder to review.

I think ReviewStack makes this easier, but I agree it's still awkward combining Sapling with GitHub.  Facebook already has tons of tooling to integrate with GitHub reviews, and it's ironic that there aren't tools (yet) to work well with Sapling.
For example, facebook-github-bot has no knowledge of stacks, making it hard to review stacked diffs.  We've been having this problem in the Sapling repo, where the review and CI tools don't work well with Sapling 😁

@vegerot hmm, the tests are failing for me.

@SimenB
#worksonmymachine 😁

In all seriousness, I landed https://github.com/facebook/sapling/commit/9192b33fff56205a4cabbc42c589b9b1ccd8c570 recently which adds a few extra revset aliases.  I'm guessing that's what you're missing

@vegerot your screenshot is without sapling 😅

not gets mixed git, hg, and sl SCM roots and dedupes them as expected

whoops, I wrote this patch on my other computer 😳.  Alright, let's not make that same mistake again
❯ yarn jest e2e/__tests__/jestChangedFiles.test.ts
 PASS  e2e/__tests__/jestChangedFiles.test.ts (60.051 s)
  ✓ gets hg SCM roots and dedupes them (3411 ms)
  ✓ gets git SCM roots and dedupes them (791 ms)
  ✓ gets mixed git, hg, and sl SCM roots and dedupes them (2136 ms)
  ✓ gets changed files for git (5200 ms)
  ✓ monitors only root paths for git (691 ms)
  ✓ does not find changes in files with no diff, for git (1781 ms)
  ✓ handles a bad revision for "changedSince", for git (1996 ms)
  ✓ gets changed files for hg (13300 ms)
  ✓ monitors only root paths for hg (1578 ms)
  ✓ handles a bad revision for "changedSince", for hg (3657 ms)
  ✓ gets sl SCM roots and dedupes them (1949 ms)
  ✓ gets changed files for sl (17002 ms)
  ✓ monitors only root paths for sl (1694 ms)
  ✓ handles a bad revision for "changedSince", for sl (4192 ms)

Test Suites: 1 passed, 1 total
Tests:       14 passed, 14 total
Snapshots:   0 total
Time:        60.893 s
Ran all test suites matching /e2e\/__tests__\/jestChangedFiles.test.ts/i.

❯ sl log -r . -T '{node}'
92630a6fadcb4a2a4b57ab4fcf6400d37594c142

❯ sl --version
Sapling 4.4.2_20230222_095031_cadebf93bc49

❯ sl config
alias.commit=commit --verbose
alias.fgo=!$HG goto $($HG log -T '{graphnode} {sl_date} {sl_diff_super} {sl_desc} {shortest(node)}\n' --rev "draft() or interestingmaster() or interestingbookmarks()" | fzf --preview="$HG show \$(awk '{print \$NF}' <<<{})" | awk '{print $NF}')
alias.sst=!$HG status && $HG ssl
commands.new-pull=true
commitcloud.automigrate=false
experimental.copytrace=off
extensions.autopullhoisthotfix=!
extensions.commitcloud=!
extensions.github=
extensions.infinitepush=!
extensions.remotenames=
extensions.treemanifest=
merge-tools.nvimDiff.args=-d $local $other $base -c 'redraw | echomsg "hg merge conflict, type \":cq\" to abort vimdiff"'
merge-tools.nvimDiff.executable=/usr/local/bin/nvim
merge-tools.nvimDiff.priority=100
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>remotefilelog.reponame=jest.git
remotenames.autopullhoistpattern=re:tags/\S+$
remotenames.autopullpattern=re:^[A-Za-z0-9._/-]+/\S+$
remotenames.disallowedto=^remote/
remotenames.disallowhint=please don't specify 'remote/' prefix in remote bookmark's name
remotenames.hoist=remote
remotenames.publicheads=remote/master,remote/main
remotenames.rename.default=remote
remotenames.selectivepull=true
remotenames.selectivepulldefault=main,master
smartlog.names=main,master
smartlog.repos=remote/
templatealias.sl_hash_minlen=1
tweakdefaults.defaultdest=
ui.editor=nvim
ui.username=Max 👨🏽💻 Coplan<EMAIL_ADDRESS>

Newer version of sapling, that might be why. I installed from homebrew, but maybe that's not automatically updated?

https://github.com/facebook/jest/releases/tag/v29.5.0


Fix crash issue if wasm file is malformed(armv7 32bit)

Environment

cpu: armv7
platform: android

aot file content like following will cause runtime to crash in 32bit system(the value of p is overflow):
00 61 6F 74 03 00 00 00 00 00 00 00 60 2B 05 E3

malformed.aot.zip

Environment

cpu: armv7
platform: android

aot file content like following will cause runtime to crash in 32bit system(the value of p is overflow):
00 61 6F 74 03 00 00 00 00 00 00 00 60 2B 05 E3

malformed.aot.zip

@JavanZhu Thanks for reporting the issue! Your fix might be not complete and some spec cases run failed. I updated have the patch according to my understanding, could you help review and test it?


Pipeline: A new way of compiler bootstrapping

This PR introduces a series of restructuring operations on the core compiler workings:

hash_ast no longer contains any parsing-related code; this is up to each parser to implement.
hash_pipeline is a new crate which contains bootstrapping logic for the compiler. For one, this includes traits Parser and Checker for implementations of parsing and typechecking. These are currently implemented by hash_parser and hash_typecheck respectively. Finally, the Compiler type manages Parser and Checker, and is able to keep checker state between interactive invocations.
The Modules type has been removed in favour of Sources. Sources does not allow concurrent access, and as such performance should be improved. Furthermore, Sources keeps track of both interactive blocks as well as modules, and keeps the sources, AST, and filenames for each one of these.
hash_parser now contains a new implementation of parallel parsing, using a channel and rayon threadpool to delegate parsing jobs. This design is much simpler and most likely more performant (although benchmarks are required to verify this).

Closes #99.