Delay running slot lambda until after the render_in block

Feature request

It would be nice if slot lambdas were not called until after the block passed to render_in is called.
Motivation

Sometimes I need to change the behaviour of a slot depending on the existence of another slot. A good example of this is a form field component that supports displaying an error message:
class FieldComponent < ViewComponent::Base
  renders_one input, ->(type: "text") { text_field_tag name, value, class: ("error" if error?), type: }
  renders_one error
end

If this component is rendered like this:
render FieldComponent.new do |field|
  field.with_error { "Error message" }
  field.with_input
end

then the error class is added as expected, however the following does not include the error class as error? returns false:
render FieldComponent.new do |field|
  field.with_input
  field.with_error { "Error message" }
end

Unfortunately in this scenario the code reads better if the with_input comes first. If the lambda was called after the block finished this would not be an issue. I believe this would also be the expected behaviour for most people as you would expect the order of calling with_ methods for renders_one slots to not matter.

A hacky proof-of-concept workaround is to have the lambda return a component:
class DelayedRenderComponent < ViewComponent::Base
  def initialize(&block)
    @block = block
  end

  def call
    block.call
  end
end

class FieldComponent < ViewComponent::Base
  renders_one input, ->(type: "text") do
    DelayedComponent.new { text_field_tag name, value, class: ("error" if error?), type: }
  end
  renders_one error
end

Looks like it would be fairly easy to update the implementation here to support it
https://github.com/ViewComponent/view_component/blob/88cec826bb43eb070f66acd0b243b22f29f7e178/lib/view_component/slotable_v2.rb#L354-L374
Instead of calling the function and playing with the value it should be possible to create a basic class which calls the function in its render_in method, then set that to the slot.__vc_component_instance.
I don't have time to dig further now, but I think I'll have time in the next couple of weeks to look at implementing it.

@TastyPi thanks for writing this up. I'm cautious changing this behavior as I could imagine others depending on the existing behavior.
Looking at your specific example, perhaps you could set the error as part of the input slot instead of having separate slots?

So I want to be able to use the component something like this:
<%= render FieldComponent.new do |field| %>
  <% field.input(...) %>
  <% field.error do %>

      <% errors.each do |error| %>

<%= error %>
      <% end %>

  <% end %>

There are definitely ways I could make this work other than forcing the input to be rendered lazily, e.g. setting the error slot first, specifying error: true somewhere it can be used in the input slot, or moving the CSS class to a parent of the input element and have the CSS work with that structure.
My bigger problem is the behaviour is inconsistent and undocumented. For example, I would expect slots like these to always behave the same way:
renders_one :eager, ->() { render MyComponent.new(...) }
renders_one :lazy, ->() { MyComponent.new(...) }

However, if the slot depends on another component they behave differently.
I understand not wanting to introduce breaking changes, but with version 3 coming up I think it would be nice to make this behaviour consistent (and documented) with said major version bump. There are two options I believe make sense - render the slot when the slot setter is called (eager), or render the slot when it is first used while rendering the component (lazy). Obviously my use-case would work better with the lazy behaviour, but I'd also be fine with eager and picking a different workaround, I'd much rather the behaviour be consistent. When I was first building the component I found it confusing when error? would not always work, if the behaviour of when a slot is rendered was predictable and documented it would have saved a lot of confusion.
There's also this very contrived example where the behaviour differs but in a way that favours eager rendering:
class ExampleComponent < ViewComponent::Base
  renders_one :eager, ->(&block) { render ExampleSlotComponent.new(block) }
  renders_one :lazy, ->(&block) { ExampleSlotComponent.new(block) }
end

class ExampleSlotComponent < ViewComponent::Base
  def initialize(block)
    @block = block
  end

  def call
    @block.call
  end
end

<%= render ExampleComponent.new do |example| %>
  <% x = 1 %>
  <% example.eager { x } %><%# renders 1 %>
  <% example.lazy { x } %><%# renders 2 %>
  <% x = 2 %>
  <% example.eager { x } %><%# renders 2 %>
  <% example.lazy { x } %><%# renders 2 %>
<% end %>

Personally, I kind of think eager rendering is more intuitive but lazy rendering is more useful, so it comes down to what's more important for view_component.

I can see why it might be misleading, but the behavior here is consistent, which is that the lambda is always eagerly evaluated.

Fair enough, I hadn't thought of it from that angle but I do agree that makes sense.

I think we could document the difference between returning an object that responds to render_in vs returning a string if it's not already, though.

This would be the main I want,

I can see why it might be misleading, but the behavior here is consistent, which is that the lambda is always eagerly evaluated.

Fair enough, I hadn't thought of it from that angle, but I can agree that it makes sense. I do still think that returning a component or returning the string from rendering a component should result in the same thing, but that's just an opinion that would have been immediately changed if I was corrected by the documentation. Speaking of...

I think we could document the difference between returning an object that responds to render_in vs returning a string if it's not already, though.

I couldn't find it mentioned anywhere, I would expect to find it here https://viewcomponent.org/guide/slots.html#lambda-slots.
If all that changes from a result of this issue is a documentation update (and maybe a test to ensure the behaviour doesn't change) I'd be happy with that.
(BTW I don't need more solutions to the specific example I gave, I have plenty of options and the component it was originally based on is very different now. Your first solution with the set_error is quite nice though.)

If all that changes from a result of this issue is a documentation update (and maybe a test to ensure the behaviour doesn't change) I'd be happy with that.

I'd be happy with it too. Would you be up for writing a PR?


Imperial County, California Data Request

emailed Imperial County -<EMAIL_ADDRESS>http://www.co.imperial.ca.us/Assessor/FIRelease.html
data here: http://services.geoviewer8.com/arcgis/rest/login?redirect=http%3A//services.geoviewer8.com/arcgis/rest/services/ImperialCounty_Public/MapServer/

This is a dup of https://github.com/openaddresses/openaddresses/issues/2207.

Sorry!? Wasn't in download for counties and in us west


The broker will close client connection  exceptionally

Environment

VerneMQ Version:1.9
OS: centos
Erlang/OTP version (if building from source):
VerneMQ configuration (vernemq.conf) or the changes from the default
Cluster size/standalone:

Expected behavior
We have a client subscription a topic. And this client processing of data is slowly.  The broker will hold this connection. and this client will receive all message.( we have to set the max_online_messages = -1, qos = 0)
Actual behaviour
The client will be closed and waiting to reconnect. And we can continue to receive some data even if the connection is closed. The max_online_messages parameter affects the connection situation.  We think this situation is caused by an internal queue overload. Is there any way to monitor this situation and how fast the client message processing speed can be to avoid being closed?

Please include minimal steps to reproduce the issue, if possible.

Hi, I'm not sure I understand the question.Do you have some logs showing why the client connection is closed and what the reason is? Is it the client or the broker which terminates the connection?

Thanks a lot , It seems this log:
09:04:08.147 [warning] session stopped abnormally due to '{send_failed,{error,timeout}}'

Interesting. I would think this is because writing to the outgoing socket times out. Is this an SSL connection or plain TCP?

It is on tcp. We used  org.eclipse.paho.client.mqttv3. We found that the client will limit the acceptance of messages. When the receive queue is full, the length of the receive queue is 10.  We don't know if this will cause client disconnection. In some scenarios we see broker logs:
stopped due to keepalive expired.
/**
* This method is called when a message arrives on a topic. Messages are
* only added to the queue for inbound messages if the client is not
* quiescing.
*
* @param sendMessage
*            the MQTT SEND message.
*/
public void messageArrived(MqttPublish sendMessage) {
final String methodName = "messageArrived";
if (mqttCallback != null) {
// If we already have enough messages queued up in memory, wait
// until some more queue space becomes available. This helps
// the client protect itself from getting flooded by messages
// from the server.
synchronized (spaceAvailable) {
while (running && !quiescing && messageQueue.size() >= INBOUND_QUEUE_SIZE) {
try {
// @TRACE 709=wait for spaceAvailable
log.fine(CLASS_NAME, methodName, "709");
spaceAvailable.wait(200);
} catch (InterruptedException ex) {
}
}
}
if (!quiescing) {
messageQueue.addElement(sendMessage);
// Notify the CommsCallback thread that there's work to do...
synchronized (workAvailable) {
// @TRACE 710=new msg avail, notify workAvailable
log.fine(CLASS_NAME, methodName, "710");
workAvailable.notifyAll();
}
}
}
}

Does this seem to be a write timeout caused by the underlying TCP send queue being full?

That would be my guess, but what puzzles me is that I wouldn't expect this error to pop up in this case. For TCP we send that data to the socket here https://github.com/vernemq/vernemq/blob/master/apps/vmq_server/src/vmq_ranch.erl#L334 which I would guess is what produces the error, though according to the erlang docs I don't think it should produce that error...

Closing for inactivity. Feel free to add further information.


Auto deploy master to a staging URL

This is task is to auto deploy the master branch of the starter kit to a staging URL, perhaps, storefront.reactioncommerce.com
Requirements:

[ ] Deploy and configure an instance of reaction with sample data found here: https://github.com/reactioncommerce/reaction-catalog-sample-data
[ ] Deploy an configure an instance of Keycloak

The reaction instance can be any url, as it's not meant to showcase reaction, but the storefront.

@spencern looping you in...

@willopez we'll need to make sure that there's a GraphQL API exposed somewhere as well

@spencern the /graphql-alpha path is mounted on reaction, the dev server is only for development purposes.

This was done. The URL for the staging env is https://starterkit-staging.devops.reactioncommerce.com/. I'll create a PR for my changes.


Fix broken memprocfs download link

The download link of the 5.8.17 version does not exist anymore and has to be replaced with the newest release 5.9.3.
I updated the version in the nuspec, the zipUrl and zipSha256.
I tested it on my own VM and after the changes the package installed with no problems.
(I did not create an Issue because it was in the Daily Failures)

Thanks for the PR @citharus ! However, I don't think we should use the URI you provide as the versions are archived quickly. So, the last version we can get to work is : https://github.com/ufrisk/MemProcFS/releases/download/v5_archive/MemProcFS_files_and_binaries_v5.9.4-win_x64-20240318.zip
Could you change you PR accordingly ? Also could you please squash your commits (in order to maintain a clean commit history) ?

LGTM, I've tested and it works well.


The Weather Network false positive (images.twnmm.com)

images.twnmm.com
this domain included in the lists blocks images and video hosting for website https://theweathernetwork.com

Thank you for this Rohan @rnnc.
On what platform are you experiencing this?  Seems functionally fine here on PC.
By the way, the Weather Network doesn't get a free pass here.
Try this experiment: open a browser window, activate an inspection and watch the network tab. Then open the weather network, and peruse a forecast or two.
Observe: a torrent of heinous inbound garbage, hundreds of network requests. Stopping this nonsense is what we do here.
I'm gonna close this issue because, frankly, we presently don't block enough weather network shenanigans.
So this isn't a false positive but, rather, a reminder that we're not doing enough to control this bad weather network behavior.

sorry getting to this late, but it's happening on PC for me
but i understand the reasoning


[fix]added placeholder for gws and opendata

Coverage increased (+13.08%) to 81.372% when pulling 6fd72b147bcdc3856248886b626f31cab4af0457 on HiraiY:fix/add_placeholder into e4286d56c493cf2bb14989f15b63df65d9846dd9 on shirasagi:master.


OriginValidator.validate failed when validate the request options from the android device by WebAuthnRegistrationRequestValidator

If the registration is sent from an Android device, it will have the format:
{
  "type": "webauthn.create",
  "challenge": "Vdpc4dM8SEKGCOv9gbBpTg",
  "origin": "android:apk-key-hash:-s dwJA3hvue3mKpYrOZ9zSPC7b4mbgzJmdZEDO5w",
  "androidPackageName": "com.foodeyfrontend"
}

The origin is no longer a domain address. Is there a way to change the implementation class of OriginValidator or to support additional origins for Android?

Good question. webauthn4j-spring-security compares origin value with an Origin contained in a ServerProperty provided by ServerPropertyProvider interface. ServerPropertyProviderImpl is the default implementation of ServerPropertyProvider and it takes Origin value from HTTP request host, but you may implement your own ServerPropertyProvider implementation, and provide expected Origin value you like. You can register your ServerPropertyProvider implementation through WebAuthnConfigurer.

Thanks for your answer. By the way, have you ever used react-native-passkey? I call the webauthn/assertion/options to get the publicKeyCredentialRequestOptions, but when I add it into Passkey.authenticate(options), it throws NoCredentialException. Is there something I missed?


Azure hosting bug - The specified CGI application encountered an error and the server terminated the process.

Azure site returns error message "The specified CGI application encountered an error and the server terminated the process." if SSL certificate is set in in Main() for Kestrel as follows:
var application = new WebHostBuilder() ...
.UseKestrel(options => { options.UseHttps("xxxx.pfx", "1xxxxx"); })
.UseIISIntegration()
.UseStartup()
.Build();
application.Run();

You can't use https on kestrel when hosted in front of IIS (which is how azure websites hosts you).

So how to detect if an app is hosted in front of IIS?

Maybe something like this?
KestrelServerOptions kestrelOptions = new KestrelServerOptions();
kestrelOptions.AddServerHeader = false;
kestrelOptions.<some_other_option> = <value>;
var pairingToken = Environment.GetEnvironmentVariable($"ASPNETCORE_TOKEN");
if (!string.IsNullOrEmpty(pairingToken))
{
    kestrelOptions.UseHttps("xxxx.pfx", "1xxxxx");
}
...
var host = new WebHostBuilder()
    .UseKestrel(kestrelOptions)

@halter73 this looks like a similar error to the other thread we saw. Have you been able to repro it to at least understand why it throws?

@xatabhk When are you not running behind IIS?

@xatabhk When are you not running behind IIS?

obligatory "Azure Service Fabric" mention :laughing:

@davidfowl  I don't know actually. Behind IIS or not I see no difference in code.

Not sure what you mean. Do you have plans to run your program with just kestrel (btw that's not recommended for the public internet). If you're running behind IIS and I don't think you need to detect that, then you configure ssl there not in your application.
If you plan to run on azure website then you're running on IIS and I'd recommend running IIS express locally (since your target is IIS)

@xatabhk

configure ssl there not in your application

https://azure.microsoft.com/en-us/documentation/articles/web-sites-configure-ssl-certificate/

@xatabhk Then you can use the code I posted above, which should detect running behind IIS based on the pairing token. In theory, that should work ... but @Tratcher and @davidfowl are the real experts here, so they'll give us the word on it.

@GuardRex Yes that should work, but I think your polarity is reversed:
if (string.IsNullOrEmpty(Environment.GetEnvironmentVariable($"ASPNETCORE_TOKEN")))
{
    kestrelOptions.UseHttps("xxxx.pfx", "1xxxxx");
}

That said, I'd still like to see the exception that's preventing it from working without this workaround.

Oooops! :smile: ... yeah ... cut-and-paste out of the repo code got me. Thx. It's fixed now.

@davidfowl Not planning, just doing tests and don't want to tie an app to IIS. Also no this issue with IIS Express in VS IDE.

@Tratcher I was able to successfully get Kestrel's sample app running  behind ANCM with UseHttps. It makes sense considering that the address provided by the module is HTTP, so the HTTPS connection filter isn't used.
@xatabhk Are you able to use HTTPS locally without IIS? Are you sure your publishing your pfx file to the correct location? If the pfx file isn't where the app expects you'll see an error like the following even at startup if HTTPS isn't used:
Unhandled Exception: System.Security.Cryptography.CryptographicException: The system cannot find the file specified.
   at System.Security.Cryptography.CryptographicException.ThrowCryptographicException(Int32 hr)
   at System.Security.Cryptography.X509Certificates.X509Utils._QueryCertFileType(String fileName)
   at System.Security.Cryptography.X509Certificates.X509Certificate.LoadCertificateFromFile(String fileName, Object password, X509KeyStorageFlags keyStorageFlags)
   at System.Security.Cryptography.X509Certificates.X509Certificate2..ctor(String fileName, String password)
   at Microsoft.AspNetCore.Hosting.KestrelServerOptionsHttpsExtensions.UseHttps(KestrelServerOptions options, String fileName, String password) in C:\Users\shalter\dev\Universe\KestrelHttpServer\src\Microsoft.AspNetCore.Server.Kestrel.Https\KestrelServerOptionsHttpsExtensions.cs:line 51
   at SampleApp.Startup.<>c.<Main>b__1_0(KestrelServerOptions options) in C:\Users\shalter\dev\Universe\KestrelHttpServer\samples\SampleApp\Startup.cs:line 55

You could enable stdout logging to try to see what error is happening. Make sure that the logging directory is published, because it will not be automatically created for you. You might also need to enable console logging in your application.

@Tratcher @GuardRex Yes. The workaround works. But IIS Express does not need this workaround, so there may be a fix.

@halter73 Everything is OK locally, self-hosted or IIS Express hosted.

@xatabhk When are you not running behind IIS?

obligatory "Azure Service Fabric" mention :laughing:

Not sure what you mean. Do you have plans to run your program with just kestrel (btw that's not recommended for the public internet).

I'd assume interconnected microservices that communicate directly with each other using Kestrel (either webapi or websockets) rather than a different network protocol (e.g. FabricTransport, Wcf, RabbitMQ, custom TCP etc).
If its an internet exposed cluster you would only have one gateway microservice exposed, which would be fronted by IIS (or multiple using hostname differentiation - which would also need IIS/http.sys); but you wouldn't use IIS as a layer between each microservice - however you may want to use https to secure the comms.


Updating build process

Upgrade of the path to download spark on Apache website (URL and version updated) solves Issue #13
Upgrade of Atlas maven build, adding an option to bypass hortonworks certificate issue
Correction on pip installation of amundsenatlastypes, adding RH packages to have Python Dev Libs and Dev Tools for package compilation

Thank you @Prjprj !


Question: What's the podfile swift_version variable for?

PromiseKit version: 4.4
Xcode version: 9.0 Beta 7
CocoaPods version: 1.3.1
Carthage version: N/A

Before all, I'm sorry If this is somehow a stupid question, but I've been scratching my head with this. 😛
I was reading your documentation on how to use Swift 4, and it states to use:

swift_version = "4.0"

However unless I actually add a post_install rule on the podfile to force the SWIFT_VERSION to 4.0 on all pods then the swift version will always be set to 3.2
Note: Also the same documentation points to a "swift4-beta1" which does not exist.

if you set swift_version to 4.x, you should use the Xcode 9.x +, Xcode 8.x not contain Swift 4.x environment

Yes, I'm using XCode 9, as stated in my first post. The thing is when I do pod install, with swift_version = "4.0" in my podfile, the Pod PromiseKit framework is always using 3.2 instead.

you can try to look over the current swift version in your system by commond xcrun swift -version,
and make sure have swift4.x environment, or use swiftenv library to control the swift version.

According to the CocoaPods documentation swift_version in the Podfile controls the Swift version used for the generated project.
That's all I know. If you need to know more you will have to ask team CocoaPods.

I have removed this instruction as it no longer seems recommended by CocoaPods.


Fragment shading rate loses device on resize

Resizing the window on the Fragment shading rate causes a lost device on next frame draw.

What platform does this happen? The sample resizes fine for me on Windows 10 with an RTX 2060. Do you get a validation layer message before the device lost?

Happens in Linux no validation error

I figured out the bug; we have the same one in our fragment shading rate dynamic sample we're working on.  The problem stems from invalidating the image views before calling the super class resize().  This is fine if the resize doesn't follow the easy out of checking to ensure the new size isn't the same as the previous size before calling the create_framebuffer() call which both of our samples override.
I have a fix I'm including in our sample and I went ahead and fixed it in the fragment shading rate sample too.


update doc

更新API文档，修正 createForm 下的 changeValue.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thaks for PR, @all-contributors please add @whj1995 for doc.


Handling dependencies that have multiple providers

I'm trying to build bitwarden_rs-vault and bitwarden_rs-postgresql. The former depends on anything that provides bitwarden_rs, of which the latter does. Unfortunately, there doesn't appear to be a way for me to tell aurutils that this is the case. It therefore proceeds to also build bitwarden_rs. This wouldn't be a big deal except for the fact that Building any of the bitwarden_rs packages (except Vault) is an expensive time-consuming operation. Building it once is bad enough, building it twice takes forever.
This issue is further compounded by a make dependency that both bitwarden_rs (non-vault) packages have: they depend on rust-nightly. While this is an actual package on the AUR, it can also be provided just fine by rustup. Unfortunately, again, there's no way for me to tell aurutils that it should just install rustup. This means I have to wait for rust-nightly to compile, which is even more expensive to build than one copy of bitwarden_rs.
It would be great if I could specify which option should be used when there is a dependency with multiple providers.
As an aside, even if I could use rustup with the build process, it isn't clear how I would actually go about preparing it to be used when building inside of a container. Do you have any advice for this?

Default --provides was added to master a while ago: https://github.com/AladW/aurutils/commit/dd22f4d4d9b182ea573c63002e03850fd3268990
An interactive menu or general way to choose between providers outside of providing manually on the command-line can't be done (efficiently), because the AUR does not support search by provides.
As to rust, I don't know the language so I have no concrete suggestions.

@djmattyg007 does that work for you or do you have more questions?

How do I make use of this functionality if I'm on the latest stable release 2.3.3?

--provides

I'm confused. The commit you linked to isn't in a tagged release yet, so I'm not sure how I could make use of the functionality in it yet. If it's not necessary and the functionality does exist in 2.3.3, I'm not sure what the purpose of linking it was for. Also, if the functionality does exist in 2.3.3, judging by that commit the public interface for it will be changing in the next version, so implementing something now that I already know I'm just going to have to change in future seems counterproductive.
And to be honest, it isn't particularly clear how I should be using these flags in either case (before or after the commit you linked to). Your example command at the start of your message doesn't actually use the --provides flag, and there doesn't appear to be any examples in the man page of how I should be using --provides and --ignore together.

You take aur sync in the comment above and replace it with aur sync --provides. This should be clear from reading --provides in the 2.3.3 aur-sync(1) manual.

What is the purpose of including the --ignore flag at the same time? Is there any situation where you would want to use --provides but not --ignore?

--provides applies to an entire repository, --ignore only to specific
packages. You can leave out the --ignore flag if you first build those
packages that offer the desired provides, then their dependencies in a
second command.
That's the best you can do without native support from the AUR API to
query provides. Some AUR helpers use heuristics to simulate this, but
this results in an exponential increase of API requests (potentially
locking you out with an HTTP 429 "Too Many Requests" error).
On 10/06/2020 11:58, Matthew wrote:

What is the purpose of including the |--ignore| flag at the same time?
Is there any situation where you would want to use |--provides| but
not |--ignore|?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/AladW/aurutils/issues/721#issuecomment-641894612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKASJBRUTMUTNI6MS7TLKDRV5KLXANCNFSM4M6LXXPQ.


Ensure the searcher has a larger z-index than welcome buttons

Currently, the "New" and "Import" buttons in the welcome message show above the searcher, if they should overlap.  This seems to be because both the buttons and the searcher are given a z-index of 10 and the buttons show up later in the DOM.  I'm guessing that there's a reason the buttons must have the z-index they do, so I've upped the z-index of the searcher-container to ensure it's comfortably over the buttons.

Awesome, thanks!


OpenResty support

This will ensure all flavors of Chef Server (OSC, OPC, OHC) are using the same bundle of Nginx for load balancing. It also allows OSC to take advantage of the HttpLuaModule for more complicated routing logic.

(I'm doing some cleaning of PRs) Given that OSC is no longer being actively worked upon, I'm going to close this PR.


(feat) update hyper to 0.14

Fixes #73

This doesn't compile. Can you make sure you run check and tests locally via:
cargo check --no-default-features --features=hyper_client

cargo test --no-default-features --features=hyper_client

Sorry, let me check later today

It seems the main branch doesn't compile on wasm either, due to error from getrandom.

@Fishrock123 it compiles on all targets. However, because the getrandom dependency was introduced in http-types, I'm not sure if it's good to add target check here

@sunng87 Could you add a separate feature flag for this? That we we can land it sooner.

@Fishrock123 I'm not quite sure if a feature flag could fix this. Could you please show me some detail about that?

I've just run into this via https://github.com/http-rs/surf/issues/295, is there any action to follow this up?

this could work but needs to be under a versioned flag, e.g. hyper-014

@Fishrock123
Do you mean that you prefer a feature flag such as:
[features]
wasm_getrandom = ["getrandom/js"]`
wasm_client = ["...", .. "wasm_getrandom"]]

Instead of:
[target.'cfg(target_arch = "wasm32")'.dependencies.getrandom]
version = "0.2.2"
features = ["js"]

Otherwise, can you elaborate so we can get this merged soon? :)

Please review this PR, it would be great to be able to use surf with Tokio 1.0 :-)


Add support for printf style formatting

Adding support for printf style file sequences as already supported by Katana.

❤ Happy to see this added

Thanks for this work btw, @walrusVision! I wasn't aware Katana supports printf padding now (or did). It is a bit weird to call this "printf":   /path/to/file.1-10%04d.ext"   since that string is not directly useful to printf, with the "%04d" being an advisory padding format. But I can see how they would use sequences without a range:  "/path/to/file.%04d.ext"

Cheers for comment. I'll start fixing those up now.
As for the name it is a bit weird, but all the examples and documentation I saw between nuke and katana, referred to it as the 'printf format'. I did see one example which called it 'printf syntax padding' which might be a better name?

Tagged and released v1.3.0. Thanks for the work!


Error: Class Zend\Filter\FilterPluginManager contains 1 abstract method...

With latest update I received this error:
PHP Fatal error:  Class Zend\\Filter\\FilterPluginManager contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Zend\\ServiceManager\\AbstractPluginManager::validatePlugin) in /var/www/vendor/zendframework/zend-filter/src/FilterPluginManager.php on line 0

Somebody know why?

Hitting the same error @pensiero .  Maybe Zend\ServiceManager\AbstractPluginManager changed?

Resolved specifying the exact version of zend-filter in composer: "zendframework/zend-filter": "2.5.*",

Same here this thing is broken

You likely have defined composer constraints that are bringing in the dev-develop branch, which contains changes to work with zend-servicemanager v3. We're still working on updates that will allow that branch to work with either v2 or v3, but the point is: you're getting unstable code currently.
Pin your zend-filter dependency to ^2.5 to ensure you get a stable version in the 2.5 series.

Thanks @weierophinney


[GLUTEN-7458][VL][FOLLOWUP] Install devtoolset-9 for centos7 static build image

What changes were proposed in this pull request?
Install devtoolset-9 for centos7 static build image to support branch 1.2 GHA.
How was this patch tested?

@wForget, thanks for your pr!
Another thought is we can install gcc-9 in velox_backend.yml only for branch-1.2. Thus, we don't need to maintain such code in main branch when branch-1.2 is EOL in the future.

@wForget, thanks for your pr! Another thought is we can install gcc-9 in velox_backend.yml only for branch-1.2. Thus, we don't need to maintain such code in main branch when branch-1.2 is EOL in the future.

Makes sense, thank you, I will try that.


In the new version, Route is imported as a type rather than a method.

Describe the bug
I've set up a new Solid project and then installed the latest version of the router(0.13.4). Although the router is functioning properly, within vscode, Route is being imported as a type instead of a method.
Then, I downgraded the router's version to 0.13.3, restarted vscode, and everything worked as expected.
Your Example Website or App
sry, i don't have
Steps to Reproduce the Bug or Issue

pnpm create solid
pnpm add @solidjs/router
pnpm install
use Router and Route

Expected behavior
no error in vscode
Screenshots or Videos

Platform

OS: Windows
Browser: Edge

Additional context
No response

I think this is due to my change #432
It should export both, lemme check...

Created an reproduction repo before I saw this issue. Here it is in case it helps: https://github.com/jsimonrichard/solid-router-0.13.4-route-type-error-mre

Same question


Fix -log-file so that it can log to a file.

Currently the file is opened via os.Open() which is a read-only shortcut to os.OpenFile(). This generates error if a file doesn't exist and bad stuff if you actually try to log something.

👍


typo: Double word "your"

@nschonni : Thanks for your contribution! The author, @cynthn, has been notified to review your proposed change.

Merging typo fix


 This should help improve compilation time for Go SDK
Introduced changes are:

Flatten go structure
Remove use of generic helper methods

as well as GetDeserializationMethodNameAndFactory


Pinned Pygments to <2.4.0 on Python 3.4

No review needed.

Coverage remained the same at 38.188% when pulling d399e6c34a31be98414a533fa6a24a2f19579b01 on andy/fix-pygments-py34 into 59425de4446111fb4c5c96cf198d1a5ce0cc1a89 on master.

Coverage remained the same at 38.188% when pulling d399e6c34a31be98414a533fa6a24a2f19579b01 on andy/fix-pygments-py34 into 59425de4446111fb4c5c96cf198d1a5ce0cc1a89 on master.


⚠ gorzdrav.org has degraded performance

In ac5dffb, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 3901 ms

Resolved: gorzdrav.org performance has improved in 1aef503.


Add back orders

Add back field orders to graph, move orders from FeynmanProperties to field in FeynmanGraph.
Add orders(g::Graph) and orders(g::FeynmanGraph) helper functions.
Remove unnecessary parametric types (use idiom v::AbstractVector{<:AbstractT} instead of v::AbstractVector{T} ... where {T<:AbstractT}).

Codecov Report
Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a724e61) 61.24% compared to head (9af118e) 61.15%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   61.24%   61.15%   -0.10%
==========================================
  Files          56       56
  Lines        3427     3437      +10
==========================================
+ Hits         2099     2102       +3
- Misses       1328     1335       +7

Files
Coverage Δ

src/computational_graph/feynmangraph.jl
91.44% <100.00%> (ø)

src/computational_graph/graph.jl
95.12% <100.00%> (+0.38%)
:arrow_up:

src/computational_graph/optimize.jl
93.57% <100.00%> (ø)

src/quantum_operator/expression.jl
96.55% <100.00%> (ø)

src/computational_graph/abstractgraph.jl
75.75% <66.66%> (ø)

src/backend/static.jl
41.37% <50.00%> (ø)

src/computational_graph/io.jl
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error: Could not process new slot, unknown finalized root" prefix=blockchain

I am getting this error in the beacon chain logs:
msg="Could not process new slot" error="0x0000000000000000000000000000000000000000000000000000000000000000: unknown finalized root" prefix=blockchain
Am I missing some configuration?

same issue.

Fixed

how was that fixed ? I still have it

@BrunoAura is it with the DockerDesktop (maybe even on MacOS)?
It works fine for Rancher Desktop, but not for Docker Desktop.


Missing starknet/os/data_availability module in PyPI cairo-lang package

Hello cairo team,
I noticed an inconsistency between the cairo-lang library on PyPI and the GitHub repository. Specifically, the folder starknet/os/data_availability is available in this repository but missing from the package on PyPI.
Issue Details:

Expected Behavior: The PyPI package should include all necessary directories, such as starknet/os/data_availability, to allow necessary imports.

Observed Behavior: The cairo-vm repository, which relies on the PyPI version, cannot import certain functions from os/data_availability due to its absence in the package.

This issue can also be noted on the latest tag on this repo.
Files in question:

https://github.com/starkware-libs/cairo-lang/blob/master/src/starkware/starknet/core/os/data_availability/commitment.cairo
https://github.com/starkware-libs/cairo-lang/blob/master/src/starkware/starknet/core/os/data_availability/bls_field.cairo

Closed because version 0.13.3 was released


Create Report Generator for HTML Reports

Implement a report generation utility that creates HTML reports using the Jinja template engine.
Acceptance Criteria:

[ ] Develop a method for generating HTML reports in the ReportGenerator class.
[ ] The report generator creates an HTML report using the Jinja template engine based on provided listing data.
[ ] The HTML template includes placeholders for the listing data.
[ ] The generated report is saved locally.

Additional Context:
Example template structure:

            Listing ID
            Listing Address
            Policy X Violation
            Policy Y Violation
            Policy Z Violation

        {% for listing in listings %}

            {{ listing.listing_id }}
            {{ listing.listing_address }}
            {{ listing.policy_x_violation }}
            {{ listing.policy_y_violation }}
            {{ listing.policy_z_violation }}

        {% endfor %}

The generated report is saved locally <=== this shouldn't be saved, just generate the report as in memory data that's good enough. we have report repo which can used to be save the data, which could be in file or uploaded or w/e


PR validation pipelines with Rush

This PR adds ci.yml files to each of our data-plane SDK folders (I think I got them all - based on Rush output). I've also added/updated a few .npmignore files to make sure that the ci.yml file doesn't get slurped into the NPM packages.
Once these are merged I'll run the pipegen tool over the repository to create all of the definitions.

PackageName must be the full name of the package as declared in the package.json file, e.g. "@azure/service-bus"

We should also always pass --verbose to Rush commands, since by default, STDOUT output is suppressed.

PackageName must be the full name of the package as declared in the package.json file, e.g. "@Azure/service-bus"

So at the moment I've got this working with the value being "storage-queue" (as an example). Is that not supposed to work, or does it produce a different result. More than happy to adjust it I just want to understand the difference in the two approaches :)

So at the moment I've got this working with the value being "storage-queue" (as an example). Is that not supposed to work, or does it produce a different result. More than happy to adjust it I just want to understand the difference in the two approaches :)

Huh, you're right it seems to work! The documentation is pretty clear that this should be the full package name as it is written in the package.json, but for some reason it seems to work without the @org/ prefix. I'd suggest we stick to the documented format, just in case this is a bug that is eventually fixed.

Just a couple small tweaks

Done - just waiting for the builds to finish and then I think its there.


Debugging yeoman: no breakpoint is hit

Refs: https://github.com/Microsoft/vscode/issues/19039

check out our code generator (https://github.com/Microsoft/vscode-generator-code)
npm install
generate a config to debug the yo man generator
add a breakpoint e.g. into index.js line 43 or even the constructor
run it
=> no breakpoint hit for me

@bpasero when running yeoman from the project, it was always using the globally installed code generator in ~/.npm-packages/lib/node_modules.
After removing ~/.npm-packages/lib/node_modules/generator-code and running npm link in the project folder (which creates a symbolic link in ~/.npm-packages/lib/node_modules, hitting breakpoints worked fine.
Using npm link is the official way to develop and test yeoman generators.


SecResponseBodyMimeType should support regex

There are mixed content types that we could match using regexes, like application/vnd.api+json. It would be useful to use a regex to match them all.

I see this something we could cover on 3.1
On Fri, 24 Mar 2023, 19:14 Juan Pablo Tosso, @.***>
wrote:

There are mixed content types that we could match using regexes, like
application/vnd.api+json. It would be useful to use a regex to match them
all.
—
Reply to this email directly, view it on GitHub
https://github.com/corazawaf/coraza/issues/736, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYASQURTZV5OEFS4W6BLW5XQBBANCNFSM6AAAAAAWG4IMQI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Bringing this back to life

What are the implications of not having a proper parser when matching some content types? This could lead to bypasses, right?


feat: add tracking to partner page website clicks

The type of this PR is: Enhancement
Description
This PR adds tracking to clicks from Artsy to external partner pages.
Slack context

Some quick demo
https://user-images.githubusercontent.com/3513494/175058061-2e09b293-c955-4dd2-81b0-13db0650e3f6.mp4


option to control tab size in output

Is there anyway to control the tab size in the output.  I'm working on project with 4 space tabs but the output uses 2 space tabs.

if you're using the API, pass in {..., format: {indent: {style: "    "}}, ...} as options. It's currently undocumented, unavailable from the CLI, and I assume there is no guarantee it will remain stable. You can see the other options for format here.

apparently GitHub doesn't preserve whitespace in inline code

That's just HTML.

It's currently undocumented

It was documented previously, I probably just missed it when rewriting the documentation. @sebmck Are there any other undocumented options right now?

@thejameskyle Not sure, you can go through file.js and generator.js for all the options.

@monsanto Thanks.  I updated my gulpfile and that did the trick.


settings-modal: Only update display if overlay loaded in DOM.

If the personal / organization settings overlay has not been loaded to the DOM in the user's session, then there's no need to update the overlay display for changes to the user's permissions to update their name, email or avatar.
So we add a checks for the relevant element ids before updating the overlay display when the user's role or these organization settings change.
Follow-up to #23964.
Notes:

The call to avatar.build_user_avatar_widget has an expectOne assertion, so the avatar widget update (update_avatar_change_display) is the only one that's causing a blueslip error.
It seemed like a good pattern to check/assert for these elements in the DOM in general though, since there's no guarantee that the user has opened their settings overlay during their session.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@sahil839 - Could you take a look at this update? It fixes a case I missed (permissions are changed when the user has never loaded the settings overlay in their current session) when testing the changes to the upload avatar widget live updates in #23964.

@sahil839 - Thanks, that makes sense and is a clearer pattern. I've updated so that all the checks have an early return pattern.

Looks good to me.

@timabbott - This should be good for you to review for integration. Fixes a bug caused by changes to live update behavior for the user avatar upload widget in #23964 where the widget was not found if the user hadn't opened the settings overlay in their current session.
@zulipbot add "integration review"

Merged, thanks @laurynmm!


MailChimp API v2 is depreciated

"MailChimp API v3.0 is now live! Prior versions will no longer be supported after 2016, so all API users should begin transitioning to v3.0. Check out the API v3.0 Documentation for more details."

Yip aware of this. If I get some time will need to rewrite however would appreciate some help if others are using this module :+1:

We have until Dec, 31 2016 before they cut the V2 API.

May need to replace the current mailchimp/mailchimp library with a v3 API wrapper - this seems to be the most popular on Packagist - https://packagist.org/packages/drewm/mailchimp-api


unable to recover after an upgrade

What did you do?
upgrade to newer version or prometheus
What did you expect to see?
clean start
What did you see instead? Under which circumstances?
crash
Environment
WARN[0007] Lost at least 9 chunks for fingerprint de012972ecd6f680, metric tunein_taps{country="DE", instance="localhost:9301", item="s236774", job="prometheus", source="browse"}.  source=crashrecovery.go:116
panic: runtime error: makeslice: cap out of range

goroutine 1 [running]:
panic(0x18b2120, 0xc446690260)
        /usr/local/go/src/runtime/panic.go:500 +0x1a1
github.com/prometheus/prometheus/storage/local.(*persistence).recoverFromCrash(0xc420362c60, 0xc4200a90b0, 0x1, 0x17bdd20)
        /go/src/github.com/prometheus/prometheus/storage/local/crashrecovery.go:119 +0xb82
github.com/prometheus/prometheus/storage/local.(*persistence).loadSeriesMapAndHeads.func1(0xc420362c60, 0xc445e859e8, 0xc4200a90b0, 0xc445e859d8)
        /go/src/github.com/prometheus/prometheus/storage/local/persistence.go:817 +0xf6
github.com/prometheus/prometheus/storage/local.(*persistence).loadSeriesMapAndHeads(0xc420362c60, 0xc42000e500, 0x0, 0x267d540, 0xc420010190)
        /go/src/github.com/prometheus/prometheus/storage/local/persistence.go:840 +0x3f5
github.com/prometheus/prometheus/storage/local.(*MemorySeriesStorage).Start(0xc420238b00, 0x0, 0x0)
        /go/src/github.com/prometheus/prometheus/storage/local/storage.go:374 +0x1f5
main.Main(0x0)
        /go/src/github.com/prometheus/prometheus/cmd/prometheus/main.go:181 +0x114f
main.main()
        /go/src/github.com/prometheus/prometheus/cmd/prometheus/main.go:43 +0x22

System information:

uname -srm
Linux 4.4.0-62-generic x86_64

Prometheus version:

./prometheus --version
prometheus, version 1.5.2 (branch: master, revision: bd1182d29f462c39544f94cc822830e1c64cf55b)
build user:       root@a8af9200f95d
build date:       20170210-14:41:22
go version:       go1.7.5

Alertmanager version:
insert output of alertmanager -version here (if relevant to the issue)

Prometheus configuration file:

insert configuration here

see
https://github.com/prometheus/prometheus/issues/1873#issuecomment-283317692
for reference

The code should handle this case more gracefully (by discarding this series and move on), but the root cause is a data corruption in the checkpoint file. Most likely you will have more corruptions, so even with the more graceful behavior in place, you might not be able to recover much.

Got it.
Should we close this issue? Or keep it opened ?
sent from a 📞

On Mar 6, 2017, at 14:57, Björn Rabenstein<EMAIL_ADDRESS>wrote:
The code should handle this case more gracefully (by discarding this series and move on), but the root cause is a data corruption in the checkpoint file. Most likely you will have more corruptions, so even with the more graceful behavior in place, you might not be able to recover much.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'll take it as a reminder to fix the code as described above. Will change title.


Where do i find which version of pyright pylance is using?

I'm running into an inconsistency between pyright CLI and pylance, and would like to know which version of pyright pylance is using.
It seems that information isn't easily accessible, though.
Where could I find out which version of pyright my current pylance version is using?
If I can't easily find out, consider this a feature request.

You can find our current pyright commit id at the top of your Pylance log ("Python Language Server" in the Output window). For example, here's mine:

[Info  - 9:21:10 AM] (37848) Pylance language server 2022.7.20 (pyright 7cadfb74) starting

We output the commit id instead of a version number because Pylance sometimes ships Pyright changes that have not yet shipped in an official Pyright release.
Alternatively, you can look in the Pylance changelog, either in VS Code's extensions view or here on GitHub. Whenever we update our version of Pyright, it is reported in the changelog with a line like this:

Pylance's copy of Pyright has been updated from 1.1.256 to 1.1.257.

In case anyone finds this useful -- for programmatic access, you can also hit: https://raw.githubusercontent.com/microsoft/pylance-release/main/releases/latest-release.json
Instead of latest-release, you can also use latest-prerelease or a specific version like 2024.11.3.


Improve check_backend()

I'm not happy with the interface of the check_backend() function:

it should be static so you don't have to instantiate the class when checking.
it should return True/False instead of throwing exceptions
there should be a function available that returns the list of all available backends, so that you don't have to iterate and check manually.

Coverage increased (+0.5%) to 86.102% when pulling 6c2648c6169ac867748588b43d6b72d2023b8de3 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.5%) to 86.102% when pulling 6c2648c6169ac867748588b43d6b72d2023b8de3 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.5%) to 86.102% when pulling 6c2648c6169ac867748588b43d6b72d2023b8de3 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.5%) to 86.102% when pulling c24c155686e0cee0519f74d63cd4544e2b6f0e0e on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.8%) to 86.333% when pulling 73e3980b742cf61526a58a572f9d7b9f380c4757 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.8%) to 86.333% when pulling d73578c7d1c6ba3f8d8ed071371d6221087a210c on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.8%) to 86.333% when pulling 39b4fbeb7ea24f8baf4537de384534665510c638 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.8%) to 86.333% when pulling 5f21956959bd031a8be90d468491af8a403565b3 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.8%) to 86.333% when pulling 5f21956959bd031a8be90d468491af8a403565b3 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.8%) to 86.333% when pulling 5f21956959bd031a8be90d468491af8a403565b3 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

Coverage increased (+0.8%) to 86.333% when pulling 5f21956959bd031a8be90d468491af8a403565b3 on ChristianKuehnel:check_backend into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.


upgrade to stable angular; upgrade to typescript 2; move to npm-based…

Completes issue #43.
Changes in this pull request:

upgrade to stable angular
upgrade to typescript 2
move to npm-based typings

Nice clean up!

Please use the guidelines for commits and feature branch naming in CONTRIBUTING.md next time

Touché!

Haha, I've decided to start becoming the person that everyone hates by not merging PRs until they meet the naming conventions. Someone has to do it.

@alienlike npm-based typings means installing @types/<library>? For example if we wanted to use lodash or moment we could install these?

@ajcrites That's correct. See https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/.


2.6.2 "servers transport not found" error

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I upgraded Traefik from 2.6.1 to 2.6.2 in a working environment, without making any other configuration changes.
What did you see instead?
After upgrading, one of my services is now in an error state, reporting "servers transport not found confluence@docker" in the dashboard interface.
Restarting the Traefik service did not result in different behavior.
I will begin trying to isolate or workaround the issue after submitting this ticket since at face value this appears to be some kind of regression between 2.6.1 and 2.6.2.
What version of Traefik are you using?
Version:      2.6.2
Codename:     rocamadour
Go version:   go1.17.8
Built:        2022-03-24T19:09:46Z
OS/Arch:      linux/amd64

What is your environment & configuration?
    labels:
      traefik.enable: "true"
      traefik.http.routers.confluence.rule: Host(`${DOMAIN_NAME}`)
      traefik.http.routers.confluence.service: confluence
      traefik.http.services.confluence.loadBalancer.server.port: 8090
      traefik.http.services.confluence.loadBalancer.serversTransport: confluence
      traefik.http.serversTransports.confluence.forwardingTimeouts.dialTimeout: 0
      traefik.http.routers.confluence.entrypoints: webtls
      traefik.http.routers.confluence_balsamiq-rtc.rule: Host(`${DOMAIN_NAME}`) && PathPrefix(`/balsamiq.io`)
      traefik.http.routers.confluence_balsamiq-rtc.service: confluence_balsamiq-rtc
      traefik.http.services.confluence_balsamiq-rtc.loadbalancer.server.port: 9083
      traefik.http.routers.confluence_balsamiq-rtc.entrypoints: webtls

If applicable, please paste the log output in DEBUG level
time="2022-03-25T13:54:02Z" level=error msg="servers transport not found confluence@docker" entryPointName=webtls routerName=confluence@docker

commenting the traefik.http.services.confluence.loadBalancer.serversTransport: confluence line causes the error to be avoided.
I will test a bit later what happens when I rename the serversTransport to not "conflict" with the router and service name.

Hello @NReilingh,
Thanks for your interest in Traefik!
There is currently no way to define a serversTransport using a docker label.
I would suggest using this as a file provider configuration:
http:
  serversTransports:
    confluence-st:
      forwardingTimeouts:
        dialTimeout: 0s

And setting the service configuration with this label:
    labels:
      ...
      traefik.http.services.confluence.loadBalancer.serversTransport: confluence-st@file

As your issue might be a configuration problem, this issue will be closed.
Fell free to join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong, feel free to re-open the issue.
In the meantime, you can double-check Traefik's documentation.

Ah, thank you! So I think the configuration validation must have improved in 2.6.2 and this was never actually having an effect on my configuration in the first place. That clarifies some things. I'll try trusting the reference documentation even more next time. :-)


A small improvement with your fix for elm-hex to work with uppercase letters

Hi @Janiczek, this is a small refactor which tries to simplify the fix. Accept the PR if you think it serves the purpose. Thank you

Ooh, a good idea :) Thanks!
I have low hopes of the PR being merged anyway :)


added 4.0 docs

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/controls/MarkdownTextBlock.md
:warning:Warning
View
Details

docs/graph/PeoplePicker.md
:warning:Warning
View
Details

docs/graph/PlannerTaskList.md
:warning:Warning
View
Details

docs/graph/PowerBIEmbedded.md
:warning:Warning
View
Details

docs/graph/ProfileCard.md
:warning:Warning
View
Details

docs/graph/SharePointFileList.md
:warning:Warning
View
Details

docs/helpers/PrintHelper.md
:warning:Warning
View
Details

docs/.template.md
:white_check_mark:Succeeded

docs/Nuget-Packages.md
:white_check_mark:Succeeded
View

docs/animations/Blur.md
:white_check_mark:Succeeded
View

docs/animations/CompositionAnimations.md
:white_check_mark:Succeeded
View

docs/animations/Fade.md
:white_check_mark:Succeeded
View

docs/animations/ImplicitAnimations.md
:white_check_mark:Succeeded
View

docs/animations/Offset.md
:white_check_mark:Succeeded
View

docs/animations/Rotate.md
:white_check_mark:Succeeded
View

docs/animations/Saturation.md
:white_check_mark:Succeeded
View

docs/animations/Scale.md
:white_check_mark:Succeeded
View

docs/breadcrumb/toc.yml
:white_check_mark:Succeeded

docs/controls/Expander.md
:white_check_mark:Succeeded
View

docs/controls/UniformGrid.md
:white_check_mark:Succeeded
View

docs/controls/WebView.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/customize_autogenerated_columns.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/datagrid_basics.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/editing_inputvalidation.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/group_sort_filter.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/keyboard_navigation_selection.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/rowdetails.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/sizing_options.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/styling_formatting_options.md
:white_check_mark:Succeeded
View

docs/docfx.json
:white_check_mark:Succeeded

docs/extensions/LogicalTree.md
:white_check_mark:Succeeded
View

docs/extensions/NavigationView.md
:white_check_mark:Succeeded
View

docs/extensions/VisualTree.md
:white_check_mark:Succeeded
View

docs/gaze/GazeInteractionLibrary.md
:white_check_mark:Succeeded
View

docs/graph/AadLogin.md
:white_check_mark:Succeeded
View

docs/helpers/CameraHelper.md
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

docs/knownissues.md
:white_check_mark:Succeeded
View

docs/resources/images/Graph/PlannerTaskList.png
:white_check_mark:Succeeded
View

docs/resources/images/Graph/PowerBIEmbedded-Permissions.png
:white_check_mark:Succeeded
View

docs/resources/images/Graph/PowerBIEmbedded.png
:white_check_mark:Succeeded
View

docs/services/Bing.md
:white_check_mark:Succeeded
View

docs/services/Facebook.md
:white_check_mark:Succeeded
View

docs/services/Linkedin.md
:white_check_mark:Succeeded
View

docs/services/MicrosoftGraph.md
:white_check_mark:Succeeded
View

docs/services/MicrosoftTranslator.md
:white_check_mark:Succeeded
View

docs/services/Twitter.md
:white_check_mark:Succeeded
View

docs/toc.md
:white_check_mark:Succeeded
View

docs/controls/MarkdownTextBlock.md

[Warning] Author quinndamerell, deltakosh, tipa, haefele, avknaidu, nmetulev, shenchauhan, vijay-nirmal, pedrolamas, williamabradley cannot be recognized in GitHub.

docs/graph/PeoplePicker.md

Line 51: [Warning] Invalid file link:(~/../docs/graph/AadLogin.md).

docs/graph/PlannerTaskList.md

Line 10: [Warning] Invalid file link:(~/../docs/services/MicrosoftGraph.md).
Line 38: [Warning] Invalid file link:(~/../docs/services/MicrosoftGraph.md).
Line 53: [Warning] Invalid file link:(~/../docs/graph/AadLogin.md).
Line 59: [Warning] Invalid file link:(~/../Microsoft.Toolkit.Uwp.SampleApp/SamplePages/PlannerTaskList).
Line 63: [Warning] Invalid file link:(~/../Microsoft.Toolkit.Uwp.UI.Controls.Graph/PlannerTaskList/PlannerTaskList.xaml).
Line 74: [Warning] Invalid file link:(~/../Microsoft.Toolkit.Uwp.UI.Controls.Graph/PlannerTaskList).

docs/graph/PowerBIEmbedded.md

Line 39: [Warning] Invalid file link:(~/../docs/services/MicrosoftGraph.md#register-the-app-to-use-azure-ad-v1-endpoint).
Line 73: [Warning] Invalid file link:(~/../Microsoft.Toolkit.Uwp.SampleApp/SamplePages/PowerBIEmbedded).
Line 77: [Warning] Invalid file link:(~/../Microsoft.Toolkit.Uwp.UI.Controls.Graph/PowerBIEmbedded/PowerBIEmbedded.xaml).
Line 88: [Warning] Invalid file link:(~/../Microsoft.Toolkit.Uwp.UI.Controls.Graph/PowerBIEmbedded).

docs/graph/ProfileCard.md

Line 53: [Warning] Invalid file link:(~/../docs/graph/AadLogin.md).

docs/graph/SharePointFileList.md

Line 68: [Warning] Invalid file link:(~/../docs/graph/AadLogin.md).

docs/helpers/PrintHelper.md

Line 33: [Warning] The content part of NOTE/WARNING/CAUTION/IMPORTANT/NEXT syntax is suggested to start in a new line.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/.template.md
:white_check_mark:Succeeded

docs/Nuget-Packages.md
:white_check_mark:Succeeded
View

docs/animations/Blur.md
:white_check_mark:Succeeded
View

docs/animations/CompositionAnimations.md
:white_check_mark:Succeeded
View

docs/animations/Fade.md
:white_check_mark:Succeeded
View

docs/animations/ImplicitAnimations.md
:white_check_mark:Succeeded
View

docs/animations/Offset.md
:white_check_mark:Succeeded
View

docs/animations/Rotate.md
:white_check_mark:Succeeded
View

docs/animations/Saturation.md
:white_check_mark:Succeeded
View

docs/animations/Scale.md
:white_check_mark:Succeeded
View

docs/breadcrumb/toc.yml
:white_check_mark:Succeeded

docs/controls/Expander.md
:white_check_mark:Succeeded
View

docs/controls/MarkdownTextBlock.md
:white_check_mark:Succeeded
View

docs/controls/UniformGrid.md
:white_check_mark:Succeeded
View

docs/controls/WebView.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/customize_autogenerated_columns.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/datagrid_basics.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/editing_inputvalidation.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/group_sort_filter.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/keyboard_navigation_selection.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/rowdetails.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/sizing_options.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/styling_formatting_options.md
:white_check_mark:Succeeded
View

docs/docfx.json
:white_check_mark:Succeeded

docs/extensions/LogicalTree.md
:white_check_mark:Succeeded
View

docs/extensions/NavigationView.md
:white_check_mark:Succeeded
View

docs/extensions/VisualTree.md
:white_check_mark:Succeeded
View

docs/gaze/GazeInteractionLibrary.md
:white_check_mark:Succeeded
View

docs/graph/AadLogin.md
:white_check_mark:Succeeded
View

docs/graph/PeoplePicker.md
:white_check_mark:Succeeded
View

docs/graph/PlannerTaskList.md
:white_check_mark:Succeeded
View

docs/graph/PowerBIEmbedded.md
:white_check_mark:Succeeded
View

docs/graph/ProfileCard.md
:white_check_mark:Succeeded
View

docs/graph/SharePointFileList.md
:white_check_mark:Succeeded
View

docs/helpers/CameraHelper.md
:white_check_mark:Succeeded
View

docs/helpers/PrintHelper.md
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

docs/knownissues.md
:white_check_mark:Succeeded
View

docs/resources/images/Graph/PlannerTaskList.png
:white_check_mark:Succeeded
View

docs/resources/images/Graph/PowerBIEmbedded-Permissions.png
:white_check_mark:Succeeded
View

docs/resources/images/Graph/PowerBIEmbedded.png
:white_check_mark:Succeeded
View

docs/services/Bing.md
:white_check_mark:Succeeded
View

docs/services/Facebook.md
:white_check_mark:Succeeded
View

docs/services/Linkedin.md
:white_check_mark:Succeeded
View

docs/services/MicrosoftGraph.md
:white_check_mark:Succeeded
View

docs/services/MicrosoftTranslator.md
:white_check_mark:Succeeded
View

docs/services/Twitter.md
:white_check_mark:Succeeded
View

docs/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Migrate gluoncv/auto/task to autogluon

Description of changes:
Having auto logic in gluoncv that also depends on autogluon is not a good design choice. It prevents autogluon's to modify non-user exposed code. This migration would make the design cleaner by having the auto logic resides in autogluon, and gluoncv will purely be the model provider and trainer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

GluonCV auto deprecation PR: https://github.com/dmlc/gluon-cv/pull/1718

Job PR-1427-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1427/1/index.html


Remove crappy combo system for introduction at a later date

https://github.com/JujuAdams/Input/commit/387ed5df29afd4855d5d5c7bb48b60c98fd87604


[Sonic Frontiers] texture_streaming ntsp files in mods aren't loaded

Any ntsp files present in a mod won't be loaded by the mod loader. It's likely that these files are loaded in a different way, since they aren't listed in the master.levels file.

Hi, will there be any work on this? It seems to be a major game performance hindrance when modding streamable textures.


UCP: Refactor the class components to function components

Description
In the frontend react code, we mix the class component and function component together, so this task is to refactor the class components to function components.
Score

605

Mentor(s)

@baurine

Contact the mentors: #tidb-challenge-program channel in TiDB Community  Slack Workspace
Recommended Skills

React

/pick-up-challenge

/pick-up-challenge

/pick-up-challenge

@Trade-Offf Hi, please try to pick up again. We have splited tasks into multiple pieces.

/pick-up-challenge

/give-up-challenge

close this issue by PR #469


[Python] pa.array([Decimal("nan")]) raises

Describe the bug, including details regarding any error messages, version, and platform.
pa.array([Decimal("nan")])

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "pyarrow/array.pxi", line 320, in pyarrow.lib.array
  File "pyarrow/array.pxi", line 39, in pyarrow.lib._sequence_to_array
  File "pyarrow/error.pxi", line 144, in pyarrow.lib.pyarrow_internal_check_status
  File "pyarrow/error.pxi", line 100, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: Decimal precision out of range [1, 38]: -2147483648

Based on how pyarrow handles numpy nans I'd expect this to get converted to a pyarrow null.
pyarrow 11.0.0 on mac
Component(s)
Python

Based on how pyarrow handles numpy nans I'd expect this to get converted to a pyarrow null.

We actually preserve NaNs by default when passing them like that:
In [16]: pa.array([float("nan")])
Out[16]:
<pyarrow.lib.DoubleArray object at 0x7f41b7c90ee0>
[
  nan
]

It's only when you specify from_pandas=True that we convert NaN to null, but this argument is set to True automatically when you pass a pandas object (Series or Index, we should expand this with checking for an array as well ..), see https://arrow.apache.org/docs/python/generated/pyarrow.array.html
That aside, the error you get here is a bit confusing, and that seems to come from a bug in the precision/scale inference. If the first value is not a NaN, we see a better error message:
In [17]: pa.array([Decimal("1.20"), Decimal("nan")])
...
ArrowInvalid: The string 'NaN' is not a valid decimal128 number

So we generally don't support NaN (or +/- Inf) for decimal data. Given that we don't support it, we should maybe consider converting it to nulls instead (or at least give the option to do so). Also casting float to decimal will raise an error for NaN/Inf values:
In [32]: pa.array([1.2, 0.0]).cast(pa.decimal128(3, 2))
Out[32]:
<pyarrow.lib.Decimal128Array object at 0x7f41b7fd8c40>
[
  1.20,
  0.00
]

In [33]: pa.array([1.2, 0.0, np.nan]).cast(pa.decimal128(3, 2))
...
ArrowInvalid: Cannot convert nan to Decimal128

For the array(..) constructor, the from_pandas=True argument will already ensure this gets converted to null:
In [34]: pa.array([Decimal("1.20"), Decimal("nan")], from_pandas=True)
Out[34]:
<pyarrow.lib.Decimal128Array object at 0x7f41c415cac0>
[
  1.20,
  null
]

Thanks @jorisvandenbossche, using from_pandas should help with the motivating use case.

Hmm looks like pa.array([Decimal("nan")], from_pandas=True) gives a null-type instead of a decimal-type.

Yes, for a generic sequence of python objects, we currently just check if an object is "null" or not using:
https://github.com/apache/arrow/blob/53c0d338e6e45cb28a3c1973522da1257eaea761/python/pyarrow/src/arrow/python/helpers.cc#L359-L372
but once we determined an object to be null, we don't take the actual type of object into account for the type inference.
So that also means that currently you could mix all kinds of null-likes together when specifying from_pandas=True (also for cases where pandas would not allow this), for example:
In [18]: pa.array([1, pd.NaT], from_pandas=True)
Out[18]:
<pyarrow.lib.Int64Array object at 0x7fcb37d62ec0>
[
  1,
  null
]

Makes sense, thanks.  Context is is implementing something like https://github.com/pandas-dev/pandas/pull/53025 for Decimal objects.


Shadows and defines (bug?)

I am using StandardAnimationMaterial and found a problem with shadows BAS.Utils.createDepthAnimationMaterial and BAS.Utils.createDistanceAnimationMaterial.
Custom #define are not added to the shader, so i get the error: 'SIZE' : undeclared identifier.
If I fix the "defines", by adding them manually, i get 'objectNormal' : undeclared identifier. I know objectNormal is a Three.js shader chunk, so I suppose it's not imported for some reason.
NOTE: this only happens if i add a light and set castShadow to true and the renderer has shadowMap enabled. Otherwise everything works fine (but no shadows!).

I have added defines to BAS.Utils.createDepthAnimationMaterial and BAS.Utils.createDistanceAnimationMaterial. Up in version 2.0.2.
Not sure about the objectNormal error. Were you replacing the defines object after creating the shadow materials?

Thanks. I tried it and that actually fixed the issue with the defines, but i still don't understand what happens with transformedNormal and objectNormal. I don't know how the chunks get imported, but when I try to add a value to one of those, i get an undeclared error, and if i create them myself, i get a redefinition error. Maybe something related to the imports?
I just checked the generated vertex shader and noticed that when USE_SHADOWMAP is NOT defined this chunk (for example) in included:
177: #ifdef USE_SHADOWMAP
178: 	#if 1 > 0
179: 		uniform mat4 directionalShadowMatrix[ 1 ];
180: 		varying vec4 vDirectionalShadowCoord[ 1 ];
181: 	#endif
182: 	#if 0 > 0
183: 		uniform mat4 spotShadowMatrix[ 0 ];
184: 		varying vec4 vSpotShadowCoord[ 0 ];
185: 	#endif
186: 	#if 0 > 0
187: 		uniform mat4 pointShadowMatrix[ 0 ];
188: 		varying vec4 vPointShadowCoord[ 0 ];
189: 	#endif
190: #endif

When USE_SHADOWMAP is defined that chunk is not there (and other parts seem missing, the file is shorter with shadow maps enabled, which seems weird?).
To answer your question, I create the StandardAnimationMaterial with the defines already, and don't change anything after (apart from creating the shadow material).

This is the line missing when USE_SHADOWMAP is defined:
vec3 objectNormal = vec3( normal );
https://github.com/mrdoob/three.js/blob/master/src/renderers/shaders/ShaderChunk/beginnormal_vertex.glsl
and this:
vec3 transformedNormal = normalMatrix * objectNormal;

#ifdef FLIP_SIDED

	transformedNormal = - transformedNormal;

#endif

https://github.com/mrdoob/three.js/blob/master/src/renderers/shaders/ShaderChunk/defaultnormal_vertex.glsl

Could you provide a link to where this occurs? Will be easier for me to debug.

I modified your Standard Material example w shadows in my fork: https://github.com/taseenb/three.bas/blob/master/examples/materials_standard/main.js

Going to close this to clean up the old open issues.


sgx-sdk, sgx-psw: 2.16 -> 2.19

Description of changes
Update to v2.19
Besides updating the version numbers and hashes, the following small necessary changes were made.

Symlink header files of new dependency sgx-emm. The Makefile creates the symlink via the preparation target, but we don't run this target -- (it initializes git submodules, downloads prebuilt binaries and applies patches).
Repair broken symlink in installation phase when moving $TMPDIR/sgxsdk/lib64 to $out/lib.
Add missing substitution for the SGX_SDK variable in SampleAttestedTLS.
Add openssl, a required dependency to build the samples (it is used to create dummy signing keys).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@veehaitch @arcz @VertexA115 ping :smile:

Closed, as it was replaced by #254845.


Added code comments to quickstart code

Signed-off-by: Kishan Savant
Missing code comments were added based on the README.md

Nice! Thanks for your contribution!

Thank you for the review


OrbitControl typings don't allow passing target as array

I've just moved a project to TypeScript and have noticed that in the target prop for OrbitControls I can no longer pass an array due to typings. I now have to import Vector3 from three instead.
Old way (JS only):
<OrbitControls target={[0, 0, 0]} />

Workaround (TS):
import { Vector3 } from "three";
...

<OrbitControls target={new Vector3(0, 0, 0)} />

While the workaround is simple, it would be nice to accept an array in TS for parity. I'm assuing that the solution will be similar to this one from R3F: https://github.com/react-spring/react-three-fiber/issues/208

should be fixed

confirmed working. thanks!


[WFCORE-2887] Upgrade WildFly Elytron to 1.1.0.Beta48

https://issues.jboss.org/browse/WFCORE-2887
https://issues.jboss.org/browse/JBEAP-11223

commit 9d4286e1f9a81f427874fba19214e5cd8603f550
Author: Darran Lofthouse<EMAIL_ADDRESS>Date:   Tue May 30 15:19:42 2017 +0100
[ELY-1210] Release WildFly Elytron 1.1.0.Beta48

commit 4f6d8d24b163c800a977630bc83fc6ec993d090c
Merge: 0fb29d2 5bd5db8
Author: Darran Lofthouse<EMAIL_ADDRESS>Date:   Tue May 30 13:28:49 2017 +0100
Merge pull request #835 from honza889/ELY-1185

[ELY-1184][ELY-1185] Elytron XML test coverage

commit 0fb29d213951a91ed5d2ecb95d39f810ce3ce2a9
Merge: 254f3b7 9bbe716
Author: Stefan Guilhen<EMAIL_ADDRESS>Date:   Sun May 28 11:47:27 2017 -0300
Merge pull request #841 from darranl/ELY-1191

[ELY-1191] CLIENT_CERT Authentication may not have access to SSLSession

commit 254f3b708610cbecb6e42ffcd7f9a6d16c2ccdd0
Merge: abcf799 15a2c03
Author: Stefan Guilhen<EMAIL_ADDRESS>Date:   Sun May 28 11:39:07 2017 -0300
Merge pull request #842 from darranl/ELY-1203

[ELY-1203] Prefer discovered providers over registered providers and …

commit abcf7996602172945fbef9e1427658c95ca2b049
Merge: 66510bd 3c7af21
Author: Stefan Guilhen<EMAIL_ADDRESS>Date:   Sun May 28 11:35:21 2017 -0300
Merge pull request #839 from honza889/ELY-1202

[ELY-1202] MatchPurposeRule - null handling

commit 66510bdb71f9cb711cdc07f67d6d1dc1f63bccda
Merge: 3156f92 a5201bd
Author: Stefan Guilhen<EMAIL_ADDRESS>Date:   Sun May 28 11:34:37 2017 -0300
Merge pull request #838 from dmlloyd/ely-1200

[ELY-1200] Skip null providers

commit 3156f92b7b105d3e410d2b5f8f8b1967d293be63
Merge: da819e3 f35ae1b
Author: Farah Juma<EMAIL_ADDRESS>Date:   Fri May 26 09:42:22 2017 -0400
Merge pull request #840 from honza889/ELY-1193

[ELY-1193] unsecured JWT fix

commit 15a2c03275e392a79efa3047eb5cf3d2fdd5e8c8
Author: Darran Lofthouse<EMAIL_ADDRESS>Date:   Thu May 25 18:11:54 2017 +0100
[ELY-1203] Prefer discovered providers over registered providers and log information about Provider being used when creating SASLClient.

commit 9bbe71612989e0f4436f66f0b64a38f37b438dbc
Author: Darran Lofthouse<EMAIL_ADDRESS>Date:   Thu May 25 12:44:22 2017 +0100
[ELY-1191] If we have no session available to hold a cache completely skip caching for CLIENT_CERT authentication.

commit f35ae1b40e1b72e39738ec1f26b6aac47ba45c0c
Author: Jan Kalina<EMAIL_ADDRESS>Date:   Thu May 25 12:58:33 2017 +0200
[ELY-1193] unsecured JWT fix

commit 3c7af21eb5be7b07721adafd7aaf60ca49ef547f
Author: Jan Kalina<EMAIL_ADDRESS>Date:   Thu May 25 10:54:14 2017 +0200
[ELY-1202] MatchPurposeRule - null handling

commit da819e39a4e8e7887440edfcf539f3e98f3791a2
Author: Darran Lofthouse<EMAIL_ADDRESS>Date:   Wed May 24 18:21:13 2017 +0100
Next is 1.1.0.Beta48

commit a5201bdd49bbabc4723650921357f57b7815695c
Author: David M. Lloyd<EMAIL_ADDRESS>Date:   Wed May 24 12:12:10 2017 -0500
[ELY-1200] Skip null providers

commit 5bd5db8921f7cb09de34c8afd12fd9d2e9e7d975
Author: Jan Kalina<EMAIL_ADDRESS>Date:   Wed May 24 17:13:20 2017 +0200
[ELY-1184][ELY-1185] test coverage

commit 55e8e8e125f4e760dda8dd7e71965ccd99be36f1
Author: Stuart Douglas<EMAIL_ADDRESS>Date:   Wed May 24 15:03:03 2017 +1000
ELY-1191 Undertow CLIENT_CERT via Elytron and HTTP/2 does not work


xcloud: make InsecureSkipVerify configurable

Hi, I'd like to do this if it's possible. I plan to add InsecureSkipVerify field to metrics.Config struct, and update the examples to include it. Please let me know if you have another opinion.

Hi @sudo-sturbia. Yep, that's it. Please go ahead!


Refactoring to strictly delineate internal code vs. externally usable code.

The Problem
Currently the EdgeX GoLang implementation has no separation between its internal domain model and the models used to pass data out of the system. They are one and the same. Likewise, there is no visibility as to which service client is used by an external application versus solely used internal to the EdgeX platform. This means we are at risk of making changes to either our data models or our service client code that break any applications which have imported those items. We have no way to insulate our consumers from changes we make to the application based on an internal need, nor do we have the ability to hide internal/private details of our data model since our data model is also part of our client contract.
The Recommendation
In order to facilitate the separation of internal/external domain models and logic, we realized that we would need to restructure the application packages. At a high level, the changes we decided to make are as follows:
/edgex-go/core
•	will be re-purposed to contain those models and libraries which are usable by external applications
•	will include the following:
o	clients package – service clients usable by external applications
o	models package – data models usable by external applications
	NOTE: These will be identical to the current property bags found today in /edgex-go/core/domain/models
/edgex-go/internal
•	This package will be extended to include all code that we do not want external applications explicitly relying on as recommended by the golang-standards project layout
•	That means the following packages will be moved into here in some fashion
o	/edgex-go/core/command
o	/edgex-go/core/core-data
o	/edgex-go/core/core-metadata
o	/edgex-go/export
o	/edgex-go/support
	Consul-client, domain, logging
	Service client packages will most likely go to core above
•	Domain models included herein may start off as identical to those found today in /edgex-go/core/domain/models but have the flexibility to change and move around over time according to the internal needs of the platform.
We are looking at making this change early in the Delhi development cycle, so please provide feedback in a timely fashion if you have it. Also please note that any external applications which are directly linking to the current package structure within the master branch of EdgeX will break when we do this. That is unavoidable. We are doing this now so that the pill isn’t too bitter to swallow later.

Maybe will be also fine to change all Id bson.ObjectId in domain/models to ID string. The change from Id to ID is a linter recommendation. The change from bson.ObjectId to string will make the code less dependent from MongoDB, and also will simplify the code (there are lots of conversions from ObjectId to string and viceversa).

@jduranf Yes, I agree something like that will need to happen. I probably won't address it as part of this issue as I have the requirement from the Device Service group to keep the external domain model the same. But with their cooperation once this is merged, I'm sure we can make our domain model DB provider agnostic, as it should be.

I'm about to submit the first PR for this issue in which the majority of the delineated code has been moved to its new location. I'm adding this comment to record my thoughts at this point on what the end goal is going to look like. There will be a couple more subsequent PRs I think.

edgex-go/core to be renamed to edgex-go/external
All code importable by 3rd party applications wishing to integrate with EdgeX will go here
edgex-go/core/domain to be removed and models moved up to edgex-go/external/models.
These models will serve as the data model for external client application consumption
edgex-go/core/domain/enums will be collapsed into the above models package
Instead of an edgex-go/internal/app directory containing all of the services, I decided to preserve the "core" / "export" / "support" packages as representative of the logical tiers of the platform. Therefore the service implementation code will go into a respective directory such as internal/core/metadata or internal/export/distro
We have to refactor database-specific types out of our domain model (such as the BSON ObjectIDs)
This should instead be a string on the model and the Mongo provider itself will be responsible for validating any platform specific datatype requirements.

@tsconn23, as pointed by Stella and recommended by golang-standards maybe instead of "external/" we can use "api/" and "pkg/". In "/pkg" we can put all clients, and in "api/" the json models and the RAML files.
Also, maybe "snap/" and "docker/" should be moved inside of "build/".

@jduranf Working on it now. I'm going to hold off on moving the deployables to "build/" until I get feedback from @SteveOss @anonymouse64 @tonyespy

@tsconn23 good work in #369!
I guess export/ and support/ will be moved inside of internal/ in the second part.
Also I want to comment that maybe the configuration files should be moved in configs/, but this doesn't seems to be an easy thing to do.

@jduranf Yes, export/ and support/ will be in part 2. As to the configs, our Delhi workload is going to see a major rework of how we handle configuration, so I'm not including those in this work. They'll most likely be moved, but not sure where yet.

@tsconn23 what about moving the models and enums to edgex-go/external/ instead of edgex-go/external/models.
In export we followed this approach, having the shared types in edgex-go/export instead of edgex-go/export/domain and it looked cleaner to me.

Since external is akin to a top-level package, I wanted to keep it as clean as possible -- thus "clients/" and "models/" plus other things that may come in the future.

Re: moving snap and docker inside of build I disagree, as firstly it makes it harder to build the project as a snap when the snapcraft.yaml file isn't either in $GIT_ROOT/snapcraft.yaml or $GIT_ROOT/snap/snapcraft.yaml. So at least the snap and docker folders should remain in the root folder.

Done via #369, #390 and #494
@tsconn23 and @brandonforster, please open again if there are more to do


Enable build flags and fix compilation warnings (gcc 14.1.0)

Current add_compile_options() in tests and examples are not taken into account, due to that any warnings are simply ignored.
This patch series moves add add_compile_options() before target creation to resolve this issue.
Also, I tried to group warnings fixes into categories as separate patches, so it should be possible to rearrange/replace part of them.

@f0rget-the-sad thank you for your contribution. According to the pipeline, it seems that the code does not compile on Windows anymore.


While on Dream Machine Pro, cannot ping or resolve other tailnet devices

However, tailscale ping hostname works.
I've read everything on the internet but I don't quite understand what is needed to get the UDM Pro able to resolve tailnet hosts and ping them.
The ideal goal: other devices on my lan (without having tailscale installed) can resolve any tailnet host, through the dream machine.
What am I doing wrong?

I'm having the same issue.
All of the devices on my tailscale network are able to ping and interact with all of the devices on my local network (those not on the tailscale network). I can even use the UDM-Pro as an exit node while not at home and it all works as expected.
What does not work is that the UDM-Pro itself can not reach nodes on my tailscale network.
root@UDM-Pro:~# /usr/bin/ubnt-device-info firmware_detail
3.1.1

What works

inbound connectivity from any tailscale device to the local network (<IP_ADDRESS>/24)
inbound connectivity from any tailscale to the UDM-Pro tailscale adderss
tailscale ping hostname from the UDM-Pro to any device on my tailscale network

What doesn't work

Any outbound connectivity from the UDM-Pro to the tailscale network, either directly or from a device on my local network


created live link for demo

Hey I want to add some cool featured with demo version.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Reading text contents of page

Hi, thanks for working on this project. It has met my needs beautifully with one exception (and it's probably a lack of understanding on my part).
I couldn't find a very intuitive way to get the contents of a page and verify its text content.
While generating a new page and inserting it into a document was very straight-forward, I'd like to also test this functionality, including that the expected contents end up on the page (it's dynamically generated). So when writing a test, I'd like to create a page, insert several lines of text, and then bring that page back in to verify that the expected lines of text exist on that page.
Am I overlooking something obvious, or are we lacking this functionality in a straight-forward way?
Thanks!

Hello @matthopson. pdf-lib is primarily focused on creating and editing PDFs right now. It does not currently have functionality to extract text content from them. Though, this is functionality I've considered adding at some point in the future.
For your use case, I'd suggest using pdf.js to extract text from the documents you create/modify with pdf-lib. pdf.js is a library specifically designed to extract text, images, etc... from PDFs for rendering. here's an example of using it in Node.
Let me know if you have any further questions!

Thanks for the response. I had considered this, but was hoping to not have to use two separate PDF libraries to do this, but it sounds like that's my best bet for the time being.
Thanks!

Hi, thank you for working on this cool library, what a team.
I would like to find out if its possible to use pdf-lib to get specic text from a pdf file using coordinates, as in were the specific text is on the page?
I'm working on a simple feature in a react ocr(optical character recorgnition using tesseract) app, with node js and espress as the server, my goal is for a user to simply upload a scanned pdf and a specific number is extracted from the document.
looking forward to your cool response
kind regards


Sessions collection page design

consider a grouped listview

Does it make sense to have a sessions collection page? Given that all sessions are within the schedule, isn't it redundant?

Ah, but the schedule page is redundant after the event (and there may be a period where we don't have a schedule, but do have sessions).
So would our plan be:
Before the event: If we have a schedule, use that instead of a sessions index.
After the event: Use the session index instead of the schedule.

That is a brilliant idea to have a post-event session index.


Build Fortran Libraries

make lib now builds a Fortran library. For now this essentially
rebuilds all the code, but is necessary to avoid problems that
CMake has with Fortran dependencies when doing a parallel build
with multiple targets.

Codecov Report

Merging #245 (0c414b9) into develop (0767ba7) will increase coverage by 13.83%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #245       +/-   ##
============================================
+ Coverage    82.46%   96.29%   +13.83%
============================================
  Files           51        5       -46
  Lines         2823      405     -2418
============================================
- Hits          2328      390     -1938
+ Misses         495       15      -480

Impacted Files
Coverage Δ

include/keyedcommand.h

src/cpp/client.cpp

include/srexception.h

include/metadatabuffer.h

src/cpp/redis.cpp

src/cpp/addressanycommand.cpp

src/cpp/commandreply.cpp

include/command.h

include/command.tcc

include/commandreply.h

... and 36 more

Here's a question for the group (because of the CI failing): do we want to build the Fortran libraries by default or should we add a --build_fortran_client as an option?

Looks like a lot of the build tests failed -- could you look into this please?

@billschereriii Yes, it's because it puts enable_language(Fortran) in the CMakeLists.txt and so all the Dockerfiles would need to be updated. I'm thinking that we might just setup the CMake build to include the Fortran client as a separate target

I think there is a split here. For CI testing, we should always have a Fortran compiler available and should be validating Fortran builds. On customer and development sites, however, we may not have one. We can't fail builds if a compiler isn't available, of course, so that's why I was suggesting adding the Fortran component to the library IFF the compiler is available.

Most people don't have a Fortran complied pre installed. (I.e all our macs)
We should not strictly require the presence of a Fortran compiler.

@mellis13 I like the object library as an intermediate solution. I think that should work, so long as CMake respects the .mod files that Fortran generates. I'll prototype your solution and see how it goes.

@mellis13 I like the object library as an intermediate solution. I think that should work, so long as CMake respects the .mod files that Fortran generates. I'll prototype your solution and see how it goes.

@ashao How did this prototyping effort go?


Use BindableProperty in BindableList

[ ] Depends on #3361

As per https://github.com/ppy/osu-framework/pull/3361#issuecomment-882157003.


Setup React frontend for this project

I would like to setup the React website for this project

I will follow the file structure as mentioned in the README file

Assign me under WoB'24

@Durgesh4993 there I can work on it as well... there has been no response so may be i can work on it if you want


Remove Gutter from ViewRegistry and Fix Race Condition

Closes #7306
We started noticing that when a TextEditor pane got split, the same view for Gutter was being shared amongst several models, thereby making the same DOM element accessible simultaneously by more than one object. This made us experience orphaned line numbers, caused by two instances of LineNumberGutterComponent mutating .line-numbers at the same time.
This is a typical race condition which I would normally address by understanding and possibly locking the correct order in which operations should happen. However, I believe in this situation we shouldn’t actually care about ordering at all, since I think views should be kept “local”, thus avoiding to expose them to the world and/or reusing them across other views (either accidentally as in this case or on purpose).
@jssln @nathansobo: I assume the ViewRegistry came into play because it was handy to get the view straight from atom.views.getView. If this is the use case and I am not missing something, we may expose a method under TextEditorElement which, in turn, would interrogate TextEditorComponent to fetch the related DOM node. What do you think? :thought_balloon:

On a side note, this is somewhat similar to what was fixed in https://github.com/atom/atom/pull/6570. I think the root cause is the same, although I believe we should just go for a different solution to avoid this problem altogether in the future. :rocket:

@as-cii The original intent of storing gutter elements in the view registry was to maintain consistency with the overall approach to accessing views in Atom. Everywhere else so far, we can always call atom.views.getView with a model object to access the view. The trade-off of course is that we can only support a single model instance in the workspace, but I considered this simpler than having a bunch of localized entry points. For example, to do this for the workspace, panes, etc, we still would have needed some global way to get the workspace element. Then, on the workspace, we would have needed individual methods for obtaining views for different model objects. After agonizing over it, I opted for a 1:1 relationship between models and views globally for the workspace, so accessing a view is always the same.
I'm a bit confused about why this is still happening. When we construct the gutter component and re-obtain our element, we always clear its contents here. How is this still going wrong?

From my understanding, one TextEditorComponent corresponds to one LineNumberGutterComponent, but one TextEditor may correspond to several TextEditorComponents(?).
So the race condition really arises from that fact. (At least there must be some place the 1:1 correspondence breaks down in order to create the multiple LineNumberGutterComponents.) It does seem the straightforward thing to do is either to make that not the case, or to make separate DOM views as in this PR.

After talking this through with @as-cii, I'm starting to think that exposing the raw gutter nodes to API users is unnecessary. For example, there are other cases where we expose model objects without their corresponding views: cursors and selections. @jssln is there anything critical you need direct node access for? If not, I think life is simpler if we remove it.

One thing we do now is register a click listener on the entire gutter node.

@as-cii That's a pretty compelling use case. We could add an official API to replicate it, but it sounds somewhat annoying for now.

@nathansobo @jssln: agreed, although I wouldn’t go down the path of creating a 1:1 correspondence between TextEditor and TextEditorComponent. It certainly sounds like a good move, but it feels somewhat risky and we should probably avoid doing it right now.
Another thing @nathansobo brought up in chat was that at some point we could replace the global ViewRegistry, but that sounds complicated as well.
So, I will simply ditch the first commit and keep the last one: this means that there will be no visible changes but the race condition will be addressed by making TextEditorComponent aware of its destruction.
If everyone is :cool: with that, I am going to :ship: it as soon as the builds gets :green_heart:.

:+1:


keyboard shortcut

I would like to pick a copy method and bind it to a keyboard shortcut for quick usage

That makes sense, thanks for the suggestion


Redirect when logged in

Redirect logged in users on /login
If a logged in user navigates to the login page they should be
redirected to the supplier dashboard.
Change redirect flow for create-users
This commit changes the redirect flow for the /suppliers/create-user route. Before this change if a logged in user clicked the create user link for a different email address they would be redirected to the /suppliers/login route rather than the supplier dashboard. Since changing the /suppliers/login route to redirect logged in users to the supplier dashboard this different flow just adds in another redirect step.
With this change we redirect the user to the same place (the supplier dashboard) but show them an error message telling them what has gone wrong.
The tests associated with this flow have been updated to not follow redirects and we instead verify the location header and cookies are set. The reason for this is that the supplier dashboard has a lot of dependencies which detract from the meaning of the create user tests.

:+1:


Added a howenchant command

added this so that new people can use it and know how do they apply enchantments
edits are allowed.

OOps completely forgot about translators and text.json will do this pr later