Overlay allows deleting directories that aren't empty

I know this is not a Docker bug, this is in the kernel itself.  I'm only filing here as I expect it will gain the attention of somebody who know where/how to get this fixed.

If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

@GordonTheTurtle is this a generic message or did you determine that my issue lacks info?  Do I have to follow your template?
#ECANNOTCOMPUTE

Lol you are fine

There seem to be a few weird overlay bugs wrt Unix sockets, installing pip lol etc
ping @vbatts

@ibuildthecloud interesting that fails on ubuntu's 4.0.1
The same steps fails on fedora20
vbatts@valse ~/tmp (master *) $ docker build -t test .
Sending build context to Docker daemon 2.048 kB
Sending build context to Docker daemon
Step 0 : FROM ubuntu
latest: Pulling from ubuntu
e9e06b06e14c: Pull complete
a82efea989f9: Pull complete
37bea4ee0c81: Pull complete
07f8e8c5e660: Already exists
ubuntu:latest: The image you are pulling has been verified. Important: image verification is a tech preview feature and should not be relied on to provide security.
Digest: sha256:8126991394342c2775a9ba4a843869112da8156037451fc424454db43c25d8b0
Status: Downloaded newer image for ubuntu:latest
 ---> 07f8e8c5e660
Step 1 : RUN mkdir /empty
 ---> Running in ea2b4971b9ee
 ---> 3adf0ef44a5b
Removing intermediate container ea2b4971b9ee
Successfully built 3adf0ef44a5b
vbatts@valse ~/tmp (master *) $ docker run -i test bash << "EOF"
> rmdir /empty
> mkdir /empty
> touch /empty/a
> rmdir /empty && echo "I'm a bug"
> EOF
rmdir: failed to remove '/empty': Directory not empty
vbatts@valse ~/tmp (master *) $ docker info
Containers: 2
Images: 5
Storage Driver: overlay
 Backing Filesystem: extfs
Execution Driver: native-0.2
Kernel Version: 3.19.5-100.fc20.x86_64
Operating System: Fedora 20 (Heisenbug)
CPUs: 4
Total Memory: 11.43 GiB
Name: valse.usersys.redhat.com
ID: RSJF:6G2K:WRHU:VG4Y:OUFZ:EZDT:UZMQ:5EGF:YGMA:6ADA:BW5B:VN5H
Username: vbatts
Registry: [https://index.docker.io/v1/]

rawr. i just tested again on 4.0.2-300.fc22.x86_64 and the bug is exposed. so, regression in the kernel.

further, this now bunk container can not be restarted.
vbatts@noyee ~ (master) $ docker start 3
Error response from daemon: Cannot start container 3: Error getting container 37b677109f2e7da10a9c3a05b24b2a6e0ac8fa972ce2bba7f093aca65da2aaa7 from driver overlay: error creating overlay mount to /var/lib/docker/overlay/37b677109f2e7da10a9c3a05b24b2a6e0ac8fa972ce2bba7f093aca65da2aaa7/merged: file exists
FATA[0000] Error: failed to start one or more containers

I've just boiled this down to a reproduction outside docker:
base=$(mktemp -d)
echo ${base}

## make an overlay fs setup
mkdir -p ${base}/{upper,work,merged,mnt,lower}

## make an empty directory in the base layer
mkdir ${base}/lower/empty

## mount the base layer
sudo mount \
        -t overlay \
        -o rw,lowerdir=${base}/lower/,workdir=${base}/work/,upperdir=${base}/upper/ \
        ${base}/merged/ ${base}/mnt/

## create a whiteout
rmdir ${base}/mnt/empty

## add the dir back (on top of the whiteout)
mkdir -p ${base}/mnt/empty
touch ${base}/mnt/empty/file.txt

## now rm the non-empty directory
rmdir ${base}/mnt/empty && echo "bug here!"

## cleanup
sudo umount ${base}/mnt
sudo find ${base}

starting with reporting it against fedora's kernel, https://bugzilla.redhat.com/show_bug.cgi?id=1220915

upstream fix done and added to the 4.0 stable tree
https://github.com/torvalds/linux/commit/d377c5eb54dd05aeb3094b7740252d19ba7791f7

I can confirm that this has already been fixed in upstream:
d@test:~$ sudo docker run -i test ash << "EOF"
rmdir /empty
mkdir /empty
touch /empty/a
rmdir /empty && echo "I'm a bug"
EOF

rmdir: '/empty': Directory not empty
d@test:~$ sudo docker info
Containers: 1
Images: 2
Storage Driver: overlay
 Backing Filesystem: extfs
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 4.1.2-040102-generic
Operating System: Ubuntu 14.04.2 LTS
CPUs: 1
Total Memory: 489 MiB
Name: test
ID: 6WL7:6M3T:ER6K:QBLJ:7DL4:GKO2:4L5N:ZGQD:FRN7:O3S6:D76A:M5J5

Closing this issue. :tada:

Great. Another one bites the dust.
/me dances
On Jul 16, 2015 20:23, "David Calavera"<EMAIL_ADDRESS>wrote:

Closed #13108 https://github.com/docker/docker/issues/13108.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/13108#event-358091427.


How to get the array values on @drag-end

Hello,
When the slider has only one value, this works, and refreshes the slider, with the new value got at drag-end:
<vue-slider :value="constraint.value" @change="val => value = +val" @drag-end="constraint.value = value ;"></vue-slider>
but I can't make it work when I am using an array of values :
<vue-slider :value="[constraint.framedMin,constraint.framedMax]" @change="val => value = +val" @drag-end="getValues(value)"></vue-slider>
getValues returns "undefined".
I can't get the new array values , I don't know how to do.
Do you have any idea how I should do to update/refresh the vue-slider when using an array as value?
I have tried things like val[0] and value[0] and value[1] with no luck.
Thanks a lot, have a nice day !

It is better to use v-model, you can also get the latest value by $refs.sliders.getValue().


New version: Chromium\ChromeDriver version 125.0.6422.60

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

@VineetHBhat please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree


*: support auto-compaction with finer granularity

fixes #8503

Some manual test result:
test 5s interval:
$ bin/etcd --auto-compaction-retention 5s
2017-09-14 16:11:32.726296 N | compactor: Starting auto-compaction at revision 1 (retention: 5s )
2017-09-14 16:11:32.729183 I | mvcc: store.index: compact 1
2017-09-14 16:11:32.729237 N | compactor: Finished auto-compaction at revision 1
2017-09-14 16:11:32.729302 I | mvcc: finished scheduled compaction at 1 (took 41.163µs)
2017-09-14 16:11:37.726362 N | compactor: Starting auto-compaction at revision 1 (retention: 5s )
2017-09-14 16:11:37.726519 N | compactor: Finished auto-compaction at revision 1
2017-09-14 16:11:42.726478 N | compactor: Starting auto-compaction at revision 1 (retention: 5s )
2017-09-14 16:11:42.726642 N | compactor: Finished auto-compaction at revision 1

test no compaction:
$ bin/etcd --auto-compaction-retention 0
2017-09-14 16:12:08.019460 N | embed: serving insecure client requests on <IP_ADDRESS>:2379, this is strongly discouraged!

test auto-compaction doesn't compact at every 1 time.Duration(1):
$bin/etcd --auto-compaction-retention 1
2017-09-14 16:12:30.743382 N | embed: serving insecure client requests on <IP_ADDRESS>:2379, this is strongly discouraged!

if the approach seems fine, I'll refactor the tests for compactor as it is currently tightly couple with  compactor's implementation.

@xiang90 I changed the compactor logic with following:

get store rev now.
wait for retention period to pass.
compact at rev from step 1.
go to step 1.

why do we change the previous logic? i feel all we need to do there is to change the wait time from a fix x hours to some user given timeout, no?

@xiang90 the previous logic has a checkCompactionInterval that defaults to 5 mins. So the loop runs every 5 minutes to check if it should compact. It works for any wait time > 5 mins but not < 5  mins. therefore, I get rid of it. Having a looping checking every 5 minutes seems unnecessary. All the compactor really care is the rev at time.Now() - retentionPeriod. So I don't see the need to keep tracks revs every 5 minutes and then get the right rev through some math.

@fanminshi
There are a few issues with your approach, which the old approach addressed.

short retry time when error occurs (5 minutes instead of 1hr)
not updating compaction rev when error occurs

I would suggest you understand how the previous code handles failures before simplifying it. The rev recording part can be simplified though.

@xiang90 i see. let me rethink about the error handling part.

@xiang90 i add fast retry behavior into the code.

this is getting more complicated. i am wondering why not keep the exact previous logic and change the checkInterval to min(user-specified-timeout/10, 1*second) or something.

@xiang90 checking every checkCompactionInterval to see if I should compact seems a bit heavy to me. I think there can be a more efficient way. Anyways, I can keep the original approach by changing checkCompactionInterval  to a appropriate value.

checking every checkCompactionInterval to see if I should compact seems a bit heavy to me. I think there can be a more efficient way.

99% people will compact > 1 minute interval. that is max 0.16 read request / second, which is almost nothing.

@xiang90 redone the pr with previous approach. PTAL

left some comments about minor issues. defer @gyuho or @jpbetz for a final look.

@fanminshi Fix Travis CI failures?

made the auto-compaction-mode  more clear.

lgtm. defer to @gyuho
@jpbetz let's improve the code in the next pr.

merge when green.


Fix warnings and format issues from an OSS build perspective

These are the fixes that cargo build/fmt need to issue no warnings or spurious changes from an open source only build.

Thanks!


Add support for FastQC 0.10.1

The file name of the zip file is slightly different.

Commit 678d7821d958303f216bfb2d307ed8ac15eee435 fixes this


Deploy submodule

Instead of having the deploy.py script directly copied here, which makes it complicated to get the latest version of it, now we use the git command submodule to create a submodule or a link to a repo where the script is centralized
The command for any dash app to have the deploy script is:
git submodule add https://git-scm.com/docs/git-submodule
And every time the developer wants to get the latest version of the script locally, they would do:
git submodule update --remote
@cldougl Could you please have a look at this

I realised a couple of days ago that there is an issue with using git submodule so I'll close this PR and come up with another solution for this.


Improve tags ordering

Currently we sort tags by names lexicographically. But in some cases we should sort numerically. See the screen.
Search mech binded to not necessary (as i see now) TAGS_ORDER settings option.
Maybe remove TagQuerySet.filter_by_products and _.exclude_by_products from SE. We already done it at stb in https://github.com/fidals/stroyprombeton/issues/419

Screen taken from this link: https://www.shopelectro.ru/catalog/categories/akkumuliatory-270/

We can make a plain query to postgres, that will order by chars and than by floats:
select * from shopelectro_tag
  order by
    substring(name, '[a-zA-Zа-яА-Я]+'),
    substring(name, '[0-9]+\.?[0-9]*')::float;

  id   |    name    | position | group_id |                 uuid                 |         slug
-------+------------+----------+----------+--------------------------------------+----------------------
     7 | Apple      |        1 |        4 | 7d2c7d35-6059-4764-b015-66ade0a86dcf | apple
     8 | Microsoft  |        2 |        4 | 9cc667df-3ef3-4c48-bdbb-684a57b3840e | microsoft
     3 | 1.2 А      |        1 |        2 | 7c1f2b04-f576-4b81-a83c-e61ced91a14c | 1-2-a
     4 | 10 А       |        2 |        2 | 2dc8dcb5-06e7-4190-8923-acd31473d28a | 10-a
     1 | 6 В        |        1 |        1 | ab972e93-45ee-4cfe-a356-9500ab8d5031 | 6-v
     2 | 24 В       |        2 |        1 | 41b3a065-9dcb-4801-b821-c921743313ea | 24-v
     5 | 7.2 Вт     |        1 |        3 | 510507d1-9255-4efe-9b40-878b78d40e8e | 7-2-vt
     6 | 240 Вт     |        2 |        3 | 170c32a2-e49d-4e04-bcc1-4ea4bdbd326d | 240-vt

Also to avoid performance gaps we can create an index for the expression:
se_prod=# explain ANALYSE select * from shopelectro_tag order by name;
                                                                  QUERY PLAN

----------------------------------------------------------------------------------------------------------------------------------------------
 Index Scan using tag_ordering on shopelectro_tag  (cost=0.42..8240.48 rows=100009 width=53) (actual time=0.024..821.284 rows=100009 loops=1)
 Planning time: 0.174 ms
 Execution time: 1504.217 ms
(3 rows)

se_prod=# explain ANALYSE select * from shopelectro_tag order by substring(name, '[a-zA-Zа-яА-Я]+'), substring(name, '[0-9]+\.?[0-9]*')::float;
                                                                   QUERY PLAN

-------------------------------------------------------------------------------------------------------------------------------------------------
 Index Scan using tag_ordering_2 on shopelectro_tag  (cost=0.42..9004.64 rows=100009 width=53) (actual time=0.039..1205.072 rows=100009 loops=1)
 Planning time: 0.378 ms
 Execution time: 1915.029 ms
(3 rows)

The difference between order by name and this expression isn't to big for 100 000 rows, so it won't be an issue for ours 773 tag :)

I am going to bring an implementation of the query in this issue

@duker33 2 puzzles #282, #283 are still not solved.

@duker33 2 puzzles #282, #292 are still not solved; solved: #283.

@duker33 2 puzzles #282, #292 are still not solved; solved: #129, #283.

@duker33 2 puzzles #292, #294 are still not solved; solved: #129, #282, #283.

@duker33 the puzzle #292 is still not solved; solved: #129, #282, #283, #294.


Added Navbar Functionality[React]

Description

Made Navbar styling and functionality changes

closes #293
Type of change
Added react-scroll package to add functionality and used tailwind classes to add styling

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] User Interface
[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have npm run format before committing
[ ] I replicated the UI with the Design

Screenshots (if applicable)

Hi @harkiratsm,
I have made the changes to the navbar (styling and functionality).
Please let me know if anything else needs to be done in this.

For the home  you should also add a scroll effect . 😄

scroll effect?
Could you ellaborate or Could you share an example? Like any other website with this feature?

scroll effect? Could you ellaborate or Could you share an example? Like any other website with this feature?

Just taking about like u did for aboutus button can you also do for home button too .

Is there a specific home page on the website?
Even in the figma design i can see pages for courses and about us but not Home.
Please let me which page is home will add the effect.🙂

this is the home page commclassroom/design/light-theme/hero.png

This is the home page commclassroom/design/light-theme/hero.png here 😄

Added it. 👍
Let me know if anything else is needed. 😄

LGTM 🚀


Add translation key to AWS

We are now storing the translation API key in the AWS account
Related: #52

thank you for doing that !!


UofT-DSI |  - Assignment <3>

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code so I can make multiple pipelines, and tune the hyperparameters to find the best model that predicts the forest fires when utilizing this data.
What did you learn from the changes you have made?
Learned about preprocessing, making pipelines, and hyperparameter tuning.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Thought of different ways to approach this according to the sample notebooks, but even
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, could not get past after loading the pickle file and getting into the SHAP section.
How were these changes tested?
in VS code and in an incognito window.
A reference to a related issue in your repository (if applicable)
Last two questions. Pickle file and SHAP values.
Checklist

[ ] I can confirm that my changes are working as intended

A3 complete


Space after comma followed by template string fails

The following snippet fails with A space is required after ','  comma-spacing:
x(1, `template literal string`);

function x() {}

.eslintrc:
parser: babel-eslint
environment:
  node: true
  mocha: true
ecmaFeatures:
  generators: true
  modules: true
  blockBindings: true
  arrowFunctions: true
  destructuring: true
  forOf: true
  templateStrings: true

Babel v5.8.9
eslint v0.24.1
babel-eslint v4.0.3

Fixed as of 4.0.4/3.1.30.

Works for me, thanks a lot!


Use iterators for comment children, attributes, etc.

It's easier, more efficient, and more readable than all the bound-checking we're doing, specially taking into account that each bound check is an extra ffi call.

cc @fitzgen

Hello,
I'd quite like to try to do this, for comment children first, since it seems simpler.
Would it be ok?
Would it be reasonable to follow the accepted answer here as a guide?
http://stackoverflow.com/questions/30218886/how-to-implement-iterator-and-intoiterator-for-a-simple-struct

Sure, it'd be great!
Yeah, that answer seems pretty reasonable :)

Does this issue make #143 redundant?

Does this issue make #143 redundant?

Agh, sort of, I didn't read this comment soon enough.
That being said, another contributor had already made progress in that issue, so I think that should be merged. If you could rebase your patch on top of it (should be straight-forward), that would be great :)

Yes, that should not be an issue as soon as it is available in master.


Anti-flickering when updating inventory

When opening an inventory, set the held slot of the player to an empty slot
When closing, set it back to the current slot

Nah... that's too complicated


Additional properties C# implementation

Typespec ...Record<T> syntax support added in https://github.com/Azure/autorest.csharp/pull/4682
Further refinement done in https://github.com/Azure/autorest.csharp/pull/4510


feat(ui/select): add select component

MR Checklist
Please check if your MR fulfills the following requirements:

[x] The commit message follows conventional commits
[ ] Docs have been added / updated (for bug fixes / features)

MR Type
What kind of change does this MR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this MR introduce a breaking change?

[ ] Yes
[x] No

Other information

Todo:

[ ] Add tests
[ ] Add styling

Closes #26


chore: Update README to highlight Comet benefits

Which issue does this PR close?

N/A
Rationale for this change

By focusing on the benefits of Comet, and showing some performance results, we can hopefully make the project more compelling to users who may consider trying it out.
What changes are included in this PR?

New README. You can see the rendered version here
How are these changes tested?

Thanks for the reviews @viirya @kazuyukitanimura @comphead. I have addressed the feedback so will go ahead and merge this and we can follow up with future PRs if we want to refine this more.


Editing issues does not relink SHA hashes

Description
When posting a new issue or comment, SHA hashes are auto-linked (and wrapped in <code>), but editing them does not relink them until a refresh. The previewer also shows them unwrapped.
Gitea Version
1.20.3
Can you reproduce the bug on the Gitea demo site?
Untested
Log Gist
No response
Screenshots
After editing (and editor preview):

After refresh:

Git Version
No response
Operating System
No response
How are you running Gitea?
Windows Service
Database
None

@colejohnson66 i can not reproduce this. can you?
@lunny ping

Nope. No repro in 1.22.6. Must've been fixed in the meantime.


Instance controller event filter ignores Status updates

by comparing the generation field of the new and old objects. This way we save the controller ~50% of reconciliation calls.
Signed-off-by: Aleksey Dukhovniy<EMAIL_ADDRESS>

Do we support nested operators? I know that we have an integration test that does this ( integration/create-operator-in-operator), but tbh, I'm not sure it's a real use case.
If we do support it though, this would add the same problem: The outer operator wouldn't get notifications about the deployed instance.
Maybe it would be better to check for ownership of the affected object:
isOwnedByInstance = <obj.ownerReferences contains an kudo.Instance>
or
isOwnedByInstance = <obj.labels contains InstanceLabel>

I'm closing this for now. The end solution is too complex and I'm not sure this is needed: we can reconcile too much for now and tackle it if needed.


Create a Virtual Reality Gallery

Description:
We're exploring VR experiences on our website. Your task is to design a virtual reality gallery where users can explore and interact with 3D objects or immersive scenes.

Difficulty: intermediate
Estimated Time: 6-7 hours

Hi Jayesh,
Hi there! I'm interested in working on this issue. Could you please assign it to me? I believe I can make a valuable contribution to this task.
Looking forward to your response. Thanks!

Hello User,
Thank you for your interest in working on this issue. I've assigned the issue to you, and you can now start working on it. If you have any questions or need any assistance, feel free to ask. Good luck with your contribution!
Best regards,
Jayesh


[bug] [comfy_mtb] | ERROR -> guidedFilter not found, use opencv-contrib-python

Describe the bug
Installed the script, and I have missing modules.
How can I fix? (thanks in advance!)
[comfy_mtb] | DEBUG -> Web extensions folder found at D:\ComfyUI\ComfyUI\web\extensions\mtb
[comfy_mtb] | DEBUG -> Imported conditions nodes
[comfy_mtb] | DEBUG -> Imported crop nodes
[comfy_mtb] | DEBUG -> Imported deep_bump nodes
[comfy_mtb] | DEBUG -> Imported graph_utils nodes
[comfy_mtb] | ERROR -> guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | DEBUG -> Imported image_processing nodes
[comfy_mtb] | DEBUG -> Imported latent_processing nodes
[comfy_mtb] | DEBUG -> Imported mask nodes
[comfy_mtb] | DEBUG -> Imported number nodes
[comfy_mtb] | DEBUG -> Imported video nodes
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceswap because ModuleNotFoundError: No module named 'ifnude'
Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
Check that you properly installed the dependencies.
 WARN: This is an experimental extension. Extremely unstable. !!
Comfyroll Custom Nodes: Loaded
Davemane42 Custom Nodes: Loaded
[tinyterraNodes] Loaded
[comfy_mtb] | DEBUG -> Web extensions folder found at D:\ComfyUI\ComfyUI\web\extensions\mtb
[comfy_mtb] | DEBUG -> Imported conditions nodes
[comfy_mtb] | DEBUG -> Imported crop nodes
[comfy_mtb] | DEBUG -> Imported deep_bump nodes
[comfy_mtb] | DEBUG -> Imported graph_utils nodes
[comfy_mtb] | ERROR -> guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | DEBUG -> Imported image_processing nodes
[comfy_mtb] | DEBUG -> Imported latent_processing nodes
[comfy_mtb] | DEBUG -> Imported mask nodes
[comfy_mtb] | DEBUG -> Imported number nodes
[comfy_mtb] | DEBUG -> Imported video nodes
[comfy_mtb] | ERROR -> Some nodes failed to load:
        Failed to import faceswap because ModuleNotFoundError: No module named 'ifnude'
        Failed to import fun because ModuleNotFoundError: No module named 'qrcode'

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | DEBUG -> Loaded the following nodes:
        Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
        Text To Image (mtb): Utils to convert text to image using a font
        Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
        B Box From Mask (mtb): From a mask extract the bounding box
        Bounding Box (mtb): The bounding box (BBOX) custom type used by other nodes
        Crop (mtb): Crops an image and an optional mask to a given bounding box
        Uncrop (mtb): Uncrops an image to a given bounding box
        Deep Bump (mtb): Normal & height maps generation from single pictures
        Save Tensors (mtb): Debug node that will probably be removed in the future
        Color Correct (mtb): Various color correction methods
        Hsv To Rgb (mtb): Convert HSV image to RGB
        Rgb To Hsv (mtb): Convert RGB image to HSV
        Image Compare (mtb): Compare two images and return a difference image
        Denoise (mtb): Denoise an image using total variation minimization.
        Blur (mtb): Blur an image using a Gaussian filter.
        Deglaze Image (mtb): Remove adversarial noise from images
        Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
        Colored Image (mtb): Constant color image of given size
        Image Premultiply (mtb): Premultiply image with mask
        Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
        Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
        Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
        Image Remove Background Rembg (mtb): -
        Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
        Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
        Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable `CLIPTextEncode` support.
WAS Node Suite: `CLIPTextEncode (BlenderNeko Advanced + NSP)` node enabled under `WAS Suite/Conditioning` menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 186 nodes successfully.

        "Success is not just about making money. It's about making a difference." - Unknown

Import times for custom nodes:
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_tonemap.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Textnode.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\advanced_model_merging.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_TiledKSampler
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ADV_CLIP_emb
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_SeeCoder
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\images-grid-comfy-plugin
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
   0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-WD14-Tagger
   0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Workflow-Component
   0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb
   0.3 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
   0.5 seconds: D:\ComfyUI\ComfyUI\custom_nodes\clipseg.py
   0.6 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
   0.7 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui
   0.9 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
   1.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui
   1.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack

Starting server

To see the GUI go to: http://<IP_ADDRESS>:8188

Additional context
No response

Hi,
Thanks for the report, the ifnude error should not be anymore but I will check closer right now!
The rest seems all ok, you can safely ignore the opencv mismatch, it's just for one node that I will probably remove in the next release: ImageDeglaze which is based on AdverseCleaner. Basically there are a few flavors of opencv for python, but each are exclusive... WAS Suite for instance installs the headless version of it, this node requires the contrib flavor

Yep I can confirm that ifnude is not used anymore since this commit: https://github.com/melMass/comfy_mtb/commit/da3e6f47c6073e73cf9d3a3cd23ba5ccbe1fedce
Maybe try pulling the latest changes: git fetch && git pull from the root directory of the extension

A new release is due today, but will more realistically be done tomorrow :)

Thanks so much for your help!!
I tried git fetch && git pull, and it opened the Connect to Github requestor to sign in via broswer or personal token. Neither has never worked for me, even with the correct info, so I receive this fetch error: fatal: helper error (-1): User cancelled dialog.
In face, none of the custom scripts that use the Connect to Github sign in via browser has worked for me. Is there a way to fix?
From there, I downloaded the latest zip file , overwrote the existing distro, and received a failed to import error.  WARN: This is an experimental extension. Extremely unstable. !!
Comfyroll Custom Nodes: Loaded
Davemane42 Custom Nodes: Loaded
[tinyterraNodes] Loaded
Log level: 20
[comfy_mtb] | WARNING -> cv2.ximgproc.guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceenhance because ModuleNotFoundError: No module named 'gfpgan'
Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
Failed to import image_interpolation because ModuleNotFoundError: No module named 'frame_interpolation.eval'
Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
Text To Image (mtb): Utils to convert text to image using a font
Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
B Box From Mask (mtb): From a mask extract the bounding box
Bounding Box (mtb): The bounding box (BBOX) custom type used by other nodes
Crop (mtb): Crops an image and an optional mask to a given bounding box
Uncrop (mtb): Uncrops an image to a given bounding box
Deep Bump (mtb): Normal & height maps generation from single pictures
Save Tensors (mtb): Debug node that will probably be removed in the future
Color Correct (mtb): Various color correction methods
Hsv To Rgb (mtb): Convert HSV image to RGB
Rgb To Hsv (mtb): Convert RGB image to HSV
Image Compare (mtb): Compare two images and return a difference image
Denoise (mtb): Denoise an image using total variation minimization.
Blur (mtb): Blur an image using a Gaussian filter.
Deglaze Image (mtb): Remove adversarial noise from images
Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
Colored Image (mtb): Constant color image of given size
Image Premultiply (mtb): Premultiply image with mask
Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
Image Remove Background Rembg (mtb): -
Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable CLIPTextEncode support.
WAS Node Suite: CLIPTextEncode (BlenderNeko Advanced + NSP) node enabled under WAS Suite/Conditioning menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: ffmpeg_bin_path is not set in D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 186 nodes successfully.
    "Success is not just about making money. It's about making a difference." - Unknown

Import times for custom nodes:
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_tonemap.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_rescalecfg.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Textnode.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\advanced_model_merging.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_TiledKSampler
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ADV_CLIP_emb
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_SeeCoder
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\images-grid-comfy-plugin
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Workflow-Component
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-WD14-Tagger
0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb
0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\clipseg.py
0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
0.3 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui
0.6 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
0.7 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188

Thanks for the details, yes the zip from github don't include the submodules unfortunately (https://github.com/dear-github/dear-github/issues/214), my release script does bundle them into the zip file though so by tomorrow I should release 0.1.0.
If you want to try manually you can just unzip these into the extern folder:

gpfgan.zip - This is used for face restoration
FILM.zip - This is used for the frame interpolation nodes.

Note that even if some node fails the others don't.

 WARN: This is an experimental extension. Extremely unstable. !!
Comfyroll Custom Nodes: Loaded
Davemane42 Custom Nodes: Loaded
[tinyterraNodes] Loaded
Log level: 20
[comfy_mtb] | WARNING -> cv2.ximgproc.guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceenhance because ModuleNotFoundError: No module named 'basicsr'
Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
Failed to import image_interpolation because ModuleNotFoundError: No module named 'tensorflow'
Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
Text To Image (mtb): Utils to convert text to image using a font
Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
B Box From Mask (mtb): From a mask extract the bounding box
Bounding Box (mtb): The bounding box (BBOX) custom type used by other nodes
Crop (mtb): Crops an image and an optional mask to a given bounding box
Uncrop (mtb): Uncrops an image to a given bounding box
Deep Bump (mtb): Normal & height maps generation from single pictures
Save Tensors (mtb): Debug node that will probably be removed in the future
Color Correct (mtb): Various color correction methods
Hsv To Rgb (mtb): Convert HSV image to RGB
Rgb To Hsv (mtb): Convert RGB image to HSV
Image Compare (mtb): Compare two images and return a difference image
Denoise (mtb): Denoise an image using total variation minimization.
Blur (mtb): Blur an image using a Gaussian filter.
Deglaze Image (mtb): Remove adversarial noise from images
Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
Colored Image (mtb): Constant color image of given size
Image Premultiply (mtb): Premultiply image with mask
Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
Image Remove Background Rembg (mtb): -
Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable CLIPTextEncode support.
WAS Node Suite: CLIPTextEncode (BlenderNeko Advanced + NSP) node enabled under WAS Suite/Conditioning menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: ffmpeg_bin_path is not set in D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 186 nodes successfully.
    "Success is not just about making money. It's about making a difference." - Unknown

Import times for custom nodes:
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_rescalecfg.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_tonemap.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Textnode.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\advanced_model_merging.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_TiledKSampler
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ADV_CLIP_emb
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_SeeCoder
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\images-grid-comfy-plugin
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Noise
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-WD14-Tagger
0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Workflow-Component
0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb
0.3 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\clipseg.py
0.5 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
0.7 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
0.8 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui
1.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui
1.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188
QualityOfLifeSuit_Omar92::NSP ready

It seems like there are two things remaining:

you did not install the requirements (or something went wrong)

the folders placed in extern are not extracted as expected, you can basically look there for the expectations: https://github.com/melMass/comfy_mtb/tree/main/extern

The other will be release later today (around 6h from now 😀)

OOOPPSS!
Sorry about that..
Here's my log after running "pip install -r requirements.txt:
(base) D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb>pip install -r requirements.txt
Ignoring tensorflow: markers 'platform_system != "Windows"' don't match your environment
Collecting gdown@ git+https://github.com/melMass/gdown@main (from -r requirements.txt (line 17))
Cloning https://github.com/melMass/gdown (to revision main) to c:\users\rethink\appdata\local\temp\pip-install-sxoj1r46\gdown_0563c6354dc64f999127a8be062bb403
Running command git clone --filter=blob:none --quiet https://github.com/melMass/gdown 'C:\Users\RETHINK\AppData\Local\Temp\pip-install-sxoj1r46\gdown_0563c6354dc64f999127a8be062bb403'
Resolved https://github.com/melMass/gdown to commit 57ea784c863290da4b880c035f99edad854234c3
Running command git submodule update --init --recursive -q
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Collecting onnxruntime-gpu==1.15.1 (from -r requirements.txt (line 1))
Using cached onnxruntime_gpu-1.15.1-cp39-cp39-win_amd64.whl (122.5 MB)
Collecting imageio===2.28.1 (from -r requirements.txt (line 2))
Using cached imageio-2.28.1-py3-none-any.whl (3.4 MB)
Collecting qrcode[pil] (from -r requirements.txt (line 3))
Using cached qrcode-7.4.2-py3-none-any.whl (46 kB)
Collecting numpy==1.23.5 (from -r requirements.txt (line 4))
Using cached numpy-1.23.5-cp39-cp39-win_amd64.whl (14.7 MB)
Collecting insightface==0.7.3 (from -r requirements.txt (line 5))
Using cached insightface-0.7.3.tar.gz (439 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Installing backend dependencies ... done
Preparing metadata (pyproject.toml) ... done
Collecting mmcv==2.0.0 (from -r requirements.txt (line 6))
Using cached mmcv-2.0.0.tar.gz (473 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [14 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "C:\Users\RETHINK\AppData\Local\Temp\pip-install-sxoj1r46\mmcv_00b42624230c46d08eb947bebf58265f\setup.py", line 343, in
ext_modules=get_extensions(),
File "C:\Users\RETHINK\AppData\Local\Temp\pip-install-sxoj1r46\mmcv_00b42624230c46d08eb947bebf58265f\setup.py", line 304, in get_extensions
ext_ops = extension(
File "C:\Users\RETHINK\anaconda3\lib\site-packages\torch\utils\cpp_extension.py", line 1048, in CUDAExtension
library_dirs += library_paths(cuda=True)
File "C:\Users\RETHINK\anaconda3\lib\site-packages\torch\utils\cpp_extension.py", line 1186, in library_paths
paths.append(_join_cuda_home(lib_dir))
File "C:\Users\RETHINK\anaconda3\lib\site-packages\torch\utils\cpp_extension.py", line 2223, in _join_cuda_home
raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

As you are using comfy-embed you must use .\python_embeded\python.exe -m pip install instead of pip install from the log it seems to have picked up an anaconda env

Third times a charm?
(base) D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb>d:\ComfyUI\python_embeded\python.exe -m pip install -r requirements.txt
Ignoring tensorflow: markers 'platform_system != "Windows"' don't match your environment
Collecting gdown@ git+https://github.com/melMass/gdown@main (from -r requirements.txt (line 17))
Cloning https://github.com/melMass/gdown (to revision main) to c:\users\rethink\appdata\local\temp\pip-install-144y8qk5\gdown_69ea027033ad4fbca9edc1f61176288e
Running command git clone --filter=blob:none --quiet https://github.com/melMass/gdown 'C:\Users\RETHINK\AppData\Local\Temp\pip-install-144y8qk5\gdown_69ea027033ad4fbca9edc1f61176288e'
Resolved https://github.com/melMass/gdown to commit 57ea784c863290da4b880c035f99edad854234c3
Running command git submodule update --init --recursive -q
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Collecting onnxruntime-gpu==1.15.1 (from -r requirements.txt (line 1))
Obtaining dependency information for onnxruntime-gpu==1.15.1 from https://files.pythonhosted.org/packages/67/4c/03519d7dd781537083b8a0badfc15f6e334b3f7ba227a544860ded5c7157/onnxruntime_gpu-1.15.1-cp310-cp310-win_amd64.whl.metadata
Using cached onnxruntime_gpu-1.15.1-cp310-cp310-win_amd64.whl.metadata (4.1 kB)
Requirement already satisfied: imageio===2.28.1 in d:\comfyui\python_embeded\lib\site-packages (from -r requirements.txt (line 2)) (2.28.1)
Collecting qrcode[pil] (from -r requirements.txt (line 3))
Using cached qrcode-7.4.2-py3-none-any.whl (46 kB)
Requirement already satisfied: numpy==1.23.5 in d:\comfyui\python_embeded\lib\site-packages (from -r requirements.txt (line 4)) (1.23.5)
Collecting insightface==0.7.3 (from -r requirements.txt (line 5))
Using cached insightface-0.7.3.tar.gz (439 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [15 lines of output]
Traceback (most recent call last):
File "d:\ComfyUI\python_embeded\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
File "d:\ComfyUI\python_embeded\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "d:\ComfyUI\python_embeded\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "d:\ComfyUI\python_embeded\lib\site-packages\setuptools\build_meta.py", line 341, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
File "d:\ComfyUI\python_embeded\lib\site-packages\setuptools\build_meta.py", line 323, in _get_build_requires
self.run_setup()
File "d:\ComfyUI\python_embeded\lib\site-packages\setuptools\build_meta.py", line 338, in run_setup
exec(code, locals())
File "", line 11, in
ModuleNotFoundError: No module named 'Cython'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
(base) D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb>

Has there been any update to this?

Tried any and every fix I could find, no luck with this?
[comfy_mtb] | WARNING -> cv2.ximgproc.guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceswap because ModuleNotFoundError: No module named 'onnx.onnx_cpp2py_export.checker'; 'onnx.onnx_cpp2py_export' is not a package
Failed to import fun because ModuleNotFoundError: No module named 'png'

That's unfortunate...
I just checked quickly with the extensions I use and: Controlnetpreprocessors, ImpactPack, DaveCustomNodes and Disco Diffusion also install onnx... I will check which is using an older version later today!

It might be roop itself, it started after I added the roop custom_nodes . I'm not 100% sure

It might be roop itself, it started after I added the roop custom_nodes . I'm not 100% sure

Can you try again ideally following the new instructions, i.e using Comfy-Manager
https://github.com/melMass/comfy_mtb/blob/main/INSTALL.md

ERROR: Could not install packages due to an OSError: [WinError 5] Access is denied: 'A:\AI_Files\ComfyUI_windows_portable\python_embeded\Lib\site-packages\google\~-otobuf\internal\_api_implementation.cp310-win_amd64.pyd' Consider using the --user option or check the permissions.
[comfy_mtb] | INFO -> Some nodes failed to load:
Failed to import module faceswap because ImportError: cannot import name 'builder' from 'google.protobuf.internal' (A:\AI_Files\ComfyUI_windows_portable\python_embeded\lib\site-packages\google\protobuf\internal_init_.py)
Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
The install does not complete sucessfully and breaks these 2 nodes:

My guess is it's Comfy Roop and mtb that have incompatibilities since I've tested the install from scratch on all modes.
I will try Comfy roop next week, and honestly if it does exactly what my node do I will just remove FaceSwap, 90% of the dependency issues come from it.
Also as said before all other nodes will work fine if a few fail, maybe I'll remove auto install for the "extra" nodes and add manual install instructions. I don't want to spend this much time on solving all the various user configs which for now more than half the time I dedicate to this project is...

My guess is it's Comfy Roop and mtb that have incompatibilities since I've tested the install from scratch on all modes.
I will try Comfy roop next week, and honestly if it does exactly what my node do I will just remove FaceSwap, 90% of the dependency issues come from it.
Also as said before all other nodes will work fine if a few fail, maybe I'll remove auto install for the "extra" nodes and add manual install instructions. I don't want to spend this much time on solving all the various user configs which for now more than half the time I dedicate to this project is...

Sorry I don't mean to cause you headaches, thanks so much for what you are doing. I will figure it out.


⚠ Guya.moe Proxied has degraded performance

In 3ce3f3a, Guya.moe Proxied (https://ice.guya.moe/) experienced degraded performance:

HTTP code: 200
Response time: 12917 ms

Resolved: Guya.moe Proxied performance has improved in f8df069 after 5 hours, 49 minutes.


Prompt executed in 105.59 seconds

OH...
I entered the wrong path in Aniportraitloader
it works well


Implementing ByteSlice and ByteSliceMut for Vec

Adresses #992

Okay, now that #1215 and #1218 have landed, this can be rebased and the soundness issues should be addressable. In particular, we can implement ByteSlice and ByteSliceMut for Vec<u8>, but we can't implement any of the other traits.


Identify Invalid SPDX File format and Invalid Tag Value file as different error.

I have added a new Exception InvalidFileFormatException for catching all invalid files which are not tag value or rdf files and thrown the exception where all invalid Files were failing in BuildDocument.checkAnalysisNull  .
Also when handling expection I have separated, all the three exception in all the enclosing function -
Invalid file type - InvalidFileFormatException,
Invalid Tag Value File - InvalidSpdxTagFileException,
Invalid RDF or any other file not caught by the above exception  - Exception  ( Default Exception )
When in CompareSPDXDocs.convertTagValueToRdf the first two exception are caught and thrown as SpdxCompareException which result in terminating the function and show proper error. This way, these two types of file will not be passed as RDF Files in later function.
Only Invalid RDF, Valid RDF or any other file not caught by the first two exception are passed in the second function to check for RDF files.

@goneall  Done.


Support nalgebra 0.30 and 0.31

Updated the cargo.toml file to support both versions. Running cargo build with 0.31 seems to build without any issue on my machine.

Seems like there may be some issues with kiss3d (which would presumably have to have the same update) based on the tests.

@OTL given that this would require a corresponding fix in Kiss3d, how would you prefer we proceed?

Thanks for the PR! The situation is almost the same as before.
There are three major options we can choose from:
The first (regular) way is to update ncollide to use the latest nalgebra (https://github.com/dimforge/ncollide/pull/379), then update kiss3d to use the latest nalgebra and ncollide, and finally update this crate. This way may take longer as we need to wait for ncollide and kiss3d to be updated.
The second way is to replace the use of ncollide in kiss3d with another library (perhaps parry). I'm not the maintainer of kiss3d, so I don't know if this is possible or if this would be acceptable. If this way is accepted, then we need to wait only for kiss3d.
The third way is to replace the use of kiss3d and ncollide in all repositories under github.com/openrr with other libraries. We are considering moving from kiss3d to bevy, ncollide to parry, but don't have the bandwidth to do it right now (the maintainers would accept this approach if it works). In this way, there is no need to wait for other libraries updates. Of course, this way is the hardest.
For now, we are choosing the first way until we have the bandwidth to do the third.

I think that will work for private dependencies, but for public dependencies, I think one of the builds will break when both crate using k and nalgebra 0.31 and crate using k and nalgebra 0.30 appear in the dependency graph.

It does not seem to work as you said in https://github.com/openrr/k/pull/91#issuecomment-1375921174. For example, the following will cause a "mismatched types" error due to version mismatch:
[package]
name = "a"
version = "0.1.0"
edition = "2021"

[workspace]

[dependencies]
urdf-viz = { version = "0.41", default-features = false }

[patch.crates-io]
k = { git = "https://github.com/AndrewJSchoen/k.git" }

cargo tree output for the above is:
$ cargo tree -i -p<EMAIL_ADDRESS>-p<EMAIL_ADDRESS>nalgebra v0.30.1
├── kiss3d v0.35.0
│   └── urdf-viz v0.41.0
│       └── c v0.1.0 (/Users/taiki/projects/tmp/a/c)
└── ncollide3d v0.33.0
    └── kiss3d v0.35.0 (*)

nalgebra v0.31.4
└── k v0.29.1 (https://github.com/AndrewJSchoen/k.git#2023f12c)
    └── urdf-viz v0.41.0 (*)

(My original concern in https://github.com/openrr/k/pull/91#issuecomment-1376732024 was the case where crate like the above example and nalgebra 0.31 are both included in the dependency tree.)

For example, right now, I have another project that also uses/exports their own version of nalgebra (0.31) which means my build always breaks right now unless I use my own fork (which has the above dependency setting).

In this case, you are using a version of nalgebra that is incompatible with the version of nalgebra that k uses, so this is expected behavior. And patching until upstream is updated is also the correct workaround.


Add related span pointing at missing arguments

Fixes #25255

cc @DanielRosenwasser

Maybe instead of guessing for closest signatures we should only do this for one signature, but let's experiment a bit. 👍


sudo: If sudo is running in a container, you may need to adjust the container configuration to disable the flag.

Please provide steps to reproduce.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


CHEF-2657: fix failing specs.

The code looks correct here, so let the specs match that.

This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!


Filter options stay the same when you search again

User stories
As a user I don't want to choose the search options every time in order to save time and see the same results when pressing the search button again.
Dependencies
Depends on:

#19

Acceptance Criteria

[ ] Filter Options stay the same after searching
[ ] could be done with 'last_category_filter' etc

We will use the new filters.


ENH: Disabling TubeTK_USE_NUMPY and TubeTK_USE_PYQTGRAPH on CicleCI

On docker, TubeTK is tested against Slicer. TubeTK_USE_NUMPY now requires
both numpy and scipy. However, scipy and pyqtgraph are not part of Slicer.

Meh - would rather install numpy and pyqtgraph on the dockers, but this is ok for now.
So...looks good to me.  :)

@aylward numpy is installed in Slicer, but scipy is not. @jcfr is there a way to add scipy and other python packages to Slicer in the docker image of Slicer that we use?

You're right.  For slicer we should disable.
Thanks!
Stephen

Sent via phone.
On May 16, 2016 5:49 PM, "Francois Budin"<EMAIL_ADDRESS>wrote:

@aylward https://github.com/aylward numpy is installed in Slicer, but
scipy is not. @jcfr https://github.com/jcfr is there a way to add scipy
and other python packages to Slicer in the docker image of Slicer that we
use?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/KitwareMedical/TubeTK/pull/745#issuecomment-219559013

Merging now, so we can see if the PR are breaking something or not. I will try to find a better long term solution later.


Thin out lets in random spec

Related to https://github.com/rubocop-hq/rubocop-rspec/issues/862

To convince me, maybe someone could refactor this spec file [to reduce the number of used memoized helpers] and show me how it improves it?

Before submitting the PR make sure the following are checked:

[no] Wrote good commit messages.
[-] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[no] Squashed related commits together.
[x] ~Added~ crushed tests.
[-] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@marcandre refactoring is done, I'm ready for the harder part, part two, "show me how it improves it".

I poked around with some of this in my own PR here.

@marcandre refactoring is done, I'm ready for the harder part, part two, "show me how it improves it".

@pirj Did you actually want me to ask? I can if you want me to, but I can tell you already what I like in the PR: some changes that have nothing to do with this (like removing a "context" that's not really useful). Also, the originality of the commit messages ;-)
Otherwise I remain unconvinced that this is an improvement, and that it is worth whoever is writing this spec to worry about. The whole exercise seems as futile to me as reducing the number of local variables in a code.

I'm pretty happy already now when you don't mention that the spec looks significantly worse this way.
The whole point was to show that it is possible to write a spec by not using much lets. For the sake of merging a cop that would limit those usages to a certain number (5 lets allowed by default).
Otherwise, I'm ready for all the criticism. If you feel that some part of this became harder to understand/change/..., I'll be glad to hear your point on this. While working on cops/style guide I try to be as neutral as possible and accept distinct coding styles. So - no arguing included, just going to learn a new point of view.
No pushing/rushing, it's completely up to you, I will not be offended if you ignore this altogether, and I completely understand it - we're about to hit 1.0, just a few things left, and it will be beneficial to everyone.

I commented on #8491, partly because your PR's diff is noisier and appear to mix different improvements that are not related to the refactoring and thus felt harder to comment on.
Still, the bulk of your PR seems to be replacing some let with a shared context:
# before
let(:ignore_cop_directives) { true }
let(:allow_uri) { true }
let(:line_length_config) do
  {
    'Enabled' => true,
    'Max' => 80,
    'AllowURI' => allow_uri,
    'IgnoreCopDirectives' => ignore_cop_directives,
    'URISchemes' => %w[http https]
  }
end
let(:other_cops) { { 'Layout/LineLength' => line_length_config } }

# after
shared_context 'with LineLength settings' do |enabled: true,
                                              allow_uri: true,
                                              ignore_cop_directives: true|
  let(:other_cops) do
  {
    'Layout/LineLength' => {
      'Enabled' => enabled,
      'Max' => 80,
      'AllowURI' => allow_uri,
      'IgnoreCopDirectives' => ignore_cop_directives,
      'URISchemes' => %w[http https]
    }
  }
end

This introduces changes like:
# before
let(:allow_uri) { false }
# after
include_context 'with LineLength settings', allow_uri: false

I feel that using shared_context remains more technically and less known. The result is also more verbose. I like that this is a case where it's unlikely to make sense to want to change one setting of LineLength and only in a sub-context want to change another one, so your shared context makes clear that one can only specify these settings all at once. As for the verbosity, it makes things more explicit, I don't have a strong opinion on if it's better or worse overall, probably more like changing four quarters to a buck. In my mind, you are actually removing one let, the line_length_config; others are just shifted to keyword arguments to your shared context. It just so happens that the metric doesn't count those....
If I was reviewing some new Cop PR and got the current version with the lets, I wouldn't think twice about that and would not have an issue with this. If I got your shared_context version, I would be thinking "wow, looks like this submitter finds it so easy to write a shared context that it was worth it here, even given the additional verbosity", and I would also have no issue with that.
In short, I would have no trouble accepting either PRs, and I consider myself a tough reviewer. If I received a PR to switch from one to the other, I'd be wondering why, oh why, is the submitter focusing on that! If doesn't change much at all, just shifting how to specify allow_uri & al. I don't feel there's one way that is clearly superior to the other.
If one has time to spend on it, there are other things that would benefit more this spec. I notice there are many instances of expect(some_very_similar_string.length).to eq 79 for example. There's the strange "/#{'a' * 37}/" and probably a few other imperfections.
But ultimately, the biggest issue by far with this spec reveals a deep problem with the Cop itself: it knows way too much about the Layout/LineLength Cop. It should not be the job of IfUnless to know the existence of an Layout/LineLength/AllowURI setting! #8290 is but one solution to this. This is the kind of problems worth focusing on, in my mind.

Thanks! Your time is much appreciated.

My pleasure.
Maybe you did already, but did you say how much of an improvement you think the shared_context is?


Unnamed repositories

How can we get rid of this message, even present in the demo : http://gitlist-khornberg.rhcloud.com/ ?

Unnamed repository; edit this file 'description' to name the repository.

http://stackoverflow.com/questions/2041993/how-to-rename-a-git-project-name

The message could be improved to say which file to edit.
Unnamed repository; edit the file '.git/description' to name the repository

@dkozel. Suggested is correct for non bare repositories. Bare repositories have no .git folder. In a master repo server you tend to work with a bare repo over non bare repos

@DannyvdSluijs Right! The grammer change should be done though.
Unnamed repository; edit the 'description' file to name the repository


Fix typo, asychronously -> asynchronously

Found via codespell -S deps,_build -L pullrequest

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


Dev server crashes with invalid scss

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Dev server crashes without explanation when adding these lines of scss:
&__line {
    display: flex;
    gap: 0.8rem;

    &:not(:last-child) {
        margin-bottom: 1rem;
    }
}

I know it's invalid, but shouldn't we receive error instead of crash?
Minimal Reproduction
add this to any .scss file in any component:
&__line {
    display: flex;
    gap: 0.8rem;

    &:not(:last-child) {
        margin-bottom: 1rem;
    }
}

Exception or Error
node:internal/event_target:916
  process.nextTick(() => { throw err; });
                           ^
TypeError [Error]: Cannot read properties of undefined (reading 'column')
    at convertSourceSpan (node_modules\@angular-devkit\build-angular\src\tools\sass\worker.js:146:30)
    at MessagePort.<anonymous> (node_modules\@angular-devkit\build-angular\src\tools\sass\worker.js:111:27)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:647:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
Emitted 'error' event on Worker instance at:
    at Worker.[kOnErrorMessage] (node:internal/worker:289:10)
    at Worker.[kOnMessage] (node:internal/worker:300:37)
    at MessagePort.<anonymous> (node:internal/worker:201:57)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:647:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
    at Worker.[kOnExit] (node:internal/worker:267:5)
    at Worker.<computed>.onexit (node:internal/worker:198:20)

Your Environment
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 16.1.3
Node: 16.14.2
Package Manager: npm 8.5.0
OS: win32 x64

Angular: 16.1.3
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, localize, material, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1601.3
@angular-devkit/build-angular   16.1.3
@angular-devkit/core            16.1.3
@angular-devkit/schematics      16.1.3
@nguniversal/builders           16.1.1
@nguniversal/express-engine     16.1.1
@schematics/angular             16.1.4
rxjs                            7.8.1
typescript                      5.0.4

Anything else relevant?
 in .scss files  should i change it everywhere . please help


@universal-login/sdk build fails:

yarn build execution report error:
@universal-login/sdk
$ yarn clean
$ rimraf dist
$ tsc --build tsconfig.build.json && tsc -p tsconfig.declaration.json
 | universal-login-sdk/lib/integration/http/fetch.ts(8,3): error TS2322: Type '(url: RequestInfo, init?: RequestInit | undefined) => Promise<IResponse>' is not assignable to type '{ (input: RequestInfo, init?: RequestInit | undefined): Promise<Response>; (input: RequestInfo, init?: RequestInit | undefined): Promise<Response>; }'.
 |   Type 'Promise<IResponse>' is not assignable to type 'Promise<Response>'.
 |     Type 'IResponse' is not assignable to type 'Response'.
 |       Types of property 'headers' are incompatible.
 |         Type 'IHeaders' is not assignable to type 'Headers'.
 |           Types of property 'forEach' are incompatible.
 |             Type '(callback: (value: string, index: number, headers: IHeaders) => void, thisArg?: any) => void' is not assignable to type '{ (callbackfn: (value: string, key: string, parent: Headers) => void, thisArg?: any): void; (callback: Function, thisArg?: any): void; }'.
 |               Types of parameters 'callback' and 'callbackfn' are incompatible.
 |                 Types of parameters 'key' and 'index' are incompatible.
 |                   Type 'number' is not assignable to type 'string'.

the problem seem related to typescript version (DOM Updates):
https://devblogs.microsoft.com/typescript/announcing-typescript-3-6/#dom-updates


NIRISS/SOSS data reduction pipeline

The steps for this task are currently being tracked via this Project.  The pipeline currently runs Stages 1 - 4 to completion.  There are areas where the code could be improved (1/f correction, 0th-order contamination detection and masking, broken MAD calculation), but this is a good first start.
At some point, we'll also have to develop a suite of tests.

@taylorbell57 I'm mostly looking for high-level feedback on implementation. I've applied a few different approaches to integrating NIRISS into Eureka!.
For example, in optspex.clean_median_flux and straighten.straighten_trace the code checks the instrument name and, if it is niriss, it calls niriss.clean_median_flux and niriss.straighten_trace otherwise, it continues with the existing code.  Alternatively, I could see us calling inst.clean_median_flux and inst.straighten_trace from s3_reduce.py and have one instrument point to another instrument's implementation if they are identical (e.g., nirspec.fit_bg or nirspec.cut_aperture). As a third option, I could switch to utilizing wrappers (e.g., straighten.straighten_wrapper) instead of calling an instrument-specific routine.  See optspex.optimize_wrapper for this style of implementation.
For plotting, I'll often write a wrapper around the function call and add order as an optional parameter.  Other times, I use an if/else statement inside the plotting routine (see plots_s3.optimal_spectrum) to get the desired plot.

I'm personally in favour of inst.clean_median_flux and inst.straighten_trace - that's in keeping with what we've done for other functions (e.g., background subtraction) which has been working pretty well so far and neatly allows instrument-specific tunings to stay in instrument-specific files. I've been dealing with a kind of similar issue for WFC3 observations as well, so this might help setup a good framework for WFC3 too
As for plotting, your methodology seems fine to me based on my quick glance at what you've done so far,

@taylorbell57 This PR is ready for its first review.

@kevin218, sounds good - I don't think I'll be able to get to this until next week though, FYI

@taylorbell57 I've been puzzling over the failed PyMC3 install for a while now.  The specific error is: ModuleNotFoundError: No module named 'numpy', which is strange in of itself, but also the error doesn't come up with Erin's latest PR, so it must be something related to this PR (even though I didn't change anything relating to PyMC3).

Update: The environment.yml file for PASTASOSS requires numpy=1.23.4; however, pymc3 requires numpy[version='>=1.20.0,<1.22']. I submitted an issue to request that they remove their overly-strict constraints on all package version numbers.

One thing we can try in the interim is using the pip install --no-deps flag which ignores any dependencies and then just specify any extra dependencies ourselves. I don't know for sure if that'd work within the setup.cfg or environment.yml files though. And to be clear, I only mean to do that for PASTASOSS

One thing we can try in the interim is using the pip install --no-deps flag which ignores any dependencies and then just specify any extra dependencies ourselves. I don't know for sure if that'd work within the setup.cfg or environment.yml files though. And to be clear, I only mean to do that for PASTASOSS

I see multiple requests for this functionality online, but no one has implemented this capability.  We could always fork PASTASOSS and remove the dependencies ourselves, but I'm going to give STScI a few days to solve the problem on their end.

Note I also merged the main branch into your branch to help make sure any issues are obvious (some past bugs have arisen during the merge process)

Turns out it was a good thing I did merge in main since a new bug popped up with the non-PyMC3 test

Ah, it turns out the pytest bug wasn't introduced with your PR but with Erin's recent PR (the same error popped up in this pytest run: https://github.com/kevin218/Eureka/actions/runs/12204503871/job/34049745506)

I meant to ask, have you tried using this code to reproduce the ERS NIRISS/SOSS transit spectrum of WASP-39b? It'd be good to know that this works at least vaguely okay before merging it into main.

I meant to ask, have you tried using this code to reproduce the ERS NIRISS/SOSS transit spectrum of WASP-39b? It'd be good to know that this works at least vaguely okay before merging it into main.

Just this afternoon, I produced a transmission spectrum of WASP-94Ab and found that it matched surprisingly well with an independent reduction.  The white LC isn't as clean as I'd hoped (scatter_mult = 3.27), but the other reduction also sees a significant amount of red noise, so the noise isn't exclusive to Eureka!.
At this point, I'm confident that the NIRISS pipeline has no major flaws and is mostly in need of fine tuning.


Upload test images

Uploading test images and a test page to see how higher-resolution PNG and SVG images are behaving.

Test finished, we will go with SVG images. Closing PR without merging.


Gambia marriage abroad

https://trello.com/c/YXaeSNfJ/495-gambia-marriage-tool-no-longer-a-commonwealth-country-content-change-request
I've updated the 9 opposite sex outcomes to reflect the fact that the Gambia is no longer a Commonwealth country.
This doesn't affect the logic.

Closing this as it has been superseded by #3097


GEOMESA-1594 Debugging print outs present in Kafka 10 KafkaConsumerTest

Signed-off-by: Charles Kelly<EMAIL_ADDRESS>

haha, these messages are great. merging


[Feature] Overwrite Colors accents

Before Requesting

[X] I found no existing issue matching my feature request
[X] This request is related to Millennium, and not a request for a specific theme/addon

Describe the feature you'd like!
I would like to have the option to overwrite the accent color picked from Windows and maybe other colors.
Currently, it takes on the system accent color, which in my case is a dark gray. This results in a gray-on-gray appearance that isn't visually appealing. It would be great to have a setting in Fluenty to choose a custom accent color.
Thank you for considering this feature request!
Anything else?
No response

Great suggestion, I'll take a look into it right now!

Implemented! https://github.com/SteamClientHomebrew/Millennium/commit/a850936e40688345a90646d92600cd6e506ea623. It will be in the next update.


python, warnings: Multiple code improvements in "generate_vars.py" & "validator.py"

Removing code warnings.
Adding a missing import.
Local variables' renaming to improve readability, fixing confusing/bad names.
Removing unused method parameters.
Different code reorganizations to improve readability.
Fixing typos (including the ones that are visible to the user).
Adding a "TODO" to be handled later.

Signed-off-by: Pavel Bar<EMAIL_ADDRESS>

ci test please


Document the configuration of relevant properties when connecting to/from existing message-broker infrastructure

@sabbyanandan commented on Fri Jan 25 2019
As a user, I'm attempting to connect to existing Rabbit infrastructure including the predefined exchange/queue resources; however, I'm unable to determine what properties to enable/disable, so the framework doesn't auto-create them differently.
More background in slack conversation here.
Notes:

@garyrussell suggested adding a new section (perhaps: Using SCSt to consume from existing infrastructure (exchange/queue) that could be useful as a reference.
It might also be helpful to define the requirement first, and follow-up with an example in this section.
Probably also clarify this in the context for both Rabbit and Kafka binders.

@garyrussell commented on Fri Jan 25 2019

Probably also clarify this in the context for both Rabbit and Kafka binders.

There's really no complexity with Kafka since the destination is simply the topic name,  but I suppose it won't hurt to mention that.

We don't need to do anything in the Kafka binder explicitly - it is already natively handled. We do, however, in Rabbit, so I will move it (again) to Rabbit binder.

Issue moved to spring-cloud/spring-cloud-stream-binder-rabbit #239 via ZenHub


Problems with Nuxt 3.0.0

Reproduction
Simple modification of Nuxt Stackblitz demo
Steps to reproduce the bug
Trying to get this to work on Nuxt 3.0.0 release, and am stuck.  You have a published StackBlitz demo but it's for RC13.  Update the repo by:

Change package.json requirement to: "nuxt": "3.0.0"
Try to run the app.  You will get an error "ERROR  Cannot start nuxt:  _nuxt.defineNuxtConfig is not a function" but this is not the main issue.
Change nuxt.config.ts by removing the line: "import { defineNuxtConfig } from 'nuxt'".  It seems you are supposed to do this now on the 3.0.0 release?
Attempt to run the app again.

Expected behavior
I would like to see Pinia in my DevTools.
Actual behavior
Nuxt fails, with this error message.
[🍍]: getActivePinia was called with no active Pinia. Did you forget to install pinia? const pinia = createPinia() app.use(pinia) This will fail in production.
Additional information
No response

Released a new version and fixed the example

Thank you sir!  I was able to get it to work in my environment.
FYI -- https://nuxt.com/docs/getting-started/configuration

A minimal configuration file exports the defineNuxtConfig function
containing an object with your configuration. The defineNuxtConfig
helper is globally available without import.

You should probably update the StackBlitz demo to use 3.0.0 also.

ah, nice, thanks!


Encoder acceleration is poor

Encoder acceleration needs looking at again. Currently it sends two or three callbacks when it detects that rotation pulses are more frequent.

Fixed in V1.02.


Provide controlled Checkbox

It should be possible to use Checkbox as a controlled component. Currently it takes a checked prop, but clicking on the checkbox changes the value even if checked isn't updated.
I suggest changing checked to defaultChecked, and adding a new checked property that when set makes the Checkbox act like a controlled component.
I'm happy to do the work for this change.

What's the core issue behind #438? Is it about making the React code more semantically similar to the HTML output?

#438 provides access to the <input type='checkbox'> element. This way you should be able to control the checkbox with regular html attributes.

The problem with the current API is that the component is halfway between a controlled and uncontrolled component. If you set the value the checkbox updates, but if the user clicks the checkbox and you don't update the value then the checkbox's state falls out of sync with the value prop which can be problematic. Furthermore it's not possible to prevent the checkbox's value from changing by listening to onChange and not updating the value prop.
React handles this elegantly by providing checked and defaultChecked props. If you set checked to a value there's no way to change the checkbox other than by listening to onChange and updating that value. Just clicking the checkbox won't do anything without the event handler, so checked always stays in sync with the component's state in the UI.
If instead you set defaultValue, then that value is set at the beginning of the checkbox's life and has no further impact. You can't use defaultValue to change the state of the checkbox once it's been loaded, and you aren't required to update anything in your event handler (or to even have one) to allow the checkbox to change state when a user clicks it.
I've created a small demo here: http://jsfiddle.net/ytq61r8a/1/.
What I'd like to do is provide users with the same API as they get when using a vanilla React <input type="checkbox" />.

@levibotelho, after reading your last post it sounds like the proposed fix of #438 would also fix the issue you're encountering. The idea is to allow people to compose the checkbox like so:
<Checkbox>
  <NativeCheckbox {...inputProps} />
</Checkbox>

With this change, you should be able to pass whatever props you'd like.

@moog16 makes sense, thanks!


Add the option to use analytical weights in 2-step diff-in-diff estimator

Refers to #557
Check that results are close to R's did2s effect's standard error and coefficient.

pre-commit.ci autofix

Took a first look and this looks great! Will take a second look and then likely merge tomorrow morning. Is the test data set published under a license that allows us to re-publish it?

Took a first look and this looks great! Thanks @marcandre259! Will take a second look and then likely merge tomorrow morning. Is the test data set published under a license that allows us to re-publish it?

I'm not aware of a license associated with the data. Here is some background info that may be useful in deciding whether it can be hosted for testing.
It is data published by the American government (.gov) and cleaned by the authors below. It's referenced in Scott Cunningham's the mixtape and taken from Cheng Cheng and Mark Hoestra (2013). He says:
"The data they used is somewhat standard in crime studies. They used the FBI Uniform Crime Reports Summary Part I files from 2000 to 2010"
The data comes from:
DOES STRENGTHENING SELF-DEFENSE LAW DETER CRIME OR ESCALATE
VIOLENCE? EVIDENCE FROM CASTLE DOCTRINE
By Cheng Cheng and Mark Hoestra (2013)
Who point out the following:
Outcome data come from the FBI Uniform Crime Reports (UCR) and cover all 50
states from 2000 – 2010. 10 Specifically, we use homicide, burglary, robbery, and
aggravated assault data from the official UCR data published online by the FBI. 11 In
addition, for the other variables not available from the online UCR, we use data from the
FBI’s Master files (Return A and Supplemental Homicide Report).

@marcandre259 I dropped the new test data set (even though it is likely ok to include it, for example it is distributed via the R did2s package) and refactored the did2s tests - they now all run via the df_het data set. Will merge after the CI passes. Thanks for implementing this!


feat: update introduction.mdx for the React SDK

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


pls help

When i leave pulse sensor it gives me BPM
How can make BPM=0 when i leave sensor?

There is a setting called Threshold in the code at the top of the sketch.
Try increasing this value (range is 0 - 1023) to see if that helps.


Modus Data Table(with tanstack) - Column visibility - Keyboard navigation(arrowUp/arrowDown)

Description
Column visibility dropdown can be accessed by keyboard navigation; dropdown items can be handled by either Tab, ArrowUp, or ArrowDown keys.
References #1426
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

We have renamed our table component. This PR might not be useful anymore. hence closing this one.


RFP - open-video-downloader

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://github.com/jely2002/youtube-dl-gui
Direct download URL for the software / installer : https://github.com/jely2002/youtube-dl-gui/releases/download/v2.4.0/Open-Video-Downloader-Setup-2.4.0.exe
Software summary / short description: A cross-platform GUI for youtube-dl made in Electron and node.js

Hi @pauby,
Actually, this package already exists here and seems up to date. The maintainer of this package is @A-d-r-i.

Thanks @Xav83 . I'll go ahead and close this now.


What syntax for multiple returns?

For the definition site, things seems straightforward.
fun div(a, b: Int): Int, Int do
   return (a/b, a%b)
end

The only question is about parentheses. In the current grammar, parentheses are mandatory in the return. But do we still force them to be mandatory in the signature foo(a,b:Int): (Int, Int) ?
For the client site, things become quite complex.
Do we force parenthesis in left-values?
(q, r) = div(7, 3) # or
q, r = div(7, 3)

Do we allow any kind of left-values?
Especially when each left value in a multiple-return can have a distinct nature.
var q, var r = div(7,3)

var q
#...
q, var r = div(7,3)

x.foo.bar, y.baz["hello"] = div(7,3)

I did not comment on this (old) issue but +1 for the latest proposal of @egagnon

I like the proposal of @egagnon
But, as the language swift, and in the way of OO of Nit,
i see the functions with multiple return values like an object.
ie, in the signature of our function, we could name our return values like:
fun div(a, b: Int): (div: Int, mod: Int) do return a/b, a%b

In fact, we could be stored both variables in a unique variable as:
var division = div(7,3)

and get return values like an object:
print "Division of 7 by 3: {division.div} modulus: {division.mod}"

@Tagachi seems like you will create a lot of disposable instance of your kind of tuple?

I do not really like anonymous tuples with named fields in statically typed languages as they are hard to expose, reuse, document or extends, that is somewhat contradictory with statically typed OO that encourages these things.
Such a tuple is analogous to a class, except that a class has a name, can have super-classes and can have methods
So let just try to expose the class instead!
class DivResult
   var div: Int
   var mod: Int
end

Then the div method can happily use it
fun div(a,b: Int): DivResult do return new DivResult(a/b, a%b)

Note that for the client, this change nothing except that things are more OO-clean.
var division = div(7,3)
print "Division of 7 by 3: {division.div} modulus: {division.mod}"

So one first issue is: is the addition of tuples useful?
I do not think that in this case anonymous types really worth it as standard classes seem to solve the thing.
As said @Morriar one other issue with the approach is the mandatory allocation.
The last issue I see is mot philosophical: is this really useful with a real meaning?
I thing that the point about multiple return is when we have to return things that are not cohesive or not meaningful per se. Here, I do not see in which other cases the tuple (or the class DivResult) could be reused, even in the client code having a single variable to hold both the quotient and the remainder seems more an artifact of the programming language than a real need of the programmer or a real meaningful abstraction for the designer.
As an analogy, the same could be done with parameters (and is in fact done in some functional languages and some dynamically typed OO languages that does have a different philosophy than Nit).
fun div(data: (dividend, divisor: Int)): Int do return data.dividend/data.divisor
var data = (7,3)
var res = div(data)

Here, again, I do not this that the tuple used as an argument is that useful for the programmer.
It may be useful for the language designer so that all function only need now to accept a single argument and that everything about multiple arguments is solved (delegated) trough tuples.
Yes, this also allows the user to do some nice tuple shenanigans in a programmatic way, especially it also simplify some issue when meta-programming (or functional-programming).
But again, does the additional complexity worth it?

Ping ? More and more I'd like to use this kind of structures, mainly for performance reasons.
The last example coming to mind is from the Codec class, and particularly its UTF-8 counterpart in my current refactor of the I/O library:
class Writer
    var codec: Codec = utf8_codec is writable
    fun write(s: Text) do
        var b = codec.code_string(s)
        write_bytes(b. items, b.length)
    end
end

class UTF8Codec
    fun code_string(s: Text): Bytes do
        var b = new Bytes.with_capacity(s.bytelen)
        b.append_text(s)
        return b
    end
end

One easy optimization the could be done here would be to directly return a NativeString instance from the passed Text if it is a FlatString along with its bytelen, avoiding the creation of ephemeral instances here (which could add up badly if a lot of strings are written like in the compiler, where these manipulations are done 1.4M times).
So considering @egagnon's proposal was accepted as a good one, can we expect such a feature to be implemented in a (near?) future @privat ?

Ping ? This would be a fun addition to the language :)

I don't know if it's to late but personally I prefer this syntax :
x, y = div(5, 2)

It seem very simple and intuitive to use! And I think this write is closer to the script syntax language.


improvement try to read enough filtered rows in segment_iterator

Proposed changes
After filter the data Status SegmentIterator::next_batch(vectorized::Block* block) maybe only output a few rows, this is inefficient.
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.93 seconds
load time: 566 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027132220_clickbench_pr_34832.html


Requirements / Setup

I assume this plugin needs both GoogleService-Info.plist and google-services.json in the root of your project? Did I miss the documentation for this somewhere? Does the plugin require any dependencies such as cordova-support-google-services? I've tried installing it by assuming the previously mentioned files need to be in the root of the ionic/cordova project but I'm still not seeing anything on my fabric dashboard.

@MarkAMcCorkle cordova-support-google-services is a dependency of this plugin. You can see that by looking at the plugin.xml file in this repo. It should however pull that in when you install the plugin. You could verify that by running 'cordova plugin list' in the root of your project. It should exist in both your package.json and config.xml with the same version if it was installed properly. I mention this because after uninstalling and reinstalling various plugins to get things to work, mine got out of whack and had different versions.
It makes sense that GoogleService-Info.plist and google-services.json need to be included - but cannot verify for certain this plugin requires them.

I assume this plugin needs both GoogleService-Info.plist and google-services.json in the root of your project? Did I miss the documentation for this somewhere? Does the plugin require any dependencies such as cordova-support-google-services? I've tried installing it by assuming the previously mentioned files need to be in the root of the ionic/cordova project but I'm still not seeing anything on my fabric dashboard.

As stated in the readme of https://github.com/chemerisuk/cordova-support-google-services your services files (.plist and .json) don't need to be placed in your root directory. Put them anywhere you want, but you have to reference those files in your config.xml via <resource-file tag (look at the readme.md file). After each prepare / before a build those files should be ported to the correct folders.  They will be overwritten each time you prepare/build/whatever build step prepares.
To verify:
Android:
platforms/android/src/app/google-services.json
iOS:
platforms/ios/{PROJECT_NAME}/Google-Services.plist