Cuspatial version

Hello! What version of the cuspatial package are you actually using?
In instruction Docker image rapidsai/rapidsai:cuda11.5-runtime-ubuntu20.04-py3.8 is used which has rapids of version 23.04. But, probably, in this version the API of cuspatial.point_in_polygon  was changed and test.py fails:
TypeError: point_in_polygon() got an unexpected keyword argument 'poly_points_x'

Hello,
I have same problems, it looks like arguments of the function cuspatial.point_in_polygon() are not correct, according to the documentation:
https://docs.rapids.ai/api/cuspatial/nightly/api_docs/spatial/#cuspatial.point_in_polygon
The signature is: cuspatial.point_in_polygon(points: GeoSeries, polygons: GeoSeries)
I managed to make it work with a complicated and not clean workaround:

Conversion of the points into cuspatial.Geoseries:
points = cs.GeoSeries([sPoint(p_x[idx], p_y[idx]) for idx in range(len(p_x))])

Conversion of the polygons into a cuspatial.GeoSeries:
p_x = list(self.points_x.to_numpy()) p_y = list(self.points_y.to_numpy()) poly_x = list(poly_dict['poly_points_x'].to_numpy()) poly_y = list(poly_dict['poly_points_y'].to_numpy()) polygons = cs.GeoSeries(make_polygons(poly_x, poly_y))

and I added a function to create polygons from 2 lists of x and y coordinates (to put at beginning or end of the plane_evaluation.py script):
def make_polygons(poly_x, poly_y):     polygons = []     sx, sy = poly_x[0], poly_y[0]     p = [(sx, sy)]     nb_points = len(poly_x)     flag = False     for i, (x, y) in enumerate(zip(poly_x, poly_y)):         if i!=0:             p.append((x, y))             if (x==sx) and (y==sy):                 if flag:                     flag = False                 else:                     polygons.append(sPolygon(p))                     p = []                     if i != nb_points-1:                         sx, sy = poly_x[i+1], poly_y[i+1]                         flag = True     return polygons
This workaround worked for me, but inference time is a bit long and I think it is due to this function call, I get around 5s/image on a Nvidia P100 GPU, and I don't know how fast it should be.
Tell me if that works for you

Thanks for reporting the issue.
I'll adapt the project to the latest cuspatial docker and lock down the version.
If I run into problems I'll lock to an older cuspatial docker.

@DavidGillsjo Did you manage to update the docker? Can't get this to work at all on my machine.

I did manage to get the code running with the newer cu-spatial version. See this branch.
Unfortunately I did not get the same performance with the old model weights, so there might be a bug or possibly a need to retrain the model using the new functions.
I'm afraid I don't have the time or resources to retrain the model, but if I find some time I will continue with the debugging.

Hello @DavidGillsjo
when installing the code and running  sudo ./run.sh from docker-cuspatials, I am getting this error:
xauth:  file /root/.Xauthority does not exist
xauth: (argv):1:  unable to read any entries from file "(stdin)"
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy'
nvidia-container-cli: initialization error: nvml error: driver not loaded: unknown.
Would you please help me to get it running?

Hello @DavidGillsjo,
Have you made any progress in improving the results (wights) for the inference_issues branch?


Densenet: takes at least 3 arguments (4 given)

When I change the code to make depth 40, dense block 3, k=12
File "run_cifar10.py", line 206, in
args.plot_architecture)
File "run_cifar10.py", line 91, in run_cifar10
weight_decay=weight_decay)
File "/home/ubuntu/GPT/DeepLearningImplementations/DenseNet/densenet.py", line 177, in DenseNet
weight_decay=weight_decay)
TypeError: transition() takes at least 3 arguments (4 given)

The code is running fine with the default options. When Change to depth 40, dense block 3, k=12
its throwing error

@ayushman-shopin please refer to #70 to see if that solved your problem.


Using cognito /logout endpoint not initiating new authn handshake with GitHub

Hi Timothy,
So the token integration is working well for us 🥳  with the authorize endpoint.
I'm now testing the clearing of the session via the /logout Cognito endpoint.  My scenario is as follows:

Logout of GitHub
Call the /logout Cognito endpoint
Call the /oauth/authorize Cognito endpoint

My expectation is that I should be presented with the GitHub authentication screen but I am getting the access and id tokens back again without authentication.
I have spoken to AWS and screen shared with them.  Their suggestion was to speak with you.  Is it possible the shim is caching the id token and returning it instead of initiating the sign in flow with GitHub?  Clutching at straws...
I can talk to our CTO about some airpairing if you're available and OK with signing an NDA?  Where are you based?
Thanks again for your help
Ben

Interestingly, when the /oauth/authorize endpoint is called again in step three, although it's not triggering a new auth flow to GitHub, it is sending a new access and id token (ie different to the ones sent in the prior call to authorize before step 1).
So Cognito is starting a new session but for some reason not initiating the GitHub auth...

Yes, that’s right. This is exactly the situation I described on the other issue you raised.
When the user tries to log in to cognito, cognito defers them to GitHub.
If they are already logged in on GitHub, GitHub immediately returns a successful session to Cognito.
Only when they are not logged in on GitHub or have not yet authorized your application will they see the GitHub login page. This behaviour is up to GitHub, and is not part of your application, cognito, or the shim.
If you check the logs, you should see the authorise flow being triggered correctly.
Sent from my mobile

On 26 Mar 2021, at 6:16 pm, Ben Sullivan @.***> wrote:

Interestingly, when the /oauth/authorize endpoint is called again in step three, although it's not triggering a new auth flow to GitHub, it is sending a new access and id token (ie different to the ones sent in the prior call to authorize before step 1).
So Cognito is starting a new session but for some reason not initiating the GitHub auth...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

How did you go with this one? I’ll close for now, feel free to reopen if there is a problem
(I’m based in Melbourne, Australia)

Hi yeah I solved it - turns out cognito session cookie doesn't work as expected if window.location.href used so I switched to putting the link in the html button.  Thanks again for your help!

Oh right! I've never tried it that way - always used the link. Glad it
works!
On Wed, 7 Apr 2021 at 16:02, Ben Sullivan @.***> wrote:

Hi yeah I solved it - turns out cognito session cookie doesn't work as
expected if window.location.href used so I switched to putting the link in
the html button. Thanks again for your help!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/TimothyJones/github-cognito-openid-wrapper/issues/51#issuecomment-814627072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG7HQL46YC3HYDGJMZNIP3THPYPTANCNFSM4Z22J3RQ
.


Migrations are not run on Plugin Update | Migrationen werden bei Plugin Update nicht ausgeführt

Used Shopware Version: <IP_ADDRESS>
**Description: **
The migration used to create the languages added by the SwagLanguagePack Extension are only run on plugin install (intended migration behavior), due to the timestamp staying the same between versions. This creates the problem, that updating from a version <2.1.0 to a version >2.1.0 will not add the new languages or snippet_sets.
**Environment: **

Shopware <IP_ADDRESS>
SwagLanguagePack 2.1.2

Steps to reproduce:

Install SwagLanguagePack version <2.1.0
Update to version >2.1.0

**Expected result: **
Languages that are added with updates to the extension are written to the database when updating the plugin.
**Actual result: **
No new languages added in the update are available.
Workaround until fixed:
Delete migration entry for the extension and run it manually via php bin/console database:migrate SwagLanguagePack --all

[public] Shopware automated response: This issue is linked to the internal issue: LAN-132
[created from LAN-132, comment 514147]


Over 900MB RAM usage

OS:
MacOS Version 10.12
Machine:
MacBook Pro (Retina, 15-inch, Mid 2015)
2.5 GHz Intel Core i7
16 GB 1600 MHz DDR3
Issue Descriptions:
This app consistently takes up >900MB ram. This is comparable to entire chrome app that has >10 tabs. Is this normal? Can we memory profile this app on a mac and see if there are ways to minimize the memory usage.
Steps to Reproduce:
Run it on a mac.

I'm seeing this issue on OS X 11.6 (El Capitan) as well. I'm not sure how much value there is in actually debugging the perf issues vs. the amount of time it might take. That being said, if the issues can be found and fixed easily, please do so :)
My proposal instead would be to offer a "low res" or basic mode option, that only shows a list (no expensive graphics or visualizations) of what's playing and what's coming up.

This app consistently takes up >900MB ram. This is comparable to entire chrome app that has >10 tabs. Is this normal?

No this isn't normal.  But in answer to the coming question "What can I do about it?".
Nothing.  There is absolutely nothing you or I can do about this RAM usage because (at least from the screenshot you provided) it is being caused by GPM not by my code.  Those helper processes run the GPM site itself.
The best I can suggest is to relaunch the player every now and again.  That and to cross your fingers that the resource usage improvements of Chromium 54 will help this when they hit Electron 1.5 👍
Sorry 😢

is this issue also on the windows version of the app? I am getting over a gig of mem usage when using the app? This causes the music to start lagging out then the app starts freezing and slows down drastically?


Explore add_features_for_residues function in feature/atomic_contact.py

Currently nested for loops are used to compare each atom of one residue against each atom of the other residue and extract information one comparison at a time.
There is likely a way to get the sum/minimum/etc (whichever is applicable) in one shot, perhaps using some numpy function.
This is likely to be faster and definitely more pythonic and readable.

 Especially considering that the people using this framework will always have to convert a huge amount of files.


⚠ Samsung has degraded performance

In bafac2c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2370 ms

Resolved: Samsung performance has improved in ab3c3b4.


test(manager): add more manager unit tests

Secure Coding Practices Checklist GitHub Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[x] Input Validation
[x] Output Encoding
[x] Authentication and Password Management
[x] Session Management
[x] Access Control
[x] Cryptographic Practices
[x] Error Handling and Logging
[x] Data Protection
[x] Communication Security
[x] System Configuration
[x] Database Security
[x] File Management
[x] Memory Management
[x] General Coding Practices

Codecov Report
Base: 39.67% // Head: 60.43% // Increases project coverage by +20.76% :tada:

Coverage data is based on head (bc2bad9) compared to base (c7e547d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #142       +/-   ##
===========================================
+ Coverage   39.67%   60.43%   +20.76%
===========================================
  Files          29       35        +6
  Lines        1641     2267      +626
===========================================
+ Hits          651     1370      +719
+ Misses        911      742      -169
- Partials       79      155       +76

Flag
Coverage Δ

unittests
60.43% <100.00%> (+20.76%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

manager/middlewares/authenticator.go
67.39% <ø> (ø)

base/utils/config.go
82.17% <100.00%> (+37.00%)
:arrow_up:

base/utils/kafka.go
77.35% <100.00%> (+52.35%)
:arrow_up:

base/utils/prometheus.go
100.00% <100.00%> (+100.00%)
:arrow_up:

pyxis/api.go
88.42% <100.00%> (ø)

pyxis/profile.go
65.51% <0.00%> (ø)

pyxis/metrics.go
100.00% <0.00%> (ø)

pyxis/database.go
66.34% <0.00%> (ø)

base/api/client.go
65.95% <0.00%> (ø)

... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Icons for Google Docs/Sheets/Slides etc.

Wow, I have been searching for this capability for months, thank you so much for building it.
I believe the most powerful part of your program is the .desktop file generation for the Google Docs formats.  It is awesome that I can double click a Google Sheet in my file manager and Chrome opens with the spreadsheet ready to edit.  The fact that I am editing the file actually stored on Google's servers is even better, no worries about sync errors or other problems.
Because you are building a .desktop file for each document I believe you could add an icon that indicates the file type (basically simulate a mime type icon).  If you included an icon for Docs, Sheets, etc. in the ~/.gdfuse directory then you could add an icon=/home/username/.gdfuse/gdocs.png line to the .desktop file for each item as it is created (just noticed .desktop files refuse to follow the ~ might be better to install the icons to /usr/share/icons).  I would recommend the icons for the various programs but if you feel that might cause copyright problems, I'll gladly build you a set of similar icons with no copyright issues.
Maybe I'll try to build a bash script to implement this for my own use, looks like I can grep for /spreadsheets/ or /document/ and then append the corresponding Icon line to the .desktop file.
Thanks again for the great program!
Regards,
J. Jordan

I think I will add a configuration option per file-type (e.g. spreadsheet_icon) so that you can specify any icon you want: a system icon or a custom icon (that you can put in ~/.local/share/icons/...). Hope that works for you.

Sounds great!
On Tue, Jun 16, 2015, 12:15 PM Alessandro Strada<EMAIL_ADDRESS>wrote:

I think I will add a configuration option per file-type (e.g.
spreadsheet_icon) so that you can specify any icon you want: a system
icon or a custom icon (that you can put in ~/.local/share/icons/...).
Hope that works for you.
—
Reply to this email directly or view it on GitHub
https://github.com/astrada/google-drive-ocamlfuse/issues/126#issuecomment-112533324
.

Should be available in version 0.5.17. Remember to clear the cache after changing icons in config file.

Wow, Thanks for the quick response.  I'm really lazy and don't have a
system handy with a build environment set up, how often do you usually
update the PPA?
Thanks again,
-j
On Tue, Jun 16, 2015 at 1:22 PM Alessandro Strada<EMAIL_ADDRESS>wrote:

Should be available in version 0.5.17. Remember to clear the cache after
changing icons in config file.
—
Reply to this email directly or view it on GitHub
https://github.com/astrada/google-drive-ocamlfuse/issues/126#issuecomment-112557511
.

I usually upload the .debs as I publish a new version. I think the PPA should already be updated.

Yes, it is updated, I should have taken a look before I asked, sorry.
On Tue, Jun 16, 2015 at 1:38 PM Alessandro Strada<EMAIL_ADDRESS>wrote:

I usually upload the .debs as I publish a new version. I think the PPA
should already be updated.
—
Reply to this email directly or view it on GitHub
https://github.com/astrada/google-drive-ocamlfuse/issues/126#issuecomment-112562051
.

Don't worry. No need to apologize. :smile:

5.17 Love it, beautiful, fantastic!  Got to spread the word on this awesome
software sent a tip to OMG Chrome to do an article on it.  Don't know if
they will.  I have Peppermint 5 on a couple of systems and just started
playing with Chromixium both of those projects should include
google-drive-ocamlfuse in their installations.   This was really all that
was missing to allow a Linux installation to do everything a ChromeBook can
and still have the power of Linux when you want or need it.
Grazie mille. Andare al piano di sotto per abbracciare il mio 1992 Alfa
Romeo Spider Veloce in tuo onore.  (Google translate, my 1 semester of
Italian is pretty much gone.)
-j
On Tue, Jun 16, 2015 at 1:40 PM Alessandro Strada<EMAIL_ADDRESS>wrote:

Don't worry. No need to apologize. [image: :smile:]
—
Reply to this email directly or view it on GitHub
https://github.com/astrada/google-drive-ocamlfuse/issues/126#issuecomment-112563106
.

Thanks! I'm glad you find this project useful.


Resolve "Unit Tests and Bugfixes for sicd_elements ImageFormation"

Add additional unit tests for the sicd_elements module, specifically ImageFormation.py
This PR:

Minor bugfixes for sarpy/io/complex/sicd_elements/ImageFormation.py
New tests in test_sicd_elements_imageformation.py

Details + Before/After coverage report
ImageFormation.py
BUGFIX: The code should set self.TxFrequencyProc to a new instantiation of TxFrequencyProcType when it does not exist.  Instead the code was doing the opposite.
Coverage from main branch:
pytest tests --cov=sarpy.io.complex.sicd_elements.ImageFormation --cov-report term-missing

Name
Stmts
Miss
Cover
Missing

sarpy/io/complex/sicd_elements/ImageFormation.py
206
106
49%
61-68, 98-103, 111-113, 121-123, 128-131, 134-139, 150, 167, 184-190, 225-232, 322-333, 362-368, 496-513, 516-522, 538-548, 565-567, 578, 589-593, 604-607, 618

TOTAL
206
106
49%

Coverage from this branch:
pytest tests/io/complex/sicd_elements/test_sicd_elements_imageformation.py --cov=sarpy.io.complex.sicd_elements.ImageFormation --cov-report term-missing

Name
Stmts
Miss
Cover
Missing

sarpy/io/complex/sicd_elements/ImageFormation.py
206
0
100%

TOTAL
206
0
100%

performing code review and testing


Build Problems and OS X Support

I'm trying to get this toolchain (minus vivado) running on Mac OS 10.14.6, and have run into a few problems; some may be Mac related, and perhaps that's unsupported, but some seem more general.
Following the Readme:
Set up all tools and added them to my path, set appropriate environment variables.
$ source settings.sh
no such file.  From the git history, it looks like it's been renamed env.sh, so I used that instead.
$ make env
no such target.  Looks like make conda might be appropriate, since we're setting up a python environment.  So I ran that, and did some manual setup that I don't recall at the moment to get things running.
$ python3 fpgaperf.py --toolchain arachne --project oneblink --device "hx8k" --package "ct256" --board "breakout"
fpgaperf.py: error: --family argument required.  Looks like it's missing a required flag.  Looking at the next example, I set family to xc7.  This may well be wrong, but it made the tool run.
That ran the Yosys portion successfully, but then generated the following error:

End of script. Logfile hash: af0a50ac80, CPU: user 0.38s system 0.06s
Yosys 0.9+1706 (git sha1 2bda51ac, gcc 10.0.1 -fPIC -Os)
Time spent: 44% 12x read_verilog (0 sec), 14% 1x share (0 sec), ...
arachne-pnr -d 8k -P ct256 -q -p empty.pcf oneblink.blif -o oneblink_arachne.asc
oneblink.blif:10: fatal error: unknown directive '.subckt'
make: *** [oneblink_arachne.asc] Error 1
rm oneblink.blif
This looks like something I've run into before when trying to read hierarchical blifs with tools that don't support them.  But at this point I decided to ask for help.
It seems like the readme is out of date; if anyone could direct me on how to properly get started with this tool, I'd really appreciate it.
Thanks,
Scott

Thanks for filing this @srtemp.
Regarding the various README issues you are right, there have been quite some changes lately and the README is out of date, I will update it accordingly.
Currently, ice40 tests are not being run in CI, therefore it may be that the blif error is a latent bug in fpga-tool-perf. I'll try to add that as well to the benchmarks run in CI.

@srtemp FYI, the README has been updated

Thanks @acomodi I'll give it another try!
I appreciate you working on this so promptly

@srtemp If you don't mind using Nix on your Mac, you could try: https://github.com/HackerFoo/nix-symbiflow
Then, in your checked out repo, run:
nix-shell /path/to/nix-symbiflow -A fpga-tool-perf --use-prebuilt-symbiflow false

It will take a while.

@HackerFoo
Thank you; I'll give that a try.
I just moved to using a VM with 16.04 and have gotten it running, but a native install would be much better.  I appreciate it.


how to get closed issues?

final Map<String, String> para = new HashMap<String, String>();
para.put("project_id", project_id);
final ResultsWrapper resultsWrapperMain =  mgr.getIssueManager().getIssues(para);
can't get closed issue.

Hi,
By default the status is "Open" and you have to specify in your Map.
To get all status use the value "*".
para.put("status_id", "*");

@Yoshiiix thank you, I added this to README file


Need to add short month in mask(dd/mmm/yyyy - 10/Aug/2020)

I cant able to find mask like this in this plugin (dd/mmm/yyyy - 10/Aug/2020). Is there is any way to do like this?

Hi ghost,
Did yo solve your problem?
I was searching but it seems there is not solution so far using the datetime.


release QA: test create-realm experience

Before we release 1.6, we should test /create_realm to make sure it works nicely in light of some recent changes.  In particular, we want to look at what happens in the left sidebar after these two actions:

Create the realm in dev using /create_realm
Immediately reload the page.

The behavior that we expect to be possibly quirky is how we show active streams in the sidebar.  Streams are inactive until there are actual messages on them, but we recently added code to make them appear active when users are first notified about them.  (Also, we made it so that we no longer wait till you have 40+ streams to split active/inactive in the sidebar.)

This was tested successfully.


guoyww/animatediff-motion-adapter-v1-5-2 is missing

cant find this directory

motion_adapter_path points to animatediff's huggingface repo, and the code is supposed to download it automatically when running. The url of this repo is https://huggingface.co/guoyww/animatediff-motion-adapter-v1-5-2. If your machine cannot get access to huggingface, you can download this model manually and put it under /path/to/your/animatediff/folder/, and change motion_adapter_path to your local folder.
The same procedure should be followed for the ip_adapter_path if you encounter similar access issues.


Get data regarding emergency protocol

Would it be worth to get information regarding countries' implementation of some specific emergency protocol? This information could be stated as a vertical line on the plot. Would it be helpful to check the impact on the shape of the curve?

More context about countries would certainly be useful. Do you have an
idea of a source?

I don't know the WHO as something about it: https://www.who.int/emergencies/diseases/novel-coronavirus-2019/events-as-they-happen

seems hard to imagine that there will be single events that will have a
visible effect. I agree that it could be useful to know e.g. when Italy
shut down travel, but it seems like this would need to be curated manually
and it's not clear to me that it's worth the effort....
On Sun, Mar 15, 2020 at 3:17 PM Guillaume Lemaitre<EMAIL_ADDRESS>wrote:

Would it be worth to get information regarding countries' implementation
of some specific emergency protocol? This information could be stated as a
vertical line on the plot. Would it be helpful to check the impact on the
shape of the curve?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/covid19-dash/covid-dashboard/issues/22, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGUVEFSW3YKY2O3SECH7ELRHVHWNANCNFSM4LLNX7IA
.

--
Russell A. Poldrack
Albert Ray Lang Professor of Psychology
Professor (by courtesy) of Computer Science
Bldg. 420, Jordan Hall
Stanford University
Stanford, CA 94305
<EMAIL_ADDRESS>http://www.poldracklab.org/

this would need to be curated manually

I think this is true.

it's not clear to me that it's worth the effort....

Fair enough. I was thinking that it could be valuable when forecasting since successive protocols should hopefully have an impact.

If we want to add interesting information on the graph, @twiecki has started to curate a list of interventions:
https://twitter.com/twiecki/status/1240405642063552512
They could be added somewhere on the graph with good hover information.


Missing try/except for Bio.Alphabet in abutils/core/pair.py

There should be
try:
    from Bio.Alphabet import generic_dna
except ImportError:
        generic_dna = 'DNA'

in abutils/core/pair.py similar to the other commits you made recently otherwise abstar 0.4.3 does not work for me immediately after pip installing.
Or perhaps the problem is that upgrading my abstar from 0.3.5 to 0.4.3 didn't also upgrade to the latest abutils . . .

Yeah, it looks like an old version of abutils is to blame. I'll update requirements..txt to specify the appropriate abutils version.

Yeah, it looks like an old version of abutils is to blame. I'll update requirements..txt to specify the appropriate abutils version.


I have changed the color and font

Hey, Developer of this website, I have changed the color and font family of this website. So that It feels like new because I wanted to give it a new refresh look. And you have also done a great job. Thanks, I hope you will consider my request. Thanks again.

Thank you for taking the time to contribute. I appreciate your effort to refresh the design but I think it doesn't add any value to the project.
Thanks again for your contribution!


Calling function of a class

Hey,
great library!
But is it also possible to call a function of an object with parameters?

I actually worked on this a few days ago. I can get a pointer to the vtable and all get of the symbol names, however there is no way to demangle them unfortunately, so they are kind of useless.
I saw a proposal to add a demangle function to the stdlib, but no progress has been made on it. Until then I don’t see a way to do it.

Ok thanks for the answer. So I think as this not possible at the moment I'll close the issue until I hear something new in the Swift forum about function reflection.

I actually worked on this a few days ago. I can get a pointer to the vtable and all get of the symbol names, however there is no way to demangle them unfortunately, so they are kind of useless.
I saw a proposal to add a demangle function to the stdlib, but no progress has been made on it. Until then I don’t see a way to do it.

How to get method list of one instance?


Semicolon docs: fix list formatting in source file

PR checklist

[ ] Addresses an existing issue: #0000
[ ] New feature, bugfix, or enhancement
[ ] Includes tests
[x] Documentation update
[ ] Enable CircleCI for your fork (https://circleci.com/add-projects)

What changes did you make?
Fix formatting for semicolon rule docs.
Is there anything you'd like reviewers to focus on?
(optional)

@vgrigoriu thanks!

@vgrigoriu thanks!


Throw when accidentially passing SteamIDs as numbers

Since JS numbers are too small to convey SteamIDs, I'd expect all functions to throw if I accidentially pass a number instead of a string. The current behavior, silently carrying on with a rounded version of the number, is one of the worst strategies I could imagine.

Yes, though it would be better to check to make sure it's not a number instead of checking if it is a string.
if (typeof steamID === 'number') {
  throw('Dangerous use of number for steamID.')
}

This will ensure the use of a Long (from bytebuffer, which this library uses) is still allowed, in addition to a SteamID class.

I'd be ok with the more strict type check as well. Catching the number mistake is just the minimum safeguard. :-)


Some tweaks to ensure compat with newer Go

I upgraded to 1.11 on my laptop and thought I would clean up some minor things. Newer gofmt, a tweak to a format string to please newer vet, and fixing one test where the error message appears to vary between Go versions.

Coverage remained the same at 22.778% when pulling fc98bfb9fbd7d91e406ef5d9264a689f56a8259b on coderanger:go-1.11 into 0b75a899208a459b912b71c42c1493149d0efda2 on zalando-incubator:master.

The JSON error thing is apparently already fixed upstream: https://github.com/golang/go/issues/27464
I just have bad timing.


Added michael collin to ap engieers team

Added new joiner Michael collins

not sure about the error, do I need to invite michael to github team first, then raise this PR, Can someone in core-infra team to tell me ? thank you

From Super-Linter output, it wants you to align the comments
terraform/github/teams.tf
--- old/terraform/github/teams.tf
+++ new/terraform/github/teams.tf
@@ -41,8 +41,8 @@
     "BrianEllwood",
     "tom-webber",
     "bogdan-mania-moj",
-    "Emterry",   # Emma Terry
-    "ahbensiali",  # Abdel Bensiali
+    "Emterry",    # Emma Terry
+    "ahbensiali", # Abdel Bensiali
     "michaeljcollinsuk"
   ]

not sure about the error, do I need to invite michael to github team first, then raise this PR, Can someone in core-infra team to tell me ? thank you

From Super-Linter output, it wants you to align the comments
terraform/github/teams.tf
--- old/terraform/github/teams.tf
+++ new/terraform/github/teams.tf
@@ -41,8 +41,8 @@
     "BrianEllwood",
     "tom-webber",
     "bogdan-mania-moj",
-    "Emterry",   # Emma Terry
-    "ahbensiali",  # Abdel Bensiali
+    "Emterry",    # Emma Terry
+    "ahbensiali", # Abdel Bensiali
     "michaeljcollinsuk"
   ]

@jacobwoffenden , sorry for bothering you gain 😞 ..... still complaining ......


react-native run android is not working for me

What is wrong?
app is not getting build in to my phone.
on running $react-native run-android on windows cmd
gradle repo is getting downloded and installed while installing application to device I'm getting this error
Exception in thread "main" java.lang.NullPointerException
at org.gradle.wrapper.BootstrapMainStarter.findLauncherJar(BootstrapMain
Starter.java:34)
at org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.ja
va:25)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:127)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Where does it happen?
it happens on graddle I guess i don't know clearly
How do we replicate the issue?
just use command react-native run-android
How important is this (1-5)?
I am not even able to create a sample hello world app because of this issue.
Expected behavior (i.e. solution)
App should open in my android device

Yes all the details are present.
Regards,
Arun
On Mon, Mar 26, 2018, 1:18 PM React Native Bot<EMAIL_ADDRESS>wrote:

[image: Boxbe] https://www.boxbe.com/overview This message is eligible
for Automatic Cleanup<EMAIL_ADDRESS>Add cleanup rule
https://www.boxbe.com/popup?url=https%3A%2F%2Fwww.boxbe.com%2Fcleanup%3Fkey%3DYBvpjiofgN32UkrB4WxkOqylFXQZp0EZkSEQLNVcUAo%253D%26token%3D1X7aOYPKUUFOvBe7FYNEvoInRN4yjQaa3L7yiHZtJkBttRFGHNTEDEnq3mp4a0W%252FkcqKDadkAX0yuddgK2wibY5Rw0v%252FHtUcLIa00nf8lH3v%252FtZsQtldCYEvBAZNBln4UB0cT6YXhc7WhlkT5L4%252B%252Fg%253D%253D&tc_serial=37810635833&tc_rand=246362949&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001
| More info
http://blog.boxbe.com/general/boxbe-automatic-cleanup?tc_serial=37810635833&tc_rand=246362949&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001
Thanks for posting this! It looks like your issue may be incomplete. Are
all the fields required by the Issue Template
https://raw.githubusercontent.com/facebook/react-native/master/.github/ISSUE_TEMPLATE.md
filled out?
If you believe your issue contains all the relevant information, let us
know in order to have a maintainer remove the No Template label. Thank you
for your contributions.
How to Contribute
https://facebook.github.io/react-native/docs/contributing.html#bugs • What
to Expect from Maintainers
https://facebook.github.io/react-native/docs/maintainers.html#handling-issues
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/18560#issuecomment-376075214,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM04n1CJuJ9mj-nIUqr9-avWwSS36rGYks5tiJzagaJpZM4S6p0I
.


Schoology graduation year is off

Around line 69 of functions/functions/sgyauth.js it seems that the fetched graduation year from Schoology is off (fetched 2023 for me, whereas should be 2024). Not quite sure why yet.

Is it possible it's using yu-ting's course data?

No, I think it's schoology's internals being a year off. I remember seeing back when CC was in its infancy and it just pasted the JSON stringified schoology data in the page that my graduation year was listed as 2022. I'll try and find a discord message link.

https://discord.com/channels/710932856251351111/710936824121655396/829069203772014662
Grad year listed as 2022 for me ¯_(ツ)_/¯

I guess we can just offset the grad year by 1, though I don't know how consistent this issue is. Is it 1 year off for everyone?

Could conduct some tests to be sure but I'm pretty sure its 1 off for everyone. I'll close this issue for now.


Bring back the ContentMD5 standard header

It doesn't have to be exposed as a constant but it is still under heavy enough use that I believe it merits a standard header slot.
Removed as part of #67

Do we really want to make it easier to use a header that involves MD5? What harm does it do to leave it out?

As no one else has commented wishing this existed, I'm eager to just close this. If I'm wrong, pile on here and we can re-open.


Node-RED page iteration

Description

The hero section will be more oriented to explaining what Node-RED is
The e-book will be the main CTA
If the content in the hero section makes the "What is Node-RED" content seem repetitive, we'll remove it
Add an anchor to FAQs, so we can share an URL that goes directly into that section

@Hasmin-AC I'll need the text for points 1 and 2. You can use the current length of the text we have in those sections as a guide, at least as a starting point to see how it looks.
Epic/Story
#1932
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

Requested SEO agency for input on this as well. Will share recommendations soon.

I'm adding @ZJvandeWeg's comments from other issues related to this one so we can discuss:
https://github.com/FlowFuse/website/issues/1777#issuecomment-2074211914

I feel like the /node-red page should behave like /node-red/core-nodes/. To have a sidebar so we can build pages on them.

https://github.com/FlowFuse/website/pull/1963#issuecomment-2071766785

I start to believe we need to put this under /node-red/*. So this would be flowfuse.com/node-red/variables. We can move other blogs there too, to have one hub for all resources on how to leverage Node-RED with FlowFuse.

So, this would be like a documentation page, right? A completely different design than what we currently have, more educational and not commercial.

Here's the reworked content for the Node-RED page.
One other recommendation from the SEO agency is to internally link to this page as much as possible from other pages and blogs.

I will audit and categorize the blogs we have now to move them docs like the structure suggested by ZJ. URL can be Flowfuse.com/node-red// similar to core nodes

This is how the landing page would look with the content provided by Hasmin.
@ZJvandeWeg This is what I meant when I said that what Hasmin described wasn't quite the usual documentation layout. However, it can work similarly to https://dashboard.flowfuse.com/, which has a landing page with a different structure from the rest of its pages. I believe you even suggested it in one of our meetings, and Hasmin mentioned it in the Google Docs attached to this issue.
@Hasmin-AC, the text in the hero section was a bit long. I tried to shorten it, but if you could make it even shorter, I think it would look better. Also, the deployment options, you mentioned dedicated in the doc, but now it has edge device instead. I kept it as we have it now, let me know if it will be replaced with the dedicated content.
Also, I was thinking that maybe we could add a secondary button, similar to the one on the homepage, that directs users to the learning resources pages. These pages would be the ones with left column where users can navigate through all the content we'll add there. You  both mentioned that this landing page should focus on educating people about Node-RED, so I believe that having a link to all the resources above the fold would be beneficial.
As part of an iteration, I could develop this landing page without the "SEE ALL" link or the secondary button mentioned above. And for the next one, we could build that centralized Node-RED resources page. What do you think?

Looks nice @Yndira-E !

Looks Good @Yndira-E
How many words or characters would you like me to cut? One note about the existing page was that it was a little light on content so I wouldn't want to scale back too much.
I will add some text for dedicated to add to the deployments section.
For the resources, the idea is to have something similar to https://flowfuse.com/node-red/core-nodes/, where it's like a documentation hub,  for things like Variables etc. We can go live with this for now and once I've curated the content we can implement and link for the next iteration.

@Hasmin-AC

How many words or characters would you like me to cut?

Around 100, if possible

See doc for revised intro text.
Also lets add the question "Who uses Node-RED?" to the FAQ. Text for the answer to this is also in the doc.


RFC - Spatial Queries & Virtualisation in XYFlow

Summary
This RFC explores the potential of adding additional functionality to XYFlow to allow for more complex graphs while still remaining performant for smaller graphs and the general case.
Motivation
For larger more complex graphs, it is possible to achieve improved performance when zoomed in by only rendering the nodes that are visible within the viewport. Currently this is achieved by performing a naïve axis aligned bounding box check on each node & edge. This still requires that all node and edge data is available to the renderer and does come with a performance overhead, especially for smaller graphs and when zoomed out.
Similarly, the multi-selection rect uses similar logic to find nodes that intersect with the selection rect. The multi-selection rect also does not support direct selection of edges.
For advanced cases with a client/server architecture, it would be desirable to be able to lazily fetch data for a given region of the viewport.
For client architectures, it would be desirable to be able to speed up viewport intersection and selection rect performance, and to potentially offer the ability for direct box selection of edges.
Implementation
There is a class of data-structures known as BVH (Bounding Volume Hierarchies) that allow for fast, coarse grained intersection testing. BVHs are widely used in systems such as mapping software and in game development for rendering (including ray-tracing) and physics. These work by placing an axis aligned bounding box around each entity within the system and constructing a tree that contains these boxes in a manner that allows for efficient lookup. Insertion and removal has a time complexity of approximately $O(log_k(n))$, depending upon the data structure used. For larger graphs, this may represent a significant improvement over a naïve approach.
However this is not a given and would require profiling for specific use cases. Additionally baking in a particular structure and its inherent assumptions would negatively impact bundle size. Therefore the API offers a means for users to provide two functions, potentially asynchronous ones, that fetch the nodes and edges respectively within a particular bounding box. These are an overload of the already existing nodes and edges props. When the viewport is moved, or the selection rect is used, these functions are called. Additionally, the API allows the means of invalidating the cached value of a particular node or group of nodes, or even a region within the viewport. This has precedent in that there is already a useUpdateNodeInternals() hook.
This offers a third way of interacting with the XYFlow libs, which represents a middle-ground between controlled and uncontrolled flows. In this third way, the data store remains the authoritative source of graph information, while removing the expensive data integration step and allowing users to use intersection tests of their choice.
There is an additional option to optimistically update nodes when moved or connected which helps maintain interactivity in the face of slow-downs.
XYFlow provides adapters for particular BVH implementations and has created a pro example of a client/server architecture that uses these new APIs to lazily load data as needed.  An additional pro example shows how to implement collision resolution using these APIs that reuses the BVH provided by the BVH package.
May also want to add option to configure padding of viewport, so that panning and zooming don't necessarily always trigger a refetch.
Drawbacks

Adding a third way to interact with XYFlow libs may introduce additional complexity for users
Adding a third way to interact with XYFlow libs may introduce an additional maintenance burden.
Maintaining internal state becomes more complex as cache invalidation needs to be handled.
Optimistic updates may introduce additional complexity in internals.

Alternatives
Intersection Function
This alternative narrows the scope of the feature to simply provide an function that returns the set of node/edge ids that intersect with a given bounding rect. This would be a lot simpler to implement, however it has the downside that it may not provide enough of a performance boost for large graphs to make the implementation lift worth it.
Allow nodes and edges to come and go
Implementors could provide a transient set of nodes and edges based on viewport position. To implement this, it would need to be validated that nodes and edges can arbitrarily be removed or added to the set of nodes and edges without catastrophic performance hitches. Additionally this would not solve the problem of maintaining user interactivity in cases where updates to the store are slow or asynchronous. To solve that in user land, it would require a similar effort to implementing it once in the library.
Bake in BVH support into the library
Has similar issues to the intersection function alternative.
Unresolved Questions

Open Question: Ordering may be tricky with optimistic updates and cache handling and invalidation

Open Question: How to document and communicate these changes effectively to users

Open Question: How to effectively support this across all packages

Open Question: MiniMap support?

Open Question: Selection-rect support for edges. Implement parser for edge renderer?

Thanks so much for the RFC! I am just going to dump a couple of thoughts here.

Performance metrics to check out for Spatial Querying implementation: initial build time, single update, bulk update, point query, rect query, memory

I know BVH trees from 3D game engines, where you have a lot of overlapping bounding boxes and the goal is mostly ray intersections. It might be interesting to see how different spatial data structures behave in this regard as flow graphs are usually a little further spaced out. But maybe this becomes irrelevant when edges are also taken into consideration... Do you have a good resource/information/experience on how in our case BVH might be the way to go?

In my head it would work like this:

maintain an AABB in internal node

build up a BVH tree in adoptUserNodes or updateNodeInternals

query the BVH when viewport moves to render visible nodes (make mounting/unmounting of nodes faster to prevent lag)

(maybe) only update the tree after node dragging has finished

expose interface for querying the BVH tree
If I look at the performance of javascript BVH implementations I don't think an async function is really needed and it might degrade performance as async does not come for free and complicates computation ordering. Plus some of that work has to be done anyway when updating node dimensions/positions.
Is there a really a use case for exposing anything more, even have a cache?

I think if you'd want to lazy load nodes you'd have to load all nodes and edges (maybe not all edges) in advance with no information attached to them. And then implement a placeholder node that fetches the information when it gets into view/big enough. You could also create a way to batch the calls from these nodes. But I feel like this can be implemented implicitly and does not require more BVH API surface area.

This would also pave the way for canvas based edges

Hey @ncthbrt
thanks for this detailed RFC!
Even if React Flow wasn't built for huge graphs, I really like the idea of having a better support and a better performance in general. In v12 we already improved the performance for dragging nodes in bigger graphs, but the onlyRenderVisibleElements implementation wasn't touched.
It was always important to us, that React Flow is flexible and adjustable. Maybe it's an option here to expose some functionality, so that users can implement their own intersection algorithms (just yesterday someone created an issue #4272 that goes into that direction). For now we are using getNodesInside for the selection rectangle and onlyRenderVisibleElements. Would it be possible for you to use a BVH if you could overwrite that function somehow? It would be nice if we could find a better implementation than the current naive approach and give users the option to overwrite that functionality. What do you think about that?

@moklick It would be possible to do that I think. I can work on a POC to that end?
Thanks for the comments @peterkogo

That would be great, but let's wait for @peterkogo feedback here. I know he is also interested in the topic and maybe he already started something!
Would you like to make a POC for a better built-in virtualization or expose functionality or both?
To answer you open questions:

Ordering may be tricky with optimistic updates and cache handling and invalidation

Not needed for now when we focus on virtualization first

How to document and communicate these changes effectively to users

We should try not to introduce breaking changes, but only more options. We could create a page under /learn where we explain how to use a quadtree or something like that with the new API.

How to effectively support this across all packages

Let's focus on React first.

MiniMap` support?

I think it would make sense to implement an alternative canvas based minimap at some point but I would like to postpone this task.

Selection-rect support for edges. Implement parser for edge renderer?

In my view a naive approach via nodes is enough (if one connected node is visible, an edge is visible too)

Happy to do that too!

@ncthbrt I talked to @moklick about how to move forward on this.
You submitted this RFC at an undoubtably tumultuous time here at xyflow :) Just to give a bit of context, we have changed quite a lot about the inner workings of Rect Flow for the next release and are in the middle of a rewrite of Svelte Flow. There is one (hopefully) very last thing we would like to get into v12, which would influence (and simplify) this RFC immensely - namely how we handle node origins.
Just as a rough timeframe, I will create a PR with the node origin changes in the next 2 weeks, so we can move forward on this afterwards. I'll keep you posted!

Thanks. That sounds promising!
On Mon, 13 May 2024 at 17:06, peterkogo @.***> wrote:

@ncthbrt https://github.com/ncthbrt I talked to @moklick
https://github.com/moklick about how to move forward on this.
You submitted this RFC at an undoubtably tumultuous time here at xyflow :)
Just to give a bit of context, we have changed quite a lot about the inner
workings of Rect Flow for the next release and are in the middle of a
rewrite of Svelte Flow. There is one (hopefully) very last thing we would
like to get into v12, which would influence (and simplify) this RFC
immensely - namely how we handle node origins.
Just as a rough timeframe, I will create a PR with the node origin changes
in the next 2 weeks, so we can move forward on this afterwards. I'll keep
you posted!
—
Reply to this email directly, view it on GitHub
https://github.com/xyflow/xyflow/issues/4239#issuecomment-2107908336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCJEWI72DG2LBQWHMAXKC3ZCDJGVAVCNFSM6AAAAABHDN3TYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXHEYDQMZTGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

I made a shallow deep dive into acceleration structures for spatial queries so here are my 2 cents.
Due to the declarative nature of React Flow (pass in edges, get out fancy graphs), we pretty much have to expect the nodes and edges to change 100% in between updates. Whatever algorithm we chose in the end, fully rebuilding the structure should be fast.  To further extend on the point, we can simplify the implementation by a lot if we manage to do this in a stateless fashion and without additional heuristics (e.g when do we just update vs fully rebuild).
I did some preliminary testing on implementing Quadtrees, a BVH and using the libraries rbush and flatbush.
Quadtrees

Pretty fast to construct, but you end up with a lot of inefficient trees for various situations
If the full extent you'd like to subdivide is not known from the start (which might happen if we don't want to iterate over all nodes before adding)
managing a lot of empty space as well as managing node density, is both influenced by tree depth
deciding on what depth and how many nodes per leaf to choose can vary depending on type of flow graph

BVH

surprisingly complex and a lot of work involved in optimizing the partition algorithm
might take a little longer to construct
you end up with a pretty good tree very easily

rbush & flatbush

bulk insertion is really fast
tree is very optimal
it can deal with a lot of weird spatial distributions quite well
it's a tested library and just weighs around 3kb
flatbush is only really faster for tens of thousands of nodes (when fully rebuilding)

So thats that. I am very inclined to just used rbush - it should be noted however that its currently in a broken state in terms of build dependencies (already opened a pull request) & es module support (forking might be the easiest route, not sure if library will be updated...)
I will release a small benchmark repo for these things soon, however have to deal with js module issues 🥲 first...

This RFC initiative looks exciting. I have a use case that I wonder could complicate the algorithm:
How about nodes that grow?
For context, on my project I have a diagram that represents the sitemap of a website. I drag and drop elements onto the nodes, that make the nodes grow and I then trigger a relayout with d3-flextree and d3-hierarchy

@fredericrous this RFC would support dynamic changes to node size & position. Should be no problem.

Nice work on the POC @peterkogo.
Still want to experiment with improving performance beyond culling nodes but not in a huge rush to do so right now, so this could be a great intermediate win.

Thanks for the deep dive and the detailed explanation @peterkogo!
We could fork rbush and publish it under @xyflow/rbush. If your PR mourner/rbush#138 gets merged, we can replace the dependency with the original rbush package again.
Do I get it right, that the rough process would be:

build a new tree when nodes come in (in adoptUserNodes for example)
use tree for culling (onlyRenderVisibleElements)
use tree for node selections

Questions:

do we want to export helpers to query it?

That sounds about right!
We can expose functions for finding intersecting nodes with a node, intersecting with an arbitrary rectangle, and finding all collisions as well.

Would edges also be included in this?

Currently we create a box of the connected nodes. We could do the same here and create a tree for the edges too. wdyt @peterkogo

@ncthbrt what other ideas do you have?

Still want to experiment with improving performance beyond culling nodes [...]

Some ideas from me: add a inView prop to custom nodes & edges, so it's easier to lazy load things. Maybe have some kind of padding to load things that are slightly out of view as well.

Would edges also be included in this?

I would include edges sooner or later, because implementing hover effects on canvas based edges will require this eventually. Though for culling only, having a fast way to determine if either the source or target node is in view would already come a long way.

The biggest bottleneck that I've measured for large, zoomed out graphs has been the store update logic (I'm using yrs, a Rust port of yjs) and updating a thousand or more nodes in the store within a transaction can be quite costly. My hypothesis is that a tiered/hierarchical approach to updates would be appropriate for slower stores. In this hierarchy, responsiveness would be maintained by optimistically updating properties in an internal store until an appropriate idle point is reached at which point the updates are written back.

I have some updates from my investigation I'd like to share.
On accelerating spatial queries
First and foremost, RBush and Flatbush turned out to be delightful libraries. Overall, Flatbush performed slightly better than RBush in terms of memory usage & garbage collection delays — even though it required am additional mapping of node IDs to Flatbush indices. Both libraries needed to be extended by a function determining full intersections.
However, measuring the performance impact of building these trees (~1ms with 2500 nodes on M3 Apple Silicon) I realized that we started our optimization journey on the wrong end, really. With our current naive method, determining which of the 2500 nodes is in view takes roughly 0.25ms (I'm re-discovering every time how astonishingly fast computers can iterate over arrays), which is a fraction of the 80ms it takes to re-render all the elements.
The very same bottleneck applies to the lag observed with onlyRenderVisible enabled or while drawing selection boxes: the biggest culprit is mounting/unmounting/updating React components. What a bummer…
No need to fret
Well, what do we make of this?
For one, the virtualization part of this RFC would be much more impactful, than focusing on faster intersection algorithms. onlyRenderVisible for instance, provides quite a boost in performance when interacting with big flows with partially visible nodes & edges. The only downside is, that moving the viewport tends to be laggy as nodes & edges need to be constantly mounted and unmounted while coming into view. Having a way to render placeholder nodes (possibly canvas based) while moving the viewport and only rendering the actual nodes in their full glory when the interaction has stopped, would make it a far more recommendable option. One limitation of this approach, however, is that nodes and handle positions need predetermined dimensions and positions for this to work. As a small consolation, you would receive SSR for free.
Further, having the ability to render the minimap and edges on a canvas, would pose another possibility to bypass reacts lifecycle overhead. Tradeoffs of canvas-based approaches apply.
Conclusion
This was quite valuable research, thanks for providing the impulse. We will most definitely use Flatbush in the future for supporting pointer interactions on canvas elements, and we will also look into possibilities for delaying certain state updates during interactions. This helped us quite a lot in identifying more fruitful optimization paths.

My message sounds unintentionally very conclusive. We will continue working on this.

I agree with this. And mirrors my performance profiling

I have some updates from my investigation I'd like to share.
On accelerating spatial queries
First and foremost, RBush and Flatbush turned out to be delightful libraries. Overall, Flatbush performed slightly better than RBush in terms of memory usage & garbage collection delays — even though it required am additional mapping of node IDs to Flatbush indices. Both libraries needed to be extended by a function determining full intersections.
However, measuring the performance impact of building these trees (~1ms with 2500 nodes on M3 Apple Silicon) I realized that we started our optimization journey on the wrong end, really. With our current naive method, determining which of the 2500 nodes is in view takes roughly 0.25ms (I'm re-discovering every time how astonishingly fast computers can iterate over arrays), which is a fraction of the 80ms it takes to re-render all the elements.
The very same bottleneck applies to the lag observed with onlyRenderVisible enabled or while drawing selection boxes: the biggest culprit is mounting/unmounting/updating React components. What a bummer…
No need to fret
Well, what do we make of this?
For one, the virtualization part of this RFC would be much more impactful, than focusing on faster intersection algorithms. onlyRenderVisible for instance, provides quite a boost in performance when interacting with big flows with partially visible nodes & edges. The only downside is, that moving the viewport tends to be laggy as nodes & edges need to be constantly mounted and unmounted while coming into view. Having a way to render placeholder nodes (possibly canvas based) while moving the viewport and only rendering the actual nodes in their full glory when the interaction has stopped, would make it a far more recommendable option. One limitation of this approach, however, is that nodes and handle positions need predetermined dimensions and positions for this to work. As a small consolation, you would receive SSR for free.
Further, having the ability to render the minimap and edges on a canvas, would pose another possibility to bypass reacts lifecycle overhead. Tradeoffs of canvas-based approaches apply.
Conclusion
This was quite valuable research, thanks for providing the impulse. We will most definitely use Flatbush in the future for supporting pointer interactions on canvas elements, and we will also look into possibilities for delaying certain state updates during interactions. This helped us quite a lot in identifying more fruitful optimization paths.


grid search among models and hyperparam values

To complete the experiment, I'd like to implement a grid-search over model and hyperparameter search space.

closed via #20.


Update language-javascript to 0.84.0

0.83.0 fixes an issue with regex highlighting after a const declaration.
0.84.0 fixes the setInterval and setTimeout snippets not being properly escaped.

language-javascript specs are passing and the failing core specs are also broken on master, so :ship:ing.


TabView doesn't correctly respect OverlayCornerRadius not specified in App.xaml

Describe the bug

Paste the following code into an app:
<muxc:TabView>
    <muxc:TabView.TabItems>
        <muxc:TabViewItem Header="Text">
            <muxc:TabViewItem.Resources>
                <CornerRadius x:Key="OverlayCornerRadius">0,0,0,0</CornerRadius>
            </muxc:TabViewItem.Resources>
        </muxc:TabViewItem>
    </muxc:TabView.TabItems>
</muxc:TabView>

The expected result would be:

The actual result is:

Steps to reproduce the bug

Steps to reproduce the behavior:

Go to '...'
Click on '....'

Expected behavior

Screenshots

Version Info

NuGet package version:

Windows 10 version
Saw the problem?

Insider Build (20185)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop

Xbox

Surface Hub

IoT

Additional context

Pasting the above code into the MuxControlsTestApp yields:

which is also not correct in my opinion.

@chingucoding I'm experiencing a problem that is probably related.
When you try to implement a vanilla TabView, you get an error saying that the app doesn't have this resource.

InnerException = {"The text associated with this error code could not be found.\r\n\r\nCannot find a Resource with the Name/Key OverlayCornerRadius [Line: 25 Position: 39]"}

The XamlControlsGallery doesn't have this problem. It is picking the resources up from somewhere, but I can't figure out where it gets the resource from. Clearly the TabView control doesn't have the correct default resources by default which is a bug, but what is special about the sample that pulls in this resource?

Usually, the OverlayCornerRadius themeresource is shipped with WinUI (see this file). Are you using WinUI and have also added the following reference:
<XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls"/>

@chingucoding

Nuget:
    <PackageReference Include="Microsoft.UI.Xaml">
      <Version>2.4.3</Version>
    </PackageReference>

XAML:
<Page
    x:Class="WCTTabs.MainPage"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:WCTTabs"
    xmlns:controls="using:Microsoft.UI.Xaml.Controls"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"

    mc:Ignorable="d"

    Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">

    <Grid>
        <controls:TabView />
    </Grid>

</Page>

When you say "also added the following reference" do you mean drop the resources somewhere in the resources collection? I tried that and got the same problem.
<Page
    x:Class="WCTTabs.MainPage"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:WCTTabs"
    xmlns:controls="using:Microsoft.UI.Xaml.Controls"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"

    mc:Ignorable="d"

    Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">

    <Page.Resources>
        <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls"/>
    </Page.Resources>

    <Grid>
        <controls:TabView />
    </Grid>

</Page>

Is there are quickstart guide that explains how to get this working from a blank project?

@MelbourneDeveloper You should add the WinUI reference on the application level:
<Application.Resources>
    <ResourceDictionary>
        <ResourceDictionary.MergedDictionaries>
            <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" />

            <!-- Other merged dictionaries here -->
        </ResourceDictionary.MergedDictionaries>

        <!-- Other app resources here -->
    </ResourceDictionary>
</Application.Resources>

(When you add a WinUI nuget package to your project, Visual Studio should open a readme.txt file which contains instructions how to add the WinUI resources to your app.)

I think referencing the WinUI resources from the Page.Resources should work, the XAML Controls Gallery references it in the App.xaml though. There is a guide on how to get started with WinUI 2: https://docs.microsoft.com/en-us/windows/apps/winui/winui2/getting-started

@chingucoding @Felix-Dev got it. Thanks!
The secret was adding it to the app resources. I think this is going to be a stumbling block for developers new to the toolkit. Generally speaking, controls shouldn't depend on resources that they have to add separately.
Here is what worked:
<Application
    x:Class="WCTTabs.App"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:WCTTabs">

    <Application.Resources>
        <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" />
    </Application.Resources>

</Application>

The secret was adding it to the app resources. I think this is going to be a stumbling block for developers new to the toolkit.

When installing the WinUI nuget package, Visual Studio opens the packages readme file that explains how to add the WinUI resources. That step is also outlined in the guide I linked. What would you suggest to minimize this stumbling block

Generally speaking, controls shouldn't depend on resources that they have to add separately.

I can see what you mean, however that is kind of the point of lightweight styling. Lighweight styling allows you to override single resource in order to change visual aspects of templates easily without having to retemplate the control. Without resources that templates depend on.

@chingucoding hmmm... Well, I can see some merit to that. But this a break from the design of any of the other XAML frameworks I've come across.
People just expect that they can leverage a control without it depending on anything and when it throws errors because resources are missing, people will probably just give up. I almost did.

The lightweight styling is not only present in WinUI but also in other XAML libraries/frameworks such as Uno platform, Avalonia and the Windows Community toolkit. The issue you encountered is that for some reasons, including the WinUI resources did not work, which is not really an issue caused by lightweight styling but rather faulty resource lookup.
@StephenLPeters Is this expected to happen? Shouldn't the XAML resource lookup still pick up the appropriate resource if you include the resources in a page and not on the app level?

@chingucoding that doesn't sound right to me. I work with Uno all the time and I don't have to explicitly drag in any extra resources for the controls to work.
I haven't needed to with Avalonia either.

The issue with WinUI 2 is that you need to add the templates and resources consumed by the WinUI controls. By the way, if you don't add the WinUI resources, the WinUI tabview wouldn't work too as it wouldn't be able to find it's template. The advantage of Avalonia and Uno is that they own the complete experience, WinUI 2 is only a library of controls. It's not the complete UWP XAML framework but only an addition to the existing UWP controls, the same is true for the Windows Community Toolkit. The references that you "needed to pull in" where not outside of WinUI, they are all contained in WinUI or the OS XAML. Again the issue you encountered is not an issue with that WinUI expects you to provide resources that are not present in WinUI but rather that the way you included the WinUI resources failed in that case.

Also the following can't work since TabView is not part of the standard UWP controls, but rather is an addition WinUI 2 delivers to customers. When the control tries to look up the template for the control, it asks the XAML resource system where to provide the resource. The XAML resource system however looks at:
a) the standard templates provided through UWP XAML
b) any resource dictionaries on the way from the XAML root to the control (simplifying here)
So if you don't add the resource dictionaries for WinUI to your app, the templates for the control won't be loaded and thus it can't find the template. With WinUI 3, this won't be an issue, for the time being though, WinUI 2 needs this right now because of the way XAML resources work.
<Page
    x:Class="WCTTabs.MainPage"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:WCTTabs"
    xmlns:controls="using:Microsoft.UI.Xaml.Controls"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"

    mc:Ignorable="d"

    Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">

    <Grid>
        <controls:TabView />
    </Grid>

</Page>

The lightweight styling is not only present in WinUI but also in other XAML libraries/frameworks such as Uno platform, Avalonia and the Windows Community toolkit. The issue you encountered is that for some reasons, including the WinUI resources did not work, which is not really an issue caused by lightweight styling but rather faulty resource lookup.
@StephenLPeters Is this expected to happen? Shouldn't the XAML resource lookup still pick up the appropriate resource if you include the resources in a page and not on the app level?

I think I would expect this code to work generally.. however App.xaml resource dictionary gets special treatment in the resource lookup which is probably why it works and the page dictionary doesn't.  resource tree lookup never restarts the process, so I suspect what is happening is we are looking for a template, find it in the page resources, load the template, start the lookup process for the resources that were in the template, from the point at which we found the template. And in this particular case that point is beyond the light weight styles.
App.xaml and generic.xaml are unique in that they gets searched in there entirety for every lookup (I think).  @MikeHillberg @kikisaints @kmahone or maybe @jevansaks can confirm or specify further.
I think this does indicate that there might be a better way to set up the projects resources so that templates are always found before resources.
<Page
    x:Class="WCTTabs.MainPage"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:WCTTabs"
    xmlns:controls="using:Microsoft.UI.Xaml.Controls"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"

    mc:Ignorable="d"

    Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">

    <Page.Resources>
        <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls"/>
    </Page.Resources>

    <Grid>
        <controls:TabView />
    </Grid>

</Page>

@ranjeshj as well

I'm curious if this is specific to WinUI2.x and the way we are including the styles in app.xaml. Does this also repro in WinUI3 ?

Luke says we add the templates and the resources separately. I wonder if we change the order we add those in if we could alleviate this issue now.

here is the code that does it: https://github.com/microsoft/microsoft-ui-xaml/blob/de788345659ba319597161149843504fbe686659/dev/dll/XamlControlsResources.cpp looking closer I'm not sure there is anything we can do.

It doesn't seem like there is any code in there that has any say in this. I'm inclined to say that this issue is because of the way resources work which would need to wait until WinUI 3 to be fixed.


GH: update auto sync to use aormsby/Fork-Sync-With-Upstream-action

To auto sync branches from upstream to downstream without creating new token

/lgtm

/approve


Layout issues in "Show changes since last view" view

With RGH:

Without:

Issues (highlighted boxes above):

the Files header has broken to two lines
the first file's header has broken to three lines

Repro
I think that this only happens when you've selected "Show changes since your last review"

and mayyybe when the top file in that view is showing "Changed since last view".
I can't get it to happen when I've selected all commits, individual commits, nor commit ranges within the PR.
Speculating on causes
I'm a bit mystified as to issue 2 above, but issue 1 seems caused by RGH adding these two buttons

which probably don't have room when "Clear filters" is visible as it is when you have selected "Show changes since your last review".

Duplicate of #2291.


migrate to evo/rx, save 200Kb memory

Coverage remained the same at 90.27% when pulling 53bf134d7970f2c6fc42d735d6fff7dc00e108cf on HunsonlAbadeer:evo/rx into 7ef62e27c0446519b0c86ce1cdbef09a6e2e5794 on brabadu:master.


Fix Sheets not showing '0' with Integer types

This formatting symbol tells Sheets to display '0' instead of an empty cell when using the default formatting style "Automatic".

No problem, @SteveWinward. Thanks for letting me contribute to this project!
I have a thought I'd like your opinion on. In a few places, like Repository<TRecord>.AddRecords(List<TRecord> records), the parameter takes a List<TRecord>. Sometimes I have a TRecord[], and it would be nice to add these without first converting the array to a list.
It would be super easy to support arrays, as we just need to change List<T> to IList<T> (the interface rather than concrete class).  No changes would need to be made to the implementation since foreach is used. Would you be interested in seeing some of these changes in a pull request?

@Monsoonexe  that sounds great.  Please feel free to make those updates and submit another pull request.


Examples/benchmarking

Description of changes:
This is some benchmarking of Bayesian Neural Networks (meanfield VI) against a non-Bayesian NN. Hopefully this could provide a useful starting point for further analysis (e.g. different kinds of BNN).
The script examples/benchmarking/bnn_classification_benchmark.py runs through several datasets (MNIST, FashionMNIST, CIFAR10, CIFAR100), with 3 different NN architectures. Several metrics are computed (Accuracy, MSE (=Brier score), Log loss). Some "sensible" defaults are set for the hyperparameters - no HP tuning is performed. Results are stored in the results.txt file as a list of json strings.
Also added a notebook in the notebooks directory for exploring the results. This outputs figures to the directory examples/benchmarking/figs (figures also included).
Changes to MXFusion core files:

mxfusion/components/functions/mxfusion_gluon_function.py: Made the exception more helpful
mxfusion/inference/batch_loop.py: added a callback for custom status messages
mxfusion/inference/grad_based_inference.py: added GradIteratorBasedInference - a version of GradBasedInference that operates on a data loader
mxfusion/inference/minibatch_loop.py: fixed bug that stopped it working on GPUs; added callback for custom status messages

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meissnereric can you have a look at the failing tests? Don't think this was happening before.

I think this was happening before, I remember seeing it.
The reason is that you're using Python 3.6 only string formatting in places. this "(f"Context device id {ctx.device_id} outside range of list {ctx_list} or None")" style isn't supported in 3.4/3.5, use the classic "blah".format() style.

Codecov Report

Merging #143 into develop will decrease coverage by 0.41%.
The diff coverage is 30.43%.

@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
- Coverage    85.19%   84.78%   -0.42%
===========================================
  Files           78       78
  Lines         3850     3917      +67
  Branches       654      666      +12
===========================================
+ Hits          3280     3321      +41
- Misses         376      395      +19
- Partials       194      201       +7

Impacted Files
Coverage Δ

...on/components/functions/mxfusion_gluon_function.py
86.9% <0%> (ø)
:arrow_up:

mxfusion/inference/batch_loop.py
80% <0%> (-20%)
:arrow_down:

mxfusion/inference/__init__.py
100% <100%> (ø)
:arrow_up:

mxfusion/inference/grad_based_inference.py
71.42% <33.33%> (-19.88%)
:arrow_down:

mxfusion/inference/minibatch_loop.py
73.33% <40%> (-4.45%)
:arrow_down:

mxfusion/inference/inference_parameters.py
84.4% <0%> (-4.49%)
:arrow_down:

mxfusion/models/factor_graph.py
84.72% <0%> (-0.17%)
:arrow_down:

mxfusion/util/graph_serialization.py

mxfusion/util/serialization.py
85.71% <0%> (ø)

mxfusion/inference/inference.py
83.33% <0%> (+1.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ccde7...01fd48c. Read the comment docs.


[BUG] Create New Dirmon Form Missing

When you click "Create" on directory monitoring the form is missing.

Fixed in master branch.


[Prisma Plugin] nullable fields are not suggested in the expose methods and display error in VSCode

Hi,
Im just learning GraphQL and everything around it and wondering if i missed smth, but nullable fields show up as an error in VSCode. If i remove the null property then they are showing up correctly.

I found the solution in a youtube comment buried under a video, i have to add { nullable: true }.

This was something that was fixed for the core expose methods a while back, I just ported the fix to the prisma plugin as well.  It will now correclty auto-complete nullable fields, but show an error for the options object if making the field nullable is required


DeviceTreeValidation: Add test case to validate ibm,firmware-versions node

This test validates version property. May be in future we can add validation for component level version property.
Signed-off-by: Vasant Hegde<EMAIL_ADDRESS>

FSP machines and maybe qemu/mambo under certain conditions will fail this; could we add a skip for those types?

Correct. I should skip tests on FSP, qemu and mambo for now.
-Vasant

======================================================================
ERROR [1.706s]: runTest (testcases.DeviceTreeValidation.DeviceTreeValidationSkiroot)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/testcases/DeviceTreeValidation.py", line 396, in runTest
    self.validate_firmware_version()
  File "/mnt/testcases/DeviceTreeValidation.py", line 252, in validate_firmware_version
    raise OpTestError("DT: Firmware version property is missing")
OpTestError: DT: Firmware version property is missing

It's just occurred to me that the version property doesn't exist on P8 where ibm,firmware-versions is generated by hostboot instead of skiboot.

Sam Mendoza-Jonas<EMAIL_ADDRESS>writes:

======================================================================
ERROR [1.706s]: runTest (testcases.DeviceTreeValidation.DeviceTreeValidationSkiroot)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/testcases/DeviceTreeValidation.py", line 396, in runTest
    self.validate_firmware_version()
  File "/mnt/testcases/DeviceTreeValidation.py", line 252, in validate_firmware_version
    raise OpTestError("DT: Firmware version property is missing")
OpTestError: DT: Firmware version property is missing

It's just occurred to me that the version property doesn't exist on
P8 where ibm,firmware-versions is generated by hostboot instead of
skiboot.

Hrm... and we don't go and add/modify the node in skiboot based on VERSION?
--
Stewart Smith
OPAL Architect, IBM.

        if (proc_gen < proc_gen_p9)
                return;

It would appear not! I suppose we could add a path to only add the version property on P8 and leave the rest of the node intact.

@sammj On P8 OpenPower system hostboot is creating device tree and they are adding firmware-versions node. Hence in OPAL you see above check.
In OPAL we do more stuff to get proper version property.. .but in hostboot, they just parse VERSION partition and add property to device tree. So its possible that we may not have version property inside ibm,firmware-versions node. Its my fault. I should have double checked on P8 system. Sorry for that.
I will check on P8 system.
-Vasant

sample output from P8 :
/proc/device-tree/ibm,firmware-versions# lsprop
op               "build-d033e11"
skiboot          "5.4.8-7f3e3b0"
occ              "d7efe30-dca92ac"
hostboot         "2eb7706-f28ad92"
firestone-xml    "2494a43"
buildroot        "81b8d98"
IBM              "firestone-ibm-OP8_v1.12_2.85"
capp-ucode       "1bb7503"
hostboot-binaries
"fc2f7b9"
petitboot        "v1.4.4-a6d3938"
phandle          100001aa (268435882)
linux            "4.4.92-openpower1-59284a2"
name             "ibm,firmware-versions"
So version property is not exists in P8 (or depends on how VERSION partition is created).
May be I will add P8 check.
-Vasant

I have added P8 check. Also added sanity check for other component versions.
-Vasant

Looks good!


Can I add a ReduRx example?

Before I start coding, I'd like to make sure that a PR with a ReduRx sample has some chance to get listed.
Here is some resource on the lib in Flutter.

Hey there -- sure thing! This repo is meant as a way to provide different implementations so we can compare and contrast them as a community using an "Apples to Apples" comparison as much as possible.
Please do your best to ensure your app follows the spec, and submit a PR when you're ready for feedback :)
https://github.com/brianegan/flutter_architecture_samples/blob/master/app_spec.md

Awesome, thank you. I'll make sure that specs are properly implemented.


depolymerizing, guardee

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[d,g]

/trunk merge


Add drives output & user filter

Reverted back to draft, there is a bug, only admins can list drives atm. Needs more logic in reva.

https://drone.owncloud.com/owncloud/ocis/13901/42/8
runsh: Total unexpected failed scenarios throughout the test run:
apiSpaces/restoreSpaces.feature:63
apiSpaces/restoreSpaces.feature:64

https://drone.owncloud.com/owncloud/ocis/13913/42/8
The same scenarios failed again:
runsh: Total unexpected failed scenarios throughout the test run:
apiSpaces/restoreSpaces.feature:63
apiSpaces/restoreSpaces.feature:64

It seems that either there is a regression (code to be fixed), or a change in behavior (tests to be adjusted)

@phil-davis seems to be a bug in the code we introduced to reva: https://github.com/cs3org/reva/pull/3109

will be superseded by #4244 , delete as soon as it is merged!


CustomEvent is not defined

I think this needs the dom lib right?

No, although if you're using IE it's possible you're lacking support for the CustomEvent constructor:
https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent#Browser_compatibility
But really, you should not be using IE.

To explain this: this issue is ment, when you want to use it serverside.
There the lib is not working at all. For solving this, used jsdom and injected the related dependencies into the module (i know its hakish as anything, but worked ;) )

Ah, yeah. Never intended for this to be used server-side, so never bothered to test that. You can also probably use the custom-event-polyfill instead, which might be more lightweight that the whole jsdom.

Yep, i tried it, but there have been still some issues with that (maybe i did something wrong there). Anyways, the hackish approach works fine for me, so if anyone get into these troubles, he has a solution ;)

@nilsroesel : Hi, I am using this lib server side as well and see the same issue. Would you be kind enough to share how this is implemented. Code snippet much appreciated

@mpetazzoni Any plans to get this working server-side with Node? custom-event-polyfill isn't working.

@0xTomDaniel CustomEvent should be available (as experimental) in more recent versions of Node, without the polyfill. Can you share what you've tried so far, and what errors / issues you're seeing? 🙏🏻


Android | KeyboardAwareScrollView overlaps react-navigation header & statusbar

Hi, I'dont thing its the right behavior. KeyboardAwareScrollView overlaps custom header and statusbar when text input is focused.
I can avoid overlapping the statusbar when i set backgroundColor not transparent but i need to do it.
Navigation no custom codes.
Stack.Navigator
Screen
Stack.Navigator
Screen
Container
...
TextInput
TextInput
TextInput
...
Container
Container
SafeAreaView
StatusBar backgroundColor='transparent'
KeyboardAwareScrollView>
{children}
KeyboardAwareScrollView
SafeAreaView
And i set <activity android:name=".MainActivity" ... android:windowSoftInputMode="adjustPan"  ...   />
transparent statusbar

not transparent

Swaggy_McMuffin's solution works.
This has nothing to do with KeyboardAwareScrollView and everything to do with your activity android:windowSoftInputMode being "adjustPan". Change it to "adjustResize" and make sure to recompile the apk - aka npx react-native run-android.

still getting same error in android devices
"react-native-keyboard-aware-scroll-view": "^0.9.5",
"react-native": "0.73.6",


Relax extract_sequence to the status quo before 0.17 was released

This is the part that should be relative uncontroversial and fit to release as part of 0.17.2.
Closes #2615

Not sure the coverage drop by more than 18% is real...


Aww

Aww module supplies a response of a random image pulled from r/aww in the HOT category.
User should be able to prompt module with such language:

"Show me something cute"
"r/aww"
"aww"

I had no idea praw existed, great suggestion!
Switched to praw in most recent commit.

@vinceiv Yes, praw is awesome. Contributing to open-source is indeed a great way to learn! 😄


🪲[Bug]: Footer has to be improved

Describe the bug
A clear and concise description of what the bug is.
Footer aligned content is on left .. It should be aligned properly
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
@Anishkagupta04 Please assign me this issue under GSSoC 24

Assigning

I would like to work on this issue , please assign this to me.
@Anishkagupta04


Fool model toward specified target class using FSGM

Hello @goodfeli and @npapernot ,
In my understanding, these two lines get the result of what trained model is gonna classify the clean example.
Then by adding this gradient to the image, the trained model will tend to not classify it as the same label as before.
However, I'm wondering how can I use FSGM to fool model so that it will classify all examples to a specified label, e.g., 0.

def fgsm_to_class_0(x, predictions, eps, clip_min=None, clip_max=None):

    # Compute loss
    zero = tf.constant(0, dtype=tf.float32)
    mask = tf.convert_to_tensor([1, 0, 0, 0, 0, 0, 0, 0, 0, 0], dtype=tf.float32)
    y = tf.to_float(tf.not_equal(predictions*mask, zero))
    y = y / tf.reduce_sum(y, 1, keep_dims=True)
    loss = utils_tf.model_loss(y, predictions, mean=False)

    # Define gradient of loss wrt input
    grad, = tf.gradients(loss, x)

    # Take sign of gradient
    signed_grad = tf.sign(grad) * -1

    # ... same as original fgsm function

I've tried using above code to raise the score of particular class's logits, but it didn't work 😢

Sorry, I figured out how to make it work.


Cant set file as default file manager (preview)

Description
When i try to set as default the option just freeze, like on image:

After while comeback as disabled, no error, nothing, just don't work. Any tip?

Steps To Reproduce
Try to set as default file manager on preview version
Steps to fix
dont know how to fix.
Files Version
Versão: <IP_ADDRESS> OS Version: 10.0.22621.819
Windows Version
Windows 11 22H2 22621.819
Relevant Assets/Logs
debug.log

Have you tried restarting your pc then toggle the option

Have you tried restarting your pc then toggle the option

Yes, didnt work

Asking @yaira2 for approval.

is working on 2.4.11


Using GitHub Actions -- replace Travis CI integration?

I've created the YAML script to drive GitHub Actions (GA) testing, in commit c7630ae + 3b10324 (the latter because I didn't realize before that GA cancels everything in the matrix if any one of them fails.)
As you can see here, the tests passes for the current HEAD of master.
(You can manually trigger it to run by clicking on "aiosmtpd CI" on the left sidebar, then click "Run workflow".)
I don't know how to integrate them to the PR system, though. And/or how to replace Travis CI automatic testing of PR and pushes-to-PR.

I think the project will go to GitHub Actions sooner and later.
Sorry, I don't have the capacity to migrate the project myself but I can help with answering any GH Actions related question, sure.

Where does one configure PR checks to be done against GitHun Actions instead of Travis?

If I remove .travis.yml, will that also result in stopping the usage of Travis CI?

Done. Now I need that PR to be reviewed, and upon merging, Travis CI will stop and get replaced by GitHub Actions 😎


[data-broker] Empty tenant and subject names are accepted

In TopicManager, function editConfigTopics, there is no validation of tenant and subject strings, which can be empty.

Done.


3 simplify multiplier

Deleted select wire from multiplier PU, Verilog and Haskell models reworked. Solution passed the tests

Moved to: https://github.com/ryukzak/nitta/pull/224


Allow to exclude images from lazyloading

Please describe the feature you would like to see implemented.
https://web.dev/lcp-lazy-loading/ and actual results suggest a gain on LCP when not lazyloading images above the fold.
Instead of fiddling with mechanisms to identify affected elements I suggest to allow to explicitely exclude images such as e.g. logo, navigation icons and jumbo header backgrounds.
The easiest way to do so might be adding a speaking CSS classname of 'nolazyload'.
Looking into the lazysizes' JS I did not find an option to do so.
Also the thumbnail's twig left me without an idea as the media management I am familiar with in Shopware's backend does not allow to add classes to be assigned the image.
Even if it is not something you would consider to add right away a hint in a possible direction of where to add this would be appreciated :)
Thank you in advance.

Hey, this would just work, if there is no need for any thumbnail because:
lazysizes (JS) makes lazyLoading AND calculates the needed size (see attribute sizes) to be loaded by the browser.
While this isn't available initially, there is possibility to use thumbnails for such functions.
So, you would end up with loading the biggest image. Sure, for logo is would work, but the more important and influencing content would load too big images. That's the reason, I don't see any good way and solution to get lower LCP, too :-(

Swift as always.  Thank you.
A naming pattern to look after in the media.url should work to build a toggle.


Therer Are Some Strings Not Included In Localization

It's under MechanicsChanges.
AddtionalModifiersDesccriptors

I need to update this area to allow for localization, will come in time


Bluetooth: ISO: Fix swapping of broadcast code and document usage

Add a short example of how the broadcast code for BIGs shall be used.
The spec states:
"On all levels other than UI, the Broadcast Code parameter shall be represented as a 128-bit value. The transformation from string to number shall be by representing the string in UTF-8, placing the resulting bytes in 8-bit fields of the value starting at the least significant bit, and then padding with zeros in the most significant bits if necessary. For example, the string “Børne House” is represented as the value 0x00000000_6573756F_4820656E_72B8C342."
So "Børne House" becomes
[00, 00, 00, 00, 65, 73, 75, 6F, 48, 20, 65, 63, 72, B8, C3, 42] when sending over HCI.
Signed-off-by: Emil Gydesen<EMAIL_ADDRESS>

@alexsven @Casper-Bonde-Bose Please tell me if your understanding of the spec is the same as I.
Unfortunately, for non-string values, the spec offers no examples or explanations.

String and non-string bytes are considered as little-endian values, left to right in order (i believe the same for SMP passkey too).
0x42 represents the character B and by the example in the BT Spec. the little storage in memory shall be in the order {0x42, 0xC3, 0xB8, 0x72, 0x63, 0x65, 0x20, 0x48, 0x6F, 0x75, 0x73, 0x65, 0x00, 0x00, 0x00, 0x00} = 0x00000000_6573756F_4820656E_72B8C342.
Your comment in code is correct, but a memory swap shall not be done. Instead, as uint8_t bcode[BT_ISO_BROADCAST_CODE_SIZE]; represents byte-array, the application/user shall supply the values left to right order as Least Significant value to Most Significant and ensure trailing bytes are padded to zero.

I think this padding should be done in host. Thereby leaving the end user to just set a broadcast code (string) through a config.

Since the broadcast code can either be a string, or just some random values (where 0 is in fact a valid value), we cannot do padding in the host, unless we also add a size_t broadcast_code_len field.
Even a broadcast code such as [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0] is valid.

strncpy is perfect for setting bcode from a pointer. strncpy copies the string and adds zero padding to fill dst to size.

strncpy is perfect for setting bcode from a pointer. strncpy copies the string and adds zero padding to fill dst to size.

And that would work great if the broadcast codes were ever only strings, but they are not.
e.g. [1, 2, 3, 4, 5, 0, 1, 2, 3, 4, 5, 0, 1, 2, 3, 4] is a valid broadcast code, but copying that with strncpy would yield [1, 2, 3, 4, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0].


eden config generates incorrect eden.root

My eden workspace is checked out at /Users/roman/src/lfe/eden however when I run eden config I see that the value of eden.root is pointing to /Users/roman/eden

Fixed at PR50

Likely not fixed. Eden config still tries to put config to /home/fleandr/.eden/ if I run from ~/eden2/eden

Can we please get a resolution here @sadov @giggsoff ?

I suggest to put /.eden/ in the current eden directory instead of home

close? @rvs


UTF-8 in readme.md

setup.py run on windows fails to read readme.md
Need to define encoding argument in setup.py
with open("README.md", "r", encoding="utf-8") as fh:

Thank you for bringing this issue to my attention. I will address it in the next commit.


[Feature] Generated code should be PSR-2 compatible

I would like to see the generated code PSR-2 compatible. We could use something like templates and define PSR-2 as default but make it adjustable for other people if they prefer another code style.
What do you think?

Propel3 builders use the great php-code-generator library, that doesn't support PSR-2 until the issue
https://github.com/gossi/php-code-generator/issues/23 is resolved.
By now, I've forked php-code-generator and refactored it to generate psr-2 code https://github.com/cristianoc72/psr2-code-generator .
When Propel3 will be finished, if https://github.com/gossi/php-code-generator/issues/23 not solved yet, we could think to temporarly switch to my fork.
Anyway, imho Propel should generate psr-2 classes.

I saw this too but as far as I could see there is not much progress to finish the issue https://github.com/gossi/php-code-generator/issues/23 .
For our issue #4 I extended the classes of the code generator but didn't liked the way I had to do this. Maybe we should use your Fork to fix issue #4 and this one until the gossi code generator supports PSR2. Would be a much cleaner way.

you might also think about forking the code-generator libraries so I can merge your code and all can benefit from that.

See gossi/php-code-generator#54 where I started an implementation towards psr-2. Please read, run experiments, gain experience, send PRs 😉

Use this one, It generates PSR-2 compliant code, and supports all PHP 7.x features https://packagist.org/packages/nette/php-generator


imp: prevent bin overwriting

Closes: #64.
A bin can currently overwrite another one, if it has the same identifier.
This will prevent overwriting, by generating an ID until it is not already taken.

Even if it is very unlikely, add a max retry limit.

Even if it is very unlikely, add a max retry limit.

Why not, but what should be returned to the user? This is an unlikely case, he will inevitably end up finding a free identifier.

Why not, but what should be returned to the user? This is an unlikely case, he will inevitably end up finding a free identifier.

I really don't like the idea of having a possible infinite loop. I suppose a Internal Server Error could be sufficient.
Maybe, we need more reviewers to express their thoughts on that

I really don't like the idea of having a possible infinite loop. I suppose a Internal Server Error could be sufficient.
Maybe, we need more reviewers to express their thoughts on that

+1 for a watchdog
for watchdog in range(20):
indent = xxx
if indent is free:
break
else:
raise RuntimeError("Woof")```

+1 for a watchdog
for watchdog in range(20):
indent = xxx
if indent is free:
break
else:
raise RuntimeError("Woof")```


Similar Piece of Code for Invoke and SendTransaction Function

There is two piece of code, very much similar in the function body. can we integrate them? because in the period of updating code, there may be inconsistency, for example, the 1 shows "Result Stack", 2 shows "Evaluation Stack". It will cause some confusion.
besides, the part using (ApplicationEngine engine = ApplicationEngine.Run(tx.Script, tx, null, testMode: true))  is almost the same.

https://github.com/neo-project/neo-node/blob/dec52fbd25850113f5372bf8d2aa7c97a6ffcced/neo-cli/CLI/MainService.cs#L545-L569

https://github.com/neo-project/neo-node/blob/dec52fbd25850113f5372bf8d2aa7c97a6ffcced/neo-cli/CLI/MainService.cs#L490-L506

I will unify it


Include response length in output

It would be useful if the response length was included in the output, or even better, have a way to filter the output by response length (!=, <, >). This would allow the user to filter out expected responses during enumeration.

This should be fixed now with the latest update.