Virtual keyboard action does not change when focus change.

Hi guys. Today I try to implement form field in flutter follow this page. Although I declared two different textInputAction in TextFields, keyboard action does not change when focus change. If I declare different keyboardType in TextFields everything works like normal. Seems like textInputAction does not notify keyboard to change.
Steps to reproduce:
1/ Click on first TextField to show virtual keyboard (action  Next).
2/ Click on FloatingActionButton to change focus to second TextField. Keyboard action doesn't change, still in action Next, must change to action Done).
If I just click on the second TextField when the keyboard doesn't show, everything works like expected, keyboard action is Done.

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Flutter Image picker',
      theme: new ThemeData(
        primaryColor: const Color(0xFF02BB9F),
        primaryColorDark: const Color(0xFF167F67),
        accentColor: const Color(0xFF167F67),
      ),
      home: MyCustomForm(),
    );
  }
}

class MyCustomForm extends StatefulWidget {
  @override
  _MyCustomFormState createState() => _MyCustomFormState();
}

class _MyCustomFormState extends State<MyCustomForm> {

  FocusNode myFocusNode;
  final GlobalKey<FormState> _formKey = new GlobalKey<FormState>();

  @override
  void initState() {
    super.initState();

    myFocusNode = FocusNode();
  }

  @override
  void dispose() {
    myFocusNode.dispose();

    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Text Field Focus'),
      ),
      body: Padding(
        padding: const EdgeInsets.all(16.0),
        child: Form(
          key: _formKey,
          child: Column(
            children: [
              TextField(
//                Enable this code bellow, keyboard action change like expected
//                keyboardType: TextInputType.emailAddress,

                autofocus: true,
                textInputAction: TextInputAction.next,
              ),
              TextField(

                focusNode: myFocusNode,
                textInputAction: TextInputAction.done,
              ),
            ],
          ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () => FocusScope.of(context).requestFocus(myFocusNode),
        tooltip: 'Focus Second Text Field',
        child: Icon(Icons.edit),
      ),
    );
  }
}

flutter doctor infos
[√] Flutter (Channel beta, v1.6.3, on Microsoft Windows [Version 10.0.17763.557], locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[√] Android Studio (version 3.4)
[√] Android Studio (version 3.5)
[√] IntelliJ IDEA Ultimate Edition (version 2019.1)
[√] VS Code, 64-bit edition (version 1.33.1)
[!] Connected device
! No devices available
! Doctor found issues in 2 categories.
Test on Nokia 7 plus (android 9), emulator (android 5).

Hi @ltvu93, I just tested this on the master branch and it seems to be working. What I'm observing is:

Keyboard starts off showing TextInputAction.next button on bottom-right of keyboard.
Tap on FAB or second TextField.
Keyboard now shows TextInputAction.done button.

Let me know if I interpreted your issue correctly, and if not, please correct my understanding! Thanks

@shihaohong Sorry, I posted working code in yesterday, please check my edited comment for bugs code block and addition information.

I'll test this again tomorrow since it's the end of the day for me here, but if I remember correctly, I did try commenting out keyboardType: TextInputType.emailAddress, and it still turned out okay. Could you check with the master branch to see if this is still happening for you? Thank you for adding more details to the original post!

@shihaohong I switched to master channel to test, still get this bug.
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel master, v1.7.4-pre.85, on Microsoft Windows [Version 10.0.17763.557], locale en-US)

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
[√] Android Studio (version 3.4)
[√] Android Studio (version 3.5)
[√] IntelliJ IDEA Ultimate Edition (version 2019.1)
[√] VS Code, 64-bit edition (version 1.33.1)
[√] Connected device (1 available)

! Doctor found issues in 2 categories.

It seems to work fine for me, the bottom right button icon changes when I focus on the second field.

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.7.4-pre.108, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Android Studio (version 3.3)
[✓] VS Code (version 1.34.0)
[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

@shihaohong I think I found what causes this issue. This bug only happens when I use a custom keyboard if I use default google keyboard everything work fine.
Custom keyboard (Laban key)

Google keyboard

@ltvu93  @carmas123
Are you still experiencing this issue on latest Channel stable, v1.17.3?
I am not able to reproduce the issue on latest (Channel dev, 1.19.0-3.0.pre gboard or samsung keyboard

flutter doctor -v
[✓] Flutter (Channel dev, 1.19.0-3.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.19.0-3.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 6135091de9 (3 days ago), 2020-06-01 17:17:03 -0700
    • Engine revision e39301f23f
    • Dart version 2.9.0 (build 2.9.0-13.0.dev 6489a0c68d)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10
      (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.5.1
    • macOS         • macOS                     • darwin-x64     • Mac OS X
      10.15.5 19F101
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome
      83.0.4103.97

• No issues found!

Thank you

@TahaTesser (I'm not sure it's the same issue): I'm on slow connection and actually going from Flutter 1.17.2 to 1.17.3 right now. Anyway in the 1.17.2 with only one input wrapped by a BlocBuilder (from flutter_bloc), when the state changes, the decoration modification is reflected visually but not the textInputAction (from TextInputAction.none to TextInputAction.search).

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

Same issue here.

Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


update dad joke search function to be async

What's expected:
If we call fetchNextPage() twice in init:
init {
  fetchNextPage()
  fetchNextPage()
}

The second call should be short circuited by is Loading check
In original implementation, this doesn't work (i.e. is Loading check is never true), because the dummy search function emits Success state synchronously. This PR simply defer the execution to make it async.
@BenSchwab @elihart @gpeal

@hellohuanlin I'm not sure I follow. That is actually executing a network request through a retrofit service.

The description under https://github.com/airbnb/MvRx/wiki#accessing-state doesn't seem to match up with how the sample works. The RxJava calls will be made synchronously since we're using the create() method when creating the RxJava2CallAdapterFactory. It seems that the sample should be using an asynchronous observable to reflect the wiki description. It seems like this should be done either by using the createAsync() method when creating the RxJava2CallAdapterFactory or by using a subscribeOn() call when searching on the DadJokeService.

@pmecho yeah subscribeOn(io) looks cleaner than delay 1 millisecond

@hellohuanlin Yeah, this is correct now. Execute used to call subscribeOn(Schedulers.io()) automatically but it was never added here when that was removed.


react-toast component does not resume timer after clicking close/action buttons

Bug report
react-toast component does not seem to resume timer once a toast was actioned (and closed) via action or close button, which causes all subsequent toasts to be permanently stuck on a screen.
I've made a codesandbox that console logs using onPause and onResume methods to better illustrate the issue.
Current Behaviour
Kapture 2023-07-12 at 09.54.42.webm
In the video above I first trigger a toast and hover/unhover it to illustrate how timer is paused and resumed and then let it auto dismiss when it exceed the timer limit (unrelated to a bug reproduction itself, purely to show pause/resume messages)
Then I click "undo" button that triggers "pause" and never resumes, from that moment on all subsequent toasters will be permanently stuck until you manually close them.
Focusing on other elements does not help either.
Expected behaviour
Clicking toaster action/close buttons should resume the counter, so toasters in future does not start with paused state.
Reproducible example
CodeSandbox Template

Thanks for report! Looks like the same as #2233

just experienced this myself, is there a workaround while it gets fixed?


egcurl does not work on OS X 10.10.1

This doesn't seem to work on OS X 10.10.1 after a clone from github.
Receive the following error out of the box:
egcurl: line 18: import: command not found
egcurl: line 19: import: command not found
egcurl: line 20: import: command not found
egcurl: line 21: import: command not found
egcurl: line 22: import: command not found
egcurl: line 23: import: command not found
egcurl: line 24: import: command not found
egcurl: line 25: import: command not found
egcurl: line 26: import: command not found
egcurl: line 27: import: command not found
from: can't read /var/mail/time
from: can't read /var/mail/urlparse
egcurl: line 38: syntax error near unexpected token `('
egcurl: line 38: `def get_host(url, headers):'

Are there missing install instructions?

I've changed egcurl to be executable automatically in commit 6322de4.


Make it clear that this is the MIT licence

I was looking for a licence to send someone as an example and noticed that this one doesn't make it clear it's the MIT licence. This PR changes that, to make it easier for people to understand what licence is being used.

As per, for example, https://github.com/alphagov/digitalmarketplace-aws/blob/master/LICENSE

Good call, thanks @annashipman!
We'll add them to some other ones that are missing. This also made me realise that between our repos we have 3 LICENSE files and 8 LICENCE files. We should probably choose one.

I vote "LICENCE"!

Github search shows LICENSE is 20 times more popular though.

Really?
¯_(ツ)_/¯

LICENCE is the British spelling; LICENSE is the American spelling. So I also vote LICENCE.
...for the filename. However, for the licence itself, I'd use the exact wording, so The MIT License https://opensource.org/licenses/MIT


mkcloud: add support for deploying designate

Adds a want_designate_proposal option that defaults to false.

SOC9 mkcloud failed in designate

we need to add a line in scripts/lib/mkcloud-common.sh next to : ${want_magnum_proposal:=0}

@bmwiedemann done

@dirkmueller is there a reason why this is still WIP?
@bmwiedemann @nicolasbock could you have another look please?

@toabctl I wanted to test it at least once..


updated backupSession() method to new arguments to effectively override ...

...MemcachedSessionService.backupSession() method and get called during serialization of session
DummyMemcachedSessionService.backupSession() was not being called during serialization of session as it appears that the signature for the MemcachedSessionService.backupSession() had changed and  DummyMemcachedSessionService.backupSession() signature had not been updated so was not overriding parent method call.
Updated signature to override MemcachedSessionService.backupSession() method properly and handle null session condition.

Thanks for the PR!


EV3 type checking in nested ternary operator is not working

Describe the bug
In the nested operator the true and false condition can have different types, for example boolean and float. The program runs fine in simulation but cannot be compiled
To Reproduce
Steps to reproduce the behavior:

Create a boolean variable and assign a value
Click on 'logic'
Add two ternary operators
Add to the nested operator a boolean and a float value as the return type

Expected behavior

it should not allow adding of different variables. Either detach the whole nested block or refuse to add the variable

Screenshots

Device information

Type [Desktop]
OS: OS: [Linux]
Browser[firefox 64.0]

ev3_logic_test_compile_error.xml.zip

Wrong types cannot be connected to ternary operators anymore.


added a simple pub/sub topic for testing

Check the README.md for more details. The process now is manual.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @Abacn

R: @damccorm


Fix issues from PR #1932

This is not ready for merging yet.
Feature or improvement description
A few minor bugs and inconsistencies were discovered after merging #1932.

Wrong name for the ExtLoads module in comment
replace m_FAST%t_global with t_now calculated from t_global in FAST_Subs::WriteOutputToFile call

Also added a check on the number of tower nodes when ExtInflow is used with CFD.
Related issue, if one exists

https://github.com/OpenFAST/openfast/pull/1932#discussion_r1430444257
https://github.com/OpenFAST/openfast/pull/1932#discussion_r1430454778

Impacted areas of the software

glue code

Additional supporting information
Test results, if applicable
No test results change with this PR

[ ] Update PR https://github.com/OpenFAST/openfast/pull/1949 notes and the v3.5.2.md file with links to this PR after merging.


keep old month markup onMonthChange

Hi there! Thank you for the great calendar plug in. One question please:
onMonthChange the script renders (overwrites) the previous month. Is there a way of keeping the markup with all its classes, maybe just make it hidden (display: none) so only one month is displayed.
Reason being is that I need the .calendar-day-xxxx-xx-xx class to manually add a selected class for a certain date range. Thank you for any help!

Hi @andreikainer, unfortunately there's no way that I know of. You could pull the HTML out manually using jQuery: $( '#calendar' ).html() and then your app logic could do whatever you want at that point.
Unfortunately, we're keeping the GH issues to be bugs/PRs only so it might be easier/faster to get feedback on Stack Overflow.


[DO NOT SUBMIT] Experimental Travis PR

Currently Travis doesn't fail if a test fails... this PR is
to investigate why. (Reduced to building and testing Datastore, which
now contains a deliberate failure.)

(This PR failed on Travis as expected...)


IMAP server gives FLAGS response to FETCH

Hi,
I'm writing a simple tool to dump all my e-mail in an mbox.
The IMAP server seems to send * FLAGS twice but I cannot tell for sure what is going on because I'm not sure where to exactly add the log statements so that I can see every single packet to and from the server. I suppose either there is an extra line at the end of the "EXAMINE" response, or there is an extra line at the beginning of the "FETCH" response.
The first time I do fetch() after examine() I get the below panic:
Thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Parse(Unexpected("MailboxData(Flags([\"\\\\Answered\", \"\\\\Deleted\", \"\\\\Draft\", \"\\\\Flagged\", \"
\\\\Seen\",...

After patching rust-imap with the changes below I can run more "fetches" and I see that it is only the first time I get unsolicited data.
diff --git a/src/lib.rs b/src/lib.rs
index 87249d0..3fe0326 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -66,6 +66,8 @@ extern crate imap_proto;
 extern crate native_tls;
 extern crate nom;
 extern crate regex;
+#[macro_use]
+extern crate log;

 mod parse;

diff --git a/src/parse.rs b/src/parse.rs
index c89aa6d..021eee4 100644
--- a/src/parse.rs
+++ b/src/parse.rs
@@ -113,10 +113,22 @@ pub fn parse_fetches(
             }

             Ok(MapOrNot::Map(fetch))
-        }
+        },
+        Response::MailboxData(m) => {
+            use imap_proto::MailboxDatum;
+            match m {
+                MailboxDatum::Flags(flags) => {
+                    trace!("Matched flags")
+                },
+                _ => {}
+            }
+            Ok(MapOrNot::Ignore)
+        },
         resp => Ok(MapOrNot::Not(resp)),
     };

     unsafe { parse_many(lines, f, unsolicited) }
 }

What do you think is the proper solution here?
It would  be great to be able to trace the "imap conversation" to debug these kinds of issues.

Sorry if this doesn't make any sense, I'm new to IMAP.

Ah, there's a hidden debug field on Connection, which you can get at through the Deref that is implemented on Client and Session:
https://github.com/jonhoo/rust-imap/blob/ba09886e3b12867926093faf61711351ca5d2a59/src/client.rs#L78
Try setting that to true?
As for the issue you are experiencing, it's hard to say what's going on without seeing the trace. In general, parse_fetches should only be called in contexts where only FETCH responses can be returned. In this case, it looks like you are also getting MailboxData::Flags responses, which doesn't seem right. Maybe EXAMINE can return Flags as well? I know @Emm54321 has worked a bunch on unsolicited server responses in the context of #114, so maybe they can shed some light on this?

After coding some more I saw that I got the same issue if I ran LIST after EXAMINE. So it seems like the response to EXAMINE actually gives the * FLAGS twice.. I'll try the debug flag and see if I can get a better idea of the problem.

@NickeZ I know this is late follow-up, but did you ever figure out what was wrong here?

hey! I don't remember really. I think I managed to dump all my e-mail. But I don't recall if this was a problem in the end. Thanks!

Thanks for following up! Well, I think in that case we can close this, and if someone runs into it again, re-open :)


OpenIdConnectEvents event for RemoteSignOut complete

A useful event to have would be one that fires after the sid checking is complete and the authentication cookie has been removed.

not until v2.0 unless we find a way not to break everybody. https://github.com/aspnet/Security/issues/942#issuecomment-238947101

Parking in 2.2.0 milestone for consideration.


Unable to scaled-up based on an Azure Service Bus using KEDA

Discussed in https://github.com/kedacore/keda/discussions/2877

Originally posted by jitendrabehera2 April  4, 2022
Hi
I am trying to set a scaling rules in Azure Container Apps using KEDA.
I followed the tutorial here:
https://www.codit.eu/blog/scaling-apps-with-kubernetes-based-event-driven-autoscaling-keda/?country_sel=be
But after insert message in my azure subscription it not scaled up. Please help me on this.
Specifications

**KEDA Version: 2.6
Platform & Version: Windows 10, Docker Desktop Kubernetes cluster**

deploy-order-processor.yml
apiVersion: v1
kind: Secret
metadata:
name: order-secrets
labels:
app: order-processor
data:
SERVICEBUS_QUEUE_CONNECTIONSTRING: XXXXXXXXXXXXXXXXXXX

kind: Deployment
apiVersion: apps/v1
metadata:
name: order-processor
labels:
app: order-processor
spec:
replicas: 1
selector:
matchLabels:
app: order-processor
template:
metadata:
creationTimestamp: null
labels:
app: order-processor
spec:
containers:
- name: order-processor
image: myapps:latest
env:
- name: KEDA_SERVICEBUS_QUEUE_CONNECTIONSTRING
valueFrom:
secretKeyRef:
name: order-secrets
key: SERVICEBUS_QUEUE_CONNECTIONSTRING
resources:
limits:
cpu: 250m
memory: 256Mi
requests:
cpu: 100m
memory: 128Mi
terminationMessagePath: /dev/termination-log
terminationMessagePolicy: File
imagePullPolicy: Always
restartPolicy: Always
terminationGracePeriodSeconds: 30
dnsPolicy: ClusterFirst
nodeSelector:
beta.kubernetes.io/os: linux
securityContext: {}
schedulerName: default-scheduler
strategy:
type: RollingUpdate
rollingUpdate:
maxUnavailable: 25%
maxSurge: 25%
revisionHistoryLimit: 10
progressDeadlineSeconds: 600

apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
name: azure-servicebus-auth
spec:
podIdentity:
provider: azure

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
name: prism-processor-scaler
namespace: prism-akscontainer
labels:
app: order-processor
deploymentName: order-processor
spec:
scaleTargetRef:
name: order-processor
minReplicaCount: 1  # We don't want pods if the queue is empty
maxReplicaCount: 5  # We don't want to have more than 5 replicas
triggers:

type: azure-servicebus
metadata:
topicName: prismcoretopic
subscriptionName: QC_GA_DADE_Subscription
connection: KEDA_SERVICEBUS_QUEUE_CONNECTIONSTRING
messageCount: '5'
pollingInterval: '30'
cooldownPeriod: '300'

Could you provide logs for the keda-operator pod?

Duplicate of https://github.com/kedacore/keda/discussions/2877


added The Absolute Realm

Welcome to the Cuddler Webring, fellow lover of cuddles!
Now add links on your webpage to
https://cuddler-webring.netlify.app/shinto/next and
https://cuddler-webring.netlify.app/shinto/previous.


tree broken by recent update

tree is broken:
$ nix-build --no-out-link -A tree
these derivations will be built:
  /nix/store/z08rzjmg5jz3s91qhsdj5blq0p07v3bb-tree-1.8.0.drv
building '/nix/store/z08rzjmg5jz3s91qhsdj5blq0p07v3bb-tree-1.8.0.drv'...
unpacking sources
unpacking source archive /nix/store/yksivrsn7ya9ccfq80zxvl7dy76y7liq-tree-1.8.0.tgz
source root is tree-1.8.0
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file tree-1.8.0/CHANGES
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/phqa311klldrcbwid1i22dwnpfc9dnma-bash-5.1-p8/bin/bash prefix=/nix/store/lcbszzq9a20i74xddzdblz8rawnnlmz1-tree-1.8.0 MANDIR=/nix/store/lcbszzq9a20i74xddzdblz8rawnnlmz1-tree-1.8.0/share/man/man1 CC=\$CC
C -ggdb -pedantic -Wall -DLINUX -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -c -o tree.o tree.c
/nix/store/phqa311klldrcbwid1i22dwnpfc9dnma-bash-5.1-p8/bin/bash: line 1: C: command not found
make: *** [Makefile:104: tree.o] Error 127
builder for '/nix/store/z08rzjmg5jz3s91qhsdj5blq0p07v3bb-tree-1.8.0.drv' failed with exit code 2
error: build of '/nix/store/z08rzjmg5jz3s91qhsdj5blq0p07v3bb-tree-1.8.0.drv' failed

According to git-bisect, this is the commit that broke it:

commit 378659148dbc0a376fa1d59b388fd156c4620f59
Author: Sandro Jäckel<EMAIL_ADDRESS>Date:   Fri Nov 12 17:30:38 2021 +0100
tree: cleanup, take maintainership
pkgs/tools/system/tree/default.nix | 54 ++++++++++++++++++--------------------
1 file changed, 26 insertions(+), 28 deletions(-)

Ping @SuperSandro2000.

 I just realized that this issue has been fixed in recent versions of master. I guess all I have to do is to wait for nixos-unstable to update.


Automated cherry pick of #5038: fix: 避免因tenantcache未缓存tenant导致创建云账号失败

Cherry pick of #5038 on release/3.1.
#5038: fix: 避免因tenantcache未缓存tenant导致创建云账号失败

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@bd2d11f). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             release/3.1   #5039   +/-   ##
=============================================
  Coverage               ?   6.76%
=============================================
  Files                  ?     544
  Lines                  ?   95129
  Branches               ?       0
=============================================
  Hits                   ?    6431
  Misses                 ?   88159
  Partials               ?     539

Flag
Coverage Δ

#aFlag
6.76% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/cloudaccounts.go
0.78% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2d11f...8739393. Read the comment docs.

/lgtm

/approve


Add student domain for Vellore Institute of Technology

vit.ac.in is the domain for faculty email ids. This domain is already added. The domain for student email ids is vitstudent.ac.in

@kairavsheth First stage of verification passed, official domain is vit.ac.in as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: http://chennai.vit.ac.in/files/MBA_7th Oct 2020.pdf


Ability to open sibling panels

I'm building an extension that shows data from a topic, and I would like to add the ability to open a sibling plot to show values over time, similar to the functionality in the Diagnostics panel and Raw Messages panel.
It looks like those panels call openSiblingPlotPanel and openSiblingStateTransitionsPanel, but when I try to import those from studio-base I run into all kinds of issues with dependencies. I'm guessing the "right way" to do this would be to have an extension API method that would allow opening sibling panels?
If there are other ways to achieve this please let me know! I think this is a particularly valuable feature in the base Studio app and would love to bring it into my extension.

@jessicaaustin would you mind re-filing this in the https://github.com/foxglove/studio repo? We can track it better there. And yea - I'm thinking the context would have a method whereby you can open a sibling panel by its fully qualified ID.

https://github.com/foxglove/studio/issues/1914

Thank you! Closing this out in favor of the studio issue.


HPC-friendly PyLossless

The aim of this issue is to merge back in the main PyLossless project the modifications that were made in this fork https://github.com/Andesha/pylossless to make PyLossless more HPC-friendly. My understanding from the diff is that most of these modifications have to do with making the package more lightweight, but most importantly, reducing dependencies (e.g., removing dependencies related to the dashboard, which is not run through bash scripts used in an HPC context). I think the functionalities required by this fork could be implemented as part of the main PyLossless project with a install of the type pip install pylossless[light]

@Andesha, please feel free to comment if you think I am not capturing your specific requirements or if you think this issue is a bad idea overall. I discussed this with @jadesjardins earlier today.

Comparing the fork https://github.com/lina-usc/pylossless/compare/main...Andesha:pylossless:main
71 files are modified.
Among those, the following files were removed:

4 files from.github/workflows.
.pre-commit-config.yaml, .readthedocs.yaml, and codecov.yml.
5 files in the examples folder.
2 files in the notebooks folder.
28 pylossless/assets/... files
13 pylossless/dash/... files
3 pylossless/dataset/... files
3 pylossless/tests/... files
removal of requirements_qc.txt and requirements_texting.txt

I don't think that the presence of these files would actually cause an issue for the execution on HPC. It may make the package slightly larger, but this effect should be fairly negligible. If some of these files were removed because their functionalities require dependencies not wanted for an HPC application, I think the issue needs to be solved with the installer script, not be removed files from the package. So, I propose not merging these changes.
One additional change not to be merged:

Change to .gitignore to add a test.py to the files to be ignored.

Here are the files which diff need to be further considered to merge relevant changes:

README.md
init.py
pylossless/assets/ll_default_config.yaml
pylossless/flagging.py
pylossless/pipeline.py
requirements.txt
setup.py

The requirements from @Andesha has numpy<2. I'd rather not include that. Less-than version requirements are nasty. To be avoided if possible. Do we know if this is still needed and if so, what is the context?

@scott-huberty Part of the changes were substituting
            f"  Noisy: {self.get('ch_sd', None)}\n"
            f"  Bridged: {self.get('bridge', None)}\n"
            f"  Uncorrelated: {self.get('low_r', None)}\n"

by
            f"  Noisy: {self.get('noisy', None)}\n"
            f"  Bridged: {self.get('bridged', None)}\n"
            f"  Uncorrelated: {self.get('uncorrelated', None)}\n"

On the one hand, the latter is definitely more readable. On the other hand, it is a breaking change. What is your opinion on adopting that change?

For pylossless/assets/ll_default_config.yaml, Taylor's fork scrubs slurm, general_info, and t_info from the config file. I cannot see these fields used anywhere in the current code base, so I tend to align with his choice to remove these.

For pylossless/assets/ll_default_config.yaml, Taylor's fork scrubs slurm, general_info, and t_info from the config file. I cannot see these fields used anywhere in the current code base, so I tend to align with his choice to remove these.

Agreed.

@scott-huberty Part of the changes were substituting
            f"  Noisy: {self.get('ch_sd', None)}\n"
            f"  Bridged: {self.get('bridge', None)}\n"
            f"  Uncorrelated: {self.get('low_r', None)}\n"

by
            f"  Noisy: {self.get('noisy', None)}\n"
            f"  Bridged: {self.get('bridged', None)}\n"
            f"  Uncorrelated: {self.get('uncorrelated', None)}\n"

On the one hand, the latter is definitely more readable. On the other hand, it is a breaking change. What is your opinion on adopting that change?

I'm sorry I'm not following. Here is the pattern on main:
https://github.com/lina-usc/pylossless/blob/c647153bd39315b94f39a122a2e8629a3c1f08d5/pylossless/pipeline.py#L507-L512
In the code you are displaying, it seems like f strings are being used instead of a dictionary.
BTW If by breaking change you are referring to the flag names, That was merged in https://github.com/lina-usc/pylossless/pull/152

Well... it seems like pipeline.py and flagging.oy as not in sync somehow... or I am missing something... https://github.com/lina-usc/pylossless/blob/c647153bd39315b94f39a122a2e8629a3c1f08d5/pylossless/flagging.py#L21-L26

OK, it seems that what it is only the repr that was not properly updated by #152 originally. Adjusting the flagging.py consistently with
 # Flagged Channels
 flagged_channels_data = {
     "Noisy": ch_flags.get("noisy", None),
     "Bridged": ch_flags.get("bridged", None),
     "Uncorrelated": ch_flags.get("uncorrelated", None),
 }

For the record, the approach with pip install pylossless[light] would not work because the extra in pip install package[extra] can only be used to add extra dependencies, not alternative dependencies... so it cannot be used to install less dependencies. We would need to have "light" by default and use something like [full] to have all dependencies... which I think is not desirable. Anyway, looking at the diff, I don't think it is need anyway.

Right... It depends on what dependencies are the issue.
@Andesha Can you please let us know.

Yeah. I integrated whatever changes seem to make sense of it and I was thinking of asking @jadesjardins to check if the PR works for him because it is my understanding that he needs that for running Q1K through the pipeline. I guess @Andesha is probably using his fork for wrapping pylossless for EEGNet, so the requirement may be a bit different. If that is the case, maybe you could also test it, @Andesha, and clarify what needs to be edited to make it work.

I am still getting the same error when trying to run the hpc-friendly-pylossless branch on Narval... this is the error message:
$ cat slurm-38223405.out
Traceback (most recent call last):
File "/lustre06/project/6030602/q1k/experimental/HSJ/derivatives/pylossless/code/q1k_submit_pylossless/main.py", line 1, in
import pylossless as ll
File "/project/def-emayada/q1k/experimental/q1k_env/lib/python3.11/site-packages/pylossless/init.py", line 1, in
from . import pipeline, bids, config, datasets, flagging, utils
File "/project/def-emayada/q1k/experimental/q1k_env/lib/python3.11/site-packages/pylossless/pipeline.py", line 33, in
from .flagging import FlaggedChs, FlaggedEpochs, FlaggedICs
File "/project/def-emayada/q1k/experimental/q1k_env/lib/python3.11/site-packages/pylossless/flagging.py", line 16, in
import mne_icalabel
File "/project/def-emayada/q1k/experimental/q1k_env/lib/python3.11/site-packages/mne_icalabel/init.py", line 5, in
from . import features  # noqa: F401
^^^^^^^^^^^^^^^^^^^^^^
File "/project/def-emayada/q1k/experimental/q1k_env/lib/python3.11/site-packages/mne_icalabel/features/init.py", line 3, in
from .topomap import get_topomaps  # noqa: F401
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/project/def-emayada/q1k/experimental/q1k_env/lib/python3.11/site-packages/mne_icalabel/features/topomap.py", line 6, in
from mne.io import Info
ImportError: cannot import name 'Info' from 'mne.io' (/project/def-emayada/q1k/experimental/q1k_env/lib/python3.11/site-packages/mne/io/init.py)

OK. Thanks, this is useful. I did not know this was the issue. Let me check the issue and push a commit.

I think this bug was present in mne_icalable v0.4 and fixed in v0.5. Currently, the requirement file set "mne_icalabel>=0.6.0", so it should be fine. How do you install pylossless?

In the section to install for HPC, the readme on the master install specifically v0.4, which would cause the issue. On this branch, the corresponding text is
# Clone down mne-iclabel and switch to the right version and install it locally
cd ~/eeg-env
git clone https://github.com/mne-tools/mne-icalabel.git
cd mne-icalabel
git checkout maint/0.5
pip install .

So it should work... but do we have any reason to believe it is actually necessary to install this from source? Could you try to see if pip install --upgrade mne-icalabel fix your issue?

in my test environment I definitely used mne-icalabel main/0.4 .... I will try 0.5 and let you know.

actually, I will try the pip install --upgrade first...

Unless there were some HPC-specific issues with using the latest version of that package (0.7), the pip install --upgrade should work fine! And is simpler... I expect that the installation from the clone was used at some point where a recent PR was necessary, but was not yet merged in the latest release. Such PR has long been included since they made multiple releases since then.

it is working after the upgrade!

Thanks @christian-oreilly for the detective work 🕵

Alright! I changed the README to use the current version of mne-icalabel instead of an outdated clone. I'll give a few days for @Andesha to comment if he cares to comment about the usability of this version for his application (EEGNet I suppose) and will proceed with these changes if he does not comment (I think he is probably working on other stuff these days).


Add vela cli documentation

This is use for

a first glance of vela command and all sub commands and their usages.
dashboard developers to look function and parameters details. We don't need to rewrite Restful API specification for every interface.

LGTM


Allow enabling of anonymous provider via tenant configuration

Internal API proposal: http://doc/1ikY2GoQZrwHNJ5mBa---t2o9R-MdjA4np4uW9SJ9dTg#heading=h.x94y9zzc13xn

Can you add a reference to the API proposal in the description.

Done.

Looks like this was almost over the line before the holidays hit. Hope this comment may bring it back on someone's radar. Thanks.

Looks like this was almost over the line before the holidays hit. Hope this comment may bring it back on someone's radar. Thanks.

Thanks for the reminder.  (It had stalled due to some internal launch processes, but those were cleared up just before the holidays.)


Experimental icons needs a 'edit' icon

There is no edit icon in the ion-icon library
We are currently using the create icon as edit, but the tooltip shows 'create' and there is no way to overwrite it.
related to https://goa-dio.atlassian.net/browse/CS-1051

@chrisolsen will investigate to see if there is an issue in the label parameter not being set correctly.


"additional" Properties are not correctly sent to IDS metadata broker

Properties that appear under the "additional" key of an offer description are not correctly converted to IDS-IM messages.  I show two different cases below, none of which is handled correctly, as well as an example of how this is not a Metadata Broker issue.
Example 1
This offer has the following in its description (as per DSC /api/offers endpoint)
        "additional": {
          "ids:theme": "https://my.vocabulary/themes/Enterprises",
          "ids:contentType": "https:/my.ontology/Dataset"
        }

If I try to push this, using the DSC /api/ids/resource/update endpoint, to an IDS Metadata Broker, I get an error back saying:
{
  "reason": {
    "properties": null,
    "@id": "https://w3id.org/idsa/code/MALFORMED_MESSAGE"
  },
  "payload": "The message could not be parsed due to an error in the message. Note that, due to being unable to parse this message, the ID of the correlating message is incorrect. Error: Failed to find matching enum value for https:/my.ontology/Dataset",
  "type": "de.fraunhofer.iais.eis.RejectionMessageImpl"
}

A message is shown in the metadata broker logs regarding enums also:
broker    | 18:24:27.312 [http-nio-8080-exec-4] INFO  de.fraunhofer.iais.eis.ids.jsonld.Parser - Available enums are: https://w3id.org/idsa/code/INTERFACE_DEFINITION
broker    | 18:24:27.313 [http-nio-8080-exec-4] INFO  de.fraunhofer.iais.eis.ids.jsonld.Parser - Available enums are: https://w3id.org/idsa/code/SCHEMA_DEFINITION

Example 2
This offer has the following in its description (see the lack of prefix)
        "additional": {
          "theme": "https://my.vocabulary/themes/Enterprises",
          "contentType": "https:/my.ontology/Dataset"
        }

Pushing this to the broker returns in a nice 200 message, however, when retrieving the description of the resource using the /api/ids/description endpoint of the DSC, I get no reference of the two additional properties quoted above:
{
  "@graph" : [ {
    "@id" : "http://central-core:8282/connectors/1012493422/-336692087/-1247151697",
    "@type" : "ids:Resource",
    "sameAs" : "http://localhost:8282/api/offers/5d877ea1-21a3-45b0-a9d3-8758eeac6fa4",
    "contractOffer" : "http://central-core:8282/connectors/1012493422/-336692087/-1247151697/411470713",
    "created" : "2022-02-05T16:34:13.491Z",
    "description" : "",
    "language" : "https://w3id.org/idsa/code/EN",
    "modified" : "2022-02-05T18:07:32.247Z",
    "representation" : "http://central-core:8282/connectors/1012493422/-336692087/-1247151697/-823090980",
    "resourceEndpoint" : "http://central-core:8282/connectors/1012493422/-336692087/-1247151697/-1014866500",
    "standardLicense" : "http://www.opendefinition.org/licenses/gfdl",
    "title" : "Dataset Eleven",
    "version" : "3"
  }
.
.
.

Example 3
This time I have hand crafted a message to the dataspace broker with the following payload (from their documentation)
{
  "@context" : {
    "ids" : "https://w3id.org/idsa/core/",
    "idsc" : "https://w3id.org/idsa/code/"
  },
      "@type" : "ids:DataResource",
      "@id" : "https://w3id.org/idsa/autogen/dataResource/afaafe22-fb63-4532-a1e1-15230cb99444",
       "ids:thema": "https://my.vocabulary/themes/Industry",
      "ids:representation" : [ {
        "@type" : "ids:DataRepresentation",
        "@id" : "https://w3id.org/idsa/autogen/dataRepresentation/d5b72746-2302-4685-99b8-fc2be06fd23f",
        "ids:instance" : [ {
          "@type" : "ids:Artifact",
          "@id" : "https://broker.ids.isst.fraunhofer.de/connectors/"
        } ]
      } ]
}

And, when I then use the /api/ids/description endpoint of the DSC to get that dataset's description, I get back:

  "@graph" : [ {
    "@id" : "http://central-core:8282/connectors/1012493422/-336692087/1870145456",
    "@type" : "ids:DataResource",
    "sameAs" : "https://w3id.org/idsa/autogen/dataResource/afaafe22-fb63-4532-a1e1-15230cb99444",
    "representation" : "http://central-core:8282/connectors/1012493422/-336692087/1870145456/1691410900",
    "thema" : "https://my.vocabulary/themes/Industry"
  }, {
    "@id" : "http://central-core:8282/connectors/1012493422/-336692087/1870145456/1691410900",
    "@type" : "ids:DataRepresentation",
.
.
.

To Reproduce
Create an offer that has additional properties. These are created, afaiu, by adding arbitrary key-value pairs to the json.
Expected behavior
The additional properties should be sent in the IDS message as properties of the ids:resource (not clear how they are being sent at the moment)
Desktop (please complete the following information):
DSC 6.2
Changelog does not suggest this behaviour to have changed in 7.

Let me try to explain the 3 observations you made. I guess all of dem are related to the IDS Broker implementation, not to any issue of the DSC.
Example 1
The properties attribute of each class is for custom values. With the prefix ids, the Broker resp. the IDS Infomodel Serializer, recognizes a field that is apparently known (as part of the default IDS Infomodel). As there is a list of allowed values for ids:theme and ids:contentType and your values do not match them, this error is thrown.
Example 2
I just checked wether additional attributes are correctly mapped to the IDS Infomodel by the DSC. Their are.
POST /api/offers/ with payload {"title": "Example resource", "paymentModality": "free", "test": "value"} returns:
{
	"creationDate": "2022-02-07T09:51:29.938+0100",
	"modificationDate": "2022-02-07T09:51:29.938+0100",
	"title": "Example resource",
	"description": "",
	"keywords": [
		"DSC"
	],
	"publisher": "",
	"language": "",
	"license": "",
	"version": 1,
	"sovereign": "",
	"endpointDocumentation": "",
	"paymentModality": "free",
	"samples": [
	],
	"additional": {
		"test": "value"
	},
	"_links": {
		"self": {
			"href": "https://localhost:8080/api/offers/ef7e0a36-6886-489c-8afb-c9226a490f2b"
		},
		[...]
	}
}

as IDS:
{
  "@context": {
    "ids": "https://w3id.org/idsa/core/",
    "idsc": "https://w3id.org/idsa/code/"
  },
  "@type": "ids:ResourceCatalog",
  "@id": "https://localhost:8080/api/catalogs/cbd3f799-0100-43f4-af37-111d1117ccfb",
  "ids:offeredResource": [
    {
      "@type": "ids:Resource",
      "@id": "https://localhost:8080/api/offers/ef7e0a36-6886-489c-8afb-c9226a490f2b",
      "ids:language": [
        {
          "@id": "https://w3id.org/idsa/code/EN"
        }
      ],
      "ids:version": "1",
      "ids:description": [
        {
          "@value": "",
          "@language": "EN"
        }
      ],
      "ids:title": [
        {
          "@value": "Example resource",
          "@language": "EN"
        }
      ],
      [...]
      "ids:paymentModality": {
        "@id": "https://w3id.org/idsa/code/FREE"
      },
      "ids:publisher": {
        "@id": ""
      },
      "ids:sovereign": {
        "@id": ""
      },
      "ids:modified": {
        "@value": "2022-02-07T08:51:29.938Z",
        "@type": "http://www.w3.org/2001/XMLSchema#dateTimeStamp"
      },
      "ids:resourceEndpoint": [
        {
          "@type": "ids:ConnectorEndpoint",
          "@id": "https://w3id.org/idsa/autogen/connectorEndpoint/75b5f086-fa3f-4309-8ed0-a98c915c2810",
          "ids:endpointDocumentation": [
            {
              "@id": ""
            }
          ],
          "ids:accessURL": {
            "@id": "https://localhost:8080/api/offers/ef7e0a36-6886-489c-8afb-c9226a490f2b"
          }
        }
      ],
      "test": "value"
    }
  ]
}

Thus, I assume that the IDS Broker somehow throws away these additional properties. Can you please take a look or comment? @sebbader @NehaThawani44
Example 3
I don't understand your point here. Is there some information missing or do you wonder about the syntax of the response? This is somehow different from the one used in the DSC, but still syntactically correct IDS Infomodel.

Thanks @juliapampus  for the detailed reply.
I confirm that if I add properties which are not part of IDS-IM they are correctly transmitted to the Broker, and further stored and returned by it.


ROS mission tests simple markdown documentation

Not that useful yet.
https://github.com/PX4/Firmware/blob/5a1d98015040c0149a529745da2c606ad42c128d/integrationtests/python_src/px4_it/mavros/tests.md
TODO

each Jenkins build should either include the description or link to this (both Jenkins and posted flight review)
missions need meaningful naming
test everything!

Some thoughts:

Purple for the mission path is not very easy to see. Offboard tracks much easier to see. If possible use more distinctive colour. Maybe also crop closer to the actual path. Maybe use a higher resolution image.
Is it worth moving the content to README in the directory?

My understanding is that this will then render the tests on the page that gets displayed when you go to the parent directory. That is more discoverable.
Also allows you to have more general docs about what is in the folder.

These are screenshots of flight review, but I agree. If we wanted to get really fancy they should be rendered from the example URL.

These are screenshots of flight review, but I agree.

OK, well just for comparison, screenshot below is 1200Kb, while yours are 200Kb. Somewhere in between would be good.

Another idea, use the map view:

I think the photo should match what will come up in flight review -- same map -- to compare easier when necessary. If the missions will change down the line, it might be easier (in terms of future maintenance) to render them from the example.
I don't have a strong opinion where this goes, but what about here?: https://dev.px4.io/en/test_and_ci/integration_testing.html (which recently became outdated as well)

I don't have a strong opinion where this goes, but what about here?: https://dev.px4.io/en/test_and_ci/integration_testing.html (which recently became outdated as well)

I discussed this with @dagar offline. I had a slight preference for that location too, but it doesn't matter as long as we have clear links between the places. I also thought having tests in README.md better than tests.md, so that they auto render when you go to the folder.

Importing the map would be cool, but not particularly easy.

How about we make the image a link to the example, and change the row heading to Example (Click Image)?

Because this will be under active development it makes sense to leave it on the firmware side rather than the dev guide -- so pull requests can include both -- and link to it in the dev guide.
Regarding the readme: You're probably right, although I really don't see users caring about development testing. Again no preference. Renaming it is fine.

I agree.

Removing the example link from the description to the image along with changing the column heading to reflect it is a good idea

@dagar What is blocking moving this forward? I'm quite tempted to pull this into the devguide instead.


Russian translation

I want to translate this game to Russian. But someone has already requested to add this language to the project on app.transifex.com. Can you please accept that request or reject it so I can make my request?

I am sorry, but due ongoing issues affecting me personally, I cannot accept a Russian language translation for the time being.
If you want though, I can offer you that I could add an easy way for you to make a "language pack" that users can add to the game if desired. At least for the Linux and Windows versions, probably for macOS too, it would be rather easy for me to provide users the ability to simply place language files right next to the game executable and use those if available.
Right now there is also a minor amount of per-language customization that is required to make a language work (like which font to use), but I think I can easily move that into the language files too to better enable the possibility of externally provided language packs.

As a simple preparation, I now factored all per-language settings of the game that normally require code changes to add a language into the .po files themselves. If you want, I can soon add code to the game to automatically detect a pair of game.po and level.po files in the game executable's directory, and use that instead of the builtin languages. Would that be acceptable to you?

If you want, I can soon add code to the game to automatically detect a pair of game.po and level.po files

It would be great. I already made first version of translation, but only able to use it in cheat mode which doesn't allow to save progress.

OK, I just made changes to the game engine so it accepts .po files placed next to the game executable when you pass the option -language=.. I will later make it autodetect existence of such files at startup.

Finished language pack support - now if one is placed next to the game executable, it will be detected by the in-game menu.
This is as much as I'll support for now - enjoy!


Workflow for migrating from Jetpack 6 DP to Jetpack 6 GA ?

After migrating from Jetpack 6 DP to GA with this steps:
https://docs.nvidia.com/jetson/archives/jetpack-archived/jetpack-60/install-setup/index.html#upgrade-jetpack
The docker commands are not working anymore:
jetson-containers run --name ollama $(autotag ollama)
docker run -it --rm --network=host --add-host=host.docker.internal:host-gateway -v open-webui:/app/backend/data ghcr.io/open-webui/open-webui:main
->
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
Does the update broke docker ?
If there is an easy way to fix this, please help. greetings

What does this show?:
sudo systemctl status docker

Does this iptables fix work? I also had to do that first time I ran containers on Jetsons ( JP 6.x )

You are right my posting was easy to misinterpret, i used 2 terminals, each of them for one command.
`sudo systemctl status docker says:
× docker.service - Docker Application Container Engine
     Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Thu 2024-05-09 12:32:03 CEST; 5min ago
TriggeredBy: × docker.socket
       Docs: https://docs.docker.com
    Process: 2288 ExecStart=/usr/bin/dockerd -H fd:// --containerd=/run/containerd/containerd.sock (code=exited, status=1/FAILURE)
   Main PID: 2288 (code=exited, status=1/FAILURE)
        CPU: 220ms

Mai 09 12:32:03 orin-desktop systemd[1]: docker.service: Scheduled restart job, restart counter is at 3.
Mai 09 12:32:03 orin-desktop systemd[1]: Stopped Docker Application Container Engine.
Mai 09 12:32:03 orin-desktop systemd[1]: docker.service: Start request repeated too quickly.
Mai 09 12:32:03 orin-desktop systemd[1]: docker.service: Failed with result 'exit-code'.
Mai 09 12:32:03 orin-desktop systemd[1]: Failed to start Docker Application Container Engine.

I can search the docker issue for my one, but asked here if dusty or some other nvidia member has tips for upgrading this way ( https://docs.nvidia.com/jetson/archives/jetpack-archived/jetpack-60/install-setup/index.html#upgrade-jetpack ) , because it was recommended by nvidia
`

Does this iptables fix work? I also had to do that first time I ran containers on Jetsons ( JP 6.x )

YESS. It worked, the link to your solution should be posted in the official nvidia update guide.

Thanks, if that solved your problem, mark the issue as closed 😁

Does this iptables fix work? I also had to do that first time I ran containers on Jetsons ( JP 6.x )

YESS. It worked, the link to your solution should be posted in the official nvidia update guide.


Antivirus Check?

I am sorry to ask here but nobody else seems to know. We need to scan uploaded files for viruses.
We have configured ICAP on ORDS using Sophos SAVDI. But it is not working. It seems we need to be able to set the service that we have configured on the SAVDI side or change the SAVDI service to that of what Apex is expecting. Do you by any change know how to set-up ICAP ?
We know that SAVDI is working as we tested it using the c-icap-client to upload a test virus file.

Hey @JacoFourie
sorry I'm not really familiar with this kind of virus scans...As you're saying that you configured it with ORDS, does it work with standard APEX file inputs?
I would definitely choose the "normal" upload method instead of "chunked", thus there the file is not splitted into 1mb chunkes which are base64 encoded...I bet a virus scan engine wouldn't recognize viruses in that encoded chunks...
The normal upload methods sends the file as is to the server using multipart/formData POST

@Dani3lSun thanks for coming back to me about this. How do you check for viruses in files being uploaded into Apex if you say you dont use the ICAP method? Let say you develop an app that you open up to the internet where people will upload CVs to apply for a job. You don't know what files will come into your DB and you need to make sure it is stopped before it gets to the DB. We have installed your plug-in and we see this error if we enable ICAP on ORDS.

I know this is not an issue with your plug-in. was just hoping that seeing you work with files a lot you would know how to do the ICAP part.


Stopped the "close" event from triggering when clicking Confirm and Cancel buttons.

I was hoping there would be a better way to accomplish this. I don't want the 'close' event to trigger when clicking 'confirm' or 'cancel' but I do want the modal to close. I have events that need to trigger when closing that don't need to run when confirming or canceling.

Incompatible solution. Extra data for the 'close' event is much better.

https://github.com/VodkaBears/Remodal/commit/7a1fb50a6e06c06570ab54e1a0aabc282e928800


improve contrast for several link styles, fix #52

I decreased the lightness of a couple link style colors and following accessibility (WCAG 2.1) requirements.
Before:

After

my commits were messy and we've changed the default style of link styling (and this commit was before this); and I was kinda lazy and didn't rebase this, so I just made a new branch.


Resolve issue #18 where only the first 500 products are returned

Hello @timgaunt , thanks you for spending time to make this PR.
I've pushed the version 13.1.1--preview.2.g5c9044e to Umbraco Nightly Feed. Can you verify that the preview solve the issue? Once you do, I'll push the 13.1.1 to nuget in 24 hour.


Internal overflow error in floff

====== BEGIN OUTPUT ======
INFO: Running with entropic power schedule (0xFF, 100).
 Test unit written to ./crash-1ea458a26909c872f9c66cd50d1b0b8036674bb3
Base64: NDQ0NDQ0NjU1NjY4ODUuMjYyNTUyCi0zMjcxOTQ3MDc1LjQ0MjEyNwoxODY2MTQ2ODgxLjI4MjM0NjcKOTkyMjMxODY4Ny4yNDc1MzIKMjEwNTg4OTM3NC45NTQzNDc2CjE0MTIxOTExNDUuMTk5MDczOAo0ODk5MjQ0AA==

EXIT STATUS: 1
====== END OUTPUT ======

Overflow is in this rounding check: https://github.com/boostorg/charconv/blob/develop/include/boost/charconv/detail/dragonbox/floff.hpp#L2426

fractional_part_rounding_thresholds32[digits_in_the_second_segment - 1]

This should be fractional_part_rounding_thresholds32[digits_in_the_second_segment - 3] indeed. Thanks for catching this!


Add a global switch for ActiveRecord

Hey guys, first thank you for this great project! :)
I encountered lately an issue like this, where the ActiveRecord constant was loaded,
but on purpose not used on an app. The rails_helper.rb was configured
not to use transactions, etc.
Unfortunately, the FixtureSupport module was configured for ActiveRecord
and errored like this:
   ActiveRecord::ConnectionNotEstablished:
     No connection pool with 'primary' found.

I figured out that ActiveStorage had a dependency on ActiveRecord, which I do not use.
The app just makes use of the ActiveStorage service, without any database records.
So I had to unload the ActiveRecord constant on my rails_helper.rb like this:
# This file is copied to spec/ when you run 'rails generate rspec:install'
require 'spec_helper'
ENV['RAILS_ENV'] ||= 'test'
require File.expand_path('../../config/environment', __FILE__)

# Remove the ActiveRecord constant, because it is autloaded by
# ActiveStorage and not needed for our application. The presence
# of the ActiveRecord constant causes rspec-rails to include
# extra fixture support (see: https://goo.gl/6Ed17Y), which
# results in:
#
#   ActiveRecord::ConnectionNotEstablished:
#     No connection pool with 'primary' found.
#
Object.send(:remove_const, :ActiveRecord)

It would be better to have a configuration switch on rspec-rails to turn off any
handling of ActiveRecord. The guessing based on the availability of the constant
results in false-positive cases like mine.
Something like that would be helpful (guessing by default, but configurable):
RSpec.configure do |config|
  # Disable all ActiveRecord handling
  config.use_active_record = false
end

I'm also willing to send in a PR, if this is proposal is accepted. :)

Hmm this feels like a bug in active storage, if it's not using Active Record it shouldn't load ActiveRecord, can you not only load the parts you need? I'm not overall against the idea of a flag for it but we'd need to keep the auto detection as well and that feels like extra maintenance burden.

Yeah, it's probably an issue with ActiveStorage. The implementation makes it possible to go without a database by just using the configuration and the storage service. But hey, I could imagine there are more gems like that out there and it would be handy to have a flag for that.
I thought of something like this:
require 'ostruct'
require 'rspec'

# The logic under test. This should accomplish the auto configuration
# when no explicit user configuration was set. And it should honor a
# user configuration, when it is safe.
def process_config(config)
  if config.use_active_record != false && defined?(ActiveRecord)
    config.use_active_record = true
  else
    config.use_active_record = false
  end
end

def add_active_record
  Kernel.const_set('ActiveRecord', nil) unless defined?(ActiveRecord)
end

def remove_active_record
  Kernel.send(:remove_const, :ActiveRecord) if defined?(ActiveRecord)
end

RSpec.shared_examples 'config value' do |prop, actual, expected|
  it ['sets config to', expected.inspect, 'when',
      actual.inspect, 'was given'].join(' ') do
    subject[prop] = actual
    process_config(subject)
    expect(subject[prop]).to be(expected)
  end
end

RSpec.describe 'use_active_record configuration' do
  subject { OpenStruct.new(use_active_record: nil) }

  context 'ActiveRecord constant is defined' do
    before { add_active_record }

    [
      # given config value , expected config value
      [nil                 , true ],
      [true                , true ],
      [false               , false],
    ].each do |actual, expected|
      include_examples 'config value', 'use_active_record', actual, expected
    end
  end

  context 'ActiveRecord constant is undefined' do
    before { remove_active_record }

    [
      # given config value , expected config value
      [nil                 , false],
      [true                , false],
      [false               , false],
    ].each do |actual, expected|
      include_examples 'config value', 'use_active_record', actual, expected
    end
  end
end

use_active_record configuration
  ActiveRecord constant is defined
    sets config to true when nil was given
    sets config to true when true was given
    sets config to false when false was given
  ActiveRecord constant is undefined
    sets config to false when nil was given
    sets config to false when true was given
    sets config to false when false was given

Finished in 0.00162 seconds (files took 0.06667 seconds to load)
6 examples, 0 failures

Should I provide a PR for this?

You don't want to set the value based on autodetect, (because of load ordering issues) but suppress the auto check when it's explicitly disabled, I think that'd work for me

I'm a bit confused about your comment, do you propose a logic change? :)

Take a look at how our config is built, what you want is it to fall back to the defined? check if it's not been set, and don't memomize that value

None of the core team have any time to work on this, and its unlikely to get anywhere without an outside volunteer.

Sad to see that its impossible to run a Rails app by removing ActiveRecord without Jack's unmerged patch or removing a bunch of unrelated ActiveStorage stuff...
Wasted an hour fixing this today and I know I'm not the only one. Makes me hesitant to use ActiveStorage in new projects. Seems like fixing this should be a higher priority than new features...

Its not impossible, you just need to ensure ActiveRecord is configured if it is present.


Image generation fixes

Fixed:

-d sets device for all models including tokenizer. But tokenizers are known to work on CPU only
lcm_dreamshaper_v7 --seed is ignored for --num 4
lcm_dreamshaper_v7 with -r outputs 4 identical images

@Wovchena, please take a look


Debug options

The following debug options are currently available using a query parameter:

Debug Option
Query Parameter
Demo

Tile boundaries
show-tile-boundaries
Link

Collision boxes
show-collision-boxes
Link

Overdraw inspector
show-overdraw-inspector
Link

Until there is a general debug panel available as outlined in https://github.com/maputnik/editor/issues/252#issue-294367056, how about making these options available via shortcuts and adding them to the existing shortcut menu?

A shortcut for openening a link to https://www.openstreetmap.org/#map={ZOOM}/{LAT}/{LON}
(https://github.com/maputnik/editor/issues/82) could be also added there.
Even if a debug paneI would exist, I think it would be good to have these options available via shortcut anyway.

So my thoughts are that we should only add shortcuts for actions that have

obvious side effects in the UI
an easy way to reverse the action

So for instance it's quite easy to accidentally hit a shortcut key, you could be typing without having focus on an <input/> for example. The current shortcuts mostly open modals, which is fine because there is an obvious way out by pressing the [x] button
So if we do add the following as shortcuts we'd also need a way to reverse that in the UI

Tile boundaries
Collision boxes
Overdraw inspector

I feel like that means we'd need a UI to enable/disable these features as well as a visual cue for those that these are enabled.
Thoughts?

Good points.
What about a new Debug modal which is available from the toolbar? This would be independent from shortcuts.
There could be buttons/check-boxes which are also indicating whether a debug option is on/off.
#82 could go in there too, like how https://enable-cors.org/ opens in a new tab from the Open modal.

Regarding shortcuts for these:
Maybe use somthing like CTRL + ... or SHIFT + CTRL + ... to prevent an accidentally hit like how you described.
A shortcut could be used to toggle a debug option on/off (and also update the new Debug modal), so the way out would be the same as the way in.
I'm also fine to have no shortcuts for these at all.

Or do you think it's better to do nothing here and wait for https://github.com/maputnik/editor/issues/252?
This would be also fine with me.


DO NOT MERGE - testing ability to make a new branch by adding a file

Going through this as an exercise to make sure all is set up correctly.  I will revert.
DO NOT MERGE

Closing this out, as it was a test.

Closing this out, as it was a test.


USER STORY: Create Event page

As a developer, I will want to clean and concise error messages when input is invalid.
[ ] Clean up error messages for all fields on the Create Event page
[ ] Replace Event Cover Photo field with image upload picker

Closing since we no longer use user story issues.


Fix shortcut not working issue on macOS

The issue was cause by KeyCombination#match not working properly on macOS.
Before, this method only works after the character has been typed once.
e.g. ctrl-F can only be matched after the upper-case 'F' has been typed.
Could not find online bug reports of this issue, probably javafx version specific.
Solved issue with self-created method to manually check if the shortcut matches.
Closes #209.

@awhb @xenosf Can one of you please help me test on macOS laptop and confirm it works, thanks!


WEEK VIEW: CALENDAR SHOWING WRONG WEEK WHEN CHANGING TIMEZONE

CalendarDay minDate = CalendarDay.from(2016,Calendar.APRIL, 1);
CalendarDay maxDate = CalendarDay.from(2017,Calendar.MARCH, 9);
widget.state().edit()
    .setFirstDayOfWeek(Calendar.MONDAY)
    .setMinimumDate(minDate)
    .setMaximumDate(maxDate)
    .setCalendarDisplayMode(CalendarMode.WEEKS)
    .commit();

In the above code snippet, it works correctly with IST(+05:30)
But when I changed to PST(-08:00) the previous week is shown.

I found the same problem sometimes after change timezone, the days e move one column to right.

I have same issue. In some devices with same timezone it showing previous week.


Use RenderCache for all UI Widgets

Might have a nullptr by default, and enable/disable it when needed.

Some problems with this approach is that it would add an extra layer of confusion in case the widgets are updated, but the render cache isn't updated.
Users will need to be cognizant of dirty flags and use flag_as_dirty()


Source tarball distribution

Hey!
While packaging the latest scipy version for Exherbo I noticed that

pypi.org only provides the sources as zip file now (used to have tar.gz as well)
the github releases lack some files (e.g. the whole benchmarks/ directory, runtests.py, site.cfg.example etc.)

I would appreciate if someone could comment whether the distribution of tarballs exclusively on github is intentional and why the releases don't include the mentioned files
Thanks in advance and best regards,
Marvin

While packaging the latest scipy version for Exherbo I noticed that
pypi.org only provides the sources as zip file now (used to have tar.gz
as well)

This is a recent pypi change where they only allow a single sdist, and I
uploaded the zip archive. Is there a strong preference for a tar.gz
instead?)

the github releases lack some files (e.g. the whole benchmarks/
directory, runtests.py, site.cfg.example etc.)

There are two tarballs on gh releases: an autogenerated checkout from the
release tag, and the "binary" tar.gz, generated by $ make dist at the
release time. The former requires Cython as a build-time dependency to
generate the .c sources.
Cheers,
Evgeni

I would appreciate if someone could comment whether the distribution of
tarballs exclusively on github is intentional and why the releases don't
include the mentioned files
Thanks in advance and best regards,
Marvin
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Is there a strong preference for a tar.gz instead?)

I think the sdist won't be used much on Windows, and for Linux and OS X tar.gz is preferable.

.tar.gz shades it for me.

Don't think we can/should change this for 0.19.0 anymore, so marked it 1.0

gh-7768 updates the "how to release" documentation to say to upload .tar.gz to PyPI. Nothing else to do, so closing this.


xgboost: use pkgs.autoAddDriverRunpath

Description of changes
Part of https://github.com/NixOS/nixpkgs/issues/141803
Decided to universally add the driver runpath, may increase hardware acceleration regardless.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@jonringer, @SomeoneSerge  -  I don't have time to test this thoroughly now, but I am approving based on https://github.com/NixOS/nixpkgs/issues/141803. Please speak up if you object.


Rdar 40526328 emit sigint for cancelled batch constituents

This detects "batch constituents that had one of their neighbours emit an error" as signalled by #17131 and propagates that information to parseable output by writing a "signalled" message (pseudo-SIGINT) for each such pseudo-task.
This is backward-compatible with previous semantics, while giving consumers the opportunity to more-fully suppress such cases if they like (SIGINT is after all a user-generated interrupt signal; there's likely no point reporting it to the user as an error in any case.)
I also included a commit in here that supports adjusting batch size independently from -j / parallelism size. This was useful for testing this change, and has come up repeatedly as "something that would help test a hypothesis" during the past few months of testing batch mode.
rdar://40526328

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 72b3640d1ad16d2f860ec64e6f2b6bf909c6673b

Build failed
Swift Test Linux Platform
Git Sha - 72b3640d1ad16d2f860ec64e6f2b6bf909c6673b

@swift-ci please test and merge

@swift-ci please test and merge


Technical Outreach Event

Last year we had the basis of an outreach event planned for either Lower or Middle School students. We should continue that plan. Maya should have a copy of the plan outline. To proceed we need to:

[ ] Have a meeting with Ms. McCormick and Mr. Cooper
[ ] Email/Meet with other school heads
[ ] Run the Event

Last year we had the basis of an outreach event planned for either Lower or Middle School students. We should continue that plan. Maya should have a copy of the plan outline. To proceed we need to:

[ ] Have a meeting with Ms. McCormick and Mr. Cooper
[ ] Email/Meet with other school heads
[ ] Run the Event

In contact with the New Orleans Latter library


Better testing of the catalog and Blacklight integrations

The catalog page features recently broke due to a jQuery update. The build passed because we weren't testing that particular feature. We need to add additional feature testing to ensure all the features from Blacklight continue to work with each CI build
WDLL

Test expand/collapse of facets
Test UI elements?
Others?

Not specific enough.


Timeout waiting for navigator API server to start in e2e tests

W1113 16:58:41.944] + navigator_ready
W1113 16:58:41.944] ++ kubectl get deployment nav-e2e-navigator-controller --output 'jsonpath={.status.readyReplicas}'
W1113 16:58:42.052] + local replica_count_controller=1
W1113 16:58:42.052] + [[ 1 -eq 0 ]]
W1113 16:58:42.052] ++ kubectl get deployment nav-e2e-navigator-apiserver --output 'jsonpath={.status.readyReplicas}'
W1113 16:58:42.174] + local replica_count_apiserver=
W1113 16:58:42.174] + [[ '' -eq 0 ]]
W1113 16:58:42.174] + return 1
W1113 16:58:42.174] ++ date +%s
W1113 16:58:42.175] + local current_time=1510592322
W1113 16:58:42.175] + local remaining_time=-1
W1113 16:58:42.175] + [[ -1 -lt 0 ]]
W1113 16:58:42.175] + return 1
W1113 16:58:42.175] + kubectl api-versions
I1113 16:58:42.279] apiextensions.k8s.io/v1beta1
I1113 16:58:42.279] apiregistration.k8s.io/v1beta1
I1113 16:58:42.279] apps/v1beta1
I1113 16:58:42.279] authentication.k8s.io/v1
I1113 16:58:42.279] authentication.k8s.io/v1beta1
I1113 16:58:42.279] authorization.k8s.io/v1
I1113 16:58:42.279] authorization.k8s.io/v1beta1
I1113 16:58:42.279] autoscaling/v1
I1113 16:58:42.279] batch/v1
I1113 16:58:42.279] certificates.k8s.io/v1beta1
I1113 16:58:42.279] extensions/v1beta1
I1113 16:58:42.279] networking.k8s.io/v1
I1113 16:58:42.279] policy/v1beta1
I1113 16:58:42.279] rbac.authorization.k8s.io/v1alpha1
I1113 16:58:42.279] rbac.authorization.k8s.io/v1beta1
I1113 16:58:42.279] settings.k8s.io/v1alpha1
I1113 16:58:42.279] storage.k8s.io/v1
I1113 16:58:42.279] storage.k8s.io/v1beta1
I1113 16:58:42.279] v1
W1113 16:58:42.380] + kubectl get pods --all-namespaces
W1113 16:58:42.396] + kubectl describe deploy
I1113 16:58:42.499] NAMESPACE     NAME                                                           READY     STATUS              RESTARTS   AGE
I1113 16:58:42.499] kube-system   etcd-55ce72d6-c892-11e7-a1e2-0a580a1c2309                      1/1       Running             0          2m
I1113 16:58:42.499] kube-system   kube-addon-manager-55ce72d6-c892-11e7-a1e2-0a580a1c2309        1/1       Running             0          2m
I1113 16:58:42.499] kube-system   kube-apiserver-55ce72d6-c892-11e7-a1e2-0a580a1c2309            1/1       Running             0          2m
I1113 16:58:42.499] kube-system   kube-controller-manager-55ce72d6-c892-11e7-a1e2-0a580a1c2309   1/1       Running             0          2m
I1113 16:58:42.499] kube-system   kube-dns-1848271846-pg8v8                                      3/3       Running             0          3m
I1113 16:58:42.499] kube-system   kube-proxy-0n1l2                                               1/1       Running             0          3m
I1113 16:58:42.499] kube-system   kube-scheduler-55ce72d6-c892-11e7-a1e2-0a580a1c2309            1/1       Running             0          3m
I1113 16:58:42.499] kube-system   kubernetes-dashboard-06vfl                                     1/1       Running             0          2m
I1113 16:58:42.499] kube-system   tiller-deploy-3341511835-1hdjh                                 1/1       Running             0          1m
I1113 16:58:42.499] test-pods     nav-e2e-navigator-apiserver-1670849492-6hht2                   0/2       ContainerCreating   0          1m
I1113 16:58:42.499] test-pods     nav-e2e-navigator-controller-1608401658-w386t                  1/1       Running             0          1m

/kind bug
Full log:

https://prow.build-infra.jetstack.net/log?job=navigator-e2e-v1-7&id=33
log.txt

Perhaps we just need to wait longer for the apiserver container to start up.

I'd imagine this is caused by heavy load on our build infra VM - we are going to be setting up proper resource accounting for test jobs soon, which should hopefully reduce these sorts of errors. For now, a /retest should do it.

Haven't seen this error since @munnerz made the change above.


Create 0000-01-02-mmudge.md

added a sweet new feature
Add mmudge's file

looks great

great code


new type inference not using externs?

I'm using an extern for the Google Visualization API and it compiles fine using the old type system but with NTI I get warnings like this:
filevision/ui/field/PieChartField.js:70: WARNING - Type annotation references non-existent type google.visualization.PieChart.
     * @private {?google.visualization.PieChart}
                  ^

Can you link to the externs file? Sometimes the definitions there are a bit loose for NTI, eg, namespaces may not be defined.

Here it is:
gviz-api.zip
I downloaded it from somewhere (I don't remember) and modified it with some JSDoc annotation to match the textual description in the documentation.
Yesterday I noticed there was also an externs file for this API in the Closure repo at \contrib\externs\google_visualization_api.js but that's missing some of the JSDoc that mine has e.g.
/**
 * @override
 */
google.visualization.PieChart.prototype.draw = function(data, opt_options) {};

vs
/**
 * @param {google.visualization.DataTable|google.visualization.DataView} data
 * @param {Object=} opt_options
 */
google.visualization.PieChart.prototype.draw = function(data, opt_options) {};

I'll work on a PR to update the repo extern with the missing annotations.

The definitions for google, google.visualization and google.visualization.PieChart in that file look good. I tried a minimal example with them and NTI recognizes the type without issues.
https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%2520%2540type%2520%257Bgoogle.visualization.PieChart%257D%2520*%252F%250Avar%2520x%253B%26input1%26conformanceConfig%26externs%3Dvar%2520google%2520%253D%2520%257B%257D%253B%250Agoogle.visualization%2520%253D%2520%257B%257D%253B%250A%252F**%2520%2540constructor%2520*%252F%250Agoogle.visualization.PieChart%2520%253D%2520function(container)%2520%257B%257D%253B%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1
So there is another problem and we don't have enough info here to reproduce. Maybe you didn't provide the externs in that compilation? I'm not sure. If you can give me a way to reproduce the bug, then I can look into it. Closing for now.


Release v0.5.1: update Change log

What this PR does:
Release v0.5.1: update Change log
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #455 (42eeac4) into develop (c3a5d87) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #455   +/-   ##
========================================
  Coverage    37.20%   37.20%
========================================
  Files           55       55
  Lines         3790     3790
========================================
  Hits          1410     1410
  Misses        2220     2220
  Partials       160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a5d87...42eeac4. Read the comment docs.


Multi-container task definition

Multi-container task definition
The current module implementation assumes one container per tast definition. AWS however allows multiple container definitions per single tast. terraform-aws-ecs-alb-service-task Module demonstrates how multiple container definitions can be combined to achieve this.
It is technically possible to use an array of definitions as the argument for container_definition_json. For example:
module "ecs_alb_service_task" {
    ...
    container_definition_json = "[${module.first_container.json_map_encoded},${module.second_container.json_map_encoded}]"
    ...
  }

This however seems more like a workaround rather than expected solution.
Expected Behavior
A clear and concise description of what you expected to happen.
Use Case
We are deploying an appilcation consisting of nginx, php-fpm, and nodejs (frontend api). All these containers composit one application and must behave as one and scale as one unit.
Describe Ideal Solution
Ideally module definition would accept container_definitions (emphasis trailing s) instead of container_definition. For example:
module "ecs_alb_service_task" {
    ...
    container_definitions_json = [module.first_container.json, module.second_container.json]
    ...
  }

Variable descriptions should reflect this ability and provide examples.
Alternatives Considered
The two alternatives considered are: 1) use multiple services (single container per task, service) 2) stuff multiple definitions into container_definition_json.
Solution (1)  is not quite applicable to our use-case due to extreme additional complexity. Solution (2) would work, however it feels more like shoehorning.
Additional Context
I would be interested in working on a MR if this sounds like a reasonable project. Are there any issues in implementing this?

@osterman , is this feature worth pursuing in an MR? Anything that speaks against placing multiple container definitions into a single task with this module?

You can use this to make it look cleaner
module "ecs_alb_service_task" {
  ...
  container_definition_json = jsonencode([
    module.first_container.json_map_object,
    module.second_container.json_map_object,
  ])
  ...

Thanks for a quick reply @nitrocode ! Now that I see your example it occures to me that renaming a module attribute would introduce a breaking change and force everybody to upgrade to the new attribute name. This change is not worth it.
How about we add the example you provided to the README to demostrate the "official" way of using multiple container definitions?


Social Login plugin replaced default deeplink URL scheme

We've been digging for a while why our app suddenly stopped responding to the default custom URL scheme. According to the OutSystems docs the URL scheme should be set to the value specified in the App Identifier field under Module / Distribute / Native Platform / iOS.
When digging through the source code I found that this plugin actually sets that value in the iOSCopyPreferences.js hook. It fetches a JSON config (endpoint specified in the app's Extensibility Configurations) from the SocialLoginConfigurator and uses the value found under app_deeplink.url_scheme.
If I understand the code correct it looks like the hook replaces the existing array for the DeepLinkScheme (CFBundleURLName), with a new array instead of pushing the value onto the existing one.
Do you have any suggestions how to solve this issue without updating the source code of this plugin?

Hey @emilof.
Apologies for the late reply.
The latest 2.0.2 release already has this issue fixed. Please try it and, if it works, we can close the issue.
Best regards.


Upgraded golang/x/net to 0.24 to fix vuln

Per https://issues.redhat.com/browse/OSD-22347

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.25%. Comparing base (1a837c4) to head (1958f61).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   47.25%   47.25%
=======================================
  Files           9        9
  Lines         764      764
=======================================
  Hits          361      361
  Misses        354      354
  Partials       49       49

/retest

@npecka it's complaining about not having the latest ubi-minimal tag in its build/Dockerfile, in practice we need to bug people to get #179 merged (and wait for dependabot to create the next) I can chase down approvers.

/retest

/retest

/lgtm


Memory leak when switching version

steps
> cat build.sbt
crossScalaVersions := (0 to 6).map(i => s"2.10.$i") ++ (0 to 11).map(i => s"2.11.$i") ++ (0 to 2).map(i => s"2.12.$i")

> cat project/build.properties
sbt.version=0.13.15

> sbt crossScalaVersions +version

problem
In the beginning, sbt switches through versions quickly, but it gets slower and slower, and around 2.11.8 or 2.11.9 it's stuck.
I took a heap dump in YourKit. There's 422 MB (865 MB retained size) of scala.collection.immutable.::, I looked at a few objects, they seem to be lists of sbt.Init$Setting. There's 84 MB of sbt.Init$Setting (440 MB retained size).

expectation
notes
See also https://github.com/typesafehub/genjavadoc/pull/103

Thank you very much for the very minimised reproduction, @lrytz.

Btw, we've run into this problem (pretty sure it's this root cause) ourselves in sbt/zinc: https://github.com/sbt/zinc/commit/d5d59b6f4c563a5f9aa5d095295b93b912b90cf3.

Thank you for the report @lrytz. Indeed, I knew something was wrong here when we run into https://github.com/sbt/zinc/commit/d5d59b6f4c563a5f9aa5d095295b93b912b90cf3. I've also had several related issues locally, when abusing so from sbt-doge.
I'll have a look at this if someone doesn't beat me to it.

I ran into this recently as well. Most time seems to be spent in appending lists:

As a workaround we use reload between + commands, it seems to help. In my case I ran into the problem with 4 Scala versions already.

I'm happy to say that the inclusion of 1d0eda2e6a8aa04ca83b310b3612a57beaad553f solved this issue in sbt 1.0.0 (it brought sbt-doge implementation of cross version). I cannot reproduce neither in the sbt build nor scripted. I think we can label this as fixed in sbt 1.0.0. We cannot backport because of binary compatibility issues.

1d0eda2e6a8aa04ca83b310b3612a57beaad553f says "Add Windows script support and native file extensions on Unix platforms", so maybe another commit?

https://github.com/sbt/sbt/pull/2613


[Feature]  Add support for AS identifiers

echo "AS1449" |  mapcidr
mapcidr should accept the ASN number as input and then expand the IPs available for that ASN.

❯ echo AS14421 | mapcidr

                   ____________  ___
  __ _  ___ ____  / ___/  _/ _ \/ _ \
 /  ' \/ _ '/ _ \/ /___/ // // / , _/
/_/_/_/\_,_/ .__/\___/___/____/_/|_| v1.0.3-dev
          /_/

		projectdiscovery.io

Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>


Periodically run KF ready tests against auto deployments

Follow on to #42
We should setup a periodic test that runs the tests that the kubeflow applications were correctly deployed.

Getting a weird kubernetes client issue when running the tests.
self = <kubernetes.config.kube_config.KubeConfigLoader object at 0x7f12cc3197c0>

    def _refresh_gcp_token(self):
        if 'config' not in self._user['auth-provider']:
            self._user['auth-provider'].value['config'] = {}
        provider = self._user['auth-provider']['config']
        credentials = self._get_google_credentials()
        provider.value['access-token'] = credentials.token
        provider.value['expiry'] = format_rfc3339(credentials.expiry)
        if self._config_persister:
>           self._config_persister()
E           TypeError: _save_kube_config() missing 1 required positional argument: 'config_map'

/usr/local/lib/python3.8/dist-packages/kubernetes/config/kube_config.py:363: TypeError

Here's the full stacktrace
kf_is_ready_test.py:70: in check_deployments_ready
    util.load_kube_config()
/srcCache/kubeflow/testing/py/kubeflow/testing/util.py:814: in load_kube_config
    loader.load_and_set(config) # pylint: disable=too-many-function-args
/usr/local/lib/python3.8/dist-packages/kubernetes/config/kube_config.py:550: in load_and_set
    self._load_authentication()
/usr/local/lib/python3.8/dist-packages/kubernetes/config/kube_config.py:278: in _load_authentication
    if self._load_auth_provider_token():
/usr/local/lib/python3.8/dist-packages/kubernetes/config/kube_config.py:293: in _load_auth_provider_token
    return self._load_gcp_token(provider)
/usr/local/lib/python3.8/dist-packages/kubernetes/config/kube_config.py:350: in _load_gcp_token
    self._refresh_gcp_token()

It looks like the version of kubernetes lib in the container is "11.0.0" locally I have "9.0.0".

Dashboard:
https://k8s-testgrid.appspot.com/sig-big-data#kubeflow-gcp-blueprints-master-periodic
Tests are running regularly but some of the tests are failing.

@Bobgy The test is passing can we close this?
https://k8s-testgrid.appspot.com/sig-big-data#kubeflow-gcp-blueprints-master-periodic&group-by-hierarchy-pattern=[\w-]%2B

looks like kf_is_ready and metadata_is_ready tests are not passing yet, did you see them?

Or is this issue just for setting up the test, then I have no objection

/priority p2


[Extensibility Enhancements] OnInit Trigger of Request Page on Report 1305 "Standard Sales - Order Conf."

OnInit Trigger of RequestPage is not reachable in ReportExtension. We added parameter and there is no way where we can set default value of Field UploadToSharePoint to true
reportextension 50250 "DBH StandardSalesOrderConf" extends "Standard Sales - Order Conf."
{
requestpage
{
layout
{
addlast(content)
{
group(DBH)
{
Caption = 'DBH', Comment = 'DBH';
field(UploadToSharepointField; UploadToSharepoint)
{
Caption = 'Upload to Sharepoint';
ApplicationArea = Basic, Suite;
}
}
}
}
}

Please specify what do you need, probably event?

Hi Alexander,
Yes correct we need OnInit trigger of Request page to be reachable from ReportExtension (this will solve all reports at once)
or second posibility is:
We need one Event OnInit trigger where we can subscribe (this should be done than per report, and we have more to come)

BEFORE
trigger OnInit()
begin
LogInteractionEnable := true;
ArchiveDocument := SalesSetup."Archive Orders";
end;
AFTER
trigger OnInit()
begin
LogInteractionEnable := true;
ArchiveDocument := SalesSetup."Archive Orders";
OnInitRequestPage("Sales Header");
end;
[IntegrationEvent(false, false)]
local procedure OnInitRequestPage(var SalesHeader: Record "Sales Header")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

We added parameter and there is no way where we can set default value of Field UploadToSharePoint to true

Can't you just use requestpage => trigger OnOpenPage() ?

NO! we cannot, it is the same issue like with OnInitPage - it is not reachable outside of report

but if you are creating a report extension, in which that new variable/control is declared, you can in the same extension AL object add trigger onOpenPage() within the requestpage block, and access/set said variable/control

Thank you very much for the tip! It works with OnOpenPage()
OnInit() is not reachable and the name is OnInit() not OnInitPage()


Add wall-time profiles to ProfileEndpoints.jl

Through the HTTP endpoints:

/profile_wall
/profile_wall_start
/profile_wall_stop

Through the debug super-endpoint:

/debug_engine profile_type="wall_profile"
/debug_engine profile_type="wall_profile_start"
/debug_engine profile_type="wall_profile_stop"

Tagging @vustef for review.


Audit memory allocation

After letting a node sync the first 540k blocks:
761,473,422,968 bytes allocated in the heap
  63,238,559,440 bytes copied during GC
     128,763,248 bytes maximum residency (292 sample(s))
       3,529,360 bytes maximum slop
             122 MB total memory in use (0 MB lost due to fragmentation)
                                     Tot time (elapsed)  Avg pause  Max pause
  Gen  0     724781 colls,     0 par   730.289s  731.350s     0.0010s    0.0256s
  Gen  1       292 colls,     0 par   11.830s  11.962s     0.0410s    0.0940s
  TASKS: 7 (1 bound, 6 peak workers (6 total), using -N1)
  SPARKS: 0(0 converted, 0 overflowed, 0 dud, 0 GC'd, 0 fizzled)
  INIT    time    0.000s  (  0.000s elapsed)
  MUT     time  773.008s  (709.649s elapsed)
  GC      time  742.119s  (743.313s elapsed)
  EXIT    time    0.001s  (  0.009s elapsed)
  Total   time  1515.128s  (1452.970s elapsed)
  Alloc rate    985,078,173 bytes per MUT second
  Productivity  51.0% of total user, 48.8% of total elapsed

The productivity is low, but not dramatically low. We should do some allocation profiling to see whether we're not allocating too much at some places.

Related: #1420

I recently tried again and got the following after syncing the first 1,758,300 blocks:
3,602,638,107,880 bytes allocated in the heap
  70,881,748,848 bytes copied during GC
     504,668,016 bytes maximum residency (181 sample(s))
       8,258,336 bytes maximum slop
             481 MB total memory in use (0 MB lost due to fragmentation)

                                     Tot time (elapsed)  Avg pause  Max pause
  Gen  0     113573 colls, 113573 par   243.896s  153.133s     0.0013s    0.0365s
  Gen  1       181 colls,   180 par   31.907s  17.807s     0.0984s    0.2727s

  Parallel GC work balance: 64.05% (serial 0%, perfect 100%)

  TASKS: 16 (1 bound, 15 peak workers (15 total), using -N2)

  SPARKS: 0(0 converted, 0 overflowed, 0 dud, 0 GC'd, 0 fizzled)

  INIT    time    0.001s  (  0.001s elapsed)
  MUT     time  3281.462s  (2470.461s elapsed)
  GC      time  275.802s  (170.940s elapsed)
  EXIT    time    0.001s  (  0.009s elapsed)
  Total   time  3557.266s  (2641.411s elapsed)

  Alloc rate    1,097,876,082 bytes per MUT second

  Productivity  92.2% of total user, 93.5% of total elapsed

This is looking much better already.

Ok, I think this is looking very reasonable. Let's close this and reopen new tickets if we have specific concerns.


Please move linux bots to prod

This requires several steps:

[x] Copy bot config files from staging versions to prod. : cl in flight
[x] Move the bot names to the prod pool using the new bot configurations.
[x] Update the server in the salt configurations and reboot the machines
[ ] Remove the keys from staging salt master
[ ] Add the keys to the prod salt master.

Completed migration of linux-{1,2,3,4,7} to prod salt master.


fix select dropdown width

It was not the same as select when select itself had the floating-point width (Issue #6)

Thank you!

Welcome!) Could you please update it on npm?

Sure, just wanted to add minified dist/ folder to this release.

@nikolai-katkov done.


Add foggy filter to lessen color pop, especially around edges of the viewport

Currently:

Desired result:

https://godotshaders.com/shader/vignette-shader-for-godot-4/


Convert nix-gitignore from Docbook to CommonMark

This issue tracks the conversion of /doc/functions/nix-gitignore.xml from Docbook to CommonMark per RFC 72.
If you intend to work on this conversion, please comment below!
Conversion instructions

Comment here that you intend to work on it. (Please also post if you stop working on it.)
Checkout a new branch of nixpkgs master.
Edit /doc/functions.xml: change nix-gitignore.xml to nix-gitignore.section.xml.
Rename /doc/functions/nix-gitignore.xml to nix-gitignore.section.md.
Convert the contents from Docbook to CommonMark. Follow conversion best practices. Use existing .md sections for inspiration.
Use nix-build from the doc/ folder to build the manual.
Preview the manual on your computer at http://<IP_ADDRESS>:8000/manual.html after running from doc/ folder:

nix-shell -p python3 --run 'python3 -m http.server --directory ./result/share/doc/nixpkgs'

When it looks good, submit a PR and reference this issue.

I'll work on this!


Update "multiple schedulers" example

Description:
Update multiple scheduler deployment example to align with changes introduced via v1.22. Addresses https://github.com/kubernetes/website/issues/29342.
Test Environment:
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"darwin/arm64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.1", GitCommit:"632ed300f2c34f6d6d15ca4cef3d3c7073412212", GitTreeState:"clean", BuildDate:"2021-08-20T00:45:19Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"linux/amd64"}

Furthermore, used the default kube-scheduler image k8s.gcr.io/kube-scheduler:v1.22.0 for testing.

/assign @reylejano

@reylejano please find the suggestions integrated into the PR. Appreciate if this could be reviewed and approved.

@reylejano updated based on review comments. Please review and approve.

Thank you so much for the updates
/lgtm

/approve


detect and error about name-conflicts in namespace

One of the initial idea about concept of project is that they serve as the unique concept of namespace.
It's mean that public names MUST be unambiguous in a same project.
This proposed policy is a middle ground between the C and Java spec and tries to avoid the cons of both. Its big advantage is that the unambiguous vocabulary is simple (KISS) standard::Array is the only Array class of the standard library and standard::array is the only array-related module of standard.
(no scala.collection.immutable.Map madness)
Unfortunately, the rules are not yet enforced but the various tools takes them for granted, this causes unexpected issues when using bad programs.

To finish once #1250 is decided

closed by #1654