Multi-File operations should provide a overall progress

Would be great to have seperated function that will show the "Full-Progress" of DownloadDirectory and other functions that is related to downloading.
This library has specific implementation of Progress. But this Progress only show optimized progress when it downloads something.
The other function should be the same with a little exception, it should always calculate what does it do, file checking and everything related to it.
Would be great to see it.

The FtpProgress class contains many of the necessary properties etc. to handle the "Overall Progress" for mutil file operations.
Taking DownloadDirectory as an example, what needs to be done to provide progress?

Let's say the directory has 5 files, all of them nice and big.
You now implement a progress callback.
If you show just the "progress" it wil go from 0->n five times.
But the "FileIndex" property will increase 1, 2, 3, 4, 5.
So you if you would know the individual file sizes, you could calculate that "overall progress" in percent.

The FtpProgress class contains many of the necessary properties etc. to handle the "Overall Progress" for mutil file operations.
Taking DownloadDirectory as an example, what needs to be done to provide progress?

When we provide the progress to function with FullProgress it should in loop fire the IProgress every single time when something happended to a file, for example we checked the file, and we like it, we skip it, and after skipping we add += 1, to file count. When we do so, update the progress imidiately. Which should give us effect of file checking.

Whatever is done, it should all be stored in FtpProgress object. So the user can access the information and do with it what he likes.

Whatever is done, it should all be stored in FtpProgress object. So the user can access the information and do with it what he likes.

Yes, would be just perfect either provide specific class that will collect all events no matter what, or implement functions that will fire all of the time when something happened, not only when file was downloaded.

So not just bytes, files processed, but also "Downloading", "Checking", etc. etc. Need an enum of different actions.

So not just bytes, files processed, but also "Downloading", "Checking", etc. etc. Need an enum of different actions.

Here is the poor video that I made, it requires more logic but this was just the test.
This video shows on how exactly should it work.
I modified very little the main library to make it work, and it works by firing every single time when it checks or skips the file, and totally satisfies me. Only thing to change in here is the showing the amount of bytes to check, the Percentage Progress that checks the file and something more, sorry for not being clear enough.
https://youtu.be/edFIjycNvXg

I watched the video and it looks a lot cleaner now. What have you changed?

Author

In that video it fully showed the progress of downloading, it started from zero and always counted files it checked/downloaded before was ONLY firing the Progress when it was downloading in this video:
https://youtu.be/1JpgldcjjEA

I watched the video and it looks a lot cleaner now. What have you changed?

Well, it will require to apply this in all possible cases of downloading but here is the little snippet:
I copied this from the DownloadFileInternal.cs because that's the only way I saw to fire the progress.
	if (progress != null) {
		ReportProgress(progress, knownFileSize - restartPos, 0, 0, TimeSpan.Zero, localPath, remotePath, metaProgress);
	}

After inside of the DownloadFile.cs I paste the snippet on top to function DownloadFileToFileAsync because it was getting called from the AsyncFtpClass.DownloadDirectory
Full code of DownloadFile.cs:
using System;
using System.IO;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using FluentFTP.Streams;
using FluentFTP.Helpers;
using FluentFTP.Exceptions;
using FluentFTP.Client.Modules;
using System.Threading;
using System.Threading.Tasks;

namespace FluentFTP {
	public partial class AsyncFtpClient {

		/// <summary>
		/// Downloads the specified file onto the local file system asynchronously.
		/// High-level API that takes care of various edge cases internally.
		/// Supports very large files since it downloads data in chunks.
		/// </summary>
		/// <param name="localPath">The full or relative path to the file on the local file system</param>
		/// <param name="remotePath">The full or relative path to the file on the server</param>
		/// <param name="existsMode">Overwrite if you want the local file to be overwritten if it already exists. Append will also create a new file if it doesn't exists</param>
		/// <param name="verifyOptions">Sets if checksum verification is required for a successful download and what to do if it fails verification (See Remarks)</param>
		/// <param name="progress">Provide an implementation of IProgress to track download progress.</param>
		/// <param name="token">The token that can be used to cancel the entire process</param>
		/// <returns>FtpStatus flag indicating if the file was downloaded, skipped or failed to transfer.</returns>
		/// <remarks>
		/// If verification is enabled (All options other than <see cref="FtpVerify.None"/>) the hash will be checked against the server.  If the server does not support
		/// any hash algorithm, then verification is ignored.  If only <see cref="FtpVerify.OnlyChecksum"/> is set then the return of this method depends on both a successful
		/// upload & verification.  Additionally, if any verify option is set and a retry is attempted then overwrite will automatically be set to true for subsequent attempts.
		/// </remarks>
		public async Task<FtpStatus> DownloadFile(string localPath, string remotePath, FtpLocalExists existsMode = FtpLocalExists.Resume, FtpVerify verifyOptions = FtpVerify.None, IProgress<FtpProgress> progress = null, CancellationToken token = default(CancellationToken)) {
			// verify args
			if (localPath.IsBlank()) {
				throw new ArgumentException("Required parameter is null or blank.", nameof(localPath));
			}

			if (remotePath.IsBlank()) {
				throw new ArgumentException("Required parameter is null or blank.", nameof(remotePath));
			}

			return await DownloadFileToFileAsync(localPath, remotePath, existsMode, verifyOptions, progress, token, new FtpProgress(1, 0));
		}

		/// <summary>
		/// Download a remote file to a local file
		/// </summary>
		protected async Task<FtpStatus> DownloadFileToFileAsync(string localPath, string remotePath, FtpLocalExists existsMode, FtpVerify verifyOptions, IProgress<FtpProgress> progress, CancellationToken token, FtpProgress metaProgress) {

			// verify args
			if (localPath.IsBlank()) {
				throw new ArgumentException("Required parameter is null or blank.", nameof(localPath));
			}

			if (remotePath.IsBlank()) {
				throw new ArgumentException("Required parameter is null or blank.", nameof(remotePath));
			}

			// skip downloading if the localPath is a folder
			if (LocalPaths.IsLocalFolderPath(localPath)) {
				throw new ArgumentException("Local path must specify a file path and not a folder path.", nameof(localPath));
			}

			remotePath = remotePath.GetFtpPath();

			LogFunction(nameof(DownloadFile), new object[] { localPath, remotePath, existsMode, verifyOptions });

			bool isAppend = false;

			// skip downloading if the local file exists
			long knownFileSize = 0;
			long restartPos = 0;
#if NETSTANDARD || NET5_0_OR_GREATER
			if (existsMode == FtpLocalExists.Resume && await Task.Run(() => File.Exists(localPath), token)) {
				knownFileSize = (await GetFileSize(remotePath, -1, token));
				restartPos = await FtpFileStream.GetFileSizeAsync(localPath, false, token);
				if (knownFileSize.Equals(restartPos)) {
#else
			if (existsMode == FtpLocalExists.Resume && File.Exists(localPath)) {
				knownFileSize = (await GetFileSize(remotePath, -1, token));
				restartPos = FtpFileStream.GetFileSize(localPath, false);
				if (knownFileSize.Equals(restartPos)) {
#endif
					LogWithPrefix(FtpTraceLevel.Info, "Skipping file because Resume is enabled and file is fully downloaded (Remote: " + remotePath + ", Local: " + localPath + ")");
					if (progress != null) { // here is the poor implementation, we just reporting progress every single time when we skip, which is what I need.
						ReportProgress(progress, knownFileSize - restartPos, 0, 0, TimeSpan.Zero, localPath, remotePath, metaProgress);
					}

					return FtpStatus.Skipped;
				}
				else {
					isAppend = true;
				}
			}
#if NETSTANDARD || NET5_0_OR_GREATER
			else if (existsMode == FtpLocalExists.Skip && await Task.Run(() => File.Exists(localPath), token)) {
#else
			else if (existsMode == FtpLocalExists.Skip && File.Exists(localPath)) {
#endif
				LogWithPrefix(FtpTraceLevel.Info, "Skipping file because Skip is enabled and file already exists locally (Remote: " + remotePath + ", Local: " + localPath + ")");
				return FtpStatus.Skipped;
			}

			try {
				// create the folders
				var dirPath = Path.GetDirectoryName(localPath);
#if NETSTANDARD || NET5_0_OR_GREATER
				if (!string.IsNullOrWhiteSpace(dirPath) && !await Task.Run(() => Directory.Exists(dirPath), token)) {
#else
				if (!string.IsNullOrWhiteSpace(dirPath) && !Directory.Exists(dirPath)) {
#endif
					Directory.CreateDirectory(dirPath);
				}
			}
			catch (Exception ex1) {
				// catch errors creating directory
				throw new FtpException("Error while creating directories. See InnerException for more info.", ex1);
			}

			// if not appending then fetch remote file size since mode is determined by that
			/*if (knownFileSize == 0 && !isAppend) {
				knownFileSize = GetFileSize(remotePath);
			}*/

			bool downloadSuccess;
			var verified = true;
			var attemptsLeft = verifyOptions.HasFlag(FtpVerify.Retry) ? Config.RetryAttempts : 1;
			do {

				// download the file from the server to a file stream or memory stream
				downloadSuccess = await DownloadFileInternalAsync(localPath, remotePath, null, restartPos, progress, token, metaProgress, knownFileSize, isAppend, 0);
				attemptsLeft--;

				if (!downloadSuccess) {
					LogWithPrefix(FtpTraceLevel.Info, "Failed to download file.");

					if (attemptsLeft > 0)
						LogWithPrefix(FtpTraceLevel.Info, "Retrying to download file.");
				}

				// if verification is needed
				if (downloadSuccess && verifyOptions != FtpVerify.None) {
					verified = await VerifyTransferAsync(localPath, remotePath, token);
					LogWithPrefix(FtpTraceLevel.Info, "File Verification: " + (verified ? "PASS" : "FAIL"));
					if (!verified && attemptsLeft > 0) {
						LogWithPrefix(FtpTraceLevel.Verbose, "Retrying due to failed verification." + (existsMode == FtpLocalExists.Resume ? "  Overwrite will occur." : "") + "  " + attemptsLeft + " attempts remaining");
						// Force overwrite if a retry is required
						existsMode = FtpLocalExists.Overwrite;
					}
				}
			} while ((!downloadSuccess || !verified) && attemptsLeft > 0);

			if (downloadSuccess && !verified && verifyOptions.HasFlag(FtpVerify.Delete)) {
				File.Delete(localPath);
			}

			if (downloadSuccess && !verified && verifyOptions.HasFlag(FtpVerify.Throw)) {
				throw new FtpException("Downloaded file checksum value does not match remote file");
			}

			return downloadSuccess && verified ? FtpStatus.Success : FtpStatus.Failed;
		}

	}
}

So in summary, I want to just see every single time the Progress even if it was skipped.

I will continue tomorrow. Slawa Ukra...

I will continue tomorrow. Slawa Ukra...

Heroyam Slava, good night!

Well, your PR #1453 at least fixes the missing updates of the multi-file progress (filecount etc.) in cases where files are skipped.
It is a start towards more detailed reporting that would give you more than just numbers,  but also tell you more about "what" is currently happening.
In my own apps using FluentFTP, I have pursued this also - for me, a solution was to use progress and to monitor the detailed log messages which were telling me what the transfer was doing. A risky business in case log message texts would change (already happened to me a number of times).

I'm totally satisfied with this now, I think that's it 😄


fix(jasmine): propagate all arguments of it/describe/etc...

Travis failure looks legitimate, but also looks like it was caused by the previous commit.


Garry's Mod Crashes when trying to open Expression2 Files

Ever since the new GMod update, I keep on crashing when I try to open E2 files. Other people can open it, some people I know can't. I use a mac, but I'm not sure if that's the reason.

Are you using the Github version or the workshop one?

I tried using github and workshop version, none worked.

I have to ask because people these days... Did you disable/uninstall the workshop one before installing the Github one? It's needed because if you have both versions, it's the workshop one that is being loaded in Gmod.

yes.

Does the crash produce a .dmp file on your GarrysMod folder? We might be able to analyze it. In the meantime though, check your access permissions.

I can't find a .dmp file anywhere, and I only spent 10 minute in my gmod file looking for them. I'm pretty sure it's just I can't find them, because this is actually the first time I heard someone mention a .dmp file.

It's actually .mdmp

Ever since the new GMod update

That would be "Garry's fault".
@Chippyy Is it still crashing for you?


Help/Bug

Describe the bug
The bug consists of duplicating the Storage Actuator with the items inside
To Reproduce
Steps to reproduce the behavior:

Try placing the Storage Actuator next to a plot protected by the RedProtect Plugin (usually 2 edge blocks).
Note that it will drop 2 identical Storage Actuators

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Video
System (please complete the following information):

Occultism Version: 1.125.0
OS: Linux Host
Minecraft Version: 1.21.1
Modpack Link and Version, or list of mods: Curse

Additional context
This is a bit confusing, I don't know if the “error” is on the part of the mod or the plugin but I've contacted both, they're working on my server .-

I am not familiar with how well plugins deal with block drops, but I suspect it may be due to the storage actuator not using loot tables. I will look into changing that!

I will soon push a fix that will close this issue. If the problem remains, please ping me here to reopen it


Sentiment Analysis

In this project, I have analyzed the reviews of a women's clothing company. The data has been extracted from a CSV file.
Contribution under Python > Machine Learning.
Kindly review this PR.
Issue number: #101

@deepeshaburse your Readme.md file is not upto the mark.

details you have added are looks right just add additional sections into it.
just make the changes that add additional sections which are mentioned in the #43  for a good PR.

Points 3 and 5 were not relevant to this project hence, I did not add them. Kindly review it again.

@deepeshaburse its amazing for making user to attract towards your project then add some screenshots(5 to 8) in your Readme.md file. just make these small changes then we are good to merge.
for refrence you can watch : #23 thats attract user towards your project.

Changes made. Kindly review the README.md now.


Can't find variable yml file in V 2.5.0

We have two repositories such as reusable workflow actions which is called workflow, and another repository is the end user which is
caller workflow.
We have used<EMAIL_ADDRESS>latest 2.5.0 version in our workflows and facing below issue where variable.yml is unable to identify the path.
we have placed under .github/variables//variables.yml

Could you please help in resolving this issue.
Note: Please treat this issue at highest priority.

We have two repositories such as reusable workflow actions which is called workflow, and another repository is the end user which is caller workflow. We have used<EMAIL_ADDRESS>latest 2.5.0 version in our workflows and facing below issue where variable.yml is unable to identify the path.
we have placed under .github/variables//variables.yml

Could you please help in resolving this issue.
Note: Please treat this issue at highest priority.

Can anyone please provide a resolution to this issue

It looks like a simple bug, I missed passing the ref into the call to retrieve the file list here: https://github.com/lindluni/actions-variable-groups/blob/a09ab106947f24ac43c42b303738eb90977cf714/index.js#L41
I’ll publish a v2.5.1 to address this in the morning.
Thank you for the report!

It looks like a simple bug, I missed passing the ref into the call to retrieve the file list here:
https://github.com/lindluni/actions-variable-groups/blob/a09ab106947f24ac43c42b303738eb90977cf714/index.js#L41
I’ll publish a v2.5.1 to address this in the morning.
Thank you for the report!

Any update on the new deployment fix

@lindluni  -  Any update on the above fix

@lindluni   -  Hi Brett , could you please treat this request at highest priority as we are dependent on these actions and currently its impacting our deliverables.

I just published v3.0.0 or v3 that should fix this

@Anoop-P-Hegde
Were you able to confirm if this fixed your issue?

@Anoop-P-Hegde
Were you able to confirm if this fixed your issue?

@lindluni  -  Thanks for the quick turnaround. Let me test in our actual project workflow and confirm.

@lindluni  -  I tried using v3.0.0 in our workflow and still facing the same issue. Below is the screenshot attached for reference.

Could you please suggest some workaround for the above outstanding issue.?

@lindluni   -   Is it feasible to have some teams call/ troubleshooting session  in order to fix this problem'


chore(master): release 0.10.0

:robot: I have created a release beep boop
0.10.0 (2024-04-22)
Features

updating from newer svd2rust (#74) (ba2c1bb)

Bug Fixes

deps: update rust crate cortex-m-rt to 0.7.4 (#76) (03ef9c0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/xmc-rs/xmc4300/releases/tag/v0.10.0 :sunflower:


[<IP_ADDRESS>] A tag key that is the same as a field key cannot be queried directly

If points are written to a measurement with a tag key and field key that are equal, the points with the tag key are not returned in query results when the tag key is included in any WHERE clause conditional using the equals (=) or regex (=~) operators.
$ influx
Connected to http://localhost:8086 version <IP_ADDRESS>
InfluxDB shell <IP_ADDRESS>
> create database test
> use test
Using database test
> format json
> insert cpu,missing=tag missing="field",value=1
> select * from cpu
{"results":[{"series":[{"name":"cpu","columns":["time","missing","value"],"values":[["2015-10-31T00:29:33.041336768Z","field",1]]}]}]}
> select * from cpu where missing = 'tag'
{"results":[{}]}
> select * from cpu where missing =~ /tag/
{"results":[{}]}
> select * from cpu where missing = 'field'
{"results":[{"series":[{"name":"cpu","columns":["time","missing","value"],"values":[["2015-10-31T00:29:33.041336768Z","field",1]]}]}]}

This could be fixed by either addressing issue https://github.com/influxdb/influxdb/issues/2615 or adding the field key renaming feature described in https://github.com/influxdb/influxdb/issues/4156.

Closing this in favor of #6519.

can somebody help me with this issue , i am not able to get this work.?
InfluxDB version: 1.5.4
SHOW FIELD KEY
name: testcase_point
fieldKey           fieldType

build_number       integer
project_name       string
project_path       string
rf_critical_failed float
rf_critical_passed float
rf_duration        float
rf_failed          float
rf_name            string
rf_passed          float
rf_suite_name      string

SHOW TAG KEY
name: testcase_point
tagKey
project_name
rf_name
so basically the filed and tag key name are same , so i am not able to get the below query work
show tag values from "testcase_point" with key in ("rf_name")  WHERE "project_name" = "Altiplano_AC_SystemTest"
actually WHERE CLAUSE is not working here it always returns the same set of series irrespective of WHERE clause.
Thanks in advance||


[REQUEST] Full mod for newer minecraft versions

Will the full mod with proxy capability release for newer minecraft versions?

Sorry, I am not sure what you mean. The HMC-Specifics already released for the latest Minecraft version (1.20.1). If you mean HeadlessMc, it is not a mod but a launcher which can launch any of the newer minecraft versions.

My bad, i totally fumbled the repositories when creating the issue. But in short after following the tutorial on the earthhack to setup HeadlessMc, the proxy doesnt seem to work (1.19.4). But i already managed to find another solution so thx anyway :)


pycon/static/less/responseive-site.less mixes tabs and spaces

They are mixed pretty much at random (as far as I can tell), I suspect other less files are also effected.

As that file no longer exists in the new site design, I am going to go ahead and close this issue.


Hi there, I'm missing some shiet

SOOOOOOO, we all know that brainfuck is grand-touring-complete. BUTTTTT
What if I wanna print hello world? How do I do it?
SoRrY fOr My BaD EnGlIsH aNd PrOgRaMmInG sKiLlZ,
but I spent all my points in upgrading the rickroll meme statz.
Steve Jobs died of LIGMA. WHO IS STEVE JOBS? LIGMA 3D rendered SPHERE in rust

To print anything in brainfuck, you'll need to put special values in a cell and then output them using the (.) 'dot' operator. The specific values depend on wich characters you want to print. To see all of them, have a look at the ASCII table. I'll also leave you a link to the wikipedia page about brainfuck. It contains the following hello world example program:
[ This program prints "Hello World!" and a newline to the screen; its
  length is 106 active command characters. [It is not the shortest.]

  This loop is an "initial comment loop", a simple way of adding a comment
  to a BF program such that you don't have to worry about any command
  characters. Any ".", ",", "+", "-", "<" and ">" characters are simply
  ignored, the "[" and "]" characters just have to be balanced. This
  loop and the commands it contains are ignored because the current cell
  defaults to a value of 0; the 0 value causes this loop to be skipped.
]
++++++++                Set Cell #0 to 8
[
    >++++               Add 4 to Cell #1; this will always set Cell #1 to 4
    [                   as the cell will be cleared by the loop
        >++             Add 2 to Cell #2
        >+++            Add 3 to Cell #3
        >+++            Add 3 to Cell #4
        >+              Add 1 to Cell #5
        <<<<-           Decrement the loop counter in Cell #1
    ]                   Loop until Cell #1 is zero; number of iterations is 4
    >+                  Add 1 to Cell #2
    >+                  Add 1 to Cell #3
    >-                  Subtract 1 from Cell #4
    >>+                 Add 1 to Cell #6
    [<]                 Move back to the first zero cell you find; this will
                        be Cell #1 which was cleared by the previous loop
    <-                  Decrement the loop Counter in Cell #0
]                       Loop until Cell #0 is zero; number of iterations is 8

The result of this is:
Cell no :   0   1   2   3   4   5   6
Contents:   0   0  72 104  88  32   8
Pointer :   ^

>>.                     Cell #2 has value 72 which is 'H'
>---.                   Subtract 3 from Cell #3 to get 101 which is 'e'
+++++++..+++.           Likewise for 'llo' from Cell #3
>>.                     Cell #5 is 32 for the space
<-.                     Subtract 1 from Cell #4 for 87 to give a 'W'
<.                      Cell #3 was set to 'o' from the end of 'Hello'
+++.------.--------.    Cell #3 for 'rl' and 'd'
>>+.                    Add 1 to Cell #5 gives us an exclamation point
>++.                    And finally a newline from Cell #6


proposal: slices: implement common utility functions for cardinality, transformation, filtering and venn operations

Proposal Details
Description
This proposal enhances the slices package(slices/slices.go) by adding the essential functions around cardinality, transformation, filtering and venn operations which are as follows.

Cardinality: This is used to get the number of occurrences of the given element in the provided slice.
CardinalityFunc: This is used to get the number of occurrences of the element satisfying the function in the provided slice.
CardinalityMap: This is used to get a Map mapping each unique element in the given slice to an Integer representing the number of occurrences of that element in the slice.
Transform: This is used to transform all elements of the input slice by the given transformer.
Filter: This is used to filter the slice with elements that satisfy the predicate.
Disjunction: This is used to get a slice containing the exclusive disjunction (symmetric difference) of the given slices. This means the elements which are in either one of the slice but not in both.
Intersection: This is used to get a slice containing the intersection of the given slices. This means the elements which are in both the given slices.
Union: This is used to do the union of the 2 provided collections. The cardinality of each element in the returned collection will be equal to the maximum of that element in the given 2 collections.
Subtract: This is used to get a new slice containing s1 - s2 i.e. all elements of s2 removed from s1.

Motivation
These new functions added, are the common functions available in a lot of languages like Java, Python, etc in their standard packages, and are used very commonly in Go based applications, though implemented repeatedly everywhere. Including these functions in the Go standard slices package, provides robustness and reliability around such use cases.
Design
The functions will be added to the existing slices package, ensuring they are easy to use and can be integrated seamlessly. Each of these functions will handle for nil or empty slices, instead of a panic in such scenarios.
Examples

Cardinality:

a := []int{1,2,3,2,1}
count := slices.Cardinality(a, 2)   // 2 is the result

CardinalityFunc:

a := []int{1,2,3,2,1}
f := func(a int) bool { return a == 2 }
count := slices.CardinalityFunc(a, f)   // 2 is the result

CardinalityMap:

a := []int{1,2,3,2,1}
m := slices.CardinalityMap(a)   // {1: 2, 2: 2, 3: 1} is the result

Transform:

a := []int{1,2,3,2,1}
t := func(a int) string { return fmt.Sprintf("%d", a) }
b := slices.Transform(a, t) // ["1", "2", "3", "2", "1"] is the result

Filter:

a := []int{1,2,3,2,1}
f := func(a int, i int) { return a == 1 || i > 2 }
b := slices.Filter(a, f)    // [1, 2, 1] is the result

Disjunction:

a := []int{1,2,1,3,1,2}
b := []int{1,2,2,3}
c := slices.Disjunction(a, b)   // [1, 1] is the result

Intersection:

a := []int{1,2,1,3,1,2}
b := []int{1,2,2,3}
c := slices.Intersection(a, b)   // [1, 2, 3, 2] is the result

Union:

a := []int{1,2,1,3,1,2}
b := []int{1,2,2,3}
c := slices.Union(a, b)   // [1, 2, 1, 3, 1, 2] is the result

Subtract:

a := []int{1,2,1,3,1,2}
b := []int{1,2,2,3}
c := slices.Subtract(a, b)   // [1, 1] is the result

Related Issues and Documentation

slices: implement common utility functions for cardinality, transformation, filtering and venn operations #69467
proposal: slices: Add functions `Map` and `Filter` #68065 (closed)
slices: new package to provide generic slice functions #45955 (closed)
proposal: slices: Add Intersect and IntersectFunc #64539
proposal: affected/package: slices #61252 (closed)
proposal: slices: add difference function #58730 (closed)
slices: new standard library package based on x/exp/slices #57433 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Cardinality, Disjunction, Intersection, Union, Subtract belong in the container/set proposal: https://github.com/golang/go/issues/69230
Transform, Filter in the x/exp/xiter proposal: https://github.com/golang/go/issues/61898


Create a graphical weather app that fetches and displays current weather conditions.

Please assign this issue to me and add a hactoberfest label to it.

@Anujjoshi021 You have been assigned the issue.
You can start working on it


Adding 18.09 as UCP/DTR compatible engine version

Proposed changes

Adding 18.09 as UCP/DTR compatible engine version under the 18.03 release notes
18.03 is not compatible with any version UCP or DTR. With the release of EE 2.1, UCP and DTR can be deployed not only with 17.06, but 18.09 as well. Linking to compatibility matrix for additional clarification.

Deploy preview for docsdocker ready!
Built with commit f9c08b98611d754bd0552968ad69bac8a2db134b
https://deploy-preview-7926--docsdocker.netlify.com


Readme and solution for The Twelve Days of Xmas problem added

Readme and solution for The Twelve Days of Xmas problem added, and tag modified

The test file is just output to stout. I do not know much about unit testing in C++, but at least some asserts with the expected output would be nice. Please read a bit about unit testing and fix your test file.

Hi @Meyito, thanks for the contribution!
As @dalleng points out, it's preferable to check the output of an algorithm against a predefined, expected output value. A pattern such as:
expected_output = {1, 2, 3}

assert(my_algorithm() == expected_output)

The problem with printing to stdout is that it leaves the check for correctness up to visual inspection by the user, and a human user is more likely to make a mistake than an assert() statement.
Here are some unit tests, in C, if you'd like a starting point: https://github.com/kennyledet/Algorithm-Implementations/blob/193947fb7bb027f6c4e8a333851d5e4c54462abc/Stat_Mode/C/PatrickYevsukov/stat_mode_test.c

seems like Kennyledet is not active and most of the PRs are still on hold.
I'm maintaining the fork at https://github.com/pravsingh/Algorithm-Implementations. Please do send the PRs to this fork.
lets continue with the mission Kennyledet started with.


should be peak picking a method of common-spectrum or method specific?

I started working a bit on the peak picking (https://github.com/kjappelbaum/xrd-analysis) but it seems to me that the code is not really dependent on the specific spectrum type (except for the peak shape). Maybe this should then be moved to common-spectrum?
What do you think @lpatiny ?

Maybe but for some spectra (like TGA) you can not make peak picking (except after derivative).
This is why I didn't put it there. But it is through that it could be in common spectrum and we don't need to export it in tga-spectrum for example. We can also when we reexport this method defined default parameter.
You may put it in common-spectrum.


No Error Information if no LED Type specified

Config -> Driver -> Basic -> LED Type. If not specified, the system gives no indication as to an error or the using of some unspecified default LED type

Disallowed selecting nothing


Update check

Update check using built-in HttpClient, includes a "CheckForUpdates" variable in the config, resolves #7.
No added dependencies.
Thanks to @SloopyNoSleep for reminding me I was overcomplicating things :D

LGTM


Made Quick Capture under a heading in a note

Hi,
Thanks to the developer who made this plugin, but can I add content under a heading in the note I select?

The current functionality allows you to do that. You provide the title and the content. The content is added below the heading. You can even use markdown in the Enter note content box.
Are you looking for something else?

Yes, I did try that but nothing shows in the note I choose from the dropdown menu. But, it does work when I create the new note and add the content underneath. I don't know what I am doing wrong.

Can you please share a video if possible.
On Sun, 7 May 2023, 03:16 Feranmi-Star90, @.***> wrote:

Yes, I did try that but nothing shows in the note I choose from the
dropdown menu. But, it does work when I create the new note and add the
content underneath. I don't know what I am doing wrong.
—
Reply to this email directly, view it on GitHub
https://github.com/tmfelwu/obsidian-inbox/issues/1#issuecomment-1537228868,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBIHL5LBERMOVZNLNYRUFTXE3BEFANCNFSM6AAAAAAXYIOQZA
.
You are receiving this because you commented.Message ID:
@.***>

I apologise for been so late in replying, but this is the issue I have been having:
https://github.com/tmfelwu/obsidian-inbox/assets/79968557/b756a990-0630-4df1-9794-4431461129d1

Right this functionality is not implemented yet. If a not exists it just
helps navigating to that note. What could be other alternative?

Add at the end of the note?
Add at the beginning of the note?

And provide a setting to seitch between the two.
Can you think of something else?
On Wed, 10 May 2023, 02:34 Feranmi-Star90, @.***> wrote:

I apologise for been so late in replying, but this is the issue I have
been having:
https://github.com/tmfelwu/obsidian-inbox/assets/79968557/b756a990-0630-4df1-9794-4431461129d1
—
Reply to this email directly, view it on GitHub
https://github.com/tmfelwu/obsidian-inbox/issues/1#issuecomment-1540888195,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBIHL4EFVK5QSP3WLIGSTLXFKWODANCNFSM6AAAAAAXYIOQZA
.
You are receiving this because you commented.Message ID:
@.***>


release?

Sorry if this is not the right way to go about asking, but could I ask you to please tag a release version?

Just for completeness and because the issue has been open for a long time.  I wanted to record that a release has been made to the go-fastly client and this is v0.4.3.  A number of pieces that were present on master have now been record in the CHANGELOG.md
https://github.com/fastly/go-fastly/releases


ClassCastException during REPL execution

Compiler version
3.4.1
Minimized code
It is important to apply each of the definitions/expressions one by one, otherwise the exception is not reproducible.
scala> def g1(acc: Int)(h: (Int, Int) => Int): Int = h(acc, acc)
// def g1(acc: Int)(h: (Int, Int) => Int): Int

scala> def g2(acc: Int)(h: (=> Int, => Int) => Int): Int = h(acc, acc)
// def g2(acc: => Int)(h: (=> Int, => Int) => Int): Int

scala> g2(1)(_ + _)
// java.lang.ClassCastException: class java.lang.Integer cannot be cast to class scala.Function0 (java.lang.Integer is in module
// java.base of loader 'bootstrap'; scala.Function0 is in unnamed module of loader java.net.URLClassLoader @49798e84)
//   at scala.Function2.apply$mcIII$sp(Function2.scala:40)
//   at rs$line$2$.g2(rs$line$2:1)
//   ... 35 elided

Expectation
The result should be 2, instead of a ClassCastException being thrown.
Related IntelliJ IDEA ticket: https://youtrack.jetbrains.com/issue/SCL-22382/ClassNotFoundException-when-running-a-Scala-3-worksheet

otherwise the exception is not reproducible.

oh man, hate it when that happens.

Fixed in nightly builds by https://github.com/scala/scala3/pull/19983


If body length is 0(only have header), then it's will fall into a dead loop.

It will invoke onSocketWriteResponse heaps of times.

I can't reproduce the problem ,as follow the pic

You need check your data which returned by the server.The head of data is correct.

onSocketWriteResponse method will invoked once when you call send function.

You can download the demo apps for study how to use it to communicate with your server

@Jack-SunQi You mean you got a empty header? How could that happen.would you tell me the step of your issues reproducing exactly?

在Reader.java文件的read()方法，如果服务端关闭了socket，mInputStream.read()会读取到-1，但是现在并没有对-1进行处理，所以socket读取会进入死循环。

测试方法就是，服务器直接close socket，客户端这边就死循环了。


Add brawler unlocks to /progession

Could add Brawler unlocks as an extra category (only visible when not 100%) and Credit deficit to Resources.

Addressing with dev branch (26d2bba6edce498a679c65c2fd6c9dd118c1f8aa)


SPARKC-90 Error Out on Unknown Environment Vars

Does it also suggest if I forget a whole word in the property name, e.g "spark.cassandra.output.batch.rows" instead of "spark.cassandra.output.batch.size.rows" ?

Changed naming, decided that the exception would take a list of invalid properties and a map to possible suggestion

+1

I fixed those minor code style issues and rebased.


feat: query policydefinition, contractdefinition via privateProperties

What this PR changes/adds
Search policydefinition, contractdefinition via privateProperties
Why it does that
PrivateProperties are stored in policydefinition, contractdefinition as json values. It is necessary to support search/query function via these stored json values.
Linked Issue(s)
Closes # <-- https://github.com/eclipse-edc/Connector/issues/3623

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (924a977) 71.72% compared to head (40a5981) 71.74%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3691      +/-   ##
==========================================
+ Coverage   71.72%   71.74%   +0.01%
==========================================
  Files         919      919
  Lines       18447    18455       +8
  Branches     1034     1036       +2
==========================================
+ Hits        13232    13240       +8
  Misses       4756     4756
  Partials      459      459

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

can label be assigned to this PR?. Apart from that PR is ready. Unit test, endtoend tests are there for query.

can label assigned to this PR? Also request to review and merge it sooner. I would like to contribute feature, related to sorting by privateProperties too after this is merged.

@jimmarino Please check it

@jimmarino Please check it

Check what? If you want me to re-review the PR, please resolve the open issues and re-request the review.

I already resolved last 4 review comments you have given. @ndr-brt approved PR. If all ok for you, please approve.

Please resolve the outstanding conversations and I will take another look.

Please resolve the outstanding conversations and I will take another look.

Please resolve the outstanding conversations and I will take another look.

resolved.


Update README.md

Modification README file.
notice detailed ways on how contributer can contribute our Open Source.

It's perfect. I think it's easier for a contributor to contribute


Unable to see sort by in Dark mode.

I was unable to use the sort function on tasks due to bad colour choices.
----To copy issue {steps}:-

Change to dark mode
Add task
click on sort by in tasks.

https://github.com/Kritika30032002/To-Do-List-Application/pull/240


can not install

Your environment.

Version: *Linux 5.3.0-45-generic #37-Ubuntu SMP Thu Mar 26 20:41:27 UTC 2020 x86_64 x86_64 x86_64 GNU/Li
go version go1.14 linux/amd64

Browser: include version
Other Information - *go: github.com/pion/webrtc upgrade => v1.2.0
go get<EMAIL_ADDRESS>parsing go.mod:
module declares its path as: github.com/pions/webrtc
but was required as: github.com/pion/webrtc

What did you do?

go get github.com/pion/webrtc
What did you expect?
package to be installed
What happened?
go: github.com/pion/webrtc upgrade => v1.2.0
go get<EMAIL_ADDRESS>parsing go.mod:
module declares its path as: github.com/pions/webrtc
but was required as: github.com/pion/webrtc

You probably want v2.

So try go get github.com/pion/webrtc/v2

could you please ad it into documentation


使用官方BaiduCN1.2k Model和Mandarin LM Small搭建语音识别报错

修改test.py并运行提示：
TensorRT dynamic library (libnvinfer.so) that Paddle depends on is not configured correctly. (error code is libnvinfer.so: cannot open shared object file: No such file or directory)
  Suggestions:
  1. Check if TensorRT is installed correctly and its version is matched with paddlepaddle you installed.
  2. Configure TensorRT dynamic library environment variables as follows:
  - Linux: set LD_LIBRARY_PATH by `export LD_LIBRARY_PATH=...`
  - Windows: set PATH by `set PATH=XXX;-----------  Configuration Arguments -----------
alpha: 2.5
batch_size: 32
beam_size: 500
beta: 0.3
cutoff_prob: 0.99
cutoff_top_n: 40
decoding_method: ctc_beam_search
error_rate_type: CER
lang_model_path: models/lm/zh_giga.no_cna_cmn.prune01244.klm
mean_std_path: models/baidu_ch1.2k/mean_std.npz
model_path: /home/mocai/Graduation/DeepSpeech/models/aishell
num_conv_layers: 2
num_proc_bsearch: 8
num_rnn_layers: 3
rnn_layer_size: 2048
share_rnn_weights: False
specgram_type: linear
test_manifest: /home/mocai/Graduation/DeepSpeech/data/aishell/manifest.test
use_gpu: True
use_gru: True
vocab_path: models/baidu_ch1.2k/vocab.txt
------------------------------------------------
[INFO 2021-01-13 19:20:17,509 model.py:474] begin to initialize the external scorer for decoding
[INFO 2021-01-13 19:20:17,587 model.py:484] language model: is_character_based = 1, max_order = 5, dict_size = 0
[INFO 2021-01-13 19:20:17,587 model.py:485] end initializing scorer
[INFO 2021-01-13 19:20:17,587 test.py:115] start evaluation ...
W0113 19:20:17.922132 20528 device_context.cc:252] Please NOTE: device: 0, CUDA Capability: 75, Driver API Version: 11.1, Runtime API Version: 10.0
W0113 19:20:17.924199 20528 device_context.cc:260] device: 0, cuDNN Version: 7.6.
Traceback (most recent call last):
  File "test.py", line 155, in <module>
    main()
  File "test.py", line 151, in main
    evaluate()
  File "test.py", line 119, in evaluate
    feeding_dict=data_generator.feeding)
  File "/home/mocai/Graduation/DeepSpeech/model_utils/model.py", line 411, in infer_batch_probs
    self.init_from_pretrained_model(exe, infer_program)
  File "/home/mocai/Graduation/DeepSpeech/model_utils/model.py", line 161, in init_from_pretrained_model
    filename="params.pdparams")
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/io.py", line 877, in load_params
    filename=filename)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/io.py", line 751, in load_vars
    filename=filename)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/io.py", line 820, in load_vars
    format(orig_shape, each_var.name, new_shape))
RuntimeError: Variable's shape does not match, the Program requires a parameter with the shape of ((6144L,)), while the loaded parameter (namely [ layer_2_forward_batch_norm_moving_mean ]) has a shape of  ((3072,)).

然后我的TensorRT也安装好了并且导入到LD_LIBARARY_PATH内了

TensorRT dynamic library (libnvinfer.so) that Paddle depends on is not configured correctly. (error code is libnvinfer.so: cannot open shared object file: No such file or directory)
  Suggestions:
  1. Check if TensorRT is installed correctly and its version is matched with paddlepaddle you installed.
  2. Configure TensorRT dynamic library environment variables as follows:
  - Linux: set LD_LIBRARY_PATH by `export LD_LIBRARY_PATH=...`
  - Windows: set PATH by `set PATH=XXX;-----------  Configuration Arguments -----------
alpha: 2.5
batch_size: 32
beam_size: 500
beta: 0.3
cutoff_prob: 0.99
cutoff_top_n: 40
decoding_method: ctc_beam_search
error_rate_type: CER
lang_model_path: /home/mocai/Graduation/DeepSpeech/models/lm/zh_giga.no_cna_cmn.prune01244.klm
mean_std_path: /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k/mean_std.npz
model_path: /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k
num_conv_layers: 2
num_proc_bsearch: 8
num_rnn_layers: 3
rnn_layer_size: 2048
share_rnn_weights: False
specgram_type: linear
test_manifest: /home/mocai/Graduation/DeepSpeech/data/aishell/manifest.test
use_gpu: True
use_gru: True
vocab_path: /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k/vocab.txt
------------------------------------------------
[INFO 2021-01-13 19:33:06,033 model.py:474] begin to initialize the external scorer for decoding
[INFO 2021-01-13 19:33:06,112 model.py:484] language model: is_character_based = 1, max_order = 5, dict_size = 0
[INFO 2021-01-13 19:33:06,112 model.py:485] end initializing scorer
[INFO 2021-01-13 19:33:06,112 test.py:115] start evaluation ...
W0113 19:33:06.465489 21373 device_context.cc:252] Please NOTE: device: 0, CUDA Capability: 75, Driver API Version: 11.1, Runtime API Version: 10.0
W0113 19:33:06.467573 21373 device_context.cc:260] device: 0, cuDNN Version: 7.6.
finish initing model from pretrained params from /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k
Error rate [CER] (32/?) = 1.000000
finish initing model from pretrained params from /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k
^CTraceback (most recent call last):
  File "test.py", line 155, in <module>
    main()
  File "test.py", line 151, in main
    evaluate()
  File "test.py", line 119, in evaluate
    feeding_dict=data_generator.feeding)
  File "/home/mocai/Graduation/DeepSpeech/model_utils/model.py", line 423, in infer_batch_probs
    return_numpy=False)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1066, in run
    return_merged=return_merged)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1154, in _run_impl
    use_program_cache=use_program_cache)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1224, in _run_program
    fetch_var_name=fetch_var_name)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 609, in _add_feed_fetch_ops
    attrs={'col': i})
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 2679, in _prepend_op
    attrs=kwargs.get("attrs", None))
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 1829, in __init__
    if in_dygraph_mode():
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 200, in in_dygraph_mode
    return _dygraph_tracer_ is not None
KeyboardInterrupt

TensorRT dynamic library (libnvinfer.so) that Paddle depends on is not configured correctly. (error code is libnvinfer.so: cannot open shared object file: No such file or directory)
  Suggestions:
  1. Check if TensorRT is installed correctly and its version is matched with paddlepaddle you installed.
  2. Configure TensorRT dynamic library environment variables as follows:
  - Linux: set LD_LIBRARY_PATH by `export LD_LIBRARY_PATH=...`
  - Windows: set PATH by `set PATH=XXX;-----------  Configuration Arguments -----------
alpha: 2.5
batch_size: 32
beam_size: 500
beta: 0.3
cutoff_prob: 0.99
cutoff_top_n: 40
decoding_method: ctc_beam_search
error_rate_type: CER
lang_model_path: /home/mocai/Graduation/DeepSpeech/models/lm/zh_giga.no_cna_cmn.prune01244.klm
mean_std_path: /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k/mean_std.npz
model_path: /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k
num_conv_layers: 2
num_proc_bsearch: 8
num_rnn_layers: 3
rnn_layer_size: 2048
share_rnn_weights: False
specgram_type: linear
test_manifest: /home/mocai/Graduation/DeepSpeech/data/aishell/manifest.test
use_gpu: True
use_gru: True
vocab_path: /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k/vocab.txt
------------------------------------------------
[INFO 2021-01-13 19:33:06,033 model.py:474] begin to initialize the external scorer for decoding
[INFO 2021-01-13 19:33:06,112 model.py:484] language model: is_character_based = 1, max_order = 5, dict_size = 0
[INFO 2021-01-13 19:33:06,112 model.py:485] end initializing scorer
[INFO 2021-01-13 19:33:06,112 test.py:115] start evaluation ...
W0113 19:33:06.465489 21373 device_context.cc:252] Please NOTE: device: 0, CUDA Capability: 75, Driver API Version: 11.1, Runtime API Version: 10.0
W0113 19:33:06.467573 21373 device_context.cc:260] device: 0, cuDNN Version: 7.6.
finish initing model from pretrained params from /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k
Error rate [CER] (32/?) = 1.000000
finish initing model from pretrained params from /home/mocai/Graduation/DeepSpeech/models/baidu_ch1.2k
^CTraceback (most recent call last):
  File "test.py", line 155, in <module>
    main()
  File "test.py", line 151, in main
    evaluate()
  File "test.py", line 119, in evaluate
    feeding_dict=data_generator.feeding)
  File "/home/mocai/Graduation/DeepSpeech/model_utils/model.py", line 423, in infer_batch_probs
    return_numpy=False)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1066, in run
    return_merged=return_merged)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1154, in _run_impl
    use_program_cache=use_program_cache)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1224, in _run_program
    fetch_var_name=fetch_var_name)
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 609, in _add_feed_fetch_ops
    attrs={'col': i})
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 2679, in _prepend_op
    attrs=kwargs.get("attrs", None))
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 1829, in __init__
    if in_dygraph_mode():
  File "/home/mocai/.local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 200, in in_dygraph_mode
    return _dygraph_tracer_ is not None
KeyboardInterrupt

模型和配置不匹配。


echomsg requires a string, while echo does not

While :echo {} works, :echom {} fails with E731: using Dictionary as a String.
For prototyping and in general it would be nice if this would be consistent, i.e. :echom {} should work, and not require to use :echom string({}).

Fixed in https://github.com/vim/vim/commit/461a7fcfce3cd6414f990037e6468af3b5ccf119.
Thank you very much!


Could you please  provide more detailed for the bitstream and more details on BMac architecture?

Hello,
Thank you so much for your interesting work.
I am particularly interested in the implementation details of the BMac architecture in OpenNIC. Would it be possible for you to provide more detailed information on the bitstream and the BMac architecture implemented on OpenNIC through the Alveo platform?
Thank you for your time and consideration.
I look forward to hearing back from you soon.

@manwu1994 As discussed in our email conversation, here are the links with further information on OpenNIC and BMac implementation:
https://www.computer.org/csdl/proceedings-article/icdcs/2022/717700a258/1HriXBXbVUk
https://arxiv.org/pdf/2104.06968.pdf


fix(keyvalue-nats): README link keys lowercase

Feature or Problem
Fixes the keyvalue-nats provider noting that configuration values are uppercase, when in fact the code expects lowercase and does not make them case insensitive.
Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

I don't want to block minor doc fix on this but this provider needs some additional TLC. Filed #3346 and #3347 for follow-up.


Update GitHub Issue Classification to v 1.0.0-preview

Update GitHub Issue Classification to v 1.0.0-preview
Interal Review URL
Related Code Sample
Fixes https://github.com/dotnet/docs/issues/12082, https://github.com/dotnet/docs/issues/12083, https://github.com/dotnet/docs/issues/12084,  https://github.com/dotnet/docs/issues/12085

@CJGrondlun - Do you explicitly approve this PR for BUILD ask mode?

@cjgronlund  - Do you explicitly approve this PR for BUILD ask mode?

Approve


Default receipt compaction to be enabled and update latest db version…

PR description
Enable receipt compaction by default. This also updates the database version to use receipt compaction for all new databases simplifying database version logic. Whether receipt compaction is enabled or not still depends on the --receipt-compaction-enabled flag.
Performance testing
No noticeable difference in engine API times over 7 days

Fixed Issue(s)

fixes #7157
Thanks for sending a pull request! Have you done the following?

[ ] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[ ] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

This also updates the database version to use receipt compaction for all new databases simplifying database version logic.

Just to make check my understanding, does this mean that the following scenarios hold?
Scenario A

Before this PR, I have an existing database on with DATABASE_METADATA.json on version 2, e.g. am on Besu version 24.5.1 with default options, i.e. receipt compaction disabled.
I upgrade Besu to a release containing this PR
My DATABASE_METADATA.json is upgraded to version 3

Scenario B

Before this PR, I have an existing database with receipt-compaction explicitly enabled so DATABASE_METADATA.json is version 3
I upgrade Besu to a release containing this PR
My DATABASE_METADATA.json remains on version 3

Scenario C

Using a version of Besu containing this PR, I start a new database with receipt-compaction-enabled=false
My DATABASE_METADATA.json is still set to version 3

Scenario D
Downgrading to 24.5.1 after any of Scenario A-C results in DATABASE_METADATA.json remaining on version 3.
Downgrading beyond 24.5.1 after any of Scenario A-D would break compatibility.

Not sure if this is related to the change of default directly, but is it intended that you have to give an explicit "true" value for the option to work?
besu --receipt-compaction-enabled
Missing required parameter for option '--receipt-compaction-enabled' (<receiptCompactionEnabled>)

Think I had a similar issue when I enabled bonsai-limit-trie-logs-enabled by default and had to use a fallbackValue: https://github.com/hyperledger/besu/commit/7c21eed59d0a02eb340757aaffe066c9d9ea8e2d#diff-694f097ee7fb3140c34f4aed55d05b024c8faf509b09e71643d16ed68e1db67bR90

This also updates the database version to use receipt compaction for all new databases simplifying database version logic.

Just to make check my understanding, does this mean that the following scenarios hold?
Scenario A

Before this PR, I have an existing database on with DATABASE_METADATA.json on version 2, e.g. am on Besu version 24.5.1 with default options, i.e. receipt compaction disabled.
I upgrade Besu to a release containing this PR
My DATABASE_METADATA.json is upgraded to version 3

Yes

Scenario B

Before this PR, I have an existing database with receipt-compaction explicitly enabled so DATABASE_METADATA.json is version 3
I upgrade Besu to a release containing this PR
My DATABASE_METADATA.json remains on version 3

Yes

Scenario C

Using a version of Besu containing this PR, I start a new database with receipt-compaction-enabled=false
My DATABASE_METADATA.json is still set to version 3

Yes

Scenario D Downgrading to 24.5.1 after any of Scenario A-C results in DATABASE_METADATA.json remaining on version 3.

Yes it will remain on version 3, but if receipt compaction isn't enabled then a warning is printed in case they wanted to remove the compacted receipts
Database contains compacted receipts but receipt compaction is not enabled, new receipts  will be not stored in the compacted format. If you want to remove compacted receipts from the database it is necessary to resync Besu. Besu can support both compacted and non-compacted receipts.

Scenario E Downgrading beyond 24.5.1 after any of Scenario A-D would break compatibility.

Yes in this Besu won't start and there will be an error saying the database is incompatible

Not sure if this is related to the change of default directly, but is it intended that you have to give an explicit "true" value for the option to work?
$besu --receipt-compaction-enabled
Missing required parameter for option '--receipt-compaction-enabled' (<receiptCompactionEnabled>)

Think I had a similar issue when I enabled bonsai-limit-trie-logs-enabled by default and had to use a fallbackValue: 7c21eed#diff-694f097ee7fb3140c34f4aed55d05b024c8faf509b09e71643d16ed68e1db67bR90

I broke this in the original PR by adding arity=1 option. That was added so it would work with a default false value, fallback might worked in that case. Not it defaults to true don't need either trick.

Think I had a similar issue when I enabled bonsai-limit-trie-logs-enabled by default and had to use a fallbackValue: 7c21eed#diff-694f097ee7fb3140c34f4aed55d05b024c8faf509b09e71643d16ed68e1db67bR90

I broke this in the original PR accidentally by adding arity=1 option. That was added so it would work with a default false value, fallback might have worked in that case. Now it defaults to true don't need either trick.
Updated the PR so works with an implicit true value.

Now, this silently sets receipt-compaction-enabled=false...
besu --receipt-compaction-enabled
...
2024-08-16 20:33:05.055+10:00 | main | WARN  | BesuControllerBuilder | Receipt compacting enabled? false

That's why I had to add fallbackValue="true" for limit-trie-logs.
Also, I had to add my own log to test this - reckon it's worth adding this to the config overview table?

Think I had a similar issue when I enabled bonsai-limit-trie-logs-enabled by default and had to use a fallbackValue: 7c21eed#diff-694f097ee7fb3140c34f4aed55d05b024c8faf509b09e71643d16ed68e1db67bR90

I broke this in the original PR accidentally by adding arity=1 option. That was added so it would work with a default false value, fallback might have worked in that case. Now it defaults to true don't need either trick.
Updated the PR so works with an implicit true value.

Now, this silently sets receipt-compaction-enabled=false...
besu --receipt-compaction-enabled
...
2024-08-16 20:33:05.055+10:00 | main | WARN  | BesuControllerBuilder | Receipt compacting enabled? false

That's why I had to add fallbackValue="true" for limit-trie-logs.

Also, I had to add my own log to test this - reckon it's worth adding this to the config overview table?
I don't think it's worth it as I doubt it will probably be changed much in practice. I've also added a test for the implicit case so I know that's working.


Validate API documentation (meta-release item 4-5)

API versioning convention applied  (done)
API documentation (pending from #25 )

Completed


Update Organizations functional tests for collaborators

Due to https://github.com/NuGet/NuGetGallery/issues/5731 we now no longer test collaborator permissions correctly in our functional tests. We should update the tests to reflect this.

dupe of https://github.com/NuGet/NuGetGallery/issues/5781


python311Packages.pytensor: 2.18.4 -> 2.18.5

Description of changes
Changelog: https://github.com/pymc-devs/pytensor/releases/tag/rel-2.18.5
cc @bcdarwin

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 278297 run on x86_64-linux 1

12 packages built:

python310Packages.bambi
python310Packages.bambi.dist
python310Packages.pymc
python310Packages.pymc.dist
python310Packages.pytensor
python310Packages.pytensor.dist
python311Packages.bambi
python311Packages.bambi.dist
python311Packages.pymc
python311Packages.pymc.dist
python311Packages.pytensor
python311Packages.pytensor.dist


refresh control is affected by horizontal swipe

https://github.com/facebook/react-native/issues/11939
How can I resolve this?

Downgrade to version 0.6.x should help. See #541

It resolved that issue but now my nested Scrollable Tab Views don't show their content.


DELETE all the code!! And replace with a bit of less, yet better code!

What's this PR do?
This PR DRYs up the request methods in the ApiClient class in JS, so that they all send their requests through the new send() method. This will help keeps things cleaner and easier to manage in the class. It also update the console output for development purposes when a request is made via the class.
Example in the console on development only:

This PR also moves the whatwg-fetch polyfill library out of the webpack config and into libs.js.
How should this be reviewed?
👀 do API calls happening in the Onboarding experience still work?!?
Relevant tickets
Fixes #6954
Fixes: 💅
Checklist

[ ] Tested on staging.

@DFurnes @deadlybutter
cc: @jessleenyc

Two little thoughts – otherwise looks great! 🚢

I was considering using: https://github.com/marak/colors.js/ for coloring the output in console, but also wasn't sure how best to add a package that doesn't get bundled for prod. I wasn't even sure I'd end up using it or not, but curious if you had suggestions on the non-prod bundling issue @DFurnes

@weerd dev dependency? npm install <thing> --save-dev i think

You can conditionally include things with the NODE_ENV environment variable.
if (process.env.NODE_ENV !== 'production') {
  require('colors.js')
}

@deadlybutter yeah, the problem is I'd be require-ing in the same ApiClient class, and thus would get bundled in. @DFurnes yeah, more something like that, cool. I'll play around with it at some point and see where it gets me and if it's worth it.

@deadlybutter NPM's dependencies and devDependencies will both always get installed, since this isn't a library (where NPM will skip the devDependencies when a package is being installed as another project's dependency).
We've been adding "local dev" (build, linting, etc) dependencies in that group by convention, but it just so happens that they also aren't things that are included in the final production build. Nothing's really stopping us from doing that if we wanted to be wild.

@DFurnes Oh interesting, I always thought production builds excluded those

@deadlybutter new lodash merge() will override any props on default object that you pass into via the options object. 😉

🚢


Are you using "loadMax" for performance?

Are you using loadMax for performance in the code below?
export default class DataResource {
    loadMax: number = 500;
    ...
}

Code using loadMax.
https://github.com/xtreme1-io/xtreme1/blob/2959792b11c7c7c1426dd4dbe208249743a4c35a/frontend/pc-tool/src/packages/pc-editor/common/DataResource.ts#L207-L208
https://github.com/xtreme1-io/xtreme1/blob/2959792b11c7c7c1426dd4dbe208249743a4c35a/frontend/image-tool/src/package/image-editor/common/ResourceManager/index.ts#L6-L11
Thank you all for your contributions and great features. They are always appreciated.

You are right. When the size loaded into memory exceeds loadMax, the earliest loaded point cloud data will be released.

Thanks reply!


getting error when passing with_head=False to load_adapter

I use the following code to load adapter to my bert model of type BertModel :
adapter1_conf = AdapterConfig.load("pfeiffer")
adapter1_name = model.bert.load_adapter("dialect/arabic@mapmeld", config=adapter1_conf, model_name='aubmindlab/bert-base-arabert', with_head=False)

However, I get the following error:
Traceback (most recent call last):
  File "modeling.py", line 347, in <module>
    trainer_class.train_and_evaluate_with_multiple_seeds(1, seeds_from_config=True, eval_on_train=False)
  File "modeling.py", line 314, in train_and_evaluate_with_multiple_seeds
    accuracy_agg, model_pathes = self.train_with_multiple_seeds(no_times, seeds_from_config=seeds_from_config)
  File "modeling.py", line 248, in train_with_multiple_seeds
    temp_accuracy, best_model_path = self.train()
  File "modeling.py", line 96, in train
    adapter1_name = model.bert.load_adapter("dialect/arabic@mapmeld", config=adapter1_conf, model_name='aubmindlab/bert-base-arabert', with_head=False)
  File "/usr/local/lib/python3.7/dist-packages/transformers/adapters/model_mixin.py", line 347, in load_adapter
    adapter_name_or_path, config, version, model_name, load_as, leave_out=leave_out, **kwargs
  File "/usr/local/lib/python3.7/dist-packages/transformers/adapters/loading.py", line 401, in load
    **kwargs,
  File "/usr/local/lib/python3.7/dist-packages/transformers/adapters/utils.py", line 405, in resolve_adapter_path
    adapter_name_or_path, model_name, adapter_config=adapter_config, version=version, **kwargs
  File "/usr/local/lib/python3.7/dist-packages/transformers/adapters/utils.py", line 354, in pull_from_hub
    download_path = download_cached(file_entry["url"], checksum=checksum, checksum_algo=checksum_algo, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/transformers/adapters/utils.py", line 115, in download_cached
    output_path = get_from_cache(url, cache_dir=cache_dir, **kwargs)
TypeError: get_from_cache() got an unexpected keyword argument 'with_head'

When I remove the with_head parameter it works, but I need to remove the head from the adapter.
Any idea?

The with_head parameter is only present for model classes that actually have a prediction head (AutoModelForSequenceClassification, AutoModelWithHeads, BertModelWithHeads etc.). Base model classes (BertModel, RobertaModel etc.) don't have this parameter for load_adapter() as adapters are loaded without heads in any case. From your code, it seems you're calling load_adapter() from a base model class (model.bert.load_adapter()).

@calpt  so even if the adapter description says it has a prediction head, the head will not be loaded in my case?
I use this adapter:
https://adapterhub.ml/adapters/mapmeld/bert-base-arabert-ar-dialect/
and it has a classification head that I don't want to use

Yes, that's right. BertModel and similar classes cannot make use of a prediction head, even if available. Only classes that support heads (XForSequenceClassification etc. and XModelWithHeads) will load prediction heads by default.

Thank you @calpt


🐛 Collapse component is playing animation on load

Describe the bug
When using the Collapse component in for example a Navbar on page load it plays the close/open animation (if expanded it fades in the menu and if in mobile mode it plays the slide up animation).
How to reproduce
Steps to reproduce the behavior:

Create a Navbar that is expanded on md level
Reload the page
See error

e.g.
<script lang="ts">
  let isOpen: boolean = false;
  function handleUpdate(event: CustomEvent<boolean>) {
    isOpen = event.detail;
  }
</script>
<Navbar color="primary" expand="md" container="md">
	<NavbarBrand href="/">
		My Logo
	</NavbarBrand>
	<NavbarToggler on:click={() => (isOpen = !isOpen)} />
       <Collapse {isOpen} navbar expand="md" on:update={handleUpdate}>
		<Nav navbar>
			<NavItem>
				<NavLink href="/">Home</NavLink>
			</NavItem>
		</Nav>
	</Collapse>
</Navbar>

Expected behavior
The animation should only play if I toggle the menu after clicking the NavbarToggler button. But not on page load
This seem to be an issue that existed in the previous version as well but got fixed at some point: https://github.com/bestguy/sveltestrap/pull/457

There seem to be a lot of issues with collapse in the navbar, I may just have to write my own or use the normal bootstrap js for now


Added support for UUID type

I needed a UUID type, so I added support for it.
Hope it can be merged into main project.

Thanks a lot!


add more complex sort option (geo_distance eg)

now we can dot something like
Model::search('*')->whereGeoDistance('pin', $position, '500m')->from($offset)->take($limit)->sort([
                "_geo_distance" => [
                    "pin" => $position,
                    "order" => "asc",
                    "unit" => "km",
                    "distance_type" => "plane",
                ],
            ]
        );

Hi, is this going to be merged at any point ? Thanks


Generalize UTxO identifiers and addresses in coin selection Gen modules.

Issue Number
ADP-1523
Summary
This PR removes the dependency on Address and WalletUTxO from the following modules:

Cardano.Wallet.CoinSelection.Internal.Balance.Gen
Cardano.Wallet.Primitive.Types.UTxOIndex.Gen
Cardano.Wallet.Primitive.Types.UTxOSelection.Gen

It moves all generators and shrinkers for WalletUTxO to a new module:

Cardano.Wallet.CoinSelection.Gen

Future Work
In the long run we should be able to remove module Cardano.Wallet.CoinSelection.Gen, as the coin selection test suite will eventually use its own test types for addresses and UTxO identifiers.
But for now, we use this module as a way to minimize duplication.

bors r+


High memory usage

Hi, your code is very good and works well, but when I use it the memory usage goes up quite a lot and when the scraping is finished the memory doesn't come back to normal. Are you sure you closed the goroutines when they were finished?

thank you @c0deslinger .
The application starts on the background N browsers (chrome). This is memory intensive.
When scraping finishes the application does not exit.
Although indeed I can confirm that memory usage does not drop
smem |grep -w 'google-maps-scraper'
36621 giorgos  ./google-maps-scraper -dept        0   704424   704432   705612

It does not look that any goroutines are still running, but I need to check again the "parent" project scrapemate.
Although, this "problem" does not look a blocker. Even with a large number of queries the memory increases but at some point stops increasing.
you may try to tune the garbage collector frequency (use the GOGC environment variable). I noticed less memory usage when the GC triggers more often.
Also please read this: https://tip.golang.org/doc/gc-guide
The section 'A note about virtual memory', but I am not sure if that's the case here.
this requires deeper investigation since I didn't notice any obvious issue in code.
I will leave the issue open. Maybe someone assists here

closing issue because of inactivity

Hi, I'm also facing the high memory issue and I noticed playwright took out a lot of space. I attached my local heap profile for reference and this is after finishing all the jobs and awaiting for jobs.
The high memory issue is also due to ms-playwright but this can't really be resolved


help with regular expressions

Using version 0.6.0. I can't figure out how to incorporate regular expressions into the step function.
I'm trying to not only make 'exact' an optional word, but have the step function track whether 'exact' is included or not in the gherkin sentence. This is so my step function's logic can act on whether 'exact' was in the sentence or not.
Goal:
"Then I do a exact search" => step function parameter exactParam will store 'exact'
"Then I do a search" => step function parameter exactParam will store either null, undefined, or ''
But the following cause cypress to say "Step implementation missing for: I do a exact search":
then('I do a (exact)? search'), (exactParam) => {.... //rest of code
then('/I do a (exact)? search/'), (exactParam) => {.... //rest of code
then('^/I do a (exact)? search$/'), (exactParam) => {.... //rest of code
then('^/I do a (exact\s+)?search$/'), (exactParam) => {.... //rest of code
I also tried another simple regex example to look for a single digit in the gherkin sentence:
"Then I do 2"
But Cypress still said "step implementation missing for: I do 2"
then('I do (\d)'), (num) => {.... //rest of code
then('I do (\d+)'), (num) => {.... //rest of code
then('/I do (\d+)/'), (num) => {.... //rest of code

If using a direct regexp in the step definition is not currently available or won't be for a while, is it possible to define my own custom cucumber parameter types somewhere such as the following?
new ParameterType(
'color',           // name
/red|blue|yellow/, // regexp
Color,             // type
s => new Color(s), // transformer
false,             // useForSnippets
true               // preferForRegexpMatch
)

both should be possible :) but I don't think either are supported yet. I will put a few hours into this today and will  let you know what I find.

I'm so sorry - the previous issue about regular expressions seemed to be resolved, so I assumed they worked, but they never did. I fixed them, will release a new version in a momen!
Thanks so much for reporting this!

Great, thanks a lot. This will help writing step definitions a lot more flexible.

Hi I need some help with regular expressions.
I basically have these two feature lines
Given the user selects the "4th" item from the results lists
Given selects the "4th" item from the results lists

my given:
Given(/^selects the {string} item from the results lists$/, (itemPosition: string) => {
    home.selectItem(itemPosition.replace(/[^0-9]/g, ''))
  },
);

I need the ability for the Given to recognise both those feature lines above (the user - is basically optional)
Is there an issue or am I doing regular expressions incorrectly?

Remove the ^

I removed the ^ - didnt work
I removed the $ as well - didnt work

my packages:
"cucumber": "^7.0.0-rc.0",
"cypress": "8.0.0",
"cypress-commands": "^1.1.0",
"cypress-cucumber-preprocessor": "^4.2.0",
it seems the / aint working at all no more, as it even failed against
And selects the "5th" item from the results lists

You can't use {string} in regular expressions. It only has meaning in strings, which are translated by cucumber-expressions.
Given(/selects the "([^"]*)" item from the results lists/, (itemPosition: string) => {})

ah, right... :-) I somehow assumed the first Given worked and the second did not.
The ^ has to go as well nonetheless (and Jonas omitted it in his example). ^ in the regex world means that the matching line has to start with whatever follows.

Thanks both for your help - it works nicely now :)


GH-2691: Kafka Reactive Binder Support Multiplex

Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2691

Looks great! Merged upstream.


Common builder

Type of change:

[ ] add reconcile/common, make common builder to use in pkg/reconcile

LGTM


sp-container not destroyed when clicking on .sp-choose

Hello,
I am using your great color picker in a current project. I am very content with it but have following issue:
Spectrum opens when the user clicks onto (one or more)  elements (which are dynamically created upon various user interactions). spectrum is appended to the  node (which I want to keep). When the user clicks somewhere outside spectrum the .sp-container is hidden, everything's fine.
But: when the user clicks onto .sp-choose an additional (hidden) .sp-container node is appended to . So each time the user opens spectrum the  node receives another .sp-container.
How can I get rid of  these (unused) remains?
As mentioned: this behaviour occurs only when clicking on .sp-choose.
I've tried 'destroy' and/or manually remove the .sp-container node, but then spectrum does not open at all any more.
Cheers from Vienna/Austria.
jo

Same sort of behavior here - (duplications) - but when using inside a Worpress Divi & DiviPopup container.. pre-callling ("destroy") seems to do nothing...
IMHO (with great deference) there should be a "check for pre-existance on a given element" somewhere in the instantiation code


eScience branding

@ctwhome suggested adding some eScience center branding to the guide.
Todo:

[x] eScience center logo on the search bar
[x] eScience colour scheme
[x] Download button for PDF version of guide (see #217)
[ ] Welcome image on landing page (turing-way style)

please check the pull request https://github.com/NLeSC/guide/pull/227

Closing this since it is mostly done.


Authorisation Error

With a new push, stage Set up job and Run actions/checkout@v2 go well, but at stage Run<EMAIL_ADDRESS>an error occurs:
with:
    deta-access-token: ***
    deta-name: server-one
    deta-project: default
#=#=#

######################################################################## 100.0%
                                                                           0.0%
#######################################                                   54.5%
########################################################                  78.9%
######################################################################## 100.0%
Archive:  /home/runner/.deta/bin/deta.zip
  inflating: deta
Deta was installed successfully to /home/runner/.deta/bin/deta
Manually add /home/runner/.deta/bin/deta to your path:
  export PATH="/home/runner/.deta/bin:$PATH"

  Run '/home/runner/.deta/bin/deta --help' to get started
Error: failed to list spaces: Unauthorized
Error: Process completed with exit code 1.

My actions:
On deta: added a new key in settings by pressing button Create Key.
Copied the key value and added the repository with code DETA_TOKEN to the secrets.
Created an action file.
My action file

Hey @uspi!

My actions:
On deta: added a new key in settings by pressing button Create Key.
Copied the key value and added the repository with code DETA_TOKEN to the secrets.

You generated and used the API key for the project, that serves other purposes than the access tokens (see https://docs.deta.sh/docs/micros/api_keys). You need to generate an access token from your profile settings page and add it to the DETA_TOKEN secret and in your action file.

The deta cli also authenticates with deta access tokens. You can create an access token under the Settings view at https://web.deta.sh/home/:your_username/ (also accessible by clicking the blue left caret < from the nav bar in a project's view). The access tokens are valid for a year.

from https://docs.deta.sh/docs/cli/auth#deta-access-tokens

It works, thanks!


How can I set content encryption algorithm while using jose-jwe-jws.d.ts

In jose-jwe-jws.d.ts file, setContentEncryptionAlgorithm is not exposed for WebCryptographer. As of now its taking A256GCM as default value and since this method is not exposed in ts file I am unable to set content encryption algorithm which I need to use.
Can you please let me know how to set content encryption algorithm when I use jose-jwe-jws.d.ts.

Feel free to open a PR which adds the missing function to the type definition file.

I have the same problem, function does not exist

I have the same problem.

Feel free to open a PR which adds the missing function to the type definition file.


[FLINK-14210][metrics]support connect timeout and write timeout confi…

What is the purpose of the change
Support optional connect timeout and write timeout for InfluxDB metric reporter (currently only default is allowed)
Brief change log
Added support for r timeout and write timeout specification for InfluxDB metrics reporter along with supporting tests and documentation.
Verifying this change
Running the unit test suite
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@1u0 ths for review

@1u0  Could you help me review the other PR （https://github.com/apache/flink/pull/9542）

@rmetzger  Could you help approval this PR?


SW-1680 Add accession CSV upload endpoints

Add a set of endpoints under /api/v1/seedbank/accessions/uploads to allow users
to upload accession CSV files. These follow the exact same flow as the existing
species list upload endpoints (and in fact, the same payload classes are used)
including stopping to wait for user input if the file has entries that already
exist in the database.

Current dependencies on/for this PR:

main

PR #639

PR #640   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: va9njEzokSC8Y8P5VHX9


Add option to store nonce validation status on chain with private transactions

PR description
privacy-validate-private-transactions is enabled by default, but there are situations where you may want to allow the private transactions to still be processed. For instance, if you have a separate validator where the PMT is valid, but the validator doesn't know the private transaction is invalid.
Enabling this option could potentially cause your private state to diverge from one another. If you wish to enable this option it is recommended that you re-sync all nodes your network after you do so.
Fixed Issue(s)
Some mitigation for https://github.com/hyperledger/besu/issues/614
Fixes https://github.com/hyperledger/besu/issues/1942
Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

[ ] I thought about the changelog and included a changelog update if required.

Signed-off-by: Antony Denyer<EMAIL_ADDRESS>

@antonydenyer Can we close this issue? Is it still relevant?

I'm reluctant to continue with this unless someone can test it in a production-like environment.  I think close for now and if someone want's to pick it up again I'm happy to help out.


Fix Kafka broker

Not tested but seems safe to assert it's just a typo
Proposed changes:

...

Status (please check what you already did):

[ ] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for submitting this PR, we'll give it a review as soon as possible


Moved sub-package local resources to the global "Resources" & added Modelica 3.5 conform "Protection" annotation

External resources cleanup
Moved all external resources into the root Resources directory (i.e., deleted sub-package local Resources directories); this is according to common Modelica design guidelines and to enable encryption (otherwise encrypting the library will miss the local Resources folders such that their images linked in the documentation etc are not available and broken).
Broken Modelica_Synchronous references cleanup
Further removed references to outdated and unused Modelica_Synchronous library (replaced them with respective references to Modelica.Clocked).
Encryption preparations for non-modifiable distribution with other tooling
Added Modelica 3.5 conform "Protection" annotation to ease distribution of the library bundled with Modelica tooling.
The root-package annotation
Protection(
      access = Access.packageDuplicate)

is the most liberal protection; it restricts nothing (everything visible and copy-/duplicateable). It helps however with bundling the library with distributions of Modelica tooling; such can now easily create encrypted versions of the library if required by distribution environments for example to ensure it is read-only and users who want to modify it have to do so on some source copy (like a git repository clone) but not the Modelica distribution's version.

@AndreasPfeiffer: Can you please review and merge the pull-request?


Data Migration: fixed readme, added java readme

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-java

Can one of the admins verify this patch?

@yaohaizh Hi Yaohai, it seems the generation for Java failed (although the PR is created), could you take a look?

@michaeljqzq The Java SDK is passed in the latest run.

@hitenjava Hi, could you take a look at it?


Display react component type props properly

Show their displayName. Showing it like jsx would be cool. Like <HSplit /> for the example below.

Fixed with #14


Getting Push Notifications Even When Not Logged In

I'm getting push notifications for accounts I'm not logged in with or if I'm not logged in at all.

Yes, we didn't implemented unregister of push from device on logoff, sorry.

You've tried to unregister when user logout?

You can do:
@mobileNotifications_unregister = () ->
  pushNotification = window.plugins.pushNotification
  successCallback = ->
    console.log 'unregister success'
  errorCallback = ->
    console.error 'unregister error'
  pushNotification.unregister successCallback, errorCallback

And call that function before user logout. I'm doing so and works fine.


Evaluate rate limitting

While in general, we shouldn't force the SDK user to a limited rate, It would be useful to pull back on some errors (for example 503), since retries in that case would just make the situation worse.

There is a RetryMiddleware available which uses exponential backoff


Append key mapping to defaults like the signs

It's possible to update signs table within setup, but the keymaps are not updated but replaced. With the following setup, i could see the count of modifications (e.g., add, change) but only the <leader>hl mapping exists, all the defaults are gone e.g., ]c, and <leader>hs. Digged through the implementation in config.lua, the deep_extend attribute of signs table makes it ok with updating but the lack of this attribute in keymaps table makes it overrides the defaults. Hopefully these behaviors could be consistent.
require('gitsigns').setup{
    signs = {
      add = {show_count = true},
      change = {show_count = true},
      delete = {show_count = true},
      topdelete = {show_count = true},
      changedelete = {show_count = true},
    },
    keymaps = {
      noremap = true,
      buffer = true,
      ['n <Leader>hl'] = '<cmd>lua require("gitsigns").toggle_linehl()<CR>',
    },
}

The difference between signs and keymaps is that signs needs to have values for all the fields otherwise gitsigns will error, whereas keymaps are purely optional and we need a way for the user to disable keymaps entirely. The complete list of default keymaps is documented so you just need to copy them. I believe telescope works pretty similarly.

Could you please make this clearer in the documentation then? I also ran into this and was quite surprised that the keymaps got overwritten instead of updated.

I'm noticing the exact opposite behaviour, where keymaps is not getting overridden, meaning I'm unable to remove the keybinds,..... What's happening here?

Are you running :PackerCompile when you make changes to the config? I just tested and the following removes all keymaps:
  {'~/projects/gitsigns.nvim',
    requires = { 'nvim-lua/plenary.nvim' },
    config = function()
      require('gitsigns').setup{
        keymaps = {}
      }
    end
  }

Could you please make this clearer in the documentation then? I also ran into this and was quite surprised that the keymaps got overwritten instead of updated.

I agree it makes the config a bit awkward. Ideally all aspects of the config should be handled the same way.
Some alternative ways we can handle this:

Change keymaps from a table to a function called on_attach, just like how the builtin LSP is configured, and expose the default function so you user can call it to extend mappings:

require('gitsigns').setup{
    on_attach = function(bufnr)
      require('gitsigns.defaults').setup_keymaps() -- Inherit default keymaps

      -- Add our own.
      vim.api.nvim_set_keymap('n', 'm', ':Gitsigns dump_cache<cr>'    , {silent=true})
      vim.api.nvim_set_keymap('n', 'M', ':Gitsigns debug_messages<cr>', {silent=true})
    end
}

With this config.keymaps should probably be deprecated.

Add a field like config.apply_default_keymaps which defaults to true and must be disabled to prevent default keymaps being applied.

Either of these ways will make it so we don't need to special-case the keymaps when processing the config which should be less surprising to users.
Thoughts anyone?

I don't have the config block in the packer statement, i have my config in a separate place where it get's sourced afterwards...
still, ran PackerCompile, but no fix.

This is my config, (it's in fennel, but in the end it compiles down to just calling
gitsigns.setup {
  signs = { ... }
  keymaps = {
    noremap = true,
    buffer = true
  }
}

What you see at the bottom is the output of :nmap <leader>h (which is the specific keybind i'm concerned about).
Replacing it with a function seems very sensible to me - i don't really see the need for having a special table for keybinds, people are using other ways of creating keybinds in other places anyways - I prefer the consistency of that over this weird thing.

I just tried:
      local gs = require('gitsigns')
      gs.setup {
        keymaps = {
          noremap = true,
          buffer = true
        }
      }

And it definitely removes the keymaps.
I suspect the issue may lie in your config. Try adding some print statements in gitsigns.setup to verify the config being passed is correct.

I was doing
gisigns.setup(
  { signs = {...} },
  { keymaps = { ...} }
)

I'm sorry...

No problems, happy to help!


Download only latest version of file in snappy pull-processed-data

Issue
We store several versions of the same file in SODAR; this could be due to sequence QC failure, for instance. The different runs are stored based on different dates (example below). The duplication of results could be confusion and redundant, but importantly it will affect new snappy workflows based on externally generated VCFs -  merge VCFs steps: Error: Duplicate sample names (...), use --force-samples to proceed anyway.
|-- P001-N1-DNA1-WGS1
    `-- variant_calling
       |-- 2022-09-02
       |   `-- out
       |        |-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz
       |        |-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz.md5
       |        |-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz.tbi
       |        `-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz.tbi.md5
       `-- 2022-09-26
           `-- out
               |-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz
               |-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz.md5
               |-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz.tbi
               `-- bwa.gatk_hc.P001-N1-DNA1-WGS1.vcf.gz.tbi.md5

Feature
Add new argument --latest-only to snappy pull-processed-data call. Change PullProcessedDataCommand.pair_ipath_with_outdir() so it can optionally order iRODS objects by date (based on directory tree) and return only latest file.
Alternatives
None.
Additional context
None.

After feedback...
The default behavior should be to download only the latest version. Instead, we should implement a --download-all-versions flag.


🐞 [BUG] - To Fixed contributors page list Remove Bot

Description
To remove Bot name from the contributing list... and also fixed some known issue od templates
Current behaviour
Bot is Added in contributors list
Expected behaviour
Bot to be removed from the contributors list...
Reproduction steps
1. Go to '/contributors'
2. See bot name in 1st page of list

Screenshots
No response
Logs
No response
Browsers
Firefox, Chrome, Safari, Microsoft Edge, Opera
OS
Windows, Linux, Mac
Are you contributing for a program ?
GSSoC2023
Code of Conduct

[X] I have read and agree to the CONTRIBUTING GUIDELINES of this project.

Issue Fixed...


Feature/bunny benchmark

BunnyMarK benchmark is ready.
Build, open the godot project, inspect the main node and change the language you want to use.
You can choose between 3 different implementations of the benchmark as well.
Launch the game and enjoy how quick Koturtle can be.

Out of curiosity, can you post the numbers here? 🙏

Running on I5 4690K, 16BG, Windows 10:
TextureV1:
Kotlin -> 1100 bunnies
GdScript -> 11000 bunnies
SpritesV1:
Kotlin--> 1564
GdScript --> 9015
V2:
Kotlin --> 35
Gdscript --> 9600
Number of bunnies before reaching 60 fps, higher is better.

Ohh, wow! I'm going to try this on my binding (It's probably much slower since I didn't re-implement the core types - and just delegate every operation to Godot).

It's only it was the calls to Godot that were slow. But actually what takes the most time is to instanciate the Sprite Nodes each frame. Nothing much going on there, we just use the pointer returned by Godot and wrap it with a Kotlin Sprite object.

Maybe we could think of putting the benchmark results in a spreadsheet and update it on each release, so we see performance changes over time?
Maybe we could even automate this somehow.

Was able to port he DrawTexture benchmark to my binding and it is looking grim. I got a lower number (1000). Used linux's perf tool and have identified the following as "expensive":

calling c methods (specially the ones returning CValues, there's a hidden step here - moving the value from the stack into kotlin's memory)
MemScope.ptr/getPointer (similar to above but the opposite direction, kotlin memory -> native heap)
KString -> c string conversions (mainly on method_bind calls, caching them would solve the problem)
garbage collection (I'll have to look at this more)

There is still a lot of things we can optimize.
But if what cost the most perf is the memory context switch between C and Kotlin. There is no much we can do until K/N perfs improve.
We also have a lot of memory leaks on our side because we can't call the destructor of the native object when the koltin wrapper is freed by the GC.

@raniejade @CedNaru before we now do performance optimizations on each of our bindings, maybe now would be a good time to speak together about the future of our projects.
I think it's too early to speak of merging but surely we can do some sort of know how transfer and maybe work a bit closer together to see in which direction each binding is heading, what works, what does not and maybe even discuss some topics directly together across our projects?

@chippmann I totally agree with you !
I wanted to send a mail to @raniejade today, but as you are already here, I think we can start discuss here.
I think we should have a discord call to organize ourself :)
I'd really like we share our experiences, what will make a future merge easier to do.

GMT +1 (CET) at least we maintainers.

I'm in the land down under :joy: UTC + 11 (AEDT). It will probably be hard to set a meeting :). Let's just discuss here.

UTC -8 (PST) here


[BUG]: Array being passed as multiple params

What version of drizzle-orm are you using?
latest
What version of drizzle-kit are you using?
No response
Describe the Bug
const selectedCategories = ['1', '2', '3']
db.query.transaction.findMany({
      where: and(
        eq(transaction.end_user_id, me.id),
        sql`${transaction.category} = ANY(${selectedCategories}))`
      ),
    })

Selected categories will be passed in as for separate params, rather than a single varchar array parameter into postgres, resulting in query failure. There doesn't seem to be a way to pass array param into drizzle at all
Expected behavior
No response
Environment & setup
No response

Hello, @tonyxiao! As for now, there is no ANY operator in drizzle, so you need to cast javascript array into postgres array by yourself or you can use inArray (IN) operator. They are quite similar, so I think for your task you can do something like this:
const selectedCategories = ['1', '2', '3'];

const response = await db.query.transaction.findMany({
  where: and(eq(transaction.end_user_id, me.id), inArray(transaction.category, selectedCategories)),
});

@realmikesolo they are actually not the same. 1) if you pass an array of 0 elements to the IN operator that will result in a failed query, whereas for ANY operator that will execute just fine. 2) IN operator results in a variable number of parameters (e.g. $1,$2,$3) which cannot be used in things like stored procedures whereas ANY operator receives just a single binding parameter which can be used in stored procedures and also supports better caching.

Thank you for your insights, @tonyxiao. You've correctly pointed out differences between the IN and ANY operators. In this case you should cast you js array to postgresql array format:
const selectedCategories = ['1', '2', '3', '4'];
const postgresArray = `{${selectedCategories.join(',')}}`;

const response = await db.execute(
  sql`select "id", "logins", "category" from "users" where "users"."category" = ANY(${postgresArray}::text[]);`,
);

sql`ANY(${postgresArray}::text[])`

This construction is invalid because, as stated in the first comment, it will be resolved to sqlANY(($1, $2, ...)::text[])`, depending on array length.


Cannot call export_graph with image_size different from default

If your image_size is different from 256, calling export_graph won't work. E.g. if image_size < 256, errors are thrown that certain weights and biases could not be found in the checkpoint.
Solution:
image_size needs to be passed to the CycleGAN constructor, otherwise the network will have the wrong structure. Adding image_size=FLAGS.image_size to the parameters fixed this for me.

Nice! Could you send me a pull request?

https://github.com/vanhuyz/CycleGAN-TensorFlow/pull/25 👍