Query retry logic is not triggered in certain cases

Query executor does not involve retry policy in certain cases
https://github.com/scylladb/gocql/blob/fc1b783165b9629112d226580e2edafbc3c30f49/query_executor.go#L109-L198
These cases are

Host is down
Host does not have pool
Host pool does not have connections

Probably it make sense to involve retry policy in such cases.
It will require policies to be smarter in regards of the GetRetryType results, in listed cases.
Also it will break API a bit in a sense that we will have to introduce new errors which will be returned instead of ErrNoConnections

@dkropachev Currently in these cases you mentioned we don't use retry policy, but we retry on the next host always. It is true even if retry policy is not defined. I am not sure what correct behavior should be if one of those cases occur:

Host is down
Host does not have pool
Host pool does not have connections
and rt == nil, should we then stick to the current behavior and retry on the next host or should we just exit?

@dkropachev ping

I would think stopping the retry on next host would be a regression.  It seems to me - the request was not really tried.

I would think stopping the retry on next host would be a regression. It seems to me - the request was not really tried.

Ok, so I guess if retry policy is not there we should retry on next host in those cases. Also I think the retry policies should be edited to make sure they always result in retry on next host for given scenarios


Fix markdowns

Found via this command markdownlint README.md --disable MD038.
See a detailed description of the rules is available at
https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Thanks!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


Update sbt to 1.10.7 in main

About this PR
📦 Updates org.scala-sbt:sbt from 1.10.2 to 1.10.7
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (1.10.2).
You might want to review and update them manually.
package-lock.json
src/test/scala/io/iohk/atala/prism/node/NodeServiceSpec.scala

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, old-version-remains, commit-count:1

🦙 MegaLinter status: ⚠ WARNING

Descriptor
Linter
Files
Fixed
Errors

✅ REPOSITORY
dustilock
yes

no

✅ REPOSITORY
git_diff
yes

no

⚠ REPOSITORY
kics
yes

1

✅ REPOSITORY
syft
yes

no

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


Add barycentric_coordinate function to Geometry

I added a new function to Geometry that returns the barycentric coordinate for a point within a triangle, and added documentation for the new function.
This algorithm uses the area of a triangle, so I exposed that inside Geometry as well (and documented it).
I used the pure mathematical definition of barycentric coordinates rather than a more optimized algorithm as this implementation has more defined behavior, specifically for points that do not intersect with the triangle, in that scenario, the barycentric coordinate returned will contain a negative number, or the sum will exceed 1. Most optimized versions of this algorithm only return sensical data for the case where the point is on the triangle.
It's a useful little function for lots of rendering stuff - namely getting the UV coordinate for any point on a triangle.
We could theoretically use this calculation to refactor ray_intersects_triangle and is_point_in_triangle, but there is no real need to do that - and we'd likely want to compare the performance between the two implementations.
EDIT:
Note that some other documentation changed in this PR due to running godot --doctool .
Let me know if you need me to make a PR without those changes.
doctool caused changes in this commit:
https://github.com/godotengine/godot/pull/39553/commits/2b867251e13828bedba9a661a38fd712cd617ef7

You'll need to revert the accidental documentation changes.
Most IDEs let you just right-click the line and revert them.

I just pushed a revert commit to undo those doc changes. Is this PR good now clayjohn? Or would you like to rebase this so it doesnt a commit docs/revert docs?

You'll still need to rebase it. We generally want 1 commit per PR unless it is a large change that can logically be broken up into distinct commits.
Here is a helpful doc explaining how to do so.
https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase

Thanks, @clayjohn
I rebased it and submitted another PR: https://github.com/godotengine/godot/pull/39554

In the future, it's better to amend a commit rather than close and reopen a pull request. See https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#modifying-a-pull-request
I highly recommend reading through the entire doc as well when you have time.

Ok. I'll force push the rebase should this happen again next time :)


feat: allow patching name and always return private fields

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 86.654%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
2240

Relevant Lines:
2585

💛  - Coveralls

components/renku_data_services/storage_blueprints/core.py needs to be updated to return sensitive_fields

@leafty I addressed that in https://github.com/SwissDataScienceCenter/renku-data-services/pull/49


Show RDF graphs as PNG also

At this moment we visualize RDF graphs using viz.js option to render as SVG. The library provides also the option to generate PNG images which may be useful to save those images and reuse in presentations.

Done


Minor updates and demo update

@diachedelic I'll publish a minor version after this gets merged. I noticed master was updated recently with a fix.

Also, I will clean up https://bodyscrolllock.now.sh/


User can commit with any name

I have cloned Azure DevOps Repository in local directory. I have installed Tortoise git. Now I have edited username as 'xxxxxxxxxx' in tortoise git's global config file. I have edited any code file and commit&push it from tortoise git. When I see commit in Azure DevOps Repository user name is 'xxxxxxxxxx'. How Can I solve this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e47a3960-103f-0974-47db-9c90e2523447
Version Independent ID: efaf6896-060c-2021-0c8b-5a95b1896eed
Content: Author names in Git - Azure Repos
Content Source: docs/repos/git/git-names.md
Product: devops
Technology: devops-code-git
GitHub Login: @apawast
Microsoft Alias: sdanie

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot


Add repository node to json

Add repository information to components, tools, templates data
Add repository node to json files when needed
Remove stars node from json (as it's only read from stars.json)
Add link to repository on component card
Update stars.json
Update the submission page

This is great! Thank you so much!
Do you think we could move the github URLs to always be contained within the repository field? I.e. use the the url field only if an entry has both a site url and repository URL present. We could probably write a little Node script to transform it or maybe use jq (I don't have any experience with the latter)

Do you think we could move the github URLs to always be contained within the repository field? I.e. use the the url field only if an entry has both a site url and repository URL present.

So swap the behavior ?

repository is the required field
url is an (optional) "superset" to add a specificity
the link of the component/tool/template card is repository unless url is defined

But:

what about package that don't have public source?

don't make any URL mandatory ?

What happen is a package don't have a repository nor an URL?

So swap the behavior ?
repository is the required field
url is an (optional) "superset" to add a specificity
the link of the component/tool/template card is repository unless url is defined

Yep, that's what I was thinking

what about package that don't have public source?

Do we have any? I suppose we could make neither URL mandatory in that case

What happen is a package don't have a repository nor an URL?

We should at the very least require one of the two fields to be present

an IDE/TextEditor seach/replace

Duh. That's obviously the easiest :laughing:


Migrate bots to GitHub Actions

PDF.js has two dedicated bots for testing. However, this is all custom and maintained manually. This is already a problem now since the bots run quite old OS versions that lack a (modern enough) Python 3 version, which blocks the ttx upgrade for example (see #11802).
We could unblock this work by upgrading the OS versions, but for the longer term it would be better for the project to move towards a managed solution such as GitHub Actions. The latter integrates well with GitHub and our existing jobs, and reading quickly through the docs might allow us to create a botio-like flow where whitelisted users can comment on PRs to trigger actions (builds).
In terms of our builds, I mainly see a challenge for the browser tests since they are stateful, so we need to be able to fetch/store the reference images somewhere. I'm thinking this could be done in an S3 bucket, and let GitHub manage the credentials for that.
Let's investigate if these solutions could work for us and how much logic we have to maintain ourselves. The objective is to use existing solutions as much as possible so we don't have to build/maintain it ourselves, as well as improving reliability.

GitHub Actions might actually be available for us now. I think it wasn't before, but now https://github.com/mozilla/pdf.js/actions/new is available, even though the actions tab in the tab bar above is not available. I think the project owner can enable that.

The switch to GitHub Actions is now made in #12760 because of #12743.

For the long term health of the project I think it would be good to migrate all testing to github actions. As Tim mentioned we can store refs in S3 or alternatively Marco mentioned gh action artifacts can be stored for 90 days so we could set up a cron job to maintain them.

I think using GitHub artifacts might also be a good and perhaps even easier solution since everything then stays within the GitHub ecosystem, so we don't have to manage another AWS account for S3. The cronjob should be doable.

Time permitting I'll try to set up a basic workflow to run the bot commands using GitHub Actions, without artifact retention for now, so we can see how/if it works and go from there.

I have been working on migrating the preview task from the bot to GitHub Actions in https://github.com/timvandermeij/pdf.js/commit/fe60c41b69549c48a658b898afb49d00c57db39f and while mostly working, I did run into the limitation that build artifact files can't seem to be accessed individually, at least through the UI, since the are all combined into one ZIP file; see the example run at https://github.com/timvandermeij/pdf.js/actions/runs/1085127345. There are actions to post a comment on a PR with a link to the artifact, but if we can't get a direct link that opens the viewer in the browser that'll be inconvenient. Something similar will be needed for the reftest analyzer for migrating the reference testing task.
This limitation is already reported inhttps://github.com/actions/upload-artifact/issues/14, so given that GitHub doesn't really "host" the artifacts separately, we might still need to use an S3 bucket to make the preview/reftest analyzer available in the browser from a direct link, similar to how Botio does it. We can then also store the reference images there, avoiding the need for a cronjob.

I now have a working implementation of Botio's lint command fully in a GitHub Actions workflow in commit https://github.com/timvandermeij/pdf.js/commit/d37aa7d4a09ed808a15950f57cb9ee18ac6c80de. It works the same as Botio: if a specific comment is places on a pull request by an authorized user, it will trigger the command and put notification comments on the pull request. https://github.com/timvandermeij/pdf.js/pull/5#issuecomment-894801711 is an example of how that looks (first a commit that failed linting, then one that made it pass). I think it's pretty cool how this works and it shows how nicely it integrates with GitHub and how it matches the current Botio behavior.
I chose the lint command since it's easiest to set up the issue comment infrastructure with since we don't have to bother with running browsers. However, while Botio has the linting command, I'm not sure if we should also introduce that in the new setup given that linting by default already runs in the CI workflow for every push, so I don't think there is ever a point where we want to run linting on-demand since it already happens (and if it fails, we can simply retrigger the CI build). Therefore, once I get the browsers working, we can start introducing workflows for all Botio tasks that don't require assets since that's pending on the S3 point above (basically everything except for the browser tests).

One thing that has always annoyed me a little bit with the botio setup is the need to have separate bot-specific tasks for all the tests we want to run (look at the gulp-tasks whose names start with "bot...").
In the new "GitHub Actions" setup, would it be possible to use command line flags instead together with the "normal" gulp-tasks (to reduce duplication)?
For example, instead of having to run gulp bottest, could we run gulp test --bot and have createTestSource directly check for that flag?

I don't see why not. In fact, I'm not really sure why that's even needed in the current Botio setup given that I don't see anything stopping us from using gulp test --bot at https://github.com/mozilla/botio-files-pdfjs/blob/master/on_cmd_test.js#L42? Botio or GitHub Actions will simply run the command we provide it, so if the Gulpfile can handle that argument we're good.

@brendandahl Would it be possible for you to set up an S3 bucket and configure the required secrets for accessing it in GitHub's secret manager? Once that's done, we can test uploading our artifacts and reference images there. See https://dev.to/johnkevinlosito/deploy-static-website-to-s3-using-github-actions-4a0e for how to do this.

Yeah, we should be able to do that. Let me look into getting it set up.

@timvandermeij I've added an s3 bucket. I've also added the following repository secrets:
AWS_ACCESS_KEY_ID
AWS_REGION
AWS_S3_BUCKET
AWS_SECRET_ACCESS_KEY

Nice; thank you! It will require some more tweaking of my initial GitHub Actions workflows, but I think we now have all the pieces of the puzzle to implement all features that our current bots have.

There are things like https://github.com/marketplace/actions/debugging-with-ssh that would allow us to access the GH Actions machines in an interactive fashion through ssh.

@timvandermeij do you think you will have time to continue this?

Sadly I won't have much time on the short term. If you want to have it done faster, feel free to take the proof-of-concept work in https://github.com/mozilla/pdf.js/issues/11851#issuecomment-894803689 and go from there. It mainly needed some more thought given that GitHub did not have a way of inheriting parts of jobs, so for example the list of allowed users would have to be duplicated in every job file, which seems suboptimal. Moreover, we need to try if storing the reference images in S3 works for the browser tests.

Re-reading the discussion above it seems that most of "problems" are around testing in particular, so could we perhaps make easier progress here by ignoring that part for now?
Basically, could we start by only moving tasks like building the gh-pages branch and the pdfjs-dist library from the bots and into GitHub actions instead?

The source code for the existing commands of the bots can be found at https://github.com/mozilla/botio-files-pdfjs. The list of commands of the bots is as follows, and all of them should get an equivalent GitHub Actions workflow before we can shut down the bots.

Non-testing commands:

[x] on_push.js: publishes a new website on every push to the master branch.

Fixed in #16364 and finetuned in #16370 and #16371.

[ ] on_release.js: publishes a new release to the pdfjs-dist repository and NPM.

Testing commands:

[ ] on_cmd_browsertest.js: runs the reference tests.
[ ] on_cmd_fonttest.js: runs the font (TTX) tests.
[ ] on_cmd_integrationtest.js: runs the integration tests.
[ ] on_cmd_lint.js: runs the linting command.
[ ] on_cmd_makeref.js: runs the reference image generation.
[ ] on_cmd_preview.js: builds a preview of the library and viewer for inspection in the browser.
[ ] on_cmd_test.js: runs the unit, font, integration and reference tests.
[ ] on_cmd_unittest.js: runs the unit tests.
[ ] on_cmd_xfatest.js: runs the unit, integration and reference test, but for the latter only the reference tests that involve XFA (as a shortcut to not have to run all tests for XFA changes).

on_release.js: publishes a new release to the pdfjs-dist repository and NPM.

That seems like the single most important one to me, given all of the problems we've had with recent release. (Also, we really "need" to do a new release given some of the standard-font data stuff being worked on now.)

on_cmd_lint.js: runs the linting command.

https://github.com/mozilla/pdf.js/issues/11851#issuecomment-894803689 talks about possibly just removing that one, which is something that I'd fully support.

Thinking about this again, it might be easier to store reference images in a GitHub repository. This way we can easily access images from any run of makeref, and we don't need to set up anything in S3 or GCS.

Thinking about this again, it might be easier to store reference images in a GitHub repository. This way we can easily access images from any run of makeref, and we don't need to set up anything in S3 or GCS.

I think that could work, but then we still need a location for storing the cached PDF files, and especially the linked PDFs are difficult because we don't want to download them again for every run but we also can't put them in a Git repository (for the same reason we currently don't and have the concept of linked PDFs in the first place). Currently we cache them on the filesystem on the bots, and we will need some equivalent option for GitHub Actions.
Do you have ideas on this? (It has been a while since I worked on it so I'm not sure if the secrets listed in https://github.com/mozilla/pdf.js/issues/11851#issuecomment-911955059 are still valid, but lately we've been making more progress in moving bot actions to GitHub Actions so this becomes relevant again.)

What if we used a private github repository? It would be essentially the same as a local filesystem.

Yes, I think that can definitely work. It could store the PDF files that only GitHub Actions may fetch with special credentials, and maybe setting up GitHub Pages for that repository could give us a way to expose e.g. the reference images viewer and the previews we build using a public URL similar to how Botio currently works.

It seems that any further progress on this issue is now completely blocked by having somewhere to store test PDFs and reference images.
Most likely we'll need to do some "real world" experimentation/testing to see what will/won't work, and converting e.g. botio unittest might be a good place to start; however based on the recent discussion we'll need:

A private GitHub repository setup. (It'd be nice if Tim and myself had access to it, to make things easier.)
The private repository configured such that the PDF.js GitHub Actions can access it, as mentioned in https://github.com/mozilla/pdf.js/issues/11851#issuecomment-1817487963, for both reading and writing.

@calixteman, @marco-c Can either of you please help out with the above?
With that in place we'd hopefully be able to replicate the reading/writing that botio unittest currently does, see

https://github.com/mozilla/botio-files-pdfjs/blob/a514bbfe2d8a71cda350b6c404028520784ff29d/on_cmd_unittest.js#L10-L15
https://github.com/mozilla/botio-files-pdfjs/blob/a514bbfe2d8a71cda350b6c404028520784ff29d/on_cmd_unittest.js#L40-L46

which again hopefully would be enough to migrate the unit-tests to GitHub Actions. Once this works, the other test-suites should be fairly simple to convert as well.

I'm going to create a pdf.js-references repository and give all of us access.

Regarding accessing the repo through GitHub Actions, we can do it through the @moz-tools-bot bot. We can create a secret that stores the API key and push to the repo by doing something like<EMAIL_ADDRESS>

* Testing commands:
  * [ ]  `on_cmd_browsertest.js`: runs the reference tests.
  * [ ]  `on_cmd_integrationtest.js`: runs the integration tests.
  * [ ]  `on_cmd_makeref.js`: runs the reference image generation.
  * [ ]  `on_cmd_preview.js`: builds a preview of the library and viewer for inspection in the browser.
  * [ ]  `on_cmd_test.js`: runs the unit, font, integration and reference tests.
  * [ ]  `on_cmd_unittest.js`: runs the unit tests.

Is there any other test command that would be easy to move to GH Actions?  E.g. maybe the unittest one?

  * [ ]  `on_cmd_xfatest.js`: runs the unit, integration and reference test, but for the latter only the reference tests that involve XFA (as a shortcut to not have to run all tests for XFA changes).

Given we're not doing a lot of XFA changes anymore, perhaps we could remove this command at this point.

  * [ ]  `on_cmd_preview.js`: builds a preview of the library and viewer for inspection in the browser.

For this one we could rely on something like https://github.com/marketplace/actions/deploy-pr-preview maybe.


Interpolate fills the shape

Hey guys,
i am having the problem, that two shapes that i interpolate will have a phase inbetween where the shape is filled:
Before:

Inbetween:

After:

That's the code:
const paths = {
  circleOutline:
    'M77,5A72,72,0,1,1,5,77,72.08,72.08,0,0,1,77,5m0-5a77,77,0,1,0,77,77A77,77,0,0,0,77,0Z',
  rectangleOutline:
'M102.73,5A46.33,46.33,0,0,1,149,51.27v51.46A46.33,46.33,0,0,1,102.73,149H51.27A46.33,46.33,0,0,1,5,102.73V51.27A46.33,46.33,0,0,1,51.27,5h51.46m0-5H51.27A51.26,51.26,0,0,0,0,51.27v51.46A51.26,51.26,0,0,0,51.27,154h51.46A51.26,51.26,0,0,0,154,102.73V51.27A51.26,51.26,0,0,0,102.73,0Z',
 };

    const interpolator = interpolate(paths.circleOutline, paths.rectangleOutline);
<path d={interpolator(0.7)} />

What am i doing wrong?

Would love to see this fixed also.
It's also a known challenge since the "fill" really isn't fill but the lack of support for "holes" in a path. Ref. the "Deal with holes?" item in the To do list.
M77,5A72,72,0,1,1,5,77,72.08,72.08,0,0,1,77,5m0-5a77,77,0,1,0,77,77A77,77,0,0,0,77,0Z
The path from the example above has two shapes, represented by the M and m
As described in the documentation

If your path string includes holes or multiple shapes in a single string, everything but the first outer shape will be ignored.

This is what gives the "filled" experience during animation, as only the first path get's calculated, and in the final stage, the target path get's added and gives us the final expected result.


Focus on input when clicking label-tag with for attribute only works for multiple

Bug description:
According PR #1220 I can specify the input-id attribute on ui-select and that attribute value will be reflected in the input tag's id attribute. This logic itself works but focusing does not in Google Chrome at least.
When I click the label I expect the cursor to be moved inside the input field.
Link to minimally-working plunker that reproduces the issue:
Multiple select (works)
Single select (doesn't work)
Plain html (Clicking label sets focus to select box and I can use keyboard to select value)
Version of Angular, UI-Select, and Bootstrap/Select2/Selectize CSS
Angular: 1.5
UI-Select: 0.19.5

Looks like a valid bug to me. Could you investigate and make a PR?

Would hijacking the click event of the label element corresponding to the ui-select directive and set focus on ui-select programatically be a acceptable solution?
As I understand it the relationship between label's and input's id attribute a non standard to begin with.

+1


Nebra OutDoor Miner down for nearly 24h... Even though Online and receiving and Transmitting data (confirmed via router).

https://explorer.helium.com/hotspots/11DXxYuZU1FTDfpm8qmUMob86aC94WNLGp6bUKoqrvRPeJSCDCs
Why this is happening? Everything was functioning normal for the first time yesterday and then boom flatline.

This is not a support channel.
Please email<EMAIL_ADDRESS>

You guys don't respond to support tickets

@rgrego90 yes we reply to every support ticket. We have a team of technical support who are sharing queries all day


update endpoint implemented

Description
This PR fixes #

Can you update the input box for updating the assets to be only active when actually an asset has been selected. Right now you the API request for update still goes through even if there isn't a asset that been selected.

it's also happening for other input fields, should I update them too?

Yes you can

Hey @kmaity-9563! Thanks for this addition.
Can you make sure that you have your tabs spaces set to only 2 and not 4? Once that is set in your IDE settings, then if you could just ensure that all your changes match the syntax of 2 space tabs 👍

yes! i have used 2 space tabs


Tensorlist bug fixes

Hi
This set of patches fixes 2 bugs in current TF master which is also present in 2.4 and 2.3 versions, this pull request is against master branch, please tell me if you need 2.4 version.
Bug was reported in https://github.com/tensorflow/tensorflow/issues/44428 and https://github.com/tensorflow/tensorflow/issues/44526, in a nutshell TensorList can not be decoded from the proto data, there are two bugs (fixed in two commits): decoder for tensorlist got lost and rtti for tensorlist doesn't match.
Both bugs are related to the fact that for some reasons runtime reloads some TF libraries several times, either it is statically linked first time when model is being loaded and then the second time for the second model or maybe the reason for subsequent load is different, but nevertheless having multiple loads wreck things a lot. I observed this bug for the case when inference runtime loads multiple saved_model models, this never happened for single model runtimes.
Please check commit messages for details on how and when bugs appeared.

Given the long description in each commit, I would recommend opening a PR for each one. We are squashing on merge.
Plus, it seems there are a few GPU build failures, so it would be nice to isolate and fix them

Are you sure you want to split it into two pull requests? Because none of them will be able to fix the problem (although both of them will fix some bugs) and it will not be clear why did they occur in the first place.
I will take a look why master changes started to produce internal compiler error during compilation

Checked that master branch builds with my patches on top of commit b299b2600d2be042aa8604f83ef494cea91adb4d with gcc 8.3.1
Could you please restart this test to check out whether it works with more master updates, and also what is the compiler version (and other related info) used in the test? Information is rather scarce via those 'Details' links or I maybe I just do not know where to look?

Hi, any progress on merging this?

Hey, any chance to get it merged into 2.5?

@mihaimaruseac Can you please take a look on above comments from @bioothod. Thanks!

Ping?

@bioothod There was some problems pulling the PR in. Could you please help rebase? (In case it helps.)

@penpornk I will rebase it

Apparently rebase went weird

Force-pushing rebased branch has resolved everything. I can not test bugfix against current master, because it is unusable:

I have manually verified that both commits in this PR are by the same github author who has CLA with us. Changing CLA label to yes.


Feature/add support for original data in messages

Pull request for issue #81

A function "CloneOriginal" has to be implemented in the Message struct

Added MessageData struct to Message struct instead of direct data []byte

Added new method CloneOriginal() to *Message

Added Filter and Formatter interfaces

Updated all existing core filter and formatter

Added FilterModulator and FormatterModulator wrapper

Added FilterArray and FormatterArray types beside exiting ModulatorArray

Renamed modulator related go files (sub-package creation)

New message now get consumer stream as initial stream setting

Removed formatter support from routers (see #80)

Removed deprecated ModulateResultRoute and ModulateResultHandled status

Increased code coverage

:beer: yolo


Move packages to pkg to allow importing

This change will enable other projects to import Spegel directly instead of deploying it as a Daemonset. The goal is to create a stable API that exposes the required packages without limiting the ability to make changes in the future.
Part of enabling embedding Spegel in k3s.
https://github.com/k3s-io/k3s/pull/8977

I have a bunch of stuff queued up, but I'm waiting to make sure I don't need anything else before I submit PRs:

https://github.com/XenitAB/spegel/compare/main...brandond:spegel:main

My plan was to wait on merging this until I get your feedback. I have been looking through your changes in k3s and wanted to get a head start on creating a framework for the exposed API. I think it would be best to use functional option pattern to expose and configuration required.  In a perfect world I do not want to expose any dependencies towards libp2p. I think that we can come up with a solution that will work well for all.

In a perfect world I do not want to expose any dependencies towards libp2p.

Unless you wrap all the libp2p options that anyone might want to use, I don't see a good way around that.

Could we split you changes into a couple of PRs? For example the metrics storage, peer identity, peer storage, and delayed containerd client should be pretty easy to merge. Exporting the bootstrap and OCI package should solve another set of challenges. I just think that if we can agree on how to support an existing router we should be there.

Oh yeah I'll split it up when I open PRs.
Are you open to moving everything out of internal or do you want to put a public facade on everything?

If possible having a public facade would be better, but if it does not work we will just have to expose everything. I pinged you on Slack maybe we can take a longer discussion there?

Closing as this has been done in separate PRs


Spelling and grammar check

Category

[X] Content fix
[ ] New article

What's in this Pull Request?
Pulled the contents of this into Word and ran a spelling and grammar check.

thx @skaggej, appreciated.


Test with zombie.js

MAke sure all tests can run in a headless browser

Is this still an open issue?
I have run each of the available examples (basic, TodoMVC and touch) with casperjs and no observable failures.
There is an issue with the logging output from the formFiller.js and toucher.js when passing an object to the .logger().
Casperjs returns [ object Object ] or [ HTML Object ] due to the fact that Phantomjs only supports basic strings for console logging.
Example:
gremlin toucher    multitouch at 393 37 [object Object]

@jhulme you are right, but I'm not sure we have to use casperjs as this is a "maintained but not too much" project.
Also, there is a lot of better testing frameworks like zombie.js (2?) so that's why I finaly "don't" suggest any PR using casperjs.

Thanks @mickaelandrieu I will take a look at zombie.js

The following worked for me when running with puppetteer:
import fs from 'fs'
import { Page } from 'puppeteer'

export async function runGremlins (page: Page) {
  const gremlinsFile = require.resolve('gremlins.js/gremlins.min.js')
  const gremlins = fs.readFileSync(gremlinsFile, 'utf8')
  await page.addScriptTag({ content: gremlins })
  await page.evaluate(() => {
    // @ts-ignore
    const horde = gremlins.createHorde();
    horde.seed(1)
    horde.unleash()
    return new Promise((resolve) => {
      horde.after(resolve)
    })
  })
}

Hey folks. The Marmelab team is attempting to clean up the Issues backlog. With that, we're closing issues that have been open for an one or more years.
We really appreciate the folks have taken the time to open and comment on this issue. Please don't confuse this closure with us not caring or dismissing your issue, feature request, discussion, or report. If the issue pertains to a bug, please re-test for the bug on the latest version of gremlins.js.
The best way to report problems with gremlins.js 2.0 is to file new issues.


components/commmon: Gallery component improvements

Improved logic to render the Gallery Component more efficiently
Increased the size of the images, when Gallery full screen is toggled
Added a button to minimize full screen slider

Great. Can you add a couple of screenshots?

Great. Can you add a couple of screenshots?

Done. Check PR message.


Tooltips not working

When using the example code from the docs for the tooltips, the tooltips are not shown when hovering in Chrome and Safari when using macOS.

We use the tooltips provided by the filament components. Could you make sure the tooltips work as is expected in other components too?

I can't find tooltips when using regular filament fields. I only find them (in their docs) for the Table Builder - and I use only the Form Builder.


Can't install the 'switch' component

Shell output:
$ yarn add @material/react-switch
yarn add v1.9.4
[1/4] Resolving packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/@material%2freact-switch: Not found".
info If you think this is a bug, please open a bug report with the information provided in "/home/dtc/Documents/Craftathon/craftathon-admin/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

I noticed that in the switch's package.json, version is set to 0.0.0. Does that have anything to do with this?
Tried with NPM, same error.

@Rexcantor it actually hasn't been published yet. I believe next week we will have another release.

@Rexcantor just want to follow up and make sure you know switch is out there!


RVIZ VIO and SLAM paths seperate

Hi,
I have been using your SLAM software and I have been having some issues. First the VIO and SLAM paths in RVIZ seperate and get extremely far apart. Is this normal?
Secondly it's not at all clear what features being track actually means, is there is a way to display the features detected ontop of the image pairs so we can diagnose potential problems with tracking and see where tracking fails?
Third the information on frames is pretty confusing, to clarify what is the difference between base_frame and input_base_frame and base_link? My assumption was input_base_frame transforms the base_link to the left_camera_frame but the wording is very confusing.

Messing with this more, changing the input_base_frame to the same name as the left_camera_frame fixed it, I assumed input_base_frame would be the parent name of the transform "left_camera_frame" but apparently this didn't work. It's not clear to what the difference between "left_camera_frame" and "input_base_frame" transforms are now since both transform the base_frame to the left camera.

Hello,

First the VIO and SLAM paths in RVIZ separate and get extremely far apart. Is this normal?
Ideally, they would stay on top of each other but with any odometry system, you could expect a drift in the VO path as it gives the smooth poses out as opposed to the SLAM path which can have jumps but is accurate w.r.t a map frame

Secondly it's not at all clear what features being track actually means, is there is a way to display the features detected ontop of the image pairs so we can diagnose potential problems with tracking and see where tracking fails?
You can use the Camera display in RViz and use the observations topic (visual_slam/vis/observations_cloud) as an overlay

what is the difference between base_frame and input_base_frame and base_link?
The idea is to add the ability to separate input and output subtrees in tf2.
User can have in_left/in_right/in_base_link and out_map/out_odom/out_base_link.
For example if you want to compare the
o/p of Isaac ROS Visual Slam with a ground truth system you can have
in_left/in_right/in_base_link   --- From groundtruth system
cuvslam_out_map/cuvslam_out_odom/cuvslam_out_base_link   ---- From Isaac ROS Visual Slam

In case of a single robot input_base_frame = base_frame. If you want to track the motion of the robot put the value of base_link in base_frame. If you want to track the motion of left imager then put the value of  left_camera_frame in base_frame.


No Uninstall...

What's the problem?
There is no uninstall executable included.  There is a shortcut called "Uninstall WPN-XM Server Stack" that simply links to "This PC"...
What do we need to reproduce the issue?
This is the file I downloaded: WPNXM-0.8.5-LiteRC-Setup-php70-w64

Installed WPNXM-0.8.5-LiteRC-Setup-php70-w64 into D:\wpnxm-085-literc70-64.
Check, if file exists D:\wpnxm-085-literc70-64\unins000.exe:

Check, if "Uninstall" shortcut points to the unins000.exe executable:

@atiredmachine ?

And, of course, the workaround is to manually delete the folder.


Added (optional) keycloak-adapter

Also added details about configuration to the README file.

In this PR I changed the [spring-boot-starter to tomcat (from jetty)] (https://github.com/daklassen/budgeteer/blob/e5335b0aff2ae6fdb4363e6fbdecb0768523c23d/budgeteer-web-interface/build.gradle#L63), because of easier integration of keycloak adapter.
Does it have any negative impact somewhere else?

@daklassen I don't think it will have any negative impact, but I'll take a look into it. Do you have a running Keycloak server I can use to test the feature? You can send me the needed server infos in Slack. I sent you an invite.

Also there is an Exception when starting the app.
18:46:05.900 [localhost-startStop-1] WARN  org.reflections.Reflections - could not create Vfs.Dir from url. ignoring the exception and continuing
org.reflections.ReflectionsException: could not create Vfs.Dir from url, no matching UrlType was found [war:file:/C:/Users/balke/Downloads/budgeteer-web-interface-1.0.9.BETA.41.war*/WEB-INF/classes/]
either use fromURL(final URL url, final List<UrlType> urlTypes) or use the static setDefaultURLTypes(final List<UrlType> urlTypes) or addDefaultURLTypes(UrlType urlType) with your specialized UrlType.
        at org.reflections.vfs.Vfs.fromURL(Vfs.java:109)
        at org.reflections.vfs.Vfs.fromURL(Vfs.java:91)
        at org.reflections.Reflections.scan(Reflections.java:237)
        at org.reflections.Reflections.scan(Reflections.java:204)
        at org.reflections.Reflections.<init>(Reflections.java:129)
        at org.wickedsource.budgeteer.web.BudgeteerApplication.mountPages(BudgeteerApplication.java:88)
        at org.wickedsource.budgeteer.web.BudgeteerApplication.init(BudgeteerApplication.java:49)
        at org.apache.wicket.Application.initApplication(Application.java:953)
        at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:429)
        at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:353)
        at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:279)
        at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:260)
        at org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFilterConfig.java:105)
        at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4572)
        at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5215)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
        at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1419)
        at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1409)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)


Tests for boundary Integer & Long literals

These tests highlight two compile-time errors that should be occurring that are not. They also provide some boundary literal values that should compile.
According to the Java Language Specification:

It is a compile-time error if a decimal literal of type int is larger than<PHONE_NUMBER> (231), or if the decimal literal<PHONE_NUMBER> appears anywhere other than as the operand of the unary minus operator (§15.15.4).

and

It is a compile-time error if a decimal literal of type long is larger than<PHONE_NUMBER>854775808L (263), or if the decimal literal<PHONE_NUMBER>854775808L appears anywhere other than as the operand of the unary minus operator (§15.15.4).

http://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.10.1
Edit: Sorry I don't have the time or ability to submit a fix along with these tests.

See GROOVY-7385

this is no bug, this is on purpose, so I guess we can close the PR and the issue


Rewrite to use Hyperscript.jl

Because it makes this package more stable because we will never have HTML errors. The other option is to use a HTML parser in our testing to verify the output, but using Hyperscript is much nicer.
Also it's a nice package to work with!

You can do this work mostly inside a Pluto notebook, and copy things over to PlutoUI when you're done!

Done in #148


docs(ui/theme): modal component/service docs add

Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:

Will reopen later


Endless loop in menu

This is a continuation of https://github.com/microsoft/vscode/issues/104727#issuecomment-675896536

I was able to repro the behavior and I think the above commit fixes the issue. Essentially we try to focus the first item but none of the items is enabled yet. In this case we will loop forever. I've simplified the logic of focusing the first item to avoid that condition.


Staking pallet

Import the staking pallet from substrate frame and port into our application.
Budget $40.

Duplicate


Notify/webhook

这个 PR 实现什么功能/修复什么问题:
notify:

support webhook contact type
allow empty receivers for robot or webhook contact type

region:

add NotifyWebhook in notifyclient
call NotifyWebhook in NotifyServerEvent

[x] 功能、bugfix描述
[x] 冒烟测试

是否需要 backport 到之前的 release 分支:

release/3.4

/cc @swordqiu @zexi

Codecov Report

Merging #8344 into master will increase coverage by 11.66%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #8344       +/-   ##
===========================================
+ Coverage    6.13%   17.79%   +11.66%
===========================================
  Files         762       71      -691
  Lines      118312     8019   -110293
===========================================
- Hits         7256     1427     -5829
+ Misses     110401     6486   -103915
+ Partials      655      106      -549

Flag
Coverage Δ

#aFlag
17.79% <ø> (+11.66%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/multicloud/esxi/logger.go

pkg/compute/regiondrivers/kvm.go

pkg/multicloud/esxi/monitor.go

pkg/cloudcommon/validators/misc.go

pkg/cloudcommon/db/enabledstatusinfrasresource.go

pkg/mcclient/options/k8s/configmap.go

pkg/compute/models/routetables.go

pkg/compute/models/policy_definition_resource.go

pkg/compute/models/loadbalancerbackendgroups.go

pkg/baremetal/tasks/worker.go

... and 679 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 928f6c9...927b693. Read the comment docs.

/lgtm
/approve


V11 Lint improvements

This adds some linting improvements and also fixes things. Sadly it also uncovers more typecheck errors.
Closes #2609.

Since we're updating import paths here — can we clean up DataModel? I know their implementation of the file is a mess with the exports, but we should clean that up for our purposes.

What exactly do you mean by that?

Look at the import/export statements in the DataModel file, both in our
repo and in Foundry. It's exported at least twice and only the non-default
export includes the namespace.
On Sun, Jul 14, 2024, 11:24 Kai Moschcau @.***> wrote:

What exactly do you mean by that?
—
Reply to this email directly, view it on GitHub
https://github.com/League-of-Foundry-Developers/foundry-vtt-types/pull/2638#issuecomment-2227443077,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD6Y5AG5C3JI6VP2H7C3IOTZMK64NAVCNFSM6AAAAABK3GAZECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGQ2DGMBXG4
.
You are receiving this because you commented.Message ID:
<League-of-Foundry-Developers/foundry-vtt-types/pull/2638/c2227443077@
github.com>

I can have a look later, but I thought this is modeling what foundry does. The exports, both named and default, should be the same as they are in core. And I thought if it's named the same, namespaces are exported either way. If they are not, I doubt there is a way to also export them as default.

I can have a look later, but I thought this is modeling what foundry does. The exports, both named and default, should be the same as they are in core. And I thought if it's named the same, namespaces are exported either way. If they are not, I doubt there is a way to also export them as default.

While Foundry is internally a mess in this file, I think our project would be better served deviating from it — I should be able to go foundry.abstract.DataModel and then access any namespace properties.
The change that needs to happen is the export default class DataModel needs to be broken up into declare class DataModel and then export default DataModel

I finally had the opportunity to have a look. Now I got what you mean and I changed it.


Add additional primitive support to IsPrimitive extension.

Add support for DateOnly, TimeOnly types.

We would loose netstandard 2.1 support and had to switch to net6.


docs: add readme

Description
Replace this paragraph with a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant examples in examples.

Breaking Change
Does your PR require Discord notification package users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change. (Indicate it in the Conventional Commit prefix with a !,
e.g. feat!:, fix!:).
[ ] No, this is not a breaking change.

Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database.
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.45%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
110

Relevant Lines:
112

💛  - Coveralls


Cleanup all Tag / Favorites code - chtaylo2

Cleanup all Tag / Favorites code from application. No need to continue to have.

Completed in 3.722.20170123


Projections expose protected interfaces

The UWP projections expose protected interfaces, which are not intended to be used by client code.
For example, the projected XAML Control class and all its subclasses expose the IControlProtected interface, which has the [protected] attribute and therefore shouldn't be accessible. I should not be able to write this code:
WXCButton* button = [WXCButton make];
[button getTemplateChild:@"name"];    // Bad! This method should not be visible

Blocked on bug#2319


the url of k8s-ds-amdgpu-db.yaml is not found

Organization Name:

Short summary about the issue/question:  the url of k8s-ds-amdgpu-db.yaml is not found
Brief what process you are following:
https://github.com/openxpu/pai/blob/master/src/device-plugin/deploy/start.sh.template +42
svn cat https://github.com/RadeonOpenCompute/k8s-device-plugin.git/trunk/k8s-ds-amdgpu-dp.yaml
| kubectl apply --overwrite=true -f - || exit $?
the url https://github.com/RadeonOpenCompute/k8s-device-plugin.git/trunk/k8s-ds-amdgpu-dp.yaml can not work

How to reproduce it:

OpenPAI Environment:

OpenPAI version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

Anything else we need to know:

how to pull my modify to  openxpu/pai.
I➜  openxpu_pai git:(dev-jia) git push origin dev-jia
ERROR: Permission to openxpu/pai.git denied to jiaxiaolei.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

Thanks for your contribute to this project. And a pull request has been merged to the project.


Shree: Watch anyfullform.com

Shree requests the watch of the watch_keyword anyfullform\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

anyfullform\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ

Reverting this merge; duplicate entries
https://github.com/Charcoal-SE/SmokeDetector/commit/191abc81bf377dcfdc1bb735dd9be72753751fe8


WIP: operator deployment

This is for testing purposes only.
The files in installation allow local installation of my Quay catalog. Based on the “operator testing” instructions:

start a Kubernetes cluster

install OLM:
kubectl apply -f https://github.com/operator-framework/operator-lifecycle-manager/releases/download/0.10.0/crds.yaml
kubectl apply -f https://github.com/operator-framework/operator-lifecycle-manager/releases/download/0.10.0/olm.yaml

(this will only work in a single-cluster environment; if you want to test in our three-node KIND environment, as used for e2e, you’ll need to pull master OLM which fixes a few bugs)

install the operator marketplace:
git clone https://github.com/operator-framework/operator-marketplace
kubectl apply -f operator-marketplace/deploy/upstream/

install the operator source:
kubectl apply -f installation/operator-source.yaml

verify the result with
kubectl get operatorsource skitt-operators -n marketplace
kubectl get catalogsource -n marketplace

check the available operators:
kubectl get opsrc skitt-operators -o=custom-columns=NAME:.metadata.name,PACKAGES:.status.packages -n marketplace

(you should see Submariner and Wildfly)

create an operator group:
kubectl apply -f installation/operator-group.yaml

create a subscription:
kubectl apply -f installation/submariner-subscription.yaml

After all the above, the Submariner CSV is becomes available, and
kubectl get clusterserviceversion -n marketplace

lists it. Now to check whether it works...
As a sanity test, you can copy submariner-subscription.yaml and modify it to install Wildfly instead, and check that that works: the CSV appears.
The package directory contains the OLM bundle. You can follow the instructions to push it to your own Quay repository, and obviously review the contents for glaring omissions. Courier warns about a number of missing pieces of data, but none of them are essential.

spec.customresourcedefinitions.owned.displayName in body is required
spec.customresourcedefinitions.owned.description in body is required

I suspect this is the problem...

@dimaunx, @mkolesnik, @Jaanki, if you have time to check out the process detailed in the PR description, it would be very helpful! Thanks :-).


Munkireportinfo Data Type Change

Changed reportitems datatype to TEXT for larger data entries

I don't think you can put an index on a TEXT column

You're correct. Forgot to remove the index. It has been removed.


introduce Exchange() interface

LGTM, even if you are modifying the Exchange function signature, meaning breaking API

v0.6.0 tagged to mark the change


NF sample_mask

Major change in API
Closes #132.
Closes #125.
Closes #26.
Sample_mask to handle non-steady-state and scrubbing strategy in Ciric 2017
Method Confounds.load now returns

confounds_: confound variable with non-steady-state and scrubbed time point removed; major change.
sample_mask_: index of sample to keep; new in this PR.
labels_: unchanged.

Concerns
In fMRIprep confound outputs, non-steady-state and motion outliers are regressors.
Scrubbing methods in Ciric 2017 requires removing the volumes before confound removal through regression.
The same should be done on non-steady-state volumes as well.
The current implementation matches Ciric 2017.
I am wondering if this will confuse the users because now the confounds_ and the image file is not the same length?
Another concern is nilearn now supports GLM. The first level model class doesn't have  sample_mask as in NiftiMasker. It would be good if we can accommodate the GLM as well.
Proposed solutions
The temporary solution without nilearn changing their stuff is as follow:

Add an option for sample_mask.
If it's on, return the confounds trimmed and the sample_mask to pass to NiftiMasker.
If off, leave the confounds untrimmed, keep the outliers as part of the confound regressors, and sample_mask kept as it is.
Add docs on how to use the sample_mask feature in NiftiMasker and nilearn GLM class.
Propose relevant change to nilearn

WDYT? Or there's a better way to implement the change?
To-do

[x] Alternative API to address sample_mask
[ ] Improve documentation
[ ] Check ICA-AROMA output
[x] Propose change in nilearn NiftiMasker sample_mask implementation (see #132)
[x] Propose adding sample_mask to nilearn GLM first level model class.
[ ] Deal with the code quality metrics

Huge thanks for starting this PR. It is a non-obvious feature, but I believe the only big piece left for load_confounds to handle everything generated by fmriprep.
Re the proposed change in API, this is a tough one.
Removing time points really can break a lot of things, and should probably not be made too easy to implement.
The issue is that confounds itself depends on whether or not the user wants to use sample_mask ...
For example, if the user applies sample_mask with the Scrubbing strategy, there should not be any scrubbing regressor in the model.
An alternative API would be:

load: returns only confounds, and confounds is not meant to be used in conjunction with sample_mask. If initial time points are suppressed, then they are added to the confounds using one-hot encoders.
load_mask: returns confounds and sample_mask, and the two have to be used together. For the Scrubbing strategy, this means no scrubbing confounds are added, but they are incorporated in sample_mask instead.

Please let me know what you think.

This makes a lot of a sense and is easier for users to understand!
It's an easy change in the code, and with this implementation I will not need to rush with the test data.
I am still not entirely confident with a test case generated from the NKI dataset.
The reason is it doesn't have fieldmap and single-band references and I am not certain how much that effects the non-steady-state detection. I have never processed data with field map or multiband with fMRIprep, and definitly don't know enough to make a call.

I will chat with @ltetrel because he's selected some data on open-neuro to test fmriprep, and he tried to be able to trigger all the parts of the pipeline. Also I am not sure we can easily redistribute derivatives from NKI. I have not checked in a long time, but from what I remember there is a data usage agreement to be signed to access the dataset.

Using data from open neuro is a good shout.
The DUA of NKI is only for the phenotype and genetic data. Just to be on the safe side, I checked the imaging data again. The license is no-free (CC-BY-NC) but it does allow redistribution. I would prefer a dataset that's fully open just to be on the safe side.

I will come back to this PR once we have updated test data - does that sound alright?

After working on nilearn sample_mask issue (see PR #2857), I think we will have a better idea with the API related to sample_mask here.

Fixed a bug not covered with test_load_mask.
The remaining failed test is related to loading non-steady-state outliers.
To remain consistent in how the class method Confounds._load_confound find different confound strategies, I passed self to Confounds._load_non_steady_state but not using it at all.
I prefer to ignore this warning from codacy.

I finally found the time to go over the PR.
I have very little to say: I found the code clear and easy to follow.
A wonderful contribution!
I've marked a couple of typos and some commented lines in the tests which should either be removed or uncommented, but this is ready to be merged as far as I am concerned.
My only (potentially) substantial issues are on the API design.
First, it may be more intuitive to have the load method send back both confounds and mask_samples no matter what. If there is no motion outlier and no non-steady volume, the mask would simply retain every volume. We would then have an option for scrubbing, something like scrub_mask which would switch between adding scrubbed volumes in confounds (scrub_mask=False) vs adding them to sample_masks (scrub_mask=True). We could also not have this parameter at all and offer scrub_mask=True as our only option - if we ever implement a Despiking strategy, this one proceeds with the regressors - but I think we can live without this alternative strategy and avoid crowding further an already over-crowded API. The non_steady_state frames would always get encoded in sample_mask. The load_mask method would disappear. I realize this is a bit of a 180 degree pivot from my initial feedback on the API. But two things have changed. The main one is that nilearn has implemented the mask_sample across all maskers. I wanted to preserve a method that would work without mask_sample because nilearn at the time did not support it, but nilearn ended up moving faster than this PR, and this concern is now obsolete :). The other change is that there is now a clear perspective to merge load_confounds into nilearn. So now is as good a time as any to break our API: users will discover the final API in nilearn for the first time anyway.
Second, the attribute in the confounds object is sample_mask_ but the load_mask method returns sample_masks (with an s). I realize this mimics what's going on with confounds inside the parser. But I would be in favour of using exactly the same name as the corresponding parameter in the nilearn maskers. confounds is meant to be plugged in the confounds parameter of the masker, so following this logic the sample mask should be sample_mask and not sample_masks. I think it only needs to be changed in the docs and the tutorials, but internal names could stay as they are right now (there is an additional suffix _out anyway, and load_single does use sample_mask already).
Let me know what you think @htwangtw

Thanks to the super detailed feedbacks @pbellec. I think these are all good points that we can address. I don't have much to add really.

First, it may be more intuitive to have the load method send back both confounds and mask_samples no matter what. If there is no motion outlier and no non-steady volume, the mask would simply retain every volume. We would then have an option for scrubbing, something like scrub_mask which would switch between adding scrubbed volumes in confounds (scrub_mask=False) vs adding them to sample_masks (scrub_mask=True). We could also not have this parameter at all and offer scrub_mask=True as our only option - if we ever implement a Despiking strategy, this one proceeds with the regressors - but I think we can live without this alternative strategy and avoid crowding further an already over-crowded API. The non_steady_state frames would always get encoded in sample_mask. The load_mask method would disappear.

This is a great idea and simplify the API! The one thing I would add is to check how Nilearn addresses sample_mask or scrubbing in the documentation. I would like to make sure the language is consistent and helpful. For new imager or less method focused researcher, the relationship between sample_mask, scrub_mask, and the nilearn masker parameter mask_sample might not be immediately obvious. It's fine to ignore this point for now I feel. We probably won't know much about how to come up with more consistent descriptors until we have some user feedbacks. Or it might be me over thinking this :P

I realize this is a bit of a 180 degree pivot from my initial feedback on the API. But two things have changed. The main one is that nilearn has implemented the mask_sample across all maskers. I wanted to preserve a method that would work without mask_sample because nilearn at the time did not support it, but nilearn ended up moving faster than this PR, and this concern is now obsolete :). The other change is that there is now a clear perspective to merge load_confounds into nilearn. So now is as good a time as any to break our API: users will discover the final API in nilearn for the first time anyway.

Sometimes we need to get to an intermediate stage before coming to a better solution. I agree this is a good time to make the change. Can either merge this and then implement the changes here, or just implement this in the same PR

Second, the attribute in the confounds object is sample_mask_ but the load_mask method returns sample_masks (with an s). I realize this mimics what's going on with confounds inside the parser. But I would be in favour of using exactly the same name as the corresponding parameter in the nilearn maskers. confounds is meant to be plugged in the confounds parameter of the masker, so following this logic the sample mask should be sample_mask and not sample_masks. I think it only needs to be changed in the docs and the tutorials, but internal names could stay as they are right now (there is an additional suffix _out anyway, and load_single does use sample_mask already).

Nice catch on this one! Consistent parameter name with nilearn is a good shout.

Happy to hear we are on the same page.
Only follow-up comment: I agree it will be confusing for users to get both sample_mask and scrub_mask. After sleeping on it, we should probably only offer to scrub through sample_mask, as it was the original approach. This will simplify the API and limit possible confusion. The benefits of the regressor-based scrubbing is not obvious to me, so it adds complexity with no tangible benefits.

I caught an implementation error of the non-steady-state volume handling while making changes.
load_confounds/confounds.py#L270 is not covered by the current test as this is related to the regressor based scrubbing. We are not exposing this feature to users in the current implementation. I would prefer to keep it but let the test coverage slide.. WDYT @pbellec

fantastic work @htwangtw I have made super-minor comments, and ready to merge :tada: :tada: :tada:


Versions not publishing in Maven

https://travis-ci.org/bblfsh/client-scala
The log for 1.7.0 seems to be Ok, yet the release is not showing on Maven Central:
https://mvnrepository.com/artifact/org.bblfsh/bblfsh-client

It published eventually after many, many hours. So business as usual for maven central, only slightly slower this time.


Don't use Blaze HybridMatrix for internal Gauss points

With p=10, the number of internal Gauss points is 79, which far exceeds the 16, set here. Eigen doesn't have this problem as it makes the non-static dimension, full dynamic. A simple fix would be to just set Hybrid matrices to dynamic matrices in Blaze.
Alternatively, we could set the hyb_mat_buff_size to 79, although I'm not sure if this was intended usage.

Another simple fix, would be to expose an optional template parameter for hybrid matrices. This would allow other hybrid matrices to remain small.


Step By Step

Hi Oliver,
i have a sun2000 inverter. I try to use your program but i need support. You can help me with a detailed installation step?
Thank you for your help.

Hi @salvifran78, how far did you come so far?

Hi Oliver,
because i'am not an expert of python, i used yaml configuration with modbus on home assistant. I found some interpeter that work for me.

This project is a library for being used in some Python applications, providing an easy to use interface to the internal Modbus interface of the Sun2000 inverter. It is not a standalone application that can be used out of the box.
I'm not familiar with Home Assistant, I've heard and read about it recently, but I don't have any experience with that software. But as far as I know, what Home Assistant is and can do, this library does not seem to be usable for your use case.

Closing this due to inactivity.


onPositionDiscontinuity not called when seeking with remote controller while using CastPlayer

Version
Media3 1.2.1
More version details
No response
Devices that reproduce the issue
Tested with:

Samsung A52 and Chromecast Speaker
Pixel 5 with Android TV

Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
We are using ReplacableForwardingPlayer approach. Listeners are readded when switching player

Add Player.Listener with onPositionDiscontinuity callback to player
Play something
Connect to Cast device
Try seeking with remote controller (TV remote or other phone which is connected to same wifi)
onPositionDiscontinuity is not called

Expected result
onPositionDiscontinuity should be called when seeking with remote controller
Actual result
onPositionDiscontinuity is not called when seeking with remote controller while casting to Cast device even though other callbacks like onPlayWhenReadyChanged is called when toggling playback with remote controller
Media
any media
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Thanks for reporting! We are aware of some shortcomings with the current CastPlayer, in particular when other control surfaces (like the TV remote) are involved. I'll leave it open as a known bug, but we are likely not able to fix it soon. The long-term plan is to replace CastPlayer with a completely new implementation that doesn't rely on the Cast SDK, and many of these issues are hopefully solved once we get to this state.

Thank you for the answer. Do you have any suggestions on how we could work around this for now? We rely on Player.Listener callbacks for some important domain calculations and onPositionDiscontinuity is one of the more important callbacks

Do you have any suggestions on how we could work around this for now?

I'm afraid not right now because we would need to investigate this first to check what kind of callback we receive from the Cast SDK and what may be missing to support this use case. If you want, feel free to investigate this problem yourself and send a pull request. Even though we plan to replace CastPlayer as indicated above, we can still accept fixes for obvious problems in the current one if it helps you.


Can't start the server

I just downloaded the starter and installed the global dependencies. when I run the server, I get this message:
I'm not sure if it is a local problem or something with the starter.
I'm using windows8
C:\Users\primary\toto>npm run server

<EMAIL_ADDRESS>server C:\Users\primary\toto
npm run server:dev:hmr

<EMAIL_ADDRESS>server:dev:hmr C:\Users\primary\toto
npm run server:dev -- --hot

<EMAIL_ADDRESS>server:dev C:\Users\primary\toto
webpack-dev-server --inline --progress --profile --colors --watch --display-er
ror-details --display-cached  --content-base src/ "--hot"

module.js:338
throw err;
^
Error: Cannot find module 'webpack'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (C:\Users\primary\toto\webpack.config.js:3:15)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\\node.exe" "C:\Program Files (
x86)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "server:dev" "--" "--hot
"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>server:dev: webpack-dev-server --inline  --progress --profile --colors --watch --display-error-details --display-cached  --content-base src/ "--hot"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server:dev script 'webpack
-dev-server --inline --progress --profile --colors --watch --display-error-detai
ls --display-cached  --content-base src/ "--hot"'.
npm ERR! This is most likely a problem with the angular2-webpack-starter package
,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     webpack-dev-server --inline --progress --profile --colors --watch -
-display-error-details --display-cached  --content-base src/ "--hot"
npm ERR! You can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\primary\toto\npm-debug.log
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\\node.exe" "C:\Program Files (
x86)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "server:dev:hmr"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>server:dev:hmr: npm run server:dev -- - -hot
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server:dev:hmr script 'npm
run server:dev -- --hot'.
npm ERR! This is most likely a problem with the angular2-webpack-starter package
,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run server:dev -- --hot
npm ERR! You can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\primary\toto\npm-debug.log
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\\node.exe" "C:\Program Files (
x86)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "server"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>server: npm run server:dev:hmr
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server script 'npm run ser
ver:dev:hmr'.
npm ERR! This is most likely a problem with the angular2-webpack-starter package
,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run server:dev:hmr
npm ERR! You can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\primary\toto\npm-debug.log

can you update node to 5+ and npm to 3+ you're currently at node 0.12.7 and npm 2

Thax, I just did, but still not working:
C:\Users\primary\toto>npm start

<EMAIL_ADDRESS>start C:\Users\primary\toto
npm run server

<EMAIL_ADDRESS>server C:\Users\primary\toto
npm run server:dev:hmr

<EMAIL_ADDRESS>server:dev:hmr C:\Users\primary\toto
npm run server:dev -- --hot

<EMAIL_ADDRESS>server:dev C:\Users\primary\toto
webpack-dev-server --inline --progress --profile --colors --watch --display-er
ror-details --display-cached  --content-base src/ "--hot"

module.js:341
throw err;
^
Error: Cannot find module 'webpack'
at Function.Module._resolveFilename (module.js:339:15)
at Function.Module._load (module.js:290:25)
at Module.require (module.js:367:17)
at require (internal/module.js:16:19)
at Object. (C:\Users\primary\toto\webpack.config.js:3:15)
at Module._compile (module.js:413:34)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Module.require (module.js:367:17)
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\node.exe" "C:\Program Files (x8
6)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "server:dev" "--" "--hot"
npm ERR! node v5.7.0
npm ERR! npm  v3.6.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>server:dev: webpack-dev-server --inline  --progress --profile --colors --watch --display-error-details --display-cached  --content-base src/ "--hot"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server:dev script 'webpack
-dev-server --inline --progress --profile --colors --watch --display-error-detai
ls --display-cached  --content-base src/ "--hot"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-webpack-star
ter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     webpack-dev-server --inline --progress --profile --colors --watch -
-display-error-details --display-cached  --content-base src/ "--hot"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-webpack-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to in
stall?
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\primary\toto\npm-debug.log
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\node.exe" "C:\Program Files (x8
6)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "server:dev:hmr"
npm ERR! node v5.7.0
npm ERR! npm  v3.6.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>server:dev:hmr: npm run server:dev -- - -hot
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server:dev:hmr script 'npm
run server:dev -- --hot'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-webpack-star
ter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run server:dev -- --hot
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-webpack-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to in
stall?
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\primary\toto\npm-debug.log
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\node.exe" "C:\Program Files (x8
6)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "server"
npm ERR! node v5.7.0
npm ERR! npm  v3.6.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>server: npm run server:dev:hmr
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server script 'npm run ser
ver:dev:hmr'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-webpack-star
ter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run server:dev:hmr
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-webpack-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to in
stall?
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\primary\toto\npm-debug.log
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files (x86)\nodejs\node.exe" "C:\Program Files (x8
6)\nodejs\node_modules\npm\bin\npm-cli.js" "start"
npm ERR! node v5.7.0
npm ERR! npm  v3.6.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: npm run server
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'npm run serv
er'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-webpack-star
ter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run server
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-webpack-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to in
stall?
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\primary\toto\npm-debug.log

what about npm run server:dev?

same issue!
should I re-install global packages considering that I have upgraded node/npm ? or is it something else?

yeah delete node_modules and run npm install again then install all of the globals again

While Installing Global Packages, I got the following warnings/errors:
1- WebPack:
npm WARN optional Skipping failed optional dependency /webpack/chokidar/fsevents
:
npm WARN notsup Not compatible with your operating system or architecture: fseve
<EMAIL_ADDRESS>2.  Therefore problem for webpack-dev-server:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><3 but non
e was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><3 but
none was installed.
3. With protractor:
C:\Users\primary\AppData\Roaming\npm\node_modules\protractor\node_modules\utf-8-
validate>if not defined npm_config_node_gyp (node "C:\Program Files (x86)\nodejs
\node_modules\npm\bin\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js"
rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build,
please add the "/m" switch.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppBuild.targe
ts(366,5):
warning MSB8003: Could not find WindowsSDKDir variable from the regi
stry.  TargetFrameworkVersion or PlatformToolset may be set to an invalid versi
on number. [C:\Users\primary\AppData\Roaming\npm\node_modules\protractor\node_m
odules\utf-8-validate\build\validation.vcxproj]

TRACKER : error TRK0005: Failed to locate: "CL.exe". The system cannot find the
 file specified.  System Windows_NT 6.3.9600
gyp ERR! command "C:\Program Files (x86)\nodejs\node.exe" "C:\Program Files
(x86)\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "reb
uild"
gyp ERR! cwd C:\Users\primary\AppData\Roaming\npm\node_modules\protractor\node_m
odules\utf-8-validate
gyp ERR! node -v v5.7.0
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS><EMAIL_ADDRESS>install: node-gyp re build
npm WARN<EMAIL_ADDRESS>Exit status 1
C:\Users\primary\AppData\Roaming\npm

@moaaz-s can you pull latest changes and see if it works? I'm going to close this but feel free to open another issue


revise error messages with regards to DerivationIndex

Issue Number

ADP-509
Overview

0d1f207902a45a5451a38b264156f92f17d596db
:round_pushpin: revise error messages and error code for DerivationIndex
The current errors were saying black and white at the same time. Understanding what was a valid a value for derivation index and what was not was unclear.

96c62fbb9b9380e8c7356730dd2b06f172c7e561
:round_pushpin: remove 409 Conflict from possible errors of the new signature endpoint.

Comments

bors merge


Draft: Feat/prof page

Related to #6
More description soon

@LudoLogical Thank you very much for spending the time to review the PR. I greatly appreciate it! I addressed most of the issues, but I left some that I thought would be solved in the future via code prettiness plugins, linting, etc. I took note of them and will start working on getting those plugins into the codebase and required before merging PRs (via CI/CD). I also left Tailwind styling as is (even though sometimes it's repetitive) per the Tailwind documentation.

@heartgg You're very welcome; thank you for considering the review! It's great that you're working on setting up things like eslint and prettier. Leaving the Tailwind as-is is perfectly reasonable. In fact, instead of putting things in variables, the official line is actually that, for large projects, anything with repeated Tailwind styles should be considered for componentization (e.g.,  instead of ). Just wanted to throw that out there in case it ends up being right for you down the line.


Controlled rollout of native for new users

For #4599

Can you add a description as to why you're doing this? I can kinda surmise that from the code itself, but it would be better if you updated the description of the PR.


⚠ ClamAV has degraded performance

In a0a46e8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 85 ms

Resolved: ClamAV performance has improved in 7883794.


Immediately crashes game upon trying to load a world

Crash
To Reproduce
Attempt to load a world with this mod.
Expected behavior
World Loads.
Mods and versions are listed in the linked crash report.
https://pastebin.com/2Ycvdezu

This issue was fixed in 6.0.2+1.18, thank you for reporting let me know if the issue persists.


chore(ci): skip shared connections when sweeping virtual circuits

Not a draft because I want to see e2e test results.  Description will be updated pending those results.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a2797d8) 63.11% compared to head (8b8a359) 55.46%.
Report is 59 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   63.11%   55.46%   -7.66%
==========================================
  Files          94       93       -1
  Lines       18250    18149     -101
==========================================
- Hits        11519    10066    -1453
- Misses       6299     7756    +1457
+ Partials      432      327     -105

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Unrelated sweeper warnings:

Error: /22 16:12:16 [ERROR] Sweeper (equinix_metal_vlan) has dependency (equinix_metal_vrf), but that sweeper was not found
Error: /22 16:12:16 [ERROR] Sweeper (equinix_metal_organization) has dependency (equinix_metal_project), but that sweeper was not found


Add trading goods for cargo

Description

Crates or packages with the sole purpose of buying and selling for profit.
Reproduction

Screenshots

Additional context

Isn't the gambling crate pretty much that?

Wrecks will probably need loot piles that can be sold for money.

starbound weapons/food/medicine/parts trading money farm

this feels too gamey


ProcBots, VersionBot: Ensure Github ServiceListener always checks labels; VersionBot does not act on flow/in-progress

This patches broken behaviour, denoted in the title.
Change-type: patch

Connects-to: #238


[BEAM-7543] ReduceByKey.combineBy must accept BinaryFunction<V, V, V>

Fixes [BEAM-7543].

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@dmvk @mareksimunek would you have a look at this please?

Note that there is a slight breaking change. combineBy(Sums.ofLongs()) no longer takes type parameter, because it is contained in the value returned from Sums.ofLongs(). I hope that this change is so tiny we can afford to take it. If not, only option would be to add the parameter back, deprecate it and check that the value passed to this is the same as returned by Sums.ofLongs()

Awesome, thanks for the contribution! ;)


Feature request: shift enter multiline input

Title is pretty self explanatory. It would be nice to be able to shift enter to do multiline input.

The tview.InputField widget is very basic; it only supports single-line input and some bare functionality. There is an open issue for TextArea widget for multi-line input. Unfortunately, it has been a while since the issue has been opened and I don't see the TextArea widget being implemented anytime soon.

Would you be open to a PR which includes #447? It contains all the basic features that would be needed.


Wrong UI elements placement

The login and Signup buttons should come before the cancel button. Here the cancel buttons appear first

This issue has been resolved.
Best Regards,
Surajudeen Akande
Software Developer, Andela
+2348037690966 | Skype: sirolad https://webapp.wisestamp.com/#
http://facebook.com/runthinz http://twitter.com/babatoclean1
http://github.com/andela-sakande
On Tue, Dec 22, 2015 at 4:05 PM, Prosper Otemuyiwa<EMAIL_ADDRESS>
wrote:

The login and Signup buttons should come before the cancel button. Here
the cancel buttons appear first
[image: screen shot 2015-12-22 at 3 56 14 pm]
https://cloud.githubusercontent.com/assets/2946769/11958010/876da3d0-a8c5-11e5-8e95-4c40866e5b49.png
[image: screen shot 2015-12-22 at 3 56 35 pm]
https://cloud.githubusercontent.com/assets/2946769/11958039/af27e8ae-a8c5-11e5-9bb1-00c4d12f878f.png
—
Reply to this email directly or view it on GitHub
https://github.com/andela-sakande/schoo/issues/6.


bmake: 20210621 -> 20220208

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Why is aarch64-linux failing?

@OfBorg build pkgsMusl.hello pkgsCross.x86_64-netbsd.hello

@ofborg build pkgsMusl.hello pkgsCross.x86_64-netbsd.hello


[Five Torches Deep]Minor updates

Changes / Comments
Correction of asheetworker miscalculation
Adding custom attributes for perception, arcane and divine checks
Uploading background images (planning on switching links to Roll20)
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[X] Is this a bug fix?
[X] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Hello @Pantoufle167 ! Your Pull Request includes changes to translation files. Unfortunately, we no longer accept translations submitted outside of Crowdin. To learn more about Crowdin and how to submit translations through Crowdin, please see our article on How to Become a Translation Volunteer. Thanks for all you do!

Hello @Pantoufle167 ! Your Pull Request includes changes to translation files. Unfortunately, we no longer accept translations submitted outside of Crowdin. To learn more about Crowdin and how to submit translations through Crowdin, please see our article on How to Become a Translation Volunteer. Thanks for all you do!

Well ok I registered on Crowdin but I cannot find the Five Torches Deep sheet... I found my other sheets... but not this one :(


HaplotypeCaller - bamOut very different size from GATK3

tag 39c988c2dc7f669306d246a2191d16af50496640
(using our test resources)
./gatk-launch HaplotypeCaller -I ~/IdeaProjects/gatk/src/test/resources/large/CEUTrio.HiSeq.WGS.b37.NA12878.20.21.bam -L 20:1-11000000 -R ~/IdeaProjects/gatk/src/test/resources/large/human_g1k_v37.20.21.fasta  -O testa.g.vcf -ERC GVCF --bamOutput testa.outHC.bam

compare to gatk3.4.46
java -jar /Users/akiezun/projects/GATK3.4-46/GenomeAnalysisTK.jar -T HaplotypeCaller -I ~/IdeaProjects/gatk/src/test/resources/large/CEUTrio.HiSeq.WGS.b37.NA12878.20.21.bam -L 20:1-11000000 -R ~/IdeaProjects/gatk/src/test/resources/large/human_g1k_v37.20.21.fasta -ERC GVCF --bamOutput testa.gatk3.outHC.bam --out testa.gatk3.g.vcf

The size of bamOut files is very different:
samtools view -h testa.outHC.bam |wc -l
     222

samtools view -h testa.gatk3.outHC.bam |wc -l
   41752

Yes, --bamOutput is untested in GATK4, and we already have an alpha-2 ticket to add tests for the HC args that aren't yet covered. What we've tested so far is basic operation in GVCF and VCF mode, with and without intervals.
David

(note: obviously this is not a showstopper)


[Infrastructure] Investigate the use of alembic for openledger migrations

Current Situation

We have the DDL files for the openledger database defined in a series of SQL files in the local_postgres Docker image folder.
Suggested Improvement

For future migrations, it might be useful to have the database managed by a system like alembic^1 for tracking migrations.
Benefit

A migration manager could help us determine which migrations need to be applied to the database and what its current state is. It can also help us roll back should we need to revert to a previous change.
Alternatives

Alembic is the only tool I've used in the past (besides Django's migration tooling, which isn't really applicable here). There also appears to be another tool called yoyo-migrations
Additional context

Implementation

[ ] 🙋 I would be interested in implementing this feature.

Related, I noticed that a few DAGs, like:
openverse_catalog/dags/database/recreate_image_popularity_calculation.py
openverse_catalog/dags/database/recreate_audio_popularity_calculation.py
aren't meant to be scheduled, but rather run manually after sql changes have been made to related tables. Might it make sense for these to be archived and their functionality replaced with some helper code that could be run inside/alongside of migrations?

The idea of a "migration DAG" is feeling more and more reasonable... :thinking:

Alembic is good. It's also a part of the ingestion server packages on the API side so the added consistency is another plus.

We might be able to leverage this project for our functions/views: https://github.com/olirice/alembic_utils

Nice!


Issue with privacy of visualizations

https://github.com/CartoDB/cartodb-central/issues/390#issuecomment-89960117

Closing and also managed other related things in https://github.com/CartoDB/cartodb/issues/8364


Digital goods should probably display in a store regardless of the set "Ships to" country

I have 4 listings in my store, which all happen to be digital listings:

When I change "Ships to" to United States, my store now displays empty because I do not have any physical goods:

This seems like one of those scenarios we could justify going either direction, but when setting my "Ships to" destination, I don't feel like I'm implying that I do not want to see digital goods. I'm more so implying that I want to see things that I can purchase and receive.
It seems like a lot of users will potentially miss out on seeing digital goods if they can only see them when "(Any country)" is selected. I would think since digital goods "ship" to Any country, selecting a specific country would still display them.
Thoughts?

I think it would make sense to change this to "don't show things I can't buy" instead of "show only physical products that ship to me."
Eventually when services have the ability to define a service area, this would filter the services too, and we'd need to change the text to something other than "Shipping". Maybe we should do that now along with changing how the filter works?
Something like "Available in My Area" or "Available In".

@morebrownies I actually have this change in place, but when I check Free Shipping, Digital and Service listings disappear. Is that right, or should they also be exempt from this filter?


Refactor testing to be consistent and clean up after itself more

Went through and renamed and documented all of the "cleanup" functions in Player.java
Fixed up any of these functions that were used without being cleaned up
Made a few new cleanup functions and a few new convenience overloads (there are still loads more that could be done, but this is good)
Made a new custom matcher for checking inventory

How on earth did I miss those? Ah because they're one's not preceeded by a space in my search. Whoops!


[libffi] Build error on x64-windows

-- Configuring x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
Command failed: "B:/Enzo/Desktop/Rocket League/RLMarlbot-master/MemoryWriter/vcpkg/downloads/tools/msys2/09133458fed80fcb/usr/bin/bash.exe" --noprofile --norc --debug -c "V=1 CPP='compile cl.exe -E' CC='compile cl.exe' CC_FOR_BUILD='compile cl.exe' CPP_FOR_BUILD='compile cl.exe -E' CXX_FOR_BUILD='compile cl.exe' CXX='compile cl.exe' RC='windres-rc rc.exe' WINDRES='windres-rc rc.exe' AR='ar-lib lib.exe' LD='link.exe -verbose' RANLIB=':' STRIP=':' NM='dumpbin.exe -symbols -headers' DLLTOOL='link.exe -verbose -dll' CCAS=':' AS=':' ./../src/libffi-3-5867c437e9.clean/configure --build=x86_64-pc-mingw32 "--enable-portable-binary" "--disable-docs" "--disable-multi-os-directory" "CFLAGS=${CFLAGS} -DFFI_BUILDING_DLL" "CCAS=msvcc.sh -m64" "ac_cv_prog_ac_ct_STRIP=:" "gl_cv_double_slash_root=yes" "ac_cv_func_memmove=yes" "--disable-silent-rules" "--verbose" "--enable-shared" "--disable-static" "--prefix=/B/Enzo/Desktop/Rocket League/RLMarlbot-master/MemoryWriter/vcpkg/installed/x64-windows/debug" "--bindir=\${prefix}/../tools/libffi/debug/bin" "--sbindir=\${prefix}/../tools/libffi/debug/sbin" "--libdir=\${prefix}/lib" "--includedir=\${prefix}/../include" "--datarootdir=\${prefix}/share/libffi""
Working Directory: B:/Enzo/Desktop/Rocket League/RLMarlbot-master/MemoryWriter/vcpkg/buildtrees/libffi/x64-windows-dbg
Error code: 77
See logs for more information:
B:\Enzo\Desktop\Rocket League\RLMarlbot-master\MemoryWriter\vcpkg\buildtrees\libffi\config-x64-windows-dbg-config.log
B:\Enzo\Desktop\Rocket League\RLMarlbot-master\MemoryWriter\vcpkg\buildtrees\libffi\config-x64-windows-dbg-out.log
B:\Enzo\Desktop\Rocket League\RLMarlbot-master\MemoryWriter\vcpkg\buildtrees\libffi\config-x64-windows-dbg-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_make.cmake:863 (vcpkg_execute_required_process)
ports/libffi/portfile.cmake:49 (vcpkg_configure_make)
scripts/ports.cmake:175 (include)
error: building libffi:x64-windows failed with: BUILD_FAILED

Working Directory: B:/Enzo/Desktop/Rocket League/RLMarlbot-master/MemoryWriter/vcpkg/buildtrees/libffi/x64-windows-dbg

Do not use locations with special characters: space, +, *, (, ?.

This issue hasn’t been updated for a long time; if it is still an issue, please ping me and I will reopen this issue.