HADOOP-18107 Adding scale test for vectored reads for large file

part of HADOOP-18103.
Description of PR
How was this patch tested?
Reran the changed tests.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
16m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 29s

feature-vectored-io passed

+1 :green_heart:
compile
23m 25s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
20m 37s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 25s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 49s

feature-vectored-io passed

-1 :x:
javadoc
1m 54s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m  5s

feature-vectored-io passed

+1 :green_heart:
shadedclient
22m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 47s

the patch passed

+1 :green_heart:
compile
22m 19s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

-1 :x:
javac
22m 19s
/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 3 new + 1821 unchanged - 3 fixed = 1824 total (was 1824)

+1 :green_heart:
compile
20m 33s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
javac
20m 33s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 3 new + 1700 unchanged - 3 fixed = 1703 total (was 1703)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 17s
/results-checkstyle-root.txt
root: The patch generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12)

+1 :green_heart:
mvnsite
3m 46s

the patch passed

-1 :x:
javadoc
1m 43s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 20s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m 14s

the patch passed

+1 :green_heart:
shadedclient
22m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 43s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 12s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 34s

The patch does not generate ASF License warnings.

244m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 994e63fb8525 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / 55886f54a3ce157b3a2cdbc6e1439adec9dcb5e8

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/1/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
16m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 40s

feature-vectored-io passed

+1 :green_heart:
compile
23m 22s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
20m 47s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 25s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 42s

feature-vectored-io passed

-1 :x:
javadoc
1m 52s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m  8s

feature-vectored-io passed

+1 :green_heart:
shadedclient
22m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 49s

the patch passed

+1 :green_heart:
compile
22m 27s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
22m 27s

root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 0 new + 1822 unchanged - 2 fixed = 1822 total (was 1824)

+1 :green_heart:
compile
20m 33s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 33s

root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 1701 unchanged - 2 fixed = 1701 total (was 1703)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 17s
/results-checkstyle-root.txt
root: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

+1 :green_heart:
mvnsite
3m 47s

the patch passed

-1 :x:
javadoc
1m 41s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m 14s

the patch passed

+1 :green_heart:
shadedclient
22m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 28s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  9s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 38s

The patch does not generate ASF License warnings.

244m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 1bb0ab806e99 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / 53d006f0f83c75db5ff1ca24d7db9408a984b565

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/2/testReport/

Max. process+thread count
1294 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
16m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 29s

feature-vectored-io passed

+1 :green_heart:
compile
23m 17s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
20m 41s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 23s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 46s

feature-vectored-io passed

-1 :x:
javadoc
1m 52s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m  3s

feature-vectored-io passed

+1 :green_heart:
shadedclient
22m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 47s

the patch passed

+1 :green_heart:
compile
22m 26s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
22m 26s

root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 0 new + 1822 unchanged - 2 fixed = 1822 total (was 1824)

+1 :green_heart:
compile
20m 42s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 42s

root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 1701 unchanged - 2 fixed = 1701 total (was 1703)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 11s
/results-checkstyle-root.txt
root: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

+1 :green_heart:
mvnsite
3m 45s

the patch passed

-1 :x:
javadoc
1m 43s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 22s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 36 unchanged - 9 fixed = 37 total (was 45)

+1 :green_heart:
spotbugs
5m 16s

the patch passed

+1 :green_heart:
shadedclient
22m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 40s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 38s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 38s

The patch does not generate ASF License warnings.

245m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6fedfcd3a024 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / 425eef4515348342f043cdd4e222ccb4e195a225

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/3/testReport/

Max. process+thread count
1296 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
16m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 29s

feature-vectored-io passed

+1 :green_heart:
compile
23m 22s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
20m 43s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 45s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 50s

feature-vectored-io passed

-1 :x:
javadoc
1m 55s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m  2s

feature-vectored-io passed

+1 :green_heart:
shadedclient
22m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 44s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 50s

the patch passed

+1 :green_heart:
compile
22m 32s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
22m 32s

root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 0 new + 1822 unchanged - 2 fixed = 1822 total (was 1824)

+1 :green_heart:
compile
20m 49s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 49s

root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 1701 unchanged - 2 fixed = 1701 total (was 1703)

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 16s
/results-checkstyle-root.txt
root: The patch generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12)

+1 :green_heart:
mvnsite
3m 49s

the patch passed

-1 :x:
javadoc
1m 45s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 22s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 36 unchanged - 9 fixed = 37 total (was 45)

+1 :green_heart:
spotbugs
5m 18s

the patch passed

+1 :green_heart:
shadedclient
22m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 31s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  9s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 38s

The patch does not generate ASF License warnings.

246m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0eb83bea76dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / 84d1e5ff91b1b20e188df1a602e852a588c97d68

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/4/testReport/

Max. process+thread count
2059 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
15m  6s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 18s

feature-vectored-io passed

+1 :green_heart:
compile
23m 16s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
20m 42s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 24s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 48s

feature-vectored-io passed

-1 :x:
javadoc
1m 51s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m  6s

feature-vectored-io passed

+1 :green_heart:
shadedclient
22m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 48s

the patch passed

+1 :green_heart:
compile
22m 33s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
22m 33s

root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 0 new + 1822 unchanged - 2 fixed = 1822 total (was 1824)

+1 :green_heart:
compile
20m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 39s

root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 1701 unchanged - 2 fixed = 1701 total (was 1703)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 16s
/results-checkstyle-root.txt
root: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

+1 :green_heart:
mvnsite
3m 44s

the patch passed

-1 :x:
javadoc
1m 44s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 36 unchanged - 9 fixed = 37 total (was 45)

+1 :green_heart:
spotbugs
5m 12s

the patch passed

+1 :green_heart:
shadedclient
22m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 37s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 21s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 36s

The patch does not generate ASF License warnings.

243m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 9918c8e59d68 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / 6c1ac7eebeb849431ee6caafdd1afd09f2cb054d

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/5/testReport/

Max. process+thread count
1846 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran  I think it is ready to be merged. Just the java docs.

+1 pending that move into a constant, just for clarity. thanks
(btw, suggest another rebase to get rid of those javadoc issues)

(btw, suggest another rebase to get rid of those javadoc issues)

Will do the rebase of feature branch in one go after the smaller patches are merged.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
15m 26s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 28s

feature-vectored-io passed

+1 :green_heart:
compile
23m 55s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
22m  9s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 59s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 21s

feature-vectored-io passed

-1 :x:
javadoc
1m 39s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 40s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
4m 45s

feature-vectored-io passed

+1 :green_heart:
shadedclient
23m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 51s

the patch passed

+1 :green_heart:
compile
24m 47s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
24m 47s

root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 0 new + 1822 unchanged - 2 fixed = 1822 total (was 1824)

+1 :green_heart:
compile
21m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 31s

root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 1701 unchanged - 2 fixed = 1701 total (was 1703)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 41s
/results-checkstyle-root.txt
root: The patch generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12)

+1 :green_heart:
mvnsite
3m 35s

the patch passed

-1 :x:
javadoc
1m 31s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m  7s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 36 unchanged - 9 fixed = 37 total (was 45)

+1 :green_heart:
spotbugs
5m  4s

the patch passed

+1 :green_heart:
shadedclient
23m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 43s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 12s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 34s

The patch does not generate ASF License warnings.

248m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux feca553591b4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / 4ab2e2fdcb34144411a84e6147241b67de80d465

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/6/testReport/

Max. process+thread count
1296 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
14m 56s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 52s

feature-vectored-io passed

+1 :green_heart:
compile
25m 12s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
22m 22s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 19s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 21s

feature-vectored-io passed

-1 :x:
javadoc
1m 35s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m  7s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
4m 58s

feature-vectored-io passed

+1 :green_heart:
shadedclient
23m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
1m  2s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 54s

the patch passed

+1 :green_heart:
compile
24m 40s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
24m 40s

root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 0 new + 1815 unchanged - 2 fixed = 1815 total (was 1817)

+1 :green_heart:
compile
21m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 36s

root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 1690 unchanged - 2 fixed = 1690 total (was 1692)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 15s
/results-checkstyle-root.txt
root: The patch generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12)

+1 :green_heart:
mvnsite
3m 24s

the patch passed

-1 :x:
javadoc
1m 37s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 15s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 36 unchanged - 9 fixed = 37 total (was 45)

+1 :green_heart:
spotbugs
5m 15s

the patch passed

+1 :green_heart:
shadedclient
22m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 31s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 10s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 38s

The patch does not generate ASF License warnings.

252m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 20f3430befc3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / 6c00e737fa0da942b0fdda6a52501c20c5e21484

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/7/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ feature-vectored-io Compile Tests _

+0 :ok:
mvndep
14m 32s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m  4s

feature-vectored-io passed

+1 :green_heart:
compile
23m 26s

feature-vectored-io passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
20m 55s

feature-vectored-io passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 27s

feature-vectored-io passed

+1 :green_heart:
mvnsite
3m 46s

feature-vectored-io passed

-1 :x:
javadoc
1m 52s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in feature-vectored-io failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in feature-vectored-io failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
spotbugs
5m  7s

feature-vectored-io passed

+1 :green_heart:
shadedclient
22m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 49s

the patch passed

+1 :green_heart:
compile
22m 38s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
22m 38s

root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> generated 0 new + 1822 unchanged - 2 fixed = 1822 total (was 1824)

+1 :green_heart:
compile
20m 45s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 45s

root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 1701 unchanged - 2 fixed = 1701 total (was 1703)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 10s
/results-checkstyle-root.txt
root: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

+1 :green_heart:
mvnsite
3m 42s

the patch passed

-1 :x:
javadoc
1m 43s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
1m 21s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 36 unchanged - 9 fixed = 37 total (was 45)

+1 :green_heart:
spotbugs
5m 14s

the patch passed

+1 :green_heart:
shadedclient
22m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 26s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 12s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 38s

The patch does not generate ASF License warnings.

243m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4273

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 86b0ecfd23ff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-vectored-io / c734d47c433aa9c63b31858452d091f7c8410998

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/9/testReport/

Max. process+thread count
2235 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4273/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Avoid FOUC when using CSS modules in dev

Fixes #5019
Importing CSS modules causes flash of unstyled content, as an object is returned from Vite causing it to be injected as [object Object] inside the style tag.
Importing with ?inline, allows Vite to returns the CSS  as string which can be used inside the style tag.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Thank you @DrLoopFall!


Password strength validator and it appears to have a bug in its logic for calculating password strength

I’m with RDBS we’re using your password strength validator and it appears to have a bug in its logic for calculating password strength.  We were looking at your calculatePasswordStrength.coffee script and if our password length is over 9 characters and our char types is 3 our strength is 0 which is causing us to fail validation.  When we reduce the password length to exactly nine characters and our char types stays at three we pass validation.
else if password.length <= 9 and charTypes == 3
strength = 3
should be
else if password.length >= 9 and charTypes == 3
strength = 3

fixed a539a9dba8b07c2f30b061cf94a60d4b28b5fa12


[REQUEST] Use of emojis in Markdown

Hello,
I really enjoy this project. Thinking about building it into my encrypted diary project.
I would love to use markdown and emojis in my journal entries. Right now this doesn't seem to be supported.
So I would have to choose to use either emojis or markdown.
:+1: :smile:

I guess you mean emoji code? It probably doesn't need to be part of the Markdown class as you can pre-process your markdown prior to printing it. Something like this:
from rich.emoji import Emoji
markdown = "# Hello World :thumbs_up:"
markdown = Emoji.replace(markdown)

Send me the repos for your repos project if you like, sounds interesting...

That does the trick. Thanks a lot!
I don't have my projekt published on github yet (since its a still a mess).
But if I do so I will let you know :)


BluetoothGATTGetCharacteristicValue returning E_INVALIDARG on first pass to get value data size

When trying to get the value of a Characteristic, I'm getting an E_INVALIDARG result from the call to the function BluetoothGATTGetCharacteristicValue in BleGattCharacteristic::getValue(). I believe this first call is designed to get the return value character size before calling it again to get the actual value.
This line of code in getValue() is returning the E_INVALIDARG:
HRESULT hr = BluetoothGATTGetCharacteristicValue( 			hBleService.get(), 			_pGattCharacteristic, 			0, 			nullptr, 			&charValueDataSize, 			BLUETOOTH_GATT_FLAG_NONE);
I noticed that you (or someone with the same name) noted something similar on stackoverflow (https://stackoverflow.com/questions/46451135/bluetoothgattsetcharacteristicvalue-returns-e-invalidarg-or-error-invalid-functi).
Did you manage to find out why this is occurring?

Yes this problem was resolved.


Write a JavaScript program to find sum of digits of a number

Description
Write a JavaScript program to find sum of digits of a number
Suppose you have a number n and you want to find the sum of its digits. For example, if n = 123, then the sum of its digits is 1 + 2 + 3 = 6.
Input  : 123
Output : 6

How to contribute

Save the solution in FindSumOfDigitsOfANumber.js file
Add FindSumOfDigitsOfANumber.js file in program/find-sum-of-digits-of-a-number folder

!assign


Fix broken links and gallery test

🚀 Pull Request
Description

Fixed a couple of broken links.

Consult Iris pull request check list

@rcomer I restarted the timed-out cirrus-ci jobs, however we're getting a gallery failure
FAIL: test_plot_wind_speed (gallery_tests.test_plot_wind_speed.TestWindSpeed)
:cry:

@bjlittle I'm pretty sure the gallery tests are using an older matplotlib version (can't find a conda list).  We removed the old hashes for that wind plot at #4112, because the old images didn't include some lake features that had been explicitly plotted.  The test passes locally with an up-to-date environment 👍

Wind example in stable docs no lakes 👎
Wind example in dev docs lakes :+1:

For https://github.com/SciTools/iris/pull/4059#issuecomment-840439925 I also ran the main tests locally under both py3.6 and py3.7.  So I'm confident all is well.

@bjlittle please see additional commit to blacken those lake edges.  Gallery tests now passing.
😎

@rcomer Clearly we're not going to get CI to work for py36 or py37 due to known reasons... so I'm going to test your branch locally instead.
I'm happy to merge with CI failures, but local passes :+1:

@bjlittle I think we'll need to pull in #4139 to get the tests passing with a fully up-to-date environment :cry:
I'm on leave for the next week and can't promise to give this attention.  Please feel free to do whatever you like with my branches to get v3.0.2 over the line.

Superseded by #4154


Populate votes element data on the single-legislator view

Right now, because of (lack of) name resolution in my local scrapes, my database lacks People that have linked VoteEvents. Going to mock the element for now, to unblock @heyitsolivia.

cc https://github.com/openstates/new-openstates.org/commit/46b236d512f59d4c85bbb8cd2243c62abc4c52d6


[FEATURE REQ] File Share Upload/ Download needs parallelize uploads

Library or service name.
Azure.Storage.Files.Shares
Is your feature request related to a problem? Please describe.
For upload and download, we do not take advantage of StorageTransferOptions for parallelizing uploads and downloads like how we do for Azure.Storage.Blobs and Azure.Storage.Files.DataLake.
This wouldn't be too bad since we already did it for blobs and datalake. This would help with the new feature of being able to upload a smb file of 4TB

Hi @amnguye, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


[BUG]: unable to run molpal in docking objective

Iam able to run molpal for lookup objective but unable to run it for docking.
i changed the objective configuration file as well but facing some bug.
i am using ubuntu 20.04
please find the attached screenshot

please guide me

Probably a version mismatch with pyscreener. I believe MolPal is only compatible with pyscreener < 1.2.1.
I do agree that changing the patch version number for API changes is a bit confusing.

I faced this issue with pyscreener ==1.1.1.
Solved this by having pyscreener==1.2.2.
So it's another way round instead
pip install pyscreener==1.2.2


Draggable + Swipeable not working

I followed the demo app to the letter and still can't get this to work.
Here is my Adapter class
Here is the Fragment that holds the list
Here is the list view
Any help would be appreciated. Swiping works--but dragging does absolutely nothing.

Hi. I noticed that your ViewHolder class does not implments SwipeableItemViewHolder. Just change super class to AbstractDraggableSwipeableItemViewHolder or implement like the following;
static class ViewHolder extends AbstractSwipeableItemViewHolder implements DraggableItemViewHolder, View.OnClickListener {

    ...

    private int mDragStateFlags;

    @Override
    public void setDragStateFlags(int flags) {
        mDragStateFlags = flags;
    }

    @Override
    public int getDragStateFlags() {
        return mDragStateFlags;
    }
}

Oops. Not sure how I missed that. Thank you! Amazing library.


⚠ Bofrost.at has degraded performance

In 808f005, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1831 ms

Resolved: Bofrost.at performance has improved in 096d516.


Add seed parameter to gen context block

Suggested fix -
add seed parameter to gen context block in the default flows.
--
Seed: This parameter is used to set a seed value for the random number generator used by the model. This allows you to generate reproducible results by providing the same seed value each time.
If seed is not provided, or the model changes, or the input changes (by as much as a single token) then the result will be a completely new result. It's only there for reproducibility.

I don't know what this means? Need a full explanation of what is proposed here

@markmc -- updated the description, will open a PR with this change.


fix(@jest/environment, jest-mock, jest-runtime): align createMockFromModule() type with its behaviour

Summary
@viceice Hm.. I was trying to run yarn build using your proposed patch (#13201), but the build fails. Apologies for pulling a new PR, but it was easier to implement the idea than to explain in comments.
Bellow I am playing with createMockFromModule() example from documentation:
const utils = jest.createMockFromModule('./utils').default;

test('is mock function?', () => {
  expect(jest.isMockFunction(utils.authorize)).toBe(true);
});

The test is passing. That’s why I have a feeling that the return type of createMockFromModule() should be Mocked<T>. One could use it like this: jest.createMockFromModule<typeof import('./utils')>('./utils').
Unfortunately that does not fix #13199 in the desired way, but I see another value in this approach: the type of createMockFromModule() gets aligned with its behaviour.
What do you think? (;
Test plan
I have to test the implementation bit more to make sure that types work as documented. So type tests will be added soon. (Current type test for jest.createMockFromModule() is failing, but that is expected.)

I disagree about that part - source of truth is this repo. Unless @types/jest is more correct, we shouldn't copy their approach - compatibility isn't in and off itself a goal (DT needs to align with us)

@viceice The PR has landed, but I do understand it did not solve your issue. Now someone should make similar change in @types/jest to align everything.
They have Mocked type defined, its shape is slightly different, not sure if that will work. Might be there will be a need to copy (or import?) Mocked from jest-mock. Uff.. After digging though all the complexity for this PR, I am not interested for more of the same (; Just trying to explain. I am not interested to work on @types/jest., but just ping me if something gets unclear. Glad to take a look.
By the way, you can also explicitly import all APIs from @jest/globals instead of relying on @types/jest. That's what I do in my projects. One dependency less – always good idea.

yeah, i think I'll remove that dependency too and manually declare the required globals until we refactored the whole solution (more that 1000 tests in hundreds of files)

That should work too. If you will find something missing or incorrect, please open an issue. In general Jest built-in types are in very good shape. Some niche features like jest.Mock type are not yet implemented, but they are in the plan. Easy to prioritise, if there is a use case.
By the way, it might be tricky to have utility types like jest.Mocked, jest.MockedClass, etc. in a manual .d.ts declaration. If you need them, most probably the implementation should to be copied from here:
https://github.com/facebook/jest/blob/0cfc2ad2991373324306c8daf962c41d0f37793c/packages/jest-globals/src/index.ts#L35-L57


Adjust confirmations for cached txs only

Coverage increased (+0.005%) to 80.987% when pulling ddd9107600c8be10b2b0c6394815d622f47098b3 on isocolsky:ref/confirmations into 811246a36fc448715c6a122f492e3ee01e9ab02c on bitpay:master.

Coverage increased (+0.005%) to 80.987% when pulling ddd9107600c8be10b2b0c6394815d622f47098b3 on isocolsky:ref/confirmations into 811246a36fc448715c6a122f492e3ee01e9ab02c on bitpay:master.


fix Zellic 3.4 Missing range checks in MulAdd chip

merge #690 before this
review https://github.com/scroll-tech/zkevm-circuits/compare/fix/lt-chip-range-check...fix/mul-add-range-check instead before #690 merge

\b run testool

seems got OOM killed on jenkins2

\b run testool

super_circuit_degree not enough

\b run testool

optimize the lookup
i think the API between MuAddChip and ExpCircuit is bad.    q_enable: impl FnOnce(&mut VirtualCells<'_, F>) -> Expression<F> + Clone,.   It looks like a very flexible API, but instead, the MuAddChip needs q_enable offset >= 8 at least due to its internal implementation details (pub range_check_64: UIntRangeCheckChip<F, { UIntRangeCheckChip::SIZE_U64 }, 8>,). It is implicit.   Changing it needs some work, so we will not do it this time.   But we need to add a comment above  OFFSET_INCREMENT = 8, to state that the OFFSET_INCREMENT should be max_of(HOW_MANY_ROWS_MUL_ADD_UNIT_NEEDS, HOW_MANY_ROWS_EXP_UNIT_NEEDS), here first is 8, and latter is 7. So the final value is 8.

i will take care of CI & merging later

@lightsing can have a look at the optimization comments


Compatibility with matplotlib 3.1.1

Hi,
I have experienced some problems when using the tfplot using the new version of matplotlib.
More details about the error are:
Traceback (most recent call last):
  File "tmp.py", line 169, in <module>
    main()
  File "tmp.py", line 160, in main
    summary = session.run(summary_op)
  File "/home/makansio/venv/tf1.14/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 950, in run
    run_metadata_ptr)
  File "/home/makansio/venv/tf1.14/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1173, in _run
    feed_dict_tensor, options, run_metadata)
  File "/home/makansio/venv/tf1.14/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1350, in _do_run
    run_metadata)
  File "/home/makansio/venv/tf1.14/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1370, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.UnknownError: AttributeError: 'FigureCanvasBase' object has no attribute 'tostring_argb'
Traceback (most recent call last):

  File "/home/makansio/venv/tf1.14/lib/python3.6/site-packages/tensorflow/python/ops/script_ops.py", line 209, in __call__
    ret = func(*args)

  File "/home/makansio/venv/tf1.14/lib/python3.6/site-packages/tfplot/ops.py", line 101, in _render_image
    image = figure.to_array(fig)

  File "/home/makansio/venv/tf1.14/lib/python3.6/site-packages/tfplot/figure.py", line 92, in to_array
    img = np.frombuffer(fig.canvas.tostring_argb(), dtype=np.uint8)

AttributeError: 'FigureCanvasBase' object has no attribute 'tostring_argb'

I have solved it by reinstalling an older version of matplotlib == 3.0.2
Best,
Osama

Thanks for reporting it. Let me fix this very soon

Upstream issue: matplotlib/matplotlib#12450

Fixed on master

Bugfixed released as 0.3.2


Undoing a change created after undo skips history

Not sure what's really going on, so the title may be incorrect.
Steps:

create a shape
move the shape
undo the move change
move the shape again
undo that move again

The last undo removes the shape completely, instead of undoing the last move.

Hi @dwelle, I was just working on https://github.com/excalidraw/excalidraw/pull/309 and I was facing the same bug. It is caused because here we are allowing to remove 2 elements in the history stack when we should only pop one element, put it into the redo stack, and grab last element of the history (previous second last) and restore it.
This is what happens:

Create a shape --> push entry --> [createShape]
Move the shape --> push entry --> [createShape, moveShape]
Undo the move change --> undoOnce --> pop --> [createShape] --> sees current state is equal to popped element --> pop --> []
Move the shape again --> [moveShape]
Undo that move again --> []

I suppose there are historical reasons why this logic was introduced (which I'm not aware). Looking at the code as it is today, I see no reason why we could have a simplified undoOnce like this:
undoOnce() {
    if (this.stateHistory.length === 0) {
      return null;
    }

    const currentEntry = this.stateHistory.pop();
    const entryToRestore = this.stateHistory[this.stateHistory.length - 1];

    if (currentEntry !== undefined) {
      this.redoStack.push(currentEntry);
      return this.restoreEntry(entryToRestore);
    }

    return null;
  }

Let me know if you want me to submit a PR where I can also revisit the redoOnce function 👍

For context, I've never written an undo/redo action before, so I tried something with pushing random stuff so that it kind of worked. Looks like I didn't get it right. Thanks @enzoferey for the correct version!

@vjeux As I wrote at the end of my comment, there are other not working as expected things and to be simplified things in the history. I will send a PR solving them in the next hours.


"context canceled" error after 2.7.6 to 2.7.7 upgrade

After influxdb2-2.7.6 to influxdb2-2.7.7 upgrade read queries time out, influxdb logs lvl=warn msg="internal error not returned to client" handler=error_logger error="context canceled" error.
Downgrading back to influxdb2-2.7.6 fixes the problem.
Steps to reproduce:
Execute a read query that returns 3,000,000+ rows with 7 columns with influxdb_client:
from(bucket:"B")
 |> range(start:<PHONE_NUMBER>, stop:<PHONE_NUMBER>)
 |> filter(fn: (r) => r._measurement == "M" and (r._field == "F1" or r._field == "F2" or r._field == "F3" or r._field == "F4" or r._field == "F5" or r._field == "F6"))
 |> pivot(rowKey: ["_time"], columnKey: ["_field"], valueColumn: "_value")
 |> keep(columns: ["_time","F1","F2","F3","F4","F5","F6"])
 |> map(fn: (r) => ({r with _time: uint(v: r._time)})).

Expected behaviour:
With influxdb2-2.7.6 the query returns data in 47 seconds. influxdb2-2.7.6 logs:
Jul 14 03:38:07 influxd-systemd-start.sh[19220]: ts=2024-07-14T02:38:07.041797Z lvl=info msg="Executed Flux query" log_id=0qNmSaHl000 compiler_type=flux response_size=237485590 query="..." stat_total_duration=50491.140ms stat_compile_duration=0.293ms stat_execute_duration=50490.799ms stat_max_allocated=576243031 stat_total_allocated=0

Actual behaviour:
With influxdb2-2.7.7 the query doesn't return anything, the client times out in 180 seconds. influxdb2-2.7.7 logs:
Jul 14 02:41:30 supernova influxd-systemd-start.sh[4208]: ts=2024-07-14T01:41:30.316178Z lvl=warn msg="internal error not returned to client" log_id=0qNdPszW000 handler=error_logger error="context canceled"

Environment info:

Ubuntu 22.04 LTS, Linux kernel 6.5.0-42-lowlatency x86_64
influxdb-client-1.44.0
influxdb2-2.7.7-1

Config:
query-concurrency = 32
query-queue-size = 32
storage-tsm-use-madv-willneed = true
flux-log-enabled = true
storage-cache-snapshot-write-cold-duration = "24h0m0s"
storage-compact-full-write-cold-duration = "24h0m0s"
storage-retention-check-interval = "24h0m0s"
storage-shard-precreator-check-interval = "24h0m0s"
storage-max-concurrent-compactions = 1
storage-series-file-max-concurrent-snapshot-compactions = 1

Can confirm this behaviour, what's worse is that influxdb keeps hogging the CPU after this happens. Downgrade to 2.7.6 fixed the problem.

Confirmation here. Downgrade back to 2.7.6 from 2.7.8 fixed the problem for me.

Confirmation here. Downgrading back to 2.7.6 fixed the problem for me and other issues like CPU hight usage.

May be related to https://github.com/influxdata/influxdb/issues/25226

May be related to #25226

I wish an InfluxDB developer commented on what is going on here and diagnosed the root cause in one mental step 🤷🏼♂😬

2.7.10 seems to have fixed the problems, at least for me.

I'm facing a similar issue on 2.7.4, with a query that uses a reduce.
ts=2024-11-05T11:43:22.710906Z lvl=warn msg="internal error not returned to client" log_id=0sebx8mG000 handler=error_logger error="context canceled"
on the influxdb script executor I get
Failed to execute Flux query

@rfontes17 - please upgrade to 2.7.10 and test. We had some fixes for Flux performance in 2.7.10.

Exact same problem here (same warning messages as OP described).
It was running fine for many months with 2.7.3 (via docker and used by OpenHAB as it’s persistence service). From one day to the next this error occurs, but just for some queries.
Also an upgrade to 2.7.10 has not fixed the issue.

Exact same problem here (same warning messages as OP described).
It was running fine for many months with 2.7.3 (via docker and used by OpenHAB as it’s persistence service). From one day to the next this error occurs, but just for some queries. Also an upgrade to 2.7.10 has not fixed the issue.

Currently using InfluxDB v2.7.10
Same for me, something with MAP is still low speed compared to the old version which is 2.7.3 or 2.7.6
|> map(fn: (r) => ({r with value: float(v: r._value)}))

This takes more than 30 seconds.
@max0x7ba  @davidby-influx
Best Regards


Fatal error: Malformed packet

I'm getting this error when trying to deploy via sftp. Any ideas on what this could be?

@cuweb I also have this since ssh2 was upgraded to 0.4.X.
There is a PR open to freeze ssh2 dependency to 0.3.x https://github.com/chuckmo/grunt-ssh/pull/92
In the meantime I had to use npm shrinkwrap.

@acramatte Awesome, thanks! :+1:

+1, I almost wrote a support ticket ot my CI :) Glad I found this issue.

+1, finally found an explanation to this issue.

Fixed in 0.12.1


CON-16: Test plan

Description
Originally, I wrote a test plan in https://github.com/GovStackWorkingGroup/bb-consent/pull/13 but had issues getting anyone to review it.
I think we should write one that we're all onboard with and share it with SolDevelo.
Related Issue
https://govstack-global.atlassian.net/browse/CON-16

I haven't actually seen a test plan in another BB, but to summarize on recent discussions, ideas and priorities, I think this could be a good candidate.

CC: @aaviksoo


File database relative path connection string issue

Not sure if this can be solved but an issue anyway
This is the configuration

When developing with local machine its expect the databases to reside in the same level of source code

When you deploy it, it expect the databases to be resided at

where it "ideally" it should expect the databases to reside at approot/src/{project_name}/
Of course I know there is workaround to put additional production appsettings.json and use different path.

@Eilon any insights on this feedback and what the "ideal" location for a database file would be at development time and on deployment?
FWIW, our SQLite provider simply uses AppContext.BaseDirectory (or equivalent) to resolve file name locations in the connection string.

I have no strong opinion on this, as long as it's not in wwwroot :smile:

App_Data? :stuck_out_tongue_winking_eye:

This really isn't an identity issue, it's more a configuration one. @Eilon where should this bug end up?

It a question/suggestion about what should the base path be at development and deployment so I don't think @blowdart means "configuration" in the aspnet/Configuration sense.
Maybe aspnet/hosting?

This issue was moved to aspnet/Hosting#639


fix to support modeladmin and/or embedding in page

When the form is used outside the normal page context (ie. in modeladmin or embedded in another page) the new email recipient can't rely on the CMS page session variable to identify the parent. So it dies. It's safer to skip relationships until the parent is properly linked. This happens after the first write, which seems to happen immediately, so those fields get filled anyway.

If these records are being created through a ModelAdmin, how are you assigning the FormID ?

form id already exists... the recipient belongs to a form/page.
i suppose if the user creates the page in modeladmin and doesn't save, they should not be able to add a recipient. this assumes the page was already saved. i suppose userdefinedform.php should be updated to check that the page has an id before adding the new recipient button.

Oh I see, you're actually creating the pages in modeladmin... not the recipients directly.

It looks like there's a huge number of formatting changes... makes it hard to review.

you asked me to change the formatting! lol

Oh my god I'm a retard. So I did.


Add an excludedDomains configuration, will skip matching to disallow

[x] Applies to both the target URL and any redirects it makes
[x] Entries in the collection are matched by both
Exact match to URI.getHost()
Ends-With match to "." + URI.getHost()
[x] Javadoc for the new configuration of the above
[x] A new CLI parameter for the above

I'll change it to use endsWith, and update the javadocs and CLI usage summaries to indicate this will be the logic that is applied 👍

I'll change it to use endsWith, and update the javadocs and CLI usage summaries to indicate this will be the logic that is applied 👍

I've tested manually with the command line tool!
./robots http://pdxcross.com/content --excludedDomains instagram.com
17:09:32.406 [main] DEBUG com.brandwatch.robots.RobotsFactory - Initializing factory with config: RobotsConfig{cacheExpiresHours=24, cacheMaxSizeRecords=10000, maxFileSizeBytes=196608, maxRedirectHops=5, defaultCharset=UTF-8, userAgent=robots, requestTimeoutMillis=10000, readTimeoutMillis=30000, excludedDomains=[instagram.com]}
17:09:32.462 [main] DEBUG com.brandwatch.robots.RobotsFactory - Initializing cache (maxSize: 10000, expires after: 24 hours)
17:09:32.483 [main] DEBUG c.b.robots.RobotsServiceImpl - Resolving robots URL for: http://pdxcross.com/content
17:09:32.488 [main] DEBUG c.b.robots.RobotsServiceImpl - Resolved robots URI to: http://pdxcross.com:80/robots.txt
17:09:32.533 [main] DEBUG c.brandwatch.robots.RobotsLoaderImpl - Loading: http://pdxcross.com:80/robots.txt
17:09:33.307 [jersey-client-async-executor-0] DEBUG c.b.robots.net.FollowRedirectsFilter - Redirect location present in domain exclusions: http://pdxcross.com:80/robots.txt -> https://instagram.com/pdxcrossrobots.txt
17:09:33.308 [main] DEBUG c.b.robots.RobotsServiceImpl - Disallowing: http://pdxcross.com/content
http://pdxcross.com/content: disallowed

I've tested manually with the command line tool!
./robots http://pdxcross.com/content --excludedDomains instagram.com
17:09:32.406 [main] DEBUG com.brandwatch.robots.RobotsFactory - Initializing factory with config: RobotsConfig{cacheExpiresHours=24, cacheMaxSizeRecords=10000, maxFileSizeBytes=196608, maxRedirectHops=5, defaultCharset=UTF-8, userAgent=robots, requestTimeoutMillis=10000, readTimeoutMillis=30000, excludedDomains=[instagram.com]}
17:09:32.462 [main] DEBUG com.brandwatch.robots.RobotsFactory - Initializing cache (maxSize: 10000, expires after: 24 hours)
17:09:32.483 [main] DEBUG c.b.robots.RobotsServiceImpl - Resolving robots URL for: http://pdxcross.com/content
17:09:32.488 [main] DEBUG c.b.robots.RobotsServiceImpl - Resolved robots URI to: http://pdxcross.com:80/robots.txt
17:09:32.533 [main] DEBUG c.brandwatch.robots.RobotsLoaderImpl - Loading: http://pdxcross.com:80/robots.txt
17:09:33.307 [jersey-client-async-executor-0] DEBUG c.b.robots.net.FollowRedirectsFilter - Redirect location present in domain exclusions: http://pdxcross.com:80/robots.txt -> https://instagram.com/pdxcrossrobots.txt
17:09:33.308 [main] DEBUG c.b.robots.RobotsServiceImpl - Disallowing: http://pdxcross.com/content
http://pdxcross.com/content: disallowed

https://github.com/BrandwatchLtd/robots/pull/34 should replace Travis and fix the build 🤞

https://github.com/BrandwatchLtd/robots/pull/34 should replace Travis and fix the build 🤞


D lang ?

<EMAIL_ADDRESS>

@igouy thx for bringing this up. Will do when I get a chance or if someone would offer help.

@igouy I learnt in the post that D was once included in ur site, is source code of D solutions still available somewhere? May I use them to jump start?  Btw, I've added D workflow here and implemented a coro-prime-sieve problem

Any dlang programs will be in these folders:
https://salsa.debian.org/benchmarksgame-team/archive-alioth-benchmarksgame/-/tree/master/contributed-source-code/shootout
They are old. I don't know if they still work, but of course you can use them.

Also
https://qznc.github.io/d-shootout/
Don't know if they are different.

Thanks!

Unfortunately, those code from 3+ years ago does not compile anymore : )  Looks like D lang has changed a lot.

Unfortunately, those code from 3+ years ago does not compile anymore : ) Looks like D lang has changed a lot.

Sorry.

Hi
https://github.com/hanabi1224/Programming-Language-Benchmarks
"This is inspired by The Computer Language Benchmarks Game, thanks to the creator."
Some people always read "thanks to the creator" to mean "thanks to God".
Perhaps better to say "thanks to the curator".
There's a new version of Chapel, maybe that would be a good addition to your project?
https://salsa.debian.org/benchmarksgame-team/benchmarksgame/-/issues/467
best wishes, Isaac

Hi Isaac, thx for ur suggestions, my answers are inline

Perhaps better to say "thanks to the curator"

Fixed, thx for pointing out the ambiguity.

new version of Chapel

Sure, I've just added chapel and bootstrapped it with 3 code files directly borrowed from ur site, plz let me know if there's any concern.

Some new D realizations under preparation. I just would like to ask @hanabi1224 : consider to change DMD compiler with GDC.
DMD is reference compiler and could not provide faster machine code as LDC and GDC. And comarison of LLVM (LDC) and GCC (GDC) worlds would be much more interesting in my opinion.

I would second @cyrusmsk
DMD is not a real/production compiler IMO, it's the language's reference compiler. It's useful for development because it compiles very fast but you'd not want to ship a DMD binary ideally.
Would be more interesting/useful to compare GDC and LDC (GCC + LLVM implementations)

<EMAIL_ADDRESS>
Btw the issue could be closed now - all problems have some D solution


I got a black window when I run freerdp-shadow-cli svr on Win7x64 .

As the title,when I run freerdp-shadow-cli svr on my Win7X64 system, I got a black window,after debug,I got the error at:
win_wds.c:int win_shadow_wds_init(winShadowSubsystem* subsystem):
hr = subsystem->pSharingSession->lpVtbl->put_ColorDepth(subsystem->pSharingSession, 32);
hr is E_INVALIDARG One or more arguments are invalid.
I tryed replace 32 as 24 \16\8 only 16\8 is OK, I cannot found the doc at msdn about the param, so i donnot know if the magic number 32 is ok.
when I try 16, another  problem come...  svr is running but... not of problems
So, I just wonder anyone can provide a runable client&svr with runable cmd...
fresh just want got a runable client&svr runable without know any other... like a hello world..

@aijyo sorry for the late reply, but windows shadow server was not tested for some time.
could you describe the issues remaining after the fix you mention?

@akallabeth Sorry for the late reply due to the National Day,  after fix the color depth problem, I got a nego error , I donnot knonw how to fix it, but when I tryed at home, everything is okay, but a black window still, does the rdp support client&svr run at a screen？ or to test it, must have two computer?  follow is the info:
[09:57:07:603] [6632:00002044] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[09:57:07:605] [6632:00002044] [INFO][com.freerdp.client.common.cmdline] - loading channelEx encomsp
[09:57:07:607] [6632:00002044] [INFO][com.freerdp.client.common.cmdline] - loading channelEx remdesk
[09:57:07:607] [6632:00002044] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[09:57:07:607] [6632:00002044] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[09:57:07:608] [6632:00002044] [INFO][com.freerdp.client.common.cmdline] - loading channelEx drdynvc
[09:57:07:609] [6632:00002044] [ERROR][com.freerdp.channels.encomsp.client] - Unhandled event type 0
[09:57:13:417] [6632:00002044] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 0: No error
[09:58:00:737] [6632:00002044] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[09:58:00:755] [6632:00002044] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[09:58:00:756] [6632:00002044] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure
[09:58:00:756] [6632:00002044] [INFO][com.freerdp.server.shadow.win] - OnConnectionResult: -1
[09:58:00:770] [6632:00002044] [INFO][com.freerdp.server.shadow.win] - freerdp_connect: 0

@akallabeth  I have tryed use wfreerdp-client connect sfreerdp-server, everthing is okay, according to the output info but client just got a gray window with a mouse as the freerdp icon:
svr out put is(I changed the 3389 port as 5900 because of 3389 be used by others):
[10:30:54:615] [6732:00001c34] [INFO][com.freerdp.core.listener] - Listening on :::5900
[10:30:54:615] [6732:00001c34] [INFO][com.freerdp.core.listener] - Listening on <IP_ADDRESS>:5900
“sfreerdp-server.exe”(Win32):  已加载“C:\Windows\SysWOW64\nlaapi.dll”。无法查找或打开 PDB 文件。
“sfreerdp-server.exe”(Win32):  已加载“C:\Windows\SysWOW64\NapiNSP.dll”。无法查找或打开 PDB 文件。
“sfreerdp-server.exe”(Win32):  已加载“C:\Windows\SysWOW64\pnrpnsp.dll”。无法查找或打开 PDB 文件。
“sfreerdp-server.exe”(Win32):  已加载“C:\Windows\SysWOW64\dnsapi.dll”。无法查找或打开 PDB 文件。
“sfreerdp-server.exe”(Win32):  已加载“C:\Windows\SysWOW64\winrnr.dll”。无法查找或打开 PDB 文件。
“sfreerdp-server.exe”(Win32):  已加载“C:\Windows\SysWOW64\bcryptprimitives.dll”。无法查找或打开 PDB 文件。
[10:32:36:689] [6732:00002328] [INFO][com.freerdp.server.sample] - We've got a client (local)
[10:32:36:689] [6732:00002328] [INFO][com.freerdp.core.connection] - Client Security: NLA:1 TLS:1 RDP:0
[10:32:36:689] [6732:00002328] [INFO][com.freerdp.core.connection] - Server Security: NLA:0 TLS:1 RDP:1
[10:32:36:689] [6732:00002328] [INFO][com.freerdp.core.connection] - Negotiated Security: NLA:0 TLS:1 RDP:0
[10:32:38:292] [6732:00002328] [INFO][com.freerdp.core.connection] - Accepted client: QD-PC
[10:32:38:292] [6732:00002328] [INFO][com.freerdp.core.connection] - Accepted channels:
[10:32:38:292] [6732:00002328] [INFO][com.freerdp.core.connection] -  cliprdr
[10:32:38:292] [6732:00002328] [INFO][com.freerdp.core.gcc] - Active rdp encryption level: NONE
[10:32:38:292] [6732:00002328] [INFO][com.freerdp.core.gcc] - Selected rdp encryption method: NONE

@aijyo could you post the command line of the client?

@aijyo could you post the command line of the client?
client command line is: (I restore the port now)
wfreerdp.exe -w:800 -h:600  -cert-ignore -rfx -v:localhost:3389

svr problem now is:
0x75C5C54F (KernelBase.dll) (freerdp-shadow-cli.exe 中) first chance exception:  0x000006BA: RPC server not available。。

@aijyo Ok, missed you're using sfreerdp-server, that one is a sample server that only sets a gray background with a FreeRDP logo as mouse, so that is working ;)
Your second post shows you're using the correct binary freerdp-shadow-cli.exe and that one seems to still be broken?
Best run a debug build in a debugger to check where it breaks down.
freerdp-shadow-cli  out put as follow(ignor the Chinese, that's the RPC error i'll find out):
[15:29:27:760] [7728:00001e34] [INFO][com.freerdp.server.shadow.win] - width: 0 height: 0
[15:29:27:760] [7728:00001f04] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[15:29:27:760] [7728:00001f04] [INFO][com.freerdp.client.common.cmdline] - loading channelEx encomsp
[15:29:27:760] [7728:00001f04] [INFO][com.freerdp.client.common.cmdline] - loading channelEx remdesk
[15:29:27:760] [7728:00001f04] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[15:29:27:760] [7728:00001f04] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[15:29:27:760] [7728:00001f04] [INFO][com.freerdp.client.common.cmdline] - loading channelEx drdynvc
[15:29:27:760] [7728:00001f04] [ERROR][com.freerdp.channels.encomsp.client] - Unhandled event type 0
线程 0x1edc 已退出，返回值为 0 (0x0)。
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
线程 0x1e94 已退出，返回值为 0 (0x0)。
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
[15:29:33:130] [7728:00001f04] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 0: No error
[15:29:33:691] [7728:00001f04] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[15:29:33:691] [7728:00001f04] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[15:29:33:691] [7728:00001f04] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure
[15:29:33:691] [7728:00001f04] [INFO][com.freerdp.server.shadow.win] - OnConnectionResult: -1
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
[15:29:33:691] [7728:00001f04] [INFO][com.freerdp.server.shadow.win] - freerdp_connect: 0
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
线程 0x1f04 已退出，返回值为 0 (0x0)。
“freerdp-shadow-cli.exe”(Win32):  已加载“C:\Windows\SysWOW64\wship6.dll”。无法查找或打开 PDB 文件。
[15:29:34:378] [7728:00001e34] [INFO][com.freerdp.core.listener] - Listening on :::3389
[15:29:34:378] [7728:00001e34] [INFO][com.freerdp.core.listener] - Listening on <IP_ADDRESS>:3389
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。
0x753DC54F (KernelBase.dll) (freerdp-shadow-cli.exe 中)处的第一机会异常:  0x000006BA: RPC 服务器不可用。。

@aijyo Ok, missed you're using sfreerdp-server, that one is a sample server that only sets a gray background with a FreeRDP logo as mouse, so that is working ;)
Your second post shows you're using the correct binary freerdp-shadow-cli.exe and that one seems to still be broken?
Best run a debug build in a debugger to check where it breaks down.

I donnot got any breakdown, but "Protocol Security Negotiation Failure" and some times RCP not available.  when client connected, I can move mouse through client with a black client window.

@akallabeth  When I run Remote Desktop Services at 3389 and start freerdp-shadow-cli at 5900,RPC problem resolved,  but the problem still, something must be wrong according to the output " Protocol Security Negotiation Failure",
as the result of transport_read_pdu return -1 at
FreeRDP-master\libfreerdp\core\nego.c(547):	status = transport_read_pdu(nego->transport, s);
because of transport_read_layer_bytes returned -1:
FreeRDP-master\libfreerdp\core\transport.c(659):	    && (status = transport_read_layer_bytes(transport, s, 2 - position)) != 1)
callstack as follow ,something wrong:

freerdp2.dll!transport_read_layer(rdp_transport * transport, unsigned char * data, int bytes) 行 558	C
freerdp2.dll!transport_read_layer_bytes(rdp_transport * transport, _wStream * s, unsigned int toRead) 行 616	C
freerdp2.dll!transport_read_pdu(rdp_transport * transport, _wStream * s) 行 659	C
freerdp2.dll!nego_recv_response(rdp_nego * nego) 行 547	C
freerdp2.dll!nego_attempt_tls(rdp_nego * nego) 行 484	C
freerdp2.dll!nego_send(rdp_nego * nego) 行 790	C
freerdp2.dll!nego_connect(rdp_nego * nego) 行 160	C
freerdp2.dll!rdp_client_connect(rdp_rdp * rdp) 行 276	C
freerdp2.dll!freerdp_connect(rdp_freerdp * instance) 行 192	C
freerdp-shadow-subsystem2.dll!shw_client_thread(void * arg) 行 177	C

Due to the  "Protocol Security Negotiation Failure"  error I wonder if there some problem with the RDP COM at my local machine, but I can receive OnWindowOpen and OnWindowClose at:
FreeRDP-master\server\shadow\Win\win_wds.c(246):static HRESULT STDMETHODCALLTYPE Shadow_IRDPSessionEvents_Invoke
Which is Invoked by the rdpcom, so the rdp is also okay?
I wonder....  If freerdp-shadow-cli is also only support a mouse event ,Image is not available...so, when client connected, a black window with mouse support...

Everthing is okay now, according to issue and code , I found out that windows server is not finished now...... so...

According to the issue and coding, the windows RDP server seems to be not finished...  so...

I got a runable RDP client && svr through codeproject,  i'll find out why ...

@aijyo could you please break down your issues?

Authentication issues - try with -auth to disable authentication, check if it works
Everything else: Please give some details, guessing does not help much here.

@aijyo could you please break down your issues?

Authentication issues - try with -auth to disable authentication, check if it works
Everything else: Please give some details, guessing does not help much here.

Need time to break down ...
And after various attempts， there are two problem left:
First:
hr = subsystem->pSharingSession->lpVtbl->put_ColorDepth(subsystem->pSharingSession, 32);
32 not available, so I comment it out
Second:
I got a black window at client with mouse move is okay
Can U give me a runable client and server  param...
I am currently running a runable  project(client&server)  from codeproject to understand RPD, and then I'll find out the problem, ( Currently I just know It does not works  or It work with a black window... without any any warning or error)

For the black screen try with another bit depth (24, 16, ...) instead of the not working 32 (you're commenting out your framebuffer source configuration there, so you'll never see anything)
As for auth, would need your /buildconfig

For the black screen try with another bit depth (24, 16, ...) instead of the not working 32 (you're commenting out your framebuffer source configuration there, so you'll never see anything)
As for auth, would need your /buildconfig

I donnot known how to give U my buildconfig, I download the src code,  config it with cmake gui(generate with server, default config  server not include), and then got *.sln open it with vs2013 ... complie & run... so  what's the meanning of /buildconfig...

wfreerdp.exe /buildconfig >somefile.txt

I got a empty file after run this cmd...

then you have a very old version of freerdp.

I will confirm it tomorrow. Thanks

then you have a very old version of freerdp.

follow is my build config , print by wfreerdp-client(wfreerdp.exe project):
This is FreeRDP version 2.0.0-dev4 (n/a)
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_EXECINFO_H= HAVE
_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_SYSLOG_H= HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H=
HAVE_SYS_SELECT_H= HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_TM_GMTOFF= HAVE_UN
ISTD_H= WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 W
ITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WI
TH_CLIENT_INTERFACE=OFF WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBU
G_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=
OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NE
GO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP
=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_R
FX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DE
BUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OF
F WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND
=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE
=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_FAAC=OFF WITH_FAAD2=OFF WI
TH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_GSTREAMER_0_10=O
FF WITH_ICU=OFF WITH_IPP=OFF WITH_JPEG=OFF WITH_LAME=OFF WITH_LIBRARY_VERSIONING
=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=
ON WITH_MBEDTLS=OFF WITH_MEDIA_FOUNDATION=ON WITH_NATIVE_SSPI=ON WITH_OPENH264=O
FF WITH_OPENSSL=ON WITH_PROFILER=OFF WITH_SAMPLE=ON WITH_SERVER=ON WITH_SERVER_C
HANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SSE2=ON WITH
_THIRD_PARTY=OFF WITH_WIN8=ON WITH_WINMM=OFF WITH_X264=OFF
Build type:          Release
CFLAGS:              /DWIN32 /D_WINDOWS  /Gd /W3
Compiler:            MSVC, 18.0.40629.0
Target architecture: x86

then you have a very old version of freerdp.

at buildflags.h I found follow:
#define CFLAGS "/DWIN32 /D_WINDOWS  /Gd /W3"
#define COMPILER_ID "MSVC"
#define COMPILER_VERSION "18.0.40629.0"
#define TARGET_ARCH "x86"
#define BUILD_CONFIG "BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_EXECINFO_H= HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_SYSLOG_H= HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H= HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_TM_GMTOFF= HAVE_UNISTD_H= WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_FAAC=OFF WITH_FAAD2=OFF WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_GSTREAMER_0_10=OFF WITH_ICU=OFF WITH_IPP=OFF WITH_JPEG=OFF WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_MEDIA_FOUNDATION=ON WITH_NATIVE_SSPI=ON WITH_OPENH264=OFF WITH_OPENSSL=ON WITH_PROFILER=OFF WITH_SAMPLE=ON WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SSE2=ON WITH_THIRD_PARTY=OFF WITH_WIN8=ON WITH_WINMM=OFF WITH_X264=OFF"
#define BUILD_TYPE "Release"

@aijyo you need to set the build configuration with CMake.

I config it with cmake-gui ... now I donnot known what's wrong ... and how to fix it.   I'm reading the code, try to understand something ... I cannot find any doc about how to connect rdpsession, and negotiation proto.  without know much about OpenSSL also.  I don't want to give up freeRDP using rdp ocx in the next project.

@aijyo did you configure the CMAKE_BUILD_TYPE?

@akallabeth
I debug the exe got something as follow...
I set a break point at nego_attempt_tls:nego_recv_response
1、when break down the net state is 1(tcp connect seems to be okay)
2、when break down at
freerdp2.dll!transport_read_layer(rdp_transport * transport, unsigned char * data, int bytes) line 545
net state is 1
WSAGetLastError() == 10035
3、After retry status = BIO_read(transport->frontBio, data + read, bytes - read);
net state switch to 3
WSAGetLastError() == 10054

@aijyo did you configure the CMAKE_BUILD_TYPE?

I cannot find CMAKE_BUILD_TYPE config entry in Cmake-gui, So  I use default CMAKE_BUILD_TYPE Configed in cmakelist.txt (as default It seems to be release, so it's okay? if necessary I‘ll change it to debug)’

@aijyo

There are advanced cmake options, check the UI (I don't use it, cmdline only for me ;))
check shw_authenticate if the authentication of the client succeeds (or if it is called at all)

authenticate

I think it is a bit misunderstood about the problem,
shw_authenticate be breakpoint not triggered, as follow

But the problem does not seem to be caused by authenticate,just like the follow img show, after BIO_wait_read wait 100ms, the TCP disconnected(when I run same code at my win10 computer, the problem does not exist...everthing is okay), I'm not familiar with OpenSSL ... The TCP disconnected result shw_client_thread exit, It seems to te important...

@aijyo Ah, ok. Which version of OpenSSL do you use on these machines? Might be as simple as that they can not agree on a common cipher suite.

@aijyo Ah, ok. Which version of OpenSSL do you use on these machines? Might be as simple as that they can not agree on a common cipher suite.

That's also what I am worried about, I'm using OpenSSL Version: 1.1.2

@akallabeth I reinstall my system, okay  now everthing is "ok"  but the problem "ERROR][com.freerdp.core.fastpath] - Fastpath update New Pointer [b] failed, status 0" as I rementioned in another issue.......


Forward signals to qemu process

nsenter does not forward signals to its child. Therefore, register
handlers to do so, when libvirt sends signals to QEMU.

/cc @fabiand FYI

Awesome catch, @rmohr .


Fixed kubeVersion comparision

This PR changes the kubeVersion so that Kubernetes versions with suffixes (like v1.23.4-r0-CCE22.5.1)  are properly detected. Otherwise you will receive and error message like
Error: INSTALLATION FAILED: chart requires kubeVersion: >= 1.19.0 which is incompatible with Kubernetes v1.23.4-r0-CCE22.5.1

Contributing a Chart / update to an existing Chart

[x] Run helm lint on the chart dir.
[ ] (Update) Bump the Chart.yaml version before merging, to release it as a new version.
[ ] (Update) Replace the annotations on the Chart.yaml with:

artifacthub.io/changes - the changes introduced on the PR with the appropiate format.
artifacthub.io/images - the updated tag on the cs3org/revad image.

[ ] (Update) If the PR includes new configurable parameters in the chart's values.yaml. Add documentation in the appropiate README.

Hi @d7oc 👋
Thanks a lot for your contribution! Could you please extend the change to the revad chart as well and write [skip ci] on the commit message, so your change doesn't require tagging a whole new version of both charts?

Hi @SamuAlfageme 👋
changes done.

@d7oc thanks a bunch! 🚀


Add basic support for Markdown

Allows you to create files  with .markdown or .md extensions that will be compiled to HTML.
Specifying which layout to use and the layout section is done through YAML front matter. For example, you might have a layout like this:

    ...

        @yield('body')

If that layout was named master in the _layouts folder, you could create a Markdown template that used this layout like so:
---
extends: _layouts.master
section: body
---

# My awesome heading!

My awesome content!

There is also support for custom front matter variables, so given a template like:

    ...

        @yield('body')

        @if (isset($footer))
            {{ $footer }}
        @endif

...and a Markdown file like this:
---
extends: _layouts.master
section: body
footer: 'My custom footer content'
---

# My awesome heading!

My awesome content!

...you'd get this output:

    ...

My awesome heading!

My awesome content!

        My custom footer content

Questions

Right now this only support replacing a single section in a Blade template, so you couldn't have a Markdown file with two chunks of content that are meant to be yielded in two different parts of the parent template.
I don't know if this actually matters at all, no other static site generator I've ever seen supports this either, but I'm curious what people think. The main reason this is important is because the current approach of using front matter is not forwards compatible with supporting multiple sections. We'd have to use @section and @endsection directly in the Markdown and parse it out ourselves.

Right now all variables share the same namespace/scope. So any variables defined in the root config.php can potentially collide with variables set in the YAML, and extends and section become reserved variable names because they are used to tell the Markdown handler what Blade template and section should be used.
I don't know what I really think here. On one hand, from a purist perspective it would be better to keep everything separately scoped, but on the other hand, trying to do that would likely make it gross to work with. Instead of just being able to do {{ $myPageVariable }} you'd have to start doing things like {{ $pageVariables['myPageVariable'] }} and `{{ $config['myConfigVariable'] }}.
It's not totally horrible on it's own but it's one of many small aesthetic decisions that could eventually pile up and muddy things up.

I haven't dug into Jigsaw enough to comment intelligently on this one, but supporting multiple @yields seems worthwhile on the face of it. But if implementation is nasty, it may not be worth it.

My vote would be to avoid scoping and leave it to the user to handle it through prefixes if they want...so long as there's clear behavior about which variable would win out in the case of a collision. This could even, perhaps, be a feature rather than a bug—if the page variable has primacy over a config variable, it could be an easy way to conditionally override a config variable.


Upgrade to faraday 0.10?

First: Thank you for restforce, it saves me loads of headaches and I appreciate all the hard work you guys do.
I am working on upgrading my app to Rails 5; any chance of supporting the most recent version of Faraday as your dependency?
Thank you!

@alexluke is on it in #278 - should get it merged soon :heart:

Done!

thank you!


Fixed repo link in about NavCoin Core Window

Fixes #313

@red010b37 Can you review this when you have the time?


Issue 198 repair attempt full screen modal

Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[x] The pull request title has an issue number
[ ] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
[Is there anything in particular in the review that I should be aware of?]

Nice work!
For mobile devices, could you make the modal take the entire screen instead of still being a modal.
Example:

It's still a modal but it takes about the full width of the screen, is that good or should it be a separate page on mobile view? The modal uses headlessui's dialog component and it seems that cant take up the whole screen.
@dct0 ?


play.sqlc.dev is down

Version
1.18.0
What happened?
This site can’t be reachedplay.sqlc.dev’s server IP address could not be found.
Relevant log output
No response
Database schema
No response
SQL queries
No response
Configuration
No response
Playground URL
No response
What operating system are you using?
No response
What database engines are you using?
No response
What type of code are you generating?
No response

We're in the middle of migrating domains and DNS settings. Should be cleared up soon.

And we're back

Thank you. Nice touch with the panic label 🤣


Connection established but GetAllSessions finds nothing until a little time has passed.

Note that I am Starting By Config (if that matters).
I have been building my app, and I noticed that after a client connects to the server, and then sends a message immediately after, the ExecuteJsonCommand fires, however, GetAllSessions/GetSessions produced zero results until a small period of time has elapsed (less than 2 seconds).
From the samples, I added the following code, and it too revealed zero connections after a connection was established..
void webSocketNewSessionConnected (WebSocketSession session) 		{ 			int x = 0; 			foreach (var s in GetAllSessions()) { 				x++; 			} 			Console.WriteLine ("foreach count: {0} SessionCount: {1}", x, SessionCount); 			//outputs: foreach count: 0 SessionCount: 1 		}
I hope I'm missing something because that is a big issue for me.

disableSessionSnapshot="false"


Create .readmeFileLocally

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Hey @kadiyalabhargavi
Looks like this PR was supposed to be made on your own fork.
This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.