Fix route cache service key.

Fix https://github.com/istio/istio/issues/37356
Route cache uses a copy of services when constructing key, which does not have attributes populated. Furthermore it uses hostname for resource dep compute, which should really be service name. Also cache assertion does not really work for rds cache for now and this PR fixes that.

@bianpengyuan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d270053720349c714b690ab06b01bee5c18cc137
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-assertion_istio

/test integ-assertion_istio

@bianpengyuan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
abd9a35ba1ba1cadeb25f34d378bf8b4980d1b0e
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
abd9a35ba1ba1cadeb25f34d378bf8b4980d1b0e
link
true
/test release-notes_istio

integ-assertion_istio
abd9a35ba1ba1cadeb25f34d378bf8b4980d1b0e
link
false
/test integ-assertion_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-assertion_istio

/test integ-assertion_istio

/retest

In response to a cherrypick label: new pull request created: #37384

In response to a cherrypick label: new pull request created: #37385


add typ header to vcjwt

Overview
Closes #82 and #88

[!WARNING]
CI lint will continue to fail due to undocumented exported functions. will be putting up a handful of issues to address

https://github.com/TBD54566975/web5-go/issues/90


Undo run end filter performance regression

Which issue does this PR close?

Related to https://github.com/apache/arrow-rs/pull/6675
Rationale for this change

After running some benchmarks it turned out that the changes introduced in my previous PR were quite slow. This should bring it back closer to how it was before.
run_ends_len = 64       time:   [3.9878 µs 4.0035 µs 4.0204 µs]
                        change: [-1.3684% -0.4485% +0.5210%] (p = 0.34 > 0.05)
                        No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

run_ends_len = 512      time:   [56.654 µs 57.076 µs 57.458 µs]
                        change: [-1.7583% -1.0124% -0.2300%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

run_ends_len = 1024     time:   [151.37 µs 151.83 µs 152.34 µs]
                        change: [-4.5739% -3.1197% -1.6545%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  1 (1.00%) low mild
  4 (4.00%) high mild
  6 (6.00%) high severe

run_ends_len = 64       time:   [2.7373 µs 2.8041 µs 2.8841 µs]
                        change: [-32.545% -31.650% -30.574%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
  6 (6.00%) high mild
  8 (8.00%) high severe

run_ends_len = 512      time:   [4.5291 µs 4.5413 µs 4.5548 µs]
                        change: [-91.973% -91.902% -91.821%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) high mild
  5 (5.00%) high severe

run_ends_len = 1024     time:   [6.3687 µs 6.4206 µs 6.4869 µs]
                        change: [-95.802% -95.750% -95.693%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  4 (4.00%) high mild
  6 (6.00%) high severe

What changes are included in this PR?
I subtract the difference from end to keep it in bounds.

Are there any user-facing changes?
No

I apologize for being denise @delamarch3  -- but I spent a while trying to find the benchmarks you are running and I couldn't figure out which they were. Is it the filter_kernels?

I'll try to add one into filter_kernels

I'll try to add one into filter_kernels

Thank you -- if you could do so as a separate PR that would be most helpful (so it is easy to compare with these changes) 🙏

I've run the filter_kernel benchmark I added for the run array in https://github.com/apache/arrow-rs/pull/6706 with the different approaches, here are the results I get:
for pred in filter_values
    .iter()
    .skip(start as usize)
    .take((end - start) as usize)
{
    count += R::Native::from(pred);
    keep |= pred
}

Benchmarking filter run array (kept 1/2): Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 52.1s, or reduce sample count to 10.
filter run array (kept 1/2)
                        time:   [542.98 ms 549.50 ms 556.59 ms]
Found 10 outliers among 100 measurements (10.00%)
  7 (7.00%) high mild
  3 (3.00%) high severe

Benchmarking filter run array high selectivity (kept 1023/1024): Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 54.3s, or reduce sample count to 10.
 You may wish to increase target time to 53.5s, or reduce sample count to 10.
filter run array low selectivity (kept 1/1024)
                        time:   [536.14 ms 540.44 ms 545.14 ms]
Found 11 outliers among 100 measurements (11.00%)
  6 (6.00%) high mild
  5 (5.00%) high severe

for _ in start..end {
    if let Some(pred) = preds.next() {
        count += R::Native::from(pred);
        keep |= pred
    }
}

filter run array (kept 1/2)
                        time:   [598.70 µs 601.93 µs 605.25 µs]
                        change: [-99.892% -99.890% -99.889%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high severe

Benchmarking filter run array high selectivity (kept 1023/1024): Collecting 100 samples in estimated 6.0573 s (15k iterations
filter run array high selectivity (kept 1023/1024)
                        time:   [386.55 µs 388.17 µs 389.91 µs]
                        change: [-99.931% -99.930% -99.929%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) high mild
  2 (2.00%) high severe

filter run array low selectivity (kept 1/1024)
                        time:   [239.93 µs 240.46 µs 241.04 µs]
                        change: [-99.956% -99.955% -99.955%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
  6 (6.00%) high mild
  6 (6.00%) high severe

These two are similar but after running a few times the low selectivity benchmark seems slightly faster in this one
end -= end.saturating_sub(filter_values.len() as u64);
for pred in (start..end).map(|i| unsafe { filter_values.value_unchecked(i as usize) }) {
    count += R::Native::from(pred);
    keep |= pred
}

filter run array (kept 1/2)
                        time:   [581.12 µs 584.01 µs 586.90 µs]
                        change: [-2.5195% -1.1178% +0.1036%] (p = 0.11 > 0.05)
                        No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

Benchmarking filter run array high selectivity (kept 1023/1024): Collecting 100 samples in estimated 5.5900 s (15k iterations
filter run array high selectivity (kept 1023/1024)
                        time:   [359.79 µs 361.40 µs 363.47 µs]
                        change: [-7.7904% -5.5816% -3.1503%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
  3 (3.00%) high mild
  11 (11.00%) high severe

filter run array low selectivity (kept 1/1024)
                        time:   [209.87 µs 210.45 µs 211.09 µs]
                        change: [-13.950% -13.255% -12.616%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe

for _ in start..end {
    if let Some(pred) = preds.next() {
        count += R::Native::from(pred);
        keep |= pred
    }
}

Maybe you could try something like (two minor changes)?
    for pred in preds.take(end-start) {
        count += R::Native::from(pred);
    }
    let keep = count > 0;
}

I'm not sure calling take on each iteration will work because it takes ownership of the Iterator so it needs to be reassigned on each run_ends iteration, but then it will always take on the first n elements, unless you had something else in mind? I did try BitIterator::new(filter_values.values(), start, end - start) to try achieve something similar but It turned out to be slower.
I had to create a temp variable with the count for assigning keep after the loop, ie let keep = count > count_before, for the algorithm to still be correct, but this was also slower.

For me looks good - I feel somehow there probably should be more performance on the table.
I believe the reason is BitIterator is currently doing the same as filter_values.value_unchecked so for using the iterator it is only the extra cost of the bounds check.
I think it should be possible to improve BitIterator (use bitshift rather than using the current index) and use unwrap_unchecked() to be slightly more performant than the current solution.

Thanks @delamarch3


Update README.md

Better promote the concept of 'operator'.

Thanks for pointing this out, but since there were a couple other changes necessary I just merged in https://github.com/coreos/prometheus-operator/commit/4b037488ba3e46804b462f087588054e7cf86a06


[clojure mode] Further clean-up.

This PR:

Highlights special forms and core symbols as keyword, following the same convention used by the Common Lisp mode and Scheme mode;
Removes indentation rules for non-core symbols to stay focused on covering more core symbols for indentation.

Removes indentation rules for non-core symbols to stay focused on covering more core symbols for indentation.

I don't quite get this—how does removing those symbols help cover more core symbols?

Oh, my bad. I should have articulated my thoughts more clearly.
My focus for this round of refactoring is on special forms and core symbols and the goal is to make syntax highlighting more consistent (by using the same style) and indentation as complete as possible (by covering the remaining core symbols). I expect this to take a little while given the number of remaining symbols in the core namespace and therefore I would like to be "laser-focued" and not distracted by other concerns (i.e., one namespace at a time).
The next step will be thinking about covering symbols from non-core namespaces. I don't know if we should yet since both the Common Lisp mode and the Scheme mode don't seem to do so. If we somehow decide to cover these namespaces, I would like to apply the same approach and do it one namespace at a time while maintaining the same level of consistency and completeness.
So that's the plan and that's why I removed those symbols for now in order to add of them back later (maybe) with better quality of coverage.

both the Common Lisp mode and the Scheme mode don't seem to do so

The CL mode has a heuristic for (see assumeBody) for when to use body-style indentation versus argument-style indentation. Maybe something like that would be appropriate here too? Though I don't know what the Clojure community's conventions look like.
I guess the number of removed symbols in this PR is small, and any regression it might cause obscure, so I'll go ahead and merge.

The CL mode has a heuristic for (see assumeBody) for when to use body-style indentation versus argument-style indentation. Maybe something like that would be appropriate here too?
Yes and that's exactly what I've been thinking about doing (instead of completely relying on a static list of symbols). The Common Lisp mode is a very good example and starting for this. I've been experimenting with tweaking it to syntax highlight Clojure code and it feels very promising. I might end up re-writing the Clojure mode based on the code of the Common Lisp mode since it is relatively easier to reason about than the current Clojure mode code.


Airflow deployment

Create an airflow deployment similar to the current git actions deployment. The deployment should support

[ ] generation of a dag running the pipeline

[ ] ideally this dag should contain tasks representing resources, in the correct dependency. If not currently possible, start with just running the pipeline in a task before defining next steps.

[ ] credentials should be passed into airflow or the appropriate user actions/guidance to take should be offered on CLI similar to the other deployment command.

ad 2. do you want to run the tasks in parallel or one by one? in the second case you can decompose any source into DAG tasks but sacrificing various optimizations ie. dlt can run any number of async/threaded data items from any number of resources in parallel, it will also get data only etc.
in the first case we would need to merge state and load packages. it would be the best to brainstorm how to do it


enhancement: [cli] target specific tests with -s or --steps.

Also auto-init's on deploy command
Proposed changes

Issues for these changes

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (changes to code, which do not change application behavior)

Checklist

[ ] I have filled out this PR template
[ ] I have read the CONTRIBUTING doc
[ ] I have added automated tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix mocha issues/pr URLs

Requirements
Description of the Change
Fix mocha issues/pr URLs

Alternate Designs
Just let the links 404
Why should this be in core?
people want to read the changelog of mocha on mocha, not via a plugin
Benefits
People will be able to click on the links, and get to the content they expected
Possible Drawbacks
More traffic to github issues might increase the overall cost to github
Applicable issues
N/A

Coverage increased (+0.05%) to 89.674% when pulling 967aaee2e3ff3072027b527a16e0f42cf48a3840 on graingert:patch-1 into d69bf14a860235e7ceb50a50c2072dddd1ef8520 on mochajs:master.

Thanks for catching this!


Compiling in Windows using MinGW

Hi
Having hard time compiling using MinGW.
First. generating makefiles had problem with if(CMAKE_NO_STD_NAMESPACE), for some reason this check fails, although I do have std. Anyway I've commented this out and created the makefiles.
The problem now is that make fails on\libs\Lomse\include/lomse_events_dispatcher.h:49:14: error: 'thread' in namespace 'std' does not name a type  49 | typedef std::thread EventsThread;
and some other similar errors on mutax.
I have installed mingw32 pthreads but it doesnt work.
Were you able to successfully compile it using MinGW ?

No, sorry. I never compiled the code using cmake in Windows, neither using windows tools nor MinGW. I only build the library in Linux and cmake buils the makefile withou problems. But in windows I use lomse including its sources in my app. LenMus, therefore I never tried cmake there. Probably it needs some fixes to build in Windows. The cmake file for lenmus, at https://github.com/lenmus/lenmus/blob/master/CMakeLists.txt builds the app using lomse sources in Windows under the ubuntu subsystem.

Lomse build instructions for Windows 10
PR #236 partially fixes cmake script for building in Windows, as I explain here.
To build in Windows, open a Command Window appropiate for x64 build: "x64 Native Tools Command Prompt"
Create build directory:
cd path\to\lomse
rmdir build-area /S /Q
mkdir build-area && cd build-area

Create makefile and build:

For building the static library:

cmake -G "Ninja" ..
ninja

You will see many warnings, mainly complaining about usafe function, such as:

'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS.

There are also a couple of other warnings that I have to fix.
The unit tests runner program testlib.exe is built and is linked against zlib.lib and libpng.lib but when executed, the testlib.exe program complains of not finding zlib.dll and libpng.dll (!!!???). Copying these DLLs to build folder solves the problem and the tests run. There are four failures related to Chinese font.
To install the library and the header files it is required to have admin privileges. To do it, open as admin a "x64 Native Tools Command Prompt". Then:
cd path\to\lomse\build-area
ninja install

For building the shared library:

cmake -G "Ninja" -DLOMSE_BUILD_STATIC_LIB=OFF -DLOMSE_BUILD_SHARED_LIB=ON ..
ninja

In this case, the library is built but building the unit tests runner program fails due to linkage problems. I do not know how to fix this.
My knowledge of Windows and cmake is very limited, and I never used MinGW. Any help for fixing all this will be greately appreciated!

I have a successful build using this:
mkdir build
cd       build
cmake -G "Unix Makefiles" ..
make

The localtime_r is the only issue, I just turned into localtime_s and it worked.

Glad to know and thanks for reporting. My understanding is that to build for MinGW you will need MinGW installed and available in your %PATH%. Then do:
mkdir build
cd build
cmake -G "MinGW Makefiles" ..
make

Why are you instead generating Unix makefiles?

Glad to know and thanks for reporting. My understanding is that to build for MinGW you will need MinGW installed and available in your %PATH%. Then do:
mkdir build
cd build
cmake -G "MinGW Makefiles" ..
make

Why are you instead generating Unix makefiles?

Thanks for so replying so quick.
I think in MinGW, unix makefiles are the same with makefiles. Later, I figured out that if I use cmake -G "MinGW Makefiles", I have to use a long mingw32-make to make. This previously I did not know.

I never used MinGW but my understanding is that it is for building Windows binaries using linux tools. If you uses cmake -G"Unix Makefiles" .. and builds with gcc I think that you will be generating linux binaries and they will not be valid. But this is just my uninformed understanding. I never had to learn and deal with MinGW.
If you would like to generate Windows binaries perhaps it is simpler to do it without using MinGW, as I explained here https://github.com/lenmus/lomse/issues/235#issuecomment-626874538

Closed, inadvertely, in PR

Closing this issue due to lack of any concrete implications.


The End is Nigh for DRS

I think that should read "The End is Nigh for FRS".  That's also the title of the page it links to.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd810b22-4e2a-5a66-db90-dd39b1b5c565
Version Independent ID: 8e36df09-f7f1-dcbd-dc3d-93cbeed1b040
Content: On-premises Azure AD password protection FAQ
Content Source: articles/active-directory/authentication/howto-password-ban-bad-on-premises-faq.md
Service: active-directory
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

Thanks for the feedback! We are currently investigating and will update you shortly.

@jordanmills Thanks for reporting this. I have updated the doc accordingly and I am closing the issue now.


Seriously slow?

I tried to execute this code using jvmgo
import java.util.*;
class prime {
        public static void main(String[] args) {
                ArrayList<Integer> res = new ArrayList<Integer>();
                int last = 3;
                res.add(last);
                while(true) {
                        last = last + 2;
                        boolean prime = true;
                        for(int v : res) {
                                if(v*v>last) break;
                                if(last%v == 0) {
                                        prime = false;
                                        break;
                                }
                        }
                        if(prime) {
                                res.add(last);
                                if(res.size()%100000 == 0) System.out.println(last);
                                if(last>9999999) break;
                        }
                }
        }
}

but it took too much time, more than 578.62s (I terminate execution because it took too long), for comparison openjdk gives complete output within 1.23s

Hi, thanks for your issue. This project is coded for fun and learning. Besides that, it is in the baby stage(two months old, mostly programmed by one guy). So, do not expect too much : ) I will try my best to finish this project and make it run faster.

Btw this project is cool :cool: i'll look forward for the completion :+1:

@zxh0 could there be a bug or something related to this? I have a feeling that no matter how slow, it shouldn't take that long. I don't know anything but yeah, my 2 cents.

Yes, it's too slow :( I did some cpu profile and code optimization yesterday, but I feel it's not the time to do this kind of stuff.  Thread, ClassLoader, Java Memory Model, File, Socket... a lot of things are still not working(correctly). I will try to implement all of them and then go back to this issue.

While peeking at the code I think it's already using a threaded interpreter, right?
Then to achieve good performance you must implement JITs, which I suspect will take years to be competitive... (look at LuaJIT)
I agree it's better making things working than making them performant for now.

Actually, writing a JIT is beyond my ability :(

Go can't easily support a JIT currently because Go's memory model clashes with most ways of doing jit. Creating a JIT itself is not particularly hard.

What if we instead transpiled Java to Golang, and then could get native execution speed?
Kind of like GWT transpiles Java bytecode to JavaScript.

@bpilot why use go then? GCC has gcj which compiles Java to native x64 elf binaries.

Actually, writing a JIT is beyond my ability :(

How about migrate VMKit to latest LLVM?


Add WindowsProcessService module

The new module contains ProcessServiceImpl, which implements the
orbit_grpc_protos::ProcessService::Service on Windows. Add required
ReadProcessMemory.h/cpp/Test.cpp in WindowsUtils. Also add
FindDebugSymbols.h/.cpp/Test.cpp.

Thanks for the review @dpallotti , I addressed all the comments, please take another look, thanks!


chore(deps): update common-dev-assets digest to 44ee19c

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
f497c08 -> 44ee19c

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.4.4 :tada:
The release is available on:

GitHub release
v1.4.4

Your semantic-release bot :package::rocket:


Create and test PausableToken Contract

Creates PausableToken contract that inherits from the StandardTokenContract.
Change Pauable contract to use pause as opposed to emergency
PausableToken has an owner who is able to:
Pause all token transfers
Unpause all token transfers
This contract was created in response to issue #194
It's fully tested in PausableToken.js and all tests are passing.

Amazing work @DavidKnott!!! Thanks a lot.
Do you mind refactoring the code so that it inherits from Pausable?
(https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/lifecycle/Pausable.sol)
I actually like the modifier and event names better here, so if you can also modify Pausable to adopt this new names that would be great.
What do you think?
BTW, if you haven't already, please join our slack, I'd like to have a chat with you and thank you for your contributions :)
https://slack.openzeppelin.org/

Thanks for looking it over so quickly @maraoz! I like that idea, I'll integrate it with the Pause contract and change the names to match the PauseToken.

@maraoz I changed the  Pausable contract like we talked about before.  I think the modifier '''canTransfer''' makes sense for allowing transactions only when they're not paused but cannotTransfer seems a bit confusing to me (the functionality is that it allows stuff to occur only when paused).  What do  you think?

@DavidKnott I think Pausable should have no mentions to transfers, I would call the methods pause, unpause, and the modifiers ifPaused or whenPaused and whenNotPaused

@maraoz thanks for the feedback, I took all mentions of transactions out of the Pausable contract (tried to make it as modular as possible).  Do you see anything else that needs to be changed?

LGTM, many thanks for the contribution!


upload_to_testflight: Not Found

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Complete output when running fastlane, including the stack trace and command used

  +--------------------------------+--------------------------------------+
[20:09:29]: <!DOCTYPE html>

<title></title>
<link rel="stylesheet" href="/styles/main.css">

Not Found

Copyright © 2015 Apple Inc. All rights reserved.

Terms of Service

Privacy Policy

+------+------------------------+-------------+
|              fastlane summary               |
+------+------------------------+-------------+
| Step | Action                 | Time (in s) |
+------+------------------------+-------------+
| 1    | default_platform       | 0           |
| 2    | latest_testflight_bui  | 13          |
|      | ld_number              |             |
| 3    | increment_build_numbe  | 1           |
|      | r                      |             |
| 4    | build_app              | 792         |
| 💥   | upload_to_testflight   | 3664        |
+------+------------------------+-------------+

[20:09:29]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...

/Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/spaceship/lib/spaceship/test_flight/client.rb:330:in `handle_response': [!] <!DOCTYPE html> (Spaceship::UnexpectedResponse)

<title></title>
<link rel="stylesheet" href="/styles/main.css">

Not Found

Copyright © 2015 Apple Inc. All rights reserved.

Terms of Service

Privacy Policy

	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/spaceship/lib/spaceship/test_flight/client.rb:72:in `post_for_testflight_review'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/spaceship/lib/spaceship/test_flight/build.rb:217:in `submit_for_testflight_review!'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/pilot/lib/pilot/build_manager.rb:183:in `distribute_build'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/pilot/lib/pilot/build_manager.rb:108:in `distribute'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/pilot/lib/pilot/build_manager.rb:61:in `upload'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/actions/upload_to_testflight.rb:16:in `run'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:253:in `block (2 levels) in execute_action'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:232:in `block in execute_action'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
	from Fastfile:38:in `block (2 levels) in parsing_binding'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/lane.rb:33:in `call'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/lane.rb:33:in `call'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/fastlane/lib/fastlane/cli_tools_distributor.rb:108:in `take_off'
	from /Users/daminik00/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.110.0/bin/fastlane:23:in `<top (required)>'
	from /Users/daminik00/.fastlane/bin/bundle/bin/fastlane:22:in `load'
	from /Users/daminik00/.fastlane/bin/bundle/bin/fastlane:22:in `'

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.3

Ruby
2.2.4

Bundler?
false

Git
git version 2.17.1 (Apple Git-112)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.14.3 (18D21c)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.0

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  ENV["FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD"] = «"
  desc "Push a new beta build to TestFlight"

  lane :sendPush do
    changelog = File.read("Changelog.txt")
    url = URI.parse(URI.escape("http://api.daminik00.ru/push.php?info=#{changelog}"))
    req = Net::HTTP::Get.new(url.to_s)
    res = Net::HTTP.start(url.host, url.port) {|http|
      http.request(req)
    }
  end

  lane :beta do
    increment_build_number(
      build_number: latest_testflight_build_number.to_i + 1,
      xcodeproj: "SupremeBotiOSAcute.xcodeproj"
    )
    build_app(workspace: "SupremeBotiOSAcute.xcworkspace", scheme: "SupremeBotiOSAcute")
    changelog = File.read("Changelog.txt")
    upload_to_testflight(changelog: changelog, beta_app_description: "Удачных вам дропов", groups: "Me")
    sendPush
  end
end

`./fastlane/Appfile`
app_identifier("ru.daminik00.Supreme-Bot") # The bundle identifier of your app
<EMAIL_ADDRESS># Your Apple email address

itc_team_id("118705364") # App Store Connect Team ID
team_id("4X4HAH2D2G") # Developer Portal Team ID

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.110.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
2.3.2

atomos
0.1.3

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.7.0

rouge
2.0.7

xcpretty
0.3.0

unicode-display_width
1.1.3

terminal-table
1.7.3

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-screen
0.6.5

tty-cursor
0.6.0

tty-spinner
0.9.0

babosa
1.0.2

colored
1.2

commander-fastlane
4.4.6

faraday
0.12.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

gh_inspector
1.1.3

json
1.8.1

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.2

security
0.1.3

xcpretty-travis-formatter
0.0.4

bundler
1.14.6

faraday_middleware
<IP_ADDRESS>

naturally
2.2.0

simctl
1.6.5

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

mime-types
3.1

signet
0.11.0

memoist
0.16.0

googleauth
0.6.7

httpclient
2.8.3

google-api-client
0.23.9

google-cloud-env
1.0.5

google-cloud-core
1.2.7

digest-crc
0.4.1

google-cloud-storage
1.15.0

emoji_regex
0.1.1

highline
1.7.10

excon
0.62.0

CFPropertyList
3.0.0

libxml-ruby
3.0.0

plist
3.4.0

fastimage
2.1.5

addressable
2.5.2

retriable
3.1.2

mime-types-data
3.2018.0812

multi_json
1.13.1

jwt
2.1.0

os
1.0.0

psych
2.0.8

uber
0.1.0

generated on: 2018-12-13

I got the same problem.

I am also experiencing the same issue.

I already had ITSAppUsesNonExemptEncryption key
<key>ITSAppUsesNonExemptEncryption</key>
<false/>

+1

The problem is reproduced for all our applications. upload_to_testflight is completely broken.

Quick summary of what has been posted: You are using upload_to_testflightas you have many times before, but now this crashes with an output of a HTML page that includes "Not Found" and a stacktrace similar to https://github.com/fastlane/fastlane/issues/13903#issuecomment-447097174. All correct?

I looked through the (obvious) stacktrace: It is successfully uploading the build, but when trying to distribute it does a POST request to a URL ending in /review (for that specific team, app, build) and gets this very much unexpected "Not Found".

Can someone please post the complete  output of fastlane (with --verbose) including the HTML and stacktrace? The parts before it actually crashes are also relevant. There is some error catching logic in the code, and I need to know if and how this is triggered.
As you can see in the Stacktrace, the component crashing here when doing the actual request is spaceship. Spaceship has extensive logging to /tmp/spaceship*.log: https://github.com/fastlane/fastlane/blob/master/spaceship/docs/Debugging.md#logging Can someone please post the logs of such a failed upload attempt? This will tell us about the HTTP header being returned and if previous request may be failing or returning unexpected stuff as well.
Thanks 💯

Do you see the upload in Apple's UI anywhere?
It's possible Apple changed something on their end - we will of course try to adapt to this asap.

@janpio The build is on the iTunes Connect alright. It's just failure during Testflight distribution

@janpio is this the log you requested https://gist.github.com/NicosKaralis/efe0acf0a156caf5f2a80802dd666db3 ?

Yep, correct folder and type of log - but wrong file (or the logging is broken there as well). There should be at least one POST request to providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/review (#{...} replaced with your IDs of course).

Updated the link
https://gist.github.com/NicosKaralis/efe0acf0a156caf5f2a80802dd666db3

Same kind of log
https://gist.github.com/duyleekun/1fc6a97422cd4b7c100b048194e49f2a

Yep, those are perfect. Will look into those. Thanks!

Can't find providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/review in https://developer.apple.com/documentation/appstoreconnectapi/submit_an_app_for_beta_review
Seems like Apple deprecated the old endpoint?

Fastlane/spaceship is not using the App Store Connect API (yet).

Hello everyone! I want to give an update. I was able to make some code changes and I got a submit working on my local machine again 😊 Bad news is we had to implement some of App Store Connect's new APIs so it will be a bit longer until I can properly put all the pieces together so that we can ship this fix but I was able to put the pieces back together.
Stay tuned 💪

Thanks guys :muscle:

Heyyyy 👋 I think I got a fix working in PR #13919 if anybody would like to give this a shot 😊
How To
Replace gem "fastlane" in your Gemfile with the following and run bundle install`
gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "joshdholtz-post_for_testflight_review-new-api"

This uses the new App Store Connect API (the first use of it in fastlane) so having some other people testing this would be 💯

@joshdholtz On first trial, I'm getting following error. I will test again to confirm whether the error is from fastlane. FYI, I can find the build in the itunes website
[09:35:28]: ----------------------------------
[09:35:28]: --- Step: upload_to_testflight ---
[09:35:28]: ----------------------------------
[09:35:28]: Login to App Store Connect<EMAIL_ADDRESS>Available session is not valid any more. Continuing with normal login.
[09:35:31]: Login successful
[09:35:31]: Ready to upload new build to TestFlight (App:<PHONE_NUMBER>)...
[09:35:32]: Going to upload updated app to App Store Connect
[09:35:32]: This might take a few minutes. Please don't interrupt the script.
[09:36:55]: iTunes Transporter successfully finished its job
[09:36:55]: --------------------------------------------------------------------
[09:36:55]: Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online.
[09:36:55]: --------------------------------------------------------------------
[09:36:55]: Successfully uploaded the new binary to App Store Connect
[09:36:55]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
+------------------------------------+-----------------------------------------------------------------------------------------------+
|                                                            Lane Context                                                            |
+------------------------------------+-----------------------------------------------------------------------------------------------+
| PLATFORM_NAME                      | ios                                                                                |
| LANE_NAME                          | ios deploy_beta                                                                               |
| ORIGINAL_DEFAULT_KEYCHAIN          | "/Users/tripath/Library/Keychains/login.keychain-db"                                          |
| FL_CHANGELOG                       | Version Bump                                                                                |
|                                    | Use version of fastlane that use itunes connect api                                           |
|                                    | Bump version string                                                                           |
|                                    | Version Bump                                                                                |
|                                    | Add missing plist files                                                                       |
|                                    | D not update repo                                                                             |
|                                    | Test legacy                                                                                |
|                                    | Version Bump                                                                                |
|                                    | Add bundle install                                                                            |
|                                    | Version Bump                                                                                |
| SIGH_PROFILE_TYPE                  | app-store                                                                                |
| MATCH_PROVISIONING_PROFILE_MAPPING | {"vn.tripath.m090rn"=>"match AppStore vn.tripath.m090rn"}                                     |
| IPA_OUTPUT_PATH                    | /Users/tripath/builds/m090/RNApp/M090.ipa                                                     |
| DSYM_OUTPUT_PATH                   | /Users/tripath/builds/m090/RNApp/M090.app.dSYM.zip                                            |
| XCODEBUILD_ARCHIVE                 | /Users/tripath/Library/Developer/Xcode/Archives/2018-12-14/M090 2018-12-14 09.29.08.xcarchive |
+------------------------------------+-----------------------------------------------------------------------------------------------+
[09:36:57]: Could not find a build for app:<PHONE_NUMBER> on platform: ios

+------+----------------------------+-------------+
|                fastlane summary                 |
+------+----------------------------+-------------+
| Step | Action                     | Time (in s) |
+------+----------------------------+-------------+
| 1    | setup_circle_ci            | 0           |
| 2    | yarn                       | 55          |
| 3    | cocoapods                  | 122         |
| 4    | changelog_from_git_commits | 0           |
| 5    | match                      | 2           |
| 6    | build_app                  | 386         |
| 💥   | upload_to_testflight       | 89          |
+------+----------------------------+-------------+

[09:36:57]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...

Found no similar issues. To create a new issue, please visit:
https://github.com/fastlane/fastlane/issues/new
Run `fastlane env` to append the fastlane environment to your issue
FastlaneCore::Interface::FastlaneCrash: [!] Could not find a build for app:<PHONE_NUMBER> on platform: ios
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane_core/lib/fastlane_core/ui/interface.rb:129:in `crash!'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane_core/lib/fastlane_core/ui/ui.rb:17:in `method_missing'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane_core/lib/fastlane_core/build_watcher.rb:13:in `wait_for_build_processing_to_be_complete'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/pilot/lib/pilot/build_manager.rb:55:in `upload'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/actions/upload_to_testflight.rb:16:in `run'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:253:in `block (2 levels) in execute_action'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:232:in `block in execute_action'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:227:in `chdir'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
  Fastfile:78:in `block (2 levels) in parsing_binding'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/lane.rb:33:in `call'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:45:in `chdir'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/runner.rb:45:in `execute'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
  /usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
  /usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
  /usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
  /usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/fastlane/lib/fastlane/cli_tools_distributor.rb:108:in `take_off'
  /usr/local/lib/ruby/gems/2.5.0/bundler/gems/fastlane-a469c588e701/bin/fastlane:23:in `<top (required)>'
  /usr/local/lib/ruby/gems/2.5.0/bin/fastlane:23:in `load'
  /usr/local/lib/ruby/gems/2.5.0/bin/fastlane:23:in `<top (required)>'

For some reason, 2nd time is a charm 👍
[09:39:02]: ----------------------------------
[09:39:02]: --- Step: upload_to_testflight ---
[09:39:02]: ----------------------------------
[09:39:02]: Login to App Store Connect<EMAIL_ADDRESS>Available session is not valid any more. Continuing with normal login.
[09:39:05]: Login successful
[09:39:05]: Ready to upload new build to TestFlight (App:<PHONE_NUMBER>)...
[09:39:06]: Going to upload updated app to App Store Connect
[09:39:06]: This might take a few minutes. Please don't interrupt the script.
[09:40:24]: iTunes Transporter successfully finished its job
[09:40:24]: --------------------------------------------------------------------
[09:40:24]: Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online.
[09:40:24]: --------------------------------------------------------------------
[09:40:24]: Successfully uploaded the new binary to App Store Connect
[09:40:24]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
[09:40:27]: Waiting for App Store Connect to finish processing the new build (2.0.0 - 35)
[09:40:58]: Waiting for App Store Connect to finish processing the new build (2.0.0 - 35)
[03:56:54]: Waiting for App Store Connect to finish processing the new build (2.0.0 - 35)
[03:57:24]: Waiting for App Store Connect to finish processing the new build (2.0.0 - 35)
[03:57:55]: Waiting for App Store Connect to finish processing the new build (2.0.0 - 35)
[03:58:25]: Waiting for App Store Connect to finish processing the new build (2.0.0 - 35)
[03:58:56]: Waiting for App Store Connect to finish processing the new build (2.0.0 - 35)
[03:59:27]: Build doesn't show up in the build list anymore, waiting for it to appear again (check your email for processing issues if this continues)
[03:59:57]: Build doesn't show up in the build list anymore, waiting for it to appear again (check your email for processing issues if this continues)
[04:00:28]: Build doesn't show up in the build list anymore, waiting for it to appear again (check your email for processing issues if this continues)
[04:00:59]: Build doesn't show up in the build list anymore, waiting for it to appear again (check your email for processing issues if this continues)
[04:01:29]: Build doesn't show up in the build list anymore, waiting for it to appear again (check your email for processing issues if this continues)
[04:02:00]: Successfully finished processing the build 2.0.0 - 35
[04:02:06]: Successfully set the changelog for build
[04:02:06]: Distributing new build to testers: 2.0.0 - 35
[04:02:07]: Successfully distributed build to External testers 🚀

+------+----------------------------+-------------+
|                fastlane summary                 |
+------+----------------------------+-------------+
| Step | Action                     | Time (in s) |
+------+----------------------------+-------------+
| 1    | setup_circle_ci            | 0           |
| 2    | yarn                       | 57          |
| 3    | cocoapods                  | 348         |
| 4    | changelog_from_git_commits | 0           |
| 5    | match                      | 2           |
| 6    | build_app                  | 370         |
| 7    | upload_to_testflight       | 66185       |
+------+----------------------------+-------------+

[04:02:07]: fastlane.tools just saved you 1116 minutes! 🎉

@duyleekun Ohhhhh... I wonder if I also need to replace the API call that checks for build statuses as well 😩 I’m going to Disneyland with my nieces today but I will work on fixing that later tonight 💪
Sent with GitHawk

@joshdholtz  The Could not find a build for app has happened to me before. It happened randomly so I guess Apple's at fault. Anyway, have a nice trip

@joshdholtz thanks for rolling such a quick fix for this. We tested out the branch and it allowed us to get past the waiting for review and get a build out into App Store Connect. Still got a failure related to an UnexpectedResponse, but it got far enough along to unblock us for now. This failure was on CircleCI:
bundler: failed to load command: fastlane (/Users/distiller/gospotcheck-ios/vendor/bundle/ruby/2.5.0/bin/fastlane)
Spaceship::UnexpectedResponse: [!] The build is not in state for internal testing. - Build is not in internal testing state.
   Today, one of our developers inadvertently reverted us back to the latest mainline fastlane version (2.111.0) and pushed a new build which failed. But what is weird is that we did not see the
Not Found
 error from last week and the build did get uploaded successfully. Instead, we did get a slightly different error further down the build, trying to set the changelog, of all things:
[!] Could not set changelog:

<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 403 </title>

HTTP ERROR: 403

The fact that we are not getting the original error seems to suggest that Apple might have un-deprecated the old iTunes connect endpoint? This changelog error appears to be something entirely new that we weren't seeing last week. I'll open a separate issue about that.

I'm having the same Not Found issue in fastlane 2.111.0 . Did anyone able to get this done ? What is the state of PR #13919 ?

It has been merged but not released. You can test it with the instructions in https://github.com/fastlane/fastlane/issues/13903#issuecomment-447535838 to see if it fixes the issue for you.

Thank you, will test it. Hopefully it will be released soon.

@janpio what is the timeline for getting this release out?  If there is anyway to get something pushed out today, that would be a major help!

Release will be happening later today! Sorry to keep everyone waiting 😬 Testing out one more PR that fixes some adhoc profile stuff and then these will both be shipped out 🚀

@joshdholtz much appreciated.  Please let me know as soon as an update is released!

(2.112.0 is out 🚥 🚆 )

🙌 our build is processing right now.  best of luck 🤞

We updated fastlane version to 2.111.0 and now we are not getting 'Not found' error but another error, same as what @nickgsc pointed out. Will this also be fixed in latest release?
/Users/ios-worker/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/fastlane-c63166f9d98c/spaceship/lib/spaceship/connect_api/client.rb:84:in handle_response': [!] The build is not in state for internal testing. - Build is not in internal testing state. (Spaceship::UnexpectedResponse) from /Users/ios-worker/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/fastlane-c63166f9d98c/spaceship/lib/spaceship/connect_api/client.rb:66:in post_for_testflight_review' from /Users/ios-worker/.r

Thanks a lot, it worked 👍

@VSAC-STORES-TEAM-INDIA Please open a new issue for this new problem - afaik we are not aware of this one yet, so nobody is working on understanding or fixing it. (Please make sure to include all the information the template asks for.)


[RFR] Fix Karma tests

In WIP. Trying to identify the issue first.

Any progress?

Not yet. Can't find the issue. I'll look at it more deeply later today.

Succeeded to reproduce, using PhantomJS instead of Chrome with command line:
CI=true grunt test

Looking at a fix.

Switching to RFR. Tests should finally be green (modulo the current GitHub DDOS attack).

\o/


close folder from explorer sidebar

Summary
Having an option to close the folder from the explorer side bar would be nice
Details

Since the option to open the folder was there in the sidebar,

my mind automatically searches for the option to close the folder there itself.

But it's found only in the "file" menu option

Duplicate 🔍 close folder from explorer sidebar

Those sidebar buttons are for "welcome" content; basically listing ways to put content into an otherwise empty view. If you really want a close option the explorer context menu is open for extension contributions, but for in-core we will leave it to the file menu.


fix(set): updating an array

Description
Sets array values correctly and fixes #29

:tada: This PR is included in version 0.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update SA1402 to handle records and record structs

Fixes #3542

Ready for review

Note that I did not add any tests for record class, since there is no new syntax node for it. Let me know if tests are still expected.

Can you take a look at this, @sharwell?

@sharwell?


Fix the hex orientation of pin locations.

The pin locations in a hex block were rotated 30 degrees from where they
should be. This was discovered when plotting pin-level assembly plots
and they were all sticking out the edges. The major confusion comes in
from the fact that even though pointed end up  doesn't seem right when
you look at the pins, if you look at the little outline hexes
surrounding each pin then you can see that indeed the pointed end is
supposed to be up in this case.
This could impact results for anyone using auto-generated pin-level
grids and using the pin-wise pin coordinates.
Before:

After:

Checklist

[x] The code is understandable and maintainable to people beyond the author.
[ ] Tests have been added/updated to verify that the new or changed code works.
[x] There is no commented out code in this PR.
[x] The commit message follows good practices.
[x] All docstrings are still up-to-date with these changes.

If user exposed functionality was added/changed:

[ ] Documentation added/updated in the doc folder.
[ ] New or updated dependencies have been added to setup.py.

@ntouran  black is broken. I'd fix it for you, but it's in your private repo.


Generate synthetic package for l10n.yaml

When provided with the config synthetic: true, will generate the source under .dart_tool/flutter/flutter_gen and update the package_config.json with the contents. synthetic: true could become opt-out instead of opt-in in the future, allowing a gradual migration from the old generation pattern.
fyi @shihaohong

NICE

Fixed via https://github.com/flutter/flutter/pull/61261


Explicitly specify AppVeyor clone dir

I was assuming it would always clone into C:\projects\flow, but then it do this:
git clone -q --branch=master https://github.com/facebook/flow.git C:\projects\flow-sv90g

The format of the default directory on the build machine for cloning repository is c:\projects<project-slug>.

And on my AppVeyor account, gabelevi/flow is "flow" and facebook/flow is "flow-sv90g". Huh.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Use dedicated threadpool for Godot threads

Follow up to #25213 which I didn't mean to close.
--
Alternative fix to #25117
Although the concept is the same (i.e. use a thread pool) this implementation uses a dedicated thread pool rather than the default one.
This is better than using QueueUserWorkItem because the dedicated thread pool can be set with a minimum number of threads that are pre-allocated to handle the queue work items.
The minimum number of threads is configured with "thread_pool/min" project setting. By default it's 0 (so for the first work item it works the same as CreateThread) but can be changed to a higher number for projects that use threads extensively.
Please note that this uses Windows Vista+ API however that shoulld be fine as Godot already seems to require Vista+ (I didn't know about it when implmenting #25117 and that's the reason why I'm proposing this alternative now).

I couldn't get this reviewed in time by @hpvb or @reduz and it's now too close to the 3.2 release to do such change. So let's re-assess for 4.0, together with many other changes to threading thanks to moving to C++14.

@dragmz  Is this still desired? If so, it needs to be rebased on the latest master branch. It's also possible that this PR needs changes or is no longer relevant due to Godot moving to C++17.
Otherwise, abandoned pull requests will be closed in the future as announced here.

This PR has not received any new commits for over a year and is abandoned, closing.


Add call_module_function_promise to deal with async functions

I'd like to call an async function in JavaScript. When I do this with call_module_function I get an error

error: plugin errored with: failed to call function: Error converting from js 'promise' into type 'JSBytesValue'

I believe this can be fixed by adding a fn call_module_function_promise to lib.rs that calls finish on the Promise. Happy to try implementing this myself if this is the right thing to do.

@j-mueller
I have not yet considered synchronisation in the project. But I think that's a good feature request.
I think it makes the most sense to check in the existing function whether there is a promise back instead of establishing a new function.
So an option that a promise is ‘converted’ to a JSBytesValue.  The implemantion position would be here: https://github.com/lublak/typst-ctxjs-package/blob/main/src/value.rs
This would benefit all functions that return a promise value.
I will be on holiday from Wednesday until Tuesday. I can't guarantee whether I'll be able to do it before then. But I can take it over and try to make it possible before my holiday.

@j-mueller I think it's a quick function. I will do it today, can you test it then?

fix in: https://github.com/lublak/typst-ctxjs-package/commit/05cf075711d1b112bae88e02c7470f7ad5633194

@lublak  Yep it works, thank you!

@j-mueller awesome :) i published a new version to the universe. https://github.com/typst/packages/pull/1016
It will take a few days and then it should also be available in the Universe.

Amazing, thank you!

@j-mueller it's now on universe

Thanks, I already made a package based on it (and inspired by your echarms package): https://typst.app/universe/package/nulite/

@j-mueller awesome! :)
The first one implemented was echarming without any further usability of the Javascript runtime. But I thought, hey, others might find it useful too. That's how ctxjs came about. Echarming should then serve as an example. As a small recommendation for the next release. The best context name here would be the package name "@preview/nulite".


GitHub not Github

Sorry, pedantry, but it's GitHub not Github, re https://spellfucker.com/
I couldn't find the site source to make a PR, apologies

Thank you, fixed.


[Snippet Generation] Csharp openAPI generation fixes

This PR is part of https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/1398 and closes https://github.com/microsoftgraph/microsoft-graph-devx-api/issues/705
It resolves snippet generation failures on raptor validation of the snippet generator due to various reasons.
Changes include : -

Fixes snippet generation in Java and CSharp for URLs with $search to be properly escaped. #705
Adds generated namespace information to the SnippetGodeGraph so that relevant language generators can take advantage of the information to resolve Type resolution in compilation
Improves Enum member resolution to use spelling from metadata in CSharp
Detect scenarios where request executors need a request payload even though the snippet has no body to provide default/null parameters using the RequestSchema
Improves SnippetCodeGraph schema information to detect composed schemas as is done in Kiota to reduce type resolution failures.
Adds tests to validate the above scenarios

Thanks @baywet


CWL+Toil+Restarts produces "Got workflow error"

I have large workflow, 10x human genomes, ~15 steps about a week of runtime. I've had to restart it because our cluster failed and initially the restart seemed to work well, it ran for several more days. It then failed with the following:
Got workflow error
Traceback (most recent call last):
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/cwltool/main.py", line 281, in single_job_executor
r.run(**kwargs)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/cwltool/job.py", line 307, in run
stageFiles(self.generatemapper, ignoreWritable=self.inplace_update, symLink=True)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/cwltool/process.py", line 227, in stageFiles
os.symlink(p.resolved, p.target)
OSError: [Errno 17] File exists
ERROR:cwltool:Got workflow error
Traceback (most recent call last):
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/cwltool/main.py", line 281, in single_job_executor
r.run(**kwargs)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/cwltool/job.py", line 307, in run
stageFiles(self.generatemapper, ignoreWritable=self.inplace_update, symLink=True)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/cwltool/process.py", line 227, in stageFiles
os.symlink(p.resolved, p.target)
OSError: [Errno 17] File exists
DEBUG:toil.fileStore:LOG-TO-MASTER: Job 'file:///stornext/HPCScratch/PapenfussLab/projects/ovary-work/pdx-genome/tools/src/tools/samtools-index.cwl' samtools index s/k/jobRYYJes used 4002.83% (80.1 GB [85960163328B] used, 2.0 GB [2147483648B] requested) at the end of its run.
WARNING:toil.fileStore:LOG-TO-MASTER: Job used more disk than requested. Please reconsider modifying the user script to avoid the chance  of failure due to incorrectly requested resources. Job 'file:///stornext/HPCScratch/PapenfussLab/projects/ovary-work/pdx-genome/tools/src/tools/samtools-index.cwl' samtools index s/k/jobRYYJes used 4002.83% (80.1 GB [85960163328B] used, 2.0 GB [2147483648B] requested) at the end of its run.
DEBUG:toil.fileStore:CACHE: Obtained lock on file /home/thomas.e/tmp/toil-8f27be6d-d41a-4567-bf63-6b298c5302fe-e0b198a6-1d82-4bc3-9fd8-97741b77688b/cache-8f27be6d-d41a-4567-bf63-6b298c5302fe/.cacheLock
DEBUG:toil.fileStore:LOG-TO-MASTER: Successfully deleted local copies of file with ID 'g/C/tmpRxqHOu.tmp'.
DEBUG:toil.fileStore:CACHE: Released lock
DEBUG:toil.fileStore:CACHE: Obtained lock on file /home/thomas.e/tmp/toil-8f27be6d-d41a-4567-bf63-6b298c5302fe-e0b198a6-1d82-4bc3-9fd8-97741b77688b/cache-8f27be6d-d41a-4567-bf63-6b298c5302fe/.cacheLock
DEBUG:toil.fileStore:CACHE: Released lock
DEBUG:toil.fileStore:CACHE: Obtained lock on file /home/thomas.e/tmp/toil-8f27be6d-d41a-4567-bf63-6b298c5302fe-e0b198a6-1d82-4bc3-9fd8-97741b77688b/cache-8f27be6d-d41a-4567-bf63-6b298c5302fe/.cacheLock
DEBUG:toil.fileStore:CACHE: Released lock
Traceback (most recent call last):
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/toil/worker.py", line 340, in main
job._runner(jobGraph=jobGraph, jobStore=jobStore, fileStore=fileStore)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/toil/job.py", line 1289, in _runner
returnValues = self._run(jobGraph, fileStore)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/toil/job.py", line 1234, in _run
return self.run(fileStore)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/toil/cwl/cwltoil.py", line 306, in run
**opts)
File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/lib/python2.7/site-packages/cwltool/main.py", line 289, in single_job_executor
raise WorkflowException(Text(e))
WorkflowException: [Errno 17] File exists
ERROR:toil.worker:Exiting the worker because of a failed job on host trqn-n51538.hpc.wehi.edu.au
WARNING:toil.jobGraph:Due to failure we are reducing the remaining retry count of job 'file:///stornext/HPCScratch/PapenfussLab/projects/ovary-work/pdx-genome/tools/src/tools/samtools-index.cwl' samtools index s/k/jobRYYJes with ID s/k/jobRYYJes to 0
<=========
If I restart it just produces the same error. Not sure what other information I should provide.
Here is some version info:
(toil-env) [thomas.e@torquelord ovary]$ cwltoil --version
3.9.1
(toil-env) [thomas.e@torquelord ovary]$ cwltool --version
/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env/bin/cwltool 1.0.20170822192924

This is a crosspost: https://github.com/common-workflow-language/cwltool/issues/541

Hi @evan-wehi
I'm a little confused.  You are reporting cwltoil 3.9.1 (which was released July 19) but cwltool from August 22?  Are you using a version from git?
I suggest trying the current master branch of Toil.

Yes, this is a large job which I started a month ago which is why I want to restart the failed workflow if possible. I would have just done pip install toil cwltool etc into the virtualenv to get stable releases. Also the job store is very large so it is not practical to copy it. I'm not really in a position to experiment unless there is a compelling reason to.

I made copy of the jobstore, which took 5 days (I won't be doing that again). I've restarted the workflow with the current master branch. It also fails:
Traceback (most recent call last):
  File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env-3.11/lib/python2.7/site-packages/toil/worker.py", line 315, in main
    job._runner(jobGraph=jobGraph, jobStore=jobStore, fileStore=fileStore)
  File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env-3.11/lib/python2.7/site-packages/toil/job.py", line 1299, in _runner
    returnValues = self._run(jobGraph, fileStore)
  File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env-3.11/lib/python2.7/site-packages/toil/job.py", line 1244, in _run
    return self.run(fileStore)
  File "/stornext/HPCScratch/PapenfussLab/projects/ovary-work/toil-env-3.11/lib/python2.7/site-packages/toil/cwl/cwltoil.py", line 428, in run
    fillInDefaults(self.step_inputs, cwljob)
AttributeError: 'CWLJob' object has no attribute 'step_inputs'
ERROR:toil.worker:Exiting the worker because of a failed job on host trqn-n51538.hpc.wehi.edu.au
WARNING:toil.jobGraph:Due to failure we are reducing the remaining retry count of job 'file:///stornext/HPCScratch/PapenfussLab/projects/ovary-work/pdx-genome/tools/src/tools/samtools-index.cwl' samtools index s/k/jobRYYJes with ID s/k/jobRYYJes to 0

Stale, and my guess is, difficult to reproduce.  Please reopen if this is still an issue.  If reopened, we would need the CWL script and some parsed down input files with which to run it at the least otherwise I don't know how we'd reproduce this to debug.


IBM MQ binding missing Operation Binding Object

During implementation of AsyncAPI 2.1 and IBM MQ I've noticed that IBM MQ doesn't come with Operation Binding Object. I'm not familiar with IBM MQ protocol, but wanted to raise this issue to be sure that missing Operation Binding Object is an explicit decision and not something that has been forgotten.
ibmmq field is missing from Operation Bindings Object as well.

@char0n It is missing as ibmmq binding doesn't have any operation-level bindings -> https://github.com/asyncapi/bindings/tree/master/ibmmq

Thanks!


NLogViewer not updating its visual components

Hello,
I have a TabControl with various tabs, which will be added dynamically. Each tab has a NLogViewer for displaying logs happening inside that tab. Your sample code works great when added inside xaml, but when added via code, the following behaviour occurs:
If switched between tabs, the initial tab, which holds a programmatically created NLogViewer, is not updating its visual components compared to tabs which hold a NLogView created inside the xaml.
This is my code, to create the controls and other stuff:
LoggingConfiguration config = LogManager.Configuration;

var logger = LogManager.GetLogger(LoggerName);

CacheTarget target = new CacheTarget()
{
    Name = LoggerName
};
config.AddTarget(LoggerName, target);

LoggingRule loggingRule = new LoggingRule("*", LogLevel.Trace, target);

loggingRule.DefaultFilterResult = FilterResult.Ignore;
loggingRule.Filters.Add(new WhenEqualFilter()
{
    Layout = "${logger}",
    CompareTo = LoggerName,
    Action = FilterResult.Log,
    IgnoreCase = true
});

config.LoggingRules.Add(loggingRule);

LogManager.Configuration = config;

NLogViewer_ = new NLogViewer()
{
    TargetName = LoggerName,
};

TabItemLog.Content = NLogViewer_;

Task t = Task.Run(() =>
{
    for (int k = 0; k < 10000; k++)
    {
        logger.Error("error: " + k + " || " + LoggerName);
        Thread.Sleep(1000);
    }
});

I have successfully tested with the following code:
LoggingConfiguration config = new LoggingConfiguration();

string loggerName = "foo";

CacheTarget target = new CacheTarget
{
	Name = loggerName
};
config.AddTarget(loggerName, target);

LoggingRule loggingRule = new LoggingRule("*", LogLevel.Error, target);

//loggingRule.DefaultFilterResult = FilterResult.Ignore;
//loggingRule.Filters.Add(new WhenEqualFilter()
//{
//    Layout = "${logger}",
//    CompareTo = loggerName,
//    Action = FilterResult.Log,
//    IgnoreCase = true
//});

config.LoggingRules.Add(loggingRule);

LogManager.Configuration = config;

NLogViewer nLogViewer = new NLogViewer()
{
	TargetName = loggerName,
};

CodeBehind.Content = nLogViewer;

It seems there is something wrong with your 'filter'. After I commented it out, it worked.

Hi Dojo,
thanks for your feedback. I have figured out, that it was not a problem with NLogViewer, with how the display was implemented. I had wrapped the page around a frame to be able to add it, but the frame killed the visual update. Removing it solved my problem.
Thank you very much.
Regards,
Rejac


Workaround get_metadata() failing to parse response; make start_measurement_matching capable of 100000 samples/second

On recent PPK2s with the latest firmware, get_metadata() can get a response that fails to be parsed, and it can cause Ppk2::new() to fail, only to work fine on retry. Let's retry get_metadata() a few times before we decide that something has gone wrong.
On Ubuntu 24.04, port.read() in get_measurement_matching blocks until buf (1024 bytes) is full. Therefore it also returns after 128 samples are accumulated, making the maximum possible sampling rate ~3000 instead of the possible 100_000. Therefore making buf 4 bytes long.
Allow serde::{Serialize, Deserialize} for Measurement; cargo fmt

Great stuff, thanks a lot!
I'd like for the serde support to be behind a feature flag. Can you make the dependency optional?

Thanks! I thought a bit about the serde support, maybe it's not so essential. Users can just copy measurement data into their own data structures and serialize/de-serialize from there. I've dropped that commit :slightly_smiling_face:


update dependencies, ledger improvements

remove await poll
update dependencies
improve ledger response handling, catch errors

I created 3 separate PRs but it became a hassle with trying to fix the LedgerNotFound during the tests.

Allright with the recent fix where we can directly use the schema/cred def returned from the register method I removed all the places where schemas/cred def were directly created and then retrieved and now just used the returned object from register.
The only place where a schema/cred def is retrieved from the ledger after creation is the ledger tests and that's also the only place (it seems) that's randomly failing now. So I think it has to do with retrieving a schema /cred def from the ledger too quickly after creating it. I've added a 2second sleep and would like to see how that holds up for now.
If it resolves the issue with failing tests, we can see to dive deeper and maybe properly fix it. But for now the sleep will do I think.

@jakubkoci updated the sleep part. I'm fine with the current prettier / eslint config, but if we want to tackle it, I want to do that in a separate PR.

Missed your taa comment, updated


macOS arm64 builds do not work

When attempting to run the arm64 prebuilt release v1.21 binaries on macOS 14.4, the following is produced
zsh: trace trap  /Users/caleb/Downloads/wfs-tools-v1.2.1-macos-arm64/wfs-extract

I was able to reproduce this by exporting the variables LDFLAGS="-L/opt/homebrew/opt/llvm/lib" and CPPFLAGS="-I/opt/homebrew/opt/llvm/include" before compiling. Without these environment variables the compiled builds ran fine.
I was also unable to compile it with gcc or AppleClang, which ought to be noted in the readme.
Here is my build: wfs-tools.zip

Thanks for the report and reproduction.
Can you verify if the artifacts that attached here are working?
https://github.com/koolkdev/wfs-tools/actions/runs/8404738575

As far as I can tell the artefacts run perfectly well.


How to remove first delay transition?

Hi! 👋
(please, excuse my english)
I'm using your example, great btw, for one of my projects and I have an issue. When load the page, the first transition, there is a delay before animation starts. I edited your code and changed duration from 0.5 to 3, so you can see the problem with long start animations.

Do you know how to remove this delay?
Thanks!

@tonicastillo,
That delay is intentional. The delay is set for whenever a page "enters" either via a route change or when it is first mounted.
If you don't want any fade in transition on mount I believe you can set initial={false} on AnimatePresence on Layout.js. I haven't tested it out but you can give that a shot.
Documentation on AnimatePresence can be found here: https://www.framer.com/api/motion/animate-presence/

Hi @ryanwiemer
I understand it's intentional.
I have tested adding initial = false to AnimatePresence, but this disable the animation, not only the delay.
I'll try another option. Thanks for your answer anyway.


Zoom with CTRL+= (equals) no longer works

The browsers and editors I know that support zoom out with ctrl + - and zoom in with ctrl + + also support ctrl + = for zoom in. Electron does not define a shortcut for the latter. The workaround is to define it manually as suggested in https://github.com/electron/electron/issues/15496.
We had a shortcut for this but it was removed in f72e0a563e100b6520fdd13d9b3fc3a707241abe. Maybe it could be restored if it does not have side effects.

@krassowski is this still an issue?

Yes.

this is working fine for me on Mac with Cmd + - and Cmd + =

I'm currently using Ubuntu, and Ctrl + = doesn't appear to have any effect (though Ctrl + + does work).

Hi. I have been using JupyterLab Desktop for a few days (Windows). Only Ctrl - works for me. Any suggestions?

Just noticed that Ctrl Shift + works for "zoom-in", so never mind and thanks!


Upgrade Script somehow lost within the Doc

Hi
Since the reorganisation the Update Script here https://github.com/mattermost/docs/blob/master/source/administration/upgrade-script.rst is lost. There is no section in the docs for that. You can find it by searching but then it looks strange.

Thanks, @JtheBAB, for logging this issue! It was dropped in error and it will be added back with a link in the LHS.

@JtheBAB, thanks for picking this up. I'm handling the migration of the content and will have this up shortly. Thank you!

Hi @JtheBAB! Sorry about the delay on this. I've moved the upgrade script article to the forum. Please take a look at it and let me know if you have any issues or feedback. :)


Documentation update

@zeeke @e0ne @Eoghan1232 when you have time please take a look :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.008%) to 38.446%

Files with Coverage Reduction
New Missed Lines
%

controllers/drain_controller.go
1
70.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.008%

Covered Lines:
4820

Relevant Lines:
12537

💛  - Coveralls

Thanks, folks!
merging this one


Event Grid Support in NCUS?

Do you have a timeline for supporting Event Grid in NCUS region?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3427291a-bf0e-81c6-0e9f-72bdf440b871
Version Independent ID: 3d833d91-98c1-548b-06c5-681b0c41326b
Content: Azure Event Grid overview
Content Source: articles/event-grid/overview.md
Service: event-grid
GitHub Login: @banisadr
Microsoft Alias: babanisa

Current North American available regions for Azure Event Grid.

We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Zwift (widows10) does not show up in the list of smart trainers on the device screen.

Zwift (widows10) does not show up in the list of smart trainers on the device screen.
It does show up in the list of power meters and cadence sensors.

Could you elaborate on your issue?  Are you saying that the ESP32, when programmed with the logic established in this repository, does not show up in the Zwift app?


Install from source fix

The instructions have a step as follows:
build cuda-on-cl
pushd third_party/cuda-on-cl
make -j 4
sudo make install
popd
But it should be
build cuda-on-cl
pushd third_party/cuda-on-cl
mkdir build
cd build
cmake ..
make -j 4
sudo make install
popd

I abandoned these instructions and used the tensorflow instructions but just modified the repo to this one. I think the docs need a bit of work.


feat(protocol-designer, step-generation): custom z offset for blowout

closes AUTH-7
Overview
This PR adds a custom z offset field to blowout in the advanced settings of mix and transfer
Test Plan
create a flex or Ot-2 protocol and add a transfer step. open the advanced settings and click on the blowout checkbox. The input field for z offset should be next to the location drop down. It should be disabled if the location is not chosen, or if the source/dest well is a trash bin/waste chute. Once it is enabled, click on it and it should render the tip position modal. The default should be 0 at the top of the well and then the range should be the depth of the well in a negative number. Add a custom offset and the step should be created successfully.
Now, do the same thing with a mix step.
Changelog

create a new field for blowout z offset
add new type to fields and step-generation
modify the tip position modal to account for the z offset starting from the top
fix the tests
fix cypress, the blowout commands now generate offset from the top of the well instead of from the bottom (this theoretically should NOT be a change in behavior since before, we were getting the z offset that was the height of the well from the bottom)

Review requests
see test plan
Risk assessment
low

_well_height_label wouldn't need right: 10px

_well_height_label wouldn't need right: 10px

nice! thanks for catching this @koji. i'll remove it. seems like its some old css styling added 6 years ago 😅


feat(kubernetes): support api managed from k8s

Issue
gravitee-io/issues#7202
https://github.com/gravitee-io/issues/issues/8189
Description
Original branche : https://github.com/gravitee-io/gravitee-api-management/tree/issues/%237202-kubernetes-operator
added in new one to run e2e
Additional context

🤝  review with @a-cordier

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of APIM master. (Same login and password as APIM master)

📚  View the storybook of this branch here

@ThibaudAV I'm struggling with them we can have a look together if you can?


Mistake in short paragraph

[Enter feedback here]
The short paragraph should say 'This example queries PostgreSQL using its JDBC driver.'
Document details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b965327d-9242-c891-0157-d95a14964398
Version Independent ID: b965327d-9242-c891-0157-d95a14964398
Content: Query PostgreSQL with Azure Databricks - Azure Databricks
Content Source: databricks/external-data/postgresql.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@Bayo19
Thanks for your feedback! We will investigate and update as appropriate.

@Bayo19
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Feature request: Add Manual Mode

basically what warp journal already has, with the webcache folder changing every version, it's easier to use extra scripts that are updated more often like AAGL that grab your URL so you can paste it into WW, just like with paimon.

I'll submit a fix for this on the weekend that automatically stays up to date after a patch.

I'll submit a fix for this on the weekend that automatically stays up to date after a patch.

neat.


Improve instructions for members removing themselves from fleets

Improve instructions for members removing themselves from fleets
Change-type: patch

Please make sure to read the CONTRIBUTING document before opening the PR for relevant information on contributing to the documentation. Thanks!

LGTM


Add step to check if cache is restored

Description
What is the current behavior?

The cache is not referring to the right directory path for caching nox installed environments.

closes: #1135
What is the new behavior?

Correct the path for nox dependencies to cache.
Does this introduce a breaking change?
No
Attaching screenshots for showing cache size before and after this change and that nox does not reinstall the packages upon using the cache.
Cache size before: ~25MB

Cache size after: ~228MB

Although the cache is right referring to the nox directory path now, the tests themselves take a lot longer as we can see in the pytest summary. We will need to check if we can optimise the tests run duration.

We can see an improvement in the Type-Check job where it is 3x faster now because of caching nox dependencies correctly.
Before: 2min41s

Now: 46s

Attaching screenshots for showing cache size before and after this change and that nox does not reinstall the packages upon using the cache.
Cache size before: ~25MB

Cache size after: ~228MB


Fluent ListMutator API

While the SetMutator add and remove operations understandably return Boolean, the ListMutator equivalents simply return void. I would rather see them return the instance instead so that I could perform e.g. mutableList.add(1).add(2).set(0, 0).insert(1, 1).
Also, having Boolean replaceFirst(Element&Object element, Element replacement) and Boolean replaceLast(Element&Object element, Element replacement), but void replace(Element&Object element, Element replacement) seems inconsistent (and that method would have had a more obvious purpose if named replaceAll).
To be clear, I'm suggesting that every method in ListMutator that currently returns void return the mutator instance instead , save for replace which should return Boolean for consistency.
Edit: Went too fast through the API, removeFirst and removeLast also return Boolean, so at this point the API is inconsistent already, so I'm removing the special case for replace.

@ncorai I think a potential negative is that implementors might then feel obligated to refine all of those methods to return more specific types, which would require a bunch of extra work and maintenance. I'd probably expect to be able to do:
    ArrayList<String> myList = ArrayList<String>().x().y().z();

@jvasileff Just like, say, StringBuilder and AbstractStringBuilder in Java; what extra work is involved?

Yeah, it would only be extra work if extending/satisfying a class/interface that provided default implementations, or if default implementations were later added (like, if addAll didn't originally exist).

In those cases, you'd need to have multiple statements, like you do now anyway.

While the SetMutator add and remove operations understandably return Boolean, the ListMutator equivalents simply return void. I would rather see them return the instance instead

This is not idiomatic Ceylon. So-called "fluent" interfaces are a Java idiom, foreign to Ceylon where we have the named-argument "builder"-style syntax.
Furthermore, in this particular case:

It's confusing, since it looks like the ListMutator.add() has copy-on-write semantics, returning a new List.
It's inconsistent, since SetMutator and MapMutator don't work like this.
It's unnecessary, since we offer addAll() and removeAll() operations for when you're adding or removing multiples.

Finally, I endorse @jvasileff's comment about default implementations not working out nicely with fluent interfaces and inheritance.
I don't want to make this change.

Agreed about the returned instance making it look like it could be a copy.
Regarding API consistency, why do removeFirst, replaceFirst (resp. Last) return Boolean, while remove and replace (and the All variants) return void ?

Good question. I think they should return Integer.
On Sat, Mar 28, 2015 at 9:45 PM, Nicolas Corai<EMAIL_ADDRESS>wrote:

Agreed about the returned instance making it look like it could be a copy.
Regarding API consistency, why do removeFirst, replaceFirst (resp. Last)
return Boolean, while remove and replace (and the All variants) return
void ?
—
Reply to this email directly or view it on GitHub
https://github.com/ceylon/ceylon-sdk/issues/366#issuecomment-87299394.

--
Gavin King
<EMAIL_ADDRESS>http://profiles.google.com/gavin.king
http://ceylon-lang.org
http://hibernate.org
http://seamframework.org

@ncorai I have made that change.


Sort entries in bug-bounty-list.json

While it probably doesn't matter much from a programmatic sense, having the entries sorted would be nice from a human sense.
Using something like jq, this would be as easy as (note: piping could probably be better.. doing it directly seemed to clobber the end file, but i'm sure that's easilysolvable):
cat bug-bounty-list.json | jq 'sort_by(.program_name)' --raw-output > bug-bounty-list2.json
mv bug-bounty-list2.json bug-bounty-list.json

Sorted!


Don't bold box comment text

 BUG: Contents of Box comments should not be bolded. #sprint-jan-19 #tiny


Improve error when a golden image doesn't exist

Currently, if you verify when the golden is not present:
java.lang.AssertionError: Roborazzi: [removed]/ForYouScreenLoading_foldable_compare.png is added.
See compare image at [removed]/ForYouScreenLoading_foldable_compare.png
	at com.github.takahirom.roborazzi.RoborazziOptions$RoborazziCompareReporter$VerifyRoborazziCompareReporter.report(capture.kt:349)
	at com.github.takahirom.roborazzi.RoborazziKt.processOutputImageAndReport(Roborazzi.kt:650)
	at com.github.takahirom.roborazzi.RoborazziKt.access$processOutputImageAndReport(Roborazzi.kt:1)
	at com.github.takahirom.roborazzi.RoborazziKt$captureRoboImage$2.invoke(Roborazzi.kt:274)
	at com.github.takahirom.roborazzi.RoborazziKt$captureRoboImage$2.invoke(Roborazzi.kt:267)
	at com.github.takahirom.roborazzi.RoborazziKt.capture(Roborazzi.kt:708)
	at com.github.takahirom.roborazzi.RoborazziKt.captureRoboImage(Roborazzi.kt:267)
	at com.github.takahirom.roborazzi.RoborazziKt.captureRoboImage(Roborazzi.kt:259)
	at com.github.takahirom.roborazzi.RoborazziKt.captureRoboImage$default(Roborazzi.kt:254)

The "Error" is not "the png is added". It should say that the original file doesn't exist or that there are differences between the images.

Thank you for the feedback. I'm planning to make the following changes. Do you see any other areas that could be improved?
-            "Roborazzi: ${compareReportCaptureResult.compareFile.absolutePath} is added.\n" +
-              "See compare image at ${compareReportCaptureResult.compareFile.absolutePath}"
+            "Roborazzi: The original file (${compareReportCaptureResult.goldenFile.absolutePath}) was not found.\n" +
+              "See the actual image at ${compareReportCaptureResult.actualFile.absolutePath}"

https://github.com/takahirom/roborazzi/pull/133/files#diff-56dd94f09cbeedc48d8c6e7b9c7d0c9453f25103df63997b6c76da895919f352L96-R97


Add key repeat info to KeyEvent

Small change to add key repeat info to KeyEvent
Also - quick question - what's the policy on breakages for Veldrid? If I didn't have the default parameter for repeat on the KeyEvent constructor, would that be a breaking change? If so, would you have to release a new major version? i.e. 5.0.0, or would it be a minor version increment? i.e. 4.8.0
Also - is the change of the ToString function breaking behaviour, in your opinion?

Thanks for the contribution. This look good overall.
Regarding breaking changes and major versions: the policy is to not make any breaking changes. Bumping the major version to 5.0.0 would only be done for a major restructuring of the library.

If I didn't have the default parameter for repeat on the KeyEvent constructor, would that be a breaking change?

Actually, this change as-is would be considered a breaking change, because it effectively removes the 3-argument constructor and adds a 4-argument constructor. It needs to be adjusted so that there is both a 3- and 4-argument constructor. The 3-argument constructor would behave as if false was passed in for the new property.

@trolleyman I merged this in with one additional commit on top:
https://github.com/mellinoe/veldrid/commit/a8001529b6b06be9b49e46a72d5ac2d0e24b6f21
Thanks again for the contribution!

Ah right, thanks for that catch
No problem - thanks for merging this :)
Just a heads up - will probably be doing a few more of these in the next few weeks, as we're looking into using Veldrid at work


Add support for binary types

We should add support for VARBINARY to support ByteBuffer/byte[] representations of binary data.

Hello, I am willing to look into this, but I will need more info. I still new in r2dbc.
I noticed that we got the enum SqlServerType.
I was able to find this:
    VARBINARY(Category.BINARY,          "varbinary"),
    VARBINARYMAX(Category.LONG_BINARY,  "varbinary"),

When you say:  " to support ByteBuffer / byte[] " it would mean new type on the SqlServerType? or create a new TdsDataType and include on the SqlServerType construtor?

I just found also the TypeBuilder. or should there be the new support added?

or maybe if you have any material that I should read/practice before going further, it would be good. ( :

Here are a few pointers:

Protocol documentation (overview): https://msdn.microsoft.com/en-us/library/dd304523.aspx
Protocol documentation (TDS 7.4, rev25): https://winprotocoldoc.blob.core.windows.net/productionwindowsarchives/MS-TDS/[MS-TDS].pdf (see page 26 for data types)

Places that contain already support for BIGBINARY/BIGVARBINARY:

TdsDataType
SqlServerType
TypeBuilder

Places to change:

New ByteArrayCodec
New ByteBufferCodec
DefaultCodecs, add the new codecs.

I'm not sure regarding the default data type, I suppose it would make the most sense to decode binary types to byte[].
A tip for testing: I used the JDBC driver to set up a test case (create table, insert data, select data) and then use the verbose logging (see https://docs.microsoft.com/en-us/sql/connect/jdbc/tracing-driver-operation?view=sql-server-2017, logger com.microsoft.sqlserver.jdbc.internals.TDS.DATA) to intercept the wire protocol. Another possibility is using wireshark or tcpdump.

hello, I will invest time in this task this week.
Could you just help me with one more thing? I want to create a local table, what should be the correct column type?

There would be three types:

BINARY(n)
VARBINARY(n)
VARBINARY(MAX) - this one is related to #28. let’s leave this one for later.


begin adding rewrite based on new ref

WIP.
Based on new reference.

@scottfeldman Going to go ahead and merge this branch now since it's mostly the new cyrw rewrite package and blinky+cyweth still work as before.


Weird crash on new version of EnderIO

Issue Description:
Delete this line after reading it: If this bug occurs in a modpack, please report this to the modpack author first. If you are using an unreleased version of Ender IO (a.k.a development/nightly version), please don't open an issue for features that have not been announced as "finished" or "working". Expect to be ignored if you ignore this template.
What happens:
When I launch my custom Modpack with the new updated version of EnderIo that was released yesterday that I get an error message telling me bad File = Capacitor_machines.xml
Error Message 'key' 'enderio:block_stirling_generator/burntime' is invalid.
What you expected to happen:
Some kind of way to fix it as I have no clue and I try removing the Capacitor_machine.xml and that did nothing.
Steps to reproduce:

...

Affected Versions (Do not use "latest"):

EnderIO: 1.12.2-5.0.30.jar
EnderCore: 1.12.2-0.5.37.jar
Minecraft: 1.12.2
Forge: 1.12.2 <IP_ADDRESS>47
SpongeForge? yes/no no
Optifine? yes/no no
Single Player and/or Server? single player as of right now

Your most recent log file where the issue was present:
https://gist.github.com/TacticalUniverse/215479a75abc09e313ee15d620498a00
Have fun reading this but it is huge so good luck
[pastebin/gist/etc link here]

what log file missing lol

Hopefully this can be fix asap or my custom pack is screwed cause I need to get on to fix other things with the pack.

You have an old copy of the file capacitor_machines.xml in your user recipes. Fix it,


Frequent call of binarize method then run in webworker

It is very misterious, bt...

My guess its GC. Any idea how to avoid this?
I found it in Chrome 78. It works in Firefox and Safari.

Hello everyone !
I tried to set the worker solution from @cozmo , it works great, but for some reason, the drawCode function, that is supposed to draw the detected code in green is not working anymore (works great with the no worker solution).
Any hint about this ?
Thank you so much
Brice