black screen when killing hyprland with super + m in nixos

Hyprland Version
Hyprland, built from branch at commit v0.35.0 ().
Date: 2024-02-05
Tag:
flags: (if any)
System Information:
System name: Linux
Node name: nixos
Release: 6.7.5
Version: https://github.com/hyprwm/Hyprland/pull/1-NixOS SMP PREEMPT_DYNAMIC Fri Feb 16 18:14:32 UTC 2024
GPU information:
04:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Lucienne [1002:164c] (rev c2) (prog-if 00 [VGA controller])
os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05pre586498.0e74ca98a74b"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"
Bug or Regression?
Bug
Description
so when i try to kill hyprland with mod + m it shows me black screen sometimes and sometimes don't so i have tried to do this in sway and i found the logs.
also i use greetd as a display manager i have tired like gdm sddm still this same issue
How to reproduce
like u can't reproduce this all the time but yeah just do mod + m
Crash reports, logs, images, videos
❯ Hyprland
Welcome to Hyprland!
[LOG] Instance Signature: v0.35.0_1708614379
[LOG] Hyprland PID: 10972
[LOG] ===== SYSTEM INFO: =====
[LOG] System name: Linux
[LOG] Node name: nixos
[LOG] Release: 6.7.5
[LOG] Version: #1-NixOS SMP PREEMPT_DYNAMIC Fri Feb 16 18:14:32 UTC 2024
[LOG] GPU information:
04:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Lucienne [1002:164c] (rev c2) (prog-if 00 [VGA controller])
[LOG] os-release:
ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05pre586498.0e74ca98a74b"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"
[LOG] ========================
[INFO] If you are crashing, or encounter any bugs, please consult https://wiki.hyprland.org/Crashes-and-Bugs/
[LOG]
Current splash: Compile, wait for 20 minutes, notice a new commit, compile again.
[LOG] Creating the HookSystem!
[LOG] Creating the KeybindManager!
[LOG] [hookSystem] New hook event registered: configReloaded
[LOG] Creating the AnimationManager!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 70.40µs. Estimated average calc time: 0.34µs.
[LOG] Creating the ConfigManager!
[LOG] NOTE: further logs to stdout / logfile are disabled by default. Use debug:disable_logs and debug:enable_stdout_logs to override this.
[LOG] Creating the CHyprError!
[LOG] [hookSystem] New hook event registered: focusedMon
[LOG] [hookSystem] New hook event registered: preRender
[LOG] Creating the LayoutManager!
[LOG] [hookSystem] New hook event registered: preConfigReload
[LOG] Reloading the config!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 30.10µs. Estimated average calc time: 0.29µs.
[LOG] Using config: /home/coco/.config/hypr/hyprland.conf
[LOG] Registered dynamic var "$terminal" -> alacritty
[LOG] Registered dynamic var "$fileManager" -> kitty -e yazi
[LOG] Registered dynamic var "$menu" -> rofi -show drun
[LOG] Registered dynamic var "$browser" -> brave
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 30.52µs. Estimated average calc time: 0.34µs.
[LOG] Registered dynamic var "$mainMod" -> SUPER
amdgpu: amdgpu_cs_ctx_create2 failed. (-13)
Error: "There seems to already be another instance running..."
/bin/sh: line 1: sway-audio-idle-inhibit: command not found
registry: adding output 48
gamma control of output 48 failed
calculated sun trajectory: dawn 06:43, sunrise 07:21, sunset 18:25, dusk 19:04
setting temperature on output '48' to 4000 K
(EE) could not connect to wayland server
xhost:  unable to open display ":1"
(lxqt-policykit-agent:11006): Gtk-WARNING **: 20:36:22.019: cannot open display: :1
~ took 2s
❯
(nm-applet:11005): Gtk-WARNING **: 20:36:22.138: cannot open display: :1
(waybar:11003): Gtk-WARNING **: 20:36:22.157: cannot open display: :1
(.blueman-applet-wrapped:11008): Gtk-CRITICAL **: 20:36:22.228: gtk_icon_theme_get_for_screen: assertion 'GDK_IS_SCREEN (screen)' failed
Traceback (most recent call last):
File "/nix/store/mid4741yhahc6zhmv1ikiq99708gvlpj-blueman-2.3.5/bin/..blueman-applet-wrapped-wrapped", line 41, in
app = BluemanApplet()
^^^^^^^^^^^^^^^
File "/nix/store/mid4741yhahc6zhmv1ikiq99708gvlpj-blueman-2.3.5/lib/python3.11/site-packages/blueman/main/Applet.py", line 19, in init
setup_icon_path()
File "/nix/store/mid4741yhahc6zhmv1ikiq99708gvlpj-blueman-2.3.5/lib/python3.11/site-packages/blueman/Functions.py", line 155, in setup_icon_path
ic.prepend_search_path(ICON_PATH)
^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'prepend_search_path'
[2024-02-22 20:36:38.040] [error] Error calling StartServiceByName for org.freedesktop.portal.Desktop: Timeout was reached
❯

#3558


Replication over VPN

Azure Site Recovery now allows us to use Azure Private Link private endpoints to replicate your on-premises machines to a virtual network in Azure.  So, could you please update this FAQ related to replication over VPN?
https://docs.microsoft.com/en-us/azure/site-recovery/site-recovery-faq#can-i-replicate-over-a-site-to-site-vpn-to-azure
https://docs.microsoft.com/en-us/azure/site-recovery/site-recovery-faq#why-cant-i-replicate-over-vpn

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a8f2ca3-19b1-330d-8dd3-6dcdce38c8d4
Version Independent ID: 700335aa-c802-0314-1579-3493918f5000
Content: General questions about the Azure Site Recovery service - Azure Site Recovery
Content Source: articles/site-recovery/site-recovery-faq.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@ToruMakabe  Thank you for bringing this to our notice, we will review the feedback and update the document accordingly.

Update:
We're discussing (Toru) on this internally with the author, based on the review we will update the document as appropriate.
We're closing this thread for now, but tracking internally. Thanks again for the discussion and feedback on this, Toru.


Add template

You could do something like this to avoid copying the lock:
      flake = {
        templates.default.path = (inputs.nixpkgs.lib.cleanSourceWith {
          src = ./.;
          filter = path: type: baseNameOf path == "flake.nix";
        }).outPath;
      };

Well, not src = ./., but the example


Update FilePicker to 0.8.x

Resolves #356 (I think)

Updated! Thank you for taking the time to review my PR.
callback is in the same order as source now.
I've addressed the other types you pointed out.
I've changed the default forLAST_DISPLAY_MODE to simply 'list' - previous implementation had it as FilePicker.DISPLAY_MODES.List which isn't actually a meaningful value.

Sorry, I forgot to mark the last comment as resolved.
So I think we're ready for another review. All the previous items have been addressed, plus I've added more options types to replace those which were previously Record<string, any>.
I've also broken up the result types, so BrowseResult is different to ConfigurePathResult.
Finally, and this may be the controversial bit - I've created a helper type called PromisedReturnType which helps when you're forwarding the result of a promise. There are other ways of doing this, including just hard-coding the promised type, but this feels like the most correct solution. If I have over-engineered this just for sake of making _onDrop cleaner I will revert those changes :)

Yes, that extra helper type was pointless. I've move PromisedType into utils.d.ts and in doing so I no longer need an import in filePicker.d.ts so I've reverted the declare global I'd added there, so the diff is less catastrophic.

Oh and thanks to the link to the contrib guidelines, I hadn't seen that.

Done! Thanks for the review.


4035 manufacturer donations

Resolves #4035
Description
This PR makes changes to sort the manufacturer donations summary report by each manufacturer's most recent donation. Addressing each of the issue's details:

manufacturer_donations_summary.html.erb was modified so the page is now headed "Recent Manufacturer Donations" instead of "Top Manufacturer Donations".
A new function by_donation_date was implemented for manufacturer.rb to return a set of Manufacturers based on their most recent Donation in a given time frame. reports_controller.rb was modified to use this new function to order its data and thus, the manufacturer donations summary page.
The function by_donation_date filters Donations by the given time frame the same way the existing function by_donation_count does.
The manufacturer donations summary page continues to show, in brackets, the total number of Donations per Manufacturer in the given time frame.
by_donation_date orders by when the Donations happened (issued_at) as opposed to when the record was created (created_at)

In addition, donations_controller.rb was modified to sort its set of Donations by issued_at instead of created_at. This results in the donations index page reflecting the same ordering as the manufacturer donations summary.
While by_donation_count was previously only used in the reports_controller.rb, I chose not to modify or delete it as sorting the Manufacturers by the quantity of recent donations doesn't seem fundamentally erroneous, is functionally distinct from by_donation_date, and could find use in the future.
Type of change

Bug fix
New feature

How Has This Been Tested?
The following tests were added or changed:

A unit test for the new function was added to manufacturer_spec.rb.
manufacturer_donations_summary_spec.rb was updated to expect the manufacturer entries in order of most recent donation.
A testcase was added to donation_system_spec.rb to expect the entries in the donations index page to be ordered by issued_at.

I manually verified the functional changes to the manufacturer donations and donations index pages.
Screenshots

Manufacturer donations before changes

Donations index before changes

Manufacturer donations after changes

Donations index after changes

Manufacturer donations after changes with expanded filter range
Note that the order has changed because a new latest donation is now in the filter, and the bracketed number has updated accordingly.

Donations index after changes with expanded filter range

Hey @Benjamin-Couey We do have some known flaky tests.   We seem to be collecting them over in issue #4557 at the moment, if you want to add yours in, along with the seed that causes it.

"In addition, donations_controller.rb was modified to sort its set of Donations by issued_at instead of created_at. This results in the donations index page reflecting the same ordering as the manufacturer donations summary."
That is  out of scope for this issue...
At least some of the banks tend to have bunches of donations in a single day.  If we're to change this, we need to consider what the order within a day should be so that it makes sense for them.

I guess there was a miscommunication on the issue here. Is there a different page I should modify?

Hmm.  Apparently I forgot I said that!

Alright, I reverted the commits that modified the donations_controller.rb and added the associated test.

This is more of a question for @cielf. But maybe we want to add some language that says how the manufacturers are sorted? Because now a user might see something like this:

And not know how they are sorted (by most recent donation date).
If we wanted to really make it clear we could add a column for "Last date of donation" (or similar) and then it would be obvious how they are sorted.
But maybe those are just ideas for future improvements.

Let's leave it for now.    We recently carved all these small reports out of an earlier version of our dashboard -- one of the things that gives us is the ability to see which if these are being well-used,  so we can prioritized improvements to more highly-used areas.

A minor point from a functional point of view -- we didn't tell you how to determine the order if you had multiple donations on the same day.  I would think dropping back to creation date makes sense in that case.

I'm willing for this to go in as it is -- I'd like a slight tweak to the order, but it wasn't asked for in the issue.


Plugin crash with Valueerror 12 not in list.

Issue description
The plugin crashes when I go to the zigbee2mqtt settings page in domoticz (top bar -> Custom -> Zigbee2mqtt
Hope you can help find the cause.
Additional information
Zigbee2MQTT version: 21.33.0
Python version: 3.9.2
Domoticz version:2023.3
Plugin version: 3.1 beta and 3.2.0-beta
Logs
2023-10-19 14:57:00.235 Status: Zigbee2MQTT: Exiting work loop.
2023-10-19 14:57:00.288 Status: Zigbee2MQTT: Stopping threads.
2023-10-19 14:57:00.288 Status: Zigbee2MQTT: Stopped.
2023-10-19 14:57:41.860 Status: Zigbee2MQTT: Started.
2023-10-19 14:57:41.864 Status: Zigbee2MQTT: Entering work loop.
2023-10-19 14:57:50.365 Status: Zigbee2MQTT: Initialized version 3.2.0-beta
2023-10-19 14:59:49.892 Error: Zigbee2MQTT: Call to function 'onMessage' failed, exception details:
2023-10-19 14:59:49.915 Error: Zigbee2MQTT: Traceback (most recent call last):
2023-10-19 14:59:49.915 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/devices/switch/selector_switch.py", line 41, in get_string_value
2023-10-19 14:59:49.915 Error: Zigbee2MQTT: index = self.level_values.index(value)
2023-10-19 14:59:49.915 Error: Zigbee2MQTT: ValueError: 12 is not in list
2023-10-19 14:59:49.915 Error: Zigbee2MQTT:
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: During handling of the above exception, another exception occurred:
2023-10-19 14:59:49.916 Error: Zigbee2MQTT:
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: Traceback (most recent call last):
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/devices/device.py", line 194, in handle_message
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: }, **self.get_device_args(value, device, message))
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/devices/device.py", line 171, in get_device_args
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: 'nValue': self.get_numeric_value(value, device),
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/devices/switch/selector_switch.py", line 37, in get_numeric_value
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: return 1 if self.get_string_value(value, device) != '0' else 0
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/devices/switch/selector_switch.py", line 43, in get_string_value
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: domoticz.debug('Unable to find selector switch level for value "' + value + '", device: ' + device.Name)
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: TypeError: can only concatenate str (not "int") to str
2023-10-19 14:59:49.916 Error: Zigbee2MQTT:
2023-10-19 14:59:49.916 Error: Zigbee2MQTT: During handling of the above exception, another exception occurred:
2023-10-19 14:59:49.917 Error: Zigbee2MQTT:
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: Traceback (most recent call last):
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/plugin.py", line 299, in onMessage
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: _plugin.onMessage(Connection, Data)
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/plugin.py", line 137, in onMessage
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: self.mqttClient.onMessage(Connection, Data)
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/mqtt.py", line 167, in onMessage
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: self.on_mqtt_message_cb(topic, message)
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/plugin.py", line 215, in onMQTTPublish
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: self.devices_manager.handle_mqtt_message(topic, message)
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/devices_manager.py", line 61, in handle_mqtt_message
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: adapter.handle_mqtt_message(zigbee_message)
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/adapters/base_adapter.py", line 64, in handle_mqtt_message
2023-10-19 14:59:49.917 Error: Zigbee2MQTT: device.handle_message(device_data, converted_message)
2023-10-19 14:59:49.918 Error: Zigbee2MQTT: File "/var/www/domoticz/plugins/zigbee2mqtt/devices/device.py", line 196, in handle_message
2023-10-19 14:59:49.918 Error: Zigbee2MQTT: domoticz.error('Can't calculate the value for device ' + device.ID + ' from raw value "' + str(value) + '"')
2023-10-19 14:59:49.918 Error: Zigbee2MQTT: TypeError: can only concatenate str (not "int") to str

Could you please update the plugin and check, there should be no crash anymore

Thanks. i have upgraded and will keep an eye on the log!

Hi,
Today I added a zigbee device to the network. It was nicely picked up he plugin and added to domoticz. All is fine. This issue can bel closed


Finalize UI for context metadata

Finalize designs for UI components of the context metadata
Context metadata designs in the UpGrade UI should include

Banners or warnings for when part of an experiment is invalid according to the context metadata
A switch to allow us ignore context, as a global feature
A way for admins to view the full structure of the context metadata

@zackcl do we have a design for context metadata validation in the experiment create/edit stepper?


HANDLE types should support Sync trait

I'm new to Rust, so if my understanding is misguided, do let me know.
I'm trying to use a handle - HMODULE in a static HashMap. This is not allowed because the trait std::marker::Sync is not satisfied on *mut winapi::HINSTANCE__.
I think DECLARE_HANDLE should define a type that supports the Sync trait.
Handles are not pointers even though they're defined that way in winnt.h.

You should be wrapping your handles in a newtype so that you can do stuff like automatically closing the handle when dropped. One of the benefits of such a wrapper is you can assert that it is thread safe like so:
struct Handle(HANDLE);
unsafe impl Sync for Handle {}

Related issue: https://github.com/retep998/winapi-rs/issues/360

I see.
Does it make sense for winapi to define a wrapper type for at least some handle types?  So for example, you could have a Raw type that is the pointer, and the wrapper type?
This would also introduce a level of type safety that isn't present in C/C++ with Windows handles.

winapi is strictly raw bindings. It does not attempt to provide wrappers (aside from the minimal amount for COM interfaces) or make anything safe. Anyone is free to create their own library on top of winapi which provides thread safe wrappers.


[WIP]Feature/prepare yaml roundtrip tests

Improve converter

Add converter junit5 test cases
Add derived_from type to ArtifactTypes for round trip

either implementation or deployment

Add WineryPropertiesDefinition while converting from yaml to xml
Fix NodeTypeImplementation Builder
Add some comments
Add some @nullable and @nonnull annotations
Replace empty exception catches with error logs

[x] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit
[x] Ensure that the commit message is a good commit message
[x] Ensure to use auto format in all files
[x] Ensure that you appear in NOTICE at Copyright Holders
[x] Tests created for changes
[ ] Documentation updated (if needed)
[ ] Screenshots added (for UI changes)

Can one of the admins verify this patch?

Closed due to inactivity.


Automatically run deepdive compile when necessary

Currently, the user has to remember to manually run deepdive compile after making changes.  Some users want deepdive do to be smarter and conservatively compile by itself when needed.  The process timestamps can be invalidated whenever the user switches database or makes changes to the udf files.  The data timestamps may well be kept per db.url and we could rely on git to detect changes to files as well.  However, ultimately the user should decide to compile or not, so maybe it can simply show a warning or ask to recompile interactively.

I'd prefer DD to auto compile by default since that's the most common use case.


Junit Jupiter version is removed when used in JvmTestSuite

Describe the issue
Junit Jupiter version is removed from catalog despite being used:
testing {
    suites {
        val test by getting(JvmTestSuite::class) {
            useJUnitJupiter(libs.versions.jupiter)
        }
    }
}

[versions]
jupiter = "5.10.1"

Steps to reproduce
Execute versionCatalogUpdate on my repo
Stacktrace
none

Most likely the versions plugin does not detect this as a dependency. The workaround is to to keep the entry using a @keep comment. However, it will also not be updated because the versions plugin doesn't see it as a dependency.
You can also try out the new resolver that will be the default in the next version and does not depend on the versions plugin. The new resolver looks at the toml file as the source of truth and will therefore also keep the entry up to date.


InjectBoundHtml updates

resolves http://dartbug.com/21989 by adding support for custom NodeValidator and/or TreeSanitizer

hmm history here is a bit weird, I will see if I can clean that up

lgtm


Duplicate namespace silently ignored

Defining a namespace more than once is silently ignored.  E.g. the following Cadl
import "@cadl-lang/rest";
import "@cadl-lang/openapi3";

using Cadl.Http;

@route("/")
namespace root {
  op read(): string;
}

@route("/test")
namespace root {
  op getStatus(): string;
}

creates the /test path but the root path is not emitted (by the openapi3 emitter).
I'm not sure if this is a problem in the emitter or in what is passed in to the emitter.

That's an interesting issue. Feel like in general you should be able to merge the namespaces(Like csharp namespaces) but here the metadata override the previous one.
Guess maybe we should emit a diagnostic that namespace root has 2 @route

first operation is dropped
should be checking that decorators are not in conflict when merging namespaces
investigate for a fix in v1


Skip validation if we don't expect the antivirus to be present

We'd like to allow developers to upload files in development without
expecting them to install Clamav.
We initially assumed that scanner.available? will return false since
Clamav won't be installed locally. However, calling available?
just checks that Ratonvirus::Clamby::Base is an executable class
(which is always true because it's a class present in the
ratonvirus-clamby gem). The scan will therefore still be run locally but
will fail when it doesn't find an antivirus.
So we'd actually block people from uploading when running in development
because it looks like the scanner is available.
We've set force_availability as a feature flag to indicate whether we
expect an antivirus to be present. Let's return early in the validation
class without scanning when we set force_availability to false.
This means we can now upload to our heart's content in development, but
still expect the antivirus to be present everywhere else.
While we're here we'd like to make sure that we expect the antivirus to
be present by default. In case we ever set up a new environment (pentest,
disaster recovery), we won't need to worry about setting this to true in
the config. By default we'll expect an antivirus to be installed or we raise
an error.
Trello

Sounds good to me 👍


Use --openssl-use-def-ca-store when building node

Closes #12

CI failed because of a time limit. Anything I can do?

@kylecarbs can we merge this anyway and hope for the best 🤞?


Fixed CSS issue with delete button. Made link open in new tab even if…

Microsoft removed some icon CSS styles, which broke the "delete" button on the links.
A new tab was not being opened even when "Open in new tab" was selected if the url was on the same SharePoint site. I added code to include data-interception="off" so that a new tab would be opened.

Maybe I should just update this whole web part to use the latest versions of the libraries (SPFx, pnp, React 16 etc)?

Sure thats a better solution, but also please include
 linkProps["data-interception"] = "off";
in the link so that it opens in a new tab even if its linked to a page within the same SharePoint Site

Yeah I'll put an option in to respect the router or not.


Support building on Windows.

This PR makes it so Fuzi can be used in Swift projects on Windows.

Add .build/ to .gitignore.
Add CMakeLists.txt where needed to build Fuzi with CMake.
Add Vendor with CMakeLists.txt to fetch and build LibXml2 on Windows, which is not available by default.
Fix issue relating to the fact that a C long on Windows is 4 bytes instead of 8.
CoreFoundation is not available on Windows, so replace usage of CFXxx() functions to map IANA encodings to String.Encoding with a String.Encoding extension that does the mapping.
Fix a problem with libxml2 C functions wanting a mutable pointer argument.
Fix issue where one member of a set of flags is a #define instead of a member of the enum proper so it is imported as the wrong type on Windows.

To build on Windows, use the Ninja generator:
cmake -S . -B build -G Ninja
cmake --build .\build\

Verified that the project still builds on MacOS with swift build.

@cezheng do you have any feedback?  I'd love to get your opinion on Windows support, and I'm happy to iterate.


minor

Pull Request Test Coverage Report for Build 198

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 54.466%

Totals

Change from base Build 196:
-0.01%

Covered Lines:
4180

Relevant Lines:
7113

💛  - Coveralls


adding jay to index

Docs Build status updates of commit 762c459:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/index.html.yml
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Created two functions for multiple hashtags

get_hashtags() takes input from user and seprates the hashtags
get_multi_tweets() gathers tweets from theses hash tags

@nutstache Thank you for the PR! You can find a few more issues here!


[Subtask]: Modify transaction details design for stardust

Task description
Now that we support feature blocks and have a byte cost in stardust, we should show these details in the transaction details pane.
Requirements

[ ] Feature block details are displayed in transaction details
[ ] Byte cost is displayed in transaction details
[ ] Ensure the correct and relevant information is present
[ ] Ensure copy and visit explorer actions is present

Acceptance criteria
Design approved by epic owner / product owner
Creation checklist

[X] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

Looks good 👍 , just need to consider how this changes with claiming flow in other task and different assets in M5.


Cannot read property 'extend' of undefined

on line 20
this.options = Waypoint.Adapter.extend({}, Waypoint.defaults, options);

Same issue for me !

+1

Hi guys. Are you perhaps using Waypoints with jQuery?
The new default Waypoints doesn't work with jQuery and will generate this error.
If you are using jQuery make sure to download the jQuery version (jquery.waypoints.js or jquery.waypoints.min.js) and use it instead.

Had the same issue, did like @nadavrt said and now it works, but to be honest I had a problem to find jquery.waypoints.js... For those who will try to find it: waypoints/libs/jquery.waypoints.js


Update persist modules build to latest timestamp

Purpose
$subject
Fixes:
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the specification
[ ] Updated the changelog
[ ] Added tests

Duplicate PR


wsl-vpnkit: init at 0.4.1

Description of changes

Add the package wsl-vpnkit which can be used to revive network connectivity within WSL when connecting to certain VPN:s that would otherwise break the network within WSL. The main caveat with the packaging was that I could not re-use the nixpkgs gvproxy since it needed the Windows version, hence there is an override to cross-compile it and then refer to the produced exe in the wrapper. Script also needs to be run as root.
Cross linking previous issue from NixOS-WSL
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@SuperSandro2000 This is ready for another pass, in the meantime I the gvproxy changed the name of the "vm" binary, so updated that and I also tested this again (inside a systemd unit) after the resholve switch and found it didn't manage to find ping/iptables, but found workarounds for those. So now it is also tested to be executed in systemd environment which is "leaking less state".
I guess the only open question is regarding the gvproxy windows executable should be an option or go to the top-level. I am not sure who knows could decide such a thing. Personally I know no other use case for it at this point.

Fine for now :)


Add member profile

@sot528

added bato and kamei's profile
deleted kamei's twitter button (he doesn't have an account)

I especially want you to check the code which enable only fb button to be on profile.

@sot528 Thanks for your review! There are always lots of things to learn from your review points. I fixed all the points you mentioned, so please check it if it's correct!

LGTM!!


required tags for all resources

Hello,
Right now required-tags config rule supports only a set of resources, is there a way to add the rest of the resources ? may be it already exists ?
Would appreciate your help.

Only the resources supported by Config are in required-tags, so it is limited indeed. Expand it to all tag is possible, it will require to track every single API for each service retrieving the tag value. I mark it as "new rule requests.

Is it possible to have the source code of the current lambda and I can create a new custom lambda with the rest of the resources ?

It is not possible. The logic is not complicated though the CI has a Tag key, so it is just a basic comparison with the input parameters. We cannot use that, because we will need to do a periodic rule.

Afternoon, I was checking the list of resources that can be used with this rule,  Elasticache and Lambda are NOT yet on the list... Any idea if those resources will be added in the future, is yes, approximately when?

keen to have lambda added to the list

@jongogogo any update on this? seems like something that should not be unordinary considering how widely tags are used.


[quesiton] Test runner & chromatic coordination

Describe the bug
I have installed storybook test runner and axe-playwright to include accessibility tests when my test runner executes. I know it is possible to have interaction tests appearing in chromatic, but is it possible to have accessibility checks from axe-playwright and test runner appear in chromatic?

Hey there @ChristianTumamo! Thanks for opening an issue here, and for using the test-runner!
The Storybook test-runner does not relate to Chromatic, although they work well in tandem. Your question is more like a feature request to Chromatic, so I would suggest reaching out to their customer support to share your thoughts! I believe they are taking this into consideration already, but it doesn't hurt to show your appreciation for such feature in their app!


[Add observation] Required fields show errors when form is opened

To Reproduce

Add a feature
Add an observation for a form with required fields

Expected behavior
Blank required fields show errors immediately.
Actual behavior
Required fields do not show errors only on blur or when form is saved.
Screenshots

By @gino-m
"We can show a * next to required field labels for now"


Create gem to distribute the tech docs template

This converts the tech-docs-template repo into a gem. It is a fork of the original https://github.com/alphagov/tech-docs-template, which will be updated to use this gem. This will mean the 2 repos will have a shared git history.
What happens in this commit?

Adds a .gemspec so that we'll be able to release this as a gem
Adds a example directory, which is an example of a documentation site. It can be used in day-to-day development and is used to build an integration test.
Integrate the table_of_contents gem, which is only used for these tech docs. Because the gem was never released to Rubygems we can't make it a dependency of this gem (even if we wanted to).
Add TechDocs.configure(self) which sites use to configure itself. I've done some experimentation to make this a proper Middleman extension but that seemed to be a pretty unreliable way of configuration.

Testing
You can see it in action here:

https://github.com/alphagov/govuk-content-api-docs/pull/45 updates the content API docs

Part of https://github.com/alphagov/tech-docs-template/issues/126.

Do still think you should prefix it with govuk if it's going to rubygems.

I've renamed it to govuk_tech_docs everywhere.

yay have a big ✅ then.


ngrok memory leak

As a Kubefirst developer I want to handle a channel that is open for ngrok. So that, after the channel is not in use anymore, we close the running go routine and avoid memory leak.
AC1: ngrok functionality behaves the same
AC2: the opened channel is closed when the installation finish

Once the channel is closed, atlantis will not be usable on local. Is this the intended behavior?

Once the channel is closed, atlantis will not be usable on local. Is this the intended behavior?

yes, a non closed channel is a memory leak, we can close the channel before exiting the main process/kubefirst install.


Update settings.ini to fix local images when not using a root url

Per https://forums.fast.ai/t/fastpages-github-pages-blog-using-nbdev/62828/79

This injects liquid code into the URL generated by nbdev to correct the relative path.

/preview

/preview

/chatops

/preview


profiles/base: adding ifenslave

Motivation for this change
In some enterprise datacenter, the network is setup with LACP 802.3ad by default. In order to get a network connection, you need to create a bonded interface. For this to happen, the ifenslave utility is indeed in additional to ip/ifconfig.
I would like to propose to add this to our default profile for the installation medias, give the utility itself is only 36K, but extremly useful when dealing in non-cloud environments.
36K	/nix/store/sgii49fyg2pcsih78h6fmx1dk5bmjp21-ifenslave-1.1.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Since this is indeed very small and only impacting the install media, I think it looks okay to me:
[nix-shell:~/Downloads/thinking-intensifies]$ ldd /nix/store/vga49x750d5hljxrblib1rza8k9fb1ix-ifenslave-1.1.0/bin/ifenslave
	linux-vdso.so.1 (0x00007ffcc79d5000)
	libc.so.6 => /nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6 (0x00007fbf12737000)
	/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/ld-linux-x86-64.so.2 => /nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib64/ld-linux-x86-64.so.2 (0x00007fbf128f8000)

[nix-shell:~/Downloads/thinking-intensifies]$ nix-store --query --requisites /nix/store/vga49x750d5hljxrblib1rza8k9fb1ix-ifenslave-1.1.0/bin/ifenslave
/nix/store/mxaxvp33wg9sim8qh2kkw041v492bvxj-libunistring-0.9.10
/nix/store/hjng28vbd73qq9iz9j8r397x19aa8fp9-libidn2-2.3.0
/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30
/nix/store/vga49x750d5hljxrblib1rza8k9fb1ix-ifenslave-1.1.0

What can ifenslave do that ip link cannot? Creating a bond and adding slave devices to it are definitely possible.

What can ifenslave do that ip link cannot? Creating a bond and adding slave devices to it are definitely possible.

Oh, damn, today I have learned... :) thank you for letting me know.


[SDK BUG] MinWindowSize/MaxWindowSize works unexpectedly

Describe the bug
MinWindowSize function do not work expectedly, and MaxWindowSize function makes the program crash.
To Reproduce
Steps to reproduce the behavior:

Clone and build WidgetAdvSample
Debug in x64 mode; Win+G
Click on SetMinWindowSize (behavior 1)
Click on SetMaxWindowSize (behavior 2)

Behavior & Screenshots

after MinWindowSize({800, 600}), the window can be resized to very small.

after MaxWindowSize, nothings happens. But when you try to resize or drag the window, the whole game bar crashed (how can i get the crash log?).

Desktop:

OS version: Windows 10 2004 build 19041.264
Game Bar version  5.320.5291.0
SDK version: XboxGameBar v5.1.200401003
Target platform version: Windows 10.0.19041.0  (Tried 10.0.17763.0 also)

Should be fixed in the current 20.06 release - please let us know if you're still seeing this.

@hamiltonia What is the fix. Any fixed sized for the Widget etc.

The fix was internal to Game Bar and the SDK.


build and test on circleci

https://circleci.com/gh/jumanjihouse/puppet-on-coreos/9 is clean
:ship:


sap.m.UploadCollection selectionChange fired more than once

OpenUI5 version:

1.38.1 (built at 20160503-1007, last change )
latest as well
Browser/version (+device/version):
Google Chrome 56.0.2924.87
Firefox 51.0.1 (32-Bit)

Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible):
https://jsbin.com/lesujadupo/edit?html,output
For each uploaded file, the number of times "somehow" that selectionChange is called is +1.
So if you upload 3 files, it will be called 3 times.
Steps to reproduce the problem:

Open the JS Bin Url
Upload a file (it will not showed, no real upload)
select 1 of the 3 existing files

What is the expected result?
Chrome Console: should be logged only 1 time the:

SelectionChange - new Date()

OR
Under the UploadCollection there is a Count that goes up by 1 every time the selection changes
What happens instead?
Chrome Console: After every file upload, the number of logged "SelectionChange - new Date()" is added by 1.
OR
Under the UploadCollection there is a Count that goes up by N every time the selection changes, with N being the number of uploaded files
Any other information? (attach screenshot if possible)

Hi @adrian-zguri,
Thanks for the ticket.
Internal incident<PHONE_NUMBER>  has been opened for this issue.

Hi @adrian-zguri ,
Thanks for the bug report. I'm able to reproduce the issue and found the root cause. Downports to the release will fowllow.
Best regards,
Oli..

Happy to hear that.
Best regards, adrian.

Hello @adrian-zguri ,
the fix is submitted for the master branch. Downports I will start tomorrow. I expect that the fix will be included in 1.38.19.
Best regards,
Oli..


Make attiny_hal::pins! and atmega_hal::pins! feature-agnostic

This removes the feature-specific (and therefore MCU-specific) pins! macro and replaces it with a feature-agnostic pins! macro + an MCU-specific wrapper function.
This is initial work to enable a refractor that will switch all crates in arduino-hal to use additive features, as is the recommended best practice. See https://github.com/Rahix/avr-hal/issues/602 for more context.
Testing:

Verified that cargo build -p arduino-hal --features <board> succeeds for all boards
Verified that cargo build --bins succeeds for every example/*

Using stacked PRs — see https://github.com/innermatrix/avr-hal/pull/1#issuecomment-2489875246 for a preview of the follow-on work in progress.

Canceling this PR because I came up with a way of doing this that doesn't require code changes in clients of arduino-hal


Maths Plugin Improvement Suggestion

Right now, I think Mathematics is displayed like this:

(correct me if I'm wrong...)

Only TeX notation is currently supported. (There are other input formats)
Only dollar signs are recognised as maths delimiters.
Maths is stored as a <script> tag in the HTML file, (which is good, better than leaving it raw, solving issues such as #3, but maybe MathML is better for accessibility and other reasons).
TeX notation is stored within the script element.
MathJax is required to display the maths.
Not all EPUB readers support MathJax, and so some EPUB readers, and engines that don't run JS can't display the mathematics. E.g. GitbookIO/gitbook#295

Suggestion: Would it be great if it was like this?

ASCIIMath, TeX syntax, and MathML are all recognised and parsed (authors can choose which one to use through the plugin options).
Various delimiters for mathematics are recognised and supported (chosen by the author through plugin options, maybe author uses a lot of dollar signs? perhaps.)
MathML and SVG are generated. Since MathJax is not lightning fast, SVG is shown until all mathematics are typeset completely.
SVG is also used as a backup for software that don't support MathML nor MathJax. SVG can be disabled through the option.
Perhaps something like MathJax-Node could help us with generating MathML and SVG?
Authors can define custom macros for MathJax through the plugin options. This would make our lives a lot easier and make our markdown source look more beautiful (and readable).
Original notation source is preserved in MathML annotation.
MathJax is served with the webpage, so that mathematics is rendered consistently. (Authors can also choose the maths font settings and other useful settings as well)

Summary
What do you guys, @SamyPesse and @AaronO, think?

Plugin options that are possibly great to have:

choose input notation
choose maths delimiters
enable/disable SVG being generated
custom macros and all those kind of good stuff that are in MathJax configurations.

Is it possible to add mhchem extension to MathJax. I really need it for the chemistry book. In mathjax configuration docs the recommendation is to  "use this extension in your own configurations, add it to the extensions array in the TeX block:
TeX: {
extensions: ["mhchem.js"]
}"
But if try to do it in book.json it just doesn't work.

Let single dollar sign be supported as inline math delimiter? This could enable converting existing latex files into gitbooks.

@vasalx It should also be possible to force the extension to load by putting \require{mhchem} in some equation.
http://docs.mathjax.org/en/latest/tex.html#tex-and-latex-extensions

Thanks @ErnWong for this great summary of expected improvements, it 's very clearly exposed !
Does anybody currently working on it ? I'll be happy to help :)
Especially, I will be glad to be able to use another input notation (ASCIIMath).
What about simply using config=TeX-MML-AM_HTMLorMML  ?
Isn't it possible to enable a full configuration of mathjax by linking some MathJax.Hub.Config parameters to book.json "pluginsConfig" ?

+1 for single dollar sign delimiter for maximum compatibility with existing latex

As @dsoto  said it would be great to have compatibility with existing latex

All math is inline math now, can't seem to use display math.


mdc migration: Card (use raised instead of outlined)

This just updates the "mat-card" components (and the initial changes in styles.scss to prepare migration); this one is fairly straightforward, the migration script introduces `appearance: "outlined" to the html templates, which looked wrong, but switching it to "raised" looked like the way we have styled it previously.
Please make sure everything looks normal!
https://material.angular.io/components/card/api
#1196

Everything looks good as I checked.


Adding multiple sheets in loop with only one save

I am trying to loop over a dictionary and create a worksheet for each item in the dictionary.  My initial approach works but takes a big time hit because I it is exporting and saving on each pass.  A watered down example of this approach is below.
foreach ($x in Get-Process | Where-Object {$_.Id -lt 1000}) {
Export-Excel -Path ./test.xlsx -ClearSheet -WorkSheetname $x.Id -Title $x.Name
}
I end up with the desired result with each process ID as a new worksheet.  This example only takes a few seconds but for my use case it will be doing this about 70-100 worksheets with rows of data for each sheet anywhere from 30-100 rows.

I have attempted to use the passthru and then a final save at the end but I am over writing my data and only ending up with the last result as a worksheet.  This method is almost instantaneous compared to the above method.
foreach ($x in Get-Process | Where-Object {$_.Id -lt 1000}) {
$excel = Export-Excel -Path ./test.xlsx -ClearSheet -WorkSheetname $x.Id -Title $x.Name -PassThru
}
Close-ExcelPackage $excel

Can someone please assist me in setting this up so that I am not overwriting each previous worksheet.  I have attempted to add the ( += ) to my code but I get an error because there is no method named "op_Addition"
$excel += Export-Excel -Path ./test.xlsx -ClearSheet -WorkSheetname $x.Id -Title $x.Name -PassThru

the second and subsequent though the loop you need to do time you need to use
export-excel -excelPackage $excel
It can be easier as
$excel = Open-ExcelPackage ./test.xlsx -Create
foreach () { $excel = whatever | export-excel -excelPackage $excel -passthrough <<etc>> }
Close-excelpackage $excel

Thank you @jhoneill! The open package is exactly what I needed!


(question) could quarkus.langchain4j.ollama.embedding-model.model-id also give vector dimension ?

hello
the root use case behind issue opening is : ollama https://ollama.com/library/nomic-embed-text produces a Vector of 768 byte dimension, which does not fit into the 1536 dimension inherited from OpenAI, or the 384 dimension from in memory embedders
it throws an Exception at first embedding storage (using nomic) because the create table embeddings done by langchain4j for pgvector defaults to 1536.
of course the documentation mentions : the pgvector has to be set, i.e https://docs.quarkiverse.io/quarkus-langchain4j/dev/pgvector-store.html. however, it does not yet discovers the correct vector size, which depends on the embedder used.
to make it work I simply did an alter table embeddings and changed the vector size from 1536 to 768, because I was using nomic.
my suggestion would be : let the extension discover at Configuration/Build time the default vector size inherited from the embedder used.
however to do that, the extension shall know the embedder used : quarkus.langchain4j.ollama.embedding-model.model-id could give the dimension information to the extension
the dimension could be discoverable at runtime : it seems ollama is augmenting model info, see https://github.com/ollama/ollama/issues/3570#issuecomment-2105284515
I believe this is also related to https://github.com/ollama/ollama/issues/651 and https://github.com/spring-projects/spring-ai/issues/840
WDYT ?

cc @langchain4j @jmartisk

There is https://github.com/langchain4j/langchain4j/pull/1250


Custom dataset

Hello,
I'm a newbie in the field of image retrieval. I'd like to run your code using my own dataset. I've downloaded the pre-trained CVNet weights as you've described and would like to use the CVNet model.  Unlike the roxford5k dataset, it's not annotated. The query images are simply in a query folder, and the images that should go into the database are in a separate database folder. I'm not sure how to apply my custom dataset to your code in this situation. Additionally, you mentioned grid search in your paper, which I don't fully understand.  Is there separate code available for this?

Hi, welcome to the image retrieval community! I couldn't give you a concrete script for this (also good for you to practice and more time for me to relax;) ). But in your case, here are the probable steps you could follow, which won't be hard or rather it is super easy:

I don't recommend using our pipeline with parameter in console. Instead, try to build your own pipeline, but with some of my codes as the tools - if you are also new in python then a jupyter might be your choice.
Construct a Dataset object in torch to cover your query and index datasets.
Initialize the model (Grabbed from our code) with your pre-trained weights loaded.
Refer to extract_feature in /[test](https://github.com/ShihaoShao-GH/SuperGlobal/tree/main/test) /test_utils.py for extracting the global feature for both query and index.
Now, you will have two tensors of global features, where one in shape (#query, dims) and (#index, dims).
Do dot product between them, which gives (#query, #index). Then do torch.argsort(descending=True). You will get the sorted ordered of index for similarity from high to low for a given query.

For grid search, our paper indicates there is a strong consistency in different datasets for our searching results. So you can directly use them.


Discussion Help needed on unlinking snapshot

Hello,
we are currently using PyU4V <IP_ADDRESS>.
I have query on unlinking snapshot by snapid:
I want to know is there a way from which i can find the linked storage group or atleast clean_up these snapshots that are linked.
We are able to fetch the snapshot info:
conn.replication.get_snapshot_snap_id_details("SG_Mukesh_STG-3","snapc0716de6", "132778281731")
{'name': 'snapc0716de6', 'snapid':<PHONE_NUMBER>31, 'timestamp': '12:43:52 Sun, 21 Mar 2021 +0000', 'timestamp_utc':<PHONE_NUMBER>000, 'state': ['Established'], 'num_source_volumes': 1, 'source_volume': [{'name': '003C4', 'capacity': 10923, 'capacity_gb': 20.00061}], 'num_storage_group_volumes': 5, 'tracks': 0, 'non_shared_tracks': 0, 'expired': False, 'linked': True, 'restored': False}

conn.replication.get_snapshot_snap_id_details("SG_Mukesh_STG-2", "snap027b6202", "132777053445")
{'name': 'snap027b6202', 'snapid':<PHONE_NUMBER>45, 'timestamp': '12:03:53 Sun, 21 Mar 2021 +0000', 'timestamp_utc':<PHONE_NUMBER>000, 'state': ['Established'], 'num_source_volumes': 5, 'source_volume': [{'name': '003BF', 'capacity': 10923, 'capacity_gb': 20.00061}, {'name': '003C0', 'capacity': 10923, 'capacity_gb': 20.00061}, {'name': '003C1', 'capacity': 10923, 'capacity_gb': 20.00061}, {'name': '003C2', 'capacity': 10923, 'capacity_gb': 20.00061}, {'name': '003C3', 'capacity': 10923, 'capacity_gb': 20.00061}], 'num_storage_group_volumes': 5, 'tracks': 0, 'non_shared_tracks': 0, 'expired': False, 'linked': True, 'restored': False}

But i am unable to find to which storage group it is linked.
Based on using same name when we link i tried the following:
cleanup_link_storage_group: src_sg:SG_Mukesh_STG-2 export_sg: SG_snap027b6202_export snapshot_name: snap027b6202snapshot_id:<PHONE_NUMBER>45, masking_view: None
Unable to fetch session: Bad or unexpected response from the storage volume backend API: Error PUT symmetrix resource. The status code received is 500 and the message is {'message': 'A problem occurred modifying the snapshot snapid resource: The number of source and target devices must be equal'}.

In Few response of snapshot details i am able to fetch linked_storage_group_names.
and also  linked_storage_group when we perform link_by_snapshot.
I want to know is there a way from which i can find the linked storage group or atleast clean_up these snapshots that are linked.

Mukesh, I have an enhancement filed for this, unfortunately the current API doesn't have a filter to pick out the linked storage groups easily.  I've been controlling this myself with naming conventions which make it easier.  Once it's in the API it will be in  PyU4V

Thanks, Paul.

yes,  you need to unlink first then you can terminate the snapshot.  If there is a time to live set and it has expired,  the snapshot will automatically get terminated as soon as the unlink is executed.

The two functions you need are
unlink_snapshot_by_snap_id
delete_storage_group_snapshot_by_snap_id


Editor control issues

A bunch of little features/bugs that I may take a look at adding

[x] Right click menu on a surface should let me select a texture for the surface
[ ] Right click on a surface then moving the camera should prevent the right-click menu from opening when you let go
[x] Escape doesn't close the right-click menu
[x] Camera Y rotation should be clamped, so you can't end up upside down
[ ] Sometimes the camera flips upside down in one frame, I need to look into reproducible steps for this

I'm super glad you are tackling this! ❤

Regarding the second point. That is not happening anymore, I guess. Not sure when it was fixed, though.

Regarding the second point. That is not happening anymore, I guess. Not sure when it was fixed, though.

The logic behind this, I found, is a half-second timer. Looks like in the GIF you do exceed this threshold. If you do release fast enough then it might still be the case.


Update SmokeScreen.netkan

Fix KSP version, Latest is a compatibility release

I'm unclear on the effect you're trying to affect with this change. If the current version of SmokeScreen is not backwards-compatible then we should use a ksp_version_min of 1.0.5 and max of 1.0.99 so that we don't have earlier versions having greater compatibility than later versions.

I've separately submitted a change to the earlier versions to restrict them to 1.0.4 I'm not expecting there to be any KSP version between 1.0.5 and 1.1, so not really worth bothering with such a min/max setting.

:+1:


hotfix(globalpatches) use OpenSSL to seed PRNG

Note: this is a hotfix to be manually merged in both master and next
Summary
This changes the seeding technique for LuaJIT's PRNG from using a
combination of time (s precision) + worker PID to using OpenSSL's
RAND_bytes().
Reasoning: in modern deployment setups such as application containers
and AWS AMIs (etc...), it is a common practise to deploy from a forked
VM, resulting in high probability of collision for PIDs at a seconds
precision. This could result in duplicated PRNG seeds, which is
ultimately the PRNG used to generate UUIDs in Kong, by the use of
lua-resty-jit-uuid.
Solution: in order to have a higher entropy when seeding LuaJIT's PRNG,
a proposed fix was to use /dev/urandom. This implementation however
uses OpenSSL's RAND_bytes(), which has the advantage of returning an
error if the entropy is estimated to be too low. However, this won't
cover use cases where the VM has been forked, resulting in multiple VM
clones with a high entropy, but equal to that of the other clones. We
suggest that such deployment environment increase their cloned VMs
entropy before starting Kong.
Full changelog

use OpenSSL's RAND_bytes() to read random bytes
truncate the final seed to 12 digits to prevent integer overflows
update fallback seeding technique (time + worker PID) to use ms
precision, just in case
introduce a new kong lua shared dict. This dictionary's purpose is
to hold essential data through Kong's lifecycle, and should eventually
only be used through safe_set() (an abstraction for this could be
envisaged later on, but is not the purpose of this patch)
chosen seeds for each worker are stored in the kong shm, and can be
consulted via the / endpoint. There is currently no way to re-seed all
the workers at once unless by sending SIGHUP, because only 1 worker
would be receiving such a request through the Kong Admin API.
update debug.traceback() calls to use lvl 2 of the call stack, to
show the actual caller of our patched math.randomseed()
update log messages to be more explicit

Issues resolved
Fix #1751 #1739 #1623

Manually merged to both next and master.


Same-country security policy may be too strict for some frequent corner cases (phone roaming, VPN, etc.).
Ask tho mobile user, and she decides if it is appropriate to proceed.

Note that the blocking behavior was removed (#241).
With #236, the signal would be "suspended" until mobile user has take action.

Note that any new button has a cost to develop, a cost to maintain, but more importantly is an extra cognitive burden on the end user.  Consider avoiding the new button when applicable.


Handle filter label duplicates

Coverage increased (+1.3%) to 100.0% when pulling 5d41508abd1c2368d738e89c05c937b255431a3f on OnigiriJack:handle-filter-label-duplicates into 1f9f64ac9fef82b9e502c4d0f48207b202fcc691 on woylie:main.

#88


The temporal dimension of the 3D dataset

The 3D dataset have dimensions (N, 28, 28, 28) where N corresponds to the number of samples. I would just like to make myself clear on the point that axis=1 stands for the temporal dimension here (number of frames of images).
I have also noticed in the following function, the frames are taken from axis=1
https://github.com/MedMNIST/MedMNIST/blob/9713611ce3e6aa879011f49d66d378af0462ef57/medmnist/utils.py#L39
Any help would be greately appreciated.
TIA!

Hi @ariG23498 ,
Yes, the axis=1 means the temporal dimension in videos, or the "axial dimension" of 3D images in medical image terminology.
Jiancheng

Thanks @duducheng
Closing the issue.


Ubuntu Base Images

We needed ubuntu xenial base images. So I tried to adapt the Debain scripts for Ubuntu. Happy to correct anything that may be wrong here.
 Front conversations

Thanks for posting this pull-request!  I'm able to use this to run Ubuntu on a Jetson TX2 (aarch64).
I did need to run chmod +x ubuntu/aarch64/xenial/entry.sh for the entrypoint to run correctly when the container ran.  Other entry.sh files in the repository (such as debian/aarch64/jessie/entry.sh) have executable permissions on the committed files.  The other entry.sh files in this pull-request likely have the same issue as I don't see the extra file permission being set.
Hope this helps!

Hi, @jemoster you should use this PR instead https://github.com/resin-io-library/base-images/pull/431.

@joshughes, I will close this PR since I've submitted https://github.com/resin-io-library/base-images/pull/431, we will merge it soon and let you know when the ubuntu base images are released. Thanks


n

Challenge Size your Images has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.109 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css" >

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

Hi @jagadishmanjunath , if you need help solving the challenge. you can ask at help room

@jagadishmanjunath
Thank you for reporting this issue.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "Help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.


Added --sub-command flag

Feature added in response to issue #9523.
Issuing 'lxc --sub-command' or 'lxc help --sub-command' or 'lxc --help --sub-command' Will list available sub-commands as well as their descriptions for each top-level command. Adding the '--all' flag will have the same results but includes all commands.
The approach for adding this feature involved creating a separate UsageTemplate that displays the sub-commands, and overriding CobraCommand's default UsageTemplate to use the new one if the '--sub-commands' flag is passed.

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

jenkins: test this please

Tweaked the commit message to put sign-off line separate from the title, also fixed sign-off formatting and added a follow-up commit to support more depth as we have sub-sub-sub-commands :)

Oh, this is modifying a string, so going to add an i18n commit too.

jenkins: test this please


Update plv8 to 3.1.8

Problem
We likely need this to support Postgres 16
It's also been asked by a user https://github.com/neondatabase/neon/discussions/5042
The latest version is 3.2.0, but it require some changes in the build script (which I haven't checked, but it didn't work right away)
Summary of changes
3.1.8       2023-08-01
            - force v8 to compile in release mode

3.1.7       2023-06-26
            - fix byteoffset issue with arraybuffers
            - support postgres 16 beta

3.1.6       2023-04-08
            - fix crash issue on fetch apply
            - fix interrupt issue

From https://github.com/plv8/plv8/blob/v3.1.8/Changes
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

does it affect the image size?

does it affect the image size?

No, it doesn't (for compressed layers):
$  # the latest release:
$ docker manifest inspect neondatabase/compute-node-v14:release-3836 | jq '[.layers[].size] | add' | numfmt --to=si
257M
$ docker manifest inspect neondatabase/compute-node-v15:release-3836 | jq '[.layers[].size] | add' | numfmt --to=si
257M
$
$  # current PR:
$  docker manifest inspect neondatabase/compute-node-v14:6108808546 | jq '[.layers[].size] | add' | numfmt --to=si
257M
$  docker manifest inspect neondatabase/compute-node-v15:6108808546 | jq '[.layers[].size] | add' | numfmt --to=si
257M


Error when running solve_models() on a pastastore

When I run pstore.solve_models() I get this error:
Solving models: 0it [00:00, ?it/s]INFO:pastas.timeseries:Nan-values were removed at the end of the time series B58A0092-004.
INFO:pastas.timeseries:Cannot determine frequency of series B58A0092-004: freq=None. The time series is irregular.
INFO:pastas.timeseries:Time Series B58A0092-004: 13 nan-value(s) was/were found and filled with: drop.
INFO:pastas.timeseries:User provided frequency for time series RH_ELL: freq=D
INFO:pastas.timeseries:User provided frequency for time series EV24_ELL: freq=D
Solving models: 0it [00:00, ?it/s]
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
<ipython-input-15-3c39fc9ad072> in <module>
----> 1 pstore.solve_models()

~\anaconda3\envs\dev\lib\site-packages\pastastore\store.py in solve_models(self, mls, report, ignore_solve_errors, store_result, progressbar, **kwargs)
    619         desc = "Solving models"
    620         for ml_name in (tqdm(mls, desc=desc) if progressbar else mls):
--> 621             ml = self.conn.get_models(ml_name)
    622
    623             m_kwargs = {}

~\anaconda3\envs\dev\lib\site-packages\pastastore\base.py in get_models(self, names, return_dict, progressbar, squeeze, update_ts_settings)
    737         """
    738         models = []
--> 739         names = self._parse_names(names, libname="models")
    740         desc = "Get models"
    741         for n in (tqdm(names, desc=desc) if progressbar else names):

~\anaconda3\envs\dev\lib\site-packages\pastastore\base.py in _parse_names(self, names, libname)
    935                 raise ValueError(f"No library '{libname}'!")
    936         else:
--> 937             raise NotImplementedError(f"Cannot parse 'names': {names}")
    938
    939     @ staticmethod

NotImplementedError: Cannot parse 'names': Model(oseries=B58A0092-004, name=B58A0092-004, constant=True, noisemodel=True)

I think the error occurs since version 0.7.0 because pstore.conn.models returns a pastastore.base.ModelAccessor now instead of a list.

I'm not getting this error... The code above the for loop refers to model_names:
        if mls is None:
            mls = self.conn.model_names
        elif isinstance(mls, ps.Model):
            mls = [mls.name]

Are you sure you're not on an older version?

I get the error when I run notebook 3 from the hydropandas examples. (https://github.com/ArtesiaWater/hydropandas/blob/master/examples/03_pastastore_from_observations.ipynb)

Ah my bad, this was fixed in dev, but not yet in the latest release (0.7.0). I should probably make a new release.
I think you can revert your change and use the dev version.

Ah yes sorry should have checked that first.
I reverted the changes


openafs: fix OpenAFS 1.6 on Linux 4.20

Motivation for this change
I have been requested to add linuxPackages_latest support to OpenAFS 1.6. I found working patches, although not enough for 5.0
Things done
This patch cherry-picks commits from the OpenAFS git repository using
git show to add support for Linux 4.20 for OpenAFS 1.6.
There do not seem to be patches in the Git repository for full Linux 5.0
support, although I have added the ones which exist so far.
This patch has been tested on Linux 4.4, 4.14, 4.20, and is confirmed to
fail on Linux 5.0. It does not change the drv of the openafs package,
only linuxPackages_*.openafs.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @spacefrogg

@GrahamcOfBorg build linuxPackages_4_20.openafs

@GrahamcOfBorg build linuxPackages_4_20.openafs

@GrahamcOfBorg build linuxPackages_4_20.openafs

@artemist Thanks for the effort! Looks good from my side.

@veprbl That's an annoying issue with struct layout randomization. i'm writing a patch I'll submit upstream after some testing, but it's out of scope for this PR (and quite possibly nixpkgs)


GOBBLIN-1409 Expose Kafka record timestamp

Dear Gobblin maintainers,
This is my first PR, please do point out any mistakes or omissions.
JIRA
GOBBLIN-1409
Description
When consuming from Kafka, we need the kafka timestamp.  We weren't sure if there was another way to expose this, but figured it's a general enough need that it should be implemented.  And it didn't affect performance as far as we could see.
Tests

I added a basic test, but I'm really not sure about it, I couldn't replicate the testing environment.  Some advice on that would be greatly appreciated.

Thanks so much, I think that makes sense.  So now users of kafka-1 can check what type of timestamp they're going to expect and get it.  I guess the test setup consumes records with NO_TIMESTAMP_TYPE, but I couldn't see how that was done or how to change it.  Any guidance is appreciated.


Invalid word

Puzzle for 12/22 included a word not in the valid word list: santa

This was already filed as #32 and should be fixed. Unfortunately you may need to force refresh the page to get it to load the newer version.


Change required node version from 12 to >=12

It's impossible to use this library unless you use node 12.x.x. This change fixes this so that it's more widely usable. If PR accepted please update the package.

@kallerosenbaum, thank you for spotting this issue. It has been fixed in the new version of the library (ver. 1.0.1) that was published today.


Bump dependencies

The usual.

hi @gaearon
I've noticed that the hot reload client from latest/beta react-dev-utils does not work under Internet Explorer 11. And I think the cause is that strip-ansi package was bumped to 4.0.0 in this PR: strip-ansi@4 contains arrow functions which are not compatible with legacy browsers and unluckily webpackHotDevClient imports it.
This package was previously rolled back to 3.x for the same reason (#2691 and #2692). If legacy browser incompat is still a valid issue, It would be better to downgrade it again along with some check to prevent unintended version bump.
May I make a PR for that?

Hmm. All right!

Actually I thought we did it now because we should be compiling dependencies automatically. Can you file a separate issue for this so we can investigate?

I'm sorry I may have made a mistake. Actually I ejected several months ago (when CRA was 1.x) but is still using react-dev-utils, and I was not aware of such change in build config. I'll do some verification for that.

Ah yeah that's likely the reason. Newer babel preset should handle it.


Better explain task names in the docs

This issue suggests improving the docs with respect to task names. How are task names used? Should people use specific task names? Or should they rely on default names? We should probably add a section to the "Discussions" chapter to discuss task names.

All I know about that:

Names are free to choose
The only specific thing that happens is that if an unknown task has a name that is a python dotted path, we try importing it so see if we can find the task before failing because the task would be unknown


the cursor can't move when long time not operated computer

my computer sleep a night，then cursor can't move in vscode

Please try with empty init.vim and settings.json and no extentions.


Add apigility integration

Provide a generic messagebox endpoint to receive commands from the client. Each command type should have an own messagebox, so that you can document the different commands like you would document resources.
A messagebox should answer with a HTTP Status code and with a hypermedia link to an endpoint where client can check the status of the command: pending, succeeded, failed, ....
Provide helper to add hal links to resources pointing to available commands for the resource.
Also provide an event-stream endpoint, so that a client can query for published events.

This is covered with prooph/no-mvc


Add napari plugin with skeletonize widget

This PR adds a napari plugin with a basic widget for skeletonizing a labels layer.

@jni This does not work for because of an strange error regarding label dimensionality. Strange because it says it expects a 2d or 3d layer but it has certainly been passed a 2d layer.
Tried this in ipython with a numpy array and did not error. We checked the attributes of the data and it all seems to be what skeletonize requires, so I'm a bit lost. Would love your insights!
import numpy as np
from skimage.morphology import skeletonize
img = np.zeros(shape=(100, 100), dtype=np.uint8)
img[0:10, 0:10] = 1
skeletonize(img, method='zhang')

Thank you very much for the help @jni! It works now!

@jamesyan-git so cool! 😊 Should we merge this one as-is and do the skeleton analysis in the next step? Or do you want to wait until you add the shapes layer?

@jamesyan-git :wave:

Hi @jni, sorry I missed that. I've added a docstring, I think we can merge now.
I wanted to add some instructions on the widget for the user, but it seems non trivial if we want to continue auto-generating it.
Not auto-generating it would introduce dependencies though (magicgui for decorator at least), but this is necessary even for something trivial like changing the button text. I'm happy to go this route if you are, can do in separate PR if you approve.
I was thinking of just adding an example for usage, but I'm not sure if that alone is sufficient for a new user.
Let me know what you think and I'll follow up.

LOL New networkx just dropped and broke everything! 😂🤦


calltree coverage visualisation missing some cases

The following screenshot is from apache-httpd. Clearly something is off

further inspection shows this is to do with the coverage build/extraction rather than fuzz introspector itself. Will leave open until I have sorted it completely though

This is an issue on the OSS-Fuzz coverage extraction and is fixed by https://github.com/google/oss-fuzz/pull/7927


Add support for (vision) transformers, add options to set last-layer relevance

Vision Transformers
Add explanations for (vision) transformer (ViT) models by adding the package extension VisionTransformerExt that depends on Metalhead.jl.
Adds the rules

SelfAttentionRule for MultiHeadSelfAttention layers
PositionalEmbeddingRule for ViPosEmbedding layers

Also adds support for some special layers of vision transformers by adding a method for ZeroRule:

_flatten_spatial is a reshaping layer near the input
ClassTokens adds a class token to the model
SelectClassToken only retains the class token for the model prediction (this layer was added by me because Metalhead uses an anonymous function for this purpose, that we have to swap for a "real" layer before explaining the model)

So far, no support for Flux.jl's built-in MultiHeadAttention layer was added, because this layer does not work nicely with Chains (Metalhead's MultiHeadSelfAttention layer is not limited to vision transformer, but can also be used to build "regular" transformer models as long as they use only self-attention, e.g. encoder-only models, something like BERT should be doable).
In addition, the function prepare_vit can be used to prepare Metalhead's ViT (convert it to a Chain, add SelectClassToken layer).
Last layer relevance
Adds the keyword arguments normalize_output=true, R=nothing to LRP. If R is supplied, the relevances in the last layer are set to R. If normalize_output is false, the target neuron activation is not set to one, but remains the "raw" activation from the forward pass.
Canonization
This PR already contains the changes of PR #14, because otherwise canonization of ViT models does not work properly - so PR #14 should be merged first.
ToDo

[ ] add tests
[ ] add docs

For documentation, I guess it would be nice to have an extra "Extensions" section in the docs, and have a small tutorial under "Extensions => Vision Transformer".

Maybe move prepare_vit to canonize


Deprecated DebugHandlerPass

The Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\DebugHandlerPass class is deprecated since version 2.12 and will be removed in 3.0. Use AddDebugLogProcessorPass in FrameworkBundle instead: 1x
    1x in DefaultControllerTest::setUpBeforeClass from Tests\AppBundle\Controller

Using monolog-bundle v3.0.

I'm having the same problem. Locked version to 2.11.3.

I'm currently using monolog-bundle 3.0 (latest release) and I'm getting the following message:
The Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\DebugHandlerPass class is deprecated since version 2.12 and will be removed in 3.0. Use AddDebugLogProcessorPass in FrameworkBundle instead. ```

What should I do this resolve this?

Waiting for #188

I see, thanks a lot @andreybolonin

3.0.1 is out now fix the fix.


Search not working

When I add the state i want to look for alerts in from the welcome page once i get to the next screen with the food alerts and the map the same 2 states are highlighted (Oregon and Washington) but i entered California which also shows there is a food alert. Also if i change my search criteria its not refreshing.

Gene I know you are not done with this yet I have seen changes more states show up in the search I think the state that you select should just show up if there is no information for that state perhaps a message comes back saying no results were returned for that state - also besides choosing a state maybe add one more selection that the user can select all states and then the results show as they have.

Done, the highlight were the issue.


read-only mount

Hello,
Is it possible to mount a s3 bucket as a read-only?

there are 2 ways:

get a aws credentials that only have read permission to the bucket
pass -o ro to goofys

Just to note, the -o ro option does not appear to work with the -cache flag to use catfs.


State recreation issues

There are some state recreation issues as seen in Sentry:
https://sentry.io/organizations/dapperlabs/issues/3628363044/?project=6398442&query=is%3Aunresolved+is%3Afor_review+assigned_or_suggested%3A[me%2C+none]&sort=inbox&statsPeriod=14d
https://sentry.io/organizations/dapperlabs/issues/3628608270/?project=6398442&query=is%3Aunresolved+is%3Afor_review+assigned_or_suggested%3A[me%2C+none]&sort=inbox&statsPeriod=14d
https://sentry.io/organizations/dapperlabs/issues/3627952185/?project=6398442&query=is%3Aunresolved+is%3Afor_review+assigned_or_suggested%3A[me%2C+none]&sort=inbox&statsPeriod=14d
https://sentry.io/organizations/dapperlabs/issues/3627949338/?project=6398442&query=is%3Aunresolved+is%3Afor_review+assigned_or_suggested%3A[me%2C+none]&sort=inbox&statsPeriod=14d

Has been fixed


adds overrides log

Not exciting.
Adds a very basic .txt overrides log to the mc autostep command. This just logs the overriden params (based on the bitsim "batch.json" config for example:
'modeParams:car/constant: 0.0 -> -1.0\n',
'modeParams:car/constant: 0.0 -> -1.0\n',
'scoringParameters:unknown/modeParams:bus/constant: 0.0 -> -1.0\n'

Does not include other config changes such as paths, or iterations.
Tested code, but not tested in bitsim yet.
This:
'modeParams:car/constant: 0.0 -> -1.0\n',
'modeParams:car/constant: 0.0 -> -1.0\n',

is an example of where the override address effects more that one param. It is not straight forward the expose the full address of the override. In this case modeParams are updated for two different subpopulations. Because of the way that mc.find works it will not be easy to expose this info in the log.

The git pedant in me would also like to see these 3 commits squashed into one, but that's me pushing personal preference

Do the overrides need to be written out for every biteration? If I remember correctly, a set of overrides will be consistent throughout the simulation (disregarding anything to do with input/output paths, which I don't think the summary log is that concerned with). In which case, maybe writing out once to the sim root instead of biteration root would be sufficient? I've probably missed some utility in doing it in this way though

you are right - I just intend this as an mvp, plus might be useful to always find it

The git pedant in me would also like to see these 3 commits squashed into one, but that's me pushing personal preference

I think my rebase is messing with remote history and therefore you histories if you've pulled. Do you want me to force push my rebase?

Nice. The override log would be useful to trace the batch changes. I have tested it on thebitsim and the overrides.log worked well.

Thank you!

One minor thing is the find function will include all of the overrides params sometimes it may have some duplicate contents in the log. e.g 'modeParams:car/constant: 0.0 -> -1.0\n' will be repeated for every subpopulation. I think dropping the duplicates in the log could be done when writing the lines into the log.

So i decided to do this on purpose, such that we'd know how many times a find an change is applied. If it get's annoying, it's an easy change in future.

Originally, I was thinking to extract info directly from bitsim configuring files but local bitsim CLI won't support read/write to EFS. I will think about combining this overrides.log in mc.

I only intend this as a starter idea. We will add more fore sure.

I think my rebase is messing with remote history and therefore you histories if you've pulled. Do you want me to force push my rebase?

Yeah I think rebasing some commits included in a PR and force-pushing the updated refs is fine, as long as it doesn't drastically alter the content of the PR (in which case people who have already reviewed should probably be asked to again).
In this case, it would just be a case of tidying up git history without affecting content/intention so think it's perfectly acceptable.
Rebasing anything in shared history is a bad idea, but even if we've pulled the current proposed changes into a local branch and then you rebase them, we'll eventually pull from main and that will be the canonical history anyway


Cannot install make-license version 0.5

Hi, I can not install version 0.5.
npm i<EMAIL_ADDRESS>make-license

Works fine.
npm i<EMAIL_ADDRESS>
Generates error:
npm ERR! argv "/home/adabru/.nvm/versions/node/v7.4.0/bin/node" "/home/adabru/.nvm/versions/node/v7.4.0/bin/npm" "i"<EMAIL_ADDRESS>npm ERR! node v7.4.0
npm ERR! npm  v4.0.5
npm ERR! path /home/adabru/Desktop/Apps/word-complete/node_modules/make-license/dist/index.sh
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod

npm ERR! enoent ENOENT: no such file or directory, chmod '/home/adabru/Desktop/Apps/word-complete/node_modules/make-license/dist/index.sh'
npm ERR! enoent ENOENT: no such file or directory, chmod '/home/adabru/Desktop/Apps/word-complete/node_modules/make-license/dist/index.sh'

I am on Ubuntu 16.04.

Hey @adabru thanks for the heads up! Is this related to #9 ?

It may be. I tried a few things:
# download make-license
npm pack make-license
tar -xf make-license-0.5.0.tgz

Running npm install ./package gives error as described in first comment.
cd package
npm install
npm run build

Running ./dist/index.sh gives error
import inquirer from "inquirer";
^^^^^^
SyntaxError: Unexpected token import

After googling (https://stackoverflow.com/a/33608835/6040478)
babel src --out-dir dist --presets es2015

./dist/index.sh now works fine
As npm install ./package was complaining about no such file or directory, chmod '../node_modules/make-license/dist/index.sh' I replaced
  "files": [
    "src"
  ],

with
  "files": [
    "src", "dist"
  ],

in ./package.json
cd ..
npm install ./package

So now it works.
Summary:

adding "dist" as to the package.json files and adding --presets es2015 to the babel build command gives me a working program
executing index.js without babel does not work Syntax error: import ... from ..., and probably shouldn't at the moment¹


Mention the ability to specify internal ip address for LB in another subnet

I would suggest that a specific ip address can be made in the section "Specify a different subnet"
In the Section "Specify an IP address", the statement "The specified IP address must reside in the same subnet as the AKS cluster and must not already be assigned to a resource." can confuse readers when you can specify a load balancer to a different subnet, you can still specify an ip address in that other subnet. This is beneficial so you don't have ip conflict when worker node and the LB are in diferenct subnets also able to specify a fixed ip address when setting up DNS record for the ip.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25afcc19-0998-3583-f6d8-e2a619c0e071
Version Independent ID: 7629191a-6b3b-fb22-8b70-fa84fd785f38
Content: Create an internal load balancer in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/internal-lb.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@RoyKimYYZ Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@mlearned Can you please check and add your comments on this doc enhancement request as applicable.

Thank you @RoyKimYYZ for the feedback!
I have updated the article to address your feedback and the changes should be available soon.


add JSON responses

Add example scripts that return a JSON payload so it acts more like a "real" API

Fixed in #20


fix params overrides in ParentToChildMessageWriter cancel(), keppAlive()

Fixed a bug where parameter overrides were recognized as function parameters when calling retryableTx cancel() and keepalive() functions.
Before the bug fix, the following ethers error log was generated when calling the function

Error: too many arguments: passed to contract (count=2, expectedCount=1, code=UNEXPECTED_ARGUMENT, version=contracts/5.7.0)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add graphicdesign.SE room for alerts

http://chat.stackexchange.com/rooms/56223/the-spam-blot as discussed here:
http://chat.stackexchange.com/transcript/message/36356365#36356365

Updated https://github.com/Charcoal-SE/SmokeDetector/wiki/Chat-Rooms

Codecov Report

Merging #621 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   61.12%   61.12%
=======================================
  Files           5        5
  Lines        1047     1047
=======================================
  Hits          640      640
  Misses        407      407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c59093...d23cda3. Read the comment docs.

Awating definitive confirmation: http://chat.stackexchange.com/transcript/message/36356765#36356765

I'll keep an eye on this. If he's added to the GD room, I'll update FIRE / AIM to work in there as well.
If I somehow overlook this, give me a slap on the wrist :-)

The GD admins still want to defer.  http://chat.stackexchange.com/transcript/message/36464416#36464416

If the GD admins have chosen to defer, then we will have to wait until they choose to actually go ahead and "jump" on this.  If they choose to actually go ahead with it, then just add them back into the alerts list with a new pull request, please.


Upgrade operator-sdk v0.15.2

The bulk of the changes deal with upgrading k8s.io/controller-runtime from v0.1.x to v0.4.x.  The changes also collapse the validating/mutating webhook controllers into a single controller that handles caBundle updates for all webhooks.
This is divided into two commits to separate the vendor changes from the actual code changes.

This PR is good to merge, should we decide to upgrade operator-sdk for Maistra 1.1.  Note, the only issue at present is the reliance on service-ca to create the serving secret for the webhook server.  This causes the initial startup of the operator to fail (i.e. bounce).  Subsequent startups succeed and the webhook server starts normally.  (In other words, the operator will restart once when it is first installed.)

Note, the only issue at present is the reliance on service-ca to create the serving secret for the webhook server. This causes the initial startup of the operator to fail (i.e. bounce). Subsequent startups succeed and the webhook server starts normally. (In other words, the operator will restart once when it is first installed.)

I think we should introduce another controller that ensures the service and the webhookconfig objects are created (and recreated whenever they are deleted). The same controller could also watch for the serving-cert secret and write the files locally. This way, there is no need for the operator to restart. (note that running the operator locally is now harder because you need to extract the secret to /tmp manually).

Forgot to say that the PR looks good otherwise. I've tested the operator manually and it appears to work.
I'm OK with this going in. I can create the new controller in a follow-up PR.
Also, upgrading controller-runtime is a good idea, as it will allow us to do some things that weren't possible before: like forcing the update of the smcp/smmr/smm status (preventing conflicts). This will make the code simpler and ensure that the status is always updated - even if users modify the object while the controller is reconciling it.

Yeah, the issue with the webhook is compounded by the fact that we can't read objects before the cache is started.  I suppose we could create our own client, using the config on the manager object.  It would be great if we could wait until the secret is available, to prevent a restart.  (The issue is that the webhook server fails to start if the key is missing.  The key gets mounted after the secret is created, which is done via service-ca reacting to the creation of the service.)
Also, the newer controller-runtime includes a Patch() method on the Client, which would help simplify the patching code (maybe).  I didn't tackle anything beyond what was required to upgrade though.

Forgot to mention that this work includes a refactoring of the webhook cabundle controllers, merging them into a single controller that watches both validating and mutating webhooks.  The new version of that controller is used to keep the cert on the operator's webhook up to date.

I've rebased and tested again, and everything looks good.  I've added some code to wait for the secret to become available before starting the controller manager, which allows the webhook server to start without error (because the secret with the tls.key has been mounted).
@knrc, after talking with @luksa today, we think we should merge this for 1.1.  For the record, these changes do add a dependency on the service-ca operator, which is a core cluster operator and should always be present. (By dependency, I mean we rely on it to generate a secret that is used to configure tls on the webhook server.  This used to be done by the controller-runtime framework, but that functionality has long since been removed.)

@rcernich It's too big and risky at this stage, we're supposed to be finishing things off for the release and not introducing risky changes.

On hold until maistra-1.2 branch is created.

This should be good to go now.  Note, after rebasing, I updated to v0.16.0.  I tried v0.17.0, but there were issues with the dependencies, so I bailed.  I think it was the result of using 1.16 k8s with 1.17 client-go.  The migration docs didn't mention anything about updating the k8s dependencies, so I bailed out.

@dgn, could you give a review?

This segfaults on my cluster when reconciling the SMCP, haven't figured out what's going on exactly yet though
E0511 16:16:36.415797       1 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
goroutine 1987 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x1a68360, 0x3047130)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:74 +0xa3
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:48 +0x82
panic(0x1a68360, 0x3047130)
	/usr/lib/golang/src/runtime/panic.go:679 +0x1b2
github.com/maistra/istio-operator/pkg/controller/common/helm.(*PatchFactory).CreatePatch(0x0, 0x1f95780, 0xc000f73760, 0x1f95780, 0xc000f73750, 0xc000221451, 0x9, 0x1f95780, 0xc000f73760)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/controller/common/helm/patch.go:46 +0xb2
github.com/maistra/istio-operator/pkg/controller/common/helm.(*ManifestProcessor).processObject(0xc0012b74f0, 0x1fcb440, 0xc0029749f0, 0xc000f73750, 0x1ce4105, 0x9, 0x1fcb440, 0xc0029749f0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/controller/common/helm/manifestprocessing.go:150 +0x6a8
github.com/maistra/istio-operator/pkg/controller/common/helm.(*ManifestProcessor).ProcessManifest(0xc0012b74f0, 0x1fcb440, 0xc002974480, 0xc002926390, 0x2b, 0xc00292e5a0, 0x10e, 0xc003b556b0, 0x1ce4105, 0x9, ...)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/controller/common/helm/manifestprocessing.go:81 +0x792
github.com/maistra/istio-operator/pkg/controller/common/helm.(*ManifestProcessor).ProcessManifests(0xc0012b74f0, 0x1fcb440, 0xc0020a6360, 0xc0025d7520, 0x5, 0xa, 0x1ce4105, 0x9, 0x0, 0x0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/controller/common/helm/manifestprocessing.go:48 +0x311
github.com/maistra/istio-operator/pkg/bootstrap.internalInstallCNI(0x1fcb440, 0xc0020a6360, 0x1fe99e0, 0xc000a8fe00, 0xc000b96e01, 0x0, 0x0, 0x0, 0xc001d0fb30, 0x0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/bootstrap/cni.go:51 +0x682
github.com/maistra/istio-operator/pkg/bootstrap.InstallCNI(...)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/bootstrap/cni.go:20
github.com/maistra/istio-operator/pkg/controller/servicemesh/controlplane.(*controlPlaneInstanceReconciler).Reconcile(0xc002182e70, 0x1fcb440, 0xc0020a6360, 0x0, 0x0, 0x0, 0x0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/controller/servicemesh/controlplane/reconciler.go:217 +0x1b83
github.com/maistra/istio-operator/pkg/controller/servicemesh/controlplane.(*ControlPlaneReconciler).Reconcile(0xc0006488c0, 0xc0014c97ba, 0x2, 0xc0014c97a0, 0xd, 0xc00157bc00, 0x0, 0x0, 0x0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/pkg/controller/servicemesh/controlplane/controller.go:227 +0x867
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc000c1d740, 0x1ae08a0, 0xc000d50220, 0x0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:256 +0x162
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc000c1d740, 0xc0034f1c00)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:232 +0xcb
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker(0xc000c1d740)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:211 +0x2b
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc0032d51f0)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152 +0x5e
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc0032d51f0, 0x3b9aca00, 0x0, 0x1, 0xc0007f9c80)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153 +0xf8
k8s.io/apimachinery/pkg/util/wait.Until(0xc0032d51f0, 0x3b9aca00, 0xc0007f9c80)
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x4d
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
	/home/dgrimm/dev/go/src/github.com/maistra/istio-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:193 +0x328
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1852cc2]

Rob needs to rebase the PR to pull in #428 (or you can just cherrypick it on top when testing the PR).

I'll rebase and push anew.

pushed a rebase against latest maistra-1.2 branch


fix some mistaken 2.11 references in 2.12 community build

fixes #217

not starting a test run yet because I recently merge 2.11.x and 2.11.x-jdk8 onto 2.12.x, and I want the test run for that to finish first before I start one for this

test run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/315/consoleFull (404 while Jenkins catches up)