Configurable Docker registry/namespace

Currently, if I want to push the generated images to a private repo, e.g. Amazon ECR, I need to go through and add an extra tag to them, and then push them.
And if I later want to rebuild one of the later images, I need to pull the base images and retag with with adamrehn/... or the build script will recreate them from scratch, particularly due to the security token caching issue in ue4-source invalidating the layer cache. (If I understood the write-up correctly).
It seems to my (limited!) Docker expertise that being able to provide an alternative to adamrehn/ on the ue4docker build command line would be useful for automating image builds. A quick search indicates clean and export would need access to the same things, so perhaps this needs to be slightly-more stable, such as an environment variable?
It's very possible I've got the wrong end of the stick, and am asking for something silly, or that's already solved. If so, I welcome being redirected.

What you're asking for isn't silly at all, nor is it solved. I've considered adding exactly this option on a number of occasions, since the default names are convenient for me but pretty much nobody else. (The same is also true of the Conan packages generated by conan-ue4cli, for essentially the same reasons.) In fact, I've actually already modified the export command to support custom tag overrides to accommodate the scenario where the built images have been re-tagged and then pulled on another machine that then lacks the original tags.
Since someone has finally made a point of explicitly requesting this, I'll have a think about the best way to implement it to ensure consistency amongst the various commands. The ue4-build-prerequisites image will likely retain its current tag to support pulling the prebuilt version from Docker Hub, but there's no compelling reason why the other images can't have configurable tag prefixes.

That makes sense to me. I would expect that the ue4-build-prerequisites tag would have to vary by whether it was self-build, or 'pull prebuild from Docker Hub', based on the command line.
If I'm generating it locally, I would expect to push it locally and pull it back later when I need to, consistent with the other images.

This functionality is now available in ue4-docker version 0.0.30, and is documented here: https://adamrehn.com/docs/ue4-docker/building-images/advanced-build-options#specifying-a-custom-namespace-for-the-image-tags


[Upload UI] The warning message is broken when the package lacks the license URL.

The warning message is broken when the package lacks the license URL.

@zhhyu , can you please provide additional information on how to repro this, customer impact, expected behavior.

Added. @skofman1


Case sensitive

Hi,
The case sensitive doesn't seem to work :

Best regards,
Camille

Hi @vsct-jburet I see that previous options caseInsensitive and ignoreTrailingPunctuation have been merged to normalizeText. The app configuration screen and the tooltip indicate this is not compatible with entities... Can you tell us more about it?


Handle missing entity and field

Fixes #1

Pull Request Test Coverage Report for Build 15

23 of 23 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 94.186%

Totals

Change from base Build 13:
1.9%

Covered Lines:
59

Relevant Lines:
62

💛  - Coveralls


Orbit crashes and subsequent calls hangs after a unsucessfull request to a remote server

If you send a request to a remote server and the server returns an error, Orbit crashes.
Subsequent calls hangs (As stated by me in #516 in this comment).
I'm registering this issue to document  it and to learn from this.
Repro link in v0.16.6:
https://codesandbox.io/s/orbitjs-repro-issue-v0166-v8u3u
I tried to reproduce it in v0.17.0-beta.6, but I'm having some issues with the models itself.
The models from the server I'm using are in the plural. I tried to change the Orbit models to the plural too, but no success.
https://codesandbox.io/s/orbitjs-repro-issue-v0170-beta6-mybc8
Any help would be appreciated.
Best regards

This is not a bug, but by design. Orbit has not crashed, but has paused its queues to allow you to address the problem. You can either skip or retry the action that errored.
Please take a look at the documents on pessimistic and optimistic error handling.

Awesome! Again, just what I needed.
TL;DR
My actual problem  was different and I was led to use the skip method without parameters (which caused an error) based on the docs :

skip() will cancel and discard the current task and proceed to process the next task.

It never crossed my mind to pass the actual exception as a parameter to the skip method. When I did so, it worked as expected.
I could've discovered this if I've read the tests and some projects that are using the library. Lesson learned.
PS:There's an advice in the end.
Some things to note:
Yesterday I gave a special care to the Task Processing section of the Orbit docs, trying to figure it out a solution to my problem. I realized that I should've read that before. +1 for mentioning the importance of reading that that there in the docs.
I remembered that my current issue was not just how to handle the error, it was how to handle the error and retrieve the server message.
When I borrowed the catch block from  #516, I've implemented it this way:
catch(e, transform) {
    this.source.requestQueue.skip();
    this.target.requestQueue.skip();
    throw e;
  }

Note that I'm not passing any parameters to the skip method. When I do so, Orbit js throws another exception:
Processing cancelled via `TaskQueue#skip`

Even if I wrap the skip call in a try-catch block the code doesn't work as expected. So, my actual problem was how to handle the error and keep the original exception, without throwing the above. Now I'm sure I was not paying attention and I was doing something wrong.
The solution
Reading the pessimistic error handling docs you've sent  in the links avove, I just saw you passing the current exception into the skip method. When I did this, everything worked as expected.
So, a simple catch method will look like showed in the link you've sent:
catch(e, transform) {
    this.source.requestQueue.skip(e);
    this.target.requestQueue.skip(e);
    throw e;
  }

A small detail, that makes difference.
If I've been a bit more specific, we could've found the solution faster.
A small advice
I knew that there's the Orbit Ember project, but I don't even know Ember, so I've not considered taking a look there.
I tried to found the solution to my problem just looking at the source code and the Orbit official website.
There's a lot of valuable information in the Ember Orbit project and in the Todo MVC Orbit repo.
After all this I'll venture into these projects without even knowing Ember. So why not reference these projects in the Orbit js website?
Again, thanks for your support, and feel free to close this issue whenever you want.


Cesium 3d tile time availability

Added an optional availability (TimeInterval) parameter for tiles to allow for culling tiles within a tileset based on time.
I've been making animated point clouds of airborne radar by encoding time values in the batch table and reapplying styles as time changes. With large tilesets this begins to hinder performance drastically, particularly if the tileset is segmented into many children tiles. My solution was to add a time availability parameter per tile, set in tileset.json as an ISO8601 string in the form "2019-12-01T01:01:01Z/2019-12-03T01:01:01Z". An extra method call is added in the updateVisibilty method to check the tile's availability. This way a tile is only selected if the viewers time is within the availability window of said tile, and styles aren't applied to features that would otherwise be hidden.
Please see my demo here: http://brianpojo56.github.io/cesium_demo
The data being shown is:
Heymsfield, Gerald M and Lin Tian. 2017. GPM Ground Validation High Altitude Imaging Wind and Rain Airborne Profiler (HIWRAP) OLYMPEX.
Dataset available online from the NASA Global Hydrology Resource Center DAAC, Huntsville, Alabama, U.S.A.
DOI: http://dx.doi.org/10.5067/GPMGV/OLYMPEX/HIWRAP/DATA101

Thanks for the pull request @brianpojo56!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

This demo looks very cool @brianpojo56 ! Thanks for opening this pull request.
So does each point have a time interval that styling is used to show/hide as the clock ticks, and each tile has a time interval that is assumed to be the min/max of all of its children's content?
Are you aware of TimeDynamicPointCloud ? Although that may not be ideal for this case since it gives each tile a time interval, and not each point. There's a Sandcastle example using it here: https://sandcastle.cesium.com/index.html?src=Time Dynamic Point Cloud.html

Hi Omar, sorry for the long delay in a response and thank you so much for taking a look so quick.
Yes, originally I built these animations using TimeDynamicPointCloud, but I ran into a few drawbacks with this. Often the data for a single flight from this instrument is upwards of 10 million points. Due to the close proximity of the points it is well suited for hierarchical level of detail organization by generating multiple levels of resolution, but TimeDynamicPointCloud doesn't support HLOD so we can only show a single level of detail. Each point is a sensor value for a space at a given instance of time. I've simplified it a little by removing the number of milliseconds from the original data, but this still means that we have a .pnts file for every second. For the data in the demo (about 2.5 hours) that's roughly 9000 .pnts files. This in itself isn't that terrible, however, in order to show a coherent representation we need to show a window of time (the demo shows the current time and the trailing 5 minutes of data). Since we don't have overlapping TimeIntervalCollections we need to either have multiple TimeDynamicPointClouds with slightly offset TimeIntervals, or have duplicated points across each .pnts file.
I have a time value for each point in the batch table (its stored as a float32 and is the number of seconds from a specified epoch). Each second a new style is applied to the tileset that will only show the points that are less than or equal to the current time and greater than the current time minus 5 minutes. This achieves the best results that are a balance between client performance, network traffic overhead, and file size. However, with longer flights, or when displaying multiple similar airborne instruments simultaneously, applying the new style every second starts to produce a severe performance problem. By implementing availability per tile, if the current time is outside the tile's availability the style won't be applied because it won't be selected, and drastically reduces the amount of time taken to apply a style to a high volume high density dataset.

Thanks again for your contribution @brianpojo56!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @brianpojo56!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @brianpojo56!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @brianpojo56!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @brianpojo56!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

This is ready again.
It's been a while since I first opened it so I merged in all of the commits since then.

@brianpojo56 I don't have many comments on the code because it looks good, but I don't know if we're ready to commit to this approach for time dynamic 3D Tiles... yet... especially as we're deciding what time-dynamic looks like for 3D Tiles Next. That said per-tile availability makes a lot of sense, we would just need to formalize it from the spec side before we could merge this PR.

Thanks again for your contribution @brianpojo56!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Let's close this since there's no action we can take here until the specification is formalized, and that may ultimately change how it's implemented. Thank you very much @brianpojo56 for sharing this contribution and your demo! It was especially helpful hearing about your use case that you created this for.

Sorry to post on a zombie PR. I pulled out the changes here and made an npm module that can be imported to extend the Cesium3DTileset class and add the functionality.
https://www.npmjs.com/package/temporal-3d-tile
Just wanted to post it here for anyone interested.


Update rmb-peer with the latest envelope data

Description
rmb-relay v1.3.0 added a new optional relays field that is part of the Envelope to avoid chain updates delay: https://github.com/threefoldtech/rmb-rs/blob/v1.3.0/proto/types.proto#L75
This new field should have the current relays for the twin sending a request to a relay. It should be a list of relays in the format <hostname>, for example: relay.dev.grid.tf and relay.dev.02.grid.tf. neither protocol or port should be added (wss or :443).
Reference PR and Issue

Investigation:
Still checking the required changes that need to be made.

I should probably mention that sending relays as the part of the message will not work on networks other than devnet as peers aren't updated on other networks (mainly zos nodes).

WIP:
Updated the types.proto and generated the new types. Currently working on editing the challenge with the new relays.

Work completed:
Added relays to the envelope and set it whenever user sends the envelope. I also added it to the challenge the same way it's implemented in rmb-rs. However, whenever I try to run the example script from the direct client, I get failed signature error as shown below.
P.S. the old challenge works just fine.

@AbdelrahmanElawady Can you please check if I'm missing something?


multi language site use CSOM API get list title issue

If site language select multi language, use CSOM API get list title will return the title by current user's default display language setting.
For example:
current user's default display language is English, but site default language is French, use API get the Documents list title will still return Documents.

This is by design - this depends on the preferred language in the user profile.

This is indeed by design.


Grafana with persistence enabled will not seamlessly upgrade

What kind of request is this (question/bug/enhancement/feature request):
enhancement
Steps to reproduce (least amount of steps as possible):
Launch cluster-monitoring or project-monitoring v0.1.0 with persistence enabled for Grafana
Upgrade chart to v0.1.1
Result:
The replacement Grafana pod in the deployment is created before the original pod is deleted, resulting in a stuck upgrade as the PVC is still bound to the first pod.
Other details that may be helpful:
maxSurge is currently undefined in the chart, so defaults to 25%. Changing to 0% should resolve this.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.4.5
Installation option (single install/HA):
HA

gz#10888

Relating to https://github.com/rancher/rancher/issues/27450

closed. duplication of https://github.com/rancher/rancher/issues/27450


use unique process identifier to fix bug

Rebased this branch onto acc to fix this bug before merge to prod

Sadly this is just a cherrypick of a bugfix that was already merged in develop, so there won't be any changes made to the code.

Well, agree to disagree then.


Add flow typechecking as a webpack plugin

This will only run if a @flow annotation is seen in an user's file:

[x] At the first @flow file found:

[x] Write a .flowconfig if none exists
[x] Run flow-typed install
[x] Add some custom flow-typed installs (implicit jest behind react-scripts for instance)

[x] When a file with an @flow comment changes during a compilation:

[x] Run a flow check
[x] If there are some type errors in flow: show warnings
[x] If flow itself crashes: show error

[x] Refactor

Followup goals:

[x] Return-code-based success of the command (instead of looking for "No Errors!"
[x] Detect if a global flow installation exists, if yes, check its version, if not equal to CRA's version, show a warning that compilation may be slowed down

[x] Ensure the first flow status run was done after complete init (especially flow-typed)
[x] Add flow-typed dir to .gitignore during the first run
[x] Add to end-to-end testing

Followup of a discussion in #72

I just implemented the "lifecycle" of the plugin for now, early feedback is welcome!

Neat! Going to look later this week. Want to make a GIF 😄 ?

@gaearon Not done yet, will do a gif when I'm completely happy about it!

Btw, for now, the code is pretty awful callback hell-spaghetti, I have to admit I got used to promises, almost forgot about working like this!

We depend on Node >= 4 so you should be able to use Promises if you want to.

@gaearon Issue is, webpack and vanilla Node API doesn't really expose Promises. I usually use some form of promisifier to handle Node API... I don't want to add more deps than useful.

Okay, I checked, there are arrow functions elsewhere, I'm going to need that as well!

@gaearon It's way better now! I'm more satisfied with it... But I want to see what your review will show... Maybe one problem we may have here is that the flow check is global and not per-file. I can work on that maybe a bit later but I see one issue in not having the general output, we'd lose warnings in test files so I have to give it a few more thoughts before doing that.
Thanks and good luck for the review!

One thing to keep in mind is the scenario where changing file A adds or removes an error from file B. Does this work now?

@gaearon As long as A is covered by flow, typechecking project-wide will be recomputed, so we'll see issues being propagated to B if this is the case.

@gaearon Well, I think it's quite complete now, I heavily tested it and covered many edge cases... I'll see how we can add this to the e2e test process... and after that, I think we're good for a final review!

Well the addition to the e2e tests pass locally, just waiting for the CI!

@gabelevi Thank you for checking in!

😁 😁 😁 Super excited for this! 😁 😁 😁

@gaearon created an issue about those unchecked tests: https://github.com/facebookincubator/create-react-app/issues/1169

@gaearon made a PR to check the tests, via a webpack plugin, once again!

Thoughts on extracting all of these awesome webpack plugins into separate packages? I know I can just depend on react-dev-utils, but that seems kinda weird

For now we don't want to add more packages because people will have expectations of a stable release cycle. Instead it is likely we'll need to iterate on them quite a bit before they settle down. We're also not quite ready to make them "proper" because people will start asking for configuration options, come with issues specific to those packages etc. If/when this gets really stable I'd be up for extracting it from react-dev-utils. But not very soon.

Why is Travis failing?

@gaearon I don't know, maybe some of the tests I added (they pass locally, just need to understand what fails on ci)

Ok test -d flow-typed intermittently fail, I'll just suppress it for now...

@rricard
How ready do you consider this PR?
If you think is ready I’d like to propose a little challenge for you.
Build a small app with it.
It doesn’t have to be complex but it should be enough for you to get into the flow (haha) and maybe find rough edges. What do you think?

@gaearon except this small intermittent CI error and the fact that tests are not well considered yet  (cf #1169 & #1209), yea, I would consider it done!
I agree, let's try to build something with it!

I want to learn something new at the same time, let's try to build a game with SVG & animations, I may completely fail and go back writing a TODO-list but I have time so let's do that!

@gaearon Everything works well, except: not having auto-triggered typecheck + linting on test files is super annoying.
Here is how I develop:

I think I'll try developing on a CRA version with this PR + #1209.

👍
I'll merge after we cut a few more patches then.

I'm ready to start merging things slated for 0.9.0.
Would you like to bring this up to date so I can merge?

@gaearon I went further in my app, still no need to eject or to configure stuff in my editor, and with the addition of #1209 tests are much easier to write as well! So I would say this PR is definitely ready to ship, so I'm going to rebase it!

@gaearon, here we go:

@gaearon I simplified and fixed those e2e tests, I think they'll pass this time!

Fingers crossed

@gaearon yea! it's super stressful to make those tests pass!

My test logic was flawed... This time should be better

@gaearon I think Node 6 without yarn has some issues with its CI cache, can you reset Travis caches and restart a build ?

Cleared and restarted.

This time, I think we're good!

I'm going to try one last thing, if that doesn't work I'll need some help!

Okay, I can't get past this ENOENT error: https://travis-ci.org/facebookincubator/create-react-app/jobs/183983401
I don't know if you retriggered the build at the same time I committed but this exact error only appears on Node 6, no yarn. I tried to reproduce locally, didn't managed to do it.

@gaearon can you retry one last time a cache clear + rebuild on Travis? I won't commit at the same time... Otherwise I'm clueless why this specific build doesn't work

Did that

Thanks, Yarn build also failed bc of a registry error, can you retrigger it too?

Okay, I need to do the exact repro at home, let me some time...

Hope this passes, this was literally painful to debug....

EACCESS, almost there! Just need to prefix the command with node

@gaearon you can cancel all builds before the last commits they are likely to not pass

@gaearon finally green ✅

Hey @gaearon is there anything more I can do so that we can ship this feature and get this merged?

Nothing more, I'm just holding off merging more stuff until I get back from holidays. I've been focusing on React for the past few weeks but I'll find some CRA time in January for the big 0.9.0 release.

@gaearon ok, nice! I was just afraid I missed something... Enjoy your holidays!

@gaearon @Timer @thejameskyle Thanks for the feedback, however, I'm back at the university for my last semester and I do not have much time to work on that. I'll however pin the PR, resolve the requested changes and rebase at the next occasion!

Sounds great! What kind of timeline are we looking at? Maybe somebody else could pick it up and finish it.

I don't know, I'm quite busy now so for a timeline I'd say a month

I went ahead and cherry-picked @Gregoor's change and merged this with master so it's easier to work with when we pick this up or @rricard desires to finish it. I made @rricard the author on the merge commit for blame reasons. 😄

Thanks @Timer. I'm still not back yet unfortunately. I hope to get back to it soon but it's very likely I won't be able to do anything before June...

No problem, @rricard! I'm actually playing with this right now ... 😄
I upgraded flow and other things and stuff broke, but I'm working through all the comments we had on here and going to make the output prettier:

This is pretty neat! I see that this PR is in good hands!

@rricard we decided to chop the flow-typed integration for now, we only want integration with flow to be skin deep (that of an IDE, e.g. VSCode).
This PR should be good to go barring shutting down the flow server when the process exits (which I'm not even sure if that's a huge deal).

@Timer good call, flow-typed has always been the annoying part of this PR. I'm not sure it's a good idea to add it in a followup PR. At least not until https://github.com/flowtype/flow-typed/issues/526 is properly addressed.

That, and until all of definitelytyped definitions make their way in (imo).

What is missing here?

This PR should be good to go barring shutting down the flow server when the process exits (which I'm not even sure if that's a huge deal).

I'm fine with keeping the server alive.

Only thing missing is disabling this feature for Windows users.
Also, I think it'd be nice if we explicitly use the global flow and not our local when available.

Also, I think it'd be nice if we explicitly use the global flow and not our local when available.

I'm not sure if that's a good idea. Different projects may use different versions of flow, so the global version may not be correct for the project.

Only thing missing is disabling this feature for Windows users.

Is this feature slow for Windows users or Flow itself?
We could introduce two stages:

Compiled successfully (Flow checks are still running)
Compiled successfully / with errors / whatever

@gaearon flow itself is slow on windows, but I had my VSCode's "Run flow while editing" option ticked, which made my system virtually unusable.
This might not be as exaggerated if this was disabled.
I don't want to disable it because the "feature" is slow, just because it can freeze up your system for periods of time if you have certain options turned on in your editor.

After some discussion we're pushing this back to 0.11.
In particular, it doesn't seem right to wait for Flow to declare the build to be complete.
Instead, @Timer plans to investigate using the new Flow push API that Nuclide is using.
In the UI, we will probably show Flow check and Webpack compilation as two separate "panes" that don't wait for each other.

@gaearon @Timer I'm back, I'd love to sync with you if you need help on finishing that. I can particularly help to investigate the push API.

any updates?


GLatitude connection popup is empty

On a brand new locker, clicking connect to connect GLatitude popups a blank popup where the Google OAuth stuff is supposed to be. No errors are output. Popup address is about:blank.

I'm not sure when this was fixed, but it now is! Thank-you mystery coding elf!


SignalR Not Messaging Telemetry to Unity: broadcast azure function not firing when telemetry comes through ADT from device sim

I've gone through every step twice and have not been able to see any data come through to Unity in editor mode. It seems the event grid topic that ADT has an endpoint to is not receiving any events when telemetry gets sent from the device simulator to IoT Hub.
Attached are some screenshots of the different resources that I think might be involved.
If anyone has any idea why this step in the stack is not working I'd love to know!

Found the issue. When creating the resource group from Powershell the event route didn't get created for the ADT instance that was deployed.


zpages: add option for enabling / disabling zpages at startup time

It is a bit surprising that just importing zpages package (even if you don't register a handler) causes the infinite memory growth described in #597 even if DefaultSampler is NeverSample because of
func init() {
	internal.LocalSpanStoreEnabled = true
}

and
	if !internal.LocalSpanStoreEnabled && !span.spanContext.IsSampled() {
		return span
	}

This means enabling / disabling has to be done with a build tag right now, but a runtime command line flag would be best.

Agree this would be better enabled at runtime.

Thank you for filing this @toffaletti and thanks @ramonza for working on it!
@ramonza do you think we should remove that init invocation that enables zpages on the zpages.Handler variable? What else could we do here? Thank you.

FYI in Java ZPages needs to be explicitly initialized in application code:
https://github.com/census-instrumentation/opencensus-java/blob/9d533927c764069641ed56dcdcd0a83d05a5a14a/examples/src/main/java/io/opencensus/examples/zpages/ZPagesTester.java#L105

I think we can go ahead now and remove the Handler var that causes eager init.


Bump flannel to v0.24.2

Is your feature request related to a problem? Please describe.

Bump flannel to v0.24.2
Describe the solution you'd like

Describe alternatives you've considered

Additional context

Validated on Version:
-$   k3s version v1.29.1+k3s-de825845 (de825845)

Environment Details
Infrastructure
Cloud EC2 instance
Node(s) CPU architecture, OS, and Version:
NAME="Oracle Linux Server"
VERSION="8.9"
ID="ol"
ID_LIKE="fedora"
Cluster Configuration:
1 node servers
Steps to validate the fix

Install k3s with flannel backend
Validate flannel version v0.24.2
Validae nodes and pods are all ok

Validation Results:

 k3s -v
k3s version v1.29.1+k3s-de825845 (de825845)
go version go1.21.6

$  /var/lib/rancher/k3s/data/current/bin/flannel
CNI Plugin flannel version v0.24.2 (linux/amd64) commit HEAD built on 2024-02-09T23:42:01Z

~$ kubectl get nodes,pods -A
NAME                    STATUS   ROLES                       AGE   VERSION
node/ip-172-31-25-192   Ready    control-plane,etcd,master   94s   v1.29.1+k3s-de825845

NAMESPACE     NAME                                          READY   STATUS      RESTARTS   AGE
kube-system   pod/coredns-6799fbcd5-q87zx                   1/1     Running     0          79s
kube-system   pod/helm-install-traefik-crd-k66bv            0/1     Completed   0          79s
kube-system   pod/helm-install-traefik-rsc95                0/1     Completed   1          79s
kube-system   pod/local-path-provisioner-6c86858495-z7gc6   1/1     Running     0          79s
kube-system   pod/metrics-server-67c658944b-9p8g6           1/1     Running     0          79s
kube-system   pod/svclb-traefik-4f12ee92-jpsbr              2/2     Running     0          55s
kube-system   pod/traefik-f4564c4f4-ctptg                   1/1     Running     0          55s


Switch MiqRequestWorkflow dialogs accessor to writer only

Spotted by ruboop. There's already a reader method for dialogs on line 308:
https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_request_workflow.rb#L308-L310

@miq-bot add_reviewer @bdunne

@djberg96 can we switch the reference to @dialogs to use the attr_reader instead?  Switching this to only a writer feels wrong

@agrare I'm not sure I follow. The reader has a custom implementation:
  def dialogs
    @dialogs[:dialogs].each_pair { |n, d| yield(n, d) }
  end

Oh I didn't realize that, so it was overriding the reader defined by the attr_accessor?  I just saw @dialogs being used in a number of places.
Is def dialogs maybe badly named since it isn't a simple reader?

@agrare I wasn't sure what the original intent was, so I'm not sure. We could change it, though that risks breakage. As written, my guess is that it's being used by the UI.


Starting with Ruby 3.4.0, base64 will no longer be part of stdlib

Since I upgraded from Ruby 3.2.x to 3.3.0 a few days ago, I get the following deprecation notice on a Jekyll project that uses safe_yaml:

warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of safe_yaml-1.0.5 to add base64 into its gemspec.

There was a pull request already, that was deleted: https://github.com/dtao/safe_yaml/pull/107
What is the state on this issue?

You can get rid of the warning by doing what it says in it: add base64 to your Gemfile.
I had to do this with base64 and csv for my jekyll blog.

Reopened a PR for it here https://github.com/dtao/safe_yaml/pull/110
That being said, the last commit to this repo was 5 years ago, so I'm not sure what the chances at a merge are.


Introduce flakyTests=include/exclude/only

Previously we only had two strategies for flaky test: run all tests except flaky tests or only flaky tests. Now we support 3 strategies:

-PflakyTest=include this is the default value if it's not speicified. This run all tests.
-PflakyTest=exclude: run all tests excluding flaky tests.
-PflakyTest=only: run only flaky tests.

Now, for early stages (stages before ReadyForRelease), we use exclude strategy to exclude flaky tests. In ReadyForRelease builds we use include strategy (which is the default value for local build, too), and in FlakyTestQuarantine build we use only strategy.

@bot-gradle test rfr

OK, I've already triggered the following builds for you:

ReadyForRelease build

@bot-gradle test rfr

OK, I've already triggered the following builds for you:

ReadyForRelease build

@bot-gradle test rfr

OK, I've already triggered the following builds for you:

ReadyForRelease build

@bot-gradle test and merge

OK, I've already triggered a build for you.


Max IOPS from VMs

[Enter feedback here]
I'm confused by the statement "If you want to get the best performance for your VMs, you should limit the number of data disks to two disks per vCPU."
this seems to contradict the information on getting max IOPS from this article
https://docs.microsoft.com/en-us/azure/virtual-machines/linux/disk-performance-linux
If I wanted to get max IOPS from a Standard_D16ds_v4 it looks like I would want to have 5 cached P30 Data discs and 24 uncached P40 Data discs.
Can you let me know what I'm missing?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a43e5b4-7893-dcd7-839f-e394912d1bd9
Version Independent ID: 560d2e4a-6a12-48ac-dff7-44f036450250
Content: Ddv4 and Ddsv4-series - Azure Virtual Machines
Content Source: articles/virtual-machines/ddv4-ddsv4-series.md
Service: virtual-machines
Sub-service: sizes
GitHub Login: @brbell
Microsoft Alias: brbell

@bertsawicki We are checking this and will get back to you.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

#please-close


Geek's Den: Ruby on Rails Capstone

Here, I applied the knowledge gained in all the previous projects of the Ruby on Rails course.  Working with the MVC pattern, managing ActiveRecord's associations, using rails forms, testing, and model validations.
I want to apologize for the delay in delivering the project. We are in winter here in my country and the rain has been a source of a number of electrical and internet issues that prevented me from working at a productive pace. Before my deadline I sent a notification to Student Success about my situation, to let them know I would not be able to submit the project on time.
Project specifications

[x] The user logs in to the app, only by typing the username (a properly authenticated login is not a requirement)

[x] The user is presented with the homepage (see the Homepage screenshot above) that includes:

[x] Featured article with full-width image and title in the first row. This should be an article with the biggest number of votes.

[x] List of all categories in order of priority. Each category should be displayed as a square with its name on the top and its most recent article's title in the bottom. The background image should be the image of the most recent article in this category.

[x] When the user clicks the category name they can see all articles in that category (see the Articles in selected category page screenshot above):

[x] Articles are sorted by most recent.

[x] Each article displays image, title, truncated text as a preview, and its author name.

[x] Add extra button to add a vote for article (each user can vote only once).

[x] Each page should use the same top menu and footer

[x] When the user opens "Write an article" page:

[x]  A form with all necessary fields is displayed.

[x] It's not in the given design, but you should make an effort to follow the same style of the other pages.

[x] At the end extends your MVP app with one simple feature of your choice.

Technical mandatory requirements of the project

[x] The project is a desktop web app.
[x] Your database schema should reflect the following structure:

[x] You should validate all user input to make sure that none with bad intentions can destroy your app
[x] You can use view templates of your choice (.erb, .slim, .haml)
[x] Your app should be an MVP of the full product (with the full graphical design but only basic features that can be easily extended in the future)
[x] The project should be deployed and accessible online

General requirements:

[x] Add a descriptive README file to your repository
[x] The README must include instructions on how to use the project on your machine
[x] Use descriptive commit messages
[x] Do not commit debugging instructions

GitFlow:

[x] Create a development branch and set it as a default branch in your repository.
[x] Create a feature-branch branch (give it a descriptive name)
[x] Use Rubocop to validate your code.

[x] Divide your CSS in their respective files ie category styles to be in the category CSS file.

[x] Improve the UI to match the design, populate navigation menu based on category

[x] Add a link where a user can see all the categories

All changes suggested implemented.
Thanks for the feedback!

[x] Add option for the user to create categories. This solves the issue of the new article page not loading.

[x] Add links to social networks icons

Applied changes suggested


Document account setup

As a user, knowing where I need to go to create an account would be helpful in easing on boarding of the plug-in.
The readme needs to be updated to contain the instructions, along with the instructions showing up on the npmjs.com website

With the api key made public for on boarding, this item is no longer required.


[SE-0289] Rename "function builders" to "result builders"

Rename "function builders" to "result builders", per the second review of SE-0289. Start accepting @resultBuilder, but keep accepting @_functionBuilder with a warning for existing clients. The scope of the change is large because I'm updated source names, diagnostic text, and test files as well as accepting the new syntax so we'll have a clean slate going forward.

@swift-ci please smoke test

@swift-ci please test source compatibility

@swift-ci please smoke test macOS

Source compatibility failures are unrelated


commands being sent but not being recieved

As far as the skill is concerned everything is fine, i ask it to update video library and she says "updating video library" I ask to play my video playlist cartoons and she says "Playing the video playlist Cartoons" but kodi just sat there doing nothing. Sometimes if i repeated the command a few times it would eventually work, but usually by then I have picked up the remote :)
I changed line 310
timeout = (10, 0.01)

to
timeout = (10, 1)

Which appears to have sorted it. Though when I reverted back to 0.01 again so I could test and be sure, that was now appearing to be working fine (commands sent were actually being received by kodi).
I will keep an eye on it at the new (10, 1).
It may not even be related to the timeout, but it was definitely behaving as described for some reason.

Would need logs to know for sure what happened.

The first timeout is the connect/send timeout. In this case, that's all we care about, since we don't need to see the response (the skill will do the same thing no matter the response).
The second timeout is the read timeout. This one won't trigger at all until the outgoing packets have been transmitted and ACK'ed.
Not doubting that you saw a problem, but I don't think the timeouts are the cause -- it was just coincidence.
If you see it happen again, make sure to grab the log and we can see exactly what is happening.

Hmm.. was the screen saver active?  Because Kodi won't start playback if it is.

Here is the log from a time when it happened
2017-08-23T11:25:53.754Z Playing a random episode of the Simpsons

2017-08-23T11:25:53.754Z Searching for show "the Simpsons"

2017-08-23T11:25:53.754Z Sending request to https://yadayada.yada/subyada/jsonrpc from device amzn1.ask.device.YADA

2017-08-23T11:25:53.755Z [DEBUG]	2017-08-23T11:25:53.755Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	Starting new HTTPS connection (1): yadayada.yada

2017-08-23T11:25:55.333Z [DEBUG]	2017-08-23T11:25:55.333Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	https://yadayada.yada:1234 "POST /subyada/jsonrpc HTTP/1.1" 200 2423

2017-08-23T11:25:55.335Z Trying to match: the simpsons

2017-08-23T11:25:55.335Z Simple match on direct comparison

2017-08-23T11:25:55.335Z   BEST MATCH: "The Simpsons"

2017-08-23T11:25:55.335Z Sending request to https://yadayada.yada/subyada/jsonrpc from device amzn1.ask.device.YADA

2017-08-23T11:25:55.336Z [DEBUG]	2017-08-23T11:25:55.336Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	Starting new HTTPS connection (1): yadayada.yada

2017-08-23T11:25:55.604Z [DEBUG]	2017-08-23T11:25:55.604Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	https://yadayada.yada:1234 "POST /subyada/jsonrpc HTTP/1.1" 200 74

2017-08-23T11:25:55.605Z Sending request to https://yadayada.yada/subyada/jsonrpc from device amzn1.ask.device.YADA

2017-08-23T11:25:55.606Z [DEBUG]	2017-08-23T11:25:55.606Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	Starting new HTTPS connection (1): yadayada.yada

2017-08-23T11:25:55.994Z [DEBUG]	2017-08-23T11:25:55.994Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	https://yadayada.yada:1234 "POST /subyada/jsonrpc HTTP/1.1" 200 35288

2017-08-23T11:25:56.004Z Sending request to https://yadayada.yada/subyada/jsonrpc from device amzn1.ask.device.YADA

2017-08-23T11:25:56.009Z [DEBUG]	2017-08-23T11:25:56.9Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	Starting new HTTPS connection (1): yadayada.yada

2017-08-23T11:25:56.314Z [DEBUG]	2017-08-23T11:25:56.314Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	https://yadayada.yada:1234 "POST /subyada/jsonrpc HTTP/1.1" 200 187

2017-08-23T11:25:56.316Z Sending request to https://yadayada.yada/subyada/jsonrpc from device amzn1.ask.device.YADA

2017-08-23T11:25:56.316Z [DEBUG]	2017-08-23T11:25:56.316Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	Starting new HTTPS connection (1): yadayada.yada

2017-08-23T11:25:56.891Z [INFO]	2017-08-23T11:25:56.891Z	d2dc7607-87f5-11e7-9d35-251af3db3d22	<IP_ADDRESS> - - [23/Aug/2017:11:25:56 +0000] "POST / HTTP/1.1" 200 316 "" "Apache-HttpClient/4.5.x (Java/1.8.0_131)" 0/3602.214

2017-08-23T11:25:56.892Z END RequestId: d2dc7607-87f5-11e7-9d35-251af3db3d22

2017-08-23T11:25:56.892Z REPORT RequestId: d2dc7607-87f5-11e7-9d35-251af3db3d22	Duration: 3609.87 ms	Billed Duration: 3700 ms 	Memory Size: 512 MB	Max Memory Used: 49 MB

As you can see as far as the Skill is concerned it is all working fine, it requests the data several times, it is just the final "play" bit that was not working, and this was true when asking it to pause, stop, update library etc all commands with wait_resp set to False.
Maybe it is a thing to do with https or that I am using Nginx as a reverse proxy. I haven't used Kodi that much in the past couple of days but when I have it has worked fine (commands are being received).
I wouldn't worry about it for now, but I will let you know if things change.

Hmm the proxy could be the issue if it doesn't forward the packets to Kodi before the skill closes the connection.

I'll make an option to disable async IO.  But, if I were you I'd look into your proxy server a bit more and see if you can't solve it there, since it will increase latency.

Added a config option no_async_io so you can disable it.

Replaced the no_async_io option by exposing both of the read timeouts as read_timeout and read_timeout_async.   Otherwise calls that really do need to be non-blocking (such as clean library) would always result in an error message from Alexa.
Let me know if this works for you.

Going to release a new Kodi-Voice version soon.  Should I include this?

sorry didn't see all this activity
it has been fine since i changed the timeout mentioned in the first post, maybe a coincidence, im not sure. But without it failing I can't tell you if your fix works.
I did try the new version and disabled async. This was sending (and kodi was receiving) commands fine (though remember it was sending/receiving commands fine without it).
It did stop giving me feedback though. So whilst "alexa, play my video playlist, cartoons" did work, I wasn't getting the "playing the video playlist, cartoons" response.
I doubt the proxy is causing any significant lag, it is just nginx running locally on a pi. If it happens again I will reopen, but it might be better to not have it as a config option as the lack of responses might cause more confusion.

The option to disable async requests was removed in favor of making the timeout configurable. This should mask the problem for you, at the expense of a bit more lag (whatever you set the timeout too, or if Kodi sends the whole response first).

cool, so perhaps my initial timeout tweak was not just coincidental
thanks for looking into it

No, I suspect it wasn't, though if you're going to use a proxy it should probably (if possible) be configured to wait until all data has been transmitted before closing the connection.
Or, you can just live with a bit of extra latency if you don't feel like looking into it :)


'hf' model "Mixtral-8x7b" unable to load.

While loading the model "ehartford/dolphin-2.5-mixtral-8x7b" into the Lida llm, I am getting the error shown in the image.
I am loading it in a CPU.
The llama models are loading fine but the new Mixtral is facing a problem.

I would highly appreciate a detailed response and solution.

The mixtral models have not been tested with lida/llmx.
I would recommend the following.

load the model using a tool like vllm which supports mixtral
vllm provides an openai compatible api
use the openai llm approach, but point it to the vllm server.

# spin up a vllm endpoint

from lida import Manager, TextGenerationConfig , llm

model_name =  # mixtral model
model_details = [{'name': model_name, 'max_tokens': 2596, 'model': {'provider': 'openai', 'parameters': {'model': model_name}}}]

# assuming your vllm endpoint is running on localhost:8000
text_gen = llm(provider="openai",  api_base="http://localhost:8000/v1", api_key="EMPTY", models=model_details)
lida = Manager(text_gen = text_gen)

On a somewhat related point, is there a way to use HuggingFace dedicated endpoint here?


Switching document tab makes 'Remove Unnecessary Usings' pops up.

VSCode Version: Code - Insiders 1.10.0-insider (723b20093d2f525e84cdf94a52f7695d1d539273, 2017-02-03T08:24:58.073Z)
OS Version: Darwin x64 16.4.0
Extensions:

Extension
Author
Version

csharpfixformat
Leopotam
0.0.8

unity-tools
Tobiah
0.1.9

unity-snippets
YclepticStudios
0.1.2

csharp
ms-vscode
1.6.2

theme-actual-obsidian
zehfernando
1.4.2

Steps to Reproduce:

Click other tab, cmd+alt+direction to switch or cmd+number to create new window.

@antonkudin please add more details what you mean

Its manifested again, here's a gif of it in action.
Only middle tab here makes the popup appear.
I use mouse clicks couple times to switch tabs, then use keyboard shortcut and popup still appears out of nowhere.

It also seems like having top line in a document be one of the unused 'using'-s makes it appear (it appears underlined in green). Doesn't happen if top 'using' is actually important for this document's code.

This is related to the C# extension, please file this at https://github.com/OmniSharp/omnisharp-vscode/issues/new


Update Personal Data Stores section about Solid.

Changes in this PR updates information about Personal Data Stores section about Solid to more accurately reflect definitions and current development.

WG reviewed. No issues with the language. Need to validate that there is no issues with membership contribution.

Will try to get this merged before our meeting today

Follow up on this: No issues with PR, am back channeling the membership issue. If there's a better forward will let you know.
@csarven  just a heads up:

How about this way forward:

I, Sarven Capadisli, hereby release my contribution in this Pull Request (archived) to the public domain and grant unrestricted usage rights to Decentralized Identity Foundation for incorporation into the Decentralized Web Node Companion Guide.

Let me know if an adjustment to the text above would make it easier for you. Feel free to add me as a contributor of some sort somewhere without necessarily implying I endorse the work.

@csarven I believe this will work. Also talked with @acoburn and noted that they are in DIF now. We will try to merge today.

Thanks for being patient on this @csarven . Obviously we are just trying to protect our members. We should have this in today.

What's the relevancy of @acoburn or "they" (?) to my contribution in this PR where I also took the initiative to make it public domain?
You're welcome.

@csarven merging in. Discussed at the group today. Non-normative and should be fine.


The website does not have favicon

Describe the bug
There is no favicon on the website, so can I use the logo of website and make a favicon and put it on the website
Screenshots

go for it @Vanshiii203


In on-demand loading, a command with ! is invalid?

Plug 'skywind3000/asyncrun.vim',  { 'on': ['AsyncRun!'] }

The above config gives me this:
Error detected while processing function plug#end:
line   60:
E182: Invalid command name

And it works as usual without !.
From my point of view, it would be better if this case could be  covered.

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Nov 21 2016 17:35:16)
MacOS X (unix) version
Included patches: 1-94
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +cmdline_hist    -ebcdic          -gettext         +listcmds        +mouse_sgr       +persistent_undo +smartindent     +textobjects     +wildmenu
+arabic          +cmdline_info    +emacs_tags      -hangul_input    +localmap        -mouse_sysmouse  +postscript      +startuptime     +timers          +windows
+autocmd         +comments        +eval            +iconv           +lua             +mouse_urxvt     +printer         +statusline      +title           +writebackup
-balloon_eval    +conceal         +ex_extra        +insert_expand   +menu            +mouse_xterm     +profile         -sun_workshop    -toolbar         -X11
-browse          +cryptv          +extra_search    +job             +mksession       +multi_byte      -python          +syntax          +user_commands   -xfontset
++builtin_terms  +cscope          +farsi           +jumplist        +modify_fname    +multi_lang      +python3         +tag_binary      +vertsplit       -xim
+byte_offset     +cursorbind      +file_in_path    +keymap          +mouse           -mzscheme        +quickfix        +tag_old_static  +virtualedit     -xpm
+channel         +cursorshape     +find_in_path    +lambda          -mouseshape      +netbeans_intg   +reltime         -tag_any_white   +visual          -xsmp
+cindent         +dialog_con      +float           +langmap         +mouse_dec       +num64           +rightleft       -tcl             +visualextra     -xterm_clipboard
-clientserver    +diff            +folding         +libcall         -mouse_gpm       +packages        +ruby            +termguicolors   +viminfo         -xterm_save
+clipboard       +digraphs        -footer          +linebreak       -mouse_jsbterm   +path_extra      +scrollbind      +terminfo        +vreplace
+cmdline_compl   -dnd             +fork()          +lispindent      +mouse_netterm   +perl            +signs           +termresponse    +wildignore
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -L/usr/local/lib  -L/usr/local/lib -o vim        -lm  -lncurses -liconv -framework Cocoa  -L/usr/local/lib -llua -fstack-protector  -L/System/Library/Perl/5.18/
darwin-thread-multi-2level/CORE -lperl  -L/usr/local/opt/python3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/config-3.5m -lpython3.5m -framework CoreFoundation  -lruby.2.
0.0 -lobjc

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[ ] Question

OS:

[ ] All/Other
[ ] Linux
[x] OS X
[ ] Windows

Vim:

[x] Terminal Vim
[ ] GVim
[ ] Neovim

Makes sense. I assume that you already know, but :Foo! is not a separate command but a variation of :Foo, so it cannot be defined independently. I can just make vim-plug ignore the trailing ! in that case.

Just to ignore it is enough for the present. Thanks!

Should be fixed now, thanks.


Fix mismatched cases of inlineStart/End and flexStart/End

Summary: Back when I introduced the inline functions that would get the edge according to the writing direction I swapped some instances of setLayoutPosition which wrote to the flexStart edge erroneously. We should basically never read from some inline style and write to the flex edge. This changes them all to use the flex values.
Differential Revision: D52921401

64d81905acbdbef01f9bc5818a20367917372be4


Not firing onClick event

Question

The images above show that I used custom formatter to achieve this.
So when I try to click the said button, it does not fire the onClick event

My bad. It was my mistake


Config object overrides of tapis-redux configuration should be key based

Currently, if values in config objects are falsy, they are overridden. This is undesirable because an external state manager may set a value like token to be null to indicate a logout, but tapis-redux will currently fall back upon the internally stored token state and perform operations anyway.
tapis-redux should:

Check for key values in config
If a key value is present, always use it in an override even if the value is falsy (this will generate errors, but that is fine and should be expected)
If a key value is not present use the fallback values such as token state and tenant URL

not relevant


engge closes unexpectedly when accessing the options menu or saving game, normally the second time

Describe the bug
engge closes unexpectedly when accessing the options menu or saving game, normally the second time
To Reproduce
Testing the commit:
Fix call a callback when exiting elevator (https://github.com/scemino/engge/commit/aeb37dae999a0187eb837858dd4839b22ee7ec93)
engge closes unexpectedly when accessing options or when saving a game, usually the second time, when I try to open the options menu or when saving in a new slot. This I tested at the beginning, part 1, managing Boris. I saved the game after crossing the door, and when saving again in the same area, engge has closed unexpectedly, no error is observed in the log.
Expected behavior
Screenshots
Desktop (please complete the following information):

OS: Windows x64
Version 10

Additional context

I can't reproduce it, did you try to remove (or just move in other directory) your savegames? Maybe it comes from a 1 or more corrupted savegames, if it comes from a savegame, can you send it to me, I will try to fix the issue correctly.
Thank you.

I can't reproduce it, did you try to remove (or just move in other directory) your savegames? Maybe it comes from a 1 or more corrupted savegames, if it comes from a savegame, can you send it to me, I will try to fix the issue correctly.
Thank you.

You are right, the problem is due to a saved game ... maybe some data was corrupted when saving it. I think that when there is a failure a json of the saved game is generated, right?
I have moved the saved games to another location and the problem has been resolved. However, I am sending you the saved games so you can keep an eye on them.
Link:
https://www.mediafire.com/file/nk8ttvmq07eiw01/engge-0.5.0-alpha-win32-saves_fail.7z/file
Cheers :)

With the commit aeb37da, if I load the second savegame you gave me I can reproduce a crash when moving Boris to the body, I can reproduce it each time. With the last commit b0bdea3, there is no crash. So I close this issue if you agree.

I see it correct :)


Why defining run_time on worker node raises an error

Prerequisites

[X] I am using the latest version of Locust
[X] I am suggesting a new feature, not asking a question

Description
Currently when worker node receives run_time parameter raises an error and it seems that stops working.
I thing that worker could simply ignore this parameter and at most log a warning. This would simplify configuration in case of 'local distributed' load, i.e. multiple worker processes on one machine for better CPU utilization.
Funnily enough it seems that this error is not raised, when --config option is used and file has non-standard name (like worker.conf)
Tested on v. 2.25.0 - latest on pip.

Yea, it really only made sense before config files were introduced. I'll change it to an info level log message.


WIP - Fix issue #212 - Navigation header items disappear when view width is too narrow

Waiting for E2E tests to get fixed before submitting the PR for review

I'm not sure why the branch issue-212 is not getting updated. I'll close this PR and reopen it


Use react-native-web

This package largely copy-pastes or reimplements react-native-web for the web implementation. You could simply depend on react-native-web and contribute any adjustments required. That project also has better test coverage and more correct implementations. Let me know if you'd like to discuss further

Hey man, I'm not sure why you decided to use a fork of RNW in this patch and continue to refuse to engage us in developing it. I made it clear at the Airbnb-hosted React Wednesday way back when that we'd be happy to do that. We're iterating on the StyleSheet implementation to focus on the performance (reintroducing the className strategy) now that the correctness is in place. Not sure what your reasoning is, anyway, take it easy.

Hey Nicolas,
Thanks for creating this issue and starting the discussion.  I certainly would like to discuss further, and think that any collaboration we can do would be a good thing.  Please keep in mind that react-primitives is a personal project for me, is not currently used by Airbnb for web purposes, and is most interesting to me at an academic level (though I do believe has a lot of practical value in the medium to long term).  No one (that I know of) is depending on react primitives in production, and right now I have some renewed interest in this project because of another platform I am working on as a backend for it (sketch).
Sometimes, "forking" is required to try out new things, and better understand problems. A lot of the iteration I've been doing on the StyleSheet implementation, performance improvements, and flexbox fallbacks could not be done as easily with a project that people depend on like react-native-web. Also, the goals of the project are arguably different (creating a web equivalent of all of react native versus creating a minimal common interface for creating UI on different platforms).
I view a project like react-primitives as needed for a couple of reasons. A very rushed explanation of the core philosophy is something like this, though I'd like to write more on the topic later:
JavaScript is becoming a very realistic option to write cross-platform code. JavaScript libraries that don't work with DOM APIs (like pure business logic, redux, math libraries, lodash, etc.) all work great in this realm, but UI libraries have always been a problem, and a good chunk of code for an application touches this in one way or another, so sharing entire applications becomes very difficult.  React of course challenges this and makes it such that actually most of our UI related code may not need to touch DOM API's at all. React Native made this vision a lot more clear, and also came with one more gem: the handling of platform-specific file extensions. Platform specific file extensions allow for an application's dependency graph to split in small areas, and come back, defining common interfaces with different implementations.
I view react-primitives as the minimal set of components that most platform-inspecific UIs can be built from. This would go beyond just ios/android/web (see sketch as one such crazy example). My goal is for library authors to be able to depend on react-primitives instead of react-dom directly, and then be guaranteed to be building cross-platform things so long as their dependencies never go beyond that. For that reason, I think it's crucial that the naming of the project indicates that this isn't a "react native" thing, and this isn't a "web" thing. The fact that the interface is pretty similar to react native's core components is just a sane choice, but not a necessity.
As a result, I think there are three possible end states for the two projects:

react-primitives depends on react-native-web.
react-native-web depends on react-primitives.
neither libraries depend on each other.

You are proposing option 1, which is pretty reasonable. RP already depends on react-native, and react-sketchapp, and RNW wouldn't be all that dissimilar. At that point, RP just becomes the "name" of the common interface for each platform. The concerns I would have for this approach are as follows:
Performance: Some rough benchmarks of RP vs RNW seemed to indicate that RP was ~30x faster for most benchmarks I tried. I don't doubt that some of this comes at the cost of correctness, and I'm working on cleaning up some of those edge cases (like deoptimizing when an inline style overrides a registered style).  I think performance for RNW or RP will be critical in convincing people that it's a reasonable platform to build on, so I don't think there is anything as important as this right now.
Size: The web platform is unique in terms of how important bundle size will be. I eventually would want RP to be something that component library authors don't think twice about depending on (as opposed to explicitly or implicitly depending on react-dom, for instance). In order for this to happen, bundle size needs to be monitored, and this means not relying on all of react-native web. I think you've mentioned before that importing a core build of RNW for this purpose could be done. I think that's reasonable. The concern there might be that the RNW package is going through lots and lots of breaking changes to non-core APIs, and that in turn huts the compatibility matrix of libraries depending on RP.
I think option 2 also does make some sense. In many ways, RNW could be seen as a superset of RP, and having a big library depend on the smaller library in this case makes sense. This seems like a bit of a harder pill to swallow at this stage, considering RNW is a much more popular library than RP (which doesn't really have any consumers at this point).  This is a good way to have minimal duplicated work, while keeping the intentions of each library in tact as well. If the "correctness" of the stylesheet implementation get's fixed, this could also result in a fairly significant performance improvement for RNW users.
At the end of the day, option 3 would be a bummer but is also a possible reality. The downside there is duplicated work and two people working on a very similar problem in isolation versus collaborating.
I would definitely like to talk more about this, and am going to reopen this issue. I apologize for taking a few days to reply to this issue, and hope you don't think I was just ignoring you or something.
With that said, I hope you don't mind me continuing to hack on this project during my holiday because it is currently a project I'm having fun working on, even if I'm just learning some of the same things that you learned months ago. I could make the project private and then no one would know, but I prefer to write code out in the open.

OK sgtm and I understand. No question about making this private, if anything I hope you don't mind if there is cross-pollination in the other direction so I can apply some optimizations you develop back to RNW while we figure out the relationship between the projects.

@necolas I most definitely DO NOT mind. If anything, I'd be happy to chat about different trade-offs and corner cases that have caused us both to end up where we are right now. Getting stylesheet working on the web is a tricky business, but I'm pretty happy with where this implementation has gotten. I have a feeling you've stumbled into more corner cases than I have, but I think I've tackled some of the hard performance problems reasonably well.
Also, i forgot to mention that the reason I depended on the fork of RNW instead of master is only because i needed the fork that uses react 15.4

After adding memorization and mapping styles to class names render performance is looking much better without altering the computed styles. 13-15 times faster than before.
Benchmarks on my machine (means)

react-native-web@master: ~3500ms / ~500ms
react-native-web@stylesheet-rewrite: ~220ms / 35ms
react-primitives: ~140ms / ~30ms

I initially tried using the react-primitives stylesheet. But the computed styles were incorrect (because it concatenates class names when resolving RN array-styles).
There are more memoization optimizations I think I could squeeze out for arrays of mixed style types. And I'd like to find out what happens when you hydrate the cache from a SSR stylesheet

After adding memorization and mapping styles to class names render performance is looking much better without altering the computed styles. 13-15 times faster than before.
Benchmarks on my machine (means)

react-native-web@master: ~3500ms / ~500ms
react-native-web@stylesheet-rewrite: ~220ms / 35ms
react-primitives: ~140ms / ~30ms

I initially tried using the react-primitives stylesheet. But the computed styles were incorrect (because it concatenates class names when resolving RN array-styles).
There are more memoization optimizations I think I could squeeze out for arrays of mixed style types. And I'd like to find out what happens when you hydrate the cache from a SSR stylesheet

@necolas very cool!  Sounds like you got some big improvements.

I initially tried using the react-primitives stylesheet. But the computed styles were incorrect (because it concatenates class names when resolving RN array-styles).

Can you elaborate on this a little bit more?  I wasn't aware of incorrect semantics with my current implementation, and would like to know what I am missing.
The current implementation implements higher specificity of class names by their position in the nested array:
ie, <View style={[styles.foo, [styles.bar, styles.baz]]} /> would result in the following HTML and CSS:

.foo { ... }
.bar1.bar1 { ... }
.baz2.baz2.baz2 { ... }

Is this the behavior that you were saying was incorrect?

@necolas very cool!  Sounds like you got some big improvements.

I initially tried using the react-primitives stylesheet. But the computed styles were incorrect (because it concatenates class names when resolving RN array-styles).

Can you elaborate on this a little bit more?  I wasn't aware of incorrect semantics with my current implementation, and would like to know what I am missing.
The current implementation implements higher specificity of class names by their position in the nested array:
ie, <View style={[styles.foo, [styles.bar, styles.baz]]} /> would result in the following HTML and CSS:

.foo { ... }
.bar1.bar1 { ... }
.baz2.baz2.baz2 { ... }

Is this the behavior that you were saying was incorrect?

Can you elaborate on this a little bit more? I wasn't aware of incorrect semantics with my current implementation, and would like to know what I am missing.

After reading your comment and code I realised I must have made a mistake. Tried integrating it again and it renders the RNW storybook examples correctly AFAICT! There was one small issue – TouchableHighlight not clearing the pressed state, but I didn't look into it. Quite a cool hack to use class chaining. I wonder what (if any) effect there is on generated CSS in a big app.
I ran RNW through the benchmarks and switched between the StyleSheet implementations:

react-native-web@stylesheet-rewrite: ~220ms / 35ms
react-native-web@stylesheet-rp: ~370ms / 55ms

At this stage it's encouraging to have 2 different approaches with similar results!

Can you elaborate on this a little bit more? I wasn't aware of incorrect semantics with my current implementation, and would like to know what I am missing.

After reading your comment and code I realised I must have made a mistake. Tried integrating it again and it renders the RNW storybook examples correctly AFAICT! There was one small issue – TouchableHighlight not clearing the pressed state, but I didn't look into it. Quite a cool hack to use class chaining. I wonder what (if any) effect there is on generated CSS in a big app.
I ran RNW through the benchmarks and switched between the StyleSheet implementations:

react-native-web@stylesheet-rewrite: ~220ms / 35ms
react-native-web@stylesheet-rp: ~370ms / 55ms

At this stage it's encouraging to have 2 different approaches with similar results!

Nice.  Do you have a link to a branch where you have these benchmarks?  I'd love to take a look.

Nice.  Do you have a link to a branch where you have these benchmarks?  I'd love to take a look.

Added here https://github.com/necolas/react-native-web/commit/d87f71ebc11d4ac986ec39a039ec4f7c96916e7d

Thanks for working together on this :)

@lelandrichardson One of the greatest explanation of the motivation behind the library I have ever seen


[Release-1.31] - Custom path for runtimes autodetect

Backport fix for Custom path for runtimes autodetect

#10761

Validated on release-1.31 branch with commit
Steps: https://github.com/k3s-io/k3s/issues/10761#issuecomment-2412007090
Validation
$ k3s -v
k3s version v1.31.1+k3s-51591315 (51591315)
go version go1.22.6

$ sudo cat /var/lib/rancher/k3s/agent/etc/containerd/config.toml | grep nvidia
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes."nvidia"]
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes."nvidia".options]
  BinaryName = "/home/ubuntu/nvidia-container-runtime"


Fix docker image based on Python 3

Since I switched to using scons instead of make, Python 3 docker image cannot be built anymore. I overcame scons' limitations in CI runs, I believe I will work around its "Python 3 not supported" opinion in docker too.

Fixed in b0284b33af85e3701de5642c8051e9d764295c77


Italian language

I have searched extensively on Hugo documentation, but can not find something that conserved Italian  language support. I have in my config.toml file (with huge-academic theme) set italian language this way:
[languages.it]   languageCode = "it"
It does not show on the drop down manu, however there is an icon of the language and it shows only english.
Thanks

@raffdoc Salve. Currently Italian is not supported. It only supports the languages from the i8n/ folder. So you could translate the file yourself, then add the new mapping in the native_names.yaml. You can check more details from issues #151 and #155.
Buona fortuna.

@YonghuiDong thanks for helping.
@raffdoc feel free to create a pull request on GitHub if you translate the language file to Italian :)


Detect Changes - Incorrect State

Scenario -

Attach an entity to the context with a known primary key specified (Id > 0)
Extend entity graph by adding/associating another entity with an Id > 0
Trigger DetectChanges for ex; invoke context.ChangeTracker.Entries().

You will find the new entity (which was not explicitly attached) being tracked.
It's state however is incorrectly tracked as "Added" and not "Unchanged".
If the new entity were to be attached via context.Attach, its state is correctly determined.
Steps to reproduce
Repro : https://github.com/avinash-phaniraj-readify/EFCoreTestBed/tree/DetectChangesStateError
           var context = new TestDbContext(options);

            var emp = new Employee { Id = 1, Name = "known employee" };
            emp.Devices = new List<EmployeeDevice>();
            context.Attach(emp);

            var device = new EmployeeDevice { Id = 1, EmployeeId = 1, Device = "known device" };

            emp.Devices.Add(device);
            context.ChangeTracker.Entries();

            Debug.Assert(context.Entry(device).State == EntityState.Unchanged);

Further technical details
EF Core version: 2.1.4
Database Provider: EntityFrameworkCore.SqlServerCompact35 <IP_ADDRESS>
Operating system: Win 10
IDE: (e.g. Visual Studio 2017 15.8.4)

@avinash-phaniraj-readify Please see my response to #13564 and also see #13575 which would change this if we chose to implement it.


split with lasso doesn't seem to work properly

Here is my lasso:

And here is what I see after I press k:

hmm, cannot reproduce this... is it systematic?
might be related to #367

Here is another reproduction, now with just one cluster selected and when one of the feature axes is not time (those were two of my hypotheses):
before split:

after split:

Note orange points within the teal ones. I also see the same kind of thing when I do it in the feature grid rather than single feature view.

just want to second nick - i see this is as well. not with every every cluster, but more often than not.

weird!! I'll have a look

from a quick look, it seems that this happens when there are more spikes than what can be displayed in the feature view. so can you try to increase features_n_spikes_max and features_grid_n_spikes_max in your ~/.phy/user_settings.py so that they are larger than the number of spikes in the clusters you want to split? let me know if it works. I'll work on an actual fix in the meantime...

Yes! It does seem to work now that I did that. This is great as a
workaround for now - I think I wanted to have more spikes displayed,
anyway, now that I see it that way.
On Tue, Jun 23, 2015 at 1:33 PM, Cyrille Rossant<EMAIL_ADDRESS>wrote:

from a quick look, it seems that this happens when there are more spikes
than what can be displayed in the feature view. so can you try to increase
features_n_spikes_max and features_grid_n_spikes_max in your
~/.phy/user_settings.py so that they are larger than the number of spikes
in the clusters you want to split? let me know if it works. I'll work on an
actual fix in the meantime...
—
Reply to this email directly or view it on GitHub
https://github.com/kwikteam/phy/issues/355#issuecomment-114477621.

fwiw i found the bug and i have almost fixed it...

i'm trying to find user_settings.py in my windows install - i see ~/.phy/internal_settings, but no user_settings.py. is there somewhere else to change the number of displayed spikes? or i can just wait for the bug fix.

you have to create the text file manually..

you have to create the file yourself...
On Tue, Jun 23, 2015 at 3:58 PM, danieljdenman<EMAIL_ADDRESS>wrote:

i'm trying to find user_settings.py in my windows install - i see
~/.phy/internal_settings, but no user_settings.py. is there somewhere else
to change the number of displayed spikes? or i can just wait for the bug
fix.
—
Reply to this email directly or view it on GitHub
https://github.com/kwikteam/phy/issues/355#issuecomment-114534752.

You just make it and put it in ~/.phy/. Mine has literally these lines and
nothing else:
features_n_spikes_max_bg = 250000
features_n_spikes_max = 50000
features_grid_n_spikes_max = features_n_spikes_max
On Tue, Jun 23, 2015 at 3:58 PM, danieljdenman<EMAIL_ADDRESS>wrote:

i'm trying to find user_settings.py in my windows install - i see
~/.phy/internal_settings, but no user_settings.py. is there somewhere else
to change the number of displayed spikes? or i can just wait for the bug
fix.
—
Reply to this email directly or view it on GitHub
https://github.com/kwikteam/phy/issues/355#issuecomment-114534752.

got it. thanks.

HA! Don't let anyone tell you that the tech support for phy is bad... ;-)

@nippoo is it worth creating an empty file automatically if there is none? (with maybe just one line with a link to the doc or something) -- also we don't want to erase this file when the user reinstalls phy...

Yes, I actually wrote an issue for this but forgot to file it yesterday. We should create an empty file if there is none, perhaps ideally with a comment explaining where to find the list of params and their description/defaults

this is now all fixed in an upcoming PR


There is no obvious way to specify the aggregate function for the index.

There is no obvious way to specify the aggregate function for the index.
I wonder if adding implicitly the index in select/group_by isn't an error. Maybe we can make the index reference mandatory. Would it be desirable to check that the index values are sorted in ascending order?
Working on that in https://github.com/s-leroux/fin/tree/exp/make-index-selection-explicit
Originally posted by @s-leroux in https://github.com/s-leroux/fin/issues/30#issuecomment-2043759707
Other things to consider:

The index selection is also implicit for join operations.
We may introduce the new sort predicate to change the index.
OTOH, some use cases seem hard to express at first sight without explicit index selection. For example: "Calculate the average prices per month"

* OTOH, some use cases seem hard to express at first sight without explicit index selection. For example: _"Calculate the average prices per month"_

What about:
serie.select(
  (fc.named("MONTH"), fc.month, "DATE"),
  (fc.named("PRICE"), "CLOSE"),
).sort(
  (fc.concat, "MONTH", "DATE"),
).group_by(
  "MONTH",
  (ag.avg, fc.named("AVG PRICE"), "PRICE")
)

Few comments:

In a group_by clause/predicate, the aggregate function for the index defaults to fc.first (as it is hard-coded now: https://github.com/s-leroux/fin/blob/8352851a60c206fa6a8e7a3813bbf440ab952073/fin/seq/serie.pyx#L226)
both select and group_by explicitly state the columns in the result series. But join operations work on the full series column set. What should be done for sort? Should the behavior be consistent between all predicates, for example, saying the only select can change the column set? It seems rather impracticable for group_by, though.

From c058cfb1523e734548d1479a90ad2f02f4406d50 and now on, I will experiment with removing the index "special" column.
Some previously implicit things will have to now become explicit, like specifying the join column(s). This will cause problems with the operator version & and |.

... or we may make the index a "hidden" property of the serie to keep track of their order for operations that require implicit knowledge of that?


Small Problem in the player

Hello, i have implement the GiraffePlayer, and the video is online, but some times appear the message: "The Player have small problem". Why appear this?

some errors occur,such as network not available，the console will print the stack

But, when I'm export in signed Apk, I'm using the giraffe player and the Internet connection is strong, and appear this message

I have also encountered this situation

我也遇到了这个问题，在demo 中没有问题
搞到fragment 中，点击播放和暂停点不动了


Stochastic Block Model Reduction

Last semester, I developed an algorithm to compute the maximum likelihood low dimensional representation of an ER SBM. Optimizing the objective of this algorithm is very slow, and thus, it is intractable for large problems. This semester, I would like to improve on this algorithm, and in particular:

Prove that blocks only merge when ER SBMs are reduced (I am almost sure this is true)
Use the above fact to decrease the complexity of the algorithm from O(2^n) to O(n log (n) )
Run the algorithm on the HBN data to cluster patients by reduction tree distance
(REACH) Run the algorithm on Coyote/Sea Lion dataset to investigate properties of many/one nomination

My b wrong repo


[Doc Issue][Fixing video link in proactive messages]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/conversations/send-proactive-messages.md
95
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 303e95a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/conversations/send-proactive-messages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/conversations/send-proactive-messages.md
95
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0cc2e3c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/conversations/send-proactive-messages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Python script for dummy regressor

I have finished the python script for dummy regressor. The test score is negative, which is very bad. I don't think it is necessary to include it in the final report given the test score. But let's discuss about it tomorrow in the meet up.

Sounds good Yiki and thank you!!


Remove regional difficulty

Is mostly deactived already, just a few leftovers in onSpawnWithEgg in a couple of mob classes.
Though maybe one could reuse that local tension system for something else? Since it is pretty general

Closing this since onSpawnWithEgg behavior was removed with entity flatten


Forcing SSL

Does it ever make sense NOT to use SSL when requesting a token? Should SSL be forced when requesting/revoking a token?
(It might make sense to be more flexible inside the "authenticated" controller - for example read operations probably don't need SSL, but write ones do... but inside the "token" controller - I am thinking it should always be SSL forced down your throat).
http://api.rubyonrails.org/classes/ActionController/ForceSSL/ClassMethods.html
Thoughts?

Yeah, actually you should have SSL enabled at all times when requesting a token (and also just always and for everything actually). I'm not sure whether we should solve this by adding code that does it or by simply adding documentation that reminds devs of switching on SSL when deploying this to production.
You might also be running this only internally so that it only receives requests from other APIs that are accessible from the internets then. In that case you could argue SSL isn't really required.

@marcoow - I believe there are 2 distinct scenarios:
Scenario 1: (This is the scenario you are describing) Your website always needs to be authenticated. You can't DO ANYTHING without putting in your username and password. This scenario is simple to implement. Inside production.rb
config.force_ssl = true

Everyone is happy - no changed to rails_api_auth gem needed.
Scenario 2: Your website traffic is READ-heavy. For a lot of the pages, you don't need or want authentication and you don't want SSL. But for say an admin section of your website, you DO want SSL. In this case, you want to deploy your website WITHOUT SSL and turn on SSL (AND FORCE) for individual controllers (including the OAuth controller) using something like force_ssl
I am currently implementing a Scenario 2 type application and I would like to constrain the Oauth 2 controller to ALWAYS force SSL.
So, what I am proposing is as follows (and I can PR this if you agree that this is a good idea):

Have force_ssl inside Oauth2Controller with an if option

Add an accessor to RailsApiAuth module that can be added through configuration in the initializer, something like lockdown_with_ssl. Something like:

raa.lockdown_with_ssl = true

The default for this value could be false, so nothing will really change for existing apps or even future apps, UNLESS you configure this new value to be true
What do you think?

Yeah, sounds like adding
RailsApiAuth.force_ssl

which would default to true would probably be a good idea.

You want me to PR this one?

Sure, would be great

implemented in #34


Update build script to use SimulatedPlayer instead of FakeClient

Description
We are renaming "fake client" to "simulated player" to align terminology across (upcoming) projects.
The build script has the option to build headless Linux (fake) clients. This PR renames the option to build these headless Linux clients from FakeClient to SimulatedPlayer.
For backwards compatibility the build script will still support FakeClient as a GameName (which results in<EMAIL_ADDRESS>as the created assembly), but will show a warning to use SimulatedPlayer instead. Using SimulatedPlayer as the GameName will result in the same assembly being created under a different name<EMAIL_ADDRESS>Release note
No release notes: the FakeClient/SimulatedPlayer option in the build script is currently for internal use only.
Tests
Tested this change by building both a FakeClient and SimulatedPlayer assembly for an existing project. Result when using FakeClient hasn't changed, except for now showing a warning message. Using SimulatedPlayer outputs the same assembly as FakeClient under a different name.

Is backwards compatibility really needed? I don;t think fake players are being that extensively used.

Just an error when specifying FakeClient would be fine as well, but I think we should at least make it clear that FakeClient is no longer supported if you're trying to build using FakeClient. Without that, building a FakeClient will use the fall-through build option, and it won't be obvious that it did not build the expected assembly. We can remove the error/warning for FakeClient in a following release

Yeah I guess lets make it an error.

Incremented the RequireSetup number as well, the changes to the Build script will need to be rebuilt after pulling


[db engine] Add support for Elasticsearch

CATEGORY
Choose one

[ ] Bug Fix
[X] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Add support for Elasticsearch. Includes a specific engine spec, most work done upstream on elasticsearch-dbapi (https://github.com/preset-io/elasticsearch-dbapi) that implements a PEP-249 DBAPI and SQLAlchemy dialect that "queries" X-Pack SQL (Limited to no support for opendistro yet)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Example Dashboard:

SQLLab:

TEST PLAN

ADDITIONAL INFORMATION

[X] Has associated issue: #5984
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[X] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Wondering if anyone managed to get this working with opendistro?
https://github.com/preset-io/elasticsearch-dbapi/issues/31


Fix ExecuteMainCommand member offset

I don't know what other functions have shifted around, 189 clearly seemed to be an inventory function, but I am not entirely certain what 188 is doing, so I didn't adjust any others.


Stage to stage dependencies output fails

The interface
"dependencies": {
  "<STAGE_NAME>" : {
    "result": "Succeeded|SucceededWithIssues|Skipped|Failed|Canceled",
    "outputs": {
        "jobName.stepName.variableName": "value"
    }
  },
  "...": {
    // another stage
  }
}

presented for stage to stage dependencies is incorrect.
This pipeline
trigger:
- master

stages:
- stage: S0
  jobs:
  - job: J0
    pool:
      vmImage: ubuntu-latest
    steps:
    - bash: echo '##vso[task.setvariable variable=crosser;isOutput=true]'true
      name: output
- stage: S1
  variables:
    rtStage: $[dependencies.S0.outputs['J0.output.crosser']]
  jobs:
  - job: J0
    pool:
      vmImage: ubuntu-latest
    steps:
    - bash: |
        echo output'
        'variable rtStage $(rtStage)'
        'environment rtStage $RTSTAGE
      name: jobAcrossStages

outputs nothing for the variables.
Pipeline run log
Variable expansion
Job preparation parameters
Variables:
  rtStage:
    Parsing expression: <dependencies.S0.outputs['J0.output.crosser']>
    Evaluating: dependencies['S0']['outputs']['J0.output.crosser']
    Expanded: Null
    Result: ''

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77c58a78-a567-e99a-9eb7-62dddd1b90b6
Version Independent ID: 680a79bc-11de-39fc-43e3-e07dc762db18
Content: Expressions - Azure Pipelines
Content Source: docs/pipelines/process/expressions.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

For us we would like to read out the result of a stage to store it into a state store. Currently we are not able to read out the stage results, we are only able to read out job results.
The following variable mounts:
variables:
      Result1: $[stageDependencies.mystage.result]
      Result2: $[stageDependencies.mystage.myjob.result]
      Result3: $[dependencies.mystage.result]

yield:
<null>
Succeeded
<null>

$(rtStage)

Thinking about this a bit more, I think a missed a subtlety of macro expansion.
Macro expansion gets

processed before a task executes during runtime

by replacing

the expression with the contents of the variable

its literal text I'm guessing.
In that case, at execution the pipeline replaces $(rtStage) & evaluates
    steps:
    - bash: |
        echo output'
        'variable rtStage $[dependencies.S0.outputs['J0.output.crosser']]'
        'environment rtStage $RTSTAGE
      name: jobAcrossStages

a job to job dependency across stages, which requires a different expression: no wonder it fails!
In that's so, perhaps Microsoft could clarify the variable documentation, because I didn't exactly get why we had 2 runtime syntaxes ($() and $[]) until now.
Though this table might seem to say it, setting a clear distinction between

macro: expression/text expansion
runtime expression: expression execution

would send it home for me.

Thanks for the feedback. I'm updating the example to make it clearer.


Populate the Base workspace object with template information at creation time, to hold version data

The Base workspace template is defined by a JSON object. This needs to be extended to hold information about all the workspace services and their user resources, specifically to list which versions are available to the workspace.
Something like this, though the details are up for grabs:
{
  "Guacamole": {
      "versions": [
        { "1.0.0": False },
        { "1.2.0": True },
        { "2.0.0": False },
      ],
      "user-resources": {
        "Guacamole Linux VM": {
            "versions": [
              { "2.0.2": True },
              { "2.1.0": True }
            ]
        },
        "Guacamole Windows VM": {
        }
    }
  ...
}

The essential points are:

have the list of workspace services
for each service, list the versions
for each service, list the child resources (user-resources) recursively

For child resources, there are no sub-children, so the structure could be simplified by not having the "versions" key, and lifting the list of versions up a level.
The "versions" sub-structure should have entries in order. String-sorting may not work, since the version number has MAJOR.MINOR.PATCH structure.
The information to fill this structure comes from the list of registered templates in CosmosDB.

N.B., eventually, we will need two boolean flags per version, one for the TRE Admin and one for the Workspace Admin. The Workspace Admin will be able to change their flag only if the TRE Admin has enabled that version for a workspace (see the Service Catalogue slide deck we discussed recently).
This suggests that the version array should look something like this, instead:
      "versions": [
        { "1.0.0": [ False, False ] },
        { "1.2.0": [ True, True ] },
        { "2.0.0": [ True, False ] },
      ],

where, for example, the TRE Admin manipulates the first element, and the Workspace Admin manipulates the second element. So in this example, version 1.0.0 is disabled, and only the TRE Admin can enable it. Version 1.2.0 is enabled, and either role can enable/disable it. Version 2.0.0 is allowed by the TRE Admin, but the Workspace Admin has not enabled it for their project.

To clarify from the Show & Tell, I envision this object being built in the workspace CosmosDB entry when the workspace is created, by trawling the list of ResourceTemplates that are available from CosmosDB.
The object should be updated (refreshed) with new versions when the TRE Admin goes into the Configuration tab to configure the set of versions available for each workspace. That's covered in #191, and doesn't need to be done yet.
The workflow we discussed, as I understand it, and I'm happy to be corrected, would look like this:

Monday: TRE Admin creates Workspace_A. Versions object in workspace object is populated with existing resource templates at that time. So, for example, this includes AzureML version 1.0.0.
Tuesday: TRE Admin creates new version of a template, e.g. AzureML template version 2.0.0. No workspace objects are updated at this point.
Wednesday: Workspace_A Admin comes along and deploys AzureML. They only have version 1.0.0 available to them.
Thursday: TRE Admin goes into Workspace_A and opens the Configuration tab. At that point, the ResourceTemplate list is scanned again, and is merged into the workspace. AzureML 2.0.0 then shows up, disabled by default. The TRE Admin can enable it, and save the configuration.
Friday: Workspace_A Admin comes along and deploys another AzureML (maybe they now have two, maybe they deleted the first one, no matter). This time, they get version 2.0.0 by default (latest active version in their workspace).

Future enhancements will allow them to choose between version 1.0.0 and 2.0.0 if both are still enabled, but for now, it's enough to deploy the latest active version.
Another possible enhancement is for when we start to allow the Workspace Admin to control versions themselves, and that's to do the object refresh when the Workspace Admin goes into the Configuration tab. That's out of scope for this epic, we're only working with the TRE Admin access.

MR
https://github.com/Barts-Life-Science/AzureTRE/pull/new/feature/template_version_number_misc
USAGE

run script
create object in cosmosDB
edit object with script output