ChromaDB 0.4+ is no longer compatible with client config

System Info

Python 3.9.13

langchain-0.0.235-py3-none-any.whl

chromadb-0.4.0-py3-none-any.whl

Who can help?
No response
Information

[ ] The official example notebooks/scripts
[x] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
Steps to reproduce:

Create a Chroma store which is locally persisted

store = Chroma.from_texts(
    texts=docs, embedding=embeddings, metadatas=metadatas, persist_directory=environ["DB_DIR"]
)

Get the error You are using a deprecated configuration of Chroma. Please pip install chroma-migrate and run chroma-migrate to upgrade your configuration. See https://docs.trychroma.com/migration for more information or join our discord at https://discord.gg/8g5FESbj for help!
Suffer

Expected behavior

Create locally persisted Chroma store
Use Chroma store

The issue:
Starting chromadb 0.40 the chroma_db_impl is no longer a supported parameter, it uses sqlite instead.
Removing the line
chroma_db_impl="duckdb+parquet",
from langchain.vectorstores/chroma.py solves the issue, but the earlier DB cannot be used or migrated.

Thanks for helping me solve this problem

Thanks for taking quick action on this issue.
I was trying to figure out how to use the Chroma class with this new update, and found out that this code works:
import chromadb
from langchain.embeddings.sentence_transformer import SentenceTransformerEmbeddings
from langchain.vectorstores import Chroma

client = chromadb.PersistentClient(path="./db")
embeddings = SentenceTransformerEmbeddings(
    model_name="all-mpnet-base-v2",
)
vector_db = Chroma(
    client=client,
    collection_name="your-collection-name",
    embedding_function=embeddings,
)
print(f"Documents Loaded: {vector_db._collection.count()}")

Sharing in case someone else needs it.

Thanks for taking quick action on this issue.
I was trying to figure out how to use the Chroma class with this new update, and found out that this code works:
import chromadb
from langchain.embeddings.sentence_transformer import SentenceTransformerEmbeddings
from langchain.vectorstores import Chroma

client = chromadb.PersistentClient(path="./db")
embeddings = SentenceTransformerEmbeddings(
    model_name="all-mpnet-base-v2",
)
vector_db = Chroma(
    client=client,
    collection_name="your-collection-name",
    embedding_function=embeddings,
)
print(f"Documents Loaded: {vector_db._collection.count()}")

Sharing in case someone else needs it.

Hi @kevinknights29,
But how can I instead save embeddings and docs into into? Before v0.4.x I adopted the following two lines:
``
import chromadb
from langchain.vectorstores import Chroma
from langchain.embeddings.openai import OpenAIEmbeddings
embeddings = OpenAIEmbeddings(openai_api_key = key)
client = chromadb.PersistentClient(path="db_metadata_v5")
vector_db = Chroma(
client=client,
embedding_function=embeddings,
)
Create a vector database and store the chunks with embeddings
vector_db = Chroma.from_documents(documents=chunks, embedding=embeddings, persist_directory=output_dir) vector_db.persist()``
But now, according to this, the function is no longer supported.

db = vector_db.from_documents(documents=chunks, embedding=embeddings, persist_directory=output_dir)

Eh, but it still does not work. I get TypeError: 'NoneType' object is not iterable .

 I also meet this problem， so I can only installed the older version(chromadb==0.3.21) to solve that.
---Original---
From: "Andrey E. @.>
Date: Wed, Jul 19, 2023 23:29 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [hwchase17/langchain] ChromaDB 0.4+ is no longer compatible withclient config (Issue #7887)
db = vector_db.from_documents(documents=chunks, embedding=embeddings, persist_directory=output_dir)
Eh, but it still does not work. I get TypeError: 'NoneType' object is not iterable .
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Thanks for taking quick action on this issue.
I was trying to figure out how to use the Chroma class with this new update, and found out that this code works:
import chromadb
from langchain.embeddings.sentence_transformer import SentenceTransformerEmbeddings
from langchain.vectorstores import Chroma

client = chromadb.PersistentClient(path="./db")
embeddings = SentenceTransformerEmbeddings(
    model_name="all-mpnet-base-v2",
)
vector_db = Chroma(
    client=client,
    collection_name="your-collection-name",
    embedding_function=embeddings,
)
print(f"Documents Loaded: {vector_db._collection.count()}")

Sharing in case someone else needs it.

Hi @kevinknights29,
But how can I instead save embeddings and docs into into? Intuitively, I would use the following code:
import chromadb
from langchain.vectorstores import Chroma
from langchain.embeddings.openai import OpenAIEmbeddings
embeddings = OpenAIEmbeddings(openai_api_key = key)

client = chromadb.PersistentClient(path="db_metadata_v5")
vector_db = Chroma(
    client=client,
    embedding_function=embeddings,
)
vector_db = Chroma.from_documents(documents=chunks, embedding=embeddings, persist_directory=output_dir)
vector_db.persist()

But now, according to this, the function is no longer supported. So the final two lines throw an error, and indeed, I have "TypeError: 'NoneType' object is not iterable". Have you found a solution to this as well?

Based on: https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/chroma.py
You could:
import chromadb
from langchain.vectorstores import Chroma
from langchain.embeddings.openai import OpenAIEmbeddings
embeddings = OpenAIEmbeddings(openai_api_key = key)

client = chromadb.PersistentClient(path="db_metadata_v5")
vector_db = Chroma.from_documents(
     client=client,
     documents=chunks,
     embedding=embeddings,
     persist_directory=output_dir
)
vector_db.persist()

This is possible because the from_documents method has a client argument.
Could you give I try? I don't see why it wouldn't work.

Hi everyone, https://github.com/hwchase17/langchain/releases/tag/v0.0.236 was just released this morning and is backwards compatible. @kevinknights29 @Maipengfei  please upgrade and if you have any issues, please ask in our discord - https://discord.gg/MMeYNTmh3x - we are responding very quickly right now!

@jeffchuber, Thanks for the heads-up!

@jeffchuber, thank you a lot!

Hey @kevinknights29, this is just to notify you that in the end the issue has been fixed! The below code suffices, as it is backwards compatible as stated by @jeffchuber.
output_dir = "./db_metadata_v5"
db = Chroma.from_documents(chunks, embeddings, persist_directory=output_dir)

I believe that the issue can now finally be closed.
Note: I am on chromadb v0.4.2 and langchain v0.0.237.

@aevedis
I may have made something wrong, but it still displayed the same error as following:

/usr/local/lib/python3.10/dist-packages/chromadb/config.py in getitem(self, key)
108         # Error on legacy config values
109         if val in _legacy_config_values:
--> 110             raise ValueError(LEGACY_ERROR)
111         return val
112
ValueError: You are using a deprecated configuration of Chroma.

The versions of chromadb and langchain in my environment are as following:

Name: langchain
Version: 0.0.238
Name: chromadb
Version: 0.4.2

And my code is (simply)
`from langchain.vectorstores import Chroma
output_dir = "./db_metadata_v5"
db = Chroma.from_documents(law_docs, embedding_function, persist_directory=output_dir)`
Do you have any ideas? Thanks!

@vincentwang79 this worked for me... https://gist.github.com/jeffchuber/a9ebc0ad5c7b053b8d1c50449c07f893
chroma==0.4.2
langchain==0.0.237

@vincentwang79 this worked for me... https://gist.github.com/jeffchuber/a9ebc0ad5c7b053b8d1c50449c07f893
chroma==0.4.2 langchain==0.0.237

Yes, your code also works in my environment. I must have got something wrong. Thanks!

persist_dir = '/home/ubuntu/libraryEmbeddings/'
persist_dir = os.path.join(persist_dir, filename)
vectordb = Chroma.from_documents(documents=manualData, embedding=embedd>
vectordb.persist()
before  I was using the above way to store embeddings. After reinstalling chromadb. Now facing issue of depreciated configuration of chroma. how can I resolve this.

Hey everyone,
I guess this will help https://docs.trychroma.com/migration
Check out the end of this page, you'll find the reason for the error here.

@abdullah-028, just try: https://gist.github.com/jeffchuber/a9ebc0ad5c7b053b8d1c50449c07f893. I should be fine.
Only make sure to be on Chroma 0.4.2 and Langchain 0.0.237.

It is working for me with: chromadb 0.4.2 and langchain 0.0.237

I believe this issue should be resolved.

How to save and load chromadb using langchain ?

@kesavan1994 you can pass a chroma client to langchain Chroma init
import chromadb
client = chromadb. PersistentClient(path='./db')
langchain_chroma = Chroma(client=client, collection_name='langchain_collection')

You can set path and collection_name to be whatever you like.
Does this answer your question?

It is working for me with: chromadb 0.4.4 and langchain 0.0.249

@vdedourek2
How did you solve the problem? Can you please at least quote which one's solution works for you?
Or, can you please post your solution again directly?
Thank you ...

chromadb 0.4.4
langchain 0.0.249

This is what works for me
import chromadb
from chromadb.config import Settings

path='./db'
settings = Settings(
        persist_directory=path,
        anonymized_telemetry=False
)

client = chromadb.PersistentClient(settings=settings , path=path)

Create new db
db = Chroma.from_documents(
                    client=client,
                    documents=texts,
                    embedding=embeddings,
                )

Read existing db
db = Chroma(
              client=client,
              embedding_function=embeddings,
          )
db.add_documents(texts)

Retriever from existing db
db = Chroma(
            persist_directory=path,
            embedding_function=embeddings,
            client_settings=settings ,
        )
        retriever = db.as_retriever( ... )

@victorlee0505
Thank you so much.... It's working now...  ^_^
PrivateGPT's ingest.py .
I blieve you should be able provide a pull request over there. At least one more file to be modified: privateGPT.py accordingly...
Thanks...

thank you @victorlee0505 !

This seems to have been an error with migration. Such an error occurs in the case where you have some data that you were using with an older version of chromaDB and then you have updated the version.
So basically, now it's asking you to migrate the data to the newer version.
For an immediate fix, you can try changing the path of the persistent storage for the vector database and give it a try.
Maybe try this:
`import chromadb
from chromadb.config import Settings
client = chromadb.PersistentClient(path="/new_path", settings = Settings(allow_reset=True)`
Here note that I have mentioned the new_path which is essentially different from the old path.

@jimysancho
this is my setting
client = chromadb.PersistentClient(settings=CHROMA_SETTINGS_HF, path=persist_directory)

from chromadb.config import Settings
PERSIST_DIRECTORY_HF = './storage_hf'

CHROMA_SETTINGS_HF = Settings(
        # chroma_db_impl='duckdb+parquet',
        persist_directory=PERSIST_DIRECTORY_HF,
        anonymized_telemetry=False
)

so my guess of ValueError: You are using a deprecated configuration of Chroma.
I have commented # chroma_db_impl='duckdb+parquet' in my setting which is deprecated.

Gentleman,
Oct 24:
based on conversation here. I'm guessing this is the correct way?
from chromadb.config import Settings
persist_directory = 'docs/chroma/'
path=persist_directory
settings = Settings(
persist_directory=path,
anonymized_telemetry=False
)
client = chromadb.PersistentClient(settings=settings , path=path)
#client = chromadb.PersistentClient(path=persist_directory, settings = Settings(allow_reset=True))
but making a client gives an error:

AttributeError: type object 'hnswlib.Index' has no attribute 'file_handle_count'
Where do I go from here?

Also, for those coming from deeplearning.ai and trying to run the syntax in their juputerworkbook, you might as a workaround for now until this is fixed downgrade chroma until langchain supports 0.4+
#pip install chromadb==0.3.29 only works in this version

@lszyba1 langchain does not support 0.4 chroma? can you provide more info/repro? this is concerning

Hello Jeff
When you watch and download the jupyter notebook for deeplearning.ai short course:
https://www.deeplearning.ai/short-courses/langchain-chat-with-your-data/
In section 03 they have following code. When trying to replicate that code on your own computer I'm getting first the "deprecated warning on syntax for chroma", based on comment above, I'm guessing the correct syntax, which then leads to hnswlib.index error.
The syntax in question:

@lszyba1 perhaps you can help me diagnose more? i ran the notebook here - https://learn.deeplearning.ai/langchain-chat-with-your-data/lesson/4/vectorstores-and-embedding- and it looks like it ran ok? thanks!

Hello
Thanks.
Yes. it does work there. Looks like they pinned their environment to certain version of software.
Now copy/download the notebook onto your computer.
Debian Linux 11.
setup a new environment
virtualenv -p python3 env_py3
source env_py3/bin/activate
pip install jupyterlab
pip install panel
pip install python-dotenv
pip install langchain[all]
pip install chromadb
pip install lxml
open the notebook and try to run the "75" from your screenshot (you will need openai key, + few of prior lines) .
by default chromadb will be 0.4+ so that line will fail that you are using depreciated configuration options.
....then you will try to figure what the correct syntax is...when you do then you get hnswlib attribute error inside chroma.
and that is where I'm at.

@lszyba1 very strange. I pulled down the notebook locally and pip install chromadb in the notebook, and confirmed it's using 0.4.15. It seemed to run with no issues.
Can you provide more info on the failure? sorry about the trouble

That is weird...here is a test.py file that we can be on a same page.
machinelearning-lecture01.pdf
test.py
import openai
import sys
sys.path.append('../..')

from dotenv import load_dotenv, find_dotenv
_ = load_dotenv(find_dotenv()) # read local .env file

openai.api_key  = os.environ['OPENAI_API_KEY']

from langchain.document_loaders import PyPDFLoader

# Load PDF
loaders = [
    # Duplicate documents on purpose - messy data
    PyPDFLoader("machinelearning-lecture01.pdf")
]
docs = []
for loader in loaders:
    docs.extend(loader.load())

# Split
from langchain.text_splitter import RecursiveCharacterTextSplitter
text_splitter = RecursiveCharacterTextSplitter(
    chunk_size = 1500,
    chunk_overlap = 150
)

splits = text_splitter.split_documents(docs)

len(splits)

from langchain.embeddings.openai import OpenAIEmbeddings
embedding = OpenAIEmbeddings()

from langchain.vectorstores import Chroma

persist_directory = 'docs/chroma/'

#sentence3 = "the weather is awsome outside"
#embedding.embed_query(sentence3)

vectordb = Chroma.from_documents(
    documents=splits,
    embedding=embedding,
    persist_directory=persist_directory
)

vectordb.persist()

@lszyba1 let's try on a minimal example... this could be a version issue with python on your computer (very common!)
import langchain
import chromadb
print(langchain.__version__)
print(chromadb.__version__)

#0.0.324
#0.4.15

import os
import getpass

os.environ['OPENAI_API_KEY'] = "<key>"

from langchain.document_loaders import TextLoader
from langchain.embeddings.openai import OpenAIEmbeddings
from langchain.text_splitter import CharacterTextSplitter
from langchain.vectorstores import Chroma

# Load the document, split it into chunks, embed each chunk and load it into the vector store.
raw_documents = TextLoader('sotu.txt').load()
text_splitter = CharacterTextSplitter(chunk_size=1000, chunk_overlap=0)
documents = text_splitter.split_documents(raw_documents)

db = Chroma.from_documents(documents, OpenAIEmbeddings())

query = "What did the president say about Ketanji Brown Jackson"
docs = db.similarity_search(query)
print(docs[0].page_content)

sotu.txt
Madam Speaker, Madam Vice President, our First Lady and Second Gentleman. Members of Congress and the Cabinet. Justices of the Supreme Court. My fellow Americans.

Last year COVID-19 kept us apart. This year we are finally together again.

Tonight, we meet as Democrats Republicans and Independents. But most importantly as Americans.

With a duty to one another to the American people to the Constitution.

And with an unwavering resolve that freedom will always triumph over tyranny.

Six days ago, Russia’s Vladimir Putin sought to shake the foundations of the free world thinking he could make it bend to his menacing ways. But he badly miscalculated.

He thought he could roll into Ukraine and the world would roll over. Instead he met a wall of strength he never imagined.

He met the Ukrainian people.

From President Zelenskyy to every Ukrainian, their fearlessness, their courage, their determination, inspires the world.

Groups of citizens blocking tanks with their bodies. Everyone from students to retirees teachers turned soldiers defending their homeland.

In this struggle as President Zelenskyy said in his speech to the European Parliament “Light will win over darkness.” The Ukrainian Ambassador to the United States is here tonight.

Let each of us here tonight in this Chamber send an unmistakable signal to Ukraine and to the world.

Please rise if you are able and show that, Yes, we the United States of America stand with the Ukrainian people.

Throughout our history we’ve learned this lesson when dictators do not pay a price for their aggression they cause more chaos.

They keep moving.

And the costs and the threats to America and the world keep rising.

That’s why the NATO Alliance was created to secure peace and stability in Europe after World War 2.

The United States is a member along with 29 other nations.

It matters. American diplomacy matters. American resolve matters.

Putin’s latest attack on Ukraine was premeditated and unprovoked.

He rejected repeated efforts at diplomacy.

He thought the West and NATO wouldn’t respond. And he thought he could divide us at home. Putin was wrong. We were ready.  Here is what we did.

We prepared extensively and carefully.

We spent months building a coalition of other freedom-loving nations from Europe and the Americas to Asia and Africa to confront Putin.

I spent countless hours unifying our European allies. We shared with the world in advance what we knew Putin was planning and precisely how he would try to falsely justify his aggression.

We countered Russia’s lies with truth.

And now that he has acted the free world is holding him accountable.

Along with twenty-seven members of the European Union including France, Germany, Italy, as well as countries like the United Kingdom, Canada, Japan, Korea, Australia, New Zealand, and many others, even Switzerland.

We are inflicting pain on Russia and supporting the people of Ukraine. Putin is now isolated from the world more than ever.

Together with our allies –we are right now enforcing powerful economic sanctions.

We are cutting off Russia’s largest banks from the international financial system.

Preventing Russia’s central bank from defending the Russian Ruble making Putin’s $630 Billion “war fund” worthless.

We are choking off Russia’s access to technology that will sap its economic strength and weaken its military for years to come.

Tonight I say to the Russian oligarchs and corrupt leaders who have bilked billions of dollars off this violent regime no more.

The U.S. Department of Justice is assembling a dedicated task force to go after the crimes of Russian oligarchs.

We are joining with our European allies to find and seize your yachts your luxury apartments your private jets. We are coming for your ill-begotten gains.

And tonight I am announcing that we will join our allies in closing off American air space to all Russian flights – further isolating Russia – and adding an additional squeeze –on their economy. The Ruble has lost 30% of its value.

The Russian stock market has lost 40% of its value and trading remains suspended. Russia’s economy is reeling and Putin alone is to blame.

Together with our allies we are providing support to the Ukrainians in their fight for freedom. Military assistance. Economic assistance. Humanitarian assistance.

We are giving more than $1 Billion in direct assistance to Ukraine.

And we will continue to aid the Ukrainian people as they defend their country and to help ease their suffering.

Let me be clear, our forces are not engaged and will not engage in conflict with Russian forces in Ukraine.

Our forces are not going to Europe to fight in Ukraine, but to defend our NATO Allies – in the event that Putin decides to keep moving west.

For that purpose we’ve mobilized American ground forces, air squadrons, and ship deployments to protect NATO countries including Poland, Romania, Latvia, Lithuania, and Estonia.

As I have made crystal clear the United States and our Allies will defend every inch of territory of NATO countries with the full force of our collective power.

And we remain clear-eyed. The Ukrainians are fighting back with pure courage. But the next few days weeks, months, will be hard on them.

Putin has unleashed violence and chaos.  But while he may make gains on the battlefield – he will pay a continuing high price over the long run.

To all Americans, I will be honest with you, as I’ve always promised. A Russian dictator, invading a foreign country, has costs around the world.

And I’m taking robust action to make sure the pain of our sanctions  is targeted at Russia’s economy. And I will use every tool at our disposal to protect American businesses and consumers.

Tonight, I can announce that the United States has worked with 30 other countries to release 60 Million barrels of oil from reserves around the world.

America will lead that effort, releasing 30 Million barrels from our own Strategic Petroleum Reserve. And we stand ready to do more if necessary, unified with our allies.

These steps will help blunt gas prices here at home. And I know the news about what’s happening can seem alarming.

But I want you to know that we are going to be okay.

When the history of this era is written Putin’s war on Ukraine will have left Russia weaker and the rest of the world stronger.

While it shouldn’t have taken something so terrible for people around the world to see what’s at stake now everyone sees it clearly.

We see the unity among leaders of nations and a more unified Europe a more unified West. And we see unity among the people who are gathering in cities in large crowds around the world even in Russia to demonstrate their support for Ukraine.

In the battle between democracy and autocracy, democracies are rising to the moment, and the world is clearly choosing the side of peace and security.

This is a real test. It’s going to take time. So let us continue to draw inspiration from the iron will of the Ukrainian people.

To our fellow Ukrainian Americans who forge a deep bond that connects our two nations we stand with you.

Putin may circle Kyiv with tanks, but he will never gain the hearts and souls of the Ukrainian people.

He will never extinguish their love of freedom. He will never weaken the resolve of the free world.

We meet tonight in an America that has lived through two of the hardest years this nation has ever faced.

The pandemic has been punishing.

And so many families are living paycheck to paycheck, struggling to keep up with the rising cost of food, gas, housing, and so much more.

I understand.

I remember when my Dad had to leave our home in Scranton, Pennsylvania to find work. I grew up in a family where if the price of food went up, you felt it.

That’s why one of the first things I did as President was fight to pass the American Rescue Plan.

Because people were hurting. We needed to act, and we did.

Few pieces of legislation have done more in a critical moment in our history to lift us out of crisis.

It fueled our efforts to vaccinate the nation and combat COVID-19. It delivered immediate economic relief for tens of millions of Americans.

Helped put food on their table, keep a roof over their heads, and cut the cost of health insurance.

And as my Dad used to say, it gave people a little breathing room.

And unlike the $2 Trillion tax cut passed in the previous administration that benefitted the top 1% of Americans, the American Rescue Plan helped working people—and left no one behind.

And it worked. It created jobs. Lots of jobs.

In fact—our economy created over 6.5 Million new jobs just last year, more jobs created in one year
than ever before in the history of America.

Our economy grew at a rate of 5.7% last year, the strongest growth in nearly 40 years, the first step in bringing fundamental change to an economy that hasn’t worked for the working people of this nation for too long.

For the past 40 years we were told that if we gave tax breaks to those at the very top, the benefits would trickle down to everyone else.

But that trickle-down theory led to weaker economic growth, lower wages, bigger deficits, and the widest gap between those at the top and everyone else in nearly a century.

Vice President Harris and I ran for office with a new economic vision for America.

Invest in America. Educate Americans. Grow the workforce. Build the economy from the bottom up
and the middle out, not from the top down.

Because we know that when the middle class grows, the poor have a ladder up and the wealthy do very well.

America used to have the best roads, bridges, and airports on Earth.

Now our infrastructure is ranked 13th in the world.

We won’t be able to compete for the jobs of the 21st Century if we don’t fix that.

That’s why it was so important to pass the Bipartisan Infrastructure Law—the most sweeping investment to rebuild America in history.

This was a bipartisan effort, and I want to thank the members of both parties who worked to make it happen.

We’re done talking about infrastructure weeks.

We’re going to have an infrastructure decade.

It is going to transform America and put us on a path to win the economic competition of the 21st Century that we face with the rest of the world—particularly with China.

As I’ve told Xi Jinping, it is never a good bet to bet against the American people.

We’ll create good jobs for millions of Americans, modernizing roads, airports, ports, and waterways all across America.

And we’ll do it all to withstand the devastating effects of the climate crisis and promote environmental justice.

We’ll build a national network of 500,000 electric vehicle charging stations, begin to replace poisonous lead pipes—so every child—and every American—has clean water to drink at home and at school, provide affordable high-speed internet for every American—urban, suburban, rural, and tribal communities.

4,000 projects have already been announced.

And tonight, I’m announcing that this year we will start fixing over 65,000 miles of highway and 1,500 bridges in disrepair.

When we use taxpayer dollars to rebuild America – we are going to Buy American: buy American products to support American jobs.

The federal government spends about $600 Billion a year to keep the country safe and secure.

There’s been a law on the books for almost a century
to make sure taxpayers’ dollars support American jobs and businesses.

Every Administration says they’ll do it, but we are actually doing it.

We will buy American to make sure everything from the deck of an aircraft carrier to the steel on highway guardrails are made in America.

But to compete for the best jobs of the future, we also need to level the playing field with China and other competitors.

That’s why it is so important to pass the Bipartisan Innovation Act sitting in Congress that will make record investments in emerging technologies and American manufacturing.

Let me give you one example of why it’s so important to pass it.

If you travel 20 miles east of Columbus, Ohio, you’ll find 1,000 empty acres of land.

It won’t look like much, but if you stop and look closely, you’ll see a “Field of dreams,” the ground on which America’s future will be built.

This is where Intel, the American company that helped build Silicon Valley, is going to build its $20 billion semiconductor “mega site”.

Up to eight state-of-the-art factories in one place. 10,000 new good-paying jobs.

Some of the most sophisticated manufacturing in the world to make computer chips the size of a fingertip that power the world and our everyday lives.

Smartphones. The Internet. Technology we have yet to invent.

But that’s just the beginning.

Intel’s CEO, Pat Gelsinger, who is here tonight, told me they are ready to increase their investment from
$20 billion to $100 billion.

That would be one of the biggest investments in manufacturing in American history.

And all they’re waiting for is for you to pass this bill.

So let’s not wait any longer. Send it to my desk. I’ll sign it.

And Intel is not alone.

There’s something happening in America.

Just look around and you’ll see an amazing story.

The rebirth of the pride that comes from stamping products “Made In America.” The revitalization of American manufacturing.

Companies are choosing to build new factories here, when just a few years ago, they would have built them overseas.

That’s what is happening. Ford is investing $11 billion to build electric vehicles, creating 11,000 jobs across the country.

GM is making the largest investment in its history—$7 billion to build electric vehicles, creating 4,000 jobs in Michigan.

All told, we created 369,000 new manufacturing jobs in America just last year.

Powered by people I’ve met like JoJo Burgess, from generations of union steelworkers from Pittsburgh, who’s here with us tonight.

As Ohio Senator Sherrod Brown says, “It’s time to bury the label “Rust Belt.”

It’s time.

But with all the bright spots in our economy, record job growth and higher wages, too many families are struggling to keep up with the bills.

Inflation is robbing them of the gains they might otherwise feel.

I get it. That’s why my top priority is getting prices under control.

Look, our economy roared back faster than most predicted, but the pandemic meant that businesses had a hard time hiring enough workers to keep up production in their factories.

The pandemic also disrupted global supply chains.

When factories close, it takes longer to make goods and get them from the warehouse to the store, and prices go up.

Look at cars.

Last year, there weren’t enough semiconductors to make all the cars that people wanted to buy.

And guess what, prices of automobiles went up.

So—we have a choice.

One way to fight inflation is to drive down wages and make Americans poorer.

I have a better plan to fight inflation.

Lower your costs, not your wages.

Make more cars and semiconductors in America.

More infrastructure and innovation in America.

More goods moving faster and cheaper in America.

More jobs where you can earn a good living in America.

And instead of relying on foreign supply chains, let’s make it in America.

Economists call it “increasing the productive capacity of our economy.”

I call it building a better America.

My plan to fight inflation will lower your costs and lower the deficit.

17 Nobel laureates in economics say my plan will ease long-term inflationary pressures. Top business leaders and most Americans support my plan. And here’s the plan:

First – cut the cost of prescription drugs. Just look at insulin. One in ten Americans has diabetes. In Virginia, I met a 13-year-old boy named Joshua Davis.

He and his Dad both have Type 1 diabetes, which means they need insulin every day. Insulin costs about $10 a vial to make.

But drug companies charge families like Joshua and his Dad up to 30 times more. I spoke with Joshua’s mom.

Imagine what it’s like to look at your child who needs insulin and have no idea how you’re going to pay for it.

Joshua is here with us tonight. Yesterday was his birthday. Happy birthday, buddy.

For Joshua, and for the 200,000 other young people with Type 1 diabetes, let’s cap the cost of insulin at $35 a month so everyone can afford it.

Drug companies will still do very well. And while we’re at it let Medicare negotiate lower prices for prescription drugs, like the VA already does.

Look, the American Rescue Plan is helping millions of families on Affordable Care Act plans save $2,400 a year on their health care premiums. Let’s close the coverage gap and make those savings permanent.

Second – cut energy costs for families an average of $500 a year by combatting climate change.

Let’s provide investments and tax credits to weatherize your homes and businesses to be energy efficient and you get a tax credit; double America’s clean energy production in solar, wind, and so much more;  lower the price of electric vehicles, saving you another $80 a month because you’ll never have to pay at the gas pump again.

Third – cut the cost of child care. Many families pay up to $14,000 a year for child care per child.

Middle-class and working families shouldn’t have to pay more than 7% of their income for care of young children.

My plan will cut the cost in half for most families and help parents, including millions of women, who left the workforce during the pandemic because they couldn’t afford child care, to be able to get back to work.

My plan doesn’t stop there. It also includes home and long-term care. More affordable housing. And Pre-K for every 3- and 4-year-old.

All of these will lower costs.

And under my plan, nobody earning less than $400,000 a year will pay an additional penny in new taxes. Nobody.

The one thing all Americans agree on is that the tax system is not fair. We have to fix it.

I’m not looking to punish anyone. But let’s make sure corporations and the wealthiest Americans start paying their fair share.

Just last year, 55 Fortune 500 corporations earned $40 billion in profits and paid zero dollars in federal income tax.

That’s simply not fair. That’s why I’ve proposed a 15% minimum tax rate for corporations.

We got more than 130 countries to agree on a global minimum tax rate so companies can’t get out of paying their taxes at home by shipping jobs and factories overseas.

That’s why I’ve proposed closing loopholes so the very wealthy don’t pay a lower tax rate than a teacher or a firefighter.

So that’s my plan. It will grow the economy and lower costs for families.

So what are we waiting for? Let’s get this done. And while you’re at it, confirm my nominees to the Federal Reserve, which plays a critical role in fighting inflation.

My plan will not only lower costs to give families a fair shot, it will lower the deficit.

The previous Administration not only ballooned the deficit with tax cuts for the very wealthy and corporations, it undermined the watchdogs whose job was to keep pandemic relief funds from being wasted.

But in my administration, the watchdogs have been welcomed back.

We’re going after the criminals who stole billions in relief money meant for small businesses and millions of Americans.

And tonight, I’m announcing that the Justice Department will name a chief prosecutor for pandemic fraud.

By the end of this year, the deficit will be down to less than half what it was before I took office.

The only president ever to cut the deficit by more than one trillion dollars in a single year.

Lowering your costs also means demanding more competition.

I’m a capitalist, but capitalism without competition isn’t capitalism.

It’s exploitation—and it drives up prices.

We see it happening with ocean carriers moving goods in and out of America.

During the pandemic, these foreign-owned companies raised prices by as much as 1,000% and made record profits.

Tonight, I’m announcing a crackdown on these companies overcharging American businesses and consumers.

And as Wall Street firms take over more nursing homes, quality in those homes has gone down and costs have gone up.

That ends on my watch.

Medicare is going to set higher standards for nursing homes and make sure your loved ones get the care they deserve and expect.

We’ll also cut costs and keep the economy going strong by giving workers a fair shot, provide more training and apprenticeships, hire them based on their skills not degrees.

Let’s pass the Paycheck Fairness Act and paid leave.

Raise the minimum wage to $15 an hour and extend the Child Tax Credit, so no one has to raise a family in poverty.

Let’s increase Pell Grants and increase our historic support of HBCUs, and invest in what Jill—our First Lady who teaches full-time—calls America’s best-kept secret: community colleges.

And let’s pass the PRO Act when a majority of workers want to form a union—they shouldn’t be stopped.

When we invest in our workers, when we build the economy from the bottom up and the middle out together, we can do something we haven’t done in a long time: build a better America.

For more than two years, COVID-19 has impacted every decision in our lives and the life of the nation.

And I know you’re tired, frustrated, and exhausted.

But I also know this.

Because of the progress we’ve made, because of your resilience and the tools we have, tonight I can say
we are moving forward safely, back to more normal routines.

We’ve reached a new moment in the fight against COVID-19, with severe cases down to a level not seen since last July.

Just a few days ago, the Centers for Disease Control and Prevention—the CDC—issued new mask guidelines.

Under these new guidelines, most Americans in most of the country can now be mask free.

And based on the projections, more of the country will reach that point across the next couple of weeks.

Thanks to the progress we have made this past year, COVID-19 need no longer control our lives.

I know some are talking about “living with COVID-19”. Tonight – I say that we will never just accept living with COVID-19.

We will continue to combat the virus as we do other diseases.

Here are four common sense steps as we move forward safely.

First, stay protected with vaccines and treatments. We know how incredibly effective vaccines are. If you’re vaccinated and boosted you have the highest degree of protection.

We will never give up on vaccinating more Americans. Now, I know parents with kids under 5 are eager to see a vaccine authorized for their children.

The scientists are working hard to get that done and we’ll be ready with plenty of vaccines when they do.

We’re also ready with anti-viral treatments. If you get COVID-19, the Pfizer pill reduces your chances of ending up in the hospital by 90%.

We’ve ordered more of these pills than anyone in the world. And Pfizer is working overtime to get us 1 Million pills this month and more than double that next month.

And we’re launching the “Test to Treat” initiative so people can get tested at a pharmacy, and if they’re positive, receive antiviral pills on the spot at no cost.

If you’re immunocompromised or have some other vulnerability, we have treatments and free high-quality masks.

We’re leaving no one behind or ignoring anyone’s needs as we move forward.

And on testing, we have made hundreds of millions of tests available for you to order for free.

Even if you already ordered free tests tonight, I am announcing that you can order more from covidtests.gov starting next week.

Second – we must prepare for new variants. Over the past year, we’ve gotten much better at detecting new variants.

If necessary, we’ll be able to deploy new vaccines within 100 days instead of many more months or years.

And, if Congress provides the funds we need, we’ll have new stockpiles of tests, masks, and pills ready if needed.

I cannot promise a new variant won’t come. But I can promise you we’ll do everything within our power to be ready if it does.

Third – we can end the shutdown of schools and businesses. We have the tools we need.

It’s time for Americans to get back to work and fill our great downtowns again.  People working from home can feel safe to begin to return to the office.

We’re doing that here in the federal government. The vast majority of federal workers will once again work in person.

Our schools are open. Let’s keep it that way. Our kids need to be in school.

And with 75% of adult Americans fully vaccinated and hospitalizations down by 77%, most Americans can remove their masks, return to work, stay in the classroom, and move forward safely.

We achieved this because we provided free vaccines, treatments, tests, and masks.

Of course, continuing this costs money.

I will soon send Congress a request.

The vast majority of Americans have used these tools and may want to again, so I expect Congress to pass it quickly.

Fourth, we will continue vaccinating the world.

We’ve sent 475 Million vaccine doses to 112 countries, more than any other nation.

And we won’t stop.

We have lost so much to COVID-19. Time with one another.

Let’s use this moment to reset. Let’s stop looking at COVID-19 as a partisan dividing line and see it for what it is: A God-awful disease.

Let’s stop seeing each other as enemies, and start seeing each other for who we really are: Fellow Americans.

We can’t change how divided we’ve been. But we can change how we move forward—on COVID-19 and other issues we must face together.

I recently visited the New York City Police Department days after the funerals of Officer Wilbert Mora and his partner, Officer Jason Rivera.

Officer Mora was 27 years old.

Officer Rivera was 22.

Both Dominican Americans who’d grown up on the same streets they later chose to patrol as police officers.

I spoke with their families and told them that we are forever in debt for their sacrifice, and we will carry on their mission to restore the trust and safety every community deserves.

I’ve worked on these issues a long time.

I know what works: Investing in crime prevention and community police officers who’ll walk the beat, who’ll know the neighborhood, and who can restore trust and safety.

So let’s not abandon our streets. Or choose between safety and equal justice.

Let’s come together to protect our communities, restore trust, and hold law enforcement accountable.

That’s why the Justice Department required body cameras, banned chokeholds, and restricted no-knock warrants for its officers.

That’s why the American Rescue Plan provided $350 Billion that cities, states, and counties can use to hire more police and invest in proven strategies like community violence interruption—trusted messengers breaking the cycle of violence and trauma and giving young people hope.

We should all agree: The answer is not to Defund the police. The answer is to FUND the police with the resources and training they need to protect our communities.

I ask Democrats and Republicans alike: Pass my budget and keep our neighborhoods safe.

And I will keep doing everything in my power to crack down on gun trafficking and ghost guns you can buy online and make at home—they have no serial numbers and can’t be traced.

And I ask Congress to pass proven measures to reduce gun violence. Pass universal background checks. Why should anyone on a terrorist list be able to purchase a weapon?

Ban assault weapons and high-capacity magazines.

Repeal the liability shield that makes gun manufacturers the only industry in America that can’t be sued.

These laws don’t infringe on the Second Amendment. They save lives.

The most fundamental right in America is the right to vote – and to have it counted. And it’s under assault.

In state after state, new laws have been passed, not only to suppress the vote, but to subvert entire elections.

We cannot let this happen.

Tonight. I call on the Senate to: Pass the Freedom to Vote Act. Pass the John Lewis Voting Rights Act. And while you’re at it, pass the Disclose Act so Americans can know who is funding our elections.

Tonight, I’d like to honor someone who has dedicated his life to serve this country: Justice Stephen Breyer—an Army veteran, Constitutional scholar, and retiring Justice of the United States Supreme Court. Justice Breyer, thank you for your service.

One of the most serious constitutional responsibilities a President has is nominating someone to serve on the United States Supreme Court.

And I did that 4 days ago, when I nominated Circuit Court of Appeals Judge Ketanji Brown Jackson. One of our nation’s top legal minds, who will continue Justice Breyer’s legacy of excellence.

A former top litigator in private practice. A former federal public defender. And from a family of public school educators and police officers. A consensus builder. Since she’s been nominated, she’s received a broad range of support—from the Fraternal Order of Police to former judges appointed by Democrats and Republicans.

And if we are to advance liberty and justice, we need to secure the Border and fix the immigration system.

We can do both. At our border, we’ve installed new technology like cutting-edge scanners to better detect drug smuggling.

We’ve set up joint patrols with Mexico and Guatemala to catch more human traffickers.

We’re putting in place dedicated immigration judges so families fleeing persecution and violence can have their cases heard faster.

We’re securing commitments and supporting partners in South and Central America to host more refugees and secure their own borders.

We can do all this while keeping lit the torch of liberty that has led generations of immigrants to this land—my forefathers and so many of yours.

Provide a pathway to citizenship for Dreamers, those on temporary status, farm workers, and essential workers.

Revise our laws so businesses have the workers they need and families don’t wait decades to reunite.

It’s not only the right thing to do—it’s the economically smart thing to do.

That’s why immigration reform is supported by everyone from labor unions to religious leaders to the U.S. Chamber of Commerce.

Let’s get it done once and for all.

Advancing liberty and justice also requires protecting the rights of women.

The constitutional right affirmed in Roe v. Wade—standing precedent for half a century—is under attack as never before.

If we want to go forward—not backward—we must protect access to health care. Preserve a woman’s right to choose. And let’s continue to advance maternal health care in America.

And for our LGBTQ+ Americans, let’s finally get the bipartisan Equality Act to my desk. The onslaught of state laws targeting transgender Americans and their families is wrong.

As I said last year, especially to our younger transgender Americans, I will always have your back as your President, so you can be yourself and reach your God-given potential.

While it often appears that we never agree, that isn’t true. I signed 80 bipartisan bills into law last year. From preventing government shutdowns to protecting Asian-Americans from still-too-common hate crimes to reforming military justice.

And soon, we’ll strengthen the Violence Against Women Act that I first wrote three decades ago. It is important for us to show the nation that we can come together and do big things.

So tonight I’m offering a Unity Agenda for the Nation. Four big things we can do together.

First, beat the opioid epidemic.

There is so much we can do. Increase funding for prevention, treatment, harm reduction, and recovery.

Get rid of outdated rules that stop doctors from prescribing treatments. And stop the flow of illicit drugs by working with state and local law enforcement to go after traffickers.

If you’re suffering from addiction, know you are not alone. I believe in recovery, and I celebrate the 23 million Americans in recovery.

Second, let’s take on mental health. Especially among our children, whose lives and education have been turned upside down.

The American Rescue Plan gave schools money to hire teachers and help students make up for lost learning.

I urge every parent to make sure your school does just that. And we can all play a part—sign up to be a tutor or a mentor.

Children were also struggling before the pandemic. Bullying, violence, trauma, and the harms of social media.

As Frances Haugen, who is here with us tonight, has shown, we must hold social media platforms accountable for the national experiment they’re conducting on our children for profit.

It’s time to strengthen privacy protections, ban targeted advertising to children, demand tech companies stop collecting personal data on our children.

 More people they can turn to for help, and full parity between physical and mental health care.

Third, support our veterans.

Veterans are the best of us.

I’ve always believed that we have a sacred obligation to equip all those we send to war and care for them and their families when they come home.

My administration is providing assistance with job training and housing, and now helping lower-income veterans get VA care debt-free.

Our troops in Iraq and Afghanistan faced many dangers.

One was stationed at bases and breathing in toxic smoke from “burn pits” that incinerated wastes of war—medical and hazard material, jet fuel, and more.

When they came home, many of the world’s fittest and best trained warriors were never the same.

Headaches. Numbness. Dizziness.

A cancer that would put them in a flag-draped coffin.

I know.

One of those soldiers was my son Major Beau Biden.

We don’t know for sure if a burn pit was the cause of his brain cancer, or the diseases of so many of our troops.

But I’m committed to finding out everything we can.

Committed to military families like Danielle Robinson from Ohio.

The widow of Sergeant First Class Heath Robinson.

He was born a soldier. Army National Guard. Combat medic in Kosovo and Iraq.

Stationed near Baghdad, just yards from burn pits the size of football fields.

Heath’s widow Danielle is here with us tonight. They loved going to Ohio State football games. He loved building Legos with their daughter.

But cancer from prolonged exposure to burn pits ravaged Heath’s lungs and body.

Danielle says Heath was a fighter to the very end.

He didn’t know how to stop fighting, and neither did she.

Through her pain she found purpose to demand we do better.

Tonight, Danielle—we are.

The VA is pioneering new ways of linking toxic exposures to diseases, already helping more veterans get benefits.

And tonight, I’m announcing we’re expanding eligibility to veterans suffering from nine respiratory cancers.

I’m also calling on Congress: pass a law to make sure veterans devastated by toxic exposures in Iraq and Afghanistan finally get the benefits and comprehensive health care they deserve.

And fourth, let’s end cancer as we know it.

This is personal to me and Jill, to Kamala, and to so many of you.

Cancer is the #2 cause of death in America–second only to heart disease.

Last month, I announced our plan to supercharge
the Cancer Moonshot that President Obama asked me to lead six years ago.

Our goal is to cut the cancer death rate by at least 50% over the next 25 years, turn more cancers from death sentences into treatable diseases.

More support for patients and families.

To get there, I call on Congress to fund ARPA-H, the Advanced Research Projects Agency for Health.

It’s based on DARPA—the Defense Department project that led to the Internet, GPS, and so much more.

ARPA-H will have a singular purpose—to drive breakthroughs in cancer, Alzheimer’s, diabetes, and more.

A unity agenda for the nation.

We can do this.

My fellow Americans—tonight , we have gathered in a sacred space—the citadel of our democracy.

In this Capitol, generation after generation, Americans have debated great questions amid great strife, and have done great things.

We have fought for freedom, expanded liberty, defeated totalitarianism and terror.

And built the strongest, freest, and most prosperous nation the world has ever known.

Now is the hour.

Our moment of responsibility.

Our test of resolve and conscience, of history itself.

It is in this moment that our character is formed. Our purpose is found. Our future is forged.

Well I know this nation.

We will meet the test.

To protect freedom and liberty, to expand fairness and opportunity.

We will save democracy.

As hard as these times have been, I am more optimistic about America today than I have been my whole life.

Because I see the future that is within our grasp.

Because I know there is simply nothing beyond our capacity.

We are the only nation on Earth that has always turned every crisis we have faced into an opportunity.

The only nation that can be defined by a single word: possibilities.

So on this night, in our 245th year as a nation, I have come to report on the State of the Union.

And my report is this: the State of the Union is strong—because you, the American people, are strong.

We are stronger today than we were a year ago.

And we will be stronger a year from now than we are today.

Now is our moment to meet and overcome the challenges of our time.

And we will, as one people.

One America.

The United States of America.

May God bless you all. May God protect our troops.

Hello
yes, that code works.
Getting loser:
Breaking it down:
org:
splits = text_splitter.split_documents(docs)
vectordb = Chroma.from_documents(
documents=splits,
embedding=embedding,
persist_directory=persist_directory
)
yours:
documents = text_splitter.split_documents(raw_documents)
db = Chroma.from_documents(
documents,
OpenAIEmbeddings()
)
The difference is that I'm passing persistent_directory...you are not.
This does now work:
vectordb = Chroma.from_documents(
documents=splits,
embedding=embedding,
)
#vectordb.persist()
but what is the new syntax for making sure the chromadb is saved in a folder.
Per documents in langchain:
https://python.langchain.com/docs/integrations/vectorstores/chroma#basic-example-including-saving-to-disk
you do that by passing
persist_directory="./chroma_db"
which trigger original error.
And if I look at chroma docs, they use client.
Note we are importing:
from langchain.vectorstores import Chroma
Thanks
Lucas

using the same script i posted above, and adding
db = Chroma.from_documents(
    documents,
    OpenAIEmbeddings(),
    persist_directory='sotu_db' # new
    )

still executes perfectly.
here is the integration to prove that it should support this
https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/vectorstores/chroma.py
sorry im not sure what else tos ay

Thank you!!!!!!!!!!!!!!!!!!!!
Well, this was crazy ride, but the final answer is :
langchain 0.0.228
chromadb 0.4.15
has the issue with "deprecated old config"
vs
langchain 0.0.325
chromadb 0.4.15
does not have any issues.
So the issue was langchain all along even do the error is coming from chroma. I guess implementation in in 228 had the problem.
Its unclear to me why pip install langchain (maybe early in a week when I re-created virtualenv would pull 0.228 version from July instead of any of the Oct versions).
nonetheless
Thank you for the time. The imports of version lines were the most critical.  guess next time I'll start there first.
pip install langchain --upgrade
solves the issue and
vectordb = Chroma.from_documents(
    documents=splits,
    embedding=embedding,
    persist_directory="./chroma_db"
)

vectordb.persist()

now works without a problem in a same-way as deeplearning.ai tutorial.

@lszyba1 glad to hear :)

Should this ticket be closed?
Since it references the error that is now solved. Keeping it open would maybe cause additional confusion as to whether this is still active bug or just archive.
Thanks
Lucas

I am having a strange issue here.
Two environments, same langchain==0.0.327, chromadb==0.4.15.
One env works, the other fails with
ValueError: You are using a deprecated configuration of Chroma.
Script is super easy:
loader = TextLoader('text.txt')
    raw_documents = loader.load()
    text_splitter = CharacterTextSplitter(chunk_size=1000, chunk_overlap=0, separator='\n')
    documents = text_splitter.split_documents(raw_documents)
    Chroma.from_documents(documents=documents, embedding=OpenAIEmbeddings(), persist_directory="./test_chroma_db")

One fails, the other doesn't...
Any clue or where to look for?

@rtomaf, im sorry im not able to reproduce this.

Sorry, had an .env being loaded with:
chroma_db_impl='duckdb+parquet'
That made it complain


CI & CD

Add more features to automate important steps like:

[ ] Build and Deploy as npm Package
[ ] Automated Versioning
[ ] Code Coverage
[ ] Dependency Update Strategy

👍 Thanks for the feedback!

The first has been linked to github actions.
The rest has to be had a look at in the future.


Feature Request: Allow setting custom NTP servers

I prefer to keep IoT devices on a non-internet VLAN where possible.
I also run my own NTP server on the local network and communicate its address via DHCP to clients.
It would be nice to be able to configure my own NTP server either in the Settings page or have the device follow the DHCP options for NTP servers.

I'm working on this in a fork, but I'm not used to working with ArduinoIDE.
So I'm looking to incorporate this: https://github.com/ropg/ezTime#setserver-and-setinterval

Can anyone try to compile this and check if it works?
https://github.com/TheGroundZero/clockwise/commit/8a1e3f3c9b47f95e3bde1d3aa69961591d40ffe9

@TheGroundZero it was a great first attempt. It almost work at first. I made some changes in your fork I would like to push the changes and then you open a PR

@jnthas I've initiated the PR and marked it as editable by the maintainer


docs(api): Add additional docs to describe behaviour of model redeployment

What this PR does / why we need it:
This PR introduces some additional user documentation to describe the new behaviour when redeploying model versions in Merlin.
Which issue(s) this PR fixes:
None
Fixes #
Does this PR introduce a user-facing change?:
NONE

Checklist

[ ] Added unit test, integration, and/or e2e tests
[ ] Tested locally
[x] Updated documentation
[ ] Update Swagger spec if the PR introduce API changes
[ ] Regenerated Golang and Python client if the PR introduce API changes

Okay I've just addressed the comments in this PR. Thanks a lot for the reviews!


Should I need to specify an access_token for enabled: :log ?

I've created a trial Rollbar account and installed Rollbax into my application. But for development purposes I've specified enabled: :log in my config/dev.exs so that I'm not spamming my limited rollbar account while I'm adding logging procedures around my code.
However during startup it tells me to add an access token, which I don't feel is necessary because it won't be sending anything to rollbar yet.
Additionally, I'd like to keep my access_token in prod.secret.exs instead of anything I commit to my public repo, but would like the development environment to pretty much work out of the box.

@Lugghawk hey there, thanks for opening the issue!
I think you should be able to use a bogus token alongside enabled: :log, as if no requests are actually sent to Rollbar then the access token is never used. So you would have something like this in config/config.exs (or dev.exs or whatever you want to put this non-production configuration):
config :rollbax,
  enabled: :log,
  access_token: ""

and then something like this in prod.secret.exs:
config :rollbax,
  enabled: true,
  access_token: "your real access token"

Can you try something like this out and let me know if it works? :)

That worked, thanks.

No worries, glad to help :)


Devcontainer setup ad-hoc parsing fails on Rocky 8.5

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.92.0 (Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124)
OS Version: Rocky Linux 8.5

The check-requirements-linux.sh script that runs as part of a devcontainer setup wants to parse the OS version from /etc/os-release.
That file "is a newline-separated list of environment-like shell-compatible variable assignments" (see man os-relase on Linux).
The script tries to parse the value it wants here, by running:
OS_ID="$(cat /etc/os-release | grep -Eo 'ID=([^"]+)' | sed -n '1s/ID=//p')"

This looks for a key-value pair of the form ID=value and strips out the ID= part.
It assumes the pair is not of the form ID="value", which appears to be permitted by the file format, and appears in the wild in Rocky 8.5 where the relevant line reads:
ID="rocky"

In that case the grep command will fail to match the line and the value of OS_ID will be empty, resulting in a non-zero exit code of 1.
This could be fixed by changing the variable assignment to:
OS_ID=$(source /etc/os-release && echo $ID)

This will run a subshell in which the values in the file get assigned to environment variables, which removes any surrounding " marks.
Since this runs in a subshell the current shell's environment will not pick up these variables.
Steps to Reproduce:

Start a devcontainer built from Rocky 8.5.

In the issue text I link to the problematic line in HEAD on master, so the issue remains there.

Thanks for the report, feel free to send a PR.


Upstream merge request.

Upstream merge request again please. ❤

I'll get on this.

https://github.com/WaterfallMC/Waterfall/commit/91d537c7cc5dcee415855a20dd681c8b42f20e5c


Media not work!

I think I understood why some of the issues wrote that the preview was not working. It depends on the terminal. It really doesn't work in kitty. But when I run neovim in alacrity,  everything becomes working.

Why does this not work in Kitty 😔?

Because I can it in kitty and it didn't work, and when I run it in another terminal, it worked. Oh, how! Magic:)) Just information. Perhaps it depends on the settings of the terminal itself.

have you solved the problem?

adelarsq/image_preview.nvim recently started to support Kitty.

bump. I've tried this in both kitty and wezterm, not working for me in either, have tried in and out of tmux session. Catimg works outside of vim.

also tried alacritty, no dice.

i got the same issue in iTerm2.

Same issue in Wezterm 20240203-110809-5046fc22


The application displays an error message when the user does not configure any “Social Media Link” for a trainer.

Description:
The application displays an error message when the user does not configure any “Social Media Link” for a trainer.
-Env.
Device: MacBook Pro
Google Chrome Version 54.0.2840.98 (64-bit)
REPRODUCIBILITY LEVEL:
Always
STEPS:
Steps

Open the Crafter studio with the Fitness site.
On the site bar, locate the pages section.
Click on the edit button of the “Trainers“  page.
On the Trainer list, add 1 trainer with the next properties.
Trainer 1: Fill out all the Fields, but do not add any Social Media Link.
5. Click on the Save and Close Button.
Go to the page preview and check the trainers section

CURRENT RESULT:
The application displays an error message when the user does not configure any “Social Media Link” for a trainer.
https://www.screencast.com/t/bxQEvK4XyM
EXPECTED RESULT:
The application should not displays any error message when the trainers does not have any “Social Media Link” configured.

Fixed

Bug verified and closed fixed in build c557d13.


LOOCV calculation Error

In loo_shortcut(X, y) function,  acorrding to the ITSL,
mse = ((y[row] - ypred[row])  / (1 - hi))**2 should be  right

Thank you, this is for the chapter5 notebook right? Can you please reference the equation in ITSL where you see this (page number/equation number)? Its been a while since I did this, but the only equation for MSE I see in ITSL is equation 2.5 on Page 29, where the denominator is not squared.


Revert Fix due to  https://github.com/oap-project/gluten/pull/3756

Problem description
In #3756, we fix build by introducing -Wno-extra-semi-stmt and -Wno-used-but-marked-unused,  it seems https://github.com/ClickHouse/ClickHouse/pull/56853 fix that. let's revert them in the next upgrade.
System information
no
CMake log
No response

FIXED BY #3802


stuck on Arm11.bin loading

So I went through another thread that was troubleshooting this error, but I couldn't find any solutions, and I noticed it was a dated thread, so I'm hoping something new might solve this. I'm going through the guide and I can't seem to get past the browser portion where it tells me to go to http://2xrsa.hacks.guide. After typing in that URL, the screen prompts me to a page that only says "arm11.bin loading". I noticed that this particular error isn't in the troubleshooting options, so I'm hoping there are some means of troubleshooting that could help with this. Things I've troubleshot thus far:
-Verified the SD card through h2testw
-redid the steps leading up to the URL directions.
Let me know if there's anything I can provide that would assist anyone, thanks in advance!

the 2xrsa method only works on 2.1.0. Any other version won't work

Oh I gotcha, thank you! Which alternative should I be using? 3ds version is saying "11.8.0-41U"


impl StableVec, StableHashMap.... for stable-structures

impl StableVec, StableHashMap.... for stable-structures

Hey @famouscat8, thanks for filing this. A StableBTreeMap can already simular a vec or a hashmap, so I don't think we need these, at least in the foreseeable future. If you have a specific use-case, feel free to open an issue to discuss it or post on the forums.


Search Users (based on name)

Hi,
Is there some way we can search users by name (in workspace) in Person field.
Explanation:
If we have just a name of person and we have a search-bar appearing in the notion-ui. Someway we can add search user functionality in the API. (Search-user-by-name)
something like
def get_user_by_name(user_name):
    ...
    return possible_matched_users(User_Obj or User_Id/s)

@liaq192  I couldn't find anything in the codebase. Closest thing was getting this:
client = NotionClient(token_v2="blah")
client.current_space.users
# retuns just me
# [<User (id='....', email='....', full_name='....')>]

Here's what I'm doing right now. Let's say your collection has a column called assigned.
assigned_users = [row.assigned for row in rows]
assigned_users = [item for sublist in assigned_users for item in sublist]
assigned_users = list(dict.fromkeys(assigned_users)) # remove duplicates
assigned_users
# returns all possible users

Caveat obviously is - if the person is an option but not previously listed, it won't show up.
Ideally, we'd have all the people listed in the collection.get_schema_properties(). Would make life easy.


⚠ Bofrost.lu has degraded performance

In 2f0bd56, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 3196 ms

Resolved: Bofrost.lu performance has improved in e752a46 after 17 minutes.


"Play All" button brings up black screen only

I met the Jan 12 deadline to update my 2 Channels, using your (then) updated software on a Windows 10 PC.  I just noticed on my Channels the "Play All" button doesn't work, but it brings up a black screen showing only the date at the top-right of the screen.  Is there an update on this? Thanks, John

What version are you using?  Look in the main.brs file at the top.

Nothing anywhere in main.brs on the version. The latest software was downloaded and installed December 15th.

You have to edit the main.brs file.  The version number is a comment at the top of the file.
If you downloaded and installed it on our about December, you're using an old version.  I suggest you download the latest beta version and try it.
Also, if you haven't already, you should set yourself up as a "watcher" of this project or "star" it to be notified when new versions are released.

Do you have an update on this?

The "Play All" button is working now. The layout is better but the text is a dark blue on my black background.
How do I change it to white?

From: rrirower @.>
Sent: Thursday, February 29, 2024 2:17 PM
To: rrirower/DP2SceneGraphWizard @.>
Cc: JLNjolo @.>; Author @.>
Subject: Re: [rrirower/DP2SceneGraphWizard] "Play All" button brings up black screen only (Issue #85)
Do you have an update on this?
—
Reply to this email directly, view it on GitHubhttps://github.com/rrirower/DP2SceneGraphWizard/issues/85#issuecomment-1971802414, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFYE36LZXLPZKSLINGWRRTYV57F5AVCNFSM6AAAAABDX4O5YKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRHAYDENBRGQ.
You are receiving this because you authored the thread.Message ID: @.***>

Please refer to the project wiki for info on how to change colors and fonts.

OK. Thank you.

I also noticed the title isn't there, and the logo image is smaller. But the overall look is much better. Good work!

It's too complicated for me.

From: rrirower @.>
Sent: Thursday, February 29, 2024 6:50 PM
To: rrirower/DP2SceneGraphWizard @.>
Cc: JLNjolo @.>; Author @.>
Subject: Re: [rrirower/DP2SceneGraphWizard] "Play All" button brings up black screen only (Issue #85)
Please refer to the project wiki for info on how to change colors and fonts.
—
Reply to this email directly, view it on GitHubhttps://github.com/rrirower/DP2SceneGraphWizard/issues/85#issuecomment-1972165517, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFYE37R5IPS6WFILAH4T4TYV67GFAVCNFSM6AAAAABDX4O5YKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGE3DKNJRG4.
You are receiving this because you authored the thread.Message ID: @.***>


use relative path to find the templates

This pull request is now managed with CodeReviewHub. Refresh.

:+1: Palante!

:shipit:


Superflat World; Invalid Datapack

When attempting to load up a previously exited superflat world, the game refuses to and instead requests using safe mode due to an invalid datapack. However, when clicking the 'safe mode' mode button nothing happens. I have used no datapacks when attempting to play in a superflat world. What's even more bizarre, is that non superflat worlds load just fine.
Included Log: 2021-06-23-2.log.gz
Safe Mode:

Hi, I tested this and I couldn't get the same error. I tested superflat worlds created with vanilla & old BE - both worked correctly and loaded fine (twice) with modern BE. Probably your level.dat or fabricDynamicRegistry.dat are corrupted, can you please check them or attach them here?

This seems strangely similar to this issue https://github.com/svenhjol/Charm/issues/593#issuecomment-867221139

You are right, I have the same issue as you.

Level.dat: level.dat.zip
Fabric Registry.dat: fabricRegistry.dat.zip

Hi, I tested this and I couldn't get the same error. I tested superflat worlds created with vanilla & old BE - both worked correctly and loaded fine (twice) with modern BE. Probably your level.dat or fabricDynamicRegistry.dat are corrupted, can you please check them or attach them here?

Fabric Dynamic Registry: fabricDynamicRegistry.dat.zip
Level.dat: level.dat.zip

Your DynamicRegistry is fine, I tried to fix your level.dat, now it should probably work fine
level.dat.zip

Looks like this issue was finally located and fixed in dev code

Fixed in 0.10.3


nxstyle:  No line with check on single line comments.

I haven't really verified this thoroughly, but nxstyle appears to skeip the line with check on some or all single line comments.
Certainly, it ignores the line width check on right hand comments all or most of the time.  Those often extend will beyond the section headers.
Fixing the later would probably cause more problems than it would be worth.  We would need to consider that carefully.  Forcing all right hand commits to conform to the line width would like generate a lot of work for us and likely some discontent from contributors.
In .h files, it is not such a big issue because you can always extend the block comment with a little if need be.  But this problem also occurs in the Pre-processor Definitions,  Private Types, and Private Data sections of .c files.  We would not want to have to extend the line width of the whole C file to accomodate that.
So I think there is a issue with the current nxstyle behavior and probably issues with correcting that behavior in all cases.

For example, this long line is not detected:
/****************************************************************************
 * junk.c
 ****************************************************************************/

/* This is a very long, single line comment.  This is a very long, single line comment.  This is a very long, single line comment. */

/****************************************************************************
 * Public Functions
 ****************************************************************************/


UnboundLocalError: local variable 't' referenced before assignment

I'm using c352e87b6f39581e94ea4337853768817c22361c as the local root and attempt to use another attack fails:
> python3.10 RsaCtfTool.py --createpub -n<PHONE_NUMBER>000000127 -e 65537 > test.pub
> python3.10 RsaCtfTool.py --attack wiener --publickey test.pub
...
[*] Testing key test.pub.
[*] Performing wiener attack on test.pub.
 29%|████████████████████████████████████████▊                                                                                | 2/7 [00:00<00:00, 42366.71it/s]
[!] An exception has occurred during the attack. Please check your inputs.
[!] local variable 't' referenced before assignment
[!] Traceback (most recent call last):
  File "/Users/catap/src/RsaCtfTool/lib/rsa_attack.py", line 328, in attack_single_key
    self.priv_key, unciphered = attack_module.attack_wrapper(
  File "/Users/catap/src/RsaCtfTool/attacks/abstract_attack.py", line 44, in attack_wrapper
    return self.attack(publickeys, cipher, progress)
  File "/Users/catap/src/RsaCtfTool/attacks/single_key/wiener.py", line 37, in attack
    pq = wiener(publickey.n, publickey.e, progress)
  File "/Users/catap/src/RsaCtfTool/attacks/single_key/wiener.py", line 24, in wiener
    if (s + t) & 1 == 0:
UnboundLocalError: local variable 't' referenced before assignment

[+] Time elapsed: 0.0139 sec.
[+] Total time elapsed min,max,avg: 0.0139/0.0139/0.0139 sec.

Hi, thanks for reporting.


README file needs update.

This should ideally be done by original author(s). We need following information:

goal of the project
current state of the project
how to get this code
how to run this code
more ?

Partially done by aa55ed1fcac4026031b8bf732e071bf71d7cdafa
Maybe @dligthart can describe how to get and run the code


Updating  - with AI formats - AI label and sensitivity label

Executed build pipeline:
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/9178251034


Set up docker

User Story
As a developer
I want to set up Docker for our project
So that we can containerize our application, simplify deployment, and standardize the development environment
Definition of Done
What means that this task is done?
Acceptance Criteria
Given xxxx
When xxxx
Then xxxx

@sbhamani and @andrew-rist-tw to discuss this further


Chat template is being overwritten when the Tokenizer has a default_chat_template.

PreTrainedTokenizerBase.apply_chat_template contains the following logic:
        if chat_template is None:
            if self.chat_template is not None:
                chat_template = self.chat_template
            else:
                chat_template = self.default_chat_template

get_tokenizer currently does not respect default_chat_template and overwrites chat_template without checking if the class has a default. In my use case, I noticed that the CodeLlamaTokenizer is implemented using default_chat_template, which was being ignored.
Attempt to fix https://github.com/huggingface/alignment-handbook/pull/83

Closed by #83


Alignment of Example: HTML in readme

Alignment of example is wrong
In "Example: HTML" of readme the alignment on FF Mobile is wrong pushing the column of tuples off to the right outside the visual box presented by the UI.
Steps to reproduce (only needed for problems)
View on mobile. FWIW alignment is correct when viewed in landscape for me, only portrait mode is wrong.
Versions (only needed for problems)

Resonance:
React:
Browser:

Yeah.  I should make that demo a little nicer.  It's just using simple absolute positioning so it will spill outside the container.  I added it to show that you can animate HTML since  all the other demos are SVG stuff.  I'd like to have a few more HTML demos. PRs are welcome on this!

https://ibb.co/jS3Xpa

Fixed this example.  Thanks!


Update LATAM tail icons

Changes to be committed:
modified:   src/icons/logos/tail-LA.svg
modified:   src/icons/logos/tail-LP.svg
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #142
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
This PR updates the LATAM tail per new colors.
BEFORE:

AFTER:

Type of change:

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 4.16.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


missing launcher buttons

Describe the bug
In previous versions of jupyter-book theme we had the binder and colab launchers available
however in recent versions the launcher buttons are not available
html_theme_options = {
    "path_to_docs": "docs",
    "repository_url": "https://github.com/gdsfactory/gdsfactory",
    "repository_branch": "master",
    "launch_buttons": {
        "binderhub_url": "https://mybinder.org/v2/gh/gdsfactory/gdsfactory/HEAD",
        "notebook_interface": "jupyterlab",
    },
    "use_edit_page_button": True,
    "use_issues_button": True,
    "use_repository_button": True,
    "use_download_button": True,
}

Reproduce the bug
git clone https://github.com/gdsfactory/ubc.git
make install
cd docs
make html

List your environment
Jupyter Book      : 0.13.1
External ToC      : 0.2.4
MyST-Parser       : 0.15.2
MyST-NB           : 0.13.2
Sphinx Book Theme : 0.3.3
Jupyter-Cache     : 0.4.3
NbClient          : 0.5.13

This is still available, you just need to manually enable these buttons in the configuration. See the launch button docs for more details.


Rework the plugin entry-point API to be a well-known symbol name

The plugins' entry-point used to be a symbol which name was constructed based
on the library name but the Parameter Framework was trying to deduce it based
on how library files are usually named on Linux, i.e. prefixed with "lib", then
the soname, then ".so".
This is not always true on Linux and this is usually false on Windows.
Also, if the API of this symbol changes, there is no way to know at
compile-time.
Which is why this rework introduces a macro to be used by plugins. This macro
is the name of the entry-point symbol to be declared by plugins and will be
retrieved by the Parameter Framework.
If the plugin entry point API changes, we will change the name of the macro
(it contains a version number), which will cause the plugins to raise an error
at compile time instead of failing at runtime.
For now, we only support one API version at a time: if the API changes from V1
to V2, the plugins won't compile and the Parameter Framework won't recognize
previously-compiled plugins using V1. If we want backward-compatibility, we can
add it later by declaring both macros (V1 and V2) and trying to find the symbol
corresponding to V1 if the symbol corresponding to V2 can't be found.
The first name of the macro is: PARAMETER_FRAMEWORK_PLUGIN_ENTRYPOINT_V1
Signed-off-by: David Wagner<EMAIL_ADDRESS>

[ ]   Commit 754ad80 comments
 To prevent the rewrite of all plugins, maybe you can add an symbol alias to the old name
 No, I can't because there isn't an "old name" (cf. commit message and the changes to the "test" and "skeleton" subsystems).

This pull request is now managed with CodeReviewHub. Refresh.

@krocard Please review

nice to see the removal of SystemClass::getPluginSymbol()
:+1:

Great patch :+1: (need to fix CI though ;)

ok, discussed with you :+1:

:+1:

:shipit:


GPL-731 BUG - Lighthouse +ves on site report failing (Lims submission: ‘cherry picked yes/no’ flag)

Describe the bug
Lighthouse +ves on site report failing. Root issue is query that builds the ‘Lims submission;’ which I used as ‘cherry picked yes/no’ flag is failing  - SQL packet size limits
RT 704417
reported vai slack at 1:36pm
To Reproduce
Steps to reproduce the behaviour:

Go to page '...'
Click on button '...'
See error

Expected behaviour
What was expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Windows or Mac?
Browser Chrome, Firefox, Safari or other?
Browser version (use 'About' to look up)?

Additional context
Add any other context about the problem here.

Current state (3rd Nov @ 17:30)

Is deployed,
new report generated '201103_1711_positives_with_locations.xlsx' however
all LIMS submission' are 'No' when should be some 'Yes' values e.g. file 201103_0101_positives_with_locations.xlsx sample sample ending ......92018 was 'Yes'

Closing this as it's in the Done column


Add support for java-based configuration at SpringWebProcessingContextBuilder

Currently, SpringWebProcessingContextBuilder only allows configuring beans by means of setting the location of an XML file.
But XML configuration is now on its way to deprecation so we should allow the configuration of Spring's ApplicationContext by directly specifying beans or, ideally, @Configuration classes.

@danielfernandez
Is it still the case that this library won't recognize @Configuration classes?
I'd like to start using it with @WebMvcTest spring boot annotation, but I'm struggling to get it up and running.


Compile JDK17

Problem description
Check if RDF4J compiles on JDK17. Probably not an issue since we already compile on JDK16.
Preferred solution
Compiles without changes
Are you interested in contributing a solution yourself?
Yes
Alternatives you've considered
No response
Anything else?
No response

Also need to update maven-source-plugin to the newest version covered by that CQ.

And update the base docker image to jdk11 since jdk8 won't read the code compiled with jdk17.


Add swig as build dependency

Swig added as build dependency as mentioned here to help solving build errors. I have also fixed readme file for commands
Note: We have to check if it breaks pipelines or conda based installation.

Closed because we have migrated to setup.py


Added basic LODs

LOD UVs need to be refined.
Fan LOD needs to be added and setup.
Also added Diamond skin as opposed to titanium.
Basic Water cooler.

You can ignore changes to minimal of course

Removed printers I spawned in minimal. Adjusting LOD UVs.

Oh my bad I tought it was finished so I fixed the conflict

It should be good enough now I think. I can return it later to touch it up more.


chore: simplify logic for updating config/credentials files

This PR contains a series of commits that make simplifications to the code for updating the config/credentials files.  Should be easier to maintain as a result, as well as significantly reducing the number of copy operations that are being made when updating the files.

rebased


Template variable in JSON expects to be entire field value

The JSON template for variable detection works by check the start and end of a string for a variable.
i.e.
"foo" : "{{bar}}"
It should be possible to have the field value as a partial variable e.g:
"foo" : "My {{bar}}"

This has been fixed now.


Quality control jpeg

Maybe I missed this in the readme or examples, but I'm nit seeing a way to control the quality of jpegs encoded using this library. Is that implemented?

Encoding JPEGs is non-trivial and should be left to specialized libraries. I.e. mozjpeg. Closing for now.

:+1: thanks for the explanation and totally agree


How to create object and call the function

I can't see any output for this code I know I missing some basic steps like object creation and help on fixing this.
from pyjamas.ui.SimplePanel import SimplePanel
from pyjamas.ui.HTML import HTML

class HtmlDemo(SimplePanel):
    def __init__(self):
        SimplePanel.__init__(self)

        html = HTML("Hello, World!")
        self.add(html)

Take a look a the hello world example, maybe that helps. More examples are available through the website.


Cannot modify session expiry

It seems when using the Session with tide's session middleware, it's not possible to modify the session expiry because it is not wrapped in an Arc (I think).
This can be a somewhat tricky thing to reason with because of the session lifecycle in a request (and how it is cloned), but testing reveals that there are two things that would prevent this:

the expiry not being wrapped in Arc so the cloned session (via tide session middleware's handler) does not update the session expiry
Session::expire_in does not mark the session data_changed, so unless the check is disabled in the middleware, changes to session expiry will not cause the session to be updated by the store even it 1 is fixed

These are relatively straightforwards things to resolve, but may have some more subtle implications since it will change how sessions behave and existing code may be out there which depends on these quirks.

I think this would require a semver-breaking release of async-session, but it's been a while since there's been a tide release and tide is already out of date from async-session. Tide's current development status is described here

Definitely seems like it would warrant a semver-major release. I'm happy to make the changes for this if it's agreed upon that it's a change worth making.
After a bit deeper thinking though, I'm not sure that this would cause too many in-the-wild issues - if someone had been modifying the session expiry as of now, nothing would have been happening and they would surely take notice that their intended effect wasn't working. Still a breaking change, but the changelog notice should basically be to check that any usage of expire_in intended because it will now work.
There's unfortunately no workaround I can think of for this other than to modify the Session struct as well (barring a larger change to the tide::SessionMiddleware).

As far as larger changes: There's a larger change I've been wanting to make that removes all interior mutability from Session, but that might be a later change. The interior mutability of some of the fields (but not all of them) is a consequence of the fact that async-session was built for tide, and had to work around tide's inability to pass any owned data through the request-response cycle (since request extensions are dropped along with the request). I feel like the behavior (bug or misfeature) that this issue is about is a consequence of that design. Now that a number of other frameworks use async-session, it makes more sense to move any tide-specific workarounds into the tide middleware and out of async-session. Wrapping the entire Session in an Arc<RwLock<_>> in tide's middleware might be the simplest way to fix this (and removing the interior mutability).
Regardless of whether we treat this as a semver-patch or semver-minor release of async-session, tide would require a new release because tide's already out of date, and has been for a while.
I'll take a look at making the above changes, but my guess is that it's going to be a slow road to a new tide release. Probably the best choice for tide would be publishing a standalone middleware as an external crate that can be used instead of the built-in middleware, just like I did with driftwood as a replacement for the tide default logger.

Let me know if I can help in tackling anything on this. We're using tide so have a vested interest in seeing it's development stay active and alive (and I don't want to switch to axum...) so I'm happy to jump in and help more often with tide (and associated Fishrock/Yoshua/Jbr tide-related projects) maintenance.


Isolate the Node 10-only parts in their own directory

This allows enabling TypeScript from the outer side, so that the server scripts can be checked by it without requiring the inner side to care.

Okay, another update. Fixed all the review comments. I don't think I can fix CI, it's running that against your workflows, and thus hasn't caught onto the Dockerfile having moved to server. But the script files are now TS-strict-checked, and you can pretty much edit them using whatever version of Node you are running. Actually, I can .nvmrc pin it inside that folder now, let me do that…

Okay, updated. I kept the .nvmrc file in because I think it makes it more obvious than this is a "weird" area. I hope I got the .js->.cjs rename correct, too. I know I saw that warning a few times, but can't remember what I was doing at the time.


Remove domain extension length limit on extract() method ...

...to avoid cutting the domain extension on long generic domain names such as .photography, .club, .company, etc.
See issue #50

@jwage :smiley:

:+1: thanks!


When building Conda packages (workflows), pin the versions of the packages LUE depends on

This makes the package more likely to be usable, for a longer time. Otherwise LUE depends on the most recent versions of all packages, which may result in conflicts when LUE is used with other packages depending on older versions.

@OliverSchmitz I will set things up. If you have any tips you can dump them here.


Update the Leaderboard test

Updating the UI test for the new leaderboard.
Related to previous issue : #42  in pull request #50

This issue was added by misstake to this pull requests.


Review Korean Translation

Is this a draft?
PR closed by mistake?

Sorry, It was the PR by mistake 😅 I forgot to comment.


Enabling real-time loading of beacons

Description:
Currently, the beacons do not load in real-time, impacting the user experience. To address this, we need to implement improvements that ensure instantaneous loading of beacons for a smoother interaction.

i want to work on this issue i will create subscription for this.


Odd behavior with shaders drawing to DEPTH

Tested versions
4.3-stable
System information
Windows 11, Vulkan
Issue description
I am trying to create a shader that causes an object to only appear in the DEPTH buffer and not be visible on screen under certain conditions. However I am noticing some strange behavior.
This shader will always draw the object with a default albedo of white:
shader_type spatial;
render_mode depth_draw_always;

void fragment()
{
	DEPTH = FRAGCOORD.z;
}

This shader will only draw to the DEPTH buffer:
shader_type spatial;
render_mode depth_draw_always;

void fragment()
{
	DEPTH = 1.0;
}

However adding any write to ALPHA or ALBEDO will cause the object to appear in white again even if alpha is set to 0.0.
I am currently using a secondary pass to actually shade the object if desired but it is kinda odd that anything other than DEPTH = 1.0; will cause the object to be rendered.
Steps to reproduce
Test the provided shaders
Minimal reproduction project (MRP)
shader_type spatial;
render_mode depth_draw_always;

void fragment()
{
	DEPTH = FRAGCOORD.z;
}

shader_type spatial;
render_mode depth_draw_always;

void fragment()
{
	DEPTH = 1.0;
}

Godot doesn't have an option for only writing to depth. When you create a shader that doesn't write to ALBEDO etc. The defaults are used (e.g. white for ALBEDO).
When you set DEPTH to 1.0 you are aligning it directly with the near plane. So the pixels are getting discarded for being too close to the near plane.
Ultimately this isn't a bug, so I'm going to close this bug report. I suspect that you have an effect in mind that isn't possible with Godot right now, so I suggest thinking a bit more about what you are trying to do and what is missing in Godot for you to do it, then open a proposal that clearly describes the effect you are trying to make and what you need exposed in order to make it.

The thing is that it is in fact possible. DEPTH = 1.0 does exactly what I want it to do


control-service: question about broken test case

What
This test case makes the assertion that if the status doesn't change then the job should not be redeployed.
However that is not true. There are two versions of the methods createCronJob and updateCronJob.
We are only asserting they don't call one of them when they infact call the other.
I looked around the code and I don't see any attempt to not deploy if they value is the same.
Can someone with relevant experience please look at this and tell me how we should change this test.

Hi @murphp15,
Currently, the patch method merges fields without checking for changes, which is not accurately reflect the desired behavior of this test. I suggest deleting the test.


minor Throw error when sync analyze failed

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Fix markdown meta parsing

Fixes #12815
This code should now exclude the separator lines themselves, so as long as there are two or more hyphens it will work as a separator and also YAML won't choke.
Included a minimal test case.

Codecov Report

Merging #12817 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12817      +/-   ##
==========================================
+ Coverage   43.12%   43.17%   +0.05%
==========================================
  Files         654      654
  Lines       72194    72196       +2
==========================================
+ Hits        31131    31172      +41
+ Misses      36012    35979      -33
+ Partials     5051     5045       -6

Impacted Files
Coverage Δ

modules/markup/markdown/meta.go
91.66% <100.00%> (+91.66%)
:arrow_up:

models/issue_comment.go
53.90% <0.00%> (+0.15%)
:arrow_up:

services/pull/pull.go
42.03% <0.00%> (+0.46%)
:arrow_up:

modules/git/repo.go
49.74% <0.00%> (+0.50%)
:arrow_up:

models/error.go
35.32% <0.00%> (+0.51%)
:arrow_up:

modules/git/commit.go
55.40% <0.00%> (+0.67%)
:arrow_up:

services/pull/check.go
50.00% <0.00%> (+1.53%)
:arrow_up:

modules/git/utils.go
77.04% <0.00%> (+3.27%)
:arrow_up:

modules/indexer/stats/queue.go
76.47% <0.00%> (+11.76%)
:arrow_up:

modules/indexer/stats/db.go
60.86% <0.00%> (+17.39%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18c6cf...ee8e0a6. Read the comment docs.


Is the supported Operating System list accurate? If so, remove OS versions that are end of life.

Is the supported Operating System list on this page accurate in terms of supported versions?
Red Hat Enterprise Linux 7.3 and CentOS 7.3 are both "End of Life" and they no longer receive security updates or bug fixes.
Only currently supported operating systems by the OS vendor should be considered to be supported.
Red Hat Enterprise Linux and CentOS should be removed as being supported operating systems until the solution is supported on a newer release.
For example, I doubt that Microsoft would list the newest supported version for Windows as being Windows Server 2008 R2.
The oldest version of Red Hat Enterprise Linux that is still maintained is 7.6.
Source:  https://access.redhat.com/support/policy/updates/errata
In Red Hat Enterprise Linux 7, EUS is available for the following releases:
7.1 (ended March 31, 2017)
7.2 (ended November 30, 2017)
7.3 (ended November 30, 2018)
7.4 (ends August 31, 2019)
7.5 (ends April 30, 2020)
7.6 (ends May 31, 2021)
7.7 (ends August 30, 2021; Final RHEL 7 EUS Release)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7783cfe9-0508-9a73-3923-597cbc523cda
Version Independent ID: e2dba78f-0f1a-20d1-54d8-f30084328bb0
Content: Container Monitoring solution in Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/insights/containers.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@mikenri Thanks for the feedback! We are currently investigating and will update you shortly.

@mikenri - The article is up-to-date regarding the OS and versions that are supported.  This solution isn't receiving any further investment by the product group as AzMon for containers is the successor for monitoring containers in different Kubernetes environments.  I hope this answers your question. #please-close