migrate: 'alter' when using Waterline standalone

I got bitten by this gotcha and lost (development) data...
I and some others on gitter chat think default should be migrate: 'safe'
https://github.com/balderdashy/waterline/blob/63effdb480ae9bd61cd78fd534e1e513294bd98d/lib/waterline/collection/defaults.js

Applies to production to.
See this TODO`s:
https://github.com/balderdashy/waterline/blob/25ccb99e92ea018ca832bd4497af903c4212b34e/lib/waterline/adapter/sync/strategies/alter.js#L22
https://github.com/balderdashy/waterline/blob/25ccb99e92ea018ca832bd4497af903c4212b34e/lib/waterline/adapter/sync/strategies/drop.js#L20

Something else I'd like to add... since I'm using this separately from Sails, I will use the exact same code / setup on production...
So I think this really should not be the default...

I believe a good candidate for a default migration strategy in Waterline standalone is migrate: 'create' (#846). It's on master branch and it hasn't been released yet. 'create' has the advantage of creating tables when one first launches waterline and it never deletes any data. It will also create any missing tables/columns in subsequent initialisations. It can be seen as safeish alter migration.

I would vote for 'safe'

I'm cool with either safe or create. The tricky part is when you start with:
username: {
    type: 'string'
}

and then change it later to:
username: {
    type: 'string',
    unique: true
}

With alter it would pull the data out and make sure these indexes get built. To be honest for sql databases we switched to migrations long ago on our projects so mine is set to migrate: 'safe' from the start but I'll let you guys choose whatever works best for your use cases and we can set that as the default. Losing data is bad and if what we have now isn't working for people it's an easy change.

Regarding @robertbak's comment, I've created PR #893 which will prevent drop/alter migrations from running on production. Pretty simple changes:
  // Refuse to run this migration strategy in production.
  if (process.env.NODE_ENV === 'production'){
    return cb();
  }

I don't think we need new tests for them.
@particlebanana, that's the downside of 'create', it only performs additive changes. I do wonder if we can improve alter, maybe by delegating some of its work to the adapter?

Just to entertain the thought: does this silent loss of (dangerous) functionality warrant a breaking change or at least some sort of error for the developer?
Also @particlebanana, is there a way I'm not aware of to override the Waterline default migration strategy across all models?  Based upon what you said, it seems like there may be.  I think I heard that sails does this, but does WL itself?

@devinivy, currently it would silently prevent the migration from happening if NODE_ENV is set to 'production' without breaking any other behaviour. It's not throwing an error nor logging anything. That's actually something I'm not sure which is the best way to deal with as this code is ran for all collections, so it can potentially throw a lot of output... Throwing an error has the annoying effect of preventing the app from starting even if no changes have been done to the schema. What do you think it's the best behaviour?
Regarding your second question, you can pass a "defaults" object to waterline when you initialise it:
var options = {
  adapters: {...},
  connections: {...},

  // you can override adapter default options
  defaults: {
    migrate: 'safe',
  }
}

waterline.initialize(options, cb);

I don't think it's documented anywhere apart from adapters READMEs.

What if we instead changed the default for production to "safe"?  That seems like a way to leave the (dangerous) functionality should someone want to use it and avoid the necessity of a failure or logging if someone alters/drops on prod.

I still think it's really 2 different issues:

Change default away from 'alter': everyone agrees on this one :white_check_mark: ;
Prevent users from using 'alter'/'drop' in production: even with the default set to 'safe' it's possible for someone to screw up, copy a config from dev and lose production data (that person probably doesn't deserve their job :smile: ) :question: .

Ah!  Gotchya.  In that case, my take would be to,

Set default to "safe".
Prevent users from using alter/drop in production by throwing an error.  That way they can fix their config.  Given that the default is "safe", the error would only occur if their configuration is broken.

If we weren't changing the default, it would be more unclear to me whether to throw an error or silently skip migration.  Since we are changing the default, an error seems appropriate.

Changing the default itself is easy (defaults.js#L8), but the fixtures in waterline-adapter-tests will need to be updated at the same time otherwise the tests break;
Throwing error in commit 113dab2 (PR #893).

PR #893 has been merged, the only thing standing is changing the default migration.

Forgive me if I'm missing something obvious, but what strategy are you supposed to use with waterline to migrate a production schema with a SQL adapter?  Sequelize-CLI or gulp tasks, etc??

@tribou we use https://github.com/BlueHotDog/sails-migrations and it's worked out really well

Thanks @particlebanana!  Looks like a good defined migration option.

@dmarcelino do you remember what needs to be done to close this out, regarding changing the default strategy and corresponding tests?

@devinivy, take a look at #962 and balderdashy/waterline-adapter-tests#50. Those should do it.

BTW @devinivy, this is slightly off topic but I just noticed that the integration tests have 2 new broken sails-mysql tests:

Association Interface Has Many Association create nested associations() with single level depth and objects should create a new customer and payment association
Association Interface 1:m association :: .update() update nested associations() with single level depth when associations already exist should reset associations with the updated associations

Build: https://travis-ci.org/balderdashy/waterline-adapter-tests/jobs/57844170#L548
This suggests that some unreleased change in waterline (from these 13 commits) have caused it. I don't have MySQL installed on my machine so it's not easy for me to say which one caused it.

@dmarcelino feeling pretty sure it's just about this change https://github.com/balderdashy/waterline/compare/v0.10.21...master#diff-762fb5e96b0c3cfe800c9025650adbb6R68 and assumptions around order that records are created.  Mind console.logging around those tests? :P

@devinivy, regarding the above broken tests you were correct, I've just issued PR balderdashy/waterline-adapter-tests#52 which fixes them!


Fix/host mistmatch next page

Description
This fixes the issue where the URL that is returned by the "next" field doesn't match the API base_url.
Fixes doccano/doccano-client#146

Thanks.


Add: majority_element

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #108   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          46     47    +1
  Lines         511    520    +9
=====================================
+ Hits          511    520    +9

Impacted Files
Coverage Δ

problems/majority-element/majority_element.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bff384...ab175ba. Read the comment docs.


Twig method "stat" causes a problem

Commented lines here causes this problem: Attempted to call an undefined method named "getViewStat" of class "Ojs\ReportBundle\Twig\AnalyticsExtension"

#841

#884 took care of this problem.


List workflow pagination

Proposed changes

Updated ListWorkflow API to fetch only requested data from the DB.
Added Pagination, Filtering, Sorting, and Searching at DB level for ListWorkflow API.
Updated frontend according to the API's.
Removed deprecated API's from backend and frontend.
Minor style changes due to litmus-ui version 1.1.7

Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:
Please ignore translation changes if not important

There was some issue with this branch, so created a new branch for the same PR: https://github.com/litmuschaos/litmus/pull/2882


Slow Updating of Recent papers

Currently the website lacks 4 days behind the actual arXiv publications.
I'm not sure why that is or what can be done about it, but it would be nice if it was more up to date.

Related issues:
https://github.com/karpathy/arxiv-sanity-preserver/issues/57
https://github.com/karpathy/arxiv-sanity-preserver/issues/72
https://github.com/karpathy/arxiv-sanity-preserver/issues/79


add postgres comparison to python test

Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example Closes #123 indicates that this PR will close issue #123.
Closes #.
Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the breaking change label.

this relies on https://github.com/apache/arrow-datafusion/issues/282 to be resolved first

Codecov Report

Merging #281 (eb4a1cd) into master (3be087a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   76.21%   76.19%   -0.02%
==========================================
  Files         140      140
  Lines       23553    23595      +42
==========================================
+ Hits        17950    17978      +28
- Misses       5603     5617      +14

Impacted Files
Coverage Δ

datafusion/src/physical_plan/coalesce_batches.rs
83.18% <0.00%> (-1.77%)
:arrow_down:

...tafusion/src/physical_plan/distinct_expressions.rs
90.34% <0.00%> (-0.46%)
:arrow_down:

...lista/rust/core/src/serde/logical_plan/to_proto.rs
68.05% <0.00%> (-0.10%)
:arrow_down:

datafusion/src/sql/planner.rs
83.62% <0.00%> (-0.09%)
:arrow_down:

datafusion/src/physical_plan/functions.rs
89.42% <0.00%> (-0.06%)
:arrow_down:

...sta/rust/core/src/serde/logical_plan/from_proto.rs
40.51% <0.00%> (-0.06%)
:arrow_down:

datafusion/src/physical_plan/mod.rs
87.69% <0.00%> (ø)

datafusion/src/execution/dataframe_impl.rs
88.88% <0.00%> (ø)

datafusion/tests/sql.rs
99.89% <0.00%> (+<0.01%)
:arrow_up:

datafusion/src/execution/context.rs
92.64% <0.00%> (+0.01%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be087a...eb4a1cd. Read the comment docs.

@alamb @Dandandan updated to use unittest so it's more structured

What do we think @Dandandan  -- shall we merge this PR? I feel like in general the DataFusion testing story could use some consolidation / writeup (we now have tests in sql.rs, exec.rs, and now here). However, I don't think I will have time to do anything major for a while (until I get the arrow release process running like a 🚋 )

I think we should merge this PR!
I also feel some consolidation would be very helpful.
This PR seems to me it can help a lot with testing against PostgreSQL, something we don't do ATM.


Missing contact info for maintainer

@dougwilson it looks you're the maintainer, what's the best method to contact you. Via the email address you use in commits?

Yes, or the email addess in package.json, or in the license file, or any number of places :) they are all the same address.

Just as a heads up, for whatever it is you need, I am out this week so may be a slight delay, as the device i sync my email to stopped working and I'll get it back when i get home.


StoryFrames are NOT staying in correct chapter in UI

When switching between chapters, StoryFrames are not displaying in the correct chapter.

This may be resolved by #311 which @darinacosta is working.


No such command 'users'.

from the docs it seems you can use litestar cli however:
❯ litestar users

 Usage: litestar [OPTIONS] COMMAND [ARGS]...

╭─ Error ──────────────────────────────────────────────────────────────────────╮
│ No such command 'users'.                                                     │
╰──────────────────────────────────────────────────────────────────────────────╯

my pyproject:
[tool.poetry.dependencies]
python = "^3.11"
litestar-users = "^1.2.3"
aiosqlite = "^0.20.0"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

ok figured it out, it appears if you pass the --app flag only which makes sense, but the docs could be improved in that regard


Add Google Login functionality

 US2003: Användare - Inlogg via sociala medier

To do implementations:

[ ] Google, Facebook, Twitter, Microsoft accounts supported 3rd parties for login
[ ] Tokens should be stored in User Secrets (only dev)
[ ] Tokens should be stored in Azure Key Vault (when in production)

To do in reading:

[ ] Storing App Secrets
[ ] Secret Manager
[ ] Storing App Secrets in Azure Key Vault
[ ] In case of Proxy / Loadbalancers


Building https://github.com/inlab-geo/pysurf96.git fails

Tutorials on Mac OS X using pysurf96 from the corresponding InLab repository https://github.com/inlab-geo/pysurf96 no longer work due to pip install --upgrade pip install -U cofi git+https://github.com/inlab-geo/pysurf96.git failing on Mac OS X.

See https://github.com/inlab-geo/pysurf96/tree/ctypes for fix in progress


bugs

that button "Intereact" won't work
` public static void Interact()
{
Debug.Msg("Troll->Interact: Triggered", 1);
//   Main.ghostAI.Inte();
Main.ghostActivity.Interact();
 Main.ghostAI.field_Public_GhostActivity_0.InteractWithARandomProp(true,true);
 Main.ghostAI.field_Public_GhostActivity_0.Interact();
 Main.ghostAI.field_Public_GhostActivity_0.InteractWithARandomDoor();

}`
add item won't work
When u press DELETE key it should appear mouse visitibly but there is no
  if (cheatmenu == false)   {       cheatmenu = true;       originalLockState = Cursor.lockState;       originalVisible = Cursor.visible;       Cursor.lockState = CursorLockMode.None;       Cursor.visible = true;       if (myPlayer != null)           myPlayer.field_Public_FirstPersonController_0.enabled = false;   }   else if (cheatmenu == true)   {       cheatmenu = false;       Cursor.lockState = originalLockState;       Cursor.visible = originalVisible;       if (myPlayer != null)           myPlayer.field_Public_FirstPersonController_0.enabled = true;
also I suggesting add
RandomWeather -> public void PlayLightningEffect()
and noclip & fly
`    fly = !fly;
if (fly)
{
GetLocalPlayer().field_Public_CharacterController_0.enabled = false;
GetLocalPlayer().GetComponent().useGravity = false;
}
else
{
GetLocalPlayer().GetComponent().enabled = true;
}
}
if (fly)
{
Ray y = Camera.main.ScreenPointToRay(new Vector2(Screen.width / 2, Screen.height / 2));
float up = y.direction.y * movementMultiplier * Time.deltaTime;
float frd = (Mathf.Abs(y.direction.z) + Mathf.Abs(y.direction.x)) / 2;
GetLocalPlayer().field_Public_CharacterController_0.enabled = false;
GetLocalPlayer().GetComponent().useGravity = false;
if (keyboard.wKey.isPressed)
{
    GetLocalPlayer().transform.position += GetLocalPlayer().transform.TransformDirection(0, up, frd * movementMultiplier * Time.deltaTime);
}
if (keyboard.sKey.isPressed)
{
    GetLocalPlayer().transform.position += GetLocalPlayer().transform.TransformDirection(0, -(up), -(frd) * movementMultiplier * Time.deltaTime);
}
if (keyboard.aKey.isPressed)
{
    GetLocalPlayer().transform.position += GetLocalPlayer().transform.TransformDirection(-1f * movementMultiplier * Time.deltaTime, 0, 0);
}
if (keyboard.dKey.isPressed)
{
    GetLocalPlayer().transform.position += GetLocalPlayer().transform.TransformDirection(1f * movementMultiplier * Time.deltaTime, 0, 0);
}

}`
FullBright:
`
if (keyboard.f1Key.wasPressedThisFrame)
{
CheatToggles.enableFullbright = !CheatToggles.enableFullbright;
Debug.Msg("Fullbright: Toggled " + (CheatToggles.enableFullbright ? "On" : "Off"), 1);
if (CheatToggles.enableFullbright == true)
{
Fullbright.Enable();
}
else
{
Fullbright.Disable();
}
}
public static void Enable()
{
if (Main.boneTransform != null && Main.initializedScene > 1 && isAlreadyOn == false)
{
isAlreadyOn = true;
Debug.Msg("isAlreadyOn: true", 3);
Main.light = Main.boneTransform.GetComponent();
Object.Destroy(Main.boneTransform.GetComponent());
Main.light = Main.boneTransform.gameObject.AddComponent();
Main.light.color = Color.white;
Main.light.type = LightType.Spot;
Main.light.shadows = LightShadows.None;
Main.light.range = 99f;
Main.light.spotAngle = 9999f;
Main.light.intensity = 0.3f;
Debug.Msg("boneTransform set", 3);
}
else if (isAlreadyOn == false)
{
CheatToggles.enableFullbright = !CheatToggles.enableFullbright;
Debug.Msg("No boneTransform! Fullbright: Toggled " + (CheatToggles.enableFullbright ? "On" : "Off"), 1);
}
}
public static void Disable()
{
isAlreadyOn = false;
Debug.Msg("isAlreadyOn: false", 3);
Object.Destroy(Main.light);
}
private static bool isAlreadyOn = false;
`
some examples from my c# mod menu, I'm not good at c++
I'm trying to learn c++ by studying your project and making improvements on it. thank you so much for sharing.

also set player speed won't work too

Thank you for your feedback. We received similar feedback about this issue last week as well. Due to the inconvenience caused by the UnityHack library that the program is based on, the current project cannot be updated further. However, in the next few days, the program will be rewritten using UnityResolve and an attempt will be made to fix these issues.


42 add mypy

Codecov Report

Merging #54 (62ddc31) into release-candidate (7f70017) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-candidate       #54   +/-   ##
===================================================
  Coverage             100.00%   100.00%
===================================================
  Files                     43        43
  Lines                    633       633
===================================================
  Hits                     633       633


Replace @classmethod with @staticmethod?

Several classes (Renderer, Allocator, …) have a factory function which does not use the passed cls argument at all, they can be decorated with @staticmethod without any difference.
Example: https://github.com/flacjacket/pywlroots/blob/b38b6ceab0a4cf7cc8d755217b365702f59692cb/wlroots/allocator.py#L21
    @classmethod
    def autocreate(cls, backend: Backend, renderer: Renderer) -> Allocator:
        """Creates the adequate allocator given a backend and a renderer."""
        ret = lib.wlr_allocator_autocreate(backend._ptr, renderer._ptr)
        if not ret:
            raise RuntimeError("Unable to create an allocator.")
        return Allocator(ret)

This is a good point, happy to accept a PR for this, otherwise I can change these as I see them.


Measure client and cluster connect time

Related to #486 and #487
Measure cluster reconnect time. The test already existed but it was not recording anything.
Measure client connect time.
Remove auto_benchmark_time fixture, as it was sensitive to ordering issues with other fixtures

Ready for review and merge

@crusaderky I might be confused. There was some rpc call or something that you suspected was significantly affecting wall-clock on some test runs. I had assumed that was what you wanted to measure here, but maybe that's not the case.

Client connect time to a cluster is a crude proxy for a new RPC call - although it does quite a bit more stuff on top of that.

I will merge this at COB today unless there are comments

@ntabris how would you visualize in the static dashboard the data from all other tests? You would need an entirely ad-hoc series of functions in dashboard.py in order to show it.

I think visualization and measurement is not necessarily the same thing. We could measure it for every test but only write it to the DB once. Something like

@pytest.mark.fixture(scope="session")
def measure_connect_time(benchmark_db_engine):

    with Session(benchmark_db_engine, future=True) as session, session.begin() as benchmark_db_session:
        run = TestRun(
            session_id=testrun_uid,
            name="connect-time",
            originalname="connect-time",
            path=str(request.node.path.relative_to(TEST_DIR)),
            dask_version=dask.__version__,
            distributed_version=distributed.__version__,
            coiled_runtime_version=COILED_RUNTIME_VERSION,
            coiled_software_name=COILED_SOFTWARE_NAME,
            python_version=".".join(map(str, sys.version_info)),
            platform=sys.platform,
            ci_run_url=WORKFLOW_URL,
        )
        yield run

        rep = getattr(request.node, "rep_setup", None)
        if rep:
            run.setup_outcome = rep.outcome
        rep = getattr(request.node, "rep_call", None)
        if rep:
            run.call_outcome = rep.outcome
        rep = getattr(request.node, "rep_teardown", None)
        if rep:
            run.teardown_outcome = rep.outcome
        yield run
        benchmark_db_session.add(run)

def small_client(..., measure_connect_time):
    start = time()
    with Client(...):
        measure_connect_time.appropriate_field.update(time() - start)
        ...

The code is not functioning but the idea is to have a global measurement we update. We'll write it to the DB as if it was a test case but we will not have an actual test case.
There are possibly more things we would like to collect globally in which case this kind of approach would pay off. If it's just about the one metric, I don't mind running an extra test.

thanks @fjetter, I think I endorse all of what you said in https://github.com/coiled/coiled-runtime/pull/489#issuecomment-1327699785

Removed the offending test.
The measure of client connect time can be done in a separate PR.
Ready for review and merge again.

Merging COB today if there are no objections


allow sass

This is needed to remove @types/sass

Is there a PR for this on Definitely Typed? I looked and didn't see one.

@sandersn, I didn’t open a PR in DefinitelyTyped just yet, since the tests were failing locally.
But this is needed to remove types/sass since now sass includes its own declaration files<EMAIL_ADDRESS>

Looks like @types/sass has 4 dependencies inside DT. Are you able to update those to use the new sass types, or will they need to point to the old @types/sass? I'd prefer to add both at the same time to make future reference easier.
Adding @orta for next week in case this takes longer than today, since I'll be on vacation.

@sandersn, I opened a draft PR with the proposed changes https://github.com/DefinitelyTyped/DefinitelyTyped/pull/57768


Sender recovery (trace_filter) failed for an old block

Describe the bug
eth.merkle.io snapshot was used, so it's unclear if it's corrupted snapshot; or reth, which generated corrupted data
Steps to reproduce
Get internal transactions (trace_filter) for address 0x6994eCe772cC4aBb5C9993c065a34C94544A4087 from block 46100 to block 46200
Node logs
No response
Platform(s)
Linux (x86)
What version/commit are you on?
0.2 b6
What database version are you on?

Which chain / network are you on?

What type of node are you running?
Archive (default)
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

thanks, this is pre eip2, we just need to use a different recovery fn here #8200


Remove irc_channels

End of an era?
My plan is to remove all the callers of this handler, then remove the handler itself.

I've reverted this change


Connectycube connects to chat server too late. (RN Voip and Call-Keep)

Hello, I use voip push to wake up an application. RN call-keep works right after waking the application with Voip. However, these are happening on the native side. On the Rn side, call-keep works before I connect to the chat. As soon as the user answers the call, only the open application comes in front of him. How can we synchronize both.
- (void)pushRegistry:(PKPushRegistry *)registry didReceiveIncomingPushWithPayload:(PKPushPayload *)payload forType:(PKPushType)type withCompletionHandler:(void (^)(void))completion {
  // Process the received push
  [RNVoipPushNotificationManager didReceiveIncomingPushWithPayload:payload forType:(NSString *)type];

  NSObject* aps = payload.dictionaryPayload[@"aps"];

  NSString* alert = [aps valueForKey:@"alert"];

  NSLog(@"%@", alert);

  NSData *webData = [alert dataUsingEncoding:NSUTF8StringEncoding];
  NSError *error;
  NSDictionary *jsonDic = [NSJSONSerialization JSONObjectWithData:webData options:NSJSONReadingMutableContainers error:&error];

  NSLog(@"%@", jsonDic);

  NSString *uuid = [jsonDic valueForKey:@"uuid"];
  NSString *callerName = [jsonDic valueForKey:@"callerName"];
  NSString *handle = [jsonDic valueForKey:@"handle"];

  NSLog(@"%@ %@ %@", handle,callerName,uuid);

  BOOL hasVideo = NO;

  if ([[jsonDic valueForKey:@"hasVideo"] isEqualToString:(@"1")]) {
    hasVideo = YES;
  } else {
    hasVideo = NO;
  }

  if([[UIApplication sharedApplication] applicationState] != UIApplicationStateActive)
  {
      [RNCallKeep reportNewIncomingCall: uuid
                               handle: handle
                           handleType: @"generic"
                             hasVideo: hasVideo
                  localizedCallerName: callerName
                      supportsHolding: NO
                         supportsDTMF: YES
                     supportsGrouping: NO
                   supportsUngrouping: NO
                          fromPushKit: YES
                              payload: nil
                withCompletionHandler: completion];
  }

@CMLCNL Is this a P2P call?
In general, the flow should be the following:

UserA starts to call UserB. SDK sends call requests via Chat every 5 seconds. This is managed by videochat.dialingTimeInterval config.
Also, UserA sends a VoIP push notification.

At UserB side, the app is in bg or closed.
UserB receives the VoIP push and display CallKit UI.
Then UserB accepts the call, which triggers the app to launch.

Once app is launched at UserB side, you perform login + chat connect.
Once chat is connected, UserB will receive one of the dialing messages via Chat and can perform accept https://developers.connectycube.com/js/videocalling?id=accept-a-call

Is this how you are trying to implement it?

@CMLCNL Is this a P2P call?
In general, the flow should be the following:

UserA starts to call UserB. SDK sends call requests via Chat every 5 seconds. This is managed by videochat.dialingTimeInterval config.
Also, UserA sends a VoIP push notification.

At UserB side, the app is in bg or closed.
UserB receives the VoIP push and display CallKit UI.
Then UserB accepts the call, which triggers the app to launch.

Once app is launched at UserB side, you perform login + chat connect.
Once chat is connected, UserB will receive one of the dialing messages via Chat and can perform accept https://developers.connectycube.com/js/videocalling?id=accept-a-call

Is this how you are trying to implement it?

I'm doing what you say. Do you yourself use this connectycube? Because it takes a long time to connect to the chat server. Sometimes it takes 5 seconds to connect. I successfully show CallKit ui with voip notification. However, I cannot answer the call while on the Lock screen. Most of the time, the request cannot be sent. Application that falls off the socket. Listeners may not be working.

I'm doing what you say. Do you yourself use this connectycube? Because it takes a long time to connect to the chat server. Sometimes it takes 5 seconds to connect. I successfully show CallKit ui with voip notification. However, I cannot answer the call while on the Lock screen. Most of the time, the request cannot be sent. Application that falls off the socket. Listeners may not be working.

@CMLCNL the call request duration is managed by   videochat.answerTimeInterval config and set to 60 seconds by default,
so mainly a user should have enough time to answer
Once a user accepted a call via CallKit screen -> run your app, show Call screen.
Then connect to chat and listen for incoming call request which you need to accept automatically

@CMLCNL the call request duration is managed by   videochat.answerTimeInterval config and set to 60 seconds by default,
so mainly a user should have enough time to answer
Once a user accepted a call via CallKit screen -> run your app, show Call screen.
Then connect to chat and listen for incoming call request which you need to accept automatically

I tried what you said, but I am having trouble connecting to http requests and sometimes socket service. If the application is on the Lock screen and I answer the call from Callkit, then sometimes I cannot connect to the http request and socket service. Most of the time cb listeners don't work either. I'm getting a warning that Connection is not offline.

I tried what you said, but I am having trouble connecting to http requests and sometimes socket service. If the application is on the Lock screen and I answer the call from Callkit, then sometimes I cannot connect to the http request and socket service. Most of the time cb listeners don't work either. I'm getting a warning that Connection is not offline.

I'm sending voip push via connectycube.
When there is a push on the native side, callkit works. How do I make CallKit work on js side? If I remove the call kit on the native side, the application only runs for a few seconds.
I don't use it because the application keeps running with voip for a few seconds. When voip notification arrives.
RNCallKeep.displayIncomingCall(uuid, handle, localizedCallerName);
Whenever I use it like that. Then the application is fully working. But most of the time I cannot answer calls on the lock screen. Something is happening that I don't understand. Connection is not offline on console.
[RNCallKeep reportNewIncomingCall: uuid
                               handle: handle
                           handleType: @"generic"
                             hasVideo: hasVideo
                  localizedCallerName: callerName
                      supportsHolding: NO
                         supportsDTMF: YES
                     supportsGrouping: NO
                   supportsUngrouping: NO
                          fromPushKit: YES
                              payload: nil
                withCompletionHandler: nil];

I'm sending voip push via connectycube.
When there is a push on the native side, callkit works. How do I make CallKit work on js side? If I remove the call kit on the native side, the application only runs for a few seconds.
I don't use it because the application keeps running with voip for a few seconds. When voip notification arrives.
RNCallKeep.displayIncomingCall(uuid, handle, localizedCallerName);
Whenever I use it like that. Then the application is fully working. But most of the time I cannot answer calls on the lock screen. Something is happening that I don't understand. Connection is not offline on console.
[RNCallKeep reportNewIncomingCall: uuid
                               handle: handle
                           handleType: @"generic"
                             hasVideo: hasVideo
                  localizedCallerName: callerName
                      supportsHolding: NO
                         supportsDTMF: YES
                     supportsGrouping: NO
                   supportsUngrouping: NO
                          fromPushKit: YES
                              payload: nil
                withCompletionHandler: nil];

me too

me too

@meosieudang @CMLCNL I think the best way will be to implement it on our side an integrate in P2P code sample.
Will try to dod it this week and share

@meosieudang @CMLCNL I think the best way will be to implement it on our side an integrate in P2P code sample.
Will try to dod it this week and share

As for the progress tracking - here is an MR https://github.com/ConnectyCube/connectycube-reactnative-samples/pull/200

As for the progress tracking - here is an MR https://github.com/ConnectyCube/connectycube-reactnative-samples/pull/200

Closed due to inactivity. Please create a new issue if needed.


[SSADestroyHoisting] Don't fold over trivial use.

Given an aggregate addr %agg with trivial subobject addr %triv and nontrivial subobject addr %sub which %triv is projected from,
  Aggregate   <- %agg
    Subobject <- %sub
      Trivial <- %triv
      ...
    ...

after %sub is destroyed, %triv is no longer initialized.  As a result, it's not valid to fold a destroy_addr of %agg into a sequence of load [copy]s and copy_addrs if there's an access to %triv after the load [copy]/copy_addr of %sub (or some intermediate subobject).
In other words, transforming
  copy_addr %sub
  load [trivial] %triv
  destroy_addr %agg

into
  copy_addr [take] %sub
  load [trivial] %triv

is invalid.
During destroy_addr folding, prevent that from happening by keeping track of the trivial fields that have already been visited.  If a trivial field is seen more than once, then bail on folding.  This is the same as what is done for non-trivial fields except that there's no requirement that all trivial fields be destroyed.

@swift-ci please test

@swift-ci please test macOS platform

@swift-ci please test source compatibility


⚠ Fetchers has degraded performance

In b4e6f45, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 202 ms

Resolved: Fetchers performance has improved in c96766a.


Fixes issue where Ensure DB user check fails when the port value is changed

Fixes issue #3
When the postgresql.port value is changed you get the following error:
TASK [Ensure DB user] ******************************************** fatal: [default]: FAILED! => {"changed": false, "failed": true, "msg": "unable to connect to database: could not connect to server: No such file or directory\n\tIs the server running locally and accepting\n\tconnections on Unix domain socket \"/var/run/postgresql/.s.PGSQL.5432\"?\n"}
This occurs because the postgresql_user gradle core module does not inspect the postgresql configuration and instead opts to connect via the 5432 port as a default. See here .

Following.


Update GMZA token Logo assest + URI + website

I'm submitting a ...
[ ] bug report
[ ] feature request
[x ] question about the decisions made in the repository
[ ] question about how to use this project

**Plz kindly update the logo of the token to the latest logo assest added and its URi also website is added
thanks in advance

PR: #13210
**

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

added comment on PR


where set this in herolu

Where do i set this in heroku?
export PORT=8080
export CORSANYWHERE_BLACKLIST=https://abuse.example.com,http://abuse.example.com
export CORSANYWHERE_RATELIMIT='50 3 my.example.com my2.example.com'
node server.js

The README links to https://devcenter.heroku.com/articles/getting-started-with-nodejs
which has a section "Define config vars" at https://devcenter.heroku.com/articles/getting-started-with-nodejs#define-config-vars
which provides some details, and also links to a more detailed tutorial at https://devcenter.heroku.com/articles/config-vars


Ability to create a snake_case field with the graphql_object! macro

Hi, as I wasn't able to find any way to do this I open this issue:
a way to create snake_case fields should be provided.
Now we can create an object
graphql_object!(Human: () |&self| {
    field id() -> Option<&str> {
        self.id.as_str()
    }

    field appearsIN() -> Vec<Episode> {
        vec![Episode::NewHope, Episode::Jedi]
    }
});

which results in
query {
human(id: "1234") {
    id
    appearsIN
  }
}

but we can't create the following object due to the automatic field transformation
query {
human(id: "1234") {
    id
    appears_in
  }
}

indeed
graphql_object!(Human: () |&self| {
    field id() -> Option<&str> {
        self.id.as_str()
    }

    field appears_in() -> Vec<Episode> {
        vec![Episode::NewHope, Episode::Jedi]
    }
});

will results in
query {
human(id: "1234") {
    id
    appearsIn
  }
}

Yup we should probably allow snake case fields even though they are against the convention.

the source of the problem come from constructions like this
$reg.field_convert::<$t, _, Self::Context>(
                &$crate::to_camel_case(stringify!($name)), $info)
                .deprecated($reason),

https://github.com/graphql-rust/juniper/blob/master/juniper/src/macros/object.rs#L280
but being not fluent enough in rust, I don't know how to modify the macro to allow snake_case call instead of to_camel_case

We will need to add some kind of attribute that disables to to_camel_case conversion.
Maybe
#[juniper(keep_field_name)]
field appears_in() -> Vec<Episode> {
        vec![Episode::NewHope, Episode::Jedi]
    }

I disagree that the current behavior should be changed.
Juniper should keep the current behavior (names are coerced into camel case).
Many new users create fields using snake_case intuitively, which is part of the current benefits of Juniper that your rust code looks more or less like rust, using rust conventions (instead of diverging completely into a custom DSL), and your GraphQL schema still uses GraphQL conventions.
While field names are always coerced to strings, and can be handled arbitrarily because of that, other parts of the graphql_xyz! macros are hard coded and cannot be changed according to preference.
Example:
graphql_interface!(<'a> &'a Character: () as "Character" |&self| {
    field myCamelCaseField() -> &str { self.id() }
    field myOtherCamelCaseField() -> &str { self.id() }

    instance_resolvers: |_| { // <--- not a field
        &Human => self.as_human(),
        &Droid => self.as_droid(),
    }
});

As an additional note, the documentation currently uses snake_case in its examples, so I would expect more existing users to write with juniper that way and expect the current behavior (See http://juniper.graphql.rs/types/input_objects.html).
To get the behavior you want, where schema names have non-standard GraphQL names, I'd instead recommend one of the patterns like:
/// Option Foo
#[juniper(rename = "Appears_In")]
field appears_in() -> Vec<Episode> {
        vec![Episode::NewHope, Episode::Jedi]
    }
}

/// Option Bar
field appears_in() rename "appears_in" -> Vec<Episode> {
        vec![Episode::NewHope, Episode::Jedi]
    }
}

The first option has the benefit of being similar to serde's macros and so should be easier to learn and more familiar for the majority of rustaceans.

Post Script 1.  -  If anything I'd strongly recommend removing support for non-snakecase field identifiers in the macros (or adding a lint, and have them warn by default); especially prior to v1.0, allowing juniper to make larger changes to macro generated code in the future without affecting stability.

@kestred no one suggested changing the default behaviour.
All this is about is a option to disable the automatic camel case conversion if you really need it, which might be neccessary in some cases.

@z0mbie42 Why not to query like this
query {
  human(id: "1234") {
    id
    appears_in: appearsIn
  }
}

and not introduce extra complexity in this crate?

I think the current behaviour is fine and this is a pretty edge use case.
renaming fields is a relatively small manual step if you really need it.

@theduke the camelCase naming is a preference NOT a specification or even a convention. Technically __typename is snake case... In fact the the spec in forces the use of snake case when you read  names.


[BUG] Support for 1.19, k3s version is hardcoded.

What did you do

How was the cluster created?

k3d cluster create mycluster

What did you do afterwards?

docker images

What did you expect to happen
According to the source code it should pull the latest k3s version which is currently 1.19 but it doesnt. It always gets the hardcoded 1.18 version from the version.go file. I also try preloading rancher/k3s:latest and the 1.19 tag and still didnt work.
Which OS & Architecture

Linux - Ubuntu Focal 20.04.1

Which version of k3d

3.0.2

Which version of docker

19.x

Hi @gabrielcalderon , thanks for opening this issue :)
We have to hardcode the default version in the code to avoid runtime issues with trying to fetch the latest version (also, there are API limits everywhere, so this is fairly impractical and error-prone).
However, there's the --image flag for this :+1:
E.g. in your case you'd use k3d cluster create mycluster --image rancher/k3s:v1.19.2-k3s1

@iwilltry42 Thanks! I will give that a try!


TEIIDTOOLS-466: Adding OpenTracing support

LGTM - the last step is to have the agent running with the application - described as a sidecar https://github.com/jaegertracing/jaeger-openshift
istio may also provide that automagically.


feat: add linting

@kylecarbs it looks like most of the modules have example code blocks but linter is complaining.
Do They need to be before ##Examples heading?

@kylecarbs our linter is now happy :D


Removed Point of Service from Topic column

Getting Started and device support

@TerryWarwick,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Please include glad directly into forge

Current setup of glad dependency makes it unnecessary hard to build:

forge expects a specific configuration, as can be found in arrayfire's glad repository. A vanilla upstream glad does not work, as that has to be integrated specifically, see e.g. https://github.com/Dav1dde/glad/issues/376#issuecomment-1209640818
Offline builds expects a git clone, a snapshot downloaded from githup (e.g. https://github.com/arrayfire/glad/archive/refs/heads/master.tar.gz) does not work.

forge should either include the pregenerated glad sources as a git subproject, or use a plain upstream glad and configure it at build time.

Forge (ArrayFire also) uses a specific workflow for fetching dependencies like glad, glm etc. for building the concerned project. I believe it is better to be consistent on how CMake fetches dependencies if possible, which it is in the case of glad for forge/arrayfire. I am not a fan of including large source files into the repository, especially when CMake can help with the same. Also, please note that, all this dependency handling is taken care by the CMakeLists.txt without user invention. If that is not the case in your experience, please share the issue you have encountered.

forge should either include the pregenerated glad sources as a git subproject,

Sure, that is one way to do it. Again subtree is nothing but maintaining a copy of those sources in the downstream project which we want to avoid. We used to have similar dependencies as submodules, but we removed those in favor of CMake's fetch content which lets us handle the case of git not being available in offline builds.

or use a plain upstream glad and configure it at build time.

In a way, what's transpiring now is akin to the above suggestion. The difference being, we keep the glad sources that arrayfire and forge needs in separate repository and we re-use that directly in our CMake.

As far as the offline builds are concerned, every release of forge uploads a full code base of forge that includes the dependencies also as forge-full-x.x.x.tar.bz2 GitHub release asset.

I am not suggesting the workflow of arrayfire/forge is the best route but it definitely addresses the uses cases we want to handle.

CMake handles all build time dependencies automatically
Make offline builds possible without git
Avoid large source files of upstream dependencies

Closing due to inactivity, please re-open if required after reviewing my above response.

The "forge-full" tarball is broken - FetchContent_Populate, as called by fg_dep_check_and_populate requires a git checkout, i.e. including the ".git" directory.
Please try to build it without any network connection, it will fail with the following output:
[   14s] [ 11%] Creating directories for 'fg_glad-populate'
[   14s] [ 22%] Performing download step for 'fg_glad-populate'
[   14s] [ 33%] Performing disconnected update step for 'fg_glad-populate'
[   14s] CMake Error at /home/abuild/rpmbuild/BUILD/forge-1.0.8/build/extern/fg_glad-subbuild/fg_glad-populate-prefix/tmp/fg_glad-populate-gitupdate.cmake:34 (message):
[   14s]   Failed to get the hash for HEAD:
[   14s]
[   14s]   fatal: not a git repository: '.git'

https://github.com/arrayfire/arrayfire/issues/3527#issuecomment-1882445456


Typo in Documentation

Hi @davidkpiano,
Fantastic library.
While reading the documentation I found an inconsistency:
Api > Action Creators: describes asyncSetValidity
Based on the API it seems as the correct function is asyncSetValidty
Guides > Validation: describes setAsyncValidty
import { actions } from 'react-redux-form';

// wherever validation occurs...
const { user, dispatch } = this.props;

dispatch(actions.setAsyncValidity('user.username', (value, done) => {
  asyncCheckUsername(value)
    .then((response) => done({ available: response.available });
}));

Nothing major of course but possibly worth correcting to avoid confusions.
Thanks again for a great library!

Thanks for the report!


Implement handling of SOF (Start-of-Frame) packets and grouping of SOFs

Current version of ViewSB does not properly handle SOF (Start-of-Frame) packets; only shows that a group of SOFs was filtered out.
This PR adds following functionality:

the grouping will show the number of SOF packets inside the group (instead of always 0)
the detailed SOF packets are available, including the frame number value

Validated for cli, tui and qt frontends.
Note that by default the SOF packets are filtered-out; use the --include-sofs or -S option to disable this filter

Thanks!


[10.x] Add str()->take($limit)

Take the first or last {$limit} characters.
Before
str('abcdef')->substr(0, 2) // 'ab'

After
str('abcdef')->take(2) // 'ab'

Hey there - cool method but would have to be added to Str too.

Added! https://github.com/laravel/framework/pull/48467


docs: add Python API reference to mkdocs

Description
The description of the main changes of your pull request
Related Issue(s)
Documentation

@wjones127 - what commands can I run to QA this PR?


COUNTA vs. DISTINCTCOUNT

Hi!
I am learning Power BI and am studying the Opportunity Analysis dataset. I am had a question about the "Opportunity Count" measure in the "Fact" table. The measure uses the formula "Opportunity Count = COUNTA([Opportunity ID])" and returns a value of 487 in the Report View.
However, when I look at the "Opportunity ID" column in the data table there are only 486 rows. I initially used the formula "Opportunity Count = DISTINCTCOUNT([Opportunity ID])" when I created a copy version for practice and received a total of 486 when I included the measure in the Report View.
Is the use of COUNTA correct and if so, why does is there one additional value?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3041354-2ebf-99f3-e0c5-ac57227904c8
Version Independent ID: 3a410693-c86e-70c3-4b44-1fad4719ffb3
Content: Opportunity Analysis sample for Power BI: Take a tour - Power BI
Content Source: powerbi-docs/sample-opportunity-analysis.md
Service: powerbi
GitHub Login: @mihart
Microsoft Alias: mihart

Hi @rslayunc ,
That's a really good question.  I'll look into this and get back to you asap.
Thanks
Michele

Hi @rslayunc
This took a lot of investigation, thanks to WillT and JeffreyW.
You have Opportunity ID 302 twice in the Fact table, therefore distinct count is 486 but countis 487. To easily visualize the data issue, simply create a table visual and add [Opportunity ID] to the visual twice, once using Do Not Summarize, the second time using Count. Sort the rows by Count in descending order and you’ll see the duplicate value.
Take care,
Michele


Add configure to bypass assert dialogs

Set the value to false will allow build debug binaries while not showing the assertion failure dialogs. Just to make the debugging easier.

Codecov Report

Merging #888 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage   17.48%   17.48%
=======================================
  Files         228      228
  Lines      139263   139263
  Branches    12334    12334
=======================================
  Hits        24353    24353
  Misses     113967   113967
  Partials      943      943

Flag
Coverage Δ

#2017
17.48% <ø> (ø)
:arrow_up:

#Debug
17.48% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906b9cb...59276c5. Read the comment docs.

If I understand this, this does not actually change the default (which is 'true') and thus asserts will pop a dialog box.   It also obviously will not affect a release build (which has no asserts). but simply makes this useful option more discoverable) and easier to turn on (you don't have to remember the exact name).
I am conflicted about this because it is frankly not too likely to be discovered (how will users know to look there.  Only those people who know about this switch will think to look).  and frankly turning off asserts is probably not a good idea (they are there for a reason).   I know you can redirect to a file, but that is not what this encourages, and frankly if it is not in your face it is not doing its job.
In my own usage, when I hit asserts that I don't want to investigate, I simply comment it out (that way all the others are still on).   There used to be an option on the dialog for this.
This to me is reasonably 'obvious' (If I keep hitting an assert I don't care about comment it out).
If you still feel strongly that this adds value, let me know in antoher comment on this PR and I will check it in (since it is a no-op and will be valuable to at least those people like yourself that know about it), but I guess I am trying to convince you that commenting out is a better strategy, and we should not bother.   If you agree that it is not worth it, just close this.
I am OK either way.

Yes, this doesn't change the default behavior.
There is scenario every once a while that I need it. Since it is not frequently used, I find myself searching for it again and again. I know what I want, but I can't remember the schema.

I'll appreciate it if this gets in, then I'll save the time for searching the schema when I ran into that scenario again. And hopefully, this could save someone else's time as well.
Bottom line, this should have no side effect by default. :-)


UX Accessibility Testing

Title of ticket: UX Accessibility Testing
Description
Run Gathering Records and PDF Tron through Accessibility Tests to identify any issues.
Dependencies
Are there any dependencies?
DOD

[x] Run accessibility tests in PDF Tron
[x] Document Critical Errors in ticket for review
[x] Run accessibility test on gathering records
[x] Document Critical Errors in ticket for review

Created tickets #3497 & #3496 this critical level errors that were identified all seem to be ALT Text related and small. No issues with design or sizing.
@m-prodan let me know if you have any questions and if we are okay to add these new tickets to an upcoming refinment


"RNGADBannerView does not exist" error

Hello,
I've tried to use react-native-admob 2 beta but I'm getting this error.

I don't know what to do, could anyone please help me?
Before anyone asks;  I had started with create-react-native-app command but before then using admob I ejected my app.
My dependencies are below.
"dependencies": {
"axios": "^0.17.1",
"expo": "^23.0.4",
"react": "16.0.0",
"react-native": "0.50.3",
"react-native-admob": "^2.0.0-beta.4",
"react-native-loading-spinner-overlay": "^0.5.2",
"react-native-render-html": "^3.5.2",
"react-navigation": "^1.0.0-beta.21",
"react-redux": "^5.0.6",
"redux": "^3.7.2",
"redux-promise": "^0.5.3",
"redux-saga": "0.16.0",
"redux-thunk": "^2.2.0"
}

Looks like you forgot to “link” the project. Please check the installation section in the README

Maybe I've screwed up somehow but Xcode and terminal say that it is linked.

The icon of the library should not look like that actually..
Can you try to follow the manual linking steps and see if that solves it?

Glad you figured it out. Going to close this now.

Btw, you do not need to add the xcodeproj file to the linked libs

Thank you! Last quick question, do I need to do anything with my Admob app Id like we should do on swift/xcode?

It works without, but I believe Google recommends it. To add it you should use the documented way; so just adding it to the AppDelegate for iOS, and using the respective way on Android too.

I also face the same issue. I share a link, this issue mention here with the solution. It might be helpful to you.
Pls refer this link:
https://react-native-solutions.blogspot.com/2018/07/how-to-create-react-native-app-with.html

me too...


Split memos disappear

Steps to reproduce the behaviour

Click on transaction
Click on edit FAB button
Click on split icon
Add memo to 1 or more splits
Click "save"
Click "save" again
Click on edit FAB button
Click on split icon

Expected behaviour
Splits have their memos.
Actual behaviour
Split do not have their memos anymore.
Software specifications

GnuCash Android version: 2.2.0
System Android version: 6.0
Device type: Any

caused by commit 96a204564147d54ca0b2ec8b393fb5c3aa33c5d1

Merged into hotfix/patches (957ae86). Thanks!


upgrade to rc1 from preview9

Thanks for this package! Might it be possible to upgrade the nuget package from preview9 to rc1?

As far as I’m aware there has been no breaking change. Do you get an error? If so please post it.

I'm closing this because there was no follow up


[💡 FEATURE REQUEST]: Introduce/revive JWT middleware in HTTP plugin

Plugin
HTTP Middleware (any)
I have an idea!
Often in microservices it is required to validate JWT. Perhaps this functionality was previously in RR. Maybe we will return it in 2025?
These is JWT mention -> https://roadrunner.dev/features
Some jwt packages required https://github.com/search?q=org%3Aroadrunner-server+jwt&type=code&p=1

duplicate: #912
You may send your proposal in the ^ ticket.

But yeah, need to remove mentions from the features page. Thanks.


Dashboard is not loading

🐛 Bug
Following example_4 the trainer app
The dashboard is not loading
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
Traceback:
File "/Users/mansy/src/lightning-hpo/venv/lib/python3.9/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 556, in _run_script
    exec(code, module.__dict__)
File "/Users/mansy/src/lightning-hpo/venv/lib/python3.9/site-packages/lightning_app/frontend/streamlit_base.py", line 35, in <module>
    main()
File "/Users/mansy/src/lightning-hpo/venv/lib/python3.9/site-packages/lightning_app/frontend/streamlit_base.py", line 31, in main
    render_fn(flow_state)
File "/Users/mansy/src/lightning-hpo/lightning_hpo/controllers/sweeper.py", line 106, in render_fn
    resp = requests.get(state.db_url + "/general/", data=GeneralModel.from_cls(SweepConfig).json())

To Reproduce
Steps to reproduce the behavior:
1- follow readme to install package and requirements
2- run  lightning run app examples/4_app_sweeper.py
the dashboard shows

Resolved by updating the Specs. Validate it works on master with @ethanwharris.


Member Rewards Program example breaks at estimate step

I've been trying to learn DoWhy by replicating some of your example cases in JupiterLab. I ran into a problem with the Member Rewards example. When I run the Estimate step
estimate = model.estimate_effect(identified_estimand,
        method_name="backdoor1.propensity_score_matching",target_units="att")
print(estimate)

it fails with this error
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
/var/folders/8_/ql9yb6nn4076n1y9vptzpqwm0000gp/T/ipykernel_31382/3092132001.py in <module>
----> 1 estimate = model.estimate_effect(identified_estimand,
      2         method_name="backdoor1.propensity_score_matching",target_units="att")
      3 print(estimate)

~/opt/anaconda3/lib/python3.9/site-packages/dowhy/causal_model.py in estimate_effect(self, identified_estimand, method_name, control_value, treatment_value, test_significance, evaluate_effect_strength, confidence_intervals, target_units, effect_modifiers, fit_estimator, method_params)
    277                 treatment_value=treatment_value)
    278         # Check if estimator's target estimand is identified
--> 279         elif identified_estimand.estimands[identifier_name] is None:
    280             self.logger.error("No valid identified estimand available.")
    281             estimate = CausalEstimate(None, None, None,

KeyError: 'backdoor1'

If I replace backdoor1 with backdoor the cell runs without throwing an error, but I get this output
Estimation failed! No relevant identified estimand available for this estimation method.
I'm attaching my JupyterLab notebook in a zip file so you can check it.
dowhy-example1.ipynb.zip

Can you try using this version of the notebook?

I replicated your new notebook in JupyterLab in my environment (MacOS Monterrey, Chrome) and it matched your output. No more errors on the estimate step.
Interestingly, backdoor1.propensity_score_matching also works, although it gives a fairly different estimate (below). Also, I couldn't find any documentation on backdoor1 vs backdoor, so have no idea how they differ or when to use one vs the other.
*** Causal Estimate ***

## Identified estimand
Estimand type: nonparametric-ate

## Realized estimand
b: post_spends~treatment+signup_month+pre_spends
Target units: att

## Estimate
Mean value: 93.67169431875327


Incorrect inputMap

You missed touchend event in inputMap variable

Good catch! I'll have this in a release available in the next day or two. I'll post here when I do so you know when you can check out the update.

Hi @Metastasis, this is now added in v5.1.4


More testing with yelp and created date type arrays

Declared 5 arrays globally for date type search parameters for yelp. Also changed line 8 from "var" to "let". Please review.

looks great


TypeError: this._connectionResolver is null

https://github.com/IcecaveLabs/overpass-websocket-client/blob/develop/src/connection/Connection.coffee#L97
Throws the error on this line this._connectionResolver.reject(new Error(c.reason))
Somehow the connectionResolver is already null before it can reject it.

FYI @ezzatron

I've looked into this pretty heavily.
Couldn't find a pathway where this should occur.

On 27 Oct 2015, at 7:13 PM, James Harris<EMAIL_ADDRESS>wrote:
FYI @ezzatron
—
Reply to this email directly or view it on GitHub.

Repo is being archived.


fix: correctly calculate resize metadata when given w & h

Meant to fix https://github.com/JonasKruckenberg/imagetools/issues/510
There is an additional case not being handled in resizeTransform: If both width AND height are given, but no aspect.
This case is a bit complicated, because the fit needs to be considered and possibly used to recalculate all the values:

(See Resizing images in the Sharp docs)
I couldn't find anything in resize.spec.ts testing the metadata, any pointers there?

Quick Checklist

[x] I have read the contributing guidelines
[ ] I have written new tests, as applicable (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] I have added a changeset, if applicable

For testing, I wonder if you could refactor out the code for calculating dimensions and then just test that part with a unit test.

@nick-vincent this PR will need a rebase

I think I found some additional edge cases, so I went ahead and merged this so that I can add tests for all of them together at once

Thanks for merging this, @benmccann! Feel free to tag me in the follow-up PR.


Warning when device tree overlay for pullup/pulldown resistors compiled with dtc

The dtc (device tree compiler) outputs the following warning when the device tree overlay for configuring pullup/pulldown resistors is compiled:
Warning (unit_address_vs_reg): Node /fragment@0 has a unit name, but no reg property

See https://lb.raspberrypi.org/forums/viewtopic.php?f=107&t=161771&p1051588#p1051588

This is a dtc issue. The error can be suppressed with -W no-unit_address_vs_reg, for example:
dtc -W no-unit_address_vs_reg -@ -I dts -O dtb -o mygpio-overlay.dtb mygpio-overlay.dts


ring_filter build error: fatal error: velodyne_pointcloud/point_types.h: No such file or directory

Hi,
at the date of 05/19, the version by git cannot be compiled
[ 86%] Built target kf
Scanning dependencies of target ring_filter
[ 86%] Building CXX object sensing/data_filter/packages/points_filter/CMakeFiles/ring_filter.dir/nodes/ring_filter/ring_filter.cpp.o
~/Autoware/ros/src/sensing/data_filter/packages/points_filter/nodes/ring_filter/ring_filter.cpp:38:45: fatal error: velodyne_pointcloud/point_types.h: No such file or directory
 #include <velodyne_pointcloud/point_types.h>
                                             ^
compilation terminated.
Linking CXX executable ~/Autoware/ros/devel/lib/points_filter/distance_filter

I hacked the cmake file by adding the directory of the header file, it can work. you guys may have an more elegant way to solve it .
include_directories(include
   ${catkin_INCLUDE_DIRS}
   ~/Autoware/ros/src/sensing/drivers/lidar/packages/velodyne/velodyne_pointcloud/include/
)

thanks
Richard

Did you install ros-indigo-velodyne-pointcloud package ?

I did not installed that one, as instructed
"NOTE: Please do not install ros-indigo-velodyne-pointcloud package. Please uninstall it if you already installed."
should I install  ros-indigo-velodyne-pointcloud?

Oh, sorry for my mistake. No you should not. It is imported into Autoware repository. It looks compile flag is not collect, I'll check it.

Add velodyne_pointcloud to find package.
find_package(catkin REQUIRED COMPONENTS
roscpp
pcl_ros
sensor_msgs
pcl_conversions
velodyne_pointcloud
runtime_manager
message_generation
)
Add "velodyne_pointcloud" to build_depend and to run_depend to package.xml as follows.

points_filter
0.0.0
The points_filter package
Yuki KITSUKAWA
BSD
<buildtool_depend>catkin</buildtool_depend>
<build_depend>sensor_msgs</build_depend>
<build_depend>runtime_manager</build_depend>
<build_depend>message_generation</build_depend>
<build_depend>velodyne_pointcloud</build_depend>
<run_depend>sensor_msgs</run_depend>
<run_depend>message_runtime</run_depend>
<run_depend>velodyne_pointcloud</run_depend>

@yukikitsukawa Could you send pull request ?

@syohex I have just sent PR.

@RicWg We have fixed this issue at #312, please check latest version.

will do, light speed you guys.
thanks
On Thursday, May 19, 2016 10:09 PM, Syohei YOSHIDA<EMAIL_ADDRESS>wrote:

@RicWg We have fixed this issue at #312, please check latest version.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

I met same problem .

I followed the kitsukawa's comment. However, I did't work

Could you explain in detail?

you do not build_depend snd run_depend on but_velodyne pkg.


ntp: add telemetry events for show/hide

Asana Task/Github Issue:
Description

Testing Steps

Checklist

Please tick all that apply:

[ ] I have tested this change locally
[ ] I have tested this change locally in all supported browsers
[ ] This change will be visible to users
[ ] I have added automated tests that cover this change
[ ] I have ensured the change is gated by config
[ ] This change was covered by a ship review
[ ] This change was covered by a tech design
[ ] Any dependent config has been merged

#1280  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Convert report-a-lost-or-stolen-passport outcomes to use ERB templates

The main thing of interest in this PR is that it's the first one where we've need to use a data partial. For the moment we've implemented this by simply using a standard call to render partial: 'foo', but prefixing the template name with a relative path to the shared data partial directory. See the commit entitled "Convert contact_the_embassy outcome" for further details.

Looks good to me.


Fix company logos not rendering on "Case Studies" page

On the Kubernetes case studies page (https://kubernetes.io/case-studies/), certain company icons are not visible. I have changed the names of the missing companies logo to be of the same format as rest of company logos that are present in the repo. And after name change the logo are visibiel for all companies.
Fixes https://github.com/kubernetes/website/issues/46321

/area web-development


Fragment_id column in .bed file.

A fragment_id column is observed in In the .bed file generated by Decoil. I would like to ask if there is a way to identify which reads correspond to this fragment_id and determine the positions of this target sequence.

Hi @MJoseMo, the fragment_id refers to a non-overlapping region from the reference genome to which the data was aligned. So it refers only to coordinates i.e. chr:start-end.
Extracting which reads are mapping to which fragments it is not possible to see in Decoil. However what you can do is:
samtools view -b input.bam "chr:start-end" > output.bam

Could you explain what you mean with target sequence?

Dear @madagiurgiu25, How could I interpret the column fragment_id in terms of coordinates such as 4633? I would like to determine which part of the sequence aligns with a specific genomic region, for example if it had been 100-500 position which align to chr1:100-600.

Dear @MJoseMo, The fragment_id is a code for numbering the genomic fragments in the graph. I understand what you are interested in, but based on decoil output you cannot do this. I think you would need to use samtools or equivalent tools.


smack fixes

Local networking under runqemu no longer worked because
/var/lib/connman/wired.config had wrong Smack labels.
The solution for that may also be useful for labeling all
files with security.SMACK64=_ explicitly, to overcome the
"swupd does not work with Smack enabled" problem.
The change triggers a mkfs.ext4 bug when multiple xattrs
are present, so this also gets fixed. Because the layer is
also used with older OE-core releases, e2fsprogs had to be
copied. It only gets used for older OE-core releases.
Disabling the "smack" distro feature did not really disable Smack in
the kernel.

@ipuustin can you review this?

I think this patch set looks good. I just had very minor gripes. +1

Force-pushed the revised commit with "install -d"

Re-tested again against latest OE-core master, which has the same e2fsprogs fix as this PR => no problem, merging.


Md5 enhance impl and test

fixes: https://github.com/Azure/azure-sdk-for-cpp/issues/1619
Updating Hash design to fix:
multi-thread support by not using a singleton handle for the hash

We also need to add tests for the edge cases listed in the issue.

We also need to add tests for the edge cases listed in the issue.

Tests are already there for the questions.
We throw invalid args and runtime error for the edge cases.
All I did was remove the static field from the Windows implementation and the void* from the general abstraction in favor or a unique_ptr


create notebook showing the workflow of model training

Yang added a notebook with an example of SciKit-learn model fitting


Documentation has broken paths

There are a number of broken links in the docs, as detected by marker:
Found absolute path    (benchmark hacking guide -> /hack/benchmark/) at ./Documentation/benchmarks/etcd-2-1-0-alpha-benchmarks.md:17
Found absolute path    (benchmark hacking guide -> /hack/benchmark/) at ./Documentation/benchmarks/etcd-2-2-0-rc-benchmarks.md:27
Found absolute path    (etcd v3 benchmark tool -> /tools/benchmark/) at ./Documentation/benchmarks/etcd-3-demo-benchmarks.md:17
Found broken path      (capnslog -> [https://github.com/coreos/pkg/tree/master/capnslog]) at ./Documentation/dev-internal/logging.md:3
Found absolute path    (TLS setup -> /hack/tls-setup) at ./Documentation/op-guide/clustering.md:81
Found absolute path    (here -> /hack/tls-setup) at ./Documentation/op-guide/security.md:7
Found absolute path    (benchmark hacking guide -> /hack/benchmark/) at ./Documentation/v2/benchmarks/etcd-2-1-0-alpha-benchmarks.md:17
Found broken path      (benchmark instructions -> ../../hack/benchmark/) at ./Documentation/v2/benchmarks/etcd-2-2-0-benchmarks.md:27
Found absolute path    (benchmark hacking guide -> /hack/benchmark/) at ./Documentation/v2/benchmarks/etcd-2-2-0-rc-benchmarks.md:27
Found absolute path    (etcd v3 benchmark tool -> /tools/benchmark/) at ./Documentation/v2/benchmarks/etcd-3-demo-benchmarks.md:17
Found broken path      (Procfile script -> ./Procfile) at ./Documentation/v2/README.md:76
Found broken path      (LICENSE -> LICENSE) at ./Documentation/v2/README.md:165
Found broken path      (persistent -> [https://en.wikipedia.org/wiki/Persistent_data_structure]) at ./Documentation/v2/api_v3.md:9
Found broken path      (b+tree -> [https://en.wikipedia.org/wiki/B%2B_tree]) at ./Documentation/v2/api_v3.md:21
Found broken path      (btree -> [https://en.wikipedia.org/wiki/B-tree]) at ./Documentation/v2/api_v3.md:25
Found broken path      (sequential consistency -> [https://en.wikipedia.org/wiki/Consistency_model#Sequential_consistency]) at ./Documentation/v2/api_v3.md:60
Found broken path      (linearized -> [#Linearizability]) at ./Documentation/v2/api_v3.md:62
Found broken path      (strict consistency -> [https://en.wikipedia.org/wiki/Consistency_model#Strict_consistency]) at ./Documentation/v2/api_v3.md:64
Found broken path      (serializable isolation -> [https://en.wikipedia.org/wiki/Isolation_(database_systems)#Serializable]) at ./Documentation/v2/api_v3.md:68
Found absolute path    (etcd/client -> /client) at ./Documentation/v2/clustering.md:399
Found absolute path    (here -> /hack/tls-setup) at ./Documentation/v2/security.md:7

The following two commits (in the master branch) correct the absolute paths. Please backport them to the next releases.
31c1931b7bc34c010c6bf4e5e1fccd3187130951
e0de6536c8532315fab307e42f42adcf37198cb6
The other broken links still exist in the master branch.

Ok, will backport those two commits to release-3.1 branch.
Thanks!


fixed uninitialized memory writing/reading in flann

KMeansNode is 48 byte structure, but sum of its fields sizes is 44 bytes. So, padded 4 bytes contain junk. We need to initialize the rest 4 bytes to eliminate valgrind warning when this structure is saved to file.

:+1:


Decaying gradient issue

Hi Matthias,
I am using GCNConv to solve a prediction task problem with linear layers at the output of the GNN. The model is trained on graphs of 10K nodes with ~20K-40K edges. The gradient value decays down to 0 after less than 10 epochs when training on these graphs and has an overall bad gradient flow during backpropagation. For reference, I have attached the code:
import torch
from torch.nn.parameter import Parameter
import torch.nn as nn
from torch_geometric.nn import GCNConv

class Model(nn.Module):
    def __init__(self, nin, nhid1, nout, hid_l, out_l=1):
        super(Model, self).__init__()

        self.gc1 = GCNConv(in_channels= nin, out_channels= nhid1)
        self.gc2 = GCNConv(in_channels= nhid1, out_channels= nout)
        self.lay1 = nn.Linear(nout ,hid_l)
        self.l0 = nn.Linear(hid_l,hid_l)
        self.l1 = nn.Linear(hid_l,hid_l)
        self.lay2 = nn.Linear(hid_l ,out_l)
        self.active = nn.LeakyReLU(0.1)

        with torch.no_grad():
            self.gc1.weight = Parameter(nn.init.uniform_(torch.empty(nin,nhid1),a=0.0,b=1.0))
            self.gc1.bias = Parameter(nn.init.uniform_(torch.empty(nhid1),a=0.0,b=1.0))
            self.gc2.weight = Parameter(nn.init.uniform_(torch.empty(nhid1,nout),a=0.0,b=1.0))
            self.gc2.bias = Parameter(nn.init.uniform_(torch.empty(nout),a=0.0,b=1.0))
            self.lay1.weight = Parameter(nn.init.uniform_(torch.empty(hid_l, nout ),a=0.0,b=1.0))
            self.l0.weight = Parameter(nn.init.uniform_(torch.empty(hid_l, hid_l),a=0.0,b=1.0))
            self.l1.weight = Parameter(nn.init.uniform_(torch.empty(hid_l, hid_l),a=0.0,b=1.0))
            self.lay2.weight = Parameter(nn.init.uniform_(torch.empty(out_l,hid_l),a=0.0,b=1.0))

    def forward(self, data):
        x, adj = data.x, data.edge_index
        x = self.active(self.gc1(x, adj))
        x = self.active(self.gc2(x, adj))
        x = self.active(self.lay1(x))
        x = self.active(self.l0(x))
        x = self.active(self.l1(x))
        x = self.active(self.lay2(x))

        return x

The gradient flow for the model is:

As it can be seen, the gradient falls steeply after the second GCN layer and doesn't improve upon later. Is there a way to improve the gradient values while training on these graphs?
Thanks for the help and wonderful library.

@rusty1s  It is a node regression problem that outputs a [n X 1] vector (each entry in the vector corresponds to a node). Removing the last activation didn't change anything and the gradient flow remains the same. Is the issue arising because of Batch Gradient Descent as here:    https://discuss.pytorch.org/t/very-small-lstm-gradients/59234/2?u=asgard

@rusty1s  It is a node regression problem that outputs a [n X 1] vector (each entry in the vector corresponds to a node). Removing the last activation didn't change anything and the gradient flow remains the same. Is the issue arising because of Batch Gradient Descent as here:    https://discuss.pytorch.org/t/very-small-lstm-gradients/59234/2?u=asgard

It might be possible that full-batch training leads to smaller gradient due to averaging, but I never noticed that in practice. You can try to add BatchNorm after each intermediate GCNConv layer to obtain better gradients.

It might be possible that full-batch training leads to smaller gradient due to averaging, but I never noticed that in practice. You can try to add BatchNorm after each intermediate GCNConv layer to obtain better gradients.


Render to Volume Texture

I'd like to do light propagation volumes in the near future. I've done an "offline" version that injects the lights on the CPU, propagates, and renders. I'd like to move up to real time light injection and propagation via a compute shader.
Could we get the ability to render to volume textures when it's capable? (OpenGL 3.x extension, OpenGL 4.x can do it stock, and DX11 can do it) I'm making an assumption it's not possible in bgfx at the moment, I could be wrong.
Additionally, I assume that compute shaders are able to read and write from volume textures at the moment?

Yeah I don't have way to specify slice for 3D texture when creating frame buffer.

Geometry shaders would be nice too =)


User course_id as region if region is None.

If we use decorator on a view where we need course specific sudo access then we need course_id.

@cpennington, @adampalay Please review this.

@cpennington If we don't do this then we have to call redirect_to_sudo() every where and we can't use sudo_required as decorator where we need course specific sudo access.


Remove components define that cannot be supported

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

what do you mean cannot support?

@wu-sheng EntityFrameworkCore's in-memory database does not have built-in diagostics api,  and a better way is to use the in-memory database provided by sqlite . so I don't plan to support EntityFrameworkCore in-memory database.

Cannot support for now or forever? From my perspective, removing some existed IDs is a very dangerous and un-recommended operations.

sqlite  is a difference component compared with EntityFrameworkCore's in-memory database. Right? So, you don't want to support it even after you have more powerfully C++ based codes injection tech?

You're right. It is not appropriate to remove existing IDS.

Coverage remained the same at 23.363% when pulling e2d9e266d3cc43f544b1de14c5ba2100b4e1246a on liuhaoyang:component into bb1efe5d60267c780f657dee56fa55d8fb288ce9 on apache:master.


IOProxyMixin helper class

IOProxyMixin helper class
When implementing a format-specialized derived class of ImageInput or
ImageOutput, now you can inherit from IOProxyMixin<ImageInput> or
IOProxyMixin<ImageOutput> that gives you the data members and many
convenience functions you'll need for using the IOProxy, without
needing to repeat it in every format plugin that supports proxies.
This coalesces some redundant code that would need to appear
separately in most of the plugins that support IOProxy, helps to
reduce cut-and-paste errors from having to make these changes
separately in many places, and centralizes the logic so that as our
ideas of how to implement IOProxy evolve, we can easily change it in
just one place and have it apply to all plugins.
Revise the JPEG and GIF IOProxy handling to use this new mixin class,
so you can see how it works, and the bits of redundant code that it
eliminates.
Also add IOProxy support to DDS input using the new mixin.

Abandoning. I had a better implementation idea.


Set Origin-Agent-Cluster on playground.lit.dev

This allows Chrome to use a separate process to run Playground iframes. This should improve performance overall, and will also prevent e.g. an infinite loop accidentally written by a user in the playground from locking up the entire site.
Demo:

Current site (observe the entire tab is unresponsive during spinlock).
This PR (observe the tab is still responsive during spinlock).

See https://github.com/PolymerLabs/playground-elements/pull/179 and https://web.dev/origin-agent-cluster/ for more context.
Fixes https://github.com/lit/lit.dev/issues/411

Is there a solution that can work on other browsers?

Neither Firefox nor Safari currently support out-of-process iframes at all (even with different-site).
Firefox does have experimental support behind a flag (about:config / fission.autostart) to switch on Project Fission, which adds support (https://wiki.mozilla.org/Project_Fission, https://bugzilla.mozilla.org/show_bug.cgi?id=1451850). I tested it out, and it works! There's also a bug filed to implement Origin-Agent-Cluster (https://bugzilla.mozilla.org/show_bug.cgi?id=1665474). Firefox does have a nice related feature, which is that after a minute or so of any page being blocked, it will prompt you to stop execution.
Safari doesn't seem to support out-of-process iframes at all, and I couldn't find any bug filed for it at https://bugs.webkit.org/ (but I definitely could have missed it).
I also was curious how Glitch works in these cases, and it's exactly the same as Playground will now behave (Glitch uses a different-site for the preview iframe): https://glitch.com/edit/#!/humdrum-aware-kitty?path=index.html%3A14%3A9

Would it be possible to make the refresh button save the user from a possible loop? Currently it seems that a full page refresh is required to get the preview to respond again.

I think we can detect a lockup like this:

Maintain a second prober iframe with the same origin as the preview, which serves a static document that simply acknowledges postMessage pings.
Ping the prober iframe every N seconds. If we don't get a response after some timeout, assume that the preview must have locked up that origin's process/thread.

From some experimenting, I don't think there is any way to kill the runaway process once it's started. It will lock up that origin until the parent window reloads. Even if the culprit iframe is removed from the DOM, the process continues running (so if you create a new iframe with the same origin, it will never load). Something to look into, and ask about!
Maybe the best we can do after detecting a lockup is to show an alert to the user with a button that saves the current playground state, and reloads the tab.
There is a "solution" I thought of, but it has its own fatal problem:

Set up wildcard DNS for *.lit.dev (or maybe register a new TLD for this purpose).
Use a sandbox origin like playground-0.lit.dev instead of the static playground.lit.dev we have now.
Every time we detect a lockup (using the prober iframe approach above), increment the number in the origin (e.g. playground-1.lit.dev) and re-initialize the project again on the new origin. The new origin should get a separate process

The big problem with this is that each runaway process would just continue in the background forever, so we'll end up consuming all CPU resources eventually. (Barring any interventions the browser might do to detect runaway processes? Firefox does actually prompt to stop processes after a minute or so).


Letter grade is set to None when grade is populated through a management command

Steps to Reproduce
Example course run grade id 43640.
I noticed that some grades are missing letter_grade value. We think that happens through the management command manage_certificates.  If is_grade_override is true then we set letter grade to None: [code here]
(https://github.com/mitodl/mitxonline/blob/2f951479e328c2a9f9d21d79f84fc3e04837ff43/courses/api.py#L871-L897)
Expected Behavior
If the grade is passing and enrollment verified we need an actual letter grade.
Actual Behavior
The learner is missing a letter grade.

When we pass a grade to the management command, we should require a letter grade (string) as well.

Example course run grade id 43640.

Solving this issue also requires doing a search for other missing letter grades and fixing them up. If the courses are DEDP courses, it's straightforward since they always use the same grading policy. If there are missing letter grades from other courses, we will have to look at their grading policy in Studio.

@pdpinch FYI.

Solving this issue also requires doing a search for other missing letter grades and fixing them up. If the courses are DEDP courses, it's straightforward since they always use the same grading policy. If there are missing letter grades from other courses, we will have to look at their grading policy in Studio.

This might be difficult in the sense that, a None letter grade in Django would not mean that it was only set by the override command. So, To reduce the scope, We can check those grades that are set_by_admin=True to back fill the data.
Also, Just to add more thoughts to what's already defined above:

I believe that the Letter grade from edX can have possible values (A, B, C, D, E, F, Pass, Fail, None)
So, along with the override management command, The grade can come as None from edX as well.
I think we'll need to update validation on letter grade as defined here in the PR
Usually, The Pass/Fail comes when there is a 50/50 grading policy set which is also the default in edX.

See some screenshots below:

@pdpinch @arslanashraf7 The problem we are having is not about all grades, but about grades that we have to show on the Program Records page. Those grades only belong to a program and those grades are only for certificate track learners. We need to have these letter be consistently A-F.

I'm OK with omitting the pass/fail option if it's a big lift. I think it's unlikely that we will need it. And I assume we can add it if/when we do.

@arslanashraf7 In what scenario would letter_grade come from edx as None?

Given that we don't have a clear direction with this, I will create a migration to populate only DEDP grades that were set by admin.

@arslanashraf7 In what scenario would letter_grade come from edx as None?

I believe that happened in cases when the completion of the course by the user is not done e.g. in a Self-paced course and in instructor-paced courses when the grades are not finalized and persisted.

We populated all DEDP grades and we set a restriction on the management command to provide letter_grade


How to access to same host and port as specified?

Hi @codekitchen.
I tried to get your tool working and it's works good except one issue!
First of thanks for this tool and it's has great performance, when disabling all config except VM, performance 4-x faster than Docker Desktop for Mac. This tool has very good performance (not as Linux, but only just 3.5x slower than Linux, not 10-12x, like Docker Desktop for Mac).
When i run my docker image with docker run -p 3000:3000 IMAGE_NAME, i should able to use port localhost:3000 from browser, but i'm cant. But available from DOCKER_IP:3000
Even i tried this docker run -h localhost:localhost -p 3000:3000 IMAGE, not available from localhost:3000.
If i enable DNS config from Dinghy preferences, i able to use IMAGE_NAME.docker from browser, but i need functioning this like Docker Desktop from Mac.
Used tool: docker, docker-machine, docker-compose, xhyve + docker-machine-driver-xhyve, dinghy
OS: macOS 10.15.1
Thanks you again for best tool!

Thanks. Dinghy does not forward ports from the VM to the host machine, so this isn't supported. It could theoretically be added using a mechanism similar to what Docker for Mac does, but it's not something I'm planning to work on myself.

Thanks, then currently my workaround is adding host like this DOCKER_IP docker.host!

Performance is very very great, preference editing well, clean and easy. I sure this project will get new users more than Docker Desktop over time.

ha, that's very kind of you but honestly I've been trying to deprecate this project for years. I push people to just use Docker Desktop when possible. :)  I'm sure their performance will continue to improve with time.

When i reported issue, they even didn't answered.
Horrible performance and bad optimized things, what their product works good only CLI (not always through) and your tool solves my problem, here i can show you how i able to save 2-3GB ram and improved performance by 20-25% on macOS Catalina.
Docker for Desktop:

Takes almost 20 second to startup on my machine
Can't configure less than 1GB ram
Docker for Desktop uses 300-500Mb ram + Uses almost 2GB hyperkit
Cant select driver
Limitation for macOS High Sierra (min OS)

Your tool:

Maximum 7-8 second, in most cases 3-4 seconds
Configuration is easy and able to configure use 512Mb RAM
Maximum ram usage is 800Mb. Only 800Mb
Able to use driver
Can be used on all macOS (i think it's possible)

Don't forget, not all developers can get powerful machine. Our task (i also developer) make it's possible for all users and you is one of people which helps users get latest and performant Docker with your tools FREE! We not required to change computer.
I think you understand what i mean.
Thanks again for tool.
Sorry for bad english


Shard storage of subgraphs

This PR makes it possible to store subgraph data in several database shards. The shards, their replicas and the rules for how subgraphs get deployed are configured in a TOML configuration file.
This changes the meaning of the node_id parameter of the subgraph_deploy JSON-RPC call: the node_id is only used as a fallback, and the rules in the configuration are consulted first to determine which node a subgraph should be assigned to.
The basic idea is that metadata is divided into store-wide metadata and per-subgraph metadata: store-wide metadata (subgraph, subgraph_version, subgraph_deployment_assignment, and deployment_schemas) is always stored in the primary, and deployment-specific metadata goes into the shard that holds the deployment data. The deployment_schemas table serves as a directory of deployments, and ensures that the internal id (sgdNNNN) of deployments is unique across all shards.
I am also subsuming PR #2021 into this one. This PR is on top of #2037 as it is expected that that will be committed before this PR. But the PR is ready for review in its current form.

Rebase onto latest master (after merging 2 commits from the original PR)

Rename all migrations so that they come after any migrations currently on master


How to use kprobe to generate code files?

I used the following command to create a project and selected kprobe:
cargo generate https://github.com/aya-rs/aya-template

I checked the kprobe example in the repository and found the binding.rs  file.
I don't know how to generate this file, what should I do to achieve the same effect?

This is my generated project directory：

I have the same question.


Migrate from circle to travis

I think circleci is not the best choice, and we need more different environments.
I did this PR for moving to travis.
Travis provides more different environments and it allows us to testings the propel for better quality
https://travis-ci.org/Big-Shark/Propel2
P.S. I could not understand how you update the codeclimate. Please add it yourself.

Well, we use circle because it is almost twice as fast as travis

The circle check only one environment, but Travis environment list a lot more, we can keep both, but you need a fix the settings for the circle

Yeah I see that argument. Let us use then both and keep circleci (because I like it more and it's faster). Could you please readd circleci stuff? :smile:

@marcj Done :)

@marcj we have any problems with that?

Looks cool, but I'd like to prefer that we include experimental platforms like mssql, oracle and sqlsrv in the filter>whitelist>exclude of each phpunit.xml, so it doesn't destroy our code coverage.

@marcj I added

cool, thanks :)

#1059


fixed Incomplete assert with unresolved generic dependency #172

Instead of
ZenjectException: Unable to resolve type 'Foo`1' while building object with type 'FooRequester'.
there is now
ZenjectException: Unable to resolve type 'Foo`1[Bar]' while building object with type 'FooRequester'.

Thanks!
Also, re: the questions in your issue, like @green-coder said, for simple fixes/tweaks, you can directly send a pull request.  For larger scale changes, it might be a good idea to discuss beforehand in the gitter chage


⚠ Bofrost.es has degraded performance

In 5cda325, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1468 ms

Resolved: Bofrost.es performance has improved in 009800e after 6 minutes.


Update CODEOWNERS

We are going through the list of codeowners errors and reassigning codeowners to teams identified by execs that have gone through the list.

Additionally, we're only using the rack-version branch, which is built off the 2.4 version, not master

Additionally, we're only using the rack-version branch, which is built off the 2.4 version, not master. We don't utilize pull requests or merges, we just reference specific commits, see where this is used here: https://github.com/circleci/circleci.com/blob/main/Gemfile#L19

The idea here is to have the right values in Master so that our security tools can correctly assign the Jira to the right team. 🙂  it's all good if you don't use it, it's mainly for our tooling 😄

Updated and ready for a review 😄


Change primary color attribute in theme

Thanks for all your efforts on the development of this theme.
I am using the latest version of the them. In the theme settings default.toml (copied to create a custom theme), I updated the "primary" attribute, and see this update the "network-icon" field on the page for both light/dark accordingly. However, I do not see "primary_light" and "primary_dark" not affect the appearance of the elements.
In academic.css I do not see any color attribute i.e primary associated with the network icon field, is there a way I can change this to toggle based on dark/light?

You can create a CSS plugin with your custom CSS:
https://sourcethemes.com/academic/docs/customization/#customize-style-css
It can be used to override Academic's styles. For light theme style, define .<SELECTOR-NAME> {...}. For dark theme style, define .dark .<SELECTOR-NAME> {...}.

What is the value of . for network-icon?

As a quick update, @rajesh-s I was able to get the featurette icon color changed in the dark mode by using the code code you provided. I placed the css file in assets/css and changed the param.toml plugin_css to the name of the css file.


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Vasal Kesarwani

Discord Username(if exists): vatsal kesarwani

Additional Context:

youtube

I am an open-source lover and want to learn with Eddie. I want to learn with the beautiful community built by Eddie.
:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


Dump file are empty

Thank you for this project. I been working on this app quite sometimes, but still unable to figure out it.
I try to run dump-on-server.js without make any changes:
frida -U -f <package_name> -l dump-on-server.js
Output:
Error: libreactnativejni.so: unable to find export '_ZN8facebook5react22isHermesBytecodeBundleERKNS0_12BundleHeaderE'
    at value (frida/runtime/core.js:250)
    at get_addr (D:\frida\script2.js:119)
    at hookLibrnjni (D:\frida\script2.js:41)
    at onLeave (D:\frida\script2.js:109)

File /storage/emulated/0/Download/index.android.bundle are empty. Maybe because _ZN8facebook5react22isHermesBytecodeBundleERKNS0_12BundleHeaderE do not exist, so I changed it to _ZN8facebook5react16NativeToJsBridge20getJavaScriptContextEv.
Output:
[*] Installing hook for libandroid.so @ 0x75e653447000
[*] Installing hook for libreactnativejni.so @ 0x75e5d64a0000
[*] isHermesBytecodeBundle called
[*] bundle size: 0
[*] Writing bundle to /sdcard/Download/index.android.bundle_1734393595030
[*] Successfully wrote bundle to /sdcard/Download/index.android.bundle_1734393595030
[*] AAssetManager_open index.android.bundle
[*] AAssetManager_open js-modules/UNBUNDLE

Same, the "/sdcard/Download/index.android.bundle_1734393595030" are empty.

If you don't mind, please take a look at this app: https://file.io/8BgbAUpBvEk6

Hi @zayne-anyra, seems like the app you are dealing with does not encrypt its index.android.bundle file.
$ file my-digi-14-0-8/assets/index.android.bundle
my-digi-14-0-8/assets/index.android.bundle: Hermes JavaScript bytecode, version 84

Hence, you could directly analyze the file without dumping it.

I though Hermes bytecode was kind of encryption/obfuscation. it kinda confuse, I already disassemble it using hbctool, but it quite hard to get it done.
is it possible to dump the hermes .bundle than see what method or function been use?

Perhaps you could take a look at this tool hermes-dec. Although it could decompile the Hermes bytecode into JavaScript code, you still need to analyze the code pattern as the control flow is not apparent.

yeah its been a while I'm working on this project but still got no progress 🙃.  ie, in that bundle file contains "encrypt" function, how can I hook at this function? is it possible?