Unique Column Names "Error" Option

In {columns:true} no error is thrown with non-unique column names.  Results in silent overwrite of data during parse with last duplicate column name winning.  Would be helpful with dirty data sources.

could you prepare a pull request or at least at test or sample illustrating the expected behavior?

For sure:
var csv = require('csv');
var output = [];
var parser = csv.parse({
	delimiter: ',',
	columns: true
});
parser.on('readable', function() {
	let record = parser.read()
	if(record !== null){
		output.push(record);
	};
});
parser.on('error', function(err) {
	console.log(err.message);
});
parser.on('finish', function() {
	console.log(`"header_1" equals "${output[0]['header_1']}"`); //"Header_1" equals "false"
        //Overwrites "header_1" in column 1.  Propose "uniqueHeader" option to
       //go with "{columns:true}" that would throw Error.
});
parser.write("header_1,Header_2,header_1\n")
parser.write("true,value,false\n");
parser.end();

If I undestood well, you're proposing to keep the current behavior by default and to add an option "uniqueHeader" to detect overlapping headers?

Yes sir.  I was thinking an opt-in addition as to avoid any breaking
changes.  The behavior as it is might being utilized intentionally as away
to de-dup duplicate headers.
Respectfully,
Michael
On Tue, Mar 15, 2016 at 4:47 PM, Worms David<EMAIL_ADDRESS>wrote:

If I undestood well, you're proposing to keep the current behavior by
default and to add an option "uniqueHeader" to detect overlapping headers?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/wdavidw/node-csv-parse/issues/80#issuecomment-197057395

--
Michael Price Films
918-694-3081

do you feel like preparing a pull request?

Absolutely, I was planning on it.  I've not used coffee script before, so
I'll need a beat to familiarize myself with the syntax seems pretty
straight forward.  I've forked the project. I'll put it in as soon as I can.
Respectfully,
Michael
On Wed, Mar 16, 2016 at 11:25 AM, Worms David<EMAIL_ADDRESS>wrote:

do you feel like preparing a pull request?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/wdavidw/node-csv-parse/issues/80#issuecomment-197442276

--
Michael Price Films
918-694-3081

be welcome to ask questions in case of any doubts. i will also accept plain js pull request, in which case i'll convert it to coffee.

Closing due to lack of activity. Feel free to open a new issue to initiate a new discussion on this topic.

It would be really useful to know if the input file has duplicate (or blank) column names.
Ideally, the info object would list the duplicate column names.  Or optionally set it to throw an error in that event.
The solution in #285 to catenate the values really clever and useful for some applications.
But here my goal is to preview a CSV file to infer data types, etc. before importing into SQL databases, and duplicate column names are often not handled by the RFC4180 CSV parsers implemented natively in relational databases.

As I understand it, there are 2 requests:

An option to guaranty the absence of duplicate columns, eg columns_duplicates_strict:

parse(
  'a,b,a\n1,2,3\n4,5,6',
  {columns_duplicates_strict: true},
  (err, records) => {
    err.should.eql({
      code: 'CSV_DUPLICATE_COLUMNS',
      message: 'column `a` is defined at multiple index, got 0, 2'
    })
  }
)

Get columns information in the info object

parse(
  'a,b,a\n1,2,3\n4,5,6',
  {info: true},
  (err, records) => {
    records.map(({info}) => {
      info.columns.should.eql(['a', 'b', 'a'])
      info.duplicate_columns.should.be.True()
    })
  }
)

Is this right ?

@wdavidw  Thanks for the lightning reply on an open source project.  My goal is to identify whether there are duplicate columns, and if possible, which they are.   For this It would be sufficient to, say, query the info object to get a list of (raw, not deduplicated) column names, and the client code could decide how to test and handle the existing of duplicate or blank column names, such as throw an exception or what ever.

What if you call the parse twice and the first time, you dont pass columns, limit the number of records to 1 with to or to_line and eventually get the raw record ? The first call will be fast since it will stop on the first record. Something like (not tested) require('csv-parse/lib/sync', parse(data, {to: 1, raw: true})).


feat(api-usage): add environment variable to prevent API usage tracking.

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Adds an environment variable which controls whether API usage data is tracked.
Closes #2580.
How did you test this code?
Ran the docker compose file locally with the following settings:
      USE_POSTGRES_FOR_ANALYTICS: 'true'
      ENABLE_API_USAGE_TRACKING: 'false'

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (16e6a28) 95.93% compared to head (f31eb1a) 18.04%.
Report is 4 commits behind head on main.

Files
Patch %
Lines

api/app/settings/common.py
66.66%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3386       +/-   ##
===========================================
- Coverage   95.93%   18.04%   -77.89%
===========================================
  Files        1077      996       -81
  Lines       32944    28721     -4223
===========================================
- Hits        31606     5184    -26422
- Misses       1338    23537    +22199

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[PyGrid-0.4.0] Testing Report

Description
I've been troubleshooting the deployment and configuration of a PyGrid domain in AWS. Here report all the bugs and unexpected behaviours I could identify.

Right after deploying the domain I hit POST /users  to create an Owner (owner@openmined.org). I could login with that user and make requests. Worked fine from the UI.
Then, I hit GET /setup  and got a 400 saying there was no existing initial setup.
I called POST /setup and send by the fields user, password and node_name. Got 200.
I then realised that the POST /setup had also created another user<EMAIL_ADDRESS>, which was also set with role Owner. This means that I had two distinct user accounts with Owner roles.
I went ahead and call again POST /setup with the same arguments to see what happens when I try to run the initial setup when already exists. It created another user with the same email and Owner. I then had two accounts under  the same email address and all of them Owner.
I called again POST /users and try to create another Owner account. I got 403

How to Reproduce

Deploy to AWS
Follow the notes by order and hit the endpoints

Expected Behaviour
Notes on what I understand is a bug on the above:

I should get 403  when trying to create a User ( whatever role is ) before the initial setup has been undergo
The Initial Setup created an Owner user ( this is fine ) even though there already existed an Owner user because of step 1. This bug is caused because of the first bug where we created a user without undergoing the Initial Setup
Subsequent calls to POST /setup shouldn't go through since it already exists.  This endpoint might be changed to PUT /setup to update parameters only.
Two accounts with the same email address shouldn't exist.

Screenshots

Closing this Issue now. Resolved in #829


Allow KO_CONFIG_PATH to be a file

Fixes #245

Codecov Report

Merging #731 (4f42b7c) into main (1a5551d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

:exclamation: Current head 4f42b7c differs from pull request most recent head aeede97. Consider uploading reports for the commit aeede97 to get more accurate results

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   51.30%   51.42%   +0.11%
==========================================
  Files          44       44
  Lines        3286     3292       +6
==========================================
+ Hits         1686     1693       +7
+ Misses       1389     1388       -1
  Partials      211      211

Impacted Files
Coverage Δ

pkg/commands/options/build.go
71.42% <100.00%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5551d...aeede97. Read the comment docs.


Remove call to user.Current which doesn't work on Windows Nano

What does this PR do?
Until now, we had a call to user.Current() plus an alternative code path since user.Current() might fail if it can't get all the user info. In Windows Nano, however, user.Current() plain crashes the program (see linked golang issue below).
Since we already had alternative code in place, and given the fact that we only need the user SID from user.Current(), this replaces the call with the simpler alternative code.
Also it removes some debug prints that we weren't actually checking to debug anything.
Motivation
Workaround golang incompatibility with Windows Nano: https://github.com/golang/go/issues/21867

Unfortunately this is not enough, as many of our dependencies also call user.Current() (specially many related to k8s, which is where it would be most beneficial to use Windows Nano...)

I've managed to run a build of the Agent on Windows Nano after bumping klog :D


New deadline form

Task

[ ] Implement form in new deadline modal that includes validation.
[ ] Register new deadline in backend on submit
[ ] Handle errors and loading states

I'm working on this


continueConversation() does not match the C# SDK

In the C# SDK, ContinueConversation takes the bot's ID as a parameter, which is "critical to the BotFrameworkAdapter which is multi-tenant aware" (from here):
public virtual Task ContinueConversation(string botId, ConversationReference reference, Func<ITurnContext, Task> callback)

continueConversation in this Node SDK does NOT take the bot's ID as a parameter (from here):
public abstract continueConversation(reference: Partial<ConversationReference>, logic: (revocableContext: TurnContext) => Promiseable<void>): Promise<void>;

The BotId should be in the conversation reference. It's reference.bot.id. Is there another Bot Id you're looking for?
It's a valid point that they're out of alignment.

I assume it's wanting the app ID, based on some of the C# samples that retrieve it:
// The BotFrameworkAdapter sets the identity provider on the context object.
var claimsIdentity = context.Services.Get<IIdentity>("BotIdentity") as ClaimsIdentity;

// For requests from a channel, the app ID is in the Audience claim of the JWT token.
// For requests from the emulator, it is in the AppId claim.
// For unauthenticated requests, we have anonymouse identity provided auth is disabled.
// For Activities coming from Emulator AppId claim contains the Bot's AAD AppId.
var botAppIdClaim =
    (claimsIdentity.Claims?.SingleOrDefault(claim => claim.Type == AuthenticationConstants.AudienceClaim)
    ?? claimsIdentity.Claims?.SingleOrDefault(claim => claim.Type == AuthenticationConstants.AppIdClaim));

But the C# sample also has notes like this

The GetAppId method is a work around to enable proactive messaging in the .NET SDK.

so now I'm unsure which SDK needs to match the other.

So the real issue is the C# SDK supports multiple bots from within a single adapter which is why they need that ID passed in. The thing is it's rare that you will ever have multiple bots so the Node SDK just has you create a new adapter for each bot. I believe the plan is to change the C# SDK to work the way the Node SDK works. Not the other way around.


The app display blank after upgrade Blazor version 0.3.0

Hi team,
My SPA app stops working and displays a blank page after upgrade to Blazor version 0.3.0. Could you help advise is there any configuration or additional migration steps required for upgrade to v0.3.0?
Repo: https://github.com/Swastika-IO/Swastika-IO-Admin-Blazor
Thanks.
Huy

You have to do some steps to upgrade.
https://blogs.msdn.microsoft.com/webdev/2018/05/02/blazor-0-3-0-experimental-release-now-available/
See "Upgrade an existing project to Blazor 0.3.0" section.

Install all of the required bits listed above.
Update your Blazor package and .NET CLI tool references to 0.3.0.
Remove any package reference to Microsoft.AspNetCore.Razor.Design as it is now a transitive dependency.
Update the C# language version to be 7.3. You may need to restart Visual Studio for this change to take effect.
Update component parameters to not be public and to add the [Parameter] attribute.
Update layouts to inherit from BlazorLayoutComponent and remove the implementation of ILayoutComponent including the Body property.

Thanks @SIkebe let me try again then keep you posted.


Metric Revision (name change) - Code Changes Commits

Is this issue (#423) different from #422?
Signed-off-by: Armstrong<EMAIL_ADDRESS>


[AMQ-9234] Remove JournalJDBC store and activeio dependency

Notes for reviewers:

JournalPersistenceAdapter is from ActiveMQ 4.x era
useJournal = false flag is transition feature to return the JDBCPersistenceAdapter
Unit tests that are journal-only were removed
Unit tests that are other were updated to kahaDB
activeio is only used by the journalJDBC persistence adapter
activeio is not maintained anymore and should be removed

A mostly complete list of the unit tests impacted
./src/test/java/org/apache/activemq/console/command/PurgeCommandTest.java
./src/test/java/org/apache/activemq/console/command/AMQ3411Test.java
./src/test/java/org/apache/activemq/console/command/AMQ3410Test.java
./src/test/java/org/apache/activemq/perf/InactiveDurableTopicTest.java
./src/test/java/org/apache/activemq/perf/InactiveQueueTest.java
./src/test/java/org/apache/activemq/usecases/PublishOnQueueConsumedMessageUsingActivemqXMLTest.java
./src/test/java/org/apache/activemq/usecases/PublishOnTopicConsumerMessageUsingActivemqXMLTest.java
./src/test/java/org/apache/activemq/xbean/XBeanStartFalseTest.java
./src/test/java/org/apache/activemq/xbean/MultipleTestsWithXBeanFactoryBeanTest.java
./src/test/java/org/apache/activemq/xbean/XBeanXmlTest.java

Journal webpage notes: https://activemq.apache.org/persistence

Note: rebased to pull in 5.19.0-SNAPSHOT version


Usage of FsControl makes VSCode + Ionide slow

Just a subjective observation.
Since I switched to FsControl and the usage of its operators Ionide tooltips and code suggestions have become pretty slow.

Your observation is not that subjective, it is slow since it relies in overload resolution which in the current version of F# is really slow.
Here's a proposal to make it faster, hopefully it will be accepted for F# 4.1
So this is in fact an F# compiler issue.

interesting. I hope your PR will be merged and I only have to wait for V 4.1 and the mono binary drop. Can only be a few more month ;-)

@robkuz it was just merged today :)


Uploaded Pannellum on server now what?

No matter what file i look at i can't recreate this below on my own server
https://cdn.pannellum.org/2.5/pannellum.htm#panorama=https://pannellum.org/images/alma.jpg
You tell me to use your CDN on the tutorials which is self defeating i want the files on my server, the directories also appear all wrong, i'm told to use /2.5/ # code assistance when my # directory assistance is /pannellum-2.5.6/ i'm told to use /images/ folder when there is no such directory on the tutorial files, i'm provided an examples directory instead
All i want to do is place your files on my server and have it load instead i'm provided a jargon of rabble. What is the directory location to load my example Panorama on my server, the tutorials here are telling me to use your cdn, this is not helpful i want to use the files on my server https://cdn.pannellum.org/2.5/pannellum.htm#panorama=https://pannellum.org/images/alma.jpg

https://cdn.pannellum.org/2.5/pannellum.htm#panorama=https://pannellum.org/images/alma.jpg
How do i recreate this on my server
.
I can't locate /pannellum-2.5.6/pannellum.htm, i can't locate anything frankly

I had to use the other folder it appears, there wasn't any mention of this in the tutorial. I had to add Minified standalone viewer to my server also it appears


⚠ PrivateHD has degraded performance

In 89d24ec, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3008 ms

Resolved: PrivateHD performance has improved in 29e5f60.


Change version selector to retain current page when switching versions (for website v1.13)

Fixes https://github.com/kubernetes/website/issues/19340 for version 1.16 of the website
(Additional PRs will be issued for other versions)

/assign @tengqm

/lgtm
/approve


[BUG]-DeviceManager.AddDevice() potentially unsafe

Describe the bug
If you happen to call DeviceManager.AddDevice() in a PreActivate/CustomActivate/PostActivate it will throw an Exception since you are trying to add to the Devices dictionary while currently iterating through it in the DeviceManager.ActivateAll() method.  This causes the base ControlSystem.Initialize() method to fail leaving everything in an inconsistent state.
Stacktrace
[08:20:18.000]App 2:FATAL INITIALIZE ERROR. System is in an inconsistent state:
System.InvalidOperationException: InvalidOperationException
at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
at System.Collections.Generic.Dictionary`2.ValueCollection.Enumerator.MoveNext()
at PepperDash.Essentials.Core.DeviceManager.ActivateAll()
at PepperDash.Essentials.ControlSystem.Load()
at PepperDash.Essentials.ControlSystem.GoWithLoad()
at PepperDash.Essentials.ControlSystem.InitializeSystem()
at Crestron.SimplSharpPro.CrestronControlSystem.InitializeSimplSharpProApplication()
at Crestron.SimplSharpProInternal.SimplSharpProManager.LoadSimplSharpProApplication(String moduleFileName)
at Crestron.SimplSharpProInternal.SimplSharpProManager..ctor(UInt32 appNumber, String simplSharpProAppName, UInt32 flags, Boolean& badExit)
at Crestron.SimplSharpProEntry.b(String[] A_0)
To Reproduce

Call AddDevice() in any of the methods: PreActivate/CustomActivate/PostActivate
If you call CommFactory.CreateComForDevice() it adds the comm port to the device manager, throwing an error

Expected behavior
Two possible solutions,

Add the following which should iterate through a copy of the Dictionary as opposed to the original collection.

// PreActivate all devices
            foreach (var d in Devices.Values.ToList())
            {
                try
                {
                    if (d is Device)
                        (d as Device).PreActivate();
                }
                catch (Exception e)
                {
                    Debug.Console(0, d, "ERROR: Device PreActivation failure:\r{0}", e);
                }
            }

Block the AddDevice() method from adding to the collection once the Activation phase has started because presumably we don't want to add any devices mid-activation.

Screenshots
Additional context

What's the intention behind adding devices to the Device Manager in this manner?

There really shouldn't be I wouldn't think... but it is common for devices to instantiate add other devices to the DeviceManager, its just typically been done in the constructor.  If we don't want to be adding devices once the Activation phase starts, we should at least throw an error instead of failing the entire Initialization method and putting the proc in a failed state

I just went through and added a CCriticalSection to the DeviceManager class, and added it to pretty much all the methods in the class. Not sure there's any reason to really send a message, but that could be done relatively easily. Try alpha-165 when it's posted and see if it at least keeps the exception from happening.

@ndorin and I discussed this. We've gone through and added a critical section and used it in any methods that modify the DeviceManager dictionary. We've also added a public boolean field called AddDevicesEnabled. Once the activation sequence has run, this will be set to false. If the AddDevice method is called after the activation sequence is complete, a message indicating that adding devices isn't allowed will be printed to console and logged in the error log. Please test this with build alpha-166 when it's available.

Will do, thanks for looking into it!


SSize

I would like to have a module to manipulate the POSIX type ssize_t, there is one in Unsigned for Size_t, but no SSize_t counterpart in Signed.
I'm not sure what is the best way to add it, hence the issue. Thanks!

I think that the analogue of what we do for size_t (which we define in terms of one of the unsigned types using first-class-modules) is the right approach, except that ssize_t belongs in PosixTypes, not Signed.
We should do the same for ptrdiff_t, which does belong in Signed.


Importing Multiple URLs

Hello, Is it possible to import from multiple source URLs?

IMPORTJSONAPI takes care of a single API call.
If you want to blend data from mutliple sources I'd suggest making a sheet for each source, and then use another sheet to aggregate the data from the different sources.


ci: migrate auto approve github actions

use this instead: https://github.com/AwesomeHamster/actions-auto-approve

ref: https://github.com/AwesomeHamster/koishi-plugin-hitokoto/pull/18


Use of APP_ADMIN_URL env variable in installer for admin URL

Description
In the installer file (packages\Webkul\Installer\src\Console\Commands\Installer.php), a static /admin url path is implemented despite the availability of environment variable APP_ADMIN_URL, which is not being used to show the admin url after installation.
How To Test This?

Branch Selection

[ ] Target Branch: master

Hello @ariabid
Thank you for your contribution. Please create a pull request on the 2.2 branch.

Hi @amit-webkul
I've created a pull request on the branch - 2.2
https://github.com/bagisto/bagisto/pull/10150
https://github.com/bagisto/bagisto/pull/10150


release-4.0: update openssl-src of proxy to fix CVE-2023-0286

What problem does this PR solve?
Issue Number: close  #6903
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/rebuild

/run-integration-test

/rebuild

/run-integration-test

/run-integration-test

/rebuild

/run-integration-test


Add tilt and timing performance attribution. Also respect time range

Fixed the pyfolio thing in https://github.com/quantopian/pyfolio/pull/608.


s3 cloud provider file existence

Fix: #69
Hey, @Sammyjo20 I've not tested this, but made changes from comments made by 'danmatthews'.
Context:
ISSUE
ISSUE

Thanks for this @ajuchacko I'm going to re-review this issue and if this PR is needed, we can re-open.


Use a dedicated type for PoET proof ref

Motivation
This PR presents a practical use of leveraging a type system to increase code readability, the expressiveness of APIs and to prevent API misusage.
The idea is to use a dedicated "new" type instead of a generic primitive (for example use type PoetProofRef []byte instead of []byte). Some of the benefits are:

It is clear what a variable "is for" - this information is embedded in its type. For example, it is immediately clear what a PoetProofRef is for, in contrast to []byte. Consider an example interface: https://github.com/spacemeshos/go-spacemesh/blob/develop/activation/interface.go#L12-L16. It's hard to tell what is expected to be passed as an argument exactly.
It limits the usage of a given type of variable throughout the program. It is easier to understand where it comes from and what can be done with it (IDE's features like find all references begin to be helpful).
~It prevents mistakes of passing a wrong thing to some API at compile time. It takes the burden of questioning "Am I passing the right thing to this function?" from the developer and moves it to the compiler.~

Some cons:

it might require adding some "glue" casts here and there where APIs are not fully compatible (not 100% ported to use the new type), this especially manifests in tests. On the other hand, having to do an explicit cast should trigger thinking if one is doing the correct thing, to begin with.
When used too much and without thinking, it might actually reduce the readability of the code.

Edit: I realized that Go actually allows for implicit conversions so the 3rd point is invalid :(
Changes
Replaces usage of []byte with a new type type PoetProofRef []byte where applicable.
Test Plan
unit tests
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors merge


Lack of Email Address Input Validation on privacy-request/notification API Endpoint

Bug Description
The Fides API allows to define alerts which in case of some errors in processing send proper notifications to recipients. The API was found to not validate the email addressed on the backend, thus it can potentially result in uncaught errors and unexpected notifications failures.
Steps to Reproduce
API Request
PUT /api/v1/privacy-request/notification HTTP/2
Host: <redacted>.ethyca.com
Content-Length: 68
Sec-Ch-Ua: "Not:A-Brand";v="99", "Chromium";v="112"
Unescape-Safestr: true
Sec-Ch-Ua-Mobile: ?0
Authorization: Bearer eyJh<redacted>
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.5615.50 Safari/537.36
Content-Type: application/json
Access-Control-Allow-Origin: *
X-Fides-Source: fidesops-admin-ui
Sec-Ch-Ua-Platform: "Linux"
Accept: */*
Origin: https://<redacted>.ethyca.com
Sec-Fetch-Site: same-origin
Sec-Fetch-Mode: cors
Sec-Fetch-Dest: empty
Referer: https://<redacted>.ethyca.com/privacy-requests
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.9

{"email_addresses":["INVALID ADDRESS1","INVALID ADDRESS2"],"notify_after_failures":1}

API Response
HTTP/2 200 OK
Date: Wed, 16 Aug 2023 09:04:37 GMT
Content-Type: application/json
Content-Length: 85
Server: uvicorn
X-Ratelimit-Limit: 1000
X-Ratelimit-Remaining: 998
X-Ratelimit-Reset:<PHONE_NUMBER>
Retry-After: Wed, 16 Aug 2023 09:05:12 -0000
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: https://<redacted>.ethyca.com
Vary: Origin

{"email_addresses":["INVALID ADDRESS1","INVALIDADDRESS2"],"notify_after_failures":1}

Expected behavior

The request should be rejected with an error when the invalid email address fails input validation.
Implement input validation and consider adding a test notification feature to verify the settings are working correctly.

Screenshots
n/a
Environment
Version: 2.18.0 (repro'd on nightly 2.21.0rc0.post0.dev22)
OS: Kubernetes (AWS EKS v1.27.3-eks-a5565ad)
Python Version: 3.10.12
Docker Version: containerd://1.6.19
Additional context
n/a

Please assign this to me. Also, can you please add the label "hacktoberfest". ?


Docs: Add Expand / Collapse tags to unfold icons

Description
Docs: Add Expand / Collapse tags to unfold icons
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Approved by Zach Ward


Remove dependency on a pre-created jar for running unit tests for JarFileUtils

The current unit tests for JarFileUtils viz., JarFileUtilsTest relies on a pre-created jar. We should be leveraging something such as https://github.com/shrinkwrap/shrinkwrap to have the jar generated at runtime for the tests to use.
The source code for the testng-tests.jar is being attached as well.
testng-tests.zip

Here I attched what I have updated for testng-tests for #1635
testng-tests.zip


Safe Browsing

Any plans on adding a Safe Browsing API (Example Googles API), While Ddg has good privacy features it would be nice to see some security behind the browser, especially as it built off WebView.

https://ci3.googleusercontent.com/proxy/TPdfc_lIDXbTnNdrn6nCRslk1u0BDbLhPD2JgEbNebqf3Egzwxo5cY6U6Jb5ECh1fs_uxoLAC5PelpPSkYkxXfWbre5ZFesB8NDyBrWA9OAeeapYYIWbkDBjZ_G6=s0-d-e1-ft#https://cdn.bonnerandpartners.com/BBD/signatures/bill-bonner-signature.png

Please use our GitHub templates so we can understand better your request. Thanks.

Please use our GitHub templates so we can understand better your request. Thanks.


Why showing this “Papertrail is a legacy winston transport. Consider upgrading”

I am using Winston version
"winston": "^3.2.1",
"winston-papertrail": "^1.0.5"

When I add
transports: [ new winston.transports.Papertrail({})]
I get
Papertrail is a legacy winston transport. Consider upgrading: - Upgrade docs: https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md
why this message show and how do I stop showing this.

The master branch is a legacy transport for winston3. There is a v2 branch that is implemented in winston3 format. You can install it:
npm install https://github.com/kenperkins/winston-papertrail.git#v2 --save

The readme that you can find here details setting up for Winston3.


BEANUTILS-541 - FluentPropertyBeanIntrospector caches corrupted writeMethod (1.x)

https://issues.apache.org/jira/browse/BEANUTILS-541
Backport #68 for 1.x

@garydgregory I see that you have some activity in this project. WDYT finally review real issues with value? I mean these two:

https://github.com/apache/commons-beanutils/pull/69
https://github.com/apache/commons-beanutils/pull/68

Current implementation has a severe issue. If you think this project does not deserve meaningful changes, please let me know so I would not waste time on these efforts.

Hello @seregamorph
Thank you for the reminder, please rebase on git master to pick up the new GH workflow.

The branch is rebased. Please note this this change is just a backport of
https://github.com/apache/commons-beanutils/pull/68


Fix a typo: CVS -> CSV

BATCH SCORING PULL REQUEST
This is a pull request into a public repository for Batch Scoring script maintained by DataRobot.
RATIONALE
CHANGES
TESTING

Coverage remained the same at 84.047% when pulling 3a3019d578e136361630c07c588c05f2eeabdeff on kleschenko-patch-1 into 13da21e813da3e757526b9c51f7dd1fe2b224603 on master.


Correction for raw affiliation Eco&Sols, Univ Montpellier, IRD, INRAE, CIRAD, Montpellier SupAgro, Montpellier, France

Correction needed for raw affiliation Eco&Sols, Univ Montpellier, IRD, INRAE, CIRAD, Montpellier SupAgro, Montpellier, France
raw_affiliation_name: Eco&Sols, Univ Montpellier, IRD, INRAE, CIRAD, Montpellier SupAgro, Montpellier, France
new_rors: 051escj72;05kpkpg04;003vg9w96;05q3vnk25;03rnk6m14;00b80ez59
previous_rors: 051escj72;05kpkpg04;003vg9w96;05q3vnk25;03rnk6m14
works_examples: W4402492788
contact: 0b6bc30470aee895608aec8d01bd12bf:88b5a0f3fa191e6202a984402ee4971f9fce @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


MySQL/MariaDB - ROLLBACK not working

Hello, i have an issue using a typical MySQL/MariaDB 'START TRANSACTION' statement.
I'm using 'SET autocommit = 0' to disable autocommit (works well)
and then a 'ROLLBACK', wich looks to have no effect in Azure Data Studio :-/
I also tryed my script with some other IDEs, and it works fine on both MySQL and MariaDB (see attached).
MariaDB__AUTOCOMIT-COMMIT-ROLLBACK.sql.txt
Did i missed something with Azure Data Studio connection settings or is that a bug on the connector ?
Regards

Thanks @Jay-UdS for reporting this. This is a bug on the connector. Will be fixed in the next release.

Hello, have you got any information about a possible bugfix ?
Best regards

@Jay-UdS we are planning a new release soon, it will be fixed in that.

Thanks @nitishsharma25

@Jay-UdS  meanwhile, you can install Azure Data Studio-insiders and use mysql extension there, we have released the latest version there.

@Jay-UdS We have released the latest version 0.2.6 with this fix.


feat(msw): split polymorphic mocks into its own functions

Status
READY
Description
Fixes #1318
This splits response mocks where the response contains objects that have a base object.
The specification in the linked issue is an example of a response mock that will get split.

Todos

[ ] Tests
[ ] Documentation
[ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Generate using a specification that contains a allOf prop, e.g. the one in the linked issue.
Notice that the response mock contains calls to functions that has been generated above.
Notice that no errors exists

@AffeJonsson
A conflict occurred when I merged the following PR. Could you please check again and correct it?
https://github.com/anymaniax/orval/pulls?q=is%3Apr+is%3Aclosed

@AffeJonsson
A conflict occurred when I merged the following PR. Could you please check again and correct it?
https://github.com/anymaniax/orval/pulls?q=is%3Apr+is%3Aclosed

Merged master and did a small update to make overrideResponse param Partial, just like the new overrideResponse code

Maybe wait with this until #1199 is complete? I assume we might need to change this when it is completed anyway

@AffeJonsson
No, they says it will take time, so we unnecessary wait. And. I'll share it to they.
I would like to check this PR, but please forgive me if it takes a little more time.

it would make sense to regenerate samples
example in screenshot has overrideResponse twice 🤔
...overrideResponse
// some faker
...overrideResponse

it would make sense to regenerate samples
example in screenshot has overrideResponse twice 🤔
...overrideResponse
// some faker
...overrideResponse

This is no longer the case after your PR was merged, only one overrideResponse is now present

Seems I broke tests with this, fixing...

@AffeJonsson Please let me know when this is ready for me to review 👍

It's ready!


Fix state handling after rotation with different anchor points

If you set the anchor point to

1.0f in landscape
0.6f in portrait for instance

Then the state in landscape, when the panel is open, is saved as extended.
After the rotation, it will appear extended again but it should be anchored as the anchor point is 0.6f.

After Talking with David, we linked the issue here to an issue in the sliding panel library.
We decided not to fork as this was minor.

Thank you for your contribution. However, an anchor value of 1.0f is not really valid, you should not be setting an anchor point in that case at all. Everything is working as intended.


Modify Chart for Netbox Release 3.6.0

Hi,
Netbox 3.6 was released: https://github.com/netbox-community/netbox-docker/releases/tag/2.7.0
With this release there is a renaming of a few Vars.
I think this is not many work to modify your Chart and release a new Version.
Can you do this?
edit: 3.7 -> 3.6

NetBox 3.6 was released, not 3.7...

Netbox 3.6 also requires postgres >=12

I just noticed that @bootc seems to be dusting off the chart, bumping postgres, chart version, preparing for 3.6.0 in the development branch. I hope this leads to a release soonish

Yeah I hope I get enough round tuits and energy to make a release this weekend. If you want to get your PRs in, now would be a good time to polish them up! :-)

@bootc let me know if there is anything I can do to help you out and to get everyone closer to a release.

Hey @bootc, what's the latest on this one?

Ok now NetBox 3.7 is out.
This is really awkward, because the author is making changes and responding to issues, but a release is not coming out. Should we fork anyway?

I'm going to go ahead and close this now that we have some momentum going again. Sorry about the delay, but if you've followed any of the other places talking about this, I've been brought on by NetBox Labs to help take ownership of the charts (with @bootc's blessing and assistance).
The only major technical issue with the 4.1.1 chart and 3.7 that I know of is that the provided PostgreSQL is too old, but if you use your own (or upgrade/migrate the postgresql in the chart) it should still work fine.
Going forward the 5.x charts in develop are updated to 4.0 and should still be 3.7-compatible as far as I can tell if you wish to override the image. I'm working to wrap up some final stuff and release a 5.0.0 non-beta in hopefully the next few weeks.
In the meantime, if you'd like to bang on the 5.0 beta charts in the new repo, I'd love feedback about anything that might be missing or needs cleanup. There's been a lot of refactoring going on in the last few weeks.

Thank you for the great work. Since movement away from bootc I'm on develop branch, but for long time before on old bootc with external Postgres and since a few days on external redis.

I'm sorry to be that guy, but there have been 78 beta releases, and they seem to contain nothing but dependency updates. Is there a blocker to GA? Is there a way we can help get out of beta?

@remram44 #286


Add reserved words

#1345 adds infrastructure, but the real breaking change we need here is for this to be on-by-default, tracked with #1406.


feat: choose locale in settings

#143

Found a parser. But it's present in a different library. The Locale class of the default(sky_engine) is different from the Locale class of the intl library I used. Hence I'm not assigning parsedLocale in the file directly to the locale prop.


Multiple ways to specify Spark configurations causing duplicate spark-submit args

There are two ways to set many of the spark-submit configurations.  The current spark submission logic found in submission.go does not do any de-duplication of these configurations, which leads to potentially undefined behavior.
For example, suppose you were to apply the following yaml file:
apiVersion: "sparkoperator.k8s.io/v1beta1"
kind: SparkApplication
metadata:
  name: spark-pi
  namespace: default
spec:
  type: Scala
  mode: cluster
  image: "gcr.io/spark-operator/spark:v2.4.0"
  imagePullPolicy: Always
  mainClass: org.apache.spark.examples.SparkPi
  mainApplicationFile: "local:///opt/spark/examples/jars/spark-examples_2.11-2.4.0.jar"
  sparkVersion: "2.4.0"
  sparkConf:
    "spark.driver.cores": "2"
  restartPolicy:
    type: Never
  volumes:
    - name: "test-volume"
      hostPath:
        path: "/tmp"
        type: Directory
  driver:
    cores: 1
    coreLimit: "1200m"
    memory: "512m"
    labels:
      version: 2.4.0
    serviceAccount: cautious-chicken-spark
    volumeMounts:
      - name: "test-volume"
        mountPath: "/tmp"
  executor:
    cores: 1
    instances: 1
    memory: "512m"
    labels:
      version: 2.4.0
    volumeMounts:
      - name: "test-volume"
        mountPath: "/tmp"

Because the spec.driver.cores field maps to the spark configuration spark.driver.cores and there is no de-duplication nor a defined precedence, the spark operator passes the following arguments to spark-submit:
I0918 22:47:23.101329       9 submission.go:63] spark-submit arguments: [/opt/spark/bin/spark-submit --class org.apache.spark.examples.SparkPi --master k8s://https://<IP_ADDRESS>:443 --deploy-mode cluster --conf spark.kubernetes.namespace=default --conf spark.app.name=spark-pi --conf spark.kubernetes.driver.pod.name=spark-pi-driver --conf spark.kubernetes.container.image=gcr.io/spark-operator/spark:v2.4.0 --conf spark.kubernetes.container.image.pullPolicy=Always --conf spark.kubernetes.submission.waitAppCompletion=false --conf spark.driver.cores=2 --conf spark.kubernetes.driver.label.sparkoperator.k8s.io/app-name=spark-pi --conf spark.kubernetes.driver.label.sparkoperator.k8s.io/launched-by-spark-operator=true --conf spark.kubernetes.driver.label.sparkoperator.k8s.io/submission-id=47c67adb-f110-4b87-984a-a2543e1c8c0d --conf spark.driver.cores=1.000000 --conf spark.kubernetes.driver.limit.cores=1200m --conf spark.driver.memory=512m --conf spark.kubernetes.authenticate.driver.serviceAccountName=cautious-chicken-spark --conf spark.kubernetes.driver.label.version=2.4.0 --conf spark.kubernetes.executor.label.sparkoperator.k8s.io/app-name=spark-pi --conf spark.kubernetes.executor.label.sparkoperator.k8s.io/launched-by-spark-operator=true --conf spark.kubernetes.executor.label.sparkoperator.k8s.io/submission-id=47c67adb-f110-4b87-984a-a2543e1c8c0d --conf spark.executor.instances=1 --conf spark.executor.cores=1 --conf spark.executor.memory=512m --conf spark.kubernetes.executor.label.version=2.4.0 local:///opt/spark/examples/jars/spark-examples_2.11-2.4.0.jar]
Notice that the spark.driver.cores configuration is passed to spark-submit twice. While spark-submit does not fail here, I think the spark-operator should have an explicit precedence of fields to prevent this duplication and ensure a straightforward implemenation.
While it seems easier for new users to give the sparkConf map the highest precedence, I think the ordering should probably be first the spec and then the sparkConf map. I haven't worked with the Mutating Admission Webhook, but I assume the choice here will have consequences for the webhook because if you want to enforce some type of default field, you'll want to specify it in the field that has the highest precedence.
Note: I tested this issue using the v1beta1 version.
The implementation shouldn't be too complicated, but I'd like some consensus before I submit a PR.
Let me know if you have any questions. Thanks.

Thanks for raising this. I agree it could be confusing to users when they have two different ways of setting a Spark config option. I think for Spark config options that can be configured in both ways, the values from dedicated fields should take precedence and the values for the same options under sparkConf should be ignored. Otherwise, the values under sparkConf will be used. It doesn't need to involve the webhook as the spark-submit command is prepared before the app gets submitted. Thoughts?

Has this been solved? If not, I might work on it.

@jacobhjkim - I can confirm that I won’t be contributing a solution.


NEW FEED ADDED : C-TRAN

C-TRAN
,  ()
Details
Data type
GTFS Realtime - Vehicle Positions
Issue type
New source
Name
Your name and organization
Taylor Eidt (C-TRAN)
URLs

Current URL on OpenMobilityData.org
Updated/new feed URL
Download URL
Link to dataset

http://gtfs-rt.c-tran.org/gtfsrealtime/VehiclePostions
https://www.c-tran.com/about-c-tran/business/c-tran-gtfs-data

Authentication
Authentication Type
Link to how to sign up for authentication credentials (API KEY)
HTTP header or API key parameter name
Note (any important clarifications so people know how to use your dataset)
View more details
https://docs.google.com/spreadsheets/d/1Q96KDppKsn2khdrkraZCQ7T_qRSfwj7WsvqXvuMt4Bc

Already present in the Mobility Database - bug that it was added


Add French Support

Issue
Currently only Japanese is supported
Instructions to Reproduce
not applicable
Criteria for Completion

you can set your target language to French in the .env file.
you can run the server with French set with everything working as expected
default should still be Japanese
no changes should be made to README.md or setup.py that would indicate French is available yet

Helpful information

gpt prompt must be modified conditionally to accommodate the nuances of the language
new variable in .env
import variable into settings.py
add logic everywhere that Japanese is hardcoded if this is the first time language support is added
possible unexpected considerations

Future plans will conflict with this implementation.


Media Clusters Follow Up

Problem
Comments haven't been resolved for the media clusters code update PR
Proposed Solution
Update code per suggestion in the PR

@lazarkov could you please bring here the details on what's needed?

@franck-apple honestly, with this poorly written ticket, I need time as well figure out.

All comments have been resolved.


Improve UX For Resizing Editor Suggestions Box

Hello, thank you for your great contributions to VS Code!
Recently in the /r/vscode subreddit, a post was made by a user who was only getting a single editor suggestion while typing. The problem was that the the user must have inadvertently minimized the box in the past, and now had no idea how to restore it to its original size. This happened to me too a while ago, and I went a while without having a good solution to the problem.
Image from reddit post:

Judging by the amount of upvotes on the post (50+ at the time of writing this) I imagine that this is an issue that many VS Code users experience and are confused about at some point. Its also easy for the user to assume that there is just a single suggestion, and decide to disable the box altogether since it's not as useful as it once was.
Is there some simple way to improve the UX without too much trouble? Maybe something like the drag handle UI that shows in the bottom right corner of HTML text areas?

Thanks for reaching out. Yeah, somehow folks run into the "resized to single line" case and I do agree that this is a problem. What I very very keen on knowing is how folks get into this state. Is there a bug in my persist/resize logic or do people unknowingly resize stuff?
Tho, for the next release I have pushed a poor mans fix which is so that sizes below a minimum height aren't persisted anymore. I have used 4.3 - a fraction on purpose so that you can see a little bit of the next item.
What also helps, is to make the resize-sash visible on hover. Our theme don't have a color defined so that are "invisible" but this is what I use and how it looks (mouse not captured, but resizing the width)
"workbench.colorCustomizations": {
	"sash.hoverBorder": "#5a505042"
}

Adding @misolori for the proposed drag handle UX. I actually like it and I think it makes sense to have something like that. Too many user have been confused

Thanks for reaching out. Yeah, somehow folks run into the "resized to single line" case and I do agree that this is a problem. What I very very keen on knowing is how folks get into this state. Is there a bug in my persist/resize logic or do people unknowingly resize stuff?
Tho, for the next release I have pushed a poor mans fix which is so that sizes below a minimum height aren't persisted anymore. I have used 4.3 - a fraction on purpose so that you can see a little bit of the next item.
What also helps, is to make the resize-sash visible on hover. Our theme don't have a color defined so that are "invisible" but this is what I use and how it looks (mouse not captured, but resizing the width)
"workbench.colorCustomizations": {
	"sash.hoverBorder": "#5a505042"
}

Adding @misolori for the proposed drag handle UX. I actually like it and I think it makes sense to have something like that. Too many user have been confused

Hi,
<-- that's actually me who created a post on Reddit.
I believe that happened ( at least in my case) with one of the extensions, it's difficult to say, which one as I was ok with a single line of example for a long time. And even though that it's an extension 'feature'.  Never the less, resizing with a mouse never even came to my mind. As mentioned above some indication for the option to do it would be an improvement.

Hi,
<-- that's actually me who created a post on Reddit.
I believe that happened ( at least in my case) with one of the extensions, it's difficult to say, which one as I was ok with a single line of example for a long time. And even though that it's an extension 'feature'.  Never the less, resizing with a mouse never even came to my mind. As mentioned above some indication for the option to do it would be an improvement.

The drag handle is typically used for text inputs, not sure if that would work well here. I'd be in favor of adding a sash hover color for our default themes but I think @joaomoreno wasn't a fan of this. I'd say we need to make sure that the resizing indicators match the rest (sidebar, panels, editors, etc.) and the sash color is one that spans all of those.

The drag handle is typically used for text inputs, not sure if that would work well here. I'd be in favor of adding a sash hover color for our default themes but I think @joaomoreno wasn't a fan of this. I'd say we need to make sure that the resizing indicators match the rest (sidebar, panels, editors, etc.) and the sash color is one that spans all of those.

I'd be in favor of adding a sash hover color for our default themes but I think @joaomoreno wasn't a fan of this.

Might just be me! Let's experiment!

I'd be in favor of adding a sash hover color for our default themes but I think @joaomoreno wasn't a fan of this.

Might just be me! Let's experiment!

Another thing that we could try to experiment with is to highlight all sash when they are connected. E.g in the suggest widget when hovering over the horizontal sash also highlight the veritical sash and vice versa

Another thing that we could try to experiment with is to highlight all sash when they are connected. E.g in the suggest widget when hovering over the horizontal sash also highlight the veritical sash and vice versa

So here's one thing we can try, I played around with setting the sash hover color using an existing color and focusBorder seemed to be the best color that other themes also included. Here's what that looks like:

And then how it applies for the rest of the workbench:
https://user-images.githubusercontent.com/35271042/105428063-6b501600-5c03-11eb-9528-322cddbb8f0f.mov
Since we're at the end of the iteration I think we should wait until the next milestone to try this out.

So here's one thing we can try, I played around with setting the sash hover color using an existing color and focusBorder seemed to be the best color that other themes also included. Here's what that looks like:

And then how it applies for the rest of the workbench:
https://user-images.githubusercontent.com/35271042/105428063-6b501600-5c03-11eb-9528-322cddbb8f0f.mov
Since we're at the end of the iteration I think we should wait until the next milestone to try this out.

Looks good and consistent.

Looks good and consistent.

Alright, I just enabled this for all themes. Let's try it out and see how it feels.

This happened with @joaomoreno's changes. Thanks


CANOpenNode Stack can use as master or only slave node?

Hi,
I am newer with CanOpen, my project need to communicate with some motion drivers which have CANOpen communication, and motion drivers are as slave node, so with CANOpenNode Stack I can use it to import for microcontroller or Linux processor act as master communicate with some slave node or CANOpenNode Stack when import for microcontroller or Linux processor just only act as slave node?

Please don't look CANopen as master/slave protocol. Follow some links from readme or see CANopenDemo or read some other literature about CANopen.


init.vim: use %F in section_c if autochdir is set.

The difference as per documentation of :statusline
f S   Path to the file in the buffer, as typed or relative to current
  directory.
F S   Full path to the file in the buffer.

thanks.


Titles in non-english gets 2 capital letters at the beginning

E.g. if I have a code like
//...
var sample_data = [/*...*/
            {"name": "role", "title": "Роль", "size": 40, "class": "level2"}
                /*...*/],
connections = [/*...*/];

d3plus.viz()
                .container("#viz")
                .type("network")
                .data(sample_data)
                .edges(connections)
                .edges({"arrows": true})
                .id("name")
                .text("title")
                .draw();

Word 'Роль' turns into ' РОль' in render.
The following code causes this problem:
https://github.com/alexandersimoes/d3plus/blob/master/src/string/title.coffee#L19
prefix = txt.charAt(0).search(/[^A-Za-z0-9\-_]/g) is 0

Actually, JavaScript does not support full range unicode match character, so the following RegExp would be much more appropriate in order to support i18n:
prefix = txt.charAt(0).search(/[^\W\s]/g) is 0

It performs a check if the first letter is neither non-letter character (\W) nor space (\s)
Moreover, instead of following code
    prefix = txt.charAt(0).search(/[^A-Za-z0-9\-_]/g) is 0

    if prefix
      prefix = txt.charAt(0)
      txt = txt.slice(1)
    else
      prefix = ""

you could use
    if /^[^\W\s]/.test(txt)
      prefix = txt.charAt(0)
      txt = txt.slice(1)
    else
      prefix = ""

which works faster and looks simplier.

Wow, good find and great solution. Would you mind creating a pull request with this code change? I'd love to have you recorded as the contributor for this.

Sure, you're welcome: https://github.com/alexandersimoes/d3plus/pull/248
Actually, the whole file can be simplified and optimized at least twice, but I'm actually kind of scary to edit the project - there are no tests, so I don't know how to check that all of the test cases still works

I hear you man. I feel the same way when I edit some of these files. The whole project grew very rapidly.
This title case function would be easy to create some simple test cases for, but I've been looking for a testing library that's more cross-browser based because D3plus is tied so closely to the visuals rendered in browser. I've been looking into using DalekJS (http://dalekjs.com) for creating a comprehensive set of tests.
We're probably going to do 1 more big sprint into developing new features, and then I'm hoping to spend some time on tests and code documentation.

Going forward with this thread. I have nodes having names like {'source':'ALPHA','target':'BETA','source':'DBS','target':'CDN','source':'Cross Platform','target':'Primary OS'}
I needed the 'source' and target to be same as they are in connections so I removed toLowerCase from the above code. Would there be any impact somewhere else because till now its working as I wanted. Please suggest.

@ssjsatish instead of modifying the internal source code, you should be overriding the default text formatting function: http://d3plus.org/examples/advanced/7760febcda3375b39e1f/


api-docs: Add organization name to page header

Hey, I just made a Pull Request!

Current API Explorer always displayed, "Backstage API Explorer". Updates to use the org name such as "My Company API Explorer", if defined, falling back to Backstage if not.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

Tugboat has finished building the preview for this pull request!
Link:

https://pr4713-2wvwewjyxoly4furtdahcydgrflgzfi0.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60387cb365f8171a37fb40d1

Tugboat has finished building the preview for this pull request!
Link:

https://pr4713-2wvwewjyxoly4furtdahcydgrflgzfi0.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60387cb365f8171a37fb40d1

I tried to sign-off on these old commits.

Tugboat has finished building the preview for this pull request!
Link:

https://pr4713-2wvwewjyxoly4furtdahcydgrflgzfi0.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60387cb365f8171a37fb40d1


goreleaser publishes prerelease to prod brew

version in output below should be v0.10.2
❯ brew info akash
ovrclk/tap/akash: stable 0.12.0-rc1
Blockchain-powered decentralized compute platform
https://akash.network
/usr/local/Cellar/akash/0.12.0-rc1 (3 files, 69.3MB) *
  Built from source on 2021-03-24 at 11:02:20
From: https://github.com/ovrclk/homebrew-tap/blob/HEAD/akash.rb

Im having the same issue and when issuing simple commands such as
akash version
I get the following error:
Error: failed to parse log level (main:info,state:info,statesync:info,*:error): Unknown Level String: 'main:info,state:info,statesync:info,*:error', defaulting to NoLevel

You have some stale configuration.   Edit ~/.akash/config/config.toml and set
log_level = "info"


WIP add support for PHP8

#54

Add support for PHP8.0
Remove blocking issue added in https://github.com/wizaplace/php-etl/pull/4/files (so, we might have a BC if someone rely on this one)

May be it is time to consider a 2.0 to drop all the old stuff and have a fresh base for new features.

In response to your comment above -- I'd support a 2.0 release that used "php": "~7.4|~8.0" as a basis. With the availability of typed properties in 7.4, we can further reduce the need for PHPdoc annotations for types, but doing so is interface changing, so increasing to 2.x is helpful.
It might be nice to tag a release where we are before making that jump.

@kdebisschop ok !
So to sum-up:

we merge this PR and tag the 1.3 version with the mention "partial support for PHP8 - partial meaning for the dev tools", and some details.
We can prepare a 2.0 branch to start working on it with a minimal support of 7.4 (or 8 directly ?).


Added link_redirects and members_link_click_events tables

closes https://github.com/TryGhost/Team/issues/1912
closes https://github.com/TryGhost/Team/issues/1913

@SimonBackx This LGTM but will need updating for 5.15 -> 5.16


Implement initial support for user authentication

This adds generic authentication framework via the new cfg::Auth
configuration object.  The two initial authentication modes are Trust and
SCRAM (SCRAM-SHA-256).  The default is SCRAM, which means that a valid
role password is required to connect.   Since new instances obviously don't
have that configured, add a way to connect to a special
"admin" UNIX socket, which is protected by OS permissions, and which does
not enforce internal authentication.
To make things easier, the development server (which is now started with
edb server) has Trust auth configured by default.

Good job!
Linked to:

https://github.com/scram-sasl/info/issues/1


friends show up as derived

For example free function async_connect, a friend of timed_stream, says:
"(Inherited from async_connect)"

I couldn't find timed_stream in the Beast HTML docs (assuming that's where it was originally reported), so I wonder if this one is obsolete too?

I couldn't find timed_stream in the Beast HTML docs (assuming that's where it was originally reported), so I wonder if this one is obsolete too?

it was renamed to basic_stream before the release:
https://www.boost.org/doc/libs/1_75_0/libs/beast/doc/html/beast/ref/boost__beast__basic_stream.html

it was renamed to basic_stream before the release:
https://www.boost.org/doc/libs/1_75_0/libs/beast/doc/html/beast/ref/boost__beast__basic_stream.html

Following up on this. I see async_connect on that basic_stream page, but I don't see it saying "(Inherited from async_connect)". Does that mean this issue is obsolete? Or am I misunderstanding it? Sorry I need the extra handholding!

It looks like I got rid of the free functions, so this issue is no longer relevant - good work ;)


Add short form flag -h

--help exists, but -h is useful too.

Click doesn't make this available by default and the error message is clear enough today. If you feel strongly enough about this, please submit a pull request that enables this.


[$500] Split - A new group is formed when splitting bill with a few members in the group

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to group chat with many members
Click + > Split bill
Unselect a few members and create the bill split
Note that a new group is formed

Expected Result:
The bill split is created in the same group chat
Actual Result:
A new group is formed in which the bill split is created
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ea4258f3-f34b-4533-a89b-95c0825e0e79
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ecb31d068a616959
Upwork Job ID:<PHONE_NUMBER>712480256
Last Price Increase: 2023-12-11

Proposal
Please re-state the problem that we are trying to solve in this issue.
A new group is formed when splitting bil with a few members in a group
What is the root cause of that problem?
in the split we pass the report argument as the tag https://github.com/Expensify/App/blob/968f39f0a2c6e7305e46f7d5a8a546407689cc10/src/pages/iou/request/step/IOURequestStepConfirmation.js#L215-L225
        IOU.splitBill(
                    selectedParticipants,
                    currentUserPersonalDetails.login,
                    currentUserPersonalDetails.accountID,
                    transaction.amount,
                    trimmedComment,
                    transaction.currency,
                    transaction.category,
                    report.reportID,
                );

What changes do you think we should make in order to solve the problem?
we should change it to
        IOU.splitBill(
                    selectedParticipants,
                    currentUserPersonalDetails.login,
                    currentUserPersonalDetails.accountID,
                    transaction.amount,
                    trimmedComment,
                    transaction.currency,
                    transaction.category,
                    transaction.tag,
                    report.reportID,
                );

@abzokhattab's proposal looks good to me. We recently added merchant so this should be correct fix:
        IOU.splitBill(
                    selectedParticipants,
                    currentUserPersonalDetails.login,
                    currentUserPersonalDetails.accountID,
                    transaction.amount,
                    trimmedComment,
                    transaction.currency,
                    transaction.category,
                    transaction.tag,
                    report.reportID,
                    transaction.merchant,
                );

@situchan is correct, the merchant field needs added too. Thanks for grabbing this one!

@tgolen I was fixing this one here https://github.com/Expensify/App/pull/30721, I had to copy the update to the new file as I was changing the old one

OK, thanks. Since this is a deploy blocker, I think we'll need a PR just for this fix.

Sounds good!

The PR is ready

Starting CP

Testing

Just tested - when I unselect members from the split no new group is formed. The split remains in the same group chat

Please assign me here as reviewer

@shubham1206agra - please can you accept the offer? I will pay once you have completed the BZ checklist.
@abzokhattab - offer is in your inbox

Thanks @sophiepintoraetz, I have accepted the offer

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/28618
[x]  [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1432806472
[x]  [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[x]  [@shubham1206agra] Determine if we should create a regression test for this bug. No as we already caught this in deploy testing
[x]  [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ]  [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Both paid, thanks!


Update build configuration

The build configuration of this project is outdated and may no longer work.
This pull request will be merged automatically if there are no conflicts.

:tada: This PR is included in version 5.1.23 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Generated epg.xml does not contain any epg information, just icons

When using the script it succesfully downloads both original.m3u8 and original.xml files. For the groups/channels that I end up with
EPG data is present in the original.xml, but nothing ends up in the epg.xml except icon info.
I have attached all files involved. If more info is needed, please let me know.
epg.zip

It looks like the script might be having an issue making sense of your source xml. I'm not sure what the cause is yet, I'll run some tests and comment again when I have further details.

I tested with your input data with python v3.9.2 on linux using script arguments that I guessed from the supplied process.log file and the result was a populated epg.xml file. It appeared to work as it should.
Can you advise specifically which arguments you're using and I'll test again with that, thanks.

Hello Joe,
Attached is my json file that I use for the input parameters.
input_args.zip
I use the native Python docker on my Synology NAS to trigger everything and use the following command:
docker exec python python /iptv/m3u-epg-editor-py3.py --json_cfg /iptv/input_args.json
So your generated epg.xml was larger than what was generated on my side? Your assistance is much appreciated!

Thanks for that, no problem.
I think that I might have got to the bottom of your issue, the problem appears to be related to the time range of programme stop/start attribute data in your source epg.xml. I think that your epg programme data is currently being considered to be invalid and data is being thrown away because you haven't specified a range argument value in your json config.
When a range value is not specified, this value automatically defaults to a value of 168hrs (7 days) which causes the script to consider programmes in the epg xml to be valid only when the start/stop time for a programme is now +/- 168hrs.
If you were to add a large range value to your json config I think it should resolve this problem.. or it should at least ensure that the newly generated xml file contains programme elements.. but I am unable to say if this epg data will work as expected.
i.e. try something like: "range": 12000000 in your json config, go again and let me know how that goes, thanks.

Hi Joe,
Will test today or tomorrow and let you know the results. Again, thanks for your help.

Hello Joe,
I think I found the reason. It seems my original.xml only contains outdated data. When I look at the timestamps for start of TV shows, I only see dates from February, e.g.<PHONE_NUMBER>2000. There does not seem to be any recent data in there at all.  So I think it it safe to close the issue.

No worries, I agree, this is what I described in my previous comment

the problem appears to be related to the time range of programme stop/start attribute data in your source epg.xml. I think that your epg programme data is currently being considered to be invalid and data is being thrown away because you haven't specified a range argument value in your json config.

This looks like a case of poor quality source epg data. Closing.


add Type field

Not required, but strongly recommended.

Why isn't this required? Seems like it should be.

add test for a type field in each schema


fuchsia: fix regression in fmt::Debug for Events

@cramertj

Oh, sorry about that. Apparently there isn't CI for fuchsia.

Thanks!

@raggi We would be happy to add fuchsia to the CI run if that is contributed ;)


how to use Client and server

hello sir how to use in Server and Client mode can u please give me any config file or example how to use between Server and client.I want to use udp-udp
thanks

Hello sir i cannot build gost# go build
_/root/gost
./ss.go:87:13: undefined: shadowsocks.DialWithRawAddrConn
Can you please give me binary for Linux 32 bit X86 kindly

Please ignore cannot build error i found the release thanks for it.But how can i use gost please


Office Hour news for 11/8/23

Need to download and cut video after available
Write blog post about the Office Hour

Video link: https://bcgcatenax.sharepoint.com/sites/CommunitiesofPractises/Shared Documents/Forms/AllItems.aspx?FolderCTID=0x01200075F4DD2D705FA349B372CD3378FD1093&id=%2Fsites%2FCommunitiesofPractises%2FShared Documents%2FCX-CoP DevSecOps%2FOffice_Hours_Regular_Recordings%2F20230811_DevSecOps Business Hours-Recording.mp4&parent=%2Fsites%2FCommunitiesofPractises%2FShared Documents%2FCX-CoP DevSecOps%2FOffice_Hours_Regular_Recordings

PR: https://github.com/catenax-ng/catenax-ng.github.io/pull/201


Stable SNAPSHOT times

At present, generating two SNAPSHOT versions of a project without any changes in between creates two versions with different timestamps.
This makes SNAPSHOT build versions somewhat unpredictable.
For clean work directories, the SNAPSHOT could contain date and time of the last commit. For dirty work directories. We need a different strategy, for instance the most recent modification time of the latest change.

done


[question] why experimental?

At the time this was created, I did not know if or how I could ever finish it.
It is incomplete and unmaintained.
I believe that once C++ has reflection and generation this would be possible in a decent fashion.

How does this project differ from sqlite3 in InMemory mode？

sqlite3 InMemory is using sqlite. This is about using any standard library container or stream (or range in C++20) like a database table and run queries on it.


module 'tensorflow' has no attribute 'zeroes' in Graph guide

Please make sure that this is a documentation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:doc_template
System information

TensorFlow version: 1.12.0
Doc Link: https://www.tensorflow.org/guide/graphs

Describe the documentation issue
On the documentation an example was given using tf.zeroes().
However, the module 'tensorflow' has no attribute 'zeroes'.
with tf.device("/job:ps/task:0"):
  weights_1 = tf.Variable(tf.truncated_normal([784, 100]))
  biases_1 = tf.Variable(tf.zeroes([100]))

with tf.device("/job:ps/task:1"):
  weights_2 = tf.Variable(tf.truncated_normal([100, 10]))
  biases_2 = tf.Variable(tf.zeroes([10]))

with tf.device("/job:worker"):
  layer_1 = tf.matmul(train_batch, weights_1) + biases_1
  layer_2 = tf.matmul(train_batch, weights_2) + biases_2

The documentation should use tf.zeros() instead
We welcome contributions by users. Will you be able to update submit a PR (use the doc style guide) to fix the doc Issue?
yes

https://github.com/tensorflow/docs/pull/383


Work around a compiler bug in MacOS AppleClang 11

Fixes #6102 by avoiding a variable capture in xgboost::common::ParallelFor2d. This works around a compiler bug in AppleClang 11.0.3 while preserving the semantics.
Also, add MacOS Catalina to the testing matrix, which has AppleClang 11.0.3.

actually can we do the test on Action instead? Travis is quite slow.


Consider deprecating isFalseOrEmpty to simply use falsey check and code around other possibilities (e.g., using for...in loop to avoid empty objects)

https://github.com/therealchjones/mffer/blob/3861ec1370deaf6778beb565289e9d96c27e7f6f/src/webapp/Code.ts#L172

However, TypeScript does not use falsy the same way; may still be appropriate to use a function


none of the events are not working

I want to get selected values onChange event

Try something like this in your component:
        $(ReactDOM.findDOMNode(this.refs.yourselect)).find('select').selectpicker().on('change', function(){
            console.log($(this).val());
        });

Not sure if it works with 0.13, but definitely it is with react 0.14, see https://github.com/tjwebb/react-bootstrap-select/pull/10


Debugger for Lua / sol2

This is outside the scope of sol2, but I was wondering if you could recommend a Lua debugger that works with Visual Studio Code and supports sol2 well?

I haven't tried this yet.
https://marketplace.visualstudio.com/items?itemName=devCAT.lua-debug
There is a lua patch to improve the debuggers performance. I learned about it on the Lua mailing list because someone said it was a considerable improvement. Here is the repo (also in the link above):
https://github.com/devcat-studio/lua-5.3.4-op_halt
They provide a VS 2017 solution file for building Lua as well if your on Windows.
An excellent all-Lua alternative to VSC is Zerobrane and it has a built in debugger. I seem to remember the phd slagging the gui once on the mailing list, but it worked well when I used it on Linux and Windows.  :P
A stand alone debugger is available here: https://luarocks.org/modules/gunnar_z/debug.lua . It's *nix only I think. I used it on FreeBSD successfully.

I don't think any debugger has built-in sol2 support. I do have some __type information on each usertype one can iterate and read to check things, but that's about it?
Debuggers are a bit out of scope for me because each person crafts their own, and the Lua team isn't very happy with adding core bits like OP_HALT to have fast, non-obscenely-intrusive debugging, so not much I can do here. Use the raw debug library intermingled with sol2 primitives and stack operations: good luck!

I am now successfully using Lua Debugger by DevCat:
https://marketplace.visualstudio.com/items?itemName=devCAT.lua-debug

This may be of interest to some users:
https://www.leadwerks.com/community/blogs/entry/2545-advanced-lua-debugging/


[Bug]: Bootstrapping a new cluster using pg_basebackup from replica

Is there an existing issue already for this bug?

[x] I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

[x] I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

[x] I have read the troubleshooting guide and I think this is a new bug.

Contact Details
<EMAIL_ADDRESS>Version
1.24.0
What version of Kubernetes are you using?
1.31
What is your Kubernetes environment?
Other
How did you install the operator?
Helm
What happened?
Bootstrapping using the pg_basebackup method doesn't work when using a replica IP instead of primary in the externalClusters section.
The pg_basebackup job successfully dumps the database but is stuck with the following logs:
specified neither \"primary_conninfo\" nor \"restore_command\"","hint":"The database server will regularly poll the pg_wal subdirectory to check for files placed there

waiting for WAL to become available at 14B/3C002000
There are no problems when bootstrapping from primary.
Cluster resource
apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  name: fc-dev-pg
spec:
  instances: 1
  imageName: ghcr.io/cloudnative-pg/postgresql:17.0

  bootstrap:
    pg_basebackup:
      source: fc-pg
      database: fastcup
      owner: fastcup
      secret:
        name: fc-dev-pg

  externalClusters:
    - name: fc-pg
      connectionParameters:
        # Production replica svc
        host: fc-pg-ro.fastcup
        user: streaming_replica
        sslmode: verify-full
      sslKey:
        name: fc-pg-replication
        key: tls.key
      sslCert:
        name: fc-pg-replication
        key: tls.crt
      sslRootCert:
        name: fc-pg-ca
        key: ca.crt

  storage:
    size: 1Ti
    storageClass: nvme-lvm-local

  postgresql:
    parameters:
      max_connections: "300"
      shared_buffers: "16GB"
      effective_cache_size: "48GB"
      maintenance_work_mem: "2GB"
      checkpoint_completion_target: "0.9"
      wal_buffers: "16MB"
      default_statistics_target: "100"
      random_page_cost: "1.1"
      effective_io_concurrency: "200"
      work_mem: "20971kB"
      huge_pages: "try"
      min_wal_size: "2GB"
      max_wal_size: "8GB"
      max_worker_processes: "16"
      max_parallel_workers_per_gather: "4"
      max_parallel_workers: "16"
      max_parallel_maintenance_workers: "4"

      pg_stat_statements.max: "10000"
      pg_stat_statements.track: all
      pg_stat_statements.track_utility: "true"
      pg_stat_statements.save: "false"
      track_io_timing: "on"

Relevant log output
pgbasebackup.log
Code of Conduct

[x] I agree to follow this project's Code of Conduct

You're not using the IP address as you comment, but the RO service
- name: fc-pg
      connectionParameters:
        # Production replica svc
        host: fc-pg-ro.fastcup

This worries me. The RO service is not a connection to one instance.
Then, while it is possible to run base backup on a replica, there are caveats.
https://www.postgresql.org/docs/current/app-pgbasebackup.html
Note that there are some limitations in taking a backup from a standby:

The backup history file is not created in the database cluster backed up.

pg_basebackup cannot force the standby to switch to a new WAL file at the end of backup. When you are using -X none, if write activity on the primary is low, pg_basebackup may need to wait a long time for the last WAL file required for the backup to be switched and archived. In this case, it may be useful to run pg_switch_wal on the primary in order to trigger an immediate WAL file switch.

If the standby is promoted to be primary during backup, the backup fails.

All WAL records required for the backup must contain sufficient full-page writes, which requires you to enable full_page_writes on the primary.


Arrows and dots not working in react-carousel

Arrows and dots are not working even after updating the properties in SliderSettings(Carousel.tsx)
Please help

@pandiarajank did you ever resolve this issue?
I'll mark this issue as closed as there hasn't been any activity for a while, but absolutely feel free to open a new issue if you're still experiencing issues.
If you do so, I encourage you to take the time to fill the issue template provided, as it helps route issues to the appropriate authors and -- hopefully -- helps get your issues the attention they deserve.


Docs for keyword implementations

Resolves #48

It might be more structured and version-aware. I'll add it in a different PR with some structural refactorings

It might be more structured and version-aware. I'll add it in a different PR with some structural refactorings


CanvasKit: provide non-overloaded SkPath.arcTo methods

Currently CanvasKit's SkPath.arcTo is overloaded. The implementation dynamically destructures the argument list and decides which WASM version to call. There's actually two dynamic destructuring happening, one in interface.js and one in the Emscripten bindings (the _arcTo is also overloaded):
  CanvasKit.SkPath.prototype.arcTo = function() {
    // takes 4, 5 or 7 args
    // - 5 x1, y1, x2, y2, radius
    // - 4 oval (as Rect), startAngle, sweepAngle, forceMoveTo
    // - 7 rx, ry, xAxisRotate, useSmallArc, isCCW, x, y
    var args = arguments;
    if (args.length === 5) {
      this._arcTo(args[0], args[1], args[2], args[3], args[4]);
    } else if (args.length === 4) {
      this._arcTo(args[0], args[1], args[2], args[3]);
    } else if (args.length === 7) {
      this._arcTo(args[0], args[1], args[2], !!args[3], !!args[4], args[5], args[6]);
    } else {
      throw 'Invalid args for arcTo. Expected 4, 5, or 7, got '+ args.length;
    }

    return this;
  };

This is slower than a direct call to the desired function, because JavaScript doesn't have static overloads this required dynamic dispatch. It also makes Dart-JS bindings awkward as there's no single method signature to bind to.
Instead CanvasKit should provide three specialized methods arcTo (takes 4 args; could be named something else for backwards-compatibility), arcToPoint (takes 7 args), and arcToTangent (takes 5 args). There would be no need for dynamic dispatch, and Dart-JS bindings would be trivial.
/cc @kjlubick

ack

I'll split it apart into the methods you described, deprecating the original.

@nhnifong this landed, right?

yes it has.

Thank you! I see the new methods and I'll move our code to the new ones.


fix($compile): Cleanup attribute-binding observers

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
https://github.com/angular/angular.js/issues/15268
What is the new behavior (if this is a feature change)?
Cleans up attributes observer on change.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Other information:

LGTM 👍 (I will rename the controller while merging.)
✨ Thx for finding the bug and fixing it too! ✨


Gamepad (SinglePad) button handling broken in 2.4.1, possible solution

Hi there,
I'm running into an issue with gamepad buttons in Phaser 2.4.1 in both Firefox and Chrome (Windows 8.1 x64).
The error reported is:
Uncaught TypeError: Cannot read property 'altKey' of null
The error occurs in Phaser.DeviceButton.start. This seems to be because Phaser.SinglePad.processButtonDown passes null as the first argument of the start function, like so:
    this._buttons[buttonCode].start(null, value);

This same issue is repeated in Phaser.SinglePad.processButtonUp:
    this._buttons[buttonCode].stop(null, value);

This is my very first day working with Phaser, so I'm quite bashful to assume I know what I'm talking about, but I may be able to offer a resolution. I got my gamepad to work through a bit of guesswork; I simply passed the button reference in as the first argument of each of these function calls, and it seems to work. It looks a bit like this in my code now:
    processButtonDown: function (buttonCode, value) {

        ...

        if (this._buttons[buttonCode])
        {
            this._buttons[buttonCode].start(this._buttons[buttonCode], value);
        }

    },

    ...

    processButtonUp: function (buttonCode, value) {

        ...

        if (this._buttons[buttonCode])
        {
            this._buttons[buttonCode].stop(this._buttons[buttonCode], value);
        }

    },

So far, so good, but I'm not very familiar with the codebase yet. Regardless, I hope this helps! I'll be sure to follow up if I run into any issues with my solution.
-zatch

Thanks for the error report. This is now fixed in the dev branch :)

Works like a charm in the 2.4.2 build -- thanks!
On Sun, Jul 26, 2015 at 8:02 AM, Richard Davey<EMAIL_ADDRESS>wrote:

Thanks for the error report. This is now fixed in the dev branch :)
—
Reply to this email directly or view it on GitHub
https://github.com/photonstorm/phaser/issues/1939#issuecomment-124975826
.


Support for Docker

Please add Dockerfile to support docker install.

@chivee Hello, please clarify your action?

will moving issues to application repos

@loretoparisi , could you clarify what's docker do you requested for? For lightLDA and mutiverso applications please refer to https://github.com/Microsoft/DMTK/wiki/Run-in-docker

@chivee thank you.


feat: Keyboard shortcut to move to next calibration step

Overview
It would be nice to have a keyboard shortcut to move to the next step in calibration.
Especially when the robot is far away from where your computer is.
I have set my Z for my pipette on the calibration block.
I want to move on to the next calibration step.

This keyboard shortcut should be hard to press by accident.
Implementation details
On my computer using Ctrl + Alt + Shift + Pg Up is not mapped to anything.
That keybinding is my suggestion, but it could be whatever makes sense.
It might be nice to have Ctrl + Alt + Shift + Pg Down go back to the previous calibration step.
Design
None
Acceptance criteria
When I press Ctrl + Alt + Shift + Pg Up it moves on to the next step in the calibration.
When I press Ctrl + Alt + Shift + Pg Down it goes back to the previous step in the calibration

Lol I've definitely counted and memorized the number of tabs it takes to highlight the "next" button for some of these flow in the past. Something like tab x7 + space to proceed 🙃


Figure out what's wrong with contentSources tracking.

See #550.

4.0 simplifies source map tracking so this may be gone too. Let's see if it's still a problem to anyone.


Add "response.redirected" property support

As described in https://developer.mozilla.org/en-US/docs/Web/API/Response/redirected
If any redirection happened, it will be equal to true. Otherwise it will be equal to false.
There is two basic test is the commit to cover this property.

Mistakenly thought this to solve my recently added issue #517  😜

I think this is largely fine to end users, though it seems the spec has changed quite a lot, there is a URL List now which redirected getter is required to check.
https://fetch.spec.whatwg.org/#concept-response-url-list
https://fetch.spec.whatwg.org/#dom-response-redirected

I think this is largely fine to end users, though it seems the spec has changed quite a lot, there is a URL List now which redirected getter is required to check.
https://fetch.spec.whatwg.org/#concept-response-url-list
https://fetch.spec.whatwg.org/#dom-response-redirected

Thanks for the link !
To follow the specs, we should have in Response object an internal array containing URL of previous redirection (if i understood correctly, as i cannot find an example of implementation...).
It should be used also for the Response.url method that need to return the last element of this array.
So it's really doable, but this implies more internal modifications and thus more testing than this little commit. And Response.redirected is the only way to know that a redirection happened without handling redirection manually ...
For the moment i think we should push this and modify methods in a later commit when the internal URL list will be added to respect the specs 👍

Just needed this feature atm.

sorry for the late update, this is now available in v2.5.0, thx @410stats !


chore: change to WebEnvironment.MOCK in tests.

It fixes migration to next vaadin version 24.4.x
See: https://github.com/vaadin/hilla/issues/2169

Hi @manolo! Is the webEnvironment parameter is required at all? Removing the parameter completely has no impact on the tests.  Looking at MainViewTests, I can't see the need for a server to start.
The tests in MainViewTests (and also CrudWithVaadinApplicationTests) look like unit tests similar to these tests as referenced in this guide. These tests look different than the end to end tests defined in this class and this section of the guide that do require a server to start. I can't see any end to end tests in this repo.
If this issue shows up in 24.4, perhaps we can address this PR with an upcoming version bump of Vaadin. It looks like 24.4 is due out this month. What do you think?

Hi, @robertmcnees here is the PR to upgrade this project to Vaadin 24.4, and it needs this fix to pass.

Thanks for the PR @manolo and the context @ZheSun88. I merged this PR so that the tests would pass when upgrading the Vaadin version to 24.4.1.
This repository is now managed by dependabot so if a scenario like this arises again we should be able to push additional commits to the dependabot PR when the CI build fails. Hopefully that makes our workflow easier to sustain going forward.
Thanks for your contribution!


Update License

Update License with copyright --> Copyright (c) 2022-Present Ploomber Inc.

can you fix the _config.yml as well?

just added!

make sure you push, I only see one edited file


VEP Annotations and FAF information for cohort studies

Hi, it would be really helpful if VEP annotations could be included or if you had any good ideas on how to cross reference. Currently I'm having to generate vcfs for the positions I'm interested in and use ensembl's VEP annotation program.
Similarly, Filtering Allele Frequency would be very useful.

Hi @weewus ,
thank you for your interest! Unfortunately, including VEP annotations isn't feasible because a single variant can be linked to multiple genes, complicating the database logic. Similarly, handling Filtering Allele Frequency would add complexity, making it impractical within the current system.
Please let me know if you have further comments.
Best,
Kalin

Hey sorry, I missed this reply. Thanks for the clarification.
What about homozygous count? This isn't something that's otherwise intuitable/possible to annotate after the fact.
This would be pretty useful for recessive studies.
Cheers,
Andreas


add back managed disk issue

the managed disk re-register issue still valid in 1809, remove it from fixed bug and add back to known-issue

@GeorgeH-MS : Thanks for your contribution! The author, @sethmanheim, has been notified to review your proposed change.

@GeorgeH-MS Thank you. If you used the private repo azure-docs-pr, it would be much easier for me to perform a technical review of your added content. #sign-off

Thanks Seth, I'll be aware of this next time.


add banner to regional page

Nav links appearing on overview page on small screen

I think it would be good to change font-color to the same orange as overview banner for "Regional Restrictions" and capitalise both first letters or neither

Just wanted to add that running the tests in the functionalTest folder has 3 failing, but these are the ones Donal and I fixed in the functionalTestHeatmapSelectorV2 branch I just merged

I've taken on board all of the feedback and updated it a lot. I have merged with master and just need to run the functional tests before pushing.


[Feat]: Allow specifying user and group scopes with OIDC authentication

Is your feature request related to a problem? Please describe.
It should be possible to specify which claim to use for the user ID. Some users might want to use email, others might want to use sub.
Additionally, it should be possible to select a claim which is used for groups. This is already possible with LDAP: https://github.com/project-zot/zot/blob/002ff05f6e5ab3870aca75e616e8a4ed9b4a5c68/pkg/api/config/config.go#L165
Describe the solution you'd like
Add userclaim and groupsclaim to OIDC provider config
Describe alternatives you've considered
No response
Additional context
No response

@AndersBennedsgaard thanks for doing a thorough evaluation and identifying improvements for zot.
We would also respectfully urge you to consider posting PRs.

I have opened PRs in OSS projects before which have been closed with a "we do not agree with this" explanation. So I don't create PRs before I get an approval from the developers that it is something they want. If you do think it's a good improvement, and wouldn't mind contributions for it, you can say that you agree and add the https://github.com/project-zot/zot/labels/good first issue label


The terraform azure provider v0.3.0 requires "account_replication_type" and "account_tier"

https://www.terraform.io/docs/providers/azurerm/r/storage_account.html
Warnings:

  * azurerm_storage_account.azure_bosh_sa: "account_type": [DEPRECATED] This field has been split into `account_tier` and `account_replication_type`

2 error(s) occurred:

* azurerm_storage_account.azure_bosh_sa: "account_replication_type": required field is not set
* azurerm_storage_account.azure_bosh_sa: "account_tier": required field is not set

Fixed by #9


UIUtil - Utility Class Conventions

This small change will simply make the class a utility by making it final and uninstantiable.

thanks!


Issue installing Saleor on Windows

(Please take the time and describe the problem you're having before you propose a solution.)
What I'm trying to achieve
Getting Saleor up and running on Windows 8/10.
...
Steps to reproduce the problem
1.Running python migrate.py
2.
What I expected to happen
Install the DB and other settings
...
What happened instead/how it failed
raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.
This is the stack trace:

This is the settings.py file:

After giving a random secret key, i get the message:
from django.urls import path
ModuleNotFoundError: No module named 'django.urls'
My pip freeze is:

I dont know if the problem is the Django version i am running or the inability of manage.py to fetch a SECRET_KEY....
...
(Please include a stack trace if this problem results in a crash.)

Hi @alexmzirai,
Have you set your SECRET_KEY env variable?
Take a look at point 4:  https://saleor.readthedocs.io/en/latest/gettingstarted/installation-windows.html

Any advice on how to add that secret key env variable?
this is my sample secret key...

I think this one might be helpful
https://superuser.com/questions/949560/how-do-i-set-system-environment-variables-in-windows-10
Have no experience setting up Saleor on Windows 10, can't help other than googling.

i assigned a secret key directly...it worked.
Now i'm getting a Postgres user error.

@alexmzirai You will need to create a user and a database in your PostgreSQL instance. This is mentioned in the installation docs.

The database is already up and running.
I dont know why the connection is not going through for user "saleor".
Let me read the docs again and see if i missed something.

Created the role "saleor" under the saleor DB.
Apparently the issue was that the "CREATE ROLE" command wasn't executing right.
Finally got it fixed.

It has finally worked.
@Pacu2 @patrys , thank you.

i assigned a secret key directly...it worked.
Now i'm getting a Postgres user error.

hi how do you set up the Environment Variable? Because I am stuck here too.

Any advice on how to add that secret key env variable?
this is my sample secret key...

hi how do you set up the Environment Variable? Because I am stuck here too.

thank you soo much your ticket help me alot ..

That depends on what operating system and shell you use. In UNIX-based systems you would usually use the export command. There is a lot of resources online, look for "setting environment variables in [your OS name]".


[SPARK-7042][BUILD] use the standard akka artifacts with hadoop-2.x

Both akka 2.3.x and hadoop-2.x use protobuf 2.5 so only hadoop-1 build needs
custom 2.3.4-spark akka version that shades protobuf-2.5
This partially fixes SPARK-7042 (for hadoop-2.x builds)

Hm, It seems that I made mistake creating https://github.com/apache/spark/pull/6253
Re-creating pull request properly this time.

Can one of the admins verify this patch?

Ok to test

I think that makes sense; @pwendell does that make sense to you ? I wasn't sure about all of the requirements that drove the need for a shaded Akka. Was it just protobuf 2.4?

Jenkins, test this please

Merged build triggered.

Merged build started.

Test build #33463 has started for   PR 6341 at commit 7eb8c60.

Test build #33463 has finished for   PR 6341 at commit 7eb8c60.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33463/
Test PASSed.

LGTM - just for documentation, the changes I made to akka are available here:
https://github.com/pwendell/akka/commits/2.2.3-shaded-proto
The only downside of this patch is that we're no longer protected if akka or hadoop decides to use a new protobuf version. However, I think that's fine (we'll just have to continue to monitor it going forward).