v3 doc: Prettier hasn't supported MDX v2 yet

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description
https://docusaurus.io/docs/next/markdown-features/admonitions#usage-with-prettier
Prettier hasn't supported MDX v2 yet.
https://github.com/prettier/prettier/issues/12209
We'll have to advise users to stop formatting MDX by Prettier for a while after upgrading Docusaurus to v3.
What page should we add this admonition?
Self-service

[x] I'd be willing to address this documentation request myself.

We handle a few exceptions in our own code, using comments:

This is just because the official documents doesn't use many React components in MDX. Such a cheap trick won't work for documents that use React components frequently. They'll have to pollute themselves with too many prettier-ignore's to be ignored. If it's not a hassle for users to add prettier-ignore to every incompatible part, we won't have to tell them to stop using Prettier. It depends on whether it is painful for them or not but is for some of them. What we should tell to users is just "If it's a pain, you may as well suspend using Prettier for MDX".

Note: we are not the first to use MDX v2, and if you look at other systems like Nextra or Astro they don't mention Prettier not supporting MDX v2 officially in their docs.

We are the last to use MDX v1 as far as I know.
Many MDX v2 users have often claimed Prettier had "defects" in the MDX formatting feature in issues in Prettier. (the identity of the "defects" is just the mismatch of MDX versions)

Not sure what to do but if you want to submit a proposal PR please do and we'll discuss it from there.
I don't think Prettier works less well with MDX v2 that v1.
And most sites will probably, like the Docusaurus site, not have extensive usage of inline React code inside MDX docs. Most Docusaurus sites still use the historical .md extension, and prettier will not format MDX elements very well with that extension anyway 😓
And Prettier is not the only problem: our "i18n SaaS" Crowdin also has limited MDX support, with a workaround proposed here: https://docusaurus.io/docs/next/i18n/crowdin#mdx

Note we already recommend declaring complex JSX code outside of Markdown files here:

I think we can still stand by this practice of avoiding inline React/JSX code if possible:

when using versioning it leads to duplicate logic
when using i18n/Crowdin it often leads to bad translated content output that doesn't compile (Crowdin bugs)
when using Prettier it leads to bad formatting

That could be a good place to put an extra admonition?

Not sure what to do but if you want to submit a proposal PR please do and we'll discuss it from there.

I will. I'll recommend to Prettier + MDX users to try prettier-ignore first.

And most sites will probably, like the Docusaurus site, not have extensive usage of inline React code inside MDX docs. Most Docusaurus sites still use the historical .md extension, and prettier will not format MDX elements very well with that extension anyway 😓

Now that you mention it, most documents for software don't have to use features beyond Markdown coverage too much.


BETWEEN with COLLATE NOACCENT.NOCASE expression results in a segfault/ASan failure

Consider the following statements:
CREATE TABLE t0(c0 DATE, c1 VARCHAR);
INSERT INTO t0(c0) VALUES (NULL), ('2000-01-01');
SELECT * FROM t0 WHERE 'a' BETWEEN c0 AND c1 COLLATE NOACCENT.NOCASE; -- segfault

Unexpectedly, the SELECT causes an ASan failure (the initial test case crashed the JVM when using the JDBC driver):
AddressSanitizer:DEADLYSIGNAL
=================================================================
==27945==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x561f1a6c2d18 bp 0x7ffccd196060 sp 0x7ffccd196040 T0)
==27945==The signal is caused by a READ memory access.
==27945==Hint: address points to the zero page.
    #0 0x561f1a6c2d17 in duckdb::Utf8Proc::Analyze(char const*, unsigned long) /duckdb/third_party/utf8proc/utf8proc_wrapper.cpp:28
    #1 0x561f1a6d60b8 in duckdb::string_t::Verify() /duckdb/src/common/types/string_type.cpp:13
    #2 0x561f1a6edcf7 in duckdb::Vector::UTFVerify(duckdb::SelectionVector const&, unsigned long) /duckdb/src/common/types/vector.cpp:605
    #3 0x561f1ae3a88a in duckdb::ExpressionExecutor::Execute(duckdb::BoundFunctionExpression&, duckdb::ExpressionState*, duckdb::SelectionVector const*, unsigned long, duckdb::Vector&) /duckdb/src/execution/expression_executor/execute_function.cpp:40
    #4 0x561f1a97fccc in duckdb::ExpressionExecutor::Execute(duckdb::Expression&, duckdb::ExpressionState*, duckdb::SelectionVector const*, unsigned long, duckdb::Vector&) /duckdb/src/execution/expression_executor.cpp:146
    #5 0x561f1ae38070 in duckdb::ExpressionExecutor::Select(duckdb::BoundComparisonExpression&, duckdb::ExpressionState*, duckdb::SelectionVector const*, unsigned long, duckdb::SelectionVector*, duckdb::SelectionVector*) /duckdb/src/execution/expression_executor/execute_comparison.cpp:82
    #6 0x561f1a98008d in duckdb::ExpressionExecutor::Select(duckdb::Expression&, duckdb::ExpressionState*, duckdb::SelectionVector const*, unsigned long, duckdb::SelectionVector*, duckdb::SelectionVector*) /duckdb/src/execution/expression_executor.cpp:171
    #7 0x561f1ae39719 in duckdb::ExpressionExecutor::Select(duckdb::BoundConjunctionExpression&, duckdb::ExpressionState*, duckdb::SelectionVector const*, unsigned long, duckdb::SelectionVector*, duckdb::SelectionVector*) /duckdb/src/execution/expression_executor/execute_conjunction.cpp:80
    #8 0x561f1a9800c0 in duckdb::ExpressionExecutor::Select(duckdb::Expression&, duckdb::ExpressionState*, duckdb::SelectionVector const*, unsigned long, duckdb::SelectionVector*, duckdb::SelectionVector*) /duckdb/src/execution/expression_executor.cpp:173
    #9 0x561f1a97ed10 in duckdb::ExpressionExecutor::SelectExpression(duckdb::DataChunk&, duckdb::SelectionVector&) /duckdb/src/execution/expression_executor.cpp:60
    #10 0x561f1b1d62f1 in duckdb::PhysicalFilter::GetChunkInternal(duckdb::ClientContext&, duckdb::DataChunk&, duckdb::PhysicalOperatorState*) /duckdb/src/execution/operator/filter/physical_filter.cpp:44
    #11 0x561f1a98a87b in duckdb::PhysicalOperator::GetChunk(duckdb::ClientContext&, duckdb::DataChunk&, duckdb::PhysicalOperatorState*) /duckdb/src/execution/physical_operator.cpp:45
    #12 0x561f1b219a54 in duckdb::PhysicalProjection::GetChunkInternal(duckdb::ClientContext&, duckdb::DataChunk&, duckdb::PhysicalOperatorState*) /duckdb/src/execution/operator/projection/physical_projection.cpp:22
    #13 0x561f1a98a87b in duckdb::PhysicalOperator::GetChunk(duckdb::ClientContext&, duckdb::DataChunk&, duckdb::PhysicalOperatorState*) /duckdb/src/execution/physical_operator.cpp:45
    #14 0x561f1b1d70f6 in duckdb::PhysicalExecute::GetChunkInternal(duckdb::ClientContext&, duckdb::DataChunk&, duckdb::PhysicalOperatorState*) /duckdb/src/execution/operator/helper/physical_execute.cpp:8
    #15 0x561f1a98a87b in duckdb::PhysicalOperator::GetChunk(duckdb::ClientContext&, duckdb::DataChunk&, duckdb::PhysicalOperatorState*) /duckdb/src/execution/physical_operator.cpp:45
    #16 0x561f1a9d84fd in duckdb::ClientContext::FetchInternal() /duckdb/src/main/client_context.cpp:153
    #17 0x561f1a9d9d98 in duckdb::ClientContext::ExecutePreparedStatement(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, duckdb::PreparedStatementData&, std::vector<duckdb::Value, std::allocator<duckdb::Value> >, bool) /duckdb/src/main/client_context.cpp:232
    #18 0x561f1a9dc751 in duckdb::ClientContext::RunStatementInternal(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::unique_ptr<duckdb::SQLStatement, std::default_delete<duckdb::SQLStatement> >, bool) /duckdb/src/main/client_context.cpp:340
    #19 0x561f1a9dd0d7 in duckdb::ClientContext::RunStatement(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::unique_ptr<duckdb::SQLStatement, std::default_delete<duckdb::SQLStatement> >, bool) /duckdb/src/main/client_context.cpp:367
    #20 0x561f1a9dbb49 in duckdb::ClientContext::Execute(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::vector<duckdb::Value, std::allocator<duckdb::Value> >&, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) /duckdb/src/main/client_context.cpp:311
    #21 0x561f1a9f542b in duckdb::PreparedStatement::Execute(std::vector<duckdb::Value, std::allocator<duckdb::Value> >&, bool) /duckdb/src/main/prepared_statement.cpp:37
    #22 0x561f1a6a2810 in sqlite3_step /duckdb/tools/sqlite3_api_wrapper/sqlite3_api_wrapper.cpp:195
    #23 0x561f1a67c1d7 in exec_prepared_stmt /duckdb/tools/shell/shell.c:9899
    #24 0x561f1a67dfb7 in shell_exec /duckdb/tools/shell/shell.c:10187
    #25 0x561f1a69739d in runOneSqlLine /duckdb/tools/shell/shell.c:15047
    #26 0x561f1a697cd7 in process_input /duckdb/tools/shell/shell.c:15149
    #27 0x561f1a69a3e4 in main /duckdb/tools/shell/shell.c:15817
    #28 0x7f6e102a7b6a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x26b6a)
    #29 0x561f1a6577c9 in _start (/duckdb/build/debug/duckdb_cli+0x9067c9)

I found this based on commit 22a5f36ee41542c915c73dc44d90d29fcbe9cbcb.

Thanks! This was a problem with the verification code itself. I had rewritten it recently and the verification code did not correctly handle the case where only a part of the expression was evaluated, leading to it accessing the wrong value. In this case it accessed the string value where the NULL value was supposed to be, which is undefined but usually by chance set to nullptr. This lead to the sanitizer triggering.

Thanks for the explanation! Just to confirm: The verification code also runs in release builds, right? I assume this, since the original test case had crashed the JVM. However, when I ran the unmodified test case on a release build without JDBC, it did not trigger a segfault. I had assumed that this might be due to a different memory layout or memory allocator.

The verification should not run in release mode; it is surrounded by an #ifdef DEBUG. I'm not sure how exactly the Java client is build, though. It is possible that for some strange reason DEBUG is defined there even in release mode.

Ok, thanks. I'll investigate this further, then.


OCM-2720: rosa_oidc_config tf resource: Recreate resource if it was deleted not from tf

OCM-2720: rosa_oidc_config tf resource: Recreate resource if it was deleted not from tf
tested manually by deleting cluster then deleting oidc-provider and running terraform apply, everything was recreated

/lgtm
/approve


Matcher.somethingLike not working according to the docs?

We are in the process of covering our mobile apps with contract testing using Pact tests.
After successful initial setup and tests, we started to take a step further and start testing type matching instead of strict value matching but have hit a roadblock as we cannot find swift documentation on how to use this feature and any sample codes we could find followed the same pattern as our code
this is how we are setting up helloProvider (we tested on top of the sayHello sample code):
helloProvider!.uponReceiving("a request for hello")
              .withRequest(method:.GET, path: "/sayHello")
              .willRespondWith(status: 200,
                               headers: ["Content-Type": "application/json"],
                               body: ["reply": "Hello",
                                      "user": Matcher.somethingLike("Me")])

Pact tests target compiles fine but then fails when running:
.../Pact Tests/Pact_Tests.swift:27: error: -[Pact_Tests.Pact_Tests testItSaysHello] : Error setting up pact: Error
This is obviously related to  "user": Matcher.somethingLike("Me") as when we replace it with  "user": "Me" the test runs fine, but we could not find any way to make it work with type matching as we need to
I assume Matcher.somethingLike works fine and its our implementation that is not ideal, but honestly speaking we did our best to search for solution across your docs but found very little regarding type matching in swift.
Thanks in advance for any support, we promise to do our best to spread the knowledge

Hi @Nonnus what you are doing looks OK, as far as I can tell. We have a very similar test here: https://github.com/DiUS/pact-consumer-swift/blob/master/Tests/PactConsumerSwiftTests/PactSpecs.swift#L245
There should be a generated log file, assuming it is getting that far. By default the log file is generated in the ./tmp/pact.log (unless you've configured the mock server to startup with a different --log ).
If you could share the contents of the log file, or even better, a sample project reproducing the problem, we could probably help you more.


Fix BoundingBox from_float() upper bounds

This is yet another fix for BoundingBox.from_float().  In the case where the upper bound is at the pixel edge (e.g. xmax=2.5), the code was effectively rounding up and then adding 1.  In those cases, the bounding box upper bound is too large by one pixel.
In other words, the lower and upper bounds were treating x.5 pixel inputs the same (rounding the same way).  But because these represent boundaries, we want them to "round inward".
Example:
from regions.core import PixCoord
from regions.shapes.circle import CirclePixelRegion
center = PixCoord(25.0, 25.0)
reg = CirclePixelRegion(center, 4.5)    # NOTE the half-pixel radius here
mask = reg.to_mask(mode='exact')
plt.imshow(mask)

New:

Old:

@larrybradley - Thanks!
Some suggestions:

So this PR is about fixing something right on the edge? Should the behaviour on the edge now be well-defined? Can we state a guarantee or at least the intent for the edge at https://github.com/larrybradley/regions/blob/08d57c8c11c807121cda1055ec86126f760aeaf7/regions/core/bounding_box.py#L87 ? If it's a guarantee, we could add a test for the behaviour?
Maybe add a code comment explaining the implementation? That could be useful for future developers that will not find the pull requests leading to this implementation, and might be tempted to just use a simpler int() call and not realise why this is needed, i.e. to get edge cases and negative numbers rounded correctly. Above you say "round inward", but I think the floor at the min and ceil at the max is "round outward"?
Can we please make _from_float public? It's so tricky to get right, and we have similar code in Gammapy for sky map cutout / pasting that I'd like to replace by this. I think as a classmethod from_float here could be fine, but a separate utility function would be fine with me as well.

@cdeil  Yes, this fixes a literal edge case.  It's a guarantee modulo possible float-point errors.  If radius=4.5 gets stored as4.50000001 then there's going to be an extra 1 pixel added to each side (top, bottom, left, right) of the bounding box (stored as 4.4999999999 will work as expected).  However, I don't think there's anything we can do about that.
I worry a bit about make _from_float public because it behaves somewhat differently from the __init__ function.  _from_float adds a 1 to the upper bounds to account for the exclusive upper index.  The __init__ function doesn't do this (it assumes you have already done it).
Example:
>>> from regions import BoundingBox
>>> BoundingBox(ixmin=1, ixmax=10, iymin=2, iymax=20)
BoundingBox(ixmin=1, ixmax=10, iymin=2, iymax=20)

>>> BoundingBox._from_float(xmin=1, xmax=10, ymin=2, ymax=20)
BoundingBox(ixmin=1, ixmax=11, iymin=2, iymax=21)

That could be very confusing even though the difference is explained in the documentation.  If you want to make it public, perhaps _from_float should be renamed?

@larrybradley - I see your point.
I'd still like to have it publicly available, because calling private methods from other parts of the package (see https://github.com/astropy/regions/search?utf8=✓&q=_from_float) or other Python packages (like Gammapy) is bad. And if it's private, it doesn't show up in the docs, and I can't link to a docs URL to point it out to people.
Concerning method name (or even relocating to somewhere completely else), I don't have a suggestion. If you agree to the change to make it public, maybe you can come up with something?

@cdeil  I don't have a good name.  @astrofrog?

One option I was thinking about was to always go via regions.RectanglePixelRegion which does support floats, and then access it's bounding_box to do what _from_float does now.
But I don't actually think it's a good suggestion. RectanglePixelRegion has data members of center and width / height, not min / max of corners, and it can have an angle.
There's several other possible solutions: allow float in bounding box init, and add a method or attribute that goes to int index. Or have a separate class for float bounding boxes. Or mostly keep as-is and try to find a good name.
I don't know which of these options would be best here, or have a suggestion for a good name.
Let's wait and see if someone comes up with a good suggestion.
And if now, maybe BoundingBox.from_float with a good docstring would be acceptable?

What about max_extent instead of _from_float?

@sosey - Thanks for the suggestion!
Personally I would prefer BoundingBox.from_float over BoundingBox.max_extent because the from_* pattern is common in Python for classmethods to create something and feels familiar, whereas max_extent sounds like a property to me.
@larrybradley - Unless others chime in, could you please make the call here on naming and then merge this?
(I'd like to make the regions 0.2 release)

@cdeil  I made from_float public.

@cdeil - I've merged this as it was all green. Now regions should be ready for 0.2.

@larrybradley - Thanks!


fix: backport #18367,augment hash for CSS files to prevent chromium erroring by loading previous files

Description

/ecosystem-ci run

@dominikg @bluwy @Rich-Harris @benmccann
SvelteKit and vite-plugin-svelte is failing probably because of svelte v4 -> v5 change.
I guess this PR won't break anything, but postpone cutting the patch for a day or so if you prefer to look into the fail.

vite-plugin-svelte passed (https://github.com/vitejs/vite-ecosystem-ci/actions/runs/11458010458/job/31879504816). Going to cut the patch tomorrow morning (~16 hours later).

Released v5.4.10


Resizing SubViewportContainer with stretch enabled changes render resolution of child SubViewport

Godot version
v4.0.alpha9.official.fc18891db
System information
Linux
Issue description
When resizing a SubViewportContainer with stretch enabled, the size of the child SubViewport is changed to the size of the container.
What this does is to undo all the "stretching", since the resolution of the viewport is now the same as the displayed resolution. This is unexpected of a property named stretch, if this were intentional a more fitting name would be auto_resize.
This problem was present in Godot 3 as well, but it wasn't hard to write something like this to preserve the size of the viewport:
func _on_Viewport_size_changed(): # connected to signal "resized" in Viewport
	if size == correct_size:
		return
	size = correct_size

But in newer alpha versions Godot 4, this workaround stopped working consistently, especially inside nested containers. So this is what I resorted to:
func workaround_hack():
	for i in 3: # with one iteration, this fails up to 50% of the time
		await get_tree().process_frame
		$SubViewport.size = correct_size

This is very inelegant, and I don't see how SubViewportContainer messing with viewport sizes would be intended behavior in the first place.
Steps to reproduce

Create a SubViewport inside a SubViewportContainer
enable stretch on SubViewportContainer
add icon.png or an image of your choice to the SubViewport, and set viewport size to the image dimensions
the texture should "stretch" and fill the entire parent container's size, just like a TextureRect set to STRETCH_SCALE
resize the container
instead of staying stretched to fit the container, the image is no longer scaled, unless you use a "workaround"
the above also caused the size of the SubViewport to change

Minimal reproduction project
MRP_SubViewportContainer.zip

Open main.tscn in editor
Resize the root Control
Notice both the viewport and icon.png changing size

In my opinion, SubViewport seems to be a pipe. Render a 2D/3D scene to a 2D texture. And SubViewportContainer is an adapter that converts SubViewport to Control.
In this way, the size property is the sampling resolution of the source, and size_2d_override is the resolution of the render target. Currently, size_2d_override only seems to work in get_visible_rect.
This is just my guess, maybe I'm wrong.

I can confirm that this still happens with Beta 10

The workarounds also don't work anymore. The data of the subviewports size property properly changes, but the SVPs don't properly fill the viewport

Still happens in Godot v4.1.1 stable.
As a workaround I set in the SubViewportContainer the "stretch_shrink" property to 2, to half the render resolution of the child SubViewport. This isn't ideal, because my display resolution is 1280x720, so the SubViewport will be 640x360 and I need another resolution...

I can't reproduce this. Downloaded the minimal project, resized the subviewportContainer, and the icon does not stretch.

@djpeach it looks to me like you are reproducing the issue. Right now there is no sensible way to scale a SubViewport, since SubViewportContainer enforces a 1:1 pixel ratio in all cases

I am actually reproducing that as well.
A subviewport cannot have resolution stretch as a window can get.

Still happens in Godot v4.1.1 stable. As a workaround I set in the SubViewportContainer the "stretch_shrink" property to 2, to half the render resolution of the child SubViewport. This isn't ideal, because my display resolution is 1280x720, so the SubViewport will be 640x360 and I need another resolution...

This indeed resize the actual Subviewport from origin resolution, but then requires unticking scale parameter to apply.
And this workaround being integer based, any resolution between 1 and 2 are unavailable.

EDIT: Setting the original resolution on Subviewport "size_2d_override", and target resolution on its "size" makes the viewport actually respect its resolution and scale to. Which works for me 🎉

Yes, it works.
It might be worth detailing in the documentation the correct usage of these related properties.


I dont know

Description
The Prog was in the background
:-)
And suddenly .... it reported a problem
Steps To Reproduce
....
Requirements

e.g. Fix crash that occurs when...
....

Files Version
<IP_ADDRESS>
Windows Version
11 Home 64 - Ver 23H2 BUILD 22631.2715
Log File
debug.log

Thanks for the report, In future please make an actually title with a summary of the issue with more details in the description so it not marked as spam.
Was Files doing anything while it was in the background?

Hi
No ....
Nothing
I don't know what went wrong
:-)
בתאריך יום ג׳, 21 בנוב׳ 2023 ב-14:10 מאת Josh65-2201 <
@.***>:

Thanks for the report, In future please make an actually title with a
summary of the issue with more details in the description so it not marked
as spam.
Was Files doing anything while it was in the background?
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/13995#issuecomment-1820801097,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEBHFFLQJ6LFXRW2GM42ABLYFSK3VAVCNFSM6AAAAAA7UJ2DACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQHAYDCMBZG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
ניצן ...

Was the app window open when the error occurred?

@niznaz


Android webview killing itself when loading pdf in webview

Attach (recommended) or Link to PDF file here: https://prawnpdf.org/manual.pdf
I am trying to create an android webview to load PDF files. It works fine. But in Andriod Nougat, it will load, and in a couple of seconds, it will close the webview. The issue is only seen for files larger than 1 MB. Smaller files are loading without issue.
Configuration:

Web browser and its version: android.chrome version 86.0.4240.110
Operating system and its version: Android Nougat MiUI
PDF.js version: 2.6.347

Steps to reproduce the problem:

In the android Nougat, opening the webview and loading the pdf file.
webview is closed after loading initially

What is the expected behavior? (add screenshot)
The pdf should load and not close the webview automatically.
What went wrong? (add screenshot)
The pdf is getting closed automatically

I am trying to create an android webview to load PDF files. It works fine. But in Andriod Nougat, it will load, and in a couple of seconds, it will close the webview.

That sounds like a bug in the platform itself, rather than in the PDF.js library, in that case. Hence that's not really something that we can fix here, since the PDF.js simply uses standard web-functionality (e.g. <canvas> for rendering).
Furthermore, according to https://en.wikipedia.org/wiki/Android_version_history#Android_7.0_Nougat_(API_24) the last release from that branch was more that three years ago (in April, 2017)

This issue is basically due to the platform itself. Also could you please confirm you are using MIUI (Xiaomi's  UI). If yes, please tell me the current UI version you are using as the PDF.js library is working fine __Tested It BY Myself.__Please do provide the answers as I am pretty much sure that it is a platform based issue not the PDF.js library.
Do, update to any latest version of your UI if available.

Closing because of the above. You're most likely hitting a resource limit, causing the webview to be closed. That's a platform issue.

The solution should not always be a soap type answer.


🐛 [Core] Unable to set FirebaseOptions at runtime

Bug report
Describe the bug
I have GoogleService-info.plist and google-service.json embedded properly in the project (works as expected).
Then I was also trying to use Firebase.initializeApp(options:) to set a different set of configurations manually during app launch via initState() of the root StatefulWidget, in order to enable the app with multiple environments. But the configurations being picked up were always what was written in the physical google service files.
Steps to reproduce
Steps to reproduce the behavior:

Add GoogleService-info.plist and google-service.json to the iOS and Android project as per described in the documentation.
In the root StatefulWidget, do

final app = await Firebase.initializeApp(options: {OPTIONS});
FirebaseAuth.instanceFor(app: app);

Go through standard username and password sign up process

Expected behavior
User is registered under the corresponding environment

Additional Questions
I think this might be expected behaviour. But if that is the case, when and where should initializeApp(options:) be used? Besides, based on what the physical file contains, it seems more of less a replicate of FirebaseOptions. Not sure why having this physical file is mandatory?

@sima-11
I believe there's similar open discussion describing your case, https://github.com/FirebaseExtended/flutterfire/discussions/5626. Please follow-up there for updates and any questions you may have.
Closing this as duplicate. If you disagree, write in comments and I'll reopen it.
Thanks.

@darshankawar Thanks for coming back to me. I checked the thread you suggested, but it was quite old (almost a year ago). I was using the latest package (version 1.3.0), but it didn't seem to allow me changing environment at runtime.
As I couldn't find info about whether this has been completed, some guidance would be very helpful (Also some confirmation about whether we can ditch the physical config file would also be quite helpful. As currently it seems a bit confusing).
If the feature is ready to use, there might then be a bug with it?

@darshankawar Just to follow up and see if there's any update.

@darshankawar It's been 11 days, man.

Guys, is it common to wait for 21 days for a reply?


Implemented the selfies / mirroring of coordinates. You can also search for selfies by typing in the lens, which in that case is "front camera". There is no option yet in the light box to delete a face though.

Cool, will this also be part of the upcoming release?

Yes :)


minor grammatical error

Summary
Just wanted to fix a grammatical error within the website documentation. I am thinking the other requirements of this description won't be necessary.

Test plan

Not really sure that this is an error.
I think both are fine.
some explanation

Read the webpage. Good point. Going to close the PR. Thank you


[Event Request] On codeunit 1250 & 1252 function "ShowMatchSummary" just like codeunit 1255

Hello,
Codeunit 1250 & 1252 should have same overridden pattern as codeunit 1255. We need event in "ShowMatchSummary" function to suppress message dialog. Same event is already defined in codeunit 1255 but not available in 1250 & 1252.
Codeunit 1252:

Codeunit 1250:

Codeunit 1255: This is how we like to have in Codeunit 1252 & 1250. Same overridden pattern.

Thanks.

@iambjaved in general it's better if you split your requests into one issue per request.
Additional it is better if you add the requested event signature as text, that can be easy copied instead of only some screenshots.
The better you prepare your request, the faster they can be implemented by someone of microsoft.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10846.


Import from Microsoft OneNote

Describe the feature you'd like
Ability to import pages and sections from a Microsoft OneNote notebook.
Describe the benefits this feature would bring to BookStack users
Attract more potential users who are actively using OneNote but not making the switch to BookStack due to high amount of pages they have accumulated over the past several years.
Additional context
N/A

Hi @bisherbas,
Thanks for this request.
I think this will be very tricky due to the flexible nature of one-note content along with the complex formats for Microsoft documents.
The benefit listed, "Attract more potential users", In my view will always remain a lower priority than things that will enhance the experience for existing users although I can understand the benefit of importing existing content.
Will leave this open-to-discussion for a while, Incase someone knows a simple way this can be done, but I may close this at some point if no simple option can be identified.

@ssddanbrown
Not trying to be the pessimist but I was trying out Notion and noticed that they are able to import from many different apps except Microsoft OneNote. Perhaps my request is not really that easy if not impossible...

Microsoft provides a REST API for their online services. At least for the users who choose to upload their notebooks it should be pretty easy to export full notebooks. Their page object returns valid HTML content so you just have to extract the images and store the HTML in the database. See more details here: https://docs.microsoft.com/en-us/graph/api/page-get?view=graph-rest-1.0

Is there a "For dummies" version on how to do that?  I have a ton of onenote notes and would like to switch.


Added goToStep function

The goToStep function takes in a step and will step through the tutorial until that step is active.
NOTE: there probably is a more efficient way than calling changeStep but this was the easiest way to implement this feature.
Manual Testing was done and succeeded.

Changed code from Travis-CI results


Plotting contour with VisIt

Hello,
I am trying to plot the contour of a variable with VisIt but I get an error message saying that "the Contour plot of variable *** yielded no data".
I use the MFEM-built object VisItDataCollection to dump the numerical solution in output files readable by VisIt.
Has anyone been able to plot contour in VisIt from a MFEM solution?
Thanks,

I assume this is a scalar variable, e.g. the pressure from an Example 5 run?
Can you do a "pseudocolor" plot of it? Does the contour operation work on the Example 5 output for you?
Tzanio

Tzanio,
thanks for your reply. I run Example 5 and I can plot the contour with
VisIt. The problem only shows when I try to visualize the data from my
MFEM-based code. As far as I know, I follow the same workflow as in Example
5 to output data in readable VisIt format. I will have to compare the codes.
Thanks,
On Wed, May 20, 2020 at 11:45 AM Tzanio Kolev<EMAIL_ADDRESS>wrote:

I assume this is a scalar variable, e.g. the pressure from an Example 5
run?
Can you do a "pseudocolor" plot of it? Does the contour operation work on
the Example 5 output for you?
Tzanio
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mfem/mfem/issues/1494#issuecomment-631558519, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD4GCV6M5ARMZL6BRWRH5DRSP3KDANCNFSM4NFO7ZJA
.

--
Marc-Olivier Delchini

Can you post the declaration of the grid function for which the code fails?

It is failing for all of the variables I dump in the output file. The class
I use to declare variables and write solution to output files is the
following:

#include <output/internal_energy_coefficient.hpp>

#include <output/pressure_coefficient.hpp>

#include <output/vel_comp_coefficient.hpp>

#include <output/vel_magn_coefficient.hpp>

#include <output/visit_output.hpp>

VisitOutput::VisitOutput(const mfem::ParFiniteElementSpace &fes_,

                         const mfem::ParFiniteElementSpace &dfes_,

                         std::shared_ptr<EquationOfState> eos_,

                         std::shared_ptr<mfem::ParMesh> pmesh_,

                         mfem::BlockVector &u_block_,

                         const mfem::Array<int> &offsets_, const int
nb_adv_eq_,

                         const std::string &file_name, const int pde_model_)

    : fes(fes_), dfes(dfes_), eos(eos_), pmesh(pmesh_), u_block(u_block_),

      offsets(offsets_), nb_adv_eq(nb_adv_eq_), pde_model(pde_model_),

      dim(pmesh->Dimension()), visit_dc(file_name, pmesh.get()),

      // Conservative variables

      rho(&fes, u_block.GetBlock(0)),

      mom(&dfes, u_block.GetData() + offsets[1]),

      rhoE(&fes, u_block.GetBlock(dim + 1)),

      // Thermo. primitive variables

      temperature(&fes), pressure(&fes), e(&fes),

      // Velocity varible

      vel(&fes)

{

  // Initialize vector objects storing momentun and velocity components

  for (int d = 0; d < dim; d++)

  {

    mom_cpt.push_back(mfem::ParGridFunction(&fes));

    vel_cpt.push_back(mfem::ParGridFunction(&fes));

  }

  // Initialize vector objects storing advection variables

  for (int i = 0; i < nb_adv_eq; i++)

  {

    adv_var.push_back(mfem::ParGridFunction(&fes));

  }

  // Register all fields

  registerAllField();

}

// Update and save all fields

void VisitOutput::saveAllFields(int ti, double time, double dt)

{

  // Define conservative coefficients

  mfem::GridFunctionCoefficient rho_coeff(&rho);

  if ((pde_model == 3) || (pde_model == 4))

  {

    mfem::VectorGridFunctionCoefficient mom_coeff(&mom);

    mfem::GridFunctionCoefficient rhoE_coeff(&rhoE);

    // Assign momentum components, momentum coefficient, compute velocity

    // coefficient, and project velocity

    mfem::Array<mfem::GridFunctionCoefficient> mom_cpt_coeff(dim);

    std::vector<VelCompCoefficient> vel_cpt_coeff;

    for (int d = 0; d < dim; d++)

    {

      mom_cpt[d] = u_block.GetBlock(d + 1);

      mom_cpt_coeff[d] = mfem::GridFunctionCoefficient(&mom_cpt[d]);

      vel_cpt_coeff.push_back(VelCompCoefficient(rho_coeff,
mom_cpt_coeff[d]));

      vel_cpt[d].ProjectCoefficient(vel_cpt_coeff[d]);

    }

    // Projet thermo. primitive variables

    if (pde_model == 3) // Euler equations

    {

      InternalEnergyCoefficient e_coeff(rho_coeff, rhoE_coeff, mom_coeff);

      e.ProjectCoefficient(e_coeff);

      TemperatureCoefficient temp_coeff(rho_coeff, rhoE_coeff, mom_coeff,
eos);

      temperature.ProjectCoefficient(temp_coeff);

    }

    PressureCoefficient press_coeff(rho_coeff, rhoE_coeff, mom_coeff, eos);

    pressure.ProjectCoefficient(press_coeff);

    double my_pressure_max = pressure.Max();

    double my_pressure_min = pressure.Min();

    double all_pressure_max;

    MPI_Allreduce(&my_pressure_max, &all_pressure_max, 1, MPI_DOUBLE,
MPI_MAX,

                  pmesh->GetComm());

    double all_pressure_min;

    MPI_Allreduce(&my_pressure_min, &all_pressure_min, 1, MPI_DOUBLE,
MPI_MIN,

                  pmesh->GetComm());

    std::cout << "max pressure: " << all_pressure_max << std::endl;

    std::cout << "min pressure: " << all_pressure_min << std::endl;

    std::cout << "delta pressure: " << all_pressure_max - all_pressure_min

              << std::endl;

    // Project velocity magnitude

    VelMagnCoefficient vel_coeff(rho_coeff, mom_coeff);

    vel.ProjectCoefficient(vel_coeff);

  }

  // Scalar variables for advection equations

  for (int i = 0; i < nb_adv_eq; i++)

  {

    adv_var[i] = u_block.GetBlock(dim + 2 + i);

  }

  // Save data at time 'time' and step index 'ti'

  visit_dc.SetCycle(ti);

  visit_dc.SetTime(time);

  visit_dc.SetTimeStep(dt);

  visit_dc.Save();

}

void VisitOutput::registerAllField()

{

  // Component names

  std::vector<std::string> cpt = {"x", "y", "z"};

  // Register variables

  switch (pde_model)

  {

  case 1: // Linear advection equation

    visit_dc.RegisterField("linear", &rho);

    break;

  case 2: // Burger's equations

    visit_dc.RegisterField("burger", &rho);

    break;

  case 3: // Euler equations

    // Register density and energy variables

    visit_dc.RegisterField("density", &rho);

    visit_dc.RegisterField("energy", &rhoE);

    // Register primitive variables

    visit_dc.RegisterField("temperature", &temperature);

    visit_dc.RegisterField("pressure", &pressure);

    visit_dc.RegisterField("internal_energy", &e);

    break;

  case 4: // Shallow water equations

    // Register height and toplogy variables

    visit_dc.RegisterField("height", &rho);

    visit_dc.RegisterField("topology", &rhoE);

    // Register primitive variables

    visit_dc.RegisterField("pressure", &pressure);

    break;

  default:

    mfem::mfem_error("Invalid PDE model.");

    break;

  }

  if ((pde_model == 3) || (pde_model == 4))

  {

    // Register momentum and velocity components

    for (int d = 0; d < dim; d++)

    {

      std::string name = "velocity_" + cpt[d];

      visit_dc.RegisterField(name, &vel_cpt[d]);

      name = "momentum_" + cpt[d];

      visit_dc.RegisterField(name, &mom_cpt[d]);

    }

    visit_dc.RegisterField("velocity_magnitude", &vel);

  }

  // Register advection variables

  for (int i = 0; i < nb_adv_eq; i++)

  {

    std::string name = "scalar_" + std::to_string(i + 1);

    visit_dc.RegisterField(name, &adv_var[i]);

  }

}

On Mon, May 25, 2020 at 12:23 PM Tzanio Kolev<EMAIL_ADDRESS>wrote:

Can you post the declaration of the grid function for which the code fails?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mfem/mfem/issues/1494#issuecomment-633641870, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD4GCW7HH3ST5P6QOLQRTLRTKLPDANCNFSM4NFO7ZJA
.

--
Marc-Olivier Delchini

From the above it is not clear what the finite element spaces are (and in particular what their collections are).
Can you visualize this output from mpirun -np 4 ex5p -r 0: Example5-Parallel.tar.gz
Can you send us a similar data collection output from your code?

Thanks again for your help.
I can visualize the output files you attached in your previous email.
I found out that the problem only happens when running the code with a
polynomial order of zero (finite volume). With first order or higher, the
contour plots show and I do not see any warning message from VisIt. I
attached output files for polynomial order equal to zero.
As for the element spaces I use the following:

  // 5. Define the discontinuous DG finite element space of the given

  //    polynomial order on the refined mesh.

  mfem::DG_FECollection fec(order, dim, meshAndOutput.basisType());

  // Finite element space for a scalar (thermodynamic quantity)

  mfem::ParFiniteElementSpace fes(pmesh.get(), &fec);

  // Finite element space for a mesh-dim vector quantity (momentum)

  mfem::ParFiniteElementSpace dfes(pmesh.get(), &fec, dim,

                                   mfem::Ordering::byNODES);

  // Finite element space for all variables together (total thermodynamic
state)

  mfem::ParFiniteElementSpace vfes(pmesh.get(), &fec, num_equation,

                                   mfem::Ordering::byNODES);

On Mon, May 25, 2020 at 10:32 PM Tzanio Kolev<EMAIL_ADDRESS>wrote:

From the above it is not clear what the finite element spaces are (and in
particular what their collections are).
Can you visualize this output from mpirun -np 4 ex5p -r 0:
Example5-Parallel.tar.gz
https://github.com/mfem/mfem/files/4679592/Example5-Parallel.tar.gz
Can you send us a similar data collection output from your code?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mfem/mfem/issues/1494#issuecomment-633776469, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD4GCXPKMVPIPPJDNVPKC3RTMS45ANCNFSM4NFO7ZJA
.

--
Marc-Olivier Delchini

I found out that the problem only happens when running the code with a polynomial order of zero (finite volume).

Contour lines don't make much sense for piecewise-constant data: on each element they are either empty or the whole element.
If you want to plot contours in that case, I will suggest projecting (i.e. averaging) to continuous linears and then plotting the contours.

You are right.
Thanks for your help again. You can close this issue.
On Tue, May 26, 2020 at 11:01 AM Tzanio Kolev<EMAIL_ADDRESS>wrote:

I found out that the problem only happens when running the code with a
polynomial order of zero (finite volume).
Contour lines don't make much sense for piecewise-constant data: on each
element they are either empty or the whole element.
If you want to plot contours in that case, I will suggest projecting (i.e.
averaging) to continuous linears and then plotting the contours.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mfem/mfem/issues/1494#issuecomment-634080918, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD4GCSZGRAZXLKC63AAVTTRTPKUJANCNFSM4NFO7ZJA
.

--
Marc-Olivier Delchini


#833 : Support that Executable resource model should not have a type.

This aims to fix #833 for the 1.0.x branch.

I added more logs to warn about invalid model. (This should help people to fix their model)
Do not use the Type.String by default for executable resource. (I keep the default value for none executable, maybe not a so good idea :thinking:)
Raise a CodecException if we try to encode a "without type" (probably executable) resource.

The new code reveals an issue in one of our included model :
Model for Resource Reset Min and Max Measured Values(5605) in /models/3303.xml is invalid : an executable resource MUST NOT have a type(STRING)

So I will probably update models regarding new version available at OMA LWM2M Registry.

I updated all models and added the missing one in all demos.
I removed Communications Characteristics (17) and Non-Access Stratum (NAS) Configuration(18) as they are not yet published (see https://github.com/OpenMobileAlliance/lwm2m-registry/issues/443)

I add a fix on 10260 object model (see https://github.com/OpenMobileAlliance/lwm2m-registry/issues/446)


CollectandSendInputs from page to page while also submitting to Firebase?

Hey! Really love this and it would be really helpful for me if I can get it going on my project. I've spent the last 24 hours trying to figure out how exactly jekyll-survey is sending and storing the data via web elements like the button (I'm a bit of a newb to Jekyll)... and my conclusion is that I think it's possible but I'm having trouble figuring out which javascript function(s) to call when the user fills out the form and either presses 'back' or 'next' (its an interactive documentation).
Thanks for the great and helpful work!

Hi Jordanurbs! Really cool that you're digging this!
I'm afraid that I'm not maintaining this code anymore, it was a one-time hobby project.
I'm not sure I 100% understand your question. The 'back' and 'next' button on people's browsers will not work (currently), because the pages are all virtual. If you look at the HTML you can see all 'pages' from Jekyll are compiled into one page.

Hey @MatthijsZw thanks for the response :) I understand this was never a serious project, but I'm finding immense value in it if I can just figure out the JS (I'm not really a coder of any sort really, but if I focus hard enough I can generally hack simple things together). I've tried to deconstruct it and it looks created for a much more complicated use case than mine.
My question is: If I only have one page of survey questions (textbox/textarea) and I simply want Firebase to store the results, can I simply use <body onLoad="startDB()"> and later use<a onClick="collectAndSendInputs()"> at the bottom of the page?

@jordanurbs yes, as far as I understand my own code, that is how it works.
Although, I think this should work automatically if you use the template provided in the code and only make 1 page in Jekyll.
Best would be to just try it out. Create a firebase, add the identifier to the code and create a very simple survey.
Please note that you'll still need to analyse the results from firebase, and I never wrote code to do that...

@MatthijsZw that's probably a good idea; instead I've just been trying to insert it into my current template. Ha.
Thank you! If I get this part of it working, I might hire someone to do that firebase analysis--in which case I'll fork this repo and send you a pull request :)

@jordanurbs thanks Jordan and good luck! Will be curious to see your survey!


database/mongo: add task state counts to service info

Adds task state counts to the service info endpoint for mongo.

Added node metrics to prometheus. Closes #470

A few comments:

You need to run dep ensure to update Funnel's dependencies
It would be nice if the task state counts had a place in the web dashboard
Some docs around the prometheus metrics would be helpful

Also why did you copy http.proto and annotations.proto rather than use the vendored version?

I think these aren't vendored since the switch to dep. I thought it was simpler to just copy these two, rather than submodule the whole repo.

Also needs:

[ ] tests

It would be nice if the task state counts had a place in the web dashboard

At first I added this to the task list page, but then I realized it might be confusing in conjunction with the task filters, so I put it on the service info page as a simple fix. We can revisit something more advanced in the future.

looks good 👍


Would someone like to explain to me what the benefit of this is?

As in, why is it better to access something with json["users", 1, "name"] instead of with json["users.1.name"], because as far as I know, you don't get compiler-time type-checking in either of those methods. And I can't think of any other possible benefit.

@Evertt the benefit is largely syntax, and now that you say it, it might be worthwhile to add a path: subscript that uses your syntax, ie: json["users.1.name"].
The biggest difference from your example is that one can only use keys, and one can access arrays and dictionaries interchangeably, for example consider the following json:
{
    "a" : [
        {
            "b" : 2
        }
    ]
}

One could call json["a", 0, "b"] // = 2
I suppose we could say if array, try Int(stringKey).
Mostly, it was just a preference of syntax in a way to add the same key path support to multiple conforming objects. Let us know if you think the feature warrants revisiting 👍

Let us know if you think the feature warrants revisiting 👍

Nope, this seems pretty good to me. :-) Sure I wouldn't say no to the addition of a path: subscript, but I never say no to an extra way to express things. :-)

@Evertt almost forgot one other thing. I'm going to add it here just in case the thread comes up again 😄
Occasionally Json uses keypaths as a key, for example
{"user.name" : "cool-user"}

I'm not sure it's the best practice, but it does exist in areas we cn't control, and we need a way to support it

Supporting "blah.blah" as a JSON key is critical.

Ah yes of course.

Actually guys, I would like to reopen this issue with the following suggestion. I would personally really like to have both methods of subscripting supported, because I really see benefit in both methods for different reasons.
So then how about the case that a key literally has a period in it? I would say, prefer literal keys over keys-paths. I'll make it clear with an example. Say my JSON looks like this:
{
    "user.name": "Evert",
    "user": {
        "name": "Tanner"
    }
}

And I write json["user.name"] then I believe it should return "Evert" and not "Tanner", because it should prefer literal keys over key-paths. So in that case the only way to get "Tanner" would be to write json["user", "name"]. Does that make sense?
But let's be honest, this is an edge case that will most likely never happen. But if it happens then I think the solution I now provided is a good solution. And having both subscripting options available is very valuable to me.

You can do that like json[path: "user.name"]
https://github.com/qutheory/path-indexable/blob/master/Sources/PathIndexable/PathIndexable%2BSubscripting.swift#L69

@tannernelson to explain a little bit what attracts me to the "user.name" form, it's because of the brevity.
Writing json["post.author.name"] is just shorter than writing json["post", "author", "name"], however that advantage completely disappears when you need to preface it with path: . So I would prefer if that's not necessary.

I think I'd prefer to keep the path: as an external argument to avoid ambiguity. It's a simple way to allow users to have a more concise syntax. With autocomplete, it should only be a couple of keystrokes.
I think we should keep this proposal up another week and consider some implementation details and see if others in the community have opinions they'd like to weigh in.


dvc: 3.55.0 -> 3.55.1

Description of changes
Version bump, also closes #338285

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 338749 run on x86_64-linux 1

18 packages built:

dvc (python312Packages.dvc)
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist (python312Packages.dvc.dist)
python311Packages.dvc
python311Packages.dvc-gdrive
python311Packages.dvc-gdrive.dist
python311Packages.dvc-hdfs
python311Packages.dvc-hdfs.dist
python311Packages.dvc.dist
python311Packages.dvclive
python311Packages.dvclive.dist
python312Packages.dvc-gdrive
python312Packages.dvc-gdrive.dist
python312Packages.dvc-hdfs
python312Packages.dvc-hdfs.dist
python312Packages.dvclive
python312Packages.dvclive.dist


Quick port re-use causes sessions to get smashed together

After RST/FIN if there is a future SYN probably start new session, but more RST/FIN go with old session?

Waiting for sample pcap from @ahodgen

Should be fixed in 3.0


Remove crypto functions from statically linked OpenSSL

Contributes to https://github.com/dotnet/runtime/issues/55639

Depends on https://github.com/dotnet/dotnet-buildtools-prereqs-docker/pull/494
We'll probably need to update image reference afterwards here:
https://github.com/dotnet/msquic/blob/deb3a26c20315aa4c659079071b821e5d5230242/eng/pipelines/msquic.yml#L73

Linux build finished. Do we know if runtime tests pass @ManickaP ?

@wfurt I ran with it locally and haven't seen any issues.


refactor: remove acorn

Description
Rollup v4 doesn't use acorn and exposes parseAst. This PR removes acorn by using that function instead.

package size:  828.6 kB -> 772.2 kB
unpacked size: 3.6 MB -> 3.3MB

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Update the corresponding documentation if needed.
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

/ecosystem-ci run

The flaky CI fails is happening in main too. I'm investigating this and will submit a fix later. Merging this for now.


[uischema] add menu config for each component

Use this query to search for the most popular feature requests.
Is your feature request related to a problem? Please describe.
Composer now supports the menu property in the uischema. We will port Composer's configuration into the component uischemas for R11.
Current config found here: https://github.com/microsoft/BotFramework-Composer/blob/main/Composer/packages/ui-plugins/composer/src/defaultMenuSchema.ts#L1

Per conversation with @a-b-r-o-w-n this is out of scope for R11.

@a-b-r-o-w-n is this going to be done in R12?

@mrivera-ms  yes.


Replicate API taking more than 2 min on T4 GPU

This is my cog file
build:
  gpu: true
  python_version: "3.10"
  python_packages:
    - "diffusers"
    - "accelerate"
    - "peft"
    - "transformers"

predict: "predict.py:Predictor"

This is my predict.py
import torch
import base64
from io import BytesIO
from PIL import Image
from cog import BasePredictor, Input, Path
from diffusers import AutoPipelineForInpainting

class Predictor(BasePredictor):

  def setup(self):
    pipe = AutoPipelineForInpainting.from_pretrained('stabilityai/sdxl-turbo', torch_dtype=torch.float16, variant="fp16")
    pipe.to('cuda')
    pipe.load_lora_weights("./sdxl_turbo_lora.safetensors")
    self.pipe = pipe

  def predict(self, input_image_base64: str = Input(description="Input base64 string"), mask_base64: str = Input(description="Mask base64 string")) -> str:

    base64_decoded = base64.b64decode(input_image_base64)
    input_image = Image.open(BytesIO(base64_decoded))

    base64_decoded = base64.b64decode(mask_base64)
    mask_image = Image.open(BytesIO(base64_decoded))

    output = self.pipe(
      prompt="remove wrinkles from the cloth, make shirt color black, don't operate on cloth folds, avoid changing cloth text or font prints",
      negative_prompt="wrinkled, low quality texture, degenerated texture, unintelligible text, overexposed, worst quality, low quality, jpeg artifacts, ugly, deformed, blurry, extra pockets, distorted hands",
      image=input_image,
      mask_image=mask_image,
      num_inference_steps=5,
      strength=0.5,
      guidance_scale=1
    ).images[0]

    buffered = BytesIO()
    output.save(buffered, format="JPEG")
    img_str = base64.b64encode(buffered.getvalue())

    return img_str

The above model is setup to run on T4 GPU, and on T4 GPU sdxl-turbo returns outputs in seconds. Even though the prediction logs states on avg 4 seconds, I'm getting output on my app after 2+ minutes.

To reproduce this you can use the below repo it's readme
https://github.com/Team-Iron-The-Dress/replicate-cog-model/tree/main
This is my model
https://replicate.com/shivansh-yadav13/iron-the-dress/versions/33757df23f3c36414a02ae99701f1c2dd1d4c3eddd29b5ae04fa0ed145044441

Hi @Shivansh-yadav13. Sorry for not responding sooner.
That additional 2 minutes looks to be from the model being cold and booting up. You can get more consistent performance with a deployment of that model, which you can figure to always have an instance running.
That said, the official SDXL model has enough public traffic to always be warm, so you might consider using that instead.


Pluralize column specified by references

Following up to https://github.com/winebarrel/ridgepole/issues/312 and https://github.com/winebarrel/ridgepole/pull/316
In Rails' DSL for schema definitions, references works like
belongs_to:
i.e.
t.references :user, foreign_key: true`

Should do the following

create a column user_id
create an index on user_id
add a foreign key constraint against the users table.

About this fix
The only change is that the table name referenced in the foreign key constraint is pluralized from the argument to references. i.e. user becomes users.
Additional background
Note that the lower level add_reference method  from the Migrations DSL has the signature add_reference(table_name, ref_name, **options)  where table_name refers to the current table name. I think that the implementation in #316 may have made a mistake in interpreting the API.

Tests seem to be failing at the dependency checking step
e.g.

/home/runner/work/_temp/7335f3f2-e9d6-4f71-b1ff-1336f45b63b8.sh: line 3: bundle: command not found

👍


Add pyGLFW dep

Pin glfw to !=3.3.1 on Linux until
https://github.com/glfw/glfw/issues/1620
is fixed.

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.


Provide a better interface to set project-only filter for stacktrace mode

Currently we can't use positive filters on cider-stacktrace-default-filters. Options like project doesn't work here.
Also the documentation on cider-stacktrace-default-filters could be improved. I had to look more than I expected for the acceptable values for the variable.

wow, wrong repo. sorry about that


PSRFITS Debugging

Debugged a few things, primarily an issue where the PSRFITS.nsubint was not overwritten if it was different than signal.nsub and the signal was initially built from a template PSRFITS file. Currently the failing io tests seem to be an issue in pdat, but further exploration may be necessary. @Hazboun6, do you have any suggestions for something to be changed in the simulator or do you think this is a pdat issue? Error report below. The input is from a notebook testing cell based on the test_savesig test and is:
S = PSRfits.make_signal_from_psrfits()
obslen = PSRfits.tsubint.value*PSRfits.nsubint*2
pulsar.make_pulses(S, tobs = obslen)
PSRfits.save(S, pulsar)

Yeah, I think that was the 2nd pdat error that I got to as well in my hacked together local version. Looks like your fixes here are way better than mine! Can you merge this so I can continue at some point? Unless you have more todo, because I probably won't get to it that soon.

Okay, great. I have nothing else to add to this that I can find right now, so I'll go ahead and merge this.


Add README to NuGet packages

Hello!
I am from the NuGet team at Microsoft. We recently introduced support for embedding READMEs into NuGet packages (blog, docs), and we plan to place these READMEs front and center on nuget.org. Would you be willing to accept a contribution to add embedded READMEs to your packages?

Resolved by #2808.


Can't scroll after close modal

I'm using version 1.0.0 latest release and have a problem with modals
When the modal is open, <body style="overflow: hidden;"> this css is added to body tag, but it's not removed when I'm closing the modal, so I'm not able to scroll the website then..
The issue is visible on desktop version of Chrome, Firefox, and also mobile (android), I didn't notice the issue on iOS devices.

Can you provide a codepen so we can reproduce this?

The same happens to me.
The problem is when the modal's close method run, the attr isOpen is always false, then the function returns and not follows to the next condition to changes body's style. I solved this adding document.body.style.overflow = '' before return
'''
/**
* Close Modal
*/
}, {
  key: "close",
  value: function close() {
    if (!this.isOpen) { //<========= here isOpen is always false
      document.body.style.overflow = ''; // I added this line
      return;
    }

'''

This workaround fixed it for me:
const options = {
    onCloseEnd() {
      $('body').css('overflow', '')
    }
  }
M.Modal.init(elem, options)

I can't reproduce this locally. Please submit a codepen that reproduces this issue

I'll try to get a codepen up by this weekend.

having this problem in 2023


fixed Cannot read property 'hash' of undefined

What kind of change does this PR introduce?
a bugfix
Did you add tests for your changes?
yes
If relevant, link to documentation update:

Summary

Does this PR introduce a breaking change?

Other information
But I don't know why the value of compilation is undefined.

This doesn't fix the problem. Please investigate why compilation is undefined. Check stack trace.

Did you add tests for your changes?
yes

Really?


import Firebase no longer works

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.0 beta 2
Firebase SDK version: 6.28.1
Firebase Component: Whole Firebase framework (Auth, Core, Database, Firestore, Messaging, Storage, etc)
Component version: 6.28.1
Installation method: CocoaPods (select one)

[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
Just install firebase with some components like functions and firestore, then try to use firestore/functions with imported Firesbase.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
After the update, importing Firebase in not enough to use firestore/auth/functions, it looks like import Firebase now do nothing

But after remove import firebase, and add import for each component then it works

That is a planned change or bug?
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:
import Fireabse
let functions = Functions.functions() // this case doesn't work

////
import FirebaseFunctions
let functions = Functions.functions() // this one works

so it looks like the `import Firebase` is useless since new update right?

Hi @Marcin951 - that certainly shouldn't be the case. In some cases I've seen this where Xcode is in a bad state - can you try a clean build, cleaning derived data, and re-launching Xcode?
Does this happen on the Xcode 12 beta 2 only, or also with Xcode 11? Just trying to figure out if this is a new issue related to the beta or something else going on.
If the above doesn't work, it's likely also worth trying to clean the CocoaPods folder and try rebuilding again.

Ya, I did it. I deleted the cocoa pods folder/cache and I did deinit cocoa pods. I deleted the derived data, cache and I cleaned the build. I tried a couple of times to build the project after clean build and always had the same issue. It looks like something went wrong in the latest version of the firebase. I also know that issue when sometimes Xcode can't detect firebase but always rebuild helps, so that definitely is the another issue

Are you able to reproduce in a quickstart sample?

Not sure if related, but I am having similar issues since I updated to last version (6.28.1) using Cocoapods.
I tried removing derived data, cleaning and building.

Using import FirebaseDatabase fixes the issue. Is this a bug or expected behavior?

Using import FirebaseDatabase fixes the issue. Is this a bug or expected behavior?

I'm pretty sure that is a bug, if they didn't mark it as change in the changelogs.
Tomorrow I'll create a brand new project to check if that is 100% issue

It would be a bug, but it doesn't repro in our tests, so we'll like need a reproducible example to diagnose.

I had the same issue with xcode 11.6,  and is not the only library that is broken. In fact AFNetworking, but it works importing extra modules like import FirebaseDatabase

Sample projects don't work, ofc i tried with cleaning build etc

on a brand new project, it looks like working

But I don't know why, I also reinstalled pods on my main project, any clue?

Same behaviour, Xcode Version 11.5 (11E608c).
need to import FirebaseCore otherwise FirebaseApp is not defined

@paulb777 @ryanwilson How is going investigation? Can I help in any way?

Having the same issue as well with Xcode 12 / Firebase SDK version: 6.28.1 / Cocoapods
It works with Xcode 11.6, and it also works again with Xcode 12 if I add specific imports (the one's that are commented out here).

@Marcin951 and others We still haven't been able to reproduce, so it would be really helpful to share an example that demonstrates the issue.
The other option would be to track down what is different about a working and broken environment.  Perhaps, diff'ing the Pods directory would provide some clues ...

I have related issue with FirebaseCrashlytics.
I've installed it w/o Cocoapods, as described at https://firebase.google.com/docs/ios/setup#frameworks (including steps for  Firebase.h and module.modulemap)
Then, I followed instructions to upgrade from Fabric to FirebaseCrashlytics at https://firebase.google.com/docs/crashlytics/upgrade-sdk?platform=ios
import FirebaseCrashlytics and FirebaseApp.configure() resulted in "Use of unresolved identifier 'FirebaseApp'".

i have fixed the problem :

close xcode
removing Pods directory
removing xcworkspace directory
launch pod install again
open myproject.xcworkspace

i suspect that during my first pod install xcode was open

Oh okay then if that is solved I can close the issue!

Got unresolved identifier FirebaseApp; XCODE 11.6. Had to import FirebaseCrashlytics directly.

See the resolution above. If that still doesn't work, we'll need a reproducible example to help with this issue.


cargo: nalgebra 0.23.0 -> 0.24.1

Was having trouble using this due to the outdated nalgebra dep.
Any chance a release can be cut following the merge of this PR?

Thanks @lovesegfault I'll take a look later tonight

A release right now would be suboptimal, will explain tomorrow. Going to bed.
You can use cargo vendor and/or the patching mechanism if you have a pressing need to use statrs as a dependency.

#125 was blocked after realizing I had commented out the slice_statistics module without ever getting around to replacing it. I've added some changes so that the module is at least not deleted, although it might be questionable whether the module is not better suited by being replaced with EmpiricalDistribution since they cover similar use cases.
With these fixes a new release could be made without much further breakage, now that the new API is in full effect.


Converting Godot 3 project to Godot 4 doesn't properly handle transform tracks in animations

Godot version
v4.0.dev.20211117.official
System information
Windows 10, gtx 1060, i5 4690k
Issue description
If you bring animations from Godot 3 to Godot 4, the tracks are wiped completely.
Whether you import the tracks manually via .tres, or .anim, or if you bring the whole anim player over
Animation tracks did get a rework, but there is no indication to the user that the tracks will be wiped upon loading them into Godot 4.
Steps to reproduce
Open these files in Godot 3, and you will see the tracks.
Open these same files in Godot 4, and the animation name will be there, but the tracks will be wiped, with no warning.
Minimal reproduction project
Godot4AnimationTransferBug.zip

We have many cases like this. E.g. opening 3.x UI scene in 4.0 will completely break the layout. When such thing happens, you can always close the scene without saving and manually upgrade the tscn.
I'd suggest running some project converter or at least making a backup before attempting to open old project.

This is a result of #53689. All of your animation tracks are transform tracks, which got replaced by individual loc/rot/scale tracks. They're not wiped, as you can see when you open the AnimationPlayer.tres file in a text editor, they're just not recognized. You could update the tracks manually or automatically with some regex. We could also try to get the project converter to handle these cases.

Is this fixed now? Godot 4 beta 13

It doesn't look like it's fixed in 4.0 stable, and the converter also seems to be clearing. Opening my files outside of the editor to look at them just shows empty animations.

Will try to fix it.

Seems the problem still occurs in Godot_v4.2-beta4_win64

I'll be sure when I find the culprit (is there an easy way to find the culprit tscn?).

@PLyczkowski I've already ran into that problem before and thought I've already solved it. Will check the the code again.
Tha cause for it was that the index track wasn't reset to 0 each time it reach the final track of an animation, and then the next animation starts with the last index of the previous animation.


[Bug]: Docker Compose file not found when it's located in a subdirectory

Description
Docker Compose file could not be found when a Base Directory is specified
Minimal Reproduction (if possible, example repository)
Not working example (because of the base directory)
https://github.com/coollabsio/coolify-examples/tree/main
Base Directory : /docker-compose-test
Docker Compose Location : /docker-compose.yaml
Working example (no base directory)
https://github.com/hagopj13/node-express-boilerplate/blob/master
Base Directory : /
Docker Compose Location : /docker-compose.yml
Exception or Error
Docker Compose file not found at: /docker-compose-test/docker-compose.yaml
Check if you used the right extension (.yaml or .yml) in the compose file name.
Version
v4.0.0-beta.294

Having the same issue

I was using Git v2.25.1. I upgraded to v2.45.2, and it solved the problem. I think the new Git version fixed the git sparse-checkout/git read-tree issue because, in the old version, the Docker Compose file was never cloned correctly in the subdirectory.


fix: don't add the storage name twice to the scheduled backup name

Don't add the storage name twice to the scheduled backup name
Adding a storage name twice might make a job name longer than 63 characters and break backup creation
CHANGE DESCRIPTION
Problem:
Scheduled backups are not being created after v1.16.0 in some situations when the storage name is not short.
Cause:
After v1.16.0 storage name is added to the scheduled backup name twice, see PR#1823.
The example of generated pxc-backup name before: cron-dev-1-db-s3-backups-daily-20241220005-372f8
The example of generated pxc-backup name after: cron-dev-1-dbs3-backups-daily-s3-backups-daily-202412230055-372f8
Solution:
Don't add the backup storage name twice to the scheduled backup name.
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?
[ ] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[ ] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?
[ ] Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

[ ] Are all needed new/changed options added to default YAML files?
[ ] Are all needed new/changed options added to the Helm Chart?
[ ] Did we add proper logging messages for operator actions?
[ ] Did we ensure compatibility with the previous version or cluster upgrade process?
[ ] Does the change support oldest and newest supported PXC version?
[ ] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

custom-users-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

pvc-resize-5-7
passed

pvc-resize-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
failure

upgrade-haproxy-5-7
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-5-7
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 42 out of 42

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1923/commits/f5e5b852d5d79691840f22a57fa74a217eba6da8
image: perconalab/percona-xtradb-cluster-operator:PR-1923-f5e5b852

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

custom-users-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

pvc-resize-5-7
passed

pvc-resize-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
failure

upgrade-haproxy-5-7
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-5-7
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 42 out of 42

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1923/commits/f5e5b852d5d79691840f22a57fa74a217eba6da8
image: perconalab/percona-xtradb-cluster-operator:PR-1923-f5e5b852


Fix #169: When paused why try to fetch every 1000 ms?

Fixes #169 and #170.

The brace at the end of function doesn't need a semicolon, will clean it.

The braces at the end of the function assignments are necessary because these functions are function expressions/assignments and not declarations.

Agree


Remove usage of deprecated ioutil package functions

165 files change a little bit too much for a single PR, although it's pretty simple, would please split it into chunks?

165 files change a little bit too much for a single PR, although it's pretty simple, would please split it into chunks?

first chunk
https://github.com/hyperledger/fabric/pull/4381

Thanks for splitting into smaller PR, I'll close this one now.


Is it possible to pass text as String?

I'd love to have all the features of this library, without converting anytime my text in epub. (little stories)
I've spent few hours going through the code and I haven't been able to do that.
Is there a way to present the reader passing data as [String:String] directly?

No, for now, there are no plans of supporting that.


Font size and tab size not ideal, and a couple other issues/questions

Hello!
Fantastic theme, I absolutely love the vertical tabs option, and I'm so glad to see you back here on Github. However, I'm wondering if it would be possible for you to use something like Sidebery to move the URL bar on the left side like Arc Browser. It's a lot better to have the URL bar on the left, where all the tabs are just like Arc.
Also, not sure if you know, but it might be beneficial to switch to Sidebery for your vertical tabs implementation. Sidebery allows resizing of the sidebar, alongside a couple other things. It's also fully customizable. Here's an example of Sidebery being used with a custom UI. Either way, you've done a fantastic job.
Now for the bugs, I noticed a couple issues with the vertical tabs. First, in your screenshots, the text size and tab size seem a lot more bigger than in the final version. Check screenshot:

Second, the only way to have transparency in the sidebar is to enable 'system auto' in the theme. It's not possible to have transparency if you select light or dark.
Third, watching videos on YouTube on Twitch in full screen will keep the sidebar on the left. It's not a proper full screen.
Fourth, it's not possible to reorder tabs. If I want to change where a tab is and drag it, I can't do that.
I'm extremely impressed by your work. Seriously, you should be extremely proud of the work you've done here. Good job!

首先谢谢你的喜欢和支持
关于你反馈的几个问题我简单说一下
1.字体/标签页大小差异是不是分辨率的问题
2、3的问题已经修复
第4个问题暂时无解
还有就是Sidebery相关的，我之前有出过一版不知道你有没有留意

等我有空再折腾一下看看
如果你喜欢arc样式这边推荐你可以看一下这个主题EdgyArc-fr

@drkhero

I noticed a new bug while using the theme, basically when I bring up mission control on macOS (F3 to bring up mission control), or try resizing the Firefox window, the animation will be very laggy.
Howver, when I i'm no using the theme and use mission control, the animation is very smooth. The lag only happens when using the theme. The fastest way to see the difference is by spamming the mission control button on mac with at least 1 other app opened, and you'll see that the theme has a very very obvious lag in the animation.
I think that the lag may be caused because of the amount of shadow used around the Firefox window. I may be wrong. Let me know if there's a fix!

这个问题在V126中修复了😊

[WIP]Arc Style😉

[WIP]Arc Style😉

Wow nice work! This looks amazing! Let me know how to enable the Arc Style 👏👍

[WIP]Arc Style😉

Wow nice work! This looks amazing! Let me know how to enable the Arc Style 👏👍

🥳完成了，快来试试

[WIP]Arc Style😉

Wow nice work! This looks amazing! Let me know how to enable the Arc Style 👏👍

🥳完成了，快来试试

I just tried, and wow, I'm incredibly impressed. Really amazing work on the URL integration on the left. The popup animation, and everything just looks perfect!  Fantastic job!
Only a couple things to fix though:

The URL bar shouldn't be showing "https", or the padlock icon. It should only show the URL, just like on Arc. This way we have a lot more space to see the full URL properly:

Could you show me how to change the color of a selected tab ? On Arc, the selected tab is fully white, whereas on here it's a little bit grey. I prefect the selected tab to be fully white. rgb (255,255,255)

[WIP]Arc Style😉

Wow nice work! This looks amazing! Let me know how to enable the Arc Style 👏👍

🥳完成了，快来试试

I just tried, and wow, I'm incredibly impressed. Really amazing work on the URL integration on the left. The popup animation, and everything just looks perfect! Fantastic job!
Only a couple things to fix though:
1. The URL bar shouldn't be showing "https", or the padlock icon. It should only show the URL, just like on Arc. This way we have a lot more space to see the full URL properly:

2. Could you show me how to change the color of a selected tab ? On Arc, the selected tab is fully white, whereas on here it's a little bit grey. I prefect the selected tab to be fully white. rgb (255,255,255)

3. There's also a couple of small bugs I found, I'll let you know about them later

不显示https about:config > browser.urlbar.trimHttps > true

userChrome.css里搜索 background: linear-gradient(#f0f0f4, #ecedf2) !important;

[WIP]Arc Style😉

Wow nice work! This looks amazing! Let me know how to enable the Arc Style 👏👍

🥳完成了，快来试试

I just tried, and wow, I'm incredibly impressed. Really amazing work on the URL integration on the left. The popup animation, and everything just looks perfect! Fantastic job!
Only a couple things to fix though:
1. The URL bar shouldn't be showing "https", or the padlock icon. It should only show the URL, just like on Arc. This way we have a lot more space to see the full URL properly:

```
2. Could you show me how to change the color of a selected tab ? On Arc, the selected tab is fully white, whereas on here it's a little bit grey. I prefect the selected tab to be fully white. rgb (255,255,255)

There's also a couple of small bugs I found, I'll let you know about them later

1. 不显示https `about:config > browser.urlbar.trimHttps > true`

2. userChrome.css里搜索 `background: linear-gradient(#f0f0f4, #ecedf2) !important;`

Alright, so here are few of the bugs I've found so far:

There's an invisible bar at the top to be able to drag to browser window around, but this invisible bar is way too big, causing it to interfere with most websites. For instance, here I'm trying to select some text on Youtube, and I'm simply unable to do so because of the invisible bar:

https://github.com/akkva/gwfox/assets/155139404/b4bb33d6-bb3e-4c6e-b412-46942cecb374

When I open a new blank page tab, this is how it looks like (there's a random grey line in the middle and the window isn't taking the full height of the page):

When I hover over the URL, I get icons that pop up. How can I make it so that nothing pops up when I hover over the URL ? :

https://github.com/akkva/gwfox/assets/155139404/a5e561c3-0716-48aa-9230-215d29de2426

[WIP]Arc Style😉

Wow nice work! This looks amazing! Let me know how to enable the Arc Style 👏👍

🥳完成了，快来试试

I just tried, and wow, I'm incredibly impressed. Really amazing work on the URL integration on the left. The popup animation, and everything just looks perfect! Fantastic job!
Only a couple things to fix though:
1. The URL bar shouldn't be showing "https", or the padlock icon. It should only show the URL, just like on Arc. This way we have a lot more space to see the full URL properly:

```
2. Could you show me how to change the color of a selected tab ? On Arc, the selected tab is fully white, whereas on here it's a little bit grey. I prefect the selected tab to be fully white. rgb (255,255,255)

There's also a couple of small bugs I found, I'll let you know about them later

1. 不显示https `about:config > browser.urlbar.trimHttps > true`

2. userChrome.css里搜索 `background: linear-gradient(#f0f0f4, #ecedf2) !important;`

Alright, so here are few of the bugs I've found so far:
1. There's an invisible bar at the top to be able to drag the browser window around, but this invisible bar is way too big, causing it to interfere with most websites. For instance, here I'm trying to select some text on Youtube, and I'm simply unable to do so because of the invisible bar:

buggin.mp4
2. When I open a new blank page tab, this is how it looks like (there's a random grey line in the middle and the window isn't taking the full height of the page):

3. When I hover over the URL bar, there's a few icons that pop up. How can I make it so that no icon pops up when I hover over the URL ?

icons.mp4

这个问题我做了优化，顶部预留了10px左右来拖拽移动窗口，经过测试应该不会影响文本选择了

这个问题彻底修复了

3.这个需求要改的东西不少，你确定不需要这些图标的操作吗？

[WIP]Arc Style😉

Wow nice work! This looks amazing! Let me know how to enable the Arc Style 👏👍

🥳完成了，快来试试

I just tried, and wow, I'm incredibly impressed. Really amazing work on the URL integration on the left. The popup animation, and everything just looks perfect! Fantastic job!
Only a couple things to fix though:
1. The URL bar shouldn't be showing "https", or the padlock icon. It should only show the URL, just like on Arc. This way we have a lot more space to see the full URL properly:

```
2. Could you show me how to change the color of a selected tab ? On Arc, the selected tab is fully white, whereas on here it's a little bit grey. I prefect the selected tab to be fully white. rgb (255,255,255)

There's also a couple of small bugs I found, I'll let you know about them later

1. 不显示https `about:config > browser.urlbar.trimHttps > true`

2. userChrome.css里搜索 `background: linear-gradient(#f0f0f4, #ecedf2) !important;`

Alright, so here are few of the bugs I've found so far:
1. There's an invisible bar at the top to be able to drag the browser window around, but this invisible bar is way too big, causing it to interfere with most websites. For instance, here I'm trying to select some text on Youtube, and I'm simply unable to do so because of the invisible bar:

buggin.mp4
2. When I open a new blank page tab, this is how it looks like (there's a random grey line in the middle and the window isn't taking the full height of the page):

```
3. When I hover over the URL bar, there's a few icons that pop up. How can I make it so that no icon pops up when I hover over the URL ?
```
icons.mp4

1. 这个问题我做了优化，顶部预留了10px左右来拖拽移动窗口，经过测试应该不会影响文本选择了

2. 这个问题彻底修复了

3.这个需求要改的东西不少，你确定不需要这些图标的操作吗？

I can confirm all of this is fixed! Good job!
Currently, the only issue remaining is that you can't re-order your tabs. It won't let me move a tab up or down. Do you think there's any fix for this ?

I can confirm all of this is fixed! Good job!
Currently, the only issue remaining is that you can't re-order your tabs. It won't let me move a tab up or down. Do you think there's any fix for this ?

目前能做的就是用Move Tab Hotkeys这个扩展添加快捷键来移动

I can confirm all of this is fixed! Good job!
Currently, the only issue remaining is that you can't re-order your tabs. It won't let me move a tab up or down. Do you think there's any fix for this ?

目前能做的就是用Move Tab Hotkeys这个扩展添加快捷键来移动

Alright thanks, I'll look into it. By the way, consider making your theme compatible with Sidebery. It might be a much easier solution considering Sidebery takes care of the Javascript side, which includes being able to re-order tabs, and also resize the sidebar.

I can confirm all of this is fixed! Good job!
Currently, the only issue remaining is that you can't re-order your tabs. It won't let me move a tab up or down. Do you think there's any fix for this ?

目前能做的就是用Move Tab Hotkeys这个扩展添加快捷键来移动

Alright thanks, I'll look into it. By the way, consider making your theme compatible with Sidebery. It might be a much easier solution considering Sidebery takes care of the Javascript side, which includes being able to re-order tabs, and also resize the sidebar.

Sidebery做不到透明背景，没有系统半透明效果加持视觉效果差很多，这个主题的出发点就是为了好看，目前的效果已经是我能做的极致了，其实我也是小白来着😊

I can confirm all of this is fixed! Good job!
Currently, the only issue remaining is that you can't re-order your tabs. It won't let me move a tab up or down. Do you think there's any fix for this ?

目前能做的就是用Move Tab Hotkeys这个扩展添加快捷键来移动

Alright thanks, I'll look into it. By the way, consider making your theme compatible with Sidebery. It might be a much easier solution considering Sidebery takes care of the Javascript side, which includes being able to re-order tabs, and also resize the sidebar.

Sidebery做不到透明背景，没有系统半透明效果加持视觉效果差很多，这个主题的出发点就是为了好看，目前的效果已经是我能做的极致了，其实我也是小白来着😊

No worries. You're a pro in my book 👍😄

I can confirm all of this is fixed! Good job!
Currently, the only issue remaining is that you can't re-order your tabs. It won't let me move a tab up or down. Do you think there's any fix for this ?

目前能做的就是用Move Tab Hotkeys这个扩展添加快捷键来移动

Alright thanks, I'll look into it. By the way, consider making your theme compatible with Sidebery. It might be a much easier solution considering Sidebery takes care of the Javascript side, which includes being able to re-order tabs, and also resize the sidebar.

Sidebery做不到透明背景，没有系统半透明效果加持视觉效果差很多，这个主题的出发点就是为了好看，目前的效果已经是我能做的极致了，其实我也是小白来着😊

No worries. You're a pro in my book 👍😄
By the way, can you provide a quick and easy way to change the color of the sidebar just like in Arc?:

这个效果改css并不麻烦，不幸的是并没有现成的扩展让你可以简单快速的定制😎

这个效果改css并不麻烦，不幸的是并没有现成的扩展让你可以简单快速的定制😎

I made a few changes to the theme color, it looks perfect now 🙌

这个效果改css并不麻烦，不幸的是并没有现成的扩展让你可以简单快速的定制😎

I made a few changes to the theme color, it looks perfect now 🙌

Hello @akkva there's something I'm wondering if you can implement.
Here's a video of the difference between the search UI on Arc Browser and the search UI on your Firefox theme. I'm wondering if you could implement the Arc Browser search UI shown in this video into the Firefox theme. I think it looks really good, and it would be awesome if you could put it into the Firefox theme. Let me know if it's possible :)
https://github.com/akkva/gwfox/assets/155139404/05a5e2ab-3a23-4b91-ba55-330a2cca09b4

While I don't personally use gwfox (I need Sidebery to replicate Spaces) I'm still very impressed with how well gwfox mimic's Arc. A while back the Arc team emailed me for a survey hosted on Figma but allowed it to be copied and edited. I've based my personal Sidebery theme on that template and I figured you may also find it useful. link

While I don't personally use gwfox (I need Sidebery to replicate Spaces) I'm still very impressed with how well gwfox mimic's Arc. A while back the Arc team emailed me for a survey hosted on Figma but allowed it to be copied and edited. I've based my personal Sidebery theme on that template and I figured you may also find it useful. link

You could also replicate spaces using native Firefox containers.
How does your Sidebery theme look like ?  I'd say we're about 80% of the way there to completely nailing the Arc experience on Firefox with gwfox's theme. There's a few things that need to be polished and done, like the command bar and the search UI, but we're really almost there.

While I don't personally use gwfox (I need Sidebery to replicate Spaces) I'm still very impressed with how well gwfox mimic's Arc. A while back the Arc team emailed me for a survey hosted on Figma but allowed it to be copied and edited. I've based my personal Sidebery theme on that template and I figured you may also find it useful. link

You could also replicate spaces using native Firefox containers.
How does your Sidebery theme look like ? I'd say we're about 80% of the way there to completely nailing the Arc experience on Firefox with gwfox's theme. There's a few things that need to be polished and done, like the command bar and the search UI, but we're really almost there.

Sidebery lets me switch between "spaces" with different assigned containers akin to Arc, my understanding is that without it I'm just able to assign specific tabs to containers instead.
My Sidebery theme currently looks like this,

The Figma template was helpful since it let me find the exact measurements of some items and exact shadow values without having to pixel peep. Though I'm not going for a perfect recreation. I should also note that I'm using EdgyArc-fr which accomplishes translucency on Sidebery by setting the opacity of Sidebery itself which isn't exactly ideal but at least works.

Though I'm not going for a perfect recreation. I should also note that I'm using EdgyArc-fr which accomplishes translucency on Sidebery by setting the opacity of Sidebery itself which isn't exactly ideal but at least works.

Nice. akkva's main reason for not using Sidebery was because he didn't think it was possible to achieve transparency on Sidebery. Turns out it is.


test(setup): configure to only run tests in uPortal-Home not in framework

Currently the setup is to run tests in framework as well as app, this change sets it up so that it only runs the app tests by replacing files provided by the overlay.  This will resolve the failing tests here - https://github.com/uPortal-Project/uportal-home/pull/750

Contributor License Agreement adherence:

[x] This Contribution is under the terms of Individual Contributor License Agreements (and also Corporate Contributor License Agreements to the extent applicable) appearing in the Apereo CLA roster.

I did some research and thought the same thing about Karma's file inclusion/exclusion rules.  I tried for a little while to use the rules.  I tried it here and in the uPortal-App-Framework and was running into weird require.js rules?  I'm open to missing something though.

I did some research and thought the same thing about Karma's file inclusion/exclusion rules. I tried for a little while to use the rules. I tried it here and in the uPortal-App-Framework and was running into weird require.js rules?

Got it, I was hoping there might be a trivial refactor,  but that is not the case.
LGTM as is :+1:


 Please review the second commit for the actual change.

Codecov Report

Merging #9178 (4a4adc8) into master (7bd4dd4) will decrease coverage by 54.60%.
The diff coverage is 85.18%.

@@              Coverage Diff              @@
##             master    #9178       +/-   ##
=============================================
- Coverage     69.90%   15.30%   -54.61%
+ Complexity     5003      170     -4833
=============================================
  Files          1847     1798       -49
  Lines         98562    96384     -2178
  Branches      14970    14720      -250
=============================================
- Hits          68900    14749    -54151
- Misses        24821    80578    +55757
+ Partials       4841     1057     -3784

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
15.30% <85.18%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/assignment/segment/OfflineSegmentAssignment.java
91.59% <83.33%> (-0.66%)
:arrow_down:

...ore/assignment/segment/SegmentAssignmentUtils.java
99.38% <88.88%> (-0.01%)
:arrow_down:

...src/main/java/org/apache/pinot/sql/FilterKind.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/java/org/apache/pinot/core/data/table/Key.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...in/java/org/apache/pinot/spi/utils/BytesUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/spi/utils/BooleanUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/data/table/Record.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/util/GroupByUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/NoOpRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1400 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Snowgem has incorrect ticker

Snowgem ticker needs to be updated from SNG to XSG:

All four of their servers are also down


Fixes set(...) not being backwards compatible on null callback.

Clients still using the old argument ordering with a null or undefined callback are broken since the API determines old vs new usage using typeof options for which null is a valid case. This fix also detects the old API usage in the case that callback is the expiration interval.

Ah, so basically if someone used set without a callback. Great! Thanks! Will mint a minor version bumb


Remove the event_meta_data table

The table event_meta_data is shared by all subgraphs, and is very large. Because subgraphs' entity_history references it, subgraph deployment has to get a SHARE UPDATE EXCLUSIVE lock on event_meta_data; because of that, subgraph deployment can get stuck behind an autovacuum of event_meta_data, and writes to event_meta_data can get stuck behind either of these operations. Autovacuum of event_meta_data can take an hour, and will only become longer as the table grows.
The table doesn't serve much of a purpose: it mostly makes it so we do not store the full block hash for a history event in entity_history, but only an integer event_id which points into event_meta_data.
We should make this table unnecessary by storing the block hash as the event_source in entity_history directly.

We won't do this. Instead, we will move to relational schemas which do not need event_meta_data


Fix ament cmake transitive dependency issue

The current amend cmake example build without problem, however there will be issue finding drake dependency for libraries depends on such a library

This change is

@jwnimmer-tri  Hey Jeremy would you mind taking a look at this PR?

+@IanTheEngineer do you know any https://github.com/RobotLocomotion/drake-ros member who would like to review this?
To me, the ament part looks okay, but manually setting LD_LIBRARY_PATH is usually an obscenity and should be avoided with prejudice.  Hopefully there is another way to get it working.  I imagine the ament ecosystem already has some better way to deal with library paths?

@IanTheEngineer last call to find someone to support this ament example.
If we can't find anyone to support it, then I will merge this PR as-is and follow up by documenting the ament example as outside of our support footprint, i.e., "community maintained - PRs welcome" and remove it from CI.

I should probably ping @EricCousineau-TRI also.