Enable protoboeuf-encode benchmark on TruffleRuby

The benchmark was disabled in #325. Now the issue is fixed (in https://github.com/oracle/truffleruby/pull/3674).

Is truffleruby-head not updated yet?
Failed benchmarks:
  ruby: protoboeuf-encode

TBH we want to test yjit-bench here instead of the TruffleRuby project. Given how unstable this job has been so far, I think this job should live in oracle/truffleruby and not in this repository (or at least not make the CI red when TruffleRuby fails).

Yeah, looks like a build for the fix isn't ready yet (the fix was merged today). Will retry jobs tomorrow.

I think only protoboeuf would fail, which seems OK as it's a very CRuby/YJIT-specific gem, considering the generated code it emits (huge methods).

You should have no problem handling that generated code. It's not CRuby-specific.

It executes correctly, it's just that https://github.com/Shopify/yjit-bench/blob/d3ce8dace054c0ac1a3339b69e1d5b686fc5868c/benchmarks/protoboeuf/benchmark_pb.rb#L888 is too big to be compiled by a method JIT (1400 lines long).
Anyway, I shouldn't have mentioned that here, it's pretty much orthogonal.

too big to be compiled by a method JIT (1400 lines long).

I think you mean your method JIT. Google's V8 handles this sort of thing just fine ;)

Actually it compiles fine, my bad, probably because it's a lot of very simple arithmetic:
[engine] opt done   engine=1  id=2126  ProtoBoeuf::TrunkItem#decode_from                  |Tier 2|Time   236( 110+126 )ms|AST 11185|Inlined  47Y   0N|IR   4401/  7516|CodeSize   29163|Addr 0x7f20e00da000|UTC 2024-09-27T10:10:02.328|Src benchmark_pb.rb:888 0x2acaf309
In the source code it certainly looks like a lot of duplication and something the JIT should be able to decide whether to inline or not (which it could if it's a separate method).

I'll make a PR to switch to a release of TruffleRuby in CI.


modify piccolo provider

remove local test environment

do not merge yet

Please review & merge. and then, PR in eclipse-symphony repository will be updated.

I will add new commit


Support Cirrus CI

https://cirrus-ci.org/guide/writing-tasks/#embedded-badges
But not sure for the states. Also not sure which projects uses it so to use for examples.
I'm consider switching to it in near future. The only thing that stopping me currently is environment variables handling, which i highly depend on for my full automation of auto-release, auto-update and auto-publish flow.
The cool thing about CircleCi is that it allows you to have one "global store" of environment variables, so you set it once and every old and new project you setup you can access it.
It's quite slow to do that for each project. Add cirrus config file, go to cirrus dashboard add env to that specific repo and etc. All that was one of the reason i switched from travis.
So yea, Cirrus CI is amazing and fast, but. :D

Much faster than CircleCI? For me I prefer Travis for it's super handy setup, .travis.yml and that's all.

It's always that way ;d And if you dont have full automation and dont do much packages per day. When you dont want to go to settings for every single project to add tokens (or run semantic-release-cli locally), then it is not so easy.

Nooooooooooo :laughing: :rocket:


update CI to compress binaries in archive at release

I adapted the CI configuration from ripgrep https://github.com/BurntSushi/ripgrep/blob/master/.github/workflows/release.yml and kept the structure of the existing configuration.

binaries are named sage (sage.exe on Windows)
binaries are compressed in tar.gz (or zip on Windows) archives named like sage-[version]-[target].tar.gz  (Fixes #23)
refactor Linux and Windows job like the MacOS one using matrix for consistency and to allow further extension of the matrices, or merge of the 3 jobs eventually
Build Sage Executables and Build Docker image now only run on releases not on every push to master
whitespace changes due to my format on save make it look like I changed a lot :(

Looks good to me - thanks for tackling this. Is it possible to push a release tag on your forked repo and test it out? @Elendol

Oh yes, I should have waited to delete my tests... I will link the results once the new release on my fork is finished.

Release tagged with demo-2
https://github.com/Elendol/sage/releases/tag/demo-2


Add details on stateless methods

As per some discussions during a previous pull request, it was pointed out that we can add more information about stateless methods.
https://github.com/near/sdk-docs/pull/37#discussion_r692370315
This might go in the near_bindgen section of the docs.

Discussed it with the team and because this hasn't really come up in the community or internally as an issue I think I'll close this issue.

Discussed it with the team and because this hasn't really come up in the community or internally as an issue I think I'll close this issue.

luv u dude! hope to see you at a conference soon!


feat(ci): enable database functional tests

Description
This PR enables functional tests for the database module to test database helpers. We can't enable all functional tests by adding --tests because they were broken and should be fixed.
Resolves #405
Stacked PRs list 🏗

0: add Postgres to Terraform config #415
1: add Postgres 16 to the docker-compose #410
2: add sql schema and migrations for the ENS #411
3: scaffold sqlx and add RPC_PROXY_POSTGRES_URI env variable #412
4: implement database helpers #413
5: enable database functional tests #414
6: add lookup handlers #417
7: name registration handler #418
8: profile names integration tests #419

How Has This Been Tested?
CI:
Passing the new CI tests.
Locally:
Start the Postgres locally and run RPC_PROXY_POSTGRES_URI=postgres://postgres@localhost:5432/postgres cargo test functional::database. The expected result is passing database functional tests.
Due Diligence

[ ] Breaking change
[ ] Requires a documentation update
[ ] Requires a e2e/integration test update

Closing this in favor of #438 for the new CI workflow.


[operator] service "opentelemetry-operator-webhook" not found

Hi everyone, I have disabled the webhook as suggested by the documentation. The helm chart installation completes successfully without errors but I do not see pods created after I apply the collector definition. Moreover when I try to list opentelemetrycollector resources from kubectl I receive the following error:
kubectl get opentelemetrycollector --all-namespaces
Warning: OpenTelemetryCollector v1alpha1 is deprecated. Migrate to v1beta1.
Error from server: conversion webhook for opentelemetry.io/v1beta1, Kind=OpenTelemetryCollector failed: Post "https://opentelemetry-operator-webhook.monitoring.svc:443/convert?timeout=30s": service "opentelemetry-operator-webhook" not found

Helm chart:
# helm upgrade --install opentelemetry-operator open-telemetry/opentelemetry-operator --version "0.60.0" -f .\values.yaml -n monitoring
manager:
  collectorImage:
    repository: "otel/opentelemetry-collector-k8s"
  # disable webhooks
  env:
    ENABLE_WEBHOOKS: "false"
  # resources configuration
  resources:
    limits:
      memory: 64Mi
    requests:
      cpu: 5m
      memory: 32Mi
# disable admission webhooks
admissionWebhooks:
  create: false

Collector definition:
apiVersion: opentelemetry.io/v1beta1
kind: OpenTelemetryCollector
metadata:
  name: otel
  namespace: "${kubernetes_namespace_v1.environment.id}"
spec:
  mode: deployment
  config:
    receivers:
      jaeger:
        protocols:
          grpc: {}
          thrift_http: {}
          thrift_compact: {}
      otlp:
        protocols:
          grpc: {}
          http: {}
      zipkin: {}
    extensions:
      health_check: {}
      pprof: {}
      zpages: {}
    processors:
      batch: {}
    exporters:
      otlp:
        endpoint: tempo.monitoring:4317
        tls:
          insecure: true
    service:
      extensions:
        - health_check
        - pprof
        - zpages
      pipelines:
        traces:
          receivers:
            - otlp
            - jaeger
            - zipkin
          processors:
            - batch
          exporters:
            - otlp

Can someone help me to pinpoint the error or the misconfiguration?
Thanks in advance

Hi, i think i have a linked issue.
It's been a week since I last tried to deploy my environment with OpenTelemetry installed, and now I'm getting a close one error and sometime another one when i try to deploy my helm:
Error from server (InternalError): error when creating "test.yml": Internal error occurred: failed calling webhook "mopentelemetrycollectorbeta.kb.io": failed to call webhook: Post "https://opentelemetry-operator-webhook-service.opentelemetry-operator-system.svc:443/mutate-opentelemetry-io-v1beta1-opentelemetrycollector?timeout=10s": service "opentelemetry-operator-webhook-service" not found

@davgia I think Kubernetes is attempting to convert them using webhooks but because you have disabled webhooks the operator will just fail. I would recommend amending your CRD definition to remove the conversion webhook if its the case that you do not have and never will have v1alpha1 collector resources. You can also just install the CRD directly from here.

@davgia I think Kubernetes is attempting to convert them using webhooks but because you have disabled webhooks the operator will just fail. I would recommend amending your CRD definition to remove the conversion webhook if its the case that you do not have and never will have v1alpha1 collector resources. You can also just install the CRD directly from here.

Thank you @jaronoff97 for the input.
I am in a clean cluster and I've installed the operator so I guess the CRDs are already at the latest version. I don't particularly like changing the CRD definition manually (I'm automating the procedure with Terraform, this CRD change cannot be done with it I think). I may try to enable webhook with the following strategy (straight from operator documentation):

You can use an automatically generated self-signed certificate by setting admissionWebhooks.certManager.enabled to false and admissionWebhooks.autoGenerateCert.enabled to true. Helm will create a self-signed cert and a secret for you.

I will let you know if this fixes the problem.

Yep, i believe this is a flavor of #677 actually where you just want the simple CRD installation. I.e. i'm working on it 😓

I must clarify that I still need the operator to create the collector (I am also using the auto-instrumentation, but I've removed it from this issue to simplify). Also I will add that I've deployed the operator in other cluster over an old version (0.40.0) that was working fine (configured without webhook) and stopped working (even if the chart is upgraded correctly).

yeah i believe that would be because of the CRD change. I would recommend setting crds.create=false for that cluster and rely on managing the CRDs externally.

would it be okay to close this in favor of #677 and #1201?

Ok, I will close this. Thank you.


Making datastore Connection.commit() return low-level protobuf.

Towards #2746. This approach is to slowly transition from our current approach to use the GAPIC generated surface.
It is unfortunately tangled quite a bit (partly because we may have too much mocked in the tests).

@dhermes so this is preparatory to adding google.cloud.datastore._gax, with its own implemenation of the API via the GAPIC client?

@dhermes Is your goal to get this in with the umbrella releaase, or after?

Approved, but holding off on merge until the umbrella release question is answered.

@lukesneeringer A merge is just fine.
@tseaver google.cloud.datastore._gax already exists, but yes this is part of the transition to switch to using the GAPIC layer in google.cloud.datastore._gax.

Passing on Travis, not done yet on CircleCI (since it doesn't yet do a restricted set of tests). Merging before CircleCI is done.


Add support for viewing logs of a pod that has exited

Note: this issue was imported from https://github.com/wercker/stern/issues/103, but it was originally created by gtseres...
kubectl logs has the --previous flag that allows for getting the logs of a pod that has exited:
  -p, --previous=false: If true, print the logs for the previous instance of the container in a pod if it exists.
I could not find such an option in stern. I think it would be very useful to support this.

Note: this comment was imported, but it was originally made by katylava...
Using --container-state terminated worked for my case.

Note: this comment was imported, but it was originally made by gtseres...
@katylava thanks for the feedback. Unfortunately this didn't work for me for the case where the Istio sidecar and istio-init container have run, as this flag only fetches the log from the istio-init container, where kubectl logs --previous -c <app_container> fetches the logs from the application container.

This issue has been resolved because now init containers are also targeted by default.
$ cat <<EOL | kubectl create -f-
apiVersion: v1
kind: Pod
metadata:
  name: app
spec:
  restartPolicy: Never
  initContainers:
  - name: init
    image: busybox
    command:
    - echo
    - init
  containers:
  - name: app
    image: busybox
    command:
    - echo
    - hello
EOL
pod/app created

$ stern --container-state terminated .
+ app › init
+ app › app
app init init
app app hello


Enhance Resolvers to work with AggregateTransform

<img src="https://avatars.githubusercontent.com/u/9606994?v=3" align="left" width="96" height="96"hspace="10"> Issue by eernstg
Originally opened as dart-lang/sdk#23130

Package Reflectable uses barback and code_transformers together to do code transformation.  We used to have code like this:
  Future apply(Transform transform) { ...
    Resolvers resolvers = new Resolvers(dartSdkDirectory);
    return resolvers.get(transform).then((resolver) {
      ... // Use the analyzer via resolver.
    });
  }
However, we are now using an AggregateTransform rather than a Transform, because we have to perform our transformation based on a global analysis, and Resolvers.get(,[]) does not accept an argument-number-1 of type AggregateTransform, only Transform.  Moreover, the body of get proceeds to call transform.primaryInput.id and pass transform to ResolverImpl.resolve and then ResolverImpl._performResolve where primaryInput is used multiple times, including on _currentTransform which is also a Transform (not Aggregate.., not Base..).  On top of that, we noticed that class Transform extends BaseTransform has been replaced by class Transform (i.e., extends Object). Hence, it is not obvious how easy it would be to support a variant of get that accepts an AggregateTransform.
Apparently it's not difficult to provide an extra method (temporarily named Resolvers.get2 in the attached patch) that accepts a BaseTransform (such as an AggregateTransform).  A couple of changes are needed around resolver_impl.dart _currentTransform, but the semantics should be the same after these updates.
With a (suitably renamed) get2, we could then do this:
  Future apply(AggregateTransform aggregateTransform) { ...
    Resolvers resolvers = new Resolvers(dartSdkDirectory);
    ... // Gather all the primaryInputs, including someAsset.
    return resolvers.get(aggregateTransform, someAsset).then((resolver) {
      ... // Use the analyzer via resolver
    });
  }
Do you agree that this looks like a possibly solution?  Would you be willing to add such a suitable renamed get2 to Resolvers?

Attachment:
code_transformers-get-AggregateTransform.patch (4.41 KB)

Closing this as it is either stale or not planned


Error parsing reference: "ubuntu:bionic as openbmc-base" is not a valid repository/tag

We're getting this on our x86 based CI machines. It works ok on our POWER based CI system so no idea what's going on yet:
https://openpower.xyz/job/openbmc-repository-ci/
12:26:47 + docker build --network=host -t openbmc/ubuntu-unit-test -
12:26:47 Sending build context to Docker daemon 9.728 kB

12:26:47 Step 1/67 : FROM ubuntu:bionic as openbmc-base
12:26:47 Error parsing reference: "ubuntu:bionic as openbmc-base" is not a valid repository/tag: invalid reference format
12:26:47 ++ cleanup
12:26:47 ++ local status=1
12:26:47 ++ '[' -n /tmp/tmp.3hfpsTLe0x ']'
12:26:47 ++ rm -f /tmp/tmp.3hfpsTLe0x
12:26:47 ++ trap - EXIT ERR
12:26:47 ++ exit 1

For now I've just changed the jenkins CI job to only use the POWER system. This seems like maybe a docker version thing?
POWER:
docker --version
Docker version 17.06.0-ce, build 411dd6e

x86:
docker --version
Docker version 1.13.1, build 092cba3

That seems ridiculously old... I'll see if I can update it.

Yeah, I believe the AS part of the FROM line was added in a 2017 version. 2017.06 must have it because the tests pass sometimes.

Darn, got the x86 systems updated but ending up with this version which does not work:
 docker --version
Docker version 17.03.2-ce, build f5ec1e2

Will need to look into manually updating my ubuntu links to get more recent.

Is this coming from the upstream docker repos?

I believe this is closable.


label's basemaps render are broken

Context
Zoom 13, Madrid Area

@makella is taking care of this.

Duplicated: https://github.com/CartoDB/support/issues/816


Creation of User Defined Types With Arrays

Is it possible to create user defined types for matrix elements that contain int array, for example?
If so, what types should be entered instead of double and uint64_t in the following line?
members = ['double w', 'uint64_t h', 'uint64_t pi']

Hi @rustam-azimov,
Unfortunately at the moment matrix elements can only be scalar elements of a fixed size.  This is a limitation of the underlying GraphBLAS spec.  There has been talk of having variable length elements, or event elements that are sub-matrices themselves but that's still in the discussion phase.

I would like to share that we were able to implement our algorithm for CFPQ that can restore all founded paths. We use C realization of GraphBLAS and C++ structure with int* array and int size members for matrix elements.  It will be great if in the future it will be possible to use int* in matrix element types in pygraphblas.

How you think, is it possible or there are some limitations from ctypes or Python itself?


Adds resistor-color exercise

Hi, this PR is to add a new exercise for resistor-color, here is a link to the problem-specifications
I'm still learning Dart, so feel free to point out anything that needs to be change or improved. I'm also happy to change the config.json to better fit your layout for the track.
Thanks! :)

I agree with your comments @Stargator.
@amscotti I merged your other branch so this might have a conflict now. Once you've rebased one of us will merge it.

@jvarness All rebased, thanks! :)


[Bug]: nvim notify bug when transparency is set to true

Your OneDarkPro config
local onedarkpro = require("onedarkpro")
local colors = require("onedarkpro").get_colors(vim.g.onedarkpro_theme)

onedarkpro.setup({
    dark_theme = "onedark_vivid",

    highlights = {
        -- Cursor
        CursorLineNr = {
            fg = "${blue}",
            bg = "${cursorline}",
            style = "bold",
        },

        -- Dashboard
        dashboardCenter = { fg = colors.blue, style = "bold" },

        -- -- NvimTree
        -- NvimTreeFolderIcon = { fg = colors.yellow },
        -- NvimTreeOpenedFolderName = { fg = colors.blue },
        -- NvimTreeRootFolder = { fg = colors.cyan },

        -- NeoTree
        NeoTreeFileIcon = { fg = colors.blue },
        NeoTreeFileNameOpened = {
            fg = colors.blue,
            style = "italic",
        },
        NeoTreeDirectoryIcon = { fg = colors.blue },
        NeoTreeRootName = { fg = colors.cyan, style = "bold" },
        NeoTreeTitleBar = { fg = "${bg}", bg = colors.blue },
        NeoTreeFloatTitle = { fg = "${bg}", bg = colors.blue },

        -- Indent Blankline
        IndentBlanklineContextChar = { fg = colors.gray },

        -- Telescope
        TelescopeSelection = {
            bg = "${cursorline}",
            fg = colors.blue,
        },
        TelescopeSelectionCaret = { fg = colors.blue },
        TelescopePromptPrefix = { fg = colors.blue },
        -- TelescopeBorder = {
        -- 	bg = "${bg}",
        -- 	fg = "${bg}",
        -- },
        -- TelescopePromptBorder = {
        -- 	bg = "${bg}",
        -- 	fg = "${bg}",
        -- },
    },
    ft_highlights = {
        rust = {
            TSField = { fg = "${red}" },
            TSVariableBuiltin = { fg = "${purple}" },
        },
    },
    options = {
        bold = true,
        italic = true,
        underline = true,
        cursorline = true,
        transparency = true,
        terminal_colors = true,
        -- window_unfocused_color = true,
    },
})
vim.cmd("colorscheme onedarkpro")

Error messages
nvim-notify
Highlight group 'Normal' has no background highlight
Please provide an RGB hex value or highlight group with a background value for 'background_colour' option.
This is the colour that will be used for 100% transparency.
require("notify").setup({
  background_colour = "#000000",
})

Defaulting to #000000
Describe the bug
Expected
no error
Actual
error
Reproduce the bug
Steps to reproduce:

set transparency to true
have nvim-notify enabled
open nvim

(I'm sorry for not having used the minimal.lua despite saying I have, but I'm pretty confident the issue persists and has to do with the themes Normal background color since I have not changed that myself...)
Final checks

[X] I have made sure this is not a duplicate issue
[X] I have made sure this issue exists in the latest version of the plugin
[X] I have tested with the minimal.lua config file above and still get the issue
[X] I have confirmed that Treesitter is working correctly by running :checkhealth treesitter

So is nvim-notify saying a background color needs to exist for the Normal highlight group, in order for it to function?

yep exactly, from what I can tell


Feature: There should be saparate message containers for read and unread

Is your feature request related to a problem? Please describe
Currently in message-container the seen messages are not deleted when the user view message
Describe the solution you'd like
for that we can saparate read or all  and unread message so that the user can differentiate that which messages was read or viewd by the user and which messages was not read or viewed by the user
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

I would like to work on this issue

Hi @upsaurav12 propose your design in slack #ux channel and take feedbacks from Nitin before code that part.

hello @tanmoysrt in this issue the problem the there is all and unread uncontainer but it is located at the bottom of message container(sorry i noticed today because i didnt have my laptop for 4 days so i viewed this issue by my mobile phone)
we can place these on top for mobile or smaller width

Hey @upsaurav12 can I work on this?

hey @upsaurav12 can i work on this ?

Hi @tanmoysrt , I’d like to take on this issue. Here’s my approach:
1-Add a read status to the message model.
2-Update the backend to mark messages as read when viewed.
3-Modify the frontend to visually differentiate between read and unread messages.
Please assign this to me, and I’ll get started!


Fixing readme wordcount tutorial

Original tutorial uses ReduceBy which requires 3 parameters as input and thus fails to compile.
ReduceByKey fixes the issue.

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   55.37%   55.37%
=======================================
  Files           9        9
  Lines         186      186
=======================================
  Hits          103      103
  Misses         81       81
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbfb62...02d58a3. Read the comment docs.


Remove incorrect Onyx prop initWithStoredValues

cc @marcaaron since you caught this here: https://github.com/Expensify/App/pull/9635#discussion_r988259244
Details

initWithStoredValues expects a boolean (see docs), it defaults to true, and if we set this to false the component won't be initialized with a possibly pre-existing error or loading state. Therefore, we can just remove it.
Fixed Issues
Not an issue, reported here: https://github.com/Expensify/App/pull/9635#discussion_r988259244
Tests

Navigate to the Close Account page (Settings -> Security -> Close Account)
Make sure there's no error showing & the "Close account" button is disabled but shows the text "Close account"
Close the page, then add some Onyx error message like this:

Onyx.merge('closeAccount', { error: 'Some error' });

Navigate back to the Close Account page and make sure the error appears
Click "OK", Close the page again, then clear the error & add a loading state like this:

Onyx.merge('closeAccount', { isLoading: true });

Navigate back to the Close Account page and make sure the "Close account" button shows a spinner
Now clear that loading state by logging out & logging back in

**Note: ** As far as I know, you can't manually insert Onyx data on native devices, so when testing those devices just turn off your internet connection, try closing your account, navigate away, then navigate back to see that the loading state is still spinning

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

Log in to any account
Turn off wifi / mobile data
Close the account, verify you see a loading spinner
Navigate away from the Close Account page, then navigate back
Verify the loading spinner is still present

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Same as web
iOS

Android

if we set this to false the component won't be initialized with a possibly pre-existing error or loading state

That's true. But is it the intention here? We have this loading state so I would wonder if that's something we don't want to initialize the component with. Didn't look too close at the code though 😄

Couldn't figure out how to access Onyx.merge in Safari

Why do we need to access Onyx.merge()? Maybe there is some user flow or manual test that would show this code is working as intended?

Can't manually insert Onyx values

Same as above. We should try to test this.

if we set this to false the component won't be initialized with a possibly pre-existing error or loading state

That's true. But is it the intention here? We have this loading state so I would wonder if that's something we don't want to initialize the component with. Didn't look too close at the code though 😄

We're clearing loading state when the "close account" response comes back - either in failureData here or by clearing most Onyx data on success - if the call is "loading" (we try to close account, navigate away, then come back while waiting) I think it makes sense to keep showing the loading state

Couldn't figure out how to access Onyx.merge in Safari

Why do we need to access Onyx.merge()? Maybe there is some user flow or manual test that would show this code is working as intended?

Can't manually insert Onyx values

Same as above. We should try to test this.

You definitely may be right, but here's my thinking:

We definitely can make sure CloseAccount command fails (easiest way is to set a 'private_amountOwed' value for that account, then close it)
Do get the error to show in ^ flow, we have to be physically on the Close Account Page, then try to close it (then the error will show up)
This isn't what we're testing here, what we're testing is that everything works when you're not on the Close Account Page and you navigate TO that page.

Do you see what I mean? We can get the error or loading state to show up in normal flows while the user is on the Close Account Page, but for these changes all we care about is opening the page while there's already some Onyx "close account" data available to load.
So the only thing I can think of is: Try closing the account when offline, navigate away then back, and check if loading state is still there - I'll go with that :D

Added screenshots on all platforms - ready for review

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @joelbettner in version: 1.2.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.13-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Break up Daytona help and colorize

Is your feature request related to a problem? Please describe.
There are ~25 sub commands in Daytona and currently they are arranged by alphabetical order. I'm proposing that we break that list up into broader categories like configuration of daytona, workspace lifecycle, server, and general purpose. For example:
  code               Open a workspace in your preferred IDE
  create             Create a workspace
  delete             Delete a workspace
  env                Manage profile environment variables that are added to all workspaces
  forward            Forward a port from a project to your local machine
  info               Show workspace info
  list               List workspaces
  ssh                SSH into a project using the terminal
  start              Start a workspace
  stop               Stop a workspace

  api-key            Api Key commands
  profile            Manage profiles
  use                Set the active profile
  container-registry Manage container registries
  git-providers      Manage Git providers

  purge              Purges all Daytona data from the current device
  serve              Run the server process in the current terminal session
  server             Start the server process in daemon mode
  provider           Manage providers
  target             Manage provider targets

  version            Print the version number
  whoami             Display information about the active user
  autocomplete       Adds completion script for your shell enviornment
  help               Help about any command

Describe the solution you'd like
This was inspired by the bun help which makes it much easier to find what you're looking for, understand what each does, and what each effects.

agreed. suggest we break them down similar to docs:

First block - everything that has to with installation
Second block - everything that has to with configuration
Third block - everything that has to with Usage
Forth block - misc. Things like whoami, version and anything that doesn't fit in the first 3

Flyio has subtitles, not sure but might be interesting

/bounty $30

/attempt #614

@tarunrajput There is a bug in the Algora bot that is failing to inform you about the limit of concurrent bounty attempts (2)
This is message that should've displayed:

We appreciate your enthusiasm but since you already have 2 active bounty attempts, we're going to keep this open for other contributors to attempt. 🫡

For this reason, we will only be considering your first two bounty attempts for now and the bounty will stay open to other contributors for a period of time. Thank you for understanding.

@tarunrajput Since you invested some time in the last two bounties as well unbeknownst to the limitation, we've reconsidered and decided to approach them with the same priority. Thank you for the contributions.


Jjo/otlp wip

What type of PR is this?
/kind feature

Any specific area of the project related to this PR?
/area outputs

What this PR does / why we need it:
Implements OTLP/Traces (OpenTelemetry) output.
Folding Falco events into traces allows them to be represented as "hierarchical" views.
Using a TraceID taken from container.id (or Kubernetes labels down to k8s.pod.name if present), all Falco events will be "rooted" under the container where it occurred, enabling a tree~ish view of these.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Will provide some screenshots  of these hierarchical views, as shown by an OTLP Traces backend like  Jaeger or Grafana Tempo.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jjo
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

fc427fc Fix message format
65ba901 Update config.go

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add Layer closes interface instead.

https://user-images.githubusercontent.com/36895037/232558205-e8b12a00-3dd5-4ef9-af1d-cab5231f0230.mp4
I am trying to add a layer... but the interface just closes instead.
Almost all other modules deactivated (Module Compatibility Checker and Module Management +)

Ah! So that button shouldn't be a button, please use the options next to it, and I'll get that fixed for the next release

Fixed in v4.02

Glad to help!  Thanks for your work.  I shudder to think about game-prep
without Tokenizer on my list of tools!  =)
 - Alan

On Mon, Apr 17, 2023 at 1:27 PM Jack Holloway @.***>
wrote:

Fixed in v4.02
—
Reply to this email directly, view it on GitHub
https://github.com/MrPrimate/tokenizer/issues/126#issuecomment-1511784351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIZPSPNMZVNUEIZUQYN6WADXBV4QVANCNFSM6AAAAAAXBO6AIA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Feature]: Loader analysis provide support for Rspack layers

What problem does this feature solve?
The loader analysis page should provide support for Rspack layers.
See https://rspack.dev/config/experiments#experimentslayers
What does the proposed API look like?
Currently, if a project uses Rspack layers, the loader analysis result will be inaccurate, I will try to provide a minimal reproduction later.

A minimal example of using layers + Rsdoctor:
https://github.com/chenjiahan/rsdoctor-repro-loader-layers
Currently all loaders from different layers are mixed together. We expect to separate them and mark the layers id in the UI.

related mr :

rspack support the layer : https://github.com/web-infra-dev/rspack/pull/8283
rsdoctor support the layer data: https://github.com/web-infra-dev/rsdoctor/pull/583


[Feature Request] Display the date of the last modification of the object

To delete a POI, you need to make sure that it really does not exist. In a large building, this can be difficult. A hint in this may be the date of the last edit of the object.
It can be displayed in an extended list of tags in order to make decisions based on it last and not make unnecessary requests.

This is an editor specifically for on-the-premise surveying. You have a floor filter for filtering out venues on different floors. So to make sure something does not exist, you just look around :)
Using dates from OSM metadata won't help you with anything, since people often add amenities remotely. And for check_date, that's what checkmarks are for.


Use custom font?

How can we replace the font in the Swipecards with a custom font(.ttf)?

This is a general Android question and not library related

It is library related, actually. The way this library works is that we call setContentView() on activity_m.xml which simply hosts a SwipeFlingAdapterView. That means that the only view we can retrieve via findViewById() is the SwipeFlingAdapterView and NOT the TextView from item.xml which is the object we need to get a hold of in order to change the TextView's font to our custom font.
This means that the usual way of setting a custom font to a TextView:
Typeface myTypeface = Typeface.createFromAsset(getAssets(), "fonts/myFont.ttf");
TextView myTextView = (TextView)findViewById(R.id.myTextView);
myTextView.setTypeface(myTypeface);
Doesn't work and we get a NullPointerException on the "myTextView.setTypeface(myTypeface);" statement.

You can customize the font and other attributes inside your adapter's viewholder class.

@xsorifc28 How exactly would that be done in code?

What kind of adapter are you using?  Can you post your code?

ArrayAdapter.

Something like:
ArrayAdapter arrayAdapter = new ArrayAdapter<String>(this, R.layout.item, items) {
@Override
        public View getView(int position, View convertView, ViewGroup parent) {
            View v = super.getView(position, convertView, parent);
            TextView tv = v.findViewById(R.id.mytextview)
             /* modify any of the views as you'd like */
            return v;
        }
    };

or you can create a new adapter whic extends ArrayAdapter.

Thanks @xsorifc28 this one worked like a charm. 👍


128x32 OLED

Hi,
I'm trying to use it with the 128x32 Oled, removing the IP infos (saving a couple of lines)
Where should I look?
Thanks.

comment lines 144-189

Thanks.
It worked, but I cannot get the right resolution. When I change SSD1306_LCDHEIGHT to 32, Text and graphics only take a quarter of the all display (unreadable).

Unfortunately I have only 128x64 display to test. SSD1306_LCDHEIGHT is used only to determine buffer size and in ssd1306DrawPixel() to see if pixel visible.
I can only assume that some modifications needed in init function. Try to change line 101     ssd1306Command(   0x12) to ssd1306_command(0x02) in ssd1306.c

You were right, thanks.
Now it works very well.


[Question]: Slowness of LLM inference step using chat engine

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hi, I am trying to setup a basic RAG chat pipeline with the below code and I am using Mistral 7B instruct model. I am noticing the generate function under the hood is a lot slower than the generate function from liltom-eth/llama2-webui setup for mistral model. (all other steps of retrieving nodes to be used in the prompt etc are fast enough. Only the step of generating content from the LLM is slow)
I made sure to have the same settings for the LLM on both the webui project and also the llama-index project by setting these in the llama-index project:
model_kwargs={"torch_dtype": torch.float16},
generate_kwargs={"do_sample": True, "top_p": 0.95, "top_k": 50, "temperature": 0.8, "num_beams":1}

Llama-index RAG pipeline is as follows:
from llama_index.llms import HuggingFaceLLM
from llama_index import LangchainEmbedding
from llama_index.langchain_helpers.text_splitter import SentenceSplitter
from langchain.embeddings import HuggingFaceEmbeddings

llm = HuggingFaceLLM(
    system_prompt="Consider you are a smart finanical assistant who has the capability to interpret SEC filings and answer the questions for the given text as expected.",
    tokenizer_name="mistralai/Mistral-7B-Instruct-v0.1",
    model_name="mistralai/Mistral-7B-Instruct-v0.1",
    device_map="auto",
   model_kwargs={"torch_dtype": torch.float16},
   generate_kwargs={"do_sample": True, "top_p": 0.95, "top_k": 50, "temperature": 0.8, "num_beams":1}
)

prompt_helper = PromptHelper.from_llm_metadata(llm_metadata=llm.metadata)
embed_model = LangchainEmbedding(langchain_embeddings=HuggingFaceEmbeddings(
        model_name="sentence-transformers/all-mpnet-base-v2",
    model_kwargs={'device': 'cuda:1'},
    encode_kwargs={'normalize_embeddings': False}
    ))
service_context = ServiceContext.from_defaults(
    llm=llm,
    prompt_helper=prompt_helper,
    node_parser=SimpleNodeParser(text_splitter=SentenceSplitter()),
    embed_model=embed_model)

index = VectorStoreIndex.from_documents(documents, service_context=service_context)
chat_engine = index.as_chat_engine(chat_mode='context',retriever_mode='embedding', similarity_top_k=2)

stream_response=chat_engine.stream_chat("what are the tax implications of the said filing?")
stream_response.print_response_stream()

Any help on where the speed difference is coming, would be appreciated
I am running them on 4 T4 GPUs and also noticed the GPU utilization during the generate function in the webui project is much higher % than that in the llama-index project which makes me wonder if there is some inefficiency of GPU utilization with the way I am setting up the RAG pipeline

@dosu-bot just to be super clear, I meant the generate function here and llama2-ui.
As you can see, it is not related to the LLMQuestionGenerator or OpenAIQuestionGenerator classes.

For example, the LlamaIndex project might be using a different version of PyTorch or a different CUDA toolkit version, which could affect GPU utilization.

both were run using the same hardware setup and conda environment i.e. so same package versions.

@Swarnashree I think it's likely slow because we are packing the context window to near its limit.
If you just prompt the llm with llm.complete("Hello!") it will return very fast.
But if you fill the context window with something like 3900 tokens, inference will be slower

@Swarnashree I think it's likely slow because we are packing the context window to near its limit.
If you just prompt the llm with llm.complete("Hello!") it will return very fast.
But if you fill the context window with something like 3900 tokens, inference will be slower

Yes, I agree, just to mention, I copied the final RAG based prompt that was generated by llama-index project onto the llama2-ui project. So both have the same incoming prompt into the llm

If you spot something that could make it faster in our source code, I encourage a PR!
https://github.com/run-llama/llama_index/blob/main/llama_index/llms/huggingface.py

Yes, I agree, just to mention, I copied the final RAG based prompt that was generated by llama-index project onto the llama2-ui project. So both have the same incoming prompt into the llm

Interesting. If you have time to debug this it would be appreciated, off-hand I'm not sure what the difference is

Interesting. If you have time to debug this it would be appreciated, off-hand I'm not sure what the difference is

Hi @logan-markewich, after spending some time debugging, I see that the bottleneck comes from starting the thread for write_response_history in context.py code
To dig further, I tried all combinations of using/not using background(bg) threads:
i.e. self._model.generate thread in huggingface.py code(lets call it func1) and write_response_history in context.py (lets call it func2) and bottleneck is evident ONLY when both are on bg threads
func1 on bg thread, func2 not on bg thread: speed of inference is as expected (:+1: )
func1 on bg thread, func2 not on bg thread: speed is not as expected (:-1: )
func1 not on bg thread, func2 on bg thread: speed of inference is as expected (:+1: )
func1 not on bg thread, func2 not on bg thread: speed of inference is as expected (:+1: )
This probably means the GPU performance is being degraded due to the over multi-threading. Is there any way to set this as perhaps a configuration to limit the number of threads?

@Swarnashree amazing debugging!
I'm not 100% sure on how best to resolve this 🤔 the thread is needed in order for streaming to work.
I'll look into this and chat with the team, and see if we can figure out a fix.


[TxManager] use TxManager to handle transactions with effects

Currently AuthorityState::handle_certificate_with_effects() does not enqueue transactions to TransactionManager. Instead, it directly calls process_certificate() to execute transactions, which will return errors if any input object is not yet available. So callers have to retry until a transaction can succeed, which is inefficient.
This PR refactors the the function to enqueue transactions to TransactionManager for execution. Now callers of AuthorityState::handle_certificate_with_effects() do not need to worry about checking errors or retries.

Yeah I think this is related to one of our previous discussions, i.e. whether TransactionManager should manage the pending certificates itself, or have Narwhal replay certificates for crash recovery. The considerations are similar.
Approach 1: TransactionManager manages certificates pending execution
This is close to the current approach. Executions can happen in parallel, so transactions do not finish executions in order. Narwhal can avoid the complexity of keeping track of the low watermark of executed certificates, which would be necessary if Narwhal is responsible to replay pending certificates. I wonder if checkpoint may be able to avoid some complexity too by just relying on TransactionManager to manage pending certificates. For user submitted RPCs, keeping track of pending certificates may speed up crash recovery a little.
Approach 2: Narwhal and Checkpoint manage certificates pending execution
In this approach, we would be able to potentially save a few disk writes in TransactionManager. The downside is that both Narwhal and Checkpoint need to keep track of and persist lower watermark of executed transactions, which may increase complexity.
An intermediate approach, e.g. TransactionManager only manages pending certificates from Narwhal, seems less ideal to either approach above.
My current preference is approach 1, because it seems simpler. But there could be other reasons why checkpointing needs to keep track of low watermark of executed transactions. We can continue the discussion next week and see what we can improve here.


Parsing events?

Hello,
I'm looking to possibly utilize this library to parse divelogs from the Garmin Descent.  The files are standard ant files with some (currently) undocumented messages and events.
I do see that a number of the dive messages are currently supported, however there are a number of events that are included within the Descent files that I'm not seeing.
In particular, what I'm looking for are events 56 (Dive Alerts) and 57 (Gas Switches)
Does fitparse process events?  If so, how do I access them?

Looking further into it, I can see how the profiles are being generated from the SDK.  Looks like the best method of action is modifying a profile by hand until the events are released in an SDK version.

If anyone is wanting a copy of profile.py which includes the correct field_types data for events 56 and 57 let me know, I have a modified version available that seems to work well for all current events as of OS version 6.0

Hey @rjjanuary, I too am trying to extract the extra events/fields that are populated by the Garmin Descent.  I'm interested in your profile.py if you're willing to share.  Thank you!


⚠ SceneTime has degraded performance

In 32c1994, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 8660 ms

Resolved: SceneTime performance has improved in e8894d1.


Add pylint to CI

[ ] update dependencies
[ ] add pylint config
[ ] update make lint
[ ] update github ci

@egregors  you can assign this to me. I'll try to implement it this year 🤣


PPO1 declines after 530 iterations

PPO1 run on 16 processes declines after 530 iterations with random seed 0:

Also why is the clip_param multiplied by the learning rate in PPO1, the constant version has a much better learning curve in the mujoco domain?

Hi @ecada ! Which mujoco environment are you using ?
Clip parameter in ppo1 is not multiplied by learning rate, rather, by the annealing factor of the learning rate. I personally have not experimented enough with mujoco to know if the annealing of learning rate and clip factor is justified. @joschu @olegklimov any thoughts?
As for decline of the rewards - that likely can be avoided by tuning hyperparameters (as your own experiments with constant vs linear schedule show)... Also, if you keep training, does the reward keep declining or does it rather level (at least approximately)?

Hi again @pzhokhov ! I'm using mujoco 1.50 and the default given hyper parameters for the Humanoid-v2 environment with random seed 0. In the default version the 'linear' learning rate is used which decays over time and that is fed into the learning rate placeholder that is multiplied by the clip parameter. It's shows the same pattern in 3e7 timesteps of training. I was curious why the default version is linear.

I see... I suspect linear annealing of the clip factor and learning rate is advantageous in some other mujoco environments, so we transferred it to humanoid without tuning specifically on humanoid (the hyperparameters in run_mujoco.py are uncannily similar to ones in run_humanoid.py). Again, @joschu @olegklimov please feel free to override this if I am wrong on that.

Yeah the linear schedule helped a little bit on the 2D tasks. I'm not sure if it helps on the humanoid, but it seems sensible--in general stepsize annealing helps.

Thank you @pzhokhov and @joschu for clearing it up. I'm grateful for all the valuable feedback and the way this library is maintained. 🥇


Fix #81 Add StatusFilter to PropertyFilter

This pull request resolve #81
While using this SDK for my project, I noticed that PropertyFilter does not have a filter for the status property and I found the same issue in #81
At that time, the issue can't be resolved but now it can be. So I added StatusFilter based on Notion API reference.

This PR is my first contribution and it’s first Kotlin experience from Java. Please let me know if you find something wrong with my PR. I’ll fix.

@whatasame Thanks for sending this PR! The changes look good to me but I have a few questions:

Have you veified if your change works with Notion's production API?
Have you managed to create the status prop in database via API? https://github.com/seratch/notion-sdk-jvm/commit/4ad1aa47022fcdfff039c73b64468ca71273b402 still does not work. This is why I've been holding off this task.

If you're confident that your change works, I can merge this PR. But we still miss automated integration tests as creating a database for testing still does not work (if I am not doing wrong in my branch). So, even after merging this PR, I would like to keep #81 open.

@seratch Thanks for your review! Here is answers for questions.

Have you veified if your change works with Notion's production API?

Added test code for StatusFilter in DatabasesTest. It works if you add the default status property to test database.

Have you managed to create the status prop in database via API? https://github.com/seratch/notion-sdk-jvm/commit/4ad1aa47022fcdfff039c73b64468ca71273b402 still does not work. This is why I've been holding off this task.

No, you're right. The Notion API doesn't support creating database with status property. According to the API Reference, only empty status database properties can be created
I understood that the first commenter in #81 needed status condition filter to query the blocks in the database. So I only cover that scope.


Please move all @nestjs core dependencies to peer dependencies

This way it's more robust, we can use our own version.
This is a best practice for these kind of libraries.

this lib seems dead, try another lib https://github.com/liaoliaots/nestjs-redis


Fix frequentist's guess

First, thanks for your amazing book!
Here, mu_1 is 3000, and mu_2 is 12000. So a frequentist's guess would be 3000 + 12000 = 15000.
35000 is the prior for the distribution of the true price, which the frequentist would typically not use :)

closing as this is evidently unmaintained


Potential fix for jupyter docker build

Still need to confirm this, but I think what was happening was that jupyter-docker/build.sh was using the Leo Dockerfile in the base directory instead of the jupyter-docker/Dockerfile.
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[ ] I've documented my API changes in Swagger

In all cases:

[ ] Get two thumbsworth of review and PO signoff if necessary
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this
[ ] Test this change deployed correctly and works on dev environment after deployment

I'm running a Jenkins build to test this. It looks to be actually building the Jupyter docker now: https://fc-jenkins.dsp-techops.broadinstitute.org/job/leonardo-build/73/

Jenkins passed, and it seems like the docker img was pushed successfully.

I'll plan to merge this after the demo today.

Turns out this approach has an issue, @ansingh7115 has a better fix. Closing this.


Scheduling doesn't use active hours

Bug Summary:
The scheduling algorithm currently does not take into account the active hours the user specifies in the settings menu.

Steps To Reproduce

Create a task using the modal such that it gets scheduled in a non-active time

Expected behaviour
Tasks should only be scheduled in active times, e.g. 9am-9pm
Observed Behaviour
Tasks are scheduled any time, disregarding active times.

PR  #260  and  PR #279  closes this issue


Has anyone created a dashboard for cloud custodian?

We are looking to use Cloud Custodian to provide governance and management of over ~50 to ~70 AWS accounts. This will cover many different teams and groups across the enterprise. I foresee the policies we create will be used to tag/notify when resources are out of compliance and some will actually take actions like the stop and starting of an EC2 instances when they go in and out of compliance. We will also provided services like offhours scheduling and such.
All of of that is great and possible with Cloud Custodian. So my question is has anyone created an accompanying dashboard that teams and owners of individual AWS accounts can go view to see things like (just examples, but I'm guessing we will need more things):

Number of instances out of compliance
Number of instances tagged for stopping or termination
Number of instances stopped or terminated b/c of compliance
Number of  resources out of compliance

I'm thinking we need some sort of reporting or dashboard so account owners can see how things are in their account and what actions we have taken on their behalf.
Thanks

There is no dashboard to my knowledge. AWS Config looks like it could fill parts of that role one day, but it's still an early product from AWS and doesn't support a lot of service types, and you can't filter by resources you own easily, etc.
You can pull all the data from s3 or cloudwatch for what changed and make some passive UI out of that. We'd help you figure things out too if you want, join gitter.

Sounds good. Let me know how to join.

We do have a few dashboards available that capture those metrics, and more on the way.
First if you pass -m on the custodian cli, it will output cloudwatch metrics into the target account. Cloudwatch dashboards can be used to construct some metrics dashboards on a per account basis, this is a usable baseline but suboptimal imo due to the lack of api on cloudwatch dashboard (manual work per account, plus adjust per policy changes).
Second, in our tools subdirectory on a git checkout we have c7n_indexer that will aggregate all custodian cloudwatch metrics across multiple accounts into an influxdb that you can drop grafana on top of, it allows rollup across subsets of accounts, albeit with an assumption of consistent policy names.
We've got a few more items on the backlog for the indexer (elasticsearch support, additional ux/ui) per other open issues.
wrt to joining gitter, https://gitter.im/capitalone/cloud-custodian

cool, will explore this option :)

Second, in our tools subdirectory on a git checkout we have c7n_indexer that will aggregate all custodian cloudwatch metrics across multiple accounts into an influxdb that you can drop grafana on top of, it allows rollup across subsets of accounts, albeit with an assumption of consistent policy names.

Thanks @kapilt and @JohnTheodore. I'll take a look at the indexer. As for the cloudwatch metrics I don't think that has the detail I'm looking for b/c it only provides me raw numbers, but I think if I can use the logs that are stored into S3 thats what will get me there. I'm thinking I need to link the compliance rules and checks to the actual resources that are effected by those rules. Something like instance i-abcdefghi is out of compliance and will be stopped on 5/12/2017. And I need to allow teams to sort or filter by their instances and resources and suppress the things they don't necessarily care about.
I joined gitter. Great group and already seeing a lot of good questions and information come across.


Set up conventions for initializing pipeline from (Config, mth5) pairs

The current config has a "mth5": /path/to/mth5.h5 field at the top level.
In general, we want this to be an optional field.
We want to support the following cases for initializing a pipeline run:

process(config, mth5_path)
process(config)

In case 1, the "mth5" field in the config would be expected to be blank.
The config["mth5"] will get overwritten by "/path/to/h5"
A check could be provided to warn a user that the "mth5" in the config is being overwritten in the case that it was not blank to begin with.
In case 2, if there is not "mth5": /path/to/mth5.h5 in the config an exception is raised.
relates to issue #71.

This is now supported, but there is a bigger issue here.  We need a TFKernel() class to interrogate mth5 and pull best case processing inputs


Size of navbar logo in dark mode

Hi Carl,
I have used your nice light-dark mode for my draft website. I copied and pasted your code for my dark and light .scss files, as well as this entry in my _quarto.yml file
navbar:     logo: images/logo-light.png
(This includes your code for the navbars in the /*-- scss:rules --*/  of those files.)
This screenshot shows that the size of the displayed navbar logo for the dark mode is extremely small. The logo for the light mode is fine.

I cannot determine why this is the case.
The pixel dimensions of the images are:
dark 1014 × 188
light  1002 × 162
Can you determine why this is the case ?
Let me know what information I can provide.
Cheers.
Howard

Hi Howard - you may need to play with the padding and background size in the dark-mode snippet below. It essentially hides the foreground image via the padding and uses the background (dark-mode) image instead. These px's just happened to work nicely for my logo size.
.navbar-brand > img {
    padding: 20px 20px;
    background: url("images/logo-dark.png");
    background-size: 40px;
    background-repeat: no-repeat;
}

The alternative is to remove the above, use a mid-grey image, and optionally use the two snippets in the "Night Mode" post to brighten of darken in dark and light mode. That works in most browsers except Safari, hence I used the approach above instead.

Hi Carl,
I've not had success with the logo display in the dark theme.
I tried changes in  the padding and background size values of the first snippet you provide above. Only at crazy small values for padding and very large values for background size did the logo enlarge, but was then very distorted.
Only if you have the time and inclination, here are the logos:
https://www.dropbox.com/sh/c4gumy371cpjyly/AADbYlS4XxHS98ZyW2_CDRHAa?dl=0
I made the backgrounds transparent via: https://www.adobe.com/express/feature/image/remove-background
The alternative method you mention works very nicely in Firefox and Chrome but not, as you mention, in Safari.
Cheers.

Hi Howard - This seemed to work reasonably well for me.
.navbar-brand > img {
    padding: 20px 120px;
    background: url("logo-dark.png");
    background-size: 250px;
    background-repeat: no-repeat;
}

Thanks so much!  It's great.
I clearly don't understand padding and background-size
Happy Holidays!
Howard


Keywords in statements following indexing of 2D matrix using variable across multiple lines are NOT highlighted

VSCode Version: 1.49.0
OS Version: Linux x64 3.13.0-71-generic

Steps to Reproduce:

Write the following code with vscode

bool function1() {
    int mat[100][100];
    int x = 50;
    auto price = mat[x]
        [x];

    // Keywords in following statements are not highlighted
    auto tmp = 2;
    auto a = tmp;
    return true;

}

bool function2() {
    int mat[100];
    int x = 50;
    auto price = mat
        [x];        // Keyword in statements following are not highlighted
    auto tmp = 2;
    return true;
}

Does this issue occur when all extensions are disabled?: Keywords like auto / return are still not highlighted, while variable names are

@wsrfad  what language are you using?

C++

Since this issue comes from the C++ grammar I've moved the issue to that repo: https://github.com/jeff-hykin/cpp-textmate-grammar/issues/507


Improve coverage for fs operations

TestCopyDir: add subdirectory to the test case; extend test to handle
multiple files in different directories.

Add tests for error conditions in CopyDir: source directory cannot be
read; destination directory cannot be read; files cannot be read.

Add tests for error conditions in IsRegular.

Add tests for error conditions in IsDir.

This addresses issue #41.
Signed-off-by: Marcelo E. Magallon<EMAIL_ADDRESS>

Interesting, Windows behaves differently wrt to the errors that are produced. I guess setting the file/directory permissions doesn't work / doesn't work as expected on that platform.

This would now need to be refactored to incorporate the new test harness - https://github.com/golang/dep/blob/master/cmd/dep/testdata/harness_tests/README.md. As this PR has been languishing for a while now, I'm going to close it - please feel free to reopen a new PR with the same basic goal!

bump

Maybe @mattn or @tro3 could lend some thoughts on how to make this work for windows? I know both of you fine folks dev on that OS 😄

Sorry about the silence for the last few weeks (new kid :-)
I've updated the PR with the suggestions and I added the skip to the failing test. Hopefully someone with a better grasp of Windows can provide a better implementation in the future.

Sorry about the silence for the last few weeks (new kid :-)

!👶 👶 !! 🎉!! 🎉🎉! 🎉❤🎉 🎉🎉❤ 🎉 🎊 🎊!!!!!!
I'm out of time for dep for tonight, but hopefully will have time to get to reviewing these tomorrow. 😄

ping, this potentially blocks #539

Ach yeah, I totally dropped this one, thanks for pinging on it. Even had a partially-written review on it. It was really just about the windows bits, though - the rest of this looked fine.
I've opened a #548 as a follow-up for the windows bits.


update setup.py

Add mpi and nvidia options to setup.py
Small cleanup of docker file to actually install devito rather than setting python path for every command

PR name also needs a suitable tag


Trouble creating rooms using my firebase console account

Describe the bug
I've tried your app with my custom 'firebase_options.dart' but I can't create rooms anymore, (on my account).
Possible, maybe I have't enabled all necesary services.

firebase_options.dart is not enough to change the firebase connection there is some other files must be changed
also You can try to create new project and copy all files in lib folder except my firebase options , the assets and the pubspec.yaml  and configure with your firebase project it may work
i hope this helps


kivy embed  omxplayer

# how embed the third player (omxplayer) in kivy

Is there an issue or is this a question?


Installing pyPLNmodels in spyder environment

Hello,
So far I was always able to install packages I needed with
conda activate spyder-env
conda install -n spyder-env *package*

I tried Bastien's suggestion with:
conda activate spyder-env
pip install pyPLNmodels

It returns that requirement*s are already satisfied. Apparently, a previous try where I installed directly from the spyder console worked.  And indeed when calling conda list, pyPLNmodels appears under chanel pypi but not as the rest under conda forge. When calling import pyPLNmodels in spyder it still returns. ModuleNotFoundError: No module named 'pyPLNmodels.
So if I understand correctly the Channel is not accesible maybe?
I tried solutions found here.
Unfortunately, when trying this solution it returns. This directory cannot be added to the path! If you want to set a different Python interpreter, please go to Preferences > Main interpreter.
Please not I consider myself still an absolute beginner in python and using anaconda / spyder.
Any help is very much appreciated.
Best regards
Jakob

Closed with dev@3a5cac9


clickToPlay broken on touch devices

Expected behaviour
Tapping a paused or stopped video should start playing it when clickToPlay is enabled.
Actual behaviour
On touch devices it does play initially when tapping, but after it's been paused and you tap it only plays briefly than pauses again. It seems like the touchend event is getting in the way. If you never release it works.
Probably related to the #968 fix?
Environment
Chrome 68 (Android or Desktop with webtools touch-emulation)
Link to where the bug is happening
https://plyr.io/

Damn it - that'd be my change. Fix one thing, break another 😂

@sampotts
yes, I have the same issue, it is broken on the latest release
any timeline for fixing it? thanks

Same issue here.... I might need to roll back to a different version. What is the last version where this issue was not happening?

I ended up for now downgrading back to v3.3.23. Because it allows the control to fadeup when you tap the viewer. In the newer version it wont toggle play/pause on tap.

The issue is that video play() is bound to both click and touchstart (listeners.js:375). Naturally, the video starts playing on touchstart, and then a couple hundred milliseconds later the click event fires and pauses it.
So obviously we don't want both, but can someone with more experience please enlighten me to why we might want to involve the touchstart event at all? It's the equiv of firing on mousedown. Click is so nice and universal. Obviously click has a delay because it fires on mouseup.. but I consider this to be minor. touchstart also has a host of other issues. Primarily that someone who tries to scroll the page by swiping on the video itself will cause it to start playing (well, it would if the bug didn't cause it to immediately pause again afterwards! :p). Swiping over video is a pretty likely scenario on mobile of course, because video takes up most of the page.
So, obvious solution (and I have tested this) is to simply remove touchstart as an event trigger for play().
A side effect of fixing this, however, is that "First touch on touch devices will just show controls" (listeners.js:383) is no longer true. But was it ever true/working?? The reason for this appears to be two-fold. One, is that toggleControls() is fired by the touchstart event at line 291, and as such the controls are always showing again by the time our click event is fired. The fix here would seemingly be to also remove touchstart as an event trigger for this function. But I tried that, and found that there appears to be a race condition whereby which the container() elements.container listener fires immediately before the media() elements.container listener. To try to reorder those would put me way out of my depth with this codebase.
I'm putting in a PR to simply drop touchstart as an event trigger for the media play() event, as it's currently breaking things pretty badly.

This should be resolved in v3.4.4. Cheers all 👍

clickToPlay doesn't seem to trigger video playing in Webkitview / ios.

I am on iOS14 and when Vimeo-video starts to play the controls fade down and tapping/toiuching screen doesn't bring it back. The stay hidden until clip ends.

I'm on iOS14.3 & w/ Plyr v.3.6.3 - same issue, I can start to play youtube vid's then the controls fade down and tapping/toiuching screen doesn't bring it back. The stay hidden until clip ends.

I have the same issue(clickToPlay doesn't work on touch devices) even in mobile version via chrome dev tools. On iOS 14.4(Safari) too.

I have the same issue with 3.7.8, even on chrome dev tools it does not work. Any quick fix or workaround?

Here's a quick workaround for anybody trying to fix this issue:
this.player.on('click', (event) => {   if (this.player.touch && event.target.tagName === 'VIDEO') {     if (this.player.playing) {       this.player.pause();     } else {       this.player.play();     }   } });


config: necessary variables

These are the variables that cdn-dler will need to know in order to work as expected.

Where to download files.
** Probably some kind of mapping for a CDN. e.g. https://ajax.googleapis.com/ajax/libs/**/*.js => ./js/angularjs/1.6.4/angular.min.js
Whether to download files.
** Perhaps they are already there?
** Perhaps user just wants a verbose dry run?
How to download files.
** All files in just one place? A flat folder?
** Files separated out into various subfolders?
** mkdir for missing folders or throw an error?
** 'clean / delete' folders?
** overwrite current files?  Check if they exist? Or throw an error?
How to insert scripts into HTML file?
** Overwrite HTML file?
** Create a new HTML file?

Can close this as done.  However, will open an issue for fallback, as this is not yet implemented.


[WIP] Create a Vault Service

Creates a Vault Service running in it's own namespace backed by a consul cluster.

superseded by k8s-retool branch.


dal is not zip safe

First I installed dal indirectly via python setup.py develop.
For some strange reason dal gets installed as zipped egg if you install it this way.
This means the python code works, but the static files can't be found and this means the js files don't get found.
I suggest you use zip-safe=False in setup.py.

Going from django-autocomplete-light==3.0.4 to django-autocomplete-light==3.1.0
The 'vendor' folder is missing in dal_select2/static/autocomplete_light/vendor when installed with pip. I'm not sure if this is related or not.

@maplemike  I'm having the same Issue. Vendor folder is not present. I've tried pip and python setup.py install

I think these are two unrelated issues.
But I was having the same issue with files located in the 'vendor' directory. I created an other issue for this: #620

zip_safe=False is already in setup.py. Closing this.


undefined symbol: RestClient Connection

Expected behaviour
It should send a request.
Actual behaviour
/usr/local/EmojicodePackages/network-v0/network.so: undefined symbol: _ZN10RestClient10ConnectionC1ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
Environment and debugging details
cmake version 3.10.1
ninja 1.8.2
clang 5.0.1
g++ 7.2.1
Arch Linux
libcurl/7.57.0
not sure how to get the compile flags.
Additional stuff
The code can be found here: https://github.com/MagnificentPako/emojicode/blob/emojicode-0.5/DefaultPackages/network/network.cpp
And here are the (I believe) relevant parts of the CMake file: https://github.com/MagnificentPako/emojicode/blob/emojicode-0.5/CMakeLists.txt#L45-L46

How are you installing restclient-cpp? From one of the release packages or building it yourself? What does the compile and linker command line look like in your build?

I installed it using the "restclient-cpp" package in the AUR which didn't seem to export any symbols. Building it myself seems to have fixed it.

oh interesting! I didn't know this was on AUR :). Glad you like the library and got to fix your problem.


Knetminer build fails in slow systems

Reported by Ajit working under Windows and seen by myself under a VM running Windows.
trying to build aratiny-ws when the system is slow fails with test errors like invalid JSON returned by the servers or HTTP 503 returned by the server. These are misleading messages, the actual cause of the problem is that our WS application wasn't started by Jetty (the embedded web server used by the build to start the API and run tests against it)
By running manual-ws.sh (which is just a wrapper of the aratiny-ws build) and checking with a browser (eg, by going to http://localhost:9090/ws/aratiny/countHits?keyword=seed), one can see that that the WS application results in the "unavailable" state.
When I tried to rebuild with the stderr/stdout redirected to a file, the build succeeded. This made me think that the problem is in some timeout (printing on the VM screen is quite slower than appending to a file), and indeed setting this property made it to go away.
I'm filing this ticket to keep a record of the issue and I'm submitting the fix straight after it. I'll wait that @AjitPS verifies it on his system to close it.
Note: Not even I would say Windows is so slow... it's just that Ajit might have experienced some build slow-down for some reason, and certainly my test under a VirtualBox with limited RAM was quite sluggish.

pulled and tested, and can verify that this is fixed and works now! thanks @marco-brandizi
fyi @KeywanHP


Push tags to GH releases

When a new tag is created in Github, the wercker build should build and push a binary release to GH Releases.

Separate wercker pipeline to manually create the tag and upload to github releases
Wercker build runs on every tag

The release processes and tagging is now all done by wrecker so I believe this is fixed now.


Setting meta data based on asyncData

In my SPA i am dealing with a slightly unusual problem. I am fetching data for each page from static json files. Within these files all the content is represented, including the meta data. Unfortunately i am experiencing that the variable can be null due to its async behaviour and cause an error. How do i work around this?
Here is an example of what i am doing:
export default {
  data () {
    return {
      content: ''
    }
  },
  async asyncData ({req, params}) {
    let { data } = await axios.get(`/data/blog/${params.slug}.json`)
    return { content: data }
  },
  head () {
    this.content.seoMetaTags.map((meta) => {
      if (meta.tagName === 'title') {
        return {
          title: meta.content
        }
      }
    })
  }
}

You can just check if seoMetaTags exists

@KonstantinVlasov, i tried this, and it works perfectly for the exception handling. Unfortunately the title is not being set. I am simply checking with inspector, it shows empty title.

I just updated my example, which does not work..

So apparently  my return did not really work within the map function.. I changed it to a for-loop and now its working.


pandas 0.23.1 munches output files

pandas 0.23.1 partially overwrites output in the to_csv function.  This results in incomplete file output when writing out MagIC tables.  Specifically, the
Solution: install 0.23.0.
pip install pandas==0.23.0

or
conda install pandas=0.23.0

pandas 0.23.2 should have the fix for this issue, and should be released around the end of June.
https://github.com/pandas-dev/pandas/issues/21471

jeez

On Jun 19, 2018, at 10:46 AM, Lori J<EMAIL_ADDRESS>wrote:
pandas 0.22.1 partially overwrites output in the to_csv function. This results in incomplete file output when writing out MagIC tables. Specifically, the
Solution: install 0.22.0.
pip install pandas==0.22.0
or
conda install pandas=0.22.0
pandas 0.22.2 should have the fix for this issue, and should be released around the end of June.
pandas-dev/pandas#21471 https://github.com/pandas-dev/pandas/issues/21471
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/371, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDfL2NBZsM9MoqEenLy8qAZ6UvHV3ks5t-TkEgaJpZM4Ut9Hw.

I've put a workaround in, but should revert it once pandas latest version is fixed.

i will leave this issue open in the meantime as a reminder.

I'm just going to leave this workaround in -- it doesn't create any problems anyway and insures proper behavior.


Cannot process less files

Hello,
I made a simple edit in themes/default/less/navbar.less and I wanted to process less files but it ends with error.
$ git diff less/navbar.less
diff --git a/themes/default/less/navbar.less b/themes/default/less/navbar.less
index 0a8e4d4..8dc651c 100755
--- a/themes/default/less/navbar.less
+++ b/themes/default/less/navbar.less
@@ -215,6 +215,10 @@
   text-decoration: none;
   font-weight:700;
 }
+
+.navbar .nav > li > a.thin {
+  font-weight:400;
+}
 // Buttons
 .navbar .btn {
   display: inline-block;

lessc --compress less/bootstrap.less > css/style.css
NameError: #grid > .core > .span is undefined in /Users/malekjir/Sync/Work/Projects/gitlist/themes/default/less/navbar.less on line 174, column 3:
173 .navbar-fixed-bottom .container {
174   #grid > .core > .span(@gridColumns);
175 }

make: *** [bootstrap] Error 1

Problem was with my OSX lessc installation.


add favicon to this website and personal sites

Added to all 3 websites, supporting all different platforms.
Added to it also scripts & tooling, so we can update easily later as well.


Adding TBR tallies and .vtk creation

Previously in the README.md file, the documentation spoke about the production of Tritium Breeding Ratio (TBR) values and the ability to visualise a mesh of TBR, while the tallies extracted were for heating.
I have rectified this by running cell and mess tallies for both the Tritium Breeding Ratio and for heating.

Sorry for the delay I must have missed the github notification for this PR. Thanks for fixing the scripts much appreciated


DDUF documentation

TODO:

[x] find a meaning to DDUF (currently DDUF’s Diffusion Unified Format) :smile:
[ ] make sure https://huggingface.co/spaces/DDUF/dduf-check is up-to-date or remove from docs
[ ] create an schema as good as the magnificent GGUF one
[x] add a diffusers example

https://moon-ci-docs.huggingface.co/docs/hub/pr_1526/en/dduf

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Will merge this once huggingface_hub / diffusers have been released :)

@Wauplin should this be merged now?


fix NamingServiceProcessor deleteInstance is incorrect

fix repeated invoke iterator.next()
fix java.util.concurrent.CopyOnWriteArrayList.COWIterator not support remove

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #175   +/-   ##
========================================
  Coverage      9.50%   9.50%
  Complexity      231     231
========================================
  Files           144     144
  Lines          7031    7031
  Branches        967     967
========================================
  Hits            668     668
  Misses         6246    6246
  Partials        117     117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27192ae...18c53a0. Read the comment docs.


Update Chewie Version to Satisfy Latest Prompts Version

I'm putting Solo in my starter and noticed I couldn't install it without downgrading prompts because Chewie had a hard version for Prompts.
But then I saw Joe Tannenbaum fixed it with a Chewie update, like a champ.

Love him for that! And thanks for the PR


Preview share link

Hi :) and thank you for making this plugin.
I got it to work showing previews on my site using version 3.0.0-beta.4, however I can't seem to get it to work with Prismic feature, share preview link.
The link that is being copied is just the "original" url, so no preview available.
Has anyone else experienced that?

Closing this out as v3 has been in open beta for a while now and solves this issue. Please give it a try if you haven't yet!


Add play/pause functionality

Add a command/key that allows user to pause/play the video render
Add a function that waits for a play pause keypress and in case of the key being pressed/event happening, pauses (or plays) the video, i.e. pauses the rendering at the current frame.

Hello, can i work on this?

Yeah sure @JeremiasFuentes. Feel free to contribute

Enhancing play/pause functionality
Though @JeremiasFuentes did provide a solution for the problem, I am welcome to other solutions that use fewer dependencies (use vanilla modules).
This is mainly because the keyboard module requires administrator/root privileges for linux systems and is experimental in macOS.


Fix wrong DE l10n of "Part of these collections"

Fixes #183.
German for "Part of these collections" was wrongly translated as "Teile dieser Sammlungen". That would translate back to "Parts of these collections", which distorts the meaning with "parts" being plural. Let's stick with singular! -> "Teil dieser Sammlungen"

I tried to follow the instructions for creating my first pull request here correctly, let me know if it's now in the right shape.


OTP 26 not supported

Erlang's OTP 26 introduced some breaking changes to the ssl library. Using tmi.ex with OTP 26 now fails to connect due to incompatible default options passed in to :ssl.connect/3 that ExIRC wraps with its ExIRC.Client.Transport.connect/4.
In practice, from OTP 26 onwards :ssl connect verify option now defaults to :verify_peer instead of :verify_none which due to missing CA certificates causes connecting to fail.
The solution to support OTP 26 here could be something like adding verify: :verify_none as the last argument to:
https://github.com/ryanwinchester/tmi.ex/blob/61ab7c88ef12efa864f3874317ca2dd3c7b51620/lib/tmi/client.ex#L87
A more comprehensive solution would be adding support to fetch certificates upon connecting.
More info:
https://www.erlang.org/blog/otp-26-highlights/#ssl-improved-checking-of-options

I opened a placeholder for the solution https://github.com/ryanwinchester/tmi.ex/pull/21


[Support] watchguard and openvpn still with password auth

As far as I can see pivpn creates Certificates in both Watchguard and OpenVPN modes.
I know that's the way to go and it's way safer that way, but can we still have connections just using a password?
How do I set the IP range the VPN clients will be put in? (to put them into the routers non-DHCP range to actually access the network).

As far as I can see pivpn creates Certificates in both Watchguard and OpenVPN modes.
I know that's the way to go and it's way safer that way, but can we still have connections just using a password?

Possibly: https://openvpn.net/community-resources/using-alternative-authentication-methods/

How do I set the IP range the VPN clients will be put in? (to put them into the routers non-DHCP range to actually access the network).

By changing the variable here (for openvpn) or here (for wireguard).

Possibly: https://openvpn.net/community-resources/using-alternative-authentication-methods/

Does that mean pivpn -add just doesn't create certificates if client-cert-not-required is found in the /etc/openvpn/server.conf or does that mean that the certificate created by pivpn can be ignored?
I was just a bit confused, older howtos for pivpn possibly using old versions simply got auth data without certificates. That may have changed, but I also couldn't see an option for that in the setup dialogs.

pivpn add always creates a certificate protected with a password, optionally without password. Login with username + password in not implemented by pivpn but that link suggests some ways to accomplish that. You can set client-cert-not-required if you actually want to use username + password and not username + password + client certificate.

--client-cert-not-required is deprecated, use --verify-client-cert none

Couldn't start pivpn with client-cert-not-required or verify-client-cert none in /etc/openvpn/server.conf. pivpn ovpn -d logged that lines as an invalid configuration.
Do I do something wrong here? Without that connections with Cert work.

You need to add an authentication method as described in the resource posted.

Closing as unrelated and inactive, but may be useful for some user, so will add the information badge


Default settings of registration display

Adjust grayscales of both moving/fixed images to resemble each other
Make brain mask checkable
Dialog to set collimator size
graywindow slider(s) for all images

done, closing.


Fix country note list ordering

Description
As per title. Changed from comparing note contents, to actual added order.
Fixes #
Testing
Added and deleted some country notes.
Remarks
NIL.

Manually tested country note add and country note delete, seems to be working as expected. So just to check, a country note will first be sorted by country code, then insertion order right?

@raysonkoh yup correct


Minimal miri changes for rustc permissive provenance

Simple no-op changes to adapt to new API surface.

Once https://github.com/rust-lang/rust/pull/95826 lands, please rebase this and edit the rust-version file so CI picks up the new rustc. :)

Thanks! :-)
@bors r+

:pushpin: Commit f8478df6dcdf92192f0df550145283673c494a73 has been approved by RalfJung

:hourglass: Testing commit f8478df6dcdf92192f0df550145283673c494a73 with merge 90d28eada18e19cde2764d360d72da0cf72c9694...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 90d28eada18e19cde2764d360d72da0cf72c9694 to master...


Subsetting

In the README you state how many times faster otfcc is than ttx; fontTools also provides a subsetter, and I wonder if otfcc might also provide a subsetter :)

I think subsetting is more like a high-level application rather than a feature could be integrated into OTFCC.


Adds ability to set MIDI channel

Hey, @levosos! Tell me, if this looks good to you, and I'll then update use examples.
/ Gonna test this solution right now. Maybe will fix something on the way.
Changes to API:
// was
midier::midi::play(note);

// became
midier::midi::play(note, 1); // channel setting

This PR follows discussion started in #11

Hey @damirka and thanks for the PR!
This looks good! Let's keep a default value of 0 for channel to not break the previous API.
This could easily be done just by adding int channel = 0 in the header file (midi.h).
For example here.