Account Constraints affect stack size usage

I wasnt sure if this is a bug or an intended feature.
Problem:
Faced with large stack variables i tried boxing it but still to no avail, i randomly removed constraints and saw a good % reduction in stack offset size , which made me experiment by adding and removing constraints and seeing there effect, i dont understand why does adding constraints affect stack size ? since even if i comment out the handler function stack size does not get affected so why is it specifically constraints affect stack size ?

@acheroncrypto  hoping you would have some insight, since it puzzles me as to when i add    let test: [i32; 1024] = [0; 1024]; inside the handler function it dsnt cause the stack offset size to increase but constraints do ?

Constraints are essentially macros that expand to more Rust code. Some constraints result in a lot of code (e.g. init), which means you can easily go over the limit of the current stack frame if you use many constraints.

@acheroncrypto hoping you would have some insight, since it puzzles me as to when i add  let test: [i32; 1024] = [0; 1024]; inside the handler function it dsnt cause the stack offset size to increase but constraints do ?

That's because the Rust compiler strips out any code that's not being used in the resulting binary. Also, sometimes you don't event get stack offset warnings on builds, but you get memory access errors in runtime instead.

Btw i dont think there is but on the offchance am wrong, does there exist a way to log stack usage to enable easier experimentation, since the solution to my solutions seems manually handrolling some of the stuff anchor codegen is doing in anchor derive accounts.

@acheroncrypto  i dont remeber where i read this, but i remember armani recommending composite structs i.e seperate it into multiple derive accounts and embed into a final derive accounts , it was quite back not sure if the internal codegen then uses seperate functions to circumvent this issue.

Closing this in favour  of #2920 , anyone who comes across this issue, if you want to use anchor, one possible  solution is to use composite structs.


Add delete game action

This would help me - I accidentally published two different copies of Go. I retitled one to Abstract Sandbox so it doesn't look as bad :)

In the meantime, you can make it private by unchecking the publish checkbox and save the game again if you want ;-)

Ah great, I did not even think of that! Thanks.

From: Jérémie Pardou-Piquemal<EMAIL_ADDRESS>Sent: Wednesday, March 3, 2021 3:03 PM
To: jrmi/airboardgame<EMAIL_ADDRESS>Cc: dudefaceguy<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [jrmi/airboardgame] Add delete game action (#251)
In the meantime, you can make it private by unchecking the publish checkbox and save the game again if you want ;-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/jrmi/airboardgame/issues/251#issuecomment-790018591, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATAYYGPPM4LPH4OYKKGI34TTB2IZTANCNFSM4X4IYICQ.


Behind a Reverse Proxy (NginxProxyManager)

I'm having issues getting this running behind NginxProxyManager..
I have it set up with SSL to link.domain.co.uk
if i visit that URL then i get nothing.. however if i append /login to the end i get the login page.. but when i log in i then get a "Not Found" page..

I can't really help with this, and it seems no one from the community can provide feedback. Closing.

stuck in the same boat!
Anybody had luck with nginx proxy manager?
Documentation is horrible

stuck in the same boat!
Anybody had luck with nginx proxy manager?
Documentation is horrible

And it was just a slow dns-update problem -_-


doc: Add the missing action argument to function call

Contributor checklist

[ ] Bug fixes include regression tests
[ ] Features include unit/acceptance tests

Fixes the documentation as specified in issue https://github.com/ash-project/ash_phoenix/issues/61

🚀 Thank you for your contribution! 🚀


Idempotence test fails while using custom docker

Issue Type

Bug report

Molecule and Ansible details
ansible --version && molecule --version

ansible 2.7.2
config file = None
configured module search path = [u'/home/sayed/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/sayed/ultra_patch/docker-hive-database/py2.7-venv/local/lib/python2.7/site-packages/ansible
executable location = /home/sayed/ultra_patch/docker-hive-database/py2.7-venv/bin/ansible
python version = 2.7.12 (default, Nov 12 2018, 14:36:49) [GCC 5.4.0 20160609]
molecule, version 2.19.0
Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used:
Desired Behavior
All the test cases should be passed
Please give some details of the feature being requested or what
should happen if providing a bug report.
Actual Behaviour
I created a custom docker, named - custom-docker to work with the molecule. Inside the docker Hive is setup and is accessible via Beeline. I wrote the testcase to access the Hive in the docker image and the test case passes.
Next, I created a playbook tasks as follows
---
- name: Create Hive database
  hive_database:
    name: "{{ database_name }}"
    ensure: present

Where the hive_database (I can't enclose full source code) tasks looks something like below.
#!/usr/bin/env bash
function create_database {
    beeline -u jdbc:hive2://localhost:10000 --silent=true --showHeader=false --outputformat=csv2 -e "show databases" | grep ${name}

    if [[ $? -eq 0 ]]; then
        changed="false"
        message="Database $name already exists"
    else
        beeline -u jdbc:hive2://localhost:10000 --silent=true --showHeader=false --outputformat=csv2 -e "create database $name"
        changed="true"
        message="Database $name created"
    fi
}
...
...
...

Now when I run molecule test it only shows the below error:
ERROR: Idempotence test failed because of the following tasks:
* [custom-docker] => hive-database : Create Hive database

Have you tried running your role in a virtual machine? Sometimes, the behaviour in a vm and in a container aren't the same, so that might be a cause. If the role is still not idempotent, maybe the module itself is at fault. I've had issues with the iptables module. I would run it a few time without any changes, but it would always show changed, even tough I just added the same rule a few second ago... I'm no expert, but I'm not sure the error is from molecule itself.

hy alex! thanks... actually it was an issue with the module that I came across later! it is now working fine. I actually forgot to close the issue though.


Autodetect environment

When starting up conda-manager as a standalone app, the environment is set to root even if I start up conda-manager from another environment. It would be nice to be able to auto-detect the environment, and also optionally to allow the user to change environment.

Hi @astrofrog, sure, will change this. This codebase was a bit abandoned for a while, so I need to do a big code refactor


Add grouped response code stat, e.g. 5xx

Merged here: https://github.com/mergermarket/node-connect-datadog/commit/16b86392bf5e929c3bc091ed0a6fa8b9ff166295


Possible fix for Call to undefined function imap_open()

Info:

Docker version ($ docker --version): Docker version 17.11.0-ce, build 1caf76c
Laradock commit ($ git rev-parse HEAD): c3715165b6f55dd04b11e5f2d8344be60c5d6f56
System info (Mac, PC, Linux): Linux
System info disto/version: Ubuntu 17.10

Issue:
imap functions are not available, even with WORKSPACE_INSTALL_IMAP=true

Expected behavior:
imap functions should be available

Reproduce:
To check if IMAP is working:
Try to use imap_open() function, or use this snippet to check if it is available.
if (function_exists('imap_open')) {
    echo "IMAP functions are available.
\n";
} else {
    echo "IMAP functions are not available.
\n";
}

Possible fix
edit: modifying laravel.ini is not necessary
Add this to php-fpm/laravel.ini
extension=imap.so
Add this to PHP-FPM Dockerfile. (tested with Dockerfile-71, added just before Final Touch)
RUN apt-get update && \
    apt-get install -y libc-client-dev libkrb5-dev && \
    rm -r /var/lib/apt/lists/* && \
    docker-php-ext-configure imap --with-kerberos --with-imap-ssl && \
    docker-php-ext-install imap

Relevant Code:
I took the snippets (and modified them) from here: http://fixwins.com/getAnswers.php?Problem-Resolved=7182&q=+Call+to+undefined+function+imap_open()+in+LaraDock+
Note
Could someone else confirm this is also working? I will try to make a pull request with the needed ENV variables and docker-compose args.

Attempted to call function "imap_open" from namespace xxx
We found a solution:
I cant explain how this fixes the problem but it did seem to.
despite PHP reporting that imap extension is installed and me confirming it works by running a test script in the browser it wasnt working on the command line. So,basically reinstalled imap and dependancy php-curl
sudo apt install php-imap
463  sudo phpenmod imap
464  sudo apt update
465  sudo apt
467  sudo apt upgrade -y
468  sudo reboot
469  sudo apt update
470  sudo apt upgrade
471  sudo apt autoremove
472  sudo reboot
477  sudo add-apt-repository ppa:ondrej/php
478  sudo apt-get update
479  sudo apt-get install php-curl

thanks for your help and advice


Solr 5.3 Refactor Breaks testTagStreaming

In the test testTagStreaming the document response has changed due to SOLR-7662. Per the comments in SOLR-7662, "javabin returns the primitive types of the fields while the text based writers return a IndexableField/StorableFIeld depends on whether you are in branch 5x or trunk".
The change results in the field values being returned with the following call as IndexableField/StorableField instead of the expected primitive value.
 assertEquals("Boston", refDoc.get().getFieldValue("name"));

How do you suggest adjusting for this?
I think this is the last bug for getting 5.3.1 working.

Looks like you fixed it.  The fix looks fine.  Can you please send one pull request with all these changes for 5.3.1?  Don't worry about bumping the version of the project in the POM.

Cool. I don't like changing tests unless it's necessary. Seemed like the case this time. Thanks for the consult!


The only images that are not affected this behavior are the following:

mcr.microsoft.com/dotnet/framework/wcf:4.7.1-windowsservercore-ltsc2016
mcr.microsoft.com/dotnet/framework/wcf:4.7.2-windowsservercore-ltsc2016

All other WCF images need to be addressed.

The WCF images are based on the ASP.NET images.  The assemblies listed appear to be the same as reported in https://github.com/microsoft/dotnet-framework-docker/issues/406 (e.g. they are coming from the base ASP.NET image).   Have you verified if there are any WCF specific assemblies that need to be ngen'd?  I am wondering if this is a dup of https://github.com/microsoft/dotnet-framework-docker/issues/406?

Ah, yep.  Wasn't thinking.  I've verified they have an identical list of files.


fix: Added Retry Button

Fixes #1174
Changes: Replaced existing textview with Retry button.
Button is more prominent than text in this case.
Screenshots for the change:
Before:-

After:-

Flat button is not material design. I think the before version looks better


Allow Helm create starters option to use paths

Currently starters can only be located in $HELM_HOME. Added the functionality to check for the path incase the starter doesn't exist in $HELM_HOME. This maintains backward compatibility and allows to use custom locations for starter charts.

Can anyone review this please?


allow for files to not be downloaded as a parameter

This is important because HTAN has terabytes of files... service catalog only supports 1TB...

@adamjtaylor Theres a couple of options here actually.  To fast track this, I'm going to set the default to False and add a syn.get command in the class for those that want to download the file.


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
e143de9 -> 492caa7

github.com/IBM/platform-services-go-sdk
require
patch
v0.54.0 -> v0.54.1

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.25.0 -> v1.25.1

Release Notes

IBM/platform-services-go-sdk (github.com/IBM/platform-services-go-sdk)
v0.54.1
Compare Source
Bug Fixes

Global Tagging: regenerate service using latest API definition (#289) (b44bea3)

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.25.1
Compare Source
Bug Fixes

deps: update gomod (#704) (b5574c4)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Is it possible to add infinite loading on this without causing layout to shuffle when items are appended?

Did you find a solution for this?


Add Azure Data Studio and Azure IoT Explorer

Add the additional two applications mentioned in the title. Both had their shortcuts removed as part of the ASR malfunction.

@snympi , I've been making my own custom script that does a better deep dive into recreating the shortcuts.
I've add the applications mentioned here, and it should work.
Script is located at: https://github.com/TheAlienDrew/OS-Scripts/blob/master/Windows/Microsoft-Endpoint-Defender/Recreate-Base-Shortcuts.ps1


Update to Swift Argument Parser 1.1.0

Landing while CI is disabled since arg parser 1.1.0 uses swift async and that requires macOS 12, which GitHub actions does not support at this time.


Edges can become misaligned with handles

As seen above. It seems to happen more frequently when switching tabs or between Windows, as well as when dragging around the canvas a lot.
Not sure if this is the case, but I think it's also more likely to happen when saving the react file and react performs an in-place reload via the websocket.

I will close this in favour of #1075 . Unfortunately I am still not able to reproduce this. Which browser are you using?


Environment isn't respected in Angular SPA template

Describe the bug
Running Angular spa template with dotnet run -c Release still runs the app in development mode
To Reproduce

dotnet new angular
dotnet run -c Release

Expected

The app runs in production mode

Actual

The hosting environment is still set to development

Note: It works fine when publishing and running with dotnet publish -c Release
Sdk version 3.0.100
@ryanbrandenburg, please add more details if I missed anything

So, it doesn't respect it because of https://github.com/aspnet/AspNetCore/blob/master/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/Angular-CSharp/Properties/launchSettings.json#L31, but if you remove that line then you have the problem that running dotnet run -c Release doesn't actually work, it demands that you do dotnet publich -c Release and then run the exe. That's not an ideal experience, but it might not be a small change to fix, and no customers have complained yet.

release/debug != production/development. They are orthogonal.
The reason this happens is because you are doing "dotnet run" and that picks up the environment from launchSettings.json, that behavior is expected.
You can run your "Release" app in "Development" and your "Debug" app in "Production".


Set default tenant

I have three tenants and I want them to be displayed in a specific order in tenants tab. Even though I have set up opendistro_security.multitenancy.tenants.preferred: ["C", "B", "A"] in kibana.yml but I still see them alphabetically ordered in tenants tab and A is selected by default. Please assist.

Same issue How I can change the default tenant in the user.

I too would like to know how to set the default Tenant.
Currently trying a workaround using ?security_tenant= in URL, but when using OpenID Connect, the URL redirects causes the URL parameter to not be preserved through the authentication process

Being able to set a default tenant would be very useful, for our use case we have many shared dashboards and visualisations in the Global tenant, when users first login they're defaulted to Private tenant with no dashboards - a confusing user experience.

We're also looking at the same solution.
When users log in to Kibana they see default tenant as Private.
When we wanted to share the dashboards they can't see any data

It is a very helpful feature will be. Without this feature using multi-tenancy is inconvenient now.

Same here, is this still an open issue or was there a resolution for this?

+1

+1

+1

+1

+1

+1

@singlash26 Putting only one tenant in opendistro_security.multitenancy.tenants.preferred: ["tenant_name"] works, but it seems that the manually created tenant's name should be in lowercase letters. The Global worked as default by just removing Private.

It would be nice if users could defined themselves which tenant they would like to use by default. It is quite annoying that one needs to pick a tenant every time one logs in. It would be cool if there would be a "remember my choice" button/checkmark when choosing the tenant.

+1

+1

I also have this issue and would appreciate a fix, it´s quite anoying

+1

Hi
Can you please share an example of how a user can create saved objects in a shared tenant space using kibana APIs?
Let's say user A creates an index pattern in a given tenant space A and user B sharing the same tenant space A sees the same index pattern?
Thanks

Hi
Can you please share an example of how a user can create saved objects in a shared tenant space using kibana APIs?
Let's say user A creates an index pattern in a given tenant space A and user B sharing the same tenant space A sees the same index pattern?


Use new FrontPress logo in readme file

FrontPress has a new logo made before #70.
This logo should be placed in top of readme file.
Also this organization image should be replaced by the new logo by Adriano Arruda.

All logo versions ready for web.


Windows detect thinkpad as macbookpro

Thanks for your work.
Can’t use Lenovo vantage app or update bios because this problem.

That's totally normal, you can press F12 and choose windows when you need to update bios.


Enable code coverage

Fixes #6009.
Description
Code coverage was disabled via https://github.com/apache/incubator-druid/pull/3122 due to an issue with
cobertura in Travis CI. Switch code coverage tool from cobertura to
jacoco to avoid issue and re-enable coveralls for Travis CI.

This PR has:

[x] been self-reviewed.

In https://github.com/apache/incubator-druid/pull/8359 coverage build failed due to drop by 0.09% (report says coverage of files not touched in the PR dropped)
also in any case, do we really want to fail the overall build on code coverage drop of 0.09% .
@clintropolis @gianm
while code coverage is an interesting metric , I don't think it is a metric to chase for and fail the builds.

@himanshug I'm hoping https://github.com/apache/incubator-druid/pull/8374 will fix the issue with the fluctuating coverage reports


about clone directory

Hi,
In section "build image locally", i was confused about the ros rpository. Does that mean my ros installation directory or my workspace? or docker installation directory

Using docker-ros, you can containerize any ROS package or set of packages. The ros repository refers to a directory containing the source code for the packages you wish to containerize. Usually this is a Git repository, hence the term repository, but it doesn't need to be.
If you wish to containerize an entire ROS workspace, the ros repository would refer to your ws/src directory that is containing all of your packages.

ok gotcha, thx


Refactor WorkBench

There's a large number of issues with Liquid's service locator, WorkBench:

It's static, which forbids a number of good OOP practices such as inheritance; It also makes testing very difficult (#74) because, once you exercise it, you can no longer change anything. It's also vulnerable to thread-safety issues because every thread will access the same data (although, I must admit, this is unlikely, since you should load instances only at application startup - after that you only read from it).

It's a glorified static dictionary. The whole interface is about restricting what can be loaded into it, which is something that the dictionary would do natively (minus the protection over setting something twice, which I wonder if it is really helpful...). The only thing that matters is that it will call Initialize on a service on the first read, which is a good feature.

It restricts what can be used as a service.

It violates SOLID in every manner I can think, well, besides SRP.

I think a redesign is in order.

Another thing to add is the enum that defines the possible services. Well, the enum doesn't prevent us from doing a mismatch.
Take a look, for instance, here, AddToCache:
https://github.com/Avanade/Liquid-Application-Framework/blob/72349eace2d177d8f722aaea9c42584475d53504/src/Liquid.Base/WorkBench.cs#L50
What prevents us from, let's say:
ILightRepository repo = null;
AddToCache(WorkBenchServiceType.Event, repo)

Nothing (also, nothing prevents us to insert a null there, since null checking isn't done).
So this shouldn't be a public interface if we want to actually restrict what a user can insert there. But then again, this is just because #39, right? We shouldn't be really restricting stuff this way.
And this flaw happens here as well:
https://github.com/Avanade/Liquid-Application-Framework/blob/f2b5da239bd9f411386344053989609abcb4f1ce/src/Liquid.Base/HealthCheck/LightHealth .cs#L73
Inside this code, there's a (T)service, a code that can very easily fail.
So, one more vote to remove this class once and for all.


Using long labels increases the distance form the label to the arrow

When labeling a vertical arrow the text distances itself from the arrow it is attached to.
This issue is relatively new.

Illustration:

Link

Good catch everyone! @Isomorphisme Do you have any idea what's going on? Otherwise, I will take a look this weekend.

Ups, it seems I broke something in the process. I quickly checked and it appears that getting rid of the 'heightDiff' parts fixes the problem. To be honest, I did not really understand this parameter but it looked like it was not doing anything.

I think I broke something because I don't understand what the 'heightDiff' is. It seems that deleting this little part solves the issue though. I do not have a lot of time to test, but if someone wants, I think that something along the lines of https://github.com/Isomorphisme/tikzcd-editor/commit/52b6c7e81ddb4ac0fcb14742c1bd5943d0b45e69 should work.

Took me a while to figure out what I wrote, but I think I finally got the correct computations... 😅


History for multiple days

This is a feature request. Also I was wanting some ideas on how to go about doing this. I would like the ability to configure the amount of history each component displays in the frontend.
The reason I would like this feature, is because I have a sensor that reports a state change once per day. This results in a graph that looks like the below. I would like to have up to a year of data on this sensor.

I have briefly looked at the history component and was able to return a couple days of history to the frontend. However the days overlay each other because it is based on time. I am also not sure how to get the config variable from a particular sensor when in the history.py code?
Would this be useful for anyone else? Some more examples?

I would also like to see some improvements in graphs:

graphs are too small in the info dialog (on desktop).
in history, sensors are grouped for the same unit_of_measurement... the temperature scale of my water heater is very different of my outside temperature, making the graphs useless.
24h time series is not always the best view for a sensor... maybe adding some buttons on top to show most common views: 1h, 12h. 24h, 1 week, 1 month, 1 year.
history takes some time to load (when DB grows significantly in my RPi2)... it would be nice to choose what sensors to see in history by default, and dynamically load others on request.
would be nice to choose the history DB engine (add platforms for history component and make sqlite3 the default)

I know some are not trivial to implement, but please considered these in next related developments.
Thanks

I would also like to weigh in on this subject:

I would also love to see more days in the graphs
the graphs are too big when opening the info view of a sensor when holding your iphone in landscape, you can't see the other attributes anymore

Op 15 feb. 2016 om 17:28 heeft sfam<EMAIL_ADDRESS>het volgende geschreven:
I would also like to see some improvements in graphs:
graphs are too small in the info dialog (on desktop).
in history, sensors are grouped for the same unit_of_measurement... the temperature scale of my water heater is very different of my outside temperature, making the graphs useless.
24h time series is not always the best view for a sensor... maybe adding some buttons on top to show most common views: 1h, 12h. 24h, 1 week, 1 month, 1 year.
history takes some time to load (when DB grows significantly in my RPi2)... it would be nice to choose what sensors to see in history by default, and dynamically load others on request.
would be nice to choose the history DB engine (add platforms for history component and make sqlite3 the default)
I know some are not trivial to implement, but please considered these in next related developments.
Thanks
—
Reply to this email directly or view it on GitHub.

I would like to see this feature too.  Until then, it does seem easy to dump the data from home-assistant.db and plot it on your own.  For instance
select datetime(created, 'unixepoch', 'localtime') as time, state from states where entity_id='sensor.YOUR_SENSOR_HERE' order by time;

Going to go ahead and close this since it isn't a bug. Opened a feature request in the forum. https://community.home-assistant.io/t/configurable-history-graphs-display-days-weeks-months-of-data/7301


right_sidebar: Remove realm description for spectators.

This commit removes the realm rendered description from the right sidebar for spectators.

Fixes: #30322

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "buddy review"

@pratik-pc This is a quick one

Seems pretty straight forward and does the work!
On an additional note, is initializing realm_rendered_description needed now?

@zulipbot remove "buddy review"

Yeah, you should be able to pull that out of web/src/sidebar_ui.ts.

Done!

@zulipbot add "mentor review"

@alya This seems too small to go through all the stages.

@zulipbot remove "mentor review"

@zulipbot add "maintainer review"

Merged, thanks @kuv2707!


Added connection monitor that polls the socket to see if the client lost the connection.

Polling is done same way as IsConnected in https://github.com/aquamoth/SocketMessaging/blob/master/SocketMessaging/Connection.cs

Hi @microm8 thanks for contributing this!  By chance have you tested on each of the various frameworks?  Nice work, it looks very clean and easy to understand!

I didn't think of the various frameworks. I have tested in a .NET 6 application and ran the unit tests...

Code source: https://stackoverflow.com/a/6993334/6097503

Hi Tino, the code snippet can be found multiple places. I have not idea who the original author is. As mentioned I found it here:
https://github.com/aquamoth/SocketMessaging/blob/master/SocketMessaging/Connection.cs

Thank you @microm8 - just merged and published to NuGet!  https://www.nuget.org/packages/SuperSimpleTcp/<IP_ADDRESS>
Also added you to the README.  Thank you for your contribution!


Dispatcher deadlock workaround

Details on https://github.com/IntelRealSense/librealsense/issues/10482
Stopping _device_watcher before unregistering callbacks.

Hi,
I have the same issue using two cameras, ROS and the initial_reset, I can reproduce it consistently by launching the ROS node before plugging the camera. This fix resolve the issue but prevent recovery of unplugged cameras... Adding a delay in the ROS wrapper just after the hardware reset seems to resolve the issue, but it's not a real fix.
Does someone has a better solution ?

Hi @Milnaye , could you please give more details about your test scenario?

I have the same issue using two cameras, ROS and the initial_reset, I can reproduce it consistently by launching the ROS node before plugging the camera. This fix resolve the issue but prevent recovery of unplugged cameras...

By this I assume, you have one camera always connected and the another camera is connected after calling the launch command. Please correct me if I'm wrong.
For which camera are you trying to do 'initial_reset'? The one which is already connected or the one you are connecting after calling launch command or for both?

Hi @Milnaye , could you please give more details about your test scenario?

I have the same issue using two cameras, ROS and the initial_reset, I can reproduce it consistently by launching the ROS node before plugging the camera. This fix resolve the issue but prevent recovery of unplugged cameras...

By this I assume, you have one camera always connected and the another camera is connected after calling the launch command. Please correct me if I'm wrong.
For which camera are you trying to do 'initial_reset'? The one which is already connected or the one you are connecting after calling launch command or for both?

Hi @Arun-Prasad-V,
After reading again what i wrote, i can understand that I wasn't clear at all...
On our robot, the two cameras stay connected all the time, the issue happens only on the second camera checked by the ros node.
To explain more, on the robot we use two ros nodes, we force the serial number of the two cameras so we know where they are, the ros nodes loop between the cameras and always start checking the "camera A" then "camera B". The issue happens only with the node "B", after resetting "camera B". We do an initial reset on both cameras.
I'm able to consistently reproduce the issue on a computer with only one camera, by lauching the ros node before plugging the camera. It happen only with initial_reset to true.
I hope it makes more sense now :)

@Milnaye , Thanks for the details. I'm able to reproduce scenario_1 with and without ROS2 wrapper, which also matches with @v-lopez 's observation. Will work on the solution and update.

@Milnaye , @v-lopez , This issue has been fixed in the 'development' branch. Please refer https://github.com/IntelRealSense/librealsense/issues/10482#issuecomment-1778512428.
Please try and let us know if you need any further help.


Upgrade icons to have color and actually be themed

The icons in the storage extension have always REALLY bothered me, so I went ahead and fixed them. Copied the svgs from Storage Explorer and used Cherry's icon gulp tasks to make them work for VS Code.
Also I didn't think all of the README screenshots were necessary, so I deleted all but one when I was updating. Let me know if you disagree.
Before:

After:

Fixes https://github.com/Microsoft/vscode-azurestorage/issues/6

Uh I did delete the old images?
But actually you reminded me that I can't delete images referenced in the README. The VS Code marketplace links directly to our master branch on GitHub for images and so we have to keep them until the next release. Added them back.

Sigh.


404 when speaking to private registry

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Using
sources:
  registry:
    kind: dockerDigest
    spec:
      image: "registry.concernedturtle.com/btrepp/blog"
      architecture: arm64
      username: beau
      password: gibberish

With
updatecli diff --debug

Gives
SOURCES
=======

registry
--------
DEBUG: Searching digest for the image "registry.concernedturtle.com/btrepp/blog" with the tag ""
DEBUG: Retrieving a bearer token from https://registry.concernedturtle.com/token?scope=repository:btrepp/blog:pull&service=registry.concernedturtle.com with the username beau and the associated password.
DEBUG: Emitting a request to https://registry.concernedturtle.com/token?scope=repository:btrepp/blog:pull&service=registry.concernedturtle.com
ERROR: Got an HTTP response code 404 while logging in to the registry registry.concernedturtle.com.
ERROR: ✗ Got an HTTP response code 404 while logging in to the registry registry.concernedturtle.com.
Pipeline "UPDATECLI.YAML" failed
Skipping due to:
       "sources stage:\t\"Got an HTTP response code 404 while logging in to the registry registry.concernedturtle.com.\""
sources stage:  "Got an HTTP response code 404 while logging in to the registry registry.concernedturtle.com."

and logs on the registry
<IP_ADDRESS> - - [21/Mar/2022:10:27:39 +0000] "GET /token?scope=repository:btrepp/blog:pull&service=registry.concernedturtle.com HTTP/1.1" 404 19 "" "Go-http-client/2.0"

Expected Behavior
Update cli connects to the registry with correct password.
Or in the case of that incorrect password above gives 401 instead of 404.
Note it gives 404 with both correct and incorrect passwords.
Steps To Reproduce
See above expected output
Environment
- OS:

uname -a
Linux beau-pc 5.16.11-1-MANJARO-ARM #1 SMP PREEMPT Wed Feb 23 12:30:41 UTC 2022 aarch64 GNU/Linux

updatecli:

updatecli version

VERSION

Application:    0.22.2
Golang     :    1.17.8 linux/amd64
Build Time :    2022-03-20T18:54:44Z

Anything else?
It would be great if the credentials for registrys could be pulled from
~/.docker/config.json

This would help in troubleshooting a fair bit, as if you can login with docker cli, that means your auth would be setup. I'm not 100% clear if I should use username/password, or token with the base64 encoding in the config.json file.
I am also not sure if this may be a feature request?. As private registries may not be supported.

Hello @btrepp thanks for reporting. This is definitively a feature request (and not a bug) as we never tried a local private registry: it needs a bit of discussion to ensure that we shape the specification. I'm changing the labelling of the issue.

Lets discuss :)
A few elements about how the docker registries usually handle the bearer token authentication:

The usage of username + password is mandatory. You might see the concept of a "token" in SaaS hosted registries such as the DockerHub: in these case you specify the token as "password": I'll refer to this token as an "API token".

We might need to ensure that the documentation of updatecli helps the end users.

As per the Docker Registry v2 API, the "bearer" token is supported: https://docs.docker.com/registry/spec/auth/token/

This "bearer token" is generated from a first HTTP request to the authentication endpoint with the username + password (or username + API token), which responds a "bearer token" to be used for later authentications. Please note that the bearer token has an expiration date (while the API token does not, like a password).
Then, for any subsequent request to the registry itself, the bearer token is provided (instead of username + password) to authenticate these request. The registry would use the authentication service as a "3rd party" to validate the authenticity of the bearer token.

In you case @btrepp , the "HTTP/404"  error is because there isn't any authentication service that would provide a bearer token: authentication is managed directly with (username + password) by your registry, out of the box:

You correctly configured updatecli! And it should stay the same configuration for at least username password
There is no such thing as an API token in your case
I'm not sure about the role of tokens found in ~/.docker/config.json. Can you check (without sharing its content of course, or anonymized) if the tokens aren't related to another registry such as dockerhub?

To implement support for a private registry, we need to think about a way to sepcify, in the YAML manifest, that there should not be any "authentication endpoint" (named "token endpoint" in the code) + that username+password should be passed "as -it" instead of expecting a bearer token.

No worries. Figured it was most likely unsupported, but couldn't make a call if it was my config or a missing feature. So thanks for confirming, and this issue can be the documentation that it's not implemented yet for anyone else :).
One the docker config. I think this might be a seperate feature too, but it does help explain some of the situation, so will mention in this thread.
The file looks like
{
        "auths": {
                "https://index.docker.io/v1/": {
                        "auth": "REDACTED"
                },
                "registry.concernedturtle.com": {
                        "auth": "REDACTED"
                }
        }
}

I generate one for m k8s cluster here https://git.sr.ht/~btrepp/infrastructure/tree/main/item/bootstrap/playbooks/secrets/dockerconfig.json.j2
{
    "auths": {
        "registry.concernedturtle.com": {
            "auth": "{{ ('k8s1:'+registry_k8s1_pass) | b64encode }}"
        }
    }
}

So it is the username : password then base64 encoded.
This all works nicely in k8s and docker cli.
With the auth spec, I think the most confusing part, is that I am running the https://hub.docker.com/_/registry which you would think implements that specification you have linked.
Thinking deeper, perhaps it's that my basic configuration needs more switches turned on https://git.sr.ht/~btrepp/infrastructure/tree/main/item/apps/registry/deployment.yaml. I've noticed that says htpasswd as auth, perhaps I need to enable something else too.
My thinking here, is that this should be the same as the public registry, it does implement the spec.
The feature request for updatecli, might be 'support registrys that use htpasswd auth'. I think in that case, maybe an enum field, that says 'authentication_method': [TOKEN,HTPASSWD]. Might work?.
I suspect the docker tooling 'figures this out', but allowing users to specify would be a good MVP.
I will also do some research to see if I can 'turn on' the registry auth to work similar as expected. If that works, maybe no changes are needed, just update the documentation to say we need these bits turned on :).

Basic/htpassswd seems to be documented as the a good default for  private installs. The JWT token path actually is more undefined :).
https://github.com/distribution/distribution/blob/main/docs/deploying.md
I think flow wise, perhaps when getting the 404, try using Basic auth for the rest of the requests (no need to document more). I think this is probably what the docker/k8s tooling does, but maybe I can find the source code for them

As far as I understood this is issue solved in by https://github.com/updatecli/updatecli/pull/900 which was released in 0.36.0


Artifacts should have a __len__() magic method

All artifacts should have a __len__() magic method based on the content of value (similar to how we implement __bool__).
As part of this request, all instances of len(artifact.value) should be replaced with len(artifact).

@vasinov could you please assign me to it?


Update plan-hyper-v-scalability-in-windows-server.md

revised incorrect maximum memory information. from 240TB to 48TB

@devalian : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This was resolved with https://github.com/MicrosoftDocs/windowsserverdocs/commit/74c8339e52c6ec126b4d0843ba6673a00f54e65b. Should this be closed?

#assign: @robinharwood, @Xelu86
@robinharwood @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Add opt-in BitcoinXT support

I want to make this as uncontroversial as possible, so let me know if anything should be different!

Hmm ran out of memory. What now?

Don't worry about travis, it happens a lot. Other question is why you don't make a separate file? This way it might be simpler, but technically it's a different package.

Some reason why making a separate file might be better solution is that in case bitcoin-xt does not become popular somehow, and it supposedly becomes deprecated, the history of git changes will be cleaner.

Here's the branch with separate files. Think I should use it instead?
https://github.com/NixOS/nixpkgs/compare/master...jefdaj:bitcoinxt-twopackages
I originally went with the single file so it would be easy to keep them in sync, but it's not a big deal either way.

OK went ahead and added that as 9384.

OK went ahead and added that as 9384.

This appears to be superseded by #9384.


Adds aws-cfn-bootstrap to build

@eemperor This pr can be closed now right? We are continuing to install the aws-cfn-bootstrap from PyPi?


More sophisticated "latest" identification in extensions/all to prefer final releases over more recent alphas

We currently expose a list of all extensions at http://registry.quarkus.io/client/extensions/all/
Current behaviour:
Take the latest, sorting by extensionRelease.sortableVersion, implemented in SQL. At the moment, that would be 3.0.0.Alpha1.
Proposed new behaviour:
Prefer extensions in recommended releases. ie at the moment, return 2.14.1 extensions. This is partly about going for .Final versions rather than .Alpha versions, and partly about looking at recommendedStream.id and preferring extensions which are members of those streams.
Proposed new implementation:
This might be too hard to manage in SQL, so we would probably need to fetch all extensions and then do a manual function to inspect the .qualifiers and cross-reference against platform information.
Secondary question:
If the same version of an extension participates in two platforms, how do we choose which platform is 'latest'? Most likely, the names of the platforms would be different, so we can't just use a version comparison. If one is recommended that would help, but if both are neither are recommended, what do we do? This doesn't affect the version in extensions/all, but it does affect what metadata appears attached to the extension. See https://github.com/quarkusio/extensions.quarkus.io/issues/24 for more discussion of this.
Tertiary question:
Should we provide/encourage a mechanism for a new version of a platform extensions to be published in the registry, without a new platform release? If such a version did appear in the registry it would automatically appear in extensions/all, so no 'latest version identification' code change would be needed. In other words, if that's the problem we're actually trying to solve, we need to look at the extension release logic, not the version-sorting logic.

@holly-cummins for the primary question I'd suggest to take a look at how the PlatformRelease.findLatest() method is implemented: https://github.com/quarkusio/registry.quarkus.io/blob/main/src/main/java/io/quarkus/registry/app/model/PlatformRelease.java#L149
Maybe we can extract that into an utility method to make it easier to reuse


Update README on reports

Updated readme to include information about new ability to receive notifications about rules in report_regexes without having to trigger a Lemmy report

Thanks!


Add audio-only to Player

If you want to provide only the audio version of the stream, you can use ?video=false at the end of an .m3u8 URL to get an audio-only stream. For example, https://livepeercdn.com/hls/{playbackId}/index.m3u8?video=none

Put in New Issues for sizing. This work currently blocks The Lot Radio.


Make use of local routing service

Change the routing backend server from the official server to the local instance to match the quick starter guide (https://github.com/Project-OSRM/osrm-backend#using-docker). This was accidentally (?) changed in this commit (a9b7e5381a74260cdaf5237c6d4cc4c2bb6e7bfc) without given reason.

LGTM - our docs and code should be in sync now, thanks!


workflows/tests: enable concurrency limiting.

Let's cancel in-progress builds on the same PR.

Review period skipped due to critical label.


Chat - User is not navigated to last open chat from staging.new.expensify.com/r/

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/22260
Action Performed:

Go to staging.new.expensify.com
Switch between different chats.
Navigate to staging.new.expensify.com/r/

Expected Result:
User is navigated to the last open chat
Actual Result:
User is occasionally not navigated to the last open chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/8a4e8570-b5a0-41db-a5c6-8660894ee2b9
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

I was able to recreate this, so going to get eyes on it, in line with the linked GH above

Not overdue — just waiting on proposals

@kameshwarnayak any updates?

I am also having a heck of a time recreating this now. @lanitochka17 can you confirm that you're still experiencing this?

@kameshwarnayak any updates on this?

I am unable to reproduce this @lanitochka17 do we have any better reproduction steps?

@lanitochka17 bump on @mananjadhav's comment above ^^^

Issue not reproducible during KI retests. (First week)

^^ I think we can close this!


Improve modelling of match strategies to use in numeric range search.

This should improve the performance by choosing the strategy that is most optimal in different scenarios: lookup-based filter matching vs posting lists merging.
The modelling is based on results from the range search performance test: https://github.com/vespa-engine/system-test/blob/master/tests/performance/range_search/.
@baldersheim please review
@toregge FYI

@baldersheim PTAL


Error on development when changing baseUrl

Is this a bug report?
Yes

Have you read the Contributing Guidelines on issues?
Yes
Environment
Node: 8.9.1
Docusaurus: 1.1.1
(Docusaurus version via npm outdated docusaurus or yarn outdated docusaurus, OS, Node, npm, yarn)
Steps to Reproduce

I followed the step on setting your landing page: Docs landing Page. Which works well. However, the problem is when you change your baseUrl for deployment:
const siteConfig = {
  title: '<Project title>' /* title for your website */,
  tagline: '<Project tagline>',
  url: 'https://<org>.github.io' /* your website url */,
  baseUrl: '/<project>/' /* base url for your project */,
  // For github.io type URLs, you would set the url and baseUrl like:
  //   url: 'https://facebook.github.io',
  //   baseUrl: '/test-site/',

It works on build, but when I try to yarn start it gives me an error:

If I put back the baseUrl: '/' it will work.
Workaround: make baseUrl: '/' when updating the doc and put back the baseUrl: '/project/' url when done.
Expected Behavior

It should redirect to my doc page  as expected without switching baseUrl for development and production

@joshuaalpuerto: hi, do you have a repo we can clone to reproduce the issue?

@endiliey
Sorry didn't provide a repro. Here is the repro, hope this help.
https://github.com/joshuaalpuerto/repro-docusaurus
Cheers!

If someone can guide me. I would like to contribute :)

yarn start or npm start basically use Express to serve the files.
You can check
https://github.com/facebook/Docusaurus/blob/master/lib/server/server.js

Thanks! I will take a look on this.

hi @joshuaalpuerto, did you manage to resolve the issue ?
Sorry for the delayed response. I just got the chance to try your repo and I think there is no issue with the current server implementation.
When you change your baseUrl to /project1/, this means that instead of localhost:3000, you should access it at localhost:3000/project1

@endiliey  No worries! I was able to take a look at it yesterday for a limited time. But you are correct, it is accessible by adding the baseUrl. But shouldn't be automatic when redirecting to to the docs page as per documentation. Perhaps the baseUrl should be automatically added. What do you think?

Actually this only happen when we use static index.html, you can try cloning Docusaurus repo, change baseUrl and yarn start will still work fine.
I'm not the maintainer of this repo, but that might be a good idea
Quick implementation:
const siteConfig = require(CWD + '/siteConfig.js')
const host = `http://localhost:${port}${siteConfig.baseUrl}`;

https://github.com/facebook/Docusaurus/blob/b7be85843af2a07ead183dd8a467ebcf83e9a3e3/lib/start-server.js#L65-L66

I will try this later and let you know! Thanks for your help!

Guess we can close this now

[UPDATE]
Now the issue is when you type in http://localhost:3000 you will not be redirected. Unless you type in the host and the baseUrl altogether http://localhost:3000/project1.

I think that's the right behavior. If you are using non default / as baseUrl, e.g: /project1/ then you should not access it without baseUrl or even manually type it.

thats what I actually meant when I said it should be automatically. Hmm, shouldn't it be base on your baseUrl?

Feel free to submit a PR for it 😄
Adding this for your reference on where to modify
https://github.com/facebook/Docusaurus/blob/b7be85843af2a07ead183dd8a467ebcf83e9a3e3/lib/server/server.js#L530-L533

Thanks! Im actually checking the server.js now. Then I'll get back once I figure this out. 😄

Hi @endiliey,
I was able to make changes on server.js
Adding baseUrl:
app.get(/\/[^\.]*\/?$/, (req, res) => {
     const siteConfig = require(CWD + '/siteConfig.js')
    let slash = req.path.toString().endsWith('/') ? '' : '/';
    const url = 'http://localhost:' + port + siteConfig.baseUrl + req.path + slash + 'index.html'
    request.get(
      url,
       ...

You can actually check my repro. I point the docusaurus package to my forked repo. Implement changes needed and it works. You can type in http://localhost:3000 and it will auto redirect to the baseUrl you change. Please let me know if this is something that I can PR. 😃
Cheers!

@joshuaalpuerto
I don't own this repo but I believe that this repo is PR Friendly 👍
Feel free to submit one. No PR is too small if it's useful.
I can give some advice though, that changes in your code might introduce a bug. What if my req.path is baseUrl/xxxx, it will become baseUrl/baseUrl/xxx

You're correct. I was able to test only my use-case.  I will keep on checking then. Thanks!

Hi @joshuaalpuerto, any progress on this?

Hello @endiliey, I'm trying to understand the inner workings of the routes but I got busy this past days. However, I was able to try using /project1/subproject/ for baseUrl and it seems working just fine.

Alright @joshuaalpuerto . I'm closing this issue for now as it seems it's been working for you. Feel free to submit a PR on the improved redirect when you have the time.


fix: check for valid numbers when reading a CSV file

Fixes #284
The implementation of GET DIRECT DATA and GET DIRECT CONSTANTS relies on the cdbl function to convert a CSV value into a C double literal string. Thecsv-parse package we use to read the CSV gives a number for cells with numeric values. cdbl was simply using toString to convert the number to a string. When the cell value was a string instead, cdbl would fail with an unhandled exception.
The solution follows Excel practice by trying to convert a string value to a number, with blank strings converted to zero. This is done with parseFloat. If NaN is returned, cdbl throws an exception with a helpful error message.
The equation generator for GET DIRECT DATA and GET DIRECT CONSTANTS catches the exception and issues an error message indicating the file with the bad data. This has been helpful for tracking down previously unknown bad data that Vensim ignored.
This solution does not handle every case that might come up. The JavaScript parseFloat method converts inputs such as '1ABC' to the number 1. A full solution would test for every valid Excel number format, but that would be much more complicated. We might be able to find a package that solves this problem, at the cost of introducing a dependency.
I went ahead and did a major version upgrade to the latest csv-parse package.

@ToddFincannonEI: Out of curiosity, what version of Vensim did you test with?  I tried updating the existing directconst sample model to see if we could have an automated test that covers this, but Vensim (I'm using 9.2.1) raises an error if I set a cell in a CSV file to something like ZERO or an empty string:
No number found in cell C3 (and perhaps others) of data/h.csv:,.

I pushed my changes to directconst to this branch, but we can back it out depending on the answer to the following question.
And the question is: Could we continue to treat this as a hard / fail-fast error like before, but keep your improved error messages (which are helpful for tracking down the source of the error)?  Or is there a good reason to keep it as a soft error?
I like to err on the side of failing fast for cases like this (similar to how Vensim handles it), because otherwise it's easy to overlook error messages (that aren't treated as hard errors) in the build logs.

I used Mac version 9.3.5 with EPS. I didn't try to make a simple test case, having fixed the problem in EPS.

The reason I kept it as a soft failure is so it would continue on to find other locations with bad data.

The reason I kept it as a soft failure is so it would continue on to find other locations with bad data.

OK, fair enough.  In that case, I think I'll leave my change to the directconst test case intact, and will merge this as is.  I filed a separate issue (#290) for considering a command-line flag to control whether errors like this are treated as a soft warning or hard error.  That way we don't hold up this PR and can consider the issue more broadly across SDE at a later time.


Support dict as input for add_header()

Currently i'm adding multiple headers like this:
headers = {'some_header' : 'some_value', 'more_header' : 'more_value'}
for h, v in headers.items():
   add_header(h, v)

Wouldn't it be convenient  if add_header() supported multiple headers, as name/value pairs in a dict?
(and set_header() as well)
I think this could be easily done with something like:
if type(arg) == dict:
  for name, value in arg.items():
    self._headers.setdefault(_hkey(name), []).append(_hval(value))
else:
  self._headers.setdefault(_hkey(name), []).append(_hval(value))

Am missing something or isn't there a good reason that this coudn't be implemented?

What about request.headers.update(header_dict)?

This is in fact a more elegant way of adding a dict to response.headers. Thanks for the hint!
I didn't think of this because i was too focussed on the iteration way i saw being used in BaseResponse.
However, i think this is just about convenience, right?
add_header() itself isn't really nessecary as you can easily add a header via response.headers['my_header'] = 'my_value', but it's nice to have.
Or is there any common usecase where you really need to do this with a function..?

Apart from convenience, add_header is a little bit faster for the usual use-case when you only need to add a header or two, because no HeaderDict wrapper is created. The code is inlined in this case. New users are also more likely to find add_header on the response object than diving into the HeaderDict API, and it's less typing.
So, yes, response.add_header() and friends are shortcuts for response.headers.append(). Use whatever is more convenient.

Well.. It would be nice to have the possibility to add many headers without the overhead..
But on the other hand i think that there would be a decreased performance when adding single headers with the modified version of add_header.
I let it run through timeit to see how big the differences are:
Setting:  20 headers, 1000000 repeats

Execution time for response.headers.update(): 30.032195936997596
Execution time for looping over header_dict with response.add_header(): 30.203815396002028
Execution time for looping over header_dict within response.add_header(): 27.579744362999918

Looping over header_dict with response.add_header()
for h, v in header_dict.items():
  response.add_header(h, v)

Looping over header_dict inresponse.add_header()
def add_header(self, *args):
  if type(args[0]) == dict:
    for h, v in args[0].items():
      self._headers.setdefault(_hkey(h), []).append(_hval(v))
  else:
    self._headers.setdefault(_hkey(args[0]), []).append(_hval(args[1]))

So 2nd performs a bit faster than 1st (as you said) but the real difference lies between 2nd and 3rd.
The performance drop when adding single headers:
Timeit at 1000000 repeats:
Performance of original add_header: 1.5151051540015033
Performance of add_header, modified as in 3rd example: 1.6766795939984151
At the end it comes down to noticeably better performance + convenience but in a not so common usecase vs. a bit worse performance in the common usecase.
I think common usecase wins.

It is possible to integrate type-check for the add_header(), but in this case we need to change function signature to add_header(*args, **kwargs), which is a bad idea, i think


lcc: Delete extra space or tab indent in .c file

This warnings are reported and fixed by a tool named "Hacash Robot".
reported-by: Hacash Robot<EMAIL_ADDRESS>Signed-off-by: William Dean<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.William Dean seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(tracer): Count lines, not opcodes

Before this commit, a tracing step was a jump over one opcode.
After this commit, a tracing step is a jump over one line in the source
code.
The test relevant to tracing is updated, so now the expected number of
tracing steps is less (7, instead of 14). For some reason, the test does
not print "warning: no call stack" anymore. I'm not completely sure why,
but this is a wanted improvement, so the expectation for that message is
removed.
There is a potential low-priority bug, involving function calls. A TODO
for it is added in the code.
Details
The following functions are no longer private in DebugContext:

get_call_stack
get_source_location_for_opcode_location

Although this is not ideal, it is an acceptable middle-term solution,
until common logic of the debugger and the tracer is extracted out of
the debugger.
The following functions are added to DebugContext, in order to surface
functionality of the contained debug_artifact:

get_filepath_for_location
get_line_for_location

In tracer/src/lib.rs:

the initializing logic that checks that the circuit contains opcodes
is now moved into the trace_circuit function, rather than in the
constructor for TracingContext;
debug_context is renamed to tracing_context, which matches the
type;
the error for when there is a breakpoint during tracing is promoted
to panic!, as it should never happen (indicates a serious bug if it
happens);
last_result is no longer stored in TracingContext, to keep things
purer.

Next steps
More tests need to be added to explore the error modes. When is there no
call stack? When is there no mapping from opcodes to source locations?
This is not a priority, however, so the first follow-up that is coming
is actually recording information on each step and saving it in the
tracing artifact.

Thanks for the reviews!

Did you add a Coda task for the known bug you've marked as TODO?

I did, two PR's down the line:
https://github.com/blocksense-network/noir/pull/16/files#diff-2d78c96d6e2cc619d0a384815c11a9974c360217b5c2f19f6845f3b813420b94R116

Why is this change considered beneficial though? Doesn't it create a lot of complications for the recording format for the cases where multiple program statements are written on the same line?

Well, I think working towards a change in the format would have been more appropriate than changing your implementation to align with a sub-optimal version of the format.
The logic for stepping is generally implemented on the debugger's side. The debugger could have specialized commands such as "step over a single expression" or "step over to the next line". It can implement these internally by executing a number of smaller steps until the next line is reached.


[WiP] Rename map_and_/_and_map functions

This is a proposal to get rid of some clumsy and inconsistently named functions in ValidationContext:

validate() as before
validate_with() replaces validate_and_map()
merge_result() as before
merge_result_with() replaces map_and_merge_result()

After renaming the function names with the additional map: Fn closure can easily be identified by their common suffix _with.
Roadmap
v0.1.2

Introduce new function names
Mark existing functions as deprecated in v0.2.0

v0.2.0

Remove deprecated functions

_with works better than either _from or _into.


fastai latest version(1.0.51) pin

Hi Team,
Right now fastai has version# 1.0.51, Also all the latest fastai docs based on the latest release. Is there any timeline we can have fastai version pinned with pytorch container? Right now in Pytorch container it has 1.0.39, it would be helpful if you can upgrade the latest version with this container.

Hi, thank you for using SageMaker. Can we know what is the use case that you want to use fastai version 1.0.51? And what do you need in #1.0.51 that 1.0.39 does not have?
Thanks!

Hi Team,
with 1.0.39 version the entry point script for model_fn has extra code like below:
def model_fn(model_dir):
logger.info('model_fn')
path = Path(model_dir)
print('Creating DataBunch object')
empty_data = ImageDataBunch.load_empty(path)
arch_name = os.path.splitext(os.path.split(glob.glob(f'{model_dir}/resnet*.pth')[0])[1])[0]
print(f'Model architecture is: {arch_name}')
arch = getattr(models, arch_name)
learn = create_cnn(empty_data, arch, pretrained=False).load(path/f'{arch_name}')
return learn
However with latest version( or atleast 1.0.48) it has less code and documentation in fastai course reffer the latest version. Also in the fastai site it was mention the same code which worked for latest version not for the 1.0.39 version.
loads the model into memory from disk and returns it
def model_fn(model_dir):
logger.info('model_fn')
path = Path(model_dir)
learn = load_learner(model_dir, fname='resnet50.pkl')
return learn

thanks for the clarification. Unfortunately, I can't give a specific ETA for when we'll upgrade the fastai version, but we're always reprioritizing our backlog based on customer feedback.

Thanks Lauren!. Will wait for the latest fastai version pin

I had a similar requirement so the way I made it work is by building my own container
ARG REGION=eu-west-1
ARG ARCH=gpu

# SageMaker PyTorch image
FROM<PHONE_NUMBER>38.dkr.ecr.$REGION.amazonaws.com/sagemaker-pytorch:1.0.0-$ARCH-py3

RUN python -m pip --no-cache-dir install --upgrade fastai==1.0.48
ENV LANG C.UTF-8
ENV LC_ALL C.UTF-8

Hope this works for you. I also got the above Dockerfile from here


New Feature: Agents story - Summarization/processing of Agent Chat Output

Enhancing the clarity and usability of interactions can be achieved by implementing a summarization feature for agent chat outputs.
This will help users quickly grasp the key points and outcomes of their interactions with the agents, improving overall user experience.
Ideally this should use a pluggable system trough an interface (IoC/Strategy pattern) so we could insert any implementation that matches this interface.

Related:

https://github.com/microsoft/semantic-kernel/issues/6828


Details popup window

JavaScript array to store all of the information for all projects.
Store pieces of data in a JavaScript object, at a minimum: name, description, featured image, technologies, link to live version, link to source.
Update the main page so that the projects section is created dynamically using the information stored in that JavaScript object. Remember, all of the HTML in that section is created when the page loads.
Implement the popup window.

@Olamarx Hi, thanks for the review. I have tried to center the popup window to be similar to the Figma template but struggled with it. Can you suggest how I can do it without wasting more time?


Bug/fix dy calculation

It looks like we had a font-size variable getting factored into the global text element offset rather than just the individual tspan lines.
https://github.com/FormidableLabs/victory/issues/577

This changes styling for labels:
Before:

After:

I couldn't find a working old version of this - the fontSize multiplier was put in about a year ago and it seems like the labels would have been misplaced before that. https://github.com/FormidableLabs/victory/issues/276
I think it was probably intended to only apply to the special adjustments though and not to the dy itself. I moved the multiplier into the getDy method so the labels are unchanged while custom dy values work.

@DerekMaffett much better! Approved!


IMDS retry logic should use exponential backoff.

Fixed retry logic to use exponential backoff per retry guidelines.
Added StatusGone to the list of IMDS-specific retry status codes.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:

[ ] I've tested my changes, adding unit tests if applicable.
[ ] I've added Apache 2.0 Headers to the top of any new source files.
[ ] I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
[ ] If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

Fixes https://github.com/Azure/azure-sdk-for-go/issues/1848 and https://github.com/Azure/go-autorest/issues/276


Fix positioning of search box in header

Summary (commit 1)
The site search box in the header was slightly inset from the right
edge, making alignment of other elements (e.g. the 'Sign out' link
above) look slightly jarring.
Now that said 'Sign out' link is no longer in the main header block, we
can move the search box out into a separate one-third header block,
making alignment easier. This includes a fix for the media queries that
provides a better experience for some of our middle media sizes (e.g.
tablet) - particularly in the 641px to 769px range.
Before

After

Ticket
https://trello.com/c/yHCN97l3/1035
Summary (commit 2)
The first child of the middle section of the CMS banner retained left
margin even on small screens, causing the text to get slightly inset.
This patch removes the left-margin for the first element when targeting
small screens.

@samuelhwilliams this is great, thanks!
Semi-related point: it seems weird the search box is hidden behind the button on small phone (eg iPhone 8 at 375px width wide) but not on a slightly wider phone (eg iPhone 8 Plus at 414 width)...
Maybe it should be full-width in all scenarios? (I'm not a huge fan of that toggle) Or otherwise it should collapse at the same breakpoint where the crown and the nav drops into a single column?

I'm not against removing the toggle if we don't like it, but it's a fair bit more work? I think full-width looks pretty weird on the smaller screens, when the rest of the header is bunched up on the left-hand side.

@samuelhwilliams let's postpone a review of the toggle then.


Some text is duplicated when two users concurrently make changes at the beginning of the same line

Checklist

[x] Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/
[x] Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/

Describe the bug
When using y-prosemirror, and two users make a few edits to a line at the exact same line, I sometimes see some text duplicated. (See attached video for more info).
To Reproduce
Steps to reproduce the behavior:

Have two users open a prosemirror editor (using y-prosemirror for collaborative editing)
They both place their cursors on the beginning of a line
They both make some edits
They make a second set of edits at the exact same time (the timing is a little tight)

You'll notice that one of the characters becomes duplicated.
Expected behavior
No duplication - some kind of tie-breaking logic is used to figure out which edits land on the left/right.
Screenshots
I've reproduced the issue on the y-prosemirror demo environment ( https://demos.yjs.dev/prosemirror/prosemirror.html )
https://github.com/user-attachments/assets/4b61e47a-7db0-498d-9493-9e46a832206c
I've also been able to reproduce it in other prosemirror-based environments (e.g. TipTap - https://templates.tiptap.dev )
https://github.com/user-attachments/assets/cb19950b-95f6-47b8-82c1-19ada0ee1eeb
Environment Information
I can reproduce in chrome (126.0.6478.127), as well as safari, and firefox.
Locally, I encountered this issue with:

@tiptap/core 2.5.1
y-prosemirror 1.2.9

Additional context
I've also created a pull-request here with a test case which seems to reproduce the issue - https://github.com/yjs/y-prosemirror/pull/160 ( I'm not too familiar with the y.js internals, so this might not be accurate. )
Let me know if you need any other information!

I fixed the issue and will make a new release shortly.
The issue is related to an internal cleanup function. The first concurrent edits create two Y.Text elements. The second concurrent edit triggers a cleanup function where both clients want to move the content from the second Y.Text to the first. This leads to duplication.
I fixed the issue by forcing the author of the second Y.Text to move the content directly after it notices a concurrent edit.
This will be good enough for most cases. But for change-tracking, I might need to implement a better fix.

Amazing - thank you!


Fix an issue with ALB aliases and already-deployed functions.

Description
In #1807, we introduced support for application load balancers as an event source for Zappa-driven functions. Unfortunately, that PR also introduced a bug where previously deployed services became unable to be updated with zappa update, as the code branch dealing with Lambda aliases wasn't checking for the existence of those aliases first. This PR fixes this bug two ways:
a) Check for the existence of the alias first before trying to update it. This handles the narrow case of older applications failing to deploy.
b) Only create the alias given that ALB provisioning is requested. Since we're checking to see if it exists before updating anyway, we can safely not create it in any circumstance where an ALB isn't part of the configuration.
Issues
https://github.com/Miserlou/Zappa/issues/1823

Coverage decreased (-20.1%) to 53.188% when pulling 5a83c327670e9a89702fd046be28bdb038d90fce on youcandanch:fix-0.48-issue into 992df04dad9fe77e84105156cec6ccd9cc8aebe3 on Miserlou:master.

Coverage decreased (-20.1%) to 53.188% when pulling 5a83c327670e9a89702fd046be28bdb038d90fce on youcandanch:fix-0.48-issue into 992df04dad9fe77e84105156cec6ccd9cc8aebe3 on Miserlou:master.

As far as I can tell, this is good to go. @jneves lemme know if there's anything else I should take on this.

Doing a final test run.


To evaluate (causal) models across multiple GPUs

To evaluate (causal) models across multiple GPUs, use --model hf-causal-experimental
But there is no such key hf-causal-experimental in MODEL_REGISTRY
MODEL_REGISTRY = {     "hf": gpt2.HFLM,     "hf-causal": huggingface.AutoCausalLM,     "hf-seq2seq": huggingface.AutoSeq2SeqLM,     "gpt2": gpt2.GPT2LM,     "gpt3": gpt3.GPT3LM,     "textsynth": textsynth.TextSynthLM,     "dummy": dummy.DummyLM, }

Hi, are you on the most up to date commit of the codebase? This was a recent change.

How to evaluate models across multiple GPUs, I do not see the model is distributed for multiple gpus in main.py?


added dark mode to admin dashboard

Description
Adding dark mode to Admin Dashboard
Fixes #125
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

https://user-images.githubusercontent.com/55352601/119970437-562e2e00-bfcd-11eb-9f3e-009b51fc68ce.mp4

@Akshay6890 i had added dark mode to admin dash board also .
If any page is left please let me know

@Akshay6890 i had added dark mode to admin dash board also .
If any page is left please let me know

have you checked /dashboard?

@Akshay6890 i had added dark mode to admin dash board also .
If any page is left please let me know

have you checked /dashboard?
Not yet..
I am adding dark mode to it..

But @Akshay6890 there is one problem in that page.
Thers is no navbar on top in that page...so i am adding toggle button in side navbar i hope its fine..

https://user-images.githubusercontent.com/55352601/120060449-8b8e5680-c075-11eb-8b6f-9c3c3f30055f.mp4

@Akshay6890 please review

@Akshay6890 i had added dark mode to admin dash board also .
If any page is left please let me know

have you checked /dashboard?
Not yet..
I am adding dark mode to it..

But @Akshay6890 there is one problem in that page.
Thers is no navbar on top in that page...so i am adding toggle button in side navbar i hope its fine..

possible to roll back changes? It doesn't look good. Only if it's not a burden,

You mean removing dark mode from dashboard?
Or just removing the toggle button??

@Akshay6890


Mod Request: Mouse Tweaks

CurseForge link
https://www.curseforge.com/minecraft/mc-mods/mouse-tweaks
CurseForge Mod Distribution
Allowed
Modrinth link
https://modrinth.com/mod/mouse-tweaks
Source/other link
No response
Mod file size
75.54 KiB
License
(any other license)
What it does
Mod adds various qol features, allowing the use of dragging items into chests and around crafting inventories.
Why should it be in the modpack
Adds significant QOL changes that improve the experience without altering the core gameplay.
Very lightweight.
One of the most popular mods, with over 171m downloads on curseforge.
Available both on curseforge and modrinth.
Always updated, has had versions since 1.4.2 on curseforge.
Why shouldn't it be in the modpack
Cannot see any obvious reasons.
Additional details
No response

Well, it has to be learned by the user, which is something I don't like when adding new mods. Also, I don't really see what value it adds over vanilla, as these kinds of mouse gestures are already possible in one way or another.

I agree that it has to be learned, but it is something that is very easily learned and not intrusive so if a user does not know about the functionality it does affect their gameplay in any way. There are arguably more intrusive mods like sodium which change the whole video settings menu, all those extra options have to be learnt since they are no longer in one scrollable menu like before.
The scroll wheel feature is particularly useful. Let's say you want to take 7 diamonds out of a chest as an example, in vanilla you would have to click the item out of the chest and then click 7 times to put the items in your inventory and move the item back again. With this feature you can just hover over the item and use the scroll wheel to accurately take those items directly into your inventory, saving so much time. It is very subtle but extremely useful.

Sorry, I still don't think this mod is suitable for this modpack.


proto clean: "" is not a built-in tool and has not been configured as a plugin

Running proto clean, I get this error where the plugin name seems to be empty:

I'll dig more into the code soon to try to fix the issue.

Easy enough fix.


[MM-49619] Channel doesn't show the posts

Summary

When CRT is enabled, On receiving a thread post (new post/edited) are being saved as channel posts, and on navigating to the channel, the channel looks empty as the saved posts are of a thread and no root posts are there but since parameter uses this updated value and doesn't load previous posts.

DM threads will not have a team_id, so use the currentTeamId to save the thread in threadsInTeam table.

Ticket Link
https://mattermost.atlassian.net/browse/MM-49619
Release Note
NONE

@anurag6713 i do wonder about the same as Daniel

We save thread in the thread table but to show the threads under different teams and continue the sync, we save the team-thread relation in  thread_in_team table.

https://github.com/mattermost/mattermost-mobile/pull/6090 For more information.

@anurag6713 just to be sure I understood.
We just add them to this team, to avoid gaps, and they will be added to their respective team when we start paginating over the threads of a different team. Am I right?
If so, LGTM, but I would consider making the teamId for the handleThreads as a required field (can be handled in a different PR).

ok so we merge this ?

We just add them to this team, to avoid gaps, and they will be added to their respective team when we start paginating over the threads of a different team. Am I right?
Yes, you are right.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-mobile
   bb351c737..c8ded6ef3  main        -> upstream/main
   57a9ff31b..317568b4c  release-2.0 -> upstream/release-2.0
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
!!! 'upstream/release-2' not found. The second argument should be something like upstream/release-0.21.
    (In particular, it needs to be a valid, existing remote branch that I can 'git checkout'.)

+++ Returning you to the master branch and cleaning up.

Cherry pick is scheduled.

/cherry-pick release-2.0

/cherry-pick release-2.0

Cherry pick is scheduled.


Add Gradle Wrapper Upgrade Plugin

https://github.com/gradle/wrapper-upgrade-gradle-plugin

Fixed via https://github.com/ioki-mobility/GradleWrapperUpgrader


cert-manager: fast-forward to upstream 193c5e2

What this PR does / why we need it:

Bump to v0.7.0

Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @kragniz

I notice you have the jetstack/cert-manager repo up on hub.helm.sh ... would it make sense to deprecate the version here in favor of that one ?

Thanks for the info @paulczar . I'll close this PR.


Bash 0.19 no longer builds in Nix

Describe the bug
Submodule is gone so it doesn’t clone correctly
To Reproduce
Try to build 0.4.0 from Nixpkgs (doesn’t yet exist… trying to update)
Expected behavior
Newer versions seem to at least build, but why hasn’t the lockfile been updated in ages?
Environment

OS name + version: NixOS unstable
Version of the code: 0.4.0

Additional context
Add any other context about the problem here.
[^1]
[^1]: Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

This has been a recurring theme with the bash tree-sitter grammar depending on bash itself. The lockfile hasn't been updated in ages because the bash grammar changed significantly, and we haven't had the time to update our queries.
The main issue regarding the current build failure is here: #702, I'll leave this issue open for the valuable regarding the bash update, but I think all further discussion about the savannah issue should go there.
Thank you!


 I have sketchybar dir in ./config and there is a binary(it's named sketchybarrc, it was created after installation of sketchybar) in there, should I make a symlink of this binary in the same one sketchybar dir and then just clone the repo into ./config dir separately, as the commands say? I tried that and system does not even see a command 'dynamic-island-sketchybar'.

sketchybarrc is not a binary file, instead it's more like a configuration file. Symlink needs to be created for the sketchybar binary itself. Running the command in the readme will create a symlink and place the symlink next to where the sketchybar installation happened.

Installation can now be done with homebrew:
brew tap crissnb/dynamicisland
brew install DynamicIslandSketchybar

then, a userconfig.sh file must be copied to ~/.config/dynamic-island-sketchybar/userconfig.sh.
cp /opt/homebrew/etc/dynamic-island-sketchybar/userconfigs/mbp2021_14.sh ~/.config/dynamic-island-sketchybar/userconfig.sh

(if the dynamic-island-sketchybar directory does not exist, create one)
and can be started with:
dynamic-island

See README.md for more details.


CommandoMessage.reply() seems to be missing in the typings

Hi 👋
I'm still new to understand typings & the correlation between typescript & javascript, but I think the CommandoMessage.reply is missing from the typings.
I got the following error when playing around with Commando:

I looked into the typings/index.d.ts and didn't find the reply command, so I'm assuming that's where my error came from.
If that is not the issue does someone know what I'm doing wrong (It's working with all the other "respond" method)?
Thanks!

CommandoMessage extends Message, which already has the reply method.
A quick fix for your issue would be to change the return type to Promise<Message> or omit it.


Where should be placed business logic?

If I placed this confidential logic in command handler.  This data also writes in event store,  table DomainCommand.
It should be additional layer for all logic (some services), and Commands/Events only updates storages ?

I put the business logic in the handler itself and in the aggregate. Everything related to event sourcing happens under the hood. Command handlers are the equivalent of buissness services in a layered architecture.

Yes, but if I need works with some confidential data (some encryption data, etc).
So, if I do it in commands it's data writes to DomainCommands table in not encrypted format.
Also, If I need to do some manipulation with data, and return result from command, not store it.

Some another questions: Could I do some commands in background ?
I did make hangfire (fire and forget job), but nothing happened. For command/events execution needs context ?

error in background execution
System.NullReferenceException: Object reference not set to an instance of an object.
at OpenCqrs.Dependencies.Resolver.ResolveT
at OpenCqrs.Dependencies.HandlerResolver.ResolveHandlerTHandler
at OpenCqrs.Queries.QueryProcessor.ProcessAsync[TQuery,TResult](TQuery query)

These are two options I could add, not store the commands and return a result.

Hi @Ilchuk-Mihail, sorry for the delay, tough time between work and uni :-)
I'm trying to find the best way to add a configuration option for saving commands at the global level and at the command level.
Not sure about returning results for the commands. Ideally commands should not return anything, but maybe it might be useful to return the event(s) generated.

Doing some experiments in the dev branch: https://github.com/OpenCQRS/OpenCQRS/tree/Dev

I have added global configuration options that can be set during registration (default value is true):
services
  .AddOpenCqrs(typeof(CreateProduct), typeof(GetProduct))
  .AddOptions(x => { x.SaveCommands = false; })
  .AddSqlServerProvider(Configuration)
  .AddServiceBusProvider(Configuration);

and the default setting can be overridden for every command using the new property SaveCommand of the IDomainCommand interface:
public interface IDomainCommand : ICommand
{
    Guid Id { get; set; }
    Guid AggregateRootId { get; set; }
    string UserId { get; set; }
    string Source { get; set; }
    DateTime TimeStamp { get; set; }
    int? ExpectedVersion { get; set; }
    bool? SaveCommand { get; set; }
}

Maybe he meant to do this in a by-command basis? and not for the whole app?
[SaveCommand(false)]
public class CreateProduct : DomainCommand

[UnpersistedCommand]
public class CreateProduct : DomainCommand

public class CreateProduct : UnpersistedDomainCommand

Or similar approaches.
TIL: https://en.wiktionary.org/wiki/unpersist

You can set it for the whole app and still be able to override it on a command basis by simply override the property SaveCommand

Great!

I'm wondering if it might be better to still save the command but not the data associated to it.

@lucabriguglia
Thanks for help.

I'm wondering if it might be better to still save the command but not the data associated to it.
In my opinion, it is a better way. That way we can track all events and commands which happened in the app. We will not have any gaps.

@lucabriguglia
Thanks for help.
I'm wondering if it might be better to still save the command but not the data associated to it.
In my opinion, it is a better way. That way we can track all events and commands which happened in the app. We will not have any gaps.

I agree, I would change the SaveCommand property to SaveCommandData.

Commit here: https://github.com/OpenCQRS/OpenCQRS/commit/473cb1b72a0815a82f7573a65d860e123dc582e3


Goals for External User Research

To prepare for external user research (when we have capacity & approved PIA), this ticket documents outlining our goals for the research to set expectations.

[ ] Ideate potential areas of focus
[ ] Ideate potential methods of research & testing
[ ] Outline high-level goals for completing external user research
[ ] Document this in the Scrum Team channel for future reference

Duplicate of #211


Two concepts connected by multiple relations

Hello,
I noticed the following issue among two GO concepts- GO:0000919 and GO:0022402. Kindly check the hierarchy from the link below.
https://www.ebi.ac.uk/QuickGO/term/GO:0000919
It seems that these two concepts are connected by both is-a and part-of relations as follows.
It can be inferred that GO:0000919 part-of GO:0022402 by the following:
GO:0000919 part-of GO:0000911 is-a GO:0000910 is-a GO:0022402
This is based on the reasoning rules mentioned in: http://geneontology.org/docs/ontology-relations/
It can be also observed that GO:0000919 is-a GO:0022402
Is this accurate? Can two concepts be connected by such multiple relations?

Hello @rashmie
Yes, GO has multiple inheritance. See some documentation here: http://geneontology.org/docs/ontology-documentation/
Thanks, Pascale

Hello @pgaudet
Thanks for the quick response. I apologize if I wasn't clear earlier. But, the issue I mentioned is not about multiple inheritance. In the example that I provided, GO:0000919 is both a child of and a part of GO:0022402. I feel like a concept being both a child and a part of another concept is not correct. Could you please clarify?

I feel like a concept being both a child and a part of another concept is not correct. Could you please clarify?

There is no technical problem with this, in fact it's quite common. As an outside example, think of Carnivore, which you could model as:

Carnivore is_a Animal
Carnivore eats Animal

If you want to take into account carnivorous plants, then it just pushes the inference farther back:

Carnivore is_a Organism
Carnivore eats Animal (which implies 'Carnivore eats Organism' via 'Animal is_a Organism')

Hi @balhoff,
Thank you for the explanation and the nice example. It indeed makes sense.


graph rag demo 向量数据库查询query 一直为空

需要先构建三元组。

to fix your trouble check this solution click
maybe this will solve your problem.


Dev feature 1 - Reduce Max Template Supply

Incorporated all comments above, this feature should be ready for production.


MB-4869 Enable validation of EDI during its generation

Description
Pre-GHC EDI generation made use of the gopkg.in/go-playground/validator.v9 to validate the EDI structure. This PR adds the validation back in to the EDI validation.
Reviewer Notes
Old code passed the logger in, I'm not sure if this is the best way to report errors in validation, but figured it couldn't hurt
Setup
Make sure server tests pass
make server_tests

Code Review Verification Steps

[X] Code follows the guidelines for Logging
[X] Request review from a member of a different team.
[X] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-4869

  Generated by :no_entry_sign: dangerJS against 0bcb729ee784f4f5a9ee109a250f37c85b7980c4


Example showing 3D stencil calculations.

Example might be useful to others. I get a speedup of ~85x with this small kernel (compared to single CPU core, so it's not really a fair comparison) so I think I did it right but please fix/amend as necessary.
Resolves #12

Hm I wonder why the tests are not being run here.

Please rebase on master and take a look at https://github.com/vchuravy/GPUifyLoops.jl/blob/master/examples/simple.jl the examples are both tested on CPU and GPU only environments and as such the GPU part needs to be conditional.

bors try

Example should run on both CPU and GPU now. Will only run on the GPU if CuArrays is found.
Git noob here and first time rebasing. Lemme know if I screwed up and I can nuke this pull request and open a clean one.

Yeah do a:
git fetch
git rebase -i origin/master

Drop all the commits that are unnecessary.

I'll learn to rebase another day.


Update to Angular 4

As of today (28 March), Nativescript supports the newly updated Angular 4 version.
Guidelines on how to update to it are posted here
https://www.nativescript.org/blog/nativescript-supports-angular-4
It'd be nice if somebody picks this up (could be me, if I find time in T + 24h from now).

I just upgraded one of my projects, I think it won't be too awful to do this one


GB Throwing Runtime Exception Errors

Gradebook is currently throwing the following runtime exception error in every test site:

@steveswinsburg, this looks related to the new settings database column.  The column we had Andy create was course_grade_letter_displayed (from the Oracle script) but the SQL in the error refers to course_letter_grade_displayed.. eep.

Fixed, sorry about that!