Add support for --noEmitUnderscoreUnderscoreESModule flag

The '__esModule' is a standard for CommonJS, but forcing the emit '__esModule' does cause problems for many users.
Issues: https://github.com/microsoft/TypeScript/issues/30718 https://github.com/microsoft/TypeScript/issues/30166 https://github.com/microsoft/TypeScript/issues/22879 https://github.com/microsoft/TypeScript/issues/15795 https://github.com/microsoft/TypeScript/issues/15685 https://github.com/microsoft/TypeScript/issues/14351 https://github.com/microsoft/TypeScript/issues/13709#issuecomment-281927333
For me, I have a script that converts the CommonJS code into a baas cloud code, but the Typescript API has no way to remove '__esModule', I can only do replace string of this code:
Object.defineProperty(exports, "__esModule", { value: true });

But this is not safe, I am not sure if Typescript will change this code in the future:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: johnsoncodehk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

good

any updates on that?

Which issue is approved to take a PR (i.e. is in the Backlog milestone) ?

This problem may never be concerned about.
But here is a quick fix:
Search and replace all !currentModuleInfo.exportEquals to false under TYPESCRIPT_DIR/lib/

We need an approved issue for a PR to be looked at, but there doesn't appear to be one.
Logged #32934 as the typeof check seems reasonable

I'm using Typescript in an embedded V8 context, and the engine does not assign exports automatically. Instead it only populates module.exports.
In my case, my code is not intended to run in any other JavaScript environment, so as a quick and dirty hack to delete these lines in the meantime, I'm using the tsc-watch tool to fire a script after successful watch builds in order to automatically delete the lines.
package.json scripts:
  "scripts": {
    "watch": "sh node_modules/.bin/tsc-watch --onSuccess 'npm run patchTSOutput'",
    "patchTSOutput": "find . -path ./node_modules -prune -o -print | grep \\.js$ | xargs -n 1 ex '+g/^Object\\.defineProperty(exports,/d' -cwq"
  },

Just thought I'd share for other onlookers in the same situation. If you're running into this problem and you want to target many JavaScript environments, you'd probably be better off inserting undefined guards instead (similar to the suggestion in #32934).


don't install anything globally, bootstrap virtualenv into working dir

I don't want that my global python configuration is modified when I build Noto fonts.
It's better to avoid doing any sudo and even pip install --user, and let the user decide what to do.
If pip is missing, we just fail, suggest a course of action and direct the user to the pip documentation.
If pip is installed but virtualenv is not, we can install virtualenv in our working directory with --target option, and use it to bootstrap our virtual environment.
Also, before installing fontmake, it's a good idea to make sure the submodule is up-to-date.

👍


Vertical alignment

is there a simple method to make ** vertical alignment ** of carousel in the center of the page?
Does slick slider provide such function?

https://github.com/kenwheeler/slick/issues/2086
@wider2 ... I appreciate you need help with your web development... however, if you really needed help with your problem... you could have asked for it in your identical issue I closed a week ago.
This is a place for tracking bugs/problems with Slick, not for helping you with the age-old CSS problem. - Please read carefully the contribution guidelines https://github.com/kenwheeler/slick/blob/master/CONTRIBUTING.markdown and get the help you need in a more appropriate manner :)
Best, Simon.


manually define package list definition in pyproject.toml

instead of using find:, so that build can package resources as asdf_standard.resources

@WilliamJamieson


Hydra: Make nix.conf changeable

if the same stuff is already reviewed for main...

Pedantic answer would be that the same patch can be good on top of one codebase, and bad on top of another.
How likely our reviews are ever to catch such issues (i.e. is that fleeting chance worth it) is another question.


RethinkDB

How hard would it be for me to write a RethinkDBdash compatible layer for lucid?
Or does anyone heard of a rethinkdb orm for adonis?
Which files needs modifications?

I have no idea about, since I don't and never using RethinkDB


Interactive scribbling in notebook for image segmentation

I spoke to some of you @EarthSim folks at SciPy2018, inquiring if pyviz/EarthSim tools could support the kind of "scribbling" interaction that we use to annotate images for deep neural network image segmentation of drone-derived beach photomosaics.
The work flow is that the user is presented with part of the image, and cycles through the different classes (e.g. sand, water, vegetation, etc) scribbling on each one to indicate the regions they see that match the class.   A 2 minute video is here: https://www.youtube.com/watch?v=0sXYKmbLz_s, and an image is shown below where the user has already indicated sand regions and has moved on to water:

Would it be possible to use the existing pyviz/EarthSim tools to do this in a notebook cell, returning the scribbled line coordinates to python?

A freehand drawing tool is definitely on our to-do list but I haven't yet started work on adding it to bokeh.

@philippifr, "freehand drawing tool" is so much better than "scribbling" or "doodling"!
Should I raise the issue on bokeh issues?

Closing in favor of https://github.com/bokeh/bokeh/issues/8133

Decided to have a go, here's a quick demo, PR incoming later today I hope:

@philippjfr WHOA!!!!  That's awesome!

The speed of @philippjfr puts the rest of us to shame! :)

Philipp Rudiger: PR by name, PR by nature :)

So how does run it? :)

@felix-tracxpoint See the Drawing Tool user guide on the website.

Thanks for this great addition. I finally got around to installing, following instructions posted here.
I would like to be able to freehand draw on an image without any geospatial information (i.e. just returning the 'image coordinates' of any annotations I make). Taking the provided image as an example, in examples/data, I can display the image like this:
import numpy as np
from imageio import imread
import holoviews as hv
from holoviews.streams import FreehandDraw
hv.extension('bokeh')

bounds=(0,0,1,1)   # Coordinate system: (left, bottom, top, right)
img = hv.Image(im, bounds=bounds)
img

but then I get stuck because I can't figure out how to add the FreehandDraw tool. I naively thought I could add a path like this
%%opts Path (line_width=1 color='white') [width=1 height=1]
path = hv.Path([[(0, 0), (1, 1)]])
freehand_stream = FreehandDraw(source=path, num_objects=99)
bounds=(0,0,1,1)   # Coordinate system: (left, bottom, top, right)
img = hv.Image(im, bounds=bounds)
img * path

but that didn't work. Any advice?

That works for me as long as you remove [width=1 height=1]. This sets the width and height of the plot to 1 pixel.

So simple! Thanks @philippjfr !
Another thing, is there a way for the image to either 1) display much larger or 2) expand to another browser tab?

Sorry, disregard. I guess that's what [width=1000, height=1000]   does!


make tabsize customizable

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   90.46%   90.46%
=======================================
  Files           3        3
  Lines         304      304
=======================================
  Hits          275      275
  Misses         29       29

Impacted Files
Coverage Δ

src/PrettyPrinting.jl
100% <ø> (ø)
:arrow_up:

src/tile.jl
88.07% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c34ce52...768ff14. Read the comment docs.


Discuss port numbers

Discuss health check port numbers.
Signed-off-by: Miek Gieben<EMAIL_ADDRESS>

AFAIK it really doesn't matter if it's health check ports or not because in the end those are ports that apps (try to) bind to, eg I have and HTTP server listening on TCP 80 and I use a livenessProbe that is a TCP check and a readinessProbe that's an HTTP GET check.

AFAIK it really doesn't matter if it's health check ports or not because in the end those are ports that apps (try to) bind to, eg I have and HTTP server listening on TCP 80 and I use a livenessProbe that is a TCP check and a readinessProbe that's an HTTP GET check.


resin-u-boot.bbclass: Add v2018.05 specific patch

In preparation for some u-boot work on the pi.

Contributor checklist

[x] Changes have been tested
[x] Change-type present on at least one commit
[x] Signed-off-by is present
[x] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

When submitting a review, please pick:

'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Using sumo u-boot v2018.01 so this isn't needed.


Fix validate_opts when single form

Test and fix for broken validate_opts when the added form is a :single type.
refs #41
Contributor checklist

[X] Bug fixes include regression tests

Pull Request Test Coverage Report for Build b308f3aa11bafebe9662fe15c39b66d67f6c839d-PR-44

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.258%

Totals

Change from base Build de56e1d20ac378da6c8f87b8a5209a3f383b2afe:
0.0%

Covered Lines:
876

Relevant Lines:
1743

💛  - Coveralls

🚀 Thank you for your contribution! 🚀


Script _common.sh fails to detect correct CPU count in WSL (Windows Subsystem for Linux) distro

Describe the bug
The script _common.sh fails to detect correct CPU count in WSL distributions.
How can we reproduce it?
Export the following two functions from the mentioned script:

common::get_cpu_num
common::colorify

Run common::get_cpu_num
You will see this output:
Unable to derive number of available CPU cores.
 Running inside K8s pod without limits or inside DinD without limits propagation.
 To avoid possible harm, parallelism is disabled.
 To re-enable it, set corresponding limits, or set the following for the current hook:
   args:
     - --hook-config=--parallelism-ci-cpu-cores=N
 where N is the number of CPU cores to allocate to pre-commit.
1

This is wrong. This snippet from get_cpu_num shows the correct CPU count:
> nproc 2> /dev/null || sysctl -n hw.ncpu 2> /dev/null || echo 1
20

But the script never reaches this point, because
/sys/fs/cgroup/cpu/cpu.cfs_quota_us

exists (and it contains -1).
So the problem is that the hook is not running inside K8s pod or inside DinD but inside WSL. It is possible to set CPU limits for WSL. But by default WSL is allowed to use all available CPUs with no limit.
Environment information
WSL-Version: <IP_ADDRESS>
Kernelversion: <IP_ADDRESS>-2
WSLg-Version: 1.0.65
MSRDC-Version: 1.2.5620
Direct3D-Version: 1.611.1-81528511
DXCore-Version: 10.0.26100.1-240331-1435.ge-release
Windows-Version: 10.0.22621.4317

Hook version is v4.6.0

Thanks for the hooks.

@trallnag Can you please confirm that /sys/fs/cgroup/cpu/cpu.cfs_quota_us file exists inside your WSL env?

@MaxymVlasov If confirmed, we can additionally check for absence of /proc/sys/fs/binfmt_misc/WSLInterop file at https://github.com/antonbabenko/pre-commit-terraform/blob/master/hooks/_common.sh#L202 (ref: https://superuser.com/a/1749811/1241314) — this method looks to be in "full compliance" with the existing check on that line. WDYT?

@yermulnik both files exist in my WSL distribution (Ubuntu from Microsoft store, no customizations)
pringles:~# cat /sys/fs/cgroup/cpu/cpu.cfs_quota_us
-1

root@pringles:~# stat /sys/fs/cgroup/cpu/cpu.cfs_quota_us
  File: /sys/fs/cgroup/cpu/cpu.cfs_quota_us
  Size: 0               Blocks: 0          IO Block: 4096   regular empty file
Device: 0,60    Inode: 10          Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2024-10-25 19:53:10.198506900 +0200
Modify: 2024-10-25 19:53:10.198506900 +0200
Change: 2024-10-25 19:53:10.198506900 +0200
 Birth: -

pringles:~# stat /proc/sys/fs/binfmt_misc/WSLInterop
  File: /proc/sys/fs/binfmt_misc/WSLInterop
  Size: 0               Blocks: 0          IO Block: 4096   regular empty file
Device: 0,32    Inode: 18882       Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2024-10-25 19:51:08.700467298 +0200
Modify: 2024-10-25 19:51:08.700467298 +0200
Change: 2024-10-25 19:51:08.700467298 +0200
 Birth: -

@MaxymVlasov I went ahead and created quick PR: https://github.com/antonbabenko/pre-commit-terraform/pull/728 — please let me know what do you think. Thanks.

@trallnag do you have /sys/fs/cgroup/cpu.max in WSL?
If not, please  ls -a /sys/fs/cgroup/

I don't have it:
❯ cat /sys/fs/cgroup/cpu.max
cat: /sys/fs/cgroup/cpu.max: No such file or directory

❯ ls -a /sys/fs/cgroup/
.   blkio  cpuacct      cpuset   freezer  memory  net_cls           net_prio    pids  systemd
..  cpu    cpu,cpuacct  devices  hugetlb  misc    net_cls,net_prio  perf_event  rdma  unified

❯ ll /sys/fs/cgroup/
Permissions Links Size User Date Modified    Name
dr-xr-xr-x      3    - root 2024-10-31 17:46 blkio/
dr-xr-xr-x     11    - root 2024-10-31 17:46 cpu/
drwxr-xr-x      2    - root 2024-10-31 17:46 cpu,cpuacct/
dr-xr-xr-x      6    - root 2024-10-31 17:46 cpuacct/
dr-xr-xr-x      6    - root 2024-10-31 17:46 cpuset/
dr-xr-xr-x     14    - root 2024-10-31 17:46 devices/
dr-xr-xr-x      7    - root 2024-10-31 17:46 freezer/
dr-xr-xr-x      6    - root 2024-10-31 17:46 hugetlb/
dr-xr-xr-x     14    - root 2024-10-31 17:46 memory/
dr-xr-xr-x      6    - root 2024-10-31 17:46 misc/
dr-xr-xr-x      6    - root 2024-10-31 17:46 net_cls/
drwxr-xr-x      2    - root 2024-10-31 17:46 net_cls,net_prio/
dr-xr-xr-x      6    - root 2024-10-31 17:46 net_prio/
dr-xr-xr-x      6    - root 2024-10-31 17:46 perf_event/
dr-xr-xr-x     14    - root 2024-10-31 17:46 pids/
dr-xr-xr-x      6    - root 2024-10-31 17:46 rdma/
dr-xr-xr-x     14    - root 2024-10-31 17:46 systemd/
dr-xr-xr-x     16    - root 2024-10-31 17:46 unified/

Note that I don't have configured a processor limit for WSL, something which is supported: https://learn.microsoft.com/en-us/windows/wsl/wsl-config#main-wsl-settings.
Out of curiosity I just configured a limit, but the mentioned file still does not appear. But the limit definitly is applied:
❯ getconf _NPROCESSORS_ONLN
4

Without limit:
❯ getconf _NPROCESSORS_ONLN
16

I edited my msg a few times, you probably missed the final revision.
Can you please also

If not, please make cure that nproc exist and provides number >1
If not, try sysctl -n hw.ncpu, it should provide number > 1
Please let me know if any of them works in WSL.
And if still nothing works - please send  ls -a /sys/fs/cgroup/ and  ls -a /sys/fs/cgroup/cpu/

❯ nproc
16

❯ sysctl -n hw.ncpu
sysctl: cannot stat /proc/sys/hw/ncpu: No such file or directory

❯ ls -a /sys/fs/cgroup/
.   blkio  cpuacct      cpuset   freezer  memory  net_cls           net_prio    pids  systemd
..  cpu    cpu,cpuacct  devices  hugetlb  misc    net_cls,net_prio  perf_event  rdma  unified

❯ ls -a /sys/fs/cgroup/cpu/
.                      cgroup.procs          cpu.cfs_period_us  cpu.rt_period_us   cpu.stat           tasks
..                     cgroup.sane_behavior  cpu.cfs_quota_us   cpu.rt_runtime_us  notify_on_release
cgroup.clone_children  cpu.cfs_burst_us      cpu.idle           cpu.shares         release_agent

super, thank you. George fix should works for you, I'll edit a clarification comment, but you already can try it by
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: 040b9771f828d52e14eff80c47b747b92db77579

Thanks, I will try later today and report back

Thanks, I will try later today and report back

Perfect. Keep us posted. Once you confirm the fix works for you, we'll merge it to default branch.

Can confirm that it works fine with the mentioned revision:
❯ task format
...
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
...
Terraform fmt............................................................Failed
- hook id: terraform_fmt
- files were modified by this hook

route53.tf
route53.tf
...

This issue has been resolved in version 1.96.2 :tada:


[BUG] Natural armor is considered as unproficient with the armor check setting on

When the AC5e armor automation setting is enabled, a creature that has only natural armor like the Ogre Zombie from the system's SRD, is considered unproficient with that armor and gets disadvantage on a attack rolls.
I think this behavior is wrong and a bug, as per RAW a creature is always proficient with its natural armor.

I have already corrected this in the soon to be released version ( #72 )
Thanks for taking the time to write this up though! 👍

Still an issue in 11.315312.2.1


Use Scala Hedgehog in ParseKey test

Ref https://github.com/sbt/sbt/issues/4523
This is a port of ParseKey property-based testing to Scala Hedgehog by the framework's author.
One of the feature is automatic shrinking.

Hi @charleso,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

@eed3si9n Oh wow, didn't think this would go anywhere. Do you mind me asking, what are you intentions regarding hedgehog in SBT with this PR? Would you actually merge this, or is it just to get some more people interested/aware?
As mentioned on the original issue, I would actually be hesitant about using hedgehog in something critical to the Scala ecosystem without setting some expectations first, and doing some tidying etc.
Thanks!

@charleso

Would you actually merge this, or is it just to get some more people interested/aware?

Yes, my intent is to merge this at the earliest point you think we're good to go, and replace the existing test that sometimes fails mysteriously. I was able to improve the test a bit (https://github.com/sbt/sbt/pull/5137/commits/a09197a929652af2650744e75f73b058d12fb724) from looking at some shrunk examples, so I think it's doing some useful things.

@eed3si9n Sorry for the random suggestions, how can I best help you on this PR? Did you want me to fork your branch and make the changes there and you can cherry-pick them?

Just to give you a heads up, and part of my vague reluctance in using hedgehog on a major project, is that I haven't really been paying attention to things like binary (or even source) compatibility. I'm not sure how much you see that being a concern/problem in SBT. I don't think it's necessarily very hard to do, I just haven't had the need up until this point because there doesn't appear to be any other users/consumers. I'm happy to discuss further, I love the idea of hedgehog being used more seriously, but slightly concerned that users will inevitably get frustrated with me/hedgehog because of poor maintenance.

Just to give you a heads up, and part of my vague reluctance in using hedgehog on a major project, is that I haven't really been paying attention to things like binary (or even source) compatibility. I'm not sure how much you see that being a concern/problem in SBT. I don't think it's necessarily very hard to do, I just haven't had the need up until this point because there doesn't appear to be any other users/consumers. I'm happy to discuss further, I love the idea of hedgehog being used more seriously, but slightly concerned that users will inevitably get frustrated with me/hedgehog because of poor maintenance.

In my opinion, you just have to be upfront about whether you intend to keep source- and/or binary- compatibility for whatever range of version number. You already state in the readme that "The API may break during this stage". Now that there is a version number, you can take different strategy about the compatibility.
For example:

As Semantic Versioning suggests, all 0.x versions are beta versions. API may break between 0.1.0 and 0.2.0.
We will try to keep source compatibility within 0.x series between the patches. For example, tests written for 0.1.0 should continue to work for 0.1.(1, 2, 3, ...).

sbt cares a lot about the binary compatibility of itself because the plugin ecosystem is one of our best asset, but it's not a huge concern for me if Hedgehog needs to make breaking changes in the future since we're just using to test things. It might eventually be your concern too once people want to integrate with Hedgehog to do law checking (https://github.com/typelevel/discipline) or some other integration test kit off of Hedgehog.

Cool. Should be relatively straight forward. I'm happy to do that in the
next day or so and let you know if you like?
On Sun, 29 Sep 2019, 9:53 am eugene yokota<EMAIL_ADDRESS>wrote:

@eed3si9n commented on this pull request.
In main/src/test/scala/sbt/internal/TestBuild2.scala
https://github.com/sbt/sbt/pull/5137#discussion_r329331530:

+package sbt
+package internal
+
+import Def.{ ScopedKey, Setting }
+import sbt.internal.util.{ AttributeKey, AttributeMap, Relation, Settings }
+import sbt.internal.util.Types.{ const, some }
+import sbt.internal.util.complete.Parser
+import sbt.librarymanagement.Configuration
+
+import java.net.URI
+
+import hedgehog._
+import hedgehog.predef.sequence
+
+object TestBuild2 extends TestBuild2
I think if would be cool if we can migrate the other ones so we can remove
the old TestBuild.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sbt/sbt/pull/5137?email_source=notifications&email_token=AAAHSU4MMFCS7ZX7P6FTSFDQL7U6LA5CNFSM4I3NCVA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIB7VQ#discussion_r329331530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAHSUYM77YTSB7PFU5J3LTQL7U6LANCNFSM4I3NCVAQ
.

FYI the last commit on https://github.com/eed3si9n/sbt/compare/wip/hedgehog...charleso:wip/hedgehog has author information as
Charles O'Farrell<EMAIL_ADDRESS>
This is going to trigger the CLA validator etc, so I amended to match the other commits.

@eed3si9n Thanks for fixing my git author.
I've rebased and pushed a new commit to my fork/branch which updates the 2 remaining ScalaCheck tests to hedgehog.
The last Delegates test fails, but at a glance I'm not sure if this is because of any of my/your changes to the generation or not. I'm happy to investigate but I figure you might have a better idea?
- sbt.Delegates$.Config axis delegates to parent configuration: Falsified after 20 passed tests
> Env:
    Tasks:
    aa (delegates: )
    ab (delegates: )
Build file:///aaaaaaa/#a :
    Project a
      Delegates:

      Configurations:
        Aa
    Project b
      Delegates:

      Configurations:
        A
Scopes:
    Scope(Select(BuildRef(file:///aaaaaaa/#a)), Select(ConfigKey(A)), Zero, Zero)
> java.util.NoSuchElementException: key not found: A
    at scala.collection.immutable.Map$Map1.apply(Map.scala:114)
    at sbt.internal.TestBuild$Env.inheritConfig(TestBuild.scala:142)
    at sbt.Delegates$.$anonfun$tests$36(Delegates.scala:101)
    at sbt.Delegates$.$anonfun$allDelegates$1(Delegates.scala:124)
    at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
    at scala.collection.immutable.List.foreach(List.scala:392)
    at scala.collection.TraversableLike.map(TraversableLike.scala:238)
    at scala.collection.TraversableLike.map$(TraversableLike.scala:231)
    at scala.collection.immutable.List.map(List.scala:298)
    at sbt.Delegates$.allDelegates(Delegates.scala:122)
    at sbt.Delegates$.$anonfun$tests$35(Delegates.scala:95)
    at scala.Option.map(Option.scala:230)
    at hedgehog.core.PropertyT.$anonfun$map$1(PropertyT.scala:64)
    at scala.Option.map(Option.scala:230)
    at hedgehog.core.GenT.$anonfun$map$2(GenT.scala:12)
    at hedgehog.core.TreeImplicits1$$anon$1.map(Tree.scala:35)
    at hedgehog.core.TreeImplicits1$$anon$1.map(Tree.scala:33)
    at hedgehog.core.Tree.map(Tree.scala:16)
    at hedgehog.core.TreeImplicits1$$anon$1.$anonfun$map$2(Tree.scala:35)
    at hedgehog.predef.LazyList.$anonfun$map$1(LazyList.scala:16)
    at hedgehog.predef.LazyList.$anonfun$map$1(LazyList.scala:16)
    at hedgehog.predef.package$.findMap(package.scala:40)
    at hedgehog.core.PropertyTReporting.takeSmallest(PropertyT.scala:145)
    at hedgehog.core.PropertyTReporting.takeSmallest$(PropertyT.scala:135)
    at hedgehog.package$$anon$2.takeSmallest(package.scala:32)
    at hedgehog.core.PropertyTReporting.loop$1(PropertyT.scala:202)
    at hedgehog.core.PropertyTReporting.report(PropertyT.scala:212)
    at hedgehog.core.PropertyTReporting.report$(PropertyT.scala:169)
    at hedgehog.package$$anon$2.report(package.scala:32)
    at hedgehog.PropertyTOps.check(Property.scala:38)
    at hedgehog.PropertyTOps.check$(Property.scala:37)
    at hedgehog.package$Property$.check(package.scala:19)
    at hedgehog.runner.Properties.$anonfun$main$1(Properties.scala:15)
    at hedgehog.runner.Properties.$anonfun$main$1$adapted(Properties.scala:14)
    at scala.collection.immutable.List.foreach(List.scala:392)
    at hedgehog.runner.Properties.main(Properties.scala:14)
    at sbt.Delegates.main(Delegates.scala)

I've rebased and pushed a new commit to my fork/branch which updates the 2 remaining ScalaCheck tests to hedgehog.

Thanks.

The last Delegates test fails, but at a glance I'm not sure if this is because of any of my/your changes to the generation or not. I'm happy to investigate but I figure you might have a better idea?

Looks like there's a problem with the test.
    Scope(Select(BuildRef(file:///aaaaaaa/#a)), Select(ConfigKey(A)), Zero, Zero)

BuildRef(...) technically doesn't own a configuration, so it's probably failing to look anything up. Filtering BuildRef out for now should be ok - https://github.com/sbt/sbt/pull/5137/commits/1cfe14a877582be8efc5df47dd5faef5bf7a02dc

@eed3si9n Just to take stock, is there anything else you need/want me to do on this PR? What's next?

@charleso I am ok with merging as-is. What do you think?

@ee3si9n I'm ok with that if you are? It's exciting (for me at least).
Do let me know if there are any follow questions/concerns/requests for Hedghehog. I'll try to improve my release process and include mima for sanity checking this week now that I have a real user!
Thanks!

@eed3si9n thanks so much for all the help, and pushing that through!!!

@charleso Thanks for all the help. Hopefully I'd starting writing more tests (none of these tests were originally written by me).


Excluding directory

I think there should be excluding directory besides excluding files and images.

Agreed

@esafirm How to filter media files?


Jade Crashes on Startup When FLASH_ENC_ENABLED on TTGO

Intro
I've bricked a few LILYGO T-Displays while trying to flash mkdefaults ...ttgo_tdisplay.defaults NDEBUG SECURE, thinking it was me messing up the more involed secure boot flashing process, but I believe I've managed to narrow the error down in a dev env...
Env

M1 MacBook Pro (13" 2020)
Debian 12 via UTM 4.4.4 (93) on macOS 14.1.2 (23B92)
manual env setup as per https://github.com/Blockstream/Jade/blob/1.0.26/README.md
LILYGO T-Display ESP32 (Rev3) 1.14"

Steps to Reproduce
( find resulting sdkconfig.defaults also attached:
sdkconfig.defaults.txt )
./tools/mkdefaults.py ./configs/sdkconfig_display_ttgo_tdisplay.defaults DEV
apply the following changes to resulting sdkconfig.defaults:
remove:

CONFIG_BOOTLOADER_LOG_LEVEL_NONE=y
CONFIG_ESPTOOLPY_FLASHSIZE_4MB=y
CONFIG_PARTITION_TABLE_OFFSET=0x9000

add:

CONFIG_BOOTLOADER_LOG_LEVEL_INFO=y
CONFIG_ESPTOOLPY_FLASHSIZE_16MB=y
CONFIG_PARTITION_TABLE_OFFSET=0xA000
CONFIG_DEFAULT_LOG_LEVEL_INFO=y
CONFIG_SECURE_FLASH_ENC_ENABLED=y
CONFIG_EFUSE_VIRTUAL_KEEP_IN_FLASH=y
CONFIG_EFUSE_VIRTUAL_LOG_ALL_WRITES=y

partitions.csv:

nvs,      data, nvs,     0xB000,  0x4000,
otadata,  data, ota,     0xF000,  0x2000, encrypted
ota_0,    app,  ota_0,   ,         1984K,
ota_1,    app,  ota_1,   ,         1984K,
nvs_key,  data, nvs_keys,,            4K, encrypted
efuse_em, data, efuse,   ,        0x2000,

rm -r build
rm sdkconfig
idf.py flash-erase
idf.py flash monitor
Expected
A functioning Jade on the same board as achieved by idf.py flashing mkdefaults ...ttgo_tdisplay.defaults DEV (ie. without the add. above modifications to sdkconfig.defaults and partitions.csv)
Actual
( find full monitor log attached: idf_monitor_sdkconfig-defaults-DEV-virtFlashEnc-w-bootlInfoLog.log ):

Backtrace: 0x40081d92:0x3ffbd7b0 0x40094831:0x3ffbd7d0 0x4009983b:0x3ffbd7f0 0x400d7090:0x3ffbd870 0x400da5e4:0x3ffbd960 0x400dae83:0x3ffbd9e0 0x400d8490:0x3ffbda10 0x4019de44:0x3ffbda80
0x40081d92: panic_abort at /COMPONENT_ESP_SYSTEM_DIR/panic.c:452
0x40094831: esp_system_abort at /COMPONENT_ESP_SYSTEM_DIR/port/esp_system_chip.c:84
0x4009983b: abort at /COMPONENT_NEWLIB_DIR/abort.c:38
0x400d7090: jade_abort at /COMPONENT_MAIN_DIR/jade_abort.c:34
0x400da5e4: init_nvs_flash at /COMPONENT_MAIN_DIR/storage.c:299 (discriminator 5)
0x400dae83: storage_init at /COMPONENT_MAIN_DIR/storage.c:323
0x400d8490: boot_process at /COMPONENT_MAIN_DIR/main.c:98
(inlined by) app_main at /COMPONENT_MAIN_DIR/main.c:242
0x4019de44: main_task at /COMPONENT_FREERTOS_DIR/app_startup.c:208
ELF file SHA256: ac00bbc99f170617
CPU halted.
Done

At a second look:
Am I right in thinking it's not "permanently" encrypting flash with the above config at all? That would mean encrypting the partition table telling it on reboot where to find the e-fuse partition containing the decryption key, which seems self-contradicting. Even sais as much in the logs:

Flash encryption not really completed. Must disable virtual efuses

That would explain the stacktrace as far as I can tell from the Jade sources. And also make this a red herring.

Apologies Blockstream devs, there appears to be nothing wrong after all.
The above mentioned scenario, and indeed a "practice run" of flashing a sdkconfig.defaults derived via mkdefaults.py ...tdisplay.defaults SECURE, can be done by applying the above mentioned modifications and additionally setting CONFIG_NVS_ENCRYPTION=n.
After such a "practice run" of flashing a T-Display with "SECURE" sdkconfig.defaults I felt confident enough to flash a production-ready version of Jade and managed to do so successfully.


Respawn health

Starting with 2.5 hearts leaves you in one shot range for a lot of even tier 1 biome mobs(within the damage range of a vanilla skeleton). This allows the potential for a cascade of deaths as a mob immediately kills you on re-spawn over and over. Maybe consider going to 5 hearts or a temporary invulnerability buff to give you a moment to run far enough to get away or kite the mob away from your respawn.

This was originally intended to stop people from abusing death (IE, killing yourself instead of eating). I'm open to suggestions on how this should act.


Add Unity actions

This adds the collection and the test action to the list
Published actions can be seen here: https://github.com/marketplace?utf8=✓&type=actions&query=unity

@gep13 Are you interested in Unity actions?

@webbertakken we are interested in all Actions being added to this list.  I can't always guarantee that I will immediately be able to merge all PR's though, sometimes takes me a few days to get to them, but they won't be forgotten.
Your changes have been merged, thanks for your contribution 👍


Remove duplicate _tags and update SOP backrefs

This change removes duplicate SOP backreferences in _tags and applies some programmatic formatting. The code to do this can be found here: https://github.com/geowa4/servicelogger/pull/27.
OSD-21264

/test checklinks-pr

The test failures are for broken links in files that are not changed in this PR. I'll report this back to the owners of that change, but I don't think it should block this PR.

seems the test failures are for other files... weird
/lgtm
/approve

without the test pass, can we merge the change?
maybe we need to remove those broken links from the repo?

/retest

should be good to merge now

/approve


UART Support/UART-related interrupts

Self explanatory. What's the plan for this?

I think that from the kernel's perspective, this should behave exactly the same as it will in the hardware implementation. So we have memory mapped buffers/status regs or whatever the kernel needs?


How to control the gradient back-propagation

Hello, thank you for releasing your great work!
In your paper, some layers' gradient back-propagation is stopped.
I wanna know how to control this process, i.e., where to change it?
Looking forward to your reply!

Thank for your attention !
You can refer to the implementation of this line of code.

Thank for your attention! You can refer to the implementation of this line of code.

Learned it, thank you for reply!


Feature Idea: Spacebar preview / Quicklook of files (like macOS has it)

Feature Idea: Spacebar preview / Quicklook of files (like macOS has it)
Apple's macOS has a great handy feature that can (quick) preview any file without the need to open the associated application by pressing the spacebar. There are some apps out there (see below) that add this feature to Windows 10 but it would be very cool if it could be included in PowerToys in an augmented/improved way.
Apps for Windows with this functionality

QuickLook: https://www.microsoft.com/en-us/p/quicklook/9nv4bs3l1h4s
Seer Pro: https://www.microsoft.com/en-us/p/seer-pro/9pgvfjbvbzwx

This would be terrific! In terms of speed and to make the transition between Mac to Windows easier!

I have been happily using QuickLook for years and consider it an essential part of my Windows workflow. It's open source, quite mature and available on GitHub. Perhaps it can be incorporated in the same manner as Wox has been utilized for PowerToys Run?

tracked in issue #80


WARNING: API 'variantOutput.getProcessResources()'

WARNING: API 'variantOutput.getProcessResources()' is obsolete and has been replaced with 'variantOutput.getProcessResourcesProvider()'.
It will be removed at the end of 2019.
For more information, see https://d.android.com/r/tools/task-configuration-avoidance.
To determine what is calling variantOutput.getProcessResources(), use -Pandroid.debug.obsoleteApi=true on the command line to display more information.
Affected Modules: app

Dupe of #1431

Dupe of #1431

After this
apply plugin: 'com.android.library'
ERROR: Android Gradle plugin 3.4.1 must not be applied to project 'E:\DelhiDarbar\app' since version 3.4.1 was already applied to this project
Open File
this occurs


GH-91: RabbitMQ Sink

Resolves #91
Also addresses https://jira.spring.io/browse/XD-2790

That's all from my side.

I'm fine to merge it, but there are several unanswered comments, which I won't do on merge silently.

Pushed

Merged as https://github.com/spring-cloud/spring-cloud-stream-modules/commit/4b9b5779ee8bdee9856d262797b70b03b5bac6de.
Any thoughts about the default * for AMQP adapters in SI?

Sure: https://jira.spring.io/browse/AMQP-588


fix: set default max retry for auto login

What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Set max retries (90) when waiting for login token, instead of waiting indefinitely for non-404 server error.
Also addresses a memory leak where closing http response reader is deferred on retry until program exit.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 19 (68.42%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.04%) to 60.115%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/login/login.go
13
19
68.42%

Files with Coverage Reduction
New Missed Lines
%

internal/storage/rm/rm.go
2
89.53%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
6903

Relevant Lines:
11483

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 19 (68.42%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 60.115%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/login/login.go
13
19
68.42%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
6903

Relevant Lines:
11483

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

16 of 22 (72.73%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.05%) to 60.125%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/login/login.go
16
22
72.73%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
6906

Relevant Lines:
11486

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

15 of 19 (78.95%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.05%) to 60.125%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/login/login.go
15
19
78.95%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
6903

Relevant Lines:
11481

💛  - Coveralls


*.aurp format documentation

Hey,
im looking into creating aurp on my own.
I wanted to ask wether there is any documentation available as my cpp skills are not the greatest.
Thanks!

Hi! Thanks for your question.
I didn't publish any documentation for aurp format, because it's supposed to be internal binary format for interaction between replay-mod and replayer. I didn't expect anyone else to use it. Moreover I don't really want to keep documentation up-to-date.
Please, tell me more about your task. If it's one-time task, I'll publish short description of current format version. If you want to develop your own aurp-generator, I should think how to deal with it.

Well, i wanted to add an plugin to https://github.com/AeonLucid/Impostor which generates file with that format to be played afterwards.

Sounds great!
I will publish some sort of documentation later.


Upgrade construct to 2.9.45

Description:
Commit log: https://github.com/construct/construct/commits/master
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

I will care about a construct update if python-miio 0.4.2 is released.

The construct requirement should be handled by python-miio and not HA. It seems that as long as the release is pinned by python-miio we need to take care about it because there are other platform around which requires construct.

Yes, HA should pin only requirements they are directly imported. We should remove the construct requirements inside HA, if the component don't import it self!

Last time python-eq3bt of components/climate/eq3btsmart.py has overruled the more specific pinning of python-miio wrongfully. The pinning at HA was introduced to avoid this issue.

xbox-smartglass-core is not a dependency we have at the moment (acc. to the requirements file).

It has not been merged yet, no. However, there is a HASS.io plugin for it: https://github.com/hunterjm/hassio-addons which is apparently also used by some: https://community.home-assistant.io/t/xbox-one-smartglass-integration/52796

We discussed about this and decided to remove the pinning for python-miio as things have stabilized. So starting from the next python-miio release there'll be no more pinning.

The version has been bumped, please update the PR :-)


Add logos - issue #102

What should be above the DDSA logo?

in principle only the main logo is needed for the application. So we would not need to provide all of the single logos in each copy of the repository.

Well, our main logos are ProteoBench, EuBIC-MS and EuPA. For the moment, these should be visible when people use the platform and when we make demos. So I think that this is good to have them on the side of the Module.

What should be above the DDSA logo?

The ProteoBench logo

So we need the for 4-5 logs in the side bar and the composite logo?

So we need the for 4-5 logs in the side bar and the composite logo?

Oups! I really did not think of dark theme... Is it OK for you if I create a single image with white background for the side-bar logos? Maybe I will remove the DDSA logo and keep only the ProteoBench, EuBIC-MS and EuPA.

@enryH : I have combined the sidebar logos together, and it now has a white background. It is definitely not ideal. All these logos (main page and module page) could look a lot better. But it is not a priority. The priority is to have the logos present somewhere when we do demos.

@mlocardpaulet, so this can ben merged for now?

I'd say yes.


Adding support for new JAva Sender API

@sebastienblanc @lfryc mind to review?
IMO Not ciritial if that does not go into beta.1 ....

:+1:

:+1:

landed on master (f0478685ffe04bb8646b906994540309c13924f0)


pandora in vps doesn't work

Describe the bug
I trying to deploy pandora in AWS EC2,but there is nothing output even a warning when i type in
I've modified the .env and settings .js make their ports consistent,and it work in cli
The chat close quickly,and it's the same as turning off the API
I used caddy for reverse proxy to my personal domain
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Node.js version (please complete the following information):

OS: debian11
Node.js v18.16.0
npm 9.5.1

Package version (please complete the following information):

[e.g. 1.33.0]

Additional context
Add any other context about the problem here.

More appropriate for a Help thread: https://github.com/waylaidwanderer/node-chatgpt-api/discussions/categories/help


Update logback-classic, logback-core to 1.4.13

About this PR
📦 Updates

ch.qos.logback:logback-classic
ch.qos.logback:logback-core

from 1.4.3 to 1.4.13
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "ch.qos.logback" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.321%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
390

Relevant Lines:
511

💛  - Coveralls

Superseded by #230.


API: change /j/tournaments/candidates/[0-9]+/? to /j/tournaments/[0-9]+/candidates/?

Done when reviewing gonawin style.


Fix resource links in README

Forgot to update the actual link locations when we changed the resource names :)

@EMH333 please add a changelog entry for this.

Released as: 2.0.1


Added accurancy option to:

bboxToCenter
lngLatToMeters
metersToLngLat
pixelsToMeters

@finkj I've updated this PR with the following changes
accuracy param => decimal
https://github.com/DenisCarriere/global-mercator/commit/27d9d6e9ee6d7924c14fcc71ffcf1a45a5887c84

published new NPM release v3.1.0


Unable to retreive API keys for eventhub namespace using CLI

Describe the bug
Unable to retreive API keys for eventhubs namespace using CLI.
Command Name
az eventhubs namespace authorization-rule keys list
Errors:
400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 608, in execute
    raise ex
cli/core/commands/__init__.py, ln 666, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 659, in _run_job
    six.reraise(*sys.exc_info())
...
python3.6/site-packages/msrestazure/azure_active_directory.py, ln 486, in get_msi_token
    result.raise_for_status()
python3.6/site-packages/requests/models.py, ln 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Create namespace using CLI
az eventhubs namespace authorization-rule keys list --name {} --namespace-name {}

Expected Behavior
Environment Summary
Linux-4.15.0-1064-azure-x86_64-with-debian-stretch-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.78

Additional Context
Error occured when using the cloud shell provided in the following exercise - https://docs.microsoft.com/en-us/learn/modules/enable-reliable-messaging-for-big-data-apps-using-event-hubs/3-exercise-create-an-event-hub-using-azure-cli
Browser is Brave Browser version 1.1.23 (Latest).

@mkyukov, we were not able to reproduce at our end. we are getting the keys . Can you please send the command you are using (without the parameter values)


mamba: error: unrecognized arguments: --force

Something seems to have changed about the --force argument of mamba causing an error during our installation script. See e.g. https://github.com/neuro-conda/neuro-conda/actions/runs/9209582797/job/25334525737?pr=48

Recent versions of conda use libmamba as default solver - maybe we should get rid of mamba at all? The official recommendation is to not use mamba with existing conda installations but rely on miniforge instead.

Interesting. I suppose that warrants switching to miniforge. Rename the project to neuro-forge? ;-)


Wrong condition in transition is hard to maintain

State may contain many transitions. Condition lambda helps to choose correct one. But is easy to make a mistake and have multiple transitions for current event, which is wrong.
Make a State to choose next state may be a better solution. As it should be simpler to make a decision where to go in one place, rather than in may separated lambdas.

solved with adding condtional transitions.


Upload from different apps and shared db

I've 2 different apps that share database, when I upload a file in one of those apps I get this error on the other one:
Error: ENOENT, open '/home/action/workspace/myapp1/.meteor/local/cfs/files/_tempstore/files-0D6C3120-9BB6-4D5C-A255-CD928D64983C-0.chunk'

It's trying to upload the file I'm uploading from a different server.
Any idea on how can I make this work?
Thanks!

No ideas? Any option of changing chunks collection name in different servers, maybe that fixes it.

Have you tried defining a different tempstore for each of the apps?

Also check this thread for more context
https://github.com/CollectionFS/Meteor-CollectionFS/issues/510

How can I set different tempstores? I think the problem could be related to graphics magic.

More info:

It only seem to happen with files that should be chunked (> 2mb)
It's related to the chunks collection in mongo, after upload document isn't removed
It happens when the file upload has ended on the origin app

It would be best to create a minimal repo to demonstrate the error

Ok, here it is:
https://github.com/bitomule/CollectionFS-BugTest
You'll need:

Amazon S3 keys or changing it to GridFS adapter
Use shared mongodb (I've used sandbox from compose.io)
2 different copies of the app in 2 different folders

Then run both in different ports, upload in one and the other crashes.
Hope this can help finding the issue.

I've seen this error when using the function transformWrite for incorrect images (text/plain instead of image/*)

@for2ne no, that's not the problem. The problem it's trying to read the file from local storage but file isn't there in app2. It's only in app1.

This needs the changes we are working on in https://github.com/CollectionFS/Meteor-CollectionFS/issues/214 to handle multiple instances sharing the same collection, as there are direct fsCollection observers in both apps and trying to run the same action.
Sorry but I don't see a way around this apart from hacking an interim solution, or maybe lookout in the linked thread for a dev branch to use (at your own risk).


Use curl to comment on a PR

Jenkins job istio-testing/pr-master passed

Jenkins job istio-testing/pr-master passed

Fixes #64


EDIT_WAIT_SECONDS Doesn't work

This option doesn't seem to work, After I set it up, it will still edit quickly until Too Many Request is triggered when a large piece of text is encountered.
Like this:
2022/12/11 04:33:36 Couldn't edit message: Too Many Requests: retry after 237
2022/12/11 04:33:36 Couldn't edit message: Too Many Requests: retry after 236
2022/12/11 04:33:36 Couldn't edit message: Too Many Requests: retry after 236
2022/12/11 04:33:37 Couldn't perform final edit on message: Too Many Requests: retry after 236

This is making the bot unusable!  It gets to two sentences of output and then I get nothing but "Couldn't edit message: Too Many Requests" and have to restart the terminal program.  Is there any solution for this?  The EDIT_WAIT_SECONDS variable can be set from the default 1 to 30 seconds and these Too Many Requests errors don't stop.

Released a new version with a fix


Drop label character restrictions

e7cb84b1d9049c1d3674fcb31e990d6af12e3360 and then d6766de7bec9b3335589d73aae4ea7e6130ab29e dramatically expanded the range of valid label characters, but many potentially-special characters are still excluded (e.g., {). This is a gap with respect to Graphviz DOT (cf. #5), and an annoying one for representing certain kinds of structured data. It would be convenient to follow the lead of CSS, expanding the syntax allowed inside of […] to allow quoted strings in addition to identifiers.

That would be nice! I can be tricky though. I think that the grammar probably needs some refactoring it has been updated for various issues and has become a bit unruly.
The syntax makes sense. Characters within quotes should be accepted as is.

Added support for quoted text without restrictions on characters. This is pushed in to dev-0.5-0 branch and will be included in the next release.

A fix for this has been released in version 0.5.0


Evaluate multiple arguments using pytest parameterized

This is an initial attempt to improve test coverage by evaluating multiple arguments. This is achieved by using @pytest.mark.parameterized .
Currently the dtypes being tested are:
uint32, int16, float32, float64, int8, int16, int32, double
And the following are skipped for now:
uint8, uint16

note: this would close #527

It looks like the PR Circle CI test is failing due to #537 :
hub.exceptions.NotHubDatasetToOverwriteException: Unable to overwrite the dataset. The provided directory is not empty and doesn't contain information about any Hub Dataset. This is a safety check so it won't be possible to overwrite (delete) any folder other than Dataset folder. If this error persists in case of Dataset folder then it means your Dataset data is corrupted. In that case feel free to create an issue in here https://github.com/activeloopai/Hub

hub/api/dataset.py:307: NotHubDatasetToOverwriteException


Add constants and metadata properties for MergeRollupTask:

Part of #2715, add constants and metadata based on updated design:

Add setter/getter method for merge/rollup watermarks of each granularity.
Add task config related constants in MinionConstants, create until functions to get rollup aggregation configs and merge constraints.
Add MergeRollupTask.bucketGranularity constant which will be used in customMap of SegmentMetadata.

@Jackie-Jiang @snleee

Codecov Report

Merging #6932 (f281a03) into master (5b7023a) will decrease coverage by 8.10%.
The diff coverage is 13.00%.

@@             Coverage Diff              @@
##             master    #6932      +/-   ##
============================================
- Coverage     73.53%   65.43%   -8.11%
  Complexity       12       12
============================================
  Files          1431     1433       +2
  Lines         70621    70704      +83
  Branches      10220    10231      +11
============================================
- Hits          51934    46266    -5668
- Misses        15255    21138    +5883
+ Partials       3432     3300     -132

Flag
Coverage Δ
Complexity Δ

integration
?
?

unittests
65.43% <13.00%> (-0.05%)
12.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7023a...f281a03. Read the comment docs.


Add get last method for HttpHeaders and QueryParams

Motivation: Close https://github.com/line/armeria/issues/3438
Modifications:

Add getLastXxx for all getXxx

Didn't change the impl to use cyclic, getLast is finding the 1st in the entries.


iOs - Hide status bar

Is there a way to hide the status bar while viewing a file on ios?
In my app the status bar is always hidden. When I open a PDF with this modules, the status bar shows up and then stays present in my app after I close the file preview. Any ideas?
Thanks

Hi @paulintrognon,
The problem should be fixed now.
Upgrade the library to version 1.0.6 and let me know!

Thank you so much yeah it's working!
Just one think, didn't you forget to update the index.d.ts file to take in account the new options?

right! I will fix it soon, thank you. In the meanwhile passing a string as it was before should work as well (I kept it for retro compatibility).

Not sure that worked ; I had an exception after I updated, I had to rewrite the options to the new format for it to work, unsure of why though, as I know nothing about native code and plugins...


Make branch instructions offset program counter by delta (PR)

Implements https://github.com/paritytech/wasmi/issues/473.
This PR also introduces the LabelRegistry abstraction that helps build up BranchParams during compilation of a Wasm program lazily. The new LabelRegistry makes it possible to reuse more heap allocated memory than was possible before for some significant speedups in the range of 5-6%.
Merging this PR will allow us to improve and optimize the wasmi bytecode executor instruction pointer.

CRITERION BENCHMARKS

BENCHMARK
MASTER
PR
Diff

execute/count_until
2.9906 ms
2.0933 ms
:green_circle:  -29.6994 %

execute/factorial_iterative
1.6939 µs
1.6906 µs
:white_circle:  -0.4527 %

execute/factorial_recursive
2.1698 µs
2.2523 µs
:red_circle:  +3.6091 %

execute/fib_iterative
10.0177 ms
10.1768 ms
:red_circle:  +1.538 %

execute/fib_recursive
20.162 ms
20.3398 ms
:white_circle:  +2.9601 %

execute/global_bump
3.8743 ms
3.8788 ms
:white_circle:  +0.8862 %

execute/host_calls
35.199 µs
35.289 µs
:white_circle:  +0.1629 %

execute/memory_fill
9.6059 ms
9.4714 ms
:green_circle:  -1.4387 %

execute/memory_sum
8.936 ms
9.1536 ms
:red_circle:  +2.0802 %

execute/memory_vec_add
16.2899 ms
16.0515 ms
:green_circle:  -1.4358 %

execute/recursive_is_even
3.0268 ms
3.4799 ms
:red_circle:  +15.1549 %

execute/recursive_ok
400.3464 µs
404.3556 µs
:red_circle:  +1.173 %

execute/recursive_scan
521.3401 µs
525.0779 µs
:white_circle:  +1.2001 %

execute/recursive_trap
39.4454 µs
39.191 µs
:white_circle:  -0.2656 %

execute/regex_redux
3.5059 ms
3.5141 ms
:white_circle:  +0.2042 %

execute/rev_complement
3.1175 ms
3.152 ms
:white_circle:  +1.1066 %

execute/tiny_keccak
2.6528 ms
2.6629 ms
:white_circle:  +0.5881 %

execute/trunc_f2i
3.7356 ms
3.6933 ms
:green_circle:  -1.1158 %

instantiate/wasm_kernel
77.9787 µs
76.5876 µs
:white_circle:  -1.7787 %

translate/wasm_kernel
6.3957 ms
6.071 ms
:green_circle:  -5.1247 %

Link to pipeline

Codecov Report

Merging #478 (b2d609a) into master (5ce1d4f) will increase coverage by 0.08%.
The diff coverage is 86.88%.

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
+ Coverage   79.15%   79.24%   +0.08%
==========================================
  Files          73       74       +1
  Lines        6255     6296      +41
==========================================
+ Hits         4951     4989      +38
- Misses       1304     1307       +3

Impacted Files
Coverage Δ

crates/wasmi/src/engine/bytecode/tests.rs
100.00% <ø> (ø)

crates/wasmi/src/engine/mod.rs
83.49% <ø> (ø)

crates/wasmi/src/engine/func_builder/labels.rs
70.90% <70.90%> (ø)

...ates/wasmi/src/engine/func_builder/inst_builder.rs
78.43% <78.78%> (+4.51%)
:arrow_up:

crates/wasmi/src/engine/bytecode/utils.rs
76.27% <95.45%> (+7.52%)
:arrow_up:

crates/wasmi/src/engine/bytecode/mod.rs
100.00% <100.00%> (ø)

crates/wasmi/src/engine/executor.rs
98.41% <100.00%> (ø)

...tes/wasmi/src/engine/func_builder/control_frame.rs
90.00% <100.00%> (ø)

crates/wasmi/src/engine/func_builder/mod.rs
89.43% <100.00%> (+0.52%)
:arrow_up:

crates/wasmi/src/module/tests.rs
98.66% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Loop constructs

Loop constructs such as while, for, and do...while.

Created while loop in 7bbe3a7aaee58f5660e5e686c2f3bbc4eb601561

Created do...while loop in 7bbe3a7aaee58f5660e5e686c2f3bbc4eb601561

Not implementing for loops for now due to some issues with statements/expressions.


Feat: generate plugin options docs

This PR adds a script which generates plugin options docs.

This is ready for review!
btw @mxstbr you might find this interesting. I'm using your plugin options schema API to generate our plugin options documentation https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/8f51f075b44ee22564cf94c599454dd25ea75eda/docs/plugin-options.md
It used to be manually maintained 😱
https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/master/docs/plugin-options.md

This is ready for review!
btw @mxstbr you might find this interesting. I'm using your plugin options schema API to generate our plugin options documentation https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/8f51f075b44ee22564cf94c599454dd25ea75eda/docs/plugin-options.md
It used to be manually maintained 😱
https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/master/docs/plugin-options.md

Thanks @jasonbahl and good call on automation. I left it out for now because I'm not 100% sure what that'll look like in the Gatsby monorepo.

Thanks @jasonbahl and good call on automation. I left it out for now because I'm not 100% sure what that'll look like in the Gatsby monorepo.

Ah ya. . .monorepo 😬

Ah ya. . .monorepo 😬


Perl interpreter does not bundle unicore/PVA.pl

From @GoogleCodeExporter on May 31, 2015 11:29
I have installed SL4A r4 and Perl 5.10.1, created this script and attempted to
run it:

use Android;
my $a = Android->new;
print $a->smsGetMessages(0);

The script fails with message "Can't locate unicore/PVA.pl in @INC".

As the above script consists of nothing more than one API call provided by
SL4A, this suggests that the Perl interpreter is not shipped with all required
core modules.

What device(s) are you experiencing the problem on?

HTC Desire GSM (rooted)

What firmware version are you running on the device?

CyanogenMod <IP_ADDRESS> (Desire)

What steps will reproduce the problem?
1. install SL4A and Perl interpreter
2. create and run script specified above
3. observe error

What is the expected output? What do you see instead?

Error message seen as specified above; some other form of output not involving
missing Perl modules expected.

What version of the product are you using? On what operating system?

See above.

Please provide any additional information below.

N/A

Original issue reported on code.google.com by alex.peters on 1 Jun 2011 at 4:36
Copied from original issue: damonkohler/android-scripting#550

From @GoogleCodeExporter on May 31, 2015 11:29
Others have experienced this problem in different circumstances as evidenced by
this discussion thread:

https://groups.google.com/d/topic/android-scripting/jCfZe2zpdXE/discussion

One suggested workaround is to manually copy core Perl modules from another
Perl installation if available, but such an installation is not available to me
and in any case seems somewhat kludgey.

Original comment by alex.peters on 1 Jun 2011 at 4:40


Allow server boot script to specify a non-default URL for startup

Follow up item from #1116
The server boot script is hardcoded to use /_blazor as its URL for connected to SignalR. We should allow the developer to specify this URL. This will also be needed when the application has a base path.

It was changed to _blazor so it's now relative to the <base href> like everything else.


Undefined returned from homedir() call passed unto path.join at top level

My issue exactly: I am using this module on a NodeJS Server and I get this error
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined at validateString (internal/validators.js:124:11)     at Object.join (path.js:1039:7)     at eval (webpack://mms-frontend-service/./node_modules/mydockerjs/lib/utils.js?:14:26)
I am using this on Linux so, I maybe understand why this happened on this line. Please check this out, also I would submit a PR of the fix for the sake of linux users.

Hi @whizyrel , could you give me more information about the nodejs version , homedir version and used operating system when the issue occurred? Which user is running the code? If you understand the issue, could you give me more details please ? Thank you

Nodejs: 14.16.0
Homedir: 0.6.0
OS: linux 20.04 LTS
user: non-root user
Thank you for your quick response.
Like I said I am running a NodeJS server where I am using this module. I get that TypeError because homedir() returns undefined like so path.join(homedir(), ...) on line 13. It also seem like a issue from homedir() since it is supposed to return the user home path on LInux and Windows.

Ok, I think that this is related with an external library, homedir.
https://github.com/wilmoore/node-homedir/blob/master/index.js
If you look at the code, the module tries to get home path by using HOME environment variable:

Could you check if your username has env HOME defined?
echo $HOME

In any case, this is related with toolboxPath, a variable that I never use in the code, as I was trying to implement windows docker toolbox support, but I unfortunately did not have too much time to implement it :-). As it is used for Windows purposes, we can check if the process platform is win32 and use it only if it is the case.

If you are able to pull request me this fix, I really appreciate it. Thank you

Yes, I mentioned it seem like a homedir bug caused it, and it does have a $HOME defined.
I figured process.env['HOME'] does return the path when it is not running as a server otherwise it returns undefined.
While it seem like a homedir issue, it actually is not.
So, I use webpack and did not include all of the env vars completely only those I defined.
To solve this issue when someone else does the same thing I did, I could PR. Also, an example of including all env vars in webpack config would be using EnvironmentPlugin and not DefinePlugin which is a popular choice
An example Webpack issue
...
plugins: [
   new webpack.EnvironmentPlugin([...Object.keys(process.env)])
]
...

Let me know what you think


Column with Boolean type and null values

I am trying to use aws wrangler library to query glue data catalog.
I have trouble with Boolean Type Columns with Null Values in it.
I am issuing a sql statement and loading the data into a dataframe.
df = session.pandas.read_sql_athena(sql=query,database=dname)
ValueError: Bool column has NA values in column 7.
I am also including the log for this.
Can you please suggest if there is a way to get around this?
I downloaded the results of the query from athena as a csv and tried loading it into a dataframe and it worked without any issues.
File "/usr/local/lib/python3.6/runpy.py", line 263, in run_path
pkg_name=pkg_name, script_name=fname)
File "/usr/local/lib/python3.6/runpy.py", line 96, in _run_module_code
mod_name, mod_spec, pkg_name, script_name)
File "/usr/local/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/tmp/glue-python-scripts-vd0482dz/SplittingDataFrame.py", line 175, in
File "/glue/lib/installation/awswrangler/pandas.py", line 447, in read_sql_athena
max_result_size=max_result_size)
File "/glue/lib/installation/awswrangler/pandas.py", line 133, in read_csv
converters=converters)
File "/glue/lib/installation/awswrangler/pandas.py", line 414, in _read_csv_once
converters=converters,
File "/glue/lib/installation/pandas/io/parsers.py", line 685, in parser_f
return _read(filepath_or_buffer, kwds)
File "/glue/lib/installation/pandas/io/parsers.py", line 463, in _read
data = parser.read(nrows)
File "/glue/lib/installation/pandas/io/parsers.py", line 1154, in read
ret = self._engine.read(nrows)
File "/glue/lib/installation/pandas/io/parsers.py", line 2059, in read
data = self._reader.read(nrows)
File "pandas/_libs/parsers.pyx", line 881, in pandas._libs.parsers.TextReader.read
File "pandas/_libs/parsers.pyx", line 896, in pandas._libs.parsers.TextReader._read_low_memory
File "pandas/_libs/parsers.pyx", line 973, in pandas._libs.parsers.TextReader._read_rows
File "pandas/_libs/parsers.pyx", line 1105, in pandas._libs.parsers.TextReader._convert_column_data
File "pandas/_libs/parsers.pyx", line 1136, in pandas._libs.parsers.TextReader._convert_tokens
File "pandas/_libs/parsers.pyx", line 1257, in pandas._libs.parsers.TextReader._convert_with_dtype
ValueError: Bool column has NA values in column 7

I was using version  0.0.15 earlier.
Just saw version 0.0.17 fixed this.
Thank you :)

Hey @hhsurap ! Thanks for report that!
Pandas doesn't allow null for bool columns, but we already worked around this!
Please, don't hesitate to open more issues if you find something strange.


[Event Request] Codeunit 80 - Procedure CheckAndUpdate - Set SrcCode

Hi,
For some of our ISVs or custom developments, in some cases,
We need to post Sales Invoices or Sales Cr.Memos with another Source Code than the one set in Source Code Setup.
In order to do that,
In the Codeunit 80, Procedure CheckAndUpdate, can you add an event to update the source code like this:
local procedure CheckAndUpdate(var SalesHeader: Record "Sales Header")
...
begin
    with SalesHeader do begin
        ...
        SourceCodeSetup.Get;
        SrcCode := SourceCodeSetup.Sales;
        // >>NEW
        OnAfterSetSrcCode(SrcCode, SourceCodeSetup, SalesHeader);
        // <<NEW
        ...
    end;
    ...
end;

[IntegrationEvent(false, false)]
local procedure OnAfterSetSrcCode(var SrcCode: Code[10]; SourceCodeSetup: Record "Source Code Setup"; SalesHeader: Record "Sales Header")
begin
end;

Thanks.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


How to insert comment or fragment in sql?

Such as select name from user /* shard_id=1 */ where name like 'can%', the shard_id comment is to tell the database proxy how to route to the sharded database.
Suggest: SELECT(User.Name).FROM(User).FRAG(FRAG("/* shard_id=1 */").BeforeWhere()).WHERE(...)

Hi @canuran
Can you use optimizer hints instead?

Hi @canuran Can you use optimizer hints instead?

It seems impossible, optimizer_hints can only be used for mysql and the format is fixed, not suitable for prompting db proxy.

Is there any way to do this with the latest version?

No, it is not possible.

@dragondgold Is your use case the same as the OP? Comment before WHERE or after FROM? What proxy is this?

@dragondgold Is your use case the same as the OP? Comment before WHERE or after FROM? What proxy is this?

My usecase is actually for tracing. I would like to add comment just before the query with a trace ID


devon/wtf → develop

Legendary weapons are now properly assigned the Attackable attribute @DewsDavid31
Fixed the load bug where items would lose their Usable state
Fixed the load bug that was improperly stripping .yml off the end of file names
Updated examine to exclude hero
Fixed player names @zanguian

Codecov Report

Merging #87 into develop will decrease coverage by 1.58%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop     #87      +/-   ##
==========================================
- Coverage    98.69%   97.1%   -1.59%
==========================================
  Files            7       7
  Lines          688     692       +4
  Branches       111     113       +2
==========================================
- Hits           679     672       -7
- Misses           5      16      +11
  Partials         4       4

Impacted Files
Coverage Δ

dork/types.py
95.74% <100%> (-2.45%)
:arrow_down:

dork/game_utils/world_builder.py
99.38% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be96438...7196987. Read the comment docs.

Look good, should be easy to add more tests now if there is time


Add runnable examples, and fix zlib writing with libflate

There's several small things accomplished in this PR - if it's easier to split them each into their own PR to make it easier to review I'd be happy to do that!
This PR:

Adds reading/writing in an examples/ folder so you can them easily with cargo run --example reading.
Updates the reading example since it seems to be out of date swf.num_frames -> swf.header.num_frames.
Fixes a case where writing with Zlib compression produced invalid SWFs (possibly only on slower machines?)

The first two are straightforward, so let me elaborate on the last one.
Writing an SWF with Zlib compression produced an invalid SWF
I encountered this when I copied the "Writing" example from the README and tried to run it. I expected a red background, but got white instead when opening it with Flash Player. I discovered this was an invalid file when I tried to read it back with swf-rs.
Looking at the bytes, it was a suspiciously small file:
4357 5306 1d00 0000 789c

Everything up to 789c is the header, so I thought it was strange that the body (2 tags) could all fit in one byte. The only way I could get this example to produce a valid SWF is if I changed Compression::Zlib to Compression::None.
I eventually noticed that the examples for both libflate and flate2 include a finish() call. Adding this fixed it, producing a valid SWF.
So the first byte here is actually the first byte of the body, so I can imagine how many bytes it writes out might depend on the system (so faster systems may not notice this bug)?
I only ran into this issue with libflate, but I added the finish() call to to the flate2 function as well for consistency here.

I also added SimpleRedBackground.swf so that both examples can be readily runnable, and so that people don't accidentally push the generated SWF from running this example.

Great, thank you!


fix: Make correct use of the recursion tracker when loading entity liveAssets

Fixes #607

This is a start, but there's one issue left, the recursionTracker.getLiveAsset callback clones children once they are loaded. But when the callback is fires that doesn't necessarily mean the entity has fully loaded yet.


21730- added pinned fields for connection

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.


Dynamic rate limit for pinot brokers

This PR uses dynamic rate limit for pinot brokers.
Basically dynamic per broker rate  = overall rate / number of online brokers.
If # of online brokers is changed, BrokerResourceOnlineOfflineStateModelFactory will update rate for a particular table.
If overall rate is changed, ClusterChangeMediator will capture the broker resourceEV change, and then update all the per broker rates with the latest qps quotas.

whats the motivation behind this change? If we simply divide total qps/number of online brokers, we will probably bring down the healthy brokers as well and potentially impact other use cases. Can we compute some kind of max possible qps per broker automatically and set that as the max qps and start throttling after that?.

@kishoreg The motivation is that users don't know how many brokers are serving their tables behind the scene. If one broker goes down, overall qps quota can be shared across the rest of the brokers. So that from users' view, pinot cluster can provide fix overall rate.
If we use fixed rate for each broker, when one broker goes down, overall rate goes down as well. Since requests get throttled, users will notice the decrease of qps, which's not what they want.
I think the strategy you mention would be total qps / number of replicas(correct me if I'm wrong), which is a fixed rate. So it falls into the 2nd case.
And yeah, it'd be great to have more discussions on this.

max_qps/replicas will be the minimum peak qps a broker will serve when all brokers are up. My suggestion is we should also find a max. With your PR max will be max_qps/1 and this might bring down the server or the queries will be timing out. Conceptually, max_qps a broker can handle is the highest qps at which a broker can still meet the SLA.

Codecov Report

Merging #2922 into master will increase coverage by 0.01%.
The diff coverage is 41.3%.

@@            Coverage Diff             @@
##           master    #2922      +/-   ##
==========================================
+ Coverage   69.15%   69.17%   +0.01%
==========================================
  Files         914      914
  Lines       43417    43458      +41
  Branches     5922     5930       +8
==========================================
+ Hits        30027    30060      +33
- Misses      11369    11376       +7
- Partials     2021     2022       +1

Impacted Files
Coverage Δ

...inot/broker/queryquota/TableQueryQuotaManager.java
66.14% <40.9%> (-13.41%)
:arrow_down:

...not/broker/broker/helix/ClusterChangeMediator.java
62.9% <50%> (-0.44%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
80% <0%> (-13.34%)
:arrow_down:

.../impl/dictionary/LongOffHeapMutableDictionary.java
81.81% <0%> (-5.46%)
:arrow_down:

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
70.9% <0%> (-3.64%)
:arrow_down:

...e/operator/dociditerators/BitmapDocIdIterator.java
60.71% <0%> (-3.58%)
:arrow_down:

...lix/core/realtime/PinotRealtimeSegmentManager.java
73.54% <0%> (-2.65%)
:arrow_down:

...inot/core/operator/docidsets/AndBlockDocIdSet.java
55.86% <0%> (-2.07%)
:arrow_down:

.../pinot/core/common/datatable/DataTableBuilder.java
78.82% <0%> (-1.18%)
:arrow_down:

...not/transport/scattergather/ScatterGatherImpl.java
55.06% <0%> (-0.64%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c59879...c1a7c87. Read the comment docs.

@kishoreg Gotcha! We can bring in a factor. The max_qps can be calculated from min_qps multipled by this factor. The ideal situation is that all replicas are up and each broker'd use the min_qps quota. If some replicas go down, the qps rate should not exceed max_qps.

@kishoreg I think what you are saying is that a single broker must have some upper limit of qps on a table. That is fine, except that we should ensure that when the client exceeds qps we return 429, but when the broker is overloaded, we return 503. Also, to implement means that we need one more config for each table. Maybe this can be a broker config as a percentage? (so, it will translate to some percentage of overall qps as the max handled by a single broker)

I found an article from Stripe. Seems they have more strategies on rate limit.
https://stripe.com/blog/rate-limiters


http-client-java, support client parameter to client

This is only part of the support for https://github.com/Azure/autorest.java/issues/2428

No changes needing a change description found.

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Replace posix-ipc by the shm from Python standard library

A blocker to this proposal is that multiprocessing.shared_memory does not provide access to the underlying file descriptor in its API.
We could try accessing the internal _fd though... :thinking:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.466%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1758

Relevant Lines:
1965

💛  - Coveralls

No noticeable impact on performance :+1:


chore: update fresh.gen.ts and fix manifest generation

Hey @marvinhagemeister, your change in #2082 broke the functionality introduced in #1986. You can see the type checking failures here, now that I've generated the new manifests for all the fixtures.
In particular the manifest now looks like:
"./islands/MultipleCounters.tsx": $MultipleCounters,

but it really needs to be the original
"./islands/MultipleCounters.tsx": {
      CounterOne: $$MultipleCounters.CounterOne,
      CounterTwo: $$MultipleCounters.CounterTwo,
      default: $$MultipleCounters.default,
    },

or something similar. I thought relying on type checking would be enough to prevent regressions, but that's obviously not true. The gap to be filled is that we should always regenerate all manifest files when changing manifest.ts. (Your change snuck through because you didn't regenerate fixture/fresh.gen.ts.)
I'll open this as a draft for now, since it's late. Feel free to collaborate if you're feeling eager, otherwise I hope to get to this again tomorrow. (Right before basePath!)

e.g.
error: TS2322 [ERROR]: Type 'typeof import("file:///Users/runner/work/fresh/fresh/tests/fixture/islands/MultipleCounters.tsx")' is not assignable to type 'IslandModule'.
  Property 'thisShouldNotCauseProblems' is incompatible with index signature.
    Type 'number' is not assignable to type 'ComponentType<any>'.
    "./islands/MultipleCounters.tsx": $MultipleCounters,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    at file:///Users/runner/work/fresh/fresh/tests/fixture/fresh.gen.ts:202:5

The other thing to do here is to finish my script so it's less hacky, and to add a new task to deno.json. Bonus points if the script runs as part of the ok task, but only if manifest.ts has changed. (Or something like that. I'll think about it more tomorrow.)

The init tests now fail with the --no-config option, since we can't import the files anymore. I haven't looked to closely at how to work around this, but it seems like we might be able to split it up into two parts:

create deno.json with --no-config
do everything else using this newly created file

+1 On adding a script to update all manifest files of test fixtures.
Regarding the manifest itself: The crux of the problem is that we must not import any "user" code during manifest generation because that can import files which contain mappings from the user's import map.  It breaks even for imports referencing just "preact". The importLine code imports the actual island/route files to check if exports are a function and that breaks the init script.
For the typing issue we should just loosen the manifest file type. It's a file completely generated by us and not modified by the user in any way. It's an internal implementation detail and we want to get rid of it anyways in the long term.

When I run deno run -A ../fresh/init.ts new_manifest I don't have any issues. What's the issue?
I'll look into an alternate approach that avoids importing anything, just to see if it's feasible.

It broke when I pointed it to the raw github URL like
deno run -A https://raw.githubusercontent.com/denoland/fresh/9450d9d62b5abf67a4c029e468363f563d3978fe/init.ts

It seems to work now though which makes me less sure of my initial assessment. Maybe I interpreted the symptoms wrong and it was caused by something else :S The tests with the --no-config flag reproduce that exact scenario. For as long as the CI is green we should be good.

Fix for the twind test https://github.com/denoland/fresh/pull/2100 . The way we bundle the twind options into the client bundle is super hacky.

Should I redo this to just provide the "generate all the manifests" functionality?


Some interfaces are very slow

StopContinuousRecognitionAsync、Recognized and EndpointId too slow
The following nodes take a particularly long time to execute
1、When I added EndPointId to my Speech, I sometimes found it took too long to trigger after the user had spoken the Speech command  Recognized event
2、When I try to _budBotService.SpeechRecognizer.StopContinuousRecognitionAsync().Wait();
This function takes about 5 seconds,it's too slow.
3、Is there a way to trigger  Recognized events quickly when I'm not talking,Sometimes I stopped talking for 5 or 6 seconds before the system triggered the corresponding event
My Code like this:

Version of the Cognitive Services Speech SDK
Microsoft.CognitiveServices.Speech   1,19
windows X64
C#
this is my log
speechLog.txt
thanks.

Hi @AlexRen01,
Thank you for reaching out. Looking at your code the one thing that does stand up is the call to Wait inside the callback. We don't recommend running blocking operations inside callbacks as it will prevent you from receiving further events. Can you try calling it as fire and forget (_ = reco.StopContinuousRecognitionAsync()).
Thanks

Just to supplement the note from @glecaros : I reproduce the same blocking behavior (it's approximately ten seconds) using .Wait() inside of Recognized, but that problem goes away with either recommended approach:

Fire and forget (_ = reco.StopContinuousRecognitionAsync())
Awaiting (await reco.StopContinuousRecognitionAsync())

Fundamentally, the problem is that the SDK needs to synchronize the order of events and that means it needs the event thread back. Wait() holds this thread and stops the Recognized event from finishing, which in turn prevents Stop from proceeding quickly.

嗨@AlexRen01，
感谢您伸出援手。查看您的代码，唯一站得住脚的是在回调中调用 Wait 。我们不建议在回调中运行阻塞操作，因为它会阻止您接收更多事件。你能不能试着把它叫做火而忘记（_ = reco.StopContinuousRecognitionAsync()）。
谢谢
Hi @glecaros
Thank you for your suggestion. I'll try it. However, in addition to stop continuous recognition async, I have another problem:

When I add endpoints to speech recognition, it often happens that the request takes too long.
For the same voice data, they are as follows:
With endpoints (100 tests):
Average time: more than 6000ms
Maximum request time: 40 seconds
Ten of these requests took more than 10 seconds
No endpoint (100 tests):
Average time: about 2000ms
Maximum request time: 4 seconds

Just to supplement the note from @glecaros : I reproduce the same blocking behavior (it's approximately ten seconds) using .Wait() inside of Recognized, but that problem goes away with either recommended approach:

Fire and forget (_ = reco.StopContinuousRecognitionAsync())
Awaiting (await reco.StopContinuousRecognitionAsync())

Fundamentally, the problem is that the SDK needs to synchronize the order of events and that means it needs the event thread back. Wait() holds this thread and stops the Recognized event from finishing, which in turn prevents Stop from proceeding quickly.

Hi @trrwilson :
Thank you for your suggestion. I'll try it. However, in addition to stop continuous recognition async, I have another problem:
When I add endpoints to speech recognition, it often happens that the request takes too long.
For the same voice data, they are as follows:
With endpoints (100 tests):
Average time: more than 6000ms
Maximum request time: 40 seconds
Ten of these requests took more than 10 seconds
No endpoint (100 tests):
Average time: about 2000ms
Maximum request time: 4 seconds

Can you please share a log or a session id of a case when you hit the slowdown?

Can you please share a log or a session id of a case when you hit the slowdown?
This is the log of my request. In this request, after I finished speaking, the interface waited for about 5S before giving me feedback
speechLog.txt

@AlexRen01 From the log - first there's a single-shot recognition session of 1.4 seconds, probably not a problem:
[651026]: 83909ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1277 [000001F35C5C3930]CSpxAudioStreamSession::FireSessionStartedEvent: Firing SessionStarted event: SessionId: 8daee769e55d406da447dd7163dbcc03
[651026]: 83911ms SPX_TRACE_INFO:  uspimpl.cpp:687 connectionUrl=wss://chinaeast2.stt.speech.azure.cn/speech/recognition/interactive/cognitiveservices/v1?language=zh-CN
[651026]: 84041ms SPX_TRACE_INFO:  uspimpl.cpp:1028 TS:131, OnConnected: connection:0x5c6e4a10
[651026]: 84051ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5C3930]CSpxAudioStreamSession::FireConnectionMessageReceived; path=turn.start
[651026]: 84980ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5C3930]CSpxAudioStreamSession::FireConnectionMessageReceived; path=speech.startDetected
[651026]: 84980ms SPX_DBG_TRACE_VERBOSE:  usp_reco_engine_adapter.cpp:1321 Response: Speech.StartDetected message. Speech starts at offset 8700000 (100ns).
...
[651026]: 85299ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5C3930]CSpxAudioStreamSession::FireConnectionMessageReceived; path=speech.phrase
[651026]: 85299ms SPX_DBG_TRACE_VERBOSE:  usp_reco_engine_adapter.cpp:1627 Response: Speech.Phrase message. Status: 0, Text: 小威小威。, starts at 8700000, with duration 7500000 (100ns).
[651026]: 85299ms SPX_DBG_TRACE_VERBOSE:  named_properties.h:363 ISpxPropertyBagImpl::SetStringValue: this=0x000001F35C5D51A0; name='RESULT-RecognitionLatencyMs'; value='1268'
[651026]: 85299ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5C3930]CSpxAudioStreamSession::FireConnectionMessageReceived; path=turn.end
[651026]: 85300ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1292 [000001F35C5C3930]CSpxAudioStreamSession::FireSessionStoppedEvent: Firing SessionStopped event: SessionId: 8daee769e55d406da447dd7163dbcc03

Then there's a session of continuous recognition. In more detail...
[68939]: 87373ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1277 [000001F35C5F45B0]CSpxAudioStreamSession::FireSessionStartedEvent: Firing SessionStarted event: SessionId: 712106e138ac4ccbb9cfb416a4fd3c48
[68939]: 87378ms SPX_TRACE_INFO:  uspimpl.cpp:687 connectionUrl=wss://chinaeast2.stt.speech.azure.cn/speech/recognition/conversation/cognitiveservices/v1?cid=23698771-9e34-4903-8ff1-0387219dec64&language=zh-CN

Connection to the service is established in less than 100ms:
[68939]: 87455ms SPX_TRACE_INFO:  uspimpl.cpp:1028 TS:77, OnConnected: connection:0x5d9127c0

Service starts processing:
[68939]: 87494ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5F45B0]CSpxAudioStreamSession::FireConnectionMessageReceived; path=turn.start

Speech start is detected ~5.1 sec after processing started:
[68939]: 92612ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5F45B0]CSpxAudioStreamSession::FireConnectionMessageReceived; path=speech.startDetected
[68939]: 92612ms SPX_DBG_TRACE_VERBOSE:  usp_reco_engine_adapter.cpp:1321 Response: Speech.StartDetected message. Speech starts at offset 4100000 (100ns).

The first intermediate result (hypothesis) comes ~5.2 sec after processing started, the recognition latency is notably higher than for the single-shot earlier:
[68939]: 92712ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5F45B0]CSpxAudioStreamSession::FireConnectionMessageReceived; path=speech.hypothesis
[68939]: 92712ms SPX_DBG_TRACE_VERBOSE:  usp_reco_engine_adapter.cpp:1373 Response: Speech.Hypothesis message. Starts at offset 4100000, with duration 6100000 (100ns). Text: 帮我
[68939]: 92712ms SPX_DBG_TRACE_VERBOSE:  named_properties.h:363 ISpxPropertyBagImpl::SetStringValue: this=0x000001F36F44E670; name='RESULT-RecognitionLatencyMs'; value='4317'

The final result, by now the latency has gone further up:
[68939]: 99149ms SPX_DBG_TRACE_VERBOSE:  audio_stream_session.cpp:1343 [000001F35C5F45B0]CSpxAudioStreamSession::FireConnectionMessageReceived; path=speech.phrase
[68939]: 99149ms SPX_DBG_TRACE_VERBOSE:  usp_reco_engine_adapter.cpp:1627 Response: Speech.Phrase message. Status: 0, Text: 帮我打开割箱线的增长率分析报表。, starts at 4100000, with duration 40700000 (100ns).
[68939]: 99149ms SPX_DBG_TRACE_VERBOSE:  named_properties.h:363 ISpxPropertyBagImpl::SetStringValue: this=0x000001F36F445600; name='RESULT-RecognitionLatencyMs'; value='7293'

So it appears that the server for chinaeast2 could not keep up with a longer real-time input in this case, possibly due to other simultaneous load, as the recognition of a 4 sec phrase took ~6.5 sec (from Speech.StartDetected to Speech.Phrase message). Also there was 5 sec after the start of processing before Speech.StartDetected was seen.


Keyboard Navigation - InkWell onTap method not called with keyboard for the first item in Row if InkWell wrapped with Focus

Steps to reproduce

Run the code sample.
Navigate to second item in the Row with keyboard arrowRight
Press 'Enter/Return' on keyboard
check console/log for message 'item 1 clicked'
Navigate to first item in the Row with keyboard arrowLeft
Press 'Enter/Return' on keyboard

Expected results
First item should be focused and message should appear in console/log
Actual results
No focus for the first item and no message in console/log
Code sample
Code sample
Row(
                  mainAxisAlignment: MainAxisAlignment.start,
                  children: List.generate(
                    3,
                    (i) => Focus(
                      child: InkWell(
                        onTap: () {
                          print("item $i clicked");
                        },
                        child: Container(
                            margin: const EdgeInsets.symmetric(horizontal: 10),
                            width: 100,
                            height: 50,
                            color: Colors.red),
                      ),
                    ),
                  ),
                )

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.5 23F79 darwin-arm64, locale en-BY)
    • Flutter version 3.24.3 on channel stable at /Users/sergey/Flutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (4 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/sergey/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Users/sergey/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.2)
    • Android Studio at /Users/sergey/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] IntelliJ IDEA Ultimate Edition (version 2024.1.1)
    • IntelliJ at /Users/sergey/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.91.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (7 available)
    • Chromecast (mobile)                   • <IP_ADDRESS>:5555                  • android-arm    • Android 12 (API 31)
    • sdk google atv64 amati arm64 (mobile) • emulator-5556                        • android-arm64  • Android 14 (API 34) (emulator)
    • iPhone 15 (mobile)                    • 9999826C-FC17-41AD-B7B6-CC42F38F063A • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
    • macOS (desktop)                       • macos                                • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop)       • mac-designed-for-ipad                • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                          • chrome                               • web-javascript • Google Chrome 129.0.6668.100

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@inludese
What platform are you seeing this behavior on ?
I tried the code on android emulator and also on desktop in which I get the desired result in console as below:
mobile:
I/flutter (15638): item 0 clicked
D/EGL_emulation(15638): app_time_stats: avg=230.31ms min=11.66ms max=1092.05ms count=5
D/EGL_emulation(15638): app_time_stats: avg=49.35ms min=1.79ms max=1343.58ms count=34
I/flutter (15638): item 1 clicked
D/EGL_emulation(15638): app_time_stats: avg=218.51ms min=11.28ms max=1023.44ms count=5
D/EGL_emulation(15638): app_time_stats: avg=18.02ms min=1.83ms max=318.54ms count=36
I/flutter (15638): item 0 clicked
D/EGL_emulation(15638): app_time_stats: avg=455.66ms min=16.56ms max=1332.14ms count=3

desktop:
flutter: item 0 clicked
flutter: item 1 clicked
flutter: item 0 clicked

I have faced this issue on Google TV with remote control and on Google TV emulator with physical keyboard

Also same behavior if you run example in dartpad

I will close this issue. Something wrong with layout on my end. Something else intercept focus