cmd/go: drop $GOPATH/pkg

(after discussion with Russ, trying to summarize here)

It's nice to be able to tell people to set $GOPATH == $HOME, which means their source
goes into $HOME/src and their binaries conveniently go into $HOME/bin.

The only wart with $GOPATH == $HOME is the $HOME/pkg directory, which is pretty ugly,
not useful for end users, and somewhat offensive to be littering in people's $HOME.

If issue #4443 and issue #3895 get fixed, $GOPATH/pkg might get even uglier.

Unlike $GOROOT/pkg, $GOPATH/pkg doesn't contain tool binaries.  It's pretty much just a
cache.

Can't cmd/go's *.a cache go into /tmp/go-cache-$USER 0700 or ~/Library/Caches with
appropriate occasional lazy cleaning?  (or letting the system clean).

Every release (especially Go 1.5) has been getting us closer to eliminating "pkg" and instead having a build cache directory somewhere (some system-specific cache directory)
Having a cache instead of "pkg" would also eliminate the frequent problems people run into where "go build" does too much work when they could've used "go install" instead.
/cc @adg @davecheney

I would love see the pkg directory go away.
I've always viewed it as an artifact of our implementation which is based on historic ideas of how a program is compiled into object files which are then linked. (In the earliest days of Go I suggested that we make this compile/link process invisible - i.e., as a programmer one just "sees" source code. But we were not ready at that time for this).

@bradfitz,
I view 'pkg' as this cache, and I'm fine with it living inside GOPATH
because that makes it simple to explain where to find it if people are
determined to delete it.
The change I implemented in gb was to remove the distinction between go
build, go install, and the other odd -I variants; if gb can cache
something, even while building tests, it will and this has worked out
pretty well.
For my money removing the number of ways one can tell them go tool to cache
things and just make the caching more pervasive would be a welcome
improvement.
If that cache lives inside GOPATH, or some default location relative to
HOME feels less important, but I suspect that the windows users will have a
issues with a large number of files written to their home directories,
which may not be local to their machines.
Thanks
Dave
On Wed, 30 Sep 2015 03:17 Robert Griesemer<EMAIL_ADDRESS>wrote:

I would love see the pkg directory go away.
I've always viewed it as an artifact of our implementation which is based
on historic ideas of how a program is compiled into object files which are
then linked. (In the earliest days of Go I suggested that we make this
compile/link process invisible - i.e., as a programmer one just "sees"
source code. But we were not ready at that time for this).
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/4719#issuecomment-144125808.

makes it simple to explain where to find it if people are
determined to delete it

If the cache is 100% correct (which isn't unimaginable; bazel does it, and Go 1.5 is basically there already), then deleting it is unnecessary. If we really wanted, we could have a go XXX subcommand to free up disk space, if that's the concern.
Great to hear that gb does caching for both build and install!
If we get to the point where the current "pkg" is just a cache and also cached go build, that's great, but then my next annoyance is that I have to look at it. I like to set my $GOPATH to $HOME, and that means I have $HOME/pkg being a useless turd right in my home directory.  So I'd rather put things in the right spots:

For Linux etc we have stuff like http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html for the user-specific cache directory.
OS X has $HOME/Library/Caches
Windows has %USERPROFILE%\AppData\Local\Temp (aka $TMP aka $TEMP) (from http://technet.microsoft.com/en-us/library/cc749104(v=ws.10).aspx

I cannot explain why people want to delete GOPATH/pkg, I believe it is
unnecessary, and in every case where I have asked for more details not have
been provided, yet the lore continues to propagate itself.
I'm fine with using the LSB mandates tmp directories, that feels like the
smaller argument vs making the go tool more aggressive with its caching.
On Wed, 30 Sep 2015 07:50 Brad Fitzpatrick<EMAIL_ADDRESS>wrote:

makes it simple to explain where to find it if people are
determined to delete it
If the cache is 100% correct (which isn't unimaginable; bazel does it, and
Go 1.5 is basically there already), then deleting it is unnecessary. If we
really wanted, we could have a go XXX subcommand to free up disk space,
if that's the concern.
Great to hear that gb does caching for both build and install!
If we get to the point where the current "pkg" is just a cache and also
cached go build, that's great, but then my next annoyance is that I have
to look at it. I like to set my $GOPATH to $HOME, and that means I have
$HOME/pkg being a useless turd right in my home directory. So I'd rather
put things in the right spots:

For Linux etc we have stuff like
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
for the user-specific cache directory.
OS X has $HOME/Library/Caches
Windows has %USERPROFILE%\AppData\Local\Temp (aka $TMP aka $TEMP)
(from http://technet.microsoft.com/en-us/library/cc749104(v=ws.10).aspx

—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/4719#issuecomment-144201427.

If pkg is to become a cache, and possibly more hidden, it would be good to fix the ways in which GOOS + GOARCH is not quite a valid cache key: GOARM is probably the worst offender here, but also tags and things like buildmodes and the race detector (although the go tool handles the last two via installstuffix currently).

Yeah, GOARM/GO386 and build tags (including race) should
also be part of the cache key (ideally, build tag that doesn't
affect the compilation of one package shouldn't be cached
under the cache with the build tag.)
The toolchain version should also be part of the cache key.
Esp. for those who switch Go releases frequently.

Forgive me if I have missed subtleties that have already been discussed.
I have not seen any discussion of how a system global pkg cache would work for people who switch between multiple GOPATHs, each of which might contain different versions of the same package(s). I understand that recent versions of the go tool will hash all the file names used to build a .a file to help keep the cache accurate. But different versions of a package in different GOPATHs could easily have the same file list but different code. It seems to me either separate caches are required per GOPATH (as the pkg directory does today) or the cache key would need to include something to differentiate between the multiple GOPATHs used.

Yes, it would have to be a good cache. :-)

(That is, it would have to take all these things into consideration. It's not a trivial problem, which is why it hasn't happened.)

+1 to this, particularly making it toolchain-sensitive too. I often find myself switching between different compiler versions so I can check behaviour differences, and switching/removing $GOPATH/pkg is a pain.

@rogpeppe, we can't do anything about Go 1.4 and earlier, but starting with
Go 1.5 you can switch versions without having to bother changing
$GOPATH/pkg. The toolchain will correctly identify what is and is not out
of date and rebuild accordingly.

It would be nice if binary-only packages (#2775) still live in $GOPATH/pkg, even if the remaining files where to move to OS specific cache directories.

I've been mentally translating this bug to "remove pkg from both $GOROOT and $GOPATH", which is difficult, but @crawshaw pointed out to me earlier today that it's only about $GOPATH. $GOROOT/pkg is difficult to kill because we want to keep allowing the building of programs with cgo-enabled package net from systems without a C compiler. We will probably have $GOROOT/pkg or an equivalent for quite some time. But $GOPATH/pkg doesn't have that concern.
Assuming build artifact caching goes well in Go 1.10, the only thing left in the way of removing $GOPATH/pkg would be updating source code analysis tools that want access to the .a files to know where to find them. We're working out how to do that, because we can see that proper package management is not going to fit into the usual $GOPATH/pkg structure either. I expect the answer will be in Go 1.11 and that we can use that release as a grace period in which old tools still work but people should convert to new tools that also work. If that happens, then we could possibly consider dropping $GOPATH/pkg in Go 1.12.

Tentatively putting in Go 1.12. Note that this means disallowing GOCACHE=off.

Note that this means disallowing GOCACHE=off

Just to double-check, and my use-case might not be the norm, but does this mean having no way whatsoever to disable caching, outside of deleting the cache itself?
Reason I ask is that I sometimes am working with randomly-failing integration tests that I want to run in a loop to have it trigger the error, since it doesn't trigger every time.
Right now, when working with such projects, I always export GOCACHE=off before I start testing, because I know one successful run won't mean the test works the second time, and so I want to keep triggering those random failures so that I can debug and squash them.
Again, this might be an edge-case, and I can change those loops to remove the cache before running, but I just wanted to put this use-case out here for consideration.

Do you want to disable build caching or test caching? The latter can be disabled with go test -count=1

On 6 May 2018, at 21:54, Jean Mertz<EMAIL_ADDRESS>wrote:
Note that this means disallowing GOCACHE=off
Just to double-check, and my use-case might not be the norm, but does this mean having no way whatsoever to disable caching, outside of deleting the cache itself?
Reason I ask is that I sometimes am working with randomly-failing integration tests that I want to run in a loop to have it trigger the error, since it doesn't trigger every time.
Right now, when working with such projects, I always export GOCACHE=off before I start testing, because I know one successful run won't mean the test works the second time, and so I want to keep triggering those random failures so that I can debug and squash them.
Again, this might be an edge-case, and I can change those loops to remove the cache before running, but I just wanted to put this use-case out here for consideration.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I came here from https://github.com/golang/go/issues/17271#issue-179909759 and I am interested if dropping $GOPATH/pkg will allow me to have my dependency in vendor/dependency checkout without touching $GOPATH at all?

@abitrolly, the bug you were at was the right place. This bug is more of a cleanup that's not very user-visible.

Now that the previous bug is closed, does that mean that the feature with vendor imports without $GOPATH works already in 1.12?

@abitrolly minimal vendor support without GOPATH is being added as part of new modules feature to Go.11. Note Go.1.11 is not released yet. You can try the beta version.

shouldn't the module cache be in os.UserCacheDir() instead of $GOPATH/pkg/mod?

@perillo, we discussed that (somewhere) earlier and decided to just use $GOPATH/pkg for now while we had it. But yes, it'd have to move later when this bug is resolved.

@perillo, or we might leave the module source cache in $GOPATH/pkg.
I think there are good reasons not to put cached module downloads in $HOME/.cache. Quoting myself on https://dave.cheney.net/2018/07/14/taking-go-modules-for-a-spin and https://groups.google.com/forum/#!msg/golang-dev/RjSj4bGSmsw/KMHhU8fmAwAJ, back when the module cache was $GOPATH/src/mod not $GOPATH/pkg/mod:

The build cache ($GOCACHE, defaulting to $HOME/.cache/go-build) is for storing recent compilation results, so that if you need to do that exact compilation again, you can just reuse the file. The build cache holds entries that are like “if you run this exact compiler on these exact inputs. this is the output you’d get.” If the answer is not in the cache, your build uses a little more CPU to run the compiler instead of reusing the output. But you are guaranteed to be able to run the compiler instead, since you have the exact inputs and the compiler binary (or else you couldn’t even look up the answer in the cache).
The module cache ($GOPATH/src/mod, defaulting to $HOME/go/src/mod) is for storing downloaded source code, so that every build does not redownload the same code and does not require the network or the original code to be available. The module cache holds entries that are like “if you need to download<EMAIL_ADDRESS>here are the files you’d get.” If the answer is not in the cache, you have to go out to the network. Maybe you don’t have a network right now. Maybe the code has been deleted. It’s not anywhere near guaranteed that you can redownload the sources and also get the same result. Hopefully you can, but it’s not an absolute certainty like for the build cache. (The go.sum file will detect if you get a different answer on re-download, but knowing you got the wrong bits doesn’t help you make progress on actually building your code. Also these paths end up in file-line information in binaries, so they show up in stack traces, and the like and feed into tools like text editors or debuggers that don’t necessarily know how to trigger the right cache refresh.)

I think that's still basically right. If the module cache is the only thing left in $GOPATH/pkg, we could decide to move it elsewhere, or we could decide to leave it there. Moving it to $HOME/.cache seems wrong though.
Really I'm just restating what I said in b8f42d7 on Jul 30, 2018 above:
If we do eliminate GOPATH/pkg for holding .a files (#4719)
then we could still keep it around for pkg/mod.
(Or we could move the module cache again then.)

I think I understand and agree with all those points individually, but I'm missing the link between them and being opposed to using $XDG_CACHE_HOME (default $HOME/.cache) or its equivalent on other platforms.
My motivation for wanting to use a platform's standard cache location is that these caches tend to grow and never shrink, and eventually it becomes necessary to reclaim some disk space. Having a single location where all "well behaved" software stores caches that are safe to delete makes it more convenient to do that kind of maintenance.
Without standards like the XDG base directory spec, most software tends to think it deserves its own entry in your ls -a ~ output. But the more software you use, the more of a mess that becomes.
I suspect we have a different level of concern around this point:

It’s not anywhere near guaranteed that you can redownload the sources and also get the same result.

I don't think ~/.cache is meant to be limited to be limited to things that could be recomputed from locally available non-cache data. Looking inside mine, I see multiple browser caches, yarn module cache, typescript typing cache, a system package manager cache (yay), etc. All of those are caching data from the internet.
Looking at the XDG data dir spec, if a distinction must be made between the durability of the two go caches, maybe $XDG_DATA_HOME ($HOME/.local/share) should be considered.

I do get rsc's point, some of Go cache is "cheap to discard", some is "expensive to discard and potentially unavailable if lost". Note that XDG says nothing about how $XDG_CACHE_HOME should or can be cleaned, or how often etc, all it says is the directory is for "non-essential (cached) data". So I guess you could argue that any automatic tool that removes ~/.cache/go/mod or whatever in way that annoys the user is just too eager, and should learn better rules about prioritization and retainment. Maybe.
For what it's worth, rust seems to plan migrating from ~/.cargo to ~/.cache/cargo for what seem to me to be similar uses: https://github.com/rust-lang/cargo/pull/148 (don't trust Github claims of "Merged").

The other thing a single cache directory location is for is a simple place to exclude things from backups.

Why will we want a long cache when there will be global modules proxies ?
I think if we want to be really safe we need a cache per project (instead of vendor ?). I'd like this cache hardlinked on linux.

This issue was originally about the .a files in $GOPATH/pkg.
Those are no longer generated when using the build cache,
and as of Go 1.12, use of the build cache is required.
So it has been quite a long time since we wrote .a files to $GOPATH/pkg.
(The build cache also fixed issue #4443 and #3895 that Brad mentioned in the issue text.)
Since the issue was written, we added $GOPATH/pkg/mod and $GOPATH/pkg/sumdb.
I am comfortable with those staying as they are today.
They don't have any of the problems that the .a files had.
Now that GOPATH defaults to $HOME/go,
$HOME/go/pkg/mod and $HOME/go/pkg/sumdb
are completely reasonable paths.
(I still prefer to set GOPATH=$HOME, but that's a choice not a default.)
Closing this issue as fixed by the now-required build cache.


[CARBONDATA-4003] Improve IUD Concurrency

Why is this PR needed?
Improve concurrency for Insert/Update/Delete
What changes were proposed in this PR?
Remove update lock in Update and Delete Command and lock the segments operared by Update and Delete Command.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3078/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4834/

@Kejian-Li please add a detailed explanation of issue and the solution in PR description.

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5083/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5059/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3326/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3302/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3304/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5063/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5063/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3305/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3305/


Added StreamType.Youtube

Needed this since Youtube is another big streaming platform.

Are you sure that Youtube is actually a supported stream type? The docs say that it's not, and other people seem to agree with that.

Discord Docs says it's twitch only and there's no PR about Youtube.
https://github.com/discordapp/discord-api-docs/blob/a8d8c780ad67d937abb864656a0a0daa0f92e1d2/docs/topics/Gateway.md#game-types

Considering the type is called "Streaming" in the official documentation you can assume that all other platforms will use the same game type just with different urls.

Yea I know they only support Twitch but I didn't wanna use Twitch enum for when I'm streaming live on Youtube. On a 2nd note, I just realized when I'm streaming it thinks I'm streaming on Twitch but probably directs to my Youtube channel :thinking:

Documentation clearly states that only Twitch is supported, furthermore it does not define game type 2 at all. So where did this come from? Which part of the documentation is this based on?


ci: test

Codecov Report

Merging #4 (ad80a91) into main (b4bcc62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   66.66%   66.66%
=======================================
  Files           3        3
  Lines          27       27
=======================================
  Hits           18       18
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bcc62...ad80a91. Read the comment docs.


changed trial period to 90 days

Please resolve conflicts. Always first pull your fork before you push any changes to production!

tags corrected and comma added


Fix misplaced 't' in TYPE_REAL link

change 'FloaTypet.md' to 'FloatType.md'

Thatk you @Braboware!
@all-contributors please add @Braboware for doc


Inconsistency in documentation or a bug in al.

Hi, the documentation is indeed outdated - columns of type Variant were deprecated with Business Central 2021 release wave 1 and will trigger AL0638 instead. We will update it.


Format of the listed links?

Thinking through what the format should be for the links that are being listed in the README.
Right now, it looks like this:
[Grommet](http://grommet.io/) which translates to Grommet.
What if we linked to both the github repo and the respective landing page like so:
[Grommet](http://grommet.io/) [[github](https://github.com/grommet/grommet)] -- Hewlett Packard
which would look like:
Grommet [github] -- Hewlett Packard
Thoughts?

Agree. What if there is no landing page for the link? What would you prefer:
a)  Grommet [github] -- Hewlett Packard
b) Grommet -- Hewlett Packard

Yeah, I think option a is the way to go!

We've settled on a format, closing.


[Broken] Atresplayer

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running yt-dlp version 2021.09.02
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

C:\Users\info>yt-dlp -u (PRIVATE) -p (PRIVATE) https://www.atresplayer.com/kidz/series-infantiles/little-charmers/temporada-1/capitulo-1-un-principe-poco-encantador-el-vestido-encantado_602e67b17ed1a8453038d061/ -v
[debug] Command-line config: ['-u', 'PRIVATE', '-p', 'PRIVATE', 'https://www.atresplayer.com/kidz/series-infantiles/little-charmers/temporada-1/capitulo-1-un-principe-poco-encantador-el-vestido-encantado_602e67b17ed1a8453038d061/', '-v']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.09.02 (exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: none
[debug] Optional libraries: mutagen, pycryptodome, sqlite, websockets
[debug] Proxy map: {}
[AtresPlayer] Downloading login page
ERROR: [AtresPlayer] 602e67b17ed1a8453038d061: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; see  https://github.com/yt-dlp/yt-dlp  on how to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
  File "yt_dlp\extractor\common.py", line 693, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 3218, in urlopen
  File "urllib\request.py", line 531, in open
  File "urllib\request.py", line 640, in http_response
  File "urllib\request.py", line 569, in error
  File "urllib\request.py", line 502, in _call_chain
  File "urllib\request.py", line 649, in http_error_default

Description

Atresplayer not working.

Edit your message to include verbose log,

@Ashish0804 Yes, fixed.

Possibly fixed by https://github.com/ytdl-org/youtube-dl/pull/27215?

Yes. @coletdjnz

I've pinged the dev to see if they want to make the PR here

please include this pr in master

The PR author seems to have abandoned it.
https://github.com/yt-dlp/yt-dlp/pull/1165#issuecomment-962490930 claims that the site has content that can be accessed without an account, but the links in that comment do ask for login. Does anyone have a link that actually doesn't need login? If not, you can send account details to me via discord (pukkandan#4207) / reddit (/u/pukkandan) / email<EMAIL_ADDRESS>if u want me to have a look

Yes, the website nows needs a cookie.txt with auth credentials confirmed to wrok, and almost everything is paid content. This pr works on soft protected links, not with hard proteced, that means half of the content can be donwnlaoaded with a paid cooke.txt, also i think it uses geoblocking, but anyway the pr works. I'll try to contact you on discord.

The PR author seems to have abandoned it.
#1165 (comment) claims that the site has content that can be accessed without an account, but the links in that comment do ask for login. Does anyone have a link that actually doesn't need login? If not, you can send account details to me via discord (pukkandan#4207) / reddit (/u/pukkandan) / email<EMAIL_ADDRESS>if u want me to have a look

@pukkandan I mentioned my Atresplayer credentials to your Discord.

It's been a long time since that comment. I don't have the time or interest to deal with this myself anymore. Some other dev will have to take it up.

Confirming for me the issue is fixed with #1165:
cd /path/to/checkout/yt-dlp
git fetch refs/pull/1165:PR-1165
git checkout PR-1165
./yt-dlp.sh -u<EMAIL_ADDRESS>-p secret https://www.atresplayer.com/...

Confirming for me the issue is fixed with #1165:
cd /path/to/checkout/yt-dlp
git fetch refs/pull/1165:PR-1165
git checkout PR-1165
./yt-dlp.sh -u<EMAIL_ADDRESS>-p secret https://www.atresplayer.com/...

did you try subtitles? they worked but i think this week they stopped working.

did you try subtitles? they worked but i think this week they stopped working.

No, just downloaded a video.

For a more modern log, see #8359


pull fails on XSLT with tt:call-method, if classic program refers to this class

This is another minimal test case (branch issue-5365) which concerns issues related to XSLT activation. It's almost the same as #5262, but I think it's worth documenting them in separate issues so that we can have all test cases if we agree on a fix (I am working on it). For information, we also have a third test case, which is https://github.com/abap2xlsx/abap2xlsx/issues/993 (with different abapGit behavior, I am also trying to build a minimal test case for it).
My system is ABAP 7.52 kernel 753 SP 500 (before the kernel indicated in the note 2859159 - link below).
I have abapGit 1.114.0, latest pull.
Marc has nicely explained the general problem here, so I just copy/paste it:

This project contains XSLT and if those objects don't activate properly, then nothing else will work (due to Ddic and code dependencies).
Therefore, please check SAP note https://launchpad.support.sap.com/#/notes/2859159 first and make sure you have the right kernel version running.
Secondly, run the very latest version since we continuously improve things like #5303 which shows inactive TABL objects correctly (note: similar handling of other DDIC types is still missing).
To have a reproducible case, uninstall the complete repo and install it again. Attach output of Utilities > Debug info and screenshot after initial pull.

To reproduce

Install the fix #5369 (otherwise there will be some errors not related to transformation)
New Online https://github.com/sandraros/test-abapgit → Switch to branch issue-5365:

Pull → "Activation cancelled. Check the inactive objects. ":

Pull again does the same as above

So that the test case above pulls correctly, I think that #5369 and #5370 are also needed.

Retested https://github.com/sandraros/test-abapgit/tree/issue-5365. Works fine with v1.115.0
Fixed by #5393


Terminal load debug logging

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[ ] Question

zplug --version: 2.4.1
zsh --version: 5.2 (x86_64-ubuntu-linux-gnu)
uname -a: Linux precision 4.10.0-26-generic #30-Ubuntu SMP Tue Jun 27 09:30:12 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Type: Bug
Minimal zshrc (with less than 30 lines)
if ! [ type "zplug" > /dev/null 2>&1 ]; then
    source ~/.zplug/init.zsh
fi

zplug 'zplug/zplug', hook-build:'zplug --self-manage'
zplug 'zsh-users/zsh-syntax-highlighting', defer:3
zplug 'zsh-users/zsh-autosuggestions'

# Install plugins if there are plugins that have not been installed
if ! zplug check; then
    printf "Install? [y/N]: "
    if read -q; then
        echo; zplug install
    fi
fi

Step to reproduce

Put the above code in my zshrc. Save it
Open a new terminal windows

Expected: Get my prompt
Actual: Get the following console output then my prompt
/home/jcostanzo/.zplug/log/load_success.log Stats {
  dev: 66306,
  mode: 33188,
  nlink: 1,
  uid: 1000,
  gid: 1000,
  rdev: 0,
  blksize: 4096,
  ino: 9961819,
  size: 0,
  blocks: 0,
  atimeMs:<PHONE_NUMBER>000,
  mtimeMs:<PHONE_NUMBER>000,
  ctimeMs:<PHONE_NUMBER>925.2686,
  birthtimeMs:<PHONE_NUMBER>925.2686,
  atime: 2017-07-03T18:06:01.000Z,
  mtime: 2017-07-03T18:06:01.000Z,
  ctime: 2017-07-03T18:06:01.925Z,
  birthtime: 2017-07-03T18:06:01.925Z }
/home/jcostanzo/.zplug/log/load_failure.log Stats {
  dev: 66306,
  mode: 33188,
  nlink: 1,
  uid: 1000,
  gid: 1000,
  rdev: 0,
  blksize: 4096,
  ino: 9962075,
  size: 0,
  blocks: 0,
  atimeMs:<PHONE_NUMBER>000,
  mtimeMs:<PHONE_NUMBER>000,
  ctimeMs:<PHONE_NUMBER>981.2761,
  birthtimeMs:<PHONE_NUMBER>981.2761,
  atime: 2017-07-03T18:06:01.000Z,
  mtime: 2017-07-03T18:06:01.000Z,
  ctime: 2017-07-03T18:06:01.981Z,
  birthtime: 2017-07-03T18:06:01.981Z }

Update 1:
Maybe this has something to do with it. When running zplug --log, I get the following output
{"pid":16599,"shlvl":1,"level":"INFO","dir":"/home/jcostanzo","message":"ZPLUG_LOADFILE is not found","trace":["__zplug::log::write::info:2","__zplug::io::file::load:3","/home/jcostanzo/.zplug/init.zsh:33","/home/jcostanzo/.dotfiles/zsh/zplug.zsh:4","/home/jcostanzo/.zshrc:14","zsh:0"],"date":"2017-07-03T15:37:04-0400"}
{"pid":17692,"shlvl":1,"level":"INFO","dir":"/home/jcostanzo/.dotfiles","message":"ZPLUG_LOADFILE is not found","trace":["__zplug::log::write::info:2","__zplug::io::file::load:3","/home/jcostanzo/.zplug/init.zsh:33","/home/jcostanzo/.dotfiles/zsh/zplug.zsh:4","/home/jcostanzo/.zshrc:14","zsh:0"],"date":"2017-07-03T15:38:15-0400"}

Sorry for the bump. Any thoughts on this?

Has this tool been abandon by the developer?

I'm having the same issue, but it only manifests when zplug is loaded inside a Tmux session – I haven't been able to figure out exactly what differences in the environment will trigger it.

Having similar issue,
Not sure if relevant but zplug --log output
{"pid":23000,"shlvl":1,"level":"INFO","dir":"/Users/cameron.pitt/.zplug/repos/robbyrussell/oh-my-zsh","message":"ZPLUG_LOADFILE is not found","trace":["__zplug::log::write::info:2","__zplug::io::file::load:3","/Users/cameron.pitt/.zplug/init.zsh:33","/Users/cameron.pitt/.zshrc:15","zsh:0"],"date":"2017-08-22T19:03:49-0700"}
{"pid":23000,"shlvl":1,"level":"INFO","dir":"/Users/cameron.pitt/.zplug/repos/robbyrussell/oh-my-zsh","message":"turn monitor on","trace":["__zplug::log::write::info:2","__zplug::job::polling::periodic:9","zsh:1"],"date":"2017-08-22T19:03:51-0700"}
{"pid":23000,"shlvl":1,"level":"INFO","dir":"/Users/cameron.pitt/.zplug/repos/robbyrussell/oh-my-zsh","message":"turn monitor on","trace":["__zplug::log::write::info:2","__zplug::job::polling::periodic:9","zsh:3"],"date":"2017-08-22T19:04:25-0700"}
{"pid":23000,"shlvl":1,"level":"ERROR","dir":"/Users/cameron.pitt/.zplug/repos/robbyrussell/oh-my-zsh","message":"log","trace":["__zplug::log::write::error:2","__zplug::io::print::f:131","__zplug::core::arguments::auto_correct:33","__zplug::core::arguments::exec:21","zplug:26","zsh:3"],"date":"2017-08-22T19:04:29-0700"}
{"pid":42429,"shlvl":1,"level":"INFO","dir":"/Users/cameron.pitt","message":"ZPLUG_LOADFILE is not found","trace":["__zplug::log::write::info:2","__zplug::io::file::load:3","/Users/cameron.pitt/.zplug/init.zsh:33","/Users/cameron.pitt/.zshrc:15","zsh:0"],"date":"2017-08-22T19:06:49-0700"}
{"pid":43402,"shlvl":2,"level":"INFO","dir":"/Users/cameron.pitt","message":"ZPLUG_LOADFILE is not found","trace":["__zplug::log::write::info:2","__zplug::io::file::load:3","/Users/cameron.pitt/.zplug/init.zsh:33","/Users/cameron.pitt/.zshrc:15","zsh:0"],"date":"2017-08-22T19:06:53-0700"}
{"pid":43402,"shlvl":2,"level":"INFO","dir":"/Users/cameron.pitt","message":"turn monitor on","trace":["__zplug::log::write::info:2","__zplug::job::polling::periodic:9","-zsh:1"],"date":"2017-08-22T19:06:55-0700"}

In my case, a global node module named "touch" is symlinked in /usr/local/bin/touch, which does output all of that messages when zplug is creating a new trace.log file. After I remove it, the problem seems to be gone.
Source: https://stackoverflow.com/questions/44923968/how-to-deactivate-bash-history-stats-print-when-opening-a-new-terminal-window-on

@phoomparin Wow that's it! I have no idea how touch got installed..... searched my zsh history.... never installed it.... looks like it might be related to this yarn bug yarnpkg/yarn/issues/3824

@phoomparin Oh. Same thing for me—a locally installed copy was prioritized in $PATH. Thanks!

@phoomparin +1


Add option for checking consistency of csv.stream parser

With checkConsistency=true, record with not the same number of values with column names will throw parsing fail exception.

Done


vscode.dev open file dialog thinks setting profile files are .txt

Testing #148058
When importing a setting profile on insiders.vscode.dev I notice that by default the filetype filter is set to .txt and .text instead of .code-profile:

Also same while exporting

This works fine in Desktop, meaning, file dialog looks for .code-profile files only.  This is how I am invoking the picker
https://github.com/microsoft/vscode/blob/522d784b28326601bafb052c18fdf2fd4dc50b72/src/vs/workbench/contrib/profiles/common/profilesActions.ts#L109-L115

https://github.com/microsoft/vscode/issues/130035#issuecomment-895091067
I'm not sure what level the issue with - and _ in file extension is at, but they couldn't be included in the suggested types.


Improve code readability

I've changed the identation on both server.js and index.html to 4 spaces. They weren't normalized so the source readability was very low. Also made some changes to make the code look prettier as a whole. Game functionality hasn't changed at all.

Great! Thank you so much @IgorAntun!!!!


Assign the description to the request object in OpenAPI

This fixes an issue where the doc comment description of an e.g. JSON parameter of a request would not show up in the generated API spec.
For example:
#[oai(path = "/users", method = "post", operation_id = "createUser")]
async fn create_user(
    &self,
    /// Parameters required to create a new user
    Json(params): Json<CreateUserParams>,
)

should translate to:
  /users:
    post:
      requestBody:
        description: Parameters required to create a new user
        content:
          application/json; charset=utf-8:
            schema:
              $ref: '#/components/schemas/CreateUserParams'
        required: true

but without this change description is missing.

@sunli829 could you please take a look? it's a relatively small one

thanks


Inaccurate test reports

https://github.com/shogo82148/gojq/pull/5
the actions says:

go test -run=FuzzQueryRun/99d387b70ac2e4e4 github.com/itchyny/gojq failed with the following output:

ok  	github.com/itchyny/gojq	3.597s

actual log:
(snip)
  fuzz: elapsed: 9m36s, execs: 8196343 (11114/sec), new interesting: 194 (total: 4029)
  fuzz: elapsed: 9m39s, execs: 8231461 (11707/sec), new interesting: 194 (total: 4029)
  fuzz: elapsed: 9m40s, execs: 8239571 (9383/sec), new interesting: 194 (total: 4029)
  --- FAIL: FuzzQueryRun (580.00s)
      fuzzing process hung or terminated unexpectedly while minimizing: EOF
      Failing input written to testdata/fuzz/FuzzQueryRun/99d387b70ac2e4e4
      To re-run:
      go test -run=FuzzQueryRun/99d387b70ac2e4e4
  FAIL
  exit status 1
  FAIL	github.com/itchyny/gojq	580.005s
fuzzing error occurred

closed by https://github.com/shogo82148/actions-go-fuzz/pull/221


Support ulimit nofile for Ubuntu Xenial

Partially fixes #37

@svrc-pivotal any update here? i would like to get this fixed as well

Hi @svrc-pivotal , please take a look at:
https://github.com/pivotal-cf/ulimit-release/pull/7
if this would be a solution for you as well.

@h0nlg does the PR not help or have a problem?  You’d need to grab this release off my fork, as I’m not a committed here.
@videlov yeah we have two implementarion  of this for historical reasons.  Your PR looks fine though probably should retain support for limits.conf to support trusty stemcells (admittedly this won’t be useful for much longer).


Camera - Dynamic Imgui widget

Add a long form option referring to camera configurable object to allow the user to specify if the camera is moving or is statis

Removing CLI option in favor of a dedicated Imgui widget


Python, Lambda and Flask: FacadeSegments cannot be mutated

When using aws-xray-sdk 0.92 on Lambda to trace a Flask application, adding the Flask middleware results in this log and traceback.
[1509032914734] Traceback (most recent call last):
[1509032914734] File "/var/task/flask/app.py", line 1982, in wsgi_app
[1509032914734] response = self.full_dispatch_request()
[1509032914734] File "/var/task/flask/app.py", line 1615, in full_dispatch_request
[1509032914734] return self.finalize_request(rv)
[1509032914734] File "/var/task/flask/app.py", line 1632, in finalize_request
[1509032914734] response = self.process_response(response)
[1509032914734] File "/var/task/flask/app.py", line 1856, in process_response
[1509032914734] response = handler(response)
[1509032914734] File "/var/task/aws_xray_sdk/ext/flask/middleware.py", line 59, in _after_request
[1509032914734] segment.put_http_meta(http.STATUS, response.status_code)
[1509032914734] File "/var/task/aws_xray_sdk/core/models/facade_segment.py", line 42, in put_http_meta
[1509032914734] raise FacadeSegmentMutationException(MUTATION_UNSUPPORTED_MESSAGE)
[1509032914734] aws_xray_sdk.core.exceptions.exceptions.FacadeSegmentMutationException: FacadeSegments cannot be mutated.
[1509032914734] FacadeSegments cannot be mutated.
Please check the forums for the detail info :
https://forums.aws.amazon.com/thread.jspa?messageID=803898&tstart=0

Hi, which serverless framework are you using?

I use zappa , and python flask framework.

The long term solution is to have the middleware directly add all http metadata to the root segment generated by Lambda worker. The SDK currently doesn't have access to this segment right now and we don't have an ETA yet.
The workaround is to have middleware to only generate subsegments when running on Lambda. This causes a problem in the service graph. The color of the Lambda function node in the service graph is decided by status code in lambda segments. And this status code only indicates if the lambda function runs or not. It doesn't respect the actual status code returned by your web application running within that lambda function. If you have correct IAM role setup and no syntax error on your application code, most likely you will always see an all green service graph node despite a lot of 4xx returned by your web app.
This workaround makes it difficult to discover issues and we cannot call this workaround "support for serverless". But we are open to here any suggestions. If such workaround is acceptable we can make it an opt-in so that at least FacadeSegmentMutationException is avoided.

@haotianw465 What are the consequences if we use our own Context() instead of using SDK-provided Lambda context?

@xplorld the recorder class intentionally exposes an API to allow users to configure their own context management https://github.com/aws/aws-xray-sdk-python/blob/master/aws_xray_sdk/core/recorder.py#L75.
You can have your own implementation of the context() used in Lambda container which creates another type of facadesegment which can be modified freely and replicate everything it has to a child subsegment.
Please let me know if you need any help on implementing a customized context management that specifically fits your use case.

Hi all, API Gateway with active X-Ray integration is launched. You can see more details here: https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-xray.html.
Feel free to leave any feedback on the new customer experience and we are happy to discuss a workaround based on those new feedback. We will also be working with Lambda team based on those new feedback to better improve the overall experience. Thank you for your patience.

I see the a dangling subsegment even when calling configure before patching third party libraries.
`from aws_xray_sdk.core import xray_recorder, patch_all
from aws_xray_sdk.core.context import Context
from aws_xray_sdk.ext.flask.middleware import XRayMiddleware
app = connexion.App(name, specification_dir='./swagger/')
app.app.json_encoder = encoder.JSONEncoder
app.add_api('swagger.yaml', arguments={'title': 'Swagger Petstore'})
xray_recorder.configure(service=' python-flask-se-development', sampling=False, context=Context())
XRayMiddleware(app.app, xray_recorder)
patch_all()`

Good news! Serverless support has been merged into the master branch!
#127

Good news! Serverless support has been merged into the master branch!
#127


Let us choose the browser for lookups with 'S'

would be be nice if we could specify the browser in a config file or something instead of using the default browser.

personally i use different browser for different things. for example: one browser for language learning, another for google services, yet another for web browsing and so on and i have them open in different windows desktop environments as well.
only have the necessary add-ons in my language learning browser

Implemented in https://github.com/rampaa/JL/commit/548c66c087939a404d207bc5382eb3f26b3e1a2e, will be included in the next release.


allow use of methods of high level class in state model

Is your feature request related to a problem? Please describe.
you cannot use high level class methods in the state model, e.g.:
object.add_method("INITIALIZED","testf")

in the define_state will not work if testf is a method defined (only) in the high level class
Describe the solution you'd like
it should "just work"
Describe alternatives you've considered
you can get around this hackishly by adding a dummy to the low level and calling this from the testf (ie self.overridden().testf()..but thats not the preferred solution
Additional context
the problem is that the state model works in getattr , which only gets called when getattribute fails (but it doesn't if the high level class defines it!)
solution should be some code added to support/interface.py..

workaround available


[Feature]: How to get scrolling list Widget in Appsmith

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
I am trying to build messaging app on app smith but list I am getting in pagination mode how can I get that in vertical scrolling mode ?enter image description here
Why should this be worked on?
vertical scrolling mode

This is still an open feature request #30447


[feature] add the notification feature.

it would be nice if it get notification that shows if your request has been accepted or not by your friends.

is this app online or it is static only???

currently its on initial stages and lack many features so its not online yet, but eventually it will be launched

how do you get notification without even making it online to pushit changes


Implement Eq and PartialEq for COM interfaces

Pointer equality is meaningful for COM interfaces, and is often used
in COM code bases. This adds #[derive(PartialEq, Eq)] for generated
COM interfaces. It includes a compile test.

CI is confused / stuck, because it's still waiting for the 1.42.0 test legs to finished. Those legs were renamed, so CI is never going to finish.
Since the PR is approved, using force-commit.


Shortcuts stopped working

Hi, I recently noticed that shortcuts stopped working
I am using Chrome 72.0.3626.121
I checked for conflicts with other extensions and tried changing the hotkeys (I particularly use the Previous Tab a lot), but I can't get any of the them to work, including CRTL + E to activate.
Seems to be since the last Chrome update.
Am I the only one or did Chrome's latest release break something here?

It looks like since the last release, the behaviour of the hotkeys was reversed: https://github.com/babyman/quick-tabs-chrome-extension/blame/2917b59c9165cf89cd9bf2c2b2ddbe2e82408c54/quick-tabs/popup.js#L528-L532
Switch hotkeys for "Switch to Newer tab" and "Switch to Older tab".

I cannot open search popup using any keyboard shortcut.
I also cannot find where they are set, using the help text provided (bottom of extensionspage).
Tips?

@rb-109 @seslash Indeed, the mapping changed. Did you try setting new ones and it still doesn't work?
Try using a combination of Shift + Alt.

@MartinLichtblau changing key mapping worked for me.

Great! So this closes #257


Added serverside SSE for operator

Signed-off-by: dhruv0000<EMAIL_ADDRESS>Description
Implementing SSE for meshery Operator
This PR fixes #
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

Nice

This might be scrubbed. Had a talk with @abhishekkumkar in afternoon. Taking the direction of having a graphql subscription, which can later be extended in other places.

Ok, sounds good.

This might be scrubbed. Had a talk with @abhishekkumkar in afternoon. Taking the direction of having a graphql subscription, which can later be extended in other places.

You tagged the wrong guy @dhruv0000 :P


Add include section

I'm not sure if this is a good convention, but what about a include directory?

@Keyaku can you give some examples, what this directory is used for?

@koistya Generally, it's used to add library headers to conveniently give less build hassles.
Here's an examples.
I'm solely suggesting, since this has its own drawbacks.

I guess this is mostly relevant to C++ projects?

It's relevant to any kind of project. Of course, it mostly works with C/C++.


Android - Thread-Mention phone number on reply thread shows expensify.sms in header

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.58
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Launch app
Tap on phone contact report
Enter @ followed by phone number in compose
Send the message
Long press and select reply in thread

Expected Result:
@ followed by phone number should be displayed in header on selecting reply in thread
Actual Result:
@ followed by phone number should be displayed in header on selecting reply in thread but header displays @ followed by phone number.expensify.sms
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/2fa22ee8-e53a-4b28-a4f1-826307d70485
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Thread-Mention phone number on reply thread shows expensify.sms in header
What is the root cause of that problem?
in getDisplayNameOrDefault when we get the user details display Name, we removeSMSDomain only in the below case.
https://github.com/Expensify/App/blob/edacb67735b14cfb484352a7267c7804ab5e9fe8/src/libs/PersonalDetailsUtils.ts#L37-L41
in this issue case the personalDetails for this user not have login and displayName set by backend<EMAIL_ADDRESS>{
  "accountID": 16574166,
  "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_7.png",
  "displayName"<EMAIL_ADDRESS>  "firstName": "",
  "lastName": ""
}

So the removeSMSDomain not applied for this case.
What changes do you think we should make in order to solve the problem?
we need to update the condition here to be
// if (displayName === passedPersonalDetails?.login && Str.isSMSLogin(passedPersonalDetails?.login)) {
if (
    (displayName === passedPersonalDetails?.login && Str.isSMSLogin(passedPersonalDetails?.login)) ||
    (!passedPersonalDetails?.login && Str.isSMSLogin(displayName)) // <<<< this issue case
)

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.

Android - Thread-Mention phone number on reply thread shows expensify.sms in header

What is the root cause of that problem?

We get the report name from here. In case of this bug, parentReportAction.message[0].text is something like<EMAIL_ADDRESS>
What changes do you think we should make in order to solve the problem?

We should update the above to:

        const parentReportActionMessage = (
            ReportActionsUtils.isApprovedOrSubmittedReportAction(parentReportAction)
                ? ReportActionsUtils.getReportActionMessageText(parentReportAction)
                : Str.removeSMSDomain(parentReportAction?.message?.[0]?.text ?? '')

What alternative solutions did you explore? (Optional)

NA

I am not sure if this is actually a bug. seems like a minor issue.

Ah I think it is worth fixing cause that format +<EMAIL_ADDRESS>is internal and means nothing to the end user and could confuse them

Agreed with Anu

@rayane-djouah PR https://github.com/Expensify/App/pull/39994 is ready to review

As I mentioned in the PR, we need to consider the case: User sends message "test message<EMAIL_ADDRESS>directly, If we apply the main solution, it will be "test message +123456789". But I think the expected is "test message<EMAIL_ADDRESS>

Done!

Sorry @anmurali It seems I wasn't paid here, could you please reopen the issue to help with this?
TIA


Error arithmetic on field 'end_col' (a nil value)

nvim --version:
NVIM v0.6.0-dev+96-g5f01714b2
Build type: Release
LuaJIT 2.1.0-beta3

Operating system/version:
MacOS

Describe the bug
Error message when search a text.   arithmetic on field 'end_col' (a nil value)
To Reproduce using nvim -u mini.vim
Example:
cat mini.vim
" use your plugin manager, here is `vim-plug`
call plug#begin('~/.config/nvim/plugged')
Plug 'kevinhwang91/nvim-hlslens'

call plug#end()
lua require('hlslens').setup()
noremap <silent> n <Cmd>execute('normal! ' . v:count1 . 'n')<CR>
            \<Cmd>lua require('hlslens').start()<CR>
noremap <silent> N <Cmd>execute('normal! ' . v:count1 . 'N')<CR>
            \<Cmd>lua require('hlslens').start()<CR>
noremap * *<Cmd>lua require('hlslens').start()<CR>
noremap # #<Cmd>lua require('hlslens').start()<CR>
noremap g* g*<Cmd>lua require('hlslens').start()<CR>
noremap g# g#<Cmd>lua require('hlslens').start()<CR>

" use : instead of <Cmd>
nnoremap <silent> <leader>l :nohlsearch<CR>

Steps to reproduce the behavior:

Search a string
see error

Error executing vim.schedule lua callback: .../.config/nvim/plugged/nvim-hlslens/lua/hlslens/index.lua:135: attempt to perform
 arithmetic on field 'end_col' (a nil value)

Expected behavior
No error
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

You need to rebuild your Neovim nightly or tag hlslens to https://github.com/kevinhwang91/nvim-hlslens/commit/ada900452b2f7100c5e6bafafb87ec2979f1b423 .

Has a variable to determine whether enable the nightly feature, I'm afraid you misunderstand hlslens doesn't work at 0.5 stable version, so I explain here and will update the README.

This "bug" hit me and it took me a while to track down this issue.
Did you say that the README was updated?
Also, if ada9004 is the target for which neovim users with nightly builds should use, do you mind tagging it?

This "bug" hit me and it took me a while to track down this issue.
Did you say that the README was updated? Also, if ada9004 is the target for which neovim users with nightly builds should use, do you mind tagging it?

I don't get what issue you are encountering. I suggest you rebuild your nightly version or use  0.5 version.


⚠ Bofrost.at has degraded performance

In 45eabeb, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1237 ms

Resolved: Bofrost.at performance has improved in ef79bd0 after 1 hour, 3 minutes.


Replicated Shared Tensor (RST): Hook method and Property

Feature Description
Write correct functionality of hook method and property behaviour of Replicated Shared Tensor (RST) that has been merged to the codebase.
Additional Context
Has a dependency on #164

@gmuraru  I would like to take this issue.


Add support for Alpine 3.21

This issue is created to track progress for the work to enable Alpine 3.21 support for .NET 8.0 and 9.0

[ ] [All Product Teams] Compatibility check and infra update
Do a compatibility check for the product with the new OS
Replace docker tags used in builds across repos and branches
Update CI legs to latest updated Dockerfile
Ensure that the correct Docker images used by teams are built in the dotnet-buildtools-prereqs (if applicable)

Created https://github.com/dotnet/dnceng/issues/4348 to track this work

Alpine 3.21 is officially released: https://alpinelinux.org/posts/Alpine-3.21.0-released.html

Container images are not released/officially supported yet.


Built value support with null safety

Ive taken the changes from https://github.com/KalilDev for adding support for built value Ive tested it and it all seems ok
however unfortunately I counldn't get Enums to work, Hive needs an empty constructor and enum class cant have one, there's probably something I'm missing (only spent a few hours with it) and i don't know if your happy to accept this as it is for now knowing it's limitations or if KalilDev can lend a hand (he has written code to work with this but it throws - Provide an unnamed constructor.)

Can you rebase from master?

Can you rebase from master?

when i do it tells me there is nothing to commit?

Have you tried "Fetch upstream" feature of github?

Have you tried "Fetch upstream" feature of github?

Same thing
https://drive.google.com/file/d/1EJDeYCMKw9f-8-Ji7tEhuRgpaNwkypsH/view?usp=sharing

how do we move forward? i did use master as my base is there something saying i havent?

how do we move forward? i did use master as my base is there something saying i havent?

why are you insisting on rebasing? for a public repo is it not better to have everybody merge?

how do we move forward? i did use master as my base is there something saying i havent?

why are you insisting on rebasing? for a public repo is it not better to have everybody merge?

To be clear i dont truly understand the difference and couldnt wrap my head around it so im in no way trying to assert that i have any real understanding of the matter 😂

how do we move forward? i did use master as my base is there something saying i havent?

why are you insisting on rebasing? for a public repo is it not better to have everybody merge?

To be clear i dont truly understand the difference and couldnt wrap my head around it so im in no way trying to assert that i have any real understanding of the matter 😂

Don't worry. I just worried if this merge could remove some of exists code as I saw from File changes. I'll check it soon and will merge.
Thanks for the contribution 😊

how do we move forward? i did use master as my base is there something saying i havent?

why are you insisting on rebasing? for a public repo is it not better to have everybody merge?

To be clear i dont truly understand the difference and couldnt wrap my head around it so im in no way trying to assert that i have any real understanding of the matter 😂

Don't worry. I just worried if this merge could remove some of exists code as I saw from File changes. I'll check it soon and will merge.
Thanks for the contribution 😊

Wow awesome thanks ❤

any idea when there might be a new build, would love to be able to use this without having to use my local changes

has this been abandoned?

Sorry for the late response. I'm currently only planning to work on maintaining existing features / bug fixes rather than adding new features because I don't have enough time to spent on maintaining new features. To support integration with 3rd parties I would suggest publishing them as independent packages because:

I have not enough experience with some of those packages
I currently prefer to keep current state of hive stable rather than adding new features to its core components

Also the PR have lots of patches for existing files and I'm a bit worried if merging it would cause issues with existing features. What do you think about that?


Undo last points method to the draw interraction

The pull request adds the ability to delete the last segments added during editing with the draw interraction.
Usage sample  :

var draw_interaction = new ol.interaction.Draw( {
  type : "Polygon"
});

// Remove last point on "delete" key when drawing a feature.
var onKeyboardEvent = function(event) {
  if (draw_interaction && event.keyCode === 8) {
    draw_interaction.removeLastPoint();
    event.preventDefault();
  }
}

$document.bind('keydown', onKeyboardEvent);

The proposed method tries to respond to issues posted via the links below, works on lines and polygons, and directly updates the preview (do not needs mouse move on the map to refresh).
http://gis.stackexchange.com/questions/152119/undo-last-point-when-drawing-linestring-possible-regression
http://stackoverflow.com/questions/28968064/remove-last-point-from-draw-interaction-in-ol3
https://groups.google.com/forum/#!msg/ol3-dev/O60t4yvJRh4/DAh7KS1Bp4sJ

Looks good @geonux. If you haven't already, please submit a CLA so we can merge this.

CCLA in progress...

The CCLA was mailed today.

Thanks @geonux.


CARBON-15759:Setting NO_ENTITY_PROPERTY

https://wso2.org/jira/browse/CARBON-15759

Closing since this caused regressions.

Reopening since this fix was causing regression due to the absence of a fix in synapse and this needs to be merged.

Integration tests:
https://github.com/wso2/product-apim/pull/639


Hangs upon launching NRO files on 5.1.0

I compiled a build from here but it doesnt load on 5.1.0   Here is the build i compiled.
https://github.com/BernardoGiordano/Checkpoint/files/2065308/96AC-42CB.zip

What exactly did you update on SD?

The files in the atmosphere folder   main and main.npdm

Here is my current installation
UPDATED.zip

Excuse me?


slight mis-match in video height width resulting in black bars

Just been trying this and really nice... it works really well... So hats off because it fixes a few issues which I came across with other scripts. The only thing I am seeing at the moment is a black bar to the left and right. I have quickly created an example and this effects mac Safari Firefox and chrome.. i haven't tested it on ie PC or any other PC browsers, just Macs.
The only way I got around it was by writing a style
iframe {height:102%}
and that does force it out to the correct size but this sounds like a bit of a mess to me.
link to my example can be found here:
https://infinit.io/_/qauLDbM
if you coment out the  iframe {height:102%} style within index.css you will see that the video then has a black vertcal border on both sides
All the best
Max

I can see a noticeable improvement on your page, but when I tried applying it to the existing SuperEmbed demo here, it actually caused black bars on the top and bottom. Maybe it's something to do with the CSS on your page?

I just uploaded SuperEmbed.js 2.0, that should fix the scaling issues.

Hi
yep I can confirm the version SuperEmbed.js 2.0 has fixed the issue.. not sure what it was in my html/css or if it was a little conflict mismatch but the latest release works and scales correctly with the same HTML without the 102% and  no black bars visible anywhere.
Thanks max

Great to hear it!


Thanks and a question about upstreaming

Hi, thank you for this wonderful library! We're creating a structure editor for ASTs for our pedagogical functional programming language, and have had a hard time finding a layout library that works well for ASTs. We recently discovered Tidy, and it looks very promising.
I have a question about submitting PRs. We've forked this repo in order to add Nix support, and in the process have cleaned up a few build- and packaging-related issues. We would like to upstream those changes, if you're interested. However, before we do that, I see that you're using npmmirror.com in the lockfile, rather than npmjs.org. Does npmmirror.com work better for you based on your location, or something like that? I ask because we've never heard of npmmirror.com and don't know anything about the organization/individuals who run it, and we're therefore uncomfortable using it for production. So for our own purposes, we're going to regenerate the package-lock.json file, which will complicate upstreaming.
Anyway, I'm not suggesting that you change anything on your end, just wondering whether you're committed to using npmmirror.com rather than npmjs.org. If so, we will just work around it if/when we upstream PRs.
Thanks again!

PRs are welcome! Yeah, npmmirror.com works better at my geo location. It's run by Alibaba. But I'm not committed to using it, you're free to change the lockfile to use npmjs.com instead.

Great, thanks! I'll close this now and submit an initial PR.


Updater broken on some windows machines.

Im not sure why it isnt working yet as its fine here.  GREAT!
INCLUDE THIS IN YOUR ISSUE:
Branch
Commit hash
Your operating system and python version
What you did
What happened
What you expected
If its a visual bug, screenshot or it didnt happen
What browser including version
Link to a copy/paste of your logfile with clear debug info of the error on PASTEBIN
ENABLING DETAILED DEBUGGING FOR LOGS
Shutdown HTPC-Manager
Start Htpc.py --loglevel debug
Start HTPC-Manager and wait for error to occure again


Change how Restic secret is created

There is a discrepancy between VSB and VSR specs, as VSB assumes the name of the Restic secret as "restic-secret," but VSR includes this field as a config value.

Add this as a config value to VSB. In the future, check if this repo is the same as bsl on dpa config.
See Rsync creation in MTC for example.

Closing because of duplicate issues #74

Closing because of duplicate issues #74


Cannot find 'LoginManager' in scope

Is it a security issue?
If you believe you have discovered a vulnerability or have an issue related to security, please DO NOT open a public issue. Instead, send us a mail to<EMAIL_ADDRESS>What did you do?

Please describe what you did before you encounter the issue.

What did you expect?

Please describe what you did expect to happen.

What happened actually?
Displaying error Cannot find 'LoginManager' in scope

Please describe what happened actually.

Your environment?

XCode 13.3
Swift

Some information of the environment in which the issue happened. LINE SDK version, Xcode version, iOS version, etc.

Sample project

It would be appreciated if you can provide a link to or update a sample project that we can download and reproduce the issue.

It is more likely a linking issue than a problem inside the package. Can you please attach or send us a minial sample project, so I could take a detail look into that to see what is going on.

@onevcat Thank you for your answer. I firegure out I need to change pod 'LineSDK' to pod 'LineSDKSwift'
But goto this page, when I clicked the button OK, an error message displayed. What should I do?
Safari can not open the page because the address is invalid

Brgs!!!

I guess that basically means you are not setting the callback URL scheme correctly in your Info.plist. Please make sure you are following the guide here to set the correct value (matching the setting Developer Console for your channel) to CFBundleURLSchemes key in your app, so LINE SDK can go back to your app by that scheme.

@onevcat So sorry for taking your time. I just set it as the guideline and now the button "OK" works now. But callback has something wrong. I click OK but the callback error is userCancelled
This is my code
struct LineLoginButton: UIViewRepresentable {
    class Coordinator: NSObject, LoginButtonDelegate {
        var parent: LineLoginButton

        init(_ parent: LineLoginButton) {
            self.parent = parent
        }

        func loginButton(_ button: LoginButton, didSucceedLogin loginResult: LoginResult) {
            LOGGING.debug("LINE didSucceedLogin token", loginResult.accessToken.value)
            LOGGING.debug("LINE loginResult", loginResult)
        }

        func loginButton(_ button: LoginButton, didFailLogin error: LineSDKError) {
            LOGGING.error("LINE login error", error)
        }

        func loginButtonDidStartLogin(_ button: LoginButton) {
            LOGGING.error("LINE login started")
        }
    }

    func makeCoordinator() -> Coordinator {
        Coordinator(self)
    }

    func makeUIView(context: Context) -> UIView {
        let view = UIView()
        return view
    }

    func updateUIView(_ view: UIView, context: Context) {
        let loginButton = LoginButton()
        loginButton.delegate = context.coordinator

        loginButton.permissions = [.profile]
        loginButton.presentingViewController = nil

        view.addSubview(loginButton)

        loginButton.translatesAutoresizingMaskIntoConstraints = false
        loginButton.centerXAnchor.constraint(equalTo: view.centerXAnchor).isActive = true
        loginButton.centerYAnchor.constraint(equalTo: view.centerYAnchor).isActive = true
    }
}

==== ERROR LINE login started
==== ERROR LINE login error authorizeFailed(reason: LineSDK.LineSDKError.AuthorizeErrorReason.userCancelled)

@onevcat Please forget the above, After I added SceneDelegate, it works now. I did not add this because my app does not have SceneDelegate class, so I have to add it.
func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {
        _ = LoginManager.shared.application(.shared, open: URLContexts.first?.url)
}

Thanks for the feedback. If your app is a scene based one, you need to add that method to handle result and give LINE SDK a chance to process the auth response.
Glad to hear it is working for you!


Type module

Okay, I can for the life of me not figure out how to make gulp work with type: module and esm. Gulp's docs aren't very helpful either. I tried, babel, esm, and ts-node and nothing worked.
The only way I found was to make the file end with .cjs and continue with CommonJS. Problem: This makes it impossible to require other ESM which we need to do.
The thing is: The problem is 100% with gulp itself. You can run ESM scripts with node (and ts-node) just fine, no problem. I'm contemplating yeeting gulp and making our own simple task runner (grunt seems to have similar levels of ESM support as gulp; none).
I already wasted close to 2 days of this, so please help...
@LeaVerou @mAAdhaTTah @Golmote @JaKXz

IMO in v2 we should move away from gulp and to just npm scripts.

I’m probably missing something major here, but why do we need ad hoc scripts to generate the changelog? GitHub these days supports auto-generating a changelog (when you generate a release), which we could then paste into CHANGELOG.md. Admittedly, it will not be as nice, but it seems to require a substantial amount of effort to have our own custom one.

I’m probably missing something major here, but why do we need ad hoc scripts to generate the changelog?

GH generated changelogs are just the list of commits since the last release. Our changelogs are a bit nicer than that. Also, we already have it, so why not keep it?
Also, changelogs don't have a lot to do with this PR, so I don't really see how this is relevant...

Closed in favor of https://github.com/PrismJS/prism/pull/3687.


Adding property decorator detection

Coverage remained the same at 100.0% when pulling 23671c2f10ced7394207c55ed7cdd4b125557061 on ktutnik:master into c568423380864bfa101dc9106f7c205f08afbe99 on kambojajs:master.

Coverage remained the same at 100.0% when pulling 23671c2f10ced7394207c55ed7cdd4b125557061 on ktutnik:master into c568423380864bfa101dc9106f7c205f08afbe99 on kambojajs:master.

Coverage remained the same at 100.0% when pulling 23671c2f10ced7394207c55ed7cdd4b125557061 on ktutnik:master into c568423380864bfa101dc9106f7c205f08afbe99 on kambojajs:master.

Coverage remained the same at 100.0% when pulling 23671c2f10ced7394207c55ed7cdd4b125557061 on ktutnik:master into c568423380864bfa101dc9106f7c205f08afbe99 on kambojajs:master.


Fixes #28590

Added a clarification explaining that nint's and nuint's max and min values are calculated at runtime. Also added that note to the table with the various types.
Fixes #28590

Edit by @billwagner Add fixes note in the PR description for automation and linking.

Thanks for the hints Bill, I believe the edits are fine.
I ran some tests, and noticed that in fact for these types, it doesn't really depend on the processor of the machine, but instead it depends on the platform target. I tried, on the same i7 computer, with the default settings (which targets x64) and got the corresponding max and min values. Then I changed the target to x86 and I get the expected values for 32bits . That is, as it says on the nint and nuint page (https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/integral-numeric-types#native-sized-integers), the value really depends on the executable settings, and not exactly on the physical processor in the machine. I suspect for other weird IOT cpus the same thing could apply.

Thanks again @rafcon-dev

@BillWagner ok, but then isn't the phrase "The sizes of those types depend on the processor." in contradition with what is on the nint and nuint page ("// output when run in a 64-bit process"), which seems to be correct?

@rafcon-dev
Yes, we should make that one additional change. I'd overlooked that in the existing diffs.

@BillWagner sure thing, I made a new PR for that


contributor

@all-contributors please add @Darlington02  for code

@all-contributors please add @mubarak23  for code

@all-contributors please add @Darlington02  for infra, code and review


Item upgrades information and artefacts bonus properties

Need info about weapon classes upgrades and info about artefacts additional properties
Weapon classes upgrades can be presented like this:
weaponClass: {
lvl1: {
damage: '+0.73',
spread: '-0.33'
},
lvl2: {
damage: '+1.62',
spread: '-0.72'
},
...lvlN: {
damage: '+x.xx',
spread: '-k.kk'
}...
lvl15: {
damage: '+30',
spread: '-15'
}
}

Yep, it would be absolute awesome to have invormation about artifacts additional properties in the DB.


feat: enhance summary for binarydata props

This PR enhances the description of model properties that are of type BinaryData.

No changes needing a change description found.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3289/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3289/


Add 12th/vectorOpGPU OpenCL

Here's an OpenCL version of the 12th session's code.
The host side of the implementation requires C++17.
Edit the Makefile's VARS to switch between OpenCL 1 and 2.

Thank you very much Ali.


[ISSUE #290]: add switch to enable/disable snapshot feature

add switch to enable/disable snapshot feature

Closes https://github.com/openmessaging/dledger/issues/290

@RongtongJin PTAL~


Add help file

Closes #39
Note:
I would maybe hold off on merging my other two PRs (#56 and #55) until this one is merged, so I can rebase the other PRs.

Thanks for all the PRs! Let me know when you want me to merge the other two.


Do we have Kubelet certificate rotation enabled?

@marcusbooyah: I assume we've already done this, but checking to be sure.
https://kubernetes.io/docs/tasks/tls/certificate-rotation/

We hadn't, but I just added it.


fix: conversation messages and event order

The type of this PR is: Bugfix

Description
When the conversation starts from Make Offer we don't see events being rendered in the conversation, like the message You sent an Offer of $XXX.
There are some open questions like messages and events are not grouped at the same time to render but not related to the scope of this PR.
Here the first 2 conversations started from Make Offer flow, the last one started from Inquiry.
https://user-images.githubusercontent.com/15792853/157627846-625c227b-e669-4ed9-95e2-f41b5633fb1e.mov
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix events not rendered in conversation when not from inquiry - araujobarret

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (fix events not rendered in conversation when not from inquiry - araujobarret)

  Generated by :no_entry_sign: dangerJS against 7d3c6b32cf9e2997429fc368b810ae6a50fd187a


⚠ Bofrost.fr has degraded performance

In 91382f9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1550 ms

Resolved: Bofrost.fr performance has improved in 8d30090 after 6 minutes.


Add Clear Cache to the extensions category

Thank you, @AhorIsaac for providing a wide range of amazing free tools that will be beneficial to many people. Your contributions are greatly appreciated.


Margin on profile sidebar bottom buttons

should be 24px bottom margin instead of 16

please make the icons slightly bigger

20px icon size itself would be nice

it will be then more accessible

👋


Bad Mojo Redux

Hello again Elisha,
like discussed here: https://github.com/CnCNet/cnc-ddraw/issues/16
dxwapper is the only wrapper that does not crash Bad Mojo Redux.
But for the moment, no fullscreen and we have only quicktime sound, no video.
As you know I'm a Linux user, I launch Windows games  with Wine.
Actually I'm using Wine 4.15 staging (Lutris version, virtual desktop mode on) on Ubuntu 19.04 with a Nvidia GPU.
I joined you log file for debug.
The idealistic objective will be to play this game FullscreenWindowMode , active vsync on with native gamer desktop resolution, with aspect ratio respected.
I played a lot with dwrapper.ini options without success.
Thank you for your help.
nota:
FullscreenWindowMode       = 1 --> I can not see menu
DdrawUseNativeResolution = 1 --> still 640x480 wine window
dxwrapper-badmojo.log

Hello @legluondunet, I will take a look at this when I get a chance.  May not be for a couple of weeks.

I'm really really struggling to see a reason in caring for wine here.
Dxwrapper exists to patch the godawful bugs in windows that you can't workaround otherwise.
Wine is FOSS and if you happen to understand the problem, you can actually fix it properly and neatly.
If you have no videos check this, and if the game crash on start: a) it was reported to work here, so report to them b) it also mean you can use an older version and/or bisect the breaking commit

Hello @mirh ,
I didn't ask @elishacloud to resolve a Wine bug, but to try to make dxwapper Bad Mojo compatible. It is not a Wine bug but a graphic game limit: you can not play this game windowed, for the moment no wrapper can launch this game windowed. The benefit here will be to play this game fullscreen (window mode borderless) at your desktop native resolution, not in 640x480.
Bad mojo works good on Linux with Wine.
You can use other wrappers on Linux with wine to play your old games at fullscreen native desktop resolution: DxWnd, dgVoodoo, cnc-draw, they are all Wine compatible and like Windows gamers, Linux gamers use them to play their old games fullscreen.

you can not play this game windowed, for the moment no wrapper can launch this game windowed

I hope you meant fullscreen, otherwise I have some headache to solve in reading your post.
If that's the case.. Uh, sorry.
Though it'd seem super strange for wine/X not to be able to stretch the window in fullscreen.

on Windows and if it works on Windows, it could work on Linux with Wine too.

Totally fair.. But your report just mentioned wine.

GOG lists the Bad Mojo Redux as not supported on Windows 10 (or more accurate, only supported on Windows XP, Vista, 7 and 8).  With the latest (unreleased) version of dxwrapper I can get the game working on Windows 10 in exclusive fullscreen and windowed fullscreen using Dd7to9.  I believe this issue is specific to Wine, unless I misunderstand something.
Note: on Windows the game still runs in 640x480, but puts a large black border around the game.  I believe this is the intent of the game when running in larger than 640x480 resolutions.  The Dd7to9 feature is only intended to exactly convert ddraw to d3d9, not to change the way the game works.
However, you may be able to eliminate the black box around the game by modifying the ini file and forcing a smaller resolution, though I did not have time to try it yet:
DdrawOverrideWidth         = 640
DdrawOverrideHeight        = 480

@elishacloud  I followed your advices and now I can launch Bad Mojo Redux fullscreen (Native desktop resolution Windowed/Fullscreen), can alt+tab, ratio ok, my desktop kept his native resolution (1920x1080).
But the game still 640x480:

An idea/option to strech/scale it with dxwrapper?

This is exactly how it looks on Windows as well.  I don't have any scaling options yet, but I have considered making some.  Other games would benefit from these options as well.  Let me see if there is something I can do quickly.
BTW: I also noticed from the log file that several API's cannot be hooked because they are "not hotpatch aware".  I wonder if you can help me troubleshoot those issues?  This is the same issue that Silent Hill 2 had.  I would like to fix the hot patching so it works even on Linux, if possible.

@legluondunet, on Windows there is an option called "Run in 640x480 screen resolution".  If I enable this option it is able to fill the screen.  I am not sure if there is an equivalent option on Linux.

Ok, I was able to stretch it to fill the screen.  However, there are a few things to note:

I was unable to stretch the menu screen as the menu screen is done via GDI and dxwrapper does not do anything with GDI.  I doubt I will fix this anytime soon.
For this test build I just hard coded the stretched resolution to be 640x480. I will make this customizable later, but this will work fine for this game.
This test build does not work correctly if you have dual display setup unless you have them set to duplicate the display.  There is nothing I can do in my wrapper about this because the game already gets the resolution before loading my wrapper.  This will need to be fixed by GOG, or someone will need to build a replacement launcher to replace the GOG launcher.
If you are NOT using the GOG build then this module won't work with any resolution larger than 1920x1080.  That is the max resolution this game can support.  There is nothing I can do in my wrapper about this because the game already gets the resolution before loading my wrapper.  So you need the GOG version to support any larger resolution.  Basically the GOG launcher sets the screen resolution to 1920x1080 at game launch if the resolution is larger than that.

Here is the test build:  dxwrapper.zip

Seriously, individual games enhancement should be left out of here.
There is a reason if 13AG has an entire project just for that.
If really really really any, something that may still fit is having control over "the kind of scaling". For example, as far as I am told, if you have a VGA monitor the graphics card cannot handle the various modes for you.

Unfortunately it looks like only the videos in this game uses DirectX.  The rest of the game play uses GDI.  So only the videos scale.  However, the good news is that I created a fully customizable scaling feature when converting from ddraw to d3d9.
Here is the updated module with scaling enabled: dxwrapper.zip

Seriously, individual games enhancement should be left out of here.

I completely agree.  But if there is a game that does not work with dxwrapper I want to fix it so that it works with dxwrapper.  All the fixes I add to dxwrapper are generic.

If really really really any, something that may still fit is having control over "the kind of scaling".

Yep, added!  I will check in the code later.

I guess that's using bilinear/bicubic?
Would be perfect if you could support nearestneighbour/integerscaling.

I tried your last two releases
dxwrapper-badmojo.log
, each time I didn't modify dxwrapper.ini and used the one that is in your archive, no changes, I always obtained the same result.
I joined you the log file for information.
I thank you very much for the interest you gave to my request and the positive result is that you ameliorate dxwrapper compatibility for this game.

I forgot: did you see that the "launcher.exe" sources are available in "extras" folder?

I guess that's using bilinear/bicubic?

Currently I just use D3DTEXF_POINT which is just nearest neighbor.  See here.

Would be perfect if you could support nearestneighbour/integerscaling.

It is easy to change this, but if I use anything other than nearest neighbor it breaks games that use palettes since I use a pixel shader for the palette and other interpolations expect the colors to be gradient, which is not usually true for palettes.
I could change the code from using pixel shaders to using my own code to interpret the palettes, but that would mean the code would be done by the CPU and not the GPU so it would be slower.  Unless there is some other GPU function that can interpret the the palettes before applying the D3DSAMP_MAGFILTER I plan to just leave it at nearest neighbor.
@legluondunet, would you mind testing the game once more?  I noticed there was some issues with dxwrapper hooking the APIs and I would like to troubleshoot that, if possible.  I don't expect the behavior to be any different, but I did add some code for logging.
Can you try with the test module below and send me the logs?
Here is the test module: dxwrapper.zip

NN is perfect.
I guess like the only thing you miss is the integer scaling "clamp" setting then.

I do have an option to preserve aspect ratio, but integer scaling clamp is a good idea.  I'll add it to my list.  Thanks!

@legluondunet, would you mind testing the game once more? I noticed there was some issues with dxwrapper hooking the APIs and I would like to troubleshoot that, if possible. I don't expect the behavior to be any different, but I did add some code for logging.
Can you try with the test module below and send me the logs?

@elishacloud , I tweaked and I tweaked this game numerous times in last days, I tried with DxWnd, dgVoodoo 2...added extern dll...It's a pleasure for me to be your Linux Wine tester and to obtain cleaner results:

I rebooted my computer
I reinstalled Bad Mojo Redux Gog version
I use last WIne version 4.15-staging with only Wine directx builtin dll (no directx native dll)
I will post you 2 log: with and without d9vk

My config:

Ubuntu 19.04 - NVidia GPU - WIne 4.15 -Lutris installer for  Bad Mojo Redux Gog version:
https://lutris.net/games/bad-mojo-redux-gog/installer/edit

without dxwapper:
Wine virtual desktop window 640x480 (or 800x600?), video ok, menu ok, game ok.
with dxwapper (added dsound dll to native, dxwrapper.ini not modified, d9vk off):
Wine virtual desktop window 640x480 (or 800x600?), no video (only the sound, black window), menu ok, game ok.
url: https://github.com/elishacloud/dxwrapper/files/3613131/dxwrapper.zip

dxwrapper-badmojo.log

with dxwapper (added dsound dll to native, dxwrapper.ini not modified, d9vk 0.20 on) :
Wine virtual desktop window 640x480 (or 800x600?), no video (only the sound, black window), menu ok, game ok.

dxwrapper-badmojo.log

FullscreenWindowMode       = 1, d9vk on:
video on, menu off (only a black window), d9vk active

dxwrapper-badmojo.log

same result as 4) with dx9vk off
dxwrapper-badmojo.log

I guess like the only thing you miss is the integer scaling "clamp" setting then.

@mirh, I added integer scaling clamp to the project.  2bdfdd47c8a82bcedeb740d1f6c07544a95fc13d
I have to say that when scaling it looks a lot better when you enable integer scaling clamp!  Good call!


fixes compatibility and png issues

fixes compatibility and png issues
compatibility below 21
Description
As  android:drawableRight is not compatible with lower versions I added custom text view and custom button view to make app:drawableRightCompat which is compatible.
VectorDrawableCompat.create() cannot load png images it will only inflate vector drawables, so when png is encountered it throws an error.
This is resolved using AppCompatDrawable.getDrawable() . For more info see here.
Related issues and discussion
closes #753
closes #571
closes #621
Checklist

[x] Apply the AndroidStyle.xml style template to your code in Android Studio.

[x] If you have multiple commits please combine them into one commit by squashing them.

[x] Read and understood the contribution guidelines .

Hi @teolemon, I've verified this one fixes #753 & #571. Tested with API 19 and 27. (I haven't been able to reproduce #621). If merged, this PR supersedes PR #784 (that addresses #571) as it keeps backward compatibility with older android versions.

merged, thanks :)


Resize the images in the memos

Describe the solution you'd like
The image width on a single memo card stretches to fill the entire card, resulting in the height of the vertically oriented image being excessively large.
Type of feature
User Interface (UI)
Additional context
No response

https://github.com/usememos/memos/pull/4239


Fix crash on unknown author/committer

When a GitHub user account has been deleted, the contribution script will crash. This fix assigns a commit to 'unknown' if no author or committer could be determined.

@bengl Can we please merge this? :D

Sure! Sorry for the delay!

Cool, thanks!

I've also added you as a collaborator.  Enjoy committing!


NamespaceOperations.UpdateAuthorizationRule not including SecondaryKey

When trying to use NamespaceOperations.UpdateAuthorizationRule to update a ServiceBusSharedAccessAuthorizationRule, it does not handle the SecondaryKey.
The response then comes back with its SecondaryKey set to NULL -- and causes the secondary key to be lost, as can be seen on the management portal:
manage.windowsazure.com/@USERNAME#Workspaces/ServiceBusExtension/Namespace/QUEUENAME

Ideally, the fix to this would be to add to NamespaceOperations.UpdateAuthorizationRule a section in order to handle the SecondaryKey :
if (rule.SecondaryKey != null)
{
	XElement secondaryKeyElement = new XElement(XName.Get("SecondaryKey", "http://schemas.microsoft.com/netservices/2010/10/servicebus/connect"));
	secondaryKeyElement.Value = rule.SecondaryKey;
	sharedAccessAuthorizationRuleElement.Add(secondaryKeyElement);
}

Thank you,
Andy M.

Published. Please use Microsoft.WindowsAzure.Management.ServiceBus version 0.18.0-preview


Add card portfolio for the rest of countries

Like this image : public/assets/images/cm/card-portfolio.png
It would be nice to have a banner like for others countries.
The card below is for TG, for example :

Done :)


Change bounding box coordinates' order for v2.0.0?

What problem does your feature proposal solve?
Geographic bounding boxes usually follow the standard format of left, bottom, right, top (e.g., at OpenStreetMap). For whatever reason, OSMnx instead expects them in the format of top, bottom, right, left (equivalent to north, south, east, west). I'm probably responsible for this oddity, but the reason behind it is lost to time. Currently, users have to read the docstring to know to use this non-standard format.
What is your proposed solution?
We should consider changing the expected bounding box format package-wide to the usual standard left, bottom, right, top in advance of the v2.0.0 release (which will have some breaking changes anyway).
Drawbacks: old code using the old format will break in v2.0.0.
Advantages: OSMnx will be aligned with global standards, creating less surprise for new users and eliminating a common source of unexpected bugs.
Additional context
I'd be grateful for any comments/feedback on whether the advantages are worth the drawbacks. It'd be an easy fix prior to the next beta release, if it's worth doing. FWIW, my current opinion is "yes."

I have thought about it for a while, but I'm in support of this. On the short term it will hurt, but on the long term it's clearly the preferred solution.
One major advantage is that you could directly pass a Shapely geometry with the .bounds method, which uses the order you propose.

WIP in #1196


Write and share a proposal for our browser support

What
We should write up our findings and decisions into a proposal of some sort.
Why
The proposal lets us collect all our research findings, decisions and future planning into one place. This gives us something to share among GDS (e.g: the frontend community) and also outside of GDS, e.g: the x-gov community, to see if our approach will work for them.
Who needs to work on this
Developers; Tech Writer
Who needs to review this
Developers; Tech Writer; Frontend Community; X-Gov Community
Done when

[x] Draft a proposal in the draft document. Consider what impact these changes will have on our codebase/users
[x] Draft an email and Slack message for sharing the proposal
[x] Copy the proposal into a new document (to avoid noise on the original doc) and allow people to comment
[x] Update feedback date in proposal doc
[x] Share proposal with the GDS Frontend community (core-frontend mailing list)
[x] Review feedback from GDS Frontend community
[x] Reply to comments from GDS Frontend community
[x] Decide format for sharing proposal with x-gov, e.g: Github discussion, entry in Github architecture repo
[ ] Share proposal with wider x-gov community to gather feedback
[ ] Write any follow-up cards (see below)

If it looks like the proposal will be accepted, we should write cards to implement/decide the following:

[ ] Card to figure out documentation for v4 (design system AND frontend docs)
[ ] Card for ensuring our support branch release process works for previous major versions (existing card)
[ ] Card for revisiting v4 support in 12 (?) months and either extending the time limit or ending support then
[ ] Any other cards for actually doing this work and reducing the support to functional (e.g: updating Github READMEs, removing polyfills, stop serving JS to IE etc)
[ ] Removing the IE8 stylesheet
[ ] Updating govuk-frontend docs (e.g: README, accessibility/browser testing) with new browser support level, referencing v4 and what we mean by 'functional'
[ ] Drafting answers for potential questions we might get on support

Resource that may be helpful for drafting a proposal: https://technology.blog.gov.uk/2018/06/26/changing-our-testing-requirements-for-internet-explorer-8-9-and-10/

Matt has suggested that we should include something in comms on this change to say that it doesn't mean GOV.UK (or in our case, GOV.UK Frontend / the Design System) will stop working in older browsers. See https://docs.google.com/presentation/d/1L93j8m4L2R2QU87FrKcMSrNzyD1fi3FSMzEGCfTRTvs/edit#slide=id.g1132d02f0e8_0_176

@vanitabarrett Should this proposal have a similar structure to our test fixtures and import removal proposals?

@EoinShaughnessy I think it probably makes sense to use that at least for a starting point - we can change it if we find the structure doesn't work well for us this time.

The proposal is ready to go now. The next steps are to copy the proposal into a new doc to avoid comments generating noise on the original doc (if we think that's helpful), and draft and email/Slack message to share it with the core-frontend mailing list. I've added those as checklist items to this card.

Have shared draft proposal with GDS frontend channel and core-frontend mailing list.

I've posted another reminder into the frontend channel on GDS channel.

The JavaScript squad had a catch-up today and we looked through the comments we've received from the FE devs. We think we probably need to pin down some of the details to our approach before we send this out to the wider community. I've written up a card for that here: https://github.com/alphagov/govuk-frontend/issues/2579
For now, I'm going to put this into Blocked

@querkmachine should we move this into Blocked while the proposal is out to GDS developers?

@vanitabarrett Can do. Makes sense from a tracking perspective, if not a labelling one—it's still "in progress", just with third-parties.

Moved back to in progress as the proposal is being prepared for sharing with the wider community.

The proposal is now open for public and cross-government feedback: https://github.com/alphagov/govuk-frontend/discussions/2607

Moving into Blocked until 13th May (the deadline for feedback)


[REVIEW]  fliscopt : Flight Scheduling Optimization in Python

Project link
A flight scheduling optimization algorithms in Python.
https://github.com/Agrover112/fliscopt

Looks good, reviewed on live stream, some suggestions...

quite a lot of branches, these should probably be reduced
suggest using semver in your Releases
remove wiki and use docs folder
.vscode and .DS_Store files should not be committed


Add video encoding example.

I don't know exactly how to fill in the fields of the structures. It would be good to know the basic combination of version, SPS, PPS which works in most cases. And what the Bytes should look like, raw bytes of frame in the R8G8B8A8 format i hope.

Hey @pudnax,
I don't have an encoding example, but have you checked out the mp4copy example? If you have the sps/pps and sample data, you can write it in the TrackConfig and sample writer.

Hey @pudnax,
I don't have an encoding example, but have you checked out the mp4copy example? If you have the sps/pps and sample data, you can write it in the TrackConfig and sample writer.

Closing. Feel free to respond if any other questions. Thanks!

Closing. Feel free to respond if any other questions. Thanks!


[Needs Review]b07902089 李智源

What is the most challenging part in this homework?
The most challenging part in this homework is learning how to  use github especially rebasing.
Is this homework helpful for you?
Yes,I learned some knowledge about Git and Python
Is there any suggestion?

PR readiness check list

[  ] Did it pass the Flake8 check?
[  ] Did you test this PR?
[  ] Did you change the title of this PR to the correct format ([status] student_ID)?

@ZG926  Your commit message is not linked to your profile. See https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/ and https://www.git-tower.com/learn/git/faq/change-author-name-email to fix it.

I have just changed the author of the commit messages to my profile

I've just linked all the previous commit messages to my profile

The code for my task8 is refer to this website :  https://docs.python.org/3.4/howto/urllib2.html


TypeError: convolution() got multiple values for argument 'weights_regularizer'

I got error like this, how do I fix it, please help me
Traceback (most recent call last):
File "D:/Workspace/PythonProjects/studyProjects/multisensory/src/sep_video.py", line 398, in
ret = run(arg.vid_file, t, arg.clip_dur, pr, gpus[0], mask = arg.mask, arg = arg, net = net)
File "D:/Workspace/PythonProjects/studyProjects/multisensory/src/sep_video.py", line 294, in run
net.init()
File "D:/Workspace/PythonProjects/studyProjects/multisensory/src/sep_video.py", line 42, in init
pr, reuse = False, train = False)
File "D:\Workspace\PythonProjects\studyProjects\multisensory\src\sourcesep.py", line 953, in make_net
vid_net_full = shift_net.make_net(ims, sfs, pr, None, reuse, train)
File "D:\Workspace\PythonProjects\studyProjects\multisensory\src\shift_net.py", line 419, in make_net
sf_net = slim.conv2d(sf_net,num_outputs= 64, kernel_size= [65, 1], scope = 'sf/conv1_1', stride = [4, 1], padding='SAME', reuse = reuse)
File "C:\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\contrib\framework\python\ops\arg_scope.py", line 183, in func_with_args
return func(*args, **current_args)
File "C:\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\contrib\layers\python\layers\layers.py", line 1154, in convolution2d
conv_dims=2)
File "C:\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tensorflow\contrib\framework\python\ops\arg_scope.py", line 183, in func_with_args
return func(*args, **current_args)
TypeError: convolution() got multiple values for argument 'weights_regularizer'

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

It has been 15 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 30 days with no activity and the awaiting response label was assigned. Is this still an issue?

Closing this issue since the issues template was not filled out.


PR

Is this how you PR?

Ok, I added a Meme making command, and some animal API comamnds. Feel free to DM/Ping/Respond with issues or things I need to fix. I will fix them ASAP.

Also, uh, don't ask about PR Merge from my repo to my repo...
I'm new to github lol.

Also, would prefer you split these into two separate CCs next time (meme and animal).

The two CCs should be separate unless I did something wrong with making the new files.

I will close this PR.