trace: explain that spans have two halves if resurrected at the server

If a trace.Span is created from an incoming request, SpanFromRequest will return a second half for the original span created remotely. Second halves can create children and are finishable. They might traced or not traced and that attribute should be passed down to the children.
Document how SpanFromRequest work and the relationship with the two halves.

Hi,
I want to ask and this issue and https://github.com/GoogleCloudPlatform/google-cloud-go/issues/538 seem to be related to my question.
I have a http.Handler that handles requests that are both traced and not traced by remote clients.
The problem I'm facing is that there is no way to tell if the span returned by SpanFromRequest will be uploaded to the server or not other than checking if the X-Cloud-Trace-Context header is set.
Is this the right way to do it, and can I expect that this behavior will be stable enough?
func traceHandler(w http.ResponseWriter, req *http.Request) {
	span := traceClient.SpanFromRequest(req)
	if xtrace := req.Header.Get("X-Cloud-Trace-Context"); xtrace == "" {
		span = traceClient.NewSpan("trace")
	}
	defer span.Finish()

	// Do some work by calling some downstream dependencies.
}

Thanks and regards,
Ivan

SpanFromRequest will always return a non-nil span and will upload depending on the client sampling policy. You should be able to achieve the behavior simply by:
func traceHandler(w http.ResponseWriter, req *http.Request) {
	span := traceClient.SpanFromRequest(req)
	defer span.Finish()

	// Do some work by calling some downstream dependencies.
}

The problem is that I want to upload the traces regardless of the client. The doc for SpanFromRequest says:
...
If the request is not being traced, then a *Span is returned anyway, but it will not be uploaded to the server -- it is only useful for propagating trace context to child requests and for getting the TraceID. ...

This is why I add the check for the X-Cloud-Trace-Context - this is the mechanism I'm using to determine whether the request is being traced by the client which sent it. If it is traced - it will be uploaded based on its sampling policy. But if the header is missing, I'm creating a new span - to make sure that it will get uploaded too.
Thanks,
Ivan

This package has been obsoleted by  go.opencensus.io/trace.


Questions to be asked on test entry

WIP for CDCGov/prime-central#56.
Known current issues:

[ ] no "Add to Queue" button at the top (just cancel). This is probably the biggest pain to fix, actually.
[x] no "No Symptoms" checkbox, which needs a little poking at to get the least bad approach using our component library
[ ] checked options are all funny looking, thanks to some CSS argument between us and the CMS design system CSS.
[x] "cancel" doesn't actually work, which does admittedly seem like a bit of a problem
[x] answers look like they are being stored, but they actually are not
[ ] various radio buttons that are supposed to be in a single row, are not.
[x] dialog needs to appear in enqueue flow as well
[x] prior test and symptom dates should be validated
[x] prior test details should be disabled if the answer to "first test" is Yes
[ ] we should have a warning dialog for saving incomplete answers
[ ] queue entries should be correctly tagged if the answers have been provided
[ ] test submission should also have a warning dialog for incomplete answers

@benwarfield-usds and I have conspired to make progress on this. He's going to make a few more changes and then merge it even though there are some display issues from the dueling design systems. Then I'll figure out a fix for that. If it turns out we can'f fix by Tuesday it's still possible to user test, the checks just look wonky.


Open a ticket in jira ASF

@davelester
I will open a ticket when I finish to modify the tutorial

https://issues.apache.org/jira/browse/AURORA-1433


Folder management

Hi,
I'm using NodeJs to develop toolkits for gcp resource managements.
I would like to know if it's planned to support folder management or not in this library (basic CRUD operations of folder for instance). (Or maybe I not in the right place / repository ?)
Thanks a lot.
YL

@jacyuan you are at right place currently We have only project API I will take a look for folder API.

@laljikanjareeya  ok, nice, thanks for your reply.

Folders should now be supported as of v3 of the API.


Use styled checkbox in RiscScoringForm

Problem
RiscScoringForm.js is not using styled checkbox

Expected Behavior
RiscScoringForm.js uses Checkbox.js component

@followdarko can you please take a look a this?


Another fix to close game sequence

There's another report of the zoom in issue.
https://discord.com/channels/695809740428673034/711649658220314635/1231603132509720766
They report it only occurs every 150 resets, so I'm guessing that sometimes the program isn't respecting the delay between the 2 home button presses. Because from my testing, the zoom feature should only activate if the delay between home button presses is less than 40 ticks (currently, the delay is 100 ticks). I'm hoping that increasing the delay between presses and using wait_for_all_requests will solve the issue.

From my testing on SV, this close_game sequence works with and without video input.


Add emoji

closes #5074
What does this PR do?
Added the emojis which were not visible earlier
Description of the task to be completed?
Some of the emojis on the support website were not visible earlier. Then I added an unpkg script in the HTML file and used the script to add the emoji.
Screenshots (if appropriate)

@schmelto This PR looks good to merge.

@2802AdityA Please resolve the branch conflicts.


detectFromUri works fine in android but it returns false in iOS

I used  https://github.com/jeanpan/react-native-camera-roll-picker#readme to get the image from photo library, it returned uri: ph://11A68DD6-A651-462D-BDAB-68FB853ED141/L0/001
Unfortunately, detectFromUri  always returns false and show the following error in console:
NSURLConnection finished with error - code -1002
However, the Image Control can show the image with that uri .
Here is my source code : https://github.com/haison8x/react-native-test-ocr

No.
This library works. Your is not work. 👎
You can double check.


Cannot download more than 2 videos/time from file

Hello,
i'm trying to download videos from urls stored in a txt file: the first two are downloaded smoothly, when the third url is reached this is the error code i get:

[ERROR] Error: Request failed with status code 401
at createError (/home/caesar753/destreamer-UniPi/node_modules/axios/lib/core/createError.js:16:15)
at settle (/home/caesar753/destreamer-UniPi/node_modules/axios/lib/core/settle.js:17:12)
at IncomingMessage.handleStreamEnd (/home/caesar753/destreamer-UniPi/node_modules/axios/lib/adapters/http.js:236:11)
at emitNone (events.js:111:20)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1064:12)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9) `

You should check with the owner of the correct project here https://github.com/Guray00/destreamer-unipi


No module named 'bjoern'

Which version of Pi are you using: PI4b-4g
Which github revision of software: image_2023-02-11-RaSCSI-v23.02.01-lite
Which board version: 2.4a
Which computer is the PiSCSI connected to: Quadra 800

Due to the major changes with the project since my last update, I decided to backup my configs and data, and perform a full re-image.
Upon starting up, I configured wifi, localizations, and changed default password.
When I attempt to load the web interface, I got the landing page for a long time.
This is the output of journalctl -f while attempting to load the config page on a fresh image.
Mar 20 14:23:12 piscsi systemd[1]: Started PiSCSI-Web service.
Mar 20 14:23:21 piscsi PISCSIWEB[1445]: Warning: Not running from a valid git repository. Will not be able to update the code.
Mar 20 14:23:23 piscsi PISCSIWEB[1451]: compiling catalog src/translations/sv/LC_MESSAGES/messages.po to src/translations/sv/LC_MESSAGES/messages.mo
Mar 20 14:23:23 piscsi PISCSIWEB[1451]: compiling catalog src/translations/zh/LC_MESSAGES/messages.po to src/translations/zh/LC_MESSAGES/messages.mo
Mar 20 14:23:23 piscsi PISCSIWEB[1451]: compiling catalog src/translations/fr/LC_MESSAGES/messages.po to src/translations/fr/LC_MESSAGES/messages.mo
Mar 20 14:23:23 piscsi PISCSIWEB[1451]: compiling catalog src/translations/de/LC_MESSAGES/messages.po to src/translations/de/LC_MESSAGES/messages.mo
Mar 20 14:23:23 piscsi PISCSIWEB[1451]: compiling catalog src/translations/es/LC_MESSAGES/messages.po to src/translations/es/LC_MESSAGES/messages.mo
Mar 20 14:23:23 piscsi PISCSIWEB[1445]: Starting PiSCSI Web UI ...
Mar 20 14:23:24 piscsi PISCSIWEB[1453]: Traceback (most recent call last):
Mar 20 14:23:24 piscsi PISCSIWEB[1453]:   File "/home/pi/piscsi/python/web/src/web.py", line 12, in <module>
Mar 20 14:23:24 piscsi PISCSIWEB[1453]:     import bjoern
Mar 20 14:23:24 piscsi PISCSIWEB[1453]: ModuleNotFoundError: No module named 'bjoern'
Mar 20 14:23:24 piscsi systemd[1]: piscsi-web.service: Main process exited, code=exited, status=1/FAILURE
Mar 20 14:23:24 piscsi systemd[1]: piscsi-web.service: Failed with result 'exit-code'.
Mar 20 14:23:24 piscsi systemd[1]: piscsi-web.service: Consumed 11.583s CPU time.

I am able to impport the python bjoern module in a quick idle session without any errors, and pip shows it properly installed in system level with correct permissions, so I'm scratching my head as to why isn't working.

This issue is usually caused by missing or incomplete python venv installations. You may have had unstable network connection while installing piscsi, or when launching piscsi-web for the first time.
I wrote a section on the wiki for this issue: https://github.com/PiSCSI/piscsi/wiki/Troubleshooting#user-content-Web_Interface

That did indeed fix it.
Though the fact that this is happening with the recommended image may still need to be looked at?

I guess one thing we could try is to pre-cache python libraries in the image to bypass the common fail state.
@akuker Is this something that's possible in the image generation script?

I'm going to close this since it's been resolved.

It's not resolved because the same thing just happened to me.

@sqwirral It is resolved in the bleeding-edge development code. We're fixing a few last bugs now in preparation for a stable release. Please bear with us a little longer!


7.1.0

The action generator now supports inheritance.
Added an AbstractReducerBuilder to mitigate type issues combining ReducerBuilders for abstract state.
Added reducer builders for all collection types in built_collection. This means you can now write reducers that rebuild just a collection.

Codecov Report

Merging #39 into master will decrease coverage by 2.88%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage     100%   97.11%   -2.89%
==========================================
  Files           6        6
  Lines          76      104      +28
==========================================
+ Hits           76      101      +25
- Misses          0        3       +3

Impacted Files
Coverage Δ

lib/src/reducer_builder.dart
92.1% <89.28%> (-7.9%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeddcd2...e9d834c. Read the comment docs.


added uploads

Added uploads

Current coverage is 31.44%

Merging #79 into master will not affect coverage as of 2a00b21

@@            master     #79   diff @@
======================================
  Files            4       4
  Stmts          159     159
  Branches        33      33
  Methods          0       0
======================================
  Hit             50      50
  Partial          1       1
  Missed         108     108

Review entire Coverage Diff as of 2a00b21

Powered by Codecov. Updated on successful CI builds.


Update knex readme

The warning is no longer relevant. ./build-test-db.sh is not available when installed from node modules.

Out of date with: https://github.com/keystonejs/keystone-5/pull/1468


Pending spec demonstrating correct handling of cookies that are set without a path

Relevant spec is RFC 2109, section 4.3.1: Interpreting Set-Cookie:
"Path: Defaults to the path of the request URL that generated the
Set-Cookie response, up to, but not including, the right-most /."
Rack/test strips the entire final component of the URL instead of just
the right-most "/".

Merged, thanks


ENH add option for positive simulated data in make_correlated_data

This feature is necessary for the NNLS benchmark (see benchopt/benchmark_nnls#12)

I don't know if it's worth adding one parameter. Do you envision usecases apart from NNLS ? Otherwise this can be handled directly in simulated.py in the NNLS benchmark (use the function to generate X, w, then cast to positive and generate y manually)
My 2 cents. It seems @agramfort disagrees here : https://github.com/benchopt/benchmark_nnls/pull/12#issuecomment-1181757270

I'm ok with both solutions. As you prefer.

will do

I would not do y=abs(y) just to keep things simpler

Message ID: @.***>

I am -1 on merging this one, IMO it's only needed in the NNLS benchmark and thus should be implemented over there rather than in the main codebase.
@tomMoral if you agree we can close

Yes I agree this is very specific and having too many parameters make it harder to use/maintain so let's not add this as one can simply call make_correlated, take abs value and regenerate Y.

Thanks a lot @cassiofragadantas anyway, sorry to have you made the code for not using it in the end.

No problem ;) I will make the modifications directly on the NNLS  simulated.py  as suggested by @mathurinm


BUG: skew, kurtosis return np.nan instead of "propagate"

Initial guess
I thought "propagate" just calculates with nans in the arrays, like np.sum, so we get the correct shape with just some extra nans.
Instead we get a scalar nan back
https://github.com/scipy/scipy/blame/v0.17.0/scipy/stats/stats.py#L1319
possible candidate for
https://github.com/statsmodels/statsmodels/pull/2800
>>> aa = np.arange(5 * 4.).reshape(5,4)
>>> aa[0,1] = np.nan
>>> np.sum(aa, 0)
array([ 40.,  nan,  50.,  55.])
>>> from scipy import stats
>>> stats.kurtosis(aa, axis=0)
array([-1.3,  nan, -1.3, -1.3])
>>> stats.skew(aa, axis=0)
array([  0.,  nan,   0.,   0.])

>>> scipy.__version__
'0.15.1'

The actual problem for the statsmodels case seems to be scalar versus array return
continued example
1-d versus 2d inputs
>>> stats.skew(aa[0], axis=0)
nan
>>> stats.skew(aa[1], axis=0)
0.0

>>> stats.skew(aa[:1], axis=1)
array([ nan])
>>> stats.skew(aa[1:2], axis=1)
array([ 0.])

>>> np.sum(aa[1], axis=0)
22.0
>>> np.sum(aa[1:2], axis=1)
array([ 22.])

>>> np.sum(aa[0], axis=0)
nan
>>> np.sum(aa[:1], axis=1)
array([ nan])

That's indeed a regression that needs fixing. I thought we had not merged one PR yet with the functions that suffered from this, but apparently we missed one.

This seems to be a pattern that has been added to several reduce functions
https://github.com/scipy/scipy/commit/73c4f620bb6602632f6539ca3764a5d8583172b8
I think statsmodels is also using normaltest, skewtest and kurtosistest, but in general we are not supposed to have nans in the calculated data, so there are no broken test cases.

I'll change the milestone to 0.17.1 because this functionality is new in 0.17.0 so it could be good to have it fixed in the 0.17.x series.


Bug: Broken production deploy with mega mode

Apparently deploy script is using not defined fulL_cmd variable for compiling rails assets.
https://github.com/tongueroo/jets/blob/9b8dd19b948e0b16494673dd6031ff9cd3a5a10f/lib/jets/builders/code_builder.rb#L224
Traceback (most recent call last):
	22: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `<main>'
	21: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `eval'
	20: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/jets:23:in `<main>'
	19: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/jets:23:in `load'
	18: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/exe/jets:14:in `<top (required)>'
	17: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/cli.rb:5:in `start'
	16: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/cli.rb:21:in `start'
	15: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/base.rb:27:in `perform'
	14: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/base.rb:38:in `dispatch'
	13: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	12: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	11: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	10: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/main.rb:21:in `deploy'
	 9: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/deploy.rb:29:in `run'
	 8: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/deploy.rb:50:in `build_code'
	 7: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/build.rb:26:in `build_code'
	 6: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:36:in `build'
	 5: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:215:in `compile_rails_assets'
	 4: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/bundler-1.17.2/lib/bundler.rb:313:in `with_clean_env'
	 3: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/bundler-1.17.2/lib/bundler.rb:562:in `with_env'
	 2: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/bundler-1.17.2/lib/bundler.rb:313:in `block in with_clean_env'
	 1: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:216:in `block in compile_rails_assets'
/Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:224:in `rails_assets': undefined local variable or method `fulL_cmd' for #<Jets::Builders::CodeBuilder:0x00007f9ee1dc8638> (NameError)

Addressed in #96 Will go out shortly.

Will add this to the QA list.
Fixed and released in v1.3.6 CHANGELOG


New devfiles samples location

New devfiles samples location
It's needed to fix docs after https://github.com/devfile/api/pull/130

Now I'm not sure if these changes should be propagated to master or gh-pages.
So, let me know if the target branch should be master.

Is closed in favor of https://github.com/devfile/docs/pull/8


integration-cli: fix minimum and default api version test

This test would have caught #19936 (if it was right :smile:)
INFO: Testing against a local daemon

----------------------------------------------------------------------
FAIL: docker_api_test.go:67: DockerSuite.TestApiClientVersionOldNotSupported

docker_api_test.go:79:
    c.Assert(strings.TrimSpace(string(body)), checker.Equals, expected)
... obtained string = "client version 1.11 is too old. Minimum supported API version is 1.23, please upgrade your client to a newer version"
... expected string = "client version 1.11 is too old. Minimum supported API version is 1.12, please upgrade your client to a newer version"

OOPS: 0 passed, 1 FAILED
--- FAIL: Test (0.13s)
FAIL

Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

LGTM
ping @vdemeester

LGTM 🐮 assuming it's green :)

LGTM


[feature] Send client SDK name and version with all requests

This will help troubleshoot and debug
I think typically the standard way to do this is to set the HTTP headers:

X-Client-Version: sdk version
X-Client-Name: client name

But we should do some research to confirm

Hey @alfonso-paella ,
I have a few questions about this one:

When we mean all requests we mean the first GET request we make to the /api/crossmint/onboardingRequests/${clientId}/status endpoint, but also to the following requests we do in the popup window, correct? Im not sure we can directly pass he headers using the client API window.open. We probably need to pass them via query params at first and find a way to do it in next(https://nextjs.org/docs/api-reference/next.config.js/headers).
How would I access the client name? If im not mistaken, the only source of external information to the button is the /status endpoint (above mentioned).

Re: 1
Yeah we can pass headers for the /status endpoint, and then pass the same info encoded in custom url params for the window.open. Maybe we can stop there for now, and down the line we can decide if we also need to transitively pass headers from the checkout ui to the crossbit-main backend

re 2:
X-client-name should just be a hardcoded name we give the client SDK which is calling.
We can use the same names we use in npm, e.g. "client-sdk-react-ui" (and if we later have for vue, angular, android, iOS, ... we will use diff names for those)

I think this is done @pgarciaegido


Difficult to read contrast

Hi, thanks for this very nice interactive reading experience! The single most painful bit that I missed about 0.5 secs of starting was autocomplete, but I see there is an issue already for it.
Meanwhile, I'd like to report a background color that made a git tag very hard for me to read. It is the "HEAD" tag on the "A Mixed Bag" Level 4:

I really had difficulties reading the black text on top of such dark blue background. For me it all seems like if there was no text inside. So I'd like to kindly ask for reviewing those tags that use dark-ish colors for backgrounds, and consider either changing them to lighter alternatives, or even changing the text color to white (albeit I think that's a worse choice because it might make people think the tag with white letters is special for some reason). In any case, looking to keep a good amount of contrast between text and background.
Thanks again!

Good point! I think this is hardcoded and I can tweak the color a bit

this better?

Commit is attached -- feel free to tweak the color if you prefer something else.
It's a little less contrasting against the background now but it is certainly more readable

Hi, yes, the one on the left is much easier to read!! thank you very much


Approvals need to be signed by approving party

From Prakash: All approvals should be signed so that the trust model doesn't require medperf.
Thanks, Prakash. This is a great point!

Could you elaborate on this? I'm guessing this requires some server changes for storing the signature?


fix(editorconfig): set pulltagsbranch to empty string

:tada: This PR is included in version 1.9.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix for cell navigation selection issue

Fix for #195
Have a look and merge it. Let me know if you need anything look suspicious or broken, i will fix it.

Coverage increased (+0.03%) to 92.157% when pulling be276072dbcdc10291de4109ae403bcb8a4e3b39 on eshugoel24:cell-navigation into e81665842143635a8991c103821689ef775e72f3 on nadbm:master.

thanks for the bugfix!


ThreatActor class incorrectly and silently validates objects not conforming to STIX 2.1 specification

Hi, this is a minor bug.
When executing the following code, no exceptions are raised, and an invalid Threat Actor object is returned. It is invalid due to the fact that it is missing 'name'.
The proper execution would be to raise stix2.exceptions.MissingPropertiesError, as empty strings don't really have any value.
from stix2 import ThreatActor
ta = ThreatActor(name="")

Thank you for bringing this to our attention. The STIX specification doesn't really prohibit empty strings, and in a couple places empty strings are even required:

window-registry-value.name: "For specifying the default value in a registry key, an empty string MUST be used."
language-content.contents: If translations are only provided for some list items, "the untranslated list items MUST be represented by an empty string ("")."

Thus we haven't made empty strings cause errors so far.

I see. I'll implement my own fix untill then. Thank you.


Missing linecache import in parfor.py

There's a missing import linecache in parfor.py, that will lead to a NameError here:
https://github.com/numba/numba/blob/a35920c275916297500743bfa4fb7af232bd9659/numba/parfor.py#L1214
Not sure how to add a test for this, so didn't send a PR.

Thanks for the report, this is clearly an omission. The code is part of the allocation hoisting diagnostics, I'm not sure if it's the diagnostics that are not running or, perhaps more likely, that the input to them/what is accepted for hoisting has changed. I'll take a look.

https://github.com/numba/numba/pull/4024 Fixes both the import problem, and that allocation hoisting got broken and now tests for both!

Fixed in #4024


WISDEM/WEIS:develop to yonghoonlee/WEIS:develop

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[X] Maintenance update
[ ] Other (please describe)

Pull Request Test Coverage Report for Build 702338777

86 of 97 (88.66%)  changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.0003%) to 71.682%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

weis/aeroelasticse/FAST_writer.py
9
11
81.82%

weis/aeroelasticse/openmdao_openfast.py
23
32
71.88%

Files with Coverage Reduction
New Missed Lines
%

weis/aeroelasticse/openmdao_openfast.py
1
72.51%

Totals

Change from base Build 569895605:
-0.0003%

Covered Lines:
17403

Relevant Lines:
24278

💛  - Coveralls


Hiding tag should hide related/sub-tag

Hiding "Scat" does not hide "Implied Scat" and "Scat Fetish"

this unfortunately isn't possible due to the tag matching being simply text based and not in any way connected to AO3's amazing tag wrangling infrastructurece :(


Anonymous AMD/RequireJS support

Doesn't appear to work nicely with requireJS.
Normally it could be shimmed, but you have throw new Error("Medium Editor is not loaded on the page."); which appears to kill any chance of using it!
It was added to MediumEditor here:
https://github.com/yabwe/medium-editor/pull/318/commits/afbf2b6963403afa79802db209604b3ccc237218

Makes sense. I never did this in the past. Contributions are welcome!

I deserve to be hated for this, but this works:
const MediumEditor = require('medium-editor');
window.MediumEditor = MediumEditor;
const MeMarkdownRequireResult = require('medium-editor-markdown/dist/me-markdown.standalone');
window.MeMarkdown = MeMarkdownRequireResult.MeMarkdown;

Is this still an issue with the latest versions?


Incompatible with the yes command

Trying to work around #464, with yes, I found that this installer doesn't work with the yes command:
x@X ~ % curl -fsSL https://install.julialang.org>script
x@X ~ % chmod +x script
x@X ~ % yes | ./script

info: downloading installer
Welcome to Julia!

This will download and install the official Julia Language distribution
and its version manager Juliaup.

While Juliaup does not seem to be installed on this system, there is a
Juliaup configuration file present from a previous installation.
? Do you want to continue with the installation and overwrite the existing Julia✔ Do you want to continue with the installation and overwrite the existing Juliaup configuration file? · no

Maybe it has something to do with line feeds? I think the UI library that I'm using right now is reacting to individual key presses?
But the proper way to handle this is that we just tackle https://github.com/JuliaLang/juliaup/issues/218.

Yes, and #464 is itself a bug in the workaround for #218.

I'm closing this as I just added a proper quiet option.

#547


Expose the index of transaction in a block

Definition
As soon as a block has been assembled by the leader the transactions in that block have a strict order. The order can be expressed using an index (0-based). The index does not change as long as the block is not changed.
Motivation

the index can be used to derive an ''happens-before'' relation between two or more transactions inside a block (but also universally)

discussed with jac0xb.sol (Sniper Labs)

Imagine you have two events emitted in two transactions that are related to the same state in one slot. To my knowledge its impossible to know which event went first/last with just getTransaction.

the transactions in that block have a strict order

Just want to make sure this is clear:
It is true that transactions have a strict and consistent order when they are recorded in PoH, but this is not necessarily true about execution order. When a node replays a block, it batches up the transactions based on account-locking rules and the transactions within each batch get executed in parallel. That means each node might execute the transactions within a batch in a different order. In practice, this means you can definitely reason about what "happened first" with 2 transactions that write to the same account, but not with 2 completely disparate transactions that were executed in parallel.
I would say this is a nuance that is not important to most if any RPC consumers.


Duplicate bookmarks

Describe the bug
By "Add Bookmark"ing a website multiple times, I'm able to get multiple bookmarks of the exact same webpage.
See screenshot below:

How to Reproduce
Steps to reproduce the behavior:
.0. Go to any website
.1. Tap on Add Bookmark in the kebab menu a couple of times [ Optional ] Tap a couple more times for good measure
.2. Going to Bookmarks, there are multiple bookmarks of the same page.
Expected behavior
Only one bookmark per a unique webpage.
System and App Information

DDG App settings: Settings -> 5.74.0 (57400)
Device: Samsung Galaxy S7 Edge SM-G935T
OS: Android 8.0.0 and Samsung Experience Version 9.0

Thanks for reporting the issue. I agree it's something we should try to avoid. Thanks.

Thanks for reporting the issue. I agree it's something we should try to avoid. Thanks.


Gitlab collector is running and connecting to gitlab but it is unable to capture the issues

here goes my application.properties
Database Name
	dbname=dashboarddb

	# Database HostName - default is localhost
	dbhost=localhost

	# Database Port - default is 27017
	dbport=27017

	# MongoDB replicaset
	dbreplicaset=[false if you are not using MongoDB replicaset]
	dbhostport=[host1:port1,host2:port2,host3:port3]

	# Database Username - default is blank
	dbusername=dashboarduser

	# Database Password - default is blank
	dbpassword=dbpassword

	# Logging File location
	logging.file=./logs/gitlabFeature.log

	#Collector schedule (required)
	gitlab.cron=0 * * * * *

	#Gitlab host (optional, defaults to 'gitlab.com')
	gitlab.host=gitlab.com

	#Gitlab protocol (optional, defaults to 'http')
	gitlab.protocol=https

	#Gitlab port (optional, defaults to protocol default port)
	gitlab.port=443

	#Gitlab path (optional, if your instance of Gitlab requires a path)
	#gitlab.path=/api

	#Gitlab API Token (required, collector will have permission of user associated to the token)
	#If token is from admin account, will be able to view all teams, and can collect all issues
	#If token is from standard user, will show only teams that user is a part of, and can only collect issues that user could view
	#It is recommended to create a Gitlab account for the collector, using its Access Token, and adding that user to the teams you want to see issues for
	gitlab.apiToken=### removed here ###

	#Gitlab selfSignedCertificate (optional, defaults to false, set to true if your instance of gitlab is running on https without a trusted certificate
	gitlab.selfSignedCertificate=false

	#Gitlab API Version (optional, defaults to current version of 4)
	gitlab.apiVersion=4

First, you should create the dashboard and config the Feature widget for your gitlab project.


perf(shorthand): standardize childKey and shorthand props

WIP
Fixes #391
Fixes #449
This PR standardizes childKey and shorthand props.  It also adds commonTests and customPropTypes for these.  In doing so, it also defines a custom prop type for the as prop.
Implementing these also means we need to implement the standardized content prop names and patterns for shorthand props.  This will also be done here.
New customPropTypes

as
childKey
icon
image
shorthand

New commonTests

implementsShorthandProp

Current coverage is 96.69% (diff: 100%)

Merging #452 into master will not change coverage

@@             master       #452   diff @@
==========================================
  Files            90         90
  Lines          1300       1300
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1257       1257
  Misses           43         43
  Partials          0          0

Powered by Codecov. Last update 258480f...951088f

It seems, that we need customProptypes.children.
-children: customPropTypes.every([
-  customPropTypes.disallow(['description', 'header', 'image', 'meta']),
-  PropTypes.node,
-]),
+children: customPropTypes.children(['description', 'header', 'image', 'meta'])

I make some updates, see comments.

Thanks much, I'll pick it up from here.

I've paused this work.  It seems we need to further consider standardization for shorthand props. Thinking out loud...
Initially it seems shorthand props are strings only.  Then there are the icon/image exceptions, which can also be a props object or an element (factory).  Then there are also two types of array shorthand props, either an array of strings (extraImages, etc) or an array of objects (accordion panels, feed events, breadcrumb sections, etc) which are being handled individually in the render method.
Ideally, there would be a single shorthand prop type and a single shorthand factory for all components.
// Single Usage
<Feed extraText='Hello' />                          // string
<Feed extraText={{ content: 'Hello' }} />           // props
<Feed extraText={
Hello
} />                   // dom component
<Feed extraText={<Segment>Hello</Segment>} />       // composite component

<Feed date='1 day ago' />                           // string
<Feed date={{ as: 'a', content: '1 day ago' }} />   // props
<Feed date={} />             // dom component
<Feed date={<Image src='1 day ago' />} />           // composite component

// Array Usage
<Feed extraImages={['foo.png']} />                  // string
<Feed extraImages={[{ src: 'foo.png' }]} />         // props
<Feed extraImages={[]} />      // dom component
<Feed extraImages={[<Image src='foo.png' />]} />    // composite component

Shorthand Factory
Could take a Component (string|function), a function mapping shorthand value to Component props, and finally the shorthand value (string|props object|element|array of any of these).
We may also solve #345 reusable component parts by doing this.
// Feed Shorthand Props
const { content, extraImages, extraText, date, meta, summary } = props

const contentJSX = shorthand(FeedContent, x => ({ content: x }), content)
const extraImagesJSX = shorthand(FeedExtra, x => ({ content: x, images: true }), extraImages)
const extraTextJSX = shorthand(FeedExtra, x => ({ content: x, text: true }), extraText)
const dateJSX = shorthand(FeedDate, x => ({ content: x }), date)
const metaJSX = shorthand(FeedMeta, x => ({ content: x }), meta)
const summaryJSX = shorthand(FeedSummary, x => ({ content: x }), summary)

This is almost identical to the createFactory that already exists.  We could create a factory for each part (similar to what has been done in #345).  Though, it would not handle cases where the array is used to generate more complicated children as in <Accordion panels={} />, <Breadcrumb sections={} />, etc.  For this, we would need something more like an actual render function.
customPropTypes.shorthandSingle
String, object, element, disallow children.  Intended to be used with simple shorthand props that map directly to sub components (i.e. Feed shorthand).
customPropTypes.shorthandMultiple
Strictly an array of objects.  Intended to be used with the more complicated shorthand arrays (Accordion panels, Breadcrumb sections, Feed events, etc).

I'm going to think on all this for a bit before continuing.

If we allow this:
<Feed.Event extraText='Hello' />                          // string
<Feed.Event extraText={{ content: 'Hello' }} />           // props
<Feed.Event extraText={
Hello
} />                   // dom component
<Feed.Event extraText={<Segment>Hello</Segment>} />       // composite component

We need need allow this:
const items = ['Hello', 'World']
const items = [ {content: 'Hello'}, {content: 'World'} ]
const items = [
Hello
,
World
 ]
const items = [ <Segment>Hello</Segment>, <Segment>World</Segment> ]

<Feed.Group items={items} />

Looks cool. Then we can standardize items render:
-  if (children) {
-    return <ElementType {...rest} className={classes}>{children}</ElementType>
-  }

-  const eventsJSX = _.map(events, eventProps => {
-    const { childKey, date, meta, summary, ...eventData } = eventProps
-    const finalKey = childKey || [date, meta, summary].join('-')
-
-    return (
-      <FeedEvent
-        date={date}
-        key={finalKey}
-        meta={meta}
-        summary={summary}
-        {...eventData}
-      />
-    )
-  })
-
-  return <ElementType {...rest} className={classes}>{eventsJSX}</ElementType>
+return (
+  <ElementType {...rest} className={classes}>
+    {children || getItemsJSX(Feed, items)}
+  </ElementType>
+)

And then add commontest for this:
common.implementsItemsProp(Feed)

We can write less code and implementation will be clean and uniform. But, there is only one problem - handling key prop.

Items
As I said I think that we need standartize items prop, too.
class Menu {
  static PropTypes: customPropTypes.items,

  render() {
    renderItems(Menu, MenuItem, this.props, ['content'])
  }
}

renderItems = (Component, ChildComponent, props, keyProps) => {
  const {children, items} = props

  if(children) {
    return <Component>{children}</Component>
  }

  const itemsJSX = _map(items, item => {
    const {childKey, ...itemProps} = item
    // Ugly variant #1
    const key = childKey || shortid.generate()

    // Ugly variant #2
    const key = () => {
      if(childKey) return childKey

      const keyParts = _map(keyProps, keyProp => {
         const propVal = itemProps[keyProp]

         if(_.isString(propVal)) return propVal
         if(_.isObject(propVal)) return hash(propVal)
      })

      return keyParts.length > 0 ? keyParts.join('-') :  shortid.generate()
   }

    return <ChildComponent {...itemProps} key={key} />
  })
}

@levithomason here is some ugly preudocode. As you might understand, I'm not from frontend, so it may be that there is a decision easier and better, but I'm tried to to suggest an idea :smiley_cat:

I'm gonna break this PR up into smaller bite sized PRs.

I think customPropTypes.shorthand should describe the props for one component. For things like items I think we should just use PropTypes.arrayOf(customPropTypes.shorthand).
Another note, in this PR currently disallow(['children']) is baked into the shorthand prop definition, which I don't think we should do. Take ItemContent for example (not sure if this is a good example):
    <ElementType {...rest} className={classes}>
      {createShorthand(ItemHeader, val => ({ content: val }), header)}
      {createShorthand(ItemMeta, val => ({ content: val }), meta)}
      {createShorthand(ItemDescription, val => ({ content: val }), description)}
      {createShorthand(ItemExtra, val => ({ content: val }), extra)}
      {children || content}
    </ElementType>

We're using shorthand for header, meta, description, extra, but also allowing children, which I think is a totally valid use-case.

@jcarbo:

For things like items I think we should just use PropTypes.arrayOf(customPropTypes.shorthand).

We need also check childKey, so it might be more complex.

I think we should just use PropTypes.arrayOf(customPropTypes.shorthand.

👍

We need also check childKey, so it might be more complex.

There is now a function (#543) that deals with merging the key.  It can also deal with creating one.  We can use the string/number literal if provided, this was one of the reasons we limited shorthand to strings/numbers.  If the user provides a props object or an element, then they can also pass a key or childKey themselves, which is reasonable.  I think this covers all the bases

disallow(['children']) is baked into the shorthand prop definition, which I don't think we should do.

There are deep seated reasons why we should not allow children with shorthand. The CONTRIBUTING.md guide for component parts points this out and links this response as the thorough reasoning.  Though I want to allow it, I'm still of the mind for v1 that is best not to for the reasons noted.

What is mostly remaining here is Feed component prop updates and examples.  I'll make a PR pulling those out soon.

With the merge of #618 this work is done.  Closing.


New version: CamiXon v1.8.8

Registering package: CamiXon
Repository: https://github.com/walra356/CamiXon.jl
Created by: @walra356
Version: v1.8.8
Commit: 24ef49073a009a32ca8e2987ac959c14a8dcf01a
Reviewed by: @walra356
Reference: https://github.com/walra356/CamiXon.jl/commit/24ef49073a009a32ca8e2987ac959c14a8dcf01a#commitcomment-136131816
Description: A package for image analysis of backscattered light

[noblock]
Looks like there is a merge conflict.
@walra356 Can you re-trigger Registrator? This will fix the merge conflict.


Remove minimum row length from delimited importers

@timgentry, are you aware of the reason behind these clauses? I've had a frustrating hour or so working out why my file wasn't mapping...

It's a legacy thing. If we get rid of it, and I think we should, we need to communicate to users that import behaviour may change. Presumably it will be a major version bump?

True - @ollietulloch, we could presumably scan delimited files to see if it common to receive files with such rows?
We could look at pushing this legacy behaviour back in to the application from which it came, and manage it from there? Would still want to follow SemVer though...

My thinking exactly

@joshpencheon, we certainly could scan files. I can discuss with users to identify any potential candidates for further investigation.


precompiling gave AssertionError: fieldoffset(CheckPadAfter64, 3) == CACHELINE_SIZE

(ConcurrentCollections) pkg> st
     Project ConcurrentCollections v0.1.0
      Status `~/.julia/dev/ConcurrentCollections.jl/Project.toml` (empty project)

julia> versioninfo()
Julia Version 1.7.0-rc1
Commit 9eade6195e (2021-09-12 06:45 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin20.5.0)
  CPU: Apple M1
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, cyclone)
Environment:
  JULIA_NUM_THREADS = 4
  JULIA_EDITOR = code

maybe you're already aware of this. thanks for the package btw

Thanks for the report! I don't have a macOS and so I didn't know this :)

Hmm... it worked on github action: https://github.com/tkf/ConcurrentCollections.jl/pull/36/checks?check_run_id=3659030733#step:3:31
Julia Version 1.8.0-DEV.563
Commit 4f3a89e3ab (2021-09-20 19:34 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin19.6.0)
  CPU: Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, ivybridge)

Do you mind checking this in your REPL?
julia> primitive type PadAfter64 448 end

julia> mutable struct CheckPadAfter64
           a::UInt64
           pad::PadAfter64
           b::UInt64
       end

julia> fieldoffset(CheckPadAfter64, 3)
0x0000000000000040

yeah notice that the action is using x86 darwin not aarch.
julia> primitive type PadAfter64 448 end

julia> mutable struct CheckPadAfter64
           a::UInt64
           pad::PadAfter64
           b::UInt64
       end

julia> fieldoffset(CheckPadAfter64, 3)
0x0000000000000050

Ah, I see. Does ARM use a different alignment rule?

not sure, but ive run into a bunch of other issues using m1 so i figured it was related

OK, thanks. Need more digging...


Update .gitignore

Hi @woshiange, can you explain why you'd want to have the three different lines for Vim swap files? Also, we likely don't want to get rid of YAML files.


update docs

This fixes a discrepancy in the docs per #684 where the enum of the storeReadablePlan variable doesnt render in the documentation, leading the user to misunderstand what is available and applicable

Looks good, just need to fix some logic in the code that checks the value: https://github.com/weaveworks/tf-controller/actions/runs/5324536107/jobs/9643972763?pr=685#step:13:590

@fire-ant could you please make sure that this is NOT a breaking change that might affect other products, like WGE?


Device shows IS ONLINE = false

After I built the balenaOS 2.28.0+rev2 image in development mode I have followed the openBalena Get started guide :  https://www.balena.io/open/docs/getting-started
I have configured the image with the wifi setting and after I flash the variscite emmc using this image from a sd card I am able to boot form internal memory (emmc) and get wlan0 UP.
After that using balena-cli
$ balena devices
$ ID UUID    DEVICE NAME         DEVICE TYPE     APPLICATION NAME STATUS IS ONLINE SUPERVISOR VERSION OS VERSION           DASHBOARD URL
7  9de9511 lingering-waterfall imx6ul-var-dart dartApp          Idle   false     8.6.3              balenaOS 2.28.0+rev2 https://dashboard.mydomain.com/devices/9de9511851fc839cd7c5448400603ddc/summary
$ balena device 9de9511
== LINGERING WATERFALL
ID:                 7
DEVICE TYPE:        imx6ul-var-dart
STATUS:             offline
IS ONLINE:          false
APPLICATION NAME:   dartApp
UUID:               9de9511851fc839cd7c5448400603ddc
SUPERVISOR VERSION: 8.6.3
OS VERSION:         balenaOS 2.28.0+rev2
DASHBOARD URL:      https://dashboard.mydomain.com/devices/9de9511851fc839cd7c5448400603ddc/summary
The variscite board shows IS ONLINE = false
Looks like it can not connect with the openbalena instance that runs in a remote server.
Any clue why this behavior?
Thanks

Hi @floion ,
I am using openBalena ( https://www.balena.io/open/ ) in my backend side.
Which does lack of web-based dashboard although the balena-cli show a "dashboard" link when execute "balena devices".
I think that this issue probably is related to :
https://forums.balena.io/t/device-not-online-production/4319
Which seems to be fixed but not sure if in production yet.

After updating the openbalena in the server side, a new rebuild of balena-variscite (development mode) and balena-cli to the lastest versions the issue still persist. :(
ID UUID    DEVICE NAME         DEVICE TYPE     APPLICATION NAME STATUS IS ONLINE SUPERVISOR VERSION OS VERSION           DASHBOARD URL
8  79a1dd9 hidden-sky          imx6ul-var-dart imx6ulApp        Idle   false     8.6.3              balenaOS 2.28.0+rev2 https://dashboard.test.hibersense.com/devices/79a1dd9c1bacdc79661d1afd31e7c52b/summary


Enabling -fstack-protector-all prevents the kernel to boot correctly

When we pass -fstack-protector-all to a new-ish gcc version (like the one used in the Docker image), the kernel panics in the paging_init() function. This behavior isn't reproducible with x86_64-pc-elf-gcc (GCC) 5.4.0.

This should be fixed by now 😄

FTR: we're using --fstack-protector-strong right now but only for x86_64.


[NEW] Migrating to NextJS 13

Changes in the PR:

[x] Remove the unused jitsi/web-sdk
[x] Remove dependency on rc-fuselage
[x] update react-slick version
[x] updated ReactJS to v18
[x] added an override for next-auth conflict for the time being until the dependency conflict fix is published by next-auth parent repo
[x] Updated NextJS to v13

Thank you!

close #190

closes #190


Bump Jinja2 requirements to >=3.1.2

The current requirements of Jinja2 <3.1.0 breaks the template used in locust/template/index.html, specifically on this kind of conditions:
{% if not ((value is none) or (value is boolean)) %}

The boolean test has only been added to Jinja2 starting 3.1.2 (cf commit introducing new test)
This PR should also close https://github.com/locustio/locust/issues/2087

Nevermind, it was fixed in the meantime...

Thx anyway :)


[Bug] Memory usage when upload file to DataLake gen2

Query/Question
I'm using Azure.Storage.Files.DataLake to send data every minute from my C# code.
public class DataLakeStorage : IFileStorage
{
	private readonly DataLakeServiceClient _dataLakeClient;

	public DataLakeStorage(FileStorageOptions options)
	{
		var sharedKeyCredentials = new StorageSharedKeyCredential(options.AccountName, options.AccountKey);
		_dataLakeClient = new DataLakeServiceClient(new Uri($"https://{options.AccountName}.dfs.core.windows.net"), sharedKeyCredentials);
	}

	public async Task Add(string containerName, string path, string name, object data)
	{
		DataLakeFileSystemClient fileSystemClient = _dataLakeClient.GetFileSystemClient(containerName.ToLower());
		await fileSystemClient.CreateIfNotExistsAsync();

		DataLakeDirectoryClient directoryClient = fileSystemClient.GetDirectoryClient(path);
		DataLakeFileClient fileClient = await directoryClient.CreateFileAsync(name);

		await using var stream = new MemoryStream();
                await JsonSerializer.SerializeAsync(stream, data, data.GetType());
                stream.Position = 0;
                await fileClient.AppendAsync(stream, 0);
                await fileClient.FlushAsync(stream.Length);
	}
}

DataLakeStorage is registered as a Singleton in web application.
When I start using this code to send data every minute, I got a lot of memory usage of my application (each file ~150 bytes).
App without sending to datalake after 3 days uptime: ~170Mb
App with sending to datalake after 6 hours uptime: ~900Mb
Where can be the issue? Could you please suggest what I'm doing wrong with sending data to datalake?
UPDATE
Also, tried await fileClient.UploadAsync(stream, overwrite: true); instaed of
                await fileClient.AppendAsync(stream, 0);
                await fileClient.FlushAsync(stream.Length);

and added
  <PropertyGroup>
    <ServerGarbageCollection>false</ServerGarbageCollection>
  </PropertyGroup>

but the same result. It uses a lot of memory.
Environment:
Package: Azure.Storage.Files.DataLake 12.4.0
App: netcoreapp3.1
OS: Linux in container

Thank you for your feedback.  Tagging and routing to the team best able to assist.  Please be aware that due to the holidays, responses may be delayed.

It seems I found the issue.
It was Application Insights
I'm using AppInsights with Dependency tracking enabled. There are a lot of operations with Datalake (now it's more than 5000 per hour). After disabled AppInsights, the app using only 96 MB (9-hour uptime).
I'm going to write custom ITelemetryProcessor and skip all dependency that related to the Datalake operations.
What would you recommend?

Actually, after disabling Application Insights it consumes less memory, but
App without sending to datalake after 2 weeks uptime: ~160Mb
App with sending to datalake after 2 weeks uptime: ~460Mb
can it be an issue in Azure.Storage.Files.DataLake package?

Actually, after disabling Application Insights it consumes less memory, but
App without sending to datalake after 2 weeks uptime: ~160Mb
App with sending to datalake after 2 weeks uptime: ~460Mb
can it be an issue in Azure.Storage.Files.DataLake package?

any updates?
I upgraded my application to .NET 5 but it didn't help

any updates?
I upgraded my application to .NET 5 but it didn't help

any updates?
I upgraded my application to .NET 5 but it didn't help

Hi @Marusyk.  Unfortunately, I'm only serving as first triage in this case and have no insight into the status of this nor process that the owning team uses for triage.   I'll need to defer to @sumantmehtams and @xgithubtriage for assistance.

Hi @sumantmehtams and @xgithubtriage
any comments from your side?


fix: Fix bin issue on Linux machines #7717

Description

This pull request fixes the following github issue, identified as part of our usage of payload 3.0 beta 82.
https://github.com/payloadcms/payload/issues/7717

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Thanks for the PR but in this case we want to keep the --no-deprecation flag if we can, we'll be fixing this in a separate PR


improvement: Windows taskbar icon notification like Skype

In windows the sys tray icon is too often hidden at the moment, and the number of unread msgs is tiny.
The legacy had this wonderful number in the taskbar icon. Please add this also in Electron app because in a multi-monitor setup we miss a lot of message due to this.

The features of our app will be limited to the capabilities of the upstream electron. There is no support to show unread count in the taskbar (also not in the tray) in the upstream electron. We have added the functionality to show unread count in the tray.
Since you are facing the problem with the size of the tray icon. We have to show unread count in the taskbar.
Looking for possible ways :sweat_smile: .

Would it be worth submitting a request issue in the electron repository?
What version of electron is zulip app using right now? Maybe the feature is there in electron but not the version zulip is built on.
there are more limitations with having notifications just in the tray:
on a multi-monitor setup the tray is not duplicated to secondary screen even if your settings say that you want the taskbar duplicated. ie. I use three screen most of the time ...

@vbNETonIce  feel free to open issues there.
I also created this issue https://github.com/electron/electron/issues/9020
Currently we are using 1.6.8 version of electron. yes we are behind. There were some newer verions released a couple of days ago.

This is probably worth doing some nontrivial investment in creating, after we've fixed the more critical bugs we're aware of.

Increasing the priority on this, since it sounds like it's a blocker to migrating for a number of people.

Thanks Tim, we basically forced everyone to use the electron app but we had many long faces when they didn't have the taskbar notifications anymore from the legacy app. And with multi-monitor setups many still complain about missing msgs. If this can be done it would be a major step forward!

for future reference some electron messengers that have taskbar notifications:
inofficial whatsapp claims to have it: https://github.com/bcalik/Whatsapp-Desktop
official wire: https://github.com/wireapp/wire-desktop (although I have to check it again.
but electron also has some documentation about overlaying the taskbar icon
overlay icon with image
flashing the taskbar icon
with only few lines of code this could be easy to implement, wouldn't it?
so it looks like Electron is supporting those notifications. 😃

@vbNETonIce thanks for above links. I'll look into it :)

This feature has been added in https://github.com/zulip/zulip-electron/commit/67dc1e2a11ab7b573776ccaa90656b8051e57124. This is how it looks -

@vbNETonIce, @ElliotSilver can you verify if it works properly.

you nailed it! Looking great and it's I catching. Well, I guess it  was a few more lines of code than my 3, haha.

@vbNETonIce Thanks, I told you it's just a matter of time. @ElliotSilver feel free to migrate to zulip-electron :)


Update version to 0.17.2

Version Used: 0.17.2
Operating System and Version(s): Windows 11
Compiler and version(s): Visual Studio 2022 version 17.10

Thanks, but unforynately this version has issues due to missing the newly added bitmap engine files. This has been corrected in a regular update release to 0.17.2

Thanks, but unforynately this version has issues due to missing the newly added bitmap engine files. This has been corrected in a regular update release to 0.17.2

No problem, I have closed the PR due you already upgraded to the latest version. Thanks.


feat: allow using custom trust anchors

supersedes https://github.com/trustification/trustification/pull/1227

Tested in CRC and we don't have the error connecting the pods to the Keycloak URL.
I've found an issue though. After everything is correctly deployed, I launched the UI and it never get loaded (see the video below). The reason was that the .well-known/openid-configuration endpoint of Keycloak is also using non trusted certificates and somehow the user needs to load it in the browser and accept the risk. If this is considered as an issue I believe we can fix it in a separate PR.
Screencast from 2024-04-11 13-53-34.webm

Ups. Hold one give me some more minutes for an additional check please

If this is considered as an issue I believe we can fix it in a separate PR.

I don't think this is something that we can fix. This is being triggered by the browser of the user, which we don't have control over. You will either need to add the CRC certificate as a trust anchor to your system (which I would not recommend to do). Or manually add exceptions in the browser for every endpoint.

Ups. Hold one give me some more minutes for an additional check please

I reset your +1, when you're done you can vote again.

If this is considered as an issue I believe we can fix it in a separate PR.

I don't think this is something that we can fix. This is being triggered by the browser of the user, which we don't have control over. You will either need to add the CRC certificate as a trust anchor to your system (which I would not recommend to do). Or manually add exceptions in the browser for every endpoint.

@ctron I agree with you, in regards of the browser there is not much we can do to avoid the issue. However, I made a deeper test and since we have multiple external urls, all of them must be configured with the browser in order to accept the self signed certificate. These are the URLs that need manual "certificate acceptance":

UI: This is the obvious URl the url will naturally jump and accept the certificate.
Keycloak: This one is not obvious and users will need to configure the browser
SpogAPI + Bombastic API + Vexination API. These are also not obvious, and without this the UI will give a false impression of "working". Please watch my video below (sorry a bit long video).

We might need to add some docs stating that it will be the user's responsibility to configure his browser to accept the certificate and make sure all the URLs stated above are configured appropriately. What do you think? This was not defined in the requirement but not sure what we can do about it.
Screencast from 2024-04-11 14-57-18.webm

I'll think the note for the docs should be: the browser needs to be configured as well to accept the custom trust anchor.


Uuid::uuid4 returns an object instead of a string

Uuid::uuid4 seems to return an object instead of a string, this seems a bit weird because it fails validation checks (is_string)
The way I use it now is: (string) Uuid::uuid4().
Anyone else have similar issues?

Why It returns object? I spent 3 hours to understand where was error.
It's very strange behavior..

The examples in the README show that it returns an object, and the API documentation shows that it returns an object. Do you have a recommendation for how I can communicate this better to avoid issues like this?

I have no idea how to make it better in documentation, especially when people like me don't read documentation for things like this...
From today I will use wrapper for this
function uuid4() {
    return \Ramsey\Uuid\Uuid::uuid4()->toString();
}

Creating a wrapper works. You could also cast the object to a string:
echo (string) \Ramsey\Uuid\Uuid::uuid4();

Yes, I understand that now, but my issue was something like below
// my code
$model = new Model()
$model->name = 'Some Name';
$model->save();

// in model behavior, set default values
$model->uuid = \Ramsey\Uuid\Uuid::uuid4();

Somewhere in PDO class of Phalcon framework (compiled into PHP extension),
it checks type of value
https://github.com/phalcon/cphalcon/blob/ec30392d477d7e7e1a4283e0f0f33ef80ecd25f6/phalcon/db/adapter/pdo.zep#L251-L285
And at the end it prepare very strange SQL query
INSERT INTO `table` (`uuid`, `xxx`, `xxx`, `xxx`, `xxx`, `xxx`, `xxx`) VALUES (7cb1b147-b4af-44e6-b419-1617c256fae9, ?, DEFAULT, ?, ?, ?, ?)


Try to fix validate_config.py for Pyyaml breaking change

Error message:

python manifests/validate_config.py check_config kubeflow/org.yaml
Traceback (most recent call last):
File "manifests/validate_config.py", line 52, in
fire.Fire(CheckConfig)
File "/usr/local/lib/python3.7/site-packages/fire/core.py", line 141, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/usr/local/lib/python3.7/site-packages/fire/core.py", line 471, in _Fire
target=component.name)
File "/usr/local/lib/python3.7/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "manifests/validate_config.py", line 18, in check_config
org = yaml.load(hf)
TypeError: load() missing 1 required positional argument: 'Loader'

Usage:
https://github.com/yaml/pyyaml

/lgtm


[Table]: should we support lazy loading of the children rows.  If so we'll need some UX to indicate this expansion is loading

This design should state the behavior of the table when a parent node is expanded

[default] Expanding a row will lazy load the child rows
[default] The selection of (non-loaded) child rows will depend on the selection of the parent row. Unselected parent will load unselected child rows. A selected parent will load selected child rows.
 The implementation may set a time threshold when to start showing a progress indicator. E.g. if loading passes 3 seconds limit.
The progress indicator should be visually located close to the user action location, i.e. the chevron. For example to the left side of the table row.
The progress indicator should be consistent with other loading / progress indicator. E.g. a swiping bar.

This issue is stale. Closing. Please re-open if needed.

This is a required table feature. With production systems in Monitor we will have 100.000 IO points in a hierarchical tree. That can not be loaded into the table. Lazy loading is required.
My take is that there is no simple/intuitive way to do paging in a hierarchical tree. The 'paging' feature is the lazy loading. Hence this is a must for enterprise scale use.
@amymillett


ByteSource generation

https://github.com/Nihiue/little-byte/blob/8496960392a676e61df3615ef7867f217543dbe1/src/compiler/index.ts#L24-L28
As far as I'm concerned, this source code generation could be replaced with only code length repetition.
const sourceMap = _module.wrap(' '.repeat(code.length));

It works very well.
But, it would break the test script.
Just FYI.

loader generates  blank dummy code if bytesource not found
https://github.com/Nihiue/little-byte/blob/8496960392a676e61df3615ef7867f217543dbe1/src/loader/index.ts#L27
But also thanks for comment

I did not realize that how strong you are until I read about this issue.
You are very 🐮🍺, bro.


Update ghcHEAD

ghcHEAD currently fails to build and should be updated to include -fcompact-unwind support (https://github.com/NixOS/nixpkgs/pull/166571#issuecomment-1087411055). This seems to require adjusting jailbreak-cabal for recent changes in Cabal.
cc fyi @NixOS/haskell

Follow https://github.com/NixOS/jailbreak-cabal/pull/19 for work on making jailbreak-cabal compatible with Cabal 3.7.


Suggestions on demo.ipynb

I think this might be confusing to the user

and then here

Users might feel lost when we give them too many choices. This demo should be as simple and precise as a tutorial. If really needed, we can add an extra section after the introduction of yaml file, then say something like:
Config in Python (optional)

Also encountered this issue on Windows:


{cosmos} Fix cosmos sample

Description
Fix cosmos sample.
Fixes GitHub Issue 30030
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Add support for +91-86698 number series

Country: India
Example number(s) and/or range(s):<PHONE_NUMBER>
Number type ("fixed-line", "mobile", "short code", etc.): mobile
Where or whom did you get the number(s) from: Personal number
Authoritative evidence (e.g. national numbering plan, operator announcement): Letter from the DoT, Ministry of Communications, Government of India
Link from demo (http://libphonenumber.appspot.com) showing error: http://libphonenumber.appspot.com/phonenumberparser?number=8669800000&country=IN

NOTE: This number series has been allocated to Reliance Jio, Maharashtra Circle.

Thanks for providing all the details we need! We've accepted this issue and will fix this in an upcoming release. For your next metadata issue, we invite you to file issues in
Google's new Issue Tracker,
which we're currently testing.
Please note that you have submitted this information with the knowledge that we may use, modify, reproduce, publicly display, and distribute the information in accordance with our open source policies. Please let us know if you did not intend to submit the information for such use.

Fixed in release 8.5.2


UIImagePickerController issue

Hello,
Since I added ETNavbarTransparent my UIImagePickerController doesn't work (UIImagePickerControllerDelegate function are never performed). There is any chance of this issue came from the UINavigationControllerDelegate extension used in ETNavbarTransparent (which are also used for UIImagePickerController) ?
Thank you

This problem has been solved, please check out the new version. Thanks for your issue


Better forceShow

Now tries to close the player's UI by spawning a snowball at their location if the player is in survival or adventure to hit the player.
Known Issues:
This approach won't work if the player opened the chat UI by pressing the / key on their keyboard for some reason. Apart from that it should work

Wondering what's the reason behind this implementation?

Well, from what I know people mostly use this function to open forms with chat commands so this can actually also close the chat and instantly show the form.

Hello, you can use applyDamage(0.0001) to close the chat-ui, but i think we could marge it, maybe split old implementation and your implementation to two separated functions. Thank you

applydamage doesn't actually close the ui, or at least it's very inconsistent, based on my testing


Allow super_fn argument passing from mixins

When a mixin calls super_fn, the arguments are currently bound to the original call, which makes it impossible to do some more advanced things, like override set for example.
function compressionPlugin() {
  return {
    set: set
  }

  function set(super_fn, key, value) {
    var newValue = 'MODIFIED' + value;
    super_fn(key, newValue)
  }
}

As a plugin author, you may expect that calling set('foo', 'bar') results in MODIFIEDbar being stored. But because the original args value, bar, is bound, that's the value that gets stored.
With this PR, any arguments passed into super_fn override the original values, so calling set('foo', 'bar') with this PR results in MODIFIEDbar being stored.
Additionally, any additional arguments passed in the original call will continue to be passed through unmodified.
I'm not entirely sure how to write tests for this change, short of writing a plugin that would use this change. That said, I would like to modify #204 to use it...

Looks good! This will break in legacy IE so I'll have to make some changes but I think the approach is good! Stay tuned for final code...

Done! Can you please double check https://github.com/marcuswestin/store.js/blob/master/tests/tests.js#L61 to ensure that it behaves in the way you'd expect it to?

I think that looks right. I don't see a test that is checking the arguments to the super_fn, but the use in the second addPlugin there is how I would expect to use it. I'll update #204 and report back.

👍


Represent non-number error categories?

My company has an internal linter that emits style violations with specific categories like ("style", "spelling", etc.). I'd like to extract these from the message, but I don't see a specific field or errorformat token to extract it. The closest thing I've seen is entry.nr. Does neomake support this?

It is not really supported by Vim/Neovim.
nr can be a number, type a single char.
This works for flake8 etc, where you have E501 etc.
I suggest using the text field for this - you can append/prepend it there.
See https://github.com/neomake/neomake/blob/bfb7179df2c883a304adfb7d98476001c19db9da/autoload/neomake/makers/ft/python.vim#L136-L250 for an advanced example.

Closing, but feel to follow up, of course.


Cannot Re-use content on another platform

the CLI interface offers to Reuse Content as Download etc but it does not work: when importing the saved content into another platform! I get error message "A valid content folder is missing".
Same problem if I use the CLI Export content command.

You may want to leave some more information. I can't reproduce/confirm this issue.

I'd just like to add a word of advice here. Be aware that the H5P CLI tool, when using the setup command, will use the sources of the master branches of the github repositories. That's usually not the release version, but a development version. If you use the H5P CLI tool blindly to build H5P files in order to install these on some other H5P integration, you risk installing untested buggy code on that platform and potentially even spread it if people download the respective content and upload it on their system. See also https://github.com/h5p/h5p-cli/issues/55
So, if that applies to your case, please rather pack the libraries that you have been working on, and then install only those on the other platform, and then create demo content or whatever on that platform.

Thanks for the advice, @otacke ! I will be careful with contents created with the H5P CLI tool...

Here is more information as requested by @otacke
Scenario to test issue with a simple H5P content

download True/False Question #1 "Oslo is the capital of Norway" from https://h5p.org/true-false
saved as true-false-question-34806.h5p
in localhost CLI tool Import it, entitle it "Oslo true-false"
View it and export it with Reuse button -> Download as an .h5p file
Check that you've got the file Oslo-true-false.h5p in your Downloads folder on your computer
Go to any one of these 3 platforms (local or online): Moodle, Drupal7 or WordPress
and Download/Import the file Oslo-true-false.h5p
Check that you get error message:  A valid content folder is missing
Open Lumi: Open Existing H5P -> Oslo-true-false.h5p
Check that you can import it without errors
In Lumi: Save As "Oslo-true-false-from-Lumi"
Go back to any one of these 3 platforms (local or online): Moodle, Drupal7 or WordPress
and Download/Import the file Oslo-true-false-from-Lumi.h5p
Check that it is imported with no errors!

Still cannot reproduce this. Might be an issue with running adm-zip inside the H5P CLI tool on Windows (?) only.

On Windows it is recommended that you run the h5p-cli commands inside git bash.

@devland and @otacke I am still experiencing this issue. When you say "cannot reproduce" do you mean you have actually tried my scenario on a Windows platform?
@devland Running the h5p-cli commands in git bash does not enter in consideration when Re-using the contents.
@otacke probably has the correct explanation, so, how about making adm-zip work on Windows?

@rezeau Nope. Did not try this on Windows. Otherwise I could have looked into the cause instead of speculating. You didn't mention Windows at all before, so I merely guessed because I know you that are bold enough to use it.

@otacke Yes, I am bold/foolish enough to stick to Windows.😵💫
In the h5p-cli tools the pack library command works OK. That command calls the adm-zip script, but only the first part of it.
The export content command (used by the Re-use link in the server interface) starts with exporting all the libraries needed by the particular content that is being exported, then it continues with the module.exports function.
As far as I can see the Windows bug lies somewhere in that function. It would be great if a fix could be found.

@rezeau I don't know how much impact creating issues on github has. From what I experience, currently what does not exist on H5P Group's JIRA instance, does not have a good chance to be tackled any time soon except for some lucky cases.

@otacke Done at https://h5ptechnology.atlassian.net/browse/HFP-4159
Probably not the best of bug reports but can't do better at the moment. And of course I don't expect any fix to happen any time soon.
"Blessed is he who expects nothing, for he shall never be disappointed" Alexander Pope.

@rezeau Sure, but expecting nothing sounds a lot like living half-asleep. I am not the maintainer anyway ;-)

I managed to reproduce this issue on my windows vm.


Regen gopkg.lock

What version of dep are you using? Other than the hash, also the syntax seems a bit different sometimes (e.g. trailing comma).
Did you run dep ensure -update?

dep:
 version     : v0.5.0
 build date  : 2018-07-26
 git hash    : 224a564
 go version  : go1.10.3
 go compiler : gc
 platform    : linux/amd64
 features    : ImportDuringSolve=false

The Pr is updated with dep ensure -update

@oscerd , @nicolaferraro what do you think about to add Gopkg.lock to .gitignore?

No @dmvolod, the lock file establishes the exact version of the libraries that the project is using, while the toml file describes high level constraints on them that must be respected by the lock file. If we don't commit the lock file, each one of us will use his own set of dependencies.
We should use dep ensure to sync dependencies but also when we add a new dependency. We should use dep ensure -update only when we want to upgrade libraries to their latest versions (respecting constraints).
The command dep ensure does not change versions in the lock file, only adds them if needed. This way the build should be reproducible across computers. At least, if we use the same version of dep..

Thanks, @nicolaferraro . But update of the Gopkg.lock look like related to the version of the dep. When I used a dep from fedora package all was good, but installed via go get, got the same result.


Support for list.inactiveSelectionForeground

I'm adding custom colors for https://github.com/teabyii/vscode-ayu and tries to make it as close to
the gorgeus https://github.com/dempfi/ayu as possible. We now have list.inactiveSelectionBackground but I really miss list.inactiveSelectionForeground to be able to set the foreground of the currently edited file like this:

Is this something that should be possible to add?

I added list.inactiveSelectionForeground

Thanks! 💃


js strack trace on notebook page

https://pub.beakernotebook.com/#/publications/5602e07d-f95b-4ae9-aecc-73e7e76cd379?fullscreen=true
TypeError: Cannot read property 'name' of undefined
    at Object.app.service.F.gaPublicationPageView (publications_main.js:1617)
    at publications_main.js:3852
    at deferred.promise.then.wrappedCallback (beakerVendor.js:46304)
    at deferred.promise.then.wrappedCallback (beakerVendor.js:46304)
    at beakerVendor.js:46390
    at Scope.promises.$get.Scope.$eval (beakerVendor.js:47433)
    at Scope.promises.$get.Scope.$digest (beakerVendor.js:47245)
    at Scope.promises.$get.Scope.$apply (beakerVendor.js:47537)
    at done (beakerVendor.js:43072)
    at completeRequest (beakerVendor.js:43286)(anonymous function) @ beakerVendor.js:44748

I believe this is because that publication doesn't have a category, so it fails when looking up scope.publication.category.name. Replacing
publicationGaData = _.extend(publicationGaData, {
            'page': '/publication',
            'dimension1': scope.publication.category.name,
            'dimension2': currentUser,
            'dimension3': scope.author.name,
            'dimension4': scope.publication.name
          });

with
publicationGaData = _.extend(publicationGaData, {
            'page': '/publication',
            'dimension1': scope.publication.category.name || "ALL",
            'dimension2': currentUser,
            'dimension3': scope.author.name,
            'dimension4': scope.publication.name
          });```
should do the trick.

https://github.com/twosigma/bunsen/pull/1181


Getting undefined url in Wordpress loop

Hi,
I have a little bug on a page. I call a loop for thumbnails on wordpress, all works, but in Firebug Javascript Console show me there is an "undefined" url.
For now, i build the website here : http://beguinmacchini.ninjazz.fr/, look on the index page with console.
I think Nivo is calling something in url's, but i'm not sure.
Do you have an idea ?
(Nice work for Nivo by the way, you rock :))
Mooty
PS : Excuse my poor english speaking ...

I solve the bug. Actually, Nivo slider


Lazy load chapter definitions

Definitions on the home pages are loaded via a series of AJAX requests to static JSON files. They appear all at once upon completion of the request.
The goal is to lazy load them, the list of chapters is streamed via an Observable and a new chapter's definitions are loaded when the user scrolls at the bottom of the page.

You know what?


Classify Traffic Acquisition Sources

This is an attempt to clean up the various traffic acqusition signals in a more
organized fashion.

feat(utils): add classifier for traffic acqusition
feat(logger): introduce acqusition checkpoint
feat(utils): allow-list acquisition checkpoint

:tada: This PR is included in version 2.24.0 :tada:
The release is available on:

v2.24.0
v2.24.0
GitHub release

Your semantic-release bot :package::rocket:

@ekremney That's been my point all along 😉 You need both to make an educated guess


Celery without the production sauce

DO NOT MERGE

@oceanzus if you need to change something in my PR you'll need to open your own PR against my branch. I'm not confident at this point that this will work as is. I'll close this so you can do that.


Fix a bug in the segment range request

When we resolve the range request, we should pass the chunk size instead of total blob size to the method.

Codecov Report

Merging #1406 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1406      +/-   ##
============================================
+ Coverage     72.37%   72.41%   +0.04%
- Complexity     7067     7071       +4
============================================
  Files           512      512
  Lines         39993    39995       +2
  Branches       5035     5035
============================================
+ Hits          28944    28962      +18
+ Misses         9644     9628      -16
  Partials       1405     1405

Impacted Files
Coverage Δ
Complexity Δ

...java/com.github.ambry.router/GetBlobOperation.java
91.51% <100%> (+0.02%)
44 <0> (ø)
:arrow_down:

...a/com.github.ambry.network/SSLBlockingChannel.java
75.67% <0%> (-5.41%)
4% <0%> (ø)

...java/com.github.ambry.store/CompactionManager.java
89.88% <0%> (-2.39%)
25% <0%> (ø)

...java/com.github.ambry.network/SSLTransmission.java
70.46% <0%> (-0.93%)
76% <0%> (ø)

...ain/java/com.github.ambry.router/PutOperation.java
91.73% <0%> (-0.5%)
115% <0%> (-1%)

...n/java/com.github.ambry.store/PersistentIndex.java
89.96% <0%> (-0.12%)
243% <0%> (-1%)

...rc/main/java/com.github.ambry.store/BlobStore.java
87.61% <0%> (ø)
107% <0%> (ø)
:arrow_down:

...in/java/com.github.ambry.store/BlobStoreStats.java
71.45% <0%> (+0.2%)
103% <0%> (-1%)
:arrow_down:

...ls/src/main/java/com.github.ambry.utils/Utils.java
77.42% <0%> (+0.31%)
117% <0%> (+1%)
:arrow_up:

...src/main/java/com.github.ambry.commons/BlobId.java
93.4% <0%> (+0.34%)
74% <0%> (+1%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97cd30f...4ab0a33. Read the comment docs.

Thank you for fixing this and improving the test case


Issue 230 - Updated REST docs for ingest views.

This issue was requested when the ingest records table was updated in the UI. After reviewing the code more closely, it seems this was actually already implemented. So I just updated the documentation to make it more clear and fixed some warnings.

LGTM, I'm going to go ahead and merge to get this in for this sprint.


tokio::test fn not recognized as a test when procedural macros are enabled

Here is a minimal example:
fn main() {}

#[cfg(test)]
mod tests {
    #[test] // 'Run Test' tooltip always shown
    fn test_one() {}

    #[tokio::test] // 'Run Test' not shown when Proc Macros enabled
    async fn test_two() {}
}

Cargo.toml dependencies:
[dependencies]
tokio = { version = "1", features = ["macros", "rt-multi-thread"] }

Like the title/code snippet says, when the Procedural Macros feature is disabled, both tests are recognized just fine and can be run from the UI action, but when Proc Macros are enabled, the tokio::test fn is not recognized as a test. Note that tokio::test is itself a procedural macro.

Confirmed with:
#[::core::prelude::v1::test]
fn test_three() {}

So is it just that we look for #[test] and don't handle the fully qualified path?

We only look for test inside the path so this should be working fine there 🤔
https://github.com/rust-analyzer/rust-analyzer/blob/75f2a5b18596e0c8851163494ae735c5e89ce621/crates/ide_assists/src/utils.rs#L70-L75

No, we actually look for anything that contains test, but drop it somewhere along the way.

#[::core::prelude::v1::testx] actually works.

Oh I think we are expanding the attribute which just replaces the item with itself but with the attribute stripped? This only works with the fully qualified path.

Yeah, we expand it to fn test_three(){}.
(did the GitHub emoji rendering just change?)

Thanks for the quick response, everyone. It's actually very useful to know this workaround in the meantime, since I typically only use one kind of test in the same mod:
#[cfg(test)]
mod tests {
    use tokio::test;

    #[test] // Now shows 'Run Test' 🎉
    async fn tokio_test() {}
}

Ah we skip some attributes in https://github.com/rust-analyzer/rust-analyzer/blob/6a07bf6a9f9b23fde98d8b9f5e70bc94f72a5723/crates/hir_def/src/nameres/collector.rs#L1710-L1741 but that is name based, not based on actual items. So fully qualified paths don't hit this.
This makes me wonder, does this mean we lose attributes on syntax trees for the IDE layer? 🤔

If we have #[test] and #[bench] implemented as built-in macros now (and they're resolved correctly), then we can remove the EXTRA_ATTRIBUTES. That was only there to make sure they don't stay unresolved/unexpanded.


Intrusion Report Improvements

"Professionalism" was noted by judges
Create templates

The main issue was the markdown compiler so I need to find a new one.

I will find a new one by the time it becomes relivent.

as for templates, that will happen at the  same time


Adding Contribution Guidelines

Related Issue(s): #2
Proposed Changes:

Adding contribution guidelines
Adding a code of conduct
Adding a changelog
Adding issue and PR templates

PR Checklist:

[ ] This PR is made against the dev branch (all proposed changes except releases should be against dev, not main).

Skipping for this PR as they are the initial guidelines changes

[x] This PR has no breaking changes.
[x] This PR contains only one commit.
[ ] I have updated or added new tests to cover the changes in this PR.
Skipping for this PR as there are no code changes
[x] I have updated the version in package.json to follow the Semantic Versioning guidelines.
[x] All tests are passing.
[x] I have added my changes to the CHANGELOG
or a CHANGELOG entry is not required.
[ ] This PR affects the Source Cooperative Frontend & API,
and I have opened issue/PR #XXX to track the change.

Merging this since there have been no reviews for a week and this isn’t changing the code


Rating graph

Add a page with rating progression graphs to the web interface (similar to the matches ui but with a different presentation)

I like that you've done things differently to how I would, as soon as the whitespace stuff is sorted I'll merge.
As it adds a new route it'll require a server restart, I can't just hotfix it in sadly :(

I should have fixed most whitespace issue now,
note: I tried to run mix format to see and it generates a lot of changes but It may be a good idea to do it sometime on the project since it simplifies these kind of things if there are multiple people working on the same codebase

I'll do a mix format soon, I'd intended to prior to this but never got around to it.


useDrag breaks onClick listener in React portal to shadow dom

Describe the bug
Binding a drag gesture listener on the parent of a shadow dom host prevents onClick listener within shadow dom from firing.
This does work with firefox, but not the Chrome version listed below.
Sandbox or Video
https://codesandbox.io/s/red-cdn-t8hkjm?file=/src/App.js
Information:

Use Gesture version: ^10.2.27
Device: Laptop
OS: Pop!_OS 22.04 LTS
Browser: Chrome Version 117.0.5938.88

Checklist:

[x] I've read the documentation.
[x] If this is an issue with drag, I've tried setting touch-action: none to the draggable element.

I found that this is related to the pointer.capture option. If capturing is disabled, then the shadowed dom button click is triggered. I updated the sandbox with this case.
I'm not sure if this is intentional since it only happens with the shadow dom

Hm use-gesture doesn't do any magic, it just tries to assign listeners to elements. It's possible that setPointerCapture which is used when pointer.capture is set doesn't work with shadowed elements I'll dig into this deeper when I have time, but I'm not sure the lib can do anything about it.


fn build should include contents of directory with non-dockerfile (ie language runtimes) funcs

for example, if my runtime is Go, and then I include a template file in the func dir and I want to open it, parse it, and return it to stdout, that template file is not included in the way the CLI does the build. Seems to me like the build should include everything in the current directory.
I can of course switch to runtime Docker, but then I'm dealing with Docker and that's not ideal. I want the simplicity of the default deal.

If this is done by default it will tend to bloat out function images (especially with functions with source and binaries)
Could this be done via a stanza in func.yaml?
includes:
   - *.html
   -  my/local/dir:container/dir

(following docker copy conventions or similar)

I agree, we shouldn't shove everything in by default (bloat). we do some magic with the cli to minimize build size already.
templates are always a pain to have to carry around, this is a specific case. +1 to have includes: to handle this, surprised we didn't have that already.
+2 it is then

+1 on the includes directive.

Includes works for me.


remove enable call from playground

Summary
remove enable call from playground from sdk playground submit call.
This was always firing and is not actually useful.
How did you test your changes?
Manually.
Just use the sdk playground. There should be no functional changes to how things work.

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

Review Error for fan-zhang-sv @ 2024-10-23 21:33:31 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help


Should Input types be Inferred from the Input Schema?

I have the following example and I am wondering if I should be seeing the input to increment being inferred? Currently the type is reported as unknown. This seems like a shortcoming if I can't see the type at dev time.

Hey, @stephen776!
Having the input and environment be unknown is desirable when using external sources like API responses or FormData. Everything else is type-safe, but we assume we cannot control the input or environment types. That's how zod works as well, and it solves the majority of use cases.
But @diogob is trying to implement strict inputs and environments in #69. With that, we can make our DFs strict whenever we know the input/environment types and flexible when we don't. We don't have an estimate of when this will be ready, but we know it will be a v2 thing :)

Thanks for the response. Totally makes sense in the context of input from from data and such. Looking forward to seeing what you all have in store for v2

@stephen776 , I'm gonna close this issue for now. I added a little FAQ in the README to answer questions like that and we will let you know whenever we come up with a solution ;)
Thank you for the feedback!


Replace SILType::isTrivial(SILModule) with isTrivial(SILFunction)

Next step after https://github.com/apple/swift/pull/23110.
Not quite ready to start using per-function resilience expansions; there was a bit more that had to be refactored first.
https://bugs.swift.org/browse/SR-261, rdar://24057844

@swift-ci Please test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility Release


 This tool have the -list option which print the info of all file images, like this:
page   num  type   width height color comp bpc  enc interp  object ID x-ppi y-ppi size ratio
--------------------------------------------------------------------------------------------
   1     0 image    1700  2200  gray    1   1  jbig2  no        26  0   200   200 24.3K 5.3%
   2     1 image    1700  2200  gray    1   1  jbig2  no         3  0   200   200 27.9K 6.1%
   3     2 image    1700  2200  gray    1   1  jbig2  no         6  0   200   200 34.0K 7.4%
   4     3 image    1700  2200  gray    1   1  jbig2  no         9  0   200   200 34.5K 7.6%
   5     4 image    1700  2200  gray    1   1  jbig2  no        12  0   200   200 28.3K 6.2%
   6     5 image    1700  2200  gray    1   1  jbig2  no        15  0<PHONE_NUMBER>B 1.3%

It occurred to me that, I can make relationships between the object-id values on this output and pdfminer, but LTImage object doesn't have such value. Is there a way to obtain it?

Yes, you can. Every LTImage object has a stream attribute that is a PDFStream object. The PDFStream object has an objid attribute.
For example:
from collections.abc import Iterable

from pdfminer.high_level import extract_pages
from pdfminer.layout import LTImage

def iter_images(item):
    if isinstance(item, Iterable):
        for child in item:
            yield from iter_images(child)
    elif isinstance(item, LTImage):
        yield item

pages = extract_pages('/home/pieter/Downloads/parkhi12a.pdf')
for image in iter_images(pages):
    print(image.stream.objid, image)

Example output on this pdf.
100 <LTImage(R8) 50.112,663.307,125.704,720.001 (500, 375)>
103 <LTImage(R8) 129.203,663.307,204.788,719.996 (500, 375)>
106 <LTImage(R8) 208.287,663.307,283.872,719.996 (500, 375)>
109 <LTImage(R8) 50.112,602.783,125.768,659.525 (500, 375)>
112 <LTImage(R8) 130.481,602.783,206.066,659.472 (500, 375)>
115 <LTImage(R8) 210.778,602.783,286.363,659.472 (500, 375)>
121 <LTImage(R8) 50.112,412.547,93.568,445.139 (800, 600)>


repository url is confusing

In the module init yotta asks for the Repository URL, "where people can submit bugfixes".
That's what it says, but it wants the URI git@github.com:user/repo.git and that is definitely not the URL "where people can submit bugfixes".
Repository url (where people can submit bugfixes): https://github.com/user/repo
"https://github.com/user/repo" isn't a valid "repoObject" value.

Proposition:
Repository url (version control uri):
Homepage (where people can submit bugfixes):

composer has an object/dict like this:
email: Email address for support.
issues: URL to the issue tracker.
forum: URL to the forum.
wiki: URL to the wiki.
irc: IRC channel for support, as irc://server/channel.
source: URL to browse or download the sources.
docs: URL to the documentation.

An example:
{
    "support": {
        "email"<EMAIL_ADDRESS>        "irc": "irc://irc.freenode.org/composer"
    }
}

"homepage" is intended to be for the "real" web-page homepage if there is one, which would normally be user docs etc., not necessarily the source repo. The plain github URL should be accepted in the repository field though: that can be improved.
There is also a separate bugs field you can fill in. The vast majority of modules will just have a single home (e.g. github/bitbucket) so I don't really think having lots of optional fields for different contact methods is useful. It's easy enough to put them in your readme if you want to, where they are easier for humans to find.

I've found the docs field to be pretty useful, since lots of folks use readthedocs and similiar sites.


fix loading of messages when we get a gregor first, array bounds check

This didn't work due to the default values of the Record
@keybase/react-hackers

The commits 40d4abd605bc...dc11b6e7e1bf introduce visual changes on linux. :mag_right: 6 changed

Changed: Chat_List-Normal (before) (after)

Changed: Chat_List-Empty (before) (after)

Changed: Chat_Input-Emoji_Open (before) (after)

Changed: Chat_Conversations_List-Selected_Normal (before) (after)

Changed: Chat_Conversations_List-Selected_Muted (before) (after)

Changed: Chat_Conversations_List-Normal (before) (after)