debug atom beautify error

Description
The results of beautification are not what I expect.
Expected Results
The beautified code should have looked like:
<INSERT CODE HERE>

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Debug
Here is a link to the debug.md Gist: https://gist.github.com/53de27e97b446388c20e86e87bf31f2c
Checklist

[ ] I have tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[ ] I have reloaded (or restarted) Atom to ensure it is not a caching issue
[ ] Searched for existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[ ] Generated debugging information and added link for debug.md Gist to this issue

I dropped the code sample into http://jsbeautifier.org/ and I got broken HTML.  Alerting @bitwiseman

@prettydiff
If the output your are seeing matches the debug, this is another example of someone not turning on e4x for a jsx input.
Also, I'm extremely glad that you have setup the debug.md function and I deeply appreciate your looping me in on issues that relate to the beautifier, but I really need clear and concise bug reports to understand and take action on issues.   Input, expected, and output.
Tagging me on an issue that hasn't been fully analyzed just makes me use the limit bandwidth I have analyzing issues instead of fixing them.

I really need clear and concise bug reports to understand and take action on issues. Input, expected, and output.
Tagging me on an issue that hasn't been fully analyzed just makes me use the limit bandwidth I have analyzing issues instead of fixing them.

I absolutely agree, @bitwiseman. We need to put our foot down on Issue report quality. If an issue is not a clear, relatively small example with input and output (from debug.md), and expected (often missing) then we cannot spend time analyzing it when other users have properly reported their Issue.
@prettydiff let's use the waiting-for-user-information label more often when applicable and only once we have the information let's begin the analysis ourselves, and/or call in @bitwiseman for assistance. We have hundreds of Issues and limited bandwidth.
On a related note, thank you to both @prettydiff and @bitwiseman for your support!

I really need clear and concise bug reports to understand and take action on issues. Input, expected, and output.
Tagging me on an issue that hasn't been fully analyzed just makes me use the limit bandwidth I have analyzing issues instead of fixing them.

I absolutely agree, @bitwiseman. We need to put our foot down on Issue report quality. If an issue is not a clear, relatively small example with input and output (from debug.md), and expected (often missing) then we cannot spend time analyzing it when other users have properly reported their Issue.
@prettydiff let's use the waiting-for-user-information label more often when applicable and only once we have the information let's begin the analysis ourselves, and/or call in @bitwiseman for assistance. We have hundreds of Issues and limited bandwidth.
On a related note, thank you to both @prettydiff and @bitwiseman for your support!

this is another example of someone not turning on e4x for a jsx input.

I'm closing this as a duplicate of https://github.com/Glavin001/atom-beautify/issues/1165#issuecomment-269891806 which is to add JSX support.

this is another example of someone not turning on e4x for a jsx input.

I'm closing this as a duplicate of https://github.com/Glavin001/atom-beautify/issues/1165#issuecomment-269891806 which is to add JSX support.


Improve link order in Classic footer

This PR will change the default order of the Our company links in the classic footer and add the ability to the users to change this order.
Default order : About us / Stores / Contact us / Delivery / Secure payment / Terms and conditions / Legal notice / Sitemap
See Ticket : http://forge.prestashop.com/browse/BOOM-1706

Hello @fatmaBouchekoua
Can you please rebase this PR so that it can be tested and merged?
Thank you!

Hello @AlexEven ,
Done !

Tested and it's all good, thanks @fatmaBouchekoua !

It's also ok for me :)

Hello @fatmaBouchekoua
If I try to change the order of the link, it's not working. Here I tried to change 1 & 2.


Use encryption at rest on bucket as default.

In order for this to be in some envs consider adding AES-256 encryption by default to your buckets.

Yes that's a good idea as that would be more secure. We welcome pull requests. Please become a contributor if you feel strongly about this.


chore(wallet-mobile): Rename Layout to LinearTransition

Description / Change(s) / Related issue(s)
This causes some noise in the react-native bump, because it conflicts all the time with other changes in develop.
Layout is an alias for LinearTransition that react-native-reanimated is deprecating.
https://github.com/software-mansion/react-native-reanimated/blob/3.1.0/src/reanimated2/layoutReanimation/defaultTransitions/LinearTransition.ts#L48

By having it already changed in develop, it'll make life easier when upgrading the dependency.

Double checking the version that supports this change, but not so much that it breaks other things or needs a bump in react-native... 1 sec.


Address CI deprecation warnings

CI is throwing deprecation warnings (recent example):

This PR updates the CI versions to address the warnings. Note that it will be beneficial to use Dependabot (or similar) to keep the actions updated via auto-submitted PRs. If you want help with that, just let me know.

I'd love to get help with Dependabot integration. Sadly i don't have much time left today. Would you mind creating a seperate issue for that, so that we can keep track about it?

It'll only take a couple of minutes for me to submit the PR. I'll have that posted in a moment.


Final init/auth params naming

Suggestion: db_id => database_id everywhere.
Also (check with a broader set of folks) token => api_key (that was being discussed at length)

@clun just want to confirm that you agree with these two changes as well. I think it makes sense!

Latest is:

api_key (a rename of token)
api_endpoint replacing region and db_id in regular flow (with builders, helpers and/or alternative signatures for nonstandard cases possibly)

Closing this issue as this has been merged in.


className must be used instead of class for applying classes

This is a refactor-related task. There are a lot of places where class is being used instead of className.
I have already made those changes in a branch.
Happy to send a PR anytime.

@SubxX assign this to me

@Darainn sorry man Its already done waiting for confirmation so that I can create a PR.

Go ahead do this. @SubxX

PR created @Rajdip019

This issue is solved so closing is issue.


.select()

Support for both sorts of usages:
Traditional SELECT:
User.find().select('name', 'age').exec(cb);
User.find().select(['name', 'age']).exec(cb);

Prune is an exclude (inverse of select)
User.find().prune('password', 'apiKey').exec(cb);
User.find().prune(['password', 'id']).exec(cb);

+1 Would love it

+1

For those that may not be aware waterline supports select in the form of:
// Returns only the field name
Model.find({ where: { age: { '<': 30 }, select: ['name'] }})

Docs: https://github.com/balderdashy/waterline-docs/blob/master/query-language.md#select

cool!
发自我的 iPhone

在 2015年4月29日，18:32，Dário<EMAIL_ADDRESS>写道：
For those that may not be aware waterline supports select in the form of:
// Returns only the field name
Model.find({ where: { age: { '<': 30 }, select: ['name'] }})
Docs: https://github.com/balderdashy/waterline-docs/blob/master/query-language.md#select
—
Reply to this email directly or view it on GitHub.

For consistency, it would make sense if this had a dedicated function, as every other option does.
FWIW I think the initial proposal from @mikermcneil is the best way to go, it seems natural.

Can we have the method

User.find().select({'name':{'AS':'userName'},{id:{AS:'UserId'}})


repo cleanup

We have been cleaning up our repositories in light of changes, and to take care of technical debt.
Please have a look at these items, and apply as needed to this repo.
Please create a Pull Request for these changes.
README (Sign-up name in checklist below)
Replace "Bluemix" with "IBM Cloud"
Change "Journey" to "Code Pattern"
Ensure there are steps after "Flow"
Cleanup old READMEs to align with new template
Double check links section syncs up with IBMCode site
Add blog ? No
Add video? Yup
Remove "With Watson" blocks
Add "Learn More" sections: https://gist.github.com/dolph/8d5f1c34eb6f46f275563dbe9abdef14
Template for Code Pattern Readme:
https://github.ibm.com/developer-journeys/journey-docs/blob/master/_content/resources/templates/readme_template.md
Example commit:
IBM/watson-conversation-slots-intro@f406290

Addressed the issues and have created a PR https://github.com/IBM/gdpr-fingerprint-pii/pull/6. Please review and merge if it's fine. Thanks


Learning Content: Cesium for Unreal FAQ

There is a clear need for a page on the docs for Frequently Asked Questions. There are quite a few repeating topics on the forums, and it would be great to have a place to point users and provide them with more support in using the plugin.
Ideally this will be maintained and updated as the plugin changes, and may also provide a template for other product documentation as well.

Draft of the FAQ is underway.
So far, here is the list of questions that will be covered.
Requirements

Do I need an internet connection to use Cesium for Unreal?
What versions of Unreal does Cesium work with?
How do I access pre-release versions of the plugin?
How do I update the plugin?

Data and Data Formats

What is a 3D Tileset?
What is a Raster Overlay?
What file formats can I load with Cesium for Unreal?
Can I download datasets from Cesium ion?

Features

What is the Georeference?
How do I enable the water mask on Cesium World Terrain?
How do I hide a part of a tileset? How do I use Cartographic Polygons?
How do I load tilesets offline?
How can I optimize my scene’s performance?

Troubleshooting

Why is my scene bright white?
Why is my scene black?
Why can’t I see my data in the viewport?
Why did my tilesets disappear, if they were previously rendering?
How do I access debug information about my tileset?
Why are these coordinates inaccurate? (Double precision, inconsistencies between coordinate systems, calculating height from longitude and latitude)
How do I prevent characters or other objects from falling through the terrain?

Attribution

Can I remove the Cesium attribution?

Contributing

I have an idea for the plugin - how can I get involved?

Please feel free to comment with additional topics that may need to be covered, or any other suggestions.

FAQ is now posted! You can find it here: https://cesium.com/learn/unreal/unreal-faq/


Consistent descriptions for OpenAPI endpoints

LGTM

lgtm

@kibbles-n-bytes @n3wscott @tinygrasshopper we just need one more


Control errors when working on empty repo

When we try to use legit over an initialized
but empty repo it breaks with an stacktrace.
Now we control that the repo has at least one head
and for 'undo' command also that we have at least
two commits on the branch. This is needed because
'git reset' cannot work on empty repo or undo
'root' commit.
Also added a chore fix to remove pytest warnings about
marks used but not registered.

The test coverage drops but since PR is from one year ago, I will merge it anyway.
A test for undo at a branch containing only one commit may be added later, as a separate pull request.


serialize dictionary content on the parent object

I'm trying to add the keys and values from a Dictionary property into the parent object, but i'm struggling with a stackoverflow or a Self referencing loop detected with type ..
Source/destination types
this is my source class
	//[Newtonsoft.Json.JsonConverter(typeof(Json.ComponentConverter))]
	public class Component
	{
		public string Id { get; set; }

		[Newtonsoft.Json.JsonIgnore]
		public Dictionary<string, object> CustomProperties { get; set; }

		public string Type { get; set; }

	}

this is my convertor
	public class ComponentConverter : JsonConverter
	{
		public override bool CanConvert(Type objectType) {
			return typeof(Component).IsAssignableFrom(objectType);
		}
		public override bool CanRead => false;

		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) {
			throw new NotImplementedException();
		}

		public override bool CanWrite => true;
		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) {
			var token = JToken.FromObject(value, serializer);
			if (token.Type != JTokenType.Object) {
				token.WriteTo(writer);
			} else {
				JObject jObject = (JObject)token;
				if (!jObject.TryGetValue("type", out token))
					jObject.AddFirst(new JProperty("type", value.GetType().Name.ToLowerInvariant()));
				Component component = value as Component;
				if (component != null && component.CustomProperties != null) {
					foreach (KeyValuePair<string, object> @key in component.CustomProperties) {
						if<EMAIL_ADDRESS>out token))
							jObject.Add(new<EMAIL_ADDRESS>JToken.FromObject(@key.Value)));
					}
				}
				jObject.WriteTo(writer);
			}
		}

	}

Expected behavior
{"id":"123","type":"component","required":true}
Actual behavior
no result at all,  stackoverflow or a Self referencing loop detected with type X
Steps to reproduce
		JsonSerializerSettings settings = null;
		public JsonTests() {
			settings = new JsonSerializerSettings() { NullValueHandling = NullValueHandling.Ignore, ContractResolver = new CamelCasePropertyNamesContractResolver() };
			settings.Converters.Add(new ComponentConverter());
		}

		[Fact]
		public void Component() {
			Component component = new Component() { Id = "123" };
			component.CustomProperties = new Dictionary<string, object>();
			component.CustomProperties.Add("required", true);
			string json = JsonConvert.SerializeObject(component, settings);
			Assert.Equal("{\"id\":\"123\",\"type\":\"component\",\"required\":true}", json);
		}

Just remove serializer from below line and it will resolve the problem.
var token = JToken.FromObject(value, serializer);
So basically what happens behind the seen is, when you pass serializer as argument at that point it already has your object so it will try to include that object once again and it throws exception from this function.
"Self referencing loop detected" exception will be generated from here.
Now there are two solutions.
first is, you can create default serializer every time like this in your writeJson function.
var token = JToken.FromObject(value, JsonSerializer.CreateDefault());
second is, just initialize the serializer value before getting token like this
serializer = new JsonSerializer();
var token = JToken.FromObject(value, serializer);
or, As I mentioned above, you can get token like this also
var token = JToken.FromObject(value);
and that will not create any problem.

Ok, but in both option i'm loosing the customized serializer settings like ignore null, contractresolver, etc. Is there an easy way to clone the current serializer?

Yes, JsonSerializer has ContractResolver as well as NullValueHandling properties and even other also.
So you can do like this in WriteJson method.
public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
{
    serializer = new JsonSerializer();
    serializer.ContractResolver = new CamelCasePropertyNamesContractResolver();
    serializer.NullValueHandling = NullValueHandling.Ignore;
    var token = JToken.FromObject(value, serializer);
    if (token.Type != JTokenType.Object)
    {
        token.WriteTo(writer);
    }
    else
    {
        JObject jObject = (JObject)token;
        if (!jObject.TryGetValue("type", out token))
            jObject.AddFirst(new JProperty("type", value.GetType().Name.ToLowerInvariant()));
        Component component = value as Component;
        if (component != null && component.CustomProperties != null)
        {
            foreach (KeyValuePair<string, object> @key in component.CustomProperties)
            {
                if<EMAIL_ADDRESS>out token))
                    jObject.Add(new<EMAIL_ADDRESS>JToken.FromObject(@key.Value)));
            }
        }
        jObject.WriteTo(writer);
    }
}

This will return exact your required output and you can even set other properties also.


Custom role without gb permissions now handled better

Delivers #3804
People without the correct permissions now receive the access denied page with a message: "Your role in this site is improperly configured. You must have one of the section.role.x permissions assigned before you can view this page."
This required adding a new checked exception which meant a bit of a propagation of that exception up the stack.
Plus I took the liberty of a panel refactor to remove duplicated code.

Massive changes like this PR have made merging incredibly difficult. Does anyone have thoughts on how to proceed here?


Add support for htlm decoding or URL on click tracking.

Occasionally, when you use the tracking support on postal and the links have some query parameters (example a reset password message from Keycloack) then the redirect URL is rendered with HTML escaped content resulting in a wrong redirect.

Additional commit fixing #2415

Merged the conflict with the new changes to default config.

@adamcooke please you see any error on this? this is affecting us and with this patch fix the bug. I think that this fix to a bug is being ignored.

@lfdominguez Do you have an example URL which causes issues?

Do you have an example URL which causes issues?

Yes, you can check here on discussion: https://github.com/postalserver/postal/discussions/2326#discussioncomment-4728413


Skills with Maybe for Encumbrance need reformating [2.1.0 - 0.8.8 EN]

Description
The skills which have maybe for the Encumbrance break the formatting and the now go over 0 rows. Basically the column for Yes, No, Maybe requires a little bit more space. Have a look at this screenshot.

The same is true for all out Character sheets.

Hm... Is this column actually of any value at all now that encumbrance is decently automated.
I think I could remove it entirely and get a cleaner look.
Any opinions anybody?

If you can (de)select encumbrance on a per-roll basis, you dont need it
visible IMHO.
I would always make the modifier visible in the pre roll pop up, and
depending on the talent, it is either pre-selected or not. That would kill
all birds with one stone.
Plushtoast @.***> schrieb am Di., 13. Juli 2021, 11:42:

Hm... Is this column actually of any value at all now that encumbrance is
decently automated.
I think I could remove it entirely and get a cleaner look.
Any opinions anybody?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Plushtoast/dsa5-foundryVTT/issues/494#issuecomment-878939476,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO7QFH2AVR6AELVTTIESGL3TXQDBJANCNFSM5AIVGKAA
.

I wouldn't have thought it is necessary, BUT I think there definitely is room in the table and nothing really is gained by removing it.
The longest Skill name is Myths & Legends and even then you still have considerable white-space before you get to dice symbols, and if people play exclusively on Foundry they might not have another character sheet to see which skills are affected by Encumbrance.
I think it would be better to give the Yes, No, Maybe column a bit more space from the skill name side of things.

Well german name's are different

My preferred way to go would be to remove it.
It's always difficult to keep the sheet clean and this would be a good opportunity.
But I could also ask the ulisses discord... In kind of a poll

Well german name's are different. And layouts depending on the language won't be a thing.
If the colum remains I would be replace it with an icon
X checkmark and ?

To be honest, I hadn't thought about Bekehren & überzeugen or Lebensmittelbearbeitung and really I do not think it is a large loss to remove it. My players have their characters all on Optolith anyway, as the master copy and as such those PDF exports show the Encumbrance column nicely.
Go ahead and remove it.

Foundry uses this column by default. If it is set to no encumbrance won't show at all on the check. Yes it's there and selected, maybe it's ther and not selected.
So one does not really have to pay a lot of attention to this.

Hm if anyone complains afterwards I can also say it's Lambert's fault.

I know. But even Talents which usually ARE modified by encumbrance can
sometimes ignore this, depending on the situation. Currently, you dont see
anything in the roll popup but only have the modifier visible after the
roll, and only when you expand the chat text.
Thats where my idea came from: instead of doing things invisible behind the
scenes, treat it visible like any other modifier, but keep the current
sytem with yes/no/maybe.
No biggie, tough, can live without it :)
Plushtoast @.***> schrieb am Di., 13. Juli 2021, 14:20:

Foundry uses this column by default. If it is set to no encumbrance won't
show at all on the check. Yes it's there and selected, maybe it's ther and
not selected.
So one does not really have to pay a lot of attention to this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Plushtoast/dsa5-foundryVTT/issues/494#issuecomment-879039972,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO7QFH7JORFH7CMASVBR4NLTXQVSNANCNFSM5AIVGKAA
.

Yes -> In the list, selected
No -> Not in the list at all
Maybe -> In the list, selected or not could depend on the module settings
So what can happen is that you roll for a talent which has a NO setting, but in this very situation encumbrance should be used.
So the only change would be to show encumbrance de-selected when the setting in NO, the rest is already perfect.

In what case is this necessary?

Like I said, in special situations, usually it's not.
So it's really low prio, mainly it would streamline the dataflow for the
user.
Not worth to invest more than 10 Minutes.
Also, I could just change all the talents to "maybe" and voila, done :)
Am Di., 13. Juli 2021 um 16:17 Uhr schrieb Plushtoast <
@.***>:

In what case is this necessary?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Plushtoast/dsa5-foundryVTT/issues/494#issuecomment-879128523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO7QFH3TMQT6XGV5TQST2GTTXRDG7ANCNFSM5AIVGKAA
.

--
Marc Ehrenmann
Käntlibachstrasse 8
8635 Oberdürnten
Switzerland
+41 (0)78 631 93 29

Sweet


[remote-state] ignore enabled, allow bypass

what

[remote-state] ignore enabled
[remote-state] allow bypassallow bypass

why

Modules that use remote-state usually need it to work even when the module itself is disabled
Modules that really know what they are doing need a replacement for enabled to prevent the lookup of the remote state

/test all


[SPARK-44649][SQL] Runtime Filter supports passing equivalent creation side expressions

What changes were proposed in this pull request?
Currently, Spark runtime filter supports multi level shuffle join side as filter creation side. Please see: https://github.com/apache/spark/pull/39170. Although this feature adds the adaptive scene and improves the performance, there are still need to support other case.
Let me show the SQL below.
SELECT *
FROM (
  SELECT *
  FROM tab1
    JOIN tab2 ON tab1.c1 = tab2.c2
  WHERE bf2.a2 = 5
) AS a
  JOIN tab3 ON tab3.c3 = a.c1

For the current implementation, Spark only inject runtime filter into tab1 with bloom filter based on bf2.a2 = 5.
Because there is no the join between tab3 and tab2, so Spark can't inject runtime filter into tab3 with the same bloom filter.
But the above SQL have the join condition tab3.c3 = a.c1(tab1.c1) between tab3 and tab2, and also have the join condition tab1.c1 = tab2.c2. We can rely on the transitivity of the join condition to get the virtual join condition tab3.c3 = tab2.c2, then we can inject the bloom filter based on bf2.a2 = 5 into tab3.
Why are the changes needed?
Enhance the Spark runtime filter and improve performance.
Does this PR introduce any user-facing change?
'No'.
Just update the inner implementation.
How was this patch tested?
New tests.
Micro benchmark for q75 in TPC-DS.
2TB TPC-DS

TPC-DS Query
Before(Seconds)
After(Seconds)
Speedup(Percent)

q75
127.615
82.225
55.20%

ping @cloud-fan @somani

The CI failure is unrelated.

ping @cloud-fan

I have no idea how to review the code change here. I understand the general idea but how to map it to the actual code? What does the def extract do today and why do you add a new parameter to it?

ping @cloud-fan I have already added comments for extract.

@cloud-fan
I added some comments to help see if it's suitable?

The GA failure is unrelated.

The GA failure is unrelated.

thanks, merging to master!

@cloud-fan Thank you! I will do the de-alias project.


[Candidate 4v4 Dusty Rampage v3] Ambient audio cuts poorly when scrolling over map

Issue Description
Ambient audio cuts poorly when scrolling over map.
Expected behavior
Ambient audio fades in and out nicely when scrolling over map.

I'll work on this one

I'll work on this one

Thank you for assisting! Make sure to name the finalized version v4.

👍

Map name version does not matter in Candidate maps. Map will be renamed when moved to Release maps.

Fixed with https://github.com/xezon/GeneralsRankedMaps/commit/00581a2df6dd7c3a5b393962607ef1ae5878d9ce


default.theme: add styleSource and sass-options

To avoid redundant webpack configuration in applications using the default theme, the loader options should be exported as a sass-options module, similar to what the cube.theme is doing.

Implemented on master (v2.0.0).


Automated Package Upgrade

:tada: This PR is included in version 25.6.47 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Proposal: Redesigned Windows File Explorer

While a lot of the UI's present in Windows are being redesigned the File Explorer has basically stayed the same(more or less). Wouldn't WinUI  look better or a Fluent based one.

This is something up to the shell team at Windows, so the folks at WinUI probably can't do anything about it.
Let's ignore that for a moment - File Explorer will probably not use XAML controls because of their runtime overhead and dependencies for Direct3D, Direct2D, DirectComposition, etc. Also, they are all GPU-intensive frameworks. For something like File Explorer, when listing thousands of files with all their thumbnails, using XAML controls would be incredibly inefficient, slow, and will probably lag the entire system due to high CPU, GPU and memory usage. Using GDI (like it is at the moment) is the best choice and File Explorer probably won't change to any other graphics framework.
This also explain why Microsoft decided to create dark theme common controls to use in dark mode File Explorer, rather than switch to dark theme XAML controls.

This also explain why Microsoft decided to create dark theme common controls to use in dark mode File Explorer, rather than switch to dark theme XAML controls.

This happened because the feedback was misinterpreted.  People wanted dark mode for all apps but for some reason they thought they wanted it just for Explorer.

If they can't make XAML controls the default then maybe as an optional extra for people with high end graphics.

Thank you for the the proposal @mcarthur-cpt. The WinUI team does not own the File Explorer app, so this work would be outside our scope.


Document prior art

There are two 'prior' (not sure about dates) similar toolsets at https://github.com/bskinn/stdio-mgr/issues/59
They should be documented moderately prominently, and imply more prior art should be added, as they help inform development of new features.

Another similar one https://github.com/welbornprod/outputcatcher
(will be getting back to this shortly; nearly finished a large project)

:+1: I've just gotten done being swamped, so it was a good thing you were focused elsewhere anyways.
I think #76 is where we were before?

A very basic unittest prior art https://github.com/nedbat/unittest-mixins/blob/855cfe605c962b172ad6001aa7721bfb7590d06c/unittest_mixins/mixins.py#L190

https://pypi.org/project/redirect-io/

https://pypi.org/project/waelstow

Potentially useful search


Support TensorCore in chainerx::Conv

Resolve #6311.

Jenkins, test this please

Jenkins CI test (for commit 266bc5372b14d3ba68f820bc502edc8110d413bc, target branch master) succeeded!

LGTM


A generic error occurred in GDI+.

When I'm using "window.CaptureToFile(file)" an exception below is catched.
A generic error occurred in GDI+.
at System.Drawing.Image.Save(String filename, ImageCodecInfo encoder, EncoderParameters encoderParams)
at FlaUI.Core.CaptureImage.ToFile(String filePath)

Below is details.

I used a thread to capture file. When the thread is running, I do abort the thread.
Open the capture file's folder with explorer.exe.
Run thread more once, the error occurred.(if step2 is none, the error didn't occur.)

I can't fix the problem.I appreciate your help. Thanks a lot.

same error with diffrent situation
actually it's the same code from the docs
`            try
{
            url = "https://stackoverflow.com/questions/12909905/saving-image-to-file";
            Url generator = new Url(url);
            string payload = generator.ToString();
            QRCodeGenerator qRCodeGenerator = new QRCodeGenerator();
            QRCodeData qRCodeData = qRCodeGenerator.CreateQrCode(payload, QRCodeGenerator.ECCLevel.Q);
            QRCode qRCode = new QRCode(qRCodeData);
            var qRCodeAsBitmap = qRCode.GetGraphic(20);
            qRCodeAsBitmap.Save($"C:\\Users\\Houuse\\Desktop\\{DateTime.Now}", ImageFormat.Jpeg);
            System.Diagnostics.Debug.WriteLine(qRCodeAsBitmap);

        }
        catch (Exception ex)
        {

            throw;
        }`

@Jazzman82 Good catch. I think older .NET Framework Versions just threw that exception on an invalid path. Newer ones give The given path's format is not supported..
@wxue1011 @Houuse Can anyone if you check that the path to save is a valid filename?


AS-186: swapped out call boto_init.sh which was causing job failures …

…in staging and prod
https://amplify-litco.atlassian.net/browse/AS-186

version bump.

Did we ultimately decide to not fix this this way and we should close this PR?

Am closing this PR, since the bug was somewhere else.


Add a random offset to the key's clock

Given the key's clock may be used to derive some key material and security indices by the datapath encryption layer, it is better to add some random offset.
Otherwise the key's clock value is very well predictable today on a freshly started swarm cluster.
Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 55.03%

Merging [#1187][cc-pull] into [master][cc-base-branch] will increase coverage by 0.05%

@@             master      #1187   diff @@
==========================================
  Files            77         77
  Lines         12188      12144    -44
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6702       6684    -18
+ Misses         4566       4544    -22
+ Partials        920        916     -4

[][cc-pull]

Powered by Codecov. Last updated by [60115ea...fb2aac5][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/60115eac10ffac0e77b0085df0b77be04c1ad1bc...fb2aac590ea032e3cf40132d7d4ef3c5f683829e?src=pr
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1187?src=pr

cc @diogomonica

LGTM

LGTM

LGTM


My schema requests – edit requests

Description

Design

Task list

[ ] Please add tasks here

Closed in PR #1983


How to set Option with the requirement to have exact two values?

I want to create an Option where at least two values are required but I don't find an attribute like that. Is there a way to define such a requirement? Example: --openSheet [path] [table]

You could use the [OptionArray] attribute in a fashion similar to the following example (see code sample below); maybe in your case you would rather use string[].
[OptionArray('v', "values", DefaultValue = new double[] {.1, .2, .3})]
public double[] Temperatures { get; set; }
:0)

hmmm, after giving some more thinking time to your question, maybe the following example is a better fit to your reqs:
[ValueList(typeof(List), MaximumElements = 2)]
public IList OtherStuff { get; set; }
;0)

Are you using the 2.0 beta? You should be able to use the Option("openSheet", Min=2) syntax to set the minimum number of values.

I switched to version <IP_ADDRESS>, but when using the Min and Max properties it seems that the validator doesnt check for the amount of values. So it is not possible for me to trigger a parse issue when having less than 3 values. Example:" --command a b"->result is still valid
[Option('c', "command", Min = 3,Max = 3, HelpText = "Command desc.")]
public IEnumerable Commands { get; set; }

I just played around with the amounts of parameter and I could see that the "Min" requirement is working, but the "Max" requirement is ignored.

I used version <IP_ADDRESS> before. Now I am using 2.0.275.0 and everything works fine! Thank you very much!


Label for each point

Hello,
Is there any way to add labels for each point? Have added a screenshot to show what I am trying to achieve. Is this feasible and if so, what configurations do I need to choose to create it?
Thank you.

Hi there,
Do you want as like as tooltip or popover of bootstrap? Then you can.
However, there is not able to realize in currently features as you shown an image.
Thank you,


synchronize ecs-logging spec

What
ECS logging specs automatic sync
Why
Changeset

https://github.com/elastic/ecs-logging/commit/d3ffcf1 Adding service.environment to the spec (https://github.com/elastic/ecs-logging/pull/62)

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-05-16T12:01:35.022+0000

Duration: 12 min 21 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
243

Skipped
0

Total
243

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


build: add package.json repository metadata

:tada: This PR is included in version 1.39.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Hard dependency on fabric api version

When attempting to launch with the latest fabric api version, the mod will not launch and will log
Mod 'Zenith' (zenith) 1.1.7-1.20.1 requires version 0.92.0+1.20.1 of mod 'Fabric API' (fabric-api), but only the wrong version is present: 0.92.1+1.20.1!

This is because of this line, where you don't specify "fabric": ">=${fapi_version}",, but rather "fabric": "${fapi_version}",.
Thus, it is not compatible with all future versions of fabric api, requiring constant updates.

Crap.
Fixed in 1.1.8


feat: add codeql workflow

Related Issue
Closes: #81
Files added

.github/workflows/codeql.yml

To run this workflow you need to enable the following permission:

Go to your project repository settings
On left pane > Actions > General

Scroll down and Go to Workflow permissions > select "Read and write permissions"

Click save and its done.

Please review this PR.
Thanks

@subhashis2204 please review this PR
Thanks

@subhashis2204 please review this PR
Thanks


Confusing parameters wrt logging? mainnet/testnet

My goal is to start fresh on a new host. My end result should be:

a mainnet node + new service tx logger
a testnet node + new service tx logger

None of these nodes should run the legacy tx logger from the node itself.
Pain points right now:

mainnet-txlog.env enables legacy logging (I think?).
mainnet-txlog.env doesn't contain an entry for PGPASSWORD to be used? Did I miss this?
https://github.com/bisgardo/concordium-docker/blob/0bcd4933359e1dc7751fdd71cbb61a06496259f5/docker-compose.yaml#L60 makes the port for the node hardcoded (again, I think). This prevents me from running 2 nodes on the same host, using this, correct?

Ideally, I would:

clone this repo
edit mainnet-txlog.env with the correct PGPASSWORD and PGDATABASE that I've setup for the mainnet service logging
edit testnet-txlog.env with the correct PGPASSWORD and PGDATABASE that I've setup for the testnet service logging
Do NODE_NAME=concordium-explorer-mainnet ./run.sh mainnet-txlog
Do NODE_NAME=concordium-explorer-testnet ./run.sh testnet-txlog
Be happy with 2 running nodes with tx logging through the service.

The above doesn't seem possible in it's current form, right?

Re reading, I think I forgot to mention that I can't seem to figure out which tx env variables I need to include to make it work.

The above doesn't seem possible in it's current form, right?

Correct.

mainnet-txlog.env enables legacy logging (I think?).

Yes. The .env files are just for convenience. You could set all the variables manually as described here. You can edit the file as you see fit (e.g. remove the line with CONCORDIUM_NODE_TRANSACTION_OUTCOME_LOGGING) or add the extra vars to the standard mainnet.env like
TRANSACTION_LOGGER_IMAGE=concordium/transaction-logger:0.2.2-0 TRANSACTION_LOGGER_PGDATABASE=mainnet_concordium_txlog_service TRANSACTION_LOGGER_PGPASSWORD=... NODE_NAME=concordium-explorer-mainnet ./run.sh mainnet

There are many ways of skinning this.

mainnet-txlog.env doesn't contain an entry for PGPASSWORD to be used? Did I miss this?

This var (TRANSACTION_LOGGER_PGPASSWORD) must be provided on runtime to keep it out of the public git repo.

Re reading, I think I forgot to mention that I can't seem to figure out which tx env variables I need to include to make it work.

The env vars for tx logging (the service, not legacy) are referenced here (them not being in the readme is a bug): It's TRANSACTION_LOGGER_xxx, where xxx are the same as for the legacy logger.

... makes the port for the node hardcoded (again, I think). This prevents me from running 2 nodes on the same host, using this, correct?

Yes, but it's not just that port, it's also 8888, 9090, and all the other port referenced in the file. I believe it would work if you cloned the Compose file and changed all the host-side ports. Would like to hear if it does.
Running multiple nodes on the same machine (particularly on different networks) is stretching the capabilities of Docker Compose. You could duplicate the services in the config file to make a mega deployment and that would probably work fine. Or change the ports as above. Otherwise I think you're entering Kubernetes land. I'm working on upgrading the Helm chart (https://github.com/bisgardo/concordium-docker/pull/21) but it's not yet properly tested.

If you aren't using the node dashboard, you could remove the services related to that. Then there aren't that many ports left to keep track of.

Hi @sderuiter did the explanations above help?

Note that #21 mentioned above has now been merged.

To be honest, no. I've started a new node+logger, I think it works, but the logger is extremely slow (still hasn't caught up after 5 days?).
I've abandoned running the logger (+ homegrown additional db on top) for the Explorer, it's too much maintenance at this moment.
Still have loggers running for statistics, but hoping to get to a state where I can move to a new host and install a node + logger without hassle. Sorry.

To be honest, no. I've started a new node+logger, I think it works, but the logger is extremely slow (still hasn't caught up after 5 days?).

I've also seen these very long catchup times. I was assuming that it was due to the old transaction logging. The new one should be much faster, especially if you enable parallelization with TRANSACTION_LOGGER_NUM_PARALLEL_QUERIES.

Not sure if this in the planning, but ideally either the node gets its logger removed, or the new logger uses parameters that have a distinctive naming pattern (to not confuse them with the node logging parameters).

The new logger service has been completely verified to be consistent with the old one, so it is indeed the intent to remove it from both this project and longer term also from the node.
I'm not sure what you mean by distinctive naming patters as they already use distinct prefixes (TXLOG for the old TRANSACTION_LOGGER for the new). The fact that they use the same names after the prefixes is intentional.
Once the old feature is removed (which it will be soon; filed #40), I will probably settle on just the TXLOG values.

Are you sure this is consistently applied in the repo? the .ENV files are called +TX_LOG, which then refers to the old logger, while I think the purpose of these .ENV files is to enable to new logger? The READMD.md file, under heading Transaction Logger, also discusses the new logger, but uses the name TX_LOG?

The term "txlog" was/is meant to refer to transaction logging in general, not exclusively the old method. It was originally the only method; when the new one was added it had to have different names where they conflicted. The only place where this applied were in the environment variables.
The *-txlog.env files enabled both methods as explained in the readme (and further up this thread). The purpose of these files is entirely convenience.
The reason for keeping the legacy method until now was for verifying the new service.

Also, that file has:
TXLOG_PGDATABASE=mainnet_concordium_txlog
Is this referring to the new or old logger?

I used to use this database name for the old logger. Now it's used for the only logger.

Wouldn't this lead to a db name of mainnet_concordium_txlog-concordium_txlog?

No it means that it defaults to concordium_txlog if TXLOG_PGDATABASE is undefined (docs) as the readme says. ${TXLOG_PGDATABASE}-concordium_txlogwould have given that result.

The legacy transaction logging feature has been removed from the node as of v4.2.2 (https://github.com/Concordium/concordium-node/pull/395).


CI builds failing

travis-ci

Reason being that there is no env set to execute batch files.  I've briefly looked further and so far I have two viable paths to take:

Write a script test using js
This would use the fs module to walk the test/ dir and spawn a process per file using child_process
Configure Travis-CI differently
I've heard node is accessible on any travis platform regardless of what language is set to, so we could have batch be the main language and try something like it.  See this.

Actually I'm not even sure if the prev comments explanation for the fail is correct.  The err log is something like:

err test.bat not found

A quick temp solution might be to name different scripts on package.json that run node, e.g.:
"test1": "node ./test/test-1"
And so forth for every test file.

Remember that this fix is temporary.  Not that it doesn't work but that it's not verbatim and noisy.  Every time we add a test script we must also add it manually (if not with a bot) to .travis.yml.
It would be easier if we do something like this:

Write a script test using js
This would use the fs module to walk the test/ dir and spawn a process per file using child_process


Merge main into live

Please don't squash-merge this PR.

closing and reopening for a fresh build.


Proxy accessing array in a not thread safe way

#482

AddUint32 returns the previous value of the variable. Can't this be safely rewritten as
index := atomic.AddUint32(&r.index, 1) - 1
u := r.proxyURL[index%uint32(len(r.proxyURLs))]

instead?

that is better

Oops, correcting myself:

AddUint32 returns the previous value of the variable.

It actually returns the new value. The code was (and still is) correct, -1 is indeed necessary so it starts from the first element, it's just my comment was wrong and misleading.

Ya, I sort of got that when I was correcting it, but ya around 5-6 lines better than before


What value should I send for SameSite = None and Secure?

Chrome update has given me great trouble
So far, I still haven't found anyone's answer in Chrome 80 that correctly answers SameSite issuess.
Leave the following questions for me and us.
In my html page, there is only  provided by YouTube.
However, in Chrome, 'cross-site requests if they are set with SameSite = None and Secure' are displayed.
What should I do?
I only did YouTube iframe, what value should I send cookie value and session value?
I want a direct solution.
A fake method like 'cross-site-cookie = name' doesn't help me.
I need a direct way to experience.
I want about php version <7.3 and I want to solve the problem with php or javascript or .htaccess etc.

** If you use only  tag as well as YouTube, a danger sign is displayed unconditionally.
I don't know the value required by the external urls. What value should I send to the external urls as a session?

If you are embedding a YouTube video, then you do not need to manage any cookies related to this. The cookie you're showing for the eie.co.kr domain is not going to be related to your video embed.
What do you mean by a "danger sign"? Is your embedded video working?


Not synced, retrying fallback headers

I try to set up a sPRUNED node in a DigitalOceans droplet (Ubuntu 16.04.4 x64) and the installation went smoothly. Once I start the application, however, it does not seem to find the network.
$ ~/src/spruned/venv/bin/spruned --daemon --debug
$ tail ~/.spruned/bitcoin.testnet/bitcoin.testnet/spruned.log
2018-07-14 20:30:33,094 - root - DEBUG - Running spruned daemon
2018-07-14 20:30:33,096 - root - WARNING - Starting daemon.
2018-07-14 20:30:33,097 - root - DEBUG - Arguments: Namespace(cache_size=50, daemonize=True, datadir='/home/bitcoin/.spruned/bitcoin.testnet', debug=True, keep_blocks=200, network=None, rpcbind='<IP_ADDRESS>', rpcpassword='..................', rpcport=18332, rpcuser='bitcoin')
2018-07-14 20:30:33,099 - leveldb - DEBUG - Ensuring integrity of the storage, and tracking missing items
2018-07-14 20:30:33,099 - leveldb - DEBUG - Ensuring no stales in blockchain repository
2018-07-14 20:30:33,104 - cache - DEBUG - Loaded index
2018-07-14 20:30:33,104 - cache - DEBUG - Empty index found
2018-07-14 20:30:33,105 - cache - INFO -
Purged from storage 0 elements not tracked by cache.
Total tracked: 0
Total protected: 0,
Total cached: 0,
Total entries: 0,
Total transactions: 0

2018-07-14 20:30:33,105 - leveldb - DEBUG - Checking cache limits
2018-07-14 20:30:33,106 - cache - DEBUG - Stales purge done, removed 0 items from index
2018-07-14 20:30:33,107 - cache - INFO - Cache is ok, size: 0, limit: 50
2018-07-14 20:30:33,107 - cache - DEBUG - Stales purge done, removed 0 items from index
2018-07-14 20:30:33,107 - cache - INFO - Cache is ok, size: 0, limit: 50
2018-07-14 20:30:33,134 - electrum - DEBUG - Checking internet connectivity
2018-07-14 20:30:33,305 - electrum - DEBUG - ConnectionPool: connect, needed: 1
2018-07-14 20:30:33,306 - electrum - DEBUG - Connecting to peers (1)
2018-07-14 20:30:33,307 - electrum - DEBUG - Created client instance: testnet.hsmiths.com
2018-07-14 20:30:33,308 - spruned.dependencies.connectrum - DEBUG - Connecting to: <ServerInfo testnet.hsmiths.com nick=bade5985a4fbd742 ports="['s', 't']" v=1.2 prune=0>
2018-07-14 20:30:33,493 - spruned.dependencies.connectrum - DEBUG - Transport connected ok
2018-07-14 20:30:33,833 - spruned.dependencies.connectrum - DEBUG - Connected to: <ServerInfo testnet.hsmiths.com nick=bade5985a4fbd742 ports="['s', 't']" v=1.2 prune=0>
2018-07-14 20:30:33,834 - electrum - DEBUG - Connected to testnet.hsmiths.com
2018-07-14 20:30:34,011 - spruned.dependencies.connectrum - INFO - Error response: '{'code': 2, 'message': "daemon error: {'code': -5, 'message': 'No such mempool or blockchain transaction. Use gettransaction for wallet transactions.'}"}'
2018-07-14 20:30:34,012 - electrum - DEBUG - Exception connecting to testnet.hsmiths.com ('blockhash')
2018-07-14 20:30:34,012 - electrum - DEBUG - Checking internet connectivity
2018-07-14 20:30:39,117 - spruned.dependencies.connectrum - DEBUG - Server version: ['ElectrumX 1.5.1', '1.2']
2018-07-14 20:30:39,120 - electrum - DEBUG - Fallback headers check: Not synced yet or sync locked (False), retrying fallback headers check in 30s
2018-07-14 20:31:09,131 - electrum - DEBUG - Fallback headers check: Not synced yet or sync locked (False), retrying fallback headers check in 30s
2018-07-14 20:31:39,139 - electrum - DEBUG - Fallback headers check: Not synced yet or sync locked (False), retrying fallback headers check in 30s
2018-07-14 20:32:09,150 - electrum - DEBUG - Fallback headers check: Not synced yet or sync locked (False), retrying fallback headers check in 30s
2018-07-14 20:32:39,151 - electrum - DEBUG - Fallback headers check: Not synced yet or sync locked (False), retrying fallback headers check in 30s
2018-07-14 20:32:39,297 - spruned.dependencies.connectrum - DEBUG - Server version: ['ElectrumX 1.5.1', '1.2']
2018-07-14 20:33:09,159 - electrum - DEBUG - Fallback headers check: Not synced yet or sync locked (False), retrying fallback headers check in 30s
2018-07-14 20:33:39,170 - electrum - DEBUG - Fallback headers check: Not synced yet or sync locked (False), retrying fallback headers check in 30s

I have a firewall set up, but only blocking incoming transactions. Outgoing, everything is open. Are there any network settings I need to configure. Or is it something completely different?
Thanks in advance for your support!

Hello, testnet servers are unreliable, I always thought I should set up one or two.
If you have notice of reliable testnet electrum servers you can add your own by making a PR.


Value of type 'DataRequest' has no member 'stream'

What did you do?
Upgrade the Alamofire from version 4 to 5
What happened instead?
I am being told 'Value of type 'DataRequest' has no member 'stream' , is there any replacement for this api?
I am using request().stream {(data) in } method to receive chunk data from my server. the server pushing realtime log via stream chunked json data through get method. (For example: the Docker log api)
Alamofire Environment
Alamofire version:5.0.0-beta.6
Xcode version:10.2.1
Swift version:5
Platform(s) running Alamofire: Mac
macOS version running Xcode:10.14.5

There is no equivalent to stream { } in Alamofire 5. It was removed from DataRequest due to the inherent differences between stream and response handling leading to a subpar user experience. However, we do think it's useful and it shouldn't be too difficult to support, but we'd like to know more about how people use the feature and what would be wanted out of it. So can you describe your use case? Are there any Alamofire features you would like to see for streaming HTTP data?

I am writing an gui program for a proxy client call Clash. It provide logs and realtime traffic through stream api. When using curl, it looks like below

The traffic data updated per second using stream chunked data.
These are codes I am using with Alamofire 4:
request(ConfigManager.apiUrl + "/traffic")
.stream {(data) in
    if let jsonData = try? JSONSerialization.jsonObject(with: data) as? [String:Int] {
        callback(jsonData["up"] ?? 0, jsonData["down"] ?? 0)
    }
}.response {[weak self] res in
    guard let err = res.error else {return}
    // Error Handle
}

I get streaming chucked data via stream{} and handle error in response{}. In stream callback, I need to manually parse json data. I hope Alamofire could also provide streamJSON or even streamDecodable method for easier use.

@jshier Any ideas ?

This would involve creating a new Request subclass, likely something like DataStreamRequest, and adding the appropriate API, ensuring we don't store any of the data in memory. We don't have the bandwidth to do add this at the moment, but we'd be very interested in a PR building this functionality.

I am also using the stream function for stream chunked data, can you please add that function back in the new version.

I am also using request().stream {(data) to fetch the data from the sever as we have large amount of data flow at the time of initial sync. please keep the support for stream. We are receiving the chunk of data continuously as response  stream, we are parsing it till the end of stream.

This is now tracked by #3072. Work is also proceeding on the feature/data-streaming branch, check it out and add your feedback to the tracked issue.

@yichengchen Thanks for the example. I've been able to confirm that the new DataStreamRequest can successfully decode from the Clash traffic log stream. Something like this should work:
struct ClashLog: Decodable {
    let up: Int
    let down: Int
}

AF.streamRequest("http://<IP_ADDRESS>:9090/traffic").responseStreamDecodable(of: ClashLog.self) { output in

}

It should be released as part of the next minor version of Alamofire.

Great!

DataStreamRequest shipped as part of Alamofire 5.1.


SquiggleRelativeValues (proof-of-concept)

Codecov Report

Merging #1571 (bd21f59) into develop (725c28c) will decrease coverage by 0.08%.
The diff coverage is n/a.

:exclamation: Current head bd21f59 differs from pull request most recent head fd1f447. Consider uploading reports for the commit fd1f447 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           develop    #1571      +/-   ##
===========================================
- Coverage    73.09%   73.01%   -0.08%
===========================================
  Files           93       93
  Lines         5017     5022       +5
  Branches       838      839       +1
===========================================
  Hits          3667     3667
- Misses        1326     1330       +4
- Partials        24       25       +1

see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


TableHeader: add type="button" to button

To prevent form submission when placed inside a form.

thank you for this!

Thank you. Fixed in v0.70.13.


Document that --config-file shouldn't be used with the operator

Using an external configuration file mean that the Jaeger instance has to be manually restarted, instead of letting the operator handle the configuration change.
We need to document this behavior and recommendation, but also point out that this might change soon, once on-the-fly updates are supported.
See https://github.com/jaegertracing/jaeger/issues/1058

@jpkrohling do we still need this given that #2188 implements time-based reloading?

Good question. I think the basic idea is still valid ("a config file shouldn't be used with the operator"), as the Operator will add configuration options as flags based on the environment (mTLS when possible, ES URL for auto-provisioned storage, ...) and using --config-file might cause confusion when trying to figure out the effective configuration for an instance.


Crash on skillshot

The game is crashing 1/10 times when you're doing a skillshot, at the exact moment when is supposed to make the skillshot announcement and sound.

Duplicate of #52 i think

True, haven't seen it


GEODE-6993: Add documentation for alter query-service gfsh command

Co-authored-by: Benjamin Ross<EMAIL_ADDRESS>Co-authored-by: Donal Evans<EMAIL_ADDRESS>Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Thanks for contributing docs!
A small request: in alter.html.md.erb, in the phrase: "...parsing of the parameter string which makes using..." please add a comma after "string": "...string, which..."

Thanks for contributing docs!
A small request: in alter.html.md.erb, in the phrase: "...parsing of the parameter string which makes using..." please add a comma after "string": "...string, which..."

Done!


Updated the validations.py python script

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Improve username behavior
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Add Compare Tool

Our initial thoughts (from @geohacker and I) on the workflow is to add a new page that lists all exported maps in the platform, and, in that page, the user would be able to select two maps and click on a 'Compare' button, which opens another page with the compare view.
To keep the map list page as simple as possible, it would look like as table available in the project page that lists its exported maps, but with the ability to search by map name. Currently, the exported map names are restricted to the geocoded name of the area, which makes difficult to differentiate between them. To address that, we can suggest to the user to include the mosaic description in the exported map name, like "Amanalco - Sentinel - March 1 to May 1".

I think this means adding a custom name to the map while exporting. Which I suppose could be done by asking the user when they click 'Export'.
I'm not entirely sure if the single page with all exported maps is the ideal workflow but I think it may be the easiest approach to get some feedback.
Also tagging @LanesGood in case he has any thoughts.

Maps can only be compared if exported

Yes, I think this is important because we only create the URL and shareable assets during the export step.

Users can compare maps that they have created - not all maps created by anyone using the platform
If these restrictions are true, we would want to incorporate this documentation into the export flow.

@LanesGood the idea of creating a separate page to see all exported maps is so that we don't have this restriction. If we wanted to allow a user to compare only their exported maps, we can do that from the Project page itself.

Sounds great! I had not realized this would enable users to compare all maps.

We'll want to explore map comparison styles:

side by side (multiple fixed viewboxs, synced zoom + pan)
slider A:B (single viewbox)
opacity (overlayed)

I've mocked up the flow here: Figma Prototype: Compare Maps. Please take a look and let me know your thoughts.
At the moment, this proposed flow has a compare screen with a slider A:B comparison tool. On this compare screen, we'll need to include the AOI names and LULC classes of both selected maps.
I do think there we should allow a user to view an exported map and then select a comparison. This may be tricky given the current unique URL of shares, but could allow for a more direct workflow.

I've updated the screens to include:

more information for the prediction tiles for both maps being compared

Users should be able to see imagery source, mosaic date range, model and checkpoint for each prediction layer being compared

Buttons to Download and View individual map for each map being compared
Example of opacity slider in use
"Mirror" map comparison mode
"Overlay" map comparison mode

Discussed and decided with @vgeorge:

Only implement the slider for now on prediction tile comparison
We likely do not need to add custom AOI name based on a formula like area | imagery | timeframe because the compare maps page + tool will surface all this information. This will allow users to pick maps to compare with a reference to all important info, without cramming all the info into the name

However, if it is important to allow users to update AOI names for other reasons (geocoder got the name wrong, etc), then this should be available on all AOI's, not just those that are exported. This would require a change on both frontend and backend

"All public maps" page will include a selection/comparison table to indicate which maps are selected.
Empty

Selected:

I also explored rendering the selected AOIs as cards, but this seemed like an unnecessary waste of vertical space, inconsistent with the table display on the rest of the page, and table display makes easier comparison of variables.


Rebrand (post-RC, pre-stable)

These are the steps to take before the stable release of Compose 1.1.0.

[ ] Update README.md with new docs URL
[ ] Update Bash completion script
[ ] Create a fig-stable branch from the 1.0.0 tag

[ ] Add a deprecation warning to all pages on http://www.fig.sh
[ ] Deploy website

[ ] Add a deprecation notice to the PyPi page for fig
[ ] Create the #docker-compose IRC channel

[ ] Update the README and docs with new channel

[ ] Rename the GitHub project

Just to inform; upon release of compose, will there also be a fig alias to ease the migration? Preparing myself to make my colleagues get used to using another command (and ... tbh, fig is still nice and short)
Also, will compose still look for fig.yml files, or do they have to be renamed?

(Linking in #864 to answer @thaJeztah question for anyone interested)
Should we close this 1.1.0 milestone and create a new 1.1.0-rc2 milestone?

I don't think we need to release another RC unless there are critical bugs.

I think we should release a second RC. An RC should be complete bar critical bugs. I'm not sure it needs a separate milestone though – ideally the 1.1.0 and 1.1.0-rc2 milestones should be the same. ;)
FYI – Engine and Machine are releasing second RCs on Tuesday or Wednesday.

Will bash completion be included in the release?
Currently bash completion is only referenced from the docs with the link pointing to the current development state in the repo. Thus, Compose and its completion are bound to run out of sync.
(This also raises the question whether putting completion on code freeze makes sense at all.)

The docs point to the release tag (currently 1.1.0-rc2), so there's no risk of version drift there. I've added a checklist item to update it when we release.

Perfect! Thanks @aanand.


Fix a bug and add a few tests

Pretty sure that pop! wants a ClassifiedCollections there.

lgtm, nice catch


Object.activate is deprecated.

AtomLinter v0.X.Y API has been deprecated. Please refer to the Linter docs to update and the latest API: https://github.com/AtomLinter/Linter/wiki/Migrating-to-the-new-API
Object.activate (/home/prabhat/.atom/packages/linter/lib/main.coffee:57:8)
Package.activateNow (/usr/share/atom/resources/app.asar/src/package.js:240:19)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:221:30)
Package.measure (/usr/share/atom/resources/app.asar/src/package.js:165:15)
Package.activate (/usr/share/atom/resources/app.asar/src/package.js:213:14)
PackageManager.activatePackage (/usr/share/atom/resources/app.asar/src/package-manager.js:452:21)

AtomLinter v0.

We are already v1.0. Perhaps this error is from another package. See : https://github.com/TypeStrong/atom-typescript/blob/master/package.json#L20-L24
:rose:


'repo' directory size increasing

Important: GitHub issues are for feature requests or bug reports. The Capistrano team recommends you use Stack Overflow for general questions. For more details, please see our contribution policy.

Steps to reproduce

Deploy your project (Only master branch) - set :git_shallow_clone, 1
Check 'repo' size
Continue to push and deploy new code and deploy
Check your 'repo' size in a couple of days

Expected behavior and  Actual behavior
Though 'repo' size has to increase, it increases too fast
System configuration
Environment
Ruby     ruby 2.0.0p598 (2014-11-13) [x86_64-linux]
Rubygems 2.0.14
Bundler  N/A
Command  /usr/local/bin/cap production doctor
Gems
capistrano        3.6.1
airbrussh         1.1.1
rake              11.3.0
sshkit            1.11.4
net-ssh           3.2.0
capistrano-harrow 0.5.3
Variables
...
:git_shallow_clone           1
....
:git_shallow_clone is not a recognized Capistrano setting (/usr/share/ruby/delegate.rb:72)
By the way cloning and fetching is really executed with '--depth 1' option. So everything has to be fine, but it doesn't. When I cloned the repo for the first time, it took ~130Mb, but after one day of pushing (updating) code it increased to ~630Mb. After a couple of weeks 'repo' increased to 4G. Is it an issue?

Sorry, I haven't encountered this problem before. Does git gc help? If so, you could write a custom task that runs git gc after a successful deploy.

Though 'repo' size has to increase, it increases too fast

The size of this dir is surely subjective. You might consider to run git gc in this directory and share the results. It's entirely likely that your repository simply includes a lot of larger binary assets, hence the ballooning size.
As @mattbrictson just suggested if git gc helps, it would be pretty easy to gc this directory after a successful deploy.

Thanks for your help. Git gc really helps

[root@pc repo]# du -sh .
626M	.
[root@pc repo]# git gc
Counting objects: 83290, done.
Delta compression using up to 32 threads.
Compressing objects: 100% (38461/38461), done.
Writing objects: 100% (83290/83290), done.
Total 83290 (delta 44660), reused 80874 (delta 42244)
[root@pc repo]# du -sh .
133M	.

It has been compressed to 133M, like it was cloned for the first time. Will 'git gc' bring a new surprises in future deployments?

Will 'git gc' bring a new surprises in future deployments?

No, from the docs:
Runs a number of housekeeping tasks within the current repository, such as compressing
file revisions (to reduce disk space and increase performance) and removing unreachable
objects which may have been created from prior invocations of git add.

Users are encouraged to run this task on a regular basis within each repository to maintain
good disk space utilization and good operating performance.

Do you need assistance with writing an after hook to run git gc after your deployment?

No, thanks. It's not a problem for me =)


New version: Kitware.CMake version 3.29.0-rc1

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@Exorcism0666 @stephengillie
This is a release candidate and not a stable version of CMake which is now offered as an update. I'm pretty sure this shouldn't be the case.
Would you consider a revert or is there some reasoning behind this change? Thanks!

@Carbenium thank you! Exactly this is why I came here to search for this PR. This is really bad form smuggling a pre-release version into such a widely used tool as winget -- even if it is a release candidate.
Create a new manifest under a new product name, instead. Other products have created numerous precedents, for example: manifests/a/ArduinoSA/IDE/rc, manifests/d/Dapr/CLI/Preview, manifests/l/LinwoodCloud/Butterfly/Nightly, manifests/o/OBSProject/OBSStudio/Pre-release, manifests/p/Prusa3D/PrusaSlicer/Alpha, manifests/o/OpenTofu/Tofu/RC as well as a number of beta versions:
$ find -type d -iname 'beta'
./manifests/a/AdGuard/AdGuardVPN/Beta
./manifests/a/AgileBits/1Password/Beta
./manifests/a/AprelTech/SilentInstallBuilder/Beta
./manifests/a/ArduinoSA/IDE/beta
./manifests/b/BitSum/ProcessLasso/Beta
./manifests/b/bozbez/WinCaptureAudio/beta
./manifests/b/Brave/Brave/Beta
./manifests/c/ClipTeam/ClipCC/Beta
./manifests/c/Coq/CoqPlatform/Beta
./manifests/c/CozyCloud/CozyDrive/Beta
./manifests/f/FeePerfect/Feem/Beta
./manifests/f/Ferdium/Ferdium/Beta
./manifests/g/Getscreenme/Dashboard/Beta
./manifests/g/GitHub/Atom/Beta
./manifests/g/GitHub/GitHubDesktop/Beta
./manifests/g/Google/AndroidStudio/Beta
./manifests/g/Google/Chrome/Beta
./manifests/g/Google/PlayGames/Beta
./manifests/h/Hashicorp/Terraform/Beta
./manifests/h/Hiddify/Next/Beta
./manifests/i/i2p/firefox/beta
./manifests/i/Intel/PresentMon/Beta
./manifests/i/InTheLoop/LoopEmail/Beta
./manifests/k/Kuro/Mery/Beta
./manifests/m/Microsoft/Edge/Beta
./manifests/m/Microsoft/OpenSSH/Beta
./manifests/n/NetEase/CloudMusic/Beta
./manifests/o/OpenTofu/Tofu/Beta
./manifests/o/OpenWhisperSystems/Signal/Beta
./manifests/o/Opera/Opera/Beta
./manifests/p/PicGo/PicGo/Beta
./manifests/p/Premake/Premake/5/Beta
./manifests/r/RandomEngy/VidCoder/Beta
./manifests/r/rickbutton/workspacer/beta
./manifests/s/SFLinux/Jami/Beta
./manifests/s/SlackTechnologies/Slack/Beta
./manifests/s/stakira/OpenUTAU/Beta
./manifests/s/StarfaceGmbH/StarfaceUCC/Beta
./manifests/s/stnkl/EverythingToolbar/Beta
./manifests/s/subhra74/XtremeDownloadManager/Beta
./manifests/t/TeamSpeakSystems/TeamSpeakClient/Beta
./manifests/t/Telegram/TelegramDesktop/Beta
./manifests/t/thomasnordquist/MQTT-Explorer/Beta
./manifests/w/WeMod/WeMod/Beta
./manifests/w/WhatsApp/WhatsApp/Beta
./manifests/w/WinMerge/WinMerge/Beta
./manifests/w/WowUp/Beta
./manifests/y/YutakaSawada/MultiPar/Beta
./manifests/z/Zettlr/Zettlr/Beta

I've created now a PR reverting this change: #140344.

@exoosh we don't necessarily know all software and their release mechanisms/cadences. That's exactly why there is so much value in having this repository open-source. We do try to ensure packages install and upgrade correctly, but there are cases like this where the community knows more than we do.
Thank you so much for "seeing something" and "saying something"!

@exoosh we don't necessarily know all software and their release mechanisms/cadences. That's exactly why there is so much value in having this repository open-source. We do try to ensure packages install and upgrade correctly, but there are cases like this where the community knows more than we do.
Thank you so much for "seeing something" and "saying something"!

Hey @denelon, thanks for the response. My question was more about whether you have guidance regarding how to deal with betas or other pre-release versions (I gave some examples how other manifests treat those). The reason I ask is because with such guidance one could point to the guide. I'm not suggesting that you folks should know the modus operandi for each and every piece of software with a manifest. Sorry if that wasn't clear.

@exoosh, ah... That makes sense. @stephengillie what do you think about updating the guidance/policy stuff so it can be linked to?

Sounds like a plan.

https://github.com/microsoft/winget-pkgs/pull/141399


Can you only use the latest version of this module with typescript? What about normal nuxt?

Apologies if I am missing something, but the latest version of this strapi module documentation https://strapi.nuxtjs.org/usage/ is all showing typescript examples. Can you still use this module with standard nuxt js (eg. this.$strapi.find() as with the older version)? If so, can you please update the docs accordingly because I think they are very misleading, its not clear what you can do!
Also, is there support for if you are using strapi v4 but nuxt v2? Or do you have to upgrade to nuxt v3? I find nuxt v3 has issues with some of the other packages I use (using nuxt 2 with bridge), but would like to use the latest version of strapi if I can.
Thanks!

@benjamincanac not sure if I'm doing something wrong 🤔
I'm using Nuxt Bridge with "@nuxtjs/strapi": "npm:@nuxtjs/strapi-edge@latest"

and I got 'useStrapi4' is not defined.
I have the module defined in my nuxt.config.js and in my buildModules.
Thank you very much 🙏

Hi @Tragio
Did you install the package as a dev dependency?
yarn add -D @nuxtjs/strapi
Btw: You don't need to use the edge channel anymore to use v1 of the module :)

@Tragio this example uses Nuxt3 & v1.2.0 of the strapi module:
pages/index.vue
<template>

Strapi Test

</template>

So it is possible to use the composables inside of the Options API

@Tragio this example uses Nuxt3 & v1.2.0 of the strapi module:
pages/index.vue
<template>

Strapi Test

</template>

So it is possible to use the composables inside of the Options API

@luke-z thank you very much. I tried but I have an Uncaught (in promise) Error: nuxt app instance unavailable 🤔

@Tragio

Hi @Tragio
Did you install the package as a dev dependency? yarn add -D @nuxtjs/strapi
Btw: You don't need to use the edge channel anymore to use v1 of the module :)

Dependency installed but similar problems here using the following:
"devDependencies": {
   "@nuxtjs/strapi": "^1.3.1",
   "@nuxtjs/tailwindcss": "^5.0.0-4",
   "nuxt3": "^3.0.0-27437402.494f85a"
 }

Issues in the nuxt.config.ts
import { defineNuxtConfig } from 'nuxt3';

// https://v3.nuxtjs.org/docs/directory-structure/nuxt.config
export default defineNuxtConfig({
  typescript: {
    strict: true,
  },
  buildModules: ['@nuxtjs/tailwindcss', '@nuxtjs/strapi'],
  css: ['~/assets/css/animate.css', '~/assets/css/style.css'],
  strapi: { // This whole object is linted by ts (see below)
    url: process.env.STRAPI_URL || 'http://localhost:9001',
    prefix: '/api',
    version: 'v4',
    cookie: {},
  },
});

Argument of type '{ typescript: { strict: true; }; buildModules: string[]; css: string[]; strapi: { url: string; prefix: string; version: string; cookie: {}; }; }' is not assignable to parameter of type 'NuxtConfig'.
Object literal may only specify known properties, and 'strapi' does not exist in type 'NuxtConfig'.ts(2345)

Also errors in index.vue component
<template>

</template>

@jbool24 We currently have an issue with exported types I have to look into. For now, you can import types like this:
import type { Strapi4Response } from '@nuxtjs/strapi/dist/runtime/types'

@benjamincanac for my issue, is there any idea why is not working for the Options API?

I'm in the process of switching to nuxt 3 and strapi v4 and it would be easier if it didn't force me to use typescript.
Besides I don't know from how the strapi types are imported. Do you have to define them by hand?
import type { Restaurant } from '~/types'
import type { Strapi4Response } from '@nuxtjs/strapi/dist/runtime/types'
const response = await find<Strapi4Response<Restaurant>>('restaurants')

Hi @benjamincanac thank you for explaining, and sorry for the delayed response (had notifications off, oops!), I have taken the plunge and am using nuxt 3 and strapi 4 for my project now.
In the docs, to use the Find One call (for example) you do the following:

But my code errors because ~/types isn't found. Do you have an example of this types file?
import type { Restaurant } from<EMAIL_ADDRESS>as above but this also errors with "Internal server error: [@vue/compiler-sfc] Unexpected token, expected "from" (12:12)"

@EmilyFlocc Here Restaurant is an example, types are not bundled with the library, you have to create them yourself ~/types/index.ts for example.

@Tragio Sorry for the late answer, composables are only usable in setup hook as mentioned here https://vuejs.org/guide/reusability/composables.html#conventions-and-best-practices, here is also an example on how to use composables with Options API: https://vuejs.org/guide/reusability/composables.html#using-composables-in-options-api

Hi, does anyone have an example of the contents of the "/types" folder and a type declaration file because nuxt cannot find my @/types module.

@Theo-Rige , try this:
`interface Restaurant {
title: string;
content: string;
}
export { Restaurant };`
The file I created in types-Folder is called index.d.ts


Support compile targets between ES5 and ES6

As of August, 2015, there are several platforms that have JS implementations falling somewhere between ES5 and ES6. Chrome 45+ has block scoping, fat-arrow functions, Map/WeakMap/Set/WeakSet, and classes. io.js 3.x has all of these features as well except fat-arrow functions, but they're coming in Node.js 4.0 or so next month.
The big common case here is that none of these platforms support ES6 modules yet -- I imagine none of them will for some time.
Can we get a compiler mode to emit ES6 features selectively, or at least emit ES6 except for modules? @mhegazy mentioned in the TypeScript gitter that this would be effectively supporting --t es6 alongside --m commonjs in terms of compiler flags.

:+1:
Though you may try something like System.js, for now.

Well, System.js is a partial solution -- it's just another package manager in the end. The primary reason for wanting this feature, node supporting a good deal of ES6, makes CommonJS the only reasonable target.

I would think decoupling packaging emitting from other features would make sense...  I see situations where there is a valid use case for emitting UMD/AMD/CommonJS modules while still targeting ES6 at the code level without additional build steps. :+1:

As a feature this would be single most important thing for me right now, since I could effectively use type annotations while using all the ES6 features available in io.js. :+1:

I'd like to note that this is technically possible right now with some rough edges with module resolution if you chain TS by compiling it to ES6 then running it through Babel with only the module transformer enabled. There could be other issues, and I'm not sure how TypeScript handles ES7 translation features either.
Actually, with ES7 coming up I think it's going to be more and more important to selectively enable future JS features as different platforms enable varying support. We're not going to get modules for awhile, but what about annotations from ES7? Async/await? Some of these things could be implemented by some platforms and those features should be used on clients like io.js where the requirements are known ahead of time.

On the other hand a mode, where you simply write the "near-ES6" syntax of your platform using the e.g. CommonJS syntax (io.js), but treating files which use this syntax just like they are ES6 modules, would be possible too (for me atleast) - all the transpiler would need to do is to basically strip out the TypeScript-specific features.
Currently, if you try to do this, it won't work since the compiler treats "local" variables automatically as global ones, if the ES6 module syntax isn't used, and when using e.g.
const foo = require("./foo");

in more than one file it will throw
error TS2451: Cannot redeclare block-scoped variable 'foo'.

@lhecker I think that just means you're not specifying --module if I'm understanding you right.
You can use --target es5 --module commonjs and write import foo = require('./foo').

@jbrantly Nope that's not what I meant.
What I was saying is that an alternate solution for now would be to mark all files using require() or exports as ES6 modules, thus making file-local variables actually local to the file (which would match CommonJS behaviour and not the current Browser-like one).
That way you could at least already use the latest native ES6 features of io.js. One could also introduce a new target value to supress accidential shims (e.g. --target native) and enforce the use of native ES6 features, but I guess the thing I mentioned in the previous paragraph is much more important (about treating CommonJS modules as ES6 modules).

@lhecker I think I see what you're saying. You're specifying --target es6 because you want the es6 emit, but you can't use import foo = require('./foo') in that case, so you're skirting around that by not using import but then running into the scope issue.
You could always use IIFEs :smile:
I'm not sure how I feel about this issue overall. If you're targeting the browser then you're going to have to  target the least common denominator anyways, which means es5 (and a bring-your-own module system). If you're targeting a server environment where you control everything, sure, you might be able to use some ES6 features that you don't want to transpile but what is the harm in transpiling anyways? Or, alternatively, emit ES6 from TypeScript and use something like Babel whose core competency is transpiling to get CommonJS (whereas TypeScript's core competency is static type checking). I think TypeScript currently does a good job balancing transpiler features and simplicity with the es5 and es6 targets.

@jbrantly it could also be possible to target only a specific subset of browsers.
Additionally, transpilation kills the benefit of some structures, like numeric for loops with block-scoped variables:
for (let i = 0; i < 10; i++) {
    // ...
}

TypeScript also has issues with for-of loop code generation because of the compile-time ambiguity and the way iterators work. io.js doesn't have that issue, and I'd like to iterate over arbitrary iterables, which would require ES6 output.

This would be great.
Another pain scenario at present is trying to use ES6 generators, which are supported by both TypeScript and Node.js. However if one targets ES5 for Node.js projects, TypeScript won't allow the generators even though it could just emit them as-is (like it does for ES6) if some flag would allow.
One can wait for TypeScript to implement down-level emit for generators in ES5, but that seems unnecessary since the target platform supports generators natively.
I'm aware one can target ES6 and add Babel to the build process, however given that TypeScript can already emit generators, if feels like unnecessary complexity.
More granular targetting in TypeScript would be a great solution IMO.

This would be great.
1.4 seems support -m commonjs -t es6 already, but 1.5 does not.

Right now, the only reason I'm not using Typescript in my nodejs projects is because of the impossibility to use generators in an ES5 context.
It's a reality that node.js and io.js provide a runtime that overlaps the ES5/ES6 specs. There are many useful functionalities as consequence.
The use of Generators with Promises reduces asynchronous code complexity which greatly improves maintainability on projects that heavily rely on I/O logic which is one of the core premises when working server-side.

I made a proposal for a possible solution over at #4692. There is a working implementation too.

Until there's broader support for ES6 on the platforms that I target (in my case web browsers) or more down-level emit support in TS, I prefer to let TS emit ES6 and pass that through Babel to get ES5 compatible code. That way I can use more features already. Indeed at the cost of a higher build complexity (though that remains manageable so far ^^).

Node 4.0.0 supports many ES6 features now that I think would make this issue more broader. The most important feature for me is that it supports generators now, bringing async/await into the tool set of anyone wanting to use TS 1.6 from beta.

+1

+1, we need to debug generators

if you are using typescript@next you should be able to specify --target ES6 and --module commonjs and get generators working on node v4. see #4811 for more details.

A good example is rest parameters.
Using --target es6 generates code that Node 5 can mostly run natively (it has around 59% coverage of the full ES2015 spec so far). let, class (with strict mode), generators, fat arrow functions, etc all work fine.
But rest/spread doesn't.
+1 for selectively compiling features against different targets.
Would love to see something in tsconfig.json like:
{
	"compilerOptions": {
		"target": {
			"rest": "ES5",
			"spread": "ES5",
			"decorators": "ES5",
			"*": "ES6"
		}
	}
}

yes @leebenson  I came reading for this. selectively targeting some features would let typescript fallback to transpiling to es5. I think there would be not so much work to do more than just adding it to tsconfig and making few more changes for typescript. then we can use more ES6 features and without another build step with babel. and also having typescript sourcemaps directly while debugging nodejs code.
+1 for
{
    "compilerOptions": {
        "target": {
            "rest": "ES5",
            "spread": "ES5",
            "decorators": "ES5",
            "*": "ES6"
        }
    }
}

because not all es6 features are supported I have to compile down to es5 from es6 using babel =( btw is it possible to compile from es6 to es5 using latest typescript features?

@PLEEROCK if you want to bypass babel an you are uisng nodejs. you can just set target es6 and enable nodejs native features with harmony flags for example to enable destructring you will pass this flag like this node --harmony_destructuring server.js

@afaayerhan with Node 5.*, most of that stuff is enabled by default. You can use my babel preset for anything that's missing from the ES6 spec - then you just run with babel-node instead of node, and you're good to go.

thanks @leebenson I have used such in react with typescript but have not tried it with node js. do typescript source maps work with debugging in nodejs when using your babel presets?


[🚀esl-tab]: activate on esl:show:request event

As an ESL Tab consumer, I want esl-tab to be activated on the esl:show:request event.

Relates to #972
Also note, that currently is not reproducible for ESL w/o owerrides


Format codes based on .editorconfig, Part 2

Continued from #2865

I'm OK with it if others are.

I'm not fond of bulk changes without demonstrable need that outweighs risks of something getting out of whack. My vote is against it but if Bill votes for it I'm OK with being outvoted.

I looked through all the changes and they look benign to me. I say we merge it.

I consider myself outvoted, merge away 😄