Widgets which do not return a promise should be composed prior to DOM attach, just like partial views

Currently, making heavy use of widgets can cause a large drag on performance (as well as unpleasant 'jitteryness' during loading) because it seems all widgets are loaded and inserted into the DOM after their parent element has already been attached.
In other words, let's say you have an edit form which makes use of many widgets for encapsulated edit capability.  When this form loads, you can actually see each widget 'pop into view' one-by-one.   For a broader description, see this stack overflow question:  http://stackoverflow.com/questions/21566358/durandal-using-many-widgets-causes-ui-to-load-jittery
It would be desirable if widgets which don't return a promise would be composed as part of the composition of their parent element (in other words, just like partial views) rather than after dom insertion.  (Please pardon if I'm miss-understanding the mechanics at work here)

I am also experiencing this problem in a fairly noticeable way with Durandal 2.1 so it's unfortunately this issue was closed. This problem really kills performance and makes widgets not usable for the types of scenarios they are intended for.
Have there been any changes in Knockout (now that it supports Custom Elements - http://knockoutjs.com/documentation/component-overview.html) that would enable this performance enhancement?
Would using Knockout Custom Elements provide better performance? Is the only disadvantage with using KO custom elements that that wouldn't understand the Durandal lifecycle events?
Thanks

@rwhepburn I haven't used Knockout components with Durandal, but we're using them fairly heavily otherwise. I don't think that there's an issue using them with Durandal. Make sure to use a build step to preload all components and use the synchrnous: true  flag http://knockoutjs.com/documentation/component-registration.html#controlling-synchronousasynchronous-loading. Otherwise you'll be hit by the same performance issue. There was a lengthy  discussion at https://github.com/knockout/knockout/pull/1504 that let to the introduction of the synchronous flag in ko3.3.
In terms of Durandal events, you're right those won't be available to you any longer. OOTB components only support a dispose event, which expects a dispose method on your viewModel http://knockoutjs.com/documentation/component-binding.html#disposal-and-memory-management.
A kind of attached can be accomplished using an bindingHandler https://github.com/knockout/knockout/pull/1504#issuecomment-54591212. This one only provides access to the DOM fragment after it's inserted, but before knockout has further processed it.
HTH

Thanks very much Rainer, that helps!:)
It looks like I have a little prototyping to do to understand how to best approach this performance issue. I know the Durandal team is hard at work on Aurelia, but it would be nice to have the Durandal docs updated to explain some of these new KnockoutJS options and and best practices around widget and KO component / custom element use.


Update Yoga.podspec: fixes archiving for macos catalyst on react-native 0.73.1 in xcode

Hi
Summary:
When I tried to archive macos catalyst app in Xcode I got error:

This PR fixes archiving
Changelog:
[IOS] [FIXED] - fixed archiving for macos catalyst on react-native 0.73.1 in xcode
Test Plan:
Try archive react-native tester app for macos catalyst in Xcode

@kesha-antonov we will have to revert this PR because it isn't the right fix.
The right way to handle Catalyst builds is to use the PUBLIC_HEADERS_FOLDER_PATH option, as we are doing here

@kesha-antonov we will have to revert this PR because it isn't the right fix. The right way to handle Catalyst builds is to use the PUBLIC_HEADERS_FOLDER_PATH option, as we are doing here

What do you need to pass to PUBLIC_HEADERS_FOLDER_PATH?
I've tried and it doesn't work

"PUBLIC_HEADERS_FOLDER_PATH" => "#{module_name}.framework/Headers/#{header_dir}"

"PUBLIC_HEADERS_FOLDER_PATH" => '${REACT_NATIVE_PATH}/ReactCommon/yoga'

"PUBLIC_HEADERS_FOLDER_PATH" => '${PODS_ROOT}/../../node_modules/react-native/ReactCommon/yoga'

The missing file that we see in the error is located here
react-native/ReactCommon/yoga/yoga/debug/Log.h

So I tried to use PUBLIC_HEADERS_FOLDER_PATH and it seems like it doesn't fix the issue.
What fixes is original solution to add HEADER_SEARCH_PATHS
But better solution to use "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)\""

@kesha-antonov we will have to revert this PR because it isn't the right fix. The right way to handle Catalyst builds is to use the PUBLIC_HEADERS_FOLDER_PATH option, as we are doing here

Moreover, we have PUBLIC_HEADERS_FOLDER_PATH flag set by default in XCode
So I don't think it changes anything when we set it in podspec
Here's screenshot from xcode with default Yoga.podspec file without changes

I check main branch. Apparently I made fix for 0.73.1 but commited in 0.74

Question is what to set in header_search_paths ?


import umd module is undefined except file in node_modules

Version
3.0.1
Reproduction link
https://github.com/yangblink/vue-cli-umd-test
Node and OS info
Node v9.3.0 / npm 6.0.1/ macOS 10.13.1
Steps to reproduce
use vue-cli create a default project, and import a simple umd module umd.js,
umd.js
/* eslint-disable */
(function webpackUniversalModuleDefinition(root, factory) {
  if(typeof exports === 'object' && typeof module === 'object')
    module.exports = factory();
  else if(typeof define === 'function' && define.amd)
    define("bxs", [], factory);
  else if(typeof exports === 'object')
    exports["bxs"] = factory();
  else
    root["bxs"] = factory();
})(window, function() {
  return 'umd';
});

when the file in /node_modules it's work fine,
copy it to other folder except /node_modules, it's undefined
import localumd from './umd.js'
import moduleumd from '../node_modules/umd.copy.js'
console.log(localumd);  // undefined
console.log(moduleumd); // umd

What is expected?
umd module can be recognize in any floder
What is actually happening?
umd module can be recognize only in path /node_modules

It's because of the helpers config of @@babel/plugin-transform-runtime  in @vue/app
plugins: [
  [
    '@babel/plugin-transform-runtime', { helpers: ture }
  ]
]

helpers: true will inject  some top at the top like follow

webpack will parse it as Harmony

Is this problem solved? How to solve it?

@yangblink  i have the same problem in my project , can you help me to solve the problem .

@yangblink i have the same problem in my project , can you help me to solve the problem .

replace babel.config.js  below
module.exports = {
  presets: [
    '@vue/app'
  ],
  ignore: [ './src/umd.js' ]
}

just ignore the umd module file

This error wont occur if you set useBuiltIns to 'entry' in your babel config. That is what determines if helpers @yangblink mentioned are included.
Does anyone have a better solution than that?

vue cli default import umd which not in node_module will occur some error. Maybe it should add some tip for user ?


burst images not included when used with --uuid or --selected

osxphotos v0.46.1
macOS 10.15.7
If user selects a burst image in Photos then exports with --selected or they use the UUID of photo with --uuid, the associated burst images are not exported.  This is working as designed so I'm not sure if I consider this a bug or "as designed behavior" but it can be unexpected.  The burst images are with the call to PhotosDB.query() but filtered out by the UUID filter.  Need to figure out if burst images should be included in this case or if maybe a --include-bursts option is needed to explicitly activate this behavior when filtering by UUID.

On further thought, I think that the associated burst images should always be exported unless --skip-bursts is specified as this is how burst images work in all other cases.

This seems to have regressed


Getting started page - mistakes

API Activation:
For open-source license, your can request one from the setup wizard directly

Its worth to create printscreen and highlight where the issue located, like this

Solved this issue

Closed this issue #19

Fixes #19


build recommend api

1 build supplier recommend api, the endpoint is /suppliers/{product_id}/recommend

Codecov Report

Merging #103 (8a562ad) into master (b2be76a) will decrease coverage by 1.73%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   96.54%   94.80%   -1.74%
==========================================
  Files           2        2
  Lines         318      327       +9
==========================================
+ Hits          307      310       +3
- Misses         11       17       +6

Impacted Files
Coverage Δ

service/service.py
94.53% <40.00%> (-3.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2be76a...8a562ad. Read the comment docs.


Unable to download system files

what shall i do? after i compiled i done everything correctly, making sure from the requests but the app isn't downloading the file systems, i saw the image in releases and i think this maybe useful like it's maybe the obb or something , so where i put it after downloading?

ok nvm lol i found it thx anyways for that cool fork ♥ .


Update ios-device-enrollment-program-for-hybrid.md

Approved in CSS content triage - Content Idea Request 78991: Under "Assign DEP Devices for management": Add this note beneath step 4: "After a DEP profile is assigned to a device, you can replace the profile only with another DEP profile. However, you cannot remove the DEP profile assignment. To remove a DEP profile from a device, you must unenroll the device."

@przlplx thanks for directly submitting the edit! Looks good


Ability to disable the auto-linting fixes

The auto-linting changes in 1.7.0 are awesome, but I'd like to have them toggleable in certain cases where I'm performing specific tasks.
For example I may have open tabs for unrelated files, or a notes file that has linting errors since vscode erroneously detected the wrong autoformat.
Of course I can (and have) asked Claude to skip via Ignore any linting errors or warnings provided by VSCode Workspace Diagnostics and it works, but it still takes up tokens in the request.

Hey thanks for taking the time to make the issue. I just released v1.7.3 that now only uses workspace errors (and not warnings since this may be too distracting in large projects). I've also added the following instructions to the system prompt:

You will automatically receive workspace error diagnostics in environment_details. Be mindful that this may include issues beyond the scope of your task or the user's request. Focus on addressing errors and warnings relevant to your work, and avoid fixing pre-existing or unrelated issues unless the user specifically instructs you to do so.
If you are unable to resolve errors provided in environment_details after a few attempts, consider using ask_followup_question to ask the user for additional information, such as the latest documentation related to a problematic framework, to help you make progress on the task.

Please give the new update a go and let me know how it works for you.

@bradam12 Please see this comment: https://github.com/saoudrizwan/claude-dev/issues/319#issuecomment-2356375137


be explicit about supported RN versions

motivation: readme contains information about supported versions and it should be more explicit because:

Currently is says "React Native versions 0.44 and above are supported." and the readme wasn't updated in 5 months, so it certainly wasn't correct in the time when 0.50 wasn't working on android.
It also isn't "future-proof" because whenever a new RN version is released, the sentence automatically makes user think the new version is supported which may not be true

For people like me who occasionally come to the repo to check if their RN version is supported, this will be a big help that will save time digging through issues.
I based the table contents on this comment, not sure what the supported versions really are.

Might be related to https://github.com/wix/detox/issues/774

Instead of using RN as a point of reference, let's use platform as point of reference.
Documentation is still missing data on what APIs exist on iOS and what APIs exist on Android. I intend to create such a list in the near future, and I want yours to align with it.

iOS
Android

>=0.55
<=0.51

thanks for the comment @rotemmiz, you table structure makes much more sense. I have changed the PR in accordance to it., I just switched the inequality sign in the iOS column because I believe it should be <=0.55 (?).
If there are some more tricks in the supported versions, we can further break the table by also including detox version column on the left.

@markhu @rotemmiz @vonovak  I have "detox": "^7.4.0" running with "react-native": "0.55.4" on android
I will test with "detox": "^8.0.0" and update you.

@markhu @rotemmiz @vonovak
I updated to 8.0.0 but I get an error:
 11: running "/Work/sdks/android-sdk-macosx/platform-tools/adb -s <IP_ADDRESS>:5555 shell ps -AMo NAME,PID" returned undefined

It doesn't seem to be related to the ReactNative version though.

This is unrelated to this PR.
Please open a new issue with full logs for that.
Moreover, add your ADB version, emulator version and device API level.


Merge to commit before monorepo change, reimplemented

Please select one of the following

[x] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[ ] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary
This is a reimplementation of #1795. It merges up to 1c1dfab, one commit before the mono repo commit.
Changelog
[GENERAL] [ADDED] - Merge to commit before monorepo change
Test Plan
The notable items in #1795 have been gone through carefully, and things still work.

setColorScheme works fine on macOS Paper, but it appears to be wonky on macOS Fabric. However, considering that macOS Fabric is still highly experimental, I think this is okay for now.
The new RNTLegacyView test page works on both macOS and iOS Fabric.

From the Old PR I had, I see I wrote
"Flatlist moved to it's own package"
I think we'll need to publish a "@react-native-macos/flatlist" package because we have diffs in there, so we don't want to accidentally use the core one. I think I didn't do anything for that in my old PR. Did you do anything to that regard?

From the Old PR I had, I see I wrote "Flatlist moved to it's own package"
I think we'll need to publish a "@react-native-macos/flatlist" package because we have diffs in there, so we don't want to accidentally use the core one. I think I didn't do anything for that in my old PR. Did you do anything to that regard?

No I didn't. I'll take a closer look at these diffs.

Looks like the RNTA pipeline isn't testing against newly published packages. -- It should do something similar to the init pipeline, where it starts a verdaccio server, publishes the new bits to that, then runs RNTA against that server to verify the bits in the PR, rather than the bits on NPM.

After experimenting with the Integration pipeline for a few days, it's clear that this fix will be rather involved with react-native-macos becoming more like a monorepo. Since @tido64 should know more about react-native-test-app than I do, I think he would be a valuable resource.
For now, we can probably press forward with this anyway. We already test our ability to use this in apps with react-native-macos-init and RNTester, so that validation may be enough.

I'd be happy to help when you think the repo is in a better state. Just an FYI, you probably want to bump the minor version and not point at a local .tgz file here:
https://github.com/microsoft/react-native-macos/blob/ebf12739065db35cb4d818a35370c8f119fc60d5/.ado/apple-integration.yml#L53-L54
https://github.com/microsoft/react-native-macos/blob/ebf12739065db35cb4d818a35370c8f119fc60d5/.ado/apple-integration.yml#L70-L71


Update integration tests

What does this PR do?
Fix a couple issues in the integration tests.
Motivation

Testing Guidelines

Additional Notes

Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

[ ] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

Codecov Report

Merging #65 (f4a04a9) into main (325e52e) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   80.72%   80.39%   -0.33%
==========================================
  Files          12       12
  Lines         607      607
==========================================
- Hits          490      488       -2
- Misses         94       96       +2
  Partials       23       23

Impacted Files
Coverage Δ

internal/metrics/processor.go
93.75% <0.00%> (-3.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325e52e...f4a04a9. Read the comment docs.


make registration-block alert texts i18n compatible

Is your feature request related to a problem? Please describe
registration-block alert texts are not currently i18n compatible

Describe the solution you'd like
We need to translate registration block alert texts into all available languages
ref PR - https://github.com/CircuitVerse/CircuitVerse/pull/4124
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
No

Can I work on this?

@Malavi1 sure

Hey @niladrix719 I am understanding the issue in different ways could you please reframe the issue again what are you supposed to change in that way I will understand IG!!

"Sign up is Currently disabled" this text is not being translated to all languages, which was a follow up issue for this: https://github.com/CircuitVerse/CircuitVerse/pull/4257#discussion_r1393805118


feat: support junit output for unit/e2e tests

What this PR does / why we need it: Title says, it does.

JIRA ID: [DTSS-0]

Notes for your reviewer:

:tada: This PR is included in version 1.19.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Rate Limit example does not work

Describe the bug
The basic rate limiting example does not work with emissary 3.9.1
https://www.getambassador.io/docs/emissary/latest/topics/using/rate-limits
To Reproduce
Steps to reproduce the behavior:

Install emissary 3.9.1 via https://www.getambassador.io/docs/emissary/latest/tutorials/getting-started
Install quote service
Install rate limit example
Update quote service mapping with rate limit labels: https://github.com/emissary-ingress/ratelimit-example/blob/main/k8s/quote-mapping-ratelimited.yaml ( api version has to be changed to v2)

Expected behavior
The rate limit example should install and work according to documentation
Versions (please complete the following information):

emissary-ingress 3.9.1
kind 1.25.3
docker.io/emissaryingress/ratelimit-example:v3
docker.io/datawire/quote:0.5.0

Additional context
emissary-ingress shows this error after updating the quote Mappings

[2024-02-28 14:32:19.397][57][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.route.v3.HeaderMatcher Using deprecated option 'envoy.config.route.v3.HeaderMatcher.exact_match' from file route_components.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.
[2024-02-28 14:32:19.397][57][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.route.v3.HeaderMatcher Using deprecated option 'envoy.config.route.v3.HeaderMatcher.exact_match' from file route_components.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.
[2024-02-28 14:32:19.397][57][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.route.v3.HeaderMatcher Using deprecated option 'envoy.config.route.v3.HeaderMatcher.exact_match' from file route_components.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.
[2024-02-28 14:32:19.398][57][critical][main] [source/server/config_validation/server.cc:67] error initializing configuration '/ambassador/snapshots/econf-tmp.json': Proto constraint validation failed (HttpConnectionManagerValidationError.RouteConfig: embedded message failed validation | caused by RouteConfigurationValidationError.VirtualHosts[0]: embedded message failed validation | caused by VirtualHostValidationError.Routes[4]: embedded message failed validation | caused by RouteValidationError.Route: embedded message failed validation | caused by RouteActionValidationError.RateLimits[0]: embedded message failed validation | caused by RateLimitValidationError.Actions[0]: embedded message failed validation | caused by ActionValidationError.RequestHeaders: embedded message failed validation | caused by RequestHeadersValidationError.HeaderName: value length must be at least 1 characters): stat_prefix: "ingress_http"
route_config {
  virtual_hosts {
    name: "emissary-ingress-listener-8080-*"
    domains: "*"
    routes {
      match {
        prefix: "/ambassador/v0/check_ready"
        case_sensitive {
          value: true
        }
        headers {
          name: "x-forwarded-proto"
          exact_match: "https"
        }
        runtime_fraction {
          default_value {
            numerator: 100
          }
          runtime_key: "routing.traffic_shift.cluster_127_0_0_1_8877_emissary"
        }
      }
      route {
        cluster: "cluster_127_0_0_1_8877_emissary"
        prefix_rewrite: "/ambassador/v0/check_ready"
        timeout {
          seconds: 10
        }
      }
    }
    routes {
      match {
        prefix: "/ambassador/v0/check_ready"
        case_sensitive {
          value: true
        }
        runtime_fraction {
          default_value {
            numerator: 100
          }
          runtime_key: "routing.traffic_shift.cluster_127_0_0_1_8877_emissary"
        }
      }
      route {
        cluster: "cluster_127_0_0_1_8877_emissary"
        prefix_rewrite: "/ambassador/v0/check_ready"
        timeout {
          seconds: 10
        }
      }
    }
    routes {
      match {
        prefix: "/ambassador/v0/check_alive"
        case_sensitive {
          value: true
        }
        headers {
          name: "x-forwarded-proto"
          exact_match: "https"
        }
        runtime_fraction {
          default_value {
            numerator: 100
          }
          runtime_key: "routing.traffic_shift.cluster_127_0_0_1_8877_emissary"
        }
      }
      route {
        cluster: "cluster_127_0_0_1_8877_emissary"
        prefix_rewrite: "/ambassador/v0/check_alive"
        timeout {
          seconds: 10
        }
      }
    }
    routes {
      match {
        prefix: "/ambassador/v0/check_alive"
        case_sensitive {
          value: true
        }
        runtime_fraction {
          default_value {
            numerator: 100
          }
          runtime_key: "routing.traffic_shift.cluster_127_0_0_1_8877_emissary"
        }
      }
      route {
        cluster: "cluster_127_0_0_1_8877_emissary"
        prefix_rewrite: "/ambassador/v0/check_alive"
        timeout {
          seconds: 10
        }
      }
    }
    routes {
      match {
        prefix: "/backend/"
        case_sensitive {
          value: true
        }
        headers {
          name: "x-forwarded-proto"
          exact_match: "https"
        }
        runtime_fraction {
          default_value {
            numerator: 100
          }
          runtime_key: "routing.traffic_shift.cluster_quote_default_default"
        }
      }
      route {
        cluster: "cluster_quote_default_default"
        prefix_rewrite: "/"
        timeout {
          seconds: 3
        }
        rate_limits {
          stage {
          }
          actions {
            request_headers {
              descriptor_key: "x-emissary-test-allow"
            }
          }
        }
      }
    }
    routes {
      match {
        prefix: "/backend/"
        case_sensitive {
          value: true
        }
        runtime_fraction {
          default_value {
            numerator: 100
          }
          runtime_key: "routing.traffic_shift.cluster_quote_default_default"
        }
      }
      route {
        cluster: "cluster_quote_default_default"
        prefix_rewrite: "/"
        timeout {
          seconds: 3
        }
        rate_limits {
          stage {
          }
          actions {
            request_headers {
              descriptor_key: "x-emissary-test-allow"
            }
          }
        }
      }
    }
  }
}
http_filters {
  name: "envoy.filters.http.cors"
}
http_filters {
  name: "envoy.filters.http.ratelimit"
  typed_config {
    [type.googleapis.com/envoy.extensions.filters.http.ratelimit.v3.RateLimit] {
      domain: "emissary"
      request_type: "both"
      timeout {
        nanos: 20000000
      }
      failure_mode_deny: true
      rate_limit_service {
        grpc_service {
          envoy_grpc {
            cluster_name: "cluster_ratelimit_example_default_5000_default"
          }
        }
        transport_api_version: V3
      }
    }
  }
}
http_filters {
  name: "envoy.filters.http.router"
}
http_protocol_options {
}
server_name: "envoy"
access_log {
  name: "envoy.access_loggers.file"
  typed_config {
    [type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog] {
      path: "/dev/fd/1"
      log_format {
        text_format_source {
          inline_string: "ACCESS [%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%\" %RESPONSE_CODE% %RESPONSE_FLAGS% %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\"\n"
        }
      }
    }
  }
}
use_remote_address {
  value: true
}
normalize_path {
  value: true
}

(exit code 1)
Aborting update...
2024-02-28 14:32:19 diagd 3.9.1 [P23TAEW] INFO: no update performed (invalid envoy configuration generated), continuing with current configuration...
time="2024-02-28 14:32:19.4013" level=info msg="error notifying diagd: 500 INTERNAL SERVER ERROR, ignoring (invalid envoy configuration generated) in snapshot snapshot" func=github.com/emissary-ingress/emissary/v3/cmd/entrypoint.notifyWebhookUrl file="/go/cmd/entrypoint/notify.go:141" CMD=entrypoint PID=1 THREAD=/watcher/notifyCh

``

Hi!  It works for me, but I implemented the rate limit with the external rate limit service. If you are interested, I can share to you the step-by-step guide.

I had installed the example external rate limit service: https://github.com/emissary-ingress/ratelimit-example
The problem I saw was errors in the Envoy logs when it tried to reconfigure after applying rate limiting. It looked the config was bad not that it couldn't reach the rate limit service.

I used the service https://github.com/envoyproxy/ratelimit
The config for it looked like something:
---
domain: emissary
descriptors:
  - key: remote_address
    rate_limit:
      unit: second
      requests_per_unit: 1000
    shadow_mode: false
    descriptors:
      - key: generic_key
        value: api_3
        rate_limit:
          unit: second
          requests_per_unit: 30
        shadow_mode: false
      - key: generic_key
        value: api_3_order
        rate_limit:
          unit: second
          requests_per_unit: 100
        shadow_mode: false
      - key: generic_key
        value: api_v4
        rate_limit:
          unit: second
          requests_per_unit: 200
        shadow_mode: false

  - key: remote_address
    value: <IP_ADDRESS>
    rate_limit:
      unit: second
      requests_per_unit: 0
    shadow_mode: true

  - key: remote_address
    value: <IP_ADDRESS>
    rate_limit:
      unit: second
      requests_per_unit: 0
    shadow_mode: true

  - key: test
    value: vasya
    rate_limit:
      unit: second
      requests_per_unit: 1
    shadow_mode: true

and finally my mapping looked like:
apiVersion: getambassador.io/v3alpha1
kind: Mapping
metadata:
  name: **********
  namespace: **********
spec:
  ambassador_id: [ "public" ]
  hostname: ***********
  prefix: /api/v4
  rewrite: ""
  add_request_headers:
    Site-Enum:
      value: *********
      append: False
  service: api-v4.zodia:8484
  labels:
    emissary:
      - request_label_group:
          - request_headers:
              header_name: "CF-Connecting-IP"
              key: remote_address
          - generic_key:
              key: endpoint
              value: api_v4

no errors at all

I used the service https://github.com/envoyproxy/ratelimit
The config for it looked like something:
---
domain: emissary
descriptors:
  - key: remote_address
    rate_limit:
      unit: second
      requests_per_unit: 1000
    shadow_mode: false
    descriptors:
      - key: generic_key
        value: api_3
        rate_limit:
          unit: second
          requests_per_unit: 30
        shadow_mode: false
      - key: generic_key
        value: api_3_order
        rate_limit:
          unit: second
          requests_per_unit: 100
        shadow_mode: false
      - key: generic_key
        value: api_v4
        rate_limit:
          unit: second
          requests_per_unit: 200
        shadow_mode: false

  - key: remote_address
    value: <IP_ADDRESS>
    rate_limit:
      unit: second
      requests_per_unit: 0
    shadow_mode: true

  - key: remote_address
    value: <IP_ADDRESS>
    rate_limit:
      unit: second
      requests_per_unit: 0
    shadow_mode: true

  - key: test
    value: vasya
    rate_limit:
      unit: second
      requests_per_unit: 1
    shadow_mode: true

and finally my mapping looked like:
apiVersion: getambassador.io/v3alpha1
kind: Mapping
metadata:
  name: **********
  namespace: **********
spec:
  ambassador_id: [ "public" ]
  hostname: ***********
  prefix: /api/v4
  rewrite: ""
  add_request_headers:
    Site-Enum:
      value: *********
      append: False
  service: **********
  labels:
    emissary:
      - request_label_group:
          - request_headers:
              header_name: "CF-Connecting-IP"
              key: remote_address
          - generic_key:
              key: endpoint
              value: api_v4

no errors at all

I tried using version https://github.com/envoyproxy/ratelimit/releases/tag/v1.4.0 seems like it is not working
the error i got is
rate limit fail, status=12 msg=unknown service envoy.service.ratelimit.v3.RateLimitService

Probably need to test master version

It turn out for me the name of TracingService cannot be emissary-ingress.
It work out fine when i set the name to emissary-ingress-tracing
RateLimitService can work when i set the name to emissary-ingress


Convert AirlineCodeLookUp to OpenAPI 3.0 spec

This PR converts spec/yaml/AirlineCodeLookUp_v1_swagger_specification.yaml from the Swagger 2.0 spec to OpenAPI 3.0. This change was done by:

converting the file automatically on https://editor.swagger.io/
reformatting Markdown tables, since the auto converter butchers them
refactored some of the duplicated fields between component/schemas and component/responses introduced by Swagger's converter.

I then validated spec files with jbang OASValidator.java oasv-1a4dev-config.properties spec and asserted that everything is correct in the web UI.
If this is something the repo maintainers would like done for other files still using the Swagger 2.0 specification, please let me know.

Converting to a draft as I determine whether removing Error_400 and Error_500 components would break existing generated client code.

@tsolakoua liar!
Jk, but I do want to rename UriType to just Uri when Im on my computer

Hello @jordan-gillard ,
Thanks a lot for your help in migrating the API documentation.
I noticed one issue with 200 response example. Data is an array in the model but an object in the example.
Can you also explain to me the benefits of the uriType? It looks to add complexity in the documentation just for strings and this is the main change from the previous version.
Thanks in advance

@gimperial

I noticed one issue with 200 response example. Data is an array in the model but an object in the example.

My bad! Fixed here 3daa9ac

Can you also explain to me the benefits of the uriType? It looks to add complexity in the documentation just for strings and this is the main change from the previous version.

I reverted this change here: dabe43e
My reasoning was that it seemed redundant to specify the same type/format/example repeatedly for each property. But I agree it's nitpicky and really a matter of taste.

Code comparison
          properties:
            self:
-             type: string
-             format: uri
-             example: https://test.api.amadeus.com/v1/area/resources?...
+             $ref: '#/components/schemas/Uri'
            next:
-             type: string
-             format: uri
-             example: https://test.api.amadeus.com/v1/area/resources?...
+             $ref: '#/components/schemas/Uri'
            previous:
-             type: string
-             format: uri
-             example: https://test.api.amadeus.com/v1/area/resources?...
+             $ref: '#/components/schemas/Uri'
            last:
-             type: string
-             format: uri
-             example: https://test.api.amadeus.com/v1/area/resources?...
+             $ref: '#/components/schemas/Uri'
            first:
-             type: string
-             format: uri
-             example: https://test.api.amadeus.com/v1/area/resources?...
+             $ref: '#/components/schemas/Uri'
            up:
-             type: string
-             format: uri
-             example: https://test.api.amadeus.com/v1/area/resources?...
+             $ref: '#/components/schemas/Uri'

Not really related, but one thing I notice is that Collection_Meta is identical across 14 files. Collection_Meta (and some other types) can be written once and shared between schema files once each schema is OpenAPI 3.0 compliant.

Thanks @jordan-gillard for your updates.
The PR is all good for me.
Regarding your point about Collection_Meta, I totally agree. We have a lot more object that should be common along most of our API but that's not reflecting well, like Error, Warning, ... . We will work on improving over time while migrating to OAS3.
Thanks again for your contribution.


Add link to Media Session article

@samdutton Now that the Media Session article is up, I thought we should link it from your existing article at https://developers.google.com/web/updates/2015/07/media-notifications
WDYT?
FYI @mounirlamouri

Thank you! LGTM apart from one tiny suggestion.

@samdutton Fixed!

👍
On 9 February 2017 at 10:58, François Beaufort<EMAIL_ADDRESS>wrote:

@samdutton https://github.com/samdutton Fixed!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/WebFundamentals/pull/4165#issuecomment-278610145,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMhqvPSDeo3eJOdKMbS7B4DzSo2tC_sks5ravFMgaJpZM4L70Ez
.


Connected but no DNS resolving?

Dear guys,
first of all I would like to thank you for putting your efforts in this project. I'm aware that it's kinda discontinued but I'm very interested in it.
In the past as I successfully ran wireguard on my OpenWrt router and I would like to do the same on my NAS.
My configurations files are quite simple and I don't really get why is keeping the client from connecting to the wider internet (ping to local IPs works) :
[wg0.conf]
[Interface]
Address = <IP_ADDRESS>/16
PrivateKey = (hidden)
ListenPort = (hidden)
PostUp = iptables -A FORWARD -i %i -j ACCEPT; iptables -t nat -A POSTROUTING -o eth1 -j MASQUERADE
PostDown = iptables -D FORWARD -i %i -j ACCEPT; iptables -t nat -D POSTROUTING -o eth1 -j MASQUERADE

[Peer]
PublicKey = (hidden)
PresharedKey = (hidden)
AllowedIPs = <IP_ADDRESS>/32`

PEER 1
[Interface]
PrivateKey = <PKEY>
Address = <IP_ADDRESS>/24
DNS = <IP_ADDRESS>

[Peer]
PublicKey = <PUBKEY>
PresharedKey = <PSKEY>
AllowedIPs = <IP_ADDRESS>/0, ::/0
Endpoint = <LOCAL_IP>:<PORT>
PersistentKeepalive = 25

![image](https://user-images.githubusercontent.com/11884948/70932229-e4189200-2041-11ea-9698-81c4842cbb9c.png)

root@DNS-NAS:/etc/wireguard# wg
interface: wg0
  public key: <PUBKEY>
  private key: (hidden)
  listening port: <PORT>

peer: <HIDDEN>
  preshared key: (hidden)
  endpoint: <IP_ADDRESS>:62341
  allowed ips: <IP_ADDRESS>/32
  latest handshake: 4 seconds ago
  transfer: 1.74 KiB received, 1.43 KiB sent

Any suggestions?
My idea is that DNS queries are currently not being resolved.
Thanks!

can you test DNS lookups with dig or nslookup?

ping to local IPs work
looks like you are connecting to the server from the same network. are you sure the pings are going through wireguard?

yes, I'm connecting from the same network.
Since there's no connection the nslookup fails
user@mac ~ % nslookup google.com
;; connection timed out; no servers could be reached

you are right :/ I'm unable to ping any ip when I'm connected from WAN

I've just tried to set this up on my DS1019+ and am having a very similar issue. Testing from my iPhone on 4G I have no access at all (as above, on my local wifi/LAN I have internal but not internet connection):
[wg0.conf]
Address = <IP_ADDRESS>/16
PrivateKey = <privKey>
ListenPort = <listenPort>
PostUp = iptables -A FORWARD -i %i -j ACCEPT; iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE; sleep 5; ip route add <IP_ADDRESS>/16 dev wg0
PostDown = iptables -D FORWARD -i %i -j ACCEPT; iptables -t nat -D POSTROUTING -o eth0 -j MASQUERADE

# iPhone
[Peer]
PublicKey = <pubKey>
AllowedIPs = <IP_ADDRESS>/32```

[wg0-iPhone.conf]
'''[Interface]
Address = <IP_ADDRESS>/24
PrivateKey = <privKey>
ListenPort = <listenport>

[Peer]
Endpoint = <router public IP>:<listenport>
PublicKey = <pubKey>
AllowedIPs = <IP_ADDRESS>/0, ::/0
PersistentKeepalive = 25'''

Tested using Chrome to try and access www.bbc.co.uk and getting ERR_NAME_NOT_RESOLVED .

Set-up was done based on [this guide](https://www.ckn.io/blog/2017/11/14/wireguard-vpn-typical-setup/) (well parts of it anyway) and also [this one](https://dietpi.com/phpbb/viewtopic.php?p=16308#p16308) as I have a server running on a Pi which works fine (but I want to move it to my NAS). When I compare the conf files between the two I can't see anything significantly different except of course I've set different listen ports.

The NAS firewall is up, but I've tried both adding a port allow to it and temporarily dropping it, and neither helps. My router is also set to port forward the listen port to the NAS as well.

Any thoughts as to what may be wrong welcomed.

I suspect this issue has to do with "The Dns = x.x.x.x setting is unsupported." in the FAQ/Known issues section. I'm getting this issue on my Synology too. I had something similar with a Wireguard setup on my router, before I added the DNS setting to the conf file, which fixed things. Since that's not an option for this version, it's quite possible it might not work until the DNS=... gets implemented for the Synology version.

That was the conclusion I was coming to as well, and I presume not a simple fix given it's current status. Was just wondering given that it must be working at least in some fashion for some people?
Anyway no big issue, will continue with the Pi based solution for now and see how progress here goes (or maybe look at a docker solution). Fingers crossed for that!

I've added the my home router's IP (<IP_ADDRESS>) as DNS server in the client configuration. Nothing done on the synology side.
I can resolve DNS names for both my internal network as well as the public internet, just like being in the local network.
[Interface]
Address = <IP_ADDRESS>
PrivateKey = <privkey>
ListenPort = <listenPort>
Dns = <IP_ADDRESS>

[Peer]
PublicKey = <publicKey>
Endpoint = <router public hostname>:<port>
AllowedIPs = <IP_ADDRESS>/0, ::/0

If that works for you, I can draft a PR to document this.

If AllowedIPs is configured globally, the Dns parameter must be specified. Otherwise, it will not affect the domain name resolution at the system level.

my VPN provider (WindScribe) has provided me a wg0.conf file which has a Dns entry in the [Interface] section and is not allowing me to instantiate the interface.
$ sudo wg-quick up wg0
Password:
Warning: `/etc/wireguard/wg0.conf' is world accessible
[#] ip link add wg0 type wireguard
[#] wg setconf wg0 /dev/fd/63
[#] ip -4 address add 100.x.x.x/32 dev wg0
[#] ip link set mtu 1420 up dev wg0
[#] resolvconf -a wg0 -m 0 -x
/usr/local/bin/wg-quick: line 32: resolvconf: command not found
[#] ip link delete dev wg0

I'm running this on a Synology NAS. How do I resolve this ?

@cchhat01
remove the Dns setting or use this solution;
https://github.com/runfalk/synology-wireguard/issues/31#issuecomment-593861167

my VPN provider (WindScribe) has provided me a wg0.conf file which has a Dns entry in the [Interface] section and is not allowing me to instantiate the interface.
$ sudo wg-quick up wg0
Password:
Warning: `/etc/wireguard/wg0.conf' is world accessible
[#] ip link add wg0 type wireguard
[#] wg setconf wg0 /dev/fd/63
[#] ip -4 address add 100.x.x.x/32 dev wg0
[#] ip link set mtu 1420 up dev wg0
[#] resolvconf -a wg0 -m 0 -x
/usr/local/bin/wg-quick: line 32: resolvconf: command not found
[#] ip link delete dev wg0

I'm running this on a Synology NAS. How do I resolve this ?

I'm running this on a Synology NAS also. How do I resolve this ?


there is no documentation for error 482 in minified error

i have issue when uploading nextjs and the server error is https://legacy.reactjs.org/docs/error-decoder.html/?invariant=482 but there is n documentation in the link

Make sure you aren't accidentally defining a client component as async

Make sure you aren't accidentally defining a client component as async

thanks mate you cure my head deck after 2 hours of debugging

Thanks 🙏

Fixed by manually re-deploying the legacy site, the longer term fix is here: https://github.com/reactjs/react.dev/pull/6214


npm run testonly fails

npm ERR! Darwin 15.2.0
npm ERR! argv "node" "/usr/local/bin/npm" "run" "testonly"
npm ERR! node v0.12.4
npm ERR! npm  v2.10.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>testonly: `mocha client/**/tests/**/*.js --compilers js:babel-core/register`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>testonly script 'mocha client/**/tests/**/*.js --compilers js:babel-core/register'.
npm ERR! This is most likely a problem with the mantra-demo package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     mocha client/**/tests/**/*.js --compilers js:babel-core/register
npm ERR! You can get their info via:
npm ERR!     npm owner ls mantra-demo
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/me/web-dev/Meteor/mantra-sample-blog-app/npm-debug.log

npm-debug.log below
0 info it worked if it ends with ok
1 verbose cli [ 'node', '/usr/local/bin/npm', 'run', 'testonly' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'pretestonly', 'testonly', 'posttestonly' ]
5 info pretestonly<EMAIL_ADDRESS>6 info testonly<EMAIL_ADDRESS>7 verbose unsafe-perm in lifecycle true
8 info<EMAIL_ADDRESS>Failed to exec testonly script
9 verbose stack Error<EMAIL_ADDRESS>testonly: `mocha client/**/tests/**/*.js --compilers js:babel-core/register`
9 verbose stack Exit status 2
9 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:213:16)
9 verbose stack     at EventEmitter.emit (events.js:110:17)
9 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:24:14)
9 verbose stack     at ChildProcess.emit (events.js:110:17)
9 verbose stack     at maybeClose (child_process.js:1015:16)
9 verbose stack     at Process.ChildProcess._handle.onexit (child_process.js:1087:5)
10 verbose pkgid<EMAIL_ADDRESS>11 verbose cwd /Users/me/web-dev/Meteor/mantra-sample-blog-app
12 error Darwin 15.2.0
13 error argv "node" "/usr/local/bin/npm" "run" "testonly"
14 error node v0.12.4
15 error npm  v2.10.1
16 error code ELIFECYCLE
17 error<EMAIL_ADDRESS>testonly: `mocha client/**/tests/**/*.js --compilers js:babel-core/register`
17 error Exit status 2
18 error Failed at the<EMAIL_ADDRESS>testonly script 'mocha client/**/tests/**/*.js --compilers js:babel-core/register'.
18 error This is most likely a problem with the mantra-demo package,
18 error not with npm itself.
18 error Tell the author that this fails on your system:
18 error     mocha client/**/tests/**/*.js --compilers js:babel-core/register
18 error You can get their info via:
18 error     npm owner ls mantra-demo
18 error There is likely additional logging output above.
19 verbose exit [ 1, true ]

I use node v0.12.4 and cannot recreate your bug.
Could you tell me your current commit id?

Could you try to remove the node_modules and run npm install again?

Hey that worked! Thanks!


[Improvment] Add a labeler github action to triage PRs

Is your feature request related to a problem? Please describe.
Using https://github.com/marketplace/actions/label-actions to triage PRs roughly to get reviewers' attention easier
Describe the solution you'd like

Add a label.yml related to our codebase, and an action to trigger this flow will be needed.
Labels shown above maybe easily tagged by robot.
Describe alternatives you've considered

Closing this issue because it was created before version 2.3.0 (2022-11-10). Please try the latest version of Flink CDC to see if the issue has been resolved. If the issue is still valid, kindly report it on Apache Jira under project Flink with component tag Flink CDC. Thank you!


No module named 'core.utils'/No module named 'core.yolov4'

I try to run the scripts, but got errors as below:

why the scripts cannot detect core.utils and core.yolov4, i have run the scripts under the parent folder

@wadewangpower Seem like an python path error. It is seem that you have pycharm installed, can you run the file with pycharm?  Usually PYTHON PATH and VARIABLES are screw in window, so i recommend that you do not deal with it and move to ubuntu.

@wadewangpower Seem like an python path error. It is seem that you have pycharm installed, can you run the file with pycharm? Usually PYTHON PATH and VARIABLES are screw in Window, so i recommend that you should use Ubuntu instead.

Now,  after i git pull the latest code and rerun the command line, everything is OK ! I found, yesterday the second command line's weights path might be wrong, its suffix is .tf instead of .weights, you can check it from my screenshot above. so i think the error maybe come from this ~

The output yolov4-int8.tflite is a little large, it is still not suitable to integrate in android app, hope the smaller but still precise tflite model can come up soon  ：）

Check if init.py file exists in core/ directory. Helped me run save_model.py from my Anaconda 3 Command Prompt on Windows.


Linux and CI proofing

I've tested this successfully with a rootless Podman in WSL2 😃
./mvnw verify -Prootless

Note that we should probably give up on running tests in a GitHub Action runner for the time being (it's all about running containers in containers in a virtual machine we don't own, etc)


add test coverage

TEST

make test-coverage-html it should open a tab in your browser with the test coverage.
ls in your project directory you will see coverage-all.out and coverage.out: run make clean, they should be gone

@shawn-hurley please verify this works on Mac

@shawn-hurley should be fixed now


openmpi: Permission Denied Error

Do you have an Idea of the error below?
/tmp/hudson3656222363984324720.sh: line 5: ./build.sh: Permission denied
Build step 'Execute shell' marked build as failure
[BFA] Scanning build for known causes...
[BFA] Found failure cause(s):
[BFA] permissions from category permissions,
[BFA] Done. 0s
Finished: FAILURE

Hey @smasoka for future reference, also please refer to the build number.

This was due to build.sh not being chmod u+x. Seems this has been fixed though.


Burp Extension Install Not Working

I followed the steps to install lightbulb into burp using the BApp Store.  When I send a request to lightbulb from Repeater tab and then select - Learning -> Tests -> Grammar -> query_sql and then right click the request and select Start Filter Learning - it only sends 2 in the campaign screen and then it just hangs.  It locks up Burp entirely and I have to force quit.
I am using the latest Burp Pro and running on Mac OSX Ventura 13.6.
In order to rule out OSX issues, I also tried the same using a Kali linux install.  I followed the same steps to install lightbulb-framework from the BApp store and same steps and again it hung on 2 requests.
Any ideas why this just hangs?

There is an issue with the TLS/SSL handshake. It can be verified on the output tab if you go at Burp Externsions -> Installed -> Select LightBulb WAF Auditing Framework -> Output

I am not trying to use a TLS/SSL connection - it is just to port 80.  Here is the output log text when I try to run the learning/grammar test -
runMessagesThread
processing new message
finish membership init
runMessagesThread
processing new message
finish membership init
error when making the request
(<type 'exceptions.TypeError'>, TypeError('cannot make memory view because object does not have the buffer interface',), <traceback object at 0x3>)
error when making the request
(<type 'exceptions.TypeError'>, TypeError('cannot make memory view because object does not have the buffer interface',), <traceback object at 0x4>)
query_sql
grammars/query_sql

Component query_sql Information:
S: A main
main: query_exp
query_exp: groupby_exp | order_exp | limit_exp | procedure_exp | into_exp | for_exp | lock_exp | ; select_exp | union_exp | join_exp
groupby_exp: GROUP BY column_ref ascdesc_exp
order_exp: ORDER BY column_ref ascdesc_exp
limit_exp: LIMIT intnum
into_exp: INTO output_exp intnum
procedure_exp: PROCEDURE name ( literal )
literal: string | intnum
select_exp: SELECT name
union_exp: UNION select_exp
ascdesc_exp: ASC | DESC
column_ref: name
join_exp: JOIN name ON name
for_exp: FOR UPDATE
lock_exp: LOCK IN SHARE MODE
output_exp: OUTFILE | DUMPFILE
string: name
intnum: 1
name: A

LearningMessagesThread
configuration OK
campaign OK
handlerconfig OK
foo
finish membership init
error when making the request
(<type 'exceptions.TypeError'>, TypeError('cannot make memory view because object does not have the buffer interface',), <traceback object at 0x5>)
error when making the request
(<type 'exceptions.TypeError'>, TypeError('cannot make memory view because object does not have the buffer interface',), <traceback object at 0x6>)
Perform membership request at input 5 -  True
start intersection
PDA States: 269
DFA States: 1
end intersection
* Reduce PDA using DFA BFS (remove unreachable states):
- Total PDA states after reduction are 271
Terminating Campaign
Campaign was Terminated

Was the output log data above helpful?


Fix reference counter error in socketNetworkClient

SocketNetworkClient would throw lots of IllegalReferenceCountException when any ambry-server dies. This is caused by a bug where I released the request twice. When a request is sent to server completed, it will be released by selector. And when it gets disconnected when it's waiting for response, it will be released again. This PR fixes that. It checks if the request is sentCompleted, if not, it will release the request when disconnected.

Codecov Report

Merging #1601 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1601      +/-   ##
============================================
- Coverage     73.72%   73.68%   -0.05%
- Complexity     8466     8467       +1
============================================
  Files           595      595
  Lines         46235    46235
  Branches       5873     5873
============================================
- Hits          34088    34067      -21
- Misses        10394    10409      +15
- Partials       1753     1759       +6

Impacted Files
Coverage Δ
Complexity Δ

.../com/github/ambry/network/SocketNetworkClient.java
93.78% <100.00%> (ø)
38.00 <0.00> (+1.00)

.../com/github/ambry/network/BlockingChannelInfo.java
80.95% <0.00%> (-3.18%)
16.00% <0.00%> (ø%)

...b/ambry/network/BlockingChannelConnectionPool.java
72.91% <0.00%> (-3.13%)
11.00% <0.00%> (-1.00%)

...java/com/github/ambry/store/CompactionManager.java
89.94% <0.00%> (-2.37%)
27.00% <0.00%> (ø%)

...va/com/github/ambry/replication/ReplicaThread.java
85.10% <0.00%> (-1.04%)
149.00% <0.00%> (-2.00%)

...m/github/ambry/replication/ReplicationMetrics.java
91.39% <0.00%> (-1.03%)
54.00% <0.00%> (-1.00%)

...ava/com/github/ambry/store/BlobStoreCompactor.java
89.83% <0.00%> (-0.29%)
120.00% <0.00%> (ø%)

...in/java/com/github/ambry/store/BlobStoreStats.java
69.08% <0.00%> (-0.21%)
99.00% <0.00%> (ø%)

...va/com/github/ambry/router/TtlUpdateOperation.java
91.33% <0.00%> (+0.66%)
51.00% <0.00%> (+1.00%)

...a/com/github/ambry/rest/NettyMessageProcessor.java
80.58% <0.00%> (+1.76%)
43.00% <0.00%> (+1.00%)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbce361...9bf7179. Read the comment docs.


feat: Enable proxy: BrainTree

Testing
GET
URL:
POST
URL:
Invalid requests
Pagination
###Page1
###Page2
Successful console operation (operation & events)
Failed console operation (operation & events)
Raw token response

MailMonkey returns "Provider not found"

@mohammedfuta2000 this doesn't look done, can you add screenshots?


Codify time an engineer is allowed to work on OSS

After our recent engineering all hands this question was asked and I would like to codify this into our guidelines so everyone is one the same page.

Previous version was:

Participation in open source projects is highly encouraged and part of every engineers job at Sauce Labs. While you are working with your team on a product backlog you should always ensure to take some time off and spend it to expand your capabilities and experiences working on an Open Source project of your choice. If your backlog doesn't allow this, please talk to your manager.

The Open Source Program Office wants to make this process as simple as possible. All Saucers are expected to follow common sense regarding the type of information and code is contributed to upstream open source projects. If you are in doubt, please reach out to the OSPO or ask your manager for direction.

I've rebased this onto dev--otherwise I think this can be merged.  @diemol ?


adding credentials vars for aws in terraform

Signed-off-by: RinkiyaKeDad<EMAIL_ADDRESS>This will allow us to pass the creds inline which we'll need to do in the prow job. On hold till we get the tests running so that local development is easier :)
/assign @jakexks
/hold

Closing since we don't need to pass the variables directly if we set them with the names mentioned in here - https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html


update ordercontroller, set data order by user login

update ordercontroller and menu product for kolom description product

fix the PHP stan first @miftahurrahmi


Wrap all math operations in parens

Previously if you used local variables or parens in Rust to override the
default order of operations, we would completely lose that information
in the generated SQL. This would at best result in an unexpected value,
but at worse would cause a query like now + 2.minutes() * (some_int + 1) to result in a runtime error complaining that there's no operator
for interval + integer
I intend to backport this to 1.4
Fixes #2017

Lgtm with ci fixed


Payment aggregator support

Guys,
is there any support for any payment aggregator? I've looked through the docs but didn't find anything helpful.
Sorry if it's described somewhere and I didn't see that.

@andr0s this will be the extremely late answer :) but yes - django-plans was initially written to be compatible with django-getpaid. But you can integrate any other payment aggregator via django signals API.


When is the Kronos "automatic refresh" triggered? Not mentioned.

The README says that Kronos attempts a "refresh" every minWaitTimeBetweenSyncMs. Is this "automatic refresh" process initiated by the first call to getCurrentTime() or when?

By the look of the code, whenever you call getCurrentTime(), if the last update is out of date, a new sync is requested in the background.


1.0.5 - correction of typo in 'unless' conflict detection template

1.0.4 version doesn't include the typo fixes on unless check on the IP conflict detection. there was an incorrect '$' before an int value we need in rendered PS. This merge will generate a new tag that includes the required fixes for the IP conflict detection to work as expected.

@karmafeast if you do not wish to generate a new tag, please update the existing tag 1.0.4 to the latest master.

@karmafeast Can you please accept the Pull Request to fix the bug?

@karmafeast care to accept this PR please ?

@karmafeast Request you to please take a look into this.
If you are occupied with other things and would like for me to co-own this repo, I'd be glad to help maintain this.


add protected flash writes/erases for when SD is in use

Soft device requires control over everything...

@mmoskal Can we merge?

I mean it was approved...


Installing requirements does not work

Hi,
I am facing an issue with the requirements installation after having launched this command:sudo pip install -r requirements.txt, see out put below.
I do not know exactly what to do :-((.
I am running El Capitan.
I would like to thank you in advance for your help,
Yop.
Requirement already satisfied: docopt in /Library/Python/2.7/site-packages (from -r requirements.txt (line 1)) Requirement already satisfied: schema in /Library/Python/2.7/site-packages (from -r requirements.txt (line 2)) Requirement already satisfied: click in /Library/Python/2.7/site-packages (from -r requirements.txt (line 3)) Requirement already satisfied: python-dateutil in /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python (from -r requirements.txt (line 4)) Requirement already satisfied: requests in /Library/Python/2.7/site-packages (from -r requirements.txt (line 5)) Requirement already satisfied: tqdm>=4.5.0 in /Library/Python/2.7/site-packages (from -r requirements.txt (line 6)) Collecting pyicloud from git+https://github.com/torarnv/pyicloud.git@photos-update#egg=pyicloud (from -r requirements.txt (line 7))   Cloning https://github.com/torarnv/pyicloud.git (to photos-update) to /private/tmp/pip-build-Q820bR/pyicloud Requirement already satisfied: keyring<9.0,>=8.0 in /Library/Python/2.7/site-packages (from pyicloud->-r requirements.txt (line 7)) Requirement already satisfied: keyrings.alt<2.0,>=1.0 in /Library/Python/2.7/site-packages (from pyicloud->-r requirements.txt (line 7)) Collecting six>=1.9.0 (from pyicloud->-r requirements.txt (line 7))   Using cached six-1.10.0-py2.py3-none-any.whl Collecting tzlocal (from pyicloud->-r requirements.txt (line 7))   Using cached tzlocal-1.4.tar.gz Collecting certifi (from pyicloud->-r requirements.txt (line 7))   Using cached certifi-2017.4.17-py2.py3-none-any.whl Collecting bitstring (from pyicloud->-r requirements.txt (line 7))   Using cached bitstring-3.1.5.zip Collecting future (from pyicloud->-r requirements.txt (line 7))   Using cached future-0.16.0.tar.gz Requirement already satisfied: pytz in /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python (from tzlocal->pyicloud->-r requirements.txt (line 7)) Installing collected packages: six, tzlocal, certifi, bitstring, future, pyicloud   Found existing installation: six 1.4.1     DEPRECATION: Uninstalling a distutils installed project (six) has been deprecated and will be removed in a future version. This is due to the fact that uninstalling a distutils project will only partially uninstall the project.     Uninstalling six-1.4.1: Exception: Traceback (most recent call last):   File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/basecommand.py", line 215, in main     status = self.run(options, args)   File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/commands/install.py", line 342, in run     prefix=options.prefix_path,   File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_set.py", line 778, in install     requirement.uninstall(auto_confirm=True)   File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_install.py", line 754, in uninstall     paths_to_remove.remove(auto_confirm)   File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/req/req_uninstall.py", line 115, in remove     renames(path, new_path)   File "/Library/Python/2.7/site-packages/pip-9.0.1-py2.7.egg/pip/utils/__init__.py", line 267, in renames     shutil.move(old, new)   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 302, in move     copy2(src, real_dst)   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 131, in copy2     copystat(src, dst)   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 103, in copystat     os.chflags(dst, st.st_flags) OSError: [Errno 1] Operation not permitted: '/tmp/pip-5vu5B1-uninstall/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/six-1.4.1-py2.7.egg-info'

I have solved my issue:

Install Homebrew
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
Install python
Brew install python
Install icloud_photo_downloader requirements
sudo pip install -r requirements.txt

It worked like a charm,
I'll try to download my pictures now ;-)
Thanks,
Kr,
yop


Localize Default Folders via Microsoft Graphs

Is it possible to localize Default-Folders of an Exchange-Online Mailbox through Update-MgUserMailboxSetting or similiar cmdlet ?
For example when using the Powershell-Module "ExchangeOnlineManagement" we can do this:
Set-MailboxRegionalConfiguration -Identity $userMail -Language de-CH -LocalizeDefaultFolderName -DateFormat dd.MM.yyyy
The '-LocalizeDefaultFolderName' parameter ensures the default Folders (Inbox for example) will be translated to the newly set langauge (de-CH in this example). How can we achieve the same when using Microsoft Graph API ?
What I'm doing currently is this:
$params = @{
<EMAIL_ADDRESS>= "https://graph.microsoft.com/v1.0/$metadata#Me/mailboxSettings"
	language = @{
		locale = "de-CH"
	}
	dateFormat = "dd.MM.yyyy"

}
Update-MgUserMailboxSetting -UserId $userInAzure.Id -BodyParameter $params

However this will update the language and dateFormat but 'DefaultFolderNameMatchingUserLanguage' will still be false (and therefore the mailbox isn't translated):

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 743129d7-ae63-b658-2690-8f9ee2c2743d
Version Independent ID: 04d4f30e-15cc-e4bf-ec8e-2da840ce5d9f
Content: Update user mailbox settings - Microsoft Graph v1.0
Content Source: api-reference/v1.0/api/user-update-mailboxsettings.md
Product: outlook
Technology: microsoft-graph
GitHub Login: @SuryaLashmiS
Microsoft Alias: MSGraphDocsVteam

@SuryaLashmiS  Any news on that ?


Disable the time feature

Is it possible to disable the time feature of this picker?
This is hands down the best bootstrap date picker and it would be nice to use it as a consistent control where time may not be relevant.

the picker uses the format option to decide what components to show. Set format to LT or another valid momentjs format string

Hi,
i see this issue is closed but when I use your plugin in my code I always see a timepicker :
My coffeescript code to load your js on date :
javascript jQuery ->   if( !(Modernizr.inputtypes.date) )     $("input:not([disabled]):not([readonly])[type='date']").datetimepicker       viewMode: 'years'       format: 'L'       locale: $('html').attr('lang')
I try also to use format: "DD/MM/YYYY"
And this is a screen capture of the displayed date picker. The time picker with a clock is always here :

create a jsfiddle and open your own issue


Backport v1.12: FQDN fixes

Backports FQDN related fixes to v1.12 that were not straightforward to backport.

[x] https://github.com/cilium/cilium/pull/26345 (@jrajahalme)
[x] https://github.com/cilium/cilium/pull/27670 (@jrajahalme)
[ ] https://github.com/cilium/cilium/pull/27693 (@joamaki)
[ ] https://github.com/cilium/cilium/pull/27870 (@joamaki)
[ ] https://github.com/cilium/cilium/pull/27985 (@joamaki)
[ ] https://github.com/cilium/cilium/pull/27796 (@bimmlerd)

for pr in 26345 27670 27693 27870 27985 27796; do contrib/backporting/set-labels.py $pr done 1.13; done

/test-backport-1.2

/test-backport-1.2

/test-backport-1.12

/test-backport-1.12

/test-1.17-4.9


use feross' standard for linting (in-progress)

Solves #495

@jonathanong -
✓ run linting in CI
✓ integrate feross' standard
✓ add babel-eslint

Aight so I refactored everything I found to standard (w/ the help of --format but still a good bit manually and w/ regex find & replace). Here are the remaining errors-
standard: Use JavaScript Standard Style (https://github.com/feross/standard)
  /Users/tejas/Repos/tejasmanohar/koa/test/application/respond.js:193:9: `errorCaught` is constant.
  /Users/tejas/Repos/tejasmanohar/koa/test/application/respond.js:745:9: Found unexpected statement after a throw.
  /Users/tejas/Repos/tejasmanohar/koa/test/context/onerror.js:103:9: Expected an object to be thrown.

// cc those who suggested standard to review PR (lmk if you know fix for these two as well- or you can just PR into my fork, going to look more tmrw)- @juliangruber @dead-horse @stojanovic

for reference,
standard: Use JavaScript Standard Style (https://github.com/feross/standard)
  /Users/tejas/Repos/tejasmanohar/koa/benchmarks/experimental/async.js:15:18: Parsing error: Unexpected token function
  /Users/tejas/Repos/tejasmanohar/koa/test/application/respond.js:193:9: `errorCaught` is constant.
  /Users/tejas/Repos/tejasmanohar/koa/test/application/respond.js:745:9: Found unexpected statement after a throw.
  /Users/tejas/Repos/tejasmanohar/koa/test/context/onerror.js:103:9: Expected an object to be thrown.
  /Users/tejas/Repos/tejasmanohar/koa/test/experimental/async.js:15:20: Parsing error: Unexpected token function

these are the errors w/o babel-eslint ^

diff is humongous- i'll keep the branch though if we do want this randomly.


[Feature] Update Config LA to Support Test data in config file

Update config Logic app to read test mode parameters from the config file and handle appropriately

Fixed in #11


bug: completion item documentation tables with no elements result in "Unknown markup" notification spam

Did you check docs and existing issues?

[X] I have read all the noice.nvim docs
[X] I have searched the existing issues of noice.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.11.0-dev (nightly from apt PPA)
Operating system/version
Ubuntu 24.04 LTS
Describe the bug
Using a language server that does (apparently) not provide documentation causes an error notification every time the cmp (code completion) changes. The error is thrown in lua/noice/lsp/format.lua on line 33, since the format_markdown function only handles list-type tables.
This is occuring for me in an .sql file with the sqls LSP attached. I've inspected item.documentation from lua/noice/lsp/override's setup function, and concluded that it's an empty table. I don't know what's a good way to handle this from your point of view, hence the issue and not a pull request. If you can provide some thoughts on the issue I would be happy to fix it.
I also realise this is, at its core, an issue with the LSP not providing said documentation, but I don't think trying to format it every time and throwing an error is the endgame for that kind of case.
Steps To Reproduce

Open an .sql file buffer
Attach sqls LSP (installed with Mason, defaults-configured with lspconfig and mason_lspconfig)
Start typing something like CREATE TABLE and see that the LSP does provide code completion suggestions, but also see a red error notification appear for every letter you type.

Expected Behavior
Graceful(?) handling of unprovided documentation data.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/noice.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

this has been merged right? .. not sure why but I'm still getting this error.. I think commit f119045 is the one related to this, right? I'm currently using latest versions:
nvim v0.11.0-dev-158+g05435a915
noice 69c6ad5

I have the same issue when using nvim-dbee with cmp-dbee.
When I start type SELECT * FROM I get the following error:
   Error  12:07:35 msg_show.lua_error Error executing vim.schedule lua callback: ...im/nvim-lazyvim/lazy/noice.nvim/lua/noice/lsp/format.lua:35: Unknown markup {
  kind = "Markdown",
  value = "```\nname: free\ntype: keyword\n```"
}
stack traceback:
	[C]: in function 'error'
	...im/nvim-lazyvim/lazy/noice.nvim/lua/noice/lsp/format.lua:35: in function 'format_markdown'
	.../nvim-lazyvim/lazy/noice.nvim/lua/noice/lsp/override.lua:17: in function 'get_documentation'
	...im/nvim-lazyvim/lazy/nvim-cmp/lua/cmp/view/docs_view.lua:48: in function 'open'
	...l/share/nvim/nvim-lazyvim/lazy/nvim-cmp/lua/cmp/view.lua:292: in function 'callback'
	.../nvim/nvim-lazyvim/lazy/nvim-cmp/lua/cmp/utils/async.lua:138: in function ''
	vim/_editor.lua: in function <vim/_editor.lua:0>
   Error  12:07:35 msg_show.lua_error Error executing vim.schedule lua callback: ...im/nvim-lazyvim/lazy/noice.nvim/lua/noice/lsp/format.lua:35: Unknown markup {
  kind = "Markdown",
  value = "```\nname: from\ntype: keyword\n```"
}

To investigate, i added print statements before line 35 in format.lua.
type(content) -- table
content.kind -- keyword
content.value -- "```\nname: free\ntype: keyword\n```"
content.language -- nil
type(next(content)) -- string

We could fix the issue by adding
elseif type(content) == "table" and type(next(content)) == "string" then
      goto continue

or we could just remove
error("Unknown markup " .. vim.inspect(content))
but I am not sure what the correct course of action is here.
Here is my plugin config if you want to reproduce the issue.
-- plugins/dbee.lua
return {
  'kndndrj/nvim-dbee',
  dependencies = {
    'MunifTanjim/nui.nvim',
  },
  build = function()
    -- Install tries to automatically detect the install method.
    -- if it fails, try calling it with one of these parameters:
    --    "curl", "wget", "bitsadmin", "go"
    require('dbee').install()
  end,
  opts = {},
}

-- plugins/dbee-cmp.lua
return {
  'hrsh7th/nvim-cmp',
  dependencies = {
    {
      'MattiasMTS/cmp-dbee',
      -- commit = '0feabc1',
      dependencies = {
        { 'kndndrj/nvim-dbee' },
      },
      -- ft = 'sql', -- optional but good to have
      -- opts = {}, -- needed
      config = function()
        require('cmp-dbee').setup()
      end,
    },
  },
  opts = function(_, opts)
    table.insert(opts.sources, { name = 'cmp-dbee' })
  end,
}

@Gabriel2409 what version of noice are you using? #820 was merged and does almost the same thing as your suggestion, and it fixed my instance with sqls but of course I didn't check with other LSP implementations for SQL.


unable to install extensions

VSCode Version: Code 1.3.0 (e724f269ded347b49fcf1657fc576399354e6703, 2016-07-07T16:50:12.291Z)
OS Version: Linux x64 4.4.0-28-generic

Steps to Reproduce:

View => Extensions
... => Show Popular Extensions
Select an Item
then Click [install]
No response

Same problem

I have the same issue with Fedora 23

Same on Ubuntu 16.04 LTS

same here on arch

I have that problem too on Mint 17.3

I have the same problem on Debian Jessie, installed from the .deb. A friend who used the zip says it works fine for him.

same issue with CentOS 7, upgraded with rpm, extensions used to work in previous version.

Duplicate of https://github.com/Microsoft/vscode/issues/8859


Add business_handbook with first part of business_plan.md.

Closes #174.
Eventually.
I'll finish off the current tech project work before writing the business plan.

Closing since I'm not sure if/when I'll get to this.


Validation perplexity not decreasing below a value

Hi,
I trained a summarization model using 3 layers, LSTM, rnn_size=600, SGD, learning_rate = 1 for 15 epochs,with start_decay at epoch 9. The lowest validation perplexity achieved was 45. I resumed training from this epoch_15_45 for another 8 epochs with learning rate of 0.1 . However my validation perplexity did not decrease any further.
What can be done in such scenarios to decrease the perplexity/ make the model learn further?
Can someone also kindly let me know how to use the start_decay_ppl_delta option? Is this the value 45 in my case, or the difference between perplexity values of two epochs? (for e.g say I need atleast a difference of 10 between the perplexity values, and if not, then start the decaying process )
Thanks!

Hi,

What can be done in such scenarios to decrease the perplexity/ make the model learn further?

With the same model, it seems you are already close to the optimal point. Otherwise, you could train a bigger model and try various model configurations to push the perplexity down.

Can someone also kindly let me know how to use the start_decay_ppl_delta option? Is this the value 45 in my case, or the difference between perplexity values of two epochs?

It's a relative value. If previous_ppl - current_ppl < start_decay_ppl_delta then the learning is decayed.

Thanks! @guillaumekln


Option to include the full commit message

{{.Message}} right now only includes the first line of the commit message
I'd suggest to have both a {{.CommitTitle}} and a {{.CommitBody}} var, where title is the one liner and body is the rest of the commit message. This way you can decide in the release config template whether you want to include both, and if yes how.

Closing as repo deprecated.


Extensive Understanding of Cloud Attacks and How to stop them

Topic Suggestion
Extensive Understanding of Cloud Attacks and How to stop them
Article introduction
Cloud attacks are most common, and these are attacks that usually let the hackers steal sensitive data stored in the cloud, and even go ahead destroying cloud services without being noticed. There are different types of cloud attacks, and the new ones keep on emerging due to advancements in technology. In this article, I will broadly discuss Cloud attacks, explain the types of club attacks, and go ahead and explain how they can be prevented
Key takeaways
Broad understanding of cloud attacks,  all the types, for example, the DDoS Attacks, and ways that can be used to prevent them.
Article quality
I will be covering in-depth, I will be covering the in-depth of every type of cloud attack, and I will show all the ways that can be used to prevent these attacks. This article will be very important not only to the organizations that use computers to store data but also to individuals who store their personal data on computers.
References
N/A.

Thank you for your response and we thank you for submitting your topic. After some careful consideration it struck us that this topic may be a bit over saturated throughout other blog sites and official documentations as previously mentioned on your topic form by our content moderator.
We typically refrain from publishing content that is covered widely on the net or other blogs. As we're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.


Support Server Side Rendering

I am using next.js for server side rendering. I managed to use styled components because they support ssr now, but I have still problems with hedron.

Hedron supports SSR as well in both 0.7.1 and 1.0.0-beta.6. You need to elaborate on what you're having problems with.

SSR was discussed a bunch in #71, make sure you have the babel plugin working.

yes, updated to a new version, now its working...


Add new notify options

Not ready to merge. Pending development update.

I'm going to close this one since it's now two years out of date and still in Draft state.


Regression in fix 203

Sorry Mangopay,
in my last fix there is bug.
Unfortunately there is a copy paste error in line:
payInExecutionDetailsBankingAlias.setBankingAliasId(object.get("WireReference").getAsString());
it should be:
payInExecutionDetailsBankingAlias.setWireReference(object.get("WireReference").getAsString());
https://gist.github.com/ptroc/014e07807c779ab573f03d553799daa5

@ptroc OK we'll look into it

Fix deployed


cabal-install-<IP_ADDRESS> is built against Cabal-<IP_ADDRESS>, but installed library is only Cabal-<IP_ADDRESS>

This seems to cause problems if you try to build a .cabal file that has cabal-version: >= <IP_ADDRESS>
Even though cabal-install-<IP_ADDRESS> is built against Cabal-<IP_ADDRESS> so you'd think it should work fine, cabal must must require Cabal-<IP_ADDRESS> to be installed in the package database in order for the build properly.
I would almost say this is a bug in cabal, but it is easily fixable here by adding:
RUN cabal install Cabal-<IP_ADDRESS>

I was able to build a cabal file with cabal-version >= <IP_ADDRESS> after specifying a default-language: Haskell2010

Do you have a default-language in your .cabal?

Hmm how strange, I definitely have it set.
If you do docker run <tag> ghc-pkg list | grep Cabal what do you get?

hmm, It would seem that I get cabal-1.18.*. Are there any other requirements to get it to fail? or is it just the cabal-version?

Let me try and put together an example on the weekend, perhaps it's to do with having tests in the project?

If I look at the PATH in the current haskell image, it doesn't have /root/.cabal/bin first, so you'll wind up running the Debian-packaged cabal executable even after updating it with "cabal install cabal-install' (how meta).  I don't know if this is the cause of the problem you ran in to, but it seems likely.  The fix may just be a PATH change if so.  BTW, cabal fibs a bit :trollface:
root@6ccd891fe3e0:/# echo $PATH
/opt/ghc/7.8.3/bin:/opt/cabal/1.20/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root@6ccd891fe3e0:/# cabal info Cabal | grep installed
Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.
    Versions installed: <IP_ADDRESS>
root@6ccd891fe3e0:/# cabal --version
cabal-install version <IP_ADDRESS>
using version <IP_ADDRESS> of the Cabal library

There is no <IP_ADDRESS> Cabal library in the image anywhere, but that is the minimal version specified by cabal-install.  FWIW, 7.8.4 also ships an older Cabal library (<IP_ADDRESS>), whereas 7.10.1 released last Friday ships with the latest <IP_ADDRESS>.

closing this since the current version of cabal is 1.22.4 in the 7.10 image


Text is not centered after loading the font

Steps to Reproduce

...
...

Logs

Logs

Text is not centered after loading the font

Hi @lcl6,
Please provide your flutter doctor -v  and a minimal complete reproducible code sample along with steps to reproduce so that we can investigate this issue.
If you're also using any custom fonts or assets, please provide them as well.
Thank you

Hi @lcl6,
Please provide your flutter doctor -v and a minimal complete reproducible code sample along with steps to reproduce so that we can investigate this issue.
If you're also using any custom fonts or assets, please provide them as well.
Thank you

I have uploaded the code and pictures。same fonts are not centered in the vertical direction。

Hi @lcl6, I cannot access the font file from the link you shared. Kindly upload the font file to github directly so that we can investigate.
Thank you


Please make sure all commits have signoff lines

We require all commits to SymbiFlow projects to have the Developer Certificate of Origin explicitly acknowledged. This is done through adding a Signed-off-by: Tim 'mithro' Ansell<EMAIL_ADDRESS>line to the bottom of each commit message.
You can do this easily with git via the git commit --amend --signoff and git rebase --signoff commands.
There is more information about this at;

https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for
https://github.com/probot/dco
https://cert-manager.io/docs/contributing/sign-off/

Was able to do all but 14b7333f4789c5d9bef95390ccd9dd1b58371583.  Not sure why I couldn't do that one.


[BEAM-11718] Actually run pre-optimize phases.

Looks like these were lost in refactoring.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @yifanmai

R: @yifanmai

Oops, this duplicates #13824. Could we use that instead?
Also, I think we have to temporarily disable translations.pack_combiners for PortableRunner / SparkRunner / FlinkRunner as well because they don't treat CombinePerKey as primitives either.

Oops, this duplicates #13824. Could we use that instead?
Also, I think we have to temporarily disable translations.pack_combiners for PortableRunner / SparkRunner / FlinkRunner as well because they don't treat CombinePerKey as primitives either.

Yes closing in favor of https://github.com/apache/beam/pull/13824

Yes closing in favor of https://github.com/apache/beam/pull/13824


How to use AggregateGroupByPeriodRequest and AggregateGroupByDurationRequest?

How can we aggregate steps data for day.
Let's say I want to fetch data for past 7 days and want count of total steps per day.

Hi
Yes! You can find it in the documentation below:
https://matinzd.github.io/react-native-health-connect/docs/api/methods/aggregateRecord

Hi
Yes! You can find it in the documentation below:
https://matinzd.github.io/react-native-health-connect/docs/api/methods/aggregateRecord
Each record type has its own result type. You can try Steps record and see what results you'll get. If you want for each day, you need to chunk below example into 7 different days.
Example:
aggregateRecord({
  recordType: 'Steps',
  timeRangeFilter: {
    operator: 'between',
    startTime: new Date(
      new Date().getTime() - 7 * 24 * 60 * 60 * 1000 // 7 days
    ).toISOString(),
    endTime: new Date().toISOString(),
  },
}).then((result) => {
  console.log(result.COUNT_TOTAL);
});

Thanks for pointing these out. I think these were added in the recent versions and it's not supported yet. I will add those to the roadmap.

@matinzd @nightskyhub
How can we aggregate steps data for day and All vitals .
Let's say I want to fetch data for past 7 and 30  days and want count of total steps per day.
i want display all vitals and steps and burned calories sleep ...etc is is possible to display all this stuff
please help on this
thanks in advance

Hi @matinzd,  When we can expect this feature, we are facing performance issue due to this. iOS by default provide payload in 1 Hour range
https://github.com/matinzd/react-native-health-connect/issues/16#issuecomment-1497233505

Hello @matinzd, Is there a plan to fulfil this feature?

If someone is up for sponsoring I will dedicate some time to implement it. Otherwise you can fork the project and add it yourself.

@matinzd Just made a PR integrating aggregateGroupByPeriod API. Would be great if you could take a look
https://github.com/matinzd/react-native-health-connect/pull/157


docs: fix rendering of tracer.startActiveSpan examples

Before (at https://open-telemetry.github.io/opentelemetry-js-api/interfaces/tracer.html):

after:

https://typedoc.org/guides/doccomments/ doesn't document the @example tag that I could see, so this is a guess that it meets the requirements to get picked up as a code block (given Markdown requires 4 leading spaces for that).

seems to be a dupe of #101

Ah, I hadn't looked. Thanks for finding the dupe. Likewise I'm happy for either one to get merged.

Dupe of #101


weapons with morex set apply spelleffect on equip

.add i_bow
.set morex=38
Equip the bow, the player become paralyzed (spell 38)
i don't find this type of property in typedef on the wiki
https://wiki.spherecommunity.net/index.php?title=TYPEDEF
Is it expected?

seems to be expected.

Ok, so it's only the wiki that needs an update. Thank you


Re: issue#435, ensure that duplicate calls to destroy arcore are ignored

Since it takes a few seconds to destroy the arcore object, multiple calls to the method can still happen concurrently while the first is still being destroyed but before the object reference has been nullified. This should protect against that race condition.

@kmayoral Hi!
As you can see in my PR I removed destroyARCore() from override fun destroy()
https://github.com/SceneView/sceneview-android/pull/438
I wrote a comment that I'm not sure if I need to call this in two places
Now I see that in version 2.1.0 the second call was returned. Perhaps the one who returned it understands the logic better and this call is necessary. But, apparently because of this, the crash returned again
I see your fix. You have added a flag
But maybe one of the owners will  explain why us, why do we need the second call of destroy?

I see only one case, when ARScene view will not have lifecycle

I think next (it not a best solution) solutions can prevent souble destroy also

So, the main questions:
1 - Do we really need to be able to pass two different Lifecycles?
2 - Is it possible to leave one and make it mandatory?
I don't understand why they are needed in construcor. For compose view ?
sharedActivity: ComponentActivity? = null,
    sharedLifecycle: Lifecycle? = null,

Is it possible to change the subscription method to this? Then there will be one lifecycle

Cuz it looks like 1 Lifecycle is necessary for ArCore calls

Hi @Antiglobalist , thanks for the comments! So it seems that your changes were probably wiped by a conflict resolving merge somewhere along the lines.
I definitely wouldn't be opposed to both changes being included in the code, but I do feel that this PR will make it so any other accidental double calls of destroy() don't cause issues by making this action more idempotent to begin with.
I would like if we could land this PR and then have another PR that reopens the changes you had previously made, what do you think?

@kmayoral Hi!
Sure!
I just noticed a common problem :)

@grassydragon Hello. Please take a look at my research above.
Perhaps it makes sense for the future

@Antiglobalist The double Lifecycle was there for Flutter but it might not be applicable anymore.
So could you please make it mandatory and unique in another PR?

@ThomasGorisse Sure!


Jupyter can't see pyscript/scripts/ context, but can see pyscript/modules/ ones

My pyscript/scripts context has gone missing in Jupyter, making it very hard to debug code.  Un-installing and re-installing the shim has had no effect.
In Jupyter, my list of available global contexts is correct, except for the missing script context:
['jupyter_1', 'modules.dic_tools', 'modules.logit', 'modules.physics', 'modules.reports']
If I try to switch to the  missing context the way I used to, I now get a NameError:
Exception in <jupyter_1> line 1:     pyscript.set_global_ctx('scripts.mkwd_main')                             ^ NameError: global context 'scripts.mkwd_main' does not exist
I'm not sure exactly what initiated the problem, although I suspect it started when I first added modules.
Any suggestions? Thanks in advance!

Re-installing Anaconda including Jupyter took care of it

Thanks for the follow up.  Glad it's working now.


Error with Node 4

When installing this boilerplate with Node 4 there are errors happening:
https://github.com/cerebral/cerebral-boilerplate

Isn't one of the issues being that node 4 comes with npm 2?

Installation completed succesfully on my side with node v4.3.1 and npm 2.14.12. However the bundle fails when using npm start because of some babel error.

So, what shall I do about this :)?

Would suggest just adding to docs that Node 5 and NPM 3 is recommended? :-)

Yup, could be nice indeed. But I am still not sure that it really does not work with node 4 & 0.12 etc.

@Yomguithereal I can confirm strange babel errors with node < 5. I actually
think it is an npm < 3 issue but we never tracked it down exactly...
On Mar 8, 2016 5:49 AM, "Guillaume Plique"<EMAIL_ADDRESS>wrote:

Yup, could be nice indeed. But I am still not sure that it really does not
work with node 4 & 0.12 etc.
—
Reply to this email directly or view it on GitHub
https://github.com/Yomguithereal/kotatsu/issues/102#issuecomment-193722838
.

Well that's unfortunate. Warning on the documentation it is then, I guess.

Just tested kotatsu on node 0.12.11 and it works.

Just tested kotatsu on node 4.1.0 (Mac OS) and it works.

Will try the boilerplate again but I'm having a hard time figuring out where the problem comes from.

The issue with the boilerplate is that npm2 doesn't flatten and therefore doesn't have access to kotatsu's babel-loader and presets dependencies.

I could try to be more clever in config merging but I am not sure this would be beneficial.

I added a note in the documentation concerning npm3 etc. Can you tell me whether we can close this issue?

@christianalfoni Safe to close?

I am happy :)


Ims.validateToken passes invalid token_type field, causes valid tokens to be rejected

Describe the bug
The Ims.validateToken method passes the wrong field, token_type, instead of type to the IMS API. This causes certain JWTs to be rejected.
To Reproduce
Steps to reproduce the behavior:

Go to https://console.adobe.io
Create a new integration
Use the private key and related information to create a JWT
Pass this JWT to the Ims.validateToken API

Expected behavior
The call should succeed, but it fails with this error:
400 - {"error_description": "Type parameter is required!", "error": "invalid_parameter_value"}

Thank you for the bug report and PR. This was probably a copy paste issue from invalidate_token which uses token_type instead of type.

Merged #41


support pprof extension

Is your feature request related to a problem? Please describe.

Elegantly support pprof

Additional context
refer to:

https://github.com/gofiber/fiber/tree/master/middleware/pprof
https://github.com/gin-contrib/pprof

Please assign this to me. I would like to work on this.

Please assign this to me. I would like to work on this.

thanks

@Haswf  There are unfinished issues, this issue will unassigned.

i want to try it

@wangbei98  thanks


Starting database stuffs

Added cache so you can be epic gamer while using database

um... dms for a second

Will merge once fully tested.

This pr will not be implemented any time soon.

...if at all


NIFI-1554: Changing process for cluster detection

Updating cluster detection to support access through the flow resource.
Using the correct resource when authorizing a root group port during site to site.

Reviewing...

+1 verified build passes contrib-check and was able to get into a secured NiFi instance


Working with @hyandell and @pracheer on MXNet converter.

Thanks @srikris for this. Looks like @madjam just merged your changes. We'll take it from here. Thanks a ton!


Grouped fixes from most forks

This PR groups most of the fixes made by other members of github to this library.
Changes on PR are:

Null safety
#36 by @thijskuilman
#31  by @DanielRobert1
#12 by  @alexkok
#8 by @gertdrui
Send custom params as form-urlencoded in the body for custom pusher authentication by @fabiancrx

Fixed presence events member_added and member_removed  still problem can you fix it, please?


chore: readonly properties

other PHP 8.1 upgrades (rector)

Loïc, thanks for this contribution that improves the code quality of this project!


Update Korean translations & .csv file encoding fixed

Provides Korean for missing keys
Fix encoding error when downloading sample .csv file in the import action modal

Next time, please create separate PRs from separate branches for unrelated changes, it makes maintenance difficult.


ci: split tests for local / db [vol.2] (#143)

ci: split tests for local / db

Authored-by: Borda https://github.com/Borda , Shay just merged this.

Everything passes! I could have bypassed and merged, but to celebrate you joining the contributors team, I have request and I am waiting your approval of your own PR! 🥳 🎆 🍾
@Borda


[Website] add Python implementation to KinesisIO

Resolves #22845

add Python implementation to KinesisIO on https://beam.apache.org/documentation/io/connectors/

before:

after:

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@pcoet, could you, please help with review of current PR?

Thank you!

Thank you!

Thank you for quick response!


Is there a publication of Ranger?

I want to cite ranger on a Medium article and I would like to know if there is an arXiv publication of Ranger or a published peer-reviewed paper on some conference or journal.
I saw you linked a paper o the README.md, but it does not seem to be about ranger, as the very word does not appear in any part of it. I know the Radam and Lookahead paper, but the Ranger one is missing on my library. Thanks

Hi @nuzrub - thanks for checking.  There's no published paper on Ranger at this point, just the medium article where I introduced it:  https://medium.com/@lessw/new-deep-learning-optimizer-ranger-synergistic-combination-of-radam-lookahead-for-the-best-of-2dc83f79a48d
Most papers have just cited the medium article.
I keep thinking soon we'll have an automated optimizer that does auto learning rate so never pushed towards a paper :) but looks like that time is still further out.
Good luck with your article and feel free to post a link here.
Hope you are doing well!

Thanks for replying. I do believe you should take sometime to write about Ranger, as I believe it is a great idea. In today's arXiv world, publishing ideas to the scientific community does not need to be as time consuming was it used to be with just journals and conferences.
Auto learning rate is something I believe would be great to all. However, I also believe there will always be some other parameter at the optimizer level. If we find a way to automatically search a good learning rate, there is going to be another parameter to control how fast this automatic detection should adapt. We are all slaves to hyper parameters in the end :x
Thanks for replying, I will let you know when I publish my article o/