Adding .DS_Store to .gitignore for Mac developers

Mac filesystem creates .DS_Store files to keep track of folder attributes, and we don't want these to be committed to the repo. Many developers don't have global git settings to ignore these files. docker/docker explicitly ignores them too.
Signed-off-by: Nishant Totla<EMAIL_ADDRESS>

LGTM
Test failed is unrelated to this change as it's trivial and not touch the code.
I'm not a Mac user actually. If other maintainers think it's useful please consider merging.
ping @docker/swarm-maintainers

sure why not. Somebody would have to be doing something very weird to have this happen (and on not-OSX), but we might as well be proactive in preventing it.

NOT LGTM on my side,
I think you should use the global git ignore.
if we merge this one, we will end up merging *~ and plenty of other stuff
I think it's better to teach the very few people that submit changes with .DS_Store committed (I don't think it ever happened here)

I understand the intent but I'm leaning towards @vieux's side, I never saw a single case of someone committing .DS_Store and this should be done through the global git ignore instead as a good practice.
So NOT LGTM.
@dongluochen WDYT?

My reasoning was that if someone committed .DS_Store files using git add . and not checking what they were adding, it just slows down the workflow since we have to ask them to update the PR. In particular, some code plugins use these files (as I found out yesterday), so it's a weird corner case as @MHBauer pointed out. Of course, experienced programmers will know to look out for this in the first place, but perhaps not everyone.
That said, I get @vieux's reasoning too (the .gitignore in docker/docker is very long for example), so if everyone thinks that this hasn't been an issue in the past, then it's not needed and I'm happy to close the PR.

I understand the intention of PR. But I think platform/IDE related files shouldn't get into code base, same reasons @vieux @abronan stated.

Thanks for the comments everyone. I'm going to close this PR, but if anyone has suggestions for things to add in .gitignore, I can reopen.


Trade - 0 attack stat

Describe the bug
the atk is 0 on a level 100 pkmn. I think the source save file is a hacked file so it might just be off.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I haven't replicated the issue in 2 weeks of development using the same files. 🤷


[Bug]: preload: false does not work for custom font

Demo URL
No response
What happened?
setting preload: false does not work for custom font
Reproduction steps
1. add preload: false to options
2. observe that fonts are still preloaded

Relevant log output
No response
What browsers are you seeing the problem on?
Chrome
What is your operating system?
MacOS

While reading through the source code, I noticed, that generating tags is unconditional for all generated link tags. Thus whenever a bundled asset matches the filename pattern for a font file, there will be a tag for it. Kinda unintuitively the settings under options.custom.prefetch and options.custom.preload are applied for all fonts, including Google Fonts, Font Source, etc.
Unfortunately, there's a bit of code duplication for the actual link tag generation, which makes the fix for this a bit spread all around the code base.
The outline for this is basically:

Find all places where getHeadLinkTags is called.
Look at the for (const file of files) loop directly below
The tags.push() there needs to be conditional on options.custom.prefetch || options.custom.preload

While at it and looking in the context of #10, after that for loop is also the ideal place to introduce a new callback options.custom.linkFilter hook, that in the simplest case just receives the tags array and could then do:

return true -> return tags unaltered
return false -> return no tags
return a modified tag array -> forward the modified choice of headers to generate


removed dead code

tuned deadcode4j configuration a bit
removed dead code

This pull request is now managed with CodeReviewHub. Refresh.


Supports assume role

Supports aws assume role

fixed #50

Other minor fixes

Usage
$ AWS_ASSUME_ROLE_ARN=<ASSUME_ROLE_ARN> tentez get -f examples/example.yaml

@FeLvi-zzz
Could you review it again?


Derive Hash for HttpDate

The headers crate has expressed interest in using httpdate1, but it needs
Hash to be implemented on its HttpDate facade.

Thank you!
I think this crate has reached maturity and used widely, so I will release it as v1.0 soon.

https://users.rust-lang.org/t/review-httpdate-before-the-release-of-v1-0/57610?u=pyfisch


Db entities

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Fixed entities and submissions post route to work with new entities & ds integration

Thank you for doing all this! Story Squad FTW!


add data migration & make referral on appointment not null

What does this pull request do?
The second part of pr-417. This adds a new migration that will update the existing appointments with a referral_id. Then finally make referral not null on the appointment.
What is the intent behind these changes?
To ensure that all appointments have a referral_id going forward.

This can't be merged until the previous one has been deployed otherwise they may get deployed together which is what you are trying to repvent

The first pr has been deployed to prod


[SPARK-37038][SQL] DSV2 Sample Push Down

What changes were proposed in this pull request?
Push down Sample to data source for better performance. If Sample is pushed down, it will be removed from logical plan so it will not be applied at Spark any more.
 TABLESAMPLE is not supported by all the databases. It is implemented using postgresql in this PR.
Why are the changes needed?
Reduce IO and improve performance. For SAMPLE, e.g. SELECT * FROM t TABLESAMPLE (1 PERCENT), Spark retrieves all the data from table and then return 1% rows. It will dramatically reduce the transferred data size and improve performance if we can push Sample to data source side.
Does this PR introduce any user-facing change?
Yes. new interface SupportsPushDownTableSample
How was this patch tested?
New test

Test build #144790 has started for PR 34451 at commit 43aba9b.

Test build #144790 has finished for PR 34451 at commit 43aba9b.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PushedDownOperators(

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144790/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49260/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49260/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49260/

Test build #144791 has started for PR 34451 at commit ceffb92.

Test build #144791 has finished for PR 34451 at commit ceffb92.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144791/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49261/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49261/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49261/

retest this please

Test build #144792 has started for PR 34451 at commit ceffb92.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49262/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49262/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49262/

cc @cloud-fan @viirya

Test build #144792 has finished for PR 34451 at commit ceffb92.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144792/

Test build #144804 has started for PR 34451 at commit e4fe27c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49274/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49274/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49274/

Test build #144804 has finished for PR 34451 at commit e4fe27c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TableSample(

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144804/

Test build #144859 has started for PR 34451 at commit b53fb39.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49329/

Test build #144863 has started for PR 34451 at commit 4628cf7.

Test build #144859 has finished for PR 34451 at commit b53fb39.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144859/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49329/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49332/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49329/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49332/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49332/

Test build #144866 has started for PR 34451 at commit 8e2a837.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49336/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49336/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49336/

Test build #144863 has finished for PR 34451 at commit 4628cf7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class TableSampleInfo(

Test build #144869 has started for PR 34451 at commit 293f233.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144863/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49339/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49339/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49339/

Test build #144866 has finished for PR 34451 at commit 8e2a837.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144866/

Test build #144869 has finished for PR 34451 at commit 293f233.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144869/

Test build #144883 has started for PR 34451 at commit 20f1a7f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49353/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49353/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49353/

Test build #144883 has finished for PR 34451 at commit 20f1a7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144883/

Test build #144896 has started for PR 34451 at commit 4d22d3e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49366/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49366/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49366/

Test build #144896 has finished for PR 34451 at commit 4d22d3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144896/

thanks, merging to master!

Thanks a lot @cloud-fan @HyukjinKwon


Feature Request: Error out when -p has a path that does not point to a valid python

When creating a pex, I used -p /Users/myacct/.pyenv/shims/python on the command line. This resulted in __main__.py contain BASH commands. It would be great if the pex command validated that paths passed via -p pointed to valid python interpreters.
pex -r /tmp/jupyterlab-requirements.txt -o jupyter-labs.pex -p /Users/myacct/.pyenv/shims/python built a pex that showed the following error when jupyter-labs.pex -e jupyterlab.labapp:main was run:
jupyter-labs.pex -e jupyterlab.labapp:main
Traceback (most recent call last):
  File "/Users/myacct/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 185, in _run_module_as_main
    mod_name, mod_spec, code = _get_main_module_details(_Error)
  File "/Users/myacct/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 219, in _get_main_module_details
    return _get_module_details(main_name)
  File "/Users/myacct/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 128, in _get_module_details
    spec = importlib.util.find_spec(mod_name)
  File "/Users/myacct/.pyenv/versions/3.6.9/lib/python3.6/importlib/util.py", line 91, in find_spec
    return _find_spec(fullname, None)
  File "<frozen importlib._bootstrap>", line 894, in _find_spec
  File "<frozen importlib._bootstrap_external>", line 1157, in find_spec
  File "<frozen importlib._bootstrap_external>", line 1131, in _get_spec
  File "<frozen importlib._bootstrap_external>", line 1112, in _legacy_get_spec
  File "<frozen importlib._bootstrap>", line 441, in spec_from_loader
  File "<frozen importlib._bootstrap_external>", line 544, in spec_from_file_location
  File "/Users/myacct/dev/virtualenvs/tmp-bc02eb6e921a2fd/jupyter-labs.pex/__main__.py", line 3
    [ -n "$PYENV_DEBUG" ] && set -x
                      ^
SyntaxError: invalid syntax

The -p flag does not mean --python it means --preamble-file. Pex just did what you asked there:
$ python -mpex -h
Usage: __main__.py [-o OUTPUT.PEX] [options] [-- arg1 arg2 ...]

__main__.py builds a PEX (Python Executable) file based on the given specifications: sources, requirements, their dependencies and other options.

Options:
  --version             show program's version number and exit
  -h, --help            show this help message and exit
  -o PEX_NAME, --output-file=PEX_NAME
                        The name of the generated .pex file: Omitting this
                        will run PEX immediately and not save it to a file.
  -p FILE, --preamble-file=FILE
                        The name of a file to be included as the preamble for
                        the generated .pex file
...

I'm going to close this as answered.

For posterity, the -p/--preamble-file feature implementation and example tests are in #400.

Thank you and sorry for not reading!


Cleaning around app component and navs - V2

Some more cleaning around the "app" component.

Codecov Report

Merging #129 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   45.00%   45.08%   +0.07%
==========================================
  Files          85       85
  Lines        1131     1129       -2
  Branches      189      189
==========================================
  Hits          509      509
+ Misses        598      596       -2
  Partials       24       24

Impacted Files
Coverage Δ

src/app/core/app.component.ts
3.70% <ø> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d9a6e...b4f7df2. Read the comment docs.


Error on logcat about Theme.AppCompat from ThemeUtils

In logcat, it constantly shows,
TAG: "ThemeUtils", Content: View class dev.jeziellago.compose.markdowntext.CustomTextView is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).

For now, there is no problem with rendering the markdown, but this error keeps showing up in the Logcat.
Is there any way to fix this?

Hi @Taewan-P!
Thank you for reporting it. I'll take a look.


Document customizing _.iteratee

For visual review: http://rawgit.com/captbaritone/underscore/custom-iteratee-docs/index.html#iteratee
Note, mostly for myself: This should not be cherry-picked onto gh-pages, since the functionality is not available in the latest tagged release.
Credit: Uses @olleicua's RegExp proposal from #2475 as the example customization.

Coverage remained the same at 96.863% when pulling f32dfc6fde825976a3126b12cc81dad4e42cfcc5 on captbaritone:custom-iteratee-docs into a0e5f4cc95e04e16a2ad90c72ec3aac067ebcfbb on jashkenas:master.

Coverage remained the same at 96.863% when pulling f32dfc6fde825976a3126b12cc81dad4e42cfcc5 on captbaritone:custom-iteratee-docs into a0e5f4cc95e04e16a2ad90c72ec3aac067ebcfbb on jashkenas:master.


Unable to find electron rebuilt's version number

I'm getting following error:

An unhandled error occurred inside electron-rebuild
Unable to find electron-prebuilt's version number, either install it or specify an explicit version
Error: Unable to find electron-prebuilt's version number, either install it or specify an explicit version
at Object. (C:\Users\Mike\Desktop\pos\node_modules\electron-rebuild\lib\src\cli.js:80:19)
at Generator.next ()
at C:\Users\Mike\Desktop\pos\node_modules\electron-rebuild\lib\src\cli.js:8:71
at new Promise ()
at __awaiter (C:\Users\Mike\Desktop\pos\node_modules\electron-rebuild\lib\src\cli.js:4:12)
at C:\Users\Mike\Desktop\pos\node_modules\electron-rebuild\lib\src\cli.js:69:8
at Object. (C:\Users\Mike\Desktop\pos\node_modules\electron-rebuild\lib\src\cli.js:145:4)
at Module._compile (internal/modules/cjs/loader.js:688:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
at Module.load (internal/modules/cjs/loader.js:598:32)

Electron version: 3.0.9
Native module: nfc-pcsc
Rebuilt using:  .\node_modules.bin\electron-rebuild.cmd
I tried to install electron-prebuilt. The rebuild works now, but then I get the following error:

The module<EMAIL_ADDRESS>was compiled against a different Node.js version using
NODE_MODULE_VERSION 50. This version of Node.js requires
NODE_MODULE_VERSION 64. Please try re-compiling or re-installing
the module (for instance, using npm rebuild or npm install).

Thanks in advance for the help!
Mike

Turns out electron was not installed as a devDependency. Electron-rebuild now works.

Not for me though


VTO2000 is not showing live stream ...

Hi there, I have successfully installed the Dahua integration, many thanks for this, but for my VTO2000, I can not get the live stream.
I also have similar issue for the 2 other Dahua cameras ... I think k I am doing something wrong :

Can someone please help me ?
Many Thanks in advance.

.. by the way, when restarting HA, I noticed the following related to WEB-RTC, which is something I u-installed as well ... but I didn't know there was a link with it ??

Logger: homeassistant.helpers.entity
Source: helpers/entity.py:1567
First occurred: 19:53:54 (1 occurrences)
Last logged: 19:53:54
Entity camera.haustur_main (<class 'custom_components.dahua.camera.DahuaCamera'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <CameraEntityFeature.STREAM: 2>, please create a bug report at https://github.com/rroller/dahua/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation


fix: base_test

What?
Test base trainer component
Why?
Comprehensive testing on JAX mava systems
Extra
The only thing to test in the base class seems to be the names of the components. The actual functions are tested in the other classes?
Closes #532

Thanks for this Siddarth. There's actually just nothing to test here, so that's my bad for creating an issue for it.
Would you mind please just resolving the issue with a comment akin to "Nothing to test" and moving on to another test instead?


Constructor

Hi. Seems that there is a problem with the library: I got this error:
const outlinevpn = new OutlineVPN({
                   ^

TypeError: OutlineVPN is not a constructor

The same problem in Node.js application.

If you encounter an issue in Node.js, you need to import the library differently:
const OutlineVPN = require("outlinevpn-api").default;
This way of importing solves the "is not a constructor" issue.

@manatech @flathead, thanks you for your feedbacks!
You can install v2.1.0, and use:
import { OutlineVPN } from 'outlinevpn-api'


v2.9.1编译错误

Describe the bug
编译错误
[100%] Linking CXX executable ../../bin/fisco-bcos
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/vrf_rpbft/VRFBasedrPBFTEngine.h:47: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/vrf_rpbft/VRFBasedrPBFTEngine.h:47: error: undefined reference to 'vtable for dev::consensus::VRFBasedrPBFTEngine'
/usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/RotatingPBFTEngine.h:34: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/RotatingPBFTEngine.h:34: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/RotatingPBFTEngine.h:34: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/usr/include/c++/9/bits/shared_ptr.h:510: error: undefined reference to 'typeinfo for dev::consensus::VRFBasedrPBFTEngine'
collect2: error: ld returned 1 exit status
make[2]: *** [fisco-bcos/main/CMakeFiles/fisco-bcos.dir/build.make:150: bin/fisco-bcos] Error 1
make[1]: *** [CMakeFiles/Makefile2:2204: fisco-bcos/main/CMakeFiles/fisco-bcos.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Environment (please complete the following information):

OS: Ubuntu20.04.4
FISCO BCOS Version 2.9.1

Additional context
Add any other context about the problem here.

Describe the bug 编译错误
[100%] Linking CXX executable ../../bin/fisco-bcos
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/vrf_rpbft/VRFBasedrPBFTEngine.h:47: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/vrf_rpbft/VRFBasedrPBFTEngine.h:47: error: undefined reference to 'vtable for dev::consensus::VRFBasedrPBFTEngine'
/usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/RotatingPBFTEngine.h:34: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/RotatingPBFTEngine.h:34: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/home/bc/fisco2.9/FISCO-BCOS-2.9.1/libconsensus/rotating_pbft/RotatingPBFTEngine.h:34: error: undefined reference to 'VTT for dev::consensus::VRFBasedrPBFTEngine'
/usr/include/c++/9/bits/shared_ptr.h:510: error: undefined reference to 'typeinfo for dev::consensus::VRFBasedrPBFTEngine'
collect2: error: ld returned 1 exit status
make[2]: *** [fisco-bcos/main/CMakeFiles/fisco-bcos.dir/build.make:150: bin/fisco-bcos] Error 1
make[1]: *** [CMakeFiles/Makefile2:2204: fisco-bcos/main/CMakeFiles/fisco-bcos.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Environment (please complete the following information):

OS: Ubuntu20.04.4
FISCO BCOS Version 2.9.1

Additional context Add any other context about the problem here.

这几个类没有虚析构函数，编译器版本比较高，检测比较严格，已经修复，可以使用master-2.0的代码


Update ReadMe

This PR makes changes in the read-me of this app.

Hi @abhinavkrin . This is ready to merge


Is there a method of adding scroll / pan easing?

Similar to the default for panellum

Is it possible to get an example on how to update this?

As I mentioned in https://groups.google.com/g/marzipano/c/41cR4WcFQ4o/m/qjfAFiGHAAAJ, the only way to customize the control acceleration/friction parameters at the moment is by editing the initialization code at https://github.com/google/marzipano/blob/master/src/controls/registerDefaultControls.js#L50.


Release 0.12.0

This is housekeeping for release 0.12.0

Coverage: 87.402% (-0.3%) from 87.744% when pulling e8deff8f678ce3bb16e096b51ed7feae20afc688 on INM-6:release_0.12.0 into b9d0d54e8560074fc34ec333cf93d8ab17d34b47 on NeuralEnsemble:master.


Default to iTermocil.yml in cwd

Default to using iTermocil.yml in the cwd if it exists when no layout is provided, re #12 (Feature request: check cwd for itermocil file).

As mentioned I'm not a python dev but had a go, not sure it's the right way to handle it though.

Hey, any update on this? Just came to use it again and remembered this.

Better late than never. Thanks @mcky. I think this is an awesome addition!!

Wow I'd completely forgotten this haha, might take a look at some of the issues later ;)


How do do an upgrade from previous version?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Example. I'm am trying to do [...] but [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I'm also unclear on this. I have an "on your computer" installation (namely, on a Windows Server 2019 with IIS).
I tried simply replacing everything except for packages with the newest binary; however, BaGet would no longer find anything. Presumably, I need to run a re-index somehow?
I then replaced the baget.db with my backup, but that file was outdated by several months, which didn't seem right. Packages did show up, but I'm not sure if all. And, after a reboot, BaGet failed to launch, with:
Unhandled exception. Microsoft.Data.Sqlite.SqliteException (0x80004005): SQLite Error 8: 'attempt to write a readonly database'.

So I'm probably not supposed to manually replace that database.
(I've downgraded again, for now.)
What's the recommended procedure?

You should be able to update by replacing BaGet's code while keeping your storage and database:

The packages folder, if any
The symbols folder, if any
The baget.db file, plus any baget.db.* files SQLite may have generated

BaGet has not had any intentional breaking changes for quite some time now. However, it's possible the update logic has bugs as it isn't all that well tested. In case the update breaks, here's a PowerShell script to re-import packages to a new BaGet installation:
$source = "C:\path\to\previous\baget\packages"
$destination = "http://localhost:5000/v3/index.json"

# Uncomment this if your new BaGet instance requires an API key.
# & nuget.exe setapikey "MY-API-KEY" -Source $destination

$packages = Get-ChildItem -Path $source -Filter *.nupkg -Recurse -File

$packages | % {
  Write-Host "nuget.exe push -Source $destination ""$($_.FullName)"""
  # & nuget.exe push -Source $destination $_.FullName
}

Let me know if you run into any problems!

For future reference: I thought the error pointed to a locking problem, but it was simply a matter of file system permissions — baget.db* weren't writable by the IIS application pool.


Rollout Range Can be Safer in Case a User Uses an Unintended Value

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

One fatal but subtle error, IMHO, is that the rollout range is (0.0,1.0) instead of (0.00,100.00). Let's look into both and see why the former is a fatal error:yum::
In the current range (0.00, 1.00), if a user thinks that the actual range is (0.00, 100.00) and sets the rollout to 0.5, the app will be released accidentally to 50% of the users (this is the fatal error).
On the other hand if the range is (1.00, 100.00), the app will be either released to 0.5% of the users at most or any other error will occur in fastlane, Google Play, or TestFlight but this error will be definitely better than accidentally releasing an app to 50% of the users.
From the issues I searched, some of them imply that the Google Play API accept (0.00,1.00) but either way the Fastlane interface is orthogonal and this should have nothing to do with how users interact with Fastlane.
And safety and explicit errors are especially important for Fastlane's usecases. And this can be easier because Fastlane has limited op-sensitive operations as compared to other tools that have a much larger surface area (e.g: Terraform and other IaC tools):sweat_smile:.
I understand that these changes (if approved) can only happen with the next major update and hope the bigger problem of silent unexpected behavior is more thoroughly  mitigated:smiley:.

Thanks @fastlane-bot for pointing this out but I think this would be irrelevant in this case:sweat_smile:.
And BTW, I think there's a strange object on top of your head so you might want to see a doctor to get it checked out. Sorry if this is too personal or hurts your feelings but you seem like a nice person and I would definitely want people to tell me if it were me:sweat_smile:.

@fastlane-bot I think you may have closed this by mistake:sweat_smile: or maybe I'm just mistaken:thinking:.


Continue query exception when fill(null) used

Hi,
This continue query:
select mean(elapsed) as average, percentile(elapsed,95) as percentile_95, max(elapsed) as maximum from /^Jmeter.*/ group by time(1s) fill(null) into 1sec.timing.:series_name backfill(false)
cause to error
[2015/07/01 08:05:38 IDT] [EROR] (github.com/influxdb/influxdb/coordinator.(*Coordinator).InterpolateValuesAndCommit:486) Couldn't write data for continuous query: %!(EXTRA *errors.errorStr ing=proto: Marshal called with nil)
and doesnt works.
Without fill(null) the CQ works fine, but i need to fill the intervals in series.
Is some workaround exists?

hey @evgygor I'm having a hard time reproducing the error. Have you tried something like fill(0) or fill(1.0)

Hi,
I'm using the influxdb 0.8.8.
I cannot use fill(0) cause it's fill data with wrong values, 0 is one of possible values, so I need fill the "missed" associated datapoints with null.
I think the issue comes from golang's working with JSON...

Currently InfluxDB doesn't support writing points with null values.
I'm trying to think if there's a work around. Could you increase the group by to time(2s) and then run a select with a group by time(1s)?

Thanks, I'll try.


Showcase Submission for challenges/4-purple-rain

Thank you Rudransh Bhardwaj for your contribution! A member of the Coding Train team will review it shortly.

Hecker Rain
Rudransh Bhardwaj

Great work!


Session 4

These are the files that i committed. i did git reset --soft HEAD~1 to remove the initial commit,in which i had committed wrong files .I should have maybe used git reset --hard. the session_3 commit which i had removed using git reset has also been committed

These are the files that i committed. i did git reset --soft HEAD~1 to remove the initial commit,in which i had committed wrong files .I should have maybe used git reset --hard. the session_3 commit which i had removed using git reset has also been committed

Hey, it looks great!
Try and attempt any of the bonus tasks

Hey, it looks great!
Try and attempt any of the bonus tasks

I don't know why i added two navigation bars but now since,i have edited the application.html.erb file,it is a single navigation bar. I tried changing the colour of my nav_link. Although the colour of the nav link did change but it is not visible on the navigation until on click on the nav bar with  my cursor.

I don't know why i added two navigation bars but now since,i have edited the application.html.erb file,it is a single navigation bar. I tried changing the colour of my nav_link. Although the colour of the nav link did change but it is not visible on the navigation until on click on the nav bar with  my cursor.

It works fine, now. The nav-link was maybe not visible as i was using the a tag which automatically sets the colour,based on the bg(the color of the other navbar that i created was bg-secondary), So,I just removed the a tag and changed it to link_to

It works fine, now. The nav-link was maybe not visible as i was using the a tag which automatically sets the colour,based on the bg(the color of the other navbar that i created was bg-secondary), So,I just removed the a tag and changed it to link_to


Update README.md files

Vet Clinic
This is a Veterinary Database that stores information about animals, including their name, date of birth, number of escape attempts, neutered status, and weight in kilograms as a decimal value.

Hi @emarkees,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that is invalid because you did not follow the correct Git-flow work flow. Thus creating the PR branch from a descriptive feature branch like feature/vet_database into the dev branch and not the main as we have currently
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


User setting for token

Make a user setting for the api token, and save the repo etc as a flag on the user

This is is resolved by limiting permissions inside Foundry VTT


Want to use Action Pack Variants.

If variants can be used, more uses.
for example
app/components/article_component.html.erb
app/components/article_component.html+amp.erb
app/components/article_component.html+sp.erb
app/components/article_component.rb

Currently only one view is supported.
Really please.

@kenzooooo thank you for the suggestion! While we aren't planning to work on support for variants in the near future, I have no objection to supporting them.
I'd happily accept a PR 😄

@joelhawksley I've been trying to solve this, but with not much success 🙈
The lookup_context variable has the variants method which returns an array of variants from the request, so that's ok. I also managed to update the compiled_template and template_file_path methods to receive a variant name as an argument. That works fine, I added some tests, but I'm not sure how to update the class_eval that implements the call method.
So I already have it working for first time requests, but as soon as you start using already compiled templates, you see that the request returns the previous used variant. And this is because I couldn't come up with a way to update the call method to actually return the variant requested.
Do you have some ideas regarding this?
Maybe I'm tackling this wrong? It felt so more complicated than it actually appears to be.
Thanks in advance!


Allow /ban telegram-id

/ban command works with the username, but we should allow to use the telegram id as parameter

Hello @grunch, can I start working on this? If yes , can you please point me out the file ?

Hello @grunch, can I start working on this? If yes , can you please point me out the file ?

yes 😀
https://github.com/lnp2pBot/bot/blob/main/bot/start.js#L503

@grunch So the /ban command should work with both the username and telegram id right? Or just the telegram id?

@grunch So the /ban command should work with both the username and telegram id right? Or just the telegram id?

both

closing it via #417


Build the docs

Summary
This PR updates the existing elastic-otel-node documentation to match the formatting and file type requirements of Docsmobile. The goal of this PR is not to improve or change the formatting/structure of the content. The goal is simply to update the existing doc source files to a Docsmobile-friendly format and provide a navigation file that can be expanded as the docs grow.
My team will help structure and improve content at a later date. This is part one of https://github.com/elastic/obs-docs-team/issues/231.
Output

Build locally
You can build this PR locally by checking out elastic/docs.elastic.co and this branch of elastic/observability-docs: https://github.com/elastic/observability-docs/pull/3915.
In elastic/docs.elastic.co, update your content-dev.js file to the following:
content-dev.js
const content = {
  sources: [
    {
      type: 'file',
      location: '../../observability-docs/docs/en/apm-agents',
    },
    {
      type: 'file',
      location: '../../elastic-otel-node/packages/opentelemetry-node/docs',
    },
  ],
  nav: {
    default: 'obs',
    structure: [
      {
        collection: 'Observability',
        navs: [
          'obs',
          {
            group: 'Node.JS',
            pageId: 'apmAgentOverview',
            navs: [
              'elastic-otel-node',
              'elastic-apm-node'
            ],
          }
        ],
      },
    ],
  },
}

module.exports = { content }

Run yarn dev.

This PR is now ready for review.

Oh, I see I can merge even without another look. Reminds me of the good ol' days. ☺


Daemon/PolicyAdd lock policyRepo to avoid fqdn races.

This is a small commit that help to fix the FQDN race found in the issue
This commit will lock PolicyRepo in the FQDN start, so rules less likely
to be overwritted by FQDN GeneratedRule callback.
Discussion PR: https://github.com/cilium/cilium/pull/7220

This change is

Coverage remained the same at ?% when pulling 3901a710f80a6c7d108ec74a25422ba62445a4ef on eloycoto:FQDN-HalfRaceFix into 8827a1ef79d4d149cce358315de60ae6d7cb57dc on cilium:master.

test-me-please


use devslog

https://github.com/golang-cz/devslog
Incorporate this into logos?

Or incorporate https://github.com/samber/slog-multi#broadcast-slogmultifanout ?

Or https://gitlab.com/greyxor/slogor

Or https://github.com/lmittmann/tint


Fixed #28442 - Fixed nested OuterRefs on primary key

Avoid exception in AutoField get_prep_value when value is an OuterRef.
https://code.djangoproject.com/ticket/28442

Are there any other comments or questions on this fix resp. the use case? As I understand @schinckel is the fix reasonable.

Sorry for a naive question, but will this fix be ever merged into the 1.11 branch?

Per our supported versions policy, 1.11 is only receiving fixes for security and data loss issues.

Should OuterRefs beeing allowed as Parameters in RawSQL-Annotations of query-sets? I cannot getting them work.
    def get_queryset(self, request):
        queryset = super().get_queryset(request)
        queryset = queryset.annotate(
              _some_yes_no_computed_annotation
                   = RawSQL('''select EXISTS ( SELECT o.id FROM sometable_unrelated_to_Model o where o.id = %s ) ''', (OuterRef('pk'),))

@ifrh, no RawSQL params must be literal types that the backend supports binding for.

So if OuterRef('something') or some "helper method" could give the name of underlaying "table.column" symbolic representation, than it would be possible - right?

No, because parameters that are specified to raw interfaces must be already resolved. In other words you must include the name of the outer column name in the SQL directly, if you use raw interfaces you're on your own and neither of the expression and compilable interfaces (respectively resolve_expression and as_sql) are usable.

@ifrh One of the things that Subquery/OuterRef and friends are supposed to do is help write queries that would have otherwise required RawSQL. Perhaps there is a way to write the query you are trying to write in the ORM proper?
This is not a support channel, but if you hop into the #django IRC channel, then you might get some help there.


Removal of accessories

Thanks a lot on the effort you did!
do you happen to know where the accessories are stored in the device?
I cant remove 4 temp sensors I had added, and also the Aqara app refuses to unbind them.
i was looking around in the directories via telnet, but cant seem to find it

zig_leave_all_devices didn't work for some reason.
What did work:

rename dev_list.json to dev_list.json.bak at /mnt/confgi
rename accessory files to 1.bak at /mnt/config/zigbee
rename device.info to device.info.bak at /mnt/config/zigbee
reboot


Setup code coverage

Looking at other repos I see a number of them run code coverage tools.  It may be worth doing the same for that project.  But we are a very mixed language package, so it is less than clear how well these tools will work.  I poked a bit at Codecov, seems like it is simple and free to add at Github market place.
@marscher any opinion on whether Codecov is worth trying here?  Is there an alternative we should consider?

I haven't seen any service so far supporting multi-language projects. I'm using Codecov for other Python based projects.

I am generally of the opinion that some coverage checker is better than no coverage checker.  Thus I guess I should spend some time setting up codecov when I next get a few free cycles.


"Moroeni", "Dobrești" are listed in the drop-down menu

Description:
When user writes ”Moroeni” and "Dobrești" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Moroeni"

Expected results
The location appears in the drop-down menu as "Sat Moroeni, DÂMBOVIȚA (Moroeni)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Dobrești"

Expected results
The location appears in the drop-down menu as "Sat Dobrești, DÂMBOVIȚA (Moroeni)".


Cargo install issue on Win 10 ("Unknown flag:  --release")

Hi,
Just running through the Windows install of the Indy environment, and all going well as far as the Cargo install.
Running the cargo command as specified, I receive the following error:
Unknown flag:  --release
And when I remove this flag, it reports that --target is an unknown flag also.
The cargo --list command returns possible switches yet the --release and --target flags are not listed.
any suggestions?
thanks
n

cargo help run
Run the main binary of the local package (src/main.rs)

Usage:
    cargo run [options] [--] [<args>...]

Options:
    -h, --help                   Print this message
    --bin NAME                   Name of the bin target to run
    --example NAME               Name of the example target to run
    -p SPEC, --package SPEC      Package with the target to run
    -j N, --jobs N               Number of parallel jobs, defaults to # of CPUs
    --release                    Build artifacts in release mode, with optimizations
    --features FEATURES          Space-separated list of features to also build
    --all-features               Build all available features
    --no-default-features        Do not build the `default` feature
    --target TRIPLE              Build for the target triple
    --manifest-path PATH         Path to the manifest to execute
    -v, --verbose ...            Use verbose output (-vv very verbose/build.rs output)
    -q, --quiet                  No output printed to stdout
    --color WHEN                 Coloring: auto, always, never
    --message-format FMT         Error format: human, json [default: human]
    --frozen                     Require Cargo.lock and cache are up to date
    --locked                     Require Cargo.lock is up to date
    -Z FLAG ...                  Unstable (nightly-only) flags to Cargo

--release                    Build artifacts in release mode, with optimizations

run and build cargo commands have this flag

@notOccupanther I am closing this as i don't see problem. If you need basic help it is better to ask in #ind-sdk channel in Hyperledger's Rocket chat.


feat: migrate service topology controller to yurt-manager

What type of PR is this?
/kind feature
What this PR does / why we need it:

Migrate service topology controller to yurt-manager.
As the last controller to be migrated, the yurt controller manager was removed during the migration.

Which issue(s) this PR fixes:

Fixes #1067
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?

other Note

@YTGhost please fix golangci-lint errors.

@rambohe-ch PTAL

/lgtm


Fix any type for ctx

Hi, I'm Russian and I use your bot in a telegram, but yesterday the bot stopped working, can I ask you when it will work again?

Hey, sorry about that, it's up again.


rancher-compose pull Unknown schema type [pullTask] error

I use rancher-compose up to deploy containers. There is 'cache' service in the docker-compose.yml,
...
cache:
  restart: always
  tty: true
  image: redis
  stdin_open: true
...

In case there is update for image redis:latest, I wanna pull that image and don't need to go through process of upgrade, like what command line rancher-compose upgrade does.
I tried to use rancher-compose pull cache, but get error
Unknown schema type [pullTask] error

Check source code, it uses docker libcompose pull, does that mean it actually uses docker-compose to pull? While I tested docker-compose pull, it works perfect.
rancher-compose version version v0.4.0

Do you have more services listed in your docker-compose.yml file? Can you share your entire docker-compose.yml file?
The rancher-compose pull command doesn't take in a service name as an argument, it automatically looks at all services inside the docker-compose.yml file and will pull new images for the images in any service.

What version is the Rancher that rancher-compose is pointed at?  It might be a red herring but the error message suggests that it's < v0.38 and the backend/api support for pull isn't there yet.

You are right, Rancher version
Rancher	v0.37.1
Cattle	v0.91.1
User Interface	v0.47.0
Rancher Compose	beta/latest
So pull isn't ready for that v0.37.1

rancher-compose pull was only added as of v0.38.0, but I'd recommend v0.39.0 as there were some bugs in v0.38.0 that have been fixed.
We are looking to implement https://github.com/rancher/rancher/issues/1725 and https://github.com/rancher/rancher/issues/2007 to ensure issues like yours are easier to spot.


Article on wine selling problem

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Both codes in python and C++ are written by me
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Fixes: #514

@atarax665 @siddharth25pandey Kindly review my PR.
Thank you


GitHub legacy token authentication is broken

The most recent commit updated the construction of a GitHub instance in the connect controller, but did not pass the 'version' option. As a result it is not possible to use the legacy 'token' GitHub authentication. I created a commit to my own branch  to try ad address this issue. However I am now getting an UnhandledPromiseRejectionWarning. The details are in the linked commit comments.
Are you in the process of tearing out support for token authentication? Any ideas why it is currently failing to work?
UPDATE:
I captured the error. It is returning a 404. I am not sure why yet though.
{ HttpError: Not Found
  at response.text.then.message (/var/task/user/index.js:130027:27)
  at <anonymous>
  at process._tickDomainCallback (internal/process/next_tick.js:228:7)
  name: 'HttpError',
  status: 404,
  headers:
  { 'access-control-allow-origin': '*',
    'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type',
    connection: 'close',
    'content-encoding': 'gzip',
    'content-security-policy': 'default-src \'none\'',
    'content-type': 'application/json; charset=utf-8',
    date: 'Sun, 07 Apr 2019 13:02:39 GMT',
    'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
    server: 'GitHub.com',
    status: '404 Not Found',
    'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
    'transfer-encoding': 'chunked',
    'x-accepted-oauth-scopes': 'public_repo, repo, repo:invite',
    'x-content-type-options': 'nosniff',
    'x-frame-options': 'deny',
    'x-github-media-type': 'github.v3; format=json',
    'x-github-request-id': 'E876:4A18:21B074A:28D6BF7:5CA9F4EF',
    'x-oauth-scopes': '',
    'x-ratelimit-limit': '5000',
    'x-ratelimit-remaining': '4999',
    'x-ratelimit-reset': '1554645759',
    'x-xss-protection': '1; mode=block' },
  request:
  { method: 'GET',
    url: 'https://api.github.com/user/repository_invitations',
    headers:
    { accept: 'application/vnd.github.v3+json',
      'user-agent': 'Staticman agent octokit.js/16.8.0 Node.js/8.10.0 (Linux 4.14; x64)',
      authorization: 'token <MY-TOKEN>' },
    request: { timeout: 5000, validate: [Object] } },
  documentation_url: 'https://developer.github.com/v3/repos/invitations/#list-a-users-repository-invitations' }

I solved this issue. The problem was that my token was not authorized to access the invitations endpoint. Once I gave my token the repo invitations permission everything worked. I can make a PR for this tomorrow. I won't have time today unfortunately. I want to read over your contributing section, add a unt test and make sure everything passes etc. I will leave this issue open until I make the PR. Thanks.

7 suites and 60 tests are failing in master. I started to fix tests until I had only 17 failing, but then realized that the tests are meant for version 2 of the GitHub API, but the code has been partially updated to version 3 of the GitHub API. I am not sure how the maintainers wish to handle this, so I stopped fixing tests. Was a PR accidentally pushed to master that was meant for dev? Perhaps the simplest solution here is simply to rollback the commit?

+1 for this issue. I just hit that when I tried to run my own instance from latest master branch.
Quick temporary workaround if needed - checkout latest verified version and restart application:
git checkout -b workaround 9ce2c48

+1 for this issue. I just hit that when I tried to run my own instance from latest master branch.
Quick temporary workaround if needed - checkout latest verified version and restart application:
git checkout -b workaround 9ce2c48

Thank you @maslankalm

Duplicate of #318


[Feature] vertical align center visualMap's text with itemSymbol

What problem does this feature solve?

chart: Calendar Heatmap
demo: https://echarts.apache.org/examples/en/editor.html?c=calendar-heatmap
problem: visualMap's text did not vertical aligned center with itemSymbol.

What does the proposed API look like?

should be

It doesn't seem to be wrong on my side with Mac Chrome. This is probably due to font family. The default font of your browser is used when user doesn't provide.


Document API/system design principles and patterns

Related to #5476, #2003, #1007, #5620, and other issues.
The PR creation rate and number of contributors are both growing. In order to scale the effort, we need to better document the patterns we want additions to the system and API to follow, so that we can better parallelize the design and review effort. I'm filing this issue to solicit important principles and patterns to document. I volunteer to create the actual document and/or presentation slides.
What do you think isn't sufficiently covered by existing design docs and/or isn't sufficiently discoverable? What principles/patterns do you find yourself explaining over and over again? What properties would you be unhappy to have violated/degraded/changed by new PRs?
I'm thinking more about reasonably general issues rather than implementation-oriented invariants that apply to very specific/narrow parts of the code.
Examples (some areas, some principles):

Declarative APIs, desired state and current state
Level-based operation: Functionality must be level-based, meaning the system must operate correctly given the desired state and the current/observed state, regardless of how many intermediate state updates may have been missed. Edge-based behavior must be just an optimization.
Status must be 100% reconstructable by observation. Any history kept must be just an optimization and not required for correct operation.
Phase, Reason, Message, Conditions, etc. vs. a single state machine with lots of states
Composable, a la carte functionality
Transparent, no glass to break
More generally, Eric Raymond's 17 UNIX rules
Only the apiserver should communicate with etcd/store, and not other components (scheduler, kubelet, etc.).
Compromising a single node shouldn't compromise the cluster (not that we've achieved that yet)
Components should continue to do what they're told in the absence of new instructions.
Open world assumption: continually verify assumptions and gracefully adapt to external events and/or actors (example: we allow users to kill pods under control of a replication controller; it just replaces them)
Don't assume a component's decisions will not be overridden or rejected, nor for the component to always understand why. For example, etcd may reject writes. Kubelet may reject pods. The scheduler may not be able to schedule pods.
When to use labels vs. annotations vs. object references
Watch vs. polling
Bootstrapping-related principles

Let's brainstorm first, and argue and prioritize afterward.
@smarterclayton @derekwaynecarr @thockin @erictune @lavalamp

Master operations must be constant time.
Cluster-wide invariants are difficult to get right. Try not to add them. If you must have them, don't enforce them atomically in master components, that is contention-prone and doesn't provide a recovery path in the case of a bug allowing the invariant violation. Instead, provide a series of checks to reduce the probability of a violation, and make every component involved able to recover from an invariant violation. Example: scheduler assigning pods to kubelet.
Self-healing components. For example, if you must keep some state (e.g., cache) the content needs to be periodically refreshed, so that if an item does get erroneously stored or a deletion event is missed etc, it will be soon fixed. Ideally on timescales that are shorter than what will attract attention from humans.

Status and spec principles: https://groups.google.com/forum/#!topic/kubernetes-dev/HKg8OD_PNfw

Other things I noticed missing from api-conventions.md:

adequate documentation of watch
subresources
delete options, deletionTimestamp, and graceful termination
list options
object references
selfLink
events

And pod-states.md is woefully out of date (e.g., it references "PodStatus" rather than "PodPhase").

Working on API-visible conventions first.

Another principle: all relevant API info should be represented in json. Relevant HTTP header fields should mirror the json fields. One example that came up just now: status codes (which are represented in Status). We've previously discussed using Etags and If-Match, also. We're going in this direction for URL query parameters, also.


Speed Brawl tiebreaker janky in multiplayer

Sprite direction doesn't seem to work, and you can punch early to push yourself forward while waiting for the timer to end.

Fixed the latter. Former is because compat_clientssendfullbuttoninfo is needed.


404 error is returned for "Edge Nodes - List."

[Enter feedback here]
We are not able to access https://docs.microsoft.com/en-us/rest/api/cdn/edgenodes/list now. 404 error is retunred.
This is needed to confirm IPs of Verizon SKU.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b2d68613-eaa2-12ca-d1e8-8fb2278ed534
Version Independent ID: fb7a90f3-6eee-0d6b-59c5-58041b2c2c86
Content: Retrieve the current POP IP list for Azure CDN
Content Source: articles/cdn/cdn-pop-list-api.md
Service: azure-cdn
GitHub Login: @asudbring
Microsoft Alias: allensu

@taminta, please try this URL "https://docs.microsoft.com/en-us/rest/api/cdn/cdn/edgenodes/list". Also, the doc has been edited accordingly and it would take some time for the changes to get reflect over the doc.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Thanks! New link works for me. Waiting for update on docs.


ncp-uart: Keep track of and report framing errors.

Previously we were simply ignoring frames that contained errors. This
change causes framing errors to be logged to the PROP_STREAM_DEBUG
stream property, so that the event can be logged by the host. The log
message looks like this:
Framing error E: [XX XX XX XX...]

Where E is the ThreadError code, and XX XX... is a hex dump of
no more than the first 42 bytes of the erroneous frame.
A frame error counter is also included, but is not yet being exposed.

LGTM :+1:

LGTM 👍

Please advice,
trying to send to FTD binary block size 1057 bytes over the BORDER ROUTER set  up 460800 baudrate and getting : wpantund[19]: NCP => Framing error 6: [80 03 72 53 04 60 00 00 00 04 2B 11 40 FD DD 00 00 00 00 00 00 0C 00 57 DB 87 F0 88 AA FD DD 00 00 00 00 00 00 F3 BC 7F 57]
If speed is 230400 everything is going smoothly.


added pre-processing checksum functions in hysds/utils.py

@DustinKLo, I've added the configuration needed to integrate circleci to run pull request building. Please update your clone of the HC-34-checksum_validation branch by running git pull. Next, if you click on the Details for the failed circleci test above, you'll see that the  test failed here:
==================================== ERRORS ====================================
_____________ ERROR collecting test/test_preprocessing_checksum.py _____________
ImportError while importing test module '/home/ops/project/test/test_preprocessing_checksum.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/test_preprocessing_checksum.py:10: in <module>
    from test import hashlib_mapper, calculate_checksum_from_localized_file, read_checksum_file, \
E   ImportError: cannot import name 'hashlib_mapper' from 'test' (/opt/conda/lib/python3.7/test/__init__.py)

Please fix your test so that the above check passes. All you need to do make sure it runs on your dev machine then push the commits up to the HC-34-checksum_validation branch. That should trigger circleci to rerun the build/test again.

@pymonger  noted, i didn't change the import statement and add sys.path.insert(0, os.path.join(os.getcwd(), 'hysds'))
but the CircleCI tests pass now 👍

Looks good. key is to walk the localized work dir to find collocated "file.hash_ext" signatures.
To make it perform slightly faster, update def hashlib_mapper(algo) to do the cascade check with the most often used checksum first to make it short out faster. e.g. md5 first.


Expose contributor codes in the creator field

What is this PR trying to achieve?
Make sure we give enough information to credit people for their images in the "Creator" field.
Have the following been considered/are they needed?

[ ] Deployed new versions

Resolves #1162.


Add files via upload

Please, add our school to get free license on your great IDEs that we use in school, but now we need a webstorm too)

@javaInSchool Pull request merged. Thank you!

Thank you!


fix(frontend): Remove redundant join non-eq pullup

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Remove redundant join non-eq pullup
Checklist For Contributors

[X] I have written necessary rustdoc comments
[X] I have added necessary unit tests and integration tests
[X] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
[X] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[X] All checks passed in ./risedev check (or alias, ./risedev c)

I think the pulling up is a kind of optimization because we think the Filter operator can process more efficiently.

Oh, I see, as it is vectorized, correct?

I will add some comments instead so it is clearer.

I think the pulling up is a kind of optimization because we think the Filter operator can process more efficiently.

Possible, Flink has a different strategy than us: https://github.com/risingwavelabs/risingwave/issues/7343#issuecomment-1381456708. Flink has no vectorized execution.

Actually, I notice that the vectorized part is already implemented within the executor for BatchHashJoin.
https://github.com/risingwavelabs/risingwave/blob/7cadc39dffda32a01587a08913591cf9666fe84e/src/batch/src/executor/join/hash_join.rs#L362
Turns out we have not been using this code path :P So let's apply this change for batch hash join after all.

Alright, license-header-check stops working again......
Maybe let @TennyZhuang force merge it after the conflicts are resolved.


AutoregressiveWrapper expects different input lengths based on type

When the AutoregressiveWrapper receives a tensor input, it shrinks the size of the input by one. When it receives non-tensor input it applies padding. This is a bit confusing, since it means you need to provide different size inputs depending on type. Normally this wouldn't matter, but with axial position encoding it expects an exact input length, so it can fail for an input length difference of 1.
        if isinstance(x, torch.Tensor):
            xi, xo = x[:, :-1], x[:, 1:]
            annotations = annotations[:, :-1]
        else:
            xi = pad(list(map(lambda t: t[:-1], x)))
            xo = pad(list(map(lambda t: t[1:], x)))

@tomweingarten Hey! Actually, the current way axial positional encoding is made can take in any sequence length, so that shouldn't be a problem. I agree the AutoregressiveWrapper introduces an area of confusion, since it should accept an input of sequence length + 1, so it can be split into input and output of seq_len -> seq_len. But it should work as is. How are you passing in the training data? As one tensor or an array of tensors?

import torch
from axial_positional_embedding import AxialPositionalEmbedding

x = torch.randn(1, 4095, 512)
emb = AxialPositionalEmbedding(512, axial_shape = (64, 64))
print(emb(x).shape) # (1, 4095, 512)

https://github.com/lucidrains/axial-positional-embedding

You are correct, I had been messing around with the generate function to play with some novel input shapes and forgot I had disabled the Autopadder in the process. I should've tried this on some clean code before reporting :)


[Event Request] Table 37 Sales-Line - OnDeleteOnBeforeTestfieldReservedQtyBase

Hi Team,
In Table 37 we need possibility to have our additional checks. Having event with handling on trigger OnDelete would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnDeleteOnBeforeTestfieldReservedQtyBase(var SalesLine: Record "Sales Line"; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


chore(main): release 0.15.1

:robot: I have created a release beep boop
0.15.1 (2023-06-14)
Bug Fixes

modules/sb-psc-attachment: remove explicit organizations prefix on variable (e4b460f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/apigee/terraform-modules/releases/tag/v0.15.1 :sunflower:


Teleportation with portals (local and remote Juju)

We could make a significant change to Jockey by adding remote connectivity support.
I have encountered success with this in my CVE collection tool here:
https://github.com/johnlettman/jujucvetool/blob/c9ad67ffb43808f40e4bed91f60e86b59d329724/src/jujucvetool/cloud.py#L27-L40
As Jockey currently operates, the change nominally selects local, which only runs commands locally. Implementing the same functionality would only change the existing commands if a remote host is specified. In addition, I was able to handle environments where one needs to assume the role of a different user over SSH to execute Juju commands (e.g., sudo su - jujuadmin):
https://github.com/johnlettman/jujucvetool/blob/c9ad67ffb43808f40e4bed91f60e86b59d329724/src/jujucvetool/cloud.py#L55-L66
In summary, this provides:

remote Juju, no sudo
remote Juju, sudo as someone else
local Juju, no sudo
local Juju, sudo as someone else

... all transparently through the same functions.
This would have interesting implications for specific users who manage many Juju environments across many networks. The tool I am referencing has terrible controller and model selection, but the local/remote functionality seems solid and worth extracting.

I'll leave that to your decision, @LCVcode, but I will self-assign if you give the green light to implement that functionality.

This functionality sounds interesting.  Can you give me an example use case?  I don't think it would be hard to convince me to give this a +1.
Would it be something like juju-jockey --remote<EMAIL_ADDRESS>units?

It's currently in PR #47
but, it looks like this:
juju-jockey --host bastion.site.local --user jlettman --sudo jujuadmin units name~controller

This sounds like a good feature to me.
How would subsequent calls to the same remote juju cluster perform?  I assume that, under the hood, there is an ssh connection established with each juju-jockey remote command.  Therefore, each command would see a delay to establish said connection.  Short of caching remote juju statuses locally, which I definitely do not want to do (at least not by default), might there be a way to keep a session alive across multiple juju-jockey commands?

This sounds like a good feature to me.
How would subsequent calls to the same remote juju cluster perform? I assume that, under the hood, there is an ssh connection established with each juju-jockey remote command. Therefore, each command would see a delay to establish said connection.

They perform reasonably well; however, they all share a single channel. The SSH connection is only explicitly closed with close(), but it will be reused in the meantime.

Short of caching remote juju statuses locally

In my PR, the file cache does store the status, but it is unique to the following keys:

hostname/IP
controller
model

which I definitely do not want to do (at least not by default)

Ope! This could be made tunable.


fix(pci-components-region-list): region update

MANAGER-3036
The region is not being set when only one region is present in a continent.
The region variable is not set correctly so that the select picker is properly displayed when displaySelectedRegion is true.

@ganeshkumar1989 Is there any internal ticket reference related to this pull request?

I just updated the ticket number in the description


[Feature Request] Thumbnails in Power Lora Loader

The Power Lora Loader is great, but there's one key feature that is missing that's keeping me from using it everywhere...
It would be nice if we could have thumbnails and lora info like there is in Pythongosssss lora loader, but for each lora.
Now, I don't know how easy it would be to implement, but throwing out this suggestion here in case it's doable.

I vote for this !
If you use the Power Lora Loader, you have many loras, and it's easier to lose track of their names.
The Pythongosssss lora loader creates 2 files, per lora, in the models folder.
One is for the image thumbnail, and another for extra data.
You can add the thumbnail only on the loras you want ( and you can use the image from Civitai, directly ).
You can also add your own notes, to the lora info !
I'm assuming that everyone that wants this feature already has the Pythongosssss nodes. It's one of the main features.
But the Pythongosssss lora loader, it's for a single lora, and it's even larger than the default loader.
Maybe you could just add a way to read these 2 files, via the Lora Power Loader.
This way the implementation would be easier and we avoid duplicated features / files.

The Power Lora Loader has some new changes coming soon that you folks will probably love :)

I am looking forward to it. If you work on it, maybe it will also be possible to output the Lora names and put them together.
The SD Prompt Saver from the SD Prompt Reader Nodes works very well with your nodes. The Lora model names can be stored in the image.

Okay, just checked out the new changes and it's a nice implementation, but it's lacking some things that the pythongoss loaders have.

vs

Pythongoss version reads tags from the safetensor files, which are usually a lot more than what's listed on the civitai page.
It also lists the base model and clip skip used for training the loras.

Yes, the new dialog is also not the final version. Though, I was curious about the tags from the metadata. Do people actually find that useful? It's so exhaustive, I usually just trust what is outlined on civitai.
Anyway, this isn't the final dialog or power lora loader experience (and why I didn't post in here the last push :)

Okay, well, the information on Civitai can be limited some times, the creators don't always write everything down.
And a trigger word is just the topmost tag used in every training image, other tags are relevant too and allows you to use the lora better.
Idk, maybe I'm one of the few who looks at them, but it's a nice thing to have.

It's pretty close to perfect now, only thing that is missing now is preview images in the lora list.

Just a quick question. With my one PC setup, I can see the thumbnails as you scroll through the Lora list. My other setup has no thumbnails. Do I have to change a setting somewhere? They are both the newest. I update with manager daily.

Just a quick question. With my one PC local ComfyUI setup, I can see the thumbnails as you scroll through the Lora list. My other setup has no thumbnails. Do I have to change a setting somewhere? They are both the newest. I update with manager daily.

The thumbnails are only available in the pythongoss lora loader right now.

Just a quick question. With my one PC local ComfyUI setup, I can see the thumbnails as you scroll through the Lora list. My other setup has no thumbnails. Do I have to change a setting somewhere? They are both the newest. I update with manager daily.

The thumbnails are only available in the pythongoss lora loader right now.

Then I have a magic node, but only on my one machine.

The pythongoss script may be hijacking the menu in one but not the other. Not sure why one case would, though.
I’ll see about adding it to the menu manually. I’m also working out a full-fledged Lora adding experience too.

In my case, the Power Lora Loader (rgthree) is displaying duplicate images, meant for the pythongosssss lora loader.
The image on the right, with the generation data, is the one fetched the Power Lora Loader (rgthree).
The one left is a jpeg. It was created by pythongosssss lora loader, in the lora folder ( with the same name as the lora ).
This image is used by pythongosssss lora loader to display a preview, as we mouseover the lora list ( see posts above ).
But now it's also being displayed by the Power Lora Loader (rgthree).
The Power Lora Loader (rgthree) keeps displaying the duplicated image, even if the jpeg it's deleted on the lora folder.
Is it possible to hide these duplicated jpeg images in the Power Lora Loader (rgthree) ?

The Power Lora Loader is my favourite node ever, as it just cleans up your workflow so much. I do agree that the ability to preview an image in the file selector is such an incredibly useful feature that is missing from the current implementation.
Off topic, but the only other thing on my wishlist would be keep the search bar searching the entire directory recursively.


Browser support

Nice work! any browser support? I mean if i want to use it in my forn-end project?

I don't understand how this is an issue.


Updated versions for ansibleee and telemetry so the latter can trigge…

…r the defaulting of the former

@jlarriba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name 	Commit 	Details 	Required 	Rerun command
ci/prow/openstack-operator-build-deploy 	5da305c link 	true 	/test openstack-operator-build-deploy
Full PR test history. Your PR dashboard.

CI hiccup?
The connection to the server api.oko-09.oooci.ccitredhat.com:6443 was refused - did you specify the right host or port?

/test openstack-operator-build-deploy

@jlarriba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name 	Commit 	Details 	Required 	Rerun command
ci/prow/openstack-operator-build-deploy 	5da305c link 	true 	/test openstack-operator-build-deploy
Full PR test history. Your PR dashboard.

It looks like the Telemetry operator is missing a permission needed for the changes introduced by https://github.com/openstack-k8s-operators/telemetry-operator/pull/108:
[pod/telemetry-operator-controller-manager-f5f69dd85-hqlrh/manager] E0608 15:01:09.486869       1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.26.3/tools/cache/reflector.go:169: Failed to watch *v1beta1.KeystoneAPI: failed to list *v1beta1.KeystoneAPI: keystoneapis.keystone.openstack.org is forbidden: User "system:serviceaccount:openstack-operators:telemetry-operator-controller-manager" cannot list resource "keystoneapis" in API group "keystone.openstack.org" at the cluster scope

Thank you very much, submitted the fix.

@jlarriba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
ci/prow/openstack-operator-build-deploy	af6c59a link	true	/test openstack-operator-build-deploy
Full PR test history. Your PR dashboard.

I have been looking the job output for a while and I dont have a clue on what might be happening here.

@jlarriba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
ci/prow/openstack-operator-build-deploy	af6c59a link	true	/test openstack-operator-build-deploy
Full PR test history. Your PR dashboard.

I have been looking the job output for a while and I dont have a clue on what might be happening here.

It seems like it's the same problem as before:
[pod/telemetry-operator-controller-manager-598874f6f4-hrg4j/manager] E0608 16:26:06.966202       1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.26.3/tools/cache/reflector.go:169: Failed to watch *v1beta1.KeystoneAPI: failed to list *v1beta1.KeystoneAPI: keystoneapis.keystone.openstack.org is forbidden: User "system:serviceaccount:openstack-operators:telemetry-operator-controller-manager" cannot list resource "keystoneapis" in API group "keystone.openstack.org" at the cluster scope

@jlarriba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
ci/prow/openstack-operator-build-deploy	af6c59a link	true	/test openstack-operator-build-deploy
Full PR test history. Your PR dashboard.

I have been looking the job output for a while and I dont have a clue on what might be happening here.

It seems like it's the same problem as before:
[pod/telemetry-operator-controller-manager-598874f6f4-hrg4j/manager] E0608 16:26:06.966202       1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.26.3/tools/cache/reflector.go:169: Failed to watch *v1beta1.KeystoneAPI: failed to list *v1beta1.KeystoneAPI: keystoneapis.keystone.openstack.org is forbidden: User "system:serviceaccount:openstack-operators:telemetry-operator-controller-manager" cannot list resource "keystoneapis" in API group "keystone.openstack.org" at the cluster scope

The import of telemetry-operator/api needs to be bumped to at least: https://github.com/openstack-k8s-operators/telemetry-operator/commit/829eea76002d12834a9e6dec29918f0c04842646

@jlarriba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
ci/prow/openstack-operator-build-deploy	af6c59a link	true	/test openstack-operator-build-deploy
Full PR test history. Your PR dashboard.

I have been looking the job output for a while and I dont have a clue on what might be happening here.

It seems like it's the same problem as before:
[pod/telemetry-operator-controller-manager-598874f6f4-hrg4j/manager] E0608 16:26:06.966202       1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.26.3/tools/cache/reflector.go:169: Failed to watch *v1beta1.KeystoneAPI: failed to list *v1beta1.KeystoneAPI: keystoneapis.keystone.openstack.org is forbidden: User "system:serviceaccount:openstack-operators:telemetry-operator-controller-manager" cannot list resource "keystoneapis" in API group "keystone.openstack.org" at the cluster scope

The import of telemetry-operator/api needs to be bumped to at least: openstack-k8s-operators/telemetry-operator@829eea7

I have pushed the update to the most recent commit.
Where do you see the log trace you are pasting here? It is not in "Details" of the CI job.

Looks like telemetry-operator/api needs a bump again

Damn, I bumped and the forgot to add the files to the commit. I need the weekend.


FR: Align "Name" field across core nodes

This was discussed and agreed with @dceejay (though I am failing to find the issue/thread/discussion)
As it stands, core nodes have random placement of the Name field.
This FR is to propose that the Name field be placed 1st on all core nodes to create a familiar layout.
Example (non exhaustive)
Nodes with Name as 1st field:

Inject
Change
Function
Template
Link-in/out/call

Nodes with Name as last field:

Debug/Catch/complete/status
Exec
Filter
MQTT/TCP
Split/Join/sort/Batch

Nodes with Name in the middle

CSV
XML

This was discussed and agreed with @dceejay (though I am failing to find the issue/thread/discussion)
As it stands, core nodes have random placement of the Name field.
This FR is to propose that the Name field be placed 1st on all core nodes to create a familiar layout.
Example (non exhaustive)
Nodes with Name as 1st field:

Inject
Change
Function
Template
Link-in/out/call

Nodes with Name as last field:

Debug/Catch/complete/status
Exec
Filter
MQTT/TCP
Split/Join/sort/Batch

Nodes with Name in the middle

CSV
XML

Hey Steve,
This is my first time solving open source bug. I have made the name field the first field in every core node. Please correct me if I made any mistakes.


[BugFix]Fix the bug of setting the default value for the float type when creating table

Why I'm doing:
The judgment of the data type after FLOAT DEFAULT is incorrect.
An exception will be thrown when executing create table t_test(a int, b float default "0.1"); :
`mysql> create table t_test(a int, b float default "0.1") properties ( "replication_num" = "1" );
ERROR 1064 (HY000): Getting analyzing error. Detail message: Invalid default value for 'b': Default value will loose precision: 0.1.
`
What I'm doing:
The reason is that the default value is incorrectly determined as the double type by checking whether two floating-point values are equal.
I modified the comparison method of two floating-point data to prevent two numbers from being judged as unequal even if they are the same. The toString methods of Double and Float can be used to accurately compare two floating-point numbers, without being affected by trailing zeros.
`mysql> create table t_test(a int, b float default "0.1") properties ( "replication_num" = "1" );
Query OK, 0 rows affected (0.01 sec)
mysql> insert into t_test(a) values(0);
Query OK, 1 row affected (0.31 sec)
{'label':'insert_b4c9baca-dcfd-11ee-b300-f4e5f2f3828b', 'status':'VISIBLE', 'txnId':'76085'}
mysql> select * from t_test;
+------+------+
| a    | b    |
+------+------+
|    0 |  0.1 |
+------+------+
1 row in set (0.01 sec)
`
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lishaoxun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@ShaoxunLi can you sign the CLA and sign-off contribution by git commit -s

I think this PR is OK, refs: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Double.html#equivalenceRelation
Double compare with Float can't use == or equals


Add generic follower requirement

Certain quests require a cat out, or another follower like Zanik. There should be a requirement which indicates if you have the required follower following you.

Added in https://github.com/Zoinkwiz/quest-helper/commit/ca1cd5a933e42056d593f2e18f6ab1231bfbc2f3.

Added in https://github.com/Zoinkwiz/quest-helper/commit/ca1cd5a933e42056d593f2e18f6ab1231bfbc2f3.


'unconfirmed_email' is looked for even when reconfirmable is not enabled

'unconfirmed_email' is referenced to even when the reconfirmable module is not enabled.
Is reconfirmable enabled by force?
My gem versions:

rails 3.2.11
warden 1.2.1
devise 2.2.3

The following is what I did:

Added devise to a new project
Enabled 'confirmable' in the user model and uncommented confirmation_token, confirmed_at and confirmation_sent_at but NOT unconfirmed_email in the migration
Migrated database
Registered a new user
Visited the site back with confirmation token
Then I get the error: undefined local variable or methodunconfirmed_email' for #User:0x007f3a986d5fe0`

Full backtrace:
activemodel (3.2.11) lib/active_model/attribute_methods.rb:407:in method_missing'
activerecord (3.2.11) lib/active_record/attribute_methods.rb:149:in method_missing' devise (2.2.3) lib/devise/models/confirmable.rb:62:in block in confirm!'
devise (2.2.3) lib/devise/models/confirmable.rb:184:in pending_any_confirmation' devise (2.2.3) lib/devise/models/confirmable.rb:52:in confirm!'
devise (2.2.3) lib/devise/models/confirmable.rb:243:in confirm_by_token' devise (2.2.3) app/controllers/devise/confirmations_controller.rb:20:in show'
actionpack (3.2.11) lib/action_controller/metal/implicit_render.rb:4:in send_action' actionpack (3.2.11) lib/abstract_controller/base.rb:167:in process_action'
actionpack (3.2.11) lib/action_controller/metal/rendering.rb:10:in process_action' actionpack (3.2.11) lib/abstract_controller/callbacks.rb:18:in block in process_action'
activesupport (3.2.11) lib/active_support/callbacks.rb:436:in _run__4433409612632964203__process_action__2722864610698420226__callbacks' activesupport (3.2.11) lib/active_support/callbacks.rb:405:in __run_callback'
activesupport (3.2.11) lib/active_support/callbacks.rb:385:in _run_process_action_callbacks' activesupport (3.2.11) lib/active_support/callbacks.rb:81:in run_callbacks'
actionpack (3.2.11) lib/abstract_controller/callbacks.rb:17:in process_action' actionpack (3.2.11) lib/action_controller/metal/rescue.rb:29:in process_action'
actionpack (3.2.11) lib/action_controller/metal/instrumentation.rb:30:in block in process_action' activesupport (3.2.11) lib/active_support/notifications.rb:123:in block in instrument'
activesupport (3.2.11) lib/active_support/notifications/instrumenter.rb:20:in instrument' activesupport (3.2.11) lib/active_support/notifications.rb:123:in instrument'
actionpack (3.2.11) lib/action_controller/metal/instrumentation.rb:29:in process_action' actionpack (3.2.11) lib/action_controller/metal/params_wrapper.rb:207:in process_action'
activerecord (3.2.11) lib/active_record/railties/controller_runtime.rb:18:in process_action' actionpack (3.2.11) lib/abstract_controller/base.rb:121:in process'
actionpack (3.2.11) lib/abstract_controller/rendering.rb:45:in process' actionpack (3.2.11) lib/action_controller/metal.rb:203:in dispatch'
actionpack (3.2.11) lib/action_controller/metal/rack_delegation.rb:14:in dispatch' actionpack (3.2.11) lib/action_controller/metal.rb:246:in block in action'
actionpack (3.2.11) lib/action_dispatch/routing/route_set.rb:73:in call' actionpack (3.2.11) lib/action_dispatch/routing/route_set.rb:73:in dispatch'
actionpack (3.2.11) lib/action_dispatch/routing/route_set.rb:36:in call' actionpack (3.2.11) lib/action_dispatch/routing/mapper.rb:42:in call'
journey (1.0.4) lib/journey/router.rb:68:in block in call' journey (1.0.4) lib/journey/router.rb:56:in each'
journey (1.0.4) lib/journey/router.rb:56:in call' actionpack (3.2.11) lib/action_dispatch/routing/route_set.rb:601:in call'
warden (1.2.1) lib/warden/manager.rb:35:in block in call' warden (1.2.1) lib/warden/manager.rb:34:in catch'
warden (1.2.1) lib/warden/manager.rb:34:in call' actionpack (3.2.11) lib/action_dispatch/middleware/best_standards_support.rb:17:in call'
rack (1.4.4) lib/rack/etag.rb:23:in call' rack (1.4.4) lib/rack/conditionalget.rb:25:in call'
actionpack (3.2.11) lib/action_dispatch/middleware/head.rb:14:in call' actionpack (3.2.11) lib/action_dispatch/middleware/params_parser.rb:21:in call'
actionpack (3.2.11) lib/action_dispatch/middleware/flash.rb:242:in call' rack (1.4.4) lib/rack/session/abstract/id.rb:210:in context'
rack (1.4.4) lib/rack/session/abstract/id.rb:205:in call' actionpack (3.2.11) lib/action_dispatch/middleware/cookies.rb:341:in call'
activerecord (3.2.11) lib/active_record/query_cache.rb:64:in call' activerecord (3.2.11) lib/active_record/connection_adapters/abstract/connection_pool.rb:479:in call'
actionpack (3.2.11) lib/action_dispatch/middleware/callbacks.rb:28:in block in call' activesupport (3.2.11) lib/active_support/callbacks.rb:405:in _run__2937362337909674586__call__4153307002548070508__callbacks'
activesupport (3.2.11) lib/active_support/callbacks.rb:405:in __run_callback' activesupport (3.2.11) lib/active_support/callbacks.rb:385:in _run_call_callbacks'
activesupport (3.2.11) lib/active_support/callbacks.rb:81:in run_callbacks' actionpack (3.2.11) lib/action_dispatch/middleware/callbacks.rb:27:in call'
actionpack (3.2.11) lib/action_dispatch/middleware/reloader.rb:65:in call' actionpack (3.2.11) lib/action_dispatch/middleware/remote_ip.rb:31:in call'
actionpack (3.2.11) lib/action_dispatch/middleware/debug_exceptions.rb:16:in call' actionpack (3.2.11) lib/action_dispatch/middleware/show_exceptions.rb:56:in call'
railties (3.2.11) lib/rails/rack/logger.rb:32:in call_app' railties (3.2.11) lib/rails/rack/logger.rb:16:in block in call'
activesupport (3.2.11) lib/active_support/tagged_logging.rb:22:in tagged' railties (3.2.11) lib/rails/rack/logger.rb:16:in call'
actionpack (3.2.11) lib/action_dispatch/middleware/request_id.rb:22:in call' rack (1.4.4) lib/rack/methodoverride.rb:21:in call'
rack (1.4.4) lib/rack/runtime.rb:17:in call' activesupport (3.2.11) lib/active_support/cache/strategy/local_cache.rb:72:in call'
rack (1.4.4) lib/rack/lock.rb:15:in call' actionpack (3.2.11) lib/action_dispatch/middleware/static.rb:62:in call'
railties (3.2.11) lib/rails/engine.rb:479:in call' railties (3.2.11) lib/rails/application.rb:223:in call'
rack (1.4.4) lib/rack/content_length.rb:14:in call' railties (3.2.11) lib/rails/rack/debugger.rb:20:in call'
railties (3.2.11) lib/rails/rack/log_tailer.rb:17:in call' rack (1.4.4) lib/rack/handler/webrick.rb:59:in service'
/home/bv/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/webrick/httpserver.rb:138:in service' /home/bv/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/webrick/httpserver.rb:94:in run'
/home/bv/.rvm/rubies/ruby-1.9.3-p327/lib/ruby/1.9.1/webrick/server.rb:191:in block in start_thread'

Have you disabled this option? https://github.com/plataformatec/devise/blob/master/lib/generators/templates/devise.rb#L107

Since Devise has changed a lot in these years, adding this comment to point to the original reference.
https://github.com/heartcombo/devise/blame/8e0327e2031985e7888b0c4bc87a450377bed886/lib/generators/templates/devise.rb#L111


docs: update code to es6 and highlight

Update code examples in docs

const/let instead of var
for of
arrow functions

Use highlight.js to highlight code in docs.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


PAINT_007_001 Testcases fail because Dialogbox got moved

Dialogbox got moved into an own class.
Now all Testcases from #16 fail.

Fixed with commit #d490639


Random function is not working for tranforms

Several plots use _groubpy function in /utils/transforms.py to groupby various functions, including random, but that's not working.

This seems to be fixed but will keep it on until 100% sure it actually is.


FRONTEND: A web page that takes in a finite magma (in some standardized format), and returns the equations obeyed or not obeyed by this magma.

If this submitted magma generates new anti-implications, instructions would be given on how to submit it as a PR.  (I assume permitting direct submission to the repository would be a security risk, and possibly not even technically feasible even with admin privileges.)
The web page could provide some sample finite magmas as examples to illustrate the tool.
The equations listed can be linked to their corresponding pages on https://teorth.github.io/equational_theories/implications/

cliam

This is great!  It can certainly go into the main repository (or stay external, depending on what you prefer).

Thank you very much for your contributions @zaklogician, both in general and for your work on the FME in particular.
Your proposal makes a lot of sense, and I completely agree that we should keep the FME source in this repository to maximise compatibility, maintainability, and ensure integrated future development.
In terms of organisation, at the moment we only have a scripts folder, which is typically reserved for independent utilities or quick tests.
It's very typical (and I would say best practice) in open-source projects to reserve the tools or the libraries (libs is very common) for library-, package-, or tool-level code which is exactly the case of FME.
In this specific case I believe the best approach would be to create a tools/FiniteMagmaExplorer or tools/FME directory for the FME source, where it can function as a project-specific tool. Its compiled HTML+JS output can then be placed in the dedicated home_page folder, as you suggested, to integrate smoothly with the website.

propose PR #468

I'm assisting there. I'm setting up my local env to be able to serve Jekyll sites comfortably.