Security bulletins - markdown formatting issues

🛑 IMPORTANT: You can get your feedback addressed faster if you use the comment section for the article in which you encountered a problem.
Link to article:
https://docs.microsoft.com/en-us/security-updates/securitybulletins/2012/ms12-020#severity-ratings-and-vulnerability-identifiers
Problem:
Markdown formatting after the table and at the bottom is not displayed correctly.

Other problems
Link to article:
https://docs.microsoft.com/en-us/security-updates/securitybulletins/2017/ms17-010#affected-software-and-vulnerability-severity-ratings
Problem:
The table headers are not formatted correctly as bolded , compare to https://docs.microsoft.com/en-us/security-updates/securitybulletins/2012/ms12-083
Also, on https://docs.microsoft.com/en-us/security-updates/securitybulletins/2012/ms12-083#affected-and-non-affected-software the links in the table are not rendered correctly

@v-hearya Can you please take a look at this issue?

Similar issue with https://docs.microsoft.com/en-us/security-updates/SecurityAdvisories/2015/3033929

It's weird that the localization repos are open, but not the english https://github.com/MicrosoftDocs?utf8=✓&q=security-updates&type=&language=
But it also looks like they stopped updating content on that site a year ago

also in https://docs.microsoft.com/en-us/security-updates/securitybulletins/2014/ms14-068 , markdown formatting in the table is not rendered

also affects - https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2010/ms10-092


Automatically convert Mattermost Markdown to Jira formatting

REPRO:

Enable and configure the plugin with instructions at https://github.com/mattermost/mattermost-plugin-jira
As a user, connect your account in Mattermost to Jira by posting /jira connect
As a user, hover over a message, click the "More Actions" (...) post menu option, then select "Create Jira Issue".
Complete the steps to create a Jira issue.
As a user, hover over a message, click the "More Actions" (...) post menu option, then select "Attach to Jira Issue"
Complete the steps to attach the chosen message to a Jira issue.

Observed: Mattermost Markdown is not converted to Jira formatting, breaking the appearance of the issue in Jira. Few of these cases are listed below.
Proposed change: When a Jira issue is created or a message is attached to Jira, automatically convert Mattermost Markdown to Jira formatting.

CASES: (See https://mattermost.atlassian.net/browse/MM-15723 for the original ticket)

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please  join our "Plugin: Jira" community channel.
New contributors please see our Developer's Guide and our Plugins Guide.

I would like to work on this.

Awesome, thank you!!
cc @aaronrothschild @levb

Example of undesirable UX when going from Mattermost -> Jira. Headers are converted to lists. Lists that are numbered with just 1. are expected to automatically enumerate, but instead are just rendered as 1. for each item.
Source post:
https://community-daily.mattermost.com/core/pl/eoydjca6upy6mfq7qxx56r67bh
# LDAP group unique identifier and filter user errors

## Summary

There is a class of potential issues caused by user error related to unique identifiers and/or filters with LDAP group sync.  Doing one of the following can cause issues:

1. Changing the configured value of `LdapSettings.GroupIdAttribute` in Mattermost
1. Changing the configured value of `LdapSettings.GroupFilter` in Mattermost
1. Changing the value of group(s) unique identifier on the LDAP side

## Potential Issues

1. Groups are soft-deleted
1. For group-synced teams, team members records are soft-deleted
1. For group-synced teams, **all `ChannelMembers` records are hard-deleted** for that team (same as if you click "Leave Team" in the main menu)
1. For group-synced channels, **`ChannelMembers` records are hard-deleted** (same as if you click "Leave Channel" in the channel menu)

Result in Jira:

Expected in rendered properly in GitHub:
LDAP group unique identifier and filter user errors
Summary
There is a class of potential issues caused by user error related to unique identifiers and/or filters with LDAP group sync.  Doing one of the following can cause issues:

Changing the configured value of LdapSettings.GroupIdAttribute in Mattermost
Changing the configured value of LdapSettings.GroupFilter in Mattermost
Changing the value of group(s) unique identifier on the LDAP side

Potential Issues

Groups are soft-deleted
For group-synced teams, team members records are soft-deleted
For group-synced teams, all ChannelMembers records are hard-deleted for that team (same as if you click "Leave Team" in the main menu)
For group-synced channels, ChannelMembers records are hard-deleted (same as if you click "Leave Channel" in the channel menu)

I reproduced this without mattermost... by making requests to the Jira API I could create issues with Markdown description that could be well rendered anywhere else except on Jira. What's the status of this issue ?

@hervinhio I'm not sure how recently it's been worked on but @nathanmkaya is working on the implementation for this here https://github.com/nathanmkaya/goldmark-extended

Closing issues due to inactivity. This issue can be re-opened with more interest from our community.


Add MIT license.

Coverage remained the same at 100.0% when pulling a2a7a5f3ab4f5a898122e44b820615bfab9accf9 on add-license into fecbbb6b99d4b0e17d878d6aefb2c341db666fb3 on master.


[Bug]: fix example notebooks for v0.2.0

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
example notebooks are not working for v0.2.0
Expected Behavior
No response
SDK Version I encountered this issue in
jquants-api-client-python v0.2.0
Steps To Reproduce
run example notebooks using Google Colab

Filled out the Steps to Reproduce section?

[X] I have entered valid steps to reproduce my issue or have attached a minimally reproducible case in code that shows my issue happening; and understand that without this my issue will be flagged as invalid and closed after 30 days.

Anything else?
No response

need to fix:

https://github.com/J-Quants/jquants-api-client-python/blob/main/examples/20220825-001-price-movement.ipynb
https://github.com/J-Quants/jquants-api-client-python/blob/main/examples/20220825-002-sector.ipynb
https://github.com/J-Quants/jquants-api-client-python/blob/main/examples/20220927-005-jquants-api-starter.ipynb

https://github.com/J-Quants/jquants-api-client-python/issues/38
Created an issue ticket for https://github.com/J-Quants/jquants-api-client-python/blob/main/examples/20220927-005-jquants-api-starter.ipynb


Violentmonkey new metadata @inject-into for CSP restricted pages

Details: https://violentmonkey.github.io/2018/11/23/inject-into-context/

Thanks for the pointer. Sounds like we want to use @inject-into content or @inject-into auto to circumvent CSP. Drawback is no access to the page's own JS objects, but we don't need those, as far as I'm aware.


Document project management workflows

In the interest of more efficient and aligned project management, I created some basic structure and useful labels in our project view to prioritize and balance our work. It will be helpful for the team to understand how best to use these by documenting the most common workflows.

@aapeliv Should I close this one? Anything we need to remember from here?


Bills

Website Link
Due Date
Set Amount or different each month/payment
Recurring

be able to mark paid/ overdue/ autopay


Is there any solution to deploy database easily and create backup while still keeping it flexible.

Thanks @Parth909 ! I also need solution for replication but this is a good starting point


Add RFmx Demod system spot tests.

What does this Pull Request accomplish?
Add RFmx Demod system spot tests.
Why should this Pull Request be merged?
AB#2341128
What testing has been done?
Built and run RFmx Demod system tests:

FYI @zhqinbo , I have a PR up to fix the failing CI: https://github.com/ni/grpc-device/pull/901

@zhqinbo  , submitted #901 but the PR builds uses the .github/... actions from the PR branch and not from main so you'll need to merge main to get the CI fixed here.


No class def found error

Also an ERROR occurs in server.log file . I do not know if this is the same problem:
[2017-02-27T14:48:51.002+0100] [glassfish 4.1] [ERROR] [] [org.hibernate.resource.transaction.internal.SynchronizationRegistryStandardImpl] [tid: _ThreadID=228 _ThreadName=p: thread-pool-1; w: 27] [timeMillis:<PHONE_NUMBER>002] [levelValue: 1000] [[
HHH000260: Exception calling user Synchronization [org.hibernate.search.backend.impl.EventSourceTransactionContext$BeforeCommitSynchronizationDelegator@4edc024f] : java.lang.NoClassDefFoundError: org/apache/commons/lang3/StringUtils]]

The error has not been noticed again.

Checked on Windows Server 2016, jdk1.8u121, glassfish 4, build: BES_MASTER_DELIVERY-10192017/04/20 in SAML mode. I have been checking it since a few days on different builds. I've got no errors in log file.


githubCodeSync: incremental syncing

Fixes #3107

Make codeSyncWorkflow signal based (10s debounce)
Introduce GithubCodeRepository to track last sync times
Signal the code syncing workflow based on PR webhooks only if repo was not synced for 8h

(the last step can race but since we debounce 10s the workflow, this will result in at most one workflow being started every 8h + no error if there are PR merge events racing through the code path)
Deploy:

deploy connectors-edge, run init_db
deploy connectors

Not sure the signalling / debouncing logic is necessary since 2 workflows with the same id can't run at the same time AFAIU? (workflow execution acts as a lock)


Broken links on doc for manual reporting

The two links on the Manual Reporting page are broken.
The current links from manual-reporting.md:

https://github.com/OpenCollective/opencollective-api/blob/master/templates/emails/group.monthlyreport.hbs
https://github.com/OpenCollective/opencollective-api/blob/master/cron/monthly/email-report.js#L30

It looks like the correct links should be:

https://github.com/opencollective/opencollective-api/blob/master/templates/emails/collective.monthlyreport.hbs
https://github.com/opencollective/opencollective-api/blob/master/cron/monthly/collective-report.js

Fixed in https://github.com/opencollective/documentation/pull/73


Response code is 403. Body: Something went wrong. Please report issue.

error : Response code is 403. Body: Something went wrong. Please report issue.
on    getMediasByUserId();
Please help me!

Use the quick fix from @AsgharRehman https://github.com/postaddictme/instagram-php-scraper/pull/335
In the vendor/raiym/instagram-php-scraper/src/InstagramScraper/Instagram.php file in the vendor folder change the generateHeaders method to this:
`/**
* @param $session
*
* @return array
*/
private function generateHeaders($session)
{
$headers = [];
if ($session) {
$cookies = '';
foreach ($session as $key => $value) {
$cookies .= "$key=$value; ";
}
$headers = [
'cookie' => $cookies,
'referer' => Endpoints::BASE_URL . '/',
'x-csrftoken' => $session['csrftoken'],
];
} else {
$headers = ['cookie' => 'Content-Type:application/x-www-form-urlencoded; sessionid=IGSC020ee8ab76d1e8b01223ab92304cbcd58075ce0bdbc771e872b77046bd82cf40:KXP3eyA1gJybewPt4CDR6ICsiF1y99Eq:{"_auth_user_id":7204036595,"_auth_user_backend":"accounts.backends.CaseInsensitiveModelBackend","_auth_user_hash":"","_platform":4,"_token_ver":2,"_token":"7204036595:iWyZVjjdX5sVFV5VsozthzDCIzBh0muN:99a84e59d3aa505f433844956d47d95e4bf095a24a6e1e397f2418c6384671d2","last_refreshed":1523431960.5035405159}; ',
];
}
    if ($this->getUserAgent()) {
        $headers['user-agent'] = $this->getUserAgent();
    }

    return $headers;
}`

This will work

I have the same problem.

@RobertGrubb exactly!

now already started to work without fixing ...bizarre

@aslan93 Yeah, it seems that they rolled back the public endpoint. We'll have to wait and see what they decide in the end to keep.

?__a=1 working put the problem with paging :(

¿Could someone fix this problem?

?__a=1 is not public anymore, it now requires Auth.

@cseesea  yes for now :(

Have a look at pgrimaud/instagram-user-feed

Hi, this is not actually working for me. I am getting 403 errors


Future proof parseTwoDigitYear

Makes parseTwoDigitYear dynamically work out date instead of relying on the year being between 1968 and 2068

This doesn't seem like a good idea. It creates additional API subtleties that will cause confusion if someone fiddles with their clock. In exchange, it will behave closer to expectations in like 2090. I think we can just wait until then and if Moment still exists (gasp), our grandchildren can fix it. In addition, it changes the current behavior without real benefit, eliminates tests without replacing them, and introduces an unknown performance penalty.


Indicates a name that was specified as a remote computer name is syntactically invalid.

Solved

how Solved?


PATCH method on "/api/v2/firewall/nat/port_forward" , always getting error in "associated_rule_id" field.

Describe the bug
PATCH method on "/api/v2/firewall/nat/port_forward" , always getting error in "associated_rule_id" field.
curl -X 'PATCH' \
  'http://x.x.x.x/api/v2/firewall/nat/port_forward' \
  -H 'accept: application/json' \
  -H 'Authorization: Basic xxxxx' \
  -H 'Content-Type: application/json' \
  -d '{
  "id": 0,
  "disabled": true,
  "associated_rule_id": "nat_669e4fc9db81b5.86263762",
}'

associated_rule_id gotten from /api/v2/firewall/nat/port_forwards
{
  "code": 400,
  "status": "bad request",
  "response_id": "FIELD_INVALID_CHOICE",
  "message": "Field `associated_rule_id` must be one of [, pass]",
  "data": []
}.

To Reproduce
Steps to reproduce the behavior:

Go to pfsense api/documentation
Click on /api/v2/firewall/nat/port_forwards and execute
Get 'id' and 'associated_rule_id' of needed rule
Click on /api/v2/firewall/nat/port_forwards and execute
fill test json fields:
id,
associated_rule_id (because we cant go without it, but no reference about it in doc),
disabled
See error

by the way everything is the same with python requests.
Expected behavior
not changing unnecessary fields.
if it really needed: using associated_rule_id from pfsense NAT rule or firewall rule id
Screenshots or Response
pfSense Version & Package Version:

pfSense Version: 2.7.2-RELEASE
Package Version v2.0.2

Affected Endpoints:

URL: /api/v2/firewall/nat/port_forwards
URL: /api/v2/firewall/nat/port_forward

Thanks in advance! Totaly cool pkg, by the way, really appreciate your work!

This would be expected behavior as of right now. This endpoint currently only supports pass or an empty string (for unassociated filter rules) as the associated_rule_id:

If you added the port forward from the webConfigurator and set the 'Filter rule association' to 'Create a new associated filter rule', the endpoint will not accept the update until the associated_rule_id is changed to an option allowed by the REST API. You receive the error even with a partial update because the entire object still must be revalidated after any value changes to ensure there are no conflicts between existing values and changed values.
There is an open feature request (#275) to allow associated filter rules which should be picked up for v2.1.0. You can follow that issue for any updates.
Thanks!

Thanks for explanation. I'll follow that request


Limited to the number of Opp. record types to exclude from Payment records auto-creating

Please see error message.

Hi @paulbfischer, we don't typically support our products here in GitHub. Instead, can you please post this in the Power of Us Hub, in the Nonprofit Success Pack group? The community can help troubleshoot the problem, and if it does turn out to be a repeatable bug, we can create an issue to log it in our backlog.
Thanks!

@paulbfischer Just found your post (and David's reply) in the Hub. https://powerofus.force.com/0D51E00004kVhC2
We need quite a bit more information to properly log an Issue (exact steps to repeat, etc.) and to first prove that it happens in an independant org rather than just your org. I'll do some investigation and create a new issue to log it if we can repeat.

@paulbfischer Unfortunately the limit of 255 characters is the max allowed therefore cannot be modified at this time. Please consider reducing the size of each Record Type name, or the number of record types in your org to fit the limit.
Hub threads
https://powerofus.force.com/0D51E00004kVhC2
https://powerofus.force.com/0D58000004WGESU


Deleting any account deletes the logged-in admin account.

So I was trying to delete a user from my umami install, and when I clicked delete, it deleted my own account instead, causing me to lose the websites I had under my account. It wasn't super important, so it wasn't too bad, and the session still worked, so I could recreate a non-admin account and give it admin rights by connecting to the database.
I created a second admin account to verify it didn't delete the first admin account, but it seems that it deletes the logged in admin account, no matter the account that is sent to the API.

Also, once the account is deleted, the session still works, oddly enough, even after closing the browser. The account can still add websites under any account, other than the admin ones, and can still view any stats from any websites.

Confirming bug.  Will have a fix out by tomorrow.

Thanks, really appreciate it 😅 I'm happy that I didn't have anything important on there haha

Fixed in v1.39.4.


Basic Auth Fail

Where curl succeeds:
curl -L<EMAIL_ADDRESS>
request fails:
>
var request = require('request'),
  url = require('url'),
  uri = url.parse('https://XXXX:XXXX@build.phonegap.com/api/v1/apps/63320/android');

console.log(uri);
request({url: uri}, function(err, res) {
  console.log(res);
});

<
{
  ...
  body: '<?xml version="1.0" encoding="UTF-8"?>\n<Error>InvalidArgument<Message>Unsupported Authorization Type</Message><ArgumentValue>Basic YWRhbS5jcmFidHJlZUBwYWxtLmNvbTpuZXdwYXNzd29yZA==</ArgumentValue><ArgumentName>Authorization</ArgumentName><RequestId>1099F84E8B9EC52C</RequestId><HostId>OleJHmIQkg76G98H8xngear3Ojo7fjpc7Id0GMoCqJvD5JKt/pilSnY4LFV1ylCf</HostId></Error>'
  ...
}

Obviously this could be a build.phonegap.com issue, but at first blush it seems to be more an Auth header issue.

can you give me the verbose curl output?

https://gist.github.com/1649844

hrm.... that looks like exactly what we do. BTW, you don't need to pre-parse the URI.
try this.
var r = request(url)
r.on('response', function () {console.log(r.headers.authorization)})

Compare that with the header you can see in the curl debug output.

Whoops. Looks like I didn't include 80% of the curl output. Updated the gist:
https://gist.github.com/1649844
Result (from your snippet):
Basic YWRhbS5jcmFidHJlZUBwYWxtLmNvbTpuZXdwYXNzd29yZA==

Header dump from res object:
_header: 'GET /android.phonegap/slicehost-production/apps/63320/PhoneGap_GettingStarted-debug.apk HTTP/1.1\r\nCookie: _okapi_2_session=BAh7ByIbd2FyZGVuLnVzZXIucGVyc29uLmtleVsIIgtQZXJzb25bBmkCCIQiIiQyYSQxMCRsUWVjMUFjVzdWUm9UTE1CWkF5RTEuIg9zZXNzaW9uX2lkIiU2NjI1ZjA2MDljMTgzYjBmODJkOTRkMmRiYTQxZjE1ZA%3D%3D--1cabde9030b443daf316daddf1b2507bec795771\r\nauthorization: Basic YWRhbS5jcmFidHJlZUBwYWxtLmNvbTpuZXdwYXNzd29yZA==\r\ncontent-length: 0\r\nhost: s3.amazonaws.com\r\nConnection: keep-alive\r\n\r\n',

looks like they match, doesn't seem to be an auth issue.
@alunny having auth issues to build.phonegap with request, thoughts?

I'll dig into this more over the weekend. I just wanted to get it out there to maybe get a lead on where to look or see if it was a known issue with a workaround.

That request (to download an Android binary) redirects from build.phonegap.com to a URL hosted by S3, with headers like the following:
Location: http://s3.amazonaws.com/android.phonegap/slicehost-production/apps/99999/SomeApp-release.apk
Status: 302

It looks like request is forwarding the build.phonegap.com auth headers to s3.amazonaws.com, which doesn't like them.
Not sure what the spec suggests in this case - maybe there's a header we should be returning in these cases.

A quick look here - http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.8 - suggests request is at fault. A different host on a different protocol should not be considered the same realm. This matches my intuition - there's no reason to think the auth credentials for one host should be valid for a different one.

hrm....
There are lots of places request, and other HTTP clients, disregard the RFC behavior because it's unexpected behavior for a client you would use in code.
I'm wondering if this is one of those cases. If you set a user/pass in a programming client to you expect it to drop those options on redirect?
For now, the fix for @CrabDude is to run with redirects:false and grab the location and make a new request without auth.

I'd argue that dropping the user/pass for a redirect to a different host is the expected behavior - it's certainly what web browsers do. I'm not sure of a use case where you would want to assume the auth mechanism for host A is the same as the auth mechanism for host B.
That said, the workaround is trivial enough that further bikeshedding can be postponed :)

FWIW, behavio consistent with curl is certainly consistent with the law of least surprise.

I'm inclined to agree. We can just blow away the header if host !== newhost when we blow away the host header.

Dude I totally use newpassword as my password too!!! :)

Lol. Damn. Did I leave the password in there again?? Or are you just recognizing the hash?

Basic auth is just a hash, it's only secure talking to phonegap because it's https and the whole socket is encrypted :)


fix: fixing ready messages when using commitsOnly or titleOnly

Use case
In my config:
titleOnly: true

I have a repo configured to only squash commit PRs and because of this, the title should always be valid.
I had a PR with some semantic commits but not a semantic title.
This PR should be blocked as the commits don't matter to me, only the title.
The status was OK, my PR got blocked.
But, the description was incorrectly showing: Pending — ready to be merged or rebased
When it should display: Pending — add a semantic PR title

Nice catch! Thanks for the PR, and apologies for the delay in reviewing it. This will deploy automatically and should be live soon.

No problem!
Thanks!


Create GitHub Page for easy access to documentation

You know, github.io and stuff.
Right now directly from browser we can only look at raw HTML...

Thank you for the suggestion.  We will be adding better browsable documentation soon, but the Facebook open source organization on GitHub is not currently set up to use GitHub Pages.
The raw.txt version should be pretty usable and has all the same information, and you can always download and view the HTML version locally. Apologies for the inconvenience.


How to use swipe directive?

How to use swipe directive?
md-swipe-left="onSwipeLeft()"

is not working

@gkucmierz You should follow the issue template and provide a plunker for your issue. Otherwise it will probably get removed.
Issue Template

Ok, you can remove it.
I have question actually, not an issue.

@gkucmierz I can't remove it, because I'm no Member of this repository. You can close it yourself and ask your question here: https://gitter.im/angular/material2


fix: allow OCI model folders

This fix allows to download OCI artifacts which contains files in a given folder structure.

Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Functional tests have been added, if necessary.
[ ] E2E Workflow tests have been added, if necessary.

@dolfim-ibm please rebase - the CI should be fixed now

@jaideepr97 rebase done


[Release] sdk/resourcemanager/privatedns/armprivatedns/1.3.0

https://github.com/Azure/sdk-release-request/issues/5464

@Mitse1n please check the config and regen the code.


Presets

I was wondering, would it be possible to add profiles to the plug in?
I know my settings for 1070, 1080, and 1660. but I woudl love if there was a drop down that allowed me to save this in a fiel and apply it back.
My question is, is this something that is supported by obs? Could I or someone else code it in to the plug in?
Or maybe a small text input that sets all settings based on the string That was added? like a save point for old games.
Just wondering bouncing an idea.

My question is, is this something that is supported by obs?

OBS supports profiles which allow you set things per profile.

Or maybe a small text input that sets all settings based on the string That was added?

The custom settings field technically allows for this.

OBS supports profiles which allow you set things per profile.

I will look into this

The custom settings field technically allows for this.

Yeah but it doesn't allow you to do quick changes to the settings nor does it allow you to see it represented physically, I meant like a string of chars I could paste into a box and it would set every setting, slider, and checkbox to the correct value from the string pasted. Kind of a way to share the settings, or saving those settings.

All the sliders, dropdowns etc do is set the things that can be set via custom settings anyway. The Custom Settings have higher priority, so they override anything set above them. There were plans for an import/export function, but that was scrapped as it is way too much work - either deal with the Custom Settings, or use the OBS provided profiles for presets.


Download is not working

Visual Studio Code Version : [ 1.6 ]
Code Sync Settings Version : [ 2.3.5  ]
Operating System : [ 10.0]
Occurs On: [Upload / Download]

any exception ? provide the steps.

Press Shift + Alt + D
Enter the github account and click enter.
Enter Your GIST ID  and click enter.
vs code display error message that
BTW i solve my issue by replacing [syncSettings.json] file
that exist in %appdata%\code\user\syncSettings.json


home-assistant-cli: fix shell completions

Description of changes
Shell completions weren't installed, presumably because they were in the midst of a refactor. This installs them back.

Installed shell completions using the installShellCompletion nixpkgs helper.
Reformatted file using nixfmt-rfc-style
Got rid of with lib inside meta

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please split that into 3 commits.

Installed shell completions using the installShellCompletion nixpkgs helper.

Reformatted file using nixfmt-rfc-style

Got rid of with lib inside meta

Please split that into 3 commits.

Installed shell completions using the installShellCompletion nixpkgs helper.
Reformatted file using nixfmt-rfc-style
Got rid of with lib inside meta

Split done.


undefined method `gsub' for #Object:0x00000001edb218 (NoMethodError)

Hello minitest-reporters friends,
Occasionally my test suite will fail with the above error, and here's the stack trace:
/var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-reporters-1.1.13/lib/minitest/reporters/spec_reporter.rb:46:in `record_print_status': undefined method `gsub' for #<Object:0x00000001edb218> (NoMethodError)
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-reporters-1.1.13/lib/minitest/reporters/spec_reporter.rb:31:in `record'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-reporters-1.1.13/lib/minitest/minitest_reporter_plugin.rb:21:in `block in record'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-reporters-1.1.13/lib/minitest/minitest_reporter_plugin.rb:20:in `each'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-reporters-1.1.13/lib/minitest/minitest_reporter_plugin.rb:20:in `record'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:674:in `block in record'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:673:in `each'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:673:in `record'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-hooks-1.4.0/lib/minitest/hooks/test.rb:97:in `rescue in with_info_handler'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-hooks-1.4.0/lib/minitest/hooks/test.rb:68:in `with_info_handler'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:308:in `run'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:158:in `block in __run'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:158:in `map'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:158:in `__run'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:135:in `run'
	from /var/autotest/vendor/bundle/ruby/2.1.0/gems/minitest-5.10.1/lib/minitest.rb:62:in `block in autorun'

I patched line 46 so that we check that the object supports gsub (basically a return unless test.name.class.public_instance_methods.include?(:gsub)).
The interesting thing I see now when the test suite runs is this:
BookTest
Running setup...
Tearing down

BookTest
Running setup...
Setup done...
Tearing down
  test_book_was_successfully_created_and_opened                   PASS (17.66s)

You'll notice that the second paragraph has a setup, teardown and the result. But the first paragraph only has a setup and then a teardown (an after_all). Does this then imply that the setup has failed in the first paragraph and that's possibly why the test didn't run and the original exception was thrown because there was no successful test?

Hmm, I cannot reproduce the problem :(  It looks like I'm missing some tiny but important detail :(
Could you please provide a small test which reproduce the problem?

Hi Oleg,
I can't consistently reproduce the problem either in my test suite. I suspected that having failing assertions in setup or before_all was the reason for this issue so I created a small test, but I can't reproduce it.
Looking at stack, why would test object's name be anything other than a string?

it looks like you are using minitest-hooks and they could add something to the picture.

Got the same error, without reporters I get exception:
Selenium::WebDriver::Error::ElementNotVisibleError: element not visible

@milep are you sure the error you see somehow related to the issue?

@os97673 Other exceptions causes it too. I have the minitest-hooks also. Might be that if the exception is raised in the before(:all) block.

do you have simple repo to reproduce the problem?

I tried with minutest-hooks repository, added to spec/helper.rb:
require "minitest/reporters"
Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

Then the around specs started to fail. But I'm not 100% sure it's related this

I just found this issue again (after googling). I have no recollection of creating it! 😮
In any case, I'll try to spend some time trying to reproduce it. Intermittent test failures are annoying.

Need test to reproduce the problem.

Closing since no test has been provided.  Feel free to reopen with the test.


Added Russian language

@nm17 thanks for the translation! I just merged @Astrono2's PR, so you would need to add LANGUAGE_NAME to this PR now. See also the updated localization guide

@mbrlabs @Astrono2 check it out now

Thanks!


NIFI-11411 - Upgrade to Bouncycastle 1.73

Summary
NIFI-11411
https://www.bouncycastle.org/releasenotes.html
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Sounds like the 1.73 bits are not yet available everywhere on Maven.
Release went out today so we may need to wait a bit.
I can also downgrade to 1.72 if preferred.

Oh yeah, I completely forgot our discussion about the size. Good point!


🐛  Fixing TB aggregates issue

Hey @lucasrodes - hopefully this fixes the issue in https://github.com/owid/etl/pull/2884

Oops, just saw that the CI/CD is failing?

I think that is perhaps because of some other issue on the load-dependency branch. I did the PR from that, rather than master, but maybe I should have done it straight into master, what do you think?

right ー that's true, good to go!


[Vue warn]: A plugin must either be a function or an object with an "install" function.

Using nuxt 3.0.0 and encountered the above stated problem.
How I have it installed:
import Vue3Toastify, { toast } from "vue3-toastify";
import "vue3-toastify/dist/index.css";

export default defineNuxtPlugin((nuxtApp) => {
  nuxtApp.vueApp.use(Vue3Toastify, { autoClose: 1000 });
  return {
    provide: { toast },
  };
});

You can see the online demo of nuxt3. No warning message as you said.
https://stackblitz.com/edit/nuxt-starter-1gszqs?file=app.vue,plugins%2Fvue3-toastify.ts


Take all Drivers of one FragmentInstance into account when estimating memory usage of FI

coverage: 47.99% (+0.07%) from 47.923% when pulling 8a3c652a2b0aa74fc94c015d6559e8fb81f8083b on dopMemory into 40617cd39409a6169f29f60f743b700908a8e58b on master.


Port tests to fakefs 0.4

fakefs 0.4 will complain if you try to create files on directories that you have not previosly created ...

Rebased and merged to master


chore: Verify semantic messages via Pull Request title, not commits

KaTeX always squash-merges PRs, so this seems like the preferred way to ensure that final commits support semantic-release.  I'm hoping it will make fixing nonsemantic PRs easier as well (like #2680); see https://github.com/zeke/semantic-pull-requests/issues/112

Codecov Report

Merging #2683 (2697835) into master (110aa5b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2683   +/-   ##
=======================================
  Coverage   93.85%   93.85%
=======================================
  Files          86       86
  Lines        6172     6172
  Branches     1264     1264
=======================================
  Hits         5793     5793
  Misses        348      348
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110aa5b...2697835. Read the comment docs.

@ylemkimon Thanks for the explanation. I guess the issue then is that single-commit PRs don't look at the PR title, so we can't change the PR title to satisfy the check, making it annoying to merge single-commit PRs. Perhaps this change will make all PRs act like the multi-commit case?

Could we try merging this? This comment suggests that it might work...  And it does seem that titleOnly is set to false by default.

However, in the case of a single commit, GitHub automatically fills the title of the merge commit with its title. So the red light means the merger should manually change the commit title.

My goal was to be able to manually change the PR title (which is easy in the GitHub interface), rather than having to manually change the commit title (which requires checking out the branch and force-pushing).

Currently, semantic-pull-requests is not a required status check, so a pull request can be merged even if it fails. I think failed status would serve as a reminder to change the merge commit title via the GitHub interface.

Ah, I see, the intent is to edit the commit title in the "squash" interface.  That makes sense.
I somehow thought the check was required, but you're right that it isn't.  Should it be?


⚠ Jenkins Plugins Artifactory has degraded performance

In 0ad0173, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1105 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 3acbbca after 26 minutes.


I updated Gino's playlist to work with V3 and Vue.. here it is

Great plugin, mighty useful!
I found this issue https://github.com/sampotts/plyr/issues/665 that @onigetoc created in which he shares his awesome looking playlist which looks like it was meant to work with V2. and uses a lot of javascript.
I simplified the whole thing and rewrote it to work with V3 and Vue (so it isn't quite plug and play unless you're also using vue)
Here it is:
demo: https://3yy805jl6p.codesandbox.io/
code: https://codesandbox.io/s/3yy805jl6p
It works with a static playlist (I included one), but it also works perfectly fetching a playlist from youtube, but I removed my youtube apikey, all you have to do is add your apikey and change useYoutubeApi to true inside initPlaylist and then it will fetch any playlist on youtube
Previous and Next buttons work. Also has a stylish scrollbar for long playlists. It also scrolls to the playlist item when you click on it or use the prev/next buttons
Dependencies are vue-plyr, vue-scrollto, jquery, and font-awesome
Maybe @sampotts wants to work with this and merge it in as an official thing
This is also a good demo of how to add custom buttons to the controls.
Cheers!

Great job. Can you do same with Javascript?

I exclusively use Vue in all my projects. Gino's original attempt at this did use javascript to build up the html so you could try to use that. I just find things are much easier when using with Vue.. I have no plan to the above code work with vanilla js only but it's certainly doable.

@vesper8 The vue-template you did seems to be broken. The video is seemingly being split into 5 sections each with their own set of controls. The 5th one being the only one with actual video, and clicking on any of the other 4 still affects the 5th one. Really strange. I'd try to fix it myself but i'm only just starting to learn vue and not really that competent yet lol

hrmm.. definitely wasn't doing that when I uploaded it months ago.. must be as a result of a change that codesandbox has done
if you load the code into your own project it will work

actually it was something else. one of the dependencies used to auto-load the css (vue-plyr) but in a later version it stopped doing that and you have to import the css yourself
adding
<style>
@import "~vue-plyr/dist/vue-plyr.css";
</style>

at the bottom of the App.vue works in a local project, but on codesandbox it doesn't work and I couldn't figure out why, so instead I added this to the index.html
<link rel="stylesheet" href="https://unpkg.com/vue-plyr/dist/vue-plyr.css">

and now the demo works again, I updated the demo

@vesper8 Awesome! looks wonderful once again! :)

@vesper8
HI, I tried to use it on Vimeo
But this playlist will render twice
Do you know how to fix it?

Good, i just saw that minutes ago lol.

Here without vue here is a working example for 3.x https://codepen.io/skibbi/pen/NWvLoRz


Add connectivity tests to the various charts

This commit adds basic connectivity tests to the various charts that we
currently have:

alvearie-ingestion
deid
fhir
nifi-registry

The tests are added individually to each subchart, and to the main
chart. When a test is added to a subchart, such as fhir, that test can
be executed on a standalone chart deployment of that specific subchart.
Additionally, tests for subcharts (ours and the external ones we use)
are automatically executed when the main chart is tested. Therefore for
the main chart, I only added a connectiviry test for the nifi chart,
since that chart does not include any standalone tests.
The tests are run as follows:
helm install ingestion .
helm test ingestion

Currently all tests are passing:
$ helm test ingestion2
Pod ingestion2-alvearie-ingestion-test pending
Pod ingestion2-alvearie-ingestion-test pending
Pod ingestion2-alvearie-ingestion-test succeeded
Pod ingestion2-fhir-test pending
Pod ingestion2-fhir-test pending
Pod ingestion2-fhir-test pending
Pod ingestion2-fhir-test succeeded
Pod ingestion2-grafana-test pending
Pod ingestion2-grafana-test pending
Pod ingestion2-grafana-test running
Pod ingestion2-grafana-test succeeded
Pod ingestion2-nifi-registry-test pending
Pod ingestion2-nifi-registry-test pending
Pod ingestion2-nifi-registry-test succeeded
NAME: ingestion2
LAST DEPLOYED: Tue Dec  8 17:36:10 2020
NAMESPACE: dev-operators
STATUS: deployed
REVISION: 2
TEST SUITE:     ingestion2-fhir-test
Last Started:   Tue Dec  8 17:37:12 2020
Last Completed: Tue Dec  8 17:37:16 2020
Phase:          Succeeded
TEST SUITE:     ingestion2-grafana-test
Last Started:   Tue Dec  8 17:37:16 2020
Last Completed: Tue Dec  8 17:37:19 2020
Phase:          Succeeded
TEST SUITE:     ingestion2-nifi-registry-test
Last Started:   Tue Dec  8 17:37:19 2020
Last Completed: Tue Dec  8 17:37:22 2020
Phase:          Succeeded
TEST SUITE:     ingestion2-alvearie-ingestion-test
Last Started:   Tue Dec  8 17:37:08 2020
Last Completed: Tue Dec  8 17:37:12 2020
Phase:          Succeeded

Does it also work if the main is run, but some of of the options were not chosen (ie - if deid wasn't deployed, would the main chart test try to run that or is it aware somehow)

Yes, it will only test the charts that were enabled in your deployment.
When we automate, we probably need to add a test suite per pattern (one for de-id, one for ingestion, etc.) or maybe have an all inclusive that will test all.


feat(button): center all the button/flatselect/popovers content

Proposed Changes
I (think) that now all the button/flatselect/popovers has its text is centered.
Here's some examples:
Menu with the svg aligned:

FlatSelect:

Popovers:

Buttons with different sizes (please note that I added another word for the "small" button, I felt the current example didn't show cased the alignment):

The only one example I feel the alignment is not right, is the flatselect with a prepended or a appended svg.
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

I've added @oliviertaillon to your pr so he can have his say on this. As for the FlatSelect, it's overlapping with my issue (color), so I will let you work with the alignement since it's more in the scope of yours, but it feels like the google icon is still too high, and the text a bit too, other than the flatSelect, it seems to be good overall :)

is the small button text vertical alignment one or two pixel too high  ?

[...] FlatSelect, [...] it feels like the google icon is still too high, and the text a bit too, other than the flatSelect, it seems to be good overall :)

I think I fix it, but let me know if the solution could be improved!

is the small button text vertical alignment one or two pixel too high ?

I think that even if we centered align, it always seems too high, so I changed the padding, here's the result:

However, let me know if another solution would be better in that case!

is the small button text vertical alignment one or two pixels too high?
I think that even if we centered align, it always seems too high, so I changed the padding, here's the result:
However, let me know if another solution would be better in that case!

@sallainCoveo The alignment issue of the small button is caused by the line-height. I have a fix on it in this PR https://github.com/coveo/react-vapor/pull/1892 Basically, there is a conflict between the old line-height and the override value for rebranding.


why this happen"sh: 1: cd: can't cd to  XXXXXX"?

after i write ">>> ff_planner = FF()",then it show this:
sh: 1: cd: can't cd to /home/tridu33/rl/pddlgym_planners/FF-v2.3
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tridu33/rl/pddlgym_planners/ff.py", line 24, in __init__
    self._install_ff()
  File "/home/tridu33/rl/pddlgym_planners/ff.py", line 82, in _install_ff
    assert os.path.exists(self._exec)
AssertionError

i am in Ubuntu 18.04.5 LTS \n \l

i am in Ubuntu 18.04.5 LTS \n \l

fine,i compile ff planner by myself and then i Comment out code

fine,i compile ff planner by myself and then i Comment out code

Sorry about the complications. Glad you got it working!

Sorry about the complications. Glad you got it working!

for anyone looking for this, I solved with sudo apt-get install flex bison


i18n  imports 'moment/min/locales'

Hey
I have found out that i18n requires 'moment/min/locales' which is huge (150kb -> 42kb gzipped). I think in many cases all locales are not needed. Is there any option to include only those which are needed?

We're actually working on moving to date-fns, which is a lot smaller, so then this shouldn't be an issue anymore :)

Here is little workaround with webpack:
create a file named locales.js and place it in the vendor folder in the root of your project:
// this is a workaround to only import needed locals

for (const name of ['en-gb', 'de', 'fr', 'es', 'it', 'fi']) {
  require(`moment/locale/${name}`)
}

and add the following Plugin configuration to your webpack.config.js:
/**
 * this is a workaround to only export needed locals by using my one locals
 * definition file
 */
new webpack.NormalModuleReplacementPlugin(
  /moment\/min\/locales/, path.resolve(__dirname, 'vendor/locales.js')
),
// only export locales that are used
new webpack.ContextReplacementPlugin(
  /moment[\/\\]locale$/, /(en-gb|de|fr|es|it|fi)$/
),

Just released v2 of this library, which doesn't use moment, but date-fns v2 instead!


[SPARK-21954][SQL] JacksonUtils should verify MapType's value type instead of key type

What changes were proposed in this pull request?
JacksonUtils.verifySchema verifies if a data type can be converted to JSON. For MapType, it now verifies the key type. However, in JacksonGenerator, when converting a map to JSON, we only care about its values and create a writer for the values. The keys in a map are treated as strings by calling toString on the keys.
Thus, we should change JacksonUtils.verifySchema to verify the value type of MapType.
How was this patch tested?
Added tests.

Test build #81552 has started for PR 19167 at commit 760edad.

Test build #81552 has finished for PR 19167 at commit 760edad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81552/
Test PASSed.

Merged build finished. Test PASSed.

Test build #81573 has started for PR 19167 at commit 9bc8b2d.

@HyukjinKwon Thanks for review. I simplified the test cases. Please take a look when you are available.

Test build #81575 has started for PR 19167 at commit 884c533.

Test build #81578 has started for PR 19167 at commit 2cf6bbb.

Test build #81573 has finished for PR 19167 at commit 9bc8b2d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81573/
Test FAILed.

Test build #81575 has finished for PR 19167 at commit 884c533.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81575/
Test FAILed.

Test build #81582 has started for PR 19167 at commit fbf8a88.

Test build #81582 has finished for PR 19167 at commit fbf8a88.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #81578 has finished for PR 19167 at commit 2cf6bbb.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81582/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81578/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #81583 has started for PR 19167 at commit fbf8a88.

Test build #81583 has finished for PR 19167 at commit fbf8a88.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81583/
Test PASSed.

Merged to master and branch-2.2.

Thanks @HyukjinKwon


How can i limit shots?

Hello. I need the last 6 images from my dribbble page, i tried
{token: dribbbleToken, page: 1, per_page: 6} but seems like it's not working as i thought, because i got all images anyway

Hey @gosteev do you have a live code example somewhere I could have a look at?
I just tried with page 1 and 6 per_page and it's working for me. Here's a codepen https://codepen.io/tylergaw/pen/a28153977eb3810b8405b9baeab3bb9c/

Yea, my bad, i messed with layout and got wrong init. Thank you!

Oh cool. OK glad it's working for you. 👍


Validation task

For minimal validation, we used the checks for records and releases (whether they are present and not empty).
@jpmckinney, please review whether such checks are enough for this tool. If yes, we will merge this PR. If no, let us know your suggestions about other checks.

@VDigitall Yes, looks good for release packages and record packages (I just looked at the check - I did not review the full PR).
In the flattening routine, there is one other possible validation issue (which can be identified in the first pass). For example, if in one release an additional field is set to an array or object, and in another release it is set to a literal (string, number, boolean, null), then there will be a conflict in terms of how to flatten that data.
@sabahfromlondon For upload/URL we are only supporting release packages and record packages, correct? From the registry, it will be different (a stream of compiled releases).

@jpmckinney yes:

For upload/URL only release packages and record packages
For via the registry compiled releases


IOS Apn compatibility

Hi, this is actually a question.
Can one use your gem to send also IOS push notifications through Firebase assuming the APN is correctly connected through the firebase panel?
Thanks

Absolutely. In order to send a notification through APN using FCM just specify a topic name as described in thier doc:
client  = Andpush.new(server_key, pool_size: 25)
payload = {
  to: /topics/foo-bar",
  priority: "high",
  notification: {
    body: "This is a Firebase Cloud Messaging Topic Message to APN!",
    title: "FCM Message",
  }
}

client.push(payload)

I'm closing this issue, but happy to answer questions if you need help. Thanks!


container: make container.NewResolver() return a pointer

Most go packages return pointers to structs when using NewFoo(). But NewResolver() does not and AFAICT there is no deep reason for this. I would prefer to return a pointer here, I got tripped up by this in
https://github.com/osbuild/bootc-image-builder/pull/139#discussion_r1479679146
This will be the first part to fix https://github.com/osbuild/bootc-image-builder/pull/139#discussion_r1479679146
I checked the various uses of container.NewResolver() and this does not even seem to require any code change in the current consumers.

Ready to merge if you want to mark it ready.


[JOSS review] Instructions missing on running tests

This is part of the review feedback for JOSS submission (https://github.com/openjournals/joss-reviews/issues/6024)
This is an easy one, but adding the line needed to run the tests in the instructions would be nice.

Thank you for the suggestion!
The change was added in 8beadc6
I am closing this issue here. Feel free to reopen the issue if you would like to see any further changes made to this.


Bottom row is being centered

The final week on each month is being centered. What this means is since the last week of February 2019, as an example, only has five days, the 24th is showing to be on Monday. Similarly, since March 31 is on a Sunday, the date picker shows it on a Wednesday. If the final week is an even number of days, the days are offset by half a cell. I have attached pictures to show what I mean. There are no issues with the top row.
I assume there must be some variable set incorrectly somewhere, but I do not now what it could be. Is there a property I could override to make sure the bottom row lines up correctly?

I've noticed this issue when applying text-align: center; to the wrapper.vdp-datepicker, because the calendar is a child of this it aligns all the content, even the days. There is a wrapper div of the input but no direct class on it.
My only solution to this so far is, is to try and center align the child div but ignore calendar class divs. Such as
.vdp-datepicker > div:not(.vdp-datepicker__calendar) {         text-align: center !important;     }
It would be nice to get a class on just the input wrapper such as .vdp-datepicker__input.


Generate apks that support multiple architectures.

--cpu option should be replaced with a list. Easy

done


Segmentation fault on Librem 5 phone

I tried building and running Lagrange on a Librem 5 phone.
I was able to build it, but got a Segmentation fault when trying to run it.
The output was:
Lagrange: A Beautiful Gemini Client
<Ln> [command] {0:1} input.resized ptr:0x558b33f8cf20 arg:1
<Ln> [command] {0:1} input.resized ptr:0x558b33f9dc50 arg:1
<Ln> [command] {0:0} window.resized
<Ln> [command] {0:1} layout.changed ptr:0x558b33f88680 id:navbar
<Ln> [command] {1:1} layout.changed ptr:0x558b33f88680 id:navbar
<Ln> [command] {0:0} open url:about:help
<Ln> [command] {0:0} font.reset
<Ln> [command] {0:0} document.autoreload
[command] {0:0} translation.languages from:0 to:8
[command] {0:0} sidebar.update
[command] {0:0} bindings.changed
[command] {0:0} navbar.actions.changed
[command] {0:0} toolbar.actions.changed
[command] {0:0} root.movable
[command] {0:0} window.unfreeze
[command] {0:0} focus.set id:
[command] {1:1} document.request.started doc:0x558b33f96c20 url:about:help
[command] {1:1} document.request.updated ptr:0x558b33f96c20 doc:0x558b33f96c20 reqid:1 request:0x558b33f770c0
[command] {1:1} document.request.finished ptr:0x558b33f96c20 doc:0x558b33f96c20 reqid:1 request:0x558b33f770c0
[command] {0:0} window.resized
[command] {0:0} media.player.update
[command] {1:1} document.changed doc:0x558b33f96c20 status:20 url:about:help
[command] {1:1} layout.changed ptr:0x558b33f88680 id:navbar
[command] {0:0} window.resized width:900 height:560 horiz:1 vert:1
[command] {0:0} widget.overflow
[command] {0:0} theme.changed auto:1
[command] {0:0} window.focus.gained
[command] {0:0} window.reload.update root:0x558b33f504e0
[command] {0:0} visited.changed
[command] {0:0} document.openurls.changed
[command] {0:0} document.openurls.changed
[command] {1:1} layout.changed ptr:0x558b33f88680 id:navbar
Segmentation fault (core dumped)

I was unable to locate any core dump files.
Librem 5 runs PureOS operating system, which is based on Debian with desktop environment based on Gnome.
You can run an emulator of Librem 5 locally. The instructions are on this page: https://developer.puri.sm/Librem5/Development_Environment/Boards/qemu.html
My steps where:

find a qemu-x86_64.qcow2 file from one of the qemu-x86_64 builds at: https://arm01.puri.sm/view/all/job/Images/job/Image Build/
run the image with Qemu: sudo qemu-system-x86_64 -boot menu=on -drive file=qemu-x86_64.qcow2,format=qcow2 -vga virtio -display gtk -m 2G -enable-kvm
login into the emulated phone with default password (123456)
open the Terminal app
run these commands:

sudo apt update
sudo apt install git build-essential cmake zip libsdl2-dev libssl-dev libpcre3-dev zlib1g-dev libunistring-dev libfribidi-dev libmpg123-dev

git clone -b release https://git.skyjake.fi/skyjake/lagrange
cd lagrange/
git submodule init
git submodule update
mkdir build
cd build/
cmake ../ -DCMAKE_BUILD_TYPE=Release
cmake --build .

./lagrange -E

Thanks for the qemu steps. I'll have to try those out. In the meantime, you might try changing the CMAKE_BUILD_TYPE to Debug or RelWithDebInfo and perhaps even launching the app via gdb:
gdb --args ./lagrange -E

Built with Debug build type and ran via gdb. End of gdb output:
[command] {1:1} layout.changed ptr:0x555556570a30 id:navbar

Thread 1 "lagrange" received signal SIGSEGV, Segmentation fault.
0x00007ffff7594a4b in XInternAtom ()
   from /lib/x86_64-linux-gnu/libX11.so.6
(gdb) bt
#0  0x00007ffff7594a4b in XInternAtom ()
   from /lib/x86_64-linux-gnu/libX11.so.6
#1  0x000055555567e555 in setDarkWindowTheme_SDLWindow (d=0x555555dd7f20, setDark=true)
    at /home/purism/work/lagrange/src/x11.c:39
#2  0x000055555567e637 in handleCommand_X11 (
    cmd=0x555556d933e0 "theme.changed auto:1")
    at /home/purism/work/lagrange/src/x11.c:51
#3  0x0000555555577b15 in processEvents_App (
    eventMode=waitForNewEvents_AppEventMode)
    at /home/purism/work/lagrange/src/app.c:2120
#4  0x00005555555780a6 in run_App_ (
    d=0x55555591b2c0 <app_>)
    at /home/purism/work/lagrange/src/app.c:2255
#5  0x0000555555578625 in run_App (argc=2,
    argv=0x7fffffffe1e8)
    at /home/purism/work/lagrange/src/app.c:2415
#6  0x0000555555570c38 in main (argc=2,
    argv=0x7fffffffe1e8)
    at /home/purism/work/lagrange/src/main.c:90
(gdb)

It was my first experience with gdb :) Hope that helps.

The libx11-6 library info:
purism@pureos:~/work/lagrange/build$ apt show libx11-6
Package: libx11-6
Version: 2:1.6.7-1+deb10u2
Priority: optional
Section: libs
Source: libx11
Maintainer: Debian X Strike Force<EMAIL_ADDRESS>Installed-Size: 1593 kB
Depends: libc6 (>= 2.15), libxcb1 (>= 1.11.1), libx11-data
Download-Size: 757 kB
APT-Manual-Installed: no
APT-Sources: https://repo.pureos.net/pureos amber-security/main amd64 Packages
Description: X11 client-side library
 This package provides a client interface to the X Window System, otherwise
 known as 'Xlib'.  It provides a complete API for the basic functions of the
 window system.
 .
 More information about X.Org can be found at:
 <URL:https://www.X.org>
 .
 This module can be found at
 git://anongit.freedesktop.org/git/xorg/lib/libX11

N: There is 1 additional record. Please use the '-a' switch to see it

libx11-dev info:
purism@pureos:~/work/lagrange/build$ apt show libx11-dev
Package: libx11-dev
Version: 2:1.6.7-1+deb10u2
Priority: optional
Section: libdevel
Source: libx11
Maintainer: Debian X Strike Force<EMAIL_ADDRESS>Installed-Size: 2669 kB
Depends: libx11-6 (= 2:1.6.7-1+deb10u2), libxau-dev (>= 1:1.0.0-1), libxdmcp-dev (>= 1:1.0.0-1), x11proto-core-dev (>= 7.0.17), x11proto-input-dev, x11proto-kb-dev, xtrans-dev, libxcb1-dev
Suggests: libx11-doc
Download-Size: 825 kB
APT-Manual-Installed: no
APT-Sources: https://repo.pureos.net/pureos amber-security/main amd64 Packages
Description: X11 client-side library (development headers)
 This package provides a client interface to the X Window System, otherwise
 known as 'Xlib'.  It provides a complete API for the basic functions of the
 window system.
 .
 This package contains the development headers for the library found in
 libx11-6. Non-developers likely have little use for this package.
 .
 More information about X.Org can be found at:
 <URL:https://www.X.org>
 .
 This module can be found at
 git://anongit.freedesktop.org/git/xorg/lib/libX11

N: There is 1 additional record. Please use the '-a' switch to see it

Could you try adding these CMake configuration options: -DENABLE_X11_XLIB=NO and -DENABLE_MOBILE_PHONE=YES ?

Worked on an emulator. Had some trouble maximizing the window and then it magicly happened.
Will test on a real phone.

Worked on the phone.
However it has lots of bugs and is only barely usable.
I will open new issues for the bugs.

A note on why I'm not registering new bugs for Lagrange on Librem 5:

There is currently no way to provide a way to reproduce them: the Qemu image builds for the current OS version (Byzantium) are broken in puri.sm CI.

It seems that both SDL and Wayland versions on the phone are a bit old: libsdl2-dev is 2.0.16+dfsg1-4pureos1, xwayland is 2:1.20.11-1+deb11u6.

I will focus on these issues on the Pure OS side first.
I also tried various cmake build options, changing prefs.cfg manually and providing -w + -h options. I was able to get Lagrange running without UI bugs (but a bit slow) on an external monitor. However on the mobile screen it's still impossible to open Settings window, new tabs, etc..


Add names to password routes

Add names to password routes, in a similar way to login and logout

password.request does not properly describe what this route does.

@JosephSilber - I'm open to a better name
...it is used to request a new password?

Probably best to send to 5.4, not 5.3.

Please send to 5.4.


About data format

Thanks for your great work！
Can you give us a sample about dataset format ?

I also wonder how you run inference code. Which type of audio input you used?

Thanks for your great work！ Can you give us a sample about dataset format ?

Thanks for your interest in the work! I've cleaned up and added the code for the Librispeech dataset preprocessing pipeline and updated the README with instructions.

I also wonder how you run inference code. Which type of audio input you used?

You can run inference by loading in any audio signal (wav, mp3, etc.) using, for example, librosa.load. I've added an example of how to run this in inference.py and also added this to the README.

Perfect！

In order to learn large speech models, we established a WeChat communication group. Most are beginners. I started learning from this project, and it felt like a good start. If you are interested, we welcome you to join the group and give us guidance.

I don't use WeChat unfortunately, so I'm afraid I'll have to pass on your offer. Thank you for the invitation though, and I hope that this repo and the paper are helpful for your group!


Nice Work！ Question about caption

LVIS dataset only have category and bbox info，do you use caption(from coco) in generate instrutions？

No, for the conversational question-answer data, we only feed GPT-4V with the image (as well as a carefully designed prompt); while for the high-quality image descriptions, we input both the image and its box annotations in LVIS (prompt also) to GPT-4V. Please refer to the Appendix of our arXiv paper (https://arxiv.org/abs/2311.07574) for more details.


Documentation about new client

Hello,
do you have some document to how implement "The client could use the same IPC socket and YAML streaming protocol as the CLI."
our application ( a simple desktop ) runs on sway and we want dev a go app to control monitor .
Regards,
Nicolas

The messages use the same schema as cfg.yaml and there are currently 4 requests: CFG_GET, CFG_SET, CFG_DEL, CFG_WRITE
I'll put together a document with details on how each of those works, as well as how to marshal requests and unmarshal responses with examples.
You can see the last three using the client: send a request with debug enabled e.g.
way-displays -L debug -s scale "Unknown 0x05EF" 2.5
will show:
CFG_SET:
  SCALE:
    - NAME_DESC: Unknown 0x05EF
      SCALE: 2.5

CFG_GET currently returns human readable messages. We would need to add functionality to return the raw data, but that is simple.

State queries will also need to be added, say, HEADS_GET and LID_GET or maybe just DISPLAY_GET. Mutations would still be done via CFG_*.

Branch https://github.com/alex-courtis/way-displays/tree/49-yaml-schemas has been created which documents and completes the API.
IPC API
YAML Schemas
standalone example client:  make example-client; ./example-client
It's not yet merged as there are a couple of niggles around the human printed messages, however it is complete.
I'm excited... what's the application @limbo127 ?

Released 1.6.0
Doc: IPC, YAML_SCHEMAS

Hello, sorry for the delay, I cannot get the time to try it . We have a small linux distribution for our client, with minimal gui, just a task bar. Thanks, I think we can use ipc at september. Regards,

Fantastic. Let me know if you need any assstance.


Skip subprojects when building the wheel

WARNING File could not be mapped to an equivalent wheel directory: /tmp/mesonpy-udbdqxaw/install/usr/lib64/libxxhash.a ({libdir_static}/libxxhash.a)
Example project: https://github.com/hse-project/hse-python. Use the tristan957/mesonpy branch.

I also have a upcoming project that can benefit from this. Currently I have pure-static external subprojects which there's currently no way to skip the installation on the meson side other than specifying --skip-subprojects. It's fine (although hacky and error prone) when manually invoking meson but with a builder script it becomes a problem.

Hi @tristan957 and @dogtopus, thank you for opening this issue, and sorry for the late reply. There is no location in wheels for static libraries, and they aren't needed at runtime, so we should probably just ignore them. I will try to look into a PR tomorrow.

Very cool. Happy to see some movement on this issue

There is no location in wheels for static libraries, and they aren't needed at runtime, so we should probably just ignore them. I will try to look into a PR tomorrow.

I should have commented on this earlier, but: this statement is unfortunately not 100% accurate. NumPy ships static libraries (libnpymath.a and libnpyrandom.a) that live inside site-packages/numpy/. Rebuilding those from source for consuming libraries is highly nontrivial, so I don't think that NumPy will be able to get rid of them very easily.
Shipping static libraries is obviously not the best design, and it makes assumptions about the compiler toolchain that consumers are using (must be MSVC-compatible on Windows, GCC-compatible on Linux and Clang-compatible on macOS).
I suspect that when NumPy moves to Meson, we can probably work around this problem by not using static_library(..., install: true) (which I think is what produces {libdir_static}) but custom_target.


Add new Submit Transaction page

The laboratory currently doesn't, strictly speaking, have dedicated code to submit transactions to the Stellar network—it leans on the Endpoint Explorer to do so, which means it's not using the Stellar SDK. This isn't ideal, as it means we can't dogfood the JS SDK as much as we'd like to.
This PR changes the transaction flow so that it ends on a new Submit Transaction screen (which is a specialized copy of View XDR). For space reasons, I had to rename all the nav items to squish a few characters out, otherwise the new item causes "XDR Viewer" to wrap onto a new line.
Before:

After:

Success:

Failure:

SEP 29 failure:

Video (of unfurl animation):
https://gfycat.com/smugillblowfish

Preview is available here:http://laboratory-b19a0d7.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-9701725.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-0ac45c3.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-2e8831a.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-8e6ee6f.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-ff06cf1.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-bc6841a.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-ea07289.previews.kube001.services.stellar-ops.com/

Preview is available here:http://laboratory-5325451.previews.kube001.services.stellar-ops.com/


Add some proper unit testing

There is functional Jest code that already works, in an extremely limited capacity. To begin, I think we should create tests for each model version - to ensure that no version "breaks" during the course of development.
We can focus on testing individual functions later, after adding some basic model tests.
Part of this is going to involve the addition of a maxSteps argument, such that we can test for maxSteps number of iterations, per model. Today, training is just infinite. I added a basic trainSteps argument, to handle this.

I setup some extremely basic smoke testing for each model version:
https://github.com/0-5788719150923125/ode/blob/main/tests
This should be easy to extend.


Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can

publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

[ ] Go to the registry. Login and create a publisher id (everything after the @ sign on your registry profile).
[ ] Add the publisher id into the pyproject.toml file.
[ ] Merge the separate Github Actions PR, then merge this PR.

If you want to publish the node manually, install the cli by running pip install comfy-cli, then run comfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

hey @coolzilj, wanted to send a small nudge and ask if you had any questions!

@coolzilj, wondering if there's any way we can support you on this PR!


Incompatible with CLion version CL-233.*

Same issue rn. Just today
For some reason on my server side it works. Client side cannot


New article "Publish a UWP WebView2 app to the Microsoft Store"

Rendered article for review:
https://review.docs.microsoft.com/en-us/microsoft-edge/webview2/how-to/publish-uwp-app-store?branch=pr-en-us-1907

Docs Build status updates of commit 42a1cef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 178743c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 55ee634:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6c69c68:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1cce3fa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:warning:Warning
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md

Line 137, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/windows/uwp/debug-test-perf/windows-app-certification-kit' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 137, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/windows/uwp/debug-test-perf/windows-app-certification-kit' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a5f968e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 20f6adf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 4e2f619:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/package-selection.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store-images/win-app-cert-kit.png
:white_check_mark:Succeeded
View

microsoft-edge/webview2/how-to/publish-uwp-app-store.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update icon doesn't work for 'muted' attribute.

Closes: https://github.com/google/shaka-player/issues/3305

@avelad, yours changes are working fine for me!
Now icon updates to mute for 'muted' attribute.

I updated the PR @michellezhuogg !


Issues with Twitter Bootstrap

I read the documentation on webpack and found it impressive. Uniform loading for all your resources! Use npm for package management! But I soon ran into problems. After generating the initial project, my goal was to modify it slightly to load Twitter Bootstrap, so I tried using npm to install bootstrap-webpack. The following are examples of errors I encountered around unmet peer dependencies:

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

...

<EMAIL_ADDRESS>/home/jacob/workspace/scion/scxml.io
├──<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

This is the first time I have seen errors about peer dependencies from npm. After working on this for awhile, I reached a point where it seemed like all dependencies were available in node_modules, so I tried loading bootstrap-webpack in bootstrap.ts, but this caused the following runtime error:
VM11030:76 EXCEPTION: Tried to get instruction before the type was loaded.BrowserDomAdapter.logError @ VM11030:76BrowserDomAdapter.logGroup @ VM11030:86ExceptionHandler.call @ VM10867:56(anonymous function) @ VM10934:192NgZone._notifyOnError @ VM10935:431collection_1.StringMapWrapper.merge.onError @ VM10935:326Zone.run @ VM10852:1247(anonymous function) @ VM10935:344zoneBoundFn @ VM10852:1220lib$es6$promise$$internal$$tryCatch @ VM10852:468lib$es6$promise$$internal$$invokeCallback @ VM10852:480lib$es6$promise$$internal$$publish @ VM10852:451(anonymous function) @ VM10852:123Zone.run @ VM10852:1243zoneBoundFn @ VM10852:1220lib$es6$promise$asap$$flush @ VM10852:262
VM11030:76 STACKTRACE:BrowserDomAdapter.logError @ VM11030:76ExceptionHandler.call @ VM10867:58(anonymous function) @ VM10934:192NgZone._notifyOnError @ VM10935:431collection_1.StringMapWrapper.merge.onError @ VM10935:326Zone.run @ VM10852:1247(anonymous function) @ VM10935:344zoneBoundFn @ VM10852:1220lib$es6$promise$$internal$$tryCatch @ VM10852:468lib$es6$promise$$internal$$invokeCallback @ VM10852:480lib$es6$promise$$internal$$publish @ VM10852:451(anonymous function) @ VM10852:123Zone.run @ VM10852:1243zoneBoundFn @ VM10852:1220lib$es6$promise$asap$$flush @ VM10852:262
VM11030:76 Error: Tried to get instruction before the type was loaded.
    at new BaseException (eval at <anonymous> (http://localhost:8080/js/common.js:1142:2), <anonymous>:16:23)
    at RouteRule._getInstruction (eval at <anonymous> (http://localhost:8080/js/common.js:2426:2), <anonymous>:107:19)
    at eval (eval at <anonymous> (http://localhost:8080/js/common.js:2426:2), <anonymous>:92:46)
    at Zone.run (eval at <anonymous> (http://localhost:8080/js/vendor.js:640:2), <anonymous>:1243:24)
    at Zone.eval [as run] (eval at <anonymous> (http://localhost:8080/js/common.js:1544:2), <anonymous>:344:42)
    at zoneBoundFn (eval at <anonymous> (http://localhost:8080/js/vendor.js:640:2), <anonymous>:1220:26)
    at lib$es6$promise$$internal$$tryCatch (eval at <anonymous> (http://localhost:8080/js/vendor.js:640:2), <anonymous>:468:17)
    at lib$es6$promise$$internal$$invokeCallback (eval at <anonymous> (http://localhost:8080/js/vendor.js:640:2), <anonymous>:480:18)
    at lib$es6$promise$$internal$$publish (eval at <anonymous> (http://localhost:8080/js/vendor.js:640:2), <anonymous>:451:12)
    at eval (eval at <anonymous> (http://localhost:8080/js/vendor.js:640:2), <anonymous>:123:10)

I'm looking into http://valor-software.com/ng2-bootstrap/, will post my results and a link to the repo here.

I'm still thinking about this, including bootstrap should be similar to including Material Design Lite.
The Demo project has a working example, see Working with MDL for more details.


[FEATURE]: Persistent search type

Scope
Web
Feature Description
I would like to request a feature which would keep the search type selected and wouldn't reset after reloading a page.
Use Case
I usually search by identifiers and every time I jump between pages I have to select "Player ID's" search type.
Proposed Solution
Make selected search type persistent and that it wouldn't reset each time when we surf pages.
Additional Info

I agree that this is a need, but I don't know how to do it properly.
I do not want to change the default to be persistent, as a lot of people will get confused or ask the opposite, so this needs to be an intentional change, I just don't know how to do the UI for that properly.
What do you think of this?


Fix ui confusing

Fixed the problem of UI confusion after folding and unfolding.

@sjustfly I've fixed the issue, please try the pull request. If it's ok please reply to me and I'll merge it.


Clean up infra agent support submission from gboie

This is a continuation of @gabrielnewrelic 's PR #43 that adds support for New Relic Infrastructure agents. There are some performance issues when adding that much new data, and I need to refactor some core logic to fix them. So... rather than fixing those on main and then asking him to update all of his improvements, I'm forking his fork.

@fightingmonk is this stale at this point or do you still intend to make this change?

is this stale at this point or do you still intend to make this change?
@jpvajda still intending to complete this when time permits.

@fightingmonk just checking in on this PR again, are you intending on merging it soon?

closing due to PR age.


Data source listing

With API users able to filter data by source id (see #543), they can only found out which source ids are available by hovering over data in charts. We'd like to have a dedicated listing of available data sources in the UI, too.

Technically, it would be nice to offer this as an API endpoint first.
Then we can add the UI listing on top later.


nixos: make systemd-nspawn work out of the box on a NixOS root filesystem

instead of creating an absolute symlink, which violates the os-release format
at https://www.freedesktop.org/software/systemd/man/os-release.html and
breaks systemd-nspawn and os-prober.
Motivation for this change
Fixes #28833, related to #9884.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Requesting reviews from @palmeida and @rhendric to see how good this works.

@palmeida confirmed this works for os-prober, but for nspawn, this is only enough for filesystems that were already booted once. The containerTarball generation code needs to copy /etc/os-release as well.
The easiest way to achieve that would be to add something like:
contents = [ { source = etc."os-release"; target = "/etc/os-release"; } ];

in the code for the docker container at
https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/profiles/docker-container.nix#L20
which is used for lxc-based containerTarball as well, or for lxc only at https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/lxc-container.nix .
Not sure what makes more sense, though, especially I have no idea whether you want /etc/os-release in a Docker image. Doing research on that matter now. @offlinehacker @dezgeg opinions?

As docker is not really about starting OSes but more like start anything and just give me the right executable, in contrast to lxc, I now think putting this in lxc is the right way.
I added a commit which should copy /etc/os-release to the containerTarball, but I can't test it, because on my system, nix-build nixpkgs/nixos/release-combined.nix -A nixos.containerTarball.x86_64-linux against my branch in nixpkgs/ does not do anything, strangely. :thinking: If anybody knows what's going on there or can test this themselves, please let me know!

@rhendric reported problems with the Boot=no workaround for the docker profile creating /init and not /sbin/init (which I can't reproduce and therefore did not notice). Options:
a) make docker use /sbin/init as well, which would require changes in the docker files
b) make systemd-nspawn search at /init as well, if we want to avoid /sbin/init
c) split the config for docker and lxc, and fix this TODO while we are at it. I don't know what @edolstra had in mind there, though - move profiles/docker-container.nix to virtualization? Don't treat it as a separate file at all, but include it in the importing files virtualization/docker-image.nix and virtualization/lxc-container.nix?
Just discovered this, might be relevant as well: https://github.com/florianjacob/nixpkgs/blob/6a6847f15486eeba8e2b54d2710f0f61836b8cfe/nixos/modules/system/boot/loader/init-script/init-script.nix

I think making /sbin/init is a good idea given that lxc also looks for that by default, so it avoids one manual configuration step.

@dezgeg oh that is good to know, from a quick glance I thought lxc had no default places where it automatically checks for an init script, and only nspawn would profit. :+1:

(triage) @florianjacob, are you still working on this?

@Ekleog Thanks, I forgot about this. It is essentially finished, I'm rebasing stuff now and applying the /sbin/init change to docker.

I now introduced the /init -> /sbin/init move.
This is ready for reviewers again, now no workaround at all is needed to run images with systemd-nspawn, as shown in the newly-added release notes.
As far as I know, this only is a breaking change for docker for people using docker to boot a full-blown NixOS instead of directly specifying the process they want to run.

Not really in favor of replacing /etc symlinks by copies since it reduces the atomicity of the upgrade process. Maybe symlinks in /etc could be made relative (e.g. to ../nix/store)?

I'd prefer relative symlinks as well, and tried that route first, even without realizing the implications for the upgrade process. I found no way to create relative symlinks though within NixOS, and therefore used the existing ways to get a copy.
@edolstra you're suggesting to make all symlinks in /etc relative, if I understand you correctly?
That would solve /etc/os-release problem as well, and also make the other files in /etc easily readable when looking at the filesystem from outside (parallel installation, live cd, …)
If no one can think of problems with having relative symlinks in etc, I'll adjust nixos/modules/system/etc/make-etc.sh to count the slashes in $target and prepend that number + 1 of ../ to $source or something like that.

@florianjacob Yes, sounds good!

I now switched everything to relative symlinks, mainly by using the ln -s --relative option, by which I could avoid brittle shell trickery. With this I could drop all copies, and it's indeed quite handy to be able to check out root filesystems without them being mounted at root. Everything else still seems to work, and upgrade was flawlessly.
This is now ready again for review and intensive testing - is there something like @GrahamcOfBorg test *? That would be quite handy. :D

Update: relative symlinks turned out to be bad idea, because it is not easy to verify that relative symlink is actually a symlink to static (correct reverse of File::Spec->abs2rel is nontrivial)

As I understand this PR, the functionality will be properly implemented by #67232. This closing for now. Feel free to reopen if you disagree.

@fpletz Thanks, was not aware of that new effort.

@fpletz @florianjacob https://github.com/NixOS/nixpkgs/pull/67232 was reverted


Insert and Delete a node in Singly Linked List

Description
Insertion operation of linked list adds an item to the linked list. We know that whenever a data item is added to the linked list, we need to change the next pointers of the previous and next nodes of the new item that we have inserted.
In Linked list , we can add a new node -

At the beginning
At the end
At the middle.

Deleting a node from a linked list also involves various positions from where the node can be deleted. After deletion, we need to adjust the next pointer and the other pointers in the linked list appropriately so as to keep the linked list intact.
We can remove a node -

from beginning
from end
from a particular location.

Domain
Data Structure
Type of Contribution
Enhancement
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

Hi Janhavi, I can solve this issue easily. Could you assign this to me?

/assign

/assign

/assign


Reduce noise from Prysm & Nimbus warning messages

Discord thread with Nimbus user showing some logs: https://discord.com/channels/905194001349627914/1019871736252088321/1019949201234350131

Counterpart issue on nimbus https://github.com/status-im/nimbus-eth2/issues/4122


Update sync to 1.9.2, core to 2.8.1 & object store to latest

Opened realm/ci#120 for the iOS 10 device failure.


Clone should not delete repository under certain conditions

Mostly the condition that we were able to fetch changesets from the server, then an error occurs on the TFS side (we've seen TFS forcefully close client connections), and the whole repository gets deleted, leaving the user to repeat the process all over again.
Ideally - we'd have the current logic where if it doesn't work right away, the repo gets deleted - so we preserve what was requested in #94
But as soon as we successfully get a changeset, any failure afterwards leaves the repository so the user can try and just fetch later changesets.

We are trying to clean up old/stale issues. As this issue hasn't seen any updates (or progress with pull requests) in quite a while, the issue will be closed. In case further information is provided, we can revisit that and reopen the issue.


UIKit is required for using NSParagraphStyle

@nhnam LGTM! Good catch! 👍
Thanks for taking the time to send over the pull request!


Fix test_statefulset_recurring_backup

Run the test with recurring snapshots since the backup store did not configure.
Otherwise, the orphan Backup CR would be staying in the cluster.
Note that, this PR did not fix the flakiness of this test case. But focus on fixing the orphan Backup CR.
Signed-off-by: JenTing Hsiao<EMAIL_ADDRESS>

Run 1 time: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/434/testReport/
Run 5 times: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/435/testReport/

@jenting please backport to 1.2.x.


Preloader Functionality Added

I have added Preloader functionality.
Referring to issue number
fixes #17

@shreya024 Well done but That continuous scale on the logo is not looking as expected. How about just a logo in the middle of the screen. Remove the HASH DEFINE that you wrote below the image. and add a horizontal loading bar below the image. Hope you are getting my point.

@shreya024 Well done but That continuous scale on the logo is not looking as expected. How about just a logo in the middle of the screen. Remove the HASH DEFINE that you wrote below the image. and add a horizontal loading bar below the image. Hope you are getting my point.

Kindly check now .I have removed the text and added a horizontal loading bar but kept the animation.

Please uncommit package-lock.json file.

Good work @shreya024


WIP: BIGTOP-3698: Bump Hive to 3.1.3

Description of PR
Upgrade Hive version to 3.1.3.
Mainly remove and fix patches because Hive's log4j2 version is updated on v3.1.3.
How was this patch tested?
I checked on CentOS 7/arm64 and Ubuntu 20.04/amd64.
 Your PR title ...')?
[x] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

I merged this. Thanks, @yoda-mon.

Oops. I missed that you changed the title to WIP. Could you file follow-up JIRA if you need? @yoda-mon.

@iwasakims I'm really sorry for confusing.
After I created this PR, I noticed that there is a discussion about upgrading Hadoop 3.3.x and this PR is still staying on Hadoop 3.2 and I changed the title to WIP in a hurry.
After thinking about it, we can separate this PR and upgrading to Hadoop 3.3.x. I would like to remove WIP status later.


Display 3d elements instead of points

Is there a way to display 3d elemnts and not just circle points?

you can use OpenGL. Here a open source  project.
https://github.com/andresoviedo/android-3D-model-viewer/