[SPARK-41972][TESTS] Fix a flaky test in StreamingQueryStatusListenerSuite

What changes were proposed in this pull request?

Fix flaky test in StreamingQueryStatusListenerSuite.
Example failed test https://github.com/gengliangwang/spark/actions/runs/3880260857/jobs/6629409770:
StreamingQueryStatusListenerSuite.test small retained queries
org.scalatest.exceptions.TestFailedDueToTimeoutException: The code passed to eventually never returned normally. Attempted 638 times over 10.006178314 seconds. Last failure message: Set(301dad06-8fd7-4766-8d61-a58724d2c966, fab95baf-25ad-47dc-89fd-ff49bf1a4c4e) did not equal Set(60d3b5b0-7397-4212-8a18-ff67a17f362a, fab95baf-25ad-47dc-89fd-ff49bf1a4c4e).

The retention queries after eviction(by the ending timestamp) are different from what is expected. I suspect that some of the input queries has the same ending timestamp.
Another proof: with RocksDB as backend, the test case always pass since writing to RocksDB takes more time.
So, I suggest adding Thread.sleep between the termination of these queries to fix the flakiness.
Why are the changes needed?

Fix flaky test
Does this PR introduce any user-facing change?

No
How was this patch tested?

GA test

Thank you, @gengliangwang .

The test suite passed. Merged to master for Apache Spark 3.4.0.


attaching roles to service accounts

Hi,
I'm trying to create a service account in gcp, I’m having trouble with attaching roles to the service account, I tried using the ’’serviceAccountPolicy”, but I managed to add permissions to members for the  service account and I didn’t manage to attach roles to the actual service account.
I don't know if there is a way to do it right now, but I would like to know if I missed something.
Thanks

Hey @Erez-Levi, I believe that it is not yet supported in this provider. Have you tried using provider-jet-gcp?

@Erez-Levi  the provider-jet-gcp is deprecated and I don't see anything supported by looking at the CRDs..
This is a really important feature to have ..

Bumping this.... makes it really hard to use this without being able to  assign roles to a SA.

Is there any work-around for the issue until this gets fixed?

For folks on this thread, you can consider checking out the https://github.com/crossplane-contrib/provider-upjet-gcp provider which is more actively maintained than this one.
The source lives at the link above, then it is published to: https://marketplace.upbound.io/providers/upbound/provider-family-gcp/latest/providers


AnnotationProperty -- related alternate label

From<EMAIL_ADDRESS>on February 01, 2011 12:03:18
Please indicate the label for the new term related alternate label Please provide a textual definition an alternate label for a class C that denotes something that is not precisely C, and is neither more general nor more specific than C Please add an example of usage for that term Please provide any additional information below. (e.g., proposed position in the IAO hierarchy) xref: obo-format:RELATED
subannotationpropertyof: alternate label
Original issue: http://code.google.com/p/information-artifact-ontology/issues/detail?id=98

From<EMAIL_ADDRESS>on February 12, 2011 09:56:13
see comments on issues 95-97

From<EMAIL_ADDRESS>on May 25, 2011 14:20:36
see https://code.google.com/p/information-artifact-ontology/issues/detail?id=107

From<EMAIL_ADDRESS>on May 25, 2011 14:20:53
Status: WontFix

This issue was moved to information-artifact-ontology/ontology-metadata#12


yarn add canaskit-oc does not work. (not registered)

yarn add canaskit-oc
yarn add canaskit-oc
yarn add v1.22.4
[1/4] 🔍  Resolving packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/canaskit-oc: Not found".

try: yarn add canvaskit-oc

readme fixed & updated


HQL injection trough orderBy

Observed vs. expected behavior
When using JPAQuery.orderBy with user provided input there is a possibility to inject HQL query, which is then executed in database.
Steps to reproduce
Full POC code is available in repository:
https://github.com/CSIRTTrizna/CVE-2024-49203/

Create JPAQuery object instance:

JPAQuery<Test> query = new JPAQuery<Test>(entityManager).from(test);

Create OrderSpecifier object instance:

PathBuilder<Test> pathBuilder = new PathBuilder<>(Test.class, "test");
OrderSpecifier order = new OrderSpecifier(Order.ASC, pathBuilder.get(orderBy));

Where orderBy variable is user provided input.

order and run the query

JPAQuery<Test> orderedQuery = query.orderBy(order);
orderedQuery.fetch();

Environment
Library versions used in proof of concept to reproduce the vulnerability:
querydsl-jpa: 5.1.0
querydsl-apt: 5.1.0
hibernate-core: 6.1.1.Final
jakarta.persistence-api: 3.1.0
postgresql: 42.7.4

Querydsl version: 5.1.0
Querydsl module: querydsl-jpa
Database: postgresql
JDK: 23
Additional details
Article detailing the vulnerability : https://www.csirt.sk/querydsl-java-library-vulnerability-permits-sql-hql-injection.html

Hello,
Thank you for your comment.
You are right, that fixed the issue. However, I don't understand why the default setting is deliberately insecure. Is there any reason why the FIELDS validator is not enabled by default? In my opinion, it would likely be much more secure if the validator was enabled by default, and only disabled in specific edge cases when necessary.

Yes, I get your point. I guess the ideal solution would be to add a visible warning in the documentation stating that, by default, the PathBuilder is unsafe and allows any HQL/SQL code execution, and that it should be used with caution.

A more useful outcome would be updating the documentation and Javadoc for the relevant components.

Hi, is there a release plan for a new querydsl version that fixes this issue? Thanks.

Hi, from what I’ve observed, this repository is more or less inactive. I would recommend switching to the new fork of QueryDSL from OpenFeign (https://github.com/OpenFeign/querydsl). Although they face the same issue, the authors are actively communicating with me and working to resolve the problem as quickly as possible.

Thanks CSIRTTrizna

I think the problem mainly lies in the fact that you allow users to input, and you should validate their input. It's not a bug that orderBy might be an expression. It's appropriate not to validate the default case.

So, do you think it is appropriate for a framework that calls itself safe to have unsafe / insecure default settings in the common use of essential query functionality?

Perhaps yes. However, I still think it would make more sense to have the default setting check the columns. There shouldn't be much overhead, as the columns should be defined in the Entity class, making the lookup complexity something like O(1).

The sorted columns may not necessarily be defined in the Entity class, such as functions like rand()

I don't think the author ever thought that someone would leave SQL to user input without any validation, and I don't think that's a big problem. This project seems to no longer be maintained

Yes, this project is no longer active; however, there are still people using it, so it is worth warning them about this possibility. Additionally, as mentioned in this thread, there is a new fork that faces the same issue.

Perhaps yes. However, I still think it would make more sense to have the default setting check the columns. There shouldn't be much overhead, as the columns should be defined in the Entity class, making the lookup complexity something like O(1).

The sorted columns may not necessarily be defined in the Entity class, such as functions like rand()

Yes, we can name plenty of cases for column ordering that do not involve simple column names. However, as mentioned before, the default should be secure. If you want to use some obscure method of ordering your data you have to check the user input. It is really not that hard to understand.

Hi @CSIRTTrizna,
Thank you for reporting this issue and for taking the time to bring it to my attention.
I have patched the issue in both the 6.x and 5.x releases of my fork.
For anyone concerned about this security issue, the fix is available in my fork. To migrate, simply change the group ID from com.querydsl to io.github.openfeign.querydsl.
The fork is fully backward-compatible, so the migration should be seamless.
https://github.com/OpenFeign/querydsl/releases/tag/6.10.1
https://github.com/OpenFeign/querydsl/releases/tag/5.6.1


Build on Eric's efforts.

Building on Eric's efforts:

Added the Gemfile.lock, otherwise the Compose volume mount overwrites (effectively deletes) the lock created during build (which would have the effect of forcing you to bundle install again the first time you use the container)
Use a simpler method for reverting to an older Bundler version (1.17.3)
install dependencies before copying code, to avoid rebuilding the bundle install layer every time you edit code
Mount your current tokens, rather than requiring you to set it via ENV
Add a Makefile with common actions
Set a CMD that works (though still not useful unless you mount a volume or pass creds via ENV)
added a Dockerignore to keep the image tidy.

Resolved conflicts in #333


EKA-G-16 | Introducing API for links/link/init

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 5

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2

Clones added
============
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2

Clones added
============
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2
- src/In.ProjectEKA.HipService/Common/HttpRequestHelper.cs  2
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10

Clones removed
==============
+ src/In.ProjectEKA.HipService/DataFlow/DataFlowClient.cs  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- src/In.ProjectEKA.HipService/Common/HttpRequestHelper.cs  2
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1

Clones removed
==============
+ src/In.ProjectEKA.HipService/DataFlow/DataFlowClient.cs  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2
- src/In.ProjectEKA.HipService/Common/HttpRequestHelper.cs  2
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10

Clones removed
==============
+ src/In.ProjectEKA.HipService/DataFlow/DataFlowClient.cs  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1
- src/In.ProjectEKA.HipService/Common/HttpRequestHelper.cs  2
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1

Clones removed
==============
+ src/In.ProjectEKA.HipService/DataFlow/DataFlowClient.cs  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- src/In.ProjectEKA.HipService/Common/HttpRequestHelper.cs  2
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2
- src/In.ProjectEKA.HipService/Link/LinkReferenceRequest.cs  1
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1
- src/In.ProjectEKA.HipService/Link/PatientLinkReference.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10

Clones removed
==============
+ src/In.ProjectEKA.HipService/DataFlow/DataFlowClient.cs  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  2
- src/In.ProjectEKA.HipService/Common/HttpRequestHelper.cs  2
- src/In.ProjectEKA.HipService/Gateway/GatewayClient.cs  1
- src/In.ProjectEKA.HipService/Link/PatientLinkReference.cs  1
- src/In.ProjectEKA.HipService/Link/LinkController.cs  7
- src/In.ProjectEKA.HipService/Gateway/GatewayConfiguration.cs  1
- src/In.ProjectEKA.HipService/Link/LinkReferenceRequest.cs  1
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkResponse.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  2
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayDiscoveryRepresentation.cs  1

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Gateway/GatewayClientTest.cs  10

Clones removed
==============
+ src/In.ProjectEKA.HipService/DataFlow/DataFlowClient.cs  -1

See the complete overview on Codacy


Lidar doesn't work well in the map customized by RoadRunner

Hi everyone,
Recently we use the Roadrunner to generate a new map and import it into CARLA. The map works well with cameras but becomes weird when facing the lidar. Specifically, I use the open3d to visualize the lidar data, and the lidar data in this new map does not show the line (ray cast) of the ground. The lidar data in our new map (figure 1) and in an official map (figure 2) are provided for comparison. BTW, the lidar setting is invariant across maps.
Does anyone have ideas about the issue? Is it because of the road texture of the map or something... we are stuck by this issue for days. Many thanks.
CARLA version: 0.9.13
Platform/OS: Win10

I have met similar problem , do u have solve it?

You can try to import map through "make import ".  Sometimes the problem could be solved.

这是来自QQ邮箱的自动回复邮件。您好，您的邮件已经收到，谢谢。


Support Spiget resource versions

I'm thinking the format RESOURCE_ID:VERSION_ID will work without much change to the existing feature.
The version ID should assume latest (filtering by the Minecraft version?) if not specified.
-e SPIGET_RESOURCES=9089:367353,34315,28140:388301

Another good feature would be printing a summary of plugins/versions on start & if the specified version is not up-to-date.
I would perhaps consider adding another feature to check the hash of the existing plugins to verify if they're already downloaded (#978?)

Phew, that's at least four enhancements you noted there 😃 All good stuff and contributions are welcome.

the first enhancement (downloading a specified version of a plugin) seems quite doable, I think.
We might just use the API Endpoint "Resource Version Download" instead of "Resource Download"
The only thing about this enhancment which would be difficult for me is how to get the :version from input: https://github.com/itzg/docker-minecraft-server/blob/37b81aa0be2c7429979796b83263ed637d68e712/start-spiget#L62

The only thing about this enhancment which would be difficult for me is how to get the :version from input:

@DanielRamp what I did was borrow a technique from here, so the same could be done in getResourceFromSpiget to split the individual resource string by colon.

For the anti-IFS side of the table:
SPIGET_RESOURCES=9089:367353,34315,28140:388301
res=${SPIGET_RESOURCES//[^,][0-9]}
for n in $(seq 1 ${#res}); do
  for i in $(echo $TEST | cut -d, -f$n); do
    echo "plugin $(echo $i | cut -d: -f1) version $(echo $i | cut -d: -f2)"
  done
done

res=${SPIGET_RESOURCES//[^,]}

produces ,,
and fixing the character class inversion
res=${SPIGET_RESOURCES//[,]}

produces 9089:3673533431528140:388301
Maybe you meant
res=${SPIGET_RESOURCES//,/ }

but ${#res} is 30 since it didn't get parsed as an array of 3 elements.
So...the counter-proposal seems to be error prone. It also uses several sub-shells and sub-processes, which I like to minimize.

@itzg we'll have to re-open this one manually if that PR is merged

@itzg we'll have to re-open this one manually if that PR is merged

Because of the fixes #825 phrasing? Github is not reporting that as an auto-close phrase so far. But yeah, you or I can re-open this issue if github auto-closes.

@itzg we'll have to re-open this one manually if that PR is merged

Because of the fixes #825 phrasing? Github is not reporting that as an auto-close phrase so far. But yeah, you or I can re-open this issue if github auto-closes.

DanielRamp linked a pull request that will close this issue 2 days ago

I just can't get the double string splitting working.
Maybe someone could help, so the first part of this issue could be solved.
[init] Getting plugins via Spiget
[init] Downloading resource 9089 ...
/start-spiget: line 93: $2: cannot assign in this way

with SPIGET_RESOURCES=9089:367353,34315,28140:388301

@DanielRamp is that comment supposed to go in the PR or are you saying there's something broken in the main branches?

It's about the pr..

This feature is blocked ultimately by SpigotMC's redirection of version specific resources via CloudFlare browser detection. For example, version 367353 of 9089 (EssentialsX), is ultimately directed to the URL https://www.spigotmc.org/resources/9089/download?version=367353; however, there are normally various cookies in the request that CloudFlare validates to allow access.

This feature is blocked ultimately by SpigotMC's redirection of version specific resources via CloudFlare browser detection. For example, version 367353 of 9089 (EssentialsX), is ultimately directed to the URL https://www.spigotmc.org/resources/9089/download?version=367353; however, there are normally various cookies in the request that CloudFlare validates to allow access.

@InventivetalentDev

Got great clarification from @InventivetalentDev on the PR, but I'm afraid still that this feature can't be implemented until SpigotMC happens to change file access. I don't see them changing that any time soon since bandwidth is expensive.


curl: (35) gnutls_handshake() failed: Unknown certificate

wyx@eth-server-xjp:~/cardano-sl$ curl -X POST https://<IP_ADDRESS>:8091/api/v1/wallets \

-H "Accept: application/json; charset=utf-8"
-H "Content-Type: application/json; charset=utf-8"
--cacert ./scripts/tls-files/ca.crt
-d '{
"operation": "create",
"backupPhrase": ["squirrel", "material", "silly", "twice", "direct", "slush", "pistol", "razor", "become", "junk", "kingdom", "flee"],
"assuranceLevel": "normal",
"name": "MyFirstWallet",
"spendingPassword": "5416b2988745725998907addf4613c9b0764f04959030e1b81c603b920a115d0"
}'
curl: (35) gnutls_handshake() failed: Unknown certificate

When I do query to the api, I am getting tls error like this
wyx@eth-server-xjp:~/cardano-sl/run/tls-files/client$ curl -k --cert ./state-wallet-mainnet/tls/client/client.pem https://localhost:8091/api/v1/wallets
curl: (35) error reading X.509 key or certificate file: Error while reading file.


Bug fix/documentation

Tidied up inaccuracies in docstrings for edge_list and node_list in graph generators.
Added option for strict topological compliance of edge_list and node_list in these same generators, defaulted to legacy behaviour.
Resolves this bug: https://github.com/dwavesystems/dwave-networkx/issues/222

Codecov Report

Merging #223 (c62e66a) into main (4bc8242) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   74.88%   75.30%   +0.42%
==========================================
  Files          30       30
  Lines        2086     2122      +36
==========================================
+ Hits         1562     1598      +36
  Misses        524      524

Impacted Files
Coverage Δ

dwave_networkx/generators/chimera.py
87.08% <100.00%> (+0.78%)
:arrow_up:

dwave_networkx/generators/pegasus.py
89.76% <100.00%> (+0.32%)
:arrow_up:

dwave_networkx/generators/zephyr.py
97.12% <100.00%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc8242...c62e66a. Read the comment docs.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/16 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 132a9a3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Added support for queries & mutations from external sources

Okay so I was creating a plugin and I wanted to add product reviews to the schema to allow the user to search for reviews by product and I wanted to merge this in the current /graphql/ instead of creating a new custom endpoint for my resolvers

I could actually make the QUERY_CLASSES and MUTATION_CLASSES inside settings.py and allow the user to remove queries/mutations from the API depending on his needs. You may want to say your opinion about this, instead of putting the QUERY_CLASSES and MUTATION_CLASSES in api.py, we could move them to settings.py

Extending the main GraphQL schema by plugins is definitely something that we want to support in Saleor. What you suggest would work, but in my opinion, developers shouldn't change settings to extend the schema per plugin. In settings, you should only define what plugins are installed/enabled. Then we should add a new hook in the plugin manager that would load the plugin's schema and add it to the main Saleor's schema. How it could work:

we could assume that plugin's schema should always live in the schema.py file in the plugin's main directory. This file would define queries and mutations specific to that plugin.
in module saleor/graphql/api.py, after the main schema is initialized, we should iterate over enabled plugins and discover their schema.py files and load operations that are defined there. Probably there should be some utility function that would handle merging the schemas.

That's just a rough idea, but I think this is how we would like to implement it eventually. What you suggest will work for you @LeOndaz and the solution is fine, as it doesn't add many changes to Saleor, so it will be easier to upgrade to newer versions in the future if you decide to use it.
@korycins Take a look at this when you have time as you have more experience with plugins than I do ;)

Well, both do work, I think you're may be right about "developers shouldn't change settings....." and I agree with you,  we agreed that the idea is to be implemented anyway (ignoring "how" for now), I'll be waiting for us to reach an agreement and for @korycins to reply then I'll implement what we agree on as I don't like to alter with saleor in my project, I usually run git pull tags/ to update it, I don't want the files to conflict with it (probably everyone who uses saleor shouldn't play with it's core files), but plugins aren't really that useful without this feature

Hey @LeOndaz ,
Just letting you know about this as I am not sure if you're already familiar - https://docs.saleor.io/docs/next/developer/extending/plugins#webhook-handler

we could assume that plugin's schema should always live in the schema.py file in the plugin's main directory. This file would define queries and mutations specific to that plugin.
in module saleor/graphql/api.py, after the main schema is initialized, we should iterate over enabled plugins and discover their schema.py files and load operations that are defined there. Probably there should be some utility function that would handle merging the schemas.

IMHO the best way would be extending the BasePlugin and add methods responsible for serving additional plugin's queries and mutations. These methods should be called by the PluginManager to extend the Saleor API.
The easiest way would be, extending Saleor's scheme by all plugins API, no matter if the plugin is active or not.
If we would like to include only the API for active plugins this will require some scheme rebuilds in real-time as the plugin can be activated/deactivated from the dashboard.
@patrys  What do you think?

The biggest challenge I see is the need to rebuild the schema each time the list of active plugins changes as those can be enabled and disabled. There's no point in rebuilding the schema for each individual request but also no obvious way to invalidate an already built one in a multi-server environment.

I think using this method of webhook method is somewhat hacky, I agree with auto detecting schema.py of active plugins + installed apps, Sounds like the right way to do it for me, better ways can come in the future and this specific way can be deprecated by then as it's not something to worry about in the future, but extending is the schema is really needed. Building the schema when a plugin active status changes in real-time is challenging and should be somewhat slow enough to annoy some users, this is why I think it should be a compile time operation, only when the server runs, it builds it, if someone disabled a plugin, basically he should restart the server, what do you think ?

I don't think the server should ever need to be restarted. Saleor was built with ease of containerization and horizontal scalability in mind. Some deployments will run dozens of Docker images, some may run hundreds. I'm also not convinced that all use cases need the schema to change. I could see a plugin callback to synthesize a key-value structure similar to the metadata that would already be part of Saleor's schema. If you absolutely need to modify the schema, there's always Apollo Federation which is already supported by our API.

@patrys Do you something like this?
type Mutation {
    pluginCallback(pluginId: ID!, data: JSON): JSON
}

I think this should do the job for a lot of plugins.

@maarcingebala I was thinking about something like this for queries:
query Foo {
  product(id: "...") {
    name
    generatedFields {
      key
      value
    }
  }
}

For mutations, we could indeed allow something like that:
mutation Foo {
  result: callPlugin(plugin: "...", data: "...")
}

@patrys I think federation is a good solution but it's an overkill just for a plugin that adds a basic thing like reviews, but anyway I used it, have a look at #6439

not stale

not stale

@patrys Months had passed, I'd like to ask if this solution is still relevant, in case I wanted to implement it

@patrys Months had passed, I'd like to ask if this solution is still relevant, in case I wanted to implement it

As I've said above, I'm not too fond of the idea of altering the schema of a running service. If needed, this can always be achieved using GraphQL federation. For other cases, I'd prefer to analyze each problem individually rather than try to find a blanket solution to cover all possible use cases.

As I've said above, I'm not too fond of the idea of altering the schema of a running service. If needed, this can always be achieved using GraphQL federation. For other cases, I'd prefer to analyze each problem individually rather than try to find a blanket solution to cover all possible use cases.

Okay then, I'll put some attention on #6439

Okay then, I'll put some attention on #6439

Btw I was talking about this

@maarcingebala I was thinking about something like this for queries:
query Foo {
  product(id: "...") {
    name
    generatedFields {
      key
      value
    }
  }
}

For mutations, we could indeed allow something like that:
mutation Foo {
  result: callPlugin(plugin: "...", data: "...")
}

Btw I was talking about this

@maarcingebala I was thinking about something like this for queries:
query Foo {
  product(id: "...") {
    name
    generatedFields {
      key
      value
    }
  }
}

For mutations, we could indeed allow something like that:
mutation Foo {
  result: callPlugin(plugin: "...", data: "...")
}


it make the usage of CPU rise soon

it make the usage of CPU rise soon

If you display too much data, it's normal to consume more, the same way an application with a lot of content would consume more. If you still think it's not normal, can you boil down the problem and provide a repro using this template?

Closing due to inactivity. Please open a new issue with a reference to this one if you can follow up with more information.


Using changesets with trans

The docs do mention how to use a changeset with trans. My code is as follows:
defmodule Company.Product do
  use Ecto.Schema
  use Trans, translates: [:name, :description]
  import Ecto.Changeset

  alias __MODULE__

  defmodule Translation do
    use Ecto.Schema

    @primary_key false
    embedded_schema do
      field :name, :string
      field :description, :string
    end
  end

  schema "products" do
    field :name, :string
    field :description, :string
    field :price, :integer
    field :image_slug, :string

    embeds_one :translations, Translations, on_replace: :update, primary_key: false do
      embeds_one :sv, Product.Translation, on_replace: :update
      embeds_one :fi, Product.Translation, on_replace: :update
    end

    timestamps()
  end

  def changeset(struct, params \\ %{}) do
    struct
    |> cast(params, [:name, :description, :price, :image_slug])
    |> cast_embed(:translations) # is cast_embed the right option here?
    |> validate_required([:name, :description, :price, :image_slug])
  end
end

Using cast_embed returns the following error:
** (UndefinedFunctionError) function Company.Product.Translations.changeset/2 is undefined or private. Did you mean:

           * __changeset__/0

What is the correct way to use trans with a changeset?

I was looking into the test files and I found an example:
https://github.com/crbelaus/trans/blob/v2.3.0/test/support/models/article.ex
Hope this helps :D

I was looking into the test files and I found an example: https://github.com/crbelaus/trans/blob/v2.3.0/test/support/models/article.ex
Hope this helps :D

This is correct. In this particular case you should create a translations_changeset and use it in the cast_embed function call. Just like we do here.
I'm closing this issue since this should answer the original question. Feel free to open a pull request to improve the documentation 🙇


qemu: In the set_affinity function, use a round up macro.

Use the DIV_ROUND_UP macro when calculating CPU set size. The original implementation gives the resulting CPU set size greater by 1 in cases where the maximum CPU is a multiple of BYTE_SIZE.
Signed-off-by: Nikolay Martyanov<EMAIL_ADDRESS>

LGTM

lgtm

I added a commit that removes 1 warning message.

@rvs could you please take a look?  The PR is pretty small :)


New Extension: Key Press

An extension that checks how many times a keyboard key was pressed in a period of time ( maximum delay ), works just like the double click extension but for keyboard keys.

Does this also have a function to detect how long a key has been depressed?  (for charging spells/attacks)
Condition: "Button X has been pressed for Y seconds"
I also wonder if it should have an expression that shows the percent complete?
Action: Start an X second long charge named "SuperAttack"
Expression: ChargePercent("SuperAttack")
Condition: "SuperAttack" is charging
Condition: "SuperAttack" is fully charged
Action: Cancel charging "SuperAttack" (the user can use this for key released, or perhaps if the player gets hit while charging)

Just commenting to say that this is a great idea and should simplify the work of many people if this can be flexible enough 👍

Does this also have a function to detect how long a key has been depressed? (for charging spells/attacks)
Condition: "Button X has been pressed for Y seconds"
I also wonder if it should have an expression that shows the percent complete?
Action: Start an X second long charge named "SuperAttack"
Expression: ChargePercent("SuperAttack")
Condition: "SuperAttack" is charging Condition: "SuperAttack" is fully charged
Action: Cancel charging "SuperAttack" (the user can use this for key released, or perhaps if the player gets hit while charging)

Sure, i can try adding a feature like that.

this works

I was wondering what data type is required here?. the parameter type is a "keyboard key", but typing the key as a string doesn't seem to work.

I was wondering what data type is required here?. the parameter type is a "keyboard key", but typing the key as a string doesn't seem to work.

The screenshot doesn't show the action sentence. I don't have enough context to answer.

Okay, I need to take a look at the extension again, I will send an update later in the day.

Okay, I need to take a look at the extension again, I will send an update later in the day.

Do you want to work on this more?  It is probably close to being merged when you are ready.

yes, i will still work on it.

@D8H This was my question, in order to get the key pressed duration I need to get the key user is checking for I used this

the parameter type is a keyboard key

but it still returns an error.

@D8H This was my question, in order to get the key pressed duration I need to get the key user is checking for I used this
the parameter type is a keyboard key
but it still returns an error.

It's really hard to follow with the events being cut.
This parameter type don't accept an expression. If you need call private actions use a text parameter.

okay

oh, ok, I guess the key parameter type can't be used for expression parameter. The UI should probably not show it in the list in this case.


libmicrohttpd_0_9_70: drop

Description of changes
libmicrohttpd 0.9.70 is vulnerable to CVE-2021-3466, which is quite bad.
I've updated all packages using it to use another version.
See also #120393, #128394

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

We can't backport a package drop to stable, but we can mark it as knownVulnerable

Oh, should probably add a throw to aliases.nix for libmicrohttpd_0_9_70

nixpkgs-review happy, macos 10.15, nixos x86_64 & aarch64. pkgsMusl & pkgsCross.aarch64-multiplatform variants build.

We can backport manually without 32f1678683e05e82b454ab3234c10bd01bf0ce6e.

LGTM from the proxysql side, if _69 doesn't contain the issue.

Yes: https://bugzilla.redhat.com/show_bug.cgi?id=1939127#c3 "All libmicrohttpd versions before v0.9.70 were not affected by this bug."


Error with Bake Texture To Mesh

I have a error wit bake texture to mesh :

I have this error in the console : C:\ComfyUI_windows_portable\python_miniconda_env\ComfyUI\Lib\site-packages\torch\include\ATen/cuda/CUDAContextLight.h(6): fatal error C1083: Impossible d'ouvrir le fichier include : 'cuda_runtime_api.h' : No such file or directory
ninja: build stopped: subcommand failed.

I found the solution my path of CUDA_HOME was not the right in environment variable

I found the solution my path of CUDA_HOME was not the right in environment variable

Could you please tell me how to set CUDA_HOME?


fsharp: avoid vanity-alignment

Fixes https://github.com/dotnet/docs/issues/21487

An open question: What about do and do! keywords? (And possibly others.)
In the spirit of this PR, perhaps there should be symmetry between let/let! and do/do!. I'm showing 2 spaces indentation below to make the difference more clear.
// Yes
async {
  let! foo =
    fooBarBaz
    |> loremIpsumDolorSitAmet
    |> theBrownFoxJumpedOverTheLazyDog
  do!
    fooBarBaz
    |> loremIpsumDolorSitAmet
    |> theBrownFoxJumpedOverTheLazyDog
}

// No
async {
  let! foo =
    fooBarBaz
    |> loremIpsumDolorSitAmet
    |> theBrownFoxJumpedOverTheLazyDog
  do! fooBarBaz
      |> loremIpsumDolorSitAmet
      |> theBrownFoxJumpedOverTheLazyDog
}

Here's with 4 space indentation and do in a class.
// Yes
type Foo () =
    let foo =
        fooBarBaz
        |> loremIpsumDolorSitAmet
        |> theBrownFoxJumpedOverTheLazyDog
    do
        fooBarBaz
        |> loremIpsumDolorSitAmet
        |> theBrownFoxJumpedOverTheLazyDog

// No
type Foo () =
    let foo =
        fooBarBaz
        |> loremIpsumDolorSitAmet
        |> theBrownFoxJumpedOverTheLazyDog
    do fooBarBaz
       |> loremIpsumDolorSitAmet
       |> theBrownFoxJumpedOverTheLazyDog

Note that if the do block contains multiple statements, then of course it should be indented in the // Yes fashion above anyway; I think everyone agrees on that. So using the // Yes variants above is more consistent with that, too.
The only downside is that with 4 spaces of indentation, the it may look a bit weird? I'm using 2 spaces anyway, so I'll leave others to decide that.

I'm more than happy to have this added here. @knocte freel free to do it; I don't need my name on any commits.

@knocte freel free to do it; I don't need my name on any commits.

Sorry I'm quite busy these days. You could create a PR on my fork and if I merge it, it would show up here :)

PR created: https://github.com/knocte/dotnet-docs/pull/1
After this is merged, the only outstanding issue for me is the indentation of the body placeholder comments. We already have a discussion of that in another comment. I will ping both of you there.

@cartermp @knocte
@nojaf asked for some clarification in https://github.com/fsprojects/fantomas/issues/657#issuecomment-747536973. I can provide a PR in case the docs need updating; I just want to discuss it first, and while this PR is merged, it seems a good place since it relates only to changes made here.
I have provided a summary at the bottom of how things look with my recommendations. Note that while this is my preference (IMHO it looks balanced and symmetrical), there are no religious feelings involved.
Point 1: Member indentation for records with internal/private constructors
I feel fairly certain about this, but I'm putting it here just to be safe.
This would be my interpretation:
type MyType =
    internal
        { Field1: ..
          ..
          Field2: .. }

    static member Create ..

As opposed to:
type MyType =
    internal
        { Field1: ..
          ..
          FieldN: .. }

        static member Create ..

In the latter example, members are indented relative to the constructor, not the type declaration. Since the constructor is internal, it has one extra level of indentation. Indenting members an extra level too has no benefits, and breaks consistency with normal class members (or members in records whose constructor is not internal/private).
I personally see no need for a clarification on this point in the docs. Let me know if you disagree.
Point 2: Indentation of parameters in long parameter lists
This wasn't asked by @nojaf but was something I saw while replying.
This PR was merged with the following example:
    member _.LongMethodWithLotsOfParameters
        (
            aVeryLongParam: AVeryLongTypeThatYouNeedToUse,
            aSecondVeryLongParam: AVeryLongTypeThatYouNeedToUse,
            aThirdVeryLongParam: AVeryLongTypeThatYouNeedToUse
        ) : AReturnType =
        // ... the body of the method

The return type makes it look a bit lopsided, with an almost empty line at the top but not at the bottom. It becomes even more clear with one parameter:
    member _.LongMethodWithLotsOfParameters
        (
            aVeryLongParam: AVeryLongTypeThatYouNeedToUse
        ) : AReturnType =
        // ... the body of the method

Granted, it looks more symmetrical without a return type:
    member _.LongMethodWithLotsOfParameters
        (
            aVeryLongParam: AVeryLongTypeThatYouNeedToUse
        ) :
        // ... the body of the method

I can live with this, but I'd still like to suggest two ways that both address different aspects of this and could be written into the guide (both of them or either one) - just give the word and I can create a PR.
1. Getting rid of the blank line at the top
I suggest we format the parameter list like a record type definition, with 1 space between ( and the first parameter and between the last parameter and ) (which is at the same line as the last parameter instead of the line with =). I like this consistency with the record formatting, and it looks uncluttered and symmetrical.
    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aSecondVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aThirdVeryLongParam: AVeryLongTypeThatYouNeedToUse )
        : AReturnType =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aSecondVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aThirdVeryLongParam: AVeryLongTypeThatYouNeedToUse )
        =
        // ... the body of the method

For completeness, here is an "in-between" solution that keeps ) on the same line as = (and the return type, if any). I like the above suggestion best, but find both better than the current suggestion.
    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aSecondVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aThirdVeryLongParam: AVeryLongTypeThatYouNeedToUse
        ) : AReturnType =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aSecondVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aThirdVeryLongParam: AVeryLongTypeThatYouNeedToUse
        ) =
        // ... the body of the method

2. Special-case the one-parameter case
Format it like this:
    member _.LongMethodWithLotsOfParameters
        (aVeryLongParam: AVeryLongTypeThatYouNeedToUse)
        : AReturnType =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        (aVeryLongParam: AVeryLongTypeThatYouNeedToUse)
        =
        // ... the body of the method

Note that this isn't critical if point 1 is implemented. With point 1 but without point 2, it looks like:
    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse )
        : AReturnType =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse )
        =
        // ... the body of the method

Though the extra space after ( and before ) is unnecessary, I don't find that it is problematic. If implementing point 1, consider if the special-casing of the 1-parameter case is worth the gain.
Summary of my recommendation
type MyType =
    internal
        { Field1: int
          Field2: string
          Field3: bool }

    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aSecondVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aThirdVeryLongParam: AVeryLongTypeThatYouNeedToUse )
        : AReturnType =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        ( aVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aSecondVeryLongParam: AVeryLongTypeThatYouNeedToUse,
          aThirdVeryLongParam: AVeryLongTypeThatYouNeedToUse )
        =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        (aVeryLongParam: AVeryLongTypeThatYouNeedToUse)  // Or with spaces by the parentheses
        : AReturnType =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        (aVeryLongParam: AVeryLongTypeThatYouNeedToUse)  // Or with spaces by the parentheses
        =
        // ... the body of the method

I personally see no need for a clarification on this point in the docs. Let me know if you disagree.

I agree with the first snippet yeah. Maybe we don't need an extra clarification but there's no harm in adding an extra code snippet.

Granted, it looks more symmetrical without a return type:

Nit: I think the snippet you posted following this sentence has a small typo: should be = instead of : right?

I can live with this

Then let's live with it :)
I mean, TBH I'm not convinced about your proposals because the single-space additions are hard to specify, remember, and follow, IMO. I get your point that it maps better with the way records are styled, but:

You're only talking about the short way of styling records, there's a longer way (which is the one that I exclusively use myself FYI, and in fantomas I enable this via fsharp_multiline_block_brackets_on_same_column=true.
You're focusing too much on members that received non-currified parameters, which is not idiomatic in F#. In fact, if we focus more on currified parameters, we don't have this problem, and in fact for the 1-parameter case it would look like exactly one of the suggestions that you hint at the bottom of your comment:

    member _.LongMethodWithLotsOfParameters
        (aVeryLongParam: AVeryLongTypeThatYouNeedToUse)
        : AReturnType =
        // ... the body of the method

    member _.LongMethodWithLotsOfParameters
        (aVeryLongParam: AVeryLongTypeThatYouNeedToUse)
        =
        // ... the body of the method

AFAIU, this is how one-parameter members/lets should be formatted according to what the guide says at the current moment, because a one-parameter function signature is not a tuple.

Fair enough. :)

Just to be clear, @nojaf wants @cartermp to confirm before implementing this in Fantomas.


Custom AuthorizationHandler HandleRequirementAsync when context fails HC returns AUTH_NOT_AUTHENTICATED instead of AUTH_NOT_AUTHORIZED

Product
Hot Chocolate
Version
14
Link to minimal reproduction
na
Steps to reproduce
I have a custom Authorization handler, and in HandleRequirementAsync, I have my custom authorization logic, when authorization fails, context.Fail() is called, standard asp.net process to handle authorization policy requirement. But when this happens, hotchocolate gives AUTH_NOT_AUTHENTICATED instead of AUTH_NOT_AUTHORIZED  error code, in HC 13 it was returning AUTH_NOT_AUTHORIZED. This is about authorization not authentication, the user is already authenticated by the role does not pass the authorization policy to access the info. Does it sound like a bug or is it by design?
What is expected?
AUTH_NOT_AUTHORIZED should be returned when AuthorizationHandler fails the authrozation check, i.e. revert back to behaviour in HC 13
What is actually happening?
I have a custom Authorization handler, and in HandleRequirementAsync, I have my custom authorization logic, when authorization fails, context.Fail() is called, standard asp.net process to handle authorization policy requirement. But when this happens, hotchocolate gives AUTH_NOT_AUTHENTICATED instead of AUTH_NOT_AUTHORIZED  error code, in HC 13 it was returning AUTH_NOT_AUTHORIZED. This is about authorization not authentication, the user is already authenticated by the role does not pass the authorization policy to access the info. Does it sound like a bug or is it by design?
Relevant log output

Additional context
No response

We need a repro for this.

Here's the handler,
public class GraphQlAuthorizationHandler : AuthorizationHandler<OpaRequirement, IResolverContext>
 {

   protected override async Task HandleRequirementAsync(
     AuthorizationHandlerContext context,
     OpaRequirement requirement,
     IResolverContext resource)
   {

       if （someCustomAuthorisationCheck == true)
         context.Succeed((IAuthorizationRequirement) requirement);
       else
         context.Fail();
   }
}


Version checking not working

Issue with version checking in chimerax.py wherein platform.system() seems to be throwing an error and halting the app from running.

Fixed by importing platform in run_conftopo.py.

Fixed by importing platform in run_conftopo.py.


Missing "employeeID" attribute under the 3rd party apps section

EmployeeID is missing from the 3rd party app selection. EmployeeID was added to the sync scope in version 1.1.524.0 which was released in May 2017. Not sure what other attributes may be missing here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e7abde7c-df25-bd14-574c-92858daed39d
Version Independent ID: 6652a5bc-4985-d45e-36fb-54da408e5e54
Content: Attributes synchronized by Azure AD Connect
Content Source: articles/active-directory/hybrid/reference-connect-sync-attributes-synchronized.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@twimmers thanks for the feedback. This appears to be correct based on the version history. I made a pull request to the doc but will let @billmath make the final call on what's needed and approve/deny the request.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/75904
https://docs.microsoft.com/en-us/azure/active-directory/hybrid/reference-connect-version-history

Closing this out.


WIP: update gradlePluginPortal workaround for JCenter availability issue

Fixing workaround from #3784 which modified metadata sources in build.gradle's subprojects.repositories block, when it should have been made in settings.gradle's pluginManagement.repositories block instead.
Reference: https://discuss.gradle.org/t/plugin-portal-dependency-resolution-failing-due-to-jcenter-usage/44131
This changes dependency resolution to deprioritize gradle plugin portal (with JCenter workaround) in favour of maven central, given the latest availability issues encountered.

Build now passes, but integration test still affected by gradle plugin portal outage:
com.google.cloud.tools.jib.cli.JarCommandTest > testSpringBootJar_packagedMode FAILED
    java.lang.RuntimeException: Command './gradlew clean bootJar' failed:
    FAILURE: Build failed with an exception.

    * What went wrong:
    A problem occurred configuring root project 'spring-boot'.
    > Could not resolve all artifacts for configuration ':classpath'.
       > Could not resolve org.springframework.boot:spring-boot-buildpack-platform:2.3.7.RELEASE.
         Required by:
             project : > org.springframework.boot:org.springframework.boot.gradle.plugin:2.3.7.RELEASE > org.springframework.boot:spring-boot-gradle-plugin:2.3.7.RELEASE
          > Could not resolve org.springframework.boot:spring-boot-buildpack-platform:2.3.7.RELEASE.
             > Could not get resource '[https://plugins.gradle.org/m2/org/springframework/boot/spring-boot-buildpack-platform/2.3.7.RELEASE/spring-boot-buildpack-platform-2.3.7.RELEASE.pom](https://www.google.com/url?q=https://plugins.gradle.org/m2/org/springframework/boot/spring-boot-buildpack-platform/2.3.7.RELEASE/spring-boot-buildpack-platform-2.3.7.RELEASE.pom&sa=D)'.
                > Could not GET '[https://jcenter.bintray.com/org/springframework/boot/spring-boot-buildpack-platform/2.3.7.RELEASE/spring-boot-buildpack-platform-2.3.7.RELEASE.pom](https://www.google.com/url?q=https://jcenter.bintray.com/org/springframework/boot/spring-boot-buildpack-platform/2.3.7.RELEASE/spring-boot-buildpack-platform-2.3.7.RELEASE.pom&sa=D)'.
                   > Read timed out

Hmm. It is available in Maven Central -- https://search.maven.org/artifact/org.springframework.boot/spring-boot-buildpack-platform/2.3.7.RELEASE/jar

Oh! It's probably because the workaround was added for the Jib project itself, but this error / dependency resolution is specific to the test project used in integration testing which has its own minimal gradle configs 🤦♀


[wip] store inv_scale on Float8Tensor

Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:

Stack from ghstack (oldest at bottom):

(to be filled)


do not throw on loading less-than-fatally-broken SBML

Errors are still printed, and people should generally check those during the curation efforts.

PS this is gonna fail until SBML1.4.1 gets out


Configure a Makefile

After checking a few open source Go projects, having a Makefile looks like a must.
Here it is an example project:
https://github.com/percona/mongodb_exporter

Will be resolved in #7.


lc trie: add exclusive flag.

Risk Level: Low
Testing: bazel test //test/...
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

@ccaraman You mean in the IP tagging filter? It could be useful there (e.g. if tags are used for geolocation), but - assuming that you guys are using it - you should probably know better than me.
I'm happy to add it if you think it's going to be useful for you, but I'd rather not block this PR on it.
FWIW, I'm going to use this for destination IP matching in the filter chains.

@brian-pane I did mass update in the comments, looks that I've missed bunch in the original commit.


take inside string misses trailing whitespace

tested with plaintext and go:
"ABC "

"copy inside string air" copies ABC not ABC .

That's intended behaviour. The content range of "inside" trims whitespace; the removal range includes it. We went back and forth on it a bunch but in practice you end up wanting it way more than you don't

OK

in practice you end up wanting it way more than you don't

So far, my experience has been the consistently the opposite. 😅  Perhaps it has to do with the context in which one is editing--I hit this when working with string constants, where precision matters, and I have done a bit of editing already (leaving junk whitespace). Then my copy/bring/move/paste to/chuck/change requires extra cleanup afterwards.
This is settled behavior, so I don't expect it to change, but I felt that I had to comment one last time. :)

Huh interesting. I almost never want the opposite, and am regularly glad for today's behaviour 😅
We could have a boolean on the inside modifier


how to solve a left matrix division efficiently for a very large sparse matrix?

let's assume the following matrices
a sparse matrix 'kk'  26400x26400
a vector 'fg' 26400x1
delta = kk\fg
evaluating delta in matlab takes about ~0.8 seconds
but as there is no left matrix division that i know of in Math.Net i tried to emulate in these ways
1 : delta = kk.Solve(fg);
2 : delta = kk.Inverse() * fg;
but even after 3 whole minutes, it was still evaluating, so am i missing something here?

@bigworld12, I believe Math.Net doesn't provide any direct solvers for sparse matrices. It will try to solve it as a dense matrix which will take a very long time. I use CSparse.Net for sparse matrices (https://github.com/wo80/CSparse.NET/wiki/Math.NET-Numerics-and-CSparse)

(Have you tried the iterative solvers, i.e. SolveIterative?)

@cdrnet which one of them ? (the matrix is square and non-symmetric)
@ajos6183 i already used that but it doesn't have UMFPACK so it gave poor performance with larger matrices compared to matlab

@bigworld12, I may be wrong but would this work?
https://numerics.mathdotnet.com/api/MathNet.Numerics.LinearAlgebra.Double.Solvers/TFQMR.htm

Sorry for the necroing, but what is the suggested approach currently?


New versions of the Safe Paths icon -- linked location pointers

This starts the work to implement the new application icon throughout the
application on both iOS and Android.  Still more to be done.
P.S. I <3 the new icon.  :)

They changed the icon on me!  But the new new one is better anyway, so totally worth it.
Implemented in #386, closing this unmerged.


[move-prover] Remove old bytecode-to-boogie/test_mvir/verify-stdlib tests

These files were temporarily kept around by #3077 but I don't think
they're needed now. We'd like to remove support for get_txn_sender and
it would be hard to update these files for that.
Motivation
Preparing to remove get_txn_sender
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I ran tests in the bytecode-to-boogie directory and didn't see any failures.

@bors-libra r=wrwg

:pushpin: Commit e1db797 has been approved by wrwg

:hourglass: Testing commit e1db7974222f47e73984faca8f0d5e9aa9fbeb7b with merge eff895b023591c8f7ec2babb4d95931a045726fd...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wrwg
Pushing eff895b023591c8f7ec2babb4d95931a045726fd to master...


MC takes 10+ minutes to launch (website down?)

Describe the bug
Minecraft takes upwards of 10 minutes launching with the Chat Triggers .jar file in my mods folder. I tested without other mods, with no mods, and with all my usual mods except chat triggers, and chat triggers seems to be the one causing the issue. Based on what small amount of information I could find from google, I'd hazard a guess that the website being down has something to do with it. I checked for logs, but couldn't find anything relevant.
To Reproduce

Have chat triggers in the mods folder
CT website is down(?)
Launch the game
Wait for it to load (10ish minutes later)

Expected behavior
Before today, MC would load in ~50 seconds.
Screenshots
N/A
Setup (please complete the following information):

OS: Windows 10
ChatTriggers Version: 1.3.2
Minecraft Version: 1.8.9
Java Version: 16.0.1

Additional context
I'd check to ensure my CT is up to date, but the website is down, so I have no way of doing so.
I believe that the website is the issue, since I found a forum post talking about the game not launching with the mod installed, and someone else replied that the website was down. Additionally, the website seemed to be fine a few days ago, and my game was launching fine up until today.

Well, the website is back up, and MC is launching fine again. It's definitely related.

Yup, I just restarted the server. If it happens again just remove CT from your mods folder.


HAS_JAX helper does not work in unit tests

Environment

Qiskit Terra version: sources
Python version: 3.8
Operating system: Mac, Windows

What is happening?
A helper _optionals.HAS_JAX does not work in unit tests. An exception is thrown, see the stack trace. Outside unit tests everything looks good. Initially, an idea was to write a test that works in both cases with and without JAX installed. While this issue probably is not in Qiskit, but in JAX, I'm opening it to let you know.
Here is the stack trace:
(dev-terra38) ... qiskit-terra % python -m unittest test/python/test_jax_presence.py
Eavailable True
.
======================================================================
ERROR: test_jax_presence (test.python.test_jax_presence.TestJaxPresence)
test.python.test_jax_presence.TestJaxPresence.test_jax_presence
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File ".../qiskit-terra/test/python/test_jax_presence.py", line 11, in test_jax_presence
    available = bool(_optionals.HAS_JAX)
  File ".../projects/qiskit-terra/qiskit/utils/lazy_tester.py", line 114, in __bool__
    self._bool = self._is_available()
  File ".../projects/qiskit-terra/qiskit/utils/lazy_tester.py", line 289, in _is_available
    imported = importlib.import_module(module)
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/jax/__init__.py", line 37, in <module>
    from jax import config as _config_module
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/jax/config.py", line 18, in <module>
    from jax._src.config import config
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/jax/_src/config.py", line 27, in <module>
    from jax._src import lib
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/jax/_src/lib/__init__.py", line 102, in <module>
    import jaxlib.pocketfft as pocketfft
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/jaxlib/pocketfft.py", line 20, in <module>
    from . import pocketfft_flatbuffers_py_generated as pd
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/jaxlib/pocketfft_flatbuffers_py_generated.py", line 1, in <module>
    import flatbuffers
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/flatbuffers/__init__.py", line 15, in <module>
    from .builder import Builder
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/flatbuffers/builder.py", line 15, in <module>
    from . import number_types as N
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/flatbuffers/number_types.py", line 18, in <module>
    from . import packer
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/flatbuffers/packer.py", line 22, in <module>
    from . import compat
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/site-packages/flatbuffers/compat.py", line 19, in <module>
    import imp
  File ".../anaconda3/envs/dev-terra38/lib/python3.8/imp.py", line 31, in <module>
    warnings.warn("the imp module is deprecated in favour of importlib; "
DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

----------------------------------------------------------------------
Ran 1 test in 0.033s

FAILED (errors=1)

How can we reproduce the issue?
Run the test. The JAX test fails, while the matplotlib one works fine. JAX and MPL are installed.
import unittest

from qiskit.test import QiskitTestCase
from qiskit.utils import optionals as _optionals

class TestJaxPresence(QiskitTestCase):
    """Main tests of approximate quantum compiler."""

    def test_jax_presence(self):
        available = bool(_optionals.HAS_JAX)
        print(f"available {available}")

    def test_mpl_presence(self):
        available = bool(_optionals.HAS_MATPLOTLIB)
        print(f"available {available}")

if __name__ == "__main__":
    unittest.main()

What should happen?
No exception should be risen.
Any suggestions?
Wait for an update in JAX?

Looks like the object is working ok, but jax itself (or more accurately, a dependency of jax) uses the imp module which raises a DeprecationWarning, and we error on unhandled warnings during test execution.
Does it similarly fail if you use it in a @unittest.skipUnless(_optionals.HAS_JAX) decorator?  I would expect that in that case, the tests should pass, because the jax import will happen during test discovery instead.
It's generally not advisable to write a test that changes its behaviour based on the environment, because it can be very hard to debug failures, and you get inconsistent coverage of the "backup" path. It'd be better to have one test that always uses the alternative (let's say Numpy), and a second test that has the skipUnless decorator but always uses jax if run.

That's right, the Qiskit code looks fine.
I added the decorator and, as you expected, the test passed. And this is a good idea, instead of having two tests in one script I can split JAX/No JAX tests into two independent scripts and the problem is solved! Thanks for the hint!


Repeatedly opening new Taskbar-groups

Hey Guys,
when I launch Taskbar-Groups it will Repeatedly open itself so far that it freezes my PC.
Does anyone else have this problem?

Duplicate of #94


ImportError: cannot import name 'nms_impl' from partially initialized module 'clrnet.ops' (most likely due to a circular import)

The following error appears in the clrnet\ops\nms.py file：ImportError: cannot import name 'nms_impl' from partially initialized module 'clrnet.ops' (most likely due to a circular import) (G:\code\CLRNet\clrnet\ops_init_.py)
Please tell me  how to solve it?

python setup.py build develop

python setup.py build developpython setup.py 构建开发

Hello, I still get this error after compiling according to the instructions. How can I solve it? The situation is as shown in the picture above

你好我也是这个问题请问怎么解决

我直接重新编译clrnet后成功了，运行python setup.py build develop


Problem upgrading zigbee2mqtt edge.

I have upgraded zigbee2mqtt edge add-on on Home Assistant. I copied/pasted my configuration as described but when I reopened the add-on UI. all devices had disappeared and I am having to manually re-add them 1 by 1
How do I upgrade and retain all existing devices in future?

You should not be losing your devices. If you use edge from same repo as the normal one, the only tying to do is to stop the stable and start edge and it should work. I don't remember there being any breaking changes in between them for a while.

I'll close this issue as i've extensively tested moving from stable to edge and updating edge with no devices lost. The only explanation is when we switched repos if you someone didn't get the config moved in time before starting the new edge for the 1st time.
Please open a new issue if you can't upgrade edge in the future without losing devices.


POW Ring POWCT

Home Assistant energy dashboard showing a negative value after daily energy reset at midnight.

https://github.com/AlexxIT/SonoffLAN?tab=readme-ov-file#issues

Hi Alex, thanks for the fast response, I did look through this at the time of installation and I didn't think this was the issue with the update interval as the daily power updates every minute or two.
It may be an issue with the sensor setup would I be right in thinking a total daily power sensor should have a state class of 'total_increasing' where as mine is setup for state class 'total'.
state_class: total
unit_of_measurement: kWh
device_class: energy
friendly_name: POWER _METER Energy Day

![Screenshot_2024-11-25-00-23-48-
01_c3a231c25ed346e59462e84656a70e50](https://github.com/user-attachments/assets/6845c6c7-e67a-4595-870d-1503909f100e)

I have changed the state class in the /homeassistant/custom_components/sonoff/sensor.py from total to total_increasing as the home asssistant customise option would not work for me.
class XEnergyTotal(XSensor):
_attr_device_class = SensorDeviceClass.ENERGY
_attr_native_unit_of_measurement = UnitOfEnergy.KILO_WATT_HOUR
_attr_state_class = SensorStateClass.TOTAL_INCREASING

It's better to start from device diagnostics. I have no idea what device you're talking about. I don't know them all by name.


FI-2700: Initial version of FHIRPath service

Summary
Initial version of a FHIRPath evaluation service, just a straight copy of the relevant pieces of the inferno fhir-validator-wrapper https://github.com/inferno-framework/fhir-validator-wrapper with all of the validator pieces removed. Most of the files left here should be identical to the validator-wrapper version. The minor file changes that do exist include updating the name of the repo and project, simplifying some of the code where possible, and simplifying the dockerfile so it doesn't need 2 stages.
This server hosts 2 endpoints:

/evaluate which takes a request param of a FHIRPath string and a request body of a FHIR resource, and returns the results of evaluating that FHIRPath against that resource
/version which reports the version of this service and the hl7 core library version

By default it runs on port 6789 but that can be changed with the FHIRPATH_PORT env var.
Testing Guidance
Results should be the same for any request against this service as against the inferno validator-wrapper.
Sample request:
GET http://localhost:6789/evaluate?path=Patient.id

{"resourceType":"Patient", "id": "1"}

returns
[
  {
    "type": "id",
    "element": "1"
  }
]

Since this is a brand new repo but all the code comes from a different one, consider using a diff tool to compare this repo to the inferno validator-wrapper to confirm what changed makes sense. (Personally I use kdiff3, available on mac via brew)

@karlnaden since that test kit will be the primary user of this, at least in the short term, it is important that what we have here actually works with it. For the purposes of this PR/ticket maybe let's say done is "confirmed working as a drop-in replacement for the inferno validator-wrapper", and then if there are other enhancements/nice-to-haves requested, those can be separate items?

For the purposes of this PR/ticket maybe let's say done is "confirmed working as a drop-in replacement for the inferno validator-wrapper"

To confirm "drop-in replacement" we need to actually integrate it into the PAS test kit then. I'm not sure I'm the right person to do that, or at least not in terms of setting up the infrastructure (putting this into inferno's docker services, creating a way in Ruby to connect to it), though I could try. Either way, I won't be able to get to it until after the connectathon / WGM next week.  @dehall do you think you'd be able to get the infrastructure pieces in place in a supporting inferno_core PR and then I can try to get it all working with PAS when I get back? Or is there a better division of labor?


App needs a retry button for initial cafe dial attemp failure

Currently if the first dial attempts fail the app will error our in an unusable state

I'm not sure how/where to catch that error, and if we do, can I give some sensible information (e.g. "Be sure to check your internet connection which is required to connect to the Textile & IPFS network") and a "Retry" button.

is this still a possible issue @asutula @sanderpick ?

with the cafes part of onboarding, i could see a retry button after selecting one

now via url, fixed


fix sender_nonce vs tx_nonce handling inside begin tx

Description
[PR description]
Issue Link
[link issue here]
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Contents

[item]

Rationale
[design decisions and extended information]
How Has This Been Tested?
[explanation]

How to fill a PR description
Please give a concise description of your PR.
The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.
MUST: Reference the issue to resolve
Single responsability
Is RECOMMENDED to create single responsibility commits, but not mandatory.
Anyway, you MUST enumerate the changes in a unitary way, e.g.
This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices
RECOMMENDED to:

What types of design choices did you face?
What decisions you have made?
Any valuable information that could help reviewers to think critically

\b run testool


Add scenario (docs) for copying & transforming event streams (for versioning…

…, data modification)

@jokokko quick comment, could you please fix the tab spacing in code changes to use 4 tab spaces?

@jokokko this sample is interesting and something that we don't have covered. I was thinking about for quite some time. Is this something that you applied also practically in your project?
I have few concerns that we'd need to diccuss.
From my practice, my common scenario for working with event streams was:

Create Stream, publish some events.
Create projection (inline, or custom) that is updated during publishing events from streams.

Then while working on aggregates and getting actual aggregate stream - use online aggegation so AggregateStream method. (so this is how I was working with write model).
While doing queries I was using projection. So Inline projections, as they are snapshots of the write model state - I was using for the write model validation, etc. Custom projections - for the read model.
So having those end usage scenarios, let's consider how this sample would help, or what might be missing.

If we create copy of the stream, with new Id then we will get new record in our read model. How will we know that it's just a new "proper" item? How will we distinguish that we should not use old one? Imho we should publish "delete event" for the old stream. Having that for custom projection we could use DeleteEvent to remove the old record. For inline projection we don't have yet automated mechanism for deleting projection item, but it can be tricked (let's not get into details right now how...). So Delete Event should more or less should solve the case for read model.

Write model. This is the harder part. Currently we don't have the way to mark the stream as "deleted", or "obsolete". At least none built in way. We could think about some "tombstoning" but still, no out of the box solution. But having "delete event" suggested in the previous point we could implement custom "soft delete".

So to sum up, imho we should add to this sample also publishing delete event for the old stream. Having that it would make possible to remove the record from projection and also mark the stream as "deleted"/"inactive", so make soft delete with custom logic.
Imho this will make this sample more complete and more helpful for the end usage. Also maybe we could show mor real life sample - like bank account, rather than slaying monsters? :)
@jokokko what are your thoughts?

@jokokko and @oskardudycz are we planning to add further docs or we are good with this PR and add any docs further as another PR?

@mysticmind that's more question to @jokokko. From my perspective it would be nice to extend this scenario with handling DeleteEvent.

@oskardudycz shall we go ahead to merge the current changes and raise a separate issue for your comments?

@oskardudycz since you merged this, I have set the milestone for this back to 3.5.0


[2010-10-18] Databases other than MySQL don't modify existing data for enumerated fields

created by: @halkyon (sharvey)
created at: 2010-10-18
original ticket: http://open.silverstripe.org/ticket/6117

When modifying the default value of an "Enum" DBField type in sapphire, the default value never gets fixed when dev/build is called. The reason for this is because MySQL uses enum data types, whereas MSSQL and PostgreSQL use constraints "CHECK" and "IN" keywords to check the values.
This code in particular not work with MSSQLDatabase, or PostgreSQLDatabase because it assumes the data type will always be an enum.
        } else if($fieldValue != $specValue) {
            // If enums/sets are being modified, then we need to fix existing data in the table.
            // Update any records where the enum is set to a legacy value to be set to the default.
            // One hard-coded exception is SiteTree - the default for this is Page.
            foreach(array('enum','set') as $enumtype) {
                if(preg_match("/^$enumtype/i",$specValue)) {
                    $newStr = preg_replace("/(^$enumtype\s*\(')|('$\).*)/i","",$spec_orig);
                    $new = preg_split("/'\s*,\s*'/", $newStr);

                    $oldStr = preg_replace("/(^$enumtype\s*\(')|('$\).*)/i","", $fieldValue);
                    $old = preg_split("/'\s*,\s*'/", $newStr);

                    $holder = array();
                    foreach($old as $check) {
                        if(!in_array($check, $new)) {
                            $holder[] = $check;
                        }
                    }
                    if(count($holder)) {
                        $default = explode('default ', $spec_orig);
                        $default = $default[1];
                        if($default == "'SiteTree'") $default = "'Page'";
                        $query = "UPDATE \"$table\" SET $field=$default WHERE $field IN (";
                        for($i=0;$i+1<count($holder);$i++) {
                            $query .= "'{$holder[$i]}', ";
                        }
                        $query .= "'{$holder[$i]}')";
                        DB::query($query);
                        $amount = DB::affectedRows();
                        $this->alterationMessage("Changed $amount rows to default value of field $field (Value: $default)");
                    }
                }
            }
            Profiler::mark('alterField');
            $this->transAlterField($table, $field, $spec_orig);
            Profiler::unmark('alterField');
            $this->alterationMessage("Field $table.$field: changed to $specValue <i style=\"color: #AAA\">(from {$fieldValue})</i>","changed");
        }

I think having this work with CHECK and IN clauses would be helpful, as MySQL is the only supported database we have which supports the enum data type and so this is not useful being in the abstract Database class if it doesn't work for other databases.

This code is still present in 4.x-dev, but I believe that other parts of the system ensure that any existing data is added to the set of legal values, to keep dev/build non-destructive. This is the behaviour that we would expect to continue if we drop enum support for #8401. It's possible that the fix here is simply to deprecate the relevant code: https://github.com/silverstripe/silverstripe-framework/blob/4/src/ORM/Connect/DBSchemaManager.php#L715


Running tile38-server detached

Is it possible to run tile38 detached (no console output, only in the background)? I'm currently it on a server and I need it to run in the background.
I've tried:
./tile38-server &
Python: subprocess.Popen(["./tile38-server"], stdin=None, stdout=None, stderr=None, close_fds=True, shell=False)

Found out how to do it.
How to:
nohup ./tile38-server &

Also, in caseyou need zero stdout/stderr output to the nohup.out file:
nohup ./tile38-server -q &

Thank you tidwall!


Remove bug label from the issue template

When I created the issue template, I was expecting that we would get fewer people opening bugs when they can't build dlib, so I added the bug label to all submitted bugs.
However, that is not the case, and we still get bug reports which are not really bugs, and this label prevents the @dlib-issue-bot from closing them if there's no activity.
I think the bug label should only be added manually after verifying that the bug report is actually a bug.

Yeah agreed.


ARGV: add missing "--force" arg to formula_install_option_names

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

This fixes an erroneous warning when running brew install --force foo. This would currently trigger a warning about the foo formula not having a --force option.
e.x. Warning: foo: this formula has no --force option so it will be ignored!
This fixes #2053

Thanks @JCount 🎉


Check license

The license must be placed inside the script root filesystem.
Solution for Microsoft/nav-docker#75

Thanks.
This was implemented slightly differently.
Now the license file is copied to a shared folder if needed.


Truncate don't work in Command/Scroll area

Hello, I would like to have a combobox component, with a scrollable area. I set a fixed width to 200px. The problem is when the number of characters exceeds the width, my truncate attribute (from tailwindcss) doesn't work because of the ScrollArea. I tried without it and it works. Do you have a solution for using truncate with ScrollArea?
My code:
<CommandGroup heading={'Wallets'}>
  <ScrollArea className='h-[96px]'>
    {wallets.map(wallet => (
      <CommandItem
        key={wallet.id}
        onSelect={() => {
          setWallet(wallet)
          setPopoverOpen(false)
        }}
        className='text-sm'
      >
        <Avatar className='mr-2 h-5 w-5'>
          <AvatarImage
            src={`https://avatar.vercel.sh/${wallet.id}.png`}
            alt={wallet.name}
          />
          <AvatarFallback />
        </Avatar>

        {wallet.name}  <----- HERE

        {selectWallet?.id === wallet.id && (
          <Icons.check className='h-4 w-4' />
        )}
      </CommandItem>
    ))}
  </ScrollArea>
</CommandGroup>

Screenshot:

@Natchii59 https://github.com/radix-ui/primitives/issues/926#issuecomment-1266790070

I was running into a similar issue (child elements of a ScrollArea not respecting w-full).
After finding this issue, here's a simple workaround for shadcn adapted from the radix-ui issue thread:
{children}


Bug fix. Use 'loop' outside for-block.

Will fail if articles_page.has_previous() == False. Because loop is referenced outside for-block.

Your update doesn't work for me at all; all of the closing tags end up out of order so the .columns that are supposed to contain the article cards end up all over the place. The loop does still seem to be in scope outside that for block.

Per textbook/bulrush#5 this became an issue with Jinja 2.9; I have now fixed it, see 2202003 and the PR getpelican/pelican-themes#480


[release-1.14] telemetry api: add support for TracingSelector

This is an automated cherry-pick of #38250

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
c6872bbf784d1cff1cef25e3fd426322d31d4684
link
true
/test lint_istio_release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
c6872bbf784d1cff1cef25e3fd426322d31d4684
link
true
/test lint_istio_release-1.14

unit-tests_istio_release-1.14
c6872bbf784d1cff1cef25e3fd426322d31d4684
link
true
/test unit-tests_istio_release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint_istio_release-1.14
/test unit-tests_istio_release-1.14

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.14
c6872bbf784d1cff1cef25e3fd426322d31d4684
link
true
/test lint_istio_release-1.14

unit-tests_istio_release-1.14
c6872bbf784d1cff1cef25e3fd426322d31d4684
link
true
/test unit-tests_istio_release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

not sure what happened with lint and unit tests, closing in favor of manual cherry-pick PR# 38753


Minor additions to io-sim and io-sim-classes

Add asyncThreadId to MonadFork
Add forkWithUnmask to MonadTimer
Implement derived timeoutAfter

Note that in order to correctly implement timeoutAfter, we needTimeouts to be comparable for equality; that was already the case, but we did not require it in MonadTimer; now we do.
Adding a few people as reviewer, not because it's all that tricky but because I don't know who's around. However, implementation of forkWithUnmask would benefit from a careful check. I think it's probably okay, but not 100% sure.

Going to push another commit to this PR, with a change to MonadAsync.

 For the simulator this required to add an additional function to Async (coyoneda).

Thanks for the review @coot !
bors r+


Update README.md with new app screenshot

Adding new image for the README file. Reflects redesign as of 10.0. Also is retina-ready for high resolution screens.

Sweet, I made an issue for this already #85

Hi, thanks for the PR but we're going to have to change it in the github pages to reflect the new style to the project site as well.

@MichielDeMey I can do that if you'd like. If not here is the screenshot used.
https://www.dropbox.com/s/7ijw6d1m14bqi3s/Screenshot 2017-02-22 08.59.12.png?dl=0

@mirshko Can you add the PNG file to the project as part of this PR? Then we can simply include it with an <img> tag in the README
ie. <img src="screenshot.png" />

@MichielDeMey @mirshko I've already gone ahead and updated the gh-pages branch though I had to redo the screenshot since the original one wasn't transparent

@gillesdemey Done!

LGTM!


Unexpected result when deleted embedded collections

Scenario: Before deleting an embedded collection, the original collection shall be backuped.
The script is listening for the onFlush Event.
For Updates this works fine:
foreach ($uow->getScheduledCollectionUpdates() AS $col) {
    $col->getSnapshot(); # gives me the original collection -> works as expected
}

However this does not work for Deletions:
foreach ($uow->getScheduledCollectionDeletions() AS $col) {
    $col->getSnapshot(); # is allways empty. -> does NOT work as expected

    # Also empty (which I consider to be really strange: as OriginalDocumentData is documented as "The original data is the data that was present at the time the document was reconstituted from the database"):

    $org = $uow->getOriginalDocumentData( $col->getOwner() );
    $mapping = $col->getMapping();
    $org[$mapping["fieldName"]]; # empty; but it should have the original collection, which is going to be deleted
}

Any Ideas?

Hi can you provide a test in phpunit against the latest github version? I am trying but I cannot reproduce.

I'm still on old version... when I'll update, I'll test again and write a test..


Remove hasNan check over array_contains

Closes #5446
As a sub-task of removing hasNan config, this PR is to remove hasNan check over array_contains.
Signed-off-by: sperlingxx<EMAIL_ADDRESS>

build

build


switchlink_address unit test

This PR contains the UT written for switchlink_address.cc belonging to krnlmon/switchlink directory.
Test cases added:

addIpv4Address
deleteIpv4Address
addIpv6Address
deleteIpv6Address

Test Cases Execution:
Output:
Running main() from /home/akumar/dev_dir/open-source/ipdk.recipe/setup/gtest/googletest/src/gtest_main.cc
[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from SwitchlinkAddressTest
[ RUN      ] SwitchlinkAddressTest.addIpv4Address
[       OK ] SwitchlinkAddressTest.addIpv4Address (0 ms)
[ RUN      ] SwitchlinkAddressTest.deleteIpv4Address
[       OK ] SwitchlinkAddressTest.deleteIpv4Address (0 ms)
[ RUN      ] SwitchlinkAddressTest.addIpv6Address
[       OK ] SwitchlinkAddressTest.addIpv6Address (0 ms)
[ RUN      ] SwitchlinkAddressTest.deleteIpv6Address
[       OK ] SwitchlinkAddressTest.deleteIpv6Address (0 ms)
[----------] 4 tests from SwitchlinkAddressTest (0 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test suite ran. (0 ms total)
[  PASSED  ] 4 tests.

Test time =   0.00 sec
Test Passed.
"switchlink_address_test" end time: May 31 16:29 IST
"switchlink_address_test" time elapsed: 00:00:00

Are there any negative cases you can test? (This might boost your test coverage...)
Added 2 negative test cases as you pointed out. Shared the updated coverage report as well.

Just to add, to cover each and every possible scenario a function could return, the dummy function will become equally intelligent in terms of the logic we are going to put in it. For complex functions, dummy functions will become equally complex.
What are your thoughts?

Just to add, to cover each and every possible scenario a function could return, the dummy function will become equally intelligent in terms of the logic we are going to put in it. For complex functions, dummy functions will become equally complex. What are your thoughts?

Not worth the added complexity for the few extra percent it would eke out.