html: move parts to head.html, sidenav.html and breadcrumbs_aside.html

In order to make it easier to find the content, in this PR some parts of layout.html are split to new files head.html and sidenav.html. At the same time, versions.html is merged into sidenav.html.

@Blendify, I tried, but test_builders.py seems to choke on it: https://travis-ci.org/readthedocs/sphinx_rtd_theme/jobs/632443541

Please also update the tests

Will try to look into the tests

Will try to look into the tests

I'd be glad to be given any hint. I had a look at it, but tests feel fragile and I was not able to run tox in a container..

I would compile documentation with and without this patch and then diff two
html files to see if there is any difference
On Mon, Mar 2, 2020, 16:31 eine<EMAIL_ADDRESS>wrote:

Will try to look into the tests
I'd be glad to be given any hint. I had a look at it, but tests feel
fragile and I was not able to run tox in a container..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/readthedocs/sphinx_rtd_theme/pull/863?email_source=notifications&email_token=ADT2426WBJ7CQJKS6TCBR5TRFQQTHA5CNFSM4KCJ77Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENRB7ZY#issuecomment-593633255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADT242YAG4DEFBBIAE2UYLDRFQQTHANCNFSM4KCJ77QQ
.

It would be best to raise issues for large changes to discuss the changes first.
The largest issue with moving these pieces around is that a number of themes extend from our theme and changes to how the files are structured can break downstream usage. Moving files around is something it makes sense for us to be careful with.
So I'd probably be -1 on moving files around, I see more potential problems from the change than benefits.

@agjohnson, the purpose of this PR is precisely to make it easier for downstream themes to extend/enhance some parts of it. Having everything together makes it difficult to keep rebasing on top of master, because potentially all the significant modifications to the layout do produce conflicts. Very specifically, ad-hoc snippets which are exclusive to projects hosted on RTD are present in the middle of the layout. After this PR, all those snippets are located at the bottom, which makes it easier to modify. See body.html and sidenav.html.

Overall, I agree that having content split out would be easier, if we had started there. Unfortunately, we can't easily move these blocks around for two reasons:
It would also potentially cause problems for anyone that has a body.html or sidenav.html as this will affect include resolution order of our own templates -- we'd load their body/sidenav first.
The larger issue I'm concerned about is that anyone with a template layout.html which was overriding a block or a nested block that has now been moved to body.html will abruptly have their content changed back to our our default content. The block now exists in body.html and would need to be overridden with a matching body.html extended from our body.html by anything downstream.
In terms of the use case you're describing, users don't need to rebase on top of master in order to alter our templates. To customize a template, users only need to include a _templates/layout.html which looks like:
{%- extends "!layout.html" %}

{% block footer %}
   ...
{% endblock %}

The Sphinx docs touch on this in their templating guide. We should perhaps have docs on this as well, or at least point to the Sphinx docs.

It would potentially cause problems for anyone that has a body.html or sidenav.html as this will affect include resolution order of our own templates -- we'd load their body/sidenav first.
The larger issue I'm concerned about is that anyone with a template layout.html which was overriding a block or a nested block that has now been moved to body.html will abruptly have their content changed back to our our default content. The block now exists in body.html and would need to be overridden with a matching body.html extended from our body.html by anything downstream.

Yes, this would be a breaking change, and should be released as such.

In terms of the use case you're describing, users don't need to rebase on top of master in order to alter our templates. To customize a template, users only need to include a _templates/layout.html which looks like:
{%- extends "!layout.html" %}

{% block footer %}
   ...
{% endblock %}

I think that this is limited to the granularity defined in the template. Which might be too coarse for multiple tweaks. For example, sidebartitle includes the logo, title, version and search box.

Yes, this would be a breaking change, and should be released as such.

Backwards incompatible changes are something that we only do when necessary. To me, this PR doesn't describe enough potential benefit to warrant the breaking change. The upside might be to improve extensibility of the theme, however causing downstream breakage is going to be an overall negative experience to our users/customers, no matter how we describe backwards incompatibility.

I think that this is limited to the granularity defined in the template. Which might be too coarse for multiple tweaks. For example, sidebartitle includes the logo, title, version and search box.

There might be a more specific issue in here. However, it's still normal usage to override nested blocks using the standard Sphinx templating flow, no hard fork required. The only case I see for forking the theme is if you want to generate style/color changes in our base stylesheets.
However, I think what you have highlighted is a few things that the theme is not communicating well:

How you should expect to extend the theme. The answer here is to use local _templates overrides or create a theme based on our theme
What blocks we have documented and how there are used
How to override individual blocks

I think documenting these would have provide much more value to users then code reorganization and wouldn't induce backwards incompatible changes. Overall, the theme is lacking a lot of documentation it should have, so any additional documentation would likely be a larger net benefit.
I'm sorry to close this PR, however I don't see this one getting merged due to the potential problems for downstream users/customers.


fix: Implement dynamic login/logout button based on user's logged in state [DEV-3092]

[x] Implement dynamic login/logout button based on user's logged in state.

Task linked: DEV-3092 SPIKE: Implement dynamic login/logout button based on user's logged in state

@abdulla-ashurov @anikitinDSR this looks like it is reviewed, is there anything blocking merging this?

@abdulla-ashurov @anikitinDSR this looks like it is reviewed, is there anything blocking merging this?
This PR can be merged after that PR because it requires changes from previous mentioned PR.


[Feature Request] Config YAML schema validator

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Yes, users can edit YAML freely, but they don't know if it's valid before running the program.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Using JSON Schema, create our YAML and JSON specific config files.
YAML files should be convertible to JSON.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Ajv (Ajv JSON schema validator)
Additional context
Add any other context or screenshots about the feature request here.

I think I will be implement this on the library itself.


why selected date  gets resized ?

Selected Date gets Resized

u can see selected date in Blue  size is bigger than other dates in the view..

And yes i m using selector to change background but i have used same selector like other dates showing just with BLUE colour..

below code solved the problem
`  ColorDrawable shapeDrawable = new ColorDrawable();
shapeDrawable.setColor(Color.TRANSPARENT);
view.setSelectionDrawable(shapeDrawable);
    view.setBackgroundDrawable(drawable);`


pekko-cluster shell script needs to remove akka refs

https://github.com/apache/incubator-pekko/blob/main/cluster/jmx-client/pekko-cluster

Not just superficial println text
also JMX and other akka refs in the script

Hi,
here's the PR for the fix.
Best,
Denny

PR is merged- https://github.com/apache/incubator-pekko/pull/127


Electron Trigger Scale Factors: Wrong arguments passed to get electron trigger scale factors

The function get_ele_sf was updated to include 2023 Electron SF, which required an additional argument phi.
The function sf_ele_trigger is not updated to also pass phi as an argument and hence fails, because ele_counts gets passed to phi and 'trigger' gets passed to counts.
def get_ele_sf(
        params, year, pt, eta, phi, counts=None, key='', pt_region=None, variations=["nominal"]
):
  ...

def sf_ele_trigger(params, events, year, variations=["nominal"]):
  sf_dict = get_ele_sf(
    params,
    year,
    ele_pt_flat,
    ele_eta_flat,
    ele_counts,
    'trigger',
    variations=variations,
  )

Hi, Thanks for opening the issue.
I have fixed this in the upcoming PR with the Weights improvement :+1:


TS complain "Variable is used before being assigned." even assigned Variable in loop without any condition.

TypeScript version : 3.9.6
I don't know this is a bug or not.
TypeScript complain "Variable 'num' is used before being assigned" even in foreach loop there is no condition to set num = 0
So 100% sure that num would be 0 . Is not it?

Duplicate of #9998. Would be solved by #11498.

// typescript version 3.9.2
interface Obj {
  a: number;
  b: number;
  c: number;
}

let obj2: Obj = {
  a: 2,
  b: 3,
  c: obj2.a + obj2.b,   // Block-scoped variable 'obj2' used before its declaration
};

let obj: Obj = {    // Property 'c' is missing in type '{ a: number; b: number; }' but required in type 'Obj'
  a: 2,
  b: 3,
};
obj.c = obj.a + obj.b;

This code is 100% valid in JavaScript.


Question about training for the embedding network of the discriminator

I'm sincerely thanks for sharing your wonderful work and its code publicly.
As I searched your code, I have a question about the training logic for the embedding network of the discriminator.
In this line :
https://github.com/shrubb/latent-pose-reenactment/blob/master/discriminators/no_landmarks.py#L156
embed = None
if hasattr(self, 'embed'):
    embed = self.embed(label)

fake_in = fake_rgbs
fake_score_G, fake_features = self.pass_inputs(fake_in, embed)
fake_score_D, _ = self.pass_inputs(fake_in.detach(), embed.detach()) # what I want to discuss!

real_in = target_rgbs
real_score, real_features = self.pass_inputs(real_in, embed)

data_dict['fake_features'] = fake_features
data_dict['real_features'] = real_features
data_dict['real_embedding'] = embed
data_dict['fake_score_G'] = fake_score_G
data_dict['fake_score_D'] = fake_score_D
data_dict['real_score'] = real_score

Is there any specific reason to detach the embedded features when we calculate adversarial loss for discriminator on fake images?
In addition, only by this way, can we guarantee that the embedder's features will be differently mapped among indices?
I think a trivial solution can exist unless we do not apply a regularization term for those features, e.g., uniformity.
Best,
Junsoo Lee

안녕하십니까, 준수씨.
Good questions. Made me reflect for a while.
As for that .detach(), I wandered around the code and couldn't understand why it's there. It feels like the system would still work without it. My only hypothesis is that it was a measure in the "Few-Shot Talking Heads" to weaken the discriminator a little bit, so that generator is given more chances to win. Maybe the projection discriminator paper will give you more insights, or you can ask the author of our base paper.
Now to your second question. In traditional GANs, the discriminator is asked "does this image look realistic?". We wanted the discriminator to answer a more complex question, "does this image look (1) realistic and (2) like a valid frame from the ith video?". That's why we employed the so-called projection discriminator. Its architecture is so that its output (real/fake score) is a dot product of two vectors, one predicted by discriminator's convolutional part and one taken from W. If you initialize W with a trivial solution — say, one vector copied to all rows, — the discriminator won't know which video it's dealing with (i.e. won't know i), so it will only be able to measure general realism (i.e. answer question (1)).
Now note that the discriminator's matrix (self.embed, also known as W) is trained only to help discriminator tell real from synthesized. So the adversarial loss will force discriminator to learn different vectors in W.


[patch] do not copy falsy values to extended

Summary
DynamoDB will throw on empty strings or falsy values do not copy irrelevant data.
Changelog
Added.
Test Plan
Test added

@Swaagie id also update minimum version of Dynastar to be 1.1.0 in this module to make sure we have proper deducing throughout the models we leverage


Updating to latest SQL Tools Service (.61) to take DacFx fix

Main change since last Tools Service version:

Updating DacFx dependency to take a couple bug fixes, namely for a bug that prevents applying a schema compare result to a database, if that result includes Edge/Streaming objects. (Fixes https://github.com/microsoft/azuredatastudio/issues/13246)

Pull Request Test Coverage Report for Build 394781503

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.254%

Totals

Change from base Build 392661845:
0.0%

Covered Lines:
21854

Relevant Lines:
48612

💛  - Coveralls


ui-react-starter: missing package-lock.json

Hi there!
Thanks for providing these great examples. I've been able to successfully load a few of them but I was having an issue with ui-react-starter. When running yarn install the preinstall script is kicking off and it is requiring a package-lock.json that doesn't exist.
Since the guide for this plugin is recommending to use yarn it is safe to remove the use of the preinstall script because the sole purpose of npm-force-resolutions is to mimic yarn's dependencies resolution without needing yarn. We will also need to commit the yarn.lock to make it work properly.
With these changes I am able to run the plugin on my end:

Happy to submit a PR if needed but the repo is currently not open to outside contributions :)

Hi @rsylvian, we'd love for you to submit a PR! It looks like we need a CONTRIBUTING file on the repo.

@ashryanbeats Hey! I'd like to work on this issue and 3 others related to ui-react-starter


X-axis values appear weird after disabling other plots

The data has a value of float with one precision but the x axis shows float with more than 10 precision when only that particular plot is kept enabled. See image

                tick: {                     fit: true                 } is working kind of reverse, keeping it true shows un-uniform axis and making it false fixes it. Not sure what's happening.

@scottydelta Could you please put this into a JSFiddle? Seems like a bug to me...

@aendrew , I would love to put that on the JSFiddle but I dont have access to the data which was causing this anymore, just the code. Let me know if that helps.
thanks

No response + duplicate of more recent issue


Official status of metalsmith?

Hi,
Enjoying the simplicity/ ease of use of this project. But what is its official status?
The 18 open pull requests and 39 issues as well as multiple npm "vulnerabilities" in metalsmith plugins doesn't give a great impression. Is it being maintained at all? I still see value in this project and find it the simplest of all static site builders (in fact I just migrated my Jekyll gh-pages to metalsmith).
See also #243 & #288

@ismay any insight as to why a new release hasn't happened since https://github.com/segmentio/metalsmith/commit/6596912d089e8e0a55b958f424822b192d03ecd8? Is there nothing in the last 70 commits that a user running npm i metalsmith@latest wouldn't benefit from?

I'm not sure if @woodyrew has publishing rights for the core package already. I think that that's the main holdup.

Personally I think that metalsmith as a project would also look better if segment's metalsmith related packages were transferred to the metalsmith org. We've been maintaining them diligently so it's not like we'd have anything but the best intentions for the project. But it seems segment does not share that sentiment.


Support tsc (TypeScript compiler) output format for file links in terminal

VSCode supports clicking file paths referenced in the terminal, optionally including line numbers and column indices, and jumping to the referenced file at the given position.
See, e.g., https://github.com/microsoft/vscode/issues/156439.
However, it does not understand the tsc output format:
path/to/file(4,1): some error message

... where 4 above is the line number, and 1 is a column offset.
Clearly it understands this in a problem matcher somewhere as the integration with tsc at edit time is working. It'd be nice to also understand it in the terminal, for times when tsc is run from there.

I believe this is already fixed, can you see if you can reproduce in the Insiders build? Let us know if not.


Init message when receiving bootstrap finish

After receiving the bootstrap finish message, the client must follow the
step 3: Clean-up after successful Bootstrapping

[...] Successful Bootstrapping means that the Bootstrap-Finish operation has
been received by the LwM2M Client and the loaded configuration is considered
consistent by the LwM2M Client. In this case the Bootstrap-Finish response code
sent to the LwM2M Bootstrap-Server is 2.04 (Changed).
If Bootstrapping was unsuccessful, the Bootstrap-Server Account MUST retain the
values it had before the unsuccessful Bootstrapping sequence started and further
statements

Hi @hadrienk,
Fixes like this should target upstream Zephyr repository (https://github.com/zephyrproject-rtos/zephyr). Once merged we'll integrate them here in an upmerge.

DNM until Upmerge #296 will be merged

This change is already in Zephyr tree.


Add new Electronize CLI command

Add  Electronize CLI command 'clear cache' or something like this to have a possibility to clean cache manually as it can be done in code :
await browserWindow.WebContents.Session.ClearCacheAsync();

I implemented a new CLI command:
electronize start /clear-cache
Every new window will created with an clear cache.
This new feature is aviable with the new Electron.NET Version 8.31.1


Qubit Allocation Analysis Pass

Qubit Allocation Analysis
Dependencies
This PR depends on #1092.
Purpose
The purpose of this pass is to analyse the code for qubit allocations and identify
the allocation dependency. This helps subsequent transfomation passes expand the code
to, for instance, eliminate loops and classical logic. This is desirable as the control
logic for some quantum computing systems may be limited and one may therefore wish
to reduce its complexity as much as possible at compile time.
Quick start
The following depnds on:

A working LLVM installation, including paths correctly setup
CMake
C#, Q# and the .NET framework

Running following command
% make run

will first build the pass, then build the QIR using Q# following by removing the noise using opt with optimisation level 1. Finally, it will execute the analysis pass and should provide you with information about qubit allocation in the Q# program defined in ConstSizeArray/ConstSizeArray.qs.
Detailed run
From the Passes root (two levels up from this directory), make a new build
% mkdir Debug
% cd Debug
% cmake ..

and then compile the QubitAllocationAnalysis:
% make QubitAllocationAnalysis

Next return examples/QubitAllocationAnalysis and enter the directory ConstSizeArray to build the QIR:
% make analysis-example.ll

or execute the commands manually,
% dotnet build ConstSizeArray.csproj
% opt -S qir/ConstSizeArray.ll -O1  > ../analysis-example.ll
% make clean

Returning to examples/QubitAllocationAnalysis, the pass can now be ran by executing:
% opt -load-pass-plugin ../../Debug/libs/libQubitAllocationAnalysis.dylib --passes="print<qubit-allocation-analysis>" -disable-output analysis-example.ll

Example cases
Below we will consider a few different examples. You can run them by updating the code in ConstSizeArray/ConstSizeArray.qs and executing make run from the examples/QubitAllocationAnalysis folder subsequently. You will need to delete analysis-example.ll between runs.
Trivially constant
This is the simplest example we can think of:
namespace Example {
    @EntryPoint()
    operation QuantumProgram() : Unit {
        use qubits = Qubit[3];
    }
}

The corresponding QIR is:
; ModuleID = 'qir/ConstSizeArray.ll'
source_filename = "qir/ConstSizeArray.ll"

%Array = type opaque

define internal fastcc void @Example__QuantumProgram__body() unnamed_addr {
entry:
  %qubits = call %Array* @__quantum__rt__qubit_allocate_array(i64 3)
  call void @__quantum__rt__array_update_alias_count(%Array* %qubits, i32 1)
  call void @__quantum__rt__array_update_alias_count(%Array* %qubits, i32 -1)
  call void @__quantum__rt__qubit_release_array(%Array* %qubits)
  ret void
}

; (...)

Running the pass procudes following output:
% opt -load-pass-plugin ../../Debug/libs/libQubitAllocationAnalysis.dylib --passes="print<qubit-allocation-analysis>" -disable-output analysis-example.ll

Example__QuantumProgram__body
====================

qubits is trivially static with 3 qubits.

Dependency case
In some cases, a qubit array will be compile time constant in size if the function arguments
provided are compile-time constants. One example of this is:
namespace Example {
    @EntryPoint()
    operation Main() : Int
    {
        QuantumProgram(3);
        QuantumProgram(4);
        return 0;
    }

    operation QuantumProgram(x: Int) : Unit {
        use qubits = Qubit[x];
    }
}

The corresponding QIR is
; ModuleID = 'qir/ConstSizeArray.ll'
source_filename = "qir/ConstSizeArray.ll"

%Array = type opaque
%String = type opaque

define internal fastcc void @Example__Main__body() unnamed_addr {
entry:
  call fastcc void @Example__QuantumProgram__body(i64 3)
  call fastcc void @Example__QuantumProgram__body(i64 4)
  ret void
}

define internal fastcc void @Example__QuantumProgram__body(i64 %x) unnamed_addr {
entry:
  %qubits = call %Array* @__quantum__rt__qubit_allocate_array(i64 %x)
  call void @__quantum__rt__array_update_alias_count(%Array* %qubits, i32 1)
  call void @__quantum__rt__array_update_alias_count(%Array* %qubits, i32 -1)
  call void @__quantum__rt__qubit_release_array(%Array* %qubits)
  ret void
}
; ( ... )

The analyser returns following output:
% opt -load-pass-plugin ../../Debug/libs/libQubitAllocationAnalysis.dylib --passes="print<qubit-allocation-analysis>" -disable-output analysis-example.ll

Example__QuantumProgram__body
====================

qubits depends on x being constant to be static.

Summary case
Finally, we do a summary case that demonstrates some of the more elaborate cases:
namespace Example {
    @EntryPoint()
    operation Main() : Int
    {
        QuantumProgram(3,2,1);
        QuantumProgram(4,9,4);
        return 0;
    }

    function X(value: Int): Int
    {
        return 3 * value;
    }

    operation QuantumProgram(x: Int, h: Int, g: Int) : Unit {
        let z = x * (x + 1) - 47;
        let y = 3 * x;

        use qubits0 = Qubit[9];
        use qubits1 = Qubit[(y - 2)/2-z];
        use qubits2 = Qubit[y - g];
        use qubits3 = Qubit[h];
        use qubits4 = Qubit[X(x)];
    }
}

We will omit the QIR in the documenation as it is a long. The output of the anaysis is:
% opt -load-pass-plugin ../../Debug/libs/libQubitAllocationAnalysis.dylib --passes="print<qubit-allocation-analysis>" -disable-output analysis-example.ll

Example__QuantumProgram__body
====================

qubits0 is trivially static with 9 qubits.
qubits1 depends on x being constant to be static.
qubits2 depends on x, g being constant to be static.
qubits3 depends on h being constant to be static.
qubits4 is dynamic.

/azp run


Avoid installing ElasticSearch libraries for those that only use Athena

Now that I have Athena support, I'd like to avoid installing the ElasticSearch libraries as they are not needed.  The setup process for CloudTracker when using ElasticSearch involves a Makefile, making this issue more complicated.

This appears to have been resolved at some point in the past.


Network Structure fix

The last layer is 256, but the SigNet paper specifies 128.
(Note: the network trains much more quickly with 128.)

Thanks for pointing it out. Do you want to make a PR for this?

:+1:
Just made this one-liner :smile_cat:

It's okay. Sometimes, we don't have to do big things to contribute 😄
Thanks for the PR.
I'll close this issue now.


Switch branches disconnects users

Product and Version [VS/VSCode]: VSCode 1.22.2
OS Version [macOS/Windows]: macOS
Live Share Extension Version: 0.2.487
Target Platform or Language [e.g. Node.js]: Node.js
Steps to Reproduce / Scenario:
Currently the extensions seems to disconnect everyone when changing to another branch. Not sure if this is intended but if it is, it might be nice to show a warning because of this.

Invite someone to your session
Switch to another branch
Other user(s) will be disconnected

@SamVerschueren Interesting. Yeah I do this all the time exactly as you are.  (Even using a read-write terminal from the guest side).
I take it since you mentioned Terminal you had experimental features on?  A few thoughts, questions:

Did everyone else in the collaboration session have experimental features on? (Strange things could happen if someone is not.)
Were you using a multi-root workspace that might have changed in some way with the checkout?
Did the root folder you were sharing change in some way?

Everyone in the session had experimental features turned on. We tried with and without.
We did not use multi-root workspace.
By switching branches, the new and changed files off course are being checked out. But other than that, nothing else should happen.

@SamVerschueren Hmm.  Very odd. How many guests were joined at the time? (In the event this was a multi-user related issue.)

@SamVerschueren I just tried reproing this issue using the latest Live Share extension, and it doesn't seem to appear. We've made a bunch of improvements in the last few months, and so it's entirely possible that we've since fixed it. I'm going to close this issue for now (since we haven't heard any other reports), but please re-open it it you notice it again. Thanks!


Fix bug #4374 for AccessLogFilter not working

which introduced by #4038
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #4566 into master will increase coverage by 0.97%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4566      +/-   ##
============================================
+ Coverage     62.38%   63.35%   +0.97%
  Complexity      450      450
============================================
  Files           791      770      -21
  Lines         34853    33089    -1764
  Branches       5457     5216     -241
============================================
- Hits          21742    20963     -779
+ Misses        10613     9725     -888
+ Partials       2498     2401      -97

Impacted Files
Coverage Δ
Complexity Δ

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
83.33% <100%> (+65.27%)
0 <0> (ø)
:arrow_down:

...ache/dubbo/remoting/p2p/support/AbstractGroup.java
45.45% <0%> (-11.37%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-8.7%)
0% <0%> (ø)

...onfig/spring/extension/SpringExtensionFactory.java
80.48% <0%> (-4.88%)
0% <0%> (ø)

...c/main/java/org/apache/dubbo/rpc/RpcException.java
82.75% <0%> (-3.45%)
0% <0%> (ø)

...pache/dubbo/registry/support/AbstractRegistry.java
78.54% <0%> (-3.07%)
0% <0%> (ø)

...a/org/apache/dubbo/common/json/ParseException.java

...o/rpc/protocol/thrift/DubboClassNameGenerator.java

.../java/org/apache/dubbo/common/json/JSONObject.java

.../java/org/apache/dubbo/common/json/JSONWriter.java

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c304bf3...f03b983. Read the comment docs.


function for finding the system wide python interpreter

Motivation

This is required in #404

Task

Create a function which returns a path to a python interpreter. The function should take a list of module names, and the returned interpreter should be able to import the modules. If there is no such interpreter, return None.

Thinking this one again. Perhaps better to have this done as part of https://github.com/fohrloop/wakepy/issues/404.


VCL relative includes

Modify vcl include resolution so that the include is relative to
the including file's location, falling back to vcl_dir for default vcl
and vcl defined on the console where file path is not available.

Please see follow-up discussion on<EMAIL_ADDRESS>It is not certain what exactly we will do, but it is pretty certain this isn't going to be it.


Create a Reference Architecture for Power & Energy industry

Is your feature request related to a problem? Please describe.
Power & Energy is a highly sophisticated, technology-driven industry that makes a huge difference in society. Having a reference architecture would help.


Is this working?

Is this working as of now?
No joy in using either ipy2wp.js  (no button) or ipy2wp.py (no draft).
Overall, very promising addition to IPython. Any help appreciated.
Regards

Hi.
The javascript extension works for me on linux. It seems there isn't an easy way to make it work globally. I asked in the IPython/Jupyter mail-list with no luck.
OTOH, The ipy2wp.py is working for me. Please. let me know what are you doing on the command line and if you have xml-rpc enabled in your wordpress box (http://codex.wordpress.org/XML-RPC_Support).

Thanks, really.
I sorted  out the issue with ipy2wp.py. It turned out I changed the default address for xmlrpc.php on my site some time ago and forgot that. Now, after entering the right address it's working. Cool!
Is there any chance to make ipy2wp.js working on my machine? Ubuntu 14.04 here.
No visible response to (no button, no anything):
%%javascript
IPython.load_extensions('gist');

The extension seems to be installed properly:
import IPython
IPython.html.nbextensions.check_nbextension('ipy2wp.js')

True

Cool it works the pythonic way.
I think I was incorrect before and I could make it work on windows, not Linux IIRC.
These days I'm busy. Please, If you can remember me this on June and I will take a look on it (I have to travel during some weeks).
Also, if you have some suggestions, please, let me know.

The only suggestion so far is to make it working ))))
The idea is great. Being able to post your work to a blog is a must have, better by pressing one button. Lacking this ability prevented me from using Joomla! + K2 (there is no way to post to K2's xmlrps  from an offline editor).
RStudio + knitr have this functionality (== posting from RStudio directly to wordpress). With your help it seems now IPython is going to have this press-one-button functionality too.
So, I'll keep reminding you ))).

Well, as far as suggestions concerned.
What about uploading the source notebook and adding to the post a button "Download Notebook", like they have on nbviewer?
Reproducibility is a hot topic in scientific world, and adding such a button will greatly contribute towards ease of running the notebook on local computer and redistribution of the code.

This is an easy stuff to implement. I can see it as a new option pointing to the notebook link but you should know the url previously. Sometimes I create a mardown cell at the end of the notebook with the link so the download will be already included in the notebook. Anyway, this is a good way to collaborate with ipy2wp if you want to create this option yourself ;-)
ipy2wp [...options...] --download http://github.com/sbushmanov/my-notebooks/Untitled.ipynb
If you don't know how I can help you.
If you don't have the time I can implement it on June if you remember me this issue!!!

Well, thanks for inviting,  I take this as a complement  .... The matter is that .... I'am not a coder ). I come from Finance and my experience with Python (sklearn mainly) is limited to a month or so. I just wanted to add [b]logging to my exercises to keep track of things. Sorry.

Do not worry :-) In some weeks we speak again.

I'll be checking my calendar every morning ;)

Hi, it's one week into June now and I am taking advantage of my good memory ;)

I can implement it on June if you remember me this issue!!!

Good memory!!!!
I updated the instructions to install it. Please, read the following:
https://github.com/Pybonacci/ipy2wp#from-the-notebook
And let me know if you find any problem installing it.
If it is not very clear just let me know.

Thanks, it's working for me now.
A couple of additions would make sense:

A line or two on how to have this extension loaded on startup:

Add this line to custom.js
IPython.load_extensions('ipy2wp/ipy2wp')

If it's not too difficult, downloading *.ipynb notebook to server with a button div at the bottom of the page would be meaningful.

Anyways, thank you very much!

If it's not too difficult, downloading *.ipynb notebook to server with a button div at the bottom of the page would be meaningful.

What do you mean with this? To upload the nb file to the wp-content folder in your wordpress or add a div in the templates to link to the notebook in a repo or wherever?

As of now, I have an opportunity to post the nb to the wp blog. On top of that, I'd like that those interested in rerunning the code on their computers have an opportunity to download the nb (like the button 'Download Notebook' on nbviewer).
To do so,  now I'd have to:

manually download the nb to github / wp server
manually edit the post to add link or button with a link.

My suggestion was to:

download the nb to the wp server along with the posting
add a button, e.g. at the bottom of the post 'Download ipynb'

My understanding it will facilitate sharing the code by shortening the path between those who author the code and those who try reproducing it.

I was thinking on that but in the end I discarded to add this as each user has a different behavior. For instance, I have the notebooks on github or bitbucket, others can have their own ftp or their own custom downloads folder on wordpress or whatever. Also, I have to provide a name for the nb (a new field in the form), a path  to the local location of the nb (a new field),...
I think it is easier and it allows for better customisation to paste a link in the wordpress editor and you can have the notebook wherever you want instead in the wp-contents/uploads folder only.

Thank you anyway, one more time!
Should you some time change your mind and agree that having nb download link next to your post makes sense, I'd be more than glad to discuss what an implementation could. Though, you already seem to have all the necessary ingredients:

a field for path, including folder and file name
a tickbox 'upload'
a div in the html

As far as github and bitbucket are concerned -- that's different. That's for developers. When I code, I git files there for keeping them. When I blog, I want the readers to have an opportunity to download the code without going somewhere else and exploring ways how to download from there. It's the idea behind nbviewer, isn't?
Thanks man!

But for the reader what's the difference between a download link from:
https://raw.githubusercontent.com/rlabbe/Kalman-and-Bayesian-Filters-in-Python/master/01_g-h_filter.ipynb
or from
http://yourwordpress.com/wp-content/uploads/2015/06/a_notebook.ipynb
It is pretty easy to add a link in the wordpress editor, a link to wherever the file is, your wordpress box, github or whatever, however, manage this from an UI perspective is not so easy.
I think now this tool solves the hard part for the user in an easy way, the easy part for the user is easily solvable by the user itself
;-)


Add oc client binary to microshift-aio, set KUBECONFIG

Which issue(s) this PR addresses:
Closes #474 #477
This oc 4.8.9 to the microshift-aio image from here
Also, sets KUBECONFIG within the microshift-aio image

/lgtm

good to close

This is hardcoded to use amd64, it needs to be changed to use $ARCH. Also need to use newer OCP_VERSION that is available for aarch64
-RUN export OCP_VERSION=4.8.9 && \
-    curl -o oc.tar.gz https://mirror2.openshift.com/pub/openshift-v4/amd64/clients/ocp/$OCP_VERSION/openshift-client-linux-$OCP_VERSION.tar.gz && \
+RUN export OCP_VERSION=4.9.11 && \
+    curl -o oc.tar.gz https://mirror2.openshift.com/pub/openshift-v4/$ARCH/clients/ocp/$OCP_VERSION/openshift-client-linux-$OCP_VERSION.tar.gz && \

@thinkahead thanks for that! I've opened a PR, although, would also accept a PR from you. https://github.com/redhat-et/microshift/pull/512


zappa certify does not work properly with certificate_arn, solution is to manually change route53 setup

I am trying to use the ACM for a custom domain of a lambda function.

Setup virtualenv

virtualenv hello
cd hello
source bin/activate
pip install zappa flask

Create my_app.py

from flask import Flask
app = Flask(__name__)

@app.route('/')
def index():
    return "Hello, world!", 200

# We only need this for local development.
if __name__ == '__main__':
    app.run()

Init and deploy

zappa init
zappa deploy dev

Create certificate for domain on ACM on US-East-1, such as hello.example.com, and get the arn of this certificate.

Edit the zappa_config.json to look something like...

{
    "dev": {
        "app_function": "my_app.app",
        "aws_region": "us-east-1",
        "profile_name": "default",
        "s3_bucket": "zappa-xxxxx9999",
        "certificate_arn": "arn:aws:acm:us-east-1:999999999:certificate/b333b333-b333-333e-333b-b111111",
        "domain": "hello.example.com"
    }
}

Certify
zappa certify dev

This is where I run into problems. When I try to connect to hello.example.com, it does not work.
Instead I look at the Route53 configuration and it seems like a CNAME link with a cloudfront.xxxx.net link.
I changed this (as per http://docs.aws.amazon.com/apigateway/latest/developerguide/how-to-custom-domains.html#how-to-custom-domains-prerequisites ), to an alias:

Create an A-IPv4 address record set for your custom domain (e.g., api.haymuto.com). An A-record maps a custom domain name to an IP4 address.
Choose Yes for Alias, type the CloudFront domain name (e.g., d3boq9ikothtgw.cloudfront.net) in Alias Target, and then choose Create. The A-record alias here maps your custom domain name to the specified CloudFront domain name that is itself mapped to an IP4 address.

Not sure if this is a bug or if it is something I am doing wrong. However, changing to alias worked for me, which isnt the default setup that is created by zappa. Comments welcome

I ran into this issue yesterday and can confirm its still occurring.
Applying the mentioned workaround did the trick for me as well.
zappa==0.47.0


New WhatsApp Emojis

WhatsApp introduced a new Emojiset.

One can extract the files (at rather low resolution) from web.whatsapp.com, but as far as I can see this requires too be logged in with one’s phone number.

Hi guys,
I found a repo with all the WhatsApp emojis: https://github.com/eladkarako/whatsapp-emoji
Can this be used?
The emoji on the web.whatsapp.com could be easily programmatically grabbed as they all have the same link: https://web.whatsapp.com/img/88179f049c0d1d26c823d2954ecb54a7_w_e-64.png
where  is a number from 1 to 2401.
E.g: https://web.whatsapp.com/img/88179f049c0d1d26c823d2954ecb54a7_w_e1483-64.png
Just not sure about the mapping of the numbers to the codes...
Or can images from emojipedia be used? They shall be also pretty easy to grab...

@eladkarako’s repository still has Apple emojis, not the new custom WhatsApp emojis.

repository still has Apple emojis, not the new custom WhatsApp emojis.

?

Úᵱḋḁtëḍ

Thanks a lot ^-^

Duplicate of https://github.com/iamcal/emoji-data/issues/102

Closing as a duplicate


Enable default repo settings similar to other siderolabs repos

Coming in from this: https://github.com/siderolabs/talos-vmtoolsd/pull/12#issuecomment-2021991973
i would be beneficial to have this repo have default settings similar to other repos under the organization.
Have a default main branch and have the standard repo branch protection settings enabled.
@robinelfrink / @lennardk I can help get this started

Yes, I'm all in for uniform repository settings :)
I'll make sure we rework the repo-content with kres as soon as we have released 0.5.0.

Yes, I'm all in for uniform repository settings :)
I'll make sure we rework the repo-content with kres as soon as we have released 0.5.0.

Yup great :+1:

I'll put up a draft PR to help things to be easier, and once 0.5.0 is released, will enforce the repository settings.

Oh, i didn't realize 0.5.0 is already cut that was fast, I'll start by renaming the branch to main, WDYT?

I just now created the release :) Yes, if you will, please go.

I just now created the release :) Yes, if you will, please go.

Done, might need this local updates:
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

Thanks. I've updated the workflow definition to reflect the branch rename, even though I suspect kres will make that obsolete anyway.

Yeh, kres generates even gh workflow files


Cleanup MissionData and move class into Animate3DSymbols files

Assign to @JamesMBallard
Moving the MissionData class to live inside the Animation3DSymbols files.  this was the code for the class can be displayed in the sample.

:+1:


How to configure vuepress v2.x config.ts?

My configuration file is config.ts, not config.js. Can you help me

Hey! Unfortunately we are not compatible with vuepress v2 and it is not planned that we will be :(

Closing as it is a duplicate of #175

Hey! Unfortunately, we are not compatible with vuepress v2. We are waiting for external contributing to make it compatible.
See #175

It's not an issue with VuePress v2. VuePress v1 itself supports TypeScript as Config.

https://github.com/JQiue/vuepress-plugin-meilisearch2/blob/main/README.md#vuepress-plugin-meilisearch2


Signout and silent renew race

I am seeing a race for completion when signout is called when silent renew is in progress.
I have set a far too low access token expiration in identity server to trigger this behavior. When automatic silent renew is enabled (with the offline_access scope), then when invoking signoutRedirect() it can happen that the user is actually not signed out, because an ongoing silent renew is in progress.

Sure, I believe you :) What are you proposing?

Year. I think the desired behavior is that the user is signed out, as that is triggered by interaction and should take precedence. So, any ongoing silent login should be cancelled before calling endsession.

I fixed this issue on my app by calling userManager.stopSilentRenew(); when starting the sign out flow


#441: Added close of inputStream in org.takes.rs.RsXSLT.consume(Input…

Closing inputStream in org.takes.rs.RsXSLT.consume(InputStream) #441

@gauee Thanks, someone will review your pull request soon

@yegor256 pull request is rather short, review it please

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 10min)

@yegor256 Thank you, I have added 16 mins to your account in payment/transaction "000-84525c21", time consumed: 15 hours and 15 mins. extra minutes for review comments (c=1). +16 added to your rating, at the moment it is: +8409

@rultor deploy

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy

@davvd Done! FYI, the full log is here (took me 7min)


Pipeline features to add

Automatically copy output files to GCP bucket
Should more outputs be designated as final? E.g. PCA pickle model is currently not treated as an output
Set random seed in selection of bin pairs for PCA transformation of model features in BinAndAnnotateGenome

Set random seed in selection of bin pairs for PCA transformation of model features in BinAndAnnotateGenome

Addressed in commits 700f785202d82a09fecff0fa88881744b7386928 through 0cb43f406d7fa371490d791a47d807b4cc1d2d12


GitHub enterprise support

Adds support for any Github Enterprise. Anyone with a host at github.mycompany.com can start another instance. This addresses Issue #141, allowing users to build the app for their GHE.
Development

Create a new application in the settings, choosing the icon for gitify http://iamemmanouil.com/static/images/projects/gitify.png
Change the values of the protocol, host, api version and auth in config.js.

I just needed to change host github.mycompany.com and new values for the clientId and clientSecret.

npm run build
npm start

{
  "github": {
    "proto": "https",
    "host": "github.com",
    "apiVersion": "v3",
    "auth": {
      "clientId": "3fef4433a29c6ad8f22c",
      "clientSecret": "9670de733096c15322183ff17ed0fc8704050379"
    }
  }
}

Possible Future Improvements

Allow multiple accounts to be monitored, in addition to the public.

This avoids multiple apps to be opened in the bar.
The state of multiple apps overrides others when opened.

Use a slack-like interface for allowing multiple instances to be monitored.

Allowing developers to see notifications from multiple instances is a win for me.

:+1: Thank you.

This feels like it will work with either enterprise or with public GitHub, but not both. It is supper common to need both. The config might need to become an array of accounts, and will probably need UI updates to config.
Suggestion: In the place I work, our GitHub enterprise uses a custom 2-legged web-auth, almost no clients support it correctly. The successful tools use manually generated tokens to setup configuration. I use "hub" the command line tool and it works by writing a token to their dotfile.

should this PR be merged or closed?
Gitify still only supports Github (not Enterprise)?

Hi there, so there good and bad news. The app has been through a complete rewrite (good news - v1.0.0) so this PR unfortunately won't work. The idea is 100% correct but we have to rewrite.
I do not have access to an enterprise account (the GitHub team provided me with a license for development) but I don't have a server that is able to handle(hardware-wise) GitHub Enterprise.
If someone is able to provide me with an account then I will be happy to spend some time on implementing GitHub Enterprise support.

@ekonstantinidis what's required, server-wise? I can spinup something on Digital Ocean for you to use.

Any news on this PR?

Hello everyone! So @deibeljc had some amazing progress on this one which is based on the v2 branch. Hopefully we will be able to release this one soon (I'm currently on holidays so I've finally have the time to do some OS work!). I'm closing this one and we can follow up on #279.
Ps. Let me know if there is any chance you can provide me with a GitHub Enterprise account so I can do some development/tests (just a dummy/empty repository to generate some notifications would be great - thank you!).


fix: map component calls onClick even when map is readonly

Description

fixes issue where map calls onClick even when map is readonly
minor refactoring:

move onClick handler to separate component, not related to LocationMarker, since its really tied to the map and not the LocationMarker itself
reuse types from MapProps to ensure we keep the same interface (optional vs required props f.ex)

Related Issue(s)

#60

Verification

[ ] Your code builds clean without any errors or warnings
[x] Manual testing done (required)
[x] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Codecov Report

Merging #87 (6330848) into main (a75935e) will decrease coverage by 0.95%.
The diff coverage is 92.59%.

:exclamation: Current head 6330848 differs from pull request most recent head 2ddd18a. Consider uploading reports for the commit 2ddd18a to get more accurate results

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   97.74%   96.79%   -0.96%
==========================================
  Files          15       19       +4
  Lines         222      281      +59
  Branches       58       71      +13
==========================================
+ Hits          217      272      +55
- Misses          5        9       +4

Impacted Files
Coverage Δ

src/components/Accordion/Context.ts
85.71% <ø> (ø)

src/components/Button/Button.tsx
100.00% <ø> (ø)

src/components/Panel/Panel.tsx
100.00% <ø> (ø)

src/components/TextField/TextField.tsx
100.00% <ø> (ø)

src/components/List/Context.ts
90.00% <90.00%> (ø)

src/components/Map/Map.tsx
91.17% <91.17%> (ø)

src/components/List/List.tsx
100.00% <100.00%> (ø)

src/components/List/ListItem.tsx
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Revert implementation of unmerged UpdateExecution API changes

Signed-off-by: Katrina Rogan<EMAIL_ADDRESS>TL;DR
https://github.com/flyteorg/flyteadmin/pull/317 adds a dependency on a specific sha, rather than release of flyteidl which breaks the flyte release process, specifically generating config docs: https://github.com/flyteorg/flyte/actions/runs/1714466031
Until we merge API changes in https://github.com/flyteorg/flyteidl/pull/248, this change reverts their implementation so we can stick to an official idl release
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/2045
Follow-up issue
NA

cc @pmahindrakar-oss


Laravel 9 compatibility

Hi,
Just wondering if this package  will be  compatible with Laravel 9?
Thank you

PR welcome :)

Close via https://github.com/brefphp/laravel-bridge/commit/0abe1e2c5ce9aabe8ac730d7e163c72a10537894


Update NU5048.md: Make Error to Warning

Docs Build status updates of commit 5e1d5b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/errors-and-warnings/NU5048.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feature(file buffer): Support in-memory file buffers

Enhance the HelloSign SDK to support file buffers instead of requiring
the use of temp-files. The support was added to include allowing the
caller to pass in the file name that is used by form.append( ) when
telling it that the Buffer should be treated as a file by giving it a
name.
Majority of any enterprise applications generate temporary files
on a per request basis customized in some fashion. Having to
unnecessarily persist to disk just to attach the file for a signature
request is avoided by adding buffer support.

Thanks for this! I'll get this reviewed internally and report back.

@npbee no prob. Any word on when this might be merged?

@matthewerwin Left a few comments as well -- can you add a unit test for this as well?

@cmpaul made the initial set of changes but have been absolutely swamped this past month. Let me see if I can have someone on my team handle. Has been a lower priority for us because we just added the SDK into our build to avoid problems going forward if this doesn't get merged.

Closed due to inactivity, but we'll keep this PR in our back pocket should we ever decide to move forward with implementing this

Hi @nathanbuchar ! 👋  😄


installation fails for cyclone03prealpha4

Compiling cyclone03prealpha4 on Linux succeeds but installing fails because data files are not found on locations defined in the lib makefile:

Help files are in an apparently renamed directory.
LICENSE.txt is in a directory called 'maintenance' (not an intuitive title for documentation files).
Files test.mid and voice.wav seem to be absent, not sure if they are no longer needed?
Patch cyclone-meta.pd seems to be absent, where is this important file?

Abstraction [number~] isn't included in the datafiles definition.

yeah, I guess we never tried "installing", sorry for the ignorance, but how do you do it? :)

Huh, seriously? Try 'make install objectsdir=./build'. You'll get the errors but after fixing the lib makefile you'll get the installed lib in ./build/cyclone with all the files (and symlinks if needed). You need this for making binary distributions.

yep, seriously :) please cope with me, haha - I actually cannot believe I was able to pull a lot of this off, I say I'm like a blind man playing soccer, but derek and matt know better than me ;)

I'll tell you what happened, I see the errors in the end of the process, but everything builds out of the specified ./build/cyclone folder as well as inside the folder, this is weird right? seems like it should only build inside the folder

anyway, fixing it... no errors no more...

well, you can try now
https://github.com/porres/pd-cyclone/commit/5ec33210ab576fac3ebf1cb245f33b212167d4c3

or better yet https://github.com/porres/pd-cyclone/commit/eea402ea4c694e9c2e741cc1791296f0ca2a0b21

Installation succeeds now. By the way you can point to any location you like with variable 'objectsdir'. I mentioned 'objectsdir=./build' as an example. In a centralized build system like pd-extended / pd-l2ork it would be the path of the 'extra' directory where all libdirs are installed before packaging.
I wonder, how did you test without installing? Binaries and help patches aren't in the same directory in the source tree so the objects don't load.

over 7 months I just manually copied help files and binaries to a cyclone folder :)

So that is how you created your binary distributions for testing? That's inefficient and hazardous. Anyway now you know how to get it with a simple command. Maybe the best location for installation is outside your source tree, like 'objectsdir=../cyclone-build-tmp'.
By the way I noticed something confusing on my system. An earlier cyclone version was in ~/pd-externals, and when I loaded patch scope~-help.pd from the local cyclone install under test, pd window told me things like 'Scope~: no method for bgcolor'. Meaning pd had preferred ~/pd-externals/cyclone/Scope~ over the local binary. I always thought that it was the other way round, that local objects had priority. But maybe this is only true for abstractions. Can you check how that works on your system? It is crucial info for alpha testers (and of course for all users in the end).

my system seems to be behaving non deterministically... it can go either way, but it seems to be controllable with abstractions indeed


Add  react-list-scroll-bound

add  react-list-scroll-bound for a better scroll experience, if list on end.
https://www.npmjs.com/package/react-list-scroll-bound

@fluse Thanks for your PR.
I ended up using react-isolated-scroll which seems to solve a similar problem.
As you can see in this example, it is not part of react-autowhatever, it just integrates nicely with it.


Use toobusy-js as toobusy doesn't compile with node 0.12

The old toobusy (c++) doesn't compile with node 0.12 and hasn't been maintained in 3 years. Recent development has moved to toobusy-js, a js-only implementation, which recently made the smoothing factor a tunable.
This PR upgrades from toobusy to toobusy-js, and sets a default smoothing factor of 0.1.
@giantballofyarn @lennardseah @yangbin @dineshsaravanan

:+1:

:+1:


BlendHcl() edge cases slightly off

Greetings!
I've been experimenting with go-colorful and noticed that for the edge cases (t = 0 and t = 1), the resulting colors are actually slightly different from what is suggested.
For example:
a,err = colorful.Hex("#ff0000")
b,err = colorful.Hex("#00ff00")

a.BlendHcl(b, 0)
// colorful.Color{
//   R: 1.000000,
//   G: 0.000002,
//   B: -0.000000,
// }

a.BlendHcl(b, 1)
// colorful.Color{
//  R: 0.000001,
//  G: 1.000000,
//  B: -0.000000,
//}

Where as I would expect G to be 0.0 in the first case, and R to be 0.0 in the later case. Also, from the negative sign assigned to "B", I'm guessing that both of those are slightly off as well.
Is it possible that there is an off-by-one error somewhere?
If not, and the interpolation calculations simply don't allow this kind of precise generation of boundary cases, a minor / simple improvement might be to clip all resulting colors so that the RGB vals fall within [0, 1]?
If I have the time down the road, I will try and look into it myself, but I'm still only just learning Go, so it may be a little while :)
Thanks for your work on this great package!

Hello, thanks for reporting this! I'll have to look into the package more deeply to see where this error is coming from. For now I have clamped the output of BlendHCL in  d49a4a4, and this will be in the next release.
It's worth noting that the errors you've noticed are well below 1/256, and so will not have any effect on the displayed RGB  values.

Hello, thanks for reporting this! I'll have to look into the package more deeply to see where this error is coming from. For now I have clamped the output of BlendHCL in  d49a4a4, and this will be in the next release.
It's worth noting that the errors you've noticed are well below 1/256, and so will not have any effect on the displayed RGB  values.

Sounds good! And thanks for the clarification.
I definitely wouldn't spend a lot of time tracking this down if the origin isn't obvious and it doesn't ultimately have any impact on the output.
Perhaps something to keep in mind the next time you are working on that part of the code :)

Sounds good! And thanks for the clarification.
I definitely wouldn't spend a lot of time tracking this down if the origin isn't obvious and it doesn't ultimately have any impact on the output.
Perhaps something to keep in mind the next time you are working on that part of the code :)


Uncontrastive start bar icon

Chrome, Paint, Explorer, Telegram have more contrastive icon edges, Black on dark blue is makes quite uncontrastive icon edges, especially the left and bottom borders.

left - default, right - with mouse hover over

Should there be an inverted version of the icon, for use with Dark Mode Windows Theme?

@vadimkantorov could you share what the Chrome, Paint taskbar icons look like for you? On my machine, the Terminal taskbar icons are behaving the same as the icons for other windows:
Here I've got paint.exe focused:

Here, I've got Teams focused, and I'm hovering on the Terminal Icon:

and here I've got just the Terminal focused:

@vadimkantorov could you share what the Chrome, Paint taskbar icons look like for you? On my machine, the Terminal taskbar icons are behaving the same as the icons for other windows:

I don't think he is saying that it is behaving differently, but that the dark icon doesn't stand out as well as a coloured or brighter icon would.

Yes, the dark icon (on already dark start bar background) without clear edges or shadows to highlight edges is almost blurs into background and makes an impresion that this is not intentional (e.g. compare with OpenVPN icon). Tux icon of wsltty also suffers from this, but at least Tux has a lot of yellow/orange, so the problem isn't as bad.

In Win11 + dark mode the task bar icon is still not contrastive enough. Maybe there needs to be a different icon for dark mode


[BUG]: QA| cheque amount format.

Expected : amount commas to be in lakh crores (indian numbering system) format.
https://jam.dev/c/59803d35-3524-436c-95ea-83870c6604cd
https://jam.dev/c/9b40e166-e290-4781-a34b-21dfa6be44fd

Can we report this as a known issue? Digit currency input isn't applying the Internationalization parameters that it is accepting as input.


Setting auto focus on different elements not working in case of show hide div

Hi,
I'm trying to set auto-focus on 2 different elements in same page based on the visibility of parent div.
I have 2 divs with some elements in them, if the 1st div is visible the auto-focus should be set on element with lowest focus-index in the 1st div.
And if the 1st div is hidden the auto-focus should be set on element with lowest focus-index in the 2nd div.
I have tried applying auto-focus on both the elements but this doesn't seem to work.
Am I missing something?
I have also created a sample for reference
http://plnkr.co/edit/cjOV9lftnMghOzvg6iJ0?p=preview

Thanks for the example. I made a fix and bumped the version to 0.3.0. I changed focus-element to focus-autofocus. It supports handling priority. I have updated example on this site and the plunker example here http://plnkr.co/edit/75ZpY9o79KytZbPgdqmR?p=preview

This works. Thanks.


fix: 标准镜像version

这个 PR 实现什么功能/修复什么问题:
标准镜像version
是否需要 backport 到之前的 release 分支:

release/2.10.0

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #3430 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3430   +/-   ##
======================================
  Coverage    7.03%   7.03%
======================================
  Files         496     496
  Lines       82391   82391
======================================
  Hits         5797    5797
  Misses      76108   76108
  Partials      486     486

Flag
Coverage Δ

#aFlag
7.03% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9156be...bdfbaf0. Read the comment docs.

/lgtm

/approve


CM function chosen

@poojashresthacode @sharmistharanit
I have chosen a CM function for which I have added a python file to our repository. @poojashresthacode I have sent you a merge request for the code.

Thank you for letting me know. I have seen it.


[Event Request] table 179 "Reversal Entry" - OnBeforeVerifyReversalEntries

Hello, can you please add a new Event OnBeforeVerifyReversalEntries in table 179 "Reversal Entry" ?
    procedure VerifyReversalEntries(var ReversalEntry2: Record "Reversal Entry"; Number: Integer; RevType: Option Transaction,Register): Boolean
   var
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeVerifyReversalEntries(ReversalEntry2, Number, RevType, IsHandled, Result);
        if IsHandled then
            exit(Result);

        InsertReversalEntry(Number, RevType);
        Clear(TempReversalEntry);
        Clear(ReversalEntry2);
        if ReversalEntry2.FindSet() then
            repeat
                if TempReversalEntry.Next() = 0 then
                    exit(false);
                if not TempReversalEntry.Equal(ReversalEntry2) then
                    exit(false);
            until ReversalEntry2.Next() = 0;
        exit(TempReversalEntry.Next() = 0);
    end;

    procedure Equal(ReversalEntry2: Record "Reversal Entry"): Boolean
    begin
        exit(
          ("Entry Type" = ReversalEntry2."Entry Type") and
          ("Entry No." = ReversalEntry2."Entry No."));
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeVerifyReversalEntries(var ReversalEntry2: Record "Reversal Entry"; Number: Integer; RevType: Option Transaction,Register; var IsHandled: Boolean; var Result: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 13591.


Enable compilation with Java 11

Use maven 3.6+ with JDK 11 and the flag -Pjava11 to enable the Java 11
profile.
Closes #9856

I tested this on my local machine using a script to run the build in a docker container:
build.sh
#!/usr/bin/env bash
#
# The Alluxio Open Foundation licenses this work under the Apache License, version 2.0
# (the "License"). You may not use this work except in compliance with the License, which is
# available at www.apache.org/licenses/LICENSE-2.0
#
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
# either express or implied, as more fully set forth in the License.
#
# See the NOTICE file distributed with this work for information regarding copyright ownership.
#

docker run -it --rm --name alluxio-java-11 \
  -v "$(pwd)":/usr/src/mymaven \
  -v ~/.m2:/root/.m2 \
  -w /usr/src/mymaven \
  maven:3.6.3-jdk-11 \
  mvn $@

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7892/
Test PASSed.

@gpang I've updated the description with the issues I hit and how they were resolved

Good catch. I'm not sure how much it matters. I was able to compile and run with java 11 without setting that property. I will add that to the profile though.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7910/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7928/
Test FAILed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7931/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7932/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7943/
Test PASSed.

Just want to add a note that if you build with java 11 locally, many of the unit and integration tests will not work - this simply gets the compilation working.

alluxio-bot, merge this please


add disclaimer to csv uploader

FRONTEND PULL REQUEST
Related Issue

addresses #4340

Changes Proposed

Add a disclaimer banner

Screenshots / Demos

Looks good, just a couple notes on formatting - only need to address if these are quick fixes:

Separate first 3 sentences into their own paragraph and italicize (see mockup)
Make the width a little narrower rather than full width; it looks a little off compared with the text below.

Looks good, just a couple notes on formatting - only need to address if these are quick fixes:

Separate first 3 sentences into their own paragraph and italicize (see mockup)
Make the width a little narrower rather than full width; it looks a little off compared with the text below.

Done, updated the screenshot


Assign IHttpContextAccessor in the default implementation of IHttpContextFactory

As part of https://github.com/aspnet/Hosting/issues/404, we should be setting the IHttpContextAccessor in CreateHttpContext

Is CreateHttpContext per request or per connection? Per connection is fine; but per request setting an AsyncLocal incurs a new Dictionary cost per set.

It's per request. Nothing is changing there. We're just moving things around so that application code can remove it if required.

Ah, kk

merged to dev


⚠ Bofrost.lu has degraded performance

In ef0ba42, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1419 ms

Resolved: Bofrost.lu performance has improved in d1fd97f after 13 minutes.


add iter() for TableList to support enumerate()

    tables = camelot.read_pdf(filename)
    for idx, table in enumerate(tables):   # Warining: Expected type 'Iterable[_T]', got 'TableList' instead  in pycharm
        pass

Are you able to provide a corresponding test as well?

I agree with @stefan6419846, your provided example is almost a test-case. Whilst the improvement looks very trivial a test-case is easy to provide.

I'll add tests soon.


add nil check for aggregator during WaitStop

Codecov Report

Merging #981 (409594e) into main (d4f5c87) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   99.99%   99.98%   -0.02%
==========================================
  Files         301      301
  Lines       19799    19800       +1
==========================================
- Hits        19798    19797       -1
- Misses          1        2       +1
- Partials        0        1       +1

Impacted Files
Coverage Δ

internal/events/event_manager.go
100.00% <100.00%> (ø)

internal/apiserver/server.go
99.12% <0.00%> (-0.88%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Wrong type of exponentiation with integer base and power

Wrong type inference of integer raised to power of any integer other than literal 2
 Environment data

Language Server version: 2021.5.2-pre.1
OS and version: Windows 10
Python version (and distribution if applicable, e.g. Anaconda): 3.9.5 (pipenv)
python.analysis.indexing: true
python.analysis.typeCheckingMode: off

 Expected behaviour
a = 10**1
b = 10**3
c = 10**int(2)

Type of both a, b and c should be inferred as int.
 Actual behaviour

Closing old issue. If this is still a problem, please reopen with the information requested. thanks


How to customize a component in :next

The next branch looks great!
What is the proposed solution for customizing components in the :next branch
For example, if I need the label of a Tab not be uppercase Tab.js#L165, how could I achieve this?

Would a xxxClassName(as mentioned here) be provided for every customizable item (i.e labelClassName)?
Would I be able to pass my own classes prop that merges with the bases classes?

Thanks a lot!

The answer id in the page you linked to.
Also:
Question? This helps us keep issues for... issues. :smile: Thanks!

So, just to make sure that I understand it correctly
For example, based on the Tab.js stylesheet does it mean that it will have all this props?
rootClassName
rootLabelIconClassName
rootAccentClassName
rootAccentSelectedClassName
rootAccentDisabledClassName
rootInheritClassName
rootInheritSelectedClassName
rootInheritDisabledClassName
labelClassName

Or would that be customized by passing a classes prop that potentially overrides any of these classes?
root: {
  /* some css */
}
rootLabelIcon: {
  /* some css */
}
rootAccent: {
  /* some css */
}
rootAccentSelected: {
  /* some css */
}
rootAccentDisabled: {
  /* some css */
}
rootInherit: {
  /* some css */
}
rootInheritSelected: {
  /* some css */
}
rootInheritDisabled: {
  /* some css */
}
label: {
  /* some css */
}

@rogeliog As it stands, for root, you would build and pass in a set of classes through the className prop based on the same conditions the component uses internally, essentially reproducing https://github.com/callemall/material-ui/blob/next/src/Tabs/Tab.js#L171-L179.
We can't override the stylesheet array with a prop, because it's created and written to the DOM on mount.
What's missing is labelClassName.


not support null safety

Error: Cannot run with sound null safety, because the following dependencies
don't support null safety:

package:flutter_screenutil

Is the empty safe version used?

This is last version used
On Fri, Mar 26, 2021, 12:22 PM LiZhuoyuan @.***> wrote:

Is the empty safe version used?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenFlutter/flutter_screenutil/issues/236#issuecomment-808100027,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS55NVT5RGVWHNWIYMYQFCLTFRN7PANCNFSM4Z3DUNXQ
.

Can you provide detailed information?

done


Add CV example: Video Dataset Management and Frame-Level Annotation for YOLOv8

Updated version of https://github.com/iterative/datachain-examples/pull/19
Current status
@shcheklein  created a bucket on gs://datachain-kinetics-700-2020. Also fixed a few issues with the notebook (e.g. pick video ids from the table instead of hardcoded, cleanup, etc). It works fine with the local file system, but not yet with the GS. OpenCV breaks it seems (need to check this).

This tutorial dives into techniques to manage video and image datasets for Video Analytics and Vision AI projects.
📋 Topics covered:

Building a Video DataChain for kinetics-700-2020 video dataset
Creating a Data Model for YOLOv8 Pose Detection projects
Integrating Video-Level Annotations from CSV
Extract and Manage Video Frames
Running Pose Detection with YOLOv8 and Saving to DataChain
Visualizing Pose Data

TODO:

[x] move data to a public bucket gs://datachain-kinetics-700-2020
[x] fix OpenCV methods to work with non-local files
[x] test end-to-end

Discussion:
The code that coverts between DataChain and Ultralytics formats are cumbersome, any ideas how it can be improved?
Any improvements in DataChain API usage?

[ ] Can LLM be used instead of OpenCV?
[ ] Can we write frames back to the bucket - do we need a method for this?

I've fixed it to work with the bucket (cc @tibor-mach ).


PackageCloud repo missing redhat/centos 5 packages for 1.2.x

The most recent el5 rpm on https://packagecloud.io/github/git-lfs is for the 1.1.1 release.
Is there an incompatibility with the 1.2.x releases, or are the packages missing because of low interest?
I have observed a problem with lfs checkout of a file with a utf8 filename under centos 5/git-lfs 1.1.1, which does not occur with ubuntu 14.04 / git lfs 1.2.1.

Packages are missing because of low interest and issues with the docker scripts that build the packages. You could install it from one of the linux downloads, but I realize this isn't a desirable way to install software.

Thanks - the 1.2.1 Linux AMD64 package seems to solve the checkout problems.

Sounds good!


Can't install sift-cli

I have tried everything,

SIFT ova, download sift-cli and follow instructions
New SIFT image from ova, follow salt install method
fresh Ubuntu 20.04 updated, manually install python2, python3, git. Use Salt install and then try again with sift-cli all of them broken. (gave up on this)

One thing I found using sift salt is the 4m6Monke scripts were resorted " In December 2021, an attempted cleanup was done - scripts were sorted into folders by OS, Perl language or "utilities" (if you're not sure where a Python script moved to, its probably here)." so this needs to be refactored most likly.
 It should have additional YAML at the end.
The python parse errors can generally be ignored at this time.


Update (insert At Stacks) - PeriodicTable.md for Assignment 4

In the Stack.java file line 16-21 explains why it is O(1).
https://github.com/TheEvergreenStateCollege/upper-division-cs/blob/main/dsa-23au/java-dsa/arrays-links/src/main/java/dev/codewithfriends/Stack.java

Great contributions @ndeanon25 here's some feedback
Can you request a review from three other people in the class?

In the Stack.java file line 16-21 explains why it is O(1).
https://github.com/TheEvergreenStateCollege/upper-division-cs/blob/main/dsa-23au/java-dsa/arrays-links/src/main/java/dev/codewithfriends/Stack.java

Your explanation in your comment looks good to me. Can you move the link and the explanation to the bottom of the file like this one:
### Arrays Insert At
[O(?)](https://github.com/TheEvergreenStateCollege/upper-division-cs/blob/main/dsa-23au/java-dsa/arrays-links/src/main/java/dev/codewithfriends/ArrayWrapper.java#L122)

The ### indicates a header and an anchor, that you can link to, by lowercasing all the letters and joining all the words with a hyphen -
Also, say more about why it is O(1), as if you are explaining it to someone who is still learning Big-Oh notation and learning DSA.

Updated already

Closed pull request from fall quarter


fix for links in markdown broken if url contains encoded parameters

fix hover link in #79474 , original query string is preserved

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: hypercubestart sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for looking into this. I believe that the linked issue could have been caused by 69146d090e1785fe122526a4d74467ece743f38a
However as the uri code is surprisingly nuanced  and used in many different flows in VS Code, I'm not sure if fixing this issue at in uri.ts is something we want to attempt. I've added @jrieken to get his feedback on this

I believe that the linked issue could have been caused by 69146d0

Very unlikely as those changes were around for maybe 3 weeks. We would never to query-string specific encoding in the URI.

I'm not sure if fixing this issue in uri.ts is something we want to attempt

Unfortunately not. Changes in uri.ts aren't accept as the impact is too big


FSLeyes: integrate (?) into native ADS installation

As of https://github.com/neuropoly/axondeepseg/pull/182, fsleyes can be installed manually. It would be nice to have it installed during ADS installation.
TODO:

Add fsleyes in requirements.txt

Test if ADS install works + usage in Windows, OSX and Linux

Closing, this was resolved with our move to a conda installation.


Fix typos on new-project page

What does this PR do?

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Although extremely minor, I had fun in the process :)

since this is the first time I am doing PR on PL, I was wondering if there are anything else I need to do on this PR to get it merged. Other than that one failing check (which I have no idea why it is failing as it was just a documentation change), everything seems to be fine.
I would very much appreciate some feedback. Thank you!


Security for WebRTC with external port 8555

hey guys,
I switched to version 3.x and moved from 5000 udp ports to stun:8555 in go2rtc.yaml and port forward of 8555 in my router.
my question is now: is that port secured via home assistant or is it possible for people out there to connect to my public_ip:8555 and consume my outdoor video stream?
best
Dirk’

I cannot guarantee that there are no bugs or vulnerabilities in the pion library:
https://github.com/AlexxIT/go2rtc/blob/f0def68482dad3a2f1e78d364a5099f580c32f4a/pkg/webrtc/api.go#L43-L51
But this port is only used to transmit encrypted SRTP packets. This port is not a control port and cannot be used to request or start a stream.
The SRTP packet encryption key is transmitted through the Home Assistant API. Therefore, if you use HTTPS, it cannot be intercepted.

Okay thanks, sounds good. Last question: why is it then possible to set a user and password for external ports? I guess mainly for the webui?
and one side nose: regarding “change your yaml” maybe you can make it more clear that go2rtc.yaml is meant, I was modifying configuration.yaml and wondering why nothing changes 😬

Where you read about "change your yaml"?
Read more here: https://github.com/AlexxIT/go2rtc#security
You can set user/pass for go2rtc WebUI and RTSP ports. It's for you LAN. You shouldn't open this ports to WAN, even with auth. You also can close LAN access to this ports if you want. Component will continue to work without problems. But WebUI and RTSP Server can be useful for you.

Ahhh user/pass is for 8554 and 1984, got it. Thanks for clarification.
I was just reading here: https://github.com/AlexxIT/go2rtc#module-webrtc
and interpreted “you can change the port in YAML config:” as configuration.yaml - maybe it’s just me but something like “you can change the port in YAML config file ‘go2rtc.yaml’”

go2rtc is separated standalone application. It's not related and not depends on Home Assistant

This is know also clear to me. But it was not when migrating the 2.x integration to 3.x in home Assistant. Anyways. I am fine know. Was only mentioning it cause it could help other users aswell. Or maybe it’s just my own inability.


F.R.: Demon Stone - opening sequence glitches

Right at the start of a new game, during the in-engine opening intro sequence, the camera passes through the main character and then he seems to move in slow motion for a while. Everything gets back to normal once you briefly see an orc running in the background.
Other in-engine sequences may be affected, though I haven't seen anything similar during gameplay.
Initially, I thought this was a Wine issue, but it doesn't happen with WineD3D.
Here's what I've recorded (sorry for the frame-skips, but it's the best my modest quad-core can do apparently):
Intro sequence with DXVK
Intro sequence with WineD3D
Software information
Forgotten Realms: Demon Stone (GOG version).
System information

GPU: GeForce GTX 1070
Driver: 440.48.2
Wine version: 5.1 Staging
DXVK version: v1.5.4

Apitrace file(s)
This part is already captured in the API traces provided with #1409
Log files

d3d9.log: demonstone_d3d9.log
d3d11.log: N/A
dxgi.log: N/A

I see this was reported before as part of issue #321 on d9vk. CartoonFan has a better capture of the slow-down in his last comment.

Have you tried enabling vsync? This sounds like the kind of thing that happens when games run at higher frame rates than they are designed for.

Have you tried enabling vsync? This sounds like the kind of thing that happens when games run at higher frame rates than they are designed for.
In any case, this is almost certainly not a bug on our end.

There's no game option for v-sync, but setting d3d9.presentInterval = 1 fixes the issue. Can this be added as a game-specific workaround?

It looks ok on my side:
https://imgur.com/a/WIbk5OS

I don't really like the idea of force-enabling vsync since the results depend on each user's monitor. But then again we don't have any other FPS limiter at the moment.
Would be interesting to know at which frame rate it starts breaking, if it's 200 FPS or less then we definitely need something else since high refresh rate monitors might start running into the issue otherwise.

This is the FPS limiter I use for Vulkan applications:
https://github.com/pchome/VkGHL

I don't really like the idea of force-enabling vsync since the results depend on each user's monitor. But then again we don't have any other FPS limiter at the moment.

On second thought, I agree and take back my suggestion. Since it won't affect everyone it shouldn't be considered as a workaround.
However, an entry in the Common-isues section of the wiki for high refresh-rate problems in general (while not DXVK specific) would be useful for people running into these sort of things and not knowing what they are or how they can be fixed. I would still be one of them if not for the feedback you've provided on this thread.
That being said, I'm quite happy I've figured out one of the last things preventing me from playing this game, so I'm closing this "bug" :). Thanks again for all your inputs.

I don't really like the idea of force-enabling vsync since the results depend on each user's monitor. But then again we don't have any other FPS limiter at the moment.

Time leaping into the future/present (depends on your point of view really), now with a dxvk frame limiter at hand (thanks for that @doitsujin!), could we please lock this game to 60 fps?

Thank you @DadSchoorse !


Fix Color Contrast Error for User Profile

Ends an open  from develop and uses the middle gray for the user profile to improve the contrast ratio.

Coverage remained the same at 54.082% when pulling 1afda932ec8f33666398c3523a1e50d14dbf941f on i#1228 into 1222a615569fa9b8a1acc0017352935f85aad25a on develop.


[Event Request] Table 5050 Contact - trigger OnValidate Address

Hi,
We need the next code and event in table 5050 Contact, OnValidate of Address:
trigger OnValidate()
            begin
               OnBefoureFindStreetNameFromAddress(Rec, CurrFieldNo, IsHandled);// New code
                if IsHandled then;// New code
                    Exit; ;// New code

              PostCodeMgt.FindStreetNameFromAddress(Address, "Address 2", "Post Code", City, "Country/Region Code", "Phone No.", "Fax No.");
            end;

Thanks,
Cosmina

Hi,
Any news about this request ?
Thanks,
Cosmina

Please help us understand the purpose of this event? And we have different code in latest version, please check if you really need this event at all.

Hi,

At validation of Address we have some custom code, for example to fill in a certain field.
We have for example a functionality to SyncAddressWhenModifyContact, this functionality should not trigger the code from OnValidate related to FindStreetNameFromAddress. (we want to copy the information) but we want to trigger the rest of the code from OnValidate.
We need that the code related to FindStreetNameFromAddress to be triggered just when is from user interface because from code we have other functionalities related to Address.

Thanks,
Cosmina

You can do all this by using embedded events available for any field validation - OnBeforeValidateEvent and OnAftervalidateEvent. Please also consider subscribers in PostCodeManagement codeunit in NL version.


assert current_head is not None error

Hi @h3ndrk!
First off - amazing stuff! This project seems to be exactly what I was looking for when trying to add some "interact-ability" to my mkdocs project.
I made it pretty far and was able to install everything (along with the backend) just fine and was even able to build my mkdocs project after adding the plugin to the mkdocs.yml config (tricky bit was guessing the right plugin name interactive_widgets :wink:)
The error I am seeing is when I try to add  simple button (like in the README) that prints the date I am seeing an error.
Here is the button I added to a .md package:
<x-button command="date" image="ubuntu:latest" label="Print date" working-directory="/data" />

And when I try and run mkdocs build after adding that page to my project I get:
  File "/home/user/plugin_venv/lib/python3.8/site-packages/interactive_widgets_mkdocs/plugin.py", line 121, in on_post_page
    assert current_head is not None
AssertionError

Any ideas on what might be causing the error?

@h3ndrk I figured it out, was just missing a comment in the markdown like this:
<!-- interactive-widgets -->

And also had to adjust the plugins.py logic a bit to loop over all the comments in the file:
            comments = soup.find_all(string=lambda text: isinstance(text, bs4.Comment))
            for comment in comments:
                log.warn(comment)
                if comment.strip() == 'interactive-widgets':
                    current_head = comment
            assert current_head is not None

I'll make a PR in a bit with the fix

I saw your comments and will reply in more detail later. For the moment, here is an example project that uses the widgets already: https://github.com/HULKs/recruiting-website Maybe you find some answers while looking into the code. This project is also deployed, if you want to see it in action: https://recruiting.hulks.de

@h3ndrk no rush, thanks for replying! I'll check out the example tomorrow and should be able to figure it out from there.
Thanks again for your amazing work here 👏


Can't use PowerToys Run

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
PowerToys auto-update, Microsoft Store
Running as admin
No
Area(s) with issue?
PowerToys Run
Steps to reproduce
Just try to open PowerToys Run and it shows the error.
2024-07-04.txt
✔ Expected Behavior
Should open PowerToys Run text box
❌ Actual Behavior
Crashing PowerToys Run
Other Software
No response

/dup #33504


Prepare verify step for Gardener update

How to categorize this PR?

/area delivery
/kind regression
/priority normal
What this PR does / why we need it:
With #80 I noticed that the verify step constantly fails during go generate. It turned out that Go Modules have been disabled for go generate in https://github.com/gardener/gardener/pull/3489 and thus vendor-ed dependencies cannot be resolved outside the GOPATH. With this PR we follow the same approach as for other Gardener repos which copy the repo first to the GOPATH before executing further instructions.
Release note:

NONE

/close
as it could be added to #80.


Change max-line-length to 150

Fixes #245
Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[ ] I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

Changing --max-line-length in .flake8.ini from 85 to 150

@mariobehling please review. Thanks


ci: clarify the name of a print logs job

Specifically, that it runs only on failure

#272  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pepyakin and the rest of your teammates on  Graphite


fix substr constructor

the correct form of substring constructor has 3 arguments, original string, starting position and length.
apparently starting position was missing.

@lazydroid
https://cplusplus.com/reference/string/basic_string/basic_string/
basic_string (const charT* s, size_type n, const allocator_type& alloc = allocator_type());
so it is correct
Even more, I have already passed at that point https://github.com/mujin/controllerclientcpp/pull/131

you're passing std::string as the first parameter, I doubt this gets automatically cast into char *

here's a little proof of the concept:
$ cat substr.cpp
#include <iostream>
#include <string>

int main()
{
	char *hw = "Hello World\n";

	std::cout << std::string(hw, 6);
	std::cout << std::string(std::string(hw), 6);

	return 0;
}
$ ./substr
Hello World
$

please check again
inline void ParseJson(rapidjson::Document& d, const char* str, size_t length) {
        const std::string substr(str, length < 200 ? length : 200);

sorry
call me again after any changes
/cc @ntohge


Consider providing binaries

Please consider providing binaries (can be easily generated by github workflow).
Remove bash scripts (install & update) and merge them into main.go (update can be handle with selfupdate packages there are multiple doing that job).

@RichardFevrier Thanks for the feedback! I am currently time crunched and focused on chasing features and bugs for my personal use case in the short-run but once that's out of the way, I will certainly work on making distribution a little bit more friendly as you suggest especially if there's a demand for it. :)

@RichardFevrier The latest release (v0.11) should hit a lot of what you were talking about in terms of installation via binaries. Let me know if you have any feedback.
One thing I haven't done and plan on fixing is that update currently does not check the currently installed version against the latest version. It just overwrites no matter what.

Overwriting no matter what is a good enough solution I think 🙂
I was curious when you merged #4 why it didn't produce the binaries for the v0.09 release since I did checked it worked on my side before the request. Seeing your commit 8e1000d I think I understand now.
You've created the release before creating the tag am I wrong?

I actually sent you an e-mail about that with a screenshot of the error but it must have been eaten by spam filters or the Internet monster.  I do releases through the web UI and it requires me to create the tag in parallel of submitting a release so when the job runs, it fails to create tag because the tag already exists. So instead, I changed the job to upload artifacts to existing tag instead of creating a new tag.

Oh and I personally couldn't stand "just overwriting" for the update function 😅 so for v0.13, update checks for the latest version and compares it with the currently installed version to determine whether or not it should move forward with the update.

Last but not least, If all looks good to you, I am thinking we can close this issue...

I actually sent you an e-mail about that with a screenshot of the error but it must have been eaten by spam filters or the Internet monster.  I do releases through the web UI and it requires me to create the tag in parallel of submitting a release so when the job runs, it fails to create tag because the tag already exists. So instead, I changed the job to upload artifacts to existing tag instead of creating a new tag.

Exact my solution creates automatically the release when the tag is created but do how you prefer 🙂

What about using the latest binary instead of compiling the app in the install and update scripts before closing this issue?

It's done already as of v0.12 but it was broken for FreeBSD and Mac because of a silly oversight and that's why I released v0.13 pretty much right away to fix the issues.
In v0.12/v0.13, users can use a single command to install the binaries way.
The single command is listed in README.md, docs/INSTALL.md, docs/UPGRADE.md, and https://hkdb.github.io/app (dist dir is automatically deployed to github pages on release)
The actual script this single command utilizes is dist/getapp.sh or in reality,  https://hkdb.github.io/app/getapp.sh.
To update app, simply running app -m app update will do. What it actually does is it checks against https://hkdb.github.io/app/version.txt ( dist/version.txt ) to determine what the latest release is and if current version is < latest version, it utilizes the script in https://hkdb.github.io/app/updateapp.sh ( dist/updateapp.sh ) to download the binary and overwrite the existing binary.
I actually did a more high level writeup about this and gave you a shout out:
https://medium.com/@hkdb/app-v0-13-is-officially-released-fd7ca6fd1aa2
If you need a friend link instead, I am more than happy to send you one privately.
install.sh & update.sh will remain as is for those who prefer to install and update by compiling and of course, to make dev/test easier. I did however bring over the new code in dist/getapp.sh and dist/updateapp.sh for configuring dot files etc since it accounts for the various shells much better and I removed all the code for installing different package managers so as to stay true to the concept of leaving it to the user to configure their package managers properly.


Possible Reactor context loss in TracedSubscriber and WebClientSubscriber

After activating/attaching of agent to java process all custom information stored by Mono.contextWrite(..) becomes unreachable later in subscriber
Steps to reproduce
Store something in the context
webClient
  .get()
  .uri(...)
  .exchangeToMono(...)
  .contextWrite(ctx -> ctx.put("KEY_1", "VAL_1"));

And later if we'll try to get context.get("KEY_1") this info from the context in a subscriber we'll get NoSuchElementException
Without activating/attaching of agent we'll get this info from the context.
Looks like the problem is in co.elastic.apm.agent.reactor.TracedSubscriber and co.elastic.apm.agent.springwebclient.WebClientSubscriber.
In TracedSubscriber the real subscriber's context is stored in the constructor but should be obtained each time in currentContext()
@Override
public Context currentContext() {
    final AbstractSpan<?> context = getContext();
    if (context != null) {
        return subscriber.currentContext().put(AbstractSpan.class, context);
    } else {
        return subscriber.currentContext();
    }
}

In WebClientSubscriber default implementation of method currentContext() in parent CoreSubscriber recreates empty context but should delegate this call to a real subscriber:
@Override
public Context currentContext() {
    return subscriber.currentContext();
}

This is a draft of pull request https://github.com/elastic/apm-agent-java/pull/2885

Great job!
Very serious BUG. Agent breaks user code

Hi @hmanon as explained in this comment on the PR I did not manage to reproduce the issue directly. I am really not an expert in Webflux/Reactor, so if you have a use-case or a sample code that helps to reproduce it would definitely help.