Color mappings fail for csv in UTF8-encoding and color mapping in first column

Scribus version: 1.5.4
CSV encoding: UTF8
Area: Color mapping
Color mappings fail when csv is saved as UTF8 and color mapping is in first column.
This seems to be because the first column gets prefixed by "\xef\xbb\xbf"
Example
VARNAMES [['\xef\xbb\xbfdummy', 'bgcolor', 'name', 'text', 'points', 'level', 'symbolimage']
Workaround
Add dummy column first in csv.
Attached example with dummy column.
Cards.zip

Hello @tofalemo
EF BB BF in hexadecimal is the UTF-8 BOM: http://www.unicode.org/faq/utf_bom.html#BOM
I guess your CSV editor did not ask you if yon wanted to save as CSV with BOM or without BOM.
I'll test if using python-unicodecsv instead of the python native csv library solves this issue and works in all cases.

or yet better (as a note to self to test), per https://tobywf.com/2017/08/unicode-csv-excel/
with open('test.csv', 'w', encoding='utf-8-sig', newline='') as fp:

seems to be fixed by updating to latest (python3) script and scribus. kindly test and get back in touch if you still experience the problem.


Unable to edit DecimalPreference

I'm getting an error when trying to edit a DecimalPreference using a rest_framework api viewset.
Environment
macOS Sierra 10.12.6
Python=3.6.1
Django=1.11
djangorestframework=3.6.1
Steps

Create a DecimalPreference and attach it to my company register.

@company_preferences_registry.register
class IsPublic(DecimalPreference):
    section = global
    name = 'minimum_price'
    default = Decimal(0)

Create Viewset and Serializer to edit company preferences

class CompanyPreferencesViewSet(PerInstancePreferenceViewSet):
    queryset = CompanyPreferenceModel.objects.all()
    serializer_class = CompanyPreferenceSerializer
    permission_classes = (IsAuthenticated)
    pagination_class = None

    def get_related_instance(self):
        return self.request.user.company

class CompanyPreferenceSerializer(PreferenceSerializer):
    pass

Verify that 0 is returned when calling GET /preferences/

[
  {
    "section": "global",
    "name": "minimum_price",
    "identifier": "global__minimum_price",
    "default": "",
    "value": "0",
    "verbose_name": null,
    "help_text": "",
    "additional_data": {},
    "field": {
      "class": "CharField",
      "widget": {
        "class": "TextInput"
      },
      "input_type": "text"
    }
  }
]

Make a PATCH request to /preferences/global__minimum_price/ which returns the following error.

Traceback:

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
  41.             response = get_response(request)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
  187.                 response = self.process_exception_by_middleware(e, request)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
  185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/django/views/decorators/csrf.py" in wrapped_view
  58.         return view_func(*args, **kwargs)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/viewsets.py" in view
  83.             return self.dispatch(request, *args, **kwargs)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/views.py" in dispatch
  483.             response = self.handle_exception(exc)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/views.py" in handle_exception
  443.             self.raise_uncaught_exception(exc)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/views.py" in dispatch
  480.             response = handler(request, *args, **kwargs)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/mixins.py" in update
  69.         serializer.is_valid(raise_exception=True)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/serializers.py" in is_valid
  236.                 self._validated_data = self.run_validation(self.initial_data)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/serializers.py" in run_validation
  431.         value = self.to_internal_value(data)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/rest_framework/serializers.py" in to_internal_value
  463.                     validated_value = validate_method(validated_value)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/dynamic_preferences/api/serializers.py" in validate_value
  64.         field.run_validators(value)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/django/forms/fields.py" in run_validators
  145.                 v(value)

File "/Users/vignesh/.pyenv/versions/klopp/lib/python3.6/site-packages/django/core/validators.py" in __call__
  420.         digit_tuple, exponent = value.as_tuple()[1:]

Exception Type: AttributeError at /api/preference/global__minimum_price/
Exception Value: 'str' object has no attribute 'as_tuple'

I was able to fix this issue by doing the following in dynamic_preference/api/serializers.py. Basically before trying to validate the value convert it into the internal python value.
class PreferenceSerializer(serializers.Serializer):

...
    def validate_value(self, value):
        """
        We call validation from the underlying form field
        """
        field = self.instance.preference.setup_field()
        value = field.to_python(value)
        field.validate(value)
        field.run_validators(value)
        return value

  ...

Thanks for reporting this, you probably found a bug in the package. I'll have a look at your PR (#98).

Any chance that this can be fixed soon? This is sort of a showstopper for me. Otherwise I think the package is a great idea and fits our needs perfectly 👍. I could even help to add Date, Datetime and other preference types in the future as I might be needing them!

I'll take a few hours to work on this on monday, hopefully this will be enough to solve the issue.Sorry for the trouble!EliotBerriot/django-dynamic-preferences wrote:Any chance that this can be fixed soon? This is sort of a showstopper for me. Otherwise I think the package is a great idea and fits our needs perfectly 👍. I could even help to add Date, Datetime and other preference types in the future as I might be needing them!
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

Great. Thanks!

Release 1.3.3 published ;)


[Bug]: KeyError: 'layers.60.mlp.gate_up_proj.weight' mistral large bitsandbytes

Your current environment

The output of `python collect_env.py`
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 24.04.1 LTS (x86_64)
GCC version: (Ubuntu 13.2.0-23ubuntu4) 13.2.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.39

Python version: 3.10.15 | packaged by conda-forge | (main, Sep 30 2024, 17:51:04) [GCC 13.3.0] (64-bit runtime)
Python platform: Linux-6.8.0-45-generic-x86_64-with-glibc2.39
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA H100 PCIe
GPU 1: NVIDIA H100 PCIe

Nvidia driver version: 535.183.06
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                         x86_64
CPU op-mode(s):                       32-bit, 64-bit
Address sizes:                        46 bits physical, 57 bits virtual
Byte Order:                           Little Endian
CPU(s):                               192
On-line CPU(s) list:                  0-191
Vendor ID:                            GenuineIntel
Model name:                           INTEL(R) XEON(R) PLATINUM 8568Y+
CPU family:                           6
Model:                                207
Thread(s) per core:                   2
Core(s) per socket:                   48
Socket(s):                            2
Stepping:                             2
CPU(s) scaling MHz:                   20%
CPU max MHz:                          4000.0000
CPU min MHz:                          800.0000
BogoMIPS:                             4600.00
Flags:                                fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cat_l2 cdp_l3 intel_ppin cdp_l2 ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local split_lock_detect user_shstk avx_vnni avx512_bf16 wbnoinvd dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req hfi vnmi avx512vbmi umip pku ospke waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq la57 rdpid bus_lock_detect cldemote movdiri movdir64b enqcmd fsrm md_clear serialize tsxldtrk pconfig arch_lbr ibt amx_bf16 avx512_fp16 amx_tile amx_int8 flush_l1d arch_capabilities
Virtualization:                       VT-x
L1d cache:                            4.5 MiB (96 instances)
L1i cache:                            3 MiB (96 instances)
L2 cache:                             192 MiB (96 instances)
L3 cache:                             600 MiB (2 instances)
NUMA node(s):                         2
NUMA node0 CPU(s):                    0-47,96-143
NUMA node1 CPU(s):                    48-95,144-191
Vulnerability Gather data sampling:   Not affected
Vulnerability Itlb multihit:          Not affected
Vulnerability L1tf:                   Not affected
Vulnerability Mds:                    Not affected
Vulnerability Meltdown:               Not affected
Vulnerability Mmio stale data:        Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed:               Not affected
Vulnerability Spec rstack overflow:   Not affected
Vulnerability Spec store bypass:      Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:             Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:             Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S
Vulnerability Srbds:                  Not affected
Vulnerability Tsx async abort:        Not affected

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-cublas-cu12==<IP_ADDRESS>
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==<IP_ADDRESS>
[pip3] nvidia-cufft-cu12==<IP_ADDRESS>
[pip3] nvidia-curand-cu12==<IP_ADDRESS>
[pip3] nvidia-cusolver-cu12==<IP_ADDRESS>
[pip3] nvidia-cusparse-cu12==<IP_ADDRESS>
[pip3] nvidia-ml-py==12.560.30
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] nvidia-nvjitlink-cu12==12.6.77
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] pyzmq==26.2.0
[pip3] torch==2.4.0
[pip3] torchvision==0.19.0
[pip3] transformers==4.45.2
[pip3] triton==3.0.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-cublas-cu12        <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cuda-cupti-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-nvrtc-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-runtime-cu12  12.1.105                 pypi_0    pypi
[conda] nvidia-cudnn-cu12         <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cufft-cu12         <IP_ADDRESS>                pypi_0    pypi
[conda] nvidia-curand-cu12        <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusolver-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusparse-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-ml-py              12.560.30                pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] nvidia-nvjitlink-cu12     12.6.77                  pypi_0    pypi
[conda] nvidia-nvtx-cu12          12.1.105                 pypi_0    pypi
[conda] pyzmq                     26.2.0                   pypi_0    pypi
[conda] torch                     2.4.0                    pypi_0    pypi
[conda] torchvision               0.19.0                   pypi_0    pypi
[conda] transformers              4.45.2                   pypi_0    pypi
[conda] triton                    3.0.0                    pypi_0    pypi
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: N/A (dev)
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      SYS     0-47,96-143     0               N/A
GPU1    SYS      X      48-95,144-191   1               N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

🐛 Describe the bug
while trying to deploy mistral-large with bitsandbytes in-flight quantization on 2 H100 80GB, I came across this error.
[rank0]: KeyError: 'layers.60.mlp.gate_up_proj.weight'

minimal code to reproduce it:
from vllm import LLM, SamplingParams
import torch
model_id = "mistralai/Mistral-Large-Instruct-2407"
llm = LLM(model=model_id, dtype=torch.bfloat16, trust_remote_code=True, \
quantization="bitsandbytes", load_format="bitsandbytes", tensor_parallel_size = 2)

full log trace.

WARNING 10-15 14:08:21 config.py:306] bitsandbytes quantization is not fully optimized yet. The speed can be slower than non-quantized models.
WARNING 10-15 14:08:21 arg_utils.py:953] Chunked prefill is enabled by default for models with max_model_len > 32K. Currently, chunked prefill might not work with some features or models. If you encounter any issues, please disable chunked prefill by setting --enable-chunked-prefill=False.
INFO 10-15 14:08:21 config.py:1005] Chunked prefill is enabled with max_num_batched_tokens=512.
INFO 10-15 14:08:21 llm_engine.py:237] Initializing an LLM engine (vdev) with config: model='mistralai/Mistral-Large-Instruct-2407', speculative_config=None, tokenizer='mistralai/Mistral-Large-Instruct-2407', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, override_neuron_config=None, rope_scaling=None, rope_theta=None, tokenizer_revision=None, trust_remote_code=True, dtype=torch.bfloat16, max_seq_len=131072, download_dir=None, load_format=LoadFormat.BITSANDBYTES, tensor_parallel_size=1, pipeline_parallel_size=1, disable_custom_all_reduce=False, quantization=bitsandbytes, enforce_eager=False, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), observability_config=ObservabilityConfig(otlp_traces_endpoint=None, collect_model_forward_time=False, collect_model_execute_time=False), seed=0, served_model_name=mistralai/Mistral-Large-Instruct-2407, use_v2_block_manager=True, num_scheduler_steps=1, chunked_prefill_enabled=True multi_step_stream_outputs=True, enable_prefix_caching=False, use_async_output_proc=True, use_cached_outputs=False, mm_processor_kwargs=None)
/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/transformers_utils/tokenizer_group/tokenizer_group.py:23: FutureWarning: It is strongly recommended to run mistral models with `--tokenizer_mode "mistral"` to ensure correct encoding and decoding.
  self.tokenizer = get_tokenizer(self.tokenizer_id, **tokenizer_config)
INFO 10-15 14:08:35 model_runner.py:1060] Starting to load model mistralai/Mistral-Large-Instruct-2407...
INFO 10-15 14:08:35 loader.py:1051] Loading weights with BitsAndBytes quantization.  May take a while ...
INFO 10-15 14:08:36 weight_utils.py:243] Using model weights format ['*.safetensors']
Loading safetensors checkpoint shards:   0% Completed | 0/102 [00:00<?, ?it/s]
Loading safetensors checkpoint shards:   1% Completed | 1/102 [00:00<01:20,  1.26it/s]
Loading safetensors checkpoint shards:   2% Completed | 2/102 [00:01<01:12,  1.39it/s]
Loading safetensors checkpoint shards:   3% Completed | 3/102 [00:02<01:10,  1.40it/s]
[rank0]: Traceback (most recent call last):
[rank0]:   File "/home/cpassero/workspace/temp/bnb/test.py", line 4, in <module>
[rank0]:     llm = LLM(model=model_id, dtype=torch.bfloat16, trust_remote_code=True, \
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/entrypoints/llm.py", line 177, in __init__
[rank0]:     self.llm_engine = LLMEngine.from_engine_args(
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 574, in from_engine_args
[rank0]:     engine = cls(
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 335, in __init__
[rank0]:     self.model_executor = executor_class(
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/executor/executor_base.py", line 47, in __init__
[rank0]:     self._init_executor()
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/executor/gpu_executor.py", line 40, in _init_executor
[rank0]:     self.driver_worker.load_model()
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/worker/worker.py", line 183, in load_model
[rank0]:     self.model_runner.load_model()
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/worker/model_runner.py", line 1062, in load_model
[rank0]:     self.model = get_model(model_config=self.model_config,
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/model_loader/__init__.py", line 19, in get_model
[rank0]:     return loader.load_model(model_config=model_config,
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/model_loader/loader.py", line 1148, in load_model
[rank0]:     self._load_weights(model_config, model)
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/model_loader/loader.py", line 1082, in _load_weights
[rank0]:     model.load_weights(qweight_iterator)
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/models/llama.py", line 580, in load_weights
[rank0]:     loader.load_weights(
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/models/utils.py", line 192, in load_weights
[rank0]:     self._load_module("", self.module, weights)
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/models/utils.py", line 173, in _load_module
[rank0]:     self._load_module(prefix, child_modules[child_prefix],
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/models/utils.py", line 160, in _load_module
[rank0]:     module_load_weights(weights)
[rank0]:   File "/home/cpassero/miniconda/envs/test/lib/python3.10/site-packages/vllm/model_executor/models/llama.py", line 395, in load_weights
[rank0]:     param = params_dict[name]
[rank0]: KeyError: 'layers.60.mlp.gate_up_proj.weight'
Loading safetensors checkpoint shards:   3% Completed | 3/102 [00:02<01:19,  1.25it/s]

Other persons mentioned it:  posted by @figuernd in https://github.com/vllm-project/vllm/issues/4198#issuecomment-2412149718_
this is related to the packed module here:
https://github.com/vllm-project/vllm/blob/v0.6.2/vllm/model_executor/models/llama.py#L354
we have gate and up layers referenced in the safetensor index, but somewhat the packing does not happen.
https://huggingface.co/mistralai/Mistral-Large-Instruct-2407/blob/main/model.safetensors.index.json#L523
might be linked to these issues:
https://github.com/vllm-project/vllm/issues/4198
https://github.com/vllm-project/vllm/issues/9316
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

@mgoin can you help look into this? Thanks!

I am able to more easily reproduce this with mistral-7b
vllm serve mistralai/Mistral-7B-Instruct-v0.3 --quantization bitsandbytes --load-format bitsandbytes

The issue seems to be that we are confused by the presense of both HF-format and Mistral-format weights within the model repo. All of the weights in the HF-format safetensors get loaded and quantized correctly, however we then try to load in the Mistral-format "consolidated" weights they are not quantized and we fail to resolve the param name.
name before maybe_remap_mistral: model.layers.0.self_attn.k_proj.qweight
name after maybe_remap_mistral: model.layers.0.self_attn.k_proj.qweight
param_name: .qkv_proj
weight_name: .k_proj
shard_id: k
final name: model.layers.0.self_attn.qkv_proj.qweight
...
name before maybe_remap_mistral: layers.0.attention.wk.weight
name after maybe_remap_mistral: model.layers.0.self_attn.k_proj.weight
param_name: .qkv_proj
weight_name: .k_proj
shard_id: k
final name: model.layers.0.self_attn.qkv_proj.weight
# KeyError: 'model.layers.0.self_attn.qkv_proj.weight'

Notice that there is no problem in the first name mapping because it is a proper .qweight param, however the second time around with the mistral format name it is just a .weight param that we don't have in our params_dict

@mgoin thank you for having looked at it. What would be the way to solve this issue ?


Create "Join us" page

please create a "Join us" page. No need to put it on the main navbar.
Here's the placeholder content to use:
You can help us and many in Nepal just from your couch or sofa. You can a designer, marketer, coder, writer, problem-solver, or anyone else and are interested in helping people make better use of technology, be digitally and data literate, then join us via:
Slack (Say hello and introduce yourself)
Github (You can start looking at projects and contribute by resolving issues or suggesting enhancements)
Facebook
Twitter
We also encourage you to explore our website, learn about our projects, and read the “Code of Conduct” policy.
If you are an Amazon shopper, you can help us by shopping through smile.amazon.com and selecting to support Code for Nepal.

sure working on it

https://github.com/CodeforNepal/website20/pull/64#issue-489765811

@ishandongol  - could you pls hyperlink "join us" page to"get involved" button on the homepage?

sure @ravinepal

https://codefornepal.github.io/website20/joinus/

@ishandongol - just flagging that the link for join us "get involved" does not work anymore. when you have time pls take a look, it is not urget.

sure

@ravinepal is this resolved?


Use sliver-based scrolling in more places

This patch uses sliver-based two more gallery demos, the stocks example,
in the date picker, and in markdown.

@Hixie


Create orders from dashboard

closes #1125

Codecov Report

Merging #1301 into master will decrease coverage by 0.04%.
The diff coverage is 68.49%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23c7cf...554272e. Read the comment docs.

We should hold this PR for now. First we have to merge #1194 as it adds widgets and logic that may be useful here. Then we should rethink the requirements more carefully. The logic behind order management is getting more and more complex and I'm afraid that if we don't clean up the code now, it'll become difficult to maintain.


add tests 100%

Fixes #17 (it's a good idea to open an issue first for discussion)

[x] - npm test succeeds
[x] - Code coverage does not decrease (if any source code was changed)
[x] - Appropriate JSDoc comments were updated in source code (if applicable)
[x] - Approprate changes to js-data.io docs have been suggested ("Suggest Edits" button)

@jmdobry @ramirezd42 please take a look. I couldn't get an assertion on throw new Error() when not passing a Container or Mapper instance. I tried using expect() from chai but code coverage doesn't pick-up the function invokation. Any thoughts?

Current coverage is 97.54% (diff: 100%)

Merging #19 into master will increase coverage by 7.37%

@@             master        #19   diff @@
==========================================
  Files             3          3
  Lines           122        122
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            110        119     +9
+ Misses           12          3     -9
  Partials          0          0

Powered by Codecov. Last update 3b7c0d3...96f7ad6

The two lines that were missed are here: https://codecov.io/gh/js-data/js-data-express/src/96f7ad6b2c8d57747f48ff22ad3987b8a3adb994/src/index.js#L27


schema: Drop self-describing media types from manifest(-list) tests

Catch up with #411 (and fixing test errors after rebuilding schema/fs.go).
Ideally we'd be testing “is schema/fs.go current?” in Travis, and I'm trying to handle that in #530, but it's tricky.  We can land these test fixes in the meantime, without blocking on more robust CI.

Make sure to remove this from manifest.md and manifest-list.md, as well.

On Thu, Jan 26, 2017 at 01:22:35PM -0800, Stephen Day wrote:

Make sure to remove this from manifest.md and manifest-list.md, as
well.

Those were marked reserved by #411 (although I'd asked for them to be
removed 1).  If the current maintainer consensus has changed to be
“they should also be removed”, I'm happy to do that in this PR (just
let me know).

On Thu, Jan 26, 2017 at 01:36:02PM -0800, W. Trevor King wrote:

Thu, Jan 26, 2017 at 01:22:35PM -0800, Stephen Day:

Make sure to remove this from manifest.md and manifest-list.md, as
well.

Those were marked reserved by #411 (although I'd asked for them to
be removed 1).  If the current maintainer consensus has changed to
be “they should also be removed”, I'm happy to do that in this PR
(just let me know).

Or did you just mean “remove mediaType from those examples”?  That
seems less controversial to me, so I've done it with bc6f0fd →
99e6104.  Still let me know if you need anything different about the
mediaType definitions 1.

LGTM

lgtm


Add "canary" workflow for HMR simulations [WIP]

Resolves #21
What the script looks like in action:
(openff-dev) [openforcefields] echo openforcefields/offxml/openff-1.2.0.offxml | python canary/scripts/test_hmr.py
Running HMR with force field openff-1.2.0 and molecule with SMILES [H]C#CC([H])([H])[H]
Running HMR with force field openff-1.2.0 and molecule with SMILES [H]c1c(c(c(c(c1[H])[H])C#CC([H])([H])[H])[H])[H]
Traceback (most recent call last):
  File "canary/scripts/test_hmr.py", line 92, in <module>
    raise HMRCanaryError(failed_runs)
__main__.HMRCanaryError: [[Molecule with name '' and SMILES '[H]c1c(c(c(c(c1[H])[H])C#CC([H])([H])[H])[H])[H]', 'openff-1.2.0']]
(openff-dev) [openforcefields] echo openforcefields/offxml/openff-1.2.1.offxml | python canary/scripts/test_hmr.py
Running HMR with force field openff-1.2.1 and molecule with SMILES [H]C#CC([H])([H])[H]
Running HMR with force field openff-1.2.1 and molecule with SMILES [H]c1c(c(c(c(c1[H])[H])C#CC([H])([H])[H])[H])[H]

I was running into some stochastic test passes with 2 ps runs, so bumped it up to 10 ps.
Many of the "coverage" mols are not covered by Parsley. Haven't dug into them much for more insightful failures.
I intentionally kept these functions out of the module structure of the Python package as I don't believe these are things we should focus on shipping out. These are intentionally not rigorous and I'd like to avoid making long-term guarantees to the users that these tests are stable, or even a part of the API.

This will be a little tricky to review, let me try to provide the necessary context:

This branch at 7de9632 is "the real" version
In ab97f08 I added back openff-1.2.0.offxml, which at least does what's expected locally, and should cause CI to fail. It will be rolled back before merging

(openff-dev) [openforcefields] git diff upstream/master --name-only | grep "\.offxml" | python canary/scripts/test_hmr.py
Running HMR with force field openff-1.2.0-old-and-bad and molecule with SMILES [H]C#CC([H])([H])[H]
Running HMR with force field openff-1.2.0-old-and-bad and molecule with SMILES [H]c1c(c(c(c(c1[H])[H])C#CC([H])([H])[H])[H])[H]
Traceback (most recent call last):
  File "canary/scripts/test_hmr.py", line 92, in <module>
    raise HMRCanaryError(failed_runs)
__main__.HMRCanaryError: [[Molecule with name '' and SMILES '[H]c1c(c(c(c(c1[H])[H])C#CC([H])([H])[H])[H])[H]', 'openff-1.2.0-old-and-bad']]

All canary tests failing in 372a96a, rolling back the bad OFFXML and merging


Add Dockerfile and the workflow to publish to docker hub

Add Dockerfile and the workflow to publish to docker hub

Preview is available here:http://stellar-anchor-tests-pr118.previews.kube001.services.stellar-ops.com/


Fix Handlebars Fn's

Handlebars fn's could be overwritten if the same fn is used in other modules
Updated handlebars fn names to include module name to drastically reduce potential collisions

close #28


Add methods to the Reference / Query class to match Javascript docs

List of operations here:
https://firebase.google.com/docs/reference/js/firebase.database.Reference
If I'm putting together a wishlist: orderByChild, startAt / endAt / equalTo, isEqual, limitToFirst / limitToLast, update.

Thanks for taking time to submit this issue! I should actually have some time today to work on this. Stay tuned.

1.0.0-dev.6.0 is now on Pub:
https://pub.dartlang.org/packages/firebase_admin_interop/versions/1.0.0-dev.6.0#-changelog-tab-
Should have all methods you mentioned.
Only Query.off, Query.on and Reference.transaction are missing, I think. Feel free to submit a separate issue if any of those become critical (and I don't get to them sooner :-) ).


Add flag to choose a path in pingpong

Basically adding 'interactive' mode, to choose a path.

This change is

Reviewed 1 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, 2 unresolved discussions.

go/examples/pingpong/pingpong.go, line 299 at r1 (raw file):

choosePath
I think you can avoid having to iterate twice over the pathSet
See the PR I did on your branch (feel free to ignore it if you think it does not apply)

go/examples/pingpong/Readme.md, line 16 at r1 (raw file):

When running the client in interactive mode, the user would be able to choose
the path used. A side effect is that the application will not adapt to path
updates, whereas snet will manage path updates whn running in non-interactive

typo:
when

Comments from Reviewable

Reviewed 1 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

go/examples/pingpong/pingpong.go, line 299 at r1 (raw file):
Previously, FR4NK-W wrote…

choosePath
I think you can avoid having to iterate twice over the pathSet
See the PR I did on your branch (feel free to ignore it if you think it does not apply)

This can definitely be simplified. See my comments on #1428

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

go/examples/pingpong/pingpong.go, line 299 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
This can definitely be simplified. See my comments on #1428

Agree, will simplify it as suggested.

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

go/examples/pingpong/pingpong.go, line 299 at r1 (raw file):
Previously, sgmonroy wrote…
Agree, will simplify it as suggested.

Done.

go/examples/pingpong/Readme.md, line 16 at r1 (raw file):
Previously, FR4NK-W wrote…
typo:
when

Done.

Comments from Reviewable

Reviewed 3 of 4 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Struggles with white letters with a black outline/"bubble letters"

The manga Yakusoku no Neverland seems to have a lot of white text with a black outline in it, and manga-ocr seems to struggle with this to varying degrees. One example:

Output:

日常に酒む「意図」

This is actually a bit "nicer" of an example, one it's not struggling with as bad as some of the others. I'll have to backtrack and find the other worse examples once I'm done this chapter, but I just wanted to open an issue before I forget again.
Do note that I'm using mokuro for this, so the screenshots I'm submitting as examples here aren't the actual images that were processed, so maybe the output will be a tad different?

More:

Output:

『田』

Output:

そして周りを取り囲む『認

Output:

いいけど、

Output:

あ

Invert the images in your favorite graphics editor and it works flawlessly.

宣戦布告


I can't find target command in command search because the English description has disappeared

Issue Type: Bug
I can't just type "collapse" in command search to find the command "workbench.files.action.collapseExplorerFolders", however I could achieve this in previews version in VS Code.

This problem appears on both my Windows and Ubuntu machine. I believe that is because you delete its English description in Chinese language pack.

VS Code version: Code 1.53.0 (8490d3dde47c57ba65ec40dd192d014fd2113496, 2021-02-03T15:56:04.185Z)
OS version: Linux x64 5.8.0-41-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz (8 x 2857)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
7.67GB (1.67GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id 078ee844-6d32-4053-9ad3-3027c9560de2

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (7)

Extension
Author (truncated)
Version

code-runner
for
0.11.2

vscode-language-pack-zh-hans
MS-
1.53.2

python
ms-
2021.1.502429796

vscode-pylance
ms-
2021.2.0

jupyter
ms-
2020.12.414227025

cpptools
ms-
1.2.0

java
red
0.74.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30211402
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30251590

This is not a translation problem. If we want to have the original text (e.g. English) for a command we have to provide it (like for example here: https://github.com/microsoft/vscode/blob/master/src/vs/workbench/contrib/tasks/browser/task.contribution.ts#L321)
We don't automatically have the English version of a string (we don't know for which they are necessary so the developer has to decide this).
I actually don't know you owns Action2 and all the code around it.
@isidorn @jrieken @sbatten any hint?

This is supported in Action2 when title is an object, this is a sample: https://github.com/microsoft/vscode/blob/7020ccf1346ad505f1395748882a435c1743256b/src/vs/workbench/browser/actions/layoutActions.ts#L36

Assigning to me since I did not add the original title when adopting Action2 in the Explorer

Thank you guys, this feature helps me a lot. BTW, IDEA doesn't show both English and local language, so VS Code is more friendly in this way :+1:

/verified


[question] Is there any graph explorer tool for Arangodb?

Neo4j has Neo4j Bloom which is convenient for explorer the graph. Is there any tools for arangodb?

@mojerro  have you found any solutions for this?

@mojerro have you found any solutions for this?

not yet, I‘m using pure AQL now.

Also very interested.
Based on my (limited) research, Arango seems like the ideal technology for a longer term project. But the lack of available visualisation and manual exploration tools makes bootstrapping anything incredibly hard. Sort of forces to stick with Neo4j


New Generation Steps are somewhat dangerous

Each of the new generation steps includes a line similar to the following:
var map = context.GetFirstOrNew<ISettableGridView<bool>>(()=> new ArrayView<bool>(context.Width, context.Height));
This is inherently unsafe, as there is no way to guarantee that there is only one component of this type on the GenerationContext.
The fix is to use tags, like how GoRogue uses them.
However, there is a possibility that the generation steps don't belong in the integration lib at all, and may move into the GoRogue repository. See GoRogue #128

I've got a few bugs I need to fix in GoRogue that will likely end up getting done before this, and I anticipate having reduced dev time for a few weeks at the end of January-beginning of Feburary timeframe.  Feel free to make some of the improvements in the integration library for the time being, and we can move it to GoRogue sometime after; that way it doesn't become a bottleneck.

I've got a few bugs I need to fix in GoRogue that will likely end up getting done before this, and I anticipate having reduced dev time for a few weeks at the end of January-beginning of Feburary timeframe.  Feel free to make some of the improvements in the integration library for the time being, and we can move it to GoRogue sometime after; that way it doesn't become a bottleneck.

TODO - Rooms in the BackroomGenerationStep should be private and retrievable through the GetFirstOrNew<ISettableMapView<bool>>. That will come after the rest of the PR.

TODO - Rooms in the BackroomGenerationStep should be private and retrievable through the GetFirstOrNew<ISettableMapView<bool>>. That will come after the rest of the PR.

I'm attempting to use the integration library in another project as a deeper test of the capabilities. I've added a tag to the generation steps and am getting them back via there tag - example code.
Is this the way of making them safer?

I'm attempting to use the integration library in another project as a deeper test of the capabilities. I've added a tag to the generation steps and am getting them back via there tag - example code.
Is this the way of making them safer?

They'll be safer when I delete them because they've moved to GoRogue in issue 218 over there.

They'll be safer when I delete them because they've moved to GoRogue in issue 218 over there.

See the linked issue; I think we could close this if we got a Draft PR that has the generation steps in their current state to GoRogue's repository; that way both the source and tracking issues are associated there.

See the linked issue; I think we could close this if we got a Draft PR that has the generation steps in their current state to GoRogue's repository; that way both the source and tracking issues are associated there.

Tracked via https://github.com/Chris3606/GoRogue/pull/222.  The steps will be removed from the integration lib in a subsequent PR, and future work will be tracked there.

Tracked via https://github.com/Chris3606/GoRogue/pull/222.  The steps will be removed from the integration lib in a subsequent PR, and future work will be tracked there.


Remove any references of HBI/HEE

RISC-V Hypervisor design has been evolved not to have a separate hypervisor
specific privilege mode. Thus, there is no concept of HBI or HEE anymore.
Remove all the references to it and update the diagram.
Signed-off-by: Atish Patra<EMAIL_ADDRESS>

Unless every SEE always also has the hypervisor extension, the distinction still exists and is useful.
There are effectively more privilege modes with the hypervisor extension, not fewer.

It's clear that when the hypervisor doesn't exist then the interface that M mode has to implement is the SBI.  When the hypervisor exists, does M mode need to implement HBI calls?  In what ways are HBI and SBI different?

We can have an SBI or HBI without M-mode - a RISC-V M-mode is only one way to implement an SBI or an HBI.  I think part of the confusion is that "the" SBI (as supported by OpenSBI) is only one possible SBI ECALL interface, and other OS stacks might have their own SBI (in the same way different OS can have their own user ABI).
An EEI is not only the set of  ECALLs, e.g., user ABI includes ISA, user-visible CSRs, as well as calling conventions and ECALLs.  A hypervisor EE provides the additional instructions and CSRs defined by the hypervisor spec - this is different than a non-hypervisor supervisor mode. A HBI ECALL interface might provide additional calls needed to support the hypervisor above and beyond what is needed with a supervisor only.

@pdonahue-ventana Does this PR need further review? If it is still valid, I would be happy to move it to the ASCIIDOC version.

My understanding is that there conceptually is a HEE (and HBI).  The fact that there's no existing implementation of that doesn't negate the fact that it exists in theory.  The existing document seems correct and this PR can just be closed.

Closing PR as per previous comments.


tiledbsoma 1.3.0

Following our release procedure at https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases, as #34 passed Conda pre-check and https://github.com/single-cell-data/TileDB-SOMA/releases/tag/1.3.0 has been tagged

Needs a re-render


[Carbon 10: Data Table] Table heading in table body

Detailed description

Describe in detail the issue you're having.

<th> should be used within the table body to denote the row's heading but it's styling is odd.

Is this issue related to a specific component?

Data Table

What did you expect to happen? What happened instead? What would you like to see changed?

Table row heading should align with the rest of the cells. Often they don't visually look different from other cells but are semantically important for screen reader users

What browser are you working in?

Chrome, FireFox, Safari

What version of the Carbon Design System are you using?

v10.0.0

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Watson Health Pattern & Asset Library (PAL)
Steps to reproduce the issue

Add a th as a cell within the tbody
View the table styles

Screenshot

@IBM/carbon-designers is this a pattern we're supporting? cc: @dakahn is this a requirement for a11y?

For a11y the rows should have headers as well, other wise when the screen reader user is navigating through the table they won't have a clear understanding of what row they are on.  Typically the styles look like a normal table cell as that's visually what most users are used to but semantically the markup should be using th elements.

So @elizabethsjudd are you saying that adding the  tag within the body to denote the row's heading is causing issues with the styling?

cc: @designertyler @aagonzales we don't have a mock up for th(header) within tbody as the row header instead of column header, so the styles right now just target all th's within table, we'd need to update that to target either th within thead and th within tbody and apply styles accordingly, but we'd need to come up with a design spec for what row headers styling would be.

@jeanservaas yes.  I'm trying to have a table that looks like a carbon style but use the proper semantic markup to denote the row heading. Without looking at the code what seems to be happening is the th element is not scoped to the thead so when i use it in the body it looks like a column header instead of a standard row cell.
@jnm2377 Personally I would make the "row header" styling a special class that is optional instead of scoping it to the th in the tbody. A lot of times the designs aren't in a way that they always want to call out which cell is the header so by default it should just look like any other row cell but then we could add a class that would allow us to style it as a "row header".

Right, but the th in tbody would still need to receive "default row cell" styles, so if we want both options, as in have the th look like all the other cells or look like a header, we'd have 2 selectors. Targeting the th would be used to apply the default styles, and the th with the special class would apply an optional "row header" look. @elizabethsjudd

The way I'm understanding the request is only to have the header cells not inherit the darker header style. Or is this request to have the option to do either (look like a head or normal row)?
If that's the case @jnm2377 I'd cut out this second part.

...as in have the th look like all the other cells or look like a header, ...

If that is what we're aiming for, then we need to revisit the design specs since those darker grays may need a divider or something to help separate.

@designertyler The request is to not have the headers in the table body look like the column styles and instead look like a standard tbody cell.  If that bug was taken care, I would say this issue is fixed.  The table in the screen shot should look like the tables on the Carbon website.
With that said, I don't think it's a bad practice to have the option to have a "row header" style but that does require additional work (design specs) and could be done as part of a separate issue IMO

No Stale.  We might have someone on our team be able to help with this but not sure when.


Add make presubmit to keep auto generated files in sync.

Right now it's very adhoc when the auto-generated files that are checked in get updated. We can add a make presubmit that force updates all the files before they are checked in.

From discussion with Jeremy:
He's fixing protos now, but will let the install yaml drift.
If the yaml files change in incompatible ways, then the install would break.
It's not possible to have the the install yaml files reference the current build because they would need to include

From discussion with Jeremy:
He's fixing protos now, but will let the install yaml drift for the moment.
If the yaml files change in a way which is incompatible with the referenced versioned image, then the install would break.  It's not good to have things be broken all the time.
It's not possible to have the the install yaml files reference the current build because they would need to reference the commit hash which includes a hash of itself.  Plus we don't want that file to change every single commit.
Jeremy proposed having the install/yaml reference a recent unstable build, but then things will still break on head for short periods of time, and checking out an old commit will be broken often.
I propose that we remove support for using the install yaml files on the development branch.  They are the easiest way to do things, so we want to continue having them for the release.  We can consider releasing them as release artifacts (like you would with a binary on github).  However I think they should be removed from the git repository.


Inline external project methods not inlining

I have 2 project, one which contains my application and one which contains common code.
I’m having problems with the following code (which is in the application project):
let inline publishMessage settings (message: 'a) =
    let queueName = typeof<'a>.FullName
    let username = settings.UserName
    ignore()

[<EntryPoint>]
let main argv =

    let settings =
        { UserName = "guest"
          Password = "guest"
          HostName = "localhost"
          ExchangeName = "Test1" }

    publishMessage settings { Body = "Hello" }
    RabbitQueue.publishMessage settings { Body = "Hello" }

RabbitQueue.publishMessage is the same as publishMessage but in the common project
It seems that RabbitQueue.publishMessage isn’t inlining like publishMessage is:
var settings, queueName, username;
return settings = new _RabbitQueue.QueueSettings("guest", "guest", "localhost", "Test1"),
(queueName = "RabbitQueue.Message1", username = settings.UserName, null),
(0, _RabbitQueue.publishMessage)(settings, new _RabbitQueue.Message1("Hello")),
0;

True, I didn't foresee this problem :( It could be possible to inline external methods too but then we have to parse the whole external project and in some cases this may really slow down the compilation.
The easiest solution would be to compile the public inline functions like normal methods so they can be called as usual from external projects (when called internally they will still be inlined). Would this solution be acceptable to you?

I'm not 100% sure what you mean - if I removed the inline I get the following from fable:
Cannot reference unknown type. If this a generic argument, try to make function inline

Ok, so you're referencing a generic type in RabbitQueue.publishMessage. This is gonna be tricky :) Would it be possible to post the code of RabbitQueue.publishMessage here? Or do you have a link for your project?

Sure, it's very rough - RabbitQueue.fs.txt

Yeah, this is complicated. As generic information is lost in runtime, the only way to do something like typeof<'a>.FullName is inlining the function in compile time, but unfortunately (right now) this is not possible across projects :( Is this a stopper for you? Can you refactor the code (for example, sending the type name as a string to RabbitQueue.publishMessage)?

Unfortunately this is going to be difficult to fix. I tried to apply the "easy" solution explained above, but then trying to use typeof<'T> with generics would fail even for internal inline functions. So right now I just improved the error message (it will warn you if you're trying to access an inline function of an external project).
If you can think of another way to fix the problem please feel free to reopen the issue.

How are the inline functions in F# Core handled i.e. in prim-types.fs?

Inlining in the F# compiler has two functions: statically resolved generic parameters and performance, however it seems it's not recommended to use inline only for performance. The AST provided by the compiler and used by Fable doesn't inline functions alone, Fable has to do it on its own.

@alfonsogarciacaro Using inline for performance is ok.  It's just that some people tend to over-use it, splattering it everywhere.
We could in theory provide some apparatus to help with separate compilation and "inline".  I suppose the idea would be to give a way to get and save the table of "inline" expressions at the end of a compilation (basically the optdata resource), and then give a way to resurrect and specialize those.  But it's quite a big big job, so dealing with it in Fable makes sense for now.

Thanks a lot for the explanation, @dsyme! I don't think we need the F# AST to inline functions at the moment, my main purpose when adding this feature, rather than performance, was to be able to resolve generic types at compile time (as in runtime they're erased) and allow things like typeof<T>` in some scenarios like the React Helper. But in cases like the one @davidtme revealed with cross projects references it gets complicated.
I'll also take the chance to confirm one thing: my understanding is that the AST provided by the compiler is always as is, and is not modified by passing options like --optimize[+|-]. Is that correct?
There are still many parts of the F# compiler I don't know well and that's why I really appreciate the F# Technology Creator Workshop you and Tomas are organising. I'm really sure it will help a lot make Fable better!

I'll also take the chance to confirm one thing: my understanding is that the AST provided by
the compiler is always as is, and is not modified by passing options like --optimize[+|-]. Is that
correct?

That's correct.  (Though if we provided the "inline" expressions then I believe that as things currently stand they would be optimized.)


Stable Marriage Problem

💥 Proposal
The Stable Marriage Problem states that given N men and N women, where each person has ranked all members of the opposite sex in order of preference, marry the men and women together such that there are no two people of the opposite sex who would both rather have each other than their current partners. If there are no such people, all the marriages are “stable”
Have you read the Contributing Guidelines on Pull Requests?
Yes

I would like to work in C and C++ languages. Kindly assign it to me.

I would like to work in python.

I want to do this in java

I have assigned the issue . Have a great day


I  need  help，I meet a markdown grammar problem

when I use react-markdown  library, I  meet  a markdown  grammar  problem.
I use ordered list and  unordered list  in  my  code,the  corrected display should  be look  like  this,

but  when   I  use    it，the markdown's  render  is  wrong,  it  looks  like below,

In my  project，my   packjson   is  below:

I  try my  best  to   solve  this  problem get through  some solutions,but  i have  failed,could   anyone  help  me?

@SkyWongHZ can you share a runnable example of the issue?

Trying the content
* test
* test
* test
1. test
2. test

in the demo site https://rexxars.github.io/react-markdown
produces the correct result

My guess is that you may have CSS that is hiding the list item markers.
But it's hard to tell without a runnable example of the issue.


Correct reference to jekyll-sitemap plugin in base config

Fixes #5859.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4390ba2d414e5871843f9afd9db7d21a516e3978/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4390ba2d414e5871843f9afd9db7d21a516e3978/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c8d118364de0b42f1dd9b12acedf921a70d47c06/


auto format repo

Somewhat unrelated: do you know why the test workflow fails on the first run? Quite tedious to have to re-run the test upon every PR.  Otherwise lgtm!

Somewhat unrelated: do you know why the test workflow fails on the first run? Quite tedious to have to re-run the test upon every PR. Otherwise lgtm!

i did not realize that was a thing. i can look into it, since i got a big into the weeds here anyway


Bug: Internel Server Error if logging_config.json is not present

Reproduction:
$ rm logging_config.json
$ curl localhost:8080
Internal Server Error%

This bug was introduced by 9a3ba526280299705a7ca31614506544c8867406.


Update version to 0.2.0

Update package.json
Remove deprecated methods

I think to remove deprecated methods you need a major version change. So maybe make it 1?

Not for major version 0. According to semver:
“Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.”


[Feature request] context menu

Add "Open with Notepads" in context menu.

Do you means add the context menu in explorer? But I can not find how to do it

Basically you can write a simple registry batch file to associate few file extensions to hook up with an command. And for that command, it can be windows protocol like <notepads %filepath%>

@JasonStein Do you means we should give a batch file to do it?

Yeah. UWP (without bridge) can not access registry. So batch file is the solution for average user.

How about this code:
    <uap3:Extension Category="windows.fileTypeAssociation">
      <uap3:FileTypeAssociation Name="lindexi">
        <uap:SupportedFileTypes>
          <uap:FileType ContentType="foo/foo">.x</uap:FileType>
        </uap:SupportedFileTypes>
          <uap2:SupportedVerbs>
              <uap3:Verb Id="doubi">逗比</uap3:Verb>
              <uap3:Verb Id="Print">林德熙是逗比</uap3:Verb>
          </uap2:SupportedVerbs>
        <uap:DisplayName>林德熙逗比</uap:DisplayName>
        <uap:EditFlags OpenIsSafe="true"/>
      </uap3:FileTypeAssociation>
    </uap3:Extension>

@lindexi  This is for certain type/extension of files right? This is not a global command forwarder to trigger something like: Notepads %selectedFilePath%

@JasonStein Yeah and it only support the extension that define in <uap:FileType ContentType="foo/foo">.x</uap:FileType>.
鉴于我的英文翻译太渣，还是说中文。 只有在 <uap:FileType ContentType="foo/foo">.x</uap:FileType> 里面定义的类型，并且点击打开方式选择了这个应用程序时，这个右键菜单才能生效。也许官方的期望是作为一个简便的入口，看了官方的例子是作为打开和打印等的菜单入口
换句话说，这个菜单不能用来所有的文件上，应该现在只有通过写注册表才能做到

Tbh, I don't understand how that would be useful, there's already "open in" menu from which you can select Notepads. If you want to avoid that just set it as default app. I like Desktop Bridge in general, but implementing for this purpose would make no sense

Tbh, I don't understand how that would be useful, there's already "open with" menu from which you can select Notepads. If you want to avoid that just set it as default app. I like Desktop Bridge in general, but implementing for this purpose would make no sense

This would be useful (if it worked for all file types) for extensions that Notepads do not advertise as supported - right now you can't use "Open with" menu for them (or at least I didn't find any way to make it work).

Not sure if I'm breaking a rule, but just want to chip in in favor of these feature since Notepad++ has it and I really miss it.
The feature is optional and can be enabled through the installer. It adds a global menu "Edit with Notepad++" as a Shell Extension of windows.
This is super useful, because I don't want to associate any file extensions to notepad++ (pretty much the same as regular Notepad), and in some cases it would be wrong to do that, for example if I want to open a file associated to another application, like html, css, js, etc.
Open With is a workaround, but it's really a hassle to go through the "Open With", looking for Notepads in the browser and finally opening the file.
There is also another useful thing to this feature, and it's to open a lot of files at once. You just select all the files, right click and select "Edit with Notepad++"
Here is a screenshot:


progress method is not called for Imagine

the code that reproduces this issue or a replay of the bug
const mjClient = new Midjourney({
ServerId: process.env.MJ_SERVER_ID,
ChannelId: process.env.MJ_CHANNEL_ID,
SalaiToken: process.env.MJ_SALAI_TOKEN ?? "",
Ws: true
})
await mjClient.init()
await mjClient.Imagine("Example prompt", (uri, progress) => {
console.log("progress called")
console.log(uri, progress)
})
Describe the bug
Describe the bug
A clear and concise description of what the bug is.
The progress callback function passed to Imagine is never called. No log messages appear with the above example.
Expected behavior
A clear and concise description of what you expected to happen.
Progress function should be called. uri and progress strings logged to the console using the example code given.
Screenshots
If applicable, add screenshots to help explain your problem.
error log
🎊 ws ready!!! Hi: null

Good day. I encountered the same problem. Tell me, did you solve it somehow? Are there any workarounds?

Good day. I encountered the same problem. Tell me, did you solve it somehow? Are there any workarounds?

mjclient.wsClient.onSystem("messageUpdate",(msg)=>{
this.messagefilter( msg );
});
if( msg.type == 20 && msg.content )
{
let mtxt = msg.content;
let perpos = mtxt.lastIndexOf('%)');
if( perpos > 0 )
{
let perposb = mtxt.indexOf('(', perpos - 4);
let progress = mtxt.substring( perposb + 1,perpos);
progress = tools.getInt( progress );

mjclient.wsClient.onSystem("messageUpdate",(msg)=>{ this.messagefilter( msg ); }); if( msg.type == 20 && msg.content ) { let mtxt = msg.content; let perpos = mtxt.lastIndexOf('%)'); if( perpos > 0 ) { let perposb = mtxt.indexOf('(', perpos - 4); let progress = mtxt.substring( perposb + 1,perpos); progress = tools.getInt( progress );

Oh, thanks! Honestly, I've already started rewriting the library for myself)


Allow Patching Array of Bytes

Allows patch(addr, [array of bytes]);.
Also some minor fixes.

I like this PR.  Once the conflicts are resolved I'll merge it right away.


Imports have extra quotes

In the output object, imports have quotes included. Not sure this is expected or desired behavior. Probably want to get rid of the quotes.
        "imports": [
            "\"bango\"",
            "\"bingo\""
        ],

Closed by #8.


The entrypoint.sh overrides any customization or nginx configuration that is made on stop/start

https://github.com/Accenture/adop-nginx/blob/8fec90cbe680685c2aa5321a2b97903c8748042b/resources/scripts/entrypoint.sh#L4-L5

I'm not really sure why this is an issue. It is specifically designed to do this so that regardless of whether a volume is used or not the correct configuration is put in place - eventually it might be tokenised.
If customisation is required then I suggest either overriding the main file in the container, or baking your own image that includes whatever configuration you desire.

Hi @nickdgriffin,
Thanks for reacting quick on this.
It's kind of a concept issue IMHO. Usually everything that is immutable is placed in the container itself, while state/data is placed outside. It is not expected, we expose release notes to the volume - so it's expected you can change it (otherwise, what's the reason to expose the volume?). If consistency is the key - the volume should be removed to not confuse a user (because in other containers you can change data in the volume)
About the second point, it's of course possible to bake your own image and customize it in a way you want, but it's a forcing customization action. Why should I create a new image, think about having a registry to put that image (or build it locally) if it is possible logically just to change the static content.
Also, overriding main file - can be the case, but do it just to fix configuration or add an extra route it's kind-a excessive.
Is this a good reasoning/thinking about?

The reason the configuration and release note are in the volume is because they can reference stuff that isn't baked in - the Nginx config has an "include" and the release note reads a "bp" folder.
For the Nginx configuration I'd like to restructure it one day to have more "include" statements that provide more flexibility to add locations under the main domain or to add additional domains, but it still mean that the main files from the image are copied into the volume on start by the entrypoint.

@nickdgriffin I realize it is made for easy deployments of ADOP, but it breaks normal way of working with containers: as @svscorp mentioned already - core installation is part of Dockerfile, everything else is added via environment variables and volumes. I was working on https support for nginx and hit the same problem - my config was overridden. Then I made a template as you did with nginx.conf and it works now, but it's ugly.
And in general this way of setting things up adds to one of core adop design problems in my opinion - everything is too tightly integrated and it's quite hard to change something. I wanted to add ldaps support for all containers to integrate ADOP with enterprise ldap and it's quite hard even to run a single ADOP container standalone, because it wasn't designed for that.

@mlushpenko I consider it quite normal to extend a container with your own customisation - ultimately we'd like the Nginx configuration to be more flexible but there will always be an element of something being within the image that someone will want to override at some point. Forking the repository and having it build in Docker Hub with your own customisations doesn't require too much work I don't think.
I agree there is work to do to decouple some of the components but like you said it wasn't designed for that (initially) - that doesn't mean there isn't room for improvement. There will always be an aspect of coupling though seeing as that is the point of the platform - to provide an integrated set of tools.

@nickdgriffin sure, we just want to contribute back to make the platform more robust. As part of this initiative, I created a pull request and was hoping somebody could review it, so the work doesn't end up just in my dockerhub, but becomes part of the core platform
https://github.com/Accenture/adop-nginx/pull/41

@nickdgriffin
"release note reads a bp folder" - that doesn't help it just adds below area for links... but when I want to customize a css I have to create our own image. My concern is that why are we forcing someone who just want to put a small customization on the main page to create image -> that also forces to have a Docker registry (private).
To not create too much discussion I want to understand, can we change this or this topic should be closed as it won't change? I can do what is required and PR that.
What's about exposing one more volume with "/resources" folder to be able to overwrite/customize what is coming up with every container run? Or what's about adding an include of "custom.css" next to the main css file to be able at least to change colors.
Or, what's about adding a flag into entrypont.sh that will accept a variable to either overwrite or persist the volume?
I am looking about any opportunity to have flexibility. Rebuilding image every time I doing change to static content - it's not cool. I understand it needs to be done if we would have a web application in the container - it is a deliverable.

I'm open to it changing as long as the "out of the box" configuration and release note are immutable inside the image - they can be changed though to be more supportive of custom configuration, but when the container is restarted I expect the copy in the volume to be replaced with the image version. If there was an option to totally override the config location or "switch off" the copy then that'd be fine too, but the default behaviour should be how it is now.
In the future the config might be either dynamically generated or templated in some form, neither of which will allow customisations unless "handles" are put into the config (like expecting config in certain places, or certain file names being allowed).
If someone wants to change the "core" parts of the image they should create their own image - it doesn't require a private registry unless the changes cannot be open sourced, as hub.docker.io can be used to build and publish the image from the forked repository.

@nickdgriffin
Can we restart the discussion on this topic? In short, I suggest to copy both configuration and html to their folders once in Dockerfile. Then with 2 ENV variables CUSTOM_CONFIG and CUSTOM_HTML that are false by default control the behavior.
Everyone is happy. On one side by default (in adop-docker-compose) this variables won't be given, so data persistence will be enforced on every container start. If someone want's to customize - there will be an easy way to do that, without going for new image creation + at least whole entrypoint.sh will be copied for 2 lines change.
Let me build and PR that.

Yeah that approach sounds sensible to me.

It is also a way to do that in #36 but not sure it's better.


[WIP] PyTorch 2.0 and torch.compile support

I'm looking into supporting PyTorch >=2.0 to see if the new compiler has any potential speedups - I've found what I think is the root cause of the bug preventing previous upgrade attempts and am seeking advice on the right fix.
A naive upgrade leads to the same inf checking error in #1610. I believe I've narrowed down the bug to this line in ray_samplers.py, where after the tenth step, pytorch will no longer calculate gradients for the proposal networks, leading to the error.
My current commit here avoids the error and continues to train by changing self._steps_since_update > self.update_sched(self._step) to self._steps_since_update >= self.update_sched(self._step) - for the example nerfacto poster command, this clause formerly always resolved to false (1 < 1). I don't know enough about pytorch's inf checks, why the updated flag is the way it currently is in ray_samplers.py, or why upgrading to 2.0 broke this line's usefulness to know if this is a proper solution, however I think it's a start if anyone would like to contribute.

There is another problem with PyTorch 2.0 #1883

There is also work being done in https://github.com/nerfstudio-project/nerfstudio/pull/1922

The reason why it was broken after upgrading to torch 2.0 is the following:
In the nerfacto model the proposal network does not get updated every training step. It gets updated first 10 steps and then it is driven by a schedule. Changing the strictness of the equality check caused to be updated every iteration - which is wrong. But that was the reason why your code was working in torch 2.0.
The way the proposal network gets updated / or doesn't get updated is done by enabling/disabling gradients to flow through it. Unfortunately, grad-scaler is called on all the optimizers (including the one handling the proposal network) without checking if the gradients were computed. This worked fine in torch 1.13, but doesn't in 2.0. The reason is this:
https://github.com/pytorch/pytorch/pull/92731
... in torch 2.0 grads are reset to None instead of zeros to save memory (which is a breaking change).
In the alternative PR: #1922 the problem is fixed by  skipping grad_scaler.step for optimizers for which the grads weren't computed.
#1922 (for now) provides a compatibility with previous torch and addresses the same problem as this PR (except it does not include model.compile).
I suggest we close this PR?

Completer in #1922


WIP: Client API implementation

Huge feature list here and apologies for the PR bomb.

New Interface type defined for client interaction with a repository (client/interface.go)
GRPC implementation of the new interface (client_api/api/*)
CLI integration with GRPC API if configured (cmd/notary/repo_factory.go and other necessary knock on changes in the cmd/notary package)
JWT token auth for the GRPC API consistent with Notary Server and Docker Registry (auth/*). Some of this is to be upstreamed into docker/distribution when I get the chance.

If enabled "push" and "pull" actions will always be requested to guarantee the Client API can communicate with the upstream Notary Server to read repos and publish updates. The server configuration will also accept a map of GRPC Endpoint Name : [permissions] (documentation to be written) that allows users to arbitrarily configure in more permissions per GRPC API. Users would need their token server to issue those permissions as appropriate to their users.

Still needed:

more tests
documentation

Shout out to @n4ss for all the hard work on this. Go get some sleep!
cc @ecordell @lewiada

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "client_api" git@github.com:docker/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354407192
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Superseded by #1139


UI: Inject  into HTML configured via ENV var

As discussed in https://github.com/openzipkin/zipkin/issues/1731.
In situations where we run behind a reverse proxy with limited configurability (like the nginx ingress of Kubernetes), we can't rely on the reverse proxy injecting the required <base> tag to make the UI work on whatever URL path prefix it's assigned. The cleanest solution would be adding support to the Spring application serving the UI for adding the tag based on the presence and value of an ENV var.
I propose we call that ENV var ZIPKIN_UI_BASEPATH. Via @wdittmer, other applications all have custom names for it, there doesn't appear to be a standard:

For example, for Prometheus we need to configure:

'--web.external-url=http://management.test.cbo:13370/prometheus'
'--web.route-prefix=/'

For Grafana:

name: GF_SERVER_ROOT_URL
value: /grafana

For Kibana:

name: SERVER_BASEPATH
value: "/kibana"

Works for me. If we do, we should update the webpack files to use the same
nomenclature or even have a comment with the variable chosen. That way grep
based troubleshooting is easier
https://github.com/openzipkin/zipkin/blob/master/zipkin-ui/webpack.config.js
On 25 Feb 2018 3:39 pm, "Zoltán Nagy"<EMAIL_ADDRESS>wrote:

As discussed in #1731 https://github.com/openzipkin/zipkin/issues/1731.
In situations where we run behind a reverse proxy with limited
configurability (like the nginx ingress of Kubernetes), we can't rely on
the reverse proxy injecting the required  tag to make the UI work
on whatever URL path prefix it's assigned. The cleanest solution would be
adding support to the Spring application serving the UI for adding the tag
based on the presence and value of an ENV var.
I propose we call that ENV var ZIPKIN_UI_BASEPATH. Via @wdittmer
https://github.com/wdittmer, other applications all have custom names
for it, there doesn't appear to be a standard:
For example, for Prometheus we need to configure:

'--web.external-url=http://management.test.cbo:13370/prometheus'
'--web.route-prefix=/'

For Grafana:

name: GF_SERVER_ROOT_URL
value: /grafana

For Kibana:

name: SERVER_BASEPATH
value: "/kibana"

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/1930, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61wZcciuaWUB49auCLKIpWNqpKRlRks5tYQ4-gaJpZM4SSM9S
.

Hey, how is it going with this?

Umm... Moderately well :D It's on my list of things to do, definitely on top of my Zipkin things to do. I'm hoping to get a (first?) implementation done this weekend.

Oh wow. I thought this'd be a quick Google search, adopting things a bit for the specifics of our case, open PR, all good. Nope, changing HTML is apparently not simple.
My first approach was extending the config.json we generate, and injecting the <base> tag from JS. The server side is clean, adding a new config value is trivial. BUT: of course the JS that'd load config.json won't know where to load the file from, because the <base> tag is not set. 🐔 and 🥚 , you see.
My second approach was to do exactly what was originally described: rewrite the HTML content. Apparently "the way" to do that is with ServletFilters, which... I tried to do, got something that might work, but I don't see how I'd inject the new filter from the context of the autoconfigured Spring application. Sounds like a horrible idea anyway.
Is the "right" way to just ... change https://github.com/openzipkin/zipkin/blob/master/zipkin-autoconfigure/ui/src/main/java/zipkin/autoconfigure/ui/ZipkinUiAutoConfiguration.java#L118 into a method returning ResponseEntity<String>, read the HTML file like a peasant, and do the HTML parsing / mutation, then pass a string to the ResponseEntity?

if all that needs to change is index.html I'd be inclined to solve it that way

I upgraded tot openzipkin/zipkin:2.5.3 and added
- name: ZIPKIN_UI_BASEPATH
value: "/zipkin/zipkin"
to the deployment yaml and I have a working UI via the bastion via reverse proxy 👍
Thanks all!

A bit more information about the deployment:
We have a AWS VPC in which an EC2 instance runs that functions as the bastion service, to which we can setup our SSH tunnel. Then we have EC2 instance(s) with a kubernetes cluster. One of the pods is an nginx-ingress pod that reverse proxies the services in the cluster for multiple namespaces. One of the services is Zipkin in the monitoring namespace.
The ingress-nginx configuration:
kind: Ingress
metadata:
  name: cbo-ingress-mgmt-elb
  labels:
    app: ingressservice-mgmt-elb
  annotations:
    kubernetes.io/ingress.class: "nginx"
    nginx.ingress.kubernetes.io/rewrite-target: "/"
    nginx.ingress.kubernetes.io/ssl-redirect: "false"
spec:
  rules:
  - host: management.test.cbo
    http:
      paths:
      - backend:
          serviceName: authentication-service
          servicePort: 8210
        path: /authentication
      - backend:
          serviceName: authorization-service
          servicePort: 8160
        path: /authorization
      - backend:
          serviceName: configuration-service
          servicePort: 8110
        path: /configuration

---

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: cbo-ingress-mgmt-elb
  namespace: monitoring
  labels:
    app: ingressservice-mgmt-elb
  annotations:
    kubernetes.io/ingress.class: "nginx"
    nginx.ingress.kubernetes.io/rewrite-target: "/"
    nginx.ingress.kubernetes.io/ssl-redirect: "false"
spec:
  rules:
  - host: management.test.cbo
    http:
      paths:
      - backend:
          serviceName: alertmanager
          servicePort: 9093
        path: /alertmanager
      - backend:
          serviceName: elasticsearch-proxy
          servicePort: 9200
        path: /elasticsearch
      - backend:
          serviceName: grafana
          servicePort: 3000
        path: /grafana
      - backend:
          serviceName: kibana
          servicePort: 5601
        path: /kibana
      - backend:
          serviceName: prometheus-monitoring
          servicePort: 9090
        path: /prometheus
      - backend:
          serviceName: zipkin-service
          servicePort: 9411
        path: /zipkin

And the Zipkin configuration:
apiVersion: v1
kind: Service
metadata:
  namespace: monitoring
  name: zipkin-service
spec:
  ports:
    - port: 9411
  selector:
    app: zipkin

---

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  namespace: monitoring
  name: zipkin
spec:
  replicas: 1
  selector:
    matchLabels:
      app: zipkin
  template:
    metadata:
      labels:
        app: zipkin
    spec:
      containers:
      - name: zipkin
        image: openzipkin/zipkin:2.5.3
        env:
         - name: STORAGE_TYPE
           value: elasticsearch
         - name: ES_HOSTS
           value: http://elasticsearch-proxy:9200
         - name: ES_DATE_SEPARATOR
           value: .
         - name: ZIPKIN_UI_BASEPATH
           value: "/zipkin/zipkin"

The separate configurations result in one concatenated nginx.conf file.
The crucial thing is that we cannot change nginx.ingress.kubernetes.io/rewrite-target: "/" which is applied to all backends.
Now that this issue has been fixed it works.
If we set up the SSH tunnel with the bastion now, and curl to /zipkin, we get:
$ curl -vvv -L http://management.test.cbo:13370/zipkin
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to management.test.cbo (<IP_ADDRESS>) port 13370 (#0)
> GET /zipkin HTTP/1.1
> Host: management.test.cbo:13370
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 302 Found
< Date: Thu, 15 Mar 2018 10:32:57 GMT
< Location: ./zipkin/
< Server: nginx/1.13.8
< vary: origin
< X-Application-Context: zipkin-server:shared:9411
< Content-Length: 0
< Connection: keep-alive
<
* Connection #0 to host management.test.cbo left intact
* Issue another request to this URL: 'http://management.test.cbo:13370/zipkin/'
* Found bundle for host management.test.cbo: 0x7fdb19c21450 [can pipeline]
* Re-using existing connection! (#0) with host management.test.cbo
* Connected to management.test.cbo (<IP_ADDRESS>) port 13370 (#0)
> GET /zipkin/ HTTP/1.1
> Host: management.test.cbo:13370
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 302 Found
< Date: Thu, 15 Mar 2018 10:32:57 GMT
< Location: ./zipkin/
< Server: nginx/1.13.8
< vary: origin
< X-Application-Context: zipkin-server:shared:9411
< Content-Length: 0
< Connection: keep-alive
<
* Connection #0 to host management.test.cbo left intact
* Issue another request to this URL: 'http://management.test.cbo:13370/zipkin/zipkin/'
* Found bundle for host management.test.cbo: 0x7fdb19c21450 [can pipeline]
* Re-using existing connection! (#0) with host management.test.cbo
* Connected to management.test.cbo (<IP_ADDRESS>) port 13370 (#0)
> GET /zipkin/zipkin/ HTTP/1.1
> Host: management.test.cbo:13370
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Cache-Control: max-age=60
< Content-Language: en-
< Content-Type: text/html; charset=UTF-8
< Date: Thu, 15 Mar 2018 10:32:57 GMT
< Server: nginx/1.13.8
< vary: origin
< X-Application-Context: zipkin-server:shared:9411
< Content-Length: 1041
< Connection: keep-alive
<
<!doctype html>

  <base href="/zipkin/zipkin/">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
  <meta charset="UTF-8">
  <title>Webpack App</title>
  <link href="app-8d2758e7891a9863b124.min.css" rel="stylesheet">

      ZipkinInvestigate system behavior

* Connection #0 to host management.test.cbo left intact
```


XML results

Question
Hello, I have a question, is there a way to get comparison results as XML?, thanks

I'm afraid this is not possible right now. We would need to configure different reporters. The only one provided is HTML. I hope this is the answer to your question.


Resource protection should be deep, not shallow

This change addresses a concurrency problem, when two distinct threads
processing the same non-object template ended up modifying the same
HashResource object simultaneously, leading to TreeMap corruption, which
manifested itself as NullPointerException or compiler hang. The trigger
was a foreach() loop over a protected hash, which did not propagate
the protection down to the hash values; the stack trace leading for this
situation was:
 [panc] org.quattor.pan.dml.data.HashResource.put(HashResource.java:172)
 [panc] org.quattor.pan.dml.data.Resource.rput(Resource.java:131)
 [panc] org.quattor.pan.template.BuildContext.setLocalVariable(BuildContext.java:1298)
 [panc] org.quattor.pan.dml.operators.SetValue.execute(SetValue.java:170)
 [panc] org.quattor.pan.dml.operators.Assign.execute(Assign.java:65)
 [panc] org.quattor.pan.dml.operators.IfElse.execute(IfElse.java:109)
 [panc] org.quattor.pan.dml.DML.execute(DML.java:120)
 [panc] org.quattor.pan.dml.operators.Foreach.execute(Foreach.java:93)

Note there is a similar concurrency issue in
org.quattor.pan.type.RecordType.setDefaults(), which is not addressed by this
patch. So this patch addresses, but does not completely solve, issues #6
and #56.
There is a visible side effect of this patch. There is the following
bit of code in the standard template library:
variable DISK_VOLUME_PARAMS = {
  foreach (volume;params;DISK_VOLUME_PARAMS) {
    if ( (params['type'] == 'partition') &&
         (is_defined(DISK_PART_BY_DEV['changed_part_num'][params['device']])) ) {
      debug('Updating '+volume+' partition to new name/number: '+DISK_PART_BY_DEV['changed_part_num'][params['device']]);
      params['device'] = DISK_PART_BY_DEV['changed_part_num'][params['device']];
      params['final'] = true;
    };
  };
  SELF;
};

The code iterates over and changes DISK_VOLUME_PARAMS, and expects the
changes to be visible in SELF. After this patch the above code will no
longer work, because DISK_VOLUME_PARAMS inside the DML block will have
copy-on-write semantics, changing it will not alter SELF. The foreach()
loop in the above code needs to be re-written to refrence SELF instead
of DISK_VOLUME_PARAMS.

@gombasg i'm trying to make sense of this patch. so there is no actual thread-safety issue, this is a different problem in the sense that the protected resources were only shallow protected. in principle, even single threaded panc runs could trigger this, but we were just very lucky that the protected resources were always updated with the same data? (and threading can cause a corrupted resource, leading to "wrong" data or crash; rather than 2 threads updating with different data and leading to wriong profile data)
i'm just surprised that the fix didn't involve any concurrency/thread-safety fixes, that's all.

We are beginning to use this patch in production. What is remaining for this to be merged to master?


fix typo challange -> challenge

Looks like a good change to me. It's a breaking change though, since it's protected folks might be relying on the option to override the method (with the misspelled name).
We should either add back the misspelled ones (just as a facade for the new method) with a deprecation notice, or just note this as a breaking change in a major release.

you're right; we'd have to bump the version nr.

I'm quite conservative when it comes to breaking changes. We have 40K+ weekly downloads.
We could add a new method delegating to the old one.


Circular dependency - help wanted

With catalog and nested elements definition we have circular dependency:
catalog -> dcat:service -> dcat:servesDataset -> Distribution -> dcat:accessService (DataService) -> servesDataset -> ....
catalog -> dataService -> dataset -> distribution -> dataService -> dataset -> distribution -> dataService -> dataset ->...
When implementing this in java, and serializing it to json Infinite recursion occurs.
Is this some flaw in design, should this "chain" be split somewhere? Maybe dataService.servesDataset to have ref to dataset instead whole dataset object.
Idea is to use JsonMapper object to serialize java to json string.

From specification:
https://docs.internationaldataspaces.org/ids-knowledgebase/v/dataspace-protocol/catalog/catalog.protocol
dcat:servesDataset
Note that the property dcat:servesDataset should be omitted from the DataService since Datasets are included as top-level entries. Clients are not required to process the contents of dcat:servesDataset.
This is not aligned with json schema classes, so this should be corrected, which could be addressed in future protocol improvements/visions.


Fix: ReferenceError

return the whole profile as the error passed to done and not json which is not defined and caused a ReferenceError in the catch

I was able to workaround this by setting skipUserProfile: true. This might not be addressing this issue but sharing nonetheless.

Hey look a 2 year old unmerged bug fix 🙅♂


output each joint depth

Is your method able to ouput each joint's depth, both from the camera view and world view, and how? Thank you.

@sunmengnan There is another repo (not mine) called RootNet, you can use this to predict joints' depth in world view


Change bCash image and referrals for PayU

Change image, url and references in the request from bCash to PayU

Done


Loading page

Loading page of the website is not aligned.

I want to take on the challenge of resolving the loading page alignment.
Kindly assign me this issue.

Loading page taking too much time to load, and also have some file location issues.
I request you to assign this task to me as part of GSSOC'24 .
Looking forward for your reply❤.

Loading page taking too much time to load, and also have some file location issues.
I request you to assign this task to me as part of GSSOC'24 .
i have 3+ years of web dev and devops experience
Looking forward for your reply❤.

I am ready to address the issue related to the loading problem on page #313. Please assign this task to me for resolution. Thank you.

Sorry to close this issue.
But I want you all to raise the issue using the templates to make it more clearer. & I will then assign you the issue.
Thanks to all


Azure.Core.Management standardization for exception, base classes across languages

Opening tracking item for standardization effort. Depending on the outcome, changes needs to be made:

in ClientDiagnostics to populate extra mgmt exception fields into Data OR create explicit ARM exception (ManagementException)
Consolidate swagger base class identification and dedup and snap to base classes such as Resources, TrackedResources etc.

Hey @allenjzhang - Is this still a thing?