Development Outline

What?
This project is a back-bone outline for the technical, marketing, and business development of GridCoin.  It is a collection of all resources regarding operation, development, and marketing.  It is the first stop for GridCoin community members looking to get involved in the development of GridCoin.  It links to other branches of development as they are created.  Read it over and please volunteer your thoughts on the project and contribute as you see fit; the last section is a section on contribution and bounty.
Why?
We have many projects, resources, roadmaps, and plans, but no primary structure on which to gather.  We need to create together an agreed upon outline and timeline for the short and long-term development of GRC.
How?
I have combed through many forums, seemits, reddits, githubs, and as many sources I could find and gathered what I found into this project.  I then created a structure containing what I felt are major and achievable short-term goals for GRC.  There are more resources and more ideas out there, so please read the contribute section for a loose format on how to submit additions and changes.  Everything in this outline is up for discussion and nothing in this outline is permanent – it is simply a starting point.
Who?
Hi.  I have been a user of GRC and BOINC for a little over 3 years now.  This is the first time I have felt I can actively contribute to its development – my background and skillset is in marketing, business, and communication.  I will be maintaining this on my free time for as long as I see active contribution to the technical development of GridCoin; the recent Wallet UI upgrade was a huge factor in my decision to get involved with the development side of GRC.  This is also my first time contributing to a GitHub, so thanks GRC community =).
https://pastebin.com/phdNQnhb

Would the multiple 'threads' not be more appropriate on cryptocointalk or the gridcoin-tasks repo?

Sure.  Theres so many different forums/repos -- I wasn't sure where to put everything.  If keeping them on gridcoin-tasks is more appropriate I'll move the threads over to there.  Should the main outline stay here?

Found a resource for wallet terms.  Will add to the next version (probably uploading on Monday)
http://grcnation.com/en/gridcoin-short-glossary/

Could you post the document's contents rather than linking to an external file please? Thanks.

i'm restructuring it -- will post contents once updated

Copy of the pastebin, in case it expires.
GridCoin Development Outline
	Updated: 6/14/17

Contents
Setup Tutorial Media
General Audience White Paper
Technical White Paper
Development Resources
Projects/Issues/Discussions
Detailed Technical Timeline
Detailed Marketing/Business Timeline
Detailed Setup Tutorial Media Timeline
Detailed General Audience Whitepaper Timeline
Resources
Contribute

1.	Setup Tutorial Media
Issue 119
Issue 114

	a.	INTRO: Get GRC wallet and BOINC client set up and synched and begin working on Asteroids (or some other project we know will be around for years... seti, etc) – Describe how and when GRC is rewarded
		i.	Video
		ii.	Text
	b.	USER LEVEL: PoS - How to change projects - BOINC settings - Terminology (CPID, Beacon, RAC, WU, DPOR, Weight, Magnitude, Difficulty (basic concept), [...]) - The Do's and Don'ts
		i.	Video
		ii.	Text
	c.	COMMUNITY LEVEL: Voting - Creating BOINC project - Console commands – How to contribute
		i.	Video
		ii.	text

2.	General Audience White Paper

	a.	https://pastebin.com/PAx4h6Nm
		i.	Blockchain Basics
			1.	PoW
			2.	PoS
			3.	DPoR introduction
		ii.	BOINC
			1.	History
			2.	Projects
			3.	Results
			4.	Terms
		iii.	Gridcoin
			1.	History
			2.	DPoR
			3.	Superblocks – Connection with BOINC
			4.	Rewards
			5.	Operation and Development

3.	Technical White Paper

	a.	Intentions and reasons for GRC protocols and reward schedule

4.	Development Resources

	a.	Community
		i.	http://gridcoin.us/
		ii.	https://steemit.com/created/gridcoin
		iii.	https://www.reddit.com/r/gridcoin/
		iv.	https://cryptocurrencytalk.com/forum/464-gridcoin-grc/
		v.	https://twitter.com/GridcoinNetwork
	b.	General Developments and Tasks
		i.	https://github.com/gridcoin/Gridcoin-Research/issues
		ii.	https://github.com/Erkan-Yilmaz/Gridcoin-tasks
		iii.	https://github.com/Erkan-Yilmaz/Gridcoin-tasks/issues
		iv.	https://github.com/grctest/Gridcoin-Site
	c.	General Roadmap
		i.	https://www.tiki-toki.com/timeline/entry/759095/Gridcoin-Roadmap/
		ii.	https://steemit.com/gridcoin/@erkan/gridcoin-roadmap-2017-2019

5.	Projects/Issues/Discussions

	a.	In Development
		i.	UI Upgrades (Upgraded 6/5/17)
			1.	Issue 15
		ii.	Removing team requirements
			1.	Issue 94
			2.	Issue 212
		iii.	Marketing/Business development plan
			1.	Outreach Translation (Ensuring that media and outreach effectively translates technical details into general language or metaphor)
			2.	Outline
				a.	Text
				b.	Visual
			3.	General Audience White Paper (2)
			4.	Main Developer /whois Pages
			5.	Developer Outreach Plan
				a.	Issue 8
		iv.	[…]

	b.	Known Issues
		i.	Translations
			1.	Issue 111
		ii.	BOINC Security/Data retention
			1.	Issue 108
			2.	Issue 106
			3.	Issue 102
			4.	Issue 105
			5.	Issue 101
			6.	Issue 78
		iii.	Mobile Wallet
			1.	Issue 66
		iv.	Asset Wallets
			1.	Get GRC supported by online, distributed, and multi wallets.
			2.	Issue not yet created
		v.	Tutorial Series
			1.	Issue 119
			2.	Issue 114
		vi.	Access To GRC re: BOINC Stats
			1.	https://boincstats.com/en/stats/-1/team/detail/118094994/overview
			2.	https://boincstats.com/en/stats/-1/team/detail/118094994/overview
			3.	Issue 99
		vii.	[…]

c.	Active Discussions on the Development of GRC – Brainstorming
		i.	Project Mag Calculation
			1.	Issue 130
		ii.	Organize Events
			1.	Issue 127
			2.	Issue 123
		iii.	Contracts With GRC
			1.	Issue 125
		iv.	Bounty Distribution and Funding
			1.	Issue 133
		v.	BOINC on ps4
			1.	Issue 110
		vi.	[…]

6.	Detailed Technical Timeline

	a.	[…]

7.	Detailed Marketing/Business Timeline (5aiii) – Sept 1 2017

	a.	Marketing/Business Development Plan –2017
		i.	Outline –
			1.	Outline Text –
			2.	Outline Visual –
		ii.	General Audience White Paper – 2017
		iii.	Main Dev /Whois Pages – 2017
		iv.	Developer Outreach Plan – 2017

	b.	[…]

8.	Detailed Setup Tutorial Media Timeline (1) – 2017

	a.	Setup Tutorial Media – 2017
		i.	Intro –
			1.	Text –
			2.	Video –
		ii.	User –
			1.	Text –
			2.	Video –
		iii.	Community –
			1.	Text –
			2.	Video –

	b.	[…]

9.	Detailed General Audience White Paper Timeline (2) – November 1 2017

	i.	Blockchain Basics - jringo
		1.	PoW - jringo
		2.	PoS - jringo
		3.	DPoR introduction - jringo
	ii.	BOINC -
		1.	History -
		2.	Projects -
		3.	Results -
		4.	Terms -
	iii.	Gridcoin -
		1.	History -
		2.	DPoR -
		3.	Superblocks – Connection with BOINC -
		4.	Rewards -
		5.	Operation and Development -

10.	Resources
http://gridcoin.us/
https://steemit.com/created/gridcoin
https://www.reddit.com/r/gridcoin/
https://cryptocurrencytalk.com/forum/464-gridcoin-grc/
https://github.com/gridcoin/Gridcoin-Research/issues
https://github.com/Erkan-Yilmaz/Gridcoin-tasks
https://github.com/Erkan-Yilmaz/Gridcoin-tasks/issues
https://steemit.com/gridcoin/@erkan/gridcoin-roadmap-2017-2019
https://www.tiki-toki.com/timeline/entry/759095/Gridcoin-Roadmap/
https://boincstats.com/en/stats/-1/team/detail/118094994/charts
https://boincstats.com/en/stats/-1/team/detail/118094994/overview
https://gridcoinstats.eu/

11.	Contribute

a.	Comment suggestions/additions to this outline and I will update it accordingly.

b.	As projects and issues progress and evolve try to post updates in the comments.

c.	If you create a new thread for an issue, please post the issue link in the comments so I can update and consolidate the outline accordingly.

d.	Large text contributions will be edited by me so to maintain a consistent voice and structure.  Contributions will be referenced appropriately.

e.	Contributors – I will update this section with users, their contributions, and a wallet address should they chose to post one.  Donate at your leisure.  Personally, I will distribute a decent portion of the donations I receive to people that help complete and maintain this outline.   This, until a better process is found.  Issue 133

i.	Hovai - S9FbBsHt64NouiAWdHezDHVmwmSi3rkfHD
	1.	Principal Contributor – Structure Creation and Original Content [1]

Closing this issue. It is necro. This belongs either in milestoning, or a superarching issue in community tasks.


[refactor] #3934: Migrate iroha_wasm_derive and iroha_validator_derive to syn 2.0

Description
Use syn 2.0, manyhow and darling to enhance the error messages
Linked issue
Closes #3934
Checklist

[ ] make sure the CI passes
[ ] add tests?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
6238 unchanged lines in 108 files lost coverage.
Overall coverage decreased (-1.0%) to 58.44%

Files with Coverage Reduction
New Missed Lines
%

cli/src/main.rs
1
0.0%

cli/src/samples.rs
1
0.0%

cli/src/torii/pagination.rs
1
98.9%

config/base/src/runtime_upgrades.rs
1
51.72%

config/src/torii.rs
1
96.67%

core/src/smartcontracts/isi/block.rs
1
87.5%

crypto/src/merkle.rs
1
96.23%

data_model/src/domain.rs
1
47.37%

logger/src/lib.rs
1
95.15%

config/src/lib.rs
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.0%

Covered Lines:
21544

Relevant Lines:
36865

💛  - Coveralls

@DCNick3 , any plans to update this? Sorry for pressure, just having a lot of openned PRs makes me feel frustrated.
Also seems like something is wrong, because there are too many lines changed...

@DCNick3 , any plans to update this? Sorry for pressure, just having a lot of openned PRs makes me feel frustrated.
Also seems like something is wrong, because there are too many lines changed...

Yes, I am planning to get back to this after I finish the ursa replacement.
The "lots of line changed" probably comes from the history rewrite that happened not so long ago. Ig I'll hate to do some git-fu to make it point to the new commits

Also seems like something is wrong, because there are too many lines changed...

it's because we rewrote history to fix DCO

Read The Docs check should be fixed by https://github.com/hyperledger/iroha/pull/4056


All resources missing from "Green Cards (Visas and green cards)" topics.

From @shandang on October 29, 2018 16:37
Data may not be mapping due to case sensitivity issue?  Also, the topic spelling on the resources spreadsheet matches topic defined in the topic spreadsheet.  It is in the UI that the spellings are different.
<Green Cards (Visas and green cards)> on spreadsheet vs.  <Green Cards (Visas And Green Cards)> in the UI (the word And should never be capitalized in the English language).  If this is a case sensitivity issue, please change the backend to match the spreadsheet as that is the correct version.
Copied from original issue: Microsoft/Access2Justice#698

We could not reproduce the issue.


class java.lang.Long cannot be cast to class java.lang.Integer

Subj exception thrown when using @Insert or @Update annotations. DefaultReactiveMybatisExecutor.doUpdateWithConnection contains bug: result.getRowsUpdated() returns Long but later collected as Integer: Collectors.summingInt(Integer::intValue)

Thanks for reporting this.This is about the r2dbc-spi version 1.0.0, it changed return type from Integer to Long. But this project hasn't adapt to R2DBC specification 1.0.0 yet. When the adaptation is completed, it will be fixed.

Finished compatible with r2dbc-spi both (0.9.1.RELEASE) version and 1.0.0.RELEASE version. See branch: 3.x


Console logs doesn't support multiple ANSI arguments

The console log doesn't support multiple ANSI arguments. See https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797
For example:

\x1b[31m sets the text color to red
\x1b[44m sets the background color to blue
\x1b[31;44m sets the text color to red and the background color to blue.

Multiple arguments aren't supported, and the ANSI escape code is displayed in the output:

cc @tlmii

I think we should ignore all the effects (bold, italics) and just think about colors. At the very least we should support background and foreground at the same time. Do we care about 256 colors/RGB colors? If simple to do, yes.
The escape sequence should never be shown.

This issue is visible in the RabbitMQ console logs in TestShop:

Does someone working on this one? I can take it if needed !


Losing Focus on Filter Input

Description
when using the filter functions and entering any value the focus is directly removed from the input field while the character pressed shows in the field successfully
Expected Behaviour
the focus must stay inside the input field till a tab is pressed or a mouse click outside the input happens
Note
this happens in version 0.0.19

The error was fixed after updating the Mantine core and other packages related to it to the latest version
thanks to npm-check

Updating to the latest version of mantine packages doesn't work for me. Tested various combinations

@mantine/core 5.5.5 + mantine-data-grid 0.0.20
@mantine/core 5.5.5 + mantine-data-grid 0.0.18
@mantine/core 5.4.0 + mantine-data-grid 0.0.20
@mantine/core 5.4.0 + mantine-data-grid 0.0.18

Can you please take a look into this? @Kuechlin


chore(throwError): typo

Description:

https://rxjs.dev/api/index/function/throwError

BREAKING CHANGE:
Related issue (if exists):

@cartant


Docs: Fix front-matter formatting.

The spacing in the front-matter comments wasn't playing nice with
prettier, leading to formatting issues. This fixes it for all pages,
and reformats the pages with prettier to be sure.

/retest pull-tekton-results-build-tests

/test pull-tekton-results-build-tests

Removed title frontmatter. All other changes to be done in https://github.com/tektoncd/website/pull/230

/approve

/kind documentation
We need this label for release as discussed in the last WG call.


Create F2_5.c

The application you will be writing for is intended to run on a small, inexpensive embedded device that does not have a floating point unit. This means that the processor can only do integer arithmetic. However, the device does have a display and needs to display the result of floating point arithmetic to the user.  Because this is a small inexpensive processor there is no support for strings or any mathematical library functions. You must write all the code yourselves performing all the floating point math with integers only and no strings! Character arrays, or C strings, can't tell you their size but they do end with a '\0' character.
The requirements for the code are to write one of the functions presented below. All the functions return a boolean value indicating the success or failure of the operation. Improper data is the most likely cause for a function to fail. You may add your own additional helper functions (I had at least a half dozen) but you must include them for the review. Do not change the interface to these functions.
These two functions take as parameters two sets of mantissa and characteristic and a char array to hold the result of the arithmetic operations. The result of the add or subtract should be converted into char's and placed in the result array. The array must end with a '\0'. The 'len' parameter tells how many characters can be placed on the result array. For these functions to return true you must at a minimum store the characteristic of the result. If the result is a non-integer place as many of the digits as will fit in the result after a decimal point.
bool add(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len);
bool subtract(int c1, int n1, int d1, int c2, int n2, int d2, char result[], int len);
...
...
char answer[100];
int c1, n1, d1;
int c2, n2, d2;

c1 = 1;
n1 = 1;
d1 = 2;

c2 = 2;
n2 = 2;
d2 = 3;

//if the C string could hold at least the characteristic if(add(c1, n1, d1, c2, n2, d2, answer, 100))
{
    //display string with answer 4.166666666...
}
else
{
    //display error message
}
'''

I am working on this.

Pros:

The description of the code and its limitations are well described in the beginning. The goal needed to be achieved through it is well written and easy to interpret.
The functions name are descriptive as it makes the purpose clear.
The functions input goes well with what is described in the introductory part, as it uses integer values even if any decimal value is introduced.
Areas of improvement:
The functions return a bool value to indicate if it is a success or failure. But it would be more descriptive, if it displayed error messages which would help in the error diagnosis.
The logic for formatting the integer into a string is good, but the results/answer given is restricted to size 100. The size could be varied in order to handle output of various sizes. Example dynamic sizing
The variables name could be more detailed. Example: Instead of c1,d1,n1 it can be character1, numerator1, denominator1, etc.
More documentation can be added to the code to increase readability.
Testing methods can also be incorporated in the code to ensure that the results are what is expected.
Different functions can be introduced.

Pros:

Great job on nailing the floating-point math with just integers! That's not an easy task, and you've pulled it off nicely.

Your code is a good to read - it's well-organized, usage of clear variable names. The comments you've added really help in understanding.

I appreciate how you've handled potential errors. Returning false when the result is too big for the array.

The way you've structured this makes it super flexible. It wouldn't be hard to improve different floating-point formats or add more math operations.

Suggestions to improve:

Have you thought about creating different versions of add and subtract that can handle floats or doubles.

Your error handling for results that don't fit is solid. Maybe you could extend that to catch other potential issues, like if someone accidentally tries to divide by zero.

Since you've got addition and subtraction function, why not take a crack at multiplication and division

To really make sure everything's working perfectly, you might want to run bunch of tests. Try throwing some tricky inputs at your functions and see how they hold up.


modify buffer output

@noseglid what do you think about giving programmatic builds the ability to modify the displayed build output (e.g. to erase matched parts).
Maybe even for regex matches. Erase all matched text
obviously this only makes sense if linter is active, because otherwise we loose information.
I don't have an exact design in mind, just throwing the idea out there.
An alternative would be that I create a separate package to which I can pass just the data I want to see and then hide atom-build's output window. This has obvious advantages, as the display method could be more than textual.

Sorry for taking so long to reply to this.
I am not sure we should increase complexity by this. I think it can be quite tedious to be able parse/modify output as it is appended, not to mention issues that may rise from incorrectly built transforms.
The alternative is a much better approach, I think and is something I've been thinking about for a while. Extracting the build view and connect to it via the service-hub, would allow anyone to create a view for atom-build. The current view could still be installed as default so users are not affected if they're happy with current implementation.
Linter is talking about the same thing.


bug: tweet section in landing page using dummy data in prod

Provide environment information
N/A
Describe the bug
https://user-images.githubusercontent.com/89210438/202898984-0e87b314-607b-4183-bf39-c82f0ffeeef3.mp4
To reproduce

Go to https://create.t3.gg/
Scroll down to the tweets section

Additional information
IIRC, three different tweets were shown there before. Or am I remembering wrong?

It seems our twitter api token has expired or become invalidated.
We need to either update it, or just hardcode/"fake" the tweets.

Wtf i just fixed this last night is twitter rate limiting me or something?

If I am not mistaken, the build will fail if there is no twitter API token provided (here). Are you sure Vercel has the twitter token added when building the docs?


Added a command for getting the service

Proposed changes
When you use docker service ls, it won't show you the list of services. Instead use docker stack services getstartedlab to show the service that was created and thereby getting the Service ID of it.

Deploy preview for docsdocker ready!
Built with commit 76a43be812f7a70ef7c4f2e1e98fa0f60a6e6991
https://deploy-preview-8189--docsdocker.netlify.com

@thaJeztah PTAL

@thaJeztah I've added both suggested changes. Can you or @paigehargrave review for final validation before we merge?

@thaJeztah - This looks good to me since you already reviewed. Please reopen it if I'm mistaken. Many thanks again for all your help with these PRs/Issues.


Remove SMTPatT

The difference between SMTPat and SMTPatT is unclear since F* moved started using universes rather than the stratified type checker (see #547).
@nikswamy said SMTPatT is around for backwards compatibility and should be removed.

This is partly fixed in master now. It was not as simple as removing SMTPatT from the constructors of pattern, since otherwise pattern lists such as [SMTPat (mem x l); SMTPat (x << bound)] (from examples/termination/termination.fst) cannot be formed, because the type of each element is at a different universe.
This is solved by not making patterns an inductive, and just defining it an abstract alias for unit like this. An unfortunate consecuence of not making it an inductive is that an uppercase-starting name for pattern is disallowed, which means a lot of code needs to be ported...
Instead of making the switch to the new names in every file (and making our life hell for merges), I made the old SMTPat's desugar into the new ones, for an easier transition. I'll gradually make the switch, and remove this custom desugaring once we're done and stable.

After a few months of this working seamlessly, I just changed all SMTPatTs to SMTPat in our regression suite.
Should we even bother with moving to smt_pat_t and smt_pat_or? Or should we just leave the current desugaring, and not make a mess?
In any case SMTPatT still works, and should probably be removed to avoid confusion. I can remove it in other projects too, but we should first decide if we want the uppercase version or not.

I've added a warning deprecating SMTPatT, but both work just as before.


Beta diversity: new hypothesis

We should add the following hypothesis for beta diversity:
Beta[donor, subject]_w < Beta[donor, subject]_0

This would be:

group_timepoints with beta div and subject
wilcoxon_srt with baseline_group = 0, and alternative of greater/lesser depending on ordering (which we should document very explicitly).

So I think this would be solved by #14 as well. As we can already ask the != version of this question.


You cannot call toBytes() more than once without calling reset()

I am getting following error while creating dataframe from LMDB
Dropping event SparkListenerTaskEnd(0,0,ResultTask,ExceptionFailure(java.lang.IllegalArgumentException,You cannot call toBytes() more than once without calling reset(),[Ljava.lang.StackTraceElement;@362757b9,java.lang.IllegalArgumentException: You cannot call toBytes() more than once without calling reset()
The command used is as per the example.
Can you please help

Do you still have this problem?


Add support for making charts

Something like https://github.com/highcharts/highcharts-vue can be used, but it would be nice if it were built in to slidev.

Not sure, but probably no. Making charts is kinda a visual and opinionated things, and might also depends on your data's format, or specific professional fields to make different charts. There are many chart libraries with different strength and trade-offs, and I don't think we have one that covers all the use cases. Meanwhile, it's fairly easy to install one on the user side. That said, it might not be a good idea to have one built-in. Thanks for bringing this up.

how to install one on the user side


Add /go/wsl2/ redirect

Docker Desktop uses an informational message that prints:
We recommend to activate the WSL integration in Docker Desktop settings.

See https://docs.docker.com/desktop/windows/wsl/ for details.

We see quite some users trying to copy the URL, and accidentally copying part
of the text, which results in a 404;
https://github.com/docker/docker.github.io/issues?q=in%3Atitle+%2Fdocker-for-windows%2Fwsl%2Ffor%2520details+
I'm changing the message to have the URL on a separate line for easier copying,
but having a shorter URL would make it slightly easier for users to type it in
their browser, without having to copy it.
This adds a new URL https://docs.docker.com/go/wsl2/ that we can redirect to
the most appropriate location within the docs, without having to update the
URL in Docker Desktop itself.

@usha-mandya @StefanScherer PTAL

FWIW, I also opened a PR to change it in Docker Desktop, and to put the actual URL on a separate line for easier copying;
We recommend to activate the WSL integration in Docker Desktop settings.

For details about using Docker Desktop with WSL 2, visit:

https://docs.docker.com/go/wsl2/


Updating a path while Excel has CSV file open crashes Path Planner

I can live with this problem, as I have learned what causes it, but crashing path planner without warning is something that probably should be fixed if it can be.
If you are looking at one of the CSV files generated by pathplanner in Excel. Then you make an adjustment to a path in pathplanner, this will crash pathplanner without warning.  I assume this is because Excel has an open handle on the file and pathplanner can't open a writable handle to the CSV file.  Maybe displaying a warning message like "Unable to update path because another program has a file open in the deploy folder. Your change to the path has been undone. Please close the external program to enable changes to paths" instead of crashing the whole program.

Are you using the release version or the current main branch? There have been changes since the last release that should stop it from crashing, but I suppose showing the user that writing a file failed is a good idea.

The last build I did was back on the 14 Aug, I'll download the latest from github and test again.

That should have had those changes then. Not sure why it crashed but I'll look into it

I just re downloaded and built.  You are correct, the current version doesn't crash the program if excel has one of the csv files open.  The only issue I can see now is that the CSV just doesn't get updated if its open in another program, but there is no warning that states this.  So I think adding the warning message would be good so that you know you have to close the excel file is you want the latest changes to flow into the CSV file.

Hi Michael,
I'm not sure if this is where I should say this or if I should open a new Issue, but I just downloaded and built the latest version of pathplanner and I don't think this issue has been resolved.  To me, it still looks like the csv file that excel has open doesn't get updated when a path is adjusted and there isn't any warning displayed in the GUI that tells you this.  I wish I new a lot more about programming flutter and dart so I could investigate the issue further but unfortunately all I can do is point out the issues I find.
Regards
Warren

I’ll play around with it again but I’m not sure why it wouldn’t be showing an error. It should now show one on any exception while writing the file.


Raw data for record?

I'm not sure if this is possible but I have a function in postgress that return a record.
Basicly it will return (x) if something wrong happen and if is ok will return (a,b)
there is the function:
CREATE OR REPLACE FUNCTION criartransacao(
    IN id_cliente INT,
    IN valor INT,
    IN tipo CHAR(1),
    IN descricao varchar(10)
) RETURNS RECORD AS $$
DECLARE
    ret RECORD;
BEGIN
    PERFORM id FROM cliente
    WHERE id = id_cliente;

    IF not found THEN
    select 1 into ret;
    RETURN ret;
    END IF;

    INSERT INTO transacao (valor, tipo, descricao, cliente_id)
    VALUES (ABS(valor), tipo, descricao, id_cliente);
    UPDATE cliente
    SET saldo = saldo + valor
    WHERE id = id_cliente AND (valor > 0 OR saldo + valor >= -limite)
    RETURNING saldo, limite
    INTO ret;

    IF ret.limite is NULL THEN
        select 2 into ret;
    END IF;

    RETURN ret;
END;
$$ LANGUAGE plpgsql;

My first guess was that I cloud get the raw data and if the len of the data was 1, I had an error, otherwhite I would have on a on data[0] and b on data[1]. Not what I am seeing here.
This is a snnipet of what I'm trying to do
 var result = try global.pool.query("select criartransacao($1, $2, $3, $4);", .{ id, valor, payload.tipo, payload.descricao });
        defer result.deinit();

        const row = try result.next();
        const record = row.?.get([]const u8, 0);

        std.debug.print("record: '{any}' len: {}\n", .{ record, record.len });

        if (record.len == 1) {
            const status: CreateTransactionReturn = @enumFromInt(record[0]);

            switch (status) {
                CreateTransactionReturn.NotFound => {
                    res.status = 404;
                    return;
                },
                CreateTransactionReturn.LimitExceeded => {
                    res.status = 422;
                    return;
                },
            }
        }

        const saldo = record[0];
        const limite = record[1];

right now I'm working with this
record: '{ 0, 0, 0, 1, 0, 0, 0, 23, 0, 0, 0, 4, 0, 0, 0, 2 }' len: 16
record: '{ 0, 0, 0, 2, 0, 0, 0, 23, 0, 0, 0, 4, 255, 254, 121, 97, 0, 0, 0, 23, 0, 0, 0, 4, 0, 1, 134, 160 }' len: 28
record: '{ 0, 0, 0, 1, 0, 0, 0, 23, 0, 0, 0, 4, 0, 0, 0, 2 }' len: 16

I'm guessing that the 4 first values represents the quantity of the data, like, when I expect a error to return like (2) the frist record is 00001, I'm not sure what 23 and 4 means here, and 2 is the value I expect
in the middle one seems similar, 2 for the two results, 23, and 4 (I guess is shows that is an integer or smothing) and them the value.
I'm sorry if this is a dumb question but I'm lost into this, have no Idea how to convert this to the data I expect, hope someone can help me or show me an easy way to do this?

I've thinking about this and for now I'm "solving" this parsing the data direclty.
        var result = try global.pool.query("select criartransacao($1, $2, $3, $4);", .{ id, valor, payload.tipo, payload.descricao });
        defer result.deinit();

        const row = try result.next();
        const raw = row.?.get([]u8, 0);

        // First byte indicates how many items we have in the record
        const len = std.mem.readInt(i32, raw[0..4], .big);

        if (len == 1) {
            // Don't really care for the next two bytes, the value is in [12..16]
            const status_value = std.mem.readInt(i32, raw[12..16], .big);
            const status: CreateTransactionReturn = @enumFromInt(status_value);

            switch (status) { ... }
        }

        // If len is not 1 we expect two values so...
        const saldo = std.mem.readInt(i32, raw[12..16], .big);
        // We have more two bytes that we don't care here so...
        const limite = std.mem.readInt(i32, raw[24..28], .big);

Maybe when I more familiar with zig and postgres I can make a PR to try getting records directly

There's support for the record type now. The API is simple and, to avoid allocations, I opted to force reading the columns in order (rather than being able to specify an ordinal position).
FWIW, since your query is only expecting a single row, you can use pool.row(...) which wraps result + result.next. deinit has to be called on the row, since it's a special row (internally it holds the result)
var row = (try pool.row(....)).?
defer row.deinit()


Update README.md

Add following entry for CVE-2015-1805 exploitation techniques incl. Samsung KNOX bypass
2016, MOSEC 2016: "Talk is cheap, show me the code" by Keen Lab

Thanks! Merged.


Create human readable Documentation

So we can derreference the model properly with a readable specification.
Should look at how Bioschemas generates their documentation, which is quite nice.

Closed as completed


How to specify page?

"Quick capture your ideas to journal or specify page"
How do we specify the page to capture to if we don't want to use the default journal page?
Thanks!

In the extension options simply enter the name of the page. For example I have a page called Bookmarks, so that's exactly how I enter it into the extensions settings textfield.


How can I generate my own training datasets

I saw the front and back masks can be download，but how can I generate my own training datasets??

You can generate your own training datasets using the methods described in Section 4 of the paper. The idea is 'amodal completion' + 'depth verification'.

got it thx. another quetions is can I only use amodal completion to generate?
Because I think the way amodal finds the intersection is good enough.

Yes, you can try. But in our project, if we use both the quality of generated training dataset is better.

Excuse me, would you like to share your source code for generating the training datasets?

got it thx. another quetions is can I only use amodal completion to generate? Because I think the way amodal finds the intersection is good enough.

Hi, could you share your amodal completion codes? I have been generating the amodal masks of my own dataset for a while, but I'm afraid that I couldn't generate them correctly. Thank you!

You can refer to the official github of De-Occlusion (CVPR 2020 oral) for the amodal completion code and follow the strategies in Section 4 of our paper to generate your own amodal masks.

You can refer to the official github of De-Occlusion (CVPR 2020 oral) for the amodal completion code and follow the strategies in Section 4 of our paper to generate your own amodal masks.

Thank you. I will try the deocclusion code.


Update README.md

Readme Updates

[X] Installation Section
[ ] Settings Section

* Settings Section

I'm not sure what are you planning here exactly but if you are planning to describe all options in the README also then I don't think that's a very good idea. Unless you really commit to keeping those + settings file + schema in sync and updating whenever upstream changes something.
Since the settings are described both in the schema and in the settings file, it should be enough to just mention where to edit the settings.
And if upstream documentation (https://github.com/hashicorp/terraform-ls/blob/main/docs/SETTINGS.md) provides some additional benefit then we could link to that too.


Raspotify Slow Song

Hey,  i use osmc and installed Raspotify. It worked but the musicsound is slower and deeper.  It's like when i play the song in half speed.  How can i fix this?

I'm having the same problem.
On stretch.

I found a fix that worked for me here: https://askubuntu.com/a/1051160
Copy-and-pasting it here:

Press Ctrl+Alt+T to go to a terminal and use your favourite editor to edit the file
nano /etc/pulse/default.pa
then find a line containing:
load-module module-udev-detect
modify this to become:
load-module module-udev-detect tsched=0
save and exit and you're all set!

Thank you very much!I tried it on stretch and it also worked for me. On osmc i didn't  had the problem after i enabled the airplay. So it was not nescessary to install raspotify


Cannot get tensorflow to work. DLL load failed and DLL initialization routine failed

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows OS 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version: 1.12.0
Python version: 3.6
Installed using virtualenv? pip? conda?: conda
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

I cant seem to import tensorflow even though I have supposedly installed CUDA and followed an online tutorial.
This is my error when I type import tensorflow:
import tensorflow Traceback (most recent call last): File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in from tensorflow.python.pywrap_tensorflow_internal import * File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in _pywrap_tensorflow_internal = swig_import_helper() File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description) File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\imp.py", line 243, in load_module return load_dynamic(name, filename, file) File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\imp.py", line 343, in load_dynamic return _load(spec)
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.
During handling of the above exception, another exception occurred:
Traceback (most recent call last): File "", line 1, in File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow__init__.py", line 24, in from tensorflow.python import pywrap_tensorflow # pylint: disable=unused-import File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python__init__.py", line 49, in from tensorflow.python import pywrap_tensorflow File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 74, in raise ImportError(msg) ImportError: Traceback (most recent call last): File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in from tensorflow.python.pywrap_tensorflow_internal import * File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in _pywrap_tensorflow_internal = swig_import_helper() File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description) File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\imp.py", line 243, in load_module return load_dynamic(name, filename, file) File "C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\imp.py", line 343, in load_dynamic return _load(spec)
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed. Failed to load the native TensorFlow runtime.
This is what I get when I run tensorflow_self_check.py: ERROR: Failed to import the TensorFlow module.
Python version is 3.6.
TensorFlow is installed at: C:\Users\User\AppData\Local\conda\conda\envs\tensorflow\lib\site-packages\tensorflow
Could not load 'cudart64_80.dll'. The GPU version of TensorFlow requires that this DLL be installed in a directory that is named in your %PATH% environment variable. Download and install CUDA 8.0 from this URL: https://developer.nvidia.com/cuda-toolkit
Could not load 'nvcuda.dll'. The GPU version of TensorFlow requires that this DLL be installed in a directory that is named in your %PATH% environment variable. Typically it is installed in 'C:\Windows\System32'. If it is not present, ensure that you have a CUDA-capable GPU with the correct driver installed.

Apparently you have installed TF-GPU version and it looks like you haven't added cuda path to your environment variable.
Please refer this windows setup guide to know more or else you can always try to install TF cpu version instead. Note that you need to install cuda 9.0 for TF 1.12 in order to use pre built TF-gpu binaries.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

I am having the same issue is anybody able to solve this?


[DRAFT] Systemd improvements

What does this PR do?
A brief description of the change being made with this pull request.
Related/Motivation PR https://github.com/DataDog/datadog-agent/pull/3973
Review checklist (to be filled by reviewers)

[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] Feature or bugfix must have tests
[ ] Git history must be clean
[ ] If PR adds a configuration option, it must be added to the configuration file.

To merge after https://github.com/DataDog/datadog-agent/pull/3974


Make test script cross-platform

This pull request fixes issue #8 using npm-run-all as suggested. It uses the -s flag for sequential execution of test:* subscripts. npm-run-all will run all matching NPM scripts in the order they are defined in package.json, so it should run in the same order as the original script.
I have also added the -l flag that prefixes each script output with the script name for easier troubleshooting. npm test will stop at the first subscript failure. npm test -- -c will run all the subscripts regardless of their completion status.
Happy Hacktoberfest!

 I genuinely thought the PR had to be accepted between Oct 1-30, but actually that's the submission date that counts :)
If you don't mind, you can close/reject this PR and I'll submit a new one tomorrow with your proposed changes.

 I genuinely thought the PR had to be accepted between Oct 1-30, but actually that's the submission date that counts :)

Oh I misunderstood this too! But it does make sense :smile:

If you don't mind, you can close/reject this PR and I'll submit a new one tomorrow with your proposed changes.

I don't mind, let's do that :+1:


datasets for zed

Hello, I want to use the captured images and depth image by zed stereo camera for the input of the great program surfelmeshing, and I want to know whether the datasets can be supported?

There are no plans to support any other dataset formats in SurfelMeshing, however, for sure it should be possible to convert data from the zed stereo camera to the supported format.

Thanks for your reply! I have made a dataset generated by zed2 camera which includes rgb/depth/groundtruth/calibration/associate files, and the program run normally but dont generate any surfels.

Thanks your reply. And I have another problem. Whether I can generate the 3D mesh online during the zed camera opens and captures the environment using the surfelmeshing?


On/off switch for Pension & Student Loans

Solved #53 Switch on/off entire groups

@wozniakpawel  i agree with you, i will make the changes, so that the code is cleaner.

Great, thanks @Shubh8899 !
While you're working on it, I also think it would make sense to move the other two pension-related variables  (autoEnrolmentAsSalarySacrifice and taxReliefAtSource) into a common pension prop, so that all the pension values revert to default when the toggle is off:
    pension: {
        autoEnrolmentAsSalarySacrifice: true,
        taxReliefAtSource: true,
        contributions: {
            autoEnrolment: 0,
            salarySacrifice: 0,
            personal: 0,
        },
    },

const pension = inputs.pensionToggle ? inputs.pension : defaultInputs.pension;
Up to you if you want to include that as that's not in the scope of the issue - if you decide not to do it, I will create a separate PR to merge after yours. Those two variables should not change the behaviour anyway, as they will have no effect with the other values being 0, so it's mostly for cosmetics and/or future-proofing.

Okay makes us, I will move the other two pension-related variables into a common pension prop & create PR for all combined tasks.


DatePicker - cannot disable close on select on desktop

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Setting disableCloseOnSelect={false} on a DatePicker on desktop does not disable close on select. It hides itself as soon as a date is selected, and never displays the Ok/Cancel buttons.
Expected Behavior 🤔
Ok/Cancel buttons should be visible, DatePicker should remain open after selecting a date.
Steps to Reproduce 🕹
https://codesandbox.io/s/basicdatepicker-material-demo-forked-8sbxz
Your Environment 🌎
Firefox 93.0 with the following envinfo:

`npx @mui/envinfo`
  System:
    OS: macOS 11.6
  Binaries:
    Node: 12.19.0 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.0.14 - /usr/local/bin/npm
  Browsers:
    Chrome: 94.0.4606.81
    Edge: Not Found
    Firefox: 93.0
    Safari: 15.0

Having a similar problem with disableCloseOnSelect prop for the Date Range Picker. Prop does not seem to have any effect whether true/false.
https://codesandbox.io/s/basicdaterangepicker-material-demo-forked-zzysw?file=/demo.js

I believe setting it to true is what prevents it from closing on select. This works if I flip the value in your demo. Are there built-in OK/Cancel buttons that you are expecting when the value is true?


Consumer: check offset before returning ConsumePartition.

When calling ConsumePartition, always check whether the offset is within the offset range. This means we now have to do two OffsetRequests for every ConsumePartition call, even if the offset is provided. The good news is that the method will immediately return an error and never start a goroutine, instead of starting the goroutine and returning an error in the Errors() channel which you can easily ignore.
This replaces #378. It now uses two OffsetRequests instead of changing OffsetRequests to allow obtaiing multiple offsets for a single partition.

@Shopify/kafka I had to disable one consumer test due to concurrency issues on the mock broker. Ideas on how to overcome this are welcome.

I believe I fixed the test you had skipped. If travis agrees, this LGTM.

There's probably some test cleanup we can do, but I'll leave that for a separate PR.


Ready for Prod issues didn't get autoclosed by CI/CD on deployment

On deployment, the following Ready for Prod issues didn't get autoclosed by our CI/CD recently:

issues in this epic
https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-data-portal/6202

This failing run shows the error https://github.com/chanzuckerberg/single-cell-data-portal/actions/runs/8472696666

Closing issues:
#6629 (Review and update schema references (4.0.0 -> 5.0.0) )
#6202 (Data Submission Policy was regressed and is returning incorrect version)
#6493 (Remove reorder feature flag)
#6688 (Update seed test data to include four collections three datasets each)
#6483 (Reorder collection datasets)
#6706 (Fix disease auto expand e2e test)
{'errors': [{'message': 'GitHub error. Message: Bad credentials', 'locations': [{'line': 2, 'column': 7}], 'path': ['closeIssues']}], 'data': {'closeIssues': None}}


ULTRA CRITICAL : System app modification

A malicious application can modify any file in /system/apps/ even if it has rights 1

I corrected that. An update will be released in few hours.


Mailmap updates

Please have a look at the individual commit messages for the details.

Merging despite the unrelated SpmFunTest failure.


Looking in wrong tag for credit card account info?

In BuildCreditAccount, you are using $xml->CCSTMTRS->BANKACCTFROM. My statement has this:
$xml->CCSTMTRS->CCACCTFROM
Perhaps different credit card companies use different ones? Or is this just a bug?

Quite possibly just different fields being used; the number of inconsistencies in OFX generation is huge.
https://github.com/asgrim/ofxparser/blob/master/lib/OfxParser/Ofx.php#L172 is probably what we're looking for, although I'd say we need to support OFX with BANKACCTFROM as well still >.<

We can probably put a check for the correct node name into https://github.com/asgrim/ofxparser/blob/master/lib/OfxParser/Ofx.php#L189


color.getFilteredItems returns {}, but the hook is otherwise working fine

To be able to highlight entities in the main component, my color legend needs to fetch all geos along with their color properties. Now when you hover Asia in color legend map you will get an error
this is because colorLegend.js L155: var filtered = _this.model.color.getFilteredItems();
returns {}

and inside getFiltered
var filtered = _DATAMANAGER.get(this._dataId, 'filtered');
returns {}
maybe because this._dataId = "-186847006"
UPD: the bug was found on bubble chart. Mountain chart is surprisingly OK
this might me a major issue, if getFilteredItems is not doing the thing

@angieskazka
Fixed. Not major.
The reason is that using getFilteredItems to get nested items was a hack we had before. Now we have getNestedItems(nesting-keys) to do exactly that.
So I replaced:
var filtered = _this.model.color.getFilteredItems();

with
var filtered = _this.model.color.getNestedItems([KEY]); //getNestedItems(["geo"])

And that's it :+1:


Use a non-zero initial guess for velocity in SAM MSRE simulations

This should fix a current BC failure

Job VTB Documentation on b9175cc wanted to post the following:
View the site here
This comment will be updated on new commits.

Blue Crab will need new submodules for its tests to pass, but this PR does fix one.


Update okhttp to 3.11.0

Fixes

Update okhttp to the newest version 3.11.0

I was already doing a lot of gradle updates in the develop branch... I updated to include everything you have here and merged in #68. Thanks!


Fix ACR linuxFxVersion for function apps

Quick fix for Ignite release
@ahmedelnably @Hazhzeng

This looks good to me


Added underscore support in domain name

Will cover the cases mentioned below table:

Email Sample
Correctly Matched?

<EMAIL_ADDRESS>✅

<EMAIL_ADDRESS>✅

If you can just resolve that one outstanding conflict, I'll take the PR 🙂

Pull Request conflict resolved @troyhunt 🚀

Nice one!


Wrong component path when using command line installation on Windows

pnpm dlx shadcn-ui@latest add dialog

It seems that @/components is not recognized, and the @ directory is created directly by this cli command.
{
  "$schema": "https://ui.shadcn.com/schema.json",
  "style": "new-york",
  "rsc": true,
  "tsx": true,
  "tailwind": {
    "config": "tailwind.config.js",
    "css": "app/globals.css",
    "baseColor": "gray",
    "cssVariables": true
  },
  "aliases": {
    "components": "@/components",
    "utils": "@/lib/utils"
  }
}

Sorry, I forgot I changed my tsconfig.json, my baseurl to ~/*


Credentials that contain / cause errors

Hi,
If AWS secret credential  contains / (forward slash) it causes the following error:
{"level":"info","msg":"Couldn't describe resources for region us-west-2: IncompleteSignatureException: Credential must have exactly 5 slash-delimited elements, e.g.
 keyid/date/region/service/term, got 'UWMPPRonaGauEZx5/MngqKyK/qZD2QllczFEZ2U9/20200619/us-west-2/tagging/aws4_request'\n\tstatus code: 400, request id: f4d107c1-fb
3b-45ed-ba34-f1179354d3c2\n","time":"2020-06-19T22:37:00Z"}

(credential above ir revoked and some chars changed to make it invalid anyway)

Nevermind!!!
Our mistake here, inverted secret and key id here.


New aerosol data

This uses MODIS-Aqua derived aerosol optical depth. Uses data from the bulk download at https://neo.gsfc.nasa.gov/about/bulk.php.
The data preparation code:

Downloads Aqua/MODIS global monthly geotiffs of AOD from 2012 to 2023 (256 files from https://neo.gsfc.nasa.gov/archive/geotiff.float/MYDAL2_M_AER_OD/
Aggregates the data by month over all years (2012-2023)
Downsamples to 1 degree resolution
Saves as a 3D array (180x360x12; lat, lon, month) in the package

The coverage is much better than the dataset used in #4:

Closes #3

 PAH sensitivity meeting


Integration Tests for User- and Settings-Service

This PR adds integration tests to the User-Service and Settings-Service.
You can run the tests using
./gradlew clean assemble integrationTest

The integrationTest task runs the required services in Docker containers and performs the tests using  rest-assured. The tests are located in the the intTest subdirectory of the services.
To run the containers, the file docker-compose-int-test.yml is used, which is located under the root of the backend. Prior to to starting the images, the images are rebuilt based on the current working directory, thus the foregoing assemble  task.
Currently, the integrationTest task is not integrated into the check task due to the fact that the assemble task is required to run beforehand.

Forgot to mention: The old integration tests in the User-Service (based on the Jersey Test Framework and jUnit 4) were removed in favor for the new integration tests.

Travis fails, because I removed the MongoDB in Travis and did not refactor the (old) remaining integration tests, e.g., history-service integration tests with MongoDB.
@lotzk refactoring works pretty well though.
I will update/refactor the remaining integration tests.

Todo:

Split integration tests and API tests into different source sets (separate docker compose files)
Use API gateway for API tests
Refactor History service endpoint test (enable dummy mode for History-Service)
API tests for single subprojects


Fix linking to the TCL library

DCO is missing.

What's DCO?

DCO = https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin
See the 'Details' link next to DCO for instruction on how to fix it.  In general you need to use -s with git commit to sign you commits.


[branch-2.0-pick] Pick "[feature](partial update) support MOW partial update for insert statement #21597"

Proposed changes
cherry-pick https://github.com/apache/doris/pull/21597
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


fix: titles for login and passwordreset page

Codecov Report

Merging #315 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   98.68%   98.68%
=======================================
  Files         152      152
  Lines        2213     2213
=======================================
  Hits         2184     2184
  Misses         29       29

Impacted Files
Coverage Δ

...ient/app/components/passwordreset/passwordreset.js
100% <ø> (ø)
:white_check_mark:

client/app/components/login/login.js
100% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730ebf4...69fe72a. Read the comment docs.


Make targets should error if REGISTRY is unset

What steps did you take and what happened:
I naively ran make test-e2e-local and it failed with an error that took a bit of investigation to fix:
DOCKER_BUILDKIT=1 docker build --build-arg builder_image=docker.io/library/golang:1.21.5 --build-arg goproxy=https://proxy.golang.org,direct --build-arg ARCH=arm64 --build-arg ldflags="-X 'sigs.k8s.io/cluster-api-addon-provider-helm/version.buildDate=2024-03-04T18:11:00Z' -X 'sigs.k8s.io/cluster-api-addon-provider-helm/version.gitCommit=a63ed8ffebda615e93f8f4c48a362b4a94746b5d' -X 'sigs.k8s.io/cluster-api-addon-provider-helm/version.gitTreeState=clean' -X 'sigs.k8s.io/cluster-api-addon-provider-helm/version.gitMajor=0' -X 'sigs.k8s.io/cluster-api-addon-provider-helm/version.gitMinor=1' -X 'sigs.k8s.io/cluster-api-addon-provider-helm/version.gitVersion=v0.1.1-alpha.1.11-a63ed8ffebda61' -X 'sigs.k8s.io/cluster-api-addon-provider-helm/version.gitReleaseCommit=ca44da536ee11b5ffd27f6f1a75f8a9552266caf'" . -t gcr.io//cluster-api-helm-controller-arm64:dev
[+] Building 0.0s (0/0)                                                                                docker:desktop-linux
ERROR: invalid tag "gcr.io//cluster-api-helm-controller-arm64:dev": invalid reference format

What did you expect to happen:
Perhaps the Makefile could warn (or specific targets could error) if REGISTRY isn't set. Making this clear would help contributors figure out how to run the e2e tests locally.
/kind bug

/assign @mboersma

/triage accepted


syntax update for stylelint npm scripts cmd

Using single quotes in the stylelint command didn't work for me (PC, Stylelint 7.7.1). This stackoverflow page simply suggested replacing single quotes with double: http://stackoverflow.com/questions/38814200/files-glob-patterns-specified-did-not-match-any-files - this fixed it for me. Checking out the stylelint docs I didn't see any reference to this issue but all examples used double quotes, so this should be safe.

Coverage remained the same at 99.048% when pulling 1eb35a88ce73e913957d77f99c6e8afec5ec5502 on benkeen:patch-1 into 9d904c963466e397de2d08f84314249d9c0e7ce9 on styled-components:master.

Awesome, thanks!

@mxstbr , I had the same issue today and I was trying to figure it out. This fix also worked for me, but someone changed the documentation back to single quotes, so I didn't see this in the README on master when I was first setting it up.

No quotes also worked, I guess it is okay if there is not space.


[Bug report]: Error Type: Callback Error getLedgerDeviceStatus

Platform
Desktop
Version
1.4.2
Description
Don´t know if this is a new issue, but in Version 1.4.2. it is still the same. When i open IOTA legacy app on ledger and start searching. I still get stuck here:
Error in Firefly:
App Version: 1.4.2
platform: macOS (High Sierra 10.13.6.)
platformVersion: 10.13.6
platformArchitecture: x64
cpuCount: 8
totalMem: 10240.0 MB
freeMem: 4147.1 MB
Error Type: Callback Error getLedgerDeviceStatus
TypeError: Cannot read property 'selectSeed' of undefined
at o (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2882882)
at s (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232324)
at onSuccess (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232138)
at e.. (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2204288)
at Function. (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2197511)
Expected behaviour
Migration trinity to firefly
Actual behaviour
error as described.
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue
steps to migrate with ledger
Operating System
Mac
Diagnostics
App Version: 1.4.2

platform: macOS
platformVersion: 10.13.6
platformArchitecture: x64
cpuCount: 8
totalMem: 10240.0 MB
freeMem: 4147.1 MB

Error Type: Callback Error getLedgerDeviceStatus

TypeError: Cannot read property 'selectSeed' of undefined
    at o (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2882882)
    at s (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232324)
    at onSuccess (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232138)
    at e.<computed>.<computed> (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2204288)
    at Function.<anonymous> (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2197511)

Developer Profile
No
Profile Type
Hardware (Ledger)
Staking
No response
Crash Status
Infinite loading symbol
Error Messages
App Version: 1.4.2
platform: macOS
platformVersion: 10.13.6
platformArchitecture: x64
cpuCount: 8
totalMem: 10240.0 MB
freeMem: 4147.1 MB
Error Type: Callback Error getLedgerDeviceStatus
TypeError: Cannot read property 'selectSeed' of undefined
at o (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2882882)
at s (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232324)
at onSuccess (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232138)
at e.. (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2204288)
at Function. (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2197511)
Error Logs
App Version: 1.4.2

platform: macOS
platformVersion: 10.13.6
platformArchitecture: x64
cpuCount: 8
totalMem: 10240.0 MB
freeMem: 4147.1 MB

Error Type: Callback Error getLedgerDeviceStatus

TypeError: Cannot read property 'selectSeed' of undefined
    at o (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2882882)
    at s (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232324)
    at onSuccess (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2232138)
    at e.<computed>.<computed> (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2204288)
    at Function.<anonymous> (file:///Applications/Firefly.app/Contents/Resources/app.asar/public/build/index.js:2:2197511)

Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@nicole-obrien is this a duplicate of https://github.com/iotaledger/firefly/issues/2783?

Yeah this is duplicate and fixed in 1.5.0 releasing Tuesday.


Skipped fields still error as unknown

As https://play.rust-lang.org/?gist=d32b5f2e2f37bd6c8c87e403f2a26f6e&version=stable illustrates, I would expect when deserializing a structure with skipped fields, deny_unknown_fields does not error on them.
I'd be okay with some other annotation here -- maybe #[serde(default, skip)] on the field explicitly? That seems odd though.
#[macro_use]
extern crate serde;
extern crate serde_json;

#[derive(Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields, default)]
struct Skipped {
    #[serde(skip)] optional: String,
}

impl Default for Skipped {
    fn default() -> Self {
        Self {
            optional: "World".to_owned(),
        }
    }
}

fn main() {
    let _data: Skipped = serde_json::from_str("{}").unwrap();
    let _data: Skipped = serde_json::from_str(r#"{"skipped": "test"}"#).unwrap();
}

This sounds like the reverse of #444. :laughing:
Can you explain a bit more about your use case here? It sounds like you have a field that exists in your JSON input and that you want to have in your Rust struct, but that when deserializing you want the field in the Rust struct to hold its default value rather than the value from the input?
If I got it right, a deserialize_with function may be better suited. It would ignore the field value in the input by deserializing to IgnoredAny, then produce a default value to put in the struct.
#[macro_use]
extern crate serde_derive;

extern crate serde;
extern crate serde_json;

use serde::de::{Deserialize, Deserializer, IgnoredAny};

#[derive(Debug, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
struct Skipped {
    #[serde(default, deserialize_with = "skip", skip_serializing)]
    skipped: String,
}

fn skip<'de, D, T>(deserializer: D) -> Result<T, D::Error>
where
    D: Deserializer<'de>,
    T: Default,
{
    // Ignore the data in the input.
    IgnoredAny::deserialize(deserializer)?;
    Ok(T::default())
}

fn main() {
    let data: Skipped = serde_json::from_str("{}").unwrap();
    println!("empty: {:?}", data);
    let data: Skipped = serde_json::from_str(r#"{"skipped": "Hello"}"#).unwrap();
    println!("non-default: {:?}", data);
}

Closing as intended behavior.

Yes, sorry I missed your message from before; using a deserialize_with attribute seems fine. Thanks!


DDS summarization and asynchrony / unifications of summarization flows across layers

IChannel.summarize() is synchronous, disallowing DDS to do async operations

Pros: the summarization story is simple, i.e. single API to implement
Cons:

(possible) does not allow asynchrony, including writing out some content as attachment blobs and referencing them in summary (to exclude from snapshot)
Not consistent with upper leyers.

Data store, on another hand, has two flows:

async: used for regular summaries
sync: used when data store is being attached to a storage (file / container).

The big con of that is data store author need to implement two different workflows.
This does blead to things like DataObject (Aqueduct) where end consumer need to be more involved in summarization process. For example, to implement O365 search protocol, DataObject does write out search blob, but it can do so only on async path (due to need to load data object which is async process)
We have a plan to unify channels, which will need to resolve these differences between data store and DDS (channels).
Supporting two flows is not great. It's better to have just one.
It would be hard to not have async flow, as we rely on delay loading. While it's possible for summarizer to pause op processing and load all data stores before moving to summarize step, data stores could have more nuanced async story (like delay loaded DataObject). So it would likely need to have two steps - async preparation, and sync summarize, that to some extent defeats the purpose (though allows to keep attachment flow synchronous, as we can assume/demand that preparation step is not required for locally created objects). To some extent that's what we have today at data store level, where summarize() is essentially a combination of prepare() & getAttachSummary()
On the other hand, allowing only async flow means complication for attachment flow.
Likely the easiest way to resolve it move away from single attachment payload, and instead have empty create plus ops that lead to final state at attachment. And either delay sending all that data until object is attached (not great), or actually behave almost as object was attached form the start (i.e. ops are flowing to storage even if object has not been added to object graph yet). Latter will increase number of ops / number of objects that are never rooted in the graph (and eventually collected by GC), but would also possibly make some of our stories easier (it might be allowing us to better deal with merges of two instances of component created by two clients at the same time).

@agarwal-navin, @arinwt, @anthony-murphy - FYI, curious about your thoughts.

@agarwal-navin , @arinwt , @anthony-murphy - FYI, any thoughts to share?

Assigning to July to make progress on design in this month

Early thoughts are captured in this internal document, will move / copy over here once ready: https://microsoft-my.sharepoint-df.com/:w:/p/vladsud/EWZbZh2J7eNHiYJJUXsTIloByNiWo108QgBVJ7q5gaxjTQ?e=XrxWXB

I'll describe possible picture how we could get to end results:

https://github.com/microsoft/FluidFramework/issues/5738 will very likely result in using immutable / copy-on-write data structures to represent DDS state.
That in turn likely makes it easy to implement cheap synchronous cloning of state (mostly talking about DDS, but need to consider how we can do it at higher level, i.e. whole container).
This in turn opens an ability to no longer need synchronous on container attachment, as we can leverage synchronous clone to run the rest of the process async (and not care what happens with the main container).
Some of the work mentioned in above document and in https://github.com/microsoft/FluidFramework/issues/6465 will remove a need for synchronous snapshotting on data store / DDS attachment, as they would always attach empty.
And as culmination, we could completely remove synchronous path for summaries, as all the processes that dependent on it (container attachment and data store/DDS attachment) are no longer dependent on it.

We should also see if other advances / substitutions show up (for example, we might want detached container flow to be much closer to attached flow, i.e. issue ops and produce incremental summaries, and thus # 1-2 from above are not needed / substituted).
But, this will take a year to play out (no matter what direction we chose), so if we need something sooner, then we will need to compromise and likely go on a path of DDS following data store path - having both synchronous and async workflows. This is confusing, but maybe we can limp along with it for a while.

@DLehenbauer, I'm not planning to do anything here in October. If async summaries are required for Whiteboard, we should chat, but I'd expect someone from Whiteboard to spend some cycles here helping implementing trivial version of it (i.e. same ugly design of having two APIs on DDS - sync and async).


Fix strictness bug in definedness check

Fixes #3454
This should improve KEVM (and other semantics which use large, concrete maps or sets) performance significantly.

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

Here is the comparison I have on KEVM (b6e1123f is this branch, be34ef62 is the last KEVM commit I have data about, which is haskell commit: dc423c103ba595c4056c597ec0900fa5545745c5):
 Test                                            | b6e1123f-prove-haskell time | be34ef62-prove-haskell time | (b6e1123f-prove-haskell/be34ef62-prove-haskell) time
-------------------------------------------------+-----------------------------+-----------------------------+------------------------------------------------------
 erc20/ds/totalSupply-spec.k                     | 75.4                        | 72.34                       | 1.042300248824993
 0                                               | 35.07                       | 33.56                       | 1.0449940405244338
 specs/functional/lemmas-spec.k                  | 27.92                       | 26.57                       | 1.0508091832894242
 specs/functional/infinite-gas-spec.k            | 23.49                       | 22.16                       | 1.0600180505415162
 erc20/ds/approve-failure-spec.k                 | 78.26                       | 73.46                       | 1.0653416825483257
 specs/mcd/vat-subui-fail-rough-spec.k           | 178.42                      | 167.36                      | 1.0660850860420648
 specs/mcd/flipper-addu48u48-fail-rough-spec.k   | 68.43                       | 63.95                       | 1.0700547302580141
 specs/mcd/vat-addui-fail-rough-spec.k           | 178.37                      | 166.54                      | 1.0710339858292304
 specs/mcd/dstoken-approve-fail-rough-spec.k     | 687.65                      | 641.68                      | 1.0716400698167312
 specs/mcd/dsvalue-peek-pass-rough-spec.k        | 471.41                      | 439.45                      | 1.0727272727272728
 specs/mcd/flipper-tau-pass-spec.k               | 248.52                      | 231.02                      | 1.0757510172279456
 specs/mcd/flipper-ttl-pass-spec.k               | 238.46                      | 220.21                      | 1.0828754370827847
 specs/mcd/vat-subui-pass-rough-spec.k           | 255.57                      | 235.48                      | 1.0853151010701545
 specs/mcd/vat-mului-pass-spec.k                 | 182.83                      | 168.26                      | 1.0865921787709498
 erc20/ds/balanceOf-spec.k                       | 118.93                      | 109.2                       | 1.0891025641025642
 specs/mcd/vat-subui-pass-spec.k                 | 258.88                      | 237.3                       | 1.0909397387273492
 specs/mcd/dsvalue-read-pass-spec.k              | 389.63                      | 356.83                      | 1.0919205223776027
 specs/mcd/vat-deny-diff-fail-rough-spec.k       | 252.7                       | 230.52                      | 1.0962172479611312
 specs/functional/lemmas-no-smt-spec.k           | 19.0                        | 17.3                        | 1.0982658959537572
 erc20/hkg/totalSupply-spec.k                    | 44.05                       | 39.92                       | 1.103456913827655
 specs/mcd/dai-adduu-fail-rough-spec.k           | 63.55                       | 57.55                       | 1.104257167680278
 specs/benchmarks/ecrecover00-siginvalid-spec.k  | 852.62                      | 755.88                      | 1.127983277768958
 specs/benchmarks/ecrecover00-sigvalid-spec.k    | 1050.38                     | 926.53                      | 1.1336707931745331
 erc20/ds/allowance-spec.k                       | 180.09                      | 158.6                       | 1.1354981084489282
 specs/bihu/forwardToHotWallet-success-2-spec.k  | 531.44                      | 467.99                      | 1.1355798200816258
 specs/bihu/forwardToHotWallet-failure-4-spec.k  | 521.75                      | 457.14                      | 1.1413352583453646
 specs/bihu/forwardToHotWallet-success-1-spec.k  | 525.21                      | 456.42                      | 1.150716445379256
 erc20/ds/transfer-failure-2-a-spec.k            | 405.11                      | 344.7                       | 1.1752538439222513
 erc20/ds/transfer-failure-2-b-spec.k            | 186.08                      | 158.15                      | 1.1766044894087893
 specs/examples/sum-to-n-spec.k                  | 36.73                       | 30.93                       | 1.1875202069188489
 specs/mcd/dai-symbol-pass-spec.k                | 173.8                       | 145.64                      | 1.1933534743202419
 specs/bihu/forwardToHotWallet-failure-1-spec.k  | 184.03                      | 154.17                      | 1.193682298761108
 specs/examples/solidity-code-spec.md            | 157.17                      | 131.37                      | 1.1963918702900205
 specs/bihu/forwardToHotWallet-failure-3-spec.k  | 297.49                      | 246.33                      | 1.2076888726505095
 erc20/ds/approve-success-spec.k                 | 324.95                      | 267.61                      | 1.2142670303800305
 erc20/ds/transferFrom-failure-2-c-spec.k        | 168.59                      | 137.72                      | 1.224150450188789
 specs/bihu/forwardToHotWallet-failure-2-spec.k  | 268.09                      | 218.91                      | 1.224658535471198
 erc20/ds/transfer-failure-1-a-spec.k            | 493.01                      | 402.16                      | 1.2259051123930773
 specs/mcd/flopper-cage-pass-spec.k              | 180.91                      | 147.31                      | 1.2280904215599755
 erc20/ds/transferFrom-failure-2-a-spec.k        | 441.69                      | 358.81                      | 1.2309857584794182
 erc20/ds/transferFrom-failure-1-d-spec.k        | 253.02                      | 204.95                      | 1.2345450109782876
 erc20/ds/transfer-failure-1-c-spec.k            | 230.18                      | 186.21                      | 1.2361312496643575
 erc20/ds/transfer-success-2-spec.k              | 546.72                      | 441.35                      | 1.238744760394245
 erc20/hkg/balanceOf-spec.k                      | 86.97                       | 69.79                       | 1.2461670726465108
 erc20/hkg/allowance-spec.k                      | 115.05                      | 91.03                       | 1.2638690541579698
 specs/benchmarks/address00-spec.k               | 129.22                      | 101.91                      | 1.2679815523501128
 specs/benchmarks/storagevar02-nooverflow-spec.k | 124.74                      | 94.86                       | 1.3149905123339658
 specs/benchmarks/storagevar03-spec.k            | 89.65                       | 68.15                       | 1.3154805575935435
 erc20/hkg/transfer-failure-2-spec.k             | 166.51                      | 125.42                      | 1.3276191994897144
 specs/mcd/cat-exhaustiveness-spec.k             | 143.23                      | 107.28                      | 1.3351043997017151
 erc20/hkg/transfer-success-1-spec.k             | 317.6                       | 237.54                      | 1.3370379725519914
 specs/mcd/cat-file-addr-pass-rough-spec.k       | 222.96                      | 166.37                      | 1.340145458916872
 specs/benchmarks/requires01-a0le0-spec.k        | 105.73                      | 78.83                       | 1.3412406444247116
 specs/benchmarks/storagevar00-spec.k            | 106.26                      | 79.16                       | 1.3423446184941892
 specs/benchmarks/keccak00-spec.k                | 212.61                      | 158.33                      | 1.3428282700688436
 specs/benchmarks/storagevar02-overflow-spec.k   | 121.61                      | 90.55                       | 1.343014908890116
 specs/benchmarks/bytes00-spec.k                 | 208.1                       | 154.74                      | 1.3448364999353755
 erc20/hkg/approve-spec.k                        | 138.34                      | 102.82                      | 1.3454580820851976
 specs/benchmarks/storagevar01-spec.k            | 115.46                      | 84.87                       | 1.3604336043360432
 erc20/hkg/transfer-failure-1-spec.k             | 253.51                      | 185.21                      | 1.3687705847416445
 specs/benchmarks/overflow00-nooverflow-spec.k   | 144.27                      | 105.1                       | 1.3726926736441487
 specs/benchmarks/requires01-a0gt0-spec.k        | 143.51                      | 104.5                       | 1.3733014354066986
 erc20/hkg/transfer-success-2-spec.k             | 204.62                      | 148.37                      | 1.3791197681471996
 specs/benchmarks/encodepacked-keccak01-spec.k   | 197.25                      | 142.06                      | 1.3884978178234548
 specs/benchmarks/overflow00-overflow-spec.k     | 140.99                      | 101.51                      | 1.3889271992907104
 erc20/hkg/transferFrom-failure-2-spec.k         | 363.15                      | 253.35                      | 1.433392539964476
 erc20/hkg/transferFrom-success-2-spec.k         | 421.91                      | 293.11                      | 1.4394254716659274
 specs/benchmarks/staticarray00-spec.k           | 201.87                      | 140.2                       | 1.4398716119828818
 specs/benchmarks/staticloop00-a0lt10-spec.k     | 251.08                      | 174.22                      | 1.441166341407416
 specs/benchmarks/encode-keccak00-spec.k         | 391.09                      | 271.15                      | 1.442338189194173
 erc20/hkg/transferFrom-failure-1-spec.k         | 503.74                      | 341.74                      | 1.4740445953063732
 TOTAL                                           | 17526.630000000005          | 14481.710000000003          | 1.2102596999939925

So it appears that there was a regression from KEVM master to now, unclear if that regression was due to this PR or something else inbetween, but my guess is something else in between.


Fix some markdown errors and add better ADL URI instructions

Instructions to ADL URI retrieval were brief, fixed that. Also fixed some Markdown issues.

@ranieuwe,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ckarst Please review these proposed changes. Thanks.

@ranieuwe,
Thanks for your contribution.
These changes look good, I'm signing off for Casey.
#sign-off

#sign-off

Hi @JennieHubbard, Unfortunately, there are conflicts preventing the merge of these changes. Please resolve the merge conflict so that the pull request can be merged. Thanks

@ranieuwe, This PR cannot be merged due to a conflict between the branch and the repository. Please resolve the merge conflict to enable the merge. Please refer to this merge conflict guidance for assistance. Thanks

@GitHubber17 please close this PR.
@ranieuwe - I submitted your fixes in a separate request.

#please-close


Share Build Credit from Azure DevOps to appcenter.ms

Describe the solution you'd like
I paid for Azure DevOps for stored code, agile tool, build, deploy and use appcenter.ms for distribute the mobile app.
I think build tool on appcenter.ms easy more than Azure DevOps.
Is possible to share credit from Azure DevOps to appcenter.ms?
Thank you.
Pongsakorn.

@ppongsakorn It's not possible to share this credit today, they require separate plans.


django.contrib.admin.util trigger DeprecationWarning in 1.8, will disappear in 1.9

Import from django.contrib.admin.utils (>= 1.9), and fallback to django.contrib.admin.util (< 1.9), to cope with the planned deprecation of 'util'

Thanks!


fix: Update file ending and small edits to script

I changed the script's file ending to .luau for better search results on GitHub (and of course, because we are using Luau). Made SanatiseAssetId a local function. Added --!optimize 2 at the top of the script.

@pizzaboxer Sorry for mention, but if you can check this out that would be great and much appreciated!!


Bring back the tooltip timeout

Type

Bug fix

Description
Before https://github.com/Ensembl/ensembl-client/pull/270, the default delay for the Tooltip used to be greater than 0 (specifically, 800ms)

but in the course of refactoring, it was changed to 0, which makes the Tooltip appear uncomfortably quickly:

This PR changes this back.
Views affected
All

It still appears uncomfortably slowly. Can't the timeout that we have given be reduced from 800 to a smaller figure?

It now appears uncomfortably slowly

Really? Doesn't It have the same delay as on 2020 site?

It now appears uncomfortably slowly

Really? Doesn't It have the same delay as on 2020 production site?

True albeit very slow as in the production site.

It is as if the tooltip doesn't exist when I hover over an icon and then it finally comes up.

I think this should indeed be the case. Most of the times when you interact with an element you shouldn't see its tooltip. It's when you hover over an element for a while — which means that you are unsure about what the element does — that the interface tries to give you a hint.
Try interacting with elements on other sites / in other apps. For example, pause the cursor over the Star or the Fork button on Github:

you will see a similar delay before a native tooltip appears.

It is as if the tooltip doesn't exist when I hover over an icon and then it finally comes up.

I think this should indeed be the case. Most of the times when you interact with an element you shouldn't see its tooltip. It's when you hover over an element for a while — which means that you are unsure about what the element does — that the interface tries to give you a hint.
Try interacting with elements on other sites / in other apps. For example, pause the cursor over the Star or the Fork button on Github:

you will see a similar delay before a native tooltip appears.

Didn't think of it in that way. I was for some reason thinking about tooltips as additional info that I would want to know immediately. Anyway let's leave it like this, since that's what others are also following 😄


fix site information in wmstats

fixes #7217

@amaltaro, Alan, please review. (I still need to test) but it looks OK, I will create 1.0.19_wmagent branch version

test this please

Hmm, It seems that errors reported are not related to the change.

test this please


Getting an error when remapping leap

Hey there,
Very nice plugin. Thanks for all your work. @ggandor.
I am setting up a new neovim configuration and would like to use your plugin.
I am using lazy.vim as my plugin manager.
You can see the configuration and the error in the screenshot.
...
 {‘ggandor/leap.nvim’,
    config = function()
      require(‘leap’).add_default_mappings()
      local leap = require(‘leap’)
      special_keys = {
        repeat_search = ‘<tab>‘,
        next_phase_one_target = ‘<tab>‘,
        next_target = {‘<tab>‘, ‘;’},
        prev_target = {‘<s-tab>‘, ‘,’},
        next_group = ‘<tab>‘,
        prev_group = ‘<s-tab>‘,
        multi_accept = ‘<tab>‘,
        multi_revert = ‘<backspace>’,
      }
      leap.opts.special_keys = special_keys

    end,
  },
      {
        ‘ggandor/flit.nvim’,
        dependencies = { ‘ggandor/leap.nvim’ },
        config = function()
            require(‘flit’).setup()
        end,
    }
}
...

What I did was going to line 30:
press ft +  to go to next.
if I do press ftf it does work as expected.
It is also interesting to see that ftf +  does work.
Therefore it seems to only error if I don't press f first to go to the next occurrence.

I think the problem is that you have mapped the same key (tab) to next_target and next_group. next_group takes precedence, and you get the error reported in #17 (pending fix).

Thanks. I'll close this one then since it's a duplicate. :)


e2e: rework on E2E framework

rework of E2E framework for better code organization and add more helpful logs for debugging.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

@humblec PTAL

@Madhu-1 overall it looks good. however few general thoughts:

In some places we are using cephfs and some places we use CephFS , we have to be consistent
Err returns are not explicit in the logs , its better to mark with a prefix , err or error: %v
We are having different object creation functions for cephfs and rbd. I am wondering if we could make a common function and knob it on the passed argument like (cephfs or rbd) , it will help.
The kubernetes version checking is enforced for some test cases, however its better to group the test cases applicable for a specific version onwards and segregate, so that the kubernetes version matrix gives a better view of the test cases supported against it and we can consistently update it.

@Madhu-1 overall it looks good. however few general thoughts:

In some places we are using cephfs and some places we use CephFS , we have to be consistent

This PR is not modifying anything related to naming conventions.

Err returns are not explicit in the logs , its better to mark with a prefix , err or error: %v

This is fixed now

We are having different object creation functions for cephfs and rbd. I am wondering if we could make a common function and knob it on the passed argument like (cephfs or rbd) , it will help.

This can be a followup PR. PR's are always welcome

The kubernetes version checking is enforced for some test cases, however its better to group the test cases applicable for a specific version onwards and segregate, so that the kubernetes version matrix gives a better view of the test cases supported against it and we can consistently update it.

version check is for Resize and snapshot as both supported versions are different i don't see a way to organize under the same By block. if its possible followup PR will be a good one to improve the readability

/retest ci/centos/mini-e2e/k8s-1.18.5

@humblec one things as part of this  PR I have not done any renaming or adding new lines or changing cephfs to CephFS in most places those are carried from older function, This PR only moves the code to a  new helper functions

@humblec made few cosmetic changes asked for PTAL

@humblec one things as part of this PR I have not done any renaming or adding new lines or changing cephfs to CephFS in most places those are carried from older function, This PR only moves the code to a new helper functions

@Madhu-1 considering the size of the PR, its difficult to understand/notice whats the change coming from existing and if there are any additions.. My intention was to correct as much as we can instead of keeping it for later. Because we may forget unless we have issues tracked for future , I am fine either way.

@humblec one things as part of this PR I have not done any renaming or adding new lines or changing cephfs to CephFS in most places those are carried from older function, This PR only moves the code to a new helper functions

@Madhu-1 considering the size of the PR, its difficult to understand/notice whats the change coming from existing and if there are any additions.  . My intention was to correct as much as we can instead of keeping it for later. Because we may forget unless we have issues tracked for future , I am fine either way.

@humblec I have opened a separate issue to track it https://github.com/ceph/ceph-csi/issues/1465. as this PR is not intended to correct everything related to naming conventions or improving test case descriptions I would like to get this merged and someone can work on the correction on the original code.

@Madhu-1 sure, waiting for E2E to pass.

@humblec am adding ready-to-merge label based on 2 points as @nixpanic is out and also these changes doesn't affect the functionality

Error from server: etcdserver: request timed out
error executing jsonpath "{.items[0].status.ceph.health}": Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:
template was:
{.items[0].status.ceph.health}
object given to jsonpath engine was:
map[string]interface {}{"apiVersion":"v1", "items":[]interface {}{}, "kind":"List", "metadata":map[string]interface {}{"resourceVersion":"", "selfLink":""}}

some failure related to deployment restarting the test

/retest ci/centos/mini-e2e-helm/k8s-1.19.0

@mergifyio backport release-v3.1


Added The Knight's Tour problem (GFG)

Description
Added The Knight's Tour problem from GeekforGeeks to gfg folder.
Problem statement:
Given a N*N board with the Knight placed on the first block of an empty board. Moving according to the rules of chess knight must visit each square exactly once. Print the order of each the cell in which they are visited.
Input:
8
0
0
Output:
01 08 15 22 03 10 19 64
16 23 02 09 18 21 04 11
07 14 17 24 05 12 63 20
34 25 06 13 44 27 52 61
55 46 33 26 53 62 43 28
32 35 54 45 40 29 60 51
47 56 37 30 49 58 39 42
36 31 48 57 38 41 50 59
Fixes #2317
Please review this PR and merge it.

@Ayush7614 please check or review it once. Have I made the the correct changes?


[Bug]: Space Fire Proof Unit for Meka-Suit not working

Minecraft Version
1.19.2
Mod Loader and Version
43.2.6
Ad Astra! Version
1.12.3
Addon Mod Version (This Mod)
1.12
The details
Hello,
Been going through this mod in ATM8 and it would seem the "Space Fire Proof Unit" does not work with the mekanism meka suit.
I can put it on the suit but once entering mercury or venus i just immediately start dying.
Space breathing/gravity both work fine,
Thanks

Did you have just 'Oxygen Can'?, not 'Netherite Oxygen Can'.

In my test, it work fine.
Need 'Netherite Oxygen Can' in hot planet.
Check temperature range in tooltip on oxygen can

In my test, it work fine.
Need 'Netherite Oxygen Can' in hot planet. Check temperature range in tooltip on oxygen can.

I am a moron, completely missed the temperature range, just assumed the netherite ones were just higher capacity.
Thanks!

you are not bad.
It had to be known easily.
Have fun!


[BugFix] Compatible with unknown column type

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #5549
Fixes #5550
Problem Summary(Required) ：

If users rolls back to a version that does not support for json types, the property type in ScalarType will be null, and it will cause some critical error.
We should rewrite the PrimitiveType deserializer process to compatible with unknown column type.
And more, the type should be inited to PrimitiveType.INVALID_TYPE, because when doing checkpoint, the type attribute may disappear in the image, and the field will not be processed when deserializing ScalarType.

[FE PR Coverage check]
:heart_eyes: pass : 9 / 9 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/persist/gson/GsonUtils.java
6
6
100.00%

:large_blue_circle:
com/starrocks/catalog/ScalarType.java
3
3
100.00%

[FE PR Coverage check]
:heart_eyes: pass : 9 / 9 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/persist/gson/GsonUtils.java
6
6
100.00%

:large_blue_circle:
com/starrocks/catalog/ScalarType.java
3
3
100.00%


add test for webhook secret

since it wasn't there 😞
and no need to update vendor when generating the golden files
Changes

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

testing release.yaml generation with go code change..