trufflehog: 3.53.0 -> 3.54.0

Diff: https://github.com/trufflesecurity/trufflehog/compare/refs/tags/v3.53.0...v3.54.0
Changelog: https://github.com/trufflesecurity/trufflehog/releases/tag/v3.54.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 252288 run on x86_64-linux 1

1 package built:

trufflehog


One dimensional case

We need to verify that the eafe_assemble method also works for one-dimensional problems. I suspect we might have an issue here:
https://github.com/thepnpsolver/pyeafe/blob/master/pyeafe/assembly.py#L86
We need to handle scalar-valued convection terms and one-dimensional meshes. Namely, it seems that dolfin defines and edge as a one-dimensional topological subset (see here).  This could be the entire cell; we need to ensure this will be consistent with the EAFE formulation in one dimension.

this works and is tested


Auto insert navigation at bottom of page

WIP

[X] Parse readings in order from start.md
[X] Figure out html tags for left and right align text inline
[ ] Check for existing navigation at bottom of page and replace/delete
[ ] Add new navigation information

As a heads up, we'll want to ensure this does not conflict with the script to add the commit sections. Thank you so much for working on this!

Yes for sure. Just to be clear this should be at the bottom after the git section right? And should I also make it a mix task?

Yes for sure. Just to be clear this should be at the bottom after the git section right? And should I also make it a mix task?

Hi @mvkvc! I'm sorry I thought I had responded to this but I did not!
Yes, it should be at the bottom after the git section. Making it a mix task would be fantastic.

@mvkvc How is this going? I'm doing a content review tomorrow, and it would be awesome to have this feature.
If you don't mind, I might grab what you've done and see if I can finish it for tmr

Draft solution in #281 . I would be happy to get your thoughts! Apologies if I'm stepping on your toes by implementing this.
I couldn't get anchor tags working with relative links, so I used markdown links inside a table. I'd like to improve the UI but this is "good enough" for my purposes tomorrow to get feedback.

@BrooklinJazz sorry I didn't see you tagged me and I have just been so busy recently and meant to get to it this weekend. Happy to see that you got it working and I will check out your solution :+1:.


Make more light weight

imho this has unnecessary dependencies and too much complexity

I think we can  refactor line 0-0 of file  to:


Add support for Rust

If the file is setup as a project with Cargo, this is easily done by running cargo run in the same directory as the .rs file.
If Cargo can't be used, either because it's not installed or because there is no Cargo.toml in the project, then a single Rust file can be run with the following two commands back-to-back (at least on Windows):
rustc helloworld.rs & helloworld.exe

Fixed by #260.

Fixed by #260.


[8.x] Add TestResponse->assertJsonPathExists

This PR adds a new test assertion assertJsonPathExists to the TestResponse. This allows users to test if a JSON response has a certain path using dot notation without caring about the value. This is an addition to assertJsonPath that checks for both the path and the value.
Example JSON response
{
  "data": {
    "username": "Foo Bar",
    "email"<EMAIL_ADDRESS>    "addresses": [
      {
        "address1": "Test 123",
        "city": "Kalamazoo",
        "state": "Michigan",
        "country": "US"
      },
      {
        "address1": "Test 456",
        "city": "Grand Rapids",
        "state": "Michigan",
        "country": "US"
      }
    ]
  }
}

Current option
$response->assertJsonStructure([
    'data' => [
        'username',
        'addresses' => [
            ['address1', 'city']
        ]
    ],
]);

This option is quite verbose especially if you just want to make sure an address has address1. You have to build out the entire array structure.
New options
$response->assertJsonPathExists('data.addresses.0.address1')

* is also supported:
$response->assertJsonPathExists('data.addresses.*.address1')

Along with partial path matches:
$response->assertJsonPathExists('data.addresses');
$response->assertJsonPathExists('data.addresses.');
$response->assertJsonPathExists('data.addresses.0');
$response->assertJsonPathExists('data.addresses.*');

Possible suggestions
assertJsonPath currently uses the data_get helper. Should we create a data_exists helper and then refactor the logic to that helper?

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Fix for Gerty mempool timestamp col on sqlite

Changed how the Gerty mempool caching table sets timestamps for cached data.
Previous code worked on postgres but not sqlite.
This changes the migration to set a default timestamp value for the mempool time col to the current time stamp and the mempool INSERT and UPDATE code no longer sets a time value.

Codecov Report

Merging #1308 (7074fc3) into main (1fcbd89) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1308      +/-   ##
==========================================
- Coverage   48.29%   48.20%   -0.09%
==========================================
  Files         278      278
  Lines       16275    16278       +3
==========================================
- Hits         7860     7847      -13
- Misses       8415     8431      +16

Impacted Files
Coverage Δ

lnbits/extensions/gerty/crud.py
28.00% <ø> (ø)

lnbits/extensions/gerty/migrations.py
100.00% <100.00%> (ø)

lnbits/db.py
81.20% <0.00%> (-10.07%)
:arrow_down:

lnbits/commands.py
73.61% <0.00%> (-1.39%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Wrong clues?

The plugin says I need to give easy and medium clues to Watson, but Watson says I need to give him an elite clue as well.

Does the plugin still say that you only need to give him easy + medium after you checked with watson, or did checking with watson fix the issue?
Also, did you ever hand him clues when not playing on runelite? The plugin only works when it sees you handing/receiving a clue to/from watson.

This was caused by a line break in the middle of "elite clue".
Fixed in 1.0.2


Pre-Trained LSTM.ipynb

missing files: wordsList.npy, wordVectors.npy
import numpy as np
wordsList = np.load('wordsList.npy').tolist()
wordsList = [word.decode('UTF-8') for word in wordsList] #Encode words as UTF-8
wordVectors = np.load('wordVectors.npy')
FileNotFoundError                         Traceback (most recent call last)
 in ()
1 import numpy as np
----> 2 wordsList = np.load('wordsList.npy').tolist()
3 wordsList = [word.decode('UTF-8') for word in wordsList] #Encode words as UTF-8
4 wordVectors = np.load('wordVectors.npy')
C:\ProgramData\Anaconda3\lib\site-packages\numpy\lib\npyio.py in load(file, mmap_mode, allow_pickle, fix_imports, encoding)
368     own_fid = False
369     if isinstance(file, basestring):
--> 370         fid = open(file, "rb")
371         own_fid = True
372     elif is_pathlib_path(file):
FileNotFoundError: [Errno 2] No such file or directory: 'wordsList.npy'

Read the README for information on downloading the data


Refinement of SQL API

Hi, @michellesackmann and I removed the last hard coded parts of the SQL API.
Everything needed is specified in the model.json file which is located under resources. So, this model.json file is the configuration file like you typically see in other systems. We also added the possibility of specifying a separator for .csv files.

Hi guys, I don't think this is the right way to support different data sources.
As we discussed in an earlier email, a better way to go about this, which is also extensible and maintainable, is to first extend the WayangRel Algebra, with specific table scan operators (e.g., one for Jdbc, one for csv, etc..) and write logical-to-physical rules. Each physical scan operator should then have methods for accessing sources.

@kbeedkar can we merge and open a ticket to improve the commit? Multiple CSV files sounds great :)

Hi, thank you for your comment. This is something that can be improved, unfortunately, given the limitations of this research project, we don't have resources to do that right now. Also, there are definitely more stuff that could be improved. In our opinion, this PR is still an improvement since it 1) gets rid of all the hard coded parts 2) cuts severely down on the lines of code that the user has to provide to run a query and 3) adds the functionality to provide delimiters/separators for csv-files. Yes, in terms of future maintainability/extensibility we agree with you, but it requires resources that we don't have right now.
We hope that your suggestions can be implemented in another PR :)

Pls add the license header:
https://github.com/apache/incubator-wayang/actions/runs/4948812486/jobs/8880546014?pr=322#step:3:127

@2pk03 the license header should be there now :)

Yes @2pk03, let's do it that way.

Sounds great guys, thank you for approving the PR! Is there any chance the PR could be merged before tomorrow afternoon, since we have to hand in the report for our project, and it would be great if it was aligned with what is on the main branch.


Update Spring Cloud Azure Support File

Update Spring Boot and Spring Cloud versions for the compatibility test. This PR is created by GitHub Actions: https://github.com/Azure/spring-cloud-azure-tools/actions/runs/2518643984

/check-enforcer override


Fixes for runtimev2 and checkpoint restore

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #2482 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2482   +/-   ##
=======================================
  Coverage   44.73%   44.73%
=======================================
  Files          93       93
  Lines        9501     9501
=======================================
  Hits         4250     4250
  Misses       4566     4566
  Partials      685      685

Flag
Coverage Δ

#linux
48.94% <ø> (ø)
:arrow_up:

#windows
40.98% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fb363...17ab11a. Read the comment docs.

LGTM


Cannot type Japanese from Ubuntu 16.04 LTS

Is your feature request related to a problem? Please describe.
As written in title, Japanese cannot be used from Ubuntu 16.04 LTS. I'm not sure this happens on other environments. I'm using Japanese introduced here http://www.localizingjapan.com/blog/2017/08/20/japanese-input-on-ubuntu-16-04-lts-xenial-xerus/
I guess this is the most popular software.

The same to Chinese input.

Input Chinese is not supported,me too.

Input Chinese is not supported,me too.

sorry,The answer is here:https://github.com/klauscfhq/tusk/issues/58

Please see https://github.com/klaussinani/tusk/issues/58.


Typography styling

Style the docs typography as per design.

Done https://github.com/arcjet/arcjet-docs/pull/82


Fix spelling of received

I spotted this while I was working on a similar page in Apply for QTS.

Looks like my PR doesn't build as it's a fork :( I don't have write access to the repo, happy for you to cherry-pick my commit in to a branch on the repo!


Testing the newly added template

Description

This is only a test of the recently pulled PR #362  .
Screenshots

[Optional] Additional Context
More such templates need to be created.

Join Eddie's discord community here

Label was added successfully. But I will remove the [Optional] tag in the body.

Thank you for testing 👍


Omit docstring from show_source

Is your feature request related to a problem? Please describe.
For modules with mathematical correlations/equations, the code can sometimes be much shorter than the docstring - especially when LaTeX equations and long parameter lists are involved. It's nice to have the option to show the source code in the documentation, as the implementation can be quickly verified, but showing the unformatted docstring source can make this difficult and less readable.
Describe the solution you'd like
It would be beneficial to have an omit_docstring option to go with show_source so that the code block line numbering starts at the first non-whitespace line and continues to the end of the function. I apologize if this is already possible and I missed it somehow.

Hello, thanks for the request, see https://github.com/mkdocstrings/mkdocstrings/issues/249!

Hello, thanks for the request, see mkdocstrings/mkdocstrings#249!

I searched this repository but didn't think to search the other one!
I had considered the issue of the break in line numbers. One alternative I thought of was also omitting the function declaration so that the source code block starts after the docstring with contiguous line numbers. Obviously that's not a desirable permanent solution, but since it looks like a full solution would require quite a few different library changes, it could be a good temporary solution. That way, the implementation would still be available with correct line numbers, and with the function annotations on you wouldn't really be missing any information.


Servers can set custom welcome messages & default role.

➤ ComixsYT commented:
Can be stored as txt or json files. These files can be expanded as needed for more per server setting.


Update documentation on jenkins, ECR and docker-hub for opensearch to reflect admin credentials change

Update docker-hub, jenkins and ECR documentation to reflect changes to admin user credentials in security plugin demo configuration tool once 2.12 is GA. (Owners: @peterzhuamazon @prudhvigodithi since they have access to update)
Tasks:

[ ] Update docker-hub documentation
[ ] Update jenkins documentation
[ ] Update ECR documentation

Also we should update ECR as well https://gallery.ecr.aws/opensearchproject/opensearch.
Thanks

thanks @prudhvigodithi. I've updated the description.

Updated already.

@peterzhuamazon any reason why this got re-opened?

Will be closed after 2.12.0 released.

@rishabh6788 @peterzhuamazon @DarshitChanpura  Can we close this issue?

On docker-hub & ECR, some description still needs be updated;
Send requests to the OpenSearch REST API to verify that OpenSearch is working. By default, OpenSearch uses self-signed TLS certificates. The -k short option skips the certificate verification step so requests don't fail. The default username is admin and the default password is admin.

curl -X GET "https://localhost:9200" -ku admin:admin
curl -X GET "https://localhost:9200/_cat/nodes?v" -ku admin:admin
curl -X GET "https://localhost:9200/_cat/plugins?v" -ku admin:admin

Changed now.

This issue is completed for now.
Thanks.

More updates:
The default username is `admin` and the password will be `admin` for OpenSearch 2.12 and earlier. For OpenSearch 2.12 and later, the password will be the custom value, which is required to be provided during the demo configuration setup for security plugin.


cart

If you'd like to request an icon, please provide the following information:

icon name
at least one use case
screenshots of similar icons

Please create one issue for each icon request.

Possible dupplicate of #79


export last_menstrual_period_at_appt_weeks

I rule and have completed some work on Case Manager that's ready for review!
Added Patient#last_menstrual_period_at_appt_weeks to be exported. Checked the data doc for the field
It relates to the following issue #s:

Fixes #1922
Bumps #Y

hey @kathrynyetter , we have a test failure here through no fault of yours --
docker-compose run --rm web rails test

....

Error:
PatientsControllerTest::index method#test_0007_should not contain personally-identifying information:
NoMethodError: undefined method `last_menstrual_period_at_appt_weeks' for #<ArchivedPatient:0x00007f9ebaec29e8>
Did you mean?  last_menstrual_period_weeks
               last_menstrual_period_weeks?
               last_menstrual_period_weeks=
               last_menstrual_period_days_was
    app/models/concerns/exportable.rb:152:in `public_send'
    app/models/concerns/exportable.rb:152:in `get_field_value_for_serialization'
    app/models/concerns/exportable.rb:193:in `block (3 levels) in to_csv'
    app/models/concerns/exportable.rb:193:in `map'
    app/models/concerns/exportable.rb:193:in `block (2 levels) in to_csv'
    app/models/concerns/exportable.rb:192:in `block in to_csv'
    app/controllers/patients_controller.rb:152:in `each'
    app/controllers/patients_controller.rb:152:in `each'
    app/controllers/patients_controller.rb:152:in `block in render_csv'
    test/controllers/patients_controller_test.rb:73:in `block (2 levels) in <class:PatientsControllerTest>'

rails test test/controllers/patients_controller_test.rb:71

From the message there, it looks like last_menstrual_period_at_appt_weeks is not a method that ArchivedPatient has available. Fortunately, we can fix that up by adding include LastMenstrualPeriodMeasureable in app/models/archived_patient.rb, easy peasy - go ahead and stick it under # Concerns. Then we should be good to go!
In other news, gotta spend some time trying to figure out what's up with circle again, bleh.


Fix checksum for Jenkins

Fix for https://github.com/caskroom/homebrew-cask/issues/13155.

Merged as e795a79b72e43db5d7d7edbf09191f571931815e.


Rename filter method "Assign to Me" to "Assigned to me"

Bringing back the changes from https://github.com/fabric8io/fabric8-planner/pull/744
Fixes #757

Resolved as part of #891, closing this.


Feature request: bufferline.nvim integration

Hello everyone,
I'm using https://github.com/akinsho/bufferline.nvim to show all currently open buffers.
It can also be used to manually rearrange the buffers in the bufferline. If I rearrange a
buffers and close a buffer (with nvim-bufdel cycle behavior), the next chosen buffer is
not necessarily the next one in the bufferline.
I forked your code and implemented a new next mode named custom_fn that will
use a custom function to choose the next buffer. I could also directly integrate bufferline.nvim
into the code.
Are you willing to accept a PR to incorporate either of those features or both? Do you see
a better way to handle choosing the next buffer then the methods I mentioned?
Have a great day!

Hello ! Yes the first feature custom_fn would be great to have :). No need to have both.


add nkut

School URL: https://www.nkut.edu.tw

please request https://www.nkut.edu.tw/ <= This domain is nkut.edu.tw
don't request https://webmail.nkut.edu.tw/cgi-bin/login?index=1


s3 compatible object storage support

closes https://github.com/rilldata/rill-developer/issues/1691

Made a little change to use the configured region if set, although I'm not sure it will ever make a difference. Everything else looks good, merging now


The cursor can't move in the Ruby irb Mode in the Integrated Terminal

VSCode Version: Code 1.6.1 (9e4e44c19e393803e2b05fe2323cf4ed7e36880e, 2016-10-13T16:21:53.542Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: austin.code-gnu-global-0.2.1, ms-vscode.cpptools-0.9.2

Ruby version is 2.2.5
In the Integrated Terminal,The cursor can move in the normal terminal , but can't when entered the irb!

PS:It actually works when calling irb on the normal cmd.exe

Duplicate #14613

This should hopefully be fixed in tomorrow's Insiders build (via https://github.com/Microsoft/vscode/commit/63f1fa66800bf641de5e36027610503ba75085b5). Please let me know if it still reproduces.
See https://github.com/Microsoft/vscode/issues/13625 for more information.

#13625 does not fix this issue

Upstream issue https://github.com/rprichard/winpty/issues/99

Thanks. I will check out.


Should we expect support for Angular 8? When?

Any updates there?

Angular 9 is released and Renderer is finally removed. It means we can't use this library with Angular 9 anymore...

Here is my PR. Could you please review this @BTMorton ?
https://github.com/BTMorton/angular2-grid/pull/305

Version 4.0.0 should support v8 and v9


Set LanuageSettings to optional

LanguageSettings  fields need to be marked as optional to allow constructs as. As not all options are needed when creating the settings object.
var table = $('#example').DataTable({

processing: true,
serverSide: true,
pagingType: "full_numbers",
lengthMenu: [5, 10, 15],
language:  {
   paginate: {
      first: "Fsairst",
      last: "Laasst",
      next: "Nexast",
      previous: "Preavious"
   }
}

@pingcrosby thanks mate!


Improve gasLimit approach

gasLimit is currently hard-coded on constants.
It should be a parameter that could be overridden and takes default value from constants.

Implemented in #148


Fix SyntaxError: JSON.parse and format the indentation

Indentation will be lost if we copy each script from web page. So, I formatted the indentation.

@changeworld : Thanks for your contribution! The author, @mgoedtel, has been notified to review your proposed change.

We're in the process of pulling these commits to the private repo, so we can verify the content on staging. We'll post a new PR # shortly and then close this PR.


Can't load FancyMessage from String

Hi, actually when I save the fancyMessage toJSONString() and then i try to load it I just get a NullPointerException.

Hi, I am also getting this issue.
I am getting this error
Caused by: java.lang.NullPointerException
	at mkremins.fanciful.FancyMessage.deserialize(FancyMessage.java:829) ~[?:?]


Feature Request: React-transition-group be part of dependencies and not peer dependencies

Is there any specific reason as to why react-transition-group is listed as peer dependencies? I am using a different version of the react-transition-group lib for my project and this will cause conflict with the lib.

Hey @benjie91
You should update your react-transition-group, why would you want two different versions of the same dependency in your bundle?
That's why it's a peer dependency, so you can have only one version of it, same reason why react is a peer dependency.

In that case, your documentation state that it is v2.5.3 and up. So are you limiting users of your lib to this particular version range.
For newer projects who are using v4.1.1 of the react-transition-group, do you suggest them to include both version of dependencies which I am not in favor of as you mentioned.
React is a different story because you are building your lib/app with it. It is expected that everyone who use react for the view component to include it as part of their dependencies.
Likewise for prop-types, I am also strongly in favor it being in the dependencies. You can see facebook also recommending it that way.
https://github.com/facebook/prop-types#how-to-depend-on-this-package

Another link for you to consider.
https://github.com/cssinjs/react-jss/issues/164
You can also see Gearon's explanation on why it should be dependencies instead.

No, if there's a newer version of react-transition-group that doesn't work with this lib, we should update it to make it work with the newer version.
But no, I will not make it a dependency because if every lib does that you would end up with a lot of duplicated code in your bundle, and I don't think that this is the right thing to do.

I think you can let yarn and npm to be the dependency manager as you had already use the carrot sign for the packages and thus there is minimal impact on duplicated code.
In the client side land, an old project especially enterprise application will not likely be able to use your lib because the risks of upgrading these dependencies such as react-transition-group might cause more harm than good. Likewise for new projects, if they are using a later version of react-transition-group, then they have to wait for the maintainer of this lib to upgrade before they can use it. Of course, there are other ways to resolve it (e.g. forking your project, maintaining two separate version in the package.json) but it is not elegant at all.
For example, react-bootstrap lib is already packaging react-transition-group as v4 and up  (dependency) and your lib is forcing users to use ^2.5.3 and up (peerDependencies). Here there are already duplicated code but your lib is imposing more restriction on users by dictating what version they need to use. If I also need to use the react-transition-group but I specify it to be v4.1.1 (Yarn and npm would resolve it to the same dependency as the one used by reasct-bootstrap), I would not be able to use react-bootstrap but not your lib due to breaking changes between v2 and v4.

My concern is not about what you install in your node_modules, but what ends up in your final bundle, the one your users will have to download before using your app.
Again, I think this type of dependencies should be peer, because I don't want the final user to have to download multiple versions of a 4.4kb (gziped) dep, just because the developer didn't wanted to manage its dependencies. If the people building react-bootstrap and other libs think different, its ok, but as I said before, if everyone do it like that your final user will have to download a ton of dup code.
By the way, I've just tested with the latest version of react-transition-group (4.1.1) and it worked, so feel free to use the latest one.

But maybe I'm getting it wrong 🤔
If I tell rollup that it's external, even as a dependency it wouldn't be included in the bundle of the lib, so maybe there's a way to make it work even for UMD bundles.

It was included in the v6 release, thanks for the suggestion!


Addition to Category > Operating System

Can you add Debian and Kali to the Operating systems category

The categories are dynamically assembled from the different Template sources.
Example
Once a template uses the Operating Systems category, the option will appear.


[DOCU-2606] Update "About service meshes" doc

Updated the name of the "What is a service mesh?" doc to match the 2.0 Kuma docs revamp and the name in the new sidebar. I didn't add a redirect because I didn't change the file name and it's still in the /introduction folder.
DOCU-2606
Signed-off-by: Diana<EMAIL_ADDRESS>

Closing this PR (but keeping the branch) until we start working on the Kuma 2.1 IA rework.


user-tools should add xms argument to java cmd

Signed-off-by: Ahmed Hussein<EMAIL_ADDRESS>Fixes #1382
Upon investigation, it was revealed that the min heap size could impact the runtime significantly. (see the linked issue for details of the performance impact)
This code change aims at setting the xms java argument to 50% of the max heap size.

pass xms to the java cmd
update the runtime report to list jvm info along with jvm arguments related to heap:

runtime.jvm.*
runtime.jvm.arg*

sample runtime.properties file. The lines that are generated by the changes in this PR are marked with >
#RAPIDS Accelerator for Apache Spark's Build/Runtime Information
#Wed Oct 23 20:26:21 UTC 2024
build.scala.version=2.12.15
build.hadoop.version=3.3.6
build.spark.version=3.5.0
> runtime.os.version=6.8.0-39-generic
> runtime.jvm.version=1.8.0_422
build.version=24.08.3-SNAPSHOT
runtime.spark.version=3.4.2
> runtime.jvm.arg.heap.min=50g
> runtime.jvm.name=OpenJDK 64-Bit Server VM
> runtime.jvm.arg.gc.UseG1GC=
> runtime.os.name=Linux
> runtime.jvm.arg.heap.max=100g
build.java.version=1.8.0_422

Details
This pull request updates the handling of JVM heap arguments in the Spark RAPIDS tool.

The most important is setting the Xms  the jar CLI.
Introduces enhancements to the RuntimeUtil class by adding JVM and OS information to the runtime properties, extracting JVM heap arguments, and ensuring these arguments are correctly set in the user tools.

Enhancements to RuntimeUtil:

core/src/main/scala/org/apache/spark/sql/rapids/tool/util/RuntimeUtil.scala: Added imports for ManagementFactory and Scala collection conversions.
core/src/main/scala/org/apache/spark/sql/rapids/tool/util/RuntimeUtil.scala: Added methods to include JVM and OS information in the runtime properties and to extract JVM heap arguments. [1] [2]

Updates to JVM heap arguments handling:

user_tools/src/spark_rapids_pytools/rapids/rapids_tool.py: Updated the _re_evaluate_platform_args method to set both minimum and maximum heap size arguments for the JVM.
user_tools/src/spark_rapids_tools/utils/util.py: Added logic to calculate and include the minimum heap size in the tool resources.

Related and followups:

internal ticket was filed to update the java CLI in the CI/CD job
there is an internal ticket to update the user guide to emphasize the important of setting the heap arguments.

Thanks @amahussein for investigating and putting up the fix for this. Just a nit.

Thanks @amahussein for investigating and putting up the fix for this. Just a nit.

Thanks @nartal1 !
Removed the debugging code.


Latest version of black?

What version of black does this use? Is it the latest?

The black version is 19.10b0
What version of action are you using? Depending on the version you use, you may be experiencing this problem. At first it was solved in Isort 5. What version of Isort are you using?
Can you send me your yml?

The black version is 19.10b0
What version of action are you using? Depending on the version you use, you may be experiencing this problem. At first it was solved in Isort 5. What version of Isort are you using?
Can you send me your yml?

https://github.com/turian/ddsp-drum/blob/main/.github/workflows/pylint.yml
Thank you

https://github.com/turian/ddsp-drum/blob/main/.github/workflows/pylint.yml
Thank you

We are having the same issue with black, not using isort. This is our yml:
name: Lint

on:
  pull_request:
    types: ["opened", "edited", "reopened", "synchronize"]

jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@master
      - name: python-lint
        uses<EMAIL_ADDRESS>        with:
          use-pylint: false
          use-pycodestyle: false
          use-flake8: true
          use-black: true
          use-mypy: false
          use-isort: false
          extra-flake8-options: "--max-line-length=99"
          extra-black-options: "--line-length=99"

Hi @alvarovn , how are u? Can you try the version<EMAIL_ADDRESS>pls?

I just tried and have the same issue.
Fedora 33 black version is 20.8b1, which has different results from 19.10b0

I put an image with new versions of the libs.
I also added how we can test the action locally in README.md. Could you try and post the results here, please?

@ricardochaves I haven't been able to replicate the bug, I'll let you know if I do.
BTW, you should consider bumping the version of black again. There are more fixes in the latest: https://github.com/psf/black/issues/2199

Are there any plans for the next bump of black version? The version used by this action does not support Python 3.9, i.e. the action fails with a matrix containing Python 3.9 because switch -t py39 is invalid. Black 21.7b0 seems to include py39 as an available option.


Type Error 2

Error
Need exists check in navigator#45
  submitForm(form: HTMLFormElement, submitter?: HTMLInputElement) {
    this.stop()
    this.formSubmission = new FormSubmission(this, form, submitter, true)

    this.formSubmission.start()
  }

Prediction
cant read property ____ of undefined

Investigation reveals potential issues only in unreachable code, like the unused FetchRequestDelegate methods on FormSubmission here and here where submitter is assumed to exist


Review doc regarding optional parameters

Some configuration options are nullable or optional. The doc should be reworked to make that clear. The code should be checked as well to see how the schema validation works in those cases

Done in #68. Some settings are missing but I need to review them altogether.


Remaining fixes as per review comments

Why not handle Photon changes in separate PR? @shuklanirdesh82 @girishshilamkar What are we blocked on?

@girishshilamkar Let's move photon documentation updates to a separate change. As we had discussed offline, we don't plan to add more details to Photon section than what we already have. Let's simply make sure the existing content is accurate. @govint can you please provide the updated description?

Why not handle Photon changes in separate PR? @shuklanirdesh82 @girishshilamkar

Sure @pdhamdhere!

What are we blocked on?

@girishshilamkar / @pdhamdhere ,
VUM related section needs to be adjusted, with the proposed PR the changes are reverting back. The PR needs to be addressed my comment related with VUM section. After addressing https://github.com/vmware/docker-volume-vsphere/pull/1244#discussion_r116578869, this PR is ready to be merged having it said "photon platform" changes needs to be addressed as a separate PR.
Thanks!

@shuklanirdesh82 I have put back the VUM references. Now changes to photon section are pending and blocked on @govint to provide those details. @govint Could you please provide details as per this request ? Thanks!

@girishshilamkar
I am merging this change please send out new PR with changes for photon section (please make sure to address @govint 's comment).
Regards,
Nirdesh


fix: make negotiation api launch a decline command

What this PR changes/adds
Introduce a decline command and make the ContractNegotiationApiController launch it.
Why it does that
The current /decline endpoint is not declining the negotiation on both sides.
Further notes

improved the SendRetryManager interface, as it caused a lot of warnings due to bad design.

Linked Issue(s)
Closes #2259
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Base: 64.52% // Head: 12.20% // Decreases project coverage by -52.31% :warning:

Coverage data is based on head (b0f0930) compared to base (d8d5e4e).
Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head b0f0930 differs from pull request most recent head 589e3c3. Consider uploading reports for the commit 589e3c3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2315       +/-   ##
===========================================
- Coverage   64.52%   12.20%   -52.32%
===========================================
  Files         828      830        +2
  Lines       17417    17439       +22
  Branches     1086     1088        +2
===========================================
- Hits        11238     2129     -9109
- Misses       5734    15203     +9469
+ Partials      445      107      -338

Impacted Files
Coverage Δ

...edc/statemachine/retry/EntitySendRetryManager.java
0.00% <0.00%> (-89.48%)
:arrow_down:

...egotiation/AbstractContractNegotiationManager.java
71.08% <ø> (-22.90%)
:arrow_down:

...and/handlers/DeclineNegotiationCommandHandler.java
0.00% <0.00%> (ø)

...actnegotiation/ContractNegotiationServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...r/transfer/process/TransferProcessManagerImpl.java
24.67% <ø> (-63.64%)
:arrow_down:

...t/spi/types/command/DeclineNegotiationCommand.java
0.00% <0.00%> (ø)

...act/spi/types/negotiation/ContractNegotiation.java
0.00% <0.00%> (ø)

.../main/java/org/eclipse/edc/spi/result/Failure.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/org/eclipse/edc/spi/query/SortOrder.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/org/eclipse/edc/policy/model/Rule.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 525 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Shouldn't we also verify in the ContractNegotiation APi controller tests that the decline transition was actually performed (or not, if not possible?) Also, I see that the result returned by ContractNegotiationService to the controller is ignored, which is not good.

Good catch, I actually forgot to register the command handler :sweat_smile:
The result returned by the ContractNegotiationService it is not ignored, if failed an exception is thrown through the .orElseThrow

Shouldn't we also verify in the ContractNegotiation APi controller tests that the decline transition was actually performed (or not, if not possible?) Also, I see that the result returned by ContractNegotiationService to the controller is ignored, which is not good.

Good catch, I actually forgot to register the command handler :sweat_smile:
The result returned by the ContractNegotiationService it is not ignored, if failed an exception is thrown through the .orElseThrow

Ah, should've read the entire line ... sry


Show display names for unknown users when splitting bill from a group chat

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/20966
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

[ ] Verify that no errors appear in the JS console

Create a group what with unknown users (type random emails)
Choose split pill from the group chat.
Choose an amount and confirm: make sure emails of the users are showing and the alternate text shows "Hidden".
Confirm splitting the bill and make sure it works.
Repeat the above from "Split bill" global button.

Offline tests

Create a group what with unknown users (type random emails)
Choose split pill from the group chat.
Choose an amount and confirm: make sure emails of the users are showing and the alternate text shows "Hidden".
Confirm splitting the bill and make sure it works.
Repeat the above from "Split bill" global button.

QA Steps

[ ] Verify that no errors appear in the JS console

Create a group what with unknown users (type random emails)
Choose split pill from the group chat.
Choose an amount and confirm: make sure emails of the users are showing and the alternate text shows "Hidden".
Confirm splitting the bill and make sure it works.
Repeat the above from "Split bill" global button.

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewing this PR today

@abdulrahuman5196 could you prioritize this review please since it fixes a deploy blocker?

@luacmartins Yes working on the review now.

@youssef-lr lint is failing.

@youssef-lr we also have conflicts now

Tests steps updated @abdulrahuman5196.

Thank you will continue testing

@abdulrahuman5196 what's the latest here?

Yea, I don't think that's caused by these changes.

@luacmartins  could you kindly check if you are able to reproduce the issue now in staging? I have been trying to and not able to reproduce the exact issue in staging currently.

I'm able to reproduce this in staging as well.

@youssef-lr  Sorry for the confusion. I meant the current issue we are dealing with "Show display names for unknown users when splitting bill from a group chat". I couldn't repro this issue now in staging.

Yeah a similar fix got deployed (which caused the previous conflicts) but this PR now adds the "Hidden" alternateText as well as DRYs up code.
For the other issue you mentioned, yeah it's happening in staging as well, that is inviting users from outside the group:

We fixed the main issue in another PR, but this PR is doing some refactoring of the code and adding the Hidden text to options

Got it thanks. I was unaware the original fix was pushed. 😶🌫

This seems to break once the unknown user adds a display name, which means we no longer can send the email to the command. I'm not sure how to fix this unless we change the backend to take accountIDs instead of emails. What do you think @luacmartins?

Also I'm not sure why this isn't failing gracefully, I can see in the backend we're sending this which is causing the error:
$additionalUpdates = [
    [
        'onyxMethod' => Onyx::METHOD_MERGE,
        'key' => OnyxKeys::COLLECTION_REPORT_ACTIONS.$reportID,
        'value' => [
            $reportActionID => null,
            $split['reportActionID'] => null,
        ],
    ],
];

It should show up like this. Weird..let me try to reproduce

@youssef-lr Gentle ping. Was it reproducible at your end as well? (I am actually waiting on your response, sorry to rush)

So the 'hidden' text is not shown currently at your end as well and you are debugging it?

I mean I'm not able to reproduce, I can see "Hidden".

Could you kindly share a video? I will try to reproduce the same steps? I have been trying for sometime and i don't see the 'hidden' text itself.
There is no videos added in the author's checklist as well.

Do I need to be part of some beta or any restrictions?

No you don't need to. Let me get you a screen recording.

The flow is still broken though...we're currently discussing not allowing these flows unless the user is known.
Uploading Screen Recording 2023-06-20 at 20.41.47.mov…

The flow is still broken though...we're currently discussing not allowing these flows unless the user is known.
Uploading Screen Recording 2023-06-20 at 20.41.47.mov…

@youssef-lr the video wasn't upload actually 🤕

@youssef-lr
Even with a fresh account, I tested again and still unable to reproduce the 'hidden' text. I am always having personalDetails for the account and login in the personalDetails. If I only manually remove the userlogin from code I am able to reproduce the 'hidden' text. I tried offline case as well and the same is happening.
alternateText: userLogin || Localize.translateLocal('common.hidden'),

https://github.com/Expensify/App/assets/46707890/34a5ae7a-d0d7-40a9-b66d-c3de1c192c85
@youssef-lr  Could you kindly add videos from you end as well on author's checklist?
@luacmartins  Could you kindly provide a lending hand here? I am unable to reproduce this fix itself, the hidden text is not coming up for me. Have been trying it for multiple times in different ways but still the same, no 'hidden' text.

:ribbon: :eyes: :ribbon: C+ reviewed

@youssef-lr we have conflicts again

Also, I don't think we need to cp this anymore.

@youssef-lr  I am still unable to reproduce the 'Hidden' text in locally setup. I can even see the first time chatting message but the 'hidden' text never came for me.
https://github.com/Expensify/App/assets/46707890/437fbfbd-acc0-41e2-8930-ba045117bcd6
I have reached out in slack to see if anyone else is able to reproduce the fix? https://expensify.slack.com/archives/C02NK2DQWUX/p1687337166852319
Other questions
Q1) Meanwhile, could you kindly add the platform videos in the author's checklist?
Q2) Could this be the reason i am not able to repro the fix?

The flow is still broken though...we're currently discussing not allowing these flows unless the user is known.

@abdulrahuman5196 I can test this just fine. Not sure why it's not working for you

@youssef-lr  And was this verified at offline end? In offline case this won't work since we are setting optimistic login still.
But as soon as we come online it will change to show 'hidden', would we fix it part of this PR?
https://github.com/Expensify/App/assets/46707890/c8320cef-6bbe-4d2c-ac03-372c5c85fd8b

@abdulrahuman5196 I think it's fine..it just occurred to me to implement an improvement here, which is if the user hasn't set a display name, let's just display the email in the alternateText, because we're already showing it any way and there's really nothing to "hide", we only need to hide the email/alternateText when the user has a display name. What do you think @luacmartins?

This crashes for me with the following steps:

Create gmail and expensifail accounts
With an expensifail account, create a group inviting all accounts created in the step before
Log in with a gmail account of the group and set a display name
With the expensifail account that created the group, try to create a split bill
Crash:

What's the status on this one?

@youssef-lr do we still need this PR?

@luacmartins I think we don't since SpitBil is kind of broken with unknown users. Should we close?

Yes, let's just close this. Sorry it took so much time and effort for no gain in the end.

No worries!


Laravel 11 support

@Tarpsvo Could you merge the PR #19 for Laravel 11 support? Thanks!

Heya! Removed the Laravel version restriction and kept the default Nova version restriction. It should work now. :) Good luck!


gulp build is not building semantic.min.css

In a fresh installation i am running "gulp build" but in the "dist" folder is not present semantic.min.css, theres only the semantic.min.js,  "components" and "themes" folder.

In gulp-clone v2+, this seems to happen again!

@jjshammas that's correct. The change they did was shifted from breaking 1.0 to 2.0. Semantic still uses v1 https://github.com/Semantic-Org/Semantic-UI/blob/5b681ca84e756d0d6080ecc6a3e2cdd40c0e3d50/package.json#L58

Would someone mind adding the version constraint to the gulp-clone peer dependency as well?

I had the same issue
I solved it by changing the build-css gulp task.
In file tasks/build/css.js in semantic folder, remove the following line
compressedStream = stream.pipe(clone());

Problem is still here, this solved the issue.

@jlukic Looks like this problem is back, as "gulp-clone": "^2.0.1", was updated. Shouldn't this issue be reopened?

Having the same problem.

Same issue happening

Was just having the same issue as well, and can confirm that the change applied in himanshu230's PR (#6631) fixes the problem.

Was just having the same issue as well, and the change applied in himanshu230's PR (#6631) fixes the problem for me.

yep, me too,

How to import semantic.min.js i get error at line 11.
after that, i install jquery and import in index.js but nothing works
import * as $ from "jquery"
import "./semantic/dist/semantic.min.js"

this issue should be re-opened

yeah i got same problem, its doesnt build semantic.min.css

Fixed in 2.4.2 patch


Visual bug - red screen

Describe the bug
The right half of the Runelite screen is red tinted. This only happens on Runelite and not the normal osrs client. I have tried uninstalling and reinstalling the client and clearing the cache.
To Reproduce
Steps to reproduce the behavior:
Every time I open Runelite and play the game.
Expected behavior
I expect this to be normal coloring.
Screenshots

Environment (please complete the following information):

OS: Windows
RuneLite version: 1.6.31
Launcher version: 2.1.5

To fix right now, choose a different mode for UI Scaling (not Bilinear or Nearest Neighbor)

That worked. Thank you Hydrox

fixed in ad4d1787a15a733ee2883c140055b0d53ba3f6a7


Include darwin-i386 symlinks in macos installs

See #18865. Cause is an OS install is, for some reason, causing VisIt to look for its binaries in darwin-i386 instead of darwin-x86_64. I think Rosetta may be cause. Maybe we should just create a symlink in the install point as part of our package so that when user's install VisIt, it can find its binary components through either path.
Alternatively, maybe we've got to fix logic in our launcher script to correctly assess architecture for these newer macOS OSs.

https://github.com/visit-dav/visit/blob/5515e8cab36a8225fdaa9db1ece81182efc05a0b/src/CMakeLists.txt#L877


Snap to grid when physics off

MOTIVATION
I am trying to make nodes snap to grid when moving dragging them around, but that does not seemed possible.
I was looking into network dragging event:
network.on('dragging', function (params) {
    // override canvas position with snap to grid logic
})

POSSIBLE FEATURE REQUEST
It could be somehow configurable in network configuration, probably it could be like this:
const networkConfig = {
  layout: {
    hierarchical: false,
    snapToGrid: false, <------- OR
    snapToGrid: {
      step: '5px', // This would make a 5px grid (invisible)
    },
  },
}

Here are some basic examples of what it look like: https://jqueryui.com/resources/demos/draggable/snap-to.html

Could it be possible to override with node position while dragging it?

@lauriskuznecovs I know this issue is now very old but was working on a project recently which also required this functionality, although its not possible within the existing event handlers I ended up overriding the interaction handler to achieve this functionality. Hope this helps anyone else looking to do the same.
var networkCurrentOnDrag = network.manipulation.interactionHandler.body.eventListeners.onDrag
network.manipulation.interactionHandler.body.eventListeners.onDrag = function(event) {
    if (this.drag.pinched === true) {
        return;
    }

        // remove the focus on node if it is focussed on by the focusOnNode
        this.body.emitter.emit("unlockNode");

        const pointer = this.getPointer(event.center);

        const selection = this.drag.selection;
    if (selection && selection.length && this.options.dragNodes === true) {
        this.selectionHandler.generateClickEvent("dragging", event, pointer);

        // calculate delta's and new location
        const deltaX = pointer.x - this.drag.pointer.x;
        const deltaY = pointer.y - this.drag.pointer.y;
        var moved = false

        // update position of all selected nodes
        selection.forEach((selection) => {
            const node = selection.node;
            // only move the node if it was not fixed initially
            if (selection.xFixed === false) {
                let x = Math.round( (this.canvas._XconvertDOMtoCanvas(this.canvas._XconvertCanvasToDOM(selection.x) + deltaX) ) / 24 ) * 24 ;
                if (node.x != x) {
                    node.x = x
                    moved = true
                }
            }
            // only move the node if it was not fixed initially
            if (selection.yFixed === false) {
                let y = Math.round( ( this.canvas._YconvertDOMtoCanvas(this.canvas._YconvertCanvasToDOM(selection.y) + deltaY) ) / 24 ) * 24;
                if (node.y != y) {
                    node.y = y
                    moved = true
                }
            }
        });

        if (moved) {
            this.selectionHandler.generateClickEvent("draggingStepped", event, pointer);
        }

        // start the simulation of the physics
        this.body.emitter.emit("startSimulation");
        return
    }
    networkCurrentOnDrag(event)
}.bind(network.manipulation.interactionHandler)


Export contains files that prevent import

The export of a directory maintained in Github contains the directory .git. This contains files or. MIME types that are blocked by SCORM (here: SCORM Cloud with Scorm2004 file format). These can prevent an import and must be removed manually in the created export file before import into SCORM/LMS.
Used command:
liaex -i README.md -o opensource -f scorm2004 --scorm-organization Dummy --scorm-typicalDuration PT0H015M0S

The following solutions would be conceivable:

Description of a recommended procedure that prevents the packing of unwanted or unauthorized files.
Support of a parameter that allows the exclusion of files and directories
support of an ignore file (for example .liaignore) which excludes files and directories for packing similar to a .gitignore file

Thanks for the report, I can confirm this and it should actually not happen. .git should actually be filtered and not included.
I tried this locally, this bug seems to appear, when you build the SCORM package from within the project-folder, you could try the following
liaex --input docs/README.md --path docs --format scorm2004
with the --path or -p option you can define the base-path for packaging. In this case the filter seems to work and hidden folders are not included ...
However, this needs to fixed ...

Ja, Angabe des Verzeichnisses hat geholfen. Mich hatte in dem Kontext allerdings verwirrt, das --path nicht die root für --input setzt und alle Angaben mit --path damit relativ werden...

hidden files and folders starting with a dot are now excluded by default from packing.


Enums parsing in hparams.yaml generated

What does this PR do?

Fixes #8912
Does your PR introduce any breaking changes? If yes, please list them.
NONE

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Yesss
Make sure you had fun coding 🙃

@grajat90 let's add a changelog entry too :)

@grajat90 let's add a changelog entry too :)

Hey sure
Also wanted some clarification:
The way omegaconf saves enum type hyperparams is it converts the chosen out of the enums to a string and just saves it as string. I’ve replicated the functionality. But I think it would be better if it were converted to a dict as you pointed out. What I’ve done locally to try out is created custom parsing for enums. I save the enum definition and recreate the enum when we load it back from the file, select the option from the enum and return it to the hparams object. Is this the approach I should pursue or just try to replicate how omegaconf does it?

As part of this latest commit, I have created custom parsing for enum type objects to store them in the hparams.yaml file as a dict. This is read back, the entire enum is recreated according to the definition, and is returned in the new object, thus retaining all enum based functionality that might be occurring in the model (using dot operator or any other enum special functions). This appears to be the best way to tackle it, please advice.

Hey if anyone can let me know if this is a better approach or the earlier approach, I can just drop the commit and we can continue with the previous method.

@grajat90 I do not know which one is better, I'm not familiar with this enum logic, but the current approach does not look right to me due to access to private member attributes.

@grajat90 I do not know which one is better, I'm not familiar with this enum logic, but the current approach does not look right to me due to access to private member attributes.

Same reason I was reluctant to go this route from the beginning. I think the way to do this would be to have it how omegaconf does it. Seams reasonable, and would be compatible if the hparams were loaded elsewhere in a separate codebase.
I've reverted it to how we were doing it before. This should be fixed as of this.

@omry What is the recommend way to save an Enum with OmegaConf  ? Mind quickly reviewing this PR ?

Hey @omry ! What is the recommend way to save an Enum with OmegaConf  ? Would you mind quickly reviewing this PR to ensure right direction ?

Can you give more details about what you are actually trying to achieve?
The way to serialize/deserialize Structured Config is with pickle. Converting to yaml does not retain any type information.


Create Recording Duration does not accept integer value

After installing Cryostat onto an OpenShift cluster off the v2 branch, attempting to create a recording from the Cryostat Operator will not accept any number in the "Duration" field of the Create Recording form view.

Install Cryostat onto your OpenShift cluster.
Log into your OpenShift cluster with Kubeadmin account.
Select "Installed Operators" in the left column in the "Operators" section.
Select "Cryostat".
Select Create instance under Recording.
Enter a number in the "Duration*" field. I entered "30".
Select state Running.
Leave everything else at the default and then hit create at the bottom.
Get an error:

   Fix the following errors:

    Error "Invalid value: "integer": spec.duration in body must be of type string: "integer"" for field "spec.duration".

In the duration field, does it accept the value if you enter "30" (with the quotes), so that the value is a string rather than being interpreted as numeric?

@andrewazores yes it does.

This should be changed to xDescriptors={"urn:alm:descriptor:com.tectonic.ui:text"}, and the expected format for the duration should be mentioned in the description. It's expected to be a string with a number and a unit, e.g. 30s 1h30m: https://pkg.go.dev/time#Duration


Cannot authenticate with spotify

I've created app on spotify dev, exactly as described (I was using other module to spotify and it worked). But when I click authorize I've get INVALID_TOKEN in response after allowing app to connect, second try to authorize just throws error.
My magic mirror is in docker environment if that means something.

Hi, Are you using the same token as the other module? You need to reauthenticate as the API scopes are probably different, even if it worked on the other module

Of course that I'm using new app. The error shows when I click on spotify
authorize green button, it redirects me to auth app, but without
authorization and refresh tokens. From this point I can only delete spotify
app and start from scratch, but it again fails.
pt., 20 wrz 2024 o 00:30 Fabrizio @.***> napisał(a):

Hi, Are you using the same token as the other module? You need to
reauthenticate as the API scopes are probably different, even if it worked
on the other module
—
Reply to this email directly, view it on GitHub
https://github.com/Fabrizz/MMM-OnSpotify/issues/78#issuecomment-2362312073,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOME4MXSWHHUVSOCE223A3LZXNGBXAVCNFSM6AAAAABOQ3DUWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGMYTEMBXGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thats strange, I just did it with an old app and it right away just worked, do you have the correct redirect?

I changed computer from witch I'm doing authorization and for my great
surprise it authorized from first try. My only issue now is that it works
only after restart of magic mirror container, after first refresh, next
reload of magic mirror and module is trying to connect to spotify, i've set
intervals like in github example.
pt., 20 wrz 2024 o 00:47 Fabrizio @.***> napisał(a):

Thats strange, I just did it with an old app and it right away just
worked, do you have the correct redirect?
—
Reply to this email directly, view it on GitHub
https://github.com/Fabrizz/MMM-OnSpotify/issues/78#issuecomment-2362330579,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOME4MWHUV3XP2GDMUFO6CDZXNIBDAVCNFSM6AAAAABOQ3DUWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGMZTANJXHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Its really strange as for a couple couple of users it just endlessly times out. What other modules do you have installed?

i think i have the same issue, is ther any solution?
after auth with spotify im gettign this error:

Step 2: Something went wrong!
Did you give permission to the app? If not you will not be able to use this module with your MagicMirror unless you authorize the app. (Click this red card to restart the tool)


[KTLN-563] Add code for Spring Boot Testing

Going to close & re-open the PR to re-trigger the build, as it looks like it just timed out.


how to install restclient-cpp on windows?

how to install restclient-cpp on windows?

there are no packages provided for windows but you can build it the same as any autotools project https://github.com/mrtazz/restclient-cpp#installation


🐛 fix(button): labels will break in groups when there is not enough space

:rocket: Welcome to Baloise ChatOps based GitOps Bot :tada:
- If you want to enable preview environments for this PullRequest, comment with `/preview`.
- If you want to disable the preview environment for this PR, comment with `/undeploy`.
- If you need help or want to see the docs, comment with `/help`.

Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:


feat(vendor,Makefile,cmd): add vendor, Makefile, xgboost-operator/main.go

What this PR does / why we need it:
adapt the repos to caicloud style, add  xgboost-operator/main.go for cmd/manager/main.go may make conflict with other ops runnning in kube-system
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @codeflitting @gaocegege

Release note:

NONE

We should disable the travis build.


feat: bump hdwallet packages to latest

Current dependencies on/for this PR:

main

PR #1222   👈

This comment was auto-generated by Graphite.


Replace stub with TaskQueue client

This allows the datastore to make TaskQueue service requests without importing AppServer code.
These changes make progress toward #2740

https://ocd.appscale.com:8080/job/Daily Build/5031/
The demo is that the Java taskqueue_tests.TransactionalTaskTest succeeded: https://ocd.appscale.com:8080/job/Hawkeye/14531/artifact/hawkeye-logs/java-detailed 2018-05-16 14-50-21.log (line 2888)


Active tab change icon and text color

Hi, is there a way to change the active tab icon and text color? thanks
tried using there css code but no luck.
 .tabs-ios {         a[aria-selected=false] {             .tab-button-icon[ng-reflect-name=search], .tab-button-icon[aria-label="search outline"] {                 background-image: url(../assets/icon/tabNew1.png);             }         a[aria-selected=true] {                   .tab-button-icon[ng-reflect-name=search], .tab-button-icon[aria-label=search] {                 background-image: url(../assets/icon/tabNew1-active.png);             }     }

https://github.com/zyra/ionic2-super-tabs/blob/master/README.md#colors
See the example, if that's what you're looking for

Are you asking how to set a custom colour for active tabs (that is different than the rest)? or how to customize the colours globally?

@ihadeed yes i'm asking how to set custom color for the text for  active tab(that is different than the rest).. not globablly

That would be a new feature that we need to add.

I don't know if you still have this problem, but if anyone else needs it
.selected {
    color: map_get($colors, primary) !important;
  }

  super-tab-button {
    color: white;
  }

When the tab is selected, a css class called .selected is added to the tab button, só just add the code above in your css file, but is important not set the toolbarColor property in the Super Tabs component


Examples of Mustache Template

Some examples of Mustache templates (Markdown, BBCode, HTML, ...) should be accessible from the UI.

The Mustache Generator is not anymore the primary goal of this application. This is suspended, and I'll look into it if there is demand.


fix(kit): put tui-island_transparent after tui-island_hoverable

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?
Closes #2909
What is the new behavior?
tui-island_transparent has precedence over tui-island_hoverable.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Hey! This fix is unstable, probably it's better to use !important instead of reordering.

@ddubrava please, rebase


Ensure tests (at least before release) run against a clean environment generated by installing the bdist_wheel.

Issue description / feature objectives
Currently the tests today run using the copy of trestle in the dev tree. This creates issues as packaging may exclude files. Final testing should be performed (at least once) against the bdist_wheel object or similar. Given trestle is pure python and cross platform testing this way for one environment will be sufficient.
tox is a wrapper on python testing frameworks designed to ensure testing is performed against the distributed package. Examine tox an introduce, as appropriate, throughout the testing lifecycle.
Caveats / Assumptions

Based on our current implementation it may make sense to incrementally adopt tox.
Tox is just something that we know may work.
Will require fiddling with other config files.

Completion Criteria

Tox is used at least once before release to test packaged content throughout the CI. Other tools can be substituted if tox is not appropriate.

Tox was found to increase complexity. Taken a 'buiild you own' approach.


Globable recordings

One can now pass globs when targeting recordings. It is still allowed to
have multiple entries. If an entry contains a globlike character the
program will first expand the glob.
Why? If you happen to have e.g several har files spread out across directories, globbing can be used to include them all when running the program
This commit probably works on its own.
However I tested it with mostly with #10. So could be good to merge that first.

This seems to be a super-set of #10? Since there is no functional content in the PR description, it's hard to know which commit it refers to?

globbing can be used to include them all when running the program

Globbing is normally performed by your shell before apidelta is executed. Under what circumstance will there not be a shell involved?

That's true, this PR is actually not needed!


Build from source - errors

Is node-sass needed? Building it makes installation problematic. sass should be enough
There is no docs about building
Build is failing with:

0 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'build' ]
1 info using<EMAIL_ADDRESS>2 info using<EMAIL_ADDRESS>3 timing config:load:defaults Completed in 3ms
4 timing config:load:file:/usr/lib/node_modules/npm/npmrc Completed in 0ms
5 timing config:load:builtin Completed in 0ms
6 timing config:load:cli Completed in 2ms
7 timing config:load:env Completed in 1ms
8 timing config:load:file:/srv/spearmint/.npmrc Completed in 2ms
9 timing config:load:project Completed in 2ms
10 timing config:load:file:/home/tczech/.npmrc Completed in 0ms
11 timing config:load:user Completed in 0ms
12 timing config:load:file:/usr/etc/npmrc Completed in 1ms
13 timing config:load:global Completed in 1ms
14 timing config:load:cafile Completed in 0ms
15 timing config:load:validate Completed in 0ms
16 timing config:load:setUserAgent Completed in 1ms
17 timing config:load:setEnvs Completed in 1ms
18 timing config:load Completed in 11ms
19 verbose npm-session ae0c8209f7a9e7df
20 timing npm:load Completed in 19ms
21 timing command:run Completed in 418698ms
22 verbose stack Error: command failed
22 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/index.js:64:27)
22 verbose stack     at ChildProcess.emit (node:events:378:20)
22 verbose stack     at maybeClose (node:internal/child_process:1067:16)
22 verbose stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
23 verbose pkgid<EMAIL_ADDRESS>24 verbose cwd /srv/spearmint
25 verbose Linux 5.9.16-1-MANJARO
26 verbose argv "/usr/bin/node" "/usr/bin/npm" "run" "build"
27 verbose node v15.11.0
28 verbose npm  v7.6.3
29 error code 1
30 error path /srv/spearmint
31 error command failed
32 error command sh -c NODE_ENV=production npm run react-build && npm run electron-build
33 verbose exit 1

Hi @Tymek,
Thanks for the message. You make a great point. We'll look in to this, and get back to you!

Hi @Tymek,
Sorry for the delay. Lots of stuff going on behind the scenes! We've reviewed the issue that you flagged, and have decided to move from node-sass to dart-sass. Will be included in the next major release of Spearmint, scheduled for May 13, 2021. Let us know if this helps fix the error.
All the best,
-tHe SpEaRmInT tEaM

Updated debug log for v0.6.0:

click to open
0 verbose cli [ 0 verbose cli   '/usr/bin/node', 0 verbose cli   '/usr/lib/node_modules/npm/bin/npm-cli.js',...

0 verbose cli [
0 verbose cli   '/usr/bin/node',
0 verbose cli   '/usr/lib/node_modules/npm/bin/npm-cli.js',
0 verbose cli   'rebuild',
0 verbose cli<EMAIL_ADDRESS>0 verbose cli<EMAIL_ADDRESS>0 verbose cli ]
1 info using<EMAIL_ADDRESS>2 info using<EMAIL_ADDRESS>3 timing npm:load:whichnode Completed in 1ms
4 timing config:load:defaults Completed in 2ms
5 timing config:load:file:/usr/lib/node_modules/npm/npmrc Completed in 1ms
6 timing config:load:builtin Completed in 1ms
7 timing config:load:cli Completed in 2ms
8 timing config:load:env Completed in 2ms
9 timing config:load:file:/srv/oss/spearmint/.npmrc Completed in 0ms
10 timing config:load:project Completed in 0ms
11 timing config:load:file:/home/tczech/.npmrc Completed in 0ms
12 timing config:load:user Completed in 1ms
13 timing config:load:file:/usr/etc/npmrc Completed in 0ms
14 timing config:load:global Completed in 0ms
15 timing config:load:validate Completed in 1ms
16 timing config:load:credentials Completed in 1ms
17 timing config:load:setEnvs Completed in 1ms
18 timing config:load Completed in 11ms
19 timing npm:load:configload Completed in 11ms
20 timing npm:load:setTitle Completed in 1ms
21 timing npm:load:setupLog Completed in 1ms
22 timing npm:load:cleanupLog Completed in 4ms
23 timing npm:load:configScope Completed in 0ms
24 timing npm:load:projectScope Completed in 0ms
25 timing npm:load Completed in 18ms
26 timing config:load:flatten Completed in 2ms
27 timing arborist:ctor Completed in 1ms
28 timing arborist:ctor Completed in 0ms
29 timing build:queue Completed in 1ms
30 info run<EMAIL_ADDRESS>install node_modules/fibers node build.js || nodejs build.js
31 info run<EMAIL_ADDRESS>install node_modules/node-pty node scripts/install.js
32 info run<EMAIL_ADDRESS>install { code: 1, signal: null }
33 timing command:rebuild Completed in 2642ms
34 verbose stack Error: command failed
34 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/index.js:64:27)
34 verbose stack     at ChildProcess.emit (node:events:365:28)
34 verbose stack     at maybeClose (node:internal/child_process:1067:16)
34 verbose stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
35 verbose pkgid<EMAIL_ADDRESS>36 verbose cwd /srv/oss/spearmint
37 verbose Linux 5.9.16-1-MANJARO
38 verbose argv "/usr/bin/node" "/usr/lib/node_modules/npm/bin/npm-cli.js" "rebuild"<EMAIL_ADDRESS><EMAIL_ADDRESS>39 verbose node v16.0.0
40 verbose npm  v7.11.2
41 error code 1
42 error path /srv/oss/spearmint/node_modules/node-pty
43 error command failed
44 error command sh -c node scripts/install.js
45 error sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
45 error gyp info it worked if it ends with ok
45 error gyp info using<EMAIL_ADDRESS>45 error gyp info using<EMAIL_ADDRESS>| linux | x64
45 error gyp info find Python using Python version 3.9.4 found at "/usr/bin/python3"
45 error (node:231136) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
45 error (Use `node --trace-deprecation ...` to show where the warning was created)
45 error gyp info spawn /usr/bin/python3
45 error gyp info spawn args [
45 error gyp info spawn args   '/srv/oss/spearmint/node_modules/node-gyp/gyp/gyp_main.py',
45 error gyp info spawn args   'binding.gyp',
45 error gyp info spawn args   '-f',
45 error gyp info spawn args   'make',
45 error gyp info spawn args   '-I',
45 error gyp info spawn args   '/srv/oss/spearmint/node_modules/node-pty/build/config.gypi',
45 error gyp info spawn args   '-I',
45 error gyp info spawn args   '/srv/oss/spearmint/node_modules/node-gyp/addon.gypi',
45 error gyp info spawn args   '-I',
45 error gyp info spawn args   '/home/tczech/.electron-gyp/12.0.7/include/node/common.gypi',
45 error gyp info spawn args   '-Dlibrary=shared_library',
45 error gyp info spawn args   '-Dvisibility=default',
45 error gyp info spawn args   '-Dnode_root_dir=/home/tczech/.electron-gyp/12.0.7',
45 error gyp info spawn args   '-Dnode_gyp_dir=/srv/oss/spearmint/node_modules/node-gyp',
45 error gyp info spawn args   '-Dnode_lib_file=/home/tczech/.electron-gyp/12.0.7/<(target_arch)/node.lib',
45 error gyp info spawn args   '-Dmodule_root_dir=/srv/oss/spearmint/node_modules/node-pty',
45 error gyp info spawn args   '-Dnode_engine=v8',
45 error gyp info spawn args   '--depth=.',
45 error gyp info spawn args   '--no-parallel',
45 error gyp info spawn args   '--generator-output',
45 error gyp info spawn args   'build',
45 error gyp info spawn args   '-Goutput_dir=.'
45 error gyp info spawn args ]
45 error /bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
45 error gyp: Call to 'node -e "require('nan')"' returned exit status 0 while in binding.gyp. while trying to load binding.gyp
45 error gyp ERR! configure error
45 error gyp ERR! stack Error: `gyp` failed with exit code: 1
45 error gyp ERR! stack     at ChildProcess.onCpExit (/srv/oss/spearmint/node_modules/node-gyp/lib/configure.js:351:16)
45 error gyp ERR! stack     at ChildProcess.emit (node:events:365:28)
45 error gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
45 error gyp ERR! System Linux 5.9.16-1-MANJARO
45 error gyp ERR! command "/usr/bin/node" "/srv/oss/spearmint/node_modules/.bin/node-gyp" "rebuild"
45 error gyp ERR! cwd /srv/oss/spearmint/node_modules/node-pty
45 error gyp ERR! node -v v16.0.0
45 error gyp ERR! node-gyp -v v7.1.2
45 error gyp ERR! not ok
46 verbose exit 1


Complete support of callables of static methods

We now have the possibility of creating a callable out of a static function, but it had a couple of flaws:

Since the MessageQueue checks for the target object being non-null, push_callable() wouldn't work with static calls. Upon reaching the corresponding call during a flush it would just be skipped. In other words, callable_mp_static(&SomeClass::some_static_function).call_deferred(); is helpless.
There's the concept of a valid callable. The only implementation was in Callable::is_valid(), enforcing that at least the object was non-null. Therefore, the custom callables implementing static calls (CallableCustomStaticMethodPointer*), that have a null target object by nature, wouldn't be able to claim themselves as valid.

This PR improves the situation by doing the following, respectively:

Enhances the MessageQueue so it remembers if the Callable backing a call message was originally a Callable, in which case it will accept a null target object as long as the callable validation tells that's OK.
Allows the custom callables to perform the kind of validation that make sense for each, with a reasonable default implementation.

This changes are needed for #71280 and #71644, where callables to static methods are used.
This is ready for review, but I'll tag it as Needs testing until I'm sure it won't cause regressions.

I think this is already enough smoke tested.

I didn't succeed in getting this reviewed in time so I'm moving it to 4.1, though if reduz gets to check it and approved, it could still be merged in 4.0 before RC 3 (Monday), as it looks fairly safe to me.

I forgot to check this before.
Looks ok, but it doesn't work in GDScript, so I didn't test the functionality itself. But it doesn't cause obvious new regressions.

Rebased on top of 4.1.

I'm rebasing it for 4.1. For 4.0 I've kept the original changes in #75994.

Thanks!


Bump StbImage version & use new API

Resolves #29:

Upgrade StbImage dep and utilize new API in the Caltech101 dataset module.

Beautiful! ❤  It would be awesome if you could ship a new version too, remember to mix deps.update ex_doc before!


Dependency issue with psisloo function

Whey I try to use compare in :psis mode, I get
UndefVarError: psisloo not defined

Stacktrace:
 [1] compare(m::Vector{Matrix{Float64}}, ::Val{:psis}; mnames::Vector{String})
   @ StatisticalRethinking ~/.julia/packages/StatisticalRethinking/Uy2Qf/src/compare_models.jl:82
 [2] compare(m::Vector{Matrix{Float64}}, type::Symbol; mnames::Vector{String})
   @ StatisticalRethinking ~/.julia/packages/StatisticalRethinking/Uy2Qf/src/compare_models.jl:132
 [3] compare(m::Vector{Matrix{Float64}}, type::Symbol)
   @ StatisticalRethinking ~/.julia/packages/StatisticalRethinking/Uy2Qf/src/compare_models.jl:132
 [4] top-level scope
   @ In[92]:1
 [5] eval
   @ ./boot.jl:360 [inlined]
 [6] include_string(mapexpr::typeof(REPL.softscope), mod::Module, code::String, filename::String)
   @ Base ./loading.jl:1116

I found this function in ParetoSmoothedImportanceSampling.jl, but we should have it in dependecies list.

I remember you mentioned about ParetoSmooth migration. So, better fix will be to port compare to ParetoSmooth, right?

Hi Max, also noted your 2 other issues on ParetoSmoothedImportanceSampling.jl.
All of this is changing with the recent release of a new package ParetoSmooth.jl. I haven't had time to update the :psis compare function in StatisticalRethinking.jl (which will look similar to waic, as in the book).
I did help on the loo_compare() in ParetoSmooth and there is an example of combining Turing.jl and ParetoSmooth.jl in ParetoSmooth's test suite (based on WaffleDivorce in fact). I did something similar for the Stan side (for now in the SR test suite).
The current state of affairs is:

ParetoSmoothedImportanceSampling.jl is deprecated and in SR v3.1 replaced by StatsModelComparisons.jl.

In v4 StatsModelComparisons.jl will be replaced by ParetoSmooth.jl (but this is not complete yet).

With the exception of the parameter penalty terms, all info for the :psis version is easily accessible from ParetoSmooth.jl (see the examples in the test script mentioned above).

Currently I am updating quadratic approximation stuff in SR, including the sample() function, as this was also updated in Turing. Most of this will move to StanQuap.jl but for Turing we do need the sample(::ModeResult) method. As soon as that is done I'll start working on the :psis part of compare.

Not ideal, but I can see the light at the end of the tunnel.

Hi Max (@Shmuma),
Oops, didn't see your 2nd comment. Yes, we should go the ParetoSmooth route and, as mentioned above, I already did some preliminary work. Any help would definitely be appreciated!
Also, on the other point I raise in my previous comment (item 4), what's your thinking about the sample(::ModeResult) function I noticed in your chapter 7 notebook, i.e. should sample() return a DataFrame or a Chain object (in Turing that would be an MCMCChains.Chain object, in StanQuap.jl sample(::QuapResult) would in that case return a KeyedArray chain object)?
Or do you think a DataFrame suffices? Of course, using the Tables API the chains are easy to convert in a DataFrame.

Great!
FYI: There is also an ongoing discussion here about cutting back the dependencies of ParetoSmooth.jl to reduce compile time. That has never been a goal of mine but just wanted to mention it in light of this discussion. At some point we might have to switch to a new package LeaveOneOut.jl or so.
In your sample()method, you do something like:
function sample(qr::QuapResult, count::Int)::DataFrame
    names = qr.params # coefnames(mode_result) in Turing
    means = values(qr.coef) # coef(mode_result) in Turing
    sigmas = Diagonal(qr.vcov) # stderror(mode_result) in Turing

    DataFrame([
        name => rand(Normal(μ, σ), count)
            for (name, μ, σ) ∈ zip(names, means, sigmas)
    ])
end

In creating the QuapResult object I use:
    ...
    distr = if size(vcov, 1) == 1
        Normal(coefvalues[1], √vcov[1]) # Normal expects std
    else
        MvNormal(coefvalues, vcov) # MvNormal expects variance matrix
    end
    ...

I wonder if this should also happen in sample()? But maybe this is taken care off in StatsBase.stderror?

Checked the latest version of the package and this function now working. Thanks a lot!
Now I can finish the chapter 7 notebook (which took me 1.5 months to complete), wheee!


HADOOP-16854. ABFS: Fix for the OutOfMemoryException in AbfsOutputStream

2014

 Quality gate: Failed
46 Issues

 4 Vulnerabilities
 42 Code issues

Details


Fixed reconnect after close

Closes #1374.

This change is

PR is added to the queue for testing as 1. task. (c49686b)

Test 100139766 (c49686b) build started.

Test (Fail) 100139766 build is completed (c49686b)
See https://github.com/ThaliTester/TestResults/tree/100139766c49686b_Fixed_reconnect_after_close_andrew-aladev/ for the logs

PR is added to the queue for testing as 1. task. (aeece48)

Test 100139766 (aeece48) build started.

Test (Success) 100139766 build is completed (aeece48)
See https://github.com/ThaliTester/TestResults/tree/100139766aeece48_Fixed_reconnect_after_close_andrew-aladev/ for the logs

Test 100139766aeece48(aeece48) has failed
See https://github.com/ThaliTester/TestResults/tree/100139766aeece48_Fixed_reconnect_after_close_andrew-aladev/ for the fail logs

Reviewed 1 of 3 files at r1.
Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 93 at r2 (raw file):

          if (retryIndex >= RETRY_COUNT) {
            var error = 'Too many connect retries';

Variable error is already declared.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 179 at r2 (raw file):

      }

      var port = new Number(listeningPort);

NB: Can't we just use parseInt ?

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 188 at r2 (raw file):

        listeningPort: port
      });
    }

missing semicolon

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 196 at r2 (raw file):

        if (error) {
          var error = new Error(format(

var error is already declared.

Comments from Reviewable

Reviewed 1 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

PR is added to the queue for testing as 2. task. (07b9425)

Test 100139766 (07b9425) build started.

Test (Fail) 100139766 build is completed (07b9425)
See https://github.com/ThaliTester/TestResults/tree/10013976607b9425_Fixed_reconnect_after_close_andrew-aladev/ for the logs

PR is added to the queue for testing as 1. task. (3e3ec72)

Test 100139766 (3e3ec72) build started.

Test (Fail) 100139766 build is completed (3e3ec72)
See https://github.com/ThaliTester/TestResults/tree/1001397663e3ec72_Fixed_reconnect_after_close_andrew-aladev/ for the logs

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

Please fix comments and then

Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 4 at r3 (raw file):

var util   = require('util');
var format = util.format;

Why not get rid of the previous line and just use var format = require('util').format?

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 65 at r3 (raw file):

function connectToPeer(peer, quitSignal) {
  var connectMethod;
  if (platform.isAndroid) {

Why are we using cascading if statements? This is what switch was invented for.

Comments from Reviewable

PR is added to the queue for testing as 1. task. (0cd47bd)

Test 100139766 (0cd47bd) build started.

Review status: all files reviewed at latest revision, 6 unresolved discussions.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 93 at r2 (raw file):
Previously, jareksl (Jarosław Słota) wrote…
Variable error is already declared.

Done.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 179 at r2 (raw file):
Previously, jareksl (Jarosław Słota) wrote…
NB: Can't we just use parseInt ?

Done.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 188 at r2 (raw file):
Previously, jareksl (Jarosław Słota) wrote…
missing semicolon

Done.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 196 at r2 (raw file):
Previously, jareksl (Jarosław Słota) wrote…
var error is already declared.

Done.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 4 at r3 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
Why not get rid of the previous line and just use var format = require('util').format?

Done.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 65 at r3 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
Why are we using cascading if statements? This is what switch was invented for.

But we have no value for switch, we have only several bools.

Comments from Reviewable

Test (Fail) 100139766 build is completed (0cd47bd)
See https://github.com/ThaliTester/TestResults/tree/1001397660cd47bd_Fixed_reconnect_after_close_andrew-aladev/ for the logs

PR is added to the queue for testing as 1. task. (107e6bf)

Test 100139766 (107e6bf) build started.

Test (Fail) 100139766 build is completed (107e6bf)
See https://github.com/ThaliTester/TestResults/tree/100139766107e6bf_Fixed_reconnect_after_close_andrew-aladev/ for the logs

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 65 at r3 (raw file):
Previously, andrew-aladev (Andrew Aladjev) wrote…
But we have no value for switch, we have only several bools.

Which argues that we should change platform to return an enum because you have to admit this code looks pretty silly. But we can fix that later.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

test/www/jxcore/lib/thaliMobileNativeTestUtils.js, line 65 at r3 (raw file):
Previously, yaronyg (Yaron Y Goland) wrote…
Which argues that we should change platform to return an enum because you have to admit this code looks pretty silly. But we can fix that later.

Ok

Comments from Reviewable


Use the new electron.Notification API

https://github.com/electron/electron/blob/a6ea316a5de1964761a82d9376c23e99eff16d25/docs/api/notification.md

Maybe use the new API here too? https://github.com/wulkano/kap/blob/master/app/src/main/share-service.js#L82

Maybe use the new API here too? https://github.com/wulkano/kap/blob/master/app/src/main/share-service.js#L82

Done


Adds Compression options to the TextureWriter node

TextureWriter node now has "Compression" input
Moved the native .dll to the correct architecture specific folder
Added overload for WriteTexture that takes a ReadOnlySpan<byte> to allow for less allocations in certain cases
LoadFromPath now works without the need for a commandlist, allowing it to be called concurrently

It looks good, so merged. I'll pusblish nuget later as well. Thanks for the great PR!