feat(avm): variants for MOV opcode

Not ready for review. Still an experiment.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8440  👈
#8439
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 786 (-45%)
avm_simulation_time_ms (Token:mint_public): 64.6 (+48%)
avm_simulation_time_ms (Token:transfer_public): 40.8 (+63%)
avm_simulation_bytecode_size_in_bytes (Token:constructor): 10,658 (-18%)
avm_simulation_bytecode_size_in_bytes (FPC:constructor): 6,144 (-21%)
avm_simulation_bytecode_size_in_bytes (FPC:prepare_fee): 3,089 (-21%)
avm_simulation_bytecode_size_in_bytes (Token:transfer_public): 7,401 (-17%)
avm_simulation_bytecode_size_in_bytes (FPC:pay_refund): 3,911 (-19%)
avm_simulation_bytecode_size_in_bytes (Benchmarking:increment_balance): 2,620 (-16%)
avm_simulation_bytecode_size_in_bytes (FPC:pay_refund_with_shielded_rebate): 3,911 (-19%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,753
1,547
706 (+2%)
758 (+2%)
776 (+1%)

proof_construction_time_sha256_30_ms
11,497
3,056
1,364
1,418
1,464

proof_construction_time_sha256_100_ms
45,254
11,760
5,860 (+7%)
5,889 (+9%)
5,355 (+1%)

proof_construction_time_poseidon_hash_ms
78.0 (-1%)
34.0
34.0
58.0
87.0

proof_construction_time_poseidon_hash_30_ms
1,530
420 (+1%)
201 (+1%)
221
269

proof_construction_time_poseidon_hash_100_ms
5,642
1,503
671 (+1%)
740 (+4%)
747 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,356
7,876
14,884

l1_rollup_calldata_gas
50,064
92,886
177,976

l1_rollup_execution_gas
842,905
1,576,623
3,361,769

l2_block_processing_time_in_ms
256 (+8%)
446 (+3%)
814 (+3%)

l2_block_building_time_in_ms
11,546 (-1%)
22,957 (+1%)
45,027 (-2%)

l2_block_rollup_simulation_time_in_ms
11,546 (-1%)
22,957 (+1%)
45,027 (-2%)

l2_block_public_tx_process_time_in_ms
9,862 (-2%)
21,228 (+1%)
43,297 (-3%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
3,368 (-1%)
4,379 (+7%)

node_database_size_in_bytes
14,217,456
18,239,728

pxe_database_size_in_bytes
16,258
26,818

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
input_size_in_bytes
output_size_in_bytes
proving_time_in_ms

private-kernel-init
71.2 (-5%)
377 (-2%)
21,099
44,933
N/A

private-kernel-inner
138 (-1%)
677 (-1%)
71,847
45,067
N/A

private-kernel-reset-tiny
294 (+3%)
663 (-1%)
64,687
44,922
N/A

private-kernel-tail
150 (+1%)
129 (+1%)
50,553
56,996
N/A

base-parity
5.53
N/A
160
96.0
N/A

root-parity
35.3
N/A
73,948
96.0
N/A

base-rollup
2,624
N/A
189,124
664
N/A

block-root-rollup
41.5 (+1%)
N/A
58,205
2,448
N/A

public-kernel-setup
82.7 (-1%)
N/A
114,173
79,414
N/A

public-kernel-app-logic
96.5
N/A
113,991
79,414
N/A

public-kernel-tail
857
N/A
497,078
16,414
N/A

private-kernel-reset-small
270
N/A
66,341
45,629
N/A

private-kernel-tail-to-public
:warning: 786 (-45%)
587
448,133
1,825
N/A

public-kernel-teardown
82.3 (-1%)
N/A
114,437
79,414
N/A

merge-rollup
20.8 (+1%)
N/A
38,174
664
N/A

undefined
N/A
N/A
N/A
N/A
83,004 (-2%)

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms

ContractClassRegisterer:register
1,344
11,731
341 (+1%)

ContractInstanceDeployer:deploy
1,408
11,731
18.0

MultiCallEntrypoint:entrypoint
1,920
11,731
418

FeeJuice:deploy
1,376
11,731
388 (+1%)

SchnorrAccount:constructor
1,312
11,731
60.5 (-1%)

SchnorrAccount:entrypoint
2,336
11,731
373 (+2%)

FeeJuice:claim
1,344
11,731
34.6 (+2%)

Token:privately_mint_private_note
1,280
11,731
71.2 (+8%)

FPC:fee_entrypoint_public
1,344
11,731
27.3 (+15%)

Token:transfer
1,312
11,731
210

Benchmarking:create_note
1,344
11,731
76.4 (+2%)

SchnorrAccount:verify_private_authwit
1,280
11,731
28.6 (+9%)

Token:unshield
1,376
11,731
498 (+4%)

FPC:fee_entrypoint_private
1,376
11,731
676 (+3%)

AVM Simulation
Time to simulate various public functions in the AVM.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
50.3
1,993 (-12%)

FeeJuice:set_portal
13.6 (-12%)
2,208 (-15%)

Token:constructor
71.3 (-1%)
:warning: 10,658 (-18%)

FPC:constructor
48.2 (-1%)
:warning: 6,144 (-21%)

FeeJuice:check_balance
36.8 (-1%)
1,740 (-12%)

Token:mint_public
:warning: 64.6 (+48%)
3,835 (-13%)

Token:assert_minter_and_mint
634 (-1%)
2,527 (-13%)

AuthRegistry:set_authorized
47.6 (+4%)
823 (-11%)

FPC:prepare_fee
72.5 (+17%)
:warning: 3,089 (-21%)

Token:transfer_public
:warning: 40.8 (+63%)
:warning: 7,401 (-17%)

FPC:pay_refund
43.6 (+1%)
:warning: 3,911 (-19%)

Benchmarking:increment_balance
1,245
:warning: 2,620 (-16%)

Token:_increase_public_balance
38.7
1,994 (-11%)

FPC:pay_refund_with_shielded_rebate
50.3 (-1%)
:warning: 3,911 (-19%)

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.167 (-2%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.20
3.99 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.114 (-1%)
0.112 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.3
18.5 (+3%)
30.8 (-1%)
61.6 (+4%)
114

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.108
0.107 (+3%)
0.0999 (-2%)
0.106 (+4%)
0.102

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.6 (+1%)
26.3 (+3%)
44.7
85.8 (+5%)
164 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
357
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.113 (+2%)
0.106 (+3%)
0.107
0.105 (+4%)
0.103 (-1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.3 (+1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
129
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.107 (+2%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
72,168
668,252

Transaction size based on fee payment method
| Metric |  |
| - |  |


Chart state when no outcome is selected

Please add this message using 12px Regular

very minor but can you change the font colour #15171A and the font weight to regular

very minor but can you change the font colour #15171A and the font weight to regular


[BUG] Still throw exception while running fvm use  command in developer mode [windows]

Although I have activated developer mode, I'm still getting "Exception: On Windows FVM requires to run in developer mode or as an administrator" error while running fvm use.
After running fvm use , it switches to the required version but still throws that error.

@Prajun2010 have you resolved this?

Not really, but I found that installing fvm using flutter cause this problem ( e.g. flutter pub global activate fvm ) .So, i reinstalled the fvm using pub only and the error was solved. Also, why activating fvm doesn't provide with the latest version, but provide with 1.3.7 version?

@Prajun2010 have you resolved this?

Not really, but I found that installing fvm using flutter cause this problem ( e.g. flutter pub global activate fvm ) .So, i reinstalled the fvm using pub only and the error was solved. Also, why activating fvm doesn't provide with the latest version, but provide with 1.3.7 version?

You have to update dart to the latest version since the new fvm uses null safety. You can also install using chocolatey that should solve a lot of these problems

You have to update dart to the latest version since the new fvm uses null safety. You can also install using chocolatey that should solve a lot of these problems

Oh ! , I got that , thank you @leoafarias for the support.


Code fix + bug fix for cupy.cuda.thrust

Close #3232, in which two different bugs were reported. Follow-up of #2745 & #3286.
This PR does two things:

code fix: most pointers passed from Cython are of type intptr_t (#2455). Shouldn't have to cast them to size_t.
bug fix: #3232 has two bugs reported:

cupy::thrust::_lexsort() assumes a C-contiguous input but we didn't check it
lack of NaN handling for real numbers

Context for the 2nd bug: In #2745 (#3286) when sorting complex (half precision) numbers was supported, NaN handling was added, but I forgot to extend it to single and double precisions 😅 Now this is done in a unified fashion, similar to how it's handled in cupy/cuda/cupy_cub.cu. (Perhaps I will do more refactoring later to reduce code repetition.) The master branch fails most of the added tests (for NaN and non-C-contiguous arrays), which this PR passes.

@takagi The PR description is updated. PTAL.

Thanks! pfnCI, test this please.

Jenkins CI test (for commit f282a18febe3b99fbbab694649e5468a7c0b21d2, target branch master) failed with status FAILURE.

Jenkins CI fails because of strange compiler errors in cupy_thrust.cu: https://jenkins.preferred.jp/job/chainer/job/cupy_pr/1212/TEST=chainer-py3,label=mn1-p100/console
Would you take a look into it?

@takagi Hmm, what's the gcc and CUDA versions in chainer-py3?

It's CUDA 10.1. I guess gcc is 7? Not sure...
Anyway, I guess it's because tuple.get<i>() is a dependent name, see "disambiguator for dependent names" here. We could either try thrust::get or add a typename.

But then I don't know why other CIs and my local build passed...😞

chainer-py3 uses CUDA 10.1 and ubuntu:18.04 docker image as its base. Other test patterns use different base image and CUDA combinations, which may be the reason other CIs pass. I'll check into the detail.
https://github.com/chainer/chainer-test/blob/master/run_test.py#L108

Thanks, @takagi! In the meanwhile, could you give 556e486 a try?

pfnCI, test this please.

Jenkins CI test (for commit 556e48605ed9d6746bd73d0226066f4095011d2c, target branch master) succeeded!

ubuntu:18.04 is used in several CIs, so looks like Thrust that comes with CUDA 10.1 caused the issue...It's now fixed in 556e486.

Thanks, LGTM!

Thanks for quick review, @takagi :)

@takagi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@takagi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@takagi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@takagi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@takagi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

I'm working on backporting this PR.

@takagi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@takagi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?


how to create master playlist for multiple resolution in ffmpeg

how to create one master playlist for all resolutions please reply
#!/bin/bash
if [ ! -d playlist ]; then
mkdir playlist
fi
if [ ! -d playlist/360p ]; then
mkdir playlist/360p
fi
if [ ! -d playlist/480p ]; then
mkdir playlist/480p
fi
if [ ! -d playlist/720p ]; then
mkdir playlist/720p
fi
if [ ! -d playlist/1080p ]; then
mkdir playlist/1080p
fi
RStreamer_engine_1.5 -i "$INPUT_URL?overrun_nonfatal=1&fifo_size=50000000"
-s:v 640x360 -c:v libx264 -movflags +faststart -preset ultrafast -c:a aac -b:a 128k -ac 2 -b:v:0 1000k
-f hls -hls_time 2 -hls_wrap 15
"playlist/360p/manifest.m3u8"
-s:v 720×480 -c:v libx264 -movflags +faststart -preset ultrafast -c:a aac -b:a 128k -ac 2 -b:v:0 2000k
-f hls -hls_time 2 -hls_wrap 15
"playlist/480p/manifest.m3u8"
-s:v 1280x720 -c:v libx264 -movflags +faststart -preset ultrafast -c:a aac -b:a 128k -ac 2 -b:v:0 3000k
-f hls -hls_time 2 -hls_wrap 15
"playlist/720p/manifest.m3u8"
-s:v 1920x1080 -c:v libx264 -movflags +faststart -preset ultrafast -c:a aac -b:a 128k -ac 2 -b:v:0 4000k
-f hls -hls_time 2 -hls_wrap 15
"playlist/1080p/manifest.m3u8"
#</dev/null > /dev/null 2>&1 & echo $! > $STREAM_PID_PATH
thank u in advance

Hi @udhayNuk
For the benefit of all users, it is important to keep this discussion forum clean, clear and well organized.
This issue is not clear enough. Is this a question? A response? To which question? It seems redundant with multiple issues you opened recently such as #1100, #1102, #1108 and maybe #1110 from a different user but with similar concern and style.
Redundant posts shall be avoided, especially from the same user at the same period. Supplement the discussion of existing topics instead.
Please read the Github documentation on how to write topics using markkdown, especially to properly embed code and commands. Mixing descriptive text and code and commands make the post extremely difficult to read and understand.
Support is provided here on a best effort basis. Developing and supporting TSDuck requires a substantial amount of effort with no compensation. Users benefits from these efforts for free. In return, users are expected to spend some effort in reading the documentation, understanding the product and the related standards, understand the way GitHub discussions work. If users appear to provide no effort and expect extensive support for free, there will be no response.

@ ok dude

@lelegard
ok dude


Port SqlParameter changes from netcore to netfx

Ports the changes in SqlParameters perf optimizations to netfx https://github.com/dotnet/SqlClient/pull/209.
This is a prerequisite for https://github.com/dotnet/SqlClient/issues/19

@Wraith2 Thanks for the PR. The test pipelines are setup, but there are some adjustments left to be done. I saw some failures on net462 and not sure if you were able to see them.

It turns out you have to actually set the parameters field so they can be sent to the server or all sorts of things stop working.
The CI doesn't seem happy because legs i haven't change (enclave ones) are failing for net6.0 builds. I'm also not sure which ones i should be paying attention to. Do we still have legacy checks?

It turns out you have to actually set the parameters field so they can be sent to the server or all sorts of things stop working.
The CI doesn't seem happy because legs i haven't change (enclave ones) are failing for net6.0 builds. I'm also not sure which ones i should be paying attention to. Do we still have legacy checks?

I will take the old one out today. The one I was working on, this will be primary one today, is CI-SqlClient-To-Be-Main.

Most legs are passing but some fail with EXEC(0)

/AzurePipelines run

Can you kick the CI again please.

/AzurePipelines run

The failures are odd but appear repeatable. They're in Always Encrypted tests which i have no way to debug locally because of the sql server requirements. I'm going to need some help from the team to investigate why those failures are occuring.
As i mentioned in the first post this is a blocking issue for the sql batch api, without these changes there is no way to access the parameter collection for the set of rpc's in the batch.

The failures don't require Always Encrypted enabled.

Ok, all green now. quick merge it before I break it again!


Update mockito-scala to 1.4.7

Updates org.mockito:mockito-scala from 1.4.6 to 1.4.7.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "org.mockito", artifactId = "mockito-scala" }]

labels: semver-patch

Already done.


[Wave Collect] New Resources to Publish - Free > Collect migration

Publish Date: May 1st 2024
Tracking GH: https://github.com/Expensify/Expensify/issues/386666
Draft: https://docs.google.com/document/d/1eobOg2Cva1SNJwZesn6FWNFJDSF-wHED0xgkasYR0rg/edit#heading=h.9ua5yvwzrmcv
cc @ren-jones

I'm ready to be assigned!

Great. TY!

Pending review

Draft in review.

Ren rewrote the article, and I just left one suggestion. Otherwise good to proceed with PR!

And then the latest was that this article should be published under Getting started in the nav structure.

Looks like copy is finalized, and next step is PR!

PR in review.

All set. TY!


Update CHANGELOG.md

📖 Description and reason

👷 Work done
Tasks

[x] Task 1
[ ] Task 2

Additional notes

🎉 Result

🦀 Dispatch
#dispatch/elixir

Incorrect target, please disconsider.


DRLParser fails while building the master branch

After setting the flag to download clang and having installed ncurses5-compat-libs, I'm observing an exception in DRLParser. Relevant parts of the output:
siplasplas reflection parser
============================

==> Scanning search directories:
  -> /home/sztomi/src/siplasplas/include/siplasplas/fswatch
  -> /home/sztomi/src/siplasplas/include/siplasplas/signals
  -> /home/sztomi/src/siplasplas/include/siplasplas/reflection/static
  -> /home/sztomi/src/siplasplas/include/siplasplas/typeerasure
  -> /home/sztomi/src/siplasplas/include/siplasplas/reflection/common
  -> /home/sztomi/src/siplasplas/include/siplasplas/utility
  -> /home/sztomi/src/siplasplas/include/siplasplas/logger
  -> /home/sztomi/src/siplasplas/include/siplasplas/constexpr

==> Processing 69 files:
[  1%] (outdated) include/siplasplas/constexpr/algorithm.hpp
[  2%] (outdated) include/siplasplas/constexpr/arrayview.hpp
[  4%] (outdated) include/siplasplas/constexpr/assert.hpp
Traceback (most recent call last):
  File "/home/sztomi/src/siplasplas/src/reflection/parser/DRLParser", line 238, in <module>
    App().run()
  File "/home/sztomi/src/siplasplas/src/reflection/parser/DRLParser", line 235, in run
    self.compiler.run()
  File "/home/sztomi/src/siplasplas/src/reflection/parser/DRLParser", line 86, in run
    self.process()
  File "/home/sztomi/src/siplasplas/src/reflection/parser/DRLParser", line 72, in process
    tu.process(self.verbose)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/translationunitprocessor.py", line 49, in process
    self.translation_unit = TranslationUnit(self.clang_tu.cursor, self.filePath)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/translationunit.py", line 55, in __init__
    self.root = Namespace.global_namespace(self)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/namespaces.py", line 32, in global_namespace
    return Namespace.create_node(cursor = translation_unit.cursor, translation_unit = translation_unit, file = translation_unit.file)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 125, in create_node
    nodeClass.initialize_children(node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 160, in initialize_children
    child = nodeClass.create_child(cursor = c, parent = node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 115, in create_child
    return class_.create_node(**kwargs)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 125, in create_node
    nodeClass.initialize_children(node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 160, in initialize_children
    child = nodeClass.create_child(cursor = c, parent = node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 115, in create_child
    return class_.create_node(**kwargs)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 125, in create_node
    nodeClass.initialize_children(node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 160, in initialize_children
    child = nodeClass.create_child(cursor = c, parent = node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 115, in create_child
    return class_.create_node(**kwargs)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 125, in create_node
    nodeClass.initialize_children(node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 160, in initialize_children
    child = nodeClass.create_child(cursor = c, parent = node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 115, in create_child
    return class_.create_node(**kwargs)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 125, in create_node
    nodeClass.initialize_children(node)
  File "/home/sztomi/src/siplasplas/src/reflection/parser/ast/node.py", line 159, in initialize_children
    if c.kind in mapping:
  File "/usr/lib/python2.7/site-packages/clang/cindex.py", line 1271, in kind
    return CursorKind.from_id(self._kind_id)
  File "/usr/lib/python2.7/site-packages/clang/cindex.py", line 555, in from_id
    raise ValueError,'Unknown template argument kind %d' % id
ValueError: Unknown template argument kind 602
make[2]: *** [src/fswatch/CMakeFiles/siplasplas-fswatch_drlparser.dir/build.make:58: siplasplas-fswatch_drlparser] Error 1
make[1]: *** [CMakeFiles/Makefile2:1722: src/fswatch/CMakeFiles/siplasplas-fswatch_drlparser.dir/all] Error 2
make: *** [Makefile:161: all] Error 2

I ran:
mkdir build && cd build
cmake ..
make

Adding
CursorKind.STATIC_ASSERT = CursorKind(602)

To /usr/lib/python2.7/site-packages/clang/cindex.py solves the problem, but obviously it's not a great idea. Maybe it would make sense to ship a patched cindex.py with siplasplas until the patch is upstream.

Maybe the long-term solution to all this problems is to provide our own versioned versions of cindex.py, one for each tested clang version. This may include some hotfixes like yours. In general, a way to avoid relying in external unstable releases if possible.

Note: In the future, I would like to deprecate the python DRLParser and rewrite everything using C++ and the libclang C API

I would be interested in contributing to that.

Cool, feel free to send PRs to the master branch ;)
What I would do:

Add a cindex/ folder in src/reflection/parser/
Add versioned cindex.py files there, named cindex-x.y.py, where x.y is the clang version (3.4, 3.8, etc)
Remove clang python package dependency from cmake/libclang.cmake
Change python scripts in src/reflection/parser/ to import cindex API from cindex/cindex.x.y.py instead of the system package

I think it's enough to have just one cindex.py because in my experience the incompatibilities stem from certain things not being exposed (like the CursorKind above), and not things like changing APIs (after all, libclang aims to be a stable, backwards-compatible library). That implies that there is no need to change the scripts that import it if it's in the correct directory.

By the way, I mainly meant contributing to the C++ rewrite of DRLparser, but I can help with this as well

OH. That's even better! I haven't done before due to lack of time and, frankly, being a bit lazy...
If we are going to continue this way, @foonathan 's standardese is a great reference.

One of the things a have been thinking for months was to directly take Standardese backend and adapt the generation part to generate the siplaspals reflection metadata. This way we:

Depend on a widely tested high-quality  libclang based backend. (Which also supports much more features than my DRLParser does)
Contribute to standardese. Standardese bugfixes help us and we help Standardese

I think it's enough to have just one cindex.py
So, we could maintain a cindex.py file compatible with all the clang versions we support (Something we must define and fix first)

One of the things I have been thinking for months was to directly take Standardese backend

Good idea, I'll take a look.

Something we must define and fix first

I think the minimal version is the first clang version that supports the C++ standard that siplasplas wants to support. If it's C++14, then if I'm not mistaken it's 3.7(?)

I think the minimal version is the first clang version that supports the C++ standard that siplasplas wants to support. If it's C++14, then if I'm not mistaken it's 3.7(?)

I have been trying to maintain C++11 compatibility at least in the static reflection API, so the DRLParser generated code and the reflection API should be C++11 compatible. (I think there are some minor issues, last time I tried it worked with a GCC 4.8 with some warning about generic lambdas).

Since C++ standards are mostly backwards-compatible, it's not a bad idea to opt for a minimal version of clang that supports a newer standard (i.e. to be able to parse the widest set of possible inputs). The generated code should not depend on this at all.

Do you want to rewrite all of DRLParser in C++ or only replace the actual parsing with Standardese? I think the latter would be fairly easy if we made a Cython wrapper around Standardese. The jinja template would probably have to be changed a bit.

I want to replace the whole DRLParser tool to get rid of python dependencies. Also, writing DRLPaser in C++ makes it easier to write a C++ API to invoke it programatically (Which I would like to have for runtime c++ compilation)

I'm looking at a replacement for Jinja and found this: https://github.com/hughperkins/Jinja2CppLight
At a first glance, it misses macros that is feature that siplasplas templates seem to heavily depend on. Are there other features missing?
This is another approach: https://github.com/hughperkins/luacpptemplater which might be easier to implement macros with. Maybe @hughperkins has some input?

I use the luacpptemplater for runtime generation of opencl kernels from templates from c++, which works very well for me. The syntax is slightly different from jinja2, a bit uglier I would say, but it's a full scripting / macro language, whereas the jinjacpplight either is very lightweight (current form) and misses stuff, or else would become it's own entire scripting language, which seems redundant somehow?
On 7 December 2016 23:54:51 CET, "Tamás Szelei"<EMAIL_ADDRESS>wrote:

I'm looking at a replacement for Jinja and found this:
https://github.com/hughperkins/Jinja2CppLight
At a first glance, it misses macros that is feature that siplasplas
templates seem to heavily depend on. Are there other features missing?
This is another approach:
https://github.com/hughperkins/luacpptemplater which might be easier to
implement macros with. Maybe @hughperkins has some input?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/Manu343726/siplasplas/issues/77#issuecomment-265599999

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I can see where you are coming from. I agree that the lua option is fairly good for this, what do you think, @Manu343726 ? (There is also a lua package on conan). This is probably the direction with the least resistance, because changing the template syntax is way less work than adding the missing features to jinjacpplight.

I looked at Jinja2CppLight previously when searching jinja2 replacements, but didn't know about luacpptemplater. I think it is perfect for our use case.
The only thing I'm worried about is conan.io support of this dependency, since I want to completely switch to conan for thirdparty management (See #78). But the project looks simple to port to conan ;)

@hughperkins is it possible to define a lua function in the template as a "macro"? What I mean:
{% function something() %}
  hey, render this
{% endfunction %}

{% something() %}
{% something() %}

would output
  hey, render this
  hey, render this

is it possible to define a lua function in the template as a "macro"?

Interesting question.  I added a test at https://github.com/hughperkins/luacpptemplater/commit/38cc75272d86c8311b91bb069620770a6b9d447b to check this point.  This test passes.
Note that the lua templater code idea and core implementation came from John Nachtiwald https://john.nachtimwald.com/2014/08/06/using-lua-as-a-templating-engine/ .  I'm not sure why I didnt point this out in the readme before, but I've added it now https://github.com/hughperkins/luacpptemplater/commit/9611b32ca7882c325c4290114cfb9746d67b8994

That's great, thank you!

@hughperkins thank you for the support!
@sztomi I'm currently working on migrating dependencies to conan, I hope I can start with the DRLParser rewrite by next week. Anyway, thanks a lot for the feedback, I'm really looking forward to review your PRs ;)

In the meantime I started to freshen up luacpptemplater a bit. I'll take a stab at making a conan package as well. https://github.com/sztomi/luacpptemplater


chore(deps-dev): Start publishing python v2 codegen

@coderabbitai summary

Abandoning branch now that https://github.com/fern-api/fern/pull/5087 is merged to avoid rebases


client: Fix failed to pull ubuntu image from docker.io

Manifests list feature in oci-distribution is already implemented, default image in docker.io like busybox use IMAGE_MANIFEST_LIST_MEDIA_TYPE, but ubuntu image use OCI_IMAGE_INDEX_MEDIA_TYPE.
Fixes: #27

@arronwy Given I don't know how much time it will take for distribution to fix this issue, and given how easy the fix is on our side I propose the following approach:

We create an issue to keep track of the missing unit test
We merge this fix without any unit test

What do you think about that?

@arronwy Given I don't know how much time it will take for distribution to fix this issue, and given how easy the fix is on our side I propose the following approach:

We create an issue to keep track of the missing unit test
We merge this fix without any unit test

What do you think about that?

Agree, thanks a lot!

I have updated this PR, and create an issue to track uni tests: https://github.com/krustlet/oci-distribution/issues/68


how to reset DrawingManager.

When I DrawingManager, onXXXComplete events emit，I want to reset DrawingManager.But can not find method to do.

const handlePolygonComplete = (polygon) => {
const coordinates = polygon.getPath().getArray();
/* whatever you want to do with the polygon */
polygon.setMap(null);
};

Write a toggle function by setting up state  to a property (drawingMode)
this.state={
getDrawingMode:''
}
Toggle State:
this.setState({
getDrawingMode:'polygon'
})
........
<DrawingManager
drawingMode={this.state.getDrawingMode}


[UI/UX] view by organization

Describe the feature you'd like to request
It'd be nice to be able to see all of the projects under an organization.
For now, we can just focus on our official organization, which shows canonical verified projects and collections.
Describe the solution you'd like
TBD
Describe alternatives you've considered
TBD

We will start with the degenerate case where the organization is the project (ie, Uniswap the organization is also Uniswap the project)
See also #102
It should be at /org/slug/ (to do: learn how to create dynamic pages in Plasmic)

@ccerv1 can you start with this?
https://github.com/hypercerts-org/oso/issues/100
This issue is a placeholder for when we get to allowing people define their own collections and projects, and we might want to have some team abstraction within OSO for owning these user-defined projects/collections.
In other words, just focus on

/projects/slug/ - https://github.com/hypercerts-org/oso/issues/100
/artifacts/id/ - https://github.com/hypercerts-org/oso/issues/99
/collections/id - https://github.com/hypercerts-org/oso/issues/102

Yep, will re-jigger

Wow this issue is 1 year old.
Happy to share that we finally did this, effectively by creating /collections, /projects, and /artifacts.
Closing this for now, we can file new issues when we have specific changes we want to make around the current behavior


Loss of IP Metadata

Originally filed at https://github.com/spanicker/ip-blindness/issues/22 by @jbradl11:

IP addresses serve a variety of use cases beyond anti-fraud. IP can be used for analytics, measurement, regional preferences, tracking paid subscribers, and many more. As Chrome seeks to mask IP addresses, we are working to ensure that valid use cases are preserved while also improving privacy on the web.
How does blocking IP challenge your different use cases? What other ways could actors achieve these use cases without IP addresses used for fingerprinting? What potential replacement signals could we extract from an IP address and pass as a new, standalone (and possibly attested?) signal?

I work in the systems department of an academic library. Like many libraries we rely on IP-based authentication to allow end users access to databases full of scholarly resources that we have licensed on their behalf.
Just to give a brief overview, the way it works is:

We license a database from a vendor (for example, JSTOR)
We send a list of the IP addresses used on our campus to JSTOR
JSTOR checks the IP addresses of incoming traffic against their list, granting access to recognized IPs
To provide for off-campus access, we run a proxy server (EZ Proxy) which relays traffic for our users through an on-campus IP so they get access

This is a very common arrangement in the library world, both at academic institutions and at smaller public libraries.   At my library, we have licenses that work this way from a couple hundred distinct vendors, ranging in size from large companies like Elsevier down to tiny single-journal shops like the Journal of Economic Insight, which has no dedicated IT staff.
Moving away from an IP-based authentication system would be a major undertaking.   I look into my future and I see a whole lot of work trying to get many vendors of hugely varying IT expertise to implement a SAML endpoint, or similar.  It's going to be difficult.  I worry that smaller vendors who lack IT staff may not be able to adapt.  Also, smaller libraries with few or no dedicated IT staff will likely face serious challenges in migrating to some other authentication regime.
But I don't see any good way to avoid that. I am broadly in support of the goals of the project. I value user privacy. But without that IP address, proxy-based authentication schemes just plain don't work.

Regarding library access to resources using IP address resolution, we are also in the a similar situation where the IP address is used to verify access to certain resources from UK public libraries. From a supplier of resources point of view, without a stable IP address to verify against, this will provide a blocker for a lot of smaller libraries that do not have the technical resources to setup authentication systems like SAML.


I created a simple bash script that automates the installation process and also updated the readme file.

There are 4 steps to make the original script run.

Step 1: Open Terminal
Step 2: mkdir -p ~/MuteSpotifyAds && curl https://raw.githubusercontent.com/gdi3d/mute-spotify-ads-mac-osx/master/NoAdsSpotify.sh > ~/MuteSpotifyAds/NoAdsSpotify.sh
Step 3: sh ~/MuteSpotifyAds/NoAdsSpotify.sh

My Script is named as AdsBlockShortcut and contains following commads
mkdir -p ~/MuteSpotifyAds && curl https://raw.githubusercontent.com/gdi3d/mute-spotify-ads-mac-osx/master/NoAdsSpotify.sh > ~/MuteSpotifyAds/NoAdsSpotify.sh

sh ~/MuteSpotifyAds/NoAdsSpotify.sh

# sh ~/MuteSpotifyAds/NoAdsSpotify.sh show

So Instead of repeating this every time the user wants to use spotify I used your script and packed it in another script to make it a little bit more fast and beginner friendly.
(Optional) - I used Platypus to create mac app from the script. It will open the script in a Text Window.

Hey thanks for effort, but it's not necessary to download the bash file every time you need to use it. Maybe I should clarify that on the docs.
Thanks for your contribution but I'll not be accepting this since it's not really need it.


Render profile view incrementally

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2165
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

We can close this PR in favor of https://github.com/opensrp/fhircore/pull/2354. Most of the issues raised here are addressed on the mentioned PR

Used a SnapshotStateList on the list view. Compose is able to refresh the UI when an item is added to the list.


Screen Timeout

Screen timeout seems not to work on the latest release.
All other screensaver fetures work correctly but not the blank/timeout.
Event if I press the sleep icon the screen stays on.

You have to set a clock or image screensaver of you want to use one. If you don’t use one then screen timeout is up to your device settings. If you had a screen saver and then disabled it, try restarting the app.

If I set a clock or image screensaver it works correctly. I just want to turn off the screen after a definite time and it just does not blank the screen.

Does your Android device have a screen saver set or a screen timeoit set?  Your device will put itself to sleep without the app have a screen saver set.

I just realized your on Android Things.  So there is way to turn off the screen on Android Things, all you can do is dim it. I suggest you use the clock and set the screen brightness low. It dims the screen when there is a screen saver running.  But there is no black screen, I guess that’s what you expected.

I guess a feature request would be to turn the screen black and do maximum dim if there are no screensavers set and you manually hit the "Zzz" button to turn on the screen saver.   Optionally, I would have to add a "Use blank screensaver" option because there is a use case for not using any screensaver.

Ok this is what really I am asking for. The previous version worked exactly this way, if a screensaver was not set it simply turned down the screen after sleep time.


Determine Database schema

We need to determine what type of database is being used either mongoDB or a SQL variant

Create a basic database schema to house the chats

I Believe we're leaning towards SQL because it provides a relational database.

Closed story by accident. SQL sounds good @Earthii !

After discussing it with Brendan we decided to go with a MongoDB database

Determined database schema for first sprint:

https://github.com/jusleg/soen341/wiki/Database-Schema


With Python 3.11.0, PyInt_FromLong not found is spammed in terminal

Type: Bug

Behaviour
Expected vs. Actual
Expected behavior: Python debugging works as expected.
Actual behavior: Terminal output is spammed with PyInt_FromLong not found.
Steps to reproduce:

Initialize vscode-server on remote (connect using Remote - SSH extension).
Install vscode-python on remote (Extensions -> Python -> "Install in SSH: hostname" button.
Select Python 3.11.0 as interpreter.
Debug the following program.

print("Hello")

You will see terminal output Hello as expected, and several messages PyInt_FromLong not found.
Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.11.0
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Pyenv
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

LSP Notebooks experiment is enabled
LSP Notebooks interactive window support is enabled
> conda info --json
Python interpreter path: ~/.pyenv/versions/3.11.0/bin/python
> ~/.pyenv/versions/3.11.0/bin/python ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/get_output_via_markers.py ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/interpreterInfo.py
> ~/.pyenv/versions/3.11.0/envs/pyplay/bin/python ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/get_output_via_markers.py ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/interpreterInfo.py
> /bin/python3 ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/get_output_via_markers.py ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/interpreterInfo.py
> /usr/bin/python3 ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/get_output_via_markers.py ~/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/interpreterInfo.py
Starting Pylance language server.
DAP Server launched with command: /home/justin/.pyenv/versions/3.11.0/bin/python /home/justin/.vscode-server/extensions/ms-python.python-2022.18.2/pythonFiles/lib/python/debugpy/adapter

User Settings

languageServer: "Pylance"

Extension version: 2022.18.2
VS Code version: Code 1.73.1<PHONE_NUMBER>f055b99068d3688932416f2346dd3b, 2022-11-09T04:27:29.066Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
Remote OS version: Linux x64 5.15.0-27-generic

System Info

Item
Value

CPUs
AMD Ryzen 7 1700 Eight-Core Processor           (16 x 2994)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
63.95GB (26.81GB free)

Process Argv
--crash-reporter-id 1e9604e4-dc28-4e69-b0ed-335830710f8b

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: mars.justind.dev

OS
Linux x64 5.15.0-27-generic

CPUs
AMD Ryzen 7 1700 Eight-Core Processor (12 x 2994)

Memory (System)
12.14GB (9.35GB free)

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
vsccc:30610678
pyindex848cf:30577861
nodejswelcome1cf:30587006
fc301958:30595537
282f8724:30602487
gswce1:30612156
3d0df643:30613357
dbltrim-noruby:30604474
f6dab269:30613381

See related: microsoft/debugpy#1300
I'm not sure if this needs a debugpy release or even if this issue goes to this repo. Just wanted to surface it.

I am seeing this in VSCodium:
Version: 1.73.1
Release: 22314
Commit: 14f2d26367b7e8f03ff2352516ba27d6302dd7b1
Date: 2022-11-10T18:19:13.052Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.0.8-200.fc36.x86_64
Sandboxed: No

Looked into this. A debugpy release is needed. Once it's released, I can submit a PR to update.

Hi there! Thanks for the bug report, and I'm sorry for this frustration. We're coordinating with the debugpy team to release the update, but given most folks are based in the US, this will likely be out after the holidays.

The issue still exist, the next holidays are coming up. And Python 3.12 will be released in 10 months...

I confirm it. The bug stille exist with python 3.11rc.

I confirm it too. The bug still exists with python 3.11

python 3.11.0rc1 Ubuntu 22.04 WSL can see this bug too

Really sorry for the frustration here. folks. This issue was fixed in debugpy 1.6.4, which we shipped in the 2022.20.0 release. However, a new bug was introduced in that version (https://github.com/microsoft/vscode-python/issues/20355), so we ended up rolling back debugpy to 1.6.3 in the 2022.20.1 release. This new bug has just been fixed in debugpy 1.6.5, which was released yesterday, so we went ahead and upgraded debugpy (https://github.com/microsoft/vscode-python/pull/20477).
The new pre-release version of the Python extension should have all these fixes now. Provided things are working as expected, we plan to do a hot-fix release next week to make the fixes available on the stable version as well.

Python 3.11.1 (main, Jan 1 2023, 17:03:48) [GCC 9.4.0]
Version: 1.74.2
Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date: 2022-12-20T10:27:19.253Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.0.16-300.fc37.x86_64
Sandboxed: No
still exists

Version: 1.74.2 (user setup)
Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date: 2022-12-20T10:29:14.590Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

The problem has been fixed in the 2022.20.2 release of the Python extension. Please make sure  you have the latest stable version of the Python extension if you're using VS Code stable, or the latest pre-release version if you're using VS Code Insiders:


use blas lock on LOONGSON3A

Time wasted on pthread_lock/unlock on LOONGSON3A platform.  Blas_lock/unlock can increase speed about 50%.

Blas_lock on mips64 is just the YIELDING macro that maps to sched_yield() I think. Is that sufficient and appropriate ? (Seems on some platforms sched_yield is about the worst one can do from a performance standpoint, so YIELDING is often maped to asm(nop) or the like in common.h). Historically most parts of OpenBLAS were not thread-safe, but I must admit that most of the locks that I put in were based on valgrind/helgrind reports rather than qualified analysis of the code. So there may have been some false positives, but on the other hand some race conditions tended to show up on fast computers with many cores. (Not sure how big and fast Loongson-based hardware can get ?)

While compile with:
make CC=gcc FC=gfortran HOSTCC=gcc TARGET=LOONGSON3A CROSS=1 NO_LAPACKE=1 BINARY=64
in common.h, SMP was defined.
#ifdef SMP
#define USE_PTHREAD_LOCK
#undef  USE_PTHREAD_SPINLOCK
#endif
So, USE_PTHREAD_LOCK will be used.
Like what we do with WINDOWS, blas_lock same code added on LOONGSON3A.

Could you create a separate PR for the sgemm_kernel bug please ?
And sorry for sitting on this PR for so long, but I have been very busy elsewhere. Both the common_mips64.h change and the one to memory.c have already been made through separate PRs in the meantime I think - your #1800 and brada4's #1785. Regarding the original locking issue, I think the difference to windows is that the x86 and x86_64 platforms define their own implementation of blas_lock in common_x86.h and common_x86_64.h respectively, where the generic sched_yield() is followed by  an InterlockedExchange (MSVC) or xchgl to - I believe - ensure thread safety. The common_mips64.h does not provide anything like this (compare lack of BLAS_LOCK_DEFINED)  so it would end up with the pure sched_yield() from the fallback code which I fear would be unsafe.


Edit the info class to not use the same blue as the .selected background color

Not use the same blue or more reasonably just use a different color.


Validate method does the wrong thing(copy paste error)

Please have a look at: https://github.com/rojo8399/PlaceholderAPI/blob/cd49713e40cc935ed2923479fa9dc6c1ea22bf7f/src/main/java/me/rojo8399/placeholderapi/impl/PlaceholderServiceImpl.java#L140-L145

Fixed


Can't install with separate features format in Cargo.toml

Bug Description
The README says

For backwards-compatibility reasons, the runtime and TLS features can either be chosen together as a single feature, or separately.
For forward-compatibility, you should use the separate runtime and TLS features as the combination features may be removed in the future.

So I used the separate runtime and TLS features combination. See screenshot below For my Cargo.toml and cargo build error.
Minimal Reproduction

Info

SQLx version: 0.6
SQLx features enabled: trying to enable them separately
Database server and version: trying to get latest stable postgres
Operating system: EndeavorOS (Arch-based)
rustc --version: 1.68.0

The new features are for 0.7.0-alpha.1 and the coming 0.7.0 release. That development is now occurring on main so the README reflects that.

Thank you for the answer. If the Cargo.toml snippet in the README showed version 0.7 instead of 0.6, it would have made more sense. But maybe that document is autogenerated.
sqlx = { version = "0.7", features = [ "runtime-tokio", "tls-rustls" ] }
but maybe that would be even more misleading.
Thanks again.


how add more parameters to json that sended to server ?

How could you do to add more parameters in json that is sent to the server
For example:
Add deviceid
...

hello @MAntonio95
You can pass deviceid into header
httpHeaders: { 'deviceid':123123123123},
its work for me. i hope its also work for you.

Notice: this issue has been closed because it has been reported for branch 2.x or later. It could be already fixed in v3 or is not relevant anymore. You may reopen this issue if it has been closed in error.


Update ru_RU.lang

@CrazyPants @HenryLoenwind merge yourself ignor Travis CI error, please

Hello?!

just the usual, all of us are afraid to merge languages they don't speak. It will be merged, give it some time.

It's error because Java 7 doesn't want build :(

How can i fix it error with Travis CI?

Authors of this mod @HenryLoenwind, @CrazyPants and others, I really like this mod and i want make RU translate will be updated. But i can't make it still due Travis CI check! Can you answer on my question: How can i fix it, or can you merge it yourself without this check?
Thanks for the next feedback!

Thank you, @tterrag1098!

btw, the CI failure has nothing to do with your PR. It seems the Travis Java 1.7 build always dies atm. Low prio for now.


Missing Relay Ice Candidate

Hi,
I'm currently moving from an implementation built around the m71 release of webrtc-uwp-sdk to this one, and have stumbled upon an problem I'm not able to resolve. The solution works on webrtc-uwp-sdk.
I have a TURN/STUN Kurento server running on Azure, and when I connnect to it (or any peers through it) with the previous solution, my client always sent 5 ice candidates.
4 local and 1 relay. The relay one looks like this:
candidate:[number] 1 udp [priority] [Server IP] [WebRTC port] typ relay raddr [Local IP] rport [WebRTC port] generation 0 ufrag 9dPY network-id 1 network-cost 50
However, on this plugin, the relay candidate is never generated (or at least never given to me). I only receive the 4 local ones, and therefore can't setup a connection through the server.
I have added the ice servers to the peer as
iceServers = new List<string>
{
      $"stun: {url}{port}",
      $"turn: {url}{port}",
      $"turn: {url}{port}?transport=tcp"
};

and have also added Username and Credential for the TURN server.

Within the same environment, same computer/network/external peer, I can connect with the old solution both before and after trying this one.
Am I missing anything? Shouldn't this then generate the relay candidate? Or is the plugin somehow configured for local communication only?
While on the topic, would be amazing if we have access to modifying the transport- and bundle-policy of ice gathering.

Solved it.
Often typing out an issue helps resolving it.
The issue was the space in the ice server list, between the type identifier and the url. Correct implementation is
iceServers = new List<string>
{
      $"stun:{url}{port}",
      $"turn:{url}{port}",
      $"turn:{url}{port}?transport=tcp"
};

I followed the design in the PeerConnection.cs script, which has the ToString method:
public override string ToString()
{
     return string.Format("{0}: {1}", Type.ToString().ToLower(), Uri);
}

Should the space probably be removed here as well?

Hi @eirikhollis
Thanks for all the details. Yes it makes no sense to have a space here between the server URL and port. And in fact the default value in the Unity integration doesn't have a space:
https://github.com/microsoft/MixedReality-WebRTC/blob/12b1c55e318191cc0462048d4008a2aafaa18960/libs/Microsoft.MixedReality.WebRTC.Unity/Assets/Microsoft.MixedReality.WebRTC.Unity/Scripts/PeerConnection.cs#L151
I will fix the ToString() method. Sorry about that.

Confirmed with the source implementation, there is no space in the scheme:
turnURI = scheme ":" turn-host [ ":" turn-port ] [ "?transport=" transport ]
https://github.com/webrtc-uwp/webrtc/blob/baa89682df1ab891ae274a1cb2d9be3b1ee7e20b/pc/iceserverparsing.cc#L128-L148

Makes sense. Thanks for the quick reply!

Fixed with 573c04b06c2b0ea2ab95ebbbf99d2bce1d23077d. Closing this issue, thanks for the feedback!

I was apparently using the version of this code that included the space. It took a while to track down!
It would be nice if when adding ICE Servers, there was a check for malformed URLs. Since the only feedback is the successful generation of local ICE candidates. It's not very clear that there's an error with the ICE candidate generation, unless you know in advance exactly what to expect like eirikhollis. Reporting issues connecting to a STUN/TURN server would be ideal, but at least checking the URLs as they are added to the peer would be nice.


I can Adldap::auth() but can't use the normal login

Hello!
If I do this inside the view, I receive 1 (or true with dd):
    {{\Adldap::auth()->attempt('username', 'password')}}
If I try to log in with login form I receive the error:

These credentials do not match our records.

This is my config.auth:
    'defaults' => [
        'guard' => 'web',
        'passwords' => 'users',
    ],

    'guards' => [
        'web' => [
            'driver' => 'session',
            'provider' => 'adldap',
        ],

        'api' => [
            'driver' => 'token',
            'provider' => 'users',
        ],
    ],

'providers' => [
        'adldap' => [ // Added 'adldap' provider here.
            'driver' => 'adldap',
            'model'  => App\Models\User::class,
        ],
],

And this is my LoginController:
<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use Illuminate\Foundation\Auth\AuthenticatesUsers;
use Adldap\Adldap;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Lang;

class LoginController extends Controller
{

    use AuthenticatesUsers;

    /**
     * Where to redirect users after login / registration.
     *
     * @var string
     */
    protected $redirectTo = '/home';
    protected $username = 'username';

    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('guest', ['except' => 'logout']);
    }

    /**
     * Get the login username to be used by the controller.
     *
     * @return string
     */
    public function username()
    {
        return 'username';
    }
        /**
     * Show the application's login form.
     *
     * @return \Illuminate\Http\Response
     */
    public function showLoginForm()
    {
        return view('auth.login');
    }

    public function postLogin(Request $request)
    {
        dd("tet");
        $rules = [
            'username' => 'required|min:3',
            'password' => 'required|min:3'
        ];
        $this->validate($request, $rules);

        // Form validated, check if the authentication matches
        if (Auth::attempt($request->input(), true)) {
            $user = Auth::user();
            // @todo: Sync the groups
            return redirect()->intended('dashboard');
        }
    }

    /**
     * Handle a login request to the application.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function login(Request $request)
    {
        $this->validateLogin($request);

        // If the class is using the ThrottlesLogins trait, we can automatically throttle
        // the login attempts for this application. We'll key this by the username and
        // the IP address of the client making these requests into this application.
        if ($lockedOut = $this->hasTooManyLoginAttempts($request)) {
            $this->fireLockoutEvent($request);

            return $this->sendLockoutResponse($request);
        }

        $credentials = $this->credentials($request);

        if ($this->guard()->attempt($credentials, $request->has('remember'))) {
            return $this->sendLoginResponse($request);
        }

        // If the login attempt was unsuccessful we will increment the number of attempts
        // to login and redirect the user back to the login form. Of course, when this
        // user surpasses their maximum number of attempts they will get locked out.
        if (! $lockedOut) {
            $this->incrementLoginAttempts($request);
        }

        return $this->sendFailedLoginResponse($request);
    }
        /**
     * Log the user out of the application.
     *
     * @param  Request  $request
     * @return \Illuminate\Http\Response
     */
    public function logout(Request $request)
    {
        $this->guard()->logout();

        $request->session()->flush();

        $request->session()->regenerate();

        return redirect('/');
    }

}

$this->guard()->attempt($credentials, $request->has('remember'))
I tried to change this and hard type my username and password, but then I get an error with the Sessionguard, because it needs an array of credentials...

Can you post your adldap_auth.php configuration file?
Also, did you change your create_users_table migration to match the username field you're using instead of email?

Laravel 5.3?
if so replace the
protected $username = 'username';

with
``php
public function username()
{
return 'username';
}
in your `LoginController.php`

@warlord0
I did what you wrote, but after a while I think my main problem is with apache configuration. I don't have admin rights for security issues, then I can't configure kerberos or NTLM.
Or maybe I just misunderstood how the plugin work :smile:
Then I found this way, if it's not wrong, could be useful.

used this script http://blogs.msdn.com/cellfish/pages/ntlm-php.aspx to fake an ntlm auth and get the data of the current user
I just return the $user var from that script.
created this little script to check if the user exists or not

$check = Adldap::search()->where('samaccountname', '=', $user )->first();
if(isset($check)){
# in here so the user exist on the server
# check if exists in the local db
# if not then create and login
# if yes login
$exist = User::where('username', '=', $user)->first();
        if (isset($exist) && !rAuth::user()) {
         rAuth::login($exist);
         return true;
     }elseif(!rAuth::user()){
        # create user
        $newuser= User::create([
        'username' => $user,
        'password' => bcrypt('randomstring'),
        'name' => $user
    ]);

        rAuth::login($newuser);
     }

where:
use Illuminate\Support\Facades\Auth as rAuth;

Ahh, ntlm :( Not something I use as my clients could be anything and my choice of server is nginx which doesn't play well with ntlm.
If you really in need to using the $_SERVER remote_user or auth_user stuff then you have to have Apache configured with ntlm support. The fudge looks interesting though.

I did what you wrote, but after a while I think my main problem is with apache configuration. I don't have admin rights for security issues, then I can't configure kerberos or NTLM.
Or maybe I just misunderstood how the plugin work

You shouldn't need admin rights on the domain if you just need to query for users.
You mention NTLM authentication. You can utilize the WindowsAuthenticate middleware for this to automatically log in users if you wish. You'll just need to change the windows_auth_attribute config array:
https://github.com/Adldap2/Adldap2-Laravel/blob/master/src/Config/auth.php#L125-L151
'windows_auth_attribute' => ['samaccountname' => 'REMOTE_USER'] // Was `AUTH_USER`,

With your regular login issues, I'm not sure what the issue may be. Your connection is definitely configured correctly, but there may be issues with your adldap_auth.php config (which still needs to be posted for me to help further).

@stevebauman
sorry I forgot to post the adldap_auth.php
  'connection' => env('ADLDAP_CONNECTION', 'default'),
  'username_attribute' => ['username' => 'samaccountname'],
  'limitation_filter' => env('ADLDAP_LIMITATION_FILTER', ''),
   'login_fallback' => env('ADLDAP_LOGIN_FALLBACK', false),
 'password_key' => env('ADLDAP_PASSWORD_KEY', 'password'),

   'password_sync' => env('ADLDAP_PASSWORD_SYNC', false),

   'login_attribute' => env('ADLDAP_LOGIN_ATTRIBUTE', 'samaccountname'),
   'windows_auth_attribute' => ['samaccountname' => 'AUTH_USER'],
   'bind_user_to_model' => env('ADLDAP_BIND_USER_TO_MODEL', true),
   'sync_attributes' => [
'username' => 'samaccountname'

   ],

   'select_attributes' => [

       //

   ],

You shouldn't need admin rights on the domain if you just need to query for users.
no I can query users perfectly, as my method above is working for me.
I would need to populate $_SERVER with the data of the authenticated user... so I need admin right to configure apache...

Ok, can you post your auth/login.blade.php file as well (or wherever your login form is stored)?

@stevebauman
This is auth.login.blade.php
@extends('layouts.app')

@section('content')

Login

                    <form class="form-horizontal" role="form" method="POST" action="{{ url('/login') }}">
                        {{ csrf_field() }}

has('username') ? ' has-error' : '' }}">
                            Username

                                <input id="username" type="username" class="form-control" name="username" value="{{ old('username') }}" autofocus>

                                @if ($errors->has('username'))

                                        {{ $errors->first('username') }}

                                @endif

has('password') ? ' has-error' : '' }}">
                            Password

                                <input id="password" type="password" class="form-control" name="password" >
                                @if ($errors->has('password'))

                                        {{ $errors->first('password') }}

                                @endif

                                        <input type="checkbox" name="remember"> Remember Me

                                <button type="submit" class="btn btn-primary">
                                    Login
                                </button>

                                    Forgot Your Password?

                    </form>

@endsection

input type="username"? Should that be "text"?

oh yes sorry, I hard replaced email with username :astonished:

Been there done that ;)

Is this still an issue?


Over-Clocking Functions Support

I made the repo be able to do over-clocking operations on Nvidia graphic card, tested on Ubuntu 20.04 LTS with Nvidia A4000 (RTX 30 series supposed to work).

FYI, I'd highly recommend squashing these commits down into a single commit for this feature addition, see something like this.


Printer prints one blank

I am using the esc sample but my print just prints one blank line and stops.
I can however  get devices, connect properly and sustain the connection.
Kindly advise

do you have any answer for this problem?


#7360: Add 'assign' to operatorSet of UnusedImport

This PR adds assign to the operatorSet of the UnusedImport rule so that kotlin-dsl assignments are not reporting unused imports.
Resolves #7360

🤔 sorry, but I can't find assign as an operator on the kotlin documentation: https://kotlinlang.org/docs/operator-overloading.html where is it documented? Or is this gradle specific?

@BraisGabin this seems to be some gradle specific stuff. I read this article about it https://blog.gradle.org/simpler-kotlin-dsl-property-assignment and then verified it by the test

Yes it's Gradle specific and implemented as a compiler plugin applied by Gradle when it compiles scripts.
Kotlin offers the extension point to customise behaviour of the assign operator (and possibly others though I'm not sure).
Given this is Gradle specific, and in line with our general philosophy of not building library or tool-specific config as defaults, I think it would be better to introduce a config option for additionalOperators where things like this can be added for those that need it.

Thanks @3flex for the clarification ☺ I like the idea introducing a separate set for non language default operators. Changes have been pushed.

Warnings

:warning:
This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

  Generated by :no_entry_sign: dangerJS against 387f747c2f78043573d3d01fc8f76e25508bdecd

Sorry I didn't check this more closely - in my earlier comment I meant that the assign operator should be configurable and something to set in the YAML config. It's been implemented here as a hardcoded value in the rule but it's highly specific to Gradle so should be something that can be configured by users who are using that for Gradle analysis and not part of the standard rule config which should be framework-, tool- and library-agnostic.
I'll open a new issue.


Action detection model pretrained on HICO is required

Hi, Can you provide pretrained HICO detection model. I want to evaluate the pretrained model on my customized dataset.

Hi @ifmaq1,
Sorry for the late reply. You can download the checkpoint using the script bash hicodet/detections/download_checkpoint.sh.
Fred.


[Theme] Replace all instrumentation with tessen

We're fully removing events fired by the browser agent and replacing them with tessen actions.
Acceptance Criteria

[ ] Remove useInstrumentedData hook (check for any uses in the opensource/dev/docs sites or theme first but I didn’t find any)
[ ] remove all browser agent page actions from the theme
[ ] Edit useInstrumentedHandler code to remove browser option/fallback (we don’t need to pass an agent argument anymore)

[ ] Check and update the use of useInstrumentedHandler in any theme components
[ ] Check and update the instrumentation prop on any theme components
[ ] Add warnings to useInstrumentedHandler for malformed category or event names

eventName is camelCase
category is Title Case

[ ] Add warnings to createtessen.js for malformed category or event names
[ ] Update any tests affected
[ ] Update any documentation/wiki references to the browser events. Remove the documentation for useInstrumentedData
[ ] Update any dashboards tracking browser events from theme components (here are the most important)

[DevEn] External I/O & Quickstarts Ecosystem
New Relic I/O Program Dashboard
[DevEn] Docs Ecosystem

@roadlittledawn mentioned that we need to verify the theme is not sending any browser agent page actions..

looks like the theme sends two PageAction actions called:

navInteraction
swiftypeSearch_input

Leaving this in open for now, once all the sites are updated with the new theme we'll do one final pass to check the charts are all correct

We're going to update the dashboards as we complete the other tickets.


AKAudioPlayer - Playing from certain time

The fix for iOS 11 crash #945 seems to have messed up the working of play(from time:) i.e player doesn't restart. Perhaps moving stop to the main thread is creating a race condition.

oh crap.  Should we revert for now?

From the discussion in #940, I suppose dispatch_async is needed only when called within the completion handler.

There have a been a number of changes to AKAudioPlayer in the develop branch, is this still an issue and if so can you make a pull request with a fix?


Gradle wrapper should be run to allow ./gradlew

Runing ./gradlew <command> is only possible after running gradle wrapper

Most welcome, thank you for merging my PR :)


Building an extension for reconcile-csv

Building on @psychemedia on issue 933 (https://github.com/OpenRefine/OpenRefine/issues/933#issuecomment-72378546) to build container for running CSV backed reconciliation services using the Open Knowledge Lab Reconcile-CSV server : Reconcile-CSV container.
My thoughts were on building a plugin that will provide:

the reconcile-csv jar file
a Javascript library to upload the csv and pass the parameter to the jar file
a way to start the service and add the reconciliation service to OpenRefine.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I've just posted some more thoughts about running reconciliation servers in docker containers that could then be linked to an OpenRefine container: OpenRefine Style Reconciliation Containers.

I think it would be great to have it as an extension, that would not use CSV files but any OpenRefine project. You could just reconcile a column to any other project in OpenRefine.

Closing as duplicate of #2003.


Unittest test discovery misses tests in folder after adding init.py

Describe the bug
[A clear and concise description of the bug]
Steps to Reproduce

Create a new python project
set unittest as the testframework
add test_1.py
add a new folder eg. "Uppercase" and add a new test "test_Upper.py"
Note test_Upper.py is missing in Test Explorer after discovery runs
Add "init.py" to "Uppercase" folder
Note test_Upper.py is still missing
edit test_Upper.py and save
test now appears in Test Explorer

Expected behavior
After adding init.py to a test folder, discovery should find all the new tests the first time, without requiring the user to modify each file.
Additional context and screenshots
[Add any other information such as screenshots, error message, or stack trace]

This is due to us filtering test discovery results to source paths in ITestDiscover sources.
We run discovery on the project folder and tests can be discovered outside the list of files that have changed.  Previous Test Explorer thought all files changed, but since they fixed that we now see issues like this.


The artifact src should be configurable

Fixed by https://github.com/mairatma/liferay-gulp-tasks/pull/8


Resize Crop Mirror - HOST Tensor AVX2 Support and Vectorized HIP support [Old]

*Added for U8 , F32 , I8 , F16 variants
*added for PKD3,PLN3,PLN1 with toggle

Issued a new PR. Added changes to new branch which is updated with master
https://github.com/r-abishek/rpp/pull/90


Update integration documentation for using kong with knative

docs.konghq.com url(s):

Summary
Provide step by step guidance for configuring kong with knative.
Also, correct some details within 1.3.x documentation
https://docs.konghq.com/kubernetes-ingress-controller/1.3.x/guides/using-kong-with-knative/#documentation

Hi @ccfishk ! Thanks for your submission, but we need more information to go on.

Also, correct some details within 1.3.x documentation
https://docs.konghq.com/kubernetes-ingress-controller/1.3.x/guides/using-kong-with-knative/#documentation

Can you please point out what is incorrect in the document that you linked?
Re:

Provide step by step guidance for configuring kong with knative.

What exactly are you asking for here? If you looking for instructions from the knative side, we generally don't document external products/software. Can you please specify what you think is missing?

https://docs.konghq.com/kubernetes-ingress-controller/1.3.x/guides/using-kong-with-knative/#documentation
Incorrect Part:

kubectl patch configmap/config-network
--namespace knative-serving
--type merge
--patch '{"data":{"ingress.class":"kong"}}'
"kong" is a default ingress.class name, and the value is configurable.
echo '
apiVersion: v1
kind: ConfigMap
metadata:
name: config-domain
namespace: knative-serving
labels:
serving.knative.dev/release: v0.13.0
data:
<IP_ADDRESS>.xip.io: "" <<<<<---- dont need the subdomain, LB external cluster ip/hostname would be good satisfy the configuration.
' | kubectl apply -f -
configmap/config-domain configured
For convenience, user is able to access the service using following format
curl --header "Host: http://svc-name.namespace.proxy-hostname" http://proxy-hostname-ip

FYI - This Docs page currently links to this doc page for using Kong with knative and is unfortunately responding with a 404. We have customers asking if this is still supported as a result of it being inaccessible in the documentation.

This issue was fixed in the older version.
In the latest versions of KIC, Knative is no longer supported, (see the notice in the docs as well) so this doc no longer exists.


Over-Read request sent to origin when issued a pgRead

When XRootD sends a pgRead to the pelican plugin, the last block may request more bytes than the size of the file, such that offset + request_size > file_size.  The built-in http plugin catches this case and restricts requests to the file_size maximum file size: XrdClHttpFilePlugin.cc
When the requested bytes range is larger than the size of the file, the xrootd origin will return the response headers, then close the connection without sending the data.  This causes the curl library to return error code 18: transfer closed with outstanding read data remaining.  I have replicated this error with multiple production pelican caches:
curl --output /dev/null http://osg-chicago-stashcache.nrp.internet2.edu:8443/icecube/PUBLIC/groups/arasoft/raytrace_timing_tables/arrivaltimes_station_100_icemodel_40_radius_300.00_angle_1.00_solution_0.root
curl --output /dev/null https://sdsc-cache.nationalresearchplatform.org:8443//icecube/PUBLIC/groups/arasoft/raytrace_timing_tables/arrivaltimes_station_100_icemodel_40_radius_300.00_angle_1.00_solution_0.root
curl --output /dev/null https://osg-sunnyvale-stashcache.nrp.internet2.edu:8443//icecube/PUBLIC/groups/arasoft/raytrace_timing_tables/arrivaltimes_station_100_icemodel_40_radius_300.00_angle_1.00_solution_0.root

The pelican platform should restrict the maximum size requested from the origin to the file size, similar to how the built-in http plugin.

IIRC, we tracked this down to an invalid response from an older version of the XRootD HTTP server.  The xrdcl-pelican behavior could be slightly improved but is correct in the presence of a well-behaved server.
Closing as "won't fix" unless we come up with another case where this bites us.


Empty live instances list

For some reason, live instances list is empty even if I'm 100% there should be at least one live instance of a given class.

The "💩 Heap Objects" page? Totally empty? o_O
What app are you testing this in? Is it open source?

The "💩 Heap Objects" page? Totally empty? o_O

Yes

What app are you testing this in? Is it open source?

Nope. Could you tell me where to breakpoint to try to figure out the problem?

Somewhere in FLEXLiveObjectsTableViewController

These conditions:
https://github.com/Flipboard/FLEX/blob/ab9515caafc5d16b44e668f9450e8ac0cd8f4f07/Classes/Utility/FLEXHeapEnumerator.m#L105-L106
are false:
(lldb) p (uintptr_t)lock_zone
(uintptr_t) $19 =<PHONE_NUMBER>

(lldb) p (uintptr_t)unlock_zone
(uintptr_t) $21 =<PHONE_NUMBER>

(lldb) p MAX_REALISTIC_ADDRESS
(uintptr_t) $20 =<PHONE_NUMBER>

What architecture are you on? 32 bit or 64 bit ARM?

I ask because your MAX_REALISTIC_ADDRESS is set to INT_MAX, which means you aren't on arm64, but your pointers are using 33 bits, which means it is a 64 bit architecture. Are you testing this in the simulator? Or is this arm64e perhaps?

Sorry for the late reply. In simulator, Heap Objects and Live Instances of a known VC are empty, on an iPhone 8, Heap Objects is not empty, but doesn't show my VC, and the Live Instances of the same VC is empty too.

Is that when using the patch from my repo?

Not yet, I'm installing it now and let you know.

It now shows stuff in the Heap Objects in Simulator too, but it still can't find my VC (which is actually on the screen behind FLEX).

__LP64__ is defined and the introspection->enumerator && lockZoneValid && unlockZoneValid returns true.

This never evaluates to true:
https://github.com/Flipboard/FLEX/blob/b64cd37ec6d920ac18d5cbe18b4667cbe85a9f3a/Classes/GlobalStateExplorers/FLEXInstancesTableViewController.m#L63

Wow, that's gotta be it, haha. I wonder whose idea it was to use strcmp() instead of converting them both to NSString.
I'm signed off for the night, but I'll fix that tomorrow ASAP and merge it into master (which will close this issue automatically). Thanks for your help man!

A better and faster solution entirely is to just compare classes directly, and not their names, now that I think about it

Thank you for the help! Wish I could actually contribute with PRs but I still have to understand the code. I tried to fix #235 but couldn't do it.

Sure thing!
Just gotta dive right in, and don't be afraid to change stuff (like how I added a new class and inserted it into the class hierarchy). If you're concerned about how to structure a change like that, feel free to ask for advice in the issue/PR!
(Though I do agree, the project structure is kinda confusing; folder and class names aren't as clear as they could be)

One thing I thought and I'd want about the project is to use tables instead of programmatically creating views and constraints.

Not sure what you mean by "use tables," can you elaborate?

For example, this class manually creates and positions its subviews, instead of using a UITableView with multiple cells.


Keep a form active after submitting.

Is your feature request related to a problem? Please describe.
I would like to be able to stop the form from quitting after submitting. In my use case I want to use the form component to browse previously submitted forms as wel as create new responses.
Describe the solution you'd like
I'd like to be able to continue using the form after the user has submitted (or aborted it). This way I can use the form both as a way of getting the information and presenting the information.
Additional context
An small(ish) example of what I am trying to achieve can be found on here

Fixed it by creating a new form and resetting the focus.
Not sure why the reset of the focus is necessary but it seems to work.
Closing.


Add notify event to seo rebuild cli command

1. Why is this change necessary?
Currently, the only way to react to SEO Index rebuild via CLI is via a hook on a called function inside the command. A dedicated notify-event would be preferable as it is potentially more update-safe.
Also, every time a hook is used, a little kitten dies.
2. What does this change do, exactly?
Add a notify-event to \Shopware\Commands\RebuildSeoIndexCommand::execute() named Shopware_Command_RebuildSeoIndexCommand_CreateRewriteTable, triggered once for each subshop like in the CronJob implementation
3. Describe each step to reproduce the issue or behaviour.
Rebuild SEO-Index via CLI command. All options described here fail.
4. Please link to the relevant issues (if any).
-/-
5. Which documentation changes (if any) need to be made because of this PR?
The new event could be added to this article.
6. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-22971
Please use this issue to track the state of your pull request.


Use better deployment solution for backend

Backend uses Flask development server which is not suitable for the production environment. We should find better solutions.
Gunicorn might be the easiest option. We will need to add more logs once we migrate to an actual server.

Is this fixed now?

I did make up a plan to migrate to Gunicorn but I haven't found time to implement&test it. After migrating to Gunicorn, I also need to implement a more robust logging system that redirects logs to CloudWatch (Gunicorn's default is to redirect to a file) so this is a bigger project than I originally thought.

Gotcha, thanks.


Initial commit for data acquisition pipeline

This is an initial pass for data acquisition. It'll be cleaned up later.


Persistent hostid mismatch error

Just installed this, enabled web server and went into the Pool Stats tab. Getting this familiar error:

Mismatch between pool hostid and system hostid on imported pool. This pool was previously imported into a system with a different hostid, and then was verbatim imported into this system.

The error doesn't show on zpool status on the host.
It semi makes sense considering that what it is saying is true and the container doesn't share my host's hostid (afaik)
I'm also using NixOS, which could have interesting consequences.

I'm afraid I can't replicate the issue. Does the issue on zfsonlinux github apply? https://github.com/zfsonlinux/zfs/issues/9367#issuecomment-536045345
Additionally repo is just my docker-compose/dockerfile for building the image, if the issue happens within ZFS or within the zfswatcher application I can't really do anything to fix it.

Thanks for the quick reply. My first reaction was to go and ask if anyone else had the same behavior, I understand that it isn't really a thing to fix here (probably)
I will investigate the linked issue, thanks!

I got the error today, so I could actually replicate 👍
It seems like ZFS just writes the hostid into /etc/hostid, so mounting it in fixed the duplication detected. https://github.com/Pectojin/docker-zfswatcher/commit/e016d6fce2490dc0d2a912a5dd21215c9dd4f586
I also regenerated the hostid as explain in the zfsonlinux comment, but I'm really not sure it did anythong. Oh and I had to reboot too.


Configuration in Helm

AFAIK, the way to configure environment variables when using helm is to use helm edit [chart] and edit the rc's template. I think it would be great if helm would allow (in some way) to change the variables set in the template, possibly doing something like this:
# ./postgres.env.dist
POSTGRES_USER=...
POSTGRES_PASSWORD=...

...and then run deis install --with-config=./postgres.env or similar which would allow to replace/append environment variables without changing the chart itself and also to allow committing .dist files in git repositories.

this document may be of interest to you :)
https://github.com/helm/helm/blob/master/docs/generate-and-template.md
Some examples on how we generate secrets for workflow's components can be found here.

@bacongobbler that seems to do it! Thanks!


add cd step to publish extension to google firefox extension marketplace

I'm fully versed in getting a Firefox extension signed and published, if you still have a need for help, let me know. I would really love to see the Firefox version updated to something past 0.0.1. 👍🏻

@geeknik did you manage to create an automatic flow for signing and publishing a Firefox extension?
If so, we would love to get your help!

@geeknik did you manage to create an automatic flow for signing and publishing a Firefox extension?
If so, we would love to get your help!

should be automatically published. will be tested on next release


feature: add default_team_id in settings for incoming tickets

Hello,
For setting a default team id for incoming ticket should be helpful this feature in the settings section where you can select a default team for incoming tickets.
Thanks
MM

Ok, i fixed all the issues

Great! thank you!


Handle inverted wtime btime order.

Although the majority of UCI interfaces do the sensible thing and just send wtime btime in that order, for whatever reason ChessBase programs can start to send them in inverted order in the middle of a game. Detect and handle this.
Not required for the 4k tournament as the command format is defined in the rules.
No size impact.

How nice of ChessBase to keep us on our toes. Thanks.


Update clickhouse features, doc

Changes

Current dependencies on/for this PR:

main

PR #394   👈

This stack of pull requests is managed by Graphite.


How should equality for a Map behave?

What I have implemented now I always knew might be problematic, so this is a TODO from the code that should be discussed among the group, and particularly after several users have now had some time using PISA 3.
See the __eq__ method of Map for current implementation of the logic:
https://github.com/jllanfranchi/pisa/blob/cake/pisa/core/map.py#L1227

Current implementation seems ok for what people need, closing.


simple for loop

I cant figure out how to make a for loop work
- for (var x = 0; x < 3; x++)
  li item

I tried these:
- for (var x = 0; x < 3; x++)
for (var x = 0; x < 3; x++)
for x = 0; x < 3; x++

errors:
Expected tag name after `<`
...{{for (var x = 0; x < 3; x++)}}}
                        ^

Jade syntax error: Expected tag name after `<`
(var x = 0; x < 3; x++)
               ^

Jade syntax error: Expected tag name after `<`
x = 0; x < 3; x++
          ^
``

This is not possible to do this in meteor-jade, because the code is not compiled in JavaScript function but in a abstract structure that handle reactivity. For this kind of use case, in both meteor-jade and spacebars, you have to use a template helper:
template(name="myTemplate")
  ul
    each items
      li this

Template.myTemplate.helpers({
  items: function() {
    return ["item1", "item2", "item3"];
  }
});

Once again, there is nothing specific to jade here, this is just the way meteor works.


[Feature Request] Populate Series Volume (Start Year)

I am requesting a feature to capture a series Volume (series start year) field that has moved from the issue resource to the volume resource. My collection's file naming format uses the Volume field to differentiate series with the same name with different runs.
I'm proposing a second call to the volume resource to capture the series start_year and deck values.
This is an example using an issue from volume 3 of Secret Origins.
Issue Look Up:
https://comicvine.gamespot.com/api/issue/4000-483313/?api_key=MY_KEY&format=json
$.results.volume.api_detail_url
[
"https://comicvine.gamespot.com/api/volume/4050-73215/"
]
Volume Look Up:
https://comicvine.gamespot.com/api/volume/4050-73215/?api_key=MY_KEY&format=json
$.results.start_year
[
"2014"
]
$.results.deck
[
"Volume 3."
]
The request may not be realistic as this would add another API call to the process.

I forgot there was a "Use the series start year as the volume number" setting somewhere. I found it in the code but not in the GUI. I'll keep poking at it.

Thanks. I must have looked at that page 100s of times....


vocms0255 and vocms0250

TaskArchiver on 250 seems to not be updating:
2018-02-20 19:07:23,350:140662893139712:INFO:TaskArchiverPoller:Marking subscriptions as Done ...
2018-02-20 19:07:25,431:140662893139712:INFO:TaskArchiverPoller:Marking subscriptions as Done ...
2018-02-20 19:07:26,036:140662893139712:INFO:TaskArchiverPoller:Marking subscriptions as Done ...
2018-02-20 19:07:26,544:140662893139712:INFO:TaskArchiverPoller:Marking subscriptions as Done ...
I have been restarting this agent a lot today.
JobAccountant seems fine.
vocms255 seems to be fine now but I just want to check because it has also been having a lot of problems.

TaskArchiver was completely down in vocms0250. The agent has 2 other heart beat alarms, one for JobAccountant which is just fine and one for a WorkQueueManager thread. Looking at the history, there has been cases that that thread took longer than 2h to run, so I'll just leave it as it is.
JobAccountant is going through a large backlog in vocms0255

I seems JobAccountant in vocms0250 is just backlogged. But TaskArchiver is seems to be stuck. I am restarting the agent.

since it is not happening anymore closing the issue.


html-minifier library causes adapter-node to break

Describe the bug
The docs provide a way which you can use to minify the HTML that is rendered. However, if you use that method, it breaks adapter-node.
This is the error output
    require.resolve("../lib/utils.js"),
            ^

ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and 'C:\Projects\kudadam\package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///C:/Projects/kudadam/build/server/chunks/server-b56e4b54.js:24606:6
    at file:///C:/Projects/kudadam/build/server/chunks/server-b56e4b54.js:24713:3
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async Server.init (file:///C:/Projects/kudadam/build/server/index.js:3183:22)
    at async file:///C:/Projects/kudadam/build/handler.js:18886:1

Reproduction
I have made a repo with the bug: Repo Link
Logs
require.resolve("../lib/utils.js"),
            ^

ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and 'C:\Projects\kudadam\package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///C:/Projects/kudadam/build/server/chunks/server-b56e4b54.js:24606:6
    at file:///C:/Projects/kudadam/build/server/chunks/server-b56e4b54.js:24713:3
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async Server.init (file:///C:/Projects/kudadam/build/server/index.js:3183:22)
    at async file:///C:/Projects/kudadam/build/handler.js:18886:1

System Info
$ pnpx envinfo --system --binaries --browsers --npmPackages "{svelte,@sveltejs/*,vite}"
.../Local/pnpm/store/v3/tmp/dlx-3476     |   +1 +
.../Local/pnpm/store/v3/tmp/dlx-3476     | Progress: resolved 1, reused 1, downloaded 0, added 1, done

  System:
    OS: Windows 10 10.0.19044
    CPU: (4) x64 Intel(R) Core(TM) i5-4300U CPU @ 1.90GHz
    Memory: 860.15 MB / 7.91 GB
  Binaries:
    Node: 18.12.1 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (108.0.1462.42)
  npmPackages:
    @sveltejs/adapter-node: 1.0.0-next.104 => 1.0.0-next.104
    @sveltejs/kit: next => 1.0.0-next.581
    svelte: ^3.54.0 => 3.54.0
    vite: ^4.0.0 => 4.0.0

Severity
blocking an upgrade
Additional Information
No response

Does it work if you make html-minifier a prod dependency so the build doesn't try to bundle it? If it does, we should probably add that to the docs, because it's likely to be a pain to get whatever this is doing to bundle correctly.

I have found a solution.
html-minifier can be installed as a dev dependency too.
This is how the code should be.
import { building } from "$app/environment";

const minification_options = {
	collapseBooleanAttributes: true,
	collapseWhitespace: true,
	conservativeCollapse: true,
	decodeEntities: true,
	html5: true,
	ignoreCustomComments: [/^#/],
	minifyCSS: true,
	minifyJS: false,
	removeAttributeQuotes: true,
	removeComments: false, // some hydration code needs comments, so leave them in
	removeOptionalTags: true,
	removeRedundantAttributes: true,
	removeScriptTypeAttributes: true,
	removeStyleLinkTypeAttributes: true,
	sortAttributes: true,
	sortClassName: true
};

/**@type {import("@sveltejs/kit").Handle} */
export const handle = async ({ resolve, event }) => {
	const response = await resolve(event);

	if (response.headers.get("Content-Type") === "text/html" && building) {
		let minify =  (await import("html-minifier")).minify
		return new Response(minify(await response.text(), minification_options), {
			status: response.status,
			headers: response.headers
		});
	}

	return response;
};


Simplify TOML syntax

This change is

Seems good, modulo one nit.
Previously, UK992 wrote…
> #### Simplify TOML syntax
>
>
>
>
>

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Cargo.toml, line 34 [r1] (raw file):

expat-sys = "2.1.1"

[target.'cfg(not(target_os = "macos"))'.dependencies]

Could you do cfg(any(target_os = "linux", target_os = "windows)) instead?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Cargo.toml, line 34 [r1] (raw file):
Previously, nox (Anthony Ramine) wrote…
> Could you do `cfg(any(target_os = "linux", target_os = "windows))` instead?
Android also use fontconfig and freetype-sys, should i add ``cfg(any(target_os = "android", target_os = "linux", target_os = "windows"))`` instead or keep it as it is?

Comments from Reviewable

Oh right. I think it would be better to not have a negation in there yes.

Fixed.

:pushpin: Commit 0b27af3 has been approved by nox

@bors-servo r+
Previously, UK992 wrote…
> Fixed.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

:hourglass: Testing commit 0b27af3 with merge 9dc8479...

:sunny: Test successful - travis


[Task-10][Frontend] As a logged in user, I can create a article

Why
User should be able to create articles
Acceptance criteria

Create a nice looking article create form
Leverage the use of view_component to show the form, input field, text filed and button
write appropriate tests for the component
Publish components in storybook

Who Benefits?
Users

Should we use a Markdown editor to write articles? :)
I think it's quick to implement and the result can be really nice (even if it is not directly related to ViewComponents)