Cannot set property 'loop' of null

Uncaught TypeError: Cannot set property 'loop' of null
Error in instance.refresh() function when change parameters like volume or loop on paused instances, because this._source is currently null.
Workaround - do not trigger setters, direct change instance._loop, instance._volume etc.
Not a real problem, i just writing a function to help me manipulate multiple instances of sound at the same time and get this in process. Sorry for my bad english.

It's a real big problem i think. Tried to use this lib in real project. I wrote externs (for haxe) and in project setting volume leads to uncaught exception.

Thanks for letting me know. Will fix!

Didn't have time to investigate properly, but it seems that _source in refresh method is null. But why it is null i don't know. I clearly see that value to it assigns during play() call. If i can help some how fill free to ask.


Failed to find a kernelspec to use for ipykernel launch

Environment data

VS Code version: 1.50.0-insider (user setup)
Extension version (available under the Extensions sidebar):2020.9.106814-dev
OS and version:  Windows_NT x64 10.0.18362
Python version (& distribution if applicable, e.g. Anaconda): Python 3.8.5 32-bit
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Jupyter 1.1.5,

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Opening Jupyter files and be able to run code
Actual behaviour
It shows.  Failed to find a kernelspec to use for ipykernel launch

Steps to reproduce:
I open Jupyter in VSCode insider then this shows up "Failed to find a kernelspec to use for ipykernel launch"
Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

The issue appears to be back in version: v2020.12.414227025

Can second this, appears to be back in v2020.12.414227025

I concur, I am facing the same error message and issue.

The following seems to have gotten rid of the error for me, occurred on a fresh install:
pip install ipython pip install ipykernel

The following seems to have gotten rid of the error for me, occurred on a fresh install:
pip install ipython
pip install ipykernel
If you already have a kernel installed, upgrading it may work too. Try:
pip install --upgrade ipython
pip install --upgrade ipykernel

i've fixed the problem as well using this :
pip install --upgrade ipython
pip install --upgrade ipykernel

I am still facing this issue?

I was facing this issue consistently, and restarting ipykernel would often solve the problem. However, lately nothing would work (i.e. uninstalling and reinstalling python, ipython, ipykernel, upgrading ipython,ipykernel). I'm using VSCode insider and ssh'ed to remote machine.. any help please?

@TogrulKazimov
Please could you create a separate issue with the logs and detailed of your environment.

Issue seemingly persists. Found no way workaround so far

@doubleplusnice
Please could you create an issue with the details.
I'd like to get you unblocked

The issue appears to be back in version: v2020.12.414227025

Same error with VS Code, started VS Code as administrator and that fixed the issue. It seems I used "all users" setup while installing Anaconda could be the reason VSCode could not load python kernel.

Same error with VSCode, i use the jupyter-extension in 2021.5.702919634,it cannot find the envs in my Anaconda @DonJayamanne

@tjucaokun you can hopefully remedy this by changing where your VSCode is pointing in terms of the local host.
First launch the Jupyter Notebook command prompt by searching "Jupyter" in your search. Then after it loads the info you need will be under "To access the notebook". Grab the http://localhost address and go to VSCode
Second hit this icon:

And add the address you just copied as a connection endpoint. Then it'll ask you to refresh the session and you should be good.
I ran into this today at work but realized it was just pointing at the wrong notebook session. After that you should be all set.

@suketubhavsar, @AGilarde12,@tjucaokun
Please could you file a new issue with the details of the error and environment.
I'd like to get you unblocked.
This issue had been closed for a while,  i.e. I want to help you get unblocked.

The following seems to have gotten rid of the error for me, occurred on a fresh install:
pip install ipython
pip install ipykernel
If you already have a kernel installed, upgrading it may work too. Try:
pip install --upgrade ipython
pip install --upgrade ipykernel

Thanks! I fixed my same issue to this thread by your method.
It should be known by other users who are searching for solutions.


smol ttweakiz

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


"typeScript language service abort 5 times in last 5 minutes"

VSCode Version: Code 1.9.0 (27240e71ef390bf2d66307e677c2a333cebf75af, 2017-02-02T08:31:00.827Z)
OS Version: Windows_NT ia32 6.1.7600
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.0.18

vue
liuji-jim
0.1.5

debugger-for-chrome
msjsdiag
2.5.1

ejs-language-support
QassimFarid
0.0.1

vscode-icons
robertohuertasm
7.1.2

JavaScriptSnippets
xabikos
1.2.0

Steps to Reproduce:

open folder
click any JavaScript file

I found the reason that the the file was deleted by 360！


Some recent changes to run with ROS_USE_PYTHON3 = "yes"

Hmm... you fix one issue, and two new unrelated issues from openembedded-core appear... I am following up on what broke the recent master

I just rebased and force pushed it; CI build job is restarted.

Just for the record, I successfully build bitbake core-image-ros-world (in total 4 test builds) with ROS_USE_PYTHON3 set and unset and with these two recent build configurations:
Build Configuration:
BB_VERSION           = "1.37.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "ubuntu-16.04"
TARGET_SYS           = "arm-oe-linux-gnueabi"
MACHINE              = "qemuarm"
DISTRO               = "nodistro"
DISTRO_VERSION       = "nodistro.0"
TUNE_FEATURES        = "arm armv5 thumb dsp"
TARGET_FPU           = "soft"
meta                 = "master:709b60a5e34a22aadb6dca7b888c010de8e6e4a4"
meta-oe
meta-multimedia
meta-python          = "master:3064819552cff0d6829b108e31aca9aa092c5f9d"
meta-ros             = "python3-manifest-change:6ddc0cc518ebcfdd6871774030bb5f91c09557d9"

Build Configuration:
BB_VERSION           = "1.37.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "ubuntu-16.04"
TARGET_SYS           = "arm-oe-linux-gnueabi"
MACHINE              = "qemuarm"
DISTRO               = "nodistro"
DISTRO_VERSION       = "nodistro.0"
TUNE_FEATURES        = "arm armv5 thumb dsp"
TARGET_FPU           = "soft"
meta                 = "master:709b60a5e34a22aadb6dca7b888c010de8e6e4a4"
meta-oe
meta-multimedia
meta-python          = "master:2f7de931885c1b9e63c4e4238f0f7ad1388e8b6d"
meta-ros             = "python3-manifest-change:6ddc0cc518ebcfdd6871774030bb5f91c09557d9"

CI is green; @rojkov This is really more your patch than mine; any comments? Once you update the git submodule in your intel-refkit layer to include this commit in meta-ros, you can drop the change in your layer.

LGTM.
re refkit... it was rather dead than alive at least a couple of my assignments ago. Most probably it won't be updated.

re refkit... that is unfortunate; it was some motivation last year to know that refkit users are some users of meta-ros out there; possibly, the refkit users step up and maintain the refkit layer now.


Sample on how to set parameter value from different activity

https://docs.microsoft.com/en-us/azure/data-factory/parameterize-linked-services
So i have a use case where my File Size to be ingested is very dynamic. it can range from 1M to 10GB.
This would help me substitute the username that i use to connect to ADW dynamically which could use higher resource class
SO the plan is to use GetMetada to check on the Size of File and than use IF Logic to update the username.
But how do i set the value of parameter from IF Block ? Is this Possible ?
Will this parameterization also work for Values(Connectionstring) stored in Azure Keyvault, any sample on that ?
Also In General,
Can we also have parameter value be pointing to Azure Keyvault,
Like i have to pass the Key in URL to invoke Azure Function Which i am storing as Parameter at Pipeline level in plain text.
Would be nice if i could specify that value be read from Keyvaalt.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bf75315-da09-2cf9-6db5-d12fcc804283
Version Independent ID: bf4deb1b-fe88-a9cb-3605-0500a60fb882
Content: Parameterize linked services in Azure Data Factory
Content Source: articles/data-factory/parameterize-linked-services.md
Service: data-factory
GitHub Login: @douglaslMS
Microsoft Alias: douglasl

@nssidhu Can you share the document you are referencing?

@nssidhu Can you share the document you are referencing?

[(https://docs.microsoft.com/en-us/azure/data-factory/parameterize-linked-services)]

@nssidhu your question is a bit complex for documentation feedback.  We would like you to ask your question in the forums here:
https://social.msdn.microsoft.com/forums/azure/en-US/home?forum=AzureDataFactory
Hopefully the community will be able to address your question, and if an understanding is reached, open another documentation issue and we will take another look.


Faster router

I've done a few different things here.

Removed the simple router since I think the regular route with a large enough cache should be very close in terms of speed
Refactor the existing code
Added a lru_cache to the get request
Made a really simple hash lookup so it doesn't need to loop over all routes

If this lands because of 4. regexes with / in them won't work which is a bit of a trade off. Right now though regexes with : in them will have issues because of the split so I'm not sure it's worse? Might be worse thinking about limiting even further like flask does since that will improve lookup performance.

Excellent work!  I added support for routes with / regexes, and added it to the tests.  I'm seeing 34,676 req/sec against cached routes now! :D


gstreamer-plugins-bad: build gtksink plugin

Motivation for this change
Corebird requires gtksink gstreamer plugin to play videos.¹ The plugin, however, is only built when GTK is available.
This patch adds gtk3 as a dependency to gstreamer-plugins-bad package, enabling the build of gtksink.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Tested by running Corebird and playing a video
[x] Fits CONTRIBUTING.md.

@jtojnar which attribute corresponds to this expression? Its not gst-plugins-bad.

@FRidh yes, it is gst-plugins-bad, I updated the commit message.

So its
$ nix-build -A gst_all_1.gst-plugins-bad

and not
$ nix-build -A gst-plugins-bad

Adding gtk adds 60 MB to the closure. How common is this plugin you need?

You are right, it is for GStreamer 1.
At least Corebird requires the gtk sink, not sure about other packages. Should it be made optional like FAAC support?

Should it be made optional like FAAC support?

I think that would be better, yes. Say we have corebird, then it could override the expression using a version that has this plugin.

@FRidh Updated to make GTK optional.


Dev mode should use separate scopes for recompiling source and tests

Dev mode uses the same dependencies for recompiling source and tests.  Instead, it should handle all of the different possible scopes and maintain separate lists of dependencies when recompiling source or tests.

There's a bigger issue than just separating out compile scope vs test scope dependencies.
It also seems, from looking at #1024, that the transitive dependencies of the liberty-maven-plugin become part of the compilation classpath (the test compile path in that case).    While it might have been a useful starting point to grab the TCCL which loaded the liberty-maven-plugin and use its path elements, that might have to be revisited if we truly wanted to honor a user's dependencies.

I wonder if the fix in  https://github.com/OpenLiberty/ci.common/pull/246 has any impact on this issue?

I wonder if the fix in  https://github.com/OpenLiberty/ci.common/pull/246 has any impact on this issue?

This issue still occurs because both source and test recompiles use the same list of artifacts which uses DevMojo's dependency scope: https://github.com/OpenLiberty/ci.maven/blob/aff0445bb1d9c67f48ae778778c37482c0c675b3/liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java#L77
With https://github.com/OpenLiberty/ci.common/pull/246, the transitive dependencies of the liberty-maven-plugin itself are no longer included.
But the dependencies of the user's projects (both compile and test dependencies) are included as part of the recompilation classpath, which works for most cases but it would be more correct to separate them instead.

Fixed in the above PRs.


data.frame → Polars DataFrame wrapper

I'm wondering if there is interest in a feature-gated conversion between Polars and R data frames, in the same way we are doing for ndarray. So the module would implement the appropriate To/From Robj traits on DataFrame.

I'm interested. I'm currently simulating passing a data.frame to Rust that I would like to clean up at some point - where I throw a data.frame at an R function and then write it to a tempfile that Rust can pick up. Polars has been easy to work with so thumbs up there!
#' execute_lr
#' @param file_path
#' @param target
#' @export
execute_lr <- function(dataset = NULL, target = "chas") {
  tmp <- tempfile()
  on.exit(file.remove(tmp))
  write.csv(dataset, tmp, row.names = FALSE)
  resp <- .Call(wrap__execute_lr, tmp, target)
}

I mean I think you can work with an R data frame in extendr currently, you don't have to save it to a file or anything. You will just have to treat it like a list of vectors (which it is).

Something that's been discussed in the discord is the fact that Polars keeps its series in the Apache Arrow format, and the arrow package for R seems to be able to use data frames consisting of Arrow columns directly. So there should be some way to just return a pointer from Polars directly to R with the right attribute in order to enable the altrep that must be in use here. However I'm not really sure I can do that myself.

Actually there seems to be a neat Data transfer protocol called Flight which might help.

I think we can first convert the DataFrame into multiple RecordBatch using polars: https://pola-rs.github.io/polars/polars/frame/struct.DataFrame.html#method.as_record_batches
Then using the arrow library for Rust we can serialize the data to bytes: https://docs.rs/arrow-flight/latest/arrow_flight/utils/fn.flight_data_from_arrow_batch.html
Then finally the feather library in R accepts a raw buffer containing the data: https://arrow.apache.org/docs/r/reference/read_ipc_stream.html

The only issue I have with this is that it seems that all the data will be copied into R, but if we already have the data in the right format, can we not just pass a pointer to the data without copying at all?

Arrow Flight is cool, but I think it's not what you want here. You cannot "transfer" a pointer of the memory that the processes don't share.
Sorry, did you already read the discussion around https://github.com/extendr/extendr/issues/310? Just in case you haven't find my proof of concept implementation yet, it might help.

Yeah I think Arrow is more designed for transferring over a network? So it's maybe overkill here.

Arrow is more designed for transferring over a network

NO. Arrow Flight is, but Arrow is a memory format.

Uh yes sorry I meant that Flight is overkill.

My understanding of the different between my work and #310 is that I'm trying to get Rust to convert Polars DataFrame to an R data.frame, whereas your work is about providing APIs for Polars functions to R, so that the actual data will still live in Rust. If we had a full port of Polars completed then my work would not be needed, but I think my approach might be a bit easier in the short term.

Yeah, you are correct about the difference, but my point was just to show you how to use ALTREP instead of "getting out a slice out of a Series." I'm not sure if it's suitable here, but you don't need to fear to use ALTREP.

Yes, you might be right about that. I'll have another look at your code.

The essence is that any iterator, including an Arrow slice can become an ALTREP Integers, Doubles or Strings.
The data source can be a series or a wrapped slice all held internally as an ExternalPtr object.
I may separate the from_values constructors for Integers and Doubles so that ALTREP is
more explict as the setup cost for ALTREP is still quite high.

The discussion in https://github.com/apache/arrow/issues/12102 is very exciting. It looks like we can convert data from Rust to R using the C/FFI interface. I suspect internally the R arrow library uses ALTREP, but we don't need to worry about that ourselves since it will be handled for us.

@andy-thomason @Ilia-Kosenkov
Sorry, let me clarify. I don't intend to discourage the great efforts by @multimeric and @fdrennan, but do you think there are chances that we accept this suggestion?
My feeling is that data.frame is a bit too high-level to support officially by extendr, at least at the stage. Their internal specs are hidden in the source code of base R (e.g. I've never found the official document that says row.names is c(NA, -nrow) when there's no rownames) and I expect it would be a tough job to support all the subclasses properly.
(To be clear, since none of us seemed to comment actively on their discussion, I tried to respond as far as I can, but I'm not super passionate about handling data.frame on Rust's side)

I know you're not asking me, but I would have said that data.frame is a fundamental part of R, and therefore ideally would be supported.
The internal specs of the data frame may be convoluted, but it's still just a list with attributes. I don't think it should be too hard to work them out. The subclasses are not needed I think, because they're not in base R.
Specifically a Polars wrapper is a bit more niche, granted, and I would happily put it into its own Rust crate. It just seems like it would be easier to keep it here. To be clear I'm not asking you guys to implement this, I'll do all that.

To be clear I'm not asking you guys to implement this, I'll do all that.

Yeah, so I'm wondering if it's better to develop it as your own crate rather than trying to add a feature directly to extendr-api crate...

One reason for keeping it in extendr-api is because of the accursed trait impl rule. I won't be able to impl From<DataFrame> for Robj and vice-versa if I have my own crate, because neither type will be owned by me. Obviously I can write a conversion function or a newtype wrapper but neither solution is ideal.

I think data.frames are an essential part of base R, and are absolutely needed in extendr. data.frame, unlike tibble, can contain only primitive vectors as its columns, and we already support almost all types (except for raw I think). I believe being able to access data.frame, subset it and create a new one should be part of the extendr API. I did not check it yet but I assume there should be some sort of C API for handling data frames, so all we need to do is carefully wrap it and provide appropriate trait implementations.
I also belive it should be done in pure extendr without external dependencies, and any other features like support for arrow/other containers or interoperability should be added in separate crates.

Thanks, I agree it would be great if we could support it, but let me add some information.

there should be some sort of C API for handling data frames

As far as I know, there's no such things. That's why I'm saying it's "too high-level."

data.frame, unlike tibble, can contain only primitive vectors as its columns

No, it can contain arbitrary data as long as their NROWs are the same. It's extremely hard to handle things right (I've seen mistakes in many packages including tidyr and vctrs). For example, can you imagine how to subset the rows of the following data.frame, whose columns have different dimensions?
d <- data.frame(x = 1:3)
d_inner <- data.frame(a = 11:13, b = 21:23)
d$y <- d_inner
d
#>   x y.a y.b
#> 1 1  11  21
#> 2 2  12  22
#> 3 3  13  23

Created on 2022-01-10 by the reprex package (v2.0.1)

I wrote a lengthy response then saw @yutannihilation message and had to remove everything. >_<

As far as I know, there's no such things. That's why I'm saying it's "too high-level."
I see, I thought I saw some functions prefixed with Df_ and assumed it was something related to data frames. Perhaps I got it all wrong.

No, it can contain arbitrary data as long as their NROWs are the same.
Again I was under a false impression that this was somehow verified and disallowed.

For example, can you imagine how to subset the rows of the following data.frame, whose columns have different dimensions?
I worked with custom {vctrs} vectors, I think they did a great job re-thinking how subsetting works for data.frame-like types. But I agree it can be difficult.

I still believe it can be useful to have a type whose try_from or whatever trait can verify that we receive i) a list ii) all list items are of the same length (by 'length' I mean size measured like vctrs::vec_size()). We should also have a constructor that creates a list and ensures that all passed elements are compatible with data.frame description, as well as setting key attributes. This is the bare minimum that will definitely help to deal with data frames.

We already have ndarray wrappers in extendr-api, which seems pretty comparable to a polars wrapper.

True, but I'd prefer to have this feature-guarded. It is ok to have base array support and then ndarray-backed option, the same can be applied to data frames as well.

Sorry, I should have included these information before...
Yeah, vctrs does a great job. It's the achievement of years-long development by the full-time developers in RStudio (and of course excellent contributors). That's exactly the reason why I feel it's not very easy to implement such things, but I might be wrong. Our scope here is more limited and we can study their code.

Ok, what I am suggesting is to not discard the idea of having a 'better list' as a proxy for data.frame.

A note on row names of data frames. That trick with NA and number of rows seems to only affect printing (or I hope so), through format.data.frame. There is a call to .row_names_info(), which is .Internal(shortRowNames(x, type)).
Here is the implementation of this function https://github.com/wch/r-source/blob/trunk/src/main/attrib.c#L190-L210
Both showRowNames() and .row_names_info() seems to be only ivoked from format.data.frame(), and with type = 2. The logic behind these functions amazes me, not in a good way though.
I still think it is worth researching if a simple type like List can be created for data frames. https://github.com/extendr/extendr/issues/330 was a good start.

I'm not strongly for or against either of you, but it seems impossible for us to agree on what representation is best suited for data.frame? If so, again, I'd suggest to implement this as a separate crate first (I personally feel the implementation can go into Polars' side to some extent, considering they are interested in creating an R binding, but I'm not sure).

I don't think so? There is interest in a List-like wrapper struct which is analogous to say Matrix, and also in a polars conversion layer which is analogous to say the ndarray wrappers for matricies.

I see. Sorry for the noise.

It seems the team is not in favour of this within the base extender library: https://github.com/extendr/extendr/pull/357.


How to fill in inputs_for

I’m not sure if there’s a better place to ask questions.
When using inputs_for for a multiple inputs where each iteration is still an open form, how do you target each input with fill_in?
Example html:

Name: <input name="model[0][name]" id="model_0_name" />

Name: <input name="model[1][name]" id="model_1_name" />

conn |> fill_in("model[0][name]", "Name", with: "John Doe")
** (ArgumentError) Found many labels with text "Name":

Hmmm. That's interesting. That may be a case we missed.
@andrewtimberlake if you try the same thing but have the labels and inputs separated, does it work? I think it might have to do wih the implicit label <> input association (which we should handle)
In other words, does it work if it's like this?

Name: <input name="model[0][name]" id="model_0_name" />

Name: <input name="model[1][name]" id="model_1_name" />

They are actually separate. I’m using the <.input /> component (my example above was a simplified example using HTML as I tend to write it by hand.
The problem is that there are multiple labels with the same name

That sounds like a bug in that case -- but it's weird because that's exactly what our tests are testing. I wonder if there's something odd with inputs_for.
Can you confirm you're using v0.4.0, and is there a chance you could create a simple app that reproduces the error?

I have created a simple app that demonstrates what I’m trying to do:
https://github.com/andrewtimberlake/phoenix_test_inputs_for
Form at http://localhost:4000/test
Test in test/phoenix_test_inputs_for_web/live/test_live_test.exs

Thanks for the help.
In that same test, I used a label and a checkbox to add a new item because I couldn’t get the example from the Phoenix docs to work, how do I test with a button like this:
<button type="button" name="model[items][]" value="new" phx-click={JS.dispatch("change")}>
  add more
</button>

See: https://hexdocs.pm/phoenix_live_view/Phoenix.Component.html#inputs_for/1-dynamically-adding-and-removing-inputs

@andrewtimberlake any chance you could create a simple app (or modify the one you already shared) to reproduce the error you're running into?

Thanks @andrewtimberlake. The error you're seeing comes from LiveViewTest.
Unfortunately, LiveViewTest doesn't support performing a render_click (which triggers the phx-click) with something that only uses JS.dispatch (which is dispatching a JavaScript event to the DOM).
You can see that by running this LiveViewTest:
  test "add items", %{conn: conn} do
    {:ok, view, _html} = live(conn, "/test")

    html =
      view
      |> element("button", "add more")
      |> render_click()

    assert html =~ "Item 1"
  end

It fails with the same error:

 ** (ArgumentError) no push or navigation command found within JS commands: [["dispatch",{"event":"change"}]]

If you were to use something like JS.push("change"), then the test would send the "change" event to the LiveView.
Does that make sense?

Thanks for your help. I’ll see if it’s something we can fix in LiveView itself.

@andrewtimberlake happy to help. Just FYI, I don't know if LiveViewTest will be able to fix it either because a JS.dispatch/1 is dispatching events to the DOM, and LiveViewTest doesn't test JavaScript logic.


Feat: Front-end to create Paybutton

Description:
Adds a primitive form in the front-end to create paybuttons.
For now there is a field for userId, this will be removed in a subsequent PR that changes the endpoint to authenticate the request with supertokens and infers the userId. In another PR I'll add front-end validation for the form, similar to the back-end validation that already exists.
Test Plan:
Go to http://localhost:3000/paybuttons, log in as the default developer user (see #143) and try to create some paybuttons, sending the userId as dev-uid
Depends on:

[x] #143

Can we get some logic in there to detect which address format is being used and validate it (even when somebody tries to enter one and omits the prefix)? bch-js / xec-js should be able to do this.
Basically if somebody enters an address without the prefix, which is a very common thing to do, we should still support that -- but convert it to the standardized format with the prefix for storage.
Right now we're not doing address validation so I can enter a BCH address with an ecash: prefix and it will still add it even though it's an invalid address.

I mentioned in the description that the front-end validation would come in a subsequent PR.
As for the back-end validation, it already exists, although is not using bch-js for xec-js. We could make an issue to perform this migration; but then I would like to understand better this example where the user could enter a BCH address with an ecash: prefix, how would we go about telling if it is an XEC or BCH address? AFAIK they use  the same syntax, minus the prefix.

Can we get some logic in there to detect which address format is being used and validate it (even when somebody tries to enter one and omits the prefix)? bch-js / xec-js should be able to do this.
Basically if somebody enters an address without the prefix, which is a very common thing to do, we should still support that -- but convert it to the standardized format with the prefix for storage.
Right now we're not doing address validation so I can enter a BCH address with an ecash: prefix and it will still add it even though it's an invalid address.

I mentioned in the description that the front-end validation would come in a subsequent PR. As for the back-end validation, it already exists, although is not using bch-js for xec-js. We could make an issue to perform this migration; but then I would like to understand better this example where the user could enter a BCH address with an ecash: prefix, how would we go about telling if it is an XEC or BCH address? AFAIK they use the same syntax, minus the prefix.

That's why a lib is nice -- because you can verify it with the checksum. If you just swap out the prefixes, it'll be invalid because the checksum is calculated using the prefix as well.


Some errors happend after I sent an comment under a issue

I got this error after send an comment
template: repo/issue/view_content:56:39: executing "repo/issue/view_content" at <.Poster.Id>: nil pointer evaluating *models.User.Id
I checked my ID in User table in MySQL but I have this problem now!

Hi, what is your version of Gogs? And can you reproduce this on https://try.gogs.io ?

ping @mafrashteh

Close due to lack of feedback.


PCP-13: Unify the thread pools in TiKV

Description
Now we have too many thread pools for read operations in TiKV. It increases the cost of context switches and thread scheduling. If we can unify the thread pools in TiKV, we can improve the performance. However, existing thread pools for common IO use are not suitable for us. Instead of balanced scheduling, we hope different tasks can have different priority and big tasks with lower priority don’t block small tasks. Therefore, we need a thread pool for prioritized tasks.

Objective: TiKV with the new thread pool should get its peak performance notably improved and not bring side effects (like latency increase or jittering). Meanwhile, we can limit the impact of big tasks or tasks with low priority on small or important tasks.

@waynexia built a thread pool upon juliex as a PoC, showing the max throughput significantly improves (sysbench point_select QPS 39k -> 59k). But it has poor latency performance. Take a look if you're interested: https://github.com/waynexia/texn
Difficulty

Hard

Score

6000

Mentor(s)

@sticnarf

Recommended Skills

Concurrent programming
Scheduling algorithms
Rust language

can you link your origin implementation here?

can you link your origin implementation here?

Updated.


Pickle mess

Hi,
I discovered there are a lot of incompability issues related to the library pickle.
First of all if you are using Python 3.* you have to open files in binary mode:
eg s = open(filename,  'rb') data = pickle.load(s, encoding='latin1')
then there are also compability related to pickle dumped from Unix or Windows environment.
A solution is to change the end of line with scripts like unix2dos or dos2unix.
Or something like this:
`content = ''
outsize = 0
with open(original, 'rb') as infile:
content = infile.read()
with open(destination, 'wb') as output:
for line in content.splitlines():
outsize += len(line) + 1
output.write(line + str.encode('\n'))
print("Done. Saved %s bytes." % (len(content)-outsize))`

Good observations. I think pickle library should have been able to note which os was used to create the pickled file and deal with it accordingly. However I will try to automate this in library's loading and saving function.

if you are using Python 3.* you have to open files in binary mode: eg s = open(filename, 'rb') data = pickle.load(s, encoding='latin1')
then there are also compability related to pickle dumped from Unix or Windows environment. A solution is to change the end of line with scripts like unix2dos or dos2unix. Or something like this: `content = '' outsize = 0 with open(original, 'rb') as infile: content = infile.read() with open(destination, 'wb') as output: for line in content.splitlines(): outsize += len(line) + 1 output.write(line + str.encode('\n'))
print("Done. Saved %s bytes." % (len(content)-outsize))`

Where exactly do I need to make these changes in the code?

I will try to automate this in library's loading and saving function.

Is this still planned?


Win-Acme - Windows - Duckdns -Autorenew

Hi Guys,
Using Windows 10 to host my Node-red. Using Win-ACME I was able to get my SSL setup and working no issue. (super easy, cheers to all those that made this possible). However, I can NOT for the life of me figure out how to enable Auto-Renew, I need a script to add the txt record and then remove it. however now sure how to do it.
Any help is greatly appreciated.

Hi @Raul-7-7, if you don't need a wildcard certificate I'd highly recommend sticking to HTTP-validation as it's much easier. Instructions on how to do the DNS script are here: https://pkisharp.github.io/win-acme/reference/plugins/validation/dns/script
Please let me know if something there is not clear.

Hi @WouterTinus , Thanks, unfortunately HTTP validation is not option as I dont have port 80 open.
do you know which script on the sample of scrips is closest to Duckdns? I am just starting and not an expert, if i can see something similar I can work from there.
Cheers,


Some native build improvements

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/6597/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/39896/ started

https://jenkins.code.rdkcentral.com/job/build-component/78730/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/11098/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/39910/ started

https://jenkins.code.rdkcentral.com/job/build-component/78738/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/6610/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/11113/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/39925/ started

https://jenkins.code.rdkcentral.com/job/build-component/78748/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/6619/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/11120/ started.

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25070/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25077/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25078/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25096/

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25095/

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25103/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25108/

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25107/

https://jenkins.code.rdkcentral.com/job/github-triggered/39962/ started

https://jenkins.code.rdkcentral.com/job/build-component/78775/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/6648/ started

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25143/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25147/

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25187/

https://jenkins.code.rdkcentral.com/job/github-triggered/40127/ started

https://jenkins.code.rdkcentral.com/job/build-component/78989/ started.

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25636/

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25635/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25643/

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25770/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/25771/


Feature: Update tags documentation to include having to import the tags definition file.

Before you start...

[X] Have you refreshed the page? You might be using an old version of the website.
[X] Have you checked if someone already requested this feature? If they have, post a comment with your use case instead.

Description
Current it does not have this information so on other device they will show as unknown. Steps to do this should have both the import/export options method and manually copying the file, incase the user just wants only the tags and not other settings.
Alternative solutions
No response
Relevant Assets
No response

This is resolved


Fix types for strict mode

Fixes #59

@Telokis thanks for the PR!
I guess we could also add "strict": true to enable the strict family options in the tsconfig file and then set "strictPropertyInitialization": false since this module resolves the class attribute values during runtime.
Then I will update the readme file to mention that when working with strict: true is necessary to disable the strictPropertyInitialization in order for this module to work.

@tommelo Thanks for your reply, I've enabled strict mode!


core: loggers os logger variations have been added.

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...
Pull Request Description

OS Logger subsystem and category support has been added.

Issues

[ ] Check for nil both subsystem and category.
[ ] non-inline method to get logger.
[ ] setters getters instead of ivars.

Could anybody post a review?

@ffried
According to Apple documentation and wwdc, os_log_create returns thread-safe singleton object.
os_log_t log = os_log_create("com.your_company.subsystem", "network");
// Create thread-safe singleton object that controls behavior of log messages

Do we still need to cache it?
Initialization with two parameters - nice idea. But I am confused about their nullability. I suppose that both of them can be nil, but Swift version has OSLog.init(subsystem: String, category: String).

@lolgear Didn't know about the singleton. The reason I'd still cache it is that even a singleton needs to be looked up again, right? It'll return the same object for the same subsystem/category combination, yes, but it still needs to look it up.
But this is also not a hard requirement for me. I'm also fine with creating it every time.
As for the nullability:
We need to make both nullable, but the initializer should have an assertion that either both are nil or both are set. In Swift I'd use an optional tuple(subsystem: String, category: String)?, but in ObjC we have to manually check this.
If both are nil, we use the default log. Otherwise we create one using os_log_create.

@ffried
I have checked it.
os_log_create() can't handle nil parameter in neither subsystem nor category.


Make test and check files executable

What this PR does / why we need it:
This PR makes test and check files executable so that they can be executed by the CI's pipeline.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/assign @mvladev


Lock and Locktimeout parameter support added

Apologies, I lost track of this PR. Have all the comments been resolved?

Apologies, I lost track of this PR. Have all the comments been resolved?

Hi @brikis98 yes, all of the comments have been resolved, thanks

Thx! Just kicked off tests.

Getting an unrelated test failure with the K8S / Helm tests. Some issue with MiniKube install:
E: Version '18.06.1-0ubuntu1.2~16.04.1' for 'docker.io' was not found

I unfortunately don't have time to dig into this right now, so will have to come back to it later.

Getting an unrelated test failure with the K8S / Helm tests. Some issue with MiniKube install:

This was resolved in commit cf0c4c521bc299d6814455dfe0a81d056ae39aa5#diff-1d37e48f9ceff6d8030570cd36286a61 back in July. I just checked your branch and it looks like it is quite a bit behind (last commit from master is from May), and thus doesn't have this fix. Can you rebase on master to pull in the recent changes? I believe we've had a number of other test fixes as well so will be more likely to get a green build that way.

Getting an unrelated test failure with the K8S / Helm tests. Some issue with MiniKube install:

This was resolved in commit cf0c4c5#diff-1d37e48f9ceff6d8030570cd36286a61 back in July. I just checked your branch and it looks like it is quite a bit behind (last commit from master is from May), and thus doesn't have this fix. Can you rebase on master to pull in the recent changes? I believe we've had a number of other test fixes as well so will be more likely to get a green build that way.

Thanks, I've pulled in the latest changes and will keep an eye on the tests

OK, thx, re-running tests now!

Tests passed. Merging now.

https://github.com/gruntwork-io/terratest/releases/tag/v0.23.1

Thanks!


Support for promises

https://github.com/IonicaBizau/node-cobol/issues/7

:tada: :ship: cobol-promises


Create signing method

#213  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on  Graphite


Gift card mailing context

I want to merge this change because it adds more context and modifies the template of gift cards.
⚠ This is a PR to feature branch.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4158 Update gift card context to contain extra info


fix: Modal may not have onConfirm func provided

What it does, and why

Add a thorough explanation of what the code in this PR does in this section. Make sure to also cover why your changes are necessary and useful.

Fix issue for using keyboard closing Modal.
onConfirm function may not be provided. (mapper - notes modal is hiding the footer, so no need to use the onConfirm in Modal)

Is there anything not straightforward in the code? Explain it. If you choose to use a pattern rather than another, use this space to provide the reason for your choice.

Checklist

Please go through following checklist before requesting review and fix issues listed there. If your code touches the files with the below in question, please address them.

Coding conventions

[ ] Have you split out components if there more than one React class or component in this file?
[ ] Have you converted the React class component to functional component?
[ ] Are you using spread props for the React component? If so, please state the exact properties required for the component <Component prop1={val1} prop2={val2} />
[ ] Are you doing prop drilling, going further than 2 levels deep? If so, refer to this document: https://blog.axlight.com/posts/four-patterns-for-global-state-with-react-hooks-context-or-redux/
[ ] If you're doing loops, are you using Lodash over es6 methods?
[ ] Have you extracted inline CSS in JSX out into its own styled variable?
[ ] Have you written PropTypes for the components?
[ ] Are you using hooks instead of HOC where possible?

Workflow

[ ] Are you writing documentation for the bits of code with complex changes?
[ ] Are you writing unit tests for business logic?
[ ] Are Stories are written for every visual change?
[ ] Request review if it is any visual/interaction

Testing

Explain how to test the changes in detail.

What testing have you performed on this change?
Is it unit tested? If not, why?
What manual steps have you performed to ensure its functioning correctly when integrated?

Trello Tickets

If this PR implements changes related to one or more Trello tickets please add them here:

UI Changes

If this PR introduce some interaction or animation change please also add GIF with how it behaves. Don't forget that this change should be possible to simulate in storybook.
You can use this tool to record your screen and convert it to a GIF.

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/components/Modal/index.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/components/Modal/index.js  1

See the complete overview on Codacy

👍

Thanks for the review.
Just found the ESC key also needs a check.
So, basically, other Modals in Mapper can be closed using keyboard.
Only the notes one doesn't response to ESC key and Enter key.

Ah yes, great thanks sho!


Fix OutputOptions and GrpcOutputOptions (issue #25950)

Fix for OutputOptions and GrpcOutputOptions being ignored - issue https://github.com/grpc/grpc/issues/25950
The Grpc.Tools msbuild XML needed updating to include using the user-supplied options.

CC @JamesNK

CC @apolcyn


Another round of Bugfixes and Tweaks

Q. Item count glitches are dealt with
Warping out now correctly rewinds missions.
combatStep was altered, the mob can attack and give chase at the same time. Kiting melee mobs around is much harder.
Mobs in general are more harder, closer to how it was in retro.
Nanos styles are less detrimental to battle.

Merged manually. Nice work.


Int underflow in objcopy.rs example

Heya,
there is an attempt to subtract with overflow in examples/objcopy.rs:92:25 with the following sizes:
symbol address: 0x20
section address: 0x488920

The binary is attached.
Best,
mrphrazer
binary.zip

Hi, thanks for the report. This is kind of expected since you are running the example for an unsupported scenario. The objcopy example only supports object files, not executables, and it's unlikely to ever support executables. We could do better error handling for this case though.
What led you to try to run objcopy on this file? What are you trying to achieve? Currently, the objcopy example is mostly intended as a development tool for this crate. If you want something for production use then you'll want to use the objcopy from llvm or binutils instead.

Hi,
thanks for the quick response! I am trying to evaluate different crates as a base for elf manipulations (adding/removing sections, segments etc.). objcopy.rs worked fine for my tested x86_64 binaries, so I thought this might be a bug due to a not so well-tested architecture.

Most testing has only been done with x86_64, so you're right that bugs in other architectures are more likely. We definitely don't support writing segments in objcopy.rs, so maybe you were only testing with x86_64 object files instead of executables.
This crate is probably not a good match for what you want to do. It does have the raw ELF structure definitions though, which might still be a useful basis.

Added objcopy check for supported file type in #352.
Added write::elf::Writer and elfcopy example in #350. Still no high level support for operations such as adding/removing sections, segments etc. Probably still missing some non x86-64 support.


Cannot build with MQTTOnlyBSDSocket set to 0

Cannot build when setting the value of MQTTOnlyBSDSocket to 0 in lib/include/Network/Clients/MQTT.hpp because lib/src/Network/Clients/MQTTClient.cpp tries to include files that do not exist in the repository.

Yes that's true. Those files are part of a very large networking multi-protocol library that we use internally for our needs and it's not open source (yet ?).
You have to define MQTTOnlyBSDSocket to 1. If you need TLS, you'll need to download and use MbedTLS library in that case. For an example code, you have the related repository

The code will build and work correctly with MQTTOnlyBSDSocket set to 1, I meant.

I understand. Thank you for the clarification.
We have a scenario when our application is compiled with Visual Studio, in which case BSD sockets are not available. That's why I started to look around in the code and tried to change the macro; I hoped it might help.
Is there any straightforward solution to build with Visual Studio?

Do you need SSL ?
Currently, I can easily add the missing Socket.hpp file but SSLSocket.hpp requires so much dependencies (mainly OpenSSL wrappers but also all crypto code that have nothing to do with this project).
I'm sorry I'm not using Windows anymore since many years. I know the Socket class is cross platform, but I don't know for SSLSocket status.

No need for SSL (currently).

Looks good. Thank you very much!


The purpose of remove the * , & and  << opeartors

I see that in the rev 1.x, pymonad supports the *, & and << operators and the * for function composition.  And these notations are so common in the haskell.  They indeed made the code more readable and looks more functional.  But in the rev 2.x, they are moved to the operator folder and will be remove in the future.
I don't understand the purpose of the removement. Would you please do some explaination?

I explained this a little bit in this closed issue: #9
Briefly though, the semantics of pymonad operators didn't really have anything to do with the "normal" semantics people usually associate with those operators. In pymonad, * doesn't have anything to do with multiplication for instance. So the use of operators in this fashion just generally goes against "good" python coding style, which is why their use is discouraged.
However, the operators will most likely not be removed but will remain in the operators package. So you're free to use them as much as you'd like.
The general guideline that I'd suggest is this: If you're writing code that other people will have to edit at some point, especially if they're not necessarily familiar with Haskell and/or functional programming, then avoid using the operators. If you're the only one that will ever touch the code and you prefer the operators, go for it. But, of course, you're free to do whatever you'd like.
Hope that helps!


"no default font found" issue on FreeBSD

While this is issue is being discussed on https://github.com/lapce/lapce/issues/2748 ,
could we have some opinion on fontdb-0.14.1 used in https://github.com/lapce/lapce 0.3.1 about the error, "no default font found"
Same problem was found on some linux distros, but we can find a way of fixing it on FreeBSD.
Any help is welcome,
Thanks

load_system_fonts supports only Windows, Linux and macOS. See the docs.
If you want to add FreeBSD - you have to update this function. I never used FreeBSD, so I cannot help you here.

I'm dealing with the same issue regarding Slint on the FreeBSD 14.0-RELEASE.  The command cargo build finished succesfully by setting the environment variable FONTCONFIG_FILE as follow.
$ export FONTCONFIG_FILE=/usr/local/etc/fonts/fonts.conf
$ cargo build

Hope this being help
Also with following setting in the VSCode-OSS on the FreeBSD 14.0-RELEASE, the same effect can be gotten
{
    "rust-analyzer.server.path": "~/.cargo/bin/rust-analyzer",
    "rust-analyzer.cargo.extraEnv": {
        "FONTCONFIG_FILE": "/usr/local/etc/fonts/fonts.conf"
    },
    "terminal.integrated.env.linux": {
        "FONTCONFIG_FILE": "/usr/local/etc/fonts/fonts.conf"
    }
}

@ierturk
On lapce port 0.3.1 ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274852 )
CARGO_ENV+=    FONTCONFIG_FILE=/usr/local/etc/fonts/fonts.conf
and
MAKE_ENV+=     FONTCONFIG_FILE=/usr/local/etc/fonts/fonts.conf
result: "no default font found"
lapce ships and compiles 2 fondb crates, 0.14.1 and 0.16.0 and I patched the two:
--- cargo-crates/fontdb-0.14.1/src/lib.rs.orig  2023-12-26 12:01:12 UTC
+++ cargo-crates/fontdb-0.14.1/src/lib.rs
@@ -442,9 +442,9 @@ impl Database {
             };

             if read_global {
-                let _ = fontconfig.merge_config(Path::new("/etc/fonts/local.conf"));
+                let _ = fontconfig.merge_config(Path::new("/usr/local/etc/fonts/fonts.conf"));
             }
-            let _ = fontconfig.merge_config(Path::new("/etc/fonts/fonts.conf"));
+            let _ = fontconfig.merge_config(Path::new("/usr/local/etc/fonts/fonts.conf"));
         }

         for fontconfig_parser::Alias {

and
--- cargo-crates/fontdb-0.16.0/src/lib.rs.orig  2023-12-26 12:04:32 UTC
+++ cargo-crates/fontdb-0.16.0/src/lib.rs
@@ -443,9 +443,9 @@ impl Database {
             };

             if read_global {
-                let _ = fontconfig.merge_config(Path::new("/etc/fonts/local.conf"));
+                let _ = fontconfig.merge_config(Path::new("/usr/local/etc/fonts/fonts.conf"));
             }
-            let _ = fontconfig.merge_config(Path::new("/etc/fonts/fonts.conf"));
+            let _ = fontconfig.merge_config(Path::new("/usr/local/etc/fonts/fonts.conf"));
         }

         for fontconfig_parser::Alias {

result: "no default font found"
Maybe I missing something...
Could you have a give a try at PR above?
Thanks

Sorry, I closed this PR by mistake

fontdb doesn't care about FONTCONFIG_FILE or fontconfig in general. See how load_system_fonts function is implemented. You have to patch it to load the system fonts directory(s).

This the implementation in Slint and related discussion
https://github.com/slint-ui/slint/blob/d1529af3cc079c724fcbe1a4101a14013eda8b76/internal/common/sharedfontdb.rs#L26
https://github.com/slint-ui/slint/issues/1240

Ok, I see in lib.rs:
    /// Attempts to load system fonts.
    ///
    /// Supports Windows, Linux and macOS.
    ///
    /// System fonts loading is a surprisingly complicated task,
    <snip>

#[cfg(target_os = "windows")]
{
}

#[cfg(target_os = "macos")]
{
}

#[cfg(target_os = "redox")]
{
}

#[cfg(all(unix, not(any(target_os = "macos", target_os = "android"))))]
{
}

Any sugestion for a new 'freebsd' block or use a existing one so I can patch and test?

Hm... right now we're treating all Unixes as Linux (except for macos and android), which is probably incorrect. Or at least overly generic.
Either way, right now building on FreeBSD with fontconfig build feature enabled you should load fonts just fine. Or FreeBSD doesn't use fontconfig? If so, at what locations does it store fonts?
According to quick googling, FreeBSD uses the same fonts location as Linux, aka /usr/local/share/fonts. So it should work just fine...
Can you check you're building fontdb with fontconfig feature enabled? If so, then check the load_fontconfig function to figure out why the default config isn't resolved.
The fontconfig root config file resolving logic is very convoluted, like everything in fontconfig, therefore we might simply not covering some edge case.

It was nice to have some build variable that controls this config.

It was nice to have some build variable that controls this config.

In Clear Linux OS, the file is located in yet another path: /usr/share/defaults/fonts/fonts.conf
Simply making hard-coded assumptions about the location of fonts.conf does not seem to be the proper OS- and distro-neutral way to go.

The distro/OS neutral way of doing this is having the config in /etc, that the distro or OS you are using is deliberately not doing that is fault of their own.

It is explained in this answer. Apparently, it has something to do with the fact that Clear Linux OS is a stateless distro.
Also, according to this answer in the same thread, libfontconfig can be used to resolve the file in a distro-independent manner.
Also, the environment variable FONTCONFIG_PATH is mentioned, but lapce appears to ignore that environment variable, even when I explicitly point it to /usr/share/defaults/fonts/fonts.conf.
Apparently, Alacritty used to have the same issue on Clear Linux OS, but that eventually got fixed, since I've been able to build and run Alacritty on this OS just fine.
@panekj Do you have any reference to documentation that defines /etc/fonts/fonts.conf as the "standard" Linux or POSIX location for this file?

Do you have any reference to documentation that defines /etc/fonts/fonts.conf as the "official" standard Linux or POSIX location for this file?

https://www.freedesktop.org/software/fontconfig/fontconfig-user.html

Do you have any reference to documentation that defines /etc/fonts/fonts.conf as the "official" standard Linux or POSIX location for this file?

https://www.freedesktop.org/software/fontconfig/fontconfig-user.html

Fair enough. And I just checked, and Clear Linux OS doesn't have the environment variable XDG_CONFIG_HOME defined out of the box either.

@nunotexbsd great. Then you can replace the current line with:
#[cfg(target_os = "freebsd")]
{
    let _ = fontconfig.merge_config(Path::new("/usr/local/etc/fonts/fonts.conf"));
}

#[cfg(not(target_os = "freebsd"))]
{
    let _ = fontconfig.merge_config(Path::new("/etc/fonts/fonts.conf"));
}

As for Clear Linux, just set FONTCONFIG_FILE or XDG_CONFIG_HOME in your .bashrc or whatever you use.

I think we can close this PR now.
fontdb works as expected and paths are respected.
Thanks all

@nunotexbsd So what was the final solution? Setting FONTCONFIG_FILE?

@nunotexbsd So what was the final solution? Setting FONTCONFIG_FILE?

I was looking for solutions for packagers (poudriere) and using src fontconfig.merge_config will give me the ability to have a pkg working without FONTCONFIG_FILE or XDG_CONFIG_HOME vars configured or not by end user.
If fondb added a build option to do this adjustment, I used that, but since it's using corrects fonts path, I will patch it to adjust to FreeBSD.
Just a side note: FreeBSD respects paths too, but it adds a PREFIX that separates files from OS to the others installed by user (src, pkgs, etc)
/usr/local/etc/fonts/fonts.conf == $PREFIX/etc/fonts/fonts.conf, where PREFIX defaults to /usr/local.
Just an example, we could delete /usr/local from system and continue to have a cleaned OS system.

Adding a compile-time option to specify prefix sounds like most sensible way to resolve that, as package/system maintainers we would like for all packages to be integrate with system libraries/software.
Adding hardcoded paths might resolve it as well, but its prone to breaking anytime downstream changes paths.

Adding a compile-time option to specify prefix sounds like most sensible way to resolve that

Except it's not that easy to do in Rust. And I still have no idea what path exactly have to be configured. Once again, I don't use FreeBSD. If someone would send a working patch - I might merge it.

as package/system maintainers we would like for all packages to be integrated with system libraries/software

It's not my fault that fontconfig sucks. It's way too slow, limited and clunky.
And before you ask, yes, I've tried using fontconfig before: https://github.com/servo/font-kit/commit/adff9391acf3d6e755d9b811c75ab2bc83ec4d13

Adding a compile-time option to specify prefix sounds like most sensible way to resolve that

Except it's not that easy to do in Rust. And I still have no idea what path exactly have to be configured. Once again, I don't use FreeBSD. If someone would send a working patch - I might merge it.

But you don't have to use FreeBSD, nor know the absolute paths.  It's way too slow, limited and clunky.

No one is blaming you, I'm just explaining the motivation behind compile time option.

I also noticed another issue, fontconfig feature limits itself to unix excluding macos and android (while also having a comment // Linux but the cfg doesn't target linux) but fontconfig works on other platforms whether that's *BSD, Windows, macOS or other.
While those might be not the most popular platforms to use fontconfig on, they certainly are a possibility. It would be good to either document that limitation or implement fontconfig feature for all platforms.

It would be good to either document that limitation or implement fontconfig feature for all platforms.

It is documented: https://github.com/RazrFalcon/fontdb/blob/c3274d016cad92fac744d76a91e4554fe51c5745/Cargo.toml#L39
The reason we only mention Linux and not Unixes is because only Linux is "supported" right now, if you can call it "support".
And the only reason fontconfig "support" is present to begin with is because Linux distros decided that putting fonts into a hardcoded directory is too easy.
Ideally, there shouldn't be any fontconfig code in fontdb.
PS:  I'm aware that recent Windows and macOS versions started doing weird shenanigans with fonts as well.
And yes, fontconfig is intentionally disabled for Windows and macOS. I know you can use fontconfig on them, but you absolutely shouldn't. The whole point of fontdb is to get rid of fontconfig and other needless abstractions.
As for FONTDB_PREFIX. I'm not sure what it solves. fontdb reads fonts.conf at a path specified by fontconfig's documentation. It's not fontdb fault that someone decided to move it.
Instead, we could/should hardcode FONTCONFIG_PATH.
Or even better, we can just hardcode /usr/local/etc/fonts/fonts.conf and call it a day.
Linux support is already 90% of fontdb system fonts loading logic. I don't want to make it even more convoluted.


Update htl-maven-plugin

Similar to https://github.com/adobe/aem-core-wcm-components/issues/302 the currently used htl-maven-plugin (1.0.6) is quite old now and does not support newer features like the in operator or decorationTagName.
Can this be updated? It's defined in src/main/archetype/pom.xml.

Hi @dhardtke , can you provide a pull request for this?

Done: https://github.com/adobe/aem-project-archetype/pull/280
I'll sign the CLA as soon as possible 👅

done in https://github.com/adobe/aem-project-archetype/pull/280


Tracking issue for crate evaluation

[ ] Expand crate-level documentation
[ ] Add examples to methods
[x] Overhaul API
[x] Add CI Badges to Cargo.toml
[x] Add #[doc(html_root_url = "...")] annotation to crate root
[ ] Document error conditions for fallible methods in a separate "Errors" section

@danburkert "Add examples" can be checked.

Based on #46 and #31 it looks like we could use someone with familiarity, or at least ready access to, Windows to help get memmap over the line.
@danburkert would it be helpful if someone pulled the PR in #46 and spent some time poking it on Windows to fix the test failure?

@KodrAus @danburkert I can help poke around in PR #46. I got my windows environment setup last night and was able to reproduce the failure. I am still fairly new to Rust and haven’t done much windows-specific development, but if you would like an extra set of eyes I am more than happy to help.

Thanks @bjnyfv! I'm not 100% sure whether @danburkert has more they want to do with that PR, but if you're able to produce a fix that gets the build green then opening up a new PR and noting that it's based on #46 would probably be helpful.
Thanks again!

@bjnyfv if you'd like a sounding board anytime for any blitz work, please join on the Gitter channel. I haven't done much Windows native dev either, but will try help where I can.

Thank you for the heads-up @KodrAus! I checked out the Gitter channel as suggested and noticed that @toankitsingh also mentioned helping out with the Windows issues. Perhaps @toankitsing and I can touch base if he is reading this. (I will also post a message in Gitter for him to hopefully see).

Now that memmap is stable we should be able to close this.


refactor(models)!: remove duplicated SubAddressIndex

Closes #42
Decided to remove SubAddressIndex instead of SubaddressIndex because there are other structs in models.rs whose name start with Subaddress (with lowercase a).
No farcaster project used  SubAddressIndex, but I marked the commit with a ! (as per https://www.conventionalcommits.org/en/v1.0.0/) to indicate that this is possibly a breaking change (in case anyone imported  it in their projects).

@TheCharlatan done.

Just wondering if I should split the current item on Changed into an item on Changed and another on Removed.

Yes, that is possible. Check the rubrics here: https://github.com/monero-rs/monero-rs/blob/main/CHANGELOG.md

Oh cool, PRs are mentioned in the other project.
Added to this one.


1205 update sp1 risc0

Update SP1 and Risc0 verifier versions
closes #1205
This PR:

Bumps the risc0 and sp1 verifier versions of operators.
Provides retro-compatibility for each version. If proof verification for SP1 and Risc0 between the current and old ('_old') verifier versions fails within the operator it will try verifying using the older version of SP1/Risc0 before returning false.
Changes the prompt library in the quiz example from dialoguer -> inquire to accomodate a dependency conflict.

To Test:
Verify network bindings works on a local network:

make test_risc_zero_go_bindings_macos
make test_sp1_go_bindings_macos
run local testnet and confirm you can submit sp1 and risc0 proofs. via
make batcher_send_risc0_task
make batcher_send_sp1_task
confirm examples work:
cd examples/zkquiz && make answer_quix
cd examples/validating-public-input && make generate_risc_zero_fibonacci_proof

Verify Retro Compatiblility of Operator Verifiers:
To verify operator retro-compatibility we deploy the rest of infrastructure of Aligned and boot the retro-compatible operator. This tests that network retro-compatible operator can verify SP1/Risc0 proofs from both verifier versions.
Note:
Commands suffixed with _old indicate the deprecated version of the SP1/Risc0 verifier that is currently running on testnet
To test this have two repos of aligned_layer one set to testnet and one to 1205-bump-sp1-and-risc0-version.
In testnet repo:
go clean
go mod tidy
make go_deps
make deps

Then you must run anvil, aggregator and batcher:

make anvil_start_with_block_time

make aggregator_start

make batcher_start_local

In 1205-bump-sp1-and-risc0-version repo:
make deps

Then you can run operator

make operator_register_and_start

Send proof from the older SP1 and Risc0 versions from the testnet repo.

make batcher_send_burst_groth16
make batcher_send_sp1_burst
make batcher_send_risc0_burst

Observe the Risc0 proof verification failed. and SP1 proof verification failed. logs are emitted and the operator successfully verifying the proofs from the old SP1/Risc0 verifiers. If you send a proof from the latest version of SP1/Risc0 you should notice its verification fails in the batcher.

Keep the operator running on the 1205-bump-sp1-and-risc0-version repo.
In the testnet repo, kill the batcher.
Navigate to the 1205-bump-sp1-and-risc0-version and start the batcher within the repo.
Send proof from both the SP1 and Risc0 versions from the 1205-bump-sp1-and-risc0-version repo.

make batcher_send_sp1_burst
make batcher_send_risc0_burst

Observe the operator successfully verifying the proofs from the new SP1/Risc0 verifiers. If you send a proof from the older version of SP1/Risc0 you should notice its verification fails in the batcher.
Type of change
Please delete options that are not relevant.

[x] New feature

Checklist

[ ] Linked to Github Issue
[ ] This change depends on code or research by an external entity

[ ] Acknowledgements were updated to give credit

[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

[ ] Has a known issue

Link to the open issue addressing it

I believe there might be missing steps in the testing procedure:
Welcome to the zkQuiz! Answer questions, generate a zkProof, and claim your NFT!
error: the following required arguments were not provided:
  --keystore-path <KEYSTORE_PATH>
  --verifier-contract-address <VERIFIER_CONTRACT_ADDRESS>
Usage: quiz-script --keystore-path <KEYSTORE_PATH> --verifier-contract-address <VERIFIER_CONTRACT_ADDRESS>

@Oppen apologies corrected the example commands in the description above.


Feature: Pipeline Checkpointing

This is a feature request for "checkpointing" built into the Tekton controller to save the state of the pipeline after each Task Step/Task completion.
Expected Behavior
There are several reasons to want the state saved periodically:

produces an accurate debug log that can help diagnose failures
enables restarts of a partial pipeline as described in #50
gives you a place to put artifacts that the user could want extracted out of a pipeline without having to first push them somewhere

Examples of things that would exist in a checkpoint:

status of the pipelinerun/taskrun, current step, timings, eg
state of workspaces/params/resources
any artifacts left on disk of the output directory on the task
container parameters like env variables?

Actual Behavior
Right now, there isn't really a good built-in way to store the state of a pipeline as it is running and the Tekton controller is in the best position to execute this as a sidecar on each task pod.

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

I would be happy to work on this.

Thanks @NikeNano, this feature is important for us, what's the progress on this item?

@dlorenc is there any related work from the tektoncd/chains project ?

I think the work described in https://github.com/tektoncd/community/blob/master/teps/0030-workspace-paths.md would be really useful for checkpointing. It could help limiting the amount of data to be saved, based on the declared paths.

Do we consider another solution of Chekpoint come from kubeflow: https://github.com/kubeflow/pipelines/tree/master/backend/src/cache
Basically, it's a Pod watcher and a Mutation webhook for Pod.

Watch pod which is complete and store the output to remote storage (mysql in kubeflow)
Webhook will check a new created Pod if it have been run previously, if yes, retrieval previously output from storage, set back to the new created pod and ignore it (by replace it's container).

@vdemeester @bobcatfish @afrittoli


Perform all necessary validation in fissile

Warnings for properties that have different defaults across jobs are removed.
They are not useful when moving to "per job" properties.

 (5) fissile: move validation code from scf to fissile

@mook-as I'd like yaml references too.
I think it's out of scope though. And maybe we should implement it after we have a manifest that's bosh compatible.


Add funding acknowledgement section to about page

We should add a section on the about page to gratefully acknowledge funding sources for CIViC. Maybe with their logos displayed as well (for NCI, NHGRI, NIH).
Example acknowledgement text as a starting point:
Acknowledgements and funding:
First and foremost we are grateful to the community of curators, editors, domain experts, and users who make CIViC possible. Malachi Griffith was supported by the National Human Genome Research Institute (NHGRI) of the National Institutes of Health (NIH) under Award Number K99HG007940. Obi Lee Griffith was supported by the National Cancer Institute of the NIH under Award Number K22CA188163. This work was also supported by a grant to Richard K. Wilson from the NHGRI under Award Number U54HG003079. The CIViC project is also supported by the NCI under Award Number U01CA209936 to Obi Lee Griffith (with Malachi Griffith and Elaine R Mardis as co-PIs). The content of this website is solely the responsibility of the creators and does not necessarily represent the official views of the National Institutes of Health.

Pinging this one.  I think it is important that we acknowledge our funding prior to any publication.


Accessing panVCF format/reader

Hello @jeffhsu3,
I was looking for a python module that reads VCF and transforms it into a Pandas dataframe, happy to find your's.
I'm having an issue accessing the pandas/vcf reader:
In [1]: import genda
In [8]: dir(genda)
Out[8]:
['__builtins__',
 '__doc__',
 '__file__',
 '__name__',
 '__package__',
 '__path__',
 'calculate_ld',
 'calculate_minor_allele_frequency',
 'common_funcs',
 'np',
 'pd',
 'pearsonr',
 'regionParse',
 'sys']

Shouldn't panVCF be accessed as a normal public function? I also had a look at the documentation and tests, but there are no examples nor tests on that module. Any hint on how to use that functionality is very welcome!

panVCF isn't exposed at the top level at the moment I'll work on getting that put there today.  I had worked on various implementations to parse VCFs into a pandas DF.

It can actually be accessed from genda.formats.panVCF.VCF.  Here is an example: http://nbviewer.ipython.org/gist/KaiSmith/90a548316eeae6bfb476 .  The parser can be slow as right now, chunksizes (similar to how pandas.read_csv does it) isn't implemented and it tries to parse out all of the INFO field at once.  L

Thanks! The key for me here was calling it like this:
from genda.formats import panVCF

genda_vcf = panVCF.VCF('tests/test-lumpy-mini.vcf')
genda_vcf.vcf

Useful! Now I can mangle the dataframe a bit further and adapt it to my needs. Thank you!

Pity that it goes so slow for "real" VCF files... tried to load one and never ended loading :/
Perhaps Dato and their SFrames with some more optimization would make sense here. Thanks anyway for your feedback!

I would check out this package.  I might try and wrap it into numpy arrays for the relevant fields.

Reopened to wrap https://github.com/arq5x/cyvcf direct into a pandas DF or something else.


Djlint intergration

What is the context of this PR?
Investigate the appropriateness of DJLint (HTML Template Linter and Formatter | djLint) for runner HTML/Jinja templates.
Djlint has problems reformatting long json inside an element so design system files have flattened code. The creator has said he is looking into fixing this.
Raising Draft PR to see whether we should continue or wait  and revist
How to review
Describe the steps required to test the changes (include screenshots if appropriate).
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

We will not be proceeding with Djlint. We have a big formatting error in Design System templates where it will flatten any json formatted code. This is an issue that has been raised with Djlint and is being looked into by the creator. As of right now It does more harm then good, but there will be big feature updates coming in the near future for Djlint (version 2.0) we shall look into it on a later date.


Install failure after downgrade from Win11 to Win10

Microsoft PowerToys version
0.53.3
Running as admin

[ ] Yes

Area(s) with issue?
Installer
Steps to reproduce
Install PowerToys in Win10
Upgrade to Win11
Downgrade to Win10
Try to upgrade to next version of PowerToys
✔ Expected Behavior
Standard upgrade, with which I've had no issues in the past
❌ Actual Behavior
"Accessing the feature...  Click OK to try again, or enter an alternate path to a folder containing the installation package 'PowerToysSetup-0.53-3-x64.msi' in the box below"
Other Software
No response

Please see if this helps! https://docs.microsoft.com/en-us/windows/powertoys/install#extracting-out-the-msi-from-the-bundle

/needinfo

This did not work.  However, running this utility solved the issue:
https://support.microsoft.com/en-us/topic/fix-problems-that-block-programs-from-being-installed-or-removed-cca7d1b6-65a9-3d98-426b-e9f927e1eb4d
On Mon, Mar 7, 2022 at 2:51 AM Franky Chen @.***> wrote:

Please see if this helps!
https://docs.microsoft.com/en-us/windows/powertoys/install#extracting-out-the-msi-from-the-bundle
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/16815#issuecomment-1060284327,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKIN7DLH6ZLSVZFK222AGDLU6WYQPANCNFSM5QAFGQUQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

This did not work. However, running this utility solved the issue: https://support.microsoft.com/en-us/topic/fix-problems-that-block-programs-from-being-installed-or-removed-cca7d1b6-65a9-3d98-426b-e9f927e1eb4d
cc: @crutkas


PHP Fatal Error after last update

Here the error :
PHP Fatal error:  Class Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Doctrine\Common\Persistence\Mapping\ClassMetadata::initializeReflection, Doctrine\Common\Persistence\Mapping\ClassMetadata::wakeupReflection) in www/vendor/doctrine-mongodb-odm/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadataInfo.php on line 1600
I just update my symfony standard project (I use the branch master)

Common was updated with a refactored metadata implementation about 1 hour ago. So you were unlucky to hit that.
You should be able to set the version parameter for common to 4e9be5bcd13219e789f54095af3f7a93dddfdcc0

Thanks, in fact it is this commit 16b2385b3ce5319d88969f18694e4b36533bd258 for common :)

That code is rewritten now, shouldn't fail anymore.


drive.files.list query on properties not working

trying to do a search for files with specific custom property which I have successfully set and and can see the properties array if I cheat an get the file directly (knowing its id)
the q below is not working get 400 error "Invalid query"
var args = {
    corpus: "DEFAULT",
    maxResults: 10,
    q:  "properties has { key='ufn' }"
};
drive.files.list(args, function(err, rd){
    if(err){
        return cb(err, null);
    }
    return cb(null, rd);
});

also if I follow the documentation at : https://developers.google.com/drive/web/search-parameters#properties
and try and use a q like:
"properties has { key='ufn' and value='8e8aceg2af2ge72e78' and visibility='PRIVATE' }" gives same error.
Is documentation correct because it does not work in web interface either.
any help appreciated

I had the same issuse and solved it.
post it here even after a year, in case anybody need it.
You need to specify

(Marking this as closed due to staleness - @djholly123 feel free to reopen if this is still a problem for you. Thanks!)

Hi,
It's working for me.
This gives a result when we give the exact key and value. how to do contains check.
Example:
A file has properties  key is "FileKey" and value is "FileValue"
I give the search value like "File".  How to get the file

Greetings @Vigneshwaran22!  If you're running into trouble, please file a new issue complete with a code sample, the version of the module you're using, and any other details.  Thanks!


Re-enable Obj-C doc generation

It was disabled to mitigate #111193.

Potential solution is to install sqlite3-ruby at version 1.4.4 before installing jazzy.

https://flutter-review.googlesource.com/c/recipes/+/33663

Doc generation has been enabled and the tests are working. More updates for proper workaround in #111193.


updated wavegen with recursive null extractor, period fix, and ui.R

ui.R has been regenerated. period fix.

@lo5 I just fixed the wavegen.tsx I removed the diff's annotations.


Revert "Preparing for  2019.10 RC"

Reverts microsoft/vscode-python#7737

No need to revert this. I will make a follow up PR to fix the distribution.toml file and any further corrections to changelog.md


enable silent compare of parameter

Describe problem solved by the proposed pull request
Remove false errors after comparing parameters that doesn't exists.
as described in https://github.com/PX4/Firmware/issues/12832
Test data / coverage
This is draft, to look
Describe your preferred solution
new compare-silent, greater-silent commands. that should be used in cases that we know that there is possibility that the parameter doesn't exist at all.

A quieter init would be nice, but I also don't want to completely lose track of irrelevant cruft. Would it make sense to change the default to silent, but have some mechanism to enable the error output (build time or environment variable)?

It also makes me wonder if we could do something more fundamental to capture a portion of the straightforward cases.
Examples:
https://github.com/PX4/Firmware/blob/f0ee0b5d495224cdc517c216bd304094df9f0817/ROMFS/px4fmu_common/init.d/rcS#L439-L444
https://github.com/PX4/Firmware/blob/f0ee0b5d495224cdc517c216bd304094df9f0817/ROMFS/px4fmu_common/init.d/rcS#L446-L450
https://github.com/PX4/Firmware/blob/f0ee0b5d495224cdc517c216bd304094df9f0817/ROMFS/px4fmu_common/init.d/rcS#L452-L456
Why don't we just generate that at build time if the module is part of that particular config?

@dagar about the first comment, I think that the default shoud be non-silent
about generating RCs according to build, If you can show me how that can be done I can start to implement that

@julianoes I agree about --silent' but to '-s'. I will do the change later.
BTW, I think that script should not even try to call parameter that doesn't exists. but current implementation doesn't fit to that.
I have contacted with @dagar about that and talked about some kind of manifest that will generate rcS parts according to spacific compilation modules.

The -s seems fine, although I'm still wondering where we actually care about keeping the non-silent version.

I think that the non-silent version should be the default. if we could we would have make it a build time error. But because we can't... only in cases we know we might "break" the rule of not trying to get a non-exist parameter we will use the silent compare.
I can think of a method that during build time I can give a warrning/error if a RC script try to fetch non-exist parameter

@julianoes Thanks!
Now the real "test" is to verify that there are no Errors running the startup script. that is something that I know that @dagar working on.
You delete the branch on the PX4/Firmware/pr-param_compare_silent


Allow different topologies for each force field

Description
This PR extends the dimer report function to accept different topologies for each force field allowing the comparison of force fields with different SMARTS patterns or types of parameters such as v-sites.
Status

[x] Ready to go

@jthorton can you run make format from the top directory, and then make lint to fix the linting errors? i don't think I can edit your branch!


Exception prioritization

Table 3.7 of the privileged architecture spec lists the synchronous exception priority for exceptions that are reported in mcause.
Section 4.1.10 says "Table 4.2 lists the possible exception codes for the current supervisor ISAs, in descending order of priority."
The two tables differ significantly.  Does the priority of exceptions differ depending on whether they are reported to M mode via mcause or to S mode via scause?  I suspect that the answer is no and that the statement about table 4.2 is wrong because load/store exceptions and environment calls cannot possibly be higher than instruction page faults which prevent you from fetching the load/store/ecall to start with.

Thanks for locating this unfortunate editing error.  The sentence in the supervisor chapter is outdated, and the priority is given by Table 3.7.


release v8.0.0

Release checklist

[x] Ensure all milestoned issues/PRs are addressed, or reassign to a new milestone.
[x] Add the don't merge label to all PRs that are close to be ready to merge (or merge them if they are ready) in capa and capa-rules.
[x] Ensure the CI workflow succeeds in master.
[x] Ensure that python scripts/lint.py rules/ --thorough succeeds (only missing examples offenses are allowed in the nursery). You can manually trigger a thorough lint in CI via the "Run workflow" option.
[x] Review changes

capa https://github.com/mandiant/capa/compare/<last-release>...master
capa-rules https://github.com/mandiant/capa-rules/compare/<last-release>...master

[x] Update CHANGELOG.md

Do not forget to add a nice introduction thanking contributors
Remember that we need a major release if we introduce breaking changes
Sections: see template below
Update Raw diffs links
Create placeholder for master (unreleased) section## master (unreleased)

### New Features

### Breaking Changes

### New Rules (0)

-

### Bug Fixes

### capa Explorer Web

### capa Explorer IDA Pro plugin

### Development

### Raw diffs
- [capa <release>...master](https://github.com/mandiant/capa/compare/<release>...master)
- [capa-rules <release>...master](https://github.com/mandiant/capa-rules/compare/<release>...master)

[x] Update capa/version.py
[x] Create a PR with the updated CHANGELOG.md and capa/version.py. Copy this checklist in the PR description.
[ ] After PR review, merge the PR and create the release in GH using text from the CHANGELOG.md.
Verify GH actions

[ ] upload artifacts
[ ] publish to PyPI
[ ] create tag in capa rules
[ ] create release in capa rules

[ ] Update homepage
[ ] Spread the word
[ ] Update internal service

closes #2498

can we hold off until https://github.com/mandiant/capa-rules/pull/953 and https://github.com/mandiant/capa-rules/pull/954 are merged?
if we tackle the prevalence database soon, it would be nice to include those rules in the dataset, rather than waiting for the next release.

recommend updating website "what's new" section too, or i can do this in a separate PR.

For waiting, it depends on when @Ana06 needs the release ready and how long the rules PR would take.
Good idea to change the website as part of the release PR.


custom rules

hi,
sorry for posting in Issues as i cant see a way to post a request,
what i want is to create custom rules like your lowercase one,
for example
i want to replace a word occurances  in  route with another one like
www.mysite.com/politic
into
www.mysite.com/politics-articles
i know that that i can reroute or redirect, but that is just a trivial example,
sometimes i need to change 2 different words.
if this possible this would be awesome, as the automatic nature of your lowercase is lovely and want to apply concept with other custom rules of mine
thanks alot in advanced.

Sorry to bother you,
but any hint on this?
thanks in advanced.

Sorry, this got lost in my inbox which is getting thrashed these days.
So I kinda get what you're describing, and I'm not sure why this would be something AR could solve. It sounds to me like you want to do this word swapping when generating the routes, right? Why not just have a helper of some kind that would do the switcheroo for ya? If I misunderstand things, please let me know.
Also, the lowercase routing stuff happens when getting the virtual path in the AttributeRoute class. I guess you could perform some magic in there, where you sniffed the route data dictionary and swapped values based on keys or values. But currently there's no configuration option to allow you do so.
So I guess fire some more info my way on what you would like to be able to do, in an ideal world. Pseudocode is great. Still trying to fully understand the issue/desire.
Cheers!

thanks a lot for replying man,
i really do not know how your advise of helper method would plug into all routes autmatically, if you have time kindly help this lost soul :)
i will try to find sometime to put some code to explain, but this job is killing me and my spine :)
one example though is that i am using images, css, js as embedded resources, so what i want is to define the url to any resources as you do normally, then catch this url and if it has Images, Javascript, css in the url, i will capture that url and replace it with the right code to load embedded resource, then append a cache hash based on the file last update date and finally return it back.
sorry if it was lame and cryptic explanation but as you see i want to manipulate the routes automatically, kind like your lowercase capture the virtual path.
thanks in advanced for keeping listening to my stupid fuss :)


Browser monitor optional attribute is actually required

Describe the bug
Creating a dynatrace_browser_monitor resource without the key_performance_metrics block causes the error: Error: Key performance metrics are missing
It's listed as optional in the provider documentation, this is probably just a small documentation fix.
To Reproduce
Steps to reproduce the behavior:

Create a dynatrace_browser_monitor resource without key_performance_metrics block.
Terraform apply and observe error.

Expected behavior
That block listed as required in provider documentation and required in the provider.
Desktop (please complete the following information):

OS: Ubuntu Linux

Thanks for the hint. With the next release the block key_performance_metrics will be required as part of the Terraform Schema.


25 add deck

Codecov Report

Merging #26 (f6dc1d5) into release-candidate (0c06c64) will not change coverage.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##           release-candidate       #26    +/-   ##
====================================================
  Coverage             100.00%   100.00%
====================================================
  Files                     23        28     +5
  Lines                    411       518   +107
====================================================
+ Hits                     411       518   +107

Files Changed
Coverage Δ

src/cards/__init__.py
100.00% <100.00%> (ø)

src/cards/cards.py
100.00% <100.00%> (ø)

src/digimon_card_game/__init__.py
100.00% <100.00%> (ø)

src/digimon_card_game/card_type.py
100.00% <100.00%> (ø)

src/digimon_card_game/deck.py
100.00% <100.00%> (ø)

tests/assertions/__init__.py
100.00% <100.00%> (ø)

tests/assertions/assertions.py
100.00% <100.00%> (ø)

tests/test_deck.py
100.00% <100.00%> (ø)


Do not fail the build on invalid declared file inputs

Since Gradle 7.0 we evaluate all file inputs of a task, regardless if
we snapshot the inputs. This causes some tasks without output files
to fail now, most prominently the Android Plugin Lint task for
AGP versions < 4.2.
We now catch possible exceptions when evaluating input file properties
and emit a validation warning instead of failing the build. We
can then fail the build for those input file properties in Gradle 8.0.

This PR also sets the supported AGP version of Gradle 7.0 to AGP 4.0.

This PR also sets the supported AGP version of Gradle 7.0 to AGP 4.0.

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

@bot-gradle test this

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

OK, I've already triggered ReadyForMerge build for you.


mocha -w not reflecting element changes

How would one use describeWithDOM() with mocha -w. When I make changes to my react component, the tests don't reflect on watch reload.

@cameronjroe when you use --watch, the globals don't get wiped across test runs - thus the global document wouldn't either. Is there a chance you're making changes to document in your tests/implementation, without cleaning up after, that's persisting across runs?

No, I'm just using mount within an it block. When I change the component the tests don't pick up the change.
it("should support additional props passed in", () => {
    const rating = mount(<StarRating name='rating' className='something' />);
    expect(rating.find('span').first().prop('className')).to.contain('rsr-container');
});

Any ideas on this?

I'm not certain, but one of the other contributors will be sure to get back to you, hopefully by Monday!

Okay, cheers.

@cameronjroe that is strange. Can you describe more about your environment and your tests?  This seems like it might be a mocha issue. Is document provided by a browser or by jsdom?

I'm using describeWithDOM which seems to be using jsdom. I'm requiring a jsx file of the component which doesn't reload once I start the tests. I'm also trying to run:
  after(() => {
    wrapper.unmount();
    wrapper.detach();
  })

but both methods are showing undefined.

@cameronjroe you might be using an older version of enzyme as those are newer methods. You also shouldn't need to run .unmount() or .detach(). The former is only useful if you want to test your component's componentWillUnmount lifecycle. The latter is only possible to be used if you are passing in an attach option to mount() which I don't believe you are.

Okay, thanks. I just changed .jsx to .js and now the tests seem to run okay.


Duplicated and old aggregate attestations

Context
During the work on #1244 duplicate attestations generated Invalid Signature errors at the time of block proposals when trying to generate aggregates (the BLS aggregate signature was computing the same aggregator more than once in the signature generated), this didn't happened before making the handle_new_block and handle_tick synchronous (i.e. without removing the GenServer and just converting casts to calls in the ValidatorManager the error was reproduced). A quick solution is already in place:
  # TODO: We need to check why we are producing duplicate attestations, this was generating invalid signatures
  unique_attestations = attestations |> Enum.uniq()

Description
The purpose of this task is two-fold

Understand the root cause of duplicated attestations and fix it
We are receiving duplicates just from ourselves, this error pop-up only when we are publishing attestations, if we just receive them from other nodes we don't have this issue.

Understand why we are still adding duplicate aggregate attestations in our block proposals (this was happening before #1244)
This might be related to the previous one, given that we only uniquely filtered them at the aggregation step this behavior might be affecting also aggregates and not just committee attestations.

Example of a block with duplicated aggregate attestations:

This also happens now with sync_committee_messages as per #1284

Additionally this should tackle the issue that we add attestation for slot-2 to our blocks instead of slot-1 as the other nodes.


Improving the 7TV GQL implementation.

Using GQL variables which avoids string format issues.
Pull request checklist:

[ ] CHANGELOG.md was updated, if applicable
[ ] Documentation in docs/ or install-docs/ was updated, if applicable

I don‘t really see any problem with the original implementation, since we‘re interpolating numbers, not arbitrary strings…

I don‘t really see any problem with the original implementation, since we‘re interpolating numbers, not arbitrary strings…

Yeah safety-wise I guess we'd be fine, this seems to be more readable and standard when it comes to GQL queries that take parameters though so I'd prefer this


Fix "TypeError: Assignment to constant variable.

Auto incrementing the file name suffix (aka "discriminator") doesn't work if the file name is a constant; it just crashes out of node with a "TypeError" (actually should be a storage class or mutability error, but that's javascript for you).
Making it mutable fixes the problem.

Thank you! I was wondering when more bugs would pop up from this.

Oh, this may be the bug I ran into last night (I changed something from
"_:/plugins/" title prefix to "$:/plugins/" prefix and Bob crashed after
deleting the first tiddler but before creating the second (as close as I
could tell). I'll do more testing around this and this fix after I recover
that lost tiddler.
Best,
Joshua F
On Sun, Jun 30, 2019 at 11:15 PM jed<EMAIL_ADDRESS>wrote:

Thank you! I was wondering when more bugs would pop up from this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OokTech/TW5-Bob/pull/95?email_source=notifications&email_token=ACFOMB7AKO3X3YIAWMAJFRDP5GOHNA5CNFSM4H4NTSM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY5DBVI#issuecomment-507130069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACFOMBZWRWBNEMGKYNJIPB3P5GOHNANCNFSM4H4NTSMQ
.