bpf: Remove unused BPF feature probes/macros

The following macros were used in the old implementation of load
balancer, but are not used anymore:

HAVE_MAP_VAL_ADJ
HAVE_MARK_MAP_VALS

Also, those feature are available in kernel 4.9+, which is already
required for running Cilium.
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

This change is

test-me-please

Coverage increased (+0.06%) to 45.889% when pulling 878e3aebc468d0ff04d9a77d21f378f43898d5fb on mrostecki:remove-unused-probes into 70c2eae518329ddc5f1b6e44fe416cf8b54700ba on cilium:master.

test-me-please

Probably unrelated
11:52:45  • Failure [117.949 seconds]
11:52:45  K8sServicesTest
11:52:45  /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:395
11:52:45    Checks service across nodes
11:52:45    /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:395
11:52:45      Tests NodePort BPF
11:52:45      /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:395
11:52:45        Tests with direct routing
11:52:45        /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:395
11:52:45          Tests NodePort [It]
11:52:45          /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:430
11:52:45
11:52:45          Pod "testclient-nrqjd" can not connect to service "http://<IP_ADDRESS>:32499"
[2020-01-06T10:52:45.526Z]         Expected command: kubectl exec -n default testclient-nrqjd -- curl --path-as-is -s -D /dev/stderr --fail --connect-timeout 5 --max-time 8 http://<IP_ADDRESS>:32499 -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
[2020-01-06T10:52:45.526Z]         To succeed, but it failed:
[2020-01-06T10:52:45.526Z]         Exitcode: 28
[2020-01-06T10:52:45.526Z]         Stdout:
[2020-01-06T10:52:45.526Z]          	 time-> DNS: '0.000018()', Connect: '0.000000',Transfer '0.000000', total '5.001122'
[2020-01-06T10:52:45.526Z]         Stderr:
[2020-01-06T10:52:45.526Z]          	 command terminated with exit code 28
[2020-01-06T10:52:45.526Z]
[2020-01-06T10:52:45.526Z]
11:52:45
11:52:45          /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/k8sT/Services.go:295

test-me-please


Move maas_rpc_scripts_dir and maas_venv_enabled

This commit moves the maas_rpc_scripts_dir variable definition to the
verify-maas.yml playbook. This variable is used no where else in the
rpc-maas role and has been taken out per
https://github.com/rcbops/rpc-maas/pull/239
This commit also removes the maas_venv_enabled variable. MaaS plugins
will now always run inside a python virtualenv.
Connects https://github.com/rcbops/u-suk-dev/issues/1601

We need https://github.com/rcbops/rpc-openstack/pull/2245 in Newton branch, so that would be great to merge it before.

Not merging, until the other one merged.


Holography reconstruction prototype

Jupyter notebook containing hologram reconstruction prototype.
It uses pieces of code which we previously contributed to hyperspy (has corresponding license statements). It also uses several functions of HS which are imported from the package. At later stage (when I create a standalone UDF out of this prototype) those can be copied to LiberTEM.

@woozey Thank you for the PR! I'm happy to hear that it works well for you. :-)
By the way, @sk1p and I have discussed the package structure of LiberTEM. We are looking into ways to include applications that depend on Hyperspy without introducing a hard dependency in the core of LiberTEM. Generally, Issue #261 is becoming more and more urgent to keep the core of LiberTEM lean and compact while nurturing a nice ecosystem of applications around it.

Thanks for the PR!
The license of mkl-fft is sadly proprietary - but we should include some facility to allow users to use it anyways (See also: #400) - also mkl-fft doesn't provice wheels for current python versions (3.7, 3.8) :frowning:. Because of this, I did my testing using pyfftw, which is GPL-Licensed.
I missed this yesterday, but the n_workers argument actually should be passed as part of cluster_kwargs, for example like this:
ctx = Context(executor=DaskJobExecutor.make_local(cluster_kwargs={
    'n_workers' : 4,
    "threads_per_worker": 1,
}))

I ran a small benchmark to check the scaling behavior:
for n_workers in [1, 4, 8, 16, 18, 24, 36]:
    print("n_workers=%d" % n_workers)
    ctx = Context(executor=DaskJobExecutor.make_local(cluster_kwargs={
        'n_workers' : n_workers,
        "threads_per_worker": 1,
    }))
    t1 = time.time()
    ds = ctx.load("dm", files=files[:100], stack=True)
    t2 = time.time()
    print("loaded in %0.5fs" % (t2 - t1))
    udf = HoloReconstructUDF(out_shape=out_shape,
                             sb_position=sb_pos,
                             sb_size=sb_size,
                             sb_smoothness=sb_smooth)
    res = ctx.run_udf(dataset=ds, udf=udf)
    t3 = time.time()
    ctx.close()
    print("processed in %0.5fs" % (t3 - t2))

And I got the following results (18 core CPU):
n_workers=1
loaded in 4.09582s
processed in 320.38284s

n_workers=4
loaded in 2.26589s
processed in 96.23547s

n_workers=8
loaded in 1.84957s
processed in 70.16752s

n_workers=16
loaded in 2.22425s
processed in 39.61359s

n_workers=18
loaded in 1.61925s
processed in 41.25830s

n_workers=24
loaded in 2.63052s
processed in 35.93761s

n_workers=36
loaded in 2.27313s
processed in 25.48298s

It looks like pyfftw even profits from hyperthreading quite a bit. Note that pyfftw is by default only using a single thread; with mkl-fft or a tweaked pyfftw setup, the optimum may indeed be at a lower number of workers.
With current numpy, using the build-in fft results in comparable performance to pyfftw.
Using 36 workers with pyfftw brought the processing time for the whole data set down to 8 minutes.

Oh, and I also forgot to mention: the CI pipeline still fails because of style issues, see https://travis-ci.org/LiberTEM/LiberTEM/jobs/621338588 for details

Thanks, merging! :tada: :tada:


[Amendment] SE-0296: Allow overloads that differ only in async

Explanation: Implement the async/await amendment currently under review that allows overloads that differ only in async vs. non-async.
Scope: Only affects programs that have already adopted Swift Concurrency. This loosens the rules around declaring overloads, so it accepts strictly more code that the existing language.
Radar/SR Issue: rdar://79788345
Risk: Low.
Testing: PR testing and CI on main.
Original PR: https://github.com/apple/swift/pull/38107

@swift-ci please test

@swift-ci please nominate

Build failed
Swift Test OS X Platform
Git Sha - 50e6f2a2b14b94ecca92a56476a72aceadb9de63

Grr. Spurious, unrelated SwiftPM failure


runtime: insufficient padding in the p structure

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

This issue is observed by reading the source code of the master branch.
While reading the code the other day I noticed that the p structure in src/runtime/runtime2.go includes the following at line 501:
pad [64]byte

I assume the intention is to pad by sys.CacheLineSize to avoid false sharing between the p structures. The value of 64 is currently plausible, but only because ppc64x is incorrectly configured with a cache line size of 64. (It should be 128; Someone from IBM will propose/confirm a fix - @laboger ?)

Yes, the cache line size should be 128. The only ppc64 processors I'm aware of that have a 64 byte cache line size are the e5500 and the PA6T, which, I believe, aren't supported by Golang.
I'll work on this issue.


Equality pattern fails after upgrade

After upgrading to 0.2.0 the following pattern stop working:
// #v-ifdef MODE=electron
...
// #v-endif

Is this expected?
BR

try this:
// #v-ifdef MODE='electron'
...
// #v-endif

#v-ifdef {JavaScript Expressions}, pls add ''


[FEATURE] Support multiple database back-ends

In deploying Flowise to Azure Container Apps, I had issues with mounting the SQLite database to a CIFS share. SQLite is great for simple deployments but one might want multiple instances of Flowise with a single backend or avoid having to mount SQLite on external storage in a cloud environment.
Implementing other backend databases should be relatively straightforward because of the use of typeorm. I have a modified version of Flowise running with MySQL as a backend and it works great (as far as my tests go). However, it would be great if this were supported by the project out of the box at some time in the feature.
In the meantime, thanks for your efforts with Flowise!

thats exactly why we use typeorm so user can easily switch to mysql, postgresql and others databases.
if you dont mind do you have a link to the implementation of switching to mysql? or feel free to open a PR :)

I used the following in DataSource.ts:
appDataSource = new DataSource({

        type: 'mysql',

        host: process.env.SQLHOST,

        port: parseInt(process.env.SQLPORT || '3306'),

        username: process.env.SQLUSERNAME,

        password: process.env.SQLPASSWORD,

        database: process.env.SQLDATABASE,

        charset: 'utf8mb4',

        synchronize: false,

        entities: [ChatFlow, ChatMessage, Tool],

        migrations: [],

        ssl: {

            ca:  fs.readFileSync(__dirname + '/ca.pem')

        }

    })

In the container build I ensure ca.pem is copied to the correct folder. ca.pem is retrieved from Azure MySQL Server portal.
I also created the database in MySQL with charset utf8mb4 and collation utf8mb4_unicode. I got errors saving sourceDocuments in chat messages otherwise. Default charset for databases (in Azure MySQL at least) is utf8.
I also needed to change the entities to support longtext in fields. For example in ChatFlow.ts:
/* eslint-disable */
import { Entity, Column, CreateDateColumn, UpdateDateColumn, PrimaryGeneratedColumn } from 'typeorm'
import { IChatFlow } from '../Interface'

@Entity()
export class ChatFlow implements IChatFlow {
    @PrimaryGeneratedColumn('uuid')
    id: string

    @Column()
    name: string

    @Column({ type: "longtext" })
    flowData: string

    @Column({ nullable: true })
    apikeyid: string

    @Column()
    deployed: boolean

    @CreateDateColumn()
    createdDate: Date

    @UpdateDateColumn()
    updatedDate: Date
}

I also did that for longer fields in ChatMessage.ts and Tool.ts.
I did have issues with synchronize: true though. So I run that once locally to create the database and then turn that off in the container build. I guess there are solutions to this but I don't know enough about TypeORM and did not spend extra time in researching that.

thanks @gbaeke this is helpful! amazing to see how people are customizing for their own use cases.
we'll be sure to add different database integration as we move closer to production

synchronize: false should be there in the production environment, you can lose your data on every build.
this option is for debug or dev mode where every time you need a fresh database
ref: https://typeorm.io/data-source-options#common-data-source-options

Hi @gbaeke, could you help verify/suggestion/enhance this documentation?
Flowise Docs #9

Updated docs - https://docs.flowiseai.com/databases and PR #575 merged


Automatic sync not working on at_client: 3.0.10 / at_utils 3.0.6 onwards

Describe the bug
When setting a AtKey and putting a value using at_client: 3.0.10 / at_utils 3.0.6 onwards no client sync is happening so no notification is sent and the receiving @ sign does not know about the shared information
To Reproduce
Steps to reproduce the behavior:

Using the MWC demo code use the previous version of the libs and everything works as it should
Then I updated to the newer versions and everything stops working and with weird sync results
Moving back cures the issues
The MWC demo and Snackbar use auto notiifications and hence if someone builds them with the latest libs they will not work!

Expected behavior
Auto Synch should work as it did in previous builds
Video
https://user-images.githubusercontent.com/6131216/155606320-d148726f-9206-4df8-818c-65746050bdaf.mp4
Smartphone (please complete the following information):

Dart SDK version: 2.16.1 (stable) (Tue Feb 8 12:02:33 2022 +0100) on "windows_x64"

Were you using an @application when the bug was found?

mwc demo

Additional context
Add any other context about the problem here.

I watched the video and found the '42' I changed it to '0' so that would zero out the dials at first rather than give a false reading..

The changes are published in at_client : 3.0.12

Suggest we leave this ticket open under we have end to end tests in place to check this works

end to end test to be taken up in PR 32


abseil-cpp: 20240116.2 -> 20240722.0

Description of changes
Changelog: https://github.com/abseil/abseil-cpp/releases/tag/20240722.0

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build abseil-cpp

I succesfully built abseil-pp on all 4 architectures.

@ofborg build telegram-desktop ycmd libreoffice protobuf

The pattern of abseil-cpp pinning and lack of pinning makes no sense to me. 🙂
I spent a lot of CPU cycles and disk space building stuff. I don't think I found anything that doesn't build due to this patch, but it's staging: there's a lot of noise.

The pattern of abseil-cpp pinning and lack of pinning makes no sense to me. 🙂

It is basically: if things break because they do major changes we pin an older version.

I think this broke onnxruntime, but downgrading it to 202401 does not fix it and gtest does not consume abseil-cpp, so I'm not sure where to apply a fix.
onnxruntime> In file included from /nix/store/b98gmgf0hv1fmwk6sff5q316mpd8h169-source/googletest/include/gtest/gtest-assertion-result.h:46,
onnxruntime>                  from /nix/store/b98gmgf0hv1fmwk6sff5q316mpd8h169-source/googletest/include/gtest/gtest.h:64,
onnxruntime>                  from /build/source/onnxruntime/test/util/file_util.cc:3:
onnxruntime> /nix/store/b98gmgf0hv1fmwk6sff5q316mpd8h169-source/googletest/include/gtest/gtest-message.h:62:10: fatal error: absl/strings/internal/has_absl_stringify.h: No such file or directory
onnxruntime>    62 | #include "absl/strings/internal/has_absl_stringify.h"
onnxruntime>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
onnxruntime> compilation terminated.
onnxruntime> make[2]: *** [CMakeFiles/onnxruntime_test_utils.dir/build.make:104: CMakeFiles/onnxruntime_test_utils.dir/build/source/onnxruntime/test/util/file_util.cc.o] Error 1
onnxruntime> make[2]: *** Waiting for unfinished jobs....

gtest does not consume abseil-cpp

It does optionally https://github.com/google/googletest/blob/main/googletest/include/gtest/gtest-message.h#L59-L62

Not in our package, so?

We are using both the compiled variant and the source and since we build onnxruntime I think it is configuring gtest with abseil https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/onnxruntime/default.nix#L184-L187
I can't test this right now though...

But rolling back abseil to 202401 in onnxruntime doesn't fix the build.


Bug: did you publish the latest 0.3.2 version ?

Describe the bug
trying to poetry add surrealdb uses 0.3.1
Steps to reproduce

poetry add surrealdb
using 0.3.2 in the pyproject.toml will give

Because project depends on surrealdb (^0.3.2) which doesn't match any versions, version solving failed.

Expected behaviour
poetry add surrealdb adds 0.3.2 latest
SurrealDB version
1.0.0
surrealdb.py version
0.3.1
Contact Details
<EMAIL_ADDRESS>Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It's not released on pypi

We had some issues with PyPi that took some time to resolve, but it's published now.


Removes unnecessary commas at end of KV pair of objects

Just some general syntax clean up - removes commas at final key value pair for a few objects (breaks in IE9).

Thanks for your contribution. However, since #32 is merged and we've changed build tool to babeljs, this issue no longer exists. Close now.


cache_loader: module silicon not found

Hey, was trying to get the silicon plugin to work with nvim to no success. Have installed silicon using cargo install, added it to lazy installation:
{     "krivahtoo/silicon.nvim", build = "make" },
Then tried to setup:
require('silicon').setup({   clipboard = true,     watermark = {       text = ' @Yair-Ziv',     }, })
When opening nvim, Lazy installs it correctly (I think):

But when executing nvim:
Error detected while processing /home/yairziv/dotfiles/.config/nvim/init.lua: E5113: Error while calling lua chunk: /home/yairziv/dotfiles/.config/nvim/init.lua:580: module 'silicon' n ot found:         no field package.preload['silicon'] cache_loader: module silicon not found cache_loader_lib: module silicon not found         no file './silicon.lua'         no file '/build/nvim/parts/nvim/build/.deps/usr/share/luajit-2.1/silicon.lua'         no file '/usr/local/share/lua/5.1/silicon.lua'         no file '/usr/local/share/lua/5.1/silicon/init.lua'         no file '/build/nvim/parts/nvim/build/.deps/usr/share/lua/5.1/silicon.lua'         no file '/build/nvim/parts/nvim/build/.deps/usr/share/lua/5.1/silicon/init.lua'         no file './silicon.so'         no file '/usr/local/lib/lua/5.1/silicon.so'         no file '/build/nvim/parts/nvim/build/.deps/usr/lib/lua/5.1/silicon.so'         no file '/usr/local/lib/lua/5.1/loadall.so' stack traceback:         [C]: in function 'require'         /home/yairziv/dotfiles/.config/nvim/init.lua:580: in main chunk Press ENTER or type command to continue
Additional info:
Running ubuntu, i3wm
nvim version is 0.9.4
silicon version is 0.5.2
Also,
When in nvim trying to use Silicon with :'<, '>Silicon
I get E492: Not an editor command: '<, '>Silicon
Appreciate all help!

Use {'krivahtoo/silicon.nvim', run = './install.sh build'} for installation if you have cargo installed.
Also silicon.nvim does not require silicon to be installed.

Still does not work, and running './install.sh build' runs successfully

What is the output of running command := require('silicon')?

What is the output of running command := require('silicon')?

E5108: Error executing lua [string ":lua"]:1: module 'silicon' not found:
	no field package.preload['silicon']
cache_loader: module silicon not found
cache_loader_lib: module silicon not found
	no file './silicon.lua'
	no file '/usr/share/luajit-2.1/silicon.lua'
	no file '/usr/local/share/lua/5.1/silicon.lua'
	no file '/usr/local/share/lua/5.1/silicon/init.lua'
	no file '/usr/share/lua/5.1/silicon.lua'
	no file '/usr/share/lua/5.1/silicon/init.lua'
	no file './silicon.so'
	no file '/usr/local/lib/lua/5.1/silicon.so'
	no file '/usr/lib/lua/5.1/silicon.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
	[C]: in function 'require'
	[string ":lua"]:1: in main chunk

If you didn't have rustup before, run rustup default stable and go to where your plugins are located, then enter silicon.nvim. Inside it, run ./install.sh build.


Docs: add dependency section

Is your feature request related to a problem? Please describe.
Yes, when a user is getting started and they are reading the docs, they want to know what dependencies they have to import.
Describe the solution you'd like
Adding a dependency section in the docs.
Describe alternatives you've considered
No alternatives, since we are using Paradox we only have one choice (https://developer.lightbend.com/docs/paradox/current/directives/dependencies.html)
Additional context
N/A

Fixed by #22


Fix CI build after repository transfer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@3fda1e2). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #93   +/-   ##
=========================================
  Coverage          ?   58.32%
  Complexity        ?      135
=========================================
  Files             ?       34
  Lines             ?     3494
  Branches          ?      788
=========================================
  Hits              ?     2038
  Misses            ?      915
  Partials          ?      541

Flag
Coverage Δ

helper
58.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


 I have full GREEN! I deserve a beer or something now.
Raw kernel interrupt test looks like it's because the kernel dies before the code starts actually running (I think the kernel interrupt was too soon?) A small sleep seems to fix it.
Export/Import test fails on test machine was because we were deleting all temp .ipynb files after after test run. This seems to have fixed a bunch more flakey issues.
The trusted notebook test I couldn't get to repro and adding logging fixed it. I added a sleep and it seems to work now.

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@842a0b3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #14346   +/-   ##
=======================================
  Coverage        ?   59.42%
=======================================
  Files           ?      716
  Lines           ?    39952
  Branches        ?     5789
=======================================
  Hits            ?    23740
  Misses          ?    14951
  Partials        ?     1261

Impacted Files
Coverage Δ

src/client/formatters/blackFormatter.ts
79.16% <0.00%> (ø)

src/client/linters/errorHandlers/standard.ts
31.81% <0.00%> (ø)

src/client/providers/symbolProvider.ts
88.73% <0.00%> (ø)

src/datascience-ui/common/cellFactory.ts
34.14% <0.00%> (ø)

...interpreter/jupyterInterpreterDependencyService.ts
76.57% <0.00%> (ø)

src/client/common/application/types.ts
100.00% <0.00%> (ø)

src/datascience-ui/renderers/constants.ts
0.00% <0.00%> (ø)

src/client/pythonEnvironments/info/interpreter.ts
80.95% <0.00%> (ø)

src/client/common/installer/poetryInstaller.ts
95.83% <0.00%> (ø)

src/client/activation/jedi/languageServerProxy.ts
27.27% <0.00%> (ø)

... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842a0b3...f1765f9. Read the comment docs.


Lack of Apache-2.0 license option prevents this from being used by the standard library

The current crate license is MIT only, with no option for Apache-2.0
However, for a crate to become a dependency of the standard library it has to have Apache-2.0 OR MIT as the license (plus possibly other license options, if any).
So, this crate can't become an eventual part of the standard library if the Apache-2.0 license isn't added as an option.
(If that's not a goal of this crate that's fine, but if so that should probably be affirmed somewhere, because if that's the case then winapi will need to continue to be used by the standard library)

That's certainly a goal.
I had a quick look and it seems we can probably offer Apache License 2.0 as well - I'm just not sure how to add that to the existing MIT license.

That's certainly a goal.
I had a quick look and it seems we can probably offer Apache License 2.0 as well - I'm just not sure how to add that to the existing MIT license.

IMNAL but isn't MIT compatible with Apache 2.0? Which should mean you can use it freely in an Apache 2.0 as long as you comply with its MIT part?
Also, the logic behind MIT or Apache 2.0 doesn't make sense to me. If I violate Apache 2.0, do I go to court saying "But I chose to use its MIT part" and vice versa?
Or, is it MIT + Apache 2.0, which means you have to comply with both?

IMNAL but isn't MIT compatible with Apache 2.0? Which should mean you can use it freely in an Apache 2.0 as long as you comply with its MIT part?
Also, the logic behind MIT or Apache 2.0 doesn't make sense to me. If I violate Apache 2.0, do I go to court saying "But I chose to use its MIT part" and vice versa?
Or, is it MIT + Apache 2.0, which means you have to comply with both?

IMNAL, but, according to my understanding, Apache 2.0 has more grants than MIT (at least w.r.t. "grant of patent license"), so, in general, software licensed under MIT cannot be freely relicensed/reused under Apache 2.0.

IMNAL, but, according to my understanding, Apache 2.0 has more grants than MIT (at least w.r.t. "grant of patent license"), so, in general, software licensed under MIT cannot be freely relicensed/reused under Apache 2.0.

IMNAL, but, according to my understanding, Apache 2.0 has more grants than MIT (at least w.r.t. "grant of patent license"), so, in general, software licensed under MIT cannot be freely relicensed/reused under Apache 2.0.

True, but there is no MIT restriction for "grant of patent license", which makes the Patent clause bound to local and international laws by default, however it can get explicit when combined (+) with Apache 2.0.
However, if I do not explicitly grant you patent license over my MIT project and you use it in your Apache 2.0 project, I may be able to troll sue you for patents (? big question mark here since I did give it away for free use in any project, and this is free and fair use that doesn't violate the MIT license.).
Either way, engagement is Patent wars will disallow the suing parties to use the Apache 2.0 project, forever.
Do I miss something?

IMNAL, but, according to my understanding, Apache 2.0 has more grants than MIT (at least w.r.t. "grant of patent license"), so, in general, software licensed under MIT cannot be freely relicensed/reused under Apache 2.0.

True, but there is no MIT restriction for "grant of patent license", which makes the Patent clause bound to local and international laws by default, however it can get explicit when combined (+) with Apache 2.0.
However, if I do not explicitly grant you patent license over my MIT project and you use it in your Apache 2.0 project, I may be able to troll sue you for patents (? big question mark here since I did give it away for free use in any project, and this is free and fair use that doesn't violate the MIT license.).
Either way, engagement is Patent wars will disallow the suing parties to use the Apache 2.0 project, forever.
Do I miss something?

IMNAL.
It seems the rational behind licensing Apache 2.0 or MIT is that everything is licensed as Apache 2.0 first, and if Apache 2.0 is not compatible, then the MIT is opted. This was originally created with the goal of being compatible with GPLv2.
Source:
https://internals.rust-lang.org/t/rationale-of-apache-dual-licensing/8952
josh said:

If we had it to do over again today, I’d suggest the https://opensource.org/licenses/BSDplusPatent license, which is a permissive license with the Apache 2.0 patent grant but retaining GPLv2-compatibility. But that license didn’t exist when Rust was first licensed.

I checked the official rust repository, it doesn't seem like there is an explicit condition that says that Apache 2.0 is first in priority so my best guess is that it is implicit by the order you declare your license. a.k.a Apache 2.0 or MIT when Apache 2.0 is the first and only then MIT is accepted (if Apache 2.0 is not). I'm not sure that this is indeed legally correct but again, IMNAL.
Other than that, the rust repository seem to only contain a copy of each license: LICENSE-APACHE and LICENSE-MIT.
https://github.com/rust-lang/rust

IMNAL.
It seems the rational behind licensing Apache 2.0 or MIT is that everything is licensed as Apache 2.0 first, and if Apache 2.0 is not compatible, then the MIT is opted. This was originally created with the goal of being compatible with GPLv2.
Source:
https://internals.rust-lang.org/t/rationale-of-apache-dual-licensing/8952
josh said:

If we had it to do over again today, I’d suggest the https://opensource.org/licenses/BSDplusPatent license, which is a permissive license with the Apache 2.0 patent grant but retaining GPLv2-compatibility. But that license didn’t exist when Rust was first licensed.

I checked the official rust repository, it doesn't seem like there is an explicit condition that says that Apache 2.0 is first in priority so my best guess is that it is implicit by the order you declare your license. a.k.a Apache 2.0 or MIT when Apache 2.0 is the first and only then MIT is accepted (if Apache 2.0 is not). I'm not sure that this is indeed legally correct but again, IMNAL.
Other than that, the rust repository seem to only contain a copy of each license: LICENSE-APACHE and LICENSE-MIT.
https://github.com/rust-lang/rust

IMNAL.
It seems the rational behind licensing MIT or Apache 2.0 is that everything is licensed as Apache 2.0 first (the more restrictive license), and if Apache 2.0 is not compatible, then the less restrictive MIT is opted. This was originally created with the goal of using Apache 2.0 as license however still wanting to be usable/compatible with GPLv2.
Source:
https://internals.rust-lang.org/t/rationale-of-apache-dual-licensing/8952
josh said:

Requiring both MIT and Apache 2.0 as inbound licenses for contributions means that anyone making a contribution is providing the Apache 2.0 patent grant. And then having MIT and Apache 2.0 as outbound licenses people can use Rust under means that Rust provides widespread compatibility with all sorts of other FOSS licenses, including GPLv2.

If we had it to do over again today, I’d suggest the https://opensource.org/licenses/BSDplusPatent license, which is a permissive license with the Apache 2.0 patent grant but retaining GPLv2-compatibility. But that license didn’t exist when Rust was first licensed.

I checked the official rust repository, it doesn't seem like there is an explicit condition that says that Apache 2.0 is first in priority so my best guess is that it is implicit by the order from most restrictive to less restrictive license, where the first compatible license is automatically opted, but I'm not sure that this is indeed correct or legally correct, IMNAL.
Other than that, the rust repository seem to only contain a copy of each license: LICENSE-APACHE and LICENSE-MIT to make it MIT or Apache 2.0
https://github.com/rust-lang/rust

IMNAL.
It seems the rational behind licensing MIT or Apache 2.0 is that everything is licensed as Apache 2.0 first (the more restrictive license), and if Apache 2.0 is not compatible, then the less restrictive MIT is opted. This was originally created with the goal of using Apache 2.0 as license however still wanting to be usable/compatible with GPLv2.
Source:
https://internals.rust-lang.org/t/rationale-of-apache-dual-licensing/8952
josh said:

Requiring both MIT and Apache 2.0 as inbound licenses for contributions means that anyone making a contribution is providing the Apache 2.0 patent grant. And then having MIT and Apache 2.0 as outbound licenses people can use Rust under means that Rust provides widespread compatibility with all sorts of other FOSS licenses, including GPLv2.

If we had it to do over again today, I’d suggest the https://opensource.org/licenses/BSDplusPatent license, which is a permissive license with the Apache 2.0 patent grant but retaining GPLv2-compatibility. But that license didn’t exist when Rust was first licensed.

I checked the official rust repository, it doesn't seem like there is an explicit condition that says that Apache 2.0 is first in priority so my best guess is that it is implicit by the order from most restrictive to less restrictive license, where the first compatible license is automatically opted, but I'm not sure that this is indeed correct or legally correct, IMNAL.
Other than that, the rust repository seem to only contain a copy of each license: LICENSE-APACHE and LICENSE-MIT to make it MIT or Apache 2.0
https://github.com/rust-lang/rust

It's an OR, the license order listed doesn't matter. The end user makes the choice based on whatever criteria they want.
Some crates list "MIT or Apache", some list "Apache or MIT".
I think "Apache or MIT" is more common just for alphabetical reasons.
(not a lawyer)

It's an OR, the license order listed doesn't matter. The end user makes the choice based on whatever criteria they want.
Some crates list "MIT or Apache", some list "Apache or MIT".
I think "Apache or MIT" is more common just for alphabetical reasons.
(not a lawyer)

I did a bit more digging. According to our open source team (source):

The default license preferred by Microsoft for releasing our own code is the MIT License. The MIT license is compatible with other open source licenses, it can be easily used by our customers, and it is rising in use across the industry. Therefore, when we are releasing our own code as OSS, we use the MIT license absent a compelling business reason to do otherwise.

So I'm hoping MIT will be sufficient. If not, I can reach out to our legal folks to see whether we can get an exception.

I did a bit more digging. According to our open source team (source):

The default license preferred by Microsoft for releasing our own code is the MIT License. The MIT license is compatible with other open source licenses, it can be easily used by our customers, and it is rising in use across the industry. Therefore, when we are releasing our own code as OSS, we use the MIT license absent a compelling business reason to do otherwise.

So I'm hoping MIT will be sufficient. If not, I can reach out to our legal folks to see whether we can get an exception.

I am not on the teams that make this approval.
However, I can say what happened with me: when I had a project that was even more permissively licensed than MIT (it was using the Zlib license), this came up. It was requested that the project (tinyvec) move to having an MIT OR Apache2 option if I wanted to stay as part of the rust standard library dependency pile in the long term.

I am not on the teams that make this approval.
However, I can say what happened with me: when I had a project that was even more permissively licensed than MIT (it was using the Zlib license), this came up. It was requested that the project (tinyvec) move to having an MIT OR Apache2 option if I wanted to stay as part of the rust standard library dependency pile in the long term.

BTW, found a detailed article explaining both the rational and HOW-TO:
https://github.com/sfackler/rust-postgres-macros/issues/19

BTW, found a detailed article explaining both the rational and HOW-TO:
https://github.com/sfackler/rust-postgres-macros/issues/19

IMNAL, but, according to my understanding, Apache 2.0 has more grants than MIT (at least w.r.t. "grant of patent license"), so, in general, software licensed under MIT cannot be freely relicensed/reused under Apache 2.0.

I don't know about relicensed (depends) on our definition for this?), but you can miz them, they don't contridict. A grand is OK as long as it's not violating an existing restriction.
Again, IMNAL.

IMNAL, but, according to my understanding, Apache 2.0 has more grants than MIT (at least w.r.t. "grant of patent license"), so, in general, software licensed under MIT cannot be freely relicensed/reused under Apache 2.0.

I don't know about relicensed (depends) on our definition for this?), but you can miz them, they don't contridict. A grand is OK as long as it's not violating an existing restriction.
Again, IMNAL.

Thanks for the feedback - I received approval and we are now dual licensed.

Thanks for the feedback - I received approval and we are now dual licensed.


Focus issue on Tearsheet with carbon Modal

What package(s) are you using?

[x] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.

We need to open a modal on top of a tearsheet when user tries to close the tearsheet with form filled.
I am using React.portal to render both Tearsheet and Modal at the document.body.
When the Modal is open, user is seeing issue with the focus still being on the tearsheet.
And in Chrome, the focus can not be fixed unless user click away from the current html document (i.e click the address bar in the browser) and comes back to the modal - all steps documented in this codesandbox example:
https://codesandbox.io/s/still-smoke-h1900i?file=/src/App.js

Is this issue related to a specific component?

Tearsheet

What did you expect to happen? What happened instead? What would you like to
see changed?

The focus should be working properly on the Modal

What browser are you working in?

Chrome, Firefox

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?

Issue is found on Production running<EMAIL_ADDRESS>But I can reproduce on<EMAIL_ADDRESS>with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Watson knowledge catalog. CPD 4.6 (Nov 2022)
Steps to reproduce the issue
Documented in the codesandbox

Please create a reduced test case in CodeSandbox

https://codesandbox.io/s/still-smoke-h1900i?file=/src/App.js

Hi @nelsonchen90, This might be an issue due to React portal. I have attempted to obtain the focus on an input inside the modal by adding selectorPrimaryFocus. However, the Tearsheet is brought back into focus once more. I have found a solution for the same from the github community. Here is the link. Kindly check this and let me know your thoughts.
https://github.com/facebook/react/issues/12454

@jagathgj
Thanks for pointing that solution. However, that doesn't resolve my issue, you can see it in the original codesanbox or here: https://codesandbox.io/s/still-smoke-h1900i?file=/src/App.js

Hi @nelsonchen90, I have investigated the issue. It might be a problem with the functionalities in Tearsheet. Tearsheet is claiming the focus back due to function written for 'stacked' tearsheet. If we move Modal inside the tearsheet, it will work as expected. But again this focus trap issue needs to be taken care. I will let you know once fixing it.

Hi @nelsonchen90, It was found out that the Carbon 10 Modal doesn't support stacked Modals. Even though the Tearsheet is based on basic Modal component, the functions written for Tearsheetshell won't work on Modals and it would be hard to achieve the expected result. This issue should be taken care in Carbon 11.
@elycheea FYI

Closing this issue. #2452 is where we are tracking the nested modal/tearsheet issues further. @davidmenendez has opened PR and discussion in the Carbon repo as well.


spirv-fuzz: Do not add synonym via CompositeConstruct when block is dead

@Vasniktel This relates to the discussion we had earlier about not wanting to add synonyms related to composites - except in this case the problem is that the composite we have added is irrelevant by virtue of being in a dead block.
I wonder whether you can work this test case in when you work on solving this problem?
TEST(TransformationCompositeConstructTest, DontAddSynonymsWhenBlockIsDead) {
  std::string shader = R"(
               OpCapability Shader
          %1 = OpExtInstImport "GLSL.std.450"
               OpMemoryModel Logical GLSL450
               OpEntryPoint Fragment %4 "main"
               OpExecutionMode %4 OriginUpperLeft
               OpSource ESSL 320
          %2 = OpTypeVoid
          %3 = OpTypeFunction %2
          %6 = OpTypeFloat 32
          %7 = OpTypeVector %6 2
          %8 = OpTypePointer Function %7
         %10 = OpConstant %6 1
         %11 = OpConstant %6 2
         %12 = OpConstantComposite %7 %10 %11
         %13 = OpTypeBool
         %14 = OpConstantFalse %13
          %4 = OpFunction %2 None %3
          %5 = OpLabel
          %9 = OpVariable %8 Function
               OpStore %9 %12
               OpSelectionMerge %16 None
               OpBranchConditional %14 %15 %16
         %15 = OpLabel
               OpBranch %16
         %16 = OpLabel
               OpReturn
               OpFunctionEnd
  )";

  const auto env = SPV_ENV_UNIVERSAL_1_3;
  const auto consumer = nullptr;
  const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
  ASSERT_TRUE(IsValid(env, context.get()));

  spvtools::ValidatorOptions validator_options;
  TransformationContext transformation_context(
      MakeUnique<FactManager>(context.get()), validator_options);
  transformation_context.GetFactManager()->AddFactBlockIsDead(15);

  TransformationCompositeConstruct transformation(
      7, {10, 11}, MakeInstructionDescriptor(15, SpvOpBranch, 0), 200);
  ASSERT_TRUE(
      transformation.IsApplicable(context.get(), transformation_context));
  ApplyAndCheckFreshIds(transformation, context.get(), &transformation_context);
  ASSERT_TRUE(IsValid(env, context.get()));
  ASSERT_FALSE(transformation_context.GetFactManager()->IsSynonymous(
      MakeDataDescriptor(10, {}), MakeDataDescriptor(200, {0})));
  ASSERT_FALSE(transformation_context.GetFactManager()->IsSynonymous(
      MakeDataDescriptor(11, {}), MakeDataDescriptor(200, {1})));
}

The situation here is similar to #3830. In both cases, the transformation creates an instruction in a dead block and tries to mark it with DataSynonym fact. I suspect other transformations have this bug as well.

I wonder whether you can work this test case in when you work on solving this problem?
Sure.

@afd, you can assign me to this one.

This was taken care of in recent PRs.


Exception value.map is not a function when array field is undefined in collection

Describe the bug
When bringing an array field that is undefined in the database, the dataMapper returns an exception claiming that value.map is not a function.
To Reproduce
Search for a document from the database that contains a field declared in the entity as an array and that is undefined in the collection.
Expected behavior
The expected behavior is that the field is returned as undefined, since it does not exist in the database.
Additional context
This problem happens because when parsing an array, it is only checked if it is equal to null, but there is a difference in MongoDB between null and undefined, if I save a field as null, the key exists in the document, but with a null value, but if the key does not exist in the document, when the datamapper tries to parse the value (which will be undefined), the check will only be made if value is equal to null, after that it tries to call value.map, being value undefined, an exception is generated.

Solved in commit https://github.com/herbsjs/herbs2mongo/commit/2453cb72df917923f8ca668f1fe40890e8c0c2dc using checker.isEmpty.
This commit was included in version 4.1.0


Shell Interactive mode, Other usability

I am using sublime on ubuntu linux platform.
This plug-in works to send shell commands, line by line.
Following are the issues which I came across:

While editing shell script, no way of highlight select multiple lines of text
and to be sent to terminal.

Shell stdout screen is nice within workspace but it doesn't support to work with
an interactive shell app like gdb, R, etc requires the user input.

Could possibly the console screen output in second tab? when I use two column format, it is not nice.

Thanks for the suggestions.
As for 1 and 2, anything beyond running a basic command that doesn't use STDIN should be done in a real terminal. A terminal can be launched with Shift+Ctrl+Alt+C, let me know how it works on Linux.
For 3, the shell commands rely heavily on the exec command used by the build systems.  This command is limited to panel output.  Since piggybacking on the exec command allows the plugin to stay simple (~40 lines of actual code), I think I'm gonna stay away from implementing anything for outputting to a tab.


[Feature Request] Dub selection for KickAssAnime.am if available

Source name
kickAssAnime
Source language
English
Describe your suggested feature
There should be an option to switch between sub or dub if available in either inside the video player or the episode list

Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I have updated the app to version 0.13.5.
[X] I will fill out all of the requested information in this form.

Already exists, in extension settings


Add dots between sentences in api definition

It seems like a common mistake to miss dots between sentences which results in
descriptions like: "ReadOnly Defaults to true". Which is sad.
This patch rights all the wrong. It consistently updates all descriptions for
all fields and structures to always end all sentences with dots, even if it's
just a single sentence.
While at it, several typos were fixed for affected descriptions, but fixing all
of them is not a goal of this patch.
Note: this patch doesn't guarantee new descriptions won't have this issue.
Reviewer, stay vigilant!

Please rebase, then it can be moved fwd as #1167 is merged.


Matrix multiplication MACs error！

MatMul_219 got a wrong result. It should be 157351936
Input shape looks weird, [12544,784] @  transpose([12544, 16])  ?   hope add inference shape checker

Thanks for your report. The MACs number is wrong, for considering B Matrix as 2-dimension only. It will be fixed soon.
But the input shapes should be just right.

Thanks for your report. The MACs number is wrong, for considering B Matrix as 2-dimension only. It will be fixed soon. But the input shapes should be just right.

Thank you！

v0.2.7 has fixed this issue. please check. pip install onnx-tool==0.2.7.

For A: 1x12x256x64, B: 1x12x64x256   v0.2.6: MACs=2,359,296   v0.2.7=50,331,648

v0.2.7 has fixed this issue. please check. pip install onnx-tool==0.2.7.

I have install onnx-tools 0.2.7，the MACs number is correct. Thank you very much!


fix: fix format error in OverrideFile

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[x] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.004%) to 71.021%

Files with Coverage Reduction
New Missed Lines
%

kclvm/query/src/lib.rs
1
93.55%

Totals

Change from base Build<PHONE_NUMBER>:
0.004%

Covered Lines:
53496

Relevant Lines:
75324

💛  - Coveralls


Easy selection of variables for filters / filtering in general

Problem statement
A recurring issue brought up in a test group is that setting up filters is hard. The reason is that, unlike demo data, all their datasets include units in parenthesis, often with unicode. This is very important for the user to know what data they are dealing with (compounded when metric and imperial units mix in a same dataset). That means backtick escaping, but it is also really hard and time consuming  to type stuff like:
Max Operating Temp (°C)
Output Capacitance (μF)
Or things like subscripts or diacritics:
P₁₁, P₁₂, énergie cinétique
This is especially the case when you are live exploring in a meeting and get a question like "how does this perform under such and such conditions" and these are not in the legend.
Possible solution:

drag a drop variables
dataframe viewer supporting filtering at column header (like qgrid does)

A related issue is that once you have added the variable to the query, how do you figure out what values are valid / typical? This is especially problematic for categorical variables. Implementing solution 2 above would fix that. With 1, some form of contextual help would possibly work.
In the past, I've implemented something like 2 for a web based product and customers really liked that functionality.

I've started looking at that. Probably will tackle this in a few steps. First, copy / paste. I do need help from someone who's a regular with PyQT: https://github.com/adamerose/PandasGUI/discussions/92

dataframe viewer supporting filtering at column header (like qgrid does)

That's been in the feature tracker for a while but I haven't started on it, glad to see someone pick it up.
Here's how I imagine it:

Right click the column header in the DataFrame viewer. I've already implemented this behavior, but all that's currently in there is Sort. You should add a Filter option to the menu
This pops up a widget in a dialog for entering a filter.
When the user submits, the dialog returns a query expression and this gets added to the PandasGuiDataFrameStore with add_filter
(Optional) Connect these same filter editors

Depending on the data type of the column the widget should look like these:
date -> QDatePicker
int/float -> QSlider spanning min to max
string -> Text box to input regex
boolean, or any data type with less than 20 unique values -> QListWidget with checkboxes that lets users pick specific values
Also need some logic to determine which widget to show for step 4 when editing an existing query expression. Also give an option to switch between them if applicable.
Let me know if you disagree or have questions about any of this

Regarding getting variable names into filters more easily, I think just paste is the best option. Drag and drop would be more work to implement and not really much more functional. I can implement copy/paste of single cells from DataFrame header/index cells, I'll do that tonight won't take long.

Between the copy/paste and the PR I just linked, it'll make things easier. Let me know what you think on the autocomplete.

stuff like:
Max Operating Temp (°C)
Output Capacitance (μF)

By the way feel free to add one of those datasets or similar to the pandasgui.datasets if it's not private. Data with weird symbols like that would be good for test cases.


fix(transformer/class-properties): fix symbol clashes in instance prop initializers

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#7872  👈 (View in Graphite)
#7871
#7870
#7869
#7868
#7867
#7866
main

How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.


rename term and add definition

closes #7604
Rename term based on information in GARD. I did not find an OMIM entry other than a gene page. This review article was helpful.

Maybe we need to discuss this issue on a call?

Sure, let's discuss  on a call.

I think this section (subclasses of MONDO:0005372 'male infertility') of Mondo needs to be reviewed in general and suggest any further changes for MONDO:0042605 'Y chromosome infertility due to DAZ1 deletion' be included in this future review. If that's ok with you @sabrinatoro let's close this PR.

@twhetzel I am ok with closing this.
Please, update the original issue with the summary of all our discussions so we remember the discussions we had, why we didn't update the term label, and where the pain points are. Also, please create a new issue to review MONDO:0005372 'male infertility', referring to this issue. Thank you!


moranthomas_181113_105416.760

Type: Incorrect
Summary:
test
Details:
test
Resolution:
test
Affected definitions:

async 2.8.0

You can review the change introduced to the full definition at ClearlyDefined.


Câmpulung La Tisa, Maramureș - is not written correctly

ENVIROMENT: ui.orase
URL: https://peviitor-ro.github.io/ui.orase/
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open URL in browser
Type "Câmpulung La Tisa" in the search bar
Looking after "Câmpulung La Tisa, Maramureș"

EXPECTED RESULTS:
The name of the locality written in the search bar is written correctly based off the law nr. 167/1929
https://legislatie.just.ro/Public/DetaliiDocument/189
ACTUAL RESULTS:
The name of the locality written in the search bar is not written correctly based off the law nr. 167/1929

Fixed. Poti sa retestezi.


add keywords "pma" and "mailhog" to launch command

this allows the ddev launch command to launch PHPMyAdmin and and Mailhog
The Problem/Issue/Bug:
the developer has to type urls for php my admin / mailhog and needs to rember the port numbers of the tools
How this PR Solves The Problem:
with ddev launch there is already a script in place to launch the webbrowser
this patch introduces two "keywords" pma and mailhog which might be used instead of the path
Manual Testing Instructions:
PHPMyAdmin:  ddev launch pma
Mailhog: ddev launch mailhog
regular website: ddev launch
regular website with path: ddev launch some/url
Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think I'd prefer a new command, since "launch" already takes an arg which is the URI.

ddev open maybe?

I vote for ddev mailhog and ddev pma

I worry about adding too many default commands, afraid that people will be overwhelmed by the number of options. I agree that two new custom commands would be a very easy option.

I am with Randy on adding not to many default commands,
but fear its confusing for a user to understand/rember the dfference between ddev launch and ddev open (as both commands) will open the webbrowser. (not s
maybe the way is to integrate both into one command with "clean" syntax. (not overloading parameters)
for example ddev open mailhog|pma|site| [path]
so launch command could be removed in future versions of ddev.  ddev open site home would open https://project.ddev.site/home
this way it would be possible to bundle all calls that open a webbrowser.
what do you think about this suggestion

I find ddev open much more intuitive than ddev launch. Either way wouldn't it still be better to just have one command? ddev open opens project base URL. ddev open /some-dir (note the starting slash) opens project base URL/some-dir. ddev open pma opens project PHPMyAdmin. ddev open mailhog opens project Mailhog.  Or ddev launch of course.

 All committers have signed the CLA.

I think we got lost on this one, but I'm open to various solutions, including opening the web interface of 3rd-party projects like solr.  I don't have any objection to "open" and "launch" being aliases, that's not hard to do. But closing this for now, I certainly have no objection, but we didn't come up with an actionable path.

How about doing it with ddev launch --<service>, for example, ddev launch --phpmyadmin or ddev launch --service=phpmyadmin with single-letter aliases like ddev launch -p ?

I'm going to reopen and retitle this so it doesn't get dropped. I think we can do something that will make us all happy.

Closing this in favor of #2137, which adds -p and -m args to launch. Would appreciate your review over there @wolffc @leymannx @gilbertsoft , and thanks for kicking off this conversation.


use redirect slim 3 with authorization header

how to use redirect sir, i have try but middleware say token not found, thanks for answer.
this the code
return $response->withRedirect('/user/home')->withHeader('Authorization', 'Bearer '.$token);

Not possible. Redirect does not work like that. When a browser sees the Location: /foo/bar header it simply makes a new GET /foo/bar request.

thanks for your answer sir, my idea is , when login  and password  true , system will redirect to home user that use slim-jwt-auth on it . generated the token and save locally  with "localStorage.setItem()".  can this idea happen sir?

Correct. You can store the token to localstorage and then include it it Authorization: Bearer header when doing a request. You could also store the token to a cookie. Good article about the differences and cotchas is Where to Store your JWTs – Cookies vs HTML5 Web Storage.


Can't not interact with node elements

Can't not click in nodes element, this library have keywords to interact nodes? In Scripting Recorder i need "Select node" "Expand node" and "Double click node":

Result, access this page:

Double-click Tree Element   IDoc/Registros de dados/ZSE00_ORD_HEADER

Each segment of the path is matched partially. That is why you do not need the exact IDoc number. I have to add this to the documentation. Don't close the issue yet :)

I just released version 2.13.5 with the updated documentation. Feel free to close the issue if it is solved.

@mardukbp Thanks for return, workly peerfectly.

@mardukbp I reopen but to execute "Double-click Tree Element   IDoc/Registros de dados/ZSE00_ORD_HEADER" i have to expand this item:

I can only execute "Double-click Tree Element   IDoc/Registros de dados/ZSE00_ORD_HEADER" after expand, and a cannot expand using your tips.
Any sugestion?


/auth/steam Not Found

Expected behavior
Actual behavior
Steps to reproduce the behavior
Other

[Operating System]: Ubuntu 140.04

[How did you start the script]: nodejs index

after i launch everything it gives me this
root@TradeItems:/home/trade# nodejs index
Bot (bot_1) has been logged-in.
[!] Website server is online.
[!] Socket server is online.
[!] Prices are updated.
Steam Guard App Code: [FloatChecker:Progress] Starting to acquire floats for bot "bot_1". This can take a while if you have a lot of items.
[FloatChecker:Progress] Done floats for bot "bot_1".
[!] All bots online.
BUT then i still can't sign in since it says not found why ?

Add me on steam and i will help you.
/Id/freddyervild

Disable apache or nginx.

I'm having the same issue, any solutions?

Disable apache or nginx.

One more question.
After authorization, an error occurs

Cannot GET //auth/steam/return

If you delete one extra /, then the authorization is successful, could you tell me how to fix this bug?


Project card thumbnails

We should render the first subject in some manner and show it on project cards in the project selection page as a preview.
This could be rendered dynamically, or we could store a thumbnail the first time the project is visited or the first time it is rendered after any change.
Once this is done, we may want to show the most recent project's thumbnail or preview on the dataset cards.

Resolved with #208


GET data:image/png net::ERR_INVALID_URL

Hello,
Upgrading from Gatsby v1 to Gatsby v2, I keep getting the error GET data:image/png net::ERR_INVALID_URL at react-scroll-up-button/dist/react-scroll-up-button.js:83.
I don't get why I keep getting this error and I'm not able to do anything about it, so I'm asking for your help on this issue.

The code where I use the plugin is the next:
import React from 'react';
import {CircleArrow as ScrollUpButton} from 'react-scroll-up-button';

export default class Article extends React.component{
  render=()=>{
    return(
      <article>
            {/* ... */}
            <ScrollUpButton ContainerClassName="ScrollUpButton__Container" TransitionClassName="ScrollUpButton__Toggled"/>
      </article>
    );
  }
}

And the last weird thing is that even with that error, the button still shows and works fine.
So, any idea on why that happens? Or am I in the wrong thinking it's the problem of the plugin?
Version of Gatsby: v2
Version of react-scroll-up-button: the latest (1.6.4)

This is weird since ive used it one Gatsby v2 myself and that error message makes no sense, this repo doesn't use any images.
Does this happen only in develop mode or after building? or both?

can you reproduce this using one of the gatsby starters?

Hi, sorry about that, I might have been too fast on my judgement. After breaking down each components of my code, happened that it is not from this package, I am sorry I'm closing the issue

Np, I'm glad you were able to figure it out.


add stream interface

closes #104

Coverage decreased (-2.5%) to 96.815% when pulling ce44a8c85ee46dfa36b17d8691f5080d676ebf88 on legomind:feature/add-stream-interface into ab12b806c9ca13ed1008fdee43f13ad7a88a6d85 on crcn:master.

Coverage increased (+0.03%) to 99.363% when pulling 86efb0532eb69ad440ef7a9f745d773fd914c53f on legomind:feature/add-stream-interface into ab12b806c9ca13ed1008fdee43f13ad7a88a6d85 on crcn:master.

Thanks for the contribution! Though, I'm not sure if this feature is a good fit for Sift since it's specific to NodeJS streams, and it also introduces a new dependency into the library. I'm trying to keep sift as minimalistic as possible - any contributions like this are probably better off as separate NPM module.
A quick search yielded this library: https://www.npmjs.com/package/stream-filter. You can probably easily use this utility with sift, like so:
import sift from 'sift';
import _ from 'highland';
import filterThrough from 'stream-filter';

_([
    { name: 'bob' },
    { name: 'borg' },
    { name: 'blab' }
])
.pipe(filterThrough(sift({ name: /^bo/ })))
.on('write', function(chunk) {
    console.log(chunk); // bob, borg
});

Hope this helps.


Investigate generic getters

we created some generic getter patterns for visible and opaque swap views. Investigate if these generic patterns can be employed for other actions. Additionally, add more detailed comments in the getters package to better inform the consumers of those getter functions.

superseded by https://github.com/penumbra-zone/web/pull/1574


README.md Further Edits

some more changes to the readme file for easier contribution in the future.
I hope this will be less confusing for anyone to pick up and go with the project

Based on what @RubyNova has written and my previous comment, as long as that is addressed, I think that this can go through as-is.
Just noting here that we will be slowly transitioning this information over to the wiki - not sure how to handle collaboration on that yet, but will 100% take additional readme edits as it affects what goes into the wiki as well :)


adds embedders as code functionality

as discussed in our roadmap thread, we're going to postpone this feature for some versions

over half a year old


Fix overlay transparency bug

Since Forms cannot have a BackColor of Color.Transparent, the workaround is to have the BackColor and TransparencyKey be the same value instead. I also made this value LightGray since it is noticeable on the edges when set to Magenta, and LightGray lets you still read the text in the Designer view on Visual Studio.
Fixes #3

There is already a feature for this you hit 'T' to toggle through different background colors, and Transparent is one of them.
The magenta/pink is for stream overlays to chroma key out.


Update box-sizing: border-box to new best practice

See:

http://www.paulirish.com/2012/box-sizing-border-box-ftw/
http://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/

box-sizing: border-box is currently implemented like this:
*,
*:before,
*:after {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box; }

Updating the implementation to the following will make it easier to reset box-sizing within components:
html {
  box-sizing: border-box;
}
*, *:before, *:after {
  box-sizing: inherit;
}

Components could simply reset on a parent element and have all their descendants inherit correct box-sizing, something that won't work with the current * { box-sizing: border-box } implementation:
.component {
  box-sizing: content-box;
}

Hopefully this can be implemented, would make things easier for third party components.

@staaky Thanks! We just updated the codebase.


Update the RMSProp optimizer class API docs

This PR updates the RMSProp optimizer class API docs. :

Added a new description: sourced from Alex Graves's 2013 paper and Hinton's lecture from 2012. The latter is said to be the first public mention of the optimizer. The description is pretty much word for word, hope that's ok. Feel free to modify it.
Added a new parameter section with the default values from the class initializer.

Added a definition for the rho param. It was taken from Lasagne lib API docs. (Lasagne was built for Theano.) Another description was used from TF 2.x API docs.
Updated the TODO code comment for rho (it's a 0.9 constant (Hinton) and may be referred by other Greeks in other literature).
Since the default params are in a separate params section now, I removed a sentence in the old description, which recommended which default values to use.

Modified the reference using Graves' reference style from the 2013 paper that followed the first "unpublished" introduction of RMSProp (or rmsprop) ("T. Tieleman and G. Hinton. Lecture 6.5 - rmsprop:..." in 2012).
Added an example code snippet - an image classifier on Cifar-10 adapted from /swift-models/ - with comments (tested in a notebook separately to make sure it works.)

Continuing doing more work on API docs.
TGIF.

All Swift code in tensorflow/swift-apis was automatically formatted via swift-format in https://github.com/tensorflow/swift-apis/pull/711.
Formatting configuration here.
One notable change is that we're now using 2-space indentation, which is consistent with:

Google Swift Style Guide
The Swift standard library style
The style of apple/swift-format

As a result, this pull request now has merge conflicts due to code formatting changes. Please resolve the conflicts if you'd like us to re-review your patch! If you haven't already, please consider installing swift-format so you can auto-format code by yourself in the future!


Performance Enhancement for information_schema."tables"

When we run the code to implement our dremio objects, the following code get run
  select (case when position('.' in table_schema) > 0
          then substring(table_schema, 1, position('.' in table_schema) - 1)
          else table_schema
      end) as table_catalog
      ,table_name
      ,(case when position('.' in table_schema) > 0
          then substring(table_schema, position('.' in table_schema) + 1)
          else 'no_schema'
      end) as table_schema
      ,lower(table_type) as table_type
  from information_schema."tables"
  **where ilike(table_schema, 'Preparation.B2BV.Curated')**
  and table_type <> 'system_table'

The issue is with the where ilike(table_schema, 'Preparation.B2BV.Curated'). By applying a fonction (iLike) on the column, the performance is really bad.  As you can see in the image,

Replacing this ilike with an equality would resolve this issue
where table_schema = 'Preparation.B2BV.Curated'
This would cause dremio to be lightning fast as it should.
Thanks

Thanks for raising the issue! We will be looking into it and get back to you if we have any questions. Thanks once again!

Hi @Alain-Barrette, @ArgusLi,
I totally agree with you, it's far from efficient. But I ended up writing that query that way because there are tricky things concerning character case in dremio.
dremio is case insensitive with metadata (table, column names), but case sensitive with data (equality, like...). And on top of that dbt could issue warnings like : "When searching for a relation, dbt found an approximate match. Instead of guessing which relation to use, dbt will move on. Please delete database.schema.model, or rename it to be less ambiguous.".
So my two cents advice, be very careful with catalog macros. I will be very pleased to help, if needed.
Best regards,
Fabrice

@Alain-Barrette I've started work on this new change. If you look at the associated branch, I have created a new variable dremio:exact_search_enabled which defaults to false. However, if you add the following to your project's dbt_project.yml file, it will enable the variable.
vars:
    dremio:exact_search_enabled: True

Enabling the variable then changes the ilike to a basic equality for the dremio__list_relations_without_caching macro when reflections are also disabled. I've done some basic testing but have not done a full test suite or investigated the consequences of enabling this variable.
Please feel free to try it out and let me know if there are any bugs or anything else that needs to be changed.
Note: Using this branch requires dbt-core 1.4.1.

Thank you @ArgusLi , I have created a ticket on my side to have the team validate this. We will keep you informed of the result.

@ArgusLi : not working when installing dbt-core 1.4.1 with dbt-dremio 1.3.2 on the CLI with Python 3.10.  Could you update PyPi?

@alexcotecbq In order to test this new change, you'll have to clone the repo, switch to the branch 134-performance-enhancement-for-information_schematables and install the local dbt-dremio. Doing dbt --version should then show that dbt-dremio and dbt-core are both at 1.4.1.
We only want to update pypi for each release, and this change will most likely be put into the 1.4 release, which should happen pretty soon, most likely within the month.

(dags) cotea@POR771:~/code/dbt-dags$ dbt run --target qa --select Application.3_Jeux_Donnees.VentesVoyage
18:41:05  Encountered an error:
'_MISSING_TYPE' object has no attribute 'replace_dict'
18:41:05  Traceback (most recent call last):
File "/home/cotea/.virtualenvs/dags/lib/python3.10/site-packages/dbt/main.py", line 135, in main
results, succeeded = handle_and_check(args)
File "/home/cotea/.virtualenvs/dags/lib/python3.10/site-packages/dbt/main.py", line 198, in handle_and_check
task, res = run_from_args(parsed)
File "/home/cotea/.virtualenvs/dags/lib/python3.10/site-packages/dbt/main.py", line 225, in run_from_args
task = parsed.cls.from_args(args=parsed)
File "/home/cotea/.virtualenvs/dags/lib/python3.10/site-packages/dbt/task/base.py", line 186, in from_args
return super().from_args(args)
File "/home/cotea/.virtualenvs/dags/lib/python3.10/site-packages/dbt/task/base.py", line 108, in from_args
config = cls.ConfigType.from_args(args)
File "/home/cotea/.virtualenvs/dags/lib/python3.10/site-packages/dbt/config/runtime.py", line 265, in from_args
return cls.from_parts(
File "/home/cotea/.virtualenvs/dags/lib/python3.10/site-packages/dbt/config/runtime.py", line 84, in from_parts
.replace_dict(_project_quoting_dict(project, profile))
AttributeError: '_MISSING_TYPE' object has no attribute 'replace_dict'

(dags) cotea@POR771:~/code/dbt-dags$ pip list | grep dbt
dbt-core                                 1.3.2
dbt-dremio                               1.4.1
dbt-extractor                            0.4.1

Okay this, is working.

Performance without the change (149 seconds)

(dags) cotea@POR771:~/code/dbt-dags$ dbt compile --target qa
20:25:15  Running with dbt=1.3.2
20:25:15  Unable to do partial parsing because config vars, config profile, or config target have changed
20:25:25  Found 969 models, 20 tests, 0 snapshots, 0 analyses, 331 macros, 0 operations, 0 seed files, 331 sources, 0 exposures, 0 metrics
20:25:25
20:27:33  Concurrency: 100 threads (target='qa')
20:27:33
20:27:44  Done.
Performance with the new change (27 seconds):

(dags) cotea@POR771:~/code/dbt-dags$ dbt compile --target qa
18:56:27  Running with dbt=1.4.1
18:56:29  Found 969 models, 20 tests, 0 snapshots, 0 analyses, 334 macros, 0 operations, 0 seed files, 331 sources, 0 exposures, 0 metrics
18:56:29
18:56:42  Concurrency: 100 threads (target='qa')
18:56:42
18:56:54  Done.

@ArgusLi , This is much much faster now.

@alexcotecbq , Thanks a lot for your implication.


Severe performance penalty on <IP_ADDRESS>

I have a ELK cluster which on 7.10.0 / <IP_ADDRESS>, and during an average day was able to process around 15,000 - 20,000 requests per second from logstash.
Upon upgrading to 7.10.2 / <IP_ADDRESS>, this plummets to 3,000 per second.
Disabling the security plugin via "opendistro_security.disabled: true" in elasticsearch.yml and going over HTTP, the cluster returns to the speeds above.
Additionally when upgrading, I noticed an increase in CPU utilisation across all nodes in the cluster by 15-20% when sitting idle (20 events a second).

Just noticed this: https://github.com/opendistro-for-elasticsearch/security/pull/1061

Fixed with #1061 Please watch out for upcoming release

Can we have a fix quickly because our production env is very instable and we loose a lot of requests ?
Thanks in advance

As of writing the <IP_ADDRESS>-rc2 tag contains some essential fixes.
Its very easy to build the plugin from the source by following instructions in the repos readme.


Plesk cert creation failed

Hello,
i can renew in Plesk 12.5 my Certificates:
Fehler: Fehler bei der Installation des SSL-Zertifikats von Let's Encrypt: Failed letsencrypt execution: 2016-03-19 21:23:27,766:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/blog.cloud-surfer.eu-0001.conf is broken. Skipping.
2016-03-19 21:23:27,779:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/cloud-surfer.eu-0001.conf is broken. Skipping.
2016-03-19 21:23:27,789:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/cloud-surfer.eu-0002.conf is broken. Skipping.
2016-03-19 21:23:27,789:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/webmail.cloud-surfer.eu.conf is broken. Skipping.
2016-03-19 21:23:27,791:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/cloud-surfer.eu.conf is broken. Skipping.
2016-03-19 21:23:27,794:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/h2530151.stratoserver.net.conf is broken. Skipping.
2016-03-19 21:23:27,795:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/cloud-surfer.eu-0003.conf is broken. Skipping.
2016-03-19 21:23:27,805:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/webmail.cloud-surfer.eu-0001.conf is broken. Skipping.
2016-03-19 21:23:27,808:WARNING:letsencrypt.cli:Renewal conf file /opt/psa/var/modules/letsencrypt/etc/renewal/blog.cloud-surfer.eu.conf is broken. Skipping.
2016-03-19 21:23:33,347:WARNING:letsencrypt.client:Non-standard path(s), might not work with crontab installed by your operating system package manager
An unexpected error occurred:
OSError: [Errno 13] Permission denied: '/opt/psa/var/modules/letsencrypt/etc/live/cloud-surfer.eu-0004'
Please see the logfiles in /opt/psa/var/modules/letsencrypt/logs for more details.

Can anyone help me?
manual it works but i think thats not the solution.

We significantly reworked the codebase in the extension version 2.0
Similar issues should have gone away.
Try the latest version and feel free to reopen the issue if occurs.


[QUESTION] - Which data is available in general?

Hi,
everything is working as desired. Thanks for your great support.
I have a question anyway, what data is available in general, e.x. power on each phase, etc.?
Thanks for your help.
André

It's listed in the README:
    Voltage L1
    Voltage L2
    Voltage L3
    Amperage L1
    Amperage L2
    Amperage L3
    Active Power Plus
    Active Power Minus
    Active Energy Plus
    Active Energy Minus
    Reactive Energy Plus
    Reactive Energy Minus

Thank you! And how do i disable mqtt?

Remove the following sections from your config:
mqtt:
  broker: <IP_ADDRESS>
  id: mqtt_broker

and
dlms_meter->enable_mqtt(id(mqtt_broker), "meter01/data"); # Enable grouped together MQTT report, useful to get exact time with each data for storing results in InfluxDB

Please note that without MQTT your data will not be grouped together so all sensors are updated individually at the time they are processed.

Sadly, no - doesn't let me upload the firmware then:
Processing smartmeter (board: esp32dev; framework: arduino; platform: platformio/espressif32 @ 3.5.0)
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
Dependency Graph
|--  1.0
|--  1.0
|--  1.0
Compiling /data/smartmeter/.pioenvs/smartmeter/src/esphome-dlms-meter/espdm.cpp.o
Compiling /data/smartmeter/.pioenvs/smartmeter/src/esphome/components/api/api_connection.cpp.o
Compiling /data/smartmeter/.pioenvs/smartmeter/src/esphome/components/api/api_frame_helper.cpp.o
Compiling /data/smartmeter/.pioenvs/smartmeter/src/esphome/components/api/api_pb2.cpp.o
Compiling /data/smartmeter/.pioenvs/smartmeter/src/esphome/components/api/api_pb2_service.cpp.o
In file included from src/esphome-dlms-meter/espdm.cpp:1:0:
src/esphome-dlms-meter/espdm.h:27:34: error: 'mqtt' has not been declared
void enable_mqtt(mqtt::MQTTClientComponent *mqtt_client, const char topic);
^
src/esphome-dlms-meter/espdm.h:27:60: error: expected ',' or '...' before '' token
void enable_mqtt(mqtt::MQTTClientComponent *mqtt_client, const char *topic);
^
src/esphome-dlms-meter/espdm.h:64:17: error: 'mqtt' does not name a type
mqtt::MQTTClientComponent *mqtt_client = NULL;
^
src/esphome-dlms-meter/espdm.cpp: In member function 'virtual void esphome::espdm::DlmsMeter::loop()':
src/esphome-dlms-meter/espdm.cpp:331:26: error: 'class esphome::espdm::DlmsMeter' has no member named 'mqtt_client'
if(this->mqtt_client != NULL)
^
src/esphome-dlms-meter/espdm.cpp:333:27: error: 'class esphome::espdm::DlmsMeter' has no member named 'mqtt_client'
this->mqtt_client->publish_json(topic, [=](JsonObject root)
^
src/esphome-dlms-meter/espdm.cpp:333:64: error: 'JsonObject' has not been declared
this->mqtt_client->publish_json(topic, [=](JsonObject root)
^
src/esphome-dlms-meter/espdm.cpp: In lambda function:
src/esphome-dlms-meter/espdm.cpp:337:48: error: assignment of read-only location '"voltage_l1"[root]'
root["voltage_l1"] = this->voltage_l1->state;
^
src/esphome-dlms-meter/espdm.cpp:338:48: error: assignment of read-only location '"voltage_l2"[root]'
root["voltage_l2"] = this->voltage_l2->state;
^
src/esphome-dlms-meter/espdm.cpp:339:48: error: assignment of read-only location '"voltage_l3"[root]'
root["voltage_l3"] = this->voltage_l3->state;
^
src/esphome-dlms-meter/espdm.cpp:344:48: error: assignment of read-only location '"current_l1"[root]'
root["current_l1"] = this->current_l1->state;
^
src/esphome-dlms-meter/espdm.cpp:345:48: error: assignment of read-only location '"current_l2"[root]'
root["current_l2"] = this->current_l2->state;
^
src/esphome-dlms-meter/espdm.cpp:346:48: error: assignment of read-only location '"current_l3"[root]'
root["current_l3"] = this->current_l3->state;
^
src/esphome-dlms-meter/espdm.cpp:351:55: error: assignment of read-only location '"active_power_plus"[root]'
root["active_power_plus"] = this->active_power_plus->state;
^
src/esphome-dlms-meter/espdm.cpp:352:56: error: assignment of read-only location '"active_power_minus"[root]'
root["active_power_minus"] = this->active_power_minus->state;
^
src/esphome-dlms-meter/espdm.cpp:357:56: error: assignment of read-only location '"active_energy_plus"[root]'
root["active_energy_plus"] = this->active_energy_plus->state;
^
src/esphome-dlms-meter/espdm.cpp:358:57: error: assignment of read-only location '"active_energy_minus"[root]'
root["active_energy_minus"] = this->active_energy_minus->state;
^
src/esphome-dlms-meter/espdm.cpp:363:58: error: assignment of read-only location '"reactive_energy_plus"[root]'
root["reactive_energy_plus"] = this->reactive_energy_plus->state;
^
src/esphome-dlms-meter/espdm.cpp:364:59: error: assignment of read-only location '"reactive_energy_minus"[root]'
root["reactive_energy_minus"] = this->reactive_energy_minus->state;
^
src/esphome-dlms-meter/espdm.cpp:369:47: error: assignment of read-only location '"timestamp"[root]'
root["timestamp"] = this->timestamp->state;
^
src/esphome-dlms-meter/espdm.cpp:369:47: error: cannot convert 'std::__cxx11::string {aka std::__cxx11::basic_string}' to 'const char' in assignment
src/esphome-dlms-meter/espdm.cpp: At global scope:
src/esphome-dlms-meter/espdm.cpp:434:37: error: variable or field 'enable_mqtt' declared void
void DlmsMeter::enable_mqtt(mqtt::MQTTClientComponent *mqtt_client, const char *topic)
^
src/esphome-dlms-meter/espdm.cpp:434:37: error: 'mqtt' has not been declared
src/esphome-dlms-meter/espdm.cpp:434:64: error: 'mqtt_client' was not declared in this scope
void DlmsMeter::enable_mqtt(mqtt::MQTTClientComponent *mqtt_client, const char *topic)
^
src/esphome-dlms-meter/espdm.cpp:434:77: error: expected primary-expression before 'const'
void DlmsMeter::enable_mqtt(mqtt::MQTTClientComponent *mqtt_client, const char *topic)
^
Compiling /data/smartmeter/.pioenvs/smartmeter/src/esphome/components/api/api_server.cpp.o
*** [/data/smartmeter/.pioenvs/smartmeter/src/esphome-dlms-meter/espdm.cpp.o] Error 1
========================== [FAILED] Took 3.01 seconds ==========================

Nope - as broker is needed for completed syntax...

if i just add:
mqtt:
broker: ''
the it works but is throwing logs that it cannot reach the broker (logischerweise :)).
Ideal would be an option do disable either mqtt or the esphome sensors in general as both are created...


Animation to cards on landing page

🚀 Feature
The cards which represent music box,The band, piano....I would like to add the flip card animation to it.
Please assign me under lgmsoc.

/assign

I am working on it.


Make AssetLoader/Saver Error type bounds compatible with anyhow::Error

Objective

In Bevy 0.11 asset loaders used anyhow::Error for returning errors. In Bevy 0.12 AssetLoader (and AssetSaver) have associated Error type. Unfortunately it's type bounds does not allow anyhow::Error to be used despite migration guide claiming otherwise. This makes migration to 0.12 more challenging. Solve this by changing type bounds for associated Error type.
Fix #10350

Solution
Change associated Error type bounds to require Into<Box<dyn std::error::Error + Send + Sync + 'static>> to be implemented instead of std::error::Error + Send + Sync + 'static. Both anyhow::Error and errors generated by thiserror seems to be fine with such type bound.

Changelog
Fixed

Fixed compatibility with anyhow::Error in AssetLoader and AssetSaver associated Error type

Code below compiles so I assume it is compatible with pretty much all error types. It would be nice if we could get this change into Bevy 0.12.1 to make migration from 0.11 easier.
trait MyTrait {
    type Error: Into<Box<dyn std::error::Error + Send + Sync + 'static>>;
}

#[derive(Error, Debug)]
pub enum ThisErrorError {
    #[error("Foo")]
    _Foo,
}

#[derive(Debug)]
struct CustomError;
impl std::error::Error for CustomError {}
impl std::fmt::Display for CustomError {
    fn fmt(&self, _f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        todo!()
    }
}

struct MyStructWithAnyhowError;
impl MyTrait for MyStructWithAnyhowError {
    type Error = anyhow::Error;
}

struct MyStructWithThiserrorError;
impl MyTrait for MyStructWithThiserrorError {
    type Error = ThisErrorError;
}

struct MyStructWithCustomError;
impl MyTrait for MyStructWithCustomError {
    type Error = CustomError;
}

I'm not sure I understand this comment:

I also stepped onto this problem. I wanted to use Box<dyn std::error::Error + Send + Sync> as mentioned above but it does not work because T must be Sized for Box<T> to implement std::error::Error which is a little non-intuitive.

What are the implications for this PR?

I'm not sure I understand this comment:

I also stepped onto this problem. I wanted to use Box<dyn std::error::Error + Send + Sync> as mentioned above but it does not work because T must be Sized for Box<T> to implement std::error::Error which is a little non-intuitive.

What are the implications for this PR?

I wrote this comment before preparing this PR and it is not directly related. It was about workaround proposed in #10350 that does not work (it did not involve anyhow::Error at all). I was trying to understand why it does not work and described my findings.

Yeah then I think we can include it in 0.12.1.


[Feature] Secret Page Improvement

Add some color theme options to the secret page to enhance its appearance.

program name?

codepeak


Final Message/Will usage

Is there any good documentation on how this 'will' message is utilized?  Can this be used to properly shut-down a connection server-side if a MQTT client disconnects (e.g. during a reboot)?  I'm running into a weird issue that when the client abruptly ends, the server does not realize the disconnect.  It could be due to using nginx and proxying the connection, but am unsure yet.

For more information about usage of MQTT please visit "https://www.hivemq.com/blog/how-to-get-started-with-mqtt". This library only implements the standard and provides no documentation of the basics.


Write tests for shard context

What changed?
Wrote tests for some part of history/shard/context.go

Why?
Improve coverage

Pull Request Test Coverage Report for Build 018fe4bc-3b62-4bdb-b2eb-3f37bf730fab
Details

0 of 0   changed or added relevant lines in 0 files are covered.
46 unchanged lines in 12 files lost coverage.
Overall coverage increased (+0.02%) to 70.215%

Files with Coverage Reduction
New Missed Lines
%

common/task/weighted_round_robin_task_scheduler.go
2
88.56%

service/matching/tasklist/db.go
2
73.23%

common/task/fifo_task_scheduler.go
2
80.41%

common/membership/hashring.go
2
84.69%

common/persistence/historyManager.go
2
66.67%

common/log/tag/tags.go
3
50.46%

common/persistence/nosql/nosql_task_store.go
3
85.52%

common/types/history.go
4
45.35%

service/history/engine/engineimpl/record_activity_task_started.go
4
68.87%

service/frontend/api/handler.go
4
65.45%

Totals

Change from base Build 018fe451-cd64-44f5-8cb8-8b9c6b71f4ba:
0.02%

Covered Lines:
104585

Relevant Lines:
148950

💛  - Coveralls


feat: Onboard EPA historical air quality dataset

Description
Included:
Annual summaries
CO Daily Summary
CO Hourly Summary
HAP Daily Summary
HAP Hourly Summary
Lead Daily Summary
NO2 Daily Summary
NO2 Hourly Summary
NONOxNOy Daily Summary
NONOxNOy Hourly Summary
Ozone Daily Summary
Ozone Hourly Summary
PM 10 Daily Summary
PM10 Hourly Summary
PM25 Frm Hourly Summary
PM25 NonFrm Daily Summary
PM25 NonFrm Hourly Summary
PM25 Speciation Daily Summary
PM25 Speciation Hourly Summary
Pressure Daily Summary
Pressure Hourly Summary
RH and DP Daily Summary
RH and DP Hourly Summary
SO2 Daily Summary
SO2 Hourly Summary
Temperature Daily Summary
Temperature Hourly Summary
VOC Daily Summary
VOC Hourly Summary
Wind Daily Summary
Wind Hourly Summary
Checklist
Note: Delete items below that aren't applicable to your pull request.

[x] Please merge this PR for me once it is approved.
[x] If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
[x] If this PR adds or edits a dataset or pipeline, I put all my code inside  datasets/epa_historical_air_quality and nothing outside of that directory.
[x] This PR is appropriately labeled.

@adlersantos Ready for review.  Thanks!

@adlersantos I have done research into trying to understand why this PR keeps failing at the Run Tests point.  Is there some recent change to the code behind these checks?  What changes do I need to make to ensure that these checks pass? Thanks!

@adlersantos I dont see any button in github UI that allows me to rerun the checks without making code changes, so I had to close and reopen the PR in order to trigger the tests.  If you know a better way to re-trigger the checks, or if closing and re-opening the PR is acceptable then please let me know.

@adlersantos Please review this code at your earliest convenience.  Thanks!

@adlersantos I have made the changes.  Please review.  Thanks.

@adlersantos All requested changes are completed.  Please review again.  Thanks!


critical bug

on this  line vim call GetEnvironmentStringsW()
on this line vim free it with FreeEnvironmentStringsA()
This is 99% likely to crash the [G]VIM process on old operating systems (the new ones apparently have foolproof protection)
proofs:

how to reproduce:

get winxp-compatible (or path target os to 5) winpty-agent.exe
run vim on winxp sp3
:terminal cmd
see critical error (99.9% chance)

moreover, the critical failure does not occur in VIM when an incorrect function is called, but deep in the bowels of the system core...

ps. patch for winpty-agent.exe (in vim dist)
FC /B winpty-agent.exe winpty-agent-patch.exe
00000138: 06 05
00000140: 06 05

I am not sure if this is critical or not, but the Microsoft documentation https://learn.microsoft.com/en-us/windows/win32/procthread/changing-environment-variables make it sound like one needs to free the returned block, if one no-longer needs it

It is even literally written in the Microsoft documentation of this function that it has to be freed:

When the block returned by GetEnvironmentStrings is no longer needed, it should be freed by calling the FreeEnvironmentStrings function.

However, the Microsoft documentation also says:

If you used the ANSI version of GetEnvironmentStrings, be sure to use the ANSI version of FreeEnvironmentStrings. Similarly, if you used the Unicode version of GetEnvironmentStrings, be sure to use the Unicode version of FreeEnvironmentStrings.

Therefore, since GetEnvironmentStringsW is used here, I think FreeEnvironmentStringsW should be used here.

I've created #13096.


Add QSV encoders support

A simple arg adding to support QSV encoders.
Maybe it would also be better to enable lookahead by default with HandBrake's default paramenters
(-look_ahead 1 -lookahead-depth 40)
https://handbrake.fr/docs/en/latest/technical/video-qsv.html

Looks good thanks!

Maybe it would also be better to enable lookahead by default with HandBrake's default paramenters (-look_ahead 1 -lookahead-depth 40) https://handbrake.fr/docs/en/latest/technical/video-qsv.html

This could be added in a similar way we set -b:v only for vp9 & aom (https://github.com/alexheretic/ab-av1/blob/ee9a586afb5c0a768e6f5f2ca2981ee867bcffa7/src/command/args/encode.rs#L250..L256)

Maybe it would also be better to enable lookahead by default with HandBrake's default paramenters (-look_ahead 1 -lookahead-depth 40) https://handbrake.fr/docs/en/latest/technical/video-qsv.html

Sorry actually in that page HandBrake used the arg lookahead-depth but for ffmpeg is look_ahead_depth


Does redux feel overwhelming? Or it's just me?

I've learnt this framework, got comfortable working with ngrx. But each time I need to create a new page - I feel overwhelmed by the amount of boilerplate code just to setup it. Lets start with a simple comparison:
Doing it without redux, I need Service and Component only. It could be expressed as Service->Component->Template. Same as in .NET MVC pattern: Model->Controller->View. The difference is that .NET MVC is stateless server side app.
However when doing redux, in addition to Service and Component, you have to do: Actions, Effects, Reducers, Smart/Dumb Components, update global AppState, register all these in barrels, inject Actions & Stores a lot. I would say, I need to do x4 more work to achieve same result. In most cases all these classes look very similar among different features: load data by id, update loaded model.
Application itself feels like a lot of unrelating pages, that don't share any state, just passing ids around to navigate to another page. Can you give some examples what is good app to use redux and what type of apps should not be using it?
I have found this statement in reactjs/redux documentation. You’ll know when you need Flux. If you aren’t sure if you need it, you don’t need it. Does it give answer to my question?

I think it depends on the complexity of solution you're trying to solve.
When I started our designing my SAAS-platform, I came from a .Net MVC background. I went with the stateless "MVC for the client"-architecture using AngularJS 1.x with an event-driven service-communication. Which worked really well at first. It's all very simple and I was really productive.
But in time, with customer demands of more features and better performance on both client and server, I starting moving more logic and caching to the client which made the client more and more stateful.  Managing the client state became increasingly difficult, and I was basically on my way to building a homemade redux store. I'm now using the ngrx/store as a replacement of what I was building on my own. :)
My solution and recommendation is to keep using your services (business layer), and have them basically work as wrappers for your store (data layer). At least for me that means I can abstract away the boilerplate to a few services that components (view layer) imports.

I agree with @bialad

I think it depends on the complexity of solution you're trying to solve.

If most of your states is just internal (component scoped) ui view usage states, then it is not necessary to use redux/@ngrx-store. But when your component states will have effect on other component states, and there are external events (from server) need to be handled by some components. It is very easy to misuse Angular JS 1.x mechanism either through services or scope boardcast/listener. Then you have to program one event handler with other event handler in services/components...
By using redux methodology, we have to create Actions, Effects and Reducers. We separate each event handler by themselves and only think about each action(event) lead to which effect and what is the next state(only related to this action) should be. We scope the context limited in this way. There is a global app state, but we do not need to think about the whole state all the time, we just need to think about part of the state how it should be changed by action(event), that's it.
I understand it is overwhelming, and many boilerplate code to use redux/@ngrx-store, but it helps me to think/code in a better way.
That is just my opinion.


Respect $KUBECONFIG

I had a very difficult time getting this tool to work. I kept getting this sort of error:
Error creating QueryExecutor instance: failed to create config: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x30 pc=0x10563f870]

goroutine 1 [running]:
main.getCurrentContextFromConfig()
        /Users/josh/dev/go/pkg/mod/github.com/avitaltamir/cyphernetes@v0.11.2/cmd/cyphernetes/shell.go:88 +0x200
main.getCurrentContext(...)
        /Users/josh/dev/go/pkg/mod/github.com/avitaltamir/cyphernetes@v0.11.2/cmd/cyphernetes/shell.go:73
main.init.3()
        /Users/josh/dev/go/pkg/mod/github.com/avitaltamir/cyphernetes@v0.11.2/cmd/cyphernetes/shell.go:567 +0x248

Based on the error message, I manually exported KUBERNETES_MASTER to my cluster's API server, but I continued to get errors.
Eventually I checked the contents of my ~/.kube/config file, and it was "emtpy":
apiVersion: v1
clusters: null
contexts: null
current-context: ""
kind: Config
preferences: {}
users: null

This is because I use a different file for each cluster that I'm interested in connecting to and set $KUBECONFIG to the appropriate path. It pairs well with direnv, automatically changing the context based on the project I'm working on. I have taken for granted the fact that most Kubernetes tooling respects the $KUBECONFIG environment variable.
In order to actually use cyphernetes, I symlinked my config file:
ln -sf $KUBECONFIG ~/.kube/config

After doing this, I was finally able to use the tool! It seems very cool.
I think it would be useful to check that environment variable in case others use k8s tooling the same way I do.

@codekoala thanks for reporting!
Will add this.


[WIP] repo: Update dev/build/deploy README

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>

current README rendering is here https://github.com/envoyproxy/envoy-website/blob/cc37e2d1891d71c816b827eff2a4923c98fa97fb/README.md


Update class-factory.blade.php view

Hello!
I have modified the class factory view to include some configurations on it.
Thanks!

Hello @TheDoctor0 !
Yes, I think it would be useful :)
Thanks for your response!

@alibori I just tagged a 1.3.0 release that includes a customizable factory template.

Hello @TheDoctor0 !
Perfect, that's great.
Thanks a lot!