Change HTTP E2 extension to make HTTP requests clientside

We already discussed that a lot in other issues, and I believe we all came to the conclusion we need to make that.
Pros:

Increased security for servers
HTTP extension can remain enabled by default without breaking any existing e2's

Cons:

It will take a little longer to make a request because of 2 transfers added

If nobody is willing to make it, then I will, it just will take time cuz I don't have much of it.

I would do it if my data stream library was implemented. https://github.com/garrynewman/garrysmod/pull/941

@thegrb93 please can you add me on Steam? Thanks.

@AbigailBuccaneer I did, I'm http://steamcommunity.com/profiles/76561197981780453/

:+1:


Possible issue with more than one instance connected via sentinel

Hey, is this possible that declaring two redis instances like that doesn't work correctly (one configuration is ignored):
var redis1 = new Redis({
  sentinels: [{ host: 'ip1', port: 26379 }, { host: 'ip2', port: 26379 }, { host: 'ip3', port: 26379 }],
  name: 'mymaster-1'
});

var redis2 = new Redis({
  sentinels: [{ host: 'ip1', port: 26379 }, { host: 'ip2', port: 26379 }, { host: 'ip3', port: 26379 }],
  name: 'mymaster-2'
});

Note that only difference is the name (i.e. both instances are running on the same machines).

Forget this one.


thunderbird: enable official branding

as was done for firefox in ce08581088897860dd3b7b510f30b093095592f3
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@sylvestre: I think we would better get explicit permission for Thunderbird as well.

Would it be possible to decrease a bit the list of specific configure option?
Like  --disable-pulseaudio, nss, nspr, necko-wifi, disable-tests?

OK! I'll open a separate pull request that removes --disable-pulseaudio, --disable-necko-wifi, and --disable-alsa, test that, and ask you to re-evaluate when it gets merged.
On --with-system-nss: it would be preferable to leave it as is because we apply some patches on top of NSS. Generally, NixOS uses system libraries and not ones that are bundled with the program.

please keep disable-alsa.
In general, please do like Firefox on Debian is doing (including using nss).
I know distro like to use system libraries (I am a debian developer myself) but we (Mozilla) prefer to have the exact library... especially with security libs like nss.

please keep disable-alsa.

ALSA is off by default, so the switch has no effect. Excerpt from mozilla/old-configure.in found in the release tarball:
MOZ_ARG_ENABLE_BOOL(alsa,
[  --enable-alsa          Enable Alsa support],
   MOZ_ALSA=1,
   MOZ_ALSA=)

if test -n "$MOZ_ALSA"; then
    PKG_CHECK_MODULES(MOZ_ALSA, alsa, ,
         [echo "$MOZ_ALSA_PKG_ERRORS"
          AC_MSG_ERROR([Need alsa for audio output on Linux. (On Ubuntu, you might try installing the package libasound2-dev.)])])
fi

AC_SUBST(MOZ_ALSA)

In general, please do like Firefox on Debian is doing (including using nss).

My idea was to base flags on mozconfig found in Thunderbird packages on Debian and Fedora. I will also check mozconfig for Firefox on Debian :-)

I know distro like to use system libraries (I am a debian developer myself) but we (Mozilla) prefer to have the exact library... especially with security libs like nss.

We have the following out-of-tree patch for NSS: https://github.com/NixOS/nixpkgs/blob/18.03/pkgs/development/libraries/nss/85_security_load.patch
As I understand, this patch fixes CA root certificate discovery on NixOS. We carry that patch at least from 2011, so it seems it's not upstreamable. It would be hard to keep up with patching and rebasing for every app whenever NSS bundled with it is bumped.
It makes sense to bundle all libraries on Debian, where stable packages may be dated, but NixOS is a bleeding-edge distro. Security-related updates are strongly prioritized. And if we update NSS system-wide, all Gecko-based applications can benefit from this, and we don't have to go and bump every and each one of them (which is also error-prone, and depends on upstream cutting a new release).
And in Firefox package (now with official branding, thanks to you!) we also use system NSS and NSPR, the only Firefox-based browser exempt from this is Tor, because they have out-of-tree patches to it: https://github.com/NixOS/nixpkgs/blob/18.03/pkgs/applications/networking/browsers/firefox/common.nix#L160

Thunderbird might need to play sound on certain actions (sending mail, archiving, receiving new mail). There are addons that add more sounds, like ToneQuilla.
PulseAudio is the configuration supported by upstream.

Superseded by #55026.


Updated tomcat9 SOURCE_URL to version 9.0.58

Problem

Installating Apache Guacamole results in ERROR 404 due to tomcat9 no longer exist on the server

Solution

Updated SOURCE_URL to the latest available version on the server and updated the SHA256 checksum

PR Status

[  ] Code finished and ready to be reviewed/tested
[ Y ] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Duplicate of #22


Fix issue with start pos on insertions

Thanks @ckandoth for solving this.
@angelicaochoa could you review?

This PR handles cases where the ref allele is an empty string (like VCF insertion events), which is handled by decrementing the given start position by 1 before trying to annotate the variant.


Update artifacts to release candidates built with tags

Very similar to the last update, but these bundles were built using the tagged version of the subcomponents.
Step 17 of https://github.com/confidential-containers/confidential-containers/issues/111

/test

/test-tdx

I am re-running TDX CLH.

I am re-running TDX CLH.

And it's green now.

"s390x requeue has also failed on the 3rd test again. I'll try again, but I don't think we should let it hold us up as if we can pull and verify signed and encrypted images, then unsigned and unencrypted should be okay too!", from Steven on https://cloud-native.slack.com/archives/C039JSH0807/p1689962125719039?thread_ts=1689257407.179079&cid=C039JSH0807
Merging then.


Doesnt work for me

I get that error and it closes automatically

I did pip install IPython and it still gives me this error

hello im also currently getting the same issue even after install IPython has there been a fix?

Hi, nope, still doesn't work for me. Please let me know if you find out a way to fix it.

@alien18075 and @Nozmic u can try https://github.com/lufy20106/PokeGrinder-V2

I got this error when the captcha appeared (then I had to solve it myself) and can you help me fix it? I am using version 1.2

I got this error when the captcha appeared (then I had to solve it myself) and can you help me fix it? I am using version 1.2

v1.2 is dead
use release or mine: PokeGrinder-V2(python)

I got this error when the captcha appeared (then I had to solve it myself) and can you help me fix it? I am using version 1.2

v1.2 is dead use release or mine: PokeGrinder-V2(python)

i am using your v2 version and sometimes it gives error like this and stops catching pokemon, can you fix it


Deps

Use dep to keep track of walrus' dependencies.

https://github.com/fjukstad/walrus/tree/dep


Rep/Leads Privileges

Overview
I forgot that rep/leads need to be considered when it comes to event creation and committee creation/updates.
Previously reps/leads will simply be given a monthly qrcode by their respective officer to give out for meetings.
However since each event requires a unique qrcode officer will need to create their rep and lead's event and give out the QRCode. This might result in a lot of micromanagement and work for officers.
Solutions?

Give Reps/Leads same power as offciers (for simplicity sake)
Give Reps/Leads view-only privileges so they can view the QRCode, but officers will still need to create the event
Do nothing and officer will have to manually give their reps/leads QRCodes
Give Reps/lead some power (not recommended, wont be worth it making things more complicated for this issue)

temp solution: giving all lead/rep power


Could HNSW and SW-grap support incremental indexing?

As I know, the indexing process of HNSW and SW-grap algorithm is rather expensive. When we want to add new data to HNSW/SW-grap (this case may be more frequently), we must rebuild indexing which is time consuming.
So If HNSW and SW-grap can support incremental indexing, it may be more attractive efficient.
(  It is worth mentioning that the features of index save/load is very useful. )

Hi, yes we have it in plans, see issue #73 . However, it will require a lot of changes to the library, so I don't know when it'll be done.

Currently, there is an experimental support for incremental addition and/or deletion (all should be done in batches), but it requires using C++ directly.


Typescript: tap returns promise, errors in runEffects

runEffects expects a stream, and tap returns a promise, therefore types don't match although they're meant for each other.

Hi @janat08.  Here is the TS type of tap, which returns a stream.  Here is the implementation of tap.  It returns a Tap, which implements the Stream interface.
Can you please provide a TS code sandbox or complete example code that reproduces the issue you're seeing?  Thanks!

https://codesandbox.io/s/r07qyv4n3p?fontsize=14
I believe it's suppose to install the packages itself, according to the documentation.

Thanks for creating a codesandbox 👍   That helps a lot.
The issue in the example is not that tap returns a Promise.  The type error is indicating that this line isn't using the @most/core API correctly:
      until(events, runEffects(tapped, newDefaultScheduler()));

That's a good thing!  It's an opportunity to learn from the types.  I hope you'll bear with me, as we dig in a bit.
If you hover over tapped, you'll see that it's type is MostStream<any>, so it's a @most/core stream.  If you look at the type of runEffects, you'll find that it returns a Promise.  And finally, if you look at the type of until, you'll see that it accepts 2 Streams.  So, we can refactor the line above by extracting a variable, it makes the types easier to see:
   const promise: Promise<void> = runEffects(tapped, newDefaultScheduler())
   until(events, promise)

So, those types clearly don't line up: until expects a stream, so we can't pass a promise to it.
I'll say a few words about @most/core's general philosophy and mechanics, a few things about combinators, such as tap and until, and finally a bit about runEffects.  I'd also suggest taking a look at some examples, to get a feel for these things.
Philosophy and mechanics
@most/core streams are inert until observed with runEffects.  You program with them by using declarative API functions like map, until, merge etc. to build a big "machine" that will do what you need.  The goal is to end up with a single stream that represents the whole computation over time that you need.
runEffects
After you've built the machine, that is, a big graph of streams, now represented by a single, final stream, you unleash it by calling runEffects with a Scheduler that provides the shared notion of time for the whole graph.
In the usual case, there should be exactly 1 call to runEffects as the last function call.  Build up declaratively, then finally, activate.  So, if you find yourself reaching for runEffects at various places, that's probably a sign that you're fighting the architecture rather than working with it.
This can be a different way of thinking, and one may wonder if it's possible to build anything real in this way.  Here's TodoMVC built in exactly this way.  Again, it can be a different way of approaching problems and solutions, but it can be quite pleasant and effective once you get the hang of it.
I hope that helps.  Again, I think it will be helpful to read some of the simple examples and the TodoMVC example.

Well I take issue with runEffects returning promise, it may as well just return never().

or frompromise if it actually tries to resolve things first.

If you're building a widget or something the machine may have to stop prematurely before browser trashes everything.

I respect that you disagree with the philosophy.  You're certainly free to, and to use other libraries.  If you decide to invest time in learning the benefits of the architecture, we'll be here to help.
I'll close this, since the the original issue was the perception that tap returns a promise, and we've seen that it returns a stream.

The github or docs themselves advertise using runeffects with until.

I assume that it's only a type mistmach, with it working as expected?

or rather advertise using it with run.


correct the Markdown format in the documentation.

I noticed some display issues in the documentation, so I've adjusted the Markdown format accordingly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Enhancement: leverage --dry-run option for op item create when using --dry-run in python

This PR enhances the features introduced in #32 by using the --dry-run option for op item create when a person runs this script with --dry-run selected.
This means the dry-run should better represent the item creation behaviour when they run the script not on a dry-run.

[x] Modify create_item() to receive options and set up conditional to use op item create...--dry-run
[x] refactor the stats var to count results of dry run for items.
[x] test

Jack to review.
Currently some discussion about the merit of this PR:
Thoughts

Slow because --dry-run with op makes a round-trip to 1Password's servers

Upsides

This will more accurately provide the user with insight as to how long the script will take to run, which could be rather long. That's valuable information. Could be misleading since a dry-run as currently implemented takes seconds, when an actual import could take hours.
Other upside: Allows the script to provide more accurate feedback about items that cannot be imported (without this, a dry run could only tell a user about items the script itself would fail to implement. There may be items that the script will parse but which op might fail to create for some reason.
Other other upside: Slightly better stats since we can more correctly count successes and failures.

Possible alternative
At the risk of considerably increasing code complexity, we could have a --dry-run, which runs as is, never passing any commands to op and not using the --dry-run option for op item create.
We could have a second flag like --damp-run (h/t to Jack for inspiring the flag name) that would behave as this PR would.
This gives users the flexibility to do either option. IMO the complexity this introduces may outweigh the performance. I think I'd prefer to land on a single behaviour for --dry-run.

I am going to close this PR in anticipation of the LastPass Migration script moving into "deprecated" status.
The LastPass migration scripts will be transitioning to a deprecated state shortly and will no longer receive updates or improvements. The functionality of these scripts is superseded by the LastPass migrator built into 1Password 8 for macOS, Windows, and Linux. This feature of the 1Password apps provides an easier, more complete, and more secure transfer of data.
The LastPass Migration scripts will remain in the repo for the foreseeable future as a proof-of-concept and an example of what the 1Password CLI is capable of.
Cheers,
Scott


Add unit capabilities to Math

So 17K becomes 17,000 and not 17.

Can this be an option for vlookup as well? Add a unit parameter and then convert the result after vlookup before posting...

Added unit= to PU(math) and PU(vlookup). Pushed to GitHub, added to ChromeStore version 1.55.


Supporting locale variants

is this repo still maintained or abandoned?

@MoshDev  Yes, it still.
Thank you for your PR


Allow user managed webhook

If a user created the github token without hook permission, and he would like to manage the web hook, the plugin should not try to create a hook.
Currently the plugin will still keep on doing the check and try creating the hook:
Jan 08, 2018 5:49:49 AM org.jenkinsci.plugins.ghprb.GhprbRepository createHook
SEVERE: Could not create web hook for repository foo/bar. Does the user (from global configuration) have admin rights to the repository?

A simple call graph is :
start->createHook->hookExist->ghRepository.createHook
Actually if user would manage the hook, there's also no value in checking 'hookExist' every time.
Can we have an option to allow user managed webhook?

@karataliu there is a global setting Auto-manage webhooks. If you deactivate this (default is true), the plugin will use webhooks for triggering but will not try to create them. This should do the trick for you :)

test this please


Add docker and podman icons

Adds icons for docker and podman from https://simpleicons.org

Couldn't find a podman dark icon. Maybe we want to hold on merging this?


A few loadmat variable_names issues

Currently, passing an empty list as variable_names to loadmat results in loading all variables rather than none of them.  The issue (probably?) has a simple fix, which is to replace if variable_names by if variable_names is not None in mio5.py.
I think passing a non-existent name as variable_names to loadmat should result in a Value/KeyError, rather than being ignored silently.
I think passing a single name (not a list containing a single name) as variable_names should result in the return value being that single array, rather than a dict.  This seems much more practical, as I expect most users who care about variable_names to be doing loadmat(foo, variable_names="bar")["bar"] anyways.  Yes, I know this is backwards-incompatible.

Care to submit a patch for the first issue?


Add extra contributing steps and move steps to separate file

Added extra steps to contributing a container and moved it to a separate file contributing.md.

related to #269

Codecov Report

Merging #275 (a298c5d) into master (29629e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   86.73%   86.73%
=======================================
  Files          29       29
  Lines         814      814
  Branches       57       57
=======================================
  Hits          706      706
  Misses         78       78
  Partials       30       30

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hey,
should we also update the pull request template new_container.md with the additions and make sure, that they are consistent?
I like the improvements though 👍🏿

Closing for now (see #269 for details).


Uncomment and fix tests for 920480

Some tests for 920480 are commented. They should be uncommented and fixed or removed.

Duplicate


Update imports for NamedNavArgument

NamedNavArgument import is changed in the latest compose navigation release (2.4.0-alpha09) from androidx.navigation.compose.NamedNavArgument to androidx.navigation.navArgument
Environment:

Accompanist version: 0.18.0

Just saw that there is a PR to fix this.
https://github.com/google/accompanist/pull/722

Temporary fix https://github.com/wisnukurniawan/Compose-ToDoList/blob/main/app/src/main/java/com/wisnu/kurniawan/composetodolist/foundation/uiextension/NavGraphBuilderExt.kt

Yep, this was fixed in #722. Snapshot builds should already have the fix and it'll be in the next release.


New version. Syncing with upstream ipfs-service-provider

:tada: This PR is included in version 2.0.1 :tada:
Your semantic-release bot :package::rocket:


use beam search to generate melodies

Modifies the melody generation to use beam search instead of taking "greedy" steps.  This version of beam search uses three parameters:
beam_size: The number of melodies to include in the "beam"; the current active set.  When using a pre-trained bundle, this parameter must match the bundle's generation batch size.
branch_factor: The number of new melodies to generate per active melody in each beam search iteration.  All but the beam_size melodies with highest likelihood will then be discarded.
steps_per_iteration: The number of melody steps to generate per beam search iteration.
When all three of these parameters have value 1, the generation matches the old "greedy" behavior.

Looks good. It actually improves readability, nice.

I updated this to use the GeneratorOptions to pass beam search parameters.
However, there's an issue with batch size.  If at all possible, I'd really like to require that beam size and batch size are the same; the code will be a lot messier otherwise.  Unfortunately batch size is currently fixed by the graph itself, and it looks nontrivial to remove this.  (It's also fixed at 1 in our existing bundles.)


Added Typescript's definitions

Added Typescript's definitions to make the library work with Typescript.

Any plan to merge this PR?


Assume pip is on PATH

Other files may need to be updated as well

Other files may need to be updated as well

Let's do all in one pr then

Other files may need to be updated as well

Let's do all in one pr then

Unsure which files that would be, so I'll mark this as draft and come back later (or someone else can complete it).


Implement String#index with bstr for String patterns

String#index is a specialized version of String#scan.
It might be possible to implement String#index in terms of String#scan, but it will likely be more efficient to create a specialized impl.

@lopopolo i can work on this

@aivensong sounds good

going to try to take this one, will review previous pull request

can I work on this @lopopolo ? or is it done ?

Hi @AlyHKafoury. Yes you can work on this.
spinoso-string is the place this should live now: https://github.com/artichoke/artichoke/tree/trunk/spinoso-string.


Errors updating azdata

2 reported issues :

This error is appearing - looks like some path isn't quoted properly

Error updating azdata : Unexpected exit code from command : '""C:\Program' is not recognized as an internal or external command,
operable program or batch file. (1)

Error updating azdata: not found: azdata.cmd on startup when azdata isn't installed. We shouldn't be displaying that error during update when it isn't user-prompted (instead just fail silently)

https://github.com/microsoft/azuredatastudio/blob/main/extensions/azdata/src/azdata.ts#L288 Issue for the first one is here - the path is being double quoted. Once on 288 and again on 289. Only one is needed.


@providesModule naming collision

I download your latest release (version 2). I am avoding to use the master branch since travis-ci said it failed to build. I thought it will run smoothly, as I start running react-native start, I got this message :
React packager ready.

[5/8/2017, 9:56:39 AM] <START> Initializing Packager
[5/8/2017, 9:56:39 AM] <START> Building in-memory fs for JavaScript
[5/8/2017, 9:56:40 AM] <END>   Building in-memory fs for JavaScript (76ms)
[5/8/2017, 9:56:40 AM] <START> Building Haste Map
Failed to build DependencyGraph: @providesModule naming collision:
  Duplicate module name: react-native-vector-icons
  Paths: /home/fawwaz.muhammad/personal/bukalapak/react-native-starter-app-2.0.0/node_modules/react-native-router-flux/node_modules/react-native/local-cli/core/__fixtures__/files/package.json collides with /home/fawwaz.muhammad/personal/bukalapak/react-native-starter-app-2.0.0/node_modules/react-native/local-cli/core/__fixtures__/files/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
Error: @providesModule naming collision:
  Duplicate module name: react-native-vector-icons
  Paths: /home/fawwaz.muhammad/personal/bukalapak/react-native-starter-app-2.0.0/node_modules/react-native-router-flux/node_modules/react-native/local-cli/core/__fixtures__/files/package.json collides with /home/fawwaz.muhammad/personal/bukalapak/react-native-starter-app-2.0.0/node_modules/react-native/local-cli/core/__fixtures__/files/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
    at HasteMap._updateHasteMap (/home/fawwaz.muhammad/personal/bukalapak/react-native-starter-app-2.0.0/node_modules/react-native/packager/react-packager/src/node-haste/DependencyGraph/HasteMap.js:159:13)
    at /home/fawwaz.muhammad/personal/bukalapak/react-native-starter-app-2.0.0/node_modules/react-native/packager/react-packager/src/node-haste/DependencyGraph/HasteMap.js:134:31
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node node_modules/react-native/local-cli/cli.js start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node node_modules/react-native/local-cli/cli.js start'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the StarterKit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node node_modules/react-native/local-cli/cli.js start
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs StarterKit
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls StarterKit
npm ERR! There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/fawwaz.muhammad/.npm/_logs/2017-05-08T02_56_40_527Z-debug.log

Hi @fawwaz
I believe this one was solved from https://github.com/mcnamee/react-native-starter-app/issues/70 if you grab the latest from Master

Yeah, I install react-native-router-flux version 0.38.0 and it works normally.


Feature/det 176 add events to activity stream

Description of change
We want to be able to save Data Hub Events as objects into Activity Stream (interactions are currently all that are saved)
This work now adds the list of events to activity stream, following a similar pattern to interactions (including a serialiser, queryset, and associated test)
Checklist

[x] Added add-events-to-activity-stream.feature.md to the events file in the Changelog fodler

[x] Has this branch been rebased on top of the current develop branch?

[x] Is the CircleCI build passing

LGTM! v cool to see it coming through on the /v3/activity-stream/event endpoint. let me know if you'd like help tidying up the commits.

LGTM! v cool to see it coming through on the /v3/activity-stream/event endpoint. let me know if you'd like help tidying up the commits.


sticky element not working. please help me!!!

Hi all,
I have faced the issue.
sticky element not fixing in top. it has been also scrolling. i have checked with inspect element.
there is only 1 or 2 seconds it has been sticky. after that sticky element also scrolling. please help me to solve this.
thanks in advance

Please read the issue template that you deleted when you created this issue!


Baresip with Coturn relay not working?

I'm not sure if this is an issue with Baresip or my noob-ness, but I have setup Coturn so that I can use STUN and TURN with Baresip. I have tested my Coturn server with Trickle ICE and it appears to be relaying (TURN) and resolving host IP's (STUN) properly.
Here is my accounts file:
"Pi" sip:101@domain.com;auth_pass=pass1234;stunuser=guest;stunpass=somepassword;stunserver=turn:domain.com:3478;medianat=turn
My understanding is that if I specify turn as a stun server, I will only have relay capabilities even though Coturn does both STUN and TURN. Is that correct?
If I use these settings baresip loads as follows:
using stunserver: 'turn:domain.com:3478'
<EMAIL_ADDRESS>Using medianat 'turn'
.....
[h264_omx @ 0xac200470] Using OMX.broadcom.video_encode
stream: incoming rtp for 'audio' established, receiving from domain.com:10842
<EMAIL_ADDRESS>session closed: Connection reset by peer0
However, if I try to make a video call over two different networks 1 NAT and the other over a cellular network (I assume that is NAT'ed) I only get any video, which if TURN is working, it should be relaying audio and video. If I'm on the same NAT'ed network, I get video.
Do both clients need to support TURN and STUN?  I tried with microsip and baresip.
Again, the expected behavior is to have both STUN and TURN working together, so that if STUN fails, TURN is there as a backup to ensure both audio and video make it though.

@alfredh
Okay, for the past two days I have been testing and testing. I believe I have narrowed the problem down slightly. If I use two different SIP clients, MicroSIP and GS Wave for Android, video call work consistently, even on differing networks. When I add Baresip into the equation with either MicroSIP or GS wave, video works intermittently.
Here is the layout of my network which is NOT effecting the intermittent video problem.
PBXSRV ----------- NAT --- BareSIP
|
MicroSIP
This is an ideal setup and video calls work intermittently.  If I replace Baresip with GS Wave it works every time. This is without using a Coturn or a google STUN server.
Any ideas?
Syirrus

My understanding is that if I specify turn as a stun server, I will only have relay capabilities even though Coturn does both STUN and TURN. Is that correct?

medianat=turn means TURN only.

Again, the expected behavior is to have both STUN and TURN working together, so that if STUN fails, TURN is there as a backup to ensure both audio and video make it though.

For this setup you need to configure medianat=ice

My understanding is that if I specify turn as a stun server, I will only have relay capabilities even though Coturn does both STUN and TURN. Is that correct?

medianat=turn means TURN only.

Again, the expected behavior is to have both STUN and TURN working together, so that if STUN fails, TURN is there as a backup to ensure both audio and video make it though.

For this setup you need to configure medianat=ice , but the peer needs ICE support too.
@sreimers
Thank you for your response.  I have tried with medianat=ice and when I do so I don't get video at all, even though my TURN server appears to be setup properly according to Trickle ICE.  I wanted to force TURN to see if my video problems were related to NAT traversal issues.  They are not and seem to be linked to baresip, because if I use differing SIP clients without Baresip (even without TURN), I get video consistently.  The funny thing is, when I accept or initiate a video call on the Pi zero, the led on the camera comes on.  I just don't see the video on the other end :(

Well after much fighting, I'm stuck.  Video & Audio work on the same LAN that is NAT'ed (public IP facing PBX). If I switch to the cellular network the calls connect and I get audio, but no video. I've used UDP, and tried TLS to no avail.

Well, I believe I can safely conclude that this issue lies within Baresip :(. If I use different SIP clients other than Baresip (Microsip and GS wave for android) video calls work over my (NAT'ed) network and the cellular network with GS Wave for android. Those clients also work both on my NAT'ed network as well.
As a part of the testing, I removed the STUN and TURN server out of the equation completely and have everything going over UDP.
When to try with Baresip on my (NAT'ed) network with GS Wave or Linphone over the same (NAT'ed) network, video calling works most of the time, but it's intermittent (irrespective of which device is calling whom).  My camera on the pi indicates that it's on always, but sometimes there is just not picture on GS Wave or Linphone. I would say it works 2 out of 3 times.
When I try with Baresip on my (NAT'ed) network with GS Wave over the cellular network, video calling fails every time, however I do have audio, just not video.
Any ideas @alfredh ?  I have spent tons of time on this double and triple checking my config and accounts file and it's just not that.


Add support for CSS prefers-reduced-motion media feature for Windows

https://bugzilla.mozilla.org/show_bug.cgi?id=1365045

Working on https://developer.mozilla.org/en-US/docs/Web/CSS/@media - I can't see how to get Media Queries Level 5 to show in the specification list: https://drafts.csswg.org/mediaqueries-5/ @chrisdavidmills can you let me know?

Wow, that is an annoying animation. I love it ;-)
Same as previous comments — add note to Fx63 rel notes, request engineering review.

With these reviews should I wait for the data to be merged or just mention that is pending?

Just link to the PR, so the engineer can see it has been submitted.

This has been added to the release notes and the bug updated to notify the engineer.

Perfect; closing now.


Add Adjudicator Getter for Multi-Adjudicator

Location
channel/multi/adjudicator.go
Problem
While the traditional adjudicator allows setting the Receiver address, this is not possible when using the Multi-Adjudicator which hides the underlying adjudicators for each chain.
Proposal
Adding a getter which would return the adjudicator for a given LedgerID would solve this problem as we could then use this adjudicator to access the Receiver address.

Has to be implemented in go-perun.


Can't open website when in 4G mode

Environment

Minimal Mistakes version: 4.22.0
Ruby gem or remote theme version:
Jekyll version:4.2.0
Git repository URL:https://github.com/fayeah/fayeah.github.io
GitHub Pages hosted (if yes provide URL to site): https://fayeah.github.io/
Operating system: macOS

Expected behavior
Can open git page (website) as normal under 4G/data, but it fails to load the page without loading on  mobile (iPhone).
Steps to reproduce the behavior
open page on Safari browser

Whoa... things are getting stranger and stranger.
It's definitely not this theme's fault that the page doesn't load on your mobile cellular data. Check your internet connection.
BTW, China Mobile is notorious for its terrible global internet access. For example, this V2EX thread and this Emacs China thread both blames China Mobile for GitHub Pages accessibility issues.
Checkout my article on accelerating GH Pages with Cloudflare (custom domain needed).
（要爱国上网就别用移动网，或者买个好点的梯子）

Whoa... things are getting stranger and stranger.
It's definitely not this theme's fault that the page doesn't load on your mobile cellular data. Check your internet connection.
BTW, China Mobile is notorious for its terrible global internet access. For example, this V2EX thread and this Emacs China thread both blames China Mobile for GitHub Pages accessibility issues.
Checkout my article on accelerating GH Pages with Cloudflare (custom domain needed).
（要爱国上网就别用移动网，或者买个好点的梯子）

好嘛，谢啦～


Add new arrow and page keybindings

Hello! I found mprocs on r/rust and have been enjoying it, many thanks for making it.
I'm not a Vim user and I found the keybindings a little unintuitive at first. I think it might help to add some additional keybindings for common navigation actions; what do you think?

Good addition. Thank you!


[WIP] Webhooks HTTPS Enhancements

This WIP PR improves HTTPS in web hooks. I just copied the test certs from vmq_server, but that's ugly. Can I move the test certs to the top-level of the project since I'll need them in these tests and in vmq_server tests?
Adds HTTPS-specific options to the webhooks module and tests. Allows
users to specify a custom CA and verification options. Allows hooks
to authenticate to endpoints with client certificates.
Adds PEM validation to the vmq_server and vmq_webhooks schemas.
Proposed Changes
Please describe the big picture of your changes here to communicate to the
VerneMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.
Types of Changes
What types of changes does your code introduce to this project?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes issue #XXXX)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, styles...)
[ ] DevOps (Build scripts, pipelines...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

[x] I have read the CODE_OF_CONDUCT.md document
[x] All tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if needed)
[x] Any dependent changes have been merged and published in related repositories
[ ] I have updated changelog (At the bottom of the release version)
[ ] I have squashed all my commits into one before merging

Further Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@varnerac looking great so far! :+1:
Guess moving test certs to toplevel is somwhat 'ugly' too :) but I'm fine with it. As long as it's clear that they're just that, a bunch of certs only used in testing.

@varnerac looking great so far! :+1:
Guess moving test certs to toplevel is somwhat 'ugly' too :) but I'm fine with it. As long as it's clear that they're just that, a bunch of certs only used in testing.

I may just leave a few in a test directory. While I am in here, I am refactoring some of the test code to pull artifacts like "dummy files" from foo_SUITE_data directories using the CT macros.

I may just leave a few in a test directory. While I am in here, I am refactoring some of the test code to pull artifacts like "dummy files" from foo_SUITE_data directories using the CT macros.

If CI is clean, this ready for review

If CI is clean, this ready for review

Meh. I've somehow bumped rebar.lock to a new version. I probably forget to hit ./rebar3 ct. I am gonna revert that.

Meh. I've somehow bumped rebar.lock to a new version. I probably forget to hit ./rebar3 ct. I am gonna revert that.

Ok. Reverted the rebar.lock. We should be good to go.

Ok. Reverted the rebar.lock. We should be good to go.

@varnerac Do the WebHook tests run ok, locally? they failed for all Erlang versions in last build, but I can't restart the build on Travis (out of build points there)

@varnerac Do the WebHook tests run ok, locally? they failed for all Erlang versions in last build, but I can't restart the build on Travis (out of build points there)

They do locally. Both the webhooks and server schema suite should be checked, because I added PEM validation to the server schema too.
varnerac@Drews-MacBook-Pro vernemq % asdf current erlang
erlang          23.2.1          /Users/varnerac/vernemq/.tool-versions
varnerac@Drews-MacBook-Pro vernemq % ./rebar3 ct --suite apps/vmq_webhooks/test/vmq_webhooks_SUITE
===> Rebar3 detected a lock file from a newer version. It will be loaded in compatibility mode, but important information may be missing or lost. It is recommended to upgrade Rebar3.
===> Verifying dependencies...
===> Compiling vmq_ql
===> Running neotoma...
===> Compiling vmq_plugin
===> Compiling vmq_commons
===> Compiling vmq_server
===> Compiling vmq_webhooks
===> Compiling vmq_swc
===> Compiling vmq_acl
===> Compiling vmq_plumtree
===> Compiling vmq_generic_msg_store
===> Compiling vmq_passwd
cc   -L/usr/local/opt/openssl/lib -I/usr/local/opt/openssl/include vmq_passwd.c -lcrypto -o ../priv/vmq_passwd
===> Compiling vmq_mqtt5_demo_plugin
===> Compiling vmq_pulse
===> Compiling vmq_bridge
===> Compiling vmq_diversity
===> Running Common Test suites...
%%% vmq_webhooks_SUITE: ......................................[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed

All 38 tests passed.
varnerac@Drews-MacBook-Pro vernemq % ./rebar3 ct --suite apps/vmq_server/test/vmq_schema_SUITE
===> Rebar3 detected a lock file from a newer version. It will be loaded in compatibility mode, but important information may be missing or lost. It is recommended to upgrade Rebar3.
===> Verifying dependencies...
===> Compiling vmq_ql
===> Running neotoma...
===> Compiling vmq_plugin
===> Compiling vmq_commons
===> Compiling vmq_server
===> Compiling vmq_webhooks
===> Compiling vmq_swc
===> Compiling vmq_acl
===> Compiling vmq_plumtree
===> Compiling vmq_generic_msg_store
===> Compiling vmq_passwd
cc   -L/usr/local/opt/openssl/lib -I/usr/local/opt/openssl/include vmq_passwd.c -lcrypto -o ../priv/vmq_passwd
===> Compiling vmq_mqtt5_demo_plugin
===> Compiling vmq_pulse
===> Compiling vmq_bridge
===> Compiling vmq_diversity
===> Running Common Test suites...
%%% vmq_schema_SUITE: .........
All 9 tests passed.

They do locally. Both the webhooks and server schema suite should be checked, because I added PEM validation to the server schema too.
varnerac@Drews-MacBook-Pro vernemq % asdf current erlang
erlang          23.2.1          /Users/varnerac/vernemq/.tool-versions
varnerac@Drews-MacBook-Pro vernemq % ./rebar3 ct --suite apps/vmq_webhooks/test/vmq_webhooks_SUITE
===> Rebar3 detected a lock file from a newer version. It will be loaded in compatibility mode, but important information may be missing or lost. It is recommended to upgrade Rebar3.
===> Verifying dependencies...
===> Compiling vmq_ql
===> Running neotoma...
===> Compiling vmq_plugin
===> Compiling vmq_commons
===> Compiling vmq_server
===> Compiling vmq_webhooks
===> Compiling vmq_swc
===> Compiling vmq_acl
===> Compiling vmq_plumtree
===> Compiling vmq_generic_msg_store
===> Compiling vmq_passwd
cc   -L/usr/local/opt/openssl/lib -I/usr/local/opt/openssl/include vmq_passwd.c -lcrypto -o ../priv/vmq_passwd
===> Compiling vmq_mqtt5_demo_plugin
===> Compiling vmq_pulse
===> Compiling vmq_bridge
===> Compiling vmq_diversity
===> Running Common Test suites...
%%% vmq_webhooks_SUITE: ......................................[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed

All 38 tests passed.
varnerac@Drews-MacBook-Pro vernemq % ./rebar3 ct --suite apps/vmq_server/test/vmq_schema_SUITE
===> Rebar3 detected a lock file from a newer version. It will be loaded in compatibility mode, but important information may be missing or lost. It is recommended to upgrade Rebar3.
===> Verifying dependencies...
===> Compiling vmq_ql
===> Running neotoma...
===> Compiling vmq_plugin
===> Compiling vmq_commons
===> Compiling vmq_server
===> Compiling vmq_webhooks
===> Compiling vmq_swc
===> Compiling vmq_acl
===> Compiling vmq_plumtree
===> Compiling vmq_generic_msg_store
===> Compiling vmq_passwd
cc   -L/usr/local/opt/openssl/lib -I/usr/local/opt/openssl/include vmq_passwd.c -lcrypto -o ../priv/vmq_passwd
===> Compiling vmq_mqtt5_demo_plugin
===> Compiling vmq_pulse
===> Compiling vmq_bridge
===> Compiling vmq_diversity
===> Running Common Test suites...
%%% vmq_schema_SUITE: .........
All 9 tests passed.

I think the rebar.lock issue comes from the Erlang Language Server (LS) in my VS Code.

I think the rebar.lock issue comes from the Erlang Language Server (LS) in my VS Code.

@varnerac Great, I'm merging this!

@varnerac Great, I'm merging this!


Error: 64bit is not automatically supported for this version of VC. Set HXCPP_MSVC_CUSTOM and manually configure the executable, library and include paths

Describe your problem here.
For some reason, for 3 days, i was blocked by this error while compiling
after this:
  source/options/NoteOffsetState.hx:60: characters 3-39 : Warning :FlxCamera.defaultCamerasis deprecated, useFlxG.cameras.setDefaultDrawTargetinstead
This happened
  F:\Jeux\FRIDAY NIGHT FUNKIN'\Theoyeah-Engine\export\release\windows\obj>setlocal enabledelayedexpansion  Error: 64bit is not automatically supported for this version of VC. Set HXCPP_MSVC_CUSTOM and manually configure the executable, library and include paths Error: Error: 64bit is not automatically supported for this version of VC. Set HXCPP_MSVC_CUSTOM and manually configure the executable, library and include paths
I tried to re-install everything, even trying to use Haxe 4.2.5, checking 4 times if i had the correct components and still, nothing happened
It would be extremely grateful if someone can help me fix this issue
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
huuhhhhh, too much stuff to list

Fixed, i tried using a specific version of visual studio 2019 and it works!

What 2019 version do I need?

I'm sorry to revive this, but which 2019 version did you use to solve this issue? I have had the same error as well.


Add additional admin fields to correct fieldset list

Additional admin fields in PostAdmin get_fieldsets were being added to an empty fieldset list (here https://github.com/nephila/djangocms-blog/blob/develop/djangocms_blog/admin.py#L96-L98) and were not being displayed. This adds them to the first list instead, making them available to the user

Coverage remained the same at ?% when pulling 92cdc0f895c22e16486a0c098c75624f29437934 on protoroto:hotfix/fix-additional-admin-fields-adding into 8c5461c58abb3451334fe674b4417937aaa318f4 on nephila:release/0.9.x.

Coverage remained the same at ?% when pulling 92cdc0f895c22e16486a0c098c75624f29437934 on protoroto:hotfix/fix-additional-admin-fields-adding into 8c5461c58abb3451334fe674b4417937aaa318f4 on nephila:release/0.9.x.

@protoroto this is not needed. As discussed directly, the issue was in missing 'sortedm2m' in installed apps


[misc] Update steps for Crosswalk FullScreen Reopen

ECS2-8A:
Impacted TCs num(approved): New 0, Update 1, Delete 0
Unit test Platform: Crosswalk Project for Android 18.46.457.0
Unit test result summary: Pass 1, Fail 0, Blocked 0
https://crosswalk-project.org/jira/browse/XWALK-5559

LGTM


[otbn,rtl] Delay the "locked" signal from controller while wiping

This signal feeds straight into the STATUS register and we need to
wait until the operation is complete before setting it to LOCKED.
Note that this still doesn't completely fix tests like otbn_imem_err when secure wipe is enabled. The problem is that we're still issuing an alert immediately upon seeing the error, but the testbench expects that to happen at the same time as the operation completes and STATUS gets updated. Delaying the alert is probably the right thing to do, but that can come in a separate PR.

Yeah, I'm not completely sure about delaying the alert either. The plus side of doing so would be that I didn't have to mess around more with the DV code :-) In the scoreboard, we essentially assert that we don't get an alert unless we see the STATUS register change.
If we do decide to keep the immediate alert behaviour, the proper fix is probably to teach the ISS to generate an "I raised an alert" output which we could match up with the scoreboard directly.


Add word-wrap support, with wrap length provided by the user

What type of PR is this?

feature

What this PR does / why we need it:
The help text is difficult to read when the lines are long. This patch attempts to wrap long lines, if the user provides a terminal width to wrap at.
Which issue(s) this PR fixes:
Updated version of #1044.
Refers to #287.
Testing
Added a unit test (which can be expanded).
Release Notes
The help text is now wrapped to fit the terminal window.

How does this look?

Is it OK to add a new field to helpPrinter?
The template probably needs tweaking to support wrapping more fields, but I don't know offhand which other fields to test.
This makes no attempt to break long words.

I see you just force pushed, so I'm not sure what changed? Can you re-request my review when this is ready for eyes again, and please not force push until after the PR is ready to merge?

I see you just force pushed, so I'm not sure what changed? Can you re-request my review when this is ready for eyes again, and please not force push until after the PR is ready to merge?

Sorry about that- I squashed the commit in an attempt to make it easy to verify that no new modules were added.
I have re-pushed the branch with the original commit followed by a fixup that removes the newly added module.

I'll try to give this a look soon!

@lynncyrin Would love to see this merged.

Oops 😄

Is this ready to be merged?

Is this ready to be merged?

It's stalled, waiting for review.

I was looking into the conflicting files, and noticed that #1175 has landed, which implements a subset of the feature here.
Force-pushed a squashed version of this with two fixes appended, which makes TestWrappedHelp also test user specifed indenting, and another change which makes Test_ShowAppHelp_MultiLineDescription on master pass if I revert the code changes from be9c0378066dc5baf84a56005f90317cca6ecd84 and then apply this PR.
How should we proceed?

I was looking into the conflicting files, and noticed that #1175 has landed, which implements a subset of the feature here.
Force-pushed a squashed version of this with two fixes appended, which makes TestWrappedHelp also test user specifed indenting, and another change which makes Test_ShowAppHelp_MultiLineDescription on master pass if I revert the code changes from be9c037 and then apply this PR.
How should we proceed?

Those changes were contributed because someone needed them, and then tagged in a release. I think reverting them is off the table.
If you're still interested in getting this change in, you'll need to resolve conflicts. I'm totally fine if we change the template—I think folks using the default template are just signing up for whatever we decide makes sense. That said, the new template functions (indent, nindent, and trim) are now part of the public API, so those are something we shouldn't be removing.

Those changes were contributed because someone needed them, and then tagged in a release. I think reverting them is off the table.
If you're still interested in getting this change in, you'll need to resolve conflicts. I'm totally fine if we change the template—I think folks using the default template are just signing up for whatever we decide makes sense. That said, the new template functions (indent, nindent, and trim) are now part of the public API, so those are something we shouldn't be removing.

Pushed a rebased and squashed version, which undoes the template changes from be9c0378066dc5baf84a56005f90317cca6ecd84, but leaves the indent, nindent and trim functions in the function map for anyone who started using them with a custom template.

Updated the template and added some tests to wrap commands and subcommands. There are probably other items that we can improve, but I think this is a good start.

How does this look now?

Ping.

@mostynb Sorry for the delay!

@mostynb Are you up for resolving the conflicts and moving this work forward? No worries if not. I'm happy to pick it up ❤

I'll take a look and let you know if I run into trouble.

@meatballhat: the failing test also fails for me locally on the tip of main. The CI failure is also visible in this typo fix PR: #1402

@mostynb this looks like the problem of the docs tests running against latest release instead of current working tree :weary:
bumping the priority of that work now...

@mostynb Attempted fix for the test-docs step at #1403

@meatballhat: CI is green after rebasing on main.

Is there any docs for this?

Is there any docs for this?

Perhaps it could be more discoverable, but you need to set HelpPrinterCustom or HelpPrinter to add a wrapAt function to the funcMap. eg:
https://github.com/urfave/cli/pull/1119/files#diff-4d3f36d62cad94424544bb84fc93b33b73ffe3491a4ddca81a7f825539afc19cR1161-R1169


test(maintenance): improve assertions on traces & logs

Summary
Changes

Please provide a summary of what's being changed

This PR improves and simplifies the helpers used to retrieve AWS X-Ray trace data that are used in the integration tests. As a result of this, the integration tests for the utility are also slightly simplified due to the helpers handling more of the data retrieval & validation from the X-Ray API.
The PR also extends some assertions in the Idempotency tests to more flexibly assert timeouts in Amazon CloudWatch Logs.
While working on this, I have also updated the Dependabot config so that it targets the @aws-cdk/cli-lib-alpha (dependency of packages/testing) as it had fallen behind on updates and was no longer compatible with the more recent AWS CDK installed version.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3011

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Passing integration tests on this branch: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/10671082450

The code duplication is a bit high for all the tracer tests (middy, decorator, manual), but I think we can address it in a different PR

I agree. We have upcoming PRs where we'll work on streamlining similar to what we did in other areas in the past few weeks. For now seeing as the PR was already large I decided to not act on this.


Partially update parameters for the Embedding layer?

A very import feature needed for word embedding is that word embeddings are updated partially depending on the input indexes, especially when the vocabulary is very large. The current code seems that it updates embeddings of all words in vocabulary for each mini-batch input. We can calculate the gradients w.r.t a subtensor instead of the whole tensor to get this feature, as the official document shows: http://deeplearning.net/software/theano/tutorial/faq_tutorial.html.
There are other mertials also show that updating with subtensor speed up weight update. For example:  https://github.com/Theano/Theano/issues/3342
However, it seems that there is no easy way to fullfil this. The problem is that layer.params must be a list of shared variables, (unfortunately, subtensors are not shared variables), otherwise the optimizer would raise an exception. Some tricks can be done to implement this feature, but they introudce dependencies between Layers and Optimizers. What a pity! Any ideas?

You are raising a big problem indeed that needs to be solved since it is causing the code to be incorrect when using rmsprop. As pointed out in the faq.

I hate doing that but i think that this issue should be pointed to @fchollet to understand possible changes.
To be honest this things is wrong in all the library out there (Blocks, Lasagne), but i think it need to be fixed.

Since the embeddings are "shared" any change for one word is a change for all words. Or am I understanding the problem wrong?

@lemuriandezapada The problem is that at each step the updates are calculated for all the embeddings in the dictionary. Assume that you have 1M words in your Embeddings matrix each time you back propagate you compute the updates for 1M Embeddings when most of the times only a few of them are seen in the batch examples. This is always an overhead. Sometimes is even worse since Embeddings updates are mostly zeros update (They do not "fire" in the forward pass so they have to be seen as not present in the network at that moment) using some optimizer that is based on the history of updates with accumulators leads to bad updates. In fact it may cause problem when the previously unseen word is finally present, since It has an history of zeros updates the optimiser assumes that the weight is "good" so it is updated only a little or nothing at all.
I hope i'm clear enough.

I did a simple evaluation on my dataset just to highlight the differences, i preloaded the embeddings matrix with the mikolov embeddings. I then trained the network two times one updating the embedding and one that do not.
Then i used  two different optimisation methods Adadelta that uses the history of updates and Adam that do not. And these are the result:
Adadelta:
Fixed Emb:         Acc: 0.6416502057
Dynamic Emb:    Acc: 0.6421389015
Adam:
Fixed Emb:          Acc: 0.6570553647
Dynamic Emb:     Acc: 0.6859934147
Despite Adam perform slightly better even without updating the embeddings i think that the difference in the refinement phase is quite significant.
@fchollet have you some ideas on how to fix this issue in this library?

I'm just seeing this and it may explain some things...
Am I correct in thinking that this means that the current Embedding class is broken if there's regularization applied to the embedding layer or any dependent layer?

Does anyone have an update on this?

@elbamos yes, regularization on embeddings would likely lead to suboptimal results. And many related weird things also depend on batch size, causing some "unexplainable" phenomenons.

UPDATE: this issue can be resolved by using tensorflow backend with tensorflow optimizer, e.g. tf.train.GradientDescentOptimizer. As the gradient of tf.gather function will be sparse. In cases of large embedding weight W, this can produce very significant speedup (e.g. 5x or more).


fix(glue): delete CatalogId parameter from get_jobs api call

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

fix(glue): delete CatalogId parameter from get_jobs api call
delete CatalogId from get_jobs api call as it doesn't support this parameter. Also updated the doc to notify users glue job doesn't support cross-account access at this moment
no BREAKING CHANGE


Changelog updates

@sthielen This draft is ready for your review. Main pages for review:

Changelog - info about platform changes to the fee schedule, refunds, and withdrawals
Analytics package docs

Let me know if any changes are required. Thanks!

This looks good to me!


Update Student_Summaries.ipynb

I'm accepting this version, but you will see an edited version on the website.  In future submissions, please try to match the style that appears on the course webpage.

Wait so did my notes post?
On Tue, Sep 6, 2022 at 8:42 AM Billy Quarles @.***>
wrote:

Merged #3 https://github.com/saturnaxis/Astrobio/pull/3 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/saturnaxis/Astrobio/pull/3#event-7330074325, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2RIFDKFGKEFGWTAG227TZLV443Z7ANCNFSM6AAAAAAQFNUV34
.
You are receiving this because you authored the thread.Message ID:
@.***>

It's merged into main branch, but not yet posted into the course website.
I'm still working on the editing.
On Tue, Sep 6, 2022, 5:51 PM tylerknox @.***> wrote:

Wait so did my notes post?
On Tue, Sep 6, 2022 at 8:42 AM Billy Quarles @.***>
wrote:

Merged #3 https://github.com/saturnaxis/Astrobio/pull/3 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/saturnaxis/Astrobio/pull/3#event-7330074325, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A2RIFDKFGKEFGWTAG227TZLV443Z7ANCNFSM6AAAAAAQFNUV34
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/saturnaxis/Astrobio/pull/3#issuecomment-1238692676,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDVGOBXOOJP6IPOZI4WSZDV464HFANCNFSM6AAAAAAQFNUV34
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Add loading option to Combo Box

Description
The design can be found on the contributions.

This will be worked on during our migration and refactoring work.


Add Ability to check a condition outside of a request

Many conditions are applicable outside a request, like percentages, user groups, user languages, etc. It would be great if there was a way to check a flag from a model method.

why don't you use a switch for that?

If you really want to fake a request outside a request, RequestFactory().get('/') is a good way to do it:
def my_offline_function():
    user = get_user_somehow()
    req = RequestFactory().get('/')
    req.user = user
    if flag_is_active(req, 'some_flag'):
        pass


There are still things wrong with the file-level license declaration fields

Issue Type: Bug
Issue Description:
I was trying to curate the license for a specific file on a component. Two strange things have happened when I try to do this:
Firstly, if you try to curate a file that already has an SPDX expression with multiple conjunctive / disjunctive operators (i.e SPDX "Apache-2.0 AND GPL-1.0-or-later AND LGPL-2.0-or-later") and try to change to "Apache-2.0 OR LGPL-3.0-or-later" instead, CD just appends it to the existing expression. This happens regardless of if you use the editor to build the expression or just type it in letter-by-letter. The result and steps to reproduce are formalized below:
Existing data: "Apache-2.0 AND GPL-1.0-or-later AND LGPL-2.0-or-later"

User's input data (via SPDX expression editor): "Apache-2.0 OR LGPL-3.0-or-later"

Result data:

And secondly, in some cases if you try to click on the "pencil" edit field after doing enter in SPDX expressions like the above, the page will go completely blank!
Tested in Google Chrome (64-bit)

This seems to be the same error mentioned in #689
We are going to investigate on this problem on the service side.
Thanks.

The first part of this is taken care of by https://github.com/clearlydefined/service/pull/530 ; second part (blank screen when using pencil) remains.

Blank screen problem has been fixed in https://github.com/clearlydefined/website/pull/695 , hence once the service implementation will be merged, we can consider this one as closed.

@storrisi I don't see either fixed in prod yet. I will assume this is because they have not been merged yet.
I'll keep my eyes open for when they are :)

@storrisi : More weird behavior: When I add a source location, it now modifies the license field too.
Please see following component: https://clearlydefined.io/definitions/pypi/pypi/-/Unidecode/1.0.23
I go to the Source Location box and enter the following: user/org = "avian2", repo = "unidecode", commit/version = "unidecode-1.0.23". I enter in the text and then select the drop-down recommendation for each field.
When I click OK, it appends SPDX: "GPL-2.0-only" to the Declared License field. In the end, it looks like the below:

Do you get the same behavior on your end?
If yes, we need to bump this up in priority if we haven't already because it affects people's ability to do curations.

Thank for addressing this.
Unfortunately those data are returned from the backend so we should investigate what happens there. I suggest @ignacior to take a look soon.

This should be resolved by incorporating @dabutvin comment here https://github.com/clearlydefined/service/pull/530#discussion_r286164619 ; I am working on it.

There is also still an issue with flipping ANDs to ORs on the UI -- it can't be done. Not sure if the above solves it and we're just waiting for it to be merged into production, but I thought I'd call it out just in case.

License detects BSD-3-Clause AND GPL-2.0.

User tries to change to BSD-3-Clause OR GPL-2.0 (either by free form text edit or by using the expression generator)

Nothing happens.  The AND remains.

@royaljust probably the problem that you mentioned is a website issue. Will check. Thanks.

I can confirm that the website sends to the service the correct information with the proper conjunction "OR" or "AND", but the returned data doesn't contain the change.
I guess that the implementation in https://github.com/clearlydefined/service/pull/530#discussion_r286164619 will fix also this problem.
@ignacionr could you confirm this?

this is now fixed in production. Please verify and open a new issue if there are further problems.
Regarding the license changing when you edit the source. This is a result of using a new algorithm to simplify the declared license expression and should be fine to submit with your curation.


How to prevent line break at a given position?

I have a document that contains this:

«Всем известно, что...», «точно установлено...»,

When it is rendered, a line break is inserted before », so it looks like this:

«Всем известно, что...
», «точно установлено...»,

How to fix that? I've tried inserting , but that causes the parser to fail.

OK, "zero width non-breaking space"  works, but is treated as a non-breaking space. Can it be parsed as a zero-width character?

Ideally, you'd use the zero-width character, though it's probably not recognized by the inline parser atm (every entity has to be parsed when passing it though Prawn). I suppose we could add &zwsp; to the list of matched entities. See https://github.com/asciidoctor/asciidoctor-pdf/blob/master/lib/asciidoctor-pdf/formatted_text/transform.rb#L6-L12.
But even if we did that, it's still not the right way to solve the problem because you shouldn't be adding those characters to your AsciiDoc to fix Prawn. This is an i18n issue in Prawn. Prawn should not be breaking the line at any quote character. It's probably hard coded somewhere in Prawn to only check for English quotes.
If we can't get it fixed in Prawn, we can introduce a patch so that Prawn behaves the right way. The bottom line is, you shouldn't be getting a break before the quote. That's the real problem to solve.


Iterator block for IEnumerable<T1<T2,T3>> generates incorrect docid

Use the following as the input assembly:
using System;
using System.Collections.Generic;

namespace Microsoft.Fx.Portability.MetadataReader.Tests
{
	class CallOtherClass
	{
		static void Main(string[] args)
		{
			OtherClass.GetValues<int>();
		}
	}

	public class OtherClass
	{
		internal static IEnumerable<Tuple<T, int>> GetValues<T>()
		{
			yield break;
		}
	}
}

The docid generated for GetValues is incorrect - there is a @ where there should be a #.
Expected: M:Microsoft.Fx.Portability.MetadataReader.Tests.OtherClass.<GetValues>d__0`1.System#Collections#Generic#IEnumerable{System#Tuple{T@System#Int32}}#GetEnumerator
Actual: M:Microsoft.Fx.Portability.MetadataReader.Tests.OtherClass.<GetValues>d__0`1.System#Collections#Generic#IEnumerable{System#Tuple{T,System#Int32}}#GetEnumerator
The generics may be a red herring, but that's the only way I can get it to compile in a way that it is detected by the dependency finder.  There are probably compiler optimizations in other cases.

Do you mean that there is a @ where a , is expected?
Actual: {T@System#Int32}
Expected: {T,System#Int32}

Yes, although I may have the expected/backward mixed up it seems (something seems off in my description).  When you get the time to take a look at it, can you post a clarification?


[purview] Migrate @azure-rest/purview-sharing to ESM/vitest

Packages impacted by this PR

@azure-rest/purview-sharing

Issues associated with this PR

https://github.com/Azure/azure-sdk-for-js/issues/31338

Describe the problem that is addressed by this PR
Migrates the @azure-rest/purview-sharing package to ESM/vitest via automation.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


TRACKING: 0.1.0

Overall

[ ] iso8601 config flag

Utils

[x] Shift Month
[x] Shift Week
[x] Shift Day

RelativeDuration

[ ] Module documentation
[x] Create

[x] RelativeDuration::months
[x] RelativeDuration::weeks
[x] RelativeDuration::days

[x] Read

[x] RelativeDuration::num_months
[x] RelativeDuration::num_weeks
[x] RelativeDuration::num_days

[ ] Add

[x] RelativeDuration to NaiveDate
[x] RelativeDuration to RelativeDuration

[x] Sub (RelativeDuration)
[ ] Div
[ ] Mul
[x] Display
[ ] serde::Serialize (human readable)
[ ] serde::Serialize (iso8601)

Interval

[ ] Display
[ ] serde::Serialize (human readable)
[ ] serde::Serialize (iso8601)

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f033eff). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   59.06%
=======================================
  Files           ?       11
  Lines           ?      579
  Branches        ?        0
=======================================
  Hits            ?      342
  Misses          ?      237
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add foreign keys checks.

Codecov Report

Merging #16 into master will decrease coverage by 4.65%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     53.08%   48.42%   -4.66%
- Complexity      443      449       +6
============================================
  Files            20       21       +1
  Lines          1441     1464      +23
============================================
- Hits            765      709      -56
- Misses          676      755      +79

Impacted Files
Coverage Δ
Complexity Δ

src/Controller/Admin/BackendController.php
0% <0%> (ø)
9 <0> (ø)
:arrow_down:

src/Controller/Admin/DatabaseController.php
0% <0%> (ø)
6 <6> (?)

src/Shell/TestCliShell.php
0% <0%> (-96.3%)
6% <0%> (ø)

src/Controller/Component/SetupComponent.php
0% <0%> (-19.87%)
59% <0%> (ø)

src/Maintenance/Maintenance.php
58.75% <0%> (-1.25%)
34% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d6a86e...f780f64. Read the comment docs.


Raven sign in button is not vertically centered

The Raven sign in button is not vertically centered inside of the white bar it's in:

Reassigning to @Coenego for review.

Coverage remained the same at 100.0% when pulling 6dfb4eeb7735692e01cfa1dacf84c4275b92949a on bp323:issue-435 into 9c63b26bee688d6e5398519060c90103216e60d4 on CUL-DigitalServices:master.


How to read HTML email

I download an email from IMAP and get an HTML email. The body is folding with an = sign. Example:
Check your remaining inventory: If you typically restock this product, chec=
k your remaining quantity in=20

How do I get the content such that there is no folding like this? I am clearly missing some setup here of some kind.

mail.html_part.decoded


feat(dspy): TensorRT LLM Integration

Solves issue #1094
This PR adds a clean integration of TensorRT LLM with dspy. Docs are also being added.

Hey @Anindyadeep , this is SO cool. In DSPy we tend to like client-server interfaces for LLMs but there's a lot of demand for inference inside the script.

Hey @okhat let me know your feedbacks, would love to iterate on them

Hi @Anindyadeep , thanks for this addition! left a few comments and should be ready to merge following that.

A quick question, any way to fix/bypass pre-commits for lm.py because it is giving me errors for things I have not added or changed.

Hi @Anindyadeep , thanks for the changes. Running ruff check . --fix-only will correct the failing test.
(not sure why it fails untouched code but sometimes modifying the file can raise linter errors, which are good to fix anyways en route with this PR).

ruff check . --fix-only

Unfortunately not working, here are the logs:
dspy-py3.9vscode ➜ /workspaces/dspy (anindya/trtllm) $ ruff check . --fix-only
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'extend-unsafe-fixes' -> 'lint.extend-unsafe-fixes'
warning: Docstring at dspy/teleprompt/mipro_optimizer.py:113:9 contains implicit string concatenation; ignoring...
warning: Docstring at dspy/teleprompt/mipro_optimizer.py:124:9 contains implicit string concatenation; ignoring...
dspy-py3.9vscode ➜ /workspaces/dspy (anindya/trtllm) $ git add dsp/modules/lm.py
dspy-py3.9vscode ➜ /workspaces/dspy (anindya/trtllm) $ git commit -m "fix(dspy): run ruff"
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /home/vscode/.cache/pre-commit/patch1718675924-4390.
ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

dsp/modules/lm.py:22:9: ANN201 Missing return type annotation for public function `basic_request`
dsp/modules/lm.py:25:9: ANN201 Missing return type annotation for public function `request`
dsp/modules/lm.py:28:9: ANN201 Missing return type annotation for public function `print_green`
dsp/modules/lm.py:31:9: ANN201 Missing return type annotation for public function `print_red`
dsp/modules/lm.py:34:9: ANN201 Missing return type annotation for public function `inspect_history`
dsp/modules/lm.py:116:9: ANN201 Missing return type annotation for public function `copy`
Found 6 errors.

ruff-format..............................................................Passed
isort....................................................................Passed
check yaml...........................................(no files to check)Skipped
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check docstring is first.................................................Passed
check toml...........................................(no files to check)Skipped
check for added large files..............................................Passed
fix requirements.txt.................................(no files to check)Skipped
check for merge conflicts................................................Passed
debug statements (python)................................................Passed
pretty format json...................................(no files to check)Skipped
prettier.................................................................Passed

no worries, just resolved it on my end and pushed the changes.
Thanks again @Anindyadeep!

no worries, just resolved it on my end and pushed the changes. Thanks again @Anindyadeep!

Thanks @arnavsinghvi11, upnext Triton Inference Server


transformation problem

@ajaniak — When trying to transform the file Guntur.xml, I get the following error message:

Can you solve this?

It is related to the fact Daniel and you wanted to declutter the code in the , so the code to handle the presence of an  <lb/> element inside a <lem> is dealt with a sum function, which cannot be performed one a structure organized paginated with recto and verso.

Sorry, I don't understand your response.

What is a "sum function"?
What do the words "which cannot be performed one a structure organized paginated with recto and verso" mean?
Does your response contain a proposal for solving the problem? If not, please formulate a proposal for
-- either modifying the EGD or
-- modifying the way I encode this situation

I'd be very grateful if I could get help solving this problem which apparently affects all files that contain bibliography.
I have prepared a number of editions to read in my EPHE séminaire this year, and I want to send the html displays to the participants a.s.a.p.

correction, the problem does not seem to be bibliography-related after all. it must be related to the use of <lb/> in apparatus, as Axelle suggested.
I await instructions for how to solve it in my xml files, if the solution doesn't lie in changing the xslt code.

 issue solved.
Axelle reverted to the ancient code in the XSLT.
Thus you need to pull "project documentation".
Important: keep in <lem> the text as it is in the edition, with all its markup; do not declutter  (keep all @).
NB @arlogriffiths : the remaining transformation issues in some of your Nusantara XMLs pertain to Zotero Short Titles:
EITHER two publications have same ST
OR ST in the field ST does not correspond to ST in Tags
OR one an the same publication has several ST in Tags

Thanks @ajaniak  and @manufrancis . I am closing this issue now and have already opened a few new ones concerning problems with display of bibliography.


Change the account creation flow

On the weekly email blast confirmation page, replace the content with the followings
[/learn intro text]

Quincy Larson, the teacher who founded freeCodeCamp.org

By the way, each Friday I send an email with 5 links about programming and computer science. I send these to about 4 million people.
[ Yes ] [ No thanks ]

Was this just edited? I was looking at this one and it had four steps. But what do expect the flow to be?

yes, we had a meeting :)

Oh~~~😅


preparations for the junit5 module

separation of the junit4 and junit5 code into different modules.
core module to share code between different TDD frameworks

hhmm com.fnproject.fn:fn-spring-cloud-function:jar:1.0.60 is missing..

Hmm that doesn’t look right, that should be a sub-module of this project @mjg123 can you take a look?

Yes - although I'm travelling rn so it's not going to be straight away.

merged master into PR, but the build ends on circleci again at the module fn-spring-cloud-function.
I checked the diff between master and PR, but this part is 100% the same. Changes are only after this point, during compile/install.  Please, have a look at this.
Cheers Sven
---- SNIP -- LOG ----
1214/1214 KB   1212/1212 KB
Downloaded: https://repo.maven.apache.org/maven2/com/fasterxml/jackson/core/jackson-databind/2.8.10/jackson-databind-2.8.10.jar (1214 KB at 7492.7 KB/sec)
Downloaded: https://repo.maven.apache.org/maven2/io/projectreactor/reactor-core/3.0.7.RELEASE/reactor-core-3.0.7.RELEASE.jar (1212 KB at 6960.5 KB/sec)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] fdk ................................................ SUCCESS [  6.936 s]
[INFO] api ................................................ SUCCESS [ 17.221 s]
[INFO] runtime ............................................ SUCCESS [ 12.788 s]
[INFO] testing ............................................ SUCCESS [  0.019 s]
[INFO] fn-spring-cloud-function ........................... FAILURE [  4.098 s]
[INFO] testing-core ....................................... SKIPPED
[INFO] testing-junit4 ..................................... SKIPPED
[INFO] testing-junit5 ..................................... SKIPPED
[INFO] string-reverse ..................................... SKIPPED
[INFO] regex-query ........................................ SKIPPED
[INFO] async-thumbnails ................................... SKIPPED
[INFO] fdk-examples ....................................... SKIPPED
[INFO] integration-tests .................................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 41.312 s
[INFO] Finished at: 2018-06-25T03:39:25+00:00
[INFO] Final Memory: 74M/497M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project fn-spring-cloud-function: Could not resolve dependencies for project com.fnproject.fn:fn-spring-cloud-function:jar:1.0.63: Could not find artifact com.fnproject.fn:testing:jar:1.0.63 in spring-milestones (https://repo.spring.io/milestone) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :fn-spring-cloud-function
Exited with code 1

Hi - I rebased this onto a branch I made updating all the dependencies - new PR is here: https://github.com/fnproject/fdk-java/pull/144

We can close this one, working on #144 and #145 ff.


Reduces "as3XXXX is undefined/null" errors

Reduces amount of "as3XXXX is undefined/null":

'TypeError: this.as3Object is undefined' when custom constructor checks if object is called from the attachMovie
'TypeError: this.as3Object is undefined' or 'this.as3ObjectOrTemplate is undefined' via refactoring to take custom object deep hierarchy in account
'TypeError: as3Offsets is null' by fixing perlinNoise
'TypeError: as3Stage is undefined' properly setting stage for AVM1 movies loaded from AS3

/botio test

I added quite a bit of comments below. In general I think it would greatly simplify the implementation if the AVM1 builtins could always assume that they have a native (i.e., AVM2) object as their backing store. This could be done by implementing a nativeObject getter that either returns the AVM2 object or a null object that just behaves like one, but essentially just swallows all input.

Reviewed 12 of 12 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 9 unresolved discussions, all commit checks successful.

src/avm1/interpreter.ts, line 902 [r1] (raw file):
I guess this is the one place where hasAS3ObjectReference as a method would be more complicated. But that can be solved with a check for the method's existence.

src/avm1/lib/AVM1Globals.ts, line 313 [r1] (raw file):
What happens here and for all other uses of getAS3Object if this isn't a real display list instance? It throws, right? Would it make sense to return a dummy instance that implements the same interface as the real as3Object but with all methods just doing nothing? Also, and independently, should we have an AVM1Utils.resolveAS3Target<T extends flash.display.DisplayObject>(context): T? There are lots of callsites that do exactly that, but in two calls instead of one.

src/avm1/lib/AVM1MovieClip.ts, line 371 [r1] (raw file):
I just tested: this should just return undefined. (Preexisting, but might just as well fix it while you're here.)
It also returns undefined when called on a non-display list object. E.g. MovieClip.prototype.getBounds.call({}) == undefined.

src/avm1/lib/AVM1MovieClip.ts, line 420 [r1] (raw file):
Same here.

src/avm1/lib/AVM1MovieClip.ts, line 573 [r1] (raw file):
Won't these all throw for non-display list objects?

src/avm1/lib/AVM1Utils.ts, line 54 [r1] (raw file):
Why did you turn this from a method to a function? It makes more sense to me to have it be a method. Also, no way of calling it with something that's not of the right type that way.

src/avm1/lib/AVM1Utils.ts, line 58 [r1] (raw file):
Can you add a doc comment explaining what this is for? It's far from self-explanatory, and quite important.
With "template" you essentially mean a dummy object, right? If so, the name isn't ideal, because it's not something that can be used to create an actual instance. "Dummy" or "Placeholder" would make more sense.
Also, I don't think this needs to be part of the function name: as far as the AVM1 implementation of the builtin methods is concerned, it's an implementation detail. Perhaps getNative? (That'd work much better if this function were a method, which I would prefer for other reasons anyway. See the comment for getAS3Object.)

src/avm1/lib/AVM1Utils.ts, line 62 [r1] (raw file):
s/a ASObject/an ASObject/
Also, it doesn't really explain what's going on here. I guess a good comment for the whole function should solve that, though.

src/avm1/lib/AVM1Utils.ts, line 277 [r1] (raw file):
Do we really need the isNullOrUndefined here? Why not just this._as3Object ? this._as3Object.name : undefined? _as3Object is guaranteed to be an object if it exists at all.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 8 unresolved discussions, all commit checks successful.

src/avm1/interpreter.ts, line 902 [r1] (raw file):
avm1IsTarget shall be refactored to not rely on  Lib.hasAS3ObjectReference. I'm keeping using isAVM1Instance just to continue pass tests.

src/avm1/lib/AVM1Globals.ts, line 313 [r1] (raw file):
It would throw, yes. We must be careful about use dummy as3Object, I'll investigate that later. resolveAS3Target must be refactored.

src/avm1/lib/AVM1MovieClip.ts, line 371 [r1] (raw file):
out of scope of this PR

src/avm1/lib/AVM1MovieClip.ts, line 573 [r1] (raw file):
Yes, I'll investigate that later.

src/avm1/lib/AVM1Utils.ts, line 54 [r1] (raw file):
We cannot use any methods/properties of the object until it's constructed using attachMovie -- that was the reason of the as3Object/as3ObjectOrTemplate error messages. The methods or properties must be attached to the object in the prototypical chain only when constructed by attachMovie and state shall be saved there (instead of intermediate link)

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

src/avm1/lib/AVM1MovieClip.ts, line 371 [r1] (raw file):
Yes, but will be forgotten - or you can just delete the line and write return undefined; ;) (And no, I'm not generally advocating for making unrelated changes. This one isn't really unrelated, as it would also fix a reason for throwing under superficially similar instances. Also, it's very, very simple.)

src/avm1/lib/AVM1Utils.ts, line 54 [r1] (raw file):
I'm not sure I agree. That depends on what exactly you mean by "we cannot use [..]". They certainly exist and are callable, and don't throw. The methods exist on instances created with, e.g., new MovieClip() and can be called. They just don't do anything.
For all uses of getAS3Object, getAS3ObjectOrTemplate, and _as3Object, we should return a lazily created dummy object that has all the right methods, none of the properties (because they're all just undefined until you set them to something in AS1/2), and where the methods do nothing. Then there's no need to ever do any checking.

Comments from the review on Reviewable.io

/botio test

Review status: 11 of 17 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io

Nice, thank you. r=me with the feedback on comments addressed.

Reviewed 6 of 6 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

src/avm1/lib/AVM1Utils.ts, line 51 [r3] (raw file):
Can you add something like "Returns false for MovieClip instances or instances of constructors with MovieClip on their prototype chain that were created in script using, e.g., new MovieClip(). Those lack the part of their internal structure that makes them displayable."
Without that, the comment only states what the function name already explains.

src/avm1/lib/AVM1Utils.ts, line 58 [r3] (raw file):
Either change "object" to "obj", or rename the parameter.

src/avm1/lib/AVM1Utils.ts, line 66 [r3] (raw file):
Same here.

src/avm1/lib/AVM1Utils.ts, line 68 [r3] (raw file):
"If the reference doesn't exist, obj was created in script, e.g. with new MovieClip(), and doesn't reflect a real, displayable display object. In that case, an empty null-proto object is created and returned. This is used for classes that are linked to embedded symbols that extend MovieClip. Their inheritance chain is built by assigning new MovieClip to their prototype. When a proper, displayable, instance of such a class is created via attachMovie, initial values for properties such as tabEnabled can be initialized from values set on the template object."

Comments from the review on Reviewable.io


Create 0000-01-02-YOUR-USERNAME.md

layout: slide
title: “Welcome to our second slide!”
Your test
Use the left arrow to go back!

TEST test TEST


[admin] Update index.md

update broken links

Docs Build status updates of commit fe6363c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/index.md
:warning:Warning

Details

Skype/index.md

Line 1, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Overview card & chart titles

Rename AWS and Azure card titles. Replace "&" with "and".
Fixes https://github.com/project-koku/koku-ui/issues/1180 and https://github.com/project-koku/koku-ui/issues/1179

Codecov Report

Merging #1181 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   75.43%   75.43%
=======================================
  Files         229      229
  Lines        4421     4421
  Branches      836      836
=======================================
  Hits         3335     3335
  Misses        968      968
  Partials      118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbaf58...690f82c. Read the comment docs.


Add gpt4-vision feature.

Hello, @lvmax1998. As I see, there is no history for user messages. It gets cleaned when the "done" function is called here. But what if it is not called or an error occurs? In that case, the content will still be here.
https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L150
Also, on the other hand, what do you think about moving a variable from the global scope?
https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L16C13-L16C13

Hello, I hope you're doing well! First of all, I want to thank you for your valuable suggestions. They are incredibly helpful! I've decided to implement your suggestions by adding a history conversation feature, allowing users to review previous dialogues. It's going to be so convenient! Additionally, I will modify the scope of the message variable to make it more flexible. This is fantastic!
By the way, I have a question. Why can't I see your comments on this pull request? (Please forgive my newbie mistakes when I first started contributing).
Add gpt4-vision feature. by lvmax1998 · Pull Request #395 · karfly/chatgpt_telegram_bot (github.com)?
Well, that's all for now! Looking forward to hearing from you!
Sent from Mail for Windows
From: Igor Udot
Sent: 2023年11月22日 16:28
To: karfly/chatgpt_telegram_bot
Cc: lvmax1998; Mention
Subject: Re: [karfly/chatgpt_telegram_bot] Add gpt4-vision feature. (PR #395)
Hello, @lvmax1998. As I see, there is no history for user messages. It gets cleaned when the "done" function is called here. But what if it is not called or an error occurs? In that case, the content will still be here.
https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L150
Also, on the other hand, what do you think about moving a variable from the global scope?
https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L16C13-L16C13
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

I think it's because I used comments in the code instead of starting a review or something like this.


Add: BRICS Africa Channel

Channel Name
BRICS Africa Channel
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
ZA
Subdivision (optional)
No response
City (optional)
No response
Broadcast Area
c/ZA
Languages
eng
Categories (optional)
general
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
No response
Logo
https://admango.cdn.mangomolo.com/analytics/uploads/188/666abcee75.jpeg
Notes
No response

Are you sure it's not South African channel?

Are you sure it's not South African channel?

It's broadcast on StarSat, and according to them "StarSat is a South African direct broadcast satellite " and is also available here: https://freevisionplay.co.za/live/394/BRICS-Africa-Channel.


fix Cannot find module when import ResourceType in server from public folder

Description
Solution:
Moved the shared enum ResourceType between server and public to common folder
Category
Bug fix
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
https://github.com/opensearch-project/security-dashboards-plugin/issues/1704
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hi @ruanyl , thanks for taking this on. Could you also fix the lint? https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/7306997494/job/19912250179?pr=1705#step:5:22

Thank you @ruanyl. The reason this is showing now is because of an import added in server/routes/index.ts introduced in this PR: https://github.com/opensearch-project/security-dashboards-plugin/pull/1502
I will file an issue on this repo to run the CI with a build of OSD core + the security-dashboards-plugin so that these issues are caught when CI runs.

No custom admin password found. Please provide a password.

@derek-ho The CI for this PR is being impacted by the custom admin pw changes.

Merging this change. To catch these issue with CI, we should prioritize updating the Github worflows to create a build of OSD and run the build. https://github.com/opensearch-project/security-dashboards-plugin/issues/1709


Misleading error message when JDBC driver is not present

Description:
When a code with a endpoint mysql client is written upon execution it gives below error when the jdbc driver is not present in bre/lib directory.
error: ballerina/runtime:CallFailedException, message: call failed        at ..<stop>(dbconnection.bal:4) caused by error        at ballerina/mysql:stop(endpoint.bal:72)
This is a misleading error and should be updated to provide the proper message on Driver not Found.
Steps to reproduce:
Create a ballerina function which uses jdbc connection.
Run it without the jdbc driver in bre/lib directory
Affected Versions:
0.974.0
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):
improvement
Suggested Assignees (optional):

The above issue is solved in 0.975.0 and the new error log is
Exception occurred :error: ballerina/runtime:CallFailedException, message: call failed         at ..<init>(dbconnection.bal:4) caused by error, message: error in sql connector configuration:Failed to get driver instance for jdbcUrl=jdbc:mysql://xxxxxxxxxxxxx?useSSL=false         at ballerina/mysql:init(endpoint.bal:58)
Hence closing the issue.


Telemetry commands changed to use Kouros

GETTELEMETRYPROPERTY, SETTELEMETRYPROPERTY, START_TELEMETRY commands changed

고생많으셨습니다.

Will not merge this pull request for unknown error. Will merge the code via another pull request.


Long time until start

Maybe a feature more than a bug: It takes 40 seconds after the device is ready before the app is started. Can this be controlled?
Cheers,
Anders

The starting is triggered by android events "BOOT_COMPLETED" (or "USER_PRESENT" if the device is locked after the boot) and then your app is immediately launched. I think it is not possible to speed it up.

OK. At least it's an explanation :).
Thanks,
Anders

Also for me it is very slow.
On a Samsung J5 with Android 7.1.1. it takes around 2'22''
On a Samsung Tablet wiht Android 7.0 it takes around 40'
Still no way to speed it up?