Tray displays on bottom left of the screen

here is my config
`;=====================================================
;     File Includes
;=====================================================
[section/base]
include-file = /home/yakoot/.config/polybar/master.conf
include-file = /home/yakoot/.config/polybar/modules.conf
;=====================================================
;     Openbox Bars
;=====================================================
[bar/openbox-bar]
inherit = bar/master
; Use $ xrandr -q | grep " connected" | cut -d ' ' -f1
monitor =
modules-left   = jgmenu workspaces
modules-center = window_switch clock
modules-right  = xkeyboard pkg memory network volume
tray-position = right
tray-padding = 2
tray-background = ${root.background}
;=====================================================
;     i3 Bars
;=====================================================
[bar/i3-bar]
inherit = bar/master
; Use $ xrandr -q | grep " connected" | cut -d ' ' -f1
monitor =
modules-left   = jgmenu i3 menu
modules-center = clock
modules-right  = pkg memory temperature coreuse network volume
;=====================================================
;     Bspwm Bars
;=====================================================
[bar/bspwm-bar]
inherit = bar/master
; Use $ xrandr -q | grep " connected" | cut -d ' ' -f1
monitor =
modules-left   = bspwm menu
modules-center = clock
modules-right  = pkg memory temperature coreuse network volume
`

What's the output of polybar in the terminal?

➜  ~ polybar openbox-bar
warn: No monitor specified, using "HDMI-0"
error: Disabling module "xkeyboard" (reason: Missing parameter "module/xkeyboard.type")
warn: Systray selection already managed (window=0x0c0001f)

I've fixed all except systray warn
➜  ~ polybar openbox-bar warn: Systray selection already managed (window=0x0c0001f)

Hm, tray still displays after killing polybar

I found a problem, it's trayer, polybars displays tray after killing him

Yeah, that's what I thought ;)


eCAL: default to local mode

Currently, eCAL is by default installed in Cloud Mode. While this is benefitial for new Users (as it works out of the box), it may pose a problem when having many machines in the same network that don't even need to distribute traffic or accept topics from the outside.
Therefore, the default configuration should be changed to local mode.
Steps to do:

Change ecal.ini
Change documentation stating that you now must manually change the configuration back to cloud
Display some kind of error warning or notification in the eCAL Monitor

Fixed by #587


UI shouldn't show children of compound attributes

Connects to #1
Children of compound attributes cannot be deleted, so shouldn't be shown in the UI as they can't be reordered. Only the compound attribute can be moved around.

Fixed by #3 already.


clicking a task should show a conversation: who did what.

Expected behaviour
When I click a task on the board, as a member of multi member team I would like to see a sort of activity stream that shows who did what when. Actually what is shown in github when I click on an issue.
Actual behaviour
Currently when I click an item on the board I see the (read only) summary. In order to edit an item (e.g. to add some comments or report the work I did) I have to click task number and select edit description.
Also the current activity stream shows mainly info on what happend to the task itself, and much less clearly what happend wrt to the topic that the tasks covers.
Configuration

Kanboard version: 2.0.26

So when I click an item on the board I would like to see something like the following screenshot:

Oh, only now I see that you can add comments. Please close this record :-)


Tag for blog

Is your feature request related to a problem? Please describe.
We should have a tag filed in our blog in which we can add one or more tags related to the blog. I am requesting for this feature because in the future we will add feature of filtering blogs by tags.

@harsh-9in ,I am interested in working on this issue. Can you assign it to me?

Hey @harsh-9in I want to work on this..

@ManishShah120  I am assigning this issue to you.
@kritikaparmar-programmer you can refer issue #154.

You both can discuss the approach for solving issues because they are interconnected to each other.

@kritikaparmar-programmer ping me on #154 I will assign that to you.


Add stride to restake

Add stride to restake

add Crescent to restake

https://github.com/eco-stake/validator-registry/pull/1948


withOptions doesn't affect Storybook v5

Describe the bug
Adding addon-options decorator has no effect on the storybook
To Reproduce
Steps to reproduce the behavior:

Create a CRA2
Add v5 addons and storybook/react (5.0.0-beta.3 for addons and 5.0.0-rc.1 for storybook/react)
Add addDecorator(withOptions({ name: "FooBar", ... }))
Observe

Expected behavior
Options change as they do in Storybook v4
Code snippets
addons.js
import '@storybook/addons';
import '@storybook/addon-actions/register';
import '@storybook/addon-knobs/register';
import '@storybook/addon-links/register';
import '@storybook/addon-options/register';
import 'storybook-readme/register';

config.js
import React from 'react';
import { configure, addDecorator } from '@storybook/react';
import { withKnobs } from '@storybook/addon-knobs';
import { withInfo } from '@storybook/addon-info';
import { withOptions } from '@storybook/addon-options';

const styles = {
  display: 'flex',
  alignItems: 'center',
  justifyContent: 'center',
  border: '1px solid rgb(238, 238, 238)',
  padding: 100
};
const CenterDecorator = (storyFn) => (
  <div style={styles}>
    { storyFn() }
  </div>
);

// ❌ doesn't work in v5
addDecorator(
  withOptions({
    name: 'Ringa roll'
  })
);

// ✅ Work fine
addDecorator(CenterDecorator);
addDecorator(withKnobs);
addDecorator(withInfo(
  {
   inline: true,
   header: false,
  }
));

function requireAll(requireContext) {
  return requireContext.keys().map(requireContext);
}

function loadStories() {
  requireAll(require.context("../src", true, /\.story\.jsx?$/));
}

configure(loadStories, module);

@shilman - I think the new recommended API is:
addParameters({
  options: { ... }
});

But we should definitely keep back-compat, perhaps with a deprecation warning, and do we need to update the dos/migration guide too?

Thanks so much, this is a great bug! I'm able to reproduce and will fix.
Here are some notes:
The addon is receiving the event as expected. However the call to api.setOptions inside the addon is apparently failing in v5. Looking into this now and hopefully will be an easy fix.
Also, here are some side comments to you @Rolandisimo:

You should generally use the same version of Storybook packages, i.e. if you're using<EMAIL_ADDRESS>you should also use<EMAIL_ADDRESS>That wasn't the problem in this case--this is a nice juicy bug, but I just wanted to say it again because this is the second issue you've filed with a version mismatch like that.
withOptions is deprecated in favor of addParameters. You'll see this if you look in the browser console. That said, it should still work.

@shilman Thanks a bunch for looking into this.
Regarding the comments:

You're absolutely right. Will note that. However, that felt like an easy inconsistency to run into. Thus, if this is important, I believe it should somehow be stressed more visibly to any newcomer. (especially newcomer)
Yes, a discrepancy I noticed several times. For example, here https://www.npmjs.com/package/@storybook/addon-options, the documentation uses withOptions.

Looking forward to the fix! 👍🎉

@Rolandisimo
Note: This is only about the theme, not the other configurable things in the option addon
In 5.0, name is not configurable via the options addon. If you want to adjust the Storybook name, as it appears in the top left corner of the UI, take a look at using brand via a theme file. This allows you complete control to pass an svg(use template literals) or a string.
https://github.com/storybooks/storybook/blob/next/lib/theming/src/themes/light.ts#L38

Can we get back-compat on this or is it too hard @domyen?

@tmeasday We can, but I'm not sure passing name and url via params is an API we want to support in the future.
Building this into the UI logic results in at least 6 permutations of the brand area (top left) to test and maintain. The new brand is intended to be open ended to avoid this.
@Hypnosphi had some good feedback 🙏, but I don't think we came to a conclusion.
What do you think?

We can, but I'm not sure passing name and url via params is an API we want to support in the future.

Usually if we want to remove something we have a major release of deprecation (where we continue to support it but warn users about it). Not critical in this case but I would suggest better.

Building this into the UI logic results in at least 6 permutations of the brand area (top left) to test and maintain

So now the only option is either the default or a custom component? I feel like it's a pretty common use case to just want to change the title, seems a pity to make this hard for people.
I think @Hypnosphi's main feedback was the brand option on the theme should be something renderedable rather than an element (something rendered). i.e. () => <x> rather than <x> and should get passed the title and url. I think that makes sense.

I'm kinda on-board with @tmeasday regarding not liking over-complication of the simple action of changing a name of the storybook. My vote would be to be user-focused. It's not about a slick pipeline or 200ms faster compilation, but rather the ease of adoption of a tool. Maybe I'm missing the big picture, but these are my 2 cents.

@Rolandisimo have a PR open for this from a theme POV. Will work with @tmeasday to hook it up to params. 👍

Ooh-la-la!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.7 containing PR #5773 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.
Closing this issue. Please re-open if you think there's still more to do.


[Dialog][Enzyme] mount not render inner components, stops on

Problem description
I created component with <Dialog /> and I want to test it with enzyme, but when I mount component (with muiTheme context) I can't find inner components (action buttons etc.).
console.log with wrapper.debug() shows:
<NetworkError open={true} close={[Function]}>
  <Dialog open={true} contentStyle={{...}} title="Network Error" actions={{...}} autoDetectWindowHeight={true} autoScrollBodyContent={false} modal={false} repositionOnUpdate={true}>
    <RenderToLayer render={[Function]} open={true} useLayerForClickAway={false} />
  </Dialog>
</NetworkError>

when original component is:
export default function NetworkError(props) {
  const { open, close } = props;
  const actions = [
    <FlatButton
      label="Cancel"
      primary={true}
      keyboardFocused={true}
      onTouchTap={close}
    />,
  ];
  return (
    <Dialog
      open={open}
      title="Network Error"
      actions={actions}
    >
      Ups! It seems that we have some problems with network, try again later.
    </Dialog>
  );

So it looks like it stops on RenderToLayer and not render anything deeper (especially not render action buttons). I tried to mount it with this helpers described here: https://github.com/callemall/material-ui/issues/4664 but it didn't help.
Versions

Material-UI: ^0.16.7
React: ^15.4.2
Enzyme: ^2.7.1

👍 I'm also experiencing this issue. For some reason it looks like the Dialog body/children is being passed in a wrapped function as props.render to RenderToLayer instead of directly as child nodes?

I checked out in DOM that things like Dialog, Popup or Menu Drop are rendered on special anchor outside of component, so it's not possible to get i.e. Dialog inside wrapper - it's rendered somewhere else in DOM.
I wonder if there is any way (even via javascript API like document.queryselectorall) to get this Dialog component and simulate click or smth.

I had to attach the component to a DOM element (via mount's attachTo option) in order to make components with Dialogs testable...
Here's a rough example as to how I did it

Thanks for sharing your workaround @aryo 😄
Perhaps a good solution for this would be to add an option to (the props of?) the Dialog component which when true casuses it to render it's children internally?

Is there any way to test this in v1.0.0?

I got it working using shallow rendering and then using wrapper.dive()

Closing this issue for #7970

Not sure if that's exactly what is the problem here, but I've had similar problem and this worked:
import { DialogActions, Button } from 'material-ui';

/* Component has a <Dialog /> with a set of action buttons defined inside as children */
const component = shallow(<Component />);
const dialogActions = component.find(DialogActions);
const okButton = [ ...dialogActions.find(Button) ].find(e => e.props.raised);
const actionFunction = okButton.props.onClick;

/* ... */


Clean the code

Hi, @d-silveira.
Your project is good. I made this PR and hope you will merge it.
The purpose of this PR is cleaning code:

removed unused variables;
removed redundant initialisations;
some methods divided to several small.

thanks


[UI-Fix] - Settings bottom padding missing

What ❓

Fixed the Rate us container dimens to final specs with @dannyalright.
gave it grid_12 marginBottom.

Story 📖
[Settings bottom padding missing](https://trello.com/c/BpDfHKNH/1110-settings-bottom-padding-missing
See  👀

 Settings bottom padding missing

Is it possible for you to add before and after screenshots? I don't always know what I should be looking for 🕵♀

@eoji I added the screenshot to the description.


Parser.RotateLeft is unintuitive

Parser.RotateLeft "rotates" the current node to the position of it's parent but the parent then just gets appended to the children of the current node. This results in the previous parent being on the rightmost child position of the current node even though this is a left rotation.
Before left rotation of A2:
graph TD;
    A-->A1;
    A-->A2;
    A2-->A2-1;
    A2-->A2-2;

After left rotation of A2:
graph TD;
    A2-->A2-1;
    A2-->A2-2;
    A2-->A;
    A-->A1;

I would expect it to result in this tree:
graph TD;
    A2-->A;
    A2-->A2-1;
    A2-->A2-2;
    A-->A1;

@superfrink Could you explain a bit more about the use case when you created this?

Agreed, the diagram would be expected to look like you show.  🤔
RotateLeft was used in an example calculator program that did not make it into a PR.  It was used to manipulate the tree to support order-of-operations.
https://github.com/superfrink/lexparse/blob/231231-example-calc/examples/calc/calc.go
RotateLeft has a couple small differences between that branch and the main branch but they look like don't change the shape of the tree.  (Error checking and the case where the root node needs to be updated.)
If the tree is not as expected then it seems like it should be possible to write a test case where the calculator does not work.

On input 1 + 2 + 3 the steps of the parsing look like
Read 1:
graph TD;
    1;

Read +:
graph TD;
    1-->+;

Rotate so + is the parent of 1:
graph TD;
    +-->1;

Read 2:
graph TD;
    +-->1;
    +-->2;

On input 1 * 2 + 3 after reading + and before RotateLeft it looks like:
graph TD;
    *-->1;
    *-->2;
    *-->+;

After RotateLeft it looks like this:
graph TD;
    +-->*;
    *-->1;
    *-->2;

And then after reading the 3 it looks like this.  Oh, no this isn't correct.  Mermaid is moving the 3 to look like the first child.  The 3 is the second child of +.
graph TD;
    +-->*;
    *-->1;
    *-->2;
    +-->3;

This is the output from printTreeNodes(0, tree.Root) in calc.go:
 [*lexparse.Node[main.calcToken]] Value: [main.calcToken]  {Type:0 Value:}
  [*lexparse.Node[main.calcToken]] Value: [main.calcToken]  {Type:2 Value:+}
   [*lexparse.Node[main.calcToken]] Value: [main.calcToken]  {Type:1 Value:*}
    [*lexparse.Node[main.calcToken]] Value: [main.calcToken]  {Type:3 Value:1}
    [*lexparse.Node[main.calcToken]] Value: [main.calcToken]  {Type:3 Value:2}
   [*lexparse.Node[main.calcToken]] Value: [main.calcToken]  {Type:3 Value:3}

@superfrink Ok, I think we're mostly on the same page. I was actually implementing an example calculator on #36 very similar to your example here and I ran into this when trying to use RotateLeft. I'll see if I can prepare a concrete change that makes sense and ask you to review the PR.

Oh, no this isn't correct. Mermaid is moving the 3 to look like the first child. The 3 is the second child of +.

Seems like this has been a long standing issue in Mermaid -> https://github.com/mermaid-js/mermaid/issues/815

The existing RotateLeft could be better named something like BecomeParentOfParent or MoveUpTree or AdoptParent.  Or maybe there is a better pattern than doing it this way.

Is there a reason to keep the current implementation? I don't think we really need to worry about backwards compatibility.

We don't need to keep RotateLeft.  The only place it was used was in that example calculator (and it was never merged).


Adopting flox as a "true" optional dependency?

Addressing a Problem?
xclim could benefit from faster/more optimized implementations wherever it is possible.
Potential Solution
The flox module has been proposed as a way to optimize grouping/reducing operations. We should investigate where its implementation could be useful and add flox as an optional dependency if it's worth it.
Additional context
No response
Contribution

[X] I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closing until the situation changes, and we require flox.


no way to discover constructors from Class model

You can do things like ClassOrInterface.getAttributes or ClassOrInterface.getMethods, but there is no way to discover Constructors - you have to know the name in advance and use Class.getConstructor.

See #718. Given that proposal to resolve this issue we could add a getConstructors() to ClassModel which would return a FunctionModel|ValueModel[] refined to return a Function|Value[]  on Class and Method|Attribute[] on MamberClass. I'm not entirely sure whether this should include an element for the default constructor, but I'm inclined to think not (since the Class or MemberClass already represents that).

The natural way for the model loader to load constructors if for it to find the java constructors. But for a value constructor the java constructor should be private (you get the instance from the getter). But it turns out that the ClassMirrors behave differently for javac and reflection versions: JavacClass.getDirectMethods() excludes private methods and constructors, but ReflectionClass includes them (because they're needed in order to support local declarations).
It seems to me that it's simply wrong for the mirror implementations to behave differently -- the inclusion of exclusion of private members should be part of the mirror contract, and that worrying about private members should be a concern of the model loader itself rather than the mirrors. Unfortunately including private members for the JavacClass opens a load of other bugs...

But why would you want the JavacClass to return private members? It's only used by the compiler backend which does not care about private stuff.
AFAICT you only care about them at runtime in the metamodel, which does not use that, but uses ReflectionClass which will return them, so you're good, no?

I had thought that the right API for this was to add
shared formal Sequential<FunctionModel<Type, Arguments>|ValueModel<Type>> getDeclaredConstructors
        <Arguments=Nothing>
        (ClosedType<Annotation>* annotationTypes)
            given Arguments satisfies Anything[];

to ClassModel, but I now realize that doesn't quite work. We usually use the <Arguments> type argument as a filter to find only things with a given argument list tuple type. But because the above API lumps callable constructors and value constructors together (and value constructors don't have argument lists), it doesn't work in an intuitive way. I suppose you could exclude the value constructors unless Arguments=Nothing.
I suppose it's OK to split the method in two, one to get matching callable constructors and another to get matching value constructors. That has the additional benefit of giving the method a for useful return type.

No parameter list is a parameter list of type Null, surely?
Sent from my iPhone

On 14 Sep 2015, at 16:07, Tom Bentley<EMAIL_ADDRESS>wrote:
I had thought that the right API for this was to add
shared formal Sequential<FunctionModel<Type, Arguments>|ValueModel> getDeclaredConstructors
<Arguments=Nothing>
(ClosedType* annotationTypes)
given Arguments satisfies Anything[];
to ClassModel, but I now realize that doesn't quite work. We usually use the  type argument as a filter to find only things with a given argument list tuple type. But because the above API lumps callable constructors and value constructors together (and value constructors don't have argument lists), it doesn't work in an intuitive way. I suppose you could exclude the value constructors unless Arguments=Nothing.
I suppose it's OK to split the method in two, one to get matching callable constructors and another to get matching value constructors. That has the additional benefit of giving the method a for useful return type.
—
Reply to this email directly or view it on GitHub.

OK, we end up with given Arguments satisfies Anything[]?, but it all makes sense.

Oh, except:
[ceylon-compile] /home/tom/ceylon/ceylon.language/src/ceylon/language/meta/model/ClassModel.ceylon:68: error: the 'SupertypeVisitor' caused an exception visiting a 'TypeConstraint' node: '"java.lang.RuntimeException: getSupertypes() not defined for union types or Nothing"' at 'com.redhat.ceylon.model.typechecker.model.Type.getSupertypes(Type.java:1370)'
[ceylon-compile]                 given Arguments satisfies Anything[]?;
[ceylon-compile]                 ^
[ceylon-compile] /home/tom/ceylon/ceylon.language/src/ceylon/language/meta/model/ClassModel.ceylon:68: error: upper bound must be a class, interface, or type parameter
[ceylon-compile]                 given Arguments satisfies Anything[]?;
[ceylon-compile]                                           ^
(i.e. an exception thrown in the tc, and using Null can't work, I love Mondays).

 Damn!

Heh. Can you report the exception please?

I've implemented this for the JVM, awaiting implementation on JS.

@tombentley why on Earth does getDeclaredValueConstructors() return a no-arg callable constructor?

So this causes CCE:
class Outer {
  class Inner {
    shared new(){}
    shared new otro(){}
    shared new valor{}
  }
  shared void test() {
    value inner=`Inner`;
    for (cv in inner.getValueConstructors()) { //this causes CCE
      print(cv);
    }
  }
}

this is because getValueConstructors incorrectly includes callable constructors with no arguments.

Well spotted @chochos -- the test was wrong so I'd written a callable ctor when I meant to by testing with a value ctor. So there's both now, and it should be fixed.


Web - Distance - The app starts flashing when any changes are made as the admin.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition:
Create IOU with the receipt as employee

Log in as the workspace admin
Navigate to the workspace chat with the employee
Navigate to the request conversation and fix the errors as the admin

Expected Result:
The admin can edit the missing information, and everything should work normally
Actual Result:
The app starts flashing when any changes are made as the admin
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/6d50bfdc-445a-4484-8936-636ac70fa107
View all open jobs on GitHub

Issue is not reproducible in production
https://github.com/Expensify/App/assets/93399543/70098366-a8f2-492f-add2-358b0dbd779e

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

The PR that caused this got reverted. Closing out.


Security pin

what is security pin and how can we set our own i tried  ota_pin as pin
and tried setpin function to set both didnot worked  for me

Here is small doc about security: https://github.com/vovagorodok/ArduinoBleOTA/blob/main/doc/SECURITY.md
From doc You can see that there are two options to provide a security by disabling/enabling uploads (using button/switch for example) or set a pin code. See:

because You set pin code before

because You set pin code before

by security.setpin(12345) ???
without this code also it ask for pin  and  pin 12345 also not work

As I remember Nim-Ble stack requires exact 6 digits pin. Try 123450 or 012345
Proposed to use ble_ota_app to change pin

Renamed a bit from pin to pin code

how to run these examples on arduino ide is there any possibility to make them compatible with arduino ide

I'm PlatformIO user, for me easier to just add to my project:
build_flags =
	-D USE_NIM_BLE_ARDUINO_LIB
lib_deps =
	https://github.com/vovagorodok/ArduinoBleOTA

I have plans to add this library to PlatformIO Hub and prepare it to work in Arduino IDE.
But for this moment there is one small issue that should be solved with non NimBle part of this library.
I hope this month I'll done all of that

Created issue in order to remember about it: https://github.com/vovagorodok/ArduinoBleOTA/issues/37

Library available at ArduinoIDE as vovagorodok_ArduinoBleOTA.
And at PlatformIO as:
build_flags =
	-D USE_NIM_BLE_ARDUINO_LIB
lib_deps =
<EMAIL_ADDRESS>

Library available at ArduinoIDE as vovagorodok_ArduinoBleOTA. And at PlatformIO as:
build_flags =
	-D USE_NIM_BLE_ARDUINO_LIB
lib_deps =
<EMAIL_ADDRESS>

Arduino ide generated bin file new version not updated using ble app it show 100 % but software not updated
flashed program
`#include <ArduinoBleOTA.h>

#define DEVICE_NAME "Esp32 Ble"
#define HW_NAME "Esp32 HW"
#define HW_VER {1, 0, 0}
#define SW_NAME "Esp32 SW"
#define SW_VER {1, 0, 0}

#define BUZZER_PIN 15  // Buzzer Pin

unsigned long previousMillis = 0;
const long interval = 1000; // Interval for buzzering
bool isBuzzing = false;

void setup() {
  Serial.begin(9600);
  ArduinoBleOTA.begin(DEVICE_NAME, InternalStorage, HW_NAME, HW_VER, SW_NAME, SW_VER);
  Serial.println("Buzzer test");
  pinMode(BUZZER_PIN, OUTPUT);
}

void loop() {
  BLE.poll();

  unsigned long currentMillis = millis();

  if (currentMillis - previousMillis >= interval) {
    previousMillis = currentMillis;

    if (isBuzzing) {
      noTone(BUZZER_PIN);
      Serial.println("Buzzering stop");
    } else {
      tone(BUZZER_PIN, 1000);
      Serial.println("Buzzering");
    }

    isBuzzing = !isBuzzing; // Toggle the buzzing state
  }
}
`

updating over ble new program

#include <ArduinoBleOTA.h>
#define DEVICE_NAME "Esp32 Ble"
#define HW_NAME "Esp32 HW"
#define HW_VER {1,0, 0}
#define SW_NAME "Esp32 SW"
#define SW_VER {1, 1, 0}

#define RELAYPIN 4

unsigned long previousMillis = 0;
const long interval = 1000; // Interval for Relay
bool isRelayON = false;

void setup() {
  Serial.begin(9600);
  ArduinoBleOTA.begin(DEVICE_NAME, InternalStorage, HW_NAME, HW_VER, SW_NAME, SW_VER);
  Serial.println("Relay test");
  pinMode(RELAYPIN, OUTPUT);
}

void loop() {
  BLE.poll();
    unsigned long currentMillis = millis();

  if (currentMillis - previousMillis >= interval) {
    previousMillis = currentMillis;

    if (isRelayON) {
      digitalWrite(RELAYPIN,LOW);
      Serial.println("Relay OFF");
    } else {
      digitalWrite(RELAYPIN,HIGH);
      Serial.println("Relay ON");
    }

    isRelayON = !isRelayON; // Toggle the Relay state
  }
}

the bin file i used is programname.ino.bin


Add vtkPDALReader

F3D is great to visualize point-cloud but supports a limited number of file formats.
VTK has a PDAL wrapper that could be integrated easily in F3D as long as the VTK IOPDAL module can be easily built.
PDAL supported file formats: https://pdal.io/stages/readers.html#readers
VTK IOPDAL module: https://gitlab.kitware.com/vtk/vtk/-/tree/master/IO/PDAL

related to #38

Sure go ahead. Note that this one should be more challenging, but feel free to reach out on discord if you need pointers.

@gapry any news on this ?

No worries!


Loop detection in graph is missing

Something like this will result in an infinite loop and should be forbidden

Visual shader disables this while it is possible for visual script. I'll try to ask chaosus about it.


Update doc/ca.pod to clarify description for dates

"Note" part is based on PR #3566

Checklist

[x] documentation is added or updated

commit updated. @FdaSilvaYY

updated: change 'presented' to 'present'

Let'e ping @openssl for an OMC approval.

updated based on @richsalz 's comments.

Delete 'version' to follow #3938

Please re-confirm, @kaduk @richsalz

reconfirm
--
Senior Architect, Akamai Technologies
Member, OpenSSL Dev Team
IM<EMAIL_ADDRESS>Twitter: RichSalz
From: Paul Yang<EMAIL_ADDRESS>Sent: Saturday, July 15, 2017 3:53 PM
To: openssl/openssl<EMAIL_ADDRESS>Cc: Salz, Rich<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [openssl/openssl] Update doc/ca.pod to clarify description for dates (#3895)
Please re-confirm, @kadukhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kaduk&d=DwMCaQ&c=96ZbZZcaMF4w0F4jpN6LZg&r=4LM0GbR0h9Fvx86FtsKI-w&m=hGm4ixbwKn2oEepu8x7jwWG1Bjsw3XGFtMOl766OxWQ&s=zSUR0WVbEj2KetBEgrqYh5MxhMhJoFUdKQcdUHUyaDo&e= @richsalzhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_richsalz&d=DwMCaQ&c=96ZbZZcaMF4w0F4jpN6LZg&r=4LM0GbR0h9Fvx86FtsKI-w&m=hGm4ixbwKn2oEepu8x7jwWG1Bjsw3XGFtMOl766OxWQ&s=33XI_vD7hc8KSicgnHeRjnvOX1UP8nMXxHCl6inyDdI&e=
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openssl_openssl_pull_3895-23issuecomment-2D315535372&d=DwMCaQ&c=96ZbZZcaMF4w0F4jpN6LZg&r=4LM0GbR0h9Fvx86FtsKI-w&m=hGm4ixbwKn2oEepu8x7jwWG1Bjsw3XGFtMOl766OxWQ&s=fmAFfw6hFEajfsQDWJTFLe1OSHVaJotVCnL7eXm2xI8&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AG-5FilL3luFQZQnji-5FMS-2Dr9xSLa3tRZHoks5sOMQhgaJpZM4OSIq5&d=DwMCaQ&c=96ZbZZcaMF4w0F4jpN6LZg&r=4LM0GbR0h9Fvx86FtsKI-w&m=hGm4ixbwKn2oEepu8x7jwWG1Bjsw3XGFtMOl766OxWQ&s=WE-2oLT13r3NnoclfkDcU0bsD5lIPk1sAHcwfKBdqCQ&e=.

looks like this could be merged now...

thank you!


add support for IHost

I added support for IHost to make this function on generic hosts as well as WebHost. I had to upgrade some of the packages to allow for compile.

Hi @thegreatco,
Thanks for the PR! However I can't accept it... As discussed in #16 and #17, I don't want to add support for IHost in this package.
This first problem is that it would mean referencing both Microsoft.AspNetCore.Hosting.Abstractions (and, indirectly, its dependencies) and Microsoft.Extensions.Hosting.Abstractions. That means ASP.NET Core users would import a package they don't need, and generic host users would import ASP.NET Core packages, which they also don't need.
The second problem is that IHost was introduced in 2.1, it's not available in 2.0. Supporting it would mean upgrading the packages, which would effectively drop support for ASP.NET Core 2.0 users. Which brings me to this:

I had to upgrade some of the packages to allow for compile.

The packages seem outdated, but that's on purpose. I reference the lowest possible version, so that people using ASP.NET Core 2.0 can use the library without having to upgrade their packages. If they already reference a more recent version, that's fine, that version will be used.
Anyway, I realize that support for IHost is useful; that's why I made a separate project: https://github.com/thomaslevesque/Extensions.Hosting.AsyncInitialization. At this point I only released an alpha, but it should work fine. I'll release a stable version soon, unless some bugs are reported.

Doh! Sorry about that, I should have done some more research!


In Client address form state, city and area code field needs update

Is your feature request related to a problem? Please describe.
In client address form following modifictions are required

state field should have dropdown containg states related to selected country. For instance if we select country as India, then state should have dropdown including all the states and UT of India.

City field should have dropdwon containing all the cities, realted to selected state. For instance, if we select state as Harayana, then   City should have dropdown including all the cities of Harayana.

Area code field should have area code based on selected city

Same procdeure should be followed if we select country other than india.

Not needed right now.


Fix delegateAddress type

The Delegate EIP712 payload was using bytes32 as the type for the delegate address (which is an Ethereum Address).
While this works, it represents the wrong input type and size constraints that we should accept for that field (an address is 20 bytes so any input bigger than that should not be valid).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 93.766%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
8242

Relevant Lines:
8790

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.798%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8243

Relevant Lines:
8788

💛  - Coveralls


Fix orphan deletion

fedv2 has been using the orphan finalizer in attempt to integrate with kube deletion policy.  This use of orphan proved problematic, though, since kube deletion policy is internal to a single cluster and the sync controller ends up racing with the gc (as per #622).  This PR switches to a new finalizer (federation.k8s.io/sync-controller) that ensures that deletion of federated resources will be visible to the sync controller and a new annotation (federation.k8s.io/orphan) in place of the orphan finalizer to indicate that managed resources should be retained on deletion of their managing federated resource.
Documentation of the new deletion policy and use of finalizers is included, as is a test of orphan deletion (superceding that proposed by #606).
Due to the finalizer change, this PR will break deletion of federated resources reconciled by previous versions of the sync controller.  It may be desirable to highlight this fact along with a workaround (e.g. kubectl patch command to remove the previous finalizers) in something like a changelog.
Fixes #622
cc: @yamt

I've also kicked off maintenance of a changelog for this PR (as discussed in this week's wg sync).

looks good to me. thank you.

@marun this looks good to me too.
I don't like the fact that we cannot use --cascade=false anymore; Does providing a delete via kubefed2 with this option make sense ?

@irfanurrehman I don't think we should duplicate deletion functionality from kubectl.  I am supportive of adding a command that would set or remove the annotation (e.g. kubefed2 enable-orphaning-deletion).

@irfanurrehman I don't think we should duplicate deletion functionality from kubectl. I am supportive of adding a command that would set or remove the annotation (e.g. kubefed2 enable-orphaning-deletion).

@marun Created https://github.com/kubernetes-sigs/federation-v2/issues/690

Just 1 minor comments above. The logic LGTM.

@marun please rebase and I will merge, thanks.

Rebased

/lgtm
/approve


Side slider get stuck over the Dashboard

When enable Keep always visible in the Side slider options it will happen instantly. I don't even have to press Save. If i then press the Dashboard it will tell me that i haven't saved my settings but i continue without saving. Now this Side slider get stuck over the Dashboard like this and it won't close:

The only way to get rid of the Side slider is to refresh the page.

This is intended as authentic preview changes immediately,  nevertheless it should go away if you don't  save.

Fixed. Thanks.

He ilia it's  eastern in western Europe and you are working?  I assume you are Russian orthodox and have easter next week (like my wife)? ;)

Yes we do. :wink:
Happy Easter!

When is Easter 2018 and how is the date decided?
This year Easter takes place from Good Friday on March 30 until Easter Monday on April 2 - making Easter Sunday fall on April 1, which is also April Fool's day.
The death of Jesus occurred around the Jewish Passover, which is traditionally held on first full moon following the vernal equinox.
As the full moon can vary in each time zone, the Church said that they would use the 14th day of the lunar month instead – the Paschal Full Moon – and host Easter Day on the following Sunday.
Once the date of the moon is known, Easter Day and the Easter holidays can be determined.


Introduce --rotate-external-peers flag to improve bootstrap client peering

Motivation
Currently, the bootstrap client connections fill up too quickly, making it cumbersome for new clients/provers to join the network. By letting bootstrap clients flush their peers more frequently, new clients have an opportunity to connect.
Naming nits are welcome, we can also go for:

--flush-external-peers
--evict-external-peers
--bootstrap-client

A complementary change would be to increase the number of bootstrap peers.
Why not just increase max peers with a --max-peers flag?

It does not fully solve the underlying problem, a bootstrap node with more peers can fill up just as well
It should be hard to mess up configuration for average joe. Having a larger number of peers has not been sufficiently tested and will likely lead to performance degredation, so if possible the option should not be available.
Also note that unfortunately doing this cleanly requires a lot of code changes because the existing MAXIMUM_NUMBER_OF_PEERS variable is a compile-time variable and tighly coupled with other logic. Probably because @ljedrz  mentions "~20 peers in a P2P setting being a desirable number is a popular notion".

Test Plan
After approval this should be deployed and tested.
Related PRs
Aims to tackle:

https://github.com/AleoNet/snarkOS/issues/2960
https://github.com/AleoNet/snarkOS/issues/3011
https://github.com/AleoNet/snarkOS/issues/3284

why not have a config file/cli commands with: an allowlist and denylist

I can see that being useful, though out of scope for this PR.

I'm in favor of peer rotation by bootstrappers, but we need to be cautious, as the heartbeat interval is currently only 25s, which may not provide enough time for the new peers to learn about others. I don't think we currently provide a list of peers as one of the initial post-handshake (OnConnect) actions, but we may want to do so now, at least for those that enable peer rotation.

Indeed, that's an issue. Letting the bootstrap peer send a PeerResponse uninvited will not be accepted by the counterparty, but we can let the counterparty send a PeerRequest: efd5ef0d2
The 4 existing bootstrap peers may relay 4*MEDIAN_NUMBER_OF_PEERS - 4 = 36 other clients, of which some hopefully are able to welcome the new client. If that's experimentally shown not to be sufficient, more (light-weight) bootstrap peers can be added to the bootstrap peer list.
Additionally, the client could choose to rotate not every heartbeat, but once every 10 heartbeats using if rand(..10) < 1, or if ledger.height % 10 == 0. But I feel its overcomplicating. What do you think?

Additionally, the client could choose to rotate not every heartbeat, but once every 10 heartbeats

I've considered this too; this certainly makes a lot of sense (assuming a 25s window IIRC) for peer shuffling, but this may also be useful for some other heartbeat activities that don't need to happen as often.

I've considered this too; this certainly makes a lot of sense (assuming a 25s window IIRC) for peer shuffling, but this may also be useful for some other heartbeat activities that don't need to happen as often.

2f7f799d6

One consideration is that this may affect syncing in a non-trivial way. More frequent disconnect + connections will likely slow down syncing.
One possible approach is if we can prevent the client from rotating clients if it is currently syncing. Though, this does not protect from the other side where the the node sending blocks.

One consideration is that this may affect syncing in a non-trivial way. More frequent disconnect + connections will likely slow down syncing.
One possible approach is if we can prevent the client from rotating clients if it is currently syncing. Though, this does not protect from the other side where the the node sending blocks.

Good callout. Given that bootstrap peers are never disconnected from, I don't think the "node sending blocks disconnecting" is a concern. But we should ensure bootstrap nodes (and even any client) to not disconnect when syncing. 7eac67f1c

@zosorock can you confirm if this has still been running succesfully on a bootstrap node? If so I think we can mark this ready to merge

@zosorock can you confirm if this has still been running succesfully on a bootstrap node? If so I think we can mark this ready to merge

Yes, it has been running on all 3 networks without any noticeable issues. I am of the opinion that one should not be syncing with a bootstrap node, especially given lots of people abuse them and connect dozens of times nonstop. I say rotate them often and make syncing with bootstrap nodes a wasteful endeavor.

Amazing. @zosorock noticed one more small improvement which should increase the frequency of disconnects: 9dccba419


error handling for gRPC reduce (and map) codepath

Today, we support only 1 type of error, and that is gRPC errors (there are no user-defined or initiated errors).
One could try to use gRPC retry to retry during an internal error. Looks like, to use this we have to maintain state since we deal with streams which can get seriously tricky if we are to introduce checkpoints.

[ ] looks into the gRPC errors and see what errors will affect us
[ ] check whether network errors are recoverable or not
[ ] once we have a good idea of the gRPC errors, we need to either implement error handling or we just have to document how we naturally recover

One can look into https://github.com/GuyLewin/grpc-bidirectional-streaming-error-handling, a sample code written in Java to simulate corner cases of our server-side stream.

So the proposal is to

Have a exception handling mechanism on the server side (in the SDK) that can catch any unhandled errors from udf and set the appropriate grpc status code and a detail with the exception serialized to a utf8 string.
On the client side, inspect the error and check

if its a status error (which indicates that this is a user code error)
if its not a status error, then it could be because the connection got terminated either because of server crashes or a network disruption.
have appropriate error translation and propagate status errors to the numa code, retry on communication error to see if the connection can be re-established.

Can we extend the error codes to support different kinds of acknowledgments, mainly NacK and Term? This can help users avoid intentional pod crashing to get it delivered.
Today the field num_delivered is managed by ISB, and it gets incremented when we have a numa pod restart causing the InProgress routines to be terminated.

Could we utilize the existing grpc-go retry feature for the numaflow-go client sdk to retry on certain errors https://grpc.io/docs/guides/error/#network-failures?
https://github.com/grpc/grpc-go/blob/master/examples/features/retry/README.md

Can we extend the error codes to support different kinds of acknowledgments, mainly NacK and Term? This can help users avoid intentional pod crash

We could define our own error types in a proto file similar to https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto

We could define our own error types in a proto file similar to https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto

I think custom metadata, etc. are something not all languages support. Writing other SDKs might get tricky.

we can definitely extend the error handling feature to support custom metadata. I will take that up in a different PR.

[ ] numaflow-python server sdk: return grpc error

[ ] numaflow-go server sdk: return grpc error (draft PR)

[ ] numaflow-go client sdk: handle error code and return to sdk caller (draft PR)

[ ] numaflow-java server sdk: return grpc error TODO

[ ] numaflow intergration: retry on retryable errors and gracefully exit on non-retryable errors TODO


[app] Invalid URL link at https://nextjs.org/learn/dashboard-app/creating-layouts-and-pages

On the sentence:
One benefit of using layouts in Next.js is that on navigation, only the page components update while the layout won't re-render.
This is called partial rendering:
The link should be #4-partial-rendering, not #3-.

Fixing! Thank you.


V1.6.0 Reload data says item doesn’t exist

self.pagingViewController.reloadData(around: self.pagingViewController(self.pagingViewController, pagingItemForIndex: startIndex)) after loading data crashes with message: Thread 1: Fatal error: pagingViewController:viewControllerForPagingItem: PagingItem does not exist. It doesn’t matter if startIndex is 0 or last index of new data array.

@sprzenus can you check what self.pagingViewController(self.pagingViewController, pagingItemForIndex: startIndex) is returning here?

It returns the first item of type PagingIndexItem for a new data

But what is the value of the item? If you could provide any ways of reproducing this that would be great

Any updates on this? I'm not able to reproduce the crash your are seeing


Home Screen

[x] Sales pitch
[x] Login link
[x] sign up link

this just needs a little touching up and styling. also loggedin status bug still in works


RDP showing small fraction (upper left) of screen.

A desktop with an UHD resolution can't be viewed in its entirety which renders remote administration useless. It shows the top left part of the screen.
This could be either a scaling issue (not showing the entire desktop) or a screen-grabbing issue (not streaming the entire desktop)
OS: Windows 10 Pro 64 bit
Version: <IP_ADDRESS>

Sadly I don't have a monitor which supports UHD resolution to figure out the issue. :(

Neither do I. Hmmm...

Mouse input is scaled correctly. So the true dimensions are known but somehow the bitmap doesn't reflect that. I'll use a debug build and try to figure this one out myself. I'll keep you posted, eta hopefully during next week.

ndows 10 handles DPI scaling a bit differently.
I've learned that with e.g. a global 125% DPI setting the Screen.AllScreens[monitor].Bounds returns a bogus resolution. So this is not the the fault of the ultra-hight resolution (I did assume this at first).
In my test setting, using a Windows 10 machine with a global 125% DPI scaling, the bounds return 1280x720 while the actual resolution was 1600x900.
Creating a graphics instance from the current form and get dpiX and dpiY? No luck, always 96 DPI.
Option 1, not favorable: One could get the real DPI in a rather difficult way
[DllImport("gdi32.dll")]
static extern int GetDeviceCaps(IntPtr hdc, int nIndex);
public enum DeviceCap
{
    VERTRES = 10,
    DESKTOPVERTRES = 117,

    // http://pinvoke.net/default.aspx/gdi32/GetDeviceCaps.html
}

private float getScalingFactor()
{
    Graphics g = Graphics.FromHwnd(IntPtr.Zero);
    IntPtr desktop = g.GetHdc();
    int LogicalScreenHeight = GetDeviceCaps(desktop, (int)DeviceCap.VERTRES);
    int PhysicalScreenHeight = GetDeviceCaps(desktop, (int)DeviceCap.DESKTOPVERTRES);

    float ScreenScalingFactor = (float)PhysicalScreenHeight / (float)LogicalScreenHeight;

    return ScreenScalingFactor; // 1.25 = 125%
}

Source
Using the scaling-factor, one can easily calculate the actual width and height.
Option 2, my favorite: OR you can make your client application DPI aware
This fixes the screen bounds without changing code. How? By adding this to your app.manifest:
<application xmlns="urn:schemas-microsoft-com:asm.v3">
    <windowsSettings>
      <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
    </windowsSettings>
  </application>

Since the Client isn't really and end-user GUI experience (except for a dialog window) this results in little or no strange GUI scaling issues when the client uses DPI scaling.

You can find more info about DPI and all it's perils here. A big thanks to Christoph Nahr for his thorough and very comprehensive documentation concerning this issue.
Now then. I'm no expert and I know little about Mono build compatibility but this fixes the issue for me and maybe option 2 should be committed when it has been tested?

Also based on some delightful light reading here.

Yes, Option 2 sounds very good. I'll add this.


Implemented input validation for package name length

I've implemented the input validation for the package name length. The package name will now be checked to ensure it does not exceed the maximum allowed length of 100 characters.
Please review the changes and let me know if you have any feedback or concerns. Once the changes are merged, this issue closes #1452

@masterismail do you plan on completing this, or should we close it out?

hey @andrewpollock , apologise for the delay in getting back to you. I'll be updating the code with the requested changes asap.

/gcbrun

@masterismail there's some linter errors on your change:
gcp/api/server.py:440:0: W0311: Bad indentation. Found 4 spaces, expected 2 (bad-indentation)
gcp/api/server.py:441:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
gcp/api/server.py:442:0: C0303: Trailing whitespace (trailing-whitespace)
gcp/api/server.py:794:0: C0303: Trailing whitespace (trailing-whitespace)

Please run https://github.com/google/osv.dev/blob/master/tools/lint_and_format.sh on your changes prior to pushing them.

@masterismail there's still some formatting errors with this change.  If you run yapf -i gcp/api/server.py it should fix them.

@masterismail there's still some formatting errors with this change.  If you run yapf -i gcp/api/server.py it should fix them.

yes, I have run "https://github.com/google/osv.dev/blob/master/tools/lint_and_format.sh " locally, this is what I am getting

Please let me know what exactly needs to fixed

this is what I am getting

Hi, have you set up your local development environment per https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md#contributing-code?
Actually, reviewing that in conjunction with the output you've screenshotted, I can see that there's an undocumented requirement on having the Go toolchain installed. And yapf, which is why you didn't get locally notified about the formatting issues.
Are you as a contributor able to view https://github.com/google/osv.dev/actions/runs/5795924263/job/15708435878?pr=1455 ? That's showing the output of running lint_and_format.sh as part of our CI pipeline.

Are you as a contributor able to view https://github.com/google/osv.dev/actions/runs/5795924263/job/15708435878?pr=1455 ? That's showing the output of running lint_and_format.sh as part of our CI pipeline.

yes, i'm able to see those test fails

this is what I am getting

Hi, have you set up your local development environment per https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md#contributing-code?

yes, I did

yes, I did

Yes, it turns out there were a few things necessary that weren't explicitly in the documentation, see the #1542 for what else you need to have to be able to properly check your changes locally.

yes, i'm able to see those test fails

Cool, do you understand what you need to do to get your PR to pass, based on the failure?

yes, i'm able to see those test fails

Cool, do you understand what you need to do to get your PR to pass, based on the failure?

I don't understand why its actually failing, it rates my code 10/10

I don't understand why its actually failing, it rates my code 10/10

pylint is happy with the change, yapf is not:
--- gcp/api/server.py	(original)
+++ gcp/api/server.py	(reformatted)
@@ -436,9 +436,12 @@
                                         empty_bucket_bitmap,
                                         len(version_query.file_hashes))

+
 def validate_package_name(package_name):
   if len(package_name) > MAX_PACKAGE_NAME_LENGTH:
     raise ValueError("Package name exceeds the maximum allowed length.")
+
+
 @ndb.tasklet
 def do_query(query, context: QueryContext, include_details=True):
   """Do a query."""
@@ -780,6 +783,7 @@

   return results, cursor

+

This is basically saying that you need to insert a blank line before your validate_package_name function and two blank lines after it (before the next function definition, do_query).
Take a moment to look at the formatting of the rest of the file, and you'll see that your change is inconsistent with the formatting of the file. You may also like to familiarise yourself with the Google Python Style Guide more broadly, for future reference.

@masterismail checking back in to see if you plan on completing this, or if we should close it?

I've committed the changes as requested !

/gcbrun

@masterismail it looks like there's one last lint finding to address, you're close!


Prevent certain directories from being scanned by require.context

Feature request

What is the expected behavior?
When using require.context there should be a way to prevent certain directories children to be checked against the regex
What is motivation or use case for adding/changing the behavior?
I would like to exclude all the node_modules directories from the search, preventing its children to be tested against the regex, this would greatly improve the build time
How should this be implemented in your opinion?
The recurse argument could accept a regex in addition to the boolean type:

true would mean "recurse inside every directory",
false "don't recurse"
a regex "check if folder satisfies the regex"

Are you willing to work on this yourself?
yes but i don't know the code base and i need guidelines on where this logic should be implemented

Maybe this is the only part that needs to be changed
https://github.com/webpack/webpack/blob/00226ff3de02078c641ef0426a5425c184510b8a/lib/ContextModuleFactory.js#L268-L270
I will open a pull request
If you have advices or suggestion on other ways to implement this please tell me

Please use regexp to include/exclude necessary files, you can read this here https://webpack.js.org/guides/dependency-management/#requirecontext

The regex is not tested against folders, all the files will be scanned recursively no matter what the regex is
Look at the line I posted above, every time the addDir function finds a directory it calls itself scanning all children

@remorses There are a lot of ways to achieve this:

You can set useSubdirectories: false and do multiple requests
You can refactor structure
You can filter in runtime (bad idea)

It is specific webpack API and we recommend avoid this in favor ES module syntax

This api is used for storybook and really slows it down because searches every file inside node modules
I can work on this, the recurse argument could be a regex or Boolean type, it is not even a breaking change, can I open a pull request?

This api is used for storybook and really slows it down because searches every file inside node modules

Can you provide where?

https://github.com/storybookjs/storybook/blob/54a1c0c5f6e6cb9ca078c884c45447b95fada29f/lib/core/src/server/preview/to-require-context.js#L26

In the next release it is still used
https://github.com/storybookjs/storybook/blob/57e5092dd5d46da5f5c5e3dbe76d26e62587c724/lib/core/src/server/preview/to-require-context.ts#L61

How you fix it in storybook?

I was thinking to add a regex to exclude directories like node_modules from being scanned
But maybe it's better to not use context.require,  instead generate a file at build time with an object that maps from filenames to import , this way the glob search behaviour can be more flexible
{
  './dir/story.js': () => import('./dir/story.js'),
  // for every file found by the glob
}

Is this the best approach?
PS: i am not a contributor of storybook but i am building another similar project that uses the same approach

I will just remove context.require

Yes, don't use context.require, migrate on other approaches, context.require is webpack specific, and should be avoided in real code as much as possible


Add info on recently added waterbodies attributes

@vikineema, when you have been able to update the GeoServer to use the polygons as they are in the database, could you please also update the download links under "Data Access - Amazon Web Service S3"?
We can call this version 0.0.3 both in GeoServer and In AWS. The difference being that version 0.0.3 no longer has the time series attribute.


TPV  telomeric DNA binding

telomeric DNA binding
is a descendant of
sequence specific DNA binding.
However, lots of proteins can bind telomeric DNA, and other regions  (replication and repair proteins), in a non-sequence specific manner.

Hi @ValWood,
This is a tricky one.
The definition of ‘sequence-specific DNA binding’ is “Interacting selectively and non-covalently with DNA of a specific nucleotide composition, e.g. GC-rich DNA binding, or with a specific sequence motif or type of DNA e.g. promotor binding or rDNA binding.”. Telomeric DNA contains repetitions of TTAGGG, and I’d consider that a sequence motif. Telomeric DNA may also contain elements with added specificity e.g. X element (see http://www.ontobee.org/ontology/SO?iri=http://purl.obolibrary.org/obo/SO_0000624), so I’d consider binding to those elements as sequence-specific binding. I’d suggest to

[ ] add a clarification to the def of ‘sequence-specific DNA binding’:
“Interacting selectively and non-covalently with DNA of a specific nucleotide composition, e.g. GC-rich DNA binding, or with a specific sequence motif, e.g. telomeric DNA repeats, or type of DNA e.g. promotor binding or rDNA binding.”

and

[ ] We could also add some annotation guidance to the effect that some proteins may bind telomeric DNA, and other regions (replication and repair proteins), in a non-sequence specific manner and that in those cases the proteins should be annotated differently. Could you please provide some text, annotation examples if you have any, and indicate whet terms should be added this guidance and what alternative terms you’d suggest. I hope this makes sense. Thanks!

Don't worry its a non issue. The telomere binding term has indeed only been used for repeat tract binding.
Origin binding as "sequence-specific" is a bit suspect (they are AT rich, but there isn't a recognisable sequence motif), but it isn't a huge problem


show error with context

这个 PR 实现什么功能/修复什么问题:
返回error携带上下文信息
是否需要 backport 到之前的 release 分支:

release/2.10.0

/cc @swordqiu @yousong

Codecov Report

Merging #1211 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1211      +/-   ##
=========================================
+ Coverage     7.9%   7.91%   +<.01%
=========================================
  Files         368     368
  Lines       57866   57851      -15
=========================================
+ Hits         4576    4578       +2
+ Misses      52892   52876      -16
+ Partials      398     397       -1

Flag
Coverage Δ

#aFlag
7.91% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/loadbalancers.go
1.96% <0%> (-0.02%)
:arrow_down:

pkg/util/ucloud/region.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/instance.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/loadbalancerlisteners.go
1.59% <0%> (ø)
:arrow_up:

pkg/util/ucloud/client.go
20.93% <0%> (+0.24%)
:arrow_up:

pkg/util/seclib2/seclib.go
95.74% <0%> (+4.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e70f3...711ad4d. Read the comment docs.

/lgtm
/approve


Nova console: stuck in ""Booting from Hard Disk ... GRUB"

RDO All-In-One devstack (Newton) on Vmware workstation.

tail /var/log/nova/nova-api.log

2016-12-24 10:45:24.205 1103 ERROR nova.servicegroup.drivers.db OperationalError: (pymysql.err.OperationalError) (2006, "MySQL server has gone away (error(32, 'Broken pipe'))")
2016-12-24 10:45:24.205 1103 ERROR nova.servicegroup.drivers.db
2016-12-24 10:48:56.358 1074 WARNING nova.cmd.cert [-] Deprecated: The nova-cert service is deprecated and will be removed in a future release.
2016-12-24 10:48:56.539 1074 WARNING oslo_reports.guru_meditation_report [-] Guru meditation now registers SIGUSR1 and SIGUSR2 by default for backward compatibility. SIGUSR1 will no longer be registered in a future release, so please use SIGUSR2 to generate reports.
2016-12-24 10:48:57.121 1074 WARNING oslo_config.cfg [req-c6a8a130-c507-4f35-b25b-c53300d76a71 - - - - -] Option "compute_manager" from group "DEFAULT" is deprecated for removal.  Its value may be silently ignored in the future.
2016-12-24 10:48:57.274 1074 WARNING oslo_config.cfg [req-c6a8a130-c507-4f35-b25b-c53300d76a71 - - - - -] Option "rabbit_host" from group "oslo_messaging_rabbit" is deprecated for removal.  Its value may be silently ignored in the future.
2016-12-24 10:48:57.274 1074 WARNING oslo_config.cfg [req-c6a8a130-c507-4f35-b25b-c53300d76a71 - - - - -] Option "rabbit_port" from group "oslo_messaging_rabbit" is deprecated for removal.  Its value may be silently ignored in the future.
2016-12-24 10:48:57.274 1074 WARNING oslo_config.cfg [req-c6a8a130-c507-4f35-b25b-c53300d76a71 - - - - -] Option "rabbit_password" from group "oslo_messaging_rabbit" is deprecated for removal.  Its value may be silently ignored in the future.
2016-12-24 10:48:57.275 1074 WARNING oslo_config.cfg [req-c6a8a130-c507-4f35-b25b-c53300d76a71 - - - - -] Option "rabbit_userid" from group "oslo_messaging_rabbit" is deprecated for removal.  Its value may be silently ignored in the future.
2016-12-24 10:48:57.460 1074 INFO nova.service [-] Starting cert node (version 14.0.2-1.el7)

tail /var/log/libvirt/qemu/instance-00000001.log

warning: TCG doesn't support requested feature: CPUID.07H:EBX.tsc_adjust [bit 1]
2017-02-13T07:48:26.462598Z qemu-kvm: terminating on signal 15 from pid 1
2017-02-13 07:48:27.710+0000: shutting down
2017-02-13 07:59:03.573+0000: starting up libvirt version: 2.0.0, package: 10.el7_3.4 (CentOS BuildSystem http://bugs.centos.org, 2017-01-17-23:37:48, c1bm.rdu2.centos.org), qemu version: 2.6.0 (qemu-kvm-ev-2.6.0-28.el7_3.3.1), hostname: localhost.localdomain
LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin QEMU_AUDIO_DRV=none /usr/libexec/qemu-kvm -name guest=instance-00000001,debug-threads=on -S -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain-1-instance-00000001/master-key.aes -machine pc-i440fx-rhel7.3.0,accel=kvm,usb=off -cpu SandyBridge,+vme,+ds,+ss,+vmx,+pcid,+osxsave,+hypervisor,+arat,+tsc_adjust -m 512 -realtime mlock=off -smp 1,sockets=1,cores=1,threads=1 -uuid d5e8026b-e38b-4b69-95e6-42281ed6bb03 -smbios 'type=1,manufacturer=RDO,product=OpenStack Compute,version=14.0.2-1.el7,serial=27cce89f-4a11-41dc-af63-8b2220e0bc77,uuid=d5e8026b-e38b-4b69-95e6-42281ed6bb03,family=Virtual Machine' -no-user-config -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/domain-1-instance-00000001/monitor.sock,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc,driftfix=slew -global kvm-pit.lost_tick_policy=discard -no-hpet -no-shutdown -boot strict=on -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -drive file=/dev/disk/by-path/ip-<IP_ADDRESS>:3260-iscsi-iqn.2010-10.org.openstack:volume-863e3910-7153-482b-98cd-95863a44f48b-lun-0,format=raw,if=none,id=drive-virtio-disk0,serial=863e3910-7153-482b-98cd-95863a44f48b,cache=none,aio=native -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -netdev tap,fd=29,id=hostnet0,vhost=on,vhostfd=31 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=fa:16:3e:6b:f3:f3,bus=pci.0,addr=0x3 -add-fd set=2,fd=33 -chardev file,id=charserial0,path=/dev/fdset/2,append=on -device isa-serial,chardev=charserial0,id=serial0 -chardev pty,id=charserial1 -device isa-serial,chardev=charserial1,id=serial1 -device usb-tablet,id=input0,bus=usb.0,port=1 -vnc <IP_ADDRESS>:0 -k en-us -device cirrus-vga,id=video0,bus=pci.0,addr=0x2 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg timestamp=on
char device redirected to /dev/pts/1 (label charserial1)
warning: host doesn't support requested feature: CPUID.01H:EDX.ds [bit 21]
warning: host doesn't support requested feature: CPUID.01H:ECX.vmx [bit 5]
warning: host doesn't support requested feature: CPUID.01H:ECX.osxsave [bit 27]
warning: host doesn't support requested feature: CPUID.0DH:EAX.xsaveopt [bit 0]

Did you find the solution? Even I am facing the same problem

Hitting this issue with Openstack AIO installed on CentOS 7.3
KVM has been installed and configured in \etc\nova\nova.conf where virt_type=kvm and cpu_mode=none
Any resolution?

kvm is the default hypervisor for compute, make sure  "svm" or "vmx" CPU extensions are present in the compute node.
grep -E 'svm|vmx' /proc/cpuinfo
Have you tried other virt_type option ?

virt_type=qemu

am having the exact same issue, same error and everything, am running RHOS 12 on virtual machines hosted on ESXi.  for that i was not expecting the KVM to work. so i deployed with qemu even though the hang is still there !!

Any solutions? Thank you.

I also faced the same problem.
Following report resolved my problem.
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1691109
I am using Ubuntu 16.04.5 LTS devstack on VMware Fusion. In that environment, as of now, default machine type was specified 'pc-i440fx-artful', so I needed to specify following setting in nova.conf.
[libvirt]
hw_machine_type = x86_64=pc-i440fx-xenial

In my environment, it didn't need to change 'virt_type' from 'kvm' to 'qemu'.
This page's original post is for RHEL/CentOS, so I think it needs to specify proper hw_machine_type string for it.

I am running openstack(3.18.0) on CentOS7.6.1810. I met the similar issue(see below image) when I create a new instance. It seems the cirros cannot boot due to it cannot find the boot volume.
I check the /var/lib/nova/instances/xxxx/, there is only one file named console.log with ZERO byte.

even when I follow this https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1691109 to change the hw_machine_type to rhel6.5.0(get the value from virsh capabilities) and then restart the nova services and use the centos65 images. I still get the similar issue.
so, what is the next step to dig further?

@sagara177. This works for me. Thanks.

First
[DEFAULT]
compute_driver = libvirt.LibvirtDriver
[libvirt]
virt_type=kvm
cpu_mode=host-passthrough
hw_machine_type = x86_64=pc-i440fx-rhel7.2.0

Finally
systemctl restart openstack-nova-compute

Tried to fix but could not. Seems filesystem of this instance got corrupted. Booted in to rescue mode, and then tried to do xfs_repair which also could not succeed.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.10.112 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


metrics: emit metric for unmanaged pod count

Adding a metric to emit the number of pods that should be managed but are unmanaged by Cilium.
Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
Enables a new metric in the cilium operator to indicate unmanaged pods.

@lambdanis - thanks for the review. That makes sense, updated the metric to be a gauge of total unmanaged pods instead.

/test

Seems the e2e upgrade test failed with:
.......  [.] Action [check-log-errors/no-errors-in-logs/kind-kind/kube-system/cilium-envoy-mtq62 (cilium-envoy)]
.  [.] Action [check-log-errors/no-errors-in-logs/kind-kind/kube-system/cilium-envoy-qjmdn (cilium-envoy)]
.
📋 Test Report [cilium-test-1]
❌ 1/67 tests failed (1/1053 actions), 37 tests skipped, 1 scenarios skipped:
Test [check-log-errors]:
  ❌ check-log-errors/no-errors-in-logs/kind-kind/kube-system/cilium-75wgr (cilium-agent)
[cilium-test-1] 1 tests failed

Might be a flaky test.

/test

@lambdanis - could you re-trigger the tests?

@doniacld - could you please review when you get a chance? thank you


Host-named site collection inconsistencies

Host-named site collections have been around for already a long time. In the past, documentation referred to them as being "hostheader site collections", which is not correct. In fact, if there's one thing that is incompatible to host-named site collections, it's hostheaders. Unfortunately, the cmdlet parameters often use the parameter name "HostHeader" - and of course these cannot be changed. The documentation around these parameters can be changed, however. This pull request aims to use the correct terminology where appropriate to avoid confusion. More recent cmdlets like Copy-SPSite already incorporate the correct terminology in their help files, but older cmdlets didn't.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Copy-SPSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Get-SPManagedPath.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/New-SPManagedPath.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/New-SPSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Remove-SPManagedPath.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Thomas, appreciated.


WIP: xen-tools: Use the minimum thread stack size

Minimize thread/coroutine overhead by changing the size
of the stack and mapping it as MAP_GROWSDOWN
Signed-off-by: Sergey Temerkhanov<EMAIL_ADDRESS>

@eriknordmark can we please close this? The idea of the "xen-tools: Use the minimum thread stack size" patch is to utilize the MAP_GROWSDOWN mmap() flag, and this is done incorrectly. The main misconception is that stack won't grow down if there is no gap between previous mapping and the stack vma (see the linux/mm/mmap.c:expand_downwards() function and 'stack_guard_gap' variable). Since 'address' is not specified in the mmap() syscall, the kernel chooses the address at which to create the mapping, thus there is no guarantee that gap will be preserved, thus "touch" of the guard page will eventually lead to the SEGV.  Also the main intention of the patch is to "Minimize thread/coroutine overhead" is questionable: if nothing is written to the anonymous private mapping then there is no physical page allocated and savings just on virtual space is doubtful.

Sure let me close it

See @rouming 's comments above for why we are closing this


Workaround for when session variables are not available for iframe

Depending on user's browser settings, the LTI session variables cannot be found - likely due to the problem described in this link
One workaround is to ask the user to visit a page on the iframe host (in this case the bridge). This PR adds a view at /lti/create_session to create a new session and set the cookie manually. After the learner visits that page in a new tab or window, they are able to use the bridge normally.
It also seems like after the learner is able to access the bridge (and get content served from the openedx content source), some javascript from the content source is not able to load, and the submit button in the problem becomes disabled. A similar solution where the learner visits a page on the content source fixes this problem.
This PR adds a message to the learner when the LTI session is not found, that directs them to open pages on the content source and the bridge in new tab/window, close them, then refresh the LMS page in order to start the adaptive quiz.

The original issue could be tricky to reproduce since its related to user browser settings, but what worked for me is to use the Safari browser, clear the browser history/cookies, then try to use a Bridge LTI component in the LMS.

Nice catch Andrew! I'm not sure we need any new endpoint for users to create new cookies for the bridge site. I would extend the error message to cover this issue with the proposition to decrease security browser level to start working on the adaptive unit and after that increase, it back, or open the new tab with the bridge's index page and close it after that unit will be rendered correctly.


fix warmup of learning rate so that it works properly w/ continued tr…

…aining
(description of the change)
Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
There were failures, but they are the same failures exhibited by the master branch
[no] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs?
[x] System tests pass (pytest test/system)
There were failures, but they are the same failures exhibited by the master branch
[x] Passed code style checking (./style-check.sh)
[no] You have considered writing a test
[x] Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
[x] Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Would it be possible to add a unit test?

Would it be possible to add a unit test?

I'm not sure what to put in a unit test, the problem seems to lie more in the way pieces interact.
I guess I could create a training instance, manipulate the counters, and force it to save state. Then create new training instance, load state, and check to make sure that various instance variable are what i expect.

I'm not sure what to put in a unit test, the problem seems to lie more in the way pieces interact.
I guess I could create a training instance, manipulate the counters, and force it to save state. Then create new training instance, load state, and check to make sure that various instance variable are what i expect.

Yes, you are right, it's a bit of a hassle. It'd be good to have but if you think it is too much work, let me know, we can merge then.

Yes, you are right, it's a bit of a hassle. It'd be good to have but if you think it is too much work, let me know, we can merge then.

Let's just merge as is.

Let's just merge as is.


chore: Bump Go to 1.18

GoReleaser v1.10 update broke our releases: https://github.com/dagger/dagger/runs/7205381884?check_suite_focus=true#step:8:116
It tried building a windows_arm64 version which is not possible with Go 1.16. This has more details: https://github.com/goreleaser/goreleaser/issues/3224
Instead of pinning to GoReleaser v1.9.2 (last version that worked https://github.com/dagger/dagger/runs/7097754532?check_suite_focus=true#step:8:15) we should do the right thing and bump the Go version that we are using to develop Dagger to 1.18. By the way, some of us are already using 1.18 locally, but not CI, so this change fixes it. It should also fix the release.
Related to https://github.com/dagger/dagger/issues/1859

LGTM
@marcosnils we can also remove these lines from goreleaser.yaml:
       - -X go.dagger.io/dagger/version.Version={{.Version}}
       - -X go.dagger.io/dagger/version.Revision={{.ShortCommit}}

@marcosnils we can also remove these lines from goreleaser.yaml:
     --X go.dagger.io/dagger/version.Version={{.Version}}
     --X go.dagger.io/dagger/version.Revision={{.ShortCommit}}

Actually we can only remove the lines from goreleaser.yaml, for the version.Revision.
version.Version is not yet available from the debug.BuildInfo (will be added eventually: https://github.com/golang/go/issues/50603#issuecomment-1076662671)


chore(package.json): update angular2 beta 12

Coverage remained the same at 100.0% when pulling f28d49211b9cd9e12b229307c14d74714e580bed on update-dep into 0cf352ee2f54cf247509989e0799047813acc157 on master.


Error with add config

C:/Ruby26-x64/lib/ruby/gems/2.6.0/gems/tty-0.10.0/lib/tty/commands/add.rb:69:in `read': No such file or directory @ rb_sysopen - li
b/rev2test/cli.rb (Errno::ENOENT)

I think this is a documentation issue. I get this same error if I try running a teletype command outside of the app directory:
[katelyn@h code]$ teletype new my-cool-app
Creating gem 'my-cool-app'...
Code of conduct enabled in config
      create  my-cool-app/Gemfile
      create  my-cool-app/lib/my/cool/app.rb
      create  my-cool-app/lib/my/cool/app/version.rb
      create  my-cool-app/my-cool-app.gemspec
      create  my-cool-app/Rakefile
      create  my-cool-app/README.md
      create  my-cool-app/bin/console
      create  my-cool-app/bin/setup
      create  my-cool-app/.gitignore
      create  my-cool-app/.travis.yml
      create  my-cool-app/.rspec
      create  my-cool-app/spec/spec_helper.rb
      create  my-cool-app/spec/my/cool/app_spec.rb
      create  my-cool-app/CODE_OF_CONDUCT.md
      append  my-cool-app/README.md
      inject  my-cool-app/my-cool-app.gemspec
      create  my-cool-app/lib/my/cool/app/cli.rb
      create  my-cool-app/lib/my/cool/app/command.rb
      create  my-cool-app/exe/my-cool-app
      create  my-cool-app/LICENSE.txt
      create  my-cool-app/lib/my/cool/app/commands/.gitkeep
      create  my-cool-app/lib/my/cool/app/templates/.gitkeep
      create  my-cool-app/spec/integration/.gitkeep
      create  my-cool-app/spec/support/.gitkeep
      create  my-cool-app/spec/unit/.gitkeep
Initializing git repo in /home/katelyn/code/my-cool-app

Your teletype project has been created successfully.

Run "teletype help" for more commands.
[katelyn@h code]$ teletype add config
Traceback (most recent call last):
	11: from /home/katelyn/.rvm/gems/ruby-2.6.5/bin/ruby_executable_hooks:24:in `<main>'
	10: from /home/katelyn/.rvm/gems/ruby-2.6.5/bin/ruby_executable_hooks:24:in `eval'
	 9: from /home/katelyn/.rvm/gems/ruby-2.6.5/bin/teletype:23:in `<main>'
	 8: from /home/katelyn/.rvm/gems/ruby-2.6.5/bin/teletype:23:in `load'
	 7: from /home/katelyn/.rvm/gems/ruby-2.6.5/gems/tty-0.10.0/exe/teletype:14:in `<top (required)>'
	 6: from /home/katelyn/.rvm/gems/ruby-2.6.5/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	 5: from /home/katelyn/.rvm/gems/ruby-2.6.5/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	 4: from /home/katelyn/.rvm/gems/ruby-2.6.5/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	 3: from /home/katelyn/.rvm/gems/ruby-2.6.5/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	 2: from /home/katelyn/.rvm/gems/ruby-2.6.5/gems/tty-0.10.0/lib/tty/cli.rb:87:in `add'
	 1: from /home/katelyn/.rvm/gems/ruby-2.6.5/gems/tty-0.10.0/lib/tty/commands/add.rb:69:in `execute'
/home/katelyn/.rvm/gems/ruby-2.6.5/gems/tty-0.10.0/lib/tty/commands/add.rb:69:in `read': No such file or directory @ rb_sysopen - lib/code/cli.rb (Errno::ENOENT)

The "Overview" section of the README makes it seem like you'd run these commands in succession; but in reality, you need to cd into 'my-cool-app' first.
In addition to a doc update, it may be nice to check if the PWD is a valid teletype app.


Zoom rendered and performance

Hi,
Two issues : when I zoom on wavesrufer loaded with peaks, there are rendered issue : blank zone or duplicate peaks on new canvas depend of zoomLevel.

When increase zoom, there si bad performance rendered,

on Chrome : [Violation] 'requestAnimationFrame' handler took xxxxms
on FireFox : shutdown process and memory leak !

There currently existing rendering issue when zooming and scroll to get all peaks left and right : #1261
See @jamiefaye and my solution to get all wave rendered.
I Need to merge solution between zooming and scrolling use and without this rendered and bad performance.
Wavesurfer.js version(s): 2.0.6
Browser version(s):
Chrome v67, Firefox 60
Code needed to reproduce the issue:
Apply zoom on waveform with peaks. I do this with mouse wheel and timeOut between scroll=>
var zoomLevel;
wavesurfer.on('ready', function () {
// define inital zoom level
                    zoomLevel = Math.trunc(wavesurfer.drawer.getWidth() / wavesurfer.getDuration() / wavesurfer.params.pixelRatio);
                    wavesurfer.container.addEventListener('wheel', wheelZoomHandler);
                });

var zoomStep = 2;
    var zoomTimeOut;
    // initialise start NO zoom
 wavesurfer.zoom();
    function wheelZoomHandler(e) {
        var deltaY = 0;
        e.preventDefault();
        if (e.deltaY) { // FireFox 17+ (IE9+, Chrome 31+?)
            deltaY = e.deltaY;
        } else if (e.wheelDelta) {
            deltaY = -e.wheelDelta;
        }
        // Update the bg size:
        clearTimeout(zoomTimeOut);
        if (deltaY < 0) {
                zoomLevel += zoomStep;
                zoomTimeOut = setTimeout(function(){
                    console.log('Zoom increase : ' + zoomLevel);
                    wavesurfer.zoom(zoomLevel);
                },200);
        } else {
            if (zoomLevel > Math.trunc(wavesurfer.drawer.getWidth() / wavesurfer.getDuration() / wavesurfer.params.pixelRatio)){
                zoomLevel -= zoomStep;
                zoomTimeOut = setTimeout(function(){
                    console.log('Zoom decrease : ' + zoomLevel);
                    wavesurfer.zoom(zoomLevel);
                },200);
            } else { // stay zoomlevel at start value
                zoomLevel = Math.trunc(wavesurfer.drawer.getWidth() / wavesurfer.getDuration() / wavesurfer.params.pixelRatio);
                wavesurfer.zoom(); // reinit no zoom
            }
        }
    };

Use behaviour needed to reproduce the issue:
Load file with peaks (example of 30 minutes with little data per second)
Use mouse wheel to increase or decrease zoom and let see rendered, navigator and computer UC/memory  !
I'm working on a solution, but all idea and optimization are welcome ;-)

I'm working on a solution, but all idea and optimization are welcome ;-)

any news?


Add manual testing to DG

Currently, the developer guide does not include manual testing.
Let's fix this by adding the necessary section.

Codecov Report
Base: 71.42% // Head: 70.92% // Decreases project coverage by -0.50% :warning:

Coverage data is based on head (60ad2ec) compared to base (3760992).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #222      +/-   ##
============================================
- Coverage     71.42%   70.92%   -0.51%
- Complexity      631      636       +5
============================================
  Files           106      106
  Lines          2009     2019      +10
  Branches        226      233       +7
============================================
- Hits           1435     1432       -3
  Misses          505      505
- Partials         69       82      +13

Impacted Files
Coverage Δ

...eedu/intrack/logic/parser/SelectCommandParser.java
71.42% <0.00%> (-28.58%)
:arrow_down:

.../intrack/logic/parser/DeleteTaskCommandParser.java
71.42% <0.00%> (-28.58%)
:arrow_down:

...va/seedu/intrack/logic/commands/SelectCommand.java
86.66% <0.00%> (-13.34%)
:arrow_down:

...eedu/intrack/logic/parser/StatusCommandParser.java
60.00% <0.00%> (-11.43%)
:arrow_down:

...va/seedu/intrack/logic/commands/StatusCommand.java
64.00% <0.00%> (-8.73%)
:arrow_down:

...eedu/intrack/logic/commands/DeleteTaskCommand.java
91.66% <0.00%> (-8.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM!


Frameit/title below image

🔑
Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
frameit places the title above the screenshot. I thought it might be useful to be able to place it below the screenshot when desired.
I successfully tested the code on my project and by running bundle exec rspec.
Description
Support for the new parameter title_below_image has been added. It can be used in Framefile.json.

Hey @claesjacobsson, thanks for submitting this pull request. Looks good to me, did you test if this works just like before if the user is not setting the new flag?

Yes, it does.

Thank YOU Felix!


[decompiler] ASM Branching Support

Still a WIP. Working toward getting all of geometry decompiling.

Pull Request Test Coverage Report for Build 998552373

60 of 327 (18.35%)  changed or added relevant lines in 10 files are covered.
7 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.3%) to 68.707%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/IR2/AtomicOpTypeAnalysis.cpp
0
2
0.0%

decompiler/IR2/AtomicOp.h
0
4
0.0%

decompiler/IR2/AtomicOpForm.cpp
2
8
25.0%

decompiler/analysis/cfg_builder.cpp
11
19
57.89%

decompiler/IR2/AtomicOp.cpp
0
22
0.0%

decompiler/analysis/atomic_op_builder.cpp
0
22
0.0%

decompiler/IR2/FormExpressionAnalysis.cpp
0
27
0.0%

decompiler/IR2/Form.cpp
1
67
1.49%

decompiler/Function/CfgVtx.cpp
45
155
29.03%

Files with Coverage Reduction
New Missed Lines
%

decompiler/analysis/atomic_op_builder.cpp
1
83.88%

game/overlord/iso.cpp
1
78.01%

decompiler/IR2/AtomicOp.cpp
2
59.32%

decompiler/IR2/FormExpressionAnalysis.cpp
3
74.84%

Totals

Change from base Build 997641364:
-0.3%

Covered Lines:
37259

Relevant Lines:
54229

💛  - Coveralls


Issue from website page Flutter示例目录

From URL: https://www.flutterchina.club/catalog/samples/index.md

404了 你要说什么？

That is a community website not maintained by the Flutter team. Try https://github.com/flutterchina/website/issues


content/index: Add cheatsheet to requirements table

While this isn't a requirement, is this the best way to make sure
that people see it?
Feel free to not merge

Is it intentional though that the other row disappeared?


ERROR: Failed building wheel for pycairo

Following your README.md I ran
git clone https://github.com/flopp/activities.git
cd activities
python3 -m venv .env
.env/bin/pip install --upgrade pip
.env/bin/pip install .
on a Ubuntu 21.04 container on proxmox as well as WSL Ubuntu, which resulted in the following error
Processing /root/activities
Preparing metadata (setup.py) ... done
Collecting click
Using cached click-8.0.3-py3-none-any.whl (97 kB)
Collecting flask
Using cached Flask-2.0.2-py3-none-any.whl (95 kB)
Collecting geopy
Using cached geopy-2.2.0-py3-none-any.whl (118 kB)
Collecting polyline
Using cached polyline-1.4.0-py2.py3-none-any.whl (4.4 kB)
Collecting py-staticmaps[cairo]
Using cached py_staticmaps-0.4.0-py3-none-any.whl
Collecting sqlalchemy
Using cached SQLAlchemy-1.4.27-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.6 MB)
Collecting stravalib
Using cached stravalib-0.10.4-py3-none-any.whl
Collecting itsdangerous>=2.0
Using cached itsdangerous-2.0.1-py3-none-any.whl (18 kB)
Collecting Jinja2>=3.0
Using cached Jinja2-3.0.3-py3-none-any.whl (133 kB)
Collecting Werkzeug>=2.0
Using cached Werkzeug-2.0.2-py3-none-any.whl (288 kB)
Collecting geographiclib<2,>=1.49
Using cached geographiclib-1.52-py3-none-any.whl (38 kB)
Collecting six>=1.8.0
Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting requests
Using cached requests-2.26.0-py2.py3-none-any.whl (62 kB)
Collecting python-slugify
Using cached python_slugify-5.0.2-py2.py3-none-any.whl (6.7 kB)
Collecting PILLOW
Using cached Pillow-8.4.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.1 MB)
Collecting appdirs
Using cached appdirs-1.4.4-py2.py3-none-any.whl (9.6 kB)
Collecting s2sphere
Using cached s2sphere-0.2.5-py2.py3-none-any.whl (23 kB)
Collecting svgwrite
Using cached svgwrite-1.4.1-py3-none-any.whl (66 kB)
Collecting pycairo
Using cached pycairo-1.20.1.tar.gz (344 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Collecting greenlet!=0.4.17
Using cached greenlet-1.1.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (153 kB)
Collecting units
Using cached units-0.7-py3-none-any.whl
Collecting pytz
Using cached pytz-2021.3-py2.py3-none-any.whl (503 kB)
Collecting arrow
Using cached arrow-1.2.1-py3-none-any.whl (63 kB)
Collecting MarkupSafe>=2.0
Using cached MarkupSafe-2.0.1-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (30 kB)
Collecting charset-normalizer~=2.0.0
Using cached charset_normalizer-2.0.7-py3-none-any.whl (38 kB)
Collecting urllib3<1.27,>=1.21.1
Using cached urllib3-1.26.7-py2.py3-none-any.whl (138 kB)
Collecting certifi>=2017.4.17
Using cached certifi-2021.10.8-py2.py3-none-any.whl (149 kB)
Collecting idna<4,>=2.5
Using cached idna-3.3-py3-none-any.whl (61 kB)
Collecting python-dateutil>=2.7.0
Using cached python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
Collecting text-unidecode>=1.3
Using cached text_unidecode-1.3-py2.py3-none-any.whl (78 kB)
Collecting future>=0.15
Using cached future-0.18.2-py3-none-any.whl
Using legacy 'setup.py install' for activities, since package 'wheel' is not installed.
Building wheels for collected packages: pycairo
Building wheel for pycairo (pyproject.toml) ... error
ERROR: Command errored out with exit status 1:
command: /root/activities/.env/bin/python3 /root/activities/.env/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py build_wheel /tmp/tmp90487_lh
cwd: /tmp/pip-install-fasvdjhp/pycairo_0922a36a62564a85b4cd2185e1e4f6df
Complete output (12 lines):
running bdist_wheel
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.9
creating build/lib.linux-x86_64-3.9/cairo
copying cairo/init.py -> build/lib.linux-x86_64-3.9/cairo
copying cairo/init.pyi -> build/lib.linux-x86_64-3.9/cairo
copying cairo/py.typed -> build/lib.linux-x86_64-3.9/cairo
running build_ext
'pkg-config' not found.
Command ['pkg-config', '--print-errors', '--exists', 'cairo >= 1.15.10']
ERROR: Failed building wheel for pycairo
Failed to build pycairo
ERROR: Could not build wheels for pycairo, which is required to install pyproject.toml-based projects

Thank you for the report. I've now removed preview images (and thus pystaticmaps + pycairo) - they didn't work correctly anyway...


Issue with S3 bucket connectivity -  Failed to create engine: error unmarshalling flow: unable to compile expression '*****': error parsing expression

Hi,
I keep getting this error
Failed to create engine: error unmarshalling flow: unable to compile expression '****': error parsing expression
This i get for the awsaccess key. I try to put the value within double quotes, but that doesnt work either. Not sure why its trying to parse the awsaccess key, its just an alphanumeric key
Thanks

attaching the app json minus the key and secret values.
s_3_operations (1).zip

Just to add our conversation on Gitter here as well:
I just ran the test cases in the repo and they work perfectly, so it’s not an issue in the code of the S3 activity. It might be an issue in either the UI or the way the UI passes the variables to the engine. The Flogo UI team is looking at potential issues.

This issue was not related to the connector, I had to restart the flogo container for some reason it was not saving changes. However I am seeing another issue.
Error:
github.com/project-flogo/flow/model/simple.(*TaskBehavior).Eval
/go/pkg/mod/github.com/project-flogo/flow@v0.9.4/model/simple/taskbehavior.go:90
github.com/project-flogo/flow/instance.(*IndependentInstance).execTask
/go/pkg/mod/github.com/project-flogo/flow@v0.9.4/instance/instances.go:255
github.com/project-flogo/flow/instance.(*IndependentInstance).DoStep
/go/pkg/mod/github.com/project-flogo/flow@v0.9.4/instance/instances.go:199
github.com/project-flogo/flow.(*FlowAction).Run.func1
/go/pkg/mod/github.com/project-flogo/flow@v0.9.4/action.go:300
2019-11-13T13:32:01.030-0500    ERROR   [flogo.flow] -  Error evaluating activity 'amazons3_4'[github.com/project-flogo/legacybridge] - interface conversion: interface {} is nil, not string
github.com/project-flogo/core/support/log.(*zapLoggerImpl).Errorf
/go/pkg/mod/github.com/project-flogo/core@v0.9.4/support/log/zap.go:65
github.com/project-flogo/flow/model/simple.(*TaskBehavior).Eval
/go/pkg/mod/github.com/project-flogo/flow@v0.9.4/model/simple/taskbehavior.go:93
github.com/project-flogo/flow/instance.(*IndependentInstance).execTask
/go/pkg/mod/github.com/project-flogo/flow@v0.9.4/instance/instances.go:255

It looks like there is an issue with the https://github.com/project-flogo/legacybridge project in combination with this code. I know the team built it to solve a few issues when they broke backward compatibility in activities but I'm not sure what it exactly does. You might want to check with the Flogo core team why this error exists.

okay, i will raise a case on flogo git and reference this issue

Hi, was there a new release to solve this? Mainly it is asking not to pass null on optional fields. Against https://github.com/TIBCOSoftware/flogo/issues/515 I was told this has to be fixed in the connector itself.

Not exactly, the issue is still that the legacy bridge passes the context with the values provided in the JSON to the legacy activity. If there's no value associated with it, it passes {}. Having said that, I have contributed a new activity to the main aws-contrib repo https://github.com/project-flogo/aws-contrib/pull/7. As soon as the PR is accepted and merged, you'll be able to use it.

okay, thanks!! i checked there already was not able to see the activity so I thought I should expect a new release here
. Thanks !

My new activity has been merged into the master branch at https://github.com/project-flogo/aws-contrib, so I suggest using that one 😄 I'll close the issue here, thanks for reporting it!


ci: Add a manual trigger for the release-please pipeline

Signed-off-by: Philipp Hinteregger<EMAIL_ADDRESS>This PR:

adds a manual trigger for the release-please pipeline

@thisthat @thschue why do we need a manual trigger for this pipeline?

@mowies the reason is to provide a convenient workaround to run the CI pipeline for the release-please PR.
Release-please does not run for all PR types (e.g., refactoring) so it doesn't get into the changelog. This has the side-effect that the CI build doesn't run and won't produce a manifest that installs the latest version of the project. As a temp workaround, we enable the manual run so we can do a final manual test before merging the PR.


⚠ SolarOscp has degraded performance

In 4b5d214, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 399 ms

Resolved: SolarOscp performance has improved in ee7984d after 9 minutes.


⚠ ClamAV has degraded performance

In 3313920, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in 344d811.