Resources are loaded using HTTP

The new version of CCP WebGL is using HTTP protocol to retrieve resources: SOF data, ship models, shaders and textures. If the website using CCP WebGL was loaded using HTTPS, it will cause browser security errors in Chrome (resulting in blank screen), and security warnings in Firefox.
JS should either detect if the website was lodaded using HTTPS or HTTP (like google analytics do) and use the correct protocol when calling for resources, OR it could be hard-coded to use HTTPS, whichever is easier to implement.

I believe this issue can be closed since the merge of PR #19


[BACKUP] az backup protection check-vm: Add vm and resource-group as optional params

Description
az backup protection check-vm command had only --vm-id as input parameter. To make it consistent with other commands added --vm and --resource-group as optional parameters.
Testing Guide
az backup protection check-vm --resource-group {rg_name} --vm {vm_name/vm_id}
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

BACKUP

Code owner review required

/azp run

Is it OK to deprecate --vm-id as --vm can also accept an vm id?

Is it OK to deprecate --vm-id as --vm can also accept an vm id?

We can stop accepting vm id using the --vm parameter. Then we won't have to deprecate anything. Tagging @mepand for any further input.

@fengzhou-msft Do you see any concerns if we accept only name as value of --vm parameter. In that case, user can either use --vm-id parameter  to pass the complete ID or combination of --vm and --resource-group , where --vm accepts only VM name.

@mepand I thought --vm in other backup commands can accept both name or id, this would still cause inconsistency.

Okay. Sounds good @fengzhou-msft . Thankyou!

/azp run

/azp run

/azp run


feat: Check listing prices of nfts when loading confirm modal

PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Needs QA check

@kodadot/qa-guild please review

pls check the following scenarios

nft price updated

quick buy -> notification "NFT price updated"
cart -> notification "NFT price updated" if one item , if more notification "NFT {nftName} price updated"

nft not listed anymore, (someone bought that item), that item will be removed , and if nft count is 0 the modal will be closed

quick buy  -> notification "NFT is not listed anymore" and modal close
cart -> if one item notification "NFT is not listed anymore" and modal close . if more items  -> notification "NFT {nftName} is not listed anymore"

Context

[x] Closes #8889
[x] Closes #8491

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Screenshot 📸

[ ] My fix has changed something on UI;

@hassnian
was it supposed to work here?
https://github.com/kodadot/nft-gallery/assets/36627808/abfb06e5-26c1-4758-a68f-f7923a7efb97

@prury works for me  , pls try again
ahp
https://github.com/kodadot/nft-gallery/assets/44554284/3c28f749-4ee7-4784-bc88-bdbd32b44dc6
ahk , messed up second try , still worked
https://github.com/kodadot/nft-gallery/assets/44554284/78597621-360c-422b-85f4-3fcbb8c2baed

Delisted and tried to buy✔
https://github.com/kodadot/nft-gallery/assets/36627808/5ead9081-a40a-4f11-8b69-ac84d478e511
changed price and tried to buy ✔
https://github.com/kodadot/nft-gallery/assets/36627808/1a6e0dd8-ba16-4b8c-8855-16c65a5f5330
bought with a third account and tried to buy ❌
https://github.com/kodadot/nft-gallery/assets/36627808/eba3a736-4f97-4263-a400-00031935f969
don't mind the values on explorer, its a bug
will test cart interactions on round 2

@prury  pls try again
https://github.com/kodadot/nft-gallery/assets/44554284/4d900366-032e-447a-afb4-a44b91a032ee

cool, tried both cart interactions and it went well
cart buy and cart change price: ✔
https://github.com/kodadot/nft-gallery/assets/36627808/2c2e7e54-ab11-496d-bb0d-b6b4d712eb5b
cart normal buy round 2: ✔
https://github.com/kodadot/nft-gallery/assets/36627808/a517304e-a2fb-47a5-b101-51b7053f9f9a
well done @hassnian!

Thanks!
pay 50 usd


RFC: Notion api wrapper

Picking up where @nickscamara left off, noodling around with a generic Notion API wrapper that could be used by doc loaders and tools. Currently able to write plain text to new page in database and load all (plain text from) pages in a database as documents. If we think this is worthwhile can polish this PR and add a doc loader and basic agent toolkit @vowelparrot @hwchase17 @eyurtsev

oh we already have a NotionDBLoader! just the writing part then

stale


Add mypy checks

Add mypy to CI and pre-commit checks. Fix mypy errors.
Closes #4720
Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[ ] The changes are tested.
[ ] GraphQL schema and type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Here is the report for e3b4705b1a92943cf88a31839c4eb3baa2a8a840 (mirumee/saleor @ add-mypy-checks)
Base comparison is b34b31e1d75c0248b7edc91c03f084c3cd5fa66e.
No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         14	         14	              2
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         16	         16	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

Some clarification:

I was trying to avoid # type: ignore annotation, but it wasn't possible in all places. For example mypy doesn't take into account hasattr. There are tickets about that on their github so maybe it'll be resolved soon. https://github.com/python/mypy/issues/1424 https://github.com/python/mypy/issues/4944
Instead of just # type: ignore I wanted to specified code error like: # type: ignore[attr-defined] but the flake8 has problem with that and I can't find solution.

I guess it's fine to have those # type: ignore occurrences in a few places if we can't do anything about it.


Setup repository rules

As discussed in the last meeting, we would like to setup a branch structure with certain rules.
E.g., main and develop branch with feature branches. Main is accessible with merge requests and approval only.
@FlrnDml I assigned you this ticket since you mentioned you wanted to setup those things

We have now 2 branches:
Deploy and Main
Deploy is the branch we are mainting our deployed code at, all code that is pushed to deploy will be deployed. We will PR code from main only.
Main is our main branch, we will keep integrating our code here.
I setup following rules: squash commits only, no pushes to main or deploy, resolve conversations, review, do not bypass
In the future I will make code checks (PR checks) required, as soon as they are part of the codebase


Data from server

i have 1000's of records and i don't want to load all at initial time. i want to just display 10 records at initial and after search i want to do server call.

Hi Rupeshtare,
you can make it auto-complete from server side also. as i have added-
<angular2-multiselect [data]="citiesList" name="selectedCity" [(ngModel)]="selectedCities" #selectedCity="ngModel" required [settings]="dropdownCities" (onSelect)="onCitySelect($event)" (onDeSelect)="OnCityDeSelect($event)" (keyup)="filter($event)">
filter(key: any) {
if (key.target.value.length > 2) {
this._getStartedService.getCityList(key.target.value).subscribe(
response => {
debugger;
this.citiesList = response.data.data;
},
error => {
this.flashMessagesService.show(error, { cssClass: 'alert-danger custom-alert ', timeout: 5000 });
});
}
}

I guess that this should be reopened, in order to improve documentation and examples on loading data from server.


Transfer groundControl from staff to admin route

Description
Addresses #3031 by re-routing ground control from a staff to an admin route.
P.S.: still figuring out the backend. Will further changes be required?

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update
[ ] Code quality improvements

How to test

Enter the test environment as an admin, and see that you are able to enter ground control normally.

Copy the ground control route (should be '/groundcontrol')

Switch the test environment to be a staff

Check that the ground control button is now missing.

Paste the ground control route. A 404 route should be expected.

Go to src/commons/navigationBar/AcademyNavigationBar and change the ground control route into a staff route.

Log in as staff. Manually append '/groundcontrol' to the URL to get to the ground control screen.

Attempt to delete an assessment, or mass publish an assessment through the ground control panel.

A 403 Forbidden error should show up.

Other functions, such as unpublishing or publishing of a single submission in the gradings table, should still be possible.

Checklist

[X] I have tested this code - I have manually tested the website to check if I broke any frontend-backend links.
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 31.45%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/academy/academyRoutes.tsx
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
4851

Relevant Lines:
14542

💛  - Coveralls

Waiting for the BE PR before merging.

@RichDom2185 backend PR is ready now. I have replaced all non-dangerous routes to use a "/staff" instead of "/admin" URL to connect to the backend. I have also changed the routes in the backend directly. All seems good, but I am not sure if I have advertently broken some frontend-backend link. Any automated way to test it?

Any automated way to test it?

@josh1248 not really, I think best to just not touch it. Refer to my comments above.
Basically your endpoints paths should be related to your resource.
E.g. GET /users/{id}/name
or something like that


Do all UI programming in logical pixels - scaling is all in backend

It might be worthwhile examining the commits separately. The bulk of the work needed to get the glium backend was done here: 29bb62c86ac08c81aa126eabe79a0606974cfb48
Could you please check the glium, wasm, and glow builds?
Glium: should be working well - though there's the known initial sizing issue. In general this fixes lots of little layout issues on macos (and presumably other scaled displays). In particular things like margin/padding, corner rounding look much better now.
(all screenshots macos, scaling factor 2)
glium before

glium after

Wasm: there's definitely issues with this, but I don't think there are any new issues. Previously the wasm build on macos was not scaled correctly, so at least that much has improved.
wasm before

wasm after

If you encounter any issues with the wasm build, could you un-revert the logging commit (97fa0c04ba65d4a377aac3783e31112616d019e0) re-run and send me the console output along with a screenshot?
Glow: I can get things to build, but even on master, I only see a blank screen in the Glow build. If you have instruction on how to get this to build properly, I can take a deeper look.

Ok @dabreegster - this is ready for review. Please take a look at my comments.

Tested on wasm with hidpi 1. Here there's a regression:
Remove the wasm commits from this PR?

Darn.
There were changes to the API, so just reverting them would make wasm not compile.
Could you try reverting the changes to ezgui/src/shaders/vertex_300.glsl and see if that fixes the wasm build for you?

FWIW, I tried reverting this, and wasm now works again normally (except for resizing the browser window). So I think something else needs to divide by scale factor for wasm.

Could you try reverting the changes to ezgui/src/shaders/vertex_300.glsl and see if that fixes the wasm build for you?

Ah you beat me to it!

except for resizing the browser window

Was the window resize stuff working before or is that a new regression?

Was the window resize stuff working before or is that a new regression?

Ah, it was never working apparently. All good here!

Thanks for the awesome fix! Merging


Document how to enable federation of types with the same plural names

When kubefed2 enable is used to enable types whose plural names (e.g. <deployments>.extensions
and <deployments>.apps) match, the crd name of the generated federated type would also match (e.g. <deployments>.types.federation.k8s.io).  After the first type with a given plural name is enabled, enabling other types with the same name will fail because a crd with the generated name already exists.
The workaround to document is the use of the --federation-group argument to kubefed2 when enabling a type with a duplicated plural name.   When this strategy is employed, it will also be necessary to update the rbac permissions granted to the federation control plane to include the new group.

/assign


512MB memory is not enough to ros install (0.4.1)

http://docs.rancher.com/os/running-rancheros/workstation/boot-from-iso/ states:

You must boot with at least 512MB of memory.

However, to perform a ros install for 0.4.1, this is not enough. I would suggest changing the documentation to 1024MB, I've confirmed this is enough to perform an installation.

This is a duplicate of https://github.com/rancher/os/issues/608, but probably better worded. Will close the other in favor of this one.

I've updated the documentation with a note that if you are planning to install to disk, you'll need 1024 MB.

Thanks for the updating the documentation. Guess this issue can be closed now?

No, we'd like to allow the ability to install using 512MB. So we'll keep it open.

If using alpine linux instead of debian image for system installer, it should be possible to decrease memory need, right?

@liyimeng the problem with alpine is that there isn't support for grub2.  I'm not inclined to switch to syslinux.  Basically we just need to build a custom installer image that has grub but not based on Debian.  Should be doable but we just haven't had the time to do it.

@ibuildthecloud syslinux is simple,  also feature rich, not a bad idea to go with it.

@liyimeng I like the simplicity.  I'm just not sure about the feature rich part.  If it truly is then maybe we should.  Honestly I don't have enough experience with it from a "production" sense.  My context of using syslinux is typically LiveCDs and also XenServer I believe was built on extlinux.  If you think there is a strong case for syslinux it would greatly simplify things.  @imikushin has already done some work in this area and moving to alpine + syslinux for our installer will make it so that we could run with less memory.

@liyimeng perusing over https://wiki.archlinux.org/index.php/syslinux seems to indicate syslinux has a lot more feature than I knew of.

The full RancherOS is no longer able to support 512MB.
For the next release v1.5.0, at least 1GB is required.
If the user adjusts user-docker and kernel and system-images, you can use 512MB memory, but this requires a custom build. It's difficult for most users.

Got it, thanks for taking the time to explain!


implement per-eventlog cassandra settings

Hi,
at first I  planned to implement a configurable per-eventlog partition-size only in order to cope with heterogenous event sizes across different event logs. Now you can override the  cassandra settings as a whole.
The CassandraEventLog constructor and its companion's props method
support an optional argument of type Option[CassandraEventLogSettings]
to override the 'global' settings of the Cassandra extension for a
specific eventlog.
As soon as this is worth integrating we can mention this 'feature' in the appropriate sections in the docs.
Cheers,
Gregor

Overriding certain config parameters per event log is definitely a valid use case but I'm not happy with the semantics of the proposed solution. Having an optional CassandraEventLogSettings per event log, a user might expect that he can also override the keyspace or connect-retry-max configuration settings, for example, but this is actually not the case. Hence, a 👎 on your proposal.
An implementation with clear semantics should distinguish global settings from log-specific settings in the *Settings type. However, this would mean a bigger redesign. Alternatively, you could allow event log instances to override the partition-size. For example, this could be done by creating a subclass of CassandraEventLog that overrides a default partitionSize method. Alternatively, the partition size could be a constructor parameter.
WDYT?

Ok, I get your point. Originally I just wanted to add a partitionSize constructor parameter only but wasn't sure what this would lead to when you want to add more eventlog specific configuration parameters. That's why I went for the whole settings approach this time.

@krasserm I've just pushed the discussed alternative approach of splitting the Cassandra related settings into global (CassandraSettings) and event log specific ones (CassandraEventLogSettings).
Just let me know if I am getting closer :D

@kongo2002 any plans to work on that ticket further?

@krasserm Sorry for the delayed response. Right now I don't see me having spare time to push this PR any further. Although I think this is a reasonable feature to integrate, for now I do have a work-around for this 'issue' in-place.


Screen Capture API: getDisplayMedia() to capture screen

Document/update getDisplayMedia() docs.
Trello card: https://trello.com/c/0oNSHXub/36-screen-capture-api-fx-64
Acceptance criteria

[ ] All tasks in Trello completed, unless otherwise determined.
[ ] Submitted to engineering for review

@a2sheppy Is this continuing into Diana Ross (Sprint 4)?


ROX-19615: Show more test debug on openshift

Description
The test is passing on GKE but failing on Openshift. Trying to catch what is the difference.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change

This is about a flaky/faulty test, so running it many times is the way to go

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test all

/test ?

/retest-times 10 ocp-4-15-qa-e2e-tests

/test ocp-4-15-qa-e2e-tests

This test has passed over 20 times. There are no flakes on master for a week already. Closing this PR, as it does not introduce any relevant changes except of debug logging.


Support dynamically generated tests

The adapter doesn't seem to support tests that were generated dynamically. For example, I have a test file whose tests are generated from a .json file containing test scenarios (from the commonmark spec). The Test Explorer shows the file was discovered, but I am unable to see any results from the tests:

I assume that the generated files are actually create on disk.  If that isn't the case, let me know.
Also, are you running all the tests at once, or just running specific ones?
Looking at your screenshot, it appears that the test file was found, but no tests were found in that file.  There are some limitations of the parser, which will hopefully be addressed soon (checkout the jest-editor-support package).  You might find more information in the logs about the parsing of the tests and if the parsing actually resulted in an error, then the latest version of the extension should have visual feedback as well.
If you can show a sanitised sample of the generated test, then I might be able to spot an issue, or debug it locally.

I looked into this a bit and I believe this is a limitation of the jest-editor-support package that you depend on, as it actually parses the test file and looks for calls to describe, it, and other similar functions. This won't work for dynamically generated tests like the ones in my case, as it requires runtime evaluation:
https://github.com/rbuckton/tsdoc/blob/6726d44fb4cce79a82fa4c3d30e0e7317e5c9b6b/tsdoc/src/beta/parser/__tests__/commonmark/spec.test.ts#L41-L59
for (const [section, tests] of groupBySection(allTests)) {
    (onlySections.has(section) ? describe.only :
        (skipAll || skipSections.has(section)) ? describe.skip :
        describe)(section, () => {
        for (const test of tests) {
            (onlyExamples.has(test.example) ? it.only :
                skipExamples.has(test.example) ? it.skip :
                it)(`<https://spec.commonmark.org/0.29/#example-${test.example}>`, () => {
                const parser: BlockParser = new BlockParser(test.markdown);
                const document: Document = parser.parse();
                const emitter: HtmlEmitter = new HtmlEmitter();
                emitter.emit(document);
                const actual: string = emitter.toString();
                expect(actual).toBe(test.html);
                expect(document).toMatchSnapshot();
            });
        }
    });
}

I've instead switched to generating the entire test file as part of a pre-build step, which allows jest-editor-support discovery to work.
While you can probably close this issue as something unactionable, if you do want to consider a blanket workaround one option might be to still try to run tests in a file where tests aren't discovered and report results in some fashion (possibly just on the file itself).

Thanks for the example code - I see what you mean by generated now.
There are some significant things to overcome for this to work, which I'll have to think through.  But there are a number of other issues where the parser isn't able to identify the tests, but the test results will be available when the tests are run.  The issue is, since I can't allocate the test results to a discovered test, they are just swallowed.  As I mentioned, there are a couple of open issues to do with the parser failing to interpret a test file.  The test results would be present in those cases too, but then can't be associated to a parsed file.


scheduler: loadware filter support estimated

Ⅰ. Describe what this PR does

What is your proposal:
add estimation in the Filter stage like in the Score stage, take the estimated pod usage into consideration.
for prod pod, usage= prodPodUsage + estimatedProdPodUsage
for batch pod, usage = estimatedPodUsage + nodeUsage - estimatedPodActualUsage
Why is this needed:
Currently, the LoadAware plug-in of koord-scheduler supports request estimation in the Score stage, but not in the Filter stage. So we should consider supporting the estimation of the Filter phase to ensure that few newly created Pods are not crowded in the same node and exceed usage
Ⅱ. Does this pull request fix one issue?
issue: https://github.com/koordinator-sh/koordinator/issues/1908
V. Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in make test

@AdrianMachao Sorry, thanks for your contribution but it seems to duplicate #1992.

It's too regrettable， is there any other issue of scheduler and descheduler I can do?

@AdrianMachao Sorry, thanks for your contribution but it seems to duplicate #1992.

It's too regrettable， is there any other issue of scheduler and descheduler I can do?

[> > @AdrianMachao Sorry, thanks for your contribution but it seems to duplicate #1992.

It's too regrettable， is there any other issue of scheduler and descheduler I can do? @saintube

emm, would you like to solve this #2097

[> > @AdrianMachao Sorry, thanks for your contribution but it seems to duplicate #1992.

It's too regrettable， is there any other issue of scheduler and descheduler I can do? @saintube

emm, would you like to solve this #2097 ?

[> > @AdrianMachao Sorry, thanks for your contribution but it seems to duplicate #1992.

It's too regrettable， is there any other issue of scheduler and descheduler I can do? @saintube

emm, would you like to solve this #2097 ?

willing to do this


Empty RBAC dashboard

Hi there,
All is in the title, every dashboard works fine, but RBAC dashboard is fully empty.
Any idea ?
Thanks

Hi Cedric. Please check this out.
https://github.com/Azure/ccodashboard/blob/master/install/TroubleshootingGuide.md#rbac-information-is-empty-or-blank
Also make sure you have delegations in place


Add Laravel 5.5 support

This pull request replace #78 and #79 based on feedback.

Added support for Laravel 5.5
Added tests for PHP version 7.1 and 7.2
Removed tests for HHVM

This should be good to merge into the 3.0 release since it doesn't break anything. This could alternatively be released in a new minor release.

@TomLingham is there anything else I can add, fix or remove to get this pull request merged?

@TomLingham is there anything else I can add, fix or remove to get this pull request merged?

Laravel 5.5 was released today. Any chance we can get this merged?

Sorry. I've been out of action for the last few weeks. Looks good!

Thanks @TomLingham!


Feature/ot rt1060 support

Adding an "Experimental support" of Openthread on IMXRT1060 as a hosted solution .

@googlebot I signed it!

@googlebot I consent.

@googlebot I consent

@chapongatien , thanks for this PR.
Can we address the TODO below?
https://github.com/openthread/ot-nxp/blob/908d2260d5154f81e61d27bdd553abbe17406a30/script/test#L47-L49

Branch has been rebased to the top of the main branch. RT1060 build automation has been enabled. The arm-gcc-4 version has been removed because the RT1060 SDK does not support it.


Catastrophic collapse in episode score on cartpole_a3c

Hi,
First of all I just want to say awesome work on the library overall, really love the concept :+1:
I have an issue where cartpole_a3c will converge relatively quickly (around ep 300-400). Then keep doing well, and then suddenly collapsing and not recovering. Has anyone else experienced this?

Thank you for your compliment.
Now the reward which is given to agent when the episode is over before 500 timestep is -100.
I think this is too big so it can influence network's stability. I am curious about the result when change the reward from -100 to -10 or -1.


Fixed functions in visual script not showing correct return value type

#58535
In VisualScriptEditor::_selected_connect_node:
if (Object::cast_to<VisualScriptFunctionCall>(vnode.ptr()) && p_category != "Class" && p_category != "VisualScriptNode") {
	Vector<String> property_path = p_text.split(":");
	String class_of_method = property_path[0];
	String method_name = property_path[1];

	Ref<VisualScriptFunctionCall> vsfc = vnode;
	vsfc->set_function(method_name);

vsfc->set_function(method_name) causes VisualScriptFunctionCall::get_output_value_port_info to be called which sets the return value type using ret = method_cache.return_val;. But method_cache.return_val is set in VisualScriptFunctionCall::_update_method_cache only if
MethodBind *mb = ClassDB::get_method(type, function);
if (mb) {
	use_default_args = mb->get_default_argument_count();
	method_cache = MethodInfo();

mb is valid, but it never is because type is always empty when call_mode == CALL_MODE_SELF, because:
else if (call_mode == CALL_MODE_SELF) {
	if (get_visual_script().is_valid()) {
		type = get_visual_script()->get_instance_base_type();
		base_type = type; //cache, too
		script = get_visual_script();
	}

get_visual_script().is_valid() is never valid because it is set with VisualScript::add_node function which is called after the vsfc->set_function(method_name), so type never gets set.
In Godot 3.4  this block of code (which calls VisualScript::add_node):
int new_id = script->get_available_id();
undo_redo->create_action(TTR("Add Node"));
undo_redo->add_do_method(script.ptr(), "add_node", new_id, vnode, pos);
undo_redo->add_undo_method(script.ptr(), "remove_node", new_id);
undo_redo->add_do_method(this, "_update_graph", new_id);
undo_redo->add_undo_method(this, "_update_graph", new_id);
undo_redo->commit_action();

was called before vsfc->set_function(method_name), so it worked correctly. Now after moving it before vsfc->set_function(method_name) it appears to also work correctly:
https://user-images.githubusercontent.com/25117425/155870573-027b55ab-f545-484e-82d8-c23ce161cf4e.mp4
Bugsquad edit: Fix #58535

Closing as we just removed VisualScript for 4.0, so this can no longer be evaluated as is.
The VisualScript module has been moved to https://github.com/godotengine/godot-visual-script with the aim that it might be ported to a GDExtension if there are interested contributors to do so. Further work to improve the features could be done on that repository too (so currently there isn't anyone dedicated to maintain this repository, it will depend again on whether some contributors step up to do so).


refactor: color scheme #1245

for issue #1245
Change the theme color switching scheme to switch color variables.  This is beneficial for removing or adding color schemes at a very small cost.
This may bring compatibility issues, but most browsers now support CSS variables.
https://developer.mozilla.org/zh-CN/docs/Web/CSS/var
Or licensed for use https://github.com/jhildenbiddle/css-vars-ponyfill Compatible with old browsers.
Most styles should be the same, with known differences being code block themes. reference

https://gohugo.io/content-management/syntax-highlighting/
https://xyproto.github.io/splash/docs/all.html

The code block uses GitHub and OneDark themes instead of three very long variables.

Hi @kkbt0, thanks for you contribution! If I am understanding you correctly, your work is a useful refactor on the current color system. However, I fail to see how it relates to the original issue.
My intention for #1245 is to (visually) adjust the current dark color theme and remove the black theme altogether. DoIt is also in the process of migrating from SCSS to Tailwind CSS for better maintainability. Hence my original plan for this is to

Decide a new set of colors to be used for the dark theme,
Define them inside Tailwind config https://tailwindcss.com/docs/customizing-colors#using-custom-colors (Specifically with CSS variables for better customisability https://stackoverflow.com/questions/72117668/tailwind-colors-based-on-dark-mode),
Add color classes to the HTML elements and remove them from SCSS.

You might notice this PR may not fit very well with the plan, and I am deeply sorry that I failed to explain my intentions more clearly in the original issue.
Here are some context behind the original issue: #1, #654, #1176.
I'd like to hear your thoughts on this.
Many thanks
PCloud

Well . I also don't kown the best method. I only used default and dark in TailwindCSS .
Should it be like this? > https://play.tailwindcss.com/KDVQG5ULlM  (This example overlooks .)
However, I anticipate that the class length for Hugo's {{ .Content }} typography prose class  will be quite lengthy. It'll be a big project.

Should it be like this? > https://play.tailwindcss.com/KDVQG5ULlM (This example overlooks .)

I was thinking about something like
@tailwind base;
@tailwind components;
@tailwind utilities;

@layer base {

  :root {
    --color-primary: 247 147 34;
    --color-text: 33 33 33;
    --color-success: 0 200 81;
    --color-info: 51 181 229;
    --color-warn: 255 187 51;
    --color-error: 254 78 78;
  }

  :root[class~="dark"] {
    --color-primary: 247 147 34;
    --color-text: 33 33 33;
    --color-success: 0 200 81;
    --color-info: 51 181 229;
    --color-warn: 255 187 51;
    --color-error: 254 78 78;
  }
}

/** @type {import('tailwindcss').Config} */
module.exports = {
  darkMode: "class",
  theme: {
    colors: {
      primary: "rgb(var(--color-primary) / <alpha-value>)",
      text: "rgb(var(--color-text) / <alpha-value>)",
      success: "rgb(var(--color-success) / <alpha-value>)",
      info: "rgb(var(--color-info) / <alpha-value>)",
      warn: "rgb(var(--color-warn) / <alpha-value>)",
      error: "rgb(var(--color-error) / <alpha-value>)",
      transparent: "transparent",
      current: "currentColor",
    },
}

(Reference: https://stackoverflow.com/questions/72117668/tailwind-colors-based-on-dark-mode)
And the user can override any of the CSS variables inside the override.scss https://github.com/HEIGE-PCloud/DoIt/blob/0b8fa13d34e16201452979fa00ff2a22d9bafba6/assets/css/_override.scss#L3
I am not planning to support multiple color themes for now since we are even struggling to coming up with a single color palette for the dark theme. I believe ad hoc customisations for individual color elements will be more useful for the users and easier for us to maintain.

However, I anticipate that the class length for Hugo's {{ .Content }} typography prose class will be quite lengthy. It'll be a big project.

The prose class will indeed be lengthy if we eventually migrate completely to Tailwind, and I am not even sure that's a good idea. But fortunately Tailwind CSS has very good suppport for progressive migration, and it seems to be working quite well integrating with the existing SCSS setup. I am planning to migrate piece by piece lazily rather than all in one go.
Specifically, I want to style all new features using Tailwind, and it worked quite well in the past (See https://github.com/HEIGE-PCloud/DoIt/pull/1214/files#diff-b15932692c619f9a334ecb156ac167557c3af214a8a3df8990c09232ac8a5baa). I also want to migrate existing styles to Tailwind when we are refactoring, so I see both #1236 and #1245 as good opportunities for doing so.

Okay, in the example of stackhoverflow, defining the appearance through CSS variables can also easily increase or decrease the theme. In fact, I like these three themes without considering the CSS file size and the large number of duplicates in the two dark modes.(Especially with the addition of code color parameters, the three theme color variables seem to exceed Github's approximately 1000 lines of colors variables .)
So next step we should define all need color variables  in  a file and use them in tailwind.config.js . Then, step by step, replace the definition of font and background color with class in html .

Regarding the issue of Tailwindcss Class being too long, I have tried Unocss Shortcuts . This will put all Tailwindcss classes into a self named class. Just be like https://daisyui.com/

So next step we should define all need color variables in a file and use them in tailwind.config.js . Then, step by step, replace the definition of font and background color with class in html .

Nice, sound good!

Regarding the issue of Tailwindcss Class being too long, I have tried Unocss Shortcuts . This will put all Tailwindcss classes into a self named class. Just be like https://daisyui.com/

I am not very sure on this one. I don't necessarily see "classes being too long" as an issue, if an element requires a lot of styling, then the class name can be long - that's what it takes to express such information. Utilities like Unocss Shortcuts does not really reduce the classes, it just moves it from HTML to the config file, which in my view defeats the purpose of atomic CSS. The whole idea is that when the style and the element is co-located, it minimises the coupling of the styles between different elements - I no longer need to worry whether changing the style of one element might potentially break the style of another. I think the right way to reduce duplication in styles is to use partial templates to extract elements as reusable "components" but keep the class names as is.

In some extreme cases, the number of classes can reach 20-30. for example a button in https://catalyst.tailwindui.com/ .
A container that is not the longest  in catalyst demo:

Actually, there are a lot of class when I am writing a grid element . This is indeed easy to write , but I'm not sure if this is highly readable and easy to maintain code.

Or create a template partia.After writing blog info card component, it should be like this. https://github.com/saicaca/fuwari/blob/main/src/components/PostCard.astro
Unocss Shortcuts corresponds to Tailwindcss @apply . Although Tailwind think that create a template partial or JavaScript component is better then use @apply.

I understand your idea, instead of writing
<div class="">

You write

and
.custom-div {
  @apply
}

My point is that this does not reduce the amount of classes you write, it merely moves it from one place to another. Now when you want to change the style for the div, you still need to deal with a very long list of classes - just in a different file. But even worse, now you don't know whether someone else is using the custom-div class and whether your changes will break other elements. I don't see how "a long list of class names" is less maintainable than "a large CSS file", if you have a lot of styles, you need to write a lot of code to describe that style, any attempt to hide it or add indirections will just make it worse.

In fact , my code likely be like this

.m-c-basic {
  @apply bg-white dark:bg-dark w-full h-full overflow-hidden rounded-lg border border-transparent card-transition shadow-[0px_0px_0px_1px_rgba(9,9,11,0.07),0px_2px_2px_0px_rgba(9,9,11,0.05)] dark:bg-zinc-900 dark:shadow-[0px_0px_0px_1px_rgba(255,255,255,0.1)] @container
}

.fc-jc {
 @apply  flex flex-col justify-center
}

.g-2-4 {
 @apply col-span-2 row-span-4 aspect-1/2
}

.g-md-1-2 {
 @apply md:col-span-1 md:row-span-2 md:aspect-1/2
}

CSS will be like
.m-c-basic {
    width: 100%;
    height: 100%;
    display: flex;
    border-width: 1px;
    border-color: transparent;
    border-radius: 0.5rem;
    container-type: inline-size;
    ....
}

Because this element needs to appear over ten times in the grid. So I abstracted and reused a portion of the code.Perhaps when changing shadows, there is no need to search and replace them in bulk. But I use @apply just to make things look “cleaner” .This may violate the principles in the tailwindcss document.

Which one is better ?

Ok, now let's say i want to change rounded-lg to rounded-full, if we are using m-c-basic, what do we do? Do we change the definition of m-c-basic? In which case we need to check every place that uses m-c-basic and make sure our changes are doing what we want. Do we add it to the back of the class list and try to override the rounded-lg provided by m-c-basic? Does it always have a higher specificity? Is this "maintainable"?
.m-c-basic {
  @apply bg-white dark:bg-dark w-full h-full overflow-hidden rounded-lg border border-transparent card-transition shadow-[0px_0px_0px_1px_rgba(9,9,11,0.07),0px_2px_2px_0px_rgba(9,9,11,0.05)] dark:bg-zinc-900 dark:shadow-[0px_0px_0px_1px_rgba(255,255,255,0.1)] @container
}

Is it really "clean"? We still have this long and unreadable m-c-basic in our config file, we just moved it from the markup to another place.

That is what i want to say. Sometimes we need molecules . The specific amount of aggregation depends on the project requirements.


How to do Extrinsic camera to camera calibration

Hi, I have two stereo zed camera and i am using usb_cam roslaunch application to launch left and right sensor of a stereo camera.
to do extrinsic camera calibration using "scripts/sensor_calibration.sh camera_camera"
how this step works?
how to pass topics name of each camera and get the yaml file.
my topics names are: /sideLeft/left/image_raw, /sideLeft/right/image_raw, /frontNear/left/image_raw, /frontNear/right/image_raw
i am trying this calib at lab setup.

Hi,
We use a lidar to calibrate cameras.
If you do not have a lidar, you need the to measure translation (x, y, z)  of a camera from IMU manually or using a vehicle model. For rotation, please align a camera to have ypr =[0, 0, 0] degrees. When aligned well the center of image should be a vanishing point and the central horizontal line should be aligned with a horizon.
Thank you,
Tae Eun

Hi,
I am trying to use the camera_camera calibrator node as well and have been unsuccessful in getting it to generate the output .yaml file. Has this issue been addressed/resolved? If not, what is the best way to do the extrinsic calibration for an Apollo setup without using sensor_calibration.sh?
Thanks,
Sneha

No It was not resolved to me... I am trying to figure it out how apollo calibration works...  did you find any source code of apollo calibration tool (camera_camera or camera_lidar) on github because i get those as binary tar file.

No I do not have access to the source code either, it is an executable.

Hi @techoe
I am able to run sensor_calibration.sh, but I get an INS_STAT not 56 (current is at -1) error. The issue is that ins_stat is publishing 56 and verifying it outside Apollo also shows INS_GOOD (which is ins_stat 56). Can you help out with this issue?
Thanks,
Sneha

Hi Sneha,
I have stoped using apollo auto for camera camera or any sensor extrinsic calibration.
I am trying out to do my own calibration using openCV aruco. try it out it might help you too. its a simple approach.
I am able to get camera to camera extrinsic calibration with other sensors.
Thanks,
Raghu

Thank you Raghu! Using openCV or your own target with known position is also one way. Apollo team will provide better solution later.

Hi @raghu31081987 - does this work with mono cameras? Or only Stereo (as far as I have noticed)

Hi Sneha,  It works for mono as well as stereo camera too... for stereo take any one sensor either left or right as center and find rotation and translation to other stereo left or right sensor. as Aruco marker will give you the distance of camera to marker. but there is some mathamatics need after you get result from Aruco.

You need to do stereo intrinsics calibration before this which might help you to get better accuracy.

The solution for the Apollo calibration tools issue was to set the uvcvideo clock to real time for the cameras (thank you @YangHan101 and @techoe).


✨ Compile React components for direct import

As it is now, the React components aren't compiled and thus can't be imported from the heroicons package. This PR will let users import them like so…
import { Menu, X } from "heroicons/react/solid
import { Menu as MenuOutline } from "heroicons/react/outline"

Hey,  yeah right now I was just hacking on some stuff to use in Vite which does support running this stuff right through the dev server, the current Vue/React versions of these icons aren't really "released" yet which is why they aren't documented :)
I noticed in the diff though it looks like the entire source code of React is embedded in the React icons, is this intentional?

@adamwathan No, just the first time I used Rollup to create a React component library. Sorry about that.

Don't be sorry I have literally no idea how to do it either 😅

@adamwathan I’ll take another stab at it tomorrow.

@adamwathan I think I got all that React code out of there.

Does this add support for Vue? As that would be awesome.
I looked at https://github.com/matschik/vue-hero-icons and https://github.com/imhassane/heroicons-vue but they don't look production ready and have poor TypeScript support.


Feature open chat

@stypr Thanks for pointing it out. Should be fixed in the latest commit https://github.com/line/line-sdk-ios-swift/pull/132/commits/b0f6e2d7d8ab6f6fd7b8922c782833ff4f6828ae

This makes a strong assumption that the server can always return the correct format for these IDs, and does not make a change in future. Otherwise, the client would suffer from a crash.


Binary store exception

From @rpalcolea:
Wondering if you could take a look at the following build: https://github.com/rpalcolea/halyard/tree/broken-build
Running ./gradlew :halyard-web:depInsight --configuration runtimeClasspath --dependency kork-core -s produces
Problems reading data from Binary store
Caused by: java.lang.IllegalStateException: Corrupt serialized resolution result. Cannot find selected module (442) for constraint platform-runtime -> io.fabric8:kubernetes-model:4.1.0

What is interesting about this build is that it doesn't have any nebula opinion, the only thing that appear to be in play is a platform BOM.
Curiously enough, removing a fix version from build files and letting the bom provide the versions solves the issue: https://github.com/spinnaker/halyard/commit/419f2b1ab1588329309cca0bb14caa681d7d1c08

The issue has been reproduced: it is a combination of a platform constraint having a lower version than the selected version and the logic for recomputing a version when a selector is removed.
However in that case, since the dependency was back to being pending (no hard edges pointing at it), it should simply leave the graph. Instead the bug in the current logic caused it to remain, but not selected, with an invalid, constraint only, single edge pointing at it.
Fix incoming


add Mob dir to CMakeLists.txt

Hi,
Please update CMakeLists.txt manually after changing the directory structure and try to build the game from terminal before committing.
It would be much easier for me to follow your progress!
Anyway you are doing a very good job, congratulations!
Zoltan

Ah sorry! I am not used to using cmakelists, I will try and make sure I do that in the future. Thank you!


MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

Change-Id: Ifedad2fae1ddd8f22623b5d44875b20a3b3fd318
Description of PR
Work in Progress. No review is needed yet, I'll update when I'm ready with my manual end-to-end tests.
How was this patch tested?
In progress...
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
I added ch.qos.logback for just a test dependency. LGPL.

[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 10s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 23s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 20s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 52s

trunk passed

+1 :green_heart:
shadedclient
26m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 12s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle: The patch generated 11 new + 8 unchanged - 29 fixed = 19 total (was 37)

+1 :green_heart:
mvnsite
0m 21s

the patch passed

-1 :x:
javadoc
0m 18s
/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-mapreduce-client-shuffle in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

-1 :x:
javadoc
0m 16s
/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
hadoop-mapreduce-client-shuffle in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.

+1 :green_heart:
spotbugs
0m 47s

the patch passed

+1 :green_heart:
shadedclient
26m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 35s

hadoop-mapreduce-client-shuffle in the patch passed.

-1 :x:
asflicense
0m 33s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

111m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle

uname
Linux ebbc81ae26e4 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ea8f12ade37f0739ddb48d317bea64c4c2ba59b1

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/1/testReport/

Max. process+thread count
538 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 56s

trunk passed

+1 :green_heart:
compile
0m 28s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 21s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 52s

trunk passed

+1 :green_heart:
shadedclient
25m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 11s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle: The patch generated 11 new + 8 unchanged - 29 fixed = 19 total (was 37)

+1 :green_heart:
mvnsite
0m 22s

the patch passed

-1 :x:
javadoc
0m 17s
/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-mapreduce-client-shuffle in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

-1 :x:
javadoc
0m 16s
/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
hadoop-mapreduce-client-shuffle in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.

+1 :green_heart:
spotbugs
0m 46s

the patch passed

+1 :green_heart:
shadedclient
26m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 36s

hadoop-mapreduce-client-shuffle in the patch passed.

-1 :x:
asflicense
0m 33s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

110m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle

uname
Linux 4edd60006a54 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8fefb83f680483ba0f8efa0094e22ab1d6f8bf8e

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/2/testReport/

Max. process+thread count
630 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
45m  0s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 26s

trunk passed

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 22s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 52s

trunk passed

+1 :green_heart:
shadedclient
26m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle: The patch generated 1 new + 5 unchanged - 32 fixed = 6 total (was 37)

+1 :green_heart:
mvnsite
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 20s

hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)

+1 :green_heart:
javadoc
0m 18s

hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08 with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08 generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)

+1 :green_heart:
spotbugs
0m 53s

the patch passed

+1 :green_heart:
shadedclient
28m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 37s

hadoop-mapreduce-client-shuffle in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

110m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle

uname
Linux 5c70fe9bae8f 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6c572c8c9c7f67117069c7c67228a608dd24021a

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/3/testReport/

Max. process+thread count
615 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 28s

trunk passed

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 23s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 28s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 21s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 52s

trunk passed

+1 :green_heart:
shadedclient
26m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 13s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle: The patch generated 1 new + 5 unchanged - 32 fixed = 6 total (was 37)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 17s

hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)

+1 :green_heart:
javadoc
0m 16s

hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08 with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08 generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)

+1 :green_heart:
spotbugs
0m 45s

the patch passed

+1 :green_heart:
shadedclient
27m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 36s

hadoop-mapreduce-client-shuffle in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

110m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle

uname
Linux 2b5931453a0f 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 59a1f409101c47c76bb3078987a4cd41f4f68e63

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/4/testReport/

Max. process+thread count
585 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5311/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

+1, non-binding

Thanks @tomicooler, the patch looks good to me, merged to trunk. Thanks @K0K0V0K for the review.

the test is failing now:
https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1143/testReport/junit/org.apache.hadoop.mapred/TestShuffleHandler/testMapFileAccess/
Though it passes locally for me.
Looks like something specific to jenkins:
Caused by: java.io.IOException: Owner 'jenkins' for path /tmp/test-shuffle-channel-handler1169959588626711767/job_1111111111111_0001/testUser/attempt_1111111111111_0001_m_000001_0/index did not match expected owner 'testUser'

anyone planning to fix or should we revert this?

the test is failing now: https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1143/testReport/junit/org.apache.hadoop.mapred/TestShuffleHandler/testMapFileAccess/
Though it passes locally for me. Looks like something specific to jenkins:
Caused by: java.io.IOException: Owner 'jenkins' for path /tmp/test-shuffle-channel-handler1169959588626711767/job_1111111111111_0001/testUser/attempt_1111111111111_0001_m_000001_0/index did not match expected owner 'testUser'

anyone planning to fix or should we revert this?

MAPREDUCE-7434

Thank you Tamas for volunteering!!!


Update test script

This PR updates the test scripts system to avoid arbitrary code execution on testing. It is not a security risk for now, but this change is necessary for the new PR merging system I'm constructing.
This PR also includes the following improvements.

Avoid duplication of _scripts/test

Previously, all _scripts/test files had the almost same content.

Avoid listing dependencies by using the local source of rbs collection.

How
Preivously, _scripts/test files in each gem had testing logic. This PR removed the script and moved the logic to bin/test script.
To avoid code execution, Ruby DSL files (Steepfile and Gemfile) are generated by bin/test script.
I also add metadata.yaml file to declare test dependencies. If the gem has dependencies only for the testing, the user needs to write the dependencies to _test/matadata.yaml file.
This file is only for testing, so it does not affect the RBS user.

But, I feel that it would be good to provide guidelines on how to respond to existing PR authors.

@ksss
I'll take over existing PRs. I think I can merge most PRs. If I cannot merge a PR, I'll comment how to treat this change into the individual PR.

I have a suggestion for bin/test: how about putting help message out to help newcomers?

@ybiquitous
Thanks for your suggestion. It looks good!
But I'd like to apply this change in another PR after this PR merges. The CI process for this PR is really heavy because the CI runs for all gems on this PR.
I'll create a PR with your suggestion. Thanks.

I'll create a PR with your suggestion. Thanks.

Never mind. Glad to hear! 👍🏼


cruft remains in setup.cfg

Commit https://github.com/MolSSI/cookiecutter-cms/pull/152/commits/800f4926e65f1883a996f344ac5eced7f2723e96 got partiallyl reverted somewhere in the merge history, and now duplicates project metadata and setuptools configs that were supposed to be moved to pyproject.toml.

@eirrgang - are you referring to lines 7-60 in setup.cfg? I see that (all?) of that info is also in pyproject.toml.
https://github.com/MolSSI/cookiecutter-cms/blob/main/{{cookiecutter.repo_name}}/setup.cfg#L7

@eirrgang - are you referring to lines 7-60 in setup.cfg? I see that (all?) of that info is also in pyproject.toml.
https://github.com/MolSSI/cookiecutter-cms/blob/main/{{cookiecutter.repo_name}}/setup.cfg#L7

Exactly. Originally, commit 800f492 moved that stuff (with syntax updates) from setup.cfg to pyproject.toml, but somehow it got muddled in subsequent merges, and both were retained.


CLient side setup

I have the case where initial setup is generated client side, based on things that server is completly not aware of. Problem is that setup is defined on Game object that is imported by both client and server so only way to have dynamic client side generated setup is to have artificial setSetup move and call it.  Isn't better to expose setup api to be pure client side and then overwrite the server state if called?

For the future, @nicolodavis, what do you think about delaying game state initialisation until after the last player has joined? That would allow the /join endpoint to receive player-specific setupData to stash in gameMetadata, which could be consumed by CreateGame once the final seat is taken.

Sorry about missing this thread earlier.  What's an example of per-player setup data in a real game?  Are we talking about true metadata (like a player name or badge) or something that has a meaning within the game?
I'm definitely open to supporting the use-case if we can find some compelling examples.

I don't have a super concrete example myself. Aside from metadata, I can think of something where players might need to choose a class of character or a strategy that might change setup. I'd be interested in other people's needs. I don't think it's super urgent as it can I think always be handled using setup phases/moves instead but I wanted to mention it in the other thread in case it was a consideration for other lobby changes.

I see.  It makes sense to have players bring in their own metadata if this choice of character class or some other game aspect happens outside the view that boardgame.io handles (for example in a custom lobby component).
On the other hand, it's easy enough to have players make the choice inside the game itself like you mentioned.  Perhaps the difficulty that arises is the fact that these moves logically belong to a "pre-game" phase.
On a related note, we have toyed around with the idea of a "start game" event before (analogous to "start phase").  I wonder if that makes these use-cases more naturally implementable.

To be fair, what would such a start game event/phase do that a handmade setup phase couldn't? I think you're right that it's partly confusing because people think of these setup tasks as “pre-game”. Maybe it's just a case of some documentation of that pattern, e.g. a more advanced tutorial than the tic-tac-toe one that uses a setup phase and perhaps stages seeing as neither of those are covered by the introductory tutorial. It's simple enough to toggle a game view based on the current phase so even if a setup phase needs custom UI it's fairly straightforward to do.
(As a sidenote: In the fork of the lobby server I'm using, I did end up initialising game state after all players have joined so I could pull player nicknames from the metadata into the game state. I did that for logging messages that should say things like “Nickname did X”. In theory, I could use some kind of template substitution to store the ID in game logic and replace it with the nickname from metadata on client, but this made my life easier at the time.)

One other option would be to have setupData arguments accepted by both the create and join endpoints. The server could create a game (without yet initialising state) with some data that impacts what players can then choose in the lobby when joining, then the join action accepts player-scoped data. Once the final player joins the game would initialised with the setupData and the player-specific data.
An example use case:

You can create a game with different character sets

You can join the game choosing from the selected character set

I'll spend more time digging into the lobby implementation as I try to convert it to Svelte, so I'll have a more informed opinion after that.  My intuition tells me that choices that the players make on the lobby screen should be handled outside boardgame.io, with the game given the eventual setupData when it is finally instantiated after all players have joined.
Choices made once the game has started (using a "pre-game" phase) can be handled by boardgame.io quite easy without any changes.  It just requires documenting the pattern like you say.


Example:
The following request allows us to load the files under /test-load directory with "hello" prefix:
curl -X GET http://localhost:28080/v1/load?path=s3a://jiamingmai-test/test-load&opType=submit&verbose=true&fileFilterRegx=^hello.*

Mostly LGTM. We need to add these filter information into journal entry so we can recover from crash. Also can we add a test for this? We can try to follow loadcommandTest

Updated. Tests are added in LoadCommandTest.

alluxio-bot, merge this please


Delete TypeChecker::callWitness.

This is no longer used, and has been migrated away from.

Amazing work, thank you!

@swift-ci please smoke test


[Demo] Fix UnknownHostException: host.docker.internal in docker demo

Important Read
Fixed #429
What is the purpose of the pull request
Fix UnknownHostException: host.docker.internal in docker demo under Linux OS.
MetaException(message:Could not connect to meta store using any of the URIs provided. Most recent failure: org.apache.thrift.transport.TTransportException: java.net.UnknownHostException: host.docker.internal
	at org.apache.thrift.transport.TSocket.open(TSocket.java:226)
	at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.open(HiveMetaStoreClient.java:478)
	at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.<init>(HiveMetaStoreClient.java:245)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at org.apache.hadoop.hive.metastore.MetaStoreUtils.newInstance(MetaStoreUtils.java:1740)
	at org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.<init>(RetryingMetaStoreClient.java:83)
	at org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.getProxy(RetryingMetaStoreClient.java:133)
	at org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.getProxy(RetryingMetaStoreClient.java:104)
	at org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.getProxy(RetryingMetaStoreClient.java:97)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.iceberg.common.DynMethods$UnboundMethod.invokeChecked(DynMeth

Brief change log
We can use docker container hostname.
Verify this pull request
locally.

hi @the-other-tim-brown can you take a look, please?

hi @vinishjail97 can you help to take a look? thanks

I have <IP_ADDRESS> kubernetes.docker.internal added to /etc/hosts, I'm guessing that is how I'm able to make this work without these changes. I will try this out though on my machine and validate it works with the updates

I'm running into java.io.FileNotFoundException: File file:/home/data/db/hudi_dimCustomer/metadata/00001-64637ad8-218d-496d-aa33-52db8188727b.metadata.json does not exist right now. @daragu did you ever see something similar?

I'm not able to re-produce the issue from my side, added a comment on the issue.
https://github.com/apache/incubator-xtable/issues/429#issuecomment-2105976390

I'm not able to re-produce the issue from my side, added a comment on the issue. #429 (comment)

hi @vinishjail97, I think host.docker.internal is effective in Docker Desktop environment, but not in systems such as Linux.
https://docs.docker.com/desktop/networking/#i-want-to-connect-from-a-container-to-a-service-on-the-host

@daragu can you squash your commits? I was able to confirm this is working after resetting some things on my local env.

Done, thanks.


Certificate error

I'm trying to list available formats for live stream but get the following exception.
$ youtube-dl -F http://www.youtube.com/watch?v=SwrKzkRUlaw
[youtube] Setting language
[youtube] SwrKzkRUlaw: Downloading webpage
[youtube] SwrKzkRUlaw: Downloading video info webpage
[youtube] SwrKzkRUlaw: Extracting video information
[youtube] SwrKzkRUlaw: Downloading formats manifest
Traceback (most recent call last):
  File "/usr/lib/python3.4/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.4/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/local/bin/youtube-dl/__main__.py", line 18, in <module>
  File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 889, in main
  File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 879, in _real_main
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1052, in download
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 516, in extract_info
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 170, in extract
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 868, in _real_extract
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 579, in _extract_from_m3u8
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 283, in _download_webpage
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 223, in _download_webpage_handle
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 203, in _request_webpage
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1231, in urlopen
  File "/usr/lib/python3.4/urllib/request.py", line 455, in open
    response = self._open(req, data)
  File "/usr/lib/python3.4/urllib/request.py", line 473, in _open
    '_open', req)
  File "/usr/lib/python3.4/urllib/request.py", line 433, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.4/urllib/request.py", line 1230, in https_open
    context=self._context, check_hostname=self._check_hostname)
  File "/usr/lib/python3.4/urllib/request.py", line 1189, in do_open
    h.request(req.get_method(), req.selector, req.data, headers)
  File "/usr/lib/python3.4/http/client.py", line 1090, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python3.4/http/client.py", line 1128, in _send_request
    self.endheaders(body)
  File "/usr/lib/python3.4/http/client.py", line 1086, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python3.4/http/client.py", line 924, in _send_output
    self.send(msg)
  File "/usr/lib/python3.4/http/client.py", line 859, in send
    self.connect()
  File "/usr/lib/python3.4/http/client.py", line 1233, in connect
    ssl.match_hostname(self.sock.getpeercert(), server_hostname)
  File "/usr/lib/python3.4/ssl.py", line 288, in match_hostname
    % (hostname, dnsnames[0]))
ssl.CertificateError: hostname 'manifest.googlevideo.com' doesn't match 'www.google.com'

This live event has ended.


Bazel 1.2 announcement

Suggested:
## Community updates

* Ignacio Le Fluk explained how to do [Fullstack development with Bazel](https://dev.to/thisdotmedia/fullstack-development-with-bazel-16ic), using Javascript and Typescript.

* Sergio Fernández wrote about [Building Faster in iOS with Bazel](https://medium.com/@fdzsergio/building-faster-in-ios-with-bazel-448a3074e73).

* Ahir Reddy and Li Haoyi did a presentation at Scale By The Bay 2019: [Speedy Scala Builds at Databricks](https://www.youtube.com/watch?v=fs-TkRkFgDI).

* Nathan Froyd is evaluating Bazel for building Firefox ([part 1](https://blog.mozilla.org/nfroyd/2019/10/28/evaluating-bazel-for-building-firefox-part-1/), [part 2](https://blog.mozilla.org/nfroyd/2019/11/01/evaluating-bazel-for-building-firefox-part-2/)).

* Oasis Digital has announced new 3-day trainings [Building with Bazel](https://oasisdigital.com/class/bazel).

Applied all suggestions.


Securing Tornjak with Keycloak

Referencing - https://github.com/spiffe/tornjak/issues/61
Specific plan details for Tornjak React Front-End and GO Back-End

[x] Two Clients configured in Keycloak - one for frontend and one for backend under the Tornjak realm
[x] Frontend client has public access since it just needs to log in and redirect to a valid URI after successful login (Turn off client Authentication under clients settings - When it's ON, the OIDC type is set to confidential access type. When it's OFF, it is set to public access type)
[ ] Backend client has bearer-only since bearer token included in the request and it never initiates login on its own.
[x] Realm roles and client roles assigned and mapped for both clients
[x] Roles embedded with the JWT Token through Keycloak configuration, now we can get the client roles from the JWT token with the “roles” key.
[x] Initially user sees the Keycloak login page
[x] User tries to log in to the front-end react application
[x] User will be redirected to the Keycloak server for authentication.
[x] If authentication is successful, Authenticated user will be redirected to the Tornjak application. At the same time, the user will get a JWT (JSON Web Token).
[ ] Send the token as a header to the back-end with the request
[x] Unauthenticated users will be redirected back to the Keycloak login page.
[ ] With the valid token, the front-end can access the back-end GO rest API by sending the token along with the service request.
[ ] Back-end will communicate with the Keycloak server to validate the token.
[ ] Back-end will check specified role for the user
[ ] Back-end will make APIs accessible based upon the specific roles (Admin or Viewer)
[ ] If the token is valid, the back-end will serve the request accordingly.
[ ] If the token is invalid, the back-end will respond with error code 401 (Unauthorized) or 403 (forbidden) for a specific role.
[ ] Logout - redirected back to key cloak login page

@mamy-CS It might also be important to consider the logic of expiring tokens which may require using refresh token? I'm unsure how the logic would work there, although it is likely a frontend issue, as the backend only needs to respond that the token is expired.

We are looking for feedback on how we will integrate Keycloak as a user management tool with Tornjak.
Proposed Oath2-inspired Protocol
We propose the following protocol of single sign-on and resource access via JWT access tokens.

Single sign-on involves redirect the user to Keycloak login to obtain an JWT used to request to the Tornjak backend.

Resource Access involves the use of the JWT obtained during single sign-on to make requests to the Tornjak backend.

In order to set this up, we would need to configure Keycloak such that the Tornjak frontend and backend are each a client applications under one Keycloak realm.

Implementation of Authorization
Currently, we are looking to create two user roles and allow two levels of access to resources:

Viewer: may view and download information on all resources
Admin: may view and download information, but also may create and manage clusters and spire entities

There are two ways we can implement the authorization of this logic.

Application-level implementation of authorization:

Tornjak backend receives a request, and calls Keycloak to verify a sent JWT access token
Keycloak authenticates and sends back the name of the role associated with the user
Tornjak responds based on the role name and request. Because of our pre-defined two-level access logic, this is easily implementable

Keycloak-level implementation of authorization:

Tornjak backend receives a request, and calls Keycloak to verify a sent JWT access token
Keycloak authenticates, and checks logic implemented internally that a user may access a certain API
Tornjak receives Keycloak authentication and authorization, and performs request based solely on Keycloak response, not role

Pros of the former method:

The logic is wrapped in Tornjak itself, and makes setup or learning Tornjak easier
There is a potentially easy workaround down the line if one wants more granularity with authorization protocols.

Pros of the latter method:

There is more flexibility overall in implementing more complicated authorization policies in the long run
While this requires more work to configure, Keycloak offers ways to import and export authorization configs, which perhaps it would be useful for us to look into and provide

Feedback requested:
Some specific questions we would like feedback or suggestions on:

Is there significant benefit/drawback in implementing the authorization protocol listed above differently? Perhaps there is a way that can give more control over direct SPIRE entities?
More generally, what kind of granularity might we want in a resource management plane of SPIRE?


External JSON config file rootAttributes setting is ignored and causes error with command line tool

When running the svn-sprite command line tool to generate our SVG sprite sheets, we are seeing the following error message:
[ERROR] Skipping --svg-rootattrs file due to errors ("Path must be a string. Received { preserveAspectRatio: 'none' }")
The tool generates a sprite sheet file, but the attributes are not added to the resulting file.
I can reproduce the error with this command line and the attached config file:
svg-sprite.js --css css-render-css --dest=out --config=./svg-sprite.json iconsets/*.svg
svn-sprite.json:
{   "svg": {     "rootAttributes": {       "preserveAspectRatio": "none"     }   },   "log": "info" }
This appears to be caused by the way that svg-sprite.js merges the config file settings (lines 166-197) with the command line settings returned from the yargs library (lines 158-163) and then assumes that the valid svg.rootAttributes value should be a string (line 207.)
If I have time this weekend I will try to prepare a PR to fix this.

This may be a similar problem to these issues:
#162
#199

The problem was the internal handling of the rootAttributes option in CLI. It was expected to be a string (file path) even if it had already been set via an external config file. Should be fixed now. :)


Is it possible to release a roberta-base model as well?

Since large models are not really practical for us to deploy, but roberta did have a large jump on the QUOREF dataset. Do you plan to release a CorefRoberta-base model?

Hi,
I uploaded the CorefRoBERTa-base model just now. Hope that it is helpful for you.
Best,
Deming

Great.


Server UI shows "undefined" for environment variable populated from a secret

Summary
When an environment variable is populated from a secret, the server UI shows undefined for its value. This is highly confusing because the user's first reaction is that the secret value isn't being correctly passed. This messaging could be improved by showing secret or hidden or something to that effect, to indicate that the value does exist, but is not displayed.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Thank you for the bug report. Would you like to submit a PR to fix this?

I would like to, if I can get to it in the next couple of weeks!

You probably don't need to know Go to do this. I think you need to change: ui/src/app/workflows/components/workflow-node-info/workflow-node-info.tsx

I'm working on this bug for Hacktoberfest. @alexec I'd like to not only fix the bug but maybe tweak it a bit to differentiate not available values from secrets. I was thinking having the value show as [redacted] (or something similar) when the value is a secret, and showing not available for other reasons. Where would you say is the best place to put that logic?

@aletepe I don't think the actual value will be returned by the API call. So I don't think you'll need to redact it. What will be useful is showing it is from a secret (e.g. using an FontAwesome icon, e.g. <i className='fa fa-key'/>), the name of the secret and key within it. This allows the user to then go and look it up themselves if they need to.

@alexec I meant writing literally redacted, so as to make users understand there was actually a value behind it and not simply that there is no value available, and thus avoiding the confusion which led to raising this bug.
I like the idea of showing a more details about the secret, like the icon you mention 👍
PS: could you please assign this issue to me? Thanks before hand!

sure or maybe "secret"?

@ebr could you please add to the Issue description a screenshot of the UI showing undefined? And maybe steps to reproduce it (an example yaml file or similar)?

I've used the example in the docs here: https://github.com/argoproj/argo/blob/master/examples/secrets.yaml
Without changes the behaviour is the following:

With my proposed changed it would look something like this (injected two secrets to show multiline behaviour):

It would still show undefined like in the first screenshot for undefined values not coming from secrets.
@alexec @ebr how is this looking?

Looks great!
Can I ask that when you hover your mouse of the key icon you get some explanatory text?

Something like this?

The value of this environment variable has been hidden for security reasons because it comes from a kubernetes secret.

perfect

Hello,
I am using argo with the following version
argo: v3.2.6
BuildDate: 2021-12-17T20:59:31Z
GitCommit: db7d90a1f609685cfda73644155854b06fa5d28b
GitTreeState: clean
GitTag: v3.2.6
GoVersion: go1.16.12
Compiler: gc
Platform: darwin/amd64
When running a workflow on argo, I am still getting the label undefined for the environment variables within the container. Why is that still happening? I thought this was resolved from v.3.0.0.

Thanks a lot for your help!


Translating Node js-xlsx to Browser

I'm having problems translating a working node script to work in browser (Angular 1.6 front-end, to be more exact).
Node:
var XLSX = require('xlsx')
var ws_name = "connect";
var wb = XLSX.readFile("test.xlsm", {bookVBA:true});
var ws = XLSX.utils.aoa_to_sheet([["sessionId", "objectId"]]);
wb.SheetNames.push(ws_name);
wb.Sheets[ws_name] = ws;
XLSX.writeFile(wb, "newpage.xlsm", {bookType:"xlsm"});

So far for the browser side, i've added the

If you have a fixed template, you can expose it at some endpoint (e.g. /static/test.xlsm route would download the original template) and have your page download the file with XHR.  The following code block combines the "Browser download file (ajax)" example with the "Browser download file" example :
var url = "/static/test.xlsm"; // <-- change this to the route for your template
var oReq = new XMLHttpRequest();
oReq.open("GET", url, true);
oReq.responseType = "arraybuffer";

oReq.onload = function(e) {
  var arraybuffer = oReq.response;
  var data = new Uint8Array(arraybuffer);
  var arr = new Array();
  for(var i = 0; i != data.length; ++i) arr[i] = String.fromCharCode(data[i]);
  var bstr = arr.join("");

  var wb = XLSX.read(bstr, {type:"binary", bookVBA:true});

  /* at this point, `wb` is a workbook */
  var ws_name = "connect";
  var ws = XLSX.utils.aoa_to_sheet([["sessionId", "objectId"]]);
  wb.SheetNames.push(ws_name);
  wb.Sheets[ws_name] = ws;

  /* The following generates a download for "newpage.xlsm" using filesaver.js */
  var wopts = { bookType:'xlsm', type:'binary' };
  var wbout = XLSX.write(wb, wopts);
  saveAs(new Blob([s2ab(wbout)],{type:"application/octet-stream"}), "newpage.xlsm");
}

function s2ab(s) {
  var buf = new ArrayBuffer(s.length);
  var view = new Uint8Array(buf);
  for (var i=0; i!=s.length; ++i) view[i] = s.charCodeAt(i) & 0xFF;
  return buf;
}

oReq.send();

FYI use triple backticks for multi-line code blocks in github:
```js
var XLSX = require('xlsx')
```

That works perfectly! Thank you guys so much <3


H5179 quirks

Govee Device SKU
H5179
Govee2MQTT Version
2024.01.19-ffca9c12
Describe the issue
The H5179 wifi thermometer/hygrometer reports temperature (C) and humidity (%) scaled by 100
Startup Diagnostics
[2024-01-20T16:16:16 INFO  govee::commands::serve] Wifi Thermometer (78:80:18:1F:C7:94:69:51 H5179)
[2024-01-20T16:16:16 INFO  govee::commands::serve]   Platform API: devices.types.thermometer. supports_rgb=false supports_brightness=false
[2024-01-20T16:16:16 INFO  govee::commands::serve]                 color_temp=None segment_rgb=None
[2024-01-20T16:16:16 INFO  govee::commands::serve]   Undoc: room=Some("Home") supports_iot=false ble_only=true

Additional Logs
No response
Home Assistant Logs
No response
Anything else?
Tysm for your hard work on this impressive integration!

Please share the metadata for your device:

go to the device entry in for your device
Find the entity id of the Status entity that is listed under your space heater and get its entity name. The default is probably something like sensor.device_name_status.

Then evaluate the following home assistant template by visiting Developer Tools | Template, replacing the entity name with what yours actually is:
{{
    {
      "meta": state_attr('sensor.device_name_status', 'platform_metadata'),
      "state": state_attr('sensor.device_name_status', 'platform_state'),
    }
}}

It should output a large-ish json blob, please share that here.

{
  "meta": {
    "capabilities": [
      {
        "alarmType": null,
        "eventState": null,
        "instance": "sensorTemperature",
        "parameters": null,
        "type": "devices.capabilities.property"
      },
      {
        "alarmType": null,
        "eventState": null,
        "instance": "sensorHumidity",
        "parameters": null,
        "type": "devices.capabilities.property"
      }
    ],
    "device": "78:80:18:1F:69:51:CC:94",
    "deviceName": "Wifi Thermometer",
    "sku": "H5179",
    "type": "devices.types.thermometer"
  },
  "state": {
    "capabilities": [
      {
        "instance": "online",
        "state": {
          "value": true
        },
        "type": "devices.capabilities.online"
      },
      {
        "instance": "sensorTemperature",
        "state": {
          "value": 2150
        },
        "type": "devices.capabilities.property"
      },
      {
        "instance": "sensorHumidity",
        "state": {
          "value": {
            "currentHumidity": 3310
          }
        },
        "type": "devices.capabilities.property"
      }
    ],
    "device": "78:80:18:1F:69:51:CC:94",
    "sku": "H5179"
  }
}

Thanks; this should be taken care of in the latest version available now!

Looks great, thanks again!

I believe this change may have been incorrect. Quite a few people (including me) suddenly saw correct readings take a dip and reported it in https://github.com/wez/govee2mqtt/issues/149#issuecomment-2005550569.
I'm getting the following readings from my H5179 with 2024.01.24-ea3cd430:

sensorTemperature: 79.52 (in Fahrenheit, not scaled by 100)
sensorHumidity: 35 (in percent, not scaled by 100)

Full template output
{
  "meta": {
    "capabilities": [
      {
        "alarmType": null,
        "eventState": null,
        "instance": "sensorTemperature",
        "parameters": null,
        "type": "devices.capabilities.property"
      },
      {
        "alarmType": null,
        "eventState": null,
        "instance": "sensorHumidity",
        "parameters": null,
        "type": "devices.capabilities.property"
      }
    ],
    "device": "93:16:18:CE:B8:C0:C9:12",
    "deviceName": "Balcony",
    "sku": "H5179",
    "type": "devices.types.thermometer"
  },
  "state": {
    "capabilities": [
      {
        "instance": "online",
        "state": {
          "value": true
        },
        "type": "devices.capabilities.online"
      },
      {
        "instance": "sensorTemperature",
        "state": {
          "value": 79.52
        },
        "type": "devices.capabilities.property"
      },
      {
        "instance": "sensorHumidity",
        "state": {
          "value": {
            "currentHumidity": 35
          }
        },
        "type": "devices.capabilities.property"
      }
    ],
    "device": "93:16:18:CE:B8:C0:C9:12",
    "sku": "H5179"
  }
}

The addon is configured to use the Celsius (C) temperature scale, in case that is relevant.
Below is a screenshot showcasing the issue:

The temperature is NOT converted from Fahrenheit to Celsisus AND is incorrectly scaled down by factor 100.
For instance: 0.8 in the graph maps to 80 ℉, which is the exepected 26.6 ℃.
The humidity is scaled down by factor 100 and ranges between 0.00 and 1.00 instead of the correct 0 and 100.


Code Coverage Tools

Investigate and Implement code coverage.
Some links worth investigating:

https://coveralls.io/
https://github.com/integrations/codecov

Closing as duplicate of #173


Create grenoble-inp.txt

Email for Grenoble Institute of Technology

@Naheuldark Piull request merged. Thank you!


Inform user that older audit history are not available

Put something like "Older records are not available. For more information, please contact<EMAIL_ADDRESS>under the User History page.

Olga will look into what email address to include.

The team has decided not to display the message.


Always return size for messages with OneOf fields

Use a maximum calculation if submessage sizes are unknown.

Looks good, thanks!