Feature request: outline color for normal & grid mode

I use an e-ink grayscale monitor, and it's sometimes hard to visually see the Square or grid depending on the color of whatever is on the screen. For example, #FF000 often appears the same as black (the monitor's rendering algorithm is somewhat adaptive but not amazing).
It'd be nice to be able to specify an outline color and size that gets drawn as a border to the  Square or grid lines (similar to the white border on the Black OS X native cursor)

Can't you just set grid_color to something which stands out on your screen?

Setting cursor_color or grid_color alone won't do it because everything is mapped to grayscale and I can't control the underlying colors on web pages or in apps…

I see. I will add this to the todo list.

I've added this to the latest release.


Security Menu in wrong place.

Why is the Security Menu under the Design Menu in the dashboard?   Should be at the root of menu.    Makes no sense!

Please watch the meeting we had on 9/13/2016 where we talked about the menu organization. It made some sense for all the people at the meeting. At the same time we are not even in beta, so we can always reconsider it once the menu is more complete, along with all other items. We might find some discrepancies then.
Right now if you really care about it you can create a module that would override its location.

Here we go: https://www.youtube.com/watch?v=fOZGjZUcl00


watch reactive array callback called with array of undefined

Version
3.0.0-rc.2
Reproduction link
https://codesandbox.io/s/fervent-sun-87su3?file=/src/index.js
Steps to reproduce
watch a reactive array, the callback function is called with array of undefined
What is expected?
callback function is called with array of undefined
What is actually happening?
callback function is called with the reactive array value

as the warning suggests, you need to use a function: watch(() => array with reactive. You will also need { deep: true } to track changes inside of the array


spaces aren't written to TextSpan: text

https://github.com/pdf-rs/pdf_render/blob/29c268f0e1c8ed3217565a43431dc3fee79c1ee0/render/src/textstate.rs#L138-L143
I presume a span.text.push(' '); is missing here. Adding it fixes the lack of spaces for me, but I am not sure if its the correct way.

I can add it there and it will work for most files, but not for all. Some creators use kerning for spaces...


update to use chat-gpt

Hi! Thanks for this repo. We are using this as part of a project and wanted to check when you'll finalize and merge this. Very excited to use ChatGPT API with this bot! :)


Move to Github Actions

Hey all 👋
So after seeing the issue about moving to Github actions I thought I would drop in a PR. I have tried to keep this as "vague" as possible incase you want to push any of these upstream. I have matched the travis support back to PHP 5.4 for now.

Would it be better to have different jobs for testing and for CI? The benefits of that are that we'd see both code style and tests even if code style failed and we'd be able to see at a glance which parts failed.

While I'd usually agree, the point of this PR was to migrate like for like from travis over to GitHub Actions 🙂
It begs the question, should code quality and tests be separated. If this is the case I would look to move the code quality checks to it's own workflow file instead of a separate job.
I'm open to opinions on this, and will happily refactor to whatever the concensus is here.

@KorvinSzanto here we go! I have moved them to separate workflos now 😄

@matthewtrask all done now buddy!

:+1: Nice, I think the last steps for this to be a complete replacement would be to move the bit in .travisci that copies coverage up to scrutinizer into the tests and drop the .travisci file

@KorvinSzanto that would be super easy to do, and I did it in the beginning, but it kept 404-ing because it ran on my repo 😂
Will get that added in the morning for you

@KorvinSzanto here we go! It may fail to build on my local branch now but scrutinizer steps have been added, as has the updated github action readme badge - so when merged the status should swap.


Generate API key

Fixes #331

I'm still getting the precondition failed

Hmm. I only had my units installed 3 days ago (post-API change - disappointing) so I'm using a fresh install/login if that makes a difference - they're working correctly, I have no errors.
One part I'm not entirely clear on is the cfc injection. The header you posted in the issue is missing it, but every request I've generated from iOS has it present.

The android version has the cfc as well, could be some issue with something not getting encoded correctly maybe special chars in the token

I did a replay of using the method:
Expected: 02230b977cfc86179cac19e48bd387062ed43222ded416377c87e0806ced8385206
Got: 7940423d8cfc47d6907152d7c445b5df85efd8629495fe95d060e172e0f787f866b

Hmm, my Home Assistant container is running in UTC - does that change anything?

Yes, that's the issue converting the time to UTC before turning it into a timestamp fixes the issue

I moved the utc conversion, since the timestamp sent by the client is the local time

just to make it look like their requests

@hrrrsn great job!

It works, thank you! I'm not sure who I should buy the coffee for. :)

Absolutely fantastic work - thank you very much
I would like to buy more than one coffee - but I don't have a credit card
Do you have a Paypal account? I think this work should be supported and honored!

Would it not now be prudent to reduce the polling frequency or even just make that a toggle?

@codyc1515 there are already options to set the polling rate separate for data and energy and a button to request new data.

I would also really enjoy seeing a write up or any pointers on how you did this. I’d like to do the same for BYD.

@codyc1515 depending on how much of the code is located in a native lib, it might not be worth the effort. But you can always throw the lib at https://dogbolt.org/ and see what comes out.


Ecto.Adapters.Postgres.structure_load delegates to psql

Present in master.
This means that we need to ship the psql tool to where we build our database, which is less than ideal.
Current behavior
Ecto.Adapters.Postgres.structure_load delegates to psql
Expected behavior
Ecto.Adapters.Postgres.structure_load performs the work without reliance on the psql tool.

Hi @jjl ! We understand. This is not something we plan to work on ourselves but if somebody is willing to contribute an implementation that uses a regular connection we will be glad to review and merge it if appropriate. Thanks!

Were I to go ahead and contribute such a change, can you think of any reason why this hasn't been done until now which might affect my decision?

As far as I know it was always implemented like that: https://github.com/elixir-ecto/ecto/pull/901
Maybe there is something that prohibits it but we don't know what that is yet. :) So giving it a try would be welcome!

Cool, thanks. I'll discuss and see if I can justify this.

@josevalim, if we keep this issue open someone that wants to contribute with this project can see easier and enhance this behaviour.


Delete location history API

Ready for Review

@omab when you have a moment, can you please review?


test: Add more tests / fix removal of coverage dir

Paths on windows should be fixed now. In our results we always use posix-style.


How to change subtotal per rowid?

I need to change subtotal per rowid, any idea?

well yeah ..https://github.com/Crinsane/LaravelShoppingcart/issues/113


Whether the quickfix window can be closed automatically after the bookmark can be located

Whether the quickfix window can be closed automatically after the bookmark can be located

There is currently no support for this as this is not the default behavior of vim

There is currently no support for this as this is not the default behavior of vim

autocmd FileType qf nnoremap   :lclose
autocmd FileType qf nnoremap  ma :lclose
I tested the feasibility myself
or
FileType > bufname = Quickfix
But I don't know if my code will have other effects

Let me clarify what I meant. I didn't mean to say that it cannot be done; it certainly is possible as you've shown yourself. What I meant to say was that vim-signature does not do this as that is not how vim behaves by default.


Appstudio update test-component-pac-qvmy

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-qvmy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
32 seconds
clone-repository

✅ Succeeded
35 seconds
build-container

✅ Succeeded
31 seconds
inspect-image

✅ Succeeded
28 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
19 seconds
sbom-json-check

✅ Succeeded
8 seconds
label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
11 seconds
show-summary

Pipelines as Code CI/test-component-pac-qvmy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
31 seconds
build-container

✅ Succeeded
30 seconds
deprecated-base-image-check

✅ Succeeded
31 seconds
inspect-image

✅ Succeeded
45 seconds
clamav-scan

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
19 seconds
sbom-json-check

✅ Succeeded
16 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


Unable to import and make authorization

AttributeError: partially initialized module 'deepl' has no attribute 'Translator' (most likely due to a circular import)
AuthorizationError:

Hi @unnidiametos, there might be a simple fix: in case your file is named "deepl.py", try renaming it, for example: "my_deepl_script.py".
If that doesn't fix it, can you please provide an example that reproduces the error, and say which Python version you are using?

It is still producing the same error after renaming. I am using python 3.9.0

Okay, then can you please share a minimal example file that produces your problem? Please make sure that your auth-key is not included.

import deepl
auth_key = {
'host' : "https://api.deepl.com/v2/translate?",
'auth_key': "xxxxxxxxxxxxxxxxxxxxxxxxxxx"}
text = "Wie geht es dir?"
target_language = "EN-US"
translator = deepl.Translator(auth_key['auth_key'])
result = translator.translate_text(text, target_lang=target_language)
translated_text = result.text
print(translated_text)

Thank you for sharing the example. I don't see anything wrong with your example, and it works fine for me.
Maybe you have another file in the same directory named "deepl.py", or a directory named "deepl"? This would cause the import error you are seeing.

Thanks for the comment. I recognized that the folder name was 'deepl'. When I changed it the import is working.
But when I got to
result = translator.translate_text(text, target_lang=target_language)
I am getting error as:
Traceback (most recent call last):
File "C:\Users\unnik\OneDrive\Desktop\my_deepl\my_deepl_script.py", line 10, in
result = translator.translate_text(text, target_lang=target_language)
File "C:\Users\unnik\AppData\Local\Programs\Python\Python39\lib\site-packages\deepl\translator.py", line 504, in translate_text
request_data = self._check_language_and_formality(
File "C:\Users\unnik\AppData\Local\Programs\Python\Python39\lib\site-packages\deepl\translator.py", line 428, in _check_language_and_formality
self._check_valid_languages(source_lang, target_lang)
File "C:\Users\unnik\AppData\Local\Programs\Python\Python39\lib\site-packages\deepl\translator.py", line 411, in _check_valid_languages
target_lang == lang.code for lang in self.get_target_languages()
File "C:\Users\unnik\AppData\Local\Programs\Python\Python39\lib\site-packages\deepl\translator.py", line 745, in get_target_languages
self._target_languages_cached = self._request_languages(
File "C:\Users\unnik\AppData\Local\Programs\Python\Python39\lib\site-packages\deepl\translator.py", line 375, in _request_languages
self._raise_for_status(status, content, json)
File "C:\Users\unnik\AppData\Local\Programs\Python\Python39\lib\site-packages\deepl\translator.py", line 345, in _raise_for_status
raise AuthorizationException(
deepl.exceptions.AuthorizationException: Authorization failure, check auth_key
Could you please help me with this also

Great.
To solve this new problem, you could check that your authentication key is exactly as it appears on your DeepL Pro Account page - check you don't have leading or trailing spaces, for example.
If you still have problems with the authorization, you could submit a support request, so that we can check your authentication key.

Sorry to bump into the conversation, but I got the same error (I'm sure the key was copied correctly).
I opened a ticket as @daniel-jones-deepl suggests, but since I'm having this issue as well, maybe there is an underlying bug here.
Hope this info is useful for you

Hi @LivingDeadCloud, no problem, thank you for commenting about your problem.

Is there any reason why this problem might occur?
I am working with DeepL in the Pythonanywhere cloud and have installed the package correctly.
However when I run my script  I only get the error
"/home/alexjeser/.virtualenvs/gpt3x/gcm_reviews_gpt3y.py", line 23, in <module>     translator = deepl.Translator(auth_key) AttributeError: module 'deepl' has no attribute 'Translator'
Any advice?

Hi @blacchollywood, to eliminate the possibility of importing the wrong module, you could try inspecting deepl.__file__; it should be a file deepl/__init__.py, beginning with the line # Copyright 2022 DeepL SE (https://www.deepl.com).
If this is all as expected, then there could be an issue with the library in PythonAnywhere.


Add support for GitHub tokens

Describe the feature
Add support for:
with:
  token: ${{ secrets.GITHUB_TOKEN }}

Version

[X] I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
The action does not support passing a valid GitHub token into the action.
Describe alternatives
None. It would require using a different action, or writing one from scratch.
Additional context
We have GitHub Enterprise Server, and use self-hosted GitHub Actions runners. We regularly hit the GitHub API rate limits when using this action.
Are you willing to submit a PR?
I don't know JavaScript, so I cannot.

@skyzyx
Try setting the GITHUB_TOKEN env in the setup-php step.
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '8.3'
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

It is documented here
https://github.com/shivammathur/setup-php?tab=readme-ov-file#wrench-tools-support
https://github.com/shivammathur/setup-php?tab=readme-ov-file#github-composer-authentication


larger batchsize, bad results?

when I train my own dataset using retinanet with batchsize-16, the map gets about 85%,
and I only enlarge the batchsize to 36, the map is 0
why does this happens, I train both using 2 gpus, I can confirm that I only change batchsize.

https://github.com/open-mmlab/mmdetection/blob/13880ae5fdfa2521060e377b0908148cc291eac0/docs/1_exist_data_model.md#train-predefined-models-on-standard-datasets

@BIGWangYuDong sorry，I didn't find any references or any solutions

You need to also increase the learning rate linearly to match the bigger batch size.

you can try to use auto-lr during training. feel free to re-open this issue if you still meet this problem


[CLI]: jax.Array not serializable and not working with wandb.log

Describe the bug

Jax has recently introduce a new Array type, but wandb.log no longer works with this array.
This problem will go away after setting jax.config.update('jax_array', False) but this setting is only guaranteed to exist until 15/3/2023.
Some background info:
https://jax.readthedocs.io/en/latest/jax_array_migration.html#jax-array-migration

import jax.numpy as jnp
import wandb
wandb.init()
wandb.log({'test': jnp.array([3])})

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/sdk/wandb_run.py", line 292, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/sdk/wandb_run.py", line 255, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/sdk/wandb_run.py", line 1612, in log
    self._log(data=data, step=step, commit=commit)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/sdk/wandb_run.py", line 1394, in _log
    self._partial_history_callback(data, step, commit)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/sdk/wandb_run.py", line 1278, in _partial_history_callback
    self._backend.interface.publish_partial_history(
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/sdk/interface/interface.py", line 556, in publish_partial_history
    item.value_json = json_dumps_safer_history(v)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/util.py", line 920, in json_dumps_safer_history
    return json.dumps(obj, cls=WandBHistoryJSONEncoder, **kwargs)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/json/__init__.py", line 234, in dumps
    return cls(
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/site-packages/wandb/util.py", line 887, in default
    return json.JSONEncoder.default(self, obj)
  File "/Users/kenyonn/miniconda3/envs/jax4/lib/python3.9/json/encoder.py", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type Array is not JSON serializable

Additional Files
No response
Environment
WandB version: 0.13.7
OS: MacOS 12.6.1
Python version: 3.9.13
Versions of relevant libraries: jax 0.4.1
Additional Context
No response

+1, seeing this issue too.

Hi @weiyaw,
Thanks for pointing this out. I'll make an internal ticket to track this request. Since Array is a new datatype within JAX, it was not supported out of the box.
One of the members from our team will reach out once this is resolved.
Thanks,
Ramit

Hey folks, the fix for this (https://github.com/wandb/wandb/pull/4718) is in main and will be released this week, but in the meantime, would you mind checking that things work for you if installing from main?

Thanks @dmitryduev. It's working on my machine.

closing since this is fixed with release 0.13.8 if someone experience another issues, please feel free to re-open.


[FEATURE] relax typer constraints

Is your feature request related to a problem? Please describe.
Currently, Argilla 1 depends on typer <0.10 but currently typer is at 0.13 so it might be worth relaxing these constraitns.
Describe the solution you'd like
relax the contraints
Describe alternatives you've considered
N.A.
Additional context
N.A.

Yes, it did, however, given that we do intend to dedicate to support fixes, I am not sure if we don't want to support things like this at all or just only want to do explicit bug fixes.
I don't know what is common practice for relaxing version constraints after deprecation but it doesn't sound very weird to do this for a certain period.

Partially resolved through this PR https://github.com/argilla-io/argilla/pull/5164


chore: Removed underscores and boxing of perk functions

I don't have permission to add this to any project boards or assign any reviewers so ima just @BarmonHammer :3


Update output parsing to work with SLiM v4

Not sure why the tree sequence SVG output isn't rendering on github (it looks fine when I open the notebook locally), but everything else runs as expected.
It seems that calcHeterozygosity is summing over multiple mutations in the single-site-genome examples at the top of the notebook. To make heterozygosity match the drift-decay expectation in the figure, I set mutation rate to 0 in this example so that we're only tracking a single introduced mutation.

awesome @nspope. thx

Probably want to revisit this at some point -- I think the first column could also be 'tick' depending on the model / what is being tracked. Maybe a better option would be to use arbitrary column names/avoid setting an index?


Restoring settings

Hello,
Thanks guys for such a lovely extension, I really appreciate the work you have done
Can you please tell me, whether settings of tabs are restored, when I sign in chrome on another computer?
Cheers

Hi @tikolakin,
Thanks for your feedback!
Do you mean " tab rules" by "settings of tabs"?
Your rules are saved locally, it means even if you sign-in from another computer you will get a fresh install of Tab Modifier. That's why you are able to export/import rules from the Settings view.
Ref. https://github.com/sylouuu/chrome-tab-modifier/issues/27
Best

Perfect, I didn't know about this feature (tbh, I didn't explore all the features)
It works like a charm, thanks.
Cheers


When the flows checking more than 150, it always has this error

[Write any error info to resolve easier]

System.AggregateException:
One or more errors occurred.
mscorlib
- System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
- Fic.XTB.FlowExecutionHistory.Models.FlowRun.GetTriggerOutputs()
- Fic.XTB.FlowExecutionHistory.Services.FlowClient.GetTriggerOutputsForFlowRun(FlowRun flowRun)
- Fic.XTB.FlowExecutionHistory.Services.FlowClient.<>c__DisplayClass17_0.<GetFlowRunsFromApi>b__0(FlowRun fr)
- System.Threading.Tasks.Parallel.<>c__DisplayClass17_0`1.<ForWorker>b__1()
- System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
- System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object <p0>)

XrmToolBox Version: 1.2023.12.68
FlowExecutionHistory Version: 1.2024.4.6
DB Version: 9.2.24041.186
Deployment: Online

Are you trying to fetch 150 flow runs or flow runs for 150 flows?

Dear Ivan,
Thank you for your following up and I think the problem has been resolved after I updated the plugin 2 days ago.
Attached my normal checking on our system which contain over 250 flows running.  Without your tool, I have no way to trace what’s happening at the system.
Regards,
mo
From: Ivan Ficko @.>
Date: Thursday, 25 April 2024 at 10:59
To: DynamicsNinja/FlowExecutionHistory @.>
Cc: Koon Hung Luk @.>, Author @.>
Subject: Re: [DynamicsNinja/FlowExecutionHistory] When the flows checking more than 150, it always has this error (Issue #28)
⚠ External sender. Take care when opening links or attachments. Do not provide your login details.
Are you trying to fetch 150 flow runs or flow runs for 150 flows?
—
Reply to this email directly, view it on GitHubhttps://github.com/DynamicsNinja/FlowExecutionHistory/issues/28#issuecomment-2076813155, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A535A6FMWIVOG3DHWHEOKT3Y7DHW3AVCNFSM6AAAAABGWUOZVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZWHAYTGMJVGU.
You are receiving this because you authored the thread.Message ID: @.***>


Block timestamp bugfix

Usage related changes

Development related changes

Checklist:

[x] Applied formatting - ./scripts/format.sh
[x] No linter errors - ./scripts/clippy_check.sh
[ ] Performed code self-review
[ ] Rebased to the last commit of the target branch (or merged it into my branch)
[ ] Documented the changes
[ ] Linked the issues which this PR resolves
[ ] Checked the TODO section in README.md if this PR resolves it
[ ] Updated the tests
[ ] All tests are passing - cargo test

related to https://github.com/starkware-libs/blockifier/issues/1145


Crash when opening a book

Describe the bug
We recently released a new version that included bug fixes for iOS 18. However, after the update, we noticed a significant drop in crash-free users—over 10%. In an attempt to resolve the issue, we downgraded the Readium version to 2.6.0, which previously did not cause any crashes. Unfortunately, this did not resolve the problem. Finally, we tried building the project with Xcode 15.4 instead of Xcode 16.0, and the crash issue was eliminated.
How to reproduce?

Open a book

Readium version
2.6.0 ... 2.7.3
OS version
Mainly iOS 17 and 18
Testing device
Any Device
Environment
macOS: 15.0
platform: x86_64
carthage: 0.40.0
Xcode 16.0
Build version 16A242d

Additional context
Crashed: com.apple.root.default-qos
0  libsystem_platform.dylib       0x2a54 platform_memmove + 52
1  libxml2.2.dylib                0x18638  + 216
2  libxml2.2.dylib                0x6a58 xmlParserInputBufferCreateMem + 92
3  libxml2.2.dylib                0x67d4 xmlCreateMemoryParserCtxt + 72
4  libxml2.2.dylib                0x6610 xmlReadMemory + 60
5                        0x101c55c XMLDocument.__allocating_init(string:encoding:) + 130 (Document.swift:130)
6                        0x1171cb4 FuziXMLDocument.init(string:namespaces:) + 14 (Fuzi.swift:14)
7                        0x1161dc8 MediaTypeSnifferContext.contentAsXML.getter + 74 (MediaTypeSnifferContext.swift:74)
8                        0x115d170 specialized static MediaType.sniffHTML(context:) + 115 (MediaTypeSniffer.swift:115)
9                        0x115b028 implicit closure #1 in variable initialization expression of static MediaType.sniffers + 32
10                       0x115c704 specialized static MediaType.of(content:mediaTypes:fileExtensions:sniffers:) + 804 (Archive.swift:804)
11                       0x115ca88 specialized static MediaType.of(:mediaTypes:fileExtensions:sniffers:) + 280 (MediaTypeSnifferContent.swift:280)
12                       0x115a6e8 static MediaType.of(:mediaTypes:fileExtensions:sniffers:) + 28 (:28)
13                       0x11c1a84 PublicationServer.resourceHandler(:) + 341 (PublicationServer.swift:341)
14                       0xd81ddc thunk for @escaping @callee_guaranteed (@guaranteed GCDWebServerRequest) -> (@owned GCDWebServerResponse?) + 48 (:48)
15                       0x122b680 __82-[GCDWebServer(Handlers) addHandlerForMethod:pathRegex:requestClass:processBlock:]_block_invoke + 923 (GCDWebServer.m:923)
16                       0x122f704 -[GCDWebServerConnection(Subclassing) processRequest:completion:] + 762 (GCDWebServerConnection.m:762)
17                       0x122cb94 -[GCDWebServerConnection _startProcessingRequest] + 152 (GCDWebServerConnection.m:152)
18                       0x122d960 __45-[GCDWebServerConnection _readRequestHeaders]_block_invoke + 346 (GCDWebServerConnection.m:346)
19                       0x122e2c8 __64-[GCDWebServerConnection(Read) readHeaders:withCompletionBlock:]_block_invoke + 461 (GCDWebServerConnection.m:461)
20                       0x122e044 __68-[GCDWebServerConnection(Read) readData:withLength:completionBlock:]_block_invoke + 432 (GCDWebServerConnection.m:432)
21 libdispatch.dylib              0x31234  + 60
22 libdispatch.dylib              0x213c  + 32
23 libdispatch.dylib              0x3dd4  + 20
24 libdispatch.dylib              0x15a6c  + 864
25 libdispatch.dylib              0x1609c  + 156
26 libsystem_pthread.dylib        0x48f8 _pthread_wqthread + 228
27 libsystem_pthread.dylib        0x10cc start_wqthread + 8

Here you can find the crash reports

We are experiencing the same issue. When building with Xcode 16, some users experience the same crash. Unfortunately(?), the crash is not consistant, for some users it never crashes. I have yet to have any workaround.

I have new information about this "bug" It seems that the application only crashes in Relaese mode, so when downloaded from TestFlight. Building through xcode doesn't cause the code to crash. Any idea? I tried several combos, I tried using xcode 15.4, xcode 16, I tried using my iPhone 15 Plus and another iPhone x and even an iPhone 7. Maybe the problem is around the optimization level or something? I would be glad to hear any tip.

Okay, I found the issue. For my defense, I got this project from others and it is an old one :) It looks like the library was updated from 2.2.0 to 2.6.0 at some point without doing the 2.5.0 migratin guide. Although it worked at that time, it looks like now this is causing this crash. I changed the implementation to use the GCDHTTPServer.shared as shown in the guide and the crash seems to go away.

@grighakobian Was it the same issue as described by @tnorbert above for you?

@mickael-menu We haven't migrated to 2.5.0 yet; we're currently using version 2.7.3. Everything works fine when building on Xcode 15.4, but we're encountering crashes when building on Xcode 16.

@grighakobian Could you share your code creating an instance of EPUBNavigatorViewController? (Just all the parameters you pass to the constructor).

@grighakobian @mickael-menu So, basically, my steps were to update the library to 2.7.3 and resolve every deprecated message. This includes using a new initializer in  EPUBNavigatorViewController (and switching to GCDHTTPServer.shared) and reimplementing the user preferences (saving the preferences by our own logic and applying these values directly to the reader). After these steps, all our crashed went away. Although, these changes made us rework some of our epubs as the new reader did not apply several user preferences such as font sizes. It turned out that some epubs needed to be changed.

@grighakobian Could you share your code creating an instance of EPUBNavigatorViewController? (Just all the parameters you pass to the constructor).

@mickael-menu Here is the EPUBNavigatorViewController initialization code.
let navigatorViewController = EPUBNavigatorViewController(publication: publication, initialLocation: initialLocation, resourcesServer: publicationServer)

Note that we are using the old PublicationServer API.

Okay that's probably why this is crashing on Xcode 16. Let me know if you still have the issue after migrating the HTTP server.

@mickael-menu Unfortunately, I started getting these crashes, too. At first, I though I solved this but it looks like I was wrong. Right now, I am getting the exact same crashes as @grighakobian. Any idea on that? The user's download it from TestFlight and when the device is fully offline (airplane mode and wifi off), the app crashes when trying to open an epub.

No but it's actually crashing in one of our third-party dependencies. Maybe you can take a look on Fuzi's repository to see if something similar was mentioned, and/or open an issue there: https://github.com/cezheng/Fuzi
Please let me know if you do so I can track the answers.

The project looks pretty dead actually. Maybe it's time to look for another XML parser.
If someone wants to contribute a solution with an alternative XML parser, you need to implement the following protocol: https://github.com/readium/swift-toolkit/blob/develop/Sources/Shared/Toolkit/XML/XML.swift
Here's an example using Fuzi: https://github.com/readium/swift-toolkit/blob/develop/Sources/Shared/Toolkit/XML/Fuzi.swift
And there are tests here, you just need to copy and adjust the FuziTests class: https://github.com/readium/swift-toolkit/blob/f53630f81f75c6201c35f40082021f2e4ed42f08/Tests/SharedTests/Toolkit/XML/XMLTests.swift#L94-L107

@mickael-menu  It looks like somebody opened a new issue here and it is the same fuzi crash as we are experiencing.
https://github.com/readium/swift-toolkit/issues/495
I think this is going to be a bigger issue now, I don't think that there is an easy solution but I am going to try to solve it somehow, without switching the parser (we kinda need it to be fixed asap as we are using this is production :) )

What's your plan to fix it? I guess we can't without fixing the issue in Fuzi. Forking it in Readium is a possibility if you find the solution by modifying Fuzy directly.

@mickael-menu I wrote a temporary solution in the other ticket but it is only a band aid for production crashes. @grighakobian What was your situation? Did you manage to solve this?

to fix your trouble check this solution click
maybe this will solve your problem.

@tnorbert We fixed the crash by compiling the project on Xcode 15.4.

Hello everyone, Xcode 16.1 crash still happening

@grighakobian @tnorbert @mickael-menu @HadrienGardeur
I reproduced the crash on the old device (se 1 gen), Xcode 16.1, release scheme.
I tried to fix it here https://github.com/MelDev1/Fuzi
The problem was in the unsafe creation of UnsafeBufferPointer.
  public convenience init(cChars: [CChar]) throws {
    let buffer = cChars.withUnsafeBufferPointer { buffer in
        UnsafeBufferPointer(rebasing: buffer[0..<buffer.count])
    }
    try self.init(buffer: buffer)
  }

The documentation prohibits doing this.
Here is the quick solution:
  public convenience init(cChars: [CChar]) throws {
      let mutablebuffer = UnsafeMutableBufferPointer<CChar>.allocate(capacity: cChars.count)
      _ = mutablebuffer.initialize(from: cChars)

      defer {
          mutablebuffer.deallocate()
      }

      let buffer = UnsafeBufferPointer(mutablebuffer)
      try self.init(buffer: buffer)
  }

I released the application and for the second day there have been no crashes.
Please check my fix for yourself.

@MelDev1 That's great thank you! I added a comment on your PR to Fuzi to add some weight, if we have no answers from the maintainers I think I will open a fork on the readium organization to release your fix.

@MelDev1 Still no crash reports after your fix? I think it's time to consider doing a fork.

@mickael-menu yep, no crashes

Could some of you try the branch fix-fuzi based off 2.7.3 and report whether the problem is fixed for you? Thank you!
cc @MelDev1 @grighakobian @tnorbert

Not yet on 2.7.3 but changed just the Fuzi dependency to that fork and fix-tag.
Playing around for about 30 minutes on two device < iOS 18 in release mode. Same scenario that was crashing constantly and pretty reliable before.
So far works like a charm.
❤👍👏


Fix branch name for bitbucket server.

When I create feature/some-event as branch name. The convertPushHook func get wrong branch name as feature.
cc @josmo
Signed-off-by: Bo-Yi Wu<EMAIL_ADDRESS>

I would suggest to use SplitN

my primary concern with the way split is being used is that it is prone to a panic due to an index out of bounds error:
 strings.Join(refParts[2:], "/")

so perhaps instead doing something like this makes more sense:
strings.StripPrefix(
    hook.RefChanges[0].RefID,
    "refs/heads/",
)

@tboerger @bradrydzewski
I change Split to SplitN function. Does it ok?
Three condition:

refs/heads/
refs/heads/feature/branch
refs/tags/v1

Output:

""
"feature/branch"
"v1"

https://golang.org/pkg/strings/#TrimPrefix :)

@tboerger @bradrydzewski
Two condition:

refs/heads/feature/branch
refs/tags/v1

Two solution:
strings.StripPrefix(
    hook.RefChanges[0].RefID,
    fmt.Printf("refs/%s/", refParts[1]),
)

Another
var branch string
if len(refParts) > 2 {
    branch = refParts[2]
}

Let me know your thoughts.

Maybe you should consider something like this since the strings funcs are really fast:
 func convertPushHook(hook *internal.PostHook, baseURL string) *model.Build {
-	var branch string
-	//get the ref parts to see if it's a tags or heads
-	refParts := strings.SplitN(hook.RefChanges[0].RefID, "/", 3)
-	if len(refParts) > 2 {
-		branch = refParts[2]
-	}
-	commitType := refParts[1]
+	branch := strings.TrimPrefix(
+		strings.TrimPrefix(
+			hook.RefChanges[0].RefID,
+			"refs/heads/",
+		),
+		"refs/tags/",
+	)

 	//Ensuring the author label is not longer then 40 for the label of the commit author (default size in the db)
 	authorLabel := hook.Changesets.Values[0].ToCommit.Author.Name
@@ -24,10 +24,10 @@
 		Ref:       hook.RefChanges[0].RefID, // TODO check for index Values
 		Link:      fmt.Sprintf("%s/projects/%s/repos/%s/commits/%s", baseURL, hook.Repository.Project.Key, hook.Repository.Slug, hook.RefChanges[0].ToHash),
 	}
-	switch commitType {
-	case "tags":
+
+	if string.HasPrefix(hook.RefChanges[0].RefID, "refs/tags/") {
 		build.Event = model.EventTag
-	default:
+	} else {
 		build.Event = model.EventPush
 	}

@tboerger I got your point. I will update this PR.

@tboerger @bradrydzewski
Done. Please help to review again.

LGTM

LGTM  thanks a bunch for catching and fixing it @appleboy


Hint for Wiki : add info for autogenerated .h regarding the icons

Hi, again I want to thank you for your work.
Just a hint:
In the Wiki:
https://github.com/jamisonderek/flipper-zero-tutorials/wiki/User-Interface#draw-icon
Would you mind to add a little explanation about the need to include the "auto-generated" file .h by ./fbt for the Icon identifiers?
Probably I missed it...

Thanks for the feedback.  I'll try to add it soon.

Sorry it took so long to update.  Thanks again for the feedback.


Add task metadata & github CI

Hey @adrtsc
For when you're back from your holidays: We're adding metadata to the tasks to be able to build better task interfaces. I've created this PR to show how this metadata is structured. The core fields for each task are:

Category: Conversion, Segmentation, Registration, Measurement, Image Processing
Modality: HCS, lightsheet, EM
Tags: Arbitrary strings that are searchable and provide info about the task

Category & Modality work by convention, but you can add new entries when useful.
Additionally, there is now an "authors" field for the whole package.
In order for the future public Fractal page to list your tasks (see https://github.com/fractal-analytics-platform/fractal-analytics-platform.github.io/issues/6), the package needs to either be on PyPI or have github releases with whl files. As part of this PR, I'm adding a Github CI that would run tests and create releases with whl files upon tags. Let me know if that works for you.
Additionally, the CI includes an easy option to activate publishing to PyPI (which would be great for your package!). Feel free to turn it on by removing the if false option on the PyPI publishing in build_and_test.yml and following the setup steps here: https://github.com/fractal-analytics-platform/fractal-tasks-template/blob/main/DEVELOPERS_GUIDE.md
=> Pypi instructions: https://docs.pypi.org/trusted-publishers

What remains to be done:

Check whether my suggestions in the image list make sense
Add additional metadata, e.g. more tags
It would be great to mark the tasks as HCS specific which assume that there is a plate. I suspect many of the compound tasks will qualify for that. Any task that works for HCS, but also works for an arbitrary list of zarr_urls doesn't need that modality tag.
Decide whether the Github CI & whl releases is something you want
Decide whether you want to publish the package on PyPI

Hi Joel,


Backend assertion failure (possibly from wrong mouse event handling)

from imgui.cpp:1390 (on "docking" branch. For mainline it's on :1354),
IM_ASSERT(!ImGui::IsAliasKey(key)); // Backend cannot submit ImGuiKey_MouseXXX values they are automatically inferred from AddMouseXXX() events.

Target game is DJMAX RESPECT V, which doesn't use any mouse input.
I couldn't find the exact condition to reproduce the crash. still testing.

https://github.com/veeenu/hudhook/commit/f058304463a28e0bd328dc35c85fabaeb0559bee
Try this

What hudhook version are you on? And how are you using the docking branch? This issue occurred before but it has now been fixed and a new release with the fix is on crates.io.

Oh It was v0.6.1...
I started my project about a month ago with that version,
and thought I'm still using newest release because of github's stupid "3 weeks ago".
Sorry for wasting your time.

All inputs on our end are correctly passed through add_mouse_event. I do not know where that assertion could be triggered. Are you by chance doing ui.io_mut()[something] = ... in your code? That is discouraged and will trigger the assertion above.

As far as I know imgui::Ui doesn't have io_mut() method so it's certainly not happening.
For imgui::Context::io_mut() which can be accessed on before_render(),
there's some logic to update Io.delta_time and Io.mouse_draw_cursor.

Right about ui.io_mut, it's not a thing.
 Please try to identify if any changes on your end result in this behavior going away so we can pinpoint the problem.

Removed everything except hooking part but crash still happens.
use hudhook::{hooks::dx11::ImguiDx11Hooks, ImguiRenderLoop};

struct BlankContext;

impl ImguiRenderLoop for BlankContext {
    fn render(&mut self, _ui: &mut imgui::Ui) {}
}

hudhook::hudhook!(ImguiDx11Hooks, BlankContext);

You mentioned the docking branch in your first message. How are you accessing that? Are you compiling against a different underlying version of imgui?
I reviewed our code but I couldn't find code paths that can ever hit that assertion, and also I do not have access to that game to test it myself. I need more information, a lot of it, if we hope to find out anything about this at all.
I encourage you to clone the repo locally and introduce log statements nearby the input related code, or at least implement the on_window_proc method and log what messages are received by the game window, and report your findings. Thank you!

After the first close of this issue I opt out for imgui docking because it seems unnecessary to me.
I accessed it via docking feature of imgui crate by the way.
I didn't test anything about the feature, so I've no idea it would work well with hudhook or not.
I will add log and collect info about why did it happen.
Slow progression expected since I'm not familiar with rust. (was C# main)

There's no rush! Take your time. This is open source, it's all based on volunteering whatever time one wants or can. :grin:

I thought current release v0.6.5 includes commit f058304 (fix for #172).
Found out it doesn't, while checking for #176 breaking change on latest source.
I recompiled and checked over ten times with denial.
With hudhook = { git = "https://github.com/veeenu/hudhook.git", rev = "f058304463a28e0bd328dc35c85fabaeb0559bee" }, problem is gone.
So ultimately I was trying to re-solve already fixed problem for two weeks. 🤦♂
Thank you for your help.

Huh! I thought it did, actually. My bad. Planning to release 0.7 at some point soonish so that fix can get in. Thank you for reporting this.


Full working sample

I dug a bit and can't get it to work.
Is there a working sample for Meteor?

Wasn't responding to touch events and Slideout.enableTouch undefined. Simplest solution was to manually bundle slideout.min.js in client/lib (to ensure Slideout is defined).

Hey @daveeel @damonmcminn,
It looks like the Slideout.js team have stopped tagging new releases on Github. This is problematic as it becomes difficult to track which version of their plugin is bundled in the smart package. I will continue to release new versions of this smart package, following the scheme: SLIDEOUT-GITHUB-TAG_RELEASE-NUMBER-UNDER-THAT-TAG.
The recently published 0.1.9_2 includes the latest code from the Slideout.js repo, so it should be exactly the same as bundling it yourself.
I've also published an example here: https://github.com/chriswessels/meteor-slideout/tree/master/example
Hope this helps!
Chris

Thanks for the reply @chriswessels , though a bit late ;)
My colleague once told me it's the local / global variable issue, but I didn't look deeper since we've switched to Meteor + Polymer 1.0, which has a nice responsive drawer plus many goodies.

Cheers Chris, especially for the example. Ta!


Output parameters that are ivi-dance-with-a-twist may be left too big after second call

This is similar to the race condition we found in #247, but sort of the opposite. If the first time we call a function and ask for the parameter's size, resize the parameter, then on the second call the size of the parameter is now smaller, we don't correctly resize the output buffer to the correct size.
We do 0-init these output buffers so there won't be garbage data in them, at least.
@harsha-bhushan - this should be a pretty straightforward fix, do you want it in the next release?

If we can get it in, it would be great. But I would not prioritize this bug over the getting DAQmx release published.


Suuport for YOLO v11

Hello Team,
Huge fan of your work. When can we expect support for YOLO v11? As far as I see, release 0.30.0 supports YOLO v5 and v8.
Would it be part of release 0.31.0 ?
P.S : Wasn’t sure how to ask this question hence creating an issue. Please close this when you have answered 🙏🏾
And apologies for any inconvenience caused

First of you, you can use YoloV8 Translator for yolo11 models. You can train or download Yolo11 models and use existing Translators. And in general, our mode zoo doesn't have all models. For example, we usually only import yolo8n models, You still need to download larger models like yolo8s, yolo8m by yourself.
We will take a look and import yolo11n models to model zoo.

https://github.com/deepjavalibrary/djl/pull/3516


[FABC-904] Add Version Endpoint

Add a version endpoint to the operations server which returns the current version of the CA
Signed-off-by: Brett Logan<EMAIL_ADDRESS>

@btl5037  have a look at my comment

@btl5037 have a look at my comment

I did, HandleFunc takes an anonymous function, which is what I was using because I failed to realize my VersionInfoHandler implemented the http.Handle interface. In Fabric we don't use the HandleFunc handler, we use the Handle handler, which is what I switched to so Fabric and CA use the same methodology. Handle takes an object that implemets the ServeHTTP function on the Handler interface.
In my opinion, it's much cleaner to just throw out the entire VersionInfoHandler and just call HandleFunc and io.Write directly, but I didn't want to break from the pattern we use in Fabric. If you are OK with using HandleFunc I'll go back and remove the VersionInfoHandler's implementation of the Handle interface and just use the much simpler HandleFunc

I decided to go back and use HandleFunc as its a much simpler implementation and has no error path

I decided to go back and use HandleFunc as its a much simpler implementation and has no error path

Good thinking.  Cleaner and simpler given the task at hand


New tag management

The new tag management allows you to set a minimum role per tag.
When editing issues, then depending on the users role he can now only set tthe tags he has access to. The ones he is forbidden to handle are not visible.
If an issue has a tag set for which the user has currently no right to access, then this tag is only tag of its type, that he can see.
In the kanban view columns for which the user has no access rights are not visible at all.
That way as a manager you can now very easily take tickets out of the normal queue, do something to it without intervention of a developer like 'discussing something with a customer' and then push it back in afterwards.
Please try setting the limit role of tickets to manager, and login with a developer.
Set the issue status to the referring statuses and watch what the developer sees and what not.
We've already began to use it and it works perfectly here.
So I really hope you like this feature.
Cheers

I will look into this in the weekend if I had sometime. One thing can you make sure your code is adhere the PSR-2 standards. It will make reviewing & merging the code a lot easier.

Ok. Will do that. Feel free to report any mistakes and I'll try to improve.


[Analyzers][CPP] Turn on warning 26492

Turn on warning 26492
Don't use const_cast to cast away const.

PR Checklist

[x] Continues towards: #940
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
Turn on warning 26492 -  Don't use const_cast to cast away const.
There is winrt warnings that were suppressed.
Some CreateProcessW calls passing a char array as string.c_str()
And a QueryAccept method that receives a const type and uses it to reset a smart pointer. But the method signature can not be changed because of inheritance.

Validation Steps Performed
CI

This will conflict with #23119 once it is merged.
I will wait for #23119 to merge and fix the conflicts.


Adds Program Outputs to Irida Next JSON Output File

I added both TSV and XLSX, because it's a pain trying to use XLSX when you don't have Excel or something that opens those files.
Output:
{
    "files": {
        "global": [
            {
                "path": "process/results.xlsx"
            },
            {
                "path": "process/results.tsv"
            },
            {
                "path": "distances/profile_dists.run.json"
            },
            {
                "path": "distances/profile_dists.results.text"
            },
            {
                "path": "distances/profile_dists.ref_profile.text"
            },
            {
                "path": "distances/profile_dists.query_profile.text"
            },
            {
                "path": "distances/profile_dists.allele_map.json"
            },
            {
                "path": "merged/locidex.merge.profile.tsv"
            }
        ],
        "samples": {

        }
    },
    "metadata": {
        "samples": {

        }
    }
}

Could I make one small request since you're already modifying the JSON config file. Could you change/add in an extra distance to:
results/distances/profile_dists.query_profile.text
results/distances/profile_dists.ref_profile.text

That'll accommodate the new distance outputs.


Missing data in CurrentVolatilStockResponse._missing_products

Hi!
First of all many thanks for pygrocy, I have been using it for a while and it helped me a lot!
I think I got a parse error when I try to get the missing products using grocy.missing_products()
If I check the JSON I See:
"missing_products": [
        {
            "id": "7",
            "name": "XXXX",
            "amount_missing": "1",
            "is_partly_in_stock": "1"
        },
        {
            "id": "8",
            "name": "YYYY",
            "amount_missing": "1",
            "is_partly_in_stock": "1"
        },
        {
            "id": "75",
            "name": "ZZZZ",
            "amount_missing": "1",
            "is_partly_in_stock": "1"
        }
    ]

But diving in CurrentStockResponse is expecting antother property names:
self._product_id = parse_int(parsed_json.get('product_id'))
self._amount = parse_float(parsed_json.get('amount'))
self._best_before_date = parse_date(parsed_json.get('best_before_date'))
self._amount_opened = parse_float(parsed_json.get('amount_opened'))

Do we might need a new class to represent missing products?
If so, I can try to open a PR with that change.

Thank you for reporting this! You're right, we need a separate class for missing products, feel free to submit a PR.


[master] update refresh_bootmap tool for several fix&enhancements

remove unnecessary chroot operation
sync cache to disk before umount
update mount parameter
Fix the rhel8 deploy error by specifying the root partition with multipath disk path

@benlei-ibm @changzhi1990 pls review. (I cann't add reviewers directly...)


docs: explain TfSec workflow cron expression

Adds a remark to the Cron expression explaining why it is there.

:tada: This PR is included in version 1.3.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updates reportback total to use override

Fixes #4652
Updated the dosomething_reportback_get_reportback_total_by_nid function to also add sum_rb_quantity_override to the quantity. Also re-added a blank line that I accidentally removed in a previous PR.
@angaither

@angaither good to go now?

:+1:


Add CODEOWNERS usage details

What article on docs.github.com is affected?
https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners#syntax-exceptions
What part(s) of the article would you like to see updated?
Add usage details about:

Excluding directories (using @ghost)
Changing files under an author's ownership
Appointing more than one CODEOWNER

Additional information

#7850

@sidletsky - thanks for flagging these omissions in the article about the CODEOWNERS file. It's clear it could do with some updates 👍🏻
I had a few questions for you so that we can make sure that any changes we merge to the article are accurate for all users.

Excluding directories (using @ghost)

I haven't seen this recommended before so I did a quick search and found a community thread that states that it no longer works: https://github.community/t/codeowners-file-with-a-not-file-type-condition/1423/3. Do you have a public repository where this is working?

Changing files under an author's ownership

As far as I know, if you edit files that you are a code owner for, you won't be added as a pull request reviewer. Is that your experience too?

Appointing more than one CODEOWNER

As far as I know, if a file has more than one code owner when you raise a pull request with changes to that file all code owners are added as reviewers. By default, code owner reviews are not required unless the repository has a branch protection rule that enables required reviews and also specifies that a code owner review is required.

Hi @felicitymay!
Answering your questions:
On using @ghost:

Do you have a public repository where this is working?

Not public, but a private one, it works. This is the code:
/.github/                                                                                @Company/some-team
/.github/CODEOWNERS                                                                                @ghost

It allows anyone to edit CODEOWNERS files without requiring @some-team to review it and github config files are still secured by the owners.

As far as I know, if you edit files that you are a code owner for, you won't be added as a pull request reviewer. Is that your experience too?

What I meant is that if a user creates a PR to the code under their ownership, then, if the review is required by the repository configuration, the review can be provided by any person to make the PR mergable.
For example, a user A is a part of @Company/some-team. The repository requires CODEOWNERS review to merge and the following CODEOWNERS file is setup in the repository:
/my_file                                                                                @Company/some-team

User A creates a PR with my_file edit. This PR can be merged if approved by anyone who is not in @Company/some-team, because the author is a part of the @Company/some-team.

As far as I know, if a file has more than one code owner when you raise a pull request with changes to that file all code owners are added as reviewers.

Interestig. Maybe some other configuration affected it. When I had two groups as CODEOWNERS, then approve from any of them will be enough to merge.

Hi @sidletsky
Thank you for answering my questions. It's really helpful to have more information. I've split my comment into sections to make it easier to navigate our discussion. Now that I believe that I've understood you correctly, I've made a short plan for the best way to update the article.
I think it would be better to separate the information on how the CODEOWNERS file works when a repository requires reviews by a code owner. This is only relevant to some users. So it's best to avoid adding this extra detail to the main content.
Excluding files/directories from ownership

Not public, but a private one, it works. This is the code:
/.github/                @Company/some-team
/.github/CODEOWNERS      @ghost

It allows anyone to edit CODEOWNERS files without requiring @some-team to review it and github config files are still secured by the owners.

That seems like a great use case. It's interesting to hear that this is working for you. I've done some local testing and you can also get the same effect with:
/.github/            @example-org/some-team
/.github/CODEOWNERS

I think it would be better to document something like this example as it doesn't rely on the @ghost account to work.
Editing files you own

As far as I know, if you edit files that you are a code owner for, you won't be added as a pull request reviewer. Is that your experience too?

What I meant is that if a user creates a PR to the code under their ownership, then, if the review is required by the repository configuration, the review can be provided by any person to make the PR mergeable.

Thanks for explaining. So effectively, if you create a PR that edits code you own, then the PR implicitly has code owner approval and there is no need for an explicit approval by a code owner for the change, even in a repository that has a requirement for a review by a code owner. I like your team example as this makes the meaning clear.
Editing files owned by multiple users/teams

As far as I know, if a file has more than one code owner when you raise a pull request with changes to that file all code owners are added as reviewers.

Interesting. Maybe some other configuration affected it. When I had two groups as CODEOWNERS, then approval from any of them will be enough to merge.

My apologies for the lack of clarity in my comment. What I saw was all code owners were added to the PR as reviewers. When the repository had a branch protection rule that required reviews and also specified that a code owner review was required, only one of them needed to approve the PR.
Plan for changes to the "About code owners" article

Excluding files/directories from ownership - Your pull request added an example to the Example of a CODEOWNERS file. I agree that this is a great place for this information but think this should use the alternative method described above.
Editing files you own and Editing files owned by multiple users/teams - I think it would be better to add a short new section to the article called "CODEOWNERS and branch protection".

This would mention that you can add a branch protection rule to ensure that pull requests are always reviewed by the code owners of the changed files.
Link to "About protected branches" for more information.
Give a short example CODEOWNERS file and explain the behavior for a code owner raising a pull request and for someone raising a pull request with two owners.

Hi @felicitymay!
Thank you for your feedback!
I found your tip on leaving empty CODEOWNER quite useful, thank you! I've applied the changes, please let me know if anything else needs to be done.

Thanks for the great discussion about how this all works and for updating your PR to follow the plan suggested above 😄 ✨
I'm just waiting on the tests to run before merging your PR 🚀


Fix: Pagination Options

What is the purpose of this pull request? (put an "X" next to item)
[] Documentation update
[x] Bug fix
[] New functionality
[] Changes an existing functionality
[] Other, please explain:
What changes did you make? (Give an overview)
Default number in the rows per page was 4 because I wanted to make sure pagination was visible in the scrollable area. However the other page options of 10 and 25 really don't go well with a default option of 4. So I made the default number as 5 and so other options 10 and 25 looks related. Also because I was using the same state variable rowsPerPage for the page options as I was doing it for the TablePagination, an error was seen when rows per page option is flipped. With these changes that error is no longer produced.
Add any screenshots

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update Item Docs Unclear or Broken

Brief bug description
Updating a kontent item via the management API appears to be broken (or undocumented?)
Repro steps
Use the following code:
const resp = await client
  .updateContentItem()
  .byItemId('<my item id>')
  .withData({
    title: '<my item title>',
    body: '<a new body>', // the field in kontent that I want to update
  })
  .promise()

Expected behavior
The body field in the payload should be reflected in kontent
Test environment

Platform/OS: Darwin Harrys-MBP 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan  9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64
Browser Firefox
Version 80.0.1

Additional context
N/A
Screenshots
Console log of resp.debug.response -

Was looking at the wrong docs - for future, what I thought i wanted to do lives here: https://docs.kontent.ai/reference/management-api-v2#operation/upsert-a-language-variant
Getting a new error:
```"Cannot deserialize the current JSON object (e.g. {"name":"value"}) into type 'System.Collections.Generic.IEnumerable`1[Kentico.Draft.API.ContentManagementApi.Models.V2.Variants.Request.ContentItemElementRequestModel]' because the type requires a JSON array (e.g. [1,2,3]) to deserialize correctly.
To fix this error either change the JSON to a JSON array (e.g. [1,2,3]) or change the deserialized type so that it is a normal .NET type (e.g. not a primitive type like integer, not a collection type like an array or List) that can be deserialized from a JSON object. JsonObjectAttribute can also be added to the type to force it to deserialize from a JSON object.
Path 'elements.elements', line 1, position 24."

Hi,
The correct syntax should be
.withElements([{
                element: {
                    codename: 'x',
                },
                value: ''
            }])

Can you try that? Are you using some IDE such as Visual studio code? We are shipping types so it should show you intellisense + warnings (if you are using typescript) if you use incorrect type variables.

Hey! Thanks for the response -  I found out how to do this by searching GitHub too -- https://github.com/brianjcarroll8/Gatsby/blob/7e83aced6b5c9fc421fd8f3b67b77269a6b59f09/benchmarks/source-kontent/update-article.js
I'm using JavaScript + Vim right now. The Vim setup clearly needs some more config.
Cheers!


Prismic support

Ref #5
A content provider should allow fetching content created with Prismic.

Implemented in #10


Design Order Process in a way to enable a user to go back and forth

Many order systems including flipkart and Amazon have the option to go back and forth in their order process. This enables the user to change the quantity of a ticket and to change the content of a basket. Please implement the order process similarly and enable users to change their order until they paid.

Hi, can you tell me what this project is all about?

open-event-frontend(EmberJs) is shifting to open-event-next(Reactjs) soon.
https://eventyay.com/

I know react.js and currently learning next.js. Can I start to build the UI of this project like the original one?


Need to run 'terraform apply' twice to get a proper Output

System Information
Linux distribution
Ubuntu 20.04

Terraform version
Terraform v0.12.24
+ provider.libvirt (unversioned)
+ provider.local v1.4.0
+ provider.template v2.1.2

Provider and libvirt versions
terraform-provider-libvirt e9ff32f1ec5825dcf05481cb7ef6a3b645696a4f
Compiled against library: libvirt 5.0.0
Using library: libvirt 6.0.0
Running hypervisor: QEMU 4.2.0
Running against daemon: 6.0.0

Description of Issue/Question
I'm not sure either it is a libvirt-related issue or generic for Terraform. Please address me to the proper channel if this one is incorrect.
I create few virtual machines and want to see their hostnames and IP addresses in the output. But when I do a first run I get only part of the information:
Outputs:

nodes = {
  "" = "<IP_ADDRESS>"
}

After next terraform apply I get what I want:
Outputs:

nodes = {
  "k8s0" = "<IP_ADDRESS>"
  "k8s1" = "<IP_ADDRESS>"
  "k8s2" = "<IP_ADDRESS>"
}

Setup
The full setup has ~200 lines of code in different files. I can provide it if necessary, but I think this one is enough to show:
resource "libvirt_domain" "k8s" {
  name   = "k8s${count.index}"
  memory = var.ram
  vcpu   = var.vcpu
  count  = var.vms_amount

  disk {
    volume_id = libvirt_volume.k8s[count.index].id
  }

  cloudinit = libvirt_cloudinit_disk.commoninit[count.index].id

  network_interface {
    network_id     = libvirt_network.kubernet.id
    hostname       = "k8s${count.index}"
    wait_for_lease = true
  }

  qemu_agent = true

  provisioner "remote-exec" {
    inline = ["echo net.ipv4.conf.all.rp_filter=0 | sudo tee --append /etc/sysctl.conf",
      "sysctl -p",
      "sudo rm /etc/resolv.conf",
      "echo nameserver <IP_ADDRESS> | sudo tee /etc/resolv.conf",
      "sudo apt update",
      "sudo apt install nfs-common -y"
    ]
    connection {
      type        = "ssh"
      user        = "igor"
      host        = self.network_interface.0.addresses.0
      private_key = file("/home/igor/.ssh/id_rsa")
    }
  }

  console {
    type        = "pty"
    target_port = "0"
    target_type = "serial"
  }

  console {
    type        = "pty"
    target_type = "virtio"
    target_port = "1"
  }

  graphics {
    type        = "spice"
    listen_type = "address"
    autoport    = "true"
  }
}

output "nodes" {
  value = zipmap(libvirt_domain.k8s.*.network_interface.0.hostname,
    flatten(libvirt_domain.k8s.*.network_interface.0.addresses))
  depends_on = [libvirt_domain.k8s]
}

I can provide the rest if necessary.
Steps to Reproduce Issue

Run terraform apply. See that VM are created and got proper IP and names, but that information is not presented in the Output.

Run terraform apply again and see information in the Output.

@igajsin check this
https://github.com/dmacvicar/terraform-provider-libvirt/blob/19c23424ccfdecf6dfcbdd87783bf835ba5f585e/examples/v0.12/count/main.tf#L25
I closed your previous issue because is a duplicate of this.

@igajsin hi thx for issue.
can you try something in this direction?
https://github.com/kubic-project/kubic-terraform-kvm/blob/6a69ab0320d670f9fc1ecd255a60fd68bd8b08d5/kubic-kvm.tf#L79
just remove zipmap etc constructs and flatten etc
actually if you use wait_for_lease should work.
Check also that example, you might find some inspiration

If I remove zipmap and flatten and use it like
     output "ips" {
       value = libvirt_domain.k8s.*.network_interface.0.addresses
     }

It works well, I got a list of lists of IPs from the first run as expected.
ips = [
  [
    "<IP_ADDRESS>",
  ],
  [
    "<IP_ADDRESS>",
  ],
  [
    "<IP_ADDRESS>",
  ],
]
nodes = {
  "" = "<IP_ADDRESS>"
}

But I need the zipmap for a reason, later I use the {host = ip} structure to render a template like
    locals {
      ips = libvirt_domain.k8s.*.network_interface.0.addresses
      names = libvirt_domain.k8s.*.network_interface.0.hostname
      inventory = templatefile("${path.module}/inventory.tpl", {
	nodes = zipmap(local.names,
	  flatten(local.ips))
      })
    }

    # generate inventory file for Ansible
    resource "local_file" "inventory" {
      content = local.inventory
      filename = "${path.module}/../kubespray/inventory/mycluster/inventory.ini"
      depends_on = [libvirt_domain.k8s]
    }

Any ideas why functions behave like that?

@igajsin  nope I have no idea. I never used such built-in function. Is something more terraform upstream issue afaik

Anyway, thanks for your help.

goodl luck!

Ok. I've got what happened. I used the version where the problem https://github.com/dmacvicar/terraform-provider-libvirt/issues/708 was presented. Because of the wrong treatment of hostnames when dhcp, instead of expected {hostname0=ip0, hostname1=ip1, ...} I got {""=ip0, ""=ip1, ""=ip2} structue, that obviously can't work with zipmap.
After updating the plugin to 0.6.2+git.1585292411.8cbe9ad0 the original issue has gone and my code works too.


Roll Engine from 8607ac495c59 to d54ac90b3e87 (1 revision)

https://github.com/flutter/engine/compare/8607ac495c59...d54ac90b3e87
2021-06-30<EMAIL_ADDRESS>Roll Skia from 55b401ed9e6c to 76e45134b8a7 (1 revision) (flutter/engine#27061)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Understanding figure 2 in the simPLE paper

Hi guys!

Consider Figure (b).
Assuming S denotes a measure of similarity, the aim of Triplet proxy free PSL is clear. We want to make Sp > Sn i.e. similarity between any two elements belonging to same class must be more than the similarity between any two elements belonging to a different class.
However in Figure (d),
If we assume S to be a measure of similarity, then similarity between any two elements of same class (Sp) must be more than a universal threshold (t) and the similarity between any to elements belonging to different classes must be less than a universal threshold (t), isn't it? Only then, that would mean the learned embedding space is suitable enough for an open-set recognition problem. In the figure the exact opposite of this is depicted. Does that mean S in figure 4 refers to distance or something?
Or I am misunderstanding something? Can someone please help clarify this figure for me?
Thanks,
Vinayak.

Hi @ydwen , @wy1iu
Could you please help with this?
Thanks & Regards,
Vinayak.

Hi ElisonSherton,
In this figure, we would like to demote similarity by S. So your understanding is correct: figure (d) shows the opposite, which is a typo. We will fix that in an updated version.

Thanks for the clarification.


Add :type option to arguments

I've found the :type option very helpful for flags, and I don't see a reason why it shouldn't be usable by regular (non-flag) arguments as well. Thoughts? I'd be happy to take a stab at implementing this.

Would non-flag arguments would be assigned :type by their position in the ARGV array?  How would it work?

I suppose it would be by position. As a concrete example, here's how I imagine using it:
desc "Adds two integers"
arg "NUM1", type: Integer
arg "NUM2", type: Integer
command :sum do |sum|
  sum.action do |_, _, args|
    puts args[0] + args[1]
  end
end

Of course, a lot of the power here comes from the ability to add custom classes with accept blocks, just like with flags:
class HTTPSURL ; end
accept(HTTPSURL) do |value|
  if value[0..6] == "http://"
    "https://#{value[7..-1]}"
  elsif value[0..7] != "https://"
    "https://#{value}"
  else
    value
  end
end

desc "Download files over HTTPS"
arg "URL", type: HTTPSURL, multiple: true
command :download do |download|
  download.action do |_, _, args|
    args.each { |url| download(url) }
  end
end

Does that make sense?

Sort of.  What if you had other args that were of another type?  You would have to specify argument position in the definition of the arg type:
arg "STR1", type: String, position: 1
arg "NUM1", type: Integer, position: 2
arg "STR2", type: Integer, position: 3
arg "NUM2", type: Integer, position: 4

Ah, I thought the order of arg calls itself specified the position. (Basically I agree with @mojavelinux in https://github.com/davetron5000/gli/issues/12#issuecomment-37626324) Is there a reason that isn't the case?

Yeah, I had always wanted to expand this to be richer, but it wasn't clear how you'd do it.
Since the args are positional, there are a lot of options for how to interpret them.  For example, you could have a fixed number of positional args.  You could have a fixed number and optional final arg.  You could have all of them optional but treated as a collective list (e.g. a file list), or some positional and some optional as a list.
To get this in an existing GLI app, you could use the pre hook to coerce the types of args.  I don't know if args is mutable, so your coercion might have to populate another data structure.

You can technically derive the position from the order of the args defined, but I do not think that is clear, especially when there may be flag interspersed with the unnamed position args?

I think the mental model is that, regardless of where things are on the command line, args is the ordered list of arguments to the command.  OptionParser will remove all switches and flags and whatever's left are the args.  So users should generally be doing stuff like:
app command --flag=foo --switch --other-flag=bar arg1 arg2 arg3

If a user wants to mix args amongst the flags and switches, they can, but that would be a strange invocation syntax.

Exactly. Since OptionParser already figures out what the args are regardless of their placement with flags and switches, I don't think I see the problem with that. To @davetron5000's earlier comment about the trickiness of knowing which argument is which when :optional is used, that seems like a general problem developers must handle regardless of whether they want their arguments coerced into a given type or not.
Is the real problem here the fact that OptionParser doesn't provide (as far as I can tell) hooks to do coercion of non-flag arguments?

Yeah, OptionParser just leaves the unparsed args alone.
So, I think it comes down to what is the API for developers to specify how they want the args treated?
Each arg needs a way to:

include a description
include a type
include a short name for the CLI usage statement (e.g. SRC_URL)

We can also assume that every arg but the last one is required and that the last arg is either: totally optional, also required, can be a list of things.
And then, a way to access the parsed results.  All without breaking backwards compatibility.
An explicit and simple thing might be:
args {
  mime_type: { description: "Mime types to upload"}, # required since not last, type is String since that's the default
  dest_url: { description: "Where to download files to", type: Dir }, # again, required since it's not last
  files: { description: "Files to upload", arity: :at_least_one } # at least one is required, multiple accepted, type is Array of String
]

# also
args {
  mime_type: { description: "Mime types to upload"}, # required since not last, type is String since that's the default
  dest_url: { description: "Where to download files to", type: Dir }, # again, required since it's not last
  file: { description: "File to upload", arity: :one } # required, type is String
]

# or
# also
args {
  mime_type: { description: "Mime types to upload"}, # required since not last, type is String since that's the default
  dest_url: { description: "Where to download files to", type: Dir }, # again, required since it's not last
  files: { description: "Files to upload, if any", arity: :any } # not required, type is Array of String
]

Trickier is making this available.  It could be that we make a fourth argument available to action blocks:
c.action do |global,options,args,parsed_args|
end

where parsed_args would be a hash of the values passed to arg?
I dunno, am I overcomplicating this maybe?

That feels way overcomplicated to me. My proposal is to keep all existing functionality and just add the minimum needed for this feature. Repasting my code from above, it would look like:
desc "Adds two integers"
arg "NUM1", type: Integer
arg "NUM2", type: Integer
command :sum do |sum|
  sum.action do |_, _, args|
    # Note that I'm accessing the type arguments directly from the `args` array.
    puts args[0] + args[1]
  end
end

So the help output would look like:
NAME
    sum - Adds two integers

SYNOPSIS
    test.rb [global options] sum NUM1 NUM2

This project has been fine so far without needing long descriptions for arguments, or needing to specify their positions, or needing a way of accessing arguments beyond just args array in action blocks. I don't see why this feature needs to change any of that. Introducing a complete overhaul to how arguments are specified seems pretty unnecessary and will only complicate both this codebase and those of projects using GLI.
(And if in the future there's a desire for long argument descriptions, that can be added separately—for instance by extending the existing syntax à la arg "NUM1", description: "an integer to add", type: Integer)
What am I missing here?

Yeah, @JacobEvelyn you are right.  That is super simple and, honestly, if we want something much more complex/featureful later, your syntax doesn't make that any more difficult.

closing this as old (almost 5 years!)  re-open if you still want/need this


Sema: Avoid emitting superfluous resilience diagnostics with MemberImportVisibility

When MemberImportVisibility is enabled, if the import that would bring a member declaration into scope is missing it is diagnosed as an error. The existing resilience diagnostics that would also diagnose the same problem in contexts that are visible in the module interface are therefore superflous with the feature enabled.

@swift-ci please smoke test


Merge pull request #488 from MicrosoftDocs/main

Deploy January 2022 publish

Docs Build status updates of commit f1df1b4:
:warning: Validation status: warnings
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


CloudinaryAsset for a list of remote images

Hello,
When trying to use images that already exist on Cloudinary, It seems that the plugin does not recognize a list of images with the structure defined on the documentation, here is an example:
{
  "title": "Foo",
  "images": [
    {
      "cloudinaryAssetData": true,
      "cloudName": "bar",
      "publicId": "bar/whatever-1",
      "originalHeight": 969,
      "originalWidth": 546
    },
    {
      "cloudinaryAssetData": true,
      "cloudName": "bar",
      "publicId": "bar/whatever-2",
      "originalHeight": 969,
      "originalWidth": 546
    }
  ]
}

But if there is only one image, it works as expected :
{
   ...,
  "image": {
      "cloudinaryAssetData": true,
      "cloudName": "bar",
      "publicId": "bar/whatever-1",
      "originalHeight": 969,
      "originalWidth": 546
  }
}

I can't even query for cloudName, publicId, etc.
A possible solution for this?

thanks @hazzyeer for sending this in. I'm checking it out.

@hazzyeer I think this was fixed in version 2.1.0. Deeply nested asset data wasn't processed before that version.

@hazzyeer Actually, I think the issue is that your image nodes are nested inside an array. This plugin doesn't currently look inside arrays for asset data. I'd recommend you name each of your images:
{
  "title": "Foo",
  "whateverOne": {
    "cloudinaryAssetData": true,
    "cloudName": "bar",
    "publicId": "bar/whatever-1",
    "originalHeight": 969,
    "originalWidth": 546
  },
  "whateverTwo": {
    "cloudinaryAssetData": true,
    "cloudName": "bar",
    "publicId": "bar/whatever-2",
    "originalHeight": 969,
    "originalWidth": 546
  }
}

If you'd like to submit a PR to make this plugin look inside arrays for asset data, this PR will be a good starting point to figure out what needs to be modified: https://github.com/cloudinary-devs/gatsby-transformer-cloudinary/pull/57

That's a bug and not an enhancement...

This should work with beta that is out now.
Take a look at #163 for how to help with testing.
It would be much appreciated if you would help test the new beta version, it also adds Gatsby v4 support @hazzyeer and @kurttomlinson.

Solved in v3.0.0


Out of date with latest CIS guide

The current CIS standard for 20.04 specifies <IP_ADDRESS> as disabling squashfs (which is problematic, because of the rise of "snap".) See below:

https://github.com/florianutz/ubuntu2004_cis/blob/main/tasks/section1.yml#L165
Your <IP_ADDRESS> specifies udf, and <IP_ADDRESS> specifies fat which is not mentioned in the standard anymore.
Happy to submit a PR if you agree that you'd like to update the role to be in compliance with the latest published standard

Hi @rcousens , it would be great if you could create a PR for the necessary changes.

When I get a moment in the next week or two I'll do that :)

@florianutz Thanks for accepting my PR. After a comment on the PR from @alex-rowe I've done some more thinking about the applicability of the changes I made.
I notice that CIS Benchmark has Level 1 and Level 2 Profiles for both Server and Workstation (obviously Server being applicable here). Is the intent of this module to implement both Level 1 and Level 2 indiscriminately?
Also, specifically relating to squashfs: on Ubuntu squashfs is a built-in filesystem compiled into the kernel by default. Which makes rule <IP_ADDRESS> from the latest CIS Benchmark kind of silly in that the remediation is not actually possible. I will note that the rule is "manual" implying that it's not scored directly for compliance. What are your thoughts on supporting manual/automated? Should manual steps be disabled (set to false) by default?
See https://github.com/florianutz/ubuntu2004_cis/pull/52 for more details.

@florianutz This ticket can be closed!


Make log level of slf4j logger configurable

Feature Request
Which Areas Would Be Affected?
boot, monitor
Why Is the Feature Desired?
We can not get log of underlying libraries using slf4j if the log level is equal to or smaller than INFO since the log level of slf4j logger is hard coded.
It is inconvenient for developing modules depending on libraries using slf4j. Technology-Aws depending on AWS SDK is the example.
We can not temporalily use another binding like slf4j-simple if MonitorProvider is in the classpath. Since the MonitorProvider is provided by org.eclipse.edc:boot, most of the code depending on EDC could be affected.
S3DataPlaneIntegrationTest STANDARD_ERROR
    SLF4J: Class path contains multiple SLF4J providers.
    SLF4J: Found provider [org.eclipse.edc.boot.monitor.MonitorProvider@47c64cfe]
    SLF4J: Found provider [org.slf4j.simple.SimpleServiceProvider@6ce90bc5]
    SLF4J: See https://www.slf4j.org/codes.html#multiple_bindings for an explanation.
    SLF4J: Actual provider is of type [org.eclipse.edc.boot.monitor.MonitorProvider@47c64cfe]
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

Solution Proposal
Making the log level of slf4j logger configurable as done for slf4j-simple.
Making the feature opt-in could be an option. If the feature is enabled by loading the extension, EDC Config is available on initialize. Modules not loading BaseRuntime (e.g. Technology-AWS) can use alternative slf4j binding during development.

AFAIR the MonitorProvider was added a long time ago to satisfy some transitive dependency. Do we even need it anymore or can we remove it?
That would mean that people can just register their downstream implementation of a Monitor, e.g. an Slf4jMonitor.

I submitted #3463 which removes the MonitorProvider from the code path of BaseRuntime. The SLF4J-Monitor bridge feature still could be  useful for users of  existing monitor like LoggerMonitorExtension to make log destination settings simple.

I'm updating the PR to remove the bridge then.

That's the reason why PRs should only raised once issues are out of triage: getting clarity on the desired implementation.

Seeing the code change should be effective to make the issue clear and affected scope clear in this case. I needed some action before the issue is auto-closed without update for a week.


Replace mapbox-gl-inspect with maplibre-gl-inspect

This hopefully fixes #871

#871

I still need to update maplibre-gl-inspect to allow this to be fixed.

Codecov Report
Attention: Patch coverage is 40.90909% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 57.28%. Comparing base (5f54dd0) to head (e7a9e8f).

Files
Patch %
Lines

...c/components/MapMaplibreGlFeaturePropertyPopup.tsx
0.00%
8 Missing :warning:

src/components/MapMaplibreGlLayerPopup.tsx
42.85%
4 Missing :warning:

src/components/MapMaplibreGl.tsx
85.71%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   57.23%   57.28%   +0.05%
==========================================
  Files         104      104
  Lines        2939     2936       -3
  Branches      670      670
==========================================
  Hits         1682     1682
+ Misses       1257     1254       -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


MonitorStage add a blank space between the rate and the unit description

Improves readability of the output from the monitor stage
Changes output from:
FromFile rate[Complete]: 93085messages [00:01, 89424.59messages/s]

To:
FromFile rate[Complete]: 93085 messages [00:01, 89424.59 messages/s]

All I did was just insert a blank space in front of the unit name. As far as I can tell tqdm doesn't give control over the rate_fmt:
https://github.com/tqdm/tqdm/blob/master/tqdm/std.py#L445

@gpucibot merge


Flowify jest-environment-node

This adds flowtypes to the jest-environment-node package! 🎉

@cpojer mind another look? :D


add secret for cloud provider variables when using acme

Hi @ekjuanrejon , thanks for this contribution!
Would you mind explaining the high level use case please?
I understand that you want to pass secrets as environment variables to Traefik: if this is correct,
WDYT providing the secret references to Traefik, under a values.yaml section named secrets: that would provide reference and a 2nd directive exposeToEnv:
secrets:
  - reference: a-secret-used-as-env
     exposeToEnv: true
  - reference: a-secret-not-exposed-to-env
     exposeToEnv: false

?
The reason is simple (if I understand correctly the use case): with Helm v2, the values of an installed chart are stored in a ConfigMap, which means that the value that you want in a secret are stored as plain text, available in the API, which you might not want :)
Instead, if you keep, as end user, responsibilities to create the secrets yourself so it's always secret, and only ask Traefik to mount these secrets, and eventually expose its, then it should solve the "end to end" secret issue, what do you think?

@dduportal I think what @ekjuanrejon wants to do is to make this chart work well with certificates generated and managed by cert-manager. I presume this cert is a wildcard cert of sorts.
To make this PR's feature useful, it should simple:

allow specifying the secret name via values.yaml
have the chart mount this secret to be used as a default cert.

Hi @ekjuanrejon,
Thanks for your contribution.
I will close your issue because the support of secret in environment variable has been added by #101


Add 'new' badge on swap tab & Add shapeshift promo

Add 'new' badge available to all nav tabs by adding badge: true key val pair
Add Shapeshift promo

PR has a massive diff I wasn't expecting, closing and making a clean pr.


RStudio Updated Error: undefined local variable or method `version'

Error when starting an RStudio Server after the install of ood_updated_rstudio:
undefined local variable or method `version' for #<BatchConnect::SessionContext:0x0000000003183f78>
* The RStudio Server session data for this session can be accessed under the staged root directory.

Per Louis, the fix is to change version.split to r_version.split in roles/ood_updated_rstudio/files/submit.yml
diff --git a/roles/ood_updated_rstudio/files/submit.yml b/roles/ood_updated_rstudio/files/submit.yml
index a2a174c..d292772 100644
--- a/roles/ood_updated_rstudio/files/submit.yml
+++ b/roles/ood_updated_rstudio/files/submit.yml
@@ -8,7 +8,7 @@ script:
     - "--mem-per-cpu=<%= bc_num_mems.blank? ? 4 : bc_num_mems.to_i %>G"
     - "--partition=<%= bc_partition %>"
     - "--time=<%= bc_num_hours.blank? ? 1 : bc_num_hours.to_i %>:00:00"
-    - "--job-name=ood-r-<%= version.split("/")[-1] %>"
+    - "--job-name=ood-r-<%= r_version.split("/")[-1] %>"
 <%- if bc_partition.include? "pascalnodes" -%>
     - "--gres=gpu:1"
 <%- end -%>

I have made the change manually on the OOD server and confirmed it works

Also, the r_version now includes toolchains, e.g. "r_version": "R/4.1.0-foss-2021a", with the current method, user will have job name like: ood-r-4.1.0-foss-2021a, do we want to keep toolchain in the job name or further trim it down to ood-r-4.1.0?


fix for 2d diagnostics llc bug

Fixes #140. (Alternative to #143.)
I believe this is the simplest and quickest path to fixing the 2d llc diagnostic issue.

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   94.01%   94.01%
=======================================
  Files           4        4
  Lines         986      986
  Branches      223      223
=======================================
  Hits          927      927
  Misses         31       31
  Partials       28       28

Impacted Files
Coverage Δ

xmitgcm/mds_store.py
92.03% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79fafbd...453c000. Read the comment docs.


#2044 - Added support for adding the page description on page add and page set

This PR contains the fix for setting the description field when using the page add and page set commands.

Thanks! We'll go through it ASAP

Thanks! We'll go through it ASAP

Merged manually. Thank you!

Merged manually. Thank you!


feat(config): hmr add disable port config

Description
HMR connecting failed when I have to config a hmr port or using default port.
Unexpected socket host:   www.mydomain.com:3000
Expected socket host:   www.mydomain.com

Using default port cannot solve this problem completely when I need both http(80) and https(443) domain to access.
Adding a custom hmr host config is not a perfect solution, cause I have to config different hmr host for every project.
So, I was wondering if we can add disable port config for this situation?
Solution 1:
Change port: number -> port: number | false.
Solution 2:
add new config: disablePort: boolean (default false)
below is changes of Solution 1.
What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[ x Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

CI failed caused by  this line
code.replace should be code.replaceAll for an injected global var used more than once
`

below is changes of Solution 1.

Looks like the changes now are Solution 2 though. I think Solution 1 seems nicer to avoid another option.

yeah... but solution 1 make type of port a bit weird, don't you think?
Another option seems to in conformity with the SRP.

below is changes of Solution 1.

Looks like the changes now are Solution 2 though. I think Solution 1 seems nicer to avoid another option.

Hi @bluwy , please review again when you convenient, thanks!

I also think that solution 1, port: number -> port: number | false is better here

I also think that solution 1, port: number -> port: number | false is better here

Sure,  now is solution 1 already.

We'll discuss it in the next meeting to validate the API change. Thanks @jeoy!

We are good to merge this PR, let's do it in the 2.9 beta (we should start it soon)

I think we should update the types in the docs too.

rebase main branch

This LGTM with one more update to the docs at https://vitejs.dev/config/#server-hmr

This LGTM with one more update to the docs at https://vitejs.dev/config/#server-hmr

Docs updated.


C++ standard conformance

Looking through the code I see things like:

Identifiers starting with underscore (in violation of [lex.name]/3)
Use of char* instead of std::string
Use of windows-specific functions instead of standard library
Use of home-grown solutions instead of standard library

I also can't tell which version of C++ standard the code follows (other than the D3D9 client and some tileedit utility).
As a first step I would recommend picking a standard for the project, so that contributors know not to exceed it.
Luckily, MSVC (VS 2019 16.10) has a full support for the C++20 core language and also the Standard Library. So, this should be pretty easy - pick C++20 as the standard for the project.
Next is, obviously, would be to incrementally update the code-base to conform to the standard, as well as replace any windows-specific functions with the STL ones.
This will also help make the code easier to port to other platforms, such as Linux and MacOS.

If you are interested in working on this, it would be worthwhile to collaborate with https://github.com/TheGondos who was working on some of the same things, especially some of the Windows-specific stuff.
I would do this as incrementally as possible so that anyone that is working on longer-running projects has less to worry about by way of merge-conflicts.

@n7275 yeah that sounds good. Unfortunately, I don't see any changes in that repo landing in here. Did I miss something?

Another thing is the coding style. Or, rather, lack of it... 😅 Is there one?

Just remember, a lot of us aren't professional programmers.  Might keep that in mind when writing...

@maxq519 neither am I 😄. I am talking about a simple document with things like:

Use .h extension for header files and .cpp for source files.
Use 4 spaces for indentation.
Use #define guards in headers.
Use camel notation for functions.
...
...

Nothing complicated.

@Xyon let me know what you think about these patches. I've got about 50 of them queued up, but I wanted to release them piece-meal, so as not to overwhelm anyone.

I think if you want to make a sweeping change to the code style, that doesn't change anything functional, make it as one giant commit. If we ever need to look back through the commit log it will be way more clear, say 5 years down the road. As part of closing this issue you can/should probably rev the contribution guide to match.

@n7275 I can do one giant commit. I was just thinking for the purposes of future bisects to track down bugs, it would be better to have small commits. Plus, I didn't want to overwhelm anyone. 😄
And just to clarify, there aren't any functional changes to the code. The only things I am doing is fixing things considered invalid by current C++ standards.
 This way it can be approved once, but still gives an option of running git bisect in the future.

One giant commit is definitely harder to read through for seeing the changes, which is definitely going to help for my purposes :P

@Xyon I've got a bunch more patches ready to go. All small. Should I go ahead and add them to the PR #342 or would you rather want a separate PR?

Eh, sod it, lob them in 342

@Xyon done. Now the real work can start... 😈


Error in pixReadStreamJp2k

Environment

Tesseract Version:

tesseract v<IP_ADDRESS>11201
 leptonica-1.78.0
  libgif 5.1.4 : libjpeg 8d (libjpeg-turbo 1.5.3) : libpng 1.6.34 : libtiff 4.0.9 : zlib 1.2.11 : libwebp 0.6.1 : libopenjp2 2.3.0
 Found AVX2
 Found AVX
 Found FMA
 Found SSE4.1
 Found libarchive 3.5.0 zlib/1.2.11 liblzma/5.2.3 bz2lib/1.0.6 liblz4/1.7.5 libzstd/1.4.5
 Found libcurl/7.77.0-DEV Schannel zlib/1.2.11 zstd/1.4.5 libidn2/2.0.4 nghttp2/1.31.0

Commit Number:
Platform:

Current Behavior:
Error in pixReadStreamJp2k: version 2.3.0: differs from minor = 2 Error in pixReadStream: jp2: no pix returned Error in pixRead: pix not read Error during processing.
The file is available here
Expected Behavior:
Converting jp2 image to pdf file.
Suggested Fix:

Please try whether that issue also occurs with the latest Tesseract for 'Windows. If possible try also Tesseract on Linux.

@stweil
I did install the latest version from here

Result:

but tesseract --version shows 5.0.0 (see above)

I cannot confirm that:
Are you sure that you really run the latest version? Please look also on the timestamp of tesseract.exe.
$ wine tesseract --version
tesseract v<IP_ADDRESS>20118
 leptonica-1.78.0
  libgif 5.1.4 : libjpeg 8d (libjpeg-turbo 1.5.3) : libpng 1.6.34 : libtiff 4.0.9 : zlib 1.2.11 : libwebp 0.6.1 : libopenjp2 2.3.0
 Found AVX2
 Found AVX
 Found FMA
 Found SSE4.1
 Found libarchive 3.5.0 zlib/1.2.11 liblzma/5.2.3 bz2lib/1.0.6 liblz4/1.7.5 libzstd/1.4.5
 Found libcurl/7.77.0-DEV Schannel zlib/1.2.11 zstd/1.4.5 libidn2/2.0.4 nghttp2/1.31.0

... and there is no need for screenshots here.

I finally managed to install the latest Windows version:
C:\Users\walte>tesseract --version
tesseract v<IP_ADDRESS>20118
 leptonica-1.78.0
  libgif 5.1.4 : libjpeg 8d (libjpeg-turbo 1.5.3) : libpng 1.6.34 : libtiff 4.0.9 : zlib 1.2.11 : libwebp 0.6.1 : libopenjp2 2.3.0
 Found AVX2
 Found AVX
 Found FMA
 Found SSE4.1
 Found libarchive 3.5.0 zlib/1.2.11 liblzma/5.2.3 bz2lib/1.0.6 liblz4/1.7.5 libzstd/1.4.5
 Found libcurl/7.77.0-DEV Schannel zlib/1.2.11 zstd/1.4.5 libidn2/2.0.4 nghttp2/1.31.0

But still the same error:
Error in pixReadStreamJp2k: version 2.3.0: differs from minor = 2 Error in pixReadStream: jp2: no pix returned Error in pixRead: pix not read Error during processing.
This does not happen with the Ubuntu version.