Add workflow to leave PR comment

When a code snippet is updated often its line numbers also change. These line number references are used to render the snippet on ADP. It is easy to forget that step, and this Action will leave a reminder comment on the pull request to make that check prior to merging.

The action itself looks fine, but since this is just a note why not just add this to the PR templates as a checklist item?

The action itself looks fine, but since this is just a note why not just add this to the PR templates as a checklist item?

It's a good question. In discussing it with @tbedford, @marklewin and @fabianrbz yesterday, we felt that adding it as a note in the PR checklist would add a level of complication for contributors that might be overwhelming as it's dealing with submodules and a separate repository, etc. The line checks should be on the merger i.e. the repo owner, not the contributor to the code snippet PR.

Why not move this to the auto-PR that's generated after at nexmo/nexmo-developer when something is merged to master then? Right now this would add the comment when the PR is generated in this repo, meaning a new contributor would get the message about updating the ADP line numbers, which sounds like what we don't want?
This still feels like we're adding automation for automation's sake (this could just be part of the ADP submodule PR as text for that PR)

Why not move this to the auto-PR that's generated after at nexmo/nexmo-developer when something is merged to master then? Right now this would add the comment when the PR is generated in this repo, meaning a new contributor would get the message about updating the ADP line numbers, which sounds like what we don't want?

That's a good point. I'll get back to this with that feedback, it might be better to add it there than in each code snippet repo.

@dragonmantank, One issue that @tbedford brought up is a lot of people tagged on the auto-submodule PRs on ADP don't actually see or respond to the notifications, which would make adding a comment there less effective than in the original PR in the actual code snippet repo. Any thoughts on that?

At the risk of being too harsh, anyone with merge access to our repos should have enough GitHub skills to manage their notifications and keep track of what's assigned to them. I think this confuses people because they aren't always aware of how the mechanics of the code snippets work - that changes to snippets may need to be followed by changes or at least a human-driven merge to the developer portal where it's used. My instinct is to add the reminder to the automated PR on the docs repo, and do another set of education (perhaps in the PDX meeting) to remind people to look out for the followup PR.

At the risk of being too harsh, anyone with merge access to our repos should have enough GitHub skills to manage their notifications and keep track of what's assigned to them. I think this confuses people because they aren't always aware of how the mechanics of the code snippets work - that changes to snippets may need to be followed by changes or at least a human-driven merge to the developer portal where it's used. My instinct is to add the reminder to the automated PR on the docs repo, and do another set of education (perhaps in the PDX meeting) to remind people to look out for the followup PR.

I don't think that's too harsh at all, and well said.
I'm hearing now two affirmations for making this kind of thing in the automated PR in ADP.
Thanks @lornajane and @dragonmantank for the back and forth.


Quickstart: Add section to direct downloads of pre-build images

Task Description
Page: https://github.com/solettaproject/soletta/wiki/Quickstart
Add a section with the links to the supported pre-build images:

https://github.com/solettaproject/soletta/wiki/Installing-Intel®-Edison-pre-built-image
https://github.com/solettaproject/soletta/wiki/Installing-Intel®-Galileo-Gen2-pre-built-image
https://github.com/solettaproject/soletta/wiki/Installing-Minnowboard-max-pre-built-image

Dependencies
None

done


name and year extraction not working

i still cannot extract month and year everytime. only sometime it extracts month and year and that to be wrong.
using sdk version: - com.getbouncer:cardscan-ui:2.0.0059
set initializeNameAndExpiryExtraction to true
Originally posted by @mihirmodiofficial in https://github.com/getbouncer/cardscan-android/issues/82#issuecomment-806387255

hi @mihirmodiofficial , apologies for the very slow response, I didn't get notified of this issue.
Name and expiry extraction is not guaranteed on scan, but it is a best effort by the library. We have made substantial improvements to both name and expiry extraction in recent versions of the SDK. Can you please upgrade to the latest version (2.0.0082 as of this comment) and check to see if extraction improves?

Closing this issue due to inactivity. Please feel free to re-open.


UseVersionMiddleware not work when publish to .exe single file

Hi,
I added the UseVersionMiddleware ability to my CLI project and when I testing it on a non publish ouput .exe file in seem to be work but will trying to test it after publish into a single file I get this result:
C:\CLI>[CliExeFileName] -v
[CliExeFileName].exe
The path is empty. (Parameter 'path')

Thanks kashti3.  Free time is hard to come by atm but I'll find some time to look into this over this during the week.

Thankfully, MiloszKrajewski figured this out already for Spectre Console.  https://github.com/spectreconsole/spectre.console/issues/242.  I'll get an update pushed in the next couple of days.
Thank you @MiloszKrajewski

this has been fixed and released in https://www.nuget.org/packages/CommandDotNet/6.0.3


Add short demo for new users

Adds demonstration video as requested in #41.
I had a guess at the commands I thought would be most commonly used to show off in a demo that's just over 30s.

Looks like you uploaded the demo video to a non-permanent address, because the video in the README is broken.

Hm, it looks like something weird has happened. It doesn't render like it used to for me.

I think I may have fixed it.


kusk deploy does not work with absolute paths

Running kusk deploy with the watcher and with absolute paths renders no change on Kusk Gateway
For example:
go run main.go deploy -f /absolute/path/to/openapi.yaml -w

When you make an update to the file, the command detects the update but the change is not applied to the Kusk Gateway.

It is a known issue with fsnotifier which @kylehodgetts also noticed. Unfortunately it is a known issue with them https://github.com/fsnotify/fsnotify/issues/160 (somewhat explains it)

Thanks @arp242 for jumping with an example as well!
We'll try to look how to solve this :)


It looks like to interfere with tree-shaking

Hi guys,
it looks like this plugin has some unintended side effect.
molszanski  staff   139K Apr 12 14:38 index.with_node_resolve.js
molszanski  staff   106B Apr 12 14:38 index.without_node_resolve.js

Here is an example repo.
Adding node-resolve to the setup below will interfere with tree-shaking and will increase the bundle-size.
// index.js
import { fun1 } from "./module";
fun1();

// module.js
import { stuff } from "some_module";
export function fun1() {
  console.log("123");
}

An easy way to prevent this is to specifically mark 'mobx'  as external in your rollup configuration. If you also add 'treeshake.pureExternalModules: true', the import will be entirely removed.

My initial surprise was when 2 of the configs below did produce different results.
Even adding pure treeshake didn't help.

// Configu result - 139K
const js = {
  input: "src/index.js",
  output: [
    {
      file: "dist/index.with_node_resolve.js",
      format: "iife",
      name: "test"
    }
  ],
  treeshake: { pureExternalModules: true },
  plugins: [nodeResolve()]
};

// Config result - 106B
const js_withouth = {
  input: "src/index.js",
  output: [
    {
      file: "dist/index.without_node_resolve.js",
      format: "iife",
      name: "test"
    }
  ]
};

But adding external "marker" did the trick
// Config result - 106B
const happyConfig ={
  ...
  plugins: [nodeResolve()]
  external: ["mobx"];
};

Maybe it would be a good idea to drop a line or two into the docs about it for the next adventurer :)

The behaviour is described here: https://rollupjs.org/guide/en#peer-dependencies
If you think this should be extended, featured more prominently, or linked to from specific other places of the documentation we are always open to suggestions.

You can always directly contribute to the documentation here: https://github.com/rollup/rollupjs.org


Downsample

Sample for downsampling a point cloud. Based on Martin's Matlab code:
https://github.com/zivid/matlab-samples/blob/master/DownsamplePointCloud.m
https://github.com/zivid/matlab-samples/blob/master/downsample.m

You need to run black on this project

Ready for next round


improvement improve readability and efficiency of the checks

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


make ocis on eos great again

makes eos-start work on macos
adds host.docker.internal to eos mgm and cli hosts to allow configuring it as the LDAP host
updates the ocis-reva dependency to master to get eos gateway related fixes

I get an error
9:30PM ERR Users/mbarz/go/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200416050838-5fc8adf27f83/internal/grpc/services/storageprovider/storageprovider.go:319 > storageprovider: error calling CreateHome of storage driver error="eos: error creating nominal home: eos: error chowning directory: user: unknown user einstein" pid=76880 pkg=rgrpc traceid=1048d0c08d003817d6b6e3eba5339bab```

while make eos-start seems to work, I'm trying to run make eos-ocis, but attempting to log with einstein:relativity just results on an unauthorized request:
Having a look at the logs it seems the auth provider finds the user, but the storage provider is not available (?):

@micbar @refs @kulmann make sure you killed all ocis processes and eos docker containers before running make eos-start.
the login error you are seeing is caused by ldap net being accessible from within the container...
please post the output of docker exec -i eos-mgm1 authconfig --test. verify it is the same en the container running the storageporvider with docker exec -i eos-cli1 authconfig --test

also docker exec -it eos-mgm1 id einstein and docker exec -it eos-cli1 id einstein should immediately return uid=20000(einstein) gid=30000(users) groups=30000(users),30001(sailing-lovers),30002(violin-haters),30007(physics-lovers)


A lightweight version of readdirex?

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
Currently Vim has two ways to read a directory:

readdir which only returns names
readdirex which does a lot behind the scene, e.g. stat files, find user and group names

I'm writing a file explorer plugin that needs to show a ls -F style listing. Since some directories are large and on slow medium (rotational disks, network locations), I'd like to avoid the overhead of readdirex.
Describe the solution you'd like
A function to return both names and types (and perhaps inode numbers), but no more.
Describe alternatives you've considered
I've tried to use the Python interface but got #8573.
Additional context
Add any other context or screenshots about the feature request here.

On Unix:
lstat(), stat() (if needed), getpwuid() and getgrgid() are called for each file.
Dropping the "user" and "group" attributes will reduce the overhead for calling getpwuid() and getgrgid().
Other attributes may not affect so much.
On Windows:
No other APIs are called for each file to get the attributes.
Dropping some attributes may not affect so much. It may only reduce the overhead to add items to the dictionaries (dict_add_string() and dict_add_number()).
We might be able to add an option to the 3rd parameter of readdirex() to drop "user" and "group".

I'm on Linux.
A thousand uncached stats are much slower that a thousand getpwuids since data of the latter should have been cached normally.
import os
import timeit

def list_only(path):
  return [x for x in os.scandir(path)]

def list_with_stat(path):
  return [x.stat(follow_symlinks=False) for x in os.scandir(path)]

if __name__ == '__main__':
  print(timeit.timeit('list_only("/usr/bin")', number=100, globals=globals()))
  print(timeit.timeit('list_with_stat("/usr/bin")', number=100, globals=globals()))

Result:
0.1860306989401579
1.142954096896574

(The directory being tested against is on an NVMe SSD.)

If the major overhead comes from stat(), it is difficult to make readdirex() faster.
Because, even if you only need the names and types and don't need other attributes like size and time, still lstat() is called once for each file.

lstat is not needed for types. readdir(3) will return it.

Ah, I totally forgot that. Is the d_type member portable?

Not in POSIX. Python checks it at compile time. It's available on Linux, FreeBSD and OpenBSD.


TTFOpenFile Error : Can't load .ttf to add custom font for creating PDF file

Hi
I encounter TTFOpenFile Error as error below.

I follow this link for a custom Thai-Font,  but I can't make it
https://xhtml2pdf.readthedocs.io/en/latest/reference.html#using-custom-fonts
I refer to my external CSS file as an HTML file below, it works properly,  but @font-face tag, I cannot embed @font-face into my CSS file, so that's why I have to put it into an HTML file directly.
From the given error message above.   I am not sure of this error, perhaps I may configure some steps incorrectly.
This is my code.
There are some parts in the HTML file  such as links to,css, style font  or table to show data.
{% load static %}

    <meta charset="UTF-8">
    <title>Overview PM-Report</title>
    {#     <link href="/app/static/app/content/pm_pdf_css.css" rel="stylesheet" />#}
    <link rel="stylesheet" type="text/css" href="{% static 'app/content/pm_pdf_css.css' %}"/>

        {{ pmInfo.project.company.company_name }}

        Name
        {{ pmInfo.project.company.company_full_name }}

        Address
        {{ pmInfo.project.company.company_address }}

        Telephone
        {{ pmInfo.project.company.company_telephone }}

this is my view.py
from django.conf import settings
from django.template.loader import get_template

from django.http import HttpResponse
from xhtml2pdf import pisa
from django.shortcuts import  get_object_or_404
from .models import *
import os

def fetch_resources(uri, rel):
    #https://groups.google.com/g/xhtml2pdf/c/TPTl4PTJn1U?pli=1
    path = os.path.join(settings.STATIC_ROOT, uri.replace
    (settings.STATIC_URL, ""))
    return path
def build_pdf_overview_pm(request,id=0):
    #https://xhtml2pdf.readthedocs.io/en/latest/usage.html#using-xhtml2pdf-in-django

    pm_obj = get_object_or_404(PreventiveMaintenance ,pk=id)
    inventoryPMList=pm_obj.pm_inventory_set.filter(is_pm=True)

    overview_template_path = 'app/pdf_overview_pm.html'
    overview_file_path="overview_pm_report.pdf"
    context ={'pmInfo': pm_obj,
        'inventoryPMList':inventoryPMList }

    # Create a Django response object, and specify content_type as pdf
    response = HttpResponse(content_type='application/pdf')
    response['Content-Disposition'] = f'attachment; filename="{overview_file_path}"'

    # find the template and render it.
    template = get_template(overview_template_path)
    html = template.render(context)

    # create a pdf
    pisa_status = pisa.CreatePDF(html, dest=response,link_callback=fetch_resources)
    # if error then show some funny view
    if pisa_status.err:
       return HttpResponse('We had some errors
' + html + '
')
    return response

The last picture, show a comparison between unloaded Thai-Font and  pdf file that I save as SavePDF of google chrome( I capture HTML  file before generating pdf)

Thank you for any help.
Pongthorn Sangkaphet

close

the temp solution is (tested on python 3.11 windows 11)
file:
Python311\site-packages\xhtml2pdf\context.py line 853
file = TTFont(fullFontName, filename)
change it to
file = TTFont(fullFontName, file.uri)


investigate and go around the GCE firewall bug

It seems like sometimes (with a brand new project?) the firewall (http(s)) rules we ask for when launching an instance on GCE with the deployer aren't created.
Enabling/Disabling them in the GCP UI once the project is created seems to fix the problem. Maybe we can do the same programmatically.
Or add the firewall rules post-creation with an API call instead of just relying on the cloud-config.

I'll have a bash at this.

brilliant, thanks.

+1
I experienced this issue as well when creating a new project. I had to remove/add the HTTP and HTTPS Traffic options before I could access.

What does cloud-config have to do with this at all?  That's a CoreOS thing inside of Linux.  The firewall is outside and unrelated.
Aside from that, I can't understand the different things said in this bug: is the problem that the default network is missing rules for handling the "http-server" and "https-server" tag?  Or that toggling the "http-server" / "https-server" tags in the web UI fixes the problem.  Or both?
Maybe the web UI recognizes this problem (of old/new projects having a different default network) and has its own workaround to create the firewall rules.
I suppose we could just query the default network's rules and create them if they're missing.

yeah I tend to say "cloud-config" when I just mean "all the parameters we have in instance := &compute.Instance{...}", my bad. I know it's actually the CoreOS thing. I edited it out of my first comment.

https://camlistore-review.googlesource.com/#/c/4437/

df8209ca7a6305a9ea9fde53868da18253a52b72


Can upload pre-trained models for CIFAR10 and ImageNet?

Hi, Leonard
Great job, what a nice paper!
Can you upload your pre-trained models for CIFAR10 and ImageNet?
It's hard for me to re-train all the models. Thanks.
Yuzhong.

Hi Yuzhong, the models are now available for download here.
At the time of the experiments, the pre-processing mean and variance were unnecessarily divided by 255 for ImageNet. Therefore, if you are using the models trained on ImageNet, make sure to use the following statistics in the data loading code:
mean = [x / 255. for x in [0.485, 0.456, 0.406]]
std = [x / 255. for x in [0.229, 0.224, 0.225]]

Note that this does not impact the validity of the results, because the affine transformation on the input is cancelled out by the first batch normalization layer. I will reproduce the experiments without this issue when I have more resources available.

thank you, Leonard!


Add cell index normalisation config

Please provide the following information:
What is this change about?
Introduction of a cell index normalisation mechanism to be used when diego.auctioneer.bin_pack_first_fit_weight > 0.
It could be enabled by setting diego.auctioneer.use_cell_index_normalisation to true. Index normalisation is decoupled from standard bin pack first fit distribution since it changes how the weight should be configured.
💡 Note - When cell index normalisation is used, in order to keep the distribution the same as before the old value of diego.auctioneer.bin_pack_first_fit_weight should be multiplied by number of zones.
What problem it is trying to solve?
The way bin pack first-fit app distribution is currently implemented causes a misbalance in regard to cell resource utilisation between AZs when:

there has been an upscale of the number of zones in BOSH
diego.auctioneer.bin_pack_first_fit_weight > 0.

This results in stability issues (e.g. if the more utilised zone fails due to IaaS issues it could cause a longer outage).
What is the impact if the change is not made?
There would be "silent" stability issues after a CF operator tries to upscale bosh availability zones while using a bin pack first-fit distribution.
How should this change be described in diego-release release notes?
Introduce new cell indexing concept
Please provide any contextual information.
All details, including a RC and an exact reproduction scenario could be found in diego-release issue 542.
Tag your pair, your PM, and/or team!
Just me -> Ivan Hristov
PM -> Plamen Doychev
CF-Runtime team at SAP.

Closing the PR as it was decided to remove the use_cell_index_normalisation feature flag and make it the default behaviour for whenever bin_pack_first_fit_weight is used.

Closing the PR as it was decided to remove the use_cell_index_normalisation feature flag and make it the default behaviour for whenever bin_pack_first_fit_weight is used.


FR: setting to skip backups if no activity since last backup

Because there is no bedrock macOS client, I am now running a Java server and a bedrock server (different seeds) for various family members and friends to play on.  This feature request (FR) was inspired by a feature I found in Java that I would like to see implemented in your service.
I would like to see a global service checkbox setting that allows you to optionally skip scheduled backups if there have been no players online since the last backup (i.e. no world changes).  You can still force a backup using the bedrock client.  What this would enable is for someone to set the scheduled backup to once an hour, and it would only perform backups while people are playing.  And when no one is on the server, it stops making backups (which in the current implementation would eventually all be the same data, and in effect would replace all the backups up to the backup max limit we set).

This is absolutely possible! Future plans (Should probably open a ticket for that) include the service keeping track of players that have connected, but not yet disconnected. Since I already track these times, its a small matter of getting to it. I can say that its a good reason to place that upward in priorities!

Actually, after having thought about this for a few minutes, we overlooked the core of the issue: changes to backups. All I have to do to achieve this is compare the latest backup files to the query first. If these files don't change in size, I (theoretically) should have no changes to the server, and thus no reason to create the backup. Because I already work with that string, its only a few lines away from achieving this. An optional checkbox can still be added.... Does anyone have a reason to disable this though? Sounds almost like a core feature that would be appreciated by all!

Since they are database files, they may be of a fixed size (size of chunks) and/or data values change but not the size (removal and placement of a different block in the same space).  So you would have to binary compare them which is probably not ideal.  You could sha256 checksum the files and compare them, but that too may be a little costly for large worlds.  I think in Java, the plug-in I am using (eBackup) does look at the player data to see if anyone is/was logged in since the last backup timestamp.  You do have to watch for someone that logged in before the last backup and is still logged in or logged out afterward, and still take a new backup.
I think a setting is still appropriate or people will say that the backup didn’t follow the schedule.  Some people may want to do backups every x hours regardless of change.
BTW - I am running a PaperMC Java server on Ubuntu Linux, not a vanilla mojang server.  It’s got most of the management built in or via plugins.  If you want to build something for the development experience, go for it.  But me personally, I probably would not manage it using this service, because there is too much customization that goes on in Java with various plugins.  The real need you fulfilled is running Bedrock servers on windows.

You could “/list when you perform the backup, and if anyone is on, flag that the next backup should be done regardless.  Otherwise look at all the last login time stamps, and if no one was on after the last backup was taken, then you can safely skip the backup.

@tiamat2012 , New development build is up with this feature up and running! Add the entryIgnoreInactiveBackups=true to your Globals.conf and replace the service. You should be good to go my friend!

@crowbarmaster I tested various scenarios and it all worked as expected!  Great job and quick turn-around.  Thanks!


PDF data not included in page.source

This may be related to some pdf-specific comments in https://github.com/teampoltergeist/poltergeist/issues/282
If you have a controller that returns pdf data via (via send_data in this case), e.g. in this contrived example:
  def pdf
    filepath = Rails.root.join('sample.pdf')
    data = File.open(filepath, 'rb') { |io| io.read }
    send_data data, filename: "sample.pdf", disposition: :inline, type: 'application/pdf'
  end

With capybara-webkit the page.source will contain the binary PDF data, with poltergeist page.source returns a minimal html document.
Note that it is not clear to me if this should be expected to work or not.  The closing of https://github.com/teampoltergeist/poltergeist/issues/299 indicates that the goal is HTML testing and not JSON (and I'd guess, not PDF either).  However, testing PDF content with capybara is fairly common so I can see the current implementation as a surprise to a lot of people (as it was to me).

This is not expected to work in poltergeist, only html is supported for page source


Implementing a Neural Network in Rust

Title: Implementing a Neural Network in Rust
Description:
Neural Networks are one of the most popular models in Machine Learning, and are the basis for a lot of popular AI applications, such as Computer Vision (CV), Natural Language Processing (NLP), and more. In this presentation, I show the math behind Neural Nets, how to train them, and how I implemented one in Rust from scratch to recognize digits in images.
The presentation is based on a post I wrote: https://vaktibabat.github.io/posts/Rust_WASM_Digit_Recognition_1/
Length:
40 minutes
On-line or in-person?
In-person
Date?
23/06/2024
Who are  you?
I am a third-year CS student at the Open University. Other than that, I am very interested in cybersecurity, reverse engineering, Malware Analysis, AI, and Rust (for about 6 months). I run a blog here.
Linkedin Account: https://www.linkedin.com/in/yoray-herzberg-b8155621b/
Thanks, Yoray Herzberg :)

@szabgab Are there any updates?

Sorry for the delay. This sounds good, but can you shorten the presentation to be about 20 minutes? It would be better to give 20 min now and 20 min at another time.

Hi, yes, I can shorten it to be 20min.

Excellent, so this will be one of the presentations.

Done on 2024.06.23 Thank you


[Question] Difference between WebUI backup & pivccu-backup

Thanks for the great work @alexreinert !
I got a quick question (as I'm currently working on an effective backup strategy for my environment).
I'd like to initiate a backup from a remote host. Since the WebUI has a backup functionality, I could use this to create the file. However I see that the pivccu-backup script does some significant work in order to generate the backup file. Is there any significant difference between the two methods - is one preferred over the other?

The resulting backup file is the same, but with pivccu-backup you can automate the backup process e.g. by cron.

looking into the resulting files, I can actually see some differences :)
pivccu-backup bundles the installed addons completely (I got hap-homematic installed), the CCU native backup only has empty folders. Additionally pivccu-backup has an empty eQ-3-Backup folder.
The rest seems to be equivalent :)
Thanks for the quick feedback!

If anyone is interessted in my script for getting the file off the API:
CCU_HOST="http://ccu.net"
TARGET="/home/ccu/"

if [ ! -d $TARGET ]; then
    mkdir -p $TARGET
fi

# Acquire session id
SESSION_ID=$(curl -Ls -o /dev/null -w %{url_effective} "${CCU_HOST}/pages/index.htm?client=3" | grep -oE @.*@)

if [ -z $SESSION_ID ]; then
    echo "Unable to acquire session id!"
    exit 1
fi

wget "${CCU_HOST}/config/cp_security.cgi?sid=${SESSION_ID}&action=create_backup" \
    -O ${TARGET}/ccu-backup-$(date -Iseconds).tar.gz

I assume, that where is now an issue in the native backup as we addons were included in the native backup, too.

hmm - is there a place to report this with eQ3?

They will deny any support request that is not using the original CCU3 image on original CCU3 hardware. And they deny any support request that includes 3rd party addons.

oh fun - are there first party add ons? it would be interesting to see if those are included in the backup on an 'official' CCU

Not that I know.


Advanced Commands

Instead of just 4 beat commands (X-X-X-X) there could be toggle for advanced commands that do the same thing but requires more notes (X-XXX-XX--X), though this would probably just be more work on the rhythm engine so ¯_(ツ)_/¯

The Rhythm Engine of PataNext does not have fixed length commands, so it's already implemented^^ (since the summon command need it)
The only problem is that commands of 3 beats (eg: Pata-Pata-Pon) aren't fully supported, while the rhythm engine accept and does that command, they may override or not be run at all if another command that start with the same pattern exist (and is 4 beat length or more)


Provider question

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[x] Support request
[ ] Other... Please describe:

Current behavior

Is this the correct approach to using angular-svg-icon-preloader if using provideAngularSvgIcon()? This is an Angular 18.2.2 application using bootstrapApplication()
provideAngularSvgIcon(),
importProvidersFrom(
  AngularSvgIconPreloaderModule.forRoot({
    configUrl: 'assets/svg-icons.json',
  })
),

Yes, this should be correct and it should work that way.


fix issue #71

Check recursively if any .md file exist in nested directories to avoid empty nav menu

Sorry I forgot the branch creation issue/71, if you prefer I can do the PR again with the right branch naming

This is great! Thank you!
I'm not at all picky about branch naming :)

For the record, it may be useful to apply recursivity in _nested_doc to list of path generated by glob('docs_dir/**/*.md') before the call to _nested_doc once and for all, instead of calling glob recursively. This way it would be possible to have an option "filter" for specific exclusion/inclusion with patterns that could be applied to the list before sending it to _nested_doc.


Switch to 0.x as default branch name

Currently, phinx uses master as the default branch name. To align with how other cakephp projects work where the default branch is the current version number, we want to switch this repo to use 0.x.

The master branch was renamed to 0.x.


Phoenix update

This PR updates phoenix to v0.18.0 and adjusts accounts and settings accordingly.

Updated the phoenix commit id for tests to solve failing webUI CI.


saved keras model with custom layers supports ragged inputs cannot be loaded back

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): linux
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): TF2.2 rc3
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the current behavior
I created a custom keras Layer that accepts ragged inputs:
class EmbeddingMean(tf.keras.layers.Layer):
  def __init__(self, **kwargs):
    super(EmbeddingMean, self).__init__()
    self._supports_ragged_inputs = True
  def call(self, inputs, **kwargs):
    return tf.reduce_mean(inputs, axis=1)

If i create a model like this:
feature = Input(shape=(None,), ragged=True, name='input_1', dtype=tf.int32)
embedded = Embedding(10, 3)(feature)
embedded_mean = EmbeddingMean()(embedded)
m = Model(feature, Dense(1)(embedded_mean))

And save the model as a keras model:
m.save('/tmp/test')
I cannot reload that model using
model_reloaded = tf.keras.models.load_model('/tmp/test')

ValueError: Layer embedding_mean_1 does not support RaggedTensors as input.

If i save the model as a saved model it works correctly but i loose all the keras features.
Describe the expected behavior
We should be able to load back the model as expected.
Standalone code to reproduce the issue
https://colab.research.google.com/gist/tanguycdls/c9b1026bbea22cca4018139f447f249c/untitled7.ipynb
Additional Informations
The issue seems to come from the fact that self._supports_ragged_inputs is not correctly saved: when we load the model the layer has the attribute set to False instead of True.

Was able to reproduce the issue with TF v2.1, TF v2.2.0-rc3 and TF-nightly. Please find the attached gist. Thanks!

Hey @amahendrakar-
We're going to be removing the supports_ragged_inputs attr. This change has been submitted internally and should show up in the nightlies as soon as it is sync'd.

This is fixed in latest tf-nightly commit, Layer._supports_ragged_inputs property is removed. Thanks!

Thanks @ymodak i checked and it works !
thank you for the prompt answer !


How to cancel the panGesture when have pushed into a viewcontroller?

I use [self.navigationController pushViewController:view animated:YES] to push a new ViewController.But it can accept the panGesture of the slideMenu.
when I use UINavigationController *navi = [[UINavigationController alloc] initWithRootViewController:advc];     [self presentViewController:navi animated:YES completion:nil];It can't be paned to slidemenu.
My question is how can I cancel the panGesture if I want use [self.navigationController pushViewController:view animated:YES]

You must import UIViewController+AMSlideMenu.h category and use following methods in viewWillAppear: method
- (void)disableSlidePanGestureForLeftMenu;
- (void)disableSlidePanGestureForRightMenu;
- (void)enableSlidePanGestureForLeftMenu;
- (void)enableSlidePanGestureForRightMenu;

@arturdev  lately I found this way.But it doesn't work for me. I'm working with IOS8 and I find an other iusse said that it doesn't work either.

Ok, I'll fix that for iOS8 asap

thx very much

Can you the below code
AMSlideMenuMainViewController *mainVC = [AMSlideMenuMainViewController getInstanceForVC:self];
mainVC.leftPanDisabled = TRUE;
mainVC.rightPanDisabled = TRUE;

Could you look into an issue that I am having, I can disable the pan gesture for a pushed VC, however  I have that VC push to another VC.  On the second VC I cannot disable the pan gesture no matter what I try.  The result is an unwanted pan gesture that pushes my view back to the first VC!
I am so mind boggled by this issue. I really love this API, but this last issue is causing havoc. Thanks for you help.

Import "UIViewController+AMSlideMenu.h"
And in - viewWillAppear: method do

(void)viewWillAppear:(BOOL)animated
{
[super viewWillAppear:animated];
self.mainSlideMenu.leftPanDisabled = YES;
self.mainSlideMenu.rightPanDisabled = YES;
}

On Sat, Aug 15, 2015 at 7:27 AM, gatewayboys<EMAIL_ADDRESS>wrote:

Could you look into an issue that I am having, I can disable the pan
gesture for a pushed VC, however I have that VC push to another VC. On the
second VC I cannot disable the pan gesture no matter what I try. The result
is an unwanted pan gesture that pushes my view back to the first VC!
I am so mind boggled by this issue. I really love this API, but this last
issue is causing havoc. Thanks for you help.
—
Reply to this email directly or view it on GitHub
https://github.com/SocialObjects-Software/AMSlideMenu/issues/135#issuecomment-131287253
.

but this only disable pan for menu, e.g. you can't open the menu via swipe,
only via menu button.
On Sat, Aug 15, 2015 at 11:10 AM, Artur Mkrtchyan<EMAIL_ADDRESS>wrote:

Import "UIViewController+AMSlideMenu.h"
And in - viewWillAppear: method do

(void)viewWillAppear:(BOOL)animated
{
[super viewWillAppear:animated];
self.mainSlideMenu.leftPanDisabled = YES;
self.mainSlideMenu.rightPanDisabled = YES;
}

On Sat, Aug 15, 2015 at 7:27 AM, gatewayboys<EMAIL_ADDRESS>wrote:

Could you look into an issue that I am having, I can disable the pan
gesture for a pushed VC, however I have that VC push to another VC. On the
second VC I cannot disable the pan gesture no matter what I try. The result
is an unwanted pan gesture that pushes my view back to the first VC!
I am so mind boggled by this issue. I really love this API, but this last
issue is causing havoc. Thanks for you help.
—
Reply to this email directly or view it on GitHub
https://github.com/SocialObjects-Software/AMSlideMenu/issues/135#issuecomment-131287253
.

see what happens is that when in the second view the pan triggers a slide over that pushes me back to the first view, it's triggered by an edge of screen ui gesture still can't disable it, again it works for the first view stopping the menu from appearing on the gesture, but still have the problem in the second view controller

So my apologies, the pan gesture was Apple's self.navigationController.interactivePopGestureRecognizer.enabled = NO;
I just thought it was the AMSlideMenu inside my second pushed VC.  Thx for your help, love this software.

This still doesn't work; Works for first view in navigation stack, but after a push the pan gesture is enabled again.

I had that problem, but solved it with this...if you haven't already tried it.
self.navigationController.interactivePopGestureRecognizer.enabled = NO;

Still not working...facing in the issue in nextview controller...do i have to write this code in every view controller of the navigation stack??

@hardikamal  Yes! You must write that code in every view controller (in -viewWillAppear: method) of that navigation stack.

@arturdev Its working at first and if you open and close alert or actionsheet the left pan start opening again on slide...ie viewwillappear method does not get called on alert popup close...i tried with viewdidappear but its same as view did appear....

@hardikamal Can you manually call that method again after closing actionsheet/alert ?

@arturdev ohhk cool

@arturdev is this fixed??


[Issue] AutomaticInventoryFixPlugin (the log u need me provided before)

LogOutput.txt
i still can't get any useful spiderfix mod log, but i did forgot to turn off "lesslog" mod, maybe nxt time

You might want to enable the debug log for the inventory fix to provide me with more information.
Also, set the log level to Verbose

ok

@Test-Account666 well i thought that will be hard to reproduce, but well here's the log
LogOutput.txt

3 items, only pill item saved, and after that the glitch will correctly fixed (include speed glitch)

That's just wonderful:

I'll have a look it it.
Thanks for the report

this issue still not fix in the newest version

@Test-Account666 a mention, this fix feature no longer work


Single go package

added Makefile in the root directory with version & docker build commands

/run in-cluster tests

/run in-cluster tests

/run in-cluster tests

/run in-cluster tests

/run in-cluster tests


[HOLD #27510][$500] Dev: Web - Selecting a workspace selects other (all) workspaces as well

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Start money request flow
Ensure you have multiple workspaces created
Upon selecting one workspace(for split)
Observe all workspaces are selected

Expected Result:
Only selected workspace should be selected
Actual Result:
All workspaces are selected
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: Dev 1.3.70-5
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/1c96a8dd-cc8e-402b-b028-6ac1cbb5c893
Expensify/Expensify Issue URL:
Issue reported by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694781139958309
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dd4d5419ef8224cd
Upwork Job ID:<PHONE_NUMBER>192711168
Last Price Increase: 2023-09-16

Proposal
Please re-state the problem that we are trying to solve in this issue.
Selecting a workspace selects other (all) workspaces as well
What is the root cause of that problem?
While calculating isSelected here -
https://github.com/Expensify/App/blob/76c1559fb3fbee1d07c8f210b522b63edd03920e/src/components/OptionsList/BaseOptionsList.js#L176-L186
We check for accountID only, as workspace chats/reports have accountID 0.
We are showing other workspaces as selected as well
What changes do you think we should make in order to solve the problem?

We have to add, reportID to participant as well.
https://github.com/Expensify/App/blob/76c1559fb3fbee1d07c8f210b522b63edd03920e/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js#L169
While calculating isSelected we need to check reportID as well if accountID is 0.
Following conditions shall be changed

if (option.accountID && option.accountID === item.accountID) return true
if (option.reportID && option.reportID === item.reportID) return true

What alternative solutions did you explore? (Optional)

This is a duplicate of https://github.com/Expensify/App/issues/27510.

Not a dupe, that's about showing workspace details and this one is about multiple workspaces being selected. Both have different RCA and solutions as well

Proposal
Please re-state the problem that we are trying to solve in this issue.
Selecting a workspace selects other (all) workspaces as well
What is the root cause of that problem?
Upon searching i found that value of isSelected is only based on accountID, as all workspace have accountId as 0 its causing the issue. Which results in selecting all the workspaces.
[App/src/components/OptionsList/BaseOptionsList.js]
 const isSelected = _.some(selectedOptions, (option) => {
     if (option.accountID === item.accountID) {
         return true;
     }

     if (_.isEmpty(option.name)) {
         return false;
     }

     return option.name === item.searchText;
 });

What changes do you think we should make in order to solve the problem?
Instead of searching with accountID we need to search with reportID only as reportID is different for everything.
We have to pass reportID here
[App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js]
Line: 169
newSelectedOptions = [...participants, {accountID: option.accountID, login: option.login, selected: true, reportID: option.reportID}];

and need to change this to
[App/src/components/OptionsList/BaseOptionsList.js]
const isSelected = _.some(selectedOptions, (option) => {
     if (option.reportID === item.reportID) {
         return true;
     }
     if (_.isEmpty(option.name)) {
         return false;
     }
     return option.name === item.searchText;
 });

What alternative solutions did you explore? (Optional)
N/A

@BhuvaneshPatil, do you know why, when you click split with a workspace, you get this blank account that shows up? I noticed in your screenvid and it shows for me too

@mallenexpensify This is known issue - https://github.com/Expensify/App/issues/27510

Thanks @BhuvaneshPatil , I was unable to reproduce, going to put this on hold pending

#27510

@mallenexpensify I think I mis-understood with what you have said.
To reproduce this issue we need more than 1 workspace.
When we select a workspace, notice is shows  check icon for all the workspaces

@mallenexpensify This is known issue - https://github.com/Expensify/App/issues/27510

I was mentioning about the workspace detail not showing in selected participant, that is the issue linked.
This one is about, multiple workspace showing check icon when we select on workspace

#27510

Above closed and I'm unable to reproduce this so I'm closing
@BhuvaneshPatil and/or @robertKozik , if you're able to repro, please comment.
https://github.com/Expensify/App/assets/22508304/12187bb5-25c2-4ade-90f8-7cae7b8498a1


md-ripple only enlargens the element it is applied to

Bug, feature request, or proposal:
Bug
What is the expected behavior?
A ripple effect is applied when the element is clicked
What is the current behavior?
The element simply gets bigger with each click
What are the steps to reproduce?
Apply the tags md-ripple [md-ripple-color]="rippleColor" to an element and click it.
Click the basic button in this plunkr:
http://plnkr.co/edit/LoliY4kSCD66HT5AHgrn?p=preview
Which versions of Angular, Material, OS, browsers are affected?
Angular 2.0.0, Material alpha 8-1, Chrome 53

To fix that weird issue:

With version < 9 include styles:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

From version aplha.9 include:

<EMAIL_ADDRESS>You can do that globbaly in your index file:
<link rel="stylesheet" type="text/css"<EMAIL_ADDRESS>or just use the styleUrls attribute in component decorator (don't forget about the encapsulation property (probably has to be set to ViewEncapsulation.None) in this case).

Sounds like this is caused by missing the core styles. See https://github.com/angular/material2/blob/master/docs/theming.md


eslint-import-resolver-webpack reserved alias of base?

Here's a weird one: If a webpack alias is named base it is ignored by eslint-import-resolver-webpack.
With the following configs:
// webpack.shared.config.js
// ...
resolve: {
    alias: {
      base: path.resolve(__dirname, PATH_SOURCE, '_patterns/00-base/'), // <-- see `base` here
      atoms: path.resolve(__dirname, PATH_SOURCE, '_patterns/01-atoms/'),
      molecules: path.resolve(__dirname, PATH_SOURCE, '_patterns/02-molecules/'),
      organisms: path.resolve(__dirname, PATH_SOURCE, '_patterns/03-organisms/'),
      templates: path.resolve(__dirname, PATH_SOURCE, '_patterns/04-templates/'),
      pages: path.resolve(__dirname, PATH_SOURCE, '_patterns/05-pages/'),
    },
  },

// .eslintrc.js
// ...
  settings: {
    'import/resolver': {
      webpack: {
        config: 'webpack.shared.config.js',
      }
    }
  }

And then implementations all around my code like:
// design-system.js
// ...
import * as base from 'base';
import * as alert from 'atoms/alert';
import * as card from 'molecules/card';
import * as article from 'organisms/article';

Will result in this eslint error for only base:
9:1  error  'base' should be listed in the project's dependencies. Run 'npm i -S base' to add it  import/no-extraneous-dependencies

However, if I change all instances of base to derp, then we're gold:
// webpack.shared.config.js
// ...
resolve: {
    alias: {
      derp: path.resolve(__dirname, PATH_SOURCE, '_patterns/00-base/'), // <-- see `derp` here
      atoms: path.resolve(__dirname, PATH_SOURCE, '_patterns/01-atoms/'),
      molecules: path.resolve(__dirname, PATH_SOURCE, '_patterns/02-molecules/'),
      organisms: path.resolve(__dirname, PATH_SOURCE, '_patterns/03-organisms/'),
      templates: path.resolve(__dirname, PATH_SOURCE, '_patterns/04-templates/'),
      pages: path.resolve(__dirname, PATH_SOURCE, '_patterns/05-pages/'),
    },
  },

// design-system.js
// ...
import * as derp from 'derp';
import * as alert from 'atoms/alert';
import * as card from 'molecules/card';
import * as article from 'organisms/article';

The above config works flawlessly with no eslint errors. So, TLDR:
Is base as reserved word to eslint?

Any chance you have a package named “base” installed locally?

I know this sounds crazy, but rolling back our version of Gulp to the pre-alpha.3 version makes this go away.  Closing!

Perhaps the bad version of gulp has a dependency named “base” that ends up in the top level of your node_modules?

That's exactly what I'm thinking as well, testing immediately. (Also, super thank for a quick response!) Will report back what we dig up.

(Typically webpack aliases are best when they can’t possibly be real package names)

@ljharb WINS ^^


⚠ Site ANTS has degraded performance

In b5a24e1, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 11270 ms

Resolved: Site ANTS performance has improved in 5555a94.


show en or fa locale in url after add {urlMappingStrategy: 'rewrite'} to middleware

a have a project with persian and english language.
i add below code to middleware file:
const I18nMiddleware = createI18nMiddleware(['en', 'fa'] as const, 'fa', {
urlMappingStrategy: 'rewrite',
})
after run project and after change language with switch component, en or fa show in url?

From what I've tested, it's not easily possible to push a new route with a new locale without showing it in the URL. Feel free to send a PR if you belive this shouldn't be the case!

From what I've tested, it's not easily possible to push a new route with a new locale without showing it in the URL. Feel free to send a PR if you belive this shouldn't be the case!

https://github.com/QuiiBz/next-international#rewrite-the-url-to-hide-the-locale
In this link, it is said that locale can be removed from the url.
I used the same code.
However, this code does not work correctly and cannot remove the locale?

This works when initially navigating to the website and switching pages, but not when changing the locale (as explained before, it's not easily doable)

@sajjadramezani73 feel free to re-open an issue if you believe this shouldn't be the case.


runbooks added

Runbooks added. Chart version also changed.

Summary
Runbooks have been added. Chart version was changed as the old ones was not anymore available I guess
Test Plan
Console UI displaying the runbooks
Checklist

[X]  No images hosted from dockerhub
[X]  Are dashboards present to understand the health of the application.  There must be at least 1 of these

[ ]  all databases should have dashboards
[ ]  ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
[ ]  you can use plural from-grafana to convert a grafana dashboard found via google to our CRD

[X]  Are scaling runbooks present

[ ]  all databases must have scaling runbooks
[ ]  you can use the charts in pluralsh/module-library to accelerate this

[ ]  do you need to add config overlays?

[ ]  inputing secrets
[ ]  configuring autoscaling

[ ]  If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
[ ]  All major clouds must be supported

[ ]  Azure
[X]  AWS
[ ]  GCP

I think there is an OIDC related issue that I'm looking for now.

I was working on ENG-856 today and I've just updated Dagster version. This is far more advanced so I will switch to some other app and assign the ticket to you @BogdanAntoniu78.

We also need to validate the resources that are being set before merging.


Why is the documentation gone?

There used to be a documentation site: https://danigb.github.io/tonal/api/index.html
Why is it gone?

Sorry, I'm finishing the 1.0 release, and the documentation will be at https://danigb.github.io/tonal (currently a proof of concept). Sorry for the inconveniences. I hope I can release the new version with the API documentation at the end of this week.

By the way, meanwhile you can read the markdown version: https://github.com/danigb/tonal/blob/master/docs/API.md

The documentation is back (updated to the 1.0 API) : http://danigb.github.io/tonal/api/


Broken version

I'm getting
 error : Version 2.1.302 of the .NET Core SDK requires at least version 15.3.0 of MSBuild. The current available version of MSBuild is <IP_ADDRESS>. Change the .NET Core SDK specified in global.json to an older version that requires the MSBuild version currently available.`

when trying to build .NET Core application with Mono version of MSBuild. That didn't happen with 15.6 which was properly reporting it's version.

https://jenkins.mono-project.com/view/Releases/job/ng-release-generate-debian-packages/1319/

https://jenkins.mono-project.com/view/Releases/job/ng-release-generate-rpm-packages/870/

Built. Promoting to stable/vs


Can you @group_by all columns but x,y,z?

More of a question than an issue, but is there a way to @group_by all columns but columns x,y,z? The equivalent in DataFrames would be something like DataFrames.groupby(df, DataFrames.Not([:x, :y, :z]).

Not yet but I think this is at least partially related to https://github.com/TidierOrg/TidierData.jl/issues/1. This is fixable.

The eventual syntax for this will be @group_by(-x, -y, -z).

Sorry it took so long!
This works now as of #104, with the following syntax: @group_by(df, -(x, y, z)) or @group_by(df, !(x, y, z))
Note that this syntax doesn't work: @group_by(df, -x, -y, -z). While it is supportable, it is trickier to implement because it translates to Cols(Not(:x), Not(:y), Not(:z)), which is very different than Not([:x, :y, :z]). I'm not planning to implement it for now but may revisit in the future.

Awesome, thanks for this!


English support for Sentence Parser

The Toposoid(01.0 version) only supports Japanese sentences. Therefore, I would like to support English sentences in the next release.
In the current Toposoid configuration, Sentence Parser is called as a microservice at the time of inference, so it is loosely coupled.
Sentence Parser is also used when registering the knowledge graph. However, the microservice is not called when registering the knowledge graph.This situation should be refactored into a structure that calls the Sentence Parser as a microservice when registering the knowledge graph as well as when inferring.
This makes it easier to support multiple languages!

Related Issue
https://github.com/toposoid/toposoid-common/issues/1   closed
https://github.com/toposoid/toposoid-component-dispatcher-web/issues/1  closed


PHPUnit 10 support?

Will this package have PHPUnit 10 support?
Seeing how PHPUnit 10 will only work with PHP 8.1 and above, not sure if that would clash with this package. And v10 is a pretty big rewrite from what I gathered.
I tried to test one lib that I'm contributing to on PHP 8.2 and got into dependency issues, where some packages required certain versions of PHPUnit, and I noticed that polyfills support PHPUnit up to v9.

@dingo-d 100% the intention. Prelim work for this has already been done and I have a local branch with some additional changes, which is waiting for a PHPUnit 10-RC before I pull it.
The only big challenge I currently see is the changes in/removal of the test listeners and I still need figure out if the Polyfills can continue to provide a cross-version compatible test listener implementation.
The tests for this package are also already being run against PHPUnit 10 and aside from the testlisteners, there are no incompatibilities at this time.
Note: the above statements are based on the premise of the Polyfills remaining unchanged, i.e. providing a forward-compatible layer. So functionality which is removed from PHPUnit without replacement will not be handled by the PHPUnit Polyfills.

I'm closing this issue as until there is a PHPUnit 10-RC release, there is nothing to be done here. All the same, I will pin this issue for visibility as I can imagine other people may have the same question in the near future.

@jrfnl as PHPUnit 10 is now stable, should this be re-opened ?

@stof Good point. I'll be working on this once I'm back from my break. Also see: https://phpc.social/@jrf_nl/109800368057494777

Any news on this?

@Stevemoretz I've just come back from my break. Working through my email backlog now. Working on this is my next priority after that.

@Stevemoretz I've just come back from my break. Working through my email backlog now. Working on this is my next priority after that.

Thanks for the update and the great work!

Everyone: I've opened an issue with the roadmap for the PHPUnit Polyfills version to support PHPUnit 10.0.
I'd appreciate it if you could have a read-through and would leave comments if there if there is anything in the roadmap which concerns you.

Closing as version 2.0.0 has been released.


Edge marker is not dynamically updated

Describe the Bug
Changing markerStart and markerEnd of an Edge dynamically but the marker is not updated.
Your Example Website or App
https://codesandbox.io/p/sandbox/hopeful-scott-xwsysm?file=%2FApp.js
Steps to Reproduce the Bug or Issue

Go to the https://codesandbox.io/p/sandbox/hopeful-scott-xwsysm?file=%2Fpackage.json
Click the "Allow" checkbox
Marker is not rendered
Drag a node
A marker appears

Expected behavior
Markers should be updated immediately.
Screenshots or Videos
https://github.com/xyflow/xyflow/assets/4065765/22e4b829-672e-43fe-9623-a23cbcd8743d
Platform

OS: Mac
Browser: Chrome
Version: 125.0.6422.61

Additional context
No response

Don't mutate objects in your setter function, that's where the issue comes from.
Replace this
if (edge.id === "e1-2") {
  edge.markerStart = markerStart;
}

with this
if (edge.id === "e1-2") {
  return {
    ...edge,
    markerStart,
  };
}

Here's your sandbox corrected.

Thanks, but that Sandbox still doesn't seem to work correctly.

The sandbox I linked seems to work completely fine. I open the sandbox, click the checkbox and see a red marker appearing without having to click/drag or do anything at all.

Is it possible that this is environmentally dependent? I am having problems in my environment described in the ticket.
https://github.com/xyflow/xyflow/assets/4065765/fa246ea7-722b-485b-b544-f708265ce491

Mh... what browser is that? Chrome?

Interesting, in Chrome it doesn't work but in FF it does 😄
Seems to be a bug somewhere, that's strange

Dynamically instantiated SVG elements don't work: https://issues.chromium.org/issues/40656725
svg may needs an appropriate namespace.
https://github.com/xyflow/xyflow/blob/467223b9a321f6af4555244de0990ea2b766cd0c/packages/react/src/container/EdgeRenderer/MarkerDefinitions.tsx#L68
It is worth trying this:
- <svg className="react-flow__marker">
+ <svg xmlns="http://www.w3.org/2000/svg" className="react-flow__marker">

There seem to be other svg's in the codebase with no namespace defined.

Interesting find!

I found a workaround. This works fine in Chrome:
https://codesandbox.io/p/sandbox/focused-morse-8wm7s5
Add a custom edge marker, and set it in thedefaultEdgeOptions:
<svg style={{ position: `absolute`, width: 0, height: 0 }}>
  <defs>
    <marker
      id="default-edge-marker"
      viewBox="0 0 0 0"
      markerHeight={0}
      markerWidth={0}
    ></marker>
  </defs>
</svg>
<ReactFlow
  defaultEdgeOptions={{
    markerStart: `default-edge-marker`,
    markerEnd: `default-edge-marker`,
  }}
/>

Awesome. How do you find this way out?

This is fixed in v12 and we won't fix it for v11. The namespace doesn't solve it unfortunately.

Fixed with React Flow 12! If you are using 11, you can find the migration guide here: https://reactflow.dev/learn/troubleshooting/migrate-to-v12


Adds outlines back into the home page buttons

It's true, but if nothing else the outlines stay consistent with the style of the rest of the app, which seems useful. Also, if we don't do that, then the buttons get that usual fuzzy blue outline. The last thing is that our button styles may change, though I hope it's always to something visible, so maybe that's not a big deal.


No Mail sending

Describe the bug
I configured the setting to get an alert via email, but when I achieve a hijacking I get no notification.
How can I debug this process?
Affected Component(s)

[x] Back-End (Database, Microservices, Containers, etc)
[x] Front-End (Flask, API, etc)
[ ] Docs
[ ] Build System

Expected behavior
I exact to get a email.
Additional context
I run Artemis in a local kubernetes instance.

Hello @sonnenteich ! We would need a snippet of the configuration you are using to help you debug. Could you share a sample file with the sensitive information (passwords, host info, etc.) filtered out? The dcumentation on this is here: https://bgpartemis.readthedocs.io/en/latest/loggingconf/
Typically the errors done by users in this context are:

Malformed yaml
Forgetting to attach their mail handler to the mail logger

It also may be sth k8s-specific with network connectivity, but let's rule out the other factors first.

Hey, @vkotronis thanks for your answer.
The mail part of my loggingconf looks like this:
# for email
smtps_handler:
    # artemis_utils.logaux.TLSSMTPHandler for TLS
    # artemis_utils.logaux.SSLSMTPHandler for SSL
    class: artemis_utils.logaux.TLSSMTPHandler
    level: INFO
    formatter: simple
    mailhost:
    - mail.host.com
    - 25
    fromaddr<EMAIL_ADDRESS>    toaddrs:
    -<EMAIL_ADDRESS>    -<EMAIL_ADDRESS>    subject: "Artemis BGP-HIJACK Warning"
    credentials:
    # - username
    # - pass
    secure: False

I have a further question, which services should be triggered to send an email, I cant see anything in the logs.

Hey, @vkotronis thanks for your answer. The mail part of my loggingconf looks like this:
# for email
smtps_handler:
    # artemis_utils.logaux.TLSSMTPHandler for TLS
    # artemis_utils.logaux.SSLSMTPHandler for SSL
    class: artemis_utils.logaux.TLSSMTPHandler
    level: INFO
    formatter: simple
    mailhost:
    - mail.host.com
    - 25
    fromaddr<EMAIL_ADDRESS>    toaddrs:
    -<EMAIL_ADDRESS>    -<EMAIL_ADDRESS>    subject: "Artemis BGP-HIJACK Warning"
    credentials:
    # - username
    # - pass
    secure: False

I have a further question, which services should be triggered to send an email, I cant see anything in the logs.

Do you see anything in the notifier logs, i.e., docker-compose logs -f notifier? Also have you attached the smtps_handler to the mail_logger? Regarding secure: False, have you tried secure: True (default)?
I have also pasted this and asked in the Slack channel, will post here with updates. In the meanwhile please check these questions and we follow-up.

Hey @vkotronis
I missed the mail_logger, I added the smtps_handler now it works fine.
Thanks a lot for your support.


Executor configuration accepts SessionState ..

... this way we can configure way more options
Which issue does this PR close?

Closes #1098.
Rationale for this change

expose session state to executor and scheduler, this way users can set up their own instances with custom configuration (object stores, configuration, udfs ...)
What changes are included in this PR?

Integration tests have been added which rely on testcontainers infrastructure, thus docker is required for builds. Tests are disabled by default but can be enabled with testcontainers option
BALLISTA_PLANNER_OVERRIDE config was removed, there is equivalent method in BallistaSessionConfigExt

Are there any user-facing changes?

there are slight changes in original API, but not drastic

SessionContextExt finally provides enough configuration options, getting one step closer to ballista library. I will follow up with documentation update reflecting new interface and removal of object stores.
please have a look when you get chance @andygrove

Thanks @andygrove, I need another pass to clean it up and put documention. Will let you know when ready

i believe this is ready now @andygrove
thanks for your patience


Add the "/ob" prefix to the all outbound apis

Need to distinguish the outbound apis with normal api.
Because the outbound is some kind of plug-in/extra module.
Add the "/ob" prefix to the all outbound apis.
as-is
/campaigns
/campaigns/<uuid>

to-be
/ob/campaigns
/ob/campaigns/<uuid>

Done.


chore(npm): sync package.json from npm-package-template

engines, version, release scripts for semantic-release, mocha, jsdoc and istanbul

[Current coverage][cc-pull] is 100%

Merging [#126][cc-pull] into [master][cc-base-branch] will increase coverage by +n/a%

@@           master   #126   diff @@
====================================
  Files           2      2
  Lines           8     22    +14
  Methods         0      1     +1
  Branches        0      0
====================================
+ Hits            8     22    +14
  Misses          0      0
  Partials        0      0

File .../step-passthrough.js (not in diff) was modified. more

Misses 0
Partials 0
Hits +14

Powered by Codecov. Last updated by c76a084
[cc-base-branch]: https://codecov.io/gh/Kronos-Integration/kronos-step-passthrough/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/Kronos-Integration/kronos-step-passthrough/pull/126?src=pr


feat: add k8s related files

This PR adds the necessary files to make this plugin compatible with k8s.

Thanks for the pull request, @Ian2012!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Thank you for your contribution! Please let us know when the changes are ready for review.


doc: add hipages to adopter list

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @estahn !


Fast forward to v1.18.1

Ran commands:
git remote add upstream git@github.com:prometheus-community/windows_exporter.git
git checkout -b pull-v1.18.1 v0.18.1
git remote add openshift git@github.com:openshift/prometheus-community-windows_exporter.git
git pull openshift master
go mod tidy
go mod vendor

@mansikulkarni96 I have merged the PR. One thing to keep in mind is that tags don't get updated. Should I manually update the tags?

@aravindhp that would be great, I will keep this in mind the next time I am opening PR to push tags along with the PR.


Solved issue when no internet connection available

Description
When entering on flight mode or no internet connection available when selecting a new location it crashes.
Related to issue #188
How has this been tested?
Manually
Screenshots
No screens

@CristianGM I'm not ignoring the issues. There are so many issues that might not be raised as issues IMHO. For example, there are so many MagicNumber warnings on the CountryLocaleRect, and in reality the correct way to solve it is to redesign the way we manage regions.


mtools: 4.0.38 -> 4.0.40

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mtools/versions.
meta.description for mtools is: "Utilities to access MS-DOS disks"
meta.homepage for mtools is: "https://www.gnu.org/software/mtools/"
meta.changelog for mtools is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.0.40 with grep in /nix/store/rhj5mjy90afrcq5ah03inxj0hriin0jy-mtools-4.0.40
found 4.0.40 in filename of file in /nix/store/rhj5mjy90afrcq5ah03inxj0hriin0jy-mtools-4.0.40

Rebuild report (if merged into master) (click to expand)

13 total rebuild path(s)

13 package rebuild(s)

First fifty rebuilds by attrpath
bootiso
fwanalyzer
fwup
gnome.gnome-boxes
gparted
ipxe
memtest86-efi
mtools
solo5
syslinux
unetbootin
wimlib
woeusb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rhj5mjy90afrcq5ah03inxj0hriin0jy-mtools-4.0.40 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mtools https://github.com/r-ryantm/nixpkgs/archive/37ad7e2f9849a3bd9558530cc9ae221526871245.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rhj5mjy90afrcq5ah03inxj0hriin0jy-mtools-4.0.40
ls -la /nix/store/rhj5mjy90afrcq5ah03inxj0hriin0jy-mtools-4.0.40/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

14 packages built:

bootiso
fwanalyzer
fwup
gnome.gnome-boxes
gparted
ipxe
memtest86-efi
mtools
ocamlPackages.ocaml-freestanding
solo5
syslinux
unetbootin
wimlib
woeusb

Maintainer pings

Result of nixpkgs-review pr 184354 run on x86_64-darwin 1

2 packages marked as broken and skipped:

bootiso
fwanalyzer

2 packages built:

mtools
wimlib


Event Series: update event card information

Update the event card on Event Series page to align with other event cards used on What's on.

[x] display date & time rather than date range #3150
[ ] display event status

@jamesgorrie The event card with multi-date doesn't seem to display past event status. It should display 'Past event' instead of 'See all dates/times'. Would you take a look at it while you are addressing this? Or let me know if you want me to create a separate ticket.


Clarify how to write news fragments and make fragments consistent

Description of change
This expands the changelog README and corrects some existing news fragment after agreeing on how they should be written.
Checklist

[x] Has a new newsfragment been created? Check changelog/README.rst for instructions
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Codecov Report

Merging #1084 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1084   +/-   ##
========================================
  Coverage    96.45%   96.45%
========================================
  Files          220      220
  Lines         6240     6240
  Branches       593      593
========================================
  Hits          6019     6019
  Misses         153      153
  Partials        68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6eee1e...2da10a5. Read the comment docs.


Move stdenvCross and customStdenv to pkgs/stdenv

Motivation for this change
Cleanup enabled by https://github.com/NixOS/nixpkgs/pull/19940. This too leads up to https://github.com/NixOS/nixpkgs/pull/15043. I pulled some more commits from #15043 so that now top-level/stdenv.nix hardly needs to exist.
Cross compiling still behaviors weird (I don't want to change semantics with this patch), but the weirdness is syntactically isolated from normal behavior: pkgs/stdenv/cross/default.nix won't be imported unless one is cross compiling and the weirdness is confined to there.
@zimbatm this should basically be what you reviewed originally, modulo identifier renaming.
Things done
I modified @DavidEGrayson's excellent test script at https://gist.github.com/Ericson2314/fc745290db68b20235bdc457961b3658 . It now just checks for all combinations with all combinations: native target, cross compiling, custom stdenvs, and custom stdenvs + cross compiling. You can replicate my results by running
nix-instantiate --eval -E 'import (builtins.fetchTarball https://gist.github.com/Ericson2314/fc745290db68b20235bdc457961b3658/archive/master.tar.gz) {}' -A testsPass

CC @nbp @DavidEGrayson

Besides my minor indentation complaint, it looks good to me.  You are basically cleaning up the arguments that are given to the top-level stdenv.nix and all-packages.nix.

@DavidEGrayson so while you definitely want to rebase on this, you probably also should rebase on top of #15043^ (i.e. all but the last commit, subsuming this), and furthermore also take a look at @vcunat's stdenv which I linked earlier. Lot of indirection there sorry :/.
To make all that less of a pain I rebased my bitrotted rebase of vcunat's stdenv on #15043^: https://github.com/Ericson2314/nixpkgs/tree/vcunat-cross-stdenv .  For context, @vcunat's original branch is https://github.com/vcunat/nixpkgs/tree/v/cross-native-rework .

I kind of like topLevelArguments, why would that be a mandatory change?

@nbp in the follow up PR they completely diverge https://github.com/NixOS/nixpkgs/pull/15043/files#diff-69df24a05ec3d577cb638113e9837ae1R49; during development (as 1 big PR) the ... just makes things harder.

I actually think topLevelArguments was misnamed since it contained things like lib that were not arguments to top-level/default.nix.  No that were are using @ args, that won't happen again.

I'm working on maybe moving some commits from the original (now followup) PR to this, to motivate (either way, i debug them so no loss). The @vcunat stuff may be needed just to get things working again, but that may swing things in the direction of leave this as is to not over-complicate with semantic change.

Ok, added more commits from the original PR because I believe I figured out how to preserve exact semantics, yay!

@DavidEGrayson thanks for your test script, it gives me much more confidence in this :). I still recommend looking at the my vcunat-cross-stdenv branch, but that branch will be rebased on #15043 in a moment so there's absolutely no reason to wait for that follow-up PR!

I'm glad you found it useful!

Do you have a moment for IRC?

@nbp this should be ready to go.

@nbp ok now this is actually ready to go! all the stdenv combinations have been tested. And yes...I did fine a bug in in stdenvCustom, so shame on me for not testing it before.

I suggest you rename this pull-request to “Move stdenvCross and customStdenv to pkgs/stdenv.”

@nbp Thanks! I will fix those things momentarily.

@nbp Ok fixed everything! I took part of your review message and also made it a comment. More explanation never hurts!


No doc of kube-proxy's healthz port in k8s.io/docs/concepts/architecture/control-plane-node-communication/

This is a Bug Report

Problem:
The section on Control Plane to node communication does not mention the use of the kube-proxy port 10256, which is normally reachable from everywhere.
Proposed Solution:
Explain why it is normally reachable from everywhere or change the default so that it is not and explain when and why it would be made reachable from everywhere or make it always reachable only from localhost.
Page to Update:
https://kubernetes.io/docs/concepts/architecture/control-plane-node-communication/

This might be considered part of #20666

/sig node

/language en

/priority important-longterm

/triage accepted


Is there a way I can suppress a bg command exception that happens after I wait()?

If I bg a command that throws an exception and eventually call wait() on it, is there a way to handle/suppress the exception that gets put in the queue? From this comment (https://github.com/amoffat/sh/blob/master/sh.py#L2278-L2284) and my experience, it seems like I can't. However, what this means is that when I do call wait on it, if I try to ignore the exception then the one in the queue still gets shown, and if I eventually want to raise or print the exception, it looks like it gets done twice (one that I handle and the one placed in the queue).
For example:
from __future__ import print_function
import sh

# This try block will still show the exception that I want to ignore
try:
    rc = sh.ls('asdfasdf', _bg=True)
    print('calling wait...')
    rc.wait()
except:
    print('no file')

# This try block will cause the exception to be shown twice
try:
    rc = sh.ls('asdfasdf', _bg=True)
    print('calling wait...')
    rc.wait()
except:
    raise

I saw https://github.com/amoffat/sh/blob/master/sh.py#L2055-L2062, but unless I'm using it wrong, it doesn't seem like I'm able to use that to swallow the exception before it automatically gets printed.
Ideally I'd like to be able to start the command with _bg=True and tell it not to show exceptions if they happen (because I plan to eventually call wait), but at a minimum I would expect that if I call wait and the exception hasn't happened that it act more similarly to as if I just ran the command without _bg=True.
Please let me know if there already exists a way to do what I'm trying to do. If not, would you be open to making the change or accepting a PR that does?

I believe I added bg_thread_exc for debugging the sh internal threads, so that's not something you can use.
I don't think sh can do want you want to right now.  Exceptions raised in a background RunningCommand are indeed uncaught, so it is correct to propagate them.  But I also understand that there is no way to catch them, even if you wanted to.  So I can see how it can be annoying to see an exception twice, if you are also calling .wait() later on.
I would merge a PR that added a new special keyword argument _bg_exc that defaults to True.  It looks like you could check for its value here https://github.com/amoffat/sh/blob/master/sh.py#L1987.  You can probably skip adding a test for the behavior, since we skip the entire branch that raises background exceptions anyways.  You'll also need a small PR for the docs on gh-pages branch to update http://amoffat.github.io/sh/sections/special_arguments.html with the new kwarg.