Creating a new card from card-drawer takes many seconds

And sometimes doesn't even show the new card (even though the URL updates)

It may be primarily a race. If the card update comes back from the database after the section updated, then the collection is updated and the card shows. If not, then the collection showing and the logical collection are different.
Perhap a missing COMMIT_PENDING_COLLECTION_MODIFICATIONS or something?

Perhaps it has something to do with createCard calling slugLegal (which might have very high latency, if the cloud function is cold)

When slugLegal is warm, it still shows "no card by that name" temporarily, because the 'none' filter gets injected in some how and is removed later

Consider warming up slugLegal often. If the user can see the create card button, if the card is open for editing, run it every 2 minutes.

[ ] we should only call keepSlugLegalWarm if the user has moved the mouse in the last N minutes

The logic is convoluted for updateCardSelector, etc. It's optimized for the first load, when we're still waiting for sections to load. But when navigateTo is called, updateCards and updateSections haven't yet been called with the  new card and new section, but data is loaded, so it gets in a weird state temporarily where it has the 'none' filter.

Tried having an EXPECT_NEW_CARD action that is triggered that unsets sectionsLoaded, unpublishedCardsLoaded. It's a bit better (it doesn't say 'that card doesn't exist') but there's still a flash as the collection goes away and the card says 'Loading...'.
Ideally the card drawer would fade out (as it does when reordering) but stay the same until the card shows up.

The only two things left are the minor two unchecked items


fine tune upon your pertained weight

Thank you for your impressive work! I am particularly interested in building upon your pre-trained weights, which integrate LLM and LoRA. Could you kindly provide a tutorial or guidance on how to perform further fine-tuning using these weights?

Hi @NyKxo1
We’re currently working hard to integrate more lightweight LLMs this month, and the stronger models will be ready for release next month. Just hang tight and be patient. We’ll also be providing detailed fine-tuned tutorials as soon as they’re ready, and we’ll let you know right away. Stay tuned!


[Feature Request] Use candy to Power UP.

Hello
I just see on webpage there is "Use Candy" Features complete - how i can use this?
I want to use Candy to Power UP my Pokemons with the best iv.
So if i got 5 pokemons with iv:
0.7
0.4
0.6
0.8
0.9
I want to use my Candys and Dusts to"Power UP" Pokemons in this order: 0.9 > 0.8 > 0.7 >0.6 >0.4
Best Regards
TaKeN

use optimizer task

What Your mean? How to use this?

https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/docs/pokemon_optimizer.md


Use PHP-CS-Fixer as a formatter

Current coverage is 87.70% (diff: 82.25%)

Merging #32 into master will decrease coverage by 2.24%

@@             master        #32   diff @@
==========================================
  Files            14         16     +2
  Lines           189        244    +55
  Methods          30         37     +7
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            170        214    +44
- Misses           19         30    +11
  Partials          0          0

Diff Coverage
File Path

•••••••    71%
src/Server/TextDocument.php

•••••••    77%
new src/Server/CustomCSFixer.php

•••••••••  95%
new src/Server/Formatter.php

Powered by Codecov. Last update 8170562...11516fb

Code Sniffer formatter looks to be better choice in my opinion.


No way to customize manim's LaTeX package

Describe the bug
I find no easy way to customize the LaTeX package used by manim. As a result, I cannot use packages like mathtools since only very few packages are included by default:
https://github.com/NixOS/nixpkgs/blob/62730f2c3107f2f9e4684f05236ea9dc8066568d/pkgs/applications/video/manim/default.nix#L126-L131
Steps To Reproduce
Steps to reproduce the behavior:

nix-shell -p manim
Create a file test.py containing:

from manim import *

template = TexTemplate(preamble=r'\usepackage{mathtools}')

class Intro(Scene):
    def construct(self):

        termsTitle = Tex(r"a \coloneqq b", tex_template=template)
        self.play(FadeIn(termsTitle.to_edge(UP)))
        self.wait()

Run manim -pql test.py Intro and observe "LaTeX Error: File `mathtools.sty' not found.".

Expected behavior
I would like to be able to use my custom LaTeX distribution, like texlive.combined.scheme-full.
Notify maintainers
@friedelino

This should be easier since 23.11: you can override manim's texliveInfraOnly attribute to include more packages, for instance
manim.overrideAttrs { texliveInfraOnly = texliveInfraOnly.withPackages (ps: [ ps.mathtools ]); }

If that's enough for what you need @tobiasBora please close the issue.
I think the better alternative is to remove texlive from the wrapper altogether, but that's something that requires discussion with the maintainers and it would be a breaking change for some people.

Great, thanks a lot, this seems good enough for my need. And I guess I can specify texliveInfraOnly =  texlive.combined.scheme-full; if I don't want to worry about installed packages.


sanitizeURIComponents: add sanitizer when extracting data from URI

the data extracted specifically from the URI is not being sanitized.
for example, if we have route template/:id, user can insert anything for the :id portion and it won't be sanitized. so if the user sends the this request, /api/1.0/template/%22%3E%3Cscript%3Ealert%28%22XSS%22%29%3C%2Fscript%3E, the :id portion of the URI will be decoded into /\"><script>alert(\"XSS\")< and it wont be sanitized
Solution: add forked sanitizer library in i-sight and utilize it when extracting data from the URI

@literallynotjesus OWASP guidelines suggest escaping on serverside: https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html
quote: "Both reflected and stored XSS can be addressed by performing the appropriate validation and escaping on the server-side. "
mind going into detail of how the configuration import ties into bypassing sanitization on the URI?
also not sure what an FTP integration is :P

Here's a general example where I bypass server-side escaping through the configuration import: https://i-sight.atlassian.net/browse/ITPL-14306.
An FTP integration often runs weekly / daily to import profile records (for example). Since you have an import loading a csv file instead of calling the http endpoint, the sanitization here would be ignored.

I think generally OWASP recommends everything :P But usually it's generally considered a better strategy to simply not evaluate the script on the front end rather than try to escape.
I think the idea with bypassing is that you can create problematic IDs by inserting records through means separately from the API and then they will still execute on the front end.


Fixes setStyle to handle undefined style variable

Fixes the following error:
TypeError: Cannot read property 'hasOwnProperty' of undefined
    at NewClass.setStyle (leaflet-src.js?9eb7:7853)
    at NewClass.removeHooks (leaflet.draw.js?18c5:8)
    at eval (leaflet.draw.js?18c5:8)
    at NewClass._eachVertexHandler (leaflet.draw.js?18c5:8)
    at NewClass.removeHooks (leaflet.draw.js?18c5:8)
    at NewClass.eval (leaflet.draw.js?18c5:8)
    at NewClass.fire (leaflet-src.js?9eb7:593)
    at NewClass.removeLayer (leaflet-src.js?9eb7:6681)
    at NewClass.removeLayer (leaflet-src.js?9eb7:6823)
    at NewClass.removeLayer (leaflet-src.js?9eb7:6969)

Not entirely sure about this. L.Path.setStyle() expects an non-optional Object, and it seems that there is something else (in Leaflet.Draw?) that calls setStyle(undefined). Personally I'd rather see the fix on the Leaflet.Draw part.
Can you publish a fiddle/codepen/plunkr that displays the buggy behaviour?

Thank you for your comment Ivan, I investigated where this issue came from in Leaflet.draw and opened the following pull-request: https://github.com/Leaflet/Leaflet.draw/pull/952


Make page non-responsive

Better to just create a mobile page that is responsive.

It's possible... but the nav can't be made non-responsive, along with the form artifacts. Better to just leave as is.


Migrated to Swift 5

Migrated to Swift 5

Any news on this?

Really sad to see a library like RichEditorView abandoned :(

FYI, this migration to Swift 5 is (at least in our iOS project) mandatory for Xcode 14.3


Update site-design-rest-api.md

Including two site design endpoints missing from documentation. Endpoints include GetSiteDesignRun and GetSiteDesignStatusAndSchema for managing site designs.
Category

[x] Content fix

What's in this Pull Request?
Two endpoints missing from documentation. GetSiteDesignRun and GetSiteDesignStatusAndSchema

It's actually slightly more complicated than that. It might be that they are not documented as planned as if they are documented, they are also supported for 3rd party... which is not necessarily the case. Let me loop in internally the feature crew to agree if we document or not there. Will be back later.

Thanks for the feedback Vesa

I get that... reality is that if something is in the PowerShell cmdlet, it does not mean that it's supported to be called outside of it, which does not help with the setup.

Closing for now as we have not been able to get confirmation on these being supported from the feature crew. No can do.


Modifying existing subscription throttling policies doesn't work as expected

Description:
When we modify an existing subscription throttling policy, it get disappeared from the policy selector view in Dev portal.
Steps to reproduce:

Modify an existing throttling policy(I changed silver to 500)
Create an API and add the policies under business plans

Navigate to dev portal and try to subscribe to above created API
Edited policy wont be visible in the selection

Affected Product Version:
APIM 4.0.0
Environment details (with versions):

OS:Mac/Safari

Did you add any permissions when updating the policy? Seems not reproducible when I added "Internal/everyone"

I also added Internal/everyone and got this behaviour
On Tue, Mar 30, 2021 at 11:02 PM Malintha Amarasinghe <
@.***> wrote:

Did you add any permissions when updating the policy? Seems not
reproducible when I added "Internal/everyone"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wso2/product-apim/issues/10572#issuecomment-810445282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMMLLREAHQRVO7MOZDI7XTTGIDMNANCNFSM42BLEWBA
.

--
Regards,
Tishan


Import existing undo/redo history when initializing the Undoo instance

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Not possible to preload an existing history. History gets lost during page refresh and there is no way around that.
Issue Number:

https://github.com/reaviz/reaflow/issues/41

What is the new behavior?
Added an option initialHistory as UndoProps to preload an initial history when initializing the undoo instance.
Allows preserving the undo/redo history (e.g: local storage) and reload it even when the history gets lost (e.g: page refresh).
Also, added tests using @testing-library for the useUndo hook. 🎉
And added Storybook story for useUndo examples.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
I first refactored the Undo.stories.tsx by using a Storybook "Template" component, but I noticed it was harder to understand the documentation when doing so.
So, I changed it back in https://github.com/UnlyEd/reaflow/commit/72d1ddc972533cf986b048c1ec3ca46b49d60711
See https://github.com/storybookjs/storybook/issues/13657#issuecomment-785768770 for in-depth explanation.
I don't personally like duplicating all that code, but I noticed that's what has been done so far in other stories, and I believe the point of having Storybook is to favour documentation quality and understanding rather than code reusability.

@amcdnl PR ready, please review ;)

Made some improvements/changes. Ready to be merged IMHO.

@amcdnl Could you have a look at this?
If you can't fix it, I suppose we should extract the new feature from the test and make another PR with the tests only, so we can merge it and increase tests coverage. (and have the feature in another PR)


Show the Days of the Week and Link to Weather page for the grounds

The day of the week will be helpful as it is easier to understand how it falls with your own schedule.
Link to the weather page for the cities  where the ground is will be useful.
http://www.weatherzone.com.au
and
http://www.weatherzone.co.nz
are useful sites

Hi pt321, thanks for your input. Since we wanted to keep the page clean and add only important information, this might just add a bit of excess information.
Thanks for your suggestions though. A lot of such suggestions have helped us create the site better.


global: same asset should not be loaded twice

There is an issue with loading assets multiple times. For example, if two templates load invenio_search_js, this will cause an error to be raised since the Angular app will be loaded twice. Assets should rather collect the requirements and then add them only once to the output.
We discussed with @jirikuncar the possbile solutions to this. There are two approaches at least. One is to make a better Bundle class that will check if the asset has already been declared and not give out the same asset twice. Other option would be to modify the assets extensions and handle the problem there.
Relevant line in the assets extension:
https://github.com/miracle2k/webassets/blob/master/src/webassets/ext/jinja2.py#L191

Superseded by #69


.NET Framework 4.0 support

Hi, PureKrome
Do you have any plan to support .NET Framework 4.0? I want to use NLog.Bugsnag but my project is based on .NET Framework 4.0 for Windows XP support.
Thanks,
csjune

Nope - not really. Mainly because async/await is not baked into .NET 4.0. With 4.0 I'll need to add an extra nuget package Microsoft.Bcl.Async/ which suddenly makes the project a lot more work.
I'm happy to review any PR's for this, but as for ~me~ spending cycles on it - nope.
My condolences for having to work with Windows XP still.


Accessible view aria label repeated when there's dynamic terminal output, windows only

@jooyoungseo reported that when there's dynamic terminal output, on Windows, and the accessible view is open, the aria label is read as the content is updated.
I tested and could not repro on macOS.

could set aria label to nothing on windows and alert on initial open


Add ExcludeModule parameter to Get-Command

PR Summary
Adds the ExcludeModule parameter to Get-Command so you can exclude commands from specified modules like this: Get-Command *disk* -ExcludeModule Storage.

PR Context
The main purpose is to contribute towards: https://github.com/PowerShell/PowerShell/issues/16747 but like the previous example shows it can also be useful when manually searching for commands.

PR Checklist

[X] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[X] Summarized changes
[X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[X] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[X] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[X] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[X] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[X] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

The parameter name should be ExcludeModule to match existing cmdlets that use Exclude not Excluded.

Queued this up for the WG-Cmdlets to discuss

The Cmdlet WG reviewed this and agree with adding this parameter to Get-Command.  We're not making any statement on the quality of this PR.

What is the status of this PR?

Hi all. What is the status of this PR?

Hi all again. Just following up. What is the status of this PR?

Sorry to ask again, but what is the status of this PR @iSazonov and @daxian-dbw?

@alanlivio Good news, according to the PS team blogpost: https://devblogs.microsoft.com/powershell/powershell-and-openssh-team-investments-for-2024/ one of the goals for 2024 is to focus on getting community PRs merged. Obviously they haven't started doing that yet, but it would be very weird if they didn't start within the next couple of weeks after making a blog post like that.

Good news. I hope that they can merge your PR soon.

This was approved but not merged. Are we waiting for an official 7.5 release before merging or what's the idea here?

Gonna close and reopen to get CI going, once it passes I'll get it merged

@SeeminglyScience The PR is too old - I suggest to rebase before merge.

I am looking forward to seeing this merged.


Background color is not reset after exiting flow

This sequence of operations leaves the flow background color in my shell after exiting flow:

Start a new tab in Windows terminal
SSH into a Linux machine, start flow.  Flow sets the background color to gray.
Exit flow.  Background is still gray and not black as it was originally.

The Linux machine I ssh'd into is running Ubuntu 22.

Yes, unfortunately Windows Terminal does not support resetting the terminal color scheme. Set enable_terminal_color_scheme to false in your flow config to disable this feature of flow.


Make the "TODO" patterns configurable

Allows to modify the patterns and have multiple

Looks good, but the default pattern is not the same as shown in the docs:
+      self.patterns = { "TODO[:;]", "FIXME[:;]" }
+  patterns = { "TODO[%s:;]", "FIXME[%s:;]" },

Is it intentional?

you mean the comment at the bottom? yes, intential, why would a user change them otherwise?

I got that, but I was thinking that you may want TODO[%s:;] by default, so TODO something also works, but it's your choice ;).

fine as it is imo.

Merged; thanks for the patch!


"Uncaught RangeError: Maximum call stack size exceeded": deepEqual chokes on props.children

In 6.0.0-alpha.7,  when using the new <Field> element, I've been encountering a strange error when trying to compose elements that accept children props and passing them their children via the <Field> component.
Here is the most reduced working example I could get:
import React, { Component } from "react";
import { reduxForm, Field } from "redux-form/immutable";

export default class InnerComponent extends Component {
  render() {
    return (

        Something

    );
  }
}

export default class CustomField extends Component {
  render() {
    return (

 this.props.onChange(true)}>
        {this.props.children}

    );
  }
}

@reduxForm({
  form: "event",
})
export default class EventForm extends Component {
  render() {
    return (
      <Field
        name="customField"
        component={CustomField}>
          <InnerComponent/>
      </Field>
    );
  }
}

In a nutshell, CustomField will render anything that's passed as children to it. It has a simple onClick handler to trigger the onChange callback passed by redux-form, which sets the whole issue in motion.
InnerComponent is passed as a child. In my experiments, this issue does not happen when you pass just text inside <Field>.
From what I was able to figure out, the following file is at the root of the stack overflow: https://github.com/erikras/redux-form/blob/v6/src/ConnectedField.js#L19
What it does is it performs a deep comparison between the previous props and the next props of <ConnectedField/>, which is in-between <Field>, <CustomField> and <InnerComponent>.

<ConnectedField/>'s props.children is an InnerComponent element. The deep comparison moves on to InnerComponent's _owner (private React property), which in this case is the top-level EventForm component.
From that point, it's extremely easy to identify a circular reference, as you would only have to follow the props.children chain back down to find InnerComponent in order to close the loop.
When this happens, the component fails to update.
Potential solutions that I can think of:

Explicitly skip comparing the children property in the props object. Potential drawback: the component won't be able to tell when props changed. Potential workaround: only perform a shallow comparison of children objects.
Do not consider underscore-prepended properties in the deep comparison. Potential drawback: very opinionated approach and may interfere with things that are not related to React.
Impose a hard limit on the depth of the comparison that won't be exceeded. If everything matches up to that point, the objects are considered equal. Potential drawback: the circular reference may start at any point in the chain, even in shallow areas, which would moot this check.

I also attempted to pass the whole structure directly through the component prop:
import React, { Component } from "react";
import { reduxForm, Field } from "redux-form/immutable";

export default class InnerComponent extends Component {
  render() {
    return (

        Something

    );
  }
}

export default class CustomField extends Component {
  render() {
    return (

 this.props.onChange(true)}>
        {this.props.children}

    );
  }
}

@reduxForm({
  form: "event",
})
export default class EventForm extends Component {
  render() {
    return (
      <Field
        name="customField"
        component={props => <CustomField><InnerComponent/></CustomField>}>

      </Field>
    );
  }
}

In this case, I get the following error:
ReactCompositeComponent.js:154 Uncaught TypeError: Can't add property context, object is not extensible.
I did not investigate down this path further, as it seems like my initial attempt is more in line with the intended use of this API.
Secondary details:

I'm using React 0.13 and Babel 5

deepEqual needs to be rewritten. Thats on the soon-to-do list.
You're not using redux-form/immutable, right?

I'm using the immutable flavour, yes. Also sorry, I just realised by seeing your reply that I accidentally submitted this before finishing it. I'm preparing a much more detailed write up of my findings. Please check back in a bit.

I just updated this issue with a much more detailed write-up. Please let me know if this is any more helpful.
As this is a really stringent issue for me, I'd love to contribute a solution, but I'm not sure where to start. If you have an idea on how you would rewrite deepEqual to prevent this from happening, I would love to implement it if you share your thoughts with me.
Also, do you have more information about in which way the immutable version of deepEqual fails and what the difference would be between it and the vanilla JS version?

I removed the dependency from CustomField in my first example by reducing it to simply use a <button>. This should bring even more clarity to help solve the issue:
import React, { Component } from "react";
import { reduxForm, Field } from "redux-form/immutable";

export default class InnerComponent extends Component {
  render() {
    return (

        Something

    );
  }
}

@reduxForm({
  form: "event",
})
export default class EventForm extends Component {
  render() {
    return (
      <Field
        name="something"
        component="button">
          <InnerComponent/>
      </Field>
    );
  }
}

☝ The code in your previous comment is all that it takes to cause the stack overflow? Just clarifying.

Indeed, that seems to be the case on my end. Please give it a spin on your end as well if you get a chance.

I meant the "plain" deepEqual needs a rewrite. I'm not going to have time to look into this today.
If you want to get started fixing it, should see if you can recreate it in deepEqual.spec.js, and then repair deepEqual.js to avoid the overflow.

No worries, didn't mean to rush you. I'll look into how other libraries deal with cyclical objects. In case you have any idea for a strategy to prevent the overflow, I'd love to hear it.

@erikras what are your considerations on adding a dependency on lodash? As I understand redux-form does not seem to depend on it, maybe for leanness reasons, however it seems like it might be a favourable choice. redux already depends on it, so any user of redux-form will be pulling in lodash anyway.
I believe lodash has a much more tried-and-true (and efficient) approach to object comparison, so it might be a great choice. For time-sensitivity reasons I am forking redux-form and replacing deepEqual with lodash.isEqual, until there's an official solution.
If you're interested in pushing this through, I can open a PR with this change.

I would like to avoid lodash if possible, for the reasons discussed in #859.

I see. Here is my attempt at implementing the fix with lodash. The tests are green. It's fine if you don't consider it mergeable though. For now I just need something that's stable. If there's more time I will go back and have a stab at removing lodash, but otherwise I'll just depend on this until there's an official solution.
Thanks for your help so far!

Doh! 🙈 Can you PR this, @gabrielecirulli?

Here you go: #929

Published as v6.0.0-alpha.8.


Cannot read property path

During npm start.
I get:
..../node_modules/express-oas-generator/index.js:44
      let path = prefix + route.route.path;
                                      ^

TypeError: Cannot read property 'path' of undefined
    at stack.forEach.route (..../node_modules/express-oas-generator/index.js:44:39)
    at Array.forEach (<anonymous>)
    at app._router.stack.forEach.router (..../node_modules/express-oas-generator/index.js:42:11)
    at Array.forEach (<anonymous>)
    at init (..../node_modules/express-oas-generator/index.js:34:21)
    at Timeout.setTimeout [as _onTimeout] (..../node_modules/express-oas-generator/index.js:162:5)
    at ontimeout (timers.js:458:11)
    at tryOnTimeout (timers.js:296:5)
    at Timer.listOnTimeout (timers.js:259:5)

Could you please elaborate a bit more on how you initialize express app and routers in it so I can fix the module?

Sure.
File app.js:
var express = require('express')
var apiRouter = express.Router()
var index = require('./routes/index')
var user = require('./routes/user')

var app = express()

// API routes
apiRouter.get('/', index)
apiRouter.use('/users', user)

app.use('/', index)
app.use('/api/v1', apiRouter)

Example of index.js file:
var express = require('express')
var router = express.Router()

router.get('/', function (req, res, next) {
  res.status(200).json({'status': 200, 'response': {'message': 'Test string'}})
})

module.exports = router

Similar get, post, put & delete methods are attached to the user.js file.

Tried to reproduce the problem in develop branch (see https://github.com/mpashkovskiy/express-oas-generator/blob/develop/issue_1.js) but with no luck. Did I configure something wrong?
Which version of module do you use? I'm trying it with is 0.1.12
Also I added extra check so could you please try with 0.1.13?

I suppose problem is solved, so closing the issue.


Publishing library that uses Apollo Kotlin 4.0.0 to maven repo requires declaring explicit dependency on certain Gradle task

Version
4.0.0
Summary
Our library project includes Apollo Kotlin. We use maven-publish plugin for publishing the library .aar file. After migrating from v3.8.2 to v4.0.0, we started seeing error when attempting to publish our library .aar artifact. It seems that task mylibrary:sourceReleaseJar has to depend on :mylibrary:generateMylibrarysvcApolloSources task
To fix the issue,  i added the following code in afterEvaluate {} in the myLibrary/build.gradle.kts:
afterEvaluate {
    val apolloSrcTask = project.tasks.getByName(“generateMylibrarysvcApolloSources”)
    val srcReleaseTask = project.tasks.getByName("sourceReleaseJar")
    srcReleaseTask.dependsOn(apolloSrcTask)
}

Is there some configuration setting  in Apollo Gradle Plugin  that will fix this issue?
Steps to reproduce the behavior
dependencies {

    // @Keep annotation
    implementation(libs.androidx.annotation)

    // Coroutines
    implementation(libs.kotlinx.coroutines.core)
    implementation(libs.kotlinx.coroutines.android)
    testImplementation(libs.kotlinx.coroutines.test)

    // Apollo core runtime dependencies
    implementation(libs.apollo.kotlin.runtime)
...
}

apollo {
    service("Mylibrarysvc) {
        // apollo compiler by default will generate Kotlin models from queries, mutations etc
        packageName.set("mylibrary")
        // Keep schemaFile
        schemaFile.set(file("mylibraryFilepath"))
        // explicitly set srcDir
        srcDir(file("graphqlFilesFilepath"))
}
}

here is publishing section in mylibrary/build.gradle.kts
publishing {
    publications {
        register<MavenPublication>(ARTIFACT_NAME) {
            groupId = ARTIFACT_PACKAGE
            artifactId = ARTIFACT_NAME
            version = getPublishingVersion(ARTIFACT_VERSION)

            // Library documentation created with Dokka
            artifact(dokkaDocsJarTask)

            // Note that when running the Maven Publish Plugin with AGP,
            // the software components are not created directly when the plugin is applied.
            // They are instead created during the afterEvaluate() callback step.
            // Therefore, the publication that selects the software component
            // must also be configured during the afterEvaluate() step.
            afterEvaluate {
                from(components["release"])
            }
        }
    }

    repositories {

        mavenLocal()
    }
}

run  myLibrary/publishToMavenLocal task in Android Studio
Logs
FAILURE: Build failed with an exception.

What went wrong:
A problem was found with the configuration of task ‘:mylibrary:sourceReleaseJar' (type 'SourceJarTask').

Gradle detected a problem with the following location: '/Users/Myself/mylibrary/build/generated/source/apollo/mylibrarysvc'.
Reason: Task ':mylibrary:sourceReleaseJar' uses this output of task ':mylibrary:generateMylibrarysvcApolloSources' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
Possible solutions:

Declare task ':mylibrary:generateMylibrarysvcApolloSources' as an input of ':mylibrary:sourceReleaseJar'.
Declare an explicit dependency on ':mylibrary:generatemylibrarysvcApolloSources' from ':mylibrary:sourceReleaseJar' using Task#dependsOn.
Declare an explicit dependency on ':mylibrary:generatemylibrarysvcApolloSources' from ':mylibrary:sourceReleaseJar' using Task#mustRunAfter.

For more information, please refer to https://docs.gradle.org/8.2/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

Hi 👋 I'm guessing you're using something like so to configure the android publication?
android {
  publishing {
    singleVariant("release") {
        withSourcesJar()
    }
  }
}

The generated sources are registered using srcDir() and I would have expected that to carry task dependencies but maybe there's more to it. I'll take a deeper look. In the meantime your workaround should work fine.

Yes. that's how we configured the android publication. Thank you

@seab4ss fix is here. There's a surprising amount of context and backstory but I think/hope it's good. If you get a chance to try it out in the SNAPSHOTs, let me know how it goes (should land in the SNAPSHOTs once merged and deployed, hopefully today).

(PR merged, SNAPSHOTs are deploying here)

@martinbonnin this issue is fixed in Apollo Kotlin v4.0.1. Thank you!

Glad to hear that! Thanks for the follow up!


move the default position of the require comment to the top.

I just fell into the catch described by kareemamin here https://github.com/modeset/teaspoon/issues/301.
I looked for error elsewhere in my code for way to long, not realizing the require position was the problem. So here is a PR.

Coverage remained the same at 99.54% when pulling 937487953f5cdeb8f44609c5a5ba09098ca49e0e on igwan:fix-require-application-comment-position into 84441c8ba42488ffe47b7e99833c38c3c8f71449 on modeset:master.

Thanks, but please adjust this to only shift the application require to not be above any dependency loads.. you've put it above the bind-poly in some cases, and it should not be above any other dependency.

Coverage remained the same at 99.54% when pulling 033bd0f2576d1171a623bbb85c603e0527b6edca on igwan:fix-require-application-comment-position into 84441c8ba42488ffe47b7e99833c38c3c8f71449 on modeset:master.


Tile flicker on tilelayers when zooming past maxNativeZoom

[x ] I've looked at the documentation to make sure the behavior is documented and expected
[ x] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[ x] I've searched through the issues to make sure it's not yet reported

Steps to reproduce
Steps to reproduce the behavior:

Add at least 1 layer with the maxZoom and maxNativeZoom defined.  Add the option maxZoom on the Map options.  The Map maxZoom should be greater than the maxZoom for the layer
open the script debugger and look at the network section to see the file being downloaded.
zoom in past the maxNativeZoom level and you will see tiles being loaded (and hidden) at the maxZoom level.
if maxNativeZoom is not defined this does not happen.

Expected behavior
While the layer is visible, the tile load request should be made.  Once we zoom past the the maxZoom, the tile load should stop.
Current behavior
Tile are loaded at the maxNativeZoom level even if we zoom deeper than maxZoom.  For example, if maxNativeZoom is set to 8 and maxZoom is set to 8.  If we zoom to level 9 the tiles for the layer will be loaded and hidden (rather than simply not loaded).  You will see the maxNativeZoom level images flash before they are hidden.
Environment

Leaflet version: 1.4 1.6
Browser (with version): chrome 72.0.3626.121, Firefox 66.0.1, Edge 42.17134.1.0
OS/Platform (with version): windows 10 (1803)

Additional context

Minimal example reproducing the issue
var map = new L.Map('leaflet', {
	layers: [
		new L.TileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {
		  maxZoom: 8,
		  maxNativeZoom: 8,
			'attribution': 'Map data © OpenStreetMap contributors'
		})
	],
	center: [0, 0],
	zoom: 0,
	maxZoom: 10
});

https://plnkr.co/edit/pkrjiiIzQlQjUwMOLQIm?p=preview

I confirm this issue on leaflet 1.6.0
Here is my example : https://jsfiddle.net/qvrx0ojf/
Just zoom in once to see the issue

Hhhmm, gotta look at how the tile levels are handled on this specific case.


Search functionality is flawed

If I've got a word like "handshake" in one of my .md files (let's say example.md) - the search only finds it if you don't write it whole.
For example:
hand: search finds example.md
shake: search doesn't find example.md
handshake: search doesn't find example.md

Yup, it has been an underwhelming search experience. I recently switched the "search engine" from lunr.js to FlexSearch, in addition to switching the search logic from serverside to clientside. Try updating the template to the latest version. You should see a significant improvement in both speed and accuracy. Let me know if works as you expected after the update.

The problem I wrote about no longer occurs, thank you!


add resources limit for proper scaling

See plotly/streambed#9865 and plotly/streambed#11037
Reason for removing the --request-limit is because currently when we hit the 1000 requests the server exit but the container stays up monit handle the restart and when you do that the container is still healthy on the LB. So it is possible that client connect and hit a connection refused.
To avoid that I'm limiting the resources of the container cpu and memory in which if the app have a memory leak it will kill the container and making it unavailable to the LB and just spin a new container.
The annotation is required to scale-down, if a container spin-up on a node where kube-system is running so it tells it's okay to kill that node.

[x] issues with down-scale, does not down-scale node that should
[x] fined tuning the resources
[x] preemptive instances
[x] deal with evicted instances

tested with :
ab -r -c 100 -n 100000 -p 86eac25f-4de9-4da2-82a9-0c7d28db1454_200.json http://<IP_ADDRESS>:9091/

Thanks @mag009 !
I'll let @scjody review this thing (I don't much about the deployment/ folder).
One thing to keep in mind, I'll like to upgrade the electron version we're using (see https://github.com/plotly/orca/pull/125) in the short-term. So, maybe you run your tests using the electron_2.0.8 orca image on quay,io? That would be much appreciated. Thanks!

I was able to stress test and so far so good. No crashes in 30 minutes for a total of 26k requests, at an avg rate  of 17 req/s
I'm using preempt vm's with shared cpu which can handle ~2req/s.
I still have minor issue, i'm getting connection refused when it add a container so i probably need to adjust the health check.
Test below is performed with a 384K file
Completed 10000 requests
Completed 20000 requests
Server Software:
Server Hostname:        <IP_ADDRESS>
Server Port:            9091
Document Path:          /
Document Length:        Variable
Concurrency Level:      15
Time taken for tests:   1481.105 seconds
Complete requests:      26407
Failed requests:        0
Total transferred:<PHONE_NUMBER> bytes
Total body sent:<PHONE_NUMBER>2
HTML transferred:<PHONE_NUMBER> bytes
Requests per second:    17.83 [#/sec] (mean)
Time per request:       841.314 [ms] (mean)
Time per request:       56.088 [ms] (mean, across all concurrent requests)
Transfer rate:          2133.49 [Kbytes/sec] received
6843.88 kb/s sent
8977.37 kb/s total
Connection Times (ms)
min  mean[+/-sd] median   max
Connect:        0    7  20.1      2     292
Processing:<PHONE_NUMBER>.3    315    8102
Waiting:<PHONE_NUMBER>.5    306    8032
Total:<PHONE_NUMBER>.5    321    8180
Percentage of the requests served within a certain time (ms)
50%    321
66%    421
75%    530
80%    616
90%   2638
95%   5146
98%   6062
99%   6462
100%   8180 (longest request)

I was able to stress test and so far so good.

Nice!

Test below is performed with a 384K file

Can you point us to that file? I might nice to run the tests on a collections of plotly.js mocks or using "real-life" image server requests.
Last spring, @scjody used this thing, which could be useful to you.

I'm also concerned by the idea of using preemptible VMs. According to this document:

[...] any or all of your Compute Engine instances might be preempted and become unavailable. There are no guarantees as to when new instances become available.

My understanding of this is that with preemptible instances, we could lose all our nodes and have no replacement nodes. Do you have any sources that contradict this understanding?

I'm also concerned by the idea of using preemptible VMs. According to this document:

[...] any or all of your Compute Engine instances might be preempted and become unavailable. There are no guarantees as to when new instances become available.

My understanding of this is that with preemptible instances, we could lose all our nodes and have no replacement nodes. Do you have any sources that contradict this understanding?

Your right about that. Even with Auto-scale there's a chance that we lose all instances at the same time in every zones. Slim change but still. I guess for stage we don't really care if that happen but for prod we can't take that chance. What I'd like to do is to scale with preempt and have 3 min running on none preempt vm's but I guess that should be in a separated issue.

I still have minor issue, i'm getting connection refused when it add a container so i probably need to adjust the health check.

updated : #41

Let's stick with regular instances for now. If we run into significant cost issues we can consider preemptible instances, but we don't need it right now. Autoscaling alone should provide significant savings.
Please let me know when you're ready for a re-review on this!

@scjody ready for review.
Just so you know I've created a dedicated pool for the imageserver. The reason is  I want to avoid mixing kube-system with default services. For example, heapster is a critical component for Auto-scale  I ran into issue when I introduced load where heapster stopped responding and the auto-scale stopped.
Procedure to deploy in prod :

create new pool with gcloud named : imageserver
kubectl replace -f kube/prod

PR #130 fix the travis-ci

Tests are now :white_check_mark: on master.

@scjody the I've process the success folder and all of them returned a 200, except file that are too large which returned a 400: textPayload":"400 - invalid or malformed request syntax (figure data is likely to make exporter hang, rejecting request.

@mag009 did you test this out using Electron v2 afterall?

@etpinard yes, i did but the memory issue is still present in 2.0.9. I've only tested few files not the entire success folder.

Ok great. Well, if the memory issues aren't worse using electron 2.0.9, we should be updating.
@mag009 Can you testing the entire success folder using electron 2.0.9 or write the steps to do so?


Crash when using snapshot 327

I upgraded OpenModsLib to install a new mod and received this crash:
---- Minecraft Crash Report ----
// Ooh. Shiny.
Time: 3/28/15 1:04 PM
Description: There was a severe problem during mod loading that has caused the game to fail
cpw.mods.fml.common.LoaderException: java.lang.NoSuchMethodError: openmods.config.properties.ConfigProcessing.processAnnotations(Ljava/io/File;Ljava/lang/String;Lnet/minecraftforge/common/config/Configuration;Ljava/lang/Class;)V
	at cpw.mods.fml.common.LoadController.transition(LoadController.java:162)
	at cpw.mods.fml.common.Loader.preinitializeMods(Loader.java:515)
	at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:239)
	at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:480)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:867)
	at net.minecraft.client.main.Main.main(SourceFile:148)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
Caused by: java.lang.NoSuchMethodError: openmods.config.properties.ConfigProcessing.processAnnotations(Ljava/io/File;Ljava/lang/String;Lnet/minecraftforge/common/config/Configuration;Ljava/lang/Class;)V
	at openblocks.OpenBlocks.preInit(OpenBlocks.java:336)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:513)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:208)
	at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:187)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:118)
	at cpw.mods.fml.common.Loader.preinitializeMods(Loader.java:513)
	... 10 more

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- System Details --
Details:
	Minecraft Version: 1.7.10
	Operating System: Windows 7 (amd64) version 6.1
	Java Version: 1.8.0_25, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 259369152 bytes (247 MB) / 940376064 bytes (896 MB) up to<PHONE_NUMBER> bytes (4044 MB)
	JVM Flags: 6 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx4G -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode -XX:-UseAdaptiveSizePolicy -Xmn512M
	AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
	IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
	FML: MCP v9.05 FML v<IP_ADDRESS>1 Minecraft Forge <IP_ADDRESS>1 75 mods loaded, 75 mods active
	mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed->Pre-initialized
	FML{<IP_ADDRESS>1} [Forge Mod Loader] (forge-1.7.10-<IP_ADDRESS>1.jar) Unloaded->Constructed->Pre-initialized
	Forge{<IP_ADDRESS>1} [Minecraft Forge] (forge-1.7.10-<IP_ADDRESS>1.jar) Unloaded->Constructed->Pre-initialized
	Aroma1997Core{<IP_ADDRESS>} [Aroma1997Core] (Aroma1997Core-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	CodeChickenCore{<IP_ADDRESS>} [CodeChicken Core] (minecraft.jar) Unloaded->Constructed->Pre-initialized
	NotEnoughItems{<IP_ADDRESS>} [Not Enough Items] (NotEnoughItems-1.7.10-<IP_ADDRESS>-universal.jar) Unloaded->Constructed->Pre-initialized
	TubesCore{${version}} [Tubes Core] (minecraft.jar) Unloaded->Constructed->Pre-initialized
	OpenModsCore{0.6} [OpenModsCore] (minecraft.jar) Unloaded->Constructed->Pre-initialized
	<CoFH ASM>{000} [CoFH ASM Data Initialization] (minecraft.jar) Unloaded->Constructed->Pre-initialized
	bspkrsCore{6.15} [bspkrsCore] ([1.7.10]bspkrsCore-universal-6.15.jar) Unloaded->Constructed->Pre-initialized
	ArmorStatusHUD{1.28} [ArmorStatusHUD] ([1.7.10]ArmorStatusHUD-client-1.28.jar) Unloaded->Constructed->Pre-initialized
	Treecapitator{1.7.10} [Treecapitator] ([1.7.10]Treecapitator-universal-2.0.4.jar) Unloaded->Constructed->Pre-initialized
	CoFHCore{1.7.10R3.0.0RC7} [CoFH Core] (CoFHCore-[1.7.10]3.0.0RC7-211.jar) Unloaded->Constructed->Pre-initialized
	BuildCraft|Core{6.4.3} [BuildCraft] (buildcraft-6.4.3.jar) Unloaded->Constructed->Pre-initialized
	BuildCraft|Transport{6.4.3} [BC Transport] (buildcraft-6.4.3.jar) Unloaded->Constructed->Pre-initialized
	BuildCraft|Silicon{6.4.3} [BC Silicon] (buildcraft-6.4.3.jar) Unloaded->Constructed->Pre-initialized
	BuildCraft|Builders{6.4.3} [BC Builders] (buildcraft-6.4.3.jar) Unloaded->Constructed->Pre-initialized
	BuildCraft|Energy{6.4.3} [BC Energy] (buildcraft-6.4.3.jar) Unloaded->Constructed->Pre-initialized
	BuildCraft|Factory{6.4.3} [BC Factory] (buildcraft-6.4.3.jar) Unloaded->Constructed->Pre-initialized
	Additional-Buildcraft-Objects{MC1.7.10-BC6.4release2.5} [Additional Buildcraft Objects] (ABO-MC1.7.10-BC6.4-release2.5.jar) Unloaded->Constructed->Pre-initialized
	additionalpipes{3.4} [Additional Pipes] (additionalpipes-3.4.jar) Unloaded->Constructed->Pre-initialized
	Aroma1997CoreHelper{<IP_ADDRESS>} [Aroma1997Core|Helper] (Aroma1997Core-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	Aroma1997sDimension{1.0} [Aroma1997's Dimensional World] (Aroma1997s-Dimensional-World-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	AromaBackup{<IP_ADDRESS>} [AromaBackup] (AromaBackup-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	BiblioCraft{1.9.2} [BiblioCraft] (BiblioCraft[v1.9.2][MC1.7.10].jar) Unloaded->Constructed->Pre-initialized
	Mantle{1.7.10-0.3.2.jenkins184} [Mantle] (Mantle-1.7.10-0.3.2.jar) Unloaded->Constructed->Pre-initialized
	Natura{2.2.0} [Natura] (natura-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	BiomesOPlenty{2.1.0} [Biomes O' Plenty] (BiomesOPlenty-1.7.10-<IP_ADDRESS>6-universal.jar) Unloaded->Constructed->Pre-initialized
	BiblioWoodsBoP{1.9} [BiblioWoods Biomes O'Plenty Edition] (BiblioWoods[BiomesOPlenty][v1.9].jar) Unloaded->Constructed->Pre-initialized
	ExtrabiomesXL{3.16.0} [ExtrabiomesXL] (extrabiomesxl_1.7.10-3.16.0.jar) Unloaded->Constructed->Pre-initialized
	BiblioWoodsEBXL{1.4} [BiblioWoods ExtraBiomesXL Edition] (BiblioWoods[ExtraBiomesXL][v1.4].jar) Unloaded->Constructed->Pre-initialized
	Forestry{<IP_ADDRESS>} [Forestry for Minecraft] (forestry_1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	BiblioWoodsForestry{1.7} [BiblioWoods Forestry Edition] (BiblioWoods[Forestry][v1.7].jar) Unloaded->Constructed->Pre-initialized
	BiblioWoodsNatura{1.3} [BiblioWoods Natura Edition] (BiblioWoods[Natura][v1.3].jar) Unloaded->Constructed->Pre-initialized
	ForgeMultipart{<IP_ADDRESS>0} [Forge Multipart] (ForgeMultipart-1.7.10-<IP_ADDRESS>0-universal.jar) Unloaded->Constructed->Pre-initialized
	Waila{1.5.8} [Waila] (Waila-1.5.8a_1.7.10.jar) Unloaded->Constructed->Pre-initialized
	TConstruct{1.7.10-1.8.2.build858} [Tinkers' Construct] (TConstruct-1.7.10-1.8.2a.jar) Unloaded->Constructed->Pre-initialized
	boilerplate{4.1.0} [Boilerplate] (boilerplate-1.7.10-4.0.1c.jar) Unloaded->Constructed->Pre-initialized
	CarpentersBlocks{3.3.3} [Carpenter's Blocks] (Carpenter's Blocks v3.3.3 - MC 1.7.10.jar) Unloaded->Constructed->Pre-initialized
	chisel{1.5.7} [Chisel] (Chisel-1.7.10-1.5.7.jar) Unloaded->Constructed->Pre-initialized
	cookiecore{1.3.0} [Cookie Core] (cookiecore-1.3.0.jar) Unloaded->Constructed->Pre-initialized
	props{1.12} [Decocraft] (Decocraft-v1.12b_1.7.10.jar) Unloaded->Constructed->Pre-initialized
	eplus{3.0.2-d} [Enchanting Plus] (EnchantingPlus-1.7.10-3.0.2-d.jar) Unloaded->Constructed->Pre-initialized
	EnderStorage{<IP_ADDRESS>} [EnderStorage] (EnderStorage-1.7.10-<IP_ADDRESS>-universal.jar) Unloaded->Constructed->Pre-initialized
	ExtraUtilities{1.2.0} [Extra Utilities] (extrautilities-1.2.0.jar) Unloaded->Constructed->Pre-initialized
	Steamcraft{0.28.5} [Flaxbeard's Steam Power] (Flaxbeard'sSteamPower-1.7.10-0.28.5.jar) Unloaded->Constructed->Pre-initialized
	WaslieCore{1.1} [WaslieCore] (WaslieCore-1.1.jar) Unloaded->Constructed->Pre-initialized
	ForestryExtras{3.1} [Forestry Extras] (ForestryExtras-2-3.1_B28.jar) Unloaded->Constructed->Pre-initialized
	McMultipart{<IP_ADDRESS>0} [Minecraft Multipart Plugin] (ForgeMultipart-1.7.10-<IP_ADDRESS>0-universal.jar) Unloaded->Constructed->Pre-initialized
	IronChest{<IP_ADDRESS>2} [Iron Chest] (ironchest-1.7.10-<IP_ADDRESS>2-universal.jar) Unloaded->Constructed->Pre-initialized
	JABBA{1.2.0a} [JABBA] (Jabba-1.2.0a_1.7.10.jar) Unloaded->Constructed->Pre-initialized
	journeymap{5.0.1} [JourneyMap] (JourneyMap5.0.1_Unlimited_MC1.7.10.jar) Unloaded->Constructed->Pre-initialized
	MetallurgyCore{4.0.4} [Metallurgy Core] (MetallurgyCore-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	Metallurgy{4.0.6} [Metallurgy 4] (Metallurgy-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	cfm{3.4.7} [§9MrCrayfish's Furniture Mod] (MrCrayfishFurnitureModv3.4.7(1.7.10).jar) Unloaded->Constructed->Pre-initialized
	NEIAddons{<IP_ADDRESS>} [NEI Addons] (neiaddons-mc1710-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	NEIAddons|Botany{<IP_ADDRESS>} [NEI Addons: Botany] (neiaddons-mc1710-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	NEIAddons|Forestry{<IP_ADDRESS>} [NEI Addons: Forestry] (neiaddons-mc1710-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	NEIAddons|CraftingTables{<IP_ADDRESS>} [NEI Addons: Crafting Tables] (neiaddons-mc1710-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	NEIAddons|ExNihilo{<IP_ADDRESS>} [NEI Addons: Ex Nihilo] (neiaddons-mc1710-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	neiintegration{1.0.4} [NEI Integration] (NEIIntegration-MC1.7.10-1.0.4.jar) Unloaded->Constructed->Pre-initialized
	OpenMods{0.6} [OpenMods] (OpenModsLib-1.7.10-0.6-snapshot-327.jar) Unloaded->Constructed->Pre-initialized
	OpenBlocks{1.3} [OpenBlocks] (OpenBlocks-1.7.10-1.3.jar) Unloaded->Constructed->Errored
	progressiveautomation{1.6.4} [Progressive Automation] (ProgressiveAutomation-1.7.10-1.6.4.jar) Unloaded->Constructed->Pre-initialized
	Railcraft{<IP_ADDRESS>} [Railcraft] (Railcraft_1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized
	steamcraft2{Beta R4.1} [Steamcraft 2] (steamcraft2-1.7.10-B4.1b.jar) Unloaded->Constructed->Pre-initialized
	StevesCarts{2.0.0.b18} [Steve's Carts 2] (StevesCarts2.0.0.b18.jar) Unloaded->Constructed->Pre-initialized
	StevesWorkshop{0.5.1} [Steve's Workshop] (StevesWorkshop-0.5.1.jar) Unloaded->Constructed->Pre-initialized
	TSteelworks{1.7.10-1.0.6} [Tinkers' Steelworks] (TSteelworks-1.7.10-1.0.6.jar) Unloaded->Constructed->Pre-initialized
	ttCore{MC1.7.10-0.1.0-62} [ttCore] (ttCore-MC1.7.10-0.1.0-62.jar) Unloaded->Constructed->Pre-initialized
	Tubes{2.0.5} [Tubes] (Tubes-1.7.10-2.0.5.jar) Unloaded->Constructed->Pre-initialized
	TwilightForest{2.3.2} [The Twilight Forest] (twilightforest-1.7.10-2.3.2.jar) Unloaded->Constructed->Pre-initialized
	wailaplugins{MC1.7.10-0.0.1-13} [WAILA Plugins] (WAILAPlugins-MC1.7.10-0.0.1-13.jar) Unloaded->Constructed->Pre-initialized
	FMPIntegration{1.0} [FMPIntegration] (fmpintegration-1.0.jar) Unloaded->Constructed->Pre-initialized
	ForgeMicroblock{<IP_ADDRESS>0} [Forge Microblocks] (ForgeMultipart-1.7.10-<IP_ADDRESS>0-universal.jar) Unloaded->Constructed->Pre-initialized
	OpenModsLib crash transformers: [stencil_patches:FINISHED],[movement_callback:FINISHED],[map_gen_fix:FINISHED],[gl_capabilities_hook:FINISHED],[player_render_hook:FINISHED]
	CoFHCore: -[1.7.10]3.0.0RC7-211
	Mantle Environment: Environment healthy.
	TConstruct Environment: Environment healthy.
	Stencil buffer state: Function set: GL30, pool: internal, bits: 8

You've updated OpenModsLib without updating OpenBlocks.

Thank you.


Change detecting sudo priviliges to check if process euid is 0

This should address #387

Thanks! I'll clean up the line a little bit but this change seems to work perfectly


Add v3 knowledge schema support

dcb2af1 full: Adjust knowledge prompt for v3 schema
655f003 simple: Adapt simple knowledge pipeline for v3 schema
6161410 utils: Update taxonomy reading code to handle knowledge v3
2c6b323 requirements: Temporarily use schema fork that includes v3
c0c1623 utils: drop an unused import
7f8a791 e2e: Temporarily install instructlab from a PR
26e29df generate_data: Account for knowledge format when generating test data
commit dcb2af109678f4ad88cc28a76dcb148345e24948
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Wed Jul 17 17:48:53 2024 -0400
full: Adjust knowledge prompt for v3 schema

For more information on the v3 schema, see this issue:

  https://github.com/instructlab/sdg/issues/160

This change to the prompt does a couple of important things:

- Make use of document-specific context for the provided sample q&a.

- Add the new `document_outline` field which provides a summary of the
  document.

Co-authored-by: abhi1092<EMAIL_ADDRESS>Co-authored-by: shiv<EMAIL_ADDRESS>Co-authored-by: Aakanksha Duggal<EMAIL_ADDRESS>Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit 655f003c6b51972f0e364cccd96f50cadf36b5f0
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Wed Jul 17 19:19:07 2024 -0400
simple: Adapt simple knowledge pipeline for v3 schema

The v3 knowledge schema includes context specific to the sample
questionsa nd answers. Include that context in the prompt.

The schema also includes a new `document_outline`. Give it prior to
the document chunk in the same way as the `full` pipeline prompt,
`generate_questions_responses.yaml`.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit 61614105bcfea1658a8ab6715a2c9a89decf85a6
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Thu Jul 18 15:30:16 2024 -0400
utils: Update taxonomy reading code to handle knowledge v3

This is part of https://github.com/instructlab/sdg/issues/160

The changes here originated from https://github.com/aakankshaduggal/sdg/commit/5baf6dfde8334fa52a4ffe38e9dc9121dfb468aa

There are two major changes here.

- When parsing a `qna.yaml` file from a taxonomy tree, adjust for the
  new schema for knowledge. There is no attempt to maintain
  compatibility with prior versions of the schema (v1, v2).

- Change how we translate the taxonomy data into the dataset sent into
  the pipeline as input. Instead of implementing a sliding window
  approach of 3 sample qna pairs at a time over all chunks of the
  document, we now create a row per seed_example (context and
  associated qna pairs) for each chunk of knowledge docs.

Co-authored-by: abhi1092<EMAIL_ADDRESS>Co-authored-by: shiv<EMAIL_ADDRESS>Co-authored-by: Aakanksha Duggal<EMAIL_ADDRESS>Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit 2c6b323c7a542d845cfbc09232f296048f179523
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Thu Jul 18 15:37:43 2024 -0400
requirements: Temporarily use schema fork that includes v3

This change must be removed before we make a release. Since v3 is not
in a release of instructlab-schema, we have to pull it out of a git
branch.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit c0c16235a34ee1889030321fa92698b5b2f08a4b
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Thu Jul 18 16:15:25 2024 -0400
utils: drop an unused import

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit 7f8a791f03602c05925d23f923854b8964acf374
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Thu Jul 18 16:28:11 2024 -0400
e2e: Temporarily install instructlab from a PR

This PR includes the changes to account for schema v3.
This should be removed later.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit 26e29dfc598d4681a2e9279c87cc0f93dfbf109c
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Fri Jul 19 14:10:54 2024 -0400
generate_data: Account for knowledge format when generating test data

_gen_test_data() needed fixes to account for the different format
coming from a knowledge doc vs skills.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

More changes are needed. I just wanted to get a draft PR up that we can add stuff to and collaborate on.

  File "/home/runner/work/instructlab/instructlab/venv/lib/python3.11/site-packages/instructlab/data/generate.py", line 195, in generate
    generate_data(
  File "/home/runner/work/instructlab/instructlab/venv/lib/python3.11/site-packages/instructlab/sdg/generate_data.py", line 284, in generate_data
    _gen_test_data(
  File "/home/runner/work/instructlab/instructlab/venv/lib/python3.11/site-packages/instructlab/sdg/generate_data.py", line 149, in _gen_test_data
    user = seed_example["instruction"]  # question
           ~~~~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: 'instruction'

I'm guessing I haven't pulled in some changes to generate_data.py

This now passes CI, but it's blocked on an instructlab-schema release that includes https://github.com/instructlab/schema/pull/39

e2e workflow failed on this PR: View run, please investigate.

This is expected to fail because it's not using my instructlab/instructlab branch.
An equivalent job is running on the instructlab repo with this branch and the instructlab repo changes here: https://github.com/instructlab/instructlab/actions/runs/10042419982/job/27752975101

trying this out I got the same error CI is now getting

The conflict is caused by:
instructlab 0.18.0a5.dev17 depends on instructlab-schema 0.1.dev60 (from git+https://github.com/russellb/instructlab-schema.git@v3)
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
instructlab-sdg 0.1.dev265 depends on instructlab-schema>=0.3.1

Once thats resolved it lgtm, (although I do wonder about the additional overhead required of users (now need to manually extract 5 sections of the knowledge, put them into the yaml  and provide 3 same questions on each), this may be a lost of overhead for small documents. But I guess its less of a chore of large documents.

ah, need to change this in instructlab/instructlab#1790:
# TODO: change this once instructlab-schema 0.3.0 is released
#instructlab-schema>=0.3.0
instructlab-schema @ git+https://github.com/russellb/instructlab-schema.git@v3


[FullNode] enum for node states instead of bunch of bool variables.

I think it will be a good idea to have Node's state in single enum instead of several bool variables (Stopped, IsDisposed, HasExited) that don't even cover all states.
    public enum FullNodeState
    {
        Created,
        Initialized,
        Starting,
        Started,
        Stopping,
        Stopped,
        Disposing,
        Exited
    }

I would wait with this while @Aprogiena is refactoring the node code

Ok, totally agree.


Access token is require which is missing

Hi,
I'm sorry, I would like to know how can I fix the issue related to "Access token is require which is missing" when I try to access after a fresh installation.
Everything in server (docker) is well:
db
etherpad
livekit
plugnmeet-api
livekit-ingress
server-redis
Also in client:
webpack 5.89.0 compiled successfully in 83542 ms
No errors found.
Im not sure if I need to include some "key" from config server in some file from the client files ?
I really appreciate all your help.
Thanks

Please follow: https://www.plugnmeet.org/docs/api/intro
Or to direct access login page: https://your-pnm.com/login.html

Hi @jibon57
Thank you very much for your quick response. I have already solve it thanks your advise. Im sorry , I have another question: do you know how can I set up SSL on a docker installation. I can see you have previously explained for stand alone installation with haproxy. Im using this --> https://www.plugnmeet.org/docs/developer-guide/setup-development/
P.S: I dont know is better move this message to the discussion session.
Thank you very much


Provide access to Bootstrap 1.4 documentation

The site at http://twitter.github.com/bootstrap has been upgraded for Bootstrap 2.0. It'd be helpful for folks who haven't upgraded yet to still have access to the previous version of http://twitter.github.com/bootstrap for Bootstrap 1.4.

The docs are on the zip at https://github.com/twitter/bootstrap/tags

here's that as a [somewhat-badly formatted] PDF:
https://docs.google.com/open?id=0B5a7qMCnQvaZNDY0ZWRkOTMtZjYwOC00MjZjLWJhMzAtYjlhMTRlYWVhOWU5

Mmh, not so awsome... would reopen, but can't.

hardly case closed
this is bad, the old docs need to remain available

why would anyone use twitter bootstrap if the docs are going to get removed every time there is a new version ?

@whatbird @huerlisi @mog-labs huh? The docs are still available - simply download the earlier version of Bootstrap from the link provided above, then open the index.html file in the docs folder. Does that work for you, or is there some issue with that solution?

No big issue, just a bunch of minor ones;-)

Not so simple to find: had to google to find this issue to find out how to access the old docs
Not so DRY: working on more than one workstation, I had to repeat download etc. on each of them
Not so stable: I sometimes like to point to some docs in bookmarks or little howtos
Not so mobile: reading docs while commuting to refresh memories is fun, but not so simple this way

Anyway, damn nice work! Both the code and the docs are really boosting my development:-) And this is the reason why I'm using bootstrap even if docs get removed every time there is a new version, @mog-labs.

Please reopen this. Pointing users to a tag to download a zip file, extract it and open index.html is really bad.

+1 @huerlisi points.

+1

Solution is more of a workaround than a fix. I still need the docs for 1.4 to help with the migration. I'm thinking I may just have to host them off my own server because apparently twitter can't afford to host static HTML files ;-)

We love Bootstrap too but can't believe that previous documentation is not available online. We've put it here for ease of use if anyone is interested:
http://clients.digi-nut.co.uk/twitter-bootstrap/docs/1.4/
(Hopefully that doesn't break Twitter's CC license.)

@dannybull
"You are free:
to Share — to copy, distribute and transmit the work"
From: http://creativecommons.org/licenses/by/3.0/
I think you're ok there then, but never hurts to hear a twitter employee give you green light.

OK, I'm convinced guys - I'll reopen the issue - thanks Danny, but let's try to get these docs hosted here at the project site, perhaps as part of the wiki? Anyone want to add them in and do a pull request?

@dannybull :+1:

Chipping in here. Would love to have these docs available as well. Fact is, many of us still run on 1.4 and cannot simply upgrade to 2.0.


Fixes

Typos
s/python/Python/g
Adds link to Tabular Data Package spec

More controversial is trying to get at what metatab is at the top.  It’s not just for manipulating structured “data” or “information”, but, specifically, “data” and “metadata” together in a tabular form, correct?
Let me know what you think :)

Awesome, thanks.


HNC: test NetworkPolicy integration with HNC

/assign @srampal
As discussed offline - play around with NetworkPolicy and HNC and verify both that:

It gets copied and applied in descendant namespaces as expected
You can use namespaceSelector to select subtrees for ingress and egress

An example namespaceSelector to select all subnamespaces of foo might be something like:
- namespaceSelector:
  - matchExpressions:
    - key: `foo.tree.hnc.x-k8s.io/depth`
      operator: Exists

Tested and verfied that this is working as expected.
Tested network policy propagation across multiple levels and use of selective label filtering to implement propagation in partial sub-trees of a namespace hierarchy. Also tested the data plane to confirm the behavior. tested the scenarios listed in the requirements description of this issue.
The detailed testing procedure has been documented in the network policy test section of the HNC demo document at this link.

Thanks Sanjeev!


Map IRIs with WBGene namespace into biolink model

Some examples of unmapped WBGene IRIs:
http://identifiers.org/wormbase/WBGene00013878
http://identifiers.org/wormbase/WBGene00017920
http://identifiers.org/wormbase/WBGene00000467

There is a prefix for wormbase but not WBGene specifically. Look here: https://github.com/biolink/biolink-model/blob/master/context.jsonld#L172

We need to add a feature to the web service app that can normalize IRIs to a canonical namespace before compacting to a CURIE using the biolink-model context. For example, when constructing a return message:

Rewrite http://identifiers.org/wormbase/WBGene00013878 to https://identifiers.org/wb/WBGene00013878.
Compact https://identifiers.org/wb/WBGene00013878 to WB:WBGene00013878


DEX-2421 Promptpay via Omise

What this PR does

Adding PromptPay via Omise
Added another delegate to our solution to provide the merchant with additional info

Changes addressed, will thoroughly test this before merging into its preview branch and release 👍


Closing either input or output part of a channel

I know this feature is not strictly required for most of use cases. But I have encountered a situation where I need to shutdown only output portion of a socket. A server implementation that I can't make any change on relies on end-of-stream on its reading side. Though I'll find out some hacks for the time being, it would be good to have such a feature exposed as a public API.

I think we could support this easily with the new NIO.2 methods in java7.


[$500] Log in - E-mail input field not focused when scroll down and click Create A New Account/Log in

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

**Version Number:**1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Click outside е-mail input field so "Please enter an email or phone number' is presented
Scroll down to the bottom of the page
Click on Create A New Account or Log in

Expected Result:
Е-mail input field should be focused
Actual Result:
E-mail input field not focused when scroll down and click Create A New Account/Log in while the message 'Please enter an email or phone number' is presented
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/c9667c72-ee8a-49d7-9dae-28149e867d42
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue
Log in - E-mail input field not focused when scroll down and click Create A New Account/Log in
What is the root cause of that problem?
This is due to missing focus call and we just scroll to top in this case
What changes do you think we should make in order to solve the problem?
Add explicit focus mechanism
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.

Log in - E-mail input field not focused when scroll down and click Create A New Account/Log in

What is the root cause of that problem?

Currently, once we click on "Create A New Account" or "Log In", it just scroll to the top and clear all the session data as bellow:
https://github.com/Expensify/App/blob/0a8ad473e71c18adb3d299f0562057177de09e2a/src/pages/signin/SignInPageLayout/Footer.js#L30-L35

What changes do you think we should make in order to solve the problem?

First create the LoginFormInputManager.ts:

import React from 'react';
import {TextInput} from 'react-native';

const loginFormInputRef = React.createRef<TextInput>();
const setFormError = () => {};

export default {loginFormInputRef, setFormError};

Then, update:
https://github.com/Expensify/App/blob/0a8ad473e71c18adb3d299f0562057177de09e2a/src/pages/signin/LoginForm/BaseLoginForm.js#L251
to:

                    ref={(el) => {
                        input.current = el;
                        LoginFormInputManager.loginFormInputRef.current = el;
                    }}

Finally, update:
https://github.com/Expensify/App/blob/0a8ad473e71c18adb3d299f0562057177de09e2a/src/pages/signin/SignInPageLayout/Footer.js#L30-L35
to:

const navigateHome = (scrollPageToTop) => {
    scrollPageToTop();

    // We need to clear sign in data in case the user is already in the ValidateCodeForm or PasswordForm pages
    Session.clearSignInData();
+  LoginFormInputManager.loginFormInputRef.current.focus();
};

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@sobitneupane FYI - I didn't put the whole implementation code in my proposal, as this is a pretty straightforward solution to solve

@shubham1206agra yeah. I think it depends on review to choose the solution for this issue

@shubham1206agra Thanks for your proposal.
Could you please add more details to your proposal? Please do include permalinks to point out where the issue exists. Where will you make the suggested changes? And more details on the solution will be appreciated.

I will. Thanks @sobitneupane

@sobitneupane Updated

@sobitneupane can you take a look at the updated proposal when you get a chance?

@sobitneupane What do you think about my proposal?

@sobitneupane any thoughts?

Thanks for the proposal @shubham1206agra and @DylanDylann
Both of the proposal solves the issue.
Though, proposal from @DylanDylann is quite simpler to implement, I think the proposal proposed by @shubham1206agra is the general practice of dealing with such cases. So, I am recommending @shubham1206agra's proposal.
🎀 👀 🎀 C+ reviewed

@shubham1206agra you need any help to get the PR for this one up?

@shubham1206agra you need any help to get the PR for this one up?

@shubham1206agra you need any help to get the PR for this one up?

Sorry for the delay. I will open a PR shortly

I will publish a PR today

@shubham1206agra ?

Extremely sorry for the delay. I was completing other priority task, and this got delayed. Will not happen again.

@shubham1206agra offer out to you!

Dropping to weekly for @sobitneupane to request payment

Not overdue. Still waiting for request for payment.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  The PR that introduced the bug has been identified. Link to the PR:

This is an edge case and was probably existent from the inception of the feature.
https://github.com/Expensify/App/pull/17119 and https://github.com/Expensify/App/pull/17445 are the PRs that worked on scrolling of the page.

[ ]  The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

[ ]  A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ]  Determine if we should create a regression test for this bug.

Yes.

[ ]  If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open Expensify App and logout if you are already logged in.
Click outside е-mail input field so "Please enter an email or phone number' is presented
Scroll down to the bottom of the page
Click on Create A New Account or Log in
Verify that Е-mail input field is focused.

Do we agree 👍 or 👎

Done, closing

$500 payment approved for @sobitneupane based on this summary.


Normalize Unit Test Class Names

Right now they are suffixed but "Test" and "UnitTest" — choose one.

Done as of 7354b80.


feat: PGP Signed Helm Chart

Helm has a feature to sign and verify charts so that the provenance and integrity can be checked. Given that kubewarden is around security, this could be useful to use.
There is a plugin to make this easier with GPG.
On Artifact Hub there is a badge to show the provenance file. Here's an example. The badge shows up in search, too.

Just in case, we have been signing the Helm charts with Sigstore, and are published signed in ghcr.io.
See https://docs.kubewarden.io/security/verifying-kubewarden#helm-charts.


updated selector to use vite

Updated the selector to use vite.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Can you also rename all the mapBoxToken to mapboxToken? I have updated it in shared components just to have a clearer naming.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.


npm package?

This is a really cool project, are you gonna make it an npm package?

thanks, yes sure im gonna do that, im not happy how this is distributed currently.
how would you use / install this package?

i think its not possible to import this package from source in a custom js app like this src/main.js, as the custom webpack wont apply then i think. But then when using dist/main.js, there is only a function exposed manually on the global window, what doesnt seem right.
As of right now fx this wont work in the browser as there is no export via webpack:
const tailwind = import('./dist/main.js');

and webpack es6 modules are still an experiment puh and so on - many questions.
Should one better use rollup so one can import from the bundeled js file? Maybe treeshaking works too then?

i feel like i need to find answers first to some of the questions, to have a nice public api - and then publish it ^^

yeah, i think you're right. i wouldn't want it in my build and would have to do something like a dynamic import. That said, having it on a public cdn would make it easy to just add the script tag and continue using it the way you originally published it. For now i've just copied the dist into my public folder and am pointing a script tag at it.

so ideally would be if one could use this package like:
Usecase 1 / Import
(in

hu just found this package: maybe we can learn something from https://github.com/mapgrid/tailwindcss-browser, outdated and no jit, but still there is a webpack config (git log) and a rollup config ...

i tried playing around with rollup as its looks like a good idea, but ran into a lot of the stuff you had already stubbed out. Rather than fighting it i just went back to using webpack with the above pr.

how far did you get with rollup? maybe i can give it another shot?

Not far at all. Give it a shot if you have time. I'm focused on a few other things at the moment. Thanks!

https://github.com/mhsdesign/browser-jit-generate-tailwindcss/issues/1#issuecomment-1063955960
2 and 3 work, but only in a custom bundle - otherwise one needs to use it like:
await import('../dist/main.js')
console.log(window.browserJitGenerateTailwindcss)

voila https://www.npmjs.com/package/@mhsdesign/jit-browser-tailwindcss

Awesome, thanks!

btw @jamescharlesworth i just did a full rewrite xD With esbuild as bundler, and completely different internals, webworker, and half of bundle size: 250kb
https://github.com/mhsdesign/jit-browser-tailwindcss/commit/48847787122cb6f55eea9798d2fcfcd75da56a0b

thanks @mhsdesign thats awesome and I appreciate you letting me know! I've been meaning to look at esbuild for a different project. Your commit will definitely help guide me in some changes.  Thanks again!

Hi now v0.2.0 is fully done ;)
Can you maybe check if it still works for your projekt? ^^ (in combination with webpack)
(esbuild is crazy good ^^)


Allow NeogitCosole to have its kind set.

Is your feature request related to a problem? Please describe.
I have a use cases where I am using kind=floating and both commit_popup and popup also set to kind=floating. Whenever the NeogitConsole pops up (e.g. during a pre-commit hook) it is obstructed by the floating window. This process also makes the floating window lose focus without closing which may be unintentional.
Describe the solution you'd like
Allowing the NeogitConsole to be rendered in the floating window in a similar way to how commit_popup=floating works. If no error is reported, transition to the commit message dialog, otherwise, keep the console open and allow the user to exit the floating window or go back to status.
Describe alternatives you've considered
Allow the option of automatically closing the NeogitConsole while also being able to set the length of the popup dialog timeout as its currently too short to properly read the error message in my case.
Additional context

As for the alternative solution. If you disable the builtin notification system in config disable_builtin_notifications=true, you can use nvim-notify and :Notifications to view the failed commands.
That is what I do most of the time


Revert "Fallback to building Cmake from source on all platforms"

This is causing intermittent test failures on bots that build cmake. Also revert the input dumping that let me find this.

@swift-ci smoke test and merge


python3Packages.vt-py: 0.7.4 -> 0.7.5

Motivation for this change
Update to latest upstream release 0.7.5
Change log; https://github.com/VirusTotal/vt-py/releases/tag/0.7.5
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140570 run on x86_64-linux 1

3 packages built:

ioccheck
python38Packages.vt-py
python39Packages.vt-py


DeveloperGuide: Refine use case, NFR

Fix #30

Update use case by:

Exclude unnecessary UI detail such as "clicks Enter button" and "types track".
Correct the numberings for extensions.
Add necessary step for extensions.

Minorly update NFR and glossary (Correct grammar/Use number to represent scope, e.g. multiple users to at least 1 user).

Codecov Report

Merging #31 (edbb4cb) into master (73b81dc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b81dc...edbb4cb. Read the comment docs.


Update internal card handling to use the new, more complete version

Still a WIP. This will close #43. Remaining to do:

[ ] Have CardData properly handle metadata as well as meta-scaling cards like Searing Blow
[x] Move _get_cards to the subclasses and make them use the full data
[x] Make sure _get_cards and _get_removals are updated to the new internal API
[x] Update the website handling for keys (I changed how they're returned to be better)
[x] Add the card backs and description boxes for the colors of the new characters
[ ] Update API documentation
[x] Bump minor version by 1

This is ready to be tested and reviewed. CardData doesn't know how to deal with meta-scaling cards (Ritual Dagger and Genetic Algorithm, and idk how Searing Blow is handled), though there's some baseline there. Can probably merge without this.
Make sure to update Docs while merging this. I can get on them this week.

I very much agree with Olivia here, I think our get function is getting too much. I'd like to separate it into get_card and things like that. Although it would create duplicates of the inner function because they would all be the same thing. Perhaps this is an issue with the design of how the json data is, we could put them each in its own key for cards or relics, etc.
Or if we kept all the get functions looking the same, we could throw an exception if it's not the thing we're searching on.  This is partly due to the fact that everything is in one file.
Something that I didn't communicate in this PR: I am planning for full_data.json to actually reside in another repository (not one that I control), and for the bot to pull from it on startup, as it can get updated regularly with changes to Downfall. As such, moving it into multiple files isn't feasible. I'm fine with having multiple functions, but as this is specifically for internal stuff, there shouldn't be conflicts.
Whatever we decide to do, this PR should not be merged until I (or someone else!) get around to writing API reference for this on the Docs repo.


WIP: Introduce Task

I developed on top of this one in https://github.com/googlecartographer/cartographer/pull/1107, so tracking further changes there and closing this one.

This introduces the new class common::Task. A Task can have dependencies to other tasks, notify ThreadPoolInterface when all its dependencies are fulfilled, and can be executed in the background.

@wally-the-cartographer merge


upkeep: Add CODEOWNERS file with maintainer

@Antoine-Lalechere I guess that would be you?

I think so, I can take care of this in the next sprint - do you have a tuto explaining how to create cleanly a CODEOWNERS file?

closed by #3


PDF and Print functionality will be unavailable on Wednesday, 22nd June,2022 from 5 P.M - 5:30 P.M

Please be advised that there will be scheduled downtime for PDF and print service in Waypath Platform on Wednesday, 22nd June,2022 from 5 P.M - 5:30 P.M.
We apologise for any inconvenience.

PDF and Print service is available now.


Data safety check in sample collected fields

Can you please check the safety of the data being presented in the sample_reported_pop and sample_reported_host field.
Remove everything other than a-Z, 0-9, -, _, ., and " " for good measure. I see ways that could be abused, otherwise.

More explanation on this:  What if someone put the following string in their NSID value (including the quotes)
hi,",probe_id=12345,job="whatever".rrdns.pch.net
That could result in a metric that looks like this:
ripe_atlas_latency{measurement_id="12016241",probe_id="99",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="378",probe_country="IL",probe_lat="32.1115",probe_lon="34.8115",sample_reported_pop="hi,",probe_id=12345,job="whatever",",sample_reported_host="res200"} 14.12
This would result in unexpected labels appearing in the data stream from external sources.  My particular example may or may not work (at a minimum, it would be rejected and the sample would be discarded) but there is risk here for clever injection of characters into those strings which has meaning as parsed by other components.  Standard SQL injection attack methods.
This is a really bad security and stability risk.  So I'd like to see the strings that are pulled from remote systems (sample_reported_pop and sample_reported host) be stripped of all characters except for a small set of characters that cannot be interpreted by string parsers in unexpected ways further down the pipeline.
In my example above, the attack string would be sanitized to:
hiprobe_id12345jobwhatever.rrdns.pch.net

Thanks for your illustration. The sanitize_string function was written to cover this. Kindly switch to google-cloudflare-support branch commit f89048121eaad2d8e5c49592e3b16909bff346c0 to verify

sanitize_string() function will cover this use case.


pythonPackages.mapbox: init at 0.18.0

Motivation for this change
Add the Mapbox for Python SDK.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
N/A

Committed your suggested changes, @jonringer.

@GrahamcOfBorg build python27Packages.mapbox python37Packages.mapbox python38Packages.mapbox

@jonringer can this be merged?

yea, sorry, forgot to follow up after build. Thanks for pinging


Correct typo from Azure Front Door Services services to Azure Front services

Azure policy definition had an extra "services" in the end. It was perhaps because Azure Front Door was earlier called Azure Front Door Services.
The renaming of service by Azure didn't update in Azure policy definitions.

Hi @arpitjain099 Your pull request updates 100 files, not just the one file referred to in the pull request title. It includes file deletions, and the PR can't be merged in this repo. Could you take a look at the process you used to create the PR to make sure you pull in only the changes you made and want to merge? You'll probably want to create a new PR. Thanks. We'll close this one.


[FEATURE]-CameraPropertiesConfig include configuration for Camera ID

Is your feature request related to a problem? Please describe.

CameraPropertiesConfig does not include a configuration for Camera ID
No configuration for pan, tilt, zoom speeds

Describe the solution you'd like

Add support for Camera ID through configuration.
Add configuration for pan, tilt, zoom speeds.  If not defined a default value would be used.

Is this for the Visca ID?

Correct, it appears all cameras are hard coded with a VISCA ID of 0x01.

Ok, so if we add a config property for the ID and if no ID is specified in config (for backwards compatibility) we assume 0x01?  Will that work?

While updating the configuration object, can we add configuration for the pan, tilt, zoom speeds?

@jkdevito do we want speeds for slow/fast?

In most cases we don't expose P/T/Z speed increment/decrement on the UI, however we are asked to change the speed to the customers liking, typically a set and forget value.  So, personally, I would  envision this as a numeric value (falling within the device limits).  If the value defined is outside of the limits a default value (middle of the range) would be used and a console message would be generated for the developer to notify them of the value was out of range.

Right, set and forget config value, but most SIMPL modules have slow/fast config values that handle a faster speed when holding a camera direction button.  I'm going to allow for configurable properties for two speeds

Extends CameraPropertiesConfig to include the following:
 public class CameraViscaPropertiesConfig : CameraPropertiesConfig
    {
        /// <summary>
        /// Control ID of the camera (1-7)
        /// </summary>
        [JsonProperty("id")]
        public uint Id { get; set; }

        /// <summary>
        /// Slow Pan speed (0-18)
        /// </summary>
        [JsonProperty("panSpeedSlow")]
        public uint PanSpeedSlow { get; set; }

        /// <summary>
        /// Fast Pan speed (0-18)
        /// </summary>
        [JsonProperty("panSpeedFast")]
        public uint PanSpeedFast { get; set; }

        /// <summary>
        /// Slow tilt speed (0-18)
        /// </summary>
        [JsonProperty("tiltSpeedSlow")]
        public uint TiltSpeedSlow { get; set; }

        /// <summary>
        /// Fast tilt speed (0-18)
        /// </summary>
        [JsonProperty("tiltSpeedFast")]
        public uint TiltSpeedFast { get; set; }

        /// <summary>
        /// Time a button must be held before fast speed is engaged (Milliseconds)
        /// </summary>
        [JsonProperty("fastSpeedHoldTimeMs")]
        public uint FastSpeedHoldTimeMs { get; set; }

    }


different content output same content hash

Bug report

What is the current behavior?
the content of the output files are different, but the content hash are same.
If the current behavior is a bug, please provide the steps to reproduce.
reproduce repo

What is the expected behavior?
content hash should respect the real content of the output file. looks like it only respect the content which wrapper in webpackJsonp.push function.

Other relevant information:
webpack version:  4.8.3
Node.js version: 8.11.1
Operating System: macOS 10.13.1
Additional tools:

Please use webpack.NamedChunksPlugin plugin for webpack@3 and optimization.namedChunks: true in production mode. Long term caching will be improved in webpack@5. Thanks!. Feel free to feedback.

and I thought contenthash is better than chunkhash.

@evilebottnawi

Any chance to get some more help on this? Everything in the docs indicate that contenthash is the right way to go. We see the same problem as this issue, and it's very unclear how NamedChunksPlugin solves this problem.

I would recommend you to use chunkhash.


Import foundation scripts as ES6 modules

Support for modules are planned for 6.4 release: https://github.com/zurb/foundation-sites/issues/7386

We plan to remove current frontend stack boilerplate, so starter theme will ship without any at the start.
Issue moved to cli: https://github.com/tonik/cli/issues/6


New package: HeartBeats v0.1.0

Registering package: HeartBeats
Repository: https://github.com/cbrnr/HeartBeats.jl
Created by: @cbrnr
Version: v0.1.0
Commit: dba3a4c210e4b9836f49f1d728e4a599fca8faa6
Reviewed by: @cbrnr
Reference: https://github.com/cbrnr/HeartBeats.jl/issues/1#issuecomment-1019515671

I've updated the compat entry for DSP to:
DSP = "^0"

Still I get the error, but I don't understand why... [noblock]


Display in jupyter notebook

Thanks for this piece of software!
Is there a way to use molecule-slide-generator to display resulting image directly in the jupyter notebook? So far I have to use this workaround: generate png as described, and later display it in the notebook:
png = sg.generate_slide(mols, all_props)
from IPython.core.display import Image, display
display(Image(png))

I did the same thing in my manual testing. I don't think and automated way exists but then I'm not a Jupyter expert.
Only other option is to use the out_path option (save the image to disk) and then display it in the next cell as markdown cell with ![title](slide.png). But that isn't really any more convenient.
I suspect it works for rdkit molecules directly due to setting/manipulating the __repr__ method accordingly.

OK, this could be done by creating a simple subclass of bytes and returning that instead:
class Slide(bytes):
    def _repr_png_(self):
        return self

Then
png = sg.generate_slide(mols, all_props)
png

will display the image in Jupyter notebook while it can still be used as a bytes object.
But not sure if this is worth it or other possible downsides.

Good, thanks!


alias StorableObjects = Union() Syntax Error

I just did a shards update ('m using the master branch), and an app I'm working on no longer works:
Error in lib/kemal-session/src/kemal-session/storable_object.cr:19: macro didn't expand to a valid program, it expanded to:

================================================================================
--------------------------------------------------------------------------------
   1.       alias StorableObjects = Union()
   2.
--------------------------------------------------------------------------------
Syntax error in expanded macro: finished:1: expecting token 'CONST', not ')'

      alias StorableObjects = Union()
                                    ^

================================================================================

    macro finished
          ^~~~~~~~

I noticed that #19 was just committed yesterday dealing specifically with StorableObjects.

@jasonl99 are you defining any storable objects in your codd?

Yes, that's exactly the issue.


Number format without group separator

Hi,
I'm new to anuglar.js. I like to know, how to specify a number without group separation format.
For e.g:
12345678.01234
If I specify particular {{ var1 | number }} , comes with comma(,) separation for en and  dot(.) separation for es locale.
Please help me out!!

This is a support question and should be directed to the appropriate channels.
GitHub is reserved for bug reports and feature requests.
--
That said, there isn't any filter/option for removing the group separator. You could either define your own filter, expose a function on the scope or formatting the value in the controller (before displaying).


Added a2md.xml file, which contains documentation about a2md binary in

docbook format. It is just draft version, so feel free to alter it. I
was also not sure, where it should belong in project dir tree, so I
commited it into project's root.
For manpages generation use "xmlto man ./a2md.xml"

Thanks @uhliarik. Until there is a doc? or manual folder, root seems a good place for it to be.