Support Lineax operators for the vector field of ControlTerm

By providing support for lineax.AbstractLinearOperators in the vector field of a ControlTerm it may be possible to reduce the need for  WeaklyDiagonalControlTerm and/or any other such specialised control terms.
The following gives a MWE:
class ControlTerm(_ControlTerm):
    def prod(self, vf, control):
        if isinstance(vf, lx.AbstractLinearOperator):
            return jtu.tree_map(lambda _vf, _control: _vf.mv(_control), vf, control)
        return jtu.tree_map(_prod, vf, control)

# These two are now equivalent.
ControlTerm(lx.DiagonalLinearOperator(jnp.array([1,2,3])), ...)
WeaklyDiagonalControlTerm(jnp.array([1,2,3]), ...)

Not sure if this is something you want to support, but it occurred to me that the operator tags might also be useful for some of the diffrax solvers?

Yup, with the release of Lineax this is something I've been considering! This also dovetails nicely with #364, so that we may wish to also introduce a type parameter for the return type of the vector field.
(One very nitty concern I do have is that mathematically speaking, we tend to interpret f(y) dx as actually being a linear function dx -> f( . ) dx (returning a nonlinear function), rather than a nonlinear function y -> f(y) (returning a linear operator). But that's probably not a super important distinction, to be honest.)
I'd want to be sure that this works correctly with:

solvers that evaluate and store the result of .vf(...) directly.
BacksolveAdjoint
returning "complicated" linear operators like lx.JacobianLinearOperator.

In principle all of those things should be solvable -- Diffrax allows the result of the vector field to be arbitrary -- I just think we'd want to explicitly test them.
I'd be happy to take a pull request on this!

I have a branch started for this, but I want to know the scope of the change you are looking for here. Having spent (a little) time thinking about it I see a couple options, in increasing impact on the package

I can add support to ControlTerms to allow linear operators, which would really reduce the complexity of https://github.com/patrick-kidger/diffrax/pull/402, without changing much or adding many LoC (and introduce no breaking changes). This could be a weird edge case, like oh you can do weaklydiagonal or also just lx control (maybe not a big deal)
Control terms must return linear operators (or maybe allow operators and arrays), this means the weaklydiagonal term is gone/deprecated and can be totally removed from the package (breaking change) and everything is just control terms with specifications (might require some work in term checking, but probably doable)
Everything just becomes a linear operator (every f(y) dx), which means all vector fields are now this way. This would include removing weaklydiagonal and changing existing terms (and would introduce breaking changes across the board). Seems like a very substantial refactor of the core of the Term design

I'm sure there are more nuanced or totally different options, but I'm just looking to get a feel on the scope you want with this change so I don't do a lot of unnecessary work.

For context, the simplest sort of approach to 1. is shown in https://github.com/patrick-kidger/diffrax/pull/434 (needs more tests/docs/whatever but the core idea of just making minimal change to allow lineax in control terms is there)

I really like the look of #434! I think this is pretty much exactly what I had in mind.
I think if we were designing from scratch then we'd probably go with option 2*, but since that's not the reality we live in, then I think maintaining backward compatibility is worthwhile.
That said I think it might be worth marking WeaklyDiagonalControlTerm with a PendingDeprecationWarning, just to gently encourage people to use this new thing instead. (And perhaps also remove it from the generated docs?) Subclassing terms to create new matrix-vector interactions was always an advanced thing to do, so I like that this new approach simplifies and standardises that.
* Why not option 3? I think we'd still need the AbstractTerm abstraction as a wrapper around lx.AbstractLinearOperator, because we need a way to wrap up multiple terms into one, and a place to put controls. Not a strong feeling though.


runtime/trace: failure with SIGSEGV (and no other output) on linux-ppc64-buildlet

signal: segmentation fault (core dumped)
FAIL	runtime/trace	2.104s

greplogs -l -e 'signal: segmentation fault \(core dumped\)\nFAIL\s+runtime/trace' --since=2022-01-01
2022-09-06T15:49:30-c35bc69/linux-ppc64-buildlet
(CC @golang/runtime @golang/ppc64)

Hmm, the fault in gentraceback suggests a possible connection to #50144, although that could also be an independent bug with a similar failure mode. 🤔

At the point of failure, I see that, gp.m == nil caused the fault in if flags&_TraceJumpStack != 0 && gp == gp.m.g0 && gp.m.curg != nil .

@cherrymui, this is 2 commits prior to that patch.
Though, if gp.m is nil, won't this still segfault when executing gp == gp.m.g0?

That check is guarding on the previous loop. i.e., in the previous loop gp.m.curg.m == nil. Once we set gp = gp.m.curg, then then next iteration will crash on gp.m.g0.

I am not able to reproduce this with CL 428655. I think this has been fixed by CL 428656.


faceting: round 2

An improvement of the MVP

[x] Support of histograms
[ ] Display word frequency

Closing this epic since we have completed the work for this. One remaining issue that doesn't need to be part of this epic.


Repositories: fix lint warning react-hooks/exhaustive-deps with adding useCallback hook

this commit fix the exhaustive-deps by adding the useCallback hook.
after adding the missing dependencies to the useEffect,
I fix this problem that we have  -'The 'initializeRepositories' function makes the
dependencies of useMemo Hook (at line 256) change on every render.'
Move it inside the useMemo callback. Alternatively,
wrap the definition of 'initializeRepositories' in its own useCallback() Hook  react-hooks/exhaustive-deps'

The Repositories step PR https://github.com/RedHatInsights/image-builder-frontend/pull/1569 will simplify the structure of the step and some of the code in this PR may no longer be applicable.
My proposal would be to set this one as blocked for now and after https://github.com/RedHatInsights/image-builder-frontend/pull/1569 gets merged let's rebase and see what could be updated.

Ok, the blocking PR is merged. Would you like to rebase this one so we can see if anything needs updating? :)

The code looks good, the changes follow the linter suggestions, but the suggestions seem to be unreliable specifically for the exhaustive-deps rules :thinking: We should keep an eye on those.
I've ran into a bug, could you try if the behaviour is the same for you?

in stage-beta open the old Wizard
click through to the Repositories step (what you choose on the other steps shouldn't matter)
select any repository
the Next button should get immediately disabled
unselect the repository
the button is still disabled even if you try to click back through the steps and the Wizard needs to be refreshed to enable it back

Repositories unavailable now so I chant check this but
The Content service cannot be reached, please check back later.

https://github.com/osbuild/image-builder-frontend/pull/1662 was merged, unblocking

Closing this as so much has changed since this was originally authored.


[BUG]: Reactivity for variation does not work

Description of the bug
When rendering the icon, the variation prop is not reactive.
e.g.
<script>
  import { Map } from 'svelte-heros'
  let isSolid = false
</script>

<Map on:click={() => isSolid = !isSolid} variation={isSolid ? 'solid' : 'outline'}/>

You'l notice that changing the variation after initial render does not cause the variation to change.
I think the fix is as simple as adding $: to the switch(variation) { line in each .svelte file.
e.g.
<script >export let size = "24";
export let color = "currentColor";
export let variation = "outline";
let svgpath;
let svgoutline = `...`;
let svgsolid = `...`
$: switch (variation) {
    case "outline":
        svgpath = svgoutline;
        break;
    case "solid":
        svgpath = svgsolid;
        break;
    default:
        svgpath = svgoutline;
}
export let ariaLabel = "map";
</script>

Steps To Reproduce
See description
Additional Information
No response

Thanks for the issue. I updated it.
Please let me know what you think.

Close the issue for now.


API (Security)

As a developer I will have a secret code so that my mailing list will be secure.

Current plan is to check this against the OWASP top ten - https://www.owasp.org/index.php/OWASP_Top_Ten_Cheat_Sheet.

[ ] Injection
[ ] Session management
[ ] XSS cross site scripting vulnerabilities
[ ] Insecure direct object references
[ ] Security misconfiguration
[ ] Sensitive data exposure
[ ] Function level access control
[ ] Cross site request forgery
[ ] Libraries with known vulnerabilities
[ ] Unvalidated redirects and forwards


Troubleshoot latency in Cloud Bigtable C++ Client

Most of the time a client talking to the production server experiences very high latencies, in the order of 80ms [*].  The objective of this bug is to isolate the problem, if necessary file bugs with other components, or determine what needs fixing in the Cloud Bigtable C++ Client.
[*]: In this bug we will try to consistently use ms == milliseconds, and μs == microseconds.

@coryan Thanks for the detailed investigation. Recently, I also noticed there's performance degradation in the cloud bigtable c++ client. By any chance, have you or the grpc team figured out the root cause?


The Carpentries Governance Model by Diana OFODU

Name: Diana OFODU (she/her)
Project: The Carpentries (https://carpentries.org/)
Link to The Carpentries governance model: https://carpentries.org/governance/
The governance model of The Carpentries consists of rules set by the executive council. The council is responsible for determining the organization's mission, maintaining and updating bylaws, selecting and evaluating the executive director, strategic planning, financial management, identifying revenue streams, program approval, public image enhancement, and self-assessment. The executive director serves as the Chief Executive Officer and their actions are overseen by the executive council.
The executive council is made up of nine members; four of whom are elected by the community members (community-elected members) and five are elected by the executive council (council-elected members). Though they strive for transparency in their activities, some things are still kept to themselves.
Project roles
There are three major project roles:

Instructor
Trainer
Maintainer

In addition to the formal roles, there are different committees which make up of the executive council members in charge of various operations, for example:

Officers Committee
Governance Committee
Finance Committee
Program Committee

Decision-making process
Voting is done yearly and the Executive Director is exempted from it. There are four sets of people who are eligible to vote. These individuals are considered active in the community. They include those who completed an Instructor or Trainer certification within the past year, those who completed it within the last two years and have taught at least one Carpentries workshop, those who are certified instructors or trainers and have taught at least two Carpentries workshops in the past two years and those who have participated in a committee as a mentor or maintainer in the past year.
To approve an appointment or removal of any party, a majority of votes by the executive council is required.
How easy or difficult was it to find and understand the governance model?
It was not difficult for me to find the governance model as there was a button that clearly stated what I was looking for. The amazing thing was that I was going down a rabbit hole of information just like I usually do when I start binge-watching videos on YouTube. I understood it pretty well although it was my first experience with governance models and was not sure if I was getting the correct information.

@arliss-NF what do you think about this? Kindly share your thoughts and anyway I can improve.


The -W flag means -Wextra

Hi --
The -W flag is a (allegedly deprecated) synonym for -Wextra. Both gcc and clang recognize -W.
lacc however will complain that -W is missing an argument. This PR teaches lacc about -W. It still may be the case that -Wextra gets ignored for now, but that's preferable to a compiler error.

This change made me realize that the option parsing code does not need to support "flags", allowing things like -Sv to mean assembly plus verbose. Removing that functionality, we can add -W as a normal option instead of hacking argparse.c


Empty material-ui-number-input folder in node_modules

When I install this package he is empty. Why?

Yea sry I've created a dummy version yesterday to sync github and npm versions but forgot to run a command before publishing. My my apologies. I've fix it: https://github.com/NoHomey/material-ui-number-input/blob/master/CHANGELOG.md#v5019.


Update bootstrap.php

Fix Fatal error: Uncaught Error: Class 'CodeIgniter\Config\Services' not found
Description
After synchronizing the latest code, the access system reports an error.
( ! ) Fatal error: Uncaught Error: Class 'CodeIgniter\Config\Services' not found in E:\webroot\app\Config\Services.php on line 18

Fatal error: Uncaught Error: Class 'CodeIgniter\Config\Services' not found

already handled in PR https://github.com/codeigniter4/CodeIgniter4/pull/2977


fix(readme): pass README.md to stdin in the example

The command shown in the GIF doesn't match the one written out in the readme.

Thank you for this!


Update bugsnag (v1 to v2)

Hi
That's a very quick/simple PR in order to use the very last version of bugsnag-node, as it fixes a significant amount of bugs since the v1.12.
I also tried to ensure that no project would break because of a property renamed in v2.1.2.
Please let me know if I can do anything else.

@niftylettuce Do you have any opinion about this PR? Thanks :)!

I built Cabin as an alternative, see https://cabinjs.com.


RUMM-3216 use jank stats

What does this PR do?
Use the JankStats library to get the actual frame durations.
Motivation
Using the Choreographer like we did forced a redraw of all frames, which was not necessary if the content didn't require it.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1405 (f0c40b0) into develop (8586d84) will increase coverage by 0.16%.
The diff coverage is 86.49%.

@@             Coverage Diff             @@
##           develop    #1405      +/-   ##
===========================================
+ Coverage    81.94%   82.09%   +0.16%
===========================================
  Files          363      363
  Lines        13031    12974      -57
  Branches      2191     2164      -27
===========================================
- Hits         10677    10651      -26
+ Misses        1688     1668      -20
+ Partials       666      655      -11

Impacted Files
Coverage Δ

...ernal/vitals/JankStatsActivityLifecycleListener.kt
80.00% <80.00%> (ø)

...lin/com/datadog/android/rum/internal/RumFeature.kt
92.54% <100.00%> (-1.03%)
:arrow_down:

...d/rum/internal/domain/scope/RumViewManagerScope.kt
96.15% <100.00%> (+0.77%)
:arrow_up:

.../android/rum/internal/domain/scope/RumViewScope.kt
95.80% <100.00%> (+1.48%)
:arrow_up:

... and 54 files with indirect coverage changes


error on most recent build

building output video
Traceback (most recent call last):
  File "C:\Users\drewd\stammer-main\stammer.py", line 291, in <module>
    main()
  File "C:\Users\drewd\stammer-main\stammer.py", line 287, in main
    process(**vars(args))
  File "C:\Users\drewd\stammer-main\stammer.py", line 255, in process
    build_output_video(frames_dir, outframes_dir, matcher, real_frame_length, frame_length, carrier_framecount, output_path)
  File "C:\Users\drewd\stammer-main\stammer.py", line 117, in build_output_video
    shutil.copy(frames_dir / f'frame{carrier_video_frame+1:06d}.png', outframes_dir / f'frame{video_frame_i:06d}.png')
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Unknown format code 'd' for object of type 'float'

this is seems to be in the same place where the program was trying to generate frames that were beyond the end of the video

This is fixed in latest version, which casts carrier_video_frame to an int as Python expects.


Change circle technique size to metres

This is a draft pull request to solve the issues mentioned in discussion #2256
We aim to:

Allow CirclesTechnique points to be rendered with size measured in metres
Do the above in a way such that backwards compatibility is preserved

This is a draft as I have not been able to successfully scale the CirclesTechnique sizes accurately or preserve the backwards compatibility. Please reach out to me if you can solve these issues

Hi, is there any room for help with this PR?

@LukeParky , sorry, I don't have any update. We created an internal ticket: HARP-16916, but as we have a lot of bugs / features to work on, this may take some time before we can help you on this sorry!


[Kernel] Factor out epilogues from cutlass kernels

This is a straight refactor to the cutlass kernels, to separate the epilogues out of the kernel to allow adding new ones.
In particular, we're planning to define epilogues to handle cases of asymmetric quantization where fusion of the activation zero point terms is important for performance (see https://github.com/vllm-project/vllm/issues/3975).
This PR also renames cutlass_scaled_mm_dq to cutlass_scaled_mm.

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

LGTM. I think some documentation on the contract of what epilogues need to define would be helpful.

I added some comments, although it's really hard to make formal with all of the templating going on


Please consider bumping PyO3 version and re-releasing

Hello, we had an upstream report of a bug from a user who has installed on PyPy 3.10 and run into an incompatibility between PyPy 3.10 and the aging PyO3 version bundled in your 0.2.0 release.
https://github.com/PyO3/pyo3/issues/3590
https://foss.heptapod.net/pypy/pypy/-/issues/4015
I think if you update to latest PyO3 (0.20.0 at time of writing) and re-release, things should work ok.
Thanks in advance, and also for being a user of PyO3 🙏

@arjanz i've created a PR to fix this issue, i have tested it and everything worked correctly.
can we merge this? https://github.com/polkascan/py-sr25519-bindings/pull/20

@alimaktabi Merged, but encountering some issues with an outdated Github action file that is used for deployment to PyPI. I'll have to update that as well.

New wheels released to: https://pypi.org/project/py-sr25519-bindings/0.2.1/

i tried it and worked perfectly with my pypy 7.3.17
Thanks a lot


ign -> gz : Remove redundant namespace references

Part of: https://github.com/gazebo-tooling/release-tools/issues/784

It is now a ONE LINE PULL REQUEST :rofl:


Add missing dependencies to README.md

Fixes #127 (second part).  Also:

Put a space between deploy buttons
Add ask to search-engines
Add link to Open Source Developer Guide and Best Practices at FOSSASIA

NOTE: Travis CI build is broken by #193

Please work together to get two reviews of contributors who approve PRs. Let's work on it. Thanks!


warning: Could not find remote branch v0.35.3 to clone.

I have been trying to install nvm using both the curl and install.sh scripts on OS X High Sierra (10.13.6) and I keep getting the message:
warning: Could not find remote branch v0.35.3 to clone. fatal: Remote branch v0.35.3 not found in upstream origin Failed to clone nvm repo. Please report this!

What version of git are you using? nvm requires v1.7.10 (see the note just above https://github.com/nvm-sh/nvm#git-install)

What version of git are you using? nvm requires v1.7.10 (see the note just above https://github.com/nvm-sh/nvm#git-install)

git version 2.17.2 (Apple Git-113)

The tag is right here: https://github.com/nvm-sh/nvm/tree/v0.35.3 so I’m not sure how it’d be unable to find it. The error comes from here: https://github.com/nvm-sh/nvm/blob/258938ef66a2a49a4a400554a6dce890226ae34c/install.sh#L122
What happens if you try to git clone this repo directly?

I was able to clone it with git clone https://github.com/nvm-sh/nvm.git successfully.

The tag is right here: https://github.com/nvm-sh/nvm/tree/v0.35.3 so I’m not sure how it’d be unable to find it. The error comes from here:
https://github.com/nvm-sh/nvm/blob/258938ef66a2a49a4a400554a6dce890226ae34c/install.sh#L122
What happens if you try to git clone this repo directly?

I was able to clone it with git clone https://github.com/nvm-sh/nvm.git successfully.

I also tried curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.32.1/install.sh | bash as discussed at https://www.codementor.io/@mercurial/how-to-install-node-js-on-macos-sierra-mphz41ekk and it cloned to the ~/.nvm directory, but did NOT create a nvm.sh file.

"nvm itself" is the repo's nvm.sh file, which is part of the clone. (also, v0.32.1 is old, you want v0.35.3).
Perhaps you need to rm -rf ~/.nvm and try reinstalling nvm again?

@ljharb - When I tried curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.35.3/install.sh | bash, it failed on the permissions from github. no such identity: id_XXXX.key: No such file or directory
What do I need to do on the command line to authenticate to github and download everything?

@ljharb  - After figuring out how to authenticate to github, I tried curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.35.3/install.sh | bash
That file, install.sh, does exist.
I got the message:
warning: Could not find remote branch v0.35.3 to clone. fatal: Remote branch v0.35.3 not found in upstream origin Failed to clone nvm repo. Please report this!

https://raw.githubusercontent.com/creationix/nvm/v0.35.3/install.sh definitely exists; you can visit it by clicking the link.
I’m mystified how you would get this error :-/ in the separately cloned git repo, what does git tag print out?

I just ran curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.32.1/install.sh | bash and it ran, but during its running there was the message:
error: pathspec 'v0.32.1' did not match any file(s) known to git.
And then:
=> Appending source string to /Users/xxxx/.bash_profile bash: line 315: /Users/xxxx/.nvm/nvm.sh: No such file or directory
When it finishes, there is no ~/.nvm/nvm.sh file. Running git tag in that directory gives me:
POST-MIGRATE-CONFIG PRE-CONFIG-MIGRATE

https://raw.githubusercontent.com/creationix/nvm/v0.32.1/install.sh works too; the error you’re seeing is from the tags failing to load.
What does git remote -v print out?

For creationix, just:
origin	https://github.com/creationix/nvm.git (push)
No fetch. There are also two origin listings for work sites, a push and a fetch.

you’re inside the nvm git repo, why do you have remotes for your work? Is perhaps your home dir a git repo? If so, that’s the problem :-)

Also, without a fetch remote, you won’t be able to read anything from the repo, which is why you’re not seeing tags.
Another alternative is that you have your work remotes in your global git config, which would also break git usage for any other repo.

I think the problem is that I command line set up global push and fetch origins for my work stuff.

Yes, that breaks git for any other repo. If you fix that, then nvm will work fine.

@ljharb  - I edited my global git config file and ran curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash
Everything seems to have installed. The remote called returned:
origin	https://github.com/nvm-sh/nvm.git (fetch)
origin	https://github.com/nvm-sh/nvm.git (push)

Both git tag and nvm --version return v0.35.3. Its showing as (no branch).

Perfect, it's a tag, so that's all correct.
If you reopen your terminal, nvm should be installed. Happy to reopen if not.

@ljharb  - No. It's installed. Thanks. Sorry for the bother.


Master update

@kobigurk Can we get this merged pronto?

@jon-chuang sure. Next time be sure to tag me or ask for review so I notice :)
I'd merge it, but something is blocking - why is it 2 commits above scipr-lab master?

Might be because of the yml changes + merge conflicts.

Oh I see.
Can we maybe align with Zexe master for this PR?
On Sun, Sep 27, 2020, 17:09 jon-chuang<EMAIL_ADDRESS>wrote:

Might be because of the yml changes + merge conflicts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/celo-org/zexe/pull/9#issuecomment-699640258, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA23MGACXE2YIGQWCSDE3V3SH5BSTANCNFSM4RVXKN7A
.

Not sure how to do that.

Make this one completely reset just to Zexe master, it shouldn't be more than that.
Then in the next PR (the tests + refactor) add the extra commit we already have on our master.

@jon-chuang can you make the change?

It's very confusing to me

To do that, I think we can't do a merge, we must push --force directly to celo-org/zexe/master

tbh I don't really think it matters

It matters because we want to start from a clean slate.


kotlin: fix unit tests and add java tests to ci

We weren't running CI for the java tests previously because they weren't being specified in the CI task
Signed-off-by: Alan Chiu<EMAIL_ADDRESS>Description: kotlin: fix unit tests and add java tests to ci
Risk Level: low
Testing: unit
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

@junr03 could you take another look?


Ensure all API endpoints have 200, 400, 404 responses

User Story
To adopt API best practices and aid API debugging, all endpoints should have multiple responses. We need to add at least 400 (invalid information supplied eg input int in a string field) some 404 (not found) errors to our existing endpoints.

Make this dependent on application testing existing


UIImage cache

UIImage.imageNamed cached. When use a lot of images, cache eating a lot of ram
Apple says :
If you intend to display an image only once and don't want it added to the system’s cache, create it using the [imageWithContentsOfFile:]
Ideal have option, that indicate reusage images
Don't know how fix.

Clear cache at private access.
Maybe don't need to have val(use function) and gc clear it(need to test)
Or provide something like url(if possible)

Sorry, i'm android developer and don't have a lot of expirience to help with ios

Created own UIImage not from generated kotlin object. Clear don't work. Cache depends on lifecycle app

Hello!
In which case did you encounter this problem? When using Compose / UIKit / both?
Can you share reproducer project? It would be very helpful in understanding the problem and finding solution.

Using SwiftUI.
For example :
App contains 30 images
App navigation : Screen1 -> Screen2 -> Screen3. (my case, struct Screen[1,2,3] : View)
Each screen have horizontal pager with unique images
While navigate between pages image load, cached and increase memory
At Screen3, previous screens decomposed, but memory not cleared and contains previously images
Found that
UIImage(named:) caches images, and UIImage(contentsOfFile:) does not.
And when lifecycle goes to background cache of images cleared.
To check ram, used XCode -> Debug Navigator -> Memory -> Memory use

Okay, I see.
As a possible solution, I can add object urls containing URLs to images, so then image can be created using
UIImage(contentsOfFile: Res.shared.image.url.customImage)
Or a new object assets (as part of future raw file functionality), then
UIImage(contentsOfFile: Res.shared.asset.image.customImage)
I prefer the second option as the first one can break backwards compatibility (if project has an image called url).
I'll think about it.

Thanks for help


Snapchat Filters using OpenCV #66

Related Issues or bug

Added a Shiva Tilak Snapchat Filter

Fixes: #66
Proposed Changes

added a new filter

Additional Info

Added another new snap filter using OpenCV

Screenshots

Original
Updated

|

|

@hemanthraj2001   can you please mention the open-source program in which you are participating?

Codepeak

ok


gnocchi deployment: directory /etc/kolla/gnocchi-statsd is not created

osism-kolla deploy gnocchi  fails with the following error message:
2021-03-25 07:35:22,914 INFO ansible: ok: [srv00093] => (item=gnocchi-metricd)
failed: [srv00093] (item=gnocchi-statsd) => {"ansible_loop_var": "item", "changed": false, "checksum": "925f85a40712d03a3d646ace081ef6d629c0860e", "item": "gnocchi-statsd", "msg": "Destination directory /etc/kolla/gnocchi-statsd does not exist"}
2021-03-25 07:35:24,032 ERROR ansible: failed: [srv00093] (item=gnocchi-statsd) => {"ansible_loop_var": "item", "changed": false, "checksum": "925f85a40712d03a3d646ace081ef6d629c0860e", "item": "gnocchi-statsd", "msg": "Destination directory /etc/kolla/gnocchi-statsd does not exist"}
failed: [srv00098] (item=gnocchi-statsd) => {"ansible_loop_var": "item", "changed": false, "checksum": "925f85a40712d03a3d646ace081ef6d629c0860e", "item": "gnocchi-statsd", "msg": "Destination directory /etc/kolla/gnocchi-statsd does not exist"}
2021-03-25 07:35:24,052 ERROR ansible: failed: [srv00098] (item=gnocchi-statsd) => {"ansible_loop_var": "item", "changed": false, "checksum": "925f85a40712d03a3d646ace081ef6d629c0860e", "item": "gnocchi-statsd", "msg": "Destination directory /etc/kolla/gnocchi-statsd does not exist"}
failed: [srv00097] (item=gnocchi-statsd) => {"ansible_loop_var": "item", "changed": false, "checksum": "925f85a40712d03a3d646ace081ef6d629c0860e", "item": "gnocchi-statsd", "msg": "Destination directory /etc/kolla/gnocchi-statsd does not exist"}

Creating the directory /etc/kolla/gnocchi-statsd on the nodes solved the issue.

stats should be disabled by default. I will fix this. As a workaround you can set enable_gnocchi_statsd: false.

Ok thanks!

Looks like there is a bug in kolla-ansible itself. gnocchi-stats Ceph configuration should not be copied when statsd is disabled.

It looks buggy as hell. Following files are not copied to /etc/kolla/gnocchi-statsd:

config.json
gnocchi.conf

Had to do it manually.

That's because of Gnocchi. It was a deprecated service in OpenStack and is not tested.

Oho. But for ceilometer it is still the metrics storage, right?

Upstream fix is on the way: https://review.opendev.org/c/openstack/kolla-ansible/+/782916
Backport for Victoria will be prepared right now.


Improve Logging Handling

Going to use a Papertrailapp trial account to archive week's worth of logs from all services and machines to an easy to use web-based log analyzer. Can filter, search, and configure alerts based on logs. Will evaluate value in the future to expand to a paid account.

@jbradberry Assigning this to you for initial investigation to evaluate what the next action should be. YOu can consult @ironfroggy for details. Looping in @mjstealey and @dtarb as well since they were involved in the discussion that triggered this issue during March all hands meeting.

no longer relevant


get blank image on set worldPosition.z = 0 in vertex block

Describe the bug
I want to draw an image, using the code below, it work great . But when i set worldPosition.z  = 0 in vertex block, i get a blank image. Could you please tell what i miss? thanks in advance!
material {
name : "Image 2dmode_normal",
parameters : [
{
type : sampler2d,
name : texture
},
    {
        type:float,
        name:alpha
    }
],
requires : [
        uv0
    ],
  blending : fade,
  flipUV : false,
  depthWrite : false,
  depthCulling : false,
  culling : none,
  shadingModel : unlit

}
vertex {
void materialVertex(inout MaterialVertexInputs material) {
material.worldPosition =float4(material.worldPosition.x,material.worldPosition.y,0.0,material.worldPosition.w)
}
}
fragment {
void material(inout MaterialInputs material) {
prepareMaterial(material);
float4 texel = texture(materialParams_texture, getUV0());
    float4 outputColor =float4(texel.rgb * materialParams.alpha, texel.a * materialParams.alpha);
     material.baseColor = outputColor;
}

}
Smartphone (please complete the following information):

Device: huawei mate
OS: android 6.0

Normally that's used as an input variable rather than an output.  Also it is more of a "view-space position" than a world-space position (look for getWorldOffset in our materials document).
If you want to flatten your geometry it might be better to scale it using TransformManager, or set a custom projection matrix in Camera.


x-axis values not rendered properly for real-time chart

Codepen

Explanation

What is the behavior you expect?
I would expect that in the x axis the sampling time of each values is rendered with the format ('HH:mm:ss')

What is happening instead?
In the codepen nothing is rendered, but on my MAC at each x-axis tick appears the time in milliseconds instead of the selected format. I tried also to uses a custom formatter (with and without moment.js) but my impression is the the formatting callback is never invoked.
The tooltip is update correctly.

Interestingly, there are also a couple of other issues related with this codepen. If you look at the init method where I update the time series, you will see that I use both an array push and the updateSeries method. updateSeries could seem redundant but it is necessary, otherwise there is a lag between the update of the marker points and of the graph line (i.e. first are shifted forward the marker points and then the graph lines). I also tried to use the updateSeries method applying the spread operator to the series array and then adding at the end a new data point but it does not work (the graph lines are not correctly updated)

What error message are you getting?
I don't get any error, the application does not crash and the graph looks fine, only the x-axis is incorrect.

Hope this could help to solve this issue and thank you so much for sharing this fantastic charting library.
Best regards,
Gianluca Cornetta

Can you please create a codepen and provide a link for it?
It will be helpful to directly jump into the issue if I see a working demo.

Hi the codepen was in my previous comment; however I have just realised it was incomplete.
This is the URL:
https://codesandbox.io/s/vue-basic-example-ssl8r?fontsize=14
and just for security here comes again the full code:


No implementation found for java.nio.ByteBuffer com.badlogic.gdx.graphics.g2d.Gdx2DPixmap.load

Issue details
No implementation found for java.nio.ByteBuffer com.badlogic.gdx.graphics.g2d.Gdx2DPixmap.load
Is it because the gdx version does not match?
Do I need to import other so files manually?
Reproduction steps/code
TextureRegion(Texture(AssertFileHandle(context,"btn_summon.png")))

class AssertFileHandle(
    private val context: Context, private val fileName: String
) : FileHandle(fileName, Files.FileType.Internal) {

    override fun read(): InputStream {
        try {
            return context.assets.open(fileName)
        } catch (e: IOException) {
            throw RuntimeException(e)
        }
    }
}

Version of libGDX and/or relevant dependencies
implementation "com.badlogicgames.gdx:gdx:1.12.1"
Stacktrace
java.lang.UnsatisfiedLinkError: No implementation found for java.nio.ByteBuffer com.badlogic.gdx.graphics.g2d.Gdx2DPixmap.load(long[], byte[], int, int) (tried Java_com_badlogic_gdx_graphics_g2d_Gdx2DPixmap_load and Java_com_badlogic_gdx_graphics_g2d_Gdx2DPixmap_load___3J_3BII)
                                                                                at com.badlogic.gdx.graphics.g2d.Gdx2DPixmap.load(Native Method)
                                                                                at com.badlogic.gdx.graphics.g2d.Gdx2DPixmap.<init>(Gdx2DPixmap.java:84)
                                                                                at com.badlogic.gdx.graphics.Pixmap.<init>(Pixmap.java:188)
                                                                                at com.badlogic.gdx.graphics.TextureData$Factory.loadFromFile(TextureData.java:101)
                                                                                at com.badlogic.gdx.graphics.Texture.<init>(Texture.java:122)
                                                                                at com.badlogic.gdx.graphics.Texture.<init>(Texture.java:114)

Please select the affected platforms

[√] Android
[ ] iOS
[ ] HTML/GWT
[ ] Windows
[ ] Linux
[ ] macOS

I don't see any ApplicationListener type, so if that's your entire code, you aren't in the libGDX lifecycle. You should try to follow one of the first-step tutorials, such as https://libgdx.com/wiki/start/project-generation . The project setup tool (gdx-liftoff) manages the dependencies on things like the libGDX native libraries, where that mentioned Gdx2DPixmap method is implemented. The lifecycle ensures those libraries are loaded before you use them.
If you do have a class that extends Game or ApplicationAdapter, or implements ApplicationListener, then you should show that. The issue could also be in your Gradle dependencies. Following the tutorial should avoid these issues.

You are using spine-android, which only depends on gdx core. spine-android does not support developing libGDX applications. Your code triggers loading of libGDX shared libraries which are not part of your Android project' dependencies, nor does your code trigger setup loading of the shared libraries.
If you want to do libGDX things, you will need to create a libGDX app and use spine-libgdx. If you want to do Android stuff with Spine, use spine-android and don't touch any libGDX APIs.


Update schema checker and output info/warning level messages visually

This PR updates schema checker, which for the first time returns infos and warnings, and then updates codegen to allow the various generators we use within it, to also return warnings and infos should they so desire.

/test verify-crd-schema
/test verify

/test verify-crd-schema
/test verify

/test verify-crd-schema
/test verify

/test verify-crd-schema
/test verify

----- config.openshift.io ----- v1 ----- config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-CustomNoUpgrade.crd.yaml -----
----- SCHEMACHECK -----
ERROR: ^.properties[spec].properties[platformSpec].properties[baremetal].properties[apiServerInternalIPs].items: Forbidden: estimated rule cost exceeds budget by factor of 1.8x (try simplifying the rule(s), or adding maxItems, maxProperties, and maxLength where arrays, maps, and strings are declared)
WARN: ^.spec.platformSpec.baremetal.apiServerInternalIPs: Array has unbounded maxItems. It will be considered to have 1048575 items. Consider adding a maxItems constraint to reduce the raw rule cost.
WARN: ^.spec.platformSpec.baremetal.apiServerInternalIPs[*]: Field has unbounded cardinality. At least one, variable parent field does not have a maxItems or maxProperties constraint: ^.spec.platformSpec.baremetal.apiServerInternalIPs. Falling back to CEL calculated worst case of 1048576 executions.
INFO: ^.spec.platformSpec.baremetal.apiServerInternalIPs[*]: Rule 0 raw cost is 17. Estimated total cost of 17825792. The maximum allowable value is 10000000. Rule is 178.26% of allowed budget.

New output demonstrated in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2093/pull-ci-openshift-api-master-verify-crd-schema/1856782506544599040, except, with colours in prow.
Errors still collated at the bottom, but at least now errors and warnings are all together and not mixed in among the rest of the logs

/label acknowledge-critical-fixes-only
No effect on payload, tooling only


BUG: Fix bug extracting meas_date

Closes #10147
Turns out that localized dates is a pain in Python, and solving it in a general way requires a lot of work and/or additional dependencies. This implements a simpler solution: use a script to make a dict of translations and try them all. It's quick to execute, and easy enough to generate the dict of translations that we need.
@mlrocca feel free to try this branch (or just wait until it's merged into main and try that), it should fix your bug.
@rob-luke feel free to review and merge if you're happy

This is crazy!
And what about all other locales? Like, there must be dozens more?

Yes, there are many, many more locales. But we can deal with that later if we need to

let's move on here. thx @larsoner

Thanks @larsoner!
My comment was not meant to urge you to add more locales now, I was merely interested if there'd maybe need to be more in the future :)

Awesome! Thanks @larsoner

Hi @larsoner,
thank you for this answer but I am not sure to have understood how to go on.
should I find these files (latest.inc,config.py and so on) on my laptop and replace with the codes in the links that you shared with me?
What should I do with patch links?
Thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy

On 31 Jan 2022, at 19:52, Eric Larson @.***> wrote:
mne/io/nirx/tests/test_nirx.py https://github.com/mne-tools/mne-python/pull/10277/files#diff-3fda559feb3fb4c8d2fcb27653b2abf70d19baa18c992bc58721256693d57060

The easiest thing to do now that this has been merged is something like
pip install --upgrade https://github.com/mne-tools/mne-python/zipball/main

it will install the latest version of the main branch (1.0.dev0), where this PR was merged.

Thank you, it worked.
Is it possible after some MNE processing (like corrected_raw = temporal_derivative_distribution_repair(raw_od)
) to save again the file in nirx format.
I am searching a command like mne.io.read_raw_nirx but to export the file.
Tank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy

On 2 Feb 2022, at 18:43, Eric Larson @.***> wrote:
The easiest thing to do now that this has been merged is something like
pip install --upgrade https://github.com/mne-tools/mne-python/zipball/main
it will install the latest version of the main branch (1.0.dev0), where this PR was merged.
—
Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-python/pull/10277#issuecomment-1028190249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW6ZCD3JI7XDHTQAAVDYBVDUZFUKTANCNFSM5NHCPFLQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.

Not to NIRx, but you could try writing to SNIRF using MNE-NIRS
https://mne.tools/mne-nirs/generated/mne_nirs.io.snirf.write_raw_snirf.html#mne_nirs.io.snirf.write_raw_snirf

Dears,
Is it possible to add the feature to export processed data into nirx?
That would be awesome,
Thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy

On 15 Feb 2022, at 17:11, Eric Larson @.***> wrote:
Not to NIRx, but you could try writing to SNIRF using MNE-NIRS
https://mne.tools/mne-nirs/generated/mne_nirs.io.snirf.write_raw_snirf.html#mne_nirs.io.snirf.write_raw_snirf https://mne.tools/mne-nirs/generated/mne_nirs.io.snirf.write_raw_snirf.html#mne_nirs.io.snirf.write_raw_snirf
—
Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-python/pull/10277#issuecomment-1040468671, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW6ZCD4Q6V35PH4OHB6BM23U3J3MRANCNFSM5NHCPFLQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.

Hi @mlrocca,
Exporting as nirx format is not something that is planned. The nirx format has been superseded by SNIRF as larsoner mentioned. New NIRX devices actually export as SNIRF natively now. Further, the nirx format is not documented and does not support exporting as OD or haemoglobin.

Thank you,
it makes totally sense.
Then, I will try to continue to use MNE also for the analyses. I really like MNE but I am not really familiar with that.
I would need to define contrast and find statistical differences between two groups patients and controls during finger tapping task. Is there a tutorial to do this? I found how to analyze the differences between two conditions here
https://mne.tools/mne-nirs/auto_examples/general/plot_12_group_glm.html#sphx-glr-auto-examples-general-plot-12-group-glm-py https://mne.tools/mne-nirs/auto_examples/general/plot_12_group_glm.html#sphx-glr-auto-examples-general-plot-12-group-glm-py
but I can’t find group level analyses between two groups.
Could you help me?
Thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy

On 17 Feb 2022, at 01:20, Robert Luke @.***> wrote:
Hi @mlrocca https://github.com/mlrocca,
Exporting as nirx format is not something that is planned. The nirx format has been superseded by SNIRF as larsoner mentioned. New NIRX devices actually export as SNIRF natively now. Further, the nirx format is not documented and does not support exporting as OD or haemoglobin.
—
Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-python/pull/10277#issuecomment-1042436645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW6ZCD334LP3IDIEE7AJZTTU3Q5NLANCNFSM5NHCPFLQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.

@mlrocca this sounds more like a usage question, and we try to stick to code bugs and enhancement requests on GitHub. Could you please post your question to https://mne.discourse.group/ instead?

Of course,
thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy

On 17 Feb 2022, at 12:57, Eric Larson @.***> wrote:
@mlrocca https://github.com/mlrocca this sounds more like a usage question, and we try to stick to code bugs and enhancement requests on GitHub. Could you please post your question to https://mne.discourse.group/ https://mne.discourse.group/ instead?
—
Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-python/pull/10277#issuecomment-1042874043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW6ZCD2WKZMPTQTTW4HP4FLU3TPENANCNFSM5NHCPFLQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.


Bug: Provide /etc/os-release in nixpkgs/nix:nixos-*

Describe the bug
There is currently no /etc/os-release file inside the docker images nixpkgs/nix:nixos-*.
Certain tools rely on this file to be existing. It would be nice if that file can be provided.
Steps To Reproduce
 docker run -it nixpkgs/nix:nixos-23.11 cat /etx/os-release

Expected behavior
A /etc/os-release file should be available.
Notify maintainers
I am not sure where the maintenance of this is located.

Add a :+1: reaction to issues you find important.

These Docker images are not managed in Nixpkgs.
https://github.com/nix-community/docker-nixpkgs
(It's a separate namespace, so I sadly cannot transfer this isssue.)


Upgrade to AutoMapper 5.0.2 issue

I'm trying to upgrade my project from AutoMapper 4.1.1 / AutoMapper.Collection 1.1.2 to AutoMapper 5.0.2 / AutoMapper.Collection 2.0.1. I have a scenario which works fine with old dlls and I get unexpected null as a result of mapping with new dlls.
Gist with issue code.
Is this a bug  or  I am missing something?

I think this is a bug with AutoMapper 5.0.2 and you need to upgrade that.  When source or destination are null it defaults back to the CollectionMapper in AutoMapper to do the mapping.
I know Collection mapping has been updated recently in AutoMapper.

For the latest AutoMapper 5.1.1:
System.MethodAccessException at Mapper.Initialize:
"AutoMapper.Mappers.EquivlentExpressionAddRemoveCollectionMapper.IsMatch(AutoMapper.TypePair)" couldn't get access to "AutoMapper.Configuration.PrimitiveExtensions.IsEnumerableType(System.Type)"
Any thoughts on this?

I'll try to make a build that fixes it that works in 5.1.1 by the end of the week.

2.1.0 Should fix this issue.
Removed as much of AutoMapper's internal code I was using before, so hopefully only refactors of the API will only require updates.

Yes, there's no exception with 2.1.0. But null as a result of mapping is still there. I think I'll try to create an Automapper issue.

I am here again. AutoMapper issue.
@lbargaoanu :

Then I guess @TylerCarlson1 should help you here.

What should I do know? This is getting weird a bit.

I'll have to look into it some more then.

Yea when updating the logic changed and the null check changed and caused the functionality to break for nulls.

2.1.1 should fix the original issue.  Wrote unit tests for it.

Everything is OK now, thank you.


Random Battle: Reject Technician with Natural Cure + Rest

Affects Roserade and ensures that it does not receive Chesto Berry.

Hmm, alternatively, reject Hidden Power with Rest. What Rest Pokemon would want Hidden Power taking up a slot?

http://hastebin.com/egijapupub
The only other is Suicune, who definitely doesn't want HP Grass with RestTalk. So yeah, I'd say change this to reject Hidden Power if the Pokemon has Rest.

A fix.
Suicune was already protected from RestTalk HP Grass because Hidden Power already had a rejection condition in RestTalk, which I simply changed to checking for Rest.


fix #64 Add CAPABILITY_AUTO_EXPAND for SAM

Issue #64 , if available:
Description of changes:
Add CAPABILITY_AUTO_EXPAND for SAM
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@groverlalit please review

This feature has been released.


comparator instance support

also noticed that we did not have get_allocator() in some sketches, and added that

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 9 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 93.959%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
2224

Relevant Lines:
2367

💛  - Coveralls


Remove generated code from repo & remove images in npm repo

Remove the lib folder since it's not necessary in the repo
Added a prepublish task to force build before publishing a new version
Removing examples from npm repo close #40

@jossmac this looks good to me

There is a reference to the lib directory in package.json:
"main": "lib/Lightbox.js"
Also react-images uses react-component-gulp-tasks module which by default adds lib tasks
https://github.com/JedWatson/react-component-gulp-tasks/blob/master/index.js
Why is there the lib and dist directory?  Is it necessary to have both?  @JedWatson

Sorry I didn't get to this sooner, I've been busy and this repo has suffered for it.
Whilst I'm good at UI/UX, I'm not confident with build processes and used react-component-gulp-tasks because it was an out-of-the-box solution.
@pradel If you have a tidier solution I would love your help. Would you be open to that?

I am on holiday for a few days but when I come back I will work on that :smile:

Guess I missed this discussion.
For my projects I use nwb which seems to generate a pretty clean projet and npm publish. It used to be stuck with Babel 5 but got updated 4 days ago and now defaults to Babel 6.
It's kind of like create-react-app but it has multiple project types, and I use nwb new react-component. It gives you the src folder, webpack+babel with hot reloading, unit tests, and a documentation folder. A bit slow to install as it installs phantomjs for the tests.
Might do a quick test today I guess ^^

Here's a fork which uses nwb : https://github.com/GregoryPotdevin/react-images/tree/nwb-build
The main issues I ran into :

nwb has it's own template for the demo's index.html, so all the HTML needs to be in react. Not perfect but works well
not sure why but the umd bundle was including all of React. I had to declare react-addons-css-transition-group as 'external' to prevent Webpack from pulling in React

Apart from that, the demo works fine, with hot reloading. The tests are ready to use (but I haven't added any yet). The npm package is really clean, only the required files are sent (lib, es, and umd folders).

outdated pr :)


[chart/redis_ha][REQUEST] Small improvements

I have a couple of small requests, most of which I could make a PR myself on, but I'd like to hear from maintainers first. :)

Our K8s cluster requires containers to define a readinessProbe. None of the containers in this chart do that right now. The readiness probe could just be the same ping that the livenessProbe does. I had to fix that on my fork and I'd love to make a PR on that.

Network policy - While those are not explicitly enforced they are mandated for our production environment. I can of course create one outside of this chart, but it'd be nice to have it as part of it. The chart could define a label that pods allowed to connect Redis/HAProxy must have in order to be allowed. I am however unsure exactly how the HAProxy <-> Redis connectivity works so not 100% on how to define the policy correctly (In our deployment we skipped HAProxy).

I have noticed that the cluster is in an incorrect state if you configure it with:

redis:
    tlsReplication: true
    tlsPort: 6380
    port: 6379
  sentinel:
    tlsReplication: true
    tlsPort: 26380
    port: 26379
    auth: true
    existingSecret: <redacted>
    authKey: redis-password
    config:
      down-after-milliseconds: 5000
      failover-timeout: 10000
      parallel-syncs: 5
      maxclients: 10000
  auth: true
  existingSecret: <redacted>
  authKey: redis-password
  tls:
    secretName: <redacted>
    certFile: redis-crt
    keyFile: redis-key
    caCertFile: root-ca

The problem occurs when both port and tlsPort are defined. The Sentinels attempt to communicate with each other on the non-TLS port and that does not succeed. After down-after-milliseconds time all Sentinels assume the other Sentinels are gone. Thus they can never reach a quorum and perform a successful failover. After I reconfigured with:
  redis:
    tlsReplication: true
    tlsPort: 6380
    port: 0
  sentinel:
    tlsReplication: true
    tlsPort: 26380
    port: 0

Things started working properly. I'm not sure what is the intention here, but at least some documentation warning that such misconfiguration is possible would be nice.

@haljin

I have just merged a readinessProbe PR that should do what you've asked (I think).
There's an issue here with a good example: https://github.com/DandyDeveloper/charts/issues/83 which I do agree with now. Would welcome contributions from someone actively using them. If not, I'll add it to my todo.
This looks to be an artifact of the recent addition of the tls implementation. I thought Redis / Sentinel would prio port but seems to not be the case. That'll need fixing for sure. Thank you for the workaround in the meantime.

Awesome, thanks!
Here's a network policy I made for our deployment (note that redis-ha is the dependency chart to this one) :
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: {{ .Release.Name }}-redis-policy
spec:
  podSelector:
    matchLabels:
      release: {{ .Release.Name }}
      app: redis-ha
  policyTypes:
    - Ingress
    - Egress
  ingress:
    - from:
      - podSelector:
          matchLabels:
            release: {{ .Release.Name }}
            app: redis-ha
      ports:
        - port: {{ .Values.redis-ha.tlsPort }}
          protocol: TCP
        - port: {{ .Values.redis-ha.sentinel.tlsPort }}
          protocol: TCP
    - from:
      - podSelector:
          matchLabels:
            app: {{ .Release.Name }}
      ports:
        - port: {{ .Values.redis-ha.tlsPort }}
          protocol: TCP
        - port: {{ .Values.redis-ha.sentinel.tlsPort }}
          protocol: TCP
    - from:
      - podSelector:
          matchLabels:
            release: {{ .Release.Name }}
      ports:
      - port: {{ .Values.redis-ha.metrics.port }}
        protocol: TCP
  egress:
    - to:
      - podSelector:
          matchLabels:
            app: redis-ha
            release: {{ .Release.Name }}
      ports:
        - port: {{ .Values.redis-ha.tlsPort }}
          protocol: TCP
        - port: {{ .Values.redis-ha.sentinel.tlsPort }}
          protocol: TCP
    - to: []
      ports:
        - port: 53
          protocol: UDP

This is without HAProxy however, as we are not using that and I am not quite sure what does that require

@haljin Are you able to make a PR including this to review?

I'm cooking up a draft


chore: update redo-typo-pr to squash multi-commit PRs

The current typo PR script only rewrites the last commit on the typo PR branch which allows it to be evaded by just having multiple commits in your typo PR. This PR squashes the branch into a single commit before updating the commit author to aztecbot to address this.

Thanks, this bothered met oo

Note that this can result in issues when the typo PR is out of date. Merging master into it will fix it.


Fix styling for confirmation error links.

link_does_not_exist.html

Resolved #7193
That's how link_does_not_exist.html gets displayed. I've intended link_expired.html and link_malformed.html to be displayed with similar styling but I wasn't able to test and see for myself how these two pages are displayed in my development environment, so if someone could help me out there I'd appreciate it!

Thanks @utkarsh23!
You could use the image we have at https://chat.zulip.org/badlink for link not found, and the one for 500 errors for malformed link. And then maybe find an image of an empty hourglass for link expired?
If you read the code in confirmation/models.py that should give some hints on how to get the other pages.

I'm not able to figure out how to view the expired and malformed links, but I think it should work out fine since it is very much similar to link_does_not_exist.html.

link_does_not_exist.html

link_expired.html

link_malformed.html

Please review this PR :)

@utkarsh23 I posted one comment on the code.  Also, visually, I think we need to make these boxes wider or use a smaller title text size (the first 2-3 lines in title text size feel badly line-wrapped)

@timabbott Thanks for reviewing :)

I read your comment on the code below and I've removed this code since it may affect other webpages.

.app-main {
    padding: 0px;
}

I reduced the title text size 40px -> 35px. I feel that visually, the webpages look fine but if you'd like more changes please do let me know.

link_does_not_exist.html

link_expired.html

link_malformed.html

This looks great @utkarsh23 !  I merged this, after splitting the font size change into its own commit and expanding the commit messages.  You can look at 2e6b65ac227435cb2b964ce148ef1ad4ff0d2bd2 and the commit before it to see how these commits should have read.
Check out our commit guidelines for more details.
Thanks for fixing this!

Alight yeah :+1:
Thanks @timabbott ! :)


fix(syntax): DiffAdd/DiffDelete consistency

Fixes #233

Quick pic (of "After", see issue for "Before"):

Thank you, I will test it!

nvim -d also looks good to me

nightfox for reference:


How to: Building for non-programmers users?

[x] Using latest version as provided on the master branch
[x] Searched for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug
[ ] Feature Request
[x] Question
[ ] Other

Description

I would like to compile the spotfydl to use as a command line program on computers without python installed (for non-programmers). How could I do that?
Log

For example with PyInstaller. Two of the three major OS have Python installed by default (macOS and most Linux distros), and these are used by non-programmers too, so there's no relation between that - just saying.


[WIP] Card header improvements

Note: Making changes to this PR after the discussion mentioned below, do not review yet.
~- do not make headerColor a static property (if a card has headerColor property, each instance can set a different header color)~ --> after discussing this with Chris, Luke, Ian, we decided to keep this static property. Instead, each newly generated app will be a subclass and will be able to specify their own static headerColor.

if card is buried in the stack, do not keep it full-width

Closing since updates are covered in #1460


[Broker Clean up] Decouple broker from transport package

Change BrokerRequestHandler to an interface
Move all transport package related classes into ConnectionPoolBrokerRequestHandler implementation
Enhancing broker query log to include servers and exceptions info
Query log example:
2018/08/22 16:53:53.816 INFO [com.linkedin.pinot.broker.requesthandler.ConnectionPoolBrokerRequestHandler] [] Request 7 ScatterGatherStats: <IP_ADDRESS>_O=0,0,0,62
2018/08/22 16:53:53.816 INFO [com.linkedin.pinot.broker.requesthandler.BaseBrokerRequestHandler] [] Request 7:myTable_OFFLINE, time:100ms, docs:10000/44673408, entries:0/80000, servers:1/1, exceptions:0, query:select * from liAdsPacing limit 10000
Explaination: first line is the ScatterGatherStats, second line includes tableName, queryTime, numDocsScanned/numTotalDocs, numEntriesScannedIn/PostFilter, serverResponded/Queried, numExceptions, query

Codecov Report

Merging #3105 into master will decrease coverage by 0.13%.
The diff coverage is 84.65%.

@@             Coverage Diff              @@
##             master    #3105      +/-   ##
============================================
- Coverage     70.24%   70.11%   -0.14%
  Complexity        4        4
============================================
  Files           936      937       +1
  Lines         43520    43499      -21
  Branches       5901     5897       -4
============================================
- Hits          30572    30499      -73
- Misses        10896    10953      +57
+ Partials       2052     2047       -5

Impacted Files
Coverage Δ
Complexity Δ

...t/common/response/broker/BrokerResponseNative.java
85.91% <ø> (ø)
0 <0> (ø)
:arrow_down:

...pinot/broker/broker/BrokerAdminApiApplication.java
94.44% <100%> (+0.15%)
0 <0> (ø)
:arrow_down:

...n/pinot/broker/api/resources/PinotBrokerDebug.java
55% <50%> (ø)
0 <0> (ø)
:arrow_down:

...roker/requesthandler/BaseBrokerRequestHandler.java
79.06% <79.06%> (ø)
0 <0> (?)

...kedin/pinot/broker/broker/BrokerServerBuilder.java
87.09% <88.46%> (-0.41%)
0 <0> (ø)

...esthandler/ConnectionPoolBrokerRequestHandler.java
90.05% <90.05%> (ø)
0 <0> (?)

...edin/pinot/common/query/ReduceServiceRegistry.java
0% <0%> (-90%)
0% <0%> (ø)

...din/pinot/transport/config/RoutingTableConfig.java
20% <0%> (-66.67%)
0% <0%> (ø)

.../pinot/transport/config/PerTableRoutingConfig.java
0% <0%> (-56%)
0% <0%> (ø)

...linkedin/pinot/broker/routing/CfgBasedRouting.java
0% <0%> (-38.47%)
0% <0%> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5e8d8...0daf1b1. Read the comment docs.

@kishoreg Yes, this is for the broker async routing (or any new routing strategy). Will create an issue for this.


Align 2.8 to upstream

Fix direct merge from upstream & include latest v2.21.0-fixes changes.
https://issues.redhat.com/browse/RHOAIENG-5269

This may not be viable -- it is a shame we have a broken history behind 2.8 😞
I'll leave this until conversations tomorrow. I may end up having to not merge this.

On consideration today -- I think we need to just bite the bullet and say we messed up our z-stream for the EUS release and do better next time. I'll just create a manual cherry pick of the fix PR.


"top 3" status line should show rankings

Instead of:

<AgainstHumanity> Top 3 all time in #bitfolk: grifferz(2) zuzak(1) dominic(1) ziphy(1) popey(1) tolien(1) dave2(1)

I think it would be nicer to see:

<AgainstHumanity> Top 3 all time in #bitfolk: 1st (2) – grifferz; Joint 2nd (1) – zuzak dominic ziphy popey tolien dave2; Joint 3rd (0) – Everyone else.

:+1: although usually when listing joint places you're listing the top X players, not the top X scores (so in the example you'd miss out third place I suppose).


Cant get the Rankbot to work!

The rank bot for me isnt working so i need help!


Offline mode with expo

I am using expo but it does not really allow for local development in offline-mode.
Locally, I would run npx expo run:android --no-build-cache but, unfortuntely, there does not seem to be a way I can utilize the --offline (see docs) flag without running into other issues.
So, I thought I might come up with a workaround here and let useNetInfo() fail the reachability test. Something like:
const netInfo = useNetInfo({
  reachabilityTest: async (_) => {
    await new Promise((resolve) => setTimeout(resolve, 1000));
    console.log('going offline ..');
    return false;
  },
  reachabilityShouldRun: () => true,
  useNativeReachability: false,
});

const netInfo = useNetInfo({
  reachabilityMethod: 'GET',
  reachabilityUrl: 'http://<IP_ADDRESS>',
  reachabilityShouldRun: () => true,
  useNativeReachability: false,
});

I also tried setting reachabilityShouldRun: () => false, but  the problem is that netInfo.isConnected and netInfo.isInternetReachable would always be set to true. Am I misunderstanding something here?
README.md
Also, it appears the README.md might be outdated.

reachabilityShouldRun: A function which returns a boolean to determine if checkInternetReachability should be run.

Should it read reachabilityTest instead of checkInternetReachability or is that an internal routine?

I have the same problem.


A way to reliably intercept exceptions

Currently certain things will aways trigger an exception, and there is nothing that can be done about it short of wrapping calls to the state machine in a try/catch block.
I think it would be desirable to allow a special callback to be triggered instead of throwing an exception, in some circumstances.

I implemented a simple version of this custom error callback functionality in https://github.com/jakesgordon/javascript-state-machine/pull/10.
To avoid the potential onerror callback clobbering problem, I made the callback function an optional parameter to StateMachine.create(). Does this seem to be a reasonable approach?

The more I think about these issues, the more I am tempted to try to (politely) push back.
I did merge in cboone's pull request #10 into the next branch, but as I refactor to allow cfg.error to handle other error cases (such as a caller provided callback that throws an exception). I'm finding myself thinking that this is the wrong direction.
Generally speaking, if a class/method/library's preconditions are not met then an exception is the correct mechanism to deal with that problem.
In the case of triggering an inappropriate transition in an FSM, the question has to be asked - 'why are you doing that' ?

If the transition is really valid then it should be declared
if its not valid then the caller should not attempt it
if its because of an unpredictable race condition caused by asynchronous code you have bigger problems that should be dealt with rather than worked around.

I'm having a very hard time coming up with a concrete reason for why we should not throw an exception when preconditions have not been met, and I'm thinking of rolling back the pull request #10 before I merge the next branch into master
Do you guys have any further thoughts ? or more concrete examples of what you would actually do with such a callback.

It's like the corny old Tommy Cooper joke (a British reference) - "I went to the doctor, I said, doctor doctor, it hurts when I do this (lifts arm) - and the doctor said "well don't do that then!"

In my case... It was basically to detect things that shouldn't happen so I can fix the code, log it, and tell the user something broke and offer to reload (in opposite order).
ajh
On Dec 10, 2011, at 10:46 AM, Jake<EMAIL_ADDRESS>wrote:

The more I think about these issues, the more I am tempted to try to (politely) push back.
I did merge in cboone's pull request #10 into the next branch, but as I refactor to allow cfg.error to handle other error cases (such as a caller provided callback that throws an exception). I'm finding myself thinking that this is the wrong direction.
Generally speaking, if a class/method/library's preconditions are not met then an exception is the correct mechanism to deal with that problem.
In the case of triggering an inappropriate transition in an FSM, the question has to be asked - 'why are you doing that' ?

If the transition is really valid then it should be declared
if its not valid then the caller should not attempt it
if its because of an unpredictable race condition caused by asynchronous code you have bigger problems that should be dealt with rather than worked around.

I'm having a very hard time coming up with a concrete reason for why we should not throw an exception when preconditions have not been met, and I'm thinking of rolling back the pull request #10 before I merge the next branch into master
Do you guys have any further thoughts ? or more concrete examples of what you would actually do with such a callback.

It's like the corny old Tommy Cooper joke (a British reference) - "I went to the doctor, I said, doctor doctor, it hurts when I do this (lifts arm) - and the doctor said "well don't do that then!"

Reply to this email directly or view it on GitHub:
https://github.com/jakesgordon/javascript-state-machine/issues/3#issuecomment-3092312

I think that's a case where I'd suggest a more global exception handler such as a window.onerror handler ?

Yeah, good point. Maybe the documentation could suggest that.
On Dec 10, 2011, at 11:35 AM, Jake<EMAIL_ADDRESS>wrote:

I think that's a case where I'd suggest a more global exception handler such as a window.onerror handler ?

Reply to this email directly or view it on GitHub:
https://github.com/jakesgordon/javascript-state-machine/issues/3#issuecomment-3092533

In my case, I'm extending a Backbone view with the state machine, to turn it into more of a controller. The view watches for certain events – DOM events, Backbone events, and custom events (the last of those mostly coming from Ajax callbacks) – and then triggers state changes as appropriate. The state machine callbacks then trigger the appropriate behavior on the subsidiary views and models.
One place the problem arises is when the view is in state A, which cannot transition to state B, but the UI element that might trigger the change to state B is still visible and clickable. For example, there are some parts of the page that are sometimes visible and sometimes not. When those parts are visible, the user can click outside of them to make them hide again. But clicking outside of them when those parts are already hidden should not trigger any kind of state change.
I absolutely can handle situations like that without this error handling callback. But, as a practical matter, that means either adding a number of event listeners that check whether a state event can be fired before actually firing it, or namespacing all the events with selectors that indicate which states they can be called from. (The body of the page has a class that indicates which state the FSM is currently in.)
To some degree (perhaps large), this is an application design problem. But, unfortunately, this is a client project, and so I don't have much say in the overall design process.
To try to summarize how the problem seems to me, since I don't think it fits precisely into the three categories you listed, I'd say that I have a situation where the components of the application are very decoupled, and to properly prevent state-change-triggering events from happening I'd have to tighten those couplings back up. Or, put preventative measures in place in the state machine itself, in which case having a low-level custom error handler seems cleaner and simpler than high-level wrapping methods.
All that said, I realize that this might not a be common problem, so no worries at all if my patch isn't appropriate for the library. Thanks for thinking about it.

Interesting, thanks for the details. I'll mull that over and try to formulate a response (probably tomorrow)...
... in the mean time, I have 1 more question. Given the onerror callback, what would you do in it ? Are you going to handle all errors in a single generic way ? or differently for different types of errors ? or simply use it as a mechanism to ignore the error ?

Currently it's just $.noop. It might get more interesting the future, but that's all we need right now.

You know, I just remembered that, when I ran into this issue, I wanted to be able to deal with an instance or two where this could occur without letting the error bubble way up and also without putting a ton of try/catch blocks everywhere. It seemed to me an error callback would let me do just that, and would allow me to keep the most intuitive, and least repetitive, code.

I've slept on it, and I've come to the conclusion that I still think its a bad idea, but I understand why you might want it so I'm going to leave it in - but in a slightly different form...
First, I do want to say thanks for all the feedback, its greatly appreciated. Hopefully you can put up with one more long, slightly rambling, essay :-)
Lets start by considering that different types of exceptions might occur within the library:

the caller attempts to fire an event from an innapropriate state
the caller attempts to fire an event while a previous transition is in progress
an exception occurs in a caller provided callback
...

I have assumed (perhaps my mistake) that when we are talking about a customized cfg.error handler that it is general purpose and should be called for any exceptions that might occur.
I can understand how you might easily write a handler that is either:

a friendly 'sorry' message to the user before refresh/restart/shutdown
a no-op

... but I don't think you will be writing code to handle these individually (in Java terms you would consider these 'unchecked' exceptions)
Case 1 - restart
I think for case (1) the answer is simple, If you are protecting your users from sloppy programming - lets say you want to catch the error, report it to your servers, show the user a friendly "sorry" message and shutdown/restart/refresh - then you would be better off with a global exception handler that handles the entire application, not just one library.
For example in the browser having a global window.onerror handler, or in Rails using the ExceptionNotifier or in Java providing a Thread.setDefaultUncaughtExceptionHandler.

FYI: I've mentioned the bad 'J' word a couple of times here (Java) - don't take that as a sign I'm promoting Java as best practice - I just happen to be doing some Android development at the moment and forced into using Java :-)

Case 2 - ignore
But for case (2), the no-op, you are saying "lets ignore all errors", and that smells wrong, you almost certainly should either be identifying why the invalid transition is being attempted, or coding defensively at the point of transition - but that doesn't necessarily mean you need to try/catch all over the place.
For example, it might be as simple as this:
if (fsm.can('panic'))
  fsm.panic();

or
if (fsm.cannot('panic'))
  return;

Alternatively, if you can't prevent your architecture from performing an invalid transition, then you might be able to declare it as a valid transition that doesn't do anything ?
var fsm = StateMachine.create({
  initial: 'green',
  events: [
    { name: 'foo',  from: 'green, yellow', to: 'yellow' },
    . . .
]});

fsm.foo();  // transitions from green to yellow
fsm.foo();  // transitions from yellow to yellow (no-op)
fsm.foo();  // transitions from yellow to yellow (no-op)
...

SIDE NOTE
Perhaps one of the problems here is that I have assumed we are talking about a general purpose cfg.error handler, but really you just want a way to prevent the specific 'invalid transition' exception and leave all other exceptions alone.
That might be best provided as a simple cfg.ignoreInvalidTransition = true|false
General Purpose Error Handler
So, after all that rambling, I'm thinking of leaving in support for a general purpose cfg.error handler but making sure it is provided enough information to distinguish between the different types of errors so the caller has enough flexibility to handle only the ones they care about.
Something like...
StateMachine = {

  INVALID_TRANSITION_ERROR = "invalid transition",
  TRANSITION_PENDING_ERROR = "pending transition,
  OTHER_ERROR              = "aliens attacked",

  ...

    this.error = cfg.error || function(e, name, from, to, args) { throw e; };

    if (this.transition)
      return this.error(TRANSITION_PENDING_ERROR, name, from, to, args);

    if (cannot(name))
      return this.error(INVALID_TRANSITION_ERROR, name, from, to, args);

}

default error handler simply throws an exception
caller can override error by providing cfg.error
very explicit arguments for cfg.error function to decide how to handle the error
library calls error whenever anything unexpected happens
CONSTANTS to distinguish between different types of errors

Anyone still with me ?

Thanks for the comprehensive response. Regarding case 1, I completely agree.
Regarding case 2, I was doing what you illustrate at the beginning – if (this.can('doThat')), etc. – but enough of those clauses and I started to feel like something was wrong. It didn't, however, ever occur to me to try your second suggestion – using no-op transition events with the same names as real events that actually do transition from one state to another. That's clever, but still feels a little funny. (For instance, if there was a way to visually diagram the states and events of the FSM, then the no-op transitions would add a lot of confusion.)
Regarding your side note, I totally agree. All I really need is a flag that says "please don't blow up when I ask for something silly".
That said, your final plan sounds good to me. Perhaps more than anyone strictly needs right now, but nonetheless well thought out and useful. Thanks for thinking all this through.

This is (finally) done and released on the master branch as version 2.1.0.

Fantastic. Thanks Jake.


Add code to function generatePassword()

Add code to function generatePassword() in JS file to generate password with user input.

Add code to function generatePassword() in script.js file


TypeError: Cannot read property 'elements' of undefined

TypeError: Cannot read property 'elements' of undefined
in StoryProvider
in Unknown
in SnackbarProvider
in Unknown
in HistoryProvider
in Unknown
in Media3pApiProvider
in Unknown
in FileProvider
in Unknown
in APIProvider
in Unknown
in ConfigProvider
in aU
in ThemeProvider
in StyleSheetManager
in App
in StrictMode
in FlagsProvider

Thanks for your report!
What was the last action you've taken before this error happened?
Could you perhaps share your Site Health info with us so we can better understand how this happened?

Hi there,
I'm closing this for now since we haven't gotten any feedback. If it still happens with the latest 1.2.1 version of the plugin, please let us know.


cli: add reboot command

This closes #46.

Sorry for the delay. A dedicated reboot command is nice, but I think it would be more useful to be as part of the normal deployment process as a flag. If --reboot is supplied, Colmena should reboot the machine after activation (best used with the boot goal), wait for it to come back up and confirm that the new profile is in effect. This is what morph does when --reboot is supplied. What do you think?

That's definitely a much better idea.
Should I close this, then?

You can update the PR to do it if you feel like it. Otherwise I can find some time to get it done.

If the kernel supports it, you can kexec (faster), see: https://github.com/zhaofengli/colmena/issues/46#issuecomment-1082623491

It'd be interesting to have it "automatically" when we upgrade the kernel, for example.

You can update the PR to do it if you feel like it. Otherwise I can find some time to get it done.

I don't know how well I could pull that off, honestly 😅, as I'm not too familiar with Colmena/Nix internals...


Upterm added to list of applications

Added upterm into the applications as its really usefull for anyone working on the terminal or using the terminal.

I tried Upterm and it is quite amazing. However I still prefer iTerm. 🙂


#4 - Products not showing up for some categories in sample catalog

exclude categories with null url_path from sling resource provider
removed the temporary code fixing a bug with Magento 2.3.0

Related Issue
#4
How Has This Been Tested?
Extended unit test.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes and the overall coverage did not decrease.
[x] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

Codecov Report

Merging #14 into master will increase coverage by 0.3%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master      #14     +/-   ##
===========================================
+ Coverage     71.01%   71.31%   +0.3%
+ Complexity      208      202      -6
===========================================
  Files            15       15
  Lines           897      889      -8
  Branches        144      142      -2
===========================================
- Hits            637      634      -3
+ Misses          161      158      -3
+ Partials         99       97      -2

Impacted Files
Coverage Δ
Complexity Δ

...e/cq/commerce/graphql/resource/ResourceMapper.java
71% <100%> (+1.51%)
30 <0> (-6)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba67d96...e832df4. Read the comment docs.

@jelger, doesn't this has the consequence that certain categories will be unreachable in the product console and picker? Would it work to use the category id when category name and url path is missing to make all categories available?

Shouldn't we actually consider this as a Magento (or sample data) bug? At least via the Magento UI one can not create a category without a name and also url_key is set automatically to the name if the field is empty.

Yes it makes these categories unreachable, and yes why not we could in this case use the id. This would however require quite some more changes because all the resource path resolution logic is based on the url_path like men/tops-men/jackets-men which is computed by Magento. If this is null, we'd have to manually rebuild something like men/42/tees-men so I'd say this is out of scope of this PR.

Actually on my magento instance with sample data, these categories are also not reachable anywhere! ;-)

@mhaack I agree that this is a bug in the Magento samepl data. However, I prefer @cjelger's approach of ignoring the categories and outputting a log message that helps to identify the problem instead of letting the console break or adding a workaround.


Wagtail 4 not support django-filter 23

Pertinent section of the Wagtail docs

Updated django-filter version to support 23 (Yuekui)
Details

The package version support stated in the documentation is not true - link

While I realize that this may not be a major inconsistency, I would like to see it fixed - either in the documentation or in setup.py

Yep looks like the release notes for #8724 were incorrectly written in 920c0afdf435556342d92ab9926f26c9b8ebc411. The upper bound was indeed moved to 23, but it uses < so the release notes shouldn't say support 23.

Looks like the same thing happened again in #10632!

Yeah, see 91a3c6d2c2faf0315f5b498e20ce3e30d50d9379 - I must have read the previous number and just increased it.

Updated in a7f7757630c83eec12e819a4ea329abffac2d1a6 / a7f7757630c83eec12e819a4ea329abffac2d1a6 and backported to older branches as far as stable/4.1.x (the current LTS release) so that the docs will be updated if we make another patch release on those versions. Thanks for reporting, @vologzzzhanin!


Feature/talamini/thermal solid functional

Create a prototype of a material for functional-based thermomechanics.
The implementation is kept inside the file for its unit test suite, so it isn't affecting any code path yet.

Codecov Report

Merging #681 (f2fe9cc) into develop (fa11fe8) will decrease coverage by 0.02%.
The diff coverage is 94.19%.

@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
- Coverage    95.63%   95.61%   -0.03%
===========================================
  Files          129      132       +3
  Lines         8572     8793     +221
===========================================
+ Hits          8198     8407     +209
- Misses         374      386      +12

Impacted Files
Coverage Δ

src/serac/infrastructure/input.hpp
100.00% <ø> (ø)

src/serac/physics/thermal_solid_functional.hpp
62.85% <62.85%> (ø)

.../physics/coefficients/tests/serac_component_bc.cpp
100.00% <100.00%> (ø)

...sics/materials/tests/thermomechanical_material.cpp
100.00% <100.00%> (ø)

src/serac/physics/tests/serac_solid.cpp
100.00% <100.00%> (ø)

...c/physics/tests/serac_thermal_solid_functional.cpp
100.00% <100.00%> (ø)

src/serac/physics/tests/test_utilities.cpp
99.00% <100.00%> (ø)

src/serac/numerics/functional/dual.hpp
100.00% <0.00%> (ø)

src/serac/numerics/functional/tensor.hpp
97.02% <0.00%> (+0.10%)
:arrow_up:

src/serac/physics/solid_functional.hpp
100.00% <0.00%> (+0.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa11fe8...f2fe9cc. Read the comment docs.


More Verbose ReadMe

Our readme is small and can be larger and more descriptive. Maybe we can include that contribution image thing or whatever. Let's just make it pretty

let's add emojis


[5.5] Dry up starts_with + substr

In all of these case we can avoid calling 2 different functions
We can just call preg_match once

Overall I think this makes the code less readable?
When browsing I immediately understand Str::startsWith() - but I have to use my preg knowledge and try to interpret preg_match() and try to understand what the match is looking for?

I dunno I think it's OK as is.


Comparing new encoding with saved encodings from .dat file

face_recognition version: probably 1.2.2
Python version: 3.6.3
Operating System: CentOS 7

Description
Hello, I have access to lots of pictures and 64 cores CPU. I am not that great at python.
I noticed that face_recognition can't use multiple core while it is loading images, faces, encodings,it only uses multiple cores while comparing the encodings. Because of this I can't do a real-time comparison of a picture with all the others fast enough.
What I Did
I started creating a script to dump all encodings to a file (tested with 1k samples first), using your guide here:
import face_recognition
import pickle
import os
import glob
import concurrent.futures

#go to img directory
os.chdir("/home/samples")
#all img files
IMG_FILES = glob.glob("*.jpg")
FILES_COUNT = len(IMG_FILES)
print (f'\033[96m We have {FILES_COUNT} jpg files.\033[00m')
#dump file
DUMP_ENCODINGS = "/home/known_faces.dat"
#other vars
all_face_encodings = {}

#create face encoding
def face_encode(img):
    try:
        img_load = face_recognition.load_image_file(img)
    except:
        print (f'\033[91m File {img} - could not be loaded (corrupted?).\033[00m')
        return False
    try:
        a_face_encoding = face_recognition.face_encodings(img_load)[0]
    except:
        print (f'\033[91m File {img} - no face detected.\033[00m')
        return False
    return a_face_encoding

#work the cpus
with concurrent.futures.ProcessPoolExecutor() as executor:
    for IMG_FILE, the_face_encoding in zip(IMG_FILES, executor.map(face_encode, IMG_FILES)):
        if the_face_encoding is False:
            all_face_encodings[os.path.splitext(os.path.basename(IMG_FILE))[0]] = None
            continue
        all_face_encodings[os.path.splitext(os.path.basename(IMG_FILE))[0]] = the_face_encoding

#dump
with open(DUMP_ENCODINGS, 'ab+') as file_dump:
    pickle.dump(all_face_encodings, file_dump)

This worked very well and pretty fast - all cores used.
See 3 random arrays from the results.
3random_arrays.txt
Now I want to check new images against all this encodings. I tried the idea from here, but I always get this error:
Traceback (most recent call last):
  File "compare_face.py", line 37, in <module>
    main()
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "compare_face.py", line 33, in main
    result = test_img(unknown_face, face_names, face_encds)
  File "compare_face.py", line 9, in test_img
    result = face_recognition.compare_faces(face_encodings, unknown_face)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/face_recognition-1.2.3-py3.6.egg/face_recognition/api.py", line 222, in compare_faces
    return list(face_distance(known_face_encodings, face_encoding_to_check) <= tolerance)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/face_recognition-1.2.3-py3.6.egg/face_recognition/api.py", line 72, in face_distance
    return np.linalg.norm(face_encodings - face_to_compare, axis=1)
ValueError: operands could not be broadcast together with shapes (10,) (128,)

I'm guessing I don't read the encodings properly from the .dat file.
Code:
import face_recognition
import pickle
import os
import click
import numpy as np

def test_img(unknown_face, face_names, face_encodings):
    result = face_recognition.compare_faces(face_encodings, unknown_face)
    names_with_result = list(zip(face_names, result))
    return [names_with_result]

@click.command()
@click.argument('image_to_check')

def main (image_to_check):
    #unknown
    unknown_image = face_recognition.load_image_file(image_to_check)
    unknown_face = face_recognition.face_encodings(unknown_image)[0]
    #dump file
    DUMP_ENCODINGS = "/home/known_faces.dat"
    #other vars
    with open(DUMP_ENCODINGS, 'rb') as file_dump_read:
        all_face_encodings = pickle.load(file_dump_read)
    face_names = list(all_face_encodings.keys())
    face_encds = np.array(list(all_face_encodings.values()))
    result = test_img(unknown_face, face_names, face_encds)
    print (result)

if __name__ == "__main__":
    main()

If you have any ideas please do help! If you think I should change the approach, please tell!
Do you think I should save the encodings in a different way for faster comparison (like a db)?
I still need to make this second part to use multiple cores.
In the end I will probably have like 400 000 encodings saved and I will need to compare a new face with the old ones ASAP. I am willing to use KNN if it will be more accurate (right now I it does not detect faces in many, many pictures).
Regards,

i've noticed that your code works well, when all images are recognized, but if there is any mistakes recognition won't work

Hello @hanckmail I have just come across this solution, and I was wondering if you'd share some code as to how you implemented this?
Thanks

Hello,
I'm a bit late, sorry, but hanckmail was right.
I made an workaround and I haven't saved the None values any more. You can also save them in your .dat file and when your read .dat file don't compare if value is None.
Bogdan

Hi,
Could you give me some code of how you did that, as I am struggling
thanks


Patch not being picked up by patchew

Hey all,
Not sure if this is the right venue to report this; I sent the following patch about a week ago:
https://lists.xenproject.org/archives/html/xen-devel/2022-03/msg00853.html
But it's not appearing in the patchew list for xen-devel:
https://patchew.org/Xen/
Not sure what the issue is; I used a fairly vanilla git send-email to send the patch.  If there's anything in particular on my config side I need to adjust let me know.

Ah, thanks!  I should definitely be using the new address, but I suspect I'm not the only one that has the old address lurking around somewhere, so definitely good to have patchew handle both.  Thanks!


auth error

so when trying to login i get this error

the password is correct using the latest version

Check the UNAM_LIB\Logs folder for any errors, most likely your database file and folder aren't writable.

You see the permissions under your file in the screenshot.

Just make the db folder and unamwebpanel.db files writable.


Change subtile styling by default

Feature Request
I'm not sure if this is possible at all, but I couldn't find it. Is it possible to pass a standard subtitle style to the player. I would like to show a text without a background.

This feature is not supported, but here is a clue for android:
You should be able to achieve this by patch the code by adding something like follwoing line :
subView.setStyle( new CaptionStyleCompat( Color.WHITE, Color.TRANSPARENT, Color.TRANSPARENT, CaptionStyleCompat.EDGE_TYPE_NONE, Color.WHITE, null ) );
in ExoPlayerView.java, near the view instanciation line 78.

Do you also find a solution to fix this for Tvos?