[Feature] Federation between gogs instances

Description
The elevator pitch would be this:

"It would be great to fork / send pull request between public repositories across different gogs installation. So it would be great to have a way to federate between gogs instances."

My suggestion would be to look at ActivityPub, in-particular the "Federation Protocol", and see if we can federate through that protocol. The protocol is for building decentralized social network. But I think it is extensible with custom message type like "Fork" or "Pull-request".

ho yes please please please (begging dog face)

This is the github-killer feature.

Yes please add federation! For me this is the n1 priority! Definitely the github killer feature!

ActivityPub is for stars (called likes in ActivityPub) and following.
For forks, there is https://webmention.net/ This protocol can be used to notify source repository whenever it is cloned via gogs mirror/migration feature. It is indented for mentioning in blog posts, but can be easily adopted for forks and pull requests.

We may consider "Fork" as a custom "ActivityType" as described by ActivityStreams Vocabs, an ActivityStreams extension.

Another project that may be of use: https://github.com/go-fed/activity

Relevant proposal in gitea repository:
https://github.com/go-gitea/gitea/issues/1612

Let's lay down (and discuss) what needed to be done first.
Terms
Git Service: Web based Git service like Gogs, Gitea, Gitlab.

Features
For federation, these are the base line features:

Allow user to create a Pull Request to a remote upstream Web Repository.
Allow a downstream Web Repository to receive a Pull Request from a downstream Web Repository.
Allow a downstream Web Repository to report updates (e.g. git push) of a branch to an upstream Web Repository that it previously sent Pull Request to.
Allow an upstream Web Repository to notify a remote Git Service that a Pull Request is commented, tagged, assigned, reviewed, closed, re-openned or otherwise updated.

Based on these feature needs, It might also be essential to allow any Web Repository (specific branch) to be properly addressable and discover-able by query protocol (e.g. Like how Mastodon use Web Finger). This universal address should be differ from user or organization.

What about establishing an open protocol like ActivityHub in parallel to that?

I secured gits.social and gogs.social, so if anybody is going to make it happen and is interested in the domains, let me know and I'll give them to you

Hi!  ActivityPub co-editor here.  I'm fairly busy at the moment but I'd like to see this happen... if you need questions feel free to ping me, or ask in #social on irc.w3.org

This would indeed be killer - my main concern with moving off github is the lack of "social interface" that you get.
If this can somehow replicate that to some degree....that'd be amazing.

Some more thoughts: We'd also need to cater for Forking.
Downstream should notify the upstream about their forking address (so upstream could tell the owner). Potentially, a downstream would wants to know about upstream changes and vice verse. So a general subscription would be needed (which should comes natural to ActivityPub).
Feature (appending)

Allow user to create a Fork notification to a remote upstream Web Repository.
Allow an upstream Web Repository to receive a Fork notification from a downstream Web Repository (not branch specific).
Allow any agent to subscribe to any Web Repository updates.

An even more killer feature would be to make sure every major git tracking system uses the same standard, so that it would be able to federate Gogs with Gitlab, Gitea, … and why not even Github if the protocol gets big enough.

@cwebber: I plan to draft a specification document in this repository:
https://github.com/git-federation/gitpub
I feel like it is the best move to kick this off. But I'm have no experience in drafting such a thing. Please advice / join the effort. Thanks.

An even more killer feature would be to make sure every major git tracking system uses the same standard, so that it would be able to federate Gogs with Gitlab, Gitea,

I think this should even be the most important thing to consider before implementing anything - getting some specs agreed so that platforms can actually talk to each other.
Good stuff! <3

just to be clear, the look and feel would be something like if I have a private gog instance and I search for a repo, and it's hosted on e.g. a gitlab instance, I would see that repo in my gog ui, right?
and the clone address would still point to the gitlab instance or?

just to be clear, the look and feel would be something like if I have a private gog instance and I search for a repo, and it's hosted on e.g. a gitlab instance, I would see that repo, issues etc. in my gog ui, right?

This looks a bit overkill to me. The original idea, as I understand it (please correct me if I'm wrong) would be (at least in a first place) to federate PRs and forks, to make them behave "as if" the two repos were on the same gogs/gitlab/whatever instance.
Eg., I would be able to fork the gitlab project (hosted on gitlab) on my own Gogs instance, and this fork would be referenced there, so that the original project can track public forks. Then, I would be able to submit painlessly a PR to the original repo.

hm.. to me federation is when a lot of people share n bigger instances that are interconnected with each other, so only a few people need to run a server and others somehow join
what you are talking about sounds a little like a maintained version of gittorrent, if Im not mistaken https://news.ycombinator.com/item?id=9625840
https://github.com/cjb/gittorrent

@21stio: Federation does mean what you say. Gogs / Gitea / Gitlab instances are those n bigger instances. And the goal for confederation is to have their major workflow inter-connectable. So the specification of such federation needs to answer "what should be connected".
I think on the baseline, issues and comments are to be handled by the target repository server. But if the federation does not handle PRs and Forks, the federation does not make any sense.
In longer terms, issues and comments can be federated the same way as Post as specified in ActivityPub. We might not need to specify what is already an open standard.

besides the overall vision, adding something like activitypub or gitpub will have huge implications to the underlying data model and persistence layer of gogs/gitea/gitlab.. something that can only work with the consent of the maintaners @Unknwon

I'd love to have @Unknwon in the discussion / drafting of the specification.

@yookoala The idea of gitpub sounds interesting, I would love to implement if we have a open standard.

We have an ActivityPub library in Go now!
https://github.com/go-fed

ForgeFed is a work in progress specification for extensions to ActivityPub for supporting forges. Would be great to get someone from Gogs involved.
Repository: https://notabug.org/peers/forgefed/
Forum: https://talk.feneas.org/c/forgefed

This is a great idea.
Is there any progress on this issue?

FYI: the github.com/go-fed/activity library has been released at v1.0.0, which includes complete support for the ForgeFed Vocabulary.


improperly displaying privacy warning during sync issues

the privacy warning about using non-native tokens for transaction fees appears when there is a sync-related issue, which shouldn't be happening.

Closing this, as it appears to be a non-issue that should resolve itself once syncing is improved.


Remove ng-high-memory

References

Fixes #1037

Description
This removes ng-high-memory, because starting from node 12, it is no longer needed or even advisable to set the amount of memory required.
Instructions for Reviewers
To test this, verify that the scripts that used ng-high-memory still work: start, test, ci, and lint-fix
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

After a bit more thought, maybe we should just go with my alternative suggestion.  Moving us off Node v10 now would simplify our documentation (as we'd need to warn them to set NODE_OPTIONS), and it seems like this may be a good opportunity to add in v14 to our CI tests.  But, I'm open to suggestions

I agree, I'll update the PR to switch to node 12 and 14 builds on Github Actions


Unable to parse elastic response with pretty=true

NEST/Elasticsearch.Net version: 5.0.0-beta1
Elasticsearch version: 5.0.0-beta1
The Elasticsearch.Net low level client does not work when pretty=true is enabled on my clients connection settings. When I disable pretty=true, it works just fine.
Below here I have linked a pastebin containing a json document which was returned from ElasticSearch with pretty=true and could not be parsed by my nest client.
http://pastebin.com/L7wzeJ1i
The following response is returned in DebugInformation:
"Unsuccessful low level call on GET: /customer_index/product/_search?pretty=true\r\n# Audit trail of this API call:\r\n - [1] AllNodesDead: Took: 00:00:00\r\n - [2] Resurrection: Node: http://<IP_ADDRESS>:9200/ Took: 00:00:00\r\n - [3] PingSuccess: Node: http://<IP_ADDRESS>:9200/ Took: 00:00:00.2932808\r\n - [4] BadResponse: Node: http://<IP_ADDRESS>:9200/ Took: 00:00:00.0005026\r\n# OriginalException: System.Net.WebException: The server cause a ProtocolViolationException. Section=ResponseStatusLine\r\n   ved System.Net.HttpWebRequest.GetResponse()\r\n   ved Elasticsearch.Net.HttpConnection.Request[TReturn](RequestData requestData)\r\n# Request:\r\n<Request stream not captured or already read to completion by serializer. Set DisableDirectStreaming() on ConnectionSettings to force it to be set on the response.>\r\n# Response:\r\n<Response stream not captured or already read to completion by serializer. Set DisableDirectStreaming() on ConnectionSettings to force it to be set on the response.>\r\n"

@topres The thing that jumps out right away is the GET request, rather than POST.  .NET doesn't allow a body for GET requests.
Can you paste the relevant client code here?  Mainly the search request and your connection settings.

I reproduce this on beta1 as well when I added PrettyJson to connection settings
settings.EnableTcpKeepAlive(TimeSpan.FromSeconds(30), TimeSpan.FromSeconds(2)).DisableDirectStreaming().PrettyJson();

System.ApplicationException
Error checking to see if index identity exists: Original: ( - WebException) The server committed a protocol violation. Section=ResponseStatusLine

   at Foundatio.Repositories.Elasticsearch.Configuration.IndexBase.<IndexExistsAsync>d__20.MoveNext() in C:\Code\Foundatio.Repositories\src\Foundatio.Repositories.Elasticsearch\Configuration\IndexBase.cs:line 136
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Foundatio.Repositories.Elasticsearch.Configuration.IndexBase.<DeleteIndexAsync>d__19.MoveNext() in C:\Code\Foundatio.Repositories\src\Foundatio.Repositories.Elasticsearch\Configuration\IndexBase.cs:line 108
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Foundatio.Repositories.Elasticsearch.Configuration.ElasticConfiguration.<DeleteIndexesAsync>d__32.MoveNext() in C:\Code\Foundatio.Repositories\src\Foundatio.Repositories.Elasticsearch\Configuration\IElasticConfiguration.cs:line 158
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Foundatio.Repositories.Elasticsearch.Tests.ElasticRepositoryTestBase.<RemoveDataAsync>d__6.MoveNext() in C:\Code\Foundatio.Repositories\tests\Foundatio.Repositories.Elasticsearch.Tests\ElasticRepositoryTestBase.cs:line 40
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Foundatio.Repositories.Elasticsearch.Tests.ReadOnlyRepositoryTests..ctor(ITestOutputHelper output) in C:\Code\Foundatio.Repositories\tests\Foundatio.Repositories.Elasticsearch.Tests\ReadOnlyRepositoryTests.cs:line 25

Here is the calling code:
        protected async Task<bool> IndexExistsAsync(string name) {
            if (name == null)
                throw new ArgumentNullException(nameof(name));

            var response = await Configuration.Client.IndexExistsAsync(name).AnyContext();
            if (response.IsValid)
                return response.Exists;

            string message = $"Error checking to see if index {name} exists: {response.GetErrorMessage()}";
            _logger.Error().Exception(response.OriginalException).Message(message).Property("request", response.GetRequest()).Write();
            throw new ApplicationException(message, response.OriginalException);
        }

Invalid NEST response built from a unsuccessful low level call on HEAD: /identity?pretty=true
# Audit trail of this API call:
 - [1] PingSuccess: Node: http://ipv4.fiddler:9200/ Took: 00:00:00.4210542
 - [2] BadResponse: Node: http://ipv4.fiddler:9200/ Took: 00:00:00.1050037
# OriginalException: System.Net.WebException: The server committed a protocol violation. Section=ResponseStatusLine
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Elasticsearch.Net.HttpConnection.<RequestAsync>d__7`1.MoveNext() in C:\code\elasticsearch-net\src\Elasticsearch.Net\Connection\HttpConnection.cs:line 179
# Request:
<Request stream not captured or already read to completion by serializer. Set DisableDirectStreaming() on ConnectionSettings to force it to be set on the response.>
# Response:
<Response stream not captured or already read to completion by serializer. Set DisableDirectStreaming() on ConnectionSettings to force it to be set on the response.>

@gmarz The issue occurs both with GET and POST requests. If you need more info, I'll be happy to see if I can find some time to reproduce it and send you more data. I tried the following:
GET a single document with NEST.
GET all documents in a index/type with the LowLevel client.
POST search all documents in a index/type with the high level NEST api.
All failed with the same error, until I removed pretty=true.

@topres @niemyjski are you running elasticsearch server on linux? I suspect it might be CRLF header parsing issue.
If you can enable network tracing or have a wireshark dump of when it happens that be really helpful.
So far not been successful reproducing the issue.

These errors are all happening for me on local windows instances

If you want a running repo case, you could try our repo (I know that sucks to say and I'd love to have a snippet for you but literally every one of my tests breaks)

Turns out this is an issue with Elasticsearch returning a response body on HEAD requests with pretty=true.  If you're using connection pooling with pinging enabled (default) and pretty json enabled, you'll hit this as .NET conforms strictly to the HTTP 1.1 spec.
I opened https://github.com/elastic/elasticsearch/issues/21075.

This will be fixed in the next release of ES 5.0.
Closing.  Thanks for reporting @topres and @niemyjski.


update fabric qc report

Coverage decreased (-0.03%) to 64.4% when pulling e27864d8d42d18ab8a084fd13c98e3eeb113cff9 on leslieaula:dev into 712ce869a06167c9387da87c92f2cb8f12acd806 on danliris:dev.


[Issue 3112][Broker Prometheus Metrics]Fix Duplicate Prometheus TYPE fix and add test

Fixes #3112
Motivation
In this pull request, I set out to fix #3112, which is caused by duplicate TYPE statements in the metrics output which leads to parsing of Prometheus metrics to fail in recent versions of Prometheus. Because of this, Prometheus will report the broker target as down.
Since I started looking at this, the type definitions have been removed (#4136) from topics metric output. I think these types are useful in Prometheus and have added them back in.
While testing this fix in my geo-replicated setup, I found a format in error (missing quote and comma) in the TopicStats.metricWithRemoteCluster method. This pull request includes a fix for that issue.
I have also added a new test to PrometheusMetricsTest.java that fails without these changes but passed with them.
Modifications
I added a static HashMap to TopicStats to keep track of the TYPEs that have been output. All writing of the TYPE for topics and namespaces is done with the TopicStats.metricType method. I modified that method to update the HashMap and only print the TYPE out for the first occurrence of the metric name.  I also added a method reset the HashMap, which gets called in NamespaceStatsAggregator.generate.
Verifying this change
This change added tests and can be verified as follows:

Added testDuplicateMetricTypeDefinitions which checks for:

duplicate TYPE definitions in the Prometheus output
validates that no TYPE definition appears after the first metric sample
ensures that all metrics have a defined type

I execute the test twice to make sure the resetting of the HashMap of the already seen metric type definitions works correctly. This test passes for me reliably (both occurrences).
I have confirmed using promtool that the metrics output will now parse without error using versions 2.7.1 and 2.9.2 (which is the latest). There are many warnings around missing HELP definitions and metrics using reserved suffixes (ex. _count), but no errors.
In addition, I have patched 2.3.1 with this fix and am currently running it in my cluster. Prometheus (2.7.1) successfully parses the metrics and I am able to see namespace and topic-level metrics.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@cdbartholomew I think this PR https://github.com/apache/pulsar/pull/4136 fixes the issue already

@jerrypeng that PR (#4136) removes the TYPEs altogether, so now there are no type definitions for namespace and topic metrics. This PR restores the TYPEs and makes sure they aren't duplicated. It also includes a test.
I see that the PR has failed the unit tests. I will take a look at that.

@sijie I have rebased this PR as you requested.

// PulsarFunctionsProcessTest.pulsar-test-suite
run integration tests
// org.apache.pulsar.client.api.DispatcherBlockConsumerTest.testBrokerSubscriptionRecovery
// org.apache.pulsar.client.api.DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher
// org.apache.pulsar.functions.worker.PulsarFunctionStateTest.setup
run java8 tests

@jerrypeng @merlimat can you guys please take a look at this pull request?

ping @merlimat @jerrypeng

For the time of 2.4.1 release, I would like to merge this fix.


Typing failure (polymorphism + effect?)

Here's something weird: the following programs typechecks:
assume val or_else : (#a:Type) -> (f : (unit -> Ex a)) -> (g : (unit -> Ex a)) -> Ex a
assume val fail : (#a:Type) -> string -> Ex a

let rec first #a (ts : list (unit -> Ex a)) : Ex a =
    match ts with
    | [] -> fail "no tactics to try"
    | t::ts -> or_else #a t (first ts)

It's easy to miss, but in the last line, it should be or_else #a t (fun () -> first ts). If we annotate the call as first #a ts, then it fails properly since a term of type (unit -> Ex a) was expected, and not an a. The unifier is in fact resolving the implicit argument to (unit -> Ex) (instead of a), but that should require ts to have type list (unit -> Ex (unit -> Ex a)), which it does not. This is spawning a VC that gets proven by z3, but I didn't look at it in detail yet.
This does not happen for Tot, likely due to its primitive nature, but it does happen for a defined Tot
effect MyTot (a:Type) = PURE a (fun p -> forall x. p x)
assume val or_else : (#a:Type) -> (f : (unit -> MyTot a)) -> (g : (unit -> MyTot a)) -> MyTot a
assume val fail : (#a:Type) -> string -> MyTot a

let rec first #a (ts : list (unit -> MyTot a)) : MyTot a =
    match ts with
    | [] -> fail "no tactics to try"
    | t::ts -> or_else #a t (first #(unit -> MyTot a) ts)

(We can get a Tot False from this example, but that's due to the assumed fail. Maybe there's an inconsistency through this, however.)
I suspected that it's due to the decreases clause somehow, but it seems not, since the following function (which is not recursive, and just calls the original first) also typechecks.
 let first2 #a (ts : list (unit -> MyTot a)) : MyTot a =
    match ts with
    | [] -> fail "no tactics to try"
    | t::ts -> or_else #a t (first #(unit -> MyTot a) ts)

Also note that specializing the function
let rec first_int (ts : list (unit -> Ex int)) : Ex int =
    match ts with
    | [] -> fail "no tactics to try"
    | t::ts -> or_else #int t (first_int ts)

fails as expected
(Error 12) Expected type "uu___1345:Prims.unit -> FStar.Pervasives.Ex Prims.int"; but "first_int ts <: FStar.Pervasives.EXN Prims.int" has type "Prims.int"

This came about in tactics, but it seems unrelated to that.

Surprisingly enough, when checking that two computation types were equal, we were ignoring their return type. So MyTot a EQ MyTot b was always true. Subtyping was performing the check though, so this had to be exploited via some type constructor, which are invariant since we don't have polarities. (Possibly some other way too.)
More surprisingly, I only got a single regression in Vale's Calc.fst, which I just fixed and so I'm trying to merge.


Add Mini Sample Return Capsule from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of CobaltWolf, to add Mini Sample Return Capsule to CKAN.
Mod details:
name = /mod/831/Mini%20Sample%20Return%20Capsule
author = CobaltWolf
abstract = 2 part 0.625m autonomous return capsule to stuff your experiments in.
license = BSD / CC-BY-NC-SA
Homepage =
description = This mod adds two parts, a command/parachute and heatshield/cargobay.

Please direct questions about this pull request to CobaltWolf.

#rebuild


Added Multi Case #4969

Description
Link: https://github.com/bagisto/bagisto/issues/4969

@devansh-webkul
Implement this for default theme also https://prnt.sc/17hllmj

@vaishaliwebkul,
Mentioned changes have been done.


Lab 5 - Tokenization - Grammar

"You should see that the the thumbs-up emoji" -> duplicate "the"

Excellent. Nice catch. 1 point


Release semanticdb-scalac for 2.12.5

Looks like Scala 2.12.5 is critically broken (https://github.com/scala/scala-dev/issues/480). Let's wait a little bit to see whether it's here to stay or it'll be superseded by Scala 2.12.6 shortly afterwards.

I had a look at locally publishing 2.1.8 so I could use it with scalafix but there are compilation errors.
BTW, if in the future you need to make a release for a new version of scala without any source changes, but sbt-dynver trips you up on the version label, you can create a file like hack.sbt in the base directory containing the version override
version in ThisBuild := "2.1.8"

@fommil sbt -Dscalameta.version=2.1.8 should do the trick to override the dynamic version. We'll likely wait for the macro issues to be resolved before publishing for 2.12.5. Typically, it requires quite a bit of manual work to upgrade semanticdb-scalac because it touches on a large surface of compiler internals (so other tools like scalafix don't have to 😄 )

2.12.6 is planned to be released in about 2 weeks: https://contributors.scala-lang.org/t/scala-2-12-6-coming-soon/1729. I suggest we don't bother upgrading unless there's a pressing need.


Fix bug that prevented regular users to spawn notebooks (#836)

Omitted username field in spawner page for regular calls, as it should only be used when impersonating

tested using quay.io/cfchase/rhods-operator-live-catalog:1.20.0-rc4
/lgtm


[FEAT] Adding games to improve web dev and programming skills

Is your feature request related to a problem? Please describe.
Learning web dev and programming concepts can be boring at times. We could use a productive break from reading a lot of documentation and watching videos on end.
Describe the solution you'd like
Games always make learning concepts easier. So, to learn web dev or even general programming games can be highly beneficial like FLEXBOX FROGGY http://flexboxfroggy.com/ or CODE COMBAT http://codecombat.com/.
Describe alternatives you've considered
Videos can be an alternative but games make it more interesting.
Additional context
So adding a Games section would prove helpful for all the budding amateur developers out there.
Please assign this issue to me under GSSoC'23.

You can add them in the challenges sections.
flexboxfroggy can be added under CSS tag.


Improve @prinicipalField behaviour

The type of this PR is: Enhancement

This PR resolves MX-530
(Drive-by resolution of MX-522)
Description
This was started as a mob session in knowledge share.
Still to do:

[ ] Try to turn off noThrow and catch the principalField errors selectively.
[ ] Try turning off errorMiddleware. Seems like the builtin error logging is much better.
[x] Update tests.
[ ] No special handling of mutation errors?

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)

[ ] Not sure what to do with mutations

I added the followup items in KS so we can address them together. They are not blocking, so we can go ahead without them.


[t] use Test::APIcast from CPAN

extract the testing framework to own repository https://github.com/3scale/Test-APIcast
use s2i image that can install CPAN dependencies

be aware this increases the CI build time (s2i builder+runtime) significantly as there are dependencies that have to be pulled

:+1:
remember to fix the changelog conflict before merging :)


Add unit tests and e2e tests to CI workflow

https://github.com/numaproj-contrib/aws-sqs-source-go/pull/6


Have a build error, can you give me some tips how to solve it? Thx

Error in "concrt.h" :
extern "C" const __declspec(selectany) GUID ConcRT_ProviderGuid = { 0xF7B697A3, 0x4DB5, 0x4d3b, { 0xBE, 0x71, 0xC4, 0xD2, 0x84, 0xE6, 0x59, 0x2F } };
Report error : "error C2015: too many characters in constant"
Do you have any idea how to solve it? Thank you very much!

I also have this issue. Do you solve it now?
If so, can you share you solution with me?
Thank you very much.


Visualization window disappears if main window moves off initial display

When running in a multi-head environment the Aural visualization window fails to appear if the main window has been moved to a secondary monitor. It does not matter if the window is toggled via the keyboard shortcut or via "View -> Visualizer Window".
This is occurring on Ventura 13.4

Thanks for the bug report. I will look into it when I return to working on the project (away for a little while).
Cheers,
Kartik

Hi, I am unable to reproduce this issue on Ventura 13.3.1. Can you please list the exact sequence of steps, so I can be sure I'm not missing anything from your failure scenario ? Thanks!

In Ventura 13.5.2 (22G91) I was able to reproduce as follows:
First, to demonstrate the normal behavior:

Start Aural.
Using the "View" menu bar at the top of the screen, activate "Visualizer Menu"

Next, to demonstrate aberrant behavior:

Start Aural.
Drag the Aural to a different display
Using the "View" menu bar at the top of the screen, activate "Visualizer Menu"

In fact, when trying to reproduce this (multiple times, each of which succeeded), i generated the following crash report:
aural.dump.txt

Hi, I've looked at the crash report, but was not able to gain much insight from it. Also, I've been unable to reproduce on both Ventura 13.5.x and now 13.6.
Couple of ideas:
1 - Aural log file.

With Aural NOT running, go into your Music folder and under the "aural" subfolder (where all the app state and log are stored), and delete "aural.log".
Launch Aural and then run the error scenario with the visualizer to produce the crash (don't do anything else with the app, so that the log doesn't get bloated with unnecessary info).
Grab the newly generated "aural.log" from the same location: ~/Music/aural/aural.log, and share it here with me.

2 - If the log file doesn't yield anything useful and if you are willing to try a little experiment, I can build a special app bundle for you augmented with some extra debugging statements put in, to generate extra log info to see at what exact point the crash occurs. Then you can repeat the above procedure and share the log file with me. This will definitely provide good insights into where the crash occurs and possibly why.

Also, can you please share details about your 2 displays: Manufacturer, model, resolution, etc. Which one is main and which one not ?
Is it a laptop connected to an external display ? Or an iMac / macMini ?
Or, at least, whether or not the 2 displays are identical in terms of resolution or not ?

Hello, without any further info, I am unable to reproduce this issue, so I am closing it for now.
If you can provide more info, I'd be happy to look into it further.
Cheers!


In tmux, vim .fzf/**<tab>  search path problem

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[X] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.54.2 (brew)
OS

[X] Linux
[X] macOS
[ ] Windows
[ ] Etc.

Shell

[X] bash
[X] zsh
[ ] fish

Problem / Steps to reproduce
set the following:
export FZF_DEFAULT_COMMAND='fd --type f --hidden --exclude .git'
export FZF_DEFAULT_OPTS='--tmux 70%'

In tmux, vim .fzf/**<tab> the search path is in the current directory, not in the .fzf/

I can't reproduce the problem. Please make sure you have the latest version of fzf and that you have set it up using the right method.
https://github.com/junegunn/fzf?tab=readme-ov-file#setting-up-shell-integration


Class name must be a valid object or a string

I'm getting above error on laravel 5.5. I have published vendor and added table name in providers of auth.php. It is giving Creating Migration... and then above error. I have given full folder permission

I was using dev-laravel-5 version. I updated to the latest released version and the error is not appearing


Add support of flipud() and fliplr()

This pull request contains 4 features.

Implementation of cupy.flipud() which works same as numpy.flipud()
Implementation of cupy.fliplr()  which works same as numpy.fliplr()
Implementation of Functions.FlipUD which is a wrapper of cupy.flipud()
Implementation of Functions.FlipLR which is a wrapper of cupy.fliplr()

Because I am a novice programmer of matrix manipulation, my implementation may be quite slow, but I required it for my model.  I hope someone will improve them.

Thank you for your PR. These functionality is good.
Please add tests.

@tsuchm do you have time to make test? If no, i'll fix it.

Sorry, I have no time to check testing framework.

OK. I'll make it. And thank you for contribution!

#2239 is merged!
Thank you @tsuchm


Add support for the cbelow/cabove/lbelow/labove commands

Add support for the :cbelow, :cabove, :lbelow and :labove commands to jump
to errors in the current file relative to the current line.

Codecov Report

Merging #4316 into master will increase coverage by <.01%.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##           master    #4316      +/-   ##
==========================================
+ Coverage   79.94%   79.95%   +<.01%
==========================================
  Files         108      108
  Lines      141948   141999      +51
==========================================
+ Hits       113483   113529      +46
- Misses      28465    28470       +5

Impacted Files
Coverage Δ

src/ex_docmd.c
80.19% <ø> (ø)
:arrow_up:

src/quickfix.c
93.54% <98.03%> (+0.07%)
:arrow_up:

src/ex_cmds.c
81.92% <0%> (-0.25%)
:arrow_down:

src/channel.c
83.47% <0%> (-0.08%)
:arrow_down:

src/eval.c
85.9% <0%> (-0.05%)
:arrow_down:

src/screen.c
80.6% <0%> (-0.03%)
:arrow_down:

src/gui.c
57.99% <0%> (ø)
:arrow_up:

src/message.c
76.65% <0%> (+0.04%)
:arrow_up:

src/if_xcmdsrv.c
84.02% <0%> (+0.17%)
:arrow_up:

src/gui_gtk_x11.c
49.04% <0%> (+0.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701df4e...1b0ada0. Read the comment docs.

So does :cabo 3 mean move to the third error, counting up, above the current line?
What if there are multiple errors on the current line, are they included in the count?

Hi,
On Mon, Apr 29, 2019 at 7:48 AM Andy Massimino
<EMAIL_ADDRESS>wrote:

So does :cabo 3 mean move to the third error, counting up, above the current line?

Yes. If the specified count exceeds the number of entries above the
current line,
then it stops at the first error in the file.

What if there are multiple errors on the current line, are they included in the count?

Each entry in the current line is treated as separate entries. If the
current line
has 3 entries and the specified count is 2, then the cursor will not be moved.

Yegappan

Each entry in the current line is treated as separate entries. If the current line has 3 entries and the specified count is 2, then the cursor will not be moved.

So with a window like this (cursor is [|], error marked as [*]):
  Lorem ipsum dolor sit amet[*],
  consetetur sadipscing elitr, sed diam[*] nonumy eirmod[*] tempor[|]
~
~

3cabove would move to the line above (where amet is?). Wouldn't it make more sense, to have 1cabove move at least one line up?

Hi,
On Mon, Apr 29, 2019 at 7:54 AM Yegappan Lakshmanan<EMAIL_ADDRESS>wrote:

Hi,
On Mon, Apr 29, 2019 at 7:48 AM Andy Massimino
<EMAIL_ADDRESS>wrote:

So does :cabo 3 mean move to the third error, counting up, above the current line?

Yes. If the specified count exceeds the number of entries above the
current line,
then it stops at the first error in the file.

What if there are multiple errors on the current line, are they included in the count?

Each entry in the current line is treated as separate entries. If the
current line
has 3 entries and the specified count is 2, then the cursor will not be moved.

Correction. Multiple quickfix entries on a single line case is not correctly
handled now. Will update the PR.

Yegappan

Hi,
On Mon, Apr 29, 2019 at 8:09 AM Christian Brabandt
<EMAIL_ADDRESS>wrote:

Each entry in the current line is treated as separate entries. If the current line has 3 entries and the specified count is 2, then the cursor will not be moved.
So with a window like this (cursor is [|], error marked as [*]):
Lorem ipsum dolor sit amet[],
consetetur sadipscing elitr, sed diam[] nonumy eirmod[*] tempor[|]
~
~
3cabove would move to the line above (where amet is?). Wouldn't it make more sense, to have 1cabove move at least one line up?

Do you think we should treat multiple errors on a single line as one entry for
the purpose of the cabove and cbelow commands?
Thanks,
Yegappan

Yegappan wrote:

On Mon, Apr 29, 2019 at 7:54 AM Yegappan Lakshmanan<EMAIL_ADDRESS>wrote:

Hi,
On Mon, Apr 29, 2019 at 7:48 AM Andy Massimino
<EMAIL_ADDRESS>wrote:

So does :cabo 3 mean move to the third error, counting up, above the current line?

Yes. If the specified count exceeds the number of entries above the
current line,
then it stops at the first error in the file.

What if there are multiple errors on the current line, are they included in the count?

Each entry in the current line is treated as separate entries. If the
current line
has 3 entries and the specified count is 2, then the cursor will not be moved.

Correction. Multiple quickfix entries on a single line case is not correctly
handled now. Will update the PR.

If we support moving to the entry before/after the cursor, it would be
helpful if there are many errors in a line (e.g. in an XML file).
We could use :cbefore and :cafter for that.
So you could click somewhere in the line and use :cafter to jump to the
next column with an error.  It goes to a following line if that's where
the next error is.
Then :cabove and :cbelow can actually use the count as the number of
individual lines.
Makes sense?
--
MARTHA'S WAY: Don't throw out all that leftover wine. Freeze into ice cubes
for future use in casseroles and sauces.
MY WAY:       What leftover wine?
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Hi Bram,
On Mon, Apr 29, 2019 at 11:31 AM Bram Moolenaar<EMAIL_ADDRESS>wrote:

Yegappan wrote:

On Mon, Apr 29, 2019 at 7:54 AM Yegappan Lakshmanan<EMAIL_ADDRESS>wrote:

Hi,
On Mon, Apr 29, 2019 at 7:48 AM Andy Massimino
<EMAIL_ADDRESS>wrote:

So does :cabo 3 mean move to the third error, counting up, above the current line?

Yes. If the specified count exceeds the number of entries above the
current line,
then it stops at the first error in the file.

What if there are multiple errors on the current line, are they included in the count?

Each entry in the current line is treated as separate entries. If the
current line
has 3 entries and the specified count is 2, then the cursor will not be moved.

Correction. Multiple quickfix entries on a single line case is not correctly
handled now. Will update the PR.

If we support moving to the entry before/after the cursor, it would be
helpful if there are many errors in a line (e.g. in an XML file).
We could use :cbefore and :cafter for that.
So you could click somewhere in the line and use :cafter to jump to the
next column with an error.  It goes to a following line if that's where
the next error is.

So the cafter and cbefore commands are used to browse through every error
in the current file?

Then :cabove and :cbelow can actually use the count as the number of
individual lines.
Makes sense?

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Yegappan

Yegappan wrote:

Correction. Multiple quickfix entries on a single line case is not correctly
handled now. Will update the PR.

If we support moving to the entry before/after the cursor, it would be
helpful if there are many errors in a line (e.g. in an XML file).
We could use :cbefore and :cafter for that.
So you could click somewhere in the line and use :cafter to jump to the
next column with an error.  It goes to a following line if that's where
the next error is.

So the cafter and cbefore commands are used to browse through every error
in the current file?

Then :cabove and :cbelow can actually use the count as the number of
individual lines.
Makes sense?

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.
--
Proofread carefully to see if you any words out.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Hi Bram,
On Tue, Apr 30, 2019 at 12:41 PM Bram Moolenaar<EMAIL_ADDRESS>wrote:

Yegappan wrote:

Correction. Multiple quickfix entries on a single line case is not correctly
handled now. Will update the PR.

If we support moving to the entry before/after the cursor, it would be
helpful if there are many errors in a line (e.g. in an XML file).
We could use :cbefore and :cafter for that.
So you could click somewhere in the line and use :cafter to jump to the
next column with an error.  It goes to a following line if that's where
the next error is.

So the cafter and cbefore commands are used to browse through every error
in the current file?

Then :cabove and :cbelow can actually use the count as the number of
individual lines.
Makes sense?

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.

The latest updated pull request implements the above behavior. Currently
only the cabove and cbelow commands are implemented.
The current implementation supports count only after the command name
and not before the command. I did this to support only positive numbers
for the count and not use the range specification from the buffer.

Yegappan

Yegappan wrote:

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.

The latest updated pull request implements the above behavior. Currently
only the cabove and cbelow commands are implemented.
The current implementation supports count only after the command name
and not before the command. I did this to support only positive numbers
for the count and not use the range specification from the buffer.

:2cabove should work.  Use "RANGE" and "ADDR_OTHER" in the command spec.
--
It's not hard to meet expenses, they're everywhere.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Hi Bram,
On Wed, May 1, 2019 at 6:47 AM Bram Moolenaar<EMAIL_ADDRESS>wrote:

Yegappan wrote:

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.

The latest updated pull request implements the above behavior. Currently
only the cabove and cbelow commands are implemented.
The current implementation supports count only after the command name
and not before the command. I did this to support only positive numbers
for the count and not use the range specification from the buffer.

:2cabove should work.  Use "RANGE" and "ADDR_OTHER" in the command spec.

I was using RANGE in the command spec. But when a negative count is
supplied to the command, it uses the current line number from the buffer and
subtracts the specified count. I wanted to display an error for negative values.
I can use RANGE, if the value is negative, it will ignore the supplied count.

Yegappan

Yegappan wrote:

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.

The latest updated pull request implements the above behavior. Currently
only the cabove and cbelow commands are implemented.
The current implementation supports count only after the command name
and not before the command. I did this to support only positive numbers
for the count and not use the range specification from the buffer.

:2cabove should work.  Use "RANGE" and "ADDR_OTHER" in the command spec.

I was using RANGE in the command spec. But when a negative count is
supplied to the command, it uses the current line number from the buffer and
subtracts the specified count. I wanted to display an error for negative values.
I can use RANGE, if the value is negative, it will ignore the supplied count.

I looked into the way the type of range is specified, but it has a long
history of subtle ways things work not quite as expected.  Therefore
ADDR_OTHER will default to using buffer lines.
We could add a new address type, that does not use the buffer lines.
Not sure what to call it.  ADDR_NOT_LINES is not quite right.
I did do a bit of cleanup and removed NOTADR from the command flags.
It seemed a duplicate of using ADDR_OTHER, but it turns out it isn't
quite so.
--
Life is a gift, living is an art.		(Bram Moolenaar)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Hi Bram,
On Wed, May 1, 2019 at 9:20 AM Bram Moolenaar<EMAIL_ADDRESS>wrote:

Yegappan wrote:

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.

The latest updated pull request implements the above behavior. Currently
only the cabove and cbelow commands are implemented.
The current implementation supports count only after the command name
and not before the command. I did this to support only positive numbers
for the count and not use the range specification from the buffer.

:2cabove should work.  Use "RANGE" and "ADDR_OTHER" in the command spec.

I was using RANGE in the command spec. But when a negative count is
supplied to the command, it uses the current line number from the buffer and
subtracts the specified count. I wanted to display an error for negative values.
I can use RANGE, if the value is negative, it will ignore the supplied count.

I looked into the way the type of range is specified, but it has a long
history of subtle ways things work not quite as expected.  Therefore
ADDR_OTHER will default to using buffer lines.
We could add a new address type, that does not use the buffer lines.
Not sure what to call it.  ADDR_NOT_LINES is not quite right.
I did do a bit of cleanup and removed NOTADR from the command flags.
It seemed a duplicate of using ADDR_OTHER, but it turns out it isn't
quite so.

I updated the PR to use the new ADDR_NONE for the cbelow and cabove
commands. Now the negative and invalid ranges are properly passed to
the command function and the function checks for the invalid values and
displays an error message. This works on Linux and Mac (Travis CI builds).
But on Windows (Appveyor), the test fails. It looks like on MS-Windows,
the negative range is still converted into a buffer line number relative to
the current line number.
https://travis-ci.org/vim/vim/builds/527133913
https://ci.appveyor.com/project/chrisbra/vim/build/job/iw0t4ik7b28mwq1r

Yegappan

Hi Bram,
On Wed, May 1, 2019 at 10:39 PM Yegappan Lakshmanan<EMAIL_ADDRESS>wrote:

Hi Bram,
On Wed, May 1, 2019 at 9:20 AM Bram Moolenaar<EMAIL_ADDRESS>wrote:

Yegappan wrote:

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.

The latest updated pull request implements the above behavior. Currently
only the cabove and cbelow commands are implemented.
The current implementation supports count only after the command name
and not before the command. I did this to support only positive numbers
for the count and not use the range specification from the buffer.

:2cabove should work.  Use "RANGE" and "ADDR_OTHER" in the command spec.

I was using RANGE in the command spec. But when a negative count is
supplied to the command, it uses the current line number from the buffer and
subtracts the specified count. I wanted to display an error for negative values.
I can use RANGE, if the value is negative, it will ignore the supplied count.

I looked into the way the type of range is specified, but it has a long
history of subtle ways things work not quite as expected.  Therefore
ADDR_OTHER will default to using buffer lines.
We could add a new address type, that does not use the buffer lines.
Not sure what to call it.  ADDR_NOT_LINES is not quite right.
I did do a bit of cleanup and removed NOTADR from the command flags.
It seemed a duplicate of using ADDR_OTHER, but it turns out it isn't
quite so.

I updated the PR to use the new ADDR_NONE for the cbelow and cabove
commands. Now the negative and invalid ranges are properly passed to
the command function and the function checks for the invalid values and
displays an error message. This works on Linux and Mac (Travis CI builds).
But on Windows (Appveyor), the test fails. It looks like on MS-Windows,
the negative range is still converted into a buffer line number relative to
the current line number.
https://travis-ci.org/vim/vim/builds/527133913
https://ci.appveyor.com/project/chrisbra/vim/build/job/iw0t4ik7b28mwq1r

This is caused by the difference in size of the long type (64-bit vs 32-bit)
between the Linux/Mac and MS-Windows builds. To check for the negative
values, I am casting the long value to an integer. This works for the
64-bit long value and not for the 32-bit long value.

Yegappan

Hi Bram,
On Thu, May 2, 2019 at 9:25 AM Yegappan Lakshmanan<EMAIL_ADDRESS>wrote:

Yegappan wrote:

We will then have the following commands:
cbelow - Go to an error line below the current line in the current file
cabove - Go to an error line above the current line in the current file
cbefore - Go to an error before the current column in the current file
cafter - Go to an error after the current column in the current file

Right.  And when giving a count to cbelow/cabove it counts all the
errors in the same line as one.  Thus if there are three matches in the
line above and one two lines up, then ":2cabove" goes two lines up.

The latest updated pull request implements the above behavior. Currently
only the cabove and cbelow commands are implemented.
The current implementation supports count only after the command name
and not before the command. I did this to support only positive numbers
for the count and not use the range specification from the buffer.

:2cabove should work.  Use "RANGE" and "ADDR_OTHER" in the command spec.

I was using RANGE in the command spec. But when a negative count is
supplied to the command, it uses the current line number from the buffer and
subtracts the specified count. I wanted to display an error for negative values.
I can use RANGE, if the value is negative, it will ignore the supplied count.

I looked into the way the type of range is specified, but it has a long
history of subtle ways things work not quite as expected.  Therefore
ADDR_OTHER will default to using buffer lines.
We could add a new address type, that does not use the buffer lines.
Not sure what to call it.  ADDR_NOT_LINES is not quite right.
I did do a bit of cleanup and removed NOTADR from the command flags.
It seemed a duplicate of using ADDR_OTHER, but it turns out it isn't
quite so.

I updated the PR to use the new ADDR_NONE for the cbelow and cabove
commands. Now the negative and invalid ranges are properly passed to
the command function and the function checks for the invalid values and
displays an error message. This works on Linux and Mac (Travis CI builds).
But on Windows (Appveyor), the test fails. It looks like on MS-Windows,
the negative range is still converted into a buffer line number relative to
the current line number.
https://travis-ci.org/vim/vim/builds/527133913
https://ci.appveyor.com/project/chrisbra/vim/build/job/iw0t4ik7b28mwq1r

This is caused by the difference in size of the long type (64-bit vs 32-bit)
between the Linux/Mac and MS-Windows builds. To check for the negative
values, I am casting the long value to an integer. This works for the
64-bit long value and not for the 32-bit long value.

I have addressed this issue in the updated PR. The get_address()
function was not properly returning the count passed to commands
with ADDR_NONE. It was returning MAXLNUM - {count}. I have
modified it to return the actual count supplied by the user.

Yegappan


Add overrides applier

Hi!
I noticed one of the known issues about overrides and tried to create a solution to this problem.
I'm not sure if my method of copying props is correct or not. However, I didn't find anything in docs about copying styles and made it this way :–)
The function is async now. I had to convert it, because in order to copy font styles we need to load fonts used by nodes. Figma API has a method called figma.loadFontAsync which loads required font, but it is async.
If there is something else I can help with, I would be glad to :–)

Hi @bespoyasov ! Thanks for the contribution, this would be amazing to be as a configuration option... I often need a clean copy of the component!
I just need to merge @mikeozornin PR and them try to solve the conflicts for this one, okay?

@bespoyasov, I tried to help in testing of your version, cloned your repo and created a local plugin.
Get this error, and plugin still running (maybe async not closed):

Screencast: http://d.mikeozornin.ru/4KrGPN
Test file:
https://www.figma.com/file/tM2Dw30LOarrP7GbDEUK8h/reattach-test-file?node-id=0%3A1

Hi @renancamm,
I was wandering if there is anything else I can help with?

@bespoyasov I have files where overrides sometimes are lost.
Here is screencast: http://d.mikeozornin.ru/GUsK4M
There are two frames.
Lower one is created by detaching the component instance, reattach works like a charm.
Upper one is taken from some my file mockup and detaching doesn't work. Frames structure seems identical (close icon differ, but its overrides could by lost).
It's not a critical, but maybe is't some interesting case for testing.
Here is file, everybody has edit permissions: https://www.figma.com/file/Z1Eq4qFVJYc3bKNFOcp5Ca/Reattach-test-file?node-id=0%3A1

@mikeozornin, I reproduced the issue, but seems like I accidentally reloaded the page while debugging and lost that broken component :–(
How can I recreate the env to get the issue again?

@bespoyasov Done. I restored version before your changes.
There are several frame copies, just make one more copy before experimenting.
The same link: https://www.figma.com/file/Z1Eq4qFVJYc3bKNFOcp5Ca/Reattach-test-file?node-id=0%3A1

@mikeozornin thanks a lot!
I copy a file to local files since then :–)
Anyway, I've investigated this issue and it seems like it had something to do with the structure of a frame. On a screenshot below I tried to show the difference between the subtrees, which lead to an error:

The children count didn't match, so the plugin couldn't apply overrides to a node, which didn't exist.
Since we cannot predict which structures are going to be there and which one is correct I ignore frames with different structures. The plugin is still able to apply overrides, but if it encounters the difference it won't apply them.
Different structures here are just a different count of children in frames. I don't compare each subtree node with that in a different frame/instance, because they may have different names.
Now it is working as expected, however it might need further investigation for more complex cases.
Also, I fixed the error rendering on the main screen of the Figma App. Now it tells what happened right in the bottom message panel:

Somehow I forgot about it when refactored last time and all the errors passed silently in the console, which wasn't the goal really. Sorry about that.

Expected behavior for me: save overrides for frames parts with same structure and ignore parts that have another name or structure. Also I expect reseting overrides to whole subtree of node, that doesn't match by name or structure.
Now plugin works like I expect. Great thanks!

Tested with team lib.
Everything works :–)

Okay guys, I'm back
I was moving to another continent... A lot of trouble in the last weeks 😱
Let's merge and push to figma 💪

I was moving to another continent... A lot of trouble in the last weeks 😱

Wow :–)

@bespoyasov thanks for the amazing contribution!
The new code is working most of the time, but sometimes if it's freezing when I select frames that have something to copy from and other that don't have any reference.
I can't replicate this behaviour on new files tho. Do you know about any known issue?

@renancamm that's interesting, I haven't seen this yet, but I want to investigate it... 🤔
I'm going to need some more info. Could you help me, please?

How is it freezing?
Does the plugin finish the process or just crashes with an error?
Do those frames have something inside of them? If so, what is it: a text content, another frame, a component etc?

If there is some file with a problem components/frames it would be a huge help.

How is it freezing?

It get stuck in this:

Does the plugin finish the process or just crashes with an error?

No crash, no error. Console is clean! My bet is on some async problem.

Do those frames have something inside of them? If so, what is it: a text content, another frame, a component etc?

A bit of everything
Here is a sample file: https://www.figma.com/file/7YgwLVPcGC4USsXFoAntHA/Reattache-Plugin-Debug-sample?node-id=0%3A1

@renancamm I looked at it. Figma tells that there is an issue with nested component:
Can't create instance of nested master component. Please call figma.importComponentByKeyAsync(symbol.key) and await the result. The resulting component can be using createInstance().

I tried to call this figma.importComponentByKeyAsync() method, but it tells that it cannot find a component with given key among the published components.
I'm not sure if this is the issue with the code itself or with the components library. It seems like I'm going to need some more info:

Is the library included in your case?
Are the components "published" (what does it mean, btw)?
How can I know if components have different "keys"?

We can use some try-catch workarounds to avoid this issue, but I wouldn't go with this idea until we know what exactly what is going on.

@bespoyasov
Is the library included in your case?
The components are linked to a team library
Are the components "published" (what does it mean, btw)?
yes, otherwise it would't be possible to see them in other files.
("publish" is how you make changes in team libraries visible to other files)
How can I know if components have different "keys"?
No idea

So, I did a bunch of tests and it seems that the real problem is components from team libraries. It was working before, so I guess I lost track when it stopped working.
Do you know how to debug this beside printing everything to console?
I'm going to pay more attention to what is happing is this line:
let instanceClone = instanceReference.masterComponent.createInstance();

Do you know how to debug this beside printing everything to console?
¯_(ツ)_/¯
Only debugger — it helps to “stop” the program at a given moment and inspect the context.

@bespoyasov Updates from my side: It always fail with team library components (even in files inside my team) when we get to this line: let instanceClone = instanceReference.masterComponent.createInstance();, but it's failing silent because of async function.
I tested with the previous version, with #6 version, and the initial code version. None of them seem to work... It's weird because I could swear that the initial code worked in this case, because that's my only use case. They could have changed the API access to team library or I got confused somehow. I will investigate this further.

@bespoyasov @mikeozornin  While testing the code, I got surprised by #6 code. What do you think if we change to that codebase?


JAV-487 extracted rest template transport

Signed-off-by: seanyinx<EMAIL_ADDRESS>

Coverage decreased (-0.3%) to 95.146% when pulling 550cc6c2e265594b4591f330368ffcd7d39adb29 on JAV-487_rest_template_transport into 60bfa511d51b654b4db18f9170078db379fc1ede on master.

Coverage decreased (-0.04%) to 95.44% when pulling 24c37c500cdb12633598b9038d4c624bb05098db on JAV-487_rest_template_transport into 60bfa511d51b654b4db18f9170078db379fc1ede on master.


Support for other npm based infrastructure projects

How interested in a PR to add other npm infrastructure; or would you rather I maintain my own fork.

What do you mean by 'other npm infrastructure'? The tool currently cleans node_modules and .cache directories in npm projects.
Generally speaking, PRs are always welcome as long as you can explain why you need the added features.

I do a lot of NativeScript development.   It not only does a node_modules; but it also has a couple other directories that is all generated and can sometimes be more massive than the node_modules.
So this would be adding code to deal with the extra directories that are generated in addition to the node_modules.    :grinning:       I'm going to be adding the code to this in the next couple day  -- if it is for a PR; I'm a bit more "clean" and have a lot more error checking.   If it is for me, I'll probably just hack something quick and dirty.  :grinning:

That sounds great for a PR, go ahead! You should be able to add the directories to delete pretty easily in src/find/identify.rs.

I never got a PR, were you still planning to do this @NathanaelA?
In any case, if you just want a custom configuration for your project, check out the new feature added for v0.7 - you can create a .cleanuprc file in your project directory that lists all the directories that should be cleaned.
You can find an RC release of v0.7.0 on the releases page, let me know if it works for you!
If you still want to submit a PR to add these rules to the application, I will gladly accept it. Better defaults will improve things for all users. But I'll close this issue for now.


[Github][Spellcheck] Add general regex rule for GUIDs

I am sure this is for the guid. But I am not a fan of it. Couldn't we create a regex rule for spellchecker?
Originally posted by @htcfreek in https://github.com/microsoft/PowerToys/pull/14827#discussion_r762599743

We should replace expect values like ffaa0 for GUIDs by a general regex rule for GUIDs. This short character sequences which aren't real words can lead to false positives.

@jsoref is there a way to make the spell checker ignore GUIDs?


Reverse

A lot of times the io is connected to relays the reverse the output. E.G. Gpio goes low, relay closes. It would be nice to have a "reverse" parameter in the constuctor.

So writing 0 to a GPIO sets it to 1 and writing a 1 sets it to 0? 0 would read as 1 and 1 would read as 0?

Exactly.
On Sun, May 1, 2016 at 10:51 AM Brian Cooke<EMAIL_ADDRESS>wrote:

So writing 0 to a GPIO sets it to 1 and writing a 1 sets it to 0? 0 would
read as 1 and 1 would read as 0?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/fivdi/onoff/issues/47#issuecomment-216046348

This should also be possible for inputs. 0 would read as 1 and 1 would read as 0. rising edge interrupts would become falling edge interrupts and falling edge interrupts would become rising edge interrupts.

This is a good idea. I'll add it.

Excellent Thanks
On Tue, May 3, 2016 at 6:32 PM Brian Cooke<EMAIL_ADDRESS>wrote:

This is a good idea. I'll add it.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/fivdi/onoff/issues/47#issuecomment-216684528

onoff v1.1.0 was just published on npm. The Gpio constructor has an new option called activeLow that can be used to get the desired functionality:
var Gpio = require('onoff').Gpio,
  input = new Gpio(7, 'in', {activeLow: true}),
  output = new Gpio(8, 'out', {activeLow: true});

Thanks.
On Wed, May 4, 2016, 10:28 AM Brian Cooke<EMAIL_ADDRESS>wrote:

onoff v1.1.0 was just published on npm. The Gpio constructor has an new
option called activeLow that can be used to get the desired functionality:
var Gpio = require('onoff').Gpio,
input = new Gpio(7, 'in', {activeLow: true}),
output = new Gpio(8, 'out', {activeLow: true});
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/fivdi/onoff/issues/47#issuecomment-216882263

You're welcome :)
Have fun with onoff.


[Task] 功能完善建议

Description
功能完善建议
Task List

建议优化实时监控数据的展示，让界面更加友好；
建议优化历史数据展示，可以让用户关闭不需要的监控指标历史图表；
建议优化历史数据展示，可以让用户拖动关注的指标框；
建议优化历史数据展示，使用彩色的图式，类似于Grafana的dashboard；
建议中间件监控对象，增加 WebLogic 和 Nginx；
建议Redis数据库监控配置，增加单实例模式、哨兵模式和集群模式三种；
建议优化管理员用户密码，避免在配置文件中直接使用明文密码；
建议在免费版中增加普通用户和分组的创建，不同的系统监控有不同的用户和分组（从收费企业版中下放该功能）；

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Description
It is suggested that the function is perfect
Task List

It is recommended to optimize the display of real-time monitoring data to make the interface more friendly;
It is recommended to optimize the display of historical data, allowing users to close unnecessary historical charts of monitoring indicators;
It is recommended to optimize the display of historical data, allowing users to drag the indicator box they care about;
It is recommended to optimize the display of historical data and use colorful graphics, similar to Grafana's dashboard;
It is recommended to add WebLogic and Nginx as middleware monitoring objects;
It is recommended to add the monitoring configuration of Redis database, including single instance mode, sentinel mode and cluster mode;
It is recommended to optimize the password of the administrator user to avoid directly using the plaintext password in the configuration file;
It is recommended to add the creation of ordinary users and groups in the free version, different system monitoring has different users and groups (decentralize this function from the paid enterprise version);

If it is for back-end functions, please assign task 6 to me

If it is for back-end functions, please assign task 6 to me.

yes, the task 6 is to impl monitor redis cluster


4685555 Parth-Jain-2002:patch-3 git implementation

added git implementation
refer  -
https://github.com/stitionai/devika/pull/377
https://github.com/Parth-Jain-2002/devika/tree/patch-3

Thanks @nalaso for merging this. I was busy due to my personal commitments


Logs: limit rowCount

Hi!
replaces https://github.com/opnsense/core/pull/5587
Hope I got the idea right.
Although I still see some race condition when changing the severity filter quickly (without locking it on change), at least it doesn't completely block gui and doesn't drain php memory.
Thanks!

@kulikov-a thanks! this should prevent the endless waits indeed.

@AdSchellevis Thanks!!


Add new school for https://smatag45.sch.id

@yogarevy First stage of verification passed, official domain is smatag45.sch.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@yogarevy Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Fixing the bug in SparkExceptionFingerprinting

This is hot fix for fixing the bug in SparkExceptionFingerprinting , where half of the exception stack trace is displayed as new exception .
DSS-24595

@ShubhamGupta29 can u please review it at the earliest


Add support for graphing the attributes from summaries of multiple jobs

Add a REST API call that given a list of job IDs will graph attributes from the summary of the job and return it as a static image.

Support for rendering d3 page to png is here: https://github.com/datastax/cstar_perf/commit/806d028081b5305f201094c68b800ef8a51f3e4b


heading/direction fix

Codecov Report

Merging #665 (1785108) into main (c4c7ac6) will increase coverage by 1.32%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

@@             Coverage Diff              @@
##               main     #665      +/-   ##
============================================
+ Coverage     40.57%   41.90%   +1.32%
+ Complexity     1523     1519       -4
============================================
  Files           251      244       -7
  Lines         12142    11704     -438
  Branches       2434     2369      -65
============================================
- Hits           4927     4904      -23
+ Misses         6137     5733     -404
+ Partials       1078     1067      -11

Impacted Files
Coverage Δ

...oidrive/phoneui/viewmodels/CarDrivingStatsModel.kt
14.63% <ø> (ø)

...e/hufman/androidautoidrive/phoneui/PhoneUiUtils.kt
9.37% <0.00%> (-1.57%)
:arrow_down:

.../androidautoidrive/carapp/maps/MapboxController.kt

...droidautoidrive/carapp/maps/MapboxNavController.kt

...an/androidautoidrive/carapp/maps/MapboxSettings.kt

...an/androidautoidrive/maps/MapboxTokenValidation.kt

...hufman/androidautoidrive/maps/MapboxPlaceSearch.kt

.../androidautoidrive/carapp/maps/MapboxProjection.kt

...roidautoidrive/carapp/maps/MapboxLocationSource.kt

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c7ac6...1785108. Read the comment docs.

Thanks!


Review & Submit: File Selection

Definition of Ready

[ ] Does this meet the INVEST criteria?
[ ] Does this have a clearly defined user?
[ ] Does this have an estimate?
[ ] Does this have acceptance criteria?
[ ] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[ ] Does this have a dev link been provided in the design?
[ ] Is this traceable to a feature, epic, or PI?

User Story
As an ECMPS User
I want to be able to select the files to be submitted in their respective tables
So that I can submit multiple files at once
Acceptance Criteria
Given an ECMPS Submitter has accessed the Review & Submit Page
and the user is a verified submitter
When the user clicks on the checkbox in a row for a file
Then that file will be checked out
and selected to be submitted
Given an ECMPS Submitter has accessed the Review & Submit Page
and the user is a verified submitter
When the user goes to check out a file
and that file is checked out
Then the checkbox is replaced with a locked icon, and the uer cannot select that file
Given an ECMPS Submitter has accessed the Review & Submit Page
and the user has selected their file(s) for submission
When the user clicks on the submit button
Then all of the files where the checkbox = true are sent for submission
And the Modal for Submission Appears
Given an ECMPS Submitter has accessed the Review & Submit Page
and the user is a verified submitter
and the user has previously selected the checkbox for a file
When the user clicks on the checkbox in a row for a file
Then that file will be de-selected
Development Notes

Page needs to systematically refresh in order to provide accurate datat to see which files are checked out, if files are cheked out they cannot be sent in for submission

Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
Testing
Test Case:
Tester:
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Is the user story ready to be deployed to the test/staging environments?

Need to discuss with Quang Addis Abu Kyle and Jason to confirm that the checkout process is correctly integrated with the new review and submit checkout verification process


Fix tooltip destroy method still leaking because of not destroying $ti...

...p and $arrow. Memory-leak detected by Chrome inspector.

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED
Commit: d5895d7234b130bd0b810395b63d3edbc8752795
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/47888955
(Please note that this is a fully automated comment.)

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED
Commit: 82ad192f6f4dbf36ae058d0b19eeeee4ddf27fc8
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/47889535
(Please note that this is a fully automated comment.)

Could you please either fix the commits or make a new pull request, such that the pull request submitter and the commit author are the same user? Otherwise it's unclear if you might be submitting someone else's work, which gets complicated legal-wise. Thanks!


Implement data versioning for COVIDcast in server and client

This PR includes a migration assistance script -- it seems like a good idea to track these in source control, since even if we only use them once, we may regret losing track of what was done.

@korlaxxalrok This PR includes Eu Jing's script that converts a set of .sql backups into a full record of issue dates. It is a bit of a memory hog, so it's probably worth trying a couple of test runs before setting it loose on the full history. His notes:

Just in case you want to run the migration script, it requires a 3rd party package csvdiff.
I have been running it with the week's worth of compressed backup files in the same dir as:
python proc_db_backups.py --input-files just_covidcast_*_database.sql.gz --tmp-dir ./tmp  \
   --out-dir ./out --max-insert-chunk 1000 --skip jhu-csse usa-facts safegraph --debug

But I have also observed sources like doctor-visits and fb-survey consume around 10+ GB of ram during the diffing,
so skipping those to save memory might be good too just to see how it runs.
It should produce one SQL file per source in the ./out directory, and also several intermediate CSVs in the ./tmp directory.

@krivard I see this now 👁 Thanks for the reminder 🙇 I'll check it out asap.

By only inserting diffs into the database the semantics of the API is changed. For example a query that filters by issue_date will only retrieve new or changed rows in these issue_dates rather than the entire issues.

By only inserting diffs into the database the semantics of the API is changed. For example a query that filters by issue_date will only retrieve new or changed rows in these issue_dates rather than the entire issues.

If we only store diffs, we probably want a query for issue date 2020-06-01 to find the most recent data for each location that was issued on or before 2020-06-01.
That does leave open the question of how to handle a new issue that removes a particular geo_id from reporting, e.g. if a data revision brought it below a sample size threshold. A query that finds the most recent issue for each geo_id would fail to notice that, unless we issue an NA in this case.
There's also the question of how to implement such a query so that finding the most recent issue for 3000 counties can be done very quickly.

By only inserting diffs into the database the semantics of the API is changed. For example a query that filters by issue_date will only retrieve new or changed rows in these issue_dates rather than the entire issues.

If we only store diffs, we probably want a query for issue date 2020-06-01 to find the most recent data for each location that was issued on or before 2020-06-01.
That does leave open the question of how to handle a new issue that removes a particular geo_id from reporting, e.g. if a data revision brought it below a sample size threshold. A query that finds the most recent issue for each geo_id would fail to notice that, unless we issue an NA in this case.
There's also the question of how to implement such a query so that finding the most recent issue for 3000 counties can be done very quickly.

In the private API a parameter with the name as_of_issue_date is used to satisfy this query for a single issue_date, though it will report the latest issue of a key even if the key was removed in the last issue. If version filters were limited to this parameter then, ignoring removed keys, the data will be returned as expected but the issue_date and lag values returned will correspond with the latest diff rather than the latest issue per key.

When I asked Jacob about Forecasting's needs for the data versioning interface a few weeks ago, we decided three things:

We only store diffs. Data sets like cases/deaths are too dense to store a full issue for each update. (that said, we are currently uploading the full calendar of cases/deaths each day in automation, so this should be revisited)
If you don't specify an issue date in the query, covidcast should return the most recent issue for each time_value requested
If you do specify an issue date or a range of issue dates in the query, covidcast should return all matching issues for each time_value requested, which may include multiple entries for a single time_value. "On-or-before" functionality is specified using a range of issue dates.

This design does not handle deletions, but then again, neither does the current unversioned data.

Update from team leads meeting:

The terminology "as-of" is probably more useful than "issue" for sensors that only update a small portion of the calendar each day (as most covidcast sensors do). "As-of" would mean "Most recent data issued on or before" some time_value.
It is useful to report different kinds of missingness. Currently covidcast reports -2 No Results whenever the requested combination of source, signal, time_type, time_value, geo_type, geo_value is not found in the database. This includes malformed sources, signals, time_types, time_values, geo_types, and geo_values, as well as properly-formed queries that do not report a value due to privacy/sample size concerns. If we had a way to specify the latter, this would solve the deletions problem.

I do not think either of the above are blockers to merging this pull request and proceeding with the data migration, but they should be resolved before we publish updates to the clients.

@eujing, would you check my work on adding as_of to the clients?

Replaced by #149


Preselect boundary based on the user data source

Closes #12623
Now we use the information provided by the getavailablegeometries
to pre-select the best boundary for the provided user data

Applied the comments, let me know if you see something odd.

Wow thank you man, I was going to make that changes. I didn't add tests nor NEWS to make a first check if my solution was right :)

Mostly works ok, but I found some acceptance scenarios that are doing weird stuff:

Add two points very close together (< 1km) in US
Enrich from DO -> Total population. Timespan is autoselected to 2015-2015, and the smallest boundary for that is county.
Switch to 2011-2015. County is selected. It should have selected block group. It is keeping the last selection.

Do you feel we can improve this behaviour? Something like reselecting the default if the set of available boundaries changes or something along those lines?

Hum, if you didn't save/launch the analysis and store the value we it should be recalculated unless the change of timespan doesn't trigger the geometries part. Worth a check, thank you :)

I've changed this a bit check the commit this commit message for review
// @javitonino @nobuti

Looks great!

I've tested it in staging and looks good :)

Splendid!


Gray panel not show video streaming of the camera

Hi Ritchie,
congratulations for your great job!
I'm trying to show a video on the gray screen but it doesn't works.
The system is connected because I see that it sand frames but can't see the video.
Any suggests??
Thanks,
BR
Simone

Hi Simone,
You can try using the base project https://github.com/webrtc-uwp/PeerCC to validate your setup (hardware and network) to check if your webcam sender workstation is sending frames over to the receiver app and see their interactions.
If you only see a gray screen .. that usually means the receiver is not getting any video frames from the sender which could indicate either a network peer setup issue or the sender is able to get webcam frames to send.
Hope this helps.
Ritchie


Dynamically Update Copyright Year Based on the Current Year

Background
Currently, the copyright year displayed on our website is hardcoded to "2022". This requires manual updates each year to reflect the correct year, which can easily be overlooked and lead to outdated information being displayed.
Objective
The goal of this issue is to modify the copyright year so that it dynamically updates based on the current year. This will ensure the website always shows the correct copyright year without needing manual intervention.

Can you assign me this issue, please? I can collaborate on solving it.


Unable to load with multiple wavesurfer instances

When trying to load a blob via wavesurfer.loadBlob I get the error:
Uncaught (in promise) DOMException: Unable to decode audio data

I have also converted the blob to a URL and tried using wavesurfer.load but get the same error.
The type on the blob is: type: "audio/webm;codecs=opus"
Wavesurfer.js version: 3.3.3
Also, I am mapping through a list of blobs with Stencil.js (React-like framework), and the first one loads just fine. It's the consecutive wavesurfer instances that throw the error. I am building the waveform container element using Stencil refs: ref={(element) => this.waveReference = element}, which are similar to React refs. Could be that because I have a bunch of identical elements that the wavesurfer container cannot instantiate properly after the first one? I have tried custom ids but that doesn't work so I'm not sure there.
Likely related to: https://github.com/katspaugh/wavesurfer.js/issues/703, and if so a workaround would be very helpful.

Wavesurfer.js version: 3.3.3

Always test with newest version.

Updated to 4.0.1, still seeing issue.

Found the answer. When you are using MediaRecorder, as you record you save data in chunks. I was trying to render each chunk with Wavesurfer.js every 250ms in an effort to do a real-time waveform. MDN docs suggest that individual chunks may not be playable until you have finished recording and concat all chunks into one blob.
See "Note" in  MDN docs
Tl;dr- not an issue with Wavesurfer.js, chunks in MediaRecorder are not playable until you are finished recording and combine them into a single blob file.


remove background colors on api headers

They don't really match anything else, and the headers look cleaner without a background
/cc @frankiefu

LGTM


App Crashes When Viewing Chapter List For Any Manga

Just read some chapters directly (clicked the notification directly to the chapter) this morning, and went through a chapter list a week ago, maybe, but now, when viewing the chapter list of any manga, the app crashes, usually with no message. This makes it impossible to read any manga that don't have a new release (e.g. a notification to go directly to the chapter). I did try restarting my phone and clearing the cache, to no avail.

Also started happening to me after I opened up the tracking menu

As an update, when it tries to update, or if I trigger a manual update, of the mangas (checks for new chapters), it crashes. This one always pops up with the "Neko keeps stopping" window, with options to close it or go to app info.
For more info, I have a vanilla, non rooted or modified Pixel 4 XL.

Logout, then relogin

That fixed it for me. Thanks! Sorry for pinging you on this. I'll add that
to the list of things to try next time.
On Tue, Jun 15, 2021, 5:36 PM Carlos @.***> wrote:

Logout, then relogin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CarlosEsco/Neko/issues/512#issuecomment-861849838,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4VTPT2SOUWFK7IDCODXYDTS7BUJANCNFSM46X3BORA
.

Should be fixed in 2.5.0


Use minimum battery threshold to calc percent

Proposed change

Use minimum battery threshold to calc percent
This fixes the Aqara TVOC sensor battery reporting which seem to have a minimum voltage of 2.7 set for its battery alarm by default.
Additional information

This could for example change the behaviour of sensors with a nominal value of 3.0, which may not always report 100% even on new batteries. I do think that might be less of a concern. We could of course let max be nominal minus 0.1 volt.
Reference: https://github.com/zigpy/zha-device-handlers/pull/208/files#r352357340
Checklist

[x] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

Should i split this feature into some new custom cluster? It seems rather useful. Likely for other devices too.

It's not guaranteed that those attribute values are already cached. Currently, you'd probably need to read them manually for this to work.
ZHA could initialize/read those attributes during pairing, but this won't work retroactively for currently paired devices.
It would probably be best to just apply this to the Aqara TVOC sensor with static MIN/MAX values (that you read once and hard-code in the quirk).

@elupus (ping) in case you haven't seen my comment above and still want to work on this.

I saw it.. Not decided how i want to approach it. Quirking it for for aquara seems like cheating and will require more work in the future for other devices so i dont like it.
I want a solution that is beneficial for future devices too.

Quirking it for for aquara seems like cheating and will require more work in the future

Using a custom cluster like mentioned in my previous comment is not really a workaround.
It's the cleanest way to fix that device without breaking others.
But even Aqara devices themselves behave very differently with their battery reporting. Some use a custom cluster for reporting voltage only, some only report percentage, ...
Z2M uses 2.850V to 3V for the Aqara TVOC device.
If that matches the "min voltage threshold" + "rated voltage" attributes for that device, we should probably use them too.

Any updates on this?


obs-packaging: multi-arch kernel build support

Update the kernel package to allow building for multiple architectures with
a single set of sources.
Changes:

Add kernel configs for all architectures
Detect at runtime the correct target architecture and kernel
compressed image location. This is done  with the script kata-multiarch.sh.

Note that debian control files still need to be updated to handle Multi-Arch,
so that they are not tied to the architecture on which
linux-container/update.sh is run.
Fixes: #262

Updated following @jodh-intel review
/test

Thanks @marcov !

Ping @kata-containers/packaging - would be good to get some more eyes on this... ;)

lgtm

/test


Fix test which used random UTC date/time with a search that truncates the date in SQL

retest this please


react-native-payments: 0 should be an allowed amount

Good day,
The MDN documentation for PaymentRequest never mentions 0 being a forbidden total amount. The constructor for PaymentRequest in react-native-payments specifically checks for 0 and throws an error if that's the case: https://github.com/rnw-community/rnw-community/blob/master/packages/react-native-payments/src/util/validate-total.util.ts#L20
Having a total of $0 may seem counter-intuitive, but it's sometimes used to check if a payment method is valid (when changing a payment method for long-term payments for example). The flow works as expected with a total of $0 for Apple Pay (tested myself).
It might be an issue with Google Pay, but Apple Pay handles it gracefully.
Here's the workaround I had to do in my codebase:
    const paymentDetails = {
      total: {
        label: applePayRequest.total.label,
        amount: {
          currency: applePayRequest.currencyCode,
          // The library does not support a total amount of 0 (even though it is valid in the spec)
          // So we set it to 0.01 if the total amount is 0
          // The reason for 0 being an option in the first place is during our "Update Payment Method" flow
          // where we want to update the payment method without charging the user
          value:
            applePayRequest.total.amount === '0'
              ? '0.01'
              : applePayRequest.total.amount,
        },
      },
      displayItems: [],
    };

    const paymentRequest = new PaymentRequest(methodData, paymentDetails);
    // Since the constructor above throws an error if the total amount is 0, we need to set it to 0 here
    // Hacky, but it works
    if (applePayRequest.total.amount === '0') {
      paymentRequest.details.total.amount.value = '0';
    }

Maybe you should try using canMakePayment method from the standard

@mathieubruguier Have you tried canMakePayment ?

Closing due to missing response


Variant lines act like miro's lines while zooming in/out

When we zoom out in miro app, lines become small (disappear), and they create bigger lines and it goes like that (while zooming out) - if zoom in it makes the opposite. That would be great if the library has this functionality.

After some tinkering, here's my attempt at implementing dynamic grid size:
https://user-images.githubusercontent.com/46470763/120908893-ff0b0780-c623-11eb-815c-fe30569d9992.mp4
import React, { useState } from "react";

import ReactFlow, {
  Background,
  BackgroundVariant,
} from "react-flow-renderer";
import type {
  FlowTransform,
} from "react-flow-renderer";

import "./App.scss";
import initialElements from "./initial-elements";

const BASE_BG_GAP = 32;
const BASE_BG_STROKE = 1;
// At zoom = 1

export default function App() {
  const [elements, _setElements] = useState(initialElements);
  const [currentZoom, setCurrentZoom] = useState(1);

  return (
    <div className="App">
      <ReactFlow
        elements={elements}
        onMove={(flowTransform: FlowTransform | undefined) => {
          if (flowTransform) {
            setCurrentZoom(flowTransform.zoom);
          }
        }}
      >
        <Background
          variant={BackgroundVariant.Lines}
          gap={BASE_BG_GAP / currentZoom}
          size={BASE_BG_STROKE / currentZoom}
        />
      </ReactFlow>
    </div>
  );
}

Hey @ertugrulcetin
I agree that this background looks really nice but we will not work on our background variant since we have too many other things on our list ;) You could use the current Background component as a foundation for your own custom Background component. I am also willing to accept a PR for a new background variant :)


Add tests and Travis

Personally, I think (unit) tests and TravisCI would be great additions to GoNeovim, since they would help keep style consistent (by failing the travis build if gofmt needs to be run), prevent breaking changes from PRs and commits going unnoticed, etc.
I am willing to create a PR/PRs for adding tests (and Travis), even though it may take some discussion on what things should be tested (and how to test them).
@akiyosi If you want, I can make this a tracking issue with a checklist of what files need tests (and a checkbox for adding Travis) to keep things organized. Just let me know and I’ll update this.

@smolck
Hi😃
I agree with this. I prioritized feature implementation until the 0.4.0 release, so I was considering adding tests after 0.4.0.
PR for adding tests is welcome

@akiyosi If you want, I can make this a tracking issue with a checklist of what files need tests (and a checkbox for adding Travis) to keep things organized. Just let me know and I’ll update this.

Okay. I will cooperate

Related to this issue, a CI implementation by GIthub Action has been completed.
Test coverage is not enough, but this issue will be closed


Authentication Issue

Looks like Ford has disabled the OAuth password grant based on the error response CSIAQ0172E The grant type [password] is not supported. Supported grant types are [authorization_code, refresh_token].
Looking into a solution!

This is fixed with #27