Restructure handling of account group configuration

Currently, the extension creates an IndexedDB instance for view server data records information like the following (using an ephemeral test wallet):
{
    "accounts": {
        "value": [
            {
                "encryptedSeedPhrase": "U2FsdGVkX1/4J7PDteHCf99ZqlYvnOSmC0e9HBeX+rsBSyx86TI2T5EtsUwyTmY+ngsYKBjI1wVcsCcL7+BG+UhvHruKospDwKODt1Z0FVIwU9vasizxhcPVW8CREuFe7U03ek735vpYZ37QDY5FIHoITL6TvokOjHW01IRhjsym5sYzYMFzFYa1NSegtZMom0NO7Q00UyYJDSW9YHC9+UfsSgrfpM88T8bX/b9Hjxc=",
                "label": "Account #1"
            }
        ],
        "version": "V1"
    },
    "hashedPassword": {
        "value": "ade6aaedbe904e48faa3940789930d196b6aa59e981635e22364bb7b2d7ce802",
        "version": "V1"
    }
}

This structure has a few different issues, and we should restructure it to better align with the protocol design.

No separate FVK: We should store the FVK separately, and unencrypted, from the seed phrase. This has two important benefits.  First, it means that the extension can sync block data even when the extension is locked, so that when the user unlocks the extension, it's hopefully already synced to the chain tip. Second, it means that the viewing capability is recorded separately from the spending capability, so that all of the viewing-related portions of the code can be completely independent from the spend keys, and in the future, it will be easier to add other custody methods (like a Ledger), since the custody is separate from the scanning infrastructure.
Account terminology mismatch: The current structure stores one seed phrase (hence spend authority) per "account", but Penumbra provides an integrated logical account mechanism (an "account group" has up to 2^32 numbered accounts per spend key). We want to steer users towards creating multiple logical accounts under the same viewing key, and not to create multiple spending keys, which would duplicate their scanning work.  In addition, if we support multiple spending authorities, we'll need a way to carefully and honestly present that in the UX.

What I'd propose is that we align on the following terminology: use account to mean a Penumbra account, and wallet to mean a Penumbra account group / spend key.  We will probably want to support multiple "wallets" (e.g., to be able to have a hot wallet with software keys as well as different ledger devices, etc), but we should discourage users from having many wallets by making the extension modal. The extension should have an active wallet, and allow users to pick which wallet is active, but only ever operate with one at a time.  This means that all frontend and UI functionality only needs to present "accounts" to the user, since they will never be operating with two "wallets" at the same time.
With this decision made, we can restructure the configuration data. I'd propose something like:
{
    "wallets": {
        "value": [
            {
                "custody": {
                    "encryptedSeedPhrase": "U2FsdGVkX1/4J7PDteHCf99ZqlYvnOSmC0e9HBeX+rsBSyx86TI2T5EtsUwyTmY+ngsYKBjI1wVcsCcL7+BG+UhvHruKospDwKODt1Z0FVIwU9vasizxhcPVW8CREuFe7U03ek735vpYZ37QDY5FIHoITL6TvokOjHW01IRhjsym5sYzYMFzFYa1NSegtZMom0NO7Q00UyYJDSW9YHC9+UfsSgrfpM88T8bX/b9Hjxc=",
                },
                "fvk": "penumbrafullviewingkey1....",
                "label": "Wallet #1"
            }
        ],
        "version": "V1"
    },
    "activeWalletId": 0,
    "hashedPassword": {
        "value": "ade6aaedbe904e48faa3940789930d196b6aa59e981635e22364bb7b2d7ce802",
        "version": "V1"
    }
}

Notes:

By wrapping the seed phrase inside a custody object, we can have other custody methods in the future, or even a "read only" mode where no spending is possible, all using the same code for scanning and syncing;
Storing the FVK as part of the wallet config means it will always be accessible, independently of the custody method;
Recording an activeWalletId means we know which wallet is the active one;
All seed phrases are encrypted with the same password, for simplicity.

Currently, the view server data is stored in an IndexedDB instance named TESTNET-ADDRESS. Instead, this should be
viewdata/TESTNET/NUMERIC_ID

e.g.,
viewdata/penumbra-testnet-enceladus/0

After https://github.com/penumbra-zone/penumbra/issues/2997, we could change the numeric ID to be an account group ID, but this seems potentially overcomplicated for a first pass -- aligning the "account"/"wallet" terminology is more important than the internal database identifiers.

Overall, think all of this makes sense. A few comments:

it means that the extension can sync block data even when the extension is locked, so that when the user unlocks the extension, it's hopefully already synced to the chain tip.

Ideally this would be the case, but I think we rely upon the lifecycle of the service worker to achieve it. I need to dive deeper on this though.

Recording an activeWalletId means we know which wallet is the active one;

It may be easier to treat the first one in the array to be the active wallet. If not, we could just treat the fvk as the unique id. Or perhaps rename activeWalletId to activeWalletIndex.

If we want an inherent ID, the two options would be:

The FVK
The Account Group ID

The account group ID is a hash of the FVK, so it uniquely identifies the account group but doesn't convey viewing capability. Also it's shorter. The FVK also uniquely identifies its account group, but conveys permanent viewing capability. So the account group ID seems like the better option.

Implemented wtih v0.62 updates 👍


Hierarchical sampling for active learning

Implement the hierarchical sampling algorithm from Dasgupta and Hsu paper.

I'll like to work on this starting from May!


Betweenness centrality algorithms

Hi,

Hi,
I will handle it at the weekend

Codecov Report

Merging #14 into master will decrease coverage by 4.14%.
The diff coverage is 59.86%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   73.83%   69.69%   -4.15%
==========================================
  Files          69      100      +31
  Lines        1070     1521     +451
  Branches       73       94      +21
==========================================
+ Hits          790     1060     +270
- Misses        280      461     +181

Hi, I see that you are commenting a lot of issues and also fixing them. Nice, are you going to continue that trend? Those functionalities look really promising and are important for the development of the whole library.

Hi, I was looking for better solution for mutable local variables but I didn't find any alternative solution in those cases yet. If you have any hits for me how can I make my code better, I will be glad. If not, feel free to complete pull request.


TB output diagnostic table defaults

The current diagnostic table defaults are:

Let's make them:

I can't seem to find the place in the JS where the default check status of each column is set. Assigning to @brendancol

John Sabelhaus' students also suggested this one via him. Matt should notify him when it is live.


Bump to 0.1.7

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

No need to do that, @marsipu – we've set up a bot that automatically bumps version numbers and updates hashes as it detects a new release on PyPI. Of course you'll still have to update dependencies manually, if necessary, though.

You can see the bot did its business already, too:
https://github.com/conda-forge/mne-qt-browser-feedstock/pull/2

You can see the bot did its business already, too:

Hah! I missed that one :)

Thanks good to know. So I close this one, right?


Any final demo result to be show?

thks

@hyperion-thou sorry, been busy recently. will update once finished.

@hyperion-thou Hi, please check and have a try. :smiley:


completion with transitions

how does transition completion should work?
I had seen the completion will called almost immediately after transition has been started - as I can understand it will be designed for more UX-like chain transition, will not it?
if I am right, @pauljohanneskraft what do you think about providing some optional API for handle a true completion?
for example, look to the present transition (and other transitions) -
public static func present(_ presentable: Presentable, animation: Animation? = nil)
I think it would be good for providing completion -
public static func present(_ presentable: Presentable, animation: Animation? = nil, completion: (() -> ())? = nil) as native UIKit transitions - dismiss(animated:completion:)
so, what do you think about it?

I'm closing this due to inactivity - in case a question remains or if there are follow-up questions, feel free to continue on this thread or open additional issues.


Remove mainnet feature flag from feat-fast-sync.

Instead, add a chainspec entry merkle_tree_hash_activation which specifies the era from which the new block body hashing scheme is used.
So instead of comparing the block's protocol version to a hard-coded (but feature flag-dependant) constant, the block's era has to be compared to merkle_tree_hash_activation to determine whether hashing v1 or v2 should be applied.

Pulled back from "In Review" as there is some more work needed in the tests.


Attempt to assume binary is UTF-8

(IMO CRuby should raise for encoding: binary files with non-US-ASCII characters in it, TruffleRuby already does that, but it would be a breaking change)

I think that's basically what we're going to have. This is only impacting the encoding of the actual Source string itself, not the encoding of the individual strings in the result. They will still match their behavior.
Agreed though that this is very weird and niche.


Redirect 302/303

I know it's not profoundly important, but wouldn't it be better for the default redirect status to be 303 rather than 302?
Qv http://stackoverflow.com/questions/4764297, http://stackoverflow.com/questions/5129076.

i wouldnt mind. is there some sort of consensus on this? anyone else care?

Note: Many pre-HTTP/1.1 user agents do not understand the 303 status. When interoperability with such clients is a concern, the 302 status code may be used instead, since most user agents react to a 302 response as described here for 303.

Sounds about right to me, I've never seen the opposite behaviour but we're probably well beyond being safe to move to 303 as well, so I guess it doesn't really matter (unless someone can find a real case)

That note is from RFC 2616 (§10.3.4), from 1999. See also RFC2616 is Dead, RFC 7231. I know, I’m just a pedant, but if there’s a time to do it right, it’s when Koa is young.

yikes ok that's old, SGTM!

These days, don't refer to RFC 2616; RFC 7230 to 7235 are the main replacement RFCs :)

From RFC7231, it looks like 307 should be used instead of 302, not 303. I think that the latter should be reserved for situations where one wants to explicitly reference a new location for a new resource:

If the result of processing a POST would be equivalent to a
representation of an existing resource, an origin server MAY redirect
the user agent to that resource by sending a 303 (See Other) response
with the existing resource's identifier in the Location field.

@rulmarinho - not as I read the spec:

[303 (See Other)] is primarily used to allow the output of a POST action
to redirect the user agent to a selected resource, since doing so provides
the information corresponding to the POST response in a form that can
be separately identified, bookmarked, and cached, independent of the
original request.

whereas

The 307 (Temporary Redirect) status code indicates that the target
resource resides temporarily under a different URI and the user agent
MUST NOT change the request method if it performs an automatic
redirection to that URI.

I think 307 is primarily for when you want to re-post the same post data to a different URI; whereas that guidance in §4.3.3 is saying that it is acceptable to use 303 to redirect from a POST request to the same resource again (as a GET) – that is, to stay on the same page after a POST.

Right, I agree with your interpretation. What I was referring to, though, is to what koa users generally have in mind when redirecting users to another location - right now, by choosing a 302 as the default, we are basically optimising for a 303-like redirect. This works well when, for instance, you send a POST to create a resource and then redirect the user to the resource's new location via a 303. However, in these scenarios, you could opt for a 201 with the Location header pointed to the new resource instead.
Now, if we're simply optimising for a route redirect - no semantics involved, then that would be a 307 if we just want to relay the request to another endpoint (a POST continues to be a POST, no conversion happens on the user agent).
I'd say going for a 303 is more biased towards the "redirect after POST behaviour" but at the same time it's what 302 has become these days, so there's less chance for this to be become a breaking change, even if technically a 302 should have been interpreted as a 307 since the beginning 👀

@ruimarinho, I get you now. I agree, the ‘correct’ replacement for a 302 should be a 307, except that the 302 was so universally misinterpreted that that would create breaking behaviour.
201 would be appropriate following a POST if the redirected page is a representation of the resource, but not if it was, for instance, a list of such resources (after adding a widget, transfer back to list of widgets); but I take it you are not proposing that as a default...
I think 303 would be the best default, as a) in my experience, ‘redirect after post’ is the commonest use case for redirect (accepting that other people’s running may vary), and b) it would be less of a breaking change as a replacement for 302.
Note: Koa documentation would have to be changed to match.

do we have a consensus?

@jonathanong possibly. Me and @chrisveness agree that changing the default to 307 would be a BC because nowadays people expect a 302 to behave like a 303 due to how user agents mishandled the spec. Docs, however, should be updated to recommend the usage of 307 in situations where the method and the data should be kept intact.

tidbit: looks like Django and RoR still go with 302 from what I can see

Did some research and Symfony2, Laravel and Spring also go with 302. Spring appears to have a flag that disables HTTP 1.0 compatibility, which in turns makes the default redirect status code a 303.

http://bloggingmax.net/303-redirect-and-its-effect-on-seo/ from 2015 and the side effects on search engines! Very, very important for one web framework.
it should stay 302 by default @tj @travisjeffery , but add option/setting to change it to whateever the user need.

Would you accept a PR that allows an optional parameter to ctx.redirect for setting the status code?
And maybe a ctx.redirect.status variable to save the default?


packaging: install python 3.7 in fedora-nmstate-dev image

As run-tests.sh is now using Fedora 32, it requires to install python 3.7
to run python 3.7 unit tests.
GLOB sdist-make: /root/nmstate-workspace/setup.py
py37 create: /root/nmstate-workspace/.tox/py37
SKIPPED: InterpreterNotFound: python3.7

Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

@EdDev we do not need to support Fedora 31 anymore for VDSM, correct? Then we can just remove the Python 3.7 unit tests from the CI instead of fixing it for F32.

Coverage remained the same at 65.913% when pulling 11fbd0a52abbaf581fbddd608d23ea44de101261 on ffmancera:f32container_py37 into 2d44e2610ce434eb65e1d4a8bf8aa16f1528074c on nmstate:master.

Coverage remained the same at 65.913% when pulling 11fbd0a52abbaf581fbddd608d23ea44de101261 on ffmancera:f32container_py37 into 2d44e2610ce434eb65e1d4a8bf8aa16f1528074c on nmstate:master.

we do not need to support Fedora 31 anymore for VDSM, correct?

Correct. We also agreed not to support 0.2 on Fedora 31, that is why we moved to rawhide.

Then we can just remove the Python 3.7 unit tests from the CI instead of fixing it for F32.

I’m good with dropping it.

Please change it to remove the py37 test from tox and travis.yml

Done, thanks!

Rebase/merge exception: No code changed, travis-ci and tox config files were not touched on master.


release-v2.5.0

Let's skip this release since there's no new commits on master since the last release.


implementation of threaded binary tree

Description
A binary tree is made threaded by making all child pointers that would normally be NULL point to other the node.
There are two types of threaded binary tree
1-one way threaded binary tree

2-two way threaded binary tree

Domain
Data Structure
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

please assign this issue to me


DeFi SDK Integration

Create an Interactive Adapter for OUSD to be supported by Zerion's DeFi SDK. Our high-level objective is for users to be able to mint and redeem from Zerion's DApp. They have quite a few examples in GitHub, but they pointed us to this one from Curve. It appears that creating a ProtocolAdapter is a prerequisite, and it would involve querying our vault's token balances. For this interface, we would only need to support stablecoin balances and not worry about governance token balances. Our checkBalance method can be used for this.

This is live! 🧟


python problem:code analysis is in  progress...

Reporting a Problem
django project :
when enter django modul or other modul, can not use code tips.
Always show :code analysis is in progress.., waiting for ten minuts and then code analysis is in progress..
Product and Version [VS/VSCode]: 1.40.2
OS Version [macOS/Windows]: win 10
IntelliCode Extension Version: <IP_ADDRESS>
Target Platform or Language [e.g. Node.js]:12.4.0

This isn't an IntelliCode issue, can you please reopen it on the python-language-server repo?
https://github.com/Microsoft/python-language-server/issues


Smooch.io

This is a basic implementation of Smooch support for Botkit. I've tested it to ensure quick replies work in the Smooch Web Messenger. I haven't tested other message types or channels.

/cc @gozman

The legacy branch is no longer accepting new platform integrations. If you'd like to port this to v4, please create a botbuilder-adapter-smooch (similar to the other botbuilder-adapter-* examples, found here: https://github.com/howdyai/botkit/tree/master/packages)


footer for landing page

created the main footer for landing page which was duplicated in other frames

https://www.figma.com/file/LEKdq0JqyuzzOGxv0tZWjh/WalletFriendly?node-id=1735%3A6316
created all the footer section


Switch from moment to dateformat

The moment library is around 50kb minified, which ends up being around 15% of the total size of analytics.min.js. Switch to dateformat which has a much smaller footprint.

LGTM


Drone clone stuck

I have been using the drone in production for two months without any problems.
Today, the developers told me that there was a problem with CI / CD and that it didn’t run as planned.
I went up to check it and found that all the projects had been stuck in the clone step.
Have you ever met this kind of situation? How can I solve this problem?
thank you
Version introduction
drone:1.6.5
Kubernetes:1.14.6
drone log:
{
  "build.id": 525,
  "build.number": 16,
  "error": "Cannot transition status via :enqueue from :pending (Reason(s): Status cannot transition via \"enqueue\")",
  "level": "warning",
  "msg": "manager: cannot publish status",
  "repo.id": 242,
  "stage.id": 519,
  "time": "2020-07-01T09:57:07Z"
}

drone-pzav4gijxrufkrjbv8hc   0/7     Init:Error   0          2m44s

If it happens that you use Aliyun and Bitbucket.. cloning will be extremely slow (you can try doing a git clone directly from your server) my work around was to cache the repository and override the drone clone step with something like this:
clone:
  disable: true

steps:

  - name: clone
    image: alpine/git
    commands:
      - git clone --reference /cached-repository ${DRONE_GIT_HTTP_URL} .
      - git checkout ${DRONE_COMMIT_SHA} -b ${DRONE_COMMIT_SHA}
    volumes:
      - name: git-cache
        path: /cached-repository

volumes:
  - name: git-cache
    host:
      path: /drone-cache/git-cache

Assuming you already have a valid git repository at this location: /drone-cache/git-cache


Added GetRestApiForAppAsync methods

Added methods for app similar to GetRestApiForUserAsync.
Couple of small cleanups.

Thanks @brentschmaltz. I'll validate with IdWeb tomorrow.


correct path for react-native-xcode

Fixes the error reported here: https://github.com/FormidableLabs/victory-native/issues/216

I was going through a full upgrade to harmonize the versions per Carlos' instructions. Do you want us to do that instead?

@ryan-roemer whichever you prefer

Let me see if I can hack it out tomorrow and we'll touch base then...


Possible issue with jobstart's response newlines?

Sometimes newlines don't get parsed correctly. I wish I could give steps to reproduce but I would have to investigate more. Opening in case someone experiences the same problem and can provide more information.
Possibly related? https://github.com/neovim/neovim/issues/1574

Hey, sorry for the late response, but I was on a longer trip.
What do I have to look at in that screenshot?

Thanks for ocaml :) The issue was that when grepformat is wrong, you see those || lines at the beginning. I know for a fact that the error format wasn't wrong, because it worked in vim, but in neovim it didn't sometimes. I thought I had read something about newlines issues with jobcontrol so I linked it in case it might be useful.

Hmm, maybe it's related to this commit that was merged yesterday: https://github.com/jbradaric/vim-grepper/commit/6102a9b260322b607f584e99a4793901bfbc5f59
It would be nice if you could leave a note here, if it happens again (after you updated of course). :-)

That seems to do it. Thanks!

Awesome! Thanks for the feedback.


[FLINK-6732] Activate strict-checkstyle for flink-java

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[ ] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[ ] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

I've created set of changes that remove ~3k checkstyle violations in flink-java.
I had doubts about changing some public static final classes into private static final classes e.g in MinAggregationFunction.java. Is it safe to do so? Can I check it does not interfere with any part of the system. Or should I just revert it and add appropriate javadoc?
@zentol What is your opinion?

If a function is tagged as @Internal or in a class tagged as such then we should be able to restrict the visibility. Would be good if you could reply in the JIRA for the tuple checkstyle exclusion.

Right, but won't there be any serialization issues? I found a comment like which made me ask that question:
// Nested classes are only "public static" for Kryo serialization, otherwise they'd be private

eh...the commits just jumped around so i assume you just force pushed? From this point on please don't.
As for kryo, well you got me there. Frankly i don't know where we use kryo or something else; so far i relied on failing tests to tell me that.

Yes sorry for that, Just wanted to remove the AvoidStarImport commit from in the middle. Any further changes will do with new commits.

I've noticed  some <br> tags here and there, could replace those as well.

@zentol I believe this is the only outstanding checkstyle PR. Is this still in your review queue?

I was wondering whether we want to extend this PR to cover all checkstyle rules at once. We are touching so much already, might as well go all-in.
We should also try to group the changes by package to make the reviewing easier imo.

Okay, I now see there are many outstanding violations which look to be the type fixable by regex. If we split out PRs by package we should by able to copy over the comments updates from this PR as necessary.

Hi @greghogan @zentol I will rebase this PR, fix remaining checkstyle violations and split into PRs corresponding to packages. Is that ok?


Is there a pypi release likely?

It'll be nice to be able to do pip install stpyv8.

Totally agree with you. But that's really complicated for multiple reasons. The first is that we need to compile Google V8 to generate the binary wheel. And this step is platform dependant. Moreover STPyV8 itself makes use of libboost and this further complicates thinking about a single workflow for that. But be aware there's something we already provide to ease the pain.
The easiest way to install STPyV8 is to use one of the Python wheels provided at https://github.com/cloudflare/stpyv8/releases. The wheels are automatically generated using Github Actions and multiple platforms and Python versions are already supported, with others planned for the future.
Each release zip file contains the ICU data file icudtl.dat and the wheel itself. First of all you should copy icudtl.data to the STPyV8 ICU data folder (Linux: /usr/share/stpyv8, MacOS: /Library/Application Support/STPyV8/) and then install/upgrade STPyV8 using pip.
So installing on MacOS is just a matter of executing the following steps
$ unzip stpyv8-macos-10.15-python-3.9.zip
Archive:  stpyv8-macos-10.15-python-3.9.zip
  inflating: stpyv8-macos-10.15-3.9/icudtl.dat
  inflating: stpyv8-macos-10.15-3.9/stpyv8-<IP_ADDRESS>-cp39-cp39-macosx_10_15_x86_64.whl
$ cd stpyv8-macos-10.15-3.9
$ sudo mv icudtl.dat /Library/Application\ Support/STPyV8
$ sudo pip install --upgrade stpyv8-<IP_ADDRESS>-cp39-cp39-macosx_10_15_x86_64.whl
Processing ./stpyv8-<IP_ADDRESS>-cp39-cp39-macosx_10_15_x86_64.whl
Installing collected packages: stpyv8
Successfully installed stpyv8-<IP_ADDRESS>

Unfortunately if no wheels are provided for your platform and Python version you are required to build STPyV8.

I'm looking for a way to put this in a setup script or Makefile for my repo so that I can get my builds into CI.
My use case is integration tests for a Flask app — they'll run much faster and more reliably if I can use test_client.get(path) and put it in a JS context with STPyV8 and make the assertions, instead of calling out to a webdriver.
Maybe I'll try and see if it's reliable enough to submit here.

IMHO this is something you can easily automate using the Python wheels. FYI I am the lead maintainer of Thug [1] which makes use of STPyV8. I suggest taking a look at how I perform tests. Maybe it could help you figure out a way to do that.
[1] https://github.com/buffer/thug

That is most useful, thanks! I had looked there previously and didn't see it in setup.py, but didn't think to look in tox.ini. I'll use that.

Have you heard of https://github.com/pypa/cibuildwheel? Would that not be of use for building wheels on lots of different platforms/versions?

@Gobot1234 unfortunately it's not so straightforward because of the boost dependency. The last time I took a look at it I realized that the image used to build a manylinux image was very old and the build used to fail. But I was taking a look at the manylinux_2_28 image right now and it seems very promising...

FYI https://github.com/cloudflare/stpyv8/issues/81#issuecomment-1873907415
CC @jace @Gobot1234 @mikea

UPDATE
It seems like a PyPI release is very close to be released. I performed a PyPI release of STPyV8 v12.0.267.15 just for testing and tested the generated artifacts on Linux (Ubuntu 20.04, Ubuntu 22.04, Debian 11 and Gentoo) and OSX 13. And everything works as expected. I have deleted the PyPI release because I ended up uploading some wrong artifacts during the code cleanup but, starting from the next STPyV8 release (this should happen on Jan. 23th according to Google V8 release schedule), we'll start enjoying PyPI releases. I will keep this issue open until that date just for tracking purposes.


Import schema.org microdata recipe format

We already support similar import in schema.org JSON-LD format, but some web-sites export recipe data only in microdata format. We can get inspiration from a fellow project https://github.com/julianpoy/RecipeClipper/blob/master/src/utils/microdata.js.

  Instructions:

  Preheat the oven to 350 degrees. Mix in the ingredients in a bowl. Add
  the flour last. Pour the mixture into a loaf pan and bake for one hour.

  140 comments:

    <meta itemprop="interactionType" content="https://schema.org/CommentAction" />
    <meta itemprop="userInteractionCount" content="140" />

  From Janel, May 5 -- thank you, great recipe!
  ...

Of course! I'll assign this to you. Thanks!

Hey @dubadub! Thank You for assigning me the issue. But, I am an absolute beginner here and I tried to understand your issue and tried my best to understand and solve the issue but didn't get it. Sorry for the inconvenience. You can unassign me this. Again sorry for the inconvenience.

No problem @singhvibhanshu , thanks for giving a try!


Changes to support folder inputs on browser and native

Using a new optional argument in the input object to determine the input origin and use that to decide which type of path module needs to be used. Use browserified one if input origin is browser.

@LuisTejedaS Could you take a look at this PR, we are adding support for origin while using the constructor.


UI improvement for downloading a Dandiset

This issue is to gather UI feedback.
Here's a mockup of a UI on the Dandiset Landing Page to guide users towards downloading the Dandiset using the CLI. There is a way to download a different version than the current version, which is hidden by an accordion view, and then that same widget is shown in the screenshot with the accordion opened.

I'm not sure if we want the API key so prominently there, because it is a one time setup (or few time setup) and also it won't be needed for most downloads (only of embargoed data, which isn't designed or implemented yet).
Another option is to put the Dandi CLI instructions in an accordion, as that is a one/few time setup.

We can also have this overall download widget displayed when the user is exploring the dandiset. Not captured in this screenshot, we will want to display the name of the current

dandiset above the hierarchy browser.

@bendichter @satra @yarikoptic

Looks great! Let's do it! ;)

notes from discussion:

move ? icon to Help
remove API key
change DANDI:000006/draft to the full url

with these changes, if the implementation is quick, let's implement as soon as we can.

Thanks for writing those down, I wasn't able to get to it until later:
move ? icon to Help => have a "help ?" at the far right side of that component title bar
change DANDI:000006/draft to the full url => that is the dandiset permalink (not the GUI url)

that is the dandiset permalink (not the GUI url)

just to clarify this is only in the case of a draft dataset. for any published dataset it should always use the identifier form as shown in the figure above.


Cocoapod build test sample app

Basic sample app build test for Cocoapod gRPC builds
Change Summary

Barebone sample app with Podfile for cocoapod builds

the sample app takes gRPC & gRPC-ProtoRPC pod dependency which is our V1 & V2 ObjC pods

build_test_cocoapod_samples build script
added cocoapod build test to pre submit checks

Test & Verify

ensure the updated presubmit checks pass on cocoapod sample app build test.

build test pass at https://github.com/grpc/grpc-ios/actions/runs/3048322281/jobs/4913257403


[Enhancement] : Nav Bar Not work mobile site

Describe the feature

In this project nav Doesn't work .
I will ready for work on this project..
please assign me.... :rocket:

Add ScreenShots
Screencast from 2024-06-15 08-57-01.webm
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it. Happy open-source contributing!


Adding heavy weight torpedo model

Adds one more model - the Mark 48 heavy weight torpedo.
To test run
roslaunch dave_demo_launch dave_models.launch

You should see one additional model compared to https://github.com/Field-Robotics-Lab/dave/pull/209 - the large torpedo shown here:

A tagged both @quarkytale and @j-herman as potential reviewers.  Just needs one review, but thought I'd see who has the time to take a look.

I've got it.  Nice easy way to ease into the morning :)


Support: Tenant column, multiple TenantIds

Let's say I only use one tenant column:
tenant
But I may want to get 2 different companies at once (without getting all companies)
tenant = A OR tenant = B
It seems you can add multiple tenant fields:
TenantScope::addTenant($tenantColumn, $tenantId)
but not multiple values per one tenant field or am I wrong? If such a change should be made, maybe you can point out the place to extend your code.

Well, I only needed this for one specific Entity. So manually I override this trait method inside the entity:
	public function getTenantWhereClause($tenantColumn, $tenantId)
	{
		return "({$this->getTable()}.{$tenantColumn} = '{$tenantId}') OR ({$this->getTable()}.{$tenantColumn} = 'edge_case') ";
	}

It works but it's not elegant or efficient ( I may need this on more entities)

WOW
and OR statement is still 3 times slower than a IN statement.
http://stackoverflow.com/questions/782915/mysql-or-vs-in-performance
so, I made this little change:
return "{$this->getTable()}.{$tenantColumn} IN ('{$tenantId}', '{$all}')";
I hope this helps someone else.

Thanks! I don't think I'll add this in general for now, but I'll chuck it on the list for later.


API Container exiting in storefront branch with flow testnet and -f flag in flow cli not working properly

I am following the steps for Testnet Development from this link:
https://github.com/onflow/kitty-items/tree/storefront
There are two problems I am facing with the testnet commands:
(1) the kitty-items_api container shuts down each time
(2) the flow project deploy command doesn't correctly parse the file with the -f flags.
1) The kitty-items_api container problem
When I run this command:
npm run start:testnet
3 containers are created initially, the kitty-items_web, the kitty-items_api and postgres. However, within a few seconds the api containers exits.
These are the logs:
><EMAIL_ADDRESS>dev /api
> tsnd src/index.ts --respawn --dev

[INFO] 17:31:51 ts-node-dev ver. 1.1.8 (using ts-node ver. 9.1.1, typescript ver. 4.3.5)
Error: connect ECONNREFUSED <IP_ADDRESS>:5432
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1148:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 5432
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>dev: tsnd src/index.ts --respawn --dev
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-07-23T17_31_55_331Z-debug.log

(2) The Flow CLI problem
When I run the following command:
flow project deploy --network testnet -f flow.json -f flow.testnet.json
I get the following error:
:x: Config Error: deployment contains nonexisting network testnet
I was able to fix this error by merging the following contents of flow.testnet.json into the flow.json file:
  "accounts": {
    "emulator-account": {
      "address": "f8d6e0586b0a20c7",
      "keys": "f8e188e8af0b8b414be59c4a1a15cc666c898fb34d94156e9b51e18bfde754a5"
    },
    "testnet-account": {
      "address": "${FLOW_ADDRESS}",
      "keys": "${FLOW_PRIVATE_KEY}"
    }
  },
  "deployments": {
    "emulator": {
      "emulator-account": [
        "Kibble",
        "KittyItems",
        "NonFungibleToken",
        "NFTStorefront"
      ]
    },
    "testnet": {
      "testnet-account": [
        "Kibble",
        "KittyItems",
        "NFTStorefront"
      ]
    }

Looking forward to any tips on solving these issues.

Nice! Glad you're testing out the branch!
We'll be moving this into production soon. Will include a fix for this.

A quick "hacky" fix for problem number 2:
jq -s '.[0] * .[1]' flow.json flow.testnet.json > merge.json
flow project deploy --network testnet -f merge.json

There seems to be a regression in the flow-cli. We're looking into it today.

The regression has been fixed.


Examples are wrong

The examples are using the parameter -Name, which in fact does not exist.
Please correct the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8137a60-b5ea-297e-61d2-2271da424dba
Version Independent ID: b3d0d338-bce4-4204-84cf-100e318621c8
Content: Start-PnPWorkflowInstance (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Start-PnPWorkflowInstance.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

Created https://github.com/SharePoint/PnP-PowerShell/issues/2482


[BEAM-419] Fixing SE_BAD_FIELD FindBug in CombineFnUtil

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

FindBugs detected that the context member in NonSerializableBoundedKeyedCombineFn (now NonSerializableBoundedCombineFn) was not serializable although the class was. Seeing as the class has "NonSerializable" right in the name, to fix the FindBug I marked the member as transient to make it explicitly non-serializable.

I'm not familiar with this code, but by the class name NonSerializableBoundedCombineFn it seems that this is not intended to be serialized. @kennknowles can you shed any light on this?
If the class is intentionally non-serializable, then the proper fix would be to move the FindBugs suppression inline via @SuppressWarnings and remove from the findbugs-filter.xml file.

It definitely seems intentionally non-serializable. The writeObject method just throws an exception saying that it can't be serialized.
I can switch it to SuppressWarnings.

Actually, on closer look it seems like all findbugs suppressions should be in the filter. I think instead I should just edit the comment in the original suppression to explain why it's being suppressed and then close the JIRA issue.

I'll need to look back at the code review for why this was considered a good idea. Certainly once the context is baked in it should not be serialized. But CombineFn is serializable, since that's the whole idea.

Coverage decreased (-0.07%) to 69.528% when pulling 38e195f0c65f113d74a7a09f25dd583d22187b8e on youngoli:bugfix-beam419 into 66b864f2b3f95780f8952bafcafd8796ea931c2b on apache:master.

retest this please

retest this please

LGTM
@kennknowles for contributor approval and merge.

R: @kennknowles Could you review this?
@youngoli do you know why tests are failing?

retest this please

Run Java PreCommit

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/15355/Build result: FAILURE[...truncated 1.54 MB...]2017-10-26T23:19:19.224 [INFO] Apache Beam :: SDKs :: Java :: Nexmark ............. SUCCESS [03:13 min]2017-10-26T23:19:19.224 [INFO] Apache Beam :: SDKs :: Java :: Harness ............. SUCCESS [01:17 min]2017-10-26T23:19:19.224 [INFO] Apache Beam :: SDKs :: Java :: Java 8 Tests ........ SUCCESS [ 27.553 s]2017-10-26T23:19:19.224 [INFO] Apache Beam :: Runners :: Gearpump ................. SUCCESS [ 48.616 s]2017-10-26T23:19:19.224 [INFO] Apache Beam :: SDKs :: Java :: Aggregated Javadoc .. SUCCESS [ 58.271 s]2017-10-26T23:19:19.224 [INFO] ------------------------------------------------------------------------2017-10-26T23:19:19.224 [INFO] BUILD FAILURE2017-10-26T23:19:19.224 [INFO] ------------------------------------------------------------------------2017-10-26T23:19:19.224 [INFO] Total time: 01:26 h2017-10-26T23:19:19.225 [INFO] Finished at: 2017-10-26T23:19:19+00:002017-10-26T23:19:21.196 [INFO] Final Memory: 367M/2276M2017-10-26T23:19:21.196 [INFO] ------------------------------------------------------------------------2017-10-26T23:19:21.295 [ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project beam-parent: I/O operation failed: No source found for org/apache/beam/examples/Snippets.java -> [Help 1]2017-10-26T23:19:21.295 [ERROR] 2017-10-26T23:19:21.295 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.2017-10-26T23:19:21.295 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-10-26T23:19:21.295 [ERROR] 2017-10-26T23:19:21.295 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-10-26T23:19:21.296 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureExceptionchannel stoppedAdding one-line test results to commit status...Setting status of adc32d9e48710d4e6ee348462b68fe96155b511f to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/15355/ and message: 'FAILURE 5578 tests run, 10 skipped, 0 failed.'Using context: default

Previously, there was a licensing reason for the XML file to be used. Now that reason is resolved. Since this PR is open still, can you just port the line in the XML to be a more localized @SuppressFBWarning? Or if there's another solution go for it, but just commenting here to push this through and finish it off.

What's next here? Tests seem stuck, and the change seems a no-op.

For my part, I would love to see the XML file disappear entirely and each suppression move adjacent to where it happens or be fixed.

That seems reasonable, but probably warrants a separate PR, whereas the current one has become a comment-only change (nothing wrong with that, of course, but it'd be good to squash and rename the PR). @youngoli ?

Ah sorry, forgot about this PR for a while. I agree with both of those comments: The XML file disappearing would be great but I don't think it should be in this CL, it should be done all at once.
I'll squash and rename the PR when I get a chance.

Ah, ok. Well regardless adding the suppression should at least be done in a different PR, so I just squashed the commits into one that only changes the comment in findbugs-filter.xml. Since it's only a comment change I think even if some of the tests fail at this point this should get merged.

Agreed


Make it easy to embed ads

I want to embed ads using the same mechanism as <!—more—>
And want to generate about 3 ad codes with google adsense for each blog and specify the ad like <!—ads1–>

#423


Add review post state

A post can be in one of two states: draft or published. I'd like to propose adding an additional review state. I have two rough use cases below:

As a user I'd like to mark a post as being ready for review by an editor so that the editor is aware the post has been finished.
As an editor, I'd like to see a list of posts that are ready for review so I can easily find posts that need to be reviewed.

Even in situations where the editor and user are the same person, this still helps organise posts in my opinion. I'm interested to know what the Ghost team thinks.

I could see this being really useful, just by the two use scenarios you have applied. No doubt there will be even more though! I have so many draft posts, and most are already finished it's just a pain to find them to publish them, so I myself would use this for sure.

@jonblack & @HoddzDJ - really appreciate your suggestions. Could you please submit them to the wishlist instead of GitHub? There we can measure traction across a wider audience - you can access the wishlist direct from the admin panel.

I've added this to the wishlist: http://ideas.ghost.org/forums/285309-wishlist/suggestions/9596856-add-review-post-status


Merge 1.X branch resolved issues with master

Hi @nmccready
I've tried to merge but I don't know that merge, please you try it.

Yeah, this is going to be tough as hell, might be easier to cherry pick.

I haven't check this project for a few weeks and I just came back today after seeing the release of Leaflet 1.0. Now, I see that there is a leaflet-1.X branch on this repository that is released on NPM. Thus, it's not really clear what branch/package a user should use in order to integrate with Leaflet 1.0.
I think it would be great to clarify this in the README because now it's quite misleading. Also as a contributor, on which branch should I submit a PR to fix a bug due to latest Leaflet?
Thanks by advance

I've started to work on this today, please check the project Version 3.x

OK thanks.
Where should I submit the PR?

For leaflet 1.x compatibility on branch leaflet-1.X

Will do then :+1:


Inconsistent timeout behaviour when attaching an interceptor that accesses the ResponseBody

Originally we had some tests against Retrofit (2.0.0-beta3) that tested timeouts simply by exercising MockWebServer and everything worked fine we were able to simulate a socket timeout situation. After Retrofit (2.0.0) upgraded its OkHttp dependency to 3.2.0 things started to behave weirdly.
See the following test:
import okhttp3.OkHttpClient;
import okhttp3.Request;
import okhttp3.logging.HttpLoggingInterceptor;
import okhttp3.logging.HttpLoggingInterceptor.Level;
import okhttp3.mockwebserver.MockResponse;
import okhttp3.mockwebserver.MockWebServer;
import org.junit.After;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;

import java.io.IOException;
import java.net.SocketTimeoutException;
import java.util.concurrent.TimeUnit;

public class TimeoutTest {
    private MockWebServer mockWebServer;
    private OkHttpClient okHttpClient;

    @Rule
    public ExpectedException expectedException = ExpectedException.none();

    @Before
    public void setup() throws IOException {
        mockWebServer = new MockWebServer();
        mockWebServer.start();

        okHttpClient = new OkHttpClient.Builder()
                .readTimeout(100, TimeUnit.MILLISECONDS)
                // Remove this or change the level to make the test pass
                .addNetworkInterceptor(new HttpLoggingInterceptor().setLevel(Level.BODY))
                .build();
    }

    @After
    public void teardown() throws IOException {
        if (mockWebServer != null) {
            mockWebServer.shutdown();
        }
    }

    @Test
    public void test() throws IOException {
        mockWebServer.enqueue(new MockResponse()
                .setBody("12")
                .clearHeaders()
                .setHeader("Content-Length", "10"));

        Request request = new Request.Builder()
                .url(mockWebServer.url("/"))
                .build();

        expectedException.expect(SocketTimeoutException.class);

        okHttpClient.newCall(request).execute().body().string();
    }
}

This test tries to simulate a timeout just using OkHttp. I did copy the MockResponse semantics from one of your test cases.
The issue here is that when you have the HttpLoggingInterceptor attached, you get a ConnectException when the interceptor accesses the response body.
However, if you remove the logging interceptor or set it to log only the request URL or headers, everything works just fine.
The behaviour seem to have changed between OkHttp 2.7 and 3.2 as timeout tests worked fine in our case when using OkHttp 2.7. Of course OkHttp has gone through a major change between 2.x and 3.x thus it is understandable that behaviour changes. However, I'm not so sure if the contract from the client's point of view is stable as adding an interceptor affects the output exception.
In general it would also nice to have some examples how to test read, write and connection timeouts since we have a special behaviour in our code that is affected by timeouts and we want to test that code.

The root cause is that the logging interceptor triggers the body to be loaded, and when that fails we retry the whole request. We could potentially mark the response as “completed” when we start reading the body and refuse to retry once that happens.

We should presumably look at
open fun isOneShot(): Boolean = false

Marking as won't fix.  Hasn't gotten much attention since 2016 and we don't actively improve logging interceptor.


Off Screen

When working in the admin panel User/Admin the options under Action keeps moving offscreen

You need to scroll down the page to the bar below, to navigate right in order to get everything

Is it possible to make the gap between the Avatar and the IP smaller perhaps so that everything will fit in properly without scowling to the right.
This is not because of my monitor size.

@Nigrini You can actually edit yourself the template file. It's a pretty simple thing to do.
The CMS use responsive design for the display of pages so the size of the objects are not set but computed by the browser rendering the page.
PM


add front service

Add front service deployment with nginx configuration to route api and dashboard requests to front service.

@g4s8 looks good, but we also have to exclude dashboard/api slices from artipie, otherwise there will be two of them

@olenagerasimova sure, this nginx configuration routes all /api and /dashboard to front service, they will not go to artipie service.


Fixed #19215 -- ImageField's “Currently” and “Clear” Sometimes Don't Appear

Hello!
Thanks Mariusz for Cc'me in this ticket!
I just applied the mcardillo55's fix + added a selenium test. In his pull request I didn't see any review/comment/change required to apply.
To run the test please do: ./runtests.py admin_widgets.tests.ImageFieldWidgetsSeleniumTests --selenium=<chrome|firefox|safari> --parallel=1
Thanks!

buildbot, test on selenium.

The pull-requests-selenium/database=postgres,label=focal-pr,python=python3.10 buildot fails because of

This test became extremely flaky few weeks ago :disappointed: Would you like to try to improve it?

buildbot, test on selenium.

Done! @felixxm

Done! @felixxm

Many thanks! Merged in 1d6948096f6fe7aa887d651e01e9af8e4ef349a2.

@mcardillo55 Thanks for the initial patch :+1:

buildbot, test on selenium.

Merged in c0fc1b5302f5d9d82e2255fb5758321fbac34949.


[nana] One more dependency

Port: nana
One more Xorg dependency needed: libxcursor-dev

@linquize Thanks for reporting this issue. I have submitted a PR https://github.com/microsoft/vcpkg/pull/10605 to add this dependency.

This issue has been fixed by PR #10605.


python3Packages.energyflow: init at 1.3.2

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 192781 1

2 packages failed to build:

python310Packages.energyflow
python39Packages.energyflow

2 packages built:

python310Packages.wasserstein
python39Packages.wasserstein

Result of nixpkgs-review pr 192781 1

2 packages failed to build:

python310Packages.energyflow
python39Packages.energyflow

2 packages built:

python310Packages.wasserstein
python39Packages.wasserstein

Just wanted to verify that it didn't have anything to do with my garbage internet connection. It looks like setuptools builds now require the pytest-runner package as a native build input.

@GrahamcOfBorg build python3Packages.energyflow

https://github.com/NixOS/nixpkgs/pull/192781/checks?check_run_id=8531991299

This second failure is the one I was getting until I added that native build input. I am not entirely sure what is going on because it seems like without it, Python tries to fetch from PyPI during the buildPhase, which is not allowed since it is sandboxed.

I don't get why this issue is only seen on Linux.

I think it is because sandboxing is on by default on Linux but not on MacOS. I think this can sometimes break the hermeticity of builds and still allow network access during the build phase. It is also somewhat mysterious to me, though. Maybe @jonringer or @FRidh would have more insights.

For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)

Could you give that a try to see if it still builds for you in that case?

Result of nixpkgs-review pr 192781 run on x86_64-darwin 1

2 packages failed to build:

python310Packages.energyflow
python39Packages.energyflow

2 packages built:

python310Packages.wasserstein
python39Packages.wasserstein

@GrahamcOfBorg build python3Packages.energyflow

@GrahamcOfBorg build python3Packages.energyflow


Update --local-engine to account for changed host architecture of 32-…

…bit Android debug builds.
Roll engine to 7480e32854606e554ae37f8bd241c050bdc565c4.

This appears to have broken the build.

https://github.com/flutter/engine/pull/3883


[LIB] Split assertions out of lib/Basics/debugging.h

To resolve the dependency of every bit of code on heavy core functionality, split assertion code out of debugging.h and provide TRI_ASSERT and ADB_PROD_ASSERT separately from include files in three modes

Light eassertions: these do not depend on anything more than the C++ stdlib and call std::terminate() to end the process.
Maintainer mode assetions: these use ArangoDBs CrashHandler to crash the program if an assertion fails in the case of TRI_ASSERT and ADB_PROD_ASSERT
Production mode assertions: these do not crash the arangod process for TRI_ASSERT, but do crash for ADB_PROD_ASSERT

Sorry for jumping the gun on this one; It turned out that light mode was not just superflous, but actually did not really work.
One would have had to compile every bit of code in two modes. I added a "light" crash handler instead in #17616 Now one can compile every library and link the light crash handler for testing.
At some point we can get rid of the "light" crash handler again: Once I understood the dependencies from the CrashHandler through the logger downwards, we can likely agree on a base library of arangodb stuff that compiles very quickly and gives valuable information on crashes.


Account activity index

Introduce composite activity index based on the number of account trades/transfers during the last month.

Moved to #106


Add tables to Report Summary page

Table 1 shows mapped geologic hazards, relative severity, and corresponding report pages for hazards that intersect AOI
Table 2 lists other related data (lidar, imagery, etc.) that intersects AOI

Page 2 of https://docs.google.com/document/d/1F7kHj3PBc2DJrQgbNOlHTHLoi9qK-QezcJ_0QzBn97Y/edit

We don't currently have page numbers. I assume that adding them would be part of this issue as well?

Are you able to use document.getElementById('elementId').offetHeight or similar to determine when a new page will begin, along with the page dividers?


Move DJL serving to djl-serving repository

Change-Id: I94b2a2c5710241565483aa3ba7da845d7064b9e7
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1170 (0da0271) into master (8af377c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1170      +/-   ##
============================================
- Coverage     70.28%   70.26%   -0.02%
+ Complexity     5360     4962     -398
============================================
  Files           514      474      -40
  Lines         23789    21927    -1862
  Branches       2567     2314     -253
============================================
- Hits          16720    15408    -1312
+ Misses         5706     5315     -391
+ Partials       1363     1204     -159

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/Input.java
66.66% <0.00%> (-11.12%)
:arrow_down:

api/src/main/java/ai/djl/modality/Output.java
88.88% <0.00%> (-7.41%)
:arrow_down:

.../main/java/ai/djl/repository/SimpleRepository.java
78.04% <0.00%> (-3.66%)
:arrow_down:

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
:arrow_down:

api/src/main/java/ai/djl/util/Platform.java
42.30% <0.00%> (-1.93%)
:arrow_down:

api/src/main/java/ai/djl/repository/Artifact.java
86.17% <0.00%> (-1.63%)
:arrow_down:

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
40.00% <0.00%> (-1.18%)
:arrow_down:

.../java/ai/djl/repository/RepositoryFactoryImpl.java
74.75% <0.00%> (-0.98%)
:arrow_down:

...ain/java/ai/djl/tensorflow/engine/TfNDManager.java
87.50% <0.00%> (-0.79%)
:arrow_down:

...ava/ai/djl/translate/ServingTranslatorFactory.java
79.60% <0.00%> (-0.66%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af377c...0da0271. Read the comment docs.


Fix project failing to build in Xcode

The project won't build after being cloned from the repo.
First, the AudioKit package is not correctly fetched (the same happens for the develop branch). Then there are two non-unwrapped optional errors. These were fixed using code from the develop branch.

I tried re-cloning the main branch and now fetching AudioKit seems to work fine. Don't really know how Swift Packages work, so maybe that changed line in the Package.resolved file is unnecessary.
But the fetching definitely failed the first time I cloned it. Changing the AudioKit to the v5-develop branch then back to v5-main fixed the problem. Cache issues, perhaps?

I am not sure about Package.resolved...


Introduced a PRIVATE(member) macro

solution proposal for #4372

#4511 now contains all the relevant changes from this PR, plus much more, so I'm closing this one.


Screenshot during integration test sometimes contains "crosshair"

Minimal project in Git: https://github.com/chris-rutkowski/my_screenshot
Steps to reproduce
Have an Integration (E2E) test:

Tap a button
pump and settle
Take a screenshot and compare it with a golden image

await tester.tap(Key('button');
await tester.pumpAndSettle();
final bytes = await binding.takeScreenshot('screenshot');
await expectLater(bytes, matchesGoldenFile('snapshot.png'));

The result is flaky, sometimes crosshair is caught on the screenshot, sometimes not - as in the example.
An attached example is from a different project, but with exactly the same steps - tap a button, pump and settle, and eventually take and compare the screenshot.

Can we remove the crosshair from being displayed?
Should the pumpAndSettle await till the crosshair is removed from the previous steps?

This issue can be mitigated by trivial await Future.delayed(const Duration(seconds: 1)), but this is mitigation, not a solution.
Proof of an issue

Expected

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.2, on macOS 13.0 22A380 darwin-arm64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.78.2)
[✓] Connected device (4 available)
[✓] Network resources

HI @chris-rutkowski. I'm currently unable to reproduce this issue with the sample code provided both on Android and iOS. Can you provide further explanation or instances in which this issue occurs? Also, can you create a new flutter project to confirm this issue occurs?

@dam-ease
Thank you for taking the time to look into this problem. Here's the relevant context:

On our CI (GitHub Action, macos-13), we're seeing a high failure rate of around 75%. The screenshot comparison fails due to the presence of a crosshair which does not appear in our pre-recorded images.
The issue seems elusive as it's not replicable on my local Mac setup, where screenshots consistently do not show the crosshair.
I tried reproducing this problem in a sample repository, but couldn't. It's possible that the issue might be prevalent in a more resource-intensive application.

In essence, the undesired appearance of this crosshair is causing difficulties. If possible, I'd like to find a way to turn off its visibility during integration tests, as it currently isn't providing any meaningful value.

Hi @chris-rutkowski.
Few suggestions:

Try adding await binding.convertFlutterSurfaceToImage(); after first instance of pumpAndSettle()

app.main();
await tester.pumpAndSettle();
await binding.convertFlutterSurfaceToImage();
await tester.pumpAndSettle();

Then run flutter test integration_test --update-goldens for the test framework to create the missing golden files, instead of comparing them and then go ahead to run the usual tests.

Code Sample

void main() {
  final binding = IntegrationTestWidgetsFlutterBinding.ensureInitialized();

  group('end-to-end test', () {
    testWidgets('tap on the floating action button, verify counter', (tester) async {
      app.main();
      await tester.pumpAndSettle();
      await binding.convertFlutterSurfaceToImage();
      await tester.pumpAndSettle();
      expect(find.text('0'), findsOneWidget);
      final Finder fab = find.byTooltip('Increment');
      await tester.tap(fab);
      await tester.pumpAndSettle();
      // expect(find.text('1'), findsOneWidget);
      final bytes = await binding.takeScreenshot('screenshot');
      await expectLater(bytes, matchesGoldenFile('snapshots/value-1.png'));
    });
  });
}


[#336] [#338] Update new_project.kts to choose between XML or Compose and update documentation

Closes #336
Closes #338

What happened 👀
Update new_project.kts to be able to generate either xml or compose template project.

Add a new flag called template, the value can either be xml or compose
Ensure a project can be generated correctly for both options
Ensure the help message is up-to-date
Update verify_newproject_script.yml so the CI still works correctly

Insight 📝

Add keys and names for both xml and compose
Add logic to get keys and names depending on template type
Add validation for template type
Modify verify_newproject_script.yml to be able to run CI successfully
Modify README.md for the update

Proof Of Work 📹

xml
compose

No template type

Invalid template type

Apart from @Tuubz comment for the rest LGTM 🚀

@lydiasama Any final remarks? 🙏


fix sonar issue

Fix sonar issue about Array.reduce() call missing default value.
Link to original sonar issue:
https://sonarcloud.io/project/issues?resolved=false&severities=BLOCKER,CRITICAL,MAJOR,MINOR&sinceLeakPeriod=true&types=BUG&id=SAP_open-ux-tools&open=AY6jPjnTed7kdlBgm2p4&tab=code

Do we need a test for this?

Good question. I ran unit tests locally and checked test coverage. This function is already covered by unit tests and being triggered 16 times. I am not sure why test is not triggered in this PR.


feat: migrated to openai==1.28.0

Resolves #71

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review


Validate volume names for the local driver.

Closes #16132
Closes #16140

LGTM

not fond of having it in utils package, but since we need this for 1.9 it's fine for now.

@calavera Why the utils package ? It's only related to package volume for now right ; so it could be in the volume package. As @tiborvass not fond of a utils package.. you can put anything in there :stuck_out_tongue_closed_eyes:.

I'm not fond of that package either, that's not the only file there, fwiw, we already have a bunch of things in that utils package. I'm open to suggestions but I didn't want to introduce a new package only for this.

@calavera ohh for real.. never saw the package lol.. need to open my eyes more :smile_cat:.
Then I'm with @tiborvass, let's go with it for 1.9.0 and maybe create an issue on "cleaning / moving things out of utils package" :wink:

Thanks @calavera! LGTM. Only concern: how do we handle migration of existing volumes that are no longer valid?
Also: lets keep the discussion open for loosening up and being less restrictive after 1.9

oh, after looking at the error code that is (no real show-stopper, but 4XX seems more appropriate)

thanks for addressing the issues @calavera

Will run these tests locally

Added impact/changelog; do we need a mention in "deprecations" to tell people that some volume names are no longer valid?

Tests are good locally.
LGTM
@thaJeztah for the merge if docs are needed.

@calavera I think we should add a mention to https://github.com/docker/docker/blob/master/docs/misc/deprecated.md so that people are aware that this changed, wdyt?

@thaJeztah this is not a feature change or improvement, this is a bug fix from my point of view, it should go into the bug fixes section in the backlog.

@calavera cool :+1:

Removing impact/changelog since volume top level command is introduced in 1.9


docker_options/base_image with docker-api v1.20.0 result in a 404 error

Hi,
Quick issue here, with the docker-api gem v1.20 (which I believe is shipped with ChefDK 0.4.0) I'm somehow getting a 404 error with chef-provisioning-docker (0.5.2):
    ================================================================================
    Error executing action `create` on resource 'machine_image[web_server]'
    ================================================================================

    Docker::Error::NotFoundError
    ----------------------------
    Expected([200, 201, 202, 203, 204, 304]) <=> Actual(404 Not Found)

    Resource Declaration:
    ---------------------
    # In /home/sjourdan/dev/chef-repo/provisioning/webserver-docker.rb

      3: machine_image 'web_server' do
      4:   recipe 'apache'
      5:
      6:   machine_options :docker_options => {
      7:       :base_image => {
      8:           :name => 'ubuntu',
      9:           :repository => 'ubuntu',
     10:           :tag => '14.04'
     11:       }
     12:   }
     13: end
     14:

My current workaround is to simply rollback to the 1.18 version of docker-api, so the problem disappear.

I had the same issue. Upgrading to docker 1.5.0 fixed my issue.
Docker version 1.5.0, build a8a31ef

You're right I was using docker 1.3 from CentOS/RHEL 7.0.
Upgrading Docker to 1.5 did the trick, thanks!


Bonfire drop it -- unclear specification

Challenge http://www.freecodecamp.com/challenges/bonfire-drop-it has an issue.
It's unclear from the wording whether you're supposed to drop, then immediately stop,  in which case
the output of drop([1, 2, 3, 4, 1, 2], function(n) {return n >= 3; })
would be [3, 4, 1, 2]
or do you mean drop all that don't meet the criteria which would return [3, 4].

Drop the elements of an array (first argument), starting from the front, until the predicate (second argument) returns true.

The bonfire is asking you to return the array after the first true condition is met (if there is a match). It is not asking you to remove all elements that do not match. I hope this helps! :)

None of the test cases actually test for that. A simple arr.filter(func) will pass all test cases. arr.filter(func) removes ALL elements that do not match so the test cases do not test for an array after the first true condition is met. I hope that make sense. I give an example above.

When you run the code of a bonfire it errors what that bonfire excepts. In this case the it requires that all the values that meet the test provided should be returned ([3, 4])(https://github.com/FreeCodeCamp/freecodecamp/blob/master/seed_data/challenges/basic-bonfires.json#L1311)
Please check these kinds of problems in http://gitter.im/freecodecamp/help before posting issues here. As for the wording if you have any suggestions please do not hesitate to put them here and I will submit a pull request fixing the issue! :blush:

I think I'm just not making myself clear since I agree with what you're
saying
My understanding is that if you pass  [1,2,3,4,1,2,3,4]  with a function(x)
{
return x >=3; } you should get [3,4,1,2,3,4] returned.  Right now you can
pass the bonfire by doing a simple arr.filter that returns [3,4,3,4] which
does meet the specification of the bonfire. So you may mean drop then stop,
but the tests don't actually test if you are indeed stopping after the
first returned true.
I didn't have any problems "passing" the bonfire, but I thought the
intention was to meet the criteria. In the future, I will check the gitter
link as you suggested..
Thanks.
On Tue, Jul 7, 2015 at 5:09 PM, benmcmahon100<EMAIL_ADDRESS>wrote:

When you run the code of a bonfire it errors what that bonfire excepts. In
this case the it requires that all the values that meet the test provided
should be returned ([3, 4])(
https://github.com/FreeCodeCamp/freecodecamp/blob/master/seed_data/challenges/basic-bonfires.json#L1311
)
Please check these kinds of problems in http://gitter.im/freecodecamp/help
before posting issues here. As for the wording if you have any suggestions
please do not hesitate to put them here and I will submit a pull request
fixing the issue! [image: :blush:]
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/freecodecamp/issues/1225#issuecomment-119358508
.

Closing as stale.

function dropElements(arr, func) {
var val = arr.findIndex(func);
var newarr = [];
if(val >= 0) {newarr = arr.slice(val, arr.length);}
else {}
return newarr;
// Drop them elements.
}
dropElements([1, 2, 3, 4], function(n) {return n >= 3;});


Share cookies, add logout on core to sign out cookie in MVC samples

Note this required updating a bunch of packages to pull in the cookie/dataprotection interop 2.2 code

This looks to only be changes to samples, right? So it's more of a doc update on how to use the existing library?

Yeah I believe so, so if we configure both apps to use the same cookie, and just add a controller action to logout/clear the cookie on the Core App side, both logouts work and there's no antiforgery issue

By enabling this, it will cause all encrypted cookies to be invalid on the framework app, right? Effectively logging everyone off as a one-time part of the migration?

Yeah changing the cookies settings like this will cause all all existing cookies to no longer be valid

I think a one-time logout is fine. It's inevitable that it will happen eventually as part of migration.

Here's a fun thread for background reading: https://github.com/aspnet/AspNetKatana/issues/435

Are we okay with merging this as is, and I'll file a follow up issue/PR to address / add the new helpers?

Yep, I think we can merge this as is but let's get an issue to track adding helper methods

Actually, I see you're using #121 for that. That works. Thanks!


lxd/storage/drivers/zfs: Close stderr after copy

In an error case, if ioutil.ReadAll(stderr) ran before the goroutine
ended, ReadAll would hang forever. It wouldn't happen every time,
but if called often enough it would eventually hang. This would make
it impossible for the source to clean up their instances since the
resource is busy.
This closes stderr at the end of the goroutine, making it impossible for
ReadAll to hang.
Signed-off-by: Thomas Hipp<EMAIL_ADDRESS>

Testsuite passed


Geojson renderer

We have to release Windshaft before and upgrade to the new version.
cc/ @rochoa

We have to release Windshaft before and update to the new version.

OK!

Released Windshaft 1.8.0. Can I merge?

:ship: :it: !


Remove old dependency

Coverage remained the same at 77.636% when pulling fd2e9c809a4fd7072d95b069a9e6f139428bf127 on dep into a8b3e6b212892106b8e297889ea69026e633f92d on master.


Windows share hub integration

Please integrate moderndeck with windows 10 share hub. This is the only thing missing. Even the official webapp has this feature.

I'll see if I can enable this functionality with electron!

I'll see if I can enable this functionality with electron!

It seems like Electron doesn't support it, and I'm not sure if it can, because I don't know if the sharing functionality works on Win32 apps. I'll keep it open because this is definitely a feature I want added.

It seems like Electron doesn't support it, and I'm not sure if it can, because I don't know if the sharing functionality works on Win32 apps. I'll keep it open because this is definitely a feature I want added.

I don't know if this helps, but here's what I found
https://blogs.windows.com/windowsdeveloper/2017/12/04/extend-desktop-application-windows-10-features-using-new-visual-studio-application-packaging-project/

I don't know if this helps, but here's what I found
https://blogs.windows.com/windowsdeveloper/2017/12/04/extend-desktop-application-windows-10-features-using-new-visual-studio-application-packaging-project/

https://www.electronjs.org/docs/tutorial/windows-store-guide

https://www.electronjs.org/docs/tutorial/windows-store-guide


Typo in HOW.md

https://github.com/Kindelia/HVM/blob/14a02de71bd244247abc12749bbc37461feee33d/HOW.md?plain=1#L572
When introducing Dup-Sup, at one point you use the old notation for superposition (<r s>), but everywhere else the other style is used. This should read dup a b = {r s} if I'm not mistaken.

You're right. Can someone PR a fix?

Fixed in 05ad74f


support fortags param in google_maps_photos

https://github.com/outscraper/outscraper-python/blob/c531f9a4d9ae0bbd29067fc93d68bbd763657c39/outscraper/api_client.py#L437-L439
api docs reference a tag query parameter to filter by photo type. can this support be added to this package

Added in https://github.com/outscraper/outscraper-python/releases/tag/v5.1.0


Tabulate CSV Data

Theme version and system environment

Minimal Mistakes version: 4.26.2
Ruby gem or remote theme version: 3.4.0
Jekyll version: 4.3.4
Git repository URL: https://gitlab.com/diegobiavati/blog
URL to the page with the problem: https://diego.biavati.nom.br/exército/recodom/códigos/recodom/
Operating system: Linux (Debian) 12
Browser version: Firefox 128 - ESR

What happened?
I'm trying to generate an article based on a CVS file, following this tutorial https://jekyllrb.com/tutorials/csv-to-table/, when I have a table in markdown and then load the script, the error doesn't happen, but the information is doubled.
When I leave the script just to generate the spreadsheet, I receive the following error:
  Liquid Exception: Liquid syntax error (/builds/diegobiavati/blog/.gem/ruby/3.3.0/gems/minimal-mistakes-jekyll-4.26.2/_includes/page__related.html line 9): 'for' tag was never closed included in /builds/diegobiavati/blog/.gem/ruby/3.3.0/gems/minimal-mistakes-jekyll-4.26.2/_layouts/single.html
                    ------------------------------------------------
      Jekyll 4.3.4   Please append `--trace` to the `build` command
                     for any additional information or backtrace.
                    ------------------------------------------------

https://gitlab.com/diegobiavati/blog/-/jobs/8296173763
Expected behavior
I would like to generate a spreadsheet dynamically whenever I load the CVS file with the updates.
Steps to reproduce the behavior
Not
Other
No response

Problem's with your own code:
https://gitlab.com/diegobiavati/blog/-/blob/702d6d2785532e43d917aa059d0011bb1a1e8b0f/_posts/2024-10-18-recodom.md?plain=1#L28

You did not fix anything. The superfluous {% endfor %} is still there. Get rid of it and you should be fine.


Run chaining with MM2 Seeds

TODO: clean up commits that came in from anchmer-fast-score and rebase on dev-0.6


It's common for clis to use - rather than _

A bit of a nit, but it's common for CLIs to favor - over _ for the names of options
So one would expect path-to-code rather than path_to_code
(langchain_3_11_4) ➜  core git:(eugene/unsafe_pydantic) ✗ mypy_clean_slate --help
usage: mypy_clean_slate [options]

CLI tool for providing a clean slate for mypy usage within a project.

Default expectation is to want to get a project into a state that it
will pass mypy when run with `--strict`, if this isn't the case custom
flags can be passed to mypy via the `--mypy_flags` argument.

options:
  -h, --help            show this help message and exit
  -r, --generate_mypy_error_report
                        Generate 'mypy_error_report.txt' in the cwd.
  -p PATH_TO_CODE, --path_to_code PATH_TO_CODE
                        Where code is that needs report generating for it.
  -a, --add_type_ignore
                        Add "# type: ignore[<error-code>]" to suppress all raised mypy errors.
  --remove_unused       Remove unused instances of "# type: ignore[<error-code>]" if raised as an error by mypy.
  -o MYPY_REPORT_OUTPUT, --mypy_report_output MYPY_REPORT_OUTPUT
                        File to save report output to (default is mypy_error_report.txt)
  --mypy_flags MYPY_FLAGS
                        Custom flags to pass to mypy (provide them as a single string, default is to use --strict)

Yeah fair - I don't really have any strong opinion on - vs _ so am happy to use -.


Rounding to the "Nearest" Whole Unit of Currency

While I've looked through the code and documentation, I have not found a built-in method for rounding, using any of the available rounding methods (http://moneyphp.org/en/latest/features/operation.html#rounding-modes), to the "nearest" whole unit of currency.  Am I just over looking it? If so, what is the method?
Inputs and [expected] corresponding outputs:
ROUND(0.01 USD) = 0.00 USD
ROUND(0.49 USD) = 0.00 USD
ROUND(0.50 USD) = 1.00 USD
ROUND(0.51 USD) = 1.00 USD
ROUND(1.01 USD) = 1.00 USD
ROUND(1.49 USD) = 1.00 USD
ROUND(1.50 USD) = 2.00 USD
ROUND(1.51 USD) = 2.00 USD

This would be really nice to have, here is what I'm doing at the moment:
$money = Money::USD(151);
$rounded = round($money->getAmount(), -2);
$result = Money::USD($rounded); // 200

@oligus Well, I guess that's two votes!  For such a well-developed library/project, it's surprising this kind of rounding isn't needed more often and isn't yet incorporated in Money.  I'm sure there are a few nuances to a complete implementation including currency agnosticism.
The logic in your solution is more concise than mine, which is also a currency specific (USD) solution.  I attempted to avoid native, numeric types (e.g. integer, float) and operations in the intermediate logic since in any instance that could, potentially involve large values.  As you know, PHP's built-in round() function always returns a float, and therefore has the storage and operational "features" of that type.
My solution should probably also include some exception handling for the various exceptions thrown by Money.  I contemplated writing a custom class that extends Money in order to add this functionality in a manner that was integrated into an overall money solution, but the maintainers chose to define the Money class as FINAL.
Here's my solution in case it's helpful to you or you wish to expand upon it.
// Obtain amount as string from existing Money object
$str = $input->getAmount();

// If not zero...
if ($str !== '0') {

	// Obtain whole units of currency
	$whole = substr($str, 0, strlen($str)-2).'00';

	// Obtain fractional units of currency
	$factional = (int) substr($str, -2);

	// If there are no whole units of currency...
	if ($whole === '00') {

		// Force to single zero
		$whole = '0';
	}

	// Create money object from whole units of currency
	$result = Money::USD($whole);

	// If factional units of currency should round to the
	// nearest whole unit of currency...
	if (abs($factional) >= 50) {

		// If whole units of currency are positive...
		if ($result->isPositive() === true) {

			// Addend should be positive
			$addend = Money::USD(100);

		// Otherwise, if whole units of currency are negative...
		} else if (result->isNegative() === true) {

			// Addend should be negative
			$addend = Money::USD(-100);

		// Otherwise...
		} else {

			// If fractional units of currency are positive...
			if ($factional >= 0) {

				// Addend should be positive
				$addend = Money::USD(100);

			// Otherwise...
			} else {

				// Addend should be negative
				$addend = Money::USD(-100);
			}
		}

		// Add appropriate unit of currency corresponding to
		// fractional units of currency to facilitate the
		// rounding operation
		$result = $result->add($addend);
	}

// Otherwise...
} else {

	// Convert value to money object
	$result = Money::USD(0);
}

@broberts-mrmc @oligus This sounds like a great addition to this library. I will try to find some time to work on it.

I think it is pretty easy to come up with a solution. The only question is where to add the method. Rounding to nearest whole unit requires to know the number of subunits. So if we add the method rounded to Money than it might look like this.
function rounded(int $subunits) {
  return new Money(Number::roundMoneyValue($this->amount, 0, $subunits));
}

This is not tested yet, but I guess it should work.

I agree, my proposed name is not ideal. roundToSubunits sounds good. We do not have any aliases, and my suggestion would be to not ever have them. Just pick a name that suits you best, and we will discuss it when the PR is there.

Isn't this just half away from zero?
https://3v4l.org/AAlXq

Was any progress ever made on this? It'd be really cool to have this built into the library

I just had a quick go and this should work, with all currencies?
use Illuminate\Support\Str;
use Money\Money;

$price = Money::GBP(1337);

// Round up the nearest whole unit, which will end with '00'
while(!Str::endsWith($price->getAmount(), '00'))
{
    // Add one unit (pence) on each iteration
    $price = $price->add(new Money(1, $price->getCurrency()));
}

// $price is now equal to 1400


opencv program1

@sarveswar1 contribute here instead https://github.com/Ishaan28malik/Get-Dev-Resources


Added prompt parameter for LLM models to allow for passing in a custo…

Added prompt parameter for LLM models to allow for passing in a custom prompt or the path to a text file containing the prompt. This can be done for the agent system prompt, the checklist creation prompt, the summary prompt, and the justification prompt.
Closes #15

Could we also update documentation for how to customize the prompt? You may want to work with @aadesoba-nv to ensure this is covered in the customization notebook https://github.com/NVIDIA-AI-Blueprints/vulnerability-analysis/pull/18

Could we also update documentation for how to customize the prompt? It would be good to work with @aadesoba-nv to ensure this is covered in the customization notebook #18

I chatted with Adeola, her recommendation is to leave this out of the customization notebook. The notebook can cover a subset of customizations while the README covers the full set.


Userretention automation tests to main branch

All these tests are existed and running green on v2.9

I moved userretention tests to main in a different PR and it got merged. I am closing this PR.


Improve parsing in await and yield context

Fixes #44459
It works. But I don't know why 🤷♂.

I need to run through it in the debugger to understand it myself, but my guess is that isBindingIdentifier accepts await and yield as keywords where isIdentifier doesn't (when not in an await/yeild context). Then something in parseVarExpression explicitly rejects await/yield. Not sure why it incorrectly works today.

Well, I was sort of right. It's actually an error in the binder, from checkContextualIdentifier, not parseVarExpression. A better fix would be to change the definition of inYieldContext and inAwaitContext in isIdentifier to skip let await/let yield as well.

Now that I've checked how to clear Yield/AwaitContext, I see that isBindingIdentifier is the same as isIdentifier without the special cases for yield/await.
I'd like to see two things:

Check whether the special case for yield/await is even needed. Try deleting it from isIdentifier and report back how baselines change. It could be that the binder has better error messages in all cases.
If that doesn't work out, put a small comment above isBindingIdentifier saying // let await/let yield are allowed here and disallowed in the binder (or something similar)

I think it's probably fine to call isBindingIdentifier instead of isIdentifier; isIdentifier hasn't changed for 5 years, and I assume @rbuckton created a isBindingIdentifier last year instead of passing a boolean to isIdentifier for performance reasons.

Moved to #44680.


Fix to #1838 - Query :: implement CLR null semantics for query predicates

Problem is that database semantics for null equality are different from c#, resulting in unexpected results for some queries (involving null value comparisons)
Fix is to compensate this by introducing additional terms in the predicate, effectively converting 3-valued logic into 2-valued logic.
a == b -> [(a == b) && (a != null && b != null)] || (a == null && b == null))
a != b -> [(a != b) || (a == null || b == null)] && (a != null || b != null)]
also added transformations for cases when one of the operands is negated
!a == b -> [(a != b) && (a != null && b != null)] || (a == null && b == null)
!a != b -> [(a == b) || (a == null || b == null)] && (a != null || b != null)
Some terms can be removed if one of the terms is not nullable, e.g:
nullableA == nonNullableB -> (nullableA == nonNullableB) && (nullableA != null)
We do additional optimization for simple predicate of a == b where a and b are nullable:
a == b -> (a == b) || (a == null && b == null)
This is still 3-valued result, true being returned when 'a' and 'b' are in c# terms, and either false or NULL when they are not equal.
This optimization can only be applied if the predicate does not contain any NotEqual or Not operations.

@anpete @divega

Really great job! :shipit:


stack expects each tensor to be equal size, but got [256,835] at entry 0 and [256,829] at entry 1

Thanks for your Great Work!
When I try to train the model， I get the following error:“stack expects each tensor to be equal size, but got [256,835] at entry 0 and [256,829] at entry 1”.
it should be that the input data size is not consistent, how should I correct it?
Thanks in advance for your answer!

I found the descriptors are not the same size, do you konw which step is wrong, leading to a different descriptor sizes?

Thank you for your interest in our work.
The issue you got shows that you probably forgot to keep the threshold with Superpoint when running Hloc.
Note that only when you have the same number of descriptors per image, you can train the framework with batch size > 1 (in the code the batch size is 8)
Another simple solution is: change the batch size to 1 when training. It will work but I'm not sure it gonna show the best results.
`class SuperPoint(nn.Module):
"""SuperPoint Convolutional Detector and Descriptor
SuperPoint: Self-Supervised Interest Point Detection and
Description. Daniel DeTone, Tomasz Malisiewicz, and Andrew
Rabinovich. In CVPRW, 2019. https://arxiv.org/abs/1712.07629

"""
default_config = {
    'descriptor_dim': 256,
    'nms_radius': 4,
    'refinement_radius': 0,
    'do_quadratic_refinement': 0,
    'keypoint_threshold': 0.005, # please change to 0.0
    'max_keypoints': -1, # please change to number keypoints you need, ex: 2048
    'remove_borders': 4,
}`

Thank you for your quick response！I'll have a try.

Sorry to bother you again, but I still have the same problem after modifying max_keypoints=2048, it seems that it's because too few descriptors are fetched, for example [256,835]  [256,829], so max_keypoints can't be limited uniformly, do you have any idea about the reason for this?

I think you forgot to change the threshold of 'keypoint_threshold': 0.005 to 'keypoint_threshold': 0.0`. Additionally, please change the config in Hloc at the parents configuration, the example I have shown above is just for a fast response but would not correctly set the Superpoint parameters for entire Hloc framework. This is why you still received the number of descriptors per image around 835 keypoints.

Hello, I have tried to set 'keypoint_threshold': 0.0 in the configs of Hloc, I think the set of configs are right.
Maybe it's that 2048 keypoints cannot be extracted from a single image, even if the threshold is set to 0.
I‘m not sure if  I understand correctly ?

Just try as I said, you will see the result.


new tpot owner: epistasislab

Hi tpot previous owner (rhiever) has given ownership to EpistasisLab.
Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi, unfortunately, I don't have a clue :/

Well, we're skipping a few tests, but everything else is looking okay. Off we go, thanks @bosr!

@bosr please let me know if you are interested in helping maintain the recipe! We always need more sharp-eyed users to keep us honest!

Thanks Nicolas! I would like to but I’m not sure I currently have enough bandwidth.
Cheers!

On 9 Oct 2018, at 04:16, Nicholas Bollweg<EMAIL_ADDRESS>wrote:
@bosr please let me know if you are interested in helping maintain the recipe! We always need more sharp-eyed users to keep us honest!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Ask email and token before computing

If the computation is going to be some hours long then I'd rather prefer to enter my email and submission token before to start the computational part, otherwise I need to be sure I come back at the computer to enter email+token before the 5h/10h deadline expires.
And if I run it overnight that may be a bit annoying.

Entering the e-mail and token at the end was designed to resolve this issue.  The idea is,

start your computation
come back in a couple hours when it is completed
generate a fresh token from the Coursera web interface
finish the submission process with your fresh token
Do you see any issue with this workflow?

the scenario I imagine is

the solution is computed within the time given time constraints (so it should be sent to coursera and graded accordingly)
I cannot come back to my computer before the given time constraint (so I cannot enter email+token in time)
I think if I enter email+token at the beginning then the solution could be sent over the network as soon as the computation finishes, whether I am in front of my screen or not.

Last I looked into it the token timeout was stated to be around 30 mins (although I have not observed this in practice), which is too short for the assignments where each problem could take a few hours to get 10 points.  Also note that the solutions of all problem parts need to be submitted together to get full credit.  This is a requirement of the Coursera platform.  You might need to run your solver for 6 hours locally and then perform the submission.

Oh, that's it. I thought the token verification could be done at any moment (for instance, as first step in the submit.py script). If that's not the case than this ticket can be closed :)

Unfortunately not, it all has to be sent to Coursera as a single payload see, https://github.com/discreteoptimization/assignment/blob/master/submit.py#L326
You might give the _credentials file a try, but this will fail if Cousera expires your assignment token.

I see. Then maybe you could count the total time from the moment the first instance starts till the moment the last instance is completed, and if that is < 10h then let the program waiting for email+token even if they are entered much later?

I don't follow your last comment.  The code does all of the computations then it prompts for email+token.  It's fine if they are entered much later, as long as the token is still valid in Coursera's system.