Missing/wrong pull requests for commits

Describe the issue
The current approach to associate commits with the pull requests is the following:

Fetch the commits.
Fetch the pull requests.
Check if the merge_commit_sha of the pull request matches the SHA of the commit.

github_commits.for_each(|commit| {
		let pull_request = github_pull_requests
			.iter()
			.find(|pr| pr.merge_commit_sha == Some(commit.sha.clone()));
    });

This poses a couple of problems when the pull request is not squashed but rebased.
Take #360 for example (it is rebased). git cliff -c github outputs:
* fix: allow version bump with a single previous release by @orhun in #360
* fix: allow version bump with a single previous release by @nappa85

However, it should be:
* fix: allow version bump with a single previous release by @nappa85 in #360

Additional context
I don't know how to fix this yet since it is the limitation of the data we get from the GitHub API. In the perfect world, /commits endpoint would also return the associated pull request number so that we don't need to fetch the pull requests and do some hacky comparison.
Alternatively, we could use <commit>/pull API but that just means sending a request for each commit which adds up to a lot.

We need to change the logic to get the user from the pr, not from the commit, get the pr number from the commit should be straightforward.

    "number": 1347,
    "state": "open",
    "locked": true,
    "title": "Amazing new feature",
    "user": {
      "login": "octocat",

https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests

That actually makes sense!


Recipe yml structure

I have added an example recipe structure to the repository:
download:
  folder: /home/bart/Data/lsmdata/test/
  years: [1980, 2020]
  bbox: [3, 50, 6, 54]

  datasets:
    era5-land:
      frequency: hourly
      variables:
        - air_temperature  # will map to 2m_temperature...
          - height_m: 2  # optional extra argument
        - dewpoint_temperature
          - height_m: 2

convert:
  standard: ALMA
  flavor: PLUMBER2  # More specified than ALMA.
  folder: /home/bart/Data/lsmdata/output/
  frequency: 1H  # outputs at 1 hour frequency. Pandas-like freq-keyword.
  resolution: 0.01  # output resolution in degrees.

Any thoughts, @SarahAlidoost, @geek-yang ?

@BSchilperoort Thanks, it looks good, and it has the minimum required information. I think the sections can be reorganized. For example, I suggest using the same structure as springtime recipes for the 'datasets' section. Let's have a separate section for configurations. In the future, other configs like system settings can be added. I like having a documentation part as well. (see esmvaltool recipes  and config-user for more). Here is my suggestion:
configurations:
  run_directory: /home/bart/Data/lsmdata/test
  download: True # /home/bart/Data/lsmdata/test/download_dir will be created

documentation:
  description:
    Example recipe that downloads two variables from era5_land data and converts
    them to ALMA format.

datasets:
  test:
    dataset: era5-land
      frequency: hourly
      years: [1980, 2020]
      area:
        name: test
        bbox: [3, 50, 6, 54]
      variables:
        - air_temperature  # will map to 2m_temperature...
          - height_m: 2  # optional extra argument
        - dewpoint_temperature
          - height_m: 2

converter: # /home/bart/Data/lsmdata/test/processed will be created
  convention: ALMA
  flavor: PLUMBER2  # More specified than ALMA.
  frequency: 1H  # outputs at 1 hour frequency. Pandas-like freq-keyword.
  resolution: 0.01  # output resolution in degrees.

Thanks for the ideas. I do like the documentation part.
I find having "datasets" and "dataset" a bit confusing. How about calling the first one a collection?
Additionally, as the goal is to prepare input data for land surface models, the area and years will be the same for most datasets. So by default the area and years should be set on the collection level, with the possibility of deviating from this for a specific dataset. For example:
collections:
  stemmus_scope_NL:
    years: [1980, 2020]
    area: [3, 50, 8, 54]

    dataset: era5-land
      frequency: hourly
      variables:
        - air_temperature

    dataset: CAMS
      years: [2004, 2020]
      variables:
        - co2

    dataset: dummy_data
      years: [1980, 2003] # No data available for these years.
      variables:
        co2:
          unit: ppm
          value: 350

What about catalog as a container of datasets. See https://schema.org/DataCatalog


Add functions API to scanner

Current coverage is 94.17% (diff: 100%)

Merging #19 into services will not change coverage

@@           services        #19   diff @@
==========================================
  Files            10         10
  Lines           635        635
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            598        598
  Misses           25         25
  Partials         12         12

Powered by Codecov. Last update 5d614b0...84089b1


FFI instructions broken for iOS

relevant page: https://flutter.dev/docs/development/platform-integration/c-interop
1) Linking instructions:
The page reads:
On iOS, you need to tell Xcode to statically link the file:

In Xcode, open Runner.xcworkspace.
Add the C/C++/Objective-C/Swift source files to the Xcode project.

You don't need to do that because the plugin is using CocoaPods, placing the cpp files in the correct directory will cause it to get linked.
2) Linker stripping
If you follow the instruction you get an error at runtime because DynamicLibrary won't be able to find the "native_add" symbol.  That is because it is getting stripped out at linking time, example:
aaclarke-macbookpro2:Debug-iphonesimulator aaclarke$ nm MessagingTiming/libMessagingTiming.a | grep native_add
MessagingTiming/libMessagingTiming.a(native_add.o):
0000000000000000 T _native_add
aaclarke-macbookpro2:Debug-iphonesimulator aaclarke$ nm Runner.app/Runner | grep native_add
aaclarke-macbookpro2:Debug-iphonesimulator aaclarke$

moved to website: https://github.com/flutter/website/issues/3856


Simulation Upgrade

The simulation is reaching its limits with PVs that can be initialised and reinitialised, have limits and timestamps etc. There is also a need to add enums and arrays to the simulation.
In order to tie in with #34 it seems that an upgrade may be required. It would be nice to initialise a simulation environment of some kind from JSON which communicates through the middleware in the same was the Coniql client or other middleware.
Therefore, the simulation should:

be initialised separately from the components rendered on screen
maintain its own values separately from the store
provide a mechanism for updating values
provide a mechanism for pushing values on changes or new subscriptions
provide a mechanism to stop pushing values when the subscription has finished

In effect, we should aim to more fully simulate the environment we wish to use the application in.

I want to split out the separate changes into sections.
Remove namespaces
meta:// lives in a separate namespace. We could replace this with sim://limits
Make some simulated values writeable
meta:// is already writeable. If we are to move meta:// in to the simulated namespace then it seems to make sense to make most simulated pv's writeable (with the exception of those that generate random values).
This could be achieved by having SimPv implement an updateValue method that can error out for e.g. sine simulated pv's.

I just had a talk to Tim. We could potentially have multiple sim://limits PVs (e.g. sim://limits100) if we felt it was necessary. But sims aren't fundamental, they are for demonstration purposes, and something like meta:// isn't that flexible for other purposes.

I don't think there's any need to initialise PVs other than at the time they are requested. But it might be nice to close them when the last subscriber is removed, as for real PVs.

We could potentially have multiple sim://limits

I might vote for sims://limits#name so as to ape html; or perhaps sims://limits.name

That's an interesting idea.

The "initialise separately" part was looking towards initialising a simulated database from a JSON file or similar and then having the client connect to that. This would be useful because for defining multiple "meta" type PVs each with different limits.
However, that in itself might not be that useful for demonstration and perhaps there are other ways to do this on the fly based on the PV name, the # idea seems interesting to me, how much information do you think could be squeezed into something like that? PV type, limits, readonly?

I think that's just to be able to use different PVs with the same behaviour. So now you can use meta://pv1 and meta://pv2 but then you could have sim://limits#1 and sim://limits#2. Different behaviour would get a different name such as sim://other.

This page from the Phoebus documentation talks about both sim and loc PVs. We should try to support what Phoebus supports:
https://phoebus-doc.readthedocs.io/en/latest/phoebus/core/pv/doc/index.html

This would be useful because for defining multiple "meta" type PVs each with different limits.

Given that phoebus forces us to support things like "sim://sine(1, 2.0)" it feels consistent to do most things through this format.
One way to achieve limits would be to support formats like sim://limit(min, max).
As an aside, this format is probably more readable than JSON though potentially:

More difficult to prase
More error prone to parse
Producing less easy to debug error messages (unless one puts in quite a lot of effort)
More likely to contain errors (since JSON verification gives one some de facto error checking)

how much information do you think could be squeezed into something like that? PV type, limits, readonly?

I'm not really sure what the limits to storing information is. On one level, everything is bytes. We could also extend this pv name format to support embedded JSON.
I guess some issues that come to mind are:

Very long lines
The difficulty of reporting errors

I'm trying to close off this issue.

If we want to provide parameterisation to sim://limits, we should use the function-style syntax. We can add such functionality as and when we feel we need it.
However, we don't want to try and simulate a sophisticated control system. This is not the place for that.
I'll close this ticket now.


editing unit stats. when?

so, when we be able to edit unit stats ? like HP pool or damage :)
i strongly believe Swordsmen and pikeman need HP increase.

This has been raised several times, and showdown has hinted that he might be able to do a settings file like the aic, however he hasn't found all the stats locations yet.
As for buffing swords and pikes, I agree some balancing is needed, I just never thought those were underpowered. Can I ask your reasoning? Maybe nerfing another unit a little would fix this issue as well.
My opinion is that shields need to walk at pikemen speed - this will allow other melee to catch them thereby reducing their effectiveness and increasing utility of melee units, and maybe reduce price of Arabian archers or increase horse archers (their prices are too similar for me) but that's just a nice to have.

This has been raised several times, and showdown has hinted that he might be able to do a settings file like the aic, however he hasn't found all the stats locations yet.
As for buffing swords and pikes, I agree some balancing is needed, I just never thought those were underpowered. Can I ask your reasoning? Maybe nerfing another unit a little would fix this issue as well.
My opinion is that shields need to walk at pikemen speed - this will allow other melee to catch them thereby reducing their effectiveness and increasing utility of melee units, and maybe reduce price of Arabian archers or increase horse archers (their prices are too similar for me) but that's just a nice to have.

from my opinion, crossbowman are too powerfull, 200 CB can stop 400+ swordsman army easy..

Make Spears great again!
I mean it's just hillarious that a group of spears cannot outdamage the respawn rate of the villagers.
I'd go with this:
Arrow Resistance: Check (already in the UCP)
Walking Speed: Always Running (just like Archers; both have no Armor)
Damage: Increased against Villagers/Workers

Crossbows are the counter to armoured units, it makes sense that they are strong against them, but there are other ways to kill off crossbows before committing 400 swords... any ranged unit with shields will draw fire away so your melee units get in undamaged. Catapults and trebs kill any towers the cows are on, and if you dont have shields then HA will kill them easy as long as they keep moving and changing directions, if they aren't on a wall then diseased cows will slaughter them easy.

Yeah, I think there are many taste-dependent changes one could make.
In my opinion:

Pikeman slightly slower, I view them as defensive unit
Swordsman stronger (I know, historically the Pikeman was a counter for swordsman, but come on, swordsman should be way more badass!)
shield speed and health reduction, no possibility to put them on towers
Crossbowman nerf (more damage per shot, but way lower rate of fire (roughly same DMG/min) so swarming gets more effective? Less firing range? Just something to promote not to only spam Crossbowman and give Bowman some reason to exist)
...

Anyway, back to the main topic: When its done, its done (also see https://github.com/Sh0wdown/UnofficialCrusaderPatch/issues/472)

Yeah, I think there are many taste-dependent changes one could make.
In my opinion:

Pikeman slightly slower, I view them as defensive unit
Swordsman stronger (I know, historically the Pikeman was a counter for swordsman, but come on, swordsman should be way more badass!)
shield speed and health reduction, no possibility to put them on towers
Crossbowman nerf (more damage per shot, but way lower rate of fire (roughly same DMG/min) so swarming gets more effective? Less firing range? Just something to promote not to only spam Crossbowman and give Bowman some reason to exist)
...

Anyway, back to the main topic: When its done, its done (also see #472)

crossbowman need slower rate of fire for sure, but  decreasing his range will ruin ai that uses CB only.

Yeah, I think there are many taste-dependent changes one could make.
In my opinion:

Pikeman slightly slower, I view them as defensive unit
Swordsman stronger (I know, historically the Pikeman was a counter for swordsman, but come on, swordsman should be way more badass!)
shield speed and health reduction, no possibility to put them on towers
Crossbowman nerf (more damage per shot, but way lower rate of fire (roughly same DMG/min) so swarming gets more effective? Less firing range? Just something to promote not to only spam Crossbowman and give Bowman some reason to exist)
...

Anyway, back to the main topic: When its done, its done (also see #472)

crossbowman need slower rate of fire for sure, but decreasing his range will ruin ai that uses CB only.

If the range of a crossbowman on a tower equals the range of the bowman on plain field I guess it could work. I think the Pig and the Sherif would not suffer too much from this, and I think their offensive capabilities lie more in their maceman and not in their crossbowman. Maybe the crossbowman on patrol will suffer, but I guess, if such an option exists, one would notice it fast whether or not it works.

Here are changes that I view as necessary:
-Nerfing Shields to hell, reducing their movement speed if possable and increasing gold cost to 50 so that they wont be slammed. I d even go for health increase against missiles if those 2 are adjusted.
-Increasing the price of Horse Archers from 80 to 100/110 gold
Increasing cost of Assassins to 90/100 gold as well. ( It seems they are the most used pvp unit, so might as well make them taxing. Would make using alternatives better)

Reducing cost of Arab Archers from 75 to 60/65. They're far more expensive than they're worth. Purchasing Bows and building archers is cheaper than even using fletcher. Their stat differences dont warrant the huge disparity in their cost efficiency.


Ergonomics of UUID::B128(u8vec)

As I understand it UUID::B128(u8vec) takes a vector of u8 in the reverse order to that displayed. This is confusing an not ergonomic.
for example the code:
let authcharuuid : [u8; 16] = [ 0x67, 0xDF , 0xD1, 0x30, 0x42, 0x16, 0x39, 0x89, 0xE4, 0x11, 0xE9, 0x47, 0x30, 0xEE , 0xE9, 0x47];
println!("UUID:{}",  UUID::B128(authcharuuid));

produces the output:
UUID:47:E9:EE:30:47:E9:11:E4:89:39:16:42:30:D1:DF:67

FWIW, this behavior matches the other BLE API I have used, for the ESP32:
https://github.com/espressif/esp-idf/blob/master/examples/bluetooth/gatt_server_service_table/main/gatts_table_creat_demo.c#L88
I definitely found it confusing when using that library

This behaviour is also found in Nordic Semiconductor's BLE libraries - it's about host vs. network byte order.


Drop protodata and mc-java from plugins accessors and update Detekt config

This changeset does the following:

Moves protodata and mc-java plugin accessors to the corresponding dependency accessors: protoData and mcJava. mc-java cannot be applied to a project directly. protodata can be, but when used in pair with mc-java, buildscript classpath ends up with both of them. Thus, making impossible direct apply of protodata too.
Updates Detekt config to exclude *Extensions.kt files from TooManyFunctions rule. Such files usually consists only of  functions.

@alexander-yevsyukov @armiol Please take a look.


NTR: chromosomal passenger protein complex

def
A protein complex which consists minimally of the
chromosomal passenger proteins survivin, protein kinase
and Aurora B and the inner centromere protein INCENP.
This complex exists in S. pombe at the kinetochore
during metaphase but translocates to the spindle
midzone as the
chromosomes segregate at anaphase.
Reported by: ValWood
Original Ticket: "geneontology/ontology-requests/3163":https://sourceforge.net/p/geneontology/ontology-requests/3163

thanks www.movied.org


Changes to the documentation of Streaming.Prelude.mapped

Two changes to the documentation of Streaming.Prelude.mapped:
One, remove the example transformation:

let noteBeginning text x = putStrLn text >> return text

Because it doesn't seem to correspond to any transformation actually accepted by mapped.
Two, add documentation for a frequent use case: handling groups defined in effectful IO-based streams. mapped is the function to use in such cases, but it isn't obvious at all because it is functor-general.

LGTM, thanks


Add trusted facts support

let(:trusted_facts) { {'pp_uuid' => '012345670-ABCD', 'some' => 'value'} }
http://rspec-puppet.com/documentation/classes/

@lmacchi Here you go

If someone is keen to add this functionality i'd gladly accept PRs


V2

Changes to Http Client to support
Added Support for Batch Calls
Twitter Cards API WIP

Awesome 🎉
Let's try to make any requests for changes as new Issues instead of opening feedback on this review


Add Jupyterhub password secret creation to init container

Signed-off-by: Anish Asthana<EMAIL_ADDRESS>

You will need the changes in https://github.com/red-hat-data-services/odh-deployer/pull/89 to be able to test this. (Or just create the secret in question manually)

I'm currently working on testing this change.


[Impeller] Improve AiksLayer::IsReplacing

We should do the following:

[ ] Collect statistics similar to DisplayListLayer
[ ] Do a deeper comparison of the EntityPass if the pointers do not actually match, at least to a certain point - for example, DisplayListLayer will compare DLs of up to 10kb. EntityPass is potentially more expensive to compare right now though.

We decided not to proceed with the AiksLayer approach. Closing for now.


Fix errors in examples scriptlets

Many thanks!!! I will verify it in the next few days and merge.


Asthma Disease Detection Using Deep Learning

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Asthma Disease Detection Using Deep Learning
:red_circle: Aim : Develop a robust model to detect asthma using deep learning techniques, specifically ANNs from PyTorch and custom-built ANNs using NumPy and SciPy.
:red_circle: Dataset : Asthma Disease Dataset
:red_circle: Approach :

Perform exploratory data analysis (EDA) to understand the dataset and uncover initial insights.
Implement data preprocessing techniques to handle outliers, feature engineering, and missing values.
Develop and compare multiple models:

ANN using PyTorch
Custom-built ANN using NumPy and SciPy

Evaluate model performance using metrics like Accuracy, Precision, Recall, F1-Score, and ROC-AUC.
Document the process, results, and conclusions thoroughly.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Swayam
GitHub Profile Link : Swayam
Participant ID (If not, then put NA) :
Approach for this Project : Implementing a robust data preprocessing pipeline, experimenting with different deep learning architectures, and evaluating model performance comprehensively.
What is your participant role? Contributor (VSOC'24)

I want to get this assigned.

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Can you implement 3-4 models for this project?

Implement 2 ANNs and 5 ML Models for this problem statement.
Assigning this issue to you @Swish78

Issue Title: 673 Asthma Disease Detection Using Deep Learning
Full name : Sanjanah A
GitHub Profile Link : Sanjanah8(https://github.com/sanjanah8)
Participant ID (If not, then put NA) :
Approach for this Project : Implementing a robust data preprocessing pipeline, experimenting with different deep learning architectures, and evaluating model performance comprehensively.
What is your participant role? Contributor (SSOC'3 2024)
I have used ANN using pytorch and 5 different ML models for this approach. I want to get this assigned. Please review my pull request and any changes to be made can be rectified by me.

Issue Title: 713 Asthma Disease Detection Using Deep Learning
Full name : Sanjanah A GitHub Profile Link : Sanjanah8(https://github.com/sanjanah8) Participant ID (If not, then put NA) : Approach for this Project : Implementing a robust data preprocessing pipeline, experimenting with different deep learning architectures, and evaluating model performance comprehensively. What is your participant role? Contributor (SSOC'3 2024)
I have used ANN using pytorch and 5 different ML models for this approach. I want to get this assigned. Please review my pull request and any changes to be made can be rectified by me.

Please wait for the issue to be assigned to you, then only you start working on it. Without assigning an issue how can you start pushing your code?
What are the ML models you think are compatible with this dataset? As you need to implement 6-7 models for any issue here.

Full name : Aditya D
GitHub Profile Link : https://github.com/Swish78
Participant ID (If not, then put NA) : NA
Approach for this Project :  using ml algos like logistic regression , knn , random forest , decision tree , svm , adaboost , catboost , gradientboost , xgboost and stacked classifier
What is your participant role? SSOC Contributor   @abhisheks008 if this issue is still open please assign it to me

Assigned to you @adi271001


useContractSchemaRpc: Parse schema based on module version

Purpose
Make fetching/parsing of contract schema more precise based on the module version information that is now exposed by the gRPC client.
This in turn also documents the relationship between module and schema versions.
Changes
Use module version to determine what custom sections to look for and add comments explaining the expected results.

Keeping as draft until https://github.com/Concordium/concordium-dapp-libraries/pull/42 is merged.


Resolve Issue #638: Enforce PEP 8 naming conventions

Type of change

[✔] Bug fix
[✔] New features
[✔] Enhanced documentation

Changes proposed in this pull request:
This pull request addresses two issues:

Input Validation (Issue #607 ):

Implemented input validation to ensure users provide only valid and expected values.
Added error handling mechanisms for invalid inputs, providing a better user experience.

PEP 8 Compliance (Issue #638 ):

Adjusted variable and function names to adhere to PEP 8 naming conventions.
Ensured consistent indentation, spacing, and formatting throughout the codebase.
Resolved any other PEP 8 violations present in the affected files.

Project name: Number Guessing App

Short description:  The changes in this pull request aim to enhance the user experience by validating input and bring the codebase in line with PEP 8 guidelines.

Checklist

[✔] The code is Python 3 compatible
[✔] I have added relevant comments in my file to make code understandable
[✔] I have added my project in a folder which includes all the necessary files

Please maintain project directory structure , remove .idea folder

Why you removed projects/Conway’s-Game-Of-Life/ files ?


Fix: Use array type for issue form labels

Currently, the issue templates won't add the labels that are set.
Changes:

label wants an array as value, so we give it one.
The workflow won't create labels if they are not present. So it's be considered to change the
non-default Bug and Feature Request labels to default labels bug and enhancement to have something more "batteries included".
It removes the preset title to make it mandatory for a user to think about and write a title for an issue as it can't be submitted without. We had some occurrences at V where (bug report summary) was just submitted, this would reduce such things.

I realize that should have split the changes into smaller chunks. Let me know if only parts are of interest then I'll rebase accordingly.

Nice. Can you also propagate these changes to V main repo if you have time?


Error "There is no variable named 'dependency'.

Description
I'm getting the following error when trying to plan or apply changes with Terragrunt:
❯ make init
cd . && terragrunt init
ERRO[0001] Error: Unknown variable

ERRO[0001]   on /Users/lucas/MEGAsync/Documents/work/git/mycompany/mycompany-infrastructure/environments/prod/ap-southeast-2/sms-usage-uploader-lambda/terragrunt.hcl line 118:
ERRO[0001]  118:   kms_key_arn = dependency.kms.outputs.key_arn
ERRO[0001]
ERRO[0001] There is no variable named "dependency".

ERRO[0001] Error: Unknown variable

ERRO[0001]   on /Users/lucas/MEGAsync/Documents/work/git/mycompany/mycompany-infrastructure/environments/prod/ap-southeast-2/sms-usage-uploader-lambda/terragrunt.hcl line 127:
ERRO[0001]  127:   vpc_subnet_ids         = dependency.vpc.outputs.private_subnets
ERRO[0001]
ERRO[0001] There is no variable named "dependency".

ERRO[0001] Error: Unknown variable

ERRO[0001]   on /Users/lucas/MEGAsync/Documents/work/git/mycompany/mycompany-infrastructure/environments/prod/ap-southeast-2/sms-usage-uploader-lambda/terragrunt.hcl line 128:
ERRO[0001]  128:   vpc_security_group_ids = [dependency.vpc.outputs.default_security_group_id]
ERRO[0001]
ERRO[0001] There is no variable named "dependency".

ERRO[0001] Error: Unknown variable

ERRO[0001]   on /Users/lucas/MEGAsync/Documents/work/git/mycompany/mycompany-infrastructure/environments/prod/ap-southeast-2/sms-usage-uploader-lambda/terragrunt.hcl line 150:
ERRO[0001]  150:         for arn in concat(dependency.ssm.outputs.ssm_parameters_with_ignore_changes_arn, dependency.ssm.outputs.ssm_parameters_without_ignore_changes_arn) : arn
ERRO[0001]
ERRO[0001] There is no variable named "dependency".

ERRO[0001] Error: Unknown variable

ERRO[0001]   on /Users/lucas/MEGAsync/Documents/work/git/mycompany/mycompany-infrastructure/environments/prod/ap-southeast-2/sms-usage-uploader-lambda/terragrunt.hcl line 150:
ERRO[0001]  150:         for arn in concat(dependency.ssm.outputs.ssm_parameters_with_ignore_changes_arn, dependency.ssm.outputs.ssm_parameters_without_ignore_changes_arn) : arn
ERRO[0001]
ERRO[0001] There is no variable named "dependency".

WARN[0001] Error reading partial config  for dependency lambda: /Users/lucas/MEGAsync/Documents/work/git/mycompany/mycompany-infrastructure/environments/prod/ap-southeast-2/sms-usage-uploader-lambda/terragrunt.hcl:118,17-27: Unknown variable; There is no variable named "dependency"., and 4 other diagnostic(s)
INFO[0011] Downloading Terraform configurations from tfr:///terraform-aws-modules/eventbridge/aws?version=3.2.2 into /Users/lucas/MEGAsync/Documents/work/git/mycompany/mycompany-infrastructure/environments/prod/ap-southeast-2/sms-usage-uploader-scheduler/.terragrunt-cache/x1f6kqkMHJdRAwLRHsowDcrH5oQ/mD5dBOZbTj-YOZPbE56PudA-IQs

Initializing the backend...

Successfully configured the backend "s3"! Terraform will automatically
use this backend unless the backend configuration changes.

Initializing provider plugins...
- Finding hashicorp/aws versions matching ">= 5.27.0"...
- Installing hashicorp/aws v5.37.0...
- Installed hashicorp/aws v5.37.0 (signed by HashiCorp)

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

If your request is for a new feature, please use the Feature request template.

[x] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

I've tried the following:

Removed .terraform.lock.hcl and .terragrunt-cache
Ran terragrunt init -upgrade

Versions

Module version [Required]: 3.2.2

Terraform version: v1.7.4 on on darwin_arm64

Terragrunt version: 0.55.4

Provider version(s): aws v5.37.0

Reproduction Code [Required]
I've tried the following:

Removed .terraform.lock.hcl and .terragrunt-cache
Ran terragrunt init -upgrade
Ran terragrunt providers lock -platform=darwin_amd64 -platform=windows_amd64 -platform=linux_amd64 -platform=darwin_arm64 -platform=linux_arm64 -platform=darwin_arm64

environments/prod/ap-southeast-2/sms-usage-uploader-scheduler:
# ---------------------------------------------------------------------------------------------------------------------
# TERRAGRUNT CONFIGURATION
# This is the configuration for Terragrunt, a thin wrapper for Terraform that helps keep your code DRY and
# maintainable: https://github.com/gruntwork-io/terragrunt
# ---------------------------------------------------------------------------------------------------------------------
# ---------------------------------------------------------------------------------------------------------------------
# Locals are named constants that are reusable within the configuration.
# ---------------------------------------------------------------------------------------------------------------------
locals {
  # Automatically load environment-level variables
  environment_vars = read_terragrunt_config(find_in_parent_folders("env.hcl"))

  # Automatically load region-level variables
  region_vars = read_terragrunt_config(find_in_parent_folders("region.hcl"))
  aws_region  = local.region_vars.locals.aws_region

  # Extract out common variables for reuse
  env        = local.environment_vars.locals.environment
  account_id = local.environment_vars.locals.aws_account_id

  # create a list of subnets
  private_subnets_cidr     = tolist(concat([local.environment_vars.locals.private_subnet_a, local.environment_vars.locals.private_subnet_b, local.environment_vars.locals.private_subnet_c]))
  public_subnets_cidr      = concat([local.environment_vars.locals.public_subnet_a, local.environment_vars.locals.public_subnet_b, local.environment_vars.locals.public_subnet_c])
  database_subnets_cidr    = concat([local.environment_vars.locals.database_subnet_a, local.environment_vars.locals.database_subnet_b, local.environment_vars.locals.database_subnet_c])
  elasticache_subnets_cidr = concat([local.environment_vars.locals.elasticache_subnet_a, local.environment_vars.locals.elasticache_subnet_b, local.environment_vars.locals.elasticache_subnet_c])
  infra_subnets_cidr       = concat([local.environment_vars.locals.infra_subnet_a, local.environment_vars.locals.infra_subnet_b, local.environment_vars.locals.infra_subnet_c])

  # Extract out workspace variables for reuse
  VPC_CIDR = local.environment_vars.locals.VPC_CIDR
}

# We override the terraform block source attribute here just for the QA environment to show how you would deploy a
# different version of the module in a specific environment.
# https://github.com/terraform-aws-modules/terraform-aws-eventbridge/releases
terraform {
  source = "${include.envcommon.locals.base_source_url}?version=3.2.2"
}

# ---------------------------------------------------------------------------------------------------------------------
# Include configurations that are common used across multiple environments.
# ---------------------------------------------------------------------------------------------------------------------

# Include the root `terragrunt.hcl` configuration. The root configuration contains settings that are common across all
# components and environments, such as how to configure remote state.
include "root" {
  path   = find_in_parent_folders()
  expose = true
}

# Include the envcommon configuration for the component. The envcommon configuration contains settings that are common
# for the component across all environments.
include "envcommon" {
  path   = "${dirname(find_in_parent_folders())}/config/_envcommon/eventbridge.hcl"
  expose = true
}

dependency "lambda" {
  config_path = "${dirname(find_in_parent_folders())}/environments/${local.env}/${local.aws_region}/sms-usage-uploader-lambda"

  # Configure mock outputs for the `validate` command that are returned when there are no outputs available (e.g the
  # module hasn't been applied yet.
  mock_outputs_allowed_terraform_commands = ["init", "validate", "plan"]

  mock_outputs = {
    lambda_function_arn = "known-after-apply"
  }
}

# ---------------------------------------------------------------------------------------------------------------------
# MODULE PARAMETERS
# These are the variables we have to pass in to use the module. This defines the parameters that are common across all
# environments.
# ---------------------------------------------------------------------------------------------------------------------
inputs = {
  create = true
  # Remove the "-rule" postfix from the event rule name
  append_rule_postfix = false

  name        = "sms-usage-uploader-${local.env}"
  description = "Schedule the sms usage upload requested event"

  # Event bus is managed by another module
  create_bus = false

  attach_lambda_policy = true
  lambda_target_arns   = [dependency.lambda.outputs.lambda_function_arn]

  role_name = "sms-usage-uploader-${local.env}"

  rules = {
    SMSUsageUploadRequested = {
      schedule_expression = local.environment_vars.locals.sms_usage_uploader_scheduled_expression
      timezone            = "UTC"
      arn                 = dependency.lambda.outputs.lambda_function_arn
      event_pattern = jsonencode(
        {
          "detail-type" : [
            "SMSUsageUploadRequested"
          ]
        }
      )
      input = jsonencode({ "detail-type" : "SMSUsageUploadRequested" })
    }
    SMSUsageUploadStatusCheckRequested = {
      schedule_expression = local.environment_vars.locals.sms_usage_uploader_scheduled_expression
      timezone            = "UTC"
      arn                 = dependency.lambda.outputs.lambda_function_arn
      event_pattern = jsonencode(
        {
          "detail-type" : [
            "SMSUsageUploadStatusCheckRequested"
          ]
        }
      )
      input = jsonencode({ "detail-type" : "SMSUsageUploadStatusCheckRequested" })
    }
  }

  tags = local.environment_vars.locals.tags
}

Checking outputs in the environments/prod/ap-southeast-2/sms-usage-uploader-lambda directory returns successful data:
Expected behavior
The module should plan the changes without any issues.
Actual behavior
Instead, I get the error described in the beginning of this post.

Duplicate of https://github.com/gruntwork-io/terragrunt/issues/2955


Improve icon structure

We have duplicated icons, as some of the icons used by the ChainSelector component are the same as the token icons. This isn't necessarily always the case though, so we should structure the icons directory to meet the following critieria:

Icons which are used for chains only (e.g. Statemine)
Icons which are used for tokens only (e.g. USDT)
Icons where the chain icon is the same as the native token icon (e.g. Polkadot/DOT).

Closing this—very low priority


Automated Package Upgrade

:tada: This PR is included in version 12.4.18 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add datasets

Add remaining 7 targets of the Merck dataset.

Hi @dfhahn
I know this has been already merged but out of curiosity, why is it a -1 preferred over a null for a non-existent experimental error value?


Unable to initialize DB: duplicate key value violates unique constraint "tag_postids_tagid_idx"

Hi there. First: thank you for your work on this project.
Unfortunately, I've been encountering an error when rebuilding the database this past week. Log output is below. Might be a consequence of excessive tag sibling/parent loops.
I addressed it by adding ON CONFLICT DO NOTHING to applyTagSiblings, which matches all of the other INSERT INTO ... SELECT ... FROM ... statements in tag-related functions in that file.
In a couple days, if this turns out to be a sufficient fix, I can make a PR if you'd like.

Log output
Posts (153553/153553)           [####################] Done in 3.24s
Posts (3299/3299)               [####################] Done in 45ms
Posts (2470/2470)               [####################] Done in 61ms
Posts (628/628)                 [####################] Done in 25ms
Urls (601716/601716)            [####################] Done in 2.02s
Notes                           [####################] Done in 0ms
Tags (39961003/39961003)        [####################] Done in 2:04
Mappings<PHONE_NUMBER>/2031885282)[####################] Done in 53:36
Mappings (1205433/1205433)      [####################] Done in 19.84s
Mappings (45176/45176)          [####################] Done in 253ms
Tag parents (29235/29235)       [####################] Done in 156ms
Tag siblings (302637/302637)    [####################] Done in 1.59s
Importing options...            [####################] Done in 12ms
Resolving file relations...     [####################] Done in 103ms
Normalizing tags (6/6)          [####################] Done in 46:12:14
Warning! Detected 71 loops in tag siblings!
Warning! Detected 46 loops in tag parents!
Resolving tag parents...        [####################] Done in 36:40:41
Indexing (24/24)                [####################] Done in 3:25:06
Resolving tag siblings...       [--------------------] Unable to initialize DB!
error: duplicate key value violates unique constraint "tag_postids_tagid_idx"
    at Parser.parseErrorMessage (/repos/hydribooru/node_modules/pg-protocol/src/parser.ts:369:69)
    at Parser.handlePacket (/repos/hydribooru/node_modules/pg-protocol/src/parser.ts:188:21)
    at Parser.parse (/repos/hydribooru/node_modules/pg-protocol/src/parser.ts:103:30)
    at Socket.<anonymous> (/repos/hydribooru/node_modules/pg-protocol/src/index.ts:7:48)
    at Socket.emit (node:events:514:28)
    at addChunk (node:internal/streams/readable:376:12)
    at readableAddChunk (node:internal/streams/readable:349:9)
    at Socket.Readable.push (node:internal/streams/readable:286:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23) {
  length: 215,
  severity: 'ERROR',
  code: '23505',
  detail: 'Key (tagid)=(X) already exists.',
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: 'public',
  table: 'tag_postids',
  column: undefined,
  dataType: undefined,
  constraint: 'tag_postids_tagid_idx',
  file: 'nbtinsert.c',
  line: '663',
  routine: '_bt_check_unique'
}

Update: said fix solved the issue and the database now rebuilds successfully.

Log output
HyBooru started on port localhost:8080
Environment: production.
Press Ctrl-C to terminate.
Database update detected, rebuilding...
Rebuilding Database!
Posts (153553/153553)           [####################] Done in 3.97s
Posts (3299/3299)               [####################] Done in 56ms
Posts (2470/2470)               [####################] Done in 72ms
Posts (628/628)                 [####################] Done in 38ms
Urls (601716/601716)            [####################] Done in 2.55s
Notes                           [####################] Done in 0ms
Tags (39961003/39961003)        [####################] Done in 2:26
Mappings<PHONE_NUMBER>/2031885282)[####################] Done in 1:03:51
Mappings (1205433/1205433)      [####################] Done in 27.63s
Mappings (45176/45176)          [####################] Done in 311ms
Tag parents (29235/29235)       [####################] Done in 166ms
Tag siblings (302637/302637)    [####################] Done in 1.53s
Importing options...            [####################] Done in 21ms
Resolving file relations...     [####################] Done in 206ms
Normalizing tags (6/6)          [####################] Done in 52:16:48
Warning! Detected 71 loops in tag siblings!
Warning! Detected 46 loops in tag parents!
Resolving tag parents...        [####################] Done in 35:06:26
Indexing (24/24)                [####################] Done in 3:08:08
Resolving tag siblings...       [####################] Done in 1.24s
Counting tags usage...          [####################] Done in 28.26s
Calculating statistics...       [####################] Done in 9:18
Finalizing...                   [####################] Done in 357ms
Database rebuild completed in 91:57:05

Hi, thanks for your investigation.
However I can't accept this fix for now. This shouldn't happen and this fix only works around some other underlying issue. What applyTagSiblings does is it copies post lookup tables from better/preferred siblings to other siblings so they can be used for searching. The other siblings shouldn't have any lookup tables by this point because normalizeTagRelations is supposed to move all mappings to better siblings, leaving worse ones "empty". Maybe there is a possibility that a tag could have two better siblings, which I thought isn't allowed by hydrus but all kinds of shit happens there so it's better to improve hybooru tolerance to hydrus fuckery.
I will have to investigate this issue. It is possible that we might need to drop double-better siblings situations, or arguably, better, join lookup tables together on conflict. There is also possibility that the loop resolution in during tag normalization has some bug in it.
Could you try uploading your database(without images) for sake of testing? It could greatly help me debug this issue.

Ah, gotcha. I'm not at liberty to upload the hydrus db (it's also ~100gb). But if Hybooru has a verbose debug mode or crash dump / log-generating option, I'm more than willing to rebuild the database on another drive and send you the outputs.

Does that 100GB includes images or not?
As of hydrus, there is really nothing to log here, it just runs an SQL query and something goes wrong in the database. You can try to make a minimal reproduction for this bug. Otherwise, there is little I can do without any database to debug on.

That 100GB (~89GB) database does not include images or thumbnails, it's just that massive. It ballooned to that size after downloading the PTR. I'll see if I can reproduce it just rebuilding off the PTR and, if so, I'll upload the result.

Should be fixed as of v1.10.0
Let me know if you are still experiencing this issue.


PCovR small singular values should be handled more consistently

The handling of small singular values isn't particularly consistent between sample_space and feature_space -- this leads to issues particularly when doing sample_space PCovR when the mixing is set to zero and the number of components is greater than the number of regression targets. The singular values less than tol don't seem to actually get thrown out (or set to zero), and the prediction becomes unstable, yielding completely different results between repeated fit calls on the same data.

Addressed by #98


operators mondoo-operator (0.2.12)

Signed-off-by: Joel Diaz<EMAIL_ADDRESS>

/merge possible

/merge possible


feature request: embedded-yaws configuration with maps

feature request: embedded-yaws configuration with maps
ex,
    SconfList =
        [#{docroot => Yaws_docroot,
           port => Yaws_port_https,
           dir_listings => true,
           listen => Yaws_addr,
           appmods => [{"/", myapp_req}],
           ssl => #{
             certfile => lists:concat([Yaws_keysdir, "server-cert.pem"]),
             keyfile =>  lists:concat([Yaws_keysdir, "server-key.pem"])
            }
          },
         #{docroot => Yaws_docroot,
           port => Yaws_port_http,
           dir_listings => true,
           listen => Yaws_addr,
           appmods => [{"/", myapp_req}]}
        ].

Doable, but since Yaws supports Erlang releases older than version 17 where maps were introduced, it requires modification of the build systems to detect maps support, and also requires conditional compilation so that any maps-specific functions are not compiled for older Erlang systems.


Update rounding and dates in qcas

What? and Why?
https://trello.com/c/RUAleMj8/2367-qcas-amendments
Minor fixes after qcas testing
Checklist

[x] CHANGELOG.md updated? (if required)

So, if you answer -0 it doesn't show in the image (shows as 0 in the pck), not sure if that's what's expected, but everything else looks fine 👍

And the other thing I think I remember @MebinAbraham mentioned this morning, is if the calculated_total is negative then it won't show the calculated value correctly

It's (mostly) impossible for -0 to be in the answer we get from eq.  The only way the -0 occurs is during the rounding of the -1 to -499 number

@dcdarrell9 Checked with Jimi, the calculated value being of no use if the total value is negative is something the business will manage. They'll get the calculators out 👍


[PE-D][Tester B] Calender cannot show assignment of next month

Assignment 8 and 9 have deadline 2024-01-01 but is not shown on the december 2023 calendar
Although the expected behaviour of the calendar is not specified, I think that assignment 8 and 9 should be shown because this would give the user the illusion of no tasks for the next month, and when he wakes up and checks the app he might be very surprised to see that 2 assignments are due for the day.

Labels: type.FunctionalityBug severity.High
original: antonTan96/ped#6

XD?


Feature: Improve metric dimensions API by accepting a collection of dimensions

Fix Issue #2906.
Changes

Add TelemetryClient.GetMetric overload that accepts n number of dimensions;
Add Metric.TrackValue overload that accepts n number of dimension values.

Checklist

[x] I ran Unit Tests locally.
[x] CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:
- [ ] Design discussion issue #
- [ ] Changes in public surface reviewed
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:

FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

@ysbakker We are encouraging users to leverage OpenTelemetry wherever feasible instead of existing Application Insights API. We are not accepting new features/APIs to this repo, except bug fixes/security hot fixes etc.


Can't open pathlib.Path objects

Most built-in Python functions now accept pathlib.Path objects as well as str. We should do the same.

Run into this issue as i'm using the nice lib https://github.com/liormizr/s3path.


Operation User Intent

This is to address issue #263.

Coverage remained the same at 74.913% when pulling d667823d3612bac1bb0bafe4159ccb97d2cf5306 on feature/OPR-263_user_initiated into 968fcefdb5f9a61bbf5368fa9db1b715aaf0a8dd on development.

I guess my big question is, why is this necessary? Isn't setting the QoS on the operation directly enough to get this effect? This just seems to be adding a layer of API above the QoS that has no real gain. What is this API adding?

Well, the idea behind this is to make it possible to mark up in a more descriptive way what the operation is being used for. I agree that it is a just a thin layer on top of the quality of service. Perhaps we've over discussed it, as it's pretty trivial.

Also, while setting the userIntent will now set the appropriate qualityOfService, because of the way that NSOperations will get their QoS promoted automatically if the queue's QoS is promoted, or another operation is added to the queue the same QoS, you cannot reliably infer the user's intent from the qualityOfService property of an operation.

True enough. I guess my only question then, since I don't have any feedback on the enum names, is why is it Int based?

It's an Int because it's the easiest way to make it Comparable. When a Group is initialised with an array of operations, we set the groups user intent to the max of those in the array.

I like the changes and think this looks great.

Okay - gonna merge! Thanks @jshier @ryanjm


Why do I keep getting this message when I try to sign in with facebook?

"There is already an account using this email address. Sign in to that account and link it with Facebook manually from Account Settings."
Is something stuck in the cache?

This happens if you have already connected with the same email on another social account like twitter or google.

@raunaqrox is correct. Another way to quickly fix this, for local development purposes, is to drop all your users from your local mongodb database:
db.users.drop()

This will remove all existing accounts in the database, so you can try to create and link your accounts again.

It also can happen when email does not successfully store in the user object.  It happened to me after changing the Facebook app id and secret to my personal Facebook app id.  I am still having trouble to get the public info even though the app request "email", "public_profiles" permission.


Example for `FAIL_UNLESS(mock_*.verify()); is wrongly placed

Small issue here as it may confuse users.
In all of the examples FAIL_UNLESS(mock_*.verify()); is wrongly placed.
For the check to actually contribute to test status this line of code needs to be placed inside some SVTEST ... SVTEST_END and not in the teardown task.
Currently it only displays if the EXPACT_CALL had some mismatches, but doesn't make the test fail if there are mismatches.
I guess, it should be obvious that it is wrong, but made me confused for a minute.
Regards,
Aleksandar Kalajdzic

Hi Aleksandar,
I hope the issue you have mentioned is no longer there - it has been resolved!
If you run the example under bedrock then you can see one test is failing because the test is as below:
 75   `SVTEST(dino_called_once)
 76     `EXPECT_CALL(mock_f, dino).exactly(2);
 77
 78     uut.yabba_dabba_do(betty);
 79   `SVTEST_END


Sean Halpin | Web Designer | Website Clone

Project title
Portfolio of Sean Halpin
Project Description
Here I am Cloning Sean Halpin Old Website
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[x] Html
[x] CSS

/assign


Update 3-1-2_checks.Rmd

I have made the headline plot work properly by filtering out all disaggregated data. The headline plot should now only include 1 data point per year.


Error: Commit failed to return status

Not sure if things are working correctly.
I've created a Syncer successfully.
On my live project (don't have another project setup with multiple users and approvers on several branches) we currently have 8 open PRs.
I started the Syncer and it went through and created 8 bots.  Started the first one, and it was building.
The Syncer showed an Error!
Last successful sync at 2016-05-09 22:11:59 +0000 Last sync failed with error Commit  failed to return status Syncer is Idle... Waiting for the next sync...
From the log::
[ERROR]: Syncing encountered a problem. Error: Commit  failed to return status. Context: SyncPair: PR (303:a/F-11-assets-) + Bot (β a/F-11)
So I stopped the Syncer.  And looked over the bots.
The bot that was building, showed an (x) and I noticed the integration had been cancelled.
The next bot started
I restarted the Syncer, to see if it would continue to get errors on the Status issue
I then noticed:  soon after I saw another pending integration for the first bot.
I waited until the 2nd bot finished. It finished successfully.
I checked the PRs in Stash and they all show a button for "Merge Build" but it is greyed out.
I checked the PR for the bot that completed and the button was still greyed out, and I noticed that the bot had another integration in the Pending state.
I cancelled that integration as there are 6 others pending in front of it.
I am currently letting the Syncer run, hoping that it may stabilize and that there was some interaction between creating bots and starting and stopping the Syncer.  (I hope not, since sometimes the PR branches sit around for a day or three, especially over the weekend).
Is something not working correctly?  This does not seem like expected behavior.

Apparently something is cancelling the bots...
Bot Issue for β bugfix/ui-lock (build service error)
Integration #1 of β  bugfix/ui-lock
Open in Xcode: xcbot://ndgiosci2/botID/fb69145e64f3806cec314c66b5c4c09b/integrationID/fb69145e64f3806cec314c66b5c4e4e9
Assertion: This integration was canceled.
File: (null):(null)
Full logs for this integration are attached.
: Error checking out working copies: Error Domain=com.apple.dt.SourceControlErrorDomain Code=-5 "The source control operation was canceled." UserInfo={NSLocalizedDescription=The source control operation was canceled.}
May  9 16:43:46  xcsbuildd[67172] : Error checkout/clone: Error Domain=com.apple.dt.SourceControlErrorDomain Code=-5 "The source control operation was canceled." UserInfo={NSLocalizedDescription=The source control operation was canceled.}
Any ideas?

More info... I see if I edit one of these bots that under Repositories it shows
The server SSH fingerprint failed to verify.
Any suggestions on why this might happen... something more needed in the bot template?

Hi @reststop, this looks like Xcode Server canceling it.
Are you using this Buildasaur or a forked version?
Are you using GitHub.com-hosted repo or a GitHub Enterprise one? Because I've never seen the Commit failed to return status error, that seems like the wrong API is being called.

I'm using gchiong's forked version.  Will be examining the API to see if it is different for some reason.
Was not sure of the flow, so wasn't sure if the issue was in his code or the base.  Based on your response, I think it is something in the API portion of the code, and the API may be different on out Stash than it is in Bitbucket Server.  There are actually 2 spaces after "Commit" where the commit info is supposed to be, so somehow we think the API is returning a null string.
Yes, it's a Stash repo, not on guthub or bitbucket.
I'll let you know the results of my investigation now that I have a direction to search.

Ok, just adding an answer to "this looks like Xcode Server canceling it."
It was Buildasaur that was cancelling the integrations (See Issue #266).
The reason was that the API was slightly newer and the key used to get the latest commit was "latestCommit" when our version of Stash uses the key "latestChangeset".  So the headCommit was always "" and thus, the syncer always cancelled any running integrations and then enqueued a new integration.
Now that I've resolved that issue, the problem now shows:

[ERROR]: Syncing encountered a problem. Error: Failed to post a status on commit 0e3f0b953c1bdc13a52b70561ff1d9eafd87e7f3 of repo fightclub/buildasaur. Context: SyncPair: PR (1:carl/stash3-ssh-fix) + Bot (β [buildasaur] carl/stash3-ssh-fix)

And this has the SHA which was previously missing.  I'm sure this is probably an API issue and I just need to locate what needs to be changed.
I will provide an update here when I find out more.

Interesting question:
The section of code doing the status update (which seems to be failing) uses the targetUrl	String?	"https://stlt.herokuapp.com/v1/xcs_deeplink/myOSXserver.com/fb69145e64f3806cec314c66b5dbaf3c/fb69145e64f3806cec314c66b5dbb57f"	Some
With the comment	String?	"Result of Integration 1\n---\nDuration: 1 minute and 21 seconds\nResult: All 0 tests passed, but please fix 1 warning."	Some
I'm not familiar with herokuapp.com and such, but would running this behind a firewall cause problems?  If that just passes the URL to a 'local' app that's probably OK, but more than likely myOSXserver.com cannot be reached from the outside world.

Regarding the cancelling issue, I believe you understand the issue, but since you're using a fork of Buildasaur you'll have to look into it yourself, I'm not sure how to pull the latest SHA from the Stash API.
The link for stlt. is a trampoline server so that when you click on the link, it opens Xcode on the integration that Buildasaur reported. It's a nice feature for easy redirection to Xcode through a deep link. See the project here: https://github.com/czechboy0/satellite
Closing this since there's nothing outstanding. If you have any specific questions, bug reports, please open a new ticket.


noise wrap passes optional curve to noise handshake async recv

The noise handshake used in peers connection could use a custom Diffie-Hellman implementation. The Noisewarp constructor would benefit from passing the curve to the NoiseHandshake constructor making it more flexible. Besides, the implementation could be asynchronous so the receive method must await in order to decode the received buffer.
See this example:
const createHandshake = (keyPair, remotePublicKey) => {
	const curve = {
          dh: async (pk, seck) => customDH(pk, seck),
	  PKLEN: 32,
          ALG: 'Ed25519',
          name: 'Ed25519',
	  generateKeyPair
	}
	return new NoiseWrap(keyPair, remotePublicKey, { curve })
}

const node = new DHT()
const server = node.createServer({ createHandshake })

dont think this is relevant anymore, if it is please reopen


Enable drop event on the whole component

You should be able to drop a file anywhere, not just the canvas. Followup to https://github.com/excalidraw/excalidraw/pull/3383
@ThangHuuVu wanted to take this one (you'll need to comment for me to be able to assign you)

I'll be glad to take this one as my next contribution here!


build decision trees in parallel

@dwightguth si there a measurable performance difference you were able to find?
I tested it with the c-semantics and can't find anything relevant.


Dragon Quest Heroes II [PCSH00298]

App summary

App name: Dragon Quest Heroes II
App serial: PCSH00298
App version: 1.00

Vita3K summary

Version: v0.1
Build number: 1825-9664874a
Commit hash: https://github.com/Vita3K/Vita3K/commit/9664874aa3fd3a1af01b6401e60bd121d58b0918

Test environment summary

Tested by: Qiangong2
OS: Windows 10
CPU: Intel i7-980
GPU: AMD Radeon Pro WX5100
RAM: 16 GB

Issues
Game freezes on start
[10:51:55.406] |W| [unimplemented_impl]: Unimplemented _sceFiberAttachContextAndSwitch import called.
Log
vita3k.log
Recommended labels
-Nothing

You need on app summary to add this information. (你需要在应用摘要添加下列信息)
App name: Dragon Quest Heroes II
App serial: PCSH00298
App version: 1.00

You need on app summary to add this information. (你需要在应用摘要添加下列信息)
App name: Dragon Quest Heroes II
App serial: PCSH00298
App version: 1.00

And U need on commit hash to add this.
Commit hash: https://github.com/Vita3K/Vita3K/commit/9664874aa3fd3a1af01b6401e60bd121d58b0918

And U need on commit hash to add this.
Commit hash: https://github.com/Vita3K/Vita3K/commit/9664874aa3fd3a1af01b6401e60bd121d58b0918

you can edit your proper message for can update info

you can edit your proper message for can update info

edited

edited

_sceFiberAttachContextAndSwitch is now implemented on the emulator. Please re-test.

Vita3K summary

Version: v0.1.6
Build number: 2840
Commit hash: https://github.com/vita3k/vita3k/commit/4a2c6582
CPU backend: Dynarmic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:
Game crashes when trying to go ingame
Screenshots:

Log
vita3k.log
Recommended labels

Menu
Crash


Fixed paragraphs in Jay's Game App

@JayYang95 this kind of fix to your existing post is something you can commit directly.

(To your own patch branch)


The model may overfit the text sorting method, resulting in ineffective use of geometric and morphological information

Hi @phybrain , would you please give us more details about your thought?

Hi, thank you for your insight and problem.
We have tried to do experiments on the unsorted text, and the performance didn't drop.
The main aim of the text sorting method is to prevent truncation operation (MAX_BOXES_NUM ) from deleting useful information when the area of the top-left document has our interested entity in some situation.

Thank you for your reply, the score drop a little  when i trained on unsorted text。However, from the actual effect, it is not satisfying，and worse than sorted especially the digital type. It may be because there are a lot of digital types in my entity types，and digital types are uniform distribution.


Autoclose on OffCanvas doesn't work

https://www.yesvelte.com/docs/offcanvas
Clicking outside or pressing escape key doesn't seems to be working on both Edge and Chrome. But 'AutoClose with backdrop' works as expected.

thanks, We'll fix this soon


Question: what is the correct way to update the server version?

I have a livekit deployment running on a digital ocean droplet that I created using a generated startup script.
Since deploying, I see there is a new release. Haven't been unable to find any documentation recommending a method to upgrade to the latest livekit version.
What is the best practice here?

generate a new config and deploy a fresh server?
or will it work to just run the new config on an existing server running livekit?
is there a better way?

At this point, it's just a test setup but under single server production conditions.
Very much enjoying building on this platform so far, awesome project!

hey @mmckegg, it's actually as simple as updating the image tag in the generated docker-compose.yaml file.
For example, setting it to livekit/livekit-server:v1.1.2 and reboot the server. We should include this in the docs though. Glad you are enjoying it!


[textanalytics] regen on v3.1

Regenerates and records with v3.1

/azp run python - textanalytics - test


Operator switchMapIf not working with latest version

Hello kaeh
It's with surprise that I discovered the unfunctionality of switchMapIf operator I liked to use in my several projects
I hope this will be fixed asap
pls keep me aware of any updates
<3
 error TS2769: No overload matches this call.
  Overload 1 of 2, '(condition: (x: boolean) => boolean, obs: Observable<boolean>): OperatorFunction<boolean, boolean>', gave the following error.
    Argument of type '() => MonoTypeOperatorFunction<unknown>' is not assignable to parameter of type 'Observable<boolean>'.
  Overload 2 of 2, '(condition: (x: boolean) => boolean, predicate: (x: boolean) => Observable<boolean>): OperatorFunction<boolean, boolean>', gave the following error.
    Type 'MonoTypeOperatorFunction<unknown>' is not assignable to type 'Observable<boolean>'.

84         switchMapIf(
           ~~~~~~~~~~~~
85           (result) => !!result,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
86           () => tap(() => console.log("It's true !"))
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
87         ),
   ~~~~~~~~~

Hey i just checked the issue, sorry for the time to respond lol.
The problem in your example is that the second parameter () => tap(() => console.log("It's true !")) does not return an observable but a MonoTypeOperatorFunction because it returns tap.
Do you have another example of the operator not working ?


proxyBasePath requires leading slash to work correctly

Describe the bug
When providing a proxyBasePath, it must start with a leading slash to work correctly. The example in the docs does not have a leading slash.
Mentioned in this Slack thread.
Steps to reproduce the bug

Run the proxy as via Node.js
Specify some/base as the base path
try to curl http://localhost:3000/some/base/proxy
Get a 404

Expected behavior
I'd expect the proxy to "do what I mean". Whether I use a leading or trailing slash in a path section shouldn't matter. These things always catches someone off guard, and in this case I really can't see any reason why it should matter.
In other words, regardless of which of the following options you provide, the result should be the same (/base/path/proxy):

/base/path/
/base/path
base/path/
base/path

Logs, error output, etc.
No response
Screenshots
No response
Additional context
No response
Unleash version
No response
Subscription type
No response
Hosting type
No response
SDK information (language and version)
0.10 of the Proxy

You know, stale bot, I do still want to do this; I just don't know when I'll have the time. But it is a bug, so I'll pin it for now.


Indicate interaction way

In case of directed interaction, change in interaction table the name sp_taxon_1 and sp_taxon_2by from_taxon and to_taxon.

closed by commit : 07df8541be070e0b9fe0e5ec5c509adafc373e5b


💥 Fixed error connect with elasticsearch

Purpose
Solve the problem when make bootstrap cannot connect to elasticsearch
Proposal

[x] 💥 Fixed error connect with elasticsearch

@leduong Nice to see that richie works with Elasticsearch 7.5 :astonished:
Could you paste the error you got with Elasticsearch 6.6 as it should be working as well?

Origin

After

@leduong Sorry I was busy on something else. I think you are a victim of this configuration trick: https://github.com/openfun/richie/blob/master/docs/docker-development.md#elasticsearch-service-is-always-down
Can you try to follow the instructions in this section of the docs to see if it solves it with Elasticsearch 6.6?

Thanks of alot @sampaccoud

Thanks of alot @sampaccoud

So does it mean it works on your side with Elasticsearch 6.6 after this trick?
If yes, we should definitely upgrade to Elasticsearch 7 as it will avoid this bad experience for new comers. However, we will need to add an item in the CI to run tests for version 7 and still continue testing with Elasticsearch 6. 6 as well. Do you want to try to do this in your PR or should we close it and do the change on our side?


Add an option to use a different builds directory

Hi.
Currently I'm publishing my releases here on github and I want to keep this as an alternative way. Also I don't want to invest too much into a webspace for my projct and I don't like free webhosts too much either with all their advertising. So it would be awesome if your OTA-Updater could serve the needed files from a different location (eg. github) than the default /builds/full and /builds/delta directory.
Honestly I'm not sure how much really needs to be changed, cause many of the commands you used (ex. filesize) should work with http(s);// urls.
Maybe you can look into this and give me a short response.
If you don't want to (or don't have the time for it) would you like me to provide a pull request for this or should I just fork and don't bother you anymore?
wkr ADT

Hi,
Thanks for the issue. As you're hosting your own builds somewhere else, I suggest you looking for a completely different approach that is completely server-less, see https://github.com/julianxhokaxhiu/ota.julianxhokaxhiu.com
Regarding LineageOTA I think it fulfills another spot that is completely different than yours, but if you can find a smart way that could fit both, I'd be totally happy to review a PR and merge it :)
Let me know what you think.

I did a little bit of research on your serverless approach:
What I don't understand is how everything is connected and which parts need a login or user account being set up to work.
The page https://ota.julianxhokaxhiu.com/ resides on github.com (with a custom domain I guess).
There are two scripts from cloudflare included (anchor and rocket loader) which I suppose are for the redirect, but where is that configured?
And that is how far I could follow your approach. So I don't know how travis is involed in this. As far as I know travis is for actually building things from code. And last but not least Basketbuild, which I suppose is for the actual file storage, which in my case would be github.
As of this approach which uses only PHP I'm much more familiar with:
I just had to do a little bit of reasearch on Composer and Flight, but I think I get the hang of it now.
So I'm pretty sure that integrating an API call to github for fetching the releases of a repository and using these informations for serving the response would be possible. Only thing left to know is if the LineageOS Updater would accept a file from a different location (domain) than the updater script itself.

I did a little bit of research on your serverless approach:
What I don't understand is how everything is connected and which parts need a login or user account being set up to work.
The page https://ota.julianxhokaxhiu.com/ resides on github.com (with a custom domain I guess).
There are two scripts from cloudflare included (anchor and rocket loader) which I suppose are for the redirect, but where is that configured?
And that is how far I could follow your approach. So I don't know how travis is involed in this. As far as I know travis is for actually building things from code. And last but not least Basketbuild, which I suppose is for the actual file storage, which in my case would be github.

As written in the README of that repo, the idea is to use Cloudflare to handle required API redirects needed by the LineageOS updater app. Regarding Travis, it will build the API object response everytime you trigger the build ( you can trigger it manually or for eg. every night ). The API response will then be published on the github repo on the gh-pages repo allowing to use the repo via the http(s) server. In that case example I used Basketbuild to connect to the FTP and list files, but you could adapt the script to use Github API to fetch the release info and build the very same API object, starting from the Github API payload.

As of this approach which uses only PHP I'm much more familiar with:
I just had to do a little bit of reasearch on Composer and Flight, but I think I get the hang of it now.
So I'm pretty sure that integrating an API call to github for fetching the releases of a repository and using these informations for serving the response would be possible. Only thing left to know is if the LineageOS Updater would accept a file from a different location (domain) than the updater script itself.

Yes it will work just fine, there's no check between who servers the API response and where the file is hosted.


Replace black link

I changed black link in readme, because black moved it under the PSF umbrella and link changed.
https://twitter.com/llanga/status/1153417050024550401

Thanks!


php completer

Command
php
Description
PHP Command Line Interface
Homepage
https://www.php.net/
Documentation
No response
Repository
No response
Complexity
S
Anything else?
No response

Polar

related #2406
relate #2405


Update docs with latest DXP version (Resolves #375)

Let's not merge this PR until the version of repository of the DXP image is updated.
Thanks!

Let us know when it's ready @mdelapenya ;)

Hey team, this can be merged, as image and api repos have been updated
Thanks!

@mdelapenya @zenorocha Is this ready to merge. We are cleaning up PRs this week! 💪

Yes, it's ready. DXP image has been merged into api project and a Docker image has been pushed to Docker Hub


conduktor.yml - container name to conduktor-console

When I try to docker compose up with full-stack.yml, I keep getting an error saying conduktor-platform is missing, so when I looked at conduktor.yml
conduktor-console:
    image: conduktor/conduktor-console:1.21.0
    ports:
      - "8080:8080"
    volumes:
      - conduktor_data:/var/conduktor
    environment:

It wasn't conduktor-platform but conduktor-console! So in full-stack.yml's
conduktor-platform:
    extends:
      service: conduktor-platform
      file: conduktor.yml

If you change this part to
conduktor-console:
    extends:
      service: conduktor-console
      file: conduktor.yml

it works normally.

Hi, a fix has been provided, thank you very much!


jetson-containers philosophy

HI @idavis,
Here comes a philosophical question.
I am working on a robot app which is running on a jetson Xavier. This application will have several modules such as a vision system, motion control, navigation, etc. In principle, all modules could run some machine learning and therefore would have (common) dependencies such as Cuda.
I would like to have the application containerized and implement best CI/CD practices and am thinking about the following options:

A single Docker image with all my application in it.
PROS: This would be very easy to implement, and I could follow the jetson-containers pattern right away.
CONS: Having a single, heavy image doesn't sound very smart.

A Docker image per module and image orchestration via Kubernetes (e.g., k3s).
PROS: Easier to maintain; fault tolerance wrt specific modules; migrations become easier; etc.
CONS: It is not 100% clear to me how should I approach the jetson-containers pattern.

A potential solution I envision for option 2 is to (i) create my custom rootfs; (ii) on top of it run a base docker image which has Kubernetes installed; (iii) docker-in-docker style, run all my modules from the base container. Of course, I could also skip the base and have only (i) and (iii).
If the solution above makes sense (please, let me know if you'd have a better way!), then I see a problem: Let's say the robot app is made of 10 modules and that all these modules have Cuda as a dependency. To follow jetson-containers best practices, should I have 10 heavy docker images with the redundant Cuda dependency in it?  Wouldn't make sense instead to install Cuda together with nvidia-docker2 runtime into the base, and then leverage from it in all modules? Plus, having nvidia-docker2 runtime would also allow to easily run the Kubernetes Device Plugin (although that's not really a good argument).
Thanks.

There is a lot to unpack here. Please bear with me if I miss something.
Part 1
Docker layer caching ensures that if you have multiple containers that share layers that only one copy of the layers is pulled. Say you had 10 container images based on 32.3.1-jax-jetpack-4.3-all, the heaveist, only only copy of its layers would exist, but you would have 10 or more new layers which just have the additions you've made for your application. When building the base images I use --squash to remove extra files that were unavoidable as temporary files. And each image builds upon another image. Let's look at the nano-dev images:
l4t   32.3.1-nano-dev-jetpack-4.3-all             5.8GB
l4t   32.3.1-nano-dev-jetpack-4.3-devel-cudnn     4.26GB
l4t   32.3.1-nano-dev-jetpack-4.3-devel           3.37GB
l4t   32.3.1-nano-dev-jetpack-4.3-deepstream      3.37GB
l4t   32.3.1-nano-dev-jetpack-4.3-runtime-cudnn   1.88GB
l4t   32.3.1-nano-dev-jetpack-4.3-runtime         1.44GB
l4t   32.3.1-nano-dev-jetpack-4.3-base            683MB

if you pull runtime you'll get 1.44GB. If you then pull base nothing will be pulled and you'll see docker saying the layers exist already. Unless you are doing DeepStream, you will likely work your way down to base and then install the needed components. The other containers are really for convenience in getting started.

You're right, I didn't think about docker layer caching and how well the jetpack images are hierarchically organized!
Curious about the next Part...

Part 2
For anything speed sensitive, I recommend moving to as few containers as possible. The overhead of sending data between containers can cost dear milliseconds. Most of my work is with Azure IoT Edge and docker-compose. Azure IoT Edge handles the CD part.
With regards to fault tolerance, you can specify the resiliency of your containers natively in docker. K3s and K8s won't give any additional fault tolerance as everything is running on a single node.

Part 3
I'm not sure about other tools, you can set up Azure DevOps with an environment (VM) which you can host in the cloud or on your machine. The ARMing yourself post would allow the arm64v8 builds to take place on the VM.
Or, you could use it to run the builds on your Xavier device if you wish. Once you install QEMU on the host along with the arm32v7 part of ARMing yourself, the arm build agent should work. (If setting up the VM, you are given a command to execute which includes https://vstsagentpackage.azureedge.net/agent/2.164.7/vsts-agent-linux-x64-2.164.7.tar.gz, just change x64 to arm.

That's very useful feedback, @idavis , thank you!
@Part 2, I'll then try to follow your suggestions. I was already planning to use Azure IoT Edge, I will start right away. And freeze the k8s plan in favour of few containers coordinated with docker-compose.
@Part 3, my current plan is to try out Github Actions inside a VM or a container, and indeed run the builds on the Xavier. But I'll keep your suggestions in mind, in case I get stuck somewhere.


how to get history to work with observable location in MobX

Please see this issue raised in MobX: https://github.com/mobxjs/mobx/issues/710
Maybe someone can help?

I think I managed to solve this, see https://github.com/mobxjs/mobx/issues/710#issuecomment-268379145


Only check with geos-config in setup.

Do not import shapely.libgeos.

What do you think of the comments at the top of setup.py, @mwtoews? Do they help? Am I overlooking any setup use cases?

I think the changes look good. They seem to find non-standard installs.
Do we really want the script to fail if geos-config is not found? This GEOS utility is only installed if either installed from source, or if the user has the -dev packages installed (e.g., libgeos-dev). Windows, for example, does not have the utility, since it is a shell script. Shouldn't it just warn that the version cannot be verified, and skip building speedups?

geos-config only with -dev packages... I'll have to think about this a little more then.

Went with the warning if geos-config can't be found.
If geos-config is found, and its version doesn't meet the Shapely requirement, install will fail ... unless this check is overridden by NO_GEOS_CHECK=1.


fix(router): [nuvei] Nuvei recurring MIT fix and mandatory details fix

Type of Change

[X] Bugfix
[ ] New feature
[X] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Moved mandate logic outside card_info to MandatePayment
Included Device detail to send IP address to nuvei (mandatory)  for both card_info and mandate flow , Ip address is taken from browser info
Billing address for rawcard payment flow
Moved broswer info inside three_ds request construction, since its optional for non-3ds card_info flow

https://github.com/juspay/hyperswitch/issues/3537
https://github.com/juspay/hyperswitch/issues/3511
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

Open Issues :
https://github.com/juspay/hyperswitch/issues/3537
https://github.com/juspay/hyperswitch/issues/3511
Changes done to support Recurring mandate payments flow for Nuvei and included fix for mandatory detail population, like device_details, billing address and browser_info
How did you test it?

Added screenshots from testing
Recurring pay with mandate

Payment With and without IP address

Checklist

[X] I formatted the code cargo +nightly fmt --all
[X] I addressed lints thrown by cargo clippy
[X] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Please fix clippy error, so that CI checks will succeed.

Thanks for the review, We misunderstood this as an existing issue. resolved this clippy warning.


ECO flow inserts buffers backwards

We currently connect the output of the FF to the output of the delay buffer.

@donghl17 @msaligane This could do with a close review. Does it look right to you?

@antonblanchard Good catch! We can see that as well in our netlist...

@antonblanchard Thanks for fixing it! The delay is added to the circuit anyway so it's hard to notice. I did check this thing before actually, but something messed up when we tweak the code later.


fix: diagnostics crashes if user is not logged

Summary
If you try to access the diagnostics popup from anywhere out of your logged dashboard, the app crashed.
Additionally, there was a wrong locale
Changelog
fix: diagnostics crash if user not logged
chore: cleanup code

Relevant Issues
Close #3507
Type of Change
Please select any type below that is applicable to your changes, and delete those that are not.

[ ] Breaking - any change that would cause existing functionality to not work as expected
[x] Chore - refactoring, build scripts or anything else that isn't user-facing
[ ] Docs - changes to the documentation
[x] Fix - a change which fixes an issue
[ ] New - a change which implements a new feature
[ ] Update - a change which updates existing functionality

Testing
Platforms
Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[x] Linux
[ ] Windows

Mobile

[ ] iOS
[ ] Android

Instructions
Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.
Checklist
Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or modified tests that prove my changes work as intended
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have verified that my latest changes pass CI workflows for testing and linting
[ ] I have made corresponding changes to the documentation

Maybe also a good time to move this to key value boxes similar to the other popups? @jvegis

And is there a reason the app version is not being displayed?

in dev mode i have never seen the version appear

Can we make the button full width?

pushed


Establish a formal RFC process for changes

Our feature suggestion docs have some guidelines for creating feature proprosals, and link to some awesome examples of requests, but a more formal RFC process could better guide community contributions. Higher quality proposals will also be easier for everyone to review before the contributors meeting.
It looks like some effort has already been made with Steal. Ember RFCs, which came from Rust, is a great project to look at for guidance on this issue.

👍 I think this is important because it ensures that decisions are made in the open and allows interested parties to contribute their opinions.  It also prevents rushed decisions as the RFC process has several steps to it.

I think this is a duplicate issue, or at least a secondary issue after  https://github.com/donejs/donejs/issues/625 is decided.
I don't think the core contributors need to comply with an RFC process unless "unanimous consent" has been violated.  Meaning, we can make changes without having to do an RFC unless its desired from the contributors.

I don't see an RFC as a voting mechanism (although it can become that if there is disagreement) but rather as a more formal issue mechanism.  Too often issues can be understandable to no one but the person that writes them. An RFC is like an issue that has been edited for clarity and thoroughness.
Some (many) things wouldn't fall under an RFC, they are typically reserved for "substantial changes", which is something we'd be able to define.

Thanks @justinbmeyer, I don’t think I had read through that issue before and it brings up a lot of great topics related to this.
I think any new features ,changes to existing ones, or deprecations/removals should go through the RFC process. Basically. anything that would result in a minor or major version bump.
I believe it’s important for everyone, including core contributors, to comply with this process. This is important for a few reasons:

Increase visibility of changes (anyone can watch the RFC repo more easily than any of the sub-projects).
Increase community involvement (gives a voice to people outside of the core team).
Decrease potential confusion by formally explaining changes (helps the core team be on the same page).

Additionally, I’m not 100% sure how we would get “unanimous consent” or know whether any contributors object without somehow communicating the changes, which is what the RFC process is intended to accomplish.

@chasenlehara While I understand the desire, a process as formal as ember's would do more harm than good.  Something like CanJS 3.0 would have been greatly slowed up to comply with it.  Even now, changing peak to peek isn't something that should go through a formal review process.  It shouldn't take 7 days to turn around.  No one should have to submit a pull request to some other repo to get it underway.
I don't think it would give a voice to people that don't already have one.  Anyone can create issues.  I've never heard anyone make this complaint and I don't think there's people who "secretly" feel this way.
And, we should not have another repo for this.  There are 30 or so repos already.  I find it extremely useful that all of the can-connect issues are in one place.  It would be a step backwards to move this somewhere else.
I think this is a solution in search of a problem.  Take the most recently controversial feature ... can-stream.  Adam wrote this up: https://github.com/canjs/can-stream/issues/2 ... after a lengthly discussion, including one on the contributors meeting, we settled on a pretty reasonable API:  Proposal 3 - spaces and dots in https://github.com/canjs/can-stream/issues/3 .
I think creating an issue, getting it tagged enhancement is probably enough.  If it's controversial, it should be discussed at the DoneJS Contributors meeting.
By "unanimous consent", I mean that we operate under that presumption.  That it's on the other contributors to say "hold up, lets talk about this".

I do agree with @matthewp that guidelines that solve the following would be helpful:

Too often issues can be understandable to no one but the person that writes them. An RFC is like an issue that has been edited for clarity and thoroughness.

Generally speaking, I will simply clean up the proposal and even delete comments that are no longer relevant like I did in: https://github.com/canjs/canjs/issues/1699

@justinbmeyer I don't think anyone would suggest that changing peak to peek should require an RFC. It's usually reserved for "significant" changes which is something that we can define.

I don't think it would give a voice to people that don't already have one. Anyone can create issues. I've never heard anyone make this complaint and I don't think there's people who "secretly" feel this way.

Issues are not good for big changes because:

Issues are not threaded so they quickly become unreadable.  With a PR you can comment directly to the proposal, which keeps discussion to-the-point. When the author revises the issue those comments are hidden, so the discussion stays better organized.
There is a pressure to respond to issues quickly, to get them off of your notification list. So you often might not give them the care that they deserve. Given that RFCs don't expect immediate response, there is not that pressure.
Once an issue is out of someone's notifications it's largely forgotten.

Here's an issue I created almost three years ago that has gone unresolved in that time. Here's a followup issue, and another and in both cases the discussion pretty quickly fizzled out. I think this type of thing would have been a good candidate for an RFC because I could have directly updated my proposal based on feedback and taken discussion ending to mean it's ready to merge.
This recent issue suggesting radical changes to the donejs cli is another example of something that I think has a better chance under the RFC process than as an issue.

I think this is a solution in search of a problem.

One problem to keep in mind is that new projects create a maintenance burden on DoneJS. For example, steal-socket.io has some new features that, while I do not object to, I do now have to support given that it's an officially documented part of StealJS. If this were done as an RFC I might have stopped to think of that implication.

i don't know what gets discussed here at present changes already taking to long i don't think that the team is even big enought to do RFC Flows and my issue thats linked to this is not as complicated and will not change the existing functionality or so called api sure it will change a lot internal but not for the user the commands stay the same and that. even functionality stays the same there is only one thing that would need evaluation to find best method.

Which issue?

@matthewp https://github.com/donejs/cli/issues/63

@matthewp From Oct till now befor 3 hours branch major was not consistent to master and it was not even clear that this will get merged :D so now i can do a stable pull request to major kevin merged the master to major :100:

That would have been a perfect issue to do in an RFC. If you plan to make massive changes to a project it's good to get feedback on the impact. In this case you suggest getting rid of donejs-cli but donejs-cli exists for very specific reasons. We could have discussed this in an RFC and saved you from coding stuff that is unlikely to get accepted.
I hope when this process is in place you will submit an RFC for this 😁

and i think pull requests can replace RFC Simple pull requests should never get out of mind. and they are clean review able now ! ask @justinbmeyer about that he uses the review function already intensiv :+1:  in production :) at donejs/bitballs

@matthewp the good thing is i don't need to worry about accepting that :) all people that use my project starter kids wich are like ionic starter kids that i plan to market don't need to depend on the donejs cli client :) and i also did new public donejs generators that any one will and can use :) so its simply something that i will contribute back to you it don't helps me if this gets merged or not.

Ah, ok, from this post it sounded like you did care. Must have misread it, I guess. Then everything's gravy, the RFC process doesn't affect you. 😊

@matthewp my main project is a full xamarin compitor using atom and custom generators and custom atom modules to build something like xamarin but with much more nice stuff and much more rapid flows and also a big part of it is canjs integration :D because i like to use it for frontend applications.
So i offer a full IDE with DoneJS Support at present thats my main project but its only donejs support its not realy depending on it i only try to stay compatible to DoneJS and CanJS main projects.

@chasenlehara i think we could we should finish the discussion up if we want to create a extra RFC repo for that like the others projects do or simply stay with PR: like Titels for Proposals in the Issues
i am strongly for PR: Titles in the main repo for Issues.


Add builds for linux-aarch64 & linux-ppc64le

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Looks like the linux-ppc64le builds here are getting blocked by https://github.com/briansmith/ring/issues/1182, which is seemingly resolved with ring v0.17.0 - might be worth filing an issue to make sure we double back to see that those builds work later on


Customizable Rollups: Account Soft Credit Jobs Using Default 200 Batch Size

If a customer has many rollups/Filter Groups and many Accounts with thousands of Account Soft Credits, they may hit heap size errors when the CRLP_Account_AccSoftCredit_BATCH and CRLP_AccountSkew_AccSoftCredit_BATCH run. Typically we would suggest reducing the batch size, but we don't have one for this job. The suggestion is to either create its own or share the Rollups_Account_Soft_Credit_Batch_Size__c field (for non-skew at least).
Either solution should be set in: CRLP_RollupBatch_SVC.cls, Lines 265-296
Sample Stack Trace:
Class.npsp.CMT_FilterRule.isIncluded: line 149, column 1
Class.npsp.CMT_FilterRuleEvaluation_SVC.evaluateFilterGroup: line 115, column 1
Class.npsp.CRLP_RollupAccSoftCredit_SVC.processRollups: line 80, column 1
Class.npsp.CRLP_RollupProcessor_SVC.completeRollupForParent: line 303, column 1
lass.npsp.CRLP_RollupProcessor_SVC.startRollupProcess: line 115, column 1
Class.npsp.CRLP_Batch_Base_NonSkew.execute: line 271, column 1

See Work Item for full Investigation.

**lurch: add

Tracking W-032439

Included in beta release 3.154 (Beta 6)

Included in production release 3.154


Cask Applications dir symlinks not generating?

I ran script/bootstrap and then script/install and it appears that cask has successfully installed the apps I listed, but only a few of them symlinks into the "Applications" directory. There are none in the ~/Applications directory either. Any ideas what would cause some/most of them to install, but not symlink? I even ran 'dot' a few times but the symlinks don't generate then either. Thanks for your help!

You know, I'm not sure! I looked into things briefly and nothing really jumped out at me. Our usage of Homebrew isn't really too specialized here, so I kind of wonder if it's something with Homebrew that's worth looking into. Maybe there's some additional debug you can print out if you brew bundle manually? Or maybe there's some permissions mis-set in your ~/Applications dir?

Thanks for the quick response. I just did a fresh install of homebrew and that didn't fix it. Also, in the Brewfile script, you have the appdir set to /Applications, not ~/Applications. I definitely would prefer them to go into /Applications. Hmmm. Also, it's weird that some of them would get properly symlinked and others don't. There isn't a 'verbose' mode or anything I can enable to get more details, is there?

There isn't a 'verbose' mode or anything I can enable to get more details, is there?

Yeah, try running brew bundle -v.

Ahh. I think I figured it out. I think it has to do with the fact that when I first ran the scripts, I had a few of the apps already installed on my Mac. Just for consistencies sake, I deleted the apps and re-ran the dot command hoping they would fall into line. The problem was that the app was already flagged as 'installed' by cask. I ran brew cask uninstall appname and then re-ran the dot script and everything worked as expected! Thanks again!

Huh. Interesting! Glad things got sorted. :sparkles:


General Contract Cleanup + Write out style guide

Write out the styleguide that Jan and I used for Aztec connect + update it and see if we can use https://github.com/0xKitsune/solstat to enforce as much of it as possible (or add extra rules).
If solstat requires too much work to get to a good state for us, consider using https://github.com/LHerskind/solhint which has many of the rules, but relies on gettign node into the contracts part again 😓.
Update the contracts to follow the style guide.

Adding linter and performing some general cleanup in #667 and #674.


renderLink() breaks URLs with query params

We have a Craft CMS site that uses this package via Yii2. The body of our account activation emails is rendered from markdown and we're running into broken links that prevent users from completing registration.
The activation link URLs have a format similar to https://craftsite.com/login/pass?code=SEjpQz7MDIhMSmU4IY1xtNEDiClcAqwr&id=9ca06bc2-196a-4734-a1e0-7e98efb90bc3
However during parsing, renderLink() returns a link with the URL https://craftsite.com/login/pass?code=SEjpQz7MDIhMSmU4IY1xtNEDiClcAqwr&id=9ca06bc2-196a-4734-a1e0-7e98efb90bc3
This is due to htmlspecialchars($block['url'], ENT_COMPAT | ENT_HTML401, 'UTF-8') (LinkTrait.php line 230) converting & to &, which breaks the URL.
I'm wondering if it's necessary for any encoding of the URL to take place at all. Shouldn't it be incumbent on the author/system creating the URL to make sure it is encoded correctly? If there needs to be encoding, it seems like htmlspecialchars() is the wrong choice, as some of the characters it transposes are special/reserved URL characters, while others are unsafe characters that would be better handled with urlencode() or similar.
Is this something that can be fixed and released quickly?

What actual error are you seeing?
Special characters such as & in a URL in an href attribute are supposed to be HTML-encoded, so a link such as this is correct: test.
Could it be that the HTML being output by this library is being double-encoded? i.e. your link looks like https://craftsite.com/login/pass?code=SEjpQz7MDIhMSmU4IY1xtNEDiClcAqwr&amp;id=9ca06bc2-196a-4734-a1e0-7e98efb90bc3?