Mimetype

Look story short: I really like The Mother of All Demos and looked into the modern version of HyperScope. Sadly, it is already based on ancient tech, so wanted to bring it up to date before it is too difficult. First choice was to use http-server. Unfortunately the .opml files HyperScope uses didn't load because of the mime-type/content-type and http-server has no way of defining custom types.
So I gave it try, fixing #66 and everything looks good but a few things, that I hope you guys can help with.

Firstly I'm on windows right now, so get a lot of line endings equality errors (\r\n instead of \n) when I run the test suite. I think everything passes but it is difficult to see.
I'm not sure how to write out warnings. In this case, when a path to a .types file is wrong (404). I would like to inform the user, not crash estatic or ignore the error.
How do I go about testing number 2?

Anyway, I hope you look positive at this feature and perhaps I can reach my end goal :+1:

ecstatic doesn't have a way of emitting warnings or other log events, and I think that's out of the scope of this PR--though perhaps something I should consider! Given the current state and where you're doing the check, I would throw.

All right, I'll throw. Should I squash all the commits into 1? Or anything else?

Ehh, I can manage squashing if I think it's necessary. In general I don't get overly finnicky about commit history of outside contributions because it would take way too much time.

Cool. So I'm almost there. Got an issue with the content-type.js test case. My teardown function doesn't properly tear down ecstatic. If you comment out line 63: 'mime-types': 'custom_mime_type.types' the test still passes because the mime-type for .opml is defined in the previous test. Any quick ideas to what would kill the ecstatic instance?

You'll see that in a bunch of the tests I have timeout code that kills ecstatic if all the requests are done but a mystery open handle is still kicking around. I don't remember why I thought this was okay, but if it's good enough for the other tests...

I've asked for a reset implementation in mime of mime-types. https://github.com/broofa/node-mime/issues/124
I'll try to spawn ecstatic in child process and then kill that between tests.

Hmm.. since I can't setup forks without support in ecstatic.js, which I rather not do just for testing and that the code we are testing passes each individual  test in content-type.js, I'm inclined to let it go for now.
Interestingly, it seem that node cluster could be used. But t's out of scope for this PR.

@jfhbrook if I use setTimeout process.exit(0), then I would have to split content-type.js into 3 different files, right?

I don't think so? You should be able to handle the timeout at the same place as you call server.close.
As an aside though, I don't think we have to test the mime package's behavior. We should assume it behaves as-advertised.

I appreciate all the work you're putting into this by the way. Looks like good work!

I think it is good practice to test the parts of a third-party package that you use in your project. This automates detection of changes made in that library. It should make it very comforting to upgrade the package. If anything changes, we will know before pushing a new version with updated dependencies. I understand your stand point though. But I needed to learn mime anyway, so might as well do that in a unit test.
I'll give it a shot with timeout....

Nothing can happen after process.exit(0). So have to split up the test into 3 different files. In the long run, ecstatic should be able to proper clean up after itself. In long running processes or memory constraint devices, this could be a real issue.

I can't think of anything else to do in this PR. Ready for merge?

@jfhbrook wait. While implementing indexzero/http-server#35 I realized that the path to the .types file should be independent of the root path. Say I want to serve files from one directory but want to load mime-types from another directory.

The README.md says that default for root is root          : __dirname + '/public', so I made the following condition in ecstatic.js:
var root = dir && path.join(path.resolve(dir), '/') || path.resolve(__dirname + 'public'),

Is that fine?

After working a bit with the default path to public, I've changed my mind. I find it confusing. Much better to have the user define a root.
I'm trying to make the test, platform agnostic so I can actually run all of them on windows. And tripped over line 23 in common-cases. Surely it should be c.js as it is the content of d.js. it's a bit worrying that the test has passed so far. But my current experience is that ecstatic isn't that easy to test...

So I went through all of the tests and only one is failing. It turns out that many of the tests didn't run - at least I don't think so.
Line 100 in range.js expects 3-11/12 but gets 3-10/11. What is the correct value?

@jfhbrook I've update tap to version 1.0 and with that I had to move the scripts in the test folder that is not tap tests into a seperate folder. I already had a secret folder to test for .types file being in another directory that the root (it had to be outside public), so I used that.

@jfhbrook do you know what malformed-dir.js and malformed.js is suppose to test? I'm having trouble getting them to pass and don't know what they are suppose to do.

@jfhbrook ok, I get that they test what happens with a malformed path. I couldn't, for the life of me, get http.get to work. So changed it to use request as in many of the other tests.
We're still some tests short. I could really need a little feedback....

right, so before we had 267 tests and now we have 255. It turns out that the old version of tap counted none test cases as well, i.e. common-cases.js counted 2 tests but has none and 304.js counted 3 but only has 2.
So if travis agrees - I think I'm finally done with this PR (by far the longest I've ever made)

Yeah, okay. I'll try to review some time this week.

@jfhbrook thanks. I know it's mouthful - it was for me - and will do what I can to help ease the merging of this. In the mean time, I'll continue work on indexzero/http-server#35, based off this PR.

You know ecstatic can be ran as a bin, right? npm install ecstatic -g && ecstatic

@jfhbrook eh, yes. What do you mean?

I guess what I'm saying is, I don't understand what value http-server adds.

ehh nvm, it looks like http-server ships with cors support and a few other things.

ah. I like http-server it super easy to use and I only knew about http-server, not ecstatic. I came to ecstatic because I wanted custom mimetypes. And since http-server depend on ecstatic... well, the rest is history. - yep it started here :)

@jfhbrook should mention that union-multiple-folders.js creates a [object global] folder in the root. I haven't checked why but pretty sure that that didn't happen before<EMAIL_ADDRESS>

hmm trying to figure out what @yfr wanted to do in union-multiple-folders.js. I'm not sure that test ever made sense. Did I delete something?

@jfhbrook thanks for your time. Is there anything I can do to help this PR getting merged? I'm off-line this weekend but will be back mid next week.

Released in https://github.com/jfhbrook/node-ecstatic/releases/tag/0.8.0
Thanks!

@jfhbrook that's awesome  - thanks!
minor detail: though public is a fixture folder 8b27bba


End-to-end tests may test wrong commits

Here is what I think happened:

I've accidentally pushed commit 64ca94772263b303c83e637d203cbc13f543a3fd to main. It breaks end-to-end tests as there is no wal_acceptor in the Docker container built and our internal scripts in end-to-end tests assume that it exists.
I've noticed that and cancelled all builds for the commit.
I push a new commit 989fabf0ba06af481ced3df90aa5e91207ca0ec2, reverting the old one. Tests start.
I create a branch called wal-acceptor-alias-remove (as I should've done before no. 1 to prevent the whole situation), sync it with main, cherry-pick commit 64ca9477 (doing nothing, as it's already in main) and push it. So now wal-acceptor-alias-remove and main are the same commit.
Things break: end-to-end tests get triggered for the wal-acceptor-alias-remove branch and remember that commit 64ca94772263b303c83e637d203cbc13f543a3fd now belongs to this branch.
I update wal-acceptor-alias-remove so that it is now at a different commit which breaks tests again (as expected, it was WIP).
End-to-end tests for main are restarted for whatever reason, but now they check out wal-acceptor-alias-remove branch instead of main and fail (see the run for Oct 12, 2021 20:13 UTC). You can look at the "Set environment variables for containers" step (third from the top) to see that ZENITH_IMAGE_BRANCH is not main at all.

My understanding is that CI in this repository is configured to trigger CI in our internal repository with special arguments like "what branch to build Docker image from and what commit to update status for". Thus the scenario above became possible. Workaround is to re-run the internal CI with proper branch, I think.
@funbringer , does it sound plausible?
If so, this issue is only a symptom. The real problem is that end-to-end tests for a specific commit X may actually check out Docker image for commit Y, if a branch has changed since commit X was pushed. I think this is quite bad for reproduction. The proper fix would be to remove zenith_image_branch altogether and only use commit's SHA.

Ah, GitHub attaches workflows to commits, and attaches the latest branch to the commit. So the CircleCI workflow on main was actually for wal-acceptor-alias-remove. So the job re-triggered end-to-end tests with wrong ZENITH_IMAGE_BRANCH again.
New plan: go to CircleCI directly, find job for the same commit in a different branch, re-run it. It works!


Manually configured API-Quotas get lost, when API is re-created

API-Mgr. CLI version
1.3.8

Please make sure to use the latest available version before reporting a bug.

API-Manager and Service-Pack Version
7.7.20201130
Expected behavior
Updating APIs via CLI without losing quota settings
Actual behavior
Losing quota settings while updating APIs via CLI
Log-Output in Debug
3715   DEBUG APIManagerAPIAdapter| Found: 5 subscribed applications for this API. Taking over potentially configured quota configuration.
Test case sample

Please describe the steps you have done to replicate the issue

create quotas via WebUI
update APIs via CLI
check quota settings via WebUI
3.1 settings are lost

The issue has been fixed and is part of the release 1.3.9.
Please note the following also mentioned in the documentation:
Application-Quota overrides are not taken over as long as the API is unpublished


Question/Suggestion: Javascript taghelper for @model

Right now, to get the model in a JSON one uses Newtonsoft.Serialize on the view.
For security reasons it's better to place it on a html tag and then access it via data attributes from js.
So I have a question/suggestion thing.
Is it possible to have a "secure, properly encoded" tag helper <script asp-model="variableName">console.log(variableName)</script> that renders something like:
<script>
var variableName = // ..... serialized and properly escaped @Model data .... //
console.log(variableName) // ... here the extra content.
</script>

If that can be done, wouldn't it be great to have it built in on the frameworks taghelpers? I would love to know your thoughts on this, and if there's interest I can contribute with an implementation.

@DamianEdwards

For security reasons it's better to place it on a html tag and then access it via data attributes from js.

@Bartmax Could you please clarify how you would access this data from "data attributes"?

Something like :
<script type = "text/json" id="id based on asp-for+"_json"">
//Json content
</script>

it's safe because it is not executed because of the custom type. Moreover it doesn't create JavaScript vars in global scope. Json may be acessed via id, and parsed to get a JavaAcript object.
It is easy to create it also without any TagHelper.

Closing because there are no plans to implement this.


Justfile not work on other platforms

Just recipes not work on M1 Mac and Windows.

But how many people work on windows....?  I think this priority should not be too high

@sharkAndshark could you elaborate? Which recepies? What error you get?  Justfile according to docs should work on all platforms.

@sharkAndshark any updates on this?

A fast check and I will update this many times for other recipe
On my  M1 MacBook:
just start
  Created0.0s ted image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was reques
[+] Running 3/3rtin-db-1
 ✔ Network martin_default                                                                                Created0.0s ted image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was reques
 ✔ Container martin-db-1                                                                                Started0.1s
 ! db The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested 0.0s

Seems that jq behaves differently on various platform

Curl on x64-linux before jq -e
zyj@martindev:~/martin$ curl -v http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3
...
{"tilejson":"3.0.0","tiles":["http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3/{z}/{x}/{y}"],"bounds":[-180.0,-85.0,180.0,85.0],"center":[0.0,0.0,0],"maxzoom":3,"minzoom":0}

Curl on M1-Mac before jq -e
zyj@zhangyijundeMacBook-Pro martin % curl -v http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3
...
{"tilejson":"3.0.0","tiles":["http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3/{z}/{x}/{y}"],"bounds":[-180.0,-85.0,180.0,85.0],"center":[0.0,0.0,0],"maxzoom":3,"minzoom":0}%
zhangyijun@zhangyijundeMacBook-Pro martin %

ok, so basically the issue is that diff does not produce identical result. This we can fairly easily fix with a conditional run of the diff utility.   Just supports os() function - so we can simply do a test for os() == "linux" - and only do the diff in that case.

@sharkAndshark please let me know if this works for you

I will test it once I can reach out my Mac. It should be hours later 🥲 @nyurik


It fixes the bug of throwing unknown error by accessing workspaceFolders[0].uri.path when worksapceFolder is an empty array but not undefined.
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee<EMAIL_ADDRESS>
For #1419

@jyoungyun PTAL :-D


502 bad gateway when navigating to localhost

Hi. I recently tried instructions from docs as standalone, and also as development install.
docker build -t "bailo:standalone" -f ./Dockerfile.standalone .
docker run --name bailo -p 8080:8080 -d bailo:standalone
The app docker builds and docker runs fine. I can see it in docker desktop for windows.
When I try to navigate to localhost:8080 however, I receive "502 bad gateway nginx/1.18.0 (Ubuntu)".
I tried looking online for similar issues people have with nginx and have tried:

turning off firewall temporarily
using incognito mode
swapping 'localhost' for <IP_ADDRESS> or <IP_ADDRESS> for upstream in /Bailo-main/infrastructure/standalone/nginx.conf
adding trailing / to proxy_pass within /Bailo-main/infrastructure/standalonenginx.conf
Apols if I'm being daft. Grateful for any feedback/advice.

I've just redownloaded the entire project, to try again afresh.
Standalone still returns bad gateway.
Considering the 'npm run certs' recommended for development version....
The certs file already exists such that run certs gives an error.
It contains a file san.cnf (though not yet certs/key)
-p doesn't exist prior to run certs command.
Error occurred while processing: certs.

Hi Notabot123,
This looks to be a problem with our current version of NextJS, where frontend is binding to shared docker eth rather than localhost.
Could you please add:
ENV HOSTNAME <IP_ADDRESS>
Here
Will add it to future PR. Thank you for bringing this to our attention.

I can confirm this now works for me in standalone: many thanks.

Fixed in #1587


Generated Python code doesn't seem to be package-qualified

It looks like a .proto file's having a "package" directive has no effect on generated code. It should probably have the effect of placing the generated Python module inside a package hierarchy created from the .proto file's "package" directive.
I'm not sure and we'll probably want to work with the proto team on this. @haberman, what am I getting wrong here? Given that we've only written a protoc plugin, is this behavior even under our control?
Exit condition for this bug: given "package grpc.testing" in python_plugin_test's test.proto file, python_plugin_test should have "from grpc.testing import test_pb2" statements where it currently has "import test_pb2" statements.

It's true that "package" does not affect the module hierarchy in Python. It is surprising, but when you fully work through all of the implications, you realize that this behavior is the only behavior that will actually work.
The necessity of this behavior derives from these two inherited constraints:

Python requires a 1:1 correspondence between module names and filenames.
Protocol Buffer codegen requires a 1:1 correspondence between .proto filenames and generated filenames (ie. _pb2.py).

If we respected "package", imagine that we had these two .proto files:
// foo/a.proto

package mypackage;

message M1 {}

// bar/a.proto

package mypackage;

message M2 {}

In the status quo, this will produce two output files foo/a_pb2.py and bar/a_pb2.py.
If we used the package name instead of the directory name, both of these files would try to generate mypackage/a_pb2.py!
The package keyword can only be respected in languages that let source files declare symbols in any namespace, regardless of the filename (eg. C++, Ruby, JavaScript, etc). In these cases, a file called foo/a.h can declare a symbol in the mypackage namespace.

IIRC, there was some thought towards using insertion points in *_pb2.py files to allow multiple files to 'generate' mypackage/a_pb2.py, but that would require insertion points being stabilized among other things. We're currently using insertion points for our generated GRPC code, though, and haven't yet been slapped on the wrist.
There was also some pressure from the other language subteams regarding consistency, wherein everyone else appears to be generating entirely separate files for GRPC code rather than using insertion points in the usual protoc-generated files.

@tbetbetbe, would you read over @haberman's response on this issue? Does it forecast complication for the versioning behavior we discussed at the Tuesday morning meeting?

@haberman Would it be reasonable to enforce in the protoc Python plugin behavior that requires the package, if specified, to be the same as the paths along which the .proto files exist?

I don't think the Python generator could enforce this unless all generators did, and I think it's too late to try enforcing any kind of rule like this.

Despite being the individual who opened this issue... I'm not actually sure that there's a problem here. I certainly am not aware of a Beta-required need being tracked here. Do you agree @tbetbetbe?

I agree, I think we can close this.


Support liff-inspector via using CDN

Hope you could support this package by using CDN.
Because we are building an LIFF App on Flutter Web. It couldn't include npm module.

You can use liff-inspector via CDN by UNKPG. Could you try that?
https://www.unpkg.com/<EMAIL_ADDRESS>

@cola119
Thank you. I'll try it.


optimum soak time

As a fisherman I would like to know what the optimum soak time is https://github.com/StAResComp/sifids/issues/5

Hmmm - could?


Teams Meeting app

Hi, Can we make a teams app to capture actual attendee list for a teams meeting?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f57a31a0-e815-faa4-653d-795ae8a8e4d7
Version Independent ID: 8f48ea3d-231b-2776-41b7-11890ea2d3c0
Content: Microsoft Teams developer platform - Teams
Content Source: msteams-platform/overview.md
Product: msteams
GitHub Login: @clearab
Microsoft Alias: anclear

@solj2018,
Yes You can make use of Graph API in an app for fetching meeting info and participant details.
https://docs.microsoft.com/en-us/graph/api/onlinemeeting-get?view=graph-rest-1.0&tabs=http


Why the request struct should be named as xxxReq and the response struct should be named as xxxRes. in gf version 2?

Why the request struct should be named as xxxReq and the response struct should be named as xxxRes. in gf version 2?
GF v2中，为什么请求体必须以Req结尾？响应体必须以Res结尾？是基于什么原因这样规定的？

https://goframe.org/pages/viewpage.action?pageId=30738989

@liuxingke 工程规范化，请求输入输出的命名只是其中一个小点，目的是是开发者将精力聚焦在业务逻辑本身，其他由框架、工具来约定维护即可，请参考：https://goframe.org/pages/viewpage.action?pageId=30740166


the bug about lp core i2c  in esp32 c6  (IDFGH-10740)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2-dev-1449-gd2471b11e7
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
Custom Board
Power Supply used.
USB
What is the expected behavior?
when it call lp_core_i2c_master_write_to_device, it recive the data from i2c slave
What is the actual behavior?
it blocking in lp_core_i2c_wait_for_interrupt called in reading loop becasue of LP_I2C_TRANS_COMPLETE_INT_ST_M disabled
Steps to reproduce.
the LP_I2C_TRANS_COMPLETE_INT_ST_M interrupt will be detected, which cause LP_I2C_TRANS_COMPLETE_INT_ST_M disabled, the it will block to wait the trans completion when it reading. in the lp_core_i2c_master_write_to_device in lp_core_i2c.c, how to resolve the problem
Debug Logs.
No response
More Information.
No response

the LP_I2C_TRANS_COMPLETE_INT_ST_M interrupt will be detected after writting some bytes, which cause LP_I2C_TRANS_COMPLETE_INT disabled. Then lp will block to wait the trans completion when it reading. in the lp_core_i2c_master_write_to_device in lp_core_i2c.c, how to resolve the problem.

it can be resolved add a end cmd when sending last write cmd. without the end cmd, it finish the transformation early. it works, can u try it? @sudeep-mohanty, thanks

`
esp_err_t lp_core_i2c_master_write_read_device(i2c_port_t lp_i2c_num, uint16_t device_addr,
const uint8_t *data_wr, size_t write_size,
uint8_t *data_rd, size_t read_size,
int32_t ticks_to_wait)
{
(void)lp_i2c_num;
esp_err_t ret = ESP_OK;
uint32_t cmd_idx = 0;

if ((write_size == 0) || (read_size == 0)) {
    // Quietly return
    return ESP_OK;
} else if ((write_size > UINT8_MAX) || (read_size > UINT8_MAX)) {
    // HW register only has an 8-bit byte-num field
    return ESP_ERR_INVALID_SIZE;
}

/* If SCL is busy, reset the Master FSM */
if (i2c_ll_is_bus_busy(dev)) {
    i2c_ll_master_fsm_rst(dev);
}

/* Reset the Tx and Rx FIFOs */
i2c_ll_txfifo_rst(dev);
i2c_ll_rxfifo_rst(dev);

/* Enable trans complete interrupt and end detect interrupt for read/write operation */
uint32_t intr_mask = (1 << LP_I2C_TRANS_COMPLETE_INT_ST_S) | (1 << LP_I2C_END_DETECT_INT_ST_S);
if (s_ack_check_en) {
    /* Enable LP_I2C_NACK_INT to check for ACK errors */
    intr_mask |= (1 << LP_I2C_NACK_INT_ST_S);
}
i2c_ll_enable_intr_mask(dev, intr_mask);

/* Execute RSTART command to send the START bit */
lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_RESTART, 0, 0, 0, 0);

/* Write device addr and update the HW command register */
uint8_t addr_len = 0;
lp_core_i2c_config_device_addr(cmd_idx++, device_addr, LP_I2C_WRITE_MODE, &addr_len);

/* Write data */
uint32_t fifo_available = LP_I2C_FIFO_LEN - addr_len; // Initially, 1 or 2 fifo slots are taken by the device address
uint32_t fifo_size = 0;
uint32_t data_idx = 0;
int32_t remaining_bytes = write_size;

/* The data to be sent must occupy sequential slots of the Tx FIFO.
 * We must account for FIFO wraparound in case the length of data being sent is greater than LP_I2C_FIFO_LEN.
 */
while (remaining_bytes > 0) {
    /* Select the amount of data that fits in the Tx FIFO */
    fifo_size = MIN(remaining_bytes, fifo_available);

    /* Update the number of bytes remaining to be sent */
    remaining_bytes -= fifo_size;

    /* Write data to the Tx FIFO and update the HW command register. Expect ACKs from the device */
    i2c_ll_write_txfifo(dev, &data_wr[data_idx], fifo_size);
    lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_WRITE, 0, LP_I2C_ACK, s_ack_check_en, fifo_size);

    // if (remaining_bytes) {
        /* This means we have to send more than what can fit in the Tx FIFO. Insert an End command. */
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_END, 0, 0, 0, 0);
        cmd_idx = 0;
    // }

    /* Initiate I2C transfer */
    i2c_ll_update(dev);
    i2c_ll_trans_start(dev);

    /* Wait for the transfer to complete */
    ret = lp_core_i2c_wait_for_interrupt(intr_mask, ticks_to_wait);
    if (ret != ESP_OK) {
        /* Transaction error. Abort. */
        return ret;
    }

    /* Update data_idx */
    data_idx += fifo_size;

    /* We now have the full fifo available for writing */
    fifo_available = LP_I2C_FIFO_LEN;
}

/* Reset command index */
cmd_idx = 0;

/* Execute RSTART command again to send a START condition for the read operation */
lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_RESTART, 0, 0, 0, 0);

/* Write device addr again in read mode */
lp_core_i2c_config_device_addr(cmd_idx++, device_addr, LP_I2C_READ_MODE, &addr_len);

/* Read data */
fifo_size = 0;
data_idx = 0;
remaining_bytes = read_size;

/* The data is received in sequential slots of the Rx FIFO.
 * We must account for FIFO wraparound in case the length of data being received is greater than LP_I2C_FIFO_LEN.
 */
while (remaining_bytes > 0) {
    /* Select the amount of data that fits in the Rx FIFO */
    fifo_size = MIN(remaining_bytes, LP_I2C_FIFO_LEN);

    /* Update the number of bytes remaining to be read */
    remaining_bytes -= fifo_size;

    /* Update HW command register to read bytes */
    if (fifo_size == 1) {
        /* Read 1 byte and send NACK */
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_READ, LP_I2C_NACK, 0, 0, 1);

        /* STOP */
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_STOP, 0, 0, 0, 0);
    } else if ((fifo_size > 1) && (remaining_bytes == 0)) {
        /* This means it is the last transaction.
         * Read fifo_size - 1 bytes and send ACKs
         */
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_READ, LP_I2C_ACK, 0, 0, fifo_size - 1);

        /* Read last byte and send NACK */
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_READ, LP_I2C_NACK, 0, 0, 1);

        /* STOP */
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_STOP, 0, 0, 0, 0);
    } else {
        /* This means we have to read data more than what can fit in the Rx FIFO.
         * Read fifo_size bytes and send ACKs
         */
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_READ, LP_I2C_ACK, 0, 0, fifo_size);
        lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_END, 0, 0, 0, 0);
        cmd_idx = 0;
    }

    /* Initiate I2C transfer */
    i2c_ll_update(dev);
    i2c_ll_trans_start(dev);

    /* Wait for the transfer to complete */
    ret = lp_core_i2c_wait_for_interrupt(intr_mask, ticks_to_wait);
    if (ret != ESP_OK) {
        /* Transaction error. Abort. */
        return ret;
    }

    /* Read Rx FIFO */
    i2c_ll_read_rxfifo(dev, &data_rd[data_idx], fifo_size);

    /* Update data_idx */
    data_idx += fifo_size;
}

return ret;

}
`

Thanks for reporting the issue and a potential fix @DexiangYang. The changes seem fine as the END command should not alter the I2C protocol itself and should be fine to have it. However, before confirming the change, I would like test it more. May I ask if you have an easy way to reproduce this issue?

thank u for ur help, i try to connect esp32 c6 with sht30 or AT24C16. Neither can be accessed. u can try them. the  probability is 100%.

`#include <stdint.h>
#include <stdint.h>
#include <stdbool.h>
#include "ulp_lp_core.h"
#include "ulp_lp_core_print.h"
#include "ulp_lp_core_utils.h"
#include "ulp_lp_core_uart.h"
#include "ulp_lp_core_gpio.h"
#include "ulp_lp_core_i2c.h"
#include "hal/uart_hal.h"
#include "hal/i2c_hal.h"
#include "soc/pmu_reg.h"
#include "../bh1750_defs.h"
#define LP_I2C_TRANS_TIMEOUT_CYCLES 5000
#define LP_I2C_TRANS_WAIT_FOREVER   -1
#define LUX_THRESHOLD_LOW           5
#define LUX_THRESHOLD_HIGH          1000
static uint32_t sensor_on = 0;
static uint32_t res_update_done = 0;
volatile uint32_t lux = 0;
int main (void)
{
uint8_t data_wr = 0;
esp_err_t ret = ESP_OK;
uint8_t tx_buf[1 << 4];
uint8_t rx_buf[1 << 4];

int64_t temp;

lp_core_printf("Hello_world\n");

while (1) {
    tx_buf[0] = 0xF3;
    tx_buf[1] = 0x2D;
    // * (uint16_t *) tx_buf = 0xF3;
    lp_core_printf("tx_buf[0] : %02x\n", tx_buf[0]);
    lp_core_printf("tx_buf[1] : %02x\n", tx_buf[1]);
    if(ESP_OK != (ret = lp_core_i2c_master_write_read_device(LP_I2C_NUM_0, 0x44, tx_buf, 2, rx_buf, 6, 500 * 1000))) {
        lp_core_printf("i2c failed\n");
        lp_core_printf("ret : %d\n", ret);
        while(1);
    }
    for(int i = 0; i < 6; i += 1) {
        lp_core_printf("%x ", rx_buf[i]);
    }
    lp_core_printf("\n");
    ulp_lp_core_delay_us(100 * 1000);

}

return 0;

}
`

this is lp code, when lp connected with sht30.

`
    tx_buf[0] = 0xF3;
    tx_buf[1] = 0x2D;
    // * (uint16_t *) tx_buf = 0x0F32;
    // lp_core_printf("tx_buf[0] : %02x\n", tx_buf[0]);
    // lp_core_printf("tx_buf[1] : %02x\n", tx_buf[1]);
    if(ESP_OK != (ret = lp_core_i2c_master_write_read_device(LP_I2C_NUM_0, 0x50, tx_buf, 1, rx_buf, 3, 500 * 1000))) {
        lp_core_printf("i2c failed\n");
        lp_core_printf("ret : %d\n", ret);
        while(1);
    }
    for(int i = 0; i < 2; i += 1) {
        lp_core_printf("%x ", rx_buf[i]);
    }
    lp_core_printf("\n");
    ulp_lp_core_delay_us(100 * 1000);`

Hi @DexiangYang,
May I ask you to try the attached patch? It looks like the lp_core_i2c_master_write_read_device() did not send out a STOP command after the write operation and before starting the read operation.
lp_i2c_write_read.patch

Hi @DexiangYang, May I ask you to try the attached patch? It looks like the lp_core_i2c_master_write_read_device() did not send out a STOP command after the write operation and before starting the read operation.
lp_i2c_write_read.patch

thank u for ur help, while in my application, there is no stop between writing and reading according at24c16. the url is https://ww1.microchip.com/downloads/en/DeviceDoc/AT24C01C-AT24C02C-I2C-Compatible-Two-Wire-Serial-EEPROM-1Kbit-2Kbit-20006111A.pdf. so i add end instead of stop.


Release/1.2.1

Codecov Report

Merging #39 into develop will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #39      +/-   ##
===========================================
+ Coverage    92.88%   92.92%   +0.03%
===========================================
  Files            8        8
  Lines          436      438       +2
  Branches        64       65       +1
===========================================
+ Hits           405      407       +2
  Misses          14       14
  Partials        17       17

Impacted Files
Coverage Δ

anymotion_sdk/client.py
90.66% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421e2d9...fbb83fc. Read the comment docs.


Griefing in protected regions

Mod ignoring any protection. You are able to edit sculptures/paintings in spawn areas (vanilla) and WorldGuard/Towny/%any_protection_plugin% regions (Cauldron).

You'll need to use something like ForgeRestrictor while using Cauldron


[cluster-test] Update timeouts, print intermediate results

Summary

Define deadline for each experiment separately and enforce it using trait.
Update the timeout for ssh command because during network simulation events, it times out frequently
Set 24 hr deadline for multi-region-simulation experiment as it goes over a number of different topologies

@bors-libra r+

:pushpin: Commit 68dff2c has been approved by andll

:hourglass: Testing commit 68dff2c63dc008f43719b2ff49f9f03ed3e8aeb8 with merge 760fa412aab89c82c7979af0add2a601aa0b9305...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: andll
Pushing 760fa412aab89c82c7979af0add2a601aa0b9305 to master...


Update to django 2.0

See also https://docs.djangoproject.com/en/2.0/releases/2.0/
What needs to be done (may be incomplete):

before update

[X] python3 compatibility
[X] Make sure all ForeignKey fields have on_delete set
[X] import from django.urls instead of django.core.urlresolvers
[X] change MIDDLEWARE_CLASSES to MIDDELWARE
[X] replace django.template.loaders.eggs.Loader
[X] change user.is_authenticated() to user.is_authenticated

after update

[ ] change url definitions to use path()

I think @LizzAlice has already worked on adding on_delete, but I cannot find the branch anymore. Anyone knows where it went?

Have I? I can't remember creating a branch for that, maybe I changed one ore two of them while doing something else?

django 2.1 also brings the "view" permissions which can replace our own "read" permissions.


Images of the Threat Diagram are cropped in the Report

When I go to run the Report on a model (actually a group of models), the Diagrams are cropped so that the reader can't see the entire model.
I'm getting several red, brief, pop-up style warnings when running the Report.  They appear to be identical and state "Error: cannot read property 'cells' of undefined".
I'm using version 1.2, on a MacBook Air running 10.14.6

Hello @craig-Ayla - could you send me either the pdf output or the json file? I can have a look
Having said that I understand if you do not want to send your threat models around for everyone to have a look ... a bit of a reveal :-) But if you can repeat it with a generic model that would be great

I see the error "Error: cannot read property 'cells' of undefined" when I have a diagram with no elements in it, do you have any disgrams in your threat model that are empty?

No.  The diagrams all have elements (process, actor, store…).  There are 6 diagrams.
Some of the diagrams do not have Threats yet.
Craig
On Jul 13, 2020, at 10:09 PM, Jon Gadsden <notifications<EMAIL_ADDRESS>wrote:
I see the error "Error: cannot read property 'cells' of undefined" when I have a diagram with no elements in it, do you have any disgrams in your threat model that are empty?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mike-goodwin/owasp-threat-dragon-desktop/issues/146#issuecomment-657969752, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDUUEQBCSQCXVA2OV3YIUTR3PSBTANCNFSM4OY4I22Q.

Let me see if I can recast it so it’s more generic…  Probably be a day or two (sorry - can’t be helped).
Craig
On Jul 13, 2020, at 10:08 PM, Jon Gadsden <notifications<EMAIL_ADDRESS>wrote:
Hello @craig-Aylahttps://github.com/craig-Ayla - could you send me either the pdf output or the json file? I can have a look
Having said that I understand if you do not want to send your threat models around for everyone to have a look ... a bit of a reveal :-) But if you can repeat it with a generic model that would be great
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mike-goodwin/owasp-threat-dragon-desktop/issues/146#issuecomment-657969519, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDUUEVXCAKZ3B2J6A3G5SDR3PR6LANCNFSM4OY4I22Q.

OK, thanks @craig-Ayla - it may be platform dependent as well, so I can test your json/pdf on all three platform types when you are ready.
Not sure why you are getting the errors "Error: cannot read property 'cells' of undefined". Do you want to raise a bug issue for this at : https://github.com/OWASP/threat-dragon-core/issues
Thanks again, Jon

Hi Jon,
I’m terribly sorry - there were diagrams without any objects in them.  I’d forgotten I’d added them.
Also, I didn’t realize that the ends of the Data Flow arrows could be ‘attached’ to the Actor/Store, etc by dragging them into the center of the object.  Fixing that had the side-effect of fixing the diagram cropping issue.
What would you like me to do with the Issue on GitHub now?
Craig
On Jul 14, 2020, at 9:32 AM, Jon Gadsden <notifications<EMAIL_ADDRESS>wrote:
OK, thanks @craig-Aylahttps://github.com/craig-Ayla - it may be platform dependent as well, so I can test your json/pdf on all three platform types when you are ready.
Not sure why you are getting the errors "Error: cannot read property 'cells' of undefined". Do you want to raise a bug issue for this at : https://github.com/OWASP/threat-dragon-core/issues
Thanks again, Jon
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mike-goodwin/owasp-threat-dragon-desktop/issues/146#issuecomment-658282086, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDUUERH2U3E7W2JI4UOCRDR3SCADANCNFSM4OY4I22Q.

No problem at all @craig-Ayla , good to hear that the cropping issue is sorted and that the cause of the rrors are known. We need a FAQs really, because many users would have been in the same situation. Very good that you raised this issue, otherwise we never hear about these problems.
Do you mind if we keep this as a Documentation issue? We need to update the FAQs for this ... possibly on the project page at https://owasp.org/www-project-threat-dragon/

Feel free to keep everything I’ve sent.  And, thanks for providing the tool!
Craig
On Jul 14, 2020, at 12:41 PM, Jon Gadsden <notifications<EMAIL_ADDRESS>wrote:
No problem at all @craig-Aylahttps://github.com/craig-Ayla , good to hear that the cropping issue is sorted and that the cause of the rrors are known. We need a FAQs really, because many users would have been in the same situation. Very good that you raised this issue, otherwise we never hear about these problems.
Do you mind if we keep this as a Documentation issue? We need to update the FAQs for this ... possibly on the project page at https://owasp.org/www-project-threat-dragon/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mike-goodwin/owasp-threat-dragon-desktop/issues/146#issuecomment-658375011, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDUUESAL2POMVUZQE6JGFDR3SYE7ANCNFSM4OY4I22Q.

Hey, I do have one question (or possibly request).  I’m using the local version.   I open the model file, then select a diagram and work on it, and often I want to go to a different diagram.  It seems that I have to completely close the model, then reopen it, and then select the next diagram I want to work on.  I’m wondering if there’s a way that I can go from diagram to diagram without closing the model file and reopening it.  If there’s not, I think that would be a good usability enhancement.
Craig
On Jul 14, 2020, at 4:01 PM, Craig Payne <craig<EMAIL_ADDRESS>wrote:
Feel free to keep everything I’ve sent.  And, thanks for providing the tool!
Craig
On Jul 14, 2020, at 12:41 PM, Jon Gadsden <notifications<EMAIL_ADDRESS>wrote:
No problem at all @craig-Aylahttps://github.com/craig-Ayla , good to hear that the cropping issue is sorted and that the cause of the rrors are known. We need a FAQs really, because many users would have been in the same situation. Very good that you raised this issue, otherwise we never hear about these problems.
Do you mind if we keep this as a Documentation issue? We need to update the FAQs for this ... possibly on the project page at https://owasp.org/www-project-threat-dragon/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mike-goodwin/owasp-threat-dragon-desktop/issues/146#issuecomment-658375011, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDUUESAL2POMVUZQE6JGFDR3SYE7ANCNFSM4OY4I22Q.

Hello @craig-Ayla - there is a quicker way to swap between diagrams. Exit from the first diagram using the 'X' button (between the grid and the bin buttons) in the drawing pane. This takes you back to the project view, and then click on the next diagram thumbnail.
Again this is good feedback, and I will put it into the FAQs.
Cheers, Jon

Ah ha!  That works like a charm, though it’s not what I would have expected for a button that says ‘cancel’ when I hover over it.  Maybe ‘cancel pending edits and close diagram’?
Craig
On Jul 15, 2020, at 12:28 PM, Jon Gadsden <notifications<EMAIL_ADDRESS>wrote:
Hello @craig-Aylahttps://github.com/craig-Ayla - there is a quicker way to swap between diagrams. Exit from the first diagram using the 'X' button (between the grid and the bin buttons) in the drawing pane. This takes you back to the project view, and then click on the next diagram thumbnail.
Again this is good feedback, and I will put it into the FAQs.
Cheers, Jon
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mike-goodwin/owasp-threat-dragon-desktop/issues/146#issuecomment-658961583, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDUUER5JPMZXLLMZ53L62LR3X7NVANCNFSM4OY4I22Q.

That is a very good point - it is misleading. I have changed it to 'Close Diagram' in commit:
https://github.com/OWASP/threat-dragon-core/commit/51263f85d98b26dee7f445ccc23ca64934fa1a74
which should appear in version 1.3 due in August

Thank you!
Craig
On Jul 16, 2020, at 1:54 AM, Jon Gadsden <notifications<EMAIL_ADDRESS>wrote:
That is a very good point - it is misleading. I have changed it to 'Close Diagram' in commit:
OWASP/threat-dragon-core@51263f8https://github.com/OWASP/threat-dragon-core/commit/51263f85d98b26dee7f445ccc23ca64934fa1a74
which should appear in version 1.3 due in August
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mike-goodwin/owasp-threat-dragon-desktop/issues/146#issuecomment-659261794, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDUUEQTVVLAFGXUOXXILRTR3253RANCNFSM4OY4I22Q.


Improve the font under "Change / Add Wallet"

https://zpl.io/VY7JKYk
https://zpl.io/2pqPx1y

SourceSansPro Regular 12, Dove #727272

Still exists.

We need to apply the same to more Settings screen

Change Language
Change Currency
Select Currency screen

It was marked as closed but I haven't seen this updated in the design. @seabornlee  Can you take a look, please?

@colourfreak Sure.


Remove _levelsInvariant

Converted this PR to draft because it might not be necessary to merge

I'm going to close this PR for now -- I don't think it will be necessary to remove _levelsInvariant


SimpleNotificationService Andorid: GCM NOT WORKING

SimpleNotificationService is working on IOS, but not on Android.
I am not sure if GCM is depreciated, and if it will even work at all. SEE HERE FOR MORE INFO
Expected Behavior
The SimpleNotificationService does connect to platform application endpoints, when trying to connect on Android
Current Behavior
It returns null. When trying the sample project: regId returns null.
The call is  GCM.Register((regId)
Steps to Reproduce (for bugs)
Install the Unity SDK on unity 2017.
Import the SimpleNotificationService follow all the steps As  shown here
NOTE:
When trying to create a platform application on AWS, there is no option for "Google Cloud Service (GCM)". There is a way to get an api key from creating a "Firebase account" that I cant get it working.
You can create the key with firebase, and putting it in the aws Platform application. But the android app cannot reach the endpoint.
Context
Cannot sen Push Notifications to android devices.
Your Environment
AWSSDK.Core
AWSSDK.CognitoIdentity
AWSSDK.SecurityToken
AWSSDK.SimpleNotificationService

Operating System and version: Mac
Visual Studio version: 2019 Unity: 2017
Targeted .NET platform: Net 4.6

.NET Core Info
Net 4.6
Sample Code
//
// Copyright 2014-2015 Amazon.com,
// Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the AWS Mobile SDK For Unity
// Sample Application License Agreement (the "License").
// You may not use this file except in compliance with the
// License. A copy of the License is located
// in the "license" file accompanying this file. This file is
// distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
// CONDITIONS OF ANY KIND, express or implied. See the License
// for the specific language governing permissions and
// limitations under the License.
//
using UnityEngine;
using System.Collections;
using Amazon.SimpleNotificationService;
using Amazon.Runtime;
using Amazon.CognitoIdentity;
using Amazon;
using UnityEngine.UI;
using Amazon.SimpleNotificationService.Model;
namespace AWSSDK.Examples
{
public class SNSExample : MonoBehaviour
{
//identity pool id for cognito credentials
public string IdentityPoolId = "";
    //sns android platform arn
    public string AndroidPlatformApplicationArn = "";

    //sns ios platform arn
    public string iOSPlatformApplicationArn = "";

    //project id for android gcm
    public string GoogleConsoleProjectId = "";

    public string CognitoIdentityRegion = RegionEndpoint.USEast1.SystemName;

    private RegionEndpoint _CognitoIdentityRegion
    {
        get { return RegionEndpoint.GetBySystemName(CognitoIdentityRegion); }
    }

    public string SNSRegion = RegionEndpoint.USEast1.SystemName;

    private RegionEndpoint _SNSRegion
    {
        get { return RegionEndpoint.GetBySystemName(SNSRegion); }
    }

    public Button RegisterButton;
    public Button UnregisterButton;

    public Text ResultText;

    private string _endpointArn;

    // Use this for initialization
    void Start()
    {
        UnityInitializer.AttachToGameObject(this.gameObject);
        RegisterButton.onClick.AddListener(RegisterDevice);
        UnregisterButton.onClick.AddListener(UnregisterDevice);
    }

    private AWSCredentials _credentials;

    private AWSCredentials Credentials
    {
        get
        {
            if (_credentials == null)
                _credentials = new CognitoAWSCredentials(IdentityPoolId, _CognitoIdentityRegion);
            return _credentials;
        }
    }

    private IAmazonSimpleNotificationService _snsClient;

    private IAmazonSimpleNotificationService SnsClient
    {
        get
        {
            if (_snsClient == null)
                _snsClient = new AmazonSimpleNotificationServiceClient(Credentials, _SNSRegion);
            return _snsClient;
        }
    }

    private void RegisterDevice()
    {

#if UNITY_ANDROID
ResultText.text += string.Format("Hey you started..." + _credentials.ToString());
if (string.IsNullOrEmpty(GoogleConsoleProjectId))
{
Debug.Log("sender id is null");
ResultText.text += string.Format("sender id is null");
return;
}
GCM.Register((regId) =>
{
//ResultText.text += string.Format("regId: " + regId);
if (string.IsNullOrEmpty(regId))
{
ResultText.text = string.Format(" Failed to get the registration id");
return;
}
            ResultText.text = string.Format(@"Your registration Id is = {0}", regId);

            SnsClient.CreatePlatformEndpointAsync(
                new CreatePlatformEndpointRequest
                {
                    Token = regId,
                    PlatformApplicationArn = AndroidPlatformApplicationArn
                },
                (resultObject) =>
                {
                    if(resultObject.Exception==null)
                    {
                        CreatePlatformEndpointResponse response = resultObject.Response;
                        _endpointArn = response.EndpointArn;
                        ResultText.text += string.Format(@"Platform endpoint arn is = {0}", response.EndpointArn);
                    }
                }
            );
        }, GoogleConsoleProjectId);

#elif UNITY_IOS
#if UNITY_5
//#if UNITY_5_3_OR_NEWER
UnityEngine.iOS.NotificationServices.RegisterForNotifications(UnityEngine.iOS.NotificationType.Alert | UnityEngine.iOS.NotificationType.Badge | UnityEngine.iOS.NotificationType.Sound);
#else
NotificationServices.RegisterForRemoteNotificationTypes(RemoteNotificationType.Alert|RemoteNotificationType.Badge|RemoteNotificationType.Sound);
#endif
CancelInvoke("CheckForDeviceToken");
InvokeRepeating("CheckForDeviceToken",1f,1f);
#endif
}
string deviceToken = null;
//to keep a track of max number of times the device token is polled
int count = 0;
private void CheckForDeviceToken()
{
#if UNITY_IOS
//#if UNITY_5
#if UNITY_5_3_OR_NEWER
var token = UnityEngine.iOS.NotificationServices.deviceToken;
var error = UnityEngine.iOS.NotificationServices.registrationError;
#else
var token = NotificationServices.deviceToken;
var error = NotificationServices.registrationError;
#endif
if(count>=10 || !string.IsNullOrEmpty(error))
{
CancelInvoke("CheckForDeviceToken");
Debug.Log(@"Cancel polling");
return;
}
        if(token!=null)
        {
            deviceToken = System.BitConverter.ToString(token).Replace("-","");
            Debug.Log("device token  = " + deviceToken);
            ResultText.text = string.Format(@"Your device token is = {0}", deviceToken);
            SnsClient.CreatePlatformEndpointAsync(
                new CreatePlatformEndpointRequest
                {
                    Token = deviceToken,
                    PlatformApplicationArn = iOSPlatformApplicationArn
                },
                (resultObject) =>
                {
                    if(resultObject.Exception==null)
                    {
                        CreatePlatformEndpointResponse response = resultObject.Response;
                        _endpointArn = response.EndpointArn;
                        ResultText.text += string.Format("\n Subscribed to Platform endpoint arn = {0}", response.EndpointArn);
                    }
                }
            );

            CancelInvoke("CheckForDeviceToken");
        }
        count++;

#endif
}
    private void UnregisterDevice()
    {
        if(!string.IsNullOrEmpty(_endpointArn))
        {
            SnsClient.DeleteEndpointAsync(
                new DeleteEndpointRequest
                {
                    EndpointArn = _endpointArn
                },
                (resultObject)=>{
                    if(resultObject.Exception == null)
                    {
                        Debug.Log("Deleted the endpoint. You will not get any new notifications");
                        ResultText.text = @"You will not get any new notifications";
                    }
                }
            );
        }
    }

}

}

Hi @abiehusney25, support for the AWS SDK for Unity has been deprecated.  To continue using Unity with AWS, please follow the instructions in this blog post about the deprecation.  By utilizing the new method, you will also gain access to all AWS services in your Unity projects and improved async.

@klaytaybai
Thank you for the response.
I have been trying to integrate the new  .NET Standard 2.0 but cannot get the c# code to run.
This is for unity:
What I am trying to do is just create an endpoint on aws sns:
First what I need is the android and IOS deviceToken. I cannot get the tokens
Then I run
SnsClient.CreatePlatformEndpointAsync(
new CreatePlatformEndpointRequest
{
Token = deviceToken,
PlatformApplicationArn = iOSPlatformApplicationArn/AndroidPlatformApplicationArn
},
I cannot get code that runs this for the new dlls, and I cannot find a walk-through on how to create endpoints on android and IOS
Do you have a sample Unity project I could import and try out...


Errors with mysql cookbook 6.0.0+

I'm finding that when I try to run the wordpress recipe, I immediately get the error:
ERROR: could not find recipe client for cookbook mysql

I think this may be due to the changes in the 6.0.0 version of the mysql cookbook, "Cookbook now provides LWRPs instead of recipes"—it looks like, e.g. include_recipe "mysql::client" now won't work.
(Trying with wordpress-2.3.0 and mysql-6.0.6)
Any hints? I only started using chef a few days ago, so this is a little above my head!

gothick: I'm working on an update to this today as I'm running into it for the first time. You could, as a workaround, either manually download or use the Berksfile to pin the mysql cookbook to an older version of their cookbook as a workaround

I've run into a lot of problems converting this and don't know if/when I'll have something to commit. I've gotten it updated to the point that it builds and the passwords seem to work, but I get a chef runtime error complaining about the versions of mysql client compiled vs what's installed. Since this is all coming from package that's not really something I can control. It might be possible to ignore the error but I haven't nailed that down.

Hello,
I managed to make it run by downgrading the mysql version in the metadata.rb and metadata.json:
depends "mysql", "~> 5.0"
depends "mysql-chef_gem", "~> 0.0"

Thanks for the updates! I've stepped away from the WordPress installation briefly (got distracted by writing a phpBB extension!) so I can't test this right now, but I'm sure that would be the way to go for a workaround.

Maybe there should be a constraint on the mysql dependency in metadata.rb in the meanwhile

I tried to implement the change that @lpbedard posted, but I get the following error message
================================================================================
           Error executing action `create` on resource 'mysql_service[default]'
           ================================================================================

           ArgumentError
           -------------
           You must supply a name when declaring a package resource

           Cookbook Trace:
           ---------------
           /tmp/kitchen/cookbooks/mysql/libraries/provider_mysql_service_ubuntu.rb:55:in `block in <class:Ubuntu>'

           Resource Declaration:
           ---------------------
       # In /tmp/kitchen/cookbooks/mysql/recipes/server.rb

            20: mysql_service node['mysql']['service_name'] do
            21:   version node['mysql']['version']
            22:   port node['mysql']['port']
            23:   data_dir node['mysql']['data_dir']
            24:   server_root_password node['mysql']['server_root_password']
            25:   server_debian_password node['mysql']['server_debian_password']
            26:   server_repl_password node['mysql']['server_repl_password']
        27:   allow_remote_root node['mysql']['allow_remote_root']
            28:   remove_anonymous_users node['mysql']['remove_anonymous_users']
            29:   remove_test_database node['mysql']['remove_test_database']
            30:   root_network_acl node['mysql']['root_network_acl']
            31:   package_version node['mysql']['server_package_version']
        32:   package_action node['mysql']['server_package_action']
            33:   enable_utf8 node['mysql']['enable_utf8']
            34:   action :create
            35: end

           Compiled Resource:
           ------------------
           # Declared in /tmp/kitchen/cookbooks/mysql/recipes/server.rb:20:in `from_file'

           mysql_service("default") do
             action [:create]

             retry_delay 2
             default_guard_interpreter :default
             declared_type :mysql_service
             cookbook_name :mysql
             recipe_name "server"
             version "5.7"

             data_dir "/var/lib/mysql"
             server_root_password "ilikerandompasswords"
             server_debian_password "gnuslashlinux4ev4r"
             remove_anonymous_users true
             remove_test_database true
             package_action "install"
           end

       Running handlers:
       [2015-02-03T00:18:10+00:00] ERROR: Running exception handlers
       Running handlers complete

       [2015-02-03T00:18:10+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out
       Chef Client failed. 1 resources updated in 18.799817601 seconds
       [2015-02-03T00:18:11+00:00] ERROR: mysql_service[default] (mysql::server line 20) had an error: ArgumentError: You must supply a name when declaring a package resource
       [2015-02-03T00:18:11+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

I first made it run using a wrapper cookbook, so I just tried with the kitchen gem.
I just installed the latest chef-dk from opscode (https://downloads.chef.io/chef-dk/)
$ git clone https://github.com/brint/wordpress-cookbook
$ cd wordpress-cookbook
$ vim metadata.rb
Change the 3 dependencies in metadata.rb:
# depends "database", ">= 1.6.0"
# depends "mysql", ">= 5.0.0"
# depends "mysql-chef_gem", ">= 0.0.2"
depends "database", "= 2.3.1"
depends "mysql", "~> 5.0"
depends "mysql-chef_gem", "~> 0.0"
$ berks
$ kitchen converge default-ubuntu-1204
I guess that if you first tried without modifying the dependencies and it failed, you will have to run berks update to resolved the new one before trying again.
Maybe destroy your instance before running kitchen again... or start from fresh git clone like I did.

Refreshed everything and it worked perfectly. Thank you for your detailed response. It helped a lot :).

Hey everyone,
I've pushed out v3.0.0 that now supports 6.0+ of the MySQL community cookbook. I'm going to go ahead and close out this issue since the new release does properly support it now.


Flyway doesn't allow to apply SQL Server 2016 in-memory objects

Which version and edition of Flyway are you using?
Flyway Community Edition 5.1.3
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Command-line
Which database are you using (type & version)?
SQL Server 2016
Which operating system are you using?
Windows 10, Windows Server
What did you do?
I'm trying to create script for SQL Server 2016 in-memory object
USE [MyOwnSchema];
CREATE TYPE dbo.someType
AS TABLE
([Id]  BIGINT   NOT NULL INDEX IX_udt_someType_Id  NONCLUSTERED
,[Value]   NVARCHAR(500) NOT NULL
,[Type]    BIGINT   NOT NULL
)
WITH ( MEMORY_OPTIMIZED = ON );
What did you expect to see?
Successful migration
What did you see instead?
Migrating schema [dbo] to version 1.10031 - create udtt someName
WARNING: DB: Changed database context to 'MyOwnSchema'. (SQL State: S0001 - Error Code: 5701)
ERROR: Migration of schema [dbo] to version 1.10031 - create udtt someName failed! Changes successfully rolled back.
ERROR:
Migration V1_10031__create_udtt_someName.sql failed
SQL State  : S000110
Error Code : 12331
Message    : DDL statements ALTER, DROP and CREATE inside user transactions are not supported with memory optimized tables.

Thanks for reporting. This is actually trickier than it seems. While the create type as table and create table operations with memory_optimized=on are easy to detect, the alter and drop are not. This means that if we add autodetection for create, that still won't solve the issue for alter and drop. Supporting them would either require deeper introspection of the current DB state or the ability to override the autodetection (default) for the transaction support and allow to force it to be either on or off for a specific migration.
Either way this will need additional work to support properly. Delaying to 6.0 for now.

Thanks for answer, we will wait till 6.0 release

Is there a workaround for this? ie: flag a specific migration not to be executed in a transaction?

Wonder if at least support for non-transactional CREATE/DROP TYPE can be added to https://github.com/flyway/flyway/blob/0c89fc00f8413a8123552391be8554d2940eb9e9/flyway-core/src/main/java/org/flywaydb/core/internal/database/sqlserver/SQLServerParser.java in time for the 6.0 release.

Workaround can be to force specific migration script into non-transactional mode, using supported non-transactional statements aka fulltext index creation+drop.
For example:
create unique index  on ();
create fulltext catalog  as default; --if you don't have it
create fulltext index () key index  with stoplist = system;
drop fulltext index on ;
drop fulltext catalog ;
drop index .;

6.1.0 will include the ability to force specific scripts into non-transactional mode.


Feedback for “Presentations”

when i call at on presentationgpt. I am getting error "Something went wrong". How can i resolve that error

https://github.com/shuding/nextra/issues/3072#issuecomment-2254345423

You closed this issue without commenting or giving a solution and instead added a comment from someone else's question and not ours

@dimaMachina could you please answer our request of why we are getting the following error
getting error "something went wrong"

Your issue is unrelated to Nextra library, in attached comment there is explanation why

this is the help that we see for presentationsgpt? is this the wrong channel

This is wrong channel

what is the right channel because this is the channel they give on their website

I don’t know and can’t help you

maybe you should tell presentationsgpt to not have this link for support on their site. it would help all of us

You can tell them


Proposal: Managed menu visibility

This proposal adds two new props, onMenuVisibilityChange: func and open: bool. The former is invoked every time state.isOpen changes, and receives said value as its only argument. The latter - when present - overrides state.isOpen by putting the component into "managed menu visibility mode" (which is just a fancy way of saying props.open takes precedence over state.isOpen).
I created a new example (examples/managed-menu-visibility) to demonstrate the flexibility these additions offer.
This covers the request made in #129.
I personally need this feature to be able to use Autocomplete in a situation where I want to force the user to pick an option from the menu. Having the menu close when the input is blurred is needless to say not ideal ;)
@sprjr I'd like your input before merging.

This looks good from the description of the design, and I agree being able to manage something is quite nice. For exposing the internal state, we'd talked about doing that for perhaps a few props - is that satisfied by this for now as its really the only state we want to peer at?
I'll check the code out here shortly when not en route to work.
Sent from my iPhone

On Aug 31, 2016, at 4:51 AM, Christian Maughan Tegnér<EMAIL_ADDRESS>wrote:
This proposal adds two new props, onMenuVisibilityChange: func and open: bool. The former is invoked every time state.isOpen changes, and receives said value as its only argument. The latter - when present - overrides state.isOpen by putting the component into "managed menu visibility mode" (which is just a fancy way of saying props.open takes precedence over state.isOpen).
I created a new example (examples/managed-menu-visibility) to demonstrate the flexibility these additions offer.
This covers the request made in #129.
I personally need this feature to be able to use Autocomplete in a situation where I want to force the user to pick an option from the menu. Having the menu close when the input is blurred is needless to say not ideal ;)
@sprjr I'd like your input before merging.
You can view, comment on, or merge this pull request online at:
https://github.com/reactjs/react-autocomplete/pull/163
Commit Summary
Add props.onMenuVisiblityChange to be notified about changes to state.isOpen
Added props.open to allow overriding state.isOpen
Managed Menu Visiblity example
File Changes
M examples/index.html (1)
A examples/managed-menu-visibility/app.css (21)
A examples/managed-menu-visibility/app.js (82)
A examples/managed-menu-visibility/index.html (9)
M lib/Autocomplete.js (8)
M lib/tests/Autocomplete-test.js (26)
Patch Links:
https://github.com/reactjs/react-autocomplete/pull/163.patch
https://github.com/reactjs/react-autocomplete/pull/163.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@sprjr good to have you back! How was react rally?
I decided to isolate the one internal attribute that was needed for this issue (isOpen) instead of having to come up with a clever solution for surfacing all internal state. I'm not sure how much more state we would want to make public, apart from perhaps highlightedIndex (which you already have access to in renderItem).
My thinking was that we could add this, then deprecate it if/when we decide on a more generic approach.

React Rally was great! A lot of really great talks, and an overall really great community / event. The implementation of this looks simple & clean enough to me - and covers the necessary use cases.
🚢  :shipit:!

Published in 1.3.0. I had to follow up with 1.3.1 because for some reason npm pack included both node_modules and coverage, even though they're listed in .gitignore. Think I'll add files to package.json so this doesn't happen again.


Update README.md

Description of Change(s):

To help get PR's merged faster, the following is required:
[] Updated the documentation
[] Unit/Cypress test covering all cases
Please link to relevant Google Docs or schema.org docs for what you are adding so we can review.
Please have a read of the Contributing Guide for full details.
https://github.com/garmeeh/next-seo/blob/master/CONTRIBUTING.md

@CodiumAI-Agent /review

@codium


Fix Issue #18491 pass default values as parameter not template parameters in Logger

https://issues.dlang.org/show_bug.cgi?id=18491

The style checker fails to consider default arguments in ddoc parameter counting. I rechecked by hand and all passable parameters have ddoc comments.

The style checker fails to consider default arguments in ddoc parameter counting. I rechecked by hand and all passable parameters have ddoc comments.

It's not even the style checker per se, but Ddoc.
Check that Ddoc runs without errors
../dmd/generated/linux/debug/64/dmd -conf= -I../druntime/import  -w -de -dip25 -m64 -fPIC -transition=complex -g -debug -defaultlib= -debuglib= generated/linux/debug/64/libphobos2.a -w -D -Df/dev/null -main -c -o- $(find etc std -type f -name '*.d') 2>&1

I think Ddoc expects documentation for parameters like int line = __LINE__.
See https://run.dlang.io/is/cW31iD

Not good. I have not the time nor the knowledge to fix ddoc to get this PR passing.

@burner All you have to do is add all of the parameters to the Params section.

Jenkins has a build failure for libasync because libasync has its own logging functions that are just nothrow wrappers for std.experimental.logging and call logImpl with explicit __LINE__, etc. template parameters.

@n8sh thanks

@JackStouffer @wilzbach ping

What's the way forward on this? To move the current std.experimental.logger to stdx.experimental.logger (like with allocators) and submit a PR to libasync to use that?

@n8sh sound like a plan.

@n8sh @ZombineDev I do not follow. Please elaborate.

@burner Example of what I was talking about: https://github.com/atilaneves/automem/pull/20
PRs like that were made for several/many? projects that had been using std.experimental.allocator.

Ok, so we are moving stuff to code.dlang.org and give a version number. So people who don't want to rewrite and link against that!? And after that we change upstream?

@burner yes, this is so they can upgrade to a newer version of stdx and the compiler independently. Very often people use dmd, dmd-beta and even dmd-nightly for CI testing, which makes breaking changes (for which a deprecation period can't be reasonably enforced) especially painful.

PR closed as stalled. If you wish to resurrect it you are welcome to do so. We can revisit this in Phobos 3.


FlowDirection not working

if we have a resource
somekey.FlowDirection | RightToLeft
and we set in Grid or any Element:
<Grid x:Localizer.Uid="somekey"
flow direction is not working but if we use x:Uid flow direction working fine.

It doesn't work because the current version doesn't support enums.
This is one of the features I wanted to implement someday but I guess I can bring it up in the next version.

Closed by #22.


Tasks should not run with root privileges

In the Tekton tasks, bundle-all.yaml has 7 instances and container-all.yaml hs 5 instances of
securityContext:   runAsUser: 0
Running containers with root privilege is arguably bad practice and should be removed or justified.

https://github.com/okd-project/okd-operator-pipeline/pull/7


CFE-676: Feature/decouple cert manager operator as a clusteroperator

Description
Decouples cert-manager-operator from registering as a clusteroperator. After this change the operator will not show up in the list of ClusterOperators on the console.
Verified on cluster by installing bundle.

Wait for rebase post #83 being merged.

/lgtm

/cc @xingxingxia

/label docs-approved
Since this PR does not affect docs.

/cc @davemulford
This fixes UI/UX issue https://issues.redhat.com/browse/CM-35.

/label px-approved

/label qe-approved

Fixes CM-35


handles undefined on update() result.changes

It was throwing an error when an update was submitted via external API but no changes were present.

@alvin looks pretty good any chance you can add a test case for this? Either @daffl or @marshallswain should sign off as I am less familiar with this adapter.

Sure -- I reviewed index.test.js and couldn't determine a clear opportunity
to integrate the case -- unable to determine if it's just my naivety or if
these existing tests just don't dig to this level of granularity (i.e.
checking the return values from the update function).
On Sat, Apr 23, 2016 at 1:11 PM, Eric Kryski<EMAIL_ADDRESS>wrote:

@alvin https://github.com/alvin looks pretty good any chance you can
add a test case for this? Either @daffl https://github.com/daffl or
@marshallswain https://github.com/marshallswain should sign off as I am
less familiar with this adapter.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/feathersjs/feathers-rethinkdb/pull/18#issuecomment-213822336

Ah ok, this looks better now. I was wondering what the match code was for. This change makes sense. Would a test be similar to https://github.com/feathersjs/feathers-rethinkdb/blob/master/test/index.test.js#L141 but sending an empty object as the update? Do you maybe have a query that broke before?

The scenario that broke was when the object submitted to update() was
identical to the existing object (i.e. a "useless" update).  In that case,
result.changes[0].new_val (from existing master line 214) throws an error
because changes[0] is undefined.
On Sat, Apr 23, 2016 at 4:32 PM, David Luecke<EMAIL_ADDRESS>wrote:

Ah ok, this looks better now. I was wondering what the match code was
for. This change makes sense. Would a test be similar to
https://github.com/feathersjs/feathers-rethinkdb/blob/master/test/index.test.js#L141
but sending an empty object as the update? Do you maybe have a query that
broke before?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/feathersjs/feathers-rethinkdb/pull/18#issuecomment-213852850

I'm planning on doing some maintenance on this adapter some time this week and will merge this PR as well. Didn't forget about it.

Sounds good, @daffl -- I've noticed a similar issue on the create return value.  My use-case for create ships ID's with the payload.  In this case res.generated_keys seems to return undefined.  My work-around is as follows:
  create(data) {
    return this.table.insert(data).run()
      .then(res => Object.assign({
        id: (data.id ? data.id : res.generated_keys[0])
      }, data));
  }


Migrate to gpt 4o mini

Tested for LL rare words:
Average gpt-3.5-turbo times: 0.7661092758178711
Average gpt-4o times: 0.7191376924514771
Average gpt-4o-mini times: 0.8695436477661133
Average Groq times: 3.880943703651428
I'm sure mini is better if you have more in/out tokens. But latency, doesn't seem better. Ran twice, 4o won both times.


doc: basic-concept: fix small typo in source code

Codecov Report

Merging #23 (f65436f) into master (7eb05e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   32.23%   32.23%
=======================================
  Files          65       65
  Lines        4237     4237
=======================================
  Hits         1366     1366
  Misses       2871     2871

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb05e2...f65436f. Read the comment docs.

Great! Thanks for contributing :)


DOCS-4956 Exchange doc versioning fix per Slack #docs-feedback

Plus moved Version documenting section to end as it appeared to be in the wrong place

@george-hoffer and @dhirsch1 thank you very much!


Connection via localhost refused

I have your docker image running on my swarm setup with the following config:
version: "3.8"

services:
  smtp:
    image: boky/postfix
    ports:
      - 587:587
    networks:
      - relay
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - /etc/timezone:/etc/timezone:ro
    environment:
      - HOSTNAME=myhostname
      - RELAYHOST=myrelay
      - ALLOWED_SENDER_DOMAINS=mydomain

networks:
  relay:
    external: true

When I try sending a test email from it using s-nail on Debian 10 it fails with this error message:
s-nail: SMTP: Resource temporarily unavailable
s-nail: Unexpected EOF on SMTP connection
When using s-nail to send directly to my SMTP host it works as expected, it appears it's receiving an unexpected output from the docker SMTP server, any ideas?
Thank you

Managed to fix this, I had to ensure I was sending via the hostname specified in the environment variable rather than localhost


Optional renaming of the split field in History

This is a new feature requested by Arlindo, to allow using the alias feature in History to rename split fields, for example, by wavelengths

@atrayano Did your fix above get into the code?

I did. But this is not integrated into develop yet (see my last comment for #673)

Reexamined on 2021-Apr-12 with @bena-nasa and @tclune
@atrayano @gmao-esherman Is this now fixed as far as you can tell?

Yes, this feature is working for me.

If it works for @gmao-esherman, I think we can close this. Open new issues as new issues emerge.


Add a "Additional Resources" section to each User Guide page

The to do here is to add an "Additional Resources" section to each User Guide page that doesn't already have one. "Additional Resources" is an h2 section that contains three to five bullet points with links out to other closely related pages. These pages could be SendGrid blogs or docs pages with information about next steps, use cases, or other things a user should consider when they are completing the task on the page.
Here is an example "Additional Resources" section: https://sendgrid.com/docs/User_Guide/Marketing_Campaigns/design_editor.html#-Additional-Resources
Here is example formatting:
{% anchor h2 %}
Additional Resources
{% endanchor h2 %}

- [link text]({{root_url}}/User_Guide/Marketing_Campaigns/design_editor.html#-Using-Custom-HTML)(https://sendgrid.com/docs/User_Guide/Marketing_Campaigns/campaign_stats.html)
- [link text]({{root_url}}/User_Guide/Marketing_Campaigns/design_editor.html#-Using-Custom-HTML)(https://sendgrid.com/docs/User_Guide/Marketing_Campaigns/campaign_stats.html)
- [link text]({{root_url}}/User_Guide/Marketing_Campaigns/design_editor.html#-Using-Custom-HTML)(https://sendgrid.com/docs/User_Guide/Marketing_Campaigns/campaign_stats.html)

I would like to try out this issue! Could I be assigned to this issue?

@Aonepathan go for it! Thanks so much!

Are you working on this? May I help you? @Aonepathan

@thepriefy Sure! A lot of the User Guides don't have Additional Resources, so it's been taking a little longer than I thought to link to corresponding guides. I started from the top of User Guides, you can start from the bottom up if you want or pick whichever, I've done the Email Activity, About the User Guide, and finishing up SendGrid for Mobile

So I'll update what I've done here too. :) @Aonepathan

What I've done so far

Transactional Email
Transactional Templates

I'll continue the rest tomorrow. :) @Aonepathan

@Aonepathan and @thepriefy thanks so much for all the work you have done on this so far!

Thanks @thepriefy , I'll add what I've done so far as well

@Aonepathan and @thepriefy, just so you know, one of my merges changed a page that you had already added this content to -- so I circled back and made sure your additions got added to the updated page.  :)

Oh... and if you guys need any additional help on this one, let me know.  :)

oh, thanks so much. :) @triphius

Thanks @triphius , feel free to help out! There are a lot of pages that still need Additional Resources added, call dibs if you can so we can avoid conflicts!

@thepriefy @Aonepathan Okay, I'll call dibs on the Settings section.  :)

@thepriefy @triphius Just added Statistics

I haven't gotten that many pages fixed up so far, but there were some other fixes that needed to be done on these pages:
User Guide > Settings > Billing
User Guide > Settings > Subusers > Subusers Overview
User Guide > Settings > Subusers > Impersonation
User Guide > Settings > Subusers > Profile
User Guide > Settings > Subusers > Settings
On the above pages, the Additional Resources content has been added, but I've also fixed some formatting and content issues.  I also converted index.html to index.md (still renders as index.html) and converted native html to markdown.

@triphius Thank you!
Just added Legacy Newletter
We're almost there @thepriefy @triphius!
What should be left: Marketing Campaigns, Suppressions and remaining of Settings

@ksigler7 Thank you for the awesome Hacktoberfest event and handling all my PR's, it was really a lot of fun! I was curious if I could still submit to truly finish this issue, I know there are some pages missing Additional Resources and could add it to them. I just wasn't sure this was exclusive to only Hacktoberfest as a event.  And I'm sorry it took so long trying to finish this issue!

@Aonepathan - it would be amazing if you were to finish this out! I don't think any of us realized quite how much effort this was going to take, and we really really appreciate everything you have put into this and everything else you've worked on for us!
We are open source all year around, so if you ever notice anything else that needs updated in our docs, or any issues that you're interested in working on, please feel free to open a pull request :)

Hello Guys I need one help

@vikash1903 Hi! How can I help you?

Since we've moved to our new Knowledge Center, this issue has been taken care of.


v1.14 Backports 2024-08-02

[ ] #33769 (@pchaigno)
[x] #33666 (@bimmlerd) :warning: resolved conflicts
[ ] #33908 (@giorio94) :warning: resolved conflicts
[ ] #34004 (@tommyp1ckles) :warning: resolved conflicts
[ ] #34044 (@Huweicai) :warning: resolved conflicts

PRs skipped due to conflicts:

#34091 (@giorio94)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 33769 33666 33908 34004 34044

/test-backport-1.14

I reviewed https://github.com/cilium/cilium/pull/33769.

Remaining reviewers are out, but changes are not complicated and CI is green. Merging.


Bug: Splitting UI Dark Mode Issues

There are some light-theme elements in this, seems wrong?
Browser: Firefox
OS: Windows

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog :^)

This indeed looks a bit wrong, thanks for reporting the bug. I've opened a PR that improves the looks of this modal in dark mode. :)


Spec: usage info

Add copy to make clear how to use the Dialog component. In the body: "Make clear what changes are going to be made when performing this action."

https://github.com/teamleadercrm/teamleader-ui/pull/69


Collect maximum values for objects in one file?

For the most part, the maximum allowed number of an object is defined in Kernel.cuh. However, these numbers are also defined separately in other files, e.g. EventForAnalysisInterface.cc or write_sdl_ntuple.cc.
The situation is a bit more complicated when it comes to N_MAX_SEGMENTS_PER_MODULE. Except for multiple definitions of the variable, the raw number is also used, e.g. here and here.
Would it make sense to put all of these variables in one file, which would then be included in the relevant files, and to replace all the raw numbers with the appropriate variables?

There is a file called constants.h that should be able to have all of these values and pass them to all files (since it isn't a cuda header file). I think that is the place to move all this information.

Fixed in #132


Allow line numbers in addition to test name for focusing tests

When working in an editor and scripting test runs in an automated fashion, it's much more practical to be able to specify the line number rather than trying to parse the file to determine the test name.
For example:
#[cfg(test)]
mod tests {
    #[test]
    fn it_can_add_things() {
        assert!(2 + 2, 4)
    }
}

It's quite difficult to parse backwards line by line to find the previous fn statement (which is problematic in itself) and then pull out the it_can_add_things section of the line before finally constructing the full command.
All editors have a capability to determine the current line and thus, assuming I'm on line 5 (the assert line), running something like cargo test 5 or cargo test --lines=5 is very straightforward.
Bonus points would include ranges and comma separated lists: cargo test --lines=1-10,21
This feature would effectively allow "run the test under the cursor" which is something that I do constantly during the day in other languages.

Thanks for the report! I think though that this is an issue for rust-lang/rust rather than this repository where the test harness is defined.

@alexcrichton sounds great! So just open an issue over ther with the same content and link it?

Yeah that should work!

Done: https://github.com/rust-lang/rust/issues/45765


Please create repo -- aries-oca-bundles

Please create the repo and add myself, @WadeBarnes and @amanji as maintainers.  Please activate DCO on the repo.  I'll add content as soon as the repo is created.

Let me know if you need anything else.

Done; https://github.com/bcgov/aries-oca-bundles

Thanks


Update driveitem_createuploadsession.md

Fixing the bug in conflict behavior from the "overwrite" option that doesn't exist and changing it to "replace".

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/rest-api/api/driveitem_createuploadsession.md
:white_check_mark:Succeeded
View (>= odsp-graph-online)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

I made the changes on OneDrive Visual Studio Service and the changes will sync up to this repo.


Add support for external OpenGL textures

The flutter engine ABI supports external OpenGL textures allowing the embedder to draw to OpenGL directly. engine#7087
It's needed to implement the VideoPlayer.

Will also be useful for doing 3D graphics and webrtc.

@Drakirus @gedw99
I have done a texture patch on flutter/engine and it seems to work very well, but I don't know how to port it to go-flutter. Here is my Texture rendering code, maybe it will help you.
https://github.com/cloudwebrtc/flutter-engine/blob/texture_for_glfw/shell/platform/glfw/external_texture_gl.cc

@cloudwebrtc Is the EventChannel require for the Texture to work?

@Drakirus
I think EventChannel is needed, because when the video frame changes in size and aspect ratio, the flutter side needs to adjust the display scale or fit, EventChannel is used to send notifications to the flutter side.
In addition, if we want to adapt WebRTC.PeerConnection, or other plugins with many event sources, EventChannel is needed.

Hi @cloudwebrtc I'm seeing progress on flutter/engine about the textureAPI :+1:.
I'm trying to implement the textureAPI for go-flutter based your CPP code.
While implementing the API, I hit a wall.
My understanding was that you register a texture using: FlutterEngineRegisterExternalTexture, then mark a new frame with FlutterDesktopMarkExternalTextureFrameAvailable. At some point, in between or after those calls, the flutter-engine calls you back using the gl_external_texture_frame_callback. Am my missing something?
Here is my progress on the implementation: commit

@Drakirus  Sorry to reply so late, I see you in the code RegisterExternalTexture(textureId: 400), and after a while MarkExternalTextureFrameAvailable(textureId: 600), this place textureId should be a fixed value of int64_t when registering once, for example: textureId = 0, when your The plugin generates a new video frame, only need to execute MarkExternalTextureFrameAvailable(texture: 0), then the flutter engine will call GLExternalTextureFrameCallback(texture: 0, ...).

@cloudwebrtc Thanks for your reply!
The testing code that I pushed was wrong, I've updated it: commit.
I'm still facing the same issue: gl_external_texture_frame_callback never gets called. :disappointed:
I've updated the code to use a bare C handler code, OnAcquireExternalTexture never get called.
The terminal output looks great:
[....]
Texture: register result: true
go-flutter: no handler found for channel flutter/isolate
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
Texture: New Frame result: true
go-flutter: closing application

@Drakirus Your changes are correct, just add Texture(textureId: 1) to flutter lib/main.dart.
I tested it under linux:
[ERROR:flutter/shell/platform/embedder/embedder.cc(578)] Could not create external texture.
=== OnAcquireExternalTexture: 1
Unknown pixel config 0x0
[ERROR:flutter/shell/platform/embedder/embedder.cc(578)] Could not create external texture.
=== OnAcquireExternalTexture: 1
Unknown pixel config 0x0
[ERROR:flutter/shell/platform/embedder/embedder.cc(578)] Could not create external texture.
=== OnAcquireExternalTexture: 1
Unknown pixel config 0x0
[ERROR:flutter/shell/platform/embedder/embedder.cc(578)] Could not create external texture.
=== OnAcquireExternalTexture: 1
Unknown pixel config 0x0
[ERROR:flutter/shell/platform/embedder/embedder.cc(578)] Could not create external texture.
=== OnAcquireExternalTexture: 1
Unknown pixel config 0x0
[ERROR:flutter/shell/platform/embedder/embedder.cc(578)] Could not create external texture.
Texture: New Frame result: true
=== OnAcquireExternalTexture: 1
Unknown pixel config 0x0
[ERROR:flutter/shell/platform/embedder/embedder.cc(578)] Could not create external texture.
go-flutter: closing application

Texture(textureId: 1) that what I was missing, Thanks!!

Wow, that's awesome.

Updated the demo. Added an very simple videoplayer

fix taged in tag: v0.29.0


Incorrect IPv4 Address Comparison

IsBefore: https://github.com/patzj/sinc/blob/main/models/ipv4.go#L54
IsAfter: https://github.com/patzj/sinc/blob/main/models/ipv4.go#L64

https://github.com/patzj/sinc/pull/2


Plugin not working

Atom 1.18.0 X64 (Sierra) Mac OS.
Not connect.
No file tree.
No toggle tree folder.

see #907 or #839 for further discussion
As far as it seems, this issue only appears for certain people and mostly on Mac OS. I haven't tested the plugin fully but the file tree is working, connecting works too but since I have zero files on my server yet I can't say whether it works.
I am running Atom 1.18.0 ia32 on Windows 10 x64

I just can confirm, that with same configuration (Atom 1.18.0 x64, MacOS Sierra, remote-ftp 1.1.3) all works for me.

I'm on Windows 10/64 and Remote-FTP quit connecting today. It simply returns

Remote FTP: Connection closed

Is this the same issue?

Same with kotko. No file tree. No toggle. No configure. No preferrence. No reaction with shortcut. Nothing.

Same issue here - the plugin stopped functioning.
Mac OSX Sierra v10.12.5
Atom v1.18.0 x64
Remote FTP 1.1.3

Resolved with help from https://github.com/icetee/remote-ftp/issues/839


Add vSphere Volumes section

Proposed changes
Add a section for vSphere Volumes to the Persistent Storage topic
Related issues (optional)
https://docker.atlassian.net/browse/ENGDOCS-34

Deploy preview for docsdocker ready!
Built with commit d1c7da98e960dfcd09b7dfe71fc0e6e830c87ddc
https://deploy-preview-9710--docsdocker.netlify.com

Closing in favor of new PR


Check in postinst fails to detect pre-existing records in /etc/hosts

The check for a pre-existing record in /etc/hosts in scripts/postinst doesn't work as expected: it tells grep to match whole lines that read just like the fqdn, which wouldn't be a valid hosts line and is also not what would be added following this check.
May I propose this line instead:
grep -Fim1 shop.maurer-it.com /etc/hosts || echo -e "\n# Added by NoNagProxmox\n<IP_ADDRESS>\tshop.maurer-it.com\n" >>/etc/hosts

I've silenced it by adding &>/dev/null to the grep portion.
I Will add that to the next build, my Proxmox Server has a mayor outage right now, i will build the fix ASAP
More Issues/PR's Welcome & Thank you!


clean up dependencies for superset v.2.0.0+

failing because superset is installing with python 3.10, which doesn't support numpy.


[PORT] Added null checks in telemetry logger middleware

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/4248

Fixes #4247
Changed projects

Microsoft.Bot.Builder
Microsoft.Bot.Builder.Tests

Duplicate of https://github.com/microsoft/botbuilder-js/issues/2274.
#2274 will be closed by https://github.com/microsoft/botbuilder-js/pull/2434


Displaying incremental results in the python operator

Currently, the result panel is not showing the result incrementally in the python operator. For example, if the python UDF operator produces two tuples and the second tuple takes a long time to be produced, doesn't show the first tuple first in the result panel.
I tested using a workflow that has a single 1-source udf operator with batch size 1. I can see that the operator is producing the first tuple to the downstream but the first tuple is not shown on the result panel.
from pytexera import *
import time

class GenerateOperator(UDFSourceOperator):
    @overrides
    def produce(self) -> Iterator[Union[TupleLike, TableLike, None]]:
        yield {"A": "1"}
        time.sleep(10)
        yield {"A": "1"}

I think this is in general an issue on progressive computation.


Tutorial 2: Adding a new command

Codecov Report

Merging #25 (2c647ab) into master (948fe00) will decrease coverage by 0.43%.
The diff coverage is 61.97%.

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
- Coverage     72.15%   71.72%   -0.44%
- Complexity      399      409      +10
============================================
  Files            70       73       +3
  Lines          1232     1291      +59
  Branches        125      131       +6
============================================
+ Hits            889      926      +37
- Misses          311      332      +21
- Partials         32       33       +1

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

...eedu/address/logic/parser/RemarkCommandParser.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...c/main/java/seedu/address/model/person/Remark.java
62.50% <62.50%> (ø)

...va/seedu/address/logic/commands/RemarkCommand.java
70.83% <70.83%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
97.22% <100.00%> (+0.20%)
:arrow_up:

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
85.71% <100.00%> (+2.38%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
97.36% <100.00%> (+0.14%)
:arrow_up:

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Dispatcher Updates

This brings a few changes to the Dispatcher:

It no longer merges identical tasks from different nodes. We decided that this auto-merging caused more confusion than it was worth, and it may actually have prevented useful executable graphs which would have been intentionally running identical tasks at different points in the graph.
It now throws when it detects cycles in the graph. I originally tried adding this as a post validation after batchTasksWalk, but the cycle causes an infinite loop in batchTasksWalk itself, so the validation had to happen during that process. Once I made that change, it was catching all my other cases as well, so I removed the post-validation step as it seemed redundant.

I've also fixed the ExecutableNode::requirements() binding, and added a test for an ExecutableNode which requires itself, as that's why I started down this path in the first place.

I've rebased in the changes from our discussion

Nice one - thanks.


⚠ Bofrost.be has degraded performance

In c983330, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 989 ms

Resolved: Bofrost.be performance has improved in c1ed4e2 after 7 minutes.


Log Viewer to use custom collection that loads more data as the data grid access data.

Currently, it uses code behind data grid scroll change event to determine if it reaches the bottom of the view.
An alternative MVVM way is to use custom collection that loads more data as the data grid access data.

Lower priority. Close for now.


Pre-training Time

Thanks for your great codes!
In your paper, running the pre-training experiments needs 64 V100 GPUs.
How long have you been training with 64 V100 GPUs?
Thank you!

Hi @haoshuai714
https://tensorboard.dev/experiment/mNHxDM08R6eHKeU0JHn5vg/#scalars
This is the log of MLM+ITM pre-training with 64 V100 GPUS.


Updating documentation GA

Removing preview labels and update pre-requisities.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: vksriram sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@jwhit-MSFT can you please review updates in preparation for GA?
Thank you!