remove unnecessary import

Pull Request Test Coverage Report for Build 238846483

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.044%

Totals

Change from base Build 238736697:
0.0%

Covered Lines:
18954

Relevant Lines:
44370

💛  - Coveralls


Linux Shell Script redirects to old install?

Azure Data Studio Version: 1.20.1

Steps to Reproduce:

Install some version on Linux box (mine is an Amazon Linux workspace, but I don't think it matters).
Somehow, the executable and support files will be installed in /usr/share/azuredatastudio - but not by the install instructions which simply involve unzipping the archive to a local directory (azuredatastudio-linux-x64)
The shell script (which still references VSCode, mostly) redirects to /usr/share, so any new install in the local directory goes unreferenced.
Install the new version following the docs - basically download the archive, copy to user's root, and unzip. It will overwrite the files in the user's subfolder, but not touch the files in usr/share/ where the shell script defaults.
The documentation for installing (and updating) from tar.gz need to be enhanced and tested on common distros.

@eflamm thanks for reporting the issue.  To clarify, are you referring to the installation instructions from https://docs.microsoft.com/en-us/sql/azure-data-studio/download-azure-data-studio?view=sql-server-ver15?  Specifically the below steps:
cd ~
cp ~/Downloads/azuredatastudio-linux-<version string>.tar.gz ~
tar -xvf ~/azuredatastudio-linux-<version string>.tar.gz
echo 'export PATH="$PATH:~/azuredatastudio-linux-x64"' >> ~/.bashrc
source ~/.bashrc
azuredatastudio

If the source ~/.bashrc isn't working as intended on your system you could try the following:

Change the PATH to something like echo 'export PATH="~/azuredatastudio-linux-x64:$PATH"' >> ~/.bashrc so the new azuredatastudio installation is earlier in the path.

Or

Replace the azuredatastudio command with something like  ~/azuredatastudio-linux-x64/azuredatastudio to explicitly refer to the particular azuredatastudio binary.


Make sure import/export resolution does not bring duplicates

Pull Request Description
Component Groups may add additional modules to compilation. This change ensures that whatever modules result from import/export resolution, they are not duplicate. Not only could that lead to unnecessary compilation but also to multiple reports of the same error which would be confusing to users.
This fixes https://www.pivotaltracker.com/story/show/184189980
Important Notes
No easy way to write unit tests for this, so skipping that on purpose for now.

@4e6 @JaroslavTulach need at least one :+1: , pretty please


Support v2 APIM Api

Service Package Request
Can we support the following api : - https://github.com/Azure/azure-rest-api-specs/tree/main/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-05-01-preview?
This would allow Terraform to be able to create v2 versions of APIM which can be provisioned in minutes rather than hours.
Many thanks

@Alancere, could you follow up with service team on this?

Hi @ross-p-smith, A release-request has been requested and it is expected to be released in 2024-02-23.

@ross-p-smith just a heads up that Terraform no longer uses the Azure SDK for API Management, but instead uses hashicorp/go-azure-sdk- as such I’ve added support for this new API Version to that SDK which will enable supporting this in Terraform.

closed release-request.


HWKAPM-737 Fix issue where 'All' transaction (when other txns defined…

…) does not retrieve the list of hostnames due to passing empty string in criteria.transaction field

@ammendonca Could you review please?
This is a quick fix as currently only the hostnames query seems to be affected, but I've created a new bug (HWKAPM-741) as the criteria semantics is not being used consistently across the other queries - so eventually this fix would need to be applied to all queries that are supplying criteria. So if there is a more general solution it could be applied later as part of that issue?

@ammendonca Thanks, update applied. Will merge once CI finished.

Merging, as jenkins failure not related to this PR.


[Snyk] Upgrade aws-sdk from 2.1445.0 to 2.1446.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade aws-sdk from 2.1445.0 to 2.1446.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-08-28.

Release notes

Package name: aws-sdk

2.1446.0 - 2023-08-28See changelog for more information.

2.1445.0 - 2023-08-25See changelog for more information.

    from aws-sdk GitHub release notes

Commit messages

Package name: aws-sdk

ac661ff Updates SDK to v2.1446.0

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@rebase


Add default filters for the container page

Description
Currently the containers explorer page (https:///container/explorer) crashes when there is a large number of containers (e.g. ~4000).
Add some default filters to the Container page, make the filtering more useful, after removing the tree.
PR in UI Classic: https://github.com/ManageIQ/manageiq-ui-classic/pull/1204
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1443743
Screenshots

@miq-bot add_label providers/containers, bug
@simon3z @dkorn @moolitayer @himdel @dclarizio  please review

@cben please review

@yaacov can you now select filters from here to be selected by default? (in "My Setting")

@yaacov can you now select filters from here to be selected by default? (in My Setting)

@yaacov can you now select filters from here to be selected by default? (in My Setting)

a. Yes, I can select filters from here in My Setting, to be shown as options.
b. No, they can not be selected by default. I do not think, you can do that from My Settings for any filter.

LGTM :+1:
@miq-bot assign blomquisg
cc @blomquisg @chessbyte

This looks fine to me . . . @blomquisg good to merge afaic.

https://bugzilla.redhat.com/show_bug.cgi?id=1443743
Target is 5.8.1
@miq-bot add_label fine/yes

@dclarizio  @blomquisg merge ?

https://github.com/ManageIQ/manageiq-ui-classic/issues/1204 merged , without this PR it will show "No filters defined" message, on the navlist bar.

@blomquisg you have the green button

Fine backport details:
$ git log -1
commit 1332fb90715b8e98d599f3c43fcfa9749b5470dc
Author: Oleg Barenboim<EMAIL_ADDRESS>Date:   Thu May 11 17:58:28 2017 -0400

    Merge pull request #14893 from yaacov/do-not-show-containers-tree

    Add default filters for the container page
    (cherry picked from commit c1d66c8ff4a31cdd07c047278ae4a20a537e65bf)

    https://bugzilla.redhat.com/show_bug.cgi?id=1458934


capture groups coloring?

I thought I would be able to color by capture group, but it seems it only has quotes and url which I assume is hard coded? why not add these as capture groups in the regex?
how would I color code key value pairs? I see how I can color the whole line, or half. but not both. Am i wrong?
Mode: STA
PHY mode: N
Channel: 1
AP id: 0
Status: 1

also could use lookaheads to leave delimiters as default color or something else, hmm

The package was made to highlight something special pattern for a log. As you commented, quotes and links patterns are hard coded in general. To highlight separately above pattern by using Log Highlight, you have to define two separate regex - one for xxx:, another for :xxx.

So create 2 severity levels and customize colors there?
I have only been able to color an entire line one color, is there a way to only color part of a group match only ?

ohhhhhh
 [ "match regex", "" ]
doh!

This is satisfactory, I will close, but I still think even more capture groups per level would be easier to maintain, making this much more powerful for debug logs and build systems.


Note on impact of data cap

Hi,
There should be a note in the article on the impact data cap will have on services and solutions which use Log Analytics platform. For example, if data cap gets enabled and data flow is stopped; it may cause some alerts configured for log analytics to misfire - example, heartbeat or Agent Health solution based alerts.
Regards,
Vijay

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a73a8a62-95c6-9ec9-9199-695ad1e5e8a9
Version Independent ID: 6089f013-8b5b-661c-9ee4-d6b267737357
Content: Manage cost of data in Azure Log Analytics
Content Source: articles/log-analytics/log-analytics-manage-cost-storage.md
Service: log-analytics
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@msvijayn - Very good point and I'll bug this and update the article as soon as I can.  #in-progress.

@msvijayn we are closing this issue for now, please feel free to add comments as needed.


Clarify use of conditional reveals for questions only (draft)

Update guidance to clarify that conditional reveals should only be used for questions.
Includes latest conclusions from team to help service teams decide when to use them.
Right now, these edits only cover the 'Radio' component. Once content is approved, I will add a commit in this PR to make similar edits to the 'Checkbox' component.

You can preview this change here:
Built with commit 1d9e1dc95bc58ee68bbbc77541b6e88ee0277977
https://deploy-preview-1573--govuk-design-system-preview.netlify.app

Thanks for the comments @hannalaakso and @joelanman!
Once these look good, I'll need to replicate these edits in the 'Checkboxes' component and add it to this pull request.

From @36degrees 13/4:

Wary of saying that anyone ‘advised us’ on this – we did research and talked to some people but I think we have to ‘own’ the decision
I think it’s more like ‘Based on our research, we believe that conditionally revealed questions similar to those shown in this guidance meets accessibility needs and WCAG 2.1.’
I’d also be keen to stress again that if users conditionally reveal more complex… things… then that’s on them and they need to do their own research
For aria-expanded, I think we might need to use different paras for radios and checkboxes, given aria-expanded will be valid on checkboxes as of ARIA 1.2, which is currently a ‘Candidate Recommendation’ – it’s radios where it’s still contentious.
We’re also going to need to remove the bit about failing 4.1.2 Name, Role, Value, but not until we’ve published the blog post and updated the accessibility statement

Few changes to get this update released together with a backlog statement (draft) about our research so far.
We will write a blog post in the future which will give more nuanced guidance on how acceptable it is to use conditional reveals.
Discarded 13 April edits, added links to the statement with a call-to-action for users to share their research with us.


Structure member alignment issues in WTSApi32

Describe the bug
The timestamp fields in the WTSINFO and WTSINFOEX_LEVEL1 end up with bad values because their offsets within the structure aren't correct. This is due to the SizeConst = USERNAME_LENGTH + 1 of the previous field in WTSINFO messing up the padding. I haven't fiddled with WTSINFOEX_LEVEL1 but I believe it has similar issues.
Changing WTSINFO to use SizeConst = USERNAME_LENGTH + 2 or adding a private char _padding field after UserName fixes it.
What code is involved
PInvoke\WTSApi32\WTSApi32.cs
Expected behavior
The timestamp fields should have either 0s or sane values. The CurrentTime field should always be sane.
Repro
if (WTSEnumerateSessionsEx(HWTSSERVER.WTS_CURRENT_SERVER_HANDLE, out var sessionList)) {
    foreach (var session in sessionList) {
        if (WTSQuerySessionInformation(HWTSSERVER.WTS_CURRENT_SERVER_HANDLE, session.SessionId, WTS_INFO_CLASS.WTSSessionInfo, out var pSessionInfo, out var bytesReturned)) {
            using (pSessionInfo) {
                var sessionInfo = pSessionInfo.ToStructure<WTSINFO>(bytesReturned);
                Console.WriteLine("CurrentTime is {0}", sessionInfo.CurrentTime.ToDateTime());
            }
        }
    }
}

Also using FILETIME instead of LARGE_INTEGER in WTSINFO definition is not correct.
https://devblogs.microsoft.com/oldnewthing/20040825-00/?p=38053

Seems like this is the real issue here.
Will submit PR with a test.


Feature/batch endpoint

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

284 of 329 (86.32%)  changed or added relevant lines in 16 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+45.3%) to 86.607%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/dins/adapters/inbound/fastapi_/routes.py
23
24
95.83%

src/dins/adapters/inbound/event_sub.py
49
51
96.08%

src/dins/main.py
0
5
0.0%

src/dins/adapters/inbound/fastapi_/configure.py
16
22
72.73%

src/dins/core/information_service.py
71
77
92.21%

src/dins/cli.py
0
10
0.0%

src/dins/main.py
0
15
0.0%

Totals

Change from base Build<PHONE_NUMBER>6:
45.3%

Covered Lines:
291

Relevant Lines:
336

💛  - Coveralls


Added zend-expressive-authentication alpha3 support

NOTE: It is PR to master branch because there is no release-1.0.0 branch yet.
We changed recently in zend-expressive that ResponseInterface is factory not a response prototype, see: https://github.com/zendframework/zend-expressive/pull/561
It has been changed only in zend-expressive-authentication release-1.0.0 with alpha3, not in 0.X releases.
This PR drops 0.x branches support.

Thanks, @webimpress


build: support custom out of tree boards

This is one way we can support out of tree board definitions. Basically
all this needs is a board definition in the application source directory
that follows the same structure we have in the main Zephyr tree (also
allowing multiple custom boards). An application tree would like this
for example:
boards/
CMakeLists.txt
prj.conf
README.rst
src/
with boards following the same structure as in Zephyr:
.
├── boards
│   └── x86
│       └── arduino_101
│           ├── doc
│           │   └── img
│           └── support
└── src
Fixes #1727
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

Codecov Report

Merging #6150 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6150   +/-   ##
=======================================
  Coverage   52.88%   52.88%
=======================================
  Files         412      412
  Lines       40274    40274
  Branches     7801     7801
=======================================
  Hits        21297    21297
  Misses      15761    15761
  Partials     3216     3216

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2838b...a70bf31. Read the comment docs.

I wonder if we should support a BOARD= in prj.conf so someone could have multiple projects using the same external BOARD port.

"I wonder if we should support a BOARD= in prj.conf so someone could have multiple projects using the same external BOARD port."
BOARD_ROOT you mean?
That is technically difficult to do because of a chicken-and-egg problem. The Kconfig depends on the BOARD. So the BOARD can't depend on the Kconfig (prj.conf).

"I wonder if we should support a BOARD= in prj.conf so someone could have multiple projects using the same external BOARD port."
BOARD_ROOT you mean?
That is technically difficult to do because of a chicken-and-egg problem. The Kconfig depends on the BOARD. So the BOARD can't depend on the Kconfig (prj.conf).

I do, I think we will have to solve this for SOC support out of tree.

I wonder if we should support a BOARD= in prj.conf so someone could have multiple projects using the same external BOARD port.

chicken-egg problem as pointed above.
We can do the same for SoC I guess, but lets do that first for board which is in high demand, I will add documentation.

@nashif Can you give a working example of using out-of-tree board definitions? I've tried several ways to define my external board but was not successful. Actually, it works if I specify the absolute directory name of my project where the directory boards is.  But I didn't find a proper macro to let zephyr to find the boards in my project directory. Sorry that I just switched from v1.8 to this version and am not familiar with new terms defined by cmake.


feat: replace testnet_v1 tokens with Goerli tokens

ForceBridge has replaced their bridged ETH testnet tokens from Rinkeby to Goerli:

https://github.com/pygman/force-bridge/commit/274f950216bd42866fd34a6becbfc8e226bcbc9e

Changes in the PR:

Replace testnet_v1 bridged tokens to match with ForceBridge
Add bridged token WBTC|eth to testnet_v1

ForceBridge has replaced their bridged ETH testnet tokens from Rinkeby to Goerli:

cc @Keith-CY


adding vue

i'am adding vue js

Thanks for your PR. Happy to have vue.js on bord.
Can you update the main README.md accordingly, to give everybody a quickstart to vuejs?
Then i'm happy to merge this.

I simplify the .gitignore
remove app/assets/js/index.js since this file can be generated by npm run build-xxx
and i do some fixing in vue webpack.config

I appreciate the removal of  app/assets/js/index.js but we need make sure the folder app/assets/js exists or is created on the first run of npm run build-xxx otherwise we get a error. Either create a dummy placeholder in app/assets/js or create the folder in npm run build-xxx cmds.

Ah yes.. i didnt realize removing the app/assets/js folder.
And honestly i just knew that git does not track the folder, it track files! :))

Thanks, didn't knew this trick either. Good Job.


ReshapePhase needs columns for parsing types

We didn't put columns in ReshapePhase because they're not consistent, from beginning to end of a reshape phase they can be quite different e.g. in a pivot.
However, parsing types is necessary!  E.g. in the boston pipeline, the pivot phase uses a DateColumn to parse date values.
We should add incoming column types that are checked and casted at the beginning of a ReshapePhase.

I have a whole new idea instead of ReshapePhase... since it is becoming more and more like phase.  Maybe we make it a Phase but with a flag that says "renumber rows" ?


Implement Vector Class - protected void removeRange(int fromIndex, int toIndex)

Please assign this to me.


update: make TrustyAI GA

Description

https://issues.redhat.com/browse/RHOAIENG-13087
How Has This Been Tested?

local build: quay.io/wenzhou/rhods-operator-catalog:v2.15.13807
Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

merge code based on the test done by Cesar, result  from both clean install and upgrade are working as expected,


Sidecar for performance tests

Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration tests.
[x] I ensured that the PR title is good enough for the changelog.
[x] I labeled the PR.

Hmm, I just noticed: I don't think we should include the first performance test scenario in a PR with the name "Sidecar for performance tests"

The scenario is added as an example, I guess. But I agree that the title is misleading. Perhaps Sidecar for performance tests with example scenario?

The scenario is added as an example, I guess. But I agree that the title is misleading. Perhaps Sidecar for performance tests with example scenario?

I don't think we need an example scenario for now. The first scenario will soon be implemented anyway.


[themes] Disable Italic Option Feature Request

VSCode Version: 1.15.0
OS Version: Windows 10 Version 1703 Build 15063.540

Steps to Reproduce:

Reproduces without extensions: Yes/No
Sometimes authors of themes use italic for comments, language keywords and for other things. In some cases that's looks not so good (as example what I mean you can read my issue/feature-request on Material Theme https://github.com/equinusocio/vsc-material-theme/issues/81). Of course we can change this in theme source code manually but it will be great to have Disable Italic Option in vscode config file.
For example in Sublime Text 3 we have no_italic font option to disable italic at all:
"font_options":
[
	"no_italic"
],

Related issue: https://github.com/Microsoft/vscode/issues/25895
Fira Code don't have Italic too.

+1

@aeschli
Would this be something doable via user settings? (since those rules get appended to the theme rules anyways?)

I ran into this issue with the Atom One theme, and adding the following setting worked for me:
"editor.tokenColorCustomizations": {
    "textMateRules": [
        {
            "scope": [
                "comment",
            ],
            "settings": {
                "fontStyle": "",
            }
        }
    ]
}

So for anyone that wants "normal" font styling on comments, just drop that in your settings.

@Korvox thanks. That's helpful for me:
"editor.tokenColorCustomizations": {
    "textMateRules": [
        {
            "scope": [
                "comment",
                "punctuation.definition.comment",
                "variable.language"
            ],
            "settings": {
                "fontStyle": ""
            }
        }
    ]
}

"punctuation.definition.comment" to disable italic on the characters creating comments (like: // and others).

Disable it for all:
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": [
        "comment",
        "comment.block",
        "comment.block.documentation",
        "comment.line",
        "constant",
        "constant.character",
        "constant.character.escape",
        "constant.numeric",
        "constant.numeric.integer",
        "constant.numeric.float",
        "constant.numeric.hex",
        "constant.numeric.octal",
        "constant.other",
        "constant.regexp",
        "constant.rgb-value",
        "emphasis",
        "entity",
        "entity.name",
        "entity.name.class",
        "entity.name.function",
        "entity.name.method",
        "entity.name.section",
        "entity.name.selector",
        "entity.name.tag",
        "entity.name.type",
        "entity.other",
        "entity.other.attribute-name",
        "entity.other.inherited-class",
        "invalid",
        "invalid.deprecated",
        "invalid.illegal",
        "keyword",
        "keyword.control",
        "keyword.operator",
        "keyword.operator.new",
        "keyword.operator.assignment",
        "keyword.operator.arithmetic",
        "keyword.operator.logical",
        "keyword.other",
        "markup",
        "markup.bold",
        "markup.changed",
        "markup.deleted",
        "markup.heading",
        "markup.inline.raw",
        "markup.inserted",
        "markup.italic",
        "markup.list",
        "markup.list.numbered",
        "markup.list.unnumbered",
        "markup.other",
        "markup.quote",
        "markup.raw",
        "markup.underline",
        "markup.underline.link",
        "meta",
        "meta.block",
        "meta.cast",
        "meta.class",
        "meta.function",
        "meta.function-call",
        "meta.preprocessor",
        "meta.return-type",
        "meta.selector",
        "meta.tag",
        "meta.type.annotation",
        "meta.type",
        "punctuation.definition.string.begin",
        "punctuation.definition.string.end",
        "punctuation.separator",
        "punctuation.separator.continuation",
        "punctuation.terminator",
        "storage",
        "storage.modifier",
        "storage.type",
        "string",
        "string.interpolated",
        "string.other",
        "string.quoted",
        "string.quoted.double",
        "string.quoted.other",
        "string.quoted.single",
        "string.quoted.triple",
        "string.regexp",
        "string.unquoted",
        "strong",
        "support",
        "support.class",
        "support.constant",
        "support.function",
        "support.other",
        "support.type",
        "support.type.property-name",
        "support.variable",
        "variable",
        "variable.language",
        "variable.name",
        "variable.other",
        "variable.other.readwrite",
        "variable.parameter"
      ],
      "settings": {
        "fontStyle": ""
      }
    }
  ]
}

@mohouyizme Great snippet!
In your configurations all italics are disabled expect for "module" example the word "data" in the following snippet for a .tsx file is still in italic
import { data as scrapReasons } from './testData
-----------^^
What is the right configuration to set that font to "normal" style too? Thanks!

I know it's not the best way to do things but add this line to the list above Microsoft/vscode#32579 (comment)
"meta.import variable.other.readwrite"

Here is a simple way to find the scopes to add them to this list:
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": [
         // Add scopes name to this array
      ],
      "settings": {
        "fontStyle": ""
      }
    }
  ]
}

First focus your mouse on the italic or bold word:

Then open the Command Palette

Search for: "Developer: Inspect TM Scopes"

It will appear a popup contains some information about the scope

Add the highlighted part to the scope array mentioned above
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": [
         "meta.import variable.other.readwrite",
         "other scopes ..."
      ],
      "settings": {
        "fontStyle": ""
      }
    }
  ]
}

Finally you can find me on twitter: @mohouyizme

@mohouyizme sodo i just paste the code on the user settings? or do i need to put fontstyle?

@ayaorei yes, basically you can simply copy any variation of @mohouyizme's snippet into your User Preferences and you are good to go :)

This popped up yesterday in Material Theme after an upgrade to 1.31.1. All of the sudden every class in my SCSS files became italicized. Instead of slowly losing my mind throughout the day, this post helped me write this settings block:
    "editor.tokenColorCustomizations": {
        "textMateRules": [{
            "scope": [
                "entity.other.attribute-name",
            ],
            "settings":{
                "fontStyle": ""
            }
        }]
    },

That's the scope if you're running into weird italicized classes!

On the spirit of doing it the hacky way, a better solution I found is, instead of adding every single scope to editor.tokenColorCustomizations, you can use the vscode-custom-css extension, and then set this in your custom css file:
.mtki {
    font-style: normal;
}

It will apply to every single scope if that's what you're looking for.

Is there a way to only prevent terrible auto-slant but have italics when the font has them? For example in cases when the main font has italics but fallback CJK font does not?

+1

Interesting and sad at the same time, how so many workarounds accumulated over time and yet no real fix seems to be implemented in the software, itself, even after roughly 3 years. :/

Maybe should make a extension that overwrite the settings.json 😞

Hey guys,
I have disabled it in the settings.json however, it still hasn't worked:
{
    "[dart]": {
        "editor.trimAutoWhitespace": false,
        "editor.autoClosingBrackets": "always",
        "diffEditor.ignoreTrimWhitespace": true,
        "editor.formatOnSave": true,
        "editor.formatOnType": true,
        "editor.rulers": [
            80
        ],
        "editor.selectionHighlight": false,
        "editor.suggest.snippetsPreventQuickSuggestions": false,
        "editor.suggestSelection": "first",
        "editor.tabCompletion": "onlySnippets",
        "editor.wordBasedSuggestions": false
    },
    "editor.fontFamily": "Cascadia Code",
    "window.zoomLevel": 1.5,
    "workbench.iconTheme": "material-icon-theme",
    "terminal.integrated.fontSize": 15,
    "terminal.integrated.cursorStyle": "line",
    "explorer.confirmDelete": false,
    "files.autoSaveDelay": 300,
    "editor.fontLigatures": true,
    "git.enableSmartCommit": true,
    "[json]": {
        "editor.quickSuggestions": {
            "strings": true
        },
        "editor.suggest.insertMode": "replace"
    },
    "editor.fontSize": 20,
    "editor.minimap.enabled": false,
    "python.pythonPath"<EMAIL_ADDRESS>    "editor.suggestSelection": "first",
    "python.languageServer": "Microsoft",
    "kite.showWelcomeNotificationOnStartup": false,
    "python.linting.enabled": true,
    "editor.defaultFormatter": "Dart-Code.dart-code",
    "editor.formatOnSave": true,
    "explorer.confirmDragAndDrop": false,
    "dart.previewBazelWorkspaceCustomScripts": true,
    "dart.previewFlutterUiGuides": true,
    "dart.previewFlutterUiGuidesCustomTracking": true,
    "scm.inputFontFamily": "defaultSF Mono",
    "python.dataScience.askForKernelRestart": false,
    "files.autoSave": "afterDelay",
    "python.dataScience.alwaysTrustNotebooks": true,
    "cSpell.userWords": [
        "sqlite"
    ],
    "git.confirmSync": false,
    "editor.fontWeight": "300",
    "editor.tokenColorCustomizations": {
        "scope": [
            "comment",
            "comment.block",
            "comment.block.documentation",
            "comment.line",
            "constant",
            "constant.character",
            "constant.character.escape",
            "constant.numeric",
            "constant.numeric.integer",
            "constant.numeric.float",
            "constant.numeric.hex",
            "constant.numeric.octal",
            "constant.other",
            "constant.regexp",
            "constant.rgb-value",
            "emphasis",
            "entity",
            "entity.name",
            "entity.name.class",
            "entity.name.function",
            "entity.name.method",
            "entity.name.section",
            "entity.name.selector",
            "entity.name.tag",
            "entity.name.type",
            "entity.other",
            "entity.other.attribute-name",
            "entity.other.inherited-class",
            "invalid",
            "invalid.deprecated",
            "invalid.illegal",
            "keyword",
            "keyword.control",
            "keyword.operator",
            "keyword.operator.new",
            "keyword.operator.assignment",
            "keyword.operator.arithmetic",
            "keyword.operator.logical",
            "keyword.other",
            "markup",
            "markup.bold",
            "markup.changed",
            "markup.deleted",
            "markup.heading",
            "markup.inline.raw",
            "markup.inserted",
            "markup.italic",
            "markup.list",
            "markup.list.numbered",
            "markup.list.unnumbered",
            "markup.other",
            "markup.quote",
            "markup.raw",
            "markup.underline",
            "markup.underline.link",
            "meta",
            "meta.block",
            "meta.cast",
            "meta.class",
            "meta.function",
            "meta.function-call",
            "meta.preprocessor",
            "meta.return-type",
            "meta.selector",
            "meta.tag",
            "meta.type.annotation",
            "meta.type",
            "punctuation.definition.string.begin",
            "punctuation.definition.string.end",
            "punctuation.separator",
            "punctuation.separator.continuation",
            "punctuation.terminator",
            "storage",
            "storage.modifier",
            "storage.type",
            "string",
            "string.interpolated",
            "string.other",
            "string.quoted",
            "string.quoted.double",
            "string.quoted.other",
            "string.quoted.single",
            "string.quoted.triple",
            "string.regexp",
            "string.unquoted",
            "strong",
            "support",
            "support.class",
            "support.constant",
            "support.function",
            "support.other",
            "support.type",
            "support.type.property-name",
            "support.variable",
            "variable",
            "variable.language",
            "variable.name",
            "variable.other",
            "variable.other.readwrite",
            "variable.parameter",
            "source.dart",
          ],
          "settings": {
            "fontStyle": ""
          }
    },
    "workbench.colorTheme": "Dracula"
}

However,
When I go back to my editor:

Here is what to developer token option tells me:

I appreciate your help. Thanks!

don't know working fine for me with same settings.json :|

I'm sorry, why hasn't this been fixed yet?

@mrillusi0n I'm not sure if it's a problem in the first place, the font styles mainly come with themes, you may open an issue or even contribute to your favorite theme and add a variant that comes without font styles, or you can use the snippet above.

Yes, sorry about that. Now that I think about it, if the devs kept on adding every feature that was requested... 😵
BLOAAATSSS.

Instead of adding hundreds of lines to my settings.json, I feel it is easier for me to modify the themes. So I write a dirty python script to do it. The script delete all the italic fonts in themes. But you have to run it every time the theme get updated.
#!/usr/bin/env python3

import json
import os
import re
from pathlib import Path

# the `extensions` dir of your vscode profile,
# in Linux or macOS, this should be:
# extdir = Path("~/.vscode/extensions").expanduser()
# in WSL, should be like this:
extdir = Path("/mnt/c/Users/USERNAME/.vscode/extensions")

# the folder name of the themes you want to modify,
# without version numbers
themes = (
    "equinusocio.vsc-material-theme",
    "equinusocio.vsc-community-material-theme",
    "dracula-theme.theme-dracula",
)

def modify_json(themedir: Path):

    with open(themedir.joinpath("package.json"), "r", encoding="utf-8") as f:
        files = [
            themedir.joinpath(d["path"])
            for d in json.load(f)["contributes"]["themes"]
        ]

    for file in files:
        with open(file, "r+", encoding="utf-8") as f:
            data = json.load(f)
            for colors in data["tokenColors"]:
                settings = colors["settings"]
                font = settings.get("fontStyle", "")
                if "italic" in font:
                    font = re.sub(r"\s*italic\s*", "", font)
                    if font:
                        settings["fontStyle"] = font
                    else:
                        del settings["fontStyle"]
            f.seek(0)
            json.dump(data, f, indent=4, ensure_ascii=False)
            f.truncate()

def main():
    pattern = re.compile(rf'({"|".join(themes)})-[\d.]+', re.I)
    for name in filter(pattern.fullmatch, os.listdir(extdir)):
        modify_json(extdir.joinpath(name))
        print(f"{name} modified.")

if __name__ == "__main__":
    main()

Please, if this is ever implemented, I would like an option for disabling bold text too! Thanks!

I'm surprised this still isn't a setting, it's a rudimentary feature. Having to manually set the fontStyle for every single scope is a bit of a pain.

@dspacejs This might help.
This was enough for me:
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": [
        "comment",
        "punctuation.definition.comment",
      ],
      "settings": {
        "fontStyle": ""
      }
    }
  ]
},

Sometimes comment alone isn’t enough.
The problem is that italics are theme-specific. That being said, you can also override scopes but note this approach is also theme-specific.
This comment explains how to work out how to determine specifically which scopes to use so you don’t have to be exhaustive.

@zaydek that's cleaner, but users should only have to create a complex configuration if they're looking to only italicise certain nodes. I don't want any italics at all, and I'm guessing there's many users who don't.

Hey, I found a way to Highlight NON-ASCII Characters,   giving them a Custom TEXTMate Scope
https://github.com/microsoft/vscode/issues/25895#issuecomment-890614837

I wonder, could we implement this as a command so it's easier for users to accomplish? I received feedback from a user that italics are difficult and not very readable for visually impaired users (latest comments on the Dracula theme repo: https://github.com/dracula/visual-studio-code/issues/78). Ideally, all users should be able to use themes without text formatting, instead of having theme authors built alternate versions?
cc @isidorn adding accessibility label to this

Any news?

How can I turn off italic font of VS code destructuring? Thanks a lot! 🎅

Instead of adding hundreds of lines to my settings.json, I feel it is easier for me to modify the themes. So I write a dirty python script to do it. The script delete all the italic fonts in themes. But you have to run it every time the theme get updated.
#!/usr/bin/env python3

import json
import os
import re
from pathlib import Path

# the `extensions` dir of your vscode profile,
# in Linux or macOS, this should be:
# extdir = Path("~/.vscode/extensions").expanduser()
# in WSL, should be like this:
extdir = Path("/mnt/c/Users/USERNAME/.vscode/extensions")

# the folder name of the themes you want to modify,
# without version numbers
themes = (
    "equinusocio.vsc-material-theme",
    "equinusocio.vsc-community-material-theme",
    "dracula-theme.theme-dracula",
)

def modify_json(themedir: Path):

    with open(themedir.joinpath("package.json"), "r", encoding="utf-8") as f:
        files = [
            themedir.joinpath(d["path"])
            for d in json.load(f)["contributes"]["themes"]
        ]

    for file in files:
        with open(file, "r+", encoding="utf-8") as f:
            data = json.load(f)
            for colors in data["tokenColors"]:
                settings = colors["settings"]
                font = settings.get("fontStyle", "")
                if "italic" in font:
                    font = re.sub(r"\s*italic\s*", "", font)
                    if font:
                        settings["fontStyle"] = font
                    else:
                        del settings["fontStyle"]
            f.seek(0)
            json.dump(data, f, indent=4, ensure_ascii=False)
            f.truncate()

def main():
    pattern = re.compile(rf'({"|".join(themes)})-[\d.]+', re.I)
    for name in filter(pattern.fullmatch, os.listdir(extdir)):
        modify_json(extdir.joinpath(name))
        print(f"{name} modified.")

if __name__ == "__main__":
    main()

This works for perfectly! Thank you so much!!! And be well!

It's bananas that this is still an issue FIVE YEARS after this feature request was opened! 💀
A word of caution for Google visitors: @libertypi's script doesn't seem to work for themes with C-style comments in their JSON. This was all the ones I tried, e.g. Wes Bos's Cobalt2, on my Mac. Python's built-in JSON parser doesn't seem to support such comments. :c

It's not a dynamic way but add those lines to your vs code settings:
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": [
        "comment",
        "comment.block",
        "comment.block.documentation",
        "comment.line",
        "constant",
        "constant.character",
        "constant.character.escape",
        "constant.numeric",
        "constant.numeric.integer",
        "constant.numeric.float",
        "constant.numeric.hex",
        "constant.numeric.octal",
        "constant.other",
        "constant.regexp",
        "constant.rgb-value",
        "emphasis",
        "entity",
        "entity.name",
        "entity.name.class",
        "entity.name.function",
        "entity.name.method",
        "entity.name.section",
        "entity.name.selector",
        "entity.name.tag",
        "entity.name.type",
        "entity.other",
        "entity.other.attribute-name",
        "entity.other.inherited-class",
        "invalid",
        "invalid.deprecated",
        "invalid.illegal",
        "keyword",
        "keyword.control",
        "keyword.operator",
        "keyword.operator.new",
        "keyword.operator.assignment",
        "keyword.operator.arithmetic",
        "keyword.operator.logical",
        "keyword.other",
        "markup",
        "markup.bold",
        "markup.changed",
        "markup.deleted",
        "markup.heading",
        "markup.inline.raw",
        "markup.inserted",
        "markup.italic",
        "markup.list",
        "markup.list.numbered",
        "markup.list.unnumbered",
        "markup.other",
        "markup.quote",
        "markup.raw",
        "markup.underline",
        "markup.underline.link",
        "meta",
        "meta.block",
        "meta.cast",
        "meta.class",
        "meta.function",
        "meta.function-call",
        "meta.preprocessor",
        "meta.return-type",
        "meta.selector",
        "meta.tag",
        "meta.type.annotation",
        "meta.type",
        "punctuation.definition.string.begin",
        "punctuation.definition.string.end",
        "punctuation.separator",
        "punctuation.separator.continuation",
        "punctuation.terminator",
        "storage",
        "storage.modifier",
        "storage.type",
        "string",
        "string.interpolated",
        "string.other",
        "string.quoted",
        "string.quoted.double",
        "string.quoted.other",
        "string.quoted.single",
        "string.quoted.triple",
        "string.regexp",
        "string.unquoted",
        "strong",
        "support",
        "support.class",
        "support.constant",
        "support.function",
        "support.other",
        "support.type",
        "support.type.property-name",
        "support.variable",
        "variable",
        "variable.language",
        "variable.name",
        "variable.other",
        "variable.other.readwrite",
        "variable.parameter"
      ],
      "settings": {
        "fontStyle": ""
      }
    }
  ]
}
--.          {
      "support.me"
       "cloud"

}

@Pasynko I had to add keyword.control.return to that list. I still say it's bananas that we need to add 111 lines to our settings JSON to disable italics instead of checking one box. D:

The solutions above didn't worked for me, I am using Ubuntu 22.04 LTS 64-bit, note that the fonts of integrated terminal are affected:

I implemented the above still it completely didn't get me rid of the italics in the "Dark Theme".

Full code in settings.json:
{
    "workbench.colorTheme": "Dark Theme",
    "editor.fontFamily": "Fira Code, Menlo, Monaco, 'Courier New', monospace",
    "editor.fontLigatures": true,
    "terminal.integrated.fontSize": 20,
    "editor.fontSize": 20,
    "editor.tabSize": 2,
    "editor.tokenColorCustomizations": {
        "textMateRules": [
          {
            "scope": [
              "comment",
              "comment.block",
              "comment.block.documentation",
              "comment.line",
              "constant",
              "constant.character",
              "constant.character.escape",
              "constant.numeric",
              "constant.numeric.integer",
              "constant.numeric.float",
              "constant.numeric.hex",
              "constant.numeric.octal",
              "constant.other",
              "constant.regexp",
              "constant.rgb-value",
              "emphasis",
              "entity",
              "entity.name",
              "entity.name.class",
              "entity.name.function",
              "entity.name.method",
              "entity.name.section",
              "entity.name.selector",
              "entity.name.tag",
              "entity.name.type",
              "entity.other",
              "entity.other.attribute-name",
              "entity.other.inherited-class",
              "invalid",
              "invalid.deprecated",
              "invalid.illegal",
              "keyword",
              "keyword.control",
              "keyword.operator",
              "keyword.operator.new",
              "keyword.operator.assignment",
              "keyword.operator.arithmetic",
              "keyword.operator.logical",
              "keyword.other",
              "markup",
              "markup.bold",
              "markup.changed",
              "markup.deleted",
              "markup.heading",
              "markup.inline.raw",
              "markup.inserted",
              "markup.italic",
              "markup.list",
              "markup.list.numbered",
              "markup.list.unnumbered",
              "markup.other",
              "markup.quote",
              "markup.raw",
              "markup.underline",
              "markup.underline.link",
              "meta",
              "meta.block",
              "meta.cast",
              "meta.class",
              "meta.function",
              "meta.function-call",
              "meta.preprocessor",
              "meta.return-type",
              "meta.selector",
              "meta.tag",
              "meta.type.annotation",
              "meta.type",
              "punctuation.definition.string.begin",
              "punctuation.definition.string.end",
              "punctuation.separator",
              "punctuation.separator.continuation",
              "punctuation.terminator",
              "storage",
              "storage.modifier",
              "storage.type",
              "string",
              "string.interpolated",
              "string.other",
              "string.quoted",
              "string.quoted.double",
              "string.quoted.other",
              "string.quoted.single",
              "string.quoted.triple",
              "string.regexp",
              "string.unquoted",
              "strong",
              "support",
              "support.class",
              "support.constant",
              "support.function",
              "support.other",
              "support.type",
              "support.type.property-name",
              "support.variable",
              "variable",
              "variable.language",
              "variable.name",
              "variable.other",
              "variable.other.readwrite",
              "variable.parameter"
            ],
            "settings": {
              "fontStyle": ""
            }
          }
        ]
      },
    "oneDarkPro.italic": false,
}

2023 and this accessibility issue is still not fixed.

For me textMateRules does not work, but this does
  "editor.semanticTokenColorCustomizations": {
    "enabled": true,
    "rules": {
      "*": {
        "italic": false
      },
  },

Tested with Flutter code base and One Dark Pro theme

That's awesome @MariuzM, great discovery. I've disabled my textMateRules settings and tested your rule with a few themes. I've had good (but not perfect) results.
Sarah Drasner's "In Bed by 7pm" theme uses italics for a few things, and your new rule disables most of them. I'm still seeing italics for comments though.
With Sarah's Night Owl theme (the version with italics) this new settings removes lots of the italics, but I'm still seeing italics on keyword.control and entity.name.function scopes.
I tried Material Theme Darker too, and that also italicises keyword.control scopes.
I'm going to keep your "italic": false rule, and re-enable my textMateRules setting, which is largely based on the info previously shared in this issue.
So far, I've collected the following additions to the scopes reported by others in this issue:
"constant.language.json.comments",
"constant.language.boolean.false.tsx",
"constant.language.boolean.true.tsx",
"keyword.control.return",
"support.type.builtin.tsx",
"variable.other.object",
"variable.other.object.property.tsx",

I also removed my textMateRules to test @MariuzM's method, and I installed that same "In Bed by 7pm" theme as @gma did. Italics out the wazanus:

...At least in PHP. And, yes, the comments are all italicized too. It's bananas that the Code devs still haven't provided a sane method to turn these off. It shouldn't require adding 700 lines to your settings file!

以下是查找范围并将其添加到此列表的简单方法：
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": [
         // Add scopes name to this array
      ],
      "settings": {
        "fontStyle": ""
      }
    }
  ]
}

首先将鼠标聚焦在斜体或粗体单词上：
首先将鼠标聚焦在斜体或粗体单词上：

然后打开命令面板
然后打开命令面板

搜索：“开发人员：Inspect TM Scopes”
搜索：“开发人员：Inspect TM Scopes”

将会出现一个弹出窗口，其中包含有关范围的一些信息
将会出现一个弹出窗口，其中包含有关范围的一些信息

将突出显示的部分添加到上面提到的范围数组中
将突出显示的部分添加到上面提到的范围数组中
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": [
         "meta.import variable.other.readwrite",
         "other scopes ..."
      ],
      "settings": {
        "fontStyle": ""
      }
    }
  ]
}

最后你可以在 Twitter 上找到我：@mohouyizme
最后你可以在 Twitter 上找到我：@mohouyizme

sad...

This should be considered a basic accessibility feature, not a nitpick by a few developers. Using @MariuzM's solution does improve the situation, but not entirely. And it is also less performant than overriding in a per-token basis.
Also this isn't just aimed at italics, but bold and underlines as well.
TLDR: There needs to be a way to globally enable/disable font styling à la the "editor.fontWeight" option. Themes could do this by themselves, leaving it up to the themes' maintainers to add an option for this (catppuccin does this pretty well: "catppuccin.italicKeywords": false); however, leaving it to the developers doesn't seem like the best option - and sometimes it's best to have a global option.

Some themes seem to override all textMateRules scopes (even *).
Adding this setting (with the apc-extension) is the only way I've managed to disable italics (in comments) for all themes:
"apc.stylesheet": {
    ".mtk8": {
        "font-style": "normal !important",
    }
},

The !important overrides vscode's css for italics, and .mtk8 is the classname used for comments.  To target other (non-comment) font, you can use the Toggle Developer Tools command to inspect the classnames of the areas you want to target.
The only downside is that it forces all font-styles like bold  to be normal, as opposed to only italic font-styles.

I just want to disable italic but reset styles

It's August 2024, and I'm still waiting for this

Maybe you can try this configuration; I can use this configuration to turn italic.
 "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": [""],
        "settings": {
          "fontStyle": "italic"
        }
      }
    ]
  }

Need to change italic to ""


Feature Request: Manually set tracker tag during create

I generally want my slugs to be shorter than the labels--so when I create or duplicate a tracker, I'd love to be able to set the tag independently from the label.

It looks like I can do this during create, just not during duplicate.


Need a way to preserve/restore tree state

State: collapse, focus, selection.
@jrieken Outline needs it for when switching from file A to file B and back.
@isidorn Explorer needs it for reloading a window.

Is this always married to setInput? Before filtering/finding I also capture the state and restore it once filtering/finding ends but the input is always the same then


Dropdown List of Interpreters in Virtual Environments is Jumbled

Environment data

VS Code version: Version 1.25.1 (1.25.1)

Extension version (available under the Extensions sidebar): 2018.7.0

OS and version: MacOS 10.13.6

Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.0 (Homebrew/Pipenv)

Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv

Relevant/affected Python packages and their versions: ...

Actual behavior
Selecting "Python: Select Interpreter" from the Command Palette, the list of available virtual environments is jumbled, and includes CLang version information, followed by the type of virtual environment:

Also, in the dropdown list, the type of virtual environment is shown as "(virtualenv)", which is less helpful than the original "(pipenv)". The "pipenv" notation was correctly displayed in the February 2018 Release blog post.
Also, in the status bar, the Python version information does not include the type of virtual environment for the selected interpreter.

Expected  behavior
The list items should not include Clang version information.
The status bar should indicate the type of virtual environment after the Python version, to help clarify which interpreter is active.
Steps to reproduce:

Open VSCode in a directory containing a pipenv Pipfile.
Open a Python script file.
From the Command Palette, choose "Python: Select Interpreter" to display the list of virtual environments.

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
none

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
none

I'm able to replicate this as follows:

Update settings.json as follows:

    "python.venvFolders": [
        "envs",
        ".pyenv",
        ".direnv",
        "/Users/donjayamanne/.local/share/virtualenvs"
    ],
    "python.venvPath": "/Users/donjayamanne/.local/share/virtualenvs"

View list of environments

This causes the extension to look for virtual envs in the above directories.
Two problems:

I have no idea which setting is to be updated #1479
Virtual envs wins over PipEnvs. Solution: Change order of registration of providers in src/client/interpreter/locators/index.ts (move PipEnv locator above VirtualEnvs)

One problem we'll have is differentiating between PipEnv environments and standard virtual envs. According to the documentation pipenv environments are created in the standard directory (see Automatically creates a virtualenv in a standard location.)

Thanks for confirming.
A few months ago, before switching to Pipenv, I had tried to resolve venv issues by extending python.venvFolders and python.venvPath, but they are now both commented out in my user settings. Which leaves me with only the default values:
"python.venvFolders": [
    "envs",
    ".pyenv",
    ".direnv"
  ],
  "python.venvPath": ""


Use non-captured identifier in format string

To ensure that MSRV of 1.56.1 still holds, replace the captured identifier in format strings. Capturing identifierts for format strings was introduced with Rust 1.58.0.

I checked the MSRV with cargo-msrv:
$ cargo msrv
......
Finished The MSRV is: 1.56.1


Start Using SAP HANA 2.0, express edition (Virtual Machine Method)

Good day. I was able to change the SYSTEM password for SystemDB but get error - "* 10: authentication failed SQLSTATE: 28000" when I trie to change the other users passwords. Please help.

Hello: The password change functionality was updated in the third week of December -- the now system prompts you for a new password during the initial login, and updates the passwords for all required users.
Are you still experiencing this issue using the latest installation package?
Hope this helps,
John C.


:sparkles: Add caching to schema_id fetch from ledger

Note: beaker, the cache library, has a critical vulnerability:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-7489
An insecure data serialization method could theoretically allow arbitrary code execution.

Beaker has a critical vulnerability, and it seems like caching won't improve scalability significantly enough, so closing for now


Scala 2.13 deprecates language.higherKinds so make it a flag for 2.12

Coverage decreased (-0.2%) to 95.775% when pulling 0d9da03a70c630c1c1fd2af70afc3d823dc7051a on nafg:no-import-higher-kinds into 49fc9c7f3cf24cb5d04ff8bd059fb74faf3fdc86 on mohiva:master.

Coverage decreased (-0.2%) to 95.775% when pulling 0d9da03a70c630c1c1fd2af70afc3d823dc7051a on nafg:no-import-higher-kinds into 49fc9c7f3cf24cb5d04ff8bd059fb74faf3fdc86 on mohiva:master.

Coverage decreased (-0.2%) to 95.775% when pulling 0d9da03a70c630c1c1fd2af70afc3d823dc7051a on nafg:no-import-higher-kinds into 49fc9c7f3cf24cb5d04ff8bd059fb74faf3fdc86 on mohiva:master.

Coverage decreased (-0.2%) to 95.775% when pulling 0d9da03a70c630c1c1fd2af70afc3d823dc7051a on nafg:no-import-higher-kinds into 49fc9c7f3cf24cb5d04ff8bd059fb74faf3fdc86 on mohiva:master.

@nafg Are you sure? The tests fail exactly for 2.13 with the error that higher kinded-types should be enabled.
[error] /home/travis/build/mohiva/play-silhouette/silhouette/app/com/mohiva/play/silhouette/api/RequestHandler.scala:47: higher-kinded type should be enabled
[error] by making the implicit value scala.language.higherKinds visible.
[error] ----
[error] This can be achieved by adding the import clause 'import scala.language.higherKinds'
[error] or by setting the compiler option -language:higherKinds.
[error] See the Scaladoc for value scala.language.higherKinds for a discussion
[error] why the feature should be explicitly enabled.
[error] trait RequestHandlerBuilder[E <: Env, +R[_]] extends ExecutionContextProvider {
[error]                                        ^
[error] one error found
[error] (play-silhouette/compile:compileIncremental) Compilation failed
[error] Total time: 81 s, completed Dec 17, 2019 4:12:05 AM

This is Since 2.13.1
https://github.com/scala/scala/blob/3987e83b7cf0af7c8dcb17a08e8a040ccbe9a5e5/src/library/scala/languageFeature.scala#L35-L37
so you need to update to 2.13.1 from 2.13.0

See #573

Thanks @nafg


Footer alignment

Description
The alignment of footer content is rectified for large resolutions screen.
Fixes #38
Type of Change:
Delete irrelevant options.

Code

How Has This Been Tested?
It has been rigorously tested on different resolutions of desktop devices available using http://re-view.emmet.io.
Checklist:
Delete irrelevant options.

[ ] My PR follows the style guidelines of this project
[ ] I have performed a self-review of my own code or materials

What kind of changes you have done?
I can see a lot of indentation changes and your branch is not even with the master.


feature: go to the definition by clicking the library include path

Currently it will make vscode stuck when clicking the path to "../node_modules/circomlib/circuits/comparators.circom"
https://github.com/vuvoth/ccls/assets/31992185/9c6ff0e7-92f2-453d-94ca-1464a6028e35

Can you check this work well with new code, @chnejohnson ?

Yes, now it works well


Correction for raw affiliation  Electromechanical Engineering, ENSAM Meknes, Moulay Ismail University, Marjane 2, Meknes 50000, MOROCCO.;  Laboratory of Innovation and Systems Engineering ; Mechanical and Structural Engineering Department ; ENSAM, Moulay Ismail University, Meknes, 50000, Morocco; ENSAM-Meknes: Universite Moulay Ismail Ecole Nationale Superieure d'Arts et Metiers

Correction needed for raw affiliation  Electromechanical Engineering, ENSAM Meknes, Moulay Ismail University, Marjane 2, Meknes 50000, MOROCCO.;  Laboratory of Innovation and Systems Engineering ; Mechanical and Structural Engineering Department ; ENSAM, Moulay Ismail University, Meknes, 50000, Morocco; ENSAM-Meknes: Universite Moulay Ismail Ecole Nationale Superieure d'Arts et Metiers
raw_affiliation_name:  Electromechanical Engineering, ENSAM Meknes, Moulay Ismail University, Marjane 2, Meknes 50000, MOROCCO.;  Laboratory of Innovation and Systems Engineering ; Mechanical and Structural Engineering Department ; ENSAM, Moulay Ismail University, Meknes, 50000, Morocco; ENSAM-Meknes: Universite Moulay Ismail Ecole Nationale Superieure d'Arts et Metiers
new_rors: 04cnscd67
previous_rors: 018pp1107;04cnscd67
works_examples: W4382059278
contact: 1900197fd6407e81f787da0c9be042ca:90876d87bb8a5e79673430976e @ ensam.eu

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Fix bug introduced in #538

Description
Fix issue where certain config fields were accidentally renamed due to having the same name as variables that were targeted in the renaming PR #538
The bug was not caught during the PR since the accidental change happened within the franka_panda_client, which doesn't recompile without setting specific flags.
Type of change
Please check the options that are relevant.

[x] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
Before this PR running the hardware client would result in a YAML error.
Client runs smoothly after the change.
Testing
Tested on hardware.
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[x] I have added relevant collaborators to review the PR before merge.

lgtm; this makes me want to run a hardware test on every PR, though

I did run hw tests with the broken PR but forgot to recompile with BUILD_FRANKA=ON, and it's going to be tedious if we need to manually recompile everything for every PR. Thus I'm thinking of making a mock hardware test and adding it to CircleCI.
I'll get this fix merged first though.


Sometimes truffle-upgrades upgradeProxy doesn't set the address in the build/contracts/.json

Sometimes truffle-upgrades upgradeProxy doesn't set the address in the build/contracts/<ContractName>.json file
Expected
It should set something like
 "networks": {
    "<chainId redacted>": {
      "events": {},
      "links": {},
      "address": "<address redacted>",
      "transactionHash": "<tx hash redacted>"
    }
  },

Actual
It doesn't set the networks information
Why it's bad
In truffle console
when I ask
let i = await <Contract Name redacted>.deployed()

it outputs
Uncaught:
Error: <Contract Name redacted> has not been deployed to detected network (network/artifact mismatch)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
...

Can you reproduce this consistently? If so, please share the reproduction steps.

Closing as Truffle is deprecated.


Client Allocation Request for: Kodebox

Client Allocation Questions
Core Information

Name: Kodebox
Website / Social Media: https://kodebox.io/
Region: Asia excl. Greater China
DataCap Requested: 15TiB
Addresses to be Notarized: f16pippzh5h2sgg54npcpjgu6pialdlo2idpkwl7a
Notary Requested: dannyob

@Kodeboxkr Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi @Kodeboxkr ! Could you put this request to one of the notaries serving Asia? We concentrate at Filecoin Foundation on public data repositories and European requests. Thanks!


general: rely on MutableMapping for SmartDict, LazyDict and LaziestDict

Rely on MutableMapping for SmartDict, LazyDict and LaziestDict and don't override the following methods: __contains__, keys, items, values, get, __eq__, __ne__, pop, popitem, clear, update, and setdefault.

https://docs.python.org/2/library/collections.html#collections-abstract-base-classes
https://github.com/inveniosoftware/invenio/blob/c4d74fd3945567d43888b8e0e19154b27ea445a9/invenio/utils/datastructures.py

note: SmartDict moved into jsonalchemy package

with @jirikuncar we were talking about create a separate package for common data structures.

Separate package for common data structures: +1

Package name?

lazycollections (my preference)
lazy_collections

Superseded by Invenio 3.


feat(biome_js_parser): support defer attribute in import statements

Summary
closes: #4215

Test Plan

ok, i will follow this later


Move connected address to top of screen

[x] away from where it’s currently displayed under mint button
[x] non-interactive, flat black text. truncated
[x] confirmed no regression on desktop and mobile, doesn't affect layout or responsiveness
[x] nothing display if wallet not connected

wallet connected (desktop)

wallet connected (mobile)

no wallet connected

Lgtm!


expose correction metric

Example run:
{"ntp.peer.delay":0,"ntp.peer.poll":256,"ntp.peer.jitter":0,"ntp.peer.offset":-0.030286000765045173,"ntp.peer.stratum":2,"ntp.sys.frequency":1.6121444702148438,"ntp.stat.error":false,"ntp.correction":-0.000021913370801485144}

Does it show a big difference on the in the correction field on the hosts with the large offset?

It does:
{"ntp.peer.delay":0,"ntp.peer.poll":256,"ntp.peer.jitter":0,"ntp.peer.offset":-0.03952300176024437,"ntp.peer.stratum":2,"ntp.sys.frequency":1.6156848669052124,"ntp.stat.error":false,"ntp.correction":-0.000015550647731288336}

Edited previous comment.


All numeric values are converted to strings

I realize that one can first create a typemap for converting the data to its correct format. But is there a reason that all numeric values are converted to Strings values by default? I'm not really familiar with CS, but I've been pouring through the code trying to find out where this happens, but have had no success so far.

I'd assume this is because there's not really any way to tell the type of of the variables being returned by the RETS server unless you were to pull back the table schema first (which would slow everything down)
Example RETS query response:
<RETS ReplyCode="0" ReplyText="">
<COUNT Records="2117">
<DELIMITER value="09"/>
 <COLUMNS> ListingID ListPrice </COLUMNS>
 <DATA> 12345678 300000 </DATA>
 <DATA> 23456789 300000 </DATA>
 <DATA> 34567890 300000 </DATA>
 <DATA> 45678901 300000 </DATA>
 <DATA> 56789012 310000 </DATA>
 <DATA> 67890123 310000 </DATA>
 <DATA> 78901234 310000 </DATA>
 <DATA> 89012345 300000 </DATA>
 <DATA> 90123456 350000 </DATA>
 <DATA> 01234567 400000 </DATA>
</RETS>

Nothing in there says the type.  In the example of the last entry with a leading 0 in a number, that would be a string, but with all previous values you might have thought that value would be a number.
Example pulled from http://www.mredllc.com/rets/documents/RETS Developer Start Guide1.pdf

The reason you're not finding it is because the code in this module doesn't convert values to strings.  The start as strings, and this module simply passes them through as-is.
This is further complicated by the fact that even a value which is known to be a number could come back as a special value which means "we have a value, but we're not going to give it to you".  So you shouldn't be assuming you get a number, even for fields which are never any non-number value on the RETS server.
Rather than having this module do the effort of figuring out what type every field should be, which would incur processing overhead, the easier (and often more performant) approach is to have this module do as little as possible.  For instance, if you are streaming the data from the RETS server to a database, sometimes you never need to convert a number value to a string in your application code -- it would just be converted back to text to be sent to the db anyway.


Attention point using the Home Directory as base for bin and cluster stuffs

Attention points:

as all binaries by defautl are downloaded into ~/.furyctl/bin, it's not possible to download multiple distribution dependencies in parallel without raise errors.
if I have multiple AWS accounts and in each ones I use the same cluster name, I can't execute parallel operations without the risk to override the downloaded stuffs.

IMHO, I suggest to use the a more unique ID as apiVersion/Kind/AWS_ID/version/cluster Name
Proposed solution:

we should introduce a lockfile (and a mechanism to remove it in case the command is terminated abruptly) to avoid having parallel process overwrite the same file(s)
we should store the cluster folders in the ~/.furyctl/clusters folder (instead of the ~/.furyctl one as we are doing now)
we should use the following naming schema for the cluster folders: <cluster-name>-<region>-<kind>-<cloud-provider-id>. eg: eks-barebone-eu-west-1-EKSCluster-492816857163

relates #181 for the bin part

This was addressed by the --outdir flag


[External Request] UpdateReservation / VerifyChangeForSalesLineReserve

Please make the local procedure UpdateReservation externally available in the following tables:

table 1003 "Job Planning Line".UpdateReservation
table 5902 "Service Line".UpdateReservation
table 37 "Sales Line".VerifyChangeForSalesLineReserve

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


resultinfo ala rmb MODEUR-21

INFO: api-lint: Using api-lint version: 1.0.7
INFO: api-lint: Assessing API description files: OAS
INFO: api-lint: Processing OAS 3.0 file: src/main/resources/openapi/eusage-reports-1.0.yaml
INFO: api-lint:     did not detect any errors
ERROR: api-lint: Could not determine OAS version for file: ./src/main/resources/openapi/parameters/limit.yaml
ERROR: api-lint: Could not determine OAS version for file: ./src/main/resources/openapi/parameters/offset.yaml
INFO: api-lint: Processing OAS 3.0 file: src/main/resources/openapi/tenant-2.0.yaml
INFO: api-lint:     did not detect any errors
ERROR: api-lint: There were processing errors. See list above.

Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiLintReport.


Do not allow filter to search for empty string

Fixes https://issues.redhat.com/browse/AAH-820
Before:

After:

@sbuenafe-rh WDYT? Thanks :)

@ZitaNemeckova I think the chip category would just need to reflect the same attribute name (Task name) and then everything else looks good!


Codeium Crash

Hey Guys, I think your extension is really cool, the only thing that would keep from using it (and which has caused me to remove it from visual studio at least until this gets fixed) is this crash, which occurs multiple times per day, sometimes repeatedly right right after the previous crash. The crash freezes visual studio before causing it to restart, which is a real annoyance. I'm opening this in another pr because the stack trace and exception are different from the other crash.
I know it is caused by this extension because it only started after I installed it and stopped after I removed it.
I'm using it with VB.Net winforms and class library projects, in visual studio 2022 version 17.9.2, I have Devexpress's CodeRush extension also installed.
Here's event viewer details:
Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ObjectDisposedException
at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.ThrowIfInvalid()
at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.get_Start()
at Microsoft.VisualStudio.Text.Editor.Implementation.TextViewLineCollection.FindTextViewLineIndexContainingBufferPosition(Microsoft.VisualStudio.Text.SnapshotPoint)
at Microsoft.VisualStudio.Text.Editor.Implementation.TextViewLineCollection.GetCharacterBounds(Microsoft.VisualStudio.Text.SnapshotPoint)
at CodeiumVS.SuggestionTagger.UpdateAdornment(Microsoft.VisualStudio.Text.Editor.IWpfTextView, System.String, Int32)
at CodeiumVS.SuggestionTagger.Update()
at CodeiumVS.CodeiumCompletionHandler+d__14.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
(https://github.com/Exafunction/CodeiumVisualStudio/issues/new#) <System>
  <Provider Name=".NET Runtime" />
  <EventID Qualifiers="0">1026</EventID>
  <Version>0</Version>
  <Level>2</Level>
  <Task>0</Task>
  <Opcode>0</Opcode>
  <Keywords>0x80000000000000</Keywords>
  <TimeCreated SystemTime="2024-03-07T16:42:32.7837898Z" />
  <EventRecordID>200698</EventRecordID>
  <Correlation />
  <Execution ProcessID="0" ThreadID="0" />
  <Channel>Application</Channel>
  <Computer>XXX</Computer>
  <Security />
  </System>
(https://github.com/Exafunction/CodeiumVisualStudio/issues/new#) <EventData>
  <Data>Application: devenv.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.ObjectDisposedException at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.ThrowIfInvalid() at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.get_Start() at Microsoft.VisualStudio.Text.Editor.Implementation.TextViewLineCollection.FindTextViewLineIndexContainingBufferPosition(Microsoft.VisualStudio.Text.SnapshotPoint) at Microsoft.VisualStudio.Text.Editor.Implementation.TextViewLineCollection.GetCharacterBounds(Microsoft.VisualStudio.Text.SnapshotPoint) at CodeiumVS.SuggestionTagger.UpdateAdornment(Microsoft.VisualStudio.Text.Editor.IWpfTextView, System.String, Int32) at CodeiumVS.SuggestionTagger.Update() at CodeiumVS.CodeiumCompletionHandler+<GetCompletion>d__14.MoveNext() at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem() at System.Threading.ThreadPoolWorkQueue.Dispatch()</Data>
  </EventData>
  </Event>

I hope you guys can find a way to fix it. If you need any other details, please feel free to let me know.
Thank You

Are you on the latest version of the plugin (1.8.6)? We fixed a number of crashes in this release.

Oh, no I wasn't, I installed it on the 5th of this month but 1.8.0 got installed. Thank You for bringing that to my attention @fortenforge, I appreciate it, I'll update it and let you know if I get the crash again.

Hello @fortenforge, I got that crash again even with the update. I know it happens when I'm writing code in visual studio.
Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ObjectDisposedException
at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.ThrowIfInvalid()
at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.get_VisibilityState()
at Microsoft.VisualStudio.Text.Editor.Implementation.TextViewLineCollection.Microsoft.VisualStudio.Text.Editor.IWpfTextViewLineCollection.get_FirstVisibleLine()
at CodeiumVS.InlineGreyTextTagger.MarkDirty()
at CodeiumVS.SuggestionTagger.MarkDirty()
at CodeiumVS.SuggestionTagger.Update()
at CodeiumVS.CodeiumCompletionHandler+d__14.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
Here's my codeium debug info:
'''json
{
"url": "http://<IP_ADDRESS>:50991/?api_key=1e406eb9-3a3f-4271-928f-0cc7e65d93b0&extension_name=Codeium&extension_version=1.8.6&ide_name=visual_studio&ide_version=17.9.34701.34&locale=en-US&ide_telemetry_enabled=true&app_name=Visual Studio&web_server_url=ws://<IP_ADDRESS>:50990&has_dev_extension=false&has_index_service=true&open_file_pointer_enabled=true&diff_view_enabled=true&insert_at_cursor_enabled=true&has_enterprise_extension=false",
"connection": {
"status": "READY",
"error": {}
},
"isChatEnabled": true,
"handshake": {
"disabledTelemetry": false,
"ignoreChatTelemetrySetting": false
},
"params": {
"ideTelemetryEnabled": true,
"ready": true,
"apiKey": "1e406eb9-3a3f-4271-928f-0cc7e65d93b0",
"extensionName": "Codeium",
"extensionVersion": "1.8.6",
"ideName": "visual_studio",
"ideVersion": "17.9.34701.34",
"locale": "en-US",
"hasDevExtension": false,
"hasEnterpriseExtension": false,
"hasIndexService": true,
"appName": "Visual Studio",
"webServerUrl": "ws://<IP_ADDRESS>:50990",
"diffViewEnabled": true,
"openFilePointerEnabled": true,
"insertAtCursorEnabled": true
},
"data": {
"numMessages": 17
},
"bridge": {
"bridgeType": "null"
},
"health": {
"checkStatus": 200,
"error": {}
}
}

This crash should be fixed in 1.8.14.

Sorry to report @fortenforge, it did it again in 1.8.14

Do you have a stack trace?

Sure, so basically every time, first visual studio freezes up completely and then it crashes, although sometimes [when codeium is disabled] my visual studio will freeze up completely for a few seconds but it recovers from it after a few seconds, but when codeium is enabled, VS freezes completely to any input and it lasts a noticeably longer before VS crashes and reboots.
This is what I'm seeing in the event viewer:

Here's the stack traces for those errors:
Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ObjectDisposedException
at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.ThrowIfInvalid()
at Microsoft.VisualStudio.Text.Formatting.Implementation.FormattedLine.get_VisibilityState()
at Microsoft.VisualStudio.Text.Editor.Implementation.TextViewLineCollection.Microsoft.VisualStudio.Text.Editor.IWpfTextViewLineCollection.get_FirstVisibleLine()
at CodeiumVS.SuggestionTagger.MarkDirty()
at CodeiumVS.SuggestionTagger.Update()
at CodeiumVS.CodeiumCompletionHandler+d__14.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
And also:
Faulting application name: devenv.exe, version: 17.9.34701.34, time stamp: 0x65e1f90d
Faulting module name: KERNELBASE.dll, version: 10.0.19041.3996, time stamp: 0xb756c9ff
Exception code: 0xe0434352
Fault offset: 0x000000000002cf19
Faulting process id: 0x60c4
Faulting application start time: 0x01da7bb96f8d2809
Faulting application path: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.exe
Faulting module path: C:\WINDOWS\System32\KERNELBASE.dll
Report Id: e7ce571b-a881-44d8-9f74-0c3d57ed99c8
Faulting package full name:
Faulting package-relative application ID:
I'm using visual studio's blue theme if that matters at all.

I just noticed that there is another event, not directly labeled as an error right after the visual studio crash logs for windows error reporting, do you want any of the referenced files?
Fault bucket<PHONE_NUMBER>157475264, type 5
Event Name: CLR20r3
Response: Not available
Cab Id: 0
Problem signature:
P1: devenv.exe
P2: 17.9.34701.34
P3: 65e1f90d
P4: Microsoft.VisualStudio.Platform.VSEditor
P5: <IP_ADDRESS>890
P6: ca0ccd69
P7: 196b
P8: 12
P9: System.ObjectDisposedException
P10:
Attached files:
\?\C:\Users\XXX\AppData\Roaming\microsoft\visualstudio\17.0_bad6b01f\activitylog.xml
\?\C:\Users\XXX\AppData\Roaming\microsoft\visualstudio\17.0_bad6b01f\activitylog.setup.xml
\?\C:\Users\XXX\AppData\Local\microsoft\visualstudio\17.0_bad6b01f\devenv.exe.config
\?\C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.isolation.ini
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER4678.tmp.dmp
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER912E.tmp.WERInternalMetadata.xml
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER913F.tmp.xml
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER914C.tmp.csv
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER917C.tmp.txt
These files may be available here:
\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_devenv.exe_421baf24486b530526681a8f630e01ee95688_f7e34bca_630cfb73-48fc-4995-95d8-0b537584c28b
Analysis symbol:
Rechecking for solution: 0
Report Id: e7ce571b-a881-44d8-9f74-0c3d57ed99c8
Report Status: 268435456
Hashed bucket: 7484232ae8bf022838016ad3e27d1dc0

Hey @fortenforge, it's possible that this issue is fixed as I haven't seen it in a bit. It's also possible that there may have been a coderush issue that caused that last crash.
Thanks anyways, the extension has been working for me.


odb: add polygon writing to lefout

Adds:

POLYGON support to LEFout for libraries

Similarly
  if (polygon[0] == polygon[polygon.size() - 1]) {
    polygon.pop_back();
  }

should be moved to decomp.


Parse Error

Getting the following error when trying to run this:
$ php chainer.php demos/resources/mobydick.txt
PHP Parse error:  syntax error, unexpected '[' in /home/user/vendor/heidilabs/markov-php/src/MarkovPHP/WordChain.php on line 120
$ php -v
PHP 5.3.10-1ubuntu3.26 with Suhosin-Patch (cli) (built: Feb 13 2017 20:37:53)
Copyright (c) 1997-2012 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2012 Zend Technologies

@fredowsley PHP 5.3 is an unsupported branch and will not run code written with many modern PHP features. It has been obsolete for 2 years and 7 months as of the time you posted this issue. As of the time of this reply, the supported release PHP branches are 5.6, 7.0 and 7.1.
You are encountering that error because PHP 5.3 does not support shorthand array syntax which was added in PHP 5.4. If you cannot upgrade your version of PHP, you can replace the shorthand array syntax with the long form declaration of an empty array, but you will likely continue to encounter errors using such an old version of the interpreter.

Thank you for that detailed response! I have upgraded to a more recent version and it's working.


Third lesson

Finished Third Lesson

@koyuncuoglum95 great to see you working through the lessons! The best way to track your work is to create a fork of this repo to your account and merge your completed lessons to your own repo.
Closing this PR, as no changes to the lessons. As you have questions, feedback or an issue with any lesson please feel free to open a discussion or open a new issue. Thank you for using this curriculum!


Bonfire: Check for Palindromes

Challenge Bonfire: Check for Palindromes has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.130 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
function palindrome(str) {
  var rstr = str.split('').reverse().join('').toLowerCase().replace(/\W/g, '');
  if (rstr === str.toLowerCase().replace(/\W/g, '')) {
    return true;
  } else {
    return false;
  }
}

palindrome("eye");

Edit: Nevermind I should read more carefully. I am sorry.

rstr = str almost got me until I read lol


[Search] BadResponseException (HTTP 403, 500, etc)

https://api.jikan.moe/v3/search/anime?q=naruto shippuuden&page=1
{
  "status": 403,
  "type": "BadResponseException",
  "message": "Something went wrong, please try again later",
  "error": "403 on https://myanimelist.net/anime.php?q=naruto+shippuuden&type=0&score=0&status=0&p=0&r=0&sd=0&sm=0&sy=0&ed=0&em=0&ey=0&gx=0&c[]=a&c[]=b&c[]=c&c[]=f&c[]=d&c[]=e&c[]=g"
}

MAL is has been unstable the past few hours. Has been returning either 403, 502, 504, etc
https://www.isitdownrightnow.com/myanimelist.net.html

It really is unstable for the past few hours, but the 403 error may be a security measure against API's in general, a simple curl on your local machine would return the page data. But from a dedicated server/vps it will throw 403 forbidden (even setting UA, referer etc.).

This issue was resolved yesterday.
MAL had a downtime for an hour or two then blocked a huge number of IPs that were from cloud providers/VPNs after it came back up. This included our servers as well.
They unblocked it after 6~ hours. Unsure the exact reason this happened.
Due to this kind of instability - we're reworking how Jikan operates to prevent something like this from disrupting the service again.

I started noticing this again today, I think it's happening again.

@mysticflute Yep it is. Past 12~ hours.
Pinned issue here: https://github.com/jikan-me/jikan-rest/issues/102#issuecomment-640101348

I don't know about you but here it happens again right now...

@Bluppie05 check https://github.com/jikan-me/jikan-rest/issues/123#issuecomment-663598909


Migrate addons to controller-runtime based framework

/test integration-test

Reviews comments to be taken up in follow up PRs
/lgtm


Cloudflare free tier limits issues.

I have been using this status page for a few months now. (thanks btw ❤ )
Cloudflare sends out a 50% limit email every day, which is normal.
But today for the first time ever it sent me a 90% email.
I have not changed anything in the last 2-3 months, so im not sure what caused this.
Also i asked a friend that also uses this project, he seems to have gotten the same email/issue.
If what is happening continues, i will most likely hit the 100% limit in about an hour so.
I attached some photos.

Ill keep this thread updated if something else happens.

Hey, thanks for using it!
What cron trigger schedule do you have set up? Can you check your workers
dashboard to see past cron trigger schedules, do they seem normal -
following the schedule you have set?
On Sat, Apr 15, 2023 at 17:01 Benji @.***> wrote:

I have been using this status page for a few months now. (thanks btw ❤ )
Cloudflare sends out a 50% limit email every day, which is normal.
But today for the first time ever it sent me a 90% email.
I have not changed anything in the last 2-3 months, so im not sure what
caused this.
Also i asked a friend that also uses this project, he seems to have gotten
the same email/issue.
If what is happening continues, i will most likely hit the 100% limit in
about an hour so.
I attached some photos.
[image: image]
https://user-images.githubusercontent.com/65447501/232235551-2e2103c6-d790-491a-b0a2-1ee4ee781995.png
[image: image]
https://user-images.githubusercontent.com/65447501/232235565-5b4f3178-7728-493d-a3f3-f51663557f76.png
[image: image]
https://user-images.githubusercontent.com/65447501/232235593-06ddac20-3105-4162-9110-653929c5aedb.png
Ill keep this thread updated if something else happens.
—
Reply to this email directly, view it on GitHub
https://github.com/eidam/cf-workers-status-page/issues/129, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3NDLBTVM6OXXC37ILAHXDXBLA5RANCNFSM6AAAAAAW7P25AE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

The default 2 minute, that should be enough for the free tier and has been working for the last couple of months.
The events seem fine to me, but i dont see that long of a history unfortunately.
I mean the same thing happened to my friend as well and we both havent touch it in a while.

Thanks for the info - just to confirm, you don’t have any other Workers
scripts in your account, right?
On Sat, Apr 15, 2023 at 17:11 Benji @.***> wrote:

The default 2 minute, that should be enough for the free tier and has been
working for the last couple of months.
The events seem fine to me, but i dont see that long of a history
unfortunately.
I mean the same thing happened to my friend as well and we both havent
touch it in a while.
[image: image]
https://user-images.githubusercontent.com/65447501/232237043-06517f9c-c342-465e-8ffa-827c51fb39a4.png
[image: image]
https://user-images.githubusercontent.com/65447501/232236792-0b661667-44e6-4efc-b3ff-d606d0469d12.png
—
Reply to this email directly, view it on GitHub
https://github.com/eidam/cf-workers-status-page/issues/129#issuecomment-1509883563,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3NDLBW2D5DUSHWSXSYEW3XBLCCNANCNFSM6AAAAAAW7P25AE
.
You are receiving this because you commented.Message ID:
@.***>

Nope, thats all i use it for, and i havent touched cloudflare at all in a few weeks.

I have now reached the limit.

Yep I have the same issue it just happens out of nowhere every couple of months

So it has happened before?

I just got the Daily request limit exceeded Mail from Cloudflare, same situation as @hibenji

Got the same email, saying
You are 50% of the way to reaching one of your daily Cloudflare Workers KV free tier limits.
my cron triggers are set to 5 minutes.
it's the first time I got this email.

(I’m from Cloudflare)
Can folks who are observing this include their Cloudflare account ID and KV namespace ID - ?

EM for KV - looking at this now. Echo @elithrar comments above - please share account and namespace ID.

Here is my ids @elithrar:
Account id= 71571c8606d2bb2c159c3a610b341bda
I think these are the namespace ids:
87bd98f1d14d44ccafc5f0d8d455165a
c9ef7bc233314704b08f8304750a628d

I havent gotten the 90% email today yet, but considering that the 50% email came at about 10am today like it did yesterday, im guessing the issue still exists.
Usually it comes at around 6pm.

Monitoring the fix, which appears to be working: https://www.cloudflarestatus.com/incidents/fxhsgv1myxzg

Yep, seems to be working 👍
I was at 1.43k, i am now at 1.38k

Thanks for your help :)

@rts-rob This just happened to us. We got 50% emails every day for a few weeks, and today got a 90% email.

Hi @saewitz - thanks for letting us know. This issue is closed; can you please cut a new one or join us in our Discord server to discuss?
Please include your Cloudflare account ID and KV namespace ID - both of these values are safe to post publicly.


networking init

Adding the NetworkAttachmentDefinition list
I'll add also the detail page and the create form

/lgtm


Fullscreen in window only

A config option to force all apps on workspace to go fullscreen inside the window. Then the user will decided which app their want to really fullscreen. I only see option to rule specific app to use fullscreen.
Example is this youtube fullscreen.

what? In english please, I don't understand

He might have meant fakefullscreen type of thing, idk.
It's like fullscreen 0, the app goes full screen mode (e.g. chromium will hide tabs etc), but it is contained within its own window and the window itself doesn't go full screen.

oh ok

cool youtuber you watching there

@jiiiijiij I opened an issue with the same wish before (which was rejected).
Your browser might have the option to limit fullscreen to the browser window.
I use qutebrowser the option there is called "content.fullscreen.window".
For chrome the add-on fullscreen-anything might help.
@vaxerski I still think this would be a nice addition to hyprland.

added in cb4f7482269664dd20c373eef5d862a770df1643

Thx for picking it up so quickly!
Could you elaborate on the expected behavior of this?
I observe the following:
fullscreen keybinding:

any window toggles fullscreen, covers all other windows

fakefullscreen keybinding:

no effect on some windows; e.g. foot terminal (probably doesn't have a fullscreen function)
identical to fullscreen keybinding on other windows e.g. firefox toggles fullscreen, covers all other windows

From the thread above I would expect firefox in the second case to 'go fullscreen' without covering other windows.
Am I doing something wrong here? Or did I misinterpret something?

only tested chrome and it seemed to work.

chromium in wayland works perfectly fine.
As for firefox, yeah it seems to send its own events, will see what I can do bout those.

chromium in wayland works perfectly fine.

Indeed, it does. I was running chromium over XWayland though, and that's when I've seen the issue.

for the love of god dont

Yeah, that's fair. But still, it should work on apps running through XWayland in general.

fixed in 461fab0f27e4913993c6321625b343537aba1bdf
one thing that I noticed is that firefox will use the monitor's size in fullscreen (in some cases, for some reason) regardless of the window size, so fullscreen content may be cropped. (e.g. youtube videos)

one thing that I noticed is that firefox will use the monitor's size in fullscreen (in some cases, for some reason) regardless of the window size, so fullscreen content may be cropped. (e.g. youtube videos)

This is actually the same behavior that i had on xmonad, but the other way around for some reason (chromium was getting cropped, firefox was not), and the same (hacky) fix works in hyprland: resize window one pixel and back again in an event hook.
https://xmonad.github.io/xmonad-docs/xmonad-contrib/XMonad-Util-Hacks.html
https://xmonad.github.io/xmonad-docs/xmonad-contrib/src/XMonad.Util.Hacks.html#windowedFullscreenFixEventHook

windows will now not be allowed to change their fullscreen state if fakefullscreen is active for them. only you can with a manual keybind.

And this is preventing me implementing the same hack for hyprland with a socket2 script.
Speaking of scripting, i have questions on now to implement this and other things, but they would get pretty long and off topic, so i'll create a discussion thread
Back to the fakefullscreen though, i've found that toggling it on an mpv window with --force-window=immediate isn't preventing it from going fullscreen. I don't know if this is a separate issue from #1375 or not, but seems like one.


Releases page does not show 0.2.0

The releases page for this project does not show the new 0.2.0 release.

Fixed. Forgot to push the tag to GitHub.


Bug in Building and Image

Hi:
I get this error when building an LXDE image:
Summary: 4 tasks failed:
  /repo/recipes-app/node-red-contrib-modbus/node-red-contrib-modbus_5.14.1.bb:do_dpkg_build
  /repo/recipes-app/node-red-dashboard/node-red-dashboard_2.30.0.bb:do_dpkg_build
  /repo/recipes-app/mindconnect-node-red-contrib-mindconnect/mindconnect-node-red-contrib-mindconnect_3.12.0.bb:do_dpkg_build
  /repo/recipes-app/node-red-contrib-s7/node-red-contrib-s7_3.0.0.bb:do_dpkg_build
Summary: There were 4 ERROR messages shown, returning a non-zero exit code.
2022-02-28 06:43:31 - ERROR    - Command returned non-zero exit status 1

I've attached the full error, if you're interested. Have you seen this error before? Thanks
errors.txt

Likely same or at least similar issue like in https://github.com/siemens/meta-iot2050/issues/219.

cool. let me know if you want me to try anything

Please compare your build setup to the one mentioned there, specifically check if your have qemu-user-static installed and remove it if so (and reboot after that).

thanks Jan. that worked


Alternative approach to username verification

This is just an idea, and it may or may not be a good one.
Instead of passing usernames around between server/client and verifying them on server connection, we could just have each request usernames from Atlas based on UIDs, and if one exists (and we don't detect it to be one of the new temporary random ones), we update it from the launcher (on both clients and servers), and if not, we log it (so it's clear that a particular user is unverified).
Note: Origin usernames are updated on every /client/origin_auth and may be up to 4h out of date.
This would eliminate username spoofing issues (regardless of the mechanism used for doing it) while also working around many of the things causing the Invalid Name errors.

I've done some calculations on the logs, and Atlas will definitely be able to handle the load (~3-5 reqs/sec average, up to ~30-90 burst). Also, remember that the username fixing doesn't have to be instant, and it'll just use the original one at first. As for the initial connection messages, remember we can still do the initial username thing at the beginning, but we can be more lax about it.

Closed in favour of https://github.com/R2Northstar/Atlas/issues/15#issuecomment-1347608388.