MS Docs build error fixes

Category

[x] Content fix
[ ] New article

Related issues

fixes n/a

What's in this Pull Request?
Contains multiple fixes to existing docs as reported as errors/warnings/suggestions (that will later turn into errors/warnings) for existing content. No new or updated content, just fixes to reduce the findings in the build reports.

Docs Build status updates of commit d2ea5b6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/general-development/fast-query-language-fql-syntax-reference.md
:warning:Warning
View
Details

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:warning:Warning
View
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:warning:Warning
View
Details

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:bulb:Suggestion
View
Details

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:bulb:Suggestion
View
Details

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

docs/general-development/fast-query-language-fql-syntax-reference.md

Line 190, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#fql_string_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 191, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#fql_and_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 191, Column 203: [Warning-bookmark-not-found] Cannot find bookmark '#fql_or_operator' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#fql-operators'?
Line 191, Column 270: [Warning-bookmark-not-found] Cannot find bookmark '#fql_any_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 191, Column 339: [Warning-bookmark-not-found] Cannot find bookmark '#fql_andnot_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 191, Column 414: [Warning-bookmark-not-found] Cannot find bookmark '#fql_not_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 191, Column 483: [Warning-bookmark-not-found] Cannot find bookmark '#fql_count_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 191, Column 556: [Warning-bookmark-not-found] Cannot find bookmark '#fql_count_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#fql_near_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 205: [Warning-bookmark-not-found] Cannot find bookmark '#fql_onear_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 278: [Warning-bookmark-not-found] Cannot find bookmark '#fql_phrase_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 353: [Warning-bookmark-not-found] Cannot find bookmark '#fql_startswith_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 437: [Warning-bookmark-not-found] Cannot find bookmark '#fql_endswith_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 517: [Warning-bookmark-not-found] Cannot find bookmark '#fql_equals_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 193, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#fql_range_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 193, Column 208: [Warning-bookmark-not-found] Cannot find bookmark '#fql_int_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 193, Column 277: [Warning-bookmark-not-found] Cannot find bookmark '#fql_float_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 193, Column 350: [Warning-bookmark-not-found] Cannot find bookmark '#fql_datetime_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 193, Column 429: [Warning-bookmark-not-found] Cannot find bookmark '#fql_decimal_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 194, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#fql_xrank_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 194, Column 210: [Warning-bookmark-not-found] Cannot find bookmark '#fql_filter_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 202, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_and_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 203, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_andnot_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 204, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_any_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 205, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_count_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 206, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_datetime_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 207, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_decimal_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 208, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_endswith_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 209, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_equals_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 210, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_filter_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 211, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_float_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 212, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_int_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 213, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_near_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 214, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_not_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 215, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_onear_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 216, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_or_operator' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#fql-operators'?
Line 217, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_phrase_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 218, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_range_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 219, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_startswith_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 220, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_string_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 221, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#fql_xrank_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 271, Column 16: [Warning-bookmark-not-found] Cannot find bookmark '#fql_or_operator' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#fql-operators'?
Line 332, Column 136: [Warning-bookmark-not-found] Cannot find bookmark '#token_expressions' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 346, Column 113: [Warning-bookmark-not-found] Cannot find bookmark '#token_expressions' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 411, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#fql_endswith_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 454, Column 135: [Warning-bookmark-not-found] Cannot find bookmark '#token_expressions' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 468, Column 114: [Warning-bookmark-not-found] Cannot find bookmark '#token_expressions' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 548, Column 237: [Warning-bookmark-not-found] Cannot find bookmark '#fql_count_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 610, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#fql_near_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 646, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#fql_string_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 691, Column 50: [Warning-bookmark-not-found] Cannot find bookmark '#fql_endswith_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md

Line 1105, Column 97: [Warning-bookmark-not-found] Cannot find bookmark '#BKMK_ServerSideSolution' in 'general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md

Line 57, Column 467: [Warning-bookmark-not-found] Cannot find bookmark '#BKMK_NotificationPhoneApp' in 'general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md'.

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1810064:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/general-development/fast-query-language-fql-syntax-reference.md
:warning:Warning
View
Details

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:warning:Warning
View
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:warning:Warning
View
Details

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:bulb:Suggestion
View
Details

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:bulb:Suggestion
View
Details

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

docs/general-development/fast-query-language-fql-syntax-reference.md

Line 191, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#and_operator' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#fql-operators'?
Line 191, Column 156: [Warning-bookmark-not-found] Cannot find bookmark '#or_operator' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#fql-operators'?
Line 191, Column 176: [Warning-bookmark-not-found] Cannot find bookmark '#any_operator' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#fql-operators'?
Line 192, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#near_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 158: [Warning-bookmark-not-found] Cannot find bookmark '#onear_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 184: [Warning-bookmark-not-found] Cannot find bookmark '#phrase_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 192, Column 212: [Warning-bookmark-not-found] Cannot find bookmark '#startswith' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#starts-with'?
Line 192, Column 240: [Warning-bookmark-not-found] Cannot find bookmark '#endswith' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#ends-with'?
Line 193, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#range_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 193, Column 161: [Warning-bookmark-not-found] Cannot find bookmark '#int_operator' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#fql-operators'?
Line 193, Column 223: [Warning-bookmark-not-found] Cannot find bookmark '#fql_decimal' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#decimal'?
Line 194, Column 134: [Warning-bookmark-not-found] Cannot find bookmark '#xrank_operator' in 'general-development/fast-query-language-fql-syntax-reference.md'.
Line 208, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#endswith' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#ends-with'?
Line 219, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#startswith' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#starts-with'?
Line 411, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#endswith' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#ends-with'?
Line 691, Column 50: [Warning-bookmark-not-found] Cannot find bookmark '#endswith' in 'general-development/fast-query-language-fql-syntax-reference.md', did you mean '#ends-with'?
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md

Line 1105, Column 97: [Warning-bookmark-not-found] Cannot find bookmark '#BKMK_ServerSideSolution' in 'general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md

Line 57, Column 467: [Warning-bookmark-not-found] Cannot find bookmark '#BKMK_NotificationPhoneApp' in 'general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md'.

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1cdbc80:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:warning:Warning
View
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:warning:Warning
View
Details

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:bulb:Suggestion
View
Details

docs/general-development/fast-query-language-fql-syntax-reference.md
:bulb:Suggestion
View
Details

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:bulb:Suggestion
View
Details

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md

Line 1105, Column 97: [Warning-bookmark-not-found] Cannot find bookmark '#BKMK_ServerSideSolution' in 'general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md

Line 57, Column 467: [Warning-bookmark-not-found] Cannot find bookmark '#BKMK_NotificationPhoneApp' in 'general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md'.

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/fast-query-language-fql-syntax-reference.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4bf6595:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:bulb:Suggestion
View
Details

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:bulb:Suggestion
View
Details

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:bulb:Suggestion
View
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/fast-query-language-fql-syntax-reference.md
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c71e81b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:bulb:Suggestion
View
Details

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:bulb:Suggestion
View
Details

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:bulb:Suggestion
View
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/fast-query-language-fql-syntax-reference.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-apply-styles-to-page-fields-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-crawl-binary-large-objects-blobs-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-mashup-that-uses-an-embedded-workbook-and-bing-maps.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-windows-phone-sharepoint-list-app.md
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5cd1cdb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:white_check_mark:Succeeded
View

docs/general-development/fast-query-language-fql-syntax-reference.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-apply-styles-to-page-fields-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-crawl-binary-large-objects-blobs-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-mashup-that-uses-an-embedded-workbook-and-bing-maps.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-windows-phone-sharepoint-list-app.md
:white_check_mark:Succeeded
View

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 70f8104:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/general-development/how-to-create-report-editors-for-performancepoint-services-in-sharepoint.md
:warning:Warning
View
Details

docs/general-development/how-to-support-and-convert-sharepoint-field-types-for-windows-phone-apps.md
:warning:Warning
View
Details

docs/solution-guidance/search-api-usage-sharepoint-add-in.md
:warning:Warning
View
Details

docs/general-development/how-to-create-custom-sharepoint-server-workflow-forms-with-visual-studio-20.md
:bulb:Suggestion
View
Details

docs/general-development/how-to-create-tabular-data-source-editors-for-performancepoint-services-in-share.md
:bulb:Suggestion
View
Details

docs/solution-guidance/onedrive-for-business-customization-sharepoint-add-in.md
:bulb:Suggestion
View
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:white_check_mark:Succeeded
View

docs/general-development/fast-query-language-fql-syntax-reference.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-apply-styles-to-page-fields-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-crawl-binary-large-objects-blobs-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-mashup-that-uses-an-embedded-workbook-and-bing-maps.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-windows-phone-sharepoint-list-app.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-external-content-types-for-sql-server-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-filter-data-providers-for-performancepoint-services-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-filter-editors-for-performancepoint-services-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-report-renderers-for-performancepoint-services-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-customize-list-item-queries-and-filter-data-for-windows-phone-apps.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-customize-the-user-interface-of-a-sharepoint-list-app-for-windows-ph.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-store-and-retrieve-sharepoint-list-items-on-a-windows-phone.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-use-a-custom-security-trimmer-for-sharepoint-server-search-results.md
:white_check_mark:Succeeded
View

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-report-editors-for-performancepoint-services-in-sharepoint.md

Line 16, Column 359: [Warning-bookmark-not-found] Cannot find bookmark '#bk_example' in 'general-development/how-to-create-report-editors-for-performancepoint-services-in-sharepoint.md'.

docs/general-development/how-to-support-and-convert-sharepoint-field-types-for-windows-phone-apps.md

Line 387, Column 238: [Warning-bookmark-not-found] Cannot find bookmark '#BKMK_RegisterFunctions' in 'general-development/how-to-support-and-convert-sharepoint-field-types-for-windows-phone-apps.md'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs/solution-guidance/search-api-usage-sharepoint-add-in.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

docs/general-development/how-to-create-custom-sharepoint-server-workflow-forms-with-visual-studio-20.md

Line 257, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed.  Use a Markdown code block surrounded by triple backticks (```).

docs/solution-guidance/onedrive-for-business-customization-sharepoint-add-in.md

Line 41, Column 1: [Suggestion-duplicate-alt-text] Alt text 'Each OneDrive for Business site is its own site collection under the personal managed path, and each url is created based on the user profile. For example, if contoso-my.sharepoint.com is the main site, then John's site will be contoso-my.sharepoint.com/personal/john_contoso_com.' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning on 1/29/21.
Line 133, Column 1: [Suggestion-duplicate-alt-text] Alt text 'Each OneDrive for Business site is its own site collection under the personal managed path, and each url is created based on the user profile. For example, if contoso-my.sharepoint.com is the main site, then John's site will be contoso-my.sharepoint.com/personal/john_contoso_com.' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit fdbeb06:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/build-windows-phone-apps-that-access-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/create-a-sharepoint-workflow-app-using-visual-studio-2012.md
:white_check_mark:Succeeded
View

docs/general-development/fast-query-language-fql-syntax-reference.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-apply-styles-to-page-fields-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-configure-and-use-push-notifications-in-sharepoint-apps-for-windows.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-crawl-binary-large-objects-blobs-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-mashup-that-uses-an-embedded-workbook-and-bing-maps.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-a-windows-phone-sharepoint-list-app.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-custom-sharepoint-server-workflow-forms-with-visual-studio-20.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-external-content-types-for-sql-server-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-filter-data-providers-for-performancepoint-services-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-filter-editors-for-performancepoint-services-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-report-editors-for-performancepoint-services-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-report-renderers-for-performancepoint-services-in-sharepoint.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-create-tabular-data-source-editors-for-performancepoint-services-in-share.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-customize-list-item-queries-and-filter-data-for-windows-phone-apps.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-customize-the-user-interface-of-a-sharepoint-list-app-for-windows-ph.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-store-and-retrieve-sharepoint-list-items-on-a-windows-phone.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-support-and-convert-sharepoint-field-types-for-windows-phone-apps.md
:white_check_mark:Succeeded
View

docs/general-development/how-to-use-a-custom-security-trimmer-for-sharepoint-server-search-results.md
:white_check_mark:Succeeded
View

docs/solution-guidance/development-experience-tenant-apponly-permissions-in-sharepoint-online.md
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-01.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-02.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-03.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-04.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-05.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-06.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-07.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-08.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-09.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-10.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-11.png
:white_check_mark:Succeeded
View

docs/solution-guidance/media/development-experience-tenant-apponly-permissions-in-spo-12.png
:white_check_mark:Succeeded
View

docs/solution-guidance/onedrive-for-business-customization-sharepoint-add-in.md
:white_check_mark:Succeeded
View

docs/solution-guidance/search-api-usage-sharepoint-add-in.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


1.18.2 The result does not exist.

hammering/stone/blackstone
hammering/stone/cobbled_deepslate
The above two lists do not produce normal results.
version "wraith-fabricaeexnihilo-0.1.7+mc1.18.2.jar"

The crushed blackstone and deepslate are only available with mythic metals. The actual issue is that the recipes aren't disabled when mythic metals isn't installed. I'll fix this in the next update


Internal registry for disambiguated imports, vars

- Move functionality in the moq package partially into
  internal/{registry,template}.
- Leverage registry to assign unique package and variable/method
  parameter names. Use import aliases if present in interface source
  package.

BREAKING CHANGE: When the interface definition does not mention the
parameter names, the field names in call info anonymous struct will be
different.

The new field names are generated using the type info (string -> s,
int -> n, chan int -> intCh, []MyType -> myTypes, map[string]int ->
stringToInt etc.).

For example, for a string parameter previously if the field name was
'In1', the new field could be 'S' or 'S1' (depends on number of
string method parameters).

Closes #68, #94
Replaces and closes #63, #120, #121, #127
TODO:

[x] Add tests
[x] Godocs

@matryer this is a significant refactor and would be very good to get a review.
edit: Presentation deck - https://docs.google.com/presentation/d/1-HVOygCVpQQ_8ikE2_OYzlvuH1NYI3wT02PWn0Onpcc/edit?usp=sharing, which

enumerates the problems that this PR tries to solve
compares with existing PRs
walks through the changes being done in this PR.

@sudo-suhas We have the situation described in #94. I did a test with this PR and I can confirm, that it worked.
Regarding the breaking change, could you provide an example, that illustrates when and how the breaking change could potentially affect existing (test) code.

@breml an example of the breaking change is present in one of the 'golden' files generated via tests - https://github.com/matryer/moq/pull/141/files#diff-f8cb62335f3c482f132a362ff53cecc339a89fabfdc2ed25539b283308509678R36-R39

@breml What do you think about this? I'm not familiar with the key differences between this PR and #94.

@matryer this PR fixes the issue reported in #94. There are other PRs which also attempt to do the same. The difference would be that this introduces some abstraction and splits the Mocker into more manageable pieces rather than trying to fit the disambiguation logic for imports and variables into the existing type.

@matryer I spent some time to have a more in depth look at this PR.
TLDR: The result seams good, at least it worked for me. The PR as a whole is really difficult to review.
I have the following thoughts about this PR:

Generally, I think the the improvements, that are introduced with this PR are very important for moq. I also think, the design decision to use a registry to keep track of the used names is a good one. So from this point of view, I think this PR is a very good step for moq to solve these issues.
As mentioned in my previous comment, it solves issue #94 for me in a particular situation I had the other week. In the past I now and then observed similar problems especially with name clashes between packages and parameter names. I normally worked around the problem by choosing different names for the parameters to prevent the name clash. I think, I also observed the situation in #68.
From a review point of view, this PR is really difficult, because it changes a lot in a single commit. For example I would like to have the tests and the changes to moq in a separate commit, such that I as a reviewer can easily follow the changes made and reason about the effects of the change. This PR combines multiple things like refactoring the package/directory structure (introduction of internal package), adding the registry, introduce templates, introduce breaking changes to the generated mocks, moving tests to a new format (explicit tests to golden files) and so on. So from this point of view, I would wish, these changes are split into multiple commits or event PR. A good example for this is pkg/moq/moq.go. There are so many changes to this single file, I do not have the time to really go through and understand each change.
I am not really sure about the decision to use the type information for the generated variable names. To prefix variable names with a type dependent prefix does look like code smell to me, especially in a statically typed language. I think there are other ways to address the name clash issue. That being said, I like the MoqParam suffix. So maybe this could have been handled all the way down by using this (or a similar) suffix to moq-ize the variable names.
The new packages internal/registry and internal/template do not really have coverage by unit tests, so this makes it even more difficult to get a good feeling about the changes introduced by this PR. Chances are, that these packages are covered by the tests in pkg/moq, but again, this is hard to tell.

With all that said, to me the question is, are we willing to merge this PR to fix the before mentioned issues while taking the risk, that other things might be broken, due to the difficulty to properly review this PR and due to the missing tests/coverage for certain areas of the code.

@breml Thank you for taking the time to review the changes. I appreciate it very much. I do have some clarifications though.

This PR combines multiple things like refactoring the package/directory structure (introduction of internal package), adding the registry, introduce templates, introduce breaking changes to the generated mocks ...

I agree that the PR does a lot of changes. That's partly because I was (and am) not sure how to split some of the changes. For example, I am not sure how I can split the internal/registry+internal/template refactor because the template has to reference the registry types to reflect the changes made while resolving conflicts. While it is no way a justification, I think you would be able to understand that there was also a limit on the time I could dedicate for doing the changes.

moving tests to a new format (explicit tests to golden files)_and so on.

The golden file tests were added some time back. While I was adding new tests, I moved most of the existing golden file tests into a single table-driven one. I have added a commit which refactors the existing tests in a separate commit.

A good example for this is pkg/moq/moq.go. There are so many changes to this single file, I do not have the time to really go through and understand each change.

With the introduction of internal/registry, I don't think the changes in pkg/moq/moq.go could have been avoided. That's not to downplay the difficulty of reviewing the changes. Instead, perhaps, it would be better to view only the resulting file. I do believe that the file now is a lot simpler to read since a lot of the heavy lifting is moved to the registry.

I am not really sure about the decision to use the type information for the generated variable names. To prefix variable names with a type-dependent prefix does look like code smell to me, especially in a statically typed language. I think there are other ways to address the name clash issue.

The generated names for method parameters is used only if there wasn't one defined in the interface definition (or was _) to begin with. The type names are not prefixed to variable names otherwise. And with regards to the generated names when none were present, I would argue that they are still better than in1/in2/in3.... And name classes with imported packages are resolved by appending MoqParam. Name clash with variables is resolved by a serial number suffix (myName1,myName2 etc.).

The new packages internal/registry and internal/template do not really have coverage by unit tests, so this makes it even more difficult to get a good feeling about the changes introduced by this PR.

This is mostly because I am not sure how I can test these. Consider registry.Var - how do I generate an instance of types.Var with the appropriate type, package etc.? I am not sure. If I were to try to use the testpackages for this, that would not be very different from the current tests in pkg/moq.
All that said, I am still open to listing the specific steps we could take to make the PR easier to review and also improve the confidence for merging in the changes. But I would need your help to figure out what those steps need to be.

@sudo-suhas Thanks for your reply. As mentioned already in my first review comment, I think this PR brings a lot of improvement. I consider myself a regular user of moq and I contributed some smaller PR in the past. But I am not familiar with the whole code base of moq in depth. @matryer invited me to share my thoughts and this is what I did. No offence intended.
I spent again some time on this PR and I have the following additional input for you:
Generate an instance of types.Var:
This can be as follows:
import "go/types"

var x = types.NewVar(token.NoPos, nil, "variablename", types.Universe.Lookup("int").Type())

sync package edge case
For the following interface, the generation of the mock failed:
package syncimport

import (
	stdsync "sync"

	sync "github.com/matryer/moq/pkg/moq/testpackages/syncimport/sync"
)

type Syncer interface {
	Blah(s sync.Thing, wg *stdsync.WaitGroup)
}

Where package github.com/matryer/moq/pkg/moq/testpackages/syncimport/sync is:
package sync

type Thing string

Maybe I came across as defensive 🙈 but I was not offended in the least. I will find some time to incorporate the helpful input you have provided.

I made some improvements to the tests to further improve coverage:

Hope this is sufficiently high coverage for the internal/{registry, template} packages.

@sudo-suhas Would you be up for a quick 15 minute screenshare some time to go through this?

@sudo-suhas Would you be up for a quick 15 minute screenshare some time to go through this?

Sure @matryer, can do. Should we chalk out the time and tool via Twitter DMs?

Sure @matryer, can do. Should we chalk out the time and tool via Twitter DMs?

Yes, good idea. I’m @matryer on Twitter.

On 5 Jan 2021, at 10:43, Suhas Karanth<EMAIL_ADDRESS>wrote:
Sure @matryer, can do. Should we chalk out the time and tool via Twitter DMs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, good idea. I’m @matryer on Twitter.

On 5 Jan 2021, at 10:43, Suhas Karanth<EMAIL_ADDRESS>wrote:
Sure @matryer, can do. Should we chalk out the time and tool via Twitter DMs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@matryer, @sudo-suhas Did it workout with your direct chat about this PR? What are the conclusions?

@matryer, @sudo-suhas Did it workout with your direct chat about this PR? What are the conclusions?

No, not yet. We will try to sort it out soon.

No, not yet. We will try to sort it out soon.

@matryer I have created a deck which

enumerates through the problems that this PR tries to solve
compares with existing PRs
walks through the changes being done in this PR.

Please check it out - https://docs.google.com/presentation/d/1-HVOygCVpQQ_8ikE2_OYzlvuH1NYI3wT02PWn0Onpcc/edit?usp=sharing.

@matryer I have created a deck which

enumerates through the problems that this PR tries to solve
compares with existing PRs
walks through the changes being done in this PR.

Please check it out - https://docs.google.com/presentation/d/1-HVOygCVpQQ_8ikE2_OYzlvuH1NYI3wT02PWn0Onpcc/edit?usp=sharing.

This is great work. And the overview by @sudo-suhas is outstanding.

Thank you @matryer for your kind words 🙏🏼
With regards to the tagged release v0.1.6, since this was a breaking change, it should have been v0.2.0, CMIIW.

@sudo-suhas ahh yeah - that's a good point. Do you think it's worth removing the release and retagging? Or has that ship sailed now?
Technically, moq hasn't yet reached v1, but the last thing we want is to break things for those using this tool.

The correct way to handle it would be to release v0.1.7 which would be equivalent to v0.1.4 (what happened to v0.1.5? 🙈) and then release v0.2.0 which would be equivalent to [v0.1.6].

What's the advantage of bumping the minor release. Is this respected by tools, or just a better signal to moq users?

v0.1.5 got borked and I didn't want to risk having a bad release. 😬

To the best of my understanding, for v0 semantic versioning, bumping the minor version indicates a breaking change while incrementing the patch version is expected to add new backwards-compatible features.

Oh right, in modules you mean? Yeah ok, it's worth doing then.
I'm away from my computer for a bit, do you have the right permissions to do a release?

Have created both releases as discussed.
Conclusion: Use moq v0.2.0 to get the changes made in this PR.

Thanks Suhas. 🎉
On Tue, 2 Feb 2021 at 07:30, Suhas Karanth<EMAIL_ADDRESS>wrote:

Have created both releases as discussed.
Conclusion: Use moq v0.2.0
https://github.com/matryer/moq/releases/tag/v0.2.0 to get the changes
made in this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/matryer/moq/pull/141#issuecomment-771430390, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAY2G3DMYUTDVC5DZXK3VTS46SZ7ANCNFSM4UIOVAMQ
.

Thanks @sudo-suhas and @matryer for the great work, this is very much appreciated.


[FEATURE]: require convenient hybrid_parallel example

Describe the feature
Most users do not have 64 GPUs to try these config, maybe use less resource?
https://github.com/hpcaitech/ColossalAI-Examples/tree/main/image/vision_transformer/hybrid_parallel

ViT+CIFAR example will come soon.

We have updated a lot. This issue was closed due to inactivity. Thanks.
https://github.com/hpcaitech/ColossalAI/tree/main/examples


DetectCategoryURLs & DetectCategoryPaginationURLs returns all taxonomies

A few issues here:

This class is named incorrectly for what it does. Suggest DetectTaxonomyPaginationURLs or DetectCustomTaxonomyPaginationURLs depending on the below
Do we want it to cover ALL taxonomies or just custom ones? Are there detectors for any other taxonomies returning duplicate URLs?

It would be nice to break it down to:

categories
tags
custom taxonomies

and paginations for all of those, where possible.
We de-duplicate at the end, so I'm less concerned about detecting too much vs not enough, if there is some double-up.
Happy for you to make the call regarding this area

Hmm. If we split this up into DetectCategoryURLs, DetectTagURLs and DetectCustomTaxonomyURLs we get a lot of duplicate code and violate DRY. In fact the code for all 3 classes would be identical except for the argument passed to get_taxonomies. This would also result in 6 detection classes to maintain instead of 2 when we include the pagination version of each.
Sidenote: In both cases we're going to need a filter for which taxonomies to crawl which we don't currently have.
The logical breakup of built-in and custom taxonomies into separate classes makes sense, as does joining them all into a single detection class as all behavior between custom and built-in is the same so it's just a personal preference thing. We'll need to use this same philosophy for Posts and custom post types. I'm happy to go either way on this though. Let me know and I'll make it happen.
@john-shaffer do you have any thoughts to add?

I haven't looked at the detection code much, but if it's identical apart from a change of argument, then it makes sense to keep it all in one class.


One million records

I have a data, there are one million records, how to use this component, because I found that when the data from the server to get all the data
thanks

I also face this issue, and I find that the default implementation of DataSource is LocalDataSource, so we can implement a RemoteDataSource to fetch and filter the records from the server side, is it right?

I notice that "Local data source (Server/API DataSource is on its way)" in the wiki, is there any timeline of this feature?

+1

+1

Hey Guys, we released a beta version of the server data source under '0.4.0-2' version. Here https://github.com/akveo/ng2-smart-table/blob/master/demo/src/app/pages/demo/components/advanced-example-server.component.ts you can find an example of how to implement it, and here https://github.com/akveo/ng2-smart-table/blob/master/src/ng2-smart-table/lib/data-source/server/server-source.conf.ts#L22 a list of configurations available for the server data source.
Please let us know if you have any questions and your feedback is much appreciated.

I think you shouldn't create API adapter that assumes what would be API interface. ServerDataSource you created is a good example, but as there is no single version of proper REST API, or maybe someone would like to use Falcor or GraphQL, there is no point implementing specific API interface. Better if you made proper documentation of writing on DataSource.

Hi @sielay, we definitely thought of it, that there is no standardised version of REST API and moreover there are plenty of other API interfaces.
But anyway, we decided to create this one for two cases:

when a user doesn't have API and could develop it in the format suggested by the library, and then just turn the ng2-smart-table on with no (or with minor) modifications.
secondly working server data source is a good example (as you noticed) of creating your own.

The current version is still in the development and there is a list of modifications we need to make, but at least it gives a general idea on how to create your own API data source version for your needs.
Let us know your thoughts.

@nnixaa that is a good point. From what I found is that LocalDataSource is a far better example than ServerDatasource. The second is too opinionated for me. It would be nice to expose DataSource, so I don't have to extend LocalDataSource (but I can live with that). If you go further with LocalDataSource you need to add easy support for headers, as mostly authentication (like with JWT) will require it.

+1 for headers support, it would be very helpful

@gvital3230  The way how I did it so far
import { Injectable } from '@angular/core';
import { Http, Headers, Response } from '@angular/http';
import { Observable } from 'rxjs';
import 'rxjs/add/operator/map'

@Injectable()
export class ApiService {
    public token: string;
    private endpoint: string = 'MYENDPOINT';

    constructor(private http: Http) {}

    private process(response:Response) {
        let json = response.json();
        if (json && json.errorMessage) {
            throw new Error(json.errorMessage);
        }
        return json;
    }

    private processError(error: any) {
        let
            errMsg = (error.message) ? error.message : error.status ? `${error.status} - ${error.statusText}` : 'Server error';
        console.error(errMsg); // log to console instead
        return Observable.throw(errMsg);
    }

    getHeaders() {
        let headers = new Headers();
        headers.append('Content-Type', 'application/json');
        if(this.token) {
            headers.append('Authorization', this.token);
        }
        return {
            headers: headers
        };
    }

    get(url) {
        return this
            .http
            .get(this.endpoint + url, this.getHeaders())
            .toPromise()
            .then(this.process)
            .catch(this.processError);
    }

    post(url, data) {
        return this
            .http
            .post(this.endpoint+ url, data, this.getHeaders())
            .toPromise()
            .then(this.process);
    }

    put(url, data) {
        return this
            .http
            .put(this.endpoint+ url, data, this.getHeaders())
            .toPromise()
            .then(this.process)
            .catch(this.processError);
    }

    apiURL(magazine) {
        return this.endpoint
    }

    delete(url) {
        return this
            .http
            .delete(this.endpoint+ url, this.getHeaders())
            .toPromise()
            .then(this.process)
            .catch(this.processError);
    }

    setToken(token) {
        localStorage.setItem('ssid', token);
        this.token = token;
    }

}

and then my source
import {Injectable} from '@angular/core';
import {ApiService} from '...';
import {LocalDataSource} from '...';

@Injectable()
export class MyTableLoadSource extends LocalDataSource {

  busy: Promise<any>;

  constructor(private api:ApiService) {
    super(null);
  }

 getElements(): Promise<any> {
    this.busy = new Promise(resolve => {});
    return this.api
        .get('SOMERESOURCE')
        .then(data => this.data = data);
  }

}

Later you can extend it by filtering etc other ideas about your API. It's not basing on latest version of code, so guys might simplified few things already.

@sielay tried your code but am getting following error

EXCEPTION: Uncaught (in promise): TypeError: Cannot read property 'get' of undefined

can you please tell me what is the error, am creating a another parameter in get() for APIService and passing it in componenets
Code modified APIService
    get(url,request) {
        return this
            .http
            .get(this.endpoint + url,request, this.getHeaders())
            .toPromise()
            .then(this.process)
            .catch(this.processError);
    }

App.Component

getElements(): Promise {
this.busy = new Promise(resolve => {});
return this.api
.get('http://mts101:83/api/P2P/GetP2PReviewList',JSON.stringify({"LendorID": 1}))
.then(data => this.data = data);
}

@DeveBj
You need to add
import {ApiService} from '...';
and
constructor(private api:ApiService) {
  super(null);
}

I have the above working but I'm still unable to set the pagination based on the response from the API, is this possible? i.e. set a total and page from the API so that large datasets can be partially loaded for performance?

@daveykane  Were you able to do that? Can you please share an example.

I'm trying to add total record count fetched from my first API call when the page loads initially. Based on the count I will come to know the total number of pages, and in turn based on the page click will fire appropriate API calls to populate data. Is this possible using NG2-Smart-Table? I am planning to write my own custom component for pagination and do the above task.

did anyone got the solution??

Hi, in case it helps others too, I initially got slightly misled by @nnixaa's post from 26th Oct 2016 and thought that the ServerDataSource was only in a beta branch of the code (0.4.0-2) but I've realised it's in the main branch, with a live demo (second example at that link) and demo source (slightly different link from before). I am pretty sure that I've understood correctly that it's still a beta feature, though?
I was also wondering, would be possible to customise ServerDataSource to the user's own API by providing callbacks to allow the user to modify things just before the http call and to extract things (i.e. total rows and data objects) afterwards? (That works for customising server-side autocomplete callbacks in the Select2 library, which I've used.)

I wrote a custom datasource to use with loopback.
It's my first implementation:
import { BaseLoopBackApi, LoopBackFilter } from '../client/sdk';
import { map } from 'rxjs/operators';
import { LocalDataSource } from 'ng2-smart-table';

export class LoopbackDataSource extends LocalDataSource {

    protected lastRequestCount: number = 0;

    constructor(protected api: BaseLoopBackApi, protected columns: Object, protected idName: string = 'id') {
        super();
    }

    prepend(element: any): Promise<any> {
        return this.api.create(element).pipe(map(res => {
            return super.prepend(res);
        })).toPromise();
    }

    add(element: any): Promise<any> {
        return this.api.create(element).pipe(map(res => {
            return super.add(res);
        })).toPromise();
    }

    update(element: any, values: any): Promise<any> {
        return new Promise((resolve, reject) => {
            this.api.updateAttributes(element[this.idName], values).subscribe((result) => {
                // it's a nice trick from https://github.com/akveo/ng2-smart-table/issues/195#issuecomment-311799579
                element = Object.assign(element, result);
                this.emitOnUpdated(element);
                this.emitOnChanged('update');
                resolve();
            }, err => {
                reject(err);
            });
        });
    }

    remove(element: any): Promise<any> {
        return this.api.deleteById(element[this.idName]).pipe(map(res => {
            return super.remove(element);
        })).toPromise();
    }

    count(): number {
        return this.lastRequestCount;
    }

    getElements(): Promise<any> {
        let filter = this.addSortRequestParams({});
        filter = this.addFilterRequestParams(filter);
        filter = this.addPagerRequestParams(filter);

        this.api.count(filter.where).subscribe((result) => {
            this.lastRequestCount = result.count;
        });

        return this.api.find(filter).pipe(map(res => {
            this.data = res;
            return this.data;
        })).toPromise();
    }

    protected addSortRequestParams(filter: LoopBackFilter): LoopBackFilter {
        if (this.sortConf) {
            const order = [];
            this.sortConf.forEach((fieldConf) => {
                order.push(fieldConf.field + ' ' + fieldConf.direction.toUpperCase());
            });
            filter.order = order;
        }

        return filter;
    }

    protected addFilterRequestParams(filter: LoopBackFilter): LoopBackFilter {
        if (this.filterConf.filters) {
            const where = {};
            this.filterConf.filters.forEach((fieldConf: any) => {
                if (fieldConf['search']) {
                    if (this.columns[fieldConf['field']].type === 'string') {
                        where[fieldConf['field']] = { like: fieldConf['search'], options: 'i' };
                    } else {
                        where[fieldConf['field']] = fieldConf['search'];
                    }
                }
            });
            filter.where = where;
        }

        return filter;
    }

    protected addPagerRequestParams(filter: LoopBackFilter): LoopBackFilter {
        if (this.pagingConf && this.pagingConf['page'] && this.pagingConf['perPage']) {
            filter.skip = this.pagingConf['page'] - 1;
            filter.limit = this.pagingConf['perPage'];
        }

        return filter;
    }
}

I notice that "Local data source (Server/API DataSource is on its way)" in the wiki, is there any timeline of this feature?

I have impletement Server side data source . and it is working finely, pagination is also working, just facing issue with filtering data in my ng2-smart-table.

Anyone here could tell me how can I make pagination using ng2 smart table and graphql ?


Revert "Add django_extensions"

This reverts commit e0ca396f1ea2ee91fe1b0d8d9c68ec46b08cdcf4.
This isn't currently being used and is causing errors when running migrations
cc @symroe

Changes Unknown when pulling 8c7659c46e7567673b3a1f4c5c0585034ebacf0c on remove-django-extensions into ** on master**.

Thanks for the explanation Mark. That was indeed the error I was seeing. It's more relevant to setting up a new environment from scratch so I'll continue it in #123

This is actually superseded by #128


Add option to use multiple batches for a single step of power iteration

Currently, batch sizes of ~128 can still exhibit high variance in the eigenvalue estimates. It would be useful to add the ability to take a single step with multiple batches to approach vanilla power iteration to improve this.

This is a noob question, but doesn't the DataLoader being passed in determine the batch size? i.e. if you wanted to compute the estimate on more data, why not simply pass in a loader with a larger batch size?

It's true that you can modify the dataloader batch size, but then you're limited to the max batch size you can fit on your GPUs. If you want to do vanilla power iteration, for example, you need to feed in the whole dataset each time.

The implementation doesn't seem to work currently; when the DatLoader uses a batch size > 512 (which is the default max_size), this part crashes:
 84             if grad_vec:
 85                 grad_vec += torch.cat([g.contiguous().view(-1) for g in grad_dict])
 86             else:
 87                 grad_vec = torch.cat([g.contiguous().view(-1) for g in grad_dict])

because you grad_vec is not a boolean anymore in the second iteration. If there is only one chunk, the loop only runs once.

Maybe use grad_vec = None and then later test for if grad_vec is not None?


Running applications not shown in the "Dock"

Running applications are not shown in the Plank "Dock". For example, here I am running Inkscape yet its icon is absent from the "Dock":

If you want that behaviour, open the plank preferences (hold <CTRL> and right-click on an icon). Enable Show Unpinned under Behaviour.

Thanks for the hint @mrclksr. Could this be made the default? I think it is what most users would expect, coming from other systems such Windows, Mac, Xfce and so on.
By the way, the German translation for this configuration item is completely incomprehensible, but I guess I will report this upstream.

I agree with @probonopd. This should be the default setting.

Thank you very much @mrclksr :+1: These small touches are really important for newcomers.


Removes the gas reserve which is unused in our deployed versions

While this increases the best case gas cost, it decreases the real one as we haven't been using the reserves.

Coverage decreased (-0.7%) to 93.774% when pulling 4be95d9ee900c021ed5084d97e83190795bd25a5 on paul/refactor/remove_gas_reserve into 339d02b49108cde4a9940ea2838bac2e8200575a on main.


Dart2JS can't compile with generic method named set

https://dartpad.dartlang.org/0e7d8c32d6ad60967d6198ef8f70090a
main() {
  new Foo().set();
}

class Foo {
  void set<T>() => print('ran');
}

Error compiling to JavaScript:
main.dart:6:3:
Error: Unexpected token 'void'.
  void set<T>() => print('ran');
  ^^^^
main.dart:2:3:
Warning: The method 'set' is not defined for the class 'Foo'.
  new Foo().set();
  ^^^^^^^^^^^^^^^
Error: Compilation failed.

Originally reported at https://github.com/dart-lang/angular/issues/582 - cc @JackHerring, @jrote1
We allow the method name without a generic argument, and we allow the generic argument with a different method name - This seems to be a small gap in our parsing.

There is a similar bug for get you can probably de-dupe with.

yep, likely the same issue as https://github.com/dart-lang/sdk/issues/29349

Ah yeah same issue - that one looks like it has more detail.


Fixing run.sh

Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[x] Optimization
[ ] Documentation Update

Description
Seeing failures due to a change in how we orchestrate the test. See the errors here : https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/network-perf-v2/252/console

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

/lgtm
/approve


Popup Renders Incorrectly

Developing a detailed game using Kivy and using popups for some player interaction. Often, the Popup displays very badly. Cannot reproduce this with a simple click to display Popup, but using some threading shows it up to 25% of the time and my game uses threading. Here is an extremely simplified code that displays the problem when you click on 'Multiple Popups' button (does 20 popups sequentially, using a timer):
from kivy.app import App
from kivy.uix.relativelayout import RelativeLayout
from kivy.uix.boxlayout import BoxLayout
from kivy.uix.popup import Popup
from kivy.uix.button import Button
from kivy.uix.label import Label

from threading import *

class TheTest(RelativeLayout):
    def __init__(self, *args):
        RelativeLayout.__init__(self, *args)
        self.popButton = Button(text='Popup', size_hint=(0.2, 0.2), pos_hint={'center_x': 0.5, 'y': 0.6})
        self.multiplePopups = Button(text='Multiple Popups', size_hint=(0.2, 0.2), pos_hint={'center_x': 0.5, 'y': 0.4})
        self.quitButton = Button(text='Quit', size_hint=(0.2, 0.2), pos_hint={'center_x': 0.5, 'y': 0.2})
        self.popButton.bind(on_press=self.do_popup)
        self.quitButton.bind(on_press=self.do_quit)
        self.multiplePopups.bind(on_press=self.start_multiple_popups)
        self.add_widget(self.popButton)
        self.add_widget(self.quitButton)
        self.add_widget(self.multiplePopups)
        self.pop_count = 0
        self.max_pops = 20

    def do_popup(self, *args):
        boxlayout = BoxLayout(orientation='vertical')
        label = Label(text='This is a Label')
        boxlayout.add_widget(label)
        label = Label(text='This is another Label')
        boxlayout.add_widget(label)
        label = Label(text='This is yet another Label')
        boxlayout.add_widget(label)
        button = Button(text='OK')
        button.bind(on_press=self.popup_dismiss)
        boxlayout.add_widget(button)
        if self.pop_count > 0:
            title = 'Test is test #' + str(self.pop_count)
        else:
            title = 'This is a Test'
        self.popup = Popup(title=title, content=boxlayout, size_hint=(0.5, 0.5))
        self.popup.open()

    def popup_dismiss(self, *args):
        self.popup.dismiss()

    def do_quit(self, *args):
        app.stop()

    def next_popup(self, *args):
        self.popup.dismiss()
        if self.pop_count >= self.max_pops:
            return
        self.pop_count += 1
        self.do_popup()
        t = Timer(0.5, self.next_popup)
        t.start()

    def start_multiple_popups(self, *args):
        self.pop_count = 1;
        self.do_popup()
        t = Timer(0.5, self.next_popup)
        t.start()

class TesterApp(App):
    def build(self):
        return TheTest()

 if __name__ == '__main__':
    app = TesterApp()
    app.run()

Here is the debug log:
kivy_16-12-14_30.txt
Here is the expected popup display:

And here some examples of the bad rendering:

Seems like the layout wasn't even built properly yet it was used. What happens if you change framerate to something higher? Kivy is by default at 60fps, navigate to .kivy folder and change it in config.ini file to something higher.

KeyWeeUsr, you may be on to something. Just based on my own testing, it seems that when the max fps is set to 60, I get the most errors. Changing it to higher or lower values seem to decrease the error rate. A setting of about 5fps seems to eliminate the errors and triple digit settings seem to drastically reduce the error rate, but not eliminate it. Of course, these are not scientifically calculated error rates.

@DaytonaJohn, Timer executes the method in a thread, but most of kivy is not thread-safe. You could delay the call with Clock.schedule_once, which will run your method in the main thread. Please reopen with a new example if the bug is still present without threading. Make sure to also test on kivy master.

Indeed, that fixes the code and my real app. The only mention of this that I could find in the API documentation is under kivy.clock. Perhaps this should be mentioned a bit more prominently.


CASMTRIAGE-6548 add the execution of upload-rebuild-templates.sh before running IUF

Description
This changes adds the execution of upload-rebuild-templates.sh before running IUF steps. This updates CSM product versions and makes sure the IUF workflowTemplates used by Argo are updated.
This is necessary because we ran into a specific case where IUF was trying to install the incorrect product version. We believe this happened because of an ordering issue, where a newer version of docs-csm rpm is installed after a CSM upgrade. If a newer version of docs-csm is installed but this script is not run, then IUF might be referencing old versions. This script is run in prerequisistes.sh which is likely why we don't run into this problem more often.

Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.5


windows_certificate resource not idempotent on create action

Cookbook version
3.1.0
Chef-client version
13.1.31
Platform Details
Windows Server 2012 R2 on Azure
Scenario:
Importing a root and intermediate certificate executes on each run
Steps to Reproduce:
# import root certificate
windows_certificate File.join(node['jjk_ts_base']['chef_local_certificate_path'], node['jjk_ts_transport_webserver_website_sitename']['website_root_cert_file_name']) do
  store_name 'ROOT'
  action :create
end

# import intermediate certificate
windows_certificate File.join(node['jjk_ts_base']['chef_local_certificate_path'], node['jjk_ts_transport_webserver_website_sitename']['website_intermediate_cert_file_name']) do
  store_name 'CA'
  action :create
end

Expected Result:
Expected that this will execute only when the certificate is not installed.
Actual Result:
The resources execute on each chef run:
  * windows_certificate[c:/jjktschef/certificates/jjk-techservices-ca.cert.pem] action create[2017-06-02T16:19:44-05:00] INFO: Processing windows_certificate[c:/jjktschef/certificates/jjk-techservices-ca.cert.pem] action create (jjk_ts_transport_webserver_website_sitename::default line 62)

    - adding certificate c:/jjktschef/certificates/jjk-techservices-ca.cert.pem into ROOT to LocalMachine\ROOT
    * powershell_script[c:/jjktschef/certificates/jjk-techservices-ca.cert.pem] action run[2017-06-02T16:19:45-05:00] INFO: Processing powershell_script[c:/jjktschef/certificates/jjk-techservices-ca.cert.pem] action run (c:/chef/cache/cookbooks/windows/resources/certificate.rb line 39)
[2017-06-02T16:19:45-05:00] INFO: Processing powershell_script[Guard resource] action run (dynamically defined)
True
[2017-06-02T16:19:45-05:00] INFO: powershell_script[Guard resource] ran successfully
 (skipped due to not_if)

  * windows_certificate[c:/jjktschef/certificates/jjk-techservices-intermediate.cert.pem] action create[2017-06-02T16:19:45-05:00] INFO: Processing windows_certificate[c:/jjktschef/certificates/jjk-techservices-intermediate.cert.pem] action create (jjk_ts_transport_webserver_website_sitename::default line 68)

    - adding certificate c:/jjktschef/certificates/jjk-techservices-intermediate.cert.pem into CA to LocalMachine\CA
    * powershell_script[c:/jjktschef/certificates/jjk-techservices-intermediate.cert.pem] action run[2017-06-02T16:19:45-05:00] INFO: Processing powershell_script[c:/jjktschef/certificates/jjk-techservices-intermediate.cert.pem] action run (c:/chef/cache/cookbooks/windows/resources/certificate.rb line 39)
[2017-06-02T16:19:45-05:00] INFO: Processing powershell_script[Guard resource] action run (dynamically defined)
True
[2017-06-02T16:19:46-05:00] INFO: powershell_script[Guard resource] ran successfully
 (skipped due to not_if)
...
Chef Client finished, 2/209 resources updated in 01 minutes 05 seconds

Noticed this as well after upgrading from 2.1 to 3.1 windows cookbook.

+1 Same issue in 3.1.2

Not to be an echo, but this is also happening in 3.1.3


Prevent double index lookup in restic cat

What is the purpose of this change? What does it change?
restic cat has to do two Lookups to find a blob. This PR introduces an error type for LoadBlob to signal that a blob is not found in the index, so that cat can check for this.
Was the change discussed in an issue or in the forum before?
In a comment on #2640.
Checklist

[x] I have read the Contribution Guidelines
[x] I have enabled maintainer edits for this PR
[x] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Closing this as it's replaced by #2789 and, in hindsight, the duplicate index lookup inside cat is not worth the additional complexity.

Fair enough.


🐛 Overlapping terminal output

Environment

 $ rome rage --summary
Environment Variables
  Object {
    COLORTERM: "truecolor"
    LANG: "en_US.UTF-8"
    PATH: "/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/Yasser/bin:/Users/Yasser/bin"
    TERM: "xterm-256color"
    TERM_PROGRAM: "vscode"
    USER: "Yasser"
  }

User Config
  unset

Rome Version
  0.0.26-dev

Node Version
  14.6.0

Platform
  darwin x64 19.5.0

Terminal Features
  Object {
    background: "unknown"
    colorDepth: 24
    columns: 142
    cursor: true
    hyperlinks: true
    isTTY: true
    unicode: true
  }

Client Flags
  Object {
    clientName: "cli"
    cwd: "/Users/Yasser/Dev/rome"
    silent: false
  }

Steps To Reproduce

Run ./rome check

Expected Results

Old lines should be fully cleared.

I have the same issue

Are you both using the VSCode terminal?

There's some weirdness going on with other terminal emulators and cursor movement.

Fixed it. Working on regression tests and other tests for the ANSI cursor movement and will have a PR up soon.


add toSentence with docs

Useful for:
Creating Lists

Looks good to me! At some point someone should hook everything up with travis or something, but I'm on board for now. @strickinato


Added the Wyss Center as an Organization

Dear project maintainers,
I am submitting this pull request to add the Wyss Center as an organization to the project. The Wyss Center is a notable institution in the field of neurotechnology.
Changes made:

Added "Wyss Center" to the list of organizations

I believe this addition aligns with the project's goals.
Please review these changes and let me know if any modifications or additional information is needed. I'm happy to address any questions or concerns.
Thank you for considering this contribution.

of course! looks good. thanks for adding this @1990jr

@1990jr is there any affiliated academic points of contacts? usually projects/organizations stand out when there is a list of associated researchers or academics (with Google Scholar).
If you can share any financial information or GitHub repository that also helps to stand out.

@1990jr I have added your group director and all people I could find on Google Scholar. Feel free to update it, as needed.


Unable to start program

I'm using Visual Studio 2019 to compile the program and got an error message when trying to debug the program.

In the output log, got an output:
1>------ Build started: Project: main, Configuration: Debug x64 ------
1>main.cpp
1>Unknown compiler version - please run the configure tests and report the results
1>Please define _WIN32_WINNT or _WIN32_WINDOWS appropriately.

Check that your OS and compiler are both 64 bit.

My OS is Windows 10 64bit and the compiler are x64 to

Hmm... Maybe check to see if you selected the right compiler during the build process (i.e. step 4 in the instructions). You may have selected the wrong compiler there.

This is my configuration in CMAKE

@JulianSL Set main project as startup project in Visual Studio, then try again.
In "ALL_BUILD" project there is only CMakeLists.txt which is not a valid c++ project, and if you check the last lines of your log, you could see that building this project was skipped, hence there is no file to execute.

@JulianSL  from source code->docs->cmake-2.png may show you the recommended compiler.

@JulianSL  from source code->docs->cmake-2.png may show you the recommended compiler.


[WSL 2] can't access container in WSL from Windows

Unable to access localhost from Windows
start container in WSL with
docker run   -p 9001:8080 adminer
curl http://localhost:9001  returned with result no problem
however when I performed the same curl command from Windows land, the connection was refused
curl: (7) Failed to connect to localhost port 9001: Connection refused
check with netstat under Windows, and confirmed port 9001 is not visible from Windows
Microsoft Windows [Version 10.0.18917.1000]
Ubuntu 18.04.2 LTS
Docker version 18.09.6, build 481bc77
Ubuntu installed from Microsoft Store and converted to WSL 2 as per official Microsoft instruction
Docker installed as per official Docker guide for Ubuntu

You have to use the ip address of WSL 2  (as it is a hyper-v container). you can do so by running ip addr | grep eth0 within WSL 2 terminal, and you can use that ip address to access any port. You might have to play with the firewall too.

you can also can read the IP easily from task manager:

Isn't that obvious, haha.
Thanks for pointing that out, solved my problem big time. I keep recalling someone from one of the WSL 2 presentation I watched saying that WSL 2 networking environment is the same as native Windows environment....etc  perhaps he was referring to future release

Its worth to say that with WSL (version 1) localhost/<IP_ADDRESS> works fine. But once updated to WSL 2, its really necessary to run with local eth0 IP address.
And I agree with @markmail... it isnt that obvious  and must be highlighted somewhere...

The solution works for me.
However, if I run a server in WSL2 instead of in docker container, I can access my service using <IP_ADDRESS>.
Why <IP_ADDRESS> can be used to access services that run in WSL2 and eth0 should be used to access service in docker container?


we can't upload the directory(folder) in InputFile component

Describe the issue
we cant upload the directory(folder) in InputFile component. while drag and drop the folder we get the folder name only in OnChange event, while upload the folder, sub files which is present in the folder need to upload

To Reproduce
Steps to reproduce the behavior:

try to upload the folder or drag and drop the folder

Expected behavior
while upload the folder, sub files are need to upload
.NET Version
Output of dotnet 6 and 7.

Issue Details
my requirement sub files need to upload while upload the folder.

Hello @mohanrajsf3477 ... That's not a feature of the component. It only allows multiple selection of individual files. You can open a new feature request with the product unit at ...
https://github.com/dotnet/aspnetcore/issues
Note for the future that this isn't the best place to open requests for our content. Use the This page feedback button and form at the bottom of the English-US topic. Use of the This page feedback form adds metadata to your GitHub issue that cross-links the topic and automatically pings the author on an issue opened on our repo.


Revert "Update bibdata to rails 6.1"

Reverts pulibrary/bibdata#1865

Can be closed if there are no issues by 5/27/2020


Crash on Startup

I had hopeful wishes that things would work smoothely after the new Tetra update, but I figured things would be busted. I saw the other issue report about a crash with Druidcraft, and that you're already working on an update, but I figured I'd throw in my crash report in the hopes that it helps with anything that might have been missed!
https://pastebin.pl/view/66436f64

This should be fixed in the latest release. Thanks for reporting!


How to view the stack?

Hello,
I am trying to figure out how to look at the stack. I realize Ghidra has the stack pane, but this doesn't show the full contents of the stack, just the return addresses etc. I want a listing of 64 bit hex integers from the stack pointer down. I tried doing this in the memory view, but the endianess is wrong (it just puts the bytes next to eachother when grouped. Doesn't swap them to little-endian.)
This seems like a pretty straight-forward feature, so I must be missing something in trying to get this working.
Below is an example from x64dbg that I am hoping to get something similar to (see bottom right):

I tried doing this in Ghidra with a memory view, but the byte grouping basically produces a big-endian 64 bit integer, where as my system is little-endian (notice pointer (0x7ff...) is in wrong byte order)

The nearest equivalent we have is the “Hex Integer”, I believe, which flips the bytes as quads (not octets).  At a guess, we probably never did “Hex Long” as the implementation in Java is probably just a little more work and no one asked for it.


feat: Add API for Custom provider

Relates to https://github.com/envoyproxy/gateway/issues/1393

word  spell error

The API content looks good to me – how 'bout some user-facing doc? 🙂

@kflynn should be here https://gateway.envoyproxy.io/latest/design/local-envoy-gateway.html


Add admin login flag

Changes

Current dependencies on/for this PR:

main

PR #389   👈

This stack of pull requests is managed by Graphite.


Does not connect to Mosquitto broker ?

Hi,
Compiled OK and flashed OK.
When running, I get on the ESP8266 side  endless repetition of :
TCP: Connect to ip  <IP_ADDRESS>:1883
TCP:Reconect to: <IP_ADDRESS>:1883
TCP: Reconnect to <IP_ADDRESS>:1883
When I check Mosquitto log, I see repetition of :
New connection from <IP_ADDRESS> on port 1883.
Mosquitto socket error on client (null) disconnecting
Any suggestion ???
Thanks.

Please post your initialize code

Actually just resolved ! Your default code uses SSL and my mosquitto server was not configured for SSL. Hence disabled and now everything works OK !!!
Really GOOD !
Thanks.