Can we return HTTP 400 upon malformed HTTP request?

This is related to https://github.com/playframework/playframework/issues/4077.
I searched the issues in github and couldn't find any related issue.
We are using netty 2.6 and we found that if today we send an invalid http request like this curl http://my.netty.host.com/oh I have space netty will just throw IllegalArgumentException and close connection.
I am wondering why not just return 400 in this case?
This is an issue for the scenario where we fronted our netty server with some caching server. Caching server may return "5xx" if netty http server close connection with giving any response, which is a misleading status code.

@alvinlin123 I think we only throw the exception and closing the connection is actually done by the play framework implementation when an exception is catched. I'm not sure what exact version play uses though

Yes, looking deeper it looks like Netty just forward the exception to the next upstream. This is non issue then. Resolving. Thanks for replying.

Actually, now I think about it upon unable to parse the HTTP request, wound't it make more sense to throw some kind of special exception instead of IllegalArgumentException?  We are using Netty 3.6 by the way. Netty do throw TooLongFrameException if the first line is too long, then I think it follows that Netty should throw, say, InvalidMessageFormatException, if it can't parse the Http message?

I think it's better upgrading in the long run.  HttpObject (the supertype of HttpMessage and HttpContent) has the decoderResult() property that tells you when decoding fails.  Since 4, Netty does not throw an exception on a decoding failure but emits a partial message with the information about the failure, so you can handle the decoding failure more gracefully.
With Netty 3, you don't have many options as you realized already.

I think upgrading makes sense, but that's probably going to take some time with our production servers.
Is Netty 3 in maintenance only mode? Is making fix to Netty 3 not possible now? I may be wrong, but catching http messge decoding error and throwing a new specialize exception should be a straight-forward and non-breaking change right?

@alvinlin123 it's more or less in maintenance mode and we only fix bugs there atm.

I am closing this issue because I no longer work at the company when I open this issue :)


Jexcel Issue

When I type in a '0' before the number it doesn't show properly in the cell. So for example, it shows '4' if I type '4' but shows '0' if I type '04'

That has been fixed. 4.11.2+

Thanks for update. Its working fine now.


Timeout on Client constructed using fromHttpApp does not work as expected

It appears the timeout functionality has changed with the release of cats effect 1.1.0.
Previously the two below methods of doing a timeout worked the same way, now they do not.
Regardless of timeing, both methods result in a timeout error even though the timeoutTo method was allowed to run to completion.
I suspect the problem stems from this issue in cats effect (https://github.com/typelevel/cats-effect/pull/376)[https://github.com/typelevel/cats-effect/pull/376]
Whats even more of an issue, if you change the Timer[IO].sleep here to IO.never the second method just blocks indefinitely.
Setup
val startTime = System.currentTimeMillis()
def timeFromStart = (System.currentTimeMillis() - startTime) / 1000
val hostClient = Client.fromHttpApp(HttpApp[IO] {
  case _ =>
    IO(println(s"Sleeping: ${timeFromStart}")) *>
      Timer[IO].sleep(4.seconds) *>
      IO(println(s"Awake: ${timeFromStart}")) *>
      Ok(())
})

unsafeRunTimed
println(s"Starting: ${timeFromStart}")
hostClient.expect[Unit]("").unsafeRunTimed(1.second)
println(s"Done: ${timeFromStart}")

Results:
Starting: 0
Sleeping: 0
Done: 1
Awake: 4

timeoutTo
println(s"Starting: ${timeFromStart}")
hostClient.expect[Unit]("").timeoutTo(1.second, IO.unit).unsafeRunSync()
println(s"Done: ${timeFromStart}")

Results:
Starting: 0
Sleeping: 0
Awake: 4
Done: 4

While that may be true, the problem is how the change from cats-effect 1.0.0 to cats-effect 1.1.0 (I believe this one https://github.com/typelevel/cats-effect/pull/376) changed the way timeoutTo behaves within Client.fromHttpApp.
I have some unit tests in my app that was ensuring that a timeout was properly setup, and I noticed the change in cats effect caused my tests to fail.  My test is basically, construct a client from an http app that completes in an absurd amount of time, pass it to a class that has a timed out client call, test that the call fails and that it takes about the timeout amount of time to complete.  Before cats effect 1.1.0 this worked, afterwards the timeout condition is still triggered, but it takes that absurd amount of time to complete now.
Looking at the code for fromHttpApp I'm not even sure what can be done to correct it since it seems that IO.race used in the timeoutTo will always wait for a Resources allocation and finalization to finish... so... it seems that we can't timeout a client made from an http app?

If this is an issue I should bring up with on the Cats effect issue board let me know... its just I first noted the issue for fromHttpApp because that's how it affected me.

Yes, this is an unfortunate change.  I'm running out of energy tonight, but I'd like to find a solution to this.

I don't think there's a lot we can do here.  If this is still causing pain, please reopen.


Having /app mounted was surprising

I traditionally use /app for where the app in the container lives, so having this mounted for the buildkite-agent path lead to some debugging confusion

Oh, I see where I went wrong, WORKDIR sets the mount path not, the docker WORKDIR as I expected

Apologies @aussiegeek, it's confusing as it is now, we're planning on changing it in a major version bump at some point.


feat: adding Azure Availability Set module

Implements basic exists and prop get example with an advanced VM contained check
Fixes #623

CI result here https://github.com/rguthriemsft/terratest/runs/1114813177?check_suite_focus=true

https://github.com/rguthriemsft/terratest/runs/1150630104?check_suite_focus=true

@yorinasub17 I would like to submit an update to the CI to enable unit test as a seperate PR to keep the history clean if that is ok.  Will try to add it shortly.

CI ran with unit test execution here https://github.com/rguthriemsft/terratest/actions/runs/269456385

Thanks! Was that on the latest commit (99191cc)?


ignore_ids config not working for Mysql2

As stated in the wiki,
 ActiveRecord::Base.connection.reset_pk_sequence!
 which is pg only.

 If you need to use this gem with another database, use the ignore_ids configuration.

I followed this but still the error shows up.
 NoMethodError: undefined method `reset_pk_sequence!' for #<ActiveRecord::ConnectionAdapters::Mysql2Adapter:0x007f9281b8bb20>

Here is my initializer file.
 SeedMigration.config do |c|
      c.ignore_ids = true
      c.extend_native_migration_task = true
 end

Hi,
Thanks for reporting this error, I'm going to take a look at this and update this issue with what I find.
(Sorry for the late reply)

I just tried in a new project, with seed_migration 1.0.7 and it worked fine.
Could you give me steps to reproduce this error?
Remember that seeds.rb is re written after running rake seed:migrate, so you'll need to re run the task to have a seeds file without reset_pk_sequence!

@sbpipb ignore_ids is working fine for us with Mysql2, seed_migration 1.1.0, Rails 4.1.5, mysql2 0.3.20. Our initializer file looks just like yours.

Closing this for now as it seems to be fixed, feel free to reopen if you encouter the issue again.


improve data-generator source performance

Motivation
Only initialize factory once in the beginning

rerun java8 tests
rerun integration tests

rerun java8 tests

rerun java8 tests

rerun java8 tests

rerun java8 tests


Validation of maps

We need to support maps when validating. The question is how to handle validation of keys vs. validation of values.

Update: Initial support for maps. Only covers validation of map sizes and that their values are iterated properly.


Another round of adding type annotations

These are necessary to add more type annotations in Genie

Pull Request Test Coverage Report for Build 1131

164 of 187 (87.7%)  changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 80.151%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/nn-syntax/lexer.ts
35
36
97.22%

lib/typecheck.ts
21
22
95.45%

lib/ast/program.ts
0
2
0.0%

lib/nn-syntax/entity-retriever.ts
63
67
94.03%

lib/ast/function_def.ts
2
7
28.57%

lib/nn-syntax/list.ts
25
35
71.43%

Totals

Change from base Build 1120:
0.1%

Covered Lines:
9224

Relevant Lines:
11046

💛  - Coveralls


UX - the phrase "dirty data" triggers a "something is wrong" phycological response

Perhaps we can say "changed data" ?

This is based on git language FWIW https://mirrors.edge.kernel.org/pub/software/scm/git/docs/gitglossary.html#def_dirty


Scroll to column in result set does not update the horizontal scroll bar

Scroll to column in result set does not update the horizontal scroll bar
Hue Version: 4.4
It seems that previous versions of Hue had the same problem.
When I move the horizontal scroll bar to the right in the Result window after querying the Hive Query, the result is invisible.
https://issues.cloudera.org/browse/HUE-4073

we hit the same issue,  haven't found a way to fix it.

It is a tricky bug somewhere. In case it gives a hint, if you slightly resize the window it usually displays the content

It is a tricky bug somewhere. In case it gives a hint, if you slightly resize the window it usually displays the content

it seems that there're some problem in jquery.huedatatable.js line 439-446, startCol in line 441 is not changed as expected (startCol always is 1 in line 447), not familiar with javascript, working in process to figure it out.

@romainr  I think this bug is located at line 443 of jquery.huedatatable.js. The way to calculate endCol is not correct. when use position() (according to https://api.jquery.com/position/),  '$t.parent()' and '${this}' (the table header element) are not in the same coordinate system, we should add the horizontal  offset of '$t' (the result table) to the header element to make the condition meaningful (compare in the same coordinate system).

@JohanAhlen for the context in the PR

Closed with https://github.com/cloudera/hue/pull/904

@romainr @aiweaver I am still facing this issue after applying the update from https://github.com/cloudera/hue/pull/904. Could you please advise ? Would appreciate your help.

Greetings,
I too am facing the same issue, running Hue version 4.4.0 - as part of CDH 6.3.0. I manually edited the following files
/opt/cloudera/parcels/CDH-6.3.0-1.cdh6.3.0.p0.1279813/lib/hue/build/static/desktop/js/jquery.huedatatable.js /opt/cloudera/parcels/CDH-6.3.0-1.cdh6.3.0.p0.1279813/lib/hue/desktop/core/src/desktop/js/jquery/plugins/jquery.huedatatable.js /opt/cloudera/parcels/CDH-6.3.0-1.cdh6.3.0.p0.1279813/lib/hue/desktop/core/src/desktop/static/desktop/js/jquery.huedatatable.js
Applying the fix from #904 but the same issue persists - horizontal scrolling jumps to the furthest column on the right, the table does not refresh and the results aren't shown. Any ideas? :)

Hi,
I am experiencing the same problem on the EMR 5.24.0 version that comes with Hue 4.4.0.
I applied the changes suggested in #904 but the issue still persists.

Should be this one https://github.com/cloudera/hue/pull/960#issuecomment-541232722

Thanks for the hint, @romainr!
#960 slightly changes the behavior of the horizontal scrollbar, but it still instantly scrolls to the right and the preview data is still not shown for the columns to the right.

Thanks for the hint, @romainr!
#960 slightly changes the behavior of the horizontal scrollbar, but it still instantly scrolls to the right and the preview data is still not shown for the columns to the right.

I am using Hue 4.2.0, there is still not shown preview data after changing.

@swordspoet Hue 4.2.0 was working fine for us.

Thanks for the hint, @romainr!
#960 slightly changes the behavior of the horizontal scrollbar, but it still instantly scrolls to the right and the preview data is still not shown for the columns to the right.

I have the same question, how did you fix it ?

@userxiaozhu  , Might be You need to have : https://issues.cloudera.org/browse/HUE-9027 in your Hue-4.4.0 .
Please use latest Hue where the issue is fixed.

Hello, this problem also occurred in my CDH6.X+HUE4.2.0, I tried to manually repair the following files
The initial path is: /opt/cloudera/parcels/CDH-6.3.21.cdh6.3.2.p0.1605554/lib/hue
desktop/core/src/desktop/js/jquery/plugins/jquery.huedatatable.js
desktop/core/src/desktop/js/jquery/plugins/jquery.horizontalscrollbar.js
desktop/core/src/desktop/static/desktop/css/hue.css
desktop/core/src/desktop/static/desktop/css/hue3-extra.css
desktop/core/src/desktop/static/desktop/js/jquery.horizontalscrollbar.js
desktop/core/src/desktop/static/desktop/less/components/hue-scrollbar.less
But unfortunately, I still can't display it, can you help me please? Or can CDH upgrade HUE independently?

@swordspoet Hue 4.2.0 was working fine for us.

Did you solve your problem? Can you guide me?


Indonesian Translation of Readme.md and Contributing.md

Description
Adding Indonesian translation of Readme.md and contributing.md
Context
The Indonesian language is among the Top 10 spoken languages in the world. As many of the translations of Readme.md and Contributing.md are available in different languages in repo, Indonesian is missing. This translation would help people who speak Indonesian language better to understand.
Possible Solution
Adding documentation of Readme.md and Contributing.md in the Indonesian language.

Hey, @prateekpandey14 Can you please check this issue and add appropriate labels to it?

Not an valid issue @sharur7 , closing this. Please pick the issue having Hactoberfest label on it.

As we decided to consider the translation PR , re-opening the issue

@prateekpandey14  I am a beginner I want to take up this issue

bro @prateekpandey14 can you review my PR about this issue and also add appropriate labels on it ?

@hnifmaghfur are you working on this issue? I can't see this issue assigned to anyone.

@Solomon98 i think this issue open for all, so i work in this issue.

@Solomon98 i think this issue open for all, so i work in this issue.

I actually opened this issue for myself and I have already created a PR #3224 😅

no one assigned for this issue so i think this issue free for all 😅


Multiple Partial validations using $ref

What version of Ajv you are you using?
6.12.3
What problem do you want to solve?
I have a requirement where required fields would not be part of the same subschema where the properties are defined as shown below. I am trying to validate both required and property validation on same field
    $id: "appschema",
    $schema: "http://json-schema.org/draft-07/schema#",
    type: "object",
    allOf: [
      {
        description: "App resource",
        title: "sample app",
        type: "object",
        properties: {
          itemCode: {
            type: "object",
            properties: {
              code: {
                minLength: 1,
                pattern: "^[0-9]*$",
                type: "string",
                maxLength: 2
              },
            },
            required: ["code"]
          },
          serialNumber: {
            $id: "#serialNumber",
            pattern: "^[ -~]*$",
            type: "string",
            maxLength: 20
          },
          currencyCode: {
            minLength: 3,
            pattern: "^[A-Z]{3}$",
            type: "string",
            maxLength: 3
          }
        },
        required: ["currencyCode", 'itemCode']
      },
      {
        required: ["serialNumber"]
      }
    ]
 }

Code
let valid = ajv.addSchema(schema).validate({ $ref: "appschema#serialNumber" }, "abc-xyz");
The above piece of code allows validation on property serialNumber. Can we do the required field validation which is not part of the same subschema?

Required does not have to be in the same subschema, so it should work. What exactly is the problem?


Added feature to display file size

Closes #30
Type of Change
Put x inside the square bracket to specify what type of change your PR is:

[x] New Feature
[ ] Bug Fix
[ ] Code Refactor
[ ] Documentation Update
[ ] Other (please specify):

Description of change:
It shows the size of the password file in bytes.
Implementation of Change:
A new method, get_file_size, is introduced that gives the size of the file in bytes. This method also if-else statements to ensure that if the file does not exist, a user-friendly error message is raised.
Demo:
Screenshot of the new code:

@NyshG13 thank you for working on this


Mesh not drawn correctly when removed node is part of mesh [bug]

Version
Build/Run method

[ ] Docker
[ ] PKG
[X] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt version: Latest
Openzwave Version: 1.6.1789
Describe the bug
A node that was previously at address 18 (AEON Labs ZW095 Home Energy Meter Gen5), was removed and is now at 27 is still showing as a neighbor on five nodes at its old address.  Healing the network nor forcing the nodes in question to rebuild their neighbor list has resolved this issue.
Unfortunately, this breaks the Network Graph function badly resulting in random behavior.
To Reproduce
I don't know that this is a common behavior but now that my network is in this state, the Network Graph always provides random results.
Expected behavior
Unknown/removed nodes still reported as neighbors in the Z-Wave network topology should be mapped appropriately in the network mesh and labeled as "Unknown" or "Removed" as appropriate.
Additional context
Add any other context about the problem here.
Topology reported from OZWCP:
topo: node=1 6,7,8,9,10,12,15,25,27,30,31,32,33
topo: node=6 1,8,9,12,15,18,26,27,33
topo: node=7 1,8,9,10,25
topo: node=8 1,6,7,9,10,12,15,18,25,26,27
topo: node=9 1,6,7,8,10,12,15,25,26,27,30,31,32
topo: node=10 1,7,8,9,12,15,25
topo: node=12 1,6,8,9,10,15,18,25,27,33
topo: node=15 1,6,8,9,10,12,18,25,26,27,33
topo: node=24 9,25,30,31
topo: node=25 1,7,8,9,10,12,15,18,24,27,28,29,30,31,33
topo: node=26 6,8,9,15,27,33
topo: node=27 1,6,8,9,12,15,25,26,32,33
topo: node=28 25
topo: node=29 25,30
topo: node=30 1,9,24,25,29,31,32
topo: node=31 1,9,24,25,30,32
topo: node=32 1,9,27,30,31
topo: node=33 1,6,12,15,25,26,27

Note that 18 shows up as a neighbor to 6, 8, 12, 15, and 25 but not as an active node in the topology.  I realize this may be an edge case; however, I've tried factory-resetting the node in question with no success.  Presumably, this is a bug in the particular device's firmware.  It appears my only alternative is to rebuild my network from scratch.  I have to assume that if this has happened to me it likely has happened to someone else as well, though.

Switch to https://github.com/zwave-js/zwavejs2mqtt

Are there any instructions on how to migrate from zwave2mqtt and setup zwavejs2mqtt?  I have no interest in running under docker.

https://zwave-js.github.io/zwavejs2mqtt/#/guide/migrating

Thank you very much, sir.  Your effort on this is greatly appreciated.  Without your hard work, I'd be stuck on SmartThings.


Delete DNS entries when shoot is hibernated

What this PR does / why we need it:
This PR deletes DNS entries when a shoot enters hibernation.
Which issue(s) this PR fixes:
Fixes #2039
Release note:

DNS entries are now deleted when a shoot enters hibernation which prevents outdated DNS records.

Is there a reason for not deleting the ingress DNS entry as well?

Is there a reason for not deleting the ingress DNS entry as well?

https://github.com/gardener/gardener/blob/master/pkg/operation/botanist/addons.go#L44

😕 Does it make sense to move this now also to the place where you delete the other DNS records?

PTAL


Improve example documentation

Should improve readability and ensure flake8 tests pass for some examples. Just documentation addition - no coding changes.

I've just seen a small typo (missing colon before class:~) in the association description of the function associations_including_objects in the AssociationSet data type , if you prefer I can fix it here in this PR

Hi, I've found a documentation typo in functions.build_rotation_matrix, likely an extra tab in the first entry of the Parameters part which breaks the layout. Like this:

Probably removing the tab before angle_vector, and keeping the rest of the text as it is, will fix this issue.

Hi, I've found a documentation typo in functions.build_rotation_matrix, likely an extra tab in the first entry of the Parameters part which breaks the layout. Like this:
Probably removing the tab before angle_vector, and keeping the rest of the text as it is, will fix this issue.

Happy to do this in a follow-up PR - just don't want to keep making this one bigger when it's primarily about example docs :)

Have committed changes made by @hpritchett-dstl


support for cdh 5.7

It would be really great to support phoenix 4.7 over CDH 5.7.0.

FWIW, I'm working on this now.

Thanks @busbey . Please let us know where/when it's ready. Awesome

Thanks @busbey . Looking forward for it.

Sorry folks, forgot this one.
The release announcement went up on Cloudera's community site about 3 weeks ago


Cannot limit bandwith.

Apply button does not work.

Seems to work for me. Make sure you are saving settings with OK button and not just closing the dialog with Cancel or Escape.

Ahh i see the issue. Before it would apply instantly when clicking apply but now i also have to click ok. Maybe that should be addressed? but its a non issue now.


indicator for href

SRE appears to provide no indication that an element has an href attribute.

As per F2F with @zorkow this is considered an upstream problem. SRE keeps the href attribute intact and thus it's up to the renderer (e.g. mathjax-a11y) to expose it correctly.


[PROPOSAL] Revised review policy

I would like to propose a revision to the package review policy based on recent discussions, e.g. https://github.com/r-multiverse/help/issues/83.

Just submitted https://github.com/r-multiverse/r-multiverse.github.io/pull/33.
If approved, this revision will be effective 2024-12-17.

merged https://github.com/r-multiverse/r-multiverse.github.io/pull/33


How do I implement this in my code?


Blank error message when trying to insert record into cloud datastore from cloud run

If you are still having issues, please be sure to include as much information as possible:
Environment details

OS: Google Cloud Run -
Node.js version: 10.17.0
npm version: 6.11.3
@google-cloud/datastore version: 4.5.2

Steps to reproduce

Hit microservice with http request in cloud run
Application receives request (either in cold start or when already running)
Begin cloud datastore insert of record
Error with no message occurs and application returns 500 error within application server

We are seeing weird intermittent behavior in cloud run using the cloud datastore library. Periodically when trying to insert a record to cloud datastore we'll see a connection error with no message and the following stack trace. We are having a hard time trying to diagnose and remedy this issue aside from a hard crash a retry of the particular process. I couldn't really find other issues that had this specific error in cloud datastore so I posted it here.
Error: <no message>
at Http2CallStream.call.on<EMAIL_ADDRESS>line 96 col 44)
at Http2CallStream.emit (events.js line 203 col 14)
at process.nextTick<EMAIL_ADDRESS>line 71 col 21)
this.emit('status', status);
at process._tickCallback (internal/process/next_tick.js line 61 col 10)

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

👋 thanks for the bug report @mdobson.

Happy to help!

This issue keeps coming back and biting us. It’s very sporadic this making it hard to reproduce. Has there been any progress on this? Any other issues in other GCP libs that are similar?

Hi Google APIs Team,
We're still seeing this issue, but with some slight changes. The error will have a similar stack trace, but now send back an error message of Error: 13 INTERNAL: at Object.callErrorFromStatus. This will randomly disrupt inserts and other operations to datastore so we were wondering if there were any recommendations on how to remedy the issue, or if there is a potential fix in the works.
Stack trace:
(/workspace/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call.js:30:26) at Http2CallStream.call.on (/workspace/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/client.js:96:33) at Http2CallStream.emit (events.js:203:15) at Http2CallStream.EventEmitter.emit (domain.js:466:23) at process.nextTick (/workspace/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call-stream.js:75:22) at process._tickCallback (internal/process/next_tick.js:61:11)

Thanks,
-Matt

We are also seeing this issue using @google-cloud/datastore version: 5.1.0 on Cloud Run.
"Error: 13 INTERNAL:      at Object.callErrorFromStatus (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call.js:30:26)         -> /app/node_modules/google-gax/node_modules/@grpc/grpc-js/src/call.ts:79:24     at Http2CallStream.<anonymous> (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/client.js:96:33)         -> /app/node_modules/google-gax/node_modules/@grpc/grpc-js/src/client.ts:155:18     at Http2CallStream.emit (events.js:327:22)     at /app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call-stream.js:100:22         -> /app/node_modules/google-gax/node_modules/@grpc/grpc-js/src/call-stream.ts:186:14     at processTicksAndRejections (internal/process/task_queues.js:79:11)"

@ChrisWestcottUK Yeah, it's a nasty one. I hope they are looking at it though this thread has gone pretty stale. Any chance you've found a way to reproduce it consistently? We haven't been able to.

Another issue related to Error: 13 INTERNAL was recently fixed — https://github.com/googleapis/nodejs-firestore/issues/1023 for more context (we centralized discussion there). The fix was recently released; if this issue is still happening for you once all dependencies have been upgraded, can you please add additional repro steps?

@meredithslota Understood! We ended up incorporating exponential backoffs to solve this, but I'll perform the upgrade and report back.

I'm going to go ahead and close this out, but if you are still seeing issues after the upgrade, please file a new issue and reference this one. Thank you!


Group users gets error thats not for you

Brother, i have been following you since long and i am in the process of making a bot but it is showing "That's not for you!!" to my group members repeatedly when the click on next, back and page button. Please help me with it  Eagerly waiting for your reply.

Please give me solution

Its a feature actually....
Only the user who send the message can click the buttons....

Its a feature actually....
Only the user who send the message can click the buttons....

Brother I have a channel with 4000+ files. Do I need to addfilter of each file.

Add bot grp and channal comnd
To group /add channal id
Simple

Add bot grp and channal comnd
To group /add channal id
Simple

thXs


Clicking string literals produces weird highlighting

Occurs on build 3.5.4377-dev. Simply click a string literal and observe the questionable (secondary?) highlighting all over the place.

This will be fixed in 3.5.4391


Charting editors load null difficulty

Describe your bug here.
so if you don't insert a null difficulty to your data song file, it crashes when debug key is pressed
(source & lua)
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

Update to psych 0.5.2h bc it is fixed

Update to psych 0.5.2h bc it is fixed

It isn't-

Couldn't replicate the bug, record a video.

From what I understand the chart editor in the main menu loads normal difficulty, so if you switch to another song that doesn't have it you get the usual "chart json doesn't exist" error

this happens because you never loaded in a difficulty when accessing through the chart editor instead of the song, which is why this happens since it takes the recent difficulty played on

they are talking about this:

(happens when psych engine hasn't loaded in a song in that current session)

Ok I figured what is the bug, it will try to load the latest difficulty that was loaded in, when the game start, the editor difficulty is null but when you load test, the actual chart is on normal, so the game seach for a null difficulty which doesn't exist, this bug will also happen if you are on a chart with a custom difficulty and then go to another song using the Reload Json button
To make it shorter, the internal difficulty is "normal" while the editor difficulty is null, causing a crash when trying to load any song (even itself)
I do wonder, why doesn't it check if the song even EXIST before trying to go in it... crashing the game because of a spelling mistake/wrong difficulty is so annoying

I am not sure of myself but this line might be at cause (in CoolUtils)

Maybe because Test isn't in a story week, it cannot reach a difficulty and so the array is empty, it just sends out a null which then cause the game to crash since no song have a null difficulty, only a theory tho

If you have no way to acces source code to fix this, adding a null difficulty while working does solve the problem temporarily.


[TOMEE-4061] Derby <IP_ADDRESS>

This is a tentative to update Derby to 10.15.x, upon other dep updates.
Derby 10.15.x is modular, it might break CI, please merge wisely.
TomEE 9.x dependencies update:

Derby <IP_ADDRESS>

if ever the build would break because if this, we might be able to fix adding another dependency.
id'like to see if it works without; but unable to build, looks like missing deps in patch and or tomee-javaee.
<dependency>
  <groupId>org.apache.derby</groupId>
  <artifactId>derbytools</artifactId>
  <version>${version.derby}</version>
  <scope>test</scope>
</dependency>

only if needed

The branch is currently actively being worked on. I'll start doing milestone releases from Jakarta EE API and others when possible so we can get people to build and the CI at some point
Long story short, I'll merge it without the extra dependency and we can fix later if that's ok with you

thank you very much


Unable to Connect or Join LiveShare Session

Product Version: VS Code v1.34.0 (System Setup)
OS: Windows 10 Pro Build 1703
Live Share Version: 1.0.311
Refer Issue# 1836. Same device.
Carried out a reset on Surface. Reinstalled VSCode and LiveShare Extension.
Came up with "Agent terminated with exit code: 0 and signal null:" on startup.
When trying to connect to/start a session from the Live Share pane, error comes up. "command 'liveshare.joinfromActivityBar' not found."
The buttons on the taskbar (bottom left hand corner) are not present.
Checked the Log File. Refer below line for full error.
[2019-06-01 04:35:00.541 Client E] Unhandled promise rejection:
Agent terminated with exit code: 0 and signal null:
at ChildProcess.module.exports../src/abstractions/node/agent.ts.Agent_1.start.Agent_1.cp.on (C:\Users\Christian.vscode\extensions\ms-vsliveshare.vsliveshare-1.0.311\src\abstractions\node\agent.ts:272:32)
at ChildProcess.emit (events.js:187:15)
at maybeClose (internal/child_process.js:961:16)
at Socket.ChildProcess.spawn.stream.socket.on (internal/child_process.js:380:11)
at Socket.emit (events.js:182:13)
at Pipe.Socket._destroy._handle.close [as _onclose] (net.js:596:12)
Checked to see if file location exists. "\ms-vsliveshare.vsliveshare-1.0.311\src" does not.
Have tried rolling back to a previous version and copying "\.vscode\extensions" from a working install. Same result.
Have attached full log file for reference.
20190601_042331_15593630115250_VSCode.log

Hey @Morgorath, thanks for the feedback! Looks like your agent is crashing on the startup. Did you try to reinstall Live Share after nuking the %USERPROFILE%\\.vscode\\extensions\ms-vsliveshare.vsliveshare-1.0.311 folder? // cc @jasongin

Hi @legomushroom,
I sure did. Deleted all live share related folders that I could find after removing the extension from code. Then tried reinstalling. Same issue.

@Morgorath oh sorry for the inconvenience. This is not something we expect -- seems like your agent fails to start and it is not clear why. I have a hypothesis that the extension failed to download all required dependencies.
Were you able to run the extension before this version and it starting failing after update, or this is your first time trying installing in?

@legomushroom
Before I reset, I did have a install that worked once and then broke part way through the session. Never worked since.
I have attempted it twice since resetting the PC.

@Morgorath sorry to hear that. That's an interesting case indeed. We pushed a client release an hour ago, could you try to update to that and let us know if it fixes the issue.

@legomushroom
It has gone and resolved itself. To which I will only say "Typical."
Thank you for your help.

@Morgorath great to hear! Please let us know if it comes back.

@legomushroom Hello, I have the same problem in the newest updated version. Can you please help?

same problem


Added ISO 4217 numeric codes for currency

Picked from this wiki page: https://en.wikipedia.org/wiki/ISO_4217

Thanks for the contribution, could you please resolve conflicts and we will merge it

@Rhymond Resolved.

@Rhymond Can this be merged? We're looking for this functionality as well. Thank you :)

🎉 thank you! 😄


[Affected functionality] Advanced search

Browser: Microsoft Edge
Device: HP ProBook 440 G7
Actual behavior: Sorting panel changes extends when screen size is 14"

Expected behavior: sorting panel should be centralized, shouldn't merge with filters sidebar menu

Add Border/Padding


Add an option to hide window decorations when the window is maximized

I find window decorations useless when the window is maximized, so I'd like to hide them to preserve screen space, since I use tmux for multiplexing the terminal. Foot has an option for that and I imagine it wouldn't be too difficult to implement it here.

Could use
https://ghostty.org/docs/config/reference#window-decoration
if you want to always disable it

@ohmsl then I'd lose the ability to pull edges and corners of the window, move it around when it's not maximized and would have to use a keybinding to toggle. I think it could be improved.

Agreed, it should at least remove the window decorations when full screened, whether this needs to be an option I don't know but +1 from me

I prefer a discussion for feature requests but I'm willing to accept this one on the spot. It's a good idea.
This should only apply to GTK. macOS already has its own hidden decorations when fullscreen (that appear when you hover the mouse up top).

IMO it should hide the decorations when it goes full-screen,  not when the window is maximized.

@ansipunk would something like this help ?

@Pangoraw thanks, I'll keep on eye on that discussion, it indeed does look great.


Fix image security issue / adjust certification check

All Submissions:

[x] Have you signed our CLA?
[ ] Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
[ ] Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@helderjs feel free to merge this PR. Tests that are failing have nothing to do with your changes.


added customizable pipeline tool

Description
added a pipeline tool consisting multiple steps that makes tool/chain reuse easier.
with more generic tools reused by domain task tools, metadata-driven agent-tool chain loading will be easier.
Dependencies
None
Maintainer

Agents / Tools / Toolkits: @vowelparrot

love this idea, few questions on implementation
biggest one: @nfcampos wdyt about changing this to just use sequential chain? that would let it log intermediate steps properly, and we can make it easy to go from arbitrary chain to tool (if we don't already).

love this idea, few questions on implementation
biggest one: @nfcampos wdyt about changing this to just use sequential chain? that would let it log intermediate steps properly, and we can make it easy to go from arbitrary chain to tool (if we don't already).

i got the pr messed and i will raise another pr the the discussion.


stream.toString() returns object instead of data

Hi,
tried your sample to get data out of a readable stream (see README.md).
Unfortuantelly an object is returned when toString is called.
Am I missing something to get the sample to work?
I have Node v7.5.0 installed.
Expected
const reader = new streams.ReadableStream('Hello World\n');
console.log(reader.toString()); // outputs: "Hello World\n"

Actual
const reader = new streams.ReadableStream('Hello World\n');
console.log(reader.toString()); // outputs: [object Object]

Sample I tried
const streams = require('memory-streams');

// Initialize with the string
const reader = new streams.ReadableStream('Hello World\n');

// Add more data to the stream
reader.append('Hello Universe\n'); // outputs "Hello Universe\n";

// Read the data out
console.log(reader.toString()); // outputs: "Hello World\nHello Universe\n"

Many thanks in advance
Greg

Hey Greg, there's a typo in the README, missing a call to read(). A working sample is shown below:
const streams = require('memory-streams')
const reader  = new streams.ReadableStream('Hello World\n')
reader.append('Hello Universe\n')
console.log(reader.read().toString()) // NOTE: the call to `read()`

Apologies, a working version was available in the tests and I will update the README.


Theme: js caching

Assets can be cached by browser or CDN.
How to fix it?

change file names (hash, date time, query string)
put JS into html

Done with chunkhash in file name.


BUG? epochs.resample takes foreever

epochs.resample seems unresonably slow. Here's an example
import time
import numpy as np
import mne
from mne.datasets import sample
data_path = sample.data_path()
raw_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
events_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw-eve.fif'
raw = mne.io.Raw(raw_fname, preload=True)
picks = mne.pick_types(raw.info, meg=True, exclude='bads')  # Pick MEG channels
raw.filter(1, 30, method='fft')  # Band pass filtering signals
events = mne.read_events(events_fname)
event_id = {'AudL': 1, 'AudR': 2, 'VisL': 3, 'VisR': 4}
epochs = mne.Epochs(raw, events, event_id, -0.050, 0.400, proj=True,
                    picks=picks, baseline=None, preload=True,
                    reject=dict(mag=5e-12),verbose=False)

critically
start = time.time()
epochs.resample(64, n_jobs=-1)
print(time.time() - start)

83.4265270233 seconds

And the n_jobs=-1 doesn't seem to take all processes. Is this expected?

It is probably due to scipy's resample function using FFT-based resampling, thus wrapping to fftpack which is slow for non-powers of two. We need to get polyphase filtering / upfirdn-style resampling working (https://github.com/scipy/scipy/pull/5186). @rkmaddox or I (or someone else!) just need to find the time to work on it.
In the meantime, can you use CUDA? It should be an order of magnitude or more faster.
Closing as dup of #2035, where we should probably continue the discussion.
The n_jobs=-1 not taking up all jobs does seem to be a separate issue. Feel free to reopen this and retitle it for that issue if you want. What does verbose=True say about the number of jobs that will be used? You should see updates from parallel with thread numbers, for example.

Ok, thanks for the quick update.

In the meantime, can you use CUDA? It should be an order of magnitude or more faster.

no, don't have the right computer for that.

What does verbose=True say about the number of jobs that will be used? You should see updates from parallel with thread numbers, for example.

It indicates the right amount of thread (8), but only verbose 2, and only 2 are actually used.  Unfortunately, I'm under water work-wise, can't spend time on this.
For future ref, I use this quick and dirty alternative:
def resample_epochs(epochs, sfreq):
    """Fast MNE epochs resampling"""
    from scipy.signal import resample

    # resample
    epochs._data = resample(
        epochs._data, epochs._data.shape[2] / epochs.info['sfreq'] * sfreq,
        axis=2)
    # update metadata
    epochs.info['sfreq'] = sfreq
    epochs.times = (np.arange(epochs._data.shape[2],
                              dtype=np.float) / sfreq + epochs.times[0])
    return epochs

Is that actually faster? That is what epochs.resample should more or less be doing under the hood. If what you wrote is faster, I suspect we're doing something wrong in master.

If you could come up with some minimal example e.g. using EpochsArray or the sample data demonstrating the speed difference (with n_jobs=1), I'm happy to take a look.

BTW it would be better to use epochs.decimate than epochs.resample if you know your data are sufficiently low-passed, because it will avoid edge artifacts that resampling will produce.

Your example above, for example, could probably make use of decimation, but you would be a bit close to the Nyquist rate by going to sfreq=64 in this case, something like 90 i.e. 3x the highest freq would be safer.


Broken on some DPs but not others?

This worked beautifully first time I tried it, but recently I've had the strangest error. It works from one of our DPs without issue, but on two of them it fails at the copy autopilot config stage. The xcopy command returns a 4 and the log has weird Chinese characters in it. Anyone else found this or found a solution? Tried removing the package and re-adding it, tried a few things, but nada. Any ideas?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 17bfe927-f7b7-608b-8537-5c2274ccdced
Version Independent ID: 5dd9abca-92d9-fbb2-6796-d1f6b9ab3c8b
Content: Windows Autopilot for existing devices - Windows Deployment
Content Source: windows/deployment/windows-autopilot/existing-devices.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

Update: Tried creating a new package but the same result. Checked the local log on a failed install and saw an error for UNC path not supported and file not found, but the file is there. Log for the deployment looks totally different on the machine that did work

Hello,
Looks like this question can best be answered via relevant Windows 10 Support channels.
Please consider checking with Microsoft Community or contacting support for your problem; The issues section of this repository is for content fixes in documentation.
If you feel that the associated article also needs to be updated for any reason feel free to re-open this issue or contribute with a pull request.
Thank you.


Implement IPSDTA

Summary
Implemented Gauss-IPSDTA.
Only VCD-based demixing filter update is supported.
ref: #33
TODO

FPI-based demixing filter update

Codecov Report
Base: 96.27% // Head: 93.29% // Decreases project coverage by -2.98% :warning:

Coverage data is based on head (d78a356) compared to base (dbe078f).
Patch coverage: 78.32% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   96.27%   93.29%   -2.99%
==========================================
  Files          24       26       +2
  Lines        2634     3160     +526
==========================================
+ Hits         2536     2948     +412
- Misses         98      212     +114

Impacted Files
Coverage Δ

ssspy/bss/ipsdta.py
75.98% <75.98%> (ø)

ssspy/bss/_update_spatial_model.py
97.00% <90.69%> (-1.73%)
:arrow_down:

ssspy/bss/_psd.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Clarify what happens when a failed swarm node recovers

Fixes #105

@thaJeztah PTAL

Thanks for the feedback. I've reworded it a bit. Can y'all review it again?

I don't see the changes - looks like they haven't been pushed yet.

Oops, you are right! Should be pushed now.

LGTM


Stuck in terminal when trying to back out

When opening the Terminal, you get stuck inside of it (Some people are able to get out when mashing different keys but not everyone)

Please upload your logoutput.log

Unable to reproduce and user is unresponsive


Z-index of side elements changed

The Z-indexing of the side hover social media links have been changed such that they when hovered upon translate over the text,
hiding the text below making the site more neat and presentable.

The overflow in x-direction has been resolved as well.


Using a test framework for Javascript

I am currently writing code for the Topology Editor however - as @ChaelKruip pointed out - there are no Javascript specs. It sounds lovely and I know how to write tests in QUnit. However considering we're having a Rails project it might also be worthwhile to checkout teaspoon.
What is your opinion about this matter? @antw

I think Jasmine and Mocha are quite popular in the JS world, but I don't know very much about either. I used QUnit and Jasmine a few years ago, but it's been so long that I don't think my opinion counts for much. 😆
Perhaps we might research the different options? Teaspoon looks pretty cool as well

I have some experience with QUnit and that's it. But I used it for a pretty vanilla Javascript application.
I'll research some options and present my findings. 👍 Teaspoon does look really cool. I'll try some of them and see what 'works' nice and easy.

http://stateofjs.com/2016/testing/

MochaJS looks promosing. For the basic fact that you can run it from the browser 👍 which is really cool. I also know QUnit can do that. I'm only a bit unaware about the whole process of writing specs in Javascript. Will it be something like this (to put it in perspective):
// Quick code example:
describe("d3 topology chart", function () {
  before(function() {
    this.topologyChart = Topology.Base.new("body", { name: "HV" });
  });

  test("it renders", function () {
     this.topologyChart.draw();

     ok($("svg").length > 0);
  });

  afterEach(function () {
    $("body").html("");
  });
});


SourcePawn stock repository detected as partially C++

nosoop/stocksoup has a few include files (with .inc suffix) that are being incorrectly classified as C++.  The project only contains SourcePawn code, all which are include files.
nosoop/newdecl-handles is also being classified as completely C++.
A thing that might be of note is that SourcePawn, as of SourceMod's 1.7 version, has added a transitional syntax which is more similar to C# and Java than Pawn.  While the new syntax is preferred, scripts written in the old syntax will still compile on recent compilers, and scripts can contain a mix of old/new syntax.
More information about the new syntax is available here.

Any keyword or construct unique to SourcePawn that we could use to recognize it?

stock  is a common function declaration prefix in Pawn-like language include files, including but not limited to SourcePawn.
methodmap is a declaration unique to SourcePawn's transitional syntax, but its use isn't guaranteed.

Is it always ^stock nameoffunction\(?

Transitional syntax requires a return type, but the old syntax does not.  Would have to match the following:

stock return_type function_name( to match SourcePawn's transitional syntax only
stock function_name( and stock return_type:function_name( to match Pawn-likes in general

As far as I can tell, ^\s*stock\s+(\w+(\s+|\s*:\s*))?\w+\s*\( correctly matched all the ones I threw at it, including variable amounts of spaces between the opening parenthesis and surrounding the colon.
For completeness' sake, ^\s*stock\s+\w+\s+\w+\s*\( can be used to only match SourcePawn's transitional syntax, and ^\s*stock\s+(\w+\s*:\s*)?\w+\s*\( can be used to only match Pawn-like stock declarations.

Thanks for the detailed explanation.
Does that mean this file is actually a PAWN file?

mfile.inc is definitely not SourceMod's flavor of Pawn (uses a different file open call).  The function declarations listed could be done in SourcePawn, though.
The CallLocalFunction call suggests the file is from a variant of Pawn used for San Andreas Multiplayer (SA:MP).  y_testing.inc and Check.inc are also for SA:MP.
foo.sma is for AMX Mod X based on file extension; it's a much closer relative compared to SA:MP (it's Pawn for an older engine in the same family as the engine that SourcePawn scripts are used for).
fixed.inc is for CompuPhase's PAWN; I don't think operator constructs are valid in SourcePawn.
foo.sp is SourcePawn.

Crap! Looks like I'm gonna have to move everything... Do you know where I could find samples of SourcePawn files for .sma and .inc?

The include files in this repository are SourcePawn.  .inc files dated from before 2015 use the older Pawn-style syntax, 2015 ones use the new syntax.  This repository has some as well.  The transitional helpers repository has a good amount of samples that only implement methodmaps, no stock functions.
The SourceMod repository has the standard library includes.
This forum has samples for AMX's flavor of Pawn.  I'm not as knowledgeable in that domain, so I can't give any more precise examples.  Should be fine just opening a few threads labeled "[INC]" and scrolling down to the download on the first post in each.  (.sma is apparently AMX's equivalent to SourceMod's .sp "main" files; they both use .inc for includes.)
Also, forgot to note:  AMX's Pawn is a lot closer to Pawn when it comes to syntax; the C#-style syntax isn't available there.

Unfortunately, all these repositories are either under GPLv3 license or don't have one :/
We need a permissive license for samples as Linguist is under MIT license.

That's going to be a bit tricky, then.  The licensing for SourceMod states that derivative works must be licensed under GPLv2+.
Maybe I could write a sample file that only demonstrates syntax without including GPL-licensed files?

Sample files are used to train the Bayesian classifier, so demo files tend to skew its results. We usually prefer sample files from "real" applications. Could you relicense a file from one of your repository under a permissive license? If you prefer to avoid that, we'll have to do with a realistic sample file written specifically for this.

Honestly, I've been releasing my projects as GPL because I'm not a lawyer and I can't wrap my head around the licensing stuff.
Provided no issues (e.g., I can still reference SourceMod's GPLv3-licensed standard library), I'd be more than happy to relicense all of my personal SourcePawn code as MIT.

Honestly, I've been releasing my projects as GPL because I'm not a lawyer and I can't wrap my head around the licensing stuff.

Me neither and I've found http://choosealicense.com to be of great help.

Whoops, poor wording on my part.  I'm actually already really fond of MIT's simplicity (some non-SourceMod projects I wrote are licensed under that); just didn't want the hassle of checking for incompatibilities when it comes to writing SourceMod stuff in particular since the whole "all derivative works must be GPL" bit in their license is pretty intimidating.
If I can get a definitive answer to any limitations for MIT-compatible SourcePawn code (I've also asked on the primary SourceMod forum here), I'll go with whatever's appropriate.

:wave: Going to close this as it appears we can't move forward with the license as is.  Please feel free to reopen if there's a compatible license, or if I misinterpreted the status of this issue.

@pchaigno is there nothing that can be done to improve this due to the licensing? Early on in the issue you asked if there are any unique keywords or constructs in SourcePawn, is it possible to match files on those without violating the licensing conditions set by AlliedModders?
To add, this repository contains an old version of mapchooser.sp named foo.sp, this file is licensed under GPLv3 so it shouldn't be redistributed here under the MIT license, correct?
Thanks.

@pchaigno is there nothing that can be done to improve this due to the licensing? Early on in the issue you asked if there are any unique keywords or constructs in SourcePawn, is it possible to match files on those without violating the licensing conditions set by AlliedModders?

Not really. We can create a heuristic, but we still need a sample under a permissive license for the classifier which is used to catch things that fall through the heuristic.

To add, this repository contains an old version of mapchooser.sp named foo.sp, this file is licensed under GPLv3 so it shouldn't be redistributed here under the MIT license, correct?

Whooops. That definitely needs to go.

@lildude won't removing that file make the language unsupported on GitHub?

@X6B0ISI09wD4 I'm currently in discussions with our legal team regarding the license of samples. I'll provide an update once I know for certain where we stand.

I've spoken with our legal team, and whilst we'd prefer not to include copyleft licensed samples, there shouldn't be any problems with us doing so from a licensing perspective as...

we're only including them in the repo as data and not as executable or linked code, and
when building a release, we break up the samples into tokens that don't represent the original code. These tokens are "stored" in the samples.json file which we do use and ship within the gem.

So we can leave the GPL licensed samples in place (we've got quite a few already), and if absolutely necessary (we'd prefer not to if possible), can accept copyleft licensed samples in future.
We can not however accept copyleft or restrictively licensed grammars as these are shipped as linkable and executable code.
I'm reopening this issue as licensing of the samples should not hinder improving the classification.
/cc @pchaigno @Alhadis @larsbrinkhoff for future reference.
/cc @mlinksva

@lildude that's great to hear. I don't think it's possible to avoid including GPL licensed samples in SourcePawn's case as their license is very restrictive and all derivative works must be under version 2 or 3 of the GPL.

About this issue itself though (#3156) what can actually be done?
Something I noticed is that not one of the samples for SourcePawn is in the new transitional syntax which is still optional as of SourceMod 1.9 but is becoming the standard. Also AMX Mod X has been mixed in with SourcePawn which is strange.
Also just curious with the SourcePawn submodule which file(s) in that repository are used by linguist? It would be great if Dillonb/SublimeSourcePawn could replace that as it's received and still is receiving updates from Tsunami to include the new syntax and natives as they release.

About this issue itself though (#3156) what can actually be done?

Well, the problems and changes you've mentioned suggest we need to update Linguist to take these changes into account. I certainly don't have any experience with SourcePawn, but you seem to so please review the contributing guidelines and open a pull request.
This PR can include new samples for the new syntax you've mentioned and also a switch to the syntax highlighting grammar.  Just keep in mind that we will not accept a grammar that is not licensed under one of these licenses - the grammar you've referenced doesn't have a license from what I can see.

Also just curious with the SourcePawn submodule which file(s) in that repository are used by linguist?

From a quick look, it'll mostly be sourcepawn.tmLanguage as this is what defines the syntax highlighting grammar.

@lildude a few more queries I have before diving into the contributing guidelines.

The best samples are probably the plugins bundled with SourceMod from the official alliedmodders/sourcemod repository, the previously mentioned mapchooser.sp (known as foo.sp in this repository) is an example of one. These are of course all licensed under the GPL v3. My question is do you also need explicit permission from the sample's author for it be used in Linguist or does the license allow its use here automatically?

As you said @Dillonb's repository doesn't seem to have any license at all, does that prevent its use in Linguist? I'm not sure if completely unlicensed works are included. If it does I will try to get in contact with him before any kind of PR as I think the 100s of new natives, forwards, tags and keywords will do wonders in differentiating the rather vaguely suffixed .inc files.

Would further disambiguation between .inc files still be possible with what @pchaigno mentioned here? A lot of SourcePawn includes are misidentified as C++ and even if the improved grammar can be implemented most simple  includes won't benefit from it that much.
If so how would I go about implementing that? There are some quite unique constructs with naming conventions put in place by the wiki that should only exist in SourcePawn.
A couple of examples would be:

public SharedPlugin __pl_myfile = or public SharedPlugin:__pl_mapchooser =
public void __pl_mapchooser_SetNTVOptional() or public __pl_mapchooser_SetNTVOptional()

My question is do you also need explicit permission from the sample's author for it be used in Linguist or does the license allow its use here automatically?

When you submit the pull request, you'll have to sign GitHub's CLA, in which you state you have the rights to submit this contribution (see 3. Source of Contribution).

As you said @Dillonb's repository doesn't seem to have any license at all, does that prevent its use in Linguist?

Yes. For grammars in Linguist, we need a permissive license. Politely asking the author to add one often works :-)

Would further disambiguation between .inc files still be possible with what @pchaigno mentioned here?

Yes, I'm hoping we can. We should probably start with the samples and the grammar since the disambiguation work is a bit more complex.
It looks like we'll have to do some cleaning (moving incorrectly classified samples) and we could add a heuristic rule with the constructs you mentioned.

@pchaigno thank you, that all sounds great. When you say moving incorrectly classified samples could you give an example? I'm a little confused what that means. Also I forgot to ask in my previous comment, is there a limit to the amount of samples one language can have in the Linguist repository or a guideline at least?

When you say moving incorrectly classified samples could you give an example?

I'm referring to this post, but I can take care of that once your PR is merged.

is there a limit to the amount of samples one language can have in the Linguist repository or a guideline at least?

Yes, there's a limit because the resulting training file is loaded in memory. We usually limit ourselves to 2-3 sample files (with say, a few hundred lines per file) per file extension. We try to use sample files from "real" application (i.e., not sample files written for the occasion) because they are then used by the Bayesian classifier and in our tests.

Hmm, I feel like that should be done first @pchaigno, if there's a good reason it shouldn't though I'm happy to carry on with the other stuff.

I'll give some more information on the situation in case it comes in handy when you decide what to do.
AlliedModders LLC have produced and maintain a multitude of mods for games. The two that are relevant to this issue are AMX Mod X and SourceMod.
AMX Mod X is a server modification for GoldSrc games such as the original Counter-Strike. Plugins for this mod are written in CompuPhase's Pawn language formerly known as Small (this is where the .sma suffix comes from). The scripts themselves should always be suffixed with .sma and includes should always be suffixed with .inc.
SourceMod is a server modification for Source games such as the currently popular Counter-Strike: Global Offensive. Plugins for this mod are written in AlliedModders LLC's Pawn-modification SourcePawn (this is where the .sp suffix comes from). The scripts themselves should always be suffixed with .sp and includes should always be suffixed with .inc.
To add to the confusion SA-MP (San Andreas Multiplayer) also uses CompuPhase's Pawn language for its plugins. Luckily these plugins use the somewhat more common .pwn suffix for the plugins themselves and again they use the .inc suffix for includes.

The first thing I noticed is that in Linguist there is only PAWN and not Pawn, I had a quick look around online and couldn't find any other languages with the same name, just CompuPhase's Pawn, so that language should probably be renamed unless I'm mistaken.

While SourcePawn is based on Pawn it has built on it a lot in the past decade and I don't think it's really appropriate to umbrella the original under it anymore, not to mention the entire syntax changed from Pawn's in mid-2014 to a completely new one. I think the AMX Mod X and SA-MP samples/grammars/suffixes need to be transferred to Pawn (or PAWN if it's not renamed).

CompuPhase's own Pawn examples use the .p suffix (i'm not sure what the .i files are for under /rpn) and their includes use .inc. You can see in their repository that the includes are being misclassified as SourcePawn.
As suggested in #2823 I think the appropriate action is to include .p, .pwn, .pawn and .sma as Pawn extensions.

That should be a good start, sorry for the long read 😖

Any update on this @pchaigno?

Also @lildude you previously said Linguist can use the .tmLanguage format for grammars, can it also use .tmLanguage.json or are these two easily convertable, I've never looked into TextMate grammars before but a quick search doesn't yield much information on this.
It seems there's a more up-to-date grammar being maintained for a vscode extension for SourcePawn and it's licensed under the MIT license 🎉.

Also @lildude you previously said Linguist can use the .tmLanguage format for grammars, can it also use .tmLanguage.json or are these two easily convertable, I've never looked into TextMate grammars before but a quick search doesn't yield much information on this.

From what I've seen .tmLanguage.json is generally generated from a .tmLanguage (plist) file and we certainly have a few grammars using .tmLanguage.json as the only option so I don't think there'll be any problems with using the JSON version rather than the PLIST version.

It seems there's a more up-to-date grammar being maintained for a vscode extension for SourcePawn and it's licensed under the MIT license 🎉.

🎉 Feel free to include a switch to this in your PR.

@Dillonb If your grammar or the vscode one perform better than the current one (you can check/demonstrate that quickly with Lightshow), we'd definitely welcome a pull request implementing the change. I can help for the pull request if necessary.

@pchaigno any chance we can open this issue again? Also, could you elaborate on b4a77abd82d9613f35790bc8e0b251ffd028542b, is this fork procedure needed if we switch to a different grammar?

Due to Dreae's support for newer language features, his grammar is most likely the best fit now. It does differ quite a bit from the currently used one though, choosing not to highlight punctuation or operators. It also lacks support for older syntax plugins (this syntax is deprecated now though). I've made some comparisons using Lightshow:

SourceMod 1.10 syntax plugin - austinwagner grammar (currently used grammar)

SourceMod 1.10 syntax plugin - Dreae grammar (proposed grammar)

SourceMod 1.6 syntax plugin - austinwagner grammar (currently used grammar)

SourceMod 1.6 syntax plugin - Dreae grammar (proposed grammar)

After looking through #3070 and #3208, I've seen that the grammar was only forked to the @github-linguist organisation because the author removed the grammar from the original repository.
There is another problem though, as with https://github.com/goodmind/language-typelanguage/pull/2, the new grammar contains an invalid key ($schema). I've opened a PR (https://github.com/Dreae/sourcepawn-vscode/pull/15) and hopefully it gets merged at some point in the near future.

The grammar you proposed does look better to me. Don't hesitate to open a pull request to switch once the issue is fixed.

@lildude @pchaigno @Alhadis any chance you can offer input on a possible heuristic for SourcePawn, specifically for its include files. Since they use a super common extension, I figure it might be good to include one.
There are 3 unique and common conventions that come to mind (x is a series of letters, numbers and underscores).

Double include prevention (same for old and new syntax).#if defined _x_included_?
    #endinput
#endif
#define _x_included_?

SharedPlugin struct.

<1.7 syntax.public SharedPlugin:__pl_x

>=1.7 syntax.public SharedPlugin __pl_x

Marking natives as optional.

<1.7 syntax.public __pl_x_SetNTVOptional()

>=1.7 syntax.public void __pl_x_SetNTVOptional()

Unfortunately I'm horrible at writing regular expressions and have no idea how Linguist actually requires or a match. This is what I came up with, but it's super long and ugly. Thanks in advance.
^(?:public\s(?:void|SharedPlugin)?(?::|\s)?__pl_.+|#if\sdefined\s(_.+_included_?)\n\s*#endinput\n#endif\n#define\s\1)

This is what I came up with, but it's super long and ugly.

It looks fine to me. Only recommendations I could make are adding quantifiers after each \s assertion (so mandatory whitespace becomes \s+ and optional blanks become \s*). Also, if multiple newlines are permitted, then \n should become \n+.
Otherwise, your expression looks fine. Sometimes it's impossible to keep a regex elegant or concise (particularly if the format doesn't support multiline/expanded expressions, like Perl and Ruby do).

It looks fine to me. Only recommendations I could make are adding quantifiers after each \s assertion (so mandatory whitespace becomes \s+ and optional blanks become \s*). Also, if multiple newlines are permitted, then \n should become \n+.
Otherwise, your expression looks fine. Sometimes it's impossible to keep a regex elegant or concise (particularly if the format doesn't support multiline/expanded expressions, like Perl and Ruby do).

Thanks for the advice! Seems I'll have to drop the first one as it was adopted by the SA:MP community at some point, so there's a chance that could be in Pawn files. Is it worth adding the stuff after [...]__pl_.+ or not in this case?
^public\s+(?:void|SharedPlugin)?(?:\s+|:)?__pl_.+(?:_SetNTVOptional)?$

Is it worth adding the stuff after [...]__pl_.+ or not in this case?

You know more about these languages than I do (my knowledge of both is zilch), but as long as these patterns are common and consistent, then go for it. 👍

You know more about these languages than I do (my knowledge of both is zilch), but as long as these patterns are common and consistent, then go for it. +1

Well, since there's a .+ in my regex, it seems it will match everything after that until the end of the line, possibly making everything after it redundant?

Ah, right. Change it to \S+ (matching only non-whitespace), or \w+ (matching only "word" characters, excluding any others that might be legal in the language's syntax for identifiers).

.+ is also quite costly. If you can limit that to \w+ to avoid unconstrained backtracking it's much better!

Ah, right. Change it to \S+ (matching only non-whitespace), or \w+ (matching only "word" characters, excluding any others that might be legal in the language's syntax for identifiers).
Changed it around a little and incorporated \S+, could you take a look. I'll leave all the possibilities it needs to match below too (each line is separate).

^public\s+(?:void|SharedPlugin)?(?:\s+|:)?__pl_\S+(?:\s*=)?(?:\s*{)?

public SharedPlugin:__pl_x=
public SharedPlugin:__pl_x =
public SharedPlugin:__pl_x={
public SharedPlugin:__pl_x= {
public SharedPlugin:__pl_x ={
public SharedPlugin:__pl_x = {
public SharedPlugin __pl_x=
public SharedPlugin __pl_x =
public SharedPlugin __pl_x={
public SharedPlugin __pl_x= {
public SharedPlugin __pl_x ={
public SharedPlugin __pl_x = {
public __pl_x_SetNTVOptional()
public void __pl_x_SetNTVOptional()

Isn't [a-zA-Z0-9_] equivalent to \w?

Isn't [a-zA-Z0-9_] equivalent to \w?

Eh... according to POSIX, yes. But modern, Unicode-aware engines like (Perl and Oniguruma) treat \w as equivalent to \p{Word} (having the Unicode "word" property), unless a modifier like /a is enabled to restrict matching to ASCII expectations ([a-zA-Z0-9_]).
perlrecharclass(1) actually has a whole subsection dedicated to discussing "word" characters.

Is the engine GitHub uses still a mystery?

Going by earlier discussion, it seems GitHub forces ASCII locale to significantly speed up processing. Contrary to what I originally believed, the engine responsible for processing grammars is actually PCRE-based, not Oniguruma (GitHub have a Ruby-fuelled pipeline, so it's only natural to assume it powered their highlighting too).
Unfortunately, the syntax highlighting software is closed (or mixed) source, meaning we can't openly see what's driving everything...

I guess I'll leave it as is then since we don't really know the state of the engine, and its future.

Going by earlier discussion, it seems GitHub forces ASCII locale to significantly speed up processing.

So unless it changed, \w should be the same as the above on GitHub, right? We're already using \w in a lot of places in the heuristic rules, so I think it would be better to use it here too, at least to improve readability.

Well, one can't simply swap out a language's regex engine and expect an ecosystem of dependencies to not break with incompatible syntax... so I'd say whatever GitHub are using for highlighting, it's a different runtime/environment/whatever to Ruby.
That being said, I don't know enough about Ruby's (apparently convoluted) locale-handling to guess whether Linguist is running with Unicode-awareness...

@Alhadis if we merge #4518 before #4517 can we test this out?

Create a repository with a misclassified .inc file (it's quite easy to get a SourcePawn include misclassified as C++ at the moment).
Commit the line(s) detected by the heuristic with and without Unicode word characters and see if the detection changes.

Would that work or am I missing something?

Create a repository with a misclassified .inc file

You won't need to do that. Linguist includes an executable that can analyse a specific file:
$ bin/github-linguist ~/tmp/script.py
info: 2 lines (1 sloc)
  type:      Text
  mime type: text/plain
  language:  Python

See command-line usage for more info, or consult an unofficial man page I wrote because I needed another Roff fixture to test #4433. 😜

@lildude Ruby question: what's the difference between bundle exec bin/github-linguist and running the executable from command-line directly?
I noticed the former doesn't always pick up my local changes (such as when I'm testing a heuristic), and the latter requires me to gem install … Linguist's dependencies globally (with the tradeoff that it manages to pick up every change I make to a file...)

bundle exec runs the ruby script in the context of the gems specified in the Gemfile ie it uses the gems and versions specified in the Gemfile rather than the system or user installed versions, which may have incompatible differences between versions.
Both should pick up your local changes though. Both also require you to install the gems specified in the Gemfile, with script/bootstrap doing the magic for you when follow the contrib docs.

Both should pick up your local changes though. Both also require you to install the gems specified in the Gemfile

Oh, I figured that. I was wondering if the presence of a .bundle/ directory (along with tmp/ which contained untracked copies of tracked source code) may have been interfering with the bundle exec step. 😅
Thanks! That clears up a lot of confusion now... bundle exec must be Ruby's equivalent of npm install . (concerning local VS globally-installed dependencies).

Create a repository with a misclassified .inc file

You won't need to do that. Linguist includes an executable that can analyse a specific file:

Hmm, I gave it a go but if I include non-ASCII characters to test it, I get:
bundler: failed to load command: bin/github-linguist (bin/github-linguist)
ArgumentError: invalid byte sequence in US-ASCII
    /home/user/linguist/lib/linguist/blob_helper.rb:279:in `split'
    /home/user/linguist/lib/linguist/blob_helper.rb:279:in `lines'
    /home/user/linguist/lib/linguist/blob_helper.rb:341:in `loc'
bin/github-linguist:59:in `<top (required)>'

@X6B0ISI09wD4 you need to be using a UTF-8 compatible locale, eg en_US.UTF-8. Either set it in your env or set it when executing bundle exec: LANG=en_US.UTF-8 bundle exec bin/github-linguist ...

@X6B0ISI09wD4 you need to be using a UTF-8 compatible locale, eg en_US.UTF-8. Either set it in your env or set it when executing bundle exec: LANG=en_US.UTF-8 bundle exec bin/github-linguist ...

Thanks! Seems \w is limited to [a-zA-Z0-9_] then, as a á in the token won't trigger the heuristic.

as a á in the token

Tip: When verifying how UTF-8 input is handled, try to avoid using characters from the Extended Latin block (U+0080 — U+00FF, a.k.a, "Latin-1").
The reason is that if you're dealing with a program with faulty or unpredictable locale-handling, there's a risk that any byte above 0x7F is treated as a single-byte encoding, rather than UTF-8. So you might end up with false positives/negatives, depending on how bad the program's encoding support is.

Tip: When verifying how UTF-8 input is handled, try to avoid using characters from the Extended Latin block (U+0080 — U+00FF, a.k.a, "Latin-1").

Thanks for the tip. So there's a chance some programs could interpret it as two separate ASCII characters and match the \w+? I assume since it didn't match even with á it's fine, but I tried again with α and the result was the same.

So there's a chance some programs could interpret it as two separate ASCII characters and match the \w+?

Honestly, no. It's just a safeguard against a worst-case scenario, such as iif both input and output are being received incorrectly. For instance, â in UTF8 is 0xC3 0xA2, but 0xE2 in Latin-1. UTF-8 is backwards compatible with ASCII by design, so a transparent encoding change from UTF-8 to Latin-1 would remain unnoticed to a reader.
Conversely, ช (UTF8: 0xE0 0xB8 0x8A) becomes à¸ when converted to Latin-1. So a corruption would be recognisable immediately.


Cleanup: simplify the class namespace system

At the moment it's four separate name-to-adhoc-object properties

It's now more structured


Missing Contributing.md file

Missing Contributing guidelines file in the repo to provide clear guidelines to the contributors. I can add it
Please assign me this issue under Gssoc'23 @Yash-Parsana

Already present in Readme file i think i is enough.


fix(ssg): remove frame-ancestors from meta

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Closes #329
Description

Removes the frame-ancestors CSP directive in SSG mode.
As stated in the MDN Doc, this directive is not supported in the meta element.
Fixes Chrome complaining of the same:

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes (if not applicable, please state why)

Thanks @vejja for this fix 💚
I will publish a patch version with it!


When using Core Command API to update the device opState/adminState with an inexistent id(or name) , 404 should be returned

OS version: ubuntu 16.04
EdgeX version: 1.0.0
Environment details: Docker container
Steps to reproduce:

start up EdgeX
send put command with an inexistent id(or name) to /device/{id}/adminstate/{adminState} of Core Command API
for example, with the following request URL:
Method: PUT
URL: http://localhost:48082/api/v1/device/57f7937ae4AAAAe2d67c20b5/adminstate/LOCKED

Actual results: Got returned http status code 500 InternalServerError
Expected results: Got returned http status code 404 NotFound
RAML:

https://github.com/edgexfoundry/edgex-go/blob/master/api/raml/core-command.raml#L100
https://github.com/edgexfoundry/edgex-go/blob/master/api/raml/core-command.raml#L123
https://github.com/edgexfoundry/edgex-go/blob/master/api/raml/core-command.raml#L168
https://github.com/edgexfoundry/edgex-go/blob/master/api/raml/core-command.raml#L191

Fixed by PR#919


[FEATURE] @With - add boolean attribute control clone vs. mutation

I want to use @With Lombok on my JPA entities and can't have them making new instances of themselves. Therefore, I propose adding a boolean attribute to @With that controls if a new object is returned or the current instance is mutated.
Per @With documentation Lombok generates the method
  public WithExample withName(String name) {
    return this.name == name ? this : new WithExample(name, age);
  }

whereas @With(clone=false) would generate
  public WithExample withName(String name) {
    this.name = name;
    return this;
  }

The default of the new attribute should be the current behavior so that this is 100% backwards compatible.

You can archive something similar (with different method names) using @Accessor. I think that the idea of @With is to create setters for immutable objects, at least that is what the documentation says.

You can archive something similar (with different method names) using @Accessor. I think that the idea of @With is to create setters for immutable objects, at least that is what the documentation says.

We use the with prefix for immutables. What you want is a setter in combination with chaining accessors.

We use the with prefix for immutables. What you want is a setter in combination with chaining accessors.


K8SPG-506: add backup name to pg-backup status

https://perconadev.atlassian.net/browse/K8SPG-506
DESCRIPTION
Problem:
To restore a backup, the user needs to execute kubectl exec -it cluster1-repo-host-0 -- pgbackrest info to obtain the backup name.
Solution:
The operator should add a new field called .status.backupName to the pg-backup. The operator will retrieve the backup name from pgbackrest info.
To differentiate backups in the pgbackrest info output, the operator should add the following annotations to the pgbackrest backups:

percona.com/backup-name for manual backups that contain the pg-backup name.
percona.com/backup-job-name for all completed backups containing the backup job name.
percona.com/backup-job-type for replica-create backups containing the value replica-create.

Additionally, this PR adds the pgv2.percona.com/pgbackrest-backup-job-type annotation to every pg-backup to distinguish between replica-create and manual backups.
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Are the manifests (crd/bundle) regenerated if needed?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PG version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

custom-extensions
failure

demand-backup
failure

init-deploy
failure

monitoring
failure

operator-self-healing
skipped

scaling
skipped

scheduled-backup
skipped

self-healing
skipped

start-from-backup
skipped

telemetry-transfer
skipped

upgrade-minor
skipped

users
skipped

We run 4 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/d51ff6a357165d6e870b2bde69b57ca2d6824453
image: perconalab/percona-postgresql-operator:PR-722-d51ff6a35

Test name
Status

custom-extensions
failure

demand-backup
failure

init-deploy
failure

monitoring
failure

operator-self-healing
skipped

scaling
skipped

scheduled-backup
skipped

self-healing
skipped

start-from-backup
skipped

telemetry-transfer
skipped

upgrade-minor
skipped

users
skipped

We run 4 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/239f0a1ee0eda936cb042ef00ad7b244c7610932
image: perconalab/percona-postgresql-operator:PR-722-239f0a1ee

Test name
Status

custom-extensions
failure

demand-backup
failure

init-deploy
failure

monitoring
failure

operator-self-healing
skipped

scaling
skipped

scheduled-backup
skipped

self-healing
skipped

start-from-backup
skipped

telemetry-transfer
skipped

upgrade-minor
skipped

users
skipped

We run 4 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/239f0a1ee0eda936cb042ef00ad7b244c7610932
image: perconalab/percona-postgresql-operator:PR-722-239f0a1ee

Test name
Status

custom-extensions
passed

demand-backup
failure

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
failure

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/dc7d326e239efb2c5a3e67f522b6c6e6ef9c3e58
image: perconalab/percona-postgresql-operator:PR-722-dc7d326e2

Test name
Status

custom-extensions
passed

demand-backup
failure

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
failure

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/17983f4a9a134e3a00240dea30ff4185c427c441
image: perconalab/percona-postgresql-operator:PR-722-17983f4a9

Test name
Status

custom-extensions
passed

demand-backup
failure

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
failure

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/b8294c621df0cc08c8ab2abcf9c4b324fe5bb73e
image: perconalab/percona-postgresql-operator:PR-722-b8294c621

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
failure

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/07627f0cc53bb8eea5b1533d5ff606e6890ef456
image: perconalab/percona-postgresql-operator:PR-722-07627f0cc

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
failure

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/a60124d77dd0743585c22e9e1f489a267e956ac0
image: perconalab/percona-postgresql-operator:PR-722-a60124d77

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/3561aa711ffe77c79680cc0e3d7f0946e8cb9b8e
image: perconalab/percona-postgresql-operator:PR-722-3561aa711

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/fe137935734f97e71347245bd571c7a45751f74f
image: perconalab/percona-postgresql-operator:PR-722-fe1379357

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
failure

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/9ad9f13d84f9036024e88ddb3cdd0a03e3441805
image: perconalab/percona-postgresql-operator:PR-722-9ad9f13d8

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/6ab0b21a0e78f7f44df007b641e726f4e3647cb3
image: perconalab/percona-postgresql-operator:PR-722-6ab0b21a0

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 13 out of 13

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/0be5b29f617e1cd6f4e23b150b0b2ccec3306f04
image: perconalab/percona-postgresql-operator:PR-722-0be5b29f6

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
failure

start-from-backup
passed

tablespaces
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 13 out of 13

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/0ea45fd1b349e789afa5a59d15d430b522b57e44
image: perconalab/percona-postgresql-operator:PR-722-0ea45fd1b

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

tablespaces
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 13 out of 13

commit: https://github.com/percona/percona-postgresql-operator/pull/722/commits/0ea45fd1b349e789afa5a59d15d430b522b57e44
image: perconalab/percona-postgresql-operator:PR-722-0ea45fd1b


Attribute binding mismatching Roslyn code fixers

Introduces Roslyn code fixers for the attribute binding mismatching diagnostics.
They essentially change the wrong type for the expected type.
Besides the 3 code fixers, I had to do some small refactoring to our test infrastructure to allow the fixers to be tested.

https://github.com/microsoft/durabletask-dotnet/assets/13934447/c040e924-7739-46f2-852a-cf753f2cb11f


Display Human-Readable Memory Usage

Current memory usage is shown in percentage, make it more understandable to display the memory usage in GB or MB.

hi :)

can i try to solve this?

!assign @Eggz2258

!assign @Eggz2258

you are assigned, you have 30 mins to solve it. if you are close please msg me to extend time

can u assign
?

please assign

someone is already working on the issue

Can I have extended time, I just finished dinner
On Fri, Oct 18, 2024, 8:45 PM Ameya Khanzode @.***>
wrote:

someone is already working on the issue
—
Reply to this email directly, view it on GitHub
https://github.com/acmpesuecc/Process-manager/issues/2#issuecomment-2422707194,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BL5O6NQDP5FXGZANF2U56QLZ4EQZPAVCNFSM6AAAAABQDL3GKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSG4YDOMJZGQ
.
You are receiving this because you were assigned.Message ID:
@.***>

hi, please assign!

@AmeyaKhanzode Can I get this ?

Can you please Assign this to me.

!deassign @Eggz2258

can i get assigned plspls

Can I get assigned please

assign me to this plz

Can I get assigned to this?

Can I get the issue


fixed issue with passing image files through api url

The current 'require_once' for images doesn't work (even though the content-type is set.  The size is not set and the file fails.  I modified it to pass through all files that are not php or md so you get a more accurate response from the webserver.

I would like to go ahead and merge this.  Would you mind making a pull request for the testing branch instead?

going to re-do pull request to test.


Fix CI tests to not depend on big Chrome window size

Removes the workaround for this https://github.com/Leaflet/Leaflet/issues/7113#issuecomment-619528577
Should make the tests slightly faster and look nicer.

Wow such a easy solution 😄


Conditional breakpoint prompt should offer to enable (not disable) breakpoints if breakpoint is already disabled

Create a conditional breakpoint
Click on the breakpoint in the gutter to get the "Disable instead of remove?" prompt
Click "Disable breakpoint"
Click on the breakpoint again in the gutter

The dialog that pops up asks if you want to disable the breakpoint instead of removing it; but it's already disabled. It would be better to ask if the user wants to remove it or enable it since it feels quite natural to re-enable it via the path you disabled it.

This is a fair feature request and we accept PRs that fix this.
Code pointer https://github.com/Microsoft/vscode/blob/8f47ba52a023fa8e9707f805a7dc771170326e7a/src/vs/workbench/parts/debug/electron-browser/debugEditorContribution.ts#L201


Add development setup instructions

Today, we don't have good instructions on how to get set up with a development environment for tf-encrypted.

We should also take the time to expand upon our external install instructions as well (including how to install using conda).

Custom ops building for upcoming secure random PR:
Assuming python/anaconda and tf-encrypted has been bootstrapped.
Ubuntu
sudo apt install libtool automake g++
make build

Note: Other linux dist should work similar to this
MacOS
Assuming brew is installed.
brew install libtool automake

@mortendahl anything to add here?


Add support for treectrl

Add support for https://docs.wxpython.org/wx.TreeCtrl.html

  if 'root' in props:
        value = props.get('root')
        root = instance.AddRoot(value)

Perhaps I should add a 'tree' rather than a 'root'?  This tree format could be nested or  flattened as I have done beklow:
{
  'root': {
      'label': 'Root',
      'data': {
           'id': '123456'
      },
      'children': [
          'node1', 'node2'
     ]
  },
  'node1': {
       'label': 'Node 1',
      'data': {
           'id': '123457'
       }
   },
  'node2': {
       'label': 'Node 2',
      'data': {
           'id': '123458'
       }
   }
}

Perhaps I should add a 'tree' rather than a 'root'? This tree format could be nested or flattened as I have done below:

Yes, exactly. re-wx is a Model-View-Update framework, so we should never allow the view to update itself, like this:

self.Bind(wx.EVT_TREE_ITEM_RIGHT_CLICK, self.on_tree_item_right_click)
self.root = self.AddRoot('Root ')
self.SetItemHasChildren(self.root, True)

The view should update the model only.
The model is the tree props. The tree props should specify the entire tree. On every render, the component should delete the entire tree from the root and then re-create the tree from the tree props.
And if I were you, I would not flatten the tree props. I would express it something like this.
{
      'label': 'Root',
      'data': {
           'id': '123456'
      },
      'children': [{
          'label': 'Node 1',
          'data': {
               'id': '123457'
           }
       },
       {
          'label': 'Node 2',
          'data': {
               'id': '123458'
           }
       }]
}

TreeCtrl is going to be a very difficult component to wrap. Because really what we want to do is diffing and reconciliation on the tree. That's how we would avoid blindly deleting the entire tree and recreating it with every render. But we can’t use the re-wx patch diffing and reconciliation function on the tree, since the tree items are not wx.Windows with children.

The ComboBox control deletes and re-creates all of its elements on every render.
https://github.com/chriskiehl/re-wx/blob/70116d88658e9b73e3250e8243ca438474f94629/rewx/widgets.py#L273-L275


[graphiql] Fragment variables not supported

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
  fragment Fragment on AccountsConnection {
    nodes {
      id
      name
      balance(endDate: $date) {
        number
        currency
      }
    }
  }

  # ERROR Variable "$date" is never used in operation "Accounts".GraphQL: Validation
  query Accounts($startsWith: String!, $date: Date = "2024-03-24") {
    accounts(filter: { name: { startsWith: $startsWith } }, orderBy: NAME_ASC) {
      ...Fragment
    }
  }

Has flag this validation error on the Account query: Variable "$date" is never used in operation "Accounts".GraphQL: Validation. Actual code works as expected.
graphql.config.js
const config = {
  schema: "http://ds720.local:3000/graphql",
  documents: ["app/**/*.tsx"],
};

Using VSIX release found here: https://github.com/graphql/graphiql/pull/3521
Expected Behavior
Doesn't show validation error.
Steps To Reproduce
No response
Environment

GraphiQL Version: v0.9.3 from (https://github.com/graphql/graphiql/pull/3521)
OS: MacOS 14.1.1 (23B81)
Browser:
Bundler:
react Version:
graphql Version:

Anything else?
No response

this just means we need to update graphql, or we need to re-use the version in the project if it's available. these rulesets are entirely determined by the graphql version the LSP is shipping with currently

I am having this problem only intermittently so I suspect it may be something wrong with my development environment. Feel free to close this issue if you think it's not related to this package.

Thank you! It still may be a problem on our end if I'm incorrect, so I'm going to keep this open until I have time to add tests to confirm that it works as it should, and fix the bug if not

it appears we're still bundling with the latest version of graphql, so perhaps the latest specifiedRules still need to be updated to make this the default? these are what we use as the default rules for validation, and then the custom validation rules can be specified. if there is something we need to override to make this possible we can - for example, replacing the rule i linked to with another that supports fragment variables, or whatever path they chose to implement this spec


smaller layout

fixing this PR: https://github.com/davidlago/mbta-ninja/pull/64
"I made some small edits to the app's layout - specifically the homepage (logo smaller re: #39, added some color to the MBTA) and to the nav bar on line pages (clearer back button, smaller text in a few places). Obviously the visual edits are somewhat subjective, but I think these are good improvements for the usability. On iPhone 4 sized screens, almost all of the lines were being pushed below the fold because of the large title, subtitle, and logo."

Sorry for the back and forth with the rebases... but this can no longer merge directly since the refactoring in #85 today. I'm happy to cherrypick the changes and create a new PR with them, but I don't want to take credit for your work... your commit should make it to the codebase :)
Let me know if you want to submit a rebased one, or you want me to manually merge it myself.
Thanks again!

@davidlago good to go

Awesome, thanks!


Add better SEO

It would be nice to have a module to ease SEO.
Check on https://www.drupal.org/project/yoast_seo

Seems not to work (yet?) with paragraphs, although module claims it works with Paragraphs (see https://www.drupal.org/project/yoast_seo/issues/2573899)


[Grow]Timeout props

We could just use the component's timeout props.  :)

[ ] I have followed (at least) the PR section of the contributing guide.

conditionally applies the timeout property to change the entry speed.

@Thyix This changes the documentation description behavior. What's the motivation?

I was just using it, and wondered if you could use timeout props without adding a condition after the in props. After seeing that it worked, I thought it could be a nice fix for the future users :)

@Thyix Ok thanks, your use case is valid but change what we want to demonstrate. I have added a comment in this pull request diff.


Error "Fatal read error on pipe transport"

Fatal read error on pipe transport
protocol: <asyncio.streams.StreamReaderProtocol object at 0x03B24410>
transport: <_ProactorSocketTransport closing fd=536>
Traceback (most recent call last):
File "C:\Users-----\AppData\Local\Programs\Python\Python37-32\lib\asyncio\proactor_events.py", line 255, in _loop_reading
data = fut.result()
File "C:\Users-----\AppData\Local\Programs\Python\Python37-32\lib\asyncio\windows_events.py", line 732, in _poll
value = callback(transferred, key, ov)
File "C:\Users-----\AppData\Local\Programs\Python\Python37-32\lib\asyncio\windows_events.py", line 428, in finish_recv
return ov.getresult()
OSError: [WinError 121] The semaphore timeout period has expired

It seems that exception is a duplicate of https://github.com/alexbers/mtprotoproxy/issues/40. It should be fixed in the master version and now it is merged to the stable branch also. Could you retry with the latest version.