Can not comment when linked to a specific comment

Click the notification bell.
Click a comment notification and wait to be redirected to the video page containing that comment.
Try to respond.
"Comment failed to post" appears under the comment box and your comment will not post.
Problem does not occur with Youtube Center disabled and the page refreshed.

Doesn't allow commenting (example taken from one of my notifications): https://www.youtube.com/watch?v=dvnusql0p7U&lc=z12ocxlj2p33ztbzq04cix3hptf0zvgjd0c.1486840237542007
Commenting works fine: https://www.youtube.com/watch?v=dvnusql0p7U
Latest Userscript Firefox Developer Build of Youtube Center
latest stable Firefox x86
latest Firefox x64 Beta
Windows 10 x64
Has been a problem for a few months, never narrowed it down to Youtube Center until now. I previously figured it was a issue on Youtube's end since they changed their notification system and eliminated the inline notification commenting (I hate that they got rid of this functionality).

I have not had any major problem (except see below) with commenting until this new commenting system.
It's not working at all any more. Same errors as OP.
Chrome latest. Using YtC as extension.
Why on earth google decided to get rid of the inline notif system is beyond me. That's the only system that have been working flawless all the time.
 That's been broken for quite some time. Not the reply it self but person you reply to dont get "tagged".

I have this same problem, and upon deactivating YT Center the comment will then be able to post. The weird thing is that it doesn't always happen, I can sometimes comment with it on, though most of the time it fails. I have no other scripts running either, and disabling YT Center upon having the failed to post notification fixes it.


Add UDP server to gRPC.

(Trying this again, with correct email associated with commits.)
Preparation for experimentation with QUIC as a transport.
ctiller: This is the result of our discussion over email. Structure is very similar to the existing tcp_server code.
This pull request isn't quite ready for review: the test_receive test hangs at the destroy_pollset call. I'd appreciate it if you could take a look at how I've wired things up, and see if you can spot what's going on.
I'm also unclear if the read callback/write methods in udp_server.h look sensible, PTAL.
Thanks!

Can one of the admins verify this patch?

Before this goes any further: is it required that this pull request be coming from my @google.com account, rather than personal address? The googlebot's comment suggests it might not be complaining if this was the case. Let me know, and I can create a new pull request with the right address (I don't think I can modify this one).

You can send from your personal request... but you'll need to sign the CLA
(which should mostly be a click through)
On Fri, Jul 10, 2015 at 1:56 PM Robbie Shade<EMAIL_ADDRESS>wrote:

Before this goes any further: is it required that this pull request be
coming from my @google.com account, rather than personal address? The
googlebot's comment suggests it might not be complaining if this was the
case. Let me know, and I can create a new pull request with the right
address (I don't think I can modify this one).
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/2376#issuecomment-120523860.

ctiller: Can you take a look, and advise on how I should be triggering reads from the UDP socket? The udp_server_test goes into an infinite loop calling grpc_pollset_work, as I believe this never triggers a read. It's not clear to me how the new UDP server code should interact with pollsets.
$ make udp_server_test && ./bins/opt/udp_server_test

I just started to look at this today. It seems in the test your client socket is connecting to an empty addr. You may want to expose get_fd from udp_server.h and copy the part about svrfd from tcp_server_posix_test to make the connect() work.
With that change a test_receive(10) can pass but there are future events polluting the later test cases. I am still looking to understand why.

Another problem is in on_read, the case where success == 0 is not handled. With that fixed, all test cases pass. You can take a look at commit https://github.com/grpc/grpc/commit/fabefe10e31a635430365e703d6aa2eb14b91721 for a minimal fix.
What is still lacking is the actual reading part in udp_server.c on_read.

Thanks for the comments, tests now passing, branch is now up to date.
Your comment about implementing reading in udp_server.c on_read: this calls the server port's read_cb which is where I intended to actually do the reads. See the example in udp_server_test.c. Does that seem sensible?

This is ok to test.

It seems it has not picked up some recent api change and is not building.


[Juno REPL: BUG] Accent characters doesn't behabe as they do in Julia

When trying to type ^2 it doubles the latest character as 22, if spacebar is not used after the accent circumflex character ^. Indeed it happens with other accent characters as well, for instance ´p produces pp and so on.
Details

Atom version: 1.44.0
Julia version: 1.3.0
OS: Windows 10
Package versions:

Atom.jl: 0.12.7
julia-client: 0.12.2
ink: 0.12.2

Steps to reproduce

Go to the REPL
Type ^ (or some other acent) followed by some character which doesn't accept accentuation.
That character will be doubled.

I encounter the a different problem: in Juno's REPL, any accent (acute, grave, circumflex, diaeresis...) followed by a character that should accept it, is ignored (i.e. vowels are printed without accent, and numbers are regular, not superscript). If the accent is followed by a character that does not accept it, nothing happens (as it should be).
My details:

Atom 1.47.0
Julia 1.1.0
OS: Ubuntu 16.04
Packages:

Atom.jl 0.12.11
julia-client 0.12.5
ink 0.12.4

After trying in Windows, I'd say that the difference in the bug is related to the OS (doubled characters in Windows, accents ignored in Ubuntu).

This is an upstream bug we can't really do anything about.


Questions about training config options (speed_perturb: False)

@ductuantruong
Thank you for sharing your excellent research.
I would like to inquire about training config options.
It is known that applying speech perturbation in speaker verification performance helps improve model generalization performance.
However, in the training config you shared, the speech perturb option is set to "False".
When I train the model by changing the speech perturb option you shared to "True", an error occurs as shown below.
 Traceback (most recent call last):   File "/home/azureuser/data2/enskd/wespeaker/bin/train.py", line 254, in <module>     fire.Fire(train)   File "/home/azureuser/miniconda3/envs/wespeaker/lib/python3.9/site-packages/fire/core.py", line 141, in Fire     component_trace = _Fire(component, args, parsed_flag_args, context, name)   File "/home/azureuser/miniconda3/envs/wespeaker/lib/python3.9/site-packages/fire/core.py", line 466, in _Fire     component, remaining_args = _CallAndUpdateTrace(   File "/home/azureuser/miniconda3/envs/wespeaker/lib/python3.9/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace     component = fn(*varargs, **kwargs)   File "/home/azureuser/data2/enskd/wespeaker/bin/train.py", line 224, in train     run_epoch(train_dataloader,   File "/home/azureuser/data2/enskd/wespeaker/utils/executor.py", line 73, in run_epoch     aux_loss = aux_criterion(outputs, teacher_logits, targets, epoch)   File "/home/azureuser/miniconda3/envs/wespeaker/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl     return forward_call(*input, **kwargs)   File "/home/azureuser/data2/enskd/wespeaker/models/dkd_loss.py", line 70, in forward     loss_dkd = min(epoch / self.warmup, 1.0) * dkd_loss(   File "/home/azureuser/data2/enskd/wespeaker/models/dkd_loss.py", line 12, in dkd_loss     pred_teacher = cat_mask(pred_teacher, gt_mask, other_mask)   File "/home/azureuser/data2/enskd/wespeaker/models/dkd_loss.py", line 46, in cat_mask     t1 = (t * mask1).sum(dim=1, keepdims=True) RuntimeError: The size of tensor a (5994) must match the size of tensor b (17982) at non-singleton dimension 1

Hi @greatnoble,
Thank you for your interest in our work. We didn't use speech perturbation during training because the Wespeaker framework considers the augmented audio (by speech perturbation) as new speakers due to the pitch shift after the augmentation (https://arxiv.org/pdf/2210.17016.pdf). Therefore this will make the total number of speaker classes larger than the original training set (as shown in error log:  17982 & 5994). However, in this work, the proposed method is label-level knowledge distillation, hence the number of output speaker classes between student and teacher model must be the same. And, the WavLM-ECAPA model has 5994 speaker classes (number of speakers in Vox2 train set ). Therefore, we didn't use speech perturbation in order to keep the number of speaker classes identical in both the student and teacher models.
If you want to use speech perturbation without changing the number of speaker classes. You can simply remove this line of code.  However, I believe if you apply speed perturbation in an utterance, the speaker characteristic of the origin and augmented utterances will be different.
If you feel my reply answers your question, please help me close this issue. And, if you find our code helpful, a star to this repo is much appreciated.

@ductuantruong
Thank you for the detailed explanation.
It was a great help in understanding your paper.
Thank you for sharing your very impressive speaker recognition research results.


meaning of .lanes.txt annotations file in CULane

I have been trying to figure this out for a while now. But I don't seem to get exactly is the meaning of the annotations file in the CULane dataset because at first, I thought those points represent the coordinates of the key points in the lane but the coordinates more often than not are beyond the sizes of the image. If the images have been resized to some new standard size then it is not mentioned on the official page of CULane nor can I find some standard size of the image. How can I interpret/retrieve the actual coordinates of the lanes?
Any ideas?

The original annotation is indeed the coordinates of the key points in the original image. Using the official scripts of CULane can generate the segmentation maps automatically.


Bug: Onagre automatically launches first application on consecutive runs

Describe the bug
I built the application with Nix and also updated the Nix package here. Currently, we are facing the issue that Onagre automatically launches the first item from the suggestion list for every startup after the first one. (The first one works just fine).
To Reproduce

Install the Nix package manager.
Clone git@github.com:Septias/nixpkgs.git
Execute nix run nixpkgs#nixpkgs-review -- pr 290409.
Run the application ./result/bin/onagre

** Addtional Info**:
The logs for cargo run and ./result/bin/onagre look exactly the same. The latter only produces the logs which happen when one application is opened automatically.
I tested on Wayland and x11 and they both produced the same problem.

Thanks for the report.
Just to be sure I understand the issue correctly.
You launch onagre once, everything works. Then on subsequent launches, it opens then start the first suggestion item before you can type a search. Correct ?
Can you provide a bit more context so I can try to reproduce that (pop-launcer version,  desktop environment etc).

Idk how much that helps you though...

Can you provide the onagre and pop-launcher version ?


Add dist directory

I want to use jsdelivr cdn,But there is no compiled code,Hope to add dist directory.
https://www.jsdelivr.com/package/npm/fluid-player

Any particular reason you do not want to use Fluid Player CDN?

Jsdelivr cdn can accelerate globally,Fluid Player CDN can not accelerate globally.
Jsdelivr cdn own large user base
Popular js libraries basically support the dist directory,such as jquery,hls.js,vue.js

jquery
hls.js
vue.js

Jsdelivr cdn can accelerate globally,Fluid Player CDN can not accelerate globally.
I am not sure how you arrived at such conclusion. Can you elaborate?

Jsdelivr cdn own large user base
Popular js libraries basically support the dist directory,such as jquery,hls.js,vue.js

Many libraries do many different things for equally many different reasons and to support wide variety of use cases. In the case of Fluid Player creating a single build file is not currently possible because Fluid Player is using opportunistic code splitting (webpack chunking specifically) and loads several JS modules on-demand.
What it means is you can not just create a dist and publish it and have it work out of the box everywhere. The whole code splitting function was implemented to minimize the grand total runtime code size - whenever you load Fluid Player from Fluid Player CDN it will aim to load vendor dependencies only when necessary - for example, hls.js will only be loaded IF you have at least one HLS source embedded. Same goes with DASH, Panolens and others. In fact, future releases will use the same approach to split off some heavier parts of the Fluid Player code too. This works when Fluid Player is bundled using Webpack, on CDN and all other bundlers that support code splitting based on async require.
This opportunistic loading has cost - it is necessary to know from where to load the vendor dependencies. Our current CDN distributions have the path bundled during build time as opposed to the old approach of determining that during runtime which was buggy and didn't always work.

No feedback. Closing.


Maintenance across mappers

sorted all mappers
moved some misplaced mappers from v2 into proper folders
rewrote some older mappers
adjusted tests where needed

I understand what codacy is saying but don't think it's worth fixing as it worked before and doesn't seem relevant.


Add telemetry to look for jupyter lab/notebook

Codecov Report

Merging #9903 (055a223) into main (46a2afc) will decrease coverage by 0%.
The diff coverage is 40%.

:exclamation: Current head 055a223 differs from pull request most recent head 230624d. Consider uploading reports for the commit 230624d to get more accurate results

@@          Coverage Diff          @@
##           main   #9903    +/-   ##
=====================================
- Coverage    63%     62%    -1%
=====================================
  Files       203     210     +7
  Lines      9827   10083   +256
  Branches   1564    1586    +22
=====================================
+ Hits       6242    6344   +102
- Misses     3086    3239   +153
- Partials    499     500     +1

Impacted Files
Coverage Δ

src/platform/terminals/helper.node.ts
22% <22%> (ø)

...hellDetectors/userEnvironmentShellDetector.node.ts
22% <22%> (ø)

...inals/shellDetectors/settingsShellDetector.node.ts
24% <24%> (ø)

src/platform/terminals/shellDetector.node.ts
32% <32%> (ø)

...shellDetectors/vscEnvironmentShellDetector.node.ts
35% <35%> (ø)

...s/shellDetectors/terminalNameShellDetector.node.ts
35% <35%> (ø)

...terminals/shellDetectors/baseShellDetector.node.ts
70% <70%> (ø)

src/platform/terminals/serviceRegistry.node.ts
100% <100%> (ø)

src/platform/terminals/types.ts
100% <100%> (ø)

src/platform/errors/errorHandler.ts
66% <0%> (-2%)
:arrow_down:


Point to a standard license URL in POM

Using a standard license URL allows companies to automate validation of third-party library licenses. Because this library points to its own repository for the license, each company would have to manually allow-list it. For instance, Square uses https://github.com/cashapp/licensee that maintains a list of common URLs used for MIT License: https://github.com/cashapp/licensee/blob/4ae8efb9b5a8ea34dcf35d200154e097347f1d9d/src/main/kotlin/app/cash/licensee/licenses.kt#L76:L79

👍


CUDA Memory Error During Training on k80

Hello,
I have been trying to train your awesome work on my custom dataset, however, I get the following error on a k80 irrespective of Batch Size (even tried with BS = 1).
RuntimeError: CUDA out of memory. Tried to allocate 124.00 MiB (GPU 0; 11.17 GiB total capacity; 10.65 GiB already allocated; 94.31 MiB free; 10.68 GiB reserved in total by PyTorch)
Would appreciate any help in this regard so that I might be able to put the model on training as soon as possible.
Thanks.

I've just submitted a change that should substantially reduce memory use during training and inference. Let me know if that works out for you -- if not, there may be some other factor at play.


Option to render a status summary line in gif

Should be able to be disabled

Should also be able to have it so it shows all future runs grayed out... even if the status is actually known

[ ] Basic positioning of it
[ ] Render gray for the ones in the future
[ ] Render immediately below the diagram
[ ] Allow disabling it


fix: enable prometheus endpoint

Adds a missing route registration for the /prometheus endpoint and includes the relevant changelog entry.

Ahh you are correct! Thank you <3

Yes you correct! Thank you 💕


auto tagging

Is it possible to tag an user automatically  on creation of editor

Yes, you can use the quill API: https://quilljs.com/docs/api/#inserttext


Feature/html resources

Converted curricula and assessment resources from PDFs to HTML so they can be translated.
One of the main items was the ScrollManager component. react-router v4 does not scroll the page when loading new components, and basically they decided to punt because browsers are starting to do the right thing: https://github.com/ReactTraining/react-router/issues/3950
Unfortunately not all browsers are doing the right thing now, so I found examples from other people. It needed a little bit of modification because scratchjr views use a 'basename' and that wasn't handled.
All of this was only needed because the new HTML resources tend to be quite long, and to have #hash locations.
Testing:

[ ] Links on teach/curricula page go to HTML pages not PDF files
[ ] When printed the curricula pages only show the content (none of the site navigation), and include page breaks so that lessons start on a new page.
[ ] Assessment/solveit/answersheet is not PDF, and prints without the site navigation

On OSX 10.12, Chrome 60:

[x] Links on teach/curricula page go to HTML pages not PDF files

Everything looks good except for "printable block images", but I assume that's intentional

[x] When printed the curricula pages only show the content (none of the site navigation), and include page breaks so that lessons start on a new page.

Animated genres is in a different structure, but everything looks good printed

[x] Assessment/solveit/answersheet is not PDF, and prints without the site navigation

@mewtaylor yes, Tufts hasn't done an HTML version of the blocks yet, so they're still PDF. Just the curricula were converted to HTML.


Resolve syncing conflicts from repo_sync_working_branch to master

Pull request opened by Docs to resolve syncing conflicts from repo_sync_working_branch to master.

Resolved the merge conflicts; merging the PR.


perf(memory): use thread-local sequence-based memory eviction policy

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Motivation
Resolves #15305
The previous memory eviction strategy was based on epoch, and in the following scenarios, there may be cases of excessively aggressive eviction:

Uneven data volume between epochs caused by sudden increase or decrease in traffic.
Large data volume in recent epochs due to frequent access to certain data.
Large epoch interval.

This PR introduces a sequence-based memory eviction mechanism. The eviction of the cache is no longer based on epochs but on the sequence of cache access allocation with finer granularity.
Because the sequence needs to be globally shared, although only one atomic variable is needed for the sequence, the overhead of cache invalidation caused by frequent fetch_add cannot be ignored. Therefore, this PR introduces a thread_local sequence that allows global reordering within a certain range.
When insert/access an entry into/from the managed lru cache, the managed lru cache acquires a sequence from the Sequencer. The Sequencer use a thread-local variable to grant the sequence. the thread-local variable is synchronized with the global sequence if (a) the pre-allocated local sequences (step) are exhausted, or (b) the local sequence lag is higher than the threshold (lag). When evicting, the memory controller calculate the memory ratio to evict and normalize it as watermark sequence with the global sequence. The out-of-order threshold is max(lag, step).
CN node memory (before vs after):

Changes

Remove forked lru dependency. Use customized implemention in risingwave_common::lru.
Add thread-local sequencer implementation in risingwave_common::sequencer.
Add factor configuration for each eviction policy to control the eviction speed.

Configurations
    #[serde(default = "default::developer::memory_controller_eviction_factor_aggressive")]
    pub memory_controller_eviction_factor_aggressive: f64,

    #[serde(default = "default::developer::memory_controller_eviction_factor_graceful")]
    pub memory_controller_eviction_factor_graceful: f64,

    #[serde(default = "default::developer::memory_controller_eviction_factor_stable")]
    pub memory_controller_eviction_factor_stable: f64,

    #[serde(default = "default::developer::memory_controller_sequence_tls_step")]
    pub memory_controller_sequence_tls_step: u64,

    #[serde(default = "default::developer::memory_controller_sequence_tls_lag")]
    pub memory_controller_sequence_tls_lag: u64,

        pub fn memory_controller_threshold_aggressive() -> f64 {
            0.9
        }

        pub fn memory_controller_threshold_graceful() -> f64 {
            0.8
        }

        pub fn memory_controller_threshold_stable() -> f64 {
            0.7
        }

        pub fn memory_controller_eviction_factor_aggressive() -> f64 {
            2.0
        }

        pub fn memory_controller_eviction_factor_graceful() -> f64 {
            1.5
        }

        pub fn memory_controller_eviction_factor_stable() -> f64 {
            1.0
        }

        pub fn memory_controller_sequence_tls_step() -> u64 {
            128
        }

        pub fn memory_controller_sequence_tls_lag() -> u64 {
            32
        }

Micro Benchmarks for Components
Sequencer microbench:
primitive            1 threads 10000000 loops: 0ns per iter
atomic               1 threads 10000000 loops: 1ns per iter
atomic skip 8        1 threads 10000000 loops: 1ns per iter
atomic skip 16       1 threads 10000000 loops: 1ns per iter
atomic skip 32       1 threads 10000000 loops: 1ns per iter
atomic skip 64       1 threads 10000000 loops: 1ns per iter
sequencer(64,8)      1 threads 10000000 loops: 2ns per iter
sequencer(64,16)     1 threads 10000000 loops: 1ns per iter
sequencer(64,32)     1 threads 10000000 loops: 1ns per iter
sequencer(128,8)     1 threads 10000000 loops: 1ns per iter
sequencer(128,16)    1 threads 10000000 loops: 1ns per iter
sequencer(128,32)    1 threads 10000000 loops: 1ns per iter
coarse               1 threads 10000000 loops: 3ns per iter

primitive            4 threads 10000000 loops: 0ns per iter
atomic               4 threads 10000000 loops: 20ns per iter
atomic skip 8        4 threads 10000000 loops: 5ns per iter
atomic skip 16       4 threads 10000000 loops: 5ns per iter
atomic skip 32       4 threads 10000000 loops: 4ns per iter
atomic skip 64       4 threads 10000000 loops: 4ns per iter
sequencer(64,8)      4 threads 10000000 loops: 4ns per iter
sequencer(64,16)     4 threads 10000000 loops: 5ns per iter
sequencer(64,32)     4 threads 10000000 loops: 5ns per iter
sequencer(128,8)     4 threads 10000000 loops: 3ns per iter
sequencer(128,16)    4 threads 10000000 loops: 3ns per iter
sequencer(128,32)    4 threads 10000000 loops: 3ns per iter
coarse               4 threads 10000000 loops: 10ns per iter

primitive            8 threads 10000000 loops: 0ns per iter
atomic               8 threads 10000000 loops: 43ns per iter
atomic skip 8        8 threads 10000000 loops: 18ns per iter
atomic skip 16       8 threads 10000000 loops: 12ns per iter
atomic skip 32       8 threads 10000000 loops: 9ns per iter
atomic skip 64       8 threads 10000000 loops: 6ns per iter
sequencer(64,8)      8 threads 10000000 loops: 8ns per iter
sequencer(64,16)     8 threads 10000000 loops: 7ns per iter
sequencer(64,32)     8 threads 10000000 loops: 7ns per iter
sequencer(128,8)     8 threads 10000000 loops: 5ns per iter
sequencer(128,16)    8 threads 10000000 loops: 4ns per iter
sequencer(128,32)    8 threads 10000000 loops: 5ns per iter
coarse               8 threads 10000000 loops: 16ns per iter

primitive            16 threads 10000000 loops: 0ns per iter
atomic               16 threads 10000000 loops: 125ns per iter
atomic skip 8        16 threads 10000000 loops: 35ns per iter
atomic skip 16       16 threads 10000000 loops: 24ns per iter
atomic skip 32       16 threads 10000000 loops: 18ns per iter
atomic skip 64       16 threads 10000000 loops: 12ns per iter
sequencer(64,8)      16 threads 10000000 loops: 23ns per iter
sequencer(64,16)     16 threads 10000000 loops: 15ns per iter
sequencer(64,32)     16 threads 10000000 loops: 15ns per iter
sequencer(128,8)     16 threads 10000000 loops: 16ns per iter
sequencer(128,16)    16 threads 10000000 loops: 10ns per iter
sequencer(128,32)    16 threads 10000000 loops: 9ns per iter
coarse               16 threads 10000000 loops: 41ns per iter

primitive            32 threads 10000000 loops: 0ns per iter
atomic               32 threads 10000000 loops: 384ns per iter
atomic skip 8        32 threads 10000000 loops: 72ns per iter
atomic skip 16       32 threads 10000000 loops: 51ns per iter
atomic skip 32       32 threads 10000000 loops: 34ns per iter
atomic skip 64       32 threads 10000000 loops: 21ns per iter
sequencer(64,8)      32 threads 10000000 loops: 138ns per iter
sequencer(64,16)     32 threads 10000000 loops: 64ns per iter
sequencer(64,32)     32 threads 10000000 loops: 28ns per iter
sequencer(128,8)     32 threads 10000000 loops: 137ns per iter
sequencer(128,16)    32 threads 10000000 loops: 63ns per iter
sequencer(128,32)    32 threads 10000000 loops: 16ns per iter
coarse               32 threads 10000000 loops: 184ns per iter

lru microbench:
lru - 1024           1 threads 1000000 loops: 35ns per iter, total evicted: 999424
rw  - 1024           1 threads 1000000 loops: 26ns per iter, total evicted: 999424

lru - 1024           4 threads 1000000 loops: 35ns per iter, total evicted: 3997696
rw  - 1024           4 threads 1000000 loops: 27ns per iter, total evicted: 3997696

lru - 1024           8 threads 1000000 loops: 44ns per iter, total evicted: 7995392
rw  - 1024           8 threads 1000000 loops: 34ns per iter, total evicted: 7995392

lru - 1024           16 threads 1000000 loops: 46ns per iter, total evicted: 15990784
rw  - 1024           16 threads 1000000 loops: 51ns per iter, total evicted: 15990784

lru - 1024           32 threads 1000000 loops: 56ns per iter, total evicted: 31981568
rw  - 1024           32 threads 1000000 loops: 81ns per iter, total evicted: 31981568

lru - 1024           64 threads 1000000 loops: 90ns per iter, total evicted: 63963136
rw  - 1024           64 threads 1000000 loops: 149ns per iter, total evicted: 63963136

Benchmark
benchmark (nexmark, vs nightly-20240511):
http://metabase.risingwave-cloud.xyz/question/2219-nexmark-rw-compare?risingwave_tag_1=nightly-20240512&rw_label_1=daily&risingwave_metrics=avg-source-output-rows-per-second&risingwave_tag_2=git-8bc7ee189094e72c65db0725f05263ca3ec08be3&rw_label_2=benchmark-xx-tls
benchmark (nexmark, vs main without this PR):
http://metabase.risingwave-cloud.xyz/question/2219-nexmark-rw-compare?risingwave_tag_1=git-91b7ee29ce4d846f9c2ee6d9f56264bab414250a&rw_label_1=benchmark-xx-main&risingwave_metrics=avg-source-output-rows-per-second&risingwave_tag_2=git-8bc7ee189094e72c65db0725f05263ca3ec08be3&rw_label_2=benchmark-xx-tls

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Hi, would you mind sharing more information on the motivation and methodology in the PR description?

Is it necessary to also run the 4X (32C 64G) nexmark once? https://buildkite.com/risingwave-test/nexmark-benchmark/builds/3664#018f689a-0b1d-4fc3-9b82-912358895ccc
Considering that 32 threads case seem to incur more overhead

Is it necessary to also run the 4X (32C 64G) nexmark once? buildkite.com/risingwave-test/nexmark-benchmark/builds/3664#018f689a-0b1d-4fc3-9b82-912358895ccc Considering that 32 threads case seem to incur more overhead

Wha's the hardware configuration of the longevity test? I've ran longevity test and there is no regression.

https://github.com/risingwavelabs/risingwave/pull/16087#discussion_r1615588123
Discussed offline. Separating the unsafe blocks barely helps reduce the explosion radius. Let's keep it as it is now.


Fix DI generation for array exprs

Numba's DI generation for array expressions leads to strange behaviour in gdb. Issues include:

Stepping into an array expression lands here: https://github.com/numba/numba/blob/14b170a11c9b3e546b24943ffc446e152093080d/numba/np/npyimpl.py#L190-L205
If https://github.com/numba/numba/blob/14b170a11c9b3e546b24943ffc446e152093080d/numba/np/npyimpl.py#L190 is stepped through until finish and then stepped over the next executable line is reported as line 1 of the file containing the array expr.
Once on line 1, continued stepping repeatedly reports the same location with varying input values, though it will eventually step back into the calling function.

As noted here: https://github.com/numba/numba/pull/7752#issuecomment-1018394185 the fix may be to just omit DI for array expressions.

xref: https://github.com/numba/numba/issues/7787 which demonstrates the problem.


System.NotSupportedException: BinaryFormatter serialization and deserialization are disabled within this application.

Summary of the issue
System.NotSupportedException: BinaryFormatter serialization and deserialization are disabled within this application. See https://aka.ms/binaryformatter for more information.
BinaryFormatter is obsolete in AspNet Core in .net5.0
Workaround:

net6.0
true

Environment
.NET (Core) SDK version:  5.0 / 6.0

This library is not using BinaryFormatter anymore. Just use the last version of it.

i'm using nuget package 3.3.0 with EasyCaching.Redis 1.5.0
All latest versions.

Follow this topic


Add french Translation

merci beaucoup! I'll review and merge these in.

I can do that, do you need me to fork it ?

if it's just that one that needs changed, let me know what the translation is. I'll change it.

It's more that we don't have the perfect equivalent for the english preterit, to make a correct sentence to show in the statement one would need to use passé composé , but I don't know if a two word string would comply to the API ?
If yes I'll send you the corrected version , if not there are still mistakes in the current file that i'll be glad to correct

It's a display value so it can be whatever makes sense. So the verb used in an english statement would be something like tom mastered french 1. To put it another way, if << passé composê >> is the correct equivalent, we'll use that.
And feel free to review the other translations and make suggestions. I defer to those who know french to determine if those translations are right.
Thanks for your help.

Not sure that was the easiest way for you, but here are the translations:
   "answered" : "a répondu",

   "asked"  : "a demandé",

   "attempted"  : "a essayé",

   "attended" : "a suivi",

   "commented" : "a commenté",

   "completed" : "a terminé",

   "exited" : "a quitté",

   "experienced" : "a éprouvé",

   "failed" :  : "a échoué",

   "imported" : "a importé",

   "initialized" : "a initialisé",

   "interacted"  : "a interagi",

   "launched" : "a lancé",

   "mastered" : "a maîtrisé",

   "passed"  : "a réussi",

   "preferred" :  "a préféré",

   "progressed" : "a progressé",

   "registered" : "a enregistré",

   "responded" : "a répondu",

   "resumed" : "a repris",

   "scored" : "a marqué",

   "shared" : "a partagé",

   "suspended" :  "a suspendu",

   "terminated" :  "a terminé",

   "voided" : "a annulé",

so "tom mastered French 1" is "tom a maîtrisé Français" ?

Yes that would be the best translation I can think of, it's complicated to find perfect equivalent from english to french. Of course there is a need for an article before the activities display values.
e.g. Tom a maîtrisé le Français 1

OK. I'll update these and make a new pull request. As for "le Français 1" that would be handled in the activity definition name field (see https://github.com/adlnet/xAPI-Spec/blob/master/xAPI.md#activity-definition)

made edits based on the comments in this thread. new pr https://github.com/adlnet/xAPIVerbs/pull/5


Add ramrod2615's file

created a branch, created a file and made a commit, and opened a pull request

Reopen pull request


openRA: Crash on start

Note: I'm not sure whether the following is an upstream bug or related to packaging.
Issue description
OpenRA crashes on startup
Steps to reproduce
nix-shell -p openra --run openra
yields:
Platform is Linux
Using SDL 2 with OpenGL renderer
Desktop resolution: 1366x768
No custom resolution provided, using desktop resolution
Using resolution: 1366x768
OpenGL version: 3.0 Mesa 11.1.3
Using OpenAL sound engine
Using default device
ALSA lib pcm_dmix.c:1029:(snd_pcm_dmix_open) unable to open slave
AL lib: (EE) ALCplaybackAlsa_open: Could not open playback device 'default': Device or resource busy
Failed to open device. Falling back to default
ALSA lib pcm_dmix.c:1029:(snd_pcm_dmix_open) unable to open slave
AL lib: (EE) ALCplaybackAlsa_open: Could not open playback device 'default': Device or resource busy
Exception of type `System.InvalidOperationException`: Can't create OpenAL device
  at OpenRA.Platforms.Default.OpenAlSoundEngine..ctor () [0x00000] in <filename unknown>:0
  at OpenRA.Platforms.Default.DeviceFactory.CreateSound () [0x00000] in <filename unknown>:0
  at OpenRA.Sound.CreateDevice (System.Reflection.Assembly platformDll) [0x00000] in <filename unknown>:0
  at OpenRA.Sound..ctor (System.String engineName) [0x00000] in <filename unknown>:0
  at OpenRA.Game.Initialize (OpenRA.Arguments args) [0x00000] in <filename unknown>:0
  at OpenRA.Program.Run (System.String[] args) [0x00000] in <filename unknown>:0
  at OpenRA.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0
which: no zenity in (/nix/store/85294yj3rh72l8yzdkghlxbi8j9yr27i-mono-<IP_ADDRESS>/bin:/nix/store/xivdcbxihwx4rgyk09bmsf5r9k4sfyn6-openra-20160508/bin:/nix/store/yvjv42h6aq4a4nbq5bv68zsb5kpps9gw-patchelf-0.9/bin:/nix/store/gc98i9avk6kq6y97a32cwq87i8dl5pkv-paxctl-0.9/bin:/nix/store/ix03iknfgyrx7421fppjdczd9r4sw7pz-gcc-wrapper-5.3.0/bin:/nix/store/l8y2srrkp5fflwph7vq0gllj1k1ai17w-gcc-5.3.0/bin:/nix/store/s0kpgl8a101lkymj599f5a04s4wflf5s-binutils-2.26-dev/bin:/nix/store/h8kggr0qh8rx620vjj5h1j9fj1zivq33-glibc-2.23-bin/bin:/nix/store/7b38vz4w4rjwwww3k53h4s4ysf1ff4gx-coreutils-8.25/bin:/nix/store/7b38vz4w4rjwwww3k53h4s4ysf1ff4gx-coreutils-8.25/bin:/nix/store/q6svr9m8jyxn698a7vxwcpxijyg1p0xs-findutils-4.6.0/bin:/nix/store/2vxwyq0pa7lncn01h3f97s2cq6qh11kx-diffutils-3.3/bin:/nix/store/9jj37ws95k26k8cba52a7lfz8p2f4d3l-gnused-4.2.2/bin:/nix/store/sb5x3l645wrmsvxr8k6rsdg0zwg0p8il-gnugrep-2.22/bin:/nix/store/i5b6s8jgfgf74wffr5z7aa2qmkqcqpdy-gawk-4.1.3/bin:/nix/store/acikdr9h8d0jmrjxfyyh6mnh8dznqv8a-gnutar-1.28/bin:/nix/store/8fngdkhqixp4vjypa74vc5h88chyz0ml-gzip-1.7/bin:/nix/store/02sbljn6a2w27vxg6qhkijycj4qb9lzl-bzip2-1.0.6-bin/bin:/nix/store/zm4d5sc6n9q7x47s14s8bs9l92y7krgh-gnumake-4.1/bin:/nix/store/d20f169ryps7ds2qak0r5n1f4hhxr80h-bash-4.3-p42/bin:/nix/store/azljmspp22hq683p7bva9qkqxhpj0d6p-patch-2.7.5/bin:/nix/store/337fr8vx3jjl78rdbxbdx1q45ix4nngs-xz-5.2.2-bin/bin:/home/m/bin:/var/setuid-wrappers:/home/m/.nix-profile/bin:/home/m/.nix-profile/sbin:/home/m/.nix-profile/lib/kde4/libexec:/nix/var/nix/profiles/default/bin:/nix/var/nix/profiles/default/sbin:/nix/var/nix/profiles/default/lib/kde4/libexec:/run/current-system/sw/bin:/run/current-system/sw/sbin:/run/current-system/sw/lib/kde4/libexec:/home/m/archive/bin:/home/m/archive/bin)
OpenRA needs zenity installed to display a graphical error dialog. See ~/.openra. for log files.
/nix/store/xivdcbxihwx4rgyk09bmsf5r9k4sfyn6-openra-20160508/lib/openra/.launch-game.sh-wrapped: line 7: --question: command not found

and
cat ~/.openra/Logs/exception.log
Operating System: Linux (Unix <IP_ADDRESS>)
Runtime Version: Mono 4.0.4 (Stable <IP_ADDRESS>/5ab4c0d Tue May 10 21:24:44 UTC 2016) CLR 4.0.30319.17020
Exception of type `System.InvalidOperationException`: Can't create OpenAL device
  at OpenRA.Platforms.Default.OpenAlSoundEngine..ctor () [0x00000] in <filename unknown>:0
  at OpenRA.Platforms.Default.DeviceFactory.CreateSound () [0x00000] in <filename unknown>:0
  at OpenRA.Sound.CreateDevice (System.Reflection.Assembly platformDll) [0x00000] in <filename unknown>:0
  at OpenRA.Sound..ctor (System.String engineName) [0x00000] in <filename unknown>:0
  at OpenRA.Game.Initialize (OpenRA.Arguments args) [0x00000] in <filename unknown>:0
  at OpenRA.Program.Run (System.String[] args) [0x00000] in <filename unknown>:0
  at OpenRA.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0

Technical details

System: 16.09pre83100.25e3c09 (Flounder)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: "16.09pre83100.25e3c09"

can't reproduce. are you using pulseaudio or just alsa?

Just alsa.

ALSA lib pcm_dmix.c:1029:(snd_pcm_dmix_open) unable to open slave
AL lib: (EE) ALCplaybackAlsa_open: Could not open playback device 'default': Device or resource busy

Looks like something blocks your ALSA device. I don't remember those things well (I use PulseAudio today) but maybe software mixer doesn't kick in?

https://github.com/OpenRA/OpenRA/issues/2544 and https://github.com/OpenRA/OpenRA/issues/3473 seem relevant. Are you using headphones or speakers? if so try disconnecting or connecting them and see what works.

I use the builtin speakers of my device.

Could you try installing and running another application that uses OpenAL and check if the sound works so we can find out if the problem is with OpenAL or openra? For example minetest. I get this by starting a game and breaking some block :
$ minetest --verbose > log
$ grep -i -e openal -e audio log

2016-05-15 11:25:57: INFO[main]: Audio: Initializing...
2016-05-15 11:25:57: INFO[main]: Audio: Vorbis extension NOT present
2016-05-15 11:25:57: INFO[main]: Audio: Initialized: OpenAL 1.1 ALSOFT 1.17.2, using OpenAL Soft
2016-05-15 11:25:57: VERBOSE[main]: OpenALSoundManager::maintain(): 0 playing sounds, 0 sound names loaded
[...]
2016-05-15 11:25:57: INFO[main]: OpenALSoundManager: "main_menu" not found.
2016-05-15 11:25:58: INFO[main]: Audio: Deinitializing...
2016-05-15 11:25:58: INFO[main]: Audio: Deinitialized.
2016-05-15 11:25:58: INFO[main]: Attempting to use OpenAL audio
2016-05-15 11:25:58: INFO[main]: Audio: Initializing...
2016-05-15 11:25:58: INFO[main]: Audio: Vorbis extension NOT present
2016-05-15 11:25:58: INFO[main]: Audio: Initialized: OpenAL 1.1 ALSOFT 1.17.2, using OpenAL Soft
2016-05-15 11:25:59: VERBOSE[main]: OpenALSoundManager::loadSoundData(): Writing temporary file to [/home/user//.minetest/cache/tmp/tmp.ogg]
2016-05-15 11:25:59: INFO[main]: Audio file /home/user//.minetest/cache/tmp/tmp.ogg loaded
[...]
2016-05-15 11:26:00: VERBOSE[main]: OpenALSoundManager::maintain(): 0 playing sounds, 25 sound names loaded
2016-05-15 11:26:00: INFO[main]: OpenALSoundManager: Creating playing sound
2016-05-15 11:26:01: VERBOSE[main]: OpenALSoundManager::maintain(): 1 playing sounds, 25 sound names loaded
2016-05-15 11:26:01: INFO[main]: OpenALSoundManager: Creating playing sound
2016-05-15 11:26:01: VERBOSE[main]: OpenALSoundManager::maintain(): 2 playing sounds, 25 sound names loaded
2016-05-15 11:26:01: VERBOSE[main]: OpenALSoundManager::maintain(): deleting 1 playing sounds
2016-05-15 11:26:01: INFO[main]: OpenALSoundManager: Creating playing sound
2016-05-15 11:26:01: VERBOSE[main]: OpenALSoundManager::maintain(): 2 playing sounds, 25 sound names loaded
2016-05-15 11:26:01: VERBOSE[main]: OpenALSoundManager::maintain(): deleting 1 playing sounds
2016-05-15 11:26:01: INFO[main]: OpenALSoundManager: Creating playing sound
2016-05-15 11:26:01: VERBOSE[main]: OpenALSoundManager::maintain(): 2 playing sounds, 25 sound names loaded
2016-05-15 11:26:01: INFO[main]: OpenALSoundManager: Creating playing sound
2016-05-15 11:26:02: INFO[main]: Audio: Deinitializing...
2016-05-15 11:26:02: INFO[main]: Audio: Deinitialized.

With the code snippet you pasted my log file is empty. With minetest --verbose 2>&1 > log it is empty as well :curly_loop:
Minetest works as intended for me.

Oops, should be redirect stderr and not stdout, yep. But why is it empty after fixing that? try just running it without redirecting and see if you get something on the console.

Try > log 2>&1 (notice different order)

grep -i -e openal -e audio log
2016-05-15 17:07:50: INFO[main]: Audio: Initializing...
2016-05-15 17:07:50: INFO[main]: Audio: No audio device available, audio system not initialized
2016-05-15 17:07:50: INFO[main]: Audio: Deinitializing...
2016-05-15 17:07:50: INFO[main]: Audio: Deinitialized.
2016-05-15 17:07:53: INFO[main]: Attempting to use OpenAL audio
2016-05-15 17:07:53: INFO[main]: Audio: Initializing...
2016-05-15 17:07:53: INFO[main]: Audio: No audio device available, audio system not initialized
2016-05-15 17:07:53: INFO[main]: Audio: Deinitializing...
2016-05-15 17:07:53: INFO[main]: Audio: Deinitialized.
2016-05-15 17:07:53: INFO[main]: Failed to initialize OpenAL audio
2016-05-15 17:07:53: INFO[main]: Using dummy audio.

And you get sound when walking around and breaking blocks?

Yes.

I assume minetest is using some other sound method, but openAL is not working. That means the problem is with openAL. @ftrvxmtrx, any suggestion?

Closing because too old to get addressed IMO.

Works for me on master.


⚠ SceneTime has degraded performance

In 9e1a065, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 3983 ms

Resolved: SceneTime performance has improved in 0c98fc8 after 6 minutes.


Workspace picture not update in LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to Settings > Workspaces
create new workspace
close the modal
click on workspace chat in LHN
go to Settings > Workspaces
change the workspace picture
check the workspace picture in LHN

##cExpected Result:
should show updated workspace picture
Actual Result:
does not show updated workspace picture
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/235469162-9460ccc2-8da5-4b9b-8f61-80ad57a41ef7.mov
https://user-images.githubusercontent.com/43996225/235469222-60456418-5868-45e9-a2da-2a1122f5d53a.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682923095097649
View all open jobs on GitHub

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace picture is not updating in the LHN list
What is the root cause of that problem?
Seems for the policy selector in the SidebarLinks we are only considering the name and type but we are missing the avatar.
https://github.com/Expensify/App/blob/8e06eb06404589563988a2d259394d9725d8f65f/src/pages/home/sidebar/SidebarLinks.js#L281-L284
What changes do you think we should make in order to solve the problem?
Add avatar entry avatar: policy.avatar in the policy selector which will reflect the change in it in the LHN.

Result
https://user-images.githubusercontent.com/14358475/235493532-c03bdb77-c394-487a-9b1a-dd18d8100b9b.mp4

Job added to Upwork: https://www.upwork.com/jobs/~01d86d894fc0f2eac0

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to @bondydaa (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Looks like we already have one proposal for review @parasharrajat

I don't know much about how this compose functionality works https://github.com/Expensify/App/blob/8e06eb06404589563988a2d259394d9725d8f65f/src/pages/home/sidebar/SidebarLinks.js#L286 but @Pujan92's proposal seems good but I do have a couple questions:

Will this work offline? It doesn't seem like it since the image in the LHN is seen partially while we wait for it to be downloaded.
is if there is a way we could delay the render until the file has fully downloaded? (this would only be for members of the workspace since as long as we can get this to work offline it should be immediate for the user making the change)

Will this work offline? It doesn't seem like it since the image in the LHN is seen partially while we wait for it to be downloaded.

For the offline we are not showing the images instead we do show the avatars.

is if there is a way we could delay the render until the file has fully downloaded? (this would only be for members of the workspace since as long as we can get this to work offline it should be immediate for the user making the change)

I think we can use the loading state to show the loader but not sure about any possibility of renders only when it gets fully downloaded.

📣 @Pujan92 You have been assigned to this job by @bondydaa!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

okay sweet, thanks @parasharrajat ! assigning @Pujan92 then, don't worry about adding any of the loading stuff I'd previously mentioned for now but please include videos of both online/offline UX in your PR.

@parasharrajat @bondydaa PR is ready for review.

PR was merged last week, I think we're just waiting for deployment?

@gadhiyamanan @Pujan92 @parasharrajat - Could you apply for the job in Upwork if you haven't yet? https://www.upwork.com/jobs/~01d86d894fc0f2eac0

@lschurr applied!

Offers sent to @gadhiyamanan and @Pujan92 - @parasharrajat could you apply? https://www.upwork.com/jobs/~01d86d894fc0f2eac0

Also @parasharrajat - do we need a regression test for this one?

@lschurr accepted, thanks!

Great, @parasharrajat can you apply for the job? https://www.upwork.com/jobs/~01d86d894fc0f2eac0

This one is paid and done!


Poor wording

under the "Stop the Synchronization Service" heading, it says "First you can stop the service in the Windows Service Control Manager. Make sure that the service is not running when attempting to stop it. If it is, wait until it completes and then stop it.".
This wording is confusing - "make sure that the service is not running when attempting to stop it" and should be revised.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a6ac21b-3096-44b3-8099-f029a2bcf718
Version Independent ID: 30085cd3-7d19-e88b-d4c6-14e9524ec046
Content: Azure AD Connect sync:  Changing the ADSync service account
Content Source: articles/active-directory/hybrid/how-to-connect-sync-change-serviceacct-pass.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@davidsandbrand
Thanks for your feedback! We will investigate and update as appropriate.

Thanks @davidsandbrand !
I made a pull request to change the wording to, "Make sure that the service is not running before you attempt to stop it.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/110045
Hope that helps! If you think it needs to be revised further you can feel free to make a pull request to the article.

I think you missed the point:  If the goal is to stop the service, why must one make sure that the service is already stopped before attempting to stop it?
I suspect it was supposed to say something like "make sure the service is not starting or already stopping", otherwise, this literally does not make sense (even with your edit).


Fix builtin vs custom validation behavior for form controls

Maybe when there is a custom error shown the form field should be automatically set to invalid?


Bug 1951869: Fix nil ptr dereference when srcMigCluster is invalid

In the course of testing https://bugzilla.redhat.com/show_bug.cgi?id=1951869 QE bumped into a nil pointer dereference coming from https://github.com/konveyor/mig-controller/blame/master/pkg/controller/migplan/validation.go#L299 which was merged about the same time my PR was.
This will allow the plan to go to Not Ready instead of crashing.

Should we also do it for the destination cluster?

Seems reasonable. I've updated the PR.


AssertHTTP: WithRetry methods fail tests on first failed attempt

In #1707, I wrote a new set of HTTP assert helpers to facilitate testing web services as part of blueprint testing.
After some additional experimentation on the naive approach to the WithRetry methods, I've realized that even though we retry, the first failed HTTP request will fail the tests, because we call t.Error inside the retry loop.
Instead, we need to catch the last failure/error of the retry loop and use that to call t.Error.

I am working on an implementation where the last error returned from Poll is used as the error on which to assert in the Assert methods.
As part of this, I am also fixing:

Use of utils.GetLoggerFromT
Improved return from httpResponse on empty conditions
Expanded test coverage (catching some additional edge cases)
Configurable retries, because the current implementation would not have helped with what I needed to do on Monday.

At this point, I would have considered dropping the AssertXWithRetry methods, but since they are already there, I've kept them in this PR.


updated links to dev guide

Overview
This PR adds links to the dev-guide in the Readme to make the release with bumpversion more visible.
It fixes also the links in CONTRIBUTING.md
Related Issue / Discussion
See discussion in FlyingPigeon PR:
https://github.com/bird-house/flyingpigeon/pull/300
Additional Information
Taken xarray readme as example:
https://github.com/pydata/xarray/blob/master/README.rst

@tlvu thanks for review. The WPS birds will be updated by this template later.


UI: Submit the form when press enter

Description
Related #4762
This PR for fixes submit the form when pressing Enter

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (JID-3855)

Could this break anything? (for example in any input that is textarea of multi-line) cc @shwstppr @Pearl1594 @borisstoyanov @vladimirpetrov @andrijapanicsb

@rhtyd Yes, currently for textarea, selectbox focus the press enter will not submit the form

Industry practice, from what I've seen is to use CTRL + ENTER to submit a form (i.e. in gmail to send email, in Jira to send comment, in Outlook to send email, etc)
simple ENTER sounds a bit "dangerous"

and GitHub also uses CTRL + ENTER to send THIS COMMENT :)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-39)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-40)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-41)

@blueorangutan ui

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-60)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-76)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-77)

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-78)

@utchoang can you fix the conflict against latest 4.15 branch

@blueorangutan ui

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-82)

@utchoang can you fix the conflict? Thanks.

CLGTM. Will test and review

@utchoang can you fix the conflicts?

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-90)

This causes an issue when the item focused is a switch, and pressing control enter toggles the value as well as submits the form.
Try stopping a VM while forced is focused via ctrl-enter and the switch toggles and the VM is force stopped
Could be other issues, looking into it
So far works well with non switches / text / select as the focused element

@davidjumani I have checked to stop a VM even if focus or lost focus from the switch element, then pressing Ctrl + Enter still performs submit normally. Don't know how your problem is?

@utchoang

@davidjumani I think this problem belongs to the browser. Since I run on Chrome it works normally. Do not know which browser you use?

@utchoang Can you try it in firefox ?

@davidjumani Tested in firefox browser

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-91)

@utchoang can you fix the conflict
@davidjumani can you review?

@davidjumani can you review? cc @Pearl1594

@blueorangutan ui

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-102)

Moving to <IP_ADDRESS> as it's a new feature (agree a useful feature) but changes are codebase wide and can potentially add risks to the minor release.

ping @utchoang can you fix the conflicts? Thanks.

@blueorangutan build ui

@blueorangutan ui

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-278)

@utchoang can you please fix the conflicts?

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-383)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-384)

@utchoang Can you fix the conflicts ?

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-400)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-401)

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-413)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-414)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-423)

@davidjumani can you check it again? Thanks.

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-424)

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@utchoang Facing the issue mentioned in https://github.com/apache/cloudstack/pull/4766#issuecomment-815467043 again, perhaps something changed in https://github.com/apache/cloudstack/pull/4766/commits/a6c9086f98fd2f3f147204cacb689f146e54e0bd#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7 broke it ?

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-425)

@davidjumani

@utchoang Facing the issue mentioned in #4766 (comment) again, perhaps something changed in a6c9086#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7 broke it ?

sorry I forgot this on Firefox, I'll fix it now

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-426)

@utchoang I'm getting these errors at times (now while trying to add a firewall rule) by pressing control-enter. Can you please check


Nginx proxy manager, limit access to local network via access list

Are you in the right place?

If you are looking for support on how to get your upstream server forwarding, please consider asking the community on Reddit.
If you are writing code changes to contribute and need to ask about the internals of the software, Gitter is the best place to ask.
If you think you found a bug with NPM (not Nginx, or your upstream server or MySql) then you are in the right place.

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
yes
Are you sure you're not using someone else's docker image?
im using the right image

Describe the bug

A clear and concise description of what the bug is.
Recently I have been trying to limit the access of a self-hosted web service for "Streaming" to local network ONLY, with the aid of the nginx proxy manager.

My setup looks like the following:

Raspberry Pi 4 running Raspbian Os 64x running on a static IP (<IP_ADDRESS>).

docker & docker-compose & portainer are each properly installed.

raspberry running the following docker images with no ports conflicts: Nextcloud, ddclient, jc21/nginx-proxy-manager, pihole and finally this web service.

on the router (night hawk R7500), I set the IP address of the PiHole (in this case the Raspberry Pi) as DNS.

the Streaming website is a subdomain "movies.example.com". Where the domain "example.com" and the subdomain are enforced with self-signed SSL from the Nginx Proxy manger.

All the mentioned services are dockerized and nothing is installed on "bare metal"
The Nginx Proxy manager is installed with this tutorial.
The following (Screenshot 2) shows the view of the Nginx proxy manager access list IP Address Whitelist/Blacklist.

Screenshot 3 shows both the view of the SSL settings (3.3) and the view of the details section of the chosen host assigned with Authorization for Streaming.

What version of Nginx Proxy Manager is reported on the login page?
v2.9.2
What is shown upon calling the desired website from both the local and the external network: "403 Forbidden, openresty".

I ended up whitelisting the public IP address of my router, and somehow it covered all the devices within my network.

Experiencing the same issue in the access list.
It seems, only external IP addresses are accepted in the access list - which is cumbersome with a dynamically assigned IP.

Hopefully this will be implemented soon, with a fixed IP that doesn't really help.

@chaptergy Thanks for the summary. As I understand, by switching to host networking on my proxy manager container, I should be able to allowlist both the public IP of my network, and the private subnet(s) of my network. I have done both steps, and continue to see the same behavior. From /data/logs/proxy-host-8-access.log
[02/Jun/2022:17:56:25 +0000] - - 403 - GET https ombi.alvani.me "/i/" [Client <IP_ADDRESS>] [Length 111] [Gzip 1.35] [Sent-to <IP_ADDRESS>] "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.5 Safari/605.1.15" "-"
Allowlisting <IP_ADDRESS> still results in a 403.

Am I missing something?
I have NPM deployed in my local subnet. When I create an access list with
allow: <IP_ADDRESS>/24
deny: all
and attach it to a proxy host, I get a 403 from everywhere, including any machine on the local subnet.

I can confirm this doesn't work. The compose snippet of chaptergy results in an error for me. If i try to whitelist my local ip subnet i get 403 on every page that uses the auth.

Adding to the Custom Nginx Configuration should work. I did this, but to whitelist DDNS addresses as well as LAN access. For example you could:
Hosts > Edit > Advanced and in Custom Nginx Configuration:
location = / {
	allow <IP_ADDRESS>/24;
	allow <IP_ADDRESS>/24;
	deny all;
}

I'm also having the same issue. I've tried even adding the Custom Nginx Config as stated by @threehappypenguins but it still doesn't work to limit local access.

~I'm also having the same issue. I've tried even adding the Custom Nginx Config as stated by @threehappypenguins but it still doesn't work to limit local access.~
I figured it out. It does work with local access only. What I needed change is to allow the local docker IP range.
By using "allow <IP_ADDRESS>/16" in the access list, I could limit access to my containers only if connected through my docker wireguard VPN.
Adding "allow <IP_ADDRESS>/24" enables local network access. Adding "allow PUBLIC_IP" where PUBLIC_IP is your public IP address allows you to connect to a remote server without having to use the VPN.

Seems to work for me !

By using "allow <IP_ADDRESS>/16" in the access list, I could limit access to my containers only if connected through my docker wireguard VPN.

You are connecting via docker WireGuard in the same docker network, right? Because I have WireGuard built-in, and it uses different network, so still needed the public IP address.

Correct. I'm using wg-easy for my Wireguard setup to manage my users/credentials. wg-easy is using the same docker network as the rest of my containers including NginxProxyManager.

Well i have NginxProxyManager on a other VirtualMachine than wireguard because i cant use Adguard + NginxProxyManager on one Machine. But the NginxProxyManger and Wireguard are both on the <IP_ADDRESS> network..

location = / {
allow <IP_ADDRESS>/24;
allow <IP_ADDRESS>/24;
deny all;
}

the only problem is:

~I'm also having the same issue. I've tried even adding the Custom Nginx Config as stated by @threehappypenguins but it still doesn't work to limit local access.~
I figured it out. It does work with local access only. What I needed change is to allow the local docker IP range.
By using "allow <IP_ADDRESS>/16" in the access list, I could limit access to my containers only if connected through my docker wireguard VPN.
Adding "allow <IP_ADDRESS>/24" enables local network access. Adding "allow PUBLIC_IP" where PUBLIC_IP is your public IP address allows you to connect to a remote server without having to use the VPN.

the only problem is:  PUBLIC_IP can be changed and then, you need to change the configuration, right?

I have a similar problem like @xKliment. I run npm in a different lxc on the same machine as wireguard. I have this access list:

My devices get a <IP_ADDRESS>/24 ip when connected through wireguard. But I am not able to access the site through npm, only from my non-vpn internal network...
Did you find a solution for this?

ive found using 1 instance NPM in the cloud, and 1 instance NPM in my lan, works best, and set my own dns recordsin router, public dns or hosts... helps with speed as in lan traffic doesnt got out my net interface and back in...if you use cloudflare for dns and dns with the api letsincrypt works even with lan IP's...

The machine I'm running NPM on sits on both my local network and the internet, basically acts as my home router. My workaround to this issue is to firewalld off everything coming through from my WAN interface except for things like port 80 and 443, and then run this docker container with network_mode: host.
The only issue I hit is it seems NPM internally uses port 3000 for its API, which another container of mine was using. Once I switched ports for that container, everything seems to be functioning correctly now.

Workaround OpenMediaVault docker:
BASE_HOST_IP=<IP_ADDRESS>
version: '3.8'
services:
app:
image: 'jc21/nginx-proxy-manager:latest'
restart: unless-stopped
network_mode: bridge
ports:
# These ports are in format :
  - '<IP_ADDRESS>:80:80' # Public HTTP Port
  - '<IP_ADDRESS>:443:443' # Public HTTPS Port
  - '81:81' # Admin Web Port

By binding the port to the host address, I get the correct address of my systems in the local network.
Conveniently, you can use the global environment (also for other docks):
Global Environment:
BASE_HOST_IP=<IP_ADDRESS>
Placeholder in Yaml:

'${BASE_HOST_IP}:80:80' # Public HTTP Port
'${BASE_HOST_IP}:443:443' # Public HTTPS Port

Adding to the Custom Nginx Configuration should work. I did this, but to whitelist DDNS addresses as well as LAN access. For example you could:
Hosts > Edit > Advanced and in Custom Nginx Configuration:
location = / {
	allow <IP_ADDRESS>/24;
	allow <IP_ADDRESS>/24;
	deny all;
}

This worked for me (i have a hairpin NAT). I didn't have to do the extra finangling. I removed the second line, and it allowed local access and prevented public access. I wouldn't recommend using public IP cuz that can change.

so I am using cloudflare end the origin IP is changing all the time
if I block internet, then the IP cannot be resolved - domain name is kept by local nginx instance so the calling service has to go to internet, to cloudflare, come then to my nginx to resolve the IP - blocked internet access means: cannot resolve
what I am saying: even local call to  my domain:  my.domain.com (domain.com is on cloudflare, "my" is only in LAN) requires internet to resolve the my.domain.com

@homonto set up a local DNS (i.e. pi.hole is convenient) with your local server IP. In my case my router is the DHCP but I propagate the additional DNS IP to all systems in my network.

I have Pihole, even 2: one on each VLAN: <IP_ADDRESS> and <IP_ADDRESS>
so maybe you can help me:
1- nginx is on <IP_ADDRESS>
2- domain speed.mydomain.com is on <IP_ADDRESS>
3- in nginx I set:

destination: https://<IP_ADDRESS>:8443
access: speed
then in access  list, speed has:
allow: <IP_ADDRESS>/24 (my laptop is on 192.168.100.x)
deny: all
4- on Pihole I set:
speed.domain.com -> <IP_ADDRESS>

But with these settings it is not working

ping resolves speed.domain.com as proper IP of the server: <IP_ADDRESS>
nginx log shows:
2023/11/08 07:32:06 [error] 1328750#1328750: *189640 access forbidden by rule, client: <IP_ADDRESS>, server: speed.domain.com, request: "GET /favicon.ico HTTP/2.0", host: "speed.domain.com", referrer: "https://speed.domain.com/"

Evidently the request comes from Cloudfare rather than from local DNS, but why?

@homonto a ping ain't be logged by ngnix. You see a call to favicon.ico - that's probably your browser.
You must ensure in your testing that your browser uses the DNS of your network. Search for DNS in the settings. Some use primarily external DNS for security reasons. Only when the external DNS has no match, do they check the internal ones, but because Cloudflare knows an external address for your domain that's not happening.
Or call the site by curl or wget.

all my clients have provided my 2 Piholes as DNS IPs.
and the domain assignment to the internal IP is on the Piholes:

Then both Piholes are referring to router (Opnsense):

And then Unbound DNS is providing the real DNS service. Do you think this can be the issue?

@homonto maybe you missed my previous comment - did you check your browser settings?

browser has no DNS settings and I checked on 3: Chrome, Firefox and Safari. And on mobile phone as well.
plus, my firewall redirects everything calling port 53 to unbound
I am 100% sure problem is on my side - just I am NOT sure how to approach it. ;-)


[new]: copy_table(table_src, table_dest)

Check the idea has not already been suggested

[X] I could not find my idea in existing issues

Edit the title above with self-explanatory function name and argument names

[X] The function name and the argument names I entered in the title above seems self explanatory to me.

BigFunction Description as it would appear in the documentation
It would be interesting to leverage a function that copies a source table to a destination table simulating the Bigquery copy command bq cp table_src table_dest
Examples of (arguments, expected output) as they would appear in the documentation
bigfunction.eu.copy_table('project-id.dataset_src.table_id_src', 'project-id.dataset_dest.table_id_dest')

Thanks @TRKBDO for the suggesting.
But maybe the native bigquery copy table function will suit your needs?
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#create_table_copy

Thanks @unytics for your quick reply and the proposed solution. But, as it is not mentioned in the documentation you provided,  do you think that the statement CREATE  TABLE  table_dest COPY table_src  is eumlating the same zero cost behaviour of the well known BigQuery copy command: bq cp table_src table_dest?

When I execute CREATE  TABLE  table_dest COPY table_src on my bigquery console, I see that there is NO bytes billed. Si I guess it is the same as bq cp table_src table_dest.
I close the issue.
Don't hesitate if you have any other suggestion.


Ability to mute users

Hey! I am new to open source. Can I work on this issue under your able guidance.

As mentioned in #4, pick one issue to work on at a time in the interest of fairness. Let me know if you'd like to work on this one first 😄


Pick an ORM library for EE's SQLite DB

wp-cli doesn't require a database of its own
We would benefit from using an ORM wrapper for EE's SQLite  DB

Team has done own DB wrapper https://github.com/EasyEngine/easyengine/blob/develop-v4/php/class-ee-db.php

@mrrobot47 how we will handle schema upgrades for DB?
Please refer following from #858

Migration - to manage database changes between upgrades. Laravel -  https://laravel.com/docs/5.4/migrations . Outside - https://phinx.org/ looks good.

@rahul286 I found two options.

Propel (http://propelorm.org/)
Propel have ORM+Migrations options.

illuminate/database (Laravel Orm: https://github.com/illuminate/database)
Laravel Orm is unable to provide migration functionality outside Laravel as it required Laravel framework instance for that. But we can use Phinx for migration with Laravel ORM. (Ref: https://siipo.la/blog/how-to-use-eloquent-orm-migrations-outside-laravel)

Since we currently do not have enough data to form an opinion, we'll tackle this issue in the next beta release.

We have tried few libs for ORM + Migrations and all of them needs some dependency of there framework. And we don't want to add some dendancy of any framework.
Like: phinx - Internally loads cakephp framework ( with core )
Laravel ORM - This also has laravel framework dependency for db connections ( which is obvious ),
Doctrine uses some symfony package and zendframework as dependency etc.
And our use in ee4 is not that much we just required SQLite support with few tables, so we are deciding to create our custom ORM + Migration and keep it simple and clear.
We will keep architecture of migration like laravel / phinx but the code will be custom so that we can easily make modifications.

@rahulsprajapati did you check http://propelorm.org/ ? http://propelorm.org/documentation/09-migrations.html ?
Avoid writing custom codes as ORM + Migration is not a focus area.

Re: Doctrine uses some symfony package and zendframework as dependency etc.

I did not see zend deps in https://github.com/doctrine/doctrine2/blob/master/composer.json#L18
Symfony is fine as we might end up using other symfony package as we progress.

I did not see zend deps in https://github.com/doctrine/doctrine2/blob/master/composer.json#L18

Yep, the doctrine is not installing zend deps directly. But the package they've used "ocramius/proxy-manager" is using that. https://github.com/Ocramius/ProxyManager/blob/master/composer.json#L21
And this doctrine lib have dependency of Symfony that was the main reason we dig into this lib since we already have some in our ee v4 core.

About the http://propelorm.org/ this lib itself says that it's not stable ( Never ending alpha ) and they recommended using Doctrine if we are looking for long term support so if we go with propel we might end up fork this repo and be maintaining this repo.

Our advice:
Use Doctrine if you are looking for a long-term supported, full-featured (and difficult to learn) and stable ORM.

ref: https://github.com/propelorm/Propel2#status-of-the-project
Also I see so many issue raised on repo already https://github.com/propelorm/Propel2/issues and seem they're not getting much of contriburions in this as they've mention in readme.

Avoid writing custom codes as ORM + Migration is not a focus area.

Closing it as it has we've written our custom migration code and chosen to go without ORM.


TizenWindow,View: Add PointerDeviceKindMouse according to device class

In Ecore_event and Evas_event, the devcie class can check Touch and Mouse event information.
So use this to pass the appropriate PointerDeviceKind.

I have yet to find a way to check between Mouse and Touch events in NUI.

Already implemented in https://github.com/flutter-tizen/embedder/pull/30.


aaPanel 7.x

aaPanel 7.x (specifically for me 7.0.4) seems to have patched the crack
It may not actually patched it, but broke it, maybe while changing it's environment to Python 3.12
I'm not really sure

I can safely say that it still worked with aaPanel 7.0.2
(Check on my server)

my server running on version 7.0.2, broken crack after update

I can safely say that it still worked with aaPanel 7.0.2 (Checked on my server)

How did you make it to work, the "Cr*ck" function seem not working, is it still worked with new install?

i tried it and when you click on the premium plugins it says bind account - the plugins still says Buy now
crack don't work

how intall aaPanel 7.0.2 ?

@Alien25Gaming
you have aaPanel 7.0.2

i found a way: you can install the script and you use it for life with latest updates, find it in this site
https://creative-digitaldownloads.com/
You might have to subscribe to VIP access (i 'd subscibe to the lowset subsciption £0.99 and have access ) small price to pay for what is being sold at almost $700
its a simple 1 line command you endup running in SSH - directions are given.
regards

@chaosnature - tried your solution on aapanel v.7.08 and it's not working anymore

did you use the code you found in https://creative-digitaldownloads.com/ ?


JavaScript: Typing "process.ex" should suggest "exit", not "execArgv"

I've never meant execArgv ever. Not once. 100% of the time, I was trying to type "exit".

Closing as this is not really actionable feedback

You can't change the algorithm to prioritize "exit" over "execArgv" in the completion suggestions list for "process.ex"?

Some people will want execArgv instead of exit. Trying to guess what the user wants falls under https://marketplace.visualstudio.com/items?itemName=VisualStudioExptTeam.vscodeintellicode

99% of the time people type "process.ex", they intend "it". Even "e" will be "xit". I've been annoyed by this so many times in the past few years that I finally created this issue to fix it. To me this doesn't seem like an AI question but a simple matter of prioritizing certain fields as far more likely than others, to be intended. But anyway whatever, your project, deal with it as you see fit.


Add /users/{username}/activity/current to get current activity

This would be a cool addition that people could use for example in their dashboards and status bars

@DrVilepis good enough?

yes this is good


spacesos: add writeup

@derlaft @Alagunto @pomo-mondreganto @jnovikov
can someone please review and merge?

Thanks for your contribution.
I want to ask you to improve your writeup before merging.

Pls translate it to English as our CTFs are international.
There are original sploits inside the sploits directory. It would be good to have a consistency with sploit, so I would ask to first explain the original (writeup solution) and add the provided by you as a alternative.


remove vote.mdx

fixes https://webpack.js.org/vote/

Sorry, I just missed this one and have already merged another pull request to fix it here https://github.com/webpack/webpack.js.org/pull/6017. @vankop Do you know we're still using that Vote page?

yes, we do.


Model documentation done.

Codecov Report

Merging #32 (4c91627) into main (7678eeb) will increase coverage by 0.06%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   32.44%   32.50%   +0.06%
==========================================
  Files          36       36
  Lines        1122     1123       +1
==========================================
+ Hits          364      365       +1
  Misses        758      758

Impacted Files
Coverage Δ

src/model/date/date.cpp
100.00% <ø> (ø)

src/model/order/order.cpp
76.08% <ø> (ø)

src/model/order/order.h
100.00% <ø> (ø)

src/model/order/order_manager.cpp
29.13% <ø> (ø)

src/model/person/boss/boss.cpp
10.00% <ø> (ø)

src/model/person/boss/boss.h
100.00% <ø> (ø)

src/model/person/client/client.cpp
54.54% <ø> (ø)

src/model/person/client/client.h
100.00% <ø> (ø)

src/model/person/person.h
100.00% <ø> (ø)

src/model/person/worker/worker.cpp
53.57% <ø> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f3bee...4c91627. Read the comment docs.


Fixes a typo in the verilog `elsif code generation

Is there a particular verilog simulator that doesn't like elseif?

I ran into this issue when using the vivado compiler but isn't it supposed to be elsif as per the language standards and not esleif?

Hmm, I've used firrtl generated countlessly many times with both Vivado and Synopsys DC and they haven't had any issues. What version of Vivado are you using?

Keep in mind this code is only generated with very particular use of Analog
(which is generally ill advised because it doesn't work in Verilator)
On Thu, Jun 8, 2017 at 6:18 PM edwardcwang<EMAIL_ADDRESS>wrote:

Hmm, I've used firrtl generated countlessly many times with both Vivado
and Synopsys DC and they haven't had any issues. What version of Vivado are
you using?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/freechipsproject/firrtl/pull/603#issuecomment-307242958,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIL84phFU7unbbmrBJnjh9a07HSezvakks5sCHNDgaJpZM4N0pVp
.

vivado 2016.1

System Verilog 1800-2012 Section 22.6 defines ifdef, else, elsif, endif, ifndef . I don't think using elseif is standards compliant.

VCS is very generous at tolerating non-standard Verilog features. So passing VCS is not really a proof of standard compliant.
Also for Vivado, the Vivado synthesiser is  more generous than the Vivado ISim simulator. Even if some code can be synthesised by Vivado, it might fail in simulation.
So if this is not compliant with standard and changing it is not a big deal, I would suggest to just fix it.


[ffmpeg] Enable libmfx for Intel Media SDK and oneVPL

Is your feature request related to a problem? Please describe.
The feature enable the use of hardware media decoder/encoder in Intel integrated GPUs and discreet GPUs

@js333031 Thanks for posting this issue. Sorry, vcpkg currently has no MediaSDK, we should add it first and then consider the issue of supporting ffmpeg. 🧐 https://github.com/microsoft/vcpkg/issues/14342

ffmpeg, currently supports Intel QSV using libmfx-dispatch. Its slightly older but can be enabled using ffmpeg[qsv]

@Sibras FIxed by PR https://github.com/microsoft/vcpkg/pull/28263


Long opus buffers very slowly

Media3 Version
Media3 1.0.1
Devices that reproduce the issue

Pixel 7 running Android 13
Emulators

Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps

Play the attached file in the demo app
Seek to hour 35

Expected result
The playback start immediately
Actual result
The playback doesn't start at all or starts after several minutes.
If in the range of < 20h the playback starts immediately on seeking. After the 25h mark it's getting very very slow.
Media
Sent by mail
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Also see https://github.com/PaulWoitaschek/Voice/issues/1653 for the original bug report and some theories by @zsln

I can reproduce it with v1.0.1. There is a wrong calculation when calculating the seek point, a long is overflowing. I'll  prepare a fix.


Fix concurrent map write

Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
eb16ccbf7e43d6a38566322de5dae8f573d9be7d
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
eb16ccbf7e43d6a38566322de5dae8f573d9be7d
link
true
/test lint_istio

gencheck_istio
eb16ccbf7e43d6a38566322de5dae8f573d9be7d
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
eb16ccbf7e43d6a38566322de5dae8f573d9be7d
link
true
/test lint_istio

gencheck_istio
eb16ccbf7e43d6a38566322de5dae8f573d9be7d
link
true
/test gencheck_istio

integ-operator-controller_istio
eb16ccbf7e43d6a38566322de5dae8f573d9be7d
link
true
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Technical Issue] The implementation of MeanRecall Metric may be wrong.

As presented in evaluation_recall.py, in line 52 and lines 259-260, the recall of total predicates is computed by averaging the total recall on each frame. These codes are correct since them are adpot from previous work STTran [1].
However, in the author's implementation, the recall_hit and recall_count on different frames are summed to compute the recall of each predicate, which is wrong. In this way, you merely obtain the "mean recall" on overall frames, not on each frame, which is conflict from original work.
[1] Spatial-Temporal Transformer for Dynamic Scene Graph Generation, CVPR 2021.

Can you elaborate as to why mR@K over all frames is incorrect? I am unable to understand your rationale. PS the same evaluation code was also used for computing the mR@K of STTran as well in order to ensure an apples-to-apples comparison.

Additionally we took the mrecall@K code from https://github.com/KaihuaTang/VCTree-Scene-Graph-Generation/blob/master/lib/evaluation/sg_eval.py the paper that first introduced mR@K.


refgenie pull/avail implementation and saving location

Commands that are server-aware are pull and avail (name to change??). These commands know about the  refgenie_server API. They will identify the URL for the genome server from the genome config file, and then uses that base URL to construct the API calls as needed.
pull
Confirms that the server has the requested resource, and then requests the tarball from the server. When an asset tarball is requested from the server (by refgenie pull), it will download it, move it to the correctly location (specified by genomes_folder or whatever in the genome config file), untar it, and then add that asset as a line item in the genome configuration file.
The asset arg should be nargs=+; that is, it accepts one or more. So, refgenie pull --genome hg38 --asset bowtie bowtie2
avail (name?)
Uses ones of the query APIs to show what's available...assets for all genomes if no genome is provided, or just assets for the given genome if --genome is provided.

this is now pretty much implemented in the dev branch... with the exception that it is not yet writing the config file, which will depend on attmap 0.11 functions.

config file now being written, basic avail function works.


test USE_BOTH option

Coverage increased (+13.3%) to 100.0% when pulling d4222b190a50c99ad6ef567a09298fdfd0b62306 on arrays into acd8e796170159fc73138dea110b709d959ca495 on master.


docs: add npm build to readme.md

To run scripts/finschia/init.sh, module @finschia/finschia is required. So, it is necesary to run npm build.

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):
Checklist:

[ ] I have added a relevant changelog to CHANGELOG.md.
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Quick js versus goja

Proposed change
https://gitlab.com/cznic/quickjs
Use case
Perf !
see benchmarks ..
Perhaps another agent in the v3 branch is the best way .
Darwin and windows should be possible too
Contribution
No response

See also this discussion https://github.com/synadia-io/nex/discussions/369

Not sure about this - complexity of build comes in to play. Goja has no C dependencies, and that makes the build significantly easier for us in the Golang world. Also, it's trivial to add new libraries to Goja, so we extend our model to 'wrap' all the network actions - this lets us have business-centric Javascript - we could have a GetWeather("home location") function that calls a NATS micro-service to grab the weather. The Javascript script has no knowledge of anything to do with the lower-level network calls and NATS callout etc. To my mind, trying to do that in QuickJS is horrible by comparison and breaks out of the Go ecosystem.

I've played with a few of these to build integration engines for our tech and clients - happy to share experiences, if that helps.