Launching MacVim.app shows no window; mvim at shell launches but cannot open new windows

This is a similar problem to #24.
At some point recently for me, opening Macvim via /Applications/MacVim.app no longer works. I initially installed MacVim via homebrew (with a simple brew install macvim and brew linkapps macvim). I've been having this issue before installing El Capitan.
Opening MacVim via mvim at the shell works, although note that this launches exec /usr/local/Cellar/macvim/7.4-79/MacVim.app/Contents/MacOS/Vim -g as opposed to exec /usr/local/Cellar/macvim/7.4-79/MacVim.app/Contents/MacOS/MacVim. However opening a new editor window in this launched MacVim with command-N or any other command does not work.
:version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Nov  4 2015 12:55:10)
MacOS X (unix) version
Included patches: 1-903
Compiled by Homebrew
Huge version with MacVim GUI.  Features included (+) or not (-):
+acl             +clipboard       +cursorshape     +extra_search    -gettext         +lispindent      +mouse_dec       +multi_lang      +profile         +smartindent     -tcl             +virtualedit     -X11
+arabic          +cmdline_compl   +dialog_con_gui  +farsi           -hangul_input    +listcmds        -mouse_gpm       -mzscheme        +python          -sniff           +terminfo        +visual          -xfontset
+autocmd         +cmdline_hist    +diff            +file_in_path    +iconv           +localmap        -mouse_jsbterm   +netbeans_intg   -python3         +startuptime     +termresponse    +visualextra     +xim
+balloon_eval    +cmdline_info    +digraphs        +find_in_path    +insert_expand   -lua             +mouse_netterm   +odbeditor       +quickfix        +statusline      +textobjects     +viminfo         -xsmp
+browse          +comments        +dnd             +float           +jumplist        +menu            +mouse_sgr       +path_extra      +reltime         -sun_workshop    +title           +vreplace        -xterm_clipboard
++builtin_terms  +conceal         -ebcdic          +folding         +keymap          +mksession       -mouse_sysmouse  +perl            +rightleft       +syntax          +toolbar         +wildignore      -xterm_save
+byte_offset     +cryptv          +emacs_tags      -footer          +langmap         +modify_fname    +mouse_urxvt     +persistent_undo +ruby            +tag_binary      +transparency    +wildmenu        -xpm
+cindent         +cscope          +eval            +fork()          +libcall         +mouse           +mouse_xterm     +postscript      +scrollbind      +tag_old_static  +user_commands   +windows
+clientserver    +cursorbind      +ex_extra        +fullscreen      +linebreak       +mouseshape      +multi_byte      +printer         +signs           -tag_any_white   +vertsplit       +writebackup
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X_UNIX  -F/usr/local/Cellar/python/2.7.10_2/Frameworks -I/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/include
/python2.7 -I/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/include/python2.7 -fno-strict-aliasing -fno-common -dynamic -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -isysroot /Applications/Xcode.app/Contents/D
eveloper/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -mmacosx-version-min=10.11 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -L/usr/local/lib -L. -L/usr/local/lib -F/usr/local/Cellar/python/2.7.10_2/Frameworks -L/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config -lpython2.7 -framework CoreFoundation -Wl,-sy
slibroot,/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -mmacosx-version-min=10.11 -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lm  -lncurses -liconv -framework Cocoa   -fstac
k-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl -F/usr/local/Cellar/python/2.7.10_2/Frameworks -framework Python   -framework Ruby

I've also done defaults delete org.vim.MacVim as mentioned in #66 but this has no effect for me.

I've also tried Snapshot 80 from https://github.com/macvim-dev/macvim/releases but to no avail. Any advice on how to troubleshoot would be greatly appreciated :smile:
When I try to launch MacVim.app I see these messages in Console.app
11/4/15 1:07:32.244 PM MacVim[65682]: [default] Failed to updated bookmark for item (null) [AB4B762B-349E-4344-9AE0-A7609A3ED9E3] - URL:file:///Users/mattbrown/code/helios/20151021T131155.335-com.spotify.helios.system.MasterAuthenticationTest_basicAuthentication-61321.log with error Error Domain=NSCocoaErrorDomain Code=260 "The file couldn’t be opened because it doesn’t exist."
11/4/15 1:07:32.245 PM MacVim[65682]: -[SFLListItem synthesizeMissingPropertyValues] Failed to updated bookmark for item (null) [AB4B762B-349E-4344-9AE0-A7609A3ED9E3] - URL:file:///Users/mattbrown/code/helios/20151021T131155.335-com.spotify.helios.system.MasterAuthenticationTest_basicAuthentication-61321.log with error Error Domain=NSCocoaErrorDomain Code=260 "The file couldn’t be opened because it doesn’t exist."
11/4/15 1:07:32.249 PM MacVim[65682]: [default] Failed to updated bookmark for item (null) [AB4B762B-349E-4344-9AE0-A7609A3ED9E3] - URL:file:///Users/mattbrown/code/helios/20151021T131155.335-com.spotify.helios.system.MasterAuthenticationTest_basicAuthentication-61321.log with error Error Domain=NSCocoaErrorDomain Code=260 "The file couldn’t be opened because it doesn’t exist."
11/4/15 1:07:32.249 PM MacVim[65682]: -[SFLListItem synthesizeMissingPropertyValues] Failed to updated bookmark for item (null) [AB4B762B-349E-4344-9AE0-A7609A3ED9E3] - URL:file:///Users/mattbrown/code/helios/20151021T131155.335-com.spotify.helios.system.MasterAuthenticationTest_basicAuthentication-61321.log with error Error Domain=NSCocoaErrorDomain Code=260 "The file couldn’t be opened because it doesn’t exist."
11/4/15 1:07:36.507 PM launchservicesd[84]: SecTaskLoadEntitlements failed error=22
11/4/15 1:07:36.614 PM launchservicesd[84]: SecTaskLoadEntitlements failed error=22

I am not sure if the last two are related but I do see them consistently ~2 seconds after messages from MacVim on each attempt at launching MacVim.app.

i have exact same issue. i had it on yosemite and now have it on el capitan as well.
i tried reinstalling vim completely with brew, and tried latest snapshot.
i also tried removing everything related to macvim from /Users/pavelkrasnovskij/Library/Preferences/

to clarify i tries snapshot 81.
if i try to run /Applications/MacVim.app/Contents/MacOs/MacVim manually in the console, it does the same, no output at all, cannot open any editor windows, but can open Settings menu, and can open File->Open menu, and it shows Recent files too. but no editor window ever opens.

Confirm, no exceptions, no windows. I have to reactivate MacVim to be able to open any windows.
configuration doesn't matter (I've tried all combinations)

In attempting to run MacVim.app through dtruss, I discovered that for me
$ /Applications/MacVim.app/Contents/MacOS/MacVim

has the problematic behavior but if ran as another user (for instance, root)
$ sudo /Applications/MacVim.app/Contents/MacOS/MacVim

windows open as expected.

i tried starting it with sudo and it worked for me as well.
so i tried looking for some cache files vim might have in ~/Library/Caches but didnt find any
then i tried starting it without ~/.vim and ~/.vimrc, didnt start
tried wiping out all files in /tmp/ folder, didnt start
lost hope, switched to another task which required restart.
after restart, surprisingly, it started working
even though it didnt work for last 2 months for me

A restart works for me as well :confused:

So rebooting OS X solved the issue, right?

If I understand correctly, first running binary with sudo, then rebooting
I'm not sure that just rebooting solves this issue
On lau., 7. nóv. 2015 at 05:57, Kazuki Sakamoto<EMAIL_ADDRESS>wrote:

So rebooting OS X solved the issue, right?
—
Reply to this email directly or view it on GitHub
https://github.com/macvim-dev/macvim/issues/109#issuecomment-154631057.

I don't think that running the binary with sudo changed or fixed anything as the problem still existed afterwards until rebooting; it was just a troubleshooting step along the way.

Anyone has the issue right now? I can't reproduce it, but it sounds like there is old Vim process aside from the new MacVim/Vim process. So if you had the same issue, to confirm there are no Vim processes using 'ps auxww' or Activity Monitor.

@splhack I did notice when I was having the issue that I had a MacVim process still running (looked like sudo -u myusername /path/to/MacVim), although I thought at the time pre-reboot that it might have been spawned by some investigation I was trying to do with dtruss.
Interestingly the process seemed to be unkillable, kill, kill -9, kill -15 etc did not terminate it.

It sounds like the Vim process was zombie process, or the Vim process got I/O error. It should be checked using ps auxww|grep -i vim. And all we need to know is how to reproduce the issue.

i managed to reproduce this issue.
on my machine, macvim wont start properly if i docker vm is up.
i tried following several times:

quit macvim
run "docker-machine start default"
open macvim: doesnt work, doesnt open new editor windows.
quit macvim
run "docker-machine stop default"
open macvim: works properly!

actually, this even happens without quitting it.

open macvim app with docker off: works properly.
run "docker-machine start default": editor windows now stop opening in macvim
run "docker-machine stop default": macvim starts working properly again

I am also using docker-machine and I've found that starting a VM with it also re-causes this problem. My docker VM is using the VirtualBox driver, and it seems like if I create the VM with VMWare Fusion instead then I do not have an issue.
Does MacVim or Vim expect to connect to anything on the host on tcp port 2376? docker-machine sets up the VMs to listen on this port, on a private IP (chosen from CIDR <IP_ADDRESS>/24) host-only network interface. The IPs handed out to VMWare Fusion VMs seem to be on a different range, <IP_ADDRESS>/24.

Just discovered this thread after noticing that macvim had stopped working. The advice here is spot on; I'm using docker-machine with virtualbox, and stopping my VM allows macvim to work again.

How to reproduce it?
$ killall Vim
No matching processes belonging to you were found
$ killall MacVim
No matching processes belonging to you were found
$ defaults delete org.vim.MacVim

$ docker-machine ls
NAME      ACTIVE   DRIVER       STATE     URL   SWARM
default   -        virtualbox   Stopped

$ docker-machine start default
Started machines may have new IP addresses. You may need to re-run the `docker-machine env` command.

$ docker-machine ls
NAME      ACTIVE   DRIVER       STATE     URL                         SWARM
default   *        virtualbox   Running   tcp://<IP_ADDRESS>:2376

$ /Applications/MacVim.app/Contents/MacOS/Vim -g -u NONE -U NONE

MacVim works fine for me.

well this line works (as mattnworb established in the first post):
$ /Applications/MacVim.app/Contents/MacOS/Vim -g -u NONE -U NONE

but starting MacVim in gui (clicking it in dock) doesnt work.

and (also, as established in issue's name) after launching this:
$ /Applications/MacVim.app/Contents/MacOS/Vim -g -u NONE -U NONE
new windows dont open (File->New window menu item doesnt do anything)

Ok, I guess I found out.
https://groups.google.com/d/msg/vim_mac/kPo414xEHmk/eddzYMlpAgYJ

Turns out I had a circular logic in my .bashrc that was causing it to
hang whenever I ran bash

So changing the default setting will solve the issue.
$ defaults write org.vim.MacVim MMLoginShellKey false

If you have this issue, you should verify your login shell environment.

'SHELL' environment variable is correct? (no 'SHELL' set is totally ok)
login shell does work properly? for example 'bash -l' does work?

yes, this command solves issue for me:
defaults write org.vim.MacVim MMLoginShell -bool NO

but i didnt have any circular logic in shell
$ echo $SHELL
/bin/bash
$ bash -l
$

i tried removing everything from my bashrc/bashprofile
thing which stops macvim from working properly is this line in .bashrc:
  eval "$(docker-machine env default)"

this is simple eval, resulting in:
 export DOCKER_TLS_VERIFY="1"
 export DOCKER_HOST="tcp://<IP_ADDRESS>:2376"
 export DOCKER_CERT_PATH="/Users/pavelkrasnovskij/.docker/machine/machines/default"
 export DOCKER_MACHINE_NAME="default"
 # Run this command to configure your shell:
 # eval "$(docker-machine env default)"

oh all right, now i understood.
.bash_profile is for non interactive shells (http://www.joshstaiger.org/archives/2005/07/bash_profile_vs.html), so each eval command re-executes it. so it is circular logic.
but on os x .bash_profile is used instead of .bashrc on interactive shell start, so people who work in terminal tend to put things there.
proper solution to such cases is moving all code related to interactive shells (like such evals) to .bashrc and adding following to your .bash_profile:
if [ -f ~/.bashrc ]; then
source ~/.bashrc
fi
Thank you @splhack for figuring this out. it was not macvim issue.

Typing gvim after a brew install MacVim (7.4 as of this post) opens MacVim and shows an icon in the macOS dock.  right click it and choose options and keep in dock.  it also shows up in the context menu right clicking a file in the finder.  you an also drag a doc to the icon in the dock.  I removed the Vim.app that was installed in the applications folder.  it crashed after bouncing a few times in the dock.  vim at the command line opens a shell vim.

defaults write org.vim.MacVim MMLoginShell -bool NO
works for me, thanks.

I found a solution on my MBPro running macOS High Sierra 10.3.3. The MacVim installed on my machine expected Perl 5.16 and Ruby 2.0. With High Sierra, the versions are Perl 5.18 and Ruby 2.0.
What I did was open a terminal, change directory to /Applications/MacVim.app/Contents/MacOS
At the command line prompt, run ./Vim
It will give an error message about the libperl.dylib it couldn't find. In my case /System/Library/Perl/5.16/darwin-thread-multi-2level/CORE/libperl.dylib.
Edit Vim to put the correct version number in:
vi -b Vim
/Perl.5.16
Change the 6 to an 8 (for Perl 5.18) and save the file.
Run ./Vim again, and get an error message about which Ruby dylib it couldn't find. In my case, it was looking for 2.0, and 2.0.0. I edited Vim as above, found the string for Ruby 2.0, changed it to 2.3, and the 2.0.0 to 2.3.0 and saved Vim.
Now, MacVim opens a window just like it did before.

@splhack nailed it for me! For the record, i had a lot of zombie MacVim/Vim processes left in the background. Once I stopped them everything returned to normal and I was able to get back into MacVim 👍

@NoShill Your solution works for me! It seemed like that Vim did not update when the build-in perl and ruby got updated in the MacOS.

@w0i0c0o MacVim uses Perl 5.18 since snapshot 148 and Ruby 2.5 sinse snapshot 145.

Sorry. I have tried following this thread but it is unclear what the solution is. Was anyone able to actually find the cause of the issue?

@FrankDMartinez Could you describe what you want to achieve and eventually open a new issue?

I'm asking as new issue form will ask a few important questions better to answer, also we'll be able answer it better


[flash_ctrl] Update ECC handling

Refer to #4812

When an instruction type transaction sees an uncorrectable error, it is always returned to the source as an error.

When a data type transaction sees an uncorrectable error, it is returned based on software configuration (this may be further improved to lv_hw_debug_en.  Discussions are ongoing).

Regardless of the error return type to the source, the error is always collected in the flash_ctrl and alerts generated for consumption.

it would be great if the software team can chime in and think about whether this makes sense.
Basically it boils down to...

if we have an ecc error on the instruction, what should happen? (general consensus seems to be exception)
if we have an ecc error on data, what should happen? (I personally think we should not exception, and software should be notified differently for handling).

after discussion with software, we should separate the single_err_cnt and multi_err_cnt interrupts in case the handling for them needs to be different.

could someone have a look at this and let me know what you think?


Typescript: Pass an extra parameter

I was trying the below code from the documentation
interface Point {
    x: number;
    y: number;
}

function getX(p: Point) {
    return p.x;
}

class CPoint {
    x: number;
    y: number;
    constructor(x: number,  y: number) {
        this.x = x;
        this.y = y;
    }
}

getX(new CPoint(0, 0));  // Ok, fields match

getX({ x: 0, y: 0, color: "red" });  // Extra fields Ok

getX({ x: 0 });  // Error: supplied parameter does not match

As per the code comment says below line should be ok.
getX({ x: 0, y: 0, color: "red" });  // Extra fields Ok
But i am getting error as below:

error TS2345: Argument of type '{ x: number; y: number; color: string; }' is not assignable to parameter of type 'Point'. Object literal may only specify known properties, and 'color' does not exist in type 'Point'

But the below code works well which i re-wrote in which i made params as optional:
interface Point {
    x: number;
    y?: number;
    color?: string;
}

function getX(p: Point) {
    return p.x;
}

class CPoint {
    x: number;
    y: number;
    constructor(x: number,  y: number) {
        this.x = x;
        this.y = y;
    }
}

getX(new CPoint(0, 0));  // Ok, fields match

getX({ x: 0, y: 0, color: "red" });  // Extra fields Ok

getX({ x: 0 });  // Error: supplied parameter does not match

Please can somebody help me out if the documentation is wrong or am i missing something here
FYI i am using:

Typescript v1.7.5
Visual studio code

Same is been asked in stackoverflow:
I have attached the screenshot FYI.

I'd say the documentation wrong / out of date. The error you are seeing is an example of #3823. It would have worked before that PR, which landed in v1.6.

This is in the spec, not the docs.

As pointed by the Stackoverflow answer below code fixes the problem
 getX({ x: 0, y: 0, color: "red" } as Point); // no error
This is not given in spec.

It's a cast - casting is in the spec, and it's a feature. Just remember that a cast is basically you overriding the compiler and saying "this is the type of this thing at this position", and so its mostly your responsibility to make sure it's valid to cast in a given situation.

A "nicer" way to "fix" the types and allow passing an argument with extra members would be modifying the signature of getX like so:
function getX<T extends Point>(p: T) {
    return p.x;
}

Though it may not be immediately obvious how this is any different.

for future references, more information about strict object literal checking can be found at https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#strict-object-literal-assignment-checking


Relocate make_random_state() method

Proposed changes
Connected to #279. Follow-up to #322. This is a long due change, and as I was reworking sensor models I figured it was appropriate. This patch removes make_random_state() from sensor models. As we still support mixins, it relocates make_random_state() to the RandomStateGenerator mixin, which now takes both state and map as template parameters.
Type of change

[ ] 🐛 Bugfix (change which fixes an issue)
[x] 🚀 Feature (change which adds functionality)
[ ] 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Sensor models no longer have nor require a make_random_state() method.
Checklist

[x] Lint and unit tests (if any) pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All commits have been signed for DCO

Additional comments
I'm not super fond of these changes to RandomStateGenerator, but they are not unreasonable in context and it is arguably a temporary workaround.
We also have to update https://github.com/Ekumen-OS/beluga-demos to match.

Hmm, I suspect coverage worsened because this patch removes more code than it adds (and thus it changed proportions). How do you want to go about it @nahueespinosa?

@hidmic Let's go ahead and merge. I don't see anything standing out in the coverage reports.


[RHEL 9.3.0] deps: update osbuild/images to v0.3.0-r9.3.2

Update images dependency to pull in change to minimal raw images [1] for release into RHEL 9.3.0.
Includes fix for Azure image kernel options [2].
[1] https://github.com/osbuild/images/pull/163
[2] https://github.com/osbuild/images/pull/166

Tests / edge-simplified-9 is due to bug https://issues.redhat.com/browse/RHEL-4992.

Tests / edge-simplified-9 is due to bug https://issues.redhat.com/browse/RHEL-4992. I have workaround PR #3690

Thank you!  I cherry picked the commit over.

@achilleas-k All green now.


Test: Drone fix

Looking very good so far... holding thumbs!

:+1:

@bnaul I'm going to merge this so we can have more green marks all round, but if you see any problem with it we can always revert.

:+1:
On Fri, Oct 2, 2015, 4:47 PM Stefan van der Walt<EMAIL_ADDRESS>wrote:

@bnaul https://github.com/bnaul I'm going to merge this so we can have
more green marks all round, but if you see any problem with it we can
always revert.
—
Reply to this email directly or view it on GitHub
https://github.com/mltsp/mltsp/pull/73#issuecomment-145184561.


Passing merge options to Git.Merge.trees

System information

node version: 10.15.3
npm or yarn version: 6.4.1
OS/version/architecture: win32 / 10.0.17134 / x64
Applicable nodegit version: 0.24.1

Months after opening and fixing https://github.com/nodegit/nodegit/issues/1504, I need to pass options to Git.Merge.trees, but I still don't know how. For example, assume I want to pass GIT_MERGE_FAIL_ON_CONFLICT as flags. I tried this based on existing TypeScript definitions (and based on @johnhaley81's https://github.com/nodegit/nodegit/issues/941#issuecomment-193810255):
const index = await Git.Merge.trees(this.repo, baseTree, ourTree, theirTree, {
  flags: 2 // Using a constant since I did not find FAIL_ON_CONFLICT in nodegit.
});

However, this leads to a CRT assertion failure: object->InternalFieldCount() > 0.
I tried to use git_merge_init_options, there are TypeScript definitions for Git.Merge.initOptions (and it is shown in https://github.com/nodegit/nodegit/issues/941#issue-138930436), but the function does not seem to exist in nodegit: TypeError: Git.Merge.initOptions

@tniessen If you pass in nothing (so the function only takes four arguments), does it crash?
If you pass in an undefined, null, or an empty {} object, does it crash?

From my experiments:

function doesn't like there only being four argments (Error: Callback is required and must be a Function.)
undefined completes (I did not verify the result, just that the code executed without crashing)
null completes (I did not verify the result, just that the code executed without crashing)
{} crashes

@tniessen Maybe try this workaround?
const opts = Git.Utils.normalizeOptions({ flags: 2 });
const index = await Git.Merge.trees(this.repo, baseTree, ourTree, theirTree, opts);

@rcjsuen I can confirm your observations from https://github.com/nodegit/nodegit/issues/1666#issuecomment-485475477. Passing in undefined or null does not cause a crash, but also does not lead to the desired behavior (failure on merge conflicts).

Maybe try this workaround?
const opts = Git.Utils.normalizeOptions({ flags: 2 });
const index = await Git.Merge.trees(this.repo, baseTree, ourTree, theirTree, opts);

This did not work, however, adding the correct constructor did:
const opts = Git.Utils.normalizeOptions({ flags: 2 }, Git.MergeOptions);
const index = await Git.Merge.trees(this.repo, baseTree, ourTree, theirTree, opts);

This does indeed solve the problem. Sadly, these APIs appear to be completely undocumented and there are no type definitions available yet.

@tniessen Sorry about that, I gave you the incorrect code. What you wrote is what I had intended to provide you. :(
Now that the problem is understood I have a fix in mind. It's easy to write a test that doesn't crash but it'll require some more thought to go all the way and verify that the resulting index is correct.

@rcjsuen No problem, thank you for your help! There seems to be a general problem with parameter validation, supported APIs, tests and documentation in nodegit. Maybe my use cases are unusual, but I feel like I frequently stumble across such issues. Is there anything I can do to improve the situation?

Is there anything I can do to improve the situation?

You already are by opening bugs! :)
I think writing tests for functions that aren't covered would be helpful. Anyone that tried writing a test for this function would likely have encountered the bug that you have just uncovered (assuming they didn't just simply use undefined or null ;)).
The documentation certainly needs work too but I'm not familiar with the build process of that and/or how it extracts comments from the JavaScript files.

The long term fix-all-cases would be to create a JSOptionsToCPPOptions template that we can generate for options types and utilize in the convert from v8 utility for parameters on methods.


Too many open files

I am using optuna_distributed with optuna.storages.JournalStorage and after ~480 trials i get:  OSError: [Errno 24] Too many open files.
  Number of trials:  479 // All
  Number of complete trials:  419 // optuna.trial.TrialState.COMPLETE

Output of ulimit:
open files                      (-n) 1024

I am wondering if each trial properly closes the logging file after being completed.
Here is a snippet of my code:
    storage = optuna.storages.JournalStorage(
        optuna.storages.JournalFileStorage(f"{args.output_dir}/{config_name}.log"),
    )

    study = optuna_distributed.from_study(
        optuna.create_study(study_name=config_name, direction="maximize", storage=storage, sampler=sampler, load_if_exists=True)
    )

    study.optimize(
        lambda trial: objective(trial=trial, dataset_dir=args.input_dir, search_config=search_config, seed=0),
        n_trials=int(args.n_trials),
        n_jobs=int(args.n_proc)
    )

Here is the full error message:
    study.optimize(
  File "/home/ggoupy/.local/lib/python3.8/site-packages/optuna_distributed/study.py", line 192, in optimize
    event_loop.run(terminal, timeout, catch)
  File "/home/ggoupy/.local/lib/python3.8/site-packages/optuna_distributed/eventloop.py", line 65, in run
    self.manager.after_message(self)
  File "/home/ggoupy/.local/lib/python3.8/site-packages/optuna_distributed/managers/local.py", line 92, in after_message
    self.create_futures(event_loop.study, event_loop.objective)
  File "/home/ggoupy/.local/lib/python3.8/site-packages/optuna_distributed/managers/local.py", line 61, in create_futures
    p.start()
  File "/usr/lib/python3.8/multiprocessing/process.py", line 121, in start
    self._popen = self._Popen(self)
  File "/usr/lib/python3.8/multiprocessing/context.py", line 224, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
  File "/usr/lib/python3.8/multiprocessing/context.py", line 277, in _Popen
    return Popen(process_obj)
  File "/usr/lib/python3.8/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/usr/lib/python3.8/multiprocessing/popen_fork.py", line 69, in _launch
    child_r, parent_w = os.pipe()
OSError: [Errno 24] Too many open files

Hi, thanks for reporting this!
This is most likely related to a bug in my process management logic, not the storage you're using. I will investigate it further (hopefully) next week and let you know once the patch is out.

Thanks :+1:
Alternatively, increasing the limit seemed to circumvent the issue:
import resource
soft, hard = resource.getrlimit(resource.RLIMIT_NOFILE)
resource.setrlimit(resource.RLIMIT_NOFILE, (8192, hard))

Hi @ggoupy, this issue has been fixed in the latest release. You can install it by running pip install -U optuna-distributed.

Thanks for the quick fix🙏


Trait std::error::Error not implemented for amiquip::error

Error is a trait that "[represents] the basic expectations for error values".
It should be easy to implement, the problem is that your implementation of failure::Fail conflicts because of the cause function. I was hoping there might be an updated version of failure that had fixed the issue and you could simply upgrade, but sadly the most recent version1 still has the collision.
Not sure the easiest way forward. For now I plan to fork and create a nasty fix that probably involves making another kind of Error struct that wraps yours and correctly implements the std Error trait.
1: Version 0.1.5 at time of writing this

For those who are interested, here's my quick fix: https://github.com/mkeedlinger/amiquip/commit/d64a0a03cb977907c8b8a1e39afd19b2f05feb5c

Hm, that's not great. I've been using snafu recently and really liked it; maybe I should switch to that for amiquip?

It looks like they implement the Error trait, so sounds good to me!

0.3.0 is live; Error now impls std::error::Error.

Very cool!


headless-chrome: The response: 'Host header is specified and is not an IP address or localhost.'

I'm using the headless-chrome service for running browser tests and the url in my app settings is set to "http://chrome:9222", but when I run my tests I get the error that's in the issue title. I've been searching around and apparently it's down to the Chrome version being used.
This issue https://github.com/OnetapInc/chromy/issues/110 explains what's going on and I tried switching to the container/version they're using which stopped the error but gives me a new one.
Facebook\WebDriver\Exception\WebDriverException: JSON decoding of remote response failed.
Error code: 4
The response:

I'm guessing it's using the correct container and port name now, but something in the service yaml file isn't set correctly which is why the response is now blank. Any help with this issue would be greatly appreciated.

@juban @isholgueras any thoughts on this?

@Michael-Brooks @rfay I'm not familiar with chromy, but perhaps you could try to install a headless chrome directly into the ddev web container using a custom Dockerfile and run your tests directly within the container ? Installation would go something like this:
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo dpkg -i google-chrome*.deb

Thanks @juban, I'll give that a go

@Michael-Brooks In case you are struggling to install chrome in the ddev web container, you can add the following Dockerfile into .ddev/web-build which will install the needed dependencies and the latest chrome version. If that's still not working with chromy, you could perhaps download an older version of chrome.
ARG BASE_IMAGE
FROM $BASE_IMAGE
RUN apt update
RUN apt -y install gconf-service libasound2 libatk1.0-0 libcairo2 libgconf-2-4 libgdk-pixbuf2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libx11-xcb1 libxcomposite1 libxcursor1 libxdamage1 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 fonts-liberation libappindicator1 libnss3 xdg-utils libappindicator3-1 libdbusmenu-gtk3-4 libgbm1 libindicator3-7 libwayland-server0
RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
RUN dpkg -i google-chrome*.deb

Oh sorry @juban, I think you misunderstood what I was trying to say. I was trying to use https://github.com/drud/ddev-contrib/blob/master/docker-compose-services/headless-chrome/docker-compose.chrome.yaml but ran into the error as titled.
I did a Google search to find that Chromy had the same issue and they used an earlier version of Chromy to fix. I then thought I would give Chromy a try with the version they used and received a blank page.
The headless chrome service linked above won't allow me to use an earlier version of Chrome since I think it always uses the latest.
I tried creating my own Dockerfile in web-build as suggested, but I can't seem to get it working on port 9222. If I add the below to the Dockerfile, then my ddev-router stops working.
ENTRYPOINT [ "google-chrome" ]
CMD [ "--headless", "--remote-debugging-port=9222" ]

I got it working https://github.com/drud/ddev-contrib/pull/51 in the end. Thank you so much for trying to help, I really appreciate it.


State how 'MOUSE_MODE_CAPTURED' actually works in the 'Input' docs

The docs previously erroneously stated that while on MOUSE_MODE_CAPTURED, the mouse was just kept inside the window, when in reality, it's locked at the center of the window. This PR gives the correct information, and also, gives a tip about getting the relative speed taken from the online docs.

Thanks much, looking good!

Thanks!

Cherry-picked for 3.2.3.


Deanonymize author names

Currently we output Wikibook's user names of the authors. However, many of our authors doesn't use their real names. I can imagine, that they want to use their real names instead. Therefore, we need to translate certain user names to the real author names (in case the authors want this).

Implemented and done


[Bug]: Footer not responsive in smart phones

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
[Bug]: Footer not responsive in smart phones footer is take extra width in the website

assign me @man
Add Screenshots
No response
What browsers are you seeing the problem on?
Chrome
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

footer section for newsletter assigned recently

footer section for newsletter assigned recently

please tell me issue number

#398

#398

okey thank you
if you have any html css related issue please assign me


some changes

some minor changes. May merge if seem fit.

@agentjill
Thank you very much.
It looks fine, so I will merge it in.


Update trace by scroll-v4.2.2

Based on trace-dumper

we also need to think about a way to update [bridge](https://github.com/scroll-tech/test-traces/tree/main/bridge) traces.
you can borrow the idea from https://github.com/scroll-tech/testnet/blob/develop/scripts/fetch-traces.sh

Appear an error when running deploy-eips.sh, others are running successfully.
error content: (code: -32000, message: only replay-protected (EIP-155) transactions allowed over RPC, data: None)

i will use the commit 7245cca for a while. so don't force push or delete branch

Fixed.


Fix some typos and clippy lints

Fix some typos and clippy lints like:
warning: this could be a `const fn`
   --> crates/tests_integ/ch_client/src/types/mod.rs:112:5
    |
112 | /     pub fn is_nullable(&self) -> bool {
113 | |         (self.flag & FIELD_NULLABLE) == FIELD_NULLABLE
114 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

warning: this expression borrows a reference (`&std::string::String`) that is immediately dereferenced by the compiler
   --> crates/meta/src/store/sys.rs:678:50
    |
678 |                 let cid = self.new_col(&dn, &tn, &colname)?;
    |                                                  ^^^^^^^^ help: change this to: `colname`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@pymongo  really appreciated for your first  contribution!
The clippy lints makes TB scared in that some high performance are anti-pattern! But for long run, we want to make clippy passing in some extent to make engineering and performance harmoniously combined as possible.
Your PR is a great effort! Thank you!


i finally got it working! but its taking representation from my files? i thought it was going to cross reference the facial features of this person in the photo of mine with the endless list of people with photos of your facial rec listing?

this extracting faces from mutliple files of mine but i only wanted it to scan the photo i gave it to cross reference it with others that you have stored in your facial rec of every person who has uploaded their own pictures on the internet

It compares image given in img_path and images in db_path.

It compares image given in img_path and images in db_path.

wait you mean your application isnt going to compare images that it already has instored in it because your application has no stored images?

It compares image given in img_path and images in db_path.

does your application not have all the stored images of every person who ever uploaded their pictures on the internet?

Of course no!

Of course no!

wait then how is it a facial rec application?
im talking the facial rec of websites where you can upload a picture and they use their dataspace of all the stored pictures of people who posted theirs online to cross reference the facial features of the one you have giving you a list of potential sourses thus finding out who the person in your picture you uploaded is by the list provided, that has social media and etc of the listed results?


Repackage prometheus-boshrelease with modifications in prometheus config and specs

Hi Ferran
Can you kindly leave me instructions on how to repackage prometheus bosh release.
I want to modify prometheus configuration and disallow TLS 1.0 and repackage the prometheus tar ball before bosh deploy the modified release.
Thank you so much for your inputs.
Cheers
Beth

I've worked a bit more on it and it's resolved now.  What I did was to follow your instructions in README.  I'll close this question.


Dockerfile updates - speedup!

 Some formatting as well.
As of writing this works on my own machine, yet travis had some issues with downloading the base image... Awaiting it again.

@linuxbandit If you could also give feedback about this 3-way split of the docker-compose file, I think this could be a nice 'standard' format.

https://github.com/AEGEE/oms-neo-core/pull/79/commits/cbb3b891a3f967df186064eaae128a2df9611833
Is interesting, as I believe it does run more lightweight, yet it actually significantly increased the bootstrap time (composer install takes long)

I like that it is lightweight! I just need to test it too


I could add a property that prevents the lines that cross the graph from being of a different color

PR is welcome.


⚠ Samsung has degraded performance

In eafb3ef, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2940 ms

Resolved: Samsung performance has improved in d3ac2a0.


Track number of times a user has used an ability badly

If we track how many times a user has 'sinned' for lack of a better word, we guard against 'accidental morons'. It will quickly become very apparent which ones are the repeat offenders.

looks like this in devtools: http://i.imgur.com/Eq1MVfd.png


feat: promote generated CRDs to first-class citizens

I think the CRDs generated by controller-gen deserves to be available in our projects, and not just temporary files used as input to Helm CRD templates. While this will semi-duplicate the CRDs in project repositories, I think it has a lot of benefits (not limited to):

Making CRD manifests available in projects, and not just wrapped in a Helm chart.
Easier to publish CRDs as a release artifact on releases, which is requested in several issues across the cert-manager org.
Avoiding pitfalls such as https://github.com/cert-manager/trust-manager/blob/main/test/integration/bundle/integration.go#L41, which is a semi-blocker for running integration tests for IDEs.

I have suggested the default kubebuilder path for CRD manifests, even if we don't use/require kubebuilder in our projects. Open for other suggestions, but I think the term "bases" is important - as I think we can use kustomize to transform CRD in other use cases.

/cc @inteon
/cc @ThatsMrTalbot

but I think the term "bases" is important

Im not sure, if we just want to publish the CRDs I don't see why we need to pollute the path, I would opt for something like deploy/crds

I am ok with any path, as long as we get the plain CRD manifests under source control.  😸 I don't think we currently have any conversion webhooks active, but kustomize patches are useful to fix/enrich the CRDs. Example: https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4/config/crd. Another interesting approach is using kustomize to "templatify" the CRDs into a Helm template. Example: https://github.com/cybozu-go/accurate/tree/main/config/kustomize-to-helm/overlays/crds. In addition, I believe using kubebuilder "standard directory layout" will make contributor "feel more home" in general.

Adding here what I said on slack: I think I'm supportive of this as long as there's automation in place to ensure that these CRDs are updated correctly!

We currently use the Helm chart to generate the CRDs: https://github.com/cert-manager/trust-manager/blob/main/make/test-integration.mk#L15-L19.
This makes sure that the CRDs used for testing match what we output as release artifact. Additionally, this will perform all the templating that was injected.
It's not clear why we want to have the CRDs in a separate file (why being wrapped in a Helm chart is a bad thing).
The unit, integration and e2e tests often have dependencies that have to be generated by Make before running the test. CRDs are just one of the dependencies. I normally run the make target & re-run the go test using the environment variables that were generated for the make target (I agree this is non-ideal, but it will also account for other missing dependencies).

The unit, integration and e2e tests often have dependencies that have to be generated by Make before running the test. CRDs are just one of the dependencies.

As discussed in our stand-up, I don't this is a valid argument. Why shouldn't we fix this problem for the CRDs when possible, even if we have similar issues to fix later on? 😕
I had a look at the cert-manager CRDs mentioned in the stand-up, and they are currently not the same thing as I am suggesting here. They seem to be "temporary" Helm templates, and not usable to solve my use-case (example). They are also updated (not fully generated) by another controller-gen command. I believe this could be greatly improved by migrating to the standard controller-gen crd command, even in cert-manager, but that remains to prove. 😉  I also found https://github.com/kubernetes-sigs/controller-tools/issues/571 registered by @maelvls.
I am currently in doubt if this PR will be accepted - in any shape, based on some of the feedback so far. 😢 How do we get to a conclusion (hopefully a consensus) here?

How do we get to a conclusion (hopefully a consensus) here?

I feel like there are a few things which make me supportive of this PR even though I wouldn't personally use the generated CRDs in my workflow:

It's a fairly small and simple change
We can easily tell if these files are "up-to-date" in the repo and have CI to enforce that
We can leave the CRDs as an implementation detail of setting up tests and warn people away from using them
It's easy to revert if we regret it (especially if we warn people away from using them for now).

I think it's worth a go from that basis. The key concerns I can see are:

Adam asking about if this should be in the Helm module, which seems valid on the face of it - this doesn't really relate to Helm. I can see the motivation for wanting the simplest possible change, but I think both of Adam's suggestions make sense and don't seem to be disruptive? An alternative would be to keep this logic in the Helm module for now with a big comment saying it'll be moved elsewhere later, but tbh it seems reasonable to move the logic now, in this PR.

Tim's comment:

It's not clear why we want to have the CRDs in a separate file (why being wrapped in a Helm chart is a bad thing).

I think the description of this PR could do with a line explaining why having the CRDs usable without Helm is desirable. As I understand it I think the reason is "it makes it possible / easier to use those CRDs more easily with other tooling such as IDEs" which is not a bad reason. But it wouldn't hurt to spell it out!
I don't see a reason why if those two concerns are addressed we couldn't give this a go - again, it's easy to revert it we think it was a mistake. Generally, I'm supportive of checking generated files into git where it's not too much of a burden, because there's value in being able to visually look at the file in a checkout / on GitHub, and it removes a step for people to get started contributing and we want it to be easy to get started!

I had a long talk with @inteon (since he seems most negative to do this) last Thursday, hoping we can reach a consensus around this. And we did, at least we came to a shared understanding about the pros and cons. This resulted in a proposed alternative local fix in trust-manager. I am not too happy with just a local fix when we have established makefile-modules. In addition, the proposed alternative has an issue (that probably could be fixed - if we decide to move forward with it):

make generate-crds does not update the static CRDs

After thinking a bit more around this, I still believe generating static CRDs from the "master" in Go sources (as we already do, but to a "temp" location) is better than re-generating and filtering them out from the Helm chart. And I don't want this to be a local fix in trust-manager. I also work on approver-policy, and I have plans to work more in cert-manager.
So without trying to start a "fight" with Tim, I am going to raise this as a decision point to our next bi-weekly meeting agenda. 🧨
To support my case, I browsed some other popular open source projects to see how they do it. It is certainly possible to find examples supporting the opposite view, but here is what I found:

Flux kustomization-controller (same in other Flux controller projects)
Prometheus Operator
Kyverno
Cillium
OPA Gatekeeper
SPIRE Controller Manager

Many projects seem to also have adopted the kubebuilder standard layout, which is something I also prefer, but this is currently a non-goal for me to introduce this into cert-manager projects. Even if I think it would make any drive-by cloud engineer feel more "home" in our projects.  For me, the primary goal now is just to be able to work more effectively and with less friction on cert-manager projects.

I'm in favor of approving this change. Ash already explained really well the pros and cons, so I will refer to his comment.
As I understand it: with this change, developers of projects using Makefile Modules will no longer need to run some make command before being able to run "fake clientset" tests, that we also call "integration tests". I see myself benefiting from this change since I've often bumped into the issue when running the fake clientset tests with the Delve debugger and had to configure env vars for it. The slight duplication (if we can call it that) is frankly not a problem to me.

@erikgb I further discussed this PR with @maelvls this morning and we agreed that we want to empower you to make these kind of changes. Based on our past collaboration, we also know that we can rely on you taking ownership of this solution and making sure the solution is consistent across all projects. Additionally, this solution can still improve in the future.
My alternative solution https://github.com/cert-manager/trust-manager/pull/482 can be closed after we finish and merge this PR.
I'm looking forward to better understand this approach and the next steps it will unlock.
/approve

/lgtm
If Tim has approved, I'm happy to LGTM on that basis! Looking forward to seeing more on this 🚀

I further discussed this PR with @maelvls this morning and we agreed that we want to empower you to make these kind of changes. Based on our past collaboration, we also know that we can rely on you taking ownership of this solution and making sure the solution is consistent across all projects. Additionally, this solution can still improve in the future.

Thanks for the faith @inteon! Appreciated! ❤
I think this PR was merged a bit quickly. We got lost in principal discussions and forgot to discuss the following bullets:

Where should the generated files be located (by default) in our projects?
Should we try to refactor the generation out from the Helm makefile-module? Or just keep them in Helm, at least for now?

Any input here would be appreciated!

Indeed. I should have specified: I /approve the changes but have not tested nor reviewed the code ( I think the /lgtm command indicates that normally ).

Sorry, I thought this was good to merge! We'll revert and re-review a followup. I don't think we've ever formalised what the different review actions mean and maybe that's worth writing down some time.

Where should the generated files be located (by default) in our projects?

deploy/crds/... IMO, to match cert-manager?

Should we try to refactor the generation out from the Helm makefile-module? Or just keep them in Helm, at least for now?

It doesn't belong in a module called "Helm" long term unless it depends on Helm (which I don't think it does). We could keep it in the helm module short-term I guess if we needed to - but I don't think it should be too much work to move this elsewhere? I'm not really sure on that though.

It was continued in https://github.com/cert-manager/makefile-modules/pull/214.


Text labels error and helper text

Recommend this issue is not started until we have completed text inputs, drop downs, radio buttons and checkboxes so that layout across all components can be verified
As a: Full stack developer
I want: Use the Text labels, error, and helper text with UI components from the UI library (text inputs, drop-down menus, radio button and checkbox groups)
so that: So that I can create text inputs and drop-down menus that are compliant with the design system documentation
Acceptance criteria

[x] Create web component
[x] Create React wrapper
[x] Passing unit tests
[x] Linting
[x] update storybook
[x] Push to Alpha
[x] label text, error, and helper text must have equal spacing between elements for text inputs, and drop down menus
[ ] Manual design review

Presentable outcomes

[x] I can show the ui-component in storybook and provide the link to service teams so that they can view the component for themselves

Sprint Ready Checklist

Acceptance criteria defined
Team has defined steps to satisfy acceptance criteria
Acceptance criteria is verifiable / testable
External / 3rd Party dependencies identified

Related issues:
GitHub issue: Blocked by #355
Resources:
Mockups: Checkbox design
Testing URL: [If applicable a URL to the testing branch]
Design review 1:

[x] Helper text not showing on for Storybook example

[x] Example with helper and error text both showing to verify spacing and ordering

[x] Use font variables for label elements where possible (e.g. --fw-bold, --goa-color-text) for label

[x] Ensure that label wraps and pushed input down as necessary for smaller viewports

Great job @chrisolsen There are a few items to look at, let me know if you have any questions.
Thanks!

As per discussion with @chrisolsen  the character counter will be removed from the scope of this story

Hey @chrisolsen just a couple of small text variables updates, let me know if you like to chat about their usage I've noticed this issue arise a few different components, I'd be happy to go over it if you'd like.

:tada: This issue has been resolved in version 3.4.0-alpha.44 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.0.0-alpha.39 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.0.0-alpha.6 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.0.0-alpha.6 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Reporting complete log for training

Greetings,
I have been training a small dataset (60 samples w/ annotated BBs) using ResNet-50 as backbone and Cascade-RCNN as architecture. The training runs somewhat smoothly, but I can only see the validation results in the terminal, and when opening the log files, the same.
I am starting the training wit the following:
./dist_train.sh /dir_for_my_config/cfg.py 1 --validate (only 1 GPU)
After each epoch, I get validation results like:
+-------+-----+------+--------+-----------+-------+ | class | gts | dets | recall | precision | ap    | +-------+-----+------+--------+-----------+-------+ | 1     | 8   | 0    | 0.000  | 0.000     | 0.000 | +-------+-----+------+--------+-----------+-------+ | mAP   |     |      |        |           | 0.000 | +-------+-----+------+--------+-----------+-------+ 2019-04-11 11:12:22,729 - INFO - Epoch [6][29/29]       lr: 0.01410, mAP: 0.0000
The log files look like this:
2019-04-09 11:40:54,937 - INFO - Start running, host: tunai@tunai-ubuntu2, work_dir: /dir 2019-04-09 11:40:54,937 - INFO - workflow: [('train', 1)], max: 12 epochs 2019-04-09 11:41:55,108 - INFO - Epoch [1][29/29]	lr: 0.00927, mAP: 0.0000 2019-04-09 11:42:57,244 - INFO - Epoch [2][29/29]	lr: 0.01023, mAP: 0.0000 2019-04-09 11:43:57,422 - INFO - Epoch [3][29/29]	lr: 0.01120, mAP: 0.0000 2019-04-09 11:44:56,876 - INFO - Epoch [4][29/29]	lr: 0.01217, mAP: 0.0000
I am also printing region proposals, ground-truth BBs, etc. However, I am having a hard time calculating the loss and accuracy of the training set. And I have seen the logs of other projects in this forum, and these numbers are reported there. What am I missing? Are there any additional parameters in the dist_train.sh call?
Thank you.

The log_interval is 50 by default, so the training log will be printed every 50 iterations. You need to change the interval.

Thank you hellock! That solved the problem.


elastic-agent support does not reference the SIEM IP

Ansible elastic-agent support does not reference the SIEM IP input instead only reference the default IP. (<IP_ADDRESS>)

Fixed in e6a7d66


Use Nix for CI

Following from https://github.com/http4s/http4s/pull/6724#issuecomment-1264555194.

Ok @rossabaker wdyt? This actually seems quite straightforward. Still need to fix a couple minor things, and can we set up caching?
https://github.com/typelevel/typelevel-nix/blob/8448aab702b9e3370b42920dcf223bff810c0275/.github/workflows/cache.yml#L23-L27

Oh wait, now our JDK 11 and JDK 17 jobs are using the JDK 8 from Nix 🤔

Crap, did I do it wrong?
cachix: FailureResponse (Request {requestPath = (BaseUrl {baseUrlScheme = Https, baseUrlHost = "cachix.org", baseUrlPort = 443, baseUrlPath = ""},"/api/v1/cache/http4s/0cjxar99k7dscyvqwxjapv1jvq8ri1bm.narinfo"), requestQueryString = fromList [], requestBody = Just ((),application/json;charset=utf-8), requestAccept = fromList [], requestHeaders = fromList [("Authorization","<REDACTED>")], requestHttpVersion = HTTP/1.1, requestMethod = "POST"}) (Response {responseStatusCode = Status {statusCode = 401, statusMessage = "Unauthorized"}, responseHeaders = fromList [("Date","Mon, 03 Oct 2022 04:03:51 GMT"),("Transfer-Encoding","chunked"),("Connection","keep-alive"),("Cache-Control","no-cache"),("CF-Cache-Status","DYNAMIC"),("Report-To","{\"endpoints\":[{\"url\":\"https:\\/\\/a.nel.cloudflare.com\\/report\\/v3?s=KejzhQhCCuoXPdJ2bgZAvO%2BTf%2FAOK25BesbyTJ6HToYt%2FR%2FvcZveSZvAJxWUhINYeGCa19HSHAQ91oQC1ohKKpF3yv%2BCzvpMjevLiKLrD5UiyrgFlCY1VeyDm9M%3D\"}],\"group\":\"cf-nel\",\"max_age\":604800}"),("NEL","{\"success_fraction\":0,\"report_to\":\"cf-nel\",\"max_age\":604800}"),("Server","cloudflare"),("CF-RAY","7542ca57dd6d82b1-IAD")], responseHttpVersion = HTTP/1.1, responseBody = "Binary cache http4s doesn't exist or you're not authorized to access. Please check the name for typos and/or provide an auth token. Contact support on https://cachix.org/ if you're stuck!"})

I recreated the token and it worked this time.


TILA-127 | OpenAPI documentation

Looks like there is a merge conflict, but other than that looks good to me.

Looks like there is a merge conflict, but other than that looks good to me.


Update BeginnerTutorial.md

Later in the tutorial, we tell the user how to make tests for incrementAsync but we do not export the function in sagas.js, so users have to go back and add export after seeing errors in console.

Thanks!


Add more fields to the dispatcher service output

submission/comment content
upvotes / downvotes
author
other?

Docs:

Submissions
Comments


[Docs]: Workflows in Appsmith

Is there an existing issue for this?

[X] I have searched the existing issues

Engineering Ticket Link
No response
Release Date
No response
Release Number
No response
First Draft
No response
Loom video
No response
Discord/slack/intercom Link if needed
No response
PRD
No response
Test plan/cases
No response
Use cases or user requests
A Concept doc

We will come back to the concept doc later.


[TAP-5174] Webspoon integration into Pentaho base code

:x: Build failed in 26m
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:ok_hand: All tests passed!
Tests run: 3876, Failures: 0, Skipped: 6    Test Results

Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message


Feature request: paste source name and URL

As a quality of life enhancement, option of pasting the URL itself and possibly the page name in the note would be a neat addition.
This way you could easily search and organize notes by the source in the future.
Thank you for your contribution to open source! Your project greatly improved mobile experience of my Joplin note taking.

Hi @graphit0 ,
I'm glad this is useful to you!
And thanks for this feature request, it would be a great addition indeed!
How do you imagine this can be added? Two simple checkboxes in the main screen (to easily toggle them on a per page basis) or a global configuration in a separate view?
Also, how should they be inserted in the markdown? I'm inclined to use the yaml front matter to store these kind of thing, for example:
---
title: my web page
source: https://example.com/page.html
---

[Page markdown]

This works well with dendron (my current note taking app), but I can see that joplin doesn’t play nice with it.
Could you give me an example of how you normally/manually insert these info?

Thank you for the lightning fast response,

Also, how should they be inserted in the markdown? I'm inclined to use the yaml front matter to store these kind of thing

I'm absolutely in love with yaml front matter but unfortunately, in my experience it faces user friendliness problems. Non-tech people don't understand it and often get confused. Moreover providing editable and a tad fragile tags to user may result in bad experience due to user error.
Just now I tried inputting front matter tags to GitJournal (who claims to support it) via share intent, it created a duplicate dashblock (--- tag:X ---) and the editor refused to recognise its content. Only after editing manually, the editor accepted the provided/shared tags. This experience is especially undesirable on mobile with screen keyboard. However it pains me, this is the state of front matter adoption right now: those bold few apps who support it may suffer from bad user experience 😮💨
Btw, Joplin does support (i.e. can read) front matter but its editor doesn't do much with it. As many other note taking apps, unless instructed otherwise, Joplin fails to ignore it and tries to shove front matter tags into a title.

How do you imagine this can be added? Two simple checkboxes in the main screen (to easily toggle them on a per page basis) or a global configuration in a separate view?

At the current stage the app doesn't have/need settings but maybe someday it might. That would probably entail a separate settings screen. But for now, to avoid overcomplication, I think better to start with a simple UI element.
My take on this element
kebab menu dropdown at the top right with a checkbox "Include link 🔗". Its state should be kept persistently (not being reset after each restart)

In terms of webpage title, I believe it should be included by default hence doesn't need the checkbox. But I'm not adamant about this.
Both of those checkboxes insert generic, markdown formatted, text lines
# Title My Web Page
[blank line] // to force markdown standard to register next text line as a separate one
Clipped from: https://example.com/page.html

Front matterize
Although it is out of scope of this FR, to achieve some sort of compromise about front matter, I think a second checkbox could be added: "Front matterize". This feature would replace title, url and input any other tag (in case you'd like to track them) into front matter format: such as location, device name, etc.
Sorry for weird naming, I don't know how to put "front matter" into verb form and manage to cram it into a single line.

Thank you for the great explanation!
I totally agree with everything.
Front matter can wait, but the option you envision looks good.
I can't promise any ETA/quick resolution for this since I'm moving to a new home...
Obviously PRs are very welcome!

Thank you so much for this!
It works great and significantly improved visibility of my clipped content. I'll eagerly recommend your project to markdown note taking community.


Improve apply output

What this PR does / why we need it:
Improve apply output
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #531
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

/retest


Move to only self-hosted, versioned use of apps UI for all devhub

#478  and #477 are related
We should insist that users self host the dev tool that the apps UI is at a specific latest version  tag, and heavily suggest the hosted version is not appropriate for use for devs typically.

In closing, the version branch of the docs should include this content (maybe) https://github.com/substrate-developer-hub/substrate-docs/pull/591


Math & Client side stuff

stolen from yarn ™ and legacy rewoven yarn ™

slightly brings up the stats

 How did we let this in lmao
Ok epic approv time to last call this

blurted

my pull request titles shall not be anglicized


Error Handling

Currently if an operation fails because of a database constraint or what ever, I can't handle them gracefully

async add(op: Operation): Promise<any> {
    const { password, ...user } = op.data.attributes;

    if (!password) {
      throw {
        // At the very least, you must declare a status and a code.
        status: HttpStatusCode.BadRequest,
        title: "A password must be entered.",
        code: "no_password"
      } as JsonApiError;
    }

    user.salt = uuid()
    user.hashedPassword = hash(password, user.salt);

    op.data.attributes = user;
    try {
      return super.add({ ...op, params: {} });
    } catch (e) {
      throw {
        status: HttpStatusCode.BadRequest,
        title: "the email already exists",
        code: "duplicated_user"
      } as JsonApiError;
    }
  }

This is what I would like/expect, but I don't know if its the best approach.

I actually got it working, I just had to await for the super there.
 try {
      return await super.add({ ...op, params: {} });
    } catch (e) {
      throw {
        status: HttpStatusCode.BadRequest,
        title: e.detail,
        code: e.constraint
      } as JsonApiError;
    }


chore(prettier): use dedicated config

Summary

This will make sure that if you use "format document" via vscode prettier extension works as expected
Result

arguments to prettier config are moved to their own file

was causing other conflicts, let's leave as is


Changed the default ppi from 128 to 200.

Fixes part of #362 .
Changed the default DPI resolution to 200 as suggested in the issue.

I have merged it. Thanks.


Add Pull Request Counter plugin of Renuo

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Not sure if I understand this correctly, but I'm neither the maintainer nor creator not a contractor nor an employee of the project, but I would have the rights to maintain it because I work in the same company as the creator.

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Almost everyone at Renuo uses this pull request counter plugin in daily work. It may be useful to others.

Hi, thanks for the contribution! We'd prefer to hold off on adding up-and-coming projects, until they are more widely adopted within the developer community.


Field level acl

check field acl aces
fix oro voter bug (no field information passed to symfony's voter)

1.8 branch (this PR) has been updated with fixes made on main PR (to master)


Cluster alert are not visible to cluster member and project alert are not visible to project member

Cluster alert are not visible to cluster member
Project alert are not visible to project owner/member

Which team is validating alert changes? I dont know, so assigning to both logan and sangeetha

Tested with master build from Dec 7th. Created cluster and enabled monitoring using Prometheus.
Cluster level and Project level alerts were configured.
Verified that cluster members can see both cluster level and project level alerts.
Verified that project members can see only project level alerts.


CSP Spot Check #2 (Feb 6)

Jupyter notebook or web page that shows signup and login, focus on login

[ ]  Show HTML and JavaScript to support Login/Signup in VSCode …
[ ]  Show HTML that supports Login/Signup
[ ]  Show Style that supports Login/Signup formatting
[ ]  Show JavaScript code that performs Fetch
[ ]  In Browser/Jupyter demo …
[ ]  Demo Login success
[ ]  Demo Login failure
[ ] Jupyter notebook or web page that shows redirect or 403 error as a result of signup and login page, focus on redirect to data/table display or failure

[ ]  Show HTML and JavaScript to support Login/Signup failure VSCode …
[ ]  Show JavaScript that performs Fetch
[ ]  Show code that redirects to page on success
[ ]  Show code that shows implementation of roles
[ ]  Show code that captures error handling on 403
[ ]  In Browser/Jupyter demo …
[ ]  Demo Login success redirecting to table/data page
[ ]  Show in split screen, login success with cookie on redirected page
[ ]  Demo Login success to a page that requires an advanced role
[ ]  Demo Login failure related to insufficient role
[ ] Jupyter notebook that shows CRUD operation on the page that requires authentication, or this can include signup without authentication


ATBD & Reference Titles Should allow LaTeX formatting

Description
Based on feedback from a user on October 10, 2022.
Titles of scientific papers often have superscript, subscript and other unique characters. Right now, this is a plain text field. For both the ATBD title and the reference title, users need the ability to enter super- and sub-scripts so that scientific paper titles are accurately presented in the reference section.
Tasks

[ ] Create a unicode cheat sheet (commonly used characters) that will be added to APT (just like the LaTeX cheat sheet) (Brad)

Acceptance Criteria

[ ] Unicode cheatsheet submitted to DevSeed for integration into APT

This is a needed feature and will be scheduled as a must-have in PI23.2

An example title needing to be added to the reference section is "Fourier Transform Ultraviolet Spectroscopy of the A2Π3/2 ← X2Π3/2 Transition of BrO"  This indicates that more than just super and subscripts are needed.  Unique characters are also needed.

We did some testing/review (thanks @oliverroick). Greek characters (Π, µ, ∑, etc.), as well as all unicode characters work.
There are unicode superscript and subscript characters (e.g., ², ₂ and others here). The issue seems to be from rich text characters, which is probably coming from copying and pasting from word processors.
The immediate solution is to have users only use unicode characters, which can achieve the goal of having super- and sub-script.
The long term feature, to increase usability, would be to allow for rich text in the title.
cc: @deborahUAH @bwbaker1

For future consideration, this would be a time consuming feature to implement., which would require:

db field update statements
db migrations for existing docs
data model update
switch form component on frontend
switch render component on frontend
PDF equivalent

As this is the title field, it can get way more complicated. The title is used in several places (modals, confirmation prompts, emails even), and it will no longer be a simple string. Operations that are trivial on strings, become more complicated on rich fields.
If deemed necessary, we can devise ways around these things, like removing the rich features when rendering in some cases (like the superscript in an email for example), but all these cases have to be found and accounted for.

@wrynearson @bwbaker1
Just to clarify:   So a user needing to enter the reference title above can do so with unicode characters and since the needed changes would require too much effort and time (which we don't have), the better solution is to explain this in the user guide and have a demo of how to ingest a complicated title?
So long as there is a feasible workaround so that no reference needs to be left out due to the tool's inability to incorporate it, I am fine.

@wrynearson @deborahUAH After some brief testing, I think the unicode work around is fine.  Like Deborah mentioned, we just need to make sure it is included in the user guide and maybe we can consider something similar like the LaTeX cheatsheet (see below) but with common Greek/unicode characters. Just a thought.

Correct @deborahUAH, and good idea @bwbaker1. For Unicode text entry, users can search for their symbol on Google, Wikipedia, etc. and then copy the result.

@batpad flagging this issue because it could either be very complex, or a simpler user-driven workaround.

@batpad @frozenhelium @kamicut thoughts on this ticket?

@wrynearson Anthony suggested we complete this ticket sooner than later because it could complicate things once we have existing public ATBDs.
I'm still okay with copy/paste unicode characters, but we need to inform users somehow of this capability.

@sunu @frozenhelium @kamicut @batpad @thenav56 any additional thoughts on how we can implement additional characters / rich text in titles? It'd be nice to scope this out and come up with a good solution.

@wrynearson If we go the LaTeX route described in https://github.com/NASA-IMPACT/nasa-apt/issues/586#issuecomment-1481090827, we will only require frontend changes to render the proposed syntax.

Update – the initial infrastructure is in place (see https://github.com/NASA-IMPACT/nasa-apt-frontend/pull/533). We'll keep the PR open while @frozenhelium adds:

Information for the users
A live preview of the title field, so users can see if the $\LaTeX$ they've entered is correct.

@bwbaker1 this is ready for your review. Please see https://github.com/NASA-IMPACT/nasa-apt-frontend/pull/533 for some screenshots and context.

@wrynearson This looks good to me.


Change the listed Helm version

Because in fact version 3 is installed
https://github.com/actions/virtual-environments/blob/0c2643cb8d11706a08c366b3929e34f34b95197f/images/linux/scripts/installers/1604/kubernetes-tools.sh#L20

Hello, @cannibal-kush
Please don't update auto-generated documentation. It will be fixed soon in - https://github.com/actions/virtual-environments/releases/tag/ubuntu16%2F20200308.0

This is an issue as i have helm 3 installed on my build agent but the documentation leads me to believe it is version 2. I suggest you look at that process

@cannibal-kush , Usually, deployment takes 3-4 days (during this period your build can use updated or non-updated machines) and we update docs only when the all machines use new version of image.

@maxim-lobanov  Helm 3 introduced breaking changes.  If agents take 3-4 days to be updated how do I ensure that my builds will work correctly during the interim since helm2 vs helm3 require some changes to the scripts?
eg:
helm2 requires helm init --client-only to work, but this command fails with helm3
helm3 requires /home/<USER>/.config/helm to exist
There are other breaking changes but these are just two examples.


PlatformException(Permission_NOT_GRANTED,null,null,null) on background isolate

I have sorted out this issue in main isolate using request_permission package to request read_phone_permission and its working fine in main_isoloate.

I have sorted out this issue in main isolate using request_permission package to request read_phone_permission and its working fine in main_isoloate.

I am also facing this issue, have you come up with any solution ?


Generate client file with webpack

Ideally, hippy should be able to create a base client template to accompany any application with ReactJS.
Therefore, I will create a command like hippy init which will generate a baseline ReactJS client folder to use within any type of application with a webpack + instructions.

TODO: hippy init -s for isomorphic reactjs


Sample new embedding from maximum likelihood estimate

This PR improves over the status quo of producing random embeddings for unknown tokens by learning a normal distribution over the provided embeddings.

The sonar error is due to the fact that i had to fix some flake8 errors across the code base. Should be ignored


Password reset with mailgun not working

I'm trying to get the parse-server password reset functionality working, but no success so far. This is my setup:
var api = new ParseServer({
  databaseURI: process.env.DATABASE_URI || process.env.MONGOLAB_IVORY_URI,
  cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
  appId: process.env.APP_ID || 'APP_NAME',
  clientKey: process.env.CLIENT_KEY || 'xxxx',
  masterKey: process.env.MASTER_KEY || '',
  serverURL: process.env.SERVER_URL || 'https://APP.herokuapp.com/parse',
  appName : 'APP_NAME',
  verifyUserEmails: true,
  publicServerURL: 'https://APP.herokuapp.com/parse',
  emailAdapter: {
    module: 'parse-server-simple-mailgun-adapter',
    options: {
      fromAddress: 'From Name<EMAIL_ADDRESS>      domain: 'https://api.mailgun.net/v3/***MY_DOMAIN***/messages',
      apiKey: 'key-xxxxxxxxxx',
    }
  }
});

The iOS Parse SDK simply says the email is succesfully sent, but nothing arrives. Also the Mailgun logs show no sign of activity. I have tested this Mailgun setup with curl and that worked just fine.
I tried both https://api.mailgun.net/v3/MY_DOMAIN/messages and https://api.mailgun.net/v3/MY_DOMAIN
Any clue what's wrong with my setup?
Or how I can troubleshoot this remotely running Parse setup?

Ok I managed to solve it after hours of digging.
As it turns out the parse-simple-mailgun-adapter does not handle invalid Mailgun URLs.
Instead of providing https://api.mailgun.net/v3/MY_DOMAIN, I should have provided just MY_DOMAIN. Appearantly the adapter will construct the url.


[Bug]: Custom FluentBit Configuration input required even when not enable

Error Message and Logs

as you can see i use axiom but i still need to make Custom FluentBitConfiguration not empty event if i have not enabled it
if not i can't save
Steps to Reproduce

Example Repository URL
No response
Coolify Version
v4.0.0-beta.360
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
No response
Additional Information
No response

This issue should be resolved in the latest version. If you're still experiencing this issue, please reopen or create a new issue with updated details.


[Feature] Build in localhost (optional) hope to add the ability to turn off the flashAttention function

Motivation
FlashAttention-2 currently supports:
Ampere, Ada, or Hopper GPUs (e.g., A100, RTX 3090, RTX 4090, H100). Support for Turing GPUs (T4, RTX 2080) is coming soon, please use FlashAttention 1.x for Turing GPUs for now.
Datatype fp16 and bf16 (bf16 requires Ampere, Ada, or Hopper GPUs).
All head dimensions up to 256. Head dim > 192 backward requires A100/A800 or H100/H800.
Related resources
No response
Additional context
No response

What if you want to disable flash attention, just set use_context_fmha=0 in <model_dir>/triton_models/weights/config.ini.

@grimoire It seems that flashattention2 cannot be compiled successfully under cuda12+ platform

@lvhan028  https://github.com/InternLM/lmdeploy/pull/754


Animated sprite states on clothing don't work when first equipped.

To replicate load into the game and spawn the "Cosmos Bedsheet". You'll see it's an animated sprite when you spawn it, but when you put it on your back or around your neck you'll see it isn't animated. Take it off and put it back on and you'll see the sprite is now animated. Do this with any animated clothing piece and you'll see the same behavior.
Tested on local and on the public server. The animated sprites will only work if you wear an animated one, take it off and put it back on. All animated sprites after that will work.

(I know I recorded this with my neck slot pr but it's the same for all slots.)

Another example of the same bug.
https://user-images.githubusercontent.com/49448379/107127060-79f92700-68ab-11eb-95c9-35c0286bfe2f.mp4

Ye I kinda want to deal with this one. I thought it was fixed when dealing with cigarettes.


[VMware] Make disk controller selection on volume attachment consistent with VM creation and start

Description
When both rootDiskController and dataDiskController details are set to SCSI controllers, the VM creation and start processes prioritize creating and using the controllers specified by rootDiskController for all volumes. However, the volume attachment process does not consider this and always tries to attach volumes using the controllers specified for the data disks (even if a root disk is being attached).
This way, in a scenario where rootDiskController is set to pvscsi and dataDiskController is set to lsilogic (one example, as this problem also happens for other combinations) we ignore the dataDiskController setting defined by the operator and choose to use only PVSCSI controllers for both the root and data disks on VM creation/start. Then, when a user tries to attach a new data disk, we only consider dataDiskController and try to attach with LSI Logic instead. However, the process fails, as there are no LSI Logic controllers because we ignored the data disk controller chosen by the operator and opted to create PVSCSI controllers for both root and data disks when creating/starting the VM. Also, if we detach the root disk and try to attach it again, the process also fails because CloudStack tries to attach it using the controller specified for the data disks.
To solve this issue, this PR makes the volume attachment disk controller selection logic consistent with VM creation/start. Tests will be added in another PR alongside an extension for the disk controllers that I'm currently working on, as it will require me to modify this code again.
Fixes #9400
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[X] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[X] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
For each of the following rootDiskController/dataDiskController combinations:

I deployed a VM that had 1 root disk and 1 data disk, and verified which disk controllers were being used for them;
I attached a data disk, and verified which disk controller was used;
I detached the root disk and attached it again, and verified which disk controller was used.

Below are my results.

Configuration
Initial root disk
Initial data disk
(re)Attached root disk
Attached data disk

pvscsi/osdefault
PVSCSI
PVSCSI
PVSCSI
PVSCSI

osdefault/pvscsi
PVSCSI
PVSCSI
PVSCSI
PVSCSI

osdefault/osdefault
LSI Logic
LSI Logic
LSI Logic
LSI Logic

lsilogic/pvscsi
LSI Logic
LSI Logic
LSI Logic
LSI Logic

pvscsi/lsilogic
PVSCSI
PVSCSI
PVSCSI
PVSCSI

ide/ide
IDE
IDE
IDE
IDE

ide/pvscsi
IDE
PVSCSI
IDE, but see [1]
PVSCSI

lsilogic/lsilogic
LSI Logic
LSI Logic
LSI Logic
LSI Logic

[1] CloudStack tried to attach using an IDE controller. However, an exception happened because it ignored the CDRom when calculating the next available unit number, and tried to attach the disk on an unit number that was already being used. I will fix this issue separately in another PR.

@blueorangutan package

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10968

@blueorangutan test ol8 vmware-70u3

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[SF] Trillian test result (tid-11353)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51739 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9636-t11353-vmware-70u3.zip
Smoke tests completed. 125 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_events_resource
Error
131.67
test_events_resource.py

test_attach_and_distribute_multiple_volumes
Error
21.19
test_attach_multiple_volumes.py

test_attach_multiple_volumes
Failure
8.87
test_attach_multiple_volumes.py

test_01_vm_with_thin_disk_offering
Error
127.60
test_disk_provisioning_types.py

test_02_vm_with_fat_disk_offering
Error
194.53
test_disk_provisioning_types.py

test_03_vm_with_sparse_disk_offering
Error
134.86
test_disk_provisioning_types.py

ContextSuite context=TestListVolumes>:setup
Error
0.00
test_list_volumes.py

test_01_deploy_vms_storage_tags
Error
11.17
test_primary_storage.py

test_01_volume_usage
Error
88.39
test_usage.py

test_02_offline_migrate_VM_with_two_data_disks
Error
54.90
test_vm_life_cycle.py

test_03_live_migrate_VM_with_two_data_disks
Error
58.85
test_vm_life_cycle.py

test_04_migrate_detached_volume
Error
54.66
test_vm_life_cycle.py

test_11_destroy_vm_and_volumes
Error
47.22
test_vm_life_cycle.py

test_12_start_vm_multiple_volumes_allocated
Error
80.16
test_vm_life_cycle.py

test_12_start_vm_multiple_volumes_allocated
Error
80.17
test_vm_life_cycle.py

test_01_create_volume
Error
4.47
test_volumes.py

test_10_list_volumes
Failure
371.35
test_volumes.py

test_13_migrate_volume_and_change_offering
Error
18.85
test_volumes.py

ContextSuite context=TestVolumes>:teardown
Error
28.28
test_volumes.py

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 11031

@blueorangutan test ol8 vmware-70u3

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[SF] Trillian test result (tid-11410)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 94986 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9636-t11410-vmware-70u3.zip
Smoke tests completed. 121 look OK, 12 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_events_resource
Error
138.67
test_events_resource.py

test_attach_and_distribute_multiple_volumes
Error
22.31
test_attach_multiple_volumes.py

test_attach_multiple_volumes
Failure
16.01
test_attach_multiple_volumes.py

test_01_vm_with_thin_disk_offering
Error
138.96
test_disk_provisioning_types.py

test_02_vm_with_fat_disk_offering
Error
157.73
test_disk_provisioning_types.py

test_03_vm_with_sparse_disk_offering
Error
140.81
test_disk_provisioning_types.py

ContextSuite context=TestListVolumes>:setup
Error
0.00
test_list_volumes.py

test_list_vms_metrics_admin
Error
3622.91
test_metrics_api.py

test_list_vms_metrics_history
Error
7.74
test_metrics_api.py

test_list_volumes_metrics_history
Error
3615.50
test_metrics_api.py

test_01_deploy_vms_storage_tags
Error
9.12
test_primary_storage.py

test_01_restore_vm
Error
3614.75
test_restore_vm.py

test_02_restore_vm_allocated_root
Error
20.20
test_restore_vm.py

ContextSuite context=TestRestoreVM>:teardown
Error
32.71
test_restore_vm.py

ContextSuite context=TestVMWareStoragePolicies>:setup
Error
0.00
test_storage_policy.py

test_01_volume_usage
Error
88.20
test_usage.py

test_01_deploy_vm_on_specific_host
Error
17.77
test_vm_deployment_planner.py

test_02_deploy_vm_on_specific_cluster
Error
3602.91
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
1.34
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
2.38
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
2.37
test_vm_deployment_planner.py

test_01_offline_migrate_VM_and_root_volume
Error
5921.32
test_vm_life_cycle.py

test_02_offline_migrate_VM_with_two_data_disks
Error
62.46
test_vm_life_cycle.py

test_03_live_migrate_VM_with_two_data_disks
Error
51.60
test_vm_life_cycle.py

test_04_migrate_detached_volume
Error
53.48
test_vm_life_cycle.py

test_11_destroy_vm_and_volumes
Error
46.96
test_vm_life_cycle.py

test_12_start_vm_multiple_volumes_allocated
Error
83.21
test_vm_life_cycle.py

test_12_start_vm_multiple_volumes_allocated
Error
83.22
test_vm_life_cycle.py

test_01_create_volume
Error
5.43
test_volumes.py

test_10_list_volumes
Failure
371.35
test_volumes.py

@blueorangutan package

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 11061

@blueorangutan test ol8 vmware-70u3

[SF] Trillian test result (tid-11440)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9636-t11440-vmware-70u3.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@winterhazel maybe some test code could be added? integration or unit. @JoaoJandre at your descretion.

Some unit testing would be nice. @winterhazel

Hey @DaanHoogland @JoaoJandre
As I stated in the description, I am planning to add tests in another PR alongside an extension for the disk controllers that I'm working on, as it will require me to make changes to both this code and to the tests again. However, if you guys prefer it, I can try adding them here already next week.

Hey @DaanHoogland @JoaoJandre
As I stated in the description, I am planning to add tests in another PR alongside an extension for the disk controllers that I'm working on, as it will require me to make changes to both this code and to the tests again. However, if you guys prefer it, I can try adding them here already next week.

Sorry @winterhazel, I totally missed that part of the description.


PNG support

Things seem to work! I've manually tested by loading from a few formats and pixel formats (rgb, rgba, indexed, grayscale) and things go well.
I've written a lot of things by taking advantage of writers and kinda made a lot of files too. I guess some could be grouped.
I've not written tests, should I do it in this PR? It might take some time though.
Things I will but haven't implemented yet and probably will do it in an other PR:
Writing when the bits per sample is less than 8 (grayscale or indexed 1, 2, 4) (though that isn't done for the reader either)
Interlacing
Things to think about: The IDAT chunks are written in a buffered-writer style, buffering the data until a certain point and flushing one big IDAT chunk at a time. Does that make sense? I've put the buffer size to 16K which seems common in png files (some use 8K, some 32K also)
Changes to other files: added a "bit per channel" in the PixelFormat

You did very nice work especially considering there is no zlib compressor in std lib. I am wondering if you can use std lib adler and crc implementations though and simplify the code by using them inline of other writers instead of implementing them as separate writers.
I was also thinking about a similar idea I used in reader where you can use it directly and specify custom chunk parsers. It would be nice if writer would also support custom chunk writers. For example writing tRNS chunk for non indexed images could maybe be implemented as custom chunk writer and any other type of chunk could be added using these custom chunk writers.
As for writing only a limited set of palette entries one solution, although potentially expensive, would be to iterate through all the indices and find the max one (with early break out if max possible is encountered).

Thanks!
Indeed, i didnt check if std had crc and adler ^^ i will try to change that tomorrow
as for zlib thankfully its an easy format when i alreay have a deflate compressor !

Oh I forgot, yes you need to write tests for the writing but it can go in another PR

Ok for all the variable names!

You did very nice work especially considering there is no zlib compressor in std lib. I am wondering if you can use std lib adler and crc implementations though and simplify the code by using them inline of other writers instead of implementing them as separate writers.

I did that now, thanks for telling me :)

Hey @mlarouche , I think that's all for this PR. I will only make #88 and #90 in an other one, as well as interlacing, and formats of less than 8 bits per channel, but for now I need a small pause ^^
Could you tell me if everything is alright? I tried to do what you said about the png interface

I think we should consider not supporting interlacing in png writer since it is kind of obsolete with today's internet speeds.

I think we should consider not supporting interlacing in png writer since it is kind of obsolete with today's internet speeds.

I think we should implement it but not be a priority, just to be 100% compliant with the spec

Actually this is not ready for merging, there is a bug that is new probably due to a recent commit which causes the image to be a little bit incorrect and not load in some viewers. Will fix that asap

Hey i'm not forgetting this nor giving up, I just had a busy week end ^^ will investigate the problem now

Soooo, i'm really confused about this.
The error my image viewer says is "not enough compressed data"
This only happens with the Average and Paeth filters, changeable in the EncoderOptions (so in consequence, when using the heuristic filter choice too)
This is very confusing because as my last commit shows, whatever the filter used, the same number of bytes is sent to the compressor, and as I understand in the png specification filters output 1 byte per 1 input bytes so expect amount should be the same for each filter
I fear a miscompilation or a bug in the deflate compressor.
Could one of you maybe try to help me? I could provide you with my test program and image as well, as I don't know if it does this with all images

Hey! Bad news.. This is seemingly a bug in the std deflate compressor, so I can't really progress on this rn
Link to this issue:
https://github.com/ziglang/zig/issues/13144

Thanks for submitting the issue for the standard library. If you feel adventurous, you could submit the fix directly to Zig stdlib ;)

Thanks for submitting the issue for the standard library. If you feel adventurous, you could submit the fix directly to Zig stdlib ;)

I thought of it haha, im a bit burned out from other stuff rn... If its not done in a week i'll consider doing in ^^ in the meanwhile i'll just finish what i wanted to finish in this PR for it to be pulled when the bug is fixed (or before, depending on how you see it, as it works on most png images but doesn't on some because of soemthing that is not up to zigimg)

@mlarouche I think it's ready now ^^

Ok , doing it now!

Done ^^

Merci beaucoup @Guigui220D pour ta contribution et ton temps :)

:)))


Unable to load the assets

It appears that the project requires specific UE version, since both binary 4.27.2 nor 4.27.1 Oculus Fork seems to NOT load the assets. Asset files are visible with windows explorer and are there, this happens when you try to open a project that's been build with higher version of the engine, with lower version (you could however open the files build with lower ver with higher ver of the engine). Please advise as to which engine version this should work with. Plugin seems to load and compile fine, so no idea what's causing map and all other blueprints not to load with the project.

So, went through the most recent commit to README file and found out Issue#2 discussion about the very same topic. Seems like the only way to get the project to run is to clone the repo with LFS enabled, otherwise (downloading the zip) you end up without any assets visible in the project, might also be worth noting in the README that you cannot download as .zip.


added generators (integer, double, char)

Image generation is also ready (you need the first version of the project to add)

@Kuznetsov-Artyom please update branch


xSQLServer: Test integ problem

Pull Request (PR) description
This is a test for splitting the unit test and integration tests on different build workers. I want to verify that this is not an Enterprise functionality before I look into this further.
Closing this PR when the test run is done.
This Pull Request (PR) fixes the following issues:
n/a
Task list:

[ ] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #776 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #776    +/-   ##
====================================
+ Coverage    97%    97%   +<1%
====================================
  Files        30     30
  Lines      3250   3251     +1
====================================
+ Hits       3165   3166     +1
  Misses       85     85