More accurate timestamps on risk card (EXPOSUREAPP-1991)

Via #1473 we now have better infos about when the ENF calculation is finished. Let's display that timestamp instead of when we finished downloading the key pkgs (because download+provision is asynchronous from calculation).
This would fix #948 where the timestamp between the riskcard and the ENF log is off by 1-2 minutes due us using the download timestamp.
For now if there is not yet a timestamp available via CalculationTracker we'll fallback to the download timestamp otherwise everyone would see the wrong info after upgrading. We can remove that fallback in a few weeks after almost everyone has upgraded and CalculationTracker has a high chance of holding data to display.
How to test

Trigger a view key pkg submissions and compare the timestamp on the risk card with the timestamps from the ENF log.

Hint for testing: Change the landscape to WRU-XD, it looks like that there aren't packages on INT.

For now if there is not yet a timestamp available via CalculationTracker we'll fallback to the download timestamp otherwise everyone would see the wrong info after upgrading. We can remove that fallback in a few weeks after almost everyone has upgraded and CalculationTracker has a high chance of holding data to display.

Wouldn't we need the fallback also later for new/first time installations?

Wouldn't we need the fallback also later for new/first time installations? Or after a data reset?

At that point the user wouldn't expect a time stamp though, so displaying the text for "no value being available" is okay.
I think it's wouldn't even come to that, as it would display the grey card  for "not enough data" which doesn't show a timestamp. Right? :thinking:

Marked as draft as it turns out that the timestamp from Google does not fit the expected pattern. Going to clarify with Google what their timestamp actually represents, from Luka's tests, it's not just rounding up/down either.

At that point the user wouldn't expect a time stamp though, so displaying the text for "no value being available" is okay.
I think it's wouldn't even come to that, as it would display the grey card for "not enough data" which doesn't show a timestamp. Right? :thinking:

I agree, if the risk card refresh is triggered by receiving the two 'exposure check fnished' broadcasts from ENF only ('unknown risk'  until the first exposure check result is retrieved), not by closing ProvideDiagnosisKeysTransaction anymore... In my age, the brain needs more effort to re-connect changed flows consistently ;)

from Luka's tests, it's not just rounding up/down either.

@harambasicluka
Hi Luka, if you find some time, could you help me understand your tests:
Table: UI is CWA and Settings is ENF?
Log: the log doesn't correspond to the table, just shows that logging works in general, right?
What I also don't understand:
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/tracing/card/TracingCardStateTest.kt - line 58
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/tracing/common/BaseTracingStateTest.kt - line 65
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/tracing/details/TracingDetailsStateTest.kt - line 60
here lastENFCalculation is always referring to lastTimeDiagnosisKeysFetched - shouldn't it refer to lastUpdateDate also for the tests?
Thanks in advance!

What I also don't understand:
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/tracing/card/TracingCardStateTest.kt - line 58
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/tracing/common/BaseTracingStateTest.kt - line 65
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/tracing/details/TracingDetailsStateTest.kt - line 60
here lastENFCalculation is always referring to lastTimeDiagnosisKeysFetched - shouldn't it refer to lastUpdateDate also for the tests?

It should. Doesn't change the results though, just local variable names. Will fix before this gets merged, (if it get's merged), after we get a response from Google. Good catch :+1:

from Luka's tests, it's not just rounding up/down either.

@harambasicluka
Hi Luka, if you find some time, could you help me understand your tests:
Table: UI is CWA and Settings is ENF?
Log: the log doesn't correspond to the table, just shows that logging works in general, right?

@vaubaehn I just checked the timestamp displayed on the risk card and than went in to the os settings (Settings > Google > COVID-19 exposure notifications > Exposure checks) and compared the time displayed here.

This PR is now too stale, still waiting on clarification from Google.


refactor type hinting

Issue #, if available:
Description of changes:
Main aim of this pr is to simplify the representation of type hints in the handler and improve IDE resolution of types for inline hinting/validation.
A notable sacrifice was that I had to set the type for the ResourceHandlerRequest in HandlerSignature to Any to get mypy to accept that the actual handler was using ResourceHandlerRequest not BaseResourceHandlerRequest.
Previously PyCharm (didn't test other IDE's) was not able to resolve types for ResourceModel or ProgressEvent. Type completion/validation now works as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

closing in favor of #51

@jaymccon @tobywf
Depending on the reasons to keep the type hinting and the behaviour of mypy, there might be a way to use generics and still have typehinting work in pycharm. It's not super clean, but might be workable:
Generating
model = request.desiredResourceState  # type: ResourceModel

does make pycharm work in that method. The big downside of going back to generics, is that that same idea still complains about the [] syntax in the type hints:

oh, interesting! from my side, i'm happy with the approach Jay suggested. coming into a new code-base is always tough, especially with dynamic languages. so the auto-completion really helps getting resource authors going. (if someone accidentally deleted that line, i'm guessing it would break again?)

It would break indeed. It is basically telling pycharm/mypy/... "I know better, use this as the type".


test: simplify PostgreSQL test and app

There's some confusion in the test and app as to whether schemas are
being tested. The test thinks that they are, but the app doesn't
actually put data in the schema. This update simplifies the test and app to no
longer attempt to test schemas. The simplest way to use the PostgreSQL
service is just to use the pre-existing "public" schema.
#181059797
Checklist:

[ ] Have you added Draft Release Notes in docs/draft-release-notes.md?
[X] Have you followed the Conventional Commits specification?

I agree that the simplest way to test Postgres is to use public schema and the app was not set up correctly to use the schema one created.
However, the schema creation and dropping assertions were added intentionally as part of the story to test user permissions. I would suggest we keep the schema and  fix the set and get handlers to read the schema and act on it rather then removing it all together.

Is there something special about schemas that makes it worthwhile to test them over and above other resources?

We had a conversation in person. The summary is that testing the deletion of a schema is useful as it triggers the change in ownership. Maybe there are other objects that we could test, but given we already have the schema code, it makes sense to use that. Let's close this PR for now, and I'll submit a new one if needed.


feat: add ViewingRoomsRailHomeViewSection tracking

This PR resolves ONYX-1263
Description
This PR adds tracking to the home view viewing rooms rail section.

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

add ViewingRoomsRailHomeViewSection tracking - mounir

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (add ViewingRoomsRailHomeViewSection tracking - mounir)

  Generated by :no_entry_sign: dangerJS against 0d500bfa444eef4f3fae570781476965e5a50507


Update IC Candid Files

Motivation
The Internet Computer APIs have updated.
Changes

Updated the interface description files for the Internet Computer.
Updated the javascript bindings for the latest IC interface.

Tests

[ ] Please check the API updates for any breaking changes that affect our code.

Manual fix still needed. Closing until it's done.


[MOD REPORT] Mini Menu (ID#95) (PS3)

Console Type: PlayStation 3
Category: Red Dead Redemption: GOTYE
Name: Mini Menu (ID#95)
System Type: DEX
Mod Type: EBOOT/SPRX
Author: RouletteBoi
Version: 1.1
Region: ALL

Game region is not ALL, it's just BLES01294 according to the information ;)

thanks, didnt notice this lmao - updated now


fix: bump Client GW SDK version

How this PR fixes it

Upgrade @gnosis.pm/safe-react-gateway-sdk to the latest published version.
Adapts getParameterElement() to handle the upgraded types

How to test it
Call SC methods with different param values, paying a special attention to

bytes
bytes32
bytes[]
address
bytes32[][]

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 35.257%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/DecodeTxs/index.tsx
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
3404

Relevant Lines:
8720

💛  - Coveralls

@katspaugh and @iamacook I cleaned up the code a little bit in the last commit, do you mind having another look? Also included "How to test it" so we can be more confident moving forward without the legacy parameter.type.endsWith('[]')

I'm blocked. As soon as I click the top right button the page crashes

As soon as I click the top right button the page crashes

I've merged dev back into the PR and looked into the code. It seems to be only happening on the deployment. If you open to another network and switch over the Rinkeby, everything is fine. I'd be apprehensive to debug this as it only seems to be happening here.

Please also clear your localStorage.

Looks good.
I don't have a contract with a method with a byte32[][], but I have other nested types and they worked fine:
https://pr3594--safereact.review-safe.gnosisdev.com/app/rin:0xFfDC1BcdeC18b1196e7FA04246295DE3A17972Ac/transactions/0xd033a21f0b77774aff058eee9e12c6a2fc0f5bb8aaad14352a41e15ca26b44a8
https://pr3594--safereact.review-safe.gnosisdev.com/app/rin:0xFfDC1BcdeC18b1196e7FA04246295DE3A17972Ac/transactions/0xf511f5d98cc1835674e8f3426039e8f2c9058eb20738c99f1bc84d59ae6f904a

I tried editing an ABI to have a method that takes a bytes32[][] but the tx is showing it as raw data instead of the array I expect.
Tried with similar ABI that nests integers and it works fine with that one, so I think is the system not being able to read a bytes32[][] properly.
ABI and results:
[{     "inputs": [       {         "internalType": "bytes32[][]",         "name": "paramNestedArrayInteger",         "type": "bytes32[][]"       }     ],     "name": "testNestedArrayInteger",     "outputs": [],     "stateMutability": "nonpayable",     "type": "function"   }]
Input:
[["0xa000000000000000000000000000000000000000000000000000000000000001", "0xa000000000000000000000000000000000000000000000000000000000000002"], ["0xa000000000000000000000000000000000000000000000000000000000000003", "0xa000000000000000000000000000000000000000000000000000000000000004"]]
Result:
https://pr3594--safereact.review-safe.gnosisdev.com/app/rin:0xFfDC1BcdeC18b1196e7FA04246295DE3A17972Ac/transactions/0x0be9c7208da0cdb8bc25c5c29d252259818984910964a38c330e4666393bbd5b

Tried with unit256[][] and it works fine with that one:
ABI:
[{     "inputs": [       {         "internalType": "uint256[][]",         "name": "paramNestedArrayInteger",         "type": "uint256[][]"       }     ],     "name": "testNestedArrayInteger",     "outputs": [],     "stateMutability": "nonpayable",     "type": "function"   }]
Input:
[[1,2,3][2,3,4]]
Result:
https://pr3594--safereact.review-safe.gnosisdev.com/app/rin:0xFfDC1BcdeC18b1196e7FA04246295DE3A17972Ac/transactions/0x966deb0cc78e5b2807ea9d7690d6393d6ca8a9ac128169a326d063f1b61e4a80

I tried editing an ABI to have a method that takes a bytes32[][] but the tx is showing it as raw data instead of the array I expect.

The decoded data is returned by the BE services. The Front End simply displays the data returned.
In the transactions that you compare, you can see in the "Network" request that we receive dataDecoded: null and only the value of hexData which is displayed. For the other transaction, dataDecoded is being returned in the response and thus shown in the UI.
This is not PR related behaviour however.

@francovenica I found your question still pertinent so I asked on #safe-internal https://gnosisinc.slack.com/archives/CQB729LLF/p1646649905653719

Follow up on this @francovenica . In order for the transaction data to be decoded, the BE has to include the ABI in the database, so it seems that we can't simply tweak the ABI and expecting the response with the decoded values.


Bricked devices

I've been doing some independent research and work with CSR8510-A10 devices and came across your project as part of that.
I wondered if you've ever experienced a device being bricked simply by putting it into HID mode - no pairing data added, simply setting "&03cd = 0002".
I note on the wiki it suggests devices with only 32K (NAND?) Flash memory may suffer this when switched to HID mode, but I'm not sure if that is due to missing the full stack or some other reason.
Do you know of a PSKEY that reports the size of installed Flash, EEPROM and RAM?

Alas, I know of no such key. So far, the only way to know for sure is to write one of the higher addresses and then read it back, but even that makes me nervous…


HW: Consider replacing RTC battery with supercap

Wenshan was suggesting that supercaps can last for ~month now -- they're way more robust to assemble and have no hazmat considerations. Should investigate whether AM0805 can support this.

No longer relevant.


HADOOP-19306. Support user defined auth Callback in SaslRpcServer.

Description of PR
HADOOP-19306
Similar to HDFS-17576, SaslRpcServer should support CustomizedCallbackHandler.
How was this patch tested?
Added new test cases
For code changes:

[Y] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[NA] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[NA] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 57s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 33s

trunk passed

+1 :green_heart:
compile
16m 49s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
15m 30s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
3m 49s

trunk passed

+1 :green_heart:
mvnsite
3m 11s

trunk passed

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
2m 45s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
5m 47s

trunk passed

+1 :green_heart:
shadedclient
37m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  3s

the patch passed

+1 :green_heart:
compile
16m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
16m 19s

the patch passed

+1 :green_heart:
compile
15m 53s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
15m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 43s
/results-checkstyle-root.txt
root: The patch generated 7 new + 334 unchanged - 1 fixed = 341 total (was 335)

+1 :green_heart:
mvnsite
3m  9s

the patch passed

+1 :green_heart:
javadoc
2m 21s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
2m 46s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
6m 18s

the patch passed

+1 :green_heart:
shadedclient
38m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m  2s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
221m 35s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  8s

The patch does not generate ASF License warnings.

467m 23s

Reason
Tests

Failed junit tests
hadoop.conf.TestCommonConfigurationFields

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux f500a0fc6379 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b77076ad415a1a063188e3467c6e980ff92d88b2

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/1/testReport/

Max. process+thread count
3900 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  4s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 10s

trunk passed

+1 :green_heart:
compile
16m 53s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
15m 38s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
3m 49s

trunk passed

+1 :green_heart:
mvnsite
3m 11s

trunk passed

+1 :green_heart:
javadoc
2m 28s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
2m 47s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
5m 53s

trunk passed

+1 :green_heart:
shadedclient
36m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s

the patch passed

+1 :green_heart:
compile
16m 50s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
16m 50s

the patch passed

+1 :green_heart:
compile
15m 37s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
15m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 43s

root: The patch generated 0 new + 334 unchanged - 1 fixed = 334 total (was 335)

+1 :green_heart:
mvnsite
3m  9s

the patch passed

+1 :green_heart:
javadoc
2m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
2m 47s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
6m  8s

the patch passed

+1 :green_heart:
shadedclient
37m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  5s

hadoop-common in the patch passed.

+1 :green_heart:
unit
218m 22s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

463m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux<PHONE_NUMBER>a9 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 631b9b65667b6a1dddbe5ff948b4ca9db931a320

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/2/testReport/

Max. process+thread count
3535 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I'm not knowledgeable enough of this code to review it

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  3s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 32s

trunk passed

+1 :green_heart:
compile
17m 55s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
16m 41s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
3m 47s

trunk passed

+1 :green_heart:
mvnsite
4m 17s

trunk passed

+1 :green_heart:
javadoc
3m 22s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 36s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
9m  8s

trunk passed

+1 :green_heart:
shadedclient
38m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  7s

the patch passed

+1 :green_heart:
compile
17m  8s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
17m  8s

the patch passed

+1 :green_heart:
compile
15m 43s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
15m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 47s
/results-checkstyle-root.txt
root: The patch generated 1 new + 337 unchanged - 2 fixed = 338 total (was 339)

+1 :green_heart:
mvnsite
4m 18s

the patch passed

+1 :green_heart:
javadoc
3m 21s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 41s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
8m 58s

the patch passed

+1 :green_heart:
shadedclient
38m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 58s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 44s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
228m 46s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

497m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDecommission

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 55d9c0a67840 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eb9071907b24002d981f087b260ebbfde3663442

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/3/testReport/

Max. process+thread count
4066 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
37m  1s

trunk passed

+1 :green_heart:
compile
20m 40s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
19m 27s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
4m 42s

trunk passed

+1 :green_heart:
mvnsite
4m 37s

trunk passed

+1 :green_heart:
javadoc
3m 46s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 43s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
9m  0s

trunk passed

+1 :green_heart:
shadedclient
43m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 30s

the patch passed

+1 :green_heart:
compile
23m 26s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
23m 26s

the patch passed

+1 :green_heart:
compile
18m 36s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
18m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 37s

root: The patch generated 0 new + 337 unchanged - 1 fixed = 337 total (was 338)

+1 :green_heart:
mvnsite
4m 34s

the patch passed

+1 :green_heart:
javadoc
3m 40s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 48s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
9m 28s

the patch passed

+1 :green_heart:
shadedclient
43m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m  7s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 49s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
265m 40s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 16s

The patch does not generate ASF License warnings.

569m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 67b1af1697a5 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 23dd123927da464be017a1ee9e00120abb09586b

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/4/testReport/

Max. process+thread count
2694 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 23s

trunk passed

+1 :green_heart:
compile
16m 44s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
15m 35s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
3m 50s

trunk passed

+1 :green_heart:
mvnsite
4m 18s

trunk passed

+1 :green_heart:
javadoc
3m 25s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 39s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
8m 27s

trunk passed

+1 :green_heart:
shadedclient
38m 45s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
39m 10s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
16m 16s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
16m 16s

the patch passed

+1 :green_heart:
compile
15m 38s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
15m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 44s
/results-checkstyle-root.txt
root: The patch generated 1 new + 389 unchanged - 3 fixed = 390 total (was 392)

+1 :green_heart:
mvnsite
4m 15s

the patch passed

+1 :green_heart:
javadoc
3m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 40s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
9m  1s

the patch passed

+1 :green_heart:
shadedclient
37m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m  4s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 46s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
225m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

489m 12s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDecommission

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 663f2868c4f1 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 99b1487e6bdea73b0b9f23a6a13e79e33f0ecd4a

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/5/testReport/

Max. process+thread count
3431 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 28s

trunk passed

+1 :green_heart:
compile
16m 51s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
15m 36s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
3m 45s

trunk passed

+1 :green_heart:
mvnsite
4m 18s

trunk passed

+1 :green_heart:
javadoc
3m 24s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 40s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
8m 28s

trunk passed

+1 :green_heart:
shadedclient
37m 10s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
37m 34s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
16m 13s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
16m 13s

the patch passed

+1 :green_heart:
compile
15m 40s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
15m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 44s

root: The patch generated 0 new + 389 unchanged - 3 fixed = 389 total (was 392)

+1 :green_heart:
mvnsite
4m 16s

the patch passed

+1 :green_heart:
javadoc
3m 18s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 40s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
9m  7s

the patch passed

+1 :green_heart:
shadedclient
37m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 58s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 46s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
226m 31s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

487m 13s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDecommission

hadoop.hdfs.TestDecommissionWithBackoffMonitor

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 07e2db57d8ca 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 737258904fc5bbea9863d5b2e1c7b4643880e7f2

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/6/testReport/

Max. process+thread count
3442 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

Will try rebasing this.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 22s

trunk passed

+1 :green_heart:
compile
16m 46s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
15m 42s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
3m 47s

trunk passed

+1 :green_heart:
mvnsite
4m 18s

trunk passed

+1 :green_heart:
javadoc
3m 25s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 43s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
8m 30s

trunk passed

+1 :green_heart:
shadedclient
37m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  3s

the patch passed

+1 :green_heart:
compile
21m 14s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
21m 14s

the patch passed

+1 :green_heart:
compile
16m 37s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
16m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m  3s

root: The patch generated 0 new + 389 unchanged - 3 fixed = 389 total (was 392)

+1 :green_heart:
mvnsite
4m 27s

the patch passed

+1 :green_heart:
javadoc
3m 14s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 40s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
9m  3s

the patch passed

+1 :green_heart:
shadedclient
37m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 57s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 46s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
221m 51s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

489m 59s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDecommission

hadoop.hdfs.TestDecommissionWithBackoffMonitor

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux b63530ed9114 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 11ac338c6b10b9c3eafc16e1d5a24c09167ee85e

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/7/testReport/

Max. process+thread count
3455 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 32s

trunk passed

+1 :green_heart:
compile
16m 56s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
15m 40s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
3m 48s

trunk passed

+1 :green_heart:
mvnsite
4m 16s

trunk passed

+1 :green_heart:
javadoc
3m 26s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 38s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
8m 26s

trunk passed

+1 :green_heart:
shadedclient
37m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s

the patch passed

+1 :green_heart:
compile
16m 11s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
16m 11s

the patch passed

+1 :green_heart:
compile
15m 35s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
15m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 41s

root: The patch generated 0 new + 419 unchanged - 3 fixed = 419 total (was 422)

+1 :green_heart:
mvnsite
4m 12s

the patch passed

+1 :green_heart:
javadoc
3m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
3m 39s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
9m 10s

the patch passed

+1 :green_heart:
shadedclient
38m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m  2s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 46s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
227m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

489m 30s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDecommission

hadoop.hdfs.TestDecommissionWithBackoffMonitor

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7140

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 5d029c8056a2 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 40cd459e54bd3cc5c45e3a271ea2410f764d14b7

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/8/testReport/

Max. process+thread count
3482 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7140/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang , @stoty , thanks a lot for reviewing this!

@szetszwo now all my test run logs are full of stuff
2024-11-18 18:53:37,645 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod SIMPLE: code=80, mechanism=""
2024-11-18 18:53:37,645 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod KERBEROS: code=81, mechanism="GSSAPI"
2024-11-18 18:53:37,646 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod DIGEST: code=82, mechanism="DIGEST-MD5"
2024-11-18 18:53:37,646 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod TOKEN: code=82, mechanism="DIGEST-MD5"
2024-11-18 18:53:37,646 [setup] INFO  security.SaslRpcServer (SaslRpcServer.java:<init>(239)) - AuthMethod PLAIN: code=83, mechanism="PLAIN"

stack trace from the debugger implies this is UGI.initialize() calling SaslRpcServer, which now involves SaslMechanismFactory.getMechanism(), which has its own static initialiser and before long things are being logged which are completely needless.
I'm not going to roll it back as that is overkill, however this needs to be addressed as every piece of code invoking a UGI method will now see these extra lines.
Options

downgrade to debug
SaslRpcServer reverts to simpler references.

I don't care which -only that it has done ASAP. thanks.

@steveloughran , thanks for letting me know.
AuthMethod is an inner class of SaslRpcServer.  I don't not expect UGI using it.  Let me see how should it be fixed.

Filed HADOOP-19342.


cursor icon not changed if cursor not moving

cursor state not changed if mouse not moving, but sprite change its position, scale, rotation etc
Steps to reproduce

Open page: https://phaser.io/examples/v2/input/pixel-perfect-click-detection
move mouse to the bear and stop it, wait until rotating bear slide under cusor
cursor doesn't changed to hand until player move mouse

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


Support range in groupby_bins

Although groupby_bins supports setting bins as int, it doesn't support manually setting the range.
Here's an example:
from scipy.stats import binned_statistic
import numpy as np
import xarray as xr

# --- scipy method ---
x = np.arange(500)
values = x*50
statistics, _, _ = binned_statistic(x, values, statistic='min', bins=500, range=(0, 500))

# --- xarray method ---
x = xr.DataArray(x)
values = xr.DataArray(values)
x.groupby_bins('dim_0', bins=500).min()

I can set range=(0, 500) in binned_statistic, how can I get the same result using groupby_bins?
Is it suitable to add this new feature?
I have also posted a similar question on StackOverflow.

If bins is an int, it defines the number of equal-width bins in the given range (10 by default).

So the xarray equivalent would be bins=np.linspace(0, 500, 500). An extra kwarg seems unnecessary.

@dcherian Thanks! That's simple ;) However, the groupby_bins method is a little different from binned_statistic.
binned_statistic:

All but the last (righthand-most) bin is half-open. In other words, if bins is [1, 2, 3, 4], then the first bin is [1, 2) (including 1, but excluding 2) and the second [2, 3). The last bin, however, is [3, 4], which includes 4.

groupby_bins:

right (bool, default: True) – Indicates whether the bins include the rightmost edge or not. If right == True (the default), then the bins [1,2,3,4] indicate (1,2], (2,3], (3,4].

So, let's check this shorter example:
from scipy.stats import binned_statistic
import numpy as np
import xarray as xr

# --- scipy method ---
x = np.arange(10)
values = x*5
statistics, _, _ = binned_statistic(x, values, statistic='min', bins=10, range=(0, 10))

# --- xarray method ---
x = xr.DataArray(x)
values = xr.DataArray(values)
bin_res = values.groupby_bins('dim_0', bins=np.linspace(0, 10, 10), right=False, include_lowest=True).min()

print('scipy: \n', statistics)
print('xarray: \n', bin_res)

Output:
scipy:
 [ 0.  5. 10. 15. 20. 25. 30. 35. 40. 45.]

xarray:
 <xarray.DataArray (dim_0_bins: 9)>
array([ 0, 10, 15, 20, 25, 30, 35, 40, 45])
Coordinates:
  * dim_0_bins  (dim_0_bins) object [0.0, 1.111) ... [8.889, 10.0)

The scipy method has one more value ...
Summary
These produce the same results:
binned_statistic(x, values, statistic='min', bins=10, range=(0, 10))
values.groupby_bins('dim_0', bins=np.linspace(0, 10, 11), right=False, include_lowest=True).min()

Output:
scipy:
 [ 0.  5. 10. 15. 20. 25. 30. 35. 40. 45.]
xarray:
 <xarray.DataArray (dim_0_bins: 10)>
array([ 0,  5, 10, 15, 20, 25, 30, 35, 40, 45])
Coordinates:
  * dim_0_bins  (dim_0_bins) object [0.0, 1.0) [1.0, 2.0) ... [9.0, 10.0)

@dcherian Has this method been improved in dask_groupby? Could you provide a simple example we can follow? I got lost in the dask_groupby documentation ...

No I haven't finished the implementation yet.


[ZEPPELIN-3994] Notebook serving

What is this PR for?
This PR implements notebook serving explained here.
While this PR is already quite large, front-end implementation will have separate PR.
This PR is work in progress.
How to run

Prepare kubernetes cluster
Prepare persistentVolumeClaim with name 'task-context-volume-claim' in your kubernetes cluster
Build Zeppelin docker image (follow instructions here
Deploy api router by running kubectl apply -f k8s/serving-api-router/serving-api-router.yaml
Start Zeppelin on Kubernetes by running kubectl apply -f k8s/zeppelin-server.yaml
Port forward to the api router (e.g. kubectl port-forward <zeppelin-serving-api-router pod name> 8080:80) and browse localhost:8080

*Note: This branch does not include front-end implementation. To try with front-end, checkout this branch.
Summary of changes
To be updated
What type of PR is it?
Feature
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3994
How should this be tested?

First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Questions:

Does the licenses files need update? yes
Is there breaking changes for older versions? no
Does this needs documentation? yes

Which version of Zeppelin do I run on Kubernetes to work with Flink 1.11.3? Is there a working Zeppelin Kubernetes YAML that works with Flink?

Which version of Zeppelin do I run on Kubernetes to work with Flink 1.11.3? Is there a working Zeppelin Kubernetes YAML that works with Flink?

@amit-shahi You can download latest zeppelin 0.9 which support flink 1.11, but we haven't verified it on k8s

@amit-shahi You can download latest zeppelin 0.9 which support flink 1.11, but we haven't verified it on k8s

@zjffdu Can I use the Docker Image apache/zeppelin:0.9.0 (https://hub.docker.com/r/apache/zeppelin/tags?page=1&ordering=last_updated)? Also, I have flink running on another POD on the same K8 cluster. Where do I configure Zeppelin to connect to my existing Flink Job Manager POD so Zeppelin can submit JOBS through it's UI?

@zjffdu Can I use the Docker Image apache/zeppelin:0.9.0 (https://hub.docker.com/r/apache/zeppelin/tags?page=1&ordering=last_updated)? Also, I have flink running on another POD on the same K8 cluster. Where do I configure Zeppelin to connect to my existing Flink Job Manager POD so Zeppelin can submit JOBS through it's UI?

I am afraid the docker image of 0.9 is still using 0.9.0-preview2, we are working on it to upgrade to 0.9.0
But it still support flink 1.11 IIRC.

I am afraid the docker image of 0.9 is still using 0.9.0-preview2, we are working on it to upgrade to 0.9.0
But it still support flink 1.11 IIRC.

@zjffdu Okay. Which Zeppelin version I should from Docker?  I have flink running on another POD on the K8s cluster. Where do I configure Zeppelin to connect to my existing Flink Job Manager POD so Zeppelin can submit JOBS through it's UI?

@zjffdu Okay. Which Zeppelin version I should from Docker?  I have flink running on another POD on the K8s cluster. Where do I configure Zeppelin to connect to my existing Flink Job Manager POD so Zeppelin can submit JOBS through it's UI?

@amit-shahi You can refer the document here, remote mode is the way you should use I believe, https://app.gitbook.com/@jeffzhang/s/flink-on-zeppelin/execution-mode/remote-mode

@amit-shahi You can refer the document here, remote mode is the way you should use I believe, https://app.gitbook.com/@jeffzhang/s/flink-on-zeppelin/execution-mode/remote-mode

@zjffdu Thanks. I'm accessing Kubernetes on the Windows system. As per the above documentation, Do I need to set FLINK_HOME to my local Flink directory (not on Kubernetes)? Can I bypass this so it can use Kubernetes Flink's FLINK_HOME reference instead? What's the right way to do that?

@zjffdu Thanks. I'm accessing Kubernetes on the Windows system. As per the above documentation, Do I need to set FLINK_HOME to my local Flink directory (not on Kubernetes)? Can I bypass this so it can use Kubernetes Flink's FLINK_HOME reference instead? What's the right way to do that?

flink should be put in the same host of zeppelin. FLINK_HOME point to that location.

flink should be put in the same host of zeppelin. FLINK_HOME point to that location.

@zjffdu I'm not sure if I got that. Let's say on Kubernetes, Flink's Job Manager is installed on POD1 and Task Manager is installed on POD2. When we install Zeppelin through YAML, it gets installed on POD 3, How do I use POD1's (Job Manager) FLINK_HOME location/reference in POD 3 so Zeppelin server can connect to existing Flink installation?

@zjffdu I'm not sure if I got that. Let's say on Kubernetes, Flink's Job Manager is installed on POD1 and Task Manager is installed on POD2. When we install Zeppelin through YAML, it gets installed on POD 3, How do I use POD1's (Job Manager) FLINK_HOME location/reference in POD 3 so Zeppelin server can connect to existing Flink installation?

You need to put flink in pod3 and specify FLINK_HOME to this path. Then specify flink.execution.remote.host and flink.execution.remote.port as the JobManager rest api address

You need to put flink in pod3 and specify FLINK_HOME to this path. Then specify flink.execution.remote.host and flink.execution.remote.port as the JobManager rest api address

@zjffdu I will try that. Thanks.

@zjffdu I will try that. Thanks.

You need to set zeppelin.run.mode as local in zeppelin-site.xml

You need to set zeppelin.run.mode as local in zeppelin-site.xml

@zjffdu Thanks. I'm using this k8 YAML https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml
Is there a different image for interpreter apache/zeppelin-interpreter:0.9.0-SNAPSHOT (as mentioned in above YAML)
or can I use apache/zeppelin:0.9.0  from https://hub.docker.com/r/apache/zeppelin/tags as an image for ZEPPELIN_K8S_CONTAINER_IMAGE in zeppelin yaml?

@zjffdu Thanks. I'm using this k8 YAML https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml
Is there a different image for interpreter apache/zeppelin-interpreter:0.9.0-SNAPSHOT (as mentioned in above YAML)
or can I use apache/zeppelin:0.9.0  from https://hub.docker.com/r/apache/zeppelin/tags as an image for ZEPPELIN_K8S_CONTAINER_IMAGE in zeppelin yaml?

@amit-shahi Let's discuss that in user mail list.

@amit-shahi Let's discuss that in user mail list.

@zjffdu Ok, I will create a thread on the mailing list.

@zjffdu Ok, I will create a thread on the mailing list.

@zjffdu When I try to execute this YAML https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml thru
kubectl apply -f zeppelin-server.yaml, I see this error-

Is the yaml file correct?

@zjffdu When I try to execute this YAML https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml thru
kubectl apply -f zeppelin-server.yaml, I see this error-

Is the yaml file correct?

@zjffdu How do I set zeppelin.run.mode as local in zeppelin-site.xml?

@zjffdu How do I set zeppelin.run.mode as local in zeppelin-site.xml?


Refine location view

Closes: #4016
What's Changed

Reorder location detail view fields
TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Can we get some screenshots of a comparison between the new and old UI just for posterity's sake?


About - DevBlog

I think it would be a good addition to the DevBlog if there was post under the Category "About the Team" or a part of the site that is an actual "About Us". The format could be like it is in this image, were we all each have a photo of us, write little bio on why you're happy to work as a developer for games or why you do what you're doing, and a small list on games you have worked on. That little list will grow throughout the years and it will make for an amazing reference page for all of us. I just need to know if this is a cool and interesting idea, and if so, @torch2424 build it into the site? Cause he's the one who programmed the site.

@Heebe Yeah I can get on that. And I saw your texts and stuff by the way. Please keep in mind I have alot of stuff to do. I work 9 hours a day Monday-Wednesday, and I still have some freelance contracts to finish up before summer ends. So I've been quite busy. I try to dedicate about 20 hours a week to the game though. So I know you weren't rushing me to do anything, but yeah just give me a to-do list I can do when I have time. That's why I like the github issue system :)

@Heebe I need profile pictures from everyone to do this!

Finished and looks SUPPPEERRR good due to the power of basic html and inline css in wordpress.
http://www.nocomplygames.com/about/


Changed method doc to the right accepted param type

Hi! Great work!
Apologies if this PR doesn't comply with your guidelines, I couldn't read them in their original language! Found a miss-matching method param type in the Raw class construct doc, hope this helps :)
Thanks!

@marianoasselborn Thanks.


claim PGPy2 on PyPi

if we're going to maintain this fork, we should claim the name on PyPi

this is done


It takes to long to stop VlcMediaPlayer

I have an issue / a question (pick one) about Vlc.DotNet.
Generic information

Vlc.DotNet version : 3.0.1
Vlc.DotNet project used : Core
libvlc version : <IP_ADDRESS> x86
.net version : 4.5
Project language : C#
Project build architecture : AnyCPU
Operating system : Windows x64

Summary
I have a simple WPF application. The application records an RTSP stream to a file. For this purpose Vlc.DotNet library is used.
I have tested the application with two computers and the results are the same for both.
The application code is given below.
    public partial class MainWindow : Window
    {
        private IPath _pathWrapper;
        private IDirectoryInfo _vlcLibDirectory;
        private VlcMediaPlayer _videoRecorder;

        public MainWindow()
        {
            InitializeComponent();
        }

        private void OnButtonClick(object sender, RoutedEventArgs e)
        {
            if (_videoRecorder != null && _videoRecorder.IsPlaying())
            {
                _videoRecorder.Stop();
                Button.Background = Brushes.Blue;
                _videoRecorder = null;
                return;
            }

            string currentDirectory = AppDomain.CurrentDomain.BaseDirectory;
            _pathWrapper = new PathWrap();
            _vlcLibDirectory = new DirectoryInfoWrap(_pathWrapper.Combine(currentDirectory, "libvlc", IntPtr.Size == 4 ? "win-x86" : "win-x64"));
            var options = new string[]
            {
                "--file-logging",
                "--logfile=OnvifVideoRecording.log",
                "-vvv"
            };
            _videoRecorder = new VlcMediaPlayer(_vlcLibDirectory.DirectoryInfo, options);

            //string fileDestination = "\\\\\\BuildSrv\\Videos\\A, A, 1\\test.mp4";
            string fileDestination = @"D:\Media\Video\A, A, 1\test.mp4";

            if (File.Exists(fileDestination))
            {
                File.Delete(fileDestination);
            }

            string[] mediaOptions =
            {
                ":sout=#file{dst='" + fileDestination + "'}",
                ":sout-keep"
            };

            _videoRecorder.SetMedia("rtsp://<IP_ADDRESS>:5504/channel=0,stream=0", mediaOptions);
            _videoRecorder.Play();
            Button.Background = Brushes.Red;
        }
    }

The application has a window. The window has a button. When this button is pressed for the first time, recording a video file is started and the button turns red. I usually record video files for 10 minutes. When the button is pressed for the second time, recording a video file is stopped and the button turns blue.
If I record a file to the local destination (to the same computer where the program is run, for example, D:\Media\Video\A, A, 1\test.mp4), everything is ok. Recording video file is started and stopped quickly, almost immediately.
The problems occur when I try to record a file to the remote computer (for example, \BuildSrv\Videos\A, A, 1\test.mp4). Recording a video file starts immediately. However, _videoRecorder.Stop() takes approximately 30 seconds – 1 minute. Resource monitor shows very high network use (90% in case of one computer and 100% in case of another) after the button is pressed for the second time (recording video is stopped). The longer the recorded video file is, the more time is needed to stop VlcMediaPlayer.
Why does stopping VlcMediaPlayer takes so much time in case of recording an RTSP stream to the remote computer? Can this problem be solved somehow?

[ ] I confirm that my issue doesn't happen in VLC itself.

Maybe related https://code.videolan.org/videolan/LibVLCSharp/issues/214

So I can do nothing to verify this hypothesis if I do not know how to compile a recent nightly libvlc build?

You could try a libvlc 4 build to see if that changes anything, but neither vlc.dotnet nor libvlcsharp supports it yet, because it's still unstable.

I downloaded vlc-4.0.0-20191004-0250-dev-win32.zip, unzipped it and pasted needed files to the bin folder. I get next exception:
System.MissingMethodException
HResult=0x80131513
Message=The address of the function 'libvlc_media_player_stop' does not exist in libvlc library.
Source=Vlc.DotNet.Core.Interops
StackTrace:
at Vlc.DotNet.Core.Interops.VlcLibraryLoader.GetInteropDelegateT in C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\Vlc.DotNet.Core.Interops\VlcLibraryLoader.cs:line 98
at Vlc.DotNet.Core.Interops.VlcManager.Stop(VlcMediaPlayerInstance mediaPlayerInstance) in C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\Vlc.DotNet.Core.Interops\VlcManager.Stop.cs:line 12
at Vlc.DotNet.Core.VlcMediaPlayer.Stop() in C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\Vlc.DotNet.Core\VlcMediaPlayer\VlcMediaPlayer.cs:line 216
at MyWpfApp.MainWindow.OnButtonClick(Object sender, RoutedEventArgs e) in C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\MainWindow.xaml.cs:line 40
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
at System.Windows.Controls.Primitives.ButtonBase.OnClick()
at System.Windows.Controls.Button.OnClick()
at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
at System.Windows.Input.InputManager.ProcessStagingArea()
at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
at System.Windows.Application.RunDispatcher(Object ignore)
at System.Windows.Application.RunInternal(Window window)
at System.Windows.Application.Run(Window window)
at System.Windows.Application.Run()
at MyWpfApp.App.Main()
Inner Exception 1:
Win32Exception: The specified procedure could not be found

You can contribute changes to vlc.dotnet so that a preview version of it supports libvlc 4. But libvlc 4 is not available on nuget yet, so it will be confusing for a lot of users. You can start by patching locally, by adding support for the async version of stop in vlc.dotnet.

I did as you said.
In VlcMediaPlayer I added method StopAsyn(...):
public void StopAsync()
        {
            Manager.StopAsync(myMediaPlayerInstance);
        }

In VlcManager I added method StopAsyn(...):
public void StopAsync(VlcMediaPlayerInstance mediaPlayerInstance)
        {
            if (mediaPlayerInstance == IntPtr.Zero)
                throw new ArgumentException("Media player instance is not initialized.");
            myLibraryLoader.GetInteropDelegate<StopAsync>().Invoke(mediaPlayerInstance);
        }

In the namespace Vlc.DotNet.Core.Interops.Signatures I added next code:
[LibVlcFunction("libvlc_media_player_stop_async")]
    [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
    internal delegate void StopAsync(IntPtr mediaPlayerInstance);

Now stream recording to file stops immediately, but sometimes (in the most cases) resultant file is defective and it is impossible to open it.

the nightly builds can be unstable so it could be anything. You have logs?

The log is here:
libVlc : Debug Copyright © 1996-2019 the VideoLAN team @ main
libVlc : Debug VLC media player - 4.0.0-dev Otto Chriek @ main
libVlc : Debug revision 4.0.0-dev-9500-gff11419a43 @ main
libVlc : Debug configured with ../extras/package/win32/../../../configure  '--enable-update-check' '--enable-lua' '--enable-faad' '--enable-flac' '--enable-theora' '--enable-avcodec' '--enable-merge-ffmpeg' '--enable-dca' '--enable-libass' '--enable-schroedinger' '--enable-live555' '--enable-dvdread' '--enable-shout' '--enable-goom' '--enable-caca' '--enable-qt' '--enable-skins2' '--enable-sse' '--enable-mmx' '--enable-libcddb' '--enable-zvbi' '--disable-telx' '--enable-nls' '--host=i686-w64-mingw32' '--enable-debug' 'host_alias=i686-w64-mingw32' 'PKG_CONFIG_LIBDIR=/home/jenkins/workspace/vlc-nightly/vlc-nightly-win32-x86/contrib/i686-w64-mingw32/lib/pkgconfig' @ main
libVlc : Debug Creating an input for 'rtsp://<IP_ADDRESS>:5504/channel=0,stream=0' @ main
libVlc : Debug using sout chain=`file{dst='\\\BuildSrv\Videos\A, A, 1\test.mp4'}' @ main
libVlc : Debug set config option: sout-standard-dst to \\BuildSrv\Videos\A, A, 1\test.mp4 @ main
libVlc : Debug stream=`file' @ main
libVlc : Debug looking for sout stream module matching "file": 24 candidates @ main
libVlc : Debug looking for sout access module matching "file": 11 candidates @ main
libVlc : Debug file access output opened (\\BuildSrv\Videos\A, A, 1\test.mp4) @ file
libVlc : Debug using sout access module "file" @ main
libVlc : Debug looking for sout mux module matching "mp4": 11 candidates @ main
libVlc : Debug Mp4 muxer opened @ mp4
libVlc : Debug using sout mux module "mp4" @ main
libVlc : Debug using `file/mp4://\\BuildSrv\Videos\A, A, 1\test.mp4' @ stream_out_standard
libVlc : Debug using sout stream module "stream_out_standard" @ main
libVlc : Debug using timeshift granularity of 50 MiB @ main
libVlc : Debug using timeshift path: C:\Users\liidia\AppData\Local\Temp @ main
libVlc : Debug `rtsp://<IP_ADDRESS>:5504/channel=0,stream=0' gives access `rtsp' demux `any' path `<IP_ADDRESS>:5504/channel=0,stream=0' @ main
libVlc : Debug creating access: rtsp://<IP_ADDRESS>:5504/channel=0,stream=0 @ main
libVlc : Debug  (path: \\<IP_ADDRESS>:5504\channel=0,stream=0) @ main
libVlc : Debug looking for access module matching "rtsp": 40 candidates @ main
libVlc : Debug version 2016.11.28 @ live555
libVlc : Debug RTP subsession 'video/H264' @ live555
libVlc : Debug selecting program id=0 @ main
libVlc : Debug Trying Lua scripts in C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist @ lua
libVlc : Debug setup start: 0.000000 stop:0.000000 @ live555
libVlc : Debug using access module "live555" @ main
libVlc : Debug We have a timeout of 60 seconds @ live555
libVlc : Debug play start: 0.000000 stop:0.000000 @ live555
libVlc : Debug looking for stream_filter module matching "any": 25 candidates @ main
libVlc : Debug not enough data @ playlist
libVlc : Debug Trying Lua scripts in C:\Users\liidia\AppData\Roaming\vlc\lua\playlist @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\soundcloud.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\anevia_xml.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\appletrailers.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\twitch.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\newgrounds.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\koreus.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\bbc_co_uk.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\vimeo.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\anevia_streams.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\cue.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\liveleak.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\dailymotion.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\vocaroo.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\youtube.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\rockbox_fm_presets.luac @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\playlist\jamendo.luac @ lua
libVlc : Debug found NAL_SPS (sps_id=0) @ h264
libVlc : Debug no stream_filter modules matched @ main
libVlc : Debug looking for packetizer module matching "any": 25 candidates @ main
libVlc : Debug found NAL_PPS (pps_id=0 sps_id=0) @ h264
libVlc : Debug using packetizer module "h264" @ main
libVlc : Debug starting in sync mode @ main
libVlc : Debug looking for meta reader module matching "any": 2 candidates @ main
libVlc : Debug Trying Lua scripts in C:\Users\liidia\AppData\Roaming\vlc\lua\meta\reader @ lua
libVlc : Debug Trying Lua scripts in C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\meta\reader @ lua
libVlc : Debug Trying Lua playlist script C:\Users\liidia\Documents\Vlc.DotNet-develop\Vlc.DotNet-develop\src\MyWpfApp\bin\Debug\libvlc\win-x86\lua\meta\reader\filename.luac @ lua
libVlc : Debug no meta reader modules matched @ main
libVlc : Debug `rtsp://<IP_ADDRESS>:5504/channel=0,stream=0' successfully opened @ main
libVlc : Debug switching to async mode @ main
libVlc : Debug Buffering 0% @ main
libVlc : Debug lost 395906 bytes @ live555
libVlc : Debug Buffering 3% @ main
libVlc : Debug Buffering 1% @ main
libVlc : Debug increasing buffer size to 500000 @ live555
libVlc : Debug adding input @ mp4
libVlc : Debug adding a new sout input for `h264` (sout_input: 12C85F20) @ main
libVlc : Debug adding a new input @ main
libVlc : Debug Buffering 6% @ main
libVlc : Debug Buffering 31% @ main
libVlc : Debug Buffering 35% @ main
libVlc : Debug Buffering 39% @ main
libVlc : Debug Buffering 43% @ main
libVlc : Debug Buffering 47% @ main
libVlc : Debug Buffering 51% @ main
libVlc : Debug Buffering 55% @ main
libVlc : Debug Buffering 59% @ main
libVlc : Debug Buffering 63% @ main
libVlc : Debug Buffering 67% @ main
libVlc : Debug Buffering 71% @ main
libVlc : Debug Buffering 75% @ main
libVlc : Debug Buffering 79% @ main
libVlc : Debug Buffering 83% @ main
libVlc : Debug Buffering 87% @ main
libVlc : Debug Buffering 91% @ main
libVlc : Debug Buffering 95% @ main
libVlc : Debug Buffering 99% @ main
libVlc : Debug Stream buffering done (1030 ms in 897 ms) @ main
libVlc : Debug Decoder wait done in 0 ms @ main
libVlc : Debug tk->rtpSource->hasBeenSynchronizedUsingRTCP() @ live555
libVlc : Debug ES_OUT_RESET_PCR called @ main
libVlc : Debug Buffering 0% @ main
libVlc : Debug lost 144972 bytes @ live555
libVlc : Debug increasing buffer size to 1000000 @ live555
libVlc : Debug Buffering 28% @ main
libVlc : Debug Buffering 32% @ main
libVlc : Debug Buffering 36% @ main
libVlc : Debug Buffering 40% @ main
libVlc : Debug Buffering 44% @ main
libVlc : Debug Buffering 48% @ main
libVlc : Debug Buffering 52% @ main
libVlc : Debug Buffering 56% @ main
libVlc : Debug Buffering 60% @ main
libVlc : Debug Buffering 64% @ main
libVlc : Debug Buffering 68% @ main
libVlc : Debug Buffering 72% @ main
libVlc : Debug Buffering 76% @ main
libVlc : Debug Buffering 80% @ main
libVlc : Debug Buffering 84% @ main
libVlc : Debug Buffering 88% @ main
libVlc : Debug Buffering 92% @ main
libVlc : Debug Buffering 96% @ main
libVlc : Debug Buffering 100% @ main
libVlc : Debug Stream buffering done (1040 ms in 1062 ms) @ main
libVlc : Debug Decoder wait done in 0 ms @ main
libVlc : Debug killing decoder fourcc `h264' @ main
libVlc : Debug removing module "h264" @ main
libVlc : Debug removing a sout input (sout_input: 12C85F20) @ main
libVlc : Debug removing input @ mp4
libVlc : Debug Program doesn't contain anymore ES @ main
libVlc : Debug removing module "live555" @ main
libVlc : Debug tk 1 elst media time 0 duration 5070001 offset 0 @ mp4
libVlc : Debug tk 1 elst media time 5070001 duration 606945951 offset 0 @ mp4
libVlc : Warning no more input streams for this mux @ main
libVlc : Debug destroying input for 'rtsp://<IP_ADDRESS>:5504/channel=0,stream=0' @ main


Steel effect with auto-framing and associated typechecker changes

I now have small examples working for the new steel effect that includes auto-framing. The examples don't need an explicit return either.
The effect is in ulib/experimental/Steel.FramingEffect.fst and tests in examples/steel/Steel.Effects2.Tests.fst`.
Main typechecker changes include:

polymonadic_subcomp, specifically to allow SteelF <: Steel
Returning pure computations into M when (M, PURE) cannot be composed, this is done as part of maybe_return_e2_and_bind.

I already pushed some related changes into master. These changes include using M.return rather than PURE.return and then lift_PURE_M when lifting e2 in maybe_return_e2_and_bind. This combined with the second bullet above gives us a generic implementation of bind_M_PURE.

Many thanks @nikswamy for the review! Please see my comments. If we are happy with it, should I merge it in?

hi @aseemr  thanks for all your responses. I'm fine with the merge once you're happy with CI.


How to save command for restoring, but not execute right now

In Activity I fill EditText and each entered character i call presenter.setName(name). In presenter I save name as class parameter. But if I'll rotate screen the name will dissapear because I don't call viewState methods when I save name in presenter. I don't need to call some method in activity to save state like this (viewState.onNameChanged()), but moxy makes me to do it. So I'd like to offer you to create feature for saving view state command without calling methods in activity if activity doesn't need to restore state.
For example when I sets name in presenter i call viewState.onRestoreName(name) and this command will reproduced in activity when activity need to restore state, but not right now.

Hi!
This is an example of a general problem with Android View system and MVP - state duplication and the lack of a single source of truth.
In general, if you store some state in your Presenter - the name, in your case - it's your responsibility to pass this state to the UI with some viewState calls, for instance, viewState.showName(name). Maybe you don't need this in your particular case, because the name is not changed by the Presenter, but when you add some kind of logic, for example, name validation - you'll have to call viewState anyway.
So, to recap: you should always render the most actual state stored in Presenter, and you do it by calling viewState methods. I don't think that adding another kind of state restoration to Moxy will make things better, because it'll only make the problem of inconsistent state worse. And if you absolutely need to restore some state without calling viewState methods - well, there's always savedInstanceState, which actually should restore your EditText state out of the box.


Fix/audit axios

Change description
Enter a description.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-
Before merging a pull request make sure that:

[ ] tests have been updated / new tests has been added (if needed)
[ ] README and other documentation has been updated / added (if needed)

If this ticket will have any visible impact on users and is not behind a feature toggle, make sure that:

[ ] this ticket been reviewed by QA
[ ] the user story been signed off by the PO

Note that bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.
If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.

if it was anything other than codecepts I'd be a bit worried about compatibility issues between pre 1.0 versions of axios but it should be fine

if it was anything other than codecepts I'd be a bit worried about compatibility issues between pre 1.0 versions of axios but it should be fine

it has been raised as an issue on their github so hopefully when the next version comes out and its fixed, ill undo this.


Track "pending" notes in pcli

pcli currently only tracks notes as being "spent" or "unspent", and synchronizes that state from the chain.
This causes problems while submitting multiple transactions in succession, since the client state forgets that it's already tried to spend a note, and then tries to spend it again, resulting in an attempted double-spend.  (This interacts particularly badly with the current bug in #229, but would be an issue regardless).
To fix this, we should track pending changes to the client state that have been submitted to the chain, but not yet included.
There are two relevant additional states: pending_spent and pending_change. Notes that are consumed by a submitted transaction should be marked as pending_spent, and the change notes (outputs we send to ourself) should be marked as pending_change. We should track both spends and outputs, because otherwise the UI would report to the user that they've spent much more than they probably intended.
Pending notes should have a timestamp recording when the transaction was created.  Notes are removed from the "pending" state as follows:

During sync, observing a nullifier from a pending_spent note causes it to be moved from the pending_spent set to the spent set;
During sync, observing a note in the pending_change set causes it to be moved into the unspent set;
After some timeout, pending_spent notes are moved back to the unspent set;
After some timeout, pending_change notes are deleted.

The timeout should be long enough to mostly cover transaction submission; we don't want to keep stuff in the "pending" state forever, and if a long time has passed without getting any confirmation, we should probably revert to the known chain state.  (Possibly 60 seconds is a good timeout; it's definitely short-lived but still much longer than a block time).
Removing the notes we consume from the unspent set will prevent them from being used for transactions, so that logic can be unchanged.  However, we should report to the user on the state of their pending balance.  One idea is to add an extra column to our existing table:
 Asset          Balance  Pending
 tungsten_cube  197
 gm             0        -366 +356
 gn             396
 penumbra       44782
 pizza          1863

Here, I sent 10 gm tokens using a single note that recorded 366 of them; the UI shows me that I have none available to spend but 356 will become available soon.
(This touches on a more general problem of note management, and whether we should try to optimize outputs with respect to the current wallet state to make concurrent transactions possible; this is worthwhile but a bit of a rabbithole and I don't think we should try to optimize this any more than we currently do at this time.)

This was closed by #268.


Fixed COLLECT variable validation loophole

Scope & Purpose

Fixed a loophole in COLLECT variable name validation: in COLLECT INTO expressions it was possible to refer to variables that the COLLECT just introduced. This was undefined behavior and not caught by the previous version of COLLECT's variable checking.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[x] integration tests
[ ] resilience tests

[x] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.11: -
[ ] Backport for 3.10: -

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

This will need backports to 3.10 and 3.11


Add support for apple music

Thank you for the pull request! Let me test it out and I'll get back to this :)

Thank you so much for writing the blog by the way. I love the rust programming language and I was looking for a way to write a plugin in rust for neovim. :)

@devanlooches I'm glad you found it useful! Thanks!!
I added a few changes on top of your work, just to deduplicate some code and to make the naming consistent. Tested it out, works well! I'll merge to master, test and release soon.


plugin output size limitation

The plugin is an external binary which may generate very large command line output and will be loaded to memory by notation-go library.
Do we need a plugin output size limitation?

We aligned in the community meeting on 11/11 and finalized that we need pursue with the limitation option. Further discussion how to solution is pending.
Customer should trust the plugin, all of the output should satisfy the requirement and not generate large content. Will it crash if the memory is overloaded. Document security best practices and customer need to define what is the size limit.

Tested on Linux. A very large plugin output triggers the OS to kill the process. We need to fix it.


Using dependencies installed in system

My understanding is that I should be able to use dependencies already installed in my system by modifying Makefile.local. However, if I set for instance
UNIX_PROTOBUF_DIR = /usr
it seems protobuf is still being built by make third_party. Do I need to have all the dependencies to use this option?

Look at all the targets in makefiles/Makefile.third_party.{win/unix}.mk
and launch the missing installers manually.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mar. 2 juil. 2019 à 12:37, LesserBabka<EMAIL_ADDRESS>a
écrit :

My understanding is that I should be able to use dependencies already
installed in my system by modifying Makefile.local. However, if I set for
instance
UNIX_PROTOBUF_DIR = /usr
it seems protobuf is still being built by make third_party. Do I need to
have all the dependencies to use this option?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1390?email_source=notifications&email_token=ACUPL3KNAYJKBGJ5NYJKR63P5MVXZA5CNFSM4H42M7X2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G43FDRA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3JUEHFC6BW6X2KGZI3P5MVXZANCNFSM4H42M7XQ
.

I see, thank you.


Feature/Add-Swapzone.io-to-Dapps-List

Swapzone is a cryptocurrency exchange aggregator. We want to make our integration to your wallet, so that users will be able to exchange their crypto coins and tokens (Swapzone supports over 300 assets) with best rates and prices, custody-free, with no registration needed.

Hi @vrogov we can also add you to our main dapp page; we generally ask that you also list us in your mobile wallet list on your wallet explanation page.
Your website looks like a useful service, although it doesn't seem to pick up the ethereum wallet address if it's running inside the dapp browser. I can add your service in as-is but if you want it on the main dapp page (which is served from here: https://alphawallet.com/browser/) then you might want to make it a little more web3 friendly:

detect you are running in a web3 host
if so, only list EVM tokens (and contracts) as the transfer-from chains (eg Eth, Gnosis, Polygon, Klaytn, USDT etc)
Auto-populate the token address and query user balance


Error

Getting the following error:
(venv) KTEL-MBP-1312:neo4j-playlist-builder djk-tel$ python3 neo4j_spotify_playlist_builder.py
START load graph using spotify api...
b4 create neo4j session...
dropping and creating constraints...
get_tracks...
get_track_audio_featurescks...
Traceback (most recent call last):
File "/Volumes/Panko/zz Programming Transfers/Machine Learning/Neo 4J/neo4j-playlist-builder/neo4j_spotify_playlist_builder.py", line 340, in
load_graph_using_spotify_api()
File "/Volumes/Panko/zz Programming Transfers/Machine Learning/Neo 4J/neo4j-playlist-builder/neo4j_spotify_playlist_builder.py", line 42, in load_graph_using_spotify_api
neo4j.run("UNWIND $tracks as track CREATE (t:Track{id: track.id}) SET t = track", parameters={'tracks': list(tracks.values())})
File "/Volumes/Panko/zz Programming Transfers/Machine Learning/Neo 4J/neo4j-playlist-builder/venv/lib/python3.9/site-packages/neo4j/work/simple.py", line 217, in run
self._autoResult._run(query, parameters, self._config.database, self._config.default_access_mode, self._bookmarks, **kwparameters)
File "/Volumes/Panko/zz Programming Transfers/Machine Learning/Neo 4J/neo4j-playlist-builder/venv/lib/python3.9/site-packages/neo4j/work/result.py", line 101, in _run
self._attach()
File "/Volumes/Panko/zz Programming Transfers/Machine Learning/Neo 4J/neo4j-playlist-builder/venv/lib/python3.9/site-packages/neo4j/work/result.py", line 202, in _attach
self._connection.fetch_message()
File "/Volumes/Panko/zz Programming Transfers/Machine Learning/Neo 4J/neo4j-playlist-builder/venv/lib/python3.9/site-packages/neo4j/io/_bolt4x0.py", line 330, in fetch_message
response.on_failure(summary_metadata or {})
File "/Volumes/Panko/zz Programming Transfers/Machine Learning/Neo 4J/neo4j-playlist-builder/venv/lib/python3.9/site-packages/neo4j/io/_bolt4x0.py", line 529, in on_failure
raise Neo4jError.hydrate(**metadata)
neo4j.exceptions.CypherTypeError: Property values can only be of primitive types or arrays thereof. Encountered: Map{spotify -> String("https://open.spotify.com/track/1MUgIUkMkEzybR9HZnyVmj")}.
any ideas?

I was able to solve the above by fixing bad indentations in the code.  But other issues came up.  Seee next issue