iOS 11 - No response from RequestPermissionsAsync

Bug Information
_await CrossPermissions.Current.RequestPermissionsAsync(Permission.Location);

no response back from this line of code. Can I do something about it with this version of plugin (2.0.1), or do I have to wait till the next release when it will support iOS 11 too ?

Version Number of Plugin: 2.0.1
Device Tested On: iOS 11
Simulator Tested On: iOS 11
Version of VS: 2017 15.3.5
Version of Xamarin: <IP_ADDRESS>
Thanks!

What permissions are in your info plist?

For locations are the following:
        <key>NSLocationAlwaysUsageDescription</key>
	<string>bla bla</string>
	<key>NSLocationWhenInUseUsageDescription</key>
	<string>bla bla</string>
	<key>NSLocationUsageDescription</key>
	<string>bla bla</string>

I experience the same issue. Version 1.2.1 is working fine, on iOS 11 as well.

I see what is going on. This is because you have both permissions for Always and WhenInUse in there. It has to be one or the other.

This is because Apple has a typo in their docs, it is => NSLocationAlwaysAndWhenInUseUsageDescription

I am still getting sam issue in 2.2.1

Hello, I have this same problem in iOS 11.4. I tested in iOS 9.0 and iOS 10.0 and it works OK.
I have the <IP_ADDRESS> version of the plugin
When executing this line: CrossPermissions.Current.RequestPermissionsAsync(Permission.Location); the app not responds.
I try a lot of combinations of permissions in Info.plist but nothing works, and always get the same result.
When I delete all Location permissions from Info.plist the line above raises an Exception where it says that I have to add NSLocationWhenInUseUsageDescription or NSLocationAlwaysUsageDescription to Info.plist. But in my case this not works.

update plist with following
NSLocationWhenInUseUsageDescription
This app needs access location when open.
NSLocationAlwaysUsageDescription
This app needs access to your location.
NSLocationUsageDescription
This app needs access to your location.
NSLocationAlwaysAndWhenInUsageDescription
This app needs access to your location.
NSLocationAlwaysAndWhenInUseUsageDescription
This app needs access to your location.


Angular 2 - Mask not working

ORIGINAL EXCEPTION: No provider for NgControl!
When i put " ngControl " in the component to the provider this error pops up:
EXCEPTION: TypeError: this.ngControl.viewToModelUpdate is not a function
Any solution for this?

I'm assuming, from your other issue, that you found a solution for this? I'll close this, but feel free to reopen if the issue is not solved.


Adjust metrics to new requirements from proposal

Progress

[x] Add new fields
[x] Move SDK to singleton
[x] Expose SDK documentation

I see that you make it possible for users to provide their custom metrics (by implementing MetricsCollectable). I wonder what we can do about default metrics of other SDK modules, say auth. The user could manually add them before sending the metrics. Or maybe there is a way to add them automatically once the module is used?

@pb82 This interface is designed to be used by other SDK's to provide metrics, but this may imply some dependencies. I think we may just provide NSDictionary based  aproach to avoid strict dependency.  I'm in process of creating tickets to kickstart conversations about it. With that in mind MetricsCollectable can become internal interface at some point, but I would like to run that idea with entire team and community first to get more context.

@wtrocki Yes that's the concern: if we want to allow other SDK modules to automatically add their metrics, that requires the interfaces to be part of core and also initializing the SDKs in the right order. Not part of this change however. I  might add a similar abstraction to the Android metrics SDK, but unless we allow user defined metrics there's not really too much use for it.

@pb82 If you take look into master this prototype is used mostly internally in metrics. This prototype will be also used as adaptable for Dictionary payload. I did not want to go into details for this particular PR as there are couple ways we could do it. I think it's best to have some show and tell to get opinions about it considering that options may require some extensive swift knowledge.

@wtrocki Yes agree, we don't have to find a solution for that now.

@wtrocki Apologies for delay in review. I probably can't add much, but looking through the code, it looks reasonable.

@david-martin No problem. Content of this PR got outdated anyway considering out recent changes on server side proposal, but it should be trivial to adjust anyway.


adding an extra setup command to clean builds

@mistercrunch
Part of a clean fix for the revenant egg issue.

:+1:


How can I get the true meaning of states

I have read corresponding paper of this environment. But I am wondering what is the true meaning of each feature. Such as the Cartpole environment, there are four positions and two speeds. I wish to know what is it.

Hi @lich14 . You could take a look at the cartpole.py file, which has the implementation of that environment. From the get_observation method it seems that it returns the "state" given by the bounded_position and velocity methods. I think the velocity method returns the pair of velocities of the two degrees of freedom of your system (1 slide-joint <> cart position, and 1 hinge-joint <> pole angle).
The bounded_position method seems to return the cart_position (which is just 1 value, from qpos[0]), and the last row of the rotation matrix of the pole (given by the xmat[2:,['zz','xz']]. It looks from the signature that it should return only the zz and xz from the last row, but perhaps I'm mistaken. For further reference regarding the elements of the model struct, you could take a look at this reference from the mujoco-API documentation (look for xmat). dm_control exposes bindings of those structs via ctypes, so you can directly map those structs (mainly mjModel and mjData) to the exposed bindings.

What @wpumacay said is correct. xmat[2:,['zz','xz']] corresponds to the sine and cosine of the pole angle. These are more convenient as inputs to neural networks than the raw angle because they are bounded between -1 and 1, and there are no discontinuities when the pole spins > 360° in either direction.


Support for default values in .env

Would it be possible to support syntax of default values in .env files?
As in
DB_HOST=${DB_HOST:-<IP_ADDRESS>:3306}

This can prove very helpful for my usage pattern.

This will not be compatible with the underlying .env file spec, to the best of my knowledge, but I'm considering adding an option to allow variables expansion. Please follow #16 for updates.


The BnP job should be resilient to colo failures, but this has regressed

Adding a safe guard to bring back resilience, in the BnP constructor.

LGTM!

Thanks a lot @gaojieliu. I've merged this in.


Shape Mismatch when playing trained model with image observation

Description
Thanks for this great work!
The issue occurs when trying to play a policy trained using imitation learning in Isaac-orbit. During training, I successfully trained the model with a specific image observation shape of (480, 640, 3), but when I play the model for inference with a frame shape of (480, 640, 3), assertion error (asset frame_input_shape == desired_frame_input_shape) showing a shape mismatch occurs. given that shape of the frame during training and inference is the same.
I have also tried to record and train with different shape of image but it didn't solve.
I wonder how the data is pre-processed when playing the model?
I appreciate your help.
Error log
Traceback (most recent call last):
  File "source/standalone/workflows/robomimic/play.py", line 90, in <module>
    main()
  File "source/standalone/workflows/robomimic/play.py", line 73, in main
    actions = policy(ob=obs)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/robomimic/algo/algo.py", line 518, in __call__
    ac = self.policy.get_action(obs_dict=ob, goal_dict=goal)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/robomimic/algo/bc.py", line 250, in get_action
    return self.nets["policy"](obs_dict, goal_dict=goal_dict)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/robomimic/models/policy_nets.py", line 105, in forward
    actions = super(ActorNetwork, self).forward(obs=obs_dict, goal=goal_dict)["action"]
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/robomimic/models/obs_nets.py", line 584, in forward
    enc_outputs = self.nets["encoder"](**inputs)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/robomimic/models/obs_nets.py", line 445, in forward
    self.nets[obs_group].forward(inputs[obs_group])
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/robomimic/models/obs_nets.py", line 235, in forward
    x = self.obs_nets[k](x)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/aman/Orbit/_isaac_sim/kit/python/lib/python3.7/site-packages/robomimic/models/obs_core.py", line 172, in forward
    assert tuple(inputs.shape)[-ndim:] == tuple(self.input_shape)
AssertionError

Thanks for bringing this issue up. I am not too familiar with how Orbit interfaces with robomimic, so I would suggest posting an issue on their repo as well. However, my best guess is that this is related to image preprocessing operations that should take place when images are loaded from the dataset / from the simulation environment (operations such as changing from uint8 to float, and re-ordering the batch to be channel-first, e.g. B-C-H-W, instead of B-H-W-C - see here)


[Add] Add new animated button

Details
I want to add new animated button
Screenshots
https://github.com/Spyware007/Animating-Buttons/assets/120560129/4f68b2a0-0094-4c88-8513-7e8297f070ae
Type of Contribution

[ ] Update to an existing Animated Button
[X] Adding a new Button
[ ] Resolving a bug
[ ] Proposal to the Repository
[ ] Changes related to documentation or README.md
[ ] Other Changes

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue
[X] I am a GSSoC'23 contributor

Sorry for the inconvinience, but we are closing all the issues! Please open a new issue if you want to contribute anything. Also now you can create a new button from the website itself! You will get points for those too! I will add the instructions on how to create a new button soon and create an empty pr for the same to get points!


[dv/chip] Fix private CI issue

This PR fixes a private CI assertion issue triggered by writing
non-Mubi4True or False value to the extclk_ctrl CSR.
This will eventually trigger an assertion error in AST.
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

Use https://github.com/lowRISC/opentitan/pull/9419 instead


SOLID: Orchestrate docs to go to https://solidcommunity.au/docs/solid

Done. Please review:

[ ] Ninad
[ ] Zheyuan
[ ] Anushka
[ ] Jess


MARC files not getting state of transmitted after send DAG finishes

I am seeing this with OCLC after a successful run today - https://sul-libsys-airflow-prod.stanford.edu/data_export_download/. I believe if I try to run OCLC again, these files will be sent a second time.
But I think it might also be the case for GOBI?

I logged into the prod server and took a look at gobi. I think there is something more going on. It looks like the new files are being moved to transmitted but the updates are not. ANd looking at the logs for the last 2 scheduled runs of send_gobi, it looks like only new files are being sent.
libsys@sul-libsys-airflow-prod:~/libsys-airflow/current/data-export-files/gobi$ ls -l instanceids/updates/
total 17344
-rw-rw-r-- 1 libsys root 4351496 Aug 27 18:14<PHONE_NUMBER>14.csv
-rw-rw-r-- 1 libsys root  817663 Aug 29 08:21<PHONE_NUMBER>21.csv
-rw-rw-r-- 1 libsys root  929773 Sep  3 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root  811817 Sep 10 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root  779997 Sep 17 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root 1054426 Sep 24 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root  898249 Oct  1 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root 1046693 Oct  8 22:32<PHONE_NUMBER>32.csv
-rw-rw-r-- 1 libsys root  674880 Oct 15 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root  977133 Oct 22 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root  720464 Oct 29 22:31<PHONE_NUMBER>31.csv
-rw-rw-r-- 1 libsys root 2697855 Nov  5 22:34<PHONE_NUMBER>34.csv
-rw-rw-r-- 1 libsys root  850704 Nov 12 22:30<PHONE_NUMBER>30.csv
-rw-rw-r-- 1 libsys root 1058089 Nov 19 22:31<PHONE_NUMBER>31.csv
libsys@sul-libsys-airflow-prod:~/libsys-airflow/current/data-export-files/gobi$ ls -l instanceids/new
total 0
libsys@sul-libsys-airflow-prod:~/libsys-airflow/current/data-export-files/gobi$ ls -l marc-files/new/
total 75420
-rw-rw-r-- 1 libsys root 59427040 Aug 27 18:58<PHONE_NUMBER>14.mrc
-rw-rw-r-- 1 libsys root 12124301 Aug 29 08:29<PHONE_NUMBER>21.mrc
-rw-rw-r-- 1 libsys root  5575767 Sep  3 22:36<PHONE_NUMBER>31.mrc
libsys@sul-libsys-airflow-prod:~/libsys-airflow/current/data-export-files/gobi$ ls -l marc-files/updates/
total 684268
-rw-rw-r-- 1 libsys root 177125031 Aug 27 21:29<PHONE_NUMBER>14.mrc
-rw-rw-r-- 1 libsys root  36091559 Aug 29 08:57<PHONE_NUMBER>21.mrc
-rw-rw-r-- 1 libsys root  27605707 Sep  3 23:07<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root  27605434 Sep 10 23:04<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root  39777848 Sep 17 23:10<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root  34345102 Sep 24 23:12<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root  30506618 Oct  1 23:06<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root  56915197 Oct  8 23:21<PHONE_NUMBER>32.mrc
-rw-rw-r-- 1 libsys root  28235660 Oct 15 23:01<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root  40544369 Oct 22 23:10<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root  26405986 Oct 29 23:04<PHONE_NUMBER>31.mrc
-rw-rw-r-- 1 libsys root 112392180 Nov  6 00:24<PHONE_NUMBER>34.mrc
-rw-rw-r-- 1 libsys root  31076083 Nov 12 23:07<PHONE_NUMBER>30.mrc
-rw-rw-r-- 1 libsys root  31265526 Nov 19 23:25<PHONE_NUMBER>31.mrc

Update per slack with Jeremy - for OCLC when there is an error the marc files don't get moved to transmitted directory. We want to change this so that all files get moved to transmitted after DAG run finishes successfully so that the files are not resent during the next run. Staff will remediate the errors and manually resend the record will just get caught up in future processing.

For gobi, we are supposed to only be sending the new files (which is happening correctly). But we still are generating the deletes and updates files, which don't get sent and therefore not moved to transmitted. Maybe we stop generating these files?

I'm going to close this. The merged PR for OCLC addressed the issue. Gobi is another issue and is ticketed.


Prem Daemon does not start

I am using 0.0.25 (20230714.144449)
I can't have the prem daemon running at startup, even clicking on check again seems to not run it anymore
https://www.loom.com/share/1931999b2e804806a7173b389a75afe0?from_recorder=1&focus_title=1

.env vars need to be commented


[REBASED] Update moran.py with much faster iterations

From @andrewxhill, rebasing #732 onto PySAL 1.11.
The rebase still appears to be failing/erroring out on some moran-related tests, but those could just be plumbing issues.

Here is an interesting optimization that @ohasselblad and I have been toying with. Basically, it takes into effect that fact that you are shuffling (at times very large) arrays for every iteration of the loop. When in reality, you should be limiting your necessary shuffle to only the number of permutations or the length of the array, whichever is less.
since it uses the magic of index pointers in numpy, the choice sample will still act across the entire population, while the rids points to that new subsample instead.

So, I'd recommend closing, since it seems sampling without replacement is just as slow as permuting the entire matrix, unless someone has the time to do a more thorough comparison on that choice vs. shuffle performance.

@sjsrey, i believe xun's comment was about 1 line that isn't actually the heart of the enhancement, I fixed that in a commit following,
https://github.com/pysal/pysal/pull/732#issuecomment-170037766
There would be no improvement for small datasets (<1000) but it helps cap out the duration for very large datasets. The core is this,
"Basically, it takes into effect that fact that you are shuffling (at times very large) arrays for every iteration of the loop. When in reality, you should be limiting your necessary shuffle to only the number of permutations or the length of the array, whichever is less."
https://github.com/andrewxhill/pysal/commit/bcb169c7a514095575418948dd569729520c0039#diff-505086ccec22587314a0b60c73239426R682


better flow typings

[BREAKING CHANGE] Using flows in TypeScript should result in improved typings, but it requires TypeScript >= 3.6.2. Check the updated flow section of the documentation to see how to work with them now.
Scheduled for 0.15.0

Coverage increased (+0.02%) to 89.523% when pulling d30c8a4da6e488cde4aa3dcb57c56617a2775f90 on betterFlowTypings into 2dc686af8464d9de3568e6a829d124a1d9f612a2 on master.


Getting the name or username of a user

I have been able to create bots using this framework easily but lately i have been wondering how do i get the name of user or the username.I have gone through the documentation and i cant seem to find how i can do that?I know this is a minimal issue but i would really appreciate if anyone could help me out on this

Every Message contains a User object which has the users first/last name and - if set - a username as well.

I have been able to do it thanks a lot


Time to start processing seconds is too long

It can take a little while to start "processing seconds". It looks to be the step in reco.py of:
packets_io = packets[packets['io_group'] == io]    PPS_indices = np.where((packets_io['packet_type'] == 6) & (packets_io['trigger_type'] == 83))[0]
It's probably because at this point it is looking through the whole packets dataset to find the PPS indices. But if I'm only using a fraction of the data, it shouldn't need to look through the whole dataset.
Is there a way to do this faster?

This is fixed since we now process the data in an arbitrary number of chunks that doesn't depend on the occurrence of PPS pulses.


Hiera not working as expected in different test contexts

Consider the following basic example:
example.pp
class mymodule::example {

  notify { 'hello':
    message => hiera('message', 'Hello, World!'),
  }

}

example_spec.rb:
require 'spec_helper'
require 'hiera'

describe 'mymodule::example' do

  context 'with hiera' do

    let(:hiera_config) { 'spec/fixtures/hiera/hiera.yaml' }
    hiera = Hiera.new(:config => 'spec/fixtures/hiera/hiera.yaml')

    it 'should contain a notify resource that sources its message from hiera' do
      should contain_notify('hello').with({
        'message' => hiera.lookup('message', nil, nil)
      })
    end

  end

  context 'without hiera' do

    it 'should contain a notify resource that falls back on a default message' do
      should contain_notify('hello').with({
        'message' => 'Hello, World!'
      })
    end

  end

end

In this example, one would expect that the hiera_config pointing to spec/fixtures/hiera/hiera.yaml is applicable only to the context 'with hierra,' but in practice, I am finding that is not the case.  So the 'should contain a notify resource that falls back on a default message' is failing and really ought not to.  To be explicit about it, it's failing because it's still getting data from hiera when it's expected not to.
Am I doing something wrong?
EDIT: Also, note that I get similarly odd behavior if I swap the two contexts around so that the test that does not use hiera comes first and the one that does comes second.
Any insight is appreciate.  Or is this a bug?

Closed by #186


Allow passing in class objects for rules + Upgrade to RSpec 3.4 + Misc improvements

New feature allows passing in any rule class instead of requiring it to exist in Validation::Rule:
validator.rule(:field, CustomValidatorClass => { param: :eters }

Also made the code a bit more DRY and upgraded the specs to RSpec 3 syntax.
Oh, and the InvalidKey exception now tells you which key is invalid.

Good change!


Fix build workflow action

Fails on build due to Docker daemon not running:
Couldn't connect to Docker daemon at http+docker://localhost - is it running?

See: https://github.com/Vaalyn/sylius-shop/actions/runs/206382514

Fixed in 8c68bbd587b25ba4ee58acb96eb44cb573735656 and 5cf472212037cac446c0bacf1f93348af31fe28b


Estimate path payment rate two-way

Currently the Find Path method in horizon let us find a path from a source account to a destination account and destination asset.
Though it only allow us to set a destination amount, that allow us to know the sendMax amount to send.
This only permits to estimate an exchange rate on one way.
It would be very nice to have an endpoint, where we can set a source asset, source amount and destination asset and end up with an estimation of the amount of destination asset that will be received.
Maybe it would be a new endpoint because find path does not need to set the source asset.

Any plans to work on that? Would be really useful

There aren't any plans to work on this in the near term @s-a-y, but I will make sure it gets added onto the list of things to work on when I get around to doing another pass on pathfinding.

I could probably try to take a look at it with my team (we are not up to speed with golang) if you confirm there are no technical barriers for implementing this feature @nullstyle

There shouldn't be anything you can't work with @s-a-y, but I figure it will be a pain in the butt to implement...  If you're not familiar with go, you'll probably run into a lot of pain.  The pathfinding is meant to be pluggable and this will be the first big expansion of the interface so there will be some design questions to answer in addition to implementation.
The relevant interfaces are here:  https://github.com/stellar/horizon/blob/master/src/github.com/stellar/horizon/paths/main.go
You'll want to expand that interface to incorporate this change to a two-way system.

Just wanted to +1 this. I've had to use some really nasty hacks to get around this in lupoex.


Could add support for fzy?

fzy is also a fast fuzzy finder, it is faster shows better results  than fzf. I think it is an better choice to use it.

fzy doesn't support --preview-related options.
navi heavily relies on such options.
Until fzy starts supporting these options, I don't plan to add support for fzy.


localizing  (react-router-dom)

Hi,
I'd like to provide links in the translation but they shouldn't reload the page.
Ways I have tried so far:

"goto.homepage": "Go to <Link to='/home'>home page</Link>..."

Translates but it's not clickable.

"goto.homepage": "Go to ${link}..."

Inside component:

  {translate('goto.homepage', {
    link: <Link to='/home'>home page</Link>
  })}

Returns [object Object]

The issue here is <Link/> is not a valid HTML element, but a React element. The library does not currently support Rect elements included in translations, as it is outside the scope of this library.
I'm going to close this issue as it's a duplicate of #46. Please feel free to continue the conversation in that issue.

In the meantime, although not ideal I'd just split your translation strings:
{
  "goto.homepage.prefix" "Go to",
  "goto.homepage.label" "home page",
  "goto.homepage.suffix" "copy that goes after link goes here."
}

// then in your react component

{ translate('goto.homepage.prefix') } <Link to='/home'>{translate('goto.homepage.label')}</Link> { translate('goto.homepage.suffix') }

@ryandrewjohnson thanks for your time. unfortunately that approach won't work for me since the structure of the sentence changes between languages (en, ru, tr).
I've created a child component which is basically a switch statement and returns JSX based on active language. For now it works for 3 languages but the solution won't scale once you have many.


Update annotations for multilingual STS tasks

This PR updates metadata for multilingual STS tasks as they were previously partially filled.
Checklist

[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

@KennethEnevoldsen Would it be helpful if we continue adding missing annotations for other sets? As many original sets are currently missing them. We have some bandwidth to help with other mmteb task. Should we open issue to list other tasks and distribute them among other contributors?

@KennethEnevoldsen we haven't added points for annotated datasets and reviews, can we add them in the next PR?

@KennethEnevoldsen Would it be helpful if we continue adding missing annotations for other sets?

That would be lovely!

@KennethEnevoldsen we haven't added points for annotated datasets and reviews, can we add them in the next PR?

Please do!


Failed compile when Java annotation used as parameter of another Java annotation

Compiler version
Scala 3.3 and 3.4
Minimized code
//> using scala 3.4.0
//> using dep "jakarta.persistence:jakarta.persistence-api:3.1.0"

import jakarta.persistence.*

@Table(indexes=Array(Index(columnList="email")))
class User

Output
$ scala-cli run test.scala
Compiling project (Scala 3.4.0, JVM (20))
[error] ./test.scala:6:22
[error] object Index in package jakarta.persistence does not take parameters
[error] @Table(indexes=Array(Index(columnList="email")))
[error]                      ^^^^^
Error compiling project (Scala 3.4.0, JVM (20))
Compilation failed

Expectation
The code compiles with Scala <= 3.2, but does not compile with higher version of Scala. Expected to be working with Scala 3.4

Ok, so this is weird... So far I didn't manage to minimise it, despite the code from jakarta.persistance being relatively simple, so it may be something specific to the jakarta build.
We'd perhaps need a self-contained minimisation to tell more. (without the jakarta dependency).
The example indeed compiles on Scala 3.2.0, but doesn't on LTS nor on 3.4.0.
However, I wonder if it's a valid bug in the first place.
The following code compiles on 3.4.0:
//> using scala 3.4.0
//> using dep "jakarta.persistence:jakarta.persistence-api:3.1.0"

import jakarta.persistence.Index
import jakarta.persistence.Table

@Table(indexes=Array(new Index(columnList="email")))
class User

So the new keyword seems to be necessary to call the constructor here.
Should it be necessary, however?

@sjrd Would you consider this a valid regression?
Should the new keyword be required when passing an anotation parameter like this?

Yes. Adding a new keyword fixed my problem. Thanks

using local java sources, 3.2.2 also fails to compile.
package trial;

import java.lang.annotation.*;

@Target({})
@Retention(RetentionPolicy.RUNTIME)
public @interface Index {
  String name() default "";

  String columnList();
}

package trial;

import java.lang.annotation.*;

@Target(ElementType.TYPE)
@Retention(RetentionPolicy.RUNTIME)
public @interface Table {
  String name() default "";

  Index[] indexes() default {};
}

using
ThisBuild / compileOrder := CompileOrder.JavaThenScala

makes it compile, which is obviously a bug or limitation.
Nothing works on 3.3.3 or 3.4 except new.
Outside of annotation context, 3.2.2 crashes:
java.util.NoSuchElementException: class String while running genBCode

but 3.3 emits normal error.
That edit of Scala 2 spec on annotations isn't ported yet, but then perhaps "Host-platform Annotations" could be updated. Currently it says it should just work, unless it doesn't.

additional restrictions on the expressions which are valid as annotation arguments

probably doesn't intend to say that you have to use new. Java requires @.
Not sure how incremental compilation faked out javac here:
[success] Total time: 0 s, completed Mar 18, 2024, 9:28:07 PM
[info] compiling 1 Scala source and 1 Java source to .../i19959/target/scala-3.3.3/classes ...
[error] .../i19959/src/main/java/trial/Used.java:5:1: cannot find symbol
[error]   symbol: class Table
[error] Table
[error] .../i19959/src/main/java/trial/Used.java:5:1: cannot find symbol
[error]   symbol: class Index
[error] Index
[error] (Compile / compileIncremental) javac returned non-zero exit code
[error] Total time: 0 s, completed Mar 18, 2024, 9:28:07 PM

You're not supposed to need a new in Scala 3, whether you're in annotations or not. So IMO this is a real regression.

This was actually an intended change, quoting from https://github.com/scala/scala3/pull/16260/commits/3125665da2e9a15d88b1a6006d60e6b14e1bd34a :

This change is not fully backwards source compatible: this is illustrated
by the diffs in tests/run/repeatable/Test_1.scala:
-@FirstLevel_0(Array(Plain_0(4), Plain_0(5)))
+@FirstLevel_0(Array(new Plain_0(4), new Plain_0(5)))
Here, FirstLevel_0 takes an array of Plain_0 annotations as arguments, and in
previous releases of Scala 3 we could put Plain_0(4) in this array without
new. This is because the compiler generates a "constructor proxy" apply method
for classes, but this no longer works since Plain_0 is now a trait. While we
could potentially tweak the constructor proxy logic to handle this case, it
seems simpler to require a new here, both because Scala 2 does it too and
because it ensures that user code that inspects the annotation tree does not
have to deal with constructor proxies.

Given that the current encoding of constructors with annotations is already causing us headaches (https://github.com/scala/scala3/issues/19951#issuecomment-2083782502), it's probably wiser to not make things more complicated by adding constructor proxies in the mix, at least not until #19951 has been fixed.

Okay, so this is blocked by #19951.


Simplify regex some; prevent email addresses such as<EMAIL_ADDRESS>b

Simplify regex some; prevent email addresses such as<EMAIL_ADDRESS>being considered valid.

Fixed by https://github.com/jzaefferer/jquery-validation/pull/143


Don't process container event if host is removed

@ibuildthecloud and @cloudnautique observed a large number (20k+) of unprocessed ContainEventCreates in the load test environment. The number of events was likely a normal side effect of the things Bill was doing while setting up the environment. But now that the environment is stable, those 20k processes are still stuck because of a bug that cause ContainerEventCreates to hang if the associated host is removed.
The fix is to not process the event if the associated host is removed.

Fix isn't merged yet, but will be soon, So, @sangeethah I can't think of a good automated and reproducable validation test  that we could write for this.  However, our load test environment has roughly 25 thousands such containerEvents, so it will be a good test bed for this fix. Think that will suffice?

Since this issue was reported from load test environment , it would be sufficient if we can validate this issue in the same set up.

Verified in loadtest.


the header version in the glfw 3.4 release still says glfw 3.3

I don't know if it is supposed to be that way, but i was trying to use the latest glfw 3.4 as i needed the window hint GLFW_MOUSE_PASSTHROUGH.
when i download the zip file of source, i see that the headers in the include folder still say glfw 3.3 and they don't have the mouse_passthrough hint.

Most likely you link to the wrong glfw version.

OH, i am sorry. it seems i got confused between 3.4 and 3.3.4.  i was looking at the docs of https://www.glfw.org/docs/3.4/window_guide.html#GLFW_MOUSE_PASSTHROUGH_hint
and was using the glfw 3.3.4 libraries. and comparing it to the master branch of the repo which has 3.4 headers. so, i thought the release accidentally included the wrong headers from the previous release.
apologies for wasting your time :(

I was about to say, I didn't think 3.4 had released yet. No worries!


Set up alerts for VSP

This shares common commits with #226 to pull the VSP out into its own template and do the set up to support child templates.

 Set up alerts for VSP


added a note for the default branch search in case of search request

Added the instruction for the user regarding the default behavior of code search in the main branch.
https://portal.microsofticm.com/imp/v3/incidents/incident/494369623/summary

@chcomley
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


analyze_snapshot don't list function offsets

Hi,
The utility analyze_snapshot allows to dump the list functions in a class with their offset, however, in the last release, the functions are no longer shown, even though I can see them present by doing a strings call on the libapp.so file.
Some functions do still show, but external 3rd party dependencies are not.
Maybe @rmacnak-google has some insights on changes to the VM which is causing the analyzer to miss some information?

@3asm how do you produce libapp.so?

With flutter build linux.

My guess would be that this is due to dart-lang/sdk@4c82eb58364335356d56dd377ab0fd2785dc8f11, which pruned class and library dictionaries. Function objects are still floating around but they are not used for dispatch purposes so keeping them in the dictionaries is not really needed.
If this was DWARF stack traces mode then most function objects would be completely gone... You could update analyze_snapshot to iterate the heap to recover function objects - but that would be just a temporary solution because eventually these useless function objects will be gone one way or another.

Got it, thanks @mraleph .
Do you think it would make sense if Dart supported an official utility or API to introspect a Snapshot?
The common use case of security analysis for either finding vulnerabilities or detecting malicious behavior requires patching the runtime to collect that information.

Do you think it would make sense if Dart supported an official utility or API to introspect a Snapshot?

analyze_snapshot is that official utility. We will be happy to accept PR that expose additional information from it that you might find useful.
But as I said: you should not expect (especially for the purpose of detecting malicious behaviour) that usable symbolic information (e.g. function objects) remains in the snapshot. It's extremely easy to remove it by passing --split-debug-info=... to Flutter CLI when building release binaries and we want to eventually make this default.

Got it, thanks @mraleph .


Unable to restart kernel with the default interpreter with the standalone Windows installer

Problem Description
Trying to restart the kernel while using the default interpreter ends in the following being print in the console:
`Exception in thread Thread-8:
Traceback (most recent call last):
  File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\threading.py", line 926, in _bootstrap_inner
  File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\threading.py", line 870, in run
  File "C:\Users\dalth\AppData\Local\Programs\Spyder\pkgs\spyder_kernels\comms\frontendcomm.py", line 124, in poll_thread
    self.poll_one()
  File "C:\Users\dalth\AppData\Local\Programs\Spyder\pkgs\spyder_kernels\comms\frontendcomm.py", line 144, in poll_one
    self._comm_close(msg)
  File "C:\Users\dalth\AppData\Local\Programs\Spyder\pkgs\spyder_kernels\comms\frontendcomm.py", line 241, in _comm_close
    self.close(comm_id)
  File "C:\Users\dalth\AppData\Local\Programs\Spyder\pkgs\spyder_kernels\comms\frontendcomm.py", line 104, in close
    return super(FrontendComm, self).close(comm_id)
  File "C:\Users\dalth\AppData\Local\Programs\Spyder\pkgs\spyder_kernels\comms\commbase.py", line 173, in close
    self._comms[comm_id]['comm'].close()
  File "C:\Users\dalth\AppData\Local\Programs\Spyder\pkgs\ipykernel\comm\comm.py", line 118, in close
    self.kernel.comm_manager.unregister_comm(self)
  File "C:\Users\dalth\AppData\Local\Programs\Spyder\pkgs\ipykernel\comm\manager.py", line 54, in unregister_comm
    comm = self.comms.pop(comm.comm_id)
KeyError: 'b98c76c05e9e11ec8766f8a2d65bae71'

Although sometimes no message is printed but the kernel seems like is dead since when trying to interact with the Variable Explore a message appears:

Checked with a conda installed version and there seems like the kernel restart is working
What steps reproduce the problem?

Try to restart the kernel of the initial IPython Console launched with Spyder

What is the expected output? What do you see instead?
 What happens if you enclose this line
spyder_kernels\comms\commbase.py", line 173

in a try/except KeyError and pass on the error? I think should solve the problem.

Hmm, this is bad news. What happens if you enclose this line
spyder_kernels\comms\commbase.py", line 173
in a try/except KeyError and pass on the error? I think that should solve the problem.

Checked that but the problem persist
Also checked running on debug mode and this is what I'm getting when trying to restart the kernel in the log:
2021-12-17 10:50:58,728 [DEBUG] [traitlets] -> handle_close[f8e51e825f5011ecae9bf8a2d65bae71]({'header': {'msg_id': 'a9c1647a-693217bd498333ac1f3ed0a4_15000_414', 'msg_type': 'comm_close', 'username': 'username', 'session': 'a9c1647a-693217bd498333ac1f3ed0a4', 'date': datetime.datetime(2021, 12, 17, 15, 50, 58, 669705, tzinfo=tzutc()), 'version': '5.3'}, 'msg_id': 'a9c1647a-693217bd498333ac1f3ed0a4_15000_414', 'msg_type': 'comm_close', 'parent_header': {'msg_id': '6de7f0bb-83b363b4ca60eb0bd2794439_2320_155', 'msg_type': 'comm_msg', 'username': 'username', 'session': '6de7f0bb-83b363b4ca60eb0bd2794439', 'date': datetime.datetime(2021, 12, 17, 15, 50, 57, 899579, tzinfo=tzutc()), 'version': '5.3'}, 'metadata': {}, 'content': {'data': {}, 'comm_id': 'f8e51e825f5011ecae9bf8a2d65bae71'}, 'buffers': []})
2021-12-17 10:50:58,911 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:50:59,922 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:51:00,934 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:51:01,939 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:51:02,945 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:51:03,945 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:51:04,940 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:51:05,954 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std
2021-12-17 10:51:06,970 [DEBUG] [spyder_kernels.comms.commbase] -> Call to unconnected comm: flush_std

This would be solved by https://github.com/spyder-ide/spyder/pull/16890 I think

Trying to restart the kernel while using the default interpreter ends in the following being print in the console

This is going to be fixed when spyder-ide/spyder-kernels#362 is merged.


[Accessibility]A11y_VSCode_ConfigureDefaultBuildTask_ScreenReader:Jaws is not reading the placeholder text.

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
ScreenReader,,[JAWS18.0.5038],MAS1.3.1
Repro Steps:
Launch VS Code.
Navigate   to Tasks(Alt+T) menu option and select "Configure Default Build   Task" from dropdown.
Observe what Jaws reads.
Actual:
Jaws is not reading the placeholder text.
Same issue observed in JAWS also.
Expected:
Jaws is not reading the placeholder text.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
The user will not be able to know the reference.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Does this issue occur when all extensions are disabled?: Yes
Attachment for Reference
configure.pptx

Closing this issue as it's only observed in JAWS, and this isn't strictly needed to meet MAS C compliance.


feat(module:upload): add nzTransformFile, nzDownload and nzPreviewFile properties

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4051 #4339
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@cipchk Please rebase master.


fix: change our duration metrics key to prepare otel's impl

closing as in favour of https://github.com/einride/cloudrunner-go/pull/338


Drop postresql from the brewfile

It seems like we don't need it, and it's failing the Mac build
Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Seems we do need it after all. Closing.


intellij IDEA CE 2020.3 not support

In intellij IDEA CE 2020.3 Plugins market not found the plugin， maybe not support 2020.3

Same here, I couldn't find the plugin.
IntelliJ IDEA 2020.3 (Ultimate Edition)
Build #IU-203.5981.155, built on November 30, 2020
Runtime version: 11.0.9+11-b1145.21 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0

Same here, I couldn't find the plugin.
IntelliJ IDEA 2020.3 (Ultimate Edition)
Build #IU-203.5981.155, built on November 30, 2020
Runtime version: 11.0.9+11-b1145.21 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0

Great! Solved!

Great! Solved!

Found plugin! Thanks!


Create 15. 3Sum

added sum15 of leetcode to improve your database
Pull Request Template
What have you Changed(must)
Write here what you have changed in the codebase
Issue no.(must) -
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[ ] This issue was assigned to me if not it will be marked as spam.
[ ] My file is in the proper folder
[ ] I am following clean code and Documentation.
[ ] I have added the title and what program will do first in the file
[ ] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

@suchetkochhar you have to mention the issue number in the PR Body. Please go through the contribution guidelines.


[main site] two small fixes

1 - Update suggested query that currently shows low confidence results
2 - Add topic to the page title of Explore landing pages

1 - Update suggested query that currently shows low confidence results 2 - Add topic to the page title of Explore landing pages

Quick sanity -- got a screenshot for how (2) looks?

Here's a screenshot (mostly won't be visible to users but better for analytics, finding a tab among many, etc)


Extended AUParameterTree with a subscript method

Wow, this is gorgeous, assuming it passes Travis, I'll merge it right away!  Thanks!

  I'll do that

Oh yeah, sorry, I'll start using the develop branch more.


Add option to use html a tag links instead of markdown

Option to use HTML links
I originally introduced this because the markdown escaping wasn't working well for me. That appears to have been fixed, but I still personally prefer the simplicity of how HTML links are shown:

Test link: https://gist.github.com/wyne/c28ccbe46e47f488946304cfcac03a8d
Comparison

HTML Links Off
HTML Links On

Settings

Fetching

Active (editing current line)

View (not editing current line)

Ah interesting! Do you find that you always use html links or that you need to swap between the two?
I'm wondering if being able to bind an additional button to a specific type of paste would be useful here as well, so you can use one hotkey to paste markdown and another hotkey to paste html.

Updated description.
I originally introduced this because the markdown escaping wasn't working well for me. That appears to have been fixed, but I still personally prefer the simplicity of how HTML links are shown.


Improve the "We cannot connect to the Extensions Marketplace at this time" message

Issue Type: Feature Request
Many GH issues currently being opened about this message are from people using a VS Code build which doesn't point to marketplace.visualstudio.com

I suggest the error message is extended so it reports the URL it was trying to connect to,
VS Code version: Code - Insiders 1.59.0-insider (04485223ebc6a075f39966bf9b3e261359ac7818, 2021-07-23T19:21:12.120Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

My suggestion: change the text into "We cannot find any extension related to 'xxx'. Please check your spelling and try again."

@vscodebot I'm afraid these two issues arn't the same. :-/

/duplicate
https://github.com/microsoft/vscode/issues/119375

@sandy081 I don't think this is a duplicate of the one you referenced. In this one I am suggesting you enhance the text of the "cannot connect" message so it shows us whether the connection attempt was to the Microsoft Marketplace or to another one.

@gjsjohnmurray Fix in the other issue, I changed it to show the real cause of the error instead of this general message. So now, user will know what is the real error and understand and share it while filing an issue.


Why parse the body instead of stream?

Neat thing @mranney @Raynos! I was reading the code and I was wondering why you read the body instead of streaming?
My guess was because the use-case it was to optimize the 80% web application use-case for sending tiny amounts of JSON or msgpack, but wanted to hear from the horse's mouth :horse: :horse_racing:

@indexzero For simplicity we wanted to implement a subset of HTTP for our proxying need.
We have an internal HTTP framework that does not support streaming. It was easier to verify correctness if we just parsed the entire HTTP request.
We will actually deprecate proxying HTTP over ringpop+tchannel in the future and instead support forwarding tchannel messages over ringpop.
There are other technical reasons for body parsing. Our body parsing library has an internal cache. If you are trying to shared an incoming HTTP request over ringpop and need to read the body to compute the shard key, you would have to parse it before passing it to ringpop. This means ringpop either needs to be given the body to send or use a body parsing library with a build in cache. We choose the latter.

Thanks @Raynos that makes a lot of sense. I saw the cache in body when I was reading that code too.


Getting none response from slack for large workspace

Description
I am getting below error , when I try to post something in my slack channel, where slackclient is catching no channel exist for existing channel.
What type of issue is this? (place an x in one of the [ ])

[X ] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[ x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[ x] I've read and agree to the Code of Conduct.
[ x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
slackclient version: 1.3.1
python version:  python 3.7
OS version(s):  Mac
Steps to reproduce:

use errbot to connect large slack workspace, using rtm_connect instead of rtm_start
try to chat with slack app using slack channel
https://github.com/errbotio/errbot

Expected result:
As per documentation, I should get response of hello. when I try to connect
Actual result:
Traceback (most recent call last):
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 419, in _dispatch_slack_message
event_handler(message)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 516, in _message_event_handler
msg.frm = SlackRoomOccupant(self.sc, user, event['channel'], bot=self)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 195, in init
self._room = SlackRoom(channelid=channelid, bot=bot)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 1042, in init
self.name = bot.channelid_to_channelname(channelid)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 553, in channelid_to_channelname
raise RoomDoesNotExistError(f'No channel with ID {id} exists.')
errbot.backends.base.RoomDoesNotExistError: No channel with ID CHDRY5 exists.
What actually happened
Attachments:
Traceback (most recent call last):
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 419, in _dispatch_slack_message
event_handler(message)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 516, in _message_event_handler
msg.frm = SlackRoomOccupant(self.sc, user, event['channel'], bot=self)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 195, in init
self._room = SlackRoom(channelid=channelid, bot=bot)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 1042, in init
self.name = bot.channelid_to_channelname(channelid)
File "/Users/s0m02l2/Git/lazypanda/errbot/.errbot-ve/lib/python3.7/site-packages/errbot/backends/slack.py", line 553, in channelid_to_channelname
raise RoomDoesNotExistError(f'No channel with ID {id} exists.')
errbot.backends.base.RoomDoesNotExistError: No channel with ID CHDRY5 exists.

Hey @codingmaths,
I've been looking into this and it looks like this may be an issue with the Errbot package and its not waiting for the connection to finish before attempting to grab the channel ID. It does seem similar to the issue you posted in https://github.com/skoczen/will/issues/409 so I'd suggest checking with the team at https://github.com/errbotio/errbot to see if they can check further. Our Channel ID does look like its in the right format, just a few characters short.
Have you used our RTM client on its own without the Errbot library to see if it still occurs?

@splinterific I realised the issue, it's due to rtm.connect which is not responding with channel details, that's why I am getting this error.
Also my further observation:
I am trying to connect errbot/opsdroid/will chatbot with our slack workspace. But I am getting same error with all the chatbots . when I tried same code and chatbot with smaller slack workspace, it’s working as expected. With more troubleshoot I got to know it’s some kind of issue with large slack workspace , when they use rtm.start , since my chatbot also needs the channel related details I can’t use rtm.connect here.
with my experience I am able to authenticate app with slack but after that I am not getting any response from slack app. Instead I am getting none.
Please refer below log for same:
  DEBUG    errbot.bootstrap          Start serving commands from the slack backend.
23:22:12 INFO     errbot.backends.slack     Verifying authentication token 23:22:12 DEBUG    urllib3.connectionpool    Starting new HTTPS connection (1): slack.com:443
`23:22:13 DEBUG    urllib3.connectionpool    https://slack.com:443 "POST /api/auth.test HTTP/1.1" 200 146.              ## successfully authenticated
23:22:13 DEBUG    errbot.backends.slack     Token accepted 23:22:13 INFO     errbot.backends.slack     Connecting to Slack real-time-messaging API
23:22:13 DEBUG    urllib3.connectionpool    Starting new HTTPS connection (1): slack.com:443 23:22:35 DEBUG    urllib3.connectionpool    https://slack.com:443 "POST /api/rtm.start HTTP/1.1" 200 None.        ## Getting none response
23:22:48 DEBUG    root                      RTM connected
`
Let me know if you need any other detail from me.

@codingmaths , if you do use the Python-Slackclient on its own (without a wrapped library like Errbot/willbot), do you still see the same issue using rtm.connect()?

Its been a while since we heard back so I'm going to close this out @codingmaths , if you do continue to have issues without using that library, do let us know!

I using errbotv5.2 and slackclientv1.3.1, because our slack is huge, so rtm.start is naturally more difficult to use with Enterprise Grid and other large workspaces.
We often got the rtm_read error, after troubleshooting, we find out the bottleneck is CPU, old instance type is t3a.medium, which is often crash at errbot restart and need to wait for 6 mins to pull information from slack.
After the change to c5.large, I test 3 times restart just now, no crash anymore, faster to pull information from slack, only 4 mins


daemon: Fatal on incompatible host firewall options

See commits for details.
In particular, the message of the second commit, which disallows per-endpoint routes with the host firewall, discusses an alternative:

Per-endpoint routes is a recommended setting in some cases (e.g., GKE).
In such cases, it would be possible to have a partial host firewall
enforcement, with all traffic to and from pods whitelisted. The host
firewall would then only enforce policies on packets to and from world on
the native devices (likely the first use case for the host firewall).
This commit does not implement this second approach and prefers to forbid
per-endpoint routes with the host firewall because a partial enforcement
would likely be confusing to users.

Updates: #11799
Fatal if the host firewall is used without remote node identities
Fatal if the host firewall is used with per-endpoint routes

test-me-please

test-me-please

Coverage decreased (-0.0006%) to 36.963% when pulling ba966a47664bf2bbee07efe59d41e47eaf27e20e on pr/pchaigno/fatal-incompatible-host-fw-options into 89fe06592507016cb079d3ad8308e8620be562d9 on master.

test-me-please

@brb Thanks for the review! Yep, supporting per-endpoint routes is definitely on the TODO for the host firewall. I just don't think it's something that we'll be able to backport, hence this temporary "solution".


GT-precision calculation

After analyzing the above results, how to calculate GT-F1, GT-recall, GT-precision

Formulas for the metrics and gt_matrix table structure are described in the wiki. Your table shows

compGT
(1,1)
(0,1)

baseGT

(1,1)
4305
3178

(0,1)
4
1667

If you define TP as compGT == baseGT - you get 4305 + 1667 = 5972.
The difficulty for applying the metrics to FN/FP genotypes is they're symmetrical since every baseGT has a compGT to compare to. But you could say FN/FP counts are 3178 + 4 = 3182.  Plugging these totals in gives 0.652392397 precision and recall.
Because of this symmetrical FN/FP, Truvari reports the summary metric as gt_concordance:
"TP-comp_TP-gt" / ("TP-comp_TP-gt"+ "TP-comp_FP-gt") Which is also 0.652392397

Precision = TP / (TP + FP)
"Can we understand this as GT-precision = 0.652392397?"
Recall = TP / (TP + FN)
How to calculate GT-Fn？
How to calculate GT-recall?

Please see previous post. Or just use gt_concrdance.


dylib outputs required for TARGET when cross-compiling with syntax extension

When you list a syntax extension as a cargo dependency, even with plugin = true, if your chosen target doesn't have dylib outputs available, cargo will complain even if the target being built is a staticlib/executable.
This isn't working as intended, right?
For an example, try compiling the zinc (root crate) with --target=thumbv7m-none-eabi from mcoffin/zinc@ac834f2debf3df1ef763d10d4b208e160537f687 which depends on the syntax extension crate ioreg from the same project. The syntax extension crate is correctly compiled for the host architecture, but cargo gives an error after compilation about dylib outputs not being available for thumbv7m-none-eabi (which is correct, but shouldn't matter).

Hm it could be that Cargo is mixing up a host/target triple somewhere, could you gist the full error logs of a compile?

Here's the full log, though spectacularly uninteresting: https://gist.github.com/mcoffin/fdc1358787dea6ca570b
I actually didn't think to check if it actually built the archive until just now (it does). I just saw the error and assumed it didn't. The error is given afterwards for some reason.

Hm ok, I think I've found the issue but I'm not quite sure if it'll fix the bug you found, could you try out this branch of cargo and see if it works for you?

Hi @alexcrichton, I have been working on zinc as well and tried your branch and it does appear to fix the issue that @mcoffin reported.

@alexcrichton @posborne Works for me as well.

Excellent, thanks for testing @posborne and @mcoffin! I've submitted #1617 now


[BottomNavigation] Migration of bottom-navigation component

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Migration of BottomNavigation component for next branch.
I have added a showLabel prop since google say "If there are four or five actions, display inactive views as icons only".
Example of demo page:

Closes #5143.

@pradel I have two more feedbacks:

I'm wondering if we should delegate the index callback to the parent element.
That's what we are doing on the <Tabs /> element. We could call it something like onChangeIndex
I see two advantages: 1. Prevent work when the same index is selected, 2. Reduce code duplication.
The keyboard accessibility isn't great. Technically the focus is working but we don't have any visual feedback. I couldn't figured out why quickly. @nathanmarks Any clue?

Aside from that, great work 👍 .

@oliviertassinari I will check out the accessibility side of things 👍

I still need to pull this and check the changes out in the browser + review accessibility but looking good so far

@oliviertassinari What about naming consistency? For eg--we have StepButton. Should this be BottomNavigationButton instead of BottomNavigationItem?

AFAIK they can only be buttons anyways

So should I name it BottomNavigationButton ?

@oliviertassinari should I change logic with onChangeIndex ?

should I name it BottomNavigationButton
should I change the logic with onChangeIndex ?

I would vote for those changes, yes.

I moved the logic to parent with onChangeIndex prop.
I added some tests for the logic and now the coverage is 100%.

@oliviertassinari So I made changes according to your last review. Is that what you had in mind for onChangeIndex?

I moved BottomNavigationButton to class to avoid allocation function and I added the docs

@nathanmarks @oliviertassinari Any update on this?

@pradel I'm continuing this PR to bring in into next :).

Great thanks ! 👍


Reworked structure & added test build to PRs

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #343
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Does this PR introduce a breaking change?
No.
Most important changes
The GitHub Actions now all trigger on PR and on merge.
The test image and main image now have different labels (test and latest).
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
[ ] New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

Summary by CodeRabbit

New Features

Introduced a separate build process for pull requests to enhance testing before merging.
Added conditional checks to comment simulation results on pull requests.

Bug Fixes

Improved workflow triggers for code formatting and linting to run on both pull requests and direct pushes to the main branch.

Documentation

Updated workflow configurations for clarity and improved functionality.

The duplicate workflows are triggered because they are still in the main branch.
After merging this will be fixed and only the actions in the required section will run.


Migration tool not being installed

When running notary server and signer using docker-compose up, the following errors are thrown:
signer_1  | waiting for mysql://signer@tcp(mysql:3306)/notarysigner to come up.
signer_1  | ./migrations/migrate.sh: line 63: migrate: not found
signer_1  | notarysigner database failed to come up within 30 seconds
notary_signer_1 exited with code 1
server_1  | waiting for mysql://server@tcp(mysql:3306)/notaryserver to come up.
server_1  | ./migrations/migrate.sh: line 63: migrate: not found
server_1  | notaryserver database failed to come up within 30 seconds
notary_server_1 exited with code 1

Turns out that the migrate package has released a new version, v3.0.0.
In signer.Dockerfile and server.Dockerfile, it is being installed:
# Install SQL DB migration tool
RUN go get github.com/mattes/migrate

But can't find migrate at $GOPATH/bin

fix in #1140


Emmet: html:5 and html:xml snippets don't work

Related to #25358
In an HTML file, type html. There are three suggestions. Two of them are html:5 and html:xml. Their description indicates that they are snippets. When selecting them, all you get is literally html:5 and html:xml and not what they initially indicated.
The snippets are only expanded if html:5 or html:xml is already in the buffer.

See https://github.com/Microsoft/vscode/issues/25438#issuecomment-297494370 for the difference in the first item in the suggestion list and the rest.
For a user, the difference is not obvious.
I'll see what can be done.

@sergeche this is similar to what you have in the atom plugin.
It will not be clear to the user why the first item if chosen will expand the abbreviation, but the rest will just fill in the abbreviation itself.
One solution is to expand the abbreviation even for the latter group.
Take for example: ul>li>a
The first item will show the expansion for ul>li>a (current behavior)
Then you have items like a:link, a:mail, area etc.
If area is chosen, then the abbreviation ul>li>area should be expanded.
If the user didn't mean to expand yet and wanted to continue writing the abbreviation, they can always undo, and keep typing.
Thoughts?

The first completion should clearly say that it will expand abbreviation while all other completions are just a list of predefined snippets so user can use them to build a larger abbreviation, e.g. !>link:im*3+bq>p. They should display their expanded version so user can see what exactly this predefined abbreviation will output.
This is one of the UX problem I need to think about

How about this?

Is it possible to change icon for the first completion? And I’d also change ul>li>a snippet title to Expand ul>li>a to clearly state the intention

The first item in the above cases is really in fact a snippet.
I could set the kind to "snippet" and that would give a different icon and help in this current issue.
But this will affect the sorting and will work best if the editor.snippetSuggestions setting is set to inline or top
I'll look into it more and get back

For now I'll update the title to Expand Emmet Abbreviation and Complete Emmet Abbreviation

Alright, added a different icon by giving the first item a different CompletionItemKind which is a hack really.

Great fix @ramya-rao-a !


when change the month, everything(color, bound, text) be changed!

The following informations are requested in a bug report

A brief bug description.

look my video

Stack trace.
no error , crach

Device modal and iOS version.
iPhone SE

Xcode version.
Xcode 11.4.1

FSCalendar version.
when i install it by cocoapod, i did't write version. so it will be latest version.

my code is changed backgoundColor when, the Cell is clicked. problem is color change after change month. please look video and help me.

    func calendar(_ calendar: FSCalendar, didSelect date: Date, at monthPosition: FSCalendarMonthPosition) {

       self.calendar.deselect(date)
        self.calendar.cell(for: date, at: monthPosition)?.backgroundColor = SegmentedBarColor[SegmentedControl.selectedSegmentIndex]

    }

my guess, because of reusing FScalendar Cell. how can i figure  out?

Nice guess. You should store your selection state, configure it in cellForDate:, and then reload the cell.


Use PYBIND11_EXPORT instead of visibility hack

Instead of tweaking the default visibility (#5936), this PR applies PYBIND11_EXPORT to relevant classes, as suggested in https://github.com/pybind/pybind11/issues/1272#issuecomment-364132532.

Jenkins, test this please.

Jenkins CI test (for commit d27326eb7de6c0f12640bd716a02f8a5f8588d79, target branch master) succeeded!

Thanks, it LGTM. Let me just rerun the CI.
Jenkins, test this please.

Jenkins CI test (for commit d27326eb7de6c0f12640bd716a02f8a5f8588d79, target branch master) succeeded!


sorting algorithm added

Related Issue
Fixes : #605
Description
added 7 files and added in section of sorting algorithms

selection sort
insertion sort
merge sort
bubble sort
quick sort
counting sort
category.json

All files including these section

Intution
Steps of algo
Image/GIF for visulization
psuedo code
cpp,python,java,js implementation
practical consideration
time complexity
conclusion

Type of PR

[x] Feature enhancement
[x] Documentation update

Screenshots / Videos (if applicable)

Checklist

[x] I have performed a self-review of my code.
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Resources for Guidance
Here are some resources that may be helpful as you contribute to CodeHarborHub:

Code Harbor Hub Community Features
Docusaurus Documentation
React.js Documentation
Markdown Guide
MDX Documentation
Mermaid Documentation

Resources for DSA Features on Our Site:

Tabs: Switch Languages
Line Numbering
Math Equations

@Ajay-Dhangar
added whole section of sorting including 6 md file + 1 category
kindly look over chages
give give label what it deserves
thank you for giving opportunity

@Ajay-Dhangar
can you please add labels  og gssoc and level


fix IBM Model 1 comparison of incomparable types

PS: This produces the same result as on python2 before the fix.  I am reading up on how to verify if this is indeed correct. Will confirm when done. If someone has expertise on text alignment, please do the  needful
#986

Thanks @sahutd. I believe this is now outdated by @hoontw's work on the ibm modules.


SITL: Enable online model look-up in gazebo..

This solves https://github.com/wingtra/sitl_gazebo/issues/9.
Can be reverted locally if automatic model look-up causes any problems..

Thanks! Please try to rebase instead of merging. Your single commit comes with 4 merge commits. I will cherry-pick it instead.


Allow configuration of commands in .code-workspace file and project settings file

First of all, thank you for this great extension!
Currently, new commands can be defined in the user settings file (settings.json), but not in a project settings.json file or in a .code-workspace file. I think the scope property of the findInCurrentFile object in package.json is responsible for that constraint. I tried to change it from machine to machine-overridable which removed that limitation while everything still seemed to work. Are there any downsides to that approach? If not, could you incorporate the necessary changes?
https://github.com/ArturoDent/find-and-transform/blob/a780991fd04287d9d753270ac090ec52bdabd961/package.json#L110

This is a good suggestion.  My testing shows no problems, although it is a little ugly if the same command with a long title appears in both the User and Workspace settings but they both work as expected.
I am working on a couple of other changes so I'll make this scope change soon.
Thanks.

That's great, thanks!

v4.7.1 is out with the change.  Let me know if it works as you wanted.  Thanks.

Thanks, works like a charm.


Queries cannot end with ;

Steps To Reproduce
In markdown
```sql test
SELECT 1;
```

Expected Behavior
Query Runs
Actual Behaviour
Parser Error: syntax error at or near ";" LINE XX: SELECT 1;) AS "__userQuery"

Workarounds
Don't terminate your Queries with ;

3 ideas for this:

Use json_serialize_sql to rip out the comments and semicolons

Upsides:

Not hacky
Shouldn't be any edge cases

Downsides:

json extension required (adds to bundle size, download times)
Need to introduce extra back and forth between client and duckdb (alternatively done at buildtime and introduce duckdb dependency in preprocess

Use regex to remove comments, then simply remove any trailing semicolons

Upsides:

Fast
Easy

Downsides:

Edge cases introduced (-- or /* */ in queries, comments within comments?)

@ItsMeBrianD any thoughts on which way to go and/or alternatives?


Match new RIK workload definition

Context
Previously, we decided to do some changes into the workload definition (api_version into apiVersion). The change hasn't been made into our CLI tool, making it unusable
What needs to be done ?

Migrate api_version field to apiVersion: #68
Migrate Workload definition to crates/definitions crate
Improve testing coverage of the CLI with simple fixtures (either json file or json string in test's code)

Reopen as not fully completed by PRs


Give preference to OpenJDK 17

When installing the javino it is preferable to install the OpenJDK 17.  This version is mandatory in projects with Velluscinum or JaCaMo-CLI.

Solved in the commit -> [d8b5d8731e4baeed0067fd1a8bacd66f9358152f]


Warning: dropdown menu appears on extreme left when used with SmartMenus plugin

Bootstrap 3 dropped support for SubMenu's, so we adopted the JQuery SmartMenus v1.0.0-beta1 plugin, which has a Bootstrap add-on.
When experimenting with YAMM3, our dropdown menus kept appearing on the extreme left underneath the navbar, instead of directly under the clicked menu item. When disabling JQuery SmartMenus, this no longer occurred.
It seems the SmartMenu positions the dropdown menu dynamically, interfering with YAMM.
Not sure whether the use of both plugins is possible; just submitting this issue so others can find it when their dropdown menu's keep on appearing on the extreme left :smile:

Thanks for sharing this!


Feat: Adds Announcement API

Description
Added Announcements.kt and Reaction.kt entities and added AnnouncementMethods.kt method so far. Need to get these steps reviewed
Closes #300
Type of Change
(Keep the one that applies, remove the rest)

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tested using
./gradleew check
Mandatory Checklist

[x] My change follows the projects coding style
[x] I ran gradle check and there were no errors reported
[x] I have performed a self-review of my code
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Optional Things To Check

I have updated the endpoint in the MastodonClient

So I just wanted to know if I am going in the right direction
Also in this link https://docs.joinmastodon.org/entities/Announcement/#mentions, it is mentioned that the type of mentions is an array Announcements::Account and similarly for statuses. So should I make nested classes for Account and Status inside Announcement class (Similar to Poll.kt in entity? Or can I just use the pre existing Account and Status classes?

In this case I would create two new nested data classes. Looking at the documentation, classes are named Announcement::Status and Announcement::Account. I presume they did that to highlight the fact that is not the same as the regular classes we already have.

Also congrats from my side to your first PR 🙂

So what should my next steps be? I have so far:

Made the entities for Announcement.kt and Reaction.kt
Made the methods in AnnouncementMethods.kt
Added the nested classes for Account and Status in Announcement.kt
Added the api in MastodonClient.kt

@AnuraagReddy123 Please add an RxJava3 implementation for the AnnouncementMethods (RxAnnouncementMethods in bigbone-rx). You can check out #301 for an example of how this might look. 😊
For methods that return a value, use Single.fromCallable { YOUR_METHOD_CALL().execute() } and for methods that don’t return a value, use Completable.fromAction { YOUR_METHOD_CALL() }
Please also add tests at least for the AnnouncementMethods. It’s fine if you don’t have them for the Rx variant.

The RxCusotmEmojisMethods.kt has the method implemented as
https://github.com/andregasser/bigbone/blob/e40be4915a7904de6f4ed5414760cbca8edb438c/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxCustomEmojisMethods.kt#L22-L24
whereas in RxNotificationMethod.kt it is wrapped inside try-catch block
https://github.com/andregasser/bigbone/blob/e40be4915a7904de6f4ed5414760cbca8edb438c/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxNotificationMethods.kt#L20-L32
Since the getAllAnnouncements method is very similar to the getAllNotifications method, I was thinking I should implement it how it is given in getAllNotifications, which one would you suggest? Also some doubts I had:

What exactly are the Single and Completable class
What are the differences between the bigbone-rx and bigbone modules?

@AnuraagReddy123 Please use the shorter version. See https://github.com/andregasser/bigbone/pull/288 for more info on that one. 😊
Single and Completable are two of the base types of RxJava. Others are Observable, Maybe, and Flowable (plus Publisher and Subject).
RxJava is the Java implementation of the Reactive Extensions (pattern) which allow stream-based processing of data (very simplified).
see https://github.com/ReactiveX/RxJava

For methods that return a value, use Single.fromCallable { YOUR_METHOD_CALL().execute() } and for methods that don’t return a value, use Completable.fromAction { YOUR_METHOD_CALL() }

Just a small doubt why are we doing the .execute() code part only for the Single.fromCallable function and not for Completable.fromAction function?
Also I have implemented the RxAnnouncementMethods.kt file, however I am a bit doubtful if the code is completely correct or not. @PattaFeuFeu can you please check it?
And finally how do I implement the test files? Going through the NotificationMethodsTest.kt, I got a general idea of how it can be implemented, but how exactly do I "test" if it is working? Like how do I run the test file?

Just a small doubt why are we doing the .execute() code part only for the Single.fromCallable function and not for Completable.fromAction function?

Sure thing, thanks for asking. 😊
For the methods that return a MastodonRequest, we’ll need to call execute() on them to actually execute the network call. Otherwise, you would return a Single<MastodonRequest<TYPE>> and not a Single<TYPE>. When calling execute(), internally a pretty similar code as in client.performRequest is called.
For the methods that call performAction and return Unit (i.e.: “nothing”), we don’t need that as performAction already executes a network call.
That’s why we need to call Single.fromCallable { ….execute() } but Completable.fromAction { client.performAction(…) }.

Also I have implemented the RxAnnouncementMethods.kt file, however I am a bit doubtful if the code is completely correct or not. @PattaFeuFeu can you please check it?

Yep, will do! 😊

And finally how do I implement the test files? Going through the NotificationMethodsTest.kt, I got a general idea of how it can be implemented, but how exactly do I "test" if it is working? Like how do I run the test file?

Not sure how it’s done in VSCode. In IntelliJ, you have a “play” button right next to each test and next to the test class:

You can probably google for “VSCode kotlin unit test” or something of that ilk.
But if you call gradle check, tests will also be executed.
You can try that out by starting with a test test that will just verify that your tests are ran:
import org.amshove.kluent.shouldBeTrue
import org.junit.jupiter.api.Test

class AnnouncementMethodsTest {

    @Test
    fun `just a test-test`() {
        false.shouldBeTrue()
    }
}

That test should of course fail then.

Also what should the tests be? I thought I had to just verify each function in AnnouncementMethods.kt but in CustomEmojisMethodsTest.kt
https://github.com/andregasser/bigbone/blob/master/bigbone/src/test/kotlin/social/bigbone/api/method/CustomEmojisMethodsTest.kt
and NotificationMethodsTest.kt
https://github.com/andregasser/bigbone/blob/master/bigbone/src/test/kotlin/social/bigbone/api/method/NotificationMethodsTest.kt
the functions seemed random. So should I randomly write some test functions or is there a list of some test functions somewhere?

Sorry if the question is a bit simple, I haven't implemented test cases or used junit before 😅

They should test the happy path and a few potential error cases. For the methods, there always is a JSON response in the documentation. We copy that into a file in the test assets, reference that file in tests, and then write asserts to ensure that a) the correct method is called, b) the deserialisation works correctly (check for specific properties in the JSON, they should be in the return value of the function if everything went right).
The unhappy paths can be tested by either returning an error in the mock client, or supplying wrong data in case of methods where we have client-side validation (not the case for your PR as far as I have seen).

@AnuraagReddy123 Did that clarify it a bit? 😊

So I tried running the test on Intellij for AnnounementMethodsTest.kt
class AnnouncementMethodsTest {     @Test     funjust a test-test() {         true.shouldBeTrue()     } }
The test case passed

However for CustomEmojisMethodsTest.kt, for the function at
https://github.com/andregasser/bigbone/blob/c9567d12d28ab534a4a335d85dc3cedb560e368b/bigbone/src/test/kotlin/social/bigbone/api/method/CustomEmojisMethodsTest.kt#L15-L39
I get the following error
> Task :bigbone:processTestResources NO-SOURCE
> Task :bigbone:testClasses UP-TO-DATE

java.lang.ExceptionInInitializerError
	at social.bigbone.testtool.MockClient.mock(MockClient.kt:138)
	at social.bigbone.testtool.MockClient.mock$default(MockClient.kt:19)
	at social.bigbone.api.method.CustomEmojisMethodsTest.Given a client returning success, when getting all custom emoji, then expect values of response(CustomEmojisMethodsTest.kt:17)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at java.util.ArrayList.forEach(Unknown Source)
	at java.util.ArrayList.forEach(Unknown Source)
Caused by: java.lang.IllegalStateException: No compatible attachment provider is available
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:627)
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:611)
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:563)
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:540)
	at io.mockk.proxy.jvm.JvmMockKAgentFactory.initInstrumentation(JvmMockKAgentFactory.kt:128)
	at io.mockk.proxy.jvm.JvmMockKAgentFactory.init(JvmMockKAgentFactory.kt:34)
	at io.mockk.impl.JvmMockKGateway.<init>(JvmMockKGateway.kt:46)
	at io.mockk.impl.JvmMockKGateway.<clinit>(JvmMockKGateway.kt:185)
	... 6 more

No compatible attachment provider is available
java.lang.IllegalStateException: No compatible attachment provider is available
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:627)
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:611)
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:563)
	at net.bytebuddy.agent.ByteBuddyAgent.install(ByteBuddyAgent.java:540)
	at io.mockk.proxy.jvm.JvmMockKAgentFactory.initInstrumentation(JvmMockKAgentFactory.kt:128)
	at io.mockk.proxy.jvm.JvmMockKAgentFactory.init(JvmMockKAgentFactory.kt:34)
	at io.mockk.impl.JvmMockKGateway.<init>(JvmMockKGateway.kt:46)
	at io.mockk.impl.JvmMockKGateway.<clinit>(JvmMockKGateway.kt:185)
	at social.bigbone.testtool.MockClient.mock(MockClient.kt:138)
	at social.bigbone.testtool.MockClient.mock$default(MockClient.kt:19)
	at social.bigbone.api.method.CustomEmojisMethodsTest.Given a client returning success, when getting all custom emoji, then expect values of response(CustomEmojisMethodsTest.kt:17)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at java.util.ArrayList.forEach(Unknown Source)
	at java.util.ArrayList.forEach(Unknown Source)

Is this the expected behaviour for the test function? I got a similar error in the NotificationMethodsTest.kt file

No, it is not expected. The tests work both on my local machine as well as in the GitHub Actions builds.
A cursory Google search got me here: https://github.com/raphw/byte-buddy/issues/1148#issuecomment-971640429
Are there setup issues again where your system is using the JRE for some reason?

For some reason IntelliJ refuses to work with WSL, so I started to go through the command line documentation from ./gradlew help --task test. After a lot of trial and error I figured out a way to run a single method through the command line
./gradlew :bigbone:test --tests social.bigbone.api.method.AnnouncementMethodsTest."just a test-test"

or in other words
./gradlew :bigbone:test --tests social.bigbone.api.method.<ClassName>.<MethodName>

Through this I was able to run all the tests

@AnuraagReddy123 If you want to join our Slack, we could do a huddle and I can give you a 101 of testing, IntelliJ, and debugging?

Actually that would be really helpful! Thanks a lot!

I wrote a test case:
fun `Get all unread announcements`() {
      val client = MockClient.mock("announcements.json")
      val announcementMethods = AnnouncementMethods(client)
      val announcements = announcementMethods.getAllAnnouncements(withDismissed = false).execute()

      announcements.size shouldBeEqualTo 1

      verify {
          client.get(
              path = "/api/v1/announcements",
              query = any<Parameters>()
          )
      }
  }

According to the Mastodon API for get all announcements Link, having the withDismissed variable as false should only return those announcements which are not dismissed by the user.
I made this announcements.json, where the read variable is false for 2 of the announcements, so calling getAllAnnouncements with withDismissed false should return just 1 announcement, but all 3 announcements are returned

@AnuraagReddy123 While I get that that would be great, that is not how our mocking setup currently works. 😊 We do not completely emulate the Mastodon API. So what you set in the JSON you give to the MockClient is what it will return. There is no filtering for the parameters—that part is done by the actual servers, not by our library.
I commend your effort and agree that this would be a great test if we did the filtering.
But in this case, less is enough. 😊

Oh that makes sense. I have added some test cases can you check them @PattaFeuFeu?

Two small git tips:

Ideally, you would create (feature) branches in your fork as well. I noticed that you are working on AnuraagReddy123:master, so you are limited to to merge from andregasser:master now and cannot merge from your own version of master. That in itself is not too bad, but if we merge your Pull Request here, you could not start another PR from your fork. You would first need to get it exactly to the state this repository here is in to start over again as we won’t merge your changes with the exact commits and commits IDs, but will instead “squash” them into one commit, thereby rewriting that part of the git history.
Ideally, you would limit commits to one related change only. In 199803d you both added tests and changed a type. Not the case here, but if you now wanted to revert one of the two changes, the work would be more involved then simply reverting the whole commit that only introduced one of the changes

😊

Ideally, you would create (feature) branches in your fork as well. I noticed that you are working on AnuraagReddy123:master, so you are limited to merge from andregasser:master now and cannot merge from your own version of master. That in itself is not too bad, but if we merge your Pull Request here, you could not start another PR from your fork. You would first need to get it exactly to the state this repository here is in to start over again as we won’t merge your changes with the exact commits and commits IDs, but will instead “squash” them into one commit, thereby rewriting that part of the git history.

Ok so I should make a new branch like 'AnuraagReddy123:feat-branch', make my changes there, then make a pull request from the feat branch to 'andregasser:master' branch?

Ideally, you would limit commits to one related change only. In 199803d you both added tests and changed a type. Not the case here, but if you now wanted to revert one of the two changes, the work would be more involved then simply reverting the whole commit that only introduced one of the changes

Yes I will keep that in mind 👍. Currently I follow this workflow in my local machine

Sync the fork repository with the latest changes

Pull the repository to my laptop

Make a new feature branch

Make changes and make multiple commits

After I am done, I merge this branch to the master branch (in my laptop) using the --squash command (Converts all the commits to a single commit on merging)) (I usually do this to keep the number of commits small, not sure if it is a good practice)

Push the master branch to Github master branch

Ok so I should make a new branch like 'AnuraagReddy123:feat-branch', make my changes there, then make a pull request from the feat branch to 'andregasser:master' branch?

Yep 👍

(I usually do this to keep the number of commits small, not sure if it is a good practice)

Depends on the merge type of the project. If the project merges through squash commits like we do here, it doesn’t matter too much. Could be 1 or 100 commits and there would not be a difference on master after merging.
For merge commits or rebasing, it would clutter the main branch quite a bit if you had 100 additional commits from one PR, especially if many of them essentially handle the same change.
What has worked for me—as long as no one has reviewed yet: Write as many commits as necessary to work well. I often see them as “save points” like in a game, so that I can return to an older solution if something I later worked on didn’t pan out quite as planned.
But then, before pushing for a PR review, I rebase all of the commits onto the source branch (often main) and squash commits belonging to the same topic (“add endpoints”, “add entities”, “reformat”) and give them meaningful commit messages.
Regarding the “as long as no one has reviewed yet”: You should try your best to never mess with an already uploaded history. If no one has seen it yet, it could be fine. But as soon as there’s been a review and other people have checked it out, as a general rule of thumb, you shouldn’t rebase or squash existing commits you have already uploaded. That way, you would lose exact references of existing comments as the commits no longer exist. And reviewers would have to freshly check out your changes again instead of just pulling from the remote.
With PRs that’s usually not that big a deal, but you should really not rewrite history on the commonly used base branch (master, main, develop, …) as it’s easy for others to lose their work that way if they don’t know exactly how to use git under those circumstances.

So do I have to make any more changes?

A small doubt: is the endpoint supposed to be api/vx/announcements or /api/vx/announcments or are both just the same? Because going through the code, the other methods have the endpoints in the format of api/vx/... but in the Mastodon documentation it is written as '/api/vx/...`

With how our code is written, the version without a leading slash would be better, so api/vx/…. But it doesn’t really seem to matter. When running the samples, both versions work for me even if the one with the leading slash produces a double slash in the middle of the URL.
We might fix that in an upcoming PR. But for this PR, as long as you’re using the same variant in all places, it’s fine.

All done!

It was nothing compared to how much I learned about Kotlin and writing good code. Thanks a lot for teaching me so much!


[ENH] Implemented new endpoint to return known node APIs

Closes #26

Changes proposed in this pull request:

Modified the format of the NB_NODES as a string of strings to string of tuples
Renamed NB_NODES to LOCAL_NB_NODES
Refactored and renamed parse_nodes_as_list to parse_nodes_as_dict
Updated tests
Updated get function in crud.py
Fixed the parsing/creation of the output in get_terms function of crud.py
Implemented CohortQueryResponse
Added response_model for get_query endpoint
Implemented nodes router and an endpoint to return all known node APIs

Checklist

[ ] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

46 of 47 (97.87%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 92.188%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/api/routers/nodes.py
5
6
83.33%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
118

Relevant Lines:
128

💛  - Coveralls

@surchs Made an issue for the warning. See #31

:rocket: PR was released in v0.1.0 :rocket:


docs: Update README.md for docker compose usage

usage for docker compose
fix for #669

Apologize for my unfamiliarity with the process.
Updated the original Pull Request with the necessary changes.


Batch vs layer normalization description (page 560)

Hi Sebastian,
There is the description of the batch and layer normalization (including the picture) on the page 560:
"While layer normalization is traditionally performed across all elements in a given feature for each feature independently, the layer normalization used in transformers extends this concept and computes the normalization statistics across all feature values independently for each training example."
Is layer normalization mentioned correctly in the first case? It seems that when we calculate statistics for each feature independently, we perform batch normalization?
Thank you.

Thanks for the note! Phew this is a tricky one
Originally:

While layer normalization is traditionally performed across all elements in a given feature for each feature independently, the layer normalization used in transformers extends this concept and computes the normalization statistics across all feature values independently for each training example.

Yeah, reading this again, it does sound a bit weird. Here is an attempt to clarify it:

While layer normalization is traditionally performed across all feature values in a given layer for each training example independently, the layer normalization used in transformers extends this concept and computes the normalization statistics across all feature values for a given sentence token position independently for each training example

Maybe I should also swap the figure with a better one. This is the figure from the original layer norm paper:

I just found this helpful one here for transformer contexts:

Do you think that showing it like this would make it more clear? We can potentially update the book and I could swap it out. Do you think it's a helpful change?

I don't have much practical experience in DL, but I suppose the following:

The first picture has dimension annotations which are more specific to CNN than to sequences.
And it can be confusing to read PyTorch documentation, where for example convolutional layer will have N, C, L (for 1d) or N, C, H, W (for 2d) dimensions, while for embedding we will have swapped dimensions (N, L, C), and others can have (L, N, C) dimensions:
https://discuss.pytorch.org/t/inconsistent-dimension-ordering-for-1d-networks-ncl-vs-nlc-vs-lnc/14807
The implementations which I saw for transformers, including "The Annotated transformer", as I understand, uses LayerNorm with normalization only by the last dimension (embeddings dimension), so it seems that classical Layer normalization is used.
I suppose that the second picture is from this article, if you mean the left case in the picture then it is probably better for understanding your phrase. As I understand, this type of layer normalization is not described in the article in detail, just for reference.
Unfortunately I didn't find any description of this extended type of normalization neither in articles (for example, here) nor in implementations, and it will be great if you suggest any additional information about that.


OBJ-226 Get action code from Oracle Query API

I am happy with this, but this pr seems a good place. In the pom.xml there is a commented section about the jdbc and oracle driver dependencies. I believe with this approach using the query api, we can remove that commented section as we do not need it


Cannot create repository in organisation

Got this error:
{"message":"Validation Failed","documentation_url":"https://developer.github.com/v3/repos/#create","errors":[{"value":309572,"resource":"Repo","field":"team_id","code":"invalid"}]}

Is it due to an API update? Thank you.

This is a part of the test suite and it works for us.
The error message suggests that the team you specify is invalid?


Revert erroneous receipt chain hash prefix change

Closes https://github.com/MinaProtocol/mina/issues/15100

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-kme

!ci-build-me

!ci-build-me

!approved-for-mainnet


redirect_to Action: rename action attribute to action_name

The redirect_to action has an action attribute which is being passed to Turbo.visit(..., { action }) to control the Turbo visit behaviour.
But the action attribute name is clashing with the <turbo-stream> element, since it's using the action attribute for determining the stream action to execute.
We should rename the attribute for the redirect_to action to either action_name or turbo_action.

turbo_action sounds better IMO

Yeah, I would be fine with turbo_action. This makes it more explicit!


SSO and OAUTH

This is a feature request.
It would be great if Zulip can authenticate with external providers such as ONELOGIN for SSO, or Github OAUTH. I've seen the apache module, but i think this is not the same.

Since Zulip Django it is generally not hard to add a new external auth provider.  The ones we have are defined in zproject/backends.py ; as you can see they're all pretty small wrappers on top of third-party Django providers.
For OpenID in particular it looks like one could use: https://django-oauth-toolkit.readthedocs.org/en/latest/
Happy to provide advice on how to test/integrate if anyone's interested.

To share some experience hooking up a SAML SSO provider: the OneLogin python library is straightforward and works well: https://github.com/onelogin/python-saml. SSO and SLO work. The code seems good - simple structures. It can easily be hooked up into a backend.
Before that I tried djangosaml2 (https://pypi.python.org/pypi/djangosaml2/), which is more complex (code implements 1:1 mapping with XML, rather than simplifying the metadata into class + properties) and it does not support Single Log Out correctly - was missing code to handle the SessionIndex.

Since we've now added GitHub auth, I'm closing this as a duplicate of #716.


Available component "+" and "-" button issue.

Description of problem
The available component add or remove button should be constant after clicking Discard Changes
Component (web, API, etc)
web
Version or commit hash (if applicable)
ac8be5731024b3fcf54f1da73565dedd505253a0
How often reproducible
100%
Steps to Reproduce

go to edit blueprint page.
make a component change.
click discard changes button.

Actual results
The "+" should be "+" and "-" should be "-".
Expected results
All "-" button changed to "+".
Additional info

From what I can tell "Discard changes" doesn't really discard anything. Maybe that's the problem.

I'm not able to reproduce this issue.

Indeed I confirm that this issue is not reproducable. @henrywang please verify as well and close the issue if not more applicable.


WIP: [R] Verify CRAN release-<IP_ADDRESS>

Do not merge: for release purposes only

@github-actions crossbow submit --group r

@github-actions crossbow submit --group r

Everything looks good; failing jobs have reasonable explanations