[TF 2.0] tf.keras.optimizers.Adam

System information

TensorFlow version: 2.0.0-dev20190618
Python version: 3.6

Describe the current behavior
I am trying to minimize a function using tf.keras.optimizers.Adam.minimize() and I am getting a TypeError
Describe the expected behavior
First, in the TF 2.0 docs, it says the loss can be callable taking no arguments which returns the value to minimize. whereas the type error reads "'tensorflow.python.framework.ops.EagerTensor' object is not callable", which is not exactly the correct TypeError, it might be for some.
But the main issue is, I know I can do the same optimization by using GradientTape but I don't understand why I should or why the minimize() is not working. A similar issue I found related to this is linked: (https://github.com/tensorflow/tensorflow/issues/28068) and a stack overflow solution for how you can solve a similar problem using gradient tape for reference: (https://stackoverflow.com/questions/55060736/tensorflow-2-api-regression-tensorflow-python-framework-ops-eagertensor-object).
Code to reproduce the issue
import tensorflow as tf
import numpy as np

N  = 1000                               # Number of samples
n  = 4                                  # Dimension of the optimization variable
np.random.seed(0)
X = tf.Variable(np.random.randn(n, 1))  # Variables will be tuned by the optimizer
C = tf.constant(np.random.randn(N, n))  # Constants will not be tuned by the optimizer
D = tf.constant(np.random.randn(N, 1))

def f_batch_tensorflow(x, A, B):
    e = tf.matmul(A, x) - B
    return tf.reduce_sum(tf.square(e))

fx = f_batch_tensorflow(X, C, D)
print(fx)

adam_opt = tf.keras.optimizers.Adam()
optimizer = adam_opt.minimize(fx, X)
print(optimizer)

Other info / logs
Following is the error  I am getting:
TypeError                                 Traceback (most recent call last)
<ipython-input-20-225de189a3ff> in <module>()
      7
      8 adam_opt = tf.keras.optimizers.Adam()
----> 9 optimizer = adam_opt.minimize(fx, X)
     10 print(optimizer)

1 frames
/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/optimizer_v2/optimizer_v2.py in _compute_gradients(self, loss, var_list, grad_loss)
    347       if not callable(var_list):
    348         tape.watch(var_list)
--> 349       loss_value = loss()
    350     if callable(var_list):
    351       var_list = var_list()

TypeError: 'tensorflow.python.framework.ops.EagerTensor' object is not callable

The function will have already been executed. You need to pass f_batch_tensorflow (or rather, a partial thereof) to minimize, not the result of executing it.
@dynamicwebpaige @tanzhenyu This is probably a common mistake, we should catch and rethrow
(or type check the input) this specific error to explain what went wrong, maybe "EagerTensors cannot be passed to Optimizer.minimize. Please pass the callable representing the computation instead."

Hey, @martinwicke if you meant passing the function directly like so:
N  = 1000
n  = 4
X = tf.Variable(np.random.randn(n, 1))
C = tf.constant(np.random.randn(N, n))
D = tf.constant(np.random.randn(N, 1))

def f_batch_tensorflow(x, A, B):
    return tf.reduce_sum(tf.square(tf.matmul(A, x) - B))

optimizer = tf.keras.optimizers.Adam().minimize(f_batch_tensorflow(X, C, D), X)

This results in the same error unless I am missing something. Because when you pass a callable with arguments it will get evaluated before the minimize gets computed right so minimize will end up with the result, doesn't it? Or is the minimize just meant to be used inside training loops?
If you have an example, that would be great, I kinda searched stack overflow but everything I could find on minimize  was using sessions which made sense

What needs to be done here is:
f_without_any_args = functools.partial(f_batch_tensorflow, A=C, B=D)
optimizer.minimize(f_without_any_args, X)

@martinwicke Though I've been thinking maybe we should support symbolic tensor in some sense, i.e., inside tf.function? loss_fn is not a nice pattern and we're basically pushing users towards the GradientTape path.
(Supporting symbolic tensor is tricky though, because the forward pass has to be inside the same function)

These particular tensors weren't symbolic. In general, yes, but I fear it
would cause more confusion. We should definitely improve the error message
though.

perfect, thanks a lot @tanzhenyu that makes sense :)

It seems that
f_without_any_args = functools.partial(f_batch_tensorflow, x=X, A=C, B=D)
optimizer.minimize(f_without_any_args, X)

otherwise, it will raise error that f_batch_tensorflow() missing 1 required positional argument: 'x' in the optimizer.minimize function.

In the 1.x version, minimize function takes the loss as a tensor.
https://github.com/tensorflow/tensorflow/blob/1cf0898dd4331baf93fe77205550f2c2e6c90ee5/tensorflow/python/training/optimizer.py#L367
And in the 2.x version, the minimize function takes the loss as a callable function
https://github.com/tensorflow/tensorflow/blob/1cf0898dd4331baf93fe77205550f2c2e6c90ee5/tensorflow/python/keras/optimizer_v2/optimizer_v2.py#L299
as it computes the loss in _compute_gradients
https://github.com/tensorflow/tensorflow/blob/1cf0898dd4331baf93fe77205550f2c2e6c90ee5/tensorflow/python/keras/optimizer_v2/optimizer_v2.py#L351.
It really confused.


My game keeps crashing every time the Lurker attacks me and (probably) jumpscares me

Here's both my logs, crash log and game log.
crash-2024-04-28_01.29.50-server.txt
latest.log

Strange... perhaps another mod could be conflicting with my mod? though I don't see another mod being mentioned in the crash, so I don't know.
I'm not sure why it would crash when the Lurker attacks you. Also, I don't have this problem when playing or testing the mod myself.
And the only thing I see in the crash log that is really mentioned is the Void Gateway, which has nothing to do with you being attacked.
If you have other mods installed with my mod, could I possibly have a list to see if I can recreate this issue?

Strange... perhaps another mod could be conflicting with my mod? though I don't see another mod being mentioned in the crash, so I don't know.
I'm not sure why it would crash when the Lurker attacks you. Also, I don't have this problem when playing or testing the mod myself.
And the only thing I see in the crash log that is really mentioned is the Void Gateway, which has nothing to do with you being attacked.
If you have other mods installed with my mod, could I possibly have a list to see if I can recreate this issue?

Embeddium dev told me this:

the mod just appears to be trying to access client data structures from the server thread, which is not safe (and another mod detects that and blocks it), UWRAD just detects this situation because it would likely cause a random crash somewhere else otherwise

Strange... perhaps another mod could be conflicting with my mod? though I don't see another mod being mentioned in the crash, so I don't know.
I'm not sure why it would crash when the Lurker attacks you. Also, I don't have this problem when playing or testing the mod myself.
And the only thing I see in the crash log that is really mentioned is the Void Gateway, which has nothing to do with you being attacked.
If you have other mods installed with my mod, could I possibly have a list to see if I can recreate this issue?

I could send you the modpack if you want, it's quite large

Perhaps the MCreator problem is unsolvable at this level

I could send you the modpack if you want, it's quite large

It would be nice if you could send over the modpack

Actually, now that I've installed UWRAD, it might just be UWRAD itself causing the crashing because when I have UWRAD installed, my game seems to crash, and when I don't have UWRAD installed, my game doesn't crash.
I'm not sure if UWRAD is supposed to intentionally crash the game when it detects something wrong or not, but I would assume it's just for crashes in general, so I don't know why it would crash the game when it detects something wrong.


Add support for the MacOS native pasteboard via pbcopy/pbpaste.

MacOS doesn't have great support for xsel but does have somewhat equivalent functionality in pbcopy/pbpaste. This PR checks for the existence of pbcopy/pbpaste and uses it to support the native MacOS clipboard.

Thanks very much, great to have better mac support :+1: I'll change the target to dev though, and have a closer look this evening.

Sorry this was left hanging, been really busy lately. LGTM! :shipit:


Get-MgIdentityConditionalAccessPolicy : Could not load file or assembly 'Microsoft.Graph.Authentication

Get-MgIdentityConditionalAccessPolicy : Could not load file or assembly 'Microsoft.Graph.Authentication, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the
file specified.
At C:\ConditionalAccessDocumentation-master\Invoke-ConditionalAccessDocumentation.ps1:335 char:1

$conditionalAccessPolicies = Get-MgIdentityConditionalAccessPolicy -A ...

  + CategoryInfo          : NotSpecified: (:) [Get-MgIdentityC...cessPolicy_List], FileNotFoundException
  + FullyQualifiedErrorId : Microsoft.Graph.PowerShell.Cmdlets.GetMgIdentityConditionalAccessPolicy_List

Thank you for your code. Any idea what this might be ?

Hi Nicola,
I experince the same problem. Are am I missing something?

@vn82catu @t0feind this is related to module dependencies, ensure that you have the Microsoft.Graph.Authentication module installed and available under version 0.9.1. When I had a newer version present (besides 0.9.1) I encountered the same issue as you.
Deleting any newer versions solved the problem:

(Could only repro this one in PowerShell 5.1; on PowerShell 7 did not interferer)


Missing attachShape()/detachShape()

The Methodes attachShape(...) and detachShape() are missing in the class RigidActor.
BTW-> is it possible to add a shape to actors shapelist with the method attachShape(...)???

Hi Chad
Is it a big task to support the detaching and attaching of shapes?
I have tried to make a "hack" in my application to overcome this lack of functionality in the wrapper (moving shapes between actors were supported in 2.8) but it becomes too complicated and unpredictable.
Is there any way I can help in this matter because I would really appreciate if this could be fixed.
...I am guessing that it is complicated in the wrapper as well since you have not already added the code for it?

Hey, apologies for the late reply, I've been on holiday again :P
Attaching and detaching shapes as far as I can remember wasn't too hard to get working, except it had 1 particular problem that I couldn't figure out. I'll need to revisit the problem, as it's kind of a useful feature.
I'm trying to remember exactly what the problem was... I think was something in the area of disposing a shape. I'll have a look into it tonight after work.

Thanks.
Hope you have had a good vacation
The problem is that I want to deattach a shape from one actor and attach it to another actor (that already contains one or more shapes). And again deattach the shape and attach it to the original actor.
Tell me if I can be of any help.
/Steen
Den 25/08/2015 kl. 15.33 skrev Chad Mellor <notifications<EMAIL_ADDRESS>Hey, apologies for the late reply, I've been on holiday again :P
Attaching and detaching shapes as far as I can remember wasn't too hard to get working, except it had 1 particular problem that I couldn't figure out. I'll need to revisit the problem, as it's kind of a useful feature.
I'm trying to remember exactly what the problem was... I think was something in the area of disposing a shape. I'll have a look into it tonight after work.
—
Reply to this email directly or view it on GitHubhttps://github.com/stilldesign/PhysX.Net/issues/10#issuecomment-134586644.

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

Hey, I've done some work regarding attaching and detaching shapes, check out the 'DetachShape' branch and let me know if it's working for you and if there's anything missing/buggy :)
If you need, I can send you a built DLL if you have trouble building the branch

THANKS!!!
I have just tried it - but I am still not sure if I am using the methods correctly (or maybe I do not understand how to use them).
When I am calling the DetachShape method the shape becomes disposed - I would have expected by calling AttachShape on a different actor that I could have attached the same shape again (but this time to different actor then the one used to create the shape)
/Steen

There's two ways to create Shape's now, actor.CreateShape() and physics.CreateShape()
If an actor is created on an actor (actor.CreateShape()), and you DetachShape(), it will be disposed of immediately
If an actor is created on a physics instance (i.e. a shared shape) you can attach it to an actor, then detach it, then attach it to another actor.

Hi Cha
…ok great I will try that!
Thanks!
Fra: Chad Mellor<EMAIL_ADDRESS>Sendt: 9. september 2015 01:44
Til: stilldesign/PhysX.Net<EMAIL_ADDRESS>Cc: Steen Hother Jensen<EMAIL_ADDRESS>Emne: Re: [PhysX.Net] Missing attachShape()/detachShape() (#10)
There's two ways to create Shape's now, actor.CreateShape() and physics.CreateShape()
If an actor is created on an actor (actor.CreateShape()), and you DetachShape(), it will be disposed of immediately
If an actor is created on a physics instance (i.e. a shared shape) you can attach it to an actor, then detach it, then attach it to another actor.
—
Reply to this email directly or view it on GitHubhttps://github.com/stilldesign/PhysX.Net/issues/10#issuecomment-138732627.

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

Hi Chad
I still not works for me – sorry!
When I am creating a shape using the physics.CreateShape method and then calling the PhysX.DefaultSimulationFilterShader.SetGroup method then I get this error:
(InvalidParameter) NpShape::setSimulationFilterData: shared shapes attached to actors are not writable.( ....\PhysX\src\NpShape.cpp - Line 440
/Steen
Fra: Chad Mellor<EMAIL_ADDRESS>Sendt: 9. september 2015 01:44
Til: stilldesign/PhysX.Net<EMAIL_ADDRESS>Cc: Steen Hother Jensen<EMAIL_ADDRESS>Emne: Re: [PhysX.Net] Missing attachShape()/detachShape() (#10)
There's two ways to create Shape's now, actor.CreateShape() and physics.CreateShape()
If an actor is created on an actor (actor.CreateShape()), and you DetachShape(), it will be disposed of immediately
If an actor is created on a physics instance (i.e. a shared shape) you can attach it to an actor, then detach it, then attach it to another actor.
—
Reply to this email directly or view it on GitHubhttps://github.com/stilldesign/PhysX.Net/issues/10#issuecomment-138732627.

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

… and one more thing:
Can I suggest to use TryGetObject in the ToManage method in the TriggerPair class instead of just GetObjects:
Otherwise you will get an exception when you are disposing an actor that are inside a  trigger!
<EMAIL_ADDRESS>/Steen
Fra: Chad Mellor<EMAIL_ADDRESS>Sendt: 9. september 2015 01:44
Til: stilldesign/PhysX.Net<EMAIL_ADDRESS>Cc: Steen Hother Jensen<EMAIL_ADDRESS>Emne: Re: [PhysX.Net] Missing attachShape()/detachShape() (#10)
There's two ways to create Shape's now, actor.CreateShape() and physics.CreateShape()
If an actor is created on an actor (actor.CreateShape()), and you DetachShape(), it will be disposed of immediately
If an actor is created on a physics instance (i.e. a shared shape) you can attach it to an actor, then detach it, then attach it to another actor.
—
Reply to this email directly or view it on GitHubhttps://github.com/stilldesign/PhysX.Net/issues/10#issuecomment-138732627.

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

Don't mean to necro an old issue. But was this feature abandoned? Would be nice to have but haven't seen any mention of it and it isn't in the current NuGet package.

Currently only the AttachShape method is there (RigidActor.AttachShape)
What's needed is -

RigidActor.DetachShape
Physics.CreateShape to create an 'orphaned' shape which can be attached at a later stage

It's been awhile since I've looked at this topic, I can't quite remember what the trouble was with DetachShape, but there must have been something tricky otherwise I would have done it by now. I assume something around object-tracking and ownership of the object.


Adding Ebi(ashahba) to ci-team members

I'm trying to ramp up more on https://github.com/kubeflow/testing in order to align it to work that @kkasravi is doing. So being able to get more access to read logs is what I'm trying to get out of this PR.

This change is

/lgtm
/approve


release 1.3.2

Description:
release 1.3.2

Testing done:
DONE

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Is this a breaking change? no

Has documentation corresponding to this change been updated in the osm-edge-docs repo (if applicable)? no

Codecov Report
Patch and project coverage have no change.

Comparison is base (8a05f9d) 61.45% compared to head (80cb0c4) 61.46%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@              Coverage Diff              @@
##           release-v1.3     #153   +/-   ##
=============================================
  Coverage         61.45%   61.46%
=============================================
  Files               218      218
  Lines             17088    17088
=============================================
+ Hits              10502    10503    +1
+ Misses             6533     6532    -1
  Partials             53       53

Flag
Coverage Δ

unittests
61.46% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/certificate/manager.go
74.42% <0.00%> (-0.77%)
:arrow_down:

pkg/messaging/workqueue.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create new release

Please create a new release so the latest code can be referenced by External DNS Infoblox plugin build.

Hi Arvin,
We have couple more PRs to be reviewed. Expect a release to be done in a day or so.

Arvin we have published a new release https://github.com/infobloxopen/infoblox-go-client/releases/tag/v1.1.1

Thanks. I see the new release


Attachments finder doesn't find vmdl_c

It only works with vmdl, not vmdl_c

Fixed, input the path/to/model.vmdl and the editor will find the _c variant if it exists


2-way puzzle holes

Put a switch trigger for the puzzle hole on the square instead of a key trigger to make it a 2-way puzzle hole. Else it works like in OG.
New Lara object in the comment below.
Fix spiky wall speed. Insert speed in "X start vel" in your spiky wall animations. you can change the speed ingame by changing itemflag[0].

Lara-remove-puzzle.zip


Print/Save as PDF function in admin view will freeze the application

Describe the bug
When the print/save as pdf button is clicked on a student profile / application a notification/alert(containing the print confirmation) will appear. This seems to freeze the web app until the notification/alert is closed.
To Reproduce
Steps to reproduce the behavior:

Go to admin view
Click on any row (to open profile sidebar) or drop down (expanded application)
Click on "print / save as pdf", this will open a new window
The window with the data-table (which we started on) will be frozen and all interactions will hang

Desktop (please complete the following information):

OS: Windows 10
Browser: MS Edge

I found this thread on stackoverflow about this issue.
It seems that the page for printing and its parent (listing) share the same process in Chrome (as they are from the same origin). Once window.print() is executed it will block all other interactions of the same process.
Try window.open(route.href, "_blank", "noreferrer"); as a work around. It will open the tab in a new process and the printing dialog won't freeze other tabs.
This issue doesn't take place in Firefox.


Obstacle and random size

Hi Shinao,
I was wondering if this excellent project had some function like obstacles or instantiating the object using random size?
Thanks a lot.

Obstacles could be generated through affectors (either pushing or pulling boids away).
I don't quite understand what objects you refer to next question, but that should be a matter of changing the scripts.
Though you might consider going for the ECS Unity Boids system route which gives you greater control over it instead of my GPU implementations.


MAP estimate feature to avoid full posterior calculation

To speed up applications that purely make use of .posterior().mean, it would be useful with a .MAP() alternative.
This is both for the GP, DiscreteLowRank, PDM and SSM.
In a quick test with a PointDistributionModel[_3D, TriangleMesh] with a 40 rank model with ~150.000 vertices and 1000 points to condition on, I get:
posterior.mean: ~900ms
MAP: ~90ms
For a pure GP GaussianProcess[_3D, EuclideanVector[_3D]], the performance difference seems much less. Also with 1000 points to condition on, I get:
posterior.mean: ~6s
MAP: ~5.7s

Merged in as part of scalismo 1.0


Don't trap SIGTERM and let the process stops

Since the AC is not doing any prticular action on normal stop (that is
SIGTERM reception) we don't need to trap it anymore, and let service
appscale-controller stop do its magic.

Catching 'EXIT' (special word for ruby's trap) would resolve the issue:
https://github.com/AppScale/appscale/pull/3091/files#diff-4020412951682f6648be0012f9b3eb93R148

Thanks @jeanleonov much better solution! Closing this now.


specify running commands on actual Splunk server

I got tripped up and digging through code why it was failing. I was running this on my laptop and pointing it to an EC2 Splunk server. Figured out I believe these commands are supposed to be ran on the actual Splunk server .. so I ssh'd in and it worked.
This is my first time so if this is incorrect please don't merge, but hopefully helping someone else who comes behind and may try and populated data into a remote Splunk server (which didn't work for me)

going to resubmit with adding a comment in the bin/replay.yml to ensure user knows the path: has to be a local splunk path


fix: use libuv api to create async tasks

Haven't investigated much on this, but for some reason the napi async task creations are being blocked when run with our integration test suite. This just restores the old behavior and unblocks merging electron 6.
Will look into this further as follow up task.

:+1: LGTM


subsys: console: Fix signed vs unsigned char issues.

May lead to warnings/errors with pedantic compilers (like LLVM).
Jira: ZEP-2170
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

Fix for https://jira.zephyrproject.org/browse/ZEP-2170.

Should be included in 1.8 release too.

@galak : Thanks! Anything special required to lead this into v1.8-branch, or v1.8 milestone as you set is enough for it to not be missed?


Add silent mode

Fixes #3.

LGTM
Btw, do we plan on having a documentation for the cli beyond the help output, similar to what's on jade-lang right now and if so, where do we update that?


fix(vite-plugin-angular): cache already resolved style and template URLs

Thanks @arturovt. I'm not sure how much we gain here as we're already reading from the transformed source, and not reading again from the filesystem to parse the external styles and templates.

@brandonroberts aren't we running path.dirname and path.resolve when resolving the absolute file path?

@arturovt that's true. I didn't treat those as filesystem read/write calls but resolve does use the process.cwd()


Make explicit IGListDiffable protocol requirement

While the CocoaDocs for the IGListDiffable state that IGListDiffable objects should not mutate their diffIdentifier that requirement is not clear in this guide.
This is a documentation only PR.
Changes in this pull request
Issue fixed: #880
Checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[x] I have reviewed the contributing guide

Love it!

FWIW I believe I've signed the CLA (the form didn't look like there were errors when I submitted) despite what the bot says


Proper exposure time values were not always returned when parsing photo files

What version of Hugo are you using (hugo version)?
Installed from Homebrew

$ hugo version
hugo v0.110.0+extended darwin/arm64 BuildDate=unknown

Does this issue reproduce with the latest release?
Yes, at v0.110.0
Description
I'm using a Hugo photo gallery theme hugo-shortcode-gallery.
Strange behaviour when parsing EXIF content of photos taken with Nikon cameras.
In general, the exposure time should be expressed in fractions, such as 1/100sec, 1/ 320sec or 10sec.

But when I used the Hugo to generate the static pages, the exposure time was expressed in decimals.
I created a issue for the theme component and request that it should return fractions in more cases.
I forked the latest Hugo repo, used my photos and other brands' raw files downloaded from the web to debug and parse EXIF info.
The conclusion is that Hugo only returns a fraction if the numerator is 1, as it isn't in some case(E.g.: Nikon NEF files or JPEGs generated from NEF), it calculates the result of the fraction. (source)
	if n == 1 {
		rv = append(rv, rat)
	} else {
		f, _ := rat.Float64()
		rv = append(rv, f)
	}

This is probably not an appropriate way to get the exposure time.

The conclusion is that Hugo only returns a fraction if the numerator is 1, as it isn't in some case(E.g.: Nikon NEF files or JPEGs generated from NEF), it calculates the result of the fraction. (source)

I have tested this with RAW files (JPEG files generated from those) from a variety of Pentax cameras, a Sony A7R II and Nikon D500 -- and all of these reports a numerator of 1 for exposure time < 1. So I guess this is introduced with the new Nikon Z cameras?
In any case, I'm not sure what the solution is, but it would be a good start if you could somehow attach an image (preferably just an image of a wall or something, so we can use it for integration testing without having to worry about copyright ...) to this issue.

You can try this one.

How about this modification?

Yea, that looks sensible -- but the test images needs to be in kilobytes and not 10-30 megabytes, and they also need to be obviously not copyrighted. If you can demonstrate this with a small JPG, that would be great.


How to combine param paths with a fs storage

Disclaimer: This might be more of a general question on storages, but I'm not sure on that.
Say I have this rule from the docs:
rule:
    input:
        ...
    params:
        prefix="somedir/{sample}"
    output:
        "somedir/{sample}.csv"
    shell:
        "somecommand -o {params.prefix}"

The rule is executed as somecommand -o somedir/sample1. Since the storage plugin doesn't change the pwd, this will create an output file "somedir/sample1.csv" relative to the Snakefile, which might already be bad if there are a lot of writes on a slow IO system. But worse, since snakemake expects the output file in the storage directory it fails with a MissingOutputException.
Is there a smart way to prevent this? The only way I can think of is to use a lambda function for the prefix that splits of ".csv" from the output path in this case. But this would need to be adjusted to each case, since there might be more complex cases where it's not only a file extension that needs to get removed.
Thanks in advance!

The only way I can think of is to use a lambda function for the prefix that splits of ".csv" from the output path in this case. But this would need to be adjusted to each case, since there might be more complex cases where it's not only a file extension that needs to get removed.

Exactly, this is the best practice, as also suggested by the Snakemake linter in such cases. I am working on some convenience methods for helping with such tasks though. However, this is not yet finished: https://github.com/snakemake/snakemake/pull/2927


a spell mistake

after commented default portable option in app/meson.build get some error and then find this. : )

:scream: Thank you, merged as https://github.com/Genymobile/scrcpy/commit/bcd0a876f7bf52642330410812a6b7100cdeda91/

I wondered how I did not hit the error during my tests, the answer is that the default value for a boolean flag in meson option is true, I thought it was false: 53310a925a495f61d42dd90faa0a0748074d63c5


Interaction of firebase chat app

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
4, because the PR introduces a significant amount of new functionality related to Firebase integration, including authentication, chat functionality, and UI components. The complexity of the changes, spanning multiple files and involving both frontend and backend aspects, requires a thorough review to ensure functionality, security, and code quality.

 🧪 Relevant tests
No

 🔍 Possible issues

Possible Security Concern: The API key for Firebase is hardcoded in the source code (firebaseConfig object in firebase.jsx). This could lead to security vulnerabilities if the repository is public or improperly secured.

Possible Bug: The ChatBody component attempts to access properties on currentUser without null checks, which could lead to runtime errors if currentUser is null.
 🔒 Security concerns
Sensitive information exposure: The Firebase API key is exposed in the source code, which should be secured using environment variables or a secure vault solution to prevent unauthorized access to the Firebase project.

 Code feedback:
relevant fileClient/Client/firebase.jsx
suggestion

Move sensitive credentials like the Firebase API key to environment variables to prevent exposure in your codebase. This can be achieved by using .env files and accessing the variables via process.env. [important]

relevant lineapiKey: "AIzaSyDONuYo9g4jfFAJ5kWJho3fdCD_KGTdA80",
relevant fileClient/Client/src/components/FirebaseComponents/ChatBody.jsx
suggestion

Add null checks for currentUser before accessing its properties to prevent potential runtime errors. [important]

relevant line{message.senderUid === currentUser.uid && (
relevant fileClient/Client/src/components/FirebaseComponents/Chats.jsx
suggestion

Implement error handling for the Firestore operations to manage failures gracefully, such as network issues or permissions errors. This could include displaying error messages to users. [medium]

relevant lineupdateDoc(docRef, {
relevant fileClient/Client/src/components/FirebaseComponents/ChatBody.jsx
suggestion

Consider debouncing the search functionality in the chat to reduce the number of queries made to Firestore, improving performance and reducing costs. [medium]

relevant lineconst [messages, setMessages] = useState([])

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.


ocamlPackages.ocamlfuse: 2.7.1_cvs9 -> 2.7.1_cvs11

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/astrada/ocamlfuse/releases.
meta.description for ocamlPackages.ocamlfuse is: OCaml bindings for FUSE
meta.homepage for ocamlPackages.ocamlfuse is: https://sourceforge.net/projects/ocamlfuse
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.7.1_cvs11 in filename of file in /nix/store/gz609rr7m6jl75fb0gh9csr9aq9vbqq4-ocaml5.1.1-ocamlfuse-2.7.1_cvs11

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

google-drive-ocamlfuse

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gz609rr7m6jl75fb0gh9csr9aq9vbqq4-ocaml5.1.1-ocamlfuse-2.7.1_cvs11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ocamlPackages.ocamlfuse https://github.com/r-ryantm/nixpkgs/archive/6e140aaf3fb2d15c041d35de7a3815543f98d029.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6e140aaf3fb2d15c041d35de7a3815543f98d029#ocamlPackages.ocamlfuse

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gz609rr7m6jl75fb0gh9csr9aq9vbqq4-ocaml5.1.1-ocamlfuse-2.7.1_cvs11
ls -la /nix/store/gz609rr7m6jl75fb0gh9csr9aq9vbqq4-ocaml5.1.1-ocamlfuse-2.7.1_cvs11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:

google-drive-ocamlfuse
ocamlPackages.ocamlfuse

Maintainer pings
cc @bennofs for testing.

Result of nixpkgs-review pr 305657 run on aarch64-linux 1

1 package built:

google-drive-ocamlfuse


[SPARK-41214][SQL] - SQL Metrics are missing from Spark UI when AQE for Cached DataFrame is enabled

What changes were proposed in this pull request?

JIRA: https://issues.apache.org/jira/browse/SPARK-41214
spark.sql.optimizer.canChangeCachedPlanOutputPartitioning enables AQE optimizations under InMemoryRelation(IMR) nodes by creating sub-SparkPlans for AQE optimizations. However, when spark.sql.optimizer.canChangeCachedPlanOutputPartitioning = true, Spark UI does not show correct final DAG due to lack of final sub-plans (under IMR) submissions (into UI).
Why are the changes needed?

spark.sql.optimizer.canChangeCachedPlanOutputPartitioning enables AQE optimizations under InMemoryRelation(IMR) nodes. Sample query in Jira has IMR node on both BroadcastHashJoin legs. However,
when spark.sql.optimizer.canChangeCachedPlanOutputPartitioning = true, following datas are missed due to lack of final sub-plans (under IMR) submissions (into UI).

Physical operators' SQLMetrics (before AdaptiveSparkPlan) are missed such as Exchange and HashAggregate on left BHJ leg and HashAggregate on right BHJ leg,
WSCG blocks are missed on left BHJ leg,
AQEShuffleRead node is missed on left BHJ leg.

DAG before fix:

DAG after fix:

Does this PR introduce any user-facing change?

Currently, Spark UI does not show final DAG when spark.sql.optimizer.canChangeCachedPlanOutputPartitioning = true so this causes some physical operators metrics as missed. This PR aims to fix this problem.
How was this patch tested?

Specific UT Coverage will be added (In Progress).

cc @cloud-fan @Ngone51

is this still a problem after https://github.com/apache/spark/pull/38558 ?

The reason is, the AdaptiveSparkPlanExec inside InMemoryTableScanExec does not register a new execution id in SQLExecution. Then when it materializes, AdaptiveSparkPlanExec.getExecutionId can not find the corresponding QueryExecution.
https://github.com/apache/spark/blob/0ae82d99d13988086a297920d45a766115a70578/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala#L221-L226
A simple example like:
          ...
           |
  AdaptiveSparkPlanExec (queryexecution 0, no execution id)
           |
  InMemoryTableScanExec
           |
          ...
           |
  AdaptiveSparkPlanExec (queryexecution 1, execution id 0)

i s this still a problem after https://github.com/apache/spark/pull/38558 ?

@cloud-fan oh just see it. it not related

after https://github.com/apache/spark/pull/38558 , I think only the first cache access will miss the metrics?

There is another issue.. before doing a new action, we will reset the metrics. This issue is not about AQE, that means even we disable AQE for cache plan, we still can not get valid metrics after first access.


AttributeError: 'Settings' object has no attribute 'has_update'

[ Re: commit 37e0c96756526d735fe5ab0657ec49f474381af0 ]
Subject
I am packaging urllib3.future (as part of niquests and all its dependencies) for ArchLinux User Repository (AUR) and am therefore using the URLLIB3_NO_OVERRIDE=true python -m build … stanza as described in the README. As of the latest urllib3.future commit (see above) even a simple niquests.get() fails (see below).
Environment
Describe your environment.
At least, paste here the output of:
>>> print("OS", platform.platform())
OS Linux-6.8.8-arch1-1-x86_64-with-glibc2.39
>>> print("Python", platform.python_version())
Python 3.12.3
>>> print(ssl.OPENSSL_VERSION)
OpenSSL 3.3.0 9 Apr 2024
>>> print("urllib3", urllib3.__version__)
urllib3 1.26.18

Additionally, the newest versions of wassima, qh3, jh2, and niquests are installed.
Steps to Reproduce
>>> import niquests
req = niquests.get('https://github.com/jawah/urllib3.future')

Expected Behavior
niquests would fetch the requested page and return the request.
Actual Behavior
Python 3.12.3 (main, Apr 23 2024, 09:16:07) [GCC 13.2.1 20240417] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import niquests
>>> niquests.get('https://github.com/jawah/urllib3.future')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.12/site-packages/niquests/api.py", line 170, in get
    return request(
           ^^^^^^^^
  File "/usr/lib/python3.12/site-packages/niquests/api.py", line 107, in request
    return session.request(
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/niquests/sessions.py", line 539, in request
    resp = self.send(prep, **send_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/niquests/sessions.py", line 1174, in send
    r = adapter.send(request, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/niquests/adapters.py", line 896, in send
    resp_or_promise = conn.urlopen(  # type: ignore[call-overload]
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/urllib3_future/connectionpool.py", line 1383, in urlopen
    response = self._make_request(  # type: ignore[call-overload,misc]
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/urllib3_future/connectionpool.py", line 962, in _make_request
    self._validate_conn(conn)
  File "/usr/lib/python3.12/site-packages/urllib3_future/connectionpool.py", line 1922, in _validate_conn
    super()._validate_conn(conn)
  File "/usr/lib/python3.12/site-packages/urllib3_future/connectionpool.py", line 595, in _validate_conn
    conn.connect()
  File "/usr/lib/python3.12/site-packages/urllib3_future/connection.py", line 745, in connect
    self._post_conn()
  File "/usr/lib/python3.12/site-packages/urllib3_future/backend/hface.py", line 438, in _post_conn
    self.__exchange_until(
  File "/usr/lib/python3.12/site-packages/urllib3_future/backend/hface.py", line 628, in __exchange_until
    self._protocol.bytes_received(data_in)
  File "/usr/lib/python3.12/site-packages/urllib3_future/contrib/hface/protocols/http2/_h2.py", line 199, in bytes_received
    if self._connection.remote_settings.has_update:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Settings' object has no attribute 'has_update'
>>>

It seems that one constraint isn't satisfied. Make sure jh2>=5.0.3,<6.0.0 is installed.
if this solve your issue, feel free to close this one.
regards,


Exclude Tests in Package.swift

Problem - With Xcode 8.1 and Swift 3.0.1 toolchain (afair 3.0.0 also) it is impossible to build the project as a dependency because of Tests folder.
Getting error message:
Cloning https://github.com/JohnSundell/Unbox.git
HEAD is now at a0f1fd8 Merge pull request #134 from JohnSundell/2.2.0
Resolved version: 2.2.0
error: the package has an unsupported layout, unexpected source file(s) found: /Users/laskowski/test-project/Packages/Unbox-2.2.0/Tests/UnboxTests.swift
fix: move the file(s) inside a module

Fix - added Tests folder to exclude
Please create a new tag if possible, so this change will be visible via SPM.

Hey @michallaskowski - thanks for this! 👍 Seems a bit strange that we need to manually exclude the tests, as the Swift package manager should know that what's located in the /Tests folder are tests. But will merge this for now to unblock using Unbox with the SPM, will release a new version later tonight 🙂

@michallaskowski Release published! https://github.com/JohnSundell/Unbox/releases/tag/2.2.1 🎉

@JohnSundell Awesome 👍  thanks a lot.


Fail if no lefthook was found

Currently, if lefthook was not found, the user will see the message "Can't find lefthook in PATH" but commit still will go through.
IMHO it is not how it should work. The fix can be as simple as adding exit 1 in the else clause.
call_lefthook()
{
  if lefthook -h >/dev/null 2>&1
  then
    eval lefthook $1
  elif test -f "$dir/node_modules/@arkweid/lefthook/bin/lefthook"
  then
    eval "$dir/node_modules/@arkweid/lefthook/bin/lefthook $1"
  elif bundle exec lefthook -h >/dev/null 2>&1
  then
    bundle exec lefthook $1
  elif npx lefthook -h >/dev/null 2>&1
  then
    npx lefthook $1
  elif yarn lefthook -h >/dev/null 2>&1
  then
    yarn lefthook $1
  else
    echo "Can't find lefthook in PATH"
  fi
}

call_lefthook "run pre-commit $@"

Well, I believe that by default it shouldn't fail if binary wasn't found. It is better to miss something than completely break workflow for some people, IMO.
I don't see a case why we should always abort commit/push/whatever in case we can't perform git hook checks (because hooks are easily skippable by --no-verify option to git commit and git push commands).
If you want to enforce some rules (code linting, commit messages, whatever), you'd better to do this on CI (git hooks just helps to shorten feedback loop).

It can break someone with a modified PATH also https://github.com/evilmartians/lefthook/issues/178

There are several escape paths already if things goes wrong

git commit --no-verify
LEFTHOOK=0 git commit

And similar as for @skryukov it broke for me twice already.
The use case - I pull latest changes which introduce a new gem in Gemfile, then make some changes myself and commit them without doing bundle install.

People add lefthook for a reason even if it is easy to skip. I think it should break and print a reasonable message what to do if one still wants to proceed.

Opened PR - https://github.com/evilmartians/lefthook/pull/213

ooh, LEFTHOOK=0 is gold --no-verify isn't working for me on a branch which doesn't yet have lefthook installed. I just get Error: Config File "lefthook" Not Found in... and lose the commit message

I've just installed lefthook using snap and by default git actions fail if no lefthook config file is found. Is there any way to change this behavior without the need to add LEFTHOOK=0 all the time?

Is there any way to change this behavior without the need to add LEFTHOOK=0 all the time?

Could you describe what happened? You have git hooks using lefthook, but no lefthook.yml in your git project, right? And you'd like to see only a warning and not to stop git from creating a commit, right?

@mrexox yes, exactly

I'll try to prepare a fix by next week :+1:

Hey @roman-ih! Sorry for the long delay. It feels like changing current behavior is a big change for lefthook. So, I'd like to suggest an option.
What do you think of having a global config option for that, like ensure: true or mandatory: true? Git hooks will have exit 1 if this option is set to true. So, current lefthook users won't have problems when upgrading, but you can make your configuration stricter and require lefthook to be available (through PATH or other supported options).

I'm interested in this feature as well, and such a global configuration wounds very useful. The next-best option if the default cannot be changed for everyone.

@hyperupcall, cool! Do you like mandatory: true or any other naming for this option?

For me mandatory seems a bit vague to me - I like assert_lefthook_exists, or maybe fail_if_absent or abort_if_not_installed


Fix English and formatting, date article

https://developers.google.com/web/updates/2011/11/Quota-Management-API-Fast-Facts
Drive-by English fixes.
Code blocks didn't show:

CC @agektmr

Hi @dandv thanks for the contribution!
The article was published in 2011, is there some focus in this API/topic now? update is where new announcement goes and will eventually get stale.
Trying to understand if there is issue we can address in different form.

@kosamari I didn't even realize initially how old the article was, because there's no date anywhere but in the URL, and I read it on mobile, where the date part of the URL was hidden.
See the debate above about putting dates in articles.
This article showed in the top results for a Google search for "browser Quota management" or something like that. Other users likely won't realize how old it is, either.

Note that this API is deprecated and no longer recommended. Appreciate if you could link to a newer equivalent: https://developers.google.com/web/fundamentals/instant-and-offline/web-storage/offline-for-pwa

Instead of deleting the whole text, I would leave it there and add state at the top of the page that following information is obsolete. This would help people who encountered old implementation of the API to understand what is going on.

Closing this since #4508 was merged. Thanks all for the feedback !


Pedro/reactwebpk

I need someone to test the input stream by substituting the src in App.js with whatever the input is, and seeing whether it displays on the page as expected. Should it not work, let me know, but I'll need to setup the stream myself later for this too.


[ENHANCEMENT] Cutting releases on release branches

Is your enhancement related to a problem? Please describe.

In the supported branches (like v1.1), we add references to other projects.
For example, we add the installer v1.1 head in build-iso script, this ensures we always have ISOs build with v1.1 head installer code. When we do a release, we change the reference to a tag, but it's quite easy to forget to switch back to supported branch head later.
Describe the solution you'd like

Use release branches to cut releases, not touching the references in supported branches.
Describe alternatives you've considered

Additional context

Expect some modification to the .drone.yaml files.

Close as this is added via https://github.com/harvester/harvester/tree/release-1.2 and verified by https://github.com/harvester/harvester/releases/tag/v1.2.0-rc3 release.


the 8 parameters of unityeyes for generating training data

For UnityEyes , what are 8 paramters(camera 4 & eye 4)? And is it important for the training?

I generated UnityEyes images using the default parameters at 640x480 resolution with the setting "Fantastic". Due to a bug in rendering the Unity window via Wine on Linux I am not 100% sure which parameters the defaults were, but judging by the screenshot at https://www.cl.cam.ac.uk/research/rainbow/projects/unityeyes/tutorial.html it seems to be:
Camera: [0, 0, 20, 40]
Eyes: [0, 0, 30, 30]
As for whether they matter... this depends. For the purpose of training a gaze CNN to directly apply to MPIIGaze data, it was shown multiple times that improved performance can be achieved by sampling synthetic images to match the test data gaze distribution. See Fig. 12 here and Fig. 13 here. Having said that, it is not usually assumed that one has knowledge of test set labels at training time, and thus papers do not perform main evaluations in this manner.
For an unsupervised method of aligning gaze distributions between synthetic and real-world data, see this ICLR paper from Kangwook Lee et al..


Will the PS256 signing algorithm  implement in  the Identityserver4 version 3.0?

Please only use the issue tracker for simple questions. For general security questions, or free / commercial support options do not use the issue tracker and instead see here for more details.
For questions containing large amounts of code we recommend submitting a question on stack overflow using the Identity Server 4. Our amazing community on Stack Overflow is there to help answer all of your questions.
Finally, please keep the issue concise and to the point if your question does include code be sure it is a Minimal working example. If you paste in more code than the text for your question then it probably belongs on Stack overflow.
Question / Steps to reproduce the problem
Minimal working example
<code goes here>

Relevant parts of the log file
<log goes here>

I have used the Identityserver4 to implement the authorisation module in Open Banking. Unfortunately, Open Banking only support ES256 and PS256 (default) algorithms for signing tokens.

Last time I checked, the Microsoft JWT handler did not support it. There is an open issue for that at their repo.

dup: #3250


Srcset + image sizes creation

How or what could I implement to stacey that could give me the opportunity to create responsive images using the srcset attribute? Are there any modules/plug-ins I could use or add to the core? I'm reading that stacey is using twig and digging into this topic I see that its possible to create twig macros. As this concept is a bit unknown to me it faces a question about the image sizes itself: they should be regenerated on the server in the post folder also, right? Talking about 001-image-400x400.jpg, 001-image-150x150.jpg etc.
So my question (rather than an issue) is that has anybody faced the case where they've implemented srcset (or  element) for stacey based CMS?

I've not implemented image processing with Stacey, but I have used IMGIX on a Jekyll site hosted on GitHub Pages. In that set-up the client pays nothing on the hosting but there is a monthly fee on the image processing ($10 minimum each month I believe).


ImproveOSM public service URL changes

The ImproveOSM projects were transitioned from Telenav to Grab. As a result of this transition the ImproveOSM publicly available services URLs has been changed as follows:

Missing Geometry Service: https://grab.community.improve-osm.org/missingGeoService/
Direction of Flow Service: https://grab.community.improve-osm.org/directionOfFlowService/
Turn Restriction Service: https://grab.community.improve-osm.org/turnRestrictionService/

The old service URLs that are currently used by the iD tool were redirected to the new ones and will work for a couple of weeks. Can you schedule to change the ImproveOSM service URLs used by the iD tool?

Thank you.

@beataj-telenav Thanks for keeping iD in mind! I'll make the change for the next release (before the end of the month). Good luck with the transition.

@quincylvania : Thank you :)


Is it possible to load own model locally

@davidberenstein1957  @dvsrepo @martin-kirilov @DavidFromPandora  is there any possible ways to use own model locally.

Yes, this is possible! You can train a custom model via AllenNLP. Since they don´t actively maintain the package, I created a wrapper for it with some custom updates and models.
@davidberenstein1957 @dvsrepo @martin-kirilov @DavidFromPandora

I am using minilm quantized model that have " model.onnx"  format.    how to use this model format for prediction using cross-lingual package. is there any way to assign in the  function predictor = Predictor(language="en_core_web_sm", device=-1, model_name="minilm") in the model_name this model.onnx format

I contemplated speeding the model up using that approach but have not gotten around to looking into that. So I suggest you take a look at https://aclanthology.org/N18-2108.pdf and the implementation of the AllenNLP from allennlp.predictors.predictor import Predictor => Predictor.from_path()method.

I contemplated speeding the model up using that approach but have not gotten around to looking into that. So I suggest you take a look at https://aclanthology.org/N18-2108.pdf and the implementation of the AllenNLP from allennlp.predictors.predictor import Predictor => Predictor.from_path()method.

Thanks for the update


[Bug]: Back button after creating a client app

As an administrator I want to get to the project detail in the console when ever I click back from the application detail page.
Acceptance Criteria

[ ] I land on the project detail when clicking back (<--) on the application detail
[ ] I land on the project detail when clicking back (<--) on the application detail when i just created the application

Additional Context
Environment
ZITADEL Cloud
Describe the bug
Inconsistent behavior on the back button when creating a new client application. After creating a new client and go on the back button the create app dialog starts again. However, editing the client and going back lands on the Project overview.
To reproduce
Given I just created a client application (any type) on a project
When I click the back arrow
Then I get back to the create application dialog
Given I have already created an client application
When I go to my project and
When I click on the application and
When I click the back button
Then I land on the project overview
Screenshots

Expected behavior
I think the behavior should be in both cases to land on the project overview.

@mffap this issue can be also seen if you create a new project (once you create a new one, back launches create project once again), a new user, etc. This is due to the BackDirective that always navigates back in history in the back arrow found in the detail-layout-component. I'll try to fix it.

@doncicuto Thank you.

always

Nice :) Thank you


create temp table - dbeaver on mac

System information:

Operating system (distribution) and version
DBeaver version
Java version
Additional extensions
Mac OS X Yosemite
DBeaver 5.3.1
java version "1.8.0_60"

Connection specification:

Database name and version
Driver name
Do you use security connection (SSH, Proxy, etc)?
Postgresql 9.6
PostgreSQL JDBC Driver
OpenVPN

Describe the problem you're observing:
After opening the editor windows just execute:

create temp table abcd(id int4);
select * from abcd;

the second step with select statements produce the error:
"Query execution failed
Reason:
SQL Error [42P01]: ERROR: relation "abcd" does not exist"
Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

with this settings

finally I could find the reason.
It is related to the checkbox "Invalidate connection before execute" in the SQL Processing tab.
After it was disabled, it has started to work on mac.


Accessibility of images

https://c2pa.org/specifications/specifications/1.3/specs/C2PA_Specification.html#_hashing_a_bmff_formatted_asset contains some images, which would appear to include a bunch of really important procedural information.  The information in these images is not very accessible.  I am having a lot of trouble reading the text and I consider myself as having relatively good eyesight.

@martinthomson I was pretty sure all the images had associated AltText - but will most definitely make sure!  Thanks for pointing this out.

Note that I am also referring to the accessibility of the images for a sighted reader.  Alt text is one thing, but the content of the images seems to be something that should be expanded more - likely in the form of text - in order to fully understand the procedures that are involved.

@martinthomson I have made sure that every image and figure in the spec has useful AltText.  Also, all images/figures are now linked into the text itself to help provided context.
I have an action item to work on some of images to make sure that there is associated REAL text to help explain them.


C++ interface session->Close() does not reclaim memory resources

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Utuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):1.5
Python version:
Bazel version (if compiling from source):0.24.1
GCC/Compiler version (if compiling from source):5.5.0
CUDA/cuDNN version:
GPU model and memory:

Describe the current behavior
When I have executed session->closing(), the memory is not completely released.
I found that after the destruction of the session object, only a part of the memory was released, not completely released.
In my scenario, the complete memory is 4.28G, after executing session->Close() and destructuring the object, the memory is 3G.
Describe the expected behavior
Theoretically，after executed session->Close()， will Close the session to release the resources associated with.
Standalone code to reproduce the issue
int main() {
{
tensorflow::SessionOptions sess_options_;
sess_options_.config.set_use_per_session_threads(true);
sess_options_.config.set_intra_op_parallelism_threads(1);
sess_options_.config.set_inter_op_parallelism_threads(1);
std::unique_ptr<tensorflow::Session> sess_;
sess_.reset(tensorflow::NewSession(sess_options_));

tensorflow::GraphDef graph_def;
auto default_env = tensorflow::Env::Default();
tensorflow::Status s = tensorflow::ReadBinaryProto(default_env,
  pd_path, &graph_def);

sess_->Create(graph_def);

std::vector<tensorflow::Tensor> output;
std::vector<std::pair<std::string, tensorflow::Tensor>> tf_input;

tf_input.emplace_back(...);
auto status = sess_->Run(tf_input,
                         std::vector<std::string>{"output_node"}, {},
                         &output);
sess_->Close();

}
}

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


no/empty directories with segment_coverage

Segment coverage should not crash when the channel/quality directory does not exist nor should map creation crash everything if no hours are available.

Since segment_coverage starts relatively quickly, it can start checking coverage before the downloader or backfiller have gotten any segments.


Puppeteer Freezes when i put chromium on background , when i get it back to foreground script execution continues

Puppeteer version: 1.13.0
Platform / OS version: Mac / 10.14.2
URLs (if applicable):
Node.js version: 5.6.0

What steps will reproduce the problem?
Please include code that reproduces the issue.
const puppeteer = require('puppeteer');

let nau = async () =>{
const browser = await puppeteer.launch({timeout:300000,headless:false});
const page = await browser.newPage();
var g =    await page.goto('https://my.naukri.com/Profile/edit?id=&altresid',{timeout:300000});
var there  = await page.$("#usernameField");

//var there2 = await page.$("#emailTxt");
if(there != null)
{
   await page.click("#usernameField");
   await page.keyboard.type("aravindreddy.net@gmail.com");

   await page.click("#passwordField");
   await page.keyboard.type("9019444140@qQ");

   await page.keyboard.press('Enter');
   await page.waitForNavigation()
    for(var i=0 ; i< 40 ; i++)
    {
    var test = await page.$("#root");
    var h = await test.$(".resumeHeadline");
    var j = await h.$(".widgetHead");
    var k = await j.$(".widgetTitle + span")
    await k.click();
  //  page.waitFor()
    console.log("hello")

    await page.keyboard.press('Tab');
    await page.keyboard.type(".");
    await page.keyboard.press('Tab');
    await page.keyboard.press('Tab');
    await page.keyboard.press('Enter')
    console.log("Job Done" + i);
   await page.waitFor((60000*3));
    }
}
else{
    await page.click("#emailTxt");
   await page.keyboard.type("arvindchandrashekar@hotmail.com");

   await page.click("#pwd1");
   await page.keyboard.type("9019444140");

   await page.keyboard.type('Enter');

}

}
nau();

What is the expected result?
When i run the above script and have chromium in foreground , the script does its intended work , i expect the script to do the same when  I put chromium in background.
What happens instead?
when i put chromium in background the script flow kind of freezes , until i get chromium in foreground again.

Could this be related?
Can --disable-background-timer-throttling flag help?

Can --disable-background-timer-throttling flag help?

@vsemozhetbyt we pass it already by default
@ArvindReddyC Your script works for me when a put Chromium in a background; what do I do wrong?

It happens sometimes with me too (not always), but only when I use it with headless:false

[Solution]:
Add the following values to the array you assign to the args property in the options object. Now, you should be able to run Puppeteer while your window is in the foreground, background, or minimized.
const chromeArgs = [
  '--disable-background-timer-throttling',
  '--disable-backgrounding-occluded-windows',
  '--disable-renderer-backgrounding'
];

Solution and explanation available in an article written by Rohit Kumar, @rkr090 at Big Binary:
Debugging failing tests in puppeteer because of background tab

For me the previous solution did not worked (Win 10).
My hacky workaround is to normalize the Chromium window if it is accidently minimized, then use alt+tab to put it in the background.
I send the windowState: 'normal' command through CDPSession, as found here:
https://github.com/GoogleChrome/puppeteer/issues/4513#issuecomment-500195352

I just checked and it's happening to me only when I'm using a proxy. Idk how it's related..

@szilardx Setting windowState to 'normal' is only thing that worked. How did you manage alt+tab to get working? Also using Puppeteer?

[Solution]:
Add the following values to the array you assign to the args property in the options object. Now, you should be able to run Puppeteer while your window is in the foreground, background, or minimized.
const chromeArgs = [
  '--disable-background-timer-throttling',
  '--disable-backgrounding-occluded-windows',
  '--disable-renderer-backgrounding'
];

Solution and explanation available in an article written by Rohit Kumar, @rkr090 at Big Binary:
Debugging failing tests in puppeteer because of background tab

when minimize window, that also not working. must max the window.

This worked by @maxktz:
https://github.com/puppeteer/puppeteer/issues/3339#issuecomment-2293340307

SOLUTION
Since chrome has built in feature to emulate a focused page, I am just activating it using CSP session.
Works fine:
const session = await page.createCDPSession();
await session.send(`Emulation.setFocusEmulationEnabled`, { enabled: true });


Support "merged" strelka VCF type

Previously cohorts accepted a snv_vcf_list and an indel_vcf_list, but our current epidisco runs output a merged vcf.
There are two things that would help support this better:

Change vcf input to a list taking any variant collection file type
modify snv_count & related functions to filter variants by type, irrespective of source file identified

Part of this is supported via PR #165

Also related to PR #169


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Codecov Report

Merging #467 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #467   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          29     29
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e657b...8271597. Read the comment docs.

Coverage remained the same at 97.619% when pulling<PHONE_NUMBER>23e70eceb71a68805240026b751ecb on template-sync-1 into 49e657baa150ca87d407edadd5aafafabbcf42c8 on master.


Remove order dependency from tests

This might make the remote management PR easier to review. These are the changes to remove the order dependency from the manager tests.

/lgtm
/approve


Azure Repos requires additional config - only supports HTTP version 1.1

For support in Azure Repos, execute the following in your Git repo's directory before pushing.
git config http.version HTTP/1.1

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3d0afd1-bce9-b05e-ff1d-2914f63e2884
Version Independent ID: 4b69aa48-977c-cf18-bd30-17185814c8e5
Content: Work with large files in your Git repo - Azure Repos
Content Source: docs/repos/git/manage-large-files.md
Product: devops
Technology: devops-code-git
GitHub Login: @apawast
Microsoft Alias: sdanie

@MikeDiuga  Thank you for the feedback.
This issue is listed at https://github.com/git-lfs/git-lfs/issues/3875 and has been resolved in version 2.9.1.
Please use the above thread if there are any issues.

Closing the issue now, please comment below if there are any questions.


Regression in alterationx10/opinionated-zio match types

One more affected project alterationx10/opinionated-zio it's bisect points to the same commits. This time we don't have ambigious extension methods, yet, still type reduction fails
// 1_defns.scala
import scala.compiletime.*
import scala.deriving.*

sealed trait ZIO[-R, +E, +A]
sealed abstract class ZLayer[-RIn, +E, +ROut]
object ZLayer:
    def apply[RIn, E, ROut](zio: => ZIO[RIn, E, ROut]): ZLayer[RIn, E, ROut] = ???
type URIO[-R, +A] = ZIO[R, Nothing, A]
type IAnyType[T <: Tuple] = Tuple.Fold[T, Any, [x, y] =>> x & y]
type UAnyType[T <: Tuple] = Tuple.Fold[T, Any, [x, y] =>> x | y]

trait AutoLayer[A]:
  def zlayer(using
      p: Mirror.ProductOf[A]
  ): ZLayer[IAnyType[p.MirroredElemTypes], Nothing, A]

object AutoLayer:
  inline given derived[A](using p: Mirror.ProductOf[A]): AutoLayer[A] = {
    val a: ZIO[IAnyType[p.MirroredElemTypes], Nothing, A] = ???
    new AutoLayer[A]:
      override def zlayer(using
          pp: Mirror.ProductOf[A]
      ): ZLayer[IAnyType[pp.MirroredElemTypes], Nothing, A] = ZLayer {
        a.asInstanceOf[ZIO[IAnyType[pp.MirroredElemTypes], Nothing, A]]
      }
    }

// 2_usage.scala
case class TestService(port: Int) derives AutoLayer

yields:
[error] Found:    ZLayer[Tuple.Fold[pp.MirroredElemTypes, Any, [x, y] =>> x & y], Nothing,
[error]   TestService]
[error] Required: ZLayer[IAnyType[pp.MirroredElemTypes], Nothing, TestService]
[error]
[error] Note: a match type could not be fully reduced:
[error]
[error]   trying to reduce  Tuple.Fold[pp.MirroredElemTypes, Any, [x, y] =>> x & y]
[error]   failed since selector pp.MirroredElemTypes
[error]   does not match  case EmptyTuple => Any
[error]   and cannot be shown to be disjoint from it either.
[error]   Therefore, reduction cannot advance to the remaining case
[error]
[error]     case h *: t => h & Tuple.Fold[t, Any, [x, y] =>> x & y]
[error] case class TestService(port: Int) derives AutoLayer

Originally posted by @WojciechMazur in https://github.com/scala/scala3/issues/20288#issuecomment-2085298894

Related to #18261

Minimization:
type M[F[_, _]] = Int match
  case 0 => String & M[F]

type A = M[[x,y] =>> x & y]

def Test: Unit =
  val x: A = ???
  val _: M[[x,y] =>> x & y] = x // error


Success called but screen does not lock

Hey I am trying to lock the screen of Android devices with the plugin you wrote and it does not seem to work. I have this code:
window.screenLocker.lock(function(){
        console.log("SUCCESS LOCK");
    }, function(error){
        console.log(error);
    });

The console says: "SUCCESS LOCK".
The screen however does not lock.
Just so we're clear, with lock you and I mean the same thing? That the screen goes to black and the user has to unlock it again?
The device I tested this on was:
Sony xperia z2 tablet wi-fi ( http://www.gsmarena.com/sony_xperia_z2_tablet_wi_fi-6161.php )
Android Lollipop version 5.1.1
Settings --> Developer options --> Stand-by --> turned off

Same here, not working...

Any  updates?

Not yet, you may create a pull request and I'll apply it


in the new version, it appears that switching branches doesn't switch files

dvc run cp ~/foo d1/file
# file is now foo
git checkout -b branch
dvc run cp ~/bar d1/file
# file is now bar
git checkout -
# file is still bar, but should be foo

Hi @ophiry !
Are you running most recent master? If so, dvc now uses hardlinks instead of symlinks, so you need to run 'dvc checkout' after 'git checkout', so dvc can setup data files properly.
We are trying to add all of the backward-incompatible changes now, so we can stabilize dvc configs and other repo files for the next release.

still doesn't work:
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (master)> dvc run cp ~/foo d1/file2                                                23:32:01
File cp from argv is outside of git directory and cannot be traced
File d1/file2 from argv is outside of git directory and cannot be traced
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (master)> cat d1/file2                                                             23:33:14
foo
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (master)> git checkout -b branch4                                                  23:33:19
Switched to a new branch 'branch4'
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (branch4)> dvc checkout                                                            23:33:28
Checkout 'd1/file2'
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (branch4)> dvc run cp ~/bar d1/file2                                               23:33:37
File cp from argv is outside of git directory and cannot be traced
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (branch4)> cat d1/file2                                                            23:33:56
bar
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (branch4)> git checkout -                                                          23:34:01
Switched to branch 'master'
Your branch is ahead of 'origin/master' by 6 commits.
  (use "git push" to publish your local commits)
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (master)> dvc checkout                                                             23:34:09
(dvc) ophir@Ophirs-MacBook-Pro ~/d/binaries (master)> cat d1/file2                                                             23:34:18
bar

also, seem somewhat error prone in case a user forget dvc checkout, not sure what are the other considerations, but the fact that the symlinks change automatically with the checkout was a powerful feature

@ophiry just to make it clear. To minimize the number of releases with breaking changes we've decided to incorporate all breaking changes from the roadmap into the current release. One of these changes is hard links instead of symlinks and getting rid of mandatory data dir.
With hard links DVC API\commands line will change a bit. Today is not 100% clear how exactly it will change. For example, we might have an additional dvc checkout command or we might add DVC logic to the regular git checkout as a hook. Your opinions and feedback are highly appreciated.
The current code in the master branch will not be stable for a while. I'm sure we will stabilize the codebase in a couple weeks.

Found the bug in repo_change. Will fix ASAP. Thanks for reporting!

Did some testing with the new version, and I believe the issue still exists.
If you checkout a branch, but forget to do dvc checkout you end up with the previous file without a simple method to discover the issue

Hi @ophiry !
We've discussed adding a command for installing git hooks in #657 and it should be ready for 0.9.7. For now, as a workaround, you can add dvc checkout to your post-checkout git hook yourself.


Drop range is broken

There is no drop range, everything you drop goes straight below you, no matter how close you want to drop it.

Probably @Zumorica ?


Lecture 7: Maximum likelihood learning of undirected GM

Can you edit your first comment and add a link to the rendered version of the notes? Thanks.

https://tzehuik.github.io/pgm-spring-2019/notes/lecture-07/

Please let me know when to take another look. You can apply suggested changes in the comments above directly through GitHub.

@alshedivat: you can have a look now :)


How to change fix position of pagerIndicator (setPresetIndicator)

How to change fix position of pagerIndicator (setPresetIndicator)
Yes , I knew it's can set  .setPresetIndicator(SliderLayout.PresetIndicators.Center_Bottom);
but I want to set my position
thanks!

In layout,you can click PageIndicator to look its source code

@BlackCatXXF  Thanks!


Minor typo (remove 's' on find~s~)

Fix a minor typo

Read and sign the CLA. This needs to be done only once. PRs that haven't signed it won't be accepted.
Make sure your PR complies with the writer's guide.
Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.
Remove these instructions from your PR as they are for your eyes only.

We got the same change request two months ago: #945.

👍


Update UK Google Sheet for data moderation

The UK Sheet needs some love.
Right now the columns are a bit out of order, for example Postal Code (zipcode) is all the way towards the end of the row and not being combined in Column I/(final) address.

This does not enable correct pinning -- I tried pinning the Tower of London in Row 8 and without postal code, the street address is lat/lng'd to a residential house nearby
(Many UK addresses do not have a street number at all, or, just name the place. Please consult Drew in Slack for that.)

Currently we geocode addresses using the original address, city, and state. I think that we can add postal code to all geocode attempts but it's possible we may need some country-specific logic.

Ya I think b/c in both US and Canada we have street numbers for standard address, it doesn't require the double duty of the postal acode
But for UK many standard addresses do not use street numbers. It's just Lane A & Street B
Then we need to rope in the postal code

I've tested the Sheet as-is and found if I manually enter the Postal Code it works! So hopefully all you have to do is concatenate Column R?
If you delete the postal code from the red cell, it will lat/lng to a house ~2 blocks away. If you add the postal code, it will lat/lng the Tower of London


Prettify the wallet action flow's ActivateStep component

cc @MariaHCD
Details

Re-style the wallet activation page, when the wallet was activated to the Silver tier
Rewrite the component back to a stateless component (it was required by the linter)

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/223443
Tests
Pre-requisites:

Have an account with a pending wallet (all new accounts have a pending wallet created automatically)
Find the wallet's bankAccountID of that account in auth, and then run (replace the bankAccountID at the end):

UPDATE bankAccounts SET additionalData = JSON_SET(COALESCE(NULLIF(additionalData, ''), '{}'), '$.currentStep', 'TermsStep') WHERE bankAccountID = XXX;

Tests

Navigate to /enable-payments. You'll see the "Terms and fees" page.
Scroll down to the bottom, check both checkboxes, and click the Enable Payments button
Make sure you see the "Just a minute..." page, without a button at the bottom
Run the flow again but for a Gold wallet. Start by resetting and configuring the wallet as follows:

Run the validator:wallet CLI Tool on the account
In auth, run: UPDATE bankAccounts SET additionalData = JSON_SET(COALESCE(NULLIF(additionalData, ''), '{}'), '$.currentStep', 'TermsStep') WHERE bankAccountID = <walletID>;
In NewDot, run the following in the console: Onyx.merge('userWallet', {shouldShowWalletActivationSuccess:null})

Navigate to  /enable-payments again. Check both boxes at the bottom, and click the button
Make sure you see Gold wallet activation page, with the blue Tada illustration, and a button at the bottom

[x] Verify that no errors appear in the JS console

PR Review Checklist
Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
No QA

[ ] Verify that no errors appear in the JS console

Screenshots
Web

All tests were passing, removing the label

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @amyevans in version: 1.2.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.2.12-4 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Injection of variables in array of customized value producers

My use case involves an array of customized value producers and I need to inject unique variables inside each object. Is this possible?

Do you mean an array of object with unique attribute values?
Unfortunately this level of randomness is not supported right now. Current version supports randomness on each individual fields and cannot correlates different attributes.
I will work on this issue.

@haihanyin  yes, correct. Also, currently there might be a way to inject data in an array of objects with a custom value producer, but I wasn't able to find good example for that. I will try to play around.


How do I use this exactly?

Which files does it expect to have?
I can't get it to work...

That's a good question, it's been quite a while since I've worked on this and there's a chance that it doesn't even work at all anymore, themes were stored in this branch, https://github.com/tmayoff/DynamicWallpaper/tree/downloads. I don't remember how far I got with this project before I abandoned it.

This was a clone of this app on windows, as a project to learn Kotlin

I tried to download the files you've mentioned and use them, and it doesn't seem to work with them. Sorry.
qemu-system-x86_64_esHEP9TNuT.zip

Feel free to fork this (or steal the idea) if you're interested but I will archive the project


No suitable transform was found to encode or decode the content

powershell.exe -executionpolicy bypass -file ConvertTo-Jpeg.ps1 -files "IMG_0923.HEIC"
System.Management.Automation.MethodInvocationException: Exception calling "Wait" with "0" argument(s): "One or more
errors occurred." ---> System.AggregateException: One or more errors occurred. ---> System.Exception: No suitable
transform was found to encode or decode the content. (Exception from HRESULT: 0xC00D5212)
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at CallSite.Target(Closure , CallSite , Object )
--- End of inner exception stack trace ---
at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception
exception)
at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
At C:\Users\adria\Downloads\poze-20240629T125809Z-001\ConvertTo-Jpeg.ps1:121 char:13

        throw $_.Exception.ToString()

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (System.Manageme...tedFrame frame):String) [], RuntimeException
FullyQualifiedErrorId : System.Management.Automation.MethodInvocationException: Exception calling "Wait" with "0
" argument(s): "One or more errors occurred." ---> System.AggregateException: One or more errors occurred. ---> Sy
stem.Exception: No suitable transform was found to encode or decode the content. (Exception from HRESULT: 0xC00D52

--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at CallSite.Target(Closure , CallSite , Object )
--- End of inner exception stack trace ---
at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Excepti
on exception)
at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)

Duplicate of: https://github.com/DavidAnson/ConvertTo-Jpeg/issues/12


Can't install non-global?

I'd like to run the server on Heroku, with the latest code in branch "next" for user/pass connection strings. So I need to install non-globally, and I'm getting some weird errors.
$ npm install github:rethinkdb/horizon#next
npm ERR! addLocal Could not install /var/folders/c2/33k9s6bs35d4p8gldgnl0gxc0000gn/T/npm-43780-79905adc/git-cache-c94d89a5/fa365093912cfb4047b393f6ad8065f59798c470
npm ERR! addLocal Could not install /var/folders/c2/33k9s6bs35d4p8gldgnl0gxc0000gn/T/npm-43780-79905adc/git-cache-18753e5f/fa365093912cfb4047b393f6ad8065f59798c470
npm ERR! addLocal Could not install /var/folders/c2/33k9s6bs35d4p8gldgnl0gxc0000gn/T/npm-43780-79905adc/git-cache-992a369e/fa365093912cfb4047b393f6ad8065f59798c470
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/Cellar/node4-lts/4.4.7/bin/node" "/usr/local/bin/npm" "install" "github:rethinkdb/horizon#next"
npm ERR! node v4.4.7
npm ERR! npm  v3.10.5
npm ERR! code EISDIR
npm ERR! errno -21
npm ERR! syscall read
npm ERR! eisdir EISDIR: illegal operation on a directory, read
npm ERR! eisdir This is most likely not a problem with npm itself
npm ERR! eisdir and is related to npm not being able to find a package.json in
npm ERR! eisdir a package you are trying to install.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/giro/stardust-rethink-server/npm-debug.log
I can't do "npm install @horizon/server" because then I have no CLI.
Please advise.

This is a problem installing from github, since we don't have a package.json at the root of our project. We have a monorepo, and installing from github directly isn't supported by npm. You'll want to pull down the github repo and build it yourself, possibly using the test/setupDev.sh script

Thanks.
Note: I got past this using https://github.com/shama/napa and the following "scripts" entry:
"postinstall": "napa rethinkdb/horizon#next"