Karpenter leaves orphaned ec2 instances

Version
v0.18.0
Expected Behavior
No ec2 instances left when no pods scheduled in cluster
Actual Behavior
We have and EKS cluster running for 10 days. After that we decided to delete it and found out that 20 ec2 instances are still running. We verified that all these 20 instances have the same pattern in logs.
As I see it, the process is following:

Karpenter spins up a node (instance1). Node name is like "<IP_ADDRESS>.ec2.internal"
after some time EC2 instance health check fails and it's shut down
Karpenter spins up a new instance (instance2) which gets the same IP and thus the same node name
Karpenter can't register new instance in API server, getting "node already registered"
Karpenter deletes "<IP_ADDRESS>.ec2.internal" node but with the old instance id (instance1)
instance2 is running forever

Steps to Reproduce the Problem
I haven't tried to do that but I see the following steps:

Have a subnet with 1 address
Make karpenter spin up a node with that address
kill the instance
have another pod to be scheduled so karpenter will reuse IP to create a new node

Resource Specs and Logs
"2022-10-10T10:10:37.000-0400","Stopping Getty on tty1..."
"2022-10-10T10:10:37.000-0400","Stopping Serial Getty on ttyS0..."
"2022-10-10T10:10:37.000-0400","Stopped target Login Prompts."
"2022-10-10T10:10:37.000-0400","Stopping NTP client/server..."
"2022-10-10T10:10:37.000-0400","Stopping Postfix Mail Transport Agent..."
"2022-10-10T10:10:37.000-0400","chronyd exiting"
"2022-10-10T10:10:37.000-0400","I1010 14:10:37.486257    4863 dynamic_cafile_content.go:170] "Shutting down controller" name="client-ca-bundle::/etc/kubernetes/pki/ca.crt""
"2022-10-10T10:10:37.000-0400","Stopping D-Bus System Message Bus..."
"2022-10-10T10:10:37.000-0400","Stopping Command Scheduler..."
"2022-10-10T10:10:37.000-0400","Stopping Kubernetes Kubelet..."
"2022-10-10T10:10:37.000-0400","Stopped target Multi-User System."
"2022-10-10T10:10:37.000-0400","Stopped target Graphical Interface."
"2022-10-10T10:10:37.000-0400","Unmounting RPC Pipe File System..."
"2022-10-10T10:10:37.000-0400","Stopped target Cloud-config availability."
"2022-10-10T10:10:37.000-0400","Removed slice system-selinux\x2dpolicy\x2dmigrate\x2dlocal\x2dchanges.slice."
"2022-10-10T10:10:37.000-0400","Stopping Session 1 of user root."
"2022-10-10T10:10:37.000-0400","Stopped target rpc_pipefs.target."
"2022-10-10T10:10:37.000-0400","Stopped Dump dmesg to /var/log/dmesg."
"2022-10-10T10:10:37.000-0400","Closed LVM2 poll daemon socket."
"2022-10-10T10:10:37.000-0400","Stopped target Cloud-init target."
"2022-10-10T10:10:37.000-0400","System is powering down."
"2022-10-10T10:10:37.000-0400","Powering Off..."
"2022-10-10T10:10:37.000-0400","Power key pressed."
"2022-10-10T10:10:37.907-0400","time="2022-10-10T14:10:37.796153867Z" level=info msg="Processing signal 'terminated'""
"2022-10-10T10:10:37.938-0400","I1010 14:10:37.486257    4863 dynamic_cafile_content.go:170] "Shutting down controller" name="client-ca-bundle::/etc/kubernetes/pki/ca.crt""
"2022-10-10T10:10:37.966-0400","time="2022-10-10T14:10:37.803943575Z" level=info msg="Daemon shutdown complete""
"2022-10-10T10:11:19.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeNotReady"
"2022-10-10T10:11:19.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeNotReady"
"2022-10-10T10:11:46.000-0400","Node ip-172-24-55-12.ec2.internal event: Registered Node ip-172-24-55-12.ec2.internal in Controller"
"2022-10-10T10:11:46.000-0400","Node ip-172-24-55-12.ec2.internal event: Registered Node ip-172-24-55-12.ec2.internal in Controller"
"2022-10-10T10:12:14.000-0400","Deleting node ip-172-24-55-12.ec2.internal because it does not exist in the cloud provider"
"2022-10-10T10:12:14.333-0400","2022-10-10T14:12:14.333Z	INFO	controller.termination	Cordoned node	{"commit": "b157d45", "node": "ip-172-24-55-12.ec2.internal"}"
"2022-10-10T10:12:23.000-0400","Pod should schedule on ip-172-24-55-12.ec2.internal"
"2022-10-10T10:12:23.000-0400","Pod should schedule on ip-172-24-55-12.ec2.internal"
"2022-10-10T10:12:23.000-0400","Deleting node ip-172-24-55-12.ec2.internal because it does not exist in the cloud provider"
"2022-10-10T10:12:23.862-0400","2022-10-10T14:12:23.862Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0f10f3b5b671e554b, hostname: ip-172-24-55-12.ec2.internal, type: m5.4xlarge, zone: us-east-1d, capacityType: on-demand	{"commit": "b157d45", "provisioner": "my-provisioner"}"
"2022-10-10T10:12:23.926-0400","2022-10-10T14:12:23.926Z	DEBUG	controller.provisioning	node ip-172-24-55-12.ec2.internal already registered	{"commit": "b157d45", "provisioner": "my-provisioner"}"
"2022-10-10T10:12:54.000-0400","Deleting node ip-172-24-55-12.ec2.internal because it does not exist in the cloud provider"
"2022-10-10T10:12:54.000-0400","Deleting node ip-172-24-55-12.ec2.internal because it does not exist in the cloud provider"
"2022-10-10T10:12:55.000-0400","Updated Node Allocatable limit across pods"
"2022-10-10T10:12:55.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientPID"
"2022-10-10T10:12:55.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasNoDiskPressure"
"2022-10-10T10:12:55.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:12:55.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientPID"
"2022-10-10T10:12:55.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasNoDiskPressure"
"2022-10-10T10:12:55.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:12:55.000-0400","Starting kubelet."
"2022-10-10T10:12:55.000-0400","Updated Node Allocatable limit across pods"
"2022-10-10T10:12:55.000-0400","Starting kubelet."
"2022-10-10T10:12:56.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:12:56.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeNotSchedulable"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeNotReady"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientPID"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasNoDiskPressure"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal has been rebooted, boot id: 95521faa-d86b-4a16-b21e-d0296fe1620d"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeNotSchedulable"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeNotReady"
"2022-10-10T10:12:56.000-0400","Node ip-172-24-55-12.ec2.internal has been rebooted, boot id: 95521faa-d86b-4a16-b21e-d0296fe1620d"
"2022-10-10T10:13:05.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:13:05.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:13:07.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientPID"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasNoDiskPressure"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:13:07.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeSchedulable"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientPID"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasNoDiskPressure"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:13:07.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeSchedulable"
"2022-10-10T10:13:07.831-0400","2022-10-10T14:13:07.831Z	INFO	controller.termination	Deleted node	{"commit": "b157d45", "node": "ip-172-24-55-12.ec2.internal"}"
"2022-10-10T10:13:09.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:13:09.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:13:09.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientPID"
"2022-10-10T10:13:09.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:13:09.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasNoDiskPressure"
"2022-10-10T10:13:09.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:13:09.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientPID"
"2022-10-10T10:13:09.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasNoDiskPressure"
"2022-10-10T10:13:09.000-0400","Node ip-172-24-55-12.ec2.internal status is now: NodeHasSufficientMemory"
"2022-10-10T10:13:11.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
"2022-10-10T10:13:11.000-0400","network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized"
..... more logs are there for another 2 minutes until all running pods (including logging) are stopped.
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

There are a couple of things that can help here:

https://github.com/aws/karpenter/pull/2546 will add the ability for Karpenter to catch AWS Health Events including Instance Status Events that will be used to delete nodes in the case of health check failure. Until this is released (hopefully very soon), you can run the aws-node-termination-handler which does a similar thing to that PR (in queue-processor mode).
You can also switch to using instance-id hostnames in your VPC which will also result in your nodes having instance-id names instead of private IP names. Here are the docs for "Resource Naming" https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-naming.html#:~:text=.compute.internal-,Resource name,-When you launch
We've considered having a Cloud Provider reconciler that would delete the K8s node when the ec2 instance disappears. I thought that the Cloud Controller Manager would do this as well, but I may be wrong about that due to what you're seeing....

Thanks for reporting this case in such detail. We will absolutely pursue a long term fix to ensure that this can't happen.

@bwagner5 One thing need to point out, the Resource Naming only work on EKS v1.23
https://github.com/aws/containers-roadmap/issues/1723

@ig-leonov @yws-ss We discussed this one internally. We have a longer-term solution for this race condition that is in the works as part of an upgrade to a new API version of the Provisioner.
@bwagner5 added all the potential medium-term solutions that you can try until we implement this long-term solution that will solve this problem.
Let me know if the medium-term solutions works for yo.

btw. Resource Naming also breaks fargate (we run karpenter in fargate)

Should be fixed now: https://github.com/kubernetes/cloud-provider-aws/pull/471/files#r955478855

Is there some periodic check for all existing ec2 instances with karpenter tags if they are still in k8s and managed by karpenter?

We don't do a check for this inside of Karpenter. We hand this off to the cloud controller since it should be the component that is responsible for watching instances and removing nodes if the backing instance doesn't exist.

okay but the cloud controller does that? So we can be sure that there won't be any left behind ec2 instances?

The cloud controller removes nodes if the backing instance is gone. What we are observing here is the reverse, where instances are left behind but the projected node is gone.
Fundamentally, we are thinking of solving this issue with a longer-term solution where Karpenter never creates the node object, but lets the kubelet create and own it, so we don't have to deal with these conflicts and race conditions around maintaining the object.
This should solve a lot of the problems including the one you are observing where we orphan an instance because the projected node for the instance doesn't exist on the api-server.

@jonathan-innis just to confirm - https://github.com/aws/karpenter/pull/2546 will fix only issue when spot node was terminated or any kind of terminated nodes (e.g. by health check)?

#2546 will fix the issue regardless of capacity type. This feature gives awareness into EC2 instances that are terminating and stopping.

@ig-leonov, we have a design doc up now that should address this issue: #2944

@ig-leonov Have you been able to install version v0.28.0-rc.1 to try and see if the orphaned ec2 instance issue you were seeing is resolved?

@jonathan-innis unfortunately we don't have time now to test new releases. Will see how it goes when we start testing it

We probably have the similar issue.
EKS Version: 1.21
Karpenter Version: 0.13
Orphaned EC2 hostname: ip-10-13-165-204.us-west-2.compute.internal
Inspected from the logs, there are multi instance resource name with the same hostname ip-10-13-165-204.us-west-2.compute.internal, and finally the node is orphaned.
We got limitation on ips.
Karpenter Logs:
2023-10-08T08:23:09.294Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0922fb02a03b8ddc1, hostname: ip-10-13-165-204.us-west-2.compute.internal, type: m5.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T08:23:09.375Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m6i.8xlarge, m5.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T08:23:09.375Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-z6q5s","uid":"3abed46d-24a2-4d7e-b2be-ace640fb5c82","apiVersion":"v1","resourceVersion":"590250151"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T08:23:09.375Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m6i.8xlarge, m5.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T08:23:09.375Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-4sq55","uid":"f0cb9e5f-26e5-4bf2-bf45-acc301b6550e","apiVersion":"v1","resourceVersion":"590250154"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-159.us-west-2.compute.internal"}
2023-10-08T08:23:09.377Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0c9b0616c9ff40d11, hostname: ip-10-13-165-64.us-west-2.compute.internal, type: m5.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T08:23:09.399Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m6i.8xlarge, m5.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T08:23:09.399Z	INFO	controller.provisioning	Waiting for unschedulable pods	{"commit": "062a029"}
2023-10-08T08:23:09.401Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-ll229","uid":"5f1655db-357b-4a36-9b9f-96e424747f34","apiVersion":"v1","resourceVersion":"590250146"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-64.us-west-2.compute.internal"}
2023-10-08T08:23:12.118Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-z6q5s","uid":"3abed46d-24a2-4d7e-b2be-ace640fb5c82","apiVersion":"v1","resourceVersion":"590250220"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-64.us-west-2.compute.internal"}
2023-10-08T08:23:12.118Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-ll229","uid":"5f1655db-357b-4a36-9b9f-96e424747f34","apiVersion":"v1","resourceVersion":"590250212"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T08:23:27.692Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-z6q5s","uid":"3abed46d-24a2-4d7e-b2be-ace640fb5c82","apiVersion":"v1","resourceVersion":"590250402"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-159.us-west-2.compute.internal"}
2023-10-08T08:23:27.692Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-4sq55","uid":"f0cb9e5f-26e5-4bf2-bf45-acc301b6550e","apiVersion":"v1","resourceVersion":"590250406"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T08:23:42.054Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-ll229","uid":"5f1655db-357b-4a36-9b9f-96e424747f34","apiVersion":"v1","resourceVersion":"590250769"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-159.us-west-2.compute.internal"}
2023-10-08T08:23:52.926Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-64.us-west-2.compute.internal"}
2023-10-08T08:23:53.756Z	INFO	controller.node	Removed emptiness TTL from node	{"commit": "062a029", "node": "ip-10-13-165-64.us-west-2.compute.internal"}
2023-10-08T08:23:56.356Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-159.us-west-2.compute.internal"}
2023-10-08T08:23:56.400Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-159.us-west-2.compute.internal"}
2023-10-08T08:23:56.574Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T08:24:02.766Z	INFO	controller.node	Removed emptiness TTL from node	{"commit": "062a029", "node": "ip-10-13-165-159.us-west-2.compute.internal"}
2023-10-08T08:24:03.763Z	INFO	controller.node	Removed emptiness TTL from node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T08:46:46.021Z	INFO	controller.node	Triggering termination after 2m0s for empty node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T08:46:46.136Z	INFO	controller.termination	Cordoned node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T08:46:46.346Z	INFO	controller.termination	Deleted node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:37:20.453Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0220ce5f0225e5a14, hostname: ip-10-13-165-204.us-west-2.compute.internal, type: m5.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T10:37:20.501Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m6i.8xlarge, m5.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T10:37:20.501Z	INFO	controller.provisioning	Waiting for unschedulable pods	{"commit": "062a029"}
2023-10-08T10:37:20.501Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-wsgc7","uid":"86befd60-4ca1-46a3-a8cf-1bd5c7a102cb","apiVersion":"v1","resourceVersion":"590358112"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:37:43.212Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-wsgc7","uid":"86befd60-4ca1-46a3-a8cf-1bd5c7a102cb","apiVersion":"v1","resourceVersion":"590358305"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-201.us-west-2.compute.internal"}
2023-10-08T10:37:43.212Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-w7xr2","uid":"6348b78e-105f-4893-b751-a83357ff6f1a","apiVersion":"v1","resourceVersion":"590358464"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:38:03.259Z	INFO	controller.provisioning	Found 2 provisionable pod(s)	{"commit": "062a029"}
2023-10-08T10:38:03.259Z	INFO	controller.provisioning	Computed 1 new node(s) will fit 1 pod(s)	{"commit": "062a029"}
2023-10-08T10:38:03.259Z	INFO	controller.provisioning	Computed 1 unready node(s) will fit 1 pod(s)	{"commit": "062a029"}
2023-10-08T10:38:03.572Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:38:03.849Z	INFO	controller.node	Removed emptiness TTL from node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:37:20.453Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0220ce5f0225e5a14, hostname: ip-10-13-165-204.us-west-2.compute.internal, type: m5.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T10:37:20.501Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m6i.8xlarge, m5.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T10:37:20.501Z	INFO	controller.provisioning	Waiting for unschedulable pods	{"commit": "062a029"}
2023-10-08T10:37:20.501Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-wsgc7","uid":"86befd60-4ca1-46a3-a8cf-1bd5c7a102cb","apiVersion":"v1","resourceVersion":"590358112"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:37:43.212Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-wsgc7","uid":"86befd60-4ca1-46a3-a8cf-1bd5c7a102cb","apiVersion":"v1","resourceVersion":"590358305"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-201.us-west-2.compute.internal"}
2023-10-08T10:37:43.212Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-w7xr2","uid":"6348b78e-105f-4893-b751-a83357ff6f1a","apiVersion":"v1","resourceVersion":"590358464"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:38:03.259Z	INFO	controller.provisioning	Found 2 provisionable pod(s)	{"commit": "062a029"}
2023-10-08T10:38:03.259Z	INFO	controller.provisioning	Computed 1 new node(s) will fit 1 pod(s)	{"commit": "062a029"}
2023-10-08T10:38:03.259Z	INFO	controller.provisioning	Computed 1 unready node(s) will fit 1 pod(s)	{"commit": "062a029"}
2023-10-08T10:38:03.572Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:38:03.849Z	INFO	controller.node	Removed emptiness TTL from node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T10:38:05.416Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0a68604f8f6f7013b, hostname: ip-10-13-165-223.us-west-2.compute.internal, type: m5.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T11:32:31.947Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T11:32:42.459Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-201.us-west-2.compute.internal"}
2023-10-08T11:32:46.991Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-227.us-west-2.compute.internal"}
2023-10-08T11:32:47.391Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-137.us-west-2.compute.internal"}
2023-10-08T11:32:51.581Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-167.us-west-2.compute.internal"}
2023-10-08T11:32:52.799Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-186.us-west-2.compute.internal"}
2023-10-08T11:32:56.810Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-30.us-west-2.compute.internal"}
2023-10-08T11:34:26.001Z	INFO	controller.node	Triggering termination after 2m0s for empty node	{"commit": "062a029", "node": "ip-10-13-165-49.us-west-2.compute.internal"}
2023-10-08T11:34:26.056Z	INFO	controller.termination	Cordoned node	{"commit": "062a029", "node": "ip-10-13-165-49.us-west-2.compute.internal"}
2023-10-08T11:34:26.362Z	INFO	controller.termination	Deleted node	{"commit": "062a029", "node": "ip-10-13-165-49.us-west-2.compute.internal"}
2023-10-08T11:34:31.001Z	INFO	controller.node	Triggering termination after 2m0s for empty node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T11:34:31.093Z	INFO	controller.termination	Cordoned node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T11:34:31.370Z	INFO	controller.termination	Deleted node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
023-10-08T14:17:11.736Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0bdab6f708f7a9a8a, hostname: ip-10-13-165-204.us-west-2.compute.internal, type: m5.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T14:17:11.745Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m6i.8xlarge, m5.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T14:17:11.745Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-pq86z","uid":"b94f656b-1324-46c9-a293-c1cc8462af06","apiVersion":"v1","resourceVersion":"590509310"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T14:17:11.971Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0e2a23ab3123fa0f2, hostname: ip-10-13-165-25.us-west-2.compute.internal, type: m5.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T14:17:11.985Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m6i.8xlarge, m5.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-08T14:17:11.985Z	INFO	controller.provisioning	Waiting for unschedulable pods	{"commit": "062a029"}
2023-10-08T14:17:11.986Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-tzjfj","uid":"cdcc1056-67e7-465e-8300-e073d7de575e","apiVersion":"v1","resourceVersion":"590509307"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-25.us-west-2.compute.internal"}
2023-10-08T14:17:14.175Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-tzjfj","uid":"cdcc1056-67e7-465e-8300-e073d7de575e","apiVersion":"v1","resourceVersion":"590509307"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T14:17:14.175Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-pq86z","uid":"b94f656b-1324-46c9-a293-c1cc8462af06","apiVersion":"v1","resourceVersion":"590509310"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-25.us-west-2.compute.internal"}
2023-10-08T14:17:17.121Z	DEBUG	controller.provisioning	Discovered 733 EC2 instance types	{"commit": "062a029"}
2023-10-08T14:17:17.299Z	DEBUG	controller.provisioning	Discovered EC2 instance types zonal offerings	{"commit": "062a029"}
2023-10-08T14:17:54.560Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-08T14:18:00.869Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-25.us-west-2.compute.internal"}
2023-10-08T14:18:00.911Z	INFO	controller.node	Added TTL to empty node	{"commit": "062a029", "node": "ip-10-13-165-25.us-west-2.compute.internal"}
2023-10-08T14:18:02.169Z	INFO	controller.node	Removed emptiness TTL from node	{"commit": "062a029", "node": "ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-09T06:57:15.875Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0d140c1ef2f56852f, hostname: ip-10-13-165-204.us-west-2.compute.internal, type: m6a.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-09T06:57:15.889Z	DEBUG	controller.provisioning	node ip-10-13-165-204.us-west-2.compute.internal already registered	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-09T06:57:15.889Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"31435m","memory":"115428Mi","pods":"6"} from types m5a.8xlarge, m6a.8xlarge, m5.8xlarge, m6i.8xlarge, m5ad.8xlarge and 9 other(s)	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-09T06:57:15.889Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"ta-cluster","name":"trino-worker-ch-extra-project-674d9cd7f8-j22xd","uid":"90062ac0-f255-459b-8e43-ec5e04d2602b","apiVersion":"v1","resourceVersion":"591455506"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-13-165-204.us-west-2.compute.internal"}
2023-10-09T06:57:15.890Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0c7d67805cbe0d5ac, hostname: ip-10-13-165-38.us-west-2.compute.internal, type: m6a.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}
2023-10-09T06:57:15.930Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-0e27db93ea7e42115, hostname: ip-10-13-165-237.us-west-2.compute.internal, type: m6a.8xlarge, zone: us-west-2a, capacityType: spot	{"commit": "062a029", "provisioner": "trino-worker-ch-extra-project"}

Just want to confirm it is the same issue?


Deletion request (positive interoperability) nip-09

Requirements:

conforms to NIP-09

app
Deletion request
planned
comment

damus
❌
✅
.

njump
✔
?
issues with deleted events remaining in cache

amethyst
✅
?
?

coracle
✅
?
?

cornychat
✅
?
.

nostur
✅
?
?

ditto
✅
.
.

nos
✅
?
?

relay.tools
✅
?
?

shopstr
✅
?
?

voyage
✅
?
?

nostrarchive
❌
not planned
?

gossip
✅
?
?

*nos current terminology is "delete"

Amethyst yes

Relay.tools yes ✅

Voyage yes ✅

Nostur ✅

Shopstr supports NIP-09!

Comingle ✅

How do yall handle replies under a deleted note?
https://njump.me/nevent1qqsy5enmg4k25729x3s8ufpydv06d4p7f4dh5w4sfpurszvf6q8esnsprpmhxue69uhhyetvv9ujuumwdae8gtnnda3kjctvqyxhwumn8ghj7mn0wvhxcmmvqy2hwumn8ghj7etyv4hzumn0wd68ytnvv9hxgqg5waehxw309aex2mrp0yhxgctdw4eju6t0ymsl57

Coracle relies on relays to delete normal notes, so if I have it I show it (unless it was deleted by the user). IOW, I don't request delete requests from relays, and only handle deletions made by the user. For replies this means that the parent would simply not be found.

Coracle relies on relays to delete normal notes, so if I have it I show it (unless it was deleted by the user). IOW, I don't request delete requests from relays, and only handle deletions made by the user. For replies this means that the parent would simply not be found.

I do the same in Voyage

Two standalone apps that can delete notes:

https://nostr-delete.vercel.app/
https://delete.nostr.com/

However, the notes are not deleted on njump.me after several tries. It would be ideal if they can be deleted on njump.
As requested by @elsat https://primal.net/e/note1l9djdkjh6q2sedeaxnj9m0xvczpdgrkaee4mz5aca0kvyhshpr7qt7df4w

Added njump does not delete.
cc @dtonon @fiatjaf
https://njump.me/note17w828qlj3f7vns63l9umefgduc68cffwmqwflk4czug3ddcntp8qhanlav

Added njump does not delete.

There are several caches, I will try to sort it out.

njump accepts deletion requests like any relay.

@bitkarrot what was the longest duration you checked since the delete request?

Nostr archive does not accept delete requests
https://njump.me/nevent1qqs0m698nwcpesmgghh0jhjlav37k8agt3qa8t63ayxe5qh4ycg957szc4f0u

@bitkarrot when was the last time you checked if note was deleted? ~what was the longest duration you checked since the delete request?~

@alltheseas  Its still there, from 6 days ago. I ran delete on the two apps above at least twice.
Should I run it again?
here is the note I was trying to delete on njump.me last week but its still there. As you can see its not show up on on any of the relays.
https://njump.me/nevent1qqsgsqxcl86cz3a2qqf74ur7vas97cz6wx2lypklcu9mfglsjvlanncpz3mhxue69uhkummnw3ezummcw3ezuer9wcq3gamnwvaz7tmjv4kxz7fwv3sk6atn9e5k7q3q8pudjhdhhp2v8gxnkttt00um729nv93tuepjda2jrwn3eua5tf5skmsnve

Should I run it again?

No, lets see how long cache remains

Should I run it again?

No, lets see how long cache remains

@alltheseas , If its like profiles, Quite a long time I'd imagine. I updated my profile many times already due to profile wipe-outs while testing various apps in the last two months and njump.me still hasn't updated it to latest.

Whats the longest duration njump cache on your profile in days?
I asked an internet bot on cloudflare cache default duration. Might need to adjust a setting @fiatjaf @dtonon

It may not be Cloudflare. I just checked and we are making it so that Cloudflare has a maximum expiration time of 7 days.
But when you try to load the page after having deleted the note njump will try again to fetch it from other relays and if anything is found it will store it locally for a while and cache it again on Cloudflare.
Maybe we should store deletion requests and then refuse to serve events that were explicitly deleted. Will look into that, but can't be a priority to me.

njump will try again to fetch it from other relays

does njump have a fixed relay list?

Added cornychat and removed apps without info

Corny Chat supports deletions for

Slide Sets (user created/updated/deleted)
Link Sets (user created/updated/deleted)
Live Activities (user controlled, but managed via server room keys)
Scheduled Calendar Time Events (user controlled, but managed via server room keys)
Server Zap Goals (server only)

Due to the fact that some relays don't support delete, but do support replaceables, some of these are updated first wiping data, and setting expiration tag as a workaround.
When building lists of scheduled streaming events, filtering is performed to remove any events marked as deleted, expired, or ended.

Question:

Lazy dev question for relay builders/operators...

When someone publishes a delete request, do you delete the original event completely or just hide it. If you hide it, do you hide it from all users that REQ or just from the person that sent the delete request.

I'm seeing strange behavior with nostr-rs-relay where REQs by other users are returning the events that aren't being shown to the user who deleted them.

https://njump.me try/nevent1qqsxnt3qcqdj0rx706wux9cnpzhqcp3d286t8xqydlflkckfak3xdvgwyuk08

@hzrd149 added to nostrudel library https://njump.me/note1rgk6xu40fptzqawtxat73rr50vkye38hu6gscy5cq5tg5cj6d9hsyhp635


Orange pis on robot power instead of usb battery packs

All Buck Boards are soldered and ready to be put into the Mini Power Module (10 Amp)


ghc-mod : Can't find module.

Issue description

ghc-mod error with Failed to load interface for ‘System.Random’

Steps to reproduce

use following setting in configuration.nix

environment.systemPackages = with pkgs; [
  (haskellPackages.ghcWithPackages
    (self: with self; [
        # tools
        ghc-mod
        hlint
        xmobar
        xmonad

        # libs
        random
        xmonad-contrib
        xmonad-extras
  ]))
];

nixos-rebuild switch
reboot

Technical details

System: NixOS: 17.09pre107265.0afb6d789c (Hummingbird)
Nix version: nix-env (Nix) 1.11.9
Nixpkgs version: "17.09pre107265.0afb6d789c"
Sandboxing enabled: build-use-sandbox = false

Additional information
random is found on ghc but not ghc-mod
$ ghc-pkg list | grep -i random
    MonadRandom-0.5.1
    random-1.1

$ ghc-mod list | grep -i random

testfile is compiled but fail on ghc-mod
$ cat test.hs
import System.Random

main = undefined

$ ghc-mod check test.hs
test.hs:1:1:Failed to load interface for ‘System.Random’Use -v to see a list of the files searched for.

$ ghc test.hs

Also I clear the env by nix-env -e '*' to make sure there is no shadow
$ nix-env -q

$ sudo nix-env -q
[sudo] password for wizzup:

Not sure if it the right way to do but I fix this by add following envs in my .bashrc
## nix ghc-paths envs
NIX_GHC_VERSION=$(ghc --numeric-version)
export NIX_GHC="/run/current-system/sw/bin/ghc"
export NIX_GHCPKG="/run/current-system/sw/bin/ghc-pkg"
export NIX_GHC_LIBDIR="/run/current-system/sw/lib/ghc-${NIX_GHC_VERSION}"
# export NIX_GHC_DOCDIR="/run/current-system/sw/share/doc/ghc/html"

NIX_GHC_DOCDIR is not exists, I expect I have to use ghcWithHoogle if I want documents, according to users-guide-to-the-haskell-infrastructure


feat: Add logout from the session

Summary
This pull request adds the path to disconnect from the session by clearing the WalletConnectService session and the localStorage.
Details

A /logout path is added to be able to disconnect from the session.
An event is created on successful disconnection.
Added logout information to the README

Evidence
https://github.com/user-attachments/assets/43c1977d-60de-40f3-a618-2305f6754e89

Can we avoid creating a popup for the logOut event? Or maybe we can show a spinner inside the mini-popup with a message like Logging Out.


No code_span nodes after latest update

After I synced neovim's packer, it updated the markdown parser, and it stopped working for me, since I use code_span and code_span_delimiter nodes in my custom queries. On another machine, where I did not update, I see with the TSPlayground that these nodes are there, but with updated parser, they are just gone. Is it intentional, and your parser will not recognize code spans like this one any more?

I hope that answered your question, but I'll leave this open since other people probably will experience similar problems.

Yes, installing markdown_inline solved it. Thanks!

Thanks, I had the same issue. The following nvim-treesitter config fixed it for me:
parser_config.markdown = {
  install_info = {
    url = "https://github.com/MDeiml/tree-sitter-markdown",
    files = { "tree-sitter-markdown/src/parser.c", "tree-sitter-markdown/src/scanner.cc" },
  },
  filetype = "markdown",
}

parser_config.markdown_inline = {
  install_info = {
    url = "https://github.com/MDeiml/tree-sitter-markdown",
    files = { "tree-sitter-markdown-inline/src/parser.c", "tree-sitter-markdown-inline/src/scanner.cc" },
  },
  filetype = "markdown",
}


readme examples

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@OlivierDehaene done

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


React 0.14.1?

peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>

Solved by adding react-dom


Refactor how we get client parameters in examples

Description
The examples from TCGC never have these models specially made for client parameters.
The operation always has all its necessary parameters including client parameters, therefore this InputClientExample is 100% redundant.
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

How about uri parameter (e.g. {endpoint}{clientName}, the uri has two parameters which is client parameter)? The generated sample/test, should include this parameter when constructor client.

How about uri parameter (e.g. {endpoint}{clientName}, the uri has two parameters which is client parameter)? The generated sample/test, should include this parameter when constructor client.
The same as authentication parameter.
Seems current our generated sample code does not correct construct client.

The focus of this PR is not fixing any existing bug. If this is a bug, please open an issue for it and attach details so that we could fix it.
This is only a refactor, nothing changed is our goal. And nothing is changed in test project as well as the regen.
All things changed in regen comes from previous PRs, it exists there for a few days.

How about uri parameter (e.g. {endpoint}{clientName}, the uri has two parameters which is client parameter)? The generated sample/test, should include this parameter when constructor client.
The same as authentication parameter.
Seems current our generated sample code does not correct construct client.

and also as I described in the description, TCGC does not have the categories of "client parameter" or "method parameter", an operation ALWAYS has all its parameters no matter they are client or method.


Use of checkers on docker_cli_import_test.go

Signed-off-by: liaoqingwei<EMAIL_ADDRESS>

LGTM 🐻

seems good to go ping @cpuguy83

LGTM


Question about the HyDRA pipeline

Hello,
Greetings! First of all I'd like to thank you for developing such a useful pipeline of processing NGS sequences.
Here I have a fews questions about the HyDRA pipeline:

In cmd_hydra.py#L92, why combined the forward and backward sequences together but not to align them in pairs by bowtie2 (the -1 and -2 options)?
What's the reason(s) for filtering FASTQ file(s) before but not after the alignment?
What's the rationales for these options for bowtie2 in patient_analyzer.py:

--rdg 8,3 and --rfg 8,3: changed the gap opening penalty from default 5 to 8.
--ma 1: changed the match bonus from default 2 to 1.
--mp '2,2': ignored the affect of phred quality score during the alignment.

Thanks for your attention. I’m looking forward to your reply.
Best,
Philip

In cmd_hydra.py#L92, why combined the forward and backward sequences together but not to align them in pairs by bowtie2 (the -1 and -2 options)?

Aligning reads as pairs is highly dependent on the sequencing protocol, whereas combining the read sets and aligning as single end will work for any sequencing protocol. By this I mean if you perform size selection you can set the min (-I) and max (-x) insert size and bowtie2 will flag the alignments that are outside the range. But if you do not perform size selection, you would have to set the min (-I) and max (-x) insert size to a large range so that it doesn't flag any of the alignments. Additionally we do not filter out forward and reverse reads together, which we would need to do if aligning as pairs.

What's the reason(s) for filtering sam/bam file(s) before but not after the alignment?

To reduce our input size prior to alignment. Originally we were filtering on percent identity and percent similarity post alignment, but it was removed as it didn't add any value as bowtie2 was already flagging those alignments.

What's the rationales for these options for bowtie2 in patient_analyzer.py:
--rdg 8,3 and --rfg 8,3: changed the read gap opening penalty from default 5 to 8.
--ma 1: changed the march bonus from default 2 to 1.
--mp '2,2': ignored the affect of phred quality score during the alignment.

These parameters were modified from the default to prioritize aligning gaps together. I basically ran a pen and paper simulation to achieve the optimal alignment around homopolymers.

Dear Eric,
Thanks for the answers! It's really helpful.
Philip


Next Release - v0.1.1

If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #265. Adds native Apple Silicon Support for development / usage. Bumps packages to be in line with Ark, mibi-bin-tools.
How did you implement your changes

ark-analysis: 0.3.2 -> 0.4.3
mibi-bin-tools: 0.2.3 -> 0.2.4
Small function arg fixes here and there and a rosetta test type fix.

Remaining issues

[x] Test to make sure the Conda environment builds properly
[x] Test to make sure it works on Creed / Drago

Did you check with @camisowers? I don't think the current release of ark includes the stuff she needs for her PR

Did you check with @camisowers? I don't think the current release of ark includes the stuff she needs for her PR

Yes, we need to make a v0.4.4. release of ark first to include the PR's from the last 3 weeks.

@ngreenwald Should be good to go now.


Bulding multiple spark major versions 1 and 2

Updating scripts to run multiple spark versions

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished. 351 tests run, 8 skipped, 4 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/39/Failed Tests: 4datavec_PR/org.datavec:datavec-api: 1org.datavec.api.transform.serde.TestCustomTransformJsonYaml.testCustomTransformdatavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

I can't speak to the release script, but the approach looks good to me. I tested buildmultiplescalaversions.sh just to be sure, builds fine.
@agibsonccc @huitseeker - do we want to release Spark 2 with Scala 2.10 at all? Scala 2.10 is deprecated as of Spark 2.1. I'd be happy with just doing 2.11 for Spark 2.
Second issue: the versioning scheme (as of 0.7.3 release anyway) is currently as follows:
groupId / artifactId
org.datavec / datavec-spark_2.1x (or 2.11) for both spark 1 and 2
version:

0.7.3_spark_1
0.7.3_spark_2

Is this the sort of GAV scheme we want? I would have thought the following might be preferable?
org.datavec / datavec-spark_2.11 / 0.7.3
org.datavec / datavec-spark2_2.11 / 0.7.3

We shouldn't need it for spark 2.

@AlexDBlack I agree that could be beneficial, however it is common in spark based libraries to suffix spark version in version itself rather than manipulate with artifactId, see spark-testing-base

any progress on this ?

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build triggered. sha1 is merged.

Build finished. 355 tests run, 8 skipped, 4 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/47/Failed Tests: 4datavec_PR/org.datavec:datavec-api: 1org.datavec.api.transform.serde.TestCustomTransformJsonYaml.testCustomTransformdatavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

Build started sha1 is merged.

Build triggered. sha1 is merged.

Build finished. 355 tests run, 8 skipped, 4 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/48/Failed Tests: 4datavec_PR/org.datavec:datavec-api: 1org.datavec.api.transform.serde.TestCustomTransformJsonYaml.testCustomTransformdatavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

Build started sha1 is merged.

Build finished. 355 tests run, 8 skipped, 4 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/49/Failed Tests: 4datavec_PR/org.datavec:datavec-api: 1org.datavec.api.transform.serde.TestCustomTransformJsonYaml.testCustomTransformdatavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished. 355 tests run, 8 skipped, 3 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/52/Failed Tests: 3datavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

Build triggered. sha1 is merged.

Build started sha1 is merged.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/55/Failed Tests: 3datavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

Build finished. 355 tests run, 8 skipped, 3 failed.

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished. 352 tests run, 8 skipped, 3 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/57/Build result: FAILURE[...truncated 625.75 KB...]	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:544)	at hudson.model.ResourceController.execute(ResourceController.java:98)	at hudson.model.Executor.run(Executor.java:405)Caused by: java.io.FileNotFoundException: https://api.github.com/repos/deeplearning4j/DataVec/statuses/f032f107e631c84c62aa1b55a2994979a00456c5	at sun.reflect.GeneratedConstructorAccessor49.newInstance(Unknown Source)	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1890)	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1885)	at java.security.AccessController.doPrivileged(Native Method)	at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1884)	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1457)	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)	at org.kohsuke.github.Requester.parse(Requester.java:535)	at org.kohsuke.github.Requester._to(Requester.java:262)	... 12 moreCaused by: java.io.FileNotFoundException: https://api.github.com/repos/deeplearning4j/DataVec/statuses/f032f107e631c84c62aa1b55a2994979a00456c5	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1836)	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:338)	at org.kohsuke.github.Requester.parse(Requester.java:525)	... 13 more

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build triggered. sha1 is merged.

Build finished. 355 tests run, 8 skipped, 3 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/58/Failed Tests: 3datavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

Build started sha1 is merged.

Build finished. 355 tests run, 8 skipped, 3 failed.

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/59/Failed Tests: 3datavec_PR/org.datavec:datavec-data-image: 3org.datavec.image.transform.TestImageTransform.testHistEqualizationorg.datavec.image.transform.TestImageTransform.testConvertColorTransformorg.datavec.image.transform.TestImageTransform.testShowImageTransform

:)


⚠ PrivateHD has degraded performance

In a36cc42, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2047 ms

Resolved: PrivateHD performance has improved in 4dcd6d8.


Specify cross-compiler for Adbc

Right now Adbc would always use /usr/bin/x86_64-linux-gnu-gcc as the compiler. I'll try it and see how do I specify cross-compiler for Adbc. We should be able to do that by specifying CMAKE_TOOLCHAIN_FILE.

Actually, there is no need to build for other Linux targets than x86_64 because we're downloading official drivers which only have support for x86_64 Linux.

Where are the drivers being downloaded from? They should build on Linux (x64/ARM), macOS (x64/ARM), and Windows (x64). We only provide binaries via conda-forge, and those packages don't yet build for Windows there (someone needs to figure out the CI issues).

Where are the drivers being downloaded from? They should build on Linux (x64/ARM), macOS (x64/ARM), and Windows (x64). We only provide binaries via conda-forge, and those packages don't yet build for Windows there (someone needs to figure out the CI issues).

We currently download drivers from the release page, for example, https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.11.0. These drivers are extracted from Python wheels.

ah, good to know, thanks. Uh, I suppose that isn't the intended use, but if it works...

@lidavidm it would be nice if we could have only the drivers (outside of the wheels) but due to ADBC's design, they just work, yeah, so at least for now we don't see a reason to. :)

@cocoa-xu is this still relevant?

@cocoa-xu is this still relevant?

Let's close this one as we probably won't build these drivers in this repo.


"Attempting to install template"

I have a large csv file that was previously ingested fine with ES v2. logstash v5.2 using this csv filter ignores the csv file and conf file ("attempting to install template") upon loading.
Just doing the most simple test using this blog article
https://qbox.io/blog/import-csv-elasticsearch-logstash-sincedb
fails with csv plugin using v5.2.1 - is this an issue with the csv filter?
here is the console output using the csv filter.
$ bin/logstash -f ~/logstash-5.2.1/bitcoin-data/btc.conf --verbose
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
Sending Logstash's logs to /Users/greg/logstash-5.2.1/logs which is now configured via log4j2.properties
[2017-03-06T12:44:16,305][INFO ][logstash.outputs.elasticsearch] Elasticsearch pool URLs updated {:changes=>{:removed=>[], :added=>[http://localhost:9200/]}}
[2017-03-06T12:44:16,309][INFO ][logstash.outputs.elasticsearch] Running health check to see if an Elasticsearch connection is working {:healthcheck_url=>http://localhost:9200/, :path=>"/"}
[2017-03-06T12:44:16,439][WARN ][logstash.outputs.elasticsearch] Restored connection to ES instance {:url=>#<URI::HTTP:0x2d420e7e URL:http://localhost:9200/>}
[2017-03-06T12:44:16,442][INFO ][logstash.outputs.elasticsearch] Using mapping template from {:path=>nil}
[2017-03-06T12:44:16,502][INFO ][logstash.outputs.elasticsearch] Attempting to install template {:manage_template=>{"template"=>"logstash-", "version"=>50001, "settings"=>{"index.refresh_interval"=>"5s"}, "mappings"=>{"default"=>{"_all"=>{"enabled"=>true, "norms"=>false}, "dynamic_templates"=>[{"message_field"=>{"path_match"=>"message", "match_mapping_type"=>"string", "mapping"=>{"type"=>"text", "norms"=>false}}}, {"string_fields"=>{"match"=>"", "match_mapping_type"=>"string", "mapping"=>{"type"=>"text", "norms"=>false, "fields"=>{"keyword"=>{"type"=>"keyword"}}}}}], "properties"=>{"@timestamp"=>{"type"=>"date", "include_in_all"=>false}, "@version"=>{"type"=>"keyword", "include_in_all"=>false}, "geoip"=>{"dynamic"=>true, "properties"=>{"ip"=>{"type"=>"ip"}, "location"=>{"type"=>"geo_point"}, "latitude"=>{"type"=>"half_float"}, "longitude"=>{"type"=>"half_float"}}}}}}}}
[2017-03-06T12:44:16,510][INFO ][logstash.outputs.elasticsearch] New Elasticsearch output {:class=>"LogStash::Outputs::ElasticSearch", :hosts=>[#<URI::HTTP:0x2ee0e36f URL:http://localhost:9200>]}
[2017-03-06T12:44:16,517][INFO ][logstash.pipeline        ] Starting pipeline {"id"=>"main", "pipeline.workers"=>4, "pipeline.batch.size"=>125, "pipeline.batch.delay"=>5, "pipeline.max_inflight"=>500}
[2017-03-06T12:44:16,521][INFO ][logstash.pipeline        ] Pipeline main started
[2017-03-06T12:44:16,625][INFO ][logstash.agent           ] Successfully started Logstash API endpoint {:port=>9600}
Please post all product and debugging questions on our forum. Your questions will reach our wider community members there, and if we confirm that there is a bug, then we can open a new issue here.
For all general issues, please provide the following details for fast resolution:

Version:
Operating System:
Config File (if you have sensitive info, please remove it):
Sample Data:
Steps to Reproduce:

You'll have a better chance of getting help by posting on http://discuss.elastic.co. What you're seeing is probably not a bug in Logstash.


CivitAI URLs not recognised

Sure I'm doing something silly, but fresh install and adding a test model URL from CivitAI and I'm getting errors in the model downloader?

Any ideas what I'm missing?

Civitai made some changes and broke downloading.  McMonkey pushed a quick fix through tonight.  If you haven't, run the update script or git pull to grab the latest changes and you should be able to download again.

Ah brilliant, good to know it's not just me then!


An error occured while loading your audio devices. Please check the application logs for more information.

An error occured while loading your audio devices. Please check the application logs for more information.
Traceback (most recent call last):
File "main.py", line 44, in
File "buzz\gui.py", line 905, in init
File "buzz\gui.py", line 874, in init
File "buzz\gui.py", line 607, in init
File "buzz\gui.py", line 63, in init
StopIteration

help pls

A new release should be out with a few days with a fix for this issue.

Thank you bro

yes, but had new question.
https://github.com/chidiwilliams/buzz/issues/302


[Snyk] Upgrade ch.qos.logback:logback-classic from 1.5.8 to 1.5.9

Snyk has created this PR to upgrade ch.qos.logback:logback-classic from 1.5.8 to 1.5.9.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on 24 days ago.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

/ok-to-test


WIP: Create Verifiable Credential

Adds support for creating a Verifiable Credential based on a provided credentialSubject.
A minimal rake task is provided for testing this out on the command line.
e.g. be rake "healthcards:vc[my_subject]" where my_subject is the payload.
This will return something like:
{
  "@context": [
    "https://www.w3.org/2018/credentials/v1"
  ],
  "type": [
    "VerifiableCredential",
    "https://healthwallet.cards#health-card",
    "https://healthwallet.cards#presentation-context-online",
    "https://healthwallet.cards#covid19"
  ],
  "issuer": "<<did:ion identifier for lab>>",
  "issuanceDate": "2021-01-20T09:34:26-05:00",
  "credentialSubject": {
    "fhirVersion": "4.0.1",
    "fhirBundle": "my_subject"
  },
  "proof": {
    "type": "EcdsaSecp256k1VerificationKey2019",
    "created": "2021-01-20T09:34:26-05:00",
    "proofPurpose": "assertionMethod",
    "verificationMethod": "did:ion:1234#keys-1",
    "jws": "eyJhbGciOiJFUzI1NiIsInR5cCI6ImFwcGxpY2F0aW9uL2pzb24ifQ.eyJmaGlyVmVyc2lvbiI6IjQuMC4xIiwiZmhpckJ1bmRsZSI6Im15X3N1YmplY3QifQ.MEUCIAOg2tzlQxgbLdBRZaMg0WLPQNRm3SbjJcmk1pQX26R-AiEAjFURHrjs0qBMj3WRebmKLiATcd6gzr7ulmFDYOzpGgQ"
  }
}

Closing in favor of #22


onShow helper function called twice when scrolling

When the next step requires page scrolling, the onShow registered helper function is being called twice. As shown below:
...steps: [
{
onShow: 'onShowTourStep'
},...
]...
hopscotch.registerHelper('onShowTourStep', function () {
//some code here being called twice when scrolling
}

Hmm... is this being included as part of the tour's and step's onShow hook?

@zimmi88 I'm experiencing this issue as well. Took quite some time to track it down, but I think it's due to this line of code in the adjustWindowScroll function:
jQuery('body, html').animate({ scrollTop: scrollToVal }, getOption('scrollDuration'), cb);

The callback for animate gets called twice because the "body, html" selector matches two elements! See http://api.jquery.com/animate/

@zimmi88 created PR

I'm on 0.2.6 and this is still happening.  Also, I'm running into the issues where scrolling doesn't work.  I am trying to do a tutorial for the Divi customizer and the "remove" button is off the screen on the bottom.  The callout shows at the bottom of the screen but the scroll is not happening.  Here's how I'm trying to do it:
Here's the step:
{
title: "",
content: "Then click 'Remove' to get rid of the old image.",
target: "li#customize-control-background_image div button.remove-button",
placement: "right",
delay: 500,
showNextButton: false,
showPrevButton: false,
onShow: function() {
alert('I got here.');
jQuery('form#customize-controls').scrollTop(jQuery('li#customize-control-background_image div button.remove-button').position(0).top);
}
If I do alert(jQuery('jQuery('li#customize-control-background_image div button.remove-button').length) it prints 1, so I know it's finding it. Also, if I replace the position jQuery with a hard coded number like this:
jQuery('form#customize-controls').scrollTop(300);
it still doesn't scroll.  Also, it alerts "I got here" twice.
Any advice on how to get this to work?  I have a fiddle with a similar setup here that seems to be working for scrolling using the same scrollTop call as used above but without hopscotch.

The issue noted in this thread wasn't part of the 0.2.6 release, I'm afraid. Attaching to current milestone.
As for the other issue, it sounds like the form might not be scrollable? Double-check that the form has some sort of overflow: scroll or overflow: auto with a fixed height defined. Regardless, apart from getting called twice (as previously noted on this thread), it doesn't sound like an issue with Hopscotch. Hopscotch shouldn't have any logic that prevents scrolling.

Kindly have a look at this fix. Its really needs to fixed asap. PR is working needs to merge in master.


Check for getIndexAutoCreate on initSingleIndex

Hello.
I'm running tag v2.1.0.rc1 with ES v1.7.1 from Storm using Hortonworks HDP 2.2.
I have an alias (storm-today) for my index (storm-2015-08-18) and I want to use storm-today as the resource in my EsBolt(..). Elasticsearch casts an InvalidIndexNameException "Invalid index name [storm-today], already exists as alias" and as far as I can see I have no way (without changing the code) to stop this.
The problem seems to be in, or around, RestService - which forces a call to repository.touch() in line 406 without checking for getIndexAutoCreate (which I set to "no" / "false").

Why are using 2.1.0.rc1 instead of the GA? This has been fixed in 2.1.0
https://github.com/elastic/elasticsearch-hadoop/commit/dece07a5400e200f68d0823c0804bba4a917687d
A simple upgrade should fix this issue

It sure does. Sorry for not noticing. Thanks.


Fix mismatched parentheses

Fixes issue #46
The do|else etc group was missing its opening parenthesis.

Thanks!

After updating I've been getting an Uncaught Error: end pattern with unmatched parenthesis error message that is being caused by this change.
The \\) part of the regex is an escaped ) rather than the end of a group, which appears to be what caused the mismatched highlighting in regexpal mentioned in #46. The do|else... is not a separate group as far as I can see.

For reference here's the full error message. Note this also happens on stable Atom, not just beta.
Atom Version: 1.3.0-beta1
System: linux 4.2.5-1-ARCH
Thrown From: Atom Core
Stack Trace
Uncaught Error: end pattern with unmatched parenthesis
At /usr/share/atom-beta/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:803

Error: end pattern with unmatched parenthesis
    at Error (native)
    at new OnigRegExp (/usr/share/atom-beta/resources/app.asar/node_modules/oniguruma/lib/onig-reg-exp.js:9:22)
    at LanguageMode.module.exports.LanguageMode.getRegexForProperty (/usr/share/atom-beta/resources/app.asar/src/language-mode.js:410:16)
    at LanguageMode.module.exports.LanguageMode.increaseIndentRegexForScopeDescriptor (/usr/share/atom-beta/resources/app.asar/src/language-mode.js:415:19)
    at LanguageMode.module.exports.LanguageMode.suggestedIndentForTokenizedLineAtBufferRow (/usr/share/atom-beta/resources/app.asar/src/language-mode.js:304:34)
    at LanguageMode.module.exports.LanguageMode.suggestedIndentForBufferRow (/usr/share/atom-beta/resources/app.asar/src/language-mode.js:288:19)
    at LanguageMode.module.exports.LanguageMode.autoIndentBufferRow (/usr/share/atom-beta/resources/app.asar/src/language-mode.js:366:26)
    at TextEditor.module.exports.TextEditor.autoIndentBufferRow (/usr/share/atom-beta/resources/app.asar/src/text-editor.js:3066:32)
    at Selection.module.exports.Selection.insertText (/usr/share/atom-beta/resources/app.asar/src/selection.js:498:21)
    at /usr/share/atom-beta/resources/app.asar/src/text-editor.js:775:29

Commands
     -0:02.3.0 grammar-selector:show (atom-text-editor.editor.is-focused)
     -0:01.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:00.5.0 editor:newline (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "followSymlinks": false,
    "autoHideMenuBar": true,
    "disabledPackages": [
      "archive-view",
      "autocomplete-css",
      "autocomplete-html",
      "autocomplete-snippets",
      "background-tips",
      "bookmarks",
      "image-view",
      "language-clojure",
      "language-csharp",
      "language-go",
      "language-java",
      "language-javascript",
      "language-mustache",
      "language-objective-c",
      "language-perl",
      "language-php",
      "language-python",
      "language-ruby",
      "language-ruby-on-rails",
      "language-sql",
      "language-xml",
      "metrics",
      "open-on-github",
      "welcome",
      "exception-reporting",
      "vim-mode",
      "julia-client",
      "ink",
      "indent-detective"
    ]
  },
  "editor": {
    "invisibles": {},
    "fontFamily": "Office Code Pro",
    "fontSize": 12,
    "preferredLineLength": 92,
    "scrollPastEnd": true,
    "showIndentGuide": true,
    "showInvisibles": true,
    "tabLength": 4
  }
}

Installed Packages
# User
language-julia, v0.4.1

# Dev
No dev packages

Hmm. I'll take another look at it soon.

Thanks @Libbum.

Sorry, I should have tested more carefully before merging.
I think this is a real issue. The original regex was a valid regex whereas the new one is not
That isn't to say the original pattern is actually what we want, but at least it is not a "malformed expression"

Alright. So let's chock this up to being my first ever pull request and it ultimately being a failure.
So in that case, the question is: was #46 an actual problem with the expression, or with the parser on regexpal.com? Judging by the regex101 tests @spencerlyon2 just did it seems like the latter. For now, I suggest we revert this commit; as the original issue stated the regex wasn't in error, just that it seemed to parse incorrectly.

@Libbum no problem, it was a failure on my end for not testing before merging. Thanks for contributing!
My hunch is that maybe we pasted in the raw regex (as it appears in language-julia.cson) into the parser and it had a hard time with all the \\ double escape characters.
I also agree that we can simply revert back to the original version, I'll do this now.

Done in d8697c10107a8ecdf02c254984ba54627279d208

Thanks, working fine now.


Fix getEmptyMessage to close #2

please take a look

will merge though I don't understand what was fixed by this change.

Oh, understood, sorry for my overlook, this fix #2. thanks.

released v0.5.1.


Update Table-Nest-Codes.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

APEXTest/CATSTesting/Table-Cases/Table-Nest-Codes.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Use prop-types and create-react-class packages instead of using from React

React.PropTypes and React.createClass are deprecated as of React 15.5
Addresses #102

Closing in favour of #105


FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual

Fineract-428
Parallelizing and paging of periodic accrual

@vorburger yes, I'm interested in becoming an Apache Committer. Besides this has no conflicts at the moment and I'd kindly request @avikganguly01 to review these changes

@vorburger @avikganguly01 Reopened a new PR #513 based on the feedback given. Closing this one.


feature request: multi-selection

Would be good to have multi selection, this is one of the features that even the chakra select component have missing
Use the tag component would be a good option
reference: https://material-ui.com/components/autocomplete/#multiple-values

Definitely would be nice to have this feature!

Hi @gepd I'm about to work on this. I would love to have your input on the structure that would be best for this. Such that you have the flexibility of rendering the input and the internal tags. I just need a sample of the way you think would be best as an end user. E.g.
<AutoCompleteMultiInput>
     {({tags})=>(
            <AutoCOmpleteTag/>
       )
     }
<AutoCompleteMultiInput/>

Hi @anubra266, I like the flexibility of this component, would be great to have something as your example. I imagine that tags will export the label and value, and maybe a callback to remove the tag or maybe that you will handle internally (?).
Will you allow to use the tag with custom elements like in the chakra example? https://chakra-ui.com/docs/data-display/tag#with-custom-element

@gepd, I'll leave rendering tags to the end user so it's possible to use any component, Tags or something else, but the tags, will expose all required variables and methods.

Coming up in the next release


Use Dagger for Terraform CI workflow

Currently we're using task with the pre-commit project.
The most straightforward option would be to run the pre-commit into a Dagger module.

It is done, except for the terraform docs which updates files and these files should be exported to the local code.


Move metric creation to controller

We currently have helper funcs to get a metrics struct inside cmd. This
poses a problem when trying to write tests for the controller, as the
tests will run into a NPE when the controller has no metrics struct but
it is not possible to use the existing helper func as that would result
in a cyclic dependency.
This commit also removes github.com/go-kit/kit/metrics as we have no
plans to implement a metric provider other than Prometheus.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
The issues with the current approach noted in the commit message arose when trying to write tests for #243. IMHO if an unused flexibility (We can pass pass in arbitrary metrics provider and metrics configuration) comes with the price of making it harder to write tests it is something we should drop.
If we ever really need some more flexibility, we can extend NewMachineControllerMetrics()

For the tests now you simply instantiate those metrics and don't care about them?

For the tests now you simply instantiate those metrics and don't care about them?

Yep, exactly

@metalmatze @mrIncompetent I missed the metrics registration :S PTAL


zram doesn't start properly after power fail

boot after power fail results in misconfiguration,
zram-config starts, but doesn't create zdevices, it considers them as already working.
Manual Stop and Start zram service restore functionality.
It will be good to do this automatically, somehow recognizing misconfiguration after power failure
====
pi@raspberrypi:~ $ sudo systemctl status zram-config.service
● zram-config.service - zram-config
Loaded: loaded (/etc/systemd/system/zram-config.service; enabled; vendor preset: enabled)
Active: active (exited) since Fri 2020-05-08 08:30:09 EEST; 11min ago
Process: 322 ExecStart=/usr/local/bin/zram-config start (code=exited, status=0/SUCCESS)
Main PID: 322 (code=exited, status=0/SUCCESS)
May 08 08:30:09 raspberrypi systemd[1]: Starting zram-config...
May 08 08:30:09 raspberrypi zram-config[322]: entry swap                /zram0                zram-config0 already exists as zram.
May 08 08:30:09 raspberrypi zram-config[322]: entry log                /zram1                /var/log                /log.bind already exists as zram.
May 08 08:30:09 raspberrypi systemd[1]: Started zram-config.
====
pi@raspberrypi:~ $ lsblk
NAME        MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
mmcblk0     179:0    0 29.7G  0 disk
├─mmcblk0p1 179:1    0  256M  0 part /boot
└─mmcblk0p2 179:2    0 29.5G  0 part /
====
pi@raspberrypi:~ $ tail  /usr/local/share/zram-config/log/zram-config.log
zram-config start 2020-05-08-08:30:09
ztab create swap lz4 250M 750M 75 0 20
ztab create log lz4 50M 150M /var/log /log.bind /opt/zram/oldlog

I guess its https://github.com/StuartIanNaylor/zram-config/commit/0f145d200b08e218e281ef136458b77d23d4b6bd
Which its horrible with my memory to come back to code after such a time as I am desparately trying to remember why that was added.
Looking now I am wondering why that was added and seems a simpler option should of been implemented.
Let me have a think and see if memory or grey matter kicks in.

You need to delete the device file on startup such as here
https://github.com/mstormi/openhabian-zram/blob/master/zram-config.service
I agree a simpler option is favorable. While I did some changes in my own repo (see link), I haven't found a simpler (and reliable) way yet.

I think we will go back to scratch as in without keep this as a branch that any can choose, but Master will prob revert.
That way we can have a look at the service restarts and may just fix why and what is happening there.

Going to call the current openhab if that is OK @mstormi

Revert if you think it does harm but no need to rename yours, mine (above) is what I use from within openhab.
BTW the service does not properly on shutdown/reboot either, so I've also added https://github.com/mstormi/openhabian-zram/blob/master/zram-sync.service

@mstormi I think we will just revert back as it seems its your additions that seem to of added to this and another service for a service for me is adding unnecessary code as maybe the initial pull request was.
It needs a tidy and simplification not further addition and you have your own repo now, so I guess no problem if we delete those additions.
Thanks

Don't mix two issues. That other service I mentioned is unrelated to this one here. That other one was meant to fix #41 (but it didn't work out anyway for me so I removed it, too).
To fix this one, just add a line to zram-config to remove the device file on boot, see https://github.com/mstormi/openhabian-zram/blob/master/zram-config.service
Remember there was a reason for my additions so you would be losing those fixes if you revert.
Also, while I have my own repo for openhab, that's just to have access if in need to change anything fast.
I'm really not keen on maintaining another branch.


0.0.0 version

Climb suggests an odd 0.0.0 verison number:
$ climb

smarty/smarty     3.1.27     →     0.0.0

Thanks for reporting! Probably is something with the version_compare method.

Probably related to the initial value in this call. I admittedly didn't check to see how it would respond to that; it just seemed like the most reasonable value to use.

Yeah, probably that is also why it sometimes return this as well:
5.1.17     →     5.1.9

@vinkla No, that's a different problem.
php -r 'var_dump(version_compare("5.1.17", "5.1.9", ">"));' => bool(true)

Aah okay, maybe we should just remove anything but numbers and compare the values against each other then? Testing this and version_compare might do the job?

Perhaps. Maybe make this line of CheckCommand->normalize() more strict in what it returns, like so?
$version = preg_replace('/[^0-9.]/', '', $version);

Looks like related filtering is being done in CheckCommand->getLatest().
Seems like version normalization overall needs to be done in a more organized fashion within this class, maybe using Composer\Package\Version\VersionParser->normalize().

My last PR will fix the version compare issue.

Merged


edge fixes

Fixes to some logic for the edge embedding - nn.Embedding needs a [batchsize x features] tensor but is getting supplied a [batchsize x n_nodes x n_nodes] tensor.

oh, but I think it can take any shape https://pytorch.org/docs/stable/generated/torch.nn.Embedding.html


Iterating over constant strings in yara conditions block

Hello,
I recently had a use-case where I wanted to have a list of strings in the conditions block in a yara rule. I'm using yara v4.0.5. A minimal example is: comparing the SHA1 of a file with a known set of hashes. This is a working yara rule:
test.yar:
import "hash"

rule test {
    condition:
        hash.sha1(0,filesize) == "0a9fbc6dacd8887bd9d9065bc7d9a4905d7ea687" or
        hash.sha1(0,filesize) == "90cf88f9f3326d2616232d73e5adc1e85d28097f"
}

$ yara test.yar test.txt
test test.txt

For readability, this is alright when there are, say, 5 hashes. But if there are 100 hashes, then the rule file becomes messy. Is there a way in yara to have non-search strings in one variable? And I'm not referring to the strings block because those strings are searched in the file. I'm referring to a string variable (containing a list of strings) which is not searched in the file and can purely be used in the conditions block. Also, I assume hash.sha1 will be computed only once? (caching: https://github.com/VirusTotal/yara/issues/592)
Something like:
import "hash"

rule test {
    condition:
        for any i in ("90cf88f9f3326d2616232d73e5adc1e85d28097f","0a9fbc6dacd8887bd9d9065bc7d9a4905d7ea687"):
            ( i == hash.sha1(0,filesize) )
}

The above doesn't work:
$ yara test.yar test.txt
test.yar(5): error in rule "test": wrong type for enumeration item

Thanks for the help!

I think it makes sense that iterators work on lists of strings too. It's more intuitive than a long sequence of or statements.

I've taken a shot at this and am having a hard time getting it to work correctly in the grammar. It seems there is a conflict with the way integer sets are built.
Also there is https://github.com/VirusTotal/yara/pull/1338, which might make this issue obsolete. As such, I'm going to put this on hold until I can come up with a way to make it work or someone with more knowledge than me can do it.

After being shown the path by @plusvic I've got this implemented and up for review now.
Thanks, again, Victor!


Closing working file with middle-click also pastes clipboard

I noticed a small bug that when I close a file in the side bar with middle-click it will paste my clipboard into the editor context as well.

Sounds like the same issue as #7216 or #6184.  Does the problem go away if you choose Debug > Reload Without Extensions?  If you click in a blank area of the UI (e.g. a blank part of the status bar at bottom), does it also paste?  Does that occur in other apps too, or in your browser -- or is this only in Brackets?
Also, what OS are you on?

Strange, I wasn't noticing '$' anywhere, it was just dumping my clipboard. Could be related though.
This was on Ubuntu 14.04 at work. I just tried it at home on Windows 8 and can't reproduce. I can try the reload tomorrow morning and see if that fixes it.

I tried the Reload Without Extensions as well as restarting the entire client, I can still reproduce consistently.

@ianlamb What about this question?

If you click in a blank area of the UI (e.g. a blank part of the status bar at bottom), does it also paste?

Also, if you go to http://codemirror.net/mode/javascript/ and middle-click outside of the editor area, do you get the same behavior?

Clicking a blank area, such as an empty spot on in the file explorer menu, it will paste if the cursor is currently focused in the text editor. If I left click to shift the focus and then middle-click it does nothing. However, no matter where the focus is closing a file always pastes at the cursor's last position.
This behaviour is not seen on the website you linked or any of my other text editors.

I reproduce the same problem (OS: Linux Mint 17 Cinamon)

And on this page http://codemirror.net/mode/javascript/ I also have the problem in fact

I have the same problem on Arch Linux with cinnamon. And I can't reproduce this on other text editor.

Can someone on Linix check if inserting e.preventDefault() here or here helps?

It doesn't seem to make a difference for me

@DrPandemic What about either of these tests? http://jsfiddle.net/7mhec30m/

In both cases, it doesn't paste what I have in my clipboard


SS 4 Support

This also includes the outstanding PRs for SS 3 and resolves an issue with validation messages not appearing. @nedmas or @mrsteveheyes, any chance of this making it through please? I'm more than happy to answer any questions you might have on what's changed :)

Would there happen to be any update on this one? I'm not rushed to have this merged, but I just wanted to make sure this was on your radar, and that you were planning on continuing support for this module. Thanks!

@nedmas and @mrsteveheyes, just wanted to check in one more time. Any chance of hitting merge on this, or possibly transferring ownership if this is something you no longer wish to support?

For anyone that stumbles across this, I'm moving this fork over to https://github.com/symbiote-library/silverstripe-spamprotection-honeypot due to inactivity here. Please use this if you're looking for an SS 4 compatible version.


[Windows] Make Flutter development without Developer Mode

Use case
I want to start flutter development on Windows without enabling "Developer Mode".
This is a security risk and companies IT will not support or allow this.
Proposal
Make it possible to run flutter without enabling Developer mode.

To the best of our knowledge, this requirement was added in error. We're reverting it now. https://github.com/flutter/website/pull/7185


Updated tutorials to use Typings 1.0.

@bowdenk7 @sandersn

:+1:

:+1: (based on my limited understanding of the Typings 1.0 changes)


Uncaught ReferenceError: pie is not defined

https://github.com/benkeen/d3pie/blob/24b488a4f44226c407186c007365ab775f92a426/d3pie/d3pie.js#L1512
throws error
Uncaught ReferenceError: pie is not defined
at Object.maybeCloseOpenSegment (d3pie.js:1512)
at Object.openSegment (d3pie.js:1490)
at SVGGElement. (d3pie.js:1405)
at SVGGElement. (d3.min.js:2)

it still give error. PS: I use unminified version.
d3.v4.min.js:2 Uncaught Error     at d3.v4.min.js:2     at Et.ease (d3.v4.min.js:2)     at Object.openSegment (d3pie.min.js:1496)     at SVGGElement.<anonymous> (d3pie.min.js:1408)     at SVGGElement.<anonymous> (d3.v4.min.js:2)
which points to this line
.ease(segments.effectMap[pie.options.effects.pullOutSegmentOnClick.effect])

it works better if you change pie with 'a'
maybeCloseOpenSegment: function () {
d3.selectAll("." + a.cssPrefix + "expanded").size() > 0 && k.closeSegment(a, d3.select("." + a.cssPrefix + "expanded").node())
},
NB: it seems to me that examples works fine because the target DOM element is also name 'pie'


cargo rm foo on error should suggest --dev or --build, if appropriate

Problem
I just ran
$ cargo rm dunce
    Removing dunce from dependencies
error: the dependency `dunce` could not be found in `dependencies`.

Proposed Solution
It'd be nice if the error had a note saying that a --dev dependency existed
Notes
No response

If you accidentally run cargo rm dunce twice, it shouldn't act as if you did cargo rm --dev dunce.
While "if the tool knew what I intended, it should just do it" is a great principle, I feel like over doing it could lead to some very wrong behavior.

@rustbot claim

I am working on it.


[Github] Add pull request template

Do you prefer having a pr template?

I think it's a good idea, I'd like to maybe flesh it out a bit more similar to how the App's PR Template works
https://github.com/cds-snc/covid-alert-app/blob/master/.github/pull_request_template.md
I'm a fan of the reviewer checklist, while I don't think we'll get as many unsolicited PR's as the app it would be nice to have a reminder of what needs to be done
Something like the following would probably work:

[ ] Is the code maintainable?
[ ] Have you tested it?
[ ] Are there automated tests?
[ ] Does this cause automated test coverage to drop?
[ ] Does this break existing functionality?
[ ] Should this be split into smaller PRs to decrease change risk?
[ ] Does this change the privacy policy?
[ ] Does this introduce any security concerns?
[ ] Does this significantly alter performance?
[ ] What is the risk level of using added dependencies?
[ ] Should any documentation be updated as a result of this? (i.e. README setup, etc.)

Good call, I'll incorporate the app template into server.


Store browser console log when there's test failure

To improve reports of possible bugs, lets find a way to store a console log from browser. Also network chatter could be interesting too.

There's a protractor plugin that looks promising https://github.com/angular/protractor-console-plugin.


Unable to capture Video with front and back both camera

Hello,
Thank you for this amazing library. I want to capture one video with front camera and back camera both but I am unable to do this.  I had commented this line         v.flipButton.isEnabled = !state.isRecording in this function         private func updateUIWith(state: ViewState) { and I started recording and trying to changing camera back to front but whenever I change to camera Its stop recording, I want to do that while Recording If I change camera back to front or front to back then It will record one video with both camera.
Is there any way to do this?
Please anyone Help me with this?
Thanks!

I also want this feature. have you find any solution?

@YogendraPatel  I had integrated SCRecorder's camera in to this library to solve my problem, Here is link for SCRecorder https://github.com/rFlex/SCRecorder

There is 2022 year outside🎉 Old outdated issues are closing. Please search if there are already existing issues with the same problem before opening new ☮


Thanks for making such a good module. I have a question.

I am using upperf and scene together.
As an example, I'll explain when I'm currently operating in Balance Mode.
If enter the cpu control menu in the Scene, there is a menu where can specify the maximum clock for each cpu cluster, but if change the clock, it rolls back to the previous clock. Is it not possible to change the max clock per cpu cluster? For example, in balanced mode or performance, I want to limit the max clock at 2.0ghz.

PU frequency range can be specified in uperf v1 and v2. In uperf v3, CPU power is the

thank you for the answer :)


improved readability

info on versioning:

declare the validity of this tutorial for Spark 1.5 in "document description"
remove not relevant info comment about DataFrames started in Spark 1.3

put some basic comments into code

Thanks for the improvement! Looks good to me.


IS-707: Make CI fail on warnings

IS-707
To be in compliance with CII certification standards, we must address all warnings from the compiler. To ensure this, we are rejecting any build warnings in our continuous integration.
Documentation of this change can be added once #706 (or similar) is merged. Refer to IS-739 for this change.

As a sidenote, I approved this change with Nathan George, so let's please involve him on any discussion on whether or not this should be our strategy to comply with CII standards.

Alright, I made the changes you asked for. Anything else?

@vimmerru @Artemkaaas @KitHat please remove warnings in current master and merge this PR


Authorization Error from Amazon Cloud

I'm getting an Authorization Error when pushing with git lfs
Here's a log snippet:
Authorization error: https://github-cloud.s3.amazonaws.com/alambic/media/117879268/62/74/6274a215e085bef1de34ded338fa151c92a2791ff063bf85b74bc3e566cbc99c?actor_id=12548121
Check that you have proper access to the repository
I'm not sure how to ensure I have proper access. It's my repository and git pushes before git lfs worked fine.
I have paid for additional room from GitHub (50GB), so I'm not out of room.
Thoughts?

Nevermind on this ... I flattened my PSDs, so they fit under 100MB.  Deleted LFS

It's likely that you had a problem authenticating with Git LFS. I'd ask for git lfs env and maybe git config -l to see your current environment.


openssl: run make install with -j$NIX_BUILD_CORES

Description of changes
The kernel building derivation does the same thing.
Maybe it's time for setup.sh to learn enableParallelInstall=true?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] powerpc64le-linux
[ ] aarch64-linux

[x] Fits CONTRIBUTING.md.

Dammit.


Unable to run app on android (npx react-native run-android)

Description:
I have followed the instructions on https://reactnative.dev/docs/getting-started to setup my React Native CLI app. Everything have been installed and setup as documented (a fresh application) but when I run the command "npx react-native run-android", then I get the error regarding gradle.
React Native info:
C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN>npx react-native info
info Fetching system and libraries information...
System:
OS: Windows 10 10.0.17134
CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
Memory: 26.42 GB / 31.84 GB
Binaries:
Node: 10.16.3 - C:\Program Files\nodejs\node.EXE
npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
SDKs:
Android SDK:
API Levels: 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29
Build Tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.3, 24.0.3, 25.0.3, 26.0.3, 27.0.3, 28.0.3, 29.0.2, 29.0.3
System Images: android-28 | Intel x86 Atom, android-28 | Intel x86 Atom_64, android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>56338
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
React Native version:
C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN>npx react-native --version
3.2.1
C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN>npm -v
6.9.0
C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN>gradle -v

Gradle 6.2.2
Build time:   2020-03-04 08:49:31 UTC
Revision:     7d0bf6dcb46c143bcc3b7a0fa40a8e5ca28e5856
Kotlin:       1.3.61
Groovy:       2.5.8
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          1.8.0_221 (Oracle Corporation 25.221-b27)
OS:           Windows 10 10.0 amd64
Error:
C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN>npx react-native run-android
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
Jetifier found 864 file(s) to forward-jetify. Using 12 workers...
info Starting JS server...
info Installing the app...
'gradlew.bat' is not recognized as an internal or external command,
operable program or batch file.
error Failed to install the app. Make sure you have the Android development environment set up: https://facebook.github.io/react-native/docs/getting-started.html#android-development-environment. Run CLI with --verbose flag for more details.
Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081
'gradlew.bat' is not recognized as an internal or external command,
operable program or batch file.
at checkExecSyncError (child_process.js:629:11)
at execFileSync (child_process.js:647:13)
at runOnAllDevices (C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\runOnAllDevices.js:94:39)
at buildAndRun (C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\index.js:179:41)
at then.result (C:\Users\muks\Documents\Shabdkoshish\dev\FunKhelHN\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\index.js:133:12)
at process._tickCallback (internal/process/next_tick.js:68:7)

Expected Results
App must run in the attached android phone (My device is listed in adb devices also).

You can try running react-native run-android or npm run react-native run-android
Maybe docs needs to be updated

You can try running react-native run-android or npm run react-native run-android
Maybe docs needs to be updated

@chakrihacker Thanks for your comment.
I have tried both the commands but the error is still the same.

Did you get the app to build and run in the emulator? I.e. is this a problem with the device installation or a problem with the app build not running in general.

I also experienced that problem. I then used version of openJDK is 13.0.1. I could run I fixed the openJDK version to 12.0.2.


reflecting to have same type as in GodotSteam

Some functions not have same type as it should be in c++ side.
And chaning ulong in one place and changing it to long was confusing

No worries I didn't do it all of it since some might need change inside GodotSteam too since GameServer code is missing and other neat functions. (Like you cannot get the lobbyID when sending a LobbyUpdate, seems like GodotSteam forgot about that)