Automated cherry pick of #2408: fix: avoid sku validate delete return error

Cherry pick of #2408 on release/2.11.
#2408: fix: avoid sku validate delete return error

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@c49ff16). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.11   #2410   +/-   ##
==============================================
  Coverage                ?   7.08%
==============================================
  Files                   ?     454
  Lines                   ?   71628
  Branches                ?       0
==============================================
  Hits                    ?    5073
  Misses                  ?   66137
  Partials                ?     418

Flag
Coverage Δ

#aFlag
7.08% <ø> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49ff16...feff056. Read the comment docs.

/lgtm

/approve


Fixes strpos for php 7.3

Ticket: #1899
Issue
Problem with php 7.3 and strpos - described in ticket.
Solution
As stated in PHP docs:
If needle is not a string, it is converted to an integer and applied as the ordinal value of a character. This behavior is deprecated as of PHP 7.3.0, and relying on it is highly discouraged. Depending on the intended behavior, the needle should either be explicitly cast to string, or an explicit call to chr() should be performed.

so I added the chr function.
Impact

None.
Usage Changes
None
Considerations
Testing

Adding chr() does not seem right at all. Please see my comment in https://github.com/timber/timber/issues/1899#issuecomment-461635642

Just leaving this here to test later:
protected static function is_in_theme_dir( $path ) {
    $root = realpath(get_stylesheet_directory());

    if ( false === $root ) {
        return false;
    }

    if ( 0 === strpos($path, (string)$root) ) {
        return true;
    } else {
        return false;
    }
}

@jarednova I'm looking at the Travis test results and don't quite understand all the errors. I think that the problem is mostly caused by WP 4.7.9 + PHP 7.3 not the fix itself.
Do you have any idea how to fix those bugs?

@palmiak according to this post on WordPress and PHP 7.3, they aimed for full 7.3 support in the next release, which at that time would have been 5.0.
Because 4.7.x gets us to +80% in WP version support I'd like to take an honest whack at this one and see what happens if we go up to 4.7.12 for the 4.7 version we test against. Let's see what that does ....

@jarednova 4.7.12 didn't changed anything 😞 We can assume that 4.7.* won't be compatible with 7.3.
Can we remove just the tests for 4.7 + php 7.3 because they'll always give us error.

Yeah, it appears the WordPress gods have not smiled upon us. I'd like to still test against a "lower" WP version so I just upped that to 4.8.x to see if that makes Travis happy

Ended up going back down to WP 4.7.12 but excluding PHP 7.3 for that combo. All tests are good now!


use MediaServiceInterface

1. Why is this change necessary?
Using Interfaces is much better to give it a change to be decorated :-)
2. What does this change do, exactly?
Expecting MediaServiceInterface instead of MediaService
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-25057
Please use this issue to track the state of your pull request.

Hi @tinect, thank you again very much for your contribution! 💙


The Great Mixin Bazaar. [The API-8 Mixin Nuking]

This actually finds the targets for some missing villager trade mixins within the api, renames some trade related stuff and invalidates that odd DataFixer mixin.
Some of those invalid mixins are actually valid atleast.

Replaced by #2446


Installation fails (tried python 3.9 / 3.10)

Hello,
The installation of the plugin fails on MacOS using python3.9 or 3.10.
The log indicates that :

configuration error: project must contain ['name'] properties
DESCRIPTION:
Data structure for the project table inside pyproject.toml (as
initially defined in :pep:621)
...
ValueError: invalid pyproject.toml config: project

Have you already faced this kind of issue ?
Please let me know if you need further logs.
Regards,
Djow

Can you install the project again please?

I got the same issue and can confirm that with your recent change it works on my Mac (Apple MBP M1):
repos:
  - repo: https://github.com/ejba/pre-commit-maven
    rev: a7a66bd55c3d7b5c3083b7926753d0d48d17a498
    hooks:
      - id: maven
        args: ['-f automations/marketing/pom.xml spotless:apply']

I'm using Python 3.9.10

I will make a release with these changes. Thank you!

Done (v0.3.3)

Hello @ejba, that is indeed fixed ! Thank you for your support


Coding Standards

i have Gone through the code base of the controller and it can be re structured
public function store()
    {
        Auth::user()->account->users()->create(
            Request::validate([
                'first_name' => ['required', 'max:50'],
                'last_name' => ['required', 'max:50'],
                'email' => ['required', 'max:50', 'email', Rule::unique('users')],
                'password' => ['nullable'],
                'owner' => ['required', 'boolean'],
            ])
        );
        return Redirect::route('users')->with('success', 'User created.');
    }

So you dont need the Validation loging while creating the data you can just add the form request and isolate the validation login
I have also found many code restructre like this
I am opening the issue because pingcrm is slowly getting populared  so it will be used in some of the entrprise companies
So app should be neat and  clean and must easy to maintain
So If You are intrested in Restructing the code kidly tell me i will create the PR for that
OR close the issue

Greetings @ManojKiranA! Thanks for your interest in Inertia.js and PingCRM.
While you absolutely could form request objects where I am currently doing validation inline, I actually prefer to not use them. I like having the validation directly in the controller. I also like that each post/put/patch endpoint doesn't require a corresponding form request file.
Thanks either way!


[Table] sticky columns doesn't work as intended when inside mat-sidenav-content

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Sticky columns shall be "over" normal columns (aka have a greater z-index)
What is the current behavior?
When the mat-table is inside a sidenav, sticky columns get z-index: 1, which is the same z-index provided of the mat-sidenav-content element.
Graphically the columns are show in front of the non-sticky ones, but when I try to inspect the element I can see that the non-sticky are logically placed at the top, capturing mouse interaction (click, mousedown etc).
What are the steps to reproduce?
See previous point,
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 6.0.6
Material 6.3.1
Is there anything else we should know?
I saw that there is some kind of "z-index" detection on sticky columns management before deciding what is the best value, this issue should probably by addressed there

I found solution, just update to:
"@angular/cdk": "6.4.7"
"@angular/material": "6.4.7"

It seems I cannot reproduce the faulty behaviour anymore, so I guess it has been addressed at some point.
Gonna close the issue


mssql-cli broken on latest Windows update--'The system cannot find the file specified.'

I just connected to a server successful with some specific port:
mssql-cli -S server_name,port -U user -P password
But when I try to launch some query, I get the next message:
XXX> select 4+4;
Time: 0.451s
The system cannot find the file specified.

mssql-cli version: 0.18.1

I have the same issue on new servers.
master> select name from sys.databases Time: 0.555s The system cannot find the file specified.
I am using pip install command to install the utility. Tried to install 0.18.0 on the same machine. It uninstalled 0.18.1 first and installed the supplied version. But that doesn't seem to help.

I have the same issue. whatever I do I get "The system cannot find the file specified."

@G0erman, @altafub, and @jvillegas74: what machine is everyone on? How was mssql-cli installed?

This is Windows 10

This is Windows 10 (x64). Running on a Surface Pro 4. Aso the same on a Dell XPS 15

Thanks. What version of Python are you using? And do you experience the same issue on 0.18.0?
You may install a prior version by calling python -m pip install mssql-cli==0.18.0.

just tried with 0.18.0 and the same as the latest 0.18.1
Using Phyton 3.8.2

Can you call mssql-cli --version and let me know what you get? Thanks @jvillegas74, I want to rule out that your machine isn't still installing an older version, which has happened before.

I have tried with 0.18.1 (latest) and 0.18.0 as well as 0.17.0 . All of them same output
Anyway here is the output
Installing collected packages: mssql-cli
Attempting uninstall: mssql-cli
Found existing installation: mssql-cli 0.17.0
Uninstalling mssql-cli-0.17.0:
Successfully uninstalled mssql-cli-0.17.0
Successfully installed mssql-cli-0.18.0
C:\WINDOWS\system32>mssql-cli --version
Version: 0.18.0

@ellbosch Any workaround you might recommend ?

Unfortunately I'm still unable to repro this issue. However—it would help a lot if you could post your log file here (and a clean set of logs too would be great!).
The logfile is located at %LOCALAPPDATA%\dbcli\mssqlcli\mssqlcli.

mssqlcli.log
Here is a clean log

Thanks @jvillegas74. Some more questions:

Did mssql-cli used to work for you or has it always been like this?
Are you using a standard command line or the Linux Subsystem?
Is there any other error message in the stack trace that could help for debugging?

@ellbosch I have installed for first time.
I am using standard command line CMD (as regular user and as Administrator)

Thanks. Can you please return the output for which mssql-cli? Perhaps there's a path issue...

Probably

not a Pyton expert

Probably

not a Pyton expert

Sorry I meant where mssql-cli. My apologies!!

here

Thanks @jvillegas74. This doesn't look like a path issue.
Are you able to query this database with another tool? I want to ensure this error message is exclusive to mssql-cli and not an issue with your SQL Server instance.
If you don't have another tool installed, I'd recommend Azure Data Studio.

yes. I can connect to my localhost running SQL 2019 using SQLCMD, ADS and SSMS with no problem

Hmmm... are you possibly using Windows Auth instead of SQL @jvillegas74?

same thing using SQL Auth

No problems with SQLCMD

I wish I could repro this :( I'm so sorry this is happening, thanks for all of your help @jvillegas74.
Let me know if you're unblocked by using a really old version, say 0.15.0. If that still doesn't work then there's a good chance we've had this bug since the beginning. I'll keep digging in the meantime.

Is not the day today ! . this is after installing 0.15.0

This info still helps in any case! Good to know this bug exists, thanks @jvillegas74.

We use Windows 2016 ami provided by AWS. And 0.18.1 doesn't work with ami released after 11th Feb.
So this has to be a windows update thing.

We use Windows 2016 ami provided by AWS. And 0.18.1 doesn't work with ami released after 11th Feb.
So this has to be a windows update thing. @ellbosch

Interesting... @altafub are you also using a localhost db like @jvillegas74?

Confirmed this is caused by latest Windows update—I'm now able to repro this.

I can add that I just installed on a new Win 2016 Server (Azure VM) and got the same error connecting to localhost and remote server

Please share here or by email when the fix is available. looking forward to talk and demo about mssql-cli in my next presentation

@ellbosch Please share here or by email when the fix is available. looking forward to talk and demo about mssql-cli in my next presentation

Will do @jvillegas74, fixing this bug is our top priority.

Looks like one of our dependencies is the culprit. I'll update the thread when new official bits are out.

The fix is out! @jvillegas74 @altafub thanks so much for your help :)

@ellbosch thanks a ton for the prompt response and fixing this. I can confirm this is working now.

Thanks @ellbosch for the quick response !! is working great now

thanks @ellbosch for the quick response. it works great !!
which will be the right way to update ?
Alse the installation guide link  from the doc is broken
https://docs.microsoft.com/en-us/sql/tools/mssql-cli?view=sql-server-ver15

@jvillegas74 you may view installation docs here: https://github.com/dbcli/mssql-cli/tree/master/doc/installation
Thanks for letting us know about the docs!

The Microsoft Docs page is now fixed.


service endpoint retrieve username and password

I am building an azure-pipelines-extension I have a custom endpoint with basic authentication. I need to pass this endpoint credentials to my datasources.
this is my vss-manifest.json
     "dataSources": [
       {
        "name": "AccessToken",
        "endpointUrl": "$(endpoint.url)",
        "requestVerb": "Post",
        "requestContent": "username={{{endpoint.username}}}&password={{{endpoint.password}}}&grant_type=password",
        "resultSelector": "jsonpath:$.access_token",
        "headers": [
          {
            "name": "Content-Type",
            "value": "application/x-www-form-urlencoded"
          }
        ]
      }

However it doesnt seem like username is getting passed . When i replace the line "requestContent" with
       "requestContent": "username=my_username&password=my_password&grant_type=password",

It works.
What am i missing here ?

Hello, @pathakrohit08 , please take a look at this answer on developer community: https://developercommunity.visualstudio.com/t/Is-there-a-way-to-use-custom-endpoint-pa/61533?space=21&entry=problem&q=custom+endpoint&viewtype=all
Most likely it may help you to resolve you problem.

@tatyana-kostromskaya  Thank you i was able to make it work.


Improved file Q_15.java

The program was only able to determine if a number was an Armstrong number when a 3-digit number was given as input. Updated it so that it can check numbers with any number of digits

Please review the Q_15.java file

Thank you for dedicating your time to enhance the codebase. Your efforts are greatly appreciated.

Thank you for reviewing the code and merging it.

Message ID:
@.***
com>

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>


High prio: Share your game page needs explicit instructions on how to 'win' a sprig

Suggestion:
GET A SPRIG CONSOLE!
Sprig consoles will be ready for shipping end of Sept 2022*. You can get on the waitlist now by sharing your game and having it approved by one of our project maintainers. Once approved, we'll collect your details for shipping.
If you have any questions, join #sprig on our Slack
There are only a few requirements to get a Sprig console:

you must be in high school or younger (this will be checked before mailing)
your game must use the Sprig editor
your game must be winnable
your game has a minimum of 5mins of gameplay
your game is original

We'd love to play your game even if you aren't submitting for a Sprig console! Follow the steps below.

subject to availability for shipping

love it. if we had hours and hours, i'd ask for the dino sprig logo but it's fantastic as is. TYYYY

https://github.com/hackclub/sprig-gallery/pull/14 <- done!

This issue seems to be a dupe (or closely related to) #261.


Is this documentation a joke ?

There is only a single feature, that does not even work. Authentication is a protected key.
I'm sorry, but the team is obviousely not taking seriously the project or even involved in it.
We just have to compare this sh*t to the golang sdk documentation to say so.
Even worst, commits are like "update sdk". Seriously ?

Jokes are for laughs, this documentation is a shame, it makes you want to change everything on the spot

In each new project you need to open at least ten tabs and spend 4 hours just to make something "simple" work

Glad someone said that cuz in 5 minutes of signing up i had just thought the same...
how is possible that the basic tutotirial they have dont work?
not to meniton what the hell was in the mind of the person who created this shit?
omg i've never seen such a messes up project since i left introduction to programming
zero design patterns completelly crazy mess

Such a waste of time!  Going back to Sendgrid.
"Better Than Brevo"!

Totally disappointed with this documentation!

Yeah, this was a waste if time today

Hello! Apologies to have a bad experience with our SDK. We have not been able to keep the documentation up to date but will try to keep it on a higher priority from now on. I have updated the documentation on Readme.md: https://github.com/getbrevo/brevo-node?tab=readme-ov-file#we-have-two-options
Please take a look and hope it helps.

I think it was still wrong. How API key could be setup should be as follows:
	const apiKey = apiInstance.setApiKey(
		brevo.TransactionalEmailsApiApiKeys.apiKey,
		"YOUR API KEY"
	);

Such a joke. This one of the worst docs I've seen.

Hello! Apologies to have a bad experience with our SDK. We have not been able to keep the documentation up to date but will try to keep it on a higher priority from now on. I have updated the documentation on Readme.md: https://github.com/getbrevo/brevo-node?tab=readme-ov-file#we-have-two-options
Please take a look and hope it helps.

It takes 5 minutes to update those TS errors. Why isn't anyone doing it? Any manager seeing this should realize that this is bad for the business when dozens of developers complain that there are errors in README examples.

We're still maintaining a version at @groupcards/brevo for anyone interested. See #19 for more details.
Also means you don't have to create new classes for every part of the api.
import BrevoApi from "@groupcards/brevo";

const brevo = new BrevoApi({
  headers: {
    "api-key": "YOUR_API_KEY",
  },
});

const account = await brevo.account.getAccount()

This doesn't seem to work either.
I'm getting a "BrevoApi is not a constructor" error.

We're still maintaining a version at @groupcards/brevo for anyone interested. See #19 for more details.
Also means you don't have to create new classes for every part of the api.
import BrevoApi from "@groupcards/brevo";

const brevo = new BrevoApi({
  headers: {
    "api-key": "YOUR_API_KEY",
  },
});

const account = await brevo.account.getAccount()

This doesn't seem to work either.
I'm getting a "BrevoApi is not a constructor" error.

We're still maintaining a version at @groupcards/brevo for anyone interested. See #19 for more details.
Also means you don't have to create new classes for every part of the api.
import BrevoApi from "@groupcards/brevo";

const brevo = new BrevoApi({
  headers: {
    "api-key": "YOUR_API_KEY",
  },
});

const account = await brevo.account.getAccount()

This doesn't seem to work either. I'm getting a "BrevoApi is not a constructor" error.

Ah, looks like there was an issue with the build that meant to had to add .default to the end of the import. Would you be able to try again with version 2.2.0 to see if that fixes the issue?

Yes it works after the update to the new version.
Thank you.

@alexbrazier I'm still getting "This expression is not constructable."

This is what I have:
import brevo from "@getbrevo/brevo";

    let brevoApi = new brevo.TransactionalEmailsApi();
    const apiKey = process.env.BREVO_API_KEY;
    if (!apiKey) throw new Error("Missing BREVO_API_KEY");
    brevoApi.setApiKey(brevo.TransactionalEmailsApiApiKeys.apiKey, apiKey);

And this is the error I get:
TypeError: Cannot read properties of undefined (reading 'TransactionalEmailsApi')

Is anyone else getting this error?

Hi @ishaangandhi
Can you please try to clean the npm cache and reinstall the dependencies?

npm cache clean --force
npm install

This is not reproducible every time, but it occurred with me just once and I followed this above steps to fix it.


kivy.factory.FactoryException: Unknown class

After I move everything from the firebaseLoginScreen folder to the folder where the main.kv and main.py are. Then I had another error named:  kivy.factory.FactoryException: Unknown class
I am not sure is it due to the version of kivy or not.  But when I searched the MDToolbar API at kivymd's documents, the API  does not exit. So I replaced it with  and everything goes fine now.
I post this issue just in case that anyone else may have this problem with me.
Please let me know if I am wrong, thank you

@Monica-Xiao Use MDTopAppBar unstead - https://kivymd.readthedocs.io/en/latest/components/toolbar/


Server must not 500 during any integration test

Either modify server or client such that any internal server error causes the test to fail

The server does not 500 during any integration test


Fixe empty popup

Reviewer @xavijam.
Close #737 and #739.
Solves bug that happens when zoom changes, showing popup really small making content never displayed.

Looks good man! :+1:


get_path_lengths

This was requested for calculating distances between river locations for species dispersal along river systems. Turns out that it's a pretty general utility that will be useful along with some of the demo code in #214 -- Will work up some additional utilities and maybe a vignette showing how to use this stuff.

Codecov Report

Merging #241 (39a517e) into master (dc2b856) will increase coverage by 0.03%.
The diff coverage is 92.47%.

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   94.42%   94.46%   +0.03%
==========================================
  Files          20       21       +1
  Lines        2314     2401      +87
==========================================
+ Hits         2185     2268      +83
- Misses        129      133       +4

Impacted Files
Coverage Δ

R/nhdplusTools.R
98.55% <ø> (ø)

R/get_path_lengths.R
91.25% <91.25%> (ø)

R/get_network.R
95.41% <100.00%> (+1.54%)
:arrow_up:

R/index_nhdplus.R
97.56% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2b856...39a517e. Read the comment docs.


Custom dialogs; prepare for 2.0.0

Addresses #128 and prepares for release of v2.0.0.

What is the interaction between AlertDialogType and DialogProvider? Do they operate separately from each other?

Aha I see "You may call either setAlertDialogType or setCustomDialogProvider, but not both."

If you have the time, it might be useful to either include an option in the example application to illustrate a custom dialog, or make a second example application.

This may not be a well-posed idea, but is there a way using types or something to make it impossible to call setAlertDialogType and setCustomDialogProvider both? Right now the you throw an exception after the fact, but I wonder if there's a way to enforce it upfront.


Bump version to 0.9.1 and Editors to 7.52.0-Final

@caponetto I created fix for the chrome tests, see #472


Inconsistency when clicking on a problem's name in contest view vs round view

When I open a contest and click on "Problems" then problem name it takes me to the pdf problem statement. When I click on the round name beforehand, however, it takes me to the problem's page (the page of a given problem in a given contest, not the general system-wide problem page).

The layout of the problems and rounds will be fundamentally changed soon, so it will no longer be an issue.

That future has come. It should be consistent now.


setup_postdata() and global $post

It seems like setup_postdata() does not work correctly if we does not use a global $post.
For instance:
The output will be correct when using this:
foreach ( (array) $featured_posts as $post ) :
	setup_postdata( $post );
	get_template_part( 'content', 'featured-post' );
endforeach;

wp_reset_postdata();

The output will be not correct when using this:
foreach ( (array) $featured_posts as $featured_post ) :
	setup_postdata( $featured_post );
	get_template_part( 'content', 'featured-post' );
endforeach;

wp_reset_postdata();

Example of using setup_postdata() with $post: https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyfourteen/featured-content.php#L23
When using $post, the displays the following error: "Overriding WordPress globals is prohibited. Found assignment to $post".
What would you recommend in this case to avoid the error? Are we allowed to use setup_postdata()?

The context matters in this case 🙂
In which file are you using the $post variable? If it's in one of the templates, then you can use it just fine. In other files (like functions.php), since they are in global namespace, you risk of tampering with the global $post variable, and potentially affecting other places where it's used in WordPress.
You may wonder why this doesn't work, but it's actually because of the get_template_part and setup_postdata functions.
What get_template_part function does is it loads the template - tries to find it in different places before using locate_template which then uses [load_template](https://developer.wordpress.org/reference/functions/load_template/) to load the template while providing some globals:
    global $posts, $post, $wp_did_header, $wp_query, $wp_rewrite, $wpdb, $wp_version, $wp, $id, $comment, $user_ID;

Also the important part to note is the setup_postdata() function, that will set up global post data, won't override the global $post variable. For that to happen you would have to assign it to the $post variable which would trigger the message you've seen.
So, long story short: we currently have some issues with providing the context to determine if the 'globals' are actually global. When using templates, this can be ignored. In other places it's a legitimate concern.
TRT reviewers are aware of this, and they know when to ignore these issues.

If it's in one of the templates, then you can use it just fine. In other files (like functions.php), since they are in global namespace, you risk of tampering with the global $post variable

Be careful what you say here. Template files (single.php, archive.php, index.php, etc.) are in the global namespace. Look in template_loader.php and see that it just uses include ( $template ); from a file that isn't inside of any function.
It's template-parts that are loaded from a function and so their variables are local to that template-part. (but that function defines the globals as stated, so you can't use those names)

I stand corrected 🙂


modify ace inference

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.皓童 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


If I disable shift-enter from sending to the interactive window, shift-enter sends Python code to inappropriate termninals.

From a marketplace review (From: Not Specified on 3/18/2022). Here's the relevant comment:
"So that's a matter of opinion and doesn't necessarily justify one staring something. After all, in theory, if I don't like it I just disable the code that pipes things into notebooks when I hit shift -enter, back to four of five stars.
If you do that, and you have a python terminal running, you'll send (possibly incomplete) code into a python terminal if it is running. If I type exit, though. It'll still send code, to the specific terminal it thinks is the python terminal. Powershell was not amused by print('hello world'). You can even start an ipython kernel and send code in using shift enter to see what a decent cli interface feels like... well, except the fact that it messes up indentation on multiple lines of code. So it both feels like it's covering up a buggy part of the python implementation and it suggests a world where I could just flip on an ipython terminal and use that."

Here's the scenario which user describes:

The thing is we cannot know if the Python interactive session in the terminal is exited or not, so we simply keep sending the selection and this is expected.

well, except the fact that it messes up indentation on multiple lines of code

Regarding the support for IPython, we do have https://github.com/microsoft/vscode-python/issues/8945 https://github.com/microsoft/vscode-python/issues/17172 opened where we plan to help with the indentation issues so users can launch their terminals using IPython instead and would not have this problem. Closing in favor of that.


docs: adjust api.md for the website

@Florence-Njeri @pratik2315 like I said during our meeting yesterday, I could not let it go and had to make sure api.md will work in the website 😄 it was more complex that I expected 😅 but I could not imagine going public with generator docs on website without it. I wanted to make sure you can celebrate having all current docs there.
What is this PR doing:

customizing handlebar templates used by jsdoc2md library:

custom-sig-name.hbs is new handlebar based on sig-name
override version of defaultvalue.hbs
override version of header.hbs
override version of link.hbs
override version of main.hbs
override version of params-table.hbs

customizing script call for docs generation to use above diagrams as override

It was basically needed as current generated doc was failing when added to website:

Mainly because escaped values like <. Now no escaping is done
Also way too many details were done initially as headings and made generated TOC on the right ugly and not really working. Now only functions are headers
Issue was with types that had or (|) as in website it was interpreted as table delimiter and breaking. Now parameters are not show as table but simple list
frontmatter with short intro is added

@Florence-Njeri you will need to update your PR with script. Now not only you need to remove README.md but also entire folder docs/jsdoc2md-handlebars
This is how it looks like in website 👇🏼

mid software developer

will it be a drop from senior or a promotion from regular
your message is to short to figure sarcasm 😅 😆

/rtm


make shadertoys copypasta as long as uniforms are setup in settings for each, switched to webgl2/300es

While this isn't the exact goal... and i wouldn't approve any part of this because its not really shiny/doc'd/commented but for anyone curious, this change to the shader header prefixes makes it so you can pretty much take any shadertoy that is NOT multi-pass/multi fbo, and run with it in fxGlue. pretty much as long as you can have the missing uniforms (itime,idate,imouse) edited out, or added as settings/uniforms in studio, it implements the same signatures and uses same version as shadertoy
I am not really trying to get this upstream exactly...
honestly im using this PR to try and ping @mat-sz and for my fork to maybe get some visibility to anyone who looks this way...
@mat-sz you've made an awesome base/starter for a multi-layered motion/generated graphic editor in instaglitch...  i've posted some clips on twitter of what i've been doing with your awesome instaglitch, fxGlue, studio... wanted to comment/shoot shit/collab maybe? use them duckets and hit mine up.

@digitallyserviced Hey, thank you for the pull request, but as discussed over Twitter DMs - this is out of scope for the project.
I've added functionality that allows you to add prefixes and suffixes to shader sources and also allows you to override the preprocessor entirely in v0.2.0. Hopefully this resolves the problem.
This also should allow you to create a custom package that depends on fxGlue and just extends it.


Box Controller Drag update handle

Issue
I was working on my app which is a music app. As demonstrated in the example It opens the collapsed view by drag but when closing from the open state it was giving issue. This was because I gave the open height the full screen.
I then followed the example and tried to give 90% of the screen width. This gave me the access of some area above. I noticed that when I set draggableIconVisible as false on my opened body(panel) the drag was getting updated but it had some offset. Like the area just above it was used to drag the item down which was I suppose the area for the icon. I tried multiple ways, but maybe I was not able to dive deep enough to find a way if you have provided to it.
I gave a read to your source code and found a possible solution to it. I saw that there was a _onGestureUpdate and _onGestureEnd method which could be used in my case. I just exposed them with the help of BoxController and i was able to achieve the drag from externally. In my panel at the top I gave a inivisble Container of full width and height 40 and with that I was able to do the drag operation
Your source code is very readable and very well made thanks to that I was able to get to the solution very quickly.
I don't know if there is a solution to this but these few lines helped me and might help others.

Send your code to check.

Sir code from my project?

Just modify the following code in the music_player_screen.dart
Line 82: double maxHeightBox = MediaQuery.of(context).size.height - appBarHeight;
to : double maxHeightBox = MediaQuery.of(context).size.height;
and
Line 145: body: _body(height: maxHeightBox),
to: body: _body(height: maxHeightBox - 30),

Thank you for the help!

you're welcome.  no other problem?  problem is solved?

The problem actually was that the sliding window was actually covering the whole screen(according to my design) so the top part was not able to get the gesture.... I tried what you instructed but the problem was that it would be a bad UX for the user to able to hold a small part according to my design I wanted the user to give some room so I tried that with the flow I explained and gave this PR for
The whole screen is filled with the sliding panel(open) and on top there is a minimize button (arrow_down icon) and the whole region I placed an invisible container and on that I used gesture detector and with boxController.onGestureUpdate I did get the feel I wanted.... I just thought that some would want like me to use bit more customized and have a bit more control over the drag update
So now my screen is somewhat like
https://github.com/shirvanie/flutter_sliding_box/assets/63448767/4faba8ff-c2a3-4f60-a049-7903e3653826

I did not understand what you did
Did you use the nest box?
Write an example code for me to check

Ya my issue was resolved no worries. I just showed my desired action in the video above


declarative security on JAX-RS resources is unspecified

The MP JWT spec refers to some of the security annotations (@DenyAll and @RolesAllowed) a couple of times, in a way that implies that these annotations can be used for achieving declarative security on JAX-RS resources. However, that is totally unspecified, both in JAX-RS itself and MP JWT.
I believe this needs to be specified somewhere. Not sure where exactly, but my understanding is that even JAX-RS 2.1 doesn't define declarative security. I also believe this needs to mirror the EJB declarative security as closely as possible, because principle of least surprise.
(Question: what would happen today with an MP implementation that also supports EJB, in an application where a JAX-RS resource is also a session bean? The MP JWT spec does define some additional requirements for such implementations, so this would be a concern as well.)

Here's a consequence of this being unspecified: the WildFly Swarm MP JWT fraction implements declarative security by translation to <security-constraint>s in web.xml. That, however, can't possibly cover all of JAX-RS: https://issues.jboss.org/browse/SWARM-1955

CC @starksm64

Probably related to #74

Right, #74 is the task that was to clarify this underspecified extension of the security annotations to JAX-RS endpoints.

The title and description of #74 are quite narrow, but if the intent is cover all of declarative security, then we're on the same page :-)


fix: tune unused eslint rule

Tune unused eslint rule to support prefixing things with _ to disable unused error

Pull Request Test Coverage Report for Build 510232509

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.4%) to 84.698%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/trigger.ts
2
61.92%

Totals

Change from base Build 510134565:
0.4%

Covered Lines:
18067

Relevant Lines:
20364

💛  - Coveralls

Pull Request Test Coverage Report for Build 510232509

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.4%) to 84.698%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/trigger.ts
2
61.92%

Totals

Change from base Build 510134565:
0.4%

Covered Lines:
18067

Relevant Lines:
20364

💛  - Coveralls


Added an option to wrap (or not) each sentence in the DOM.

With this, there's an option for not modifying the DOM if we only want to retrieve the text but not to manipulate the HTML. In this way the operation is much less expensive than wrapping each of the elements with another one.
Bumped to V2.1.0 according to semver (added functionality in a backwards-compatible manner)
Fix #12

Thank you, sir! Will look into this shortly.

Any chance this can be merged anytime soon?


Avoid unnecessary aux nodes in Tseitin

If the recursive procedure finds an Or node with only variable children, there isn't any need to create and aux node. Just return the Or as a base case.

I think that's only true if the node has to be satisfied, for example because it's the root node or a child of an And root node.
Consider true | (a | b). It's satisfied by {'a': False, 'b': False}, so a | b should not appear as a clause.
I do think that something like this would be good to have, at a minimum to the point that running .to_CNF() on a sentence that's already in CNF doesn't do anything.

Ah, great point. The aux is required in order to activate/deactivate that particular clause. So perhaps the simplification should be if there's a top-level And, all of the clause children are kept aside while the rest is Tseitin'd and then those clauses conjoined again in the end.
As an aside, it would be useful to have a naive to_CNF implementation (ala de Morgan's) as well -- some theories are "nearly CNF", and it would be ok to pay the price of a minor blowup in order to avoid the extra search effort through aux vars: #21


Can delete read only settings and rbac TF

Code change was originally intended to (and does) address flakey rbac tests, until a related bug was found. The bug is detailed below. The two failing tests were impersonation_passthrough and project_owner.

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Send a delete request to settings API for cacert setting:

 curl -k -**YOUR-TOKEN** -X DELETE -H 'Content-Type: application/json' https://**RANCHERURL**/v3/settings/cacerts
Result:
Delete is successful.
Note: User should not be able to delete read only settings.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.1.1+

saw this twice again, https://drone-pr.rancher.io/rancher/rancher/1844/2/2

https://drone-pr.rancher.io/rancher/rancher/1845/2/2

Again: https://drone-pr.rancher.io/rancher/rancher/1855/2/2

rancher/rancher:master-head ca39b717

Deploy Rancher
Create token
Attempt to delete read only setting and error is received:

> curl -k -u <token> -X DELETE -H 'Content-Type: application/json' https://<url>/v3/settings/cacerts
{"baseType":"error","code":"MethodNotAllow","message":"Cannot delete readOnly setting cacerts.","status":405,"type":"error"}


Adding types property to package.json

Is your feature request related to a problem? Please describe:
While trying to import this in a typescript file, we ran into some typscript warnings/errors because it was missing type declarations. We're unable to import BuildPlugin unless we force typscript to ignore the type.
error TS2307: Cannot find module '@datadog/build-plugin' or its corresponding type declarations.
13 import * as BuildPlugin from "@datadog/build-plugin";

Describe the solution you'd like:
According to https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package, package.json might need types: "./src/types.ts" (or ./src/types.d.ts?). We suspect this might be the cause of the missing types error.
Describe alternatives you've considered:
For now, we worked around this issue by adding // @ts-ignore flag to the import line.
Additional context:

Hello there :wave:.
Sorry for the delays, I'm checking this right now.
I'm wondering in which context you're using import * as BuildPlugin from "@datadog/build-plugin"?
Do you have the same issue if you're doing import { BuildPlugin } from '@datadog/build-plugin/dist/webpack'; ?
Because all the types are already there, but we don't have a "main" entry in our package.json.

Closing this for lack of details, and this will most likely be covered by v2.


Somehow the generation of a gcp vpcaccess connector's ID output is invalid regex

What happened?

Error creating Connector: googleapi: Error 400: Connector ID must follow the pattern ^[a-z][-a-z0-9]{0,23}[a-z0-9]$.

The name passed to this was something like staging-company-project and will fail when the regex validation of the connector ID output fails.
I don't know what it is exactly, I think it might be the length going over 24 characters.
https://user-images.githubusercontent.com/1260938/194893535-4a4df433-1391-4e5a-880d-b521e1057ed6.mov
Renaming the Connector to simply "connector" fixes this bug.
Steps to reproduce
Try to make a gcp.vpcaccess.connector with a name with at least 2 hyphens and like 20 characters.
Expected Behavior
For my name to be valid and not cause side effects in an output field
Actual Behavior
Fails due to invalid ID output for Connector
Output of pulumi about
CLI
Version      3.42.0
Go Version   go1.19.2
Go Compiler  gc

Plugins
NAME        VERSION
cloudflare  4.12.1
gcp         6.38.0
nodejs      unknown
random      4.8.2

Host
OS       darwin
Version  12.5.1
Arch     arm64

This project is written in nodejs: executable='/opt/homebrew/bin/node' version='v18.7.0'

### Additional context

_No response_

### Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @SimonMacIntyre, thank you for getting in touch about this!
In this case, your name staging-company-project is under Google's character limit, but after Pulumi appends its auto-generated suffix, it's over the limit.
It is possible to disable Pulumi's naming suffix and use exactly the name you provide, although that comes with some trade-offs. See the naming docs for an explanation.
I hope that helps.

Ah I see, thanks for the explanation, makes sense.


More simple null safety migration

Migration to null-safety
Dependencies upgraded

@rafaelsetragni - Thanks, I will test it a bit later.


Update for websocket 0.10.0

This updates the library to work with websocket 0.10.0.
The biggest change is passing (tx, rx) Messages instead of Strings to allow Client.split() usage without having to use an Arc<Mutex<Client>>.

Thanks.


0.3.0 not working with RN0.32.0

When I swipe a row in a SwipeListView it immediately bourse back and won't stay open.  I tried reverting back to 0.2.3 but that didn't help, so maybe is an issue with RN0.32

Hm @npomfret I'm personally using 0.3.0 with RN 0.32 and haven't had an issue so far. If you could post your code and any other information about platform, OS, or version number that'd be really helpful and I'd be happy to take a look, thanks!

  <SwipeListView
            previewFirstRow={true}
            previewOpenValue={50}
            keyboardDismissMode="on-drag"
            removeClippedSubviews={false}
            enableEmptySections={true}
            scrollEventThrottle={2}
            dataSource={dataSource}
            renderRow={this.renderRow.bind(this)}
            renderHiddenRow={this.renderHiddenRow.bind(this)}
            renderSeparator={this.renderSeparator.bind(this)}
            renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />}
            rightOpenValue={-75}
            disableLeftSwipe={true}
          />

Solved it.
I was missing a leftOpenValue={xx} prop.  I thought because I'd used disableLeftSwipe={true} that it wasn't needed, but without it the right swipe just bounces back.  Strangely, I tried settings it to 0 and 1 but neither worked.  So I set it to 75 and the right swipe works now.
Thanks!


fix(hash): second time redirect page no effect

This PR is about #916.
I think we should not throw NAVIGATION_DUPLICATED if redirectedFrom exists, and at the same time from, targetLocation & redirectedFrom are not the same value.
I tested this PR with the case in #916 and it works. Feel free to let me know if I need to add the corresponding tests. :-)
Fix #916

Thank you but I'm not sure about this. The correct way would be to restore the history like in #921. Did you find a case where that fix was failing?

Hi @posva . I think I find a solution about this.
I pushed a new PR #944 . You can merge #944 if you think it's a good solution, or you can close that PR and modify the code of this PR. It's up to you. :)


Explore Notebook formatting via Code Actions

Overview
Opening this issue up as a discussion point for the current work around notebook formatting. As a way to accomplish this without the introduction of new API, the thought is to introduce a new Code Action Kind notebook.format.extensionID. Looping in some relevant notebook formatting people.
cc: @rebornix @karthiknadig @charliermarsh

Proposed Plan

Extension authors will provide a Code Action that wraps all of their formatting into a single action, with the kind notebook.format.xyz

We recommend that the xyz is unique to your extension, but this is not a restriction
We require that you have a complete DocumentFilter that contains notebookType

Only one formatting Code Action will be used against the notebook.

If more than one extension registers a provider for this type, users will be prompted to choose between them and define a setting "notebook.defaultFormatter": "extensionID" (mirrors the editor setting)
If an extension registers multiple notebook.format.xyz providers, only the first will be used.
If a notebook.format Code Action is applied on save, the standard provideDocumentFormatting flow will be skipped

The notebook.format Code Action can be applied in the following ways:

Setting "notebook.formatOnSave.enabled": true (this means that there will only be explicit triggering of this for saves, due to formatOnSave requiring the file to NOT be saved after a delay)
Command palette Format Notebook
Notebook Context Menu (🔜)

Rough Example

Extension (pseudo)Code:

export async function activate(context: vscode.ExtensionContext) {
	registerCodeActionsProvider(DocumentFilter, new ProviderName(), providedKinds);
}

class ProviderName {
	static readonly kind = "notebook.format.extensionID";

	public provideCodeActions(
		document: vscode.TextDocument,
		_range: vscode.Range | vscode.Selection,
		_context: vscode.CodeActionContext,
		_token: vscode.CancellationToken
	): vscode.CodeAction[] | undefined {
		const nbEdits: NotebookEdit[] | TextEdit[] = {
			// wrap all formatting edits here
		}

		const fix = new vscode.CodeAction(
			'Apply Notebook Formatting',
			ProviderName.kind,
		);
		fix.edit = new vscode.WorkspaceEdit();
		fix.edit.set(notebookDocument.uri, nbEdits);
		return [fix];
	}
}

User settings.json:

{
	"notebook.defaultFormatter": "extensionID", // extensionID
	"notebook.formatOnSave.enabled": true,

	"notebook.codeActionsOnSave": { // these will occur BEFORE the formatter
		"source.xyz": "explicit",
	}
}

Other relevant notes

Code Action Kind prefix rules

Code Action Providers that return a kind prefixed with notebook. will only ever be called against the 0th cell of the notebook. Additionally, the provided TextDocument will always correspond to the 0th cell in the notebook and contain a uri that can retrieve the notebook. It is the responsibility of the provider to extract the NotebookDocument from this (an example will be provided in a sample extension, coming 🔜).
If a Code Action is added to settings under notebook.codeActionsOnSave without the notebook. prefix, the codeaction will be applied to every valid cell asynchronously, in parallel.

Using NotebookEdit.replaceCells() is less performant than simply using TextEdit.replace() against that document. Additionally, using NotebookEdit.replaceCells() will fully replace cells, including output. When possible, use TextEdits for editing just the content of a cell.

Questions

Feel free to leave any and all thoughts below :+1:

Also cc'ing the other folks that have worked on Notebook support in Ruff: @snowsignal @dhruvmanila

@Yoyokrazy Can you clarify where we use fully qualified extension-id vs just the extension id? Correct me if what I got is wrong
For settings.json I am assuming it will be fully qualified extension id here (like):
"notebook.defaultFormatter": "ms-python.black-formatter"

Would VS Code provide the completion similar to editor.defaultFormatter?
For the notebook.formatter.* code action, I am assuming it is just the extension id? (like):
notebook.formatter.black-formatter

@Yoyokrazy One thing to verify is what gets added as id when Language Client registers this. I am assuming it extracts the extension ID, but there is also LS server id. This feature does not pertain to LS client, but code actions are registerable via LS client.

Updates after initial support has been implemented:

There were some incorrect assumptions in the functionality of extension defined Code Action Kinds. Initially we were operating under the assumption that in core functionality, as the extension registers a provider, the fully qualified extension ID is bundled into the provider object. This was incorrect, only the displayName was passed through and even then only used to display a progress message to the user.

Changes: The fully qualified extension id (publisher.extName) is held within the provider instance, allowing core functionality to isolate actions and providers from specific extensions.

There was a decent bit of confusion surrounding how the suffixes for code action kinds are used, how extensions should be defining/registering them, and how the users will use this to request specific code actions via their settings.json. After a lengthy debug process, the guidelines for extensibility are as follows:

As an extension author, while calling registerCodeActionsProvider(), the parameters are your document filter, the provider instance, and providedCodeActionKinds within the CodeActionProviderMetadata. The strong recommendation is that you add a unique suffix to the provided kinds that you register in this metadata. This does not need to be a fully qualified extension ID, this suffix is more informal, just acting as an avenue for users to specify which of a superset of returned codeactions they want to be run on save, etc. Furthermore, while returning a Code Action inside the provideCodeActions() implementation, you should return the code action kind again suffixed with a unique identifier to your extension. (ex: ruff correctly registers and returns source.organizeImports.ruff allowing users to specify that they want that specific extension's organize import code action -- cc/@karthiknadig)
Users in their settings.json can choose between the broader scoped code action kind (ex: source.organizeImports), or the narrower scoped code action kind with the suffix (ex: source.organizeImports.ruff). This lets them control whether or not they want a code action provided by a specific extension. Keep in mind it is the responsibility of the extension author to register their providers with and returning code actions as having this suffix.

Key point here: if a user requests either a broader OR narrower scoped kind in their codeActionsOnSave setting, they will be returned ALL code actions from providers that register that base kind (regardless of suffix). This is because  while vscode gathers code action providers, this is based on the being a superset or a subset of the user requested kind. Actions are provided for each provider. However, during the filtering of provided/returned actions, only code actions that are a subset of the requested kind will be applied (ex - user defines source.organizeImports.A in code actions on save but only has a provider of that registers and also returns source.organizeImports -- a more generic kind. The code action will be provided, however will be filtered out before being applied)

As a more detailed example:

Three extensions A, B, and C all register code action providers with the metadata containing the provided kind as the broader source.organizeImports. They correctly provide/return code actions that hold the more precise Kind of source.organizeImports.A/B/C
Case 1: User defines "editor.codeActionsOnSave": { "source.organizeImports": "always" }. Whenever they trigger an onSave event, actions from all three extensions will provided, due to the hierarchical structure of Code Action Kinds. They will also all be applied to the document due to their kinds matching the broader requested action in their settings.
Case 2: User defines "editor.codeActionsOnSave": { "source.organizeImports.B": "always" }. Whenever they trigger an onSave event, actions from all extensions are provided. However, only the action from extension B is applied, due to the provided action holding the narrower type source.organizeImports.B

As always, feel free to leave any and all questions!

related: https://github.com/microsoft/vscode/issues/161284
the end goal would be that extension authors contribute a specific source.... action, and we'd be able to show their specific contribution in the settings.json/UI.

Another example:

Three extensions A, B, and C all register code action providers with the metadata containing the provided kind as the narrower source.organizeImports.A/B/C. They ALSO provide/return code actions that hold the more precise Kind of source.organizeImports.A/B/C
User defines "editor.codeActionsOnSave": { "source.organizeImports.B": "always" }. Whenever they trigger an onSave event, only provider B is retrieved, due to nothing else matching a superset or subset. The returned code action from extension B's provider will applied to the document due to the kinds matching a subset (in this case they are the same) of the requested action in their settings.

Also related to: https://github.com/microsoft/vscode/issues/174295
This does not solve the corrupted code issue from running multiple providers against the same document, and getting edits from both. However, this information does outline the more precise way for providers to register their provided Kinds, allowing users more granular control over the execution of code actions.
On another note, referring to the following:

if users have both source.organizeImports and source.organieImports.isort in settings.json, it just runs source.organizeImports

There is currently no way for a user to disable a specific code action, if they request a broader scope in settings.json. We have seen users try the following which will not work:
{
    "editor.codeActionsOnSave": {
        "source.organizeImports.A": "never"
        "source.organizeImports": "always"
    }
}

This is the user trying to opt-out of a specific action running under the "organize imports" group. This is not a functionality that is supported. In this case the user should remove their broader kind, and simply opt-in to the the providers that they specifically want.

Ruff has applyFormat command that is now format entire notebook. see https://github.com/astral-sh/ruff/pull/11493.
Just dropping my 2cents here:
Non-breaking proposal:
{
    # only ruff organizes imports
    "notebook.codeActionsOnSave": {
        "source.organizeImports.ruff": "always"
    }

    # all except ruff organizes imports
    "notebook.codeActionsOnSave": {
        "source.organizeImports.ruff": "never",
        "source.organizeImports": "always"
    }

    # a `codeActionKind` called `sourceFormat` which will deprecate `formatOnSave` and `defaultFormatter` settings.
    "notebook.codeActionsOnSave": {
        "source.format": "always"
    }
}

Breaking proposal:
{
    "notebook.codeActionsOnSave": {
        "source.format.ruff": "explicit",
        "source.organizeImports.ruff": "always",
        "source.organizeImports.isort": "always",
        "source.fixAll.ruff": "explicit",
    }
}

Pure code actions NOT allowed. (e.g. { "source.organizeImports": "always" })
Code actions will perform on a queue (ordered-dict) and each action will perform based on previous action result.
Possible values are only always and explicit.

@T-256 thanks for the input! A lot of the points you brought up have made their way through discussions on the team as we've planned this out, and I agree with a lot of the logic behind them. Unfortunately, there's been a lot of work done throughout the years and enough users (+ our product) rely on the current behavior of code action kinds that we can't adopt some of the behaviors that you brought up. Specifically the thoughts you outlined with the following code block:
    # the way code action kinds work heirarchically prevents this opt-out behavior, since they work in supersets as well as subsets
    "notebook.codeActionsOnSave": {
        "source.organizeImports.ruff": "never",
        "source.organizeImports": "always"
    }

We're going to be trying to write enough documentation that extension authors provide the correct code action kinds to begin with. The thinking being that introducing this structure as a layer on top of the existing code action logic will prevent us from breaking any existing workflows, while giving people like ruff the rich support to develop better notebook formatting support.

Also wanted to check with @snowsignal @dhruvmanila to see if there is any plan or timeline for using vscode api + the new notebook format code action kind with ruff. Feel free to reach out if there's anything I can do to help out 👍

@Yoyokrazy We don't have a timeline for that yet, but we'll keep you updated!

Reading through this thread as an end user. The notebook.codeActionsOnSave key is very confusing, especially without Intellisense inside there. My simple question is: how do we enable isort for a Jupyter Notebook with these new settings?
This does not seem to work:
    // NOTEBOOKS
    "notebook.formatOnSave.enabled": true,
    "notebook.codeActionsOnSave": {
        "source.organizeImports": "explicit"
    },


Release 9.2.10, 9.3.7 and 9.4.2 tags on official repo

Not sure where to report this issue..
The readme at https://registry.hub.docker.com/_/postgres/ suggests that the 9.2.10, 9.3.7 and 9.4.2 tags are available, but they aren't.
The code was changed 4 days ago, but no builds where created (or pushed).

Looks like we got ahead of the pushes with the docs updates.  They are pushing as I type.  They were added to the official images build server with https://github.com/docker-library/official-images/pull/752.

They should hopefully be up within the next hour.

Thanks, images are available!


[Vlive] Only downloads a single file when attempting to download a playlist

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dlc version 2020.10.31
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.vlive.tv/video/113764/playlist/113852', '-v']
[debug] Loading archive file None
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dlc version 2020.11.11-2
[debug] Git HEAD: d052b9a11
[debug] Python version 3.8.5 (CPython) - Linux-4.19.104-microsoft-standard-x86_64-with-glibc2.29
[debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4
[debug] Proxy map: {}
[vlive:playlist] Downloading playlist 113852 - add --no-playlist to just download video
[vlive:playlist] 113852: Downloading webpage
[vlive:playlist] Downloading just video 113764 because no playlist was found
[vlive] 113764: Downloading webpage
[vlive] 113764: Downloading JSON metadata
[vlive] 113764: Downloading JSON metadata
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'http://globalv.video.p.rmcnmv.naver.com/c/read/v2/VOD_ALPHA/global_v_2019_02_19_407/c2da513a-340c-11e9-a5ac-246e963a49b9.mp4?_lsu_sa_=6365f6f311576da602df05ee6955d2bb2eeb3b486c08cfe13897a8c577283ba59e2c3a6464652b0d008531f2093e1b1ad6bfae5ec39e31da301c16889a1a1cb0139619e68e7367767c6c7343c68013d0'
[download] Destination: [V LIVE] 아이돌룸(IDOL ROOM) 39회 주Honey캠 - 이번주 픽돌 탄생 Jooheon's CAM - Birth of Today's PickDol-113764.mp4
[download] 100% of 8.28MiB in 00:02

Description

Attempting to download a playlist results in downloading a single video.
For example, link https://www.vlive.tv/video/113764/playlist/113852 contains total of 8 videos, but only downloads the video associated with the link, failing to download all videos within the playlist.
This behavior is simillar to adding  --no-playlist option.

#223 should fix this @kyuyeunk maybe @SeonjaeHyeon can also contribute to that matter.


First Pass

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


steamPackages.steamcmd: fix hash

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'll send what it got from the link for anyone who wants to use diffoscope
src.tar.gz
hash: sha256-zr8ARr/QjPRdprwJSuR6o56/QVXl7eQTc7V5uPEHHnw=

I am now also getting that but yesterday I got a differnet hash...


this._addToast observer is not defined

Hi,
Just to preface this, the project I'm using angular2-toaster for uses rxjs 5.0.0-beta.12 and is Angular2.1.xl.
I'm trying to use the toasterService method .pop() with a Toast object passed in, and when I get to this check:
if (!this._addToast) {
            throw new Error("No Toaster Containers have been initialized to receive toasts.");
}

this._addToast is always undefined.
At this point in the execution of the .pop() method, the 'this' context has addToast as a property but not _addToast.  It also seems that _clearToasts is undefined as well.
I pass in a toasterConfig object to the toaster-container component with all the required fields and the Toast object I'm trying to pop has the type of 'success' and some of the optional fields filled out.
Is this a known issue? Or am I just using angular2-toaster incorrectly?
Thanks.

You are almost certainly using the library incorrectly.
Where have you included a toaster container instance?  Can you include a simple plunker that demonstrates the issue?


zed-editor: 0.134.4 -> 0.135.2

Description of changes
Changelog: https://github.com/zed-industries/zed/releases/tag/v0.135.2
cc @jansol @niklaskorz

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 312030 run on x86_64-linux 1

1 package built:

zed-editor

Result of nixpkgs-review pr 312030 run on aarch64-linux 1

1 package built:

zed-editor

As a side note, I'm still working on fixing the broken darwin build, but the Livekit Swift package still is the major blocker here... It looks like Zed will move to the pure-Rust Livekit crate soon, which also will enable collaboration on Linux, so it probably makes more sense to wait for that and then fix the darwin build.

Great ! Thanks for the testing and update :)


use the same task runner for platform&render tasks

This fixes the issue where on MacOS the embedder crashes during window resizing.
fixes #133
This doesn't fixes the jankyness during resize.
Follow https://github.com/flutter/flutter/issues/44136 for more info.
Need to wait for https://github.com/flutter/engine/pull/13124 to be rolled to the flutter beta branch.

Beta has been updated.
This can be merged.
Test with: hover run -b '@no_resize_crash'


where is the xml files?

When i deploy the java app on heroku, i can't find the xml files. But there are xml files when i deploy the php app on heroku. Why? Is this a bug?

@chuang911 this looks like a bug with the Java version only. Please use any other language, till it's fixed.

Now i can receive xml use java, but i will receive the DocumentPDFs in the xml file when i set setIncludeDocuments false whit the EventNotification. And i won't receive the DocumentPDFs before The Chinese New Year.


Fix clips block showing when all clips are missing

Clips with missing status are not filtered out from "related" section. As result, a bogus Clips block may appear:

Helpful <3


Add my first file

I have created a new branch, created a file, and made a commit!!!

merged completed.


I can't get colors to work

I can't get colors to work in nvim-tree or telescope. I have been troubleshooting this problem on and off for months. I am at my wits end, I give up. I'm dumping my config folder here in case you feel like figuring out what's breaking icon colors.
In short, my nvim-tree config looks like this:
require("nvim-web-devicons").setup{ default = true }

require("nvim-tree").setup {
  hijack_cursor = true,
  view = {
    width = 40
  }
}

Result:

Frustratingly, if I reload my plugin config (:so %) and open nvim-tree again, it now has colored icons, but telescope doesn't:

I have spent more hours troubleshooting this than I care to admit, shuffling things around, disabling various plugins, configuring plugins in different orders etc. If you have any suggestions for what else I can try, I'd appreciate it a lot.
Here is my nvim config: nvim-config.zip

hi !
Did you manage to reproduce with a smaller configuration ? your configuration is quite big.
Also which version of neovim do you use ? and which terminal do your run neovim in ?

Also I just realized, when I reload my config I don't get full color support in nvim-tree, only the git status icons get colors. The file type icons are still white :thinking:

@kyazdani42 I finally found the issue. My colorscheme setup code waits until the first BufEnter, because of a bug I ran into when setting the colorscheme before a client had connected. If I comment out those lines, I get colored icons. Here is a minimal setup demonstrating the problem:

set termguicolors

exec plug#begin('./bundle')

Plug 'ryanoasis/vim-devicons'
Plug 'kyazdani42/nvim-web-devicons'
Plug 'kyazdani42/nvim-tree.lua'

Plug 'morhetz/gruvbox'

exec plug#end()

lua <<LUA
require("nvim-web-devicons").setup{ default = true }
require("nvim-tree").setup{}
LUA

au BufEnter * ++once colorscheme gruvbox

did you try fixing the colorscheme issue instead ? you should just be able to run colorscheme during startup.

Setting the colorscheme normally works for now.
I don't quite remember exactly what forced me to delay setting the colorscheme in the first place. I think I was playing with a GUI for Neovim.


F.refactor scans

Refactored the Scan operation.
Now we have everything in one place to reason about. This makes the code cleaner and more maintainable.

Retry Deepcode

Retry Deepcode

Retry Deepcode


feat(dbltrp): add support for critical-error

This pr raise critical-error in difftest when XiangShan issues a critical-error signal.
The critical-error state is defined in the smdbltrp extension. This extension specifies that when the critical-error signal is asserted, the CPU should halt execution. This PR implements a method for stopping execution in simulation mode, where difftest halts by triggering an abort.
In the future, an option to enter debug mode rather than directly halting the CPU will be introduced for handling critical-error. This incoming change won’t require modifications to the difftest framework; Xiangshan will only need to control it through an  valid signal.

what's the difference between this and trap?
the critical-error state is defined in smdbltrp extension. critical-error
Xiangshan will send a critical-error signal to the top level and difftest. At this point, the core should stop running: during simulation comparison, difftest will stop by triggering an abort; in other cases, after Xiangshan generates the critical-error signal, the ROB will stop committing instructions.
I think this represents an interruption more severe than exceptions or interrupts, causing the CPU to halt execution directly.

In the future, an option will be introduced to enter debug mode in the event of a critical-error, allowing the CPU to handle the critical-error in a way that improves error diagnosis and resolution. Currently, the handling method for critical-error is to directly halt CPU execution.

Make sense. Look good.

In the future, an option will be introduced to enter debug mode in the event of a critical-error, allowing the CPU to handle the critical-error in a way that improves error diagnosis and resolution. Currently, the handling method for critical-error is to directly halt CPU execution.

Make sense. Look good. Maybe we should add comments to explain its relationship with the double trap extension.

Sure, I have updated the comment to clarify the relationship.

Thanks. Merged.


timeslider output format bug

Describe the bug
Visit 3.4.1:
Setting string output format for the Time Slider in the annotation options -- it gets ignored (i.e. no matter what i put, its always in floating point format with full digits)

related to https://github.com/visit-dav/visit/issues/18922

and also related to: https://github.com/visit-dav/visit/issues/18609


disable MHA for sever without AMX

Type of Change
disable MHA on sever without AMX
Description
detail description
Issues: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

@yuchengliu1 @DDEle MHA_AVX2 has a problem with phi2. It blocks the performance measurement of #174.


Add documentation indicator to search results.

Update DB Scheme to include has_docs field.
Add has_docs to all queries and display "Has documentation" string in search results.

Only needs a nice icon and some CSS.

Fixes #1792

[x] fix unit tests, half way through
[ ] Get asset for documentation item
[ ] Tweak css

First try, at commit a02994dc4228af577f65974eed6717f1fc301c02 if we want to come back to it.

It looks good at full size...

... but it's not clear to someone with my eyesight what it is at such a small size.
I have another idea.

Getting there, but I think it needs to be white lines on a solid black background.

I think this might be the one.

Any opinions @jeroenleenarts?

Like this one a lot more compared to the open book.
Documentation is more a sheet of information and not a long form novella.


Enable building on arm64

Currently, the build fails since we use the FIPS boringssl which only works on amd64.
Even with the FIPS disabled though, still getting issues around poly_rq_mul.S that we will need to resolve

I have an M2 Mac and could work on this

Isn't this a dupe of #1 ?

Could be. I have an intel mac I can try to confirm if its MacOS or M1/ARM that's the issue.

ARM could also be for something like graviton support not just m1/macos as well

Allow developers using arm machines to contribute.
May also be required in some production environments.

https://github.com/istio/ztunnel/pull/139

we can also consider an approach similar to github.com/cloudflare/quiche, where we embed boring in this crate, so we don't need to set env vars for dependant crates (so that users won't need to remove the env vars manually, as specified in the readme)
https://github.com/cloudflare/quiche/blob/master/quiche/src/build.rs

@yuval-k Thx for the hint - that strategy unfortunately doesn't work with boring 2.1.0 - only with 2.0.0 that quiche uses, due to changes in build.rs for boring-sys which seem to break the ability to effectively vendor binaries: https://github.com/cloudflare/boring/blob/master/boring-sys/build.rs#L330

Adding this as a ref - https://github.com/cloudflare/boring/pull/97
A clang environmental dep might be easy to work around with a custom build image once that is - our current buildimage is too new for clang-7, which is what the pinned version of boringssl that boring-sys tries to autobuild (when installed as a Gitref dep) requires.
When that merges we should be good with clang-12, which is available for both arm64 and amd64 in our current build image, at least.


Error in Tutorial: Create an ASP.NET Core app with React in Visual Studio

I'm trying to follow the tutorial, but in the end of the "Start the project" section the error "Unable to launch browser" pops up to me, and then the backend crashes:

I followed everything in the tutorial (aside from using different project and solution names). How do I fix this?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f5beb7f5-5d28-d5e5-92ba-3e04c75e44b5
Version Independent ID: 867e3a3f-2387-ba46-c911-10822f8c4a81
Content: Create an ASP.NET Core app with React - Visual Studio (Windows)
Content Source: docs/javascript/tutorial-asp-net-core-with-react.md
Product: visual-studio-windows
Technology: vs-javascript
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@gabrielmaia2 -- Gabriel, thank you for your feedback and request.  Please consider these resources, and let me know if they help get you unblocked:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

cc @Mikejo5000 for awareness

I reinstalled visual studio and it worked. Thanks.


Contract billing information is only for node contracts

After a cleaning storage operation it appears that ContractBillingInformationByID new entries are created for contracts that are not node contracts.

By checking the code it seams that this happens in billing loop where all types of contracts are billed.
https://github.com/threefoldtech/tfchain/blob/333413419983df4bf6afeba65e19f173862d4d16/substrate-node/pallets/pallet-smart-contract/src/lib.rs#L1204
A previous filter should be added to avoid this.
Note: ContractBillingInformationByID is value query.

Fix verified


[SUPPORT] - Presto Querying Issue in AWS EMR 6.3.1

Hi team,
We are using Hudi 0.5.0, Presto 0.230 in emr 6.0.0 version and we have used the below sample code for data ingestion. During the upgrade, we are facing error with Presto.
Below code executed in 0.5.0. Post the data ingestion we have manually updated the table location to "s3://bucket_name/test/table_name/default" and we are able to query the data in Presto 0.230 as well.
We are in progress of upgrading the emr version to 6.3, during the POC we have observed that the table ingested through emr 6.0 (Hudi 0.5.0, Presto 0.230) is not working in Presto query engine emr 6.3 (Presto 0.245.1 & Hudi 0.7.0). provided the error below. Could you please take a look at the below and let me know
Code Executed in 0.5.0
inputDF = spark.createDataFrame(
[
("100","Apache","Spark", "2015/01/01", "2015-01-01T13:51:39.340396Z","2015-01-02"),
("101","Apache","Beam","2015/01/01", "2015-01-01T12:14:58.597216Z","2015-01-02"),
("102","Apache","Hudi","2015/01/01", "2015-01-01T13:51:40.417052Z","2015-01-02"),
("103","GCP","DataProc","2015/01/01", "2015-01-01T13:51:40.519832Z","2015-01-02"),
("104","AWS","Glue","2015/01/02", "2015-01-01T12:15:00.512679Z","2015-01-03"),
("105","AWS","EMR","2015/01/02", "2015-01-01T13:51:42.248818Z","2015-01-03")
],
["id","provider","technology", "created_date", "last_update_time","load_date"]
)
hive_jdbcurl = "jdbc:hive2://localhost:10000"
hive_username = "hive"
hive_password = "xxx"
hudi_table_name="table_name"
landing_bucket = "s3://bucket_name/test"
hive_schema = "test"
inputDF.write.format("org.apache.hudi").option("hoodie.datasource.write.recordkey.field","id,provider").option("hoodie.datasource.write.precombine.field","last_update_time").option("hoodie.table.name",hudi_table_name).option("hoodie.datasource.write.storage.type","MERGE_ON_READ").option("hoodie.datasource.hive_sync.enable","true").option("hoodie.datasource.hive_sync.database",hive_schema).option("hoodie.datasource.hive_sync.table",hudi_table_name).option("hoodie.datasource.hive_sync.jdbcurl",hive_jdbcurl).option("hoodie.datasource.hive_sync.username",hive_username).option("hoodie.datasource.hive_sync.password",hive_password).option("hoodie.datasource.hive_sync.assume_date_partitioning","false").option("hoodie.datasource.hive_sync.partition_extractor_class","org.apache.hudi.hive.NonPartitionedExtractor").option("hoodie.datasource.write.keygenerator.class","org.apache.hudi.ComplexKeyGenerator").option("hoodie.compact.inline","true").option("hoodie.bulkinsert.shuffle.parallelism","100").option("hoodie.insert.shuffle.parallelism", "2").option("hoodie.upsert.shuffle.parallelism", "2").option("hoodie.datasource.write.operation","bulk_insert").mode("Overwrite").save(landing_bucket+hudi_table_name)
Presto Error
Hoodie table not found in path s3://bucket_name/test/table_name/default/.hoodie at com.facebook.presto.jdbc.PrestoResultSet.resultsException(PrestoResultSet.java:1841) at com.facebook.presto.jdbc.PrestoResultSet$ResultsPageIterator.computeNext(PrestoResultSet.java:1821) at com.facebook.presto.jdbc.PrestoResultSet$ResultsPageIterator.computeNext(PrestoResultSet.java:1760) at com.facebook.presto.jdbc.internal.guava.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:141) at com.facebook.presto.jdbc.internal.guava.collect.AbstractIterator.hasNext(AbstractIterator.java:136) at com.facebook.presto.jdbc.internal.guava.collect.TransformedIterator.hasNext(TransformedIterator.java:42) at com.facebook.presto.jdbc.internal.guava.collect.Iterators$ConcatenatedIterator.getTopMetaIterator(Iterators.java:1311) at com.facebook.presto.jdbc.internal.guava.collect.Iterators$ConcatenatedIterator.hasNext(Iterators.java:1327) at com.facebook.presto.jdbc.PrestoResultSet.next(PrestoResultSet.java:146) at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:231) at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:381) at py4j.Gateway.invoke(Gateway.java:259) at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:133) at py4j.commands.CallCommand.execute(CallCommand.java:79) at py4j.GatewayConnection.run(GatewayConnection.java:209) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hudi.exception.TableNotFoundException: Hoodie table not found in path s3://bucket_name/test/table_name/default/.hoodie at org.apache.hudi.exception.TableNotFoundException.checkTableValidity(TableNotFoundException.java:53) at org.apache.hudi.common.table.HoodieTableMetaClient.(HoodieTableMetaClient.java:128) at org.apache.hudi.common.table.HoodieTableMetaClient.(HoodieTableMetaClient.java:114) at org.apache.hudi.common.table.HoodieTableMetaClient.(HoodieTableMetaClient.java:100) at com.facebook.presto.hive.HudiDirectoryLister.(HudiDirectoryLister.java:58) at com.facebook.presto.hive.StoragePartitionLoader.(StoragePartitionLoader.java:138) at com.facebook.presto.hive.DelegatingPartitionLoader.(DelegatingPartitionLoader.java:56) at com.facebook.presto.hive.BackgroundHiveSplitLoader.(BackgroundHiveSplitLoader.java:112) at com.facebook.presto.hive.HiveSplitManager.getSplits(HiveSplitManager.java:298) at com.facebook.presto.spi.connector.classloader.ClassLoaderSafeConnectorSplitManager.getSplits(ClassLoaderSafeConnectorSplitManager.java:62) at com.facebook.presto.split.SplitManager.getSplits(SplitManager.java:90) at com.facebook.presto.split.CloseableSplitSourceProvider.getSplits(CloseableSplitSourceProvider.java:53) at com.facebook.presto.sql.planner.SplitSourceFactory$Visitor.lambda$visitScanAndFilter$1(SplitSourceFactory.java:192) at com.facebook.presto.sql.planner.LazySplitSource.getDelegate(LazySplitSource.java:96) at com.facebook.presto.sql.planner.LazySplitSource.getConnectorId(LazySplitSource.java:48) at com.facebook.presto.execution.scheduler.SectionExecutionFactory.createStageScheduler(SectionExecutionFactory.java:281) at com.facebook.presto.execution.scheduler.SectionExecutionFactory.createStreamingLinkedStageExecutions(SectionExecutionFactory.java:243) at com.facebook.presto.execution.scheduler.SectionExecutionFactory.createStreamingLinkedStageExecutions(SectionExecutionFactory.java:221) at com.facebook.presto.execution.scheduler.SectionExecutionFactory.createSectionExecutions(SectionExecutionFactory.java:167) at com.facebook.presto.execution.scheduler.LegacySqlQueryScheduler.createStageExecutions(LegacySqlQueryScheduler.java:343) at com.facebook.presto.execution.scheduler.LegacySqlQueryScheduler.(LegacySqlQueryScheduler.java:233) at com.facebook.presto.execution.scheduler.LegacySqlQueryScheduler.createSqlQueryScheduler(LegacySqlQueryScheduler.java:164) at com.facebook.presto.execution.SqlQueryExecution.planDistribution(SqlQueryExecution.java:508) at com.facebook.presto.execution.SqlQueryExecution.start(SqlQueryExecution.java:381) at com.facebook.presto.$gen.Presto_0_245_1_amzn_0____20211208_121047_1.run(Unknown Source) at com.facebook.presto.execution.SqlQueryManager.createQuery(SqlQueryManager.java:254) at com.facebook.presto.dispatcher.LocalDispatchQuery.lambda$startExecution$5(LocalDispatchQuery.java:114) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ... 1 more

@nsivabalan Hi Siva, when you get a chance, can you please take a look on the above

sure. Will be looking into github issues today and tomorrow.

@rajgowtham24 From the stacktrace, it seems like .hoodie directory is not present under the table basepath. How was the relocation done? Can you please check that the path contain .hoodie dir after updating the location?
Another problem I noticed with the stacktrace is that it contains a call from HudiDirectoryLister. This class is not present in Presto version 0.245.1. Can you check again?

@codope - below is the folder structure post the data write from 0.5.0. Since Presto doesn't identify the parquet files under /default directory we have manually updated the table location for the table so that the query would work fine in Presto 0.230
s3://bucket_name/test/table_name/
-.hoodie_$folder$
-.hoodie/
-default_$folder$
-default/

@rajgowtham24

we have manually updated the table location to "s3://bucket_name/test/table_name/default"

so is default/ the partition path in your table? I don't quite get why this is need. Were you not able to query the table with path = s3://bucket_name/test/table_name ? It's obviously causing problem as the stacktrace is complaining table not found, because the table path is overwritten to where the .hoodie/ is not present. So the problem is about setting the correct table path. I suggest follow guide here https://hudi.apache.org/docs/query_engine_setup#prestodb and use the intended path.
Also please contact AWS support as this is under AWS environment, which we can't troubleshoot.

@xushiyan - when we are using complexkey generator in 0.5.0, by default Hudi is creating the data under default partition(same is happening with 0.8.0 as well). So to query the table through Presto 0.230 we have to modify the table location s3://bucket_name/test/table_name/default.
For partitioned table, without updating the table location we are able to query the table from Presto 0.230

@rajgowtham24 i think you need NonpartitionedKeyGenerator instead for non-partitioned table. default/ is created when complex key gen fails to extract partition path properly. With default/ in the directory, your table is unexpectedly "partitioned" now, and in your hive_sync.partition_extractor_class you used NonPartitionedExtractor, that's probably causing reading issue.

@xushiyan - when we are using complexkey generator in 0.5.0, by default Hudi is creating the data under default partition(same is happening with 0.8.0 as well). So to query the table through Presto 0.230 we have to modify the table location s3://bucket_name/test/table_name/default.
For partitioned table, without updating the table location we are able to query the table from Presto 0.230

@xushiyan - in 0.5.0, NonpartitionedKeyGenerator doesn't support Composite Primary Keys, so we have used ComplexKeyGenerator and the querying works as expected through Presto 0.230 and not in Presto 0.245.1

@xushiyan - in 0.5.0, NonpartitionedKeyGenerator doesn't support Composite Primary Keys, so we have used ComplexKeyGenerator and the querying works as expected through Presto 0.230 and not in Presto 0.245.1

@rajgowtham24 Ok do you mean the issue resolved with Presto 0.230 ?

@xushiyan - in 0.5.0, NonpartitionedKeyGenerator doesn't support Composite Primary Keys, so we have used ComplexKeyGenerator and the querying works as expected through Presto 0.230 and not in Presto 0.245.1

@rajgowtham24 Ok do you mean the issue resolved with Presto 0.230 ?

yes @xushiyan

@rajgowtham24 thanks!


vtm panel

Hi!
I started making an info panel for vtm, github repo is here.
I made this issue to update on progress.

Currently this has the issue that when using it, the panel resets the escape code, which leads to vtm sometimes drawing the panel background color instead of the default color, and the terminal is really gliched. I made a video of it:
https://github.com/netxs-group/vtm/assets/100359465/9813d666-f7a0-4575-b6df-74955d315ec2

I made it check the vtm version, because originaly it was at the bottom, covering the vtm version at the bottom right.

I am not using bash, I am using a shell called xonsh because of the python/shell combi. I dont know how the coloring works, because you can insert {color} in the $PROMPT variable and it makes the color for you. It uses prompt_toolkit.
But I think this issue is there when I am using bash as well... Will verify in a second

Sorry for the slow replies, I've been diving into extending the win32-input-mode protocol and this will take some time.

I am planning to add an extra section to the user's viewport to bind an external panel like yours there. This is a one cell high (adjustable value) and full screen width section located at the very top of the vtm viewport.

vtm will output whatever your panel prints to the console.

What's the progress here? Where are you currently working on?

I dived into implementing full keyboard support. It is necessary to uniquely identify the pressed buttons in order to use them inside the vtm. This must be implemented for correct remote work on heterogeneous systems. For example, in a Windows-Linux remote connection scenario, keyboard input occurs with errors.
Without keyboard input working correctly, it's not worth talking about remote use via directvt.
I also found that vtm is used on Android. Keyboard control is very lacking there, because instead of a mouse there is only a touch interface.
It also requires prebuild binaries for ARM architecture, including 32-bit ones, and since vtm cannot be built on a 32-bit host, the compiler needs more than 4 gigs of RAM. I have to build such assemblies too. There were a number of issues when compiling to 32-bit architecture.
I'll be able to work on the vtm panel after I finish keyboard support, it will take some time.

Along the way, I make keyboard events available from outside using the vt-input-mode #400 protocol.

I also found that vtm is used on Android.

Yes, it is available in the termux repos. I installed it. Single clickes work, but dragging only moves the mouse, without sending  a click. I cant verify it is not getting a click, because I cant open debug mode, my tablet is to old to support the 🐞.

It also requires prebuild binaries for ARM architecture, including 32-bit ones, and since vtm cannot be built on a 32-bit host, the compiler needs more than 4 gigs of RAM. I have to build such assemblies too. There were a number of issues when compiling to 32-bit architecture.

Vtm is compiled for android in the termux repo. I guess compiling works for android... but on both my android devices uname -m returns aarch64, so I guess they both are 64bit arm. Also, I once was able to run vtm on my armv7l raspberrypi. I just deleted it to update it, then found out I could not recompile because of outdated gcc.

I'm currently doing builds for ARM 32-bit and ARM 64-bit. For Windows, this turned out to be easy, now I'm doing it for Linux.

yes I know, but what I mean, could you use the termux binary on arm linux?
It is possible responses are slow next week, I am on holydays to Spain.

I haven't tested this (run Android/termux binaries on Linux), I don't have ARM devices within reach yet, and I'll test it on QEMU a bit later.
Have a nice vacation!

I don't have ARM devices within reach yet

I am thinking about buying a pinetab 2, but I don't know if I can get it in europe yet. Pine64's site is not very clear on that...

Have a nice vacation!

Thank you!

I am going to revisit my panel, but first I have to chatch up on release notes: still on v0.9.9q!

To hide any scrollbars, the application running in the panel simply needs to switch to the alternate buffer using the following vt-sequence:
# Altbuf
printf "\e[?1049h"

# Normal scrollback
printf "\e[?1049l"

Thank you very much for doing this! 👍

I guess I wrote a very detailed doc including code snippets instead. It uses examples in python3, but there's a bash adaptation at the bottom for the people that don't understand python (assuming everyone understands either python or bash :D ).
panelDocs.md

If you don’t mind, I’ll open a pull request (or you can open it yourself) and we’ll make edits there.

I edited the panel.md text a little and added a link to it from readme.md.

I don't have anything to add, I agree with your edits. Thanks for merging!

I agree with closing. Note I linked this issue from the repo as status tracker for the panel I am maintaining. If you want I can move that over to there.

I can't translate the last sentence 😅. Perhaps we need to cross-link this, add links to doc/panel.md and the like.

Ah, sorry, I meant:
I am currently asking people to go to this issue for announcements etc for my script.
If you want, I can make an issue in my own repo for announcements etc.

I have added a cross-reference to your vtm panel repository in the doc/panel.md subsection App-based Dashboard.

I've corrected the text a little. This text was slightly mismatched. I didn't notice that the link was already there in the text 😅.

I guess I will have to redo some things on my panel anyways to make it a bit more userfriendly (add stuff like colors and a config).
Does the vtm terminal translate color escape sequences (\e[48;2;0;0;0m-like) to windows api calls on windows?

Does the vtm terminal translate color escape sequences (\e[48;2;0;0;0m-like) to windows api calls on windows automatically?

Yes, it is supported by vtm. vtm renders everything (vt sequences, etc) onto its internal canvas, and then prints the final canvas using the Windows Console API.

Then I'l go and add color support later. I am currently working on other stuff.


Sweep: Remove sweep.yaml in github workflows folder

Remove the extraneous sweep.yaml.located in the .github workflows folder. Modify the workflows folder's README to accurately reflect that the correct sweep.yaml is in the root of the repository now.

The sweep.yaml.in .github still exists, and the README in .github/workflows is still not correct.

The sweep.yaml within the ~/.github/ directory is still there. Delete it.


Message signing discretely malforms provided message

Signing message with: https://github.com/Hashpack/hashconnect#sign
What it says it does is it takes dataToSign and signs it.
What it actuall do is (AFAIK) it first JSON.stringify the dataToSign and then signs it.
Extra characters are added discretely to the message (which changes the signature):
const msg = 'Hello World!'; // => Hello World!
const jmsg = JSON.stringify(msg); // => "Hello World!"

The end result is the returned signature cannot be verified (or to be precise: cannot be verified unless you know about JSON.stringify).
It may not be a problem for JS/Node, but it is a problem if you sign a message on fronted with JS and try to verify it on backend (tested with hashgraph/hedera-sdk-go/v2 and crypto/ed25519).
I see two solutions to this problem:

Keep the behavior but document it (with examples of JSON.stringified values for backend devs)
Get rid of the behavior. Remove JSON.stringify and replace string | object with Uint8Array | string where the string is expected to be hex encoded byte array: https://github.com/Hashpack/hashconnect/blob/main/lib/src/message/relayMessage.ts#L115

Had a conversation with Pluto on Discord.
try to sign a message which is 'Hello World!', but apparently, the library is JSON.stringifying it, which changes 'Hello World!' into '"Hello World!"' - it adds these double quotes.
We have a work around but just wanted to make sure you were going to use this as it stands?