  Not just during initial sync.**  ALL the time.**
I've installed CLI_tools on 3 different windows machines and they all exhibit the same behavior eventually.  Sometimes it takes about a day, but it eventually stalls out, sometimes for only 20 seconds, sometimes for 12 hours or more.  It catches up and then stalls out again.  Over and over.
I've tried removing all firewalls, syncing time through built in windows time sync as well as 3rd party programs, replaying, resyncing.  Nothing seems to help.

1711185ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089831 time: 2016-03-04T21:28:18 latency: 13150 ms from: wackou  irrevers
ible: 4089813 (-18)
1711186ms th_a       fork_database.cpp:66          push_block           ] Pushin
g block to fork database that failed to link: 003e67e784481c536dcc55d7c2588bdd7b
7a77f2, 4089831
1711187ms th_a       fork_database.cpp:67          push_block           ] Head:
4089829, 003e67e56e3598e8bd6d05d68bcd2dc95e45ac20
1711187ms th_a       application.cpp:545           handle_block         ] Error
when pushing block:
3080000 unlinkable_block_exception: unlinkable block
block does not link to known chain
{}
th_a  fork_database.cpp:87 graphene::chain::fork_database::_push_block
{"new_block":{"previous":"003e67e6ad51ad3cc86155dfd0bec5b08d37502e","timesta

mp":"2016-03-04T21:28:18","witness":"1.6.18","transaction_merkle_root":"00000000
00000000000000000000000000000000","extensions":[],"witness_signature":"1f3015693
bec805491be12a926a174732491470d53e22d755879843314ba1bc3a354e8135346083794d10e9e1
08591e7aed791f2093001d207d07afcca0c00f6a8","transactions":[]}}
th_a  db_block.cpp:205 graphene::chain::database::_push_block
1714987ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089836 time: 2016-03-04T21:28:33 latency: 1952 ms from: mindphlux.witness
irreversible: 4089819 (-17)
1715285ms th_a       application.cpp:566           handle_transaction   ] Got 1
transactions from network
1731480ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089837 time: 2016-03-04T21:28:36 latency: 15445 ms from: in.abit  irrever
sible: 4089820 (-17)
1732611ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089839 time: 2016-03-04T21:28:42 latency: 10576 ms from: bue  irreversibl
e: 4089821 (-18)
1732612ms th_a       fork_database.cpp:66          push_block           ] Pushin
g block to fork database that failed to link: 003e67ef1054769ceffaf170a583444743
19e9fc, 4089839
1732612ms th_a       fork_database.cpp:67          push_block           ] Head:
4089837, 003e67edd8614d4ceaa10837f050c09ee2a1dcff
1732613ms th_a       application.cpp:545           handle_block         ] Error
when pushing block:
3080000 unlinkable_block_exception: unlinkable block
block does not link to known chain
{}
th_a  fork_database.cpp:87 graphene::chain::fork_database::_push_block
{"new_block":{"previous":"003e67eea3000c9ee1b9cd18768be84ea8412102","timesta

mp":"2016-03-04T21:28:42","witness":"1.6.25","transaction_merkle_root":"00000000
00000000000000000000000000000000","extensions":[],"witness_signature":"202549d2e
79c81042a58e41b229d1ed0b13807792c45474fb8e6f251e82ab8d85e44c161f5e085cdc110fdd8a
6c296db25283cbbeacbd7e8ffa4df63c717cefd30","transactions":[]}}
th_a  db_block.cpp:205 graphene::chain::database::_push_block
1735609ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089843 time: 2016-03-04T21:28:54 latency: 1574 ms from: bitcube  irrevers
ible: 4089823 (-20)
1752537ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089844 time: 2016-03-04T21:28:57 latency: 15502 ms from: delegate-clayop
irreversible: 4089824 (-20)
1753318ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089845 time: 2016-03-04T21:29:00 latency: 13283 ms from: bhuz  irreversib
le: 4089824 (-21)
1753614ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089846 time: 2016-03-04T21:29:03 latency: 10579 ms from: roadscape  irrev
ersible: 4089824 (-22)
1753910ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089847 time: 2016-03-04T21:29:06 latency: 7875 ms from: wackou  irreversi
ble: 4089824 (-23)
1754207ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089848 time: 2016-03-04T21:29:09 latency: 5172 ms from: in.abit  irrevers
ible: 4089824 (-24)
1754504ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089849 time: 2016-03-04T21:29:12 latency: 2469 ms from: delegate.baozi  i
rreversible: 4089824 (-25)
1755924ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089850 time: 2016-03-04T21:29:15 latency: 889 ms from: fox  irreversible:
4089824 (-26)
1774637ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089853 time: 2016-03-04T21:29:24 latency: 10602 ms from: cyrano  irrevers
ible: 4089827 (-26)
1774638ms th_a       fork_database.cpp:66          push_block           ] Pushin
g block to fork database that failed to link: 003e67fd3eadc2c186c7336812a934a1b0
6b6890, 4089853
1774638ms th_a       fork_database.cpp:67          push_block           ] Head:
4089850, 003e67fa6dc80e87309ffa898e863284db277309
1774639ms th_a       application.cpp:545           handle_block         ] Error
when pushing block:
3080000 unlinkable_block_exception: unlinkable block
block does not link to known chain
{}
th_a  fork_database.cpp:87 graphene::chain::fork_database::_push_block
{"new_block":{"previous":"003e67fc191955265ffde9dd1b7774391e25f39e","timesta

mp":"2016-03-04T21:29:24","witness":"1.6.21","transaction_merkle_root":"00000000
00000000000000000000000000000000","extensions":[],"witness_signature":"201676c85
58855c995f56c6ff05d6f6cb8077a07d71825439b0000c9740158e44d01244190a17c53b9daa1c7a
cd8da0c31643caed8c3f307bfa8a2889078734d58","transactions":[]}}
th_a  db_block.cpp:205 graphene::chain::database::_push_block
1777715ms th_a       application.cpp:517           handle_block         ] Got bl
ock: #4089857 time: 2016-03-04T21:29:36 latency: 1679 ms from: verbaltech2  irre
versible: 4089840 (-17)
2586798ms ntp        ntp.cpp:177                   read_loop            ] ntp_de
lta_time updated to -25659 us
2598932ms ntp        ntp.cpp:177                   read_loop            ] ntp_de
lta_time updated to -6474 us

What build are you using?
On Fri, Mar 4, 2016 at 3:06 PM -0800, "Xeldal" <notifications<EMAIL_ADDRESS>wrote:
Windows 7x64
x64_cli_tools.exe
I get unlinkable blocks all the time, everyday, all day long. Not just during initial sync.** ALL the time.**
I've installed CLI_tools on 3 different windows machines and they all exhibit the same behavior eventually. Sometimes it takes about a day, but it eventually stalls out, sometimes for only 20 seconds, sometimes for 12 hours or more. It catches up and then stalls out again. Over and over.
I've tried removing all firewalls, syncing time through built in windows time sync as well as 3rd party programs, replaying, resyncing. Nothing seems to help.
1711185ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089831 time: 2016-03-04T21:28:18 latency: 13150 ms from: wackou irrevers
ible: 4089813 (-18)
1711186ms th_a fork_database.cpp:66 push_block ] Pushin
g block to fork database that failed to link: 003e67e784481c536dcc55d7c2588bdd7b
7a77f2, 4089831
1711187ms th_a fork_database.cpp:67 push_block ] Head:
4089829, 003e67e56e3598e8bd6d05d68bcd2dc95e45ac20
1711187ms th_a application.cpp:545 handle_block ] Error
when pushing block:
3080000 unlinkable_block_exception: unlinkable block
block does not link to known chain
{}
th_a fork_database.cpp:87 graphene::chain::fork_database::_push_block
{"new_block":{"previous":"003e67e6ad51ad3cc86155dfd0bec5b08d37502e","timesta
mp":"2016-03-04T21:28:18","witness":"1.6.18","transaction_merkle_root":"00000000
00000000000000000000000000000000","extensions":[],"witness_signature":"1f3015693
bec805491be12a926a174732491470d53e22d755879843314ba1bc3a354e8135346083794d10e9e1
08591e7aed791f2093001d207d07afcca0c00f6a8","transactions":[]}}
th_a db_block.cpp:205 graphene::chain::database::_push_block
1714987ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089836 time: 2016-03-04T21:28:33 latency: 1952 ms from: mindphlux.witness
irreversible: 4089819 (-17)
1715285ms th_a application.cpp:566 handle_transaction ] Got 1
transactions from network
1731480ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089837 time: 2016-03-04T21:28:36 latency: 15445 ms from: in.abit irrever
sible: 4089820 (-17)
1732611ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089839 time: 2016-03-04T21:28:42 latency: 10576 ms from: bue irreversibl
e: 4089821 (-18)
1732612ms th_a fork_database.cpp:66 push_block ] Pushin
g block to fork database that failed to link: 003e67ef1054769ceffaf170a583444743
19e9fc, 4089839
1732612ms th_a fork_database.cpp:67 push_block ] Head:
4089837, 003e67edd8614d4ceaa10837f050c09ee2a1dcff
1732613ms th_a application.cpp:545 handle_block ] Error
when pushing block:
3080000 unlinkable_block_exception: unlinkable block
block does not link to known chain
{}
th_a fork_database.cpp:87 graphene::chain::fork_database::_push_block
{"new_block":{"previous":"003e67eea3000c9ee1b9cd18768be84ea8412102","timesta
mp":"2016-03-04T21:28:42","witness":"1.6.25","transaction_merkle_root":"00000000
00000000000000000000000000000000","extensions":[],"witness_signature":"202549d2e
79c81042a58e41b229d1ed0b13807792c45474fb8e6f251e82ab8d85e44c161f5e085cdc110fdd8a
6c296db25283cbbeacbd7e8ffa4df63c717cefd30","transactions":[]}}
th_a db_block.cpp:205 graphene::chain::database::_push_block
1735609ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089843 time: 2016-03-04T21:28:54 latency: 1574 ms from: bitcube irrevers
ible: 4089823 (-20)
1752537ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089844 time: 2016-03-04T21:28:57 latency: 15502 ms from: delegate-clayop
irreversible: 4089824 (-20)
1753318ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089845 time: 2016-03-04T21:29:00 latency: 13283 ms from: bhuz irreversib
le: 4089824 (-21)
1753614ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089846 time: 2016-03-04T21:29:03 latency: 10579 ms from: roadscape irrev
ersible: 4089824 (-22)
1753910ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089847 time: 2016-03-04T21:29:06 latency: 7875 ms from: wackou irreversi
ble: 4089824 (-23)
1754207ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089848 time: 2016-03-04T21:29:09 latency: 5172 ms from: in.abit irrevers
ible: 4089824 (-24)
1754504ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089849 time: 2016-03-04T21:29:12 latency: 2469 ms from: delegate.baozi i
rreversible: 4089824 (-25)
1755924ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089850 time: 2016-03-04T21:29:15 latency: 889 ms from: fox irreversible:
4089824 (-26)
1774637ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089853 time: 2016-03-04T21:29:24 latency: 10602 ms from: cyrano irrevers
ible: 4089827 (-26)
1774638ms th_a fork_database.cpp:66 push_block ] Pushin
g block to fork database that failed to link: 003e67fd3eadc2c186c7336812a934a1b0
6b6890, 4089853
1774638ms th_a fork_database.cpp:67 push_block ] Head:
4089850, 003e67fa6dc80e87309ffa898e863284db277309
1774639ms th_a application.cpp:545 handle_block ] Error
when pushing block:
3080000 unlinkable_block_exception: unlinkable block
block does not link to known chain
{}
th_a fork_database.cpp:87 graphene::chain::fork_database::_push_block
{"new_block":{"previous":"003e67fc191955265ffde9dd1b7774391e25f39e","timesta
mp":"2016-03-04T21:29:24","witness":"1.6.21","transaction_merkle_root":"00000000
00000000000000000000000000000000","extensions":[],"witness_signature":"201676c85
58855c995f56c6ff05d6f6cb8077a07d71825439b0000c9740158e44d01244190a17c53b9daa1c7a
cd8da0c31643caed8c3f307bfa8a2889078734d58","transactions":[]}}
th_a db_block.cpp:205 graphene::chain::database::_push_block
1777715ms th_a application.cpp:517 handle_block ] Got bl
ock: #4089857 time: 2016-03-04T21:29:36 latency: 1679 ms from: verbaltech2 irre
versible: 4089840 (-17)
2586798ms ntp ntp.cpp:177 read_loop ] ntp_de
lta_time updated to -25659 us
2598932ms ntp ntp.cpp:177 read_loop ] ntp_de
lta_time updated to -6474 us

Reply to this email directly or view it on GitHubhttps://github.com/cryptonomex/graphene/issues/431#issuecomment-192513962.

Using latest.  BitShares-2.0.160223-x64-cli-tools.exe
Its been an issue going on for as long as I can remember, at least 4 months, on every release.
I should note:  I don't have every windows update installed.  So I guess its possible there is something there I'm missing.

Did you delete everything except for your wallet data, update the witness node software to latest and make sure that it has full access permissions on the data folder?

I assume installing and launching on a new machine satisfies deleting everything.  I've done that.
I launch the node with "Run as Administrator" so i assume this satisfies access permissions.
I will try deleting everything but the wallet data. Is there some other way to provide full access permission?

What block height do you reach? because this actually is just a crappy message that should not show when properly synced to latest head. (Please See: https://github.com/cryptonomex/graphene/blob/master/libraries/app/application.cpp line 481)

At the moment I'm stuck at 4092239.  Which is only about 20 minutes old.
It catches up eventually and then stalls out again.  sometimes for only 20 seconds.  Sometimes 20 hours.

Sounds like you may be seeing conflicting chains, I would set it to only connect to 1 trusted node and see if you can get right.

How is this done?  I've got a seed node set on execution, but I'm guessing this is not the same as what you're suggesting.  I don't see anything in config.ini either about number of connections or setting a specific trusted connection.   Thanks for you help here.  I appreciate it.

In your data directory there is a file called config.ini set the seed-node to ...(looking in the code for the main seed may take a minute)

ok here we go https://github.com/bitshares/bitshares-2/pull/5/files

hmm, I'm getting the same errors after specifying a seed node.  Maybe I need a -replay also.
I've set up my laptop now and downloaded\installed all the available windows updates and so far it seems to be running smooth.   I'll let it go for awhile and see but It's looking like I'll just need to bite the bullet and grab some windows updates.  The horror, the horror. : (

yes you need do delete everything and resync from 0

At the moment I'm stuck at 4092239. Which is only about 20 minutes old.

If your node is behind current head and receives the next head block it will complain about that being unlinkable. So the real issue here is that your node keeps falling behind. That can have different reasons, like network problems or your machine being overloaded. How many peer connections do you have?

I'm running with Win7x64 without problem.
Another possible reason is Windows time sync. But if @Xeldal was randomly losing sync, it would not be the case.
Check memory usage of your machine. Current windows build of witness_node need about 1.5G of RAM to run with current block height smoothly. So if the system need 1G, it's better if you have at least 3G of RAM.
Check the console for "Got block ..... latency: xxx ms" messages, check the range of latency, it may tell us something. Best if you can redirect your console logs to a file so we can probably find more from it.

How do I check the number of peer connections?  0.x had this under 'info' but I can't find it in 2.0.
How do I redirect console to file?  (sry, I'm not experienced with this)
I've tried various combinations like:
C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe "C:\Program Files\BitShares 2\bin\witness_node.exe" --rpc-endpoint <IP_ADDRESS>:9094 -s <IP_ADDRESS>:1777 | tee c:\witlog.txt
and
"C:\Program Files\BitShares 2\bin\witness_node.exe" --rpc-endpoint <IP_ADDRESS>:9094 -s <IP_ADDRESS>:1777 > c:\witlog.txt"
I can output the wallet console to file using above, but i guess because the witness needs admin privileges Im not able to get it.
My machine has 16GB memory, of which 12 GB are normally in use with everything running.  On another machine that is more or less identical has 8GB using 3.  These two machines are the ones that have the issues, They both don't install windows updates, they have windows firewall off, they connect through VPN, and they've both had various performance optimizers that surely have changed all kinds of registry settings and other things (AVG PCTuneUp2014).  I don't know if those are relevant, just listing things that are different from my laptop which seems to have no issues at all.
The latency:xxx numbers usually go something like this
15123ms
12435ms
8000ms
6000ms
950ms
750ms
250ms
and then it freezes for some time and repeats.
It's so weird, I haven't changed anything and now it is running smoothly.  It does this from time to time but it never lasts.

How do I check the number of peer connections? 0.x had this under 'info' but I can't find it in 2.0.

There is a command in cli_wallet network_get_connected_peers. To be able to use this command, you need to access network_node_api, please check this document: http://docs.bitshares.org/api/access.html for how to set it up.
So it's latency issue. Maybe due to the VPN? What's it?

This issue was moved to bitshares/bitshares-core#121


add lambda support

Add some helper tasks to deploy to lambda. Also tweaked the handler to properly work with lambda.
Verified this is working on my personal AWS account. @luqmaan, all that's needed is to set it up in Open Austin's AWS account.

Looks great, thanks for doing this!
I forgot to ask this earlier, but does this code make sure to remove any personally identifying information.
For example:

BOOKING NUMBER
NAME
CASE NUMBER

It does not. I was waiting for a decision to be made on the privacy topic before putting in work to scrub it. But I see now the @mateoclarke made a decision on that in open-austin/project-ideas#73 that I didn't see earlier. So one more PR for scrubbing when I get time this week. And then we deploy this puppy.


Benchmark normalized code

Report EO tests execution time before/after normalization

@deemp is it still not implemented?

I'm not sure this is needed. At least not for the current tests. Benchmarks will be relevant for specific rule sets in the future, for larger pipelines. I don't think this is a proper part of the Normalizer itself.


appdaemon: relax dependencies

Motivation for this change
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@freezeboy Would you mind using patches instead? That's a better idea if there's a lot to patch cause then patching fails if something changes upstream.

Ok I moved the big list to a patch file

Why don't why just replace all occurrence of == with >=?

Why don't why just replace all occurrence of == with >=?

Conflict resolved

Conflict resolved

@ofborg eval

It builds fine right now.


add @MainActor to SyncMonitor

fix Class property 'shared' is not concurrency-safe because non-'Sendable' type 'SyncMonitor' may have shared mutable state error in xcode 16 beta 3 and swift 6.

Thanks @longvudai !

-> #29


Swift - UITableView freezes when overriding viewDidLayoutSubviews

Hello,
I wanted to have my Table view extend to the top of the screen, right under the navigation bar, so I overrode viewDidLayoutSubviews with the following code
override func viewDidLayoutSubviews() {
    var offset:CGFloat? = self.navigationController?.navigationBar.frame.origin.y
    self.tableView.contentInset = UIEdgeInsets(
        top: 0,
        left: 0,
        bottom: 0,
        right: 0)
}

But when I click on a table cell that has a UITextField in it and causes the keyboard to appear, the app crashes all the time.
If I remove the above func, everything works fine. Is this a bug?

I'm pretty sure this isn't a TPKeyboardAvoiding problem


change box image to support vagrant higher version

change box image can solve this problem #4  and  the "hostnamectl not found" problem.

i use vagrant 1.7.3 and virtualbox 4.3.3, "vagrant up" printed "hostnamectl command not found". so i changed virtualbox image to debian/wheezy64 and ubuntu/precise64,  other errors including #4 occured. Changing to ubuntu/trusty64 finally worked!

Thanks!


UI slows down or locks up during transfer of large amount of files

Describe the bug
Application and interface slows down immensely when adding a lot of files to receive.
I thought first that it was perhaps HTTPS that slowed down my 8100 file transfer (around 6.6GB) but on the receiving end the UI almost completely locks up, constantly eating 100% of one core and transfer speeds slow to a crawl.
I've tested with both 4000 and 8100 files and 4000 is starting to slow down but is considerably faster, 8000 is actually unusable.
To reproduce
Just load up 8100 files to send and start.
Expected behavior
The UI to not lock up or render at 1 FPS.
Screenshots
No response
Desktop (please complete the following information)
Both machines run Arch Linux.
Smartphone (please complete the following information)
No response
Additional context
No response

Sounds like a hardware issue what computers do you have? Did you consider disabling encruption?

I tried both encrypted and non encrypted. The machine in question is a Mac Pro 2013 model with 12 cores, 64GB RAM and dual FirePro D700.


Use cargo-release and bump minor versions

I'm getting set up with cargo release to help address #8. We don't really need a tool for managing all this yet, since this commit is literally just cargo release version minor --execute. We may want to exclude the test crates from this process, but I don't see much harm in bumping those at the same time.

Good idea, thanks @ahl. After ignoring all the internal crates, here's what cargo release will do:
bnaecker@shale : ~/usdt $ cargo release version minor
   Upgrading dof from 0.3.0 to 0.4.0
    Updating usdt's dependency from =0.3.0 to =0.4.0
    Updating usdt-impl's dependency from =0.3.0 to =0.4.0
    Updating usdt-impl's dependency from =0.3.0 to =0.4.0
   Upgrading dtrace-parser from 0.2.0 to 0.3.0
    Updating usdt's dependency from =0.2.0 to =0.3.0
    Updating usdt-attr-macro's dependency from =0.2.0 to =0.3.0
    Updating usdt-impl's dependency from =0.2.0 to =0.3.0
    Updating usdt-macro's dependency from =0.2.0 to =0.3.0
   Upgrading usdt-impl from 0.5.0 to 0.6.0
    Updating usdt's dependency from =0.5.0 to =0.6.0
    Updating usdt-attr-macro's dependency from =0.5.0 to =0.6.0
    Updating usdt-macro's dependency from =0.5.0 to =0.6.0
   Upgrading usdt-attr-macro from 0.5.0 to 0.6.0
    Updating usdt's dependency from =0.5.0 to =0.6.0
   Upgrading usdt-macro from 0.5.0 to 0.6.0
    Updating usdt's dependency from =0.5.0 to =0.6.0
   Upgrading usdt from 0.5.0 to 0.6.0
warning: aborting release due to dry run; re-run with `--execute`

That's what I really want, and still no need for a script or tool to run that.


Fix some translations

When submitting a receipt the other day, I realized translation was wrong and so I fixed a few translations in the meantime.

Fixed Issues

$ None
PROPOSAL:
Tests

Switch the app to Spanish
Create any money request
Open the money request and click on the ... menu
Make sure the last item says "Emininar Solicitud" instead of "Eliminar Pedido"

While app is in Spanish

Open your profile and click on Wallet.

Enable the wallet and get to the final steps in which the terms for the wallet are shown. Numbers should be formatted as follow:

Switch the app to English and reopen the page that shows the wallet terms, make sure the numbers also make sense and are formatted like these ones:

[x] Verify that no errors appear in the JS console

Offline tests
Same as Tests
QA Steps
Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@iwiznia Updated! SInce you wanted me to refactor the amounts, it became a much larger PR 😄

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.32-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@pecanoro Could you please assist us in accessing the Terms and Services Page? After completing the Onfido flow, the user is unable to navigate to the Terms and Services Page.
https://github.com/Expensify/App/assets/93399543/396fbd66-7016-4e6c-a31d-f8b0eed74eda

@pecanoro Could you please assist us in accessing the Terms and Services Page? After completing the Onfido flow, the user is unable to navigate to the Terms and Services Page.

Hmmm, it does show after completing Onfido but I think it didn't show because it got flagged for review. It says to check in a few minutes, so is that still what it is showing?

@pecanoro  Yes, it shows the message "Unfortunately your wallet cannot be enabled at this time." Can you verify this PR internally?

@kbecciv Ahh got it, you can just check it off from the list and I will test it tomorrow. It's mostly copy changes so it should be fine.

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.32-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Instructions for CentOS should use ~/bin

The instructions on https://www.microsoft.com/net/core#centos say:
curl -sSL https://raw.githubusercontent.com/dotnet/cli/rel/1.0.0-preview1/scripts/obtain/dotnet-install.sh | bash /dev/stdin --version 1.0.0-preview1-002702 --install-dir ~/dotnet
sudo ln -s ~/dotnet/dotnet /usr/local/bin

In My Humble Opinion, I don't think it's wise to link a global /usr/local/bin to point to an executable in a user's home directory. This can cause problems on a multi-user system.
I think the instructions should be:
curl -sSL https://raw.githubusercontent.com/dotnet/cli/rel/1.0.0-preview1/scripts/obtain/dotnet-install.sh | bash /dev/stdin --version 1.0.0-preview1-002702 --install-dir ~/dotnet
mkdir -p ~/bin
sudo ln -s ~/dotnet/dotnet ~/bin

@m-ghaoui we have changed the instructions for CentOS to now install in /opt and symlink info /usr/local/bin. Does that work?

Looks good to me!


speech recognition auto processor

What does this PR do?
This PR replaces the static wav2vec2 processor with the autoprocessor class.
Furthermore it's now possible to train pretrained only model without pretrained processor by defining the processor seperately.

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[ ] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

I am not sure what to do with the failing macos test, any advice ?

@flozi00 Just a flaky test, no need to worry about it. Will merge your PR now :smiley:


TypeError: expected str, bytes or os.PathLike object, not NoneType

I tried to install dm_control by pip install git+git://github.com/deepmind/dm_control.git.
However, I can import dm_control successfully, but when I used 'from dm_control import suite', error came.
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\suite_init_.py", line 28, in
from dm_control.suite import acrobot
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\suite\acrobot.py", line 26, in
from dm_control import mujoco
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco_init_.py", line 18, in
from dm_control.mujoco.engine import action_spec
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco\engine.py", line 43, in
from dm_control.mujoco import index
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco\index.py", line 94, in
from dm_control.mujoco.wrapper import util
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco\wrapper_init_.py", line 23, in
from dm_control.mujoco.wrapper import mjbindings
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco\wrapper\mjbindings_init_.py", line 28, in
from dm_control.mujoco.wrapper.mjbindings import wrappers
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco\wrapper\mjbindings\wrappers.py", line 14, in
from dm_control.mujoco.wrapper import util
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco\wrapper\util.py", line 57, in
"~/.mujoco/mjpro150/bin", _get_shared_library_filename())
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\site-packages\dm_control\mujoco\wrapper\util.py", line 47, in _get_shared_library_filename
libc_filename = os.path.split(libc_path)[1]
File "C:\Users\bzdli\Anaconda3\envs\drl\lib\ntpath.py", line 204, in split
p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not NoneType
I's using windows 10 and python 3.6.  Can someone figure this out?

I have also faced this issue... Has anyone found a solution yet?  Many thanks!

Ok, I have noticed there is a fix in pull request 'Load shared library properly on windows.'

Has anyone managed to fix this?

@bzdlity @fcampos Do you have any solution to fix the problem?
I also use Win10 and python 3.6.

I believe this was fixed in ebc6442646c711ec5b908b6fc32befaea48da7fb - please comment if the error still occurs.


fix(webpack): use webpack HMR for node build to fix memory leak

This was implemented previously already but got lost during the
implementation of another feature which was intended to reduce memory
consumption.
We are using webpack hot module reload for the server bundle, to be able
to update a running server with incremental changes.
In order to use the HMR on the server side, we need to send a signal to
the process which tells webpack to reloaad the module.
This is the part that got lost and instead we re-required the server
bundle every time a watch event happened on the webpack compiler.
In the current implementation we require the server bundle just once and
let webpack HMR handle all other updates.

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

bors merge


fix: SetProgress and SetTime

Sequence.Goto function was receiving normalized progress instead of time in seconds

Thanks for the contribution!


Fix(franka_example_controllers): Fix dynamic reconfigure node name for cartesian_impedance_example_con…

Add a missing / to the node name so that the node name is:
/cartesian_impedance_example_controller/dynamic_reconfigure_compliance_param_node/
instead of:
/cartesian_impedance_example_controllerdynamic_reconfigure_compliance_param_node/

HI @Olimoyo
thanks for the fix, absolutely makes sense. I added a changelog entry. As soon as the CI is through, we can merge this


Determine actual date of data

When retrieving the data from Santé Montreal, it is assumed that the state of the data is from yesterday. However, it occasionally happens that the data is not updated. This happened last this week on Nov 25th. Also on the weekend the data is not updated (on Monday the data from Sunday is shown so Fri and Sat are usually missing).
To automate scraping and processing, we need to make sure that this is detected.
I see two ways:

don't append data if the exact same data exists for the previous day(s)
extract the date from the HTML page (the minibox on top of the page is often updated earlier than the data in the tables)

I can write the selector for extracting the date if you give me the url of the page where it can be found.

Thanks!
For Santé Montreal: https://santemontreal.qc.ca/en/public/coronavirus-covid-19/situation-of-the-coronavirus-covid-19-in-montreal/
Under the first table is a line:

Source : Fichier Trajectoire de santé publique (TSP), extracted on 26 November, 5:31 PM

There is also one further at the top ("Data as of November 27, 2020, at 12 p.m.") but I think that applies only to the numbers just below.
For INSPQ: The actual date is not on the page directly (https://www.inspq.qc.ca/covid-19/donnees) but shows up after. My guess is that it is taken from https://www.inspq.qc.ca/sites/default/files/covid/donnees/manual-data.csv and then inserted using JS.

For INSPQ, indeed, there is some magic JS going on to update the date element.  It happens shortly after the page loads both
https://www.inspq.qc.ca/sites/default/files/covid/donnees/manual-data.csv
and
https://www.inspq.qc.ca/sites/default/files/covid/donnees/covid19-hist.csv
(passing randNum=26782617 as a get param, but I don't think you actually need it).  As of right now, the date shown on the page is the last data cell in the CSVs (yesterday), NOT the Last-Modified HTTP header (today), so fetching the CSV directly is the right way to go.
Santé Montréal seems to be down right now.  I will write the selector once they come back up.

Thanks for looking into this. I think manual_data.csv is used for the info boxes at the top. On Nov 26th (so expecting to see data from the 25th) they had this note on top of their page: "En date du 26 novembre, seules les données des tuiles de la page principale ont été mises à jour. Le reste des données sera mis à jour dès que possible."
In manual, there was the 25th, in covid19-hist, there the last date was the 24th.
For Santé Montréal it is similar I think (except no machine-readable data). They have their info boxes on top which seem to be updated at noon, whereas the detailed data is updated later in the day.

Santé Montréal is still not working for me.  I keep getting timeouts, even after trying from a few different IPs.  Maybe they block non-Canadian IPs?  If it's still up for you, please attach the HTML and I will give you selector.

Yes, they seem to be doing that for some reason. I notified them this week, not sure if it will be fixed though.
You can find the scraped HTML page here:
https://github.com/jeremymoreau/covid19mtl/blob/add-data/app/data/sources/2020-11-25/data_mtl.html

The data on that page is not very well tagged, but we already new that.  Assuming that the date stays in bold and that your refresher is only concerned about the first stated date, you can do like this:
date_elems = [el for el in soup.select('div.csc-textpic-text p.bodytext b')
            if el.text.startswith('Data as of')]
el = date_elems[0]
label = el.text.replace('Data as of', '')
label = label[:label.index(', at')]
refresh_date = dateutil.parser.parse(label)

You will need to add dateutil to requirements.in.  I have not kept up to speed with all the changes to refreshdata.py, so I will let you put the date extraction in there since you probably know better then me where it should go.

Thanks @ygingras! I managed to adjust it slightly to get the date from the text under the table (extracted on ...).

I think the refresh part needs to be split into MTL and QC specific parts to fully support just downloading and updating either data. Alternatively, the data could be downloaded regardless and only the updating part be adjusted if the data date is the expected one.


OCPBUGS-16608: [release-4.13] UPSTREAM: 284: Bump golang.org/x/net

This is only a part of upstream PR 284, the PR updated all k8s.io deps to a release candidate.
Updating only golang.org/x/net for CVE-2022-41723
@openshift/storage

/label backport-risk-assessed

/label cherry-pick-approved

The golang.org/x/net version is 0.7.0. The CI result looks good.

/label qe-approved

/jira refresh

/lgtm


Resolves #3829 Improve codespaces debugging

Fix #3829
Description

Adds desktop environment to codespaces so tests can be viewed in browser
Fix setup issues with nvm and rbenv
Rewrite dockerfile to use apt-get and noninteractive
Adds debug gem to gemfile to allow attaching to live server using Shopify
Adds additional documentation on debugging using VSCode Shopify extension

Motivation
I think it's safe to close #3829 with these fixes because I've been doing all my development in codespaces with this setup recently and it's working great.

bin/start didn't work out of the box due to failed javascript runtime and rbenv, fixed to install node and rbenv init (I don't know when this stopped working because it did work before)
Much easier to write tests when you can view them running in browser
apt-get and noninteractive are best practice for dockerfiles
I like using Shopify's debugger because I find setting breakpoints much easier with a GUI

Dependencies
gem "debug", ">= 1.0.0"

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update
Documentation update

How Has This Been Tested?

Full rebuild of codespace, bin/start works out of the box
NOT_HEADLESS=true bundle exec rspec spec/system/partner_system_spec.rb running in Codespaces is visible over noVNC on localhost:6080
Ran Shopify Ruby LSP debugger and attached to the server as per documentation in VSCode and in Codespaces.

Screenshots

@awwaiid probably the best way to speed it up is with [codespace prebuilds] (https://docs.github.com/en/codespaces/prebuilding-your-codespaces/configuring-prebuilds#configuring-prebuilds), which takes up billable storage in the organization repo, and moving the post-create.sh to onUpdateContent so the prebuild builds it. I can open an issue for that if you want, not sure if that's something you have the storage for.


Push to docs-itb pages if pr branch starts with migrate. or itb.

Talking to BrianL -- this one isn't ready to review yet, has a few more TODOs before it's ready to go in.

@brianhlin - this one is getting stale.  What's the latest thinking here?

This had to be put on hold for November release dev work. I should be able to complete this after the dust settles for the the dev freeze today.

Ok, this is ready for a re-review.

Build from the PR only runs the verification (mkdocs build and linkchecker
Build from a branch beginning with itb.* runs both the verification and deployment to the itb

A few things:

All branches run mkdocs build and linkchecker before deployment, meaning that transient link failures can prevent deployment (I can change this)
ITB documentation is titled differently (see top left) but I haven't thought about how to add a warning header/change the readthedocs theme color/whatever to differentiate it from production docs. I also haven't figured out how to modify robots.txt so that it isn't crawled
doc-ci-scripts's README.md needs updated instructions

Yup, Travis performs the submodule checkout. Comments should be addressed now

Branch deployment here
PR verification here


WIP: Fix/25

fix https://github.com/caas-team/caas-project-monitoring/issues/25

LGTM

LGTM2

no feedback from the user. best case not to use the Rancher dashboards anymore.


add player_controller

I want to add a build that can modify the player's movement speed by wearing a certain item or entering a certain area.

Hey @Bicabo98 , I've created a feature request post here for your, feel free to add any detail: https://feedback.decentraland.org/creator-tools-sdk/p/player-physics-modifiers

Hey @Bicabo98 , I've created a feature request post, feel free to add any detail and let's follow up there.
https://feedback.decentraland.org/creator-tools-sdk/p/player-physics-modifiers


fpgad: add unit tests for config_file.c

I don't check the content of the messages explicitly, though I have seen the correct output. I rely on the return codes from the fn under test and the collected coverage data to verify the code paths as I develop the tests.


Java Process Console doesn't scan Cyrillic script.

Does this issue occur when all extensions are disabled?  Yes

VS Code Version:1.60.0
OS Version: Windows 10 Pro 10.0.19043 Build 19043
VSCode Encoding: UTF-8;
Windows Encoding: UTF-8;

Steps to Reproduce:

Copy and paste the following code.
import java.util.Scanner;
class App {
public static void main(String[] args) {
Scanner input = new Scanner(System.in);
String wordCyrillic = input.nextLine();//!Привет
String wordLatin = input.nextLine(); //!hello
System.out.println("we print: " + wordCyrillic);
System.out.println("we print: " + wordLatin);
System.out.println("we print: " + "\u26a1\u2661");
System.out.println("we print: " + "Привет");
}
}
Run this code, inputting commented data(or use a random Cyrillic letter).
You will get such output:

p.s this piece of code does work in IntelliJ idea and eclipse. @Tyriar

This is likely a problem with the conpty backend we use. You can try to reproduce the problem in Windows Terminal and if it happens there as well, report to microsoft/terminal.
/label terminal terminal-conpty windows


Add failing test that round trips a flattened signed amount in an option

Add a failing test that demonstrates a limitation using SignedAmount whose value is None in a flattened struct. I kind of suspect that this is an inherent limitation of serde, but I don't know enough to be sure.
Closing #266, which shows the issue in rust-bitcoincore-rpc-json, in favor of this issue.

Is the link in the PR description correct?

Thanks for the bug report @casey! It looks like the bug is ours, if we replace the Option<SignedAmount> with Option<usize> in Bar the test passes. Also the visit_none method we implement is never called. I'll dig some more.

Is the link in the PR description correct?

Ah, no sorry, I meant https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/266.

I'm of the not-that-knowledgeable-about-serde opion that this may be a bug in serde. Our custom deserializer is called when using flatten and also the visit_none method is called when not using flatten but with flatten the visit_none method is never called.

Oh? I just reached for the first inbuilt type that came to mind. Will try as you say using i64.

Confirming using Option<i64> (also f64) instead of Option<SignedAmount> makes the test pass.


Plugin: nativescript-tracking-transparency - Apple iOS ATT is not working on iOS 15

Apparently, there could be a new API on iOS 15 for getting authorization status:
class func requestTrackingAuthorization() async -> ATTrackingManager.AuthorizationStatus
Please see: https://developer.apple.com/documentation/apptrackingtransparency/attrackingmanager/3547037-requesttrackingauthorization
My implementation of this plugin was previously working and approved by Apple Team on iOS 14. However, Apple Team is rejecting it on iOS 15 terms now.
May I request @NathanWalker @triniwiz to review this plugin again please? Thank you.

@keithoys thank you for the report, we’ll take a look on Monday.

Can you try moving the call to another location e.g login ?

@triniwiz That does the trick! 💯 I moved the call from main.ts to Login page, and indeed solved the issue. Thank you!

@triniwiz Can I understand how you'd figure this was the missing-link and root-cause in iOS 15?

The docs was the first place I checked but I also checked the other xplat repos they ran into the issue a couples before you did 🙂


Season 6 update?

There was no update for some of the midseason 5 stuff. Will all new games be added now that a full season update is out?

1.120 has the season 6 levels


The implementation of your importance sampling for estimating likelihood

Hi, I was wondering which part is the implementation of your importance sampling? I couldn't find it...

Hi, you are right that this seems to be missing from the code, not sure whether I had done it for simplicity back then since the scores didn't differ significantly or whether it was actually missing. In any case, if you want to re-introduce the importance sampling during testing, you can replace the following lines in def eval(...) function in task.py:
batch_size = batch[0].size(0) if isinstance(batch, tuple) else batch.size(0)
batch_nll = self._eval_batch(batch, is_test=is_test)

replace with
batch_size = batch[0].size(0) if isinstance(batch, tuple) else batch.size(0)
if not is_test:
    batch_nll = self._eval_batch(batch, is_test=False)
else:
    all_nll = []
    for _ in range(num_rep):
	    batch_nll, _ = self._eval_batch(batch, is_test=True)
	    all_nll.append(batch_nll)
    batch_nll = torch.logsumexp(torch.stack(all_nll, dim=-1), dim=-1) - np.log(num_rep)
    batch_nll = batch_nll.mean()

Additionally, the task you are interested should not average the batch dimension of the NLL score under is_test.

logsumexp should operate on ll, not nll right?

True, I had in my code that the eval_batch function actually returned log-likelihoods if is_test=True. Sorry for forgetting it here, I'll adjust the code


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit f3f7a29:
:clock10: Full build: the average full build time is 6 min(s) 8 sec(s), this is based on the last 248 build(s) for this repository.
:warning: This is a FULL build due to the 'pr-webhookbackup' branch being a new branch in Docs Build service and is still building, or there are build errors in 'pr-webhookbackup' branch so the cache for incremental build is not available. Normally no action is required on your part, but if the full build persists, please contact your repository admin to manually perform a full build on the 'pr-webhookbackup' branch. For more detailed info, please click here.

Docs Build status updates of commit f3f7a29:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Merge presubmit and postsubmit workflows

Rather than having two separate workflows with tons of duplication (and
indirection and UI nesting of workflow_calls), we can just have a
single workflow and then enable or disable jobs according to the event
(and later, according to things like PR descriptions).

should we restrict this to only iree-org  forks ?  https://github.com/nod-ai/SHARK-Runtime/actions/workflows/ci.yml

Sure, we can. I think typically the fork would just disable actions entirely, but since your fork is a bit special, I understand that isn't ideal

So to prevent this, it looks like we'd need to add an if condition to every job. I don't see a way to put that condition at the workflow level. An alternative is that you can disable the workflow in your settings: https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow

Forgot to tag originally, but part of https://github.com/iree-org/iree/issues/9855


[INLONG-1436][CI] Delete checkstyle workflow

fix: #1436
Modifications

delete checkstyle workflow

Codecov Report

Merging #1437 (7b2112f) into master (6844a92) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #1437      +/-   ##
===========================================
+ Coverage      7.70%   7.72%   +0.02%
  Complexity      565     565
===========================================
  Files           355     355
  Lines         31081   31081
  Branches       4972    4972
===========================================
+ Hits           2394    2401       +7
+ Misses        28196   28190       -6
+ Partials        491     490       -1

Impacted Files
Coverage Δ

.../java/org/apache/flume/sink/tubemq/TubemqSink.java
55.42% <0.00%> (+4.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6844a92...7b2112f. Read the comment docs.


dune-release upgrade of opam files adds unnecessary flags

During the upgrade of opam 1.2 files to opam 2 at release time, the flag flags: light-uninstall is added even if not necessary (see e.g. https://github.com/ocaml/opam-repository/pull/13043 but I have seen it in other packages). I thought at first that this was a bug in opam-state but doing the upgrade with https://gist.github.com/mseri/b0d28a9c56303ac17580da9b494a68ce it did not happen (it may still be due to specific version of opam-state, this I did not check.

I think this depends on the version of opam-state and happens only when opam-upgrade-package is present. I am closing the issue here and will reopen one there


[Enhancement] Support replay catalog hive table plan from query dump

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Support replay catalog hive table plan from query dump
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Windows support with libuv?

Would you be able to support Windows in a future release if you switched to libuv?  It's used by Node.

Hi
Windows will be supported in the future, but I prefer to use libraries compatible with C++ Networking TS, such as boost.asio.
Thank you for your attention.


Update dockerfile for armhf according to recent update for normal dockerfile

apply https://github.com/eris-ltd/eris-db/pull/250 to dockerfile.armhf

At time of writing current Dockerfile is:
FROM quay.io/eris/build
MAINTAINER Monax<EMAIL_ADDRESS>
# Install eris-db, a go app that manages relationships
ENV TARGET eris-db
ENV REPO $GOPATH/src/github.com/eris-ltd/$TARGET

ADD ./glide.yaml $REPO/
ADD ./glide.lock $REPO/
WORKDIR $REPO
RUN glide install

COPY . $REPO/.
RUN cd $REPO/cmd/$TARGET && \
  go build --ldflags '-extldflags "-static"' -o $INSTALL_BASE/$TARGET

# build customizations start here
RUN cd $REPO/client/cmd/eris-client && \
  go build --ldflags '-extldflags "-static"' -o $INSTALL_BASE/eris-client

So linked PR would be out-of-date.
@AFDudley arm tag for eris/build image looks out of date. Will you be able to update? https://quay.io/repository/eris/build?tab=tags
If updated, will the Dockerfiles be otherwise identical to above? I think so.
If it is too onerous/we do not plan to keep arm up-to-date I strongly recommend we drop support for ARM rather than maintain out-of-date support.

related to https://github.com/eris-ltd/eris-cli/issues/1088

@silasdavis go ahead and drop IoT support for the time being. I've added this issue to the IoT epic which will be able to be much clean post 0.16.0

to be dealt with in https://github.com/eris-ltd/eris/issues/1088


Clarify CORS policy result log messages

Fixes https://github.com/aspnet/Home/issues/3419
@natemcmaster

It looks like the tests need to be updated to match.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: cmeeren sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Add the required SHAPE_TYPE, i.e. FEATURE and LAYER to create FC map

In SHA bf3f30b, the FEATURE and LAYER attributes in SHAPE_TYPE are missing.
However, these attributes are required when creating an FC map, for example:
https://github.com/AnatomicMaps/flatmap-maker/blob/4503fb4dd079579bf94de2b9bc58e90e3b1ed945/mapmaker/sources/fc_powerpoint/__init__.py#L157

Closing this PR and replacing it with PR #90


"Cannot Start Application" Error

I have a windows 10 64 bit desktop
When opening the taskbar x configurator manifest I get past the install button but then get prompted of the message displayed bellow. The detail log is also attached.
7P5RS3U0.log

To be able to focus on major/current bugs I had to close all issues. The issues section has gotten very messy to a point that I couldn't follow it anymore. Most issues are duplicates, very old or are already fixed/solved. Feel free to reopen this issue if you still have this issue on the latest version of TaskbarX to get my attention. All feature requests have been put in a list here: 💡| Feature requests #870
I hope you understand ❤


Can't use :block

julia> ex = Expr(:block, :(x=3))
quote
    x = 3
end

julia> eval(ex)   # works fine
3

julia> @RuntimeGeneratedFunction(ex)
ERROR: ArgumentError: Function definition contains invalid function head `:block`
Expr
  head: Symbol block
  args: Array{Any}((1,))
    1: Expr
      head: Symbol =
      args: Array{Any}((2,))
        1: Symbol x
        2: Int64 3

Same issue for let:
julia> ex = :(let a = 2
       function f(x::Int)
           return x + a
       end
       end)
:(let a = 2
      #= REPL[6]:2 =#
      function f(x::Int)
          #= REPL[6]:2 =#
          #= REPL[6]:3 =#
          return x + a
      end
  end)

julia> eval(ex)(2)
4

julia> @RuntimeGeneratedFunction(ex)(2)
ERROR: ArgumentError: Function definition contains invalid function head `:let`
Expr
  head: Symbol let
  args: Array{Any}((2,))
    1: Expr
      head: Symbol =
      args: Array{Any}((2,))
        1: Symbol a
        2: Int64 2
    2: Expr
      head: Symbol block
      args: Array{Any}((2,))
        1: LineNumberNode
          line: Int64 2
          file: Symbol REPL[6]
        2: Expr
          head: Symbol function
          args: Array{Any}((2,))
            1: Expr
              head: Symbol call
              args: Array{Any}((2,))
                1: Symbol f
                2: Expr
            2: Expr
              head: Symbol block
              args: Array{Any}((3,))
                1: LineNumberNode
                2: LineNumberNode
                3: Expr

@c42f is this solvable?

The block example isn't a function. So I'm not sure what it's even meant to do?
The let example defines a closure — it could be supported automatically, but there's a much more straightforward way — define the RGF with an extra parameter a, then use a normal Julia closure to call the RGF:
julia> using RuntimeGeneratedFunctions

julia> RuntimeGeneratedFunctions.init(@__MODULE__)

julia> ex = :(function g(a, x)
           return x + a
       end)
       g = @RuntimeGeneratedFunction(ex)

julia> f = let a = 2
           x -> g(a, x)
       end
#12 (generic function with 1 method)

julia> f(2)
4

Thanks @c42f . The way I'm currently doing things, the entire let closure is generated as a string (by a python package) and then I apply Meta.parse and evaluate. In particular the constants that go into the let block (a bunch of sparse matrices and vectors) are also generated. I can easily generate the string that goes into the let block (e.g. a=2) and the string for the internal function separately, but I'm not sure how to adapt the code to "evaluate" the string that goes into the let block in this case?

I can easily generate the string that goes into the let block (e.g. a=2)

Ok, so presuming you've only got strings coming from python and you can't modify these, you can still extract the variable names as follows:
julia> bindings_str = "a=1, b=2, c=3"
"a=1, b=2, c=3"

julia> binding_names = [a.args[1] for a in Meta.parse("($bindings_str)").args]
3-element Vector{Symbol}:
 :a
 :b
 :c

Then you need to construct the RGF function argument list to include these extra variables as parameters. There is a subtle issue with this scheme when your bindings_str is dynamically generated — you need a fixed wrapping closure to avoid world age issues.
This can be done as follows:
using RuntimeGeneratedFunctions
RuntimeGeneratedFunctions.init(@__MODULE__)

function make_rgf(bindings_str, body_str)
    binding_names = [a.args[1] for a in Meta.parse("($bindings_str)").args]
    main_body = Meta.parse("begin\n$body_str\nend")

    param_tuple = eval(Meta.parse("($bindings_str)"))

    ex = :(function f(params, x)
        ($(binding_names...),) = params
        $main_body
    end)

    @info "Generating RGF" param_tuple ex

    let params=param_tuple
        g = @RuntimeGeneratedFunction(ex)
        (x)->g(params, x)
    end
end

Running this code, we have
julia> bindings_str_from_python = "a=1, b=2, c=3"
"a=1, b=2, c=3"

julia> body_str_from_python = "y = x*x\nreturn y + a + b"
"y = x*x\nreturn y + a + b"

julia> f = make_rgf(bindings_str_from_python, body_str_from_python)
┌ Info: Generating RGF
│   param_tuple = (a = 1, b = 2, c = 3)
│   ex =
│    :(function f(params, x)
│          #= /home/chris/rgf_test.jl:10 =#
│          #= /home/chris/rgf_test.jl:11 =#
│          (a, b, c) = params
│          #= /home/chris/rgf_test.jl:12 =#
│          begin
│              #= none:2 =#
│              y = x * x
│              #= none:3 =#
│              return y + a + b
│          end
└      end)
#21 (generic function with 1 method)

julia> f(2)
7

Thanks! I will try this out


Error when user is clicking on the filter between tabs

Description
Error when user is clicking on the filter between tabs
Steps to Reproduce

Go to All orders tab click on status filter
Click on Closed orders click on status filter
See error

Expected behavior
No error should be visible
Screenshots
https://github.com/vegaprotocol/frontend-monorepo/assets/119658839/981a3fa2-48a8-4b55-b40a-8366485fd695

@daro-maj its possible that this has been resolved after recent ag grid upgrades


Convert to Swift 4

This samples project currently uses Swift 3.2 compiler and should use the newest Swift language and compiler 4.0.

Issue completed in PR https://github.com/Esri/arcgis-runtime-samples-macos/pull/73


Text() widget should have a padding argument

Is it just me, or is this a common occurrence: very often wanting to enclose your Text() with a Padding() ?
It would be convenient and save a nesting level if we could optionally pass a padding arg to Text.

We can easily extend a MyText widget class by customizing a Container class.
Text as a basic unit, itself should be as simple as possible.
In HTML compare this:
Maybe the underlying philosophy is: flutter aims to paint elements in a efficiant way, so the parent widget should provide all information about layout, narrowing the canvas space for descends.

Flutter relies on the "Composition over Inheritance" principle, which this proposal wouldn't align with.
For more information, you might check out [this StackOverflow answer] (https://stackoverflow.com/questions/54193724/is-it-bad-to-have-a-lot-of-nested-widgets-with-flutter/54196721#54196721).

https://github.com/flutter/flutter/issues/32978#issuecomment-493810790 is very accurate.


Font for Multilingual Support

I'm improving Topics's PDF export in Trimble Connect and for that I would need one .ttf font file that supports all 17 languages that Trimble Connect is supporting. Would you know if we have fonts that would fit this usage? Currently we are using Open Sans font, which works on most languages, but not all, for example Korean is not rendered. I have found one font that would fit (Arial Unicode), but its license needs to be sorted and I wanted to check if we have suitable fonts already licensed.
Best regards,
Marko Myllymaa
Modus recommends Noto but multiple families need to be installed to support all the languages. Marko needs one font.

@prashanth-offcl Let's create documentation based on Marko's findings about the option to merge multiple Noto families suites.

Marko used FontForge to combine several font files into one. Here's what he did:
Base Font: He started with Noto Sans Regular as the base.
Merged Fonts: He then merged the following regular versions:

Noto Sans KR
Noto Sans TC
Noto Sans SC


Alert Notifications Not Displayed on Tipping Page in Enatega Multivendor.

Issue: Alert Notifications Not Displayed on Tipping Page in Enatega Multivendor
Description:
There is an issue where alert notifications are not being displayed on the tipping page. This issue hinders the user's ability to receive important alerts or information while on the tipping page.
Impact:
User Awareness: The absence of alert notifications may result in users missing important information or updates related to tipping.
User Experience: A comprehensive user experience includes the timely display of notifications across all relevant pages.
Steps to Reproduce:

Access the tipping page within the application.
Observe the absence of alert notifications or any alerts that should be displayed.

Expected Resolution:
The issue should be addressed to ensure that alert notifications are correctly displayed on the tipping page. This ensures that users receive important information and updates while using this feature, enhancing the overall user experience.

Hello @Sohailqureshi9 ,
I'm pleased to inform you that we've resolved the issue where alert notifications were not displayed on the tipping page in the Enatega Multivendor Admin Dashboard.
Thank you for reporting this issue, and we appreciate your patience. If you encounter any more issues or have additional feedback, please don't hesitate to reach out.
Best regards,
@beKashif
@Ninjas-Code-official/ninjas-code


[Feature] Adds routine_load_unstable_threshold_second

Why I'm doing:
When a routine load job gets sustained failure, the retention of the Kafka partition may expire, which leads to data loss.
What I'm doing:

adding TimeProgress to the result of show routine load.
The TimestampProgress denotes the latest partition timestamp of the consumed message.

adding FE config routine_load_unstable_threshold_second.
When the time latency is more than this config value, the job would be set as UNSTABLE state.
In this state, the routine load job would be scheduled continuously, and the ReasonOfChangeState would be set.

Fixes https://github.com/StarRocks/starrocks/issues/35296
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[x] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)

[x] I have added documentation for my new feature or new function
https://github.com/StarRocks/starrocks/pull/36967

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5

@mergifyio rebase

@mergifyio backport branch-3.2 branch-3.1 branch-3.0 branch-2.5


Incorrectly written BodyExecutionCallback implementations lead to zombie executions

I'm raising this PR as a minimal reproduction of the issue I noticed from a bug in the withChecks step of the checks-api plugin: https://github.com/jenkinsci/checks-api-plugin/pull/83
The withChecks step does not handle all possible exceptions in onStart, onSuccess, and onFailure. If an exception gets thrown by one of these methods, while the job appears to fail correctly, the executor on which the step is running does not, and you end up with a execution that must be killed manually.
Whilst it is obviously the responsibility of the plugin to behave correctly, this failure mode is particularly pernicious.  I have seen three day old zombies on Monday morning from an executor that was unnecessarily up all weekend.
This PR does not (yet) contain a fix as I haven't looked into the plumbing of how this actually works. If someone can quickly identify the quick fix for this then that would be greatly appreciated, otherwise I will put on my spelunking gear.

It's also worth noting that I first saw this issue from an unhandled in onSuccess and onFailure, both of which appear to also suffer from the same issue.

Great, thanks for the pointers - I realised after raising this that this probably wasn't the right place. I'll move it over and have a play.

Finally got round to raising https://github.com/jenkinsci/workflow-cps-plugin/pull/422


specify encoding per PEP0263

Fixes this error message:
$ python app.py
Traceback (most recent call last):
File "app.py", line 2, in
import lib.globalweathernotificationheadlines
File "/lib/globalweathernotificationheadlines.py", line 23
SyntaxError: Non-ASCII character '\xe2' in file /lib/globalweathernotificationheadlines.py on line 24, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

@vabarbosa Can you please review this?

@joewxboy the file globalweathernotificationheadlines.py has since been removed and replaced with weatheralertheadlines.py. do you notice the error when you use try it now? thx


luci-app-mwan3: Duplicate metric warning and other potential false warnings on IPv6 configurations

@feckert @aaronjg
I've kind of ignored most of the warnings from luci-app-mwan3 as in my opinion some of them might be a bit false positive because it doesn't really handle IPv6 interfaces well from what I can see.

I have a couple of questions though.

Is having the same metric value applied to both the WAN and WAN6 interface really invalid? Because one is IPv4 and the other IPv6 surely this is fine, because it's two different routing tables for IPv4 and IPv6? I'm assuming it's perhaps just looking at the interface entry itself and thinks it's duplicated.

Any IPv6 interface seems to throw the Interface xxxx has no default route in the main routing table, again I think this because it's not specifically looking at the IPv6 configuration here.

All interfaces work fine, I have just been ignoring the errors but I've seen other users in the forums get put off by the above errors from LuCI, when I don't think they are that useful because I don't even think from an IPv6 perspective they are properly reporting an issue.
I'm not an expert however, so I wanted to ask for further clarification. Similar points around the diagnostics functionality, for any IPv6 interface most of the diagnostic options don't work. I personally don't use it that much and would always use SSH and test with various tools like traceroute, iperf3, ping etc.
Thank you!

I'm assuming my first point it's because the condition is looking at an IPv4 route of <IP_ADDRESS> present on the interface which won't be valid for an IPv6 interface.
https://github.com/openwrt/luci/blob/master/applications/luci-app-mwan3/luasrc/model/cbi/mwan/interface.lua#L85-L94

And the duplicate metric warning looks to be just looping through interfaces and seeing if the assigned metric value is present, not taking into account the interface being a different family. In fact the interface config itself doesn't appear to actually expose the interface family set in this case.
https://github.com/openwrt/luci/blob/master/applications/luci-app-mwan3/luasrc/model/cbi/mwan/interface.lua#L73-L83

That all sounds correct - the diagnostics appear to be quite off for IPv6, and a P/R fixing this would be welcomed.
It might also be nice to add a diagnostic for IPv6 to make sure that the user has some sort of rewrite rule in place for their IPv6 addresses, since we are currently leaving it up to the user to pick the solution that works best for them, but we might want to flag it if they have not set anything up to do the IPv6 address rewriting.

My experience with LuCI development is limited, but I think the initial step would be to have the defined family option that is set on within an interface config available to the interface model as a first step, that is then going to allow for being able to target IPv4 and IPv6 conditions within the existing metric/default route conditions, as right now they are pretty much written from an IPv4 only perspective.
In addition, the controller outputting the IPv6 counter parts for things like the ip route commands.
https://github.com/openwrt/luci/blob/master/applications/luci-app-mwan3/luasrc/controller/mwan3.lua#L194
For IPv6 the only diagnostic option that works is pinging the tracking IP.

As @aaronjg  has already said and that you @jamesmacwhite have already recognized this correctly.
This is still from the time when we only had ipv4 tracking or could configure this over the LuCI.
Either we do the whole check out or we have to check if we use ipv4 or ipv6 tracking for this interface and depending on this show the warning on miss configuration.

@feckert I think at least initially the warnings need to be not shown for IPv6 related interfaces because they are a bit misleading and aren't testing anything IPv6 really. When users are trying to diagnose something with their mwan3 configuration and they those messages appear for IPv6 interfaces, it can lead you think something is wrong, when in fact this is probably not the case.
If the interface config can at least have some form of IPv6 awareness as a start that would be a good place to build on.
I think longer term you'd want to have IPv4 and IPv6 compatibility for where there are currently IPv4 only handling, mainly around the diagnostics and information shown like ip route and such, but there probably needs to be a way to determine IPv6 is both enabled generally and if IPv6 configuration in mwan3 is present before doing that.


v0.4 deprecations: AbstractString, Union{}

Eliminates warnings when running under julia v0.4. Implemented by lifting minimal required code from Compat.jl to do the job. Only one piece of code looks potentially dangerous when actually dealing with arbitrary strings (AbstractString), where a [1:end-3] subset is taken, but this is correct because you know the final three bytes of the string are .jl as you've just tested them.

So this PR resulted in some failures on CI testing -- crashes on freeing bad pointers -- but I don't see a particular pattern to the failures. It's certainly conceivable that the change of string types is resulting in pointer problems. Do you experience these problems periodically with the infrastructure?

In this case it appears that in at least 1 case and possibly 2, the errors are erroneous, and it's Travis as fault (npm download of the package failed).  As far as Julia 0.4 and node 0.10 goes, it's because of the way the build system is set up (again), which tests against "released" Julia which used to be 0.3, but now it's 0.4 and because there apparently remains a problem (due to libuv) between node 0.10 and Julia 0.4 -- especially on OS/X. that's failing.
I've restarted this builds to see.

Ok so here's what I think is going on.

Unfortunately node 0.10 and Julia 0.4 are currently not compatible.  The reason is that some libuv stuff is exposed directly during the initialization of libjulia, which is using node's libuv, not Julia's.  This can ultimately be fixed, but not right now.  This really is unfortunate, but now that node 0.10 is 2 major versions behind the LTS node, I'm proposing that we try to migrate away from node 0.10.
Julia nightly's are a moving target, I see that 0.5 on OS/X is different than the dev 0.5 on Linux, by a lot actually, and now there's some new change to Julia that has broken compatibility.

Yes time for an update.  So this is what propose to do.  I will update the checks so that node 10 is no longer checked against "releases".  I will add a new one against Julia 0.3.  If there is a future change that breaks backward compatibility there I can make a branch of node-julia that maintains compatibility with Julia 0.3, but expect over the course of the next year that no one will be interested in Julia 0.3 either.  Meanwhile I will add what is necessary to un-break Julia 0.5 while trying to maintain backwards compatibility with earlier versions of Julia 0.5 to keep the linux variant also work -- this historically has been possible but at time difficult.

That seems reasonable. I kept up with the v0.4 train as it ran because I was learning the language and just starting out. But at the moment I have no desire to keep up with the v0.5 nightlies! As far as node goes, I agree.  We're using v0.12 ATM

Yea I can't believe AWS here, they are clearly behind, and they've been given a year's+ heads up.  Perhaps OpenShift is just plain better because of that.

It appears that the check is failing for a more subtle reason, it appears to be a combo of Mavericks, version 6.0 of Xcode, and node 4.x.  This does not happen on Yosemite with xcode 7.0, but unfortunately Mavericks old enough now, that it's hard to debug the problem when the error is so opaque.  Between mav and yosemite and the xcode that supports them, the included c++lib changed significantly, this is likely contributory.  For now I'm disabling checking node 4.x with travis and leaving node 0.12 as a proxy.  Not ideal.

This pull request seems fine though, much thanks!

:+1:


Transaction state check in the client side.

Is your enhancement request related to a problem? Please describe.
Currently, we have done the transaction state check at the server-side, so that we can avoid users to commit or abort an invalid transaction(already committed or aborted). It also needs to add the validation at the client-side to avoid users to use an invalid transaction to publish messages, acknowledge messages or abort/commit again.

@congbobo184 Please help fix this issue, thanks.


fix disks tab crashing when disks array is empty

📝 Description

fix disks tab crashing when disks array is empty
fix cloud init tab carshing when volumes array is empty
boot source availability should set to false if no type is found

/lgtm


Simplify collection RDF

From the discussion in the meeting:

update the first entry so that source links to an rdf on github, so that this is the actual use case
id should be mandatory for each entry in collection and the ids should be unique

update the first entry so that source links to an rdf on github, so that this is the actual use case

@oeway and I came to the conclusion that a dedicated rdf_source field fits our needs better....

Looks good to me


fix(ci): bump macos runners to 14 and explcitly specify targets on macos

fix #269

waiting for user feedback on #269 before I merge this


MINIFI-368 exclude hidden files when scanning for src files

Updated regex matching when scanning for source files so that we don't pick up hidden files such as vim swap files.

reviewing

looks good.  replicated issue with vim editing.  merged.  thanks for fixing


[web] [google_maps_flutter_web] GoogleMap onTap() callback not triggered when clicked on Polygon

Hi Flutter team,
this is a re-opening of #111897 with a better description and example
the GoogleMap onTap(latLng) callback is not fired in the google_maps_flutter_web when the polygon is drawn on the map and the user taps(clicks) on the polygon area.
minimum example to reproduce:
class MapsBug extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: GoogleMap(
        initialCameraPosition: const CameraPosition(target: LatLng(50.10, 14.25), zoom: 10),
        polygons: {
          const Polygon(
            polygonId: PolygonId("polygon"),
            points: [
              LatLng(50.40, 14.10),
              LatLng(50.10, 14.10),
              LatLng(50.10, 14.50),
              LatLng(50.40, 14.50),
            ],
          )
        },
        onTap: (latLng) {
          print("NOT fired when clicked on Polygon");
        },
      ),
    );
  }
}

google_maps_flutter: 2.2.0
google_maps_flutter_web: 0.4.0+2

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.6 21G115 darwin-arm, locale en-CZ)
    • Flutter version 3.3.2 on channel stable at /Users/stenlee/Developer/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e3c29ec00c (6 days ago), 2022-09-14 08:46:55 -0500
    • Engine revision a4ff2c53d8
    • Dart version 2.18.1
    • DevTools version 2.15.0

Hello @stenlee. I am closing this issue as a duplicate and reopening the other issue. Please post your findings on the original issue https://github.com/flutter/flutter/issues/111897


Drop static site for SSR?

The website is currently static. I've recently moved it to Vercel, so running it as a SSR app would work.
Making it dynamic would also remove some limitations in how we're building it/fetching data, creating links, passing data around, etc... so I think it's a good long-term investment.
Let me know your thoughts. Working on this issue also means removing the technical choices that were made because of the static nature of the site.

I still think that the initial data fetching/processing has to be done in a batch process. That part cannot be done during the page rendering because of the size of the data and API request limits. We could introduce:

A scheduled job separate from the deployment builds that would fetch and store the data in a database (SQL/NoSQL depends on the preferred choice)
A new REST/GraphQL API that would fetch and serve the data from the database to the frontend


src-inspector.nix for handling sourceProvenance  of autogenerated package sets

Description of changes
This explicitly a sketch/demo because it makes changes to generated files which would actually need to be made in upstream node2nix.
This proposes a mechanism that could be used for autogeneration of sourceProvenance information of package sets like nodePackages.*, bundix-based packages, haskellPackages.*, rPackages.*, poetry2nix packages... which themselves are largely autogenerated from language package repos.
There are 3 main ideas here:

Generated packages providing a passthru.allSourceFiles attrset that gathers together all the archive files used by the package for easy consumption by tools. This removes the requirement that might otherwise exist that internal dependencies be represented as proper packages themselves (in node2nix they are represented as minimal attrsets that the top-level package is itself responsible for unpacking & installing).
A set of tools that use Nix derivations to inspect these source archives and generate json files detailing the likely binaries found. Using Nix has the advantage that results are cached - repeated runs for large package sets on the same machine should have significantly reduced download/build toll after the initial run, multiple uses of the same archive file re-use results and the standard builder's unpackPhase is quite good at knowing how to unpack arbitrary archives (with exceptions - see later).
A mechanism to apply the results from the generated source type information to a set of packages. It's intended that this would be placed before any manual override-layer to allow false-positives to be suppressed.

Here I've implemented it for nodePackages - the included inspected-src-types.generated.json was generated with the command:
nix-build -E 'let pkgs = (import ./. {}); in pkgs.mkInspectedSrcTypesJSON (builtins.removeAttrs pkgs.nodePackages ["btc-rpc-explorer" "graphqurl" "joplin" "thelounge-theme-midnight"])'

Notice here me having to exclude some packages from the analyzed set. These were packages whose tarballs gnu tar couldn't unpack due to some quirk in how npm handles/generates tarballs (reported to an author in https://github.com/mafintosh/fd-lock/issues/3 but I can't imagine much movement). Ideally regeneration of source information could be done as part of e.g. generate.sh but perhaps that would need more thought if we were likely to routinely need exceptions :shrug:
Results for nodePackages flagged up quite a few packages that download binary native code. See the full report as generated by mkSrcInspectionReportJSON. From a spot check, it does seem that most of these packages do prefer the downloaded binary over building their own if there is a prebuilt binary for their platform.
Things that could be done but I just haven't include implementing a fallback allSourceFiles that just looks at src and srcs so this could work with regular packages, implementation for other language ecosystems, knowledge of more than just .jars for bytecode (perhaps even inspecting inside jars for native code) and so on...
Things done
N/A

The code in this PR is fairly old and requires rebasing. Would you mind doing this or closing the PR if you don't care anymore?

Have done the former and updated the generated source report json.


How to force change RGB to GRAY?

Hello all,
I have a DMK 42BUC03 camera and I want to change its RGB data to GRAY.
cvCvtColor(pOpenCVImage,pColorCVImage,CV_BayerGB2RGB); // Create a color image from the raw data
Can I just change parameter in this function or I should grab picture first and change RGB to GRAY..
Hope I can get GRAY pics to process as real time.

You do not need
cvCvtColor(pOpenCVImage,pColorCVImage,CV_BayerGB2RGB); //
this line, because it creates color RGB from the incoming bayer format. However, only color cameras have bayer raw data. Your monochrome camera has no Bayer Raw, therefore you receive 1byte per pixel gray scale.
This should answer your question.

But if I remove this line, I just can get one whole black image.
And if I want do threshold from that RGB image, I can't get real threshold image.
cvThreshold(pColorCVImage,pColorCVImage,128,255,CV_THRESH_BINARY);

I tried to add some code about RGB to GRAY and do threshold again, but it waste some speed.


Sortable do not refresh to adjustment

Issue description:
Hello, I'm testing this great customizer framework (great job btw); in particular, I'm working on the sortable ctrl, as I need exactly the "foreach/get-template" functionality available at https://kirki.org/docs/controls/sortable.
Now, after the first implementation, when I edit to add or remove options (both from the "default" and "choices" arrays accordingly), the sortable elements stack doesn't change. Looks like that it do not refresh the settings in the database (but maybe I've missed something).
Version used:
(Did you try using the develop branch from GitHub? There's a chance your issue has already been addressed there)
Version: 3.0.45. Develop branch not tried yet
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))

the Config:

Kirki::add_config( CUSTOMIZER_CONFIG, array(
	'capability'    => 'edit_theme_options',
	'option_type'   => 'theme_mod',
) );

Control (just like your docs):

Kirki::add_field( CUSTOMIZER_CONFIG, [
	'type'        => 'sortable',
	'settings'    => 'my_sections_stack',
	'label'       => esc_html__( 'SECTIONS STACK', 'kirki' ),
	'description' => esc_html__( 'Desc...', 'kirki' ),
	'section'     => 'section_name',
	'default'     => [
		'option1',
		'option2',
		'option3',
		'option4',
		'option5',
		'option6',
	],
	'choices'     => [
		'option1' => esc_html__( 'Option 1', 'kirki' ),
		'option2' => esc_html__( 'Option 2', 'kirki' ),
		'option3' => esc_html__( 'Option 3', 'kirki' ),
		'option4' => esc_html__( 'Option 4', 'kirki' ),
		'option5' => esc_html__( 'Option 5', 'kirki' ),
		'option6' => esc_html__( 'Option 6', 'kirki' ),
	],
	'priority'    => 21,
] );

The template:

// Get the parts.
$template_parts = get_theme_mod('my_sections_stack', array(
	'option1',
	'option2',
	'option3',
	'option4',
	'option5',
	'option6',
));
// Loop parts, echo just for test.

foreach ($template_parts as $template_part) {
    echo $template_part ;
}

Hello and thank you for reporting this issue.
We are closing most open GitHub issues with the release of Kirki 4 to start fresh with this major release.
If you are still running into issues after you have tested your theme with Kirki 4, please let us know so we can reopen the issue.
Please note that Kirki 3 is no longer actively supported. Moving forward, we will only provide support the very latest version of Kirki.
Thank you for your understanding.
Best,
David