Feature request: "Import {*} from 'module'" for auto importing all to local scope without namespacing

TypeScript Version:  2.4.2
ES6 allows to import all to a namespace  import * as ns from 'mymodule'.
But we'd like to avoid namespace hell in our code and still have all imports but in local scope.
Please add support to import all exports as local scope, without namespace, something like:
import {*} from 'mymodule'.
Code
//utils/index.ts
export function doThis(){...}
export class ThisClass {...}

//module1.ts
import {*} from './utils';
//all names imported to local scope automatically, so refactoring (moving across exported names modules) is easy
doThis();
new ThisClass();

this issue was started  from here #17813

We try to avoid anything that deviates from ECMAScript itself nowadays, and so I don't see TypeScript implementing this any time soon. Additionally, I believe ECMAScript specifically avoided this import form because of some of the refactoring and API impact problems that can come about from it.

avoid anything that deviates ES? Lol! Isn't it a purpose of Typescript to be a superset of ES, which extends it with features that make life of developers easier? This is one of those things.

If developer needs to move an exported name from one module to another, when this name is used in imported in bunch of other modules?

Well then you have one line to change in a bunch of different modules, instead of every use site.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


[libsoundio] Add support for linux backends

Adds features to build against optional backends (ALSA, JACK or PulseAudio).

Issue #16864

Waiting for #16904 merged.

Need test all features.

Test passed on x86-windows / x64-windows-static / x64-linux.

Thanks for the improvements!


python task ran successfull but pipeline is faiing with bash exit code 1

`trigger: none
resources:
webhooks:
- webhook: deltanew
connection: deltanew
filters:
- path: pull_request.merged
value: true
- path: pull_request.base.ref
value: "develop"
repositories:
- repository: b2b-gsp-sdelta
type: githubenterprise
name: V/b2b-gsp-delta
ref: develop
endpoint: delta
variables:

name: devops_dir
value: "/home/vsts/work/1/b2b-gsp-deltadevops"
name: global_dir
value: "/home/vsts/work/1/s/b2b-gsp-slfdelta"
group: vargroup-sfdx

stages:

stage: UnlockedPackage_Creation
jobs:

job: Build
timeoutInMinutes: 360
pool:
vmImage: ubuntu-latest
steps:

checkout: self
path: b2b-gsp-deltadevops

checkout: b2b-gsp-slfdelta
fetchDepth: 0

task: Bash@3
inputs:
targetType: 'inline'
script: |
cd $(global_dir)
git checkout master
git checkout develop
python $(devops_dir)/python-scripts/utils/vlocityCheckDiffs.py masterPython Script:import os
import subprocess
import sys

def main():
target_Branch = sys.argv[1]
cmd=f'git diff --name-status {target_Branch} vlocity/'
cmd_output, _=call_subprocess(cmd)
print(cmd_output)
if cmd_output:
print("=====EXIT CODE 123=====")
print("Changes detected")
print(cmd_output)
exit(123)
else:
print("=====EXIT CODE 1=====")
print("No changes detected")
print(cmd_output)
exit(1)
def call_subprocess(command, verbose=True):
''' Calls subprocess, returns output and return code,
if verbose flag is active it will print the output '''
try:
stdout = subprocess.check_output(command, stderr=subprocess.STDOUT,
shell=True).decode('utf-8')
if verbose:
print_output(f'{stdout}')
return stdout, 0
except subprocess.CalledProcessError as exc:
output = exc.output.decode('utf-8')
returncode = exc.returncode
if verbose:
print(f'[ERROR]Subprocess returned non-zero exit '
f'status {returncode}')
print_output(output)
return output, returncode
def print_output(output, color='', tab_level=1):
''' Prints output in the color passed '''
formated = '\t' * tab_level + output.replace('\n', '\n' + '\t' * tab_level)
print(f'{formated}')
if name=='main':
main()`
ERROR:
Previous HEAD position was a35d7eb Create form.json
Switched to a new branch 'master'
branch 'master' set up to track 'origin/master'.
Switched to a new branch 'develop'
branch 'develop' set up to track 'origin/develop'.
=====EXIT CODE 1=====
No changes detected
##[debug]Exit code 1 received from tool '/usr/bin/bash'
##[debug]STDIO streams have closed for tool '/usr/bin/bash'
##[error]Bash exited with code '1'.
##[debug]Processed: ##vso[task.issue type=error;]Bash exited with code '1'.
##[debug]task result: Failed
##[debug]Processed: ##vso[task.complete result=Failed;done=true;]
Finishing: Bash
I want perform the condition in azure if exist code 1 task will run successfull or if exist code 123 task will fail as per the above python  i am trying to perform the task but it is failing any solution failure task

Hi @bharuk thanks for reporting! We are working on more prioritized issues at the moment, but will get back to this one soon.

Any reponse regarding the issue why it is getting error..

Please post your questions on the Developer Community to get the right eyes on it, since this repo is mostly for questions about templates located in this repo.


feat(docs): Document EJBCA support for signing

This PR adds instructions to using EJBCA as ephemeral certificate issuer.
I've also moved the --bundle option to its own section.

yarn run docusaurus download-remote-deployment-readme

The README won't pass the linter. I'll send a separate PR for it.


[SPARK-37468][SQL] Support ANSI intervals and TimestampNTZ for UnionEstimation

What changes were proposed in this pull request?

This PR proposes to support ANSI intervals and TimestampNTZ for UnionEstimation.
Currently, UnionEstimation doesn't support ANSI intervals and TimestampNTZ. But I think it can support those types because their underlying types are integer or long, which UnionEstimation can compute stats for.
Why are the changes needed?

To make CBO better.
Does this PR introduce any user-facing change?

No. Not interferes with the current behavior.
How was this patch tested?

Modified UnionEstimationSuite.

Test build #145646 has started for PR 34716 at commit 7927295.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50115/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50115/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50115/

Test build #145646 has finished for PR 34716 at commit 7927295.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145646/

cc: @cloud-fan @gengliangwang @MaxGekk

Test build #145724 has started for PR 34716 at commit 9dc56f1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50194/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50194/

+1, LGTM. Merging to master.
Thank you, @sarutak .

Test build #145724 has finished for PR 34716 at commit 9dc56f1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145724/


iOS 13 Beta 2 stopped working!!

First of all thank you for you solution. This worked initially, but since updating to ios13 beta2 it no longer works. CNCopySupportedInterfaces is returning nil. My app has location permission while using the app. Any thoughts?

Reboot fixed it :)


stopping weave results in error and breaks subsequent docker invocations

Technically not a bug, but most users will see it that way.  Is 'docker -d' running on this host?
Cannot connect to the Docker daemon. Is 'docker -d' running on this host?
$ docker ps
Cannot connect to the Docker daemon. Is 'docker -d' running on this host?

The fix is to export DOCKER_HOST=<previous value> prior to weave stop, which a) is non-obvious, and b) somewhat difficult if you don't know / didn't save the previous value.

I suggest weave env also exports a DOCKER_HOST_ORIG. and weave env --restore (or weave restore-env?) uses that to restore the original settings.
@errordeveloper is there an equivalent command in boot2docker/machine/swarm that could serve as inspiration?

Maybe it would be easier to print a warning on weave stop when DOCKER_HOST was pointing to the proxy...

A warning that tells the user to a) expect an error,  and b) run weave env --restore, would indeed be helpful.


Curved text causes spacing problems.

Hello,
As you can see on the image above, putting the text in curved form is causing me problems with letter spacing, how can I solve this problem?

Found an answer, using monospace fonts, "Courrier" for instance.


rename second level per-topic supervisor MACROs

for producers
SUP -> PRODUCERS_SUP
SUP2 -> PRODUCER_SUP
for consumers
SUP -> CONSUMERS_SUP
SUP2 -> CONSUMER_SUP
keeping the actual name unchanged (e.g. brod_topics_supervisor2)
to be backword compatible. otherwise a full supervision tree
restart is required when load recompiled beam.

no, this is not good naming either. closing it.


[GOBBLIN-691] Make format-specific component pluggable in compaction

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/GOBBLIN-691

Description

As the first step of ORC compaction, this PR tries to make current compaction code insensitive to the data format: Format-specific components should be pluggable: CompactionJobConfigurator  becomes the abstract implementation for CompactionAvroJobConfigurator  which used to be the component for Avro-specific logic, so that we can implement other formats' configurator to use the same dataset discovery and verification logic.  All changes should be backward compatible.
Put deprecation annotation for old compaction implementation. Instead, we should use CompactionSource + MRCompactionTask to launch MR job.
Fix some of typo while reading thru. code.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@yukuai518 @ibuenros Can you help review ? Thanks.

+1 LGTM.


Extension badge and list view out of sync

I created a few profile, installed Jupyter and Python extensions. The extension badge said there are 2 require reload but I'm not seeing any from the list.

Does the previous profile had any reload required extensions?
Have you tried refreshing the extensions view once?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Engine: Set data_type for all protobuf values

Fixes #45

Adds missing data types to all Values.
Updates all existing tests to ensure that data types are present for returned value
Update UserComponent to also validate that values set have the correct data_type.

If the user does not run step() the Simulation trying to GetAttribute() the data type is still missing. This is a good to fix.

If the user does not run step() the Simulation trying to GetAttribute() the data type is still missing. This is a good to have/fix.

This seems to be a problem because this branch was made before the #46 was merged in

Seems like the E2E check is failing because the E2E assumed implicit type conversion which has not yet been merged (PR #51). I have patched the E2E tests and merged into this PR to see if that fixes the issue.


server.py: Remove old comment

As of spotify/luigi#1631 this is fixed, later spotify/luigi#1734 enhanced it

LGTM


Update default chart version to support Latitude deployments

:tada: This issue has been resolved in version 0.27.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Slow downloads from yum repo in Europe

Does this issue occur when all extensions are disabled?: Yes

Version: 1.57.1
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:26:56.255Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.12.10-1-default

Steps to Reproduce:
1.On my openSUSE Tumbleweed instance i get extremely slow download speeds from https://packages.microsoft.com/yumrepos/vscode repository
Retrieving: code-1.57.1-1623937083.el8.x86_64.rpm ................[done (74.9 KiB/s)]

nslookup packages.microsoft.com
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Non-authoritative answer:
packages.microsoft.com	canonical name = apt-geofence-parent.trafficmanager.net.
apt-geofence-parent.trafficmanager.net	canonical name = csd-apt-weu-d-4.westeurope.cloudapp.azure.com.
Name:	csd-apt-weu-d-4.westeurope.cloudapp.azure.com
Address: <IP_ADDRESS>

Thanks I had passed on a similar report to the linux repo team back then


KOGITO-2757 Application.java: Refactor Codegen

Simplify Application.java (and related components) and use a templated approach wherever possible.
Currently:

Refactored Config classes

Refactored Application classes so that they use templates (very tiny templates)

Processes.java: is injectable when in a DI context, otherwise acts as a factory (as usual). The injectable ApplicationProcesses.java is no longer present (it is not required anymore).

RuleUnits section N/A

DecisionModels section N/A

PredictionModels section N/A

I will maybe add RuleUnits section: with the dual Factory+Injectable version approach, but I won't do Decisions and Predictions in this same PR otherwise it gets too big; and there is also ongoing work in parallel that I don't want to break.

@evacchi Please be aware of https://github.com/kiegroup/kogito-runtimes/pull/621 that will merge once build is green.
It adds another bit of codegen for Trusty and therefore might need updating in this PR. Just FYI.

damn you @manstis
/me shakes fist
:P

Added a few people for review.

@evacchi also #642 introduces a lot of things in this module. Do you mind waiting for me? :)

sure @ricardozanini I just want to merge it ASAP because it touches a few files -- hopefully once it's merged the situation will improve. I have tried to merge both this PR and #642 locally and the only conflict I find is in ProcessCodegen.java and I think it stems from the constructor being reordered (as I mentioned in the review of #642 -- please make sure they are re-aligned as they were upstream). There should not be any other conflicts.

sure @ricardozanini I will. I just want to merge it ASAP because it touches a few files -- hopefully once it's merged the situation will improve. I have tried to merge both this PR and #642 locally and the only conflict I find is in ProcessCodegen.java and I think it stems from the constructor being reordered (as I mentioned in the review of #642 -- please make sure they are re-aligned as they were upstream). There should not be any other conflicts (apart from KogitoAssetsProcessor.java which is related to master)

oh , so go ahead and merge! I really liked the way you refactored. I'll take carefully look into it. Many thanks!

@danielezonca I have pushed a few changes that should address most of your comments :)


Amplify frontend build fails abruptly

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d121nds41yoalf
AWS Region
us-east-1
Amplify Hosting feature
Frontend builds
Describe the bug
I'm using amplify for creating the react build. Some time bulid gets completed successfully with out any error but otherwise fails. It's totally random. For instance, before posting the issue here, I tried thrice - it got failed first two time but third time it worked.
I've tried this options as well but all in vein
NODE_OPTIONS     --max_old_space_size=8192
here are the logs
Starting phase: preBuild
                             # Executing command: rm -rf node_modules

2023-03-24T07:59:34.015Z [INFO]: # Executing command: npm ci
2023-03-24T07:59:37.514Z [WARNING]: npm
2023-03-24T07:59:37.517Z [WARNING]: WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
2023-03-24T08:00:10.594Z [WARNING]: npm
2023-03-24T08:00:10.597Z [WARNING]: WARN deprecated<EMAIL_ADDRESS>Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
2023-03-24T08:00:11.877Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.
2023-03-24T08:00:12.109Z [WARNING]: npm WARN
2023-03-24T08:00:12.109Z [WARNING]: deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
2023-03-24T08:00:12.110Z [WARNING]: npm
2023-03-24T08:00:12.110Z [WARNING]: WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
2023-03-24T08:00:12.115Z [WARNING]: npm WARN
2023-03-24T08:00:12.115Z [WARNING]: deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
2023-03-24T08:00:12.115Z [WARNING]: npm
2023-03-24T08:00:12.116Z [WARNING]: WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
2023-03-24T08:00:12.317Z [WARNING]: npm WARN
2023-03-24T08:00:12.317Z [WARNING]: deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
2023-03-24T08:00:12.395Z [WARNING]: npm WARN
2023-03-24T08:00:12.396Z [WARNING]: deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
2023-03-24T08:00:12.425Z [WARNING]: npm WARN
2023-03-24T08:00:12.426Z [WARNING]: deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
2023-03-24T08:00:12.627Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>Package moved to @redux-devtools/extension.
2023-03-24T08:00:15.730Z [WARNING]: npm WARN deprecated
2023-03-24T08:00:15.734Z [WARNING]<EMAIL_ADDRESS>This SVGO version is no longer supported. Upgrade to v2.x.x.
2023-03-24T08:00:16.438Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. rc-time-picker provides its own type definitions, so you do not need this installed.
2023-03-24T08:00:21.063Z [WARNING]: npm WARN
2023-03-24T08:00:21.065Z [WARNING]: deprecated<EMAIL_ADDRESS>Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
2023-03-24T08:00:25.656Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
2023-03-24T08:00:27.658Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
2023-03-24T08:00:41.252Z [INFO]: added 1979 packages, and audited 1980 packages in 1m
2023-03-24T08:00:41.254Z [INFO]: 274 packages are looking for funding
run npm fund for details
2023-03-24T08:00:41.274Z [INFO]: 19 vulnerabilities (1 low, 6 moderate, 12 high)
To address issues that do not require attention, run:
npm audit fix
To address all issues (including breaking changes), run:
npm audit fix --force
Run npm audit for details.
2023-03-24T08:00:41.306Z [INFO]: # Completed phase: preBuild
# Starting phase: build
# Executing command: npm run build
2023-03-24T08:00:41.708Z [INFO]: ><EMAIL_ADDRESS>build
> react-scripts build
2023-03-24T08:00:43.237Z [INFO]: Creating an optimized production build...
2023-03-24T08:03:22.098Z [INFO]: The build failed because the process exited too early. This probably means the system ran out of memory or someone called kill -9 on the process.
2023-03-24T08:03:22.148Z [ERROR]: !!! Build failed
2023-03-24T08:03:22.149Z [ERROR]: !!! Non-Zero Exit Code detected
2023-03-24T08:03:22.149Z [INFO]: # Starting environment caching...
2023-03-24T08:03:22.151Z [INFO]: # Uploading environment cache artifact...
2023-03-24T08:03:22.264Z [INFO]: # Uploaded environment cache artifact
2023-03-24T08:03:22.264Z [INFO]: # Environment caching completed
Terminating logging...
Expected behavior
Should be successful front end build
Reproduction steps
It's random, same code, same branch got a successful deployment sometime otherwise not.
Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - rm -rf node_modules
        - npm ci
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: build
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Log output

# Put your logs below this line

Additional information
No response

Hi @sandeepinsys 👋🏽 , thanks for raising this issue. We recommend setting the environment variable NODE_OPTIONS to
--max-old-space-size=4096. Since the default is 2 GB and our build containers have 7 GB, setting it to 8192 exceeds the memory available.
Please let us know if this helps resolve the intermittent behavior.
Referenced: https://github.com/aws-amplify/amplify-hosting/issues/1132#issuecomment-708175103

Hi @sandeepinsys 👋🏽 , thanks for raising this issue. We recommend setting the environment variable NODE_OPTIONS to --max-old-space-size=4096. Since the default is 2 GB and our build containers have 7 GB, setting it to 8192 exceeds the memory available.
Please let us know if this helps resolve the intermittent behavior.
Referenced: #1132 (comment)

Hi @hloriii
Thanks for responding back.
We had started this configuration with --max-old-space-size=4096 only but since we were still having this build issue so we increased this.
What are my options here ?

Hi @sandeepinsys thank you for trying the suggestion, we are working on next steps to unblock you and will update you with further instruction shortly.
@sandeepinsys did you try setting NODE_OPTIONS to --max-old-space-size=4096 as well?

Hi @sandeepinsys and @SuperRiderAbt if setting NODE_OPTIONS to --max-old-space-size=4096 does not resolve the issue, please open a case with AWS Support to receive further assistance.


Save best model based on validation dice

It would be important to keep the model that gives the best validation metrics. Currently, this is not the case and we use the final checkpoint for testing, but this is not optimal.

Implemented as of 3bae5ccc9b36f96af8202c3dcbb3d9d939001f17


SPARQL: basic SELECT queries pt. II

BASIC QUERIES
Ref: https://www.w3.org/TR/rdf-sparql-query/#basicpatterns

[X] matching RDF literals with language tags
[X] matching RDF literals with arbitrary datatypes

FILTERS
Ref: https://www.w3.org/TR/rdf-sparql-query/#termConstraint

[ ] ~regex filter for strings (store-level filtering)~ (moved to https://github.com/beautifulinteractions/node-quadstore/issues/101)

published in<EMAIL_ADDRESS>


RuntimeError for gradient computation

Thank you very much for resolving the previous issue https://github.com/BIT-MCS/GCRL-min-AoI/issues/2. Recently, I encountered a new problem. When I ran the command "python train_our_policy.py --overwrite --output_dir logs/debug --gpu --gpu_id 0" according to the instructions in your readme, an error occurred as follows:
Traceback (most recent call last):
  File "train_our_policy.py", line 209, in <module>
    main(sys_args)
  File "train_our_policy.py", line 156, in main
    trainer.optimize_batch(num_batches, episode)
  File "/home/xxx/GCRL-min-AoI/method/trainer.py", line 81, in optimize_batch
    loss.backward()
  File "/home/xxx/anaconda3/envs/mcs/lib/python3.8/site-packages/torch/_tensor.py", line 487, in backward
    torch.autograd.backward(
  File "/home/xxx/anaconda3/envs/mcs/lib/python3.8/site-packages/torch/autograd/__init__.py", line 200, in backward
    Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [128, 61, 32]], which is output 0 of ReluBackward0, is at version 1; expected version 0 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).

I debugged it and found that there were many in-place operations in the forward() function of graph_model.py, and several variables shared one tensor. It seems that this may cause incorrect gradient calculation. I wonder if you can give me some clues, and I will continue to debug and try to find a solution. Looking forward to your reply.

Or is it a problem with the Torch version? It seems that starting from PyTorch 1.2, PyTorch began to support runtime detection of in-place operations in the computation graph. However, my Torch version is 2.0.0?

Yes, there exists several inplace operator (e.g., +=) in the code, which is not supported by newer version of Pytorch. Please refer to the runtime environment of this repo. My idea and code are both largely inspired by this work.


Add afterFeature and beforeFeature hooks, RunnerBuilder

Relevant Issues : #855
Type of change :
[ X] New feature
Add beforeFeature and afterFeature in ExecutionHook
And a proposal for RunnerBuilder. I did not want to modify original Runner.java as it might be a breaking changes for others.
One thing I'm not sure about how to handle the feature hook failures. I personally wouldn't treat them as test/feature failure. one way would be collect them in a separate error list and return it with Results.

@pshrm please hold on this because I may make some changes to fix the files issue #860

closing as the runner builder is re-worked: https://github.com/intuit/karate/commit/f848c0bd12d1989f618a1428d122cfda0c66c712


rtinst fails to install rutorrent as the downloaded file doesn't match

wget -q https://github.com/Novik/ruTorrent/archive/$rurelease.tar.gz
When wget has content-disposition=on, it will save the downloaded file using the suggested filename hinted by the web server. Most of the time, this is the better behaviour.  However, in this case, the downloaded file has "ruTorrent-" prepended to it, so at the time of writing, it'd download ruTorrent-3.10-beta.tar.gz or ruTorrent-master.tar.gz  This makes the untar fail as it is trying to untar the file without the "ruTorrent-"
Maybe the solution is to just download to a fixed filename and use that fixed filename thereafter.
wget -q -O rutorrent.tar.gz https://github.com/Novik/ruTorrent/archive/$rurelease.tar.gz
This applies to rutupgrade too.

Make a pull request for it if you want to see this happen. And please close this issue.


Add user icon for current location once found.

Note that there's a locationFound state in vuex that we could use.

Closing as out of date


⚠ Bofrost.at has degraded performance

In a221f56, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1343 ms

Resolved: Bofrost.at performance has improved in 914a975 after 10 minutes.


Populate HTML Content with QuestionnaireResponse Data

Describe the feature request.
Create a feature that's able to:

Hide UI elements if there is no answer in the referred link id
Populate answers as a list or a single value in the HTML
Populate the submitted date in the HTML content

Additional context
I was initially thinking to use configuration + rules engine, but I feel it will take much more time since the implementation of those 2 need to be refactored first before it can be used by this feature. So, that's why I create a new class then do some simple string manipulation to the html.
Acceptance criteria

[x] Hide UI elements if there is no answer in the referred link id

If the answer is empty:
"@is-not-empty('link-id')
Text
@is-not-empty" -> (nothing)

If the answer is not empty:
"@is-not-empty('link-id')
Text
@is-not-empty" ->
Text

[x] Populate answers as a list or a single value in the HTML

"
@answer-as-list('link-id')
" ->

answer 1

answer 2

"
@answer('link-id')
" ->
(the answer)

"
@answer('link-id')
" ->
14-May-2024
 (if it's a date type)

"
@answer('link-id','MMMM d, yyyy')
" ->
May 14, 2024

[x] Populate the submitted date in the HTML content

"@submitted-date" -> 14-May-2024

"@submitted-date('MMMM d, yyyy')" -> May 14, 2024

Area path
Run the test cases, we couldn't directly use this feature in the app until ticket https://github.com/opensrp/fhircore/issues/3235 is complete.
Implementation plan (For Engineers)

Create HtmlPopulator class
Create populateHtml() method, it will accept a raw HTML string and return the populated HTML string with the data from the QuestionnaireResponse
Create these methods: processIsNotEmpty(), populateAnswerAsList(), populateAnswer(), populateSubmittedDate(). These will handle specific tasks such as hiding UI elements, populating answers as list items or single values, and populating the submitted date in the HTML content, mainly using string manipulation by finding the tags for each functionality, then replacing it with the correct string/answer.

@FikriMilano Is the question displayed against the answer or just the link id?

My question was whether we also display the question, as in question and answer response.

Let's have those loops cleaned up before merge, moving to sprint 11


Net core updates

This pull request has additional changes to @xferra pull request 25. These changes are necessary to make the LtiSamples work. The significant changes are:

Convert OutcomesClient methods to async to avoid deadlocks (new http client is less relaxed about it)
Fix up the Json-LD formatter so that only one @context element is generated
Use HttpRequestHeader instead of a content HttpHeader where appropriate (new http client is less relaxed about it)
Stop disposing the content stream after calculating signature (new http client is less relaxed about it)

I finished verifying that all of the samples in the LtiSamples repository now work. I also ran all the unit tests in both versions of the solution (LtiLibrary.sln and LtiLibrary.NetCore.sln). All results are green.

@xferra Would you review this pull request?

@andyfmiller This PR looks good for me, great work!


Doesn't work in symbol overrides in Sketch 52.1

Before the sketch 52 update this worked with symbol overrides and was a time-saver.

Hey @Kgangi 👋
Thanks for the report, I'll investigate this and will keep you updated.

@Kgangi we've fixed the issue and will release an update in an hour.

@Kgangi we've released the updated, you should be able to update it from Sketch.

wow that was fast! It works great again


Implement a Limit operator for Myria

Myria does not appear to have a Limit operator; SinkRoot is pretty close, but we don't want to drop the tuples on the floor.

Implemented


fix: alter sql columns to long text #7463

Merge lyft-release-sp8@7bfe7bc to master

Codecov Report

Merging #7476 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7476   +/-   ##
=======================================
  Coverage   65.42%   65.42%
=======================================
  Files         435      435
  Lines       21322    21322
  Branches     2347     2347
=======================================
  Hits        13950    13950
  Misses       7256     7256
  Partials      116      116

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8bda6...1de8d38. Read the comment docs.

This has already been reviewed, merging.


wrong date calculation for vaccination certificate and status

My last vaccination was on 2021-06-01 and I inserted my certificate yesterday (2021-06-14).
Since today midnight (2021-06-15) the "cwa-app-android" app shows "Impfschutz" which let me think, I have an active vaccination status right now and can enjoy my privileges.
An other app from german health administration with name "CovPass" shows the same certificate with message "Vollständiger Impfschutz ab 16.06.2021." so this is not today but tomorrow! There is also an other official app "Covpass Check" that is supposed to be used by security personal shows on my certificate "Impfstatus nicht gültig. Das geprüfte Zertifikat weist keine vollständige Impfung nach."
Same issue is have on iphone version, too.
Please check date calculation!

Internal Tracking ID: EXPOSUREAPP-7831 iOS
Internal Tracking ID: EXPOSUREAPP-7865 Android

Duplicate: https://github.com/corona-warn-app/cwa-documentation/issues/638

Hey @Geimpfter ,
As pointed out by @DerVogel2020 , we will use https://github.com/corona-warn-app/cwa-documentation/issues/638 for discussion of this specific problem. Therefore, I will close your issue here. Nice username btw.

Corona-Warn-App Open Source Team

Duplicate of https://github.com/corona-warn-app/cwa-documentation/issues/638

Internal Tracking ID: EXPOSUREAPP-7831 iOS
Internal Tracking ID: EXPOSUREAPP-7865 Android
Corona-Warn-App Open Source Team

FYI PR iOS https://github.com/corona-warn-app/cwa-app-ios/pull/2950

FYI PR Android https://github.com/corona-warn-app/cwa-app-android/pull/3467


Add Jobs for DB Partition and Retention changes

This PR adds changes related to the DB partition and retention. It fixes the issues added in the epic #929

Add classes for Partition creation and retention
Add method to create partition based on each day
add DDL migration file

@khansaad - As discussed yesterday, I have listed the test scenarios required in addition to regression testing below:

Verify if the DB partitioning can be configurable

Verify the partition key used is correct and each partition contains correct data based on the partitioning condition. Perform both read and write operations on the partitioned tables to confirm data is accessible and modifiable as expected. Test with multiple exps and increasing volume of data and check if the partition strategy scales:

1 day
8 days data
15 days data
30 days data
40 days data

And validate:

Data is stored within the correct range of values for the partition and is accessible
If there are any error cases here, confirm appropriate error messages are displayed

Does it behave correctly when data is spread across partitions across months? What is the behavior when we upload
data for more than a month? Are partitions created automatically for the next month?

Verify if data is accessible after restarting kruize pod

Verify expected partition deletion behavior and check the behavior when the deleted partitions are accessed

Validate that appropriate error handling and exception messages are in place

Validate any log messages in kruize pod log related to partition queries or pruned messages

Verify documentation - configurable parameters, db partition keys used, partitioning logic, how to delete the partition and impact of deleting the data etc


Provide nightly builds for ACA-Py

For developers that require access to bug fixes, we should provide nightly builds (or build on merge to main?) of the ACA-Py images.
Investigate if we can leverage a nightly build in AATH or other testing situations.

@gavinok

Nightly builds would be sufficient.  Building on merge to main would cause unnecessary strain on Hyperledger's GitHub actions runner time allotments.
The nightly builds should incorporate the nightly test runs and only build/publish on success.  The workflow should only run if there are changes to the repo since the previous run, there is no point in wasting precious runner time.
The workflows you want to look at are:

https://github.com/hyperledger/aries-cloudagent-python/blob/main/.github/workflows/nightly-tests.yml

https://github.com/hyperledger/aries-cloudagent-python/blob/main/.github/workflows/publish.yml

To publish a nightly version of the image.  You'll need to update the workflow to tag the image appropriately; e.g. nightly.

https://github.com/hyperledger/aries-cloudagent-python/blob/main/.github/workflows/pythonpublish.yml

To publish a nightly python package, if we decide to do that.  This requires some additional thought and investigation due to the fact we'd be publishing more frequently to PyPi and may need to perform cleanup.

Ignore https://github.com/hyperledger/aries-cloudagent-python/blob/main/.github/workflows/publish-indy.yml, because we're dropping support for the indy-sdk releases and this workflow will go away.


vCheck Hangs after vCenter Upgrade to ver 7.0.3

vCenter was upgraded to ver 7.0.3 yesterday and now vCheck hangs when running the plugin 01 General Information.  I have downloaded the current version with the same results.
Any guidance on where to find the issue?

I have left the script running and eventually this plugin reports finished after 52 minutes.  It then hangs on various other plugins including 33 VM CPU Usage which eventually reports finished after almost 11 hours.  In total the report now takes 15 hours where it used to take 15-20 minutes.

It seems I have the same issue.
Stopped working since upgrade to 7.0.3
I didn't let it run 15 hours though

Yes, agreed - any updates / guidance?

I have an update on this ticket.
I have run the script again today and have found that it has completed in about 33mins.  I will monitor the scheduled task over the next few days but this issue may have resolved itself.

I can confirm that my scheduled task for vCheck ran this morning and completed in 29 minutes.  So for me the issue is resolved.  Although it is taking longer (by about 10-12 minutes)
I will wait and see if @tgoetheyn or @shouldabeen77 respond before closing this issue.

Hmm... it's not resolved for me, but the scheduled task was set to kill after 4 hours.  I've changed that to 24 hours, so I'll see if it runs and just takes longer (normally takes well < 1 hour).  If that doesn't work, I'm going to run it manually and see where it's hanging up.  I've not really delved deeply besides trying to track down the issue here.

Well, I can also confirm the latest run of the vCheck was succesfull.
It does take longer then before:
now: 1378 sec
before: 786 sec
but now it falls within the timeout I set for the script, so that's good for me.

In my environment, the previous working version took 453.79 seconds to run "General Information".  This last run took 47807.03.  So the whole thing is now taking like 14 hours as opposed to around 30 minutes before.  General information is the plugin that seemed to blow up for some reason.

So every time it runs, it runs approximately 1 hour quicker.  It's very very odd.   So now after several iterations it's finishing at 1PM instead of 8pm.

Well, it's really odd, but the pattern has absolutely continued.  One hour earlier every day.  And today it finished at 7am (about what it used to finish at.)  I'll see if tomorrow it finishes before it starts.  :-D  Very strange and never did figure it out.

This sounds like we all now have no real issue apart from the script taking slightly longer so I will close this issue now.


wrong jump page in keywords-search result of G6 document

Describe the bug
when you want to search some keywords in G6 document，the right related result will show you. But if you click the item in search result， it always jump to the wrong page.

Your Example Website or App
G6 Official Website
Steps to Reproduce the Bug or Issue
1、search a keyword in G6 doc search input
2、click a item in result list
3、it jump to wrong page
Expected behavior
click the keywords-search result item, ant it jump to the related page
Screenshots or Videos

Platform
platform Independent
Additional context
No response

We are still applying algolia docsearch for the new domain .antgroup now. It maybe ready in 2 weeks.

fixed, thanks for reporting


add yopass guidelines

I get you observation, but I personally think its fine. I considering the same with whether or not to add the link to the site, but concluded that it's acceptable risk. Could discuss on Mondays standup if you want


Unwanted console.log while using the playlist function [BUG]

Firstly, I want to say is that it's not really a bug but it might be something that is unwanted.
So, whenever you use the client.player.playlist() function, it will console.log() an array of all videos in the playlist. This code can be found on line 213 of Util.js. Again, I don't know if this is intentional or just left there after the testing stages and I will be removing it from my side because it is just flooding my console with things I don't need. In my opinion, it should be removed since the module is made for discord bots, and flooding your console with unwanted things is just something that should be avoided.

Hey, thanks for reporting this, I removed the console logging - that was due testing.
I already published a small fix update v6.3.2.
That should avoid this.


[doc] fix missing bracket

fix #940

Good catch, thanks @Rotzbua.

Hi!
This problem in documentation here too:
http://swiftmailer.org/docs/sending.html#using-the-send-method

@TimurGumarov Can you make a pull request? Just change https://github.com/swiftmailer/swiftmailer/blob/master/doc/sending.rst . Thanks!

#944

#944

fix #944


window.performance.memory empty object when running headless

Puppeteer version: 1.19
Platform / OS version: Osx / Ubuntu
URLs (if applicable): any
Node.js version: any

window.performance.memory
What is the expected result?
MemoryInfo object with info about the memory usage of the page e.g.  {totalJSHeapSize: 7506920, usedJSHeapSize: 6560960, jsHeapSizeLimit:<PHONE_NUMBER>}
What happens instead?
Get an empty object {} only in headless mode.

@cjroebuck This solution worked for me
https://stackoverflow.com/questions/38087467/is-it-possible-to-use-window-performance-memory-in-headless-chrome


fix #2449:It's should successful to cancel authorize a resource of a user if all the online process definitions created by this user didn't use this resource.

What is the purpose of the pull request
add the filter of user
Brief change log
It's should successful to cancel authorize a resource of a user if all the online process definitions created by this user didn't use this resource.

Codecov Report

Merging #2725 into dev-1.3.0 will increase coverage by 1.04%.
The diff coverage is 37.80%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08fa12...d60abc1. Read the comment docs.


how easy is it for someone to take this solution and build a spyware to control my phone without me knowing

I mean this solution is great, really, well done. But after I enabled tcp/ip it became veeeery easy to connect to my phone and control it. convenient me and you can describe it, vulnerable a hacker might call it.
could someone like activate that command by quickly plugging, for example, their phone or a raspberry pi or something easily opening that bridge of vulnerability to control it whenever he wants.
so my question is: how worried/ careful should we be?

The whole authentication is managed by adb: when you authorize a computer to connect to a device over adb, you grant to it shell access on the device.
So, yes, you should not authorize a computer you don't trust to connect over adb (scrcpy or not).

Turn off the USB Debugger or Developer mode to remove connected Devices.


add LICENSE to MANIFEST.in

This includes LICENSE file in distribution tarballs.
This is a requirement of the license and
it makes it easier for packagers to package your project.
Thanks!

Any chance we can get a new sdist generated on PyPI using this change?
cc @pmlandwehr

...or a later commit that includes this would work too.


Failure to load EMI plugins when using Farmer's Delight ver1.3.7 or later at the same time

Describe the Bug
Failure to load EMI plugins when using Farmer's Delight ver1.3.7 or later at the same time.
When using ver 1.3.5 or earlier, the plugin loaded without problems.
Reproduction Steps

Install Fabric, Fabric API, EMI, Create, and Farmer's Delight (ver 1.3.7 or later)
Load a world in Minecraft
EMI plugin failed to load, so recipes such as Crushing Wheels cannot be displayed.

Expected Result
Plugin should load correctly
Screenshots and Videos
No response
Crash Report or Log
https://gist.github.com/g2b3d4f/851f40c4ce4a07a49e58381207e25b96
Operating System
Windows 11
Mod Version
0.5.0g
Minecraft Version
1.19.2
Other Mods
Fabric Loader 0.14.11
Fabric API 0.69.0
EMI 0.5.1
Farmer's Delight 1.3.7
Additional Context
No response

https://github.com/newhoryzon/farmers-delight-fabric/pull/116
You should close this issues


"Failed to start model server: integer division or modulo by zero" even when allocating GPUs for InferenceService

/kind bug
What steps did you take and what happened:

Deploy the v0.13.1 Helm charts
Set defaultDeploymentMode to RawDeployment using the command kubectl patch configmap/inferenceservice-config -n default --type=strategic -p '{"data": {"deploy": "{\"defaultDeploymentMode\": \"RawDeployment\"}"}}'
Try to deploy the InferenceService (yaml provided below)
Observe that the pod enters a CrashBackoffLoop with the error

What did you expect to happen:
I expected it to launch properly and detect the GPUs without issue, like our other CUDA GPU containers do.
What's the InferenceService yaml:
apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"serving.kserve.io/v1beta1","kind":"InferenceService","metadata":{"annotations":{"serving.kserve.io/deploymentMode":"RawDeployment"},"name":"huggingface-llama3","namespace":"default"},"spec":{"predictor":{"model":{"args":["--model_name=llama3","--model_id=meta-llama/meta-llama-3-8b-instruct"],"env":[{"name":"HF_TOKEN","valueFrom":{"secretKeyRef":{"key":"HF_TOKEN","name":"hf-secret","optional":false}}}],"modelFormat":{"name":"huggingface"},"resources":{"limits":{"cpu":"6","memory":"24Gi","nvidia.com/gpu":"1"},"requests":{"cpu":"6","memory":"24Gi","nvidia.com/gpu":"1"}}}}}}
    serving.kserve.io/deploymentMode: RawDeployment
  creationTimestamp: "2024-09-05T20:23:29Z"
  finalizers:
  - inferenceservice.finalizers
  generation: 1
  name: huggingface-llama3
  namespace: default
  resourceVersion: "96031"
  uid: aaeec631-f4fd-4ee4-9578-51ad6af635b7
spec:
  predictor:
    model:
      args:
      - --model_name=llama3
      - --model_id=meta-llama/meta-llama-3-8b-instruct
      env:
      - name: HF_TOKEN
        valueFrom:
          secretKeyRef:
            key: HF_TOKEN
            name: hf-secret
            optional: false
      modelFormat:
        name: huggingface
      name: ""
      resources:
        limits:
          cpu: "6"
          memory: 24Gi
          nvidia.com/gpu: "1"
        requests:
          cpu: "6"
          memory: 24Gi
          nvidia.com/gpu: "1"
status:
  components:
    predictor:
      latestCreatedRevision: "1"
  conditions:
  - lastTransitionTime: "2024-09-05T20:23:29Z"
    reason: Predictor ingress not created
    status: "False"
    type: IngressReady
  - lastTransitionTime: "2024-09-05T20:23:29Z"
    message: Deployment does not have minimum availability.
    reason: MinimumReplicasUnavailable
    status: "False"
    type: PredictorReady
  - lastTransitionTime: "2024-09-05T20:23:29Z"
    reason: Predictor ingress not created
    status: "False"
    type: Ready
  modelStatus:
    states:
      activeModelState: ""
      targetModelState: Pending
    transitionStatus: InProgress
  observedGeneration: 1

Anything else you would like to add:

When not using the vLLM backend for the HF service, it DOES load.
I do know that #3788 adds a check to make sure this error doesn't happen, but it should be detecting the 1 GPU on my machine that is allocated to it. The GPU does get successfully allocated, and prevents any other GPU enabled pods from being scheduled.
#3769 is related, but I AM providing a GPU, so the proposed "fix" does not apply here as the root issue seems to be different
I have had successful vLLM runs from a custom vLLM container deployed using a normal k8s deployment (meaning not via KServe)

Environment:

Istio Version: 1.22.3
Knative Version: Not installed (using RawDeployment so doesn't matter)
KServe Version: 0.13.1 (also tried with 0.13.0)
Kubeflow version: N/A
Cloud Environment: Homelab Proxmox
Minikube/Kind version: Custom k3d image that can be found here https://github.com/justinthelaw/k3d-gpu-support
Kubernetes version: (use kubectl version): v1.28.8+k3s1
OS (e.g. from /etc/os-release):

PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

GPUs may be broken in a weird way in my current k8s setup, so please standby as I try to make sure my setup is properly working. I will close this issue if I realize it was an environment issue

I figured out what was wrong. Hopefully this helps someone else in the future.
We changed the way our k3d image handles GPUs, to where the nvidia runtime class was not the default. I had to add the runtimeClassName to the predictor spec. It ended up looking something like this:
apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  name: huggingface-llama2
spec:
  predictor:
    runtimeClassName: nvidia
    model:
      modelFormat:
        name: huggingface
      args:
      - --model_name=llama2
      - --model_id=meta-llama/Llama-2-7b-chat-hf
      env:
        - name: HF_TOKEN
          valueFrom:
            secretKeyRef:
              name: hf-secret
              key: HF_TOKEN
              optional: false
      resources:
        limits:
          cpu: "6"
          memory: 24Gi
          nvidia.com/gpu: "1"
        requests:
          cpu: "6"
          memory: 24Gi
          nvidia.com/gpu: "1"

This example is my llama 2 example instead of the llama 3 example, but the principle is the same


F11 to enter or exit fullscreen

[Enter feedback here]
I think it's actually F11 to exit fullscreen mode. not alt+shift+enter

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 68544507-42a5-6364-b7e2-17115bd5c88d
Version Independent ID: e588245e-c033-32a1-18b8-8bb81d7461fe
Content: Full screen and virtual space mode - Visual Studio
Content Source: docs/ide/how-to-manage-editor-modes.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@albertrw83 Unfortunately, I cannot reproduce the behavior you describe by pressing F11. Only Alt+Shift+Enter works to enter or exit full screen mode. Visual Studio reserves the F11 function key for debugging or build actions (see the Default keyboard shortcuts in Visual Studio page for more details).
Perhaps you've reassigned the F11 keyboard shortcut previously? See the Identify and customize keyboard shortcuts in Visual Studio page for more details about how to do (or undo) that.
We'll close this issue now as "non-repro", but we do appreciate you taking the time to give us feedback. We hope you'll reach out again if you have suggestions on how we can improve our documentation.

@albertrw83 Unfortunately, I cannot reproduce the behavior you describe by pressing F11. Only Alt+Shift+Enter works to enter or exit full screen mode. Visual Studio reserves the F11 function key for debugging or build actions (see the Default keyboard shortcuts in Visual Studio page for more details).
Perhaps you've reassigned the F11 keyboard shortcut previously? See the Identify and customize keyboard shortcuts in Visual Studio page for more details about how to do (or undo) that.
We'll close this issue now as "non-repro", but we do appreciate you taking the time to give us feedback. We hope you'll reach out again if you have suggestions on how we can improve our documentation.


Add support for prefetch_rows and prefetch_memory

Hello,
First of all, I would like to thank you for this awesome module ! It's so nice to be able to query Oracle databases without any extra dependency :)
I'm using this module for a project and I was wondering if it could be possible to add support for prefetch_rows and prefetch_memory  options that can be usually configured on the connection string :
oracle://user:pass@server/service_name?prefetch_rows=500&prefetch_memory=500

I tried to set those options but I could not notice any difference so I guess it's just not supported (those options do not appear in the connection_string.go file).
I was previously using github.com/mattn/go-oci8 module and with those two options, the performance is really better when fetching a lot of data. I think it can explain why this module can be slow sometimes.
If you don't have time to add support for this, I might be able to make a PR. Let me know :)

hi @rbretecher-fcms
I add prefetch_rows option to the url you can use it now

Thank you very much for this change, this is awesome.
My code is now 50 times faster when fetching a lot of data, from 15 minutes to 20 secondes :rocket:
I think you can close this issue. Keep up the good work :)

Could you please elaborate these parameters in details:

what do they exactly do
what is the recommended input for them
in what unit is prefetch_memory: bytes, kilobytes..?


Update OCP_formulation

Added the last input argument to getHeelstrikeSimulation in case of full gait cycle

Was already fixed and merged into master-dev #64


Changed token for checkout action in deploy-release.yml to bypass rules

This is a small PR to change a token in the deploy-release action, so that the action can commit and push updates to the repo as 'access-bot' bypassing protection rules.

Thank you @CodeGat!
Merged.


Update Schnorr links

It looks like on the official site both Schnorr links lead to a 404 error page due to the missing URLs here.
I hope this helps. :smile:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @D-Squared70, thanks for reporting this! I noticed several other broken links, which I fixed in  https://github.com/trailofbits/zkdocs/pull/12


feat: add asdf support to python + poetry

This PR is not complete! I wanted to get your thoughts on it before putting anymore work into it.
The idea here is to support asdf/.tool-versions for specifying python + poetry versions. This could then
be extended to support node, go, etc in the future but my initial use case is scoped to python.
Interest in this feature being added? If so I can finish implementation + add tests.

bump


[Bug]: cloud-init fails

Description
2024-12-09 09:06:47,387 - subp.py[DEBUG]: Running command ['btrfs', '--version'] with allowed return codes [0] (shell=False, capture=True)
2024-12-09 09:06:47,394 - handlers.py[DEBUG]: finish: init-network/config-resizefs: FAIL: running config-resizefs with frequency always
2024-12-09 09:06:47,394 - util.py[WARNING]: Running module resizefs (<module 'cloudinit.config.cc_resizefs' from '/usr/lib/python3.11/site-packages/cloudinit/config/cc_resizefs.py'>) failed
2024-12-09 09:06:47,394 - util.py[DEBUG]: Running module resizefs (<module 'cloudinit.config.cc_resizefs' from '/usr/lib/python3.11/site-packages/cloudinit/config/cc_resizefs.py'>) failed
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/cloudinit/config/modules.py", line 256, in _run_modules
    ran, _r = cc.run(
              ^^^^^^^
  File "/usr/lib/python3.11/site-packages/cloudinit/cloud.py", line 67, in run
    return self._runners.run(name, functor, args, freq, clear_on_fail)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/cloudinit/helpers.py", line 172, in run
    results = functor(**args)
              ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/cloudinit/config/cc_resizefs.py", line 289, in handle
    resize_cmd = resizer(resize_what, devpth)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/cloudinit/config/cc_resizefs.py", line 79, in _resize_btrfs
    system_btrfs_ver = util.Version.from_str(
                       ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/cloudinit/util.py", line 3185, in from_str
    return cls(*(list(map(int, version.split(".")))))
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '1\n-EXPERIMENTAL -INJECT -STATIC +LZO +ZSTD +UDEV +FSVERITY +ZONED CRYPTO=builtin'
2024-12-09 09:06:47,396 - modules.py[DEBUG]: Running module mounts (<module 'cloudinit.config.cc_mounts' from '/usr/lib/python3.11/site-packages/cloudinit/config/cc_mounts.py'>) with frequency once-per-instance

The cloud-init service fails for me, apparently btrfs --version returns unparseable output (more than just a version number). The upstream bug is here https://github.com/canonical/cloud-init/issues/5614.
Apparently we use /usr/bin/cloud-init 23.3-13.1 at the moment.
Kube.tf file
Happens on a default configuration.

Screenshots
No response
Platform
Linux

Can confirm, we have nearly the same issue. I will investigate a work around.

@nikolaszimmermann
Do you know of any workaround for this? It sounds like deploying new kube-hetzner nodes with a current MicroOS image is not possible today. Am I right?
The corresponding issue in the SuSE bugzilla is still in status NEW: https://bugzilla.suse.com/show_bug.cgi?id=1229340


JQuery UI Dialog refactoring

Refactored JQueryUI dialogs.
Removed Pluggable Web Views.
Fixed CheckboxWebView to support changes to model.

Fixes #30 and #21

Coverage increased (+1.0%) to 82.35% when pulling 4d31f968bb39a9a3bbbb00cad65fafb2603b3a57 on jquery_ui_dialog_refactoring into e7a51685149dbf1488f077b4f57629868ab4146c on master.


No documentation on deploying to Vercel

I found this template from the vercel template page.  I cloned the repo and set up locally, but how do I deploy to vercel?  If I try to set it up from the template page, it says I need to add my environment variables first.  But how do I do that if my backend is not setup yet?

There is no auto deploy option for Strapi on Vercel. You have to deploy you Strapi application separately.
You can use Render, Digital Ocean or even Strapi Cloud as outline here
And after wards you would deploy your Next JS application to Vercel.  As explained here

@PaulBratslavsky Quick question what was the point of using a monorepo for both frontend & backend if both can't be deployed together?

@Nazehs just so I can have one repo for the project when working on it. When deploying the app on Vercel I use the same repo but point to frontend, and when deploying the backend on Digital Ocean I use the same repo and point to the backend folder.


[JSDoc] Add missing documentation for botbuilder-dialogs-declarative files

Addresses # 2602
Description
This PR adds the missing documentation in botbuilder-dialogs-declarative library.
Some documentation is ported and adapted from botbuilder-dotnet
Specific Changes

Updated jsdoc/require-jsdoc in .eslintrc.json from warn to error.
Added JSDoc comments in all public methods and classes.

Testing
The following image shows the ESLint Report with no JSDoc errors.

Promoted


Add a .clang-format file

Clang Format is an auto-formatter for C++ source code. As there are a lot of C++ code formatting styles, it lets you customize your formatting with a .clang-format file. I think it would be helpful to add such a file to this repository; that way contributors can autoformat the code they submit to match the style of the repository.

I couldn't  tailor the clang-config to reproduce the same formatting as extists.
Particularily, it is not possible to make a line break after :::
ReturnType
ClassName::
memberFunctionName()
{
    //
}

I can add another config for the uncrustify code formatter

Totally agree with @Quincunx271 !
It'd be nice to have a code style defined in a file shipped with sources! But may be, we could stick to some more traditional styles? Google or Mozilla, may be (those are shipped with clang-format already!)
Also, some .editorconfig would be a great plus too! :)


Fix tasks system (#16668)

(cherry picked from commit 6122f9660700f211376ca9d5ea28153484bd0e45)
PR to main - https://github.com/microsoft/azuredatastudio/pull/16668
This PR fixes https://github.com/microsoft/azuredatastudio/issues/16615

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.704%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26434

Relevant Lines:
57517

💛  - Coveralls


Updating LacpTimer to match Set cmdlet.

Docs Build status updates of commit 1aad4dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/netlbfo/new-netlbfoteam.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[RFC] Add zipWith const or zipWith (flip const) function

Inspired by this blog post:

https://github.com/quchen/articles/blob/master/2018-11-22_zipWith_const.md

And this comment:

https://www.reddit.com/r/haskell/comments/9zf1tj/zipwith_const_is_my_favorite_haskell_function/ea90fqs/

The name of the function is under the question though...

Maybe zipLeft?

@cronokirby Hmm :thinking: I think I might forget the meaning of Left each time I look at this function: does Left stands for taking elements from left list or does Left means that it takes element according to left list?

ZipList already makes this nice via <* and *>, I would suggest instead making ZipList as nice to use as [].

I had the impression that this function is useful. But I haven't used since creating this issue. Also, this function is not that performant since it traverses the list prefix twice. So I propose to not add rarely used and non-optimal functions to the prelude package.


[coap] add length validation to header parsing

Thanks for the fix!
Right now OSS-Fuzz does not precisely compute the fix revision (only a ~1 day revision range).
So, may I ask you to leave comments in the oss-fuzz bug tracker saying something like
fixed by https://github.com/openthread/openthread/commit/e2d027c8a53b42bf5451e8c6fbf1abacd7e73c4a

Also, when possible, please indicate if it was a recent regression or an old bug.


Create IHookMetadata

This Pull Request proposes adding a new interface, IHookMetadata, to the Uniswap V4 Periphery repository. The IHookMetadata interface is designed to provide standardized metadata for hooks, which include information about the audit details and additional metadata. By integrating IHookMetadata, we can create a consistent and transparent way to describe hooks, enhancing both the security and the user experience for developers interacting with Uniswap hooks.
The IHookMetadata interface introduces the following key features:
Audit Metadata: Provides comprehensive information regarding audits conducted on the smart contract.
AuditSummary struct: Contains details such as the auditor's name, the issued timestamp, hashes of the code and audit document, and an audit URI.
Auditor struct: Specifies the audit firm's name, additional URI information, and a list of authors involved in the audit.
EIP-712 Domain Information
The EIP712Domain struct is included to describe the domain for which signatures are generated. This is critical for verifying off-chain signed messages, ensuring consistency and integrity across the Uniswap ecosystem.
Signature Standards:
The SignatureType enum defines multiple signature standards supported, including SECP256K1, BLS, ERC1271, and SECP256R1, which allows the flexibility to adopt different signature approaches as needed by various protocols.
Functions for Metadata Retrieval:
The interface provides several functions for easy retrieval of metadata, such as: name, repository, logoURI, and description: Functions that provide basic descriptive information about the hook.
auditSummary, eip712Domain, and signedAuditSummary: Functions that provide crucial audit and signing information.
By adding IHookMetadata, this interface aims to improve trust in the Uniswap ecosystem through more accessible audit data and standardized metadata for hooks. It would ensure a consistent method of obtaining and verifying metadata and signature information for any hooks that integrate with Uniswap V4.
Motivation
Transparency and Trust: Increasing transparency about hook audits and other metadata contributes to improved trust in the Uniswap ecosystem.
Standardization: A standardized interface for audit information reduces friction for developers seeking to integrate their hooks.
Implementation Notes
This interface is defined to be implemented by any hook used within Uniswap, providing a framework for uniform metadata collection.
Adopting IHookMetadata across hooks will help developers better understand, verify, and use hooks while ensuring they meet established standards.
Conclusion
This PR aims to improve the metadata handling, transparency, and security of hooks in Uniswap V4 by integrating IHookMetadata. We believe this will benefit developers, users, and auditors by providing a clear, accessible, and standardized set of metadata for hooks.
Please let me know if there are any questions or further improvements needed for this interface.

@RostyslavBortman can you give it a filename hah


chore(main): release 2.86.0

:robot: I have created a release beep boop
2.86.0 (2023-11-30)
Features

auth: integrate ldap (#3031) (65f78f7)

Bug Fixes

only run index queries for Postgres DBs (#3055) (7664ea2)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Flagsmith/flagsmith/releases/tag/v2.86.0 :sunflower:


Key error on 4bit dynamic qwq quant

reproduce: uvx --with bitsandbytes --with setuptools vllm serve unsloth/QwQ-32B-Preview-unsloth-bnb-4bit
ERROR 12-04 11:26:27 engine.py:366] KeyError: 'layers.10.mlp.down_proj.weight.absmax'

Will investigate vLLM!

I have the same error when using save_pretrained_merged and push_to_hub_merged
that is the reason why I ended up merging with HF Peft
https://github.com/unslothai/unsloth/issues/1378

@jmparejaz Oh wait you merged to 16bits and it errors out in vLLM?

yes, I used this code to merge the FastLanguageModel finetuned adapter but the model didnt work when trying to deploy with vllm

I had the same issue when using the Docker version. There were two parameters required for BitsAndBytes quantized models:
--load-format → bitsandbytes
--quantization → bitsandbytes
I’m confident that the CLI will work too, as the Docker internally calls the CLI with the same parameters. You need to ensure that the correct parameters are passed when using the CLI.

Ye for BnB loading in vLLM you have to follow https://docs.vllm.ai/en/latest/quantization/bnb.html ie:
from vllm import LLM
import torch
# unsloth/tinyllama-bnb-4bit is a pre-quantized checkpoint.
model_id = "unsloth/tinyllama-bnb-4bit"
llm = LLM(model=model_id, dtype=torch.bfloat16, \
quantization="bitsandbytes", load_format="bitsandbytes")


Feat(README)

Codecov Report

Merging #4 (56a43c6) into main (ac73157) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          131       131
  Branches         5         5
=========================================
  Hits           131       131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac73157...56a43c6. Read the comment docs.


Add audit events for PaymentApprove update

Created from #4525
This covers adding events for PaymentApprove operation
This event should include the payment data similar to PaymentCancel
It should also include any metadata for the event
e.g reason for payment rejection, error codes, rejection source etc
Submission Process:

Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
Once assigned, submit a pull request (PR).
Maintainers will review and provide feedback, if any.
Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

Hey @Jayanth-M0625 There is another issue assigned to you, kindly submit that one so that i can assign another issue to you!

/assign

Hey @paradoxxx09 Assigning this issue to you, Thanks for your interest!

Hey @paradoxxx09
Kindly let us know, if you're still working on the issue? If you have any questions or need assistance, feel free to reach out in the community.

@gorakhnathy7 I would like to take this up. Please assign this to me. Thanks.

@gorakhnathy7 I have started working on this issue. Assign this to me whenever you're available. Thanks,


Update cleanmgr.md

Command is also available in windows 11.

@robinharwood, @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thank you for your contribution @tiagojoaoeckhardt. Made a minor change and this update will be merged shortly.


Support for Spark 2.4.3 and 2.3.3

Two questions (quite urgent for my case - can't use sparklyr ATM due to a CDH upgrade):

does this also work for hadoop 3.0? (the segments in  inst/extdata/versions.json only go up to hadoop 2.7)
would it be possible to release a minor release with this, please please please? (yes, even if there's just been one commit since 1.0.1)

I have a question: does this also work for hadoop 3.0?
The segments in  inst/extdata/versions.json only go up to hadoop 2.7, for all spark versions...


Repeat push 重复推送

你好，我使用官网的例子，成功推送消息到客户端，但是发现会重复推送，我的代码如下：
Hello, I use the official website of the example, the success of the news push to the client, but found that the push will be repeated, my code is as follows:
# bin/ws.php
require dirname(DIR) . '/vendor/autoload.php';
$loop   = React\EventLoop\Factory::create();
$alimama = new WebSocket\Alimama;
$context = new React\ZMQ\Context($loop);
$pull = $context->getSocket(ZMQ::SOCKET_PULL);
$pull->bind('tcp://<IP_ADDRESS>:55556'); // Binding to <IP_ADDRESS> means the only client that can connect is itself
$pull->on('message', array($alimama, 'onRequest'));
// Set up our WebSocket server for clients wanting real-time updates
$webSock = new React\Socket\Server($loop);
$webSock->listen(8080, '<IP_ADDRESS>'); // Binding to <IP_ADDRESS> means remotes can connect
$webServer = new Ratchet\Server\IoServer(
new Ratchet\Http\HttpServer(
new Ratchet\WebSocket\WsServer(
$alimama
)
),
$webSock
);
$loop->run();
===============================
logic:
public function detail(){
echo "商品ID为：".I('get.id');
echo "目标：在client.html页面应该收到此ID";
$data['id'] = I('get.id');
//websocket推送
$lock = "./bin/ws.lock";
if(file_exists($lock)){
$context = new ZMQContext();
$socket = $context->getSocket(ZMQ::SOCKET_PUSH);
$socket->connect("tcp://localhost:55556");
$socket->send(json_encode($data));
}
}

=============================
result：

Thanks!!!

@cboden

When looking at the output of your application are the echo calls being repeated twice as well?


Make optional external routes the only option, forcing plugins to handle missing route bindings

Figured out a way to ship this:

Refactor frontend-plugin-api to always use option return from useRouteRef, for all types of route refs. i.e. every single type of route ref is treated as optional from now in.
Add support for using route refs defined by frontend-plugin-api in core-plugin-api directly
Deprecate useRouteRef and friends in core-plugin-api, point to frontend-plugin-api instead

Closing this since the immediate task is done in #25918. The followup is intended to be a more general core-plugin-api -> frontend-plugin-api migration.


Extend and customize listener behavior

This patch allows listeners to:

be instantiated without binding to the specified port (config option bind_to_port)
have connections that have been redirected via iptables be handled by the
listener associated with the original port rather than the listener
that received the connection request.

Use cases for these changes include:

Funnelling through the proxy connections for an entire range of destination port.
If the proxy has a listener for the original destination port (before the redirect)
it is used, otherwise the listener that received the connection handles it
Transparently proxy connections for an app listening on port X.
The proxy can have an unbound listener for port X and a bound on for port Y.
Connections originally directed to the app on port X are redirected with iptables
to the proxy on port Y. The listener for port Y picks up the connection and hands
it off to the listener for port X.
Neither the app, nor the client, have to be changed or become aware of the presence
of the proxy (except for the different src IP seen by the app).

See https://docs.google.com/document/d/1v870Igrj5QS52G9O43fhxbV_S3mpvf_H6Hb8r85KZLY/
for the entire story

Some examples of the use of SO_ORIGINAL_DST in other proxies for comparison
haproxy:
https://github.com/joyent/haproxy-1.4/blob/master/include/proto/stream_sock.h
squid: https://github.com/schmurfy/squid/blob/a33e4089e463d175014d57afed74d3897a7de02d/src/ip/IpIntercept.cc
redsocks:
https://github.com/darkk/redsocks/blob/master/base.c

@enricoschiattarella at a high level this looks good. I will have some comments but in the meantime can you sign the CLA since that will take a little bit.

SAMPLE USAGE / TESTING
(1) Start simple ncat server on ports 1111 (HTTP) and 2222 (TCP):

while true ; do ncat -l -p 1111 -c 'echo -e "HTTP/1.1 200 OK\n\n Hello from 1111"'; done
ncat -l 2222 -k -c echo "Hello from 2222"

(2) Program iptables to redirect all connections destined to ports 8081 and 8082 to port 12345:

sudo iptables -t nat -I OUTPUT 1 -p tcp --dport 8081 -j REDIRECT --to-port 12345
sudo iptables -t nat -I OUTPUT 1 -p tcp --dport 8082 -j REDIRECT --to-port 12345

(OUTPUT chain only applies to locally-initiated connections)
(3) Start Envoy with below config.

{
"listeners": [
{
"port": 8081,
"bind_to_port": false,
"filters": [
{
"type": "read",
"name": "http_connection_manager",
"config": {
"codec_type": "auto",
"stat_prefix": "ingress_http",
"route_config": {
"virtual_hosts": [
{
"name": "backend",
"domains": ["*"],
"routes": [
{
"timeout_ms": 0,
"prefix": "/",
"cluster": "service1"
}
]
}
]
},
"access_log": [
{
"path": "/tmp/access.envoy"
}
],
"filters": [
{
"type": "decoder",
"name": "router",
"config": {}
}
]
}
}
]
},
{
"port": 8082,
"bind_to_port": false,
"filters": [
{
"type": "read",
"name": "tcp_proxy",
"config": {
"cluster": "service2",
"stat_prefix": "tcp"
}
}
]
},
{
"port": 12345,
"use_original_dst": true,
"filters": []
}
],
"admin": {
"access_log_path": "/tmp/access.envoy",
"port": 8001
},
"cluster_manager": {
"clusters": [
{
"name": "service1",
"connect_timeout_ms": 250,
"type": "strict_dns",
"lb_type": "round_robin",
"hosts": [
{
"url": "tcp://localhost:1111"
}
]
},
{
"name": "service2",
"connect_timeout_ms": 250,
"type": "strict_dns",
"lb_type": "round_robin",
"hosts": [
{
"url": "tcp://localhost:2222"
}
]
}
]
}
}
(4) Use curl to verify that connections established to ports 8081 and 8082 go through the proxy and finally make it to the actual service:

curl  localhost:8081
Hello from 1111
curl  localhost:8082
Hello from 2222

cat /tmp/envoy.access
[2017-01-06T17:40:50.474Z] "GET / HTTP/1.1" 200 - 0 17 3 2 "-" "curl/7.51.0-DEV" "6eb90d05-893d-4561-ba2b-be27ea111e50" "localhost:8081" "tcp://<IP_ADDRESS>:1111"

Note: it is possible for an unbound Envoy listener to use the same port the app is listening on.
In our example, the apps are listening on ports 1111 and 222; Envoy unbound listeners would also listen on 1111 and 2222, so that the proxying is transparent to the client. In that case, however, the iptables rules have to be tweaked, so that when the proxy tries to connect to the app on ports 1111 and 2222,
the connections are not intercepted and redirected back to the proxy.
This can be done by using the "-m owner" iptables option, which excludes connections originating from a process owned by a given UID/GID, using the PREROUTING chain, which is not traversed by locally generated packets, or using iptables MARKS.
More details in the doc referenced in the commit message.

All comments look straightforward except the one about downcasting Listener to ListenerImpl.
Please let me know what is your take on that.
I will fix that and incorporate the others in the meanwhile.

I have implemented the interface for ConnectionHandler and solved the dependency violation between source/common and source/server.
However, I haven't been able to get rid of the downcast from Listener to ListenerImpl in listener_impl.cc.
The options I have considered are:
(1) add the newConnection method defined on the ListenerImpl to the Listener interface
(2) push the job of redirecting a connection to the ConnectionHandler by having a method like ConnectionHandler::redirect(connection, socket_name)
both are reasonable in principle but have the drawback of adding low-level details about the connection (fd, sockaddr, ...) to interfaces.
At this point the best solution seems to be the dynamic_cast<>, so I went with that.
Please let me know if you have other alternatives in mind.
Thanks!

@enricoschiattarella I think you have some other changes in this change. Do you mind merging master or just rebasing and pushing? I can then give it a final pass.

@mattklein123 done. PTAL when you have time. Thanks!

@enricoschiattarella, @mattklein123
The documentation says:

If there is no listener associated with the original destination port,
the connection is handled by the [original] listener that receives it."

What is the desired behavior if the original listener has no filters like in the example above? I would expect the connection to be refused (no port matched from connecting client's perspective), but it seems the TCP connection is opened and then ... nothing.
Should a listener with empty filter list and use_original_dst=true reject TCP connection altogether? Filters array is normally required (since listener configuration doesn't make sense without them) but an empty filter list doesn't throw an error. And in this special case it does make some sense to have no filter's specified since it only serves as a redirect.

@ayj I think this is just a bug in general. If there are no filters, the connection handler should just close the connection. Feel free to fix or please open a GH issue and we can fix.


[WIP]Visualize images without Trainer

This PR provides summary.image method and summary.reporter to visualize images on browser. Current ChainerUI has already provided (undocumented)ImageReporter, the extension collects images cached by summary.image, split register phase and write phase, to reduce file writing cost. In many case, however, registering images and write tend to do in same time such as evaluation time, this design confuses.
Usage
from chainerui import summary
summary.image(x, out_path)
summary.image(x, out_path)

x, x2 are converted as PNG format and show on a browser.

timestamp
image

2018-11-12T12:00:00
[x image]

2018-11-12T12:00:01
[x2 image]

from chainerui import summary
with summary.reporter(out_path) as r:
    r.image(x)
    r.image(x2)

x and x2 are converted as PNG format and show in same row.

timestamp
image_0
image_1

2018-11-12T12:00:00
[x image]
[x2 image]

Pros

more simplified usage
no dependency to Trainer

Cons

epoch and iteration are not set automatically

To deal with Cons. 1, timestamp key is added automatically to distinguish images roughly. Additionally any key-pair discription can be set on the function, like summary.image(x, out_path, epoch=10)

I put quick examples on https://github.com/disktnk/chainerui-demo-20180609/tree/master/vae


Fix conflicts with semver specifications and several bugs.

Fixes problems described in issue #10.
:zap: CAUTION: This is a breaking change! :bomb:
What I changed/fixed:

In order to allow Version to leniently parse invalid (according to semver, at least), yet common versions (and print them back identically to how they were parsed) I added Version.canonicalMinor and Version.canonicalPatch for internal handling.

public var canonicalMinor: Int {
	return self.minor ?? 0
}

I extracted the parsing code into a dedicated VersionParser class, which can now be initialized with a strict flag (false being the default). Again, we don't want to break parsing of semi-valid version strings.

This is a big one. In order to be a valid semantic version it should ignore build in comparisons.
Ignoring build would however lead to unexpected results when comparing “1.0.0+A” and “1.0.0+B”. One would expect these to not be equal.
Then again as long as one cannot guarantee a comparable build number (it might be a partial git commit hash, for which sorting makes no sense whatsoever)
I therefor removed comparison of build from “func<“, "func==“ and “hashValue” and implemented func=== to re-enable equality checks with build:

public func ===(lhs: Version, rhs: Version) -> Bool {
	return (lhs == rhs) && (lhs.build == rhs.build)
}

Fixed.

A nil-value in minor or patch now is considered equal to “0”.

Hey Vincent, sorry that this got stuck here without feedback from me. Finally came around to manually merge it to address some minor style violations. As said already in our mail conversation back then: Excellent work! :+1:

No problem, Marius!
Thanks for merging!


Update README.md: on-the-fly creation

Please @gadicc can you update the README.md file to make it obvious that the .xml files are created on-the-fly during the request by the crawler? Thanks

Yeah, that should be clearer.  Thanks for the feedback.


ByteAddressableBuffer: split up into read-only and mutable variants

ByteAddressableBuffer currently has the major limitation of requiring a &mut [u32] even if it's only used for reading data. This PR should serve as a place for discussion of how to resolve this issue.
My currently proposed solution splits up ByteAddressableBuffer into the read-only variant ByteAddressableBuffer and the mutable variant MutByteAddressableBuffer. This is obviously a breaking change and the names are up for discussion.
I would also like to mention @eddyb's comment in https://github.com/EmbarkStudios/rust-gpu/pull/1014 about adding TypedBuffer:

TODO(@eddyb): add changelog, tests, discuss UntypedBuffer (TypedBuffer<[u32]> wrapper), maybe deprecate ByteAddressibleBuffer (to rename it to ByteAddressibleView or something? unsure what's best here)

Does this have any effect on the shader side of things? It seems like a CPU-only change, as from my reading ByteAddressableBuffer is a type used to help collect and marshal data over to the GPU. My guess is that a shader wouldn't use this type directly?

Not at all.
ByteAddressableBuffer is a shader-only thing and allows you to read and write arbitrary types at arbirary offsets from &[u32] slices, usually backed by storage buffers. Now you can't directly declare a ByteAddressableBuffer as a storage buffer (afaik), so you instead declare a &[u32] as a storage buffer and use the ByteAddressableBuffer to view it and do your reads/writes.
Note however that you can only read and write structs with a minimum alignment of 4 bytes (both as struct alignment and offset), so technically it's a WordAddressableBuffer, but ByteAddressableBuffer is what HLSL calls them.

Got it. So then I am interested in this for crabslab, though I'm not sure if crabslab could benefit from switching to using ByteAddressableBuffer. It currently uses a series of index_unchecked into the &[u32], driven by a derivable trait.

Just spit-balling here, but if we're going to break backwards compatibility, we could define the type as:
pub struct ByteAddressableBuffer<T> {
    inner: T
}

impl<'a> ByteAddressableBuffer<&'a [u32]> {
    pub fn from_slice(s: &'a [u32]) -> Self {
        Self{inner: s}
    }

    pub fn load<T>(&self, byte_index: u32) -> T {
        todo!()
    }
}

impl<'a> ByteAddressableBuffer<&'a mut [u32]> {
    pub fn from_mut_slice(s: &'a mut [u32]) -> Self {
        Self{inner: s}
    }
    pub fn store<T>(&mut self, byte_index: u32, t: T) {
        todo!()
    }
}

That would cut out the new type and make fixing the callsites a bit easier, but it also makes discovering what ByteAddressableBuffer does if you're uninitiated (like me)...

I've actually thought about such a design already, but didn't knew how to express it properly in rust. Got stuck on trying to express it as ByteAddressableBuffer<[u32]> and ByteAddressableBuffer<mut [u32]>, but using the reference and lifetime like that really nice!

@Firestar99 Yes, those functions would have to be defined in both impls. But it might be nice then to add an as_ref function to ByteAddressableBuffer<&mut [u32]> to make proxying to the non-mutable buffer easier:
pub struct ByteAddressableBuffer<T> {
    inner: T,
}

impl<'a> ByteAddressableBuffer<&'a [u32]> {
    pub fn from_slice(s: &'a [u32]) -> Self {
        Self { inner: s }
    }

    pub fn load<T>(&self, byte_index: u32) -> T {
        todo!()
    }
}

impl<'a> ByteAddressableBuffer<&'a mut [u32]> {
    pub fn from_mut_slice(s: &'a mut [u32]) -> Self {
        Self { inner: s }
    }

    pub fn store<T>(&mut self, byte_index: u32, t: T) {
        todo!()
    }

    /// Create a non-mutable `ByteAddressableBuffer` from this mutable one.
    pub fn as_ref(&self) -> ByteAddressableBuffer<&[u32]> {
        let buffer: ByteAddressableBuffer<&[u32]> = ByteAddressableBuffer { inner: self.inner };
        buffer
    }

    pub fn load<T>(&self, byte_index: u32) -> T {
        self.as_ref().load(byte_index)
    }
}

#[cfg(test)]
mod test_buffer {
    use super::*;

    #[test]
    fn buffer() {
        let mut slab = [0u32; 36];
        let mut buffer_mut = ByteAddressableBuffer::from_mut_slice(&mut slab);
        buffer_mut.store(0, Some(123u64));
        let _maybe_u64: Option<u64> = buffer_mut.load(0);
    }
}

Added :heart:
This makes it pretty much feature complete, and ready for review. Changelog is added as well.

Added :heart:
This makes it pretty much feature complete, and ready for review. Changelog is added as well.


Factory ModuleNotFound errors when generating individual ALL_ASSETS

Describe the bug
Running individual asset generation with ALL_ASSETS results in ModuleNotFoundError for some factory classes.
Steps to Reproduce
python -m infinigen_examples.generate_individual_assets --output_folder ~/infinigen_outputs/ -f SingleCabinetBaseFactory -n 1 --render image --export fbx

What version of the code were you using?
v1.4.0, fb7991e06580639202a4687937082cb63e931eb0
What are your FULL output logs?
Traceback (most recent call last):
  File "~/.conda/envs/infinigen/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "~/.conda/envs/infinigen/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "~/infinigen/infinigen_examples/generate_individual_assets.py", line 514, in <module>
    main(args)
  File "~/infinigen/infinigen_examples/generate_individual_assets.py", line 416, in main
    mapfunc(build_and_save_asset, targets, args)
  File "~/infinigen/infinigen_examples/generate_individual_assets.py", line 349, in mapfunc
    return [f(i) for i in its]
  File "~/infinigen/infinigen_examples/generate_individual_assets.py", line 349, in <listcomp>
    return [f(i) for i in its]
  File "~/infinigen/infinigen_examples/generate_individual_assets.py", line 196, in build_and_save_asset
    asset = build_scene_asset(args, factory_name, idx)
  File "~/infinigen/infinigen_examples/generate_individual_assets.py", line 65, in build_scene_asset
    raise ModuleNotFoundError(f'{factory_name} not Found.')
ModuleNotFoundError: SingleCabinetBaseFactory not Found.

Platform

OS & OS Version:  Linux

Additional context
Seems to be that certain __init__.py files are missing some factory classes. e.g. SingleCabinetBaseFactory is missing in infinigen/assets/shelves/__init__.py

Should be resolved by #280, please update to v1.5.1


x11docker/check - unmet dependencies:  kaptain ...

Hi, noob here.
I am trying to run x11docker as an unprivileged user and can't even get x11docker/check to run:
docker pull x11docker/xserver
Using default tag: latest
latest: Pulling from x11docker/xserver
Digest: sha256:1912e7fbeaac53fa2cf4c73d32c9397792de94f38503ccfed83f124869368c72
Status: Image is up to date for x11docker/xserver:latest
docker.io/x11docker/xserver:latest

x11docker --verbose --build x11docker/check

...

The following packages have unmet dependencies:
 kaptain : Depends: libqt4-qt3support (>= 4:4.5.3) but it is not installable
           Depends: libqtcore4 (>= 4:4.5.3) but it is not installable
           Depends: libqtgui4 (>= 4:4.5.3) but it is not installable
E: Unable to correct problems, you have held broken packages.
The command '/bin/sh -c curl http://ftp.us.debian.org/debian/pool/main/k/kaptain/kaptain_0.73-2_amd64.deb -o /opt/kaptain.deb &&     cd /opt &&     env DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends ./kaptain.deb' returned a non-zero code: 100

x11docker ERROR: Option --build: Building image 'x11docker/check' failed.

I tried to figure out what kaptain was and why it was failing, but am just confused by messages like this:
https://github.com/mviereck/x11docker/blob/2c61c100bd17026ce75b9d08dd876e28acbc3309/CHANGELOG.md?plain=1#L131

Thank you for the report!
Just to clarify: If you have pulled image x11docker/check, you don't need to also build it with x11docker --build.
You can just run it with x11docker x11docker/check.
About the issue with x11docker --build x11docker/check: Accidentely I forgot to update the Dockerfile. It fails to build with image debian bullseye but needs the previous release debian buster. I've uploaded a fixed Dockerfile yet. kaptain fails to install on debian bullseye.
However, building with x11docker --build x11docker/check still fails because the image uses several additional files added with aCOPY instruction that are not regarded yet by x11docker. I'll have to fix that.
x11docker-gui was a GUI frontend for x11docker that I have deprecated. It is not related to image x11docker/check.


feat(lnd): update lnd to v0.5-beta

Description:
Lightning Labs have re-released v0.5-beta to include some critical fixes missing from the original  v0.5-beta release.
Motivation and Context:
Update our lnd to the current official release.
How Has This Been Tested?
Manually test app.
Types of changes:
Dependency update
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 16.201% when pulling b37daf2912c4bb93d9e4bc642af5b767574cad35 on mrfelton:chore/update-lnd-0.5-beta into cf53d926339458b0fc9d5f6d4c4b8e09cf7859a2 on LN-Zap:master.

Actually, I forgot that we can't use the official release as we need it compiled with experimental flags.
We will need to create a new release of our own using using the scripts provided in https://github.com/LN-Zap/zap-desktop/pull/759

@JimmyMow I've created a new signed release here https://github.com/LN-Zap/lnd/releases/tag/v0.5-beta-21-g25145acc and updated package.json to reference that.

Tested ACK a5f4960


Allow to embed third party websites via iFrame or simular

As an editor I want to be able to embed html from external systems, e.g. a status table or simular. This could be implented by allowing the usage of an <iframe> HTML Tag
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
0 to 6 months
Additional context
No response

Hi @saerdnaer,
This should already be possible using the media button when using the WYISWYG editor:

You may need to adjust this security setting (Iframe Source Control) to allow the remote host to be embedded within the BookStack UI (And the host must not prevent embedding).

Since there's been no follow-up I'm going to close this. If you need further guidance just respond to my previous comment and this can then be re-opened.


Support stamping

For example, update the version field in package.json before publishing.

probably blocked on https://github.com/aspect-build/bazel-lib/issues/185 so we can use the same config_setting machinery

https://github.com/aspect-build/bazel-lib/issues/185 landed


Precomputed index is returning no results. Different usage maybe?

Describe the bug
Empty results when loading precomputed index.
Version
6.4.3
Is this a regression?
dunno
🔬Minimal Reproduction
const Fuse = require('fuse.js');
const fs = require('fs');

const search_options = {
  includeScore: true,
  useExtendedSearch: true,
  keys: ['title']
}

callback = function(err) {
  if (err) throw err;
  console.log('Write complete');
};

const datasets = [{"title":2},{"title":3}];
var myIndex = Fuse.createIndex(search_options.keys, datasets);

fs.writeFile('./index.json', JSON.stringify(myIndex.toJSON()), callback);

//var myIndex = Fuse.parseIndex('./index.json');

const fuse = new Fuse(datasets, search_options, myIndex);

var search_term = process.argv[2];
var result = fuse.search(search_term);
console.log(result);
console.log(myIndex);

Additional context
The last print shows that docs, keys, records is empty, if loaded from the precomputed index.

:bump:

I'm seeing this same issue in 6.5.3. I can't get Fuse to work using a precomputed index. Works fine when doing const fuse = new Fuse(json, options);


branch name in the metadata

Hi
It would be quite useful if there could be a possibility to have a branch name somewhere in the metadata as well.
For not breaking back compatibility, it could be implemented as a placeholder for a custom format (for example x.y.z+b-m)

Could you give an example in which situations this would be helpful?

IHMO this could be useful when using git-semver for determine the tag of a docker image.

User story 1:

as a developer, I want to be able to deploy bugfix/feature/other branch on Test environment temporarily (and not, let's say usual  e.g. main branch)
as a devops engineer,  I thus must create artifacts (Docker Image / Helm Chart) that can not overlap with versions generated on main, and are easily traced back (SHA is not good enough here).

So I write function, that adds branch name to the Docker/Helm tag. Now artifacts are uniquely and easily identified at all times - if I decide to publish/deploy it, or not.
getDockerImageTags.groovy:
def call(String appVersion) {
    // Docker tags are not compatible with semver (+ sign): https://github.com/distribution/distribution/issues/1201
    env.BRANCH_NAME_SANITIZED = env.BRANCH_NAME.replaceAll('[^a-zA-Z0-9_.-]', '-')
    println "env.BRANCH_NAME_SANITIZED = $env.BRANCH_NAME_SANITIZED"
    env.APPVERSION_SANITIZED = appVersion.replaceAll('[^a-zA-Z0-9_.-]', '-')
    println "env.APPVERSION_SANITIZED = $env.APPVERSION_SANITIZED"

    Map dockerTags = [:]

    if (env.BRANCH_NAME in ['main', 'master'] || git.tagIsSemVer2() ) {
        // this logic is later repeated for deployment
        dockerTags['versionTag'] = env.APPVERSION_SANITIZED
        dockerTags['latestTag'] = 'latest'
    } else {
        // optionally deployed to optionally deploy code various branches
        dockerTags['versionTag'] = "$env.APPVERSION_SANITIZED-$env.BRANCH_NAME_SANITIZED"
        dockerTags['latestTag'] = "latest-$env.BRANCH_NAME_SANITIZED"
    }
    currentBuild.displayName += " 🐳 ${dockerTags['versionTag']}"
    println "Tags auto-generated based on branch: $dockerTags"
    return dockerTags
}

The code above, includes logic, that sometimes ADD branch name, sometimes NOT (if it is main branch).
However I see myself removing this abstraction, and add branch name to version at all times, if git-semver would support it.