Ciab.ssl.lock.fix

What does this PR (Pull Request) do?

There is an intermittent race condition it seems with regard to our TO API and TP UI tests and how the required CIAB environment comes up in a clean checkout with no modifications.

[x] This PR fixes #3486

Which Traffic Control components are affected by this PR?

CDN in a Box

What is the best way to verify this PR?

Run the TO API tests or the TP UI tests.
If this is a bug fix, what versions of Traffic Ops are affected?

master
3.0.0
3.0.1 (RC1)

The following criteria are ALL met by this PR

[ ] This PR includes tests OR I have explained why tests are unnecessary
[ ] This PR includes documentation OR I have explained why documentation is unnecessary
[ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[ ] This PR includes any and all required license headers
[ ] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3521/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3522/
Test PASSed.


Add dependency on rresult.

Missing dependency on rresult in the dream-mirage library.
https://github.com/aantron/dream/blob/master/src/mirage/mirage.ml#L20

Thank you!


Redirects are being followed with the wrong signature

minio-go will follow redirects, but the signature is invalid since the canonical string includes the original Host.  This will return mismatched signatures error by the server, failing the request.
PR to follow.

Fixed by #829


issue templates created

issue templates created newly for keras-team/keras repo to categorize keras issues with different labels

I believe this PR should be merged directly rather than via Copybara.

Please resolve the conflicts @jvishnuvardhan:
Conflicting files
.github/ISSUE_TEMPLATE/10-feature-request.md
.github/ISSUE_TEMPLATE/20-documentation-issue.md

@jvishnuvardhan  Can you please resolve conflicts? Thanks!

I am closing this as this was done through a CL. Thanks!


Status codes from GES do not always indicate what they are interpreted as

My cluster entered a state where it would reject all writes that wound up getting routed to a slave via DNS (which was "fun") and they return 400 Bad Request, which is then interpreted as WrongExpectedEventNumber - probably because the documentation is incomplete.
I described it here: https://groups.google.com/forum/#!topic/event-store/LE473sLEk_c
There is also a case pretty often where I get a 307 in response to a write while my cluster is in an error state.  No clue why.
So I think we need to do some more parsing of the responses, and can't rely on status codes.  Sadly.

Thanks for your last PRs ;) I will take a look on this issue and create ticket in our TODO list ;)


create the db on oragono run if it doesn't exist?

Inspired by a bug report on freenode: "Hi there, I'm getting this error when I start my new oragono irc server https://pastebin.com/ZBJTL8NB"
Is there any problem with just creating the database automatically in this situation? Seems akin to #243.

Hi there,
that was me asking about that on freenode: just had to use  oragono initdb
Kind Regards
nzde


Fix social auth for Google

Google was expecting the redirect_uri to be an https: URL.
We need to set SOCIAL_AUTH_REDIRECT_IS_HTTPS = True on servers
to make that happen.

:+1:


fix: panic in update_gateway_cache if called concurrently

CI failing :(

changed to mutex, maybe that will fix ci

typo fix, it is so hard to spell guard

Beautiful abstraction!


Contributing 404 link fix

Staging is no longer a valid branch but the markdown file for contributing is on the master branch.

Duplicate of #312


Bug: light mode unavailable

@srevinsaju Thank you for providing these AppImages; your work is sincerely appreciated!
I have the reverse problem to Bugfix: dark mode broken for settings when strict fingerprinting in v1.31.58 in which there is no brave://settings/appearance setting for theme; the app runs in dark mode -- loved by some but disliked by others -- and cannot be changed.

@mj162 Weird, I cannot reproduce. locally, I am able to switch between light mode and dark mode. Looks like there is some problem with the local configuration (~/.config)

Having a similar problem, changing theme or light/dark status only changes header/banner area, everything below the bookmarks line is stuck in dark mode.

@srevinsaju, just seen @jshroads's post reporting the same problem.  To clarify, intentionally run all browsers in Guest/Incognito/Private mode.  Therefore the reported behaviour is when the config is set to launch Brave in Guest mode.
(There is no brave://settings/appearance setting for theme in Guest mode in v1.31.58, v1.33.85 or v1.35.89.)
I am launching with a 'clean' ~/.config/brave since $HOME is exported in the launcher as /tmp/$USER:-
$DBUS "$exe" --no-default-browser-check --enable-ftp  --enable-site-settings \
             --guest --homedir="$HOME" --profile-directory="$HOME" --user-data-dir="$HOME" \
             --force-device-scale-factor=$QT_SCALE_FACTOR --window-size=940,1280 \
             --window-position=1200,200 --homepage https:/lite.duckduckgo.com/lite "$@" > /dev/null 2>&1 &

TIA.


Questions about the model weight file

Hello. Your work is great!
Can you provide the training weights of the model for accurate testing?

Hi, we've already update the code file and fix the bug! And the checkpoints will be released soon through Google Drive.

okay, thanks! Waiting for it.

Hi, you can download the weights now!

Thank you very much!

hey, we find that the .pth files for RGB-D and RGB-T are same (i.e., rgb-t.pth) in the Baidu link.
Could you please check it?

Sorry, we have fix it, thanks for Comment!


Error in install ipa file

Describe the bug
When I install the ipa file through computer, there comes a error dialog. Then installation failed.
"
file: installation.cpp; line 42 what:
Failed to verify code signature of /private/var/installld.Library.Caches/com.apple.mobile.installd.staging/temp.8Aewku.extracted/Payload.Undecimus.app 0xe8008016(The executable was signed with invalid tntitlements.)
"
Screenshots
If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

iOS Version:    12.1.1
iOS Device:  ipad pro 10.5
unc0ver Version: b45

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

did you solve this problem?

Same error. Tried different apple id, revoked certificates, deleted apple id in impactor, reinstalled updated impactor.


Notifications Configs + Doc

Summary of Changes
The main purpose of this PR is to add both Flask and AppConfig variables related to the mail client features. Since these features are optional, they should be disabled by default and have appropriate configuration variables to turn them on/off.

Added a NOTIFICATIONS_ENABLED config variable. If set to False, send_notification() will not execute and return a 202 response.
Added a MailClientFeaturesConfig on the AppConfig for enabling both the feedback UI and notifications UI.
Created utility methods in config-utils for accessing the aforementioned application configuration variables.
Applied the utility methods throughout the application to hide/show UI related to either feedback or notifications.

This PR also includes cleanup for the following previously existing issues:

Cleaned up the action logging of updating the table owner in /api/metadata/v0.py. We do not need the logging method to execute any logic related to the request. In addition were not passing the status_code from the request back with the response.
The status-message style on the FeedbackForm was getting applied to the OwnerEditor component. Re-nested some styles for these components so that they would only apply within their respective components

Tests
TODO
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

Codecov Report

Merging #291 into amundsen-notifications will increase coverage by 3.58%.
The diff coverage is 90%.

@@                    Coverage Diff                     @@
##           amundsen-notifications     #291      +/-   ##
==========================================================
+ Coverage                   72.39%   75.97%   +3.58%
==========================================================
  Files                         142       26     -116
  Lines                        3756     1149    -2607
  Branches                      479       97     -382
==========================================================
- Hits                         2719      873    -1846
+ Misses                       1003      246     -757
+ Partials                       34       30       -4

Impacted Files
Coverage Δ

amundsen_application/config.py
100% <100%> (ø)
:arrow_up:

...undsen_application/api/utils/notification_utils.py
100% <100%> (ø)
:arrow_up:

amundsen_application/api/metadata/v0.py
74.71% <84.61%> (+0.14%)
:arrow_up:

...ication/static/js/components/common/Tabs/index.tsx

...ndsen_application/static/js/ducks/search/api/v0.ts

...ion/static/js/components/PreferencesPage/index.tsx

...mponents/PreferencesPage/PreferenceGroup/index.tsx

...ication/static/js/components/common/Flag/index.tsx

...ts/common/ResourceListItem/TableListItem/index.tsx

...sen_application/static/js/ducks/allTags/reducer.ts

... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f851c0...cddb62a. Read the comment docs.


Can't get it to read a csv

Typed in
pd.read_csv('Department_of_Recreation_and_Parks_Facility_and_Park_Information.csv')
and get this back:
-bash: syntax error near unexpected token `'Department_of_Recreation_and_Parks__Facility_and_Park_Information.csv''
The file exists in the folder

more info:
Traceback (most recent call last):
File "", line 1, in
File "/Users/Nick_Muzzo/anaconda/envs/test.py/lib/python2.7/site-packages/pandas/io/parsers.py", line 474, in parser_f
return _read(filepath_or_buffer, kwds)
File "/Users/Nick_Muzzo/anaconda/envs/test.py/lib/python2.7/site-packages/pandas/io/parsers.py", line 250, in _read
parser = TextFileReader(filepath_or_buffer, **kwds)
File "/Users/Nick_Muzzo/anaconda/envs/test.py/lib/python2.7/site-packages/pandas/io/parsers.py", line 566, in init
self._make_engine(self.engine)
File "/Users/Nick_Muzzo/anaconda/envs/test.py/lib/python2.7/site-packages/pandas/io/parsers.py", line 705, in _make_engine
self._engine = CParserWrapper(self.f, **self.options)
File "/Users/Nick_Muzzo/anaconda/envs/test.py/lib/python2.7/site-packages/pandas/io/parsers.py", line 1072, in init
self._reader = _parser.TextReader(src, **kwds)
File "pandas/parser.pyx", line 350, in pandas.parser.TextReader.cinit (pandas/parser.c:3173)
File "pandas/parser.pyx", line 594, in pandas.parser.TextReader._setup_parser_source (pandas/parser.c:5912)
IOError: File Department_of_Recreation_and_Parks_Facility_and_Park_Information.csv does not exist

I'm not sure it's clear what directory you are in.  Try providing the full path to your file when calling read_csv.

Tried that and it still gives me the same traceback

also it won't recognize this line: import matplotlib.pyplot as plt

Pls provide your directory structure, then try:
import os
os.getcwd()
# your current working directory will be displayed
os.path.exists('Department_of_Recreation_and_Parks__Facility_and_Park_Information.csv')
# Must be True, otherwise it is unrelated to pandas

Not sure why you're caring matplotlib. If you trying a script taken from somewhere, you can attach the link.

/Nick_Muzzo/Downloads is where it lives. As for the matplotlib bit, it was what the script required.

The file tries is this CSV, correct?

https://catalog.data.gov/dataset/department-of-recreation-and-parks-facility-and-park-information-e7cff

The CSV file is: 'Department_of_Recreation_and_Parks__Facility_and_Park_Information.csv'
And your error says:
IOError: File Department_of_Recreation_and_Parks_Facility_and_Park_Information.csv does not exist

Maybe filename is incorrect? (2 underscores between "Parks" and "Facility")

Oh God, really? SMH. Thanks

NP:)

I am getting this error when i am trying to get to read the CSV file. Kindly help.

import pandas as pd
df= pd.read_csv('FBI-CRIME11.csv')
Traceback (most recent call last):
File "", line 1, in
File "/Users/ajinkyasirsikar/anaconda/envs/py35/lib/python3.5/site-packages/pandas/io/parsers.py", line 491, in parser_f
return _read(filepath_or_buffer, kwds)
File "/Users/ajinkyasirsikar/anaconda/envs/py35/lib/python3.5/site-packages/pandas/io/parsers.py", line 268, in _read
parser = TextFileReader(filepath_or_buffer, **kwds)
File "/Users/ajinkyasirsikar/anaconda/envs/py35/lib/python3.5/site-packages/pandas/io/parsers.py", line 583, in init
self._make_engine(self.engine)
File "/Users/ajinkyasirsikar/anaconda/envs/py35/lib/python3.5/site-packages/pandas/io/parsers.py", line 724, in _make_engine
self._engine = CParserWrapper(self.f, **self.options)
File "/Users/ajinkyasirsikar/anaconda/envs/py35/lib/python3.5/site-packages/pandas/io/parsers.py", line 1093, in init
self._reader = _parser.TextReader(src, **kwds)
File "pandas/parser.pyx", line 350, in pandas.parser.TextReader.cinit (pandas/parser.c:3229)
File "pandas/parser.pyx", line 583, in pandas.parser.TextReader._setup_parser_source (pandas/parser.c:6042)
OSError: File b'FBI-CRIME11.csv' does not exist

You need to provide the full path to the file not just the name.

okay so instead of just mentioning 'FBI-CRIME11.csv' in "df= pd.read_csv('FBI-CRIME11.csv')" i have to mention the full path inside the quotes?

Yes...df = pd.read_csv('/example/path/FBI-CRIME11.csv')

Wow awesome thanks a lot @rockg. it worked!!!

Traceback (most recent call last):
File "D:/competitions/image/funs.py", line 6, in
data=pd.read_csv("D:\competitions\image\train.csv")
File "C:\Users\varun\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pandas\io\parsers.py", line 678, in parser_f
return _read(filepath_or_buffer, kwds)
File "C:\Users\varun\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pandas\io\parsers.py", line 440, in _read
parser = TextFileReader(filepath_or_buffer, **kwds)
File "C:\Users\varun\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pandas\io\parsers.py", line 787, in init
self._make_engine(self.engine)
File "C:\Users\varun\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pandas\io\parsers.py", line 1014, in _make_engine
self._engine = CParserWrapper(self.f, **self.options)
File "C:\Users\varun\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pandas\io\parsers.py", line 1708, in init
self._reader = parsers.TextReader(src, **kwds)
File "pandas_libs\parsers.pyx", line 384, in pandas._libs.parsers.TextReader.cinit
File "pandas_libs\parsers.pyx", line 695, in pandas._libs.parsers.TextReader._setup_parser_source
FileNotFoundError: File b'D:\competitions\image\train.csv' does not exist
i am too getting an error like this please me i think it is due to the pandas module what should i do?


CSUB-479: Compare current release metadata w/ mainnet/testnet

and store the results as CI artifacts for future examination
Description of proposed changes:
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #1005 (ce50a45) into dev (734489a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1005   +/-   ##
=======================================
  Coverage   78.15%   78.15%
=======================================
  Files          76       76
  Lines       11476    11476
=======================================
  Hits         8969     8969
  Misses       2507     2507

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Move leex to heex, extra update to new Heex

Updating all leex and ex file to new Phoenix LiveView.

I found a bug which we need to fix this to continue this issue
https://github.com/phoenixframework/phoenix_live_view/issues/1738


Update delete-rgs.azcli

Added alternative query to show example of specifying a specific tag key/value ( actually used this recently! 😄 )

Thanks @jesseloudon


witadmin

On other URL(https://docs.microsoft.com/en-us/azure/devops/reference/witadmin/witadmin-customize-and-manage-objects-for-tracking-work?view=tfs-2018) it is written that :
The witadmin command-line tool is not supported on Azure DevOps Services. Instead, you use inherited processes.
But here it says it is supported.
My witadmin is not working for Azure DevOps project. Please confirm.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b7617be-b5a7-5e1c-873d-e541e9382376
Version Independent ID: 3c286b88-d74f-88eb-0b6d-aa2388f1643b
Content: Customize the layout of the work item web form - Azure DevOps & TFS
Content Source: docs/reference/customize-wit-form.md
Product: devops
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@nirnaybansal - Apologies for any confusion. The witadmin tool is not supported in anyway on Azure DevOps Services (formerly known as Visual Studio Team Services). I'm updating the topic to reflect this to make more clear.


BUG: Memory leak in _superluobject.c when ENUM_CHECK is not used (static analyzer report)

There are many cases in this file, we only show an example reported by our analyzer in function trans_cvt.

Call macro ENUM_CHECK_INIT.
https://github.com/scipy/scipy/blob/8627df31ab07d66b438c7e5d5880e3f4d435f248/scipy/sparse/linalg/_dsolve/_superluobject.c#L910

A new reference is returned and assigned to tmpobj.
https://github.com/scipy/scipy/blob/8627df31ab07d66b438c7e5d5880e3f4d435f248/scipy/sparse/linalg/_dsolve/_superluobject.c#L817

Assume tmpobj is not NULL.
https://github.com/scipy/scipy/blob/8627df31ab07d66b438c7e5d5880e3f4d435f248/scipy/sparse/linalg/_dsolve/_superluobject.c#L818

Assume taking the true branch.
https://github.com/scipy/scipy/blob/8627df31ab07d66b438c7e5d5880e3f4d435f248/scipy/sparse/linalg/_dsolve/_superluobject.c#L914

Function returns without decreasing the refcnt of tmpobj.
https://github.com/scipy/scipy/blob/8627df31ab07d66b438c7e5d5880e3f4d435f248/scipy/sparse/linalg/_dsolve/_superluobject.c#L916

Internal Report ID: d8636a

So I did an analysis on my machine. Found that reference count of tmpobj is negative. Very surprising for me. I applied the following diff to SciPy,
diff --git a/scipy/sparse/linalg/_dsolve/_superluobject.c b/scipy/sparse/linalg/_dsolve/_superluobject.c
index 6d07473e7..82914c19c 100644
--- a/scipy/sparse/linalg/_dsolve/_superluobject.c
+++ b/scipy/sparse/linalg/_dsolve/_superluobject.c
@@ -821,6 +821,8 @@ PyObject *newSuperLUObject(SuperMatrix * A, PyObject * option_dict,
     }                                           \
     else if (PyUnicode_Check(input)) {          \
         tmpobj = PyUnicode_AsASCIIString(input);\
+        printf("%d\n", Py_REFCNT(tmpobj));      \
+        printf("%ld\n", Py_REFCNT(tmpobj));      \
         if (tmpobj == NULL) return 0;           \
         s = PyBytes_AS_STRING(tmpobj);         \
     }                                           \

and executed the following code,
import numpy as np
from scipy.sparse import csc_array
from scipy.sparse.linalg import splu

A = csc_array([[1., 0., 0.], [5., 0., 2.], [0., -1., 0.]], dtype=float)
B = splu(A, options={"Trans": "N"})

and got the following output,
-1
4294967295

I am a bit surprised how is this possible. Reference count shouldn't go below 0. :-).

I think there is no point in doing Py_DECREF. May be we should do Py_SET_REFCNT(tmpobj, 0). This will make tmpobj garbage collectable.  Its not needed at all after trans_cvt is complete.

Its same case in linux,
(scipy-dev) czgdp18079@scipy-linux-9:~/Quansight/scipy$ python dev.py python ../debug.py
💻  ninja -C /home/czgdp18079/Quansight/scipy/build -j1
ninja: Entering directory `/home/czgdp18079/Quansight/scipy/build'
[2/2] Generating scipy/generate-version with a custom command
Build OK
💻  meson install -C build --only-changed --tags
runtime,python-runtime,tests,devel
Installing, see meson-install.log...
Installation OK
-1
4294967295

Same code and diff as in https://github.com/scipy/scipy/issues/16234#issuecomment-2533817282
tmpobj is not needed after trans_cvt, its an argument processing function I think. So, setting reference count of tmpobj to 0 should be safe. That should fix the memory leak also. tmpobj is converted to s via PyBytes_AS_STRING. After this, tmpobj can be garbage collected safely because whatever we need is now in s. I can set it to 1 but<PHONE_NUMBER> (basically -1, since its stored in unsigned type so that's why its such a large number). However, that would leak memory because tmpobj is not needed after we have s.
Would like to what other folks think on it.
cc: @rgommers @Snape3058

But setting the refcnt directly to zero will not trigger the automatic object destruction. If the object is no longer used, we can manually destruct it instead of setting its refcnt, as it is not safe to set the refcnt due to the chances of leading to a use-after-free problem.

I see. I will check about it. Make a PR also. Thanks for the idea.


Optimization: cache past key-values

This needs to go hand in hand with changes to the conversion process in exporters and transformers-to-coreml.

Caching and latency issues with memory of the models is key. Found this in coremltools docs:
"Impact on Latency and Compute Unit Considerations
For a model that is primarily running on the Neural Engine, sparsity typically helps in improving latency. Firstly, it reduces the amount of weight memory to be loaded at inference time, which is beneficial for networks that are weight memory bound (note that starting from iOS17/macOS14, for ops running on the Neural Engine, sparse weights are decompressed at prediction time). In addition to that, when a relatively long string of consecutive 0s are encountered, the Neural Engine may also be able to skip computations, thereby reducing the amount of computation as well. This means choosing higher levels of sparsity (e.g. 75% or higher) can lead to more latency gains than lower levels. This also means that choosing a block structured kind of sparsity with larger block sizes may be more beneficial. However, note that it's also relatively harder to preserve accuracy with stricter constraints like larger block size and higher level of sparsity."
For a model that has a lot of linear ops and uses a specific kind of sparsity; that is, n:m such that m is a factor of 16 (such as 3:4, 7:8, 14:16, and so on), it can benefit from the CPU compute unit performance in newer hardware generations, thereby resulting in faster inference
(https://coremltools.readme.io/docs/pruning-overview)
GitHub repo: ml-stable-diffusion. If I am not mistaken utilizes Pruning and Palettization of the model for better interference with apple devices. I believe for Llamav2 we'd use post-training pruning and post-training palettization.
I will be working on this, but some people are faster than me, so figure I would share the information. Will follow up soon with another post.

This issue with caching past key-values also deals with pytorch's dataloader issue https://github.com/pytorch/pytorch/issues/13246 This is happening because of how CPython, Python Multipprocessing, and Pytorch Dataloader works.
Here is a podcast discussing the issue, how it works, and the multiple ways to fix this. https://pytorch-dev-podcast.simplecast.com/episodes/dataloader-with-multiple-workers-leaks-memory
While trying to convert a llama model or any other big model. I believe there are numerous python objects being written to and read while trying to convert these PyTorch models to CoreML. I have tried google cloud, google colab, buying more ram, different LLM sizes. All of these and none of them have worked.
The past key-values as a python list, which pytorch is trying to load from is causing multiple read/writes and then possibly more depending on how coremltools reads each layer from pytorch to convert it to coremltools.
I am going to attempt a making a couple of python lists/dicts into numpy in a couple of places and see how that goes. Hopefully, will not have to convert all lists/dicts in coremltools.

This may help us open the door to implementing similar code to swift-transformers
apple/ml-recurrent-drafter
Even this modeling_llama.py is implementing the split attention layers, redefining states, the four NHWC channels, kv cache and repeat_interleave op.
Wonder if we would be able to take some of this logic and apply to openelm float16 (because of the repeat_interleave op in modeling_llama.py).

modeling_llama.py
modeling_llama_test.py
kv_cache.py

Check out this issue / comment for some more information Convert OpenELM to float16 Core ML


Medium-to-High Energy Impact in Firefox on Linux

Description

The DuckDuckGo Privacy Essentials extension for Firefox 114.0.1 (64-bit) consistently has
a medium-to-high energy impact as reported in the about:performance page.
Steps to Reproduce

Type about:performance in browser;
press enter; and
monitor the energy impact column for this extension.

Expected behavior:

I expect this extension to almost never have an energy impact above low.
Ublock Origin does a tremendous job at this, so it's certainly possible for
this extension to achieve very similar energy-impact characteristics.
Actual behavior:

Firefox consistently reports that this extension has a medium-to-high energy impact.
Versions

Extension: 2<IP_ADDRESS>
Browser: Firefox (64 bit)
OS: Linux

Additional Information

Thanks for this report. We recently shipped a performance improvement to our content-script, which is now available in the latest (2023.9.20) version. Please let us know if you're still observing these warnings after that update.


New Release issue

Hey there, i believe the 4.1.0 release is causing a breaking change. Once i downgrade back to v4.0.1 the issue is resolved.
Here's the implementation --- nothing too complex.
<AttentionSeeker
    triggerOnce
    delay={750}
    effect="bounce"
    className="unread-notifications-dot"
>
    <span />
</AttentionSeeker>

Here's the console error.

My project is using node v16.17.1 and on react v17.0.2 and react-scripts v17.0.2

Please make a reproducible example on Codesandbox following this link.
I tried your snippet and I had no errors.

Closing this due to inactivity


Flav/remove assistant preview min h

Description

This PR removes the min height of the AssistantPreview2 component.
Risk

Deploy Plan

PMRW.


DNS operation refused

Summary
this problem occured:
time="2021-05-28T18:18:23+08:00" level=warning msg="discover to bootnode /dnsaddr/bootnode.ethswarm.org"
time="2021-05-28T18:18:53+08:00" level=trace msg="kademlia balanced connector took 0s to finish"
time="2021-05-28T18:18:53+08:00" level=trace msg="kademlia iterator took 0s to finish"
time="2021-05-28T18:18:53+08:00" level=debug msg="kademlia has no connected peers, trying bootnodes"
time="2021-05-28T18:19:01+08:00" level=debug msg="discover fail /dnsaddr/bootnode.ethswarm.org: dns resolve address /dnsaddr/bootnode.ethswarm.org: lookup _dnsaddr.bootnode.ethswarm.org: dnsquery: DNS operation refused."
Steps to reproduce
when I use  https://goerli.infura.io/v3/53b4e5cf35db4cf2a3c511ff07916ef6
as swap-endpoint
whatever it is 0.5.3 or 0.6.1
Expected behavior

Actual behavior

Hi there,
Thank you for running Bee! :bee:
I suspect that you run v0.5.3. Please wait a few days until v0.6.2 is out and then try again!
Sorry for the wait.

Join our Discord for support: https://discord.gg/QpVwzJ3JKj


add schema for landCover, base theme

Proposal
Add multiple resolutions of global land cover data to base theme in Overture (sometime in 2024). Examples below from Meta's production basemaps.

Low Resolution, minZoom=0, maxZoom=4

Medium Resolution, minZoom=4, maxZoom=9

High Resolution, minZoom=9, maxZoom=24
Background
The Display Maps team at Meta recently completed a project to integrate global land cover data into it's basemaps. Landcover data provides an opportunity o display continuous, gapless representation of the Earth's natural surfaces. We derived these products from the 2020 European Space Agency (ESA) raster land cover product. Our process was generally: (1) download the image tiles, (2) process them, (3) vectorize them, and finally (4) post-process them to a usable format for vector tiling. We publicly released these with our Daylight product last year (Blog).
For Discussion
(1) IMO this is a huge opportunity for Overture to provide a massive dataset, critical to every global basemap used in a multitude of mapping applications.  This would be a first-of-its kind public dataset, it's hard to develop for day-to-day mappers, and is a huge technical lift at global scale.
Examples of land cover in production across several providers.

(2) Providing multiple resolutions meets the needs of map developers and cartographers who would use this data in their workflows. We could provide only the highest resolution, but users would need to develop complex processes to generalize and simplify the data. Providing only medium or low resolution would fall short of expectations for this type of dataset.
Providing tile zoom recommendations is probably a better way to define resolution than a specific reference scale like 1:1,000,000 or text like 'medium'.
(3) This is typically a "one and done" type dataset. This type of data is generally only needs refreshing every 5 to 10 years, and adding metadata such as year and source helps define that.
(4) While this type of data can be found in OpenStreetMap, this product provides continuous coverage across the globe.

This sounds great!
I feel like the right place to initially have this discussion is within the base theme Task Force. Once they're aligned that:

this is a good thing to do; and
we can generate and provide the data once the schema is merged;

then we should push forward with it...

I feel like the right place to initially have this discussion is within the base theme Task Force.

thanks @vcschapp - this PR is the result of discussion in that task force last week

@jonahadkins Wasn't there a version of this where min-max zoom level was expressed instead as a scale?

@jonahadkins Wasn't there a version of this where min-max zoom level was expressed instead as a scale?

originally,  but we thought it was more confusing

PR for data license approval: https://github.com/OvertureMaps/tf-data-platform/pull/253

In schema meeting 2024-05-01, @jwass indicated including ESA WorldCover for use as landcover is OK by legal. So this is not a blocker for merging.


Update go code excerpts

I ran npm run codeexcerpts to apply latest changes to the go examples, I think this is one of the first times we do the update, so please take a close look

This seems wrong, as it removes the log example.

This seems wrong, as it removes the log example.

I was surprised about that myself... wait I might have something wrong locally.

turning this into a draft for now, this needs more thought than I initially anticipated

Thanks @svrnm. Btw, this sort of experience goes to show that we can automate the code-snippet refresh (which is super great for minor changes), but when major structural changes are involved, we still need to carefully address the changes in the prose.
/cc @zeitlinger

for java, I have created a dedicated doc-snippets project to make this less likely

Thanks @svrnm. Btw, this sort of experience goes to show that we can automate the code-snippet refresh (which is super great for minor changes), but when major structural changes are involved, we still need to carefully address the changes in the prose.
/cc @zeitlinger

for java, I have created a dedicated doc-snippets project to make this less likely

Can you share that project?

Thanks @svrnm. Btw, this sort of experience goes to show that we can automate the code-snippet refresh (which is super great for minor changes), but when major structural changes are involved, we still need to carefully address the changes in the prose.
/cc @zeitlinger

for java, I have created a dedicated doc-snippets project to make this less likely

Can you share that project?

https://github.com/open-telemetry/opentelemetry-java-examples/pull/422

Will raise a new PR because of https://github.com/open-telemetry/opentelemetry.io/pull/4679


Does noble have to be installed with bleno? How to configure mtu, please

Hello, everybody!
I hope you can help me. Thank you.
I would like to know if noble and bleno must be used together to scan or be scanned?
So I have a hardware Bluetooth device, and I just use noble to scan it?
The webble I used before was abandoned due to the 20 mtu limit of the browser, can this library be modified to 514?
I've tried a few other libraries before, all of which require compilation with c++ leading to various postures of system incompatibility. Does this need to compile c++?
Thank you, everybody.

May you forward the issue to @abandoware/noble until upstream gives feedback at:
https://github.com/abandonware/noble/issues/2


update binaries used in Makefile

In the Makefile, we define a few binaries which we download. However, when using them, we may not have necessarily used the correct binary versions (they may have been pulled from the system instead). This PR ensures we use the freshly downloaded versions of the binaries. See https://github.com/stackrox/stackrox/blob/master/Makefile to see that the stackrox repo does it this way.
This PR also updates the version of github.com/sourcegraph/go-diff used by golangci-lint. See https://github.com/stackrox/stackrox/pull/4320 for more information.

/test e2e-test slim-e2e-tests


enhancement enable single_replica_load by default in BE

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Still getting [github assistant] undefined error when trying to pull

I have already set up login successfully to github and I even see the changes identified by the PULL, but when I click on the button to bring the changes down, I'm still getting this error. Already made sure that the GAS API is properly enabled. I removed and added the extension twice already, so I'm sure I'm using the latest version (<IP_ADDRESS>).
Already tried installing and uninstalling many times and also generated a new key on github; I'm able to see the repositories and the code changes, though, but the error happens whenever the pull is done.

Same issue here. From everything I see from the other related issues this seems to only be affecting GSuite Users, but I'm not entirely sure. Either way this is a huge blocker for many of us. @leonhartX If there is anything we can do to provide more information or attempt to support you in getting this resolved, it will be greatly appreciated. I love this Extension but haven't been able to use it in months.
This is the error I receive from the console:
{
  "error": {
    "code": 401,
    "message": "Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.",
    "status": "UNAUTHENTICATED"
  }
}

I am getting the same error. I've been using this extension happily for months (a couple small issues here and there) now it's suddenly stopped talking to Github.
It can see my repos but refuses to push/pull.
Same error:
{   "error": {     "code": 401,     "message": "Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.",     "status": "UNAUTHENTICATED"   } }
I've tried uninstall/reinstall, new access token and removing the app's google auth. Nothing working so far....

It seems the developer has not been able to take a look at the issues for the new version. Hopefully he'll retake on this. I really like the extension as it is really useful.

sorry guys, I can't manage to get some time to look at this now due to my work and family, wish I could get back in later August.

@leonhartX No problem friend, we appreciate all of your effort and really love this extension that you've built. It's so very helpful for all of us and we appreciate your hard work. Please let us know if there is any way to go open source with this so that we can assist in troubleshooting and perhaps take some work off of your plate. Thanks again!

The source code is all there ... have at it!
On Wed, 28 Jul 2021 at 05:14, AdiaProductTeam @.***>
wrote:

@leonhartX https://github.com/leonhartX No problem friend, we
appreciate all of your effort and really love this extension that you've
built. It's so very helpful for all of us and we appreciate your hard work.
Please let us know if there is any way to go open source with this so that
we can assist in troubleshooting and perhaps take some work off of your
plate. Thanks again!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/leonhartX/gas-github/issues/142#issuecomment-887995211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD4XXMUEUHCPU6RNFQ6I2TTZ57ZJANCNFSM4Y6RKDHQ
.

I tried all the suggested solutions: could push, but not pull. I ended up just going back to the old IDE and installing v4.0.7.

Hello, so actually I'm using this at work (with GitLab and the new GAS IDE after my fixes in the pull request) and we're within a custom GSuite environment.
It's true that out of the box you'll get these errors but there's nothing that leonhartX can do about it since it's probably blocked by your organization.
The way to fix this would be to set up your own OAuth2 with your own KEY and CLIENT ID from within your organization's GCP.
Or at least, that's how it worked for me.

Hi @Hell-K glad to hear this is working for you currently. Would you be willing to share a bit of instruction on the fix you mentioned? Maybe just some screenshots and directions to make it easier for us who aren't as familiar with that process off hand? It would be greatly appreciated.

I tried all the suggested solutions: could push, but not pull. I ended up just going back to the old IDE and installing v4.0.7.

HI Andrew. Can you provide some guidance on how to install that old version? (I have no clue how to do something like that). Thanks in advance!

To install the old v4.0.7 to use on the old Apps Script editor.

Unzip v4.0.7 on your computer, noting the location
In Chrome open the extensions page: Tools > Extensions
In the top right-hand corner enable developer mode, which should
enable the "Load unpacked" button on the left hand side
Click on "Load unpacked" and select your unzipped extension.

The extra Gas-GitHub buttons should now appear in your editor.
Enjoy!
On Tue, 16 Nov 2021 at 21:30, KoosKaas @.***> wrote:

I tried all the suggested solutions: could push, but not pull. I ended up
just going back to the old IDE and installing v4.0.7.
https://drive.google.com/file/d/1o2D4DM_sBGVDaHLBDZF6LPepqifcfuUQ/view?usp=sharing
HI Andrew. Can you provide some guidance on how to install that old
version? (I have no clue how to do something like that). Thanks in advance!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/leonhartX/gas-github/issues/142#issuecomment-970695871,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD4XXKWLUQR55KYUUANVP3UMLEP3ANCNFSM4Y6RKDHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Finally found the (or at least: "my") issue: my code that I wrote in local editor contained a bug that can't be saved by gas. So just check your code!!! (Or: develop in GAS and commit from GAS)

Although my token was set to never expire, creating a new one got it working in the new UI.

I received this error, too. However, I did not have Google Apps Script API enabled; once I fixed that here, I was able to pull without a problem. This is on Version 5.0.5.
Creating a new token (alone) did not fix my problem. (It is possible that the combination of fixing the token and enabling the API fixed the problem, but I tried the token first, so I will never know.)

I have recreated my token, ensured that the GAS API was enabled, but yet I'm still experiencing the same issue. Not sure what's going on.

I received this error, too. However, I did not have Google Apps Script API enabled; once I fixed that here, I was able to pull without a problem. This is on Version 5.0.5.
Creating a new token (alone) did not fix my problem. (It is possible that the combination of fixing the token and enabling the API fixed the problem, but I tried the token first, so I will never know.)

This worked for me. I engaged Google Apps Script API and I could pull!

Wasn't working for me.
I disabled Google Apps Script API, deleted the Token, enabled Google Apps Script API, created a new Token and then added it.
Now it works.

Still not working for me

Still not working for me

Are you getting the undefined error or is something else wrong?

@andreChmielewski So basically what happens is that when I open the Apps Script editor, it still does that thing where it opens a new tab to sign into Google, and even though the Github Assistant tool tabs appear e.g. - "Repository", push/pull - nothing happens when I click on any of those.
I went through the entire process of disabling/enabling Apps Script API both in my personal Apps Script User Settings and for the project itself in GCP, deleted/recreated a GitHub PAT, reinstalled the extension, etc etc and it's still not working for me. Not sure if I'm doing something wrong or if I should revert to a previous version of the extension.

@Adia-US I think I had this problem once -  I had installed everything but it didn't load any of my repositories. So I read somewhere that switching into the classic editor and then back into the new one would fix it. And it did!
Try switching to the classic editor and then back the new editor. Maybe refresh the browser then too.

@andreChmielewski Ugh, thank you for the recommendation but unfortunately that still didn't work for me. I've attempted all of the recommendations/work-arounds in this thread so far to no avail, so I'm wondering if there is something specific blocking me on the Google Workspace/GCP Administration side.

This happened to me again today.
Made sure that the API was enabled. Flipped it Off and On again. Still didn't work.
Reloaded the Chrome window a few times. Still didn't work.
right clicked the extension and opened the options of GasHub to verify I was still logged in. Yes I was.
Tried pull again. Well, hello there! Now it works!
Didn't have to fix new token.

@Adia-US I think I had this problem once - I had installed everything but it didn't load any of my repositories. So I read somewhere that switching into the classic editor and then back into the new one would fix it. And it did!
Try switching to the classic editor and then back the new editor. Maybe refresh the browser then too.

There is no option to switch to classic editor for me.

@Adia-US I think I had this problem once - I had installed everything but it didn't load any of my repositories. So I read somewhere that switching into the classic editor and then back into the new one would fix it. And it did!
Try switching to the classic editor and then back the new editor. Maybe refresh the browser then too.

There is no option to switch to classic editor anymore. The legacy Apps Script IDE was deprecated in Q4 2022.
https://issuetracker.google.com/issues/254509556

I've done all the usual changes but it works on some repos but not others.
I've resorted to using clasp for those ones.
On Thu, 3 Nov 2022 at 17:29, solroi @.***> wrote:

@Adia-US https://github.com/Adia-US I think I had this problem once - I
had installed everything but it didn't load any of my repositories. So I
read somewhere that switching into the classic editor and then back into
the new one would fix it. And it did!
Try switching to the classic editor and then back the new editor. Maybe
refresh the browser then too.
There is no option to switch to classic editor anymore. The legacy Apps
Script IDE was deprecated in Q4 2022.
https://issuetracker.google.com/issues/254509556
—
Reply to this email directly, view it on GitHub
https://github.com/leonhartX/gas-github/issues/142#issuecomment-1302445284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD4XXOBIJHWPDX4FZYKIO3WGPY7NANCNFSM4Y6RKDHQ
.
You are receiving this because you commented.Message ID:
@.***>

I received this error, too. However, I did not have Google Apps Script API enabled; once I fixed that here, I was able to pull without a problem. This is on Version 5.0.5.
Creating a new token (alone) did not fix my problem. (It is possible that the combination of fixing the token and enabling the API fixed the problem, but I tried the token first, so I will never know.)

you saved me man


[Bug]: 400 error is returned on a newly defined JS function name

Is there an existing issue for this?

[x] I have searched the existing issues

Description
A newly defined function displays a message stating object and function name combination already exists when it does not.
Steps To Reproduce

Go to app at this location and observe the toast message and the browser logs display error for a newly defined function

Public Sample App
No response
Version
Cloud
Test Plan

[ ] [Test Case]: verify that there is no 400 error appear on defining a new JS function name

This seems like a BE issue. When we fetch JS Collections for the application, the affected JS Object, TC4  returned from the server has only 1 action (TC4.dog), whereas there are multiple actions in the JS Object.
When we then try to update the js collection with new actions (detected after we evaluateTree), an error is thrown with the message  "TC4.cat is already exists."
The question is "if it is already present, why aren't we getting it when we fetch the js collection?"
cc: @nidhi-nair

Can you please share the app with me? @ramsaptami

I'm not able to repro this consistently. Only random. But the app attached to the issue shows the issue. I've also shared the app with you @subrata71

What I tried

Tried to reproduce by creating JS object in different environments {local, release, prod} but I wasn't able to reproduce

Forked the application that Saptami shared and found that the issue exists in that forked app too.

Exported that application and imported in local environment. The issue also exists in local after being imported.

Saptami confirmed that the issue is not easily reproducible and it seems to appear intermittently.

There's a PUT request taking place every time I click on the page which has usage to that JS object. Is it expected to trigger a PUT request when a page is clicked in edit mode?
Request URL: https://release.app.appsmith.com/api/v1/collections/actions/62ba8d7eca2698047034f59c
Request Method: PUT
Status Code: 400 Bad Request

Whenever the following method returns true an error message like {} already exists. Please use a different name is thrown.

LayoutActionServiceCEImpl.isNameAllowed
It returns true in the following cases

If any unpublished action under this page contains the fully qualified name of the given JS object
If any widget under this page contains the fully qualified name of the given JS object
If any action collection under this page contains the fully qualified name of the given JS object

Current workaround

Rename the JS object to something else which doesn't conflict with any of the existing {action names, widget names, collection names} which creates this issue
Now revert back to the previous name of the JS object
You should see the issue doesn't seem to prevail

Next course of action
We need to figure out on which instances the following API is triggered from FE
/api/v1/collections/actions/{actionId}

@subrata71 But ideally this should not matter since the function name should be scoped by the name of the JSObject and hence does not need to be unique across widgets and other queries right?

Any updates on this?
I am experiencing the same issue in an app I use in production. I can also confirm @subrata71's steps (fork, export/re-import) don't fix this and the issue seems to occur randomly after a while.
However: I did experience a much larger latency between my Browser and the Server – between the last updates that I deployed without editing any App so I just realized it some days ago – which sometimes results in "the server took too long to respond" and seems to favorably trigger this.

I've also run into this a few times while building the Hacktoberfest app. I assumed it was related to some type of caching of the JS object, so I ignored the first one for a few days. Finally, I renamed the method and updated my code to get the error to go away.
Now its happening on a different method in a different page. I've confirmed that there isn't a duplicate method name both in my code AND in the export. There are no errors running the JS object or in the IDE, but this error message pops up over an over (it seems to be when the JS object is updated/saved).
I could ignore the warning, BUT it is now not showing my new methods when I try to bind them to a button. The list of methods on an object doesn't show the new ones. I can manually add them, and it works... but super annoying.

It must be related to some type of cache somewhere. I believe it happens when I move a method inside my object during refactoring.

Thanks for adding in your observations @rlnorthcutt.
I also see a "cannot reproduce" label here and wanted to add that trying to copy paste an existing function and then trying to rename the function throws this error for the renamed function

Don't think this has been resolved. I still see this error show up on the sample app attached in the description hence reopening it

I found it happening in a few other apps too.

(WIP)
The following query returns a few documents which shouldn't return any document ideally.
{"pluginType": "JS", "unpublishedAction.collectionId" : {$exists: false}, "unpublishedAction.deletedAt" : {$exists:false}}
It's expected that the actions inside a JS collection should always have a collectionId if it's not deleted. (But even if it's deleted thecollectionId should persist).

Verification blocked since there's another area of code that's triggering this error
Slack thread for more context

I am closing this issue as it solves one reason which causes this issue. And I will create a new one addressing the other reason.
cc: @ramsaptami


[BEAM-10758] Centralized Glob Translation Method

I moved code translated globs to regular expressions that was duplicated in several filesystems to a central location. I also fixed a bug in the method.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @pabloem

R: @boyuanzz

Run Java_Examples_Dataflow_Java11 PreCommit


Any plan to support QA based AirGap Bitcoin hardware wallet ?

Hi, Currently on the Bitcoin Community, There is some hardware wallet (like ColdCard Q, Keystone Bitcoin wallet and foundation wallet) are focused on the air-gapped mode which use QA Code for the data transmission.  Does the HWI have any plan to support these types of device?

No

OK, Thanks for sharing the info


avoid using Lazy for metrics

Steps to reproduce
Currently, we are using Lazy for all metrics, but if we do not access that metric, it will not appear in the exporter.
Expected result
Actual result
Environment
Logs, links

Given we will need to pass a global object everywhere if we remove Lazy, this is not an optimal way to fix it. Currently we are solving this by adding access metrics in pre-initialize.

The intention of this issue is that there is a test case that checks if a metrics is available when a tenant is attached and removed when a tenant is detached. For page cache metrics, it is hard to have page hit in tests and therefore it is not available immediately when a tenant is created.


RxSwift4.0

RxSwift latest version is 4.0, but Moya->RxSwift is 3.3

Hey @Z-JaDe,
We will be using the latest version of RxSwift in Moya 10.0.
You can use the beta release, 10.0.0-beta.1 which uses RxSwift, 4.0.0-rc.0

RxSwift 4.0.0 was released at night today, we are gonna prepare for 10.0.0 release today as well :)

I know. Thanks

hope it

It makes me so happy that our releases sync with Rx. I love that we treat RxMoya so well

Hey guys, just a heads-up that we found a confirmed bug (#1382) and we will be delaying the 10.0.0 release for a short amount of time to make sure we fixed it correctly. Sorry for the trouble!

I'm gonna close this issue as the only problem right now is when the 10.0.0 version is out. For this we have #1253, so please head out there as we are planning the release for today 😉


[Enhancement] Field isn't final but should be [ClientGroupWrapper]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java line 76
analysis and explanation:
This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.
Describe the solution you'd like
add final modifier field.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

@Alonexc can you assign this to my name , I can work on it


Audio stuttering with latest version of Framer

Hello,
I'm trying to use AudioPlayer Module with the latest version of Framer and as soon as I make the progressBar appear, audio playback is stuttering.
When I open one of the included examples -without- updating the libraries, audio plays fine. When I reopen and update libraries, audio stutters again. I'm also having another problem: when progressBar is disabled, showTime doesn't work anymore...
Is there an easy way to fix this?
Thank you very much,
Philippe Côté

Hello,
When progressBar is true, currentTime doesn't work, then progressBar can't "automove" anymore.
But timeLeft still work.
How can we fix this?
Thanks,
Jiaxin Chen


I cannot build bigints with pulp/bower

My library uses bigints.  I can't build it with pulp/bower although I can with spago.  I wonder if it is related to the CI failure on the last commit?

Thank you for reporting this. I did not notice the CI failure. Maybe @thomashoneyman can help here? (see also: https://github.com/sharkdp/purescript-bigints/pull/33#issuecomment-790968162)

@newlandsvalley What error are you seeing, and on what Pulp / Bower versions? I just pulled the repository down locally and I was able to build using:
λ bower --version
1.8.8

λ pulp --version
Pulp version 15.0.0
purs version 0.14.2

Is it possible you're seeing an error when running npm run build if you don't have purescript-psa installed on your system? I think it ought to work otherwise. I've opened #37 to update CI.

Currently I have :
pulp --version
Pulp version 15.0.0
purs version 0.14.1

bower --version
1.8.12

I do pulp init and then edit bower.json to add "purescript-bigints": "^5.0.0".  If I then do bower install I see:
Unable to find a suitable version for purescript-effect, please choose one by typing one of the numbers below:
    1) purescript-effect#^2.0.0 which resolved to 2.0.1 and is required by purescript-refs#4.1.0, purescript-tailrec#4.1.1
    2) purescript-effect#^3.0.0 which resolved to 3.0.0 and is required by bigints, purescript-console#5.0.0, purescript-psci-support#5.0.0

I'm very confused about what's causing this.

It looks like your library may depend on purescript-refs#4.1.0 or purescript-tailrec#4.1.1, but those are both older of those libraries (they're both on v5 now). Because those libraries are a version behind they're trying to require effect#2.0.0, but your other dependencies (console, bigints, etc.), which are on up-to-date versions, are trying to require effect#3.0.0.
It may be that you need to update your refs or tailrec dependencies, or perhaps you have some other dependency that's bringing those packages in.

But at this point, I have no library:
{
  "name": "mybigints",
  "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "output"
  ],
  "dependencies": {
    "purescript-prelude": "^5.0.1",
    "purescript-console": "^5.0.0",
    "purescript-effect": "^3.0.0",
    "purescript-bigints": "^5.0.0"
  },
  "devDependencies": {
    "purescript-psci-support": "^5.0.0"
  }
}

Huh! @sharkdp it looks like the v5.0.0 release was accidentally cut without including the PureScript 0.14 updates!
https://github.com/sharkdp/purescript-bigints/releases/tag/v5.0.0 points to https://github.com/sharkdp/purescript-bigints/commit/54863140def3f25d131b1a4994a4fa91ef51f017 but it should point to https://github.com/sharkdp/purescript-bigints/commit/a072ed2e81cf2b1f975e55c74fb7bd3a0c655c30.

Oh - thank goodness!  I thought I was going mad!

Me too 😂 once that's fixed you should be good to go. In the meantime you could point the Bower file at a specific commit instead of the v5.0.0 tag.

Yeah - there's no rush.  I think I'll wait for the new version (which hopefully might now be published to pursuit).  Many thanks for following this up so quickly @thomashoneyman and @sharkdp.

Huh! @sharkdp it looks like the v5.0.0 release was accidentally cut without including the PureScript 0.14 updates!

Looks like I forgot to pull before tagging. Sorry for that. I released v6.0.0 now.


duplicate title but unique file slugs cause exception

use the codestart and cp content/posts/2024-10-13-the-first-roq.adoc content/posts/2024-11-01-other-post and you get:
 java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
        [error]: Build step io.quarkiverse.roq.frontmatter.deployment.record.RoqFrontMatterInitProcessor#bindSite threw an exception: java.lang.IllegalStateException: Duplicate key posts/the-first-roqjj (attempted merging values Runtime proxy of interface java.util.function.Supplier with id proxykey1555 and Runtime proxy of interface java.util.function.Supplier with id proxykey1560)

digging in I see its because it has a title that is used for the slug ...not the filename.
I have two issues with that:

is using the title really the right thing? should it not be the slug derived from the file which then could be changed using slug: or similar?

the exception is very technical and does not give casual blog user much help. Would have expected some more meaningful and helpful; like "Duplicate slug ('the-first-roq') found. Check your titles and file names for duplication" or similar.

I have two issues with that:

is using the title really the right thing? should it not be the slug derived from the file which then could be changed using slug: or similar?

As explained in the doc: https://docs.quarkiverse.io/quarkus-roq/dev/quarkus-roq-frontmatter.html#link-placeholders
The default link for document is /:collection/:slug
:slug: The slugified title of the page, derived from the title. Defaults to the slug property in data, if available or using the slugified title, falling back to the file name.
For page it uses the path.

the exception is very technical and does not give casual blog user much help. Would have expected some more meaningful and helpful; like "Duplicate slug ('the-first-roq') found. Check your titles and file names for duplication" or similar.

Yes we need to improve logging for sure overall, thanks for reporting this one.

We could change the default, this is only me choosing what seemed the more relevant... to me :)

Log is fixed


Deprecate bindings json command

Background:
I like the idea of using the raw XDR<>JSON for the interface format.
There is actually another JSON format we invented at some point, that is visible with this command:
❯ stellar contract bindings json --wasm test_empty.wasm
[
  {
    "type": "function",
    "doc": "",
    "name": "empty",
    "inputs": [],
    "outputs": []
  }
]

The json command really doesn't belong in the bindings command, because bindings is for generating actual clients, and the JSON is clearly not a client. So I think we can deprecate the bindings json command.
The question becomes should we keep this JSON interface format around, or abandon it for the XDR/JSON.
Realistically the two formats don't look that different, and so the value in maintaining the other format that I'm not sure many people know exists has little value.
$ wasm-cs test_empty.wasm read contractspecv0 -f binary | stellar xdr decode --input stream --type ScSpecEntry --output json-formatted
{
  "function_v0": {
    "doc": "",
    "name": "empty",
    "inputs": [],
    "outputs": []
  }
}

Originally posted by @leighmcculloch in https://github.com/stellar/stellar-cli/pull/1532#discussion_r1708395883

We should ask for feedback about this on Discord in the soroban-itself channel.

Forgot to post discord discussion thread


Regression from 2.0-beta15 release.

Since https://github.com/kfogel/OneTime/commit/76c46de2efdd651846758e419f2ef35743b5968a pulling random data from /dev/random and using it as an directed by onetime --pad-help can result in onetime blowing up, as discussed in https://github.com/Homebrew/homebrew-core/pull/7258 with a random file that'll produce a failure in https://github.com/Homebrew/homebrew-core/pull/7258#issuecomment-263068825.
~> dd if=/dev/random of=pad_data.txt bs=1024 count=1
~> ./onetime -e --pad=pad_data.txt --no-trace --config=. input.txt
Traceback (most recent call last):
  File "./onetime", line 1923, in <module>
    main()
  File "./onetime", line 1841, in main
    result = encoder.finish()
  File "./onetime", line 1493, in finish
    remainder += self.pad_sess.finish()
  File "./onetime", line 1424, in finish
    remainder += self._make_fuzz(self._tail_fuzz_length)
  File "./onetime", line 1105, in _make_fuzz
    ret_data = ret_data + chr(ord(rnd_data[i]) ^ ord(pad_data[i]))
IndexError: string index out of range

Stable and 2.0-beta13, 2.0-beta14 are unaffected, as far as I can discover from testing. Any git checkout prior to https://github.com/kfogel/OneTime/commit/76c46de2efdd651846758e419f2ef35743b5968a works fine using that known-defective /dev/random created file at https://github.com/Homebrew/homebrew-core/pull/7258#issuecomment-263068825.

Ping on this ... any chance of getting it fixed?


Unable to delete paginated messages

Describe the bug
What is called a "carousel" in the code is referred to as "pagination" within this issue.
All the pagination in this bot is handled by the same process:
send message -> listen for message delete -> send message -> repeat
However, this means that we can create an infinite loop with paginated embeds, and we are unable to delete any paginated embeds until the collector has ended.
As seen here, the bot deletes the embed every time a reaction is sent. However, we can simply just edit the message instead of deleting and resending. Despite rate limits, it would provide a much more streamlined experience when multiple paginated messages are being used.
To Reproduce
Steps to reproduce the behavior:

You can use any command that references the carousel function. In this case, &leaderboard is used.
Delete the embed message that the bot sends

Expected behavior
I expect that once the message is deleted, it will stay deleted and not resend.
Screenshots
Here's a gif instead:
Contact Information
||hi_everyone||#1273<PHONE_NUMBER>79697411) on discord

the fix is to probably edit the original message instead nice

Hmm, i do not know how to make it so the bot edits the message instead of deleting it, but i think that would be something great to add.

Theoretically, all you would need is to use a MessageCollector.


adds jshintc and dir-locals to conform to repo style

Hello. I added a few features that I need to your library.
Each of the branches on the pull-requests is based on the previous one. i.e.: the last pull request includes all of them. They are pretty focused, so hopefully it'll be easy to review.
I'm hoping we can collaborate, but if you are not interested in this direction or don't have the time please let me know so that I push a new package to NPM. Or if you are not interested in maintaining it anymore maybe you can transfer it.
Anyhow, thanks for your work.
Cheers

I'm reviewing alternatives that are somewhat closer to the original.
I'll reopen once I'm satisfied.

Cool, thanks for your contribution! No need to open so many pull requests, just open a big one with all the changes you want to merge in and I'll be happy to review and pull it in. We can discuss everything in the inline comments.
Thanks!

Sorry for the confusion, but i closed them all since I'm working on a
better version more in line with the original minimalism. I'll send new
pull requests soon.
On Mar 16, 2015 4:51 AM, "Hrvoje Šimić"<EMAIL_ADDRESS>wrote:

Cool, thanks for your contribution! No need to open so many pull requests,
just open a big one with all the changes you want to merge in and I'll be
happy to review and pull it in. We can discuss everything in the inline
comments.
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/shime/micro-machine/pull/3#issuecomment-81510582.


isStandardBrowserEnv hope that can be configured

I'm working in a ReactNative env
But for some reason,  i have to fake  a global document var
So the isStandardBrowserEnv always return true,  and the request failed..
Hope that can be configured,  is that ok or i have to find another way.
please let me know, ths

No, there is no way to configure it at the moment.


Deleted authorities created by scope.

Deleted authorities created by scope.

Why are we remove scopes authorities here?

@saragluna
Originally(last release), we do not have authority like SCOPE_Calender.Read.
But add authority like SCOPE_Calender.Read is default behavior of OidcUserService, So I added it recently.
Then I found it may have problem like this:
If we have resource-server-a has scope Calendar.Read, and resource-server-b also has scope Calendar.Read, Then we can not differentiate where SCOPE_Calender.Read comes from. So I deleted it.


fix overflow of edit in place container

There was a problem with not visible part of translation edit. Before http://prntscr.com/edlkiu , after http://prntscr.com/edlldc

Also something with z-index http://prntscr.com/edlpxr . In Chrome at least. In FF good.


Attempt to support 3.2.1 mono version - does not work yet

Fails with
EditorSettings: Save OK!
ERROR: _fs_changed: Cannot export project with preset 'macos' due to configuration errors:
No export template found at the expected path:
/root/.local/share/godot/templates/3.2.1.stable.mono/osx.zip

   At: editor/editor_node.cpp:611.
ERROR: _fs_changed: Project export failed for preset 'macos', the export template appears to be missing.
   At: editor/editor_node.cpp:634.
EditorSettings: Save OK!
Mono: Unloading scripts domain...
Mono: Runtime cleanup...
Mono: Finalized
ERROR: ~List: Condition "_first != __null" is true.
   At: ./core/self_list.h:112.
ERROR: cleanup: There are still MemoryPool allocs in use at exit!
   At: core/pool_vector.cpp:69.

Fix it at some point


Removed python-utils dependency

This is based on my currently unmerged change #145
The dep was only used for very simple string conversions and may prevent some people from using  progressbar.
After doing the changes I noticed that this will also fix #144.

Sounds like you're replacing one dep with another. Python utils gone and six was added, I'm not sure I understand the reasoning?

Since the to_unicode is essentially a copy from the other library, can you explain why it fixes #144?  It's not making sense to me yet

It would actually require me to refactor a bit more than what you've done already, I was working on a local branch that actually moved more util functions to the python-utils package so I'm not entirely sure if I'll merge this.

Hi Rick,
First of all I would like to thank you for your contribution of progressbar2 to the community. I tried to write a similar piece of code some years ago, but the API of progressbar2 is much more elegant than mine was before 👍.
Getting to your questions:
At the first look at the code I saw a local six copy and a dependency, that already have a dependency to the official six package. So the local six copy seems to be unnecessary.
Six is currently the number 3 of most downloaded packages on pypi. So you can say, that six is already present in almost all installations and its better to profit from upstream six enhancements, instead of having a local vendor branch. In addition, the motivation was to avoid duplicate code in installations (two variants of six).
On the other hand, python-utils is currently ranked 3955 (progressbar2 is ranked 1938). This means to the most users, that an additional dependency must be downloaded, which was not needed before.
In my opinion, that would be fine if python-utils were needed here for a complex task. However, it is only about the conversion of objects to Unicode strings, which can be a one-liner.
For me as a new user of progressbar2 it doesn't seem necessary to load additional 15KB code for a one-liner.
And getting to the question, why this fixes #144 - I'm currently not sure (I discussed it already with a colleague on Friday), but I hopefully will find out the reason and report it here. - Stay tuned.

Hi, the difference, why it fixes #144 is not checking for .decode, but checking on six.binary_type.
Otherwise with py27 the following happens:

a unicode string object
has the decode attr
unicode object is encoded to python 27 default encoding which is ASCII (sys.getdefaultencoding()) (if not otherwise patched!), to decode it later to unicode :-(
-> fail

This looks to me as a bug in python-utils.

I have to update my last comment:
The issue with #144 comes from an outdated conda-forge python-utils package having a bug.

I've cleaned up the code a bit more and moved more stuff away from the progressbar library now so this pull request is no long relevant.
Thanks for the help and the discussion, six is now part of the requirements and more code has been moved out of the library.


Setup a Memento-free fork of PowerModels for OPF Benchmark

We will just stay on https://github.com/lanl-ansi/PowerModels.jl/pull/887 until it merges.


feat: Implement layout to errorCallout

Description
Implements a parsing of the JSON error object to show a more readable message.
Task Item
Closes #6395
Screenshots

Was
Became

Made it in a way that:

Unknown fields are pushed to the bottom.
Multiline fields are wrapped in a <pre> tag
Whitelisted fields have the display name and order defined
If it's not a JSON object, no changes are made.

Tested with the error messages I could simulate.

@cdonke this is awesome!

Looks great @cdonke. Thanks for the PR!

We need to make sure this doesn't affect other error types that show up here, like publishing to LUIS or QnA

@cwhitten
I test if it is JSON parsable.. if not, returns the text as is...
I'll try to simulate the other errors and check how it goes..

Coverage decreased (-0.005%) to 52.886% when pulling fd5ee79d630641651d5f8cd5d8e52e005d35d1f3 on cdonke:BeautifyErrorMessage into 1584c35f30fc705efb0ccb4283f26ffb8886dafa on microsoft:main.

Publishing to LUIS wasn't affected, since it returns text:

QnAMaker doesn't show errors there...
It shows a pop-up with some details...

IT would be nice to join all the messages on the same place...

Thanks @cdonke. In the upcoming sprint we are also going to push this detailed error view inside a "Outputs" tabs in the Debug drawer at the bottom. This tab would house the stdout from the runtime as well as errors that happen while starting. We will reuse your code to display errors.

Great @srinaath ...
I really miss the runtime stdout (especially logging).

@srinaath I checked with @cwhitten and concluded that this is fine to take into main as we work towards surfacing these errors in the debug tray, so I'll merge once it goes green.


InstancedMesh support

Hi, would it be possible to add InstancedMesh support with a per-instance .instanceMatrix? My use case is displaying a large number of ellipsoids (many more than geometry.Ellipsoid can handle).
I'm also happy to take a stab at this if there's a preferred way to implement.

@rdeits @RussTedrake any thoughts on this?


Fixing the example config to work with the docker-compose sftp container

Fixes the commented out sftp example config to work when running along docker-compose.

Codecov Report

Merging #626 (f7922f2) into master (42a0847) will increase coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   51.73%   52.40%   +0.67%
==========================================
  Files          95       95
  Lines        3236     3280      +44
==========================================
+ Hits         1674     1719      +45
+ Misses       1211     1206       -5
- Partials      351      355       +4

Impacted Files
Coverage Δ

pkg/transfers/inbound/scheduler.go
44.18% <0.00%> (-2.16%)
:arrow_down:

pkg/transfers/pipeline/notify/email.go
62.12% <0.00%> (-1.38%)
:arrow_down:

pkg/transfers/pipeline/aggregate.go
12.75% <0.00%> (-0.18%)
:arrow_down:

pkg/transfers/inbound/cleanup.go
76.00% <0.00%> (+4.57%)
:arrow_up:

pkg/transfers/pipeline/notify/multi.go
42.85% <0.00%> (+42.85%)
:arrow_up:

pkg/transfers/pipeline/notify/mock_sender.go
66.66% <0.00%> (+66.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a0847...f7922f2. Read the comment docs.


Operator may be removed unexpectedly.

Please answer these questions before submitting your issue. Thanks!

What did you do?
If possible, provide a recipe for reproducing the error.
Benchmark new hotspot scheduler for write flow.

What did you expect to see?
Record removed operators in time.

What did you see instead?
Some operators are removed without record. There is the log:

[2019/08/29 07:57:18.572 +00:00] [INFO] [operator_controller.go:313] ["add operator"] [region-id=2] [operator="\"remove-extra-replica {rm peer: store 10} (kind:region,replica, region:2(5628,2884), createAt:2019-08-29 07:57:18.572825408 +0000 UTC m=+14171.746185546, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, steps:[remove peer on store 10])\""]
[2019/08/29 07:57:18.573 +00:00] [INFO] [operator_controller.go:416] ["send schedule command"] [region-id=2] [step="remove peer on store 10"] [source=create]
[2019/08/29 07:57:18.583 +00:00] [INFO] [cluster.go:370] ["region ConfVer changed"] [region-id=2] [detail="Remove peer:{id:375418 store_id:10 }"] [old-confver=2884] [new-confver=2885]
[2019/08/29 07:57:18.583 +00:00] [INFO] [operator_controller.go:120] ["operator finish"] [region-id=2] [operator="\"remove-extra-replica {rm peer: store 10} (kind:region,replica, region:2(5628,2884), createAt:2019-08-29 07:57:18.572825408 +0000 UTC m=+14171.746185546, startAt:2019-08-29 07:57:18.573005184 +0000 UTC m=+14171.746365387, currentStep:1, steps:[remove peer on store 10]) finished\""]
[2019/08/29 07:57:18.583 +00:00] [INFO] [operator_controller.go:313] ["add operator"] [region-id=2] [operator="\"move-hot-write-region {mv peer: store 5 to 10} (kind:region,hot-region, region:2(5628,2885), createAt:2019-08-29 07:57:18.583871087 +0000 UTC m=+14171.757231214, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, steps:[add learner peer 381188 on store 10, promote learner peer 381188 on store 10 to voter, remove peer on store 5])\""]
[2019/08/29 07:57:18.584 +00:00] [INFO] [operator_controller.go:318] ["replace old operator"] [region-id=2] [operator="\"remove-extra-replica {rm peer: store 10} (kind:region,replica, region:2(5628,2884), createAt:2019-08-29 07:57:18.572825408 +0000 UTC m=+14171.746185546, startAt:2019-08-29 07:57:18.573005184 +0000 UTC m=+14171.746365387, currentStep:1, steps:[remove peer on store 10]) finished\""]
[2019/08/29 07:57:18.584 +00:00] [INFO] [operator_controller.go:416] ["send schedule command"] [region-id=2] [step="add learner peer 381188 on store 10"] [source=create]
[2019/08/29 07:57:18.591 +00:00] [INFO] [cluster.go:370] ["region ConfVer changed"] [region-id=2] [detail="Add peer:{id:381188 store_id:10 is_learner:true }"] [old-confver=2885] [new-confver=2886]
[2019/08/29 07:57:57.225 +00:00] [INFO] [operator_controller.go:313] ["add operator"] [region-id=2] [operator="\"promote-learner {promote learner: store 10} (kind:region, region:2(5628,2886), createAt:2019-08-29 07:57:57.225111428 +0000 UTC m=+14210.398471558, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, steps:[promote learner peer 381188 on store 10 to voter])\""]
[2019/08/29 07:57:57.225 +00:00] [INFO] [operator_controller.go:416] ["send schedule command"] [region-id=2] [step="promote learner peer 381188 on store 10 to voter"] [source=create]
[2019/08/29 07:57:57.232 +00:00] [INFO] [cluster.go:370] ["region ConfVer changed"] [region-id=2] [detail="Remove peer:{id:381188 store_id:10 is_learner:true },Add peer:{id:381188 store_id:10 }"] [old-confver=2886] [new-confver=2887]
[2019/08/29 07:57:57.232 +00:00] [INFO] [operator_controller.go:120] ["operator finish"] [region-id=2] [operator="\"promote-learner {promote learner: store 10} (kind:region, region:2(5628,2886), createAt:2019-08-29 07:57:57.225111428 +0000 UTC m=+14210.398471558, startAt:2019-08-29 07:57:57.22515548 +0000 UTC m=+14210.398515604, currentStep:1, steps:[promote learner peer 381188 on store 10 to voter]) finished\""]

We can see that "remove-extra-replia"  is removed and then replaced. "move-hot-write-region" is add but not dropped (finish, timeout, replace, cancel). "promote-learner" is added without replacing the "move-hot-write-region".

What version of PD are you using (pd-server -V)?
Self modified (master 14b91e8f merged)

The reason seems like that the removeOperatorLocked assumes the given op is in oc.operators[op.RegionID()].
https://github.com/pingcap/pd/blob/14b91e8fbe3c172adcae880e3b858379e3d90eff/server/schedule/operator_controller.go#L370-L375
However the Dispatch function breaks this. In the following code, oc.operators maybe modified before the RemoveOperator gets the lock.
https://github.com/pingcap/pd/blob/14b91e8fbe3c172adcae880e3b858379e3d90eff/server/schedule/operator_controller.go#L118-L126
Possible solutions:

add lock for Dispatch and other functions doing similar work
check op is the same one before delete in removeOperatorLocked

Fixed by #1719


[review] Element handle

Commit messages are WIP
CElementHandle can be used by applications to directly control an element part of the parameter tree. CElementHandle objects can be created by calling the platform connector class new createElementHandle() functionality.
Element handle objects are owned by the application so it's its responsibility to destroy them through a "delete" operation.
The following functionalities are available in CElementHandle class:

getting element's name
getting element's path in parameter hierarchy tree
getting element's memory size in bytes
determining if element is rogue
getting the structure of the element (expanded version of the structure)
getting/setting the element's settings in XML format
getting/setting the element's settings in binary format

Notes:

setting the element's settings in binary shall be done cautiously: no check is made as to the data integrity, meaning the operation could result in inconsistent parameter states where some parameter values are out of range or invalid wrt their type
setting the element's settings will fail if the element is not rogue (belong to a domain or one of its descendent does)
if a tuning application has set the auto sync mode to off, the changes applied through CElementHandle will be forward-synchronized when the auto sync mode is set back to on or when the "sync" remote command is executed.
when the tuning mode is on, calls to setAsXML() and setAsBytes() will fail silently (do nothing but return success)
The handle is not tested !

[x]   File: parameter/CMakeLists.txt:L124 (240f360)
 for consistency: please use ".h" as suffix.
 The coding style require hpp. Why should new file be .h ?
[x]   File: parameter/include/ElementHandle.hpp:L92 (240f360)
 not implemented.
[x]   File: parameter/include/ElementHandle.hpp:L67 (240f360)
 not implemented
[x]   File: parameter/include/ElementHandle.hpp:L53 (240f360)
 not implemented
 oups, how did you see that ?
 I first wanted to see getChildren's implementation and noticed it wasn't implemented. I then proceeded to check every method of this class.
[x]   File: parameter/include/ElementHandle.hpp:L64 (240f360)
 not implemented
[ ]   File: parameter/include/ElementHandle.hpp:L102 (240f360)
 not implemented
[x]   File: parameter/include/ElementHandle.hpp:L108 (240f360)
 not implemented.
[ ]   General Comment
 :-1: review done.
 :-1: reviews done
[x]   File: parameter/ElementHandle.cpp:L43 (240f360)
 remove
[x]   File: parameter/ElementHandle.cpp:L2 (240f360)
 2015 (or 2011-2015)
 I dislike license headers :+1:
[x]   File: parameter/ElementHandle.cpp:L62 (240f360)
 are we sure we want to use dynamic casts? Consider android.
 We are catching exceptions by base class all over the place... The current PF can not work without rtti. :+1:
[x]   File: parameter/ElementHandle.cpp:L30 (240f360)
 ElementHandle.h
[x]   File: parameter/ElementHandle.cpp:L100 (240f360)
 no need for the "else" (since there is a return in the if)
[x]   File: parameter/ElementHandle.cpp:L108 (240f360)
 Since you've defined setSettingsAsXML in the same PR, you could make it take a reference instead of a pointer.
EDIT: oops, scratch that - I got the method names mixed up.
[x]   File: parameter/ElementHandle.cpp:L169 (240f360)
 checkGetValidity duplicates the isParameter check.
[x]   File: parameter/ElementHandle.cpp:L139 (240f360)
 checkSetValidity duplicates the isParameter check.
[x]   File: parameter/ParameterMgr.cpp:L787 (240f360)
 coding style: } else {
[x]   File: parameter/ParameterMgr.cpp:L783 (240f360)
 "//" should work too. There shouldn't be a special case for the root element.
 I agree but this is the same behavior everywhere. Not introduced in this patch. :+1: I can not see a trivial fix.
[x]   File: parameter/ParameterMgr.cpp:L798 (240f360)
 copy-paste detected :) there is no conversion done here.
 I should have read more carefully Pat's patch. :+1:
[x]   File: parameter/ParameterMgr.h:L153 (240f360)
 nullptr
 :+1: not changed in Connector as it is not c++11
[x]   File: parameter/ParameterMgr.h:L147 (240f360)
 this note doesn't seem useful to me.
 Neither to me. It might confuse more the client than help him. "/" == root is basically the default everywhere. :+1:
[x]   File: parameter/ParameterMgrPlatformConnector.cpp:L89 (240f360)
 element
 :+1:  remove the comment.
[x]   File: parameter/include/ElementHandle.hpp:L2 (240f360)
 2015?
[x]   File: parameter/include/ElementHandle.hpp:L77 (240f360)
 trailing whitespaces
[x]   File: parameter/include/ElementHandle.hpp:L134 (240f360)
 I suggest "getSettingsAsXML" for consistency.
 I disagree getAs is used everywhere to get a value. Why confuse the client with an other name for the same thing ? :+1:
[x]   File: parameter/include/ElementHandle.hpp:L150 (240f360)
 ditto
 ditto :+1:
[x]   File: parameter/include/ElementHandle.hpp:L156 (240f360)
 ditto (maybe)
 ditto :+1:
[x]   File: parameter/include/ElementHandle.hpp:L164 (240f360)
 ditto (maybe)
 ditto :+1:
[x]   File: parameter/include/ParameterHandle.h:L2 (240f360)
 2015
[x]   File: parameter/include/ParameterHandle.h:L43 (240f360)
 PARAMETER_EXPORT
[x]   File: parameter/include/ParameterHandle.h:L46 (240f360)
 either a) make the ctor protected or b) make the class final, to make it clear whether CParameterHandle a) can be derived or b) must not be derived.
 :+1: added final
[x]   File: parameter/include/ParameterMgrPlatformConnector.h:L90 (240f360)
 not sure this note is needed

This pull request is now managed with CodeReviewHub. Refresh.

:-1: review done.

:-1: reviews done

:-1: review done

main change is: https://github.com/krocard/parameter-framework/commit/0f29ce1957d994e2510e10092549fc20c8243fc5

:shipit:


Atom-Typescript error: Cannot read property 'NaN' of undefined

Error is displayed when I pop the latest stash (git stash pop). Then when I save the stash I think I get a different stack trace, I will add that as a comment.  I am on Ubuntu 18.04, atom 1.40.1, atom-typescript 13.3.0.This is the error stack trace following git stash pop:
TypeError: Cannot read property 'NaN' of undefined
    at TextEditorComponent.renderedScreenLineForRow (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:81417)
    at TextEditorComponent.pixelLeftForRowAndColumn (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:107405)
    at TextEditorComponent.pixelPositionForScreenPosition (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:66571)
    at HTMLElement.pixelPositionForBufferPosition (/snap/atom/238/usr/share/atom/resources/app.asar/src/text-editor-element.js:238:32)
    at TooltipController.computeTooltipPosition (~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/controller.js:59:34)
    at TooltipController.updateTooltip (~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/controller.js:41:34)
    at new TooltipController (~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/controller.js:26:36)
    at SigHelpManager.showTooltip (~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/manager.js:60:40)
    at ~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/manager.js:20:44
    at Function.simpleDispatch (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1210649)
    at TextBuffer.emitDidStopChangingEvent (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:504867)
    at later (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:14:104393)

This is the stack trace after git stash save:
TypeError: Cannot read property 'NaN' of undefined
    at TextEditorComponent.renderedScreenLineForRow (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:81417)
    at TextEditorComponent.pixelLeftForRowAndColumn (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:107405)
    at TextEditorComponent.pixelPositionForScreenPosition (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:66571)
    at HTMLElement.pixelPositionForBufferPosition (/snap/atom/238/usr/share/atom/resources/app.asar/src/text-editor-element.js:238:32)
    at TooltipController.computeTooltipPosition (~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/controller.js:59:34)
    at TooltipController.updateTooltip (~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/controller.js:41:34)
    at invokeFunc (~/.atom/packages/atom-typescript/node_modules/lodash/lodash.js:10333:23)
    at leadingEdge (~/.atom/packages/atom-typescript/node_modules/lodash/lodash.js:10343:26)
    at debounced (~/.atom/packages/atom-typescript/node_modules/lodash/lodash.js:10410:20)
    at TooltipController.disposables.add.editor.onDidChangeCursorPosition.evt (~/.atom/packages/atom-typescript/dist/main/atom/sigHelp/controller.js:20:35)
    at Function.simpleDispatch (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1210649)
    at TextEditor.cursorMoved (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:33212)
    at Selection.markerDidChange (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:547080)
    at Selection.marker.onDidChange.e (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:532223)
    at Function.simpleDispatch (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1210649)
    at DisplayMarker.notifyObservers (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:14:2855767)
    at /snap/atom/238/usr/share/atom/resources/app/static/<embedded>:14:2851269
    at Function.simpleDispatch (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:1210649)
    at Marker.emitChangeEvent (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:14:73563)
    at /snap/atom/238/usr/share/atom/resources/app/static/<embedded>:14:80000
    at Set.forEach (<anonymous>)
    at MarkerLayer.emitChangeEvents (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:14:79945)
    at TextBuffer.emitMarkerChangeEvents (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:503916)
    at TextBuffer.finishLoading (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:501023)
    at TextBuffer.load (/snap/atom/238/usr/share/atom/resources/app/static/<embedded>:11:499942)


created Radio component

closes #88
This Pull Request meets the following criteria:

[x] Tests have been added/adjusted for my new feature
[x] New Components are registered in index.js of my project

Oh no, could you rebase it on master without such merge commit?

@jaroslav-kubicek done


Move running related code to separate crate

Closes #839
Introduced changes

Split forge into two crates. Note that this PR will not pass checks as it is incomplete. See related PRs linked in comments for continuation of this work.

Checklist

[ ] Linked relevant issue
[ ] Updated relevant documentation
[ ] Added relevant tests
[ ] Performed self-review of the code
[ ] Added changes to CHANGELOG.md

Continuation:
#1032
#1046


Removes bulk preloading all existing fonts

Because every browser will preload all fonts, even if they don’t need them. This is a very bad example.
Fixed on MDN too.

Thanks Vadim ;-)
This is a really good point; thanks for the fix.


Add json only feature for file exports/nodejs imports

New config key:
json_only default: false
#config/i18n-js.yml
fallbacks: false
json_only: true

translations:
  - file: "tmp/i18n-js/%{locale}.js"

outputs:
{"en":{"test":"Test"}}

instead of:
I18n.translations || (I18n.translations = {});
I18n.translations[\"en\"] = {"en":{"test":"Test"}};

This is so I can manually host the translation files behind a custom controller behind authentication using rails as an api only backend, but would be useful for anyone looking to host the files separately in an automated way.

Pull Request Test Coverage Report for Build 561

18 of 19 (94.74%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.2%) to 65.57%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/i18n/js/errors.rb
4
5
80.0%

Files with Coverage Reduction
New Missed Lines
%

lib/i18n/js/dependencies.rb
2
50.0%

Totals

Change from base Build 559:
1.2%

Covered Lines:
259

Relevant Lines:
395

💛  - Coveralls

Pull Request Test Coverage Report for Build 561

18 of 19 (94.74%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.2%) to 65.57%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/i18n/js/errors.rb
4
5
80.0%

Files with Coverage Reduction
New Missed Lines
%

lib/i18n/js/dependencies.rb
2
50.0%

Totals

Change from base Build 559:
1.2%

Covered Lines:
259

Relevant Lines:
395

💛  - Coveralls

Thanks for your PR
There are several options like namespace & pretty_print for each segment (for each entry under translations) (which is processed in /lib/i18n/js/segment.rb)
Example PR: #397
Do you think it would be more flexible to add the new option there?
e.g. Generate both JSON and JS version, I dunno why someone would do that though

My purpose with this is to have one source of truth for webpage copy, ie. rails hosting the files and a react server importing them with no preprocessing needed.
Current options combined with json_only:
Fallbacks: can be used
Namespace: ignored
Pretty Print: can be used
I can't think someone would ever want to use both on the same application, and if they did, it's not too much work to add a PR :) If you consider it a showstopper if I don't add such functionality I can though.

Considering fallbacks is also a global option I think it's fine (yup I missed that when commenting previously)
Let me check the code once more before merging


⚠ ClamAV has degraded performance

In 15f6d1a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: ClamAV performance has improved in 114f895 after 5 minutes.


[RHMWRT-221] Add OpenShift labels

If we also want to add the same labels to https://github.com/snowdrop/rest-http-example/blob/sb-2.1.x/.openshiftio/application.yaml we'll need to also extend our atomist scripts to inject correct Spring Boot version.

@cmoulliard I've updated the PR. Could you give one more full review? Once we agree on how this should look like I'll update the other examples.