Update 0069-VCBS-validators_chosen_by_stake.md

Added Acs for IssueSignature
close #1577 .

Will need AC numbers updating before it goes; let's try to get @wwestgarth to review.

Needs to have the AC code duplicates resolved before merging


Connection lost due to heartbeat ignore

Describe the bug
I am using:

AMQP-CPP 4.3.15 with libboostasio TcpHandler.
RabbitMQ 3.8.11

I don't do anything more complex than the example, so I didn't changed default the heartbeat behavior somehow.
Using pcap dump I see the following connection negotiation steps:
Frame 10: 86 bytes on wire (688 bits), 86 bytes captured (688 bits) on interface eth0, id 0
    Interface id: 0 (eth0)
        Interface name: eth0
    Encapsulation type: Ethernet (1)
    Arrival Time: Nov 29, 2021 14:21:17.782187767 MSK
    [Time shift for this packet: 0.000000000 seconds]
    Epoch Time:<PHONE_NUMBER>.782187767 seconds
    [Time delta from previous captured frame: 0.000259074 seconds]
    [Time delta from previous displayed frame: 0.000259074 seconds]
    [Time since reference or first frame: 0.003860519 seconds]
    Frame Number: 10
    Frame Length: 86 bytes (688 bits)
    Capture Length: 86 bytes (688 bits)
    [Frame is marked: False]
    [Frame is ignored: False]
    [Protocols in frame: eth:ethertype:ip:tcp:amqp]
    [Coloring Rule Name: TCP]
    [Coloring Rule String: tcp]
Ethernet II, Src: VMware_19:a0:42 (00:0c:29:19:a0:42), Dst: VECOW_05:03:49 (20:46:a1:05:03:49)
    Destination: VECOW_05:03:49 (20:46:a1:05:03:49)
        Address: VECOW_05:03:49 (20:46:a1:05:03:49)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
    Source: VMware_19:a0:42 (00:0c:29:19:a0:42)
        Address: VMware_19:a0:42 (00:0c:29:19:a0:42)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
    Type: IPv4 (0x0800)
Internet Protocol Version 4, Src: <IP_ADDRESS>, Dst: <IP_ADDRESS>
    0100 .... = Version: 4
    .... 0101 = Header Length: 20 bytes (5)
    Differentiated Services Field: 0x00 (DSCP: CS0, ECN: Not-ECT)
        0000 00.. = Differentiated Services Codepoint: Default (0)
        .... ..00 = Explicit Congestion Notification: Not ECN-Capable Transport (0)
    Total Length: 72
    Identification: 0x28bb (10427)
    Flags: 0x40, Don't fragment
        0... .... = Reserved bit: Not set
        .1.. .... = Don't fragment: Set
        ..0. .... = More fragments: Not set
    Fragment Offset: 0
    Time to Live: 64
    Protocol: TCP (6)
    Header Checksum: 0x71c5 [validation disabled]
    [Header checksum status: Unverified]
    Source Address: <IP_ADDRESS>
    Destination Address: <IP_ADDRESS>
Transmission Control Protocol, Src Port: 5672, Dst Port: 38166, Seq: 514, Ack: 275, Len: 20
    Source Port: 5672
    Destination Port: 38166
    [Stream index: 0]
    [TCP Segment Len: 20]
    Sequence Number: 514    (relative sequence number)
    Sequence Number (raw):<PHONE_NUMBER>
    [Next Sequence Number: 534    (relative sequence number)]
    Acknowledgment Number: 275    (relative ack number)
    Acknowledgment number (raw): 25711864
    1000 .... = Header Length: 32 bytes (8)
    Flags: 0x018 (PSH, ACK)
        000. .... .... = Reserved: Not set
        ...0 .... .... = Nonce: Not set
        .... 0... .... = Congestion Window Reduced (CWR): Not set
        .... .0.. .... = ECN-Echo: Not set
        .... ..0. .... = Urgent: Not set
        .... ...1 .... = Acknowledgment: Set
        .... .... 1... = Push: Set
        .... .... .0.. = Reset: Not set
        .... .... ..0. = Syn: Not set
        .... .... ...0 = Fin: Not set
        [TCP Flags: ·······AP···]
    Window: 507
    [Calculated window size: 64896]
    [Window size scaling factor: 128]
    Checksum: 0xa06a [unverified]
    [Checksum Status: Unverified]
    Urgent Pointer: 0
    Options: (12 bytes), No-Operation (NOP), No-Operation (NOP), Timestamps
        TCP Option - No-Operation (NOP)
            Kind: No-Operation (1)
        TCP Option - No-Operation (NOP)
            Kind: No-Operation (1)
        TCP Option - Timestamps: TSval<PHONE_NUMBER>, TSecr<PHONE_NUMBER>
            Kind: Time Stamp Option (8)
            Length: 10
            Timestamp value:<PHONE_NUMBER>
            Timestamp echo reply:<PHONE_NUMBER>
    [SEQ/ACK analysis]
        [iRTT: 0.000682851 seconds]
        [Bytes in flight: 20]
        [Bytes sent since last PSH flag: 20]
    [Timestamps]
        [Time since first frame in this TCP stream: 0.003860519 seconds]
        [Time since previous frame in this TCP stream: 0.000259074 seconds]
    TCP payload (20 bytes)
    [PDU Size: 20]
Advanced Message Queueing Protocol
    Type: Method (1)
    Channel: 0
    Length: 12
    Class: Connection (10)
    Method: Tune (30)
    Arguments
        Channel-Max: 2047
        Frame-Max: 131072
        Heartbeat: 60

Note, that the server suggest heartbeat: 60, and the client (AMQP-CPP) agrees with this suggestion:
Frame 12: 86 bytes on wire (688 bits), 86 bytes captured (688 bits) on interface eth0, id 0
    Interface id: 0 (eth0)
        Interface name: eth0
    Encapsulation type: Ethernet (1)
    Arrival Time: Nov 29, 2021 14:21:17.782688949 MSK
    [Time shift for this packet: 0.000000000 seconds]
    Epoch Time:<PHONE_NUMBER>.782688949 seconds
    [Time delta from previous captured frame: 0.000208720 seconds]
    [Time delta from previous displayed frame: 0.000208720 seconds]
    [Time since reference or first frame: 0.004361701 seconds]
    Frame Number: 12
    Frame Length: 86 bytes (688 bits)
    Capture Length: 86 bytes (688 bits)
    [Frame is marked: False]
    [Frame is ignored: False]
    [Protocols in frame: eth:ethertype:ip:tcp:amqp]
    [Coloring Rule Name: TCP]
    [Coloring Rule String: tcp]
Ethernet II, Src: VECOW_05:03:49 (20:46:a1:05:03:49), Dst: VMware_19:a0:42 (00:0c:29:19:a0:42)
    Destination: VMware_19:a0:42 (00:0c:29:19:a0:42)
        Address: VMware_19:a0:42 (00:0c:29:19:a0:42)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
    Source: VECOW_05:03:49 (20:46:a1:05:03:49)
        Address: VECOW_05:03:49 (20:46:a1:05:03:49)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
    Type: IPv4 (0x0800)
Internet Protocol Version 4, Src: <IP_ADDRESS>, Dst: <IP_ADDRESS>
    0100 .... = Version: 4
    .... 0101 = Header Length: 20 bytes (5)
    Differentiated Services Field: 0x00 (DSCP: CS0, ECN: Not-ECT)
        0000 00.. = Differentiated Services Codepoint: Default (0)
        .... ..00 = Explicit Congestion Notification: Not ECN-Capable Transport (0)
    Total Length: 72
    Identification: 0xc9a8 (51624)
    Flags: 0x40, Don't fragment
        0... .... = Reserved bit: Not set
        .1.. .... = Don't fragment: Set
        ..0. .... = More fragments: Not set
    Fragment Offset: 0
    Time to Live: 64
    Protocol: TCP (6)
    Header Checksum: 0xd0d7 [validation disabled]
    [Header checksum status: Unverified]
    Source Address: <IP_ADDRESS>
    Destination Address: <IP_ADDRESS>
Transmission Control Protocol, Src Port: 38166, Dst Port: 5672, Seq: 275, Ack: 534, Len: 20
    Source Port: 38166
    Destination Port: 5672
    [Stream index: 0]
    [TCP Segment Len: 20]
    Sequence Number: 275    (relative sequence number)
    Sequence Number (raw): 25711864
    [Next Sequence Number: 295    (relative sequence number)]
    Acknowledgment Number: 534    (relative ack number)
    Acknowledgment number (raw):<PHONE_NUMBER>
    1000 .... = Header Length: 32 bytes (8)
    Flags: 0x018 (PSH, ACK)
        000. .... .... = Reserved: Not set
        ...0 .... .... = Nonce: Not set
        .... 0... .... = Congestion Window Reduced (CWR): Not set
        .... .0.. .... = ECN-Echo: Not set
        .... ..0. .... = Urgent: Not set
        .... ...1 .... = Acknowledgment: Set
        .... .... 1... = Push: Set
        .... .... .0.. = Reset: Not set
        .... .... ..0. = Syn: Not set
        .... .... ...0 = Fin: Not set
        [TCP Flags: ·······AP···]
    Window: 501
    [Calculated window size: 64128]
    [Window size scaling factor: 128]
    Checksum: 0x4fe8 [unverified]
    [Checksum Status: Unverified]
    Urgent Pointer: 0
    Options: (12 bytes), No-Operation (NOP), No-Operation (NOP), Timestamps
        TCP Option - No-Operation (NOP)
            Kind: No-Operation (1)
        TCP Option - No-Operation (NOP)
            Kind: No-Operation (1)
        TCP Option - Timestamps: TSval<PHONE_NUMBER>, TSecr<PHONE_NUMBER>
            Kind: Time Stamp Option (8)
            Length: 10
            Timestamp value:<PHONE_NUMBER>
            Timestamp echo reply:<PHONE_NUMBER>
    [SEQ/ACK analysis]
        [iRTT: 0.000682851 seconds]
        [Bytes in flight: 20]
        [Bytes sent since last PSH flag: 20]
    [Timestamps]
        [Time since first frame in this TCP stream: 0.004361701 seconds]
        [Time since previous frame in this TCP stream: 0.000208720 seconds]
    TCP payload (20 bytes)
    [PDU Size: 20]
Advanced Message Queueing Protocol
    Type: Method (1)
    Channel: 0
    Length: 12
    Class: Connection (10)
    Method: Tune-Ok (31)
    Arguments
        Channel-Max: 2047
        Frame-Max: 131072
        Heartbeat: 60

Expected behavior and actual behavior
Actual behavior is that AMQP-CPP ignores heartbeat incoming messages and then the connection is closed by the server.
Excepted behavior would be one of the following:

AMQP-CPP should answer to the heartbeats
AMQP-CPP should set 0 when Tune-Ok.

Can you send the smallest possible example program that demonstrates this issue?

Sure!
#include <boost/asio/io_service.hpp>
#include <boost/asio/strand.hpp>

#include <amqpcpp.h>
#include <amqpcpp/libboostasio.h>

int main() {
    boost::asio::io_service service(4);

    AMQP::LibBoostAsioHandler handler(service);

    AMQP::TcpConnection connection(&handler, AMQP::Address("amqp://guest:guest@localhost/"));
    AMQP::TcpChannel channel(&connection);

    channel.onError([] (const char* message) {
        std::cerr << "AMQP channel: " << message << std::endl;
    });

    return service.run();
}

Actual result:
> ./example
AMQP channel: connection lost

Expected result is running forever.

Ping?

The boost asio handler is not something that I wrote, checked or tested. I accepted your pull request, I hope it solves the issue for you.

Thanks! :+1:


Remove version: Canonical.Juju version 2.9.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://launchpadlibrarian.net/535927459/juju-setup-2.9.0.exe
Status Code: 200
(Automated message - build 903)

Close with reason: Duplicate;


rfc - a preferred slave list in a sentinel setup

We want to run a sentinel setup:

each webserver has it's own redis slave (will NOT become master - using slave-priority = 0)
a set of sentinels running to protect us from partioning and handle the quorum
a master and a few redis slaves for failover of master

In the current implementation , the slaves can be selected using the role slave but it picks a rather arbitrary slave. We would propose to have a way to indicate a list of preferred slaves for a client.
This is useful is in multi-AZ aws setups, where we want to keep the latency to app<->slave low .
A new syntax could look like:
var redis = new Redis({
  sentinels: [{ host: 'localhost', port: 26379 }, { host: 'localhost', port: 26380 }],
  preferred_slaves: [ { prio: 10 , host: 'localhost', port: 6381 }]
  name: 'mymaster'
});

Makes sense. Besides a list of preferred slaves, I think we may also accept a function to let user pick up the slave:
var redis = new Redis({
  sentinels: [{ host: 'localhost', port: 26379 }, { host: 'localhost', port: 26380 }],
  preferredSlaves: function (availableSlaves) {
    return _.sample(availableSlaves);
  },
  name: 'mymaster'
});

This feature is what i am looking for.

This is exactly the setup I need as well - any idea when it will be available?

Aha, my fault. It seems that slave priority have to be set on the Redis side. See http://redis.io/topics/sentinel#slaves-priority for details.

I think there is a misunderstanding - the goal isn't to pick a Slave for failover but rather for reads. Assume there are 6 servers, all running Redis and Sentinel.

1 Redis Master
2 Redis Replicas (a slave, but available for failover)
3 Redis Slaves (a slave, but not available for failover)

In the above setup with the 3 "Slaves" running on the application server reads can be made locally to the Slave instance while writes are made to the remote Master. It's assumed that the reads will not always be in sync with the writes based on the asynchronous Redis replication, but in cases where this is OK you get much better performance.
I actually updated the ioredis code/tests to handle this already, and was planning on submitting a pull request.
It accepts either a function (as you suggested) with the available slaves provided as an argument or an array of objects with properties ip, port, and optionally prio (with a default of 1). I used ip rather than host to match the output from the SENTINEL slaves command. The first available "preferred" slave is returned, otherwise the default behavior of returning a random available slave is preserved. The prio isn't the actual slave priority, it is your preference priority - i want to connect to priority 1 because it is local, priority 2 because it is in my network segment, or worst case something else because 1 and 2 are not available. This would not affect failover or Sentinel functionality.
Let me know if you see any issues with the code below in sentinel_connector.js lines 150-204, with var _this = this; at the top of the function on line 136;
// allow the options to prefer particular slave(s)
if (_this.options.preferredSlaves) {
  var preferredSlaves = _this.options.preferredSlaves;
  switch (typeof preferredSlaves) {
  case 'function':
    // use function from options to filter preferred slave
    selectedSlave = _this.options.preferredSlaves(availableSlaves);
    break;
  case 'object':
    if (!Array.isArray(preferredSlaves)) {
      preferredSlaves = [preferredSlaves];
    } else {
      // sort by priority
      preferredSlaves.sort(function (a, b) {
        // default the priority to 1
        if (!a.prio) {
          a.prio = 1;
        }
        if (!b.prio) {
          b.prio = 1;
        }

        // lowest priority first
        if (a.prio < b.prio) {
          return -1;
        }
        if (a.prio > b.prio) {
          return 1;
        }
        return 0;
      });
    }
    // loop over preferred slaves and return the first match
    for (var p = 0; p < preferredSlaves.length; p++) {
      for (var a = 0; a < availableSlaves.length; a++) {
        if (availableSlaves[a].ip === preferredSlaves[p].ip) {
          if (availableSlaves[a].port === preferredSlaves[p].port) {
            selectedSlave = availableSlaves[a];
            break;
          }
        }
      }
      if (selectedSlave) {
        break;
      }
    }
    // if none of the preferred slaves are available, a random available slave is returned
    break;
  }
}
if (!selectedSlave) {
  // get a random available slave
  selectedSlave = _.sample(availableSlaves);
}

Check out the commit in my fork here: https://github.com/doublesharp/ioredis/commit/8dfbe3287208e573056c61bbac191f8d9a855b33

I got your point. The code looks great. Feel free to send a pull request and I'll definitely merge it.

@tangxinfa @jedi4ever this is now included in 2.4.0 :)

If specify referredSlaves option as a function, it's better to pass in local address:
SentinelConnector.prototype.resolveSlave = function (client, callback) {
  var _this = this;
  client.sentinel('slaves', this.options.name, function (err, result) {
    var localAddress = client.stream.localAddress;
    client.disconnect();
    if (err) {
      return callback(err);
    }
    var selectedSlave;
    if (Array.isArray(result)) {
      var availableSlaves = [];
      for (var i = 0; i < result.length; ++i) {
        var slave = utils.packObject(result[i]);
        if (slave.flags && !slave.flags.match(/(disconnected|s_down|o_down)/)) {
          availableSlaves.push(slave);
        }
      }
      // allow the options to prefer particular slave(s)
      if (_this.options.preferredSlaves) {
        var preferredSlaves = _this.options.preferredSlaves;
        switch (typeof preferredSlaves) {
        case 'function':
          // use function from options to filter preferred slave
          selectedSlave = _this.options.preferredSlaves(availableSlaves, localAddress);

Then we can computer ip distance and select the closed one, for example:
function preferLocalSlave(slaves, localAddress) {
    var localIPSegments = new Array(4);
    if (net.isIPv4(localAddress)) {
        localIPSegments = localAddress.split('.');
    }

    var localSlaves = [];
    var remoteSlaves = [];

    for(var i = 0; i < slaves.length; ++i) {
        var slave = slaves[i];
        if (net.isIPv4(slave.ip)) {
            var slaveIpSegments = slave.ip.split('.');
            if (localIPSegments[0] === slaveIpSegments[0] &&
                localIPSegments[1] === slaveIpSegments[1] &&
                localIPSegments[2] === slaveIpSegments[2]) {
                localSlaves.push(slave);
                continue;
            }
        }

        remoteSlaves.push(slave);
    }

    return _.sample(localSlaves.length ? localSlaves : remoteSlaves);
}

There is a even more radicalness slave select algorithm i already implemented in production enveriment, with the flollow proirities:

local slave
local master
remote slave
remote master

This is because we deploy redis replica with 1 Master + 1 Slave, and in different data center to minimize replica throughput between data centers.
See gist https://gist.github.com/tangxinfa/1646be8aa7a6176a3eb731a914e54518 for more information.


Adding pyhc intro slides to hack week repo

This PR will add the PyHC intro slides to the hack week repo. Let me know if anything else is needed!
Thanks,
Julie

Thank you!


Python package or version not found

What is this badge? How do we fix it?

Working now once we published with pypi.


Document how to use Prometheus

In the README file we need to document how to use Prometheus
see #116

Not doing as we will get rid of Prometheus (see #120)


Adding CSS to new domain

Closes #1

Would be useful to add github actions and deployment previews

Why is the site/_build directory being committed to this repo? That should be in the gitignore file.

Ahh I thought I missed the "portal" to "cookbooks" to "site" transition somewhere.

@jukent:  The new Cookbook organization contains a fork of this repository.  So, you don't have to move all of your work to that repo.  You can just merge this PR into this repo as usual, and then we can merge new changes from this repo into the Cookbooks fork.  Once this PR is merged, we can "detach" the Cookbooks fork from this repo and the two will be independent.

@jukent: Why did you close this?

@kmpaul Oops @jnmorley and I just started the process already

So, you cannot delete this repo because the ProjectPythiaCookbooks/projectpythiacookbooks.github.io repo is a fork of this repo!  Just keep working on your PR here, merge it, and we can pull the changes into the cookbooks repo.

So, you cannot delete this repo because the ProjectPythiaCookbooks/projectpythiacookbooks.github.io repo is a fork of this repo! Just keep working on your PR here, merge it, and we can pull the changes into the cookbooks repo.

I deleted my own fork of it (where the PR is coming from).
I made a new PR here https://github.com/ProjectPythiaCookbooks/projectpythiacookbooks.github.io/pull/3

Well, we want a site for the Tutorials org, too.  So, keeping this PR, merging it, and then pulling those changes into the Cookbooks repo would have killed 2 birds with 1 stone.
We'll have to merge from the Cookbooks repo back into this repo when https://github.com/ProjectPythiaCookbooks/projectpythiacookbooks.github.io/pull/3 gets merged, then.

Sorry. I got frustrated that GitHub wouldn't let me have a fork of both the tutorials and cookbooks repositories since they are forked from each other. I cannot undo the deletion of my fork by making a new one (since I made one in the cookbooks repo) but we can still merge this PR as is.

Okay thanks I'll merge it now

Done!


#1876 optimize /ingests/status

Fixes #1876

Checklist

[x] manage.py test passes
[ ] tests are included
[ ] migrations are included
[ ] documentation is changed or added

Affected app(s)

ingest

Description of change

Adjusted some .select_related() and .prefetch_related() targeting /ingests and /ingests/status. See issue for detailed metrics.

Closing in favor of #1877. Added my optimizations on top of that PR.


Cannot Cancel out of Connection Dialog when Launched from Notebooks

Create new notebook
Create new code cell
Press F5 (connection dialog will appear)
Click cancel (or press escape key)
[Nothing happens 😞]

Note: I am not able to repro this behavior for query editor.

Given that January will be forked off of December, moving this to February milestone (where we need to fix this).

Given that January will be forked off of December, moving this to February milestone (where we need to fix this).

@VasuBhog can you take a look? For February release so not immediately urgent.

@VasuBhog can you take a look? For February release so not immediately urgent.

@VasuBhog can you still repro?

@VasuBhog can you still repro?

I can not repro on current Mac insiders. However, I do see it still happening on the first click of cancel on Windows. If a user clicks cancel twice on windows then it will close (workaround).

I can not repro on current Mac insiders. However, I do see it still happening on the first click of cancel on Windows. If a user clicks cancel twice on windows then it will close (workaround).

Reopening for port request

Closing since related PR has merged to release/1.26.


Installation for nni on Azure B1s VM is stuck

Create a B1s type Azure VM (Ubuntu 16.04), and try to follow the command
pip3 install -v --user<EMAIL_ADDRESS>to install nni, but it stuck, the last message is
$ react-app-rewired build --scripts-version react-scripts-ts
    Creating an optimized production build...
    Starting type checking and linting service...
    Using 1 worker with 2048MB memory limit
    ts-loader: Using<EMAIL_ADDRESS>and /tmp/pip-vcid8cpq-build/src/webui/tsconfig.json
    No valid rules have been specified

Need to update documentation to list NNI minimum hardware limitation.

Please use a VM with larger memory (> 4GB), recommend 8GB

Is 4GB enough?

@lipingbj - in v0.3, we start to support pip package install which requires less Memory during installation.
May you try the following method to install with 4GB memory:
python3 -m pip install --user --upgrade nni

@goooxu  Could you please help confirm if it is fixed since NNI v0.3.x?

@yds05 still reproduce in v0.4

For NNI installation, please make sure your system meet the recommended system requirement: https://github.com/Microsoft/nni/blob/master/docs/Installation.md#system-requirements


Allow all valid class names

Is your feature request related to a problem? Please describe.
Currently the pipeline sanitizes class names to lowercase and hyphenated. This negates many valid class names, including the use of BEM notation and others.
Currently class names, such as class--name and class__name, are output as class-name in both cases.
Describe the solution you'd like
Change the names.map function to allow any valid CSS syntax (https://developer.mozilla.org/en-US/docs/Web/CSS/ident), including, but not limited to:

allow uppercase
allow multiple hyphens
allow underscores (single and multiple)

Describe alternatives you've considered
Because this is in the pipeline build, I do not see any other alternatives. Any authored class name gets returned sanitized before block-level code can affect it.

I realize this is a potential breaking change. Is there a mechanism to allow users to opt in? Keep the old, add the new behind a flag?
Tested a possible solution. Existing function on top, proposed on bottom, tested with same data set. Proposed retains casing, converts spaces to hyphens, removes leading/training space and hyphens, allows 1-2 hyphen/underscore.
// Existing function
        function sanitizeNames(names) {
            return names.map((name) => name
                .toLowerCase() // Convert to lowercase
                .replace(/[^0-9a-z]+/g, '-') // Replace non-alphanumeric characters with hyphens
                .replace(/^-+/, '') // Removes leading hyphens from the string
                .replace(/-+$/, '')) // Removes trailing hyphens from the string
            .filter((name) => !!name);
        }

        // Proposed function
        function sanitizeClasses(classes) {
            return classes.map((cls) => cls
                .replace(/[^0-9a-zA-Z_-]+/g, '-') // Allow hyphens and underscores
                .replace(/-{3,}/g, '--') // Replace more than 2 hyphens with exactly 2 hyphens
                .replace(/_{3,}/g, '__') // Replace more than 2 underscores with exactly 2 underscores
                .replace(/^-+/, '') // Removes leading hyphens from the string
                .replace(/-+$/, '') // Removes trailing hyphens from the string
                .trim()) // Remove leading and trailing spaces
            .filter((cls) => !!cls);
        }

        // Test data
        const testNames = [
            "MixedCase123",
            "Space In Name",
            "Under_Score",
            "Hyphen-Case",
            "Bob!@#$%^&*()",
            "  ",
            "-removeLeadingHyphen",
            "removeTrainingHyphen-",
            " removeLeadingAndTrailingSpaces  ",
            "block--element__modifier"
        ];

        // Call the function with test data
        const sanitizedNames = sanitizeNames(testNames);
        const sanitizedClasses = sanitizeClasses(testNames);

        // Log the results
        console.log(sanitizedNames);
        console.log(sanitizedClasses);

the class names are generated from author input in the documents, so the existing transformation rules cannot be changed. also, there is no opt-in mechanism for projects yet.


Concerns About API Key Exposure

Hello, I have been exploring this repository and noticed several issues related to API key exposure. As a user who is keenly interested in the security aspects of this project, I am quite concerned about this issue.
Has this issue been resolved? If so, could you please explain how it was addressed?
Thanks!

We’ve moved away from local storage which were the cause of those issues.


Fix: null attribute check in decisionService and experimentUtils

Pull Request Test Coverage Report for Build 649

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.997%

Totals

Change from base Build 641:
0.0%

Covered Lines:
2386

Relevant Lines:
2681

💛  - Coveralls


Remove toggle_viewTransitions

What?
We have a toggle: 'Use view-transitions API' on the 'Temporary' section of the toggles page. This turns on functionality which uses the web platform View Transitions API to transition between exhibition guide overview pages and individual stops, as well as between stops (using prev/next) links.
This should work on several desktop browsers, as well as Android, and iOS (starting in the latest version – 18).
We need to decide if we'd like to keep this functionality, and if so, move it out from behind the toggle.
@dana-saur @kasiabbb please could you turn the toggle on at the page above, and test the exhibition guide journeys to see if you think we want to use this or remove it. There might also be some scope for finessing transitions, but they don't (currently) offer a great deal of control (just what is possible with css animations).
Why?
Potentially nicer UX.
Background
Done when

[ ] reviewed by designers
[ ] decision made to keep/remove
[ ] toggle code no longer in production

I'm getting this effect on Chrome, for a split second after swiping the previous stop's picture is visible instead of the following stop. I suppose it's a little disorientating, is that something that could be fixed easily or not so much?..
https://github.com/user-attachments/assets/369b1ee4-5e99-4e72-9622-6423647e19ba
It did not work on up-to-date Safari or Firefox for me.
Updating iOS to the version 18 to check there


How to add badge in tree

I want to show count as a badge in tree , my model:
public class TreeDto
{
    public Int64 id { get; set; }

    public Int64 parentId { get; set; }

    public string text { get; set; }

    public Int32 count { get; set; }

    public Decimal minValue { get; set; }

    public Decimal maxValue { get; set; }

    public int viewRank { get; set; }

    public bool hasChildren { get; set; }

    public virtual List<TreeDto> children { get; set; }
}

Please tell me how to do it?

We don't support this yet. We are going to add this feature in future version. Thanks for the feedback.

@atatanasov how about this feature?


ingress-nginx helm chart in AKS walk through is deprecated

Description
The helm chart specified here, https://github.com/retaildevcrews/helium/tree/main/docs/aks, is deprecated. The recommended replacement, https://github.com/kubernetes/ingress-nginx, only works if it is installed in the default namespace. It does not work if you try to install in another namespace.
Possible solutions:

use replacement helm chart and use the default namespace
use the static yaml that installs in the ingress-nginx namespace. https://kubernetes.github.io/ingress-nginx/deploy/#azure
other?

Final solution should take https://github.com/retaildevcrews/helium/blob/main/docs/aks/cluster/manifests/ingress-nginx-namespace.yaml into account.

Get feedback from customer on desired ingress. Also take a look at Azure application gateway ingress controller.
https://docs.microsoft.com/en-us/azure/application-gateway/ingress-controller-overview


cnm,you  don't even write Chinese

cnm,you  don't even write Chinese

hello，已经收到了~

@super117893344p 丢人，最起码的礼貌呢

hello，已经收到了~


Unable to run build command - devPath does not exist

Following the instructions in the readme, I added this to my application. After running dev mode successfully, I tried running npm run vite-tauri build, and got the following error:
13:59:55 PM [vite-plugin-tauri]  Building Vite project...
vite v2.5.1 building for production...
transforming (1) index.html
warn - You have enabled the JIT engine which is currently in preview.
warn - Preview features are not covered by semver, may introduce breaking changes, and can change at any time.
transforming (9<EMAIL_ADDRESS>elm make /Users/lindsaykwardell/dev/juralen-elm/src/Main.elm --output /var/folders/h1/5z847ym134lfkv1tl0f0mm5r0000gn/T/202181-14138-1erk9mp.37rf.js --optimize
Success!     (10<EMAIL_ADDRESS>...

    Main ───> /var/folders/h1/5z847ym134lfkv1tl0f0mm5r0000gn/T/202181-14138-1erk9mp.37rf.js

✓ 13 modules transformed.
dist/index.html                  0.68 KiB
dist/manifest.webmanifest        0.19 KiB
dist/registerSW.js               0.13 KiB
dist/assets/index.ef0d1657.css   13.99 KiB / brotli: 3.19 KiB
dist/assets/vendor.346cc026.js   47.63 KiB / brotli: 17.01 KiB
dist/assets/index.6bb06838.js    84.73 KiB / brotli: 22.62 KiB
13:59:58 PM [vite-plugin-tauri]  Vite build finished.
13:59:58 PM [vite-plugin-tauri]  Building Tauri app...
   Compiling app v0.1.0 (/Users/lindsaykwardell/dev/juralen-elm/src-tauri)
error: proc macro panicked
 --> src/main.rs:8:10
  |
8 |     .run(tauri::generate_context!())
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: message: The `devPath` configuration is set to `"Injected by vite-plugin-tauri"` but this path doesn't exist

error: aborting due to previous error

error: could not compile `app`

To learn more, run the command again with --verbose.

Not 100% certain what to do from here, should I be configuring the plugin somehow to have the correct devpath? Or is the plugin passing the wrong value?

Here's my repo for reference: https://github.com/lindsaykwardell/juralen-elm/tree/tauri

version 0.1.3 is published with the fix.


"delete" keyword on Component attributes does not remove the attribute

delete this.attributes.a

results in nothing happening
this.attributes.a = undefined

works as expected

https://github.com/rbxts-flamework/transformer/commit/39ce0d968ab7b8c1ef383f1ad57c5b6048ba10e2


Navigating walkthrough steps with keyboard doesn't read steps

Testing #228766
I have a walkthrough step selected, I press down key and it switches to next step but it's not read.
https://github.com/user-attachments/assets/c32463b0-c2a7-453a-95ce-c51184bd472f

I experience this with a slightly different keyboard combination too:

Use tab to get to the next step
Use enter to open the actual step info
Nothing is read aloud

You can either learn the keyboard shortcuts to navigate HTML content via screen reader or open the content in the accessible view. Screen reader users like @rperez030  have tested this and confirmed that it does work for them.


getSongsStatePlaylist( playlist )

Issue description
The function Amplitude.getSongsStatePlaylist( playlist ) isnt working.
Environment
Electron 2.0.8 with Chromium  61.0.3163.100 on Windows 10

Amplitude.js Version: "3.3.1"

Steps to reproduce the issue

call the function getSongsStatePlaylist( playlist )
see error

What is expected?
return songArray
Link to where issue can be reproduced
https://jsfiddle.net/qsxjotL4/
Additional details / screenshots
Uncaught TypeError: Cannot read property 'main' of undefined
at Object.getSongsStatePlaylist (amplitude.js:6217)
at updatePlaylistTable (renderer.js:156)
at addToPlaylist (renderer.js:152)
at HTMLButtonElement. (renderer.js:185)
at HTMLDocument.dispatch (jquery.js:5206)
at HTMLDocument.elemData.handle (jquery.js:5014)
Like in the JSFiddle
Fix
Changing "_config2.default.shuffled_status[playlist]" to "_config2.default.shuffled_statuses[playlist]" (In Line 6217) fixed it for me
Edit
Sorry for the previous issuse not following your issue template. I thought it wouldnt fit and as i still think there isnt much someone can verify. The was fix is included, the typo is (as i think) obvious.
Because "shuffled_status" is nowhere else used or declared, i thought a way to reproduce and the environment isnt needed
Your Project is awesome!

Thanks for submitting it again with our template. Although you had a fix, it is helpful for us to have an example so we can make sure it doesn't break other things in other browsers.
@danpastori will take a look into this soon.
Thanks again for making Amplitude better!

This has been fixed in the 4.0 release


Sc-5345:  Copy updates && landing page improvement

Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[x] refactoring

Scope of changes
Sc-5345:  Copy updates && landing page improvement
Acceptance criteria

Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[x]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated ShortCut or Jira ticket to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #529 (6cd372d) into main (e33c1c1) will decrease coverage by 7.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   44.78%   37.47%   -7.32%
==========================================
  Files         470      152     -318
  Lines       13714     2391   -11323
  Branches     1058      608     -450
==========================================
- Hits         6142      896    -5246
+ Misses       6595     1320    -5275
+ Partials      977      175     -802

Impacted Files
Coverage Δ

...omponents/CertificateReview/BasicDetailsReview.tsx

...rc/components/CertificateReview/ContactsReview.tsx

...components/CertificateReview/LegalPersonReview.tsx

...ts/CertificateReview/TrisaImplementationReview.tsx

...i/src/components/CertificateReview/TrixoReview.tsx

...eb/gds-user-ui/src/components/Head/LandingHead.tsx

...ds-user-ui/src/components/Header/LandingHeader.tsx

web/gds-user-ui/src/components/Section/AboutUs.tsx

web/gds-user-ui/src/components/Section/JoinUs.tsx

...user-ui/src/components/Section/SearchDirectory.tsx

... and 308 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33c1c1...6cd372d. Read the comment docs.


Cannot seem to run meta when not a global module

When trying to run meta from local npm modules you get this:
git:(meta)$ ./node_modules/.bin/meta
{ Error: ENOENT: no such file or directory, scandir '/projectName/node_modules/meta/node_modules'
    at Error (native)
    at Object.fs.readdirSync (fs.js:951:18)
    at module.exports.error (/projectName/node_modules/meta/lib/listDirectories.js:32:28)
    at Object.<anonymous> (/projectName/node_modules/meta/bin/meta:13:14)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.runMain (module.js:590:10)
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: '/projectName/node_modules/meta/node_modules' }

Is there anything that could be done about that or it has to be run globally?

What's your use case? Do you have a meta repo of meta repos?

I want for people to just be able to do npm install and for post install to do some meta stuff.

It seems to work fine when I git clone this repo and do a meta link to it.
The npm repo seems to have the issue.

Stuck at a client with low-to-no reception on my cel and no guest network connectivity. Is that the same error message you get when you execute from an npm script?
So, it seems like meta should detect if it's installed globally or as a dependency of another project. Can you try manually commenting this out and seeing if things run? https://github.com/mateodelnorte/meta/blob/master/lib/listDirectories.js#L30-L38
BTW, if you run with DEBUG="*" before your command, you'll get all sorts of additional logging.

You'll need a little more tweaking than just commenting out the above. Basically, do a little work to make it skip the global modules, and see if that gets things going. If so, I can do some work later to have it check whether it's globally installed. Also happy to field PRs. :smile:

Is this only meant to work if globally installed though?

That was the original intention, but I have no qualms updating it to run from within another project/repo. I've had others ask me about support for meta repos in meta repos, but I think they use the globally installed executable.

I think you are a little confused as to the use.
This is a meta repo, I just want to set up a bunch of npm scripts that uses meta, but I dont want to require the people who use the repo to install meta globally -- just to have them as dependencies of the project.

Maybe I am mistaken onto how to use it?

Ah. Gotcha. Yea, generally, you're using meta as a globally installed tool. If you have a meta repo, with a .meta file in it, you would npm i -g meta and then meta git clone [my repo url].git. That would then clone your meta and child repos.
From there, you have access to all the default meta plugins meta git status, etc. Or, you could npm i --save-dev meta-yarn and have access to the yarn plugin. Same with npm i --save-dev meta-gh and viewing issues and prs for your projects.
That said, I'm not against people using it in the way you describe.

 I intend on creating some asciinema vids for all sorts of common usages and to put them on a gh-pages branch soon.

Pretty sure this is resolved by the last commit.

Sounds right. ;) Cheers.


ml2cpp step 12.1 : Pytorch

Pytorch
Follow the six steps described in #1
See : https://github.com/antoinecarme/pytorch2sql

Closing


What prevents windows from using an audio driver?

What would cause windows to not recognize any compatible audio drivers after a windows update?
Drivers have been reinstalled, and they show no issues in devmgmt.
WIndows Audio and Endpoint services are running and showing no issues.
So, if the drivers are fine, and the audio services are fine, why does Windows believe there aren't any audio input/output devices?  Is there a breakdown in the audio engine somewhere?
Is there a way to delete the entire windows audio stack and restore it from an image?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b65f03a-de45-b9db-381b-a9dff007c023
Version Independent ID: 8676d46d-aeea-5809-d8e2-7651a14f709e
Content: Audio Devices Troubleshooting - Windows drivers
Content Source: windows-driver-docs-pr/audio/audio-devices-troubleshooting.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @DOMARS
Microsoft Alias: domars

@philhuy . You should post your query in answers.microsoft.com .

@philhuy -  This particular channel is monitored by the men and women who write the driver developer documentation posted on docs.microsoft.com/drivers. Though we'd like to, we don’t have the resources to provide support for specific scenarios.
For audio driver issues, this article provides some information on audio troubleshooting and covers running the Audio Troubleshooting tool.
https://answers.microsoft.com/en-us/windows/forum/windows_10-hardware/how-to-troubleshoot-sound-problems-in-windows-10/9807857d-632c-465a-ab10-395c4a1f6df4
As Raju mentioned, you may also post your question on https://answers.microsoft.com
Good luck resolving your audio issues.


Unable to download

Hey!
Was really looking to write my own shim application but I found yours yesterday. But I'm facing an issue here.

If possible, I can build it myself. I have Visual Studio Build Tools (2019) installed. Can you provide build instructions?

Okay, I disabled Defender momentarily to download it.
Thanks!


Upstream v5.73.0

Work in progress toward upgrading upstream v5.73.0.
Toward https://github.com/pulumi/pulumi-aws/issues/4665
The ./upstream code does not compile yet due to removal of some of the SDK v1 machinery. I did partially resolve the conflicts though, TBC.

panic: interface conversion: interface {} is nil, not *session.Session

Tests pointing out that reverse-engineering AWS SDKv1 removal need to go a bit deeper, working this out.

ecr/credentials_data_source is maintained by patches and might be affected, need to verify.

@t0yv0 I've added a test for the ECR getCredentials function


Unavailable : JCenter shutting down

The repository JCenter is shutting down from now (and definitively on May, 1st) and the dependency seems to be unavailable elsewhere, some migration is planned?

you can use the one on Jitpack
https://jitpack.io/#TangoAgency/material-intro-screen


Allow module to be resolved by NPM

This change is simple but significant, as it allows NPM to resolve this module properly outside of the React Native environment. Without a file on disk that NPM can resolve (i.e. index.js), it is impossible to mock this library in a testing environment.
const key = require.resolve('react-native-google-signin');

require.cache[key] = {
  id: key,
  filename: key,
  loaded: true,
  exports: GoogleSigninMock,
};

As it stands, the above code will fail, Babel complaining rightly so about MODULE_NOT_FOUND. With this change, the above code will run properly.

@devfd, thoughts?

hey @mikefowler thanks for the PR and sorry for the long wait.


Removing release version

https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/1704

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@JoanneHendrickson PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@JoanneHendrickson Please review my Pull Request. Thank you


learning-goals-readme-done #2

uploaded learning goals , resolves #2

thank you saeed for the comment, I just fixed the typo error.

Nice work!


bug: Union type interface is not generated with codegen with generateInterfaces

Please read our contributor guide before
creating an issue.
Expected behavior
DGS generates an interface for a union type.
Actual behavior
In one of our types, we reference a union type in one of our types, like so:
union FizzBuzz = Fizz | Buzz

type Foo implements Bar {
   fizzBuzz: [FizzBuzz!]!
}

This generates the following:
public interface IFoo {
  List<IFizzBuzz> getFizzBuzz();
}

However, IFizzBuzz is not generated, causing errors on build.
Our build.gradle looks like the following:
generateJava {
    schemaPaths = ["${projectDir}/src/main/resources/schema"]
    packageName = 'com.example.dto'
    generateClient = true
    generateInterfaces = true
    typeMapping = [
            "Locale" : "java.util.Locale",
            "JSON" : "java.util.Map",
            "DateTime" : "java.time.OffsetDateTime",
            "Url" : "java.net.URL"
    ]
}

Steps to reproduce
Note: A test case would be highly appreciated, but we understand that's not always possible

This is a DGS Codegen issue, the repo of such project is https://github.com/Netflix/dgs-codegen


Drop Images Folder

This looks beautiful. It could be even more usable if a folder could be specified where images were stored and then potpack derived the dimensions from the images found there.

Nope. Potpack is intentionally just an algorithm. File handling should be on the user.


Add not null constraint to primary key columns

In PostgreSQL, PRIMARY KEY implicitly adds non-null constraint,
which reflected in the pg_catalog.pg_attribute table and information_schema.table_constraints view.
It's not necessarily a bug, rather improvement of displaying internal state:
CREATE TABLE constraint_test (
    not_null_col int not null,
	pk_col int,
    checked_col int CHECK(checked_col>0),
    PRIMARY KEY (pk_col)
);

1.  information_schema.table_constraints
select constraint_name, constraint_type
from information_schema.table_constraints
where table_name = 'constraint_test' ;

PG13:

constraint_name
constraint_type

constraint_test_checked_col_check
CHECK

constraint_test_pkey
PRIMARY KEY

2200_16385_1_not_null
CHECK

2200_16385_2_not_null
CHECK

CrateDB on current master:
+----------------------------------------------------+-----------------+
| constraint_name                                    | constraint_type |
+----------------------------------------------------+-----------------+
| constraint_test_pk                                 | PRIMARY KEY     |
| doc_constraint_test_not_null_col_not_null          | CHECK           |
| doc_constraint_test_checked_col_check_aff819193feb | CHECK           |
+----------------------------------------------------+-----------------+

not null constraints have to be excluded from table_constraints (we already excluded them from pg_constraints in https://github.com/crate/crate/commit/5cf2caaf23f13f3ff3d5760ce1e33badcf324fe4)
PK columns needs to be shown as CHECK (it's not-null constraint but it's shown here as it's related to table constraint PRIMARY KEY)

2.  pg_catalog.pg_attribute
select attname, attnotnull
   from pg_catalog.pg_attribute
where
attrelid = 16385
   and
attname in ('not_null_col', 'pk_col', 'checked_col');

PG13:

attname
attnotnull

not_null_col
true

pk_col
true

checked_col
false

CrateDB (with  ... where attrelid = -543137618, oid taken from select oid from pg_class where relname = 'constraint_test' )
+--------------+------------+
| attname      | attnotnull |
+--------------+------------+
| not_null_col | TRUE       |
| pk_col       | FALSE      |
| checked_col  | FALSE      |
+--------------+------------+

pk_col is not nullable as it's primary key column.

https://www.db-fiddle.com/f/h6SSAXRC1RYSC5oCrrmQYx/14


More control of application instances

Is your feature request related to a problem? Please describe.
Azure Spring Apps application instances cannot be controlled, for instance it is not possible to reboot or kill a specific application instance.
I had an application with some instances failing due to failing dependency. The application requires a connection to a Postgresql server and there were no more available connections when some application instances started. Once fixed the connections availability it was not possible to reboot the failed instances.
The application remains in update or failed stated and didn't allow to do a manual scale-in.
The only way to fix this situation was to completely stop the application, with a service disruption, and then start the application again.
Another impact is that seems that failed instances were charged to the bill, so there costs charged for failed instances that was not possible to stop.
Describe the solution you'd like
Provide a restart action for application instances. For instance in the CLI or Azure Portal, provide an action to restart an application.
Provide a delete action for application instances. That would automatically scale-in the application, reducing the amount of instances.
Describe alternatives you've considered
The only solution found was stopping the application, fix the issue, and start again. It implies a service disruption.
Describe the Customer Impact
As described above, the only way to fix it is by stopping the application with a service disruption.
Failed application instances are billed and there is no way to stop them without service disruption.
Additional context
Add any other context or screenshots about the feature request here.
Can we contact you for additional details? Y/N
Y
If yes, please send us your contact information to<EMAIL_ADDRESS>and include the issue number in the email title.

@felipmiguel just wonder: if the app met DB connection failure due to DB connection unavailability at that moment, supposedly any follow-up DB queries from that app to the DB should be received on DB side and be judged against current available DB connections there. Why not work in that way? the app should have the capability to keep resilient with its backing services, any of which can fall into unavailability situation any time right?

@taoxu0903 the problem is due to the fact that the connections to the database are created during the startup of the application depending on the connection pool configuration. If it is not able to open a given amount of connections it fails and the application do not start. It is also due to the fact the backend database has a limited number of physical connections, in this case postgresql is configured with 5000 max connections. I had an application with multiple instances, the latest instances to start were impacted because there was no more physical connections, so they couldn't start.
I hope it clarifies the scenario, let me know if you need more details.

We created a work item internally to track this "restart a specific instance" request. It's currently in our backlog.
Currently, the service provides a "Restart" operation for app (in portal or in CLI az spring app restart --help), which allows you to restart a specific deployment in a rolling manner. As long as the health probes and readiness probes are properly defined, this should be a smooth operation without disruption.
For this particular case, a possible way may be treating the "database connection readiness" as a precondition during application start, and fail fast if the connection is not available or broken. When the app instance is failed, the backend will restart this particular instance. So when you fixed the connection limits, it will start normally and go back working.
For "Provide a delete action for application instances. That would automatically scale-in the application, reducing the amount of instances.", it will not be supported. We cannot combine a deletion to a specific instance and a scale-in operation.


Introduce onFailure Handler

When the condition to wait for is not reached within the given timeout it is sometimes useful to dump a more thorough state of the system. Thus a onFailure handler would be useful.

Drafting
It's not only on failure. Probing has a certain life cycle to take into account. Not all of the following steps might be relevant to take into account:
try
  # before loop
  while (time < timeLimit && !success)
    # before loop iteration
    # before state retrieval
    get state
    # after state retrieval
    # before comparison
    check retrieved state
    # after comparison
    # after loop iteration
  elihw
catch problem
   # before problem report
   report problem
   # after problem report
hctac
finally
  # after loop
yllanif


BREAKING CHANGE(rum): resolve main field to source file

This is a bug, We should allow the users of our library to do necessary optimisations(Preferring ES6 or ES5) on the lib.

Blocked by #108


Need to show length of draft straight sketch line segments while placing them

See this flow in Figma
Here is the important step in the flow: it shows a draft line with an annotation of its length shown around its midpoint. This length annotation should update on mouse move:

After the user places the line the annotation should convert to a text input for the user to edit, but this will be covered in a sibling issue.

All right @pierremtb you said send a high priority item your way and so here's one 😆

@lf94 Thanks haha! Will get on it now that the updater stuff is back on track

@pierremtb I'm going to reassign to @franknoirot just because I think he has more capacity to do this right now


The test standard applied

@edevenport Could you please review and merge this PR?

@nurfet-becirevic Can you review and merge this PR? Once that's completed, ping me and I will merge upstream.

@edevenport
ready to merge upstream


CANHUBK3 eth0 down, not able to ping

The default state of eth0 is down, When issuing the command ifup eth0 the interface reports 'okay' but does not init. I am unable to ping out from the device.

Netman manages the eth0 interface and turns it off automatically through link detection.
What network config does netman show?

Hmm, so the ping works with dhcp when the connected to my router via T1 converter, but not able to ping the NavQ plus with a static IP.
By default I don't show a net.cfg in "/fs/microsd/". Even if I create one and echo the key val pairs followed by 'netman update -i eth0' I cant seem to get the static IP to work

Hi, can you show me the "defconfig" file?

Hi, can you show me the "defconfig" file?

https://github.com/dirksavage88/Firmware/blob/master/boards/nxp/mr-canhubk3/nuttx-config/nsh/defconfig


🌐Add Korean translation for docs/ko/docs/help-fastapi.md

Add Korean translation for docs/ko/docs/help-fastapi.md
Related [FEATURE] Korean translations [FEATURE] Korean translations #2017

Same here. Can you split it into several PRs to check each single document?


upgrade  snakeyaml from 1.33 to 2.2

Why are the changes needed?

upgrade  snakeyaml from 1.33 to 2.2 reducing direct CVE vulnerabilities, see (https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes)
CVE-2022-1471
SnakeYaml's Constructor() class does not restrict types which can be instantiated during deserialization. Deserializing yaml content provided by an attacker can lead to remote code execution. We recommend using SnakeYaml's SafeConsturctor when parsing untrusted content to restrict deserialization. We recommend upgrading to version 2.0 and beyond.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No

Codecov Report

Merging #5293 (5b2412d) into master (137dcf1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5293   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         590     590
  Lines       33367   33367
  Branches     4413    4413
======================================
  Misses      33367   33367

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master/1.8


114 - Lower right info box terrain updating

This updates the lower-right info box to display the correct terrain.  I also added bombard stats (if applicable), and updating it when a unit moves.
Remaining caveat: It only updates after unit movement if the unit was not in combat.  The logical place to have it be updated would be in AnimationTracker.cs, in the endAnimation method, but that method is never called.  I tried to trace through the animation to figure out where the logical place for that method to be called would be, and it looks like the update method, line 105, or maybe 111, might be that area.  If we convert the unit guid ("id") to the unit, we could probably call endAnimation.
But I'm not very confident at all changing the unit animation code, and would thus like a second opinion before I go changing it.

The easiest thing would be to call the update method from Game._Process. That way the info box would always be up to date regardless of what happens with combat, etc., because it would get updated every frame. The only potential downside is that it's heavier in terms of performance, but I highly doubt that would matter.
About endAnimation, my plan for that method was that it would be called to stop repeating animations like workers doing their thing and maybe for cases like animations being interrupted by a unit's death or something. It's not called b/c it's not needed right now. All the animations are one-shots that get ended automatically and the unit layer just doesn't draw units with zero HP so their animation state doesn't matter. Eventually endAnimation will be needed.

The easiest thing would be to call the update method from Game._Process. That way the info box would always be up to date regardless of what happens with combat, etc., because it would get updated every frame. The only potential downside is that it's heavier in terms of performance, but I highly doubt that would matter.
About endAnimation, my plan for that method was that it would be called to stop repeating animations like workers doing their thing and maybe for cases like animations being interrupted by a unit's death or something. It's not called b/c it's not needed right now. All the animations are one-shots that get ended automatically and the unit layer just doesn't draw units with zero HP so their animation state doesn't matter. Eventually endAnimation will be needed.

That probably would be the easiest, and for this particular change I don't think it would have a significant performance impact.  What concerns me is the precedent set by tossing re-calculations on Game._Process... if that becomes the default, a whole bunch of small impacts could add up to a quite substantial one.
Maybe stopAnimation would be a slightly better name?  I see the use case, I'd just thought from the name it was intended to be a hook for when the animation ended (in the onStart/onEnd style that many libraries use for hooks).  That can also be for the future though.


Renaming the OS X Platform Conditional Compilation Test

Starting in Sierra, Apple's Mac-based OS (OS X) will be renamed "macOS". All user-facing Swift APIs must go through Swift Evolution. While this is a trivial API change, I have put together a formal proposal as is normal and usual for this process.
This proposal replaces the #if os(OSX) conditional configuration test in Swift with #if os(macOS).
Swift Evolution Discussion: [DRAFT] Aliasing the OS X Platform Configuration	Test
Update Proposal is reverted to form originally presented to list, with aliasing instead of replacement. 6/18/16

Not that this is absolutely necessary, but I think it might be useful if you described where the first code snippet in "Detailed Design" came from.

Hi Erica,
I think we should just accept both of them as aliases.  I'd be willing to consider that a "bug fix" or obvious extension that doesn't require an evolution proposal.

@lattner I'll revert to the original proposal then

@lattner reverted. Please check

@lattner SR-1823

Hello everyone,
Just thought to say finally that you are doing amazing job on this swift evolution project.
Actually I've only started with Swift a month ago and never used this #if syntax yet! So I might be off-topic, or even saying the same as others have already done. #if os(something) looks to me a bit like calling a function with an argument and not following overall clean Swift syntax.
What if it actually looked like
#if os.macOS
#if arch.arm64

or
#if os == .macOS
#if arch == .arm64

and also
#if swift >= 2.2
#if swift == 2.2 || swift == 2.3

All these parenthesis, especially swift(>=2.2) look odd to my eyes.

I think accepting "macOS" as an alias should be considered a bug fix, that doesn't need to go through the evolution process.

Thanks!


Some TerrariaHooks IL Hooks throw errors when using them

Description
When using IL.Terraria.ClassName.MethodName += SomeMethod to hook onto a method and modify it at runtime, regardless of whether SomeMethod does anything, some methods throw the following exception:
System.InvalidOperationException: Sequence contains no matching element
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
   at MonoMod.Utils.ReflectionHelper._ResolveReflection(MemberReference mref, Module[] modules)
   at MonoMod.Utils.DynamicMethodDefinition._GenerateEmit(MethodBase _mb, ILGenerator il)
   at MonoMod.Utils.DynamicMethodDefinition.GenerateViaDynamicMethod()
   at MonoMod.Utils.DynamicMethodDefinition.Generate(Object context)
   at MonoMod.RuntimeDetour.HookGen.HookEndpoint.UpdateILManipulated(Boolean force)
   at MonoMod.RuntimeDetour.HookGen.HookEndpoint.Modify(Delegate callback)
   at MonoMod.RuntimeDetour.HookGen.HookEndpointManager.Modify(MethodBase method, Delegate callback)
   at IL.Terraria.Player.add_PlaceThing(Manipulator )
   at TestMod.TestTile.Autoload(String& name, String& texture) en TestMod\TestTile.cs:line 21
   at Terraria.ModLoader.Mod.AutoloadTile(Type type)
   at Terraria.ModLoader.Mod.Autoload()
   at Terraria.ModLoader.ModContent.<>c.<Load>b__30_0(Mod mod)
   at Terraria.ModLoader.ModContent.LoadModContent(Action`1 loadAction)
   at Terraria.ModLoader.ModContent.Load()
   at Terraria.ModLoader.ModLoader.Load()
   at Terraria.ModLoader.ModLoader.<>c.<BeginLoad>b__36_0(Object _)
   at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

So far i've tested this inside the Autoload method of a ModTile class, and with the following methods (in various orders) WorldeGen.CheckAlch, Player.SmartCursorLookup, WorldGen.TileFrame and Player.PlaceThing, and only the last two ones have thrown the exception.
Steps to Reproduce

Create a simple Mod with a simple ModTile class
In it's Autoload method, add IL.Terraria.WorldGen.TileFrame += SomeMethod
Make SomeMethod but don't add any code to it
Build and load the mod

Expected behavior
The game should load the mod as normal
Actual behavior
An exception is thrown
Reproduction frequency
Always
Versions
tModLoader v0.11 Beta 4
Mods
None
Additional Information
This was first found in a test version of Thorium, then i made a simple test mod and the reproduction steps are the exact same.

Tried IL hooking into PlaceThing myself and got the following:
The mod(s) have been automatically been disabled.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Loot.Loot.<>c.<Load>b__7_0(ILContext il) in Loot.cs:line 43
   at MonoMod.Cil.ILContext.Invoke(Manipulator manip)
   at MonoMod.RuntimeDetour.HookGen.HookEndpoint.InvokeManipulator(MethodDefinition def, Delegate cb)
   at MonoMod.RuntimeDetour.HookGen.HookEndpoint.Modify(Delegate callback)
   at MonoMod.RuntimeDetour.HookGen.HookEndpointManager.Modify(MethodBase method, Delegate callback)
   at IL.Terraria.Player.add_PlaceThing(Manipulator )
   at Loot.Loot.Load() in Loot.cs:line 41
   at Terraria.ModLoader.ModContent.<>c.<Load>b__30_0(Mod mod) in tModLoader\Terraria.ModLoader\ModContent.cs:line 311
   at Terraria.ModLoader.ModContent.LoadModContent(Action`1 loadAction) in tModLoader\Terraria.ModLoader\ModContent.cs:line 355
   at Terraria.ModLoader.ModContent.Load() in tModLoader\Terraria.ModLoader\ModContent.cs:line 306
   at Terraria.ModLoader.ModLoader.Load() in tModLoader\Terraria.ModLoader\ModLoader.cs:line 117
[23:17:02] [8/INFO] [tML]: Disabling Mod: Loot```

Ok, it's most likely an issue with multi-dimensional array get for the tile array:
call      instance class Terraria.Tile class Terraria.Tile[0..., 0...]::Get(int32, int32)

We need a fix in MonoMod for this to be solved. (Upgrade Monomod)

Fixed in a88af31 by upgrading Monomod RuntimeDetours and Utils after fix.
The actual problem lied in:
newobj    instance void string[0..., 0...]::.ctor(int32, int32)
MonoMod did not account for 2d arrays constructors, which make use of newobj compared to newarr for 1d arrays.

Yeah, I remember helping 0x0ade with something like that previously. Hadn't updated MonoMod in a while though while waiting for stable. Are we on latest now?

We're on dev/latest for RuntimeDetours and Utils now, he said nothing else needed update.


Implement email notifications

See: https://docs.google.com/spreadsheets/d/18zrWLqbU_j7PJtCOS5cqFVZnN_OnVninFsqByLVYM4M/edit?gid=1881110513#gid=1881110513 for necessary notification content and trigger logic

@aaron-collier That link above is not right. That's to a file with some text changes that I'd like to see made to a few of the existing email notifications. There are many more than that. Let's discuss what you need here. I did pull out some info about the two that Donna indicated she used. I'll see if I can find that.


Replace chalk by ansis?

I played a bit with colored messages and since I also still have CommonJS projects, and the latest version of chalk no longer supports CommonJS, it was not possible (without using an old chalk version) in the way that was used in your example.
I then solved it with ansis. Wouldn't that also be a good replacement for this project? ansis has a few other advantages besides CommonJS support - check out this comparison.
I could understand if you reject this, as it would probably a breaking change.

Hi @KristjanESPERANTO
Thank you for bringing this to my attention and for your valuable input. I appreciate the time you've taken to explore alternatives and understand your concerns regarding the compatibility of chalk with CommonJS projects.
However, for the "console-stamp" project, I'm planning a transition to TypeScript in the near future. Given this roadmap and the existing integration with chalk, I've decided to continue using chalk for the time being. This decision is based on a few considerations:

Consistency: Staying with chalk maintains consistency in the codebase, which is especially important during the transition to TypeScript.
Stability: chalk has been a stable and reliable dependency for this project, and I'd prefer to minimize the number of major changes during the TypeScript rewrite.
Community Support: chalk is widely used and well-supported in the community, which is beneficial for long-term maintenance and support.

That said, I'm always open to revisiting this decision in the future, especially post the TypeScript migration.
Again, thank you for your suggestion!

Hi @starak! 🙂
Thank you for your clear and insightful answer!
Do you already know if you are dropping CommonJS support through the migration? If you continue to support CommonJS, I am optimistic to find a way for me to use node-console-stamp with ansis instead of chalk. I'll be happy to share my findings with you.
Thank you very much for maintaining this module for over 10 years now! 👏


Updated link in KnownSecurityIssues.md

Updated link in KnownSecurityIssues.md

Thanks @sandakersmann ! Would you like have a more formal participation?

No, but thanks for the offer :)

Ok, let me know if you change your mind :). I have some donation funding to reward contributors.


Add Mission Manager API docs

Add the new OutdoorNav Mission Manager's topics & services to the API docs.
Marked this as WIP until Drew and I are sure the API is in its final state. But a quick once-over to make sure I haven't misformatted anything would be appreciated.

Removed DRAFT label. I think we're ready to merge this. We may have a few final changes to the package names for some messages, but those will be minor corrections and can be done later.


Update hyperlinks to VIPER issues

I've moved the VIPER issues to GitHub. At some point in the future, I may remove them from my personal site.
This PR updates all URLs linking to the VIPER issues hosted on my personal website to reference GitHub instead.

Thanks for the update, @mattmikolay! This is a big help!


Mod option for removing the tank

While the tank does have uses other than attacking biters, it's still a weapon and looks and is described as one, so I'd rather it be removed for my pacifist runs. I understand leaving it in the game by default.
I can probably figure out how to make a PR for this, looking at your existing options for toggling other tech.
(Feel free to ignore this and I can make my own mod to do this if you prefer.)

Hi, thanks for the suggestion, it's absolutely something that should be relatively straight forward to add. I'll have a look when I sit down to work on the mod next time.


duplicate detection example?

need an example for duplicate detection using messageId

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1752a37b-b40a-5613-3416-fd604b281dbc
Version Independent ID: f088004f-f80e-ba5c-e08e-c76ac395c809
Content: Azure Service Bus bindings for Azure Functions
Content Source: articles/azure-functions/functions-bindings-service-bus-output.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hi @bradoyler Thanks for your feedback. We will review and update as appropriate.

@bradoyler Just following up again if you have gone through these and see if it helps.
http://microsoftintegration.guru/2016/09/20/use-azure-function-to-deduplicate-messages-on-azure-service-bus/
https://docs.microsoft.com/en-us/azure/service-bus-messaging/duplicate-detection

@DixitArora-MSFT Hi, I was specifically looking for an example with javascript functions, and I'm not sure if its supported.

@bradoyler As this is something specifically to a Product question , recommendation at this point is to create the product issue to the official Azure Functions Repo for better clarity. Azure Function Repo will be monitored by Product team of Azure function

@bradoyler For now we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


In some instances compiled SQL is incompatible with duckdb client

Twin issue of https://github.com/duckdb/duckdb/issues/4314, it was suggested to continue here.
To reproduce
import duckdb
from sqlalchemy import func, select, create_engine, MetaData, Table

# setup
conn = duckdb.connect("test.duckdb")
conn.execute("create table test (dt date); insert into test values ('2022-01-01');");

# query
engine = create_engine("duckdb:///test.duckdb")
metadata = MetaData(engine)
metadata.reflect()
test = metadata.tables["test"]
part = "year"
date_part = func.date_part(part, test.c.dt)

stmt = select(date_part).select_from(test).group_by(date_part)
engine.execute(stmt).fetchall()

Compiled statement:
SELECT date_part(?, test.dt) AS date_part_1
FROM test GROUP BY date_part(?, test.dt)

So, from our discussion, I see several possibilities:

I just shouldn't generate queries this way with sqla.
There is a bug in duckdb library itself, I guess the consensus is that this is not the case.
The compiled statement is incorrect and it's fixable from within duckdb_engine.
The compiled statement is incorrect and it's only fixable from within the core sqlalchemy library.

As of https://github.com/Mause/duckdb_engine/pull/836 this is now fixed for SQLAlchemy 2+


Latest version not compiling

First time use with the next setup:

OS: Ubuntu Server 22.04 minimised
Kernel: 5.15.0-76-generic
ethercat-igh: ethercat slaves shows slaves for my ethercat NIC
Cargo Version: 1.70.0 (ec8a8a0ca 2023-04-25)

Steps
Just cloned latest version from this repo (git clone https://github.com/ethercat-rs/ethercat.git)
exporting ETHERCAT_PATH so ethercat-sys can find it:
$> ETHERCAT_PATH=/home/user/ethercat-1.5.0/ethercat/
$> export ETHERCAT_PATH

ethercat-sys is build successfully but ethercat fails:

$> cargo build
   Compiling ethercat v0.3.0 (/home/gpg/ethercat-test/ethercat)
error[E0308]: mismatched types
  --> src/convert.rs:27:8
   |
27 |     Ok(foe_name)
   |     -- ^^^^^^^^ expected an array with a fixed size of 255 elements, found one with 32 elements
   |     |
   |     arguments to this enum variant are incorrect
   |
help: the type constructed contains `[i8; 32]` due to the type of the argument passed
  --> src/convert.rs:27:5
   |
27 |     Ok(foe_name)
   |     ^^^--------^
   |        |
   |        this argument influences the type of `Ok`
note: tuple variant defined here
  --> /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs:507:5

For more information about this error, try `rustc --explain E0308`.
error: could not compile `ethercat` (lib) due to previous error

Workaround
Edit convert.rs so the function string_to_foe_name admits and returns a 255 array.
Now it compiles.  All examples run:
$> cargo run --example
error: "--example" takes one argument.
Available examples:
    cyclic-data
    foe-read
    foe-write
    info
    sdo

$> cargo run --example cyclic-data
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
     Running `target/debug/examples/cyclic-data`
usage: ethercat ESI-FILE
$> cargo run --example foe-read
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/examples/foe-read`
Usage: foe-read <slave-position> <foe-name>
Error: Custom { kind: Other, error: "Not enough arguments" }
$> cargo run --example foe-write
   Compiling ethercat v0.3.0 (/home/gpg/ethercat-test/ethercat)
   Finished dev [unoptimized + debuginfo] target(s) in 0.39s
     Running `target/debug/examples/foe-write`
Usage: foe-read <slave-position> <foe-name> <file>
Error: Custom { kind: Other, error: "Not enough arguments" }
$> cargo run --example foe-write
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/examples/foe-write`
Usage: foe-read <slave-position> <foe-name> <file>
Error: Custom { kind: Other, error: "Not enough arguments" }
$> cargo run --example info
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/examples/info`
EtherCAT Master: Ok(
    MasterInfo {
        slave_count: 8,
        link_up: true,
        scan_busy: false,
        app_time: 0,
    },
)
$> cargo run --example sdo
    Finished dev [unoptimized + debuginfo] target(s) in 0.02s
     Running `target/debug/examples/sdo`
Could not find any SDOs

I hope this helps.

Please check out the stable-1.5 branch in the IgH repository. This library works against that branch, not master.

Hi again,
I get your point checking out the stable-1.5 branch of IgH repository as it is indicated in the readme file. This repo is not responsible for changes in IgH repositories.
The modification I did to this repo code to make it run was to change the hardcoded size of an array and some assertions about it. the error thrown by cargo is E0308 mismatching types error. I might be wrong but the issue that I am facing has to do with rust code.
I am aware that you are an expert in rust while I am just starting. Maybe I mislead you with the title of the issue?

Hi again,
I get your point checking out the stable-1.5 branch of IgH repository as it is indicated in the readme file. This repo is not responsible for changes in IgH repositories.
The modification I did to this repo code to make it run was to change the hardcoded size of an array and some assertions about it. the error thrown by cargo is E0308 mismatching types error. I might be wrong but the issue that I am facing has to do with rust code.
I am aware that you are an expert in rust while I am just starting. Maybe I mislead you with the title of the issue? In any event, thanks for this repository.

I'm sorry, I don't fully understand your comment. After you switch the IgH code to the stable-1.5 branch, this library should compile fine. One of the changes between stable-1.5 and master is that they changed the size of the array in question from 32 to 255 items.
You may have to cargo clean before rebuilding though, I don't think the build system is clever enough to realize that the C header has changed.


[DS-4126] 4x: Optimize docker builds

Port of https://github.com/DSpace/DSpace/pull/2307
Images have been built on DockerHub at terrywbrady/dspace.

verifyImages.sh has been run
 ===== dspace-4_x-jdk7 =====
DSpace version:  4.10-SNAPSHOT
           JRE:  Oracle Corporation version 1.7.0_181
  ---> http://localhost:8080/xmlui
  ---> http://localhost:8080/oai/request
  ---> http://localhost:8080/solr
  ---> http://localhost:8080/rest
$ ../../tools/verifyImages.sh
 ===== terrywbrady/dspace:dspace-4_x-jdk7-test =====
DSpace version:  4.10-SNAPSHOT
           JRE:  Oracle Corporation version 1.7.0_181
  ---> http://localhost:8080/xmlui
  ---> http://localhost:8080/oai/request
  ---> http://localhost:8080/solr
  ---> http://localhost:8080/rest

@terrywbrady After running docker build -f Dockerfile.jdk7 -t p/dspace:4 ., export DOCKER_OWNER=p; export DSPACE_VER=4 and then changing directories to the docker-compose files to run docker-compose -p d4x -f docker-compose.yml -f d4.override.yml up, all I see is:

I expected to see the picture

@PTrottier , thanks for testing.  I see this as well. I believe that in DSpace 4 the indexer does not run immediately on startup.  Please run "docker exec dspace /dspace/bin/dspace index-discovery".
The content should be visible after you run that.
I logged an issue in DSpace-Docker-Images to see if that step can be automated for DSpace 4.  https://github.com/DSpace-Labs/DSpace-Docker-Images/issues/78

@terrywbrady Yes, that solved the issue.


[Form] get values behavior does not  return logical value

      <input type="radio" name="r1" value="0" checked>
      Zero

      <input type="radio" name="r1" value="1">
      One

      <input type="checkbox" name="c1"  checked>
      Check

$('.ui.checkbox').checkbox();
console.log($('.ui.form').form('get values'));
$('input[name="r1"]').val('1');
$('input[name="c1"]').parent().checkbox('set unchecked');
console.log($('.ui.form').form('get values'));

Actual Result
Object { r1: false, c1: "on" }
Object { r1: "1", c1: false }

Expected Result
Object { r1: "0", c1:true }
Object { r1: "1", c1: false }

or
Object { r1: "0", c1:1 }
Object { r1: "1", c1: 0 }

Version
2.4.0
Testcase
http://jsfiddle.net/4eghqcrv/

I find the same trouble.
“get values” returned "on" and false.
but "set values" will not treat "on" as true...

The radio value ("0" instead of false) was fixed in the community fork Fomantic-UI by https://github.com/fomantic/Fomantic-UI/pull/1328
However, providing the value for the checkbox is intented because you can specify a custom value for a checkbox input field and implemented by https://github.com/Semantic-Org/Semantic-UI/pull/2979
Related issue https://github.com/Semantic-Org/Semantic-UI/issues/2954
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-value

The radio value ("0" instead of false) was fixed in the community fork Fomantic-UI by fomantic/Fomantic-UI#1328
See your adjusted jsfiddle here http://jsfiddle.net/lubber/gjLbqz5p/
However, providing the value for the checkbox is intented because you can specify a custom value for a checkbox input field and implemented by #2979
Related issue #2954
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-value

The unacceptable thing is the difference between "set vaules" and "get values".

@landall
I prepared a PR to also support "on" as a trigger to check the checkbox in the community fork Fomantic-UI by https://github.com/fomantic/Fomantic-UI/pull/2077


Minify js

Inserted webpack feature to minify JS.

After running npm build I get this warning. @ManrajGrover , any idea if this will work or not?
bundle.js has been reduced from ~1MB to 336 kB

Version: webpack 1.13.3
Time: 6514ms
Asset    Size  Chunks             Chunk Names
bundle.js  336 kB       0  [emitted]  main

266 hidden modules

WARNING in bundle.js from UglifyJs
Dropping unused variable testrepo [./index.js:110,8]
Dropping unused variable notFound [./index.js:111,8]
Condition always true [./~/react/lib/traverseAllChildren.js:136,0]
Condition always true [./~/react/lib/ReactDOMComponentTree.js:97,0]
Condition always true [./~/react/lib/ReactDOMComponent.js:982,0]
Condition always true [./~/react/lib/ReactMultiChild.js:265,0]
Condition always true [./~/react/lib/ReactMultiChild.js:285,0]
Condition always true [./~/react/lib/instantiateReactComponent.js:91,0]
Condition always true [./~/react/lib/ReactNodeTypes.js:36,0]
Side effects in initialization of unused variable Transaction [./~/react/lib/ReactServerUpdateQueue.js:18,0]
Condition always true [./~/react/lib/findDOMNode.js:54,0]
Condition always true [./~/react/lib/findDOMNode.js:56,0]
Dropping side-effect-free statement [./~/react-router/lib/deprecateObjectProperties.js:67,0]
Side effects in initialization of unused variable _ret [./~/react-router/lib/deprecateObjectProperties.js:65,0]
Side effects in initialization of unused variable history [./~/react-router/lib/InternalPropTypes.js:20,0]
Side effects in initialization of unused variable components [./~/react-router/lib/InternalPropTypes.js:30,0]
Side effects in initialization of unused variable routes [./~/react-router/lib/InternalPropTypes.js:32,0]
Dropping side-effect-free statement [./~/react-router/lib/makeStateWithLocation.js:41,0]
Side effects in initialization of unused variable _ret [./~/react-router/lib/makeStateWithLocation.js:39,0]
Condition always true [./~/react-router/lib/IndexRedirect.js:58,0]
Condition always true [./~/react-router/lib/Redirect.js:97,0]
Condition always true [./~/react-router/lib/IndexRoute.js:55,0]
Condition always true [./~/react-router/lib/Route.js:52,0]
Condition always true [./~/history/lib/createMemoryHistory.js:67,0]
Side effects in initialization of unused variable _reactRouter [./components/AccCardComponents.js:2,0]
Condition always true [./~/marked/lib/marked.js:1276,0]
Dropping unreachable code [./~/marked/lib/marked.js:1278,1

Nevermind turning off compression

Anyone in @o-d-i-n/helloworld please test this branch out as soon as possible.


Issues reproducing results

Hello, thanks for your work, and for making your code available.
I am having issues reproducing your results on CelebA, the network seems to converge up to around iteration 15k, but then the image quality degrades until becoming nothing recognizable.
I used the command python train_surf.py --output_dir exp_name --curriculum CelebA_single, with nothing changed from your code.
The python env was created using your instructions in "Create virtual environment".
I ran the training process 3 times, and consistently obtained this result.
Here are random samples at 15k, and 40k:

Hi @NOlivier-H , Thanks for you attention.
I just checked the train and curriculum files, I found that the batch size (now 14) is wrong.
For the first stage, I used the batch_size: 56 (not 14) At each stage, the batch size is multiplied by 1/4.
I forgot to change the original value after experimenting with my code under different conditions.
Therefore, please  change the value of batch_size of the first stage in curriculums.py-CelebA_single.
Generally, with higher batch_size, you can expect higher quality. so set the maximum batch size for your GPU.

I changed batch_size of the first stage 14-->56


Event counter alternates after swap if it has timers

To reproduce:

Open clock example (below)
wait for it to tick a while (to step x)
edit, causing swap. module has paused, but event count keeps going up (?)
press pause & play to restart it (see other bug TODO).

The clock hand starts ticking again, but the event count on the scrub slider is alternating between lower and higher values (both ticking up)
This alternation doesn't happen if you repeat the same process on a module without timers (e.g. stamps or keyboard examples).
import Color exposing (..)
import Graphics.Collage exposing (..)
import Graphics.Element exposing (..)
import Time exposing (..)

main =
  Signal.map clock (every second)

clock t =
  collage 400 400
    [ filled lightGrey (ngon 12 110)
    , outlined (solid grey) (ngon 12 110)
    , hand red 100 t
    , hand charcoal 100 (t/60)
    , hand charcoal 60 (t/720)
    ]

hand clr len time =
  let
    angle = degrees (90 - 6 * inSeconds time)
  in
    segment (0,0) (fromPolar (len,angle))
      |> traced (solid clr)

I would guess that this is related to the asyncCallbacks array. It was never clear to me if that should be all the async callbacks ever, or just the currently pending ones. Point is, I bet there is a problem there and it could explain this.


perf: misc internal performance improvements

Alias type annotations
Use PEP 563 type annotations
Simplify ConcurrentAsyncExecutor
Optimize DAG building and execution by minimizing attribute access and removing redundant checks
Don't automatically convert Scope keys to list
Add __slots__ to various classes w/ heavy attribute access
Remove ConcurrentAsyncExecutor, it is not needed and can be implemented by users

Codecov Report

Merging #38 (5918b40) into main (9320dea) will decrease coverage by 0.98%.
The diff coverage is 99.00%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   98.01%   97.02%   -0.99%
==========================================
  Files          60       60
  Lines        1963     1919      -44
  Branches      227      156      -71
==========================================
- Hits         1924     1862      -62
- Misses         27       36       +9
- Partials       12       21       +9

Impacted Files
Coverage Δ

tests/test_binding.py
92.06% <ø> (-7.94%)
:arrow_down:

tests/test_execute.py
98.32% <ø> (-1.15%)
:arrow_down:

di/_utils/task.py
98.79% <94.44%> (-1.21%)
:arrow_down:

di/_utils/dag.py
100.00% <100.00%> (ø)

di/_utils/execution_planning.py
100.00% <100.00%> (ø)

di/_utils/scope_map.py
100.00% <100.00%> (ø)

di/_utils/scope_validation.py
100.00% <100.00%> (ø)

di/_utils/state.py
100.00% <100.00%> (ø)

di/container.py
100.00% <100.00%> (ø)

di/dependant.py
88.05% <100.00%> (-2.85%)
:arrow_down:

... and 16 more


feat: A lin. indep. family of vectors in a fin. dim. space is finite

This is just a repackaging of existing lemmas, except that the correct name is already taken by the Set version, so we fix that too.
From LeanAPAP

Let's merge this first and I can incorporate this into the generalizing PR afterwards.
maintainer merge

Thanks!
bors merge


Refactor the code to move the util and reusable functions to the IRG.util namespace

In general, any function that can be used by more than one piece of code should be moved to the IRG.util

This is done... for now! Let's try to keep the tech debt as low as possible moving forward!


Fixed alpha values for generated canvas styles

fillStyle/strokeStyle colors in "rgba(r, g, b, a)" format take alpha as
a value between 0 and 1. A few utility functions created strings with
alpha values between 0 and 255.

My gut feeling is that the internal color.a value should always be 0..255 and that it should only be converted to 0..1 for the rgba() string. So perhaps it is best to change createColor to switch to 0..255 for the internal value as well.
The rgba property of a color, as far as I can tell, isn't used even once in Phaser itself.
updateColor takes a color object, not raw values. I'm hesitant to make an API breaking change here, and equally hesitant to introduce a new function.

@wayfu One of the problems is "a color object" isn't well-defined.
My first step when approaching a problem like this is first updating the documentation to reflect the current behavior. This may defining what "a color object" is better in context.
Then the current code can be compared vs the documented (as in what the function does) behavior - does the current code hold? If so, then don't change the function in a way incompatible with the documentation (and this may be "accepts 0..1 or 0..255" but you'll have to carefully identify it).
I believe rgba is primarily (only) used in a few cases, such as for background colors (eg. when the color setting bleeds down to pixi.js). More generally it may be useful for CSS - although that's outside of core.

The only places Phaser uses the rgba property of a color object is to pass
colors to a callback in bitmapData per-pixel functions. These use rgba(r,
g, b, a) with a = [0..1]. My changes do not break anything there.
Inconsistencies in the Color set of methods can be explained by different
authors. Some functions were clearly written as helpers for the specific
bitmapData.processPixel use case. There, the explicit purpose of providing
that string is that it will be useful for styles.
My PR updates the documentation.
2015-01-05 5:25 GMT+01:00 pnstickne<EMAIL_ADDRESS>
@wayfu https://github.com/wayfu One of the problems is "a color object"
isn't well-defined.
My first step when approaching a problem like this is first updating the
documentation to reflect the current behavior. This may defining what "a
color object" is better in context.
Then the current code can be compared vs the documented (as in what the
function does) behavior - does the current code hold? If so, then don't
change the function in a way incompatible with the documentation (and this
may be "accepts 0..1 or 0..255" but you'll have to carefully identify it).
I believe rgba is primarily (only) used in a few cases, such as for
background colors (eg. when the color setting bleeds down to pixi.js). More
generally it may be useful for CSS - although that's outside of core.
—
Reply to this email directly or view it on GitHub
https://github.com/photonstorm/phaser/pull/1506#issuecomment-68667146.


Repo sync for protected CLA branch

The pull request is created from main637823811405009713 to main to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Initialization

Hello, sorry for newb question. Lacking documentation online for this api, so i'm asking here.
Having problems with initializing client. Not sure what "session" is. Could you please provide me with simple example? Thanks in advance.

Hi, could you please provide the command you are trying to run or the output of the command or the debug log for additional context? Thx

Closing due to inactivity


Allow changing order of tabs in dashboards

Allow changing order of tabs in dashboards
This was added 20 days ago to Superset master:

https://github.com/apache/incubator-superset/pull/7390
https://github.com/apache/incubator-superset/commit/9e703f399b78af1a198ba5d69353385b77dd701e

I'm not sure whether it made it into any release yet (0.33.0rc1)?
Opening the issue here just to track ourselves.

It's not in 0.33.

Workaround:

Open Dashboard.
Press Edit dashboard.
Press  Edit dashboard metadata. (press an arrow close to Switch to view mode to see this button)
Go to Position JSON field.
Find "type":"TABS" (in the end of the JSON in my case) and change the order of the "children"  on the same level.

Example:
{

"...": {"..."},

"TABS-y3H9K9tIPM":
    {"children":["TAB-6pFKAgBaT","TAB-jKeAvr9fJ","TAB--aWoyKHn5","TAB-2DqtP-p_8","TAB-kb1aHKZWeK"],
    "id":"TABS-y3H9K9tIPM","meta":{},"type":"TABS"}}
}

If we want to change 1st and 2nd tabe we should change 1st and 2nd strings in children field:
{

"...": {"..."},

"TABS-y3H9K9tIPM":
    {"children":["TAB-jKeAvr9fJ","TAB-6pFKAgBaT","TAB--aWoyKHn5","TAB-2DqtP-p_8","TAB-kb1aHKZWeK"],
    "id":"TABS-y3H9K9tIPM","meta":{},"type":"TABS"}}
}

Press Save button.