Displaying HTML in Quill (or converting it to Delta)

I am looking for a WYSIWYG editor to allow users to edit their email footer. This means that the output needs to be in HTML. I'm able to grab the HTML from Quill using the following:
$("#settings-footer-text-mirror").html(quill.root.innerHTML);

Note: I am simply copying the HTML to a textarea on form submit as I can't apply a name attribute to quill which is fine
That all works and I have the raw HTML from quill. How do I go about doing the reverse? I've tried the following:
const editor = new Quill("#settings-footer-text", options);
const delta = editor.clipboard.convert(html);
editor.setContents(delta, "api");

but the delta insert still contains the HTML tags in the final output. I've also tried
editor.clipboard.dangerouslyPasteHTML(html);

That does pretty much the same thing.
An example of the HTML I'm trying to convert would be:

Hello World

Any help on this? I've seen a lot of discussion talking about retrieving HTML but I also want to allow users to edit the footer when required which means placing existing content back into the quill editor.
Platforms:
Windows 10
Chrome 84
Version:
1.3.6

The problem of clipboard.convert (html) in version 2.0 has still not been solved.

Yes, using Quill inside an Angular app (via ngx-quill) does not seem to work in any reasonable manner if trying to update the editor contents dynamically. Only reasonable way to insert HTML string (created by the editor itself) and have proper formatting applied is to directly replace quill.root.innerHTML. Clipboard's conver() and dangerouslyPasteHTML() methods insert only text content.
Only if the formcontrol value is patched (Angular reactive forms) before the editor is rendered, then the HTML will be displayed properly.
Maybe it's a browser engine thing. But so far Chromium and Firefox behave in the same way.


Enhancing the elm dependencies install command

I think enhancing the "install dependencies" command into something like this would be pretty neat:

As it says in the input placeholder, you can just press  <esc> to install all packages already listed in elm-package.json (as the command currently works now), or pick a new package to install.
It could be done as a separate command, but I kinda wanted to avoid that, since I kinda feel the extension has too many commands already :)
Just wondering what other's input was.

PR merged and released


Please install TA-Lib to use 2crows. (pip install TA-Lib) message ...

Which version are you running? The lastest version is on Github. Pip is for major releases.
import pandas_ta as ta
print(ta.version)

0.3.14b0
Do you have TA Lib also installed in your environment?
$ pip list

yes

Did you upgrade? Did the upgrade resolve the issue?
$ pip install -U git+https://github.com/twopirllc/pandas-ta

Yes.. i have installed talib using the updated version only as mentioned in the readme...
Describe the bug
[A clear and concise description of what the bug is.]
i am simply trying to import ticker data from yfinance and using df.ta.strategy(ta.AllStrategy) to build all the indicators. However, i am getting messages saying: Please install TA-Lib to use 2crows. (pip install TA-Lib)
first 7 lines of the output of df.ta.strategy(ta.AllStrategy)
0it [00:00, ?it/s][X] Please install TA-Lib to use 2crows. (pip install TA-Lib)
[X] Please install TA-Lib to use 3blackcrows. (pip install TA-Lib)
[X] Please install TA-Lib to use 3inside. (pip install TA-Lib)
[X] Please install TA-Lib to use 3linestrike. (pip install TA-Lib)
[X] Please install TA-Lib to use 3outside. (pip install TA-Lib)
[X] Please install TA-Lib to use 3starsinsouth. (pip install TA-Lib)
[X] Please install TA-Lib to use 3whitesoldiers. (pip install TA-Lib)
To Reproduce
Provide sample code.
Code:
(https://colab.research.google.com/drive/1eGviU_45HrZLDj_hSHLvXkTvw2gln-vd?usp=sharing)
Expected behavior
A clear and concise description of what you expected to happen.
My expectation is what is written in the readme that "Runs and appends all indicators to the current DataFrame by default"
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
I want to generate all the indicators at one go.. Also, I am seeing many indicators are having Null. Not sure whether it is because of the installation issue itself mentioned previously..

Thanks for using Pandas TA!

Hello @tbeesofar,
Actually, you have tblib installed... not talib. In fact, I don't even know what tblib is? Pandas TA was correct in identifying that you do not have talib installed. Please follow in the instructions at TA Lib to properly install it.
If you installed it correctly, you should see it in the pip list like so:

Furthermore you said you upgraded Pandas TA, but you listed version v0.3.14, which is the last pip version. I recommend that you upgrade to the development version instead since many bugs and features in the Current Issues list have been fixed.
$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development

Let me know on your progress!
Kind Regards,
KJ

Moreover, You also need to install the TAlib from source (the real one build from source), the python TAlib is just a wrap of real TAlib.

Hi @baotang2118 @twopirllc for pointing out the error and taking time out to respond.. I gave it another try..
I was able to install it successfully in jupyter-notebook in my local system.. However, when i am trying to install the talib in google colab, it is giving me below error.. Is there anything else i have to keep in mind while installing talib in google collab?
Collecting TA-Lib
Downloading TA-Lib-0.4.24.tar.gz (269 kB)
|████████████████████████████████| 269 kB 19.3 MB/s
Requirement already satisfied: numpy in /usr/local/lib/python3.7/dist-packages (from TA-Lib) (1.19.5)
Building wheels for collected packages: TA-Lib
Building wheel for TA-Lib (setup.py) ... error
ERROR: Failed building wheel for TA-Lib
Running setup.py clean for TA-Lib
Failed to build TA-Lib
Installing collected packages: TA-Lib
Running setup.py install for TA-Lib ... error
ERROR: Command errored out with exit status 1: /usr/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-s8i90642/ta-lib_c8e50c5fd0b74dc881799251aaec7be1/setup.py'"'"'; file='"'"'/tmp/pip-install-s8i90642/ta-lib_c8e50c5fd0b74dc881799251aaec7be1/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(file) if os.path.exists(file) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' install --record /tmp/pip-record-lrsymhg8/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/include/python3.7/TA-Lib Check the logs for full command output
Jupyter

Google collab:

Sorry if it is a lame question and i am missing out on something very trivial

@tbeesofar,
Sorry, been very busy. I know there is an Issue where someone got it working with Collab. Not exactly sure which it was, but I will update the Issue when I find it.
KJ

Hi @tbeesofar,
Were you able to figure it out? If so, your solution would help us all.
If you are still working on it, I wonder if Issue https://github.com/twopirllc/pandas-ta/issues/329 may help? I recently read that TA Lib requires/prefers that numpy is installed before TA Lib. 🤷🏼♂  But I would check on TA Lib Issues also if you haven't already.
KJ

Sorry @twopirllc , i didn't try my hands on using talib in google collab lately. Have been using talib in jupyter notebook and exporting the calculated data and importing it in google collab for the time being as a workaround.
Today, i tried the resolution given in issue #329, i was able to install it successfully in google colab.
You may choose to close this ticket if you want and let me know if you get to know anything else in the future.
keep the good work up,
Thanks
Tuhin

@tbeesofar,
Thanks!
Thanks for replying and letting me know what's happening.
KJ


devbox: 0.1.2 -> 0.2.0

Description of changes
Devbox 0.2.0 Release Notes + Changelog
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Tested basic functionality of build by running:
➜  nix-build $NIXPKGS -A devbox
/nix/store/kha5k17w8s8c6nh2ii49hmvqg5dksxm4-devbox-0.2.0
➜  /nix/store/kha5k17w8s8c6nh2ii49hmvqg5dksxm4-devbox-0.2.0/bin/devbox version
0.2.0

this duplicates #207792

Ah great! Looks like I just missed it. The changes seem identical so we can merge that one and close this.


fix docs badges in readme

The badges in the docs subsection point to the old-style Documenter.jl URLs,
instead of the correct ones (which are used for the badges at the top) so I just
copied those.

duplicate of #225 and #227


Can this be considered as poor nesting in the code?

https://github.com/clemahieu/raiblocks/blob/master/rai/node/common.cpp#L79
Thanks

no that's how you can do it

I'd agree that it's poorly constructed, but reteps is correct in that you "can" do it that way -- it's just pretty ugly. One fix would be to invert the if's and have early return statements inside each. That'd be my preference.

Yeah the code is pretty ugly. I wonder if it's done that way for some particular reason, for example, efficiency, or if it's because the coder didn't know better. I remember working on similarly ugly looking code before, but it was very efficient.

I saw a comment from Colin (lead dev) that indicated his preference was to have only 1 return statement per function. His provided reason was that he believed it made the code easier to split up into smaller chunks as it grew (paraphrasing). So I don't think it's a matter of efficiency in this case, but rather a style preference.


Xhamster url

Hello, I would like to ask for an improvement.
The url of xhamster now contains a country prefix, here for me which is Brazil the url begins with pt
https://en.xhamster.com/
When I paste the link in the ripme it accuses error that does not recognize the url

This repo is old and unmaintained, please remake this issue at https://github.com/RipMeApp/ripme


fix(datepicker): do not focus input element after selecting date

The focus causes the soft-keyboard to popup in mobile safari, which is rather unpleasant for the user.
We could also make this a configuration option but I fear proliferation of options is not a good idea.

Please rebase.

In general, I think selecting the input is the correct behavior - this is due to how forms work, and if the form is set up right, it allows the user to just hit enter and submit the form.
Maybe supporting an optional callback that gets fired if it is present instead of changing this behavior completely would be better.
This feature would require a documentation change.

@wesleycho In my opinion, we should keep the focus on the input as-is. Implementing a feature like this one will probably be bad for accessibility.

Well, in its current state at least it has a very bad user experience on
mobile causing the keyboard to pop up intermittently. Not sure how other
datepickers solve this?
That we want to have focus for submit on enter and accessibility makes
sense.
Am 05.06.2015 05:02 schrieb "Robin van Baalen"<EMAIL_ADDRESS>
@wesleycho https://github.com/wesleycho In my opinion, we should keep
the focus on the input as-is. Implementing a feature like this one will
probably be bad for accessibility.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/bootstrap/pull/3720#issuecomment-109149287
.

How about using an input with type="date"?

Considering that this seems to be against all recommendations on accessibility for datepickers, I am closing this PR.
Any solution to this issue must not break browser accessibility as a default - here is the WAI-ARIA specifications for datepickers, and here is an example of a datepicker that conforms to the guidelines.


Relationship fetch does not provide "Assume refrential integrity" checkbox information

Hi @Hugoberry ,
I see that we have added relationships in the library but it does not show information about Assume refrential integrity checkbox information from Power BI. Can we please add that information as well? It would help me a lot in comparing two Power BI files datamodel.

I've added a new column, RelyOnReferentialIntegrity, that should be storing the value for the flag Assume referential integrity.
It is available in v0.1.18 of the library.


Slow down evm event checking

Related Github tickets

https://github.com/palomachain/paloma/issues/976

Background
This was previously checking every 5 seconds for events to send a token to Paloma.  This may be unnecessarily using up RPC calls for pigeons when not much is happening.  Slowing this down, which will effectively reduce the call numbers while batching events that may happen together.
Also removed an unused interval accidentally left in
Testing completed

[x] this is a loop interval, no tests exist or are needed for it
[ ] tested in a private testnet

Breaking changes

[x] I have checked my code for breaking changes

@ToasterTheBrave Thanks. understdood.

I'm interested to know how the value of 1 minute was decided.  Is this an arbitrary constant?

@pegahcarter it's a best guess. the volume of rpc queries on the validator endpoints were hitting millions per month with every five seconds. this change will need to be eventually dynamic and based on the bridge volume for each particular chain level of bridge activity. lots of optimizations to explore. 1 minute was immediate relief without losing the bridge security model.


”Dumbrăvița”, ”Săcămaș”, ”Sârbi”, ”Valea Lungă” are listed in the drop-down menu

Description:
When user writes ”Dumbrăvița”, ”Săcămaș”, ”Sârbi”, ”Valea Lungă” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Dumbrăvița"

Expected results
The location appears in the drop-down menu as "Sat Dumbrăvița, HUNEDOARA (Ilia)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Săcămaș"

Expected results
The location appears in the drop-down menu as "Sat Săcămaș, HUNEDOARA (Ilia)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Sârbi"

Expected results
The location appears in the drop-down menu as "Sat Sârbi, HUNEDOARA (Ilia)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Valea Lungă"

Expected results
The location appears in the drop-down menu as "Sat Valea Lungă, HUNEDOARA (Ilia)".


Increase gRPC request timeout to 45 seconds

Since #2375 was merged, we've been getting context deadline exceeded while sending large raft snapshots. After investigation from @anshulpundir and I, it seems that the gRPC context timeout was too short at 2 seconds to be sufficient for sending large snapshots. This PR increases the default value to 45 seconds. Testing from @davidwilliamson confirms that this fixes the issue.
cc @anshulpundir @aluzzardi @stevvooe @aaronlehmann @marcusmartins @mghazizadeh
Signed-off-by: Nishant Totla<EMAIL_ADDRESS>

i'm pretty sure that's going to mean it takes 45 seconds to recognize that a raft member is down.

I think @dperny's concern is worth investigation.

@dperny let me test this to make sure, but your concern is legitimate. This is only the worst case though right? Does changing this timeout mean we need to adjust other Raft settings?
@davidwilliamson in your tests, is it possible to check for @dperny's concern above?

@dperny why did you claim that detecting down Raft members will take longer to detect when down? Is the "heartbeat" done through a gRPC call that times out at 2 seconds?
Anyway, based on a discussion with @anshulpundir, I've updated this PR to only increase the time limit for when we send a snapshot. This is a little hacky perhaps, but should avoid other issues.
I would still suggest that @davidwilliamson test this change out before we consider merging it. I will create a build shortly.

Oops, didn't see @nishanttotla previous message, where he already mentioned this. Please ignore.

PTAL, this is less of a hack, but might be over-engineered. WDYT? @nishanttotla @anshulpundir
https://github.com/docker/swarmkit/compare/master...dperny:increase-snapshot-timeout

It would be good to see that this is tunable.
Do we have a PR for the real solution?

@dperny looks alright to me, I think that is the right way to engineer it. The only qualm I have with doing this is that if we introduce this LargeSendTimeout option, then it just stays, even after we use streaming to send large snapshots.
What we also need to figure out is whether the core change (in peer.go) is the right one to begin with.

Had the same concern as @dperny - I see it got addressed, looks good to me.
@stevvooe Agree with the tunable part generally speaking, however I'd hope we'd get rid of this workaround very soon and therefore the tunable option would become useless.
Can we do a round of manual testing to validate this? Specifically, raft down nodes with and without the patch as well as sending a large snapshot.
Not sure what to think about the current value of 45 seconds. Given the max snapshot size is 128MB, you'd need a transfer speed of at least 23 mbit/s to make it happen within the timeout limit, which I think is a reasonable expectation?
There are a few edge cases but I don't think we can really address those. I believe the raft state machine counts any message for heart beat purposes. If the peer goes down just as we're sending a snapshot, it would take 43 additional seconds to detect it's down. But that's really a edge case and we can't really work around that, can we?

@aluzzardi re: "Given the max snapshot size is 128MB, you'd need a transfer speed of at least 23 mbit/s to make it happen within the timeout limit"
What is the expected behavior if there are, say, five snapshots (current + four historical), i.e., docker swarm update --max-snapshots 4 ?
Is the 45 second timeout (and thus the bandwidth calculation) per snapshot, or for the entire history?

@davidwilliamson --max-snapshot only control how many snapshots to keep locally, they don't get synced over the wire so they don't influence that calculation.

What is the expected behavior if there are, say, five snapshots (current + four historical), i.e., docker swarm update --max-snapshots 4 ?

Only the latest snapshot is sent @davidwilliamson

+1 on making this tunable, since the previous value of 2s for the timeout also seems arbitrary.

Added a SendTimeoutSnapshot field to NodeOptions so that the value can be made configurable in the future.
Also reduced the value of the large timeout to 20 seconds. Assuming a 100Mbps connection, about 240MB can be sent in a period of 20 seconds. This is well over our allowed limit.

@aaronlehmann for AppendEntries, are all entries required to be sent in a single gRPC request? It might be worth increasing the timeout for that too.
I understand that increasing the overall timeout may work out, but given that we're able to be specific here, I think we should only increase timeout where necessary.

are all entries required to be sent in a single gRPC request? It might be worth increasing the timeout for that too.

Even if all the entries are sent together, does increasing the grpc message size have any affect on this ?  @nishanttotla @aaronlehmann Basically I'm curious why you feel that the timeout for that also needs to be increased.

The MaxSizePerMsg, which limits the number of entries in an append message, is set to 64K. Depending on the size of each entry, a larger grpc message size can lead to larger append messages.
Also, depending on the size of each entry, MaxSizePerMsg should probably be lowered.

LGTM

for AppendEntries, are all entries required to be sent in a single gRPC request? It might be worth increasing the timeout for that too.

I think it would be fine to split these across multiple gRPC requests if we detect that a lot of data would be sent. It would also be okay to increase the timeout. Whatever's easiest.

Based on a chat with @anshulpundir, we have decided to pursue the case of AppendEntries in a follow-up PR. We think more discussion is needed for that.

After more discussion, @anshulpundir and I have decided to just increase the timeout for AppendEntries, since it seems right, and we still have the upper limit of 128MB for the gRPC message. I've updated that. I think we can now merge this PR.
cc @aaronlehmann

@thaJeztah @andrewhsu we must cherry pick this PR along with the gRPC limit increase. This must go into 17.09 as well.


how we can use on test network ropsten, rinkeby

I am trying to connect with infura
Creating clinent like

Client = Ethereum::HttpClient.new("https://ropsten.infura.io/v3/5xxxxxxxxxxxxdb")

And trying to deploy account like

contract_instance = Ethereum::Contract.create(file: "abc.sol",client: Client)

or even if i am trying to import_raw_key or creating new personal account its give same error

JSON::ParserError (767: unexpected token at 'account disabled)

If you still get the error, Can you show the behavior of the error in the following format?
### Steps to reproduce
<!-- Steps to reproduce the behavior -->

### Expected behavior
<!-- Tell us what should happen -->

### Actual behavior
<!-- Tell us what happens instead -->

### System configuration
**Ruby version**:
**Solc version**:
**Parity version**:
**OS**:

### Failure Logs
<!-- Please include any relevant log snippets or files here-->

@Avdhesh51000
Thanks for the issue. Please migrate as we will maintain the eth.rb library here. ;)


Fix new PR cancel previous PR's workflow

see https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs#example-only-cancel-in-progress-jobs-on-specific-branches

Have the specific example where you saw this not working?

@mattrobmattrob While i am waiting for my PR to pass, it got cancelled here: https://github.com/bazel-ios/rules_ios/actions/runs/10905270306/attempts/2
I checked actions list and saw another PR coming in, so I start looking at the github doc and it seems that the new change is what is recommended.
I also test myself by add a new commit on top of this PR. And previous run is cancelled: https://github.com/bazel-ios/rules_ios/pull/918/checks?sha=9c421cdfc3b13537a707a7a9524d21235dff2aa4
i assume can only test whether another PR job will kill previous run or not after merging this change

Note that runners we have are super limited, so new PR just cannot have CI job running until another PR finishes. We are considering to remove support for bazel 6.5.0 in test matrix to help with this. But not sure when to do it


can't change bloxstrap icon

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Whem I start roblox the taskbar isn't the icon I choose for custom?

The custom icon is for the bootstrapper only.


This will update existing tags, including the "recent activities"

Just updating the tag will not update recent activities (why are we using created_at there instead of updated_at?)

 Therefore, previous activities will lose the information of which tag had been pushed. An image:

These two pushes are for the same image:tag, and it's a bit weird that the information of the tag that had been pushed previously is now gone. Maybe it would be a better idea to just create a new activity for that tag (something like "Updated the metadata of ...").

Moreover, check out our CONTRIBUTING.md file. In your case, check the Mind the Style, the Provide tests and the Sign your work sections. Hope you don't mind, but every contributor (including me :grin:) has to follow these rules :wink:

@mssola why would I take the trouble of "signing my work" (which looks like much more work than just adding a line at the end)?

@mssola OK I'm not sure this can be fixed 'easily'. You lose 'previous activities' on the tag, but in fact the tag is overwritten (so the previous activities are not per se relevant). Without this PR, you never get new activities (or do you ?? if so, I'm missing something on my side!) which is IMHO worse... When I update an existing image:tag, the digest was never updated in portus (not by the callback, not by the cronotab)
Ideally and if I'm not mistaken, there should be a "taglog" which contains anything that happens to any namespace/repo:tag in time (and only gets added to). This will remain even if a tag is actually destroyed on the repo server.

I'll open it as an issue instead - easier for everyone

I think the issue I'm experiencing is actually #878; I will post there.


OpenSearchCon Europe 2024 blog

Description
Blog recap of OpenSearchCon Europe 2024 - including links to our session playlist and image gallery
Issues Resolved
N/A
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

it has gone through the editorial with @natebower


remove :0 from parameter print in error messages

this is just confusing to users

This still exists. I'm assigning it to me and fixing it.


.Net Core IActionFilter causes OpenAPI to fail

Hi,
First, thank you for this wonderful development.
I ran into an issue in my project as .net 7 project.
In some controllers I use the IActionFilter interface. This causes the entire middleware to fail.
Please find attached some screenshots:
Controller

Error messages:

I found the solution for this:
adding the OpenApiIgnore attribute solved this error


Correct Apollo Lake CPUID identification in dynamic_arch builds

Detect apollo lake like in cpuid_x86, otherwise it falls through to default ?prescott?
Also reading through there is dead break; remove that.

Thanks for catching this typo. I changed the title to make it more obvious what this commit did when browsing the git log.


fix(repo): add build to deploy step in travis

:tada: This PR is included in version 0.1.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


improve code sample for client 0-RTT data

Should there still be some example on how to use Used0RTT? And maybe some explanation in the godoc for when the flag is usable depending on the side of the connection (immediately for the server side, after completing the handshake or receiving data for the client side, IIUC).


Add products

Reason for change
This just adds additional plan stories to the sidebar, making it easier to view.
Testing
Nothing to test; these just show up in the Storybook sidebar now.

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   53.03%   53.03%
=======================================
  Files          30       30
  Lines         709      709
  Branches      164      164
=======================================
  Hits          376      376
  Misses        331      331
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1fb443...f1a2be6. Read the comment docs.


daemon: Check that DaemonConfig is not changed after being published

Add sha256 sum to config and validate no change in immutable parts after DaemonConfig is resolved.
This has been carved out from #32981 to focus reviews.

/test

This got fixed and merged as part of #32981

This got fixed and merged as part of https://github.com/cilium/cilium/pull/32981


How are Country layers shown?

I see in the layers.js that a lot of country specific map tiles are configured but I don't see them in the menu. Searching for a solution, I came across issue #203 where below the Basemaps /World menu there is a Countries but that is not visiable in my browser (and I tried chrome, firefire and edge). How can I enable this Countries menu?

Never mind, I just saw the settings menu where I can enable countries.


x/crypto/ssh: Support Encrypted Private Keys

What did you do?
SSH private keys are often stored on disk encrypted with a password.  There are 2 major formats of these encrypted private keys.  Today x/crypto/ssh just returns an error when encountering these keys.
What did you expect to see?
ssh.ParseRawPrivateKey(...) supports multiple private key formats, but only supports keys that are not encrypted with a passphrase.
For some PEM key formats, x509.DecryptPEMBlock works in, but for OpenSSH's newer openssh-key-v1 format, there is nothing in the stdlib that can decrypt the keys.
What did you see instead?
Two new methods, ParseRawPrivateKeyWithPassphrase and ParsePrivateKeyWithPassphrase:
func ParsePrivateKeyWithPassphrase(pemBytes []byte, passphrase []byte) (Signer, error)
func ParseRawPrivateKeyWithPassphrase(pemBytes []byte, passphrase []byte) (interface{}, error)

For keys that are PEM encrypted, decrypt them with x509.DecryptPEMBlock, and for the keys that are encrypted in OpenSSH's native key format, generate the key using the bcrypt-KDF, and decrypt with AES-256-CBC.

The function names are quite long, ideas?

Just a drive by comment so that if this proposal is accepted, we'll know what tests to update and the code to update: I added a proper error on encountering encrypted private keys with CL https://go-review.googlesource.com/29676, we'll need to update the tests from that CL.
The function names look gucci to me since they just add the WithPassphrase suffix and the return signatures are the same as the already existent ParsePrivateKey and ParseRawPrivateKey.
Alternatively, the names could be:
ParseEncryptedPrivateKey
ParseEncryptedRawPrivateKey

/cc @hanwen @agl

FYI, we had some code for decrypting & marshaling these encrypted keys from work code; hacked them over to the proposedParseEncryptedPrivateKey and ParseEncryptedRawPrivateKey APIs here:
https://github.com/ScaleFT/sshkeys
The hardest thing from making these an easy CR to gerrit from me is an external dependency on:
https://github.com/dchest/bcrypt_pbkdf
CC @dchest

@pquerna I'm not sure how useful bcrypt_pbkdf is for other uses, so probably there's no point in integrating it into x/crypto, it would be easier to just put it into internal/ package or right into the package without creating a new package (it's not a lot of lines of code). It already uses Go BSD-like license, I can just change my name in the copyright header to Go Authors (I signed CLA and have my name in AUTHORS file already) and whatever else I need to do for licensing purposes.

@pquerna and @dchest I just noticed that x/crypto already has https://godoc.org/golang.org/x/crypto/pbkdf2 and it has function:
func Key(password, salt []byte, iter, keyLen int, h func() hash.Hash) []byte

Perhaps this might ease the CL so that figuring out the extra dependency might no longer be needed. What do y'all think?

@odeke-em bcrypt_pbkdf and pbkdf2 are different and not compatible.

Thank you for the clarification @dchest, I was just about to go blindly write a program that derived a key using the different packages :)

Decryption of PEM blocks is already in the stdlib (https://golang.org/pkg/crypto/x509/#DecryptPEMBlock), we should at least use that for encrypted PEM keys. The OpenSSH-format private keys are another story, and would need more code.

Did you try this? https://go-review.googlesource.com/c/36079/

Shouldn't this issue be open until DecryptPEMBlock supports bcrypt_pbkdf? https://golang.org/cl/36079  doesn't fix it.

For some PEM key formats, x509.DecryptPEMBlock works in, but for OpenSSH's newer openssh-key-v1 format, there is nothing in the stdlib that can decrypt the keys.

Sorry, my mistake. I'll look into it in later. @hanwen could you please re-open this?

OpenSSH 7.8 changed it's default key format. It will likely enter distributions like Ubuntu or Fedora in their next release. Thus, new OpenSSH format keys with passphrase will become more common soon.
https://www.openssh.com/releasenotes.html

ssh-keygen(1): write OpenSSH format private keys by default
instead of using OpenSSL's PEM format. The OpenSSH format,
supported in OpenSSH releases since 2014 and described in the
PROTOCOL.key file in the source distribution, offers substantially
better protection against offline password guessing and supports
key comments in private keys. If necessary, it is possible to write
old PEM-style keys by adding "-m PEM" to ssh-keygen's arguments
when generating or updating a key.

Everyone stumbling upon this, here's instructions on circumventing it: https://byparker.com/blog/2019/generating-a-golang-compatible-ssh-rsa-key-pair/ (I'm not the author).

Any news about a solution for openssh-key-v1 format?

@Sh4d1 https://github.com/ScaleFT/sshkeys supports the openssh-key-v1 format

OpenSSH 8.1 added support for PKCS8 encrypted keys as well. See #8860.
   - All: support PKCS8 as an optional format for storage of
     private keys to disk. The OpenSSH native key format remains
     the default, but PKCS8 is a superior format to PEM if
     interoperability with non-OpenSSH software is required, as it
     may use a less insecure key derivation function than PEM's.

OpenSSH 8.1 added support for PKCS8 encrypted keys as well. See #8860.
   - All: support PKCS8 as an optional format for storage of
     private keys to disk. The OpenSSH native key format remains
     the default, but PKCS8 is a superior format to PEM if
     interoperability with non-OpenSSH software is required, as it
     may use a less insecure key derivation function than PEM's.

Aren't PKCS8 keys also encoded using PEM?

They are PEM encoded, but have native encryption, rather than the legacy PEM encryption.

Do we know which version of Go this became available in? I'm looking into https://github.com/alexellis/k3sup/issues/226

golang.org/x/crypto is a separate module that is not tied to the Go version.


Dreamhost cipher negotiation issues

Hey Josh,
Your script looks to be exactly what I need.
However there is a bug on the dreamhost side that I was hoping you could help me workaround.  I actually found mention of it on serverfault and a possible workaround, though I don't know how to adapt it to perl.
Basically, wget/curl/perl only work 1/100 tries unless i mess with some flags.
http://serverfault.com/questions/521352/openssl-issues-in-debian-wheezy
Here is the "same" issue for another site and how they fixed it:
http://permalink.gmane.org/gmane.os.cygwin/137638

Hey Josh --
I went ahead and filed a ticket with dreamhost 12/29/14-- and they responded "working on it" though haven't heard much else.
#6625223 	Dreamhost API Issues

While Dreamhost is resolving this, do you think you can help me narrow down the cipher list for the API call so that I can use your script?

Hey, so actually this is resolved.  Put in a ticket with Dreamhost and they actually fixed it!  Amazing
https://www.ssllabs.com/ssltest/analyze.html?d=api.dreamhost.com


Add tools for debugging the container everware compatibility

Hi,
I've spent quite some time trying to make my code run with Everware. Right now, Everware hangs with "Adding to proxy". And I have no idea what to do or where the problem might be. It would be nice if there was a way to find out.

Tried a container FROM yandex/rep:0.6.5 with the same result. Is there a problem with https://everware.rep.school.yandex.net ?

Have you tried running the container on your computer with something like: https://github.com/everware/container-tools/blob/master/run_local.sh If that works but it doesn't on the everware web-service then it is most likely a problem with the server.
Right now this is the best we have. In the near term we will start turning that script and a few other tools into a command-line interface for local usage.

I've run the custom code locally with https://github.com/yandexdataschool/reproducible_analysis_course/blob/py3/build_and_run_docker.sh (it's very like run_local.sh). But the run isn't a fair test - it uses jupyter notebook  instead of jupyterhub-singleuser.

should be fixed with #116
@kazeevn , your previous container is removed, so try again please

@anaderi , thank you! Everware worked and even spawned a container I couldn't get running when I reported the issue.


Switch from phantomjs testing to headless chrome testing

And no longer need separate browser-spec.js files

https://iamakulov.com/notes/all/install-google-chrome-on-travis/
https://github.com/karma-runner/karma-chrome-launcher  (browser: ChromeHeadless)

Temporarily on local machine change browser for headless karma task in Gruntfile.js from ChromeHeadless to ChromeCanaryHeadless. This is only until the stable Chrome channel has reached version 59.


panic: runtime error: invalid memory address or nil pointer dereference

Describe the bug
It seems when one spec has oauth2 flow and the other does not, I get panic: runtime error: invalid memory address or nil pointer dereference.
To Reproduce
I have in one spec:
  securitySchemes:
    AccessToken:
      type: oauth2
      flows:
        ...

and in the other:
  securitySchemes:
    AccessToken:
      type: http
      scheme: bearer

Expected behavior
I get some diff.
Additional context
I think the problem is in this code inside getOAuthFlowsDiffInternal:
        if flows1 == nil && flows2 == nil {
                return nil
        }

        result := OAuthFlowsDiff{}

        result.ExtensionsDiff = getExtensionsDiff(config, flows1.ExtensionProps, flows2.ExtensionProps)

The if checks only if both of flows are nil, but it seems in my case one is nil and the other is not, so once you get to flows1.ExtensionProps, if flows1 is nil, you get a panic.

Awesome. Thanks for the quick fix!


Use builtin cd and pwd in tmux plugin

Use the builtin cd and pwd, as these could have been overridden by aliases or other plugins.

You can remove the cd, pwd, and dirname dependencies entirely by just doing zsh_tmux_plugin_path=${0:h}. (The local doesn't do anything here, because this isn't run inside a function, at least in OMZ.)
If you want to enable local, then you can wrap most of this plugin in an anonymous or named function. You'll need to move the use of $0 outside the function, though.

This same change is done in #4412


Allow stdout as a browser option

Raised by @QuinnyPig in #78 - splitting this so we can track this issue separately.
In display-constrained devices (such as a remote SSH connection to a server, where the server is running the Granted binary) Granted users don’t have access to the browser on the same device which is executing Granted.
In this situation, it’s desirable to print the resulting console URL to STDOUT so that users can copy this out of the SSH session and into their host system, which is likely to have a web browser.
The desired experience for this is something like:
granted browser set —browser=stdout
assume -c PROFILE_NAME
# a console URL for PROFILE_NAME is printed in the terminal

Partially added this functionality in #78 @chrnorm. assume PROFILE_NAME -u will print the url to STDOUT for the user to be able to manually copy from there or alternatively use `open $(assume PROFILE_NAME -u)
We can keep this open if we alternatively want to create a browser type of no_browser

A benefit to the -url flag that @meyerjrr  referenced is you can set your browser to firefox and the url returned will be a firefox url with the extension config. Alternatively, setting your browser to Chrome with return a url the you can launch in any browser.

Then "Chrome / None" should be the menu option since it's arguably undiscoverable otherwise?

Hey @QuinnyPig thanks for the suggestion!, We have gone with a more silent/background method to add this functionality in #82. Whereby Granted won't explicitly have a no browser option, but will silently fallback to return a link if browser functionality fails. In this case we don't need to worry about the discoverability of the option.
If the user wanted to manually return the URL then they have the -u option in the cli


any examples? :-)

Hi! Is there any chance you will also include some examples ? :-) I am trying to port a video camera application from Windows to Mac but I am completely  new to AVFoundation and it seems I cannot use openpnp-capture as it do not provide raw data.
I will appreciate any help :-).
Marcin

I'm not sure if this project is what you need. This project is just a Rust wrapper for the AVFoundation framework. Perhaps you might need an Objective-C examples?

Hi, thanks for the link but no, the application I'm trying to port is in rust :-) . Initially i tried to use nokhwa and  openpnp-capture but the first library is not working at all on mac and using openpnp-capture is not possible to get raw data (jpeg) from the camera, therefore I think the best way is to use directly AVFoundation and then I've found your wrapper :-).

You can refer to this example https://github.com/libark/av-foundation-rs/blob/main/examples/video_capture.rs

Thanks!  :-)

I've added some more examples in my pull requests too


watchQuery subscription calls next / sends new data after unrelated mutation

I've got a simple watchQuery running for some data I'm rendering. Something like this:
query device($id: IDType!) {
  device(id: $id) {
    id
    name
    room {
      id
      ...
    }
  }
}

I then subscribe to the resulting ObservableQuery and pass it a next function that I expect to get called whenever new data about this query is received:
this.client.watchQuery(opts).subscribe({ next: newData });

What I'm seeing, however, is that the next function is getting called again even when I'm calling a completely unrelated mutation like this:
mutation changeUserName($id: IDType!, $newValue: String!) {
  changeUserName(id: $id, newValue: $newValue) {
    user {
      id
      name
    }
  }
}

My expectation was that the next function should only get called when I've fetched data in a query that's actually related to the original query, not something completely unrelated. Ideally it would only get called when that original data has actually changed, even if it's refetched and has identical values. But I certainly wasn't expecting it to get called after completely unrelated queries.
Is this the expected behavior? Is there a reason it would be desirable to call this function unnecessarily?
Tested on apollo-client v0.5.5.

Actually it looks like next gets called exactly twice even if I run the mutation multiple times. I believe this was actually happening because I was inadvertantly modifying the data that was coming back. I'm now cloning it immediately when next gets called and I'm not seeing it get called twice anymore.


Enhancement: remote Pull Request review

Enhancement: remote Pull Request review
Introduced a new --remote CLI option for review to review a remote GitHub Pull Request.
Usage:
$ code-review-gpt review --remote=mattzcarey/code-review-gpt#96

Technical Implementation

if --remote is present, the git logic to get the list of files to review is bypassed.
It uses paginated GitHub GraphQL API to get the files touched by the given PR.
It filters files by Git patch status, excluding the files deleted by the PR.
It filters files by supported file type.
The filtered file list is then used with the GitHub REST API to fetch file contents. Specifically, the file status at the latest Pull Request Git HEAD commit.
The next step is to pull the Pull Request diff (via REST API) and to combine each file from previous points with its diff fragment.
The result is a ReviewFile[].
The main logic is implemented by getRemotePullRequestFiles [link].

Closes https://github.com/mattzcarey/code-review-gpt/issues/93

Is there a reason to use both the GraphQL client and the rest client. Can we not get everything done with the rest client?
Also you have added in the function to get files in the review command. This should be clean of git commands or api calls and just focus on the review logic.
If you look at the roadmap this will become clear. We are building a backend which will handle a lot of the functionality you want.

@mattzcarey Hey, thanks for the review.
REST vs GraphQL: I checked, it’s possible. The code of this PR is a simplified version of a larger program that required GQL. I will change this one.
Args of review: will change this as well.
backend vs script: For my use case I will need to integrate your project into a larger set of data. Having CLI is perfect point of integration. It’s UNIX-like approach. A backend has the risk of trapping the data. Does this make sense? 🙂
I’m on vacation ATM, I will make the changes in a couple of weeks, hoping you will have accept this enhancement. 🙂

@mattzcarey

Hey, thanks for your message and I hope you have a great holiday!
Thank you, I had!

✅  I moved the retrieval of files outside of review (see https://github.com/mattzcarey/code-review-gpt/pull/96/commits/1b4b0fba2c791954871f9250db059c8876335a2e)
✅ I simplified a lot the code by using GitHub REST API only. (see https://github.com/mattzcarey/code-review-gpt/pull/96/commits/0150edd1cee9cffc1bd9cc328472e3339d7cfb48)

Looks great. Will functionally review now. :)

I am getting this error:
ERROR   Error: Error: Failed to get remote Pull Request files: Error: fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing

@mattzcarey Can you please tell me step by step how you manual test it? E.g. do you transpile from TS? So that I can reproduce your problem.

I pulled your branch and ran
npm start -- --remote=mattzcarey/code-review-gpt#96 --debug=true

@mattzcarey Which Node version are you using?
Newer versions of Octokit (GitHub SDK) require Node.js 18+.
See https://github.com/octokit/octokit.js/#fetch-missing
I suggest enforcing the project to support Node 18+.
Because 16 is EOL and 18 is LTS.

@mattzcarey I can't reproduce the problem. This is my output: https://gist.github.com/jodosha/8f84c425389ea5d3a182852c8817975b

Should be good. I'll add that to the project.

Thanks for your contribution! @jodosha

@mattzcarey Can you please consider releasing a new version so that I can use the tool as a globally installed CLI? Thanks. 🙂

@mattzcarey Can you please consider releasing a new version so that I can use the tool as a globally installed CLI? Thanks. 🙂

Yes it will be done this week. :)


workbench.files.action.showActiveFileInExplorer not working when Explorer is hidden

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version: Version: 1.69.2
Commit: 3b889b090b5ad5793f524b5d1d39fda662b96a2a
Date: 2022-07-18T16:32:39.000Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0

Steps to Reproduce:

Open any file that's listed somewhere in the Explorer view
Hide Explorer view ("View: Toggle Primary Side Bar Visibility" command)
Run "File: Reveal Active File in Explorer View" command

Expected:
Active file is focused in Explorer view
Actual:
Primary Side Bar view opens and the whole Explorer box is focused (it has outline border)

This (Actual)
Instead of this (Expected)

Do you have auto reveal disabled?

How can I check that and/or toggle that? I couldn't find any "auto reveal" or similar command, setting, nor menu item.
If you know what to look for, you could just try it out for both cases:

With auto reveal enabled
With auto reveal disabled

This should take you less time than it would take you to reply here to tell me how to enable/disable auto reveal. In this case, I suggest you just try it yourself and report here.


fs: Merge fs_poll into poll_fdsetup

Summary
to avoid the user misuse the wrong funciton
Impact
No, nobody call fs_poll directly
Testing

Ok, I agree with this change, since the code added to inside the original function is not big and the fs_poll wasn't used in any other place.


fix for "jpeg error with PIL, Can't convert 'NoneType' object to str implicitly"

Fix for an issue #95. I'm not sure with that, but it works for me and test passed.

@codelucas Would love to see this PR merged if it seems relevant, this error is messing with my logs :/
Love newspaper anyway ! Great job

It's been merged, I apologize for being so inactive recently

The new module hasn't been pushed in pypi, you're all going to have to pull from master for the meantime

:+1:

Thanks ! :+1:


Allowing normal mode

Is there a way to use this commandline in normal mode?
Would be nice to be able to use normal mode to modify the command. Pressing ESC twice would then close the prompt.

So the input uses a special type of buffer called "prompt buffer", in neovim 0.5 and 0.6 this is very buggy. I think they fixed in 0.7 or merge a patch to fix some bugs.
It could still be done by adding a keybinding.
require('fine-cmdline').setup({
  hooks = {
    set_keymaps = function(imap)
        local fn = require('fine-cmdline').fn

        imap('<Esc>', function() vim.cmd('stopinsert') end)
        imap('<Esc><Esc>', fn.close)
    end
  }
})

Thanks, I'll try that.
It works for telescope - thought they'd use the prompt buffer as well 🤷♂

Sorry, haven't been able to test this earlier.
It's working mostly fine. But I'm not able to close the prompt with <ESC> when I'm in normal mode.
It only works from insert mode since it's only a chord mapping in insert and not a normal mode mapping for <ESC> to close the prompt.
But it's fine if you don't want to support it at the current time. Maybe it works nicer with 0.7 and could then be an official feature 👍

I want to support normal mode when I see prompt buffers are fixed in a stable version.
Anyway, you can create your own mappings in normal mode, using the built-in function vim.api.nvim_buf_set_keymap. With this in the set_keymaps hook you can close the prompt from normal mode.
local nmap = function(...) vim.api.nvim_buf_set_keymap(0,'n', ...) end
local opts = {noremap = true, silent = true}
nmap('<Esc>', ":lua require('fine-cmdline').fn.close()<CR>", opts)


Not able to import previously exported styles

Describe the bug
Cannot import old export file. Previously saved as ".txt", incompatible with new v3.1 "JSON" format.
Previous version 3.0.7 export function prompted to "copy" text. Import option prompted to "paste" text.
New version, 3.1, Export downloads ".json" file, and Import prompts to select said ".json" file. This does not work, if you're importing previously copied text that was just saved wherever, such as in a text file. See screenshots.
Browser
Version 90.0.4430.212 (Official Build) (64-bit)
Windows 10 Enterprise 20H2
To Reproduce
Steps to reproduce the behavior:

Go to 'Sync'
Click on 'Import'
Select the file (I've attached it).
styles backup.txt
This is the old backup file I had, never had issues on old versions, so never had reason to doubt it's functionality and re-export it, when I had my old device.

Expected behavior
Styles import and work immediately on their respective websites.
Screenshots
This is the OLD Export function (v.3.0.7):

Here there was no "JSON" file download, it would just ask you to copy the text into a JSON file, of course I never did this and just pasted it into a TXT file, because for one It was easier and couldn't be bothered to find out how to save/convert to JSON.
This is the OLD Import function (v3.0.7):

Here I could paste the old exported text, which i normally just kept in a text file with no issues.
Here is the NEW import function (v3.1):

This no longer has the "Paste previously exported JSON". As such, when I try to copy my previously exported "copy and paste" CSS settings, I get the "JSON format" error.
Here is also the NEW Export function (v3.1):

Once you press Export, it downloads the JSON file. Hopefully you can see here how it is different than the old version, where it just gave you text to copy.
Additional context
Nevertheless, I understand I can probably fix this myself by downloading the old version and Importing the text or getting a hold of my old device and updating it then exporting the file again as JSON. The point is, it's already been done, I've already exported previously as an old version, the new version should not break this functionality or make this more difficult. (If the end goal is to make this simpler to use).
Before you ask, I have just tried removing the ".txt" extension from the file and leaving blank or changing to ".json", (yes, I know this is not how file conversion works...), regardless, it said the "Import was successful", and of course, failed to show any of the imported styles, remaining blank. However, this is a separate issue I guess, to do with whether or not it was able to read and import the file successfully. Not too bothered about this one but just thought you should know.

Is there any way to fix this? I've lost the old version and I only have the text file as backup now.


Ad method anchors

implement function includes
replace anchor includes in counter with method includes

TODO:

The initial handling of spaces before the methods is not quite right yet.
Doesn't pick up doc comments or attributes before the method
Doesn't handle structs / enums
Doesn't handle impl blocks
Doesn't handle more abstract areas (e.g. imports, modules, etc.)

This is a pre-cursor to adding hello-world / counter tutorials that use the simple template rather than cargo init (I didn't want to add a bunch of comment anchors to the generated file, so paused that work to look at this)

I'm merging this for now, the undone todos can be deferred to another PR.
Doesn't handle structs / enums
Doesn't handle impl blocks
Doesn't handle more abstract areas (e.g. imports, modules, etc.)


Add support for placement anti-affinity

To support a production cluster, the control plane nodes should be on different servers.  The same goes for the compute nodes.  PowerVS anti-affinity placement rules should be applied to nodes during their deployment.

There is a technical challenge to use affinity policies with PowerVS. For specifying the affinity or anti-affinity we need the id of other VMs which is not practical as the VMs are created in parallel for us.
Another option is to use ibm_pi_placement_group and use the placement group id while creating the VMs. The problem 'again' here is that we cannot use count, instances should be created one after the other. This can be done for master giving 3 configurations based on count, we cannot determine the number of workers and not feasible to write N number of configurations for workers.
@cs-zhang could you check with the PowerVS team on how to proceed on this?

I tested with  pi_replication_policy with pi_replicants, TF apply will create the number of VMs, but TF destroy only delete one of the VM. Also no count.index like attribute can be used.

After more testing and digging, the current anti-affinity support for PowerVS could not used for OCP installation.
Here are the three ways to define anti-affinity in PowerVS:

pi_affinity_policy  and pi_anti_affinity_instances -- it requires other pvm IDs, that is impossible to get or need to create the pvms and at a time, even in this case pvms could be be placed on same system in my test.
pi_placement_group_id -- it requires to create pvms one by one, the VM has to be in active status to be able to add in.
pi_replication_policy, pi_replicants -- it only create the VMs with the same parameters, also found the TF destroy would just remove one of the VMs, not all VMs created by replicate.

Also the TF's meta-function count is not supported by all above.


./gradlew assembleDebug failed for task ':app:externalNativeBuildDebug'

Hi. I was trying to compile your project and when running gradlew I ran into this error:
Execution failed for task ':app:externalNativeBuildDebug'.

Build command failed.
Error while executing process /home/user/Android/Sdk/cmake/3.6.4111459/bin/cmake with arguments {--build /home/user/gamedev_android/hello-sdl2-android/android/app/.externalNativeBuild/cmake/debug/armeabi-v7a --target main}
ninja: error: '../../../../../distribution/android/SDL2/intermediates/ndkBuild/debug/obj/local/armeabi-v7a/libSDL2.so', needed by '../../../../../distribution/android/app/intermediates/cmake/debug/obj/armeabi-v7a/libmain.so', missing and no known rule to make it

Closing as completed as the project has been upgraded a few times, feel free to reopen if this is still happening


Fix auto-tag build scripts

Description of changes:
When adding the Go version and architecture to the code-generator Dockerfile, it broke the continuous deployment scripts which use a separate set of calls (to buildah) instead of using build-controller-image.sh. This pull request adds the same GOARCH and GOLANG_VERSION build arguments to the release-controller.sh script and adds the Go CLI to the deploy container to support them.
These changes were validated by running a custom edit of the Prowjob against the new images and script. Log output: https://prow.ack.aws.dev/view/s3/ack-prow-logs/logs/lambda-post-submit/1620583281521070080
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I have tested these changes on the failing Lambda release job. Final output, when using this branch: https://prow.ack.aws.dev/log?job=lambda-post-submit&id=1620583281521070080

/cc @jljaco

/lgtm


help how to use transformer model without dropout

I use the transformer encoder code like below to train and dump the model.
from tensor2tensor.models import transformer
import tensorflow as tf

hparams = transformer.transformer_base()
encoder = transformer.TransformerEncoder(hparams, mode=tf.estimator.ModeKeys.TRAIN)
x = <shape [batch_size, timesteps, 1, hparams.hidden_dim]>
enc = encoder({"inputs": x, "targets": x})
...and then use the 'enc' in the following network

And load the model like saver.restore(sess, checkpoint_file).
While I found the model output is not stable. I think maybe it's because the dropout. How can I set the dropout to 1.0 in my feed_dict？

What do you mean by non-stable output?
In inference (decoding), dropout is always turned off (i.e. set to 0).
Setting dropout to 1.0 makes no sense - it would ignore all input during training. If you want to turn off dropout during training use --hparams="layer_prepostprocess_dropout=0,attention_dropout=0,relu_dropout=0" depending on which types of dropout you want to turn off. However, this is not recommended for the best results unless you have really huge training data or some other technique to prevent overfitting.

encoder = transformer.TransformerEncoder(hparams, mode=tf.estimator.ModeKeys.PREDICT)
You have the mode set to TRAIN which will have dropout enabled.

@rsepassi @martinpopel I think the tensor2tensor does not provide a good way to be used as a library.
After training, I just want to load the model and use it as a service. I don't want to copy the model network construct code only for changing the mode param.

You may be interested in the SavedModel format that export.py outputs. That's the format we use to actually serve the models.

@rsepassi I simply use saver = tf.train.Saver(tf.global_variables()) saver.save(sess, checkpoint_file) to save model,
andsaver = tf.train.import_meta_graph("{}.meta".format(checkpoint_file) saver.restore(sess, checkpoint_file) to load model for inference. Then encoder looks like not support this way.


Specific Maven example for WebTextTerminal

Hallo Serban,
Many thanks for making available text-io, I think it is fantastic and the best tool in the java world for providing a command line regardless of the interface.
Both the console and swing versions worked great out of the box, was possible to learn how to use them very quickly. My difficulty is with the WebTexTerminal. I'm struggling to get it working under Maven without success so far. I'm able to compile the Gradle demo, but unable to port this into the maven project. The documentation available on this part I'm unfortunately unable to follow and understand what is missing.
Would it be possible to ask for a quick demo specifically written in Maven just for the WebTextTerminal?
Many thanks in advance.

See this: https://github.com/beryx-gist/text-io-demo-standalone

Thank you so much Serban!
It worked right on the first run, comparing to this demo was able to find what was wrong (location of the resources). Also, on the command line is necessary (at least on my machine) to press ENTER twice to launch the web browser. We first choose 6 (doesn't really matter which app), then press 6 again (terminal to be used) and then press 1 (RatPack). To launch the web browser only happens after pressing ENTER once again, which might be confusing to other users.
Anyways, that is just a side note. Thank you for the quick answer and demo. Will later provide back the link where it is being used (an open source portal)

Found the issue behind needing to press ENTER. It was the question for confirming the port number to be used. On the IDE console this question was not appearing but debugging the code was possible to see what happened. No troubles now, everything perfect.
In case this helps other people in the future, here is minimum code required for the WebTextTermina launched on port 8080l:
    public static void main(String[] args) {
        BiConsumer<TextIO, RunnerData> app = new Weather();
        WebTextTerminal term = new WebTextTerminal();
        term.init();
        TextIO textIO = new TextIO(term);
        WebTextTerminal webTextTerm = (WebTextTerminal) textIO.getTextTerminal();
        TextIoApp<?> textIoApp = new RatpackTextIoApp(app, webTextTerm);

        WebTextIoExecutor webTextIoExecutor = new WebTextIoExecutor();
        webTextIoExecutor.withPort(8080);
        webTextIoExecutor.execute(textIoApp);
    }


Fix deprecation warnings in tests

Codecov Report

Merging #563 into master will decrease coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
- Coverage   96.46%   95.91%   -0.55%
==========================================
  Files          39       39
  Lines       14025    14025
==========================================
- Hits        13528    13451      -77
- Misses        497      574      +77


Hosting on govt.nz

As the Service Innovation Lab
We need to explore with Cam on whether govt.nz is able to host our app.
A / C

Work through with Cam what the requirements are
Update Sarah and Paul on next steps

needs  #239
needs #240

done :-D


Create sbcusd.txt

Institution Name
San Bernardino City Unified School District
San Bernardino City USD
Website
sbcusd.com
sbcusd.k12.ca.us
Course Offerings
Several year-long computer science courses are offered including:
Advanced Placement (AP) Computer Science
https://www.sbcusd.com/cms/one.aspx?portalId=59953&pageId=24527032
International Baccalaureate (IB) Computer Science
https://www.sbcusd.com/cms/One.aspx?portalId=59953&pageId=29563216

@sogervais Pull request merged. Thank you!


feature: add language option by yml

i would like to add the language options by yml file
so i added one input
sorry guys about the prettier

@jellychoco Thank you, BTW if you can commit your .prettier config would be better


Is it possible to create csharp bindings from swig for use in both android and ios projects.

Hi @redbrain! This issues list is generally used to address specific issues with the samples in this repo.
You can raise suggestions on our UserVoice and ask on our forums (there has already been a little discussion on swig).
Thanks


Nakadi publisher

Some updates and improvement made to the publisher. Tests to follow.

Changes Unknown when pulling c41488c91c544edb1883b02ebbee72fe668335be on publisher-refactor-w-tests into ** on master**.

Changes Unknown when pulling 02aa38942ee56adeee0e1c388dbcda20540e2553 on publisher-refactor-w-tests into ** on master**.

Changes Unknown when pulling 8237e87b53bd48881b56a23a9dc5e759c84d4704 on publisher-refactor-w-tests into ** on master**.


AttributeError: 'Output' object has no attribute 'ipython_display'

I am trying to fetch real time updates from mongoDB cluster on Python using streamz PeriodicDataFrame
-------------Start of code----------------------
`import pandas as pd
import numpy as np
import urllib
from streamz.dataframe import PeriodicDataFrame,DataFrame
from streamz import Stream
import MongoClient from pymongo
from pymongo import MongoClient
establish a client connection
MONGODB_CONNECTION_STRING = "mongodb+srv://KDRM:"+urllib.parse.quote("pass@123")+"@cluster0.iffy9by.mongodb.net/?retryWrites=true&w=majority"
client = MongoClient(MONGODB_CONNECTION_STRING)
to check if connection has been established
client.server_info()['ok']
point to symbolsDB collection
db = client.symbolsDB
emtpy symbols collection before inserting new records
db.symbols.drop()
get all records from collection
symbol_list_from_DB = db.test.find({})
source = pd.DataFrame(list(symbol_list_from_DB))
k=[]
def streamdb(**kwargs):
no = db.test.count_documents({})
for i in range(no):
k.append(pd.Timestamp.now())
source['time']= k
for i in range(no):
k.pop()
return source.set_index('time')

sdf = PeriodicDataFrame(streamdb,interval='1s')
sdf.tail()`
--------------------------End of code------------------------

Which version are you using exactly? I seem to recall this problem, there's a chance it is fixed on current master.

I believe this is the same issue as https://github.com/python-streamz/streamz/pull/454, I don't think it's fixed on master.

Can you please confirm that the inked PR fixes things for you? I'll merge it, and deal with the lingering CI stuff afterwards.


Chalk no longer seems to work in any browser. :(

im using:
"chalk": "^4.1.2",
import chalk from 'chalk';
...
console.log(chalk`
CPU: {red 50%}
RAM: {green 50%}
DISK: {rgb(255,131,0) 50%}
`);
const error = chalk.bold.red;
const warning = chalk.hex('#FFA500');
console.log(error('Error!'));
console.log(warning('Warning!'));

Ive tried this inside firefox, safari and brave. The console text is un-styled in all 3. 🤔

ooopsy! just realised that chalk has zero support for browsers. :P


Android - Change how heartbeat tool inserts data into collection

Because we can't know the internal structure of the metadata MAP in the heartbeat tool, and it could contain nested MAPs, we can't use DQL to insert the data. Until that gap is closed in DQL, use Legacy Query Builder to insert the device data

You can still use DQL but the underlying maps will just default to registers. Is this going to be an issue?


empty e2e target in tox.ini

Running tox -e e2e throws an error. The e2e target doesn't seem to do anything:
https://github.com/python-wheel-build/fromager/blob/main/tox.ini#L42C1-L43C9
(cc @rd4398)

That environment is used from the scripts in the e2e directory to have an easy way to create a virtualenv in CI. The script builds the environment, then activates it and uses the contents.

oh okay, got it!


Clarify if ResolvedArtifactResult is serializable

Issue type
Wrong or misleading information
Problem description
The configuration cache documentation suggests that ArtifactResult may be referenced as long as a lazy provider is used but that doesn't seem to be the case:
1 problem was found storing the configuration cache.
- Task `:test:demo` of type `DemoTask`: cannot serialize object of type 'org.gradle.api.internal.artifacts.result.DefaultResolvedArtifactResult', a subtype of 'org.gradle.api.artifacts.result.ArtifactResult', as these are not supported with the configuration cache.

Even more confusing, when the configuration contains a dependency to a local project, serialization does not fail anymore.
Context (optional)
plugins {
    id 'java'
}

dependencies {
    implementation "commons-cli:commons-cli:1.6.0"
    // removing the following dependency makes the serialization fail
    implementation project(":some-other-project")
}

tasks.register("demo", DemoTask) {
    artifacts = configurations.runtimeClasspath.incoming.artifacts.resolvedArtifacts
}

abstract class DemoTask extends DefaultTask {
    @Internal
    abstract SetProperty<ResolvedArtifactResult> getArtifacts()

    @TaskAction
    void print() {
        artifacts.get().each {
            println it.file
        }
    }
}

Page with the problem
https://docs.gradle.org/8.5/userguide/configuration_cache.html#config_cache:requirements:disallowed_types

Thank you for your interest in Gradle!
This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

@gradle/bt-configuration should we also update the implementation to not have corner cases appear supported while they should not be?

Thank you for providing a valid report.
The issue is in the backlog of the relevant team and is prioritized by them.


add spectral normalization linkhook

This PR aims at accessing #5702.

#5557 will add in_recomputing config.

Jenkins CI test (for commit b2f9bed5bf42ad8b06d17344f40f5b85ecd89114, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

It could be mentioned that l.add_hook(SpectralNormalization) should be done before opt.setup, because add_hook adds the parameter gamma by default.

I agree and I think I must mention this. But this hook does not add gamma to link by default

Could you tell me the details of the failure if it has something to do with this PR?

Jenkins, test this please.

Jenkins CI test (for commit 20d5bae376eb73ac3f239c1d78fbbfb335d1670e, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Jenkins CI test (for commit 9d5c939cea2990747034d8d7f15e0371978422da, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins CI test (for commit 9d5c939cea2990747034d8d7f15e0371978422da, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)


Auto-advance from app-missing.html to index.html if app is installed

Ran grunt test

Small suggestion on the name, otherwise :+1:


A disclaimer should be added

We don't want to give our users the impression that all our methods and values are guaranteed 100% accurate.

How would this disclaimer take shape? Is this a line of text you see right before you create your LES? Or somewhere on a separate page on the website, like on ETModel:

Is this a line of text you see right before you create your LES?

I dislike pop-ups as they inhibit the work-flow of the user but in this case I'm not sure.

Or somewhere on a separate page on the website, like on ETModel:

I think that is difficult to find (I've never consciously seen the above text myself).
@dennisschoenmakers @antw @AlexanderWirtz @jorisberkhout @ploh what do you think?

What is an LES?
How often would a user see this pop-up? If it is an action that only occasionally happens or we remember that we showed it to the user not long ago and then do not show it again, this should be fine. But if they see it every couple minutes, it will definitely be annoying - and will just be ignored.

Is this a line of text you see right before you create your LES?

How about sticking it at the bottom of the import form?

It would be super-nice if we also included a blurb about being open source and that we (happily!) welcome contributions and corrections with a link to GitHub or the open source page.
(It would also be good for the actual message used to be a little more... human, and a little less "lawyer". :grinning:)

What is an LES?

A Local Energy Solution (LES) combines a topology (the structure of an electricity network) with technologies – such as electric vehicles and space heaters – in order to compute the load on the network. It's the main concept in ETMoses.
The project wiki has some documentation on the ideas behind ETMoses, and a quick-start guide.


rustfmt does not seem to be working on latest nightly.

Version info:
➜ cargo --version
cargo 1.40.0-nightly (8b0561d68 2019-09-30)
➜ rustc --version
rustc 1.40.0-nightly (032a53a06 2019-10-03)
➜ rustfmt --version
rustfmt 1.4.8-nightly (afb1ee1c 2019-09-08)

When running format document from within VS code, or invoking the format command through LSP in vim, nothing happens. But when executing cargo fmt from the terminal, the files are formatted correctly.

Same, I've also been encountering this issue, and I'm not entirely sure why it broke. Could it be a bad interaction with rustup + what nightly is set as a default?

I have same with non-recent nightly: rustc 1.39.0-nightly (eb48d6bde 2019-09-12)

I suspect this is #4249. Does it still happen?

Closing, as it's unclear how to reproduce this.


Fixed serchAndOrder typo in docs

For the Committer

[ ] I made sure that the site looks great and functions perfectly live
[ ] I ran splell check
[ ] I'm ready for these changes to be made live

For the Reviewer
General Review

[ ] All changes/updates requested were intentionally changed or added (no extraneous file or partial updates)
[ ] The live rendered page behaves and looks like intended.
[ ] All links work as intended. (click every link to make sure that it takes the user to the expected place).
[ ] The markdown was rendered to HTML as intended. (Tables look right, code samples are gated properly).
[ ] Any style or CSS changes are tested on multiple different pages to ensure nothing unexpected broke or changed.
[ ] I proof-read the live site (gitbook serve) and there are no oblivious splelling or grammer misteaks.

Gitbook Specific

[ ] Any new documentation pages have been added to the SUMMARY.md file so they are rendered to HTML.
[ ] Any links to other pages within this documentation use relative links ([read more about ...](guides/voice/voicemail.md)).
[ ] Gitbook can install and build the documentation (gitbook install & gitbook build)

Code Specific

[ ] All code has been tested against the live API.
[ ] All code can be run without throwing errors or new warnings.
[ ] All code is formatted correctly and consistently (spaces, tabs).
[ ] All code is legible and idiomatic to the language.
[ ] All code uses sensical method, function, and variable names.
[ ] All code samples use the appropriate syntax highlighting.
[ ] Any examples re-use same phone numbers, uuids, variable names, etc... throughout (IE don't have something like {from: '+19191231234', to: '+19191231234'} unless it's meant to show the same phone number calling/texting itself ).

TL;DR

[ ] I did these things
[ ] I'm ready for these changes to be made live

 [Usabilla Feedback Item - Under //Callback, searchAndOrder is misspelled (serchAndOrder)
Thanks. :)](https://trello.com/c/sIQByXih/278-usabilla-feedback-item-under-callback-searchandorder-is-misspelled-serchandorder-thanks)


publishToGitHubPages fails if you have greater than 30 branches alphabetically before gh-pages.

Very similar to https://github.com/Kevin-Lee/sbt-github-pages/issues/113 I get an error that gh-pages does not exist... problem is it does.   The github api repo list endpoint  has a default page size of 30 and the code https://github.com/Kevin-Lee/sbt-github-pages/blob/32477dce3a8ab7a965db1dc920bfb8e0dc9ba16d/src/main/scala/githubpages/github/GitHubApi.scala#L330-L339 appears to take exactly 1 page, of the default size.

@zarthross Thanks Darren for reporting this bug and you also found the cause! That's great! I really appreciate. 🙂 👍
I'm on it!

@zarthross OK, I've fixed it. I'll release it shortly.

Awesome, @Kevin-Lee thanks for the quick work!

@zarthross Not at all. Your bug report was a lot more valuable as you found the cause which saved my time a lot!
It's been released. https://github.com/Kevin-Lee/sbt-github-pages/releases/tag/v0.8.1
It's already available on the Maven Central.

Awesome, thanks again!


test: misc. K8s test enhancements

test/helpers: gather more K8s metadata

Get output in JSON for more K8s-related objects in K8s log-gathering functions.
Get replicationcontroller and deployment data.

test/k8sT: query both service IP and hostname of redis master

This will add more visibility to cases where there is an issue with resolving service names via DNS. Tests have been failing when accessing redis-master in K8s 1.7. Accessing the service IP directly first will reveal if there is an issue with connecting to the service itself, or an issue with resolving the IP of `redis-master.

Signed-off by: Ian Vernon<EMAIL_ADDRESS>

test-me-please


[TRI-1249] Framework: Support for Remix

Build support for Remix into Trigger.dev
Please make sure to use Typescript for all code
Task 1 - Remix Adaptor

[ ] Create a new folder in packages called remix
[ ] Create the adaptor for Remix. Use this Next.js adaptor code as reference when creating yours. Include all setup configurations to fully support the framework, e.g. Next.js requires adaptor support for both App and Pages routers.
[ ] Create a basic Remix project that uses the adaptor in examples/remix folder. Include a basic Job in Trigger.dev, e.g. a simple Job that just does a delay inside it. Screen grab the full Run dashboard page showing it successfully worked. Here are examples of how to do cross-project references in package.json and tsconfig.json.
[ ] Provide a screen grab of your terminal showing the Adaptor is working

Task 2 – Add a README.md file

[ ] Create a new README.md file inside the packages/remix folder and copy in the contents from packages/nextjs/README.md. Adjust the wording to reference Remix where needed, including updating the the URLs.

Task 3 – Write the documentation

[ ] Locate the manual-setup-remix.mdx folder in /docs/_snippets/. Use this file to write your documentation, overwriting any contents of that file. Follow the structure of this Next.js example for reference when writing yours.
[ ] Update the table at the bottom of the client-adaptors.mdx page with the framework you’ve worked on.

Task 4 – Update the webapp onboarding

[ ] In the route.tsx page located in _app.orgs.$organizationSlug.projects.$projectParam.setup.remix replace the <FrameworkComingSoon/> component with your new onboarding steps. Follow the same structure as the Next.js example when creating your own. Ignore the very top step for adding this framework to a new project, just focus on the steps to add it to an existing project (so don’t include the <RadioGroup/> toggle selector at the top). Make sure you also include the useProjectSetupComplete(); hook at the top of the page – this triggers a particle effect when the new job is successfully created and redirects to the Jobs list 🥳 .
[ ] In the FrameworkSelector.tsx file, add “supported” to the framework you’ve worked on.

TRI-1249

Can I work on this?

Can I work on this?

We're just about to merge a PR in the next hour or 2 which will allow you to work on this – and absolutely, you can claim this one. We will attach a bounty to this too.

Thanks!

@Chigala This issue is ready for you now!

/attempt #445

@Chigala i've assigned this issue to you too. If you think you are attempting too many or want to give some to others, let me know.

@samejr
Can I pick this one up?

@rishi-raj-jain I've started work on this

@Chigala OK

@rishi-raj-jain, @Chigala is making an attempt at this one and I've already assigned the issue to him. Redwood.js issue is still free?

Yeah, I picked that. Crazy contributions to 3 of them by Chigala already!


fix(aws-iot-lambda-dynamodb): expose additional aws-dynamodb-lambda functionality

Issue #, if available:
Closes Issue #886
Description of changes:
When aws-lambda-dynamodb was enhanced, the extra functionality was never added to this L4 construct.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 431fe021c00e7ec09f6f59fec0e85e192690546b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


[Event Request] Codeunit 32000000 "Ref. Payment Management" - MatchLinesOnBeforeFindCustLedgerEntry

A new Event Publisher is need in the Codeunit 32000000 "Ref. Payment Management".
Event:
local procedure MatchLinesOnBeforeFindCustLedgerEntry(RefPmtImport: Record "Ref. Payment - Imported"; var CustLedgEntry: Record "Cust. Ledger Entry")
Code
procedure MatchLines(JnlTemplateName: Code[20]; JnlBatchName: Code[20])
    var
        NoMatchLines: Boolean;
    begin
        RefPmtImport.Reset();
        RefPmtImport.SetRange("Record ID", 3, 5);
        RefPmtImport.SetRange("Posted to G/L", false);
        if RefPmtImport.FindSet then
            repeat
                CustLedgEntry.Reset();
                CustLedgEntry.SetFilter("Reference No.", RefPmtImport."Reference No.");
                CustLedgEntry.SetFilter("Document Type", '%1', 2);
                CustLedgEntry.SetRange(Open, true);
                MatchLinesOnBeforeFindCustLedgerEntry(RefPmtImport,CustLedgEntry);
                if CustLedgEntry.FindFirst then begin
                    RefPmtImport."Entry No." := CustLedgEntry."Entry No.";
                    RefPmtImport.Validate("Customer No.", CustLedgEntry."Customer No.");
                    RefPmtImport."Document No." := CustLedgEntry."Document No.";
                    RefPmtImport."Posting Date" := CustLedgEntry."Posting Date";
                    RefPmtImport.Matched := true;
                    RefPmtImport."Matched Date" := Today;
                    RefPmtImport."Matched Time" := Time;
                    RefPmtImport.Modify();
                end else
                    NoMatchLines := true;
            until RefPmtImport.Next = 0;

        if NoMatchLines then
            Message(Text1090001);

        RefPmtImport.Reset();
        SetLines(RefPmtImport, JnlBatchName, JnlTemplateName);
    end;

Need to apply / include additional filters when finding the Customer Ledger Entry in the MatchLines Procedure related to Combine SEPA Payments. The new event should be invoked before Finding the Customer Ledger Entry. Could you please add the requested Publisher?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


README file() example fails in py3

Since the file() function is gone in Python3, the example in the README doesn't work.  Neither does the obvious substitution of open(), as at least some qfx files have binary characters (i.e., I had to open(file.qfx, 'rb'), and then it worked).  In general, the README could use some work so that it can be understood by non-expert programmers.  I may take a crack at it and offer a pull later, but I wanted to get this in now, in case someone had already done it and hadn't done a pull.
--jh--

If there is a need for opening binary file, then the Readme should change to ofx = OfxParser.parse(open('/tmp/x.ofx', 'rb')), since that will work in both python2 and python3.


[feature] Add support for loading TensorRT engine file directly (instead of onnx model)

Hello!
Thank you for the amazing guide to run onxx files in cpp. I see the code is also converting to tensorrt. Can we have support where we directly load tensorrt files and execute? thanks

Implemented in https://github.com/cyrusbehr/tensorrt-cpp-api/pull/53


v1.13: node: Fix node encryption condition in incorrect backport

Julian noticed that backported commit 7dbd40f280 ("ipsec: Remove workarounds for path asymmetry that was removed") didn't match the upstream commit due to a wrong conflict resolution. This commit fixes it.
We don't expect much impact here as node encryption was never stable, barely used, and eventually removed, but best to fix it, if only for consistency with v1.11 and v1.12.
Fixes: https://github.com/cilium/cilium/pull/26792.

/test-backport-1.13


scripts/test.py: Fix infinite busy loops on macOS

I confirmed that the same number of tests are run
with "make test" on:
* Ubuntu with and without this change
* macOS with this change

====== results ======
tests passed 817/817 (100.00%)
tests failed 0/817 (0.00%)

Please merge this pull request. I just spent an hour troubleshooting this same issue on Mac and reached the exact same code change as a fix... before discovering this pull request already exists.


Add Checklist and Key Questions components

Closes #14.
Preview pages

Checklist
Key Questions

New components

Adds the Checklist and Key Questions components as 11ty shortcodes

Notes
To keep merge conflicts to a minimum, I'm using the file structure that I noticed web.dev's 11ty instance using:

Each shortcode's markup is in its own dedicated file in _includes.
The common-tags package strips out whitespace, ensuring the component renders correctly.

I also moved markdown-it config to a separate file, markdown.js, so that we can properly render Markdown within shortcodes. (See this section of the 11ty docs for a description of the problem, and this blog post for more context around the solution here.)

This was approved by @admoorgit  and @LynnHerrick9 . Merge conflicts have been resolved and ready to merge this into main.


[question] Hellfire - command for compiling

@AJenbo, @qndel, I can not use the following command for compiling the hellfire branch.
"docker run --rm -v $(pwd):/root/devilution -e MAKE_BUILD=pdb diasurgical/riivaaja"
Is an additional parameter required for compiling the hellfire executable?
Thank you much in advance.

Following seems to work.
docker run --rm -v $(pwd):/root/devilution -e MAKE_BUILD=pdb -e HELLFIRE=1 diasurgical/riivaaja

I wouldn't know, I'm not using docker ;)

your 18 hours late :o

I'm never late ;)


Update simple.toml

Contribution to a scenario of "passwords" exposed for authentication in MSSQL Banks where by default the scenario below was not identified. Hence the proposed contribution.
{
"Microsoft.Hosting.Lifetime": "Information"
}
{
"AllowedHosts": "*",
"ConnectionStrings": {
"ContextLocal": "Data Source=(localdb)\MSSQLLocalDB;Initial Catalog=projetoX;Integrated Security=True;Connect Timeout=30;Encrypt=False;TrustServerCertificate=False;ApplicationIntent=ReadWrite;MultiSubnetFailover=False",
"ContextQa": "Server=xyzqa.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcabc;Password=A#$dDa41eUhbdbd;",
"ContextProd": "Server=xyzprod01.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcdef;Password=@@dqeddadfg;",
"ContextQa02": "Server=xyzqlqa.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcfgh;Password=AYDAJOAJjjjH;"
}
}
Description:
Explain the purpose of the PR.
Checklist:

[ ] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[ ] Have you lint your code locally prior to submission?

@rgmz thanks for support
I'm trying to adjust my rule there


GlueExtractor refactor

Summary of Changes

glue_extractor scope refactored to glue since there is already extractor on the config dict
AWS filters option added to support only extracting certain tables based

Tests
I didn't added any tests since I am abstracting the search function (there is not any good aws glue mock in python)
Documentation
I added a sample job config and more lines explain about the code.

Codecov Report

Merging #167 into master will decrease coverage by 0.1%.
The diff coverage is 30%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   82.98%   82.88%   -0.11%
==========================================
  Files          58       58
  Lines        2862     2868       +6
  Branches      308      309       +1
==========================================
+ Hits         2375     2377       +2
- Misses        394      398       +4
  Partials       93       93

Impacted Files
Coverage Δ

databuilder/extractor/glue_extractor.py
72.34% <30%> (-5.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d046eab...0c3354d. Read the comment docs.

Fastest merge in the history @feng-tao


[android] Java.Net.SocketException and Javax.Net.Ssl.SSLException are thrown in Debug not in Release

I see in code that you correctly catch Java exceptions and re-throw them as HttpRequestExceptions.
Strangely when i am in Debug mode only i catch no HttpRequestException instead the Java ones as
unhandled exceptions.
Its an edge-case but maybe if you have time you can have a look at it.
Glad to help when a time-window opens.
var innerHandler = new SecureHttpClientHandler(null);
client = new HttpClient(innerHandler);

at Java.Interop.JniEnvironment+InstanceMethods.CallObjectMethod (Java.Interop.JniObjectReference instance, Java.Interop.JniMethodInfo method, Java.Interop.JniArgumentValue* args) [0x0006e] in <1959115d56f8444789986cf39185638c>:0
at Android.Runtime.JNIEnv.CallObjectMethod (System.IntPtr jobject, System.IntPtr jmethod, Android.Runtime.JValue* parms) [0x00000] in /Users/builder/azdo/work/2/s/xamarin-android/src/Mono.Android/Android.Runtime/JNIEnv.g.cs:102
at Square.OkHttp3.IInterceptorChainInvoker.Proceed (Square.OkHttp3.Request request) [0x0005a] in <0eabf675945747edb17222b3720748da>:0
at SecureHttpClient.DecompressInterceptor.Intercept (Square.OkHttp3.IInterceptorChain chain) [0x00007] in :0
at Square.OkHttp3.IInterceptorInvoker.n_Intercept_Lokhttp3_Interceptor_Chain (System.IntPtr jnienv, System.IntPtr native__this, System.IntPtr native_chain) [0x0000f] in <0eabf675945747edb17222b3720748da>:0
at (wrapper dynamic-method) Android.Runtime.DynamicMethodNameCounter.115(intptr,intptr,intptr)
--- End of managed Javax.Net.Ssl.SSLException stack trace ---
javax.net.ssl.SSLException: Write error: ssl=0x6ecedf6d08: I/O error during system call, Software caused connection abort
at com.android.org.conscrypt.NativeCrypto.SSL_write(Native Method)
at com.android.org.conscrypt.NativeSsl.write(NativeSsl.java:426)
at com.android.org.conscrypt.ConscryptFileDescriptorSocket$SSLOutputStream.write(ConscryptFileDescriptorSocket.java:626)
at okio.OutputStreamSink.write(JvmOkio.kt:56)
at okio.AsyncTimeout$sink$1.write(AsyncTimeout.kt:99)
at okio.RealBufferedSink.emitCompleteSegments(RealBufferedSink.kt:255)
at okio.RealBufferedSink.write(RealBufferedSink.kt:146)
at okhttp3.internal.http1.Http1ExchangeCodec$KnownLengthSink.write(Http1ExchangeCodec.kt:271)
at okio.ForwardingSink.write(ForwardingSink.kt:29)
at okhttp3.internal.connection.Exchange$RequestBodySink.write(Exchange.kt:218)
at okio.RealBufferedSink.emitCompleteSegments(RealBufferedSink.kt:255)
at okio.RealBufferedSink.write(RealBufferedSink.kt:185)
at okhttp3.RequestBody$Companion$toRequestBody$2.writeTo(RequestBody.kt:152)
at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:59)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at crc647d92411772b9fe65.DecompressInterceptor.n_intercept(Native Method)
at crc647d92411772b9fe65.DecompressInterceptor.intercept(DecompressInterceptor.java:30)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:517)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:919)

Yes, I'm aware of it. I think it's related to the way xamarin handles exceptions and pass then between java and .net, which is different between debug and release. But so far I haven't found a proper explanation and a way to fix it.
However, I was assuming this issue is not occurring when using the SecureHttpClient nuget, right ? (since it's built in release mode).
Could you explain what is your scenario ?

are you debugging an application that uses the SecureHttpClient nuget ?
or are you debugging the SecureHttpCient code ?

i am deubbing an application that uses the SecureHttpClient nuget.

I will try it and report to you. Also i noticed in AppCenter logs that i do not have a single HttpRequestException.
Since you catch some Java exceptions and rethrow them as HttpRequestExceptions i should at least have one
instead of Java ones. This is not the case.

Fixed in 1.18.4

Could you add a catch also for Java.Net.ConnectException when there is no internet connection

@gsgou Could you please open a new issue ? I'm not sure I understand your request, so it's better to separate discussions.


Upgrade instructions aren't clear to me

I’m reading all of the information on upgrading my repo and keyboard to use the latest V3.0 branch & firmware (ZMK).
These are the resources I’m looking at:
https://github.com/KinesisCorporation/Adv360-Pro-ZMK#upgrading-from-v2-to-v3
https://github.com/KinesisCorporation/Adv360-Pro-ZMK/blob/V3.0/UPGRADE.md
and
https://kinesis-ergo.com/support/kb360pro/#firmware-updates
After reading all of these, I’m uncertain of how I move forward to upgrading. Is there more concise documentation? Some things I’m uncertain of:

My forked repo: I can change the default branch to V3.0, but I’m not seeing merge conflicts as described in the documentation. Is there more to it than just setting the default branch to V3.0 in my forked repo? Even testing some changes from the GUI, builds fail and I'm unsure why.
Once my repo is sorted, I’m unclear if there’s some process that I must perform on my keyboard itself (i.e., resets with V2.0 and/or V3.0, etc) prior to flashing my new firmware with my custom layout.

Any help you can provide would be greatly appreciated!

Looking at your repository it looks like you are running into a build error due to multiple macros called &macro_parens. Delete these lines from your macros.dtsi file https://github.com/P05TPWND/Adv360-Pro-ZMK-NP/blob/V3.0/config/macros.dtsi#L49-L66 and it should build without problems. Because you fulfilled the full v2.0 update cycle you are not running into the merge conflict that can happen.
Try flashing the board as is and seeing if both halves connect, if they do not connect then you need to undertake the reset procedure

@ReFil Thank you for pointing this out! I completely missed the specific error regarding the macros.dsi and this was what hung me up thinking I needed to do something else regarding the repo.


[UWP][SnackBar] App crashes when toggling SnackBar On

Current behavior
App crashes when toggling SnackBar On
Expected behavior
App should not crash
How to reproduce it (as minimally and precisely as possible)

Launch UWP app
Select SnackBar from burger menu
Toggle SnackBar
Notice that app crashes

Environment

Nuget Package:
Package Version(s):
Affected platform(s):

[ ] iOS
[ ] Android
[ ] WebAssembly
[x] UWP

Anything else we need to know?

Fix verified


Sync data between API Umbrella and our platform, via the REST interface.

Using Admin API wrapper from #65, determine how to best synchronise data from/with API Umbrella database. Implement basic scheduling algorithm or event to keep data in sync.
Definition of done:

[ ] API users exist in both databases and are kept in sync.
[ ] API endpoints exist in both databases and are kept in sync.
[ ]  Admin users exist in both databases and are kept in sync.

We decided to store API Umbrella users in a new collection. The Meteor user object will contain a foreign key relationship to the corresponding API Umbrella user(s). The relationship may be in the form of a collection helper.

Worked with @frenchbread to finish this task, based on his work in #82.


Incorporate connection handlers into underlay dispatcher

Need to be able to dispatch ConnectionHandlers as well as underlays, as they are related. Maybe can add them as an optional interface

Not worth it at this point. Current code is ok and refactoring would not simplify things. If we end up needing more complex connect handling, then it would be worth revisiting this in the future.


Escape unicode characters when producing latex

Currently, the qcircuit to latex code passes through unicode characters like ↺ ↻. LaTeX may not be happy about this. We should replace the unicode characters with some that LaTeX is happy with. Or perhaps throw an error?

Hi, could you please assign this to me?