[$250]  Hold is not displayed in the preview for the expense which is held

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.11-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721848036803009
Action Performed:

Submit a report with 2 expenses and with a violation
Sign in as  a approver
Open the report
Put the expense on Hold which has violation
Look at the expense preview

Expected Result:
Preview should show "Hold"
Actual Result:
Violation error only appears. Hold should take higher priority
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/8db49622-ab29-4d1e-a196-bdd5c15c970c

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01081754863788f760
Upwork Job ID:<PHONE_NUMBER>069367085
Last Price Increase: 2024-08-16
Automatic offers:

shubham1206agra | Reviewer | 103593386

Issue OwnerCurrent Issue Owner: @shubham1206agra

Proposal
Please re-state the problem that we are trying to solve in this issue.
Hold error message isn't prioritized to be displayed.
What is the root cause of that problem?
This is actually the same issue as https://github.com/Expensify/App/issues/44509. However, the selected solution doesn't prioritize hold, but prioritize violation type of violation. I also posted a proposal there to prioritize the hold, so I'm gonna copy and update it here a little bit since we also want to prioritize hold over review required when there is too many violations.
When showing the violation, we only take the first violation.
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L196-L207
We previously prioritized hold in this PR, but was reverted because it caused double Hold to show up. It's because we append the violation message (that contains hold) with another hold text. But it's not guaranteed that the hold violation is always at the first item of the violations.
What changes do you think we should make in order to solve the problem?

If we want the hold to be prioritized over other violations, including Review required, then we can move this condition higher in the block.
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L220-L222
if (shouldShowHoldMessage) return hold message
if (violations[0]) ...
...

Last, we can "revert" https://github.com/Expensify/App/pull/45325 because we fix it differently here.

Last, we can "revert" https://github.com/Expensify/App/pull/45325 because we fix it differently here.

@bernhardoj Can you give a proper solution here?

Sorry, I don't get what do you mean by proper solution of the revert. Can you clarify it?

This one

The current condition looks like this:
https://github.com/Expensify/App/blob/0a33186c80eb821d67d75b44bca527640204852c/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L194-L216
The solution will update it to:
if (shouldShowHoldMessage) return `${message} ${CONST.DOT_SEPARATOR} ${translate('violations.hold')}`;
if (violations[0]) ...
if (hasFieldErrors) ...

Woot!

merged!

pending prod deploy

Sorry for the confusion @dylanexpensify. I can confirm this was deployed to prod on 2024-08-28

Payment summary:
Contributor: @bernhardoj $250
Contributor+: @shubham1206agra $250
Please apply/request!

@shubham1206agra please accept offer! 🙇♂

@bernhardoj please apply to job! 🙇♂

Requested in ND.

$250 approved for @bernhardoj

done!


CRT secure warnings on Windows CI build

Derived from #864
Probably need to define _CRT_SECURE_NO_WARNINGS

Probably is going to be closed by #877, because /D _CRT_SECURE_NO_WARNINGS is going to be defined there, as these CRT warnings will become errors. And I doubt we would like to change the code base to use "secure" versions of C functions with suffix _s.

Resolved by #925


By Pass Super Admin

You've developed very nice package, and i appreciate your work, i'm using your package in my project but i'm facing some problem, The problem is i have to add all permission for super admin too in user_permission table that is not good. Because super admin can access anything without having permission or role in database. So i wanted to ask how i can check this if logged in user is super admin dont check permissions and roles. because i cannot add permission for super admin in table everytime i create new permission. Kindly tell me how i can achieve this. Thanks!

Currently, you have to attach the permissions to that role. Otherwise, you would have to make or modify the middleware to have a bypass based on the role to return true.
The design is to attach permissions to a role so I do not understand how that is as you say "not good".
The danger about making/modifying a middle to allow that is it may affect a lot of users of the package already.


RKE2 OCI Node Driver does not clean up nodes on deletion of cluster

Rancher Server Setup

Rancher version: 2.6.0-rc3
Installation option (Docker install/Helm Chart): Helm chart

If Helm Chart, Kubernetes Info:
Cluster Type (RKE1, RKE2, k3s, EKS, etc): RKE1 (v1.2.11)
Node Setup: single node all roles
Version: v1.20.9-rancher1-1

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.21.3-rc6+rke2r2
Cluster Type (Local/Downstream): Downstream, Infrastructure Provider via Oracle Cloud Infrastructure, RKE2 provisioning

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

Describe the bug

On deleting a fully provisioned OCI cluster, resources in OCI are not fully deleted. In the case I saw before, all the VMs were left running in OCI.
To Reproduce

See https://github.com/rancher/rancher/issues/33865#issuecomment-900612894
Result
Nodes are never cleaned up. Other resources could also be left behind.
See https://github.com/rancher/rancher/issues/33865#issuecomment-900612894
Expected Result

All resources provisioned by the cluster should be cleaned up on deletion.
Screenshots

See https://github.com/rancher/rancher/issues/33865#issuecomment-900612894
Additional context

This came up as part of testing https://github.com/rancher/rancher/issues/33865

I am seeing this issue now in another scenario (not related to OCI). It seems that deleting a cluster in an error state and then re-provisioning with the same name is causing some problems with deletion and finalizers.
Specifically, the original deletion (of the cluster in an error state) is not completing. Then when provisioning another cluster with the same name, the objects are reused and UIDs are not matching.

The nodes are listed by the command provided, but they have the TERMINATED state, which is expected.
For example, when the cluster is running I see (which includes a previously created cluster).

After I delete the cluster, I see the following:

This seems to be working as expected.

Assigning @rmweir for dev-validate

Driver cannot be downloaded bc pod is not running as root.
Downloading driver from https://github.com/rancher-plugins/rancher-machine-driver-oci/releases/download/v1.1.0/docker-machine-driver-oci-linux
docker-machine-driver-oci-linux
docker-machine-driver-oci-linux: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped
mv: cannot move 'docker-machine-driver-oci-linux' to '/usr/local/bin/docker-machine-driver-oci': Permission denied

This then leads to an outdated driver being used and flags not being recognized:
flag provided but not defined: -oci-node-memory-in-gb and join url to be available on bootstrap node

Tried using version of rancher-machine provided by @thedadams that fixed the permissions. Encountered the following error:
Waiting for machine to be running, this may take a few minutes...
Detecting operating system of created instance...
Waiting for SSH to be available...
Error creating machine: Error detecting OS: Too many retries waiting for SSH to be available.  Last error: Maximum number of retries (60) exceeded
The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.


Add items schema for .controlPlane.availabilityZones

This PR:

Adds items schema for .controlPlane.availabilityZones.

This is required for proper validation and generating a data entry form for this app (towards https://github.com/giantswarm/roadmap/issues/1181)
Testing

[ ] Fresh install works.
[ ] Upgrade from previous version works.

Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml is valid.

Waits for https://github.com/giantswarm/cluster-openstack/pull/127


Chat body isn't scrollable

I experienced it in a chat channel mode, for example here. However, it could be also at personal messages what I haven't tested.

The chat is scrollable for me. Do you have a screenshot about this? What browser are you using?

I've just tested on Chromium too, where it is scrollable.
The issue is under Firefox.

Related to https://github.com/philipwalton/flexbugs/issues/42; will fix removing flexbox from the messages list layout.


Differentiate VotingPower errors

We need to differentiate between voting power erorrs originating from skipping and verification. Reference

Done in #132


Feature request: link

Implement the ability to insert a link into the editor

Hi @andrictham , I have marked this as enhancement to be implemented on next releases

any eta? when we can get this feature?

+1

+1

+1

+1


There is no lab guides available anymore for W10

Lab Guides seems to have been replaced by lab files (VM etc) when it was updated last week.

There also seems to be two separate lab file downloads per environment (Win10 and Win11). One file with a date at the end and another without. They are different sizes as well, so without downloading both and extracting/running each, I am unable to determine which one is the refreshed lab.

I had tested for Windows 10 Lab. The Windows 10 lab environnment https://download.microsoft.com/download/3/3/a/33a3c7d7-b393-4f78-9b90-2d5eb7fd98e8/Win10_21H1_lab.zip was created in February. The Windows 10 lab Guides https://download.microsoft.com/download/2/9/9/29952cdb-b98d-4f9b-9d6e-9fb49644b0a0/Win10_21H1_Lab_05.12.zip was updated on 11/05. From my understanding, the second linked I provided should be available under the shortcut Windows lab environnment. The previously lab guides to set up the environment have been replaced by it.

@msbemba

@Turbo974  Thank you for your feedback. I'm currently checking with the author and provide an update shortly.
Thanks
Sri

As per https://github.com/MicrosoftDocs/microsoft-365-docs/issues/8714 Closing


Annotations method fails if called without sandbox

Partial stack trace:
  File "/usr/local/lib/python3.9/site-packages/veracode_api_py/api.py", line 141, in add_annotation
    return Findings().add_annotation(app,issue_list,comment,action,sandbox)
  File "/usr/local/lib/python3.9/site-packages/veracode_api_py/findings.py", line 51, in add_annotation
    return APIHelper()._rest_request(uri,"POST",body=payload,params=params)
UnboundLocalError: local variable 'params' referenced before assignment

Fixed in pull request #8


Send X-Content-Md5 header on file requests

This applies to both HEAD and GET requests.
DLTP-1790

Is this for Steve's checksum retrieval?

Yup. It looks like it was missing just due to an oversight.


Added new algorithm  from inorder and preorder #1060. Please review a…

…nd merge it

#1060

late submission


java-security-test should support Annotation based servlet configurations

At the moment java-security-test supports only web.xml based servlet definitions, it should support annotations like @WebServlet to automatically configure application server for tests.

Closing this as Github Issue section is no longer maintained.


changed copypassword fields in databases

in reference to issue #907

Thanks!

also added commits for feature #917
new updated ui

@andrasbacsai

Thanks for the PR! 💜


Add kata reverted-merge

I have added a kata to practise what happens when you revert a merge commit.
It can be used to explore the solutions proposed in:
https://github.com/git/git/blob/master/Documentation/howto/revert-a-faulty-merge.txt
I guess it is a quite advanced exercise and it follows only partly the style in the repository in that it focusses less on specific commands and more on a particular git situation.
However, I'd be glad to contribute it to your repository if you want.

Hi!
Thank you so much for your contribution.
This is indeed an advanced exercise that I will be happy to accept.
I will add a link to the gist that you provide, since that gives a bit of context.
Have an excellent day, and thank you again!

 I am happy that you consider the exercise useful.


Underspecification leads to invalid proofs.

The proved does not always detect potentially stuck states and, due to that, can prove erroneous statements.
Below @virgil-serbanuta and myself took advantage of the underspecification of division (division by 0 is unspecified) in the semantics to prove that M / N always reaches M /Int N, additionally ensuring that N =/=Int 0.
@grosu, @bmmoore please take a look.
@andreistefanescu could you confirm? Also, could you advise on how complex would be to fix it?
Steps to reproduce

In k-distribution/samples-kore/kernelc

kompile kernelc.k

Consider the following program div0.c:
int sum_iterative
(int m, int n) {
  return m / n;
}

Using sum_iterative since  it is already defined in the SYNTAX module.

and the corresponding spec div0_spec.k:
module DIV0-SPEC
  imports KERNELC

rule
  <fun>... FUN:Map ...</fun>
  <k>
    sum_iterative(tv(int, M:Int), tv(int, N:Int))
  =>
    tv(int, M /Int N)
  ...</k>
ensures N =/=Int 0
endmodule

 krun --prove tests/simple/div0_spec.k --smt_prelude ../../include/z3/basic.smt2 tests/simple/div0.c

That looks bad. In general terms we should be able to compute a condition for not getting stuck.

@traiansf yes, this is a limitation of the prover. A better way of phrasing it is that the prover assumes that the semantics is "complete".
In theory, the condition can be arbitrarily complex, and thus undecidable. In practice, you can try to look at the cases when narrowing occurs (as opposed to rewriting), and check that the disjunction of the unification constrains if true. It should work when the narrowing only splits on boolean/integer values. I can give more details about the codebase if you decide to work on this.

I believe we should either work on solving this problem or develop a "completeness checker", maybe similar to the Sufficient Completeness Checker of Maude.  Because it's ok in theory to say the semantics should be complete, but in practice it would be unsafe to assume that of a reasonably large semantics.
Personally, I would advocate for a separate tool for checking completeness. The benefit of it would be that it's orthogonal to the prover and it doesn't clutter it even more.

Guys, this is the fifth time for me to discuss this issue.  Not sure what's the best way to avoid wasting our/my time re-discussing things over and over again.
I agree with the checking completeness tool.  That will be needed anyway for the semantics of K in matching logic, because there will be axiom stating that a step can only be made with one of the rules and with nothing else.  So if we have a completeness checker, then this becomes simpler, too.
For the completeness checker, @traiansf and others, I think we can/should have a reduction to SMT or matching logic.  That is, suppose that the rules in our semantics are, after lifting => to the top level,
phi_1 => psi_1
phi_2 => psi_2
...
phi_n => psi_n

Then what we need is to prove, in matching logic, the validity of:
|= phi_1 \/ phi_2 \/ ... \/ phi_n

The ML prover should take this be able to prove it.
Some of the symbols can be constructors and their axioms can certainly help there; see the ML recent journal paper for how: http://fsl.cs.illinois.edu/index.php/Matching_logic, section 5.7

I think what you propose would work only for a system without final
states... Maybe we can define valid final states as a predicate and
disjunct that with your condition.
joi, 9 nov. 2017, 14:26 Grigore Rosu<EMAIL_ADDRESS>a scris:

Guys, this is the fifth time for me to discuss this issue. Not sure what's
the best way to avoid wasting our/my time re-discussing things over and
over again.
I agree with the checking completeness tool. That will be needed anyway
for the semantics of K in matching logic, because there will be axiom
stating that a step can only be made with one of the rules and with nothing
else. So if we have a completeness checker, then this becomes simpler, too.
For the completeness checker, @traiansf https://github.com/traiansf and
others, I think we can/should have a reduction to SMT or matching logic.
That is, suppose that the rules in our semantics are, after lifting => to
the top level,
phi_1 => psi_1
phi_2 => psi_2
...
phi_n => psi_n
Then what we need is to prove, in matching logic, the validity of:
|= phi_1 / phi_2 / ... / phi_n
The ML prover should take this be able to prove it.
Some of the symbols can be constructors and their axioms can certainly
help there; see the ML recent journal paper for how:
http://fsl.cs.illinois.edu/index.php/Matching_logic, section 5.7
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kframework/k/issues/2360#issuecomment-343139611, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACwZU0RghUIPGzKOE_W047D8QIujG0sXks5s0u99gaJpZM4QS8_b
.

It seems that this might not be a bug that we can fix easily, so I guess it should be its own project, not just maintenance work which we do on the spot, right?
To make sure I understand, since I'm still new to matching logic:
Considering that in our rules we assume a T cell at the top, the full formula that we need to check would be |= ((exists x1..xm) (x1, ... xm)) -> (phi_1 / phi_2 / ... / phi_n), right?

It seems that Github ate some of my characters... The formula should be:
 |= ((exists x1..xm) <T>(x1, ... xm)) -> (phi_1 \/ phi_2 \/ ... \/ phi_n)

Something like that, @virgil-serbanuta .  Note that the patterns phi_i also contain the constraints on their variables (the side conditions).
Yes, we cannot / should not fix this now in this Java version.  This is tricky and will take some time.  Also, I am pretty sure that our current version misses lots of important axioms, such as what is a constructor and what not, so most likely Z3 will not even have what it needs in order for the property to be provable.  We should do this properly with the next version of the symbolic engine, based on the formal semantics of K that will be make public shortly.

I don't know how slow it would be, but I think it might not be very complicated to dynamically check it in the prover. At every single step is already finding a list of candidate rules, computing a path condition for each, and then adding successor states according to all rules for which the path condition can't be proven impossible. After calculating that list of successors, you could make one more Z3 query hoping to prove that the negation of the disjunction of those conditions is unsatisfiable.


Installed maps not detected correctly

The client currently relies on technicalName which was meant to equal to the map folder name on the file system. This is, however, not the case.
Since the map folder is part of the scenario.lua, we can't just rename the folder. Instead we have to either get rid of using technicalName, or adjust the API so that it gives us the actual folder name.
This leads to different bugs, I guess the map not being able to install correctly is one of them.
Depends on FAForever/api#87

Since FAForever/api#92 the technicalName is equal to the folder name again, rendering this issue invalid.


need check - no hierarchical relation between gene-level diseases in MONDO

need a way of checking that there are no hierarchical relation between gene-level diseases in Mondo
related to https://github.com/monarch-initiative/mondo/issues/745

see report
https://github.com/monarch-initiative/mondo/blob/master/src/ontology/reports/mondo_analysis.md#check-no-subclass-between-genetic-disease-warning

This came up on the QC check:
'congenital fiber-type disproportion myopathy' subclass of actinopathy
actinopathy: 'disease has basis in dysfunction of' some ACTA1
'congenital fiber-type disproportion myopathy' has mutations in several genes, including ACTA1
@matentzn is there a way to relax this check so this is acceptable?

Are we sure that the genetic disease pattern with multiple genes is correct? Isn't there an implicit "and has basis in dysfunction of only ATC" that is simply being closed by the definition definition? This needs the be run by @cmungall. I kind of would assume that "has basis in dysfunction of" implies an exhautive enumeration..

Good question @matentzn. I'll send Chris a message on Slack.
There is one more example here - same thing as above: MONDO:0009711  congenital fiber-type disproportion myopathy, child of actinopathy

Note to self - these all should have been addressed on PR #2440 except

term
term_label
d2
d2_label

MONDO:0009711
congenital fiber-type disproportion myopathy
MONDO:0100084
actinopathy

MONDO:0009711
congenital fiber-type disproportion myopathy
MONDO:0100084
actinopathy

See comments in #900 - rename MONDO:0100084 to alpha-actinopathy (there is a good argument to obsoleted and create a new). I'm wondering where it came from, looks like an orphanet term...

"'congenital fiber-type disproportion myopathy' subclass of actinopathy"
the check is doing it's work as there are multiple things wrong here
name: congenital fiber-type disproportion myopathy
def: "A rare genetic disorder caused by mutations in the TPM3, ACTA1, RYR1 and SEPN1 genes. It is inherited in an autosomal dominant or recessive pattern and rarely in an X-linked pattern. It manifests with myopathy throughout the body, particularly in the muscles of the shoulders, upper arms, hips, and thighs. Affected individuals may have contractures, lordosis, or scoliosis. In a minority of cases mild to severe breathing problems may occur." [NCIT:C120046]
the def says OR, but the current parents says it's necessarily ACTA1!
Note the axioms for this class have a conjunction of causes. This should only be the case for polygenic diseases! Multiple axioms in OWL means AND not OR!

@cmungall the definition says AND:
"...disorder caused by mutations in the TPM3, ACTA1, RYR1 and SEPN1 genes."
Also, it is a child of other single gene terms:
'RYR1-related myopathy'
'TPM2-related myopathy'
'TPM3-related myopathy'
these didn't come up as an error though.
I am more confused now!

For the record, Chris clarified for me - this is not a polygenic disease, the def is meant to imply 'or', not 'and'. I removed the gene annotations and the gene-related parents.


82 experiment with helm tiller

Even though this failed the pipeline, I would like to commit it to get past this failure.


fixbug:Compatible with non-indexed arrays

Compatible with non-indexed arrays

Compatible with non-indexed arrays


CMD + K is not working when the focus is on compose box

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
User should be able to change chats when using the command + k.
Actual Result:
CMD + K is not working when the focus is on compose box.
Action Performed:

Log in to e.cash
Navigate to a conversation
Set the focus to the compose box
Hit CMD + K

Workaround:
User has to manually set the focus on the chat switcher
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App
Mobile Web
**Version Number:**1.0.66-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1623271189154800

CMD+K shortcut is not working when the focus is in the chat text box (tested on web in staging, if this is not happening in prod, we should block deploy on it)

Additional info:
This change was caused by upgrading our react-native-web package to 0.15.7.
It appears that when focused on inputs, all existing keybinds no longer work.

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

I think I agree with @stitesExpensify on this one – we probably don't want to revert https://github.com/Expensify/Expensify.cash/pull/3215. We won't be doing a prod deploy today anyways, so we have tomorrow to try and get this fixed, so that would be ideal. But otherwise I think we should just :shipit: and not treat this as a deploy blocker.

DB's stay internal because they are hourly priority (unless that's changed), so I'm removing the label for the time being.
I agree with Rory, let's use tomorrow to assess what the fix is for this. If it's straightforward, let's do it and avoid shipping a regression that has a pretty big impact on everyone's productivity in E.cash. If we end up needing more time, then I think we'll need to remove it as a deploy blocker, so that we can get a new prod build to Apple and unblock N5.

I also don't think this should be a deployBlocker. But I will take a look at the issue today to see if there's a simple fix.

No luck. I added some notes on the PR which introduced this library change. Moving onto other deploy blockers.

👋 @HorusGoul found the fix in this thread. Over to you, @roryabraham!

Thanks to @HorusGoul the PR to fix this is ready for review


mongo-connector not pulling data to solr after the addition of copyField

Hi,
I use mongo-connector, mobgodb v3, solr 5.3 for full text search. It works but I would boost ranking on some fields. I have over 20 fields to search against, only want to boost ranking on title, keywords, teaser. So I went to create a copyField to host the values from these fields w/o ranking boost.
After I made change in the schema file of managed-schema, I can restart solr, restart  mongo-connector, but no data were under /data/index.
What could be the cause of the issue? Any suggestions?  Thanks! --Wendy

coomad line that I used:
./mongo-connector -m localhost:27017 -t http://localhost:8983/solr/keywords -n pdb101v2.motm_articles --auto-commit-interval=0 -d solr_doc_manager

part of the schema file:

<field name="keywords.0" type="string" indexed="true" stored="true"/>
<field name="keywords.1" type="string" indexed="true" stored="true"/>
<field name="keywords.2" type="string" indexed="true" stored="true"/>
<field name="keywords.3" type="string" indexed="true" stored="true"/>
<field name="keywords.4" type="string" indexed="true" stored="true"/>
<field name="keywords.5" type="string" indexed="true" stored="true"/>
<field name="keywords.6" type="string" indexed="true" stored="true"/>
<field name="keywords.7" type="string" indexed="true" stored="true"/>
<field name="keywords.8" type="string" indexed="true" stored="true"/>
<field name="keywords.9" type="string" indexed="true" stored="true"/>
<field name="keywords.10" type="string" indexed="true" stored="true"/>
<field name="keywords.11" type="string" indexed="true" stored="true"/>
<field name="keywords.12" type="string" indexed="true" stored="true"/>
<field name="keywords.13" type="string" indexed="true" stored="true"/>
<field name="keywords.14" type="string" indexed="true" stored="true"/>
<field name="keywords.15" type="string" indexed="true" stored="true"/>
<field name="klist" type="string"  indexed="true" stored="true" multiValued="true"/>

 <copyField source="keywords.0" dest="klist"/>
  <copyField source="keywords.1" dest="klist"/>
  <copyField source="keywords.2" dest="klist"/>
  <copyField source="keywords.3" dest="klist"/>
  <copyField source="keywords.4" dest="klist"/>
  <copyField source="keywords.5" dest="klist"/>
  <copyField source="keywords.6" dest="klist"/>
  <copyField source="keywords.7" dest="klist"/>
  <copyField source="keywords.8" dest="klist"/>
  <copyField source="keywords.9" dest="klist"/>
  <copyField source="keywords.10" dest="klist"/>
  <copyField source="keywords.11" dest="klist"/>
  <copyField source="keywords.12" dest="klist"/>
  <copyField source="keywords.13" dest="klist"/>
  <copyField source="keywords.14" dest="klist"/>
  <copyField source="keywords.15" dest="klist"/>
 <dynamicField name="*klist" type="string"   indexed="true"  stored="true" multiValued="true"/>

mongo-connector won't re-index any documents if it thinks they were replicated already. Try using another oplog.timestamp file, or delete the existing one.

Hi IIvtt,
I did delete the existing oplog.timestamp file and the mongo-connector.log file.
No data were pulled over under Solr folder of  /solr/server/core/data/index/
I used the following to start mongo-connector.  Do you know if mongo-connector/solr_doc_manager/copyFields have been tested and will work?  Thanks for your help!
./mongo-connector -m localhost:27017 -t http://localhost:8983/solr/keywords -n pdb101v2.motm_articles --auto-commit-interval=0 -d solr_doc_manager

Can you provide the logs from mongo-connector?

Hi llvtt,
Thank you very much for your response.  The log file has no data (see below).
-rw-r--r-- 1 wtao rcsbdev       0 Nov 17 14:49 mongo-connector.log
-rw-r--r-- 1 wtao rcsbdev     101 Nov 17 15:07 oplog.timestamp
I did some changes, now the mongo-connector pulls data from mongodb to ./solr/server/keywords/data/index/
But I don't see the copyField (see the attached file below). Do I suppose to see the copyField data here?  Thank you very much for your help!
motm-index-data.txt

I'm not sure what I'm missing here. It looks like your copyField is in the
response in motm-index-data.txt:
...
"klist": [
"John Kendrew\n",
"oxygen binding\n",
"oxygen transporter activity \n"
],
...
On Tue, Nov 17, 2015 at 12:13 PM, Wendy8787<EMAIL_ADDRESS>wrote:

Hi llvtt,
Thank you very much for your response. The log file has no data (see
below).
-rw-r--r-- 1 wtao rcsbdev 0 Nov 17 14:49 mongo-connector.log
-rw-r--r-- 1 wtao rcsbdev 101 Nov 17 15:07 oplog.timestamp
I did some changes, now the mongo-connector pulls data from mongodb to
./solr/server/keywords/data/index/
But I don't see the copyField (see the attached file below). Do I suppose
to see the copyField data here? Thank you very much for your help!
motm-index-data.txt
https://github.com/mongodb-labs/mongo-connector/files/37149/motm-index-data.txt
—
Reply to this email directly or view it on GitHub
https://github.com/mongodb-labs/mongo-connector/issues/354#issuecomment-157492473
.

Hi llvtt,
Thank you so much! You are right, I see it :-)
You can close this ticket now.
Now I need to debug on solr end.
All the best!
Wendy


Headers already sent in ScheduledTasks.controller.php

Lines 74-76
This is an ancient bug, present in SMF. >_>

Some hint on specific cases it happens?
Lines 74 to 76 of the controllers are an if an an empty line, those should never complain about headers... :-\
Ohhh... you mean 1.1? Sorry, I thought you were talking about 1.0.
The best I can imagine is that it reacts to another error already send out (maybe). Could you check in the scheduled tasks log if there is one failing?

This obviously is not a big bug. It has however generated a decent fraction of a billion lines in my error logs -_-

Looks like the lines have moved .. was this the call to dieGif(true)? If so we could use a simple !headers_sent() to prevent the error log spam, not a fix but a block.   Could also do a  (!headers_sent($filename, $linenum)) and log when it fails so we can better see whats getting called first.

Got moved here:
https://github.com/elkarte/Elkarte/commit/7aed48e3d6dd547cc162af2e2fd9ad5e3016d9f3
Though I'm not sure if the issue got addressed properly. @emanuele45 ?

Indeed.
7aed48e3d6dd547cc162af2e2fd9ad5e3016d9f3 is just a moving things around, never meant to fix anything.
It would be very useful to find out when headers are sent out the first time...

Best we can do is ask someone who is seeing the error to also log it to the Elk error log using headers_sent($filename, $linenum) plus logerror  that should let us know where its happening.   Since the purpose of the function is to keep the connection alive, I guess if headers are already sent in some cases,  we could just check for that, flush and go

I have the feeling it may happen in case of errors... maybe database errors, but it's based on nothing at all...

Humm I bet thats true ... at which point we can't really "stop" that, but checking if the headers were sent before sending  even more would at least stop filling up the server error log.

I added the logging code, without localization and with a note to remove the code when this bug is fixed.

Moved to 2.0 with the meaning of "when the proper error will be reported, the bug will be fixed and the issue closed". Not because I was to ignore it. :smile:

https://www.elkarte.net/community/index.php?topic=5182.0
The problem is the fastcgi_finish_request call introduced a while ago.
The possible solutions I see are:
drop the fastcgi_finish_request call
drop the gif header and just send an empty page

Or don't call dieGif from the autotask method if you have called fastcgi_finish_request and closed the connection?
		if (!function_exists('fastcgi_finish_request'))
			dieGif(true);

On second thought (and test) ... I'd say drop the call.

The reason I added it is because if you have any meaningful forum members can end up waiting several minutes for the request to finish.
It could be optional, but it is deathly necessary for any sufficiently massive forum.

Interesting ...  maybe for now we just do a
	if (function_exists('fastcgi_finish_request'))
	{
		die();
	}

at the start of dieGif()

Makes sense I guess.

Well, at least for now, considering it's not likely to be terribly widespread, to me works.
For later we can think about something different. :+1:

Did what we could for 1.1.4, moving this to 2.0 for any further action


Support batch writing of values？

Hi，Does it support batch writing of values? Only a single write value is seen in the example directory

Yes.  It supports writing multiple values at once with gologix:"<tagname>" tagged structs.  It also has the ability to do a map[string]interface{} with the writeDict() function where the keys of the map are the tag paths and the values are the values to write, but this isn't exported for some reason.
I'll try and get that exported for easier use (read already has this exported as the ReadList() function) and get an example made up for it.
In the meantime you should be able to use a tagged struct like I said.

I released beta 17 where I have made the function for writing multiple tags at once external.  See "MultiWrite" in the example folder for what I think you're looking for.
Let me know if you have any issues.

That is my want. Thank you.


Kerberos

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #3593

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Plagiarism check done ✅
But I think this article is light on substance - What do you think? @mercymeave
And he should change the title.

Plagiarism check done ✅
But I think this article is light on substance - What do you think? @mercymeave And he should change the title.

Yeah @ahmadmardeni1, I think he can work on by giving use cases and an implementation example to benefit the readers more.

@mercymeave
Thanks for the input. I shall add a couple of diagrams and increase the technicality of the content. Will that be okay?

@mercymeave Thanks for the input. I shall add a couple of diagrams and increase the technicality of the content. Will that be okay?

JUst ensure what you add, has value to the article, enhances easy readability and understanding.

Updated with a few more details.


Make stats gathering idempotent

Leftover from #1683 , found on https://github.com/weaveworks/scope/issues/1795

LGTM

There's a race where StartGatheringStats() could get called twice, and the second call happens before the line c.statsConn = conn is reached, so we'll start a second goroutine and have two things gathering stats.
But that's not a regression in this particular PR, so LGTM.

There's a race where StartGatheringStats() could get called twice, and the second call happens before the line c.statsConn = conn is reached, so we'll start a second goroutine and have two things gathering stats.

Good catch, would you mind filing a bug for it?


all the new issues ideas to start with

Homepage
Issue 1: Design Homepage Layout
Description:

Create a homepage layout with sections for:

Tagline and mission statement.
Quick navigation links to Tutorials, Projects, and Community.
Space for latest blog posts and project highlights.

Add a banner image at the top and ensure the design is responsive for both desktop and mobile.

Issue 2: Add Dynamic Project Showcase
Description:

Implement a carousel or grid to display featured projects.
Include project name, short description, and a link to the repository.

Learning Hub
Issue 3: Create Tutorials Page
Description:

Design a page for categorized tutorials (e.g., Programming, Cybersecurity, Frameworks).
Add placeholder content for each category.

Issue 4: Add Skill Roadmaps
Description:

Create infographic-style skill roadmaps for topics like GSoC preparation, web development, etc.
Ensure the roadmaps are visually appealing and easy to follow.

Issue 5: Integrate Quizzes and Challenges
Description:

Add an interactive feature for quizzes and coding challenges.
Allow users to track their progress.

Projects Showcase
Issue 6: Design Projects Showcase Page
Description:

Develop a project showcase page with filters for domains (e.g., web development, ML, game development).
Include cards with project names, short descriptions, and repository links.

Issue 7: Write Contribution Guidelines
Description:

Create a Markdown file for contribution guidelines.
Include steps for forking, cloning, and submitting pull requests.

Community Section
Issue 8: Develop Discussion Forum
Description:

Implement a discussion board for Q&A and idea-sharing.
Allow users to post questions and comment on threads.

Issue 9: Create User Profiles
Description:

Design user profile pages to display achievements, skills, and contributions.
Include a feature for skill endorsements.

Issue 10: Integrate Real-Time Collaboration
Description:

Add links to WhatsApp or Discord for real-time collaboration.
Include a brief description of the collaboration channels.

Events and Challenges
Issue 11: Create Events Page
Description:

Design a page to announce events like hackathons, webinars, and coding challenges.
Include an option to RSVP or register for events.

Issue 12: Add Calendar View
Description:

Implement a calendar to display upcoming events.
Allow users to click on an event for more details.

Issue 13: Implement Leaderboard System
Description:

Develop a leaderboard to track user performance in challenges and events.
Display top contributors or performers.

Blogs and Resources
Issue 14: Set Up Blogging Platform
Description:

Create a blogging platform for team members to share posts.
Include features for adding tags and images to blogs.

Issue 15: Create Resources Library
Description:

Design a page for categorized resources (e.g., free courses, repositories).
Add a search feature to easily find resources.

Issue 16: Add Tips and Tricks Section
Description:

Create a section for quick tips and productivity hacks.
Allow users to submit their own tips.

Team and Vision
Issue 17: Design About Us Page
Description:

Create a page introducing the core team and their vision.
Include short bios and photos of each team member.

Issue 18: Write Mission Statement
Description:

Draft a mission statement and goals for UberCoders.
Display this prominently on the About Us page.

Interactive Tools
Issue 19: Build Markdown Editor
Description:

Create a Markdown-based editor for easy documentation (e.g., README generator).
Include live preview functionality.

Issue 20: Develop Code Playground
Description:

Implement a code playground for users to test and run snippets.
Support multiple programming languages.

Issue 21: Implement Task Manager
Description:

Add a task manager to track project contributions.
Allow users to assign tasks and mark them as complete.

Career Prep Zone
Issue 22: Add Resume Templates
Description:

Provide customizable resume templates.
Include guides on how to write effective resumes.

Issue 23: Schedule Mock Interviews
Description:

Add a feature to schedule mock interviews with sample questions.
Provide feedback options for interviewers.

Issue 24: Include GSoC Proposal Guide
Description:

Create a detailed guide for writing strong GSoC proposals.
Add examples of successful proposals.

General Tasks
Issue 25: Add Dark/Light Theme Toggle
Description:

Implement a dark/light theme toggle for the entire website.
Ensure seamless switching without affecting usability.

Issue 26: Optimize for Mobile and Desktop
Description:

Test and optimize the website for both mobile and desktop devices.
Fix any responsive design issues.

Issue 27: Set Up SEO and Analytics
Description:

Integrate SEO tools to improve site visibility.
Add analytics to track user behavior and performance.

Choose a issue to work on. 🔁


[Bug] BetterDiscord no longer keeps you logged in when Discord crashes

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a plugin or theme

Describe the Bug
When Discord crashes (due to #1687 or otherwise) it now logs you out, which BetterDiscord used to (optionally?) prevent.
Expected Behavior
This is a vanilla behavior that BetterDiscord used to (optionally?) prevent. Any option (if it existed) seems to have gone, and the behavior no longer works.
Steps To Reproduce

Crash Discord
Observe that you've now been logged out

Operating System
Windows
Discord Version
Stable
BetterDiscord Version
v1.9.5
Anything else?
This broke at #1683, but that issue is closed as resolved now, so I think it is appropriate to open an individual tracking issue for this feature.

Do you have devtools open when it crashes? I have not yet been logged out from any of my crashes

Yeah, it crashes from devtools and then I'm logged out. Alt+F4 doesn't log me out, but opening DevTools does:

and force-killing the process also does.
This is mildly infuriating for someone with a very long password and 2FA

Do you have this enabled?

Do you have this enabled?

Nope.
Here are the config files, if you have any other inquiries:
emotes.json
misc.json
plugins.json
settings.json
themes.json

Enable that and you should be good. It's a side effect of that setting and not an intentional feature.

Weird how it's a side effect of that setting if I've never used that setting and still got the crash protection, but alright.

Im having same issue, and Holdup option enable

Im having same issue, and Holdup option enable

You should restart Discord after enabling it to make sure it's really enabled. After that it started working for me.

Im still having crash not working for me

That isn't supposed to fix the devtools crash. That fixes you being logged out after the crash.

Ok


<IP_ADDRESS>:53 conflicts

Problem/Motivation
Hello, the addon unfortunately has conflicts with port 53. I have Adguard and unfortunately <IP_ADDRESS>:53 is occupied, so unfortunately I can only start one container.
Expected behavior
<IP_ADDRESS>:53 is not used like in the original container

@axute NetBird will attempt to listen on port 53, and if it fails, it should listen to port 5053. Can you share your netbird container logs so we can investigate more?

This happens, if I start Adguard before:
2023-06-22T16:15:33+02:00 WARN client/internal/dns/server.go:181: binding dns on <IP_ADDRESS>:53 is not available, error: listen udp <IP_ADDRESS>:53: bind: cannot assign requested address
2023-06-22T16:15:33+02:00 WARN client/internal/dns/server.go:181: binding dns on <IP_ADDRESS>:53 is not available, error: listen udp <IP_ADDRESS>:53: bind: address already in use

the container starts, but I have to disable the start on boot, because netbird starts also if the port is bind, but adguard fails to start.

okay, the DNS management I found in the dashboard, but the issue is only on home assistant.
I would like to change the client, how could I set an environment variable in the home assistant configuration?

imho in this case netbird should have to listen on different ip then <IP_ADDRESS> eg: <IP_ADDRESS>:53 and if the host (as in case of home assistant) runs systemd-resolved then and this dns as a resolver for .netbird.cloud

This happens, if I start Adguard before:
2023-06-22T16:15:33+02:00 WARN client/internal/dns/server.go:181: binding dns on <IP_ADDRESS>:53 is not available, error: listen udp <IP_ADDRESS>:53: bind: cannot assign requested address
2023-06-22T16:15:33+02:00 WARN client/internal/dns/server.go:181: binding dns on <IP_ADDRESS>:53 is not available, error: listen udp <IP_ADDRESS>:53: bind: address already in use

anyway imho it's rather an adguard bug then netbird. adguard shouldn't have to or try to listen on *:53 rather only on 127.0.0.x:53 and <public ip>:53. in this case netbird can listen on <IP_ADDRESS>:53.. so imho you should report it on adguard...

Yes I have already done that, it even binds the port hard coded. But he is of the opinion that I should look for the reason why the port is busy and fix it.
It's difficult for me because neither the Adguard server nor the Netbird client can be configured in this regard.

Just for history reasons: https://github.com/hassio-addons/addon-adguard-home/issues/432

I added extra env variable setting to the config. after adding this to the config:
- name: NB_DNS_RESOLVER_ADDRESS
  value: <IP_ADDRESS>:5053

i see this in the log
2023-06-25T15:32:35+02:00 DEBG client/internal/dns/server.go:140: starting dns on <IP_ADDRESS>:5053
2023-06-25T15:32:35+02:00 WARN client/internal/dns/server.go:311: the DNS manager of this peer doesn't support custom port. Disabling primary DNS setup. Learn more at: https://netbird.io/docs/how-to-guides/nameservers#local-resolver

may be this would be good for you

and an updated version will use systemd-resolved so probably working without extra environment variable

OK, thanks for the engagement. Currently I can't see DNS problems anymore (v0.21.7).
2023-06-26T09:35:23+02:00 INFO client/internal/dns/file_linux.go:103: created a NetBird managed /etc/resolv.conf file with your DNS settings. Added 1 search domains. Search list:  netbird.selfhosted


Make Arbitrary impl to honor bounds

Close #19

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 79.47%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/bounded_vec.rs
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.6%

Covered Lines:
120

Relevant Lines:
151

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 79.47%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/bounded_vec.rs
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.6%

Covered Lines:
120

Relevant Lines:
151

💛  - Coveralls


Multiple Photo Fields in a single CRUD

I've created CRUD containing two Photo fields (cover and map). Problem is that only the first selected image is being uploaded. So, if I first select the cover image, then map image, only the cover image is being uploaded.
I noticed that both fields are filled with string values. In above-mentioned case, cover field gets correct value (e.g.<PHONE_NUMBER>-filename.jpg) and map field gets something like /tmp/jVJthcgcF. If I upload just the map image, it gets uploaded successfully and the filename is correct.
How can I solve this problem?

@aleksandarmilutinovic I guess it's a bug inside of the package which is not easy to solve. We are currently not actively supporting the free package fixes and switched to online version at quickadminpanel.com - so that's the one I would recommend if you want quick fix. Otherwise - this issue will wait until someone on the team will find time, a few weeks at least.

@PovilasKorop Thanks for reply. I'll probably try to fix it and make a pull request. I suppose that pull request verification will be quicker that fixing the bug :)

@PovilasKorop Here is a fixed FileUploadTrait. I couldn't create Pull Request so, please, revise and update the trait so this issue can be fixed officially. Thanks in advance.
There was a bug in recreating the request (I've commented the changes). I didn't want to change the entire logic, but just to fix current issue.
Please let me know if there is anything wrong with the fix. Thanks!
<?php

namespace App\Http\Controllers\Traits;

use Illuminate\Http\Request;
use Intervention\Image\Facades\Image;

trait FileUploadTrait
{

    /**
     * File upload trait used in controllers to upload files
     */
    public function saveFiles(Request $request)
    {
        if (!file_exists(public_path('uploads'))) {
            mkdir(public_path('uploads'), 0777);
            mkdir(public_path('uploads/thumb'), 0777);
        }
        $newRequest = null; // Variable to hold a new request created by above array merging
        foreach ($request->all() as $key => $value) {
            if ($request->hasFile($key)) {
                if ($request->has($key . '_w') && $request->has($key . '_h')) {
                    // Check file width
                    $filename = time() . '-' . $request->file($key)->getClientOriginalName();
                    $file     = $request->file($key);
                    $image    = Image::make($file);
                    Image::make($file)->resize(50, 50)->save(public_path('uploads/thumb') . '/' . $filename);
                    $width  = $image->width();
                    $height = $image->height();
                    if ($width > $request->{$key . '_w'} && $height > $request->{$key . '_h'}) {
                        $image->resize($request->{$key . '_w'}, $request->{$key . '_h'});
                    } elseif ($width > $request->{$key . '_w'}) {
                        $image->resize($request->{$key . '_w'}, null, function ($constraint) {
                            $constraint->aspectRatio();
                        });
                    } elseif ($height > $request->{$key . '_w'}) {
                        $image->resize(null, $request->{$key . '_h'}, function ($constraint) {
                            $constraint->aspectRatio();
                        });
                    }
                    $image->save(public_path('uploads') . '/' . $filename);
                    // Determine which request's data to use further
                    $requestDataToMerge = $newRequest == null ? $request->all() : $newRequest->all();
                    // Create new request without changing the original one (prevents removal of specific metadata which disables parsing of a second file)
                    $newRequest = new Request(array_merge($requestDataToMerge, [$key => $filename]));
                } else {
                    $filename = time() . '-' . $request->file($key)->getClientOriginalName();
                    $request->file($key)->move(public_path('uploads'), $filename);
                    // Determine which request's data to use further
                    $requestDataToMerge = $newRequest == null ? $request->all() : $newRequest->all();
                    // Create new request without changing the original one (prevents removal of specific metadata which disables parsing of a second file)
                    $newRequest = new Request(array_merge($requestDataToMerge, [$key => $filename]));
                }
            }
        }

        return $newRequest == null ? $request : $newRequest;
    }
}

@AlexMilutinovic thanks a lot, one of our team members will test and push the fix, probably next week.


Pull common test-related code out of core

This allows web and it to depend on core and a couple of new, small subprojects, instead of core's tests. This means slightly faster local builds and less hassle when things are in flux.
It will also allow other projects to make use of the Arbitrary instances and other utilities.
This brings us in line with how scala-pathy is organized, for example, and makes building web and it a bit more sane.
On the other hand, it involves moving all of the core test files, so will possibly cause some disruption.

What is the advantage of creating a core-tests project as opposed to leaving those tests in core?

Why is ConfigSpec in core-specs2?

The tests moved to a separate subproject because they need to depend on scalacheck and specs2, which in turn depend on core. It may be possible to make only the test configuration in core depend on those two projects; I didn't try that because I noticed that pathy was broken down in this way and figured I'd be consistent with that.
ConfigSpec had to go to a shared location because it is extended in both core-tests and web's tests (and perhaps also in quasar-advanced?) It's slightly awkward, but I think it's better than putting in one of the other projects or making yet another project for the one file.
One way to look at it is that scalacheck contains Arbitrarys and anything else that might be useful for somebody using some of the datatypes from core, whereas specs2 contains stuff that's really about us writing tests for core and web.

I understand. I think we can probably come up with a better name for the specs2 project. I might even argue that it could be folded into the scalacheck project and have that project be "test-utils" (find better name) as opposed to "test utils, but only for this one library scalacheck".

Especially considering there is a bunch of useful arbitraries in the specs2 sub-project currently.

You mean AlphaCharacters and AlphaAndSpecialCharacters? I would be fine with moving those to scalacheck. I do think there's probably some value in keeping the Arbitrary's separate, but I agree that the specs2 project is a bit of a catch-all and not all of it really relates to specs2. And I don't think core-test-utils is that bad of a name.
How about I rename core-specs2 to core-test-utils, move the string arbitraries to core-scalacheck somewhere, and call it a day?

Sorry for the late response, was gone to the gym. I'm okay with just renaming the specs2 project. although I would be curious for you to elaborate on that "some" value that having a scalacheck only sub-project provides (not because I don't believe you, just not obvious to me!).
Also, I would be okay with yet another project for the actual specs2 related stuff in the current specs2 sub-project because they seem to have nothing to do with quasar. Perhaps with a disclaimer suggesting we consider contributing back to specs2 proper.
I appreciate that you want to get this merged as soon as possible, so feel free to just rename the specs2 project, merge, and we can continue pointlessly splitting hairs after 😝

Current coverage is 52.70%

Merging #1164 into master will decrease coverage by -26.15% as of 9a1bc4d

@@            master   #1164   diff @@
======================================
  Files          164     209     +45
  Stmts         9072   13567   +4495
  Branches       261     315     +54
  Methods          0       0
======================================
- Hit           7154    7151      -3
  Partial          0       0
- Missed        1918    6416   +4498

Review entire Coverage Diff as of 9a1bc4d

Powered by Codecov. Updated on successful CI builds.

Just noticed the coverage hit and will resolve that before merging.

I didn't get anywhere with codecov, and I don't want to put more time into this now, so I'm closing the PR.
It won't be hard to repeat the exercise later on if we choose.


mac os tuning is out of date/ doesn't cover all releases

http://gatling.io/docs/2.0.0-RC2/general/operations.html
for mac
update is needed eg. per
https://unix.stackexchange.com/questions/108174/how-to-persist-ulimit-settings-in-osx-mavericks

Some more from the Basho people:
http://docs.basho.com/riak/latest/ops/tuning/open-files-limit/
http://docs.basho.com/riak/latest/ops/tuning/linux/

Happy New Year BTW :)
Glad to see you there, and only on the jClarity ML ;-)

Bonne année to you too!

We'll extract some parts of the Riak doc, give credit to them, and add a link to their doc. The stackexchange link is also an extract from them.


Restructure controller reconciliation loops to reduce the API server load and fix policy status update errors

This is a spin off of the issue #645. In that issue an user was complaining that the controller is doing too many requests to the API server. Specially regarding to the configmap resource. The controller is hitting the API server many times to get the configmap because all the reconciliation loops uses that information. However, this resource is not cached in the controller. Therefore, the first mitigation proposed in that issue was enable cache for the configmap resources. In the same issue another users reported that the controller is updating the policy status many times. This is also true. Because the reconciler waits for the policy server reconciliation to properly set the policy status. And every time policy server status is "not ready", it update the policy status and requeue a request to check again. Therefore, many request updating the policy status, even with the same status value, are sent.
Both issues, the many get requests for the configmaps and the many policy status updates has a common root. All are related to the way the reconciliation loops wait for each other and get/updates many resources in the process. Therefore, we should review how the 3 reconciler work together and try to simplify them reducing the amount of time the policy status are updated and how many times we fetch data from the API server.
Acceptance criteria

Investigate if we can simplify the reconcilers in the controller reducing the number of resources requested and policy status updates over time.
Simplify the controller reconciliation loops where is possible.

I've run the all the tests using the following command line to keep them running for a while until something wrong happens:
ginkgo -r  --randomize-all --randomize-suites --until-it-fails --race --trace -v --timeout 8h

After some time, I see this error that can be addressed on this issue as well:
 [FAILED] Expected success, but got an error:
      <*errors.StatusError | 0xc000e990e0>:
      Operation cannot be fulfilled on mutatingwebhookconfigurations.admissionregistration.k8s.io "namespaced-admission-policy-controller-test-mutating-policy-6it0ama1": the object has been modified; please apply your changes to the lates
t version and try again
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Operation cannot be fulfilled on mutatingwebhookconfigurations.admissionregistration.k8s.io \"namespaced-admission-policy-controller-test-mutating-policy-6it0ama1\": the object has been modified; please apply your
changes to the latest version and try again",
              Reason: "Conflict",
              Details: {
                  Name: "namespaced-admission-policy-controller-test-mutating-policy-6it0ama1",
                  Group: "admissionregistration.k8s.io",
                  Kind: "mutatingwebhookconfigurations",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
  In [It] at: /home/jvanz/SUSE/kubewarden-controller/controllers/admissionpolicy_controller_test.go:252 @ 05/28/24 21:

Which is similar to the error mentioned in this issue description:
  2024-05-07T18:14:15-03:00     ERROR   Reconciler error        {"controller": "admissionpolicy", "controllerGroup": "policies.kubewarden.io", "controllerKind": "AdmissionPolicy", "AdmissionPolicy": {"name":"validating-policy-yu57kw2a","n
amespace":"admission-policy-controller-test"}, "namespace": "admission-policy-controller-test", "name": "validating-policy-yu57kw2a", "reconcileID": "7a775ee2-1688-456a-976a-1a25340423af", "error": "update admission policy status error: O
peration cannot be fulfilled on admissionpolicies.policies.kubewarden.io \"validating-policy-yu57kw2a\": the object has been modified; please apply your changes to the latest version and try again"}


ppham's week 5 API server up to User auth into Postgres DB

This picked up too many strange changes, I'll start over and merge on another PR.


Revert "Bring in new toolkit with new input fields"

Reverts alphagov/digitalmarketplace-buyer-frontend#450
The functional tests are breaking and I can't figure out how exactly to fix them, so we're reverting the changes until I can get them to pass locally.

👍


Adding Image to stream image_in was not ok: INVALID_ARGUMENT: Graph has errors

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
None
OS Platform and Distribution
Web Chrome
MediaPipe Tasks SDK version
0.10.2
Task name (e.g. Image classification, Gesture recognition etc.)
Image classification
Programming Language and version (e.g. C++, Python, Java)
javascript using react
Describe the actual behavior
image and video switch.  i switch  video rendering, then  after switch to image it shows an error

Describe the expected behaviour
image and video switch to get rendering images

Standalone code/steps you may have used to try to get what you need
Other info / Complete Logs
vision_wasm_internal.js:9 E0731 03:52:53.371000 1813520 gl_graph_runner_internal_image.cc:68] Adding Image to stream image_in was not ok: INVALID_ARGUMENT: Graph has errors:
Packet timestamp mismatch on a calculator receiving from stream "norm_rect". Current minimum expected timestamp is<PHONE_NUMBER>763001 but received<PHONE_NUMBER>763000. Are you using a custom InputStreamHandler? Note that some InputStreamHandlers allow timestamps that are not strictly monotonically increasing. See for example the ImmediateInputStreamHandler class comment. [type.googleapis.com/mediapipe.StatusList='\n\xf5\x02\x08\x03\x12\xf0\x02Packet timestamp mismatch on a calculator receiving from stream \"norm_rect\". Current minimum expected timestamp is<PHONE_NUMBER>763001 but received<PHONE_NUMBER>763000. Are you using a custom InputStreamHandler? Note that some InputStreamHandlers allow timestamps that are not strictly monotonically increasing. See for example the ImmediateInputStreamHandler class comment.']
=== Source Location Trace: ===
third_party/mediapipe/framework/input_stream_manager.cc:139

vision_wasm_internal.js:9 E0731 03:52:53.372000 1813520 calculator_graph.cc:858] INVALID_ARGUMENT: CalculatorGraph::Run() failed in Run:
Packet timestamp mismatch on a calculator receiving from stream "norm_rect". Current minimum expected timestamp is<PHONE_NUMBER>763001 but received<PHONE_NUMBER>763000. Are you using a custom InputStreamHandler? Note that some InputStreamHandlers allow timestamps that are not strictly monotonically increasing. See for example the ImmediateInputStreamHandler class comment. [type.googleapis.com/mediapipe.StatusList='\n\xf5\x02\x08\x03\x12\xf0\x02Packet timestamp mismatch on a calculator receiving from stream \"norm_rect\". Current minimum expected timestamp is<PHONE_NUMBER>763001 but received<PHONE_NUMBER>763000. Are you using a custom InputStreamHandler? Note that some InputStreamHandlers allow timestamps that are not strictly monotonically increasing. See for example the ImmediateInputStreamHandler class comment.']
=== Source Location Trace: ===
third_party/mediapipe/framework/input_stream_manager.cc:139

@DevaPandiyan,
Could you please elaborate your query with complete details? Also Please provide complete steps following from the documentation to reproduce the issue from our end. Thank you!

Im Using with camera and Image when im switch to video to image that was not Detect  it s showing error
Code :
const faceLandmarkerResult =  await face_landmarker.detect(img);
          onResultImage(faceLandmarkerResult,img)

const faceLandmarkerResult =  await face_landmarker.detect(img);
onResultImage(faceLandmarkerResult,img)
const switchMode=async ()=>{
console.log("swith to  :", runningMod);
(runningMod === "IMAGE")? runningMod ="VIDEO":runningMod="IMAGE";
//   (runningMod === "IMAGE")? SetRunningMode("VIDEO"):SetRunningMode("VIDEO");
SetRunningMode(runningMod);
SetRunningMode(runningMod);
if(runningModes=="IMAGE"){
console.log("runningif :", runningMod);

}else{
console.log("runningels :", runningMod);
}
console.log("running after :", runningMod);
await face_landmarker.setOptions({ runningMode:runningMod });
if(runningMod!=="VIDEO"){
stremVideoStop();
}else{

}

runningSetup();

}
Error:
vision_wasm_internal.js:9 E0731 03:52:53.371000 1813520 gl_graph_runner_internal_image.cc:68] Adding Image to stream image_in was not ok: INVALID_ARGUMENT: Graph has errors:
Packet timestamp mismatch on a calculator receiving from stream "norm_rect". Current minimum expected timestamp is<PHONE_NUMBER>763001 but received<PHONE_NUMBER>763000. Are you using a custom InputStreamHandler? Note that some InputStreamHandlers allow timestamps that are not strictly monotonically increasing. See for example the ImmediateInputStreamHandler class comment. [type.googleapis.com/mediapipe.StatusList='\n\xf5\x02\x08\x03\x12\xf0\x02Packet timestamp mismatch on a calculator receiving from stream "norm_rect". Current minimum expected timestamp is<PHONE_NUMBER>763001 but received<PHONE_NUMBER>763000. Are you using a custom InputStreamHandler? Note that some InputStreamHandlers allow timestamps that are not strictly monotonically increasing. See for example the ImmediateInputStreamHandler class comment.']
=== Source Location Trace: ===
third_party/mediapipe/framework/input_stream_manager.cc:139

Are you using "video" mode at all or does this issue occur with just "image" mode?

I reported a similar issue (#4769) and after switching to runningMode=IMAGE, I no longer see these errors.

Yeah i fixed it


Progressbar doesn't work rendering circle graph initially

Hi,
Has there been any solutions to the issue we have been facing regarding graph rendering in IE and Edge.
I found when it is first loaded on page it gives irregular graph and then when we comeback after visiting other pages it works fine. It is quite amazing to see such things. Have we got any solution to this on first visit of the page to be regular graph as wanted.
I read like strokeWidth>7 works. But I found it is working fine when like i said above, besides, the problem is only when it is loaded at the first time when we visit the page.

Unfortunately there hasn't been any solution to https://github.com/kimmobrunfeldt/progressbar.js/issues/79 that I know of yet.
Sorry, I didn't quite get the other parts of your issue description. I'm closing this issue, and let's continue the IE issue at #79.


Generates memes from local images

I missed being able to simply give memegen an image path and have it generate the meme for me. This patch solves this.

any news for this?


Loading images on refresh

Hi! When I refresh the page the images are not loading until I scroll a bit up or down.  Have you any idea what could be causing this problem?
Regards

Hello @vonPiernik,
thank you for reporting this issue.
In order to be able to resolve this, I need more information in order to reproduce the bug.

Which version of LazyLoad are you using?
In which browser and browser version are you experiencing the problem?
Could you provide the HTML, CSS and JS code you use for your images?
What are the steps to reproduce the problem?

Please answer these questions, it'll really help me understand what's happening.
Thanks

@vonPiernik you there? Are you still experiencing this issue?

skip_invisible : false will solve the issue.

Thanks @niresh12495, but this is not the recommended solution. The skip_invisible option is there for another reason. I want to investigate and understand why this happens. Is that because the images are initially invisible?

Hi, sorry for the delay. I'm using skip_invisible because I have tabs with images, so this is only way to make this tabs working, aye?
My version of lazy is the latest version I think, downloaded maybe a week ago. Chrome 57.0.2987.133 (64-bit).
My code here: https://pastebin.com/wh6qn4G6
I know it's mess, combination of wordpress gallery and data tables and lightbox plugin ;D But it's a messy site. It's hard to reproduce the problem I think, now I know that my website could be a problem, but It's complicated :p

Ok i found out that http://azaliowe.pl this is your website, i have checked few image elements all the image are referenced to src not data-src
You are using lazyload wrong
Here is a website where you can check lazyloading of verlok
https://www.guest.blog/2427/benefits-of-drinking-alcohol/

I'm a bit stupid ;D This website must working so lazy is currently disabled and I give you code from living website, sorry for that. When I tried to use lazy the data-src was set up and it worked fine except when i refreshed without scrolling.

Sorry for the delay. I'll check.

@vonPiernik you reported only the HTML code in your previous comment. Can you also give me the JavaScript code that you're using, and more information about how you load the script (in the header, in the footer, with or without the async attribute)?
By the way, have you read the new recipes and guide I've created on the new LazyLoad website?

@vonPiernik I'm closing it , if you still experience the issue please provide more information


Importing optax after jax causes training value differences

I have a program that I have written and been testing locally on MacOS. However, when I uploaded this to the github CI using Ubuntu to run the test cases, they were failing, giving different results for various test-cases that I had defined.
I played around extensively and noticed that this was only happening when I imported optax AFTER jax on Ubuntu (This didn't affect things on MacOS). After re-ordering the imports so that optax was first, everything worked fine on both platforms.
This wasn't with all operations, but specifically related to a model that used matrix multiplications. I am not sure that this was the exact cause, but that is the only difference I can think of. I can't seem to narrow this bug down any further at the moment.

I've made sure to seed both numpy and jax, and set deterministic flags.
I even set the following flags after importing jax and optax, which didn't help

jax.config.update("jax_default_device", jax.devices("cpu")[0])
jax.config.update("jax_platform_name", "cpu")
jax.config.update("jax_log_compiles", True)
jax.config.update("jax_numpy_rank_promotion", "warn")
jax.config.update("jax_numpy_dtype_promotion", "standard")
jax.config.update("jax_default_matmul_precision", "float32")
jax.config.update("jax_default_prng_impl", "threefry2x32")

The jax JIT was being used over all ops.
This was occurring on:

jax==0.4.13
optax==0.1.7
numpy==1.26.0

I also needed to set JAX_ENABLE_X64=true
Gradients were being computed through all the math.

Thanks for the report @nmichlo , it would be very useful if you can provide a reproducible test for this failure

@fabianp I'll try and narrow it down further, but I haven't had much luck yet. Its quite a complex code path unfortunately, difficult to pinpoint the exact issue because while the results aren't exact, they are still approximately correct.

It does import jax in a number of places but I don't think it changes the config of jax (at least I couldn't find anything like this in the code from master)

Thank you for the context.
Unfortunately I can't share the code I am using, but will keep an eye out and try eventually share a reproducible version

sounds good. please reopen the issue when you've got an example


Remove hard dependency on healpy

Healpy is only used as a lazy-import in one of the flight plan quicklook functions. This PR removes it from the list of hard dependencies to possibly allow an installation for Windows users (see #57)

Does this really remove the healpy dependency, or would we still pull it in through easygems?

Fair point... so I guess we would either do the same for easygems too, or explicitly state that our packages are only available on Linux/MacOS

And one thing we might want to consider is to have some form of optional dependency, such that people could install e.g. orchestra[forecast] to include forecast products, or orcestra[healpix] or orcestra[all] ?

Yes, I had thought about moving them to the test dependencies. I don't have a strong opinion for the name, but a slight preference for orcestra[all] to not over-engineer from the start

I'd be happy with orcestra[all].
For easygems, I fear that the package isn't very useful without healpix. So probably people would be annoyed if we'd remove the healpy dependency from easygems.
But as far as I see, we only use easygems in pyorcestra in those cases where we also want to use healpix. So we might just move the entire easygems to the same optional dependencies as healpy.
Remains to question if this would be of great use... I guess about all of the flight plans in the orcestra book make use of forecast data, which would be impossible without the healpy dependency...

Yes, I agree that most of our packages are pretty useless without HEALPix support these days. It seems that if we want to include Windows users, replacing the backend is the only feasible way.

I will close this PR. We can keep issue #57 open for reference.


Mobile: middle card face the wrong way

Hello.
First of all, thank you for this beautiful little app. I love playing it againsta  bot on occasion and it's great to show a friend with the local multiplayer.
I found this issue on mobile (aka, when the screen size is too small to have the middle card beside the board). In this case, the middle card is placed in the opponent's zone but still in the opponent's orientation. This messes me up often because I have to rotate the card in my head to find out what my hand will be next round. I was able to test this on desktop just by icreasing the zoom level until the layout changes, you can see the middle card flip from my own orientation to the opponent's.

I highly suspect the coding to put the card in the opponent's orientation when it is in the opponent's zone. So I see two ways to fix the issue.
A: Code a way to flip the middle card in the opponent's zone
OR
B: Move the middle card to the player's zone and identify it as unusable for this turn (greyed out?).
I have zero experience in the languages used in this repo, so I apologize for not offering a pull request instead of an issue ticket. Hopefully it is a simple fix for you. Cheers!

Very good point, that does look really confusing.
I've chosen to go with A, and have flipped it in the opponents zone, and have also added a caption to show it's been played

Thanks for pointing this out :grin:

Looks great. Thank you, my friend!


"Average Time Per Day" actually counts average time per session

"Average Time Per Day" in the game details actually seems to calculate the average time per session. I'm not sure whether it's mislabelled or whether the code was taken with the assumption that there'd be only one session per day, so fix however you feel best.
Thanks :)

Here's a screenshot. Since there's only one day, the average time would actually be the cumulative of the two sessions.


Question: Using where filter it.Contains(@0) fails where it.Contains("keep") works

Hi,
Trying to create a fairly long filter expression so tried extracting the parameter in to the parameter list.  But found that the following does not work:
List<string> testList = new List<string> {
	"something I want to filter",
	"something I want to keep"
};

var expected = testList.Where(lst => lst.Contains("keep"));
var result = testList.AsQueryable().Where("it.Contains(@0)", new List<string> { "keep"});

result.ShouldBe(expected);

Error "No applicable method 'Contains' exists in type 'String'"
Whereas the following does works fine:
List<string> testList = new List<string> {
	"something I want to filter",
	"something I want to keep"
};

var expected = testList.Where(lst => lst.Contains("keep"));
var result = testList.AsQueryable().Where("it.Contains(\"keep\")");

result.ShouldBe(expected);

Hello @IainmXray ,
The code should be:
var result = testList.AsQueryable().Where("it.Contains(@0)", "keep");

It should be
var result = testList.AsQueryable().Where("it.Contains(@0)", "keep");

close?

Sorry for the delay in replying.  Whilst this solution works for a query with one parameter it does not work for multiple parameters where you are building the set up dynamically and want to pass the params as an array.  Sorry I should have made that explicit in the query

Can't you just switch the code?
Like
var result = testList.AsQueryable().Where("@0.Contains(it)", new List<string> { "a", "b" });

Hi,when i take where method with contains used in generic type query，it can not work.
Just help me ,thanks.

@gouhan Please provide full example.

@StefH ,thanks
The detail code see below:

I find the exception reason is the "paramList" type,it's type is not explicit.
but,I need the query parameter composed by dynamically.

@gouhan
For my example, it works fine. See https://dotnetfiddle.net/bTkPJ2
using System;
using System.Linq;
using System.Linq.Dynamic.Core;

public class Program
{
	public static void Main()
	{
		var q = new [] { new User { Id = 1, Name = "test" }, new User { Id = 2, Name = "test2" } }.AsQueryable();

		var parameters = new object[] { 1, "test2" }; // var parameters = new dynamic[] { 1, "test2" };  --> also works

		var results = q.Where<User>("Id = @0 or Name = @1", parameters);
		foreach (var result in results)
		{
			Console.WriteLine("-> " + result.Id + "_"  + result.Name);
		}
	}
}

public class User
{
	public int Id {get;set;}
	public string Name {get;set;}
}

@StefH ，very thanks，I tried much more test with your demo code using generic type.where the unit test works fine.
I find the reason,that is the missing with builded sql,phrase is error.

(@0.Contains(1)) Or (@1.Contains(1)) I replace the 1 character with real fieldName ,it works.

it works

@StefH ，now I have another question,help me again

First results: var results = q.Where(expression);
Second : results = q.Where(o => o.Name == "test");
the two condition normally used And operation,But i want it works by OR opration.
How can i do?
if not using the linq core phrase, eg:using lambda expression，how can it works with linq core phrase together?

If you want an OR for all the 3 conditions, you need to use dynamic linq all the way.
var results = q.Where("Name=\"test\" OR @0.Contains(1) OR @1.Contains(1)", new [] { 1, 2 });

@StefH ,thanks.

Closing

How can we use ColumnName.Contains(list of the array)?
I have tried the below code but did not work:
List<Customer> customers = new List<Customer>()
		 {
			 new Customer() { CustomerID = 1, Name = "Terri	Lee	Duffy"},
			 new Customer() { CustomerID = 2, Name = "Gail A Erickson"},
			 new Customer() { CustomerID = 3, Name = "Gigi N Matthew"},
			 new Customer() { CustomerID = 4, Name = "Michael Raheem"},
			 new Customer() { CustomerID = 5, Name = "Janice Galvin"},
			 new Customer() { CustomerID = 6, Name = "Michael Sullivan"},
			 new Customer() { CustomerID = 7, Name = "David Bradley"},
			 new Customer() { CustomerID = 8, Name = "David	Benshoof"},
			 new Customer() { CustomerID = 9, Name = "Peter	Gilbert"},
			 new Customer() { CustomerID = 10, Name = "Rebecca Bradley"},
		 };

		List<string> strlist = new List<string>(){"osman","ali","Janice Galvin"};
		var list = customers.AsQueryable()
			//.OrderBy("Name")
			.Where("Name.Contains(@0)", new List<string>{"osm",{"Dav"}})
			.ToList();


remove deprecated flannel role

fixes #1614.
removes unused network var from k8s configuration.
untested, waiting on ci build.

[x] Installs cleanly on a fresh build of most recent master branch
[x] Upgrades cleanly from the most recent release
[x] Updates documentation relevant to the changes

Still untested?

Just tested on gce. Looks good.


Error: promisedComputed must be used inside reactions

Running into a similar error as others (https://github.com/danielearwicker/computed-async-mobx/issues/19) but can't figure out why.
My store has a substore 'data' which is making use of asyncComputed:
//inside data store
@computed get concepts() {
   return this.fetchedConcepts.get()
 }
 fetchedConcepts = asyncComputed([], 0, async () => {
     return await getConcepts({ dataset }) // a promise
 })

The store is then used by a component:
const store = useExplorerStore()

<MyComponent data={store} />

The store is working apart from the store.data properties which are using asyncComputed.
Any hints appreciated 🙏

I've seen reports of this error when using a mix of versions. I don't see it in testing when I use the latest versions. Right now that's:
"computed-async-mobx": "^4.1.1",
"mobx": "^5.13.0",
"mobx-react": "^6.1.3",
"mobx-utils": "^5.4.1"

Hope this helps!

this didn't work for, I still have the same issue


Improve combiner startup log

When starting a combiner, the last line printed on the command lines is still "starting the combiner", which is confusing: if it is completed or not -- maybe some words could be added to indicate that the combiner has successfully initialized.

Thanks Li, now  in develop, so will be in next release.


Faq Sections in the center

This PR resolves the issue #3233 that the Sections-Tittel not find in the center and its resolved by switching "body-text-align" with the position "center".

@MohamedZaghdoudi

This change moves all FAQ content to be centered 🙁

Also it is mixed up with the addition of a Backup section.


Update Automagic

This shouldn't conflict with #3344, and I don't believe it's redundant with that either.

Lines 239 and 243 kind of are, since those lines shouldn't be executed in "my version" if target is null.

Yeah, I see that now. Yours looks like a better implementation, anyway.


Want to update README.md and also want to add CODE_OF_CONDUCT.md

I want to add code of conduct file and also want to update main readme.md file by adding  How to contribute section and also adding contributors profiles
can I do this please?

@sb-decoder We already have a CONTRIBUTING.MD file here: https://github.com/alpstable/gidari/blob/main/docs/CONTRIBUTING.md
What would go in CODE_OF_CONDUCT.md?


[DRAFT] [SPIKE] Use hotwire for work form validation

Note that installation requires the asset pipeline, which requires the sprockets railtie. Why not just install via yarn and rely on webpacker? We could, but then we would not get any of the hotwire helpers that come from installing via the hotwire-rails gem, e.g., broadcasts_to, turbo_frame_tag, turbo_stream_action_tag.
Note as well that we should ultimately be able to replace remote forms entirely with the hotwire approach, hence the new TODO and commented-out configuration option in config/application.rb.
Connects to #786
Why was this change made?
To experiment with using hotwire to improve H2 form validation, in terms of user experience and developer understanding.
How was this change tested?
CI
Which documentation and/or configurations were updated?
None

Closing. See rationale: https://github.com/sul-dlss/happy-heron/issues/786#issuecomment-759052241

Closing. See rationale: https://github.com/sul-dlss/happy-heron/issues/786#issuecomment-759052241


fixes the bug #1542 :-Input is not getting empty on click of side bar

fix : #1542

[ ] My code adheres to the established style guidelines of the project.
[ ] I have included comments in areas that may be difficult to understand.
[ ] My changes have not introduced any new warnings.
[ ] I have conducted a self-review of my code.

Attach a screen recording that demonstrates the changes you made to the code, showing how it affects the application across all media widths.Also resolve the conflicts

@SWASTI-SUNDAR, the issue is not assigned to you, and it has already been taken care of.


Running oom with more than num_steps=1

Hello!
First of all, thanks for your work.
I got a problem with training the bot.
I've got a dataset of ~150k lines and already made slimmed it down to 2500.
Every time I set the "num_steps" higher than 1 my GPU runs out of memory.
It's a Vega64 with 8GB of RAM running rocm (5.4.3) on Ubuntu with pytorch version 2.1.0a0+gitefc3887. Batch_size is also set at 2. Anything higher also results in oom.
Is the dataset just too big or could there be another problem?
Thanks very much in advance for any help! Also let me know if you need additional info!

Just tried it with a GTX1060 6G that I had lying around, still the same error. Cuda 11.7 and driver version 515. Pytorch is the version for Cuda 11.7.

System memory is 64GB.
Did your dataset also contain emojis? Maybe that's a problem?
Everything else on my PC looks fine, it just really quickly fills up the VRAM and then it just errors out.

 Might be messing with system installations of other libraries or whatever.

Still running OOM, even using only num_steps=1. Last thing I could think of now, is that I am using a different python version in my conda env. Installed everything that you had (plus mkl==2021.1.1 because it was needed). So I am not sure what is causing these problems for me.
Here is the full error message I get:
Traceback (most recent call last):   File "/home/slb/Desktop/Gravital-master/main.py", line 57, in <module>     main()   File "/home/slb/Desktop/Gravital-master/main.py", line 36, in main     ai.train("dataset.txt",   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/aitextgen/aitextgen.py", line 752, in train     trainer.fit(train_model)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 460, in fit     self._run(model)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 758, in _run     self.dispatch()   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 799, in dispatch     self.accelerator.start_training(self)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/accelerators/accelerator.py", line 96, in start_training     self.training_type_plugin.start_training(trainer)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 144, in start_training     self._results = trainer.run_stage()   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 809, in run_stage     return self.run_train()   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 871, in run_train     self.train_loop.run_training_epoch()   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/training_loop.py", line 499, in run_training_epoch     batch_output = self.run_training_batch(batch, batch_idx, dataloader_idx)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/training_loop.py", line 738, in run_training_batch     self.optimizer_step(optimizer, opt_idx, batch_idx, train_step_and_backward_closure)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/training_loop.py", line 434, in optimizer_step     model_ref.optimizer_step(   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/core/lightning.py", line 1403, in optimizer_step     optimizer.step(closure=optimizer_closure)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/core/optimizer.py", line 214, in step     self.__optimizer_step(*args, closure=closure, profiler_name=profiler_name, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/core/optimizer.py", line 134, in __optimizer_step     trainer.accelerator.optimizer_step(optimizer, self._optimizer_idx, lambda_closure=closure, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/accelerators/accelerator.py", line 325, in optimizer_step     make_optimizer_step = self.precision_plugin.pre_optimizer_step(   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/plugins/precision/native_amp.py", line 93, in pre_optimizer_step     result = lambda_closure()   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/training_loop.py", line 732, in train_step_and_backward_closure     result = self.training_step_and_backward(   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/training_loop.py", line 823, in training_step_and_backward     result = self.training_step(split_batch, batch_idx, opt_idx, hiddens)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/trainer/training_loop.py", line 290, in training_step     training_step_output = self.trainer.accelerator.training_step(args)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/accelerators/accelerator.py", line 204, in training_step     return self.training_type_plugin.training_step(*args)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 155, in training_step     return self.lightning_module.training_step(*args, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/aitextgen/train.py", line 35, in training_step     outputs = self({"input_ids": batch, "labels": batch})   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/aitextgen/train.py", line 32, in forward     return self.model(**inputs, return_dict=False)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 943, in forward     transformer_outputs = self.transformer(   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 791, in forward     outputs = block(   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 317, in forward     attn_outputs = self.attn(   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 258, in forward     attn_output, attn_weights = self._attn(query, key, value, attention_mask, head_mask)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 194, in _attn     attn_weights = self.attn_dropout(attn_weights)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl     return forward_call(*input, **kwargs)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/modules/dropout.py", line 58, in forward     return F.dropout(input, self.p, self.training, self.inplace)   File "/home/slb/miniconda3/envs/aibot/lib/python3.9/site-packages/torch/nn/functional.py", line 1169, in dropout     return _VF.dropout_(input, p, training) if inplace else _VF.dropout(input, p, training) RuntimeError: CUDA out of memory. Tried to allocate 96.00 MiB (GPU 0; 5.93 GiB total capacity; 4.63 GiB already allocated; 79.25 MiB free; 4.67 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF   0%|          | 0/1 [00:00<?, ?it/s]

Ok, I solved it. Seems like a problem with the used block_size.
If I use aitextgen directly, with their test script and use it with my training data and the same model, it works.
Maybe it would be a good idea to mention that people can change it if they have problems?


aws.ecs - tagging

ECS now supports tags: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs.html#ECS.Client.tag_resource
Currently all clusters can be tagged, tasks/services/container-instances can only be tagged if they're opted into the new arn format

additional context on ecs arn, its differential on arn for at least a year due to the migration period https://aws.amazon.com/blogs/compute/migrating-your-amazon-ecs-deployment-to-the-new-arn-and-resource-id-format-2/

went ahead and did everything but task-definition which unfortunately is a bigger stretch as it will require a bit more refactoring due to how ecs tags were exposed. i'll leave this open for now, as we'll still need to add tag actions.


Integrate TensorBoard in submit-job-v2 plugin with external storage

Integrate TensorBoard in submit-job-v2 plugin with external storage.
TensorBoard config will be stored on the extra filed of protocol as the new design.
New Feature

support NFS and HDFS;
preview TensorBoard config changes in real time;

Bug Fix

Jobs can be correctly cloned from job-detail page.

Coverage decreased (-0.01%) to 53.843% when pulling 5c46339e658ad7b1cba85b60b206e5c1ea9a18bf on tozh/tensorboard-nas into 764fcf238c0144536834a360a19b98b64fcf8cd8 on master.

#3147

#3156

Fixes #3147