Do not wait for active docker nodes

Docker nodes are often spun up as needed, so waiting for one to
become active will result in us waiting forever.
Signed-off-by: Adam Farley<EMAIL_ADDRESS>

Creating this PR with the expectation that it will not be merged until after the October 2020 release.

@ShelleyLambert your call to land this or not

I do not actually think this PR is required, given default of ACTIVE_NODE_TIMEOUT is zero (and we do not intend to change the default) and DOCKER_REQUIRED does not mean spin up a docker container to run tests in (which we have not yet added as a 'feature').
DOCKER_REQUIRED is appended to the overall LABEL to find machines to run external test group on (example: to then look for an online machine labelled 'ci.role.test&&hw.arch.x86&&sw.os.linux&&sw.tool.docker').

@ShelleyLambert - Unfortunately, active node timeout of 0 doesn't mean we don't check for a node. It means that if we fail to find an active node that meets our needs, we wait 0 seconds before running this:
assert false : "Cannot find any machine that matches the LABEL: " + LABEL

And my intention with the dual-prong docker check (which I could have done a clearer job explaining, I admit) was to try and cover all possibilities (e.g. a user using a docker label but failing to tick the box, and the box being ticked but the labekl's add-on not being added on for some reason).
If you feel that's over-complicating things, I'm content to remove the DOCKER_REQUIRED check, as the label should be in its final form by the queue stage.

re: https://github.com/AdoptOpenJDK/openjdk-tests/pull/2022#issuecomment-712266394 I am well aware.
As I have stated on numerous occasions, that is how we have been doing things for almost 2 months now (without https://github.com/AdoptOpenJDK/openjdk-tests/pull/2012).  The code that asserts and test pipeline exits if no machine online with a label that matches. This approach has so far, worked without incident.  We have not seen a case where a timeout is needed (that a machine may be moments away from being online... the typical use case is that someone has provided an incorrect label and the right thing to do is exit immediately).
However, it was proposed that there could somewhere be environments where machines go on and offline, that a few minute wait may buffer us from.  No one to date has pointed me at examples to these environments, or measured what amount of wait time will work in those environments.  So we have solved for a problem that may or may not exist.  What we may have done with these changes is created a condition where dev teams will complain that testing takes too long and off-loaded handling of infra instability into test scripts, instead of stabilizing the infra layer.  But here we are.
Yes, preference to have clean, clear, uncomplicated code, as it will be easier to maintain.

Also, re: https://github.com/AdoptOpenJDK/openjdk-tests/pull/2022#issue-505916607

waiting for one to become active will result in us waiting forever

I do not believe that is true, we will either not wait at all, or wait the amount of time set by ACTIVE_NODE_TIMEOUT

I do not believe that is true, we will either not wait at all, or wait the amount of time set by ACTIVE_NODE_TIMEOUT

True. Thanks for catching the mistake. Will correct the commit message.
As for your other comment, you are quite correct. If docker nodes haven't caused failures by now, we likely won't see it prior to the release.
Will retract the PR to clear the PR list, and hold off until after the release.


add error in modal if user navigates (via url) to a page that gives an error

e.g. /people/details/{person.id}/equipment/details/{id that does not exist or is not assigned to user}
or just /equipment/details/{equipment id that does not exist}

Shouldn't that go to our error page instead of a modal?

i was just picturing an error within the modals, currently nothing renders

How about a toast for that?

yeah, i'm good with that


Is STR (stream flow package) supported currently?

I have a STR package in the model. I have tried to include a multiplier for str.con by the following code.
bc_props = []
bc_props.append(["str.cond",0])
mfp_boss = pyemu.helpers.PstFromFlopyModel(model=m,new_model_ws=new_model_ws,org_model_ws=temp_model_ws,mflist_waterbudget=False, pp_props=pp_props,  obssim_smp_pairs = obssim_smp_pairs, zone_props=zone_props,                                           **spatial_list_props=bc_props,**                                          remove_existing=True,pp_space=5,par_bounds_dict = {"hk":[0.01,100.0]})
I got the following error when I run it. It seems like PyEMU doesn't rewrite the STR file as it does for other packages, such as WEL and RCH.
FileNotFoundError: [Errno 2] No such file or directory: 'template\.\STR_0000.dat'

Does STR use the same flopy mflist type to store list directed input?  If so, then it could work.  But some of those more advanced packages use “special” input formats so STR may not follow the structure pyemu is expecting.


CacheRead: catch and invalidate an asset with invalid negative cache_seek bytes value.

One of our delivery services has all of its assets under 2.7MB.  Some clients range request into the asset and we use the background_fetch plugin to handle these.  While
testing a different way of handling these assets we found occasional oversized single fragment assets that returned bad data ONLY when the range request start is beyond normal 1048576 byte sized fragment would be. Invalidating and repulling the asset would fix it for range request use.
This patch detects that condition, tags the cache entry as corrupt and deletes it from the cache directory, resulting in a TCP_SWAPFAIL_MISS then a refetch of the asset.
I tested this by simulating a thundering herd against a single asset, then forcing the fail condition when a range request is made.  Each range request resulted in a swapfail and any normal requests threads in process of fetching cache blocks would swapfail as well.  A TCP_MISS would follow by continued TCP_(MEM)_HITs.
This only checks for a condition that should never happen and is of limited impact.

Looks reasonable. But have some questions:

Why these assets can be oversized ?

Can you re-produce it into test ?
Does it relate to #5929 ?

Looks reasonable. But have some questions:

Why these assets can be oversized ?

Can you re-produce it into test ?
Does it relate to #5929 ?

No I haven't been able to reproduce it in a test environment.  Only seen so far on our mids running ats7 (that's what we have deployed there).  I was able to very quickly flip on full debug with cache and http and look at examples on different machines.
I can only speculate that these fragments oversize because of slow spinning disks and congestion.  However I tried to simulate these conditions and that didn't work.  The only way to consistently oversize fragments was to force it in code in CacheWrite.cc in openWriteMain by hard setting not_writing to true.  All assets i checked were always single fragment.

Could you please print fragment table in https://github.com/apache/trafficserver/blob/2bc253f6f8b4bcf325a87c5dbc4619a9d07d1a91/iocore/cache/CacheRead.cc#L711-L713

An original log with cache debug was this:
[Feb 20 18:30:40.782] Server {0x2b028f250700} DEBUG: <CacheRead.cc:634 (openReadMain)> (cache_seek) Seek @ 2000000 in DEC187425A8BE98FAAFD87ED1A29A4FD from #0 @ 72/1048576:D2AD9D2D9FAB32D8D3A5E01C84BE6904
[Feb 20 18:30:40.782] Server {0x2b028f250700} DEBUG: <CacheRead.cc:694 (openReadMain)> (cache_seek) Read # 0 @ 2000072/1048576 for -951496

[Mar 12 13:10:13.526] [ET_NET 20] WARNING: cache_seek range request bug: read CFF595E6D9F55ABE49A2DCF375D841AD targ BA3BC8EF46B808676F5FB89ABC1A88BD - multi frag # 1 @ 951568/1048576 for -100 tot 2133778 url: http://localhost:8080/~p.tex/~s.2183332/~ui.2000/a

As you can see. This object has multi-fragments, which means these assets have fragments table which can be sought for data offsets.
In your case. IIUC, the fragments table has wrong offsets which lead to negative bytes (in your change).
So my concern is :  What happen if some one ask for these ill assets in correct range(bytes is positive) before the request which can trigger negative bytes and delete the assets. Does the first request get correctly data ?

[Mar 12 13:10:13.526] [ET_NET 20] WARNING: cache_seek range request bug: read CFF595E6D9F55ABE49A2DCF375D841AD targ BA3BC8EF46B808676F5FB89ABC1A88BD - multi frag # 1 @ 951568/1048576 for -100 tot 2133778 url: http://localhost:8080/~p.tex/~s.2183332/~ui.2000/a

As you can see. This object has multi-fragments, which means these assets have fragments table which can be sought for data offsets.
In your case. IIUC, the fragments table has wrong offsets which lead to negative bytes (in your change).
So my concern is : What happen if some one ask for these ill assets in correct range(bytes is positive) before the request which can trigger negative bytes and delete the assets. Does the first request get correct data ?

Yes a full asset request or range start that begins before the fragment gets the correct data.  The incorrect data is actually a shifted version of what's in the real asset.
I updated the patch to print out the previous fragment size if fragment and frags.

Yes a full asset request or range start that begins before the fragment gets the correct data. The incorrect data is actually a shifted version of what's in the real asset.

Sorry for nitpick. Why we can get correct data even if fragment table is wrong ? IIUC, fragment are not fixed size. That means we can have the fragments offsets which are not actually document size in disk. See here https://github.com/apache/trafficserver/blob/134fb609351c16656089d68a550f41c280d05c2d/iocore/cache/CacheWrite.cc#L1425-L1430
So it is would be better if we can add ink_assert to your change for further debugging but not hiding it.

You can see here
https://github.com/apache/trafficserver/blob/master/iocore/cache/CacheWrite.cc#L1425
that if the pending data is at most 1.25 fragments long, exactly a fragment is written, but otherwise a fragment can be up to MAX_FRAG_SIZE long
https://github.com/apache/trafficserver/blob/master/iocore/cache/P_CacheVol.h#L45
which is just under 4M
https://github.com/apache/trafficserver/blob/master/iocore/cache/P_CacheVol.h#L39

This patch overreaches which triggered a regression test failure (for some reason not in the open source jenkins).  It could be related:
https://github.com/apache/trafficserver/issues/6562

I don't see how this will work in practice. Given the description of the underlying problemThis code is only triggered if there is a fragment table (see CacheRead.cc:665) but the problem is non-HTTP objects don't have a fragment table, therefore the code doesn't execute in the case where it is actually needed.
Because of the way the fragment hash chaining works, the fragment search must always be linear along the fragment table, and therefore the logic looks at the offsets to get the correct fragment. Unless the fragment offsets are being stored incorrectly, I don't see how this check can ever go off.

Over sized fragments for HTTP assets should not be a problem - because of how the hash chaining works, the fragment table must always be linearly searched. The fragment table has the fragment
offsets stored therefore the search should always yield the correct fragment, even if all the fragments are different sizes. Presuming, of course, the fragment offsets were stored correctly during the cache write. For non-HTTP, there's no fragment table which means this could happen in that case.

I limited this check to only look at HTTP fragments, thus avoiding the non HTTP (and CacheTest) issue entirely.  Tested this by hand and also by hard setting a negative bytes value in CacheRead::openReadMain.  Ran this with a simulated thundering herd to make sure swapfail hits and does force refetch of asset.  Added a new function to CacheVC to safely grab the mutex in order to invalidate the cache directory entry.

Cherry-picked to v9.0.x branch.


Options for Cassandra version and memory

It would be great if there was an option which let you pick a specific version of Cassandra. Also if there was a way to specify how much memory should be used; ~4GB is way too big for a development environment, especially on a laptop.

Picking versions will probably remain in docker tags, e.g. docker pull tobert/cassandra:2.0.13 (which I need to publish).
I will look into adding an option to set the heap size on the first start. I removed it initially but just the other day I needed to do the start/edit/restart cycle and that was annoying.

Okay, I see the multiple cassandra versions in the [Docker registry] (https://registry.hub.docker.com/u/tobert/cassandra/tags/manage/). Cool. Will you be keeping the images up-to-date w/ new config options then? My team specifically uses Cassandra 2.0.11 in production, so we want that for dev boxes as well.
Looking forward for the memory options; we're currently using sed to rewrite the memory requirements.

Yeah, I'll roll a new 2.0 image with the changes. I'm testing the changes to add -heap and -new now.

+1 @allan-stewart for the memory stuff. thanks @tobert awesome image :)

Seems to be working OK on my machine. Please test and let me know. I've pushed an image to the tag tobert/cassandra:213memflags

@tobert i'm pretty new to using dockers can you provide a full example of using the -heap/-new args?

@joshblum I'll add something to the README soon. I started my most recent cluster thus:
$ docker run --net=host -v /data -d tobert/cassandra:2.1.3 -heap 2048 -new 256 -seeds <IP_ADDRESS> -name "My Cluster"
$ ps -efwww |grep java
datastax  26538    241 66 22:12 ?        00:00:09 /usr/bin/java -ea -javaagent:/opt/cassandra/lib/jamm-0.3.0.jar -XX:+CMSClassUnloadingEnabled -XX:+UseThreadPriorities -XX:ThreadPriorityPolicy=42 -Xmx2048M -Xms2048M -Xmn512M

Note: only the 2.1.3 and 2.0.13 tags have the changes at the moment. I'll bump latest once I test it a little more as there are other changes to the entrypoint.

Oh, hey look at that. My -new didn't get picked up. I'll look into tomorrow.

@tobert thanks!!


cli doesn't recognize mysql url

I ran the cli and got the error We could not determine your endpoint. It's probably in an environment variable
My database is mysql; the url is structurally identical to 'mysql://root:pass@localhost:3306/default@default
In the cli index it appears that prisma-upgrade is using the is-url package to test the supplied urls.
When I use is-url to test my db connection string, it returns false
isUrl = require('is-url')
console.log(isUrl('mysql://root:pass@localhost:3306/default@default'))

I apologize if I've misunderstood something but for now I am stuck.

Which instructions are you following where it tells you to use the CLI with that parameter? Can you link to the guide in our docs?
My current guess: This might be asking for your Prisma 1 endpoint, and not a database connection string.

Thanks! I think I understand. I was following these instructions: https://www.prisma.io/docs/guides/upgrade-guides/upgrade-from-prisma-1/upgrading-the-prisma-layer-postgres#5-use-the-prisma-schema-upgrade-cli-to-resolve-schema-incompatibilities . The earlier half of those instructions is talking about the mysql connection string, which can be either in your prisma schema or in an environment variable. Mine is in an environment variable. Then I ran the prisma command as specified in the link, and the full error reads:
Error We could not determine your endpoint. It's probably in an environment variable.

Please use the --url flag to specify the endpoint.

Run `prisma-upgrade -h` for more details.

Note: The url is not used to connect to your database, only to determine the schema name.

and it seemed like that meant the db url. I'll try with the prisma url and report back. Thank you!

Yep, we should have called that --endpoint instead I would say, then it would be harder to confuse.

So as the error says, you get the schema name from the endpoint string of the prisma instance?

It worked with the prisma endpoint so I closed this issue. Thank you for helping me!

Of course, and sorry for the confusion.


Add support for changing the minimum healthy status code

I have a use case where I am running Envoy and OPA in front of a SpringBoot app with the Lambda Web Adapter.  While OPA is starting up, Envoy will return a 4xx error code.  The Lambda Web Adapter sees the 4xx as less than 500 and thinks the app has successfully started up.  I would like an option to change the definition of unhealthy in the LWA
Note: I have a PR incoming for this.

Thanks for this contribution. This is indeed necessary.


feat: support CMS static content pages navigation

PR Type
[x] Feature
What Is the Current Behavior?
The configuration parameters for the side panel navigation of 'Static Content Page Component' are not being used by PWA component 'CMSStaticPageComponent'.
Issue Number: Closes #545
What Is the New Behavior?
The path tree of a "Static Content Page" is stored and is used in CMSStaticPageComponent. Therefore the new 'CMSNavigationComponent' is created. It is possible to split the navigation tree, if the depth attribute of the 'Static Content Page Component' is set.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
Checklist (Review by @shauke 19.04.2021)

[x] Page tree should display all first level elements, all neighbours and direct children of given content page
[x] Breadcrumb should be displayed
[x] CMS Navigation Component should be replced by Content Component
[x] Facade: load and select page tree should be in one method
[x] Use ng-template as pattern to display tree data
[x] Refactor numberParam method of ContentPageletView object (if "0" is value of param, than 0 should return)
[x] use contentPage$ Observable to get current content-page-id
[x] dispath loadPageTree action should be triggered in navigation component
[x] Route should be clickable
[x] Revert changes at package.lock.json
[x] Additional/ Rework Tests???
[x] Remove unused properties of interfaces
[x] type of load page tree actions: "[Content Page Tree] ..."
[x] some methods use uniqueId to define a contentPageId --> rename
[x] Navigation component shoud be initialized in shared-module (Ecported Classes)
[x] ToDo's and Comments in Components/ Templates should be deleted ("Component has no function x, y, ...)
[x] Check Memoization of new selectors

Requires at least ICM version <IP_ADDRESS> (IS-31581)


Slight Enhancement - File System Search - "rootkit" in form text

When searching for the term "rootkit" I was surprised to see one result returned under File Results
File Results
View.ascx (06/15/2016 09:19:49)
So I searched the DNN Instance with Windows Exporer and found the instance,
C:\**server file structre ** \DesktopModules\DNNCorp\SecurityAnalyzer\View.ascx:
   71                  <div class="dnnFormItem">
   72                      <dnn:label id="plSearchTerm" controlname="txtSearchTerm" runat="server" CssClass="dnnFormRequired"/>
   73:                     <asp:TextBox ID="txtSearchTerm" runat="server" MaxLength="256" Text="rootkit" ValidationGroup="ScannerChecks" />

AH! But that's the view.ascx of the actual Security Analyzer
We probably shouldn't remove the view.ascx from review because then it would be a good place to hide things... so perhaps in the returned search results, specific to this file it ignores the text?

I've just this second done the same thing.
It would have been helpful if the tool returned the path of the file, rather than just "view.ascx" as there's 100's of these...

Moved to https://github.com/dnnsoftware/Dnn.AdminExperience/issues/130


word_wrap settings does not obey the global settings in sublime

I had to go to Preferences->Settings-Syntax Specific and add the line "word_wrap": <value> to enforce it

I'm gonna move this to  https://github.com/PowerShell/EditorSyntax. My bad!


api/v1: add cache-control header

Let's set Cache-Control to no-store if there were any warnings while
the query was being executed i.e. it is a partial response or we got
some other problem.
Seems like this works successfully in tandem with https://github.com/cortexproject/cortex/pull/1974.
Tested by turning off one sidecar which leads to warnings and then Cortex Query Frontend did not save anything into the cache when querying.
Signed-off-by: Giedrius Statkevičius<EMAIL_ADDRESS>

We can't merge it, until you undraft it (:

We can't merge it, until you undraft it (:

I know, didn't expect such positive responses and I wasn't fast enough :smile:


Some Components are failing to render as DynamicComponent on deployed App

Bug type
Component
Component name
MudSwitch, MudDatePicker, MudTimePicker, MudColorPicker
What happened?
Ok this is hard to describe but I try my best.
Some Components failed to render if you use them in a DynamicComponent
But the error Only occurs if the application is deployed. (I try it on azure and github pages)
For example if you use <DynamicComponent Type="typeof(MudColorPicker)"></DynamicComponent> everything works locally also in release mode. But on an deployed app following error occurs
Cannot provide a value for property 'ThrottledEventManagerFactory' on type 'MudBlazor.MudColorPicker' because the property has no setter. System.InvalidOperationException: Cannot provide a value for property 'ThrottledEventManagerFactory' on type 'MudBlazor.MudColorPicker' because the property has no setter.
Same for MudSwitch but instead of failing on ThrottledEventManagerFactory it fails on the KeyInterceptorFactory looks like that something not working with DependencyInjection here.
If you use MudCheckBox for example everything works fine also on deployed applications <DynamicComponent Type="typeof(MudCheckBox<bool>)"></DynamicComponent>
Expected behavior
I would expect that Components are rendered the same way as in an local enviorement.
Reproduction link
https://mudex.azurewebsites.net/theme-edit
Reproduction steps

Create an Empty MudBlazor Application with .NET6
Add <DynamicComponent Type="typeof(MudColorPicker)"></DynamicComponent> to your Index.razor
Publish Application to Azure as WebApp

Relevant log output
No response
Version (bug)
6.0.14
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge, Other
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Did you try with the latest release?

Yes my deployed test was on 6.0.14 but now I also updated this to 6.0.15 still the same
https://mudex.azurewebsites.net/theme-edit

Could you also try with 6.0.10?

Oh yeah with 6.0.10 it's working fine
(https://mudex.azurewebsites.net/theme-edit changed to 6.0.10)

So @just-the-benno @henon trasient services PR should caused this.

I am not able to reproduce this issue. I've created a new MudBlazor app, put a dynamic component in it, and published it to Azure. It is working (https://something-just-for-testing.azurewebsites.net/)
Based on your description, you should check how you set up your DI container.

Have you used 6.0.15? I dindt have any special DI setup. My Project is also only a test project from your Template. And in 6.0.10 its working and on 6.0.15 failing.

Is this still relevant?

No you can close it. Was implicit fixed in 6.5.x

Thanks.


brew cask install little-snitch: Operation not permitted

General troubleshooting steps

[x] I have checked the instructions for reporting bugs (or making requests) before opening the issue.

[x] None of the templates was appropriate for my issue, or I’m not sure.

[x] I ran brew update-reset && brew update and retried my command.
[x] I ran brew doctor, fixed as many issues as possible and retried my command.
[x] I understand that if I ignore these instructions, my issue may be closed without review.

Description of issue
Installation of little-snitch fails on MacOS 10.12.6.
Output of your command with --verbose --debug
$ brew cask install --verbose --debug little-snitch
==> Hbc::Installer#install
==> Printing caveats
==> Caveats
You must reboot for the installation of little-snitch to take effect.

==> Hbc::Installer#fetch
==> Satisfying dependencies
==> Downloading
==> Downloading https://www.obdev.at/downloads/littlesnitch/LittleSnitch-4.0.3.dmg
Already downloaded: /Users/fnkr/Library/Caches/Homebrew/Cask/little-snitch--4.0.3.dmg
==> Downloaded to -> /Users/fnkr/Library/Caches/Homebrew/Cask/little-snitch--4.0.3.dmg
==> Verifying download
==> Determining which verifications to run for Cask little-snitch
==> Checking for verification class Hbc::Verify::Checksum
==> 1 verifications defined
Hbc::Verify::Checksum
==> Running verification of class Hbc::Verify::Checksum
==> Verifying checksum for Cask little-snitch
==> SHA256 checksums match
==> Installing Cask little-snitch
==> Hbc::Installer#stage
==> Extracting primary container
==> Determining which containers to use based on filetype
==> Checking container class Hbc::Container::Pkg
==> Checking container class Hbc::Container::Ttf
==> Checking container class Hbc::Container::Otf
==> Checking container class Hbc::Container::Air
==> Checking container class Hbc::Container::Cab
==> Checking container class Hbc::Container::Dmg
==> Executing: ["/usr/bin/hdiutil", "imageinfo", "/Users/fnkr/Library/Caches/Homebrew/Cask/little-snitch--4.0.3.dmg"]
==> Using container class Hbc::Container::Dmg for /Users/fnkr/Library/Caches/Homebrew/Cask/little-snitch--4.0.3.dmg
==> Executing: ["/usr/bin/hdiutil", "attach", "-plist", "-nobrowse", "-readonly", "-noidme", "-mountrandom", "/var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/d20170924-10492-ceyt3r", "/Users/fnkr/Library/Caches/Homebrew/Cask/little-snitch--4.0.3.dmg"]
==> Executing: ["/usr/bin/mkbom", "-s", "-i", "/var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/20170924-10492-1p6od3u.list", "--", "/var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/20170924-10492-zrqyt8.bom"]
==> Executing: ["/usr/bin/ditto", "--bom", "/var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/20170924-10492-zrqyt8.bom", "--", "/private/var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/d20170924-10492-ceyt3r/dmg.iXv5A9", "/usr/local/Caskroom/little-snitch/4.0.3"]
==> ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Agent.app/Contents/PkgInfo: Operation not permitted
==> ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Configuration.app/Contents/PkgInfo: Operation not permitted
==> ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Helper.app/Contents/PkgInfo: Operation not permitted
==> ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Network Monitor.app/Contents/PkgInfo: Operation not permitted
==> ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Software Update.app/Contents/PkgInfo: Operation not permitted
==> ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Uninstaller.app/Contents/PkgInfo: Operation not permitted
==> ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Uninstaller.app/Contents/PkgInfo: Operation not permitted
==> Executing: ["/usr/sbin/diskutil", "eject", "/private/var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/d20170924-10492-ceyt3r/dmg.iXv5A9"]
==> Purging files for version 4.0.3 of Cask little-snitch
Error: Command failed to execute!

==> Failed command:
/usr/bin/ditto --bom /var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/20170924-10492-zrqyt8.bom -- /private/var/folders/l2/g6wnzp8148dfhvws1k3b1w9h0000gn/T/d20170924-10492-ceyt3r/dmg.iXv5A9 /usr/local/Caskroom/little-snitch/4.0.3

==> Standard Output of failed command:

==> Standard Error of failed command:
ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Agent.app/Contents/PkgInfo: Operation not permitted
ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Configuration.app/Contents/PkgInfo: Operation not permitted
ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Helper.app/Contents/PkgInfo: Operation not permitted
ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Network Monitor.app/Contents/PkgInfo: Operation not permitted
ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Software Update.app/Contents/PkgInfo: Operation not permitted
ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Installer.app/Contents/Resources/Little Snitch Uninstaller.app/Contents/PkgInfo: Operation not permitted
ditto: /usr/local/Caskroom/little-snitch/4.0.3/Little Snitch Uninstaller.app/Contents/PkgInfo: Operation not permitted

==> Exit status of failed command:
#<Process::Status: pid 10636 exit 1>

/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/system_command.rb:65:in `assert_success'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/system_command.rb:36:in `run!'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/system_command.rb:14:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/system_command.rb:18:in `run!'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:95:in `block (2 levels) in extract_mount'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/tempfile.rb:295:in `open'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:90:in `block in extract_mount'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/tempfile.rb:295:in `open'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:87:in `extract_mount'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:20:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:20:in `block in extract'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:56:in `block in mount'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/tmpdir.rb:89:in `mktmpdir'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:31:in `mount'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/container/dmg.rb:17:in `extract'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:173:in `extract_primary_container'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:75:in `stage'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:96:in `install'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:19:in `block in run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:13:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/install.rb:13:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/abstract_command.rb:35:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:97:in `run_command'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:167:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:131:in `run'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'
Error: Kernel.exit
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:172:in `exit'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:172:in `rescue in run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:155:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:131:in `run'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

$ sudo brew cask install little-snitch
Error: Running Homebrew as root is extremely dangerous and no longer supported.
As Homebrew does not drop privileges on installation you would be giving all
build scripts full access to your system.

Output of brew cask doctor
$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.3.3-32-gcd1cb70
caskroom/homebrew-cask (git revision ecd7f; last commit 2017-09-24)
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
/usr/local/Caskroom
==> Homebrew-Cask Cached Downloads
~/Library/Caches/Homebrew/Cask (39 files, 1.5GB)
==> Homebrew-Cask Taps:
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask (3742 casks)
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-drivers (116 casks)
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-fonts (1114 casks)
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-versions (169 casks)
==> Contents of $LOAD_PATH
/usr/local/Homebrew/Library/Homebrew/cask/lib
/usr/local/Homebrew/Library/Homebrew
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/gems/2.3.0/gems/did_you_mean-1.0.0/lib
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby/2.3.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby/2.3.0/x86_64-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby/2.3.0/universal-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby/2.3.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby/2.3.0/x86_64-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby/2.3.0/universal-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/x86_64-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/universal-darwin9.0
==> Environment Variables
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
PATH="~/bin:~/.local/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/Homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/zsh"

https://github.com/caskroom/homebrew-cask/pull/38905


 Works by remembering the current damage modifier in decimal (not percent) into a variable called _base_damage_scalar and using that value to recover the expected ow2 damage damage.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


replace compiledin default patterns with only "base" ones

Hello,
Currently, 13905 allocations are performed when calling a Grok.New(), about 11ms on my MBPro
If I replace the current patterns.go with one containing only expressions found in the base file
Grok.New() performs 5502 allocations during 2,4 ms on the same MBPro.
What do you think about making patterns.go lighter ?

I don't have a strong opinion.
On one hand, Grok.New is not something you call very frequently (usually once during initialization) so 8ms is not a big deal.
On the other, I think that expressions in gemsi/grok are outdated compared to the "official" ones. It is something hard to maintain and keep up to date.
Said that, what I'd do is:

Simplify patterns.go the way you propose. This change breaks backwards compatibility (for people already using some grok expressions), so I'd tag current version as 1.0.0 and make the change in 2.x.

Add a new configuration property (PatternsDir if we want to use the same name already used in logstash) for those who want to load additional expressions.
 g := grok.NewWithConfig(&grok.Config{PatternsDir: pathToADir})


Assets not found when run test using main methods

Hello when i launch main methods in tests folder
like using com.badlogic.gdx.ai.tests.BehaviorTreeTests#main
public static void main (String[] argv) {
	GdxAiTestUtils.launch(new BehaviorTreeTests());
}

i got error when he try to load a file.
		skin = new Skin(Gdx.files.internal("data/uiskin.json"));

		Caused by: com.badlogic.gdx.utils.GdxRuntimeException: File not found: data\uiskin.json (Internal)

For fix i have to add tests/ before asset path
skin = new Skin(Gdx.files.internal("tests/data/uiskin.json"));

im the only with this issues ?
Should i PR with all modifications ?

yes, it's could be an issue.
to fix this, you should try this code in build.gradle under tests:
// add below setting for gdx-ai
sourceSets.main.resources.srcDirs = ["./"]
project.ext.assetsDir = new File(".")

and the complete config like this:
apply plugin: "java"

sourceCompatibility = 1.7

sourceSets.main.java.srcDirs = [ "src/" ]

// add below setting for gdx-ai
sourceSets.main.resources.srcDirs = ["./"]
project.ext.assetsDir = new File(".")

dependencies {
    implementation "com.badlogicgames.gdx:gdx-box2d:$gdxVersion"
    implementation "com.badlogicgames.gdx:gdx-box2d-platform:$gdxVersion:natives-desktop"
    implementation "com.badlogicgames.gdx:gdx-bullet:$gdxVersion"
    implementation "com.badlogicgames.gdx:gdx-bullet-platform:$gdxVersion:natives-desktop"
    implementation "com.esotericsoftware:kryo:3.0.3"
}

eclipse.project {
    name =  projectGroup + "-tests"
}

and I have the same issue at the begining, and I think it might be a mistake, not a feature.


fix: upgrade to version 3.2.118

from: https://github.com/jenkins-x/jx

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
47050b982c107dc814421c8c8ee8aded54e9083a
link
/test gsm-kapp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Update for Swift 2.3

This updates the project for Swift 2.3. This PR does 3 things

Enables 'Legacy' Swift
Adds a new constructor to SecAccessControlCreateFlags to specify an Int to adapt to the Int -> UInt rawValue change in iOS 10.0
Updates the test with a change in access group behavior.

Not sure how to manage legacy swift support with 3.0 support. I'm also assuming the change in access group behavior is due to test runner changes in iOS 10.0, and not due to me doing something incorrectly.
Brian

Interesting -- I'm actually not sure how to use the availability API's to make this compatible with Swift 2.2.

I don't know the syntax too well but it looks like you can do something like this:
#if swift(>=2.3)

    @available(iOS, introduced:8.0, deprecated:9.0, message:"Use a UseAuthenticationUI instead.")
    func test() {

        print("Swift 2.3 or greater")
    }

#else

    @available(iOS, introduced=8.0, deprecated=9.0, message="Use a UseAuthenticationUI instead.")
    func test() {

        print("Swift 2.2 or earlier")
    }

#endif

I can't find any syntax like that. It's also frustrating since the change is not in swift, but in the frameworks.
I don't think swift intends to support different versions of swift being compatible in one file. I'm not sure what the right solution is though.

Thanks for PR! Now tracked on https://github.com/kishikawakatsumi/KeychainAccess/pull/222


A fatal bug!

@Fanshia Hi, Fanshia, i found a question in your code, it's about contrastive loss function.
euclidean_distance = F.pairwise_distance(output1, output2)
in PyTorch Docs
def pairwise_distance(x1, x2, p=2., eps=1e-6, keepdim=False):
https://pytorch.org/docs/stable/_modules/torch/nn/functional.html#pairwise_distance
so,  "euclidean_distance" maybe it should be like this   euclidean_distance = F.pairwise_distance(output1, output2, keepdim = True)
that's why the loss curve is instability, and test performance is bad, If you modify it like this, you will found the performance is well! To be honest, this problem has also plagued me for a long time.  But anyway, thank you for your works, it's a very good tutorial.

Thank you a lot, man!

A PR to rectify this error is most welcome!


is there an event for errors?

seems like there is no way to catch errors, such as "DUPLICATE_TRANSACTION"?
Unless i am mistaken?

I would also like to know how to handle errors with this package. I know that there's payment-authorized, payment-completed, and payment-cancelled events. But what about one for errors? Even a generic one would be nice.
Is there a way to do this?

Possible solution made in this PR: https://github.com/khoanguyen96/vue-paypal-checkout/pull/90
The underlying dependency paypal-checkout has an onError event that simply wasn't tied into before. It should allow you to catch any errors in checkout process. However I noticed identifying the exact underlying error maybe somewhat impossible (for example if it were actually a DUPLICATE_TRANSACTION). I was only able to confirm my own errors were DUPLICATE_TRANSACTION by using the dev console in Chrome open and noticing the last failed XHR network request to paypal returned that in its response. The object you get from the onError event only has a message property filled with a very boring stacktrace (and no real mention of the failed response code). But you can at the least notify end-use there was an error.

Apparently the lack of useful error object is a known thing, semi-discussion in this issue: https://github.com/paypal/paypal-checkout-components/issues/479

I missed the big Note in the official docs, https://developer.paypal.com/docs/checkout/integration-features/handle-errors/.
Just a very general event.


Reuse schema when importing from FFI

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The reason the Arrow C data interface has a separate Schema and Array struct is to allow reuse of a single schema with multiple array, but currently the arrow-rs API doesn't allow this because ArrowArray::new consumes the schema.
Describe the solution you'd like
In a fork, I have added a new function to swap the inner array :
impl ArrowArray {
    /// Swap the internal FFI array with a new one
    pub fn swap(&mut self, array: FFI_ArrowArray) {
        self.array = Arc::new(array);
    }
}

This is compatible with existing tests.
Describe alternatives you've considered
We could change the constructor :
impl ArrowArray {
    /// Creates a new [`ArrowArray`] from the provided array and schema
    pub fn new(array: FFI_ArrowArray, schema: Arc<FFI_ArrowSchema>) -> Self {
        Self {
            array: Arc::new(array),
            schema,
        }
    }
}

I also think it's possible to simplify all the ArrowArray, ArrowArrayChild and ArrowArrayRef logic and hide the implementation details by using just two functions:
pub fn to_ffi(data: ArrayData) -> Result<(FFI_ArrowArray, FFI_ArrowSchema)> {
    todo!()
}

pub fn from_ffi(array: FFI_ArrowArray, schema: &FFI_ArrowSchema) -> Result<ArrayData> {
    todo!()
}

I can explore this more disruptive solution if you are interested.

I like the from_ffi proposal, the current API has definitely evolved naturally and would benefit from a rethink

label_issue.py automatically added labels {'arrow'} from #4447


Images missing on management.php page

Is this the same as the other issue @ronm123 ? Can you see these images fine? Also, do you see anything when you click on "Feeds" button? I just get a blank screen but not sure what I should be seeing there...

Hi John
I quickly tested for the management login error on my remote installation whish is what I reported doesn't have the error. I'm just cloning a new copy in xampp and will test with that and report back.
On my online site I have two LO's added to the rss and export feeds and they show under the feeds tab with buttons to remove from the feeds

Ah, I see what the problem is... we still have references to xerteLogo.jpg (https://github.com/thexerteproject/xerteonlinetoolkits/search?utf8=✓&q=xerteLogo)
If you upgrade an existing install then this logo will be there. If you do a fresh install then it is not...

That could also be the reason for the management page issues is suppose... referencing a file that has been removed...

If you look at management.php, there is an if statement that checks whther the login is correct. If not you end up in e really old strange block of code. The comment says that it will check whether the usertype is an admin, but it doesn't happen.
I would suggest to take that whole block out. (starting around line 300)

Hi John
yes the logos are still a bit of a mess I think in terms of both maintaining compatibility for upgraded installations and new installs. To my mind both should still be using the database values and I'm not sure they are now. A clean install has xerteLogo.jpg as the default top left value and uofNLogo.jpg top right. So we need to change the values in the install script and make sure the code is using the database values.
The images currently in the images folder by default are logo.png and apereoLogo.png
I think it should be xerteLogo.png and apereoLogo.png
But for those upgrading who haven't customised their installs their database values will still point to UofNLogo.jpg and xerteLogo.jpg
A couple of solutions to this latter point I think:

we include those file names but change the content itself to the new Xerte Apereo logo's even though the filenames would misrepresent the UofN logo
we deal with this via upgrade.php and check if the values are still default and if so change to the same as a clean install

Turns out I can replicate the errors too. I was only trying the username field. If a wrong password is added that's when the error appears regardless of anything in the username or not.

Ah good. Thought i was going crazy there... do you also see the white/grey background issue at different times?
As for the logos, I agree they seem to be a bit all over the place. A fresh install uses the xerte/apereo logos correctly everywhere except management but still puts xerteLogo.jpg into the database (we need to change that)
I think your point 2 is the best way to go, use upgrade.php to change them to the new values. The problem I see is that do the database values only get used in management.php? I had the xerteLgo/UofN paths in the database but logos show perfectly in workspace, editor etc. It was only management that freaked out because they didn't exist...


Fix external build, and add CI job to check them

An unwanted change was included in release 0.6.1 of metatensor-torch, related to the code that enables building Python wheels against an already existing libmetatensor/libmetatensor-torch. These are intended to be used for the conda release (cf #402 and #729), and where not tested before.
Contributor (creator of pull-request) checklist

[ ] Tests updated (for new features and bugfixes)?
[ ] Documentation updated (for new features)?
[ ] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

[ ] CHANGELOG updated with public API or any other important changes?

📚 Download documentation preview for this pull-request

⚙ Download Python wheels for this pull-request (you can install these with pip)

DO NOT MERGE YET, this depends on #801


Support Services without Ingresses or Routes

Our Helm chart currently allows users to install Cryostat using only Services for networking, with some additional post-install steps required. It would be useful if the operator could also support these use cases, without the post-install steps.
We would want to support ClusterIP, NodePort and LoadBalancer services. At least for ClusterIP, we would need to add some kind of "external URL" property to the Cryostat CRD. This would allow the user to inform the operator of what host:port the services are port-forwarded to. This is needed so Cryostat can set up the notifications WebSocket connection and also to launch Grafana.

We will need to be careful about CRYOSTAT_SSL_PROXIED and distinguishing between HTTP/HTTPS. See: https://github.com/cryostatio/cryostat-helm/pull/36


TypeError: _forward_cross_attn() got an unexpected keyword argument 'cu_seqlens'

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Inference should work out of the box after a full fine tune
Current behaviour
(axolotl) root@Transformers:~/axolotl# python -m axolotl.cli.inference examples/phi/phi-ft.yml --lora-model-dir="./phi-sft-out"
/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/transformers/deepspeed.py:23: FutureWarning: transformers.deepspeed module is deprecated and will be removed in a future version. Please import deepspeed modules directly from transformers.integrations
warnings.warn(
[2023-12-31 13:53:07,441] [INFO] [datasets.:58] [PID:17802] PyTorch version 2.0.1 available.
dP            dP   dP
88            88   88
.d8888b. dP.  .dP .d8888b. 88 .d8888b. d8888P 88
88'  88  8bd8'  88'  88 88 88'  88   88   88
88.  .88  .d88b.  88.  .88 88 88.  .88   88   88
88888P8 dP'  dP 88888P' dP 88888P'   dP   dP
[2023-12-31 13:53:08,703] [WARNING] [axolotl.validate_config:250] [PID:17802] [RANK:0] trust_remote_code is set to true. Please make sure that you reviewed the remote code/model.
[2023-12-31 13:53:09,764] [INFO] [axolotl.normalize_config:150] [PID:17802] [RANK:0] GPU memory usage baseline: 0.000GB (+0.886GB misc)
[2023-12-31 13:53:09,765] [INFO] [axolotl.common.cli.load_model_and_tokenizer:49] [PID:17802] [RANK:0] loading tokenizer... microsoft/phi-1_5
[2023-12-31 13:53:10,104] [DEBUG] [axolotl.load_tokenizer:185] [PID:17802] [RANK:0] EOS: 50256 / <|endoftext|>
[2023-12-31 13:53:10,104] [DEBUG] [axolotl.load_tokenizer:186] [PID:17802] [RANK:0] BOS: 50256 / <|endoftext|>
[2023-12-31 13:53:10,104] [DEBUG] [axolotl.load_tokenizer:187] [PID:17802] [RANK:0] PAD: 50256 / <|endoftext|>
[2023-12-31 13:53:10,105] [DEBUG] [axolotl.load_tokenizer:188] [PID:17802] [RANK:0] UNK: 50256 / <|endoftext|>
[2023-12-31 13:53:10,105] [INFO] [axolotl.load_tokenizer:193] [PID:17802] [RANK:0] No Chat template selected. Consider adding a chat template for easier inference.
[2023-12-31 13:53:10,105] [INFO] [axolotl.common.cli.load_model_and_tokenizer:51] [PID:17802] [RANK:0] loading model and (optionally) peft_config...
[2023-12-31 13:53:15,476] [INFO] [axolotl.load_model:517] [PID:17802] [RANK:0] GPU memory usage after model load: 2.642GB (+0.048GB cache, +1.321GB misc)
Give me an instruction (Ctrl + D to submit):
what's your name?
what's your Traceback (most recent call last):
File "/root/anaconda3/envs/axolotl/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/root/anaconda3/envs/axolotl/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/root/axolotl/src/axolotl/cli/inference.py", line 36, in
fire.Fire(do_cli)
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/fire/core.py", line 141, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/fire/core.py", line 475, in _Fire
component, remaining_args = _CallAndUpdateTrace(
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "/root/axolotl/src/axolotl/cli/inference.py", line 32, in do_cli
do_inference(cfg=parsed_cfg, cli_args=parsed_cli_args)
File "/root/axolotl/src/axolotl/cli/init.py", line 142, in do_inference
generated = model.generate(
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/transformers/generation/utils.py", line 1764, in generate
return self.sample(
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/transformers/generation/utils.py", line 2861, in sample
outputs = self(
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/axolotl/src/axolotl/models/phi/modeling_phi.py", line 1048, in forward
hidden_states = self.transformer(
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/axolotl/src/axolotl/models/phi/modeling_phi.py", line 997, in forward
hidden_states = layer(
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/axolotl/src/axolotl/models/phi/modeling_phi.py", line 844, in forward
attn_outputs = self.mixer(
File "/root/anaconda3/envs/axolotl/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/root/axolotl/src/axolotl/models/phi/modeling_phi.py", line 794, in forward
attn_output = self._forward_cross_attn(
TypeError: _forward_cross_attn() got an unexpected keyword argument 'cu_seqlens'
Steps to reproduce

Train a full phi fine tune based on a local dataset, no changes to config apart from eval_sample_packing: false
Run inference post training
Fail

Config yaml
base_model: microsoft/phi-1_5
model_type: PhiForCausalLM
tokenizer_type: AutoTokenizer
is_llama_derived_model: false
trust_remote_code: true
load_in_8bit: false
load_in_4bit: false
strict: false
datasets:

path: dataset.json
data_files: "./dataset.json"
ds_type: json
type: alpaca

dataset_prepared_path:
val_set_size: 0.05
output_dir: ./phi-sft-out
sequence_len: 2048
sample_packing: false
pad_to_sequence_len: true
eval_sample_packing: false
adapter:
lora_model_dir:
lora_r:
lora_alpha:
lora_dropout:
lora_target_linear:
lora_fan_in_fan_out:
wandb_project:
wandb_entity:
wandb_watch:
wandb_name:
wandb_log_model:
gradient_accumulation_steps: 1
micro_batch_size: 1
num_epochs: 4
optimizer: adamw_torch
adam_beta2: 0.95
adam_epsilon: 0.00001
max_grad_norm: 1.0
lr_scheduler: cosine
learning_rate: 0.000003
train_on_inputs: false
group_by_length: true
bf16: true
fp16: false
tf32: true
gradient_checkpointing:
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: false
warmup_steps: 100
evals_per_epoch: 4
saves_per_epoch: 1
debug:
deepspeed:
weight_decay: 0.1
fsdp:
fsdp_config:
resize_token_embeddings_to_32x: true
special_tokens:
bos_token: "<|endoftext|>"
eos_token: "<|endoftext|>"
unk_token: "<|endoftext|>"
pad_token: "<|endoftext|>"
Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.9
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Hello, it's been a while and phi got updated. Do you still get this issue with a new model? Does it error with base phi?

Closing this issue as the error no longer exists after testing on current release of axolotl.


Fix for Travis build, now requirements.txt on master is for python3

Merging with consent of @smotornyuk and @tino097


feat: team size calculation (#194)

I've added preprocessing of threegrams for names and emails. Will make it slightly faster.
The current threshold is a reasonable value to compare two strings that have same substrings. I think your data is based on knowledge of github about completely different emails that a user might have.


Causing memory error if Faker::Internet.email with integer argument

The line of code will non-stop execute until cannot allocate memory error occurred on that line.
I know it is mostly because the sample of email cannot generated from nuimber but I think if argument exception can be triggered before all memory consumed is better.

I am not sure if I completely get what your error is, but this is what I did and it seems to work fine:
[1] pry(main)> Faker::Internet
=> Faker::Internet
[2] pry(main)> Faker::Internet.email
=><EMAIL_ADDRESS>[3] pry(main)> Faker::Internet.email(1)
=><EMAIL_ADDRESS>
Can you please share an example of your error?


Add searching all flows and showing date in results

I corrected master to compile cleanly with current dependencies (are to be less likely to break in the same way later). Could you rebase the PR?

Rebased version pushed

Thanks!


SAK-32137: Instructors can change course site title during initial creation even if choosing a roster

By default, the title of a course site is not editable.
In SAK-29823 we enforced the titleNotEditable property in all scenarios,
including initial site creation, so that instructors could not change
the title of a course site. This assumed that a roster would always be
chosen for the course site and the title would be taken from the
roster. This lead to problems when the "Continue with no roster" feature
was enabled (it is off by default), so in SAK-31261 changes were made to
address that problem which essentially reverted SAK-29823, allowing
instructors to change course site titles during site creation.
This patch attempts to address both uses cases above. If a course site
is using a roster, the title will not be editable. If an instructor
chooses to "Continue with no roster", a site title must be provided, so
we allow it to be edited. This is accomplished by checking to see if a
roster is attached or not.
Due to the setup process being a wizard that maintains state between
pages, it is possible to first select a roster, then go back and decide
to continue with no roster. Previously the old roster would remain in
the state and would be considered attached for the checks above, so this
patch clears any roster selections from the state when "Continue with no
roster" is chosen. It also attempts to detect if the site title and/or
description were assigned by the roster selection and removes them
unless the user has edited them already.

LGTM; planning to merge by end of day tomorrow if there are no objections.


Extension activation fails due to missing dist folder

On one of my PCs the extensions\ms-vscode.csharp-1.20.0\dist folder somehow went missing (probably during an automatic extension update). Reinstalling the extension within VS Code didn't help, VS Code didn't remove the extensions\ms-vscode.csharp-1.20.0 folder during uninstall. Instead I had to uninstall it, manually remove the folder and again install the extension. Is that an issue of VS Code?
Environment data
dotnet --info output:
 Version:   3.0.100-preview5-011568
 Commit:    b487ff10aa

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18362
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview5-011568\

Host (useful for support):
  Version: 3.0.0-preview5-27626-15
  Commit:  61f30f5a23

.NET Core SDKs installed:
  2.1.600-preview-009472 [C:\Program Files\dotnet\sdk]
  2.1.604 [C:\Program Files\dotnet\sdk]
  2.1.700 [C:\Program Files\dotnet\sdk]
  2.2.200-preview-009748 [C:\Program Files\dotnet\sdk]
  3.0.100-preview5-011568 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview5-19227-01 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview5-27626-15 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview5-27626-15 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

VS Code version: 1.36.0
C# Extension version: 1.20.0
Steps to reproduce

Install extension
Open .NET Core porject

Expected  behavior
The extension loads
Actual behavior
Error: Cannot find module 'c:\Users\labor\.vscode\extensions\ms-vscode.csharp-1.20.0\dist\extension'
	at Function.Module._resolveFilename (internal/modules/cjs/loader.js:584:15)
	at Function.Module._load (internal/modules/cjs/loader.js:510:25)
	at Function.define._installInterceptor.i._load (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:491:111)
	at Function.t._load (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:760:742)
	at Function.t.getExtensionPathIndex.then.i._load (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:685:176)
	at Module.require (internal/modules/cjs/loader.js:640:17)
	at require (internal/modules/cjs/helpers.js:20:18)
	at Function.i [as __$__nodeRequire] (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:31:381)
	at c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:747:60
	at D._doActivateExtension (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:747:168)
	at D._activateExtension (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:746:6)
	at D.<anonymous> (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:742:827)
	at Generator.next (<anonymous>)
	at n (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:13:621)
	at new Promise (<anonymous>)
	at n (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:13:398)
	at Object.actualActivateExtension (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:742:529)
	at p._activateExtension (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:479:561)
	at define._activateExtensions.r.length.Promise.all.s.map.e (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:479:245)
	at Array.map (<anonymous>)
	at p._activateExtensions (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:479:233)
	at p.activateById (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:477:355)
	at D._activateById (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:744:743)
	at D.<anonymous> (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:753:319)
	at Generator.next (<anonymous>)
	at o (c:\Users\labor\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:13:454)

It seems like one has to restart, not reload VS Code for removing old extensions' directories.


[Bug Report] el-input-number initial value

Element UI version
2.4.3
OS/Browsers version
Win10/Chrome 66
Vue version
2.5.16
Reproduction Link
https://codepen.io/guohao/project/editor/AQyJkr
Steps to reproduce
when a property is null, the value of el-input-number become zero automatically.
What is Expected?
Initializes the el-input-numbe,The initial value is empty
What is actually happening?
el-input-number value become to zero

@wisdomsuper you can set the initial value to undefined.
https://github.com/ElemeFE/element/blob/b18642f716aedae9e8de409b64c078bf510ba264/packages/input-number/src/input-number.vue#L107-L110
The initial value doesn't support null and null can be converted to 0.

It's not convenient，the data usually generated by JSON, I must change the json generation.

I am facing this issue as well, this really frustrating as the only solution - workaround provided here is to add watcher on the actual input value, which decreases dramatically the performances when typing in it.
It is also not convenient as my data comes from the server, and the server doesn't handle undefined values...
@Leopoldthecoder What do you think? Is there anything else we can do to bypass this?

I have the same issue. When empty, the number value is undefined and firestore throws an error as undefined is not a number.
The number input should always be a number, 0 should be it's default empty value.
Or you should at least have the option to make 0 the default/empty value.

There is plan to rewrite input-number to support null/undefined zero. Resetting invalid value is inappropriate, and will cause problem when there are not @input event handler.
Reopen this issue.

god , null is valid for number ? why not provide default value on props ?

I have found a workaround for this and it's to pass the initial value as undefined, seems to be working as expected in this issue. Btw, this is not working if I pass null.


Model Usage on Andriod App

I'd like to use this model on an Android, to extract the keypoints coordinates.
Is there any precedent or guidance？
Thanks in advance.

Hi! There is no such, but you can try the official example.


Offering 50$ to anyone adding it to the yunohost Synapse template

See https://github.com/YunoHost-Apps/synapse_ynh/issues/395

Your excitement is welcome, but this is not the place to publish this sort of bounty.


Finalize the constraints on QuantizationZeroPoint

The goal of the ticket is to resolve the following discussions around the quantization zero_point:

Can zero point usage be restricted to 8-bit and lower?
Following the TFLite behavior, should zero_point granularity be restricted to  per-tensor?

Hi, I didn't get a chance to comment during the discussion meeting today, so I'd add my comment here. I feel 8bit zero point is more of a TFLite x INT8 quant specific choice, and in StableHLO spec it is better to be more general than that. For example, if we think about INT4 quantization, do we want to restrict the zero point to 8bit too? In this case, 8-bit seems a much more magic/arbitrary number in this case (why not 4bit, 5bit, etc.).

Hi, thanks for the today's discussion!
I think limiting zero point to dst data type range can restrict quantization schemes supported. If we have the following quantization:
x_f32 = alpha * (x_u8 - z_x)
min(x_f32) -> u8_min
max(x_f32) -> u8_max

alpha = (max(x_f32) - min(x_f32)) / (u8_max - u8_min)
z_x = u8_max - max(x_f32)/alpha

If 0_f32 < min(x_f32) then z_x might not fit into destination range. For example:
>>> x = [4, 6]
>>> alpha = (max(x) - min(x)) / (255-0)
>>> z = 255 - max(x)/alpha
>>> alpha
0.00784313725490196
>>> z
-510.0
>>> 4 / alpha + z
0.0
>>> 6 / alpha + z
255.0

As you can see the zero point is -510 which doesn't fit into u8 data type.

Thanks @igorsafo for bringing this up and thanks for the super useful example.
Let me share a bit of history on why we end up at type(zero_point) = storage_type.
I remember that the initial proposal of the spec has For all i, type(zero_points[i]) = i64. That was to accommodate the use-case you shared,  when 0_f32 does not lie between [min(x_f32), max(x_f32)], which  makes  the zero-point to be outside of [q_min, q_min] and hence an i64 can be safety be used to store the zero-point.
Later based on the discussion, we decided to add the constraint (C8) storage_min <= zero_points <= storage_max, to enforce that the 0_f32 will always be within
[min(x_f32), max(x_f32)] and if C8 is true then we can say that type(zero_point) = storage_type. The decision was backed by how tflite ensures that 0_f32 be included in the float range. (refs).
Coming back at the current discussion: I agree that, per the current form of specification, the running example is not allowed as the zero-point goes out of [u8_max, u8_min]. However, I am happy to explore and work on how we can enable that.
Just to get a bit more context: Do you mind sharing on the motivation for not including 0_f32 in the float range. I was wondering if something like https://github.com/tensorflow/tensorflow/blob/f93185001ff1d7b75e9966b80a144601d7d6e696/tensorflow/lite/tools/optimize/quantization_utils.cc#L74 work in your case.

@sdasgup3 Thank you for the links! It makes a lot of sense!
Unfortunately, I don't have a real use case. I am a developer of oneDNN and we implemented zero points as s32 to support frameworks/applications that define it this way. What is the plan to support fameworks/applications that define zero point larger than quantization data type? For example, PyTorch specifies zero point as an integer https://pytorch.org/docs/stable/quantization.html#quantized-tensor

PyTorch specifies zero point as an integer https://pytorch.org/docs/stable/quantization.html#quantized-tensor

I think it is just a catch all to express zero-point in any supported quantized dtype. Per the formula x_u8 = x_f32 / alpha  + z_x, if any zero_point value is out of the range of the storage type, it will just overflow the storage type. In this case, all values will be quantized to the same value (min or max of the storage type).
For now, let us close this issue with the resolution that  zp should be the same or narrower than the storage type enforcing that the 0_f32 will always be within the float range. Feel free to re-open this one with concrete use-cases or address them in separate issues.


Proof of work Update

I have made the changes mentioned in my issue so here is my PR to provide you all the changes.
Thanks and Regards
Spandan Mukherjee

3rd Commit Changes
Initial:

Final Changes:

Changed the meditation.html
Initially:

Final change:


Does not work in Chome

We could not resolve our promise to facebook via the angular app in Chrome!  This occurs around 146 of the ngFacebook.js
I'm not sure why this occurring but I thought I'd let you know

I have the same problem to Chrome on mobile.


UI improvements at navbar

=> as i attached the image in the navbar it is showing main, and it is not having any functionality
=> so i request to remove that

PR related to navbar UI exists !


Typo in building a picasso painting step 50

Describe the Issue
There is a typo in learn-intermediate-css-by-building-a-picasso-painting, elemnts is used instead of elements.
Here is the typo
https://github.com/freeCodeCamp/freeCodeCamp/blob/84a41308c02ce4fac2b0db6a23ac21e9ba1590a0/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/60b69a66b6ddb80858c515a7.md#L14
Here is the markdown file https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/60b69a66b6ddb80858c515a7.md
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-intermediate-css-by-building-a-picasso-painting/step-50
Additional context
Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in discord or the forum if you need help contributing, our moderators will guide you through this.
Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first.
Happy contributing.

can i take this up

@anoopano feel free to open pull request after you have read the guidelines


Sync exclude

Adds the ability to exclude some files from sync, with glob patterns, i.e. exclude: ["file1.txt", "dir2/*", "data.*"]

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

23 of 23 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 85.276%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
2085

Relevant Lines:
2445

💛  - Coveralls


add generate interviewtime

Method that takes in start time, end time and place, and even duration of interviews.
Duration may be changed later, and interviews should have an endtime also, due to some gangs having longer interviews.
added tests, check if clean add single, multiple, and if time is occupied
Method returns admissions that got an interview time
Could later add an algorithm for multiple dates

closes #1136


Add angular annotations (add support for ng-strict-di)

Annotations may have to be added to fix problems when ng-strict-di is used.

That's right. The distribution version is not piped through ng-annotate yet. I gonna take care of that tomorrow.


Add Windows support to defaultTargetPlatform

A significant amonut of code uses defaultTargetPlatform, so it's
currently impossible to run most apps on Windows. This adds a mapping
from Windows as a host to Android as a target, paralleling the
macOS->iOS and Linux->Android mappings.
This allows more use of Windows as a host platform (e.g., for testing,
as in issue #17768).

This seems very wrong. Windows is not Android and has entirely different platform conventions. I think we should revert this.

Can you elaborate on the objection? macOS and iOS have different platform conventions, and desktop Linux and Android have different platform conventions, but those mappings are there. I'm not sure why Windows is fundamentally different.
In the long term, I would expect all of these desktop mappings to go away and be replaced by desktop platforms as targets, but for now I'm not sure why Windows can't be on the same level with macOS and Linux.

I've removed those other mappings. I agree that Windows should be on the same level.


Clipping Issue: When standing right below a platform

Note: I moved to the furthest right edge to show there were actually blocks there.


62 update filter if

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue so that it closes after successful merging.
[ ] Address all merge conflicts and resolve appropriately.
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63 - Hi Ben by mistake I created this PR. I missed updating the branches before creating the PR. Could you help me with deleting this PR and creating a new one. Apologies for the trouble.

All good.  You can just close yourself next time.  I do this all the time :)


Ground hog day documentation. Escaped from the never ending loop and never got anywhere

Great product I expect.
Shame the guides are not even 5% as good as Microsoft CrmSvCUtil.
Click here for more details? How to run XrmContext? I have no idea.
Setup Instructions. generate Context. No help same loop.
Getting started. generate the context? Takes you back to the same text. Groundhog day.
More gooogling and found a powershell script, looked close but nah.
Non-devs and devs walk away from loading a phone app if it takes more than 30 seconds.
If you write a good bit of code then its worth getting it used, its not clever to have bad documentation.
Disappointed. Richard

I also have a big problem with the documentation. I use this lib because it's much better than CrmSvCUtil. I see a lot of clever things to make our lives easier, but I simple don't know how to use them. Which is a shame.
I have no clue how to use things like:

get the name of the OptionSetmetadata
GetColumnName (like this SystemUser.GetColumnName(e => e.FirstName) ?)
GetColumnSet
other extensions methods.

I like to improve stuff in XrmContext and Daxif, but I don't know F#. What I can do is add documentation to helpe you out, but I need pointers here and there, to make the correct documentation. Maby you can share some examples how you use the XrmContext in your projects, so I can make documentation for that?

Thank you for your input @remyvd - as already mentioned, looking into and improving the documentation is highly prioritised, but available time is hard to come by.


Fixed plan ls + Added bundle plan

Done.

It seems OK. If you've tested it  locally, you can merge it.


Online package viewer shows [object Object] instead of maintainer

Issue description

Steps to reproduce
https://nixos.org/nixos/packages.html

Could you open this issue in the nixos-homepage repo please?

Sure


WARNING: some source is blocking LAN

Someone is adding <IP_ADDRESS>/16 to the superhosts.deny, as a result the entire LAN is blocked from access.
The culprit source should be identified asap. EDIT: it's Firehol
@mitchellkrogza @funilrys

Hi @unbranched  and thanks for this issue,
I recently updated the script which distribute everything. It's my fault I forgot to reimplement that. It will be fixed in the coming hours (Berlin Time).
Sorry for the disruption.
Cheers,
Nissar

Hello....i copy pasted the entire host.windows text to the "hosts" ...now I'm not able to connect to internet ...lan as well as via Ethernet... And I'm not able to change hosts ..it says it's being accessed by another program... Even when done as administrator... please help


[BUG] Selection in HoldBrowser

Hello,
i have an issue with selections in a HoldBrowser.
It seems like the last line cannot be selected.
Consider the following example:
use fltk::{app::*, window::*, browser::*};

fn main() {
    let app = App::default();
    let mut wind = Window::new(100, 100, 400, 300, "Will panic!");

    let mut brw = HoldBrowser::default()
        .with_pos(50, 50)
        .with_size(300, 100);
    brw.add("One");
    brw.add("Two");
    brw.add("Three");

    brw.select(0);
    assert!(!brw.selected(0));
    brw.select(1);
    assert!(brw.selected(1));
    brw.select(2);
    assert!(brw.selected(2));
    brw.select(3);
    assert!(brw.selected(3)); // This will panic

    wind.end();
    wind.show();

    app.run().unwrap();
}

The first three assertions behave like expected:
i can select lines 1 and 2, but not 0 since lines start at 1.
But line 3 cannot be selected it seems.
I varied this a bit and the problem is always the last line.
Maybe there is an index shift missing somewhere?

Hello
Yes it was a logic bug in the BrowserExt::select() method. Thanks for pointing it out. I'll publish a fix in a few minutes

I have published the fix in version 0.12.2

Works perfectly.
Thank you for the fast response!


Visual Studio is missing necessary components.

Steps to Reproduce

Install Flutter on a new Windows machine
Switch to master channel and upgrade to latest version
Install Visual Studio 2019 Community Edition, choosing the "Desktop development with C++" workload
Start a new cmd session in case any environment variables have been changed
Run flutter doctor and get the following Visual Studio-related error message:

Double-check Visual Studio Installer settings, which seem correct:

Log this bug

Logs

[√] Flutter (Channel master, v1.10.15-pre.405, on Microsoft Windows [Version 10.0.18362.418], locale en-US)
    • Flutter version 1.10.15-pre.405 at c:\Users\csell\flutter
    • Framework revision 28b5cc3825 (4 hours ago), 2019-11-05 11:50:30 +0100
    • Engine revision 7b968ff95f
    • Dart version 2.7.0

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\csell\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[!] Visual Studio - develop for Windows (Visual Studio Community 2019 16.3.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.3.29424.173
    X Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop development with C++" workload, and include these components:
        MSBuild
        MSVC v142 - VS 2019 C++ x64/x86 build tools
       - If there are multiple versions, install the latest one
        Windows 10 SDK (10.0.17763.0)

[!] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code (version 1.39.2)
    • VS Code at C:\Users\csell\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.5.1

[√] Connected device (1 available)
    • Windows • Windows • windows-x64 • Microsoft Windows [Version 10.0.18362.418]

! Doctor found issues in 2 categories.

Running the x64 Native Tools Command Prompt for VS 2019 cmd prompt makes the various MSVC tools available on the command line, e.g. msbuild, but does not appease flutter doctor.

Your screenshot shows the required SDK version as unselected, so you are missing one of the required components listed by doctor

Apparently in VS 2019 it's now possible to just set the version to "10.0" instead of an exact version, which wasn't possible when I was initially researching this. We may want to require 2019 so that we can switch to that, since this has been, and will continue to be, a pain point.

how do I fix the issue?

You need to install the component called "Windows 10 SDK (10.0.17763.0)"

Unfortunately there doesn't appear to be a generic component ID for "latest SDK" so even if we set it to 10.0 and required VS 2019 doing the vswhere query would be very messy, and require tool updates for every Windows SDK release.

Then the bug is that flutter doctor says to do two things:

Install the "latest" Windows SDK, which is "10.0.18362.0" right now.
Install ""Windows 10 SDK (10.0.17763.0)".

#2 works. #1 does not.

Closing since the text was improved to help avoid this confusion. #50487 tracks trying to eliminate the need for a specific SDK version entirely which would avoid this common problem.


Update Kubernetes README.md

Fix title to avoid collision with User Management page for https://docs.terrakube.io/getting-started/kubernetes
Fix broken link to Azure Kubernetes Service sub-page
Update description indicating docs are a work in progress.

Thank you @Nicolas-M


Fixing tags in the HTML

@BatoolMM my name is Jesutobi Joseph, an outreachy intern, i went through the html and found out there were some errors in several lines of code,where idle close tag existed, tags without a close tags or open tags thats causing a bug when prettier tried to format the code....line 162,line 227,line 205, line210,line 227, line 489..................i have fixed them, so what should i do next

Yep!
Tag fixing is a skill in itself. I do same for my website

Yep!
Tag fixing is a skill in itself. I do same for my website

okay


Bugfix release

I would like to issue a bugfix release.  There is no major goal for this, other than to keep up a nice cadence.  If there are any objections then please let me know.

Merging PR https://github.com/dask/dask/pull/3964 would be appreciated :dancing_men:

This was released on Monday.  Closing.


registry --domain usage issue

I didn't get why we have added a --domain argument to the amp registry cli command.
Why do'nt use the server address instead?
registry.[serveur address] is routed to registry by HAProxy
considering the server address shouldn't be an IP but a DNS, i don't see the need to use another information.
Note: we can use serverAddresss as IP format only for amplifier command as stats, logs, stack, ..., because amplifier doesn't use HTTP and have a dedicated port, but for all other services including user ones we need a DNS address to make HAProxy able to route it. So we could forbid IP address format in the configuration or in the --server argument, to have only DNS and then use it for registry. It seems more consistent.

that would nice to merge the two options, for now we have these two options because of what you described (serverAddr can be an IP) and because serverAddr contains also a port, which is not the one for the registry service.


Design: Short-form for generate_commit_message()

#462 points out that the flexible name schemes for assets mean that paths = [x.name.split('_')[0] for x in path do not necessarily lead to the type name field, this is just based on our current default implementation.
While not high priority, I wonder if there is not a reasonable replacement for this; e.g. selecting the first element of onyo.assets.filename which defines the filename for assets, and/or the biggest overlap in the name of all things the list of parameters given into generate_commit_message() or something like that.
I do not see a way that always works ATM, but somebody else might come up with a reasonable alternative :)

I recently rediscovered this issue, and this functionality is really from a different era of Onyo. Nowendays, no particular key has any more meaning than others. So specifying a particular key for the summarize to use when the subject is too long... it's pretty arbitrary and I don't think will work terribly well in practice.
If I make a change to many (let's say 42) assets, every single asset is listed in the subject. That does feel... intense.
set [42] (type): laptop_apple_mba2022... [42 assets are listed here]

I see a few options:

leave the behavior as is; it's not hurting anything

it's also not useful in any way; the Operations Summary is much more useful

naively decide what "too long" is and simply say "42 assets"

this feels pointless, as set [42] (type) already contains all that information

attempt some form of reduction of the asset name:

set [42] (type): laptop_{apple,framework,lenovo,toshiba}_{16}_{42}
short lists (some char length?) will list all fields, longer ones will say the number of variants
This doesn't feel all that much better. The primary improvement is that I can review how much variance there is.

If we can't design something that's clearly an improvement, then we should close this issue.
Thoughts?

If we can't design something that's clearly an improvement, then we should close this issue.

Lol, I just went to old issues with the goal to find at least one old issue that can be closed. Seeing your comment seems to justify my believe that this one is indeed out of date.
In praxis, I did experience this too (we have some very long commit messages), but it does not hurt, and there is still no better way this could be done. I will close here :)

I'm going to reopen this, because I would like to explore option 3 more before we abandon it.

My problem here is that the subject is filled with redundant information. It's all repeated in the body, and in a much better format for both humans and scripts.
My idea is that we consider that the keys in the asset name are human-relevant descriptors of the asset. I'm comfortable with that, as clearly the user has chosen them as a reasonable way to identify assets.
So running with that idea: we have a pile of assets that have been modified. Let's attempt to reduce that:
set [42]: type=laptop,desktop make={8} model.name={12} serial={42}

This, while imperfect, is indeed a summary of what happened. When we can list the key values, we do so. Otherwise, we count the number of unique values for that key.
Thoughts?

The only thing I miss in your example is that we currently list also the keys which where changed, which I consider very important, even in the message.

Ahh, I missed that. Yeah, that information should be retained.
set [42] (type): type=laptop,desktop make=[8] model.name=[12] serial=[42]

i.e. if the number of different serials is actually needed,

I don't think it's helpful to think about them as serials. Rather, imagine the keys as a, b, c, and d. They have no meaning. All we know is that the user has chosen these keys as good identifiers on the filesystem. That is the only reason why we are able to consider them relevant for the subject. Onyo knows they are important, but not what they mean (and that's ok).

set [42] (type): type=laptop,desktop make=[8] model.name=[12] serial=[42]

FTR: I don't think we'd want to make the logic that complicated. Either the values are listed for all keys or they are all collapsed to [<number>]. Figuring out which permutation of collapsing or not collapsing is short enough seems a bit cumbersome.
Other than that: Agreed.

I don't think it's helpful to think about them as serials. Rather, imagine the keys as a, b, c, and d. They have no meaning. All we know is that the user has chosen these keys as good identifiers on the filesystem. That is the only reason why we are able to consider them relevant for the subject. Onyo knows they are important, but not what they mean (and that's ok).

Yes of course, but even so there might be value in displaying a, it being the first field, for example, completely. Just numbers in the message subject will always mean less than displaying the first field more explicitly, so my thought. The big contra is that this would in some situations lead to too large subject lines once again. (I agree with Ben that trying to permutate over multiple/all possibilities is probably bad.)
So I would be already very happy to see the proposed shortening!

I agree that less complicated is a good thing. However, I think the implementation can be relatively easy to do the "right thing":

build the full, expanded subject
loop over it, if/while it's longer than <configured length: default 75>:

take the key with highest variability (or longest value string), and reduce the values into a number (e.g. serial=[42])
continue until < 75 or all values are reduced

[...] there might be value in displaying a, it being the first field, for example, completely. [...]

I disagree. There is no way to know if a is any more relevant than b. For example, if I set something in all apple devices (second field in our inventory), that field is the most important, and not the type (the first, which might have half a dozen values).

Fair. In any case: Can be figured in an implementation issue.

Damn. I thought we had this figured out, and then as I started writing the implementation issue, I realized that there's some open questions:
This behavior clearly applies to set, unset, and new. What's unclear to me is if it applies to other commands such as mv, rm, and edit. It clearly does not apply to mkdir.
My initial impulse is that we should use this idea wherever we can. The problem is the same: the commit message is unusable.

edit: makes sense to use the approach in this issue
rm: complicated because it can remove both directories and assets (IMO, this needs its own design issue; don't list children of a dir, etc)
mv: complicated. moving or renaming a single asset/directory is covered by #708; multiple directories cannot be reduced; multiple assets... maybe should use the method in this issue. Perhaps this needs its own issue?

Thoughts?


Improve encrypting passwords

Rather than using sha-256 for encrypting passwords, use bcrypt

Added in latest commit


it's cumbersome that setting width&height for every upload image

when using the admin site for adding or uploading images, you must set the width and height for every image,  it's a very cumbersome and unefficient work, Is that any easy way to let it use the original size or auto resize to a default size?

This is just a sample. You can completely ignore the width and height and go with your own implementation.


CP2K backend: updates and documentation

switch to my new cp2k-input-tools module as parser backend for the CP2K input file for full syntax support
implement alternative cell specifications (ABC/ALPHA_BETA_GAMMA or A/B/C)
properly use CP2K's base units instead of mangling them
use the iter_collect_forces to always pick up the last ones in the .xyz files in case the user ran the calculation multiple times
add tests and documentation
add NaCl-CP2K example

Merged to develop. Thanks.


Add TPM Key Support

Description of changes:
This is a continuation of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Nice. Thanks for seeing this to completion!

Sorry it took so long, and thanks for all your help throughout the process (including writing the majority of the code, from which I built off of)!


[CI] Test against Ruby 2.5

Summary
CI against latest Ruby 2.5
Short checklist

[x] Did you run bundle exec rubocop -a to fix linter issues?
[x] If relevant, did you create a test?
[x] Did you confirm that the RSpec tests pass?
[ ] If you are fixing a bug or introducing a new feature, did you add a CHANGELOG entry?

Other Information
https://www.ruby-lang.org/en/news/2017/12/25/ruby-2-5-0-released/

The failing test is the the same as the current master branch.
Might restart failing jobs.

Thanks for the PR! I'll open a separate issue for the master build failure.

A bunch of new rubies where released yesterday, including 2.5.1. Could you update the PR to use those instead? Thanks!

Updated

Thanks! Once #1975 is merged I will merge this in as well.

@leehambley I believe master now tests Ruby 2.5, so the goals here have been met. 🎉


Publish to chocolatey (if desired)

https://docs.chocolatey.org/en-us/create/create-packages

Fixed (no auto-push yet, but I don't know if we need that either. Could do later.


Loss of carriage return issues for MD to MAML and then back to MD

Steps to reproduce
I ran the following command to get our individual markdown topics into MAML files for check-in back into code:
New-ExternalHelp -Path <Path> -ApplicableTag "<TagValue>" -OutputPath <Path> -ErrorLogFile <FileAndPath>

I then ran the following command to use one of the MAML files as the source to dump the cmdlets back into individual markdown topics:
New-MarkdownHelp -MamlFile "<MAMLFileAndPath>" -OutputFolder "<Path>"

Expected behavior
The formatting of the resulting markdown topics should be basically the same as the source markdown topics.
Actual behavior
Carriage returns are eliminated in bulleted lists and other multi-paragraph situations (parameter descriptions, example descriptions, etc.).
For example, in Add-AttachmentFilterEntry.md
The description of the Type parameter looks like this in the source topic:
### -Type
The Type parameter specifies what type of attachment the attachment filter entry blocks. Valid values are ContentType and FileName:

- ContentType: This value matches the attachment filter entry against the MIME content type specified in the Name parameter.

- FileName: This value matches the attachment filter entry against the simple file name specified in the Name parameter.

But the same parameter description looks like this in the output topic:
### -Type
The Type parameter specifies what type of attachment the attachment filter entry blocks.
Valid values are ContentType and FileName:

- ContentType: This value matches the attachment filter entry against the MIME content type specified in the Name parameter.
- FileName: This value matches the attachment filter entry against the simple file name specified in the Name parameter.

I realize a new line without a blank line in between is the same as one long line. But why is the blank line between the bullets lost?
See the attached files for details.
Is this related to #210 and #212? I don't think so, but I'll take that under advisement.
Environment data
platyPS v0.12.0
Original markdown topics
MAML file from original markdown topics
Markdown topics from MAML file

The scenario is going to be different with Microsoft.PowerShell.PlatyPS v1. Rendering to MAML produces lower fidelity content, but the quality is improved in the v1 code.

Tracking newline issues in #508