[Feature Request] Use embedded metadata like ComicInfo.xml

Is your feature request related to a problem? Please describe.
ComicInfo.xml is in all of my chapters with relevant information. It would be great if metadata is handlet that way: Use existing systems like ComicInfo.xml. You can read and update metadata that way.
Describe the solution you'd like
Mango reads embedded metadata to set titles, tags, authors etc.
Describe a small use-case for this feature request
I can search Manga better by tags

Hi, thanks for reaching out!
I know it's from ComicRack, but I've never used it, so I am not sure how it works. I did find some example ComicInfo.xml files online, but it would be great if there's a clear documentation of the format. Do you have any suggestions?
I can see that this feature would be helpful for some users, but it has a lower priority in my list. I am focusing on refactoring the plugin system and getting Mango to work with the MangaDex API v5. If you or anyone else are interested, feel free to submit a PR for this!

I noticed that ComicRack has fallen and that format is not really official anymore but more of a lingering thing.
I guess would be cool to implement but since it's not a good format anymore, have a low priority is fine.
Some form of embedded metadata would be cool though!

I guess would be cool to implement but since it's not a good format anymore

To be honest, xml was never a good file format. It is difficult to parse and read.
I would suggest the toml file format:
# lines starting with # are comments
title = "Grand Blue (Dreaming)"
# this should be supported too:
# author = "Inoue, Kenji (Story)"
# which would be a shorthand?
authors = [
    "Inoue, Kenji (Story)",
    "Yoshioka, Kimitake (Art)", # trailing commas are okay
]
description = """
Among the seaside town of Izu's ocean waves and rays of shining sun, Iori Kitahara is just beginning his
freshman year at Izu University. As he moves into his uncle's scuba diving shop, Grand Blue, he eagerly
anticipates his dream college life, filled with beautiful girls and good friends.

But things don't exactly go according to plan.
"""

genres = [
    "Comedy",
    "Slice of Life",
    "Seinen"
]

# the date format is: YYYY-MM-DD
publish_start = 2014-04-07

which has the benefit that you can have multi-line strings, comments, and it is easy to read by humans.
There is a toml parser for crystal available: https://github.com/crystal-community/toml.cr

@Luro02 I guess toml, yaml and ini are all great choices for this. Also I think it's important to make writing the embedded metadata file an optional feature and have it disabled by default as some users might find it too intrusive.

I don't know if you still needed documentation for ComicInfo.xml, but in the komga repository, there is a resource that lists all "officially supported" tags as well as example files. While I agree ComicInfo is a pretty awful standard that has never even really been fully documented, it's a somewhat legacy format that a not insignificant amount of people use/have used. I think supporting it is a good idea even if it in itself is not ideal. Adding support to at least read from them, if not write, is a good idea as people could at least transfer their metadata to whatever format becomes prevalent or that Mango decides on.

I agree wholeheartedly!
It's VERY prevalent and extended with inofficial tags a bunch, reason being that ComicRack died (RIP sweet prince, one of the kinds of softwares that taught me to select my applications a lot by availability of source code by now! ESPECIALLY since running my own rack server at home :D)
It's common to find meta data scrapers that output in that format, so... A necessary evil.
Komga project only wants to support official tags from it which is.... Missing the point if you ask me, but hey.. God speed to them I guess.

If possible, are there some ways to support to parse a custom metadata format? the downloader that I use makes their own json file for metadata (author, tags, etc.) Could it be done like download plugins doing?

If possible, are there some ways to support to parse a custom metadata format? the downloader that I use makes their own json file for metadata (author, tags, etc.) Could it be done like download plugins doing?

Love this idea! Would really make it customizable and adaptable to all sorts of downloaders!

@GlassedSilver It's infeasible for us to support every downloader out there.

I never said I'd expect as much. o.O
I was only talking about a user-friendly template system for the user (or by extension the community) to fill gaps where they may come across such.
And it's only an idea as well. I just don't know how my downloader might change from what I have now to something else in the future, because development for it might fork into another new contender yet again (FMD2 currently btw) or because something else, better comes along (maybe something that can run on Linux as a container).
Or how I may eventually want to add my smutty doujinshis to Mango as well if HPX ever turns out to not be the kind of software that it seems to be promising to be. (I mean I'm happy with its concept so far, but who knows)
So the ingressed parts of HPX (a media library manager and viewer, but it can also download content) and the tool I use to feed it with (another downloader, I just - at least for now - separate my originals from my doujinshi collection) may need coverage in the future as well.
Nothing is for certain.
I know that there's probably a lot of non-devs who would rather work up some brain muscle for a text template file to wrap some easy to understand terms with rather than being told to "just do something in JS to manipulate a component of the software".
First thing that comes to my mind is: something else that may break, when a template file is standardized to a given spec to wrap things with, etc... idk okay... Maybe the peace of mind is something that sets in if you're close to the code of the project, but to the average user it's a bit of a leap of faith and a pretty big degree of uncertainty.
That's all I'm saying. :)

@hkalexling if you ever want to support this, note that we have brought ComicInfo under the Anansi Project umbrella, where we steer small non-breaking evolutions of the schema : https://github.com/anansi-project/comicinfo
If you do want to support comicinfo.xml we would be happy to have you as a supporter of the initiative, and participate in discussions about the schema itself.
We also have documentation and accepted usage of the various fields : https://anansi-project.github.io/docs/comicinfo/documentation

@gotson Awesome, thanks for letting me know!
Supporting ComicInfo is not a priority for me atm, but I can see the value of this, and I will be happy to be a supporter and contribute in discussions :D


terraform: make field AuthOpts public

In order to enable system scoped authorization in terraform-openstack-provider need the field authOpts in Config struct to be public.

@mandre hi, can you have look please? Now I can't use authOpts field in Config struct in terraform-provider-openstack to pass system scope field. Is there any reason to be authOpts field private in struct?
Related PR  in terraform-provider-openstack https://github.com/terraform-provider-openstack/terraform-provider-openstack/pull/1517


add node clustering as argva example

Hi,
I added an example of node clustering using the ARGVA method. I thought due to this thread it could be useful.

Awesome. Thank you! I will have a closer look and merge ASAP.

Sorry it took my so long to review this one. I have nothing to complain :) Thank you a lot!


System.OutOfMemoryException when uploading large file

I am testing the maximum size of file that ModernHttpClient could handle. When I am trying to use this client to upload file that is 512MB on iPhone4s iOS 8.3 simulator, the app crashed with OutOfMemoryException.
error : System.AggregateException: One or more errors occurred. ---> System.OutOfMemoryException: Out of memory
  at (wrapper managed-to-native) object:__icall_wrapper_mono_array_new_specific (intptr,int)
  at System.IO.MemoryStream.ToArray () [0x00018] in /Users/builder/data/lanes/1503/13d1cdc2/source/mono/external/referencesource/mscorlib/system/io/memorystream.cs:589
  at ModernHttpClient.NativeMessageHandler+<SendAsync>c__async0.MoveNext () [0x0010e] in /Users/reeve/sandbox/ModernHttpClient/src/ModernHttpClient/iOS/NSUrlSessionHandler.cs:111

This is the line where the exception was thrown. It appears that the system doesn't have enough memory to convert the stream into an array. In the case, the stream should be equal or slightly larger than 512MB (since it is actually a MultipartFormDataContent Stream)
                Body = NSData.FromArray(ms.ToArray()),

The link below goes to the file that the line above come from.
https://github.com/paulcbetts/ModernHttpClient/blob/master/src/ModernHttpClient/iOS/NSUrlSessionHandler.cs#L101-111
When I was trying to look for a solution, I was end up on this stackoverflow question.
http://stackoverflow.com/questions/27427731/nsurlsession-createuploadtask-failure-with-xamarin-ios
The solution is to write the content stream to a temp file before creating the session task. Then I did a small change on SendAsync
var headers = request.Headers as IEnumerable<KeyValuePair<string, IEnumerable<string>>>;
string tempFile = Path.GetTempFileName();
using (var ms = System.IO.File.Open (tempFile,FileMode.OpenOrCreate)) {
	if (request.Content != null) {
		await request.Content.CopyToAsync (ms).ConfigureAwait (false);
		headers = headers.Union (request.Content.Headers).ToArray ();
	}
}

NSInputStream file = new NSInputStream (tempFile);

var rq = new NSMutableUrlRequest() {
    AllowsCellularAccess = true,
    /*Body = NSData.FromArray(ms.ToArray()),*/
	BodyStream = file,
    CachePolicy = (!this.DisableCaching ? NSUrlRequestCachePolicy.UseProtocolCachePolicy : NSUrlRequestCachePolicy.ReloadIgnoringCacheData),
    Headers = headers.Aggregate(new NSMutableDictionary(), (acc, x) => {
        acc.Add(new NSString(x.Key), new NSString(String.Join(getHeaderSeparator(x.Key), x.Value)));
        return acc;
    }),
    HttpMethod = request.Method.ToString().ToUpperInvariant(),
    Url = NSUrl.FromString(request.RequestUri.AbsoluteUri),
};

The code change successfully uploads a 512MB file on first gen iPad Mini.
But it looks kind of silly to have a temp file before sending out the actual content and it may not work on those devices that have very limited of storage...

You should directly use NSUrlSession's background upload, uploading a 500MB file using ModernHttpClient is a bad idea


[BUG] SetTagsAsync method sending 2 requests

Library name and version
Azure.ResourceManager.Resources v1.4.0
Describe the bug
I am using Azure SDK to set tags on a resource group. The code is fairly straightforward and it is working perfectly fine (the tags are being set properly) however when I see the audit logs, I see 2 requests being sent instead of 1.
First request is to delete the tags and the second request is to set the tags.

I am wondering why 2 requests are being sent when only 1 request should be sufficient.
Furthermore, this is going to create problems if I have locked the resource with "Delete" lock. This would prevent me from updating the tags because the 1st request which deletes the tag will fail.
Expected behavior
SDK should send just one request to update the tags. No need to delete existing tags before setting new tags.
Actual behavior
SDK sends two requests first to delete the tags and then the next one to update the tags.
Reproduction Steps
var client = new ArmClient(new DefaultAzureCredential());
var resourceId = "subscriptions/{subscription-id}/resourcegroups/{resource-group-name}";
var genericResource = armClient.GetGenericResource(ResourceIdentifier.Parse(resourceId));
var tags = new Dictionary<string, string>()
{
    {"tag-name-1", "tag-value-1"}
    {"tag-name-2", "tag-value-2"}
}
await genericResource.SetTagsAsync(tags);

Environment
OS - MacOS
.Net version 7

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@ArcturusZhang lets investigate whether or not we can optimize here for both performance and api counts.
I believe I remember early on that we took this approach because it was the most deterministic given some resources treat tags slightly differently and we wanted a common extension to all taggable resources.

We should not try to mitigate service behavior on client side

We should not try to mitigate service behavior on client side

@ArthurMa1978 , that is probably a good rule to follow but the current implementation can be quite surprising to the consumer. Besides the unexpected delete (that can conflict with locks, policies ...) the API/doc could be clearer that SetTagsAsync does not just set what is contained in the provided arguments but implicitly removes tag keys not passed to it. Yes, the doc states "Replace the tags ..." but we have seen multiple companies struggle with that at first.
As mentioned here there are also scenarios where policies could cause a situation where the resource looses all tags.
Exaggerating a bit: maybe the SDK shouldn't have a "replace tags" if ARM doesn't have that?
Thank you for looking into the issue!
I would love to have an "upsert-style" operation (setting many tags without the delete) to avoid having to SetTagAsync multiple times which might have bad performance characteristics or even cause inconsistencies should arm not immediately return a consistent state (shivers in Entra ID) when the SDK re-reads the existing values to add the single new value. And adding another sentence or two to the docs of the existing function, to ensure that the consumer is aware that tags will be removed if not provided and temporarily clear will happen, might be nice.

There is an expectation that SetTags/SetTagsAsync method are transactional - either all specified tags are updated or none of them.
https://github.com/azure-sdk/azure-sdk-for-net/blob/main/sdk/network/Azure.ResourceManager.Network/src/Generated/LoadBalancerResource.cs#L1109C1-L1114C140
Current, can cause a data loss if Delete succeeds, but CreateOrUpdate failed.
Having a Delete call is problematic if in scenario when resources have DoNotDelete lock - SetTags fails in this case even if we are not deleting any tags.
Thanks,
--Vladimir


Interactive Dictionary: Audio Pronunciation and Console Definitions

I'm always frustrated when I want to quickly learn the meaning of a word or phrase but have to look it up manually and read the definition. It would be much more convenient if I could just input a string and receive an audio pronunciation along with the text definition directly in the console.
I would like to create a Python project that allows users to input a string (a word or phrase) and then provides the following:
The text definition of the input in the console.
An audio pronunciation of the word or phrase played back to the user.
This can be accomplished using a dictionary API (like the Oxford Dictionary API or Merriam-Webster) to retrieve the meaning, and a text-to-speech library (like gTTS or pyttsx3) to generate the audio.
One alternative would be to create a simple GUI application that achieves the same functionality. However, I prefer a console application for its simplicity and ease of use. Additionally, using an online resource to fetch definitions might limit usability in offline scenarios, which could be another consideration.
The project could be structured as follows:
User Input: Use input() to take a string from the user.
API Call: Query a dictionary API to get the definition of the string.
Text-to-Speech: Use gTTS to convert the definition into audio and play it back.
Output: Print the definition to the console for easy reference.
This could be a useful tool for students, language learners, or anyone looking to expand their vocabulary quickly.

hey @DhanushNehru
I like to contribute to this ..


update rtd-pip-requirements to allow doc build

sometheing the docs are doing requires sphinx>=1.4.2.  There
was a bug in 1.4.1 that caused an error if a caption was not
supplied to TOC.  https://github.com/sphinx-doc/sphinx/issues/2465
added other requirements such that local build worked installing just
from rtd-pip-requirements from a blank conda env.

Coverage remained the same at 93.753% when pulling 6bd63683e117de7d21184512341e0c4f33890483 on justincely:rtd_fix into 1cc4d8210609f4c5d8a04b91c5cd92fc2f7d0b4e on spacetelescope:master.


Fixes in build.py for Windows

This should fix the builds on the Windows 10 VM

test this please

Oh, good catch! It seems to still not be working?

test this please

It's working on windows 10 now, but windows 7 is broken because I followed the recommended install process where python(x,y) is the prefered version of python. Python(x,y) is only 32 bit, so mosek must be 32 bit, but the build script is not setup to find the 32 bit mosek. I'm trying to fix that now.

@bqpd @whoburg all testing on the windows machines will fail until this is merged. Please review and adjust to your liking.
We will also need to reset the pylint warnings, as this is the last file with a bazillion of them...

@whoburg, I'm ready to merge this.

sounds good. @galbramc and I are going to fix some pylint errors before merging


TEST: Feature/weko3 new protocol

Codecov Report

Merging #8 (34e187a) into master (e7c83fa) will decrease coverage by 36.93%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
- Coverage   80.06%   43.13%   -36.94%
===========================================
  Files          23       23
  Lines        2573     2562       -11
===========================================
- Hits         2060     1105      -955
- Misses        513     1457      +944

Impacted Files
Coverage Δ

binderhub/repoproviders.py
35.48% <0.00%> (-46.95%)
:arrow_down:

binderhub/__main__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

binderhub/rdm.py
40.00% <0.00%> (-60.00%)
:arrow_down:

binderhub/builder.py
14.91% <0.00%> (-57.97%)
:arrow_down:

binderhub/registry.py
32.29% <0.00%> (-56.25%)
:arrow_down:

binderhub/launcher.py
30.35% <0.00%> (-50.90%)
:arrow_down:

binderhub/build.py
18.39% <0.00%> (-48.86%)
:arrow_down:

binderhub/oauth/provider.py
35.15% <0.00%> (-43.64%)
:arrow_down:

binderhub/health.py
39.16% <0.00%> (-43.34%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c83fa...34e187a. Read the comment docs.


add first class functions

@TheLoneWolfling could you take a look over this? I kind of went into a trance and clobbered through this to get it working so there might be some areas for improvement.

Interesting.
I went through the code. Mostly seems fine, though with a few bugs or potential bugs. Won't have a chance to actually compile / run it for a while, though.

Great! I'll go over each one of these and try to address all the issues. I think you're spot on about the execute.c function getting too big. One of the problems I had getting this to work was reasoning about what happens to the ast as it makes it through that massive function. I'll try to fix some of these issues as well as add some better organization before I merge this branch.

I've been playing with this branch and I've found the issue of managing scopes to be extremely tricky when dealing with first class functions. As a result I think I will close this PR until we have a better system for managing scope. Instead of doing FC functions I will try to do some of the organizational stuff to make the execute.c function clearer and less buggy. I will add the stack trace function to the main branch, though, because that's super useful.

Makes sense.
Perhaps we should open a bug for "scope issues" and go from there, then. I have a few ideas on the subject.


Bio::EnsEMBL::DnaDnaAlignFeature was referenced but not loaded (added us...

...e)

Oops wrong branch


Please update to 1.21.4 fabric

Please update to 1.21.4 fabric We're not waiting too long to play later

The mod works fine if you use a dependency override on 1.21.4


How much faster than original sadtalker?

Hi.
Thank you for your great work.
How much faster than original sadtalker?

Hi @BbChip0103 ,
Compared to the Colab demo that using a Tesla T4 from the original SadTalker, xtalker is 6~8 times faster in rendering on one Intel Xeon Sapphire Rapids CPU. The end to end speed is even more faster.

cool. thank you :)

is it faster than gpu?


Add checklist of cards to merge in merge dialog

Background / Story
Right now when we select "Merge my work" from the hamburger menu, it merges all cards that are have changes and are able to merge. Instead, we would like to give the user a checklist of cards to merge. The card should be displayed in the checklist if:

[ ] Card does not have any conflicts or errors
[ ] Card has changes (there exists a user branch for the card)
[ ] Card is read to merge

If these conditions are not true, the card should not be displayed in the checkbox. The user selects which cards on the checkbox that they would like to merge, and then when the user clicks "submit", ONLY those selected cards should have their changes merged to master. It would probably be helpful if the checkboxes were preselected, so that the user can unselect instead of having to select every one.
Implementation Tips (@jincypjose)
The MergeDialog component in transation-helps-rcl is where the checkbox should exist
The useMergeCardProps hook takes in the merge status for the cards and creates an object of lists of cards with erros, conflicts, those that are mergeable, etc.
This is where the information to use to create the checkboxes would be
Definition of Done

[ ] In the merge dialog, a checkbox list of mergeable cards is shown
[ ] A user is able to select and deselect which cards they would like to merge
[ ] When the user clicks submit, only the selected card changes are merged to master

In the merge dialog, a checkbox list for seven out of eight mergeable cards is shown. Text for translationWords Article line is not shown.

I wrote up a new issue about Cards Sync Feedback showing ugnt and uhb under Cards With No Changes To Save#510 and put it in QA fail.

Looks good in v2.1.0 build 66dd56e QA.  Resource cards that have edits saved, are listed when Merge my work is chosen from the Menu. Users can choose the resources by checking the boxes and those  user branch for those resources gets merged to master branch and gets deleted. The merged Resource is no longer available in the checklist until the next edits are done.

Checkbox list looks good, all eight mergeable cards are shown. Users are able to select and deselect which cards they would like to merge. Only the selected cards are merged to master, whether one, two, and etc. Tested with v2.1.0 build 66dd56e QA.


[Feature] Automated Greeting Workflow

Description:
I propose to implements a new GitHub Actions workflow named "Greetings," which automatically greets users who open new issues or pull requests in this repository.
Key Features:

Automatic Greeting: Users will receive an immediate acknowledgment when they create an issue or pull request. The messages are:

For Issues: "👋 Thank you for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned!"
For Pull Requests: "🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better."

Hey @Yashgabani845 please Assign me this Task

@samyak-aditya go ahead

Hey @Yashgabani845 I have raised the PR


Mark as read

The feature
Hi. Need useful function "mark as read" for calls and sms.
Please make a long tap menu on the call and sms icons "mark all calls as read", "mark all sms as read".
And logically, tap on a call to mark as read (now tap on a call and swipe to the right leads to dialing, at the same time a tap on an SMS expands the SMS and marks it as read, swipe to the right leads to the built-in application).

I'll add a "mark all as read" in the context menu. And since there is already the swiping right, I'll change the tapping logic to "mark as read", for both call and sms.

done. https://github.com/aj3423/SpamBlocker/actions/runs/11878520436


Parameter 'event' implicitly has an 'any' type

My project's typescript transpilation fails due to the following error:

node_modules/ng2-auto-complete/dist/auto-complete.directive.ts(92,31): error TS7006: Parameter 'event' implicitly has an 'any' type.

Can you please remedy this by explicitly declaring a type?  (event?: any)

Thanks for reporting this.
However, if you are using .js like the following, I don't know why this is happening

map['ng2-auto-complete'] = 'node_modules/ng2-auto-complete/dist';
packages['ng2-auto-complete'] = { main: 'index.js', defaultExtension: 'js' }

Made a pull request for this today which has been merged, I would guess this topic can be closed :)
And it probably happens because if you run tsc you are also compiling everything in the node_modules folder unless you do something about it. You should probably ignore the node_modules folder if you are using js files.

thanks @Kimpossibru


labels generated with bootstrap_form template tag does not have title attribute populated from model field's help_text

When using the bootstrap_form template tag, the generated label element does not get its title attribute populated from the help_text attribute of the corresponding model field. Whereas, it does work as expected for the bootstrap_label template tag.
This seems to be because the call to render_label inside the add_label method of the FieldRenderer class in renderers.py does not include a label_title parameter. Using the working call to render_label as guidance, filling out the parameter like so seems to do the trick:
label_title=escape(strip_tags(self.field_help))

@ned2 thanks for the issue report, are you able to open a pull request adding this change?

Apologies, but I don't think I'm in a position to at the moment. My plate is pretty full and my head is no longer in this space, having moved on from the project that came across this issue in.

Bump


Optimize load even further

coverage: 74.285% (+0.2%) from 74.111%
when pulling c2f101b2cfc7ebf8b8f9b75342f2a176e7d89c44 on optimize-load
into add89eca6252b752000914e984a24eb5dc730b49 on master.


Model config add param. to change directory

Would be cool if you could create a config for models, with which you can deposit the folder where the models drine should be created, if you (artisan make: model NAME) that those in the folder are:> sorry for my English.

There are many ways developers can use models with multiple locations. You can automatically store models in a directory (eg. App/Models) by extending the Model Command and add your own directory.

Hi there,
Welcome to Laravel and we are glad to have you as part of the community.
Unfortunately this GitHub area is not for ideas, suggestions etc. This is only for issues/bugs with the framework code itself.
I will be closing your ticket here. You are able to open a ticket at https://github.com/laravel/ideas
Alternatively you are able to open a PR using the Contributions guidelines: https://laravel.com/docs/5.7/contributions#which-branch
If you feel I've closed this issue in error, please provide more information about how this is a framework issue, and I'll reopen the ticket.
Thanks in advance.


nodeJS conversion

This is a general tracker for nodeJS conversion.
Advantages:

Extremely easy to deploy the app in Heroku and have it automatically build on push to master
Way more people here are familiar with JS than PHP (which as far as I can tell from the code we’re not using much)
Use routes instead of .htaccess
Easier to run locally (npm install followed by npm start)
Ability to use env vars for config
Dynamically grab data-${country).json files
Generate meta tags by location

Current outstanding tasks:

Get donation forms to work
Router for symlinks
Use template language for generating html
Grab data-${country}.json files from bucket
Enforce TLS
Update documentation

Working branch - #490

This also takes care of #465

So -- one further thought on this. Team Canada wants to add some more text to the landing page in a way that won't fit with existing headings, and talking about it with them and just thinking about it more, this sort of thing -- changing the landing page more than just changing text -- is likely to be needed across most if not all countries.
That alone seems like a pretty strong argument in favor of a templating engine. I think we could accomplish this with a Jekyll-based approach, too, but using Node and Handlebars (or some other templating engine) perhaps allows us to be a bit DRYer and fall-back to default content without duplicating it.

@ngottlieb I added express moustache last night, do you think that works well for us? Later today I was going to move the /config.js call to use the local variables + template instead as well

PR #495 has been merged and new site is now live in Heroku. Marking this as done.


Test data with qualifiers

The Translator Implementation Progress Tracker says KPs need to provide test data with qualifiers by 9/1.
I assume this means test triples, but I need to double check.

Yes. Also please see ARAX issue 1911 where I am doing some work to fix the test triples (though not for Biolink 3.0 specifically). I am doing that work in the master branch of the RTX project area.


TransactionPool: Remove TXs in batch queries

Speeds up block externalization by a lot. Something like from 40 secs to 80 msecs.

macOS green


Upgrade to FreeRTOS v9.0.0

After we have open_esplibs, we are able to upgrade to latest FreeRTOS.
Some function in libmain.a and libpp.a will call xTaskCreateGeneric, which has been removed in v9.0.0, so I wrote a proxy function to xTaskCreate in port.c. It can be remove after all reverse engineering works are done.
Another difference is the type of parameter pcName in xTaskCreate and xTimerCreate is const char * const instead of signed char *.

\o/ nice work! Ping #80 where an upgrade was previously discussed.
Interesting that so few places in the code actually needed changing. I'm guessing the compatibility headers take care of a lot of it at compile time? There's probably clean up we can eventually do in port.c, etc., to update to the latest APIs.
Can you confirm if this line definitely didn't need changing: https://github.com/SuperHouse/esp-open-rtos/blob/master/open_esplibs/libmain/timers.c#L74 Though we should probably fix that regardless, given it's such a hack.
How much testing have you done? I'm interesting in merging in this, but as it's a big change it'd be ideal if a few people can put it through its paces before we pull it in.

Angus and sasdf what do you suggest? I can help on testing this.
Best regards,
Rodrigo Peixoto.
On Tue, Jul 26, 2016 at 10:13 AM Angus Gratton<EMAIL_ADDRESS>wrote:

\o/ nice work! Ping #80
https://github.com/SuperHouse/esp-open-rtos/issues/80 where an upgrade
was previously discussed.
Interesting that so few places in the code actually needed changing. I'm
guessing the compatibility headers take care of a lot of it at compile
time? There's probably clean up we can eventually do in port.c, etc., to
update to the latest APIs.
Can you confirm if this line definitely didn't need changing:
https://github.com/SuperHouse/esp-open-rtos/blob/master/open_esplibs/libmain/timers.c#L74
Though we should probably fix that regardless, given it's such a hack.
How much testing have you done? I'm interesting in merging in this, but as
it's a big change it'd be ideal if a few people can put it through its
paces before we pull it in.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SuperHouse/esp-open-rtos/pull/169#issuecomment-235262906,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACJ0OYrAc2LR489EkN9viQ46TYa6Seuks5qZgfmgaJpZM4JRSy_
.

@rodrigopex , great! @sasdf  may have some other suggestions, but for now I'd suggest testing this as much as you can and letting us know what you find.

@projectgus , I have no idea about the line in timer.c, sorry.
I haven't done any test, but it works for my project.
Basic things like tasks, semaphore, queue, notification, uart ,and socket works fine.
@rodrigopex , Thanks for your help!

Gave this a test with the wificfg and an app I am working on and it seems to be running ok. Not extensive testing but it seems to run ok, and tested the AP and Station modes. A few changes were needed:

some more uses of xTaskCreate() in the examples needed updating to cast the task name to (const char * const).

In FreeRTOS.h need to change to #include <FreeRTOSConfig.h> to get the per-project FreeRTOSConfig.h override file included first.

Is that enough confidence to merge this now.
Did anyone else have any freeback?

Thanks @sasdf, @ourairquality and everybody who helped testing this. The PR is merged with https://github.com/SuperHouse/esp-open-rtos/pull/245


make basecalling optional

P24 basecalling time <<< local, so if basecalling is performed already (with an appropriate model) we shouldn't repeat this. As this might not include modifications, these rules should be optional #138

this is optional and automatically defined


Relicense under dual MIT/Apache-2.0

Hi @alkorang,
Thanks for your contributions! I've merged them into my repository.
However, I'd like to change the license from Apache-2.0-only to a dual MIT/Apache-2.0 license, which is standard in the Rust community. See the Rust FAQ and https://github.com/sfackler/rust-postgres-macros/issues/19 for an in-depth discussion.
If you don't have any objections, please post your consent with:
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Best,
Clemens

I have no objection for this relicensing, so I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.
I never expected that you would merge my commits into yours. Thanks! ;)

Great, thank you! Then I'll go ahead and perform the relicense.


Uncaught Error: spawn /opt/atom/atom (deleted) ENOENT

Uncaught Error: spawn /opt/atom/atom (deleted) ENOENT
Atom Version: 0.152.0
System: linux 3.13.0-40-generic
Thrown From: Atom Core
Steps To Reproduce

...
...

Stack Trace
At events.js:85

Error: spawn /opt/atom/atom (deleted) ENOENT
  at exports._errnoException (util.js:742:11)
  at Process.ChildProcess._handle.onexit (child_process.js:1051:32)
  at child_process.js:1142:20
  at process._tickCallback (node.js:378:11)

Just ran into this issue.
I had one instance of atom open for a few days with lots of open tabs in it. Then I started another instance of atom (via the command line) but for a different project and that's when the error kept popping up. Closed both instances and now the error is gone when I start atom again.

I get this too. With multiple projects open, it happens every time I switch focus to that window.
As previously suggested, it does seem to only happen when opening new windows after atom has been open for awhile. If I start fresh, opening two windows together, neither will encounter this.

Happening for me.
I just opened a second folder with another window open with another folder open.
Happens everytime I click in the new window.
Went away after I closed all atom windows and reopened atom.
I am on Ubuntu 14.04 with atom 0.177.0

Atom Version: 0.177.0
System: linux 3.16.0-30-generic
Thrown From: Atom Core
Stack Trace
Uncaught Error: spawn /opt/atom/atom (deleted) ENOENT
At events.js:94

Error: spawn /opt/atom/atom (deleted) ENOENT
  at exports._errnoException (util.js:753:11)
  at Process.ChildProcess._handle.onexit (child_process.js:1051:32)
  at child_process.js:1142:20
  at process._tickCallback (node.js:364:11)

Commands
     -5:36.9 snippets:next-tab-stop (atom-text-editor.editor.autocomplete-active.is-focused)
     -5:36.9 snippets:expand (atom-text-editor.editor.autocomplete-active.is-focused)
     -5:36.9 editor:indent (atom-text-editor.editor.autocomplete-active.is-focused)
     -5:35.1 snippets:next-tab-stop (atom-text-editor.editor.autocomplete-active.is-focused)
     -5:35.1 snippets:expand (atom-text-editor.editor.autocomplete-active.is-focused)
     -5:34.5 core:save (atom-text-editor.editor.autocomplete-active.is-focused)
     -4:28.3 core:copy (atom-text-editor.editor.autocomplete-active.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "git-blame",
      "minimap",
      "terminal-status",
      "welcome",
      "git-log",
      "git-log",
      "git-log",
      "git-log",
      "git-log",
      "feedback",
      "exception-reporting",
      "atom-html-preview",
      "open-on-search-engine",
      "ask-stack",
      "Search",
      "atom-runner",
      "script",
      "linter-pep8",
      "linter-pylint"
    ],
    "themes": [
      "atom-light-ui",
      "imperator-day-syntax"
    ],
    "audioBeep": false,
    "autoHideMenuBar": true
  },
  "editor": {
    "fontSize": 17,
    "showInvisibles": true,
    "autoIndentOnPaste": false,
    "tabLength": 4,
    "softWrap": true,
    "softTabs": false,
    "softWrapAtPreferredLineLength": true,
    "invisibles": {
      "eol": " "
    },
    "zoomFontWhenCtrlScrolling": false
  }
}

Installed Packages
# User
atom-color-highlight, v3.0.8
autoclose-html, v0.15.0
autocomplete-paths, v1.0.2
autocomplete-plus, v2.1.4
autohide-tree-view, v0.12.0
color-picker, v1.4.4
compare-files, v0.4.0
file-icons, v1.4.9
git-tab-status, v1.5.3
highlight-selected, v0.7.0
imperator-day-syntax, v0.0.0
linter, v0.11.1
linter-pylama, v0.0.15
preview-tabs, v0.1.6
project-manager, v1.15.5
pulsing-cursor, v0.3.0
python-isort, v0.0.5
tabs-to-spaces, v0.8.1
zentabs, v0.7.1

# Dev
No dev packages

Atom Version: 0.180.0
System: linux 3.13.0-45-generic
Thrown From: Atom Core
Stack Trace
Uncaught Error: spawn /opt/atom/atom (deleted) ENOENT
At events.js:94

Error: spawn /opt/atom/atom (deleted) ENOENT
    at exports._errnoException (util.js:753:11)
    at Process.ChildProcess._handle.onexit (child_process.js:1051:32)
    at child_process.js:1142:20
    at process._tickCallback (node.js:364:11)

Commands

Config
{
  "core": {
    "autoHideMenuBar": true,
    "themes": [
      "atom-light-ui",
      "base16-tomorrow-dark-theme"
    ]
  },
  "editor": {
    "invisibles": {},
    "fontFamily": "monaco",
    "fontSize": 13
  }
}

Installed Packages
# User
color-picker, v1.4.4
docblockr, v0.5.8
javascript-snippets, v1.0.0
jshint, v1.2.0
tasks, v1.2.4
web-browser, v1.3.0

# Dev
No dev packages

I just got this and it totally spammed with an error every 10 seconds or so (Ubuntu 14.04.2 LTS).
Since it seems to complain about a file `atom (deleteid) doesn't exists, I did this to silence it (which seems to have been successful) although I don't know the impact it might have:
sudo cp /opt/atom/atom "/opt/atom/atom (deleted)"

Happened to me also after dpkg -i the 0.187.0 version over already installed 0.186.0.
Following @noseglid, did a ln -s /usr/share/atom/atom "/usr/share/atom/atom (deleted)" to remedy.

Happened to me on Windows

Same here :( someone have a soft solution?

Fixed by https://github.com/atom/notifications/pull/62


Can't see geojson or shapefiles while creating new source

(Not sure if it is the good place to post this request for assistance, sorry if it's not !)
Mapbox Studio Classic 0.3.2. doesn't display the vector files I'm importing while creating a new source : there isn't any error message and it acts as if everything was doing ok, except that i can't see the file. It happens with both geojson and shapefiles. I tried to play with zoom levels, to change the CRS, to save, to refresh, nothing changes.
Here are some example files I'm working with : http://we.tl/wydgW075hp
Thanks for your help !

@JeremyG
Works for me.
When adding data with a small spatial extent you might want to manually pan and zoom to the area where you data is located.
Or use the search button (magnifying glass) to do so:

Great, now I can find it indeed. I didn't think about searching for the area, as I thought the software would automatically center the map view on the features of the layer (this could actually be considered as a feature request for MSC... I'll look for existing tickets about it).
Thanks a lot @BergWerkGIS !

I thought the software would automatically center the map view on the features of the layer

Yeah, you are right, this feature is broken at the moment.
Clicking on the symbol left to the layer name should zoom to the layer extent.
Working on it: https://github.com/mapbox/mapbox-studio-classic/issues/1487


Multiple recaptcha to the single page

Can you explain me, how to add multiple recaptcha to the single page in the nuxt js project? I have a form called BaseForm, it's the single file component, that used multiple times in the parent component.

Just in case anyone else has this issue: I also had two recaptcha v2s on the same page and made it work by using the v-if directive. I'm basically conditionally rendering each component based on their visibilty in my UI. So like they're on different tabs for example and check which one is visible.
...
<recaptcha v-if="visible" />
...

Thank you, pretty interesting solution, but I used google reCaptcha v3 by using CDN, It worked for me now...

I have multiple visible recaptchas on the same page and I'm dealing with this issue as well


Arriving and Leaving Home Automations

Arriving home if at night time should trigger the lights, leaving home should trigger them no matter what, if they're turned on.

Leave home, what should happen automatically?

turning off lights
turn off my fan
turn off my tv
turn off chromecast -> service "turn off"
arm alarm system

Arriving home, what should happen automatically?

always:

disarm alarm system
turn on tv
switch source to default
switch source to hyla

if nightime:

turn on lights

if outdoor temperature > 35 degrees celcius

turn on fan


How do I install the plugin?

Hello.
cordova plugin add path or git address
(node:7544) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): CordovaError: Invalid Plugin! C:\Users\thfql\Documents\ng2_start\serialtest\plugins\cordova-plugin-serialport needs a valid package.json (node:7544) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future,  promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
I tried to install it. But the wrong plug-in!have been printed out of
I want to install this plug-in.

cordova plugin add https://github.com/izee/cordova-plugin-serialport.git

cordova plugin add https://github.com/izee/cordova-plugin-serialport.git

I use codeova 8.0.0
The command fails to operate. npm err.
I did it myself.
It works right.
I've been through many failures.
But it succeeded.
Thank you for your answer.

This plug-in is not registered in npm.
That's why I can't install In Cordova 8.
I moved to my plugin folder.
And then modified config.xml and package.json.
to config.xml
<plugin name="cordova-plugin-serialport" spec="./plugins/cordova-plugin-serialport" />
to package.json
    "plugins": {
      "cordova-plugin-whitelist": {},
      "cordova-plugin-statusbar": {},
      "cordova-plugin-device": {},
      "cordova-plugin-splashscreen": {},
      "cordova-plugin-ionic-webview": {},
      "cordova-plugin-ionic-keyboard": {},
      "cordova-plugin-serialport": {}
    },
    "platforms": [
      "android"
    ]
  }


Update log_tags.md

Proposed changes
Update log_tags documentation to correct url to logging context

Yup, looks good. Thanks, @tauffredou !


no encodedText error in padchat-decode.ts

Wechaty version
<EMAIL_ADDRESS>npm: wechaty@next
Error: no encodedText
    at Object.padchatDecode (/Users/jiaruili/git/xiaoju-bot/node_modules/wechaty/src/puppet-padchat/pure-function-helpers/padchat-decode.ts:4:11)
    at PadchatManager.<anonymous> (/Users/jiaruili/git/xiaoju-bot/node_modules/wechaty/src/puppet-padchat/padchat-rpc.ts:702:64)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/jiaruili/git/xiaoju-bot/node_modules/wechaty/dist/src/puppet-padchat/padchat-rpc.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:160:7)
decode error data:  undefined
16:21:19 WARN PadchatRpc WXGetChatRoomMember(9486025987@chatroom) result.member decode error: Error: no encodedText

Hi @zixia , is this issue still going on?

I'm not sure about whether it's still going on or not...
I'd like to if we did not meet this error in a week, then we could close this issue.

Close this issue because this had not been seen for a long time.

Thanks for track this issue :)


Firefox PDF Viewer Bad Rendering of Lowercase e

foo1.pdf
foo2.pdf
Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Mozilla Firefox for Ubuntu canonical-1.0
Operating system and its version: ubuntu 18.04 linux
PDF.js version: ? built into firefox
Is a browser extension:

Steps to reproduce the problem:

view foo1.pdf with firefox

foo1.pdf and foo2.pdf are produced from the same latex file, the first with lualatex and the second with pdflatex

foo1.pdf uses LMRoman12-Regular Type 1C (CID) font Embedded subset

foo2.pdf uses CMR12 Type 1 Embedded subset

foo1.pdf renders badly unless magnified to 150%

foo2.pdf renders just fine

foo1.pdf renders properly in other pdf viewers (chrome builtin viewer, linux pdf viewer)

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

FontForge shows that the middle part of 'e' has two horizontal stem hints that are touching each other. They are not overlapping, so font validation in FontForge doesn't report them as an error. The lower one (y = 213, height = 19) is superfluous and pointless because there is no actual stem in the glyph path at those positions. It seems that some font rendering engines have problems with these hints. The Type1 version of the font has no hinting problems like this.

FontForge shows that the middle part of 'e' has two horizontal stem hints that are touching each other. They are not overlapping, so font validation in FontForge doesn't report them as an error. The lower one (y = 213, height = 19) is superfluous and pointless because there is no actual stem in the glyph path at those positions. It seems that some font rendering engines have problems with these hints. The Type1 version of the font has no hinting problems like this.


Training scripts?

Can you share the training scripts?
Contributing on the models would be much easier then!

I believe it's in https://github.com/nickwalton/AIDungeon/blob/master/generator/simple/finetune.py
The author said he had 80MB of training data but there's only 30 here, though.

@Akababa apparently that's the old version. The code is using this gpt2_generator.py to generate the story. That's a custom version of GPT2.
I don't think the training scripts are in the repo tho :/
Hope @nickwalton will reply to this!

I'm also curious about what the role of > characters is in the training! Interesting to see if we can improve on finding a point to end generation.

It's basically a token to tell the model that the text following is a prompt :)

I'll try and clean up this code when I get more time. But as @Akababa said I did actually train with generator/simple/finetune.py and then just moved the model to the gpt2 folder. I thought I had said I only used 30 MB of training data? If I spoke wrong point me to where and I'll fix it.
@Akababa It's mostly used to indicate to the model that you just used an action. It also helps me cut off the text before the model generates a new action instead of just story.

@nickwalton Oh I see, it was this comment on HN. I must have misread 8000000 as 80MB.
I noticed all the training data starts with "You", does this help? What happens if you remove the preprocessing from the training data and the prompts?

I did notice that adding "You" helped, but you would probably be able to
get good performance without it.
On Fri, Dec 6, 2019 at 9:07 AM Michael Pang<EMAIL_ADDRESS>wrote:

@nickwalton https://github.com/nickwalton Oh I see, it was this comment
https://news.ycombinator.com/item?id=21717621 on HN. I must have
misread 8000000 as 80MB.
I noticed all the training data starts with "You", does this help? What
happens if you remove the preprocessing from the training data and the
prompts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nickwalton/AIDungeon/issues/20?email_source=notifications&email_token=AFJNOQGYAK2O4O4CX2CRDM3QXJ2E7A5CNFSM4JWYNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGER2ZA#issuecomment-562634084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFJNOQES3PKNO77NLI3SIE3QXJ2E7ANCNFSM4JWYNKLQ
.

Training data has been removed due to copyright issues.


Problems with parsing values where Cyrillic characters are present

Problems with parsing values where Cyrillic characters are present
Got a problem when parsing a file where the values of the keys are strings with Cyrillic characters
https://github.com/jimmiebergmann/mini-yaml/blob/22d3dcf5684a11f9c0508c1ad8b3282a1d888319/yaml/Yaml.cpp#L1460

I have the same exception thrown when trying to use extended ASCII such as "à" or á etc
Simply comment the for loop and it's working.
                // Validate characters.
                // for (size_t i = 0; i < line.size(); i++)
                // {
                //     if (line[i] != '\t' && (line[i] < 32 || line[i] > 255))
                //     {
                //         throw ParsingException(ExceptionMessage(g_ErrorInvalidCharacter, lineNo, i + 1));
                //     }
                // }


[3.2] Cylinder support in Godot Physics 3D

Backport of cylinder support from Master.
Includes #45854 and #45931.

Thanks!


Do you plan to release this on npm?

More background here. I'm currently using samsa-core installed through package.json and imported in the files accessing the SamsaFont method. Its possible to call the library from a direct github reference, but an npm release would be useful for others.

Someone else asked about this a while ago. It’ll happen.

Hi @kontur, @rememberlenny: can you advise the best way to make this happen?

Hey @Lorp I've only published one package myself, but it's rather straight forward. You need an npm account and the publishing and updating happens straight from the console via npm commands. You already have a package.json, so it's just getting it registered to npm. This should be an exhaustive guide.
That would make installing code to other projects more easy, and doesn't enforce any kind of module or other structure to the package per se. The other day I've tried to use Samsa standalone to parse and extract some SVGs, with moderate success. The standalone sample with the linked files works, but I couldn't get it to work when importing e.g. to a browserify/babel compile pipeline. I'll try that some more next week and report back (in a separate issue) if that yields some other suggestions on how to make your excellent code more reusable — also quite likely I just don't know how to properly set it up :D I do think though that samsa-core has some globals floating around that are then missing when importing the module to projects.


Unidentified Error Appears in Ubuntu Version 14

I got different result in ubuntu 18 and 14. Everything running well in version 18. But I got this error below when using same version in ubuntu 14, is it really related with OS version ?:
istributor ID:	Ubuntu
Description:	Ubuntu 14.04.5 LTS
Release:	14.04
Codename:	trusty
Opts:
const options = {
  credentials: cred,
  fallback: true,
};

no such type: google.rpc.ErrorInfo
    at Root.lookupType (./example/node_modules/.pnpm/registry.npmjs.org/protobufjs/6.10.2/node_modules/protobufjs/src/namespace.js:382:15)
    at FallbackErrorDecoder.decodeProtobufAny (./example/node_modules/.pnpm/registry.npmjs.org/google-gax/2.10.2/node_modules/google-gax/build/src/fallbackError.js:35:32)
    at ./example/node_modules/.pnpm/registry.npmjs.org/google-gax/2.10.2/node_modules/google-gax/build/src/fallbackError.js:50:56
    at Array.map (<anonymous>)
    at FallbackErrorDecoder.decodeRpcStatus (./example/node_modules/.pnpm/registry.npmjs.org/google-gax/2.10.2/node_modules/google-gax/build/src/fallbackError.js:50:37)
    at FallbackErrorDecoder.decodeErrorFromBuffer (./example/node_modules/.pnpm/registry.npmjs.org/google-gax/2.10.2/node_modules/google-gax/build/src/fallbackError.js:63:46)
    at ./example/node_modules/.pnpm/registry.npmjs.org/google-gax/2.10.2/node_modules/google-gax/build/src/fallback.js:323:57
    at processTicksAndRejections (internal/process/task_queues.js:97:5) with message no such type: google.rpc.ErrorInfo

any clue about this ?

@prakasa-tkpd are you using the pnpm command line to install the project?
Could I bother you to try with npm, as this error actually looks like it might be related to an installation error.

@prakasa-tkpd closing this issue since I haven't heard back from you.
Were you able to get things working using npm?


A question about datamapper

For demo, The UserEntity only basic types Member variable And it‘s easy to transform. If it contains other objects，What's the best solution?

@blackguardMask you can add extra dependencies in your constructor (mappers) which will convert these objects. eg.
@Inject
public Mapper(Mapper1, Mapper2) {
}

Of course you should think if it's reasonable to do it. eg. if you have just a small object I don't think that it worths to create a whole new mapper for this but this is a personal preference.

@spirosoik Well, it looks like i have to think about it.Thank you for your answer and forgive me for my poor English.


Bug in deleting rows.

This is vanilla kilo, with only one patch:
 diff --git a/kilo.c b/kilo.c
 index 9490a77..207e297 100644
 --- a/kilo.c
 +++ b/kilo.c
 @@ -37,6 +37,7 @@
  #define _BSD_SOURCE
  #define _GNU_SOURCE

 +#include <time.h>
  #include <termios.h>
  #include <stdlib.h>

Open the attached file rename it t.c beforehand, so that the syntax highlighting is enabled.
Delete  10+ lines from the middle.
Move to the bottom of the file.
Delete a few rows.
Segfault.

Backtrace shows that we die with bogus row values:
 Core was generated by `./kilo t.c'.
 Program terminated with signal SIGSEGV, Segmentation fault.
 #0  0x0000000000401462 in editorRowHasOpenComment (row=0x16c5e90) at kilo.c:361
 361 - 41    if (row->hl && row->rsize && row->hl[row->rsize-1] == HL_MLCOMMENT &&
 (gdb) bt
 #0  0x0000000000401462 in editorRowHasOpenComment (row=0x16c5e90) at kilo.c:361
 #1  0x00000000004015fd in editorUpdateSyntax (row=0x16c5620) at kilo.c:395
 #2  0x0000000000401da7 in editorUpdateRow (row=0x16c5620) at kilo.c:566
 #3  0x00000000004024e5 in editorRowAppendString (row=0x16c5620,
     s=0x16c4a70 "", len=0) at kilo.c:668
 #4  0x00000000004028ea in editorDelChar () at kilo.c:750
 #5  0x0000000000403d6c in editorProcessKeypress (fd=0) at kilo.c:1197
 #6  0x0000000000403f5c in main (argc=2, argv=0x7fffaf038a38) at kilo.c:1270
 (gdb) p row->size
 $1 =<PHONE_NUMBER>
 (gdb) p row->rsize
 $2 =<PHONE_NUMBER>
 (gdb)

Suspect, given the nature of the crash that editorRowDelChar, or editorDelRow are to blame.  Either the memcpy is going wrong such that the size become pointers, or something else is corrupting them.
"Video" here for a clearer picture -  https://asciinema.org/a/6ou2c1lmofuzedery5mjx7kf3
This is affecting my fork in a different way, but we'll keep that quiet.
t.c.txt

https://github.com/antirez/kilo/pull/20/commits
Take a look at this, it's fixed in this PR.

Confirmed.  This commit resolves this problem.
Cheers.


Add RecyclerView support

Hi thanks for your great library. I have built all my list based on RecyclerView , i am sure many developers use this View extensively. It would be great if you add this functionality to this lib.
With regards.

It seems that it's a need as well, I'll consider this and try to implement when I find spare time. Thanks.

I appreciate your time and effort.

thanks for your , if support RecyclerView it will be better


add translated  meta-scrum guide article

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

@freeCodeCamp/portuguese-language-editors This PR now needs to be reviewed for the translation content.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Skunk sends all arguments to tracing/logging

We observed, in production, Skunk sending all query/command arguments to our tracing backend (Honeycomb). We also observed Skunk sending arguments to our logging backend (Datadog) when the query/command failed with a Postgres exception (e.g. unique constraint violation). This leaked sensitive data to those backends, requiring manual deletion.
As a basic example, when executing UPDATE users SET sensitive_data = $text WHERE user_id = $uuid Skunk would send the actual values for the sensitive_data and user_id columns to the tracing backend, in the bind trace's arguments field.
We put together a small example demonstrating both argument leaks. The readme and the code contain more details.
While we were able to mitigate the leaks in our case by essentially disabling tracing/logging for Skunk, we were unable to find a systematic way to disable sending arguments to tracing/logging in Skunk. Skunk provides much useful tracing/logging data, and it would be great to retain that, while preventing arguments from leaking.

It's hard to know what to do here since it's often very useful to know the exact arguments when an error occurs. They are also reported in exceptions. An option would be to add something to Encoder to indicate that the arguments shouldn't be logged, like WHERE data = ${text.redacted} and then have the logging mechanisms use an encoder method that respects the redaction request.

Adding a redacted method to Encoder seems like a good solution.

One thing that isn't quite clear from my description above, but which is included in the linked example repo, is that something inside Skunk (or a dep?) is printing exceptions that occur inside transactions directly to stderr/stdout. This doesn't happen when the exception occurs outside of an explicit transaction. We read through much Skunk code, and could not identify where this printing originates.
That said, exceptions (hopefully) occur rarely in production. Arguments are exposed to tracing on every database operation, successful or failed (modulo sampling). It would be great to be able to disable or configure that.

@zcox That's likely due to an uncaught exception in a fiber, which cats-effect then logs. If we can find the offending fiber, we could fix via .voidError or something similar.

Fixed in #900 which is available in Skunk 1.0 release candidates.


Make autogen ID loading work with custom type

An attempt to fix #2615.
Besides of fixing the issue, this PR changes/fixes the behavior of Ecto.Repo.__schema__(:autogenerate_id) when it comes to custom type ID.
defmodule MyUUID do
  @behaviour Ecto.Type
  def type(), do: :binary_id
end

defmodule Post do
  use Ecto.Schema

  @primary_key {:id, MyUUID, autogenerate: true}

  schema "posts" do
    # fields eaten by the Internet.
  end
end

The current behavior of the API returns {:id, :id, :binary_id}. This PR changes it to {:id, :id, MyUUID}.
IMHO this behavior is more correct, but we could come up with another fix if this change is not desired.

@qcam it looks perfect to me. Let's tidy this up and merge it. :heart:

@qcam we also need to change this line to call the new function you added in Ecto.Type.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

I will change it locally as I want to use this opportunity and normalize the autogenerate API between schemas and adapters. :)


[MM-27864][MM-27865] Telemetry for Cloud Onboarding

Summary
Telemetry for Cloud Onboarding
NOTES:

There's no telemetry for the End-User Tips and Next Steps screen, looks like it was missing from the document
The 'Download Apps' button doesn't show up on mobile, so there's only mac or windows desktop app.

Ticket Link
https://mattermost.atlassian.net/browse/MM-27864
https://mattermost.atlassian.net/browse/MM-27865

@devinbinnie can we cherry-pick this to cloud-beta?


STL-test doesn't build on "clean machine"

On my VirtualBox ubuntu I'm getting this:
~/IncludeOS/test/STL/ $ ./test.sh
...
 [ Kernel ] Starting IncludeOS basic STL test
================================================================================
*** Testing STL Basics - must be verified from the outside ***
   [ Test STL ] The following two lines should be identical, including newline
	printf and std::endl yields the same output
	printf and std::endl yields the same output
   [ Test STL ] Expect Integer 1-3 to be printed
                [x] Integer 1
                [x] Integer 2
                [x] Integer 3
   [ Test STL ] Call a std::function lambda immediately
                [x]  Lambda is called
   [ Test STL ] String to c-string conversion
                [x] std::string to c-string conversion works
service.cpp:56: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 5u for 5 == 5
service.cpp:57: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 5u for 5 >= 5
service.cpp:63: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 10u for 10 == 10
service.cpp:64: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 10u for 10 >= 10
service.cpp:56: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 5u for 5 == 5
service.cpp:57: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 5u for 5 >= 5
service.cpp:71: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 0u for 0 == 0
service.cpp:72: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 5u for 5 >= 5
service.cpp:56: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 5u for 5 == 5
service.cpp:57: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 5u for 5 >= 5
service.cpp:79: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 5u for 5 == 5
service.cpp:80: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 10u for 10 >= 10
service.cpp:86: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 10u for 10 >= 10
service.cpp:56: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 5u for 5 == 5
service.cpp:57: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 5u for 5 >= 5
service.cpp:94: passed: Scenario: vectors can be sized and resized[vector]: v.size() == 5u for 5 == 5
service.cpp:95: passed: Scenario: vectors can be sized and resized[vector]: v.capacity() >= 5u for 5 >= 5
service.cpp:107: passed: Scenario: Maps have basic functionality: map_of_ints.size() == 2 for 2 == 2
service.cpp:108: passed: Scenario: Maps have basic functionality: map_of_ints["First"] == 42 for 42 == 42
service.cpp:109: passed: Scenario: Maps have basic functionality: map_of_ints["Second"] == 43 for 43 == 43
All 2 selected tests passed.
   [ Test STL ] SUCCESS
--> TEST SUCCESSFUL: Basic STL test
qemu: terminating on signal 15 from pid 3826

But on trident1 I'm getting build errors due to not finding e.g. pthreads:
>> Compiling the service
clang++-3.6 -target i686-elf -mstackrealign -msse3 -O2 -Wall -Wextra  -c -m32 -std=c++14 -fno-stack-protector -I/home/alfred/IncludeOS_install/libcxx/include -I/home/alfred/IncludeOS_install/api/sys -I/home/alfred/IncludeOS_install/newlib/include -I/home/alfred/IncludeOS_install/api -I/home/alfred/IncludeOS/test/STL/../lest/include/lest -I -D_LIBCPP_HAS_NO_THREADS=1  -o service.o service.cpp
In file included from service.cpp:27:
In file included from /home/alfred/IncludeOS_install/libcxx/include/iostream:38:
In file included from /home/alfred/IncludeOS_install/libcxx/include/ios:216:
In file included from /home/alfred/IncludeOS_install/libcxx/include/__locale:18:
In file included from /home/alfred/IncludeOS_install/libcxx/include/mutex:176:
/home/alfred/IncludeOS_install/libcxx/include/__mutex_base:31:5: error: unknown type name 'pthread_mutex_t'
    pthread_mutex_t __m_;

Steps to reproduce? Well..... when you know that the issue is solved :-)

Found it: It's the stray -I here: https://github.com/hioa-cs/IncludeOS/blob/master/src/seed/Makefile#L43

Shouldn't the seed use the Makeseed makefile anyways?

It does

Yes, it's for mac. It breaks it for you?

Workaround: remove that trailing -I from your local IncludeOS_install/Makeseed, i.e.
diff --git a/src/seed/Makefile b/src/seed/Makefile
index 176d00d..1c8dc7f 100644
--- a/src/seed/Makefile
+++ b/src/seed/Makefile
@@ -40,7 +40,7 @@ ifndef LD_INC
 	LD_INC = ld
 endif

-INCLUDES = -I$(INC_LIBCXX) -I$(INSTALL)/api/sys -I$(INC_NEWLIB) -I$(INSTALL)/api -I$(LOCAL_INCLUDES) -I
+INCLUDES = -I$(INC_LIBCXX) -I$(INSTALL)/api/sys -I$(INC_NEWLIB) -I$(INSTALL)/api -I$(LOCAL_INCLUDES)

 all: CAPABS  =  $(CAPABS_COMMON) -O2
 debug: CAPABS = $(CAPABS_COMMON) -O0

So we can't have both :apple: and :pear: ?

I guess it went pear shaped


[Issue-584] Update doc to have the right table of content

Signed-off-by: thekingofcity<EMAIL_ADDRESS>Change log description
Update doc to have the right table of content.
Purpose of the change
Fixes #584
What the code does
Indent list in doc with 4 spaces.
How to verify it
.\gradlew clean mkdocsBuild have the right tabe.

Before:

After:


[animation] scene render time always 0 during animation

render time bottom right should be updated for each frame of the animation

not sure if you caught the issue that got fiexed in the meantime, or you used examples that cache mesh.
cached mesh is very fast and could easily give you zero render time.
here is example with random segment count and slow anim.
https://3d.hrg.hr/jscad/anim/#data:application/gzip;base64,H4sIABlxsmYAA4VSwW7bMAy9+yuIXmxnWuJm6w4GAmzHHAb0sFvRg2AzjQZZ1CiqTWH430fbWXbsSST1nh75qI5CEvidOtvDARj/ZMdYld+Xym6gHr0LL2VdrMARvXcxkesnhS+gbWQ3OHGvmP6BmMQKGhC2IXkN/4OX0ol4SMUV3dnujLP4DV09NaYx982zualVI9ve5dQ+3c83Zt88T/WtqcfjLPDTyrnY7UDeCASTbMCFmCWBZYScVEMIEiKc6Q28facsoJ1A8q5HhpNTKMlZwyuvOOXQiaMAg3WhGvXt1ZfP0bLVCWDR+YUXOc6MQ2lLMxcPjVHsj+AGu9BHeY/Y3q1CdwYGF9pGD3tp9waSYGybbbPX0imm9kFPr3a2wllNtFkoiWW55p4otiXjK3LCclI9JR0eTDHVoyYeRYd8GTDoBKspW6Yc+urL/tOa2dDTUNWbb19rJTBK5gDrzmbrH48bMR+Yr11fNeY1TEWhPyV73OIlEi/C4+zZ9BeGIm/hXwIAAA==


Add LLama.cpp

I am New to this but I want one feature to be added that is Lama.cpp or any open source LLM so that we can be free from openai api 🗝
just a feature and too I want to help you all in setting up a perfect tags so that it is neat and please give me a roll to handle that.
I loved this project.

You can achieve that by setting the baseurl on the openai package


Vuex store state emptied on reload when using vite

Environment
From the codesandbox
------------------------------
- Operating System: `Linux`
- Node Version:     `v14.18.1`
- Nuxt Version:     `2.16.0-27272174.ab1c6cb4`
- Package Manager<EMAIL_ADDRESS>- Bundler:          `Webpack`
- User Config:      `bridge`, `buildModules`
- Runtime Modules:  `-`
- Build Modules:    `<EMAIL_ADDRESS>------------------------------

Describe the bug
When using vite with nuxt-edge and bridge, it seems the store state behaves inconsistently.
Setting bridge: { vite: true } causes the store state to be as expected on first page load, but after reloading the store state is empty. Triggering a server rebuild by changing content causes the store state to be set on the next page load, but reloading the page returns and empty store state again.
Setting bridge: { vite: false } cause the store state to behave as expected, the store state contains the values on every page load.
Reproduction
https://codesandbox.io/s/nervous-sunset-277b7?file=/pages/index.vue
Additional context
No response
Logs
No response

Do you still encounter this? I can't now reproduce with your sandbox: https://codesandbox.io/s/epic-elion-siyj7d

Testing both sandboxes the bug occurred as described on Chrome (Version 106.0.5249.103), yet on Firefox (Version 105.0) the store was empty from the get go, all done on Ubuntu 20.04.5 LTS.


App crashing after reload

When reloading the app with CMD + D, this is logged to the console: Invalidating RCTSampleTurboModule...
Then, if I receive an event, it's crashing with the following error:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Error when sending event: onEvent with body: {
channelName = shows;
data = "[]";
eventName = "App\\Events\\RefreshShows";
userId = "<null>";
}. RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter.'
*** First throw call stack:
(
0   CoreFoundation                      0x00000001803f3d70 __exceptionPreprocess + 236
1   libobjc.A.dylib                     0x000000018019814c objc_exception_throw + 56
2   Foundation                          0x000000018075b6c0 -[NSMutableDictionary(NSMutableDictionary) classForCoder] + 0
3   projectname                               0x0000000100978000 -[RCTEventEmitter sendEventWithName:body:] + 400
4   projectname                               0x0000000100ca81fc $s29pusher_websocket_react_native26PusherWebsocketReactNativeC8callback4nam<…>

Anyone encountered this issue?
Expo: 46.0.16
React Native: 0.69.6
pusher-websocket-react-native: 1.1.0

Thanks, I'm investigating this issue, there seem to be many plugins having this issue googling the error.

Hi, I am experiencing the same issue with @Spharian .
So the issue occur, after reloading the app. Either pressing R or cmd + D and then reload. And after that, I tried sending an event and it gives me an error the same with Spharian.
Thread 1: "Error when sending event: onEvent with body: {\n    channelName = \"my-channel\";\n    data = \"Test 3 after reload\";\n    eventName = Feedback;\n    userId = \"<null>\";\n}. RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter."

Is this still an issue with 1.1.1 ?

Is this still an issue with 1.1.1 ?

I am having this issue now on version 1.1.1 :(

Could it be some kind of race condition? If you connect to pusher a bit later does the error still occur?

I am also getting the same issue

Issue still occur at version 1.1.1 :(

Made a PR with the fix:
https://github.com/pusher/pusher-websocket-react-native/pull/55
enjoy!

Any progress on this?

Experiencing the same error :(

I am using expo and redux to dispatch incoming messages. Logging the event works but when I try to dispatch I get this error.
RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter.

Is there any update to this? Seems a lot of the community are experiencing it and it's quite interrupting to the usual dev experience.

@Braden1996 We've just released 1.2.1 and I couldn't reproduce this issue. Could you please update it?

@fbenevides I'm on 1.2.1 and I still receive an error on iOS.
It happens nearly every time I switch to another app on the iPhone, while running the react-native project.
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Error when sending event: PusherReactNative:onConnectionStateChange with body: {
    currentState = disconnected;
    previousState = connected;
}. RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter.'
 RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter.'

@Braden1996 We've just released 1.2.1 and I couldn't reproduce this issue. Could you please update it?

This seems to have resolved the issue for me 🥳

@jacobmolby we can't reproduce this: is there a particular app you're switching to that causes this, or all apps in general? We have a theory that there is a name conflict with another RN app.

@jacobmolby we can't reproduce this: is there a particular app you're switching to that causes this, or all apps in general? We have a theory that there is a name conflict with another RN app.

I've since the same error as @jacobmolby in our Sentry monitoring, but haven't reproduced it personally.

I am getting similar issue, after I reload the app and trying to subscribe right after.
libc++abi: terminating with uncaught exception of type NSException
terminating with uncaught exception of type NSException
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Error when sending event: PusherReactNative:onConnectionStateChange with body: {
    currentState = connecting;
    previousState = reconnecting;
}. RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter.'

I have the same issue, I'm using version 1.2.1
 RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter.'

Still having the same issue, I'm also using version 1.2.1
Your app just crashed. See the error below.
NSInternalInconsistencyException: Error when sending event: PusherReactNative:onConnectionStateChange with body: {
    currentState = disconnected;
    previousState = connected;
}. RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in PusherWebsocketReactNative, even though it's inherited from RCTEventEmitter.

I'm also experiencing the same issue on version 1.2.1 when I have Flipper on and I receive an event. I use Hermes and I'm on React Native 0.71.3.

Still happening for me also :(

Same issue :(

Has this been figured out yet?

It doesn't seem to be figured out. And this is becoming very very annoying for my users complaining about crashes...

Love paying $50 a month for this issue that has been open for half a year.

Someones else on the team started working with our mobile-app recently.
Gentle reminder to please look into and fix this issue 🙏

This has been escalated internally for review, i'll update as we get more information.

Hi everyone, also running into the same issue. My guess, as initially mentioned by people in the team, is that reloads are causing Pusher to init again and again despite already being connected. I want to share a quick patch that is working for me for now. I connect to Pusher on a useEffect call in my root component. What I do to prevent it from crashing is just to check whether Pusher is connected already or not. So roughly:
  useEffect(() => {
    const connectToPusher = async () => {
      const pusher = Pusher.getInstance();
      try {
        if (pusher.connectionState !== "CONNECTED") {
          await pusher?.init({
            apiKey: "X",
            cluster: "X",
            authEndpoint: `X`,
          });

          await pusher?.connect();
        }
        await pusher?.subscribe({
          channelName: "test",
          onEvent: () => {
            console.log("Test event");
          },
        });
      } catch (e) {
        console.log(`ERROR: ${e}`);
      }
    };

    connectToPusher();
  }, []);

The one caveat is that this only works on "soft" reloads, that is, reloads caused by a change in code. Hard reloads will still cause this to crash, since the connection state is lost.
Just in case this helps while the team works on a fix, since this was driving me crazy as well.

This has been escalated internally for review, i'll update as we get more information.

Do you have any updates regarding this? Months are going by with no resolution in-sight. It serious hinders our ability to use Pusher.

We're not seeing this nearly as often after updating to React Native 0.71. Not sure if it's 100% related, but I haven't seen the problem since we updated to Expo 48/RN 0.71. Anyone else notice a change there?

I'm using :
"@pusher/pusher-websocket-react-native": "^1.2.1"
"expo": "~48.0.18"
"react-native": "0.71.8"

and I'm still experiencing crash with this

I'm using :
"@pusher/pusher-websocket-react-native": "^1.2.1"
"expo": "~48.0.18"
"react-native": "0.71.8"

and I'm still experiencing crash with this

Same here with @pusher/pusher-websocket-react-native 1.2.2.
Could you please do something @fbenevides @benw-pusher?

It's almost a year and there is no fix ? and you are charging such high prices for a service that cause app to crash ? please at least do a little effort and reply to us.

Has anyone noticed if this happens the same amount with production builds as it does with development builds? It happens for me pretty much anytime the user comes back to the app after using another app.. how is anyone using this in production?

Has anyone noticed if this happens the same amount with production builds as it does with development builds? It happens for me pretty much anytime the user comes back to the app after using another app.. how is anyone using this in production?

I am using it in production as a matter of fact. We've had a lot of issues, with end-users complaining. The majority of issues were solved with the last commits. Now crashes have significantly diminished. However, those commits are currently in master branch, but not in 1.2.2 release
@fbenevides @benw-pusher  could you please make a new release?

@swaaj are you using a forked version to include those commits?

Yes I had no other choice :
   "@pusher/pusher-websocket-react-native": "https://github.com/swaaj/pusher-websocket-react-native.git",

I will nudge the team to create a new release including the last few commits.

Is this could be solved this weekend ? we are about to publish a mobile app to production and we need to know if we're going to use pusher or try another solution

I will nudge the team to create a new release including the last few commits.

Well, there are only few commits, but the one made only couple of days after the last release (4 moths ago) seems to be a real saviour what comes to crashes with iOS when developing the app. In practice, the app crashes every time a message is received after refresh.
@benjamin-tang-pusher please release?

@swaaj We just released 1.2.3 version.


Publish this as public sonar plugin

Self-titled, thanks !

Hi,
For the moment, the plugin is not fully compatible with Sonar 5.3. We still need to make code duplication detection work.
We will make it available as public when ready.
I think it will be public soon.


Replace links to Wiki "char count page" with links to Content page #char count section

Related Ticket(s)
{{Provide url(s) to the related ticket(s) that this pull request addresses}}
Description
Currently, many instance of the links to "Character count standards" is still to the github wiki page. Now that the Character count is published under Content page, we can make all references to char count to that content page instead.
Changelog
Changed
Replaced all:
https://github.com/carbon-design-system/carbon-for-ibm-dotcom-website/wiki/Character-count-standards
With:
https://www.ibm.com/standards/carbon/guidelines/content#character-count-standard

@shixiedesign see my other ticket https://github.com/carbon-design-system/carbon-for-ibm-dotcom-website/pull/1273.
The heading of the Content standards section should be plural and I missed that in my review last week. I updated all the links here and committed directly to save you the time and because they're non-controversial. ;)


var,return=isize gives wrong result on strided axis

If an axis has been strided with SET AXIS/STRIDE=  it should behave as the shorter axis everywhere.
This means that strides in LAS can be applied to gridded data for plots in the correlation viewer.


Unexpected token, Menu at 11:1

./node_modules/rmwc/Menu/index.js
Module parse failed: Unexpected token (11:1)
You may need an appropriate loader to handle this file type.
Using the default CRA, error occurs when importing e.g. a Toolbar, but it seems to appear whenever i import anything from rmrc.

Webpack seems to need the file to be using es5, I fixed the problem by importing from 'lib/rmwc' like so
import {Button} from 'rmwc/lib/rmwc';

But this doesn't seem right at all, can you make the index.js contain 'lib/rmwc'?

Sorry about that @foreggs, I need to add some documentation around the behavior. This is related to #20
TLDR: include node_modules/rmwc with your webpack babel-loeader (node_modules is usually ignored)

Currently, the package is published to NPM with ES6 code
Google's MDC required that the components be structured in a way that can be consumed al-a-carte so it's setup to import the ES6 components directly
The lib version is a UMD compiled bundle, so it's babelfied and compressed down to ES5 so it's safe for consumption like you're doing
If you'd like to import the way that you're referencing, you just need to add nodule_modules/rmwc to the babel-loaders include.
This is hot on my list of items to fix, just a minor annoyance right now.

@foreggs Ah, just caught that you're using CRA, extra annoying, if you haven't run eject you'll need to use something like react-app-rewired to modify the babel config. I'll see about getting this fixed in the next few days. Thanks for trying out the project, sorry for the hiccup.

@foreggs, The issue is resolved in 0.0.1-beta7. After you update it should all work as expected, no extra configuration required.


Create a test fixture that is duplicate of TUFTestFixtureSimple but with only the root.json file on the client

To simulate a client starting with only a root.json we should make a fixture that is identical to TUFTestFixtureSimple except it only has the root.json file.
I marked this as "good first issue" because the python may be simple. I am just learning python so I could be wrong so feel free to ignore that.
This probably a 2 step issue, 1 in python and 1 in php. It doesn't have be done by the same person the PR for 1) should be first:

update generate_fixtures.py create the new fixture. I could see this being done 2 ways(probably someone whos python better than me could decide).

Either by making a new class or that extends TUFTestFixtureBase, and maybe then TUFTestFixtureSimple would extend this new class
or just manually copying the created TUFTestFixtureSimple directory and removing every file except
fixtures/TUFTestFixtureSimple/tufclient/tufrepo/metadata/current/root.json

We may want all of non-attack fixtures to have a root.json only version so this second way may be better

Update \Tuf\Tests\Client\UpdaterTest::providerRefreshRepository()   to test the new fixture folder.

This was fixed in #164 🎉


[ Feat ]: Pass a pre-read FormData object via context.

When I try to read FormData (for validation or something else) in action I get an error
FetchError: Invalid response body while trying to fetch http://localhost:5173/login: Invalid state: ReadableStream is locked
login.tsx
export async function action ({ request }: ActionFunctionArgs) {
  const formData = await request.formData()
  const type = formData.get('type') as string

  if (!type) {
    return json({ message: 'Type is required' }, { status: 400 })
  }

  const successRedirect = type === 'form' ? '/account' : '/verify'

  await authenticator.authenticate(type, request, {
    successRedirect,
    failureRedirect: '/login',
    context: { formData }
  })
}

As a solution, I added simple checking if we have already passed formData via options
private async _readFormData(request: Request, options: AuthenticateOptions) {
    if (request.method !== 'POST') {
      return new FormData()
    }

    if (options.context?.formData instanceof FormData) {
      return options.context.formData
    }

    return await request.formData()
  }

Hello @themkvz.
This does not look like a "fix" to me; instead, it seems more like a personal case or issue you are handling.
We used to have an example on how to handle errors with remix-auth, sadly removed some time ago. If you can look into remix-auth and how to handle errors, probably you can find some examples (if that's your issue).
Can you please provide more details of your case and the overall Pull Request and how it will affect the repository?

Also, I would suggest fixing the indentation, as it seems to not be the one originally provided by the repository. Our current prettier config could help with it.

Thoughts on this issue @mw10013?

@themkvz: Thank you for the PR. remix-auth-totp is designed to take in a pristine request. We're cautious about providing another mechanism to convey the formData so as not to add more complexity to the API.
I wonder if Request.clone() may be helpful for your use case (https://developer.mozilla.org/en-US/docs/Web/API/Request/clone). Please share your thoughts.
It is curious to see logic in the action of your login route that may redirect to an /account route. Upon success the login action would generally redirect to a verify route so that the user can input the totp code as in the example project snippet below.
https://github.com/dev-xo/totp-starter-example/blob/4f14dbc1696a81827f2708a88e1e16beec176edc/app/routes/login.tsx#L26-L39

Thank you for your response!
@dev-xo I will revert pnpm-lock.yaml. Which indents do you mean? My VSCode uses your . prettierrc config, with "tabWidth": 2 and "singleQuote": true
@mw10013 I use multiple forms on a single remix page following the next way https://sergiodxa.com/articles/multiple-forms-per-route-in-remix (using hidden input with name="type"), I need two forms because, in my Login page, I have two auth methods/strategy (authenticator.use(totpStrategy, "TOTP").use(formStrategy, "form");) – first is a traditional method with user email and user password, and second one is your based on the magic link.
Depending on the filled form we need to pass the correct type to authenticator.authenticate
Provided solution with a pre-read FormData object I use from this package https://github.com/sergiodxa/remix-auth-form?tab=readme-ov-file#passing-a-pre-read-formdata-object

@themkvz: Thanks for providing more color on your use case. It is helpful and compelling.
Can you add a test for this? Also, a small section at the end of docs/customization.md explaining that this exists and why you might need it. Thanks!

Any news on this @themkvz? Otherwise I think we can close it for now, and get back to it later at some point.

Any news on this @themkvz? Otherwise I think we can close it for now, and get back to it later at some point.

I have already added two simple tests and I plan to add a short section with an explanation in the docs

Thanks @themkvz, happy to know this is still active. Take your time and let us know when we can review it.

Not sure if the tests were already added, or you added them after; in my case, I wasn't notified.

@dev-xo I've added the brief description to the README.md
Before pushing I ran format script (pnpm run format) and I see some additional changes in README.md, if it is a problem – let me know
About test:
I've already added two short tests

To be clear @themkvz, your current issue (and PR) could be solved by cloning the request like request.clone()?

Also, will we now imply that passing a pre-read FormData to the authenticate method will be required, right?

All good @themkvz.
I was wondering if we could simply document this in the docs, letting users know that if they are looking to handle multiple auth strategies or validate the form, they could simply clone the request.
Ideally, the simpler we keep the strategy, the fewer bugs we could introduce, and the easier it will be to maintain it.

I'll leave this decision to @mw10013, as he probably has more insights on how useful this could be overall.

I appreciate the efforts in improving the strategy and making it simpler for everyone else to handle this situation or similar ones, so thank you!

All good @themkvz.
I was wondering if we could simply document this in the docs, letting users know that if they are looking to handle multiple auth strategies or validate the form, they could simply clone the request.
Ideally, the simpler we keep the strategy, the fewer bugs we could introduce, and the easier it will be to maintain it.

I'll leave this decision to @mw10013, as he probably has more insights on how useful this could be overall.

I appreciate the efforts in improving the strategy and making it simpler for everyone else to handle this situation or similar ones, so thank you!

Yeah, sure, it will be maybe the best way to post this possibility in the docs
I had some struggle when I got the next error FetchError: Invalid response body while trying to fetch http://localhost:5173/login: Invalid state: ReadableStream is locked :)

@themkvz: Thanks for the additions. We'd like to proceed with this. I ran gh pr checkout 60 locally and made a few local edits that I want to push to your PR with git push https://github.com/themkvz/remix-auth-totp.git HEAD. I'm getting
 ! [remote rejected] HEAD -> themkvz/main (permission denied)
error: failed to push some refs to 'https://github.com/themkvz/remix-auth-totp.git'

Can you grant me permission? Thanks.

Reverted it back, as it was not squashed and the whole history commit was cluttered with small unnecessary commits.

Will try to merge it back as a squashed commit.

Otherwise, I will open a PR myself with the updated changes and push it.

#64 Squashed & Merged.
Let me know if this settles the issue for you @themkvz. Also, thanks for the contribution! 👍🏻


[opentitantool] Leave IOC5 and IOC8 unconfigured

When third parties test their software on OpenTitan ASIC development boards, they are probably going to have their .json configuration file, declaring which pins are used for input or output in their code, in order to allow HyperDebug to properly stimulate and verify behavior.
Such a file would probably include /__builtin__/hyperdebug_cw310.json, in order to be able to refer to e.g. IOA0 when declaring aliases and pin configurations.
Since IOC5 and IOC8 can be used as GPIO when they are not used as TAP_STRAPn, and since opentitantool does not have a concept of one .json file "overriding" configuration from another .json file, it becomes a problem to declare the two pins as PushPull and level: false in the built-in opentitan.json (which is in turn included from hyperdebug_cw310.json), as that would conflict with any third party declaration of the two being input, or defaulting to high level.
Instead, this PR lets the two pins remain unconfigured, except when either of the named strappings PINMUX_TAP_LC or PINMUX_TAP_RISCV are explicitly applied by test scripts.

Since all CI tests pass, I assume that every piece of code that uses JTAG already explicitly applies one of the two TAP strappings.
It seems safe then, to remove the "default" configuration of the IOC5 and IOC8 pins, leaving it open to additional third-party configuration files how almost every GPIO should be configured at boot.

Thanks for thinking of the nightly tests.  It seems that a few related tests including  //sw/device/silicon_creator/rom/e2e/shutdown_watchdog:shutdown_watchdog_dev_200000_fpga_cw310_rom_with_fake_keys is failing.  However, when I try running the same test on ToT locally, I also get timeout.
If I jump bank to a random earlier commit 0a25f2d66694f19b91677b62912b2d1895e436f8, then the test passes, and when I put this PR on top of that earlier commit, the test still passes.
This leads me to believe that the nightly test failure is unrelated to this PR.

Yes, you are right, these tests have been failing for a while as you can see here, So we are safe to merge this PR.

It's a bit surprising since I had fixed shutdown_watchdog but that was before the move to the new rules so I wonder if something was undone during the conversion. I'll try to have a look this week.


Add e2e test to ensure changing dnsNames on an ACME certificate triggers a re-issue

What this PR does / why we need it:
Ensures it's possible to update dnsNames on a certificate in order to trigger a re-issuer of a certificate.
Which issue this PR fixes: fixes #294
Release note:
NONE

/assign @kragniz

Closing in favour of #744


[FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

What is the purpose of the change
1.Allow UDF & UDTF to access constant parameter values at getReturnType, see similar feature in hive: https://hive.apache.org/javadocs/r2.2.0/api/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.html#initializeAndFoldConstants-org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector:A-
2.Allow AggregateFunction to decide its user define inputs types with argClasses.
According this: https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html
this pr is binary compatible with:
Adding new fields, methods, or constructors to an existing class or interface.
Moving a method upward in the class hierarchy.
Inserting new class or interface types in the type hierarchy.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)

But now UDF is in table-common, how to move those changes to flink-table-planner-blink?

@JingsongLi why not putting CustomTypeDefinedFunction into flink-table-planner-blink for now and adding a compatibility wrapper in Blink's table environment that bridges between Flink current function design and Blink function design. I guess Blink has to do that in any case as the type system is different so far.

@JingsongLi why not putting CustomTypeDefinedFunction into flink-table-planner-blink for now and adding a compatibility wrapper in Blink's table environment that bridges between Flink current function design and Blink function design. I guess Blink has to do that in any case as the type system is different so far.

@twalthr Our current blink merge strategy does not change the user interface type. We only introduced InternalType, which is only used in internal computing and CodeGenerator, while udf, source, sink and others still use TypeInformation. So I think this change should have nothing to do with the Type system. The change is enhance the parameter of getResultType, not the return type(still use TypeInformation). And it's compatible, so I prefer table-common instead.

Merging this change to flink-table-common would introduce instant legacy as we are also thinking about dropping the existing getResultType methods and add proper operand type inference and return type strategies, similar to how Calcite functions work. I understand the necessity of this change but I would postpone it a little bit until we have a full type system picture.

@JingsongLi I think we could postpone this until the type rework been done, just as @twalthr suggested. For blink's merge, we can temporary disable or comment out the codes which plays with these APIs, and add them back after we have a conclusion for this.

Merging this change to flink-table-common would introduce instant legacy as we are also thinking about dropping the existing getResultType methods and add proper operand type inference and return type strategies, similar to how Calcite functions work. I understand the necessity of this change but I would postpone it a little bit until we have a full type system picture.

I see what you mean. It makes sense.