(Feature) - Expanded decoded data collapses automatically

Closes #1693 by:

Adding shouldSafeStoreBeUpdated within UPDATE_SAFE reducer to avoid updating the safe in the case that the values didn't changed which would fire unnecessary renders of the entire app. This happens because most of the values of the safe object are arrays or nested objects that could be the same but the reference is different and it's treated as a different value
Also on checkAndUpdateSafe avoids adding featuresEnabled if the array didn't changed

How it was before:

How it's now:

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/volta/app

Checked that the "Actions" display doesn't closes with the new rendering of the table
Same with modals that opens from the table,  like the one that confirms/rejects a tx or the "Send again" option
The table itself keeps re-rendering just fine, the status of the tx still update just fine, the executor tag keeps showing, the green dots keeps filling.
Looks good to me

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1731--safereact.review.gnosisdev.com/volta/app


feat: add feature flag to run cost optimizer in current aws region only

Issue #, if available:
In our aws accounts some regions are not available / blocked by SCPs.
An exception occured when the cost optimizer tried to search for aws workspaces in regions and blocked the whole solution from running.
Description of changes:

Added flag to only run the cost optimizer in the region where aws cost optimizer has been deployed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This feature has been pushed out in release v2.4.0


NEED DARK MODE SUPPORT!!!!!!!!!1!!

 IT IS TERRIBLE

Please put hair on the website like this cheese
https://i.redd.it/esh9aggfp5f91.jpg


[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

This is a follow-up to https://github.com/Homebrew/brew/pull/10229 which adds the ability to complete files where appropriate.
A few commands (bottle, ruby, sh, and style) accept files as named arguments. This PR will now enable automatic file completion for these commands. Note that this is only available in newer versions of bash, so I've added a conditional making the __brew_complete_files a no-op unless the compopt command exists. I've tested using builtin /bin/bash (no compopt command so no file completions) and Homebrew's /usr/local/bin/bash (with compopt and file completions).

Review period will end on 2021-01-20 at 04:58:03 UTC.

Review period will end on 2021-01-20 at 04:58:03 UTC.

Nice work again @Rylan12!

Note that this is only available in newer versions of bash

Which versions, out of interest?

Nice work again @Rylan12!

Note that this is only available in newer versions of bash

Which versions, out of interest?

Which versions, out of interest?

The compopt command was added in version 4.0. Apple's built-in bash is verion 3.2

Which versions, out of interest?

The compopt command was added in version 4.0. Apple's built-in bash is verion 3.2

Review period ended.

Review period ended.


Ability to pick specific checks to be run against a PR

Add the ability for a developer to select a subset of checks to be run against a PR.

Can you please provide a use case for it? Would this proposal still require all the applicable tests before merging?

I can think of a few:

I'm working on a draft PR, and I'd like a faster iteration cycle where I only run N checks I know might be impacted
I'm working on a final PR, and I'd only like to run N checks (ignoring other flaky or unrelated checks)
I want to introduce new check(s) that won't run on CI by default and let people opt-in to running them


[header] Inconsistency with alignment for headings and content

Is this a BUG REPORT or FEATURE REQUEST?:
bug?
What happened:
We currently center all fragments except for footer text and content text on smaller screens. Within the content fragments it looks a bit weird as markdown headers are left aligned too.
Anything else we need to know?:
Should we center the content text too?
Or should we left align headers for content fragments?
Any other ideas?
Example:

@stp-ip What do you think?

Oh wow I think that comment didn't make it through my mentions.
Mhh how about we leave it open for now and revisit this in another release?
In my view this is an inconsistency that should be fixed even in edge cases. But it might not have a high priority. My general idea would be to have the margin gone, when it's left aligned, but might need more thinking.
Maybe we'll get more ideas with more pages migrated or using Syna.

Fixed: #531


[WIP] Add all previous version of smirnoff99Frosst and test conda-install

Status

[x] All previous versions now present simultaneously
[x] Package is conda-installable from omnia
[x] Confirmed that current toolkit can read all conda package contents

For proof:

conda install -c omnia/label/rc smirnoff99frosst -c omnia openforcefield
python -c "from openforcefield.typing.engines.smirnoff import ForceField ff = ForceField('smirnoff99Frosst-1.0.9.offxml')"

[x] Table of FF-to-DOI added to README

Status

[x] Ready for review
[ ] Ready for merge

@davidlmobley Good idea -- I've updated the README with an example of loading an OFFXML using the OFF toolkit, and another that accesses the entry point directly.


x/sys/unix: Getdirentries not found on darwin arm with Go 1.11

What version of Go are you using (go version)?

$ go version
go version go1.11.13 darwin/amd64

Does this issue reproduce with the latest release?
No
What operating system and processor architecture are you using (go env)?
go env Output
I'm using gomobile targeting darwin on arm

What did you do?
Compile a program that calls Getdirentries for darwin arm (32 bit) with Go 1.11
What did you expect to see?
Successful compilation
What did you see instead?
readdirent_getdirentries.go:18:9: undefined: Getdirentries
I think this was broken by the fix for #34400

@tklauser

@tklauser That fix LGTM.


Create a short tutorial on how to use the reflection API to query explicit bindings of global parameters.

Is @tangent-vector  working on this?

Closing this one. Tess's doc is great and covers this one.


focus object issue once uses touch

Hi All,
I have two problems when I created an object once touch is pressed:

I am using both touch and hardware keyboard. I have a Start btn and once btn is pressed I want to display an mbox with tow btns on it (cancel and ok). I'd like to have cancel btn selected once mbox is created . This is fine when I pressed the Start btn using the hardware key  (mbox is created and cancel is selected) but once I use touch to press the Start btn, somtimes none of the mbox btns is selected.
Is there anyway to know which btn is selected in mbox at the time of creating mbox?
Also I have to freeze the mbox for a while otherwise it won't be the focused object while I added it to my group and focused it ( this is fine with keypad also) .

Hi,
Please send an example code to reproduce the issue.

Hi, sure . I need to create a simple example to demonstrate that , probably I would find some time by weekend , please don't close the issue.

Hi @kisvegabor
Here is my code:
static lv_res_t mbox_apply_action(lv_obj_t * mbox, const char * txt)
{
printf("Mbox button: %s\n", txt);
return LV_RES_OK; /*Return OK if the message box is not deleted*/

}
static lv_res_t btn_click_action(lv_obj_t * btn)
{
uint8_t id = lv_obj_get_free_num(btn);
/Called when a button is clicked/
lv_obj_t * mbox1 = lv_mbox_create(lv_scr_act(), NULL);
lv_mbox_set_text(mbox1, "Default message box\n"
                        "with buttons");                    /*Set the text*/
/*Add two buttons*/
static const char * btns[] ={"\221Apply", "\221Close", ""}; /*Button description. '\221' lv_btnm like control char*/
lv_mbox_add_btns(mbox1, btns, NULL);
lv_mbox_set_action(mbox1, mbox_apply_action);
lv_obj_set_width(mbox1, 250);
lv_obj_align(mbox1, NULL, LV_ALIGN_IN_TOP_LEFT, 10, 10); /*Align to the corner*/
lv_group_add_obj(activeGroup, mbox1);
lv_group_focus_obj(mbox1);

return LV_RES_OK; /*Return OK if the button is not deleted*/

}
void test_freez_problem() {
mainMenuKeypadOpsInit();
mainGroup = lv_group_create();
activeGroup = mainGroup;
lv_indev_set_group(kb_indev, mainGroup);
/Create a normal button/
lv_obj_t * btn1 = lv_btn_create(lv_scr_act(), NULL);
lv_cont_set_fit(btn1, true, true); /Enable resizing horizontally and vertically/
lv_obj_align(btn1, NULL, LV_ALIGN_IN_TOP_MID, 0, 10);
lv_obj_set_free_num(btn1, 1);   /Set a unique number for the button/
lv_btn_set_action(btn1, LV_BTN_ACTION_CLICK, btn_click_action);
lv_group_add_obj(mainGroup, btn1);
/Add a label to the button/
lv_obj_t * label = lv_label_create(btn1, NULL);
lv_label_set_text(label, "1");
lv_obj_t * btn2 = lv_btn_create(lv_scr_act(), btn1);
lv_obj_align(btn2, btn1, LV_ALIGN_OUT_BOTTOM_MID, 0, 10);
lv_obj_set_free_num(btn2, 2);               /Set a unique number for the button/
lv_group_add_obj(mainGroup, btn2);
/Add a label to the toggled button/
label = lv_label_create(btn2, NULL);
lv_label_set_text(label, "2");
lv_obj_t * btn3 = lv_btn_create(lv_scr_act(), btn1);
lv_obj_align(btn3, btn2, LV_ALIGN_OUT_BOTTOM_MID, 0, 10);
lv_obj_set_free_num(btn3, 3);               /Set a unique number for the button/
lv_group_add_obj(mainGroup, btn3);                    /Add to the group/
/Add a label to the toggled button/
label = lv_label_create(btn2, NULL);
lv_label_set_text(label, "3");
lv_group_focus_obj(btn1);
}
When I press OK key on btn1 , mbox is focused while once I touch the btn1 , mbox is created but btn1 is focused again. Here is the screenshot:

Sorry no responding. Somehow I wasn't notified about your comment.
What is mainMenuKeypadOpsInit? I don't see the implementation of this function in your example code.
Anyway, lv_group_set_click_focus(group, false) should solve the issue. By default. if you click an object it will be focused too.

As the proposed solution should solve the issue I close it. If it's not working, please reopen it and comment here.


Move BellSoft.LibericaJDK8 8.0.272.10 to BellSoft.LibericaJDK.8 8.0.2…

…72.10

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I see; Looks like this was already fixed in #31359


Expiration_date in Contracts API appends UTC, conflicts with documentation

The documentation for POST Contracts ( https://gist.github.com/drwasho/bd4b28a5a07c5a952e2f )  reads:
expiration_date=[UTC]
 - Sormatted string
 - The date the contract should expire in string formatted UTC datetime
 - Example:
 - -  "2015-11-01T00:00 UTC"
 - - “” if the contract never expires

But the api source code for creating the object actually appends the " UTC" suffix.
https://github.com/OpenBazaar/OpenBazaar-Server/blob/de9a97f44fd8059fed3115acafae03207584f1ca/market/contracts.py#L175
So following the example in the instructions gives:
"2015-11-01T00:00 UTC UTC"
And that gets displayed by the OB-Client as no expiry (which is correct, with that duplicate UTC in the suffix it becomes an invalid UTC date.)
So I don't know if the issue is in the documentation (i.e., example should not include " UTC" suffix), or in the handling of the API request.   Just reporting that following the documentation provides incorrect results.
OpenBazaar version: v0.2.0 (and master)
Reproducible: Always
Steps to reproduce:
1.
$ python additem.py       # See attached
Observed Behavior:
Contract ID: [contract_id]
Expiry after: 2015-11-01T00:00 UTC UTC

Expected Behavior:
Contract ID: [contract_id]
Expiry after: 2015-11-01T00:00 UTC

Additional info:  additem.py script, saved as .txt since github doesn't support .py attachments.
additem.py.txt

Treating an invalid date as meaning no expiry is also a serious silent-failure issue.


fix: upgrade pino pretty to v9.1.1

This PR forces the upgrade of pino-pretty to v9.1.1, resolving the problems discussed in https://github.com/pinojs/pino-webpack-plugin/pull/54
Closes https://github.com/pinojs/pino-webpack-plugin/pull/54
cc: @simoneb

@simoneb yes, on local environment now tests are working.
I checked it before opening the PR


Maze env: out-of-grid goal location?

I cannot have goal locations (shown as red dot) contained within the maze. Is this a bug of the environment?

This actually happens to ALL pointmass maze environments.

It seems like this is a just cosmetic issue that happens the first time you call render. If you call render in a loop, the first image looks like this and the subsequent images look fine.
I wasn't able to fix this by setting the target marker position on the first render, so I'm not sure if there is an easy fix. If it's causing other problems please re-open this issue.

Was this issue ever resolved?

Nvm I was having trouble with showing the correct position for the red marker, and calling set_marker() helped!


fix cmake minimum

Close https://github.com/conan-io/hello/issues/3

This repo is not maintained anymore, closing as won't fix


The Add Cloud button is unresponsive when creating an import for CSV.

I have the latest commit (master fc06a85).  The Add Cloud button is unresponsive when creating an import for CSV.  However if I save the importer and then come back to edit it, Add Cloud works.
This is in my Hyrax application.  Browse Everything is configured properly and working for 'Add Work'.

thank you for reporting it and for characterizing the issue. I'll have a look in the next day or two

@orangewolf, I have the same issue, I look the code and find three html elements with the same ID, mayba that explain this problem...


Error is not handled if HTTP response does not accomodate to WSDL schema

In case SOAP service returns a response which doesn't mach with WSDL schema we'll get unhandled error. In versions prior to 0.7 soap had next logic:
// v < 0.7, wsdl.js - WSDL.prototype.xmlToObject
var body = root.Envelope.Body;
if (body.Fault) {
  var error = new Error(body.Fault.faultcode + ': ' + body.Fault.faultstring + (body.Fault.detail ? ': ' + body.Fault.detail : ''));
  error.root = root;
  throw error;
}
return root.Envelope;

Here code throws "Cannot read property 'Body' of undefined" at the very first line. This exception is handled in client.js's try/catch statement and is provided into the callback of SOAP method.
But starting v 0.7 we have here:
// v >= 0.7, wsdl.js - WSDL.prototype.xmlToObject
if (root.Envelope) {
  var body = root.Envelope.Body;
  if (body.Fault) {
    var error = new Error(body.Fault.faultcode + ': ' + body.Fault.faultstring + (body.Fault.detail ? ': ' + body.Fault.detail : ''));
    error.root = root;
    throw error;
  }
  return root.Envelope;
}
return root;

But here we don't touch properties of undefined root.Envelope. Later in client.js we are doing this line of code
result = obj.Body[output.$name];

which invokes Body property of undefined. This crashes the node process.
Could anyone help me with this issue? In fact I'm feeling like adding additional check or try/catch in client.js.

I'm running into the same issue, franza ~ would love to look at your patch, should you decide to write one.

Check out this code update to WSDL.JS - it seems to be helping me: https://github.com/piotr-gawlowski/node-soap/pull/1


ENH: Update STRtree nearest neighbor API

Resolves #1423
From discussion with @jorisvandenbossche @caspervdw @sgillies , the decision was made to keep the nearest() method as is (from PyGEOS), and handle all parameters and more advanced functionality in a second method called query_nearest().
query_nearest() replaces the nearest_all method from PyGEOS and adds additional capabilities:

output shapes are determined by the shape of the input geometry in the same way as query() and optionally wrapped into a tuple based on return_distance parameter: scalar input produces either array[n] or tuple(tree_indices: array[n], distances: array[n]); it produces either array[2,n] of input indices, tree indices, or tuple(indices: array[2,n], distances: array[n])
exclusive parameter is added from Shapely 1.8 to prevent matching geometries that are equal to the input geometry
all_matches parameter is added to control whether this method returns all equidistant / intersecting matches (default), or the first (both cases are used by GeoPandas sjoin_nearest; this simplifies that usage).

This should now present a signature similar to query().
Both exclusive and all_matches involve low-complexity changes to the underlying C implementation: we add these as members of a struct passed to the GEOS nearest neighbor callback, and check geometric equality in the callback if exclusive is True, and add an epsilon to the returned distance if all_matches is True to force GEOS to continue finding nearest neighbors after finding the first.
Lots of test cases were added to handle both scalar and array input geometries.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

27 of 27 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 84.278%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2096

Relevant Lines:
2487

💛  - Coveralls

@brendan-ward this is ready from your point of view? Will try to do a pass over the test changes shortly.

Yes, this is ready for review, though I'm just now seeing your comment about transpose above (will address shortly).

Given that we discussed this at the meeting, going to merge this to move forward. Thanks a lot @brendan-ward !
(@sgillies @caspervdw doing a check of the new API to ensure it matches with what we discussed is certainly still welcome!)


Obscure error is thrown

I am working on a React Native application and am trying to support the Fido2 auth standard. I believe I have the server side configured correctly with AWS, however, when I call Passkey.register() I keep getting a really obscure error:
Object {
"error": "RequestFailed",
"message": "The request failed. No Credentials were returned.",
}
I am using version 2.0.0 of this library. Is there a way to tell what is causing the issue such as a way to confirm my challenge is formatted correctly? Is there a specific simulator version I need to use for testing? I'm stuck on troubleshooting next steps as all my attempts are starting to go in circles and keep leading me back to this vague error message.

Hi @S-Voss, what OS and OS Version does this error occur on?

I'm currently running Xcode 14, iOS 16.4 on a iPhone 13 Pro simulator.

It appears my registration request looks correct. My challenge seems slightly longer than your example but I don't think that is a concern? Thanks for the help by the way. This has been a 5 day struggle and I like the idea of biometric auth.

I created a new RN project using 0.70.3 as this project uses and I still get the same error message. I'm running out of things to test unfortunately so any help would be great. Could it simply just be failing to authenticate because the challenges are failing to pass? I'm not sure how to troubleshoot this further.

So I spun up a website and added WebAuthN to it via the same server I'm pointing the react native application to. I've triple checked the README and confirmed my associated domain credentials as well. I'm still getting the same exact error.

Would it be possible for you to provide an example registration request from your backend?
Have you tried setting up the example app? You can find it inside the repo.

When I run the example I get something similar: {"error": "InvalidChallenge", "message": "The provided challenge was invalid"}
I noticed an issue with React Native pointing to iOS version 11.0 which breaks the example. I had to modify the Podfile to point to 12.0 in order for it to build properly. Could it be a versioning issue with the recent RN updates?
An example registration request being sent to Passkey.register looks like this:
const challenge = response.challenge.replace(/-/g, "+").replace(/_/g, "/") + "=="
{
"challenge": challenge,
"rp": {
"id": "localhost",
"name": "test"
},
"user": {
"id": response.user.id,
"name": response.user.name,
"displayName": response.user.displayName
},
"pubKeyCredParams": [
{
"type": "public-key",
"alg": -7
},
{
"type": "public-key",
"alg": -257
}
],
"timeout": 1800000,
"attestation": "none",
"excludeCredentials": [],
"authenticatorSelection": {
"authenticatorAttachment": "platform",
"requireResidentKey": true,
"residentKey": "required",
"userVerification": "required"
}
}

Just to confirm, localhost is just a placeholder for the actual rpId right?
Like I said the error code doesn't really tell us much, but I still suspect it has something to do with your backend configuration and/or the domain association.

Interestingly, when I add my toBase64String logic to the example, the 'invalid challenge' errors instead throws the obscure error that I'm seeing...i.e {"error": "RequestFailed", "message": "The request failed. No Credentials were returned."}.

I don't know what you're using on the server, but i'm using the SimpleWebAuthn JS library. And it returns challenge as Base65URL encoded string, and to make that work using react-native-passkey on iOS i needed to convert the Base64URL string to Base64 for it to work. Without doing that i would get the 1004 error from iOS.
After that i got the same error that you're reporting {"error": "RequestFailed", "message": "The request failed. No Credentials were returned."
I tracked down to SimpleWebAuthn expecting the registration attestation sent from the client to the server to have a type and for that type to be public-key, if not it will fail.
So i did:
    registrationAttestation = await Passkey.register(registrationOptions);
    // TODO - Figure out why this doesn't come from the Passkey library and if it's
    // okay to override it like we do here. SimpleWebAuthn#verifyRegistration expects
    // a type, and returns an error if it's missing.
    // https://github.com/MasterKale/SimpleWebAuthn/blob/5229cebbcc2d087b7eaaaeb9886f53c9e1d93522/packages/server/src/registration/verifyRegistrationResponse.ts#L82
    registrationAttestation.type = 'public-key';

Not sure if it's a good idea or not, but that at least got me passed the errors.
Sorry if this is not relevant for your setup @S-Voss.
@f-23 Should react-native-passkey set the attestation type, or is it SimpleWebAuthn who is wrong in requiring it to be set?

@S-Voss were you able to solve this problem? I am getting the same error message

@S-Voss were you able to solve this problem? I am getting the same error message

I got the same error and after reading the comments here, I caught the problem and that was related to associating domains in apple-app-site-association file.

@S-Voss were you able to solve this problem? I am getting the same error message

@S-Voss were you able to solve this problem? I am getting the same error message

I got the same error and after reading the comments here, I caught the problem and that was related to associating domains in apple-app-site-association file.

https://developer.apple.com/forums/thread/727267
After a bit of research, I found out that 16 ios requires a Security Key. Try adding withSecurityKey: true
If there is another solution without Security Key - relevant for me too

@S-Voss were you able to solve this problem? I am getting the same error message

@S-Voss were you able to solve this problem? I am getting the same error message

I got the same error and after reading the comments here, I caught the problem and that was related to associating domains in apple-app-site-association file.

https://developer.apple.com/forums/thread/727267
After a bit of research, I found out that 16 ios requires a Security Key. Try adding withSecurityKey: true
If there is another solution without Security Key - relevant for me too

@MikeDevBeddo
Currently, I am using iOS 17.2 without a Security Key and everything is working fine.

@S-Voss were you able to solve this problem? I am getting the same error message

@S-Voss were you able to solve this problem? I am getting the same error message

I got the same error and after reading the comments here, I caught the problem and that was related to associating domains in apple-app-site-association file.

https://developer.apple.com/forums/thread/727267
After a bit of research, I found out that 16 ios requires a Security Key. Try adding withSecurityKey: true
If there is another solution without Security Key - relevant for me too

@MikeDevBeddo Currently, I am using iOS 17.2 without a Security Key and everything is working fine.

Same with 17+, but does iOS 16 work just as well?

I also think the problem with iOS 16 might be related to the simulator. I can't find any binding with iCloud (only internal keychain), and it's not possible to put some 1Password on the simulator either. So superficially the problem may be related to the lack of workaround options inside the simulator

We have the same problem and updating to iOS 17 did not work. Do you have any ideas other than those mentionned on the thread that we already tried?

I'm currently getting the same error, AASA is set up with the expected appID and the domain has been set correctly in the webcredentials. When I add breakpoints at run time I get [0]= "NSLocalizedFailureReason": "Application with identifier XXXXX.com.xxxxx.xxxx is not associated with the domain xxx.xxx.tech.
I can see that at domain/.well-known/apple-app-site-association does contain the correct identifier under webcredentials -->  apps and yet I still get
"error": "RequestFailed",
"message": "The request failed. No Credentials were returned.",
}

None of the above solutions have helped, is there anything else that could help me get past this issue?

@angem-cleo did you find anything on this issue ?

@S-Voss @f-23
I'm facing the same error as well. I would like to confirm - the rpID I'm using is for the domain where my AASA file is served which is different from where by Webauthn backend is being hosted. Could this be an issue?
I'm hosting my webauthn server locally (@simplewebauthn/server). Over there I've set rpID and origin equal to <mydomain.com>. I am hosting my AASA file at <mydomain.com>/.well-known/apple-app-site-association.
I have set the associated domain value in xcode as well as per instructions provided in the documentation.
I am getting the exact same error.
Object {
"error": "RequestFailed",
"message": "The request failed. No Credentials were returned.",
}

Is there anything here that I'm doing incorrectly that can be changed to make this work?

@akshay-rr
The rpId should be the domain the aasa file is hosted on. It needs to match the one in the registration or authentication request. You should be able to configure this on your webauthn server. Please double check if you've entered the right domain/rpId in both XCode and your server configuration.
As the @simplewebauthn/server documentation says, origin should be equal to https://{rpId} on iOS. On Android it needs to match a hash of your app signing key. You can get more info on that here.
I'm also working on an update which will improve error logging, especially on iOS, to make tracking down issues like this easier.
Hope this helps!

I'm facing the same issue. The well-known's for both Android and iOS seem correct, so does the registration request from our server. It works on Android but iOS is throwing the same error:
Object {
    "error": "RequestFailed",
    "message": "The request failed. No Credentials were returned.",
}

Looking forward to the improved error logging - it's always appreciated :partying_face: :clap:

Upgrading to version 3 and ensuring that our PasskeyRegistrationRequest options passed to the create method where correct, has fixed our issue :+1:
I did however fork the repository to  change the Passkey.swift files handleErrorCode function to return the entire error instead of the localizedDescription.
Thank you for taking action quickly :bow:

I was facing the same error since yesterday. Upgrading to version 3 (3.0.0-beta2) also worked for me on iOS 18 Simulator. Beyond that, I also had to:

Convert the challenge from base64url encoding to base64 as already mentioned.
Add ?mode=developer to the webcredentials url to allow for the usage of a local server running on my laptop. Since I am using expo, I could set that in app.json instead of manually in xcode window.
Trust the certificate of my local server in the simulator by dragging and dropping the root certificate file into the simulator window.
Ensure the local server serving the webauthn api and .well-known/apple-app-site-association are hosted on port 443 as I believe custom ports are not supported.

Error creating passkey: {"error": "RequestFailed", "message": "The request failed. No Credentials were returned."}
it will properly work on android but ios is showing same error
using this package @turnkey/react-native-passkey-stamper
anyone have solution


StartSharp

Hi Volkan and Serenity Team,
Does Startsharp have a way of managing subscriptions of one's customers? If I have a multi-tenancy application and I want customers to subscribe, does startsharp already have a way of managing their subscriptions, the period it expires, invoices to be sent to them per subscription or renewal, etc?
And if I want to be able to set up customer logos and urls, can that easily be done?
Regards

We have a serenity.is application which does what you ask for, but it is not part of StartSharp and is a private application. We'll not be open sourcing it.

@volkanceylan thanks very much for your response. It would be nice though to have such features for extra dollars in Startsharp. This will help customers of Startsharp to manage everything from within the serenity ecosystem.
I am planning to sign up for Startsharp for a project early next year.


Request scheme 'chrome-extension' is unsupported

I get an error on this line
cache.put(event.request, cacheCopy);
Why is this error happening?

I'm not sure. Feel free to comment and re-open if you can toss up a reduced test case.


Refactor commands to az aosm nfd|nsd build

I want to get these in before I send the commands to the CLI review.
Others should be aware of these changes to avoid merge problems.

I think we said at some point that having the --publish in the build command was maybe not a good idea and we should be encouraging users to check the autogenerated definitions before they publish. Is this something we want to do in this PR?

Are print statements the correct way of logging? Did you ever find out?

Are print statements the correct way of logging? Did you ever find out?

Yes, it seems that print is the right way to output to screen. I tried to also debug log these when I did my VNF stuff, which was a pain.

I think we said at some point that having the --publish in the build command was maybe not a good idea and we should be encouraging users to check the autogenerated definitions before they publish. Is this something we want to do in this PR?

I have done that now


Setting the Cookie Path explicitly to root

Created the PR to get the changes from oxy to set the sticky session cookie to "/".
Fixes #1744

Releated to containous/traefik#1744

You have seemingly forgotten to update the glide hash in the lock file. That's why the CI is red.

Too bad. I changed the hash in the glide.lock and glide.yml. Not sure what went wrong.
I'm on vacation without a dev environment. I can check it when I'm back.

@marcopaga I have fixed the problem.

@ldez Thank you very much!


Fix umbrella app detection

This fixes umbrella path detection. Currently, maybe_umbrella_path is always the same as child_or_root_path because of how vim.fs.find works.
So this change kind of restores the logic that existed before removing lspconfig dep
Suggestion
It also removes the logic that detects if the umbrella path contains the dir apps. This was because this path could be set to another name in mix. exs with :apps_path, and maybe it is redundant checking for this when we found the mix. exs in a parent dir. But this is a suggestion, and I may be missing something.

Can you rebase on main actually?

Thanks again! 🤗


Import edx content - "What's Next"

Signed-off-by: Thaddeus Cambron<EMAIL_ADDRESS>

Missing DCO signoff. Use the information in step 10 of the following gist to add the sign-off

OK, thank you. I will take care of this in a couple of hours.
From: Tracy Kuhrt<EMAIL_ADDRESS>Reply-To: hyperledger/education<EMAIL_ADDRESS>Date: Monday, September 10, 2018 at 10:16 AM
To: hyperledger/education<EMAIL_ADDRESS>Cc: "Cambron, James"<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [hyperledger/education] Import edx content - "What's Next" (#78)
Missing DCO signoff. Use the information in step 10 of the following gisthttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Ftkuhrt%2F10211ae0a26a91a8c030d00344f7d11b&data=02|01|jjc6476%40psu.edu|c94751882583418e256608d6174121ce|7cf48d453ddb4389a9c1c115526eb52e|0|0|636721965838510986&sdata=zIwuD0SEJDljENvWwqQnjiKWVG3gtajaPmUaCeP0P7s%3D&reserved=0 to add the sign-off
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhyperledger%2Feducation%2Fpull%2F78%23issuecomment-419990425&data=02|01|jjc6476%40psu.edu|c94751882583418e256608d6174121ce|7cf48d453ddb4389a9c1c115526eb52e|0|0|636721965838520996&sdata=y32va4DMLzTrEwwTxMUjsr%2FW3abtt6hrQUPWhpYQbRc%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAcJxJua_Lyj3tPfzt50K3O19fG77NMTcks5uZp5ZgaJpZM4Wfq3s&data=02|01|jjc6476%40psu.edu|c94751882583418e256608d6174121ce|7cf48d453ddb4389a9c1c115526eb52e|0|0|636721965838520996&sdata=xJXJ7KNcUgoAIf64iFUSMf8S7%2FdS3POOw7k2dDcCbD0%3D&reserved=0.


r.js error - Mismatched anonymous define() module: function ()

There's an issue with r.js when using jsPDF. For more info, please read this comment: https://github.com/jrburke/r.js/issues/558#issuecomment-28669778
As I can tell, the

r.js found multiple anonymous defines and skipped naming one of the define()s. This could also be bug

Is an issue, because you have https://github.com/MrRio/jsPDF/blob/master/dist/jspdf.debug.js#L1703-L1705, https://github.com/MrRio/jsPDF/blob/master/dist/jspdf.debug.js#L5673-L5675
https://github.com/MrRio/jsPDF/blob/master/dist/jspdf.debug.js#L5688
Assume that's an issue caused by build setup you're using.

I'm still getting this error on the latest version of jsPDF.

Getting this error by merely including the file as follows on a mostly blank page:

"Error: Mismatched anonymous define() module: function" which seems to be from RequireJS.

+1, i've same problem with last version.
on same page i have jspdf and d3.layout.cloud, on d3.layout.cloud parsing i've same error reported by @VaelVictus


[Shiftstack]Support proxy

We want to run the shiftstack role inside the cifmw.general collection for shiftstack validation in an already deployed RHOSO.
For accessing it from the outside, we'll require to interact with the underlying OCP through the kubernetes.core modules using a proxy. That is currently supported in that collection and we just need to set the proxy parameter. That is what this PR enables.
If the variable cifmw_shiftstack_proxy is not set, the variable is then omitted, so backward compatibility is guaranteed.

/apporove

/lgtm


[dv/tl_errors] enable tl assertions correctly

this PR updates how the tl_errors_vseq enables and disable TL assertions
to correctly support multi-RAL IP blocks.
Currently there are race conditions where one thread may disable the
assertions, but another thread may enable them right afterwards, which
causes constant assertion errors.
We also add a call to wait_no_outstanding_access() at the end to prevent
any race conditions there as well (with nonblocking accesses).
Signed-off-by: Udi Jonnalagadda<EMAIL_ADDRESS>

Seems like the right fix here is to set the path argument of set_tl_assert_en() method so that it only disables the assertions on the TL interface accessing the current RAL model under test.
Though, if you want to make progress, I will suggest filing an issue and adding TODO #bug-no: to address it later. Comment should clarify that ALL tlul_assert instances are being disabled and re-enabled.

Seems like the right fix here is to set the path argument of set_tl_assert_en() method so that it only disables the assertions on the TL interface accessing the current RAL model under test.
Though, if you want to make progress, I will suggest filing an issue and adding TODO #bug-no: to address it later. Comment should clarify that ALL tlul_assert instances are being disabled and re-enabled.

Hmm that's a good point, I think that should solve the problem as well rather than blindly enabling/disabling every single assert instance. Let me give that a try.


Add Google Analytics

Need to decide the account that should be tied to the Google Analytics

completed with Tracking ID UA-80618922-1


Great if it could keep groups together

I make a lot of jewelry and this would be hugely useful if it kept groups of objects together.

hey mirzu
do you mean svg  tags or physical clusters of objects? I don't have any background in jewelry, so it's not obvious to me how this might work.

SVG tags. Right now the parser takes them apart and places the polygons individually. If it kept the groups together and only placed the outermost group it would work perfectly for me.

hmm.. so you would like certain parts to keep their relative positions, as if they were a single object? I'm just not quite sure how this would be useful in the context of jewelry making.

Here is an example file that I tried to name the different parts so this would make sense.
https://www.dropbox.com/s/r52u5j6w7t1tv4t/slinky-vector.svg?dl=0
The groups with id "keep_together" and keep_together_copy" are what I would love SVG Nest to keep together. They contain shapes that will be cut and etched to make each piece of jewelery.
How it looks in the drawing program, black is etched, red is cut.

How it looks when cut:

ah I see. In this particular case it should work as-is.
The paths that are used for nesting are the paths that are not contained by other paths. If a path is contained inside another path, it will be grouped with the outer path. So in the given example all the paths would be grouped with the outer red path.
if you have a collection of paths without a path to enclose them, you could create the enclosing path by hand or use offset+boolean operations.
it is possible to make a feature to do this as well, but like the other suggestions so far it's do-able but not exactly trivial to implement.

It would also be helpful if a compound shape could be kept together. (That's an Illustrator term for a path node with a single d attribute defining the full shape including separate pieces.)

I would have liked for groups to be kept together as well, even if only uncontained paths are considered: that's not how I expected it to work, and I can imagine it being useful in a few cases.
Take the following svg for instance, svgnest is stuck on "placement in progress"

expand svg code, as I cannot attach it as a file

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!--

I make a lot of vinyl cutting and this would be hugely useful if it kept groups of objects together.
In this case, for example I need keep the words complete for later transfer them.


More generalized crafting machine selection

Some recipes may be crafted with multiple entities. In the vanilla dataset, this (mostly) only arises with assembling machines and furnaces. In certain mods (e.g. Bob's) there are more crafting categories for which this is a concern. The calculator should have some way of selecting crafting machines for these other cases in a generalized way.
This may be related to #96.

With 0.17 this would also be really useful in vanilla. Assembly machine 2 has a speed of 0.75 for 150kW. AM3 is 1.25 for 375kW. And the ingredient limits have been removed. So it becomes very attractive to use AM3 with modules - for example in science - but produce the ingredients for it in AM2. There are even some cases where AM1 is fast enough


feat(blocks): add BlockDocument HTTP client

resolves https://github.com/PrefectHQ/terraform-provider-prefect/issues/173
adds:

BlockDocumentClient - with Get, Create, Update, and Delete methods
a subset of ^ client for /access, to manage attached ACL objects - specifically:

GetACL (GET /block_documents/{id}/access)
UpdateACL (PUT /block_documents/{id}/access)

🎉 🚢


update remove & update check

The remove & update APIs are marked as Deprecated, so how about we switch remove => deleteOne & update => updateOne based on the doc's suggestion?

This would be backwards breaking unfortunately. I'd merge if you added deleteOne and updateOne to that if statement, as well as deleteMany and updateMany. Eventually we want to move away from using update and remove but needs to be done slowly and carefully.


feat(keymaps) UI Improvement and more options for keymaps

This PR aim to improve keymaps:

UI improvement, add fzf header line and show key mapp content
Add config options to support filter by mode. e.g: lua require'fzf-lua'.keymaps({modes = {'n'}})
Filter vim internal mapping that is not useful for end user, eg: <Plug>, <SNR>

Example:
Before:

After:

Ty for the contribution @duqcyxwd!
https://github.com/ibhagwan/fzf-lua/commit/bb704a36bc219c3e9aea2628968cafd4b50057e7
Manually merged (original autor is kept) with tiny fixes:

The | char wasn't the correct one (it was a longer unicode char)
Seperated --header-line into it's own key in fzf_opts
Fixed the keymap previewer entry parser

This broke the multiline string issue again (described in #875

This broke the multiline string issue again (described in #875)

when a keymap has desc, etc. so it has more than two lines in the `:map` (or `:imap`, etc.) output, e.g.:
i  -           * <Lua 788: some/path/to/module.lua:110>
                 autopairs end pair: <!--,-->
                 autopairs start pair: <!--,-->

Oops, sorry @wookayin, I can fix it later when I’m near the PC but you’re also welcome to submit a new PR if you wish.

Thanks. Also I don't think we should exclude <Plug> mappings completely, because it's often useful to look at what implementation functions it's actually mapped to in a chain without leaving the UI.
e.g. cs -> <Plug>Csurround -> :<C-U>call <SNR>102_changesurround()<CR>
Perhaps excluding them by default would make a sense, but at least we could have some options as a configuration point.

Perhaps excluding them by default would make a sense, but at least we could have some options as a configuration point.

Absolutely in favor of an include option, what do you think about <SNR> mappings?

https://github.com/ibhagwan/fzf-lua/commit/5fa59836c8df511dafd676c43a89ae4b47c4629a
@wookayin, this should fix the multiline string desc, also replaced the hardcoded <SNR> and <Plug> filtering with ignore_patterns (lua regex array, similar to file_ignore_patterns), the default being:
require("fzf-lua").setup({
  keymaps = {
    ignore_patterns = { "^<SNR>", "^<Plug>" }
  }
})

To disable:
:lua require("fzf-lua").keymaps({ ignore_patterns=false })
-- or
:FzfLua keymaps ignore_patterns=false


screen killed on logout

Steps to reproduce
Connect via ssh, start a screen session, detach it.  Exit ssh session.  In systemd journal:
Feb 25 21:40:46 alpha systemd[1]: session-2.scope: Killing process 2796 (screen) with signal SIGTERM.

Reconnect via ssh and screen -RD starts a new session, the old one is indeed gone.
This began happening when updating from 9b25b9347d9 to 1bf7dfaabea (on nixos-unstable).
Among other things that contains an update to systemd (from 234 to 237, eb862c48ddc288243c5447e8decc623b10ef165c).  Nothing in the release notes for those couple of versions looks immediately suspicious to me, but I'm far from a systemd expert.
I've only gotten through one step of bisecting so far, but I'll keep this updated as I go.
git bisect good 66b2d84b83a79781c1999849ce9c0f12342ec6ea
git bisect bad 53d274c1818bc6af30bb925476d178cfbddc8a12
git bisect bad 2b851d14d9f7fa09120a407fecf3a81cea12bebe

Technical details

system: "x86_64-linux"
host os: Linux 4.9.81, NixOS, 18.03.git.2b851d1 (Impala)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 1.11.16
channels(root): "nixos-16.03.1299.a8e0739"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

(That 16.03 channel is an artifact of the way I manage my nixpkgs git checkout, the commits mentioned above are correct.)

Offhand, seems likely to be same problem causing #35415.

Possibly related: http://thread.gmane.org/gmane.comp.sysutils.systemd.devel/2379/focus=2391
Also, lingering options on other thread, haven't tried.

Closing as duplicate of #35415 (but thank you for reporting, I wasn't previously sure this wasn't (somehow!) a tmux thing).


Updated TypeScript from 4.6.0 to 4.8.2

Changes

This updates the TypeScript dependencies from 4.6.0 to 4.8.2
Starting in TypeScript 4.7.x, package.json exports are supported.
During build, I noticed a missing interface for InlayHintsOptions, which was then added with citation from the TypeScript Fourslash suite.

Testing
Followed CONTRIBUTING.md.
Docs
dependency update only

Hello! Thank you for this PR. Unfortunately, updating to the latest TypeScript version is not that easy.
Some changes to our module resolution cache and our code actions are needed to properly support 4.7. Additionally, our current language services force moduleResolution to node which is not ideal

Thanks for the quick review, @Princesseuh. To clarify, would the guidance be to apply similar kinds of changes as https://github.com/sveltejs/language-tools/pull/1526? I want to be sure I’m looking at the right change Svelte made. If you’re not sure, I can ask later this week, too. No rush, and again, thank you for the incredibly fast review.

Thanks for the quick review, @Princesseuh. To clarify, would the guidance be to apply similar kinds of changes as https://github.com/sveltejs/language-tools/pull/1526? I want to be sure I’m looking at the right change Svelte made. If you’re not sure, I can ask later this week, too. No rush, and again, thank you for the incredibly fast review.

Yep! That's the right PR. Additionally, support for group aware organize imports should be considered for full support  https://github.com/sveltejs/language-tools/pull/1515
I'm okay with that one being tackled separately if you prefer not to, it's alright. I can tackle it myself låter

https://github.com/withastro/language-tools/pull/389 makes this PR unnecessary. We'll still need to add support for node16 resolution and group aware imports, but it'll be tackled separately. Thank you for making this PR!


run.sh: retry downloading plugins upon failure

In certain conditions, the network may not entirely
ready when the container starts. This prevents the plugins
from being downloaded, which may not be desirable as
liveness probes won't pick up the fact that ES does not run
all the features that were expected to be present (e.g.
prometheus metrics exporting).
 In Kubernetes, the pod will eventually get killed
and restarted by the liveness probs after the initialDelaySeconds
delay has expired.
The following happens pretty frequently on k8s 1.9+ w/ Weave CNI & CoreDNS. This makes Prometheus and the Alert Manager unhappy, as they consider that the elastic-search cluster is out.
-> Downloading https://distfiles.compuscene.net/elasticsearch/elasticsearch-prometheus-exporter-<IP_ADDRESS>.zip
Exception in thread "main" java.net.UnknownHostException: distfiles.compuscene.net
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
        at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1944)
        at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1939)
        at java.security.AccessController.doPrivileged(Native Method)
        at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1938)
        at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1508)
        at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
        at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:263)
        at org.elasticsearch.plugins.InstallPluginCommand.downloadZip(InstallPluginCommand.java:326)
        at org.elasticsearch.plugins.InstallPluginCommand.download(InstallPluginCommand.java:245)
        at org.elasticsearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:213)
        at org.elasticsearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:204)
        at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86)
        at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:124)
        at org.elasticsearch.cli.MultiCommand.execute(MultiCommand.java:75)
        at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:124)
        at org.elasticsearch.cli.Command.main(Command.java:90)
        at org.elasticsearch.plugins.PluginCli.main(PluginCli.java:48)
Caused by: java.net.UnknownHostException: distfiles.compuscene.net
        at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184)
        at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
        at java.net.Socket.connect(Socket.java:589)
        at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:673)
        at sun.security.ssl.BaseSSLSocketImpl.connect(BaseSSLSocketImpl.java:173)
        at sun.net.NetworkClient.doConnect(NetworkClient.java:180)
        at sun.net.www.http.HttpClient.openServer(HttpClient.java:463)
        at sun.net.www.http.HttpClient.openServer(HttpClient.java:558)
        at sun.net.www.protocol.https.HttpsClient.<init>(HttpsClient.java:264)
        at sun.net.www.protocol.https.HttpsClient.New(HttpsClient.java:367)
        at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(AbstractDelegateHttpsURLConnection.java:191)
        at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1156)
        at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1050)
        at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:177)
        at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1564)
        at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
        at sun.net.www.protocol.http.HttpURLConnection.getHeaderField(HttpURLConnection.java:3000)
        at java.net.URLConnection.getHeaderFieldLong(URLConnection.java:629)
        at java.net.URLConnection.getContentLengthLong(URLConnection.java:501)
        at java.net.URLConnection.getContentLength(URLConnection.java:485)
        at sun.net.www.protocol.https.HttpsURLConnectionImpl.getContentLength(HttpsURLConnectionImpl.java:407)
        at org.elasticsearch.plugins.InstallPluginCommand.downloadZip(InstallPluginCommand.java:325)
        ... 9 more

I'll be happy to make that a variable with a default. However note that until will retry until the command actually succeeds, so it's mostly only about how many time the echo occurs at this point.

Nevermind, I overlooked the until.

Thank you so much!


Correct ws4py version

correct version of ws4py should be 0.3.x instead of 3.x.0

I think it's already fixed in the trunk.


Add Avali

About the PR

Ported over from https://github.com/cosmatic-drift-14/cosmatic-drift/pull/189
It was already given the green light, I just helped porting it.
Why / Balance

More species, more customizability.
Technical details

Xenos call them Four Eared Hosts, since it's different enough that they won't get confused with Vox (I will port...one day...I still have hope) and unique enough that it's unlikely to be confused with something else.
Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Added Avali species

Got permission for the scream sound. Might take a day or 2 to check if the talk sounds are ok.

Was decided that this PR will drop the speech sounds for now, in lieu of new ones and/or permission.

https://github.com/user-attachments/assets/d3b3c8f4-18f9-42b0-b8ec-483489f582ab
(Them in armor, tucked helmet, and their currently only custom sound for now, a scream)

Forgot bursted


docs(arch): Add info about Postee distribution model

Signed-off-by: Simar<EMAIL_ADDRESS>

I honestly need to spend more time with the project and how to create rego templates, etc.
One thing that I've always wanted to see in this product as well as Sysdig Falco Sidekick UI is the ability to silence the alerts instead of editing the rego templates (or falco rules, etc).
The reference model would be like Prometheus and AlertManager.
With those tools, I can import a default set of rules, etc. but I have the ability to silence the alerts through a UI when I don't want to hear from an alert vs having to edit the config for either Prometheus or AlertManager.

Super seeded by https://github.com/aquasecurity/postee/pull/373/files#diff-5e98eb247d0b53b7f9c79bb2875a152fd5b03392f6bedce86cceaf2c96a3a383


Regression on google-compute-engine 20190124 => 20200113.0: all binaries are lost

google-compute-engine-20190124 provided binaries:
$ ls /nix/store/6g2pd9ip0c1vczva134xqa5axc2kqlv7-python3.8-google-compute-engine-20190124/bin
google_accounts_daemon  google_clock_skew_daemon  google_instance_setup  google_metadata_script_runner  google_network_daemon  google_optimize_local_ssd  google_set_multiqueue

google-compute-engine-20200113.0 doesn't:

$ ls /nix/store/n1a9avrpyi0szq991aw4jfxrpjllnyzp-python3.8-google-compute-engine-20200113.0/bin
ls: cannot access '/nix/store/n1a9avrpyi0szq991aw4jfxrpjllnyzp-python3.8-google-compute-engine-20200113.0/bin': No such file or directory

FYI, it also breaks https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/google-compute-config.nix which assumes these binaries to be present.
@cpcloud @zimbatm @SuperSandro2000

@PaulGrandperrin Can you show the error(s) you're getting? I just created a NixOS VM on GCP using Pulumi, based on NixOS/nixpkgs@https://github.com/NixOS/nixpkgs/commit/0943a5c5a089761ea06ecf95e56bab8ce84e35f3 and had no problem SSH-ing into it through an IAP tunnel and poking around.

@cpcloud I'm answering from my phone.
There shouldn't be any errors while deploying the VM, however, the GCE related services will all fail, because of the missing executables, like google_clock_skew_daemon at https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/google-compute-config.nix#L126

I can't copy more from my phone screen but you get the idea:
# systemctl status google-clock-skew-daemon.service|cat
× google-clock-skew-daemon.service - Google Compute Engine Clock Skew Daemon
     Loaded: loaded (/etc/systemd/system/google-clock-skew-daemon.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Wed 2021-12-01 11:48:34 CET; 3h 52min ago
    Process: 1233 ExecStart=/nix/store/7hhfk9vf2wmn6fk9xpmakfvldrkshbaw-python3.9-google-compute-engine-20200113.0/bin/google_clock_skew_daemon (code=exited, status=203/EXEC)
   Main PID: 1233 (code=exited, status=203/EXEC)
         IP: 0B in, 0B out
        CPU: 720us

Dec 01 11:48:34 nixos-gcp systemd[1]: Started Google Compute Engine Clock Skew Daemon.
Dec 01 11:48:34 nixos-gcp systemd[1233]: google-clock-skew-daemon.service: Failed to locate executable /nix/store/7hhfk9vf2wmn6fk9xpmakfvldrkshbaw-python3.9-google-compute-engine-20200113.0/bin/google_clock_skew_daemon: No such file or directory
Dec 01 11:48:34 nixos-gcp systemd[1233]: google-clock-skew-daemon.service: Failed at step EXEC spawning /nix/store/7hhfk9vf2wmn6fk9xpmakfvldrkshbaw-python3.9-google-compute-engine-20200113.0/bin/google_clock_skew_daemon: No such file or directory
Dec 01 11:48:34 nixos-gcp systemd[1]: google-clock-skew-daemon.service: Main process exited, code=exited, status=203/EXEC
Dec 01 11:48:34 nixos-gcp systemd[1]: google-clock-skew-daemon.service: Failed with result 'exit-code'.

And /nix/store/7hhfk9vf2wmn6fk9xpmakfvldrkshbaw-python3.9-google-compute-engine-20200113.0 is indeed installed, but is missing the bin directory.

Here are all the failing services:
● google-clock-skew-daemon.service                                             ● google-instance-setup.service                                                ● google-network-daemon.service                                                                                ● google-startup-scripts.service

I don't know how useful are the other missing binaries but anyway it looks like there's just an issue in the packaging process

@cpcloud sorry, that's not all the GCE related services that are failing, as you have seen the ssh key fetching service is still working 🙂

https://github.com/NixOS/nixpkgs/pull/144761

We were relying on some google-provided python script to perform various actions on the GCE guests. These scripts have been decommissioned in favor of a Golang daemon: GoogleCloudPlatform/guest-agent. The #131761 bump broke the google-compute-config NixOS module: the Python script are not longer present in the $out/bin directory (more info about that in the upstream commit), hence breaking the NixOS module that was relying on those scripts.

@Artturin oh I should have seen that before!
Thanks!


Display which-key on leader key only

Thank for your plugin
Hi i just want to display which-key on leader key. Currently it mapping all key g,d,y,... and I don't want that.
I only want to display on leader.
My setup function
        wk.setup {
            plugins = {
                marks = false, -- shows a list of your marks on ' and `
                registers = false, -- shows your registers on " in NORMAL or <C-r> in INSERT mode
                -- the presets plugin, adds help for a bunch of default keybindings in Neovim
                -- No actual key bindings are created
                presets = false
            },
        }

it only hide the description but it still display which-key on my mapping.

Yep, you're correct. Was planning to make this configurable. Stay tuned!

You can now set triggers = {"<leader>"}, to only trigger on that key

Thank it is working


Excuse，When will version 6.5 be released

Excuse，When will version 6.5 be released

We are waiting for two important enhance features of UI topology map from @x22x22. Planning to be next month.

Look forward to it. Thank you


Why is Function an instance inner class of Expression?

In my project, which uses EvalEx, I had to implement a custom Function and the requirement that the Function is an instance-inner-class struck me as quite odd. I did not look through the whole source code to be honest, but is it a requirement that the Functions have access to the enclosing Expression instance? Could they be made static instead?
Example, if I want to add a new Function I have to extend the Expression first:
public class ExtendedExpression extends Expression {
    // Constructors as needed.
    public class BestFunction extends Function {
        // Class body
    }
}

// Usage
ExtendedExpression expression = new ExtendedExpression("best(1, 2, 3)");
expression.addFunction(expression.new BestFunction());

Which makes it rather hard to quickly add custom functions.

This is for backwards compatibility. See discussion in issue #87.
I will probably go into the direction, I pointed out there. I experimentally tested in the 'externalize' branch.
(See source at: https://github.com/uklimaschewski/EvalEx/tree/Externalize/src/com/udojava/evalex)

I see.
Some feedback on that branch:

I wouldn't name the method addExternal*, but instead overload addFunction to accept the new Function.
Also I'd take the opportunity and make Function an interface with an abstract default implementation. That would allow other objects to implement it if they already extend another class, which would make the whole thing more flexible.
Just as a note, Java conventions state that abstract classes are prefixed with Abstract in their name to make that more clear.
I wouldn't use the External prefix, though it might be confusing having the internal and "external" classes with the same name, I believe it would make a cleaner API.

And giving it some more thought, the internal classes then could directly extend the external classes, that would minimize complexity greatly. Thinking this further, that might also eliminate the need for an additional addFunction...but need to think about this some more.

Thanks for the input. I'll consider your ideas. Maybe I will find some time after christmas to give it a try.

I'd like to work on this if you don't mind. Though, I will also only find the time for it after the holidays.
Are there unit tests in place which test the backwards compatibility (for the clients you mentioned) or need these to be created?

OK, thanks alot. If the current tests run without modifying them, then this proves enough backward and binary compatibility, I hope. Watch out when changing public/protected method signatures, though.

I'm asking because if I change the addFunction method signature (by using the "new external" class) it will be source compatible, but not binary compatible. That is the only "breakage" that I currently see happening.

If you think, you can do this without changing the existing test code, go ahead.
We can set the version to 2.0, to show that there is a binary incompatibility to earlier version.

I've started working on this, you can see the "preview" of the changes in my refactoring branch.
The most important things to note:

Two new interfaces: Function and LazyFunction
Two new abstract classes: AbstracFunction and AbstractLazyFunction
I had to fully classify the new interfaces in Expression, that is unfortunate but there is no other way I'm afraid (because of the name clashes between LazyFunction and Expression.LazyFunction.
I've duplicated some of the tests which are using the abstract classes.
I'd need to extract the helper functions like assertNotNull(BigDecimal) somewhere else so that they can be reused. Most likely into AbstractLazyFunction.

The new class hierarchy looks like this:
interface LazyFunction
interface Function extends LazyFunction

class AbstractLazyFunction implements LazyFunction
class AbstractFunction extends AbstractLazyFunction implements LazyFunction

Comments are obviously welcome, note that this is a preview so Javadoc and some cleanup is still missing. The tests are working and the changes inside Expression are minimal.
I've been thinking about convenience factory methods, something like this (with Java 8):
expression.addFunction(AbstractFunction.oneArg("NAME", (parameters) -> {
    return parameters.get(0).multiply(new BigDecimal("8"));
});

But that does not do much, now that I think about it and see it.


VS Code terribly slow

Type: Performance Issue
i run on one of the latest intel's processor i7 13700hx, and a 32gb ddr5 ram memory, with no more than 15 extentions on my vs code, it runs terribly slow with no valid reason, one thing i noted, is that whenever i enter anything in my text editing it keeps parsing code i guess.
VS Code version: Code 1.87.0 (019f4d1419fbc8219a181fab7892ebccf7ee29a2, 2024-02-27T23:41:44.469Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
13th Gen Intel(R) Core(TM) i7-13700HX (24 x 2304)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.75GB (20.92GB free)

Process Argv

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	   104	  2760	code main
    0	   111	  3356	   gpu-process
    0	   225	  4080	window [1] (CS112_A1_T5_20230045.cpp - C++ or C - Visual Studio Code)
    0	    96	 18352	window [2] (Issue Reporter)
    0	    41	 19992	   utility-network-service
    0	   142	 27196	extensionHost [1]
    0	   133	 14196	     c:\Users\adham\.vscode\extensions\ms-vscode.cpptools-1.19.4-win32-x64\bin\cpptools.exe
    0	    10	 27600	       C:\WINDOWS\system32\conhost.exe 0x4
    0	     5	 27916	       "c:\Users\adham\.vscode\extensions\ms-vscode.cpptools-1.19.4-win32-x64\bin\cpptools.exe"
    0	    55	 27912	         c:\Users\adham\.vscode\extensions\ms-vscode.cpptools-1.19.4-win32-x64/bin/cpptools-srv.exe 14196 {F9E03158-39DC-4E33-8C6B-C84BC95100E7}
    0	    10	 28000	           C:\WINDOWS\system32\conhost.exe 0x4
    0	    82	 27792	     "C:\Users\adham\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\adham\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=27196
    0	   133	 28104	     "C:\Users\adham\AppData\Local\Programs\Microsoft VS Code\Code.exe" c:\Users\adham\.vscode\extensions\streetsidesoftware.code-spell-checker-3.0.1\packages\_server\dist\main.cjs --node-ipc --clientProcessId=27196
    0	   102	 27268	shared-process
    0	    82	 27300	fileWatcher [1]

Workspace Info
|  Window (CS112_A1_T5_20230045.cpp - C++ or C - Visual Studio Code)
|    Folder (C++ or C): 18 files
|      File types: exe(5) json(4) cpp(4) c(1) o(1)
|      Conf files: launch.json(1) settings.json(1) tasks.json(1)
|      Launch Configs: cppdbg(2);

Extensions (17)

Extension
Author (truncated)
Version

project-manager
ale
12.7.0

gitignore
cod
0.9.0

python-extensions-pack
dem
1.0.3

githistory
don
0.6.20

code-runner
for
0.12.1

codespaces
Git
1.16.11

vsc-python-indent
Kev
1.18.0

black-formatter
ms-
2024.0.1

debugpy
ms-
2024.2.0

python
ms-
2024.2.1

vscode-pylance
ms-
2024.2.2

cpptools
ms-
1.19.4

cpptools-extension-pack
ms-
1.3.0

indent-rainbow
ode
8.3.1

code-spell-checker
str
3.0.1

vscode-lldb
vad
1.10.0

vscode-open-in-github
ziy
1.3.6

(2 theme extensions excluded)

Same issue for me. It's especially unbearable with C++. It was not great before, mostly with big files, but now it got waaaaaaay worse, even with small files it can cause few second typing lags.

same issue for me on Linux , Ubuntu. It has become terribly laggy and slow. Downgraded to 1.86.2 because it was a nightmare to work with. Downgrading fixed issues for me. Ill skip this latest update and try a future one. Nothing in the new one is of importance to me.

/duplicate #206510


Static unchecked() function

It would be nice to have a static function unchecked(), defined for all ThrowingFunction types, that could return functional types from java.util.function. Checked exception would be wrapped in RuntimeException instances.

Released in v1.2


Change to AlphaStack for ...Groups

Self Checklist

[x] I wrote a PR title in English.
[x] I added an appropriate label to the PR.
[x] I wrote a commit message in English.
[x] I wrote a commit message according to the Conventional Commits specification.
[x] I added the appropriate changeset for the changes.
[ ] [Component] I wrote a unit test about the implementation.
[ ] [Component] I wrote a storybook document about the implementation.
[ ] [Component] I tested the implementation in various browsers.

Windows: Chrome, Edge, (Optional) Firefox
macOS: Chrome, Edge, Safari, (Optional) Firefox

[ ] [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue
Fixes https://github.com/channel-io/bezier-react/issues/1222
Summary

Change ButtonGroup RadioGroup FormGroup from Stack to AlphaStack
Details

React.Children iteration cause problem when the wrapper component of children was fragment.
So replace with AlphaStack that uses flex-gap instead of Stack, StackItem.
There are changes with css expression with stack to AlphaStack. It could not be catched with jest snapshot test so updated snapshot test.
It would be tested with chromatic UI test in this case. But current plan's snapshot feature is already over.... 😢

Breaking change or not (Yes/No)

References

Chromatic UI Test

👍 머지해주셔도 됩니다!


Changesets implementation

This PR introduces the changesets tool to provide changelog generation and automated releases to npm of the @opennextjs/cloudflare package.

This PR will need careful review, since it is very hard to test until it has landed on main.


Props-table arrayOf

Issue Description

Datepicker props table: http://engineering.cerner.com/terra-core/#/site/datepicker
Issue Type

[ ] New Feature
[x] Enhancement
[ ] Bug
[ ] Other

Released in terra-props-table v1.2.0


Feature Request: mini.surround support

Feature Requested
Great plugin!
I'd love to replace my usage of https://github.com/roobert/f-string-toggle.nvim
I have run up against one issue: when using mini.surround for deleting the brackets within a python f-string, (e.g: gzd{) the string state doesn't update.
I've tried to debug this by using set verbose=9 to capture the potential autocmd that could be used as a hook, however, it's too verbose and I believe some kind of custom function may need making that involves filtering the output, etc.
Opening this in case you know off-hand the correct autocmd to hook off to fix support, before I try and investigate further.
Thanks again for the plugin!
Relevant Screenshot
No response
Checklist

[X] The feature would be useful to more users than just me.

I use nvim-surround instead of mini.surround, and with that plugin, it works just fine though? 🤔
nvim-puppeteer is triggered on TextChanged, so any kind of operation by another plugin should be picked up correctly.
My guess is that this is mini.surround using :noautocmd somewhere in its code. That would be an issue you'd have to report at their issue, nothing I can do about it on this end, sorry

Interesting, it doesn't appear mini.surround (the default in lazyvim) is using noautocmd.

Closing this since probably not related to this plugin; please reply if there is still an issue!


Android Basics: Activities and intents

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-activities-intents?hl=en&continue=https%3A%2F%2Fcodelabs.developers.google.com%2F%3Fcat%3Dandroid%26authuser%3D4%231#1
In which task and step of the codelab can this issue be found?
Download the Starter Code for this Codelab
Describe the problem
It is not clear how to download the starter code.
I have followed the steps, it downloads a zip file "android-basics-kotlin-words-app-main"
This is not the starter code (despite be in the starter branch assuming by the codelab instructions).
The project downloaded does not have "detail activity" and has fragments in its place
Therefore the github starter code is unusable because it doesnt match the instructions in the codelab.
Steps to reproduce?
Go to the codelab
Download the github starter code as per the codelab instructions
Open the project in android studio and follow the next steps in the codelab
(https://developer.android.com/codelabs/basic-android-kotlin-training-activities-intents?hl=en&continue=https%3A%2F%2Fcodelabs.developers.google.com%2F%3Fcat%3Dandroid%26authuser%3D4%231#2)
It refers to a screenshot with "DetailActivity" on it. This is not in the project downloaded from github,
Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

This seems like an issue with Github that has now been fixed (the issue was the attempting to download a zip of a branch was instead downloading a zip of the main branch). I've tried download the zip file of the starter branch and confirmed it was not the completed app.


Backport more logging to 0.3

Backports #5325 and #5340.

Why is this not running? CI seems to run fine for other PRs...

@elsirion Maybe some github bug. Do you want to re-push with some tirivial change to re-trigger it?

Rebased, now CI seems to run.


UI : Remove the text ellipses and wrap the content to next line

Describe your changes :

Issue: Closes #8346
Remove the text ellipses and wrap the content to the next line
Increases column width and added horizontal scroll in the table of profiler and data quality

Type of change :

[x] Bug fix

Frontend Preview (Screenshots) :

https://user-images.githubusercontent.com/66266464/214551315-c9492472-60dd-4835-a1b5-a940cecdedd1.mov
https://user-images.githubusercontent.com/66266464/214551456-39fa5cad-2c21-4804-9868-dabe589a9edf.mov

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
@open-metadata/ui

@chirag-madlani  @devyani-kaushik  changes done as per comments!

Looks good to me @chirag-madlani @Ashish8689


[BUG] CODEOWNERS file is invalid

What is the bug?
Seeing this error on CODEOWNERS file:
Unknown owner on line 1: make sure @davidlago exists and has write access to the repository
…123 @cwperks @DarshitChanpura @davidlago @derek-ho @peternied @RyanL1997 @scrawfor9
We should probably move Dave to emeritus maintainer and remove him from codeowner file.
What is the expected behavior?
No error

Let's make sure to get @davidlago's input on his status in the project before making changes.  IMO there are two potential outcomes, 1) the permissions issue gets resolved and the file starts working again, 2) David chooses to become emeritus and he is removed from the codeowners (and maintainers.md is updated)

Confirmed with @davidlago this move to emeritus maintainer in a private conversation.


pull request for e2e test at 01/12/2017 10:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


HarvestX/HarvestModLike Crop Check compatibility issue

HarvestX, originally the main function from this mod, has crop checking for many plantings, especially not fully grown crops
HarvestModLike, which is HarvestRightClick, recently implemented into the mod to prevent Anti-cheat from flagging packets, broke the crop checking function, which ruined half the purpose of this mod
Two video below should show the issue, ignore the background noises
https://streamable.com/chye8o
https://streamable.com/hxt7al

Check out the new release.

damn that was a clever workaround
the one thing right now about the right-click crop harvesting is it doesn't have a check if the players is holding a seed/plants or not, which is fairly inconvenient for players spamming their Bone Meal(s) to grow crops that aren't meant for breaking, rather a decoration (it's common for farm buildings)
But for now, thanks for accepting my issue and have a good holidays

There is no expected item holding check.
Maybe if turn Right Break off when holding nothing or what do you think about it?
Have a good holidays too. (But there is no actual break from work in China, lol)

Ah right, China, people worked hard for a long period of time for a short break, gotta admire their spirit
Anyway, no, the video provided was having Right Break on
That's the issue I was trying to describe, basically it's for people trying to spam Bone Meal on crops, with this Right Clicking function, it would accidentally break the crops, which by any means, you have to replant it and hope for the best you won't accidentally break it again 💀
It's kinda a hard concept to describe with words, but I will try
If there is like a checking for this function that the crops only break when the players is holding the seed/plants than is able to plant on crops then it would minimize the accidental breaking issue
That's it I guess

To check the seed holding in hand is quite hard, because we don't know what are the seeds in code.
My thought is that like disabling right break when sneaking, or disabling when holding bone meal.
Which one would you like?
And I think we hardly use bone meal to make decorating crops, just turn it off can work all things out.

I think keep it the same should be fair enough, think again I don't think people even spam Bone Meal that much except getting quick food.


Replaces the config_clear

For Debian.

Seems to close #4
At least CIP-Building does not throw Warnings/Errors, even with -Wextra

NVM Not checking for file not existing -> Segfault (yay...)

Imma ignore this and rewrite the patch from scratch, since the bug was something else.


should be able to return generated token value

Currently I am not able to get the generated token_value from the Construct. Looking at for example the credentials construct I see that there is a public function attached to return attribute string. Would this be required for token too?

enforcing this to output a token as just a string does not really feels secure. Can this be masked from the output and store the token as secure parameter or in the secret manager with a given key?

replaced by https://github.com/godatadriven/databricks-cdk/pull/911


Strict attribute types

The problem
I work on api. I use RedisActiveRecord.
I do create request
{
stringValue : '123'
intValue : 20,
boolValue : true
}
I load AR model & save it.
So, model have integer validator for intValue & bool Validator for boolValue
when i do get request
I find model by Id from RedisDB & return $model->toArray().
the ploblem that after loading from DB intValue & boolValue become string '20' & '1'.
Suggestion
Maybe that is not a problem for PHP7. But at this momen i don't have ability to upgrade a php version. I guess, you can face the challenge with other DB & AR.
I'd suggest following solution.
Add method attributeTypes to BaseActiveRecord which return array in following format
[
'attributeName1'=> 'int'
'attributeName2'=> 'bool'
'attributeName3'=> 'string'
]
in __set method we have to verify type of value for attribute & bring it, if it's required.
Additional info
I saw similar solution at Laravel and i find it very usefull.

Q
A

Yii version
2.0.5

PHP version
5.6

Operating system
Ubuntu mate

Resolved by #12067


[Feature] Grading System - Participant Scores

Checklist

[x] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Client: I followed the coding and design guidelines.
[x] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
[x] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
[x] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes
[x] Client: I translated all newly inserted strings into English and German.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.

Motivation and Context

This PR integrates the grading system with the participant scores pages for courses and exams
Description

I've added an average grade and average rated grade on top of the participant scores pages.
In addition, the average scores table now also has an average grade and average rated grade columns.
Steps for Testing

Log in to Artemis
Navigate to Course Administration -> Grading Key
Create a Grading Key
Navigate to Participant scores and verify that (the course should have at least one exercise submission)
a) an average grade and an average rated grade are displayed at the top of the page
b) in the average scores table to last two columns display an average grade and an average rated grade
Create a Grading Key for an exam
Go through step 4 again for the exam (the exam should have at least one submission)

Test Coverage

unchanged (100% for both participant scores components)
Screenshots

Tested on TS1. Might not be associated with this PR, but somehow the grading key is not stored after generation (see Screencast below), therefore of course the average grades cannot be displayed as well. I faced this problem for both the course and an exam.
2021-07-10.11-16-51.mp4

That's odd, I would have to check that out on a test server. I can't reproduce the issue locally. I would have to check it out on a test server. Was the save button constantly disabled and did you test only in your course?

It seems like there are still translation issues:

Also, currently, there are no german translations for both labels (German translation is still the English text)
I don't think this is in scope for this PR, but I want to mention it anyway:
The Participant Scores Button is present in the course management detail view of a course, but not in the course-management view that lists all courses. Also, while testing I was not quite sure how the average grade is calculated:

I would expect something between 4.7 and 5.0, is it rounded to the next possible grade?

@niclasschuemann The translation issue is what Lorena mentioned a few weeks ago in the team meeting. You have to refresh your browser cache and it should work.
Regarding your other comments, I think the Participant Scores button is not on the "overview" pages, but only on the detail ones because it's mainly used for debugging and is not as important.
The average grade is calculated entirely based on the average score -> whatever grade that average score would map to, is the average grade. This is similar to the calculation on the scores pages as well. The reason for that is simple, grades don't necessarily have to be a numeric value -> they could be A,B,C,D,E,F, if that is the type of grading key set. Such grades can't reasonably be averaged. In general, the grading key is discrete in terms of its values, so this gets propagated to the average grade as well.


Kevin/addtests

Adding new tests for miengine

Hi @kevindu7, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Please squash the commits into one.

Consider setting the email address associated with your commits to the email address you used to register on GitHub so that the commits show as associated to your GitHub account.

@kevindu7, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;


SAK-40852 - Update some dependencies

Please do not merge this issue, it needs a discussion about some dependencies.

I didn't test it, this PR has a WIP label and a needs discussion.
I'll test it on Monday


Add cache back in, for-in and many other improvements

Added for (... in ...)
Added facts merging
Created facts chain trait and use in it places for getting properties
Added caching (binary type definitions)

Only allows once cache at the moment
Only works for one definition file (start of the world, cannot interweave files)
Now on by default for the internal definition
Reduces time to startup

Created generic chain
Added lookup generics (for untyped collection types)

TODO

Fix SourceIds after cache (add content into cache)

Causes printing issues when arguments don't match parameters in a definition file

Resolve issues around generics?

I think TypeRestrictions is a cause

clippy

Currently doing some research in contravariance and covariance with respect to explicit generics. Not impossible but generics and structural type systems don't mix nice. Especially as my implementation tries to collect generics at the same time as subtyping of arguments against parameters (rather than two passes). We will get there!

https://www.youtube.com/watch?v=fKMwsRUwWzI

Just seen the date and diff count of this PR. Still lots to do but to prevent this dragging on forever (it was originally just to add the cache back), will merge now and open issues for the leftovers.


[html] HTML, script type=langid should properly tokenize any mode

Testing #16526
We used to be able to tokenize any mode inside a script tag, as long as the user provided the correct type attribute.

This is no longer supported. Browsers typically only support scripts of type javascript.
What does <script 'type=markdown'> mean anyway?

Many build tools support it. Some runtime tools do too. Python, TypeScript, CoffeeScript.

Requires a enhancement request to the textmate grammar we use (https://github.com/textmate/html.tmbundle)

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
If you disagree and feel that this issue is crucial: We're happy to listen and to reconsider.
Maybe you want to give it a try yourself and provide the feature through an extension or a PR: We're happy to give advise and get you started.
Thanks for your understanding. Thanks for helping and happy coding!


⚠ Bofrost.at has degraded performance

In cc30d5e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1066 ms

Resolved: Bofrost.at performance has improved in b2a1a7e after 9 minutes.


FeatureBinarizer: Skipping column 'X': data type cannot be handled

The solution to this problem is a simple one-liner. I will submit a pull request along with this issue. I'm just documenting the error so other people can find it.
FeatureBinarizer prints "Skipping column 'X': data type cannot be handled" for various integer and float subtypes that should be handled. The following code reproduces the problem.
import numpy as np
import pandas as pd
from aix360.algorithms.rbm import FeatureBinarizer

dtypes = np.dtype([
          ('int32', np.int32),
          ('int64', np.int64),
          ('float32', np.float32),
          ('float64', np.float64),
])

X = pd.DataFrame(np.array(np.arange(100)).astype(dtypes))
print(X.dtypes)

# Both fit and transform do not handle int64 and float32 though there should be no problem...
fb = FeatureBinarizer()
fb.fit(X);
fb.transform(X);

# Skipping column 'int64': data type cannot be handled
# Skipping column 'float32': data type cannot be handled
# Skipping column 'int64': data type cannot be handled
# Skipping column 'float32': data type cannot be handled

The problem is that the FeatureBinarizer class tests the type as follows:
for c in X.columns:
    if np.issubdtype(X[c].dtype, np.dtype(int).type) | np.issubdtype(X[c].dtype, np.dtype(float).type):
        pass
    else:
        print(("Skipping column '" + str(c) + "': data type cannot be handled"))

# Skipping column 'int64': data type cannot be handled
# Skipping column 'float32': data type cannot be handled

This can be resolved by using the generic numpy types integer and floating in the test.
for c in X.columns:
    if np.issubdtype(X[c].dtype, np.integer) | np.issubdtype(X[c].dtype, np.floating):
        pass
    else:
        print(("Skipping column '" + str(c) + "': data type cannot be handled"))

Thanks!


[tool_crash] ShaderCompilerException

Command
flutter run -d Chrome

Steps to Reproduce

...
...
...

Logs
ShaderCompilerException
#0      ShaderCompiler.compileShader (package:flutter_tools/src/build_system/targets/shader_compiler.dart:77:7)
<asynchronous suspension>
#1      writeBundle.<anonymous closure> (package:flutter_tools/src/bundle_builder.dart:184:25)
<asynchronous suspension>
#2      Future.wait.<anonymous closure> (dart:async/future.dart:522:21)
<asynchronous suspension>
#3      writeBundle (package:flutter_tools/src/bundle_builder.dart:162:3)
<asynchronous suspension>
#4      WebDevFS.update (package:flutter_tools/src/isolated/devfs_web.dart:843:9)
<asynchronous suspension>
#5      ResidentWebRunner._updateDevFS (package:flutter_tools/src/isolated/resident_web_runner.dart:488:35)
<asynchronous suspension>
#6      ResidentWebRunner.run.<anonymous closure> (package:flutter_tools/src/isolated/resident_web_runner.dart:283:41)
<asynchronous suspension>
#7      asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:24)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.3.2, on Microsoft Windows [Version 10.0.19044.2130], locale ko-KR)
    • Flutter version 3.3.2 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e3c29ec00c (6 weeks ago), 2022-09-14 08:46:55 -0500
    • Engine revision a4ff2c53d8
    • Dart version 2.18.1
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\jg348\AppData\Local\Android\Sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = C:\Users\USER\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.1)
    • Visual Studio at D:\vscode
    • Visual Studio Community 2022 version 17.3.32811.315
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 2020.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at C:\Users\jg348\AppData\Local\JetBrains\Toolbox\apps\IDEA-C\ch-0\212.5284.40
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.72.2)
    • VS Code at C:\Users\jg348\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.48.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19044.2130]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 106.0.5249.119
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 106.0.1370.52

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: e3c29ec00c9c825c891d75054c63fcc46454dca1

Hi @sovla, this issue was initially reported in https://github.com/flutter/flutter/issues/107590 and has since been fixed.
The fix is available on the master and beta channels and it should be available on stable some time in the future.
Per our triage policy, I'll be closing this issue since it has already been fixed.
Thank you


Config draggable

Not sure If is the nicest way of doing, but it works :dancer:
I'm looking forward to hearing from you~
Thanks!

Hi!
Yes, it is works, but it implemented not as I would like.
So I will add this feature myself with additional ability like: disable all time cells resizing, disable all time cells moving or disable concrete time cells and disable moving the ruler.
Thanks!

Ok <3

Done! You can see last 3 commits.


Add pronunciation assessment availability column

Add a column to STT languages table to show pronunciation assessment availability

@yinhew : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add MiqRequest factory with MiqApproval

Provide a MiqRequest factory which has an MiqApproval. Required to test that report_data is capable to query based on reason.
Related: https://github.com/ManageIQ/manageiq-ui-classic/pull/3274

@miq-bot add_label wip, test

@miq-bot remove_label wip

cc @martinpovolny

ping, @tumido ?

@bdunne : is it ok now?


[QUESTION] Tool Agent support for chatollama

There is a use case where I want to post URL API as soon as the user enters his name and phone number. This is working fine when I use chatOpenAI. I am attaching the screenshot for reference. This is the working use case. You can see the webhook post has been sent successfully.

I am trying the same flow except chatOpenAI has been replaced with with ollama running locally. But I am getting following error "Error: This agent requires that the "bindTools()" method be implemented on the input model.".

I am aware the tool agents supports models that supports function calling (such as chatOpenAI chatMistral). Any suggestions would be helpful.
Is there any other way the same use case can be accomplished with ollama running locally?
Warm Regards,
Karthick

for ollama, we need to add the integration dedicated for function calling - https://js.langchain.com/docs/integrations/chat/ollama_functions

Ah great, good to know I'm not the only one.
Is there an ETA on this. Happy to donate $50. Only for learning/testing atm.

Workarround: use ChatLocalAI block for Ollama with base url http://host.docker.internal:11434/v1, but this is without streaming

http://host.docker.internal:11434/v1

this doesn't seem to use the calculator tool for example:

illama itself works. it's the agent tools that is not.

@snailbrainx ,
Yes, I have tried too. It does not look like it used the tools "calculator."

@HenryHengZJ ,
If I understand correctly, this will be a new feature? When can we expect to see this on flowise? ETA, please?
Warm Regards,
Karthick

I have sponsored $50 if that helps.
This will allow a lot of people to run the tools agent locally.

here - https://github.com/FlowiseAI/Flowise/pull/2403

Hi @HenryHengZJ ,
Thank you very much for the enhancement/feature. I just have to upgrade the flowise to get this feature to work?
Warm Regards,
Karthick

here - #2403

Hi @HenryHengZJ ,
Please let me know how to use Tool System Prompt. You can give the tool system prompt #2403 for reference.
Warm Regards,
Karthick

here - #2403

Hi @HenryHengZJ ,
Please let me know how to use Tool System Prompt. You can give the tool system prompt #2403 for reference.
Warm Regards, Karthick

here - #2403

Hi @HenryHengZJ ,
Please let me know how to use Tool System Prompt. You can give the tool system prompt #2403 for reference.
Warm Regards, Karthick

here - #2403

Hi @HenryHengZJ ,
Please let me know how to use Tool System Prompt. You can give the tool system prompt #2403 for reference.
Warm Regards, Karthick

Because every LLM works differently, so the idea is for you to modify the prompt to have the LLM pick and use the tools appropriately. The PR will need to be merged in order to test it on Flowise

Hi @HenryHengZJ ,
In the meantime, I tried cloning the branch you have been working (feature/ChatOllama) built it and ran the flowise.
This is what I give in Tool System Prompt.

This is the output I got (Failed to parse a function call from mistral output: {"num1": 8, "num2": 9}).

I will wait for the merged code.
Warm Regards,
Karthick

@KarthickMani87 its generally not recommended to modify the tool prompt, i've added more description to it:

Under the hood, Ollama's JSON mode is being used to constrain output to JSON. Output JSON will contains two keys: tool and tool_input fields. We then parse it to execute the tool. Because different models have different strengths, it may be helpful to pass in your own system prompt.

Hi @HenryHengZJ , Thanks again for completing this feature.

Hi @HenryHengZJ ,
I have a question. In this flow, webhook got triggered only once when a name and phone number were received from a user.

But in the case of ollamaFunction, webhook is getting triggered every time. How to make it call the tool only for a specific condition in the chat? For example, I want to post URL only for name and phone number and the rest of the time it should just answer my questions.

How to make it call the tool only for a specific condition in the chat?

use Conversational Agent instead Tool Agent

OllamaFunction is no longer available in Flowise. Was that deliberate? What is the alternative, using Open Source tools?


Custom cells crashing on 5.1.0

meh, JNI DETECTED ERROR IN APPLICATION: attempt to return an instance of com.rubymotion.Hash from org.w3c.dom.DOMImplementation com.infinitered.bluepotion.PMBaseAdapter.item(int)

solved as of latest commit.