Contact Us form is overlapping with Footer

Description
In Contact Us page the form is overlapping with footer and when we enter the email id the UI is not good. I can resolve this issue please assign me this issue.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Please assign me this task as I have worked on web for long time

Please allocate this task to me. I'm capable of tackling it as I possess all the requisite skills to address the matter at hand.

Hello @Rakesh9100 sir
I would like to work on this issue as a contributor to the GSSOC. please assign this to me!
I have relevant skills that definitely help to enhance the website.

Hi PA, please assign me this issue. I would like to contribute.

Hey! Please assign this task to me. I would like to contribute.

For which screen size are you facing this overlapping issue as I can see it is perfect on the website @Akshita-8

For which screen size are you facing this overlapping issue as I can see it is perfect on the website @Akshita-8

For 90 percent zoom in screen size it is perfect but for 100 percent is it overlapping you can see in the attached screenshot below.

Okay proceed @Akshita-8

Thank you. Started working on it.

pls assign me this under gssoc 2k24

please assign this issue to me, i can work on this, i have made the local setup as well, i can make the changes, and resolve this issue

Go ahead @bhavanishanker-png

This is resolved now, pls work on new issues @bhavanishanker-png


cleanup: dry up files names in commit tables for git-hack

@kevgo @allewun
related to #471

:ship:


Any plan to upgrade to terraform version 1.2.7

Hi,
On my machine, I have "terraform 1.2.7" installed.
Terraformer version : Terraformer v0.8.21
I am using terraformer to import okta infrastructure. The problem is that the state file and terraform config files generated using "terraformer" conforms to the old terraform version "0.12.31" which conflicts with the version installed on my machine.
I use below command for the migration:
terraform state replace-provider "registry.terraform.io/-/okta" "registry.terraform.io/okta/okta"
By using above command, I am able to run "terraform init" command successfully but "terraform plan" fails as configuration file is incompatible with the okta provider used by the latest version of the terraform.
Error: Unsupported block type
│
│   on network_zone.tf line 2282, in resource "okta_network_zone" "tfer--Vendors-0020---0020-WNS":
│ 2282:   gateways {
│
│ Blocks of type "gateways" are not expected here. Did you mean to define
│ argument "gateways"? If so, use the equals sign to assign it a value.

│ Error: Missing required argument
│
│   on template_sms.tf line 1, in resource "okta_template_sms" "tfer--template_sms_Default":
│    1: resource "okta_template_sms" "tfer--template_sms_Default" {
│
│ The argument "template" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on template_sms.tf line 1, in resource "okta_template_sms" "tfer--template_sms_Default":
│    1: resource "okta_template_sms" "tfer--template_sms_Default" {
│
│ The argument "type" is required, but no definition was found.

Is there any way to make terraformer use the latest version of terraform? or any other way to resolve such issues?
Any leads would be highly appreciated.
Thanks,
Manisha Sharma

Hi, I think you're looking for this
https://github.com/GoogleCloudPlatform/terraformer/issues/1356

Thank you Samuel for your response. The link you specified above can help me install older versions of terraform on my machine which I can not do as the requirement is to use the latest terraform version.
I am required to use the latest version of terraform which has  "registry.terraform.io/okta/okta"  as okta provider. However, Terraformer uses the old version of terraform (0.12.31) and hence, the terraform files it generates conforms to the syntax/standard of the okta provider used by terraform version 0.12.31 which are not compatible with the terraform's latest version 1.2.7. Due to this "terraform plan" command fails with errors like "missing required argument" or "unexpected argument" etc.
Please let me know if there is any way to tweak terraformer to use the latest version of terraform.
Thanks
Manisha Sharma

I'm interested in this as well.  I managed to use terraformer to create TF and a statefile and then I used tfenv to install all the interim major versions of terraform and upgraded the state to the latest version.
That got me pretty far, but I still have the issue that my users are still creating AWS resources manually and I need to add them to the master terraform repo.  Not sure how that would be possible given the version mismatch.

not stale

Not stale, interested in this as well

Not stale, interested in this as well

not stale

Not stale - I'm interested in this as well!


Percentile doesn't work on scalars

According to numpy API, percentile can accept a scalar
from dask import array
res = array.random.random(10000, chunks=100)
array.percentile(res, 15)

traceback:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-57-4f859bf3a205> in <module>()
      1 from dask import array
      2 res = array.random.random(10000, chunks=100)
----> 3 array.percentile(res, 15)

~/anaconda3/envs/hello/lib/python3.6/site-packages/dask/array/percentile.py in percentile(a, q, interpolation)
     40             "Percentiles only implemented for 1-d arrays")
     41     q = np.array(q)
---> 42     token = tokenize(a, list(q), interpolation)
     43     name = 'percentile_chunk-' + token
     44     dsk = dict(((name, i), (_percentile, (key), q, interpolation))

TypeError: iteration over a 0-d array

dask version: '0.15.2'

I was able to reproduce this error

Same.  Thank you for the excellent error report @gabrielelanaro .  Is anyone willing and able to provide a pull request with a test and fix?

It looks like the issue is calling list on q, which might be a scalar array

Ah, I should learn to read my e-mail from top to bottom.  Thanks for the PR @jrbourbeau !


Auto-select components across workloads

I'm wondering: wouldn't it be better to select identical components across workloads?
Say I checked the MSBuild component inside ".NET desktop development", shouldn't it automatically be checked as well in "ASP.NET and web development" or any other workload that declares it?
Conversely, should deselecting a component from any workload imply it is removed from all workloads?

@odalet you're right. Each component that gets manually selected are always get included. If two identical component get checked, then two identical component also get included in --add parameter.
I suspect this would not generate problem in VS side. Albeit I should add conditional to check redundant --add.

Say I checked the MSBuild component inside ".NET desktop development", shouldn't it automatically be checked as well in "ASP.NET and web development" or any other workload that declares it?

I agree with this, but I fear this will be technically difficult to implement, for such simple behaviour.

I've fixed the duplicate problem in component args. I think this should be enough.


Start and end dates

Hello,
Is it possible to restrict the calendar date range, setting a startDate and endDate, or minDate and MaxDate ?
Thanks

For what purpose? The calendar always starts with the current month or week. Do you want to set the initial date for the view?

Closing issue due to lack of activity.


Add rate limiter

Since the real load during processing is on the backing Solr, a rate limiter is needed to avoid denial of service.

Introduced in a9f67c758299d3160af04d576eac0f67d88abf8e

Introduced in a9f67c758299d3160af04d576eac0f67d88abf8e


Add modification_commands' tests

@Krishnag09 I finished modification_commands.py, you can make the tests when you can

i will look into this soon, thanks.

@Krishnag09 Changes are done, you can start with the tests when you want


Recurrence-ID support

Currently, if a single item is overridden in the recurrence schedule, those overrides do not come through in 'overrides'.
See attached reproduction script:
require "bundler/inline"

gemfile do
  source "https://rubygems.org"
  gem "icalendar-recurrence", "~> 1.2"
  gem "icalendar"
  gem "activesupport"
  gem "byebug"
end

require "active_support"
require "active_support/core_ext"
require "icalendar/tzinfo"

ical_str = <<-ICAL
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
X-WR-CALNAME:Jubilee Street
X-WR-TIMEZONE:Australia/Sydney
BEGIN:VTIMEZONE
TZID:Australia/Sydney
X-LIC-LOCATION:Australia/Sydney
BEGIN:STANDARD
TZOFFSETFROM:+1100
TZOFFSETTO:+1000
TZNAME:GMT+10
DTSTART:19700405T030000
RRULE:FREQ=YEARLY;BYMONTH=4;BYDAY=1SU
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+1000
TZOFFSETTO:+1100
TZNAME:GMT+11
DTSTART:19701004T020000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=1SU
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=Australia/Sydney:20241017T113000
DTEND;TZID=Australia/Sydney:20241017T120000
RRULE:FREQ=WEEKLY;BYDAY=TH
DTSTAMP:20241018T072558Z
<EMAIL_ADDRESS>CREATED:20241018T053646Z
LAST-MODIFIED:20241018T053845Z
SEQUENCE:1
SUMMARY:Usual summary
TRANSP:TRANSPARENT
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Australia/Sydney:20241024T113500
DTEND;TZID=Australia/Sydney:20241024T120000
DTSTAMP:20241018T072558Z
<EMAIL_ADDRESS>RECURRENCE-ID;TZID=Australia/Sydney:20241024T113000
CREATED:20241018T053646Z
LAST-MODIFIED:20241018T053845Z
SEQUENCE:1
SUMMARY:Overridden summary
TRANSP:TRANSPARENT
END:VEVENT
END:VCALENDAR

ICAL

base_event, override = Icalendar::Calendar.parse(ical_str).sole.events

puts 'By ical'
puts base_event.summary
puts base_event.dtstart
puts base_event.dtend
puts override.summary
puts override.dtstart
puts override.dtend

occurence = base_event.occurrences_between(Date.parse("20 oct 2024"), Date.parse("30 oct 2024")).sole
puts 'By recurrence'
puts occurence.start_time
puts occurence.end_time

This prints
By ical
Usual summary
2024-10-17 11:30:00 +1100
2024-10-17 12:00:00 +1100
Overridden summary
2024-10-24 11:35:00 +1100
2024-10-24 12:00:00 +1100
By recurrence
2024-10-24 00:30:00 UTC
2024-10-24 00:30:00 UTC

Thanks for your report. This is working as currently expected, since the occurrences_between only has access to the single event.
I'm open to PRs to expand how this works so that occurrences_between understands the context of the whole calendar.


chore: update Quarkus to 2.16.1.Final

EVNT-812

FYI There's a Quarkus wiki with migration guides for all Quarkus versions: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.16. Considering the huge gap between versions in this PR, it may be a good idea to check everything between 2.8 and 2.16.

@gwenneg besides Micrometer returning metrics in Prometheus format, there does not seems to be a breaking change.

Checking logs of the service with test runs yields:
2023-02-06 15:31:28,128 ERROR [com.red.con.not.toC.splunk] (Camel (eventing-splunk) thread #3 - seda://push) IOFailure for event 5f987c17-4279-4783-b420-61cc50e1c802 (orgId REDACTED account REDACTED) to https://REDACTED:8088: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
2023-02-06 15:32:37,016 ERROR [com.red.con.not.toC.splunk] (Camel (eventing-splunk) thread #3 - seda://push) IOFailure for event a16ea4d4-b4d8-469d-bc7a-3822a2d2a5fc (orgId REDACTED account REDACTED) to https://REDACTED:8088: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

/retest

@gwenneg PTAL
Tests are failing only on unstable policies test.

Unstable policies test or product issue?  The test triggers a policy notification and waits up to 5 mins for it to appear in the event log before checking Splunk.  If it's timing out waiting for the event, the next step is to check the policy logs to see if the notification was sent.

@msager27 looks like a timeout. The logs on policies backend only have
SRMSG18256: Initialize record store for topic-partition 'platform.inventory.events-43' at position -1.

and
2023-02-08 09:54:40,037 INFO  [access_log] (executor-thread-1) "REDACTED - eventing-test-1 08/Feb/2023:09:54:40 +0000 "POST /api/policies/v1.0/policies?alsoStore=True HTTP/1.1" 201 299 orgId=REDACTED"
2023-02-08 09:54:40,038 INFO  [access_log] (executor-thread-1) "REDACTED - eventing-test-1 08/Feb/2023:09:54:40 +0000 "POST /api/policies/v1.0/policies?alsoStore=True HTTP/1.1" 201 299 orgId=REDACTED"
2023-02-08 09:59:58,242 INFO  [access_log] (executor-thread-1) "REDACTED - eventing-test-1 08/Feb/2023:09:59:58 +0000 "DELETE /api/policies/v1.0/policies/0382d3c9-ef60-439b-b8f1-af18fd5cf8c7 HTTP/1.1" 200 299 orgId=REDACTED"
2023-02-08 09:59:58,242 INFO  [access_log] (executor-thread-1) "REDACTED - eventing-test-1 08/Feb/2023:09:59:58 +0000 "DELETE /api/policies/v1.0/policies/0382d3c9-ef60-439b-b8f1-af18fd5cf8c7 HTTP/1.1" 200 299 orgId=REDACTED"

(from the UI container).

I reserved an EE namespace and ran the smoke test twice.  All tests passed in both runs.  I looked thru the policy pod logs, but didn't see any notification events logged.  Maybe I'm not looking in the right place.  I also looked at the notification logs.  Here's a sample excerpt:
2023-02-08 21:47:47,473 INFO  [io.sma.rea.mes.kafka] (vert.x-eventloop-thread-1) SRMSG18256: Initialize record store for topic-partition 'platform.notifications.ingress-0' at position -1.
2023-02-08 21:47:47,475 INFO  [com.red.clo.not.eve.EventConsumer] (executor-thread-0) Processing received action [id=null, rh-message-id=a4ee4080-76c0-47da-9fc6-4d7d9eb73bba, orgId=3340851, baet=rhel/policies/policy-triggered]
2023-02-08 21:47:47,484 INFO  [com.red.clo.not.pro.cam.CamelTypeProcessor] (executor-thread-0) Sending CloudEvent [orgId=3340851, integration=iqe-eventing-splunk-<IP_ADDRESS>-26d11077-4bbf-400e-a253-b754c06481ad, historyId=ba4c61d8-2533-4e05-b387-bd78cd228f77, originalEventId=a4ee4080-76c0-47da-9fc6-4d7d9eb73bba]
2023-02-08 21:47:47,539 INFO  [com.red.clo.not.eve.FromCamelHistoryFiller] (executor-thread-0) Processing return from camel: {"specversion":"1.0","source":"splunk","type":"com.redhat.console.notifications.history","time":"2023-02-08T21:47:47.535Z","id":"ba4c61d8-2533-4e05-b387-bd78cd228f77","content-type":"application/json","data":"{"duration":650494,"finishTime":1675892867535,"details":{"type":"com.redhat.console.notification.toCamel.splunk","target":"https://<IP_ADDRESS>:8088"},"outcome":"Success: Event ba4c61d8-2533-4e05-b387-bd78cd228f77 sent successfully","successful":true}"}
Ideally, it would be good to know if/where Policies logs events since that's more relevant in your case.  My namespace is ephemeral-drfjok and is reserved for 2 days.  Feel free to poke around the logs.
If your EE stays active after a pr_check run, we could perhaps do some troubleshooting live tomorrow.

@msager27 Thank you Mike! I think we can proceed with this.
Unfortunately Policies do not log much, and the logs within Notifications have overflown. I think that we should improve the Policies logging. Ibutsu (from prod) reveals some error around policy naming in some cases: Policy name is not unique.


obtain basic live data feed to update currently viewed stock

User Story
As a user, I want to obtain a basic live data feed to update currently viewed stock.
Detailed Description
Provide additional details and context.
Subtasks (Please also link task PRs here)

[]
[]
[]

I propose we use the following arch:

Backend acts as a proxy to get historical OHLC candlestick quote from finnhub (see here). As a free tier member, we get 1 year back, which isn't the best, but it's free. Note that for now, we don't cache anything yet so that it simplifies our system - also the free tier rate limits for finnhub are quite generous if we don't get a lot of traffic.
Backend also exposes a Websocket (WS) endpoint 'proxy' that allows client to subscribe to stock updates that come directly from finnhub's own websocket endpoint (only for currently viewed stock).

Then the frontend will operate as follows:

Fetch from our backend the data from 1M, 6M, 1Y ago to now (current time) depending on client's desired resolution.
Subscribe to WS endpoint as mentioned above to add new candlestick points to the chart as live data comes in, AS WELL AS updating the buy & sell widget's price quote.

This will segue to the 'use realtime info to trade stocks' (story #15) pretty nicely as we can piggyback from the (2) request as above to keep track of every stock's most recent prices.

@ChoiJ0527 @varun1729  if that sounds good to yall we can get started with this ^^

Sounds good! I'm assuming you're going to go into more details about the back-front connection in the meeting?

yes

don't forget to handle fetching for older data when the user scrolls / pans the graph to see older datapoints, as well as using the different resolutions - You can use the from , to & resolution query params as stated in the api docs


[DPE-5612] Update shared workflows version

This PR updates the shared workflows we use in our CI.
In addition, I also upgraded the GH actions checkout and download-artifact. This will prevent a nodejs version warning in the logs, and we were at risk of our CI breaking soon.

I would have separated the project update (not the CI workflow update) to a different PR

Yes, I need to be mindful of keeping things in scope. In that case however, I did not have much choice since the charm-lib dependencies group is required for the workflows, and scenario 6 breaks with ops 2.17

Oh I see. That's fine. Again, it was more of a niptick but I'm happy to hear that we are on the same page :D


Bug/Error: Max retries exceeded with url: /hf-coqui/XTTS-v2/main/model.pth

Initiating app.py after accepting the agreement then hitting this roadblock:
HTTPSConnectionPool(host='coqui.gateway.scarf.sh', port=443): Max retries exceeded with url: /hf-coqui/XTTS-v2/main/model.pth (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x00000192A0C3E3E0>: Failed to establish a new connection: [Errno 11004] getaddrinfo failed'))

Wow. It looks like they took access down. Appears the XTTS Model is still up on HF.. Do you have any suggestions for alternatives or workarounds?
https://news.ycombinator.com/item?id=38437743

If you download teh models from HF and place them under:
/home/${USER}/.local/share/tts/tts_models--multilingual--multi-dataset--xtts_v2 it should work, though I did not test this.

Awesome work by the way which is why I would love to see this continue on.
That being said, I’m on Windows and had already tried to put the models under a local directory. The folder tts_models… doesn’t exist but perhaps I need to create it.
I’m wondering if I could somehow change the URL listed under manage.py (somewhere I think it was in site-packages) to the HF URL, if this would work instead. But truthfully, it would be even better if we could specify in the UI where a model is locally installed, thereby bypassing any future issues with URLs disappearing.

But we did- the readme clearly indicate where the models are located on Windows:
C:\Users\ YOUR-USER-ACCOUNT \AppData\Local\tts\tts_models--multilingual--multi-dataset--xtts_v2

I just double-checked and there's no folder created by that name. However I had stuck those models in:
C:\Users\ YOUR-USER-ACCOUNT \AppData\Local\tts\
I did manage to circumvent that error now by manually creating that missing folder and dropping the models into there.
Perhaps it's not being created because the app hits the 404 first then spits out an error? It could on the other hand be a strange win 11 permissions error. However I would think that the directory would be created first and THEN the files would be downloaded to that directory.


Json string

Changes the way lists are printed, so they appear in Json notation.   Implements the ShowListsAsLisp property.
Still need to change runtime.scm to make use-json-format a macro.    Also need to implement the upgrader.

I updated the PR to comment out the upgrade code and the designer property.  This should now be ready for review.

@halatmit It doesn't work properly. Basically the ShowOldStyle is hidden, but it's default value is "false" so lists now only appear as JSON. We need a solution where ShowOldStyle is hidden and lists appear in the Companion in lisp syntax. We can discuss when we meet in person... this is tricky

Thanks for catching that.   We can discuss when we meet.
== Hal
Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Mon, Dec 5, 2016 at 8:39 PM, Jeffrey Schiller<EMAIL_ADDRESS>wrote:

@halatmit https://github.com/halatmit It doesn't work properly.
Basically the ShowOldStyle is hidden, but it's default value is "false" so
lists now only appear as JSON. We need a solution where ShowOldStyle is
hidden and lists appear in the Companion in lisp syntax. We can discuss
when we meet in person... this is tricky
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/856#issuecomment-265035369,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwLtxl3Q2xoqmlvl_pCHjJrgNYoeB1Xks5rFLzGgaJpZM4K8uBQ
.

@halatmit @afmckinney A version of this change has been pushed onto the ucr branch.


Authentication Error

Publishing2Dataflow works fine on my desktop. However, on my laptop the login fails.
Request Id:  some GUID
Correlation Id:  another GUID
Timestamp:  2022-02-24T15:17:31Z
Message:  AADSTS50011: The reply URL specified in the request does not match the reply URLs configured for the application: 'GUID [= ApplicationID of the Power BI Gateway]'.
Any idea what's going on?
In general, login does work for me on the laptop including PowerShell.

Hi Marcus,
thanks for your kind and prompt reply.
I have updated MicrosoftPowerBIMgmt on my laptop to 1.2.1077 (same as desktop).
Unfortunately, this doesn't help.

Starting from the bottom:
• login azure (desktop)
• login powershell (laptop)
• login in your app (laptop) - Why is it Gateway?
• login in your app (desktop) - Here it is Powershell!

Hi Frank,
just to be sure, you can run the following PowerShell command on desktop and laptop without error, but when running my app it comes to an error on laptop, with reference to the gateway?
Connect-PowerBIServiceAccount

Hi Marcus,
that is exactly the case.
Both, my desktop and laptop have its own enterprise gateway on the respective machine.
Both gateways are online (status).
I call your app from a shared .pbix file.
Only on the laptop I get the following error message when authenticating:
Request Id:  xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx [always different]
Correlation Id:  xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx [always different]
Timestamp:  2022-03-02T10:04:55Z
Message:  AADSTS50011: The reply URL specified in the request does not match the reply URLs configured for the application: 'xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx [Gateway-GUID]'.
Do you have any idea what's going on or why the gateway might be involved?

Hi Frank,
I have no idea why the gateway is involved.
Only the PowerShell script is executed, whose commands work for you in the manual execution.


Missing Popover

Popover is not implemented:
https://getbootstrap.com/docs/4.3/components/popovers/
Needs Popper/tether support.

@bestguy I have created a svelte component you might want to look at.
https://github.com/bgreenacre/svelte-popper
It's loosely based on react-popper (based on popper.js). Still a work in progress and I'm still learning some things about the node/npm ecosystem but I'd like your feedback on it. You can see a super basic example of it if you run npm run dev.

Awesome @bgreenacre !   I would love to try it out.  Will let you know if I can integrate it into this.

Hi @bestguy. Should I implement popover like tooltip?
<button id='btn'></button>
<Popover target="btn" ></Popover>

and Can I implement this as below?
<Popover target="...">
    <slot title></slot>
    <slot content></slot>
</Popover>

Or the props one?
<Popover title="" content="" target="" />

Hi @eddie0329, Thanks, I'd suggest we support:
<Popover title="Optional Title" target="blah">
  My popover content goes here.
</Popover>

And optionally allow title as slot for html content:
<Popover target="blah">

    Optional Title with HTML

  My popover content goes here.
</Popover>

Internally this would look like:
 export let title = '';

    <slot name="title">{title}</slot>

    {#if children}
      {children}
    {:else}
      <slot />
    {/if}

Hope this makes sense!

Released in v3.11.0 thank you all for the help!

Released in v3.11.0 thank you all for the help!


Keep track of notification results

Store the result of notifications in the database and add them to the job summary.
This will allow us to collect the list of bugs open during a job run.
AB#162995

We should also decouple updating a work item in our table, from updating a work item in ADO. This would give us benefits like:

Easy retry (if we fail to update a bug in ADO, we already know what state the work item should be in, we can try again later)
Easy to pause updating work items. For example if we have a bug where work items aren't rendered correctly
Easy to rate limit our ADO usage (only update as frequently as we're allowed(


feat: create value change component

What does this PR do?

[x] Create value change component

Can we apply the component to the profile widget?


Add Iroh to tools

Pre-submit checklist

[x] This PR includes only one addition, removal, or edit.
[x] I have followed the Contribution Guidelines.
[x] I reviewed the IPFS Community Code of Conduct to ensure my submission meets the requirements.

closing in favor of #493


Supporting Vue 2.7

I got the following error message when I trying install Vue 2.7
npm WARN Could not resolve dependency:
npm WARN peer vue@">= 2.5 < 2.7" from<EMAIL_ADDRESS>npm WARN node_modules/@vue/composition-api
npm WARN   peer @vue/composition-api@"*" from<EMAIL_ADDRESS>npm WARN   node_modules/feathers-vuex

Same issue here.  Any workarounds?


Error on Android building when using react native 0.76 version

Execution failed for task ':journeyapps_react-native-quick-sqlite:configureCMakeDebug[arm64-v8a]'.

[CXX1214]<EMAIL_ADDRESS>debug|arm64-v8a : User has minSdkVersion 23 but library was built for 24 [//ReactAndroid/hermestooling]

Updating the minSdkVersion setting in your app to 24 (or above) should resolve this issue. If using Expo this can be done with build properties.


Introduce USING keyword for language-related data

The idea is to make the (DDL/SDL) syntax for defining expressions and function bodies more consistent. So the general syntax would revolve around the USING keyword. Typically it would be USING lang ....
What this affects:

functions: instead of FROM ... simply become USING ..., but otherwise stay unchanged
operators: same as functions
casts: FROM type TO type remains unchanged, but the body definition changes to USING ... much like function bodies.
views: we will retain the shorthand CREATE VIEW foo := <expr>, but instead of using SET expr := <expr> in the long form, the syntax will be USING <lang> "<expr>" or USING <expr>
computables: similarly to views they will retain the := shorthand, but will switch to USING clause instead of SET expr := ...

One of the big changes is to drop the rather obscure SET expr := ... syntax in favor of the somewhat more natural USING ... syntax. However, constraints, for example, will retain their SET expr := ... because it is not a shorthand for ON (...).

Done in master.


Sip session timeout fix etc.

RTC.Session._runSessionTimer() was only firing the first time, as a result the sip session would expire at about 130 seconds.
Moved this._handleSessionTimersInIncomingResponse(response); above the return statement in RTCSession.dart @ line 2448 which now ensures that the Session Timer gets re-scheduled.
Also prevented handling of empty data packets in WebSocketInterface.dart _onMessage(data) which was causing parser errors.
Inferred types where relevant and possible.

LGTM


Default Service URLs should be in secure protocol (HTTPS)

For example, in BotFrameworkDriver.php line 165
$apiURL = Collection::make($matchingMessage->getPayload())->get('serviceUrl', 'http://skype.botframework.com');

It should be:
$apiURL = Collection::make($matchingMessage->getPayload())->get('serviceUrl', 'https://skype.botframework.com');

When,
$botMan = app('botman');
$botMan->say($message, $channel, 'BotFramework');

Throws an error
Object MovedThis document may be found here
with 301 since API redirect to secure protocol.

Thanks for letting me know. I'll change it accordingly


hint_depth_texture causing infinite error output and engine lag

Godot version
4.0beta14
System information
Manjaro, 6.1.1 kernel, Ryzen 6950, Radeon 6900, amdgpu, Vulkan
Issue description
When attempting to utilize the new hint_depth_texture in any shader, the enginge lags and keeps outputting:
ERROR: Uniforms supplied for set (3):
Set: 3 Binding: 0 Type: UniformBuffer Writable: N Length: 128
Set: 3 Binding: 1 Type: Texture Writable: N Length: 1
Set: 3 Binding: 2 Type: Texture Writable: N Length: 1
Set: 3 Binding: 3 Type: Texture Writable: N Length: 1
are not the same format as required by the pipeline shader.  Is there another sampler2D in your shader?

Duplicate of https://github.com/godotengine/godot/issues/71739


Tuple parameters break validation of SafeSnap contract interaction transactions

When setting up a SafeSnap contract interaction transaction, where the function takes a tuple (struct) as a parameter, validation always fails. It works fine with non-tuple parameters.
Reproduce with this ABI:
[{"inputs":[{"internalType":"uint256","name":"_index","type":"uint256"}],"name":"complete","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"components":[{"internalType":"string","name":"text","type":"string"},{"internalType":"bool","name":"completed","type":"bool"}],"internalType":"struct Todos.Todo","name":"_todo","type":"tuple"}],"name":"create","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"internalType":"uint256","name":"","type":"uint256"}],"name":"todos","outputs":[{"internalType":"string","name":"text","type":"string"},{"internalType":"bool","name":"completed","type":"bool"}],"stateMutability":"view","type":"function"}]
There's a create function that takes a [string,bool] tuple and a complete function that only takes an uint256.

{"text":"some todo","completed":true} also does not work.

@carlosfebres could you take a look at this?

Thanks a lot for filing this @mktcode! I guess this was either a result of my reports in Gnosis Guild or Snapshot Discord, or maybe just a huge coincidence that we discovered this at the same time :-)
Either way, I did a bunch of reverse-engineering on the UI with a debugger last night together with a colleague.  We discovered that this validation code is relying on encodeFunctionData from ethers.js, and that the issue seems to be that while param.baseType === 'array' is special-cased to treat the value in the field as a string which needs to be parsed as JSON before feeding it to encodeFunctionData for validation, there is no equivalent special-case logic for param.baseType === 'tuple':
https://github.com/snapshot-labs/snapshot-plugins/blob/70c7c07497c8af7dcee953b583b17f709fba1457/src/plugins/safeSnap/utils/abi.ts#L90-L98
By setting a breakpoint at that point in the UI, and then manually performing the JSON parse from the browser dev console on the minified code via:
n[1] = JSON.parse(n[1])

I was able to get validation to pass and the UI to behave as expected.  So I suspect the fix is probably as simple as just doing the JSON.parse in both cases: when param.baseType is either 'array' or 'tuple'.

Thanks a lot for filing this @mktcode! I guess this was either a result of my reports in Gnosis Guild or Snapshot Discord, or maybe just a huge coincidence that we discovered this at the same time :-)

Ah sorry, only just noticed that you already replied to me on Discord with the link to this issue :man_facepalming:  We were working until 6am, so brain not functioning fully.  Thanks a lot again for taking the initiative to provide great follow-up on this!

@aspiers thanks for reporting the issue and providing a way to solve it, I will fix this today and update this issue

@aspiers @mktcode I've created a PR to solve this issue =D
https://github.com/snapshot-labs/snapshot/pull/1553


Point sizes not always absolute

🐛 Bug
Point sizes are absolute relative to image pixels when Viewer.camera.zoom is less than the size of the points .
size=4 gives points with a diameter of 4 image pixels but when zooming in beyond zoom=4 this is no longer true, they become smaller than 4 image pixels)

In the image above, at zoom 2.4 and zoom 4 the points are exactly 4 image pixels. At zoom 10 they are significantly smaller
To Reproduce
import napari
import numpy as np

viewer = napari.Viewer()

image = np.zeros((100, 100))
image[::2, ::2] = 1

viewer.add_image(image)

x = np.linspace(4, 94, 10, endpoint=True)
yy, xx = np.meshgrid(x, x)
yx = np.vstack((yy.flatten(), xx.flatten())).transpose()

viewer.add_points(yx, size=4, face_color='cornflowerblue')

Steps to reproduce the behavior:

run above example
play with zoom
note how point diameters are constant 4 image pixels (seen on grid below) at Viewer.camera.zoom < 4
note how point diameters become smaller than 4 image pixels at Viewer.camera.zoom > 4

cc @brisvag

As we already discovered, I cannot reproduce on my work computer. Apparently, I also cannot reproduce on my laptop. This is zoom 32:

napari: 0.4.9
Platform: Linux-5.12.9-arch1-1-x86_64-with-glibc2.33
System: Arch Linux
Python: 3.9.5 (default, May 24 2021, 12:50:35) [GCC 11.1.0]
Qt: 5.15.2
PyQt5: 5.15.4
NumPy: 1.20.1
SciPy: 1.6.3
Dask: 2.30.0
VisPy: 0.6.6

OpenGL:
- GL version: 4.6.0 NVIDIA 465.31
- MAX_TEXTURE_SIZE: 32768

Screens:
- screen 1: resolution 1920x1080, scale 1.0

Plugins:
- console: 0.0.3
- mrcfile-reader: 0.1.2
- napari-em-reader: 0.1.0
- napari-properties-plotter: 0.1.0
- scikit-image: 0.4.8
- svg: 0.1.5

really strange, thanks for the comparison @brisvag - here is my environment for comparison
napari: 0.4.9
Platform: macOS-11.2.1-x86_64-i386-64bit
System: MacOS 11.2.1
Python: 3.9.4 | packaged by conda-forge | (default, May 10 2021, 22:13:15)  [Clang 11.1.0 ]
Qt: 5.15.2
PyQt5: 5.15.4
NumPy: 1.20.3
SciPy: 1.6.3
Dask: 2021.05.0
VisPy: 0.6.6

OpenGL:
  - GL version:  2.1 Metal - 71.0.7
  - MAX_TEXTURE_SIZE: 16384

Screens:
  - screen 1: resolution 1440x900, scale 2.0

Plugins:
  - console: 0.0.3
  - scikit-image: 0.4.9
  - svg: 0.1.5

Based on vispy/vispy#2078, it looks like this is a GL-driver-specific issue and therefore not something napari can do much about, so I think we should close this. @alisterburt feel free to reopen if you think I've made an erroneous assessment!

No need to reopen this, but it looks like the visualized diameter of the points is never 4 at any of these zooms. At a zoom of 2.4 and 4, in the original image, it looks like the diameter is about 5.75.
@alisterburt : am I missing something about the setup here, or can I simply not count? As part of my work on #3132, I'm trying to understand if the size we pass to vispy has a direct correspondence to some size in world coordinates. Based on this, it seems like it doesn't.

you're right @andy-sweet - I just can't count! I think you're right about the size correspondance, maybe we should try to fix that

I'm reopening this because of what @andy-sweet mentions in his comment above - point sizes should be absolute from the napari side (with the caveat that they only increase up to a limit set by a combination of GL/drivers/hardware)

Cool, I'll leave open because of point 2 - it really feels to me like the diameter of the disc/longest axis of the marker should be absolute, I was imagining a simple scale-factor on the napari size as you suggest. Glad it doesn't block you on #3132 though

I completely missed this when it got posted. I havn't had time to read yet, but I'd like too

This will be addressed by vispy/vispy#2209!

Size relative to data was fixed by #3494.
import napari
import numpy as np

viewer = napari.Viewer()

image = np.zeros((100, 100))
image[::2, ::2] = 1

viewer.add_image(image)

x = np.linspace(4, 94, 10, endpoint=True)
yy, xx = np.meshgrid(x, x)
yx = np.vstack((yy.flatten(), xx.flatten())).transpose()

viewer.add_points(yx, size=5, face_color='cornflowerblue', edge_width=0)

https://user-images.githubusercontent.com/23482191/144435651-6120e9e9-056e-4cb0-96b7-c1106a971a82.mp4
The original issue (point size having a hard limit on mac, as per vispy/vispy#2078) is unfortunately not solvable here. We can either close this and leave it, or open another issue just for that so people can find it easily by searching the bug.

Thanks @brisvag - will close this!

I encountered something similar with 3D points: when I changed the scale, there seemed to be a maximum size limit of points. Is this an expected behavior, or possibly a bug related to this?
A code to reproduce this:
import napari
viewer = napari.Viewer()
viewer.add_points([[0, 0, 0], [0, 100, 100]],size=[10,100],shading="spherical")

https://github.com/napari/napari/assets/5919272/051ee3c7-e832-4e17-8d61-cbb1e49b845a

I see; thanks @brisvag for the clarification! I now understand it's a tricky thing, but I'm looking forward to seeing it solved at some point 😃


apply "templates/concept" and rename title to "DC/OS" from "DCOS"

apply templates/concept
I think we should use official name "DC/OS" rather than "DCOS"

preview is here
original

/assign @steveperry-53


Typo before 'https' on default "invite to discord message"

https://github.com/EnvyWare/API/blob/main/forge/src/main/java/com/envyful/api/forge/command/command/ForgeCommand.java#L76

Fixed in next version


Justina added her learning goal

I have specified my individual goal in the learning_goals.md file in Collaboration. Ready to be reviewed and merged

Teammate modified branch. I have to close and delete


Port LS2 from MATLAB -> Python

As titled.
I used Claude+ to port the code here:
https://github.com/SIO-Ocean-Optics-Research-Laboratory/LS2_Distribution
I then tested it with the LS2_test_run.m script.
Their Excel file can be viewed here:
https://docs.google.com/spreadsheets/d/1fnal1Mrh457vHLIZwkEqxv0wQKByCrPl/edit?usp=sharing&ouid=114694095617648510125&rtpof=true&sd=true
And compared to ours:
https://docs.google.com/spreadsheets/d/1HUap4u4nBUreB_ebBlw8eRURBdmqAFs1/edit?usp=sharing&ouid=114694095617648510125&rtpof=true&sd=true
This is also tested in the code base with test_ls2.py in tests/

If you're interested in multiple models, I ported some matlab code last year which recreates Roesler and Perry 1995's model here: https://github.com/patrickcgray/inverse_modeling/blob/main/inversemodelRC.ipynb. This is a classic and while not as optimized is basically the same form as all modern semi-analytical approaches. I was just on the boat all day with Matthew Kehrli Darisz' student.
I will take a look at this in the next day or two.

Whoa, that's quite the Notebook!
I'd happily slurp in the main methods,
if that were ok with you.
In a different PR ;)

Yes certainly okay to ingest and adapt. I did a big update and fixed a few bugs in the latest push before a lab we had this week so it is much better tested now.


[Fix] keyThereVal: number => string conversion

This is needed for feathers adapters that use a number as id instead of string (feathers-sequelize)

Btw, original error was: TypeError: currentId.includes is not a function (for line 170)

Yes, I'm running into the above error, would be great to get this merged in.

Same for me. We need this to get it to work with feathers-sequelize.
@marshallswain this also breaks feathers-graph-populate. It also throws the error: TypeError: currentId.includes is not a function (for line 170).
Is there anything to do to get this merged? I would like to help.

Oops.  I just merged it, but it's not passing all tests.  I don't have CI setup on this, yet, so the tests have to be manually run.

@fratzinger could you open a PR that addresses these tests?  I won't be able to do this for a week at least.

Of course! I'll have a look. Let's see how far I get :)

Released in<EMAIL_ADDRESS>


Reduce the size of the Docker Image

Right now the Image is like 500 MB or something I am not happy with it
I want to reduce to at least half.

Problem: I wanted to reduce my docker image for this : https://hub.docker.com/repository/docker/kitarp29/k8s-api
Tag:5.0 is around 500 MB and uses Golang image
I wanted to reduce it to half
Solution tried:
I tried using an Alpine image of Golang.
As it happens that Go' alpine doesn't have gcc installed. I added a RUN command in my Dockerfile.
Current DockerFile:
FROM golang:alpine3.17
WORKDIR /k8s-api
COPY . .
RUN apk add build-base gcompat && go mod tidy
CMD ["go","run","server.go"]
EXPOSE 8000

Blocker:
gcc is still not being installed in the container as it runs. When I run the container and try to access my Go Project the error I get is this:
❯ kubectl logs kube-ez -f
# command-line-arguments
/usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: exec: "gcc": executable file not found in $PATH

If I exec in the container and install gcc, then this works but RUN command doesn't;t seem to be dong it's job properly!

We reduced the Docker Image to around 30% with this Merge 🥳

We will try to reduce it further!

With the 7th version: Here
I applied a multistage build pattern. Made a binary on the build stage and used it to run the container.
Now the image size was: ~35 MB

Decreased the Docker Image size to 16MB from ~500MB !!
This is a decrease of about 97% 🥳
Yes, even I can't believe it.
Further reduced the size of the Golang Binary by removing the dependency of gcc
It was a trade-off between the speed of creating the container and the memory of the Docker Image.
But did it Finally!!

Great work kitarp

If someone reads to read more on this issue, refer this:
https://dev.to/kitarp29/reducing-docker-image-size-a67


Add simple semaphore.

Add a simple and fast semaphore implementation which should cover the most common use case of limiting the number of same-type workers.

Hi @darkdragon-001 as another random go user I like the idea 👍.
I'm not sure what the process of appetite of the golang team is. But I think they would want unit tests and some documentation before accepting this proposal.

@googlebot I signed it!

This is new API and as such should go through the proposal process. See https://go.dev/s/proposal-process. Thanks.
I'll note that I'm not sure this adds enough value over just using a channel.

I don't have any more time to work on this. Closing.


onTranslateEnd

I can't get onTranslateEnd to fire when filtering different layers, am I just being dumb?
If I remove the filter it fires as it should - I just don't need every layer to be moveable
<RInteraction.RTranslate     filter={(feature) => {         return feature.getProperties().type === 'moveable';     }}     onTranslateEnd={(e) => {         console.log(e);     }} />

When you pass a function in this manner, without useCallback, the function will get recreated at each update - this is what triggers the bug.
If you memoize the function, you will work around the bug.

Yes sorry, I had useCallback there previously and it worked ... until I added the filter. I switched to trying with returning only the layers I want moveable AND with useCallback and it is still not firing.
<RInteraction.RTranslate               layers={(layer) => layer.getProperties().type === 'moveable'}               onTranslateEnd={useCallback((e) => {                   console.log('event', e);               }, [])}           />

Thought I had it after trying out alpha.1 - but no, this still does not work:
<RInteraction.RTranslate                 layers={(layer) => layer.getProperties().type === 'moveable'}                 onTranslateEnd={useCallback((e) => {                     console.log('event', e);                 }, [])}             />

Using your own example for Interaction and Translate I can get onTranslateEnd to fire once and then it stops firing:
<RInteraction.RTranslate                     filter={(feature) => feature.get('name') === "Place d'Italie"}                     onTranslateEnd={React.useCallback((e) => {                         const f = e.features.item(0);                         const coords = toLonLat(f.getGeometry().getFirstCoordinate());                         setMsg(                             You placed ${f.get('name')} at ${coordsToString(
coords,
)},                         );                     }, [])}                 />

My bad, you were referring to adding useCallback to the filter attr 🤦♂


docker builds for scorecard cron

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
N/A

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
Docker builds are broken for scorecard cron.

What is the new behavior (if this is a feature change)?
Fixed the docker build for scorecard cron and as well as updated the
integration to test for the docker builds.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
None

Other information:

Enabled the cloudbuild for cron now. It should be building the latest image as we merge to master.


ThreadIterator_AddFindRemove test is flaky

See, for example (links will go stale):
http://build.chromium.org/p/client.dart/builders/vm-linux-release-x64-be/builds/10678/steps/tests/logs/stdio
http://build.chromium.org/p/client.dart/builders/vm-linux-release-x64-be/builds/10671/steps/checked_tests/logs/stdio
http://build.chromium.org/p/client.dart/builders/vm-arm64-sim-release-be/builds/8169/steps/tests/logs/stdio

Duplicate of #24692 .


dht contact bug

2017-01-23 14:59:11,554 CRITICAL twisted:154: Unhandled Error
Traceback (most recent call last):
  File "/home/grin/.virtualenvs/lbry/local/lib/python2.7/site-packages/twisted/python/log.py", line 84, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/home/grin/.virtualenvs/lbry/local/lib/python2.7/site-packages/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/home/grin/.virtualenvs/lbry/local/lib/python2.7/site-packages/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
  File "/home/grin/.virtualenvs/lbry/local/lib/python2.7/site-packages/twisted/internet/posixbase.py", line 597, in _doReadOrWrite
    why = selectable.doRead()
--- <exception caught here> ---
  File "/home/grin/.virtualenvs/lbry/local/lib/python2.7/site-packages/twisted/internet/udp.py", line 248, in doRead
    self.protocol.datagramReceived(data, addr)
  File "/home/grin/code/lbry/lbry/lbrynet/dht/protocol.py", line 158, in datagramReceived
    self._node.addContact(remoteContact)
  File "/home/grin/code/lbry/lbry/lbrynet/dht/node.py", line 385, in addContact
    self._routingTable.addContact(contact)
  File "/home/grin/code/lbry/lbry/lbrynet/dht/routingtable.py", line 403, in addContact
    self._replacementCache[bucketIndex].append(contact)
exceptions.KeyError: 0

@kaykurokawa is this fixed?

I'm getting this also (over and over and over again, heh).  It was using as much CPU as it could grab and a substantial chunk of RAM too (and i have 16 gigs).
I had installed per the https://lbry.io/quickstart/install instructions for Linux.
Started the lbrynet-daemon and it had been running since, with not deleterious effects that i was aware of.
I had suspended the computer and changed locations a few times already with no incident.  The only possible thing i can think of now being different is that it took a while to reconnect to the wifi network this time.  Maybe this error could be triggered by not having network access for a time?

It was running at full resource hog mode for about an hour before i ctrl+Cd it.  There was one other set of error messages i got (showing much more occasionally than the constant of the error lyoshenka already reported) that is not reported yet, "lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK".  For those who want the full flavor, here's a slice of the errors it kept spitting out:
2017-03-20 18:40:29,109 CRITICAL twisted:154: Unhandled Error
Traceback (most recent call last):
  File "site-packages/twisted/python/log.py", line 86, in callWithContext

  File "site-packages/twisted/python/context.py", line 118, in callWithContext

  File "site-packages/twisted/python/context.py", line 81, in callWithContext

  File "site-packages/twisted/internet/posixbase.py", line 597, in _doReadOrWrite

--- <exception caught here> ---
  File "site-packages/twisted/internet/udp.py", line 249, in doRead

  File "site-packages/lbrynet/dht/protocol.py", line 160, in datagramReceived

  File "site-packages/lbrynet/dht/node.py", line 385, in addContact

  File "site-packages/lbrynet/dht/routingtable.py", line 403, in addContact

exceptions.KeyError: 0

2017-03-20 18:40:29,224 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,224 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,225 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,225 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,225 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,226 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,226 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,227 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,227 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
2017-03-20 18:40:29,227 WARNING  lbrynet.dht.protocol:262: Can't send data to dht: EWOULDBLOCK
Unhandled Error
Traceback (most recent call last):
  File "site-packages/twisted/python/log.py", line 86, in callWithContext

  File "site-packages/twisted/python/context.py", line 118, in callWithContext

  File "site-packages/twisted/python/context.py", line 81, in callWithContext

  File "site-packages/twisted/internet/posixbase.py", line 597, in _doReadOrWrite

--- <exception caught here> ---
  File "site-packages/twisted/internet/udp.py", line 249, in doRead

  File "site-packages/lbrynet/dht/protocol.py", line 160, in datagramReceived

  File "site-packages/lbrynet/dht/node.py", line 385, in addContact

  File "site-packages/lbrynet/dht/routingtable.py", line 403, in addContact

exceptions.KeyError: 0

2017-03-20 18:40:29,264 CRITICAL twisted:154: Unhandled Error
Traceback (most recent call last):
  File "site-packages/twisted/python/log.py", line 86, in callWithContext

  File "site-packages/twisted/python/context.py", line 118, in callWithContext

  File "site-packages/twisted/python/context.py", line 81, in callWithContext

  File "site-packages/twisted/internet/posixbase.py", line 597, in _doReadOrWrite

--- <exception caught here> ---
  File "site-packages/twisted/internet/udp.py", line 249, in doRead

  File "site-packages/lbrynet/dht/protocol.py", line 160, in datagramReceived

  File "site-packages/lbrynet/dht/node.py", line 385, in addContact

  File "site-packages/lbrynet/dht/routingtable.py", line 403, in addContact

exceptions.KeyError: 0

Killing the daemon gave the "Can't stop reactor that isn't running" error message mentioned in #544, among other output, but i doubt any of that output is relevant to this issue.  Let me know if you want it though!

@jimmykiselak any idea what this is, before we dig deeper?

@lyoshenka nope, haven't seen that before.


v0.4 - No LCD character prompt on hard reset

(Self-logging some known issues to fix before v1.0)
Upon reset after a full power disconnection, there's no prompt character '>' on LCD.
Seems to work fine afterwards.

Found the problem. When we wipe the ram, we lose the spot in memory that stores the minimum and maximum acceptable ASCII ranges for printing.
Created some instructions to re-initialise the min and max ASCII ranges (stored in $02B4 and $02B5). Now the arrow is back!


Reorganize directory structure

Reorganize and improve folder structure
Cleanup various nomenclature

We should throw Bundle into containers.

@unruffledBeaver I'm gonna do that.

Wait, since we're on this we should pull out magic imports

@unruffledBeaver @rynocouse https://github.com/MadeInHaus/react-redux-webpack-starter/pull/35/commits/8236770a1c1cae644335a6d4af9cdc16cd6e03bc

If we're all good on this, I'd like to merge :)


undefined is not an object (evaluating _reactNative.UIManager.RNVidroProcessing.Contatns)

Getting the following error on startup up, iOS attached screenshot

https://github.com/shahen94/react-native-video-processing/issues/113#issuecomment-335081401


ADD TO 1.18

Hi its a great plugin pls add to 1.18 cause we'd like to include it in our personal server

Magic has supported 1.18 since the day Spigot supported it.
If you're having issues please open a more specific issue with details.


Comma in example code and dialog mixin js path in readme

Added a comma in options example. Fixed wrong dialog mixin js path where /dist was missing.

Thank you @pankajsanam 🙌


pytorch native mixed precision and IABN

Hi,
I am currently working with the TResNet model, training with mixed precision. Regarding the IABN model, for Nvidia apex O2 level, it is needed to recast the module to float32. Is this also necessary when using the native pytorch mixed precision methods, introduced in pytorch 1.6?
Best regards,
Joakim Haurum

i haven't tried PyTorch 1.6 with Inplace-ABN, but my guess is that the (simple) casting is still needed:
(see https://github.com/mrT23/TResNet/blob/master/INPLACE_ABN_TIPS.md,  'NVIDIA Apex mixed precision
' section)
The reason is that Inplace-ABN is not an integral part of PyTorch, so basic 'if' condition for casting are not catched.
If you do try it and find out otherwise, let me know
Tal

Hi Tal,
I looked around in PyTorch docs and asked on the forums. It appears that the native PyTorch implementation is similar to Apex O1, so the explicit conversion should not be necessary :) I will therefore close the issue.
Link to PyTorch forum discussion: https://discuss.pytorch.org/t/understanding-pytorch-native-mixed-precision/98535
-Joakim


Wrong character being inserted when period key is pressed

Description
I'm facing an strange behavior, where, for no reason and happening at random moments, my period key begins to insert the '>' character instead the period one.
I couldn't figure out yet a pattern or even steps to reproduce it, since this bug happens randomly.
The only way I found to fix it is rebooting.
Facing this problem on Ubuntu Linux, Atom v.1.5.3 and French (Azerty) keyboard.
Steps to Reproduce
Couldn't find a pattern or steps to reproduce yet.
Expected behavior: When the period key is pressed, a period mark should be inserted on text.
Actual behavior: When the period key is pressed, the symbol '>' is placed instead.
Versions
Atom: v1.5.3
APM: v1.0.1
NPM: v2.5.1
Node: v0.10.35
Python: v2.7.6
Git: v1.9.1

This is a duplicate of atom/atom-keymap#35 - feel free to subscribe there for updates.  As a workaround you can try installing the keyboard-localization package.

Thanks for the quick responde @50Wliu !


Fix unit formatting

This PR is ready for review now. Read the changes to docs/tutorial/units.md first to get an idea of what the whole change is before looking at the code.

It looks like big change. and It would be nicer to give more accurate formatting for users. :)
For unformatting, iLib gets data from CLDR. and CLDR defined 3 lengths (narrow, short and long) but the iLib doesn't use narrow length for unit formatting. Is there any you intention? Because other feature uses narrow data from CLDR.

Oh! Have you run test cases on QT/QML? It fails some cases in unit and util category.

All Qt tests are fixed now. Please try again.

Yes, regarding my question, it is not tightly related this PR. I just found that while looking UniFmt code.
I checked All of cased are Passed on QT/QML. Thanks!


#7003_StringFilterForm

solves issue https://github.com/OrchardCMS/Orchard/issues/7003

Hi @psp589, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@psp589, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


Uncaught TypeError: element.addEventListener is not a function

[Enter steps to reproduce below:]

Open any file
This happens

Atom Version: 1.2.0-dev-17d962f
System: Ubuntu 12.04.5
Thrown From: jshint package, v1.8.0
Stack Trace
Uncaught TypeError: element.addEventListener is not a function
At /usr/local/share/atom/resources/app.asar/src/delegated-listener.js:36

TypeError: element.addEventListener is not a function
  at listen (/usr/local/share/atom/resources/app.asar/src/delegated-listener.js:36:11)
  at [object Object].Tooltip.init (/usr/local/share/atom/resources/app.asar/src/tooltip.js:83:28)
  at new Tooltip (/usr/local/share/atom/resources/app.asar/src/tooltip.js:18:8)
  at TooltipManager.module.exports.TooltipManager.add (/usr/local/share/atom/resources/app.asar/src/tooltip-manager.js:50:17)
  at addReasons (/home/98255584072/.atom/packages/jshint/index.js:186:30)
  at displayError (/home/98255584072/.atom/packages/jshint/index.js:206:2)
  at /home/98255584072/.atom/packages/jshint/index.js:214:10
  at arrayEach (/usr/local/share/atom/resources/app.asar/node_modules/babel-core/node_modules/lodash/index.js:1289:13)
  at Function.<anonymous> (/usr/local/share/atom/resources/app.asar/node_modules/babel-core/node_modules/lodash/index.js:3345:13)
  at displayErrors (/home/98255584072/.atom/packages/jshint/index.js:213:4)
  at lint (/home/98255584072/.atom/packages/jshint/index.js:293:2)
  at complete (/usr/local/share/atom/resources/app.asar/node_modules/babel-core/node_modules/lodash/index.js:7697:25)
  at delayed (/usr/local/share/atom/resources/app.asar/node_modules/babel-core/node_modules/lodash/index.js:7707:11)

Commands
     -3:33.5.0 project-ring:toggle (atom-pane.pane.active)
     -1:46.3.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Config
{
  "core": {
    "disabledPackages": [
      "autocomplete-php",
      "pigments"
    ],
    "fileEncoding": "iso88591"
  }
}

Installed Packages
# User
atom-autocomplete-php, v0.10.11
atom-jshint, v2.0.0
autocomplete-html-entities, v0.1.0
autocomplete-modules, v1.1.0
jsformat, v0.9.0
jshint, v1.8.0
minimap, v4.13.3
minimap-pigments, v0.1.6
php-cs-fixer, v2.4.0
project-manager, v2.5.2
project-ring, v0.35.2
project-view, v0.1.2
recent-projects, v0.8.8

# Dev
No dev packages

:+1:

I get the same error, Atom Beta 1.1.0-beta1

:+1:

Yup this just started happening to me suddenly! Been using this fine for weeks.

I get the same error, Atom 1.1.0, Mac 10.11

why is this closed? Is it fixed?
[Enter steps to reproduce below:]

...
...

Atom Version: 1.1.0
System: Microsoft Windows 10 Home Single Language
Thrown From: jshint package, v1.8.1
Stack Trace
Uncaught TypeError: element.addEventListener is not a function
At C:\Users\rohan\AppData\Local\atom\app-1.1.0\resources\app.asar\src\delegated-listener.js:36

TypeError: element.addEventListener is not a function
    at listen (C:\Users\rohan\AppData\Local\atom\app-1.1.0\resources\app.asar\src\delegated-listener.js:36:11)
    at [object Object].Tooltip.init (C:\Users\rohan\AppData\Local\atom\app-1.1.0\resources\app.asar\src\tooltip.js:83:28)
    at new Tooltip (C:\Users\rohan\AppData\Local\atom\app-1.1.0\resources\app.asar\src\tooltip.js:18:8)
    at TooltipManager.module.exports.TooltipManager.add (C:\Users\rohan\AppData\Local\atom\app-1.1.0\resources\app.asar\src\tooltip-manager.js:50:17)
    at addReasons (C:/Users/rohan/.atom/packages/jshint/index.js:169:32)
    at displayError (C:/Users/rohan/.atom/packages/jshint/index.js:189:2)
    at C:/Users/rohan/.atom/packages/jshint/index.js:196:24
    at arrayEach (C:\Users\rohan\AppData\Local\atom\app-1.1.0\resources\app.asar\node_modules\babel-core\node_modules\lodash\index.js:1289:13)
    at Function.<anonymous> (C:\Users\rohan\AppData\Local\atom\app-1.1.0\resources\app.asar\node_modules\babel-core\node_modules\lodash\index.js:3345:13)
    at displayErrors (C:/Users/rohan/.atom/packages/jshint/index.js:196:4)

Commands
     -0:05.7.0 tree-view:toggle (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ],
    "destroyEmptyPanes": false
  }
}

Installed Packages
# User
atom-handlebars, v1.2.0
atom-jshint, v2.0.0
color-tabs, v0.1.8
css-color-underline, v1.0.1
file-types, v0.5.1
jshint, v1.8.1
language-spacebars, v0.2.2
linter, v1.9.1
linter-handlebars, v2.2.0
meteor-api, v2.20.0
webbox-color, v0.5.9

# Dev
No dev packages

Yeah this is certainly not fixed, I'm getting this issue right now.
Atom v1.1.0
jshint v1.8.1

Same issue here...
Atom 1.1.0
Jshint 1.8.1

:+1:
Same here ... and same versions ...
Atom 1.1.0
jshint 1.8.1
Ubuntu 14.04

:+1:

same here same versions again

Same here.

Atom Version: 1.1.0
System: Mac OS X 10.11.1
Thrown From: jshint package, v1.8.1

I am getting this issue too. I disabled all 3rd party packages, and still get the error.
Atom 1.1.0, Mac OSX 10.11.1, jshint 1.8.1


failed to read CA certificate(s)

Describe the bug
ocis sometimes gets the following fatal error on startup - see below.
Steps to reproduce
Run CI and sometimes:
https://drone.owncloud.com/owncloud/ocis/11077/50/5
latest: Pulling from owncloudci/alpine
Digest: sha256:326b0ab9ec8a2fe12247b5c54e37f7afd2daa179fe7bd2a3d376b2d3139d2297
Status: Image is up to date for owncloudci/alpine:latest
+ ocis/bin/ocis server
{"level":"fatal","service":"idp","error":"failed to read CA certificate(s) from '/root/.ocis/ldap/ldap.crt': open /root/.ocis/ldap/ldap.crt: no such file or directory","time":"2022-04-29T06:34:31Z","message":"could not bootstrap idp"}

Expected behavior
ocis starts without error
Actual behavior
"could not bootstrap idp"
Setup
drone CI

Can happen in API test pipelines as well as UI test pipelines, so it is not related to any difference between those (if any)
https://drone.owncloud.com/owncloud/ocis/11083/25/3


[Package Issue]: Git.Git 2.37.1

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
No applicable update found.
Brief description of your issue
Git.Git 2.37.1 manifest has been approved, but Git 2.37.0 is not updated.
Steps to reproduce
$  winget upgrade
No installed package found matching input criteria.
Actual behavior
$ winget list Git.Git
Name Id      Version Source
Git  Git.Git 2.37.0  winget
$  winget upgrade
No installed package found matching input criteria.
Expected behavior
Update from Git 2.37.0 to 2.37.1
Environment
$ winget --info
Windows Package Manager v1.2.11601
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.795
Package: Microsoft.DesktopAppInstaller v1.17.11601.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs
No response

This is because it has not been published yet - Note the PR does not have the Publish-Pipeline-Succeeded label on it.
Currently the publishing pipelines are experiencing issues and I’ve notified @denelon on Gitter; I’ll also tag @JohnMcPMS @hackean-msft and @ryfu-msft here since I know Denelon is on PTO

@Trenly Thanks for the details and the effort to resolve the issues about the pipelines.
I was asking because I submitted for the first time an unpdate for that manifest, then another contributor pushed another update, and I was not sure if I did something wrong.
Closing the issue.


Add config argument to getAccessTokenWithPopup

Description
Add workaround config argument to getAccessTokenWithPopup to work with iOS, similar to loginWithPopup.
References
https://github.com/auth0/auth0-spa-js/pull/368
Checklist

[x] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[x] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used, if not master

Thanks @ygist


Add pip check

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@danielhrisca and @hardbyte Can you review this pull request?


Missing fft-block-mac.py for x86_64-fma

Hello,
When I run configure.py, I get the following error:
Traceback (most recent call last):   File "./configure.py", line 396, in <module>     main(sys.argv[1:]).generate()   File "./configure.py", line 71, in main     build.peachpy("x86_64-fma/fft-block-mac.py"),   File "/usr/local/lib/python2.7/dist-packages/confu/builds/unix.py", line 72, in peachpy     source_path = validate_source_path(source_path, self.source_dir)   File "/usr/local/lib/python2.7/dist-packages/confu/validators.py", line 67, in validate_source_path     .format(source_path=source_path)) ValueError: Specified source file /home/weiyinko/Github/NNPACK/src/x86_64-fma/fft-block-mac.py does not exist
When I checked inside the directory, that file indeed does not exist. Is it ok if I comment out
build.peachpy("x86_64-fma/fft-block-mac.py") in configure.py or would that cause issues?

Should be fixed with 73af62e08af4464de68591dcda056890413a50d7


Ajax not work when create new string

Hello All,
Is it only me who has problem with new (localization) string creation?
When I try to create the new string the AJAX just keeps loading endless...
Could you please help me?
If you would have any question do not hesitate to ask me...
Thank you

I seems it was some PHP version issue beucase after PHP version update (from 5.4 to 5.6 it works fine now). Thanks!

Excuse me, but this error still exist with me.

@beysong - does it happen always, or sometimes? Please post a list of steps to reproduce the problem.


generator: handling embedded interfaces

I'm using an embedded interface as part of a response struct, and it fails with the error message "unable to resolve embedded struct for: Resulter".
Part of the code:
type Resulter interface {
	Result() (int, interface{}, error)
}

type jobResponse struct {
	// in: body
	Payload *partialJob

	Resulter
}

I can provide more details if that's desired. Should go-swagger ignore embedded interfaces?

yeah I think go-swagger should ignore embedded interfaces, at the very least we could add an annotation to make it be ignored

Seems like embedded interface does not cause error anymore, maybe this fixed it https://github.com/go-swagger/go-swagger/commit/6a060045f0c71475b6932bfd327387af081adcec
It seems the embedded interface is ignored (don't see it in generated json) but there is a function in scan/schema.go parseInterfaceType that parses interface. Given that the interface in Go can only have functions which will never be part of Rest API, why is interface parsed?

we have a pattern for discriminators. For those it parses the 0-arity methods as properties.


Support loading tokenizer from local folder

Maybe I missed something, but I am currently working on a swift mlx server implementation following the examples at https://github.com/ml-explore/mlx-swift-examples/blob/main/Libraries/LLM/Tokenizer.swift#L7. From my understanding, it seems like the tokenizer configuration has to be loaded via the hub API. I'm wondering if there is a way to load the tokenizer from a local folder instead of fetching it from the Hugging Face repo?

Thanks for the detailed explanation. I will play around a bit and see if I can make it work :)


spelling

Dependancy sounds fun but should really be dependency :)

ahh thx I'll fix it. Next time feel free to send PR directly ;)

It's the repo description, you have to do this by yourself @pleerock 😉

ah, okay


Filter by Feature

Nothing happens when clicking on "filter by feature" for municipal or regional district overlays.

[ ] Resolve "filter by feature" for map overlays

This was caused by a hard-coded URL root that was being masked in DLVR by the fact that the tileserver was still running on Legacy. I've made the URL relative to the arches root URL and stopped the tileserver on Legacy.


Loop Playlist Setting

we do not want a playlist to loop, as I find it quite annoying to not know if I finished an album or not. Maybe add in settings section once I get that together

Closed via 2dd8cd2212c8ea1fb272d0b5a7546425f24033dc


Document redact library

Once it is published, the @arcjet/redact library needs to be documented.

Completed by #58


Tiny web component(s) for registration and/or trademarks

Could we possibly create a web component to ensure all r-balls are superscripted and use character entities? This would allow us to not have to worry about changing the format from ® to <sup>&#174</sup> throughout content. Instead admins could just add <rh-rball></rh-rball>.

Some thoughts before we tackle this "tiny web component":

IMO, the "R ball" or ® (® or ®) is necessary content that should be part of the light DOM. So, using <rh-rball></rh-rball> removes this from the content—relying on JavaScript to add it.
I feel like a lot of content authors may be just copy/pasting content with the ® already embedded. Since it's a unicode character, this is easy to do for them.
Is typing or even training content authors to use <rh-rball> as easy as teaching them to wrap them with a <sup> at this point?

Fair points! Thanks for your feedback. We can probably close this out.
On Wed, Oct 10, 2018, 4:45 PM Mark Caron<EMAIL_ADDRESS>wrote:

Some thoughts before we tackle this "tiny web component":

IMO, the "R ball" or ® (® or ®) is necessary content that
should be part of the light DOM. So, using
removes this from the content—relying on JavaScript to add it.
I feel like a lot of content authors may be just copy/pasting
content with the ® already embedded. Since it's a unicode character, this
is easy to do for them.
Is typing or even training content authors to use  as
easy as teaching them to wrap them with a  at this point?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RHElements/rhelements/issues/202#issuecomment-428725192,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAb4nwyqaqxF1iNJNd6EraNMMLhBRdVYks5ujlxkgaJpZM4XT8Lu
.

--
KENDALL TOTTEN
FRONT-END ARCHITECT AND DEVELOPER
KENDALLTOTTEN.COM http://kendalltotten.com/

Ok, closingl


fix(docs): remove comment

Description
Fix a little leftover comment in the event example. Trying to up my diff count!
Scope

[ ] Patch: Bug Fix
[ ] Minor: New Feature
[ ] Major: Breaking Change

sure - added back in


[NG] Datagrid: Restrict to single row selection

[ ] bug
[x] feature request
[ ] enhancement

### Expected behaviour
Is single row selection is supported in Datagrid? I'm trying to restrict to single row selection but the selection always allow multiple row selection.

### Reproduction of behaviour
https://vmware.github.io/clarity/documentation/datagrid

### Environment details

* **Angular version:** 2.0.X

* **Clarity version:** 0.7.0

* **Browser:** [all]

@sivaah could you provide more information around your use case? Are you trying to select a single row to perform an action, copy content, etc?
I am trying to make sure we include that in Issue #17 which is filed on single row selection in datagrid.

@jaffoneh, Yeah.. Looks like duplicate of issue #17
The feature request is to restrict user to select only one row from Datagrid so that some action can be performed on that row. currently selection allows selecting multiple row.
Please mark this as duplicate of issue #17


See if we can use Jering.Javascript.NodeJS

Repo: https://github.com/JeringTech/Javascript.NodeJS
Mentioned here: https://github.com/aspnet/AspNetCore/issues/12890#issuecomment-554624959
This library allows the usage of Node.js from .NET via some form of IPC (haven't looked too far into it). Might be an interesting approach to consider, rather than embedding a JS engine in-process like we do today. Would be interesting as it'd give us support for several things we don't support today, like CommonJS modules.
I wonder if it could be added as an engine to JavaScriptEngineSwitcher? It's technically not the same as the other engines (which are all in-process) but perhaps we could have a facade that conforms to the same API.
cc @JeremyTCD

Similar to NodeServices?
https://github.com/aspnet/AspNetCore/tree/master/src/Middleware/NodeServices
I wonder what additional serialization overheads there are for crossing a
process boundary..
On Tue, Nov 19, 2019 at 21:02, Daniel Lo Nigro<EMAIL_ADDRESS>wrote:

Repo: https://github.com/JeringTech/Javascript.NodeJS
Mentioned here: aspnet/AspNetCore#12890 (comment)
https://github.com/aspnet/AspNetCore/issues/12890#issuecomment-554624959
This library lets us use Node.js via .NET. Might be an interesting
approach to consider, rather than embedding a JS engine in-process like we
do today.
I wonder if it could be added as an engine to JavaScriptEngineSwitcher?
It's technically not the same as the other engines (which are all
in-process) but perhaps we could have a facade that conforms to the same
API.
cc @JeremyTCD https://github.com/JeremyTCD
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/React.NET/issues/971?email_source=notifications&email_token=AAHGCFU3IOY47NH5WZ4ZPNLQUTAFRA5CNFSM4JPNKE22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2STDAA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGCFWH33ZXFBRJUOYGYI3QUTAFRANCNFSM4JPNKE2Q
.

Latency
Latency is acceptable (Jering.Javascript.NodeJS.INodeJSService vs Microsoft.AspNetCore.NodeServices.INodeServices default implementations):

Method
Mean
Error
StdDev
Gen 0
Gen 1
Gen 2
Allocated

INodeJSService_InvokeFromFile
108.0 us
0.82 us
0.76 us
2.4414
-
-
9.87 KB

INodeJSService_InvokeFromCache
104.5 us
0.58 us
0.54 us
2.1973
-
-
9.71 KB

INodeServices
112.4 us
0.78 us
0.73 us
1.7090
-
-
7.72 KB

BenchmarkDotNet=v0.12.0, OS=Windows 10.0.18362
Intel Core i7-7700 CPU 3.60GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.0.100
  [Host]     : .NET Core 3.0.0 (CoreCLR 4.700.19.46205, CoreFX 4.700.19.46214), X64 RyuJIT
  DefaultJob : .NET Core 3.0.0 (CoreCLR 4.700.19.46205, CoreFX 4.700.19.46214), X64 RyuJIT

For reference, the in process Node.js library, edge.js, is ~4x faster:

Method
Mean
Error
StdDev
Gen 0
Gen 1
Gen 2
Allocated

EdgeJS_InvokeFromString
25.10 us
0.331 us
0.310 us
0.0916
0.0305
-
507 B

BenchmarkDotNet=v0.12.0, OS=Windows 10.0.18362
Intel Core i7-7700 CPU 3.60GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
  [Host]     : .NET Framework 4.8 (4.8.4018.0), X86 LegacyJIT
  DefaultJob : .NET Framework 4.8 (4.8.4018.0), X86 LegacyJIT

Unfortunately it isn't compatible with .Net Core.
For our own use, Jering.Javascript.NodeJS's latency is negligible relative to JS logic execution time. JeringTech.Javascript.NodeJS just uses HttpClient for IPC. The fact that it's usable is testament the .Net team's work.
Relationship with NodeServices
Functionally the difference between the libraries is that JeringTech.Javascript.NodeJS allows for invoking of in-memory JS - strings, streams etc. We squeezed out a bit more performance and we don't invoke scripts from the temp directory, so JeringTech.Javascript.NodeJS is more secure.
Apart from all that we made some quality of life improvements like supporting async JS functions, AspNetCore-idiomatic configuration and better test coverage.
If you guys decide to use JeringTech.Javascript.NodeJS feel free to let me know, am happy to help.

Similar to NodeServices? https://github.com/aspnet/AspNetCore/tree/master/src/Middleware/NodeServices I wonder what additional serialization overheads there are for crossing a process boundary..
…

FYI: Node services are slated to be deprecated and will no be a part of 5.0.
The same thread was looking for people to make it a community project.

I wonder if it could be added as an engine to JavaScriptEngineSwitcher? It's technically not the same as the other engines (which are all in-process) but perhaps we could have a facade that conforms to the same API.

@Daniel15 Jering.Javascript.NodeJS is focused only on working with modules, i.e. we don’t have the ability to execute and evaluate regular JS code (always need to specify exports). As far as I understood that the service unlike the engine does not store any state except the cache of modules, i.e. each call occurs independently of the others. In general, this is a fundamentally different architecture.

@Taritsyn You can execute regular JS code, it just needs to be wrapped in a function assigned to module.exports.
string regularJavascript = @"
";
string javascriptModule = @"
module.exports = (callback, x, y) => {  // Module must export a function that takes a callback as its first parameter
    var result = x + y; // Your javascript logic
    callback(null /* If an error occurred, provide an error object or message */, result); // Call the callback when you're done.
}";

// Invoke javascript
int result = await StaticNodeJSService.InvokeFromStringAsync<int>(javascriptModule, args: new object[] { 3, 5 });

@Taritsyn You can execute regular JS:
const string javascriptModule = @"
module.exports = (callback, x, y) => {

    var result = x + y; // Regular JS here

    callback(null, result);
}";

// result == 8
int result = await StaticNodeJSService.InvokeFromStringAsync<int>(javascriptModule, args: new object[] { 3, 5 });

And you can cache results:
const string javascriptModule = @"
var lastResult;

module.exports = (callback, x) => {

    var result = x + (lastResult ? lastResult : 0); // Use cached value here
    lastResult = result; // Cache

    callback(null, result);
}";

// result == 3
int result = await StaticNodeJSService.InvokeFromStringAsync<int>(javascriptModule, "customIdentifier", args: new object[] { 3 });

// result == 8
result = await StaticNodeJSService.InvokeFromStringAsync<int>(javascriptModule, "customIdentifier", args: new object[] { 5 });

The CommonJS syntax does take some getting used to, but (at least in our case) it's worth it because we get access to Node.js's modules. E.g you can use the worker threads module to parallelize CPU bound work like SSR.

@JeremyTCD Modification of JS code for a specific engine does not quite correspond to main concept of the JavaScript Engine Switcher:

JavaScript Engine Switcher determines unified interface for access to the basic features of popular JavaScript engines (ChakraCore, Jint, Jurassic, MSIE JavaScript Engine for .NET, NiL.JS, Microsoft ClearScript.V8 and VroomJs). This library allows you to quickly and easily switch to using of another JavaScript engine.

@Taritsyn Took a look at IJsEngine and I think it can be implemented. Stuff like executing plain JS, pre-compiling and setting variables etc could be done with a JS interop layer, e.g interop.js:
var variables = {};

module.exports = {
    execute: (callback, javascript) => {

        // Evaluate and execute

        callback(null, result);
    },
    setVariableValue: (callback, value) => {

        // Set variable

        callback(null);
    }
}

That said you're right, Node.js technically isn't an engine, so it does not fit with the concept/theme of your project. For strict semantic correctness, another layer on top of both libraries would be necessary.

Stuff like executing plain JS, pre-compiling and setting variables etc could be done with a JS interop layer, e.g interop.js:

Interesting idea.

@JeremyTCD Two months ago I experimented with ES modules in the ChakraCore, but unfortunately I could not convince the authors of this library that the JsModuleEvaluation method should return a result.

@Taritsyn Node.js wraps any code you try to run on it with the following strings:
https://github.com/nodejs/node/blob/917fedd21ae07c6fac10681c9393a2c7652a5f1e/lib/internal/modules/cjs/loader.js#L174-L177
(function (exports, require, module, __filename, __dirname) {
    // User's javascript that exports stuff
    module.exports = ...
});

Not very familiar with your library so I don't know if it'll help. Does this affect whether you can incorporate Jering.Javascript.NodeJS?

@Taritsyn Node.js wraps any code you try to run on it with the following strings, from loader.js:
const wrapper = [
  '(function (exports, require, module, __filename, __dirname) { ',
  '\n});'
];

You could get the exports by doing the same thing:
(function (exports, require, module, __filename, __dirname) {
    // User's javascript that exports stuff
    module.exports = ...
});

Not very familiar with your library so I don't know if it'll help. Does this affect whether you can incorporate Jering.Javascript.NodeJS?

Does this affect whether you can incorporate Jering.Javascript.NodeJS?

I have long been asked to implement such functionality. As soon as I have free time I will try to make a module based on the Jering.Javascript.NodeJS library.

@Taritsyn Oh I see. Let me know if you need any help with Jering.Javascript.NodeJS. Feel free to tag me if you open a pull request on your repo to add it.

We made a library today, it is almost compatible with React.NET API, https://github.com/DaniilSokolyuk/NodeReact.NET, we use worker threads for rendering

@DaniilSokolyuk Looks interesting. How does performance compare with React.NET?

There is a benchmark suite in this project you can use if you’d  like to
compare render times.
A fork of this project is a great place to start, and later we can figure
out how to work it in after experimenting.
Later on... we could add an optional INodeService that lives in React.Core,
and create a new project React.NodeServices that provides an implementation
of it. I’d be a bit worried about having React.Core depending on any more
packages than it has to :)
I agree that it seems a bit out of scope for JsEngineSwitcher but would not
be opposed to deferring to an implementation in that project if there’s a
clean way to pull that off.
On Fri, Nov 22, 2019 at 08:36, JeremyTCD<EMAIL_ADDRESS>wrote:

@DaniilSokolyuk https://github.com/DaniilSokolyuk Looks interesting.
How does performance compare with React.NET?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/React.NET/issues/971?email_source=notifications&email_token=AAHGCFR6LLLEU7EG4GZT42LQVADCNA5CNFSM4JPNKE22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6FPXY#issuecomment-557602783,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGCFWYDWR5USE6AWFBGDLQVADCNANCNFSM4JPNKE2Q
.

I make benchmarks  but result is not good because this component does nothing. In our production application we see performance boost 10-20%  compared ZeroReact

@JeremyTCD @dustinsoftware
I am updated my banchmarks, now i use real production bundle and real production data
results is very good excluding allocations 😄

BenchmarkDotNet=v0.12.0, OS=Windows 10.0.17763.475 (1809/October2018Update/Redstone5)
Intel Core i7-7700 CPU 3.60GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.0.100
  [Host] : .NET Core 3.0.0 (CoreCLR 4.700.19.46205, CoreFX 4.700.19.46214), X64 RyuJIT

Job=InProcess  Toolchain=InProcessEmitToolchain

Method
Mean
Error
StdDev
Median
Gen 0
Gen 1
Gen 2
Allocated

NodeReact_RenderSingle
8.380 ms
0.4387 ms
1.2867 ms
7.831 ms
-
-
-
638.34 KB

ZeroReact_RenderSingle
14.106 ms
1.3290 ms
3.8345 ms
13.604 ms
-
-
-
4.73 KB

ReactJs_RenderSingle
12.027 ms
0.3590 ms
0.9705 ms
12.018 ms
-
-
-
898.66 KB

And bigger component

BenchmarkDotNet=v0.12.0, OS=Windows 10.0.17763.475 (1809/October2018Update/Redstone5)
Intel Core i7-7700 CPU 3.60GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.0.100
  [Host] : .NET Core 3.0.0 (CoreCLR 4.700.19.46205, CoreFX 4.700.19.46214), X64 RyuJIT

Job=InProcess  Toolchain=InProcessEmitToolchain

Method
Mean
Error
StdDev
Median
Gen 0
Gen 1
Gen 2
Allocated

NodeReact_RenderSingle
27.32 ms
1.047 ms
3.038 ms
26.93 ms
-
-
-
1262.37 KB

ZeroReact_RenderSingle
48.73 ms
2.198 ms
6.165 ms
48.48 ms
-
-
-
4.73 KB

ReactJs_RenderSingle
55.89 ms
2.289 ms
6.714 ms
54.03 ms
-
-
-
1305.15 KB

@dustinsoftware

Later on... we could add an optional INodeService that lives in React.Core,
and create a new project React.NodeServices that provides an implementation
of it. I’d be a bit worried about having React.Core depending on any more
packages than it has to :)

A separate project makes sense and @DaniilSokolyuk's project seems to do the job. I'll work on optimizing for his project instead.
I guess this thread has reached a conclusion?

@JeremyTCD I have the following conclusion: in coming days I will begin work on the JavaScriptEngineSwitcher.Node module. I will try to make a standard engine based on the Jering.Javascript.NodeJS.

@Taritsyn okay tag me in the pull request, am happy to help.

#1021

Continuing investigation in the linked pull request.


feat: add ReferenceFilterResolver type to referenceFilterOptions option

This already works, just adding the type

Wait I'm dumb, it doesn't work, let me implement it properly sorry

Wait I'm really dumb, the resolver should be on the filter field in the filterOptions. This already works...


Issue 740: OpenAPI v2 converter: java.lang.IllegalArgumentException with allOf and discriminatorr

Hi team,
This PR is to solve the illegal argument exception in swagger converter as mentioned in the issue #740
Please review the PR and merge the same.
Thanks,
Mohammed

Thank you for looking into this topic.
I am not part of the team, but I guess a unit test to cover your changes would be great.
Have a look at V2ConverterTest. You will need to add a new file like issue-740.yaml in swagger-parser-v2-converter/src/test/resources and a new test case in V2ConverterTest.
The example (issue-740.yaml) should be as small as possible.
Your test should be red before your change and should be green after that.
Let me know if you need some help.

This change looks good to me.
@ymohdriz Thank you for this contribution.
I recommend you to add a unit test to this PR.
As an example, I have created one https://github.com/jmini/swagger-parser/commit/da64e415e9e452e2e1bc5d488373a2a5d20d0e7d in my fork on top of your commit https://github.com/ymohdriz/swagger-parser/commit/e4da4965eaef44bdddb19183545edd4f1fa298ad.
Can you please integrate this commit (or a similar one) in this Pull Request?

Note: When merging this PR I recommend "Squash and merge" because the intermediate commit in this branch are not really useful.

Like @jmini pointed. I think it might be a good idea to add the test.

Hi @ralphdoe,
Sure I will add the junit test for this issue. In future, I will commit the junits along with the fix.
Thanks,
Mohammed

This PR has still no junit tests...
@ymohdriz feel free to just add my commit to your PR or to add something similar.
Thank you in advance.


Add epoch-based training support to lora.py

Adds epoch-based training functionality to lora.py. Previously, the script only allowed training iterations through manually specified iteration counts.

@wyanzhao  It's basically updating the logic in llms/mlx_lm/lora.py, can you synchronize that part of the commit to the llms/mlx_lm/lora.py script.

You can fork and update lora/lora.py as you like but won't merge these types of features into it with the intention of keeping it pretty simple.
If you have a change to trianing you could propose adding it to the LoRA functionality in MLX LM. If you're not sure, I encourage you to file an issue first!

Hi folks, I've updated the code in llms/mlx_lm/lora.py based on the feedback provided. Please take a moment to review the updated code. Thanks for your valuable feedback.

Hmm, I cannot reopen this PR. Can you reopen it?

Actually now I can


[Auto-generated] Update requirements.txt

Update requirements.txt
Automatically created PR from the ci_update_requirements.yml workflow.

Codecov Report

:exclamation: No coverage uploaded for pull request base (ci/dependabot-updates@71c29e9). Click here to learn what that means.
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@                   Coverage Diff                    @@
##             ci/dependabot-updates     #271   +/-   ##
========================================================
  Coverage                         ?   69.15%
========================================================
  Files                            ?       18
  Lines                            ?      522
  Branches                         ?        0
========================================================
  Hits                             ?      361
  Misses                           ?      161
  Partials                         ?        0

Flag
Coverage Δ

pytest
69.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Closing Plenary - Friday am

Jessica Hilt & Chrissy Rissmeyer

Jessica Hilt agreed to facilitate the closing plenary. She will need the following:

Note Cards
Pencils/Pens
~4 volunteers to hand out and collect note cards and help with sorting
1 note taker

Brian McBride - volunteered
Anna Headley - volunteered

Emily Stenberg - volunteered

Presenters both registered

Irene Taylor - volunteered
Deb Katz - volunteered


Change collapsed post fadeout to use mask-image

Back when we added collapsed posts, the only way I could figure out how to do the fade out effect was to overlay a div over the post text with a transparent gradient going to the colour of the post background. That ended up being a huge pain because it had to account for every single possible background colour that the post could have because that changes on hover, for pinned posts, after clicking a permalink, in the RHS, in a comment in the RHS, etc, etc. That also got worse over time because colours could get out of sync, especially when we started adding animations to the post effects.
Instead of all that, we can now use a CSS mask with a fading out gradient to mask the post contents, and that works without us needing to know and work out every single possible background colour. This also works with animations and transitions which previously looked pretty janky.
Screenshots

before
after

https://user-images.githubusercontent.com/3277310/215206615-c40faa57-8795-4792-adec-3487640049a8.mov
https://user-images.githubusercontent.com/3277310/215206689-f871998d-cac6-4f48-81ec-f48a38ecc037.mov

Release Note
Changed collapsed post fade out effect to be less buggy

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

Thanks @hmhealey
Looks great - just one small issue with "Show more/less" button

E2E report - no PR related failures

@jgilliam17 That should be fixed now. I definitely had that working at some point, and I must've removed that when I was cleaning up the code for submission


Add config files to add stuff to machines.

Much like https://github.com/SleepyTrousers/EnderIO/tree/master/resources/assets/enderio/config does, with their .xml files, it'd be great to be able to add stuff to machines.
Like Industrial Hemp Seeds from Immersive Engineering to the crusher to get bio fuel for instance.

I integrate with the IMC API which should allow for other mods to easily add their own materials to Mekanism's processing.  Perhaps I'll consider adding a user entry-defined way to add recipes in the future, but I'm happy with the functionality at the moment.