epic2-bw KeyError: 'required_flag' , doesn't appear in arg parser

Hi, I'm trying to run the following epic2-bw command and am getting a KeyError: 'required_flag'.
`epic2-bw --treatment TREATMENT --control CONTROL --genome GENOME --bin-size 100 --guess-bampe --log2fc-bigwig LOG2FC-BIGWIG-FILE
Traceback (most recent call last):
File ".../bin/epic2-bw", line 192, in
main(args)
File ".../lib/python3.7/site-packages/epic2/bigwig.py", line 113, in main
treatment_ranges = files_to_coverage(args["treatment"], args)
File ".../lib/python3.7/site-packages/epic2/bigwig.py", line 75, in files_to_coverage
ranges = file_to_ranges(f, args, "ChIP")
File ".../lib/python3.7/site-packages/epic2/bigwig.py", line 44, in file_to_binned_ranges
bin_counts, _ = files_to_bin_counts([f], args, datatype)
File "epic2/src/reads_to_bins.pyx", line 218, in epic2.src.reads_to_bins.files_to_bin_counts
File "epic2/src/reads_to_bins.pyx", line 250, in epic2.src.reads_to_bins.files_to_bin_counts
KeyError: 'required_flag'`
I noticed that:

the --required-flag flag doesn't exist in the epic2-bw usage:
usage: epic2-bw [-h] --treatment TREATMENT [TREATMENT ...]              [--control CONTROL [CONTROL ...]] [--raw] [--bigwig BIGWIG]              [--individual-log2fc-bigwigs INDIVIDUAL_LOG2FC_BIGWIGS]              [--chip-bigwig CHIP_BIGWIG] [--input-bigwig INPUT_BIGWIG]              [--log2fc-bigwig LOG2FC_BIGWIG] [--genome GENOME]              [--keep-duplicates] [--bin-size BIN_SIZE]              [--fragment-size FRAGMENT_SIZE] [--chromsizes CHROMSIZES]              [--guess-bampe] [--mapq MAPQ] [--example] [--version]

In ".../bin/epic2-bw" there is no "--required-flag" arg in the arg parser.

I'd be very grateful to hear from you on how to run the above command so that it passes this indexing:
cpp_tags = read_bampe(f, drop_duplicates, args["mapq"], args["required_flag"], args["filter_flag"])
Many thanks!

It seems to be missing from epic2-bw.
It is here: https://github.com/biocore-ntnu/epic2/blob/master/bin/epic2#L139
Would you be able to submit a PR?
On Mon, Jan 9, 2023 at 2:41 PM a-lahat @.***> wrote:

Hi, I'm trying to run the following epic2-bw command and am getting a
KeyError: 'required_flag'.
`epic2-bw --treatment TREATMENT --control CONTROL --genome GENOME
--bin-size 100 --guess-bampe --log2fc-bigwig LOG2FC-BIGWIG-FILE
Traceback (most recent call last):
File ".../bin/epic2-bw", line 192, in
main(args)
File ".../lib/python3.7/site-packages/epic2/bigwig.py", line 113, in main
treatment_ranges = files_to_coverage(args["treatment"], args)
File ".../lib/python3.7/site-packages/epic2/bigwig.py", line 75, in
files_to_coverage
ranges = file_to_ranges(f, args, "ChIP")
File ".../lib/python3.7/site-packages/epic2/bigwig.py", line 44, in
file_to_binned_ranges
bin_counts, _ = files_to_bin_counts([f], args, datatype)
File "epic2/src/reads_to_bins.pyx", line 218, in
epic2.src.reads_to_bins.files_to_bin_counts
File "epic2/src/reads_to_bins.pyx", line 250, in
epic2.src.reads_to_bins.files_to_bin_counts
KeyError: 'required_flag'`
I noticed that:

the --required-flag flag doesn't exist in the epic2-bw usage:
usage: epic2-bw [-h] --treatment TREATMENT [TREATMENT ...] [--control
CONTROL [CONTROL ...]] [--raw] [--bigwig BIGWIG]
[--individual-log2fc-bigwigs INDIVIDUAL_LOG2FC_BIGWIGS] [--chip-bigwig
CHIP_BIGWIG] [--input-bigwig INPUT_BIGWIG] [--log2fc-bigwig LOG2FC_BIGWIG]
[--genome GENOME] [--keep-duplicates] [--bin-size BIN_SIZE]
[--fragment-size FRAGMENT_SIZE] [--chromsizes CHROMSIZES] [--guess-bampe]
[--mapq MAPQ] [--example] [--version]
2.
In ".../bin/epic2-bw" there is no "--required-flag" arg in the arg
parser.
I'd be very grateful to hear from you on how to run the above command so
that it passes this indexing:
cpp_tags = read_bampe(f, drop_duplicates, args["mapq"],
args["required_flag"], args["filter_flag"])
Many thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/biocore-ntnu/epic2/issues/68, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHURUQZQMC6H45XFHJMX5LWRQIPXANCNFSM6AAAAAATVOHZY4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Happy to.
Im getting - remote: Permission to biocore-ntnu/epic2.git denied to a-lahat.
Could you help with the permission and I'll push the PR?
Thanks


Option for not consuming the same message more than once

Hello guys,
I work at a company (Top Free Games) and we are currently using sarama on one of our services. We are currently in process of migrating from Kafka 0.8.2 to Kafka 0.9.0, so we will be able to use the new Kafka-based offset tracking and consumer-group rebalancing.
We noticed that in a very particular case, when the service crashes, there's a possibility that we consume the same message more than once, since the message`s offset is committed periodically only. However, as we deal with end users, we can not afford to duplica messages as that would affect in a really bad way our user's experience.
We could store the offsets on another database, but that would add another layer and possibly another point of failure to watch for, so that doesn't seem like a good option for us.
We came up with another solution: Store a batch of messages (e.g: 10k messages) at once, commit them right away and only then start using it as we have confirmation that they were committed. This sounds like a perfect solution for us, but we noticed that you don't export the method 'commitOffsets' that is responsible for committing the messages.
So my question is, would exporting this method be a solution or adding the whole functionality (consuming a batch of messages) would be more reasonable?

Another solution would be to create a separate channel (e.g: safeMessages) so we can mark all the incoming messages as processed and then transfer all of them that were already committed to the separate channel.
A possible solution would be: https://github.com/MateusDantas/sarama-cluster/commit/13158289da96e48ae00e981baa8c4d3d19efa084 (Still untested)
What do you guys think?
What do you guys think?

Hey,

We noticed that in a very particular case, when the service crashes, there's a possibility that we consume the same message more than once, since the message`s offset is committed periodically only

I am not sure how committing the offsets manually would solve the problem. What you consume your messages and your server crashes before you can issue e.g. a CommitOffsets() call?
I also don't see how a separate e.g. Committed channel would help in that situation. The only thing you realistically can do is ensure that services don't just 'crash', but are terminated gracefully. The consumer will always issue a final commit on Close().

We actually make a lot of effort into making sure our service will never crash, but sometimes unexpected things may happen (such as machines crashing by themselves), and we will not be able to terminate gracefully in such cases. I know it's a super rare condition and that it may never happen, but we can not afford to take those risks and duplicate messages for the end user as that would affect us in a really bad way.
Our first solution would be to first commit the offsets, and only then consume them. That would make sure that we never duplicate messages for the end user. A separated "Committed" channel would also help, because we would only consume committed messages. We know in that case there would be a chance that some messages get lost in case the system crashes, but that's acceptable for our case and duplicating messages is not acceptable in any way.
Hope we can find a common solution, as we really don't want to maintain another fork repo.

Two solutions I propose:

Separated "Committed" channel with only messages that were already committed: https://github.com/MateusDantas/sarama-cluster/commit/13158289da96e48ae00e981baa8c4d3d19efa084
BatchOfMessages module that return a number X of messages after committing them: https://github.com/MateusDantas/sarama-cluster/commit/1531358a3c1b10c2d624881928e25e700ca24ab3

Actually a very simple solution would be to just export https://github.com/bsm/sarama-cluster/blob/master/consumer.go#L556 to enable us to commit offsets manually. I believe I'm not the only one that would like this feature to be present, as sarama already enables manual offset committing.

Yep, was thinking among the same lines. So what you effectively want is to
turn Kafka's 'at least once' guarantee into 'at most once'.
Exporting commitOffsets is a little tricky but doable. It would allow you
to pull a batch of messages, then mark them as processed and finally commit
the offsets manually, before actually processing the messages.
Before I go ahead with this, a little word of warning. The approach above
will fix your immediate consumer problem, but it does not change Kafka's
core principles. If uniqueness of your messages is critical to your use
case, I would not rely on offsets. Messages are duplicated by Kafka and by
producers at a sufficiently regular basis. To assert uniqueness, you must
additionally employ one of the usual stream deduplication techniques.

Yes, that's exactly what we want. We know that a message can be duplicated by producers at a regular basis, but we already have some checks in progress to prevent that on the producer. So based on the assumption that our producer will never produce the same message twice, we just need to guarantee that we will never consume the same message more than once. That's why exporting commitOffsets would be a great help for us, as that would allow me to do exactly what you described, thus guarantee uniqueness of our messages.

Added in b3b9ad2a10642db7afbfb8d5b5fb2fc9345dfe8e


proofread readme documentation and correct english terms

校正英语语法，因为我对这个 Project 不是很了解，可能有的地方会有出入，但希望能够有帮助。请到［这里］（https://github.com/mattma/egg-loader）看看 rendered markdown file.

This change is

@fengmk2 我刚开始看 egg project, it is pretty cool. I am going to review more readme docs in the following weeks. For this repo, I feel like it is a loader like Webpack, it can load up different environment configurations in the runtime. am i right?

Good, welcome to help us to translate.

Commit message should follow https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md#commit-提交规范

Current coverage is 99.79% (diff: 100%)

No coverage report found for master at 8a36509.

Powered by Codecov. Last update 8a36509...4c06d59

@popomore 我们以前在 Slack 上聊过，想想都是一年多前的事了。
我已经更改了 serverEnv 翻译，加上了 doc: prefix before commit message, then squashed commits.
I wish that I can contribute to the project in the future once I understand the purpose, use case of egg. By reading the docs, I feel like it is a server side framework like Express, Koa, but take some best practices from front end like webpack, cli tooling, etc, bring some goodness to Node.js development.

egg is a web framework base on koa, just like connect vs express

@atian25 That is awesome. I do think Server side framework need a facelift at some point. I am glad that you guys pioneer and lead us to the future!
Have you ever considered to use typescript instead of vanilla js? Typescript becomes so popular recently here in US.

@mattma 我们在应用有使用 ts，但框架使用可能还不是时候（也还没有使用 koa2），我们会考虑定义 tsd。

The main benefit of taking advantage of TS is to ease the development pain. Ex: GoLang is a compiled language. All source code will be compiled through compiler so that you know your code won't run in your development time before it ships to production. TS is trying to guard the best practice for loose typed JS language and brings in the smart text editor feature to benefit developer while you writes your code in confidence.
I have tried with TS with KOA2, and it works pretty good so far. The rising of Angular2, which built on top of TS, is leading the JS revolution wave. More and more developers have seen, used, enjoyed TS in their daily dev workflow.
BTW, how is my PR? ready to merge? @popomore

@popomore For TS, typescript 2.0 is going to be released very soon. and They have updated their typings strategy. Read here  Include a .d.ts is pretty easy.
tsd and typings, that you mentioned above, are old good days. tsd project has been deprecated for 6 months already. When you use typescript with declaration: true flag should auto generate .d.ts files.
Then you install the module through NPM, then definition file should be picked up by typescipt automatically

It seems litter misunderstanding. I mentioned the word tsd that's mean I will define a d.ts file for egg.
I have used Typescript 2.0 in my work, and will use npm instead of the old typing modules, npm is awesome.

Cool. Good to know.
Microsoft only drives the development effort of typescript. @type is run and maintained by community, majority of type definition should be merged over from DefinitedTypes project.
BTW, if I understand correctly, egg project is an open sourced project by Ali, right? or a fun project by the top 10 JS developers in China, Gang of four? @popomore

an opensource project of ali, it is used at almost all the node project of ali.

has egg been stress test in production environment? Is egg ready to be built on large production Node.js server and runs on many machines?

@mattma Invite sent!
Welcome on board!

has egg been stress test in production environment? Is egg ready to be built on large production Node.js server and runs on many machines?

@mattma We will share the detail datas on ningjs.

英文不太会写，不过 @mattma 可以双语交流，我就说中文。

我们在2013年就开始使用 egg 的前身，在2014年D2上分享过 chair http://yq.aliyun.com/articles/2921 ，然后 2015年我们成立了 ali node team 虚拟小组，一起共建内部版本的 egg。
核心：egg-core （现在叫 egg-loader，很快就会改名 https://github.com/eggjs/egg-loader/pull/6） 是一个框架的框架，它可以让有能力的开发者基于 egg-core 搭建符合自己团队需求的 web 框架。
也就是这个 repo 是整个 eggjs 最核心的部分。

关于 ts，我们未来肯定会支持，但现在还是先采取保守模式，正如我们现在只是基于 koa1 来做。因为我们不想任何 build 过程，我们希望还是 node server.js 这样就能启动一个服务。
@mattma 如果你所在的团队或者公司，也希望做属于自己的符合自己业务需求的框架，基于 egg 也是很快能够封装起来。
关于性能和是否已经在生产环境使用。我在2011年加入阿里，就一直在做 node web 相关应用产品和技术，阿里应该是业界最早的一批使用 node 来做线上大流量应用的公司，只是因为相对于阿里的主流 Java 技术，node 的流量实在太小，就没怎么过多宣传。egg 这套技术从2013年起到现在有2年多的线上稳定运行经历，所以生产环境用是可靠的。性能数据我们在开源之前也会通过购买一台阿里云的 ECS 标准服务器来做 benchmarks，所以到时候能够看到真实一点的数据。

This is awesome! First of all, I am totally on board with this idea and I think that I could contribute to the project with my extensive deep knowledge on Node.js and JavaScript.
I speak fluent chinese, A.K.A, Beijingish. But i am sucks on typing Chinese with PinYin. I do prefer to write in English, just for the sake of saving times.
I will go through each repos soon, and share my thoughts in the following days. @fengmk2 It is honor to be part of ali open source project and work with such a strong Node.js team on earth. Thanks for the opportunity and cannot wait to see each other in person near future!


As a user I should see a UI Design of 404 Page

Expected output:
404 Page should have a design (UI)


Problem to compile on windows WSL

I tried to compile the wallet under the windows subsystem for linux.
I used this: https://github.com/gridcoin/Gridcoin-Research/blob/master/doc/build-msw.txt instruction to do it.
But I get this error:
In file included from db.cpp:6:0:
db.h:14:20: fatal error: db_cxx.h: File or directory not found.
compilation terminated.
makefile.unix:176: rule for „obj/db.o“ failed
make: *** [obj/db.o] error 1

Can somebody help me how to compile gridcoin under windows?
Thank you.

I'm not sure if those instructions are correct. I'd probably do make install on each package or the Gridcoin makefile won't see the headers and libraries.

Thanks for your comment. I used make install on all packages.

did you mkdir obj?
On Jun 13, 2017 12:22 AM, "Pythonix"<EMAIL_ADDRESS>wrote:

Thanks for your comment. I used make install on all packages.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gridcoin/Gridcoin-Research/issues/363#issuecomment-308030049,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMrVQOCNb9SJTi2WOU8qYu3fczc_ACNXks5sDjingaJpZM4N1Xry
.

Yes I did...Can I crosscompile the wallet on linux to make changes on the windows client?
I really don't know how to compile it on windows..

i never compiled on windows personally onyl installed the msi but not i only have linux in this house. sory

This issue will be taken care of in #487.


Can't build

So far I am receiving errors building in MS Azure, while doing yarn install && yarn build
I will try on Ubuntu 16.04
me ~/libraries/coins (master)
$ git clone https://github.com/dternyak/monerochain.git
Cloning into 'monerochain'...
remote: Counting objects: 227, done.
remote: Total 227 (delta 0), reused 0 (delta 0), pack-reused 227
Receiving objects: 100% (227/227), 37.71 KiB | 772.00 KiB/s, done.
Resolving deltas: 100% (89/89), done.

me ~/libraries/coins (master)
$ cd monerochain/

me ~/libraries/coins/monerochain (master)
$ ls
app.yaml  common/  jest_config/  LICENSE  package.json  README.md  static/  webpack_config/

me ~/libraries/coins/monerochain (master)
$ yarn install && yarn build
yarn install v1.3.2
info No lockfile found.
[1/4] Resolving packages...
warning<EMAIL_ADDRESS>🙌  Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "webpack ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
success Saved lockfile.
Done in 166.23s.
yarn run v1.3.2
$ webpack --config webpack_config/webpack.prod.js
Hash: d5e0f475834e4183448f
Version: webpack 2.3.3
Time: 140458ms
                  Asset       Size  Chunks                    Chunk Names
     client.ae81d7b2.js    1.01 MB       0  [emitted]  [big]  client
     vendor.bc3f8d63.js     194 kB       1  [emitted]         vendor
    client.ae81d7b2.css     149 kB       0  [emitted]         client
 client.ae81d7b2.js.map    1.04 MB       0  [emitted]         client
client.ae81d7b2.css.map   88 bytes       0  [emitted]         client
 vendor.bc3f8d63.js.map     199 kB       1  [emitted]         vendor
             index.html  598 bytes          [emitted]
              readme.md   19 bytes          [emitted]
   [0] ./~/react/react.js 56 bytes {1} [built]
  [14] ./~/react-dom/index.js 59 bytes {1} [built]
  [58] ./~/react-router-redux/lib/index.js 1.97 kB {1} [built]
  [81] ./~/redux-thunk/lib/index.js 529 bytes {1} [built]
 [249] ./common/reducers/index.js 338 bytes {0} [built]
 [250] ./common/routing/index.jsx 2.72 kB {0} [built]
 [251] ./~/bulma/css/bulma.css 41 bytes {0} [built]
 [252] ./~/react-activity-indicator/src/activityindicator.css 41 bytes {0} [built]
 [253] ./~/react-addons-perf/index.js 52 bytes {0} [built]
 [254] ./~/redux-devtools-extension/index.js 635 bytes {0} [built]
 [255] ./~/redux-logger/dist/redux-logger.js 10.5 kB {0} [built]
 [256] ./~/grommet/scss/vanilla/index.scss 1.33 kB {0} [built]
 [257] ./~/whatwg-fetch/fetch.js 12.7 kB {1} [built]
 [289] ./common/index.jsx 3.13 kB {0} [built]
 [661] multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch 100 bytes {1} [built]
    + 647 hidden modules

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (250 kB).
This can impact web performance.
Assets:
  client.ae81d7b2.js (1.01 MB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (250 kB). This can impact web performance.
Entrypoints:
  client (1.35 MB)
      vendor.bc3f8d63.js
      client.ae81d7b2.js
      client.ae81d7b2.css

WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

ERROR in ./~/react-router/es/match.js
Module not found: Error: Can't resolve 'history/lib/Actions' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/match.js 5:0-46
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch

ERROR in ./~/react-router/es/browserHistory.js
Module not found: Error: Can't resolve 'history/lib/createBrowserHistory' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/browserHistory.js 1:0-68
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch

ERROR in ./~/react-router/es/useRouterHistory.js
Module not found: Error: Can't resolve 'history/lib/useBasename' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/useRouterHistory.js 2:0-50
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch

ERROR in ./~/react-router/es/createMemoryHistory.js
Module not found: Error: Can't resolve 'history/lib/useBasename' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/createMemoryHistory.js 2:0-50
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch

ERROR in ./~/react-router/es/createMemoryHistory.js
Module not found: Error: Can't resolve 'history/lib/createMemoryHistory' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/createMemoryHistory.js 3:0-70
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch

ERROR in ./~/react-router/es/hashHistory.js
Module not found: Error: Can't resolve 'history/lib/createHashHistory' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/hashHistory.js 1:0-62
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch

ERROR in ./~/react-router/es/useRouterHistory.js
Module not found: Error: Can't resolve 'history/lib/useQueries' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/useRouterHistory.js 1:0-48
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch

ERROR in ./~/react-router/es/createMemoryHistory.js
Module not found: Error: Can't resolve 'history/lib/useQueries' in 'C:\Users\world\libraries\classrepo\coins\monerochain\node_modules\react-router\es'
 @ ./~/react-router/es/createMemoryHistory.js 1:0-48
 @ ./~/react-router/es/index.js
 @ multi react react-dom react-router redux react-router-redux redux-thunk whatwg-fetch
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

me ~/libraries/coins/monerochain (master)
$

Any updates on build instructions?

Any updates on build instructions?

Sorry, I haven't had any time. I have a half-baked re-implementation, but I
won't have any time to work on it for at least a few weeks. I'll be sure to
ping you when it's ready
On Thu, Mar 1, 2018 at 9:54 PM, Mark Allen Evans<EMAIL_ADDRESS>wrote:

Any updates on build instructions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dternyak/monerochain/issues/4#issuecomment-369812704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf02blenEbcPGtcxW9m1yk4g8I0kt64ks5taMJ0gaJpZM4RdJCT
.

@shopglobal Checkout https://github.com/MyCryptoHQ/MoneroVision - it's the spiritual successor. Hope you like it!


20-incident-factory

Status
READY
Testing
[X] I have added passing tests for all new functionality.
[X] I have confirmed that all test prior to this pull request still PASS.
Documentation
[X] I have fully documented features in this PR's code. Please put an X in the box to confirm.
[ ] This PR does NOT require documentation.
Description
Create an IncidentFactory with methods to retrieve a single Incident or a list of all Incidents.
Resolves Issue Number
Resolves #16
Deploy Notes
git pull --prune
git checkout 20-incident-factory
dotnet test

Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.

Make sure the program builds and all tests pass on your machine

Impacted Files in Application
List general components of the application that this PR will affect:

Factories/IncidentFactory.cs
IncidentFactoryTests.cs

🎺 🎺 🎺 LGTM

LGTM :horn:


Fixed-point math

The library currently uses lots of floating-point math which leads to rounding errors, which is unacceptable for financial applications.
Here is some suggestions:

Amount class should present asset amount as Decimal
Price class should use Fraction for self["price"]
Internal conversions in Price class (.invert() should not use floating-point math
More general, all API objects exposed to library users should present prices as Fraction, and all amounts in Decimal
Market.buy() and Market.sell() methods should be refactored to use Decimal for amounts and Fraction for price
Add additional method to Market class to place an order with any amount of BASE and QUOTE, like place_raw_order(amount_to_sell: Amount, min_to_receive: Amount)

Actually, there are no rounding errors that could be prevented by using Decimal(). At least in a sense that Decimal would have the same rounding errors.
But I agree, that it would all look much better if it used Decimal.

Well, there was at least one error caused by FP math, which I tracked down and fixed: #171
Also here is the simple use-case which screws usage of PF math in calculation with amounts:
from bitshares.amount import Amount

# calculate an order amount 2% bigger
amount = Amount('0.325 RUDEX.GOLOS')
m = 1.02
num1 = amount * m
print(num1)

# simulate real order from blockchain which is 2% bigger
num2 = 0.325 * m
num2 = round(num2, 3)
print(num2)
# actually it's a float inside:
print(float(num1))

# oops
print(num1 == num2)

0.332 RUDEX.GOLOS
0.3315
0.332
False

See? To get reliable results, a library user must round() all his calculations to make sure the results are matched with blockchain precision. Because of this, we're in dexbot doing various checks and hacks, and I'm not sure there are no errors (lol).

Oh well, that is a bug/feature.
The Amount class comes with its own way of dealing with multiplications.
Given that I (as developer) cannot know what the user wants to do with the Amount after multiplying a float with it, I decided to not strip it.
Thinking about it right now, it might have been a wrong decision that can be fixed easily.

Prices as Fraction class aren't optimal as it automatically converts (like from 5/10 to 1/2). If you think of the numerator and denominator as base amount and quote amount, then it won't work.

In dexbot we're incrementing prices to place staggered orders, this is a test which shows actual order price and initially calculated price are different:
        closer_order = worker.place_closer_order(asset, order, place_order=True)

        # Test for correct price
>       assert closer_order['price'] == order['price'] * (1 + worker.increment)
E       assert 99.01980296969697 == 99.0099009894
E         -99.01980296969697
E         +99.0099009894

So, we should switch from incrementing prices to incrementing amount only (base or quote) to place staggered orders.

Even better if we can do all calculations in internal amounts (integers), and place orders using them.

@bitfag I'm working on a method and a few helper methods to cater for our needs. I'll share them once I get them somewhat done.  It is greatly expanded from this one


App Logo Discussion Issue

This issue serves as a discussion thread for the app logo. While discussing the app in our chat, it was brought up that the logo looks a bit squished.
One idea was to add some additional negative space around the logo, but I would love to hear what you all think as well.
How the app appears in my play store

Forum PWA on left, our mobile app on right

There is a fixed size for the app icons in different platforms right. So I think it would be better if padding was done and from that base icon we made the icons for other platforms.

So the puck social ones have extra padding for situations like this: https://github.com/freeCodeCamp/design-style-guide/tree/master/assets


Need to add a dependency for the typhoeus Gem to the .gemspec

Error when first running:
$ pry
[1] pry(main)> require 'pokegem'
LoadError: cannot load such file -- typhoeus
from /home/pj/.rbenv/versions/2.1.2/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'

I'll fix that one when I get home tonight and push it.

Scratch that, easy fix. v0.0.3 compensates for this and JSON missing: https://github.com/baweaver/pokegem/commit/faf360cddf99b91f22639d7f251de90e22a23a5c

Awesome thanks!
On Tue, Feb 24, 2015 at 4:56 PM, Brandon Weaver<EMAIL_ADDRESS>wrote:

Scratch that, easy fix. v0.0.3 compensates for this and JSON missing:
faf360c
https://github.com/baweaver/pokegem/commit/faf360cddf99b91f22639d7f251de90e22a23a5c
—
Reply to this email directly or view it on GitHub
https://github.com/baweaver/pokegem/issues/2#issuecomment-75855131.

--
Philip Hughes
H4W5


fix continuous install of same package version

subscriptions to dnf_package resources are triggered each time the resource converges with an install action
Description

Related Issue

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[X] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

@jalberti We did a large amount of refactoring in dnf_package on master recently. This will be shipping in Chef Infra Client 16. Can you possibly test out your issue against a current build (https://downloads.chef.io/chef/current) and let us know if this is still an issue.

Yeah this is also the wrong fix, it blows up CI.  Messing around with the package superclass is very hard to do correctly because of all the use cases, and there should be no reason to fix this problem there.  I'm pretty sure that I fixed this in Chef 16 and it boiled down to issues with EVRA-vs-EVR comparisons never succeeding and the workaround (if I recall correctly, is that including the full EVRA in the package resource works around it), but I can't tell if you don't include any linked issue or any reproduction steps.

Before making these changes I tried to back port all the changes from Chef 16/master, but those changes did not fix my issue, they break backward compatibility with existing attribute values.
All out pipelines are written against centos 6, i.e. they are using the yum_package, now we are porting to centos 8 ... the example where we saw this looks as follows ...
yum info ....
Available Packages
Name         : broken-package
Epoch        : 1
Version      : 0.1
Release      : 123
Architecture : x86_64
Now I define a resource ...
e.g.
new_version: 0.1-123
current_version: 1:0.1-123.x86_64
candidate_version: 1:0.1-123.x86_64
package will be always "re-installed" ... it does not really re-install, yum catches the issue and it results in a no-op from the host point of view, but the subscriptions all fire

those changes did not fix my issue, they break backward compatibility with existing attribute values.

That is a more interesting question to solve.  We are going to backport the Chef-16 behavior to Chef-15 so if we have breaking issues we need to know about it.

If this is the problem where you have to include a full EVRA in the version that's deliberate.
version 1.2.3-1 will only match 0:1.2.3-1 now and you must write version 1:1.2.3-1 if that is your package's epoch.
That may block the backporting of any fixes to Chef-15, it'll become a tradeoff between forcing that breaking change in Chef-15 and fixing this bug.

If this is the problem where you have to include a full EVRA in the version that's deliberate.
version 1.2.3-1 will only match 0:1.2.3-1 now and you must write version 1:1.2.3-1 if that is your package's epoch.
That may block the backporting of any fixes to Chef-15, it'll become a tradeoff between forcing that breaking change in Chef-15 and fixing this bug.

Yes, that is exactly the issue. I think you are taking the breaking change too lightly, and I'm also not sure why you are thinking my change is not safe for this case. Basically my change says ... the version that would have been installed is already installed ... so this from my point of view is exactly what you want here, but I'm certainly not the expert, as you rightfully said, one would expect that such a fundamental issue should sit deeper in the stack, i.e. dnf specific provider, but I was not able to figure out how to fix this lower in the stack, in the time I was willing to spend on this ...

That breaking change is correct behavior.  The prior behavior of chef-client was to treat 1.2.3 like it matches 0:1.2.3, 1:1.2,3, 2:1.2.3, etc.  Which is not correct per the spec of RPMs or how rpm/yum/dnf treat version strings.  Per the spec and the behavior of the underlying tools 1.2.3 is only equivalent to 0:1.2.3 and is never equivalent to 1:1.2.3.  That was deliberately removed.  Chef now uses the underlying python libraries to do version comparisons and those return that 1.2.3 != 1:1.2.3 correctly.  That behavior will not be changed or reverted.  You must update your existing code to work around that.  That decision was very much not taken lightly and was due to years of issue involved with maintaining our own custom ruby implementation of RPM version parsing and comparison which was buggy and deliberately violated the RPM spec.  We did that in a major breaking change release with the yum_package provider that shipped in Chef 14 and the behavior of the dnf_package provider in Chef 16 now will match that behavior.  We aren't going to re-litigate that decision at this time.
The patch that you submitted can't be accepted because it breaks behavior:
Failures:

  1) Chef::Provider::Package - Multi when installing multiple packages installs the specified version when some are out of date
     Failure/Error: expect(new_resource).to be_updated
       expected `<package[emacs, vi] @package_name: ["emacs", "vi"] @name: "emacs, vi" @before: nil @params: {} @provider: nil @allowed_actions: [:nothing, :install, :upgrade, :remove, :purge, :reconfig, :lock, :unlock] @action: [:install] @updated: false @updated_by_last_action: false @source_line: nil @guard_interpreter: nil @default_guard_interpreter: :default @elapsed_time: 0 @version: ["1.0", "6.3"]>.updated?` to return true, got false
     # ./spec/unit/provider/package_spec.rb:523:in `block (3 levels) in <top (required)>'

It has also broken functional specs which run on opensuse:
Failures:

  1) Chef::Resource::ZypperPackage with versions downgrades when the installed version is higher than the package_name version
     Failure/Error: expect(zypper_package.updated_by_last_action?).to be true

       expected true
            got false
     # ./spec/functional/resource/zypper_package_spec.rb:129:in `block (3 levels) in <top (required)>'

That is why there's a red x next to the PR on buildkite (the kitchen test failures are some other issues that would go away if the branch was rebased against master and force-pushed).
There's lot of complicated edge conditions to the package providers and it is nearly impossible at this point to find a quick fix to something in the superclass without causing more problems than you solve.

I'm totally fine with that decision, it is your product, therefore your decision. Thanks for looking at and discussing this PR here. Feel free to close this PR. Best regards, Johannes


Fix PRs being skipped when Github returns a 401/404 for a missing admin

This PR fixes the problem of missing PR builds, for repos where the admin is not found.
Travis will check for the first 15 users with github tokens and admin rights on the repo. The user permissions' data could be outdated since user permissions are synced with github, only once a day.
So, the candidate is checked for admin rights again.
The number of candidates is set to be large to reduce the probability of missing a build when the first few candidates aren't valid admins.
An invalid admin's admin permission is revoked, on our side too.
If no admin is found, which could be the case, when a user's admin rights have been revoked recently or their account has been deleted, Travis::AdminMissing error is raised. This error is picked up to re-try the build later.

Has this been tested?

@BanzaiMan regression tested in staging and unit tested.


False positives - strings containing only digits

var isUpperCase = require("is-upper-case")
console.log(isUpperCase('1'))
// => "true"

see it on RunKit: https://runkit.com/embed/pzxpzsvvl2l3
Should we additionally compare is the particular string's toUppercase() not equal toLowerCase()? That way we would filter-out the letters..

Looks like a good catch to me. We can add a third argument for backward compatibility making it "strict" and use that to do something like toLowerCase(str) !== str && toUpperCase(str) === str. Is that what you were thinking also?

Yeah, I think that's good idea.


PowerShell Gallery

Any chance to add support for PowerShell Gallery?  It's nuget based like many other services here.

Would you like to try submitting a pull request to add it? If it's NuGet-based, it should be very easy to add (see mapNugetFeed and mapNugetFeedV2 in server.js)

@Daniel15, great suggestion, thanks -- I've submitted a PR.

@ebekker @Daniel15 Hey Eugene and Daniel, I saw that this functionality was added in commit https://github.com/badges/shields/commit/ce0eb7b3369b81205e56beac9461dcfd25d72deb , but it does not appear that the functionality is working (the examples added to try.html in the commit are both broken, as seen here and here). Any clue why this would be the case? I would love to add this to the Azure PowerShell repository 😃
Thanks in advance!

It's likely the site hasn't been redeployed yet. @espadrine manages all that stuff, so I'll let him chime in here 😃

@Daniel15 @espadrine perfect, thanks for the update!

Is there a way to see what version of the code base is deployed to the public site?  I was trying to find a way to match against a tag or something in GitHub but it doesn't look to be there?
Or alternatively, is there any indication in the GitHub repo when a release is deployed, like a tag, a PR or an issue?  Or maybe a tweet or announcement some other way?  I couldn't find any convention.

Not sure, sorry 😢 . I haven't really handled that side of things. I'll try pinging @espadrine again as I haven't heard back.

This has been deployed now.
For future reference, to see the version that's currently deployed, you can look at the gh-pages branch. The deploy process updates the servers and force-pushes a deploy commit to that branch. Github Pages hosts https://shields.io/index.html. @ebekker @Daniel15

@paulmelnikow thank you!

@paulmelnikow thanks Paul!

@jzabroski Hey John, here's an example of how we use it in the Azure PowerShell repository:
[![AzureRM](https://img.shields.io/powershellgallery/v/AzureRM.svg?style=flat-square&label=AzureRM)](https://www.powershellgallery.com/packages/AzureRM/)

Note: the PowerShell Gallery badges are currently broken -- see this issue

Ah, the #2078 is why I was having troubles. Thanks!


UHF-10539: Unpublishable redirects

UHF-10539

What was done
The City wants to deactivate automatically made redirects after 6 months. This change alters redirect entity type from  redirect module so that the entity implements EntityPublishedInterface and has field is_custom.
The redirect entities added or updated by any user from the entity from are automatically permanently marked as custom, while redirects created automatically are marked not custom. A cron job queries for non-custom redirect entities that are more that 6 months old, and unpublishes them.
How to install

make fresh
composer require drupal/helfi_platform_config:dev-UHF-10539
drush updb -y
drush cr

How to test

[ ] Edit the title of any node so that the path alias should change. An automatic redirect from the old path alias to the new should be created. Check that the automatically created Redirect is not marked as custom: https://helfi-etusivu.docker.so/fi/admin/config/search/redirect?is_custom=0&status=1
[ ] Manually create redirect entity for any URL: https://helfi-etusivu.docker.so/fi/admin/config/search/redirect/add. Check that the Redirect is marked as custom: https://helfi-etusivu.docker.so/fi/admin/config/search/redirect?is_custom=1&status=1
[ ] Mark all redirect entities as NOT custom: drush sqlq "UPDATE redirect SET is_custom = 0"; drush cr

[ ] Check that the RedirectCleaner service unpublishes redirects that are older that 6 months: drush php:eval "\Drupal::service(\Drupal\helfi_platform_config\RedirectCleaner::class)->unpublishExpiredRedirects()"
[ ] Check that unpublished redirects do not work (should return 404).
[ ] Go to the redirect edit form and manually publish it, the redirect should now be marked custom and is not removed if RedirectCleaner::unpublishExpiredRedirects() is re-run.

[ ] Check that code follows our standards

Continuous documentation

[ ] This feature has been documented/the documentation has been updated
[ ] This change doesn't require updates to the documentation

Translations

[ ] Translations have been added to .po -files and included in this PR

Other PRs

Link to other PR

Codecov Report
Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 17.89%. Comparing base (6c57a10) to head (950b694).
Report is 67 commits behind head on main.

Files with missing lines
Patch %
Lines

src/RedirectCleaner.php
89.65%
3 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #862      +/-   ##
============================================
+ Coverage     14.49%   17.89%   +3.40%
- Complexity      271      285      +14
============================================
  Files            33       36       +3
  Lines          1035     1084      +49
============================================
+ Hits            150      194      +44
- Misses          885      890       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[VS Code] Unskip flaky tests in feature branch

In order to unblock CI and get the VS Code bits inserted, I skipped some known flaky integration tests (unrelated to VS Code work). We should unskip these when we merge the feature branch to main:
Diagnostics_ShowErrors_CSharpAndHtml
FindAllReferences_ComponentAttribute_FromCSharpInCSharp

This has been resolved (FindAllReferences_ComponentAttribute_FromCSharpInCSharp unskipped, Diagnostics_ShowErrors_CSharpAndHtml superseded by #8150).


Cannot trigger build when there are no changes

Describe the bug
My latest build failed and required a change to the app build specification file to fix.  I edited the configuration file in the console UI and saved it, then used the webhook to trigger a new build.  The build was cancelled because there was no diff detected from previous build.
To Reproduce
Steps to reproduce the behavior:

Trigger an automated build by pushing a change to git
Attempt to trigger a rebuild by running a webhook curl command
The build is cancelled because there is no diff

Expected behavior
Triggering a webhook build should not be cancelled due to no diff if the previous run failed.  Alternately, provide a flag in the webhook to force a rebuild.

Hi @pagameba can you try using the "Redeploy this Version" button

Hi @pagameba can you try using the "Redeploy this Version" button

I don't seem to have that option in the UI

I don't seem to have that option in the UI

@pagameba can you please share your appId

@pagameba can you please share your appId

I think this is the appId: dp57bbn61ewiy

I think this is the appId: dp57bbn61ewiy

I believe you need to click on the Build green tick - which opens up the build details.

I believe you need to click on the Build green tick - which opens up the build details.

That does not appear to do anything for me(in as much as it doesn't reveal the redeploy this version button) in either the cancelled build or previously successful builds, not does clicking on any of the other stages of the build.

That does not appear to do anything for me(in as much as it doesn't reveal the redeploy this version button) in either the cancelled build or previously successful builds, not does clicking on any of the other stages of the build.

Hi @pagameba I followed your repro steps but was not able to reproduce the issue for myself. What response do you get when you run the webhook curl command?

Hi @pagameba I followed your repro steps but was not able to reproduce the issue for myself. What response do you get when you run the webhook curl command?

{"SendMessageResponse":{"ResponseMetadata":{"RequestId":"11cad055-f77c-5992-b80f-88235254ffb0"},"SendMessageResult":{"MD5OfMessageAttributes":"0a31f1f13f31824a56483ae938b38fb6","MD5OfMessageBody":"99914b932bd37a50b983c5e7c90ae93b","MD5OfMessageSystemAttributes":null,"MessageId":"e755e72c-db90-4514-a41d-f81ca56383a6","SequenceNumber":null}}}%

{"SendMessageResponse":{"ResponseMetadata":{"RequestId":"11cad055-f77c-5992-b80f-88235254ffb0"},"SendMessageResult":{"MD5OfMessageAttributes":"0a31f1f13f31824a56483ae938b38fb6","MD5OfMessageBody":"99914b932bd37a50b983c5e7c90ae93b","MD5OfMessageSystemAttributes":null,"MessageId":"e755e72c-db90-4514-a41d-f81ca56383a6","SequenceNumber":null}}}%

@pagameba Where in the Console are you seeing the message that the build was cancelled due to no change being found? We will prioritize adding a way to force deployment on webhook trigger, but want to make sure we have the right scenario.

@pagameba Where in the Console are you seeing the message that the build was cancelled due to no change being found? We will prioritize adding a way to force deployment on webhook trigger, but want to make sure we have the right scenario.

you can see it here:

This screenshot also highlights another minor annoyance which I can file as a separate issue if its something new, the link to the Source repository changes constantly between the actual org/repo and undefined every few seconds while I am on this page.

you can see it here:

This screenshot also highlights another minor annoyance which I can file as a separate issue if its something new, the link to the Source repository changes constantly between the actual org/repo and undefined every few seconds while I am on this page.

Any update on this?  I am having the exact same issue.

Any update on this?  I am having the exact same issue.

I did discover that the "Redeploy this version" button does appear when using Previews, that's the only place I've seen it.  It also does not work (as reported in #1516)

I did discover that the "Redeploy this version" button does appear when using Previews, that's the only place I've seen it.  It also does not work (as reported in #1516)


Fix Providers doc refer to non-existent 'events.md'

Another commit to go with:

https://github.com/fluxcd/source-controller/pull/1200

There is no events.md - this is the result of anchor/404 testing being done on fluxcd/website#1573 and associated PRs
Please review and merge at will

Pinging @makkes

Sorry for the confusion. We had to change the docs structure in #582 so that all API type pages are pluralized. The import-flux2-assets.sh script  in the main branch of the website repo will fail with the new structure until fluxcd/website#1577 is merged from which point it will pass again. Since we're not building the docs from the n-c main branch but only from a released version the docs structure change onf #582 has no impact on the current docs site.
I think we can close this PR and wait until fluxcd/website#1577 has been merged. Then, the anchor check should not fail, anymore.

OK, 👍 closing


TypeError: Cannot read properties of undefined (reading 'split')

Hello,
I have tried to run test.js but it says:
TypeError: Cannot read properties of undefined (reading 'split')
Is the package currently working?
Thanks!

Hello! I believe this was due to an error where Google didn't return the lyrics, so there wasn't any html to parse. This has been fixed in https://github.com/Jeve-Stobs/lyrics-finder/commit/e71a30584a70e790aabf9b5c4bf6fbf7bfb85065


Issue when trying to adopt

Hey! Wanted to keep making use of the package, but getting this error when doing that:
Failed config

status_led: [source <unicode string>:50]

  Pin 5 is used in multiple places.
  pin:
    number: 5
    mode:
      output: True
      input: False
      open_drain: False
      pullup: False
      pulldown: False
    inverted: False
    ignore_strapping_warning: False
    drive_strength: 20.0
output.ledc: [source <unicode string>:76]

  Pin 5 is used in multiple places.
  platform: ledc
  pin:
    number: 5
    mode:
      output: True
      input: False
      open_drain: False
      pullup: False
      pulldown: False
    inverted: False
    ignore_strapping_warning: False
    drive_strength: 20.0
  id: output_led_red
  zero_means_zero: False
  frequency: 1000.0

This is fixed in #2


Fix markdown formatting in kubectl reference by escaping pipes.

Hi I just registered for linux foundation and linked my github account there. Unfortunately I'm not a regular OSS contributor so please excuse any general cluelessness.
Also ideally we should have a test that checks for any markdown syntax oopsies, but in the meantime I just needed the kubectl reference to actually be readable.

I signed the agreement. Got an email that says:
You just signed CNCF Individual Contributor License Agreement

/assign @bgrant0607

Fixed in: https://github.com/kubernetes/website/pull/8462


added training page

Added the necessities for a training page including pug file, navigation header, tests, and changes to member.js file.

Looks like there are some linting errors and the new test you added didn't pass. I'll let you look at it first, then I can look if you need help


[test/plugin] spring async scenario optimize

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

License header missing.


Unable to include own libraries

I'm using linux 64bit version (0.0.5 - alpha)
After successfully (?) adding a library from zip file, I'm unable to compile the program as I get :
[3/12/2016 12:14:02 AM] - Command failed: /tmp/build1457738042474/sketch_mar10b.cpp:4:21: fatal error: OneWire.h: No such file or directory #include ^ compilation terminated.

Also "clicking" the add button in import library sub menu doesn't add the include statement into sketch  for the once uploaded, only libraries already included with the studio works.

I'm seeing a similar issue to this as well.  Is this project still being worked on?


Stop approval states being overwritten

When computes nodes send their info updates, they were sending a version of the NodeInfo struct that contains an empty approval value.  We shouldn't accept them at all, and so this commit will overwrite whatever the client sends with the current approval state.
We should probably change what the compute node sends so that the NodeInfo on the requester node is an enhanced version of the info the compute node has.
Possible fix for: https://github.com/bacalhau-project/bacalhau/issues/3783

This is unnecessary given the existence of #3785 which is a better long-term fix.


Feature request: default cross-stream replies

I would like to be able to designate a pair of streams such that replies to topics in stream A should result in a new topic in stream B, quoting the original post. Any subsequent replies in A should be appended to the relevant topic in B instead.
The use case for this is having A being an announcement stream, and B a discussion stream related to the annoucements in A.
An alternative feature would show a notification to the user when trying to reply in stream A, asking them if they want their reply to appear in A or to start a new topic in B.

You can likely implement a version of this with a simple interactive bot that does the reposting: https://zulip.com/api/writing-bots.
The bot would just reply to the first message in any topic in stream A with a "Discuss this announcement here." notice linking to the discussion stream.


allow ability to inject bootstrap, lint functions directly etc

right now everything is still pretty centralized to fox-suite folder, making stuff less modular
todo a refactor that demodularizes and puts bootstrap templates, functions to call at bootstrap time, and linting functions in the actual folders they're supposed to be

work has started at ab14543130707b29b9fdf0ee3096a85f6cd105b3


Add BuiltInIterableIterator for built-in iterables with undefined return values

Fixes https://github.com/microsoft/TypeScript/issues/52998
Adds BuiltInIterableIterator, a stricter version of IterableIterator which is adhered to by all built-in iterables. This ensures correct types for next().value and for the return value of yield*:
declare const str: string
const iter = str[Symbol.iterator]()

// old type: any
// new type: string | undefined
const maybeChar = iter.next().value

function* generator() {
    // old type: any
    // new type: undefined
    const val = yield* [1, 2, 3]
}

// old type: Generator<number, any, undefined>
// new type: Generator<number, undefined, undefined>
function* generator2() {
    return yield* [1, 2, 3]
}

// old version: TS allows this
// new version: Property 'return' does not exist on type 'BuiltInIterableIterator<number>'.
iter.return?.()
// old version: TS allows this
// new version: Property 'throw' does not exist on type 'BuiltInIterableIterator<number>'.
iter.throw?.()

IterableIterator still remains, and should probably be preferred for usage as a parameter type to maintain backward compatibility and to allow lenience where the return value is discarded.
Currently out of scope for this PR: corresponding changes to DOM libs; any equivalent changes to async iterables.

Maybe the name IterableIteratorWithNoReturn is better? built-in does not definitely means it will return undefined, and user land iterators can also return undefined.

Maybe the name IterableIteratorWithNoReturn is better? built-in does not definitely means it will return undefined, and user land iterators can also return undefined.

Yeah, it'd be worth considering alternatives for the name. Some other possibles, per https://github.com/microsoft/TypeScript/issues/52998#issuecomment-1822085956:

GenericIterableIterator (not to be confused with TS generics) ... StrictIterableIterator, ImplicitReturnIterableIterator, StandardIterableIterator

Personally I prefer the nomenclature "implicit return" over "no return", because the latter could also refer to a non-terminating function/generator (function* noReturn() { while (true) yield 1; })
However, bikeshedding about names may be premature — per https://github.com/microsoft/TypeScript/issues/52998#issuecomment-1825100980, this will likely remain blocked pending https://github.com/microsoft/TypeScript/issues/36239, unless someone smarter than me can see a non-breaking way forward.

To preserve backwards compatibility, in #58243 we've opted to introduce a strict-mode flag to control the expected return type for a built-in iterator. We've also adopted BuiltinIterator as part of introducing types to support the iterator helpers proposal, per #58222.
There is a slight conflation of terms here, however. #58222 introduces BuiltinIterator as a place to hang the iterator helpers methods so as not to collide with TypeScript's Iterator, which merely describes the minimal interface for iteration. However, all generators are also derived from BuiltinIterator, so we cannot specify a default return type lest we conflict with existing generator functions. In #58243 we introduced the BuiltinIteratorReturn type alias, which is an intrinsic type whose actual type is either undefined or any depending on whether the --strictBuiltinIteratorReturn compiler option is set. Since this is a strict-mode flag, anyone with strict: true in their configurations will get this new behavior automatically, but can manually opt out by setting strictBuiltinIteratorReturn: false. Anyone not compiling under strict mode will retain the existing behavior where the return type is any.


'Path must be a string. Received undefined' after upgrading to 2.3.1

OS?
Ubuntu 16.04
Versions.
angular-cli: 1.0.0-beta.24
node: 6.9.2
npm: 3.10.9
Repro steps.
I tried to upgrade my project from 2.2.3 to 2.3.1 and angular-cli from beta.22-1 to beta.24, and started getting this error on build. I practically copy/pasted all dependencies generated by the ng new command.
This is my package.json:
{
  "dependencies": {
    "body-parser": "^1.15.2",
    "compression": "^1.6.2",
    "express": "^4.14.0",
    "helmet": "^3.1.0",
    "morgan": "^1.7.0"
  },
  "devDependencies": {
    "concurrently": "^3.1.0",
    "nodemon": "^1.11.0",
    "@angular/common": "^2.3.1",
    "@angular/compiler": "^2.3.1",
    "@angular/core": "^2.3.1",
    "@angular/forms": "^2.3.1",
    "@angular/http": "^2.3.1",
    "@angular/platform-browser": "^2.3.1",
    "@angular/platform-browser-dynamic": "^2.3.1",
    "@angular/router": "^3.3.1",
    "core-js": "^2.4.1",
    "rxjs": "^5.0.1",
    "ts-helpers": "^1.1.1",
    "zone.js": "^0.7.2",
    "@angular/compiler-cli": "^2.3.1",
    "@types/jasmine": "2.5.38",
    "@types/node": "^6.0.42",
    "angular-cli": "1.0.0-beta.24",
    "codelyzer": "~2.0.0-beta.1",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "2.5.0",
    "karma": "1.2.0",
    "karma-chrome-launcher": "^2.0.0",
    "karma-cli": "^1.0.1",
    "karma-jasmine": "^1.0.2",
    "karma-remap-istanbul": "^0.2.1",
    "protractor": "~4.0.13",
    "ts-node": "1.2.1",
    "tslint": "^4.0.2",
    "typescript": "~2.0.3"
  }
}

And my angular-cli.json is:
{
  "project": {
    "version": "1.0.0-beta.22-1",
    "name": "my-project-name"
  },
  "apps": [
    {
      "root": "client",
      "outDir": "dist",
      "assets": [
        "assets"
      ],
      "index": "index.html",
      "main": "main.ts",
      "tsconfig": "tsconfig.json",
      "prefix": "my-project-name",
      "mobile": false,
      "styles": [
        "styles.less",
        "assets/icons/icons.css"
      ],
      "scripts": [],
      "environments": {
        "source": "environments/environment.ts",
        "dev": "environments/environment.ts",
        "prod": "environments/environment.prod.ts"
      }
    }
  ],
  "addons": [],
  "packages": [],
  "e2e": {
    "protractor": {
      "config": "./protractor.conf.js"
    }
  },
  "test": {
    "karma": {
      "config": "./karma.conf.js"
    }
  },
  "defaults": {
    "styleExt": "less",
    "prefixInterfaces": false,
    "inline": {
      "style": false,
      "template": false
    },
    "spec": {
      "class": false,
      "component": true,
      "directive": true,
      "module": false,
      "pipe": true,
      "service": true
    }
  }
}

The log given by the failure.
Path must be a string. Received undefined
TypeError: Path must be a string. Received undefined
at assertPath (path.js:7:11)
at Object.join (path.js:1211:7)
at Object.exports.getWebpackNonAotConfigPartial (/home/myuser/work/myproject/src/node_modules/angular-cli/models/webpack-build-typescript.js:24:26)
at new NgCliWebpackConfig (/home/myuser/work/myproject/src/node_modules/angular-cli/models/webpack-config.js:26:42)
at Class.run (/home/myuser/work/myproject/src/node_modules/angular-cli/tasks/build-webpack.js:18:22)
at Class.run (/home/myuser/work/myproject/src/node_modules/angular-cli/commands/build.js:60:26)
at Class. (/home/myuser/work/myproject/src/node_modules/angular-cli/ember-cli/lib/models/command.js:152:17)
at process._tickCallback (internal/process/next_tick.js:103:7)
Thanks! We'll be in touch soon.

You say you copied the bits from ng new, but that's not the right step! You need to perform ng init in the root of the project. The CLI will interactively ask about overwriting files. Enter d for Difference on any files you may want to keep changes you've made, then either enter n to decline the overwrite, and apply the changes yourself. Overwrite those which have no changes or don't need changes saved with y.

Yes, that did the trick. Thanks.


used EnsureProportionAtLeast

Reference to issue #25
Used EnsureProportionAtLeast instead of EnsureProportionMoreThan. it is because EnsureProportionMoreThan is satisfied if the number of approvals is strictly greater than a specified fraction. While EnsureProportionAtLeast is satisfied if the number of approvals is at least equal to a specified fraction. It would require at least the full (100%) of the council members to approve an action.

To understand clearly lets have a look at the code:

The only difference is the equal sign in the criteria.  So therefore if we set 50%.  EnsureProportionMoreThan has to be 51% to be true while EnsureProportionAtLeast would accept 50%.

@villenaj I agree with the change.  Let me first make an issue on this.


Larger font sizes cause layout issues for popup menu

Internal: b/140826056
Using standard material components, increasing the font size causes layout artifacts. See this example:
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        theme: ThemeData(primaryColor: Colors.blue),
        home: Scaffold(
          appBar: AppBar(
            title: Text('Menu Test'),
            actions: [
            PopupMenuButton<String>(
              itemBuilder: (context) {
                final result =List<PopupMenuEntry<String>>();
                for(int i = 0; i < 5; ++i) {
                  result.add(PopupMenuItem<String>(value: '$i', child: Text('Menu $i')));
                }
                return result;
              },
            )
            ]
          ),
        ));
  }
}

This yields to:

Similar bugs have been filed for specific components such as: https://github.com/flutter/flutter/issues/5939.
What is the recommended solution to this? Material guidelines state that the UI layout should scale nicely with font size: https://material.io/design/usability/accessibility.html#implementing-accessibility.

In the particular example above, I would expect:

The app bar to pad the tile.
The overflow menu to show menu items with padding.
The gray selection bar to cover the entire text and padding.

In general we do handle this, but some specific components fail to do it right. The most useful thing to do would be to file specific bugs on each case you find. (We added text zoom late in the game and have not done a perfect job of retrofitting it.)

cc @HansMuller

The test case, as is, running on Android 9 with the text scaling at its highest setting, appears to do the right thing. Test case source.

One can see the reported problem by setting the text style of the menu items to something big, if the item heights and the menu's padding are not specified. Both of these parameters have constant default values which are too small for jumbo menu items. Test case source.

One can accommodate jumbo menu item sizes by specifying the menu's padding and the popup menu items' heights. Test case source.

This shouldn't be necessary, i.e. we can compute reasonable values in this case.
I've opened a new issue for that limitation: https://github.com/flutter/flutter/issues/39508

Hans, could you please test this also on iOS? I filed the bug thinking this is a platform agnostic issue but as you said, it does not reproduce on Android. I still think it is odd because the tap target does not vertically center the text (you can see it in your sshot) but it is not nearly as bad as on iOS.

The menu problem does reproduce on Android, however it's possible to work around the issue by specifying popup menu button padding, and item heights (that's the second and third cases above). I will test https://github.com/flutter/flutter/issues/39508 on both platforms.
I haven't looked at the AppBar issue yet.

Internally tracked in b/140826056

Customer Money (g3) needs this fixed by mid-Q4.

The menu item issue has been fixed, see https://github.com/flutter/flutter/pull/40179. I updated b/140826056

So what is left?

@Hixie https://github.com/flutter/flutter/issues/36265#issuecomment-511858371 - also notes that the AppBar's title doesn't fit so (perhaps) we should automatically move it upwards. Still TBD.

Ok, I'll update the issue title then.

I've created a separate issue for the jumbo appbar title issue: https://github.com/flutter/flutter/issues/42932. I'll close both of them when https://github.com/flutter/flutter/pull/42936 lands.


Improve build log out but still allow full debug log

Issue #, if available:
Description of changes:
This builds on something weve in build-tooling to limit the output when building the minimal images, but still allow an override via the OUTPUT_DEBUG_LOG env var to see it all if you want.
This PR introduces build::common::echo_and_run along with start and end log message for key targets in Common.mk.  echo_and_run was added to a few key places in our common scripts and the set -x were removed.  The resulting output, imo, is easier to read and follow and should still provide key data points for when scripts fail. That said, I do expect to see failures in the future that we want to add more logging for. In those case, we can temporary set the OUTPUT_DEBUG_LOG env var to see the full debug log.
IMO, set -x is nice because it gives you all the output, but if you are not intimately familiar with and have a strong understanding of what these scripts are doing, its too overwhelming and introduces tons of red herrings.
Please review the output from some of the presubmit jobs to see what you think and lets discuss!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I really like this, and I like the idea of having the ability to set -x for debugging purposes; we can then add more logging as needed based on waht we find with the debugging enabled.

/test all

/approve


Speedometer does not touch left end when value is minimum. Similarly speedometer does not touch right end when value is maximum

The speedometer needle is based on the image and only transtions from 180deg to -180 deg. You can add custom style to the needle to be positioned lower to align with the speedometer section

Yeah i figured it out by changing the style of animated.view which wrapped the image component and putting it outside of the inclosing view.


Features req (activity & custom settings)

First this config is great congratz :)
Regarding unseen activity, it is working great if the tab has no pane. If the tab has panes, only the active pane raises activity icon. I think it would be great to have unseen activity also from non focused pane.
Regarding the custom settings:

maybe having the datetime format as custom setting would be a good idea (in appearance config file for eg)
more config dedicated to visual_bell (also in appearance config file)
size controls of fonts & panes are great, background should follow same logic I think with leader key
custom backdrops location

Hey @damajor,
Thanks for the great feedback.
So far, I've added the visual_bell option to config/appearance.lua, fixed the unseen_output issue, and added an option to the Backdrops util to set a custom directory for the images.
I think I'll keep the datetime format setting in the right-status event file as I want all the items in the config dir to be configuration options for WezTerm only.
Also, making the background controls into a key_table works to a degree, but isn't very fun to use.
The background control bindings are custom actions wrapped in an action_callback and for some reason, action_callbacks, seem to exit the key table as soon as they are completed rather than staying in the key_table.
This makes basic actions like cycling through the images a pain because you'll have to do the whole key sequence to activate the key_table every time.
So, for now, I'll keep the background controls as is.

Also, making the background controls into a key_table works to a degree, but isn't very fun to use.
The background control bindings are custom actions wrapped in an action_callback and for some reason, action_callbacks, seem to exit the key table as soon as they are completed rather than staying in the key_table.
This makes basic actions like cycling through the images a pain because you'll have to do the whole key sequence to activate the key_table every time.

I did it myself this way and I found the exact same behavior, a bit frustrated :)
And of course thanks for the updates.

No worries 😊

Hmm the unseen activity seems to be a step forward the perfect resolution :p
I noticed that when you are in a tab with multiple panes, the panes with activity that are NOT focused generate the activity icon. I would expect this behavior on NOT focused tabs, but not on the tab that is currently in use.
This is not a big deal btw :)

unseen_ouptut alert no longer shows for any of panes of the active tab

I think it can be a be more polished but it is working great now.
Well this is going complicated :D
2 Tabs
1rst tab shell only
2d tab with 3 panes (one active with top, the 2 others only shell)
Test 1:

2d tab, pane with top has focus
Wait top refresh and go to first tab
unseen icon should appear in few second (the time top refresh)
This is working fine.

Test 2:

2d tab, pane with top WITHOUT focus, so put focus on any other pane in the same tab
Wait top refresh and go to first tab
unseen icon appears instantly you leave the tab with panes
Behavior expected is to be notified only until when real activity occurs

Agreed :)

Just pushed a change that makes the date time format configurable in the event setup function.
https://github.com/KevinSilvester/wezterm-config/blob/6febb08f74a2d0a0975cd330787d0f1dab2b8fac/wezterm.lua#L8-L13


Add ingress for epinio registry

fixes #440

PR includes

Removal of ngnix is a side car to registry pod. After this PR, ngnix is removed and is replaced by linkerd which are installed during epinio installation.
Removal of unused secrets and service accounts
Removal of quarks secrets copy feature as it can be replaced by simple function.
Use cert-manager instead of quarks secret for certificate generation.
Make the registry ingress accessible
Upgrade k3d to 4.4.4
Remove traefik disable from acceptance tests which downgrades traefik to 1.9.2

This PR works according to the table

Platform
Traefik 1.9.2 (Default from k3d)
Traefik 2.2.3 (Installed by epinio)

k3d
👍🏽
👎🏽

minikube

👍🏽

Progress
I could not reproduce on kind.
@manno  and me saw some issues with flannel. So replaced flannel with calico on K3d and tried to reproduce and I could reproduce. So, this experiment was not so useful.
Pinged Mark about SSL debugging.
Created an issue in k3d https://github.com/rancher/k3d/issues/633

Steps to reproduce

k3d cluster create epinio --k3s-server-arg --disable --k3s-server-arg traefik
git clone https://github.com/epinio/epinio.git
cd epinio
make build-all
./dist/epinio-linux-amd64 install
make patch-epinio-deployment
./dist/epinio-linux-amd64 org create workspace
./dist/epinio-linux-amd64 target workspace
./dist/epinio-linux-amd64 app push app1 ./assets/sample-app/
The above step would fail after sometime.
Execute this command curl  from outside the cluster and it works.
Execute this command `` from any pod ex:- epinio-server-xxx and it should fail with an OpenSSL  error.

I suspect that step 5 should be

export EPINIO_DONT_WAIT_FOR_DEPLOYMENT=true ./dist/epinio-linux-amd64 install --skip-default-org

as we are talking about a dev deployment here which does not have a release image to pull.

Progress to actions items.

Tried to reproduce without linkerd and everything worked.

The issue is finally fixed.
The cause was that in the non working case, the klipper-lb and linkerd modify IP tables which conflict each other and so we see the bug.
@manuelbuil suggested in line with the investigations I found that klipper-lb should not have a linkerd sidecar.

I was also wondering regarding if we should acceptance tests to cover the different cases?


html2canvas not able to print images which are hyperlinked to other server

eg. if page contains image from other server like this http://www.free-avatars.com/data/media/79/Snowman-Cartoon.jpg . Then html2canvas is not able to render it but it leaves a blank white patch. It means function is not waiting for remote image to load.

This is intended behavior and described in the documentation:
"Limitations: All the images that the script uses need to reside under the same origin for it to be able to read them without the assistance of a proxy."
However, if the images on the other server are being served with proper CORS headers you can set the useCORS: true option and it will include the images.


Why does ~True evaluate to -2 ?

I don't see it in the list. Working in a jupyter notebook ~True evaluates to -2. ( ~np.array(True) correctly evaluates to False).
Can someone explain the answer ? Does it need to be added in the list ?

Thanks for the suggestion.
~ is a bitwise NOT operator, which essentially inverts all the 1s and 0s in the binary representation of the operand.  The int value of True is 1.  So essentially what you're seeing is ~1, which is -2.  Why ~1 is -2 needs a bit tricky to explain. The negative numbers are internally represented as two's complement, and when you apply the ~, by flipping the bits, you end up exactly at the binary representation of -2. This StackOverflow thread explains it to some extent https://stackoverflow.com/a/12946226/4354153
I think this would be a good addition to the collection (if someone's up for the challenge, most welcome :), otherwise I'll add it in next major revision) because it's sometimes tempting to use ~ in the boolean conditional logic but it can lead to confusing results like
>>> True == ~False
False

and of course also because numpy handles it differently as you suggested (need to look deeper into it).

Thanks for the explanation. This is frightening as I might have used this before...

thank you, this is interesting :)
>>> ~True
-2

>>> ~False
-1

>>> ~True + ~False
-3

and I didn't know you can even add True to integer:
>>> 5 + True
6


RuntimeError: unreachable

I was editing a Cargo.toml file (moving a dependency to it's own subtable) and the VSCode extension crashed with the below error. I have been unable to reproduce this at all, but figured it was worth noting.
..\.vscode\extensions\tamasfe.even-better-toml-0.14.2\dist\server.js:81
    throw up;
    ^

RuntimeError: unreachable
    at <anonymous>:wasm-function[2096]:0x374582
    at <anonymous>:wasm-function[2798]:0x389b66
    at <anonymous>:wasm-function[2833]:0x38a1ac
    at <anonymous>:wasm-function[2732]:0x388dfd
    at <anonymous>:wasm-function[2834]:0x38a1e2
    at <anonymous>:wasm-function[2689]:0x3882d6
    at <anonymous>:wasm-function[112]:0xe5d36
    at <anonymous>:wasm-function[102]:0xc6c6f
    at <anonymous>:wasm-function[3117]:0x38c268
    at <anonymous>:wasm-function[99]:0xbab2f

Thanks, unfortunately stack traces after wasm-opt are not really informative. However I'm almost certain that it's related to #92, which is an incomplete feature with various edge cases not handled.

I just got the error again, all I did was type [workspace] at the end of a Cargo.toml file. Yet again, I am unable to reproduce it even by typing the exact same characters.
..\.vscode\extensions\tamasfe.even-better-toml-0.14.2\dist\server.js:81
    throw up;
    ^

RuntimeError: unreachable
    at <anonymous>:wasm-function[2096]:0x374582
    at <anonymous>:wasm-function[2798]:0x389b66
    at <anonymous>:wasm-function[2833]:0x38a1ac
    at <anonymous>:wasm-function[2732]:0x388dfd
    at <anonymous>:wasm-function[2834]:0x38a1e2
    at <anonymous>:wasm-function[2689]:0x3882d6
    at <anonymous>:wasm-function[81]:0x64325
    at <anonymous>:wasm-function[3121]:0x38c298
    at <anonymous>:wasm-function[99]:0xbab2f
    at <anonymous>:wasm-function[3120]:0x38c28c

weird, it's not just #92 then, I'll look into it, thanks.


⚠ Minecraft has degraded performance

In a18b441, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1430 ms

Resolved: Minecraft performance has improved in dbc207e.


🐞 Comment text is not spaced correctly

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Multi-line comment is having too much line spacing.
Steps To Reproduce

Go to any circuit details page
in the comment section add new comment with each line broken with a enter
submit the comment and check

Expected Behavior

Screenshots
but what actually is happening:

Device Information [optional]
- OS: windows
- Browser: chrome , firefox
- version: web

Additional context
No response
Are you working on this issue?
Yes

hey is the issue resolved? if not, please assign it to me. this shouldn't take more than a day to solve! Thanks.


Support MapBuilder in make_builder

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

This adds MapBuilder into make_builder function to make it easier to build array builder recursively for schema including nested types.
Are there any user-facing changes?

Thank you @tustvold


Simulation stop on wednesday

Hi,
Does someone know where is the piece of code that set the end of the simulation on the last wednesday ?
Thanks

It's in the zenbrain module, sim.js

Thanks,
I changed 7d to 1d and increase the backillday.

It's set to Wednesday so that the simulations stay constant for that period of time, if you change it to 1 day your simulations will kick out ROI's that vary based on day to day price fluctuations. It is much harder to dial in an 'overfit' strategy.


[Relay][TF] Keep node name in span

With this PR, it is easy to trace a relay CallNode to its source in an imported model. It looks like:
%57 = nn.relu(%56) /* resnet_model/Relu_9 */;
%58 = transpose(%resnet_model/conv2d_12/kernel, axes=[3, 2, 0, 1]);
%59 = nn.conv2d(%57, %58, padding=[0, 0, 0, 0], channels=128, kernel_size=[1, 1]) /* resnet_model/conv2d_12/Conv2D */;
%60 = nn.batch_norm(%59, %resnet_model/batch_normalization_10/gamma, %resnet_model/batch_normalization_10/beta, %resnet_model/batch_normalization_10/moving_mean, %resnet_model/batch_normalization_10/moving_variance, epsilon=1.001e-05f) /* resnet_model/batch_normalization_10/FusedBatchNorm */;

I'm not sure whether it is the correct  to use span.SourceName to store node name, but line, column doesn't make sense for an imported model.
@jroesch @junrushao1994 @zhiics Could you please help to review? Thanks

Ah...I think it is a nice feature and should enable it in all frontend, this is good for profiling (like we use debug graph runtime to see every layer's output). But I remember @tqchen said we will have another WIP feature to do this?

I now think that spand is the right way to do it, as long as we don't rely the information in passes.

Perhaps we could also do similar things for other frontends

@lixiaoquan I think we can do this, but I am not sure if overloading the source spans are the right way? perhaps we can sub-class or modify spans for handling whether they point into a source file or into an imported graph? I think it might be good to clarify this design.

@jroesch I agree with you. It looks like a makeshift to use SourceName to store node name, I did this because it introduced very little change. I think we can add a hint field.  I added a thread https://discuss.tvm.apache.org/t/expand-span-for-imported-module/8435


Validation set & test/train answer differences

Hello,
First off, thanks for this contribution and for making the code public.
I have some questions regarding the validation of your model on VQA-Rad:
First, I wasn’t able to find anything about a validation set. Is the current setup that the model is validated and tested on the same test set?
Second, as I understand it the problem is set up as classification of all the possible answers present in the dataset. However, I noticed that there are many answers in the test set that are not present in the train set. Wouldn’t this mean that it’s impossible (as long as we don’t include any textual embedding of the answers) for the model to predict these answers correctly?
Thanks!

Thanks for your inquiry.

Yes, the test set has been used as validation set as well.

This is mainly true for the VQA-RAD dataset. In the VQA-RAD dataset, (if I remember correctly) about 10% of the answers present in the test set are not present in the training set if you exact match them! This potentially means that without zero-shot approaches, we cannot achieve better than 90% overall accuracy. However, for the SLAKE dataset, there are very few answers in test set that are unseen in the training set.


Is there any plans for other rpc framework like capnproto?

Thanks for the support of grpc, that helps me a lot. I was wondering that whether it would be easy to switch between rpc frameworks using only one jdl design. Please at least tell me where should I start, thank you very much.

A JHipster module for CapnProto could of course be developed the same way as the gRPC one.
I don't have time for that but if you want to do it, me and the JHipster community can surely provide help.


Latest version doesn't have Ruby 3.3.0 compatible precompiled binaries

Ref: https://rubygems.org/gems/blake3-rb/versions/1.5.3-arm64-darwin
As a result to compile it you need to install quite a lot of extra system dependencies such as libclang and libllvm.

Done -> https://rubygems.org/gems/blake3-rb/versions/1.5.4-x86_64-darwin

❤


Fix package TS types path

Should fix part of #124

Looks safe and reasonable, I'll cut a release


Object Overlapping with the nearby lat long

I am facing problem in object overlapping. I am going to develop one AR application with GPS location and plot the objects of the nearby places.But When the lat long is about same it is overlapping with other object. I want to create distance between two objects. Please give me any suggestions.. Thank you in advance.

And i am doing navigation using real time object Map navigation. Is there any solution to navigate and show object to get the direction using object??Please give me any suggestion..Thank you..

did you try with setOffsetOverlaping() method from the library.
or you can also add the library as a local module to the app and modify the code as required for your needs.
while placing the anchor,the library makes use of some heightfactor to decide the cords for the anchor.
you can play around it by changing / modifying the code (i suggest you to use azimuth based approach rather than pitch) which will give you good results

Yes, I have added but it is not  fixed. object moves everytime. So how should i achieve it??And yes i have already added setRefreshInterval(99999) it don't show any object. Please Give me suggestion.

Ok Now i am going to use only setOffsetOverlapping for object overlapping problem it's works fine.

@SheikhZayed @harshadladva  are this issue mean ask for show AR only where user in narby at parameter location set  ? cause in my app, i want to display AR only when user is < 30 M from location setting to display AR object. exactly like Pokemen Go app. thats show Pokemon only in some location setting . sorry my bad english


nonnumeric helper function gives error

I'm trying to apply linestyle based on the numeric value of a column. The example below errors when trying to plot. Changing the input type to string is a workaround (see below).
using AlgebraOfGraphics, CairoMakie
df = (
           x1 = [1, 2, 3],
           x2 = [4, 5, 6],
           y1 = [7, 8, 9],
           y2 = [10, 11, 12],
       )
tr = data(df) * mapping(:x1, :x2)
layers = tr * mapping(linestyle=:y2) * visual(Lines)
save("test.svg", draw(layers))

gives the following error:
ERROR: MethodError: no method matching full_rescale(::Vector{Int64}, ::Type{AlgebraOfGraphics.AesLineStyle}, ::AlgebraOfGraphics.ContinuousScale{Int64})

Closest candidates are:
  full_rescale(::Any, ::Any, ::Any, ::Any, ::Any, ::Any)
   @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:380
  full_rescale(::Any, ::Type{<:Union{AlgebraOfGraphics.AesDeltaX, AlgebraOfGraphics.AesDeltaY, AlgebraOfGraphics.AesDeltaZ, AlgebraOfGraphics.AesX, AlgebraOfGraphics.AesY, AlgebraOfGraphics.AesZ}}, ::AlgebraOfGraphics.ContinuousScale)
   @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:431
  full_rescale(::Any, ::Type{<:Union{AlgebraOfGraphics.AesABIntercept, AlgebraOfGraphics.AesABSlope, AlgebraOfGraphics.AesContourColor}}, ::AlgebraOfGraphics.ContinuousScale)
   @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:415
  ...

Stacktrace:
  [1] full_rescale(data::Vector{…}, key::Symbol, aes_mapping::Dictionaries.Dictionary{…}, scale_mapping::Dictionaries.Dictionary{…}, categoricalscales::Dictionaries.Dictionary{…}, continuousscales::Dictionaries.Dictionary{…})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:383
  [2] (::AlgebraOfGraphics.var"#141#144"{…})(::Pair{…})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:346
  [3] map!(f::AlgebraOfGraphics.var"#141#144"{…}, out::Dictionaries.Dictionary{…}, d::Dictionaries.PairDictionary{…})
    @ Dictionaries ~/.julia/packages/Dictionaries/RaTRN/src/map.jl:57
  [4] map
    @ ~/.julia/packages/Dictionaries/RaTRN/src/map.jl:92 [inlined]
  [5] to_entry(P::Type, p::ProcessedLayer, categoricalscales::Dictionaries.Dictionary{…}, continuousscales::Dictionaries.Dictionary{…})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:345
  [6] to_entry(p::ProcessedLayer, categoricalscales::Dictionaries.Dictionary{…}, continuousscales::Dictionaries.Dictionary{…})
    @ AlgebraOfGraphics ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:328
  [7] #127
    @ ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:127 [inlined]
  [8] iterate
    @ ./generator.jl:47 [inlined]
  [9] _collect(c::Vector{ProcessedLayer}, itr::Base.Generator{Vector{…}, AlgebraOfGraphics.var"#127#131"{…}}, ::Base.EltypeUnknown, isz::Base.HasShape{1})
    @ Base ./array.jl:854
 [10] collect_similar(cont::Vector{ProcessedLayer}, itr::Base.Generator{Vector{…}, AlgebraOfGraphics.var"#127#131"{…}})
    @ Base ./array.jl:763
 [11] map
    @ ./abstractarray.jl:3285 [inlined]
 [12] #126
    @ ~/.julia/packages/AlgebraOfGraphics/dm2ev/src/algebra/layers.jl:126 [inlined]
 [13] #4
    @ ./generator.jl:36 [inlined]
 [14] iterate
    @ ./generator.jl:47 [inlined]
 [15] collect(itr::Base.Generator{Base.Iterators.Zip{Tuple{…}}, Base.var"#4#5"{AlgebraOfGraphics.var"#126#130"{…}}})
    @ Base ./array.jl:834
 [16] map
    @ ./abstractarray.jl:3409 [inlined]
 [17] compute_entries_continuousscales(pls_grid::Matrix{…}, categoricalscales::Dictionaries.Dictionary{…}, scale_props::Dictionaries.Dictionary{…})

     Use `show(err)` to see complete types.

Version info

julia> versioninfo()
Julia Version 1.10.5
Commit 6f3fdf7b362 (2024-08-27 14:19 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 8 virtual cores)```

julia> import Pkg;Pkg.status()
Status `/tmp/jl_YWagMk/Project.toml`
  [cbdf2221] AlgebraOfGraphics v0.8.7
  [13f3f980] CairoMakie v0.12.10

Expected output (from workaround using String for y2):
using AlgebraOfGraphics, CairoMakie
df = (
           x1 = [1, 2, 3],
           x2 = [4, 5, 6],
           y1 = [7, 8, 9],
           y2 = ["10", "11", "12"],
       )
tr = data(df) * mapping(:x1, :x2)
layers = tr * mapping(linestyle=:y2) * visual(Lines)
save("test.svg", draw(layers))

mapping(linestyle=:y2=>nonnumeric) should do it. Linestyle does not work with continuous data, but admittedly the error is not very clear about that.

Thanks, that works.
I did realize linestyle does not work with continuous data, and I see now that I actually messed up my example when trying to produce a minimal test case. What I expected to work (with the nonnumeric in the first mapping) was :
using AlgebraOfGraphics, CairoMakie
df = (
           x1 = [1, 2, 3],
           x2 = [4, 5, 6],
           y1 = [7, 8, 9],
           y2 = [10, 11, 12],
       )
tr = data(df) * mapping(:x1, :x2, :y2=>nonnumeric)
layers = tr * mapping(linestyle=:y2) * visual(Lines)
save("test.svg", draw(layers))

But apparently this doesn't carry over like I expected:
julia> layers = tr * mapping(linestyle=:y2) * visual(Lines)
Layer
  transformation: AlgebraOfGraphics.Visual(Lines, {})
  data: AlgebraOfGraphics.Columns{@NamedTuple{x1::Vector{Int64}, x2::Vector{Int64}, y1::Vector{Int64}, y2::Vector{Int64}}}
  positional:
    1: x1
    2: x2
    3: :y2 => AlgebraOfGraphics.nonnumeric
  named:
    linestyle: y2

julia> layers = tr * mapping(linestyle=:y2=>nonnumeric) * visual(Lines)
Layer
  transformation: AlgebraOfGraphics.Visual(Lines, {})
  data: AlgebraOfGraphics.Columns{@NamedTuple{x1::Vector{Int64}, x2::Vector{Int64}, y1::Vector{Int64}, y2::Vector{Int64}}}
  positional:
    1: x1
    2: x2
    3: :y2 => AlgebraOfGraphics.nonnumeric
  named:
    linestyle: :y2 => AlgebraOfGraphics.nonnumeric


[FEATURE] Ability to add custom tags to createSource

Is your feature request related to a problem? Please describe.
I'm not able to add custom tags to warp.createSource()
Describe the solution you'd like
I'd like to be able to add custom tags to my contract source transactions and data items via warp.createSource() similar to other contract deployment related interfaces
Describe alternatives you've considered
I tried disabling bundling to force createSource() to return a Transaction which I then pushed my custom tags to and signed using arweave-js.  However, I'd like to use bundling.  There's no way to add custom tags to the returned DataItem without constructing my own from scratch.

Hey @jim-toth! Please look at the release note and tell me if everything's ok https://github.com/warp-contracts/warp/releases/tag/v1.4.24


[ruby] Handling nodes directly under typedecl

This PR Handles:

Added new trait AllowedTypeDeclerationChild for all nodes that are allowed to be directly under TypeDecl.
Moved all nodes at start of class definition not allowed under TypeDecl into the <init> method.
astForConstructorMethodBody parses method body for constructor without the implicit return.

Resolves #4395

Lots of tests failing, investigating.


Ensure target is generated during run() with FakeBackendV2

Summary
This commit fixes the noise model construction of instances of FakeBackendV2. Previously, the FakeBackendV2 class would try to build the noise model only if there was a stored BackendProperties JSON payload present. However, if run() is used directly without transpile() or something querying the Target for the backend we won't have necessarily loaded the properties yet. This commit fixes this issue by first checking we have a target defined which will load the properties json if present and then uses the presence of properties to construct the noise model.
Details and comments
Fixes #8862
Fixes #8801

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.759%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
61900

Relevant Lines:
73031

💛  - Coveralls


ElementDataCollection iterable

1. Why is this change necessary?
The ElementDataCollection object is currently not iterable. By making it so, it becomes possible to loop over all results.
Use case
When adding a decorator for a CmsElementResolver it is sometimes unknown what the name of the returned data is exactly.
For example in the ProductSlider CMS element, 3 different names are possible depending on the configuration. It is possible to generate the name according to the configuration again in the decorator, but it is easier and faster to loop over all results and check if the type is correct.
2. What does this change do, exactly?
Implements \IteratorAggregate so the object can be used in a foreach loop.
3. Describe each step to reproduce the issue or behaviour.
/
4. Please link to the relevant issues (if any).
/
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-24062
Please use this issue to track the state of your pull request.

Hello @runelaenen,
thank you very much for your contribution!
Your Pull Request has been successfully imported and merged.
Best regards
Martin Krzykawsk


Getting invalid keyword error on 'bgg.search.query' in production

Project background:
NextJS 13
Typescript
Using bgg.search.query
 bggClient.search.query({ query: value, type: ['boardgame', 'boardgameexpansion'] })
      .then((queryResults) => {
        // eslint-disable-next-line no-console -- cuz
        console.log('not results problem', queryResults)

        // eslint-disable-next-line no-debugger -- deal with it
        debugger;
        //...

I can never get console to log 'not results problem' it seems like the interface may have changed or something is wrong with the search.
XML response from rest client

Example code that will fail in next13
    console.log(bggClient)
    bggClient.search.query({ query: 'Monopoly' })
      .then((r) => {
        // eslint-disable-next-line no-console -- is client made?
        console.log(r)
      })
      .catch((error) => {
        // eslint-disable-next-line no-console -- cuz
        console.log('search error:'error)
      })

What is very odd is when I run locally npm run dev it seems to work fine with no issues, my error ONLY occurs when I run in production mode. The test code above returns 'search error' Invalid keyword

Debugging next production is extremely difficult so I can't help much more than this unfortunately. I am trying to get this project out soon. If I could get some help with this that would be great or I will have to wrap my own APIs for the search functionality.
I also tried other calls, like 'hot' and 'thing' and they seem to work fine in production mode. Seems to be an error with search from what I can tell.

Console when running locally

@LearningProcesss is this still an active project? or should I fork and fix myself

@LearningProcesss is this still an active project? or should I fork and fix myself

Hi, which version are you using?

It's actually the same in Angular production mode.
In Dev everything works fine. In production, I see the XML response from BGG API in network, but then, nothing happens. No console logs, nothing.

The reason for this seems to be the jackson-js library and its annotations.
Using parts of the code of this repository with a custom parsing instead of jackson-js works fine in Angular production mode.