embrace type coercion

Since Sanctuary is available for those who dislike type coercion, perhaps Ramda should embrace type coercion. #1966 provides an example of "surprising" behaviour due to coercing in some cases but not others. Perhaps String as an input type should mean Ramda will apply String to the value and use the result in the computation. So, for example, R.toUpper(null) would evaluate to 'NULL'.
This is just an idea. Feel free to react with :thumbsup: or :thumbsdown:.

Like all the reaction emoticons I'm also :-1: in the general case, but I think there are good places for principled exceptions to our usual stronger enforcement of types.  The changes in #1926 are a good example.  Rather than sticking with the less useful String-only API, this PR expanded some functions to include a String | Int typedef.  There is a very straightforward argument that union types are inherently less principled than their unary counterparts, but they prove themselves useful time and again.
#1966 is a borderline case because by far the easiest -- and likely also the simplest -- way to enforce the obvious invariant is, as you say, to apply String to the purported key in assoc and dissoc.  I could live with this if it's documented only to work with Strings / Ints.  But I wouldn't be thrilled in seeing this implemented that way.  I really wouldn't want users intentionally using other objects' toString methods for this, or at least not to count on such code continuing to work between releases
So no to the general case, but that doesn't mean we shouldn't consider it where it makes sense..

Rather than sticking with the less useful String-only API, this PR expanded some functions to include a String | Int typedef.

I've no problem with this. :)

I could live with this if it's documented only to work with Strings / Ints.

This highlights one significant philosophical difference between Ramda and Sanctuary: Ramda documents intended usage; Sanctuary actually enforces its invariants.
If one day Ramda goes down the sanctuary-def route we could handle String | Int quite nicely:
//    Idx :: Type
const Idx = $.NullaryType('ramda/Idx', R.either($.String._test, $.Integer._test));

This highlights one significant philosophical difference between Ramda and Sanctuary: Ramda documents intended usage; Sanctuary actually enforces its invariants.

Yes.  Ramda is willing to trade some type safety in exchange for reduced exception-throwing and higher performance.  It is a significant difference.  I do think the community is stronger by having both approaches available.


Resolve HolidaysBase() typo for HolidayBase() in README.

Found a minor typo in the README while using this great library. 🎉
Thanks for the work put into this by the way.

Pull Request Test Coverage Report for Build 749

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.951%

Totals

Change from base Build 727:
0.0%

Covered Lines:
8141

Relevant Lines:
8145

💛  - Coveralls

Hey there,
thank you very much for the fix and your appreciation! 👍
Merged on beta branch.. cheers!
dr-p


Add the ImageJ Macro Language

I am adding the ImageJ Macro language widely used by scientists to handle images, particularly microscopy data.
The macro language is saved in .ijm files. It would be great to see it recognised by GitHub.
I chose color: "#99AAFF# from the ImageJ Macro web documentation. It did not appear elsewhere in the list.
Checklist:

[x]  I am adding a new language.
[x] The extension of the new language is used in hundreds of repositories on GitHub.com.
Search results for extension:ijm = 7K
[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

simple.ijm
batch of ratiometric FRET using IO settings.ijm

Sample license(s):

ImageJ License
MIT

[ ] I have included a syntax highlighting grammar
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

Samples need to be in a folder with the exact same name as the language, ImageJ Macro. Logs currently throw an error saying Expected: "ImageJ"  Actual: "ImageJ Macro"

The other error is a missing language ID: use https://gist.github.com/Nixinova/6817e82fffe85f0b33491d32ad8742eb to generate it, replacing "lang" with "ImageJ Macro".

At this point I am quite lost.
Could you tell me what are the three Ruby checks for?
I am very sorry for all the pings. I have spent weeks trying to work out how to get this right on my own machine, but as soon as I submitted the pull request it feels like a totally different approach.
Is it running ruby script stored within the repo? I am having problems installing all dependencies on my machine. If not, then I have no idea.

Green tick, gj :+1:

Can you please add a link to the source and state the license of the simple.ijm sample you've included to the OP.

Can you please add a link to the source and state the license of the simple.ijm sample you've included to the OP.

I have updated the original comment now, with a link and a source (does it matter that the source is a text file I converted to the .ijm format?).
Thanks for your help an patience.

(does it matter that the source is a text file I converted to the .ijm format?)

Nope.
Thanks for updating the OP.

Thanks for this, the ImageJ Macro language is nicely detected in the language bar statistics. However, when I click the linked search for ImageJ Macro language, the results are empty, see e.g. https://github.com/cleterrier/Utils/search?l=imagej-macro
Is that search functionality also located in this repository, or are changes required somewhere else to make the search work?

Is that search functionality also located in this repository, or are changes required somewhere else to make the search work?

Search uses go-enry for the language detection which feeds in Linguist releases but these tend to lag a few months. Case in point, https://github.com/go-enry/go-enry/pull/52 is still open to update to v7.14.0 however we've already released v7.15.0, so it should probably be closed and a newer PR opened.
I don't summit a PR to go-enry when I make a new Linguist release but I'm tempted to start doing so to head off questions like yours.


TypeError getting isFetching from use*Query when selectFromResult is used.

I wanted to use selectFromResult but found that to have isSuccess and the likes, they would also have to be passed through this selector.
However this does not work for isFetching, and gives the error:
Property 'isFetching' does not exist on type '({ status: QueryStatus.uninitialized; originalArgs?: undefined; data?: undefined; error?: undefined; requestId?: undefined; endpointName?: string | undefined; startedTimeStamp?: undefined; fulfilledTimeStamp?: undefined; } & { ...; }) | ({ ...; } & { ...; }) | ({ ...; } & { ...; }) | ({ ...; } & { ...; })'.ts(2339)

Am i missing something with how this is to be used, or is it a bug?
For example this will work:
const { data, isSuccess } = useGetPokemonByNameQuery(name, {
    selectFromResult: ({ data, isSuccess }) => ({ data, isSuccess })
  });

This will give a a type error:
const { data, isFetching } = useGetPokemonByNameQuery(name, {
    selectFromResult: ({ data, isFetching }) => ({ data, isFetching })
  });

Here's a codesandbox to show it:
https://codesandbox.io/s/concepts-queries-deduping-caching-forked-b4u4z?file=/src/Pokemon.tsx

isFetching is actually not a part of currentState and needs to be calculated on a per-hook-level, by calling defaultQueryStateSelector, passed in as third argument into that selector function.
So, correct code would be
  const {
    data: selectFromResultWithIsFetching,
    isFetching
  } = useGetPokemonByNameQuery(name, {
    selectFromResult: (result, lastResult: {data: any, isFetching: boolean} | undefined, defaultSelector) => {
      const { data, isFetching } = defaultSelector(result, {...lastResult});
      return { data, isFetching }
    }
  });

We clearly need to document this.
Also, this uncovered a bug in the types - this should also be possible to do as just
  const {
    data: selectFromResultWithIsFetching,
    isFetching
  } = useGetPokemonByNameQuery(name, {
-    selectFromResult: (result, lastResult: {data: any, isFetching: boolean} | undefined, defaultSelector) => {
+    selectFromResult: (result, lastResult, defaultSelector) => {
-      const { data, isFetching } = defaultSelector(result, {...lastResult});
+      const { data, isFetching } = defaultSelector(result, lastResult);
      return { data, isFetching }
    }
  });

which it currently isn't.
So we probably need changes like
export type QueryStateSelector<R, D extends QueryDefinition<any, any, any, any>> = (
  state: QueryResultSelectorResult<D>,
-  lastResult: R | undefined,
+  lastResult: NoInfer<R> | undefined,
  defaultQueryStateSelector: DefaultQueryStateSelector<D>
) => R;

export type DefaultQueryStateSelector<D extends QueryDefinition<any, any, any, any>> = (
  state: QueryResultSelectorResult<D>,
-  lastResult: Pick<UseQueryStateDefaultResult<D>, 'data'>
+  lastResult: Pick<UseQueryStateDefaultResult<D>, 'data'> | undefined
) => UseQueryStateDefaultResult<D>;

for this to be used better in the next version.

Thanks for the throughout answer!
Regarding documentation, i at first only looked at the selecing data from a query result section, which made it seem like it just takes the data and filters it. Now from looking at the useQuery api reference i see that selectFromResult takes a QueryStateSelector which isn't mentioned anywhere in the docs.
Hope this isn't comming of as complaning - I just wanted to add how I as a new user of RTK-query read the documentation.
And just to confirm - in the case where I want to select a subset of a query and get IsFetching in a component, your  first code block would be the correct way to do it?

Yeah, there is still a lot of stuff to be documented and some edges are also only found by early adopters such as you :)

And just to confirm - in the case where I want to select a subset of a query and get IsFetching in a component, your first code block would be the correct way to do it?

Yes (the same for isLoading) with one caveat: if your subset would be undefined at times, while result.data would be present, actually both isLoading and isFetching might both return to true where it would not be if you returned result.data.
Might need to think more about that. Maybe we can do that better in the next release.

This should get handled better after we get https://github.com/reduxjs/redux-toolkit/pull/1035 in

Closing this here.


revisit 'Foreign key options' section

needs revisiting w/r/t proposed syntax drift; other unique options (indexes, etc)
this page: https://docs.datajoint.io/python/definition/10-Dependencies.html

Though the options documentation reflects the current datajoint-python and new syntax, this has not been updated yet in datajoint-matlab. An example of the prior syntax for specifying options is the following:
(new_attr1, new_attr2) -> [nullable, unique] ClassName.TableName(old_attr1, old_attr2)


Support multiple accounts on REST interface

The current implementation requires separate BitmexApiService instances for each account, as account details (in BitmexAuthorization) are passed in at construction time. This in turn means separate TCP connections for each account.
Providing an alternate interface where account details are passed with a request would allow any number of accounts to share a single connection.

@tekr good point! If you provide a very elegant way to do that, I will accept your pull request. but I think you can handle it without any changes. When I designed the structure I expected handling this case by registration the components with the following way. This example uses UnityContainer but you can implement absolutely the same behaviour using any other DI framework.
           // authorization1 - this instance contains apikey1 and secret1
            Container.RegisterInstance<IBitmexAuthorization>("AuthorizationAccount1", authorization1);
            Container.RegisterType<IBitmexApiProxy, BitmexApiProxy>($"BitmexApiProxyAccount1",
                new InjectionConstructor(new ResolvedParameter<IBitmexAuthorization>($"AuthorizationAccount1")));
            Container.RegisterType<IBitmexApiService, BitmexApiService>($"BitmexApiServiceAccount1",
                new InjectionConstructor(new ResolvedParameter<IBitmexApiProxy>($"BitmexApiProxyAccount1")));

           // authorization2 - uses another credencials
            Container.RegisterInstance<IBitmexAuthorization>("AuthorizationAccount2", authorization2);
            Container.RegisterType<IBitmexApiProxy, BitmexApiProxy>($"BitmexApiProxyAccount2",
                new InjectionConstructor(new ResolvedParameter<IBitmexAuthorization>($"AuthorizationAccount2")));
            Container.RegisterType<IBitmexApiService, BitmexApiService>($"BitmexApiServiceAccount2",
                new InjectionConstructor(new ResolvedParameter<IBitmexApiProxy>($"BitmexApiProxyAccount2")));

let me know if it covers you case

@semashkinvg The current implementation requires each account to have its own TCP connection. I.e. 10 accounts = 10 TCP connections.
However it's fairly straightforward to support multiple accounts on one connection given that account detail are specified on every REST request. There are at least a couple of ways to do it:

Make the IBitmexAuthorization parameter optional in the BitmexApiService constructor, and add an optional parameter for it to IBitmexApiService.Execute(). It can then be specified in the constructor (as before) for single-account usage, or alternatively in the Execute() calls for multi-account usage.

Add an IBitmexMultiAccountApiService interface and BitmexMultiAccountApiService implementation. They would be similar to the existing (I)BitmexApiService, except IBitmexAuthorization is moved from the constructor to the Execute() method.

The first approach has the advantage of less code/duplication, but with the loss of compile-time checking that an IBitmexAuthorization has been specified in either the constructor or Execute() call (of course it can be checked at run-time).
The second approach allows compile-time checking, at the cost of some duplication.
Do you have a preference? I'm happy to go with either approach.

NB. Commits 51f0996 and 7c99c8f referenced above are implementations of options 1 and 2 respectively. Let me know if you're happy with one of them and I'll raise a PR.

@tekr wow thanks, I will have a look tonight

So.. not keen on adopting either approach?
In my current production setup I'm using 7c99c8f (i.e. a build with [I]BitmexMultiAccountApiService added). Happy to keep maintaining that fork if need be as it's not much extra code. I just figured some others may find it useful.


Inclusion of Post Ems for FreeCEN records

Chris M has asked whether Post Ems can be included for FreeCEN records as is done for BMD.
The FreeCEN Committee thought that this is worthwhile. Feedback to an enquiry some time ago was that this would require an extra field in the FreeCEN csv data collection. It would not be achievable in the vld data collection.
I am notsure how difficult this would be, or whether we should wait for FreeCEN to be aligned with FreeBMD and FreeREG?

To add into Roadmap


Add access_control example to the configuration reference

Reflecting the anonymous: ~ behavior from the old security system.

https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/Resources/doc/index.md#configuration
Are the issue solved? I think the docs is good except IS_AUTHENTICATED_ANONYMOUSLY.  Should we use PUBLIC_ACCESS in new system or both are correct actually?

We should use PUBLIC_ACCESS here

We should use PUBLIC_ACCESS here

Alright, i can make a PR for it.

Since we are promoting new authentication system, perhaps this section need to update as well (like removing the guard authentication usage) ?
https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/Resources/doc/1-configuration-reference.md#security-configuration

Alright, i can make a PR for it.

That would be great!

Since we are promoting new authentication system, perhaps this section need to update as well (like removing the guard authentication usage) ?

I think we should keep the guard reference until we bump Symfony to 5.3+. Makes sense?

Since we are promoting new authentication system, perhaps this section need to update as well (like removing the guard authentication usage) ?

I think we should keep the guard reference until we bump Symfony to 5.3+. Makes sense?

Yeah it does make sense here. But i realize that i did make a mistake here, i replace the "extending jwt guard authenticator" with "extending jwt authenticator" doc in my last PR. So i will restore the previous one and make it become two section in a file.
And last thing, the bundle require Symfony 4.4+ but the doc still having Symfony 3 usage at https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/Resources/doc/index.md#prerequisites
Should we remove that one as well?

Oh yes, indeed!

Oh yes, indeed!

Done making a PR. Waiting for review.


Update TradeSystem to 1.21.3

Requires CodingAPI from https://github.com/erikzimmermann/CodingAPI/tree/version/1.21.3 to be published first.

outdated


grep: warning: stray \ before -

On commit, I get
grep: warning: stray \ before -

that's caused by the following pattern
% git config --get-all secrets.patterns|grep ACCOUNT
("|')?(AWS|aws|Aws)?_?(ACCOUNT|account|Account)_?(ID|id|Id)?("|')?\s*(:|=>|=)\s*("|')?[0-9]{4}\-?[0-9]{4}\-?[0-9]{4}("|')?
%

as demonstrated by
% grep -E "(\"|')?(AWS|aws|Aws)?_?(ACCOUNT|account|Account)_?(ID|id|Id)?(\"|')?\\s*(:|=>|=)\\s*(\"|')?[0-9]{4}\\-?[0-9]{4}\\-?[0-9]{4}(\"|')?"
grep: warning: stray \ before -
grep: warning: stray \ before -

This is on up-to-date Arch Linux and git-secrets 1.3.0 (the latest tag, from 3.5 years ago, which contains the latest master version of the git-secrets script).

Hello,
Any new about this issue?
I have same problem with the 3.18.3 official Alpine docker image with the las grep upgrade.
Regards,


RDBMS: Connections are not closed

Describe the bug
The RDBMS connector leaves JDBC connections open
To Reproduce
A simple test with the RDBMSMEtadataProvider
        for (i in 1..100) {
            val metadata = provider.fetchMetadata(dataSourceNoAggregation)
 }

Expected behavior
JBDC connections MUST be closed

fixed


Post on PyPI

The readme says this is available via pip install django-constant-contact, but it's not on pypi yet.

Has been for a while.


Two blackscreens with /rfx and /gdi:hw

I am currently experiencing two blackscreens (two monitor setup and it does not matter which one is the primary) with the command line xfreerdp /u: /p: /d: /v: /gdi:hw /f /multimon +sec-nla /rfx /cert-ignore
to a 2012R2 server. It shows the mouse cursor though.
If I change either /rfx or /gdi:hw it works instantly. No problems with /gfx:rfx. When I now reinitialize the monitors with xrandr while the session is running (make both monitors off with xrandr and then use xrandr --auto) the session shows up normally.

@T3N4K4 Same command line works with 2012R2, win8.1, win10 and win7 here. Could you add some additional info (build of your xfreerdp, client environment, ...)?

Environment: Ubuntu 15.10, x86, Kernel 4.9.21.
Build configuration:
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EVENTFD_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=ON WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_GDI=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_ORDERS=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DIRECTFB=OFF WITH_EVENTFD_READ_WRITE=1 WITH_FFMPEG=ON WITH_GPROF=OFF WITH_GSM=ON WITH_GSTREAMER_0_10=ON WITH_GSTREAMER_1_0=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_KRB5=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_LEAK=OFF WITH_SANITIZE_LEAK_AVAILABLE=1 WITH_SERVER=OFF WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SSE2=OFF WITH_THIRD_PARTY=ON WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=OFF WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XDGAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:               -march=i686 -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls
Compiler:            GNU, 5.2.1
Target architecture: x86

It just shows
[11:20:54:176] [26529:26530] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[11:20:54:176] [26529:26530] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_BGRA32

and nothing happens anymore except the two screens being black.
One screen has the resolution of 1600x1200 (DVI) and one of 2560x1080 (HDMI). Both at 60 Hz.

@akallabeth when I compare the two beginnings of the commandline above with /gdi:hw and /gdi:sw it seems like /gdi:hw does initialize but then does not react on changes:
HW:
[09:14:55:215] [9469:9470] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[09:14:55:215] [9469:9470] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_BGRA32
[09:14:55:247] [9469:9470] [DEBUG][com.freerdp.core.update] - SurfaceFrameMarker: action: Begin (0) id: 0
[09:14:55:247] [9469:9470] [DEBUG][com.freerdp.core.update] - SurfaceFrameMarker: action: End (1) id: 0
[09:14:55:312] [9469:9470] [DEBUG][com.freerdp.core.update] - SurfaceFrameMarker: action: Begin (0) id: 0
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC0 blockLen 12
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - version 0x00000100
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC3 blockLen 13
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - ctxId 0 tileSize 64 properties 0x2828.
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - codec is in video mode.
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - RLGR3.
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC1 blockLen 10
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - id 1 version 0x100.
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC2 blockLen 12
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - numChannels 1 id 0, 2560x1200.
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC4 blockLen 14
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_BEGIN: frameIdx: 0 numRegions: 1
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC6 blockLen 23
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - rect 0 (x,y=0,0 w,h=1600 1200).
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC7 blockLen 20927
[09:14:55:313] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - quant 0 (6 6 6 6 7 7 8 8 8 9).
[09:14:55:354] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC5 blockLen 8
[09:14:55:354] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_END
[09:14:55:370] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC4 blockLen 14
[09:14:55:370] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_BEGIN: frameIdx: 1 numRegions: 1
[09:14:55:370] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC6 blockLen 23
[09:14:55:370] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - rect 0 (x,y=0,0 w,h=2560 1080).
[09:14:55:370] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC7 blockLen 29947
[09:14:55:370] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - quant 0 (6 6 6 6 7 7 8 8 8 9).
[09:14:55:411] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC5 blockLen 8
[09:14:55:411] [9469:9470] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_END

SW:
[09:15:06:481] [10060:10070] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[09:15:06:481] [10060:10070] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_BGRA32
[09:15:06:511] [10060:10070] [DEBUG][com.freerdp.core.update] - SurfaceFrameMarker: action: Begin (0) id: 0
[09:15:06:511] [10060:10070] [DEBUG][com.freerdp.gdi] - frameId 0 frameAction 0
[09:15:06:511] [10060:10070] [DEBUG][com.freerdp.core.update] - SurfaceFrameMarker: action: End (1) id: 0
[09:15:06:511] [10060:10070] [DEBUG][com.freerdp.gdi] - frameId 0 frameAction 1
[09:15:06:576] [10060:10070] [DEBUG][com.freerdp.core.update] - SurfaceFrameMarker: action: Begin (0) id: 0
[09:15:06:576] [10060:10070] [DEBUG][com.freerdp.gdi] - frameId 0 frameAction 0
[09:15:07:621] [10060:10070] [DEBUG][com.freerdp.gdi] - destLeft 0 destTop 0 destRight 1600 destBottom 1200 bpp 32 codecID 3 width 1600 height 1200 length 21019
[09:15:07:621] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC0 blockLen 12
[09:15:07:621] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - version 0x00000100
[09:15:07:621] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC3 blockLen 13
[09:15:07:621] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - ctxId 0 tileSize 64 properties 0x2828.
[09:15:07:621] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - codec is in video mode.
[09:15:07:621] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - RLGR3.
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC1 blockLen 10
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - id 1 version 0x100.
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC2 blockLen 12
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - numChannels 1 id 0, 2560x1200.
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC4 blockLen 14
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_BEGIN: frameIdx: 0 numRegions: 1
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC6 blockLen 23
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - rect 0 (x,y=0,0 w,h=1600 1200).
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC7 blockLen 20927
[09:15:07:622] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - quant 0 (6 6 6 6 7 7 8 8 8 9).
[09:15:07:682] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC5 blockLen 8
[09:15:07:682] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_END
[09:15:07:700] [10060:10070] [DEBUG][com.freerdp.gdi] - destLeft 1600 destTop 0 destRight 4160 destBottom 1080 bpp 32 codecID 3 width 2560 height 1080 length 29992
[09:15:07:700] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC4 blockLen 14
[09:15:07:700] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_BEGIN: frameIdx: 1 numRegions: 1
[09:15:07:700] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC6 blockLen 23
[09:15:07:700] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - rect 0 (x,y=0,0 w,h=2560 1080).
[09:15:07:700] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC7 blockLen 29947
[09:15:07:700] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - quant 0 (6 6 6 6 7 7 8 8 8 9).
[09:15:07:745] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - blockType 0xCCC5 blockLen 8
[09:15:07:745] [10060:10070] [DEBUG][com.freerdp.codec.rfx] - RFX_FRAME_END

@akallabeth I'm sorry. Next time I fill in a bug please remind me to drink more coffee or tea ...
I forgot that I experimented with libssl the last time and did not undo my changes.
After installing the correct libssl.so it was working again :(


built PRs differential

Before submitting

[x] Was this discussed/approved via a GitHub issue? (no need for typos and docs improvements)
[ ] Did you create/update your configuration file?
[ ] Did you add your config to CI - GitHub action and Azure pipeline?
[ ] Are all integration tests passing?

What does this PR do? [optional]
Resolves #16
Did you have fun?
Make sure you had fun coding 🙃


[All Products]: Set up Routes Component

At minimum:
will house the following routes:

[x] homepage
[x] all products

Also added a footer component


3scale-kourier-gateway pod fails to start with istio sidecar injection

issue

When enabled sidecar injection on 3scale-kourier-gateway, the pod is not able to start.
Even though adding --base-id  option, the gateway pod still does not start well.

step to reproduce
0. Deploy Serving with Kourier
$ cd ${KNATIVE_SERVING_CODE}
$ kubectl apply -f third_party/kourier-latest/kourier.yaml
$ ko apply -f config/  --selector=networking.knative.dev/ingress-provider!=istio

1. Deploy Istio
(Please download istioctl 1.6.3 from here https://github.com/istio/istio/releases/tag/1.6.3)
$ wget https://gist.githubusercontent.com/nak3/1f533b1a8be1bdd891e9b2fd8bebb40a/raw/d6acf8e0688e046c1c115ab553fd8669a0c78688/istio-mesh.yaml
$ istioctl manifest apply -f istio-ci-mesh.yaml

2. Enable sidecar injection on kourier-gateway
$ kubectl label namespace kourier-system istio-injection=enabled
$ kubectl  delete pod -n kourier-system --all                   # Restart pods to enable sidecar injection

3. Controller can run but gateway does not.
$ kubectl  get pod -n kourier-system
NAME                                      READY   STATUS             RESTARTS   AGE
3scale-kourier-control-5485f6df9f-fxb2g   2/2     Running            0          87s
3scale-kourier-gateway-67d8847b79-x2t5k   0/2     CrashLoopBackOff   2          60s

$ kubectl  get pod -n kourier-system
NAME                                      READY   STATUS      RESTARTS   AGE
3scale-kourier-control-5485f6df9f-fxb2g   2/2     Running     0          64s
3scale-kourier-gateway-67d8847b79-x2t5k   0/2     Completed   2          37s

4. Adding base-id option
As you can see unable to bind domain socket with id=0 (see --base-id option), the base-id was conflicted.
$ kubectl  -n kourier-system logs 3scale-kourier-gateway-67d8847b79-x2t5k -c istio-proxy
  ...
[2020-06-28 07:04:16.886][14][debug][init] [external/envoy/source/common/init/watcher_impl.cc:27] init manager Server destroyed
unable to bind domain socket with id=0 (see --base-id option)
2020-06-28T07:04:16.890205Z	error	Epoch 0 exited with error: exit status 1
2020-06-28T07:04:16.890235Z	info	No more active epochs, terminating

So add base-id option to kourier-gateway deployment.
    spec:
      containers:
      - args:
        - -c
        - /tmp/config/envoy-bootstrap.yaml
        - --base-id
        - 1

5. still 3scale-kourier-gateway fails with connection refused error.
$ kubectl  -n kourier-system  describe pod 3scale-kourier-gateway-7c98464679-mtb42
  ...
   I opened https://issues.redhat.com/browse/SRVKS-584 as well.

#112 has been merged.
/close


OBJC_CLASS$_AFHTTPResponseSerializer", referenced from:

Undefined symbols for architecture x86_64:
"OBJC_CLASS$_AFHTTPResponseSerializer", referenced from:
objc-class-ref in AFNetworkingUtil.o
objc-class-ref in MDETaskManager.o
"OBJC_CLASS$_AFHTTPSessionManager", referenced from:
objc-class-ref in AFNetworkingUtil.o
objc-class-ref in MDETaskManager.o
objc-class-ref in NDSCDWorkManager.o
objc-class-ref in NDSCDPersonalManager.o
"OBJC_CLASS$_AFJSONResponseSerializer", referenced from:
objc-class-ref in MDETaskManager.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Same issue after updating the cocoa pods. :(

Are you still having this issue?

@SlaunchaMan I'm having this issue, but just with the Serializers.  I have tried everything I can think of.
I'm using the latest CocoaPods production executable, along with v3.1.0 of AFNetworking.
I've tried everything short of not using CocoaPods.
Any ideas?

I don't think it's related at all, but I did have to modified the AFURLSessionManager.h file to fix a compiler error:
/**
 The dispatch queue for `completionBlock`. If `NULL` (default), the main queue is used.
 */
#if OS_OBJECT_HAVE_OBJC_SUPPORT
@property (nonatomic, strong, nullable) dispatch_queue_t completionQueue;
#else
@property (nonatomic, assign, nullable) dispatch_queue_t completionQueue;
#endif

/**
 The dispatch group for `completionBlock`. If `NULL` (default), a private dispatch group is used.
 */
#if OS_OBJECT_HAVE_OBJC_SUPPORT
@property (nonatomic, strong, nullable) dispatch_group_t completionGroup;
#else
@property (nonatomic, assign, nullable) dispatch_group_t completionGroup;
#endif


MicroWin doesn't open Windows 11 ISO

When I try to select Windows' ISO, MicroWin gives me the following error:
"Install.wim file doesn't exist in the image".
I've just downloaded the ISO from microsoft website (from here https://www.microsoft.com/software-download/windows11). The same error appears if I try to use Win10 ISO or an ISO from the media creation tool

As described in the error dialog window on your screenshot:
* One cannot use Windows ISO downloaded by Media Creation Tool or downloaded using any browser with the Windows user agent string, because Microsoft serves in such cases ISO with more compressed install.esd (instead of install.wim) file that is not editable by Winutil.

* You must change the user agent string your browser uses when downloading the Windows ISO = change the user agent to some other OS - Chrome OS, Linux, etc. or download the ISO using a device with some other OS.

I know I cannot use a ISO from MCT but I've had no idea about the user agent, it is not specified anywhere. Thanks for the answer, I'll try

i have the same issues you can extract the iso and convert install.esd to install.wim using powershell check this solution
https://www.itechguides.com/convert-esd-to-wim/


'migrate' uses the wrong database

After applying the patch in #31, running fragmenta migrate at the top dir of my Fragmenta-CMS project gives me this output:
% fragmenta migrate
12:12:18
------

12:12:18 Opened database at fragmentatest_development for user sybren
12:12:18 Database ERROR pq: relation "fragmenta_metadata" does not exist
12:12:18 Running migration 2018-07-17-115428-Create-Database.sql
12:12:18 Running database creation migration: db/migrate/2018-07-17-115428-Create-Database.sql
12:12:18 psql: FATAL:  database "sybren" does not exist
12:12:18 ERROR loading sql migration:exit status 2
12:12:18 All further migrations cancelled

12:12:18 No migrations to perform at path ./db/migrate

You can see on the first line that it knows the correct database name fragmentatest_development. However, the 5th line shows that the wrong database name sybren is used.

Did you perhaps edit your secrets file after generating the site, without adjusting the Create-Database migration (which does exactly what the name would imply)?
If you prefer you can just delete this migration and create the db yourself manually with whatever username/pass combination you wish - this initial migration is just for bootstrapping so that you don't have to fiddle with the db, but it is optional if you wish to name/create a db yourself (as you seem to).

Did you perhaps edit your secrets file after generating the site, without adjusting the Create-Database migration (which does exactly what the name would imply)?

In the code that runs the migration (https://github.com/fragmenta/fragmenta/blob/master/migrate.go#L62) you explicitly do not pass a database name. This makes psql connect to the database named after the current user, which doesn't exist on my system.
I wouldn't expect to have to regenerate anything after changing the database credentials.

OK, psql won't run a migration which consists of just creating a role and db (as this one does), so I don't see any solution to that really - you can't run psql against a db which doesn't exist yet (as is the situation when bootstrapping). I usually create the user db when creating a user to avoid exactly this sort of situation (for example your setup precludes you from just connecting to psql without specifying a database to query).
I think in this situation the best solution is not to attempt to use this migration but do your own db setup with your preferred user/db name and just edit the secrets file.


[Suggestions] Some more JEI integration

For recipes that are not available in JEI I often find myself having to craft everything until that point to creste the recipe. This is especially annoying for fluids.
My idea is to make it possible to drag and drop items from JEI into the pattern grid.
In a similar vein with the new bookmark feature from JEI I often find myself typing in itemnames  of items that I can already see on the left side screen.
Idea here is to add a shorcut for inserting itemnames. For example control  + click on an item inserts the name into the search bar. Drag and drop onto the searchbar might be more intuitive though.

The drag and drop JEI code is already there, but due to a bug in JEI unfortunately this cannot work. When there is dragging code present, you can no longer look up recipes and usages.

https://github.com/mezz/JustEnoughItems/issues/1307


Error build status at the Docker registry

https://registry.hub.docker.com/u/cachethq/cachet/builds_history/122451/
The last 2 builds have an error status.

I just saw you fixed the Travis build, so I'm sure the Docker build will be fine too.

It could be related, let's see :)

@sammcj hey buddy, can I somehow add you to the Registry and let you handle it? :)

Hey @jbrooksuk - sorry I'm in the middle of moving house at the moment!

This no longer seems to be an issue now? https://registry.hub.docker.com/u/cachethq/cachet/builds_history/122451/


Clearify documentation

The documentation for the Read opcode says it's equivalent to read(2) but I believe that's incorrect as you have to specify offset = -1 to get the behavior for read(2). The docs should reflect that.

This is actually copied from the liburing manpage. would you like to update it with a PR?

Sure, I'll submit a PR when I'm in front of my computer again. This applies to write too.

I filed an issue upstream about this too https://github.com/axboe/liburing/issues/435


no result in folder

Hello. Problem with run this

It seems that your folder has no images. Can you show me the structure of your input_dir?

the problem was with the extension.


Solving issue #29

I tested it in the canvas-lms open source project (that uses this gem) and it works like a charm.

Note that this isn't strictly necessary. The problem in canvas-lms is we were calling ICU::Lib.figure_suffix with the output of ICU::Lib.version.to_s, instead of ICU::Lib.load_icu (which is not clear, given that figure_suffix's argument is version).


FAQ theme?

Hello, @digitalcraftsman! I only want to ask, is there any reason to add FAQ theme to showcase? I am in doubt!

Hello @aerohub,
thanks again for submitting a new Hugo theme. Could you add a static folder to the exampleSite directory?

@digitalcraftsman oh, my fault! Added now. Thank you very much!

Great. Now, the demo works too.I added your theme in 3e58f296799e1921f19fe27a6d8c5c79c74dc57b.


Allow dependency_overrides for dependencies of dependencies

Right now it is possible to use dependency_overrides for the dependencies of your own project, but not for the dependencies of your dependencies. This frequently leads to the following kind of problem:
https://github.com/appsup-dart/firebase_admin/issues/40
Issues like this can sit for months or years, if the repo is abandoned, even with a PR:
https://github.com/appsup-dart/firebase_admin/pull/41/files
Eventually a repo like this will have to be forked by somebody who will actually bring it up to date and maintain it, but in the short term, it means that every user of this repo who needs to work with a newer version of a library (due to the version constraints of other dependencies in their project) needs to fork the abandoned repo themselves, and update the pubspec in that repo.
A better solution would be to be able to do something like the following, to override the dependencies of the dependency:
dependencies:
  firebase_admin: ^0.2.0
    dependency_overrides:
      http: '>=0.13.0 <2.0.0'

My understanding of dependency_overrides  is that is should force constraint resolution to use the indicated version (https://dart.dev/tools/pub/dependencies#dependency-overrides), irrespective of the version constraint specified in either your direct dependencies: section or the version constraint from any direct or transitive dep.
Can you confirm that you are seeing something different from this? Preferably via a minimal repro. Thanks!

@devoncarew Correct, based on the current usage of dependency_overrides, which affects only the dependencies of your own project.
I am proposing augmenting the pubspec.yaml syntax to add a new dependency_overrides section as a child of any dependency, so that the dependencies of the dependency can be forced to a specific version.
The "repro" is the bug report I linked. Basically, tyr depending upon firebase_admin: ^0.2.0 and http: ^1.0.0 in the same project, and you will see the problem. firebase_admin is compatible with http: ^1.0.0, but its own dependency on this is http: ^0.13.0, so you cannot use  if your project needs http: ^1.0.0 (possibly because another dependency you are using depends upon it), you can't build your project, even though all the code would compile and work just fine with http: ^1.0.0.
Therefore, currently the only fix is to fork the firebase_admin project, change your fork's dependency to http: '>=0.13.0 <2.0.0', then change your project to depend upon your fork. This is a pain in the butt, and leads to a lot of different projects having to fork the same project just to get their build dependencies to resolve.
What I am proposing is allowing the user to override the version requirement of any dependency of any dependency of your project. This is not what dependency_overrides currently does. Look where I wrote dependency_overrides in the yaml example I gave. Currently you can't use dependency_overrides there. I am proposing that it should be allowed, for dependency-specific transitive dependency overrides.

@devoncarew Correct, based on the current usage of dependency_overrides, which affects only the dependencies of your own project.

To be clear, is does affect the transitive dependencies. dependency_overrides can be and is used to work around the problem of a dep not updating one of it's own dependencies. dependency_overrides lets you ignore the version constraints that your pubspec + transitive deps would otherwise impose on that dep.
https://github.com/dart-lang/sdk/wiki/Flutter-Pinned-Packages#i-see-issues-through-one-of-my-dependencies-but-they-cant-immediately-release-a-new-version mentions this as a way to get around periodic issues with flutter pinned packages.

To be clear, is does affect the transitive dependencies.

Ah, OK, thank you for explaining that. I jumped to the conclusion that I couldn't override dependencies in other packages using a directive in my own package. Thanks, I'll close this!


Hmm, that's probably a bug...
Instead, please download from https://github.com/aieuo/Mineflow/releases/download/2.2.0/Mineflow_v2.2.0.phar

You can use world > Show particle action to show particles. This will only show up if your action permission is 1 or higher.

Thx

How does the time trigger work?

It may not be working at all now. I'll fix it

yeah, i tried to use it and it did nothing


Missing privacy manifest for NotificationService extension

Receiving warnings from Apple when submitting ios build for App Store Review.
ITMS-91053: Missing API declaration - Your app’s code in the “PlugIns/NotificationService.appex/NotificationService” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryUserDefaults. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.

Hey @DavidLichy thank you for reaching out and bringing this to our attention, we are reviewing this and will send out a fix for this.

@DavidLichy we looked into this, the privacy mentions using App group, we are not necessarily utilizing App Groups in the SDK. Are you certain its not any other SDK that might be causing it? or if you are utilizing App Groups in the app?

NSPrivacyAccessedAPICategoryUserDefaults

The issue from Apple was indicating the use of UserDefaults api in the NotificationService extension created by this plugin. I will look deeper to see if there are any other sdks that use the extension. Patching with the changes from this PR fixed the issue with App Store. https://github.com/tawkify/customer-mobile/pull/144

@DavidLichy we looked into this, the privacy mentions using App group, we are not necessarily utilizing App Groups in the SDK. Are you certain its not any other SDK that might be causing it? or if you are utilizing App Groups in the app?

I've removed 1C8F.1 from the manifest in the PR

@DavidLichy the only one is already added in the react native release.

@DavidLichy the only one is already added in the react native release.

We had updated to 3.6.0 with expo 50.0.17 and setup the app.json as per the expo docs. https://docs.expo.dev/guides/apple-privacy/#including-required-reasons-for-expo-sdk-packages-and-other-third-party-libraries.
It seems like there is a problem with Apple parsing the PrivacyInfo files.
As of now, Apple does not correctly parse all the PrivacyInfo files included by static CocoaPods dependencies (such as Expo SDK packages and other ecosystem libraries).
You may need to include the required reasons for the APIs used by those dependencies in your app's PrivacyInfo.xcprivacy file or the configuration in the app.json.

The only warning from App Store submission after that was the one mentioned in this issue, which had been fixed with the changes from the PR.
Maybe we need to wait for Apple or Expo to fix?

Yup, it seems like an Apple issue, and their suggestion in the link

You can usually identify the required reasons for the APIs used by other third-party libraries by checking if the library you intend to use has a PrivacyInfo.xcprivacy file in the node_modules/package_name/ios directory. If it does, you can check the NSPrivacyAccessedAPITypes and NSPrivacyAccessedAPITypeReasons values in that file and copy those values to your configuration.

suggest expo users will need to add these permission manually, until Apple fixes it.
I am going to close this issue, but feel free to reopen another one. We are going to update the docs to reflect this as well. Thank you for your assistance and help in this.


feature: set feelimit percentage in settings

You can set "The fee limit expressed as a percentage of the payment amount" in the lnd api.
https://api.lightning.community/#feelimit
this could be an option in settings. basically the same thing as @chitowncrispy did in this pr: https://github.com/LN-Zap/zap-iOS/pull/274
idk what limits we should let the user choose. maybe:

none
1%
3%
5%
10%

any thoughts @JimmyMow ?

I've implemented this on Android: https://github.com/LN-Zap/zap-android/pull/122
So currently for payments below 100 sats this fee limits are ignored. (limit for them is 100%)
The default limit for payments above 100 sats is at 3%.
Do you think those values are okayish? Or would you go for other ones?
@ottosuess @JimmyMow

@maraph when do you show the alert in the android app? when queryRoute returns a fee higher than the % limit?
let's say the route returned by queryRoute is below the fee limit, but fails. and an other route with a fee above the fee limit is chosen. do we get an alert or does it just silently fail?

@ottosuess Yes, if the possible fee will be higher than the limit, we show the alert.
To the second questions right: If we set the limit and LND doesn't find a route within the fee limit, the payment will fail with "no path to destination".


x/mobile: gomobile bind is failing with latest version [+cafc553] of gomobile

What version of Go are you using (go version)?

$ go version: go1.12.4 linux/amd64

$ go mobile version:
gomobile version +cafc553 Mon Aug 26 17:01:11 2019 +0000 (android); androidSDK=/home/--/Android/Sdk/platforms/android-28

Does this issue reproduce with the latest release?
Yes, the issue is produced only on the latest gomobile version.

Trying to generate the java  binding for my go file:
Error:

gomobile bind -o ~/test.aar -target=android -androidapi=23 test || exit 1
gomobile: $GOPATH/bin/gobind -lang=go,java -outdir=/tmp/gomobile-work-628614164 test failed: exit status 1
2019/08/27 09:51:37 go [list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags  -- test]: exit status 2: # runtime/cgo
gcc_android.c:6:25: fatal error: android/log.h: No such file or directory
compilation terminated.

What did you see instead?
Error in generating the java binding.
Note: Before updating the gomobile same code was building.

Hello @hajimehoshi ,
Yesterday your patch got merged:
https://github.com/golang/mobile/commit/cafc553e1ac52dc290ac711ed9b891bb4fcc1b4c
Before that,  gomobile bind was working.
Can you please please let me know, what update I have to make to gobind command ?

Hi,
I'm not sure your question, but my last patch should fix some bugs and gobind should work (as long as go module is not used).

Could you try gomobile with GO111MODULE=off?

@hajimehoshi ,
Now, I removed the gomobile and gobind from my system completely. (src and bin folder)
Now, I tried freshly to do:
go get golang.org/x/mobile/cmd/gomobile
But following error is coming:

package golang.org/x/mobile/cmd/gomobile: cannot find package "golang.org/x/mobile/cmd/gomobile" in any of:
/usr/local/go/src/golang.org/x/mobile/cmd/gomobile (from $GOROOT)
/home/jay/go/src/golang.org/x/mobile/cmd/gomobile (from $GOPATH)

Any idea ?

@jay11ca39  You can try the following order, to see if that helps (still GO111MODULE=off):
go get golang.org/x/mobile/cmd/gobind
go get golang.org/x/mobile/cmd/gomobile
gomobile init

@torbenschinke
Thanks for your reply..
I tried the suggested way, but it is also giving the same error:
go get golang.org/x/mobile/cmd/gobind

package golang.org/x/mobile/cmd/gobind: cannot find package "golang.org/x/mobile/cmd/gobind" in any of:
/usr/local/go/src/golang.org/x/mobile/cmd/gobind (from $GOROOT)
/home/jay/go/src/golang.org/x/mobile/cmd/gobind (from $GOPATH)

I have one basic query regarding: GO111MODULE=off
How to make sure it is off ?
Is it a flag we have to give while doing go get ?
For example:

GO111MODULE=off go get golang.org/x/mobile/cmd/gobind

Is it a flag we have to give while doing go get ?

It is safe to give GO111MODULE=off explicitly when go-getting gomobile/gobind. My guess is that you did go-get with modules. Then try:
GO111MODULE=off go get golang.org/x/mobile/cmd/gobind
GO111MODULE=off go get golang.org/x/mobile/cmd/gomobile
gomobile init

I am using gomobile for couple of months.. I used to give:
go get golang.org/x/mobile/cmd/gomobile
go get golang.org/x/mobile/cmd/gobind

As you see above commands, I  do not have use GO111MODULE flag.
But today when I am tried it is failing I am not sure what is the cause..
This issue is raised for gobind on latest gomobile version.
but now it became go get issue. :(

I have the same issue, running inside a docker (debian:stretch-slim).
If it would be of any help, you can try it out here: https://hub.docker.com/r/blixtwallet/blixtwallet/
This is the Dockerfile: https://github.com/hsjoberg/blixt-wallet/blob/35a904cf1f9c6a5da74ecdd4e09dbf5ee6fae24b/Dockerfile

We're having the same issue (gcc_android.c:6:25: fatal error: android/log.h: No such file or directory) @jay11ca39 initially reported. I can also confirm the problem started once cafc553e1ac52dc290ac711ed9b891bb4fcc1b4c was merged. If I revert that commit, all is well

I can also confirm the problem started once golang/mobile@cafc553 was merged.

I was wondering if the previous commit https://github.com/golang/mobile/commit/30c70e3810e97d051f18b66d59ae242540c0c391 worked on your environment.

I could not reproduce the issue. The latest gomobile worked on my MacBook Pro:
$ gomobile version
gomobile version +cafc553 Mon Aug 26 17:01:11 2019 +0000 (android,ios); androidSDK=/Users/hajimehoshi/Library/Android/sdk/platforms/android-28

Hello @rayvbr ,
How did you revert to the old commit ?
Are you building gomobile from source, I mean cloning and building or
Is there is any option in go get to take a specific version ?
cc @hajimehoshi

@jay11ca39
You can use any version of gomobile by using git:
cd $GOPATH/go/src/golang.org/x/mobile
git checkout [version]
go install ./cmd/...

I had the same issue.
After reverting back to 30c70e3810e97d051f18b66d59ae242540c0c391 everything works again.

OK I think I found the solution: could you try
go get -u golang.org/x/tools

? https://go-review.googlesource.com/c/tools/+/190339 should be the necessary change.

OK I think I found the solution: could you try
go get -u golang.org/x/tools

? https://go-review.googlesource.com/c/tools/+/190339 should be the necessary change.

I tried this (with modules enabled and disabled) but that doesn't seem to work.

Updating all tools with go get -u golang.org/x/tools/... also doesn't help.

I can confirm, that reverting back to 30c70... also worked for us

Thanks. It looks like this happens when the default driver is not used. I am not familiar with drivers...
@HeavyHorst do you have gopackagesdriver command in $PATH?
@matloob If an external driver in go/packages is used, the fix https://go-review.googlesource.com/c/mobile/+/190479 is not applied. Is my understanding correct? I was wondering if there is a workaround.
CC @hyangah

@HeavyHorst do you have gopackagesdriver command in $PATH, or did you specify $GOPACKAGESDRIVER?

No, neither one nor the other.

Hmm, thanks.

Updating all tools with go get -u golang.org/x/tools/... also doesn't help.

Could you tell me the Git hash of $GOPATH/src/golang.org/x/tools? If you did go get with enabling Go modules, this might not be updated.

Thanks for investigating.
The hash is: b29f5f60c37a1dd56e6942c2717b85b976e4a592
Let me know if you need anything else.

@HeavyHorst
Thanks! Could you try
cd $GOPATH/src/golang.org/x/mobile
GOPACKAGESDRIVER=off GO111MODULE=off go test -v -run=TestGobind/Go-Cgopkg -count=1 ./cmd/gobind

and tell me the result?

GOPACKAGESDRIVER=off GO111MODULE=off go test -v -run=TestGobind/Go-Cgopkg -count=1 ./cmd/gobind
=== RUN   TestGobind
=== RUN   TestGobind/Go-Cgopkg
--- FAIL: TestGobind (0.28s)
    --- FAIL: TestGobind/Go-Cgopkg (0.28s)
        gobind_test.go:82: gobind -lang go,java,objc golang.org/x/mobile/bind/testdata/cgopkg failed: exit status 1: 2019/08/28 12:52:09 go [list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags  -- golang.org/x/mobile/bind/testdata/cgopkg]: exit status 2: # runtime/cgo
            gcc_android.c:6:10: schwerwiegender Fehler: android/log.h: No such file or directory
                6 | #include <android/log.h>
                  |          ^~~~~~~~~~~~~~~
            Kompilierung beendet.

FAIL
FAIL    golang.org/x/mobile/cmd/gobind  0.791s

Not sure if that helps but when i readd this line: Env: append(os.Environ(), "CGO_ENABLED=0"),
to cmd/gobind/main.go everything works again.

https://github.com/golang/tools/blob/b29f5f60c37a1dd56e6942c2717b85b976e4a592/go/packages/golist.go#L889-L891
I guess this condition is suspicious: the error message might not be exactly 2 lines. Probably the stderr gobind -lang go,java,objc golang.org/x/mobile/bind/testdata/cgopkg > /dev/null has 4 lines in your environment.

Not sure if that helps but when i readd this line: Env: append(os.Environ(), "CGO_ENABLED=0"),
to cmd/gobind/main.go everything works again.

Thanks! Thought this suppresses the error, I don't think this is a correct fix since go/packages would miss some files for Cgo.

Hm, I don't see any error if I run go list directly in the terminal:
 rkaufmann  rkaufmann  ~  %  GOPACKAGESDRIVER=off GO111MODULE=off GOOS=android go list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags -- golang.org/x/mobile/bind/testdata/cgopkg > /dev/null
 rkaufmann  rkaufmann  ~  % 

GOPACKAGESDRIVER=off GO111MODULE=off go test -v -run=TestGobind/Go-Cgopkg -count=1 ./cmd/gobind
=== RUN   TestGobind
=== RUN   TestGobind/Go-Cgopkg
--- FAIL: TestGobind (0.27s)
    --- FAIL: TestGobind/Go-Cgopkg (0.27s)
        gobind_test.go:82: gobind -lang go,java,objc golang.org/x/mobile/bind/testdata/cgopkg failed: exit status 1: 2019/08/28 13:37:31 go [list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags  -- golang.org/x/mobile/bind/testdata/cgopkg]: exit status 2: # runtime/cgo
            gcc_android.c:6:10: schwerwiegender Fehler: android/log.h: No such file or directory
                6 | #include <android/log.h>
                  |          ^~~~~~~~~~~~~~~
            Kompilierung beendet.

FAIL
FAIL    golang.org/x/mobile/cmd/gobind  0.748s
FAIL

Sry, I had to enable cgo with export CGO_ENABLED=1.
After that go list prints this error:
# runtime/cgo
gcc_android.c:6:10: schwerwiegender Fehler: android/log.h: No such file or directory
    6 | #include <android/log.h>
      |          ^~~~~~~~~~~~~~~
Kompilierung beendet.

@HeavyHorst Thank you for confirming! I think that's the cause and we should fix go/packages.
@matloob :
As we discussed here, there are two problems:

(https://github.com/golang/go/issues/33859#issuecomment-525697213) If go-list's error message doesn't have exactly 2 lines like above, go/packages cannot ignore the Cgo error message. I'm not sure we could remove this checking of line numbers simply.
(https://github.com/golang/go/issues/33859#issuecomment-525677675) An external gopackagesdriver is specified, Cgo message can also be ignored, but I don't think this is a critical issue.

What do you think?

Just to confirm:
 rkaufmann  rkaufmann  ~  go  …  golang.org  x  mobile  master  ERROR  %  GOPACKAGESDRIVER=off GO111MODULE=off go test -v -run=TestGobind/Go-Cgopkg -count=1 ./cmd/gobind                                                                                :(
=== RUN   TestGobind
=== RUN   TestGobind/Go-Cgopkg
--- FAIL: TestGobind (0.28s)
    --- FAIL: TestGobind/Go-Cgopkg (0.28s)
        gobind_test.go:82: gobind -lang go,java,objc golang.org/x/mobile/bind/testdata/cgopkg failed: exit status 1: 2019/08/28 14:09:52 go [list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags  -- golang.org/x/mobile/bind/testdata/cgopkg]: exit status 2: # runtime/cgo
            gcc_android.c:6:10: schwerwiegender Fehler: android/log.h: No such file or directory
                6 | #include <android/log.h>
                  |          ^~~~~~~~~~~~~~~
            Kompilierung beendet.

FAIL
FAIL    golang.org/x/mobile/cmd/gobind  0.729s
FAIL

I then removed strings.Count(stderr.String(), "\n") == 2 from /home/rkaufmann/go/src/golang.org/x/tools/go/packages and everything seem to work afterwards
 rkaufmann  rkaufmann  ~  go  …  golang.org  x  mobile  master  ERROR  %  GOPACKAGESDRIVER=off GO111MODULE=off go test -v -run=TestGobind/Go-Cgopkg -count=1 ./cmd/gobind                                                                                :(
=== RUN   TestGobind
=== RUN   TestGobind/Go-Cgopkg
--- PASS: TestGobind (1.68s)
    --- PASS: TestGobind/Go-Cgopkg (1.68s)
PASS
ok      golang.org/x/mobile/cmd/gobind  2.143s

I am getting this problem
gcc_android.c:6:10: fatal error: 'android/log.h' file not found
and from the above am not clear what I have to do to fix it
gomobile version +d9e324c Sat Nov 23 05:49:42 2019 +0000 (android); androidSDK=/Users/davidsteed/Library/Android/sdk/platforms/android-28

XXXX-Mac:~ XXXXhi$ go get golang.org/x/mobile/cmd/gobind
go: finding golang.org/x/mobile latest
XXXX-Mac:~ XXXXhi$ go get golang.org/x/mobile/cmd/gomobile
go: finding golang.org/x/mobile latest
XXXX-Mac:~ XXXXhi$ gomobile init
gomobile: /usr/local/go/bin/go install golang.org/x/mobile/cmd/gobind failed: exit status 1
go/src/golang.org/x/mobile/internal/importers/ast.go:37:2: cannot find package "golang.org/x/tools/go/packages" in any of:
	/usr/local/go/src/golang.org/x/tools/go/packages (from $GOROOT)
	/Users/XXXXhi/go/src/golang.org/x/tools/go/packages (from $GOPATH)

@stonedreamforest  try this
   go get -u golang.org/x/tools/...


Vending machine storage - #5071

About the PR
fixes issue #5071
This PR:
Adds ability to insert items into vending machines that have a whitelist
Why isn't this a separate type?:
A functionality of ss13 was the ability for the chef and bartender to insert drinks into vending machines of that specific type and since this was along the same lines I wanted to ensure that functionality would be possible.
Screenshots

Changelog

:cl:

add: Smart fridges now properly store pills, bottles, and produce, food and drink can be added to some vending machines

Additionally, based on your posted gifs. The items placed in the 'Smart Fridge' should stack.
I also agree with @metalgearsloth, this is no longer a vending machine at this point and should really have its own component.


Feature/demo app icon images

Solved bug where images are not displayed in the demo app - in some cases.
Updated manifest information for the DemoApp.

Current coverage is 72.01% (diff: 100%)

Merging #4 into master will not change coverage

@@             master         #4   diff @@
==========================================
  Files            16         16
  Lines           411        411
  Methods           0          0
  Messages          0          0
  Branches         62         62
==========================================
  Hits            296        296
  Misses          103        103
  Partials         12         12

Powered by Codecov. Last update 4e3fbd5...37b8cd4


Tab order with containers

I found out that if I have something like
<TextBox>
  <Grid>
    <TextBox>
  </Grid>
<TextBox />

then nested TextBox will be skipped when tabbing through controls
it helps if I set Grid.Focusable=true but then focus will go first to grid and only then to nested TextBox
Focusable shouldn't affect nested controls I think.

I think this was fixed a while ago. Please re-open if that's not the case.


Error: ThunkComposer() returns empty value: undefined with Graphback Alpa release 0.14.0-dev2

Starting a server with this model file https://github.com/aerogear/OpenVolunteerPlatform/blob/chore/update-graphback/platform/model/main.graphql and graphback v0.14.0-dev2 I am getting an error below
Error: ThunkComposer() returns empty value: undefined
    at ThunkComposer.get ofType [as ofType] (/Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/ThunkComposer.js:24:13)
    at getTypeNode (/Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/utils/definitionNode.js:250:28)
    at /Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/utils/definitionNode.js:323:18
    at Array.map (<anonymous>)
    at getInputValueDefinitionNodes (/Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/utils/definitionNode.js:321:21)
    at getInputObjectTypeDefinitionNode (/Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/utils/definitionNode.js:55:13)
    at InputTypeComposer.getType (/Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/InputTypeComposer.js:412:81)
    at NonNullComposer.getType (/Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/NonNullComposer.js:27:52)
    at /Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/ObjectTypeComposer.js:322:23
    at /Users/machi/Projects/aerogear/OpenVolunteerPlatform/platform/node_modules/graphql-compose/lib/utils/misc.js:134:19

The error is reproducible using this OVP's branch https://github.com/aerogear/OpenVolunteerPlatform/tree/chore/update-graphback

/cc @wtrocki

That is issue with generating some specific input type for the object. We need to selectively remove objects from schema to see what is failing.
Generally if could be one of the relationships we have there

Yeap.
I planned to dig deeper today with a simple model below:
"""
@model
"""
type  Issue {
  id: ID!
  name: IssueType
}

enum IssueType {
 BUG
 QUESTION
 FEATURE_REQUEST
}

From my understand the issue came here https://github.com/aerogear/graphback/blob/master/packages/graphback-core/src/crud/mappingHelpers.ts#L159 since we do not check for enum values thus returning undefined always for enum types.

Also judging from https://github.com/aerogear/graphback/blob/master/packages/graphback-codegen-schema/src/definitions/schemaDefinitions.ts#L148 it seems like the Filter input types lacks support for enum types, which I think it is something we'll like to do. This logic is not always the case e.g here https://github.com/aerogear/graphback/blob/master/packages/graphback-codegen-schema/src/definitions/schemaDefinitions.ts#L178 where the outstanding type of an enum field is undefined as observed in (1) above.

@machi1990 world class job. If you already done some investigation maybe you want to fix this with some help from team?
I think we should have quick win if we map enums to strings as we do with other scalars.

@wtrocki great. I have opened #1306.


Add SetProfile Activity for external use

First of all great thanks to you @saiho for the great app.
I don't know if you find this useful and if the code style fits your needs. But in the case you or someone else finds this useful I've decided to create this PR.
This api.SetProfile activity can be triggered from external app (e.g. Tasker).
Issues #6 (@bbbco) and #7 (@landry314) can then be circumvented by using the activity directly from Tasker and create a widget using this Task in an external widget supporting activites.
So it is possible to change LineageOS profiles programmatically without the need to have a rooted device.
The activity needs to be used as follows:
intent:
android.intent.action.MAIN
package name:
com.saiho.togglelineageprofiles
class name:
com.saiho.togglelineageprofiles.api.SetProfile
extra:
string com.saiho.togglelineageprofiles.api.profileName
It's tested with LOS 18.1 and 19.1 with E-Robot.

Thanks a lot, your contribution is appreciated. I will merge your changes.
I am just preparing a new version. I was just cleaning the code by removing support for the old Cyanogenmod. When ready, your changes can be part of the new release. However, I will not be able to properly test them because I do not use Tasker. I hope you can provide some feedback.

@Blacky-Toggle, can you please clarify the Tasker intent format please? Does the following look right?
   Task: Test Task     A1: Send Intent [          Action: android.intent.action.MAIN          Cat: None          Extra: com.saiho.togglelineageprofiles.api.wifidisconnect          Package: com.saiho.togglelineageprofiles.api          Class: com.saiho.togglelineageprofiles.api.SetProfile          Target: Activity ]

@Blacky-Toggle, can you please clarify the Tasker intent format please? Here's my latest attempt: Task: Test Task A1: Send Intent [ Action: android.intent.action.MAIN Cat: None Extra: com.saiho.togglelineageprofiles.api.wifidisconnect Package: com.saiho.togglelineageprofiles.api Class: com.saiho.togglelineageprofiles.api.SetProfile Target: Activity ]

@nickelnine, try this:
Task: Test Task
A1: Send Intent [
Action: android.intent.action.MAIN
Cat: None (may try some other value)
Extra: com.saiho.togglelineageprofiles.api.profileName:wifidisconnect
Package: com.saiho.togglelineageprofiles.api
Class: com.saiho.togglelineageprofiles.api.SetProfile
Target: Activity ]
Take a look at Tasker Intents documentation here.


Optimize iic and spi parts and add iic slave drivers

Summary
Optimize iic and spi parts and add iic slave drivers
Impact
iic and spi driver
Testing
iic and spi driver

@Zhangshoukui nice work!! Kudos!!!
Could you please include a Documentation to I2C Slave at https://nuttx.apache.org/docs/latest/components/drivers/special/index.html at I2C Drivers. The existing documentation is "non-existent", since you are working on it, please help us to improve it.

@Zhangshoukui nice work!! Kudos!!!
Could you please include a Documentation to I2C Slave at https://nuttx.apache.org/docs/latest/components/drivers/special/index.html at I2C Drivers. The existing documentation is "non-existent", since you are working on it, please help us to improve it.

I updated the submission to add documentation

@acassis I updated the submission to add documentation


refactor: respect Loaded type in EntityDTO

Closes #2414

@JanJakes could you take a look at this please? I managed to adjust the Loaded type so it is respected in EntityDTO (better say in the methods that return it, so toObject() etc), but now the Loaded<T> is no longer assignable to T when T is generic (it works fine with non-generic types).
This problem in the codebase is workaroundable via type casting, user facing code (tests) are type checked correctly, so I guess it is good enough, but it you could find a better way, I am all ears.


fix: enable rosetta2

Enable rosetta2 to install some tools on M1 Mac.

suzuki-shunsuke/akoi
suzuki-shunsuke/ci-info
suzuki-shunsuke/circleci-config-merge
suzuki-shunsuke/cmdx
suzuki-shunsuke/dd-time
suzuki-shunsuke/durl
suzuki-shunsuke/git-rm-branch
suzuki-shunsuke/github-comment
suzuki-shunsuke/matchfile

Oh, I misunderstood.
Architecture is hardcoded, so there is no problem.


[docs] Fix typos in Table API documentation

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Good catches @wuchong!
+1 to merge

Merging


Allow number of settings per H2 session to be configurable

(cherry picked from commit d91a8ca17bb17b08ce7f040b868e3c286a7bb0a6)
Conflicts:
doc/admin-guide/files/records.config.en.rst
mgmt/RecordsConfig.cc
proxy/http2/HTTP2.cc
proxy/http2/HTTP2.h
proxy/http2/Http2ConnectionState.h

[approve ci autest]

[approve ci ubuntu]

We can ignore these two failed builds, for now.

This went into the 8.0.4 release.


[Bug]: Experimental Agents broken with custom endpoints

What happened?
Note: This is only tested with OpenRouter, this may not apply to other custom endpoints. Unfortunately I do not have the resources to try with something else.
When choosing a custom endpoint in the agent creation menu, and then choosing a model (any model from what I found), exiting out will lead to this error.
Unexpected Application Error!
n.toLowerCase is not a function
i_@https://mydomain.example/assets/index.DOfEXLPm.js:3128:22877
A7@https://mydomain.example/assets/vendor.BujiSg_e.js:38:19557
Qee@https://mydomain.example/assets/vendor.BujiSg_e.js:40:44171
zee@https://mydomain.example/assets/vendor.BujiSg_e.js:40:39879
pSe@https://mydomain.example/assets/vendor.BujiSg_e.js:40:39802
v2@https://mydomain.example/assets/vendor.BujiSg_e.js:40:39648
j$@https://mydomain.example/assets/vendor.BujiSg_e.js:40:36004
iB@https://mydomain.example/assets/vendor.BujiSg_e.js:40:36809
Kf@https://mydomain.example/assets/vendor.BujiSg_e.js:38:3288
Vo/<@https://mydomain.example/assets/vendor.BujiSg_e.js:40:34324

I have no concrete theory as to what is causing this. But I assume something on the front end is passing a broken input to the chatCompletion function at api/server/controllers/agents/client.js since the error appears in the logs.
Again, this theory is mostly baseless. I unfortunately do not have the time to go more in depth, as I wish to rewatch The Orville at this moment, not make another issue.
Steps to Reproduce

Create a custom endpoint (for me, OpenRouter)
Under the Model option, choose the custom endpoint provider
Set the actual model to anything, not sure it matters
Click the back arrow to return to the previous screen
Error will appear

What browsers are you seeing the problem on?
No response
Relevant log output
2024-10-02T02:03:46.493Z debug: [api/server/controllers/agents/client.js] chatCompletion
{
  baseURL: undefined,
  // 1 payload(s)
  payload: [{"role":"user","content":"\nUnexpected Application Error!\nn.toLowerCase is not a<EMAIL_ADDRESS>[truncated]],
}

Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I also didn't see this when I first made the issue, but someone on the discord is also experiencing the issue.
So it's not an isolated incident with my f*cked up config at least.

I will confirm that I had the issue. I use custom and litellm as a backend.


docs(openid-connect): docs improvements

Description
Improved readibility, clarified a few details in the plugin's description and configuration fields.
Fixed a broken link.
Checklist

[X] Review label added
[X] PR pointed to correct branch (all changes apply to the current version of the plugin, can be merged in main)

KAG-402

This is a PR that is part of the 3.2 sprint but can be merged into main.

thanks @Guaris , I applied the suggestions


Render Markdown of JSDoc

From @waderyan on November 11, 2016 22:34
From @mohsen1 on November 7, 2016 18:37

VSCode Version: 1.7.1
OS Version: macOS

I'm expecting
/**
 * This is foo
 * Foo is great! Use it like this:
 *
 * ```ts
 * const foo = new Foo();
 * ```
 */
function Foo() {

}

var f = new Fo

I was expecting my Markdown to be rendered here:

Copied from original issue: Microsoft/vscode#15117
Copied from original issue: Microsoft/TypeScript#12185

From @Emeryao on November 10, 2016 6:32
the code above works fine and the jsdoc displayed as markdown in a .ts file on insiders build :
Version 1.8.0-insider
Commit ce6d57875ab53309204cf12dc54d74956221cfc1
Date 2016-11-09T08:48:03.700Z
Shell 1.3.8
Renderer 52.0.2743.82
Node 6.5.0
OS Windows 10 14393.447

From @DanielRosenwasser on November 11, 2016 23:23
Given that VS Code already does custom styling for quick info, and renders other markdown within it, I don't think that this should be an issue on TS.

I am seeing the issue.

This is a good feature request.

From @mhegazy on November 14, 2016 21:49
We do return the text of the comment. @dbaeumer if you can spot the problem with the output we can trace it from there and fix it.

@dbaeumer is this something that should be done on the VS Code side? I will move the issue back if so.

From @dbaeumer on November 15, 2016 1:35
There are two different issue here:

the one rendering it as markdown in the editor. This is a grammar problem which is owned by TS.
the one in the hover / code complete is a Code issue. To fix we need to create a marked String by parsing the strings we get from the TS server.

From @mhegazy on December 15, 2016 20:39
For the first issue, TM grammar issues are tracked under https://github.com/Microsoft/TypeScript-tmlanguage, for the second, it should be tracked by a VSCode issue.

Will do. Thanks!

From @mhegazy on December 15, 2016 20:39
closing for now. @waderyan we need to port this back to VSCode.

Closing as a duplicate of #1920


Support for gzipped fasta files throughout workflow

Description of proposed changes

Upload and delta change scripts understand .gz files.  Checksums are still performed on uncompressed data.  This works out well, because we compress at most once, and uncompressing is cheap.
bin/transform-gisaid will inspect the input to see if it's gzipped.  If so, it unzips it.
bin/transform-gisaid will use the output filename to decide whether or not to compress it on the fly.

Testing
Launched a build where we keep most files compressed.  We had an earlier version of the workflow without the nextclade integration, but when rebased, it'll likely be problematic.  However, this workflow can still operate on uncompressed data, so it is backwards compatible.

Thanks, @ttung! Is this working well for you folks in your own ingests? Did you notice a meaningful time increase due to compression?
Background for the rest of the team/posterity: Tony's change was born out of disk-space issues on GitHub Actions. The Nextstrain team has since moved our ingest to run on AWS Batch (via nextstrain build infrastructure) after being triggered by GitHub Actions.
On AWS Batch we're not meaningfully constrained on disk anymore, so I'm not sure trade of disk usage for CPU/wall clock time that compression makes is worth it? That said, this PR doesn't require use of compression, just adds support for it, so we could still accept the PR but not make the compression trade.

Thanks, @ttung! Is this working well for you folks in your own ingests? Did you notice a meaningful time increase due to compression?
Background for the rest of the team/posterity: Tony's change was born out of disk-space issues on GitHub Actions. The Nextstrain team has since moved our ingest to run on AWS Batch (via nextstrain build infrastructure) after being triggered by GitHub Actions.
On AWS Batch we're not meaningfully constrained on disk anymore, so I'm not sure trade of disk usage for CPU/wall clock time that compression makes is worth it? That said, this PR doesn't require use of compression, just adds support for it, so we could still accept the PR but not make the compression trade.

It's not meaningfully different because we are compressing during upload-to-s3 anyway.  Decompressing the .gz file takes ~4s on my laptop.
Yes, this does not require you to use compression.

It's not meaningfully different because we are compressing during upload-to-s3 anyway.  Decompressing the .gz file takes ~4s on my laptop.
Yes, this does not require you to use compression.

@WandrilleD Do you see any reason why this shouldn't be merged?


iOS free trial Promotion offer is not Applying.

Version of react-native-iap
4.4.9
Version of react-native
react-native-cli: 2.0.1
react-native: 0.62.2
Platforms you faced the error (IOS or Android or both?)
iOS
App target version is iOS 12.2 and up
Expected behavior
In my subscription is indicating that a free trial is available.  however when the user is going  to buy the product, the Apple-controlled screen indicates no free trial, instead they are signing up for the subscription right away without trial period.
My Product object
{
"productId": "xxx",
"subscriptionPeriodUnitIOS": "MONTH",
"description": "Upgrade to Family HQ Basic features",
"introductoryPrice": "",
"title": "Basic Features",
"introductoryPriceSubscriptionPeriodIOS": "",
"introductoryPriceNumberOfPeriodsIOS": "",
"discounts": [
{
"localizedPrice": "$0.00",
"numberOfPeriods": "2",
"type": "SUBSCRIPTION",
"identifier": "xxx-xx",
"paymentMode": "FREETRIAL",
"price": "0",
"subscriptionPeriod": "WEEK"
}
],
"type": "Do not use this. It returned sub only before",
"localizedPrice": "$0.99",
"introductoryPricePaymentModeIOS": "",
"price": "0.99",
"currency": "AUD",
"subscriptionPeriodNumberIOS": "1"
}
Actual behavior
Purchase amount should be deducted after the trial period (14 days).
Tested environment (Emulator? Real Device?)
Real Device

I think we need a contributor for testing this out and enhancing reliability.

hi, any idea if this has been fixed? or any workarounds?
thanks.

hi, i got the same problem and would be interested in any solutions too. Thanks!

If it's on the Apple-controlled screen, then there is a configuration problem with your in-app purchases. iOS doesn't provide developers with a mechanism for controlling whether a user can or should start a free trial or not, it's all handled by the App Store.

thanks a lot, we contacted our customer and this was exactly the problem 🙈


azure-functions-core-tools: 4.0.5455 -> 4.0.5700

close: #302640
Description of changes
Diff: https://github.com/Azure/azure-functions-core-tools/compare/refs/tags/4.0.5455...4.0.5700
Changelog: https://github.com/Azure/azure-functions-core-tools/releases/tag/4.0.5700
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

 Then it could also close https://github.com/NixOS/nixpkgs/issues/364653


[feature] add ability to create new service if it doesn't exist

The requirement to have the ECS service running before using the plugin brings a couple of problems, specifically the duplication of configuration across drone and the initial creator application. It would be helpful if the plugin had the ability to create the service if it doesn't exist on the cluster, so the plugin can be used for the full service lifecycle.

Yesss! I find this requirement to be peculiar.

Sounds like it would be a nice addition :) If anyone wants to PR a change for that I'll totally merge it in. Otherwise I'll take a look when I get a chance but probably won't be super soon.


Mention "return type" in the error message when return type of a function is not matching the declared type

Suggestion

🔍 Search Terms
return type, error message
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Mention "return type" when return type of a function is not matching the declared type
When a parameter type is not matching the declared type, the error message has the words "parameter X" in it which makes it super easy to spot the error. For return types it only says type X is not compatible with type Y but is not clear that it is the return type
📃 Motivating Example
Playground
const func: (a: string, very: number, confusing: string, error: boolean, message: string) => string =
    (a: string, very: number, confusing: string, error: boolean, message: string) => {
        return 1
    }

Error:
Type '(a: string, very: number, confusing: string, error: boolean, message: string) => number' is not assignable to type '(a: string, very: number, confusing: string, error: boolean, message: string) => string'.
  Type 'number' is not assignable to type 'string'.(2322)

💻 Use Cases
This can get tricky in very large and complex types. Just mentioning the word "return" can save a ton of time debugging issues

If someone wants a good project, I think any time we have
X is not assignable to Y
  A is not assignable to B

there's a "missing" elaboration:
X is not assignable to Y
  (Some explanatory text of why we're talking about A and B)
    A is not assignable to B

This is interesting, a little investigation and the Diagnostics @bakkot mentions were suppressed in #33473
Removing the "elidedInCompatabilityPyramid": true attribute gives a more readable message and doesn't cause the long pyramid on the example in #33361
I feel like these 4 messages could be flattened into one simpler message
"Call signature return types '{0}' and '{1}' are incompatible.": {
        "category": "Error",
        "code": 2202,
        "elidedInCompatabilityPyramid": true
    },
    "Construct signature return types '{0}' and '{1}' are incompatible.": {
        "category": "Error",
        "code": 2203,
        "elidedInCompatabilityPyramid": true
    },
    "Call signatures with no arguments have incompatible return types '{0}' and '{1}'.": {
        "category": "Error",
        "code": 2204,
        "elidedInCompatabilityPyramid": true
    },
    "Construct signatures with no arguments have incompatible return types '{0}' and '{1}'.": {
        "category": "Error",
        "code": 2205,
        "elidedInCompatabilityPyramid": true
    },

especially as the with no arguments variants are already merged in the checker...
  if (msg.code === Diagnostics.Call_signatures_with_no_arguments_have_incompatible_return_types_0_and_1.code) {
                                mappedMsg = Diagnostics.Call_signature_return_types_0_and_1_are_incompatible;
                            }
                            else if (msg.code === Diagnostics.Construct_signatures_with_no_arguments_have_incompatible_return_types_0_and_1.code) {
                                mappedMsg = Diagnostics.Construct_signature_return_types_0_and_1_are_incompatible;
                            }

Also there is another related diagnostic
    "The expected type comes from the return type of this signature.": {
        "category": "Message",
        "code": 6502
    },

That seems to trigger with an implicit return, but not with explicit return or if redefining the type on the args
Playground example


Embedded expressions silently ignore any exceptions thrown from called Java code

First of all thanks for creating the Karate framework, I really like it!
But I ran into the following: if you have some json that contains an embedded expression, and that expression (either directly, or indirectly through an intermediary javascript function) calls some Java method, then when that Java method throws an exception (either checked or unchecked), the embedded expression just silently ignores that exception, and just leaves the embedded expression 'unexpanded'.
Example:
* def Exceptions = Java.type('examples.Exceptions')
* def dummy = { key: "#(Exceptions.alwaysUnchecked())" }
* print dummy
, where examples.Exceptions.alwaysUnchecked() is a method that always throws an unchecked exception (for instance an IllegalArgumentException), then instead of the scenario containing this snippet being aborted, it just prints
{
"key": "#(Exceptions.alwaysUnchecked())"
}
without anything hinting at the exception having occurred. The same thing happens when the method throws a checked exception, say an IOException. Only when the method doesn't throw an Exception, but some subclass of Error, does karate properly abort the scenario and show that the Error occurred !
Note: calling the method directly like
* def dummy = Exceptions.alwaysUnchecked()
or even
# using  'enclosed javascript'
* def dummy = ( { key: Exceptions.alwaysUnchecked() } )
will also properly abort the scenario.
I've attached a minimal Maven project that demonstrates the issue. It can be run simply with "mvn clean test".
embedded-expressions-issue.zip

@florimon yes, for some reason I decided to swallow this exception in the early days - and after some iteration even set the log-level to trace: https://github.com/intuit/karate/blob/master/karate-core/src/main/java/com/intuit/karate/Script.java#L481
I'm not 100% sure this has to stop everything. one of the reasons (though rare) is that JSON for expected results can set up in 2-3 steps, and "lazy evaluated":
* def temp = { foo: '#(bar)' }
* print temp
* def bar = 'hello'
* def actual = { foo: 'hello' }
* match actual == temp

what do you think. so I don't consider this a priority. if an embedded expression fails where you need it not it - you would realize pretty quickly when you get into assertions or look at the log during dev

@ptrthomas
At the very least, I would expect the karate documentation to mention that this can be an issue - it is already good at pointing out "gotcha's". Next up, I would use a log level higher than 'trace' to log it, because now it goes completely unnoticed - I only became aware of it because I started seeing unresolved embedded expressions popping up in the requests being handled by the server under test.
And I think the icing on the cake would be, if there could be a karate configuration flag, something like "karate.abortOnEmbeddedExpressionFailure" so anyone could choose for themselves how they'd wanted exceptions to be handled. Or an other alternative could be, to only abort on checked exceptions, not unchecked ones ?
At the moment, the only viable workaround I see is to have my Java code throw an Error instead of an Exception, and I'm reluctant to do that since common practice is to let only the JVM itself throw Error's, not user code.

@florimon yep[, agreed :) I'm tagging this as help wanted though for now

moving this to the project board which is what we use to solicit contributions, e.g. during hacktoberfest
https://github.com/intuit/karate/projects/3#card-41316888


Introduce ImmediateExecutor

ImmediateExecutor is a helper class to be used in conjunction with
Future::Then. It allows to chain a task to be executed whenever the
future completes. The task will be executed in the execution context
that sets the result of the promise.
This type of executor should only be used for tasks that don't depend on
any outside resources since it can't be guaranteed when and where this
task is executed.

LGTM! And I am in dire need of this, so thank you!
I guess dimitry should have a look

Thanks. :laughing: I wanted to give Dimitry a break, so just to point out: Not my fault this time. :see_no_evil:

Thank you both for the reviews!


Add check constraint support

Parser changes to handle CHECK statements.

@zachmu I think this should be good now. The alter statement is still confusing, but I tried to get behavior close to the mysql docs for checks.


Add config cp and set QPS

Create a cmd which generate a config to create a clusterpool based on an existing clusterpool https://github.com/open-cluster-management/cm-cli/issues/66
Increase QPS as lots of throttling message https://github.com/open-cluster-management/cm-cli/issues/68
Signed-off-by: Dominique Vernier<EMAIL_ADDRESS>

/hold

/unhold


edits issue?

I've been running this for a few months now...
I've been getting lots of strange messages in the console... and I think it comes down to "edits" on the discord side... they are not passed through to IRC.
This is using "latest" versions of everything.
Is this a know issue? and is there a way to resolve it?
Thanks.

Hi, this is a known issue. This version of the bot relies on a broken and outdated version of discord.js. It hasn't seen updates in a while. It has errors and outright crashes depending on what happens on the Discord side.
My rewrite here has updates that should resolve your errors in the console. You'll have to edit your config.json slightly to use it if you choose. Note that I moved away from Node.js to Deno, but I offer .exe and linux binaries you can download to skip using Node.js or Deno entirely here.
Messages edits were never supported by this bot, but my rewrite supports them in the latest update with a config change in the release notes.

Excellent! thankyou for the reponse. I didn't know about this version. I'll give it a go tomorrow.
Thanks again.


To use the list jobs in list_materialization_operation

Description
Change the implementation of list_materialization_operation to jobs operation list which supported in 08-01 version
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


Unable to connect to MariaDb/MySQL

Hello there, and thank your for this interesting project!
I am looking to try out using roapi, with mariadb and getting the error below in logs.
Installation / setup is using docker compose (not swarm), on a ubuntu host machine on which mariadb is also running.
I have other applications running in my self hosted set up, and the database is working fine with the other applications with the same connection string.
Below are my docker-compose.yaml, roapi.yml and the logs I see.
Any help is greatly appreciated. TIA.
services:
  roapi:
    image: ghcr.io/roapi/roapi:latest
    container_name: roapi
    command: --config /config/roapi.yml
    environment:
      - RUST_BACKTRACE=1
    ports:
      - 8080
      - 5432
      - 32010
    volumes:
      - ./config:/config

addr:
  # binding address for TCP port that speaks HTTP protocol
  http: <IP_ADDRESS>:8000
  # binding address for TCP port that speaks Postgres wire protocol
  postgres: <IP_ADDRESS>:5432

# List All Data Sources
tables:

  - name: "testtbl"
    uri: "mysql://test:pwd1234@mariadb:3306/testtbl"

[2024-03-13T06:45:52Z INFO  roapi::context] loading `uri(mysql://test:pwd1234@mariadb:3306/testtbl)` as table `testtbl`
thread 'main' panicked at /roapi_src/roapi/src/startup.rs:63:14:
Failed to create Roapi context: Whatever { source: Some(TableError { source: Extension { msg: "unsupported extension in uri: mysql://test:pwd1234@mariadb:3306/testtbl" } }), message: "Failed to load table", backtrace: Backtrace(()) }
stack backtrace:
   0: rust_begin_unwind
             at ./rustc/20999de3a2f866a6006169c9bc188017aba79fcc/library/std/src/panicking.rs:619:5
   1: core::panicking::panic_fmt
             at ./rustc/20999de3a2f866a6006169c9bc188017aba79fcc/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at ./rustc/20999de3a2f866a6006169c9bc188017aba79fcc/library/core/src/result.rs:1652:5
   3: roapi::startup::Application::build::{{closure}}
   4: roapi::main::{{closure}}
   5: roapi::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

If anyone has got roapi working with MySql/MariaDb, any help is much appreciated.
After a few more days of attempting a clean start from the examples, I am still facing the same issue.

@accforgithubtest the official image is not built with mysql feature enabled, you will need to build your own binary with the database-mysql feature with cargo.

@houqp - thanks for your reply !
I couldn't find any docs on how this can be done (I am also not a developer, just learnt docker for self hosting purposes).
Any chances you can add some doco on how to get a new docker image built with mysql enabled ?

You can try add the database-mysql flag in https://github.com/roapi/roapi/blob/c2a3268d44faf3d7602ef19c73b8758f03e93afa/Dockerfile#L3

thanks @houqp ! will give that a try.
For my information - is there a reason why mysql is not enabled by default ? Is there a performance penalty ? or higher system requirements, etc ?


Tests

Following tasks were completed:

Wrote unit tests using Rspec.
Understood an existing codebase in a way that allows for adding tests.
Checked for and fixed linter errors

@Tayyab-Kamboh seems this is also a pair-programming project hence you're required to actively work with your partner. Commit messages should be seen from both partners.


transitions() doesn't return events that use a wildcard in the "from" property

Been messing with the FSM (thanks btw, tons of headache avoided b/c of this) and tried using the wildcard feature. Unfortunately, when I call "transitions()" is doesn't return those events with it.
But, I have a fix in mind that I'm using to hold me over.
I simply changed the definition of the transitions function by combining the transitions of the current node with that of the wildcard.
fsm.transitions = function()      { return transitions[this.current].concat(transitions[StateMachine.WILDCARD]); };
It works for now, but I will continue to test and update if I notice any glaring issues with this.

Fixed - PR merged (and unit tests fixed/added) for the (upcoming) v2.4 release.
Thanks!