Digit grouping symbol to match system setting

Summary

I want it to be possible to change the digit grouping symbol from comma to space. (see screenshot)
Motivation

I learned that comma is technically the wrong symbol to use for digit grouping. It should always be a space. Fortunately, Windows and macOS have the option to change it, but it can't do much outside the OS's built-in apps (like Calculator).
All we need is probably for Atom to change the digit grouping symbol according to the computer's language and region settings.
Describe alternatives you've considered

It could also be possible to manually change the digit grouping symbol, decimal symbol, and digit grouping manner.
Digit grouping and decimal symbol could be a text field where the user enters a single character to use as the respective symbol. In my case, I would insert   (whitespace) into the digit grouping symbol field and leave the decimal symbol field as default. (assuming it's .)
Digit grouping manner would be a dropdown list of the following options:

123 456 789 (groups of 3)
12 34 56 789 (lowest group 3, from there onwards 2)
1 2345 6789 (groups of 4)

Additional context

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/3103. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

This has nothing to do with translations, I just wanted an option to change the digit grouping symbol to space independently of the language or region. Please reopen until this is implemented.

Digit grouping is a localization issue, for example while you say this:

I learned that comma is technically the wrong symbol to use for digit grouping.

That is entirely inaccurate for where I live. The "right" way to group numbers depends on your localization settings.

That is entirely inaccurate for where I live. The "right" way to group numbers depends on your localization settings.

Well too bad. The General Conference on Weights and Measures has clearly worded against commas or dots as decimal separators.

"Numbers may be divided in groups of three in order to facilitate reading; neither dots
nor commas are ever inserted in the spaces between groups"
Source: https://www.bipm.org/utils/en/pdf/Resol22CGPM-EN.pdf

Regardless, my request at the top of the page still applies.

Is there at least a package I can install to do this?


Effective receptive fields analysis

Hi @junyuchen245,
Thank you so much for the great work and for sharing the code!
I am very interested in the effective receptive field analysis in your MIA paper (Section 6.3 and Fig. 15). I would like to compare Transmorph with some other CNN-based models in that respect.
I was wondering if you could share the code for the effective receptive field analysis (something like generating the results in Fig. 15). I tried implementing it myself but was having some trouble with it.
Thank you so much in advance!

i also want to konw .if you have solution,plz tell me .Thank you very much.


Update session-affinity.md

Fixed grammar: missing that

I'm going to port this change over to main. It might not get merged into latest due to other build issues.


Error in file mq_prometheus.out

Hi, I have this error in file mq_prometheus.out:
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.NoClassDefFoundError: com.ibm.mq.MQException
at java.lang.J9VMInternals.prepareClassImpl(Native Method)
at java.lang.J9VMInternals.prepare(J9VMInternals.java:304)
at java.lang.Class.getMethodHelper(Class.java:1247)
at java.lang.Class.getMethod(Class.java:1191)
at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:556)
at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:538)
Caused by: java.lang.ClassNotFoundException: com.ibm.mq.MQException
at java.net.URLClassLoader.findClass(URLClassLoader.java:610)
at java.lang.ClassLoader.loadClassHelper(ClassLoader.java:944)
at java.lang.ClassLoader.loadClass(ClassLoader.java:889)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:872)
... 6 more
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.NoClassDefFoundError: com.ibm.mq.MQException
at java.lang.J9VMInternals.prepareClassImpl(Native Method)
at java.lang.J9VMInternals.prepare(J9VMInternals.java:304)
at java.lang.Class.getMethodHelper(Class.java:1247)
at java.lang.Class.getMethod(Class.java:1191)
at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:556)
at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:538)
Caused by: java.lang.ClassNotFoundException: com.ibm.mq.MQException
at java.net.URLClassLoader.findClass(URLClassLoader.java:610)
at java.lang.ClassLoader.loadClassHelper(ClassLoader.java:944)
at java.lang.ClassLoader.loadClass(ClassLoader.java:889)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang
Please help me.

other launch by command:
[root@mqserver mq_exporter]# java -jar mq_exporter.jar config.yml
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.NoClassDefFoundError: com/ibm/mq/MQException
at java.lang.Class.getDeclaredMethods0(Native Method)
at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
at java.lang.Class.privateGetMethodRecursive(Class.java:3048)
at java.lang.Class.getMethod0(Class.java:3018)
at java.lang.Class.getMethod(Class.java:1784)
at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:544)
at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:526)
Caused by: java.lang.ClassNotFoundException: com.ibm.mq.MQException
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 7 more

update:
[root@mqserver mq_exporter]# java -jar mq_exporter.jar exporter_config.yaml
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.HashMap
at ru.cinimex.exporter.Config.(Config.java:52)
at ru.cinimex.exporter.ExporterLauncher.main(ExporterLauncher.java:45)

Hi! Error "A JNI error has occurred, please check your installation and try again" indicates that MQ JNI libraries are not added to classpath. This libraries are usually installed with IBM MQ.
For example, that's how you can add them via MQ Exporter startup arguments: -Djava.library.path=/opt/mqm/java/lib64 (considering /opt/mqm/java/lib64 is the correct location for MQ JNI libraries).
As for the error "Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.HashMap" - could you please provide exporter_config.yaml? Mostly interested in "prometheusEndpointParams" section. It seems like there is something wrong with configuration file format. (I'll try to make configuration errors handling more informative in the future)

Hello, it works perfect now, but I added more queues and messages to the MQ Test Server and the service crashes (MQEXPORTER)
This is the log:
2020-08-17 11:09:01.414 ERROR [main] [ru.cinimex.exporter.mq.MQConnection] [createSpecificTopic] [ru.cinimex.exporter.mq.MQConnection.createSpecificTopic(MQConnection.java:145)] - The maximum number of open handles allowed for the current task has already been reached. Please, increase the MaxHandles queue manager attribute or reduce the number of queues to monitor:
com.ibm.mq.MQException: MQJE001: Completion Code '2', Reason '2017'.
at com.ibm.mq.MQSubscription.subscribe(MQSubscription.java:105) ~[com.ibm.mq.allclient-<IP_ADDRESS>.jar:<IP_ADDRESS> - p912-L190308]
at com.ibm.mq.MQSubscription.(MQSubscription.java:75) ~[com.ibm.mq.allclient-<IP_ADDRESS>.jar:<IP_ADDRESS> - p912-L190308]
at com.ibm.mq.MQTopic.openForSubscription(MQTopic.java:1313) ~[com.ibm.mq.allclient-<IP_ADDRESS>.jar:<IP_ADDRESS> - p912-L190308]
at com.ibm.mq.MQTopic.(MQTopic.java:1142) ~[com.ibm.mq.allclient-<IP_ADDRESS>.jar:<IP_ADDRESS> - p912-L190308]
at com.ibm.mq.MQTopic.(MQTopic.java:720) ~[com.ibm.mq.allclient-<IP_ADDRESS>.jar:<IP_ADDRESS> - p912-L190308]
at com.ibm.mq.MQQueueManager.accessTopic(MQQueueManager.java:4130) ~[com.ibm.mq.allclient-<IP_ADDRESS>.jar:<IP_ADDRESS> - p912-L190308]
at ru.cinimex.exporter.mq.MQConnection.createSpecificTopic(MQConnection.java:142) [mq_exporter.jar:?]
at ru.cinimex.exporter.mq.MQTopicSubscriber.(MQTopicSubscriber.java:36) [mq_exporter.jar:?]
at ru.cinimex.exporter.mq.MQSubscriberManager.addTopicSubscriber(MQSubscriberManager.java:135) [mq_exporter.jar:?]
at ru.cinimex.exporter.mq.MQSubscriberManager.addTopicSubscribers(MQSubscriberManager.java:117) [mq_exporter.jar:?]
at ru.cinimex.exporter.mq.MQSubscriberManager.runSubscribers(MQSubscriberManager.java:53) [mq_exporter.jar:?]
at ru.cinimex.exporter.ExporterLauncher.main(ExporterLauncher.java:58) [mq_exporter.jar:?]
2020-08-17 11:09:01.421 INFO [Thread-4] [ru.cinimex.exporter.ExporterLauncher] [lambda$createShutdownHook$0] [ru.cinimex.exporter.ExporterLauncher.lambda$createShutdownHook$0(ExporterLauncher.java:191)] - Exporter finishes all activities...
2020-08-17 11:09:01.422 DEBUG [Thread-4] [ru.cinimex.exporter.ExporterLauncher] [lambda$createShutdownHook$0] [ru.cinimex.exporter.ExporterLauncher.lambda$createShutdownHook$0(ExporterLauncher.java:194)] - Stopping subscribers... (it may take some time, please, be patient)
2020-08-17 11:09:01.453 INFO [Thread-4] [ru.cinimex.exporter.ExporterLauncher] [lambda$createShutdownHook$0] [ru.cinimex.exporter.ExporterLauncher.lambda$createShutdownHook$0(ExporterLauncher.java:206)] - Goodbye!

Ready, I solved it.
https://stackoverflow.com/questions/30804518/ibm-mq-cwsmq0082e-failed-to-send-to-compcode-2-reason-2017
Regards.

Yes, that's expected behavior. IBM MQ has default max handles (250 or something like that) restriction. It was made to prevent uncontrolled amount of usages of MQ objects.
During startup MQ Exporter creates single dynamic queue to retrieve metrics. There are also many subscriptions that publish metrics to this queue. The more queues you need to monitor, the more subscriptions will be created. That is why sometimes default maxhandles attribute can be exceeded. The only correct solution is to increase it manually. There is an article about it: https://www.ibm.com/support/pages/maxhands-queue-manager-parameter
Please, let me know, if you need any further help.

This was the first stage of testing the operation and integration in a test environment.
Now what we want is not to touch the production Qmanager Server, therefore what we will do is configure a pivot that connects in client mode to the QM server, in the pivot we will try to implement a service so that the mq_exporter is executed. jar and the exporter_config.yaml
Greetings and thank you very much

Hello again,
We notice that the metrics are shown in Prometehus with 4 hours more, we have all the servers with the correct time.
But in Build Information - BuildDate is 4 more hours.
Do you know how to solve this difference, how to modify that date?
Build Information
-Version 2.20.1
-Revision 983ebb4a513302315a8117932ab832815f85e3d2
-Branch HEAD
-BuildUser root @ 7cbd4d1c15e0xx
BuildDate 20200805-17: 26: 58
--GoVersion go1.14.6

AFAIK prometheus always stores data in UTC. Found similar issue.
Exporter does not pass timestamp to Prometheus, so this is more likely to be related to the work of Prometheus himself.

update:
[root@mqserver mq_exporter]# java -jar mq_exporter.jar exporter_config.yaml
Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to java.util.HashMap
at ru.cinimex.exporter.Config.(Config.java:52)
at ru.cinimex.exporter.ExporterLauncher.main(ExporterLauncher.java:45)

How this was sorted ???? could we get an overview


Typo in documentation

Typo can be found here:

This action and function can be definedn as lambda functions in the Command constructor:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d99bbf7-baf8-ce1d-1580-97f730028cd1
Version Independent ID: 7d99bbf7-baf8-ce1d-1580-97f730028cd1
Content: Commanding - .NET MAUI
Content Source: docs/fundamentals/data-binding/commanding.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Another possible typo here?

An exception will be raised if a validation callback returns false, which you should be handle.

Hi @kristijan-boskovic
Thanks for pointing them out. There's a PR that fixes them working it's way through the publishing system now.


doc: Minor grammar/spelling fixes for README

Minor README tweaks. I tried to keep everything in the spirit of what exists.

Thanks!


Remove dependency on CoreRegistry from Skysphere

Remove dependency on CoreRegistry from Skysphere by passing in the CelestialSystem directly.
I also added it to the HeadlessEnvironment, with a mock to WorldProvider, and a static WorldTime reference, so unit testing the day/night cycle in the future becomes possible
How to test

Run all the unit tests and verify nothing got broken by this change.
Open up the game, and create a world
Open up the game, and load a world

Hooray Jenkins reported success with all tests good!

In the description of this PR you correctly mention what you did. Another aspect that would be interesting to know however, is the why. What is the reasoning that led you to propose this set of changes?

Any CoreRegistry usage removal is good.
Using the Ciregegistry is like using a static variable and comes with the same restrictions. E.g currently we can't run server and client in same JVM

Fair enough, but then why not to use the Context instead?
I guess my question is about the advantage of passing the CelestialSystem (which couples the SkySphere to it) rather than Skysphere implementations obtaining it from a Context only if they need it, as there could be game modes that do not need a skysphere (i.e. undeground-only) or need a Skysphere that does not use a CelestialSystem, i.e. creative-mode daytime-only modes.

@emanuele3d It makes testing more easier for my work in progress sun/moon cycles. I won't need a HeadlessEnvironment, or to instantiate a Context just to initialize a Skysphere.

But never mind. Looking at the context of this code it seems to be pretty inflexible anyway. It's not like a module can currently provide a different SkySphere implementation if it had one.

Sorry, I had to re-read your comment, and now I get it! For those cases it makes more sense to have it with the Context, I'll change this.

Hooray Jenkins reported success with all tests good!

Since this seems like it has been worked out in a good way while making progress on CoreRegistry -> Context I've gone ahead and merged it after testing :-)

Thank you @Avalancs for the last minute changes and thank you @Cervator for the merge!


feat: migrate to Mariner containers

Description
Migrates the images from Ubuntu/Debian builder and Debian-distroless final image to Mariner for everything. Incidentally also moves from clang-14 to clang-16.
Checklist

[x] I have read the contributing documentation.
[x] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
[x] I have correctly attributed the author(s) of the code.
[x] I have tested the changes locally.
[x] I have followed the project's style guidelines.
[x] I have updated the documentation, if necessary.
[x] I have added tests, if applicable.

validated by deploying ghcr.io/rbtr/retina/retina-agent@sha256:df460114dbc08be26db1988bb0ce631697563b073953e61cfdaaacf84c7aea5b from my fork, seems to function as before 🙂


When listening to an album, the song titles do not change

When you listen to an album, I assume because the album art never changes, the song title never changes

Good catch, I've only tested albums before titles were added, will fix this when I get the chance.


Loop devices are wrongly hotplugged when using privileged containers

Description of problem
When starting a privileged container, the loop devices of host will be hotplugged to pod as block devices.
Expected result
Don't hotplug the loop devices in the spec of privileged container.
Actual result
The dmesg of pod will show lots of messages like:
[   22.020384] scsi 0:0:0:252: Direct-Access     QEMU     QEMU HARDDISK
[   22.021520] sd 0:0:0:252: Power-on or device reset occurred
[   22.021870] sd 0:0:0:252: [sdis] Read Capacity(16) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.021973] sd 0:0:0:252: [sdis] Sense Key : 0x2 [current]
[   22.022034] sd 0:0:0:252: [sdis] ASC=0x4 ASCQ=0x3
[   22.022187] sd 0:0:0:252: [sdis] Read Capacity(10) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.022315] sd 0:0:0:252: [sdis] Sense Key : 0x2 [current]
[   22.022383] sd 0:0:0:252: [sdis] ASC=0x4 ASCQ=0x3
[   22.022594] sd 0:0:0:252: [sdis] 0 512-byte logical blocks: (0 B/0 B)
[   22.022674] sd 0:0:0:252: [sdis] 0-byte physical blocks
[   22.022763] sd 0:0:0:252: [sdis] Write Protect is off
[   22.022833] sd 0:0:0:252: [sdis] Mode Sense: 5b 00 00 00
[   22.022949] sd 0:0:0:252: [sdis] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
[   22.023621] sd 0:0:0:252: [sdis] Read Capacity(16) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.023733] sd 0:0:0:252: [sdis] Sense Key : 0x2 [current]
[   22.023804] sd 0:0:0:252: [sdis] ASC=0x4 ASCQ=0x3
[   22.023947] sd 0:0:0:252: [sdis] Read Capacity(10) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.024057] sd 0:0:0:252: [sdis] Sense Key : 0x2 [current]
[   22.024112] sd 0:0:0:252: [sdis] ASC=0x4 ASCQ=0x3
[   22.024419] sd 0:0:0:252: [sdis] Attached SCSI disk
[   22.096149] scsi 0:0:1:1: Direct-Access     QEMU     QEMU HARDDISK
[   22.097095] sd 0:0:1:1: Power-on or device reset occurred
[   22.097403] sd 0:0:1:1: [sdix] Read Capacity(16) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.097516] sd 0:0:1:1: [sdix] Sense Key : 0x2 [current]
[   22.097586] sd 0:0:1:1: [sdix] ASC=0x4 ASCQ=0x3
[   22.097729] sd 0:0:1:1: [sdix] Read Capacity(10) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.097840] sd 0:0:1:1: [sdix] Sense Key : 0x2 [current]
[   22.097896] sd 0:0:1:1: [sdix] ASC=0x4 ASCQ=0x3
[   22.098069] sd 0:0:1:1: [sdix] 0 512-byte logical blocks: (0 B/0 B)
[   22.098150] sd 0:0:1:1: [sdix] 0-byte physical blocks
[   22.098246] sd 0:0:1:1: [sdix] Write Protect is off
[   22.098314] sd 0:0:1:1: [sdix] Mode Sense: 5b 00 00 00
[   22.098430] sd 0:0:1:1: [sdix] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
[   22.099095] sd 0:0:1:1: [sdix] Read Capacity(16) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.099212] sd 0:0:1:1: [sdix] Sense Key : 0x2 [current]
[   22.099286] sd 0:0:1:1: [sdix] ASC=0x4 ASCQ=0x3
[   22.099429] sd 0:0:1:1: [sdix] Read Capacity(10) failed: Result: hostbyte=0x00 driverbyte=0x08
[   22.099540] sd 0:0:1:1: [sdix] Sense Key : 0x2 [current]
[   22.099595] sd 0:0:1:1: [sdix] ASC=0x4 ASCQ=0x3
[   22.099878] sd 0:0:1:1: [sdix] Attached SCSI disk

@darfux With privileged containers, all devices on the host are passed to the container which means any block devices are hotplugged. We added a configuration with containers and crio to tackle this.
Please take a look at this:
https://github.com/kata-containers/documentation/blob/master/how-to/privileged.md

@darfux Closing this. Please reopen if you think this is still relevant.

@amshinde got it, thanks 😃


fix linter warnings, refactoring, added new cmake versions, added package test

Also I don't know why, on line 27 of main conanfile there is double str(self.settings.os) argument passed to the get method. Passing this argument just once gives same result.

Thanks!, about the line 27, the second parameter is a default value in case the dictionary doesn't contain the requested value.


Fix for issue related to GridMap editor

closes #2102

not sure why this can't be merged, can you try pulling and sending PR again?


new StringValue("'") error

use new StringValue("'")  with version 4.4
Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -1

Greetings.
You will need to provide much more information, about what you are trying to achieve, what has been observed and what was expected.

I use version 4.4
I want to convert the data queried from the database into an insert statement through  StringValue.
If the data in the database is ', new StringValue will report an error exception. The exception information is: java lang.StringIndexOutOfBoundsException: String index out of range: -1。
I read the source code and found a problem:
if (escapedValue.startsWith("'") && escapedValue.endsWith("'")) {
    value = escapedValue.substring(1, escapedValue.length() - 1);
    return;
}
I want the final effect to be that SQL statements can be produced normally.

if (escapedValue.startsWith("'") && escapedValue.endsWith("'")) {
value = escapedValue.substring(1, escapedValue.length() - 1);
return;
}

Thank you for the hint and finding. We will fix that of course,

Could you test the behaviour. Is it now like you expected it?

Great, the problem has been solved.


Latest build is not populating config values

Great grunt task, been using it for quite a while.
v1.3.2
sample:
prompt : {
            deploy : {
                options : {
                    questions : [
                        {
                            config : 'environment',
                            type : 'list',
                            message : 'Environment to deploy to:',
                            default : 'staging',
                            choices : ['staging', 'production']
                        }
                    ]
                }
            }
        }

using the following will log and empty string here:
    grunt.registerTask('logit', function() {
        console.log(grunt.template.process('the env is <%= environment %>'));
    });
    grunt.registerTask('deploy', [
        'prompt:deploy',
        'logit']);

the env is

1.3.0 logs staging

Same problem here! Adding fixed version v1.3.0 to our grunt projects for now until this issue is resolved.

Also experiencing this problem

Sorry about that!
Thanks for quickly reporting it @pajtai and followups from @nvaken and @ld0rman.
It was a quick fix and I've published the new version as 1.3.3.

Awesome, thanks for the quick hotfix.


Refactorings

Mostly attempts to do various state cleanup with a meta reducer to clear out state on logout instead of having actions to clear out each slice of state individually. Also mostly decouples feature modules from one another by moving shared state to the shared module.
Lazy loading will be an optimization for later, though it was mostly focused on mobile users. I intend of making a mobile app at some point, so this may be a premature optimization.

Pull Request Test Coverage Report for Build 656

80 of 80 (100.0%)  changed or added relevant lines in 41 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 98.743%

Totals

Change from base Build 645:
-0.04%

Covered Lines:
2114

Relevant Lines:
2127

💛  - Coveralls


rbd plugin refactoring: remove k8s clientSet

before we have user credential fixes, secrets are in plain text.
@sbezverk

@sbezverk let's have this and wait till we have user credentials in k8s 1.10 and merge #12


swarm/container: add support for TTY and supplementary groups

These are supported in swarmkit. Let's make sure we have the relevant fields in docker.
This will need to be followed up with a support PR in docker/docker with the appropriate flags, but this can be merged right away.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

LGTM

LGTM 🐮


Can't add tools.fastlane:screengrab

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
Screengrab
Question Description
I'm following the instructions in the screen grab documentation but adding
androidTestCompile('tools.fastlane:screengrab')
or
androidTestCompile('tools.fastlane:screengrab:1.2.0')
Fails with:
Error:Failed to resolve: tools.fastlane:screengrab:
I have added both mavenCentral and jcentral repositories:
allprojects {
    repositories {
        google()
        mavenCentral()
        jcenter()
    }
}

@YamiDaisuke Hmmm, this is what mybuild.gradle looks like and it works for me 🤔  Can you try something like this?
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {

    repositories {
        google()
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.2.0-alpha14'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

Hello! thanks for the reply, I was able to make it work but I needed to add excludes for android support library there was a conflict 'cause I was using a different version of the support library for my project
androidTestImplementation('tools.fastlane:screengrab:1.2.0'){
        exclude group: 'com.android.support', module: '*'
    }

    androidTestImplementation('com.android.support.test:runner:1.0.2') {
        exclude group: 'com.android.support', module: '*'
    }
    androidTestImplementation('com.android.support.test.espresso:espresso-core:3.0.2') {
        exclude group: 'com.android.support', module: '*'
    }


test: running checks without any change

[ERROR] Failures:
[ERROR]   ITSystemTest.detectWebEntitiesGcsTest:495 expected to contain: The Palace Of Fine Arts
but was            : [Ancient Rome, Triumphal arch, Ancient history, Ancient Roman architecture, Palace of Fine Arts, History, Architecture, Historic site, Façade, Arch, Tourism, Hematocrit]
[ERROR]   ITSystemTest.detectWebEntitiesIncludeGeoResultsGcsTest:557 expected to contain: The Palace Of Fine Arts
but was            : [Ancient Rome, Ancient history, Triumphal arch, Ancient Roman architecture, Palace of Fine Arts, History, Architecture, Historic site, Façade, Arch, Tourism, Hematocrit]

OwlBot Postprocessor didn't run on pull request creation.
Comparing a pull request in java-resourcemanager: https://github.com/googleapis/java-resourcemanager/pull/827


refactor: upgrade project

:tada: This PR is included in version 0.67.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Autoprefixer required by 'npm run build'

Totally right. Thanks (and sorry for letting this slip)!


[ORPO] system special token is included in chosen/rejected samples after applying chat template

According to the chat template used in recipe, the chosen and rejected columns will begin with the following after preprocessing:
<|system|>
<|end_of_test|>
....... (assistant response)

Shouldn't them be removed after applying the chat template?

Close this issue as resolved


Modify textarea's text

Hello, I've been having fun with this library. I'm currently trying to modify specific lines in textarea.text. Basically what I'm doing is prepending some lines wtih tabs to simulate that persistent tab effect on Enter. So far so good, I can get the line by counting characters against cursor position, but when I try to textarea.text = "something" I get the following error:
(dirfun:12443): Gtk-WARNING **: 19:03:49.532: Invalid text buffer iterator: either the iterator is uninitialized, or the characters/pixbufs/widgets in the buffer have been modified since the iterator was created.
You must use marks, character numbers, or line numbers to preserve a position across buffer modifications.
You can apply tags and insert marks without invalidating your iterators,
but any mutation that affects 'indexable' buffer contents (contents that can be referred to by character offset)
will invalidate all outstanding iterators

So I'm wondering what would be the correct way to do this. I can't find any method in the NiGui source that might handle this, so not sure if it's already implemented. I tried running the text assignment on a thread, but it complained about GC limiations.

Btw, would be great to have methods to get the current line number, and modify a specific line.

Removing this logic from the textarea change callback fixes the gtk error.

@madprops Can you please post minimal example program to reproduce the error message?

Hmm I replaced the code and made a cli version instead. But basically what I was doing was changing the textarea's content inside the text change event. If I did it from other place the error didn't appear. Probably just some GTK limitation.

Closing as not reproducible.


Docker-compose not working on buster

I already found this with raspbian buster, but running docker-compose on hypriot 1.11 gives also the following error:
ImportError: No module named ssl_match_hostname
I found a solution here: https://github.com/docker/docker-py/issues/1502#issuecomment-506544849.
After doing it works for me:
sudo pip uninstall backports.ssl-match-hostname
sudo apt install python-backports.ssl-match-hostname

I cannot reproduce the problem. Can you share more details, eg. which docker-compose commands you called or the docker-compose.yml that you are using?

I think it has been resolved now in buster itself and this is no longer needed. I already noticed in a flash this week or so, that it was no longer necessary.

This is still happening to me on a fresh buster install on pi4.

On a fresh install this isn't an issue, but when you install pip this package apparently get's installed and then breaks docker-compose.
Maybe an idea to switch to python 3 to solve this problem.

Thanks @Duvel for the update. Yes, it's time to switch to python3.

Should be fixed with #335

Cool, are you going to do another release? I was about to flash another pi this week and could test the new release and flash tool.

There is a pre-release 1.12.0-rc2 right now where we could need some feedback.

I ran some test-runs and was able to break docker-compose again. But I found out that this was due to uninstalling cloud-init, which removes a few needed packages.
Can you add the packages python3-yaml and python3-jsonschema to the image? It appears that is what is needed for docker-compose.
Is there anything else that needs to be tested in this release?


An error occurs in pretrained_ViT: True

Thank you for sharing your great work.
When setting pretrained_ViT: True in args of train.py, the following error occurs. I confirmed that the ViT model was successfully downloaded. Can you tell me how to solve it?
Building model...
--- loading pretrained to start training ---
https://dl.fbaipublicfiles.com/deit/deit_small_patch16_224-cd65a155.pth
Downloading: "https://dl.fbaipublicfiles.com/deit/deit_small_patch16_224-cd65a155.pth" to /home/dmsai3/.cache/torch/hub/checkpoints/deit_small_patch16_224-cd65a155.pth
Traceback (most recent call last):
File "train.py", line 239, in
model, args = build_model(args, model_params)
File "/home/dmsai3/TSformer-VO/build_model.py", line 97, in build_model
load_pretrained(model, num_classes=model_params["num_classes"],
File "/home/dmsai3/TSformer-VO/timesformer/models/helpers.py", line 161, in load_pretrained
elif num_classes != state_dict[classifier_name + '.weight'].size(0):
KeyError: 'head.weight'

Thank you for your explanation. I understood that I encountered an error because I downloaded a pretrained-ViT that does not match the patch_size and embed_dim. However, as you know, the default_cfgs in build_model.py specifies the URL of the pretrained-ViT according to the patch_size and embed_dim, and patch_size and embed_dim are retrieved from model_params in train.py. Therefore, I understood that the code is written to download the matching pretrained-ViT based on patch_size and embed_dim.
Indeed, when I set "patch_size", "dim", and "heads" in model_params of train.py to 12, 384, and 6 respectively, I confirmed that it downloaded the small (deit_small_patch16_224-cd65a155.pth) model, so I verified that the error did not occur because model_params and pretrained-ViT did not match.
Upon reviewing the error message, I noticed that the error occurred in the code snippet from helpers.py:
classifier_name = cfg['classifier']
...
elif num_classes != state_dict[classifier_name + '.weight'].size(0):
Here, the classifier_name variable is assigned by cfg['classifier'], but the value of 'classifier' in default_cfgs in build_model.py is set to 'head'. So, I suspect that the KeyError: 'head.weight' error occurred due to this mismatch. If my understanding of the error is correct, could you suggest another solution?

Ok, I see... I don't know if it was a typo, but you mean "patch_size=16" instead of 12, right? The 12 is the depth of the "deit_small"
I couldn't reproduce your error, I made a small test on Google Colab and I was able to read the pretrained-ViT model. If it was not a typo let me know, and I can test it later on my machine (I can't test it rn, probably in the next 2 days)

Yes, "12" was indeed a typo. I had set the patch_size to 16. It worked well in Colab, which is a relief. I'll wait to test it on your machine. Thank you for your helpful response.

helpers.py is already updated.
The problem was that state_dict[head.weight] does not exist, but state_dict['model'][head.weight'] does. So I just added the line for the cases when the state_dict has the model as a key:
https://github.com/aofrancani/TSformer-VO/blob/main/timesformer/models/helpers.py#L109
state_dict = model_zoo.load_url(cfg['url'], progress=False, map_location='cpu')
try:
    state_dict = state_dict['model']
except:
    state_dict = state_dict

It worked for me in GoogleColab because I've had this issue before and I solved it in parallel, forgetting to update my local code.
Tks for pointing that out, I hope it works now :)

Yes, training works well without errors with the updated code.
Thank you for fixing the issue and for your attentive support. :)


Deployment stability

[ ] dev/prod settings needed
[ ] Deploys to github need to use production settings, not local dev
[ ] deploy from circle-ci needs to work reliably

Unpacking 6am brain:
What I think happened:

repo name changed
automatic build failed
noticed outdated string /fsd-spike in script tag
rebuilt locally with local .env with correct REACT_APP_GH_PAGES_SUFFIX=/FSD
manual deployed
fixed npm build problem
auto deploys still failing attributed to gh-pages
Manually fixed gh-pages problem with this suggestions
Shiny tried locally using old `.env
Shiny re-tried using new `.env (worked?)
Later on I was in circle-ci settings and noticed env variables still had old /fsd-spike suffix
Updated to new suffix
Auto-deploy is back happening :tada:, circle-ci still insisting on trying to build gh-pages branch :disappointed:

confusing factors

repo rename
switch commands from yarn to npm omit of build
circle-ci failing on gh-pages branch creating noise
circle-ci managing own env

If this is accurate

[x] dev/prod settings needed - we have circle-ci env, just need to remember to use

[x]  Deploys to github need to use production settings, not local dev - again, circle-ci covers this

[x]  deploy from circle-ci needs to work reliably - as long as we keep its env up to date it should work, the gh- pages question aside

Re-opening. The site isn't deploying. I get a  github 404 page after every circle ci deploy

Added @lamorrison after discussing on slack


ipset repository removed?

@gregvirgin @dcreager @johnzachary repository of ipset (https://github.com/redjack/ipset) got removed?
I'm debian pkg maintainer of libcork and ipset. There're increasing number of users around.

https://qa.debian.org/popcon-graph.php?packages=libcork16
https://qa.debian.org/popcon-graph.php?packages=libcorkipset1

So I hope ipset can be restored.
Thanks for your understanding!

Hi @rogers0. I wish I could help, but neither @dcreager nor I work for RedJack.

It’s public again.
Greg

On Sep 24, 2017, at 12:59 PM, Roger Shimizu<EMAIL_ADDRESS>wrote:
@gregvirgin https://github.com/gregvirgin @dcreager https://github.com/dcreager @johnzachary https://github.com/johnzachary repository of ipset (https://github.com/redjack/ipset https://github.com/redjack/ipset) got removed?
I'm debian pkg maintainer of libcork and ipset. There're increasing number of users around.
https://qa.debian.org/popcon-graph.php?packages=libcork16 https://qa.debian.org/popcon-graph.php?packages=libcork16
https://qa.debian.org/popcon-graph.php?packages=libcorkipset1 https://qa.debian.org/popcon-graph.php?packages=libcorkipset1
So I hope ipset can be restored.
Thanks for your understanding!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/redjack/libcork/issues/122, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmDrsmkcuW-HrB5hzaIsbskwDFK5iS4ks5sloqNgaJpZM4Ph86i.

I’d like to offer to transfer ownership of these repos to someone else. Or please fork them so I can delete them some time this year. We don’t use them and aren’t offering to support them.
Thanks,
Greg

On Sep 24, 2017, at 2:43 PM, John Zachary<EMAIL_ADDRESS>wrote:
Hi @rogers0 https://github.com/rogers0. I wish I could help, but neither @dcreager https://github.com/dcreager nor I work for RedJack.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/redjack/libcork/issues/122#issuecomment-331730348, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmDrotwAJSxKY5Dcj4f4kG0arJObKoGks5slqK2gaJpZM4Ph86i.

@gregvirgin thanks for restoring the repo!
I just want to keep the metadata of the project, not only the code, but also reported issues, pull requests, etc.
@johnzachary @dcreager would you take the ownership of the repos, that @gregvirgin offered to hand out? I think it's more proper because you're the two main author. thanks!

I can take ownership.  I won't have time to do any ongoing development, but I'm happy to review and merge PRs.

@gregvirgin
Thanks for taking care of these repos these days!
As I said, it's better to keep the metadata of these repos, such as issues, pull requests, etc.
Since @dcreager volunteer to be able to take the ownership, could you kindly help to proceed?
It's really appreciated your kindness!

@dcreager please remove your forks of ipset and libcork so I can transfer ownership to you.

Done

transfers initiated.

The repos have been transferred, closing this issue


[Feature Request]: Allow setting times for each date

Thank you for creating a great, simple datepicker for React + Tailwind. If possible, it would be greatly appreciated if you could allow the ability to set a time for each date. Example layout screenshotted below

Hi @partounian 👋
Thank you for using our package.
Sorry for the delay. Thanks for the request. I believe we already have a similar proposal. It shows how useful it would be to have it really. We will implement it very soon.
PRs are always welcome 🎉.

@onesine @partounian
Hi guys, since PRs are welcome 😉, follow a PR in below just doing exactly that :rocket::
https://github.com/onesine/react-tailwindcss-datepicker/pull/236


🔌 Plugin: Azure sites

🔖 Summary
Hello,
I keep getting TypeError:

I have no problem pulling the data because http://localhost:7007/api/azure-sites/list/func gives me a proper json blob on the backend.
my config:
azureSites:
  domain: sample.se
  clientId: ${AZURE_CLIENT_ID}
  clientSecret: ${AZURE_CLIENT_SECRET}
  tenantId: ${AZURE_TENANT_ID}

apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
  name: developer-docs
  description: An example of a Backstage application.
  annotations:
    backstage.io/techdocs-ref: dir:.
    dev.azure.com/project-repo: backstage_proj/backstage_demo
    azure.com/tag-selector: environment/production
    azure.com/microsoft-web-sites: func
spec:
  type: service
  owner: MrKebab
  lifecycle: experimental

thank you in advance!
🌐 Project website (if applicable)
No response
✌ Context
No response
👀 Have you spent some time to check if this plugin request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

This one is solved. I reinstalled the plugin and it start working.

Ok thanks!


Can't compile on Windows 10

Hello, can i ask, compilation to the native exe files still not available ?
I
Thank u!

There have been some PRs from the community both here (https://github.com/brenhinkeller/StaticTools.jl/pull/58) and in StaticCompiler.jl so more things may work now. I don’t have a windows machine to test on myself though, so no promises!

Thank u a lot! I will try!


Speeding up ReadAssignmentFromRoute

Currently I'm working on a VRP model with the following additional characteristics

Nodes are mostly disjunctive and only a single node from each set need to be visited
These nodes need to be visited in a certain sequence (time dimension + CumulVar)
Additional resources from shared pool required for each nodes if visited

I have some heuristic implemented to generate the initial routing - due to the additional constraints highlighted above, most of the slacks are non-zero.
I'm trying to utilize ReadAssignmentFromRoute to improve on the initial routing, however, regenerating the assignment took a lot longer than expected.
Any tips and hint to speed this up?

This is not helping.
Are you sure the time is spent in the loading part ?
Are you sure the solution is valid.
Please provide a working example.
Closing for now. Do not hesitate to reopen with a working sample.


[UX] Inconsistent experience in portals

Description:
Management console and Store/Publisher/Admin portals have a significant experience gap.
All the portals should maintain consistency throughout the user flows.
Suggested Labels:
UX Improvements
Affected Product Version:
2.5.0

I’m closing this issue because it has been inactive for more than two years.


Importing a CSS file that contains @charset declaration

I am making a theme (one big compiled CSS as a result) that is built from less sources (Bootstrap 3, etc.) and some original CSS sources from GitHub. And here is an example: https://github.com/daneden/animate.css/blob/3.4.0/animate.css#L1 When I import this file, somewhere at the middle of the compiled result CSS the declaration @charset "UTF-8"; appears and it is not valid there.
Is it possible for imported CSS files the compiler simply to ignore the declaration @charset and not to put it within the result CSS?
Edit: Or, a more generalized way, @charset to be ignored if it is not going to be right at the beginning of the result CSS file.

Since this is a port of less.js, I believe it should match its behavior. In less.js the @charset is moved to the top of the file. I don't know how it behaves when there are multiple, different @charset rules however...

Several @charset declarations simply are not recognized by the browser as valid, so I don't see the point of implementing exactly the behavior of less.js in this regard.

I did a simple test with three files that have different encodings. If the calling less file doesn't contain a @charset rule already, less.js takes the encoding of the first imported file and moves that one to the top of the compiled CSS file. It will ignore all following @charset rules it encounters so the resulting CSS file will contain just one @charset rule. This is how it should be according to CSS specs and how less.php should implement it as well.
I do believe however that if the compiler finds different, conflicting encodings it should throw an exception or generate a warning, but that is an issue that should be addressed in the less.js repo...

I do believe however that if the compiler finds different, conflicting encodings it should throw an exception or generate a warning,

Not really since those directives specify the encoding of Less compiler input files, while the compiler itself outputs all of content in the same encoding (usually UTF-8 if I recall correctly) - so strictly speaking a compiler should simply eliminate all of those directives at the output

As for the less.php and less.js differences, don't forget the former is at v1.7.x while the latter is at v2.5.x hence the different behavior.

I see your point. I agree now that the charset should not be copied to the compiled CSS file. But what if one of the imported files does contain a non-ASCII character, shouldn't the resulting CSS file have @charset 'utf-8'; at the top (W3C strongly recommends to only use UTF-8)? Although it isn't strictly necessary to include a @charset declaration in your CSS file (it will use the same encoding as the calling HTML file, which should be UTF-8 as well, or the encoding in the HTTP Content-Type header) they do recommend to still include it anyway.

they do recommend to still include it anyway.

This is where practice > recommendation comes in. All modern browsers handle UTF-8 sheets w/o @charset just fine (even if the encoding is different from the HTML they belong to), while some older browsers may fail if they see the directive. In other words, it's more like a "don't fix what isn't broken" case.

So, back to @ivantcholakov's original issue: ignore all @charset rules except for the one defined at the top of the calling LESS file? I'm all for it!

ignore all @charset rules except for the one defined at the top of the calling LESS file?

Yes, I also agree this to be the most reasonable behaviour.

@renaatdemuynck

ignore all @charset rules except for the one defined at the top of the calling LESS file?
I agree. Sorry for seeing this discussion so late.


Assign reviewers on use of 'SDK Deprecation' label

As part of our Azure SDK Deprecation Strategy, I'm directing people to use the 'SDK Deprecation' label when they file a CSV change marking a package as deprecated. When this label is assigned, I'd like to have myself, Ronnie Geraghty, and Scott Addie added as reviewers to the PR.
This is the same functionality requested in this PR: https://github.com/Azure/azure-sdk/pull/5883
This issue is intended as an ask for implementation in the replacement for Fabric Bot.

@mario-guerra :  How do we expect the label to be assigned?   If we know there's a specific CSV file that is changed for a deprecation, why would we not assign you folks as owners in CODEOWNERS for that path?  That would trigger the default GitHub behavior of assigning you whenever the CSV file is changed, regardless of whether or not a label is assigned?

@jsquire ideally the label would be assigned by the person filing the issue, but I only yesterday learned that not everyone can add labels, only those with repo rights. Is that true? If so, then we may need to go with the CODEOWNERS option.

@mario-guerra : That's correct - only folks with write access can add them.   From experience, people do not follow documented practices for adding labels when opening issues and pull requests.  If you'd like the process to be at all reliable, the CODEOWNERS approach is better.   That would allow you to get the label and review assignment automatically.

Thanks, PR filed.

I've been thinking over whether we should make this a general rule for PRs and Issues for "Add assignments when labels are added" and I just can't get it to a place where I think the benefits would outweigh all the edge cases for annoyance.
Since Mario's core use case is covered under the standard CODEOWNERS functionality, I'm going to close this one out for now.


[DOC] Document tx status query

We should document tx status query to explain what the return results mean and how one might use it to determine whether the transaction has truly finished.

Fixed in #451


Update document for RuboCop 1.41.1

We are updating the documentation as versions are released that include the following

https://github.com/rubocop/rubocop/pull/11317

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[-] Added tests.
[x] Updated documentation.
[-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

So much better now to have it published in our docs, not only code, thank you!


issue using bedtools merge and bedtools maskfasta

Hi,
I would like to use bedtools merge and bedtools maskfasta but they don't produced the result I expect, probably I misunderstand some parameters ?!
I have a gff file containing several intervals that I want to mask on my fasta file. So I first merge those intervals :
cat pos2mask.gff | bedtools merge -d 0 > pos2msk
Then I mask those positions on my fasta file :
bedtools maskfasta -fi genome.fasta -bed pos2msk -fo genome.msk.fa
The problem is that bedtools miss some positions. After the merge if I have some intervals such as :
24-55 and 56-60. The base at the position 56 will not be mask, and I don't really understand why...
So I put the parameter -d at 1 in bedtools merge. It solved the problem with the previous interval and collapse it at 24-60. The problem is with intervals separates with 2 basis, it collapse them too, for example 24-55 and 57-60 because (I guess) it change the intervals with +1 and -1 respectively at end and start intervals, so those intervals know overlaps. By putting -d at 1 it mask too many bp.
Is there a way to mask all basis, even when the intervals are contiguous ?
I hope my text is understandable,
Thanks in advance for any clue,
Marion

I am unable to reproduce this. If you can share a minimal example, I can try again.


Multiball combination

fix #399

Coverage increased (+0.02%) to 92.059% when pulling 3d1d8f7a1cde0c9150650ae96b62ae3798f3d5c5 on multiball_combination into 2256b5108b395341f9dc95fccb9df8ccd2d72f36 on dev.

Coverage increased (+0.02%) to 92.059% when pulling 3d1d8f7a1cde0c9150650ae96b62ae3798f3d5c5 on multiball_combination into 2256b5108b395341f9dc95fccb9df8ccd2d72f36 on dev.


Graphql blocking tests

Description

Check that graphql addresses are blocking as expected
Motivation

Workflow

⚠⚠ Create your PR as draft
Follow the style guidelines of this project (See how to easily lint the code)
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Once your PR is reviewed, you can merge it! :heart:
Reviewer checklist

[ ] Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
[ ] CI is green

[ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)

[ ] if any of build-some-image label is present

is the image labl have been updated ?
just before merging, locally build and push the image to hub.docker.com

[ ] if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

Starting with the review. Too big. We should try to make the PRs smaller, if it's possible....

/merge


Fix indent of annotation array entry

Description
Fix indent of annotation array entry
Closes #1688
Checklist

[X] PR description added
[X] tests are added
[ ] KtLint has been applied on source code itself and violations are fixed
[ ] documentation is updated
[X] CHANGELOG.md is updated

In case of adding a new rule:

[ ] Rule is added to rules documentation

Build failures might be related to the issue on CI devices, could you run it again?

Build failures might be related to the issue on CI devices, could you run it again?

Tnx @Goooler,  builds have now succeeded. I was looking into this yesterday and totally did not understand what was going wrong. I am glad it is resolved now.

I was also confused and retried yesterday, but today it's passed.


Exclude :phoenix as a dependency in releases?

So far, this lib is proving very intriguing and promising. Thanks! ❤
One of the pitfalls we're running into, however,  is the requirement for :phoenix as a dependency which seems to only be for the %Phoenix.Socket.Message{} struct used in a few places
In some cases, like mine, where dependencies are tightly controlled, this can be a deal breaker.
I see that there are some local and testing cases that require it, so it could be scoped to dev and test:
{:phoenix, "~> 1.0", only: [:dev, :test]}

As for the struct, my current idea is just to reimplement and change as needed when phoenix changes. Or some clever meta programming could be done to pull definition from the dev dependency, but might be getting too clever there 😉.
Though I might actually suggest supporting the concept of a :serializer that can also be configured by the user. That would make this match functionality with phoenix and support those either using the V1 serializer, or those who have abandoned JSON as the primary serialization and made their own for the server instead of forcing the V2 serialization structure thats default in phoenix now.
Thoughts?

Loving the feedback @jjcarstens, glad to have you trying out slipstream! :heart:
Seems pretty reasonable to me to remove that phoenix dependency. It's a pretty steep price to pay just for a struct with a handful of fields!
I think it'd be an awesome improvement just to get rid of that dependency on the struct and limit phoenix to dev test & docs.
The serializer idea is pretty attractive. We only use some of the basic/vanilla features of Phoenix so the standard JSON serializer gets us as far as we need to go, but if you're using sockets for something super-performant you'll probably need that fine-grained control. I imagine we could work out a simple behaviour for a serializer and provide default JSON v1 and v2 implementations that look very similar to Phoenix's.
I'll make another issue to stub that serializer idea out and get to work on :hocho:ing out phoenix right now


Add segmented control to filter results by Size or Alphabetically

Here's how it looks like ( it's my first SwiftUI code ever )
Dumbledore: after all this time
Me: YES ;)

Thank you for your pull request!
Firstly, I think that it should be "Filter by" or "Filtered by" instead of "Filter option" and "Name" instead of "Alphabetical".
Secondly, segmented control is too large and I recommend to put Spacer() between text and segmented control.
Finally why does the directory list view look like it has a container with right & bottom borders?

List view look like it has a container with right & bottom borders?
i don't really know


[CWS] reduce allocation in stats reporting of activity tree

What does this PR do?
About 5% of the total system probe allocations are done to create those metric tags, this is obviously a waste of CPU time and this PR makes sure we do not build the tags at usage time.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


:tada: fixed session of undefined tests blinking

@amir-arad made changes, review please

@amir-arad check if it good

for the record I would have loved it if we could use Module Augmentation, something like
declare module "autobahn"{
    namespace autobahn {
        interface Connection {
            isConnected: boolean
        }
    }
}

but I tried and tried and didn't get it to work :(


Design the UI and UX.

UI - User Interface
UX - User Experience

This will shape how users will interact with our app and influence overall satisfaction/engagement.

[ ] Summary: Visual designs and prototypes that align with user needs and business goals.
[ ] "Done"

[ ] Summary: Creating a visually appealing UI and UX for application.
[ ] "Done" Requirements:
Ensure consistency in design element and guides a user to easily navigate through the application.
Ensure that the UI is responsive and adaptable.


KAFKA-17904: Flaky testMultiConsumerSessionTimeoutOnClose

Here are some of my conclusions about this flaky test.
First of all, the reason for the failure of this test is due to TIMEOUT, the method AbstractConsumerTest#validateGroupAssignment timeout after waiting for 10 seconds. And it reproduced on my computer.
AbstractConsumerTest#validateGroupAssignment is used to check all the consumer's assignments meet expectations, the exception as below:
org.opentest4j.AssertionFailedError: Did not get valid assignment for partitions HashSet(topic1-2, topic1-4, topic-1, topic-0, topic1-5, topic1-1, topic1-0, topic1-3). Instead, got ArrayBuffer(Set(topic1-1, topic1-0, topic1-2), Set(topic1-5, topic1-4), Set())

I ran this junit test many times on my local computer after I added some logs. Then I found the timeout case is the GroupProtocol.CONSUMER mode. The CONSUMER mode maybe interact with the GroupCoordinator multiple times before reconciliation completed

The frequency of interaction is controlled by configuration group.consumer.heartbeat.interval.ms which default value is 5000ms. Those successful unit tests take at least 5 seconds to complete, so maybe we can reduce heartbeat interval.
After I set group.consumer.heartbeat.interval.ms to 1000ms, this problem has not occurred again on my computer. And running this unit test has become more faster.

@lianetm @chia7712   PTAL

Hello @xijiu , thanks for taking a look at this! Very interesting finding indeed. I expect this same issue is behind the flakiness on testMultiConsumerSessionTimeoutOnStopPolling too right? (Could you maybe validate locally for this one too?)
https://ge.apache.org/scans/tests?search.buildOutcome=failure&search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.tags=trunk&search.timeZoneId=America%2FToronto&tests.container=kafka.api.PlaintextConsumerPollTest&tests.test=testMultiConsumerSessionTimeoutOnStopPolling(String%2C String)[2]

@lianetm  Thanks for reply.
I think this PR will server boths.
Both testMultiConsumerSessionTimeoutOnClose() and testMultiConsumerSessionTimeoutOnStopPolling() will call the method runMultiConsumersSessionTimeoutTest()
  @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
  @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
  def testMultiConsumerSessionTimeoutOnStopPolling(quorum: String, groupProtocol: String): Unit = {
    runMultiConsumerSessionTimeoutTest(false)
  }

  @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
  @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
  def testMultiConsumerSessionTimeoutOnClose(quorum: String, groupProtocol: String): Unit = {
    runMultiConsumerSessionTimeoutTest(true)
  }

And the failure of method runMultiConsumersSessionTimeoutTest(boolean) is unrelated to the input parameters.
But to be honest, this flaky test is hard to reproduce on my mac , I ran many many times but only reproduced it once 😁.

4 unrelated test failures (failures exist in trunk). 3 already tracked. I filed https://issues.apache.org/jira/browse/KAFKA-18025.


Parsing exception when trying to ingest System.evtx

Hi there! Great tool, I got it to ingest Security.evtx and Application.evtx, but when I try to ingest System.evtx I always get a parsing error. I have a very basic understanding of programming logic, not nearly that about Python - I got most of it to work with your step-by-step on Dragos' blog and some Google-fu. How can I help diagnose, maybe even help correct, this parsing error?
oh! Found one on Elasticsearch's logs:
Caused by: java.lang.IllegalArgumentException: object field starting or ending with a [.] makes object resolution ambiguous: [.NETServiceMethod]

And rolling up the log, it seems every parsing error is caused because of this error.

@joaociocca: I'm going to try to run this down this week. If you do have any more context you can share or are hitting any other issues, let me know.

Checking to see if I can recreate the issue with any of the system logs from: https://github.com/sbousseaden/EVTX-ATTACK-SAMPLES

I remember the EVTX weren't enhanced by Sysmon, and they came from Application.evtx, Security.evtx and System.evtx. Sadly, since my investigation ended, I no longer have access to those files.

Also, dunno if you or anyone else would find it useful, but I made a little bulk loader! My first attempt at a Python script: https://github.com/joaociocca/evtxtoelk/blob/master/bulkevtx.py


JSONStream ctor misnamed

Description
JSONStream constructor is misnamed, possibly due to cut'n'paste creation.

Will you submit a PR?