Compiling admin assets ?

If I run yarn watch to build my frontend, I can't login the backend because some assets file will be missing and I need to run twill:build again in order to login backend.

@imknight the manifest file that mix uses indeed gets written over if you run your own mix for the front end. This removes the admin's own mix manifest pointers. To fix this all you need to do is require laravel-mix-merge-manifest in your webpack.mix.js. Like this:
const mix = require('laravel-mix');
require('laravel-mix-merge-manifest');

mix
    .js('resources/js/app.js', 'public/js')
    .sass('resources/sass/app.scss', 'public/css')
    .browserSync({
        proxy: 'site.test'
    })
    .mergeManifest();

Of course configured to your setup.
npm i --save-dev laravel-mix-merge-manifest

yup it work, thanks !


Exponential Regression Test Failing

x 1 of 134 tests failed:

  1) numbers should return a function to calculate the exponential regression of an array of numbers:
     AssertionError: 0.8491729985314138 == 0.8491729985314136
      at Context.<anonymous> (D:\Projects\Programming\Github\numbers.js\test\statistic.test.js:108:12)
      at Test.Runnable.run (D:\Projects\Programming\Github\numbers.js\node_modules\mocha\lib\runnable.js:196:15)
      at Runner.runTest (D:\Projects\Programming\Github\numbers.js\node_modules\mocha\lib\runner.js:344:10)
      at D:\Projects\Programming\Github\numbers.js\node_modules\mocha\lib\runner.js:390:12
      at next (D:\Projects\Programming\Github\numbers.js\node_modules\mocha\lib\runner.js:270:14)
      at D:\Projects\Programming\Github\numbers.js\node_modules\mocha\lib\runner.js:279:7
      at next (D:\Projects\Programming\Github\numbers.js\node_modules\mocha\lib\runner.js:227:23)
      at Immediate._onImmediate (D:\Projects\Programming\Github\numbers.js\node_modules\mocha\lib\runner.js:247:5)
      at processImmediate [as _immediateCallback] (timers.js:358:17)

Hey @mjhasbach I received this error as well on my local (a few tests w/in stats failed actually) but Travis is still reporting all green: https://travis-ci.org/numbers/numbers.js
There's an acceptable "error bound" for operations in numbers, numbers.EPSILON = 0.001. Given that this mismatch is within that range, it's ok. Need to update the tests to accommodate for that.


Update dependency versions

It looks like there's an issue with the java 8 stuff.  I think it's probably similar to something we saw in picard/gatk recently where one off our updated dependencies had a multirelease jar with releases newer than java 8 and it somehow blew everything up.  I'm going to merge the #177 pr and then try rerunning this on top of that?

Yeah, I'm still trying to work through things, better to merge #177 first 😄

Thank you, @lbergelson!


Request: pre-trained model?

I saw in issue #42 that you were considering providing the pre-trained model. +1 to that! If there's anything I can do to make that happen, let me know.

Hello,
I am thinking of it. There are quite some technical problems (mostly, need to adress incompatibilities of different versions of deepmedic, theano, cuda etc). Slowly getting there.
An interesting question here:
What kind of pretrained model would you be interested in and for what purpose? Eg a BRATS-trained model? What would you use it for? Compare against it on BRATS? Fine-tune it on other databases?
Any comments about potential usage would help me think of what to release that would prove actually useful in practice for users.
K


Revert "Don't block origin-less blob:-URLs in hosted viewer"

This reverts commit a6aca3cabe581319d93c862cb0b85f71580cacfd, since no version of Internet Explorer is supported any more.

/botio-linux preview

Thank you for removing the last few left-over IE bits!


fix: pfe-tabs issue with active border color on horizontal/wind (#1585)

Component updates: pfe-tabs
On horizontal/wind tabs, the active border is not maintaining its color (#06c) when clicking between tabs. The active state is being being overwritten by the focus state border.
Related issues

#1585

Preview

Link(s) to demo page(s) where this element can be viewed:

Demo page

What has changed and why

Removed host(:focus), css element from horizontal/wind tabs

Testing instructions

Go to https://patternflyelements.com/components/tabs/
Click on one of the tab elements in the horizontal/wind tabset
Correct color on active tab element bottom border

Browser requirements
Your component should work in all of the following environments:

[x] Latest 2 versions of Edge
[x] Internet Explorer 11 (should be useable, not pixel perfect)
[ ] Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
[ ] Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
[x] Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
[ ] Latest 2 versions of Safari
[ ] Android mobile device (such as the Galaxy S9)
[ ] Apple mobile device (such as the iPhone X)
[ ] Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist
Check off items as they are completed.  Feel free to delete items if they are not applicable.

[x] Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
[x] Browser testing passed.
[ ] Changelog updated.
[ ] Approved by designer.

Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the<EMAIL_ADDRESS>mailing list!

@bonjo7 Thanks for tackling this issue!  I've pasted the template into your description, please go through and fill that out when you get a chance.  We also need a changelog update from you when you're able, something like this at the top:
# 1.9.4 (TBD)

- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-tabs issue with active border color on horizontal/wind (#1585)

I have reviewed the code update and branch tested ✅

Hey @castastrophe thanks for the feedback, I have reviewed the above, one question should the change log just go at the top of the description?

It should go in the CHANGELOG-1.x.md file at the top of the file. Thank you so much!

Thank you @castastrophe , I have added to change log and noted for any future PR's from me


HTTP2Stream request handling appears to cut off exception messages

Hi,
We noticed that when we get a MessageRequest::onExceptionReceived callback, the exception message tends to look cut off. since this is often (always?) JSON, it leads to improperly formatted content.
It looks like this is due to how HTTP2Stream::m_exceptionBeingProcessed is used; as soon as it's non-zero length, HTTP2Stream::notifyRequestObserver assumes the message is complete and sends it to the request callback.

The issue is fixed in v1.1.0.  Thanks!


404 on attempting to export traces to jaeger

Describe the bug
404 on attempting to export traces to jaeger
To Reproduce
Steps to reproduce the behavior:

Install Go 1.11, docker, docker-compose
export GO111MODULE=on
git clone https://github.com/voutasaurus/octest
Read octest/set/test/run.sh
Run ./octest/set/test/run.sh
Wait for docker-compose to bring up services
In another terminal curl http://localhost:8080 (to hit test web server)
View in the docker-compose output

Error when uploading spans to Jaeger: failed to upload traces; HTTP status code: 404

Expected behavior
Traces successfully exported to Jaeger
Additional context
I have an opencensus demo app https://github.com/voutasaurus/octest using docker-compose with a simple http server exporting metrics to prometheus and traces to jaeger. Prometheus is working fine (metrics show up in the dashboard), but the jaeger exporter is complaining:
Error when uploading spans to Jaeger: failed to upload traces; HTTP status code: 404
I’ve followed the guides here and I still can’t figure out what I’m doing wrong:
• https://opencensus.io/guides/exporters/supported-exporters/go/jaeger/
• https://www.jaegertracing.io/docs/getting-started/

Fixed it.
I was pointing the exporter to :9411 as documented here https://opencensus.io/guides/exporters/supported-exporters/go/jaeger/
But I should have been pointing to :14268 as per the comment on the Endpoint field of the jaeger.Options (says // Endpoint is the Jaeger HTTP Thrift endpoint. rather than Zipkin thrift endpoint)


Live chat messages don't break for one word string

Some languages like Chinese and Thai don't use spaces.
Sometimes people love to send random gibberish spam chat.
There are also chat that contains emoji only (which is not being parsed by this plugin, resulting in the screen filled up with: :yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis::yougotthis:

Fixed in https://github.com/BanchouBoo/mpv-youtube-chat/commit/4b8d6d5d3ace40d467bc0ed75f3af2a1aefce161, there is now a message-break-anywhere option as well as a break-anywhere action to toggle/set the value from a keybind or the console.

Wow, thank you for your prompt response, highly appreciated that :+1:


"./images/logo.svg" instead of "/images/logo.svg" in main.phel line 14

currently, the elephant does not show up when phel-scaffolding is ftp'd onto somedomain.com and
http://somedomain.com/phel-scaffolding/src/web/index.php
is opened in the browser.
The proposal in the topic fixes this.

Changed @kloimhardt.
Thanks!


skip randomly failing e2e test

A test was added that broke tests. API is returning a 403, when it looks like it should not be.
Disabling test as this blocks other PRs.
Test will be reenabled once it works consistently.

@AlexSCorey I am working on this. The issue appears to be that the job is somehow in running state when the delete is triggered (even though I was checking for the job status to change to "successful". I'm investigating a fix


Target vocoder links to target "Eigen3::Eigen" but the target was not found.

hello,everyone.i met this erro. Target"Vocoder"links to target "Eigen3::Eigen" but the target was not
found.Perhaps a find_packages() call is missing for an IMPORTED target, or an ALIAS target is missing? How can i solve this,thank you

@doctor-xiang , hi, i got the same question,  any solution you can share? thank you.

@Maxxiey , when i export to CPU, i met this erro.

Hello, everyone!
I find solution for this problem for Ubuntu16
It seems target_link_libraries(vocoder wavernn Eigen3::Eigen) in CMakeLists.txt don't work in my version of eigen. I removed this line and use
add_definitions     ( ${EIGEN3_DEFINITIONS} )
include_directories ( ${EIGEN3_INCLUDE_DIRS} )
This source helps me https://stackoverflow.com/questions/53991812/cmake-find-package-not-working-for-eigen


Prevent unnecessary entries in history table when clicking Save or Saved

As an applicant
I want the saved button to not react to clicking
So that each time I hit the saved button, there isn't a new item in the history table
Description:
Make it so that when buttons say 'Saved' on the assessment pages, clicking on it does not resave and create a new entry in the history
Acceptance Criteria:

[ ] Clicking on 'Saved' button anywhere in the analyst portal does not save a new entry in the database history.  Only assessment pages show the 'Saved' button currently.
[ ] If no changes made to the form, 'Save' button does not save a new entry in history table.

{Page Name}
Screen
[wireframe 1]
[wireframe 2]

[ ] .

Page Behaviours

[ ] .
[ ] .
[ ] .

Validations

[ ] .
[ ] .
[ ] .

Actions

[ ] .
[ ] .
[ ] .

Not included:

.
.

Implementation Details

DB:

.
.

Middleware:

.
.

Frontend:

.
.

Tests:

.
.

Documentation:

.
.

I think the 2nd acceptance criteria isn't working as expected:

[ ]   If no changes made to the form, 'Save' button does not save a new entry in history table.

When I click save on a form where I haven't changed anything (upon first load), the saving shows up in the history table.
To replicate this, open any assessment page and without changing anything click on save.  Then see history table, you will see it show up there.

I noticed that someone changed the acceptance criteria to make it clear:

[ ] [If no changes made to the form, including first time opening the form, 'Save' button does not save a new entry in history table.
So when I expected that when I open a new assessment window that has never been changed before then I should not be able to save it in a way that triggers an entry into the history table.  But that is not the case.  Is this what you expected too?


Kong looping, with a 503

Chris Heald @cheald 17:42
Hey folks, I'm having some issues with 0.10.0rc3 - occassionally a request will 503 and go into an insane loop where it is re-requested dozens or hundreds of times and saturate nginx.
I'm trying to build openresty --with-debug so I can peek into the nginx internals and see what's going on, but doing so results in:
2017/02/07 16:41:21 [debug] /usr/local/openresty/bin/resty -V: 'nginx version: openresty/<IP_ADDRESS>'
2017/02/07 16:41:21 [debug] got ok: false, true, , nginx version: openresty/<IP_ADDRESS>
2017/02/07 16:41:21 [debug] OpenResty 'resty' executable not found at /usr/local/openresty/bin/resty
./kong/cmd/start.lua:34: ./kong/cmd/start.lua:20: could not find OpenResty 'resty' executable. Kong requires version <IP_ADDRESS> to <IP_ADDRESS>

That "got ok" line is me printing the result of pl_utils.executeex(cmd) as found in prefix_handler.lua:is_openresty
The "success" flag is coming back negative, even though: $? on running that command manually is 0. Any ideas?
(Side note: I'm suspicious that the request storming is due to the internal DNS resolver - we're targeting a route53 domain which performs weighted resolution to a pair of AWS ELBs with this - the ELBs change IPs regularly and I've noticed that the 503 storms happen when the TTL on the DNS record is due to expire. But I need a debug build to confirm that.)
Chris Heald @cheald 18:35
http://i.imgur.com/JBWEp6i.png
is what the storming looks like, FWIW - I've confirmed that the origin isn't down when this happens, but Kong seems to lose the ability to resolve requests to the backend. I dropped Varnish in front of Kong in always-pass mode so that I can introspect traffic and I'm observing some really weird behavior where requests with the same Kong correlation ID seem to be replayed dozens of times per second. You can see when HTTP 200 traffic drops to nothing, everything starts erroring. The error traffic is a multiple of the "normal" traffic which suggests to me that there's some kind of weird amplification thing happening where failed requests are being replayed over and over. This happens even when I set retries=0 in the API config.
Chris Heald @cheald 19:20
compiling openresty with --without-luajit-lua52 fixes the startup issue. Now on to the debugging.
Thijs Schreijer @Tieske 19:55
@cheald the only place with 503's in the code is here; https://github.com/Mashape/kong/blob/64f5e9b05d25c5778cc6db927abe7b2f317969cc/kong/core/balancer.lua#L276-L308
But that indicates that there should at least be log messages.
Chris Heald @cheald 19:56
Yeah, I found those, I'm pretty sure that's not it. I think this is an actual 503 off the backend for some reason, but I haven't been able to identify why yet, and even in that case I wouldn't expect a storm of retries to choke out kong
I've got full nginx debug logs of the issue now, though, I'm trolling through those
Thijs Schreijer @Tieske 19:57
I cannot find it anymore, but in the last days there was someone reporting some sort of loopback issue, where Kong would proxy the request to itself, and go into a loop. Until the uri (which was extended on each request) became to large and an error was returned.
Chris Heald @cheald 19:58
That's the behavior I'm seeing, yes
The headers are becoming too large, rather than the URI itself, but that seems to be the general pattern
Thijs Schreijer @Tieske 20:03
iirc he had something like uris=/ and upstream_url=http://somehost/testand then requested http://kong/test which kept appending /test to the uri in a loop
Chris Heald @cheald 20:04
Right now Kong is just a straight pass-through for this config - upstream URL doesn't do any path modification
Thijs Schreijer @Tieske 20:04
can you share the config?
api config
Chris Heald @cheald 20:04
yeah, sec
     {
      "uris": [
        "/"
      ],
      "id": "75a518ec-5bc7-43b3-b30e-f6351b6f73fc",
      "retries": 0,
      "preserve_host": true,
      "created_at":<PHONE_NUMBER>000,
      "upstream_url": "https://mashable-com-688160256.us-east-1.elb.amazonaws.com",
      "https_only": true,
      "strip_uri": false,
      "http_if_terminated": true,
      "name": "api.mashable.com",
      "hosts": [
        "api.mashable.com"
      ]
    },

Kong basically just dynamically sets the upstream, then passes that back to nginx to do the actual work, correct?
2017/02/07 18:50:51 [debug] 26351#0: *5256 connect to <IP_ADDRESS>:53, fd:75 #8003
2017/02/07 18:50:51 [debug] 26351#0: *5256 epoll add event: fd:75 op:1 ev:80002001
2017/02/07 18:50:51 [debug] 26351#0: *5256 http cleanup add: 00007F56C05AEEE8
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket connect: 0
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket network address given directly
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket resolve retval handler
2017/02/07 18:50:51 [debug] 26351#0: *5256 UDP socket 78
2017/02/07 18:50:51 [debug] 26351#0: *5256 connect to <IP_ADDRESS>:53, fd:78 #8004
2017/02/07 18:50:51 [debug] 26351#0: *5256 epoll add event: fd:78 op:1 ev:80002001
2017/02/07 18:50:51 [debug] 26351#0: *5256 http cleanup add: 00007F56C05AEFA0
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket connect: 0
2017/02/07 18:50:51 [debug] 26351#0: from head of free queue, alloc semaphore: 00007F56CE31C2C8
2017/02/07 18:50:51 [debug] 26351#0: http lua semaphore new: 00007F56CE31C2C8, resources: 0
2017/02/07 18:50:51 [debug] 26351#0: *5256 send: fd:75 34 of 34
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket calling receive() method
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket read timeout: 2000
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket receive buffer size: 4096
2017/02/07 18:50:51 [debug] 26351#0: *5256 lua udp socket read data: waiting: 0
2017/02/07 18:50:51 [debug] 26351#0: *5256 recv: fd:75 -1 of 4096
2017/02/07 18:50:51 [debug] 26351#0: *5256 recv() not ready (11: Resource temporarily unavailable)

This looks like a likely culprit - DNS lookups are failing
Is there an easy way to turn on logging of the internal DNS handler?
Thijs Schreijer @Tieske 20:55
It uses 2 libraries, the basic one from OpenResty, and on top a more high-level one (by us).
@cheald can you test it with the dns record set with ttl=0 ?
Chris Heald @cheald 20:57
Hm, I'll see if I can
I'm using DNS weighting to siphon off a portion of live traffic to test with
Thijs Schreijer @Tieske 20:58
here's why; the resty dns lib has a set of retries and timeouts, now the lib on top uses locking such that only one dns query is performed for any given name at the same time. When the result returns, all waiting requests will get the same dns answer and continue.
Might be that the lock is causing this when a query fails
test with ttl=0: this is an exception for the lock. When it is 0 there is a query for every incoming request, no locking.
Chris Heald @cheald 21:00
That seems plausible. I haven't figured out how to cause the error cascade at will yet - right now I'm basically just letting a small amount of traffic hit the endpoint until it falls over. Usually breaks inside of 30 minutes though.
The theory is that with ttl=0, we shouldn't see it break?
Thijs Schreijer @Tieske 21:01
exactly. By definition ttl=0 means 1 query per request, no locks
Chris Heald @cheald 21:01
Actually, bah, no, I can't set ttl=0. ELB maintains its own DNS
60 second TTL, I don't know that I can change that

@cheald still wondering though, the lock theory does not explain the looping...

So this IS actually related to DNS, but not as you might expect.
The architecture that we have for this test is:
api.mashable.com
  - 10% of traffic routed to https://kong-lb (an AWS ELB)
  - 90% of traffic routed to https://prod-lb (another AWS ELB)

kong:
  upstream_url: https://prod-lb
  preserve_host: true

The API definition:
      "uris": [
        "/"
      ],
      "id": "75a518ec-5bc7-43b3-b30e-f6351b6f73fc",
      "retries": 0,
      "preserve_host": true,
      "created_at":<PHONE_NUMBER>000,
      "upstream_url": "https://mashable-com-688160256.us-east-1.elb.amazonaws.com",
      "https_only": true,
      "strip_uri": false,
      "http_if_terminated": true,
      "name": "api.mashable.com",
      "hosts": [
        "api.mashable.com"
      ]

The idea is that we want some requests to api.site.tld to route to kong -> prod-lb (with the Host header set to api.site.tld). However, Kong seems to be resolving the backend name based on the host header, not based on the URL given in the upstream_url. I confirmed this by adding debug logging to kong.lua in Kong.balancer(), just prior to the set_current_peer call:
ngx.log(ngx.DEBUG, "assigning peer: ", addr.ip, ":", addr.port)

which results in:
kong.lua:240: balancer(): assigning peer: <IP_ADDRESS>:443 <-- this is the Kong ELB, not the upstream!

I also added logging to balancer.lua to enumerate target:
  ngx.log(ngx.DEBUG, "XXX - balancer execute")
  for k, v in pairs(target) do
    ngx.log(ngx.DEBUG, "XXX - ", k, ": ", v)
  end

which resulted in:
2017/02/08 02:06:25 [debug] 18107#0: *383 [lua] balancer.lua:250: balancer_execute(): XXX - host: api.mashable.com
2017/02/08 02:06:25 [debug] 18107#0: *383 [lua] balancer.lua:250: balancer_execute(): XXX - type: name
2017/02/08 02:06:25 [debug] 18107#0: *383 [lua] balancer.lua:250: balancer_execute(): XXX - retries: 0
2017/02/08 02:06:25 [debug] 18107#0: *383 [lua] balancer.lua:250: balancer_execute(): XXX - tries: 0
2017/02/08 02:06:25 [debug] 18107#0: *383 [lua] balancer.lua:250: balancer_execute(): XXX - port: 443

Clearly, the name being resolved is api.mashable.com which does predictably result in a feedback loop, rather than it resolving the IP for mashable-com-688160256.us-east-1.elb.amazonaws.com.
I'm digging into why this might be happening, but I can't imagine that this is intended behavior.

The issue seems like it may have been unintentionally resolved in 37e8ed30c68d592ddd54cd3ccf6b3ccffe453f1a - upstream_host = headers["host"] is no longer being set, and router.exec() now properly returns the upstream.

The fix is logical, but unintentional. I'll make sure to add a testcase.
@cheald thanks for debugging that! This is the best issue description and analysis I seen in many years of open source projects. You are now officially entitled to have some free Mashape 🍻 .
I'll keep this open until the test case is added.

I deployed HEAD of release/0.10.0 last night and let it run overnight as a test. Rock solid, no issues to report. Looking forward to RC4! 👍

I was looking at contributing a spec for this, but it looks like there's a test that already covers this in https://github.com/Mashape/kong/blob/release/0.10.0/spec/01-unit/12-router_spec.lua#L779-L780
Perhaps it just needs to be factored out a bit to explicitly test that the upstream is preserved, for self-documentation purposes?


failed to run example

platform: Ubuntu 22.04.2 LTS
rustc rustc 1.69.0 (84c898d65 2023-04-16)
 cargo run --example client_rpc_handler --features="ipc rpc"
get error
Error: Error { kind: Io, message: Some("No such file or directory (os error 2)") }

I changed  /tmp/busrt.sock to localhost:port and the error is:
Error: Error { kind: Io, message: Some("Connection refused (os error 111)") }

https://github.com/alttch/busrt/blob/9188419bdece0a58bd34b3434ad1635059b70739/examples/client_rpc_handler.rs#L76

Hi. You must have broker running on that socket path before running client examples.
You can use any one from broker / server examples or compile a sandalone busrtd binary using "server" feature.


new feature

create feature of likes

Hello @rajeshmn47, the idea of adding a "like" feature sounds great. However, I suggest that we prioritize the implementation of the login feature before working on the "like" feature. Do you think there's any other way we can implement the "like" feature without having the login feature first?

@rajeshmn47  Thank you for the suggest this issue. Once #65 issue will be done then we assign this issue to you or any other who wanted to work on this issue.

@rajeshmn47 we are almost completing the implementation of the registration and login feature, just some styling remaining and little changes on the site . Then we can start implementing this

ok

ok


Generate drawable SMILES from molecule fragment

Hi,
I am relatively new to Rdkit and I apologize if this isn't the right place to ask this. I am dealing with molecule fragments in SMILES notation, such as 'cC(=O)N(C)C', and when I try to draw the molecule, I get the following error: ERROR: non-ring atom 0 marked aromatic. Now, of course I could set sanitize=False in my Chem.MolFromSmiles() function, but then I lose information in my drawing.
Is there a way to intelligently interpret the SMILES fragment, and create the simplest molecule that is valid, and highlight the parts that were in the original fragment? So in the 'cC(=O)N(C)C' example, I would want the first carbon to be part of an aromatic ring, and for the actual 'cC(=O)N(C)C' fragment to be highlighted. Is this at all possible?
Other examples are more complicated and involve multiple aromatic rings, such as 'cnnc' (or perhaps both nitrogens here are part of the same aromatic ring?).
Best,
Aaron

Hi Aaron,
I think to do what you are looking for, using SMARTS is more suitable. I.e.
"[c]-C;X3N;X3[C;X4]",
"[c]-CH1N;X3[CH3]"
From my limited knowledge of SMILES, you can define fragments by having
dummy atoms at the connection points, i.e. "[*]C(=O)N(C)C"
Best,
Christos
Christos Kannas
On Thu, 25 Jul 2019 at 21:13, aaron-barbieriaghib<EMAIL_ADDRESS>wrote:

Hi,
I am relatively new to Rdkit and I apologize if this isn't the right place
to ask this. I am dealing with molecule fragments in SMILES notation, such
as 'cC(=O)N(C)C', and when I try to draw the molecule, I get the following
error: ERROR: non-ring atom 0 marked aromatic. Now, of course I could set
sanitize=False in my Chem.MolFromSmiles() function, but then I lose
information in my drawing.
Is there a way to intelligently interpret the SMILES fragment, and create
the simplest molecule that is valid, and highlight the parts that were in
the original fragment? So in the 'cC(=O)N(C)C' example, I would want the
first carbon to be part of an aromatic ring, and for the actual
'cC(=O)N(C)C' fragment to be highlighted. Is this at all possible?
Other examples are more complicated and involve multiple aromatic rings,
such as 'cnnc'.
Best,
Aaron
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/2564?email_source=notifications&email_token=AA4P6SUJ2MDZHQV6ASJOSHLQBICM7A5CNFSM4IG6BX3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBSFHGQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4P6SVBK3IVAUUEWVR2HG3QBICM7ANCNFSM4IG6BX3A
.

Aaron,
Depicting from a smiles fragment is problematic.  As you discovered, you can't actually make a molecule.  Using a smarts pattern helps somewhat, however you loose some important things, like knowing that a set of carbons were in a ring.
You CAN however, depict a portion of a molecule that has been extracted.
from rdkit.Chem import AllChem
m = AllChem.MolFromSmiles("Cc1ccncc1")
AllChem.Compute2DCoords(m)
path = m.GetSubstructMatch(Chem.MolFromSmarts("Ccccn"))
submol = AllChem.PathToSubmol(m, path)

It's not perfect, but works ok.

Thank you so much for the responses! Although I like the second approach, unfortunately, I don't have access to the original molecules from which the fragments were extracted. I was hoping it would be possible to "reconstruct" the simplest form of the molecule which the fragment could be embedded in. Oh well, thanks again for responding though!


Requires (or not) another server ?

Hi,
The pro/con table seems off as "in place migration" both requires and doesn't require another server at the same time....

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b05d11c1-26dd-7bfe-a93c-aee83c101298
Version Independent ID: c86c1628-4fb2-7cca-9f04-2d3cddfbe73b
Content: Microsoft Entra Connect: Upgrade from a previous version - Microsoft Entra
Content Source: articles/active-directory/hybrid/connect/how-to-upgrade-previous-version.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@pbox
Thanks for your feedback! We will investigate and update as appropriate.

@pbox
An in-place migration in the context of Azure AD Connect does not involve setting up a new server. Instead, it entails upgrading the existing Azure AD Connect server to the latest version. During this process, the existing server's configuration is migrated to the new version. This method is typically faster and simpler compared to a swing migration.
However, it's important to be aware that in-place migrations do come with certain risks. These risks include the potential for data loss or service interruption if issues are encountered during the upgrade process. Therefore, while in-place migrations can be convenient, they should be approached with caution, and proper planning and backups should be in place to mitigate potential problems.

@billmath
Could you please review add comments on this, update as appropriate.

@pbox
We are going to close this thread, if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.
#please-close


Rename images.openshift-cli to openshiftCli

The dash - in the name is not supported by helm, so we need to
rename it (using camelCase for example)
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

cc @Senjuti256


Better messages for parse errors performed when parsing riak_ql

Instead of returning a badmatch exception and stack trace, return an error message containing the invalid error message.
yecc does not give any usable information except for the token and token type e.g.
{select, <<"select">>}

Where the token type is the select atom. If the token is unknown then the type is just chars.

@borshop merge


Responsive Landing page

Hey! @Pjha72  can you label this PR as HACKTOBERFEST-ACCEPTED instead of
hactoberfest-accepted ? There is a typo I think from your side in the spelling hacktoberfest


Modify references to go-cfenv to point to local forked version

The go-cfenv repo has been forked to a local repo under the cloud-gov organization. The next step for that repo is to find all references to it and changing them in the corresponding repos.

Repos found are:
Stratos
sample-app
laboratory
s3-broker - already done
cg-dashboard
cg-deploy-kubernetes
kubernetes-broker
cg-deploy-elasticache-broker
cg-header-validator go-cfenv
cf-events
cg-deploy-kubernetes-broker


Reset performance insights

[Enter feedback here]
Hi, we would like to reset performance insights between performance load tests. Is there any option to do so? Maybe deleting some data from tables, etc...?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73fb9e85-9373-ea1a-2ab9-93967339d617
Version Independent ID: 1405577d-16e1-4b97-e9f3-48bb898ebe73
Content: Query Performance Insight - Azure Database for PostgreSQL - Single Server
Content Source: articles/postgresql/concepts-query-performance-insight.md
Service: postgresql
GitHub Login: @sunilagarwal
Microsoft Alias: sunila

@bilak We are checking this and will get back to you.

now I've found that it's possible to get insights by some date range, but it would be very helpful if it's possible to set it by some fields with datetime range not only by seletcing it in ui. It's strange that daterange changes when I change for example the type of metrics which I want to see.

@bilak The Performance insights are basically based on the Query Store that you create as given in document as well. Also please visit the Query Store concepts and Best practices for the same.
This will convey how to do the best usage of query store and performance insights. Hope this helps.

@bilak We are going ahead and closing this issue for now. Please let us know if you need any further help regarding this.


Capturing method call arguments with separate API method

in https://github.com/NagRock/ts-mockito/issues/16 were proposed fluent API for capturing arguments and setting return value. But this API is in conflict with https://github.com/NagRock/ts-mockito/issues/12
So after conversation with @michalstocki we thought about such solutions:

when(someObject.doSomething(anything())).thenReturn(3).thenCapture(captor); - but after implementing https://github.com/NagRock/ts-mockito/issues/12 this API would be illogical because we will be able to define more returning values with fluent API e.g. when(someObject.doSomething(anything())).thenReturn(3).thenReturn(4).thenReturn(5).thenCapture(captor); - thenReturn call order will have matter. So thenCapture does not fit here.
verify(someObject.doSomething(captor.capture())); - similar to JavaMockito version, but we decided that using verify API function is not best solution, maybe this will be added as option to be more compatible with Java version
when(someObject.doSomething(anything())).thenReturnAndCapture(3, captor) - this not looks nice, and arguments type checking will be impossible.
when(someObject.doSomething(anything(firstCaptor))).thenReturn(3); - on first sight looks nice, but capturing arguments should not have any conditions while here we can define e.g. between(3, 4, capture) - and this looks bad
capture(someObject.doSomething(captor)); - this looks best at all, we do not use conditions, we strictly says that we want to capture arguments

@NagRock thanks for great summary.
I have yet another idea that might be considered while introducing the capture() method. Definitely the most common usage of the capturing mechanism is to get the value of the most recent call. It states as follows assuming that we're going to implement the 5th solution:
const firstArgCaptor = new Captor();
const secondArgCaptor = new Captor();
capture(someObject.doSomething(firstArgCaptor, secondArgCaptor));

// ... some logic invoking someObject.doSomething(...)

const firstArgValue = firstArgCaptor.getLastCallValue();
const secondArgValue =  secondArgCaptor.getLastCallValue();
expect(firstArgValue).to.equal(expectedFirstArg);
// do something with the captured value:
secondArgValue();

As we can see, the syntax is quite verbose. I wish, I could do this within a several lines, for example:
const captorApplier = capture(someObject.doSomething(new Captor(), new Captor()));

// ... some logic invoking someObject.doSomething(...)

const [firstArgValue, secondArgValue] = captorApplier.getAll().map(c => c.getLastCallValue());
expect(firstArgValue).to.equal(expectedFirstArg);
secondArgValue();

It could be even shorter if the capture() could be called after invocation of the method (as verify() in Java Mockito), and assuming that the getLastCallValues() will map captors into it's values:
// ... some logic invoking someObject.doSomething(...)

const [firstArgValue, secondArgValue] = capture(someObject.doSomething(new Captor(), new Captor())).getLastCallValues();
expect(firstArgValue).to.equal(expectedFirstArg);
secondArgValue();

@michalstocki great idea! I've already implemented it on branch https://github.com/NagRock/ts-mockito/tree/issue/12
Syntax will be like you proposed:
[firstArg, secondArg] = capture(someObject.doSomething).last();
And then you will get two typed values firstArg and secondArg
And you will be able to get: first(), second(), third(), beforeLast(), last(), byCallIndex(5)

Wonderful! I like these short methods first(), last().
It's especially handy, that TypeScript is able to determine the argument types:
export class Bar {
    public doSomething(a:string, b:Bar, c:number):string {
        return 'done';
    }
}

const b:Bar = new Bar();
const arr = capture(b.doSomething).last();
arr[0] // TypeScript: string!
arr[0].charAt(0); // ok
arr[1] // TypeScript: Bar

Should be fixed in 2.0 version. Please reopen if something is still wrong.


pvlib.irradiance.disc not working

Hi,
I am receiving the following error when using the pvlib.irradiance.disc function
My code is:
dni = pvlib.irradiance.disc(solar_data['SWGDN'],solpos['zenith'],solar_data['DATETIME'],solar_data['PS'])
With the error being:
1358 """
1359 Estimate Direct Normal Irradiance from Global Horizontal Irradiance
1360 using the DISC model.
(...)
1429 dirint
1430 """
1432 # this is the I0 calculation from the reference
1433 # SSC uses solar constant = 1367.0 (checked 2018 08 15)
-> 1434 I0 = get_extra_radiation(datetime_or_doy, 1370., 'spencer')
1436 kt = clearness_index(ghi, solar_zenith, I0, min_cos_zenith=min_cos_zenith,
1437                      max_clearness_index=1)
1439 am = atmosphere.get_relative_airmass(solar_zenith, model='kasten1966')
lib\site-packages\pvlib\irradiance.py:98, in get_extra_radiation(datetime_or_doy, solar_constant, method, epoch_year, **kwargs)
96     RoverR0sqrd = 1 + 0.033 * np.cos(B)
97 elif method == 'spencer':
---> 98     B = solarposition._calculate_simple_day_angle(to_doy(datetime_or_doy))
99     RoverR0sqrd = (1.00011 + 0.034221 * np.cos(B) + 0.00128 * np.sin(B) +
100                    0.000719 * np.cos(2 * B) + 7.7e-05 * np.sin(2 * B))
...
-> 1325         raise integer_op_not_supported(self)
1326     result = self._time_shift(-other)
1328 elif isinstance(other, Period):
TypeError: Addition/subtraction of integers and integer-arrays with DatetimeArray is no longer supported.  Instead of adding/subtracting n, use n * obj.freq
Any help will be greatly appreciated.
Thanks.

@ang-endgame this is probably an issue with the data in solar_data. Can you post your question to the Discussion, with a short sample of the data, or to the pvlib google group? Happy to help there.


Passes tests but haven't driven yet.

This is a great cleanup. Nice job!

Both cancel and resume LGTM after minor bug fix: 3cfdec54aa035f3f|2022-07-18--17-01-20. Ready for review.

Thanks for the PR!


speech to speech model there?

❓ Questions and Help
I am looking for a pre-trained speech-to-speech model. Does this repo have such model?

Do you mean audio from one person in and in the voice of another person out? No, you won't find this here. If you are looking for something like that, use STT/ASR for speech2text and then TTS for text2speech.

Do you mean audio from one person in and in the voice of another person out? No, you won't find this here. If you are looking for something like that, use STT/ASR for speech2text and then TTS for text2speech.

STT/ASR for speech2text. It should be from one lang to another. Say, english is input audio and output is french text.

Check these examples:
https://github.com/pytorch/fairseq/blob/master/examples/speech_to_text/docs/simulst_mustc_example.md


Recreate PR 3873

Recreate PR 3873
Remove empty headings from CCM release notes (please refer to release notes style guide on Confluence. Subheadings are not necessary when there is no content of that type in the release).

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66035e0d1376ed15e6235998--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6603647c742733259b0dff0b--harness-developer.netlify.app

Merging to avoid further delays (PR 3873 was created last October). Please follow up with me or create a new PR if there are any further changes needed.


Drop kernel configuration access

Proposed Changes
Drop accessing /boot/config-$(uname -r) or /proc/config.gz:

It was placed there mainly because some of the HA OS images had different routing capabilities, but it was already fixed by the OS team (see https://github.com/home-assistant/operating-system/issues/3026 and https://github.com/home-assistant/operating-system/pull/3027).
The other kernel config check is TCPMSS related, but that results only in a warning, so we can test whether that TCPMSS manipulation fails and emit a warning then, and do not check the kernel config in advance.

Related Issues
really fixes #325

Ready for review, a few dozen people installed it and no issues reported (up until now).


Changelog

I would appreciate a documentation of changes, probably just a typical CHANGELOG.md file.
Currently, it's hard / risky to just upgrade to the latest version, for example when digging out a previously stale project that depends on react-spring. It should be possible to get an overview of what has happened since the version one is currently using.

I had one but found it troublesome to maintain. I think i'm trying github tag releases, like so: https://github.com/drcmda/react-spring/releases/tag/v5.8.0

Ah, great, didn't check there. Thanks.

I just made that ;-) But i'll try to keep it that way from now on ...


GitHub Enterprise support

Discussed in https://github.com/Cian911/gomerge/discussions/49

Originally posted by Sam13 September  2, 2022
Does gomerge support GitHub enterprise installations?
I couldn't find any parameter to pass the base URL.

@Sam13


 Hos/warden webvests("coats") are fine so they would be better parenting probably.
Screenshots

https://github.com/space-wizards/space-station-14/blob/d18dba982b9e4fc6ee3d036af9cae98b962f0031/Resources/Prototypes/Entities/Clothing/Shoes/boots.yml#L76
Parenting skill issue, needs order swapping.

Is this fixed now?


How can I change the API baseurl?

For some reason, OpenAI API cannot be accessed directly in some areas.
Set the Proxy is good
But how can I change the API address?
https://api.openai.com -> https://api.example.com
Looking forward to your reply.

Oh, I seem to find the solution:
config.BaseURL =  "https://api.example.com/"


[Question] Nuget version 2.0.1

Hi,
The nuget version is currently 2.0.1, does this mean the features of the roadmap for version 2 are implemented ? For instance Velocypack ? In the docs I cannot find anything on that.
Thanks

Hi @G012481632 , the roadmap file is outdated and the current v2.0.1 doesn't match the roadmap file, which was drafted a long time ago. I'll make a note to update this file.

does this mean the features of the roadmap for version 2 are implemented ?

The major HTTP APIs have been implemented. If you spot one that's not implemented, feel free to open an issue (if one doesn't already exist).

For instance Velocypack ?

Velocypack isn't implemented. There is currently no plan to implement it, but we welcome contributions. We discussed it and wasn't considered a priority given the performance enhancement provided by new versions of the HTTP protocol.

Thanks @DiscoPYF for the answer.
Just one more question : As you mentioned, newer versions of HTTP are faster, but isn't the faster (de)serializing of the objects the main reason one would prefer Velocypack ?  If you continuous read from and write to the db, that should have a significant impact on performance (and memory).

You're right that serialization also incurs a performance cost. If you have specific performance requirements, you  could create a custom implementation of IApiClientSerialization that uses System.Text.Json.


Improve detection of the target architecture on Apple platforms.

This PR moves checking the CMAKE_OSX_ARCHITECTURES variable before checking the path of the C compiler. Likely fixes detecting the correct architecture when cross-compiling to arm64 from a x64 machine.

Thanks for the fix!


Capture One leftovers

Hey, recently I've deleted Capture One trial with BCU 4.5 version and here are the leftovers I found undetected after uninstallation:
Folders:
C:\ProgramData\Phase One (empty)
C:\Users\focus\AppData\Local\CaptureOne (has nested folders and files)
C:\Users\focus\AppData\Local\Phase_One (has nested folders and files)

Registry:
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.cocatalogdb
now has no values but had default string value "CaptureOneCatalog" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.cocatalogtemplate
now has no values but had default string value "CaptureOneCatalogTemplate" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.col
now has no values but had default string value "CaptureOneSession" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.col45
now has no values but had default string value "CaptureOneSession" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.col50
now has no values but had default string value "CaptureOneSession" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.col60
now has no values but had default string value "CaptureOneSession" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.comask
now has no values but had default string value "CaptureOneMask" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.copreset
now has no values but had default string value "CaptureOnePreset" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.cos
now has no values but had default string value "CaptureOneSettings" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.cosessiondb
now has no values but had default string value "CaptureOneSession" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.cosessiontemplate
now has no values but had default string value "CaptureOneSessionTemplate" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.costyle
now has no values but had default string value "CaptureOneStyle" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.costylepack
now has no values but had default string value "CaptureOneStylePackage" before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Applications\CaptureOne.exe
had nested key with value with path to the capture one executable before uninstallation

HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\RADAR\HeapLeakDetection\DiagnosedApplications\CaptureOne.exe

HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Tracing\CaptureOne_RASAPI32

HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Tracing\CaptureOne_RASMANCS

HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Image File Execution Options\captureone.exe

HKEY_USERS\S-1-5-21-2081619299-1437623788-1181410189-1001\Software\Phase One
now empty but it had nested key
HKEY_USERS\S-1-5-21-2081619299-1437623788-1181410189-1001\Software\Phase One\Capture One
before uninstallation

I believe leftovers scan may perform way better if it will make pre-process search before running an uninstallation to capture such cases.

Closing this issue since it's resolved except for one part that is handled in #162.


auto-recipe-update: change delay from 300 to 1800s

This is to not have overlapping PRs as the test mechanism will otherwise check all differences to the main and this will cause conflicts.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Successfully created backport PR for kirkstone-next:

#10380

Successfully created backport PR for scarthgap-next:

#10381

Successfully created backport PR for styhead-next:

#10382


Fix /authors/ endpoint for team14

Before

After

I get a // at the end of the github url

Ahh... fixed by checking if github handler is non-empty


feature: support multiple metadata servers

In addition to etcd, Mooncake Transfer Engine now supports redis to keep metadata. To use this, you should install libhiredis-dev first and compile Mooncake with -DUSE_REDIS=ON. Developers can also inherit the TransferMetadataImpl class to implement their own metadata storage logic.
This patch also fix problems in #12 (numa binding) and #20 (missing cudaMemcpy).

LGTM. Will test today to check if changing from etcd to Redis affects the vllm integration logic.

Please change the title to "[TransferEngine][feature] support multiple metadata servers"
Add documentation about installing hiredis (e.g., apt-get install libhiredis-dev)


Question: extract landmarks 2D

Hi,
Would it be possible, using the eos-py module only, to extract the 2D representations of the landmarks within the surrey face model (for one particular image)?
If possible just some pointers would really useful!
My aim would then be to train iterate this process over iBug dataset and train a dlib shape predictor.

https://github.com/patrikhuber/eos/issues/140
See this thread ^^


Implement a DatabaseArchiveWriter and add to pruneOldestBlobSidecars

PR Description
Initial change to add the concept of DatabaseArchiveWriter to pruneOldestBlobSidecars method. The initial implementation is a NoOp that returns true. See #8513 for additional tasks. With this change it sets up the structure. Future changes will implement a DatabaseArchive interface and required configuration options to configure where/how the archive is written.
Fixed Issue(s)

fixes #8513
Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

welcome to MethodInputParametersMustBeFinal world 😄


TWKB parser

Parse geometries from TWKB binary format
Test: query data from CARTO SQL API using PostGIS as_twkb() function, show it on map
Size comparison with point data,

src: 150K points: DB: 24M (with attributes), telemetry points
geojson 14M, zip 670K
hex-encoded twkb json (no attrib)- 5M, compressed 180K -> about 3x win.

With polygons :

src: 600 complex polygons, DB - 150M, (countries+, nt packages)
geojson (no attr) 193 M, gz 81M
hex-encoded twkb json (no attrib) - 46M, gz 23M ->about 4x win
hex-encoded WKB - 275M (sic!), gz 135M
base64-encoded twkb - 33MB json, gz 23M
geopackage - 138M (incl attributes), gz 108M

Tagging as 'idea-maybe-future' - useful for Carto SQL API integration when large datasets need to be downloaded. But currently no real use cases.


[Data Source] Drag and Drop file sending

Drag & drop is an intuitive interaction users expect
Smoother file sharing improves overall UX
it has been asked a lot

JTBD: As a user, I want to easily share files with my assistant using familiar interactions like drag & drop.

@Yutcam moving this to roadmap as it requires a redesign of Folders IMO.


Feature request: Support for running snyk iac test

It would be useful to configure the vscode extension to run snyk iac test instead of snyk test when developing terraform, cloudformation or kubernetes.

Hi, we have plans to bring IaC via Language Server to the extension, but no fixed date yet.

Hi, since GitHub issues are not officially monitored by Snyk support, we will be disabling "Issues" tab on this repository very soon.
Please raise the current issue directly by contact Snyk Support on the web or emailing us at<EMAIL_ADDRESS>


[Enhance] grc hook experience is not good.

This problem will be solved, such as the hook cannot be executed on the windows and the execution error is not clear.

fixed on v1.2.2.


baseLayer parameter in CesiumWidget constructor doesn't seem to work as described

The options.imageryProvider of the CesiumWidget constructor is deprecated since v1.104. The suggested replacement for this is to use the option.baseLayer. However, reading the documentation of the CesiumWidget it says that the constructor has a seperate baseLayer parameter you can provide to the CesiumWidget. Unfortunately when I provide this parameter with the value 'false' it doesn't work and it loads the default Cesium baselayer.
Looking at the actual constructor in the source code there only seems to be two parameters (container and options) and the baseLayer parameter is missing.
I tried using options.baseLayer in my TypeScript code, but this causes type errors saying that baseLayer isn't part of the options:
 return new CesiumWidget(this.elementId, {       terrainProvider,       baseLayer: false,     });
causes
TS2345: Argument of type '{ terrainProvider: CesiumTerrainProvider | undefined; baseLayer: boolean; }' is not assignable to parameter of type '{ clock?: Clock | undefined; imageryProvider?: false | ImageryProvider | undefined; terrainProvider?: TerrainProvider | undefined; terrain?: Terrain | undefined; ... 20 more ...; msaaSamples?: number | undefined; }'.   Object literal may only specify known properties, and 'baseLayer' does not exist in type '{ clock?: Clock | undefined; imageryProvider?: false | ImageryProvider | undefined; terrainProvider?: TerrainProvider | undefined; terrain?: Terrain | undefined; ... 20 more ...; msaaSamples?: number | undefined; }'.
Only when I provide the options.baseLayer as follows in my code it seems to work:
return new CesiumWidget(this.elementId, {       terrainProvider,       baseLayer: false,     } as any);
Expected behaviour:
I can provide the baseLayer parameter as separately from the options parameter and the default Cesium baseLayer isn't loaded.
Actual behaviour:
I have to provide the baseLayer as part of the options (as options.baseLayer), which causes errors in the types and seems to be contrary to the documentation.
Sandcastles:
Expected to work
What actually works
Version used: "@cesium/engine": "^2.4.1",

Hi @astrengers, good catch. This is a documentation error. We'll get it fixed before the next release. Thanks!


Will there (or can there) also be profile-guided optimisation?

TODO mentions some "binary profiles" (assuming that's saved data after profiling). Can them also be used at compile time for optimisation?

I think PGO is out of scope for this crate. If you're interested in profile guided optimization in Rust, I would look at https://github.com/rust-lang/rfcs/issues/1220


Pass storage system status to user

I should make test() call before commencing dataset download to let API user (data stage service) know that storage system is down and can not be downloaded.
Also on the dataset detail page, I should display an alert if the dataset is stored on the storage system that is currently unavailable (again, either call test() or use current health status)

When a resource is down and tries to see Raw Output, the user is simply greeted by a generic error message. We should remedy this.


API automation improvements: build-snapshot

Next improvements introduced:

libraries for API usage were updated to newer versions
support of Java annotations for API methods declaring was added

Please note that due to dependencies update package name was changed from com.jayway.restassured to io.restassured which will require imports updates in test projects

SonarQube analysis reported 3 issues

 2 critical
 1 major

Watch the comments in this conversation to review them.

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.


updating ad to 1.3 in manifest

Signed-off-by: Amit Galitzky<EMAIL_ADDRESS>Description
Updating Anomaly Detection ref to 1.3 instead of main.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1723 (c35e6e2) into main (acc3d5f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1723   +/-   ##
=========================================
  Coverage     94.78%   94.78%
  Complexity       17       17
=========================================
  Files           169      169
  Lines          3525     3525
  Branches         26       26
=========================================
  Hits           3341     3341
  Misses          181      181
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc3d5f...c35e6e2. Read the comment docs.


Misleading operator* for the required fields

What is the intent for the operator* in the sbepp::uint8_t and all other base types? From my perspective it is misleading. Every time when I do cout << *msg.field(), I think I did not check for null.

Every time when I do cout << *msg.field(), I think I did not check for null.

Well, then do cout << msg.field().value();.
Optional/required representation classes are wrappers and they should provide access to the underlying value. operator* is just a short way to access that value. Optional wrapper was strongly influenced by std::optional interface that provides value()/operator*() for the same purpose and required wrapper followed the same approach because value() is needed anyway and operator*() is just a nice shorthand for it.

For the required fields instead of operator* you can have operator T and value() function.

Nope, operator T is a nightmare, I'm strongly against it, can't remember last time I used it. In theory, required wrappers can have only value() that returns mutable reference but I think it's not worth it. It's longer to type and will introduce some divergence between optional and required wrappers.

In this case your type wrapper should mimic the behaviour of the C++ base types.

Or return uintX_t directly and do not use your types.

BTW, enums can have null value too.
        <type name="uInt8NULL" description="uInt8NULL" presence="optional" nullValue="255" primitiveType="uint8"/>
        <enum name="AggressorSide" encodingType="uInt8NULL">
            <validValue name="NoAggressor" description="No Aggressor">0</validValue>
            <validValue name="Buy" description="Buy">1</validValue>
            <validValue name="Sell" description="Sell">2</validValue>
        </enum>

Would be nice to have null_value() member function somehow for the enums too.

I'm lazy to google examples for you. The one I can give you right now is when you have operator int, your class becomes implicitly comparable to any ints and other built-in types that are convertible to/from it. It basically breaks incapsulation.
The approach sbepp uses is strong types, wrappers that provide restricted interface to the underlying value without implicit conversions to make things compile-time safe. I don't want speed(int16) field be comparable with length(uint32) one.

Misleading operator* for the required fields

It's not misleading if you read the docs. Wrapper is just a container for a value, and operator* is perfectly fine (and short) to access it.

no asserts while reading the optional fields if they are empty/null. Library should follow the std::optional approach. If field is optional, then force user to check for NULL before you read the value.

Again, optionals in SBE are not the same as std::optional. The latter physically doesn't have a value to return when empty, the former always has a value, even if empty, and it's not an error to get it. Here, semantics is up to client, don't want empty values? Then write if-statement or use value_or. In my experience, there were cases when I need to work directly with underlying values so one of sbepp goals was to not impose any semantic restrictions on the client.

The approach sbepp uses is strong types, wrappers that provide restricted interface to the underlying value without implicit conversions to make things compile-time safe. I don't want speed(int16) field be comparable with length(uint32) one.
...
Again, optionals in SBE are not the same as std::optional.

I believe that approach overcomplicates the SBE parser implementation and makes the users' experience not as smooth as it could be. I believe the more things you reuse from the standard C++, the easier is the entrance for the user. Users know what is std::optional and what is int32_t. Users know the std::nullopt variable. The C++17 (so C++20) has many good primitives.
From other side it may be painful to learn new types. Especially if they do not behave as expected and the users have to read the documentation. Believe me, I'm on their side now :)
As an input users have int/double/string. So as an output they expect is int/double/string too.
  int -> SBE -> int

In case if an output is something else, then you force them to learn the things they probably do not have to learn. Again, what user wants is to put int and get int. They do not need an intermediate value.
You said sbepp::uintX_t defines min, max and other things. Ask the question to yourself, does the user really need them? Those values are needed for the validation only. So, instead of min/max they would probably want to have a message1::validate() member function instead.

As an user, following is what I'm looking for the encoder:
auto msg = message1_encoder{};
msg.optional(123);
msg. madatory(123);
auto exchanges = msg.exchanges(3);
exchanges[0].name("CME");
exchanges[1].name("NYSE");
exchanges[2].name("CBOE");

socket.send(data(msg), size(msg));

As an user, following is what I'm looking for the decoder:
void on_message(header hdr)
{
  switch(hdr.templateId())
  {
    case message1_decoder::TemplateId:
    {
        auto msg = message1_decoder{hdr};
        std::cout << (msg.mandatory() > 10 ? "WTF???" : "Ok, got it") << "\n";
        if(auto opt = msg.optional()) std::cout << *opt << "\n";
        for(auto&& exch: msg.exchanges()) {
            std::cout << exch.name() << "\n";
        }
    }
    break;
  }
}

I believe that approach overcomplicates the SBE parser implementation and makes the users' experience not as smooth as it could be.

Again, the goal of this project is not to provide "smooth user experience" but to implement SBE standard as close as possible to C++. I personally believe that SBE should be only about raw data without min/max/null values, so what? I don't have a control over SBE specification so I just obey their rules (mostly). All your words about what users need should be addressed to SBE, not to its implementation. Btw, another goal of sbepp was not to restrict users with semantics whenever possible but to provide a basic interface that allows them to use any strategy they need. Want to throw on empty optional? Write a trivial function that does that. Don't need min/max? Just add * and work with naked values.

I believe the more things you reuse from the standard C++, the easier is the entrance for the user. Users know what is std::optional and what is int32_t. Users know the std::nullopt variable. The C++17 (so C++20) has many good primitives.

I already told you that std::optional is different, not mentioning that it has freedom to use exceptions. Yeah, users know int and other users also know that it causes tons of problems. That's why strong types were invented.

From other side it may be painful to learn new types. Especially if they do not behave as expected and the users have to read the documentation.

Learning something new can be different, it's just life.

Figure out what is the minimum buffer size needed to encode the message with 3 entries in the group. In case of nested groups, the total amount of nested group items must be passed to the function.

If you want some feature, create a separate issue, don't mix everything together. Btw, such function was initially considered and discarded due to number of reasons, that doesn't mean it can't be considered again with a more detailed investigation.

From other side it may be painful to learn new types. Especially if they do not behave as expected and the users have to read the documentation.

Learning something new can be different, it's just life.

I appreciate you did read all the details of the SBE specification and asked the questions to the authors of that specification. Just do not force your users to take that path. You do not learn ASM to write the code in C++. You do not learn the theory of how quick sort is implemented in order to call the std::sort() function.
Let me tell the simple thing, you would agree I believe. It is tremendous hard to present something complicated in the way so kids can understand it. It is hard to come with the simple interface for the thing which is not trivial. I heard the story that the vendor of the Saab car had crashed the business just because their cars were way too complicated to use. Even though they were really great. I think there are even more examples like that.
The C++ API interface (so that other interfaces) IS already a documentation. You come with the names for the functions/classes/variables/methods. When one reads your code, they read the story. If user must read something else (even comments), I believe with all my heart, the author failed to do the proper interface. The interface must be designed in such way so it is easy to use it and is hard to misuse.
If you're succeed in making good interface, your users will never suffer and they will use your product with the pleasure. They will feel you are taking care of them.
I'd say even more. I worked on the CME MDP3/iLink project for a long time both on the exchange side and on the trader side. I used real-logic. It was terrible. So I've created my own parser like sbepp. I just cannot use it on the project I'm working now. So, after a 2 years I left that project and now I do not remember SBE protocol details.
You say, they have to learn. Do they? Do they need that knowledge to do their business? I learnt SBE and after 3 years I do not remember it just because that knowledge is somewhere very deep in my brain.


Relax / revert @stylistic/comma-dangle to ease migration from standard

As both https://github.com/neostandard/neostandard/issues/78#issuecomment-2191373271 and https://github.com/fastify/fastify/pull/5509 mentioned, the enforcing of comma-dangle (that is one of two style related modernizations since<EMAIL_ADDRESS>is a bit too prescriptive and maybe even controversial.
Related rule:
https://github.com/neostandard/neostandard/blob/3130ca90602bac53df18000c9a104ed2536ce85b/lib/configs/modernization.js#L23-L29
As mentioned in https://github.com/fastify/fastify/pull/5509#discussion_r1632056940 the equivalent in<EMAIL_ADDRESS>was:
'@stylistic/comma-dangle': ['error', {
  arrays: 'never',
  objects: 'never',
  imports: 'never',
  exports: 'never',
  functions: 'never',
}],

https://github.com/neostandard/neostandard/issues/78#issuecomment-2191373271 suggests adding a configuration for the "legacy" behavior, something like noCommaDangle: true or legacyCommaDangle: true, but I don't like adding too many options.
Another option would be to simply disable the rule completely and conclude that there is no consistent approach to this within the community anymore.
A third is to revert it completely, but that would make projects that then override it not be neostandard compliant anymore.

I think its safe to say that the current state of it violates the mission statement (#7) of Being a descriptive (not prescriptive) linting of common and good practices

Some thoughts:

Enforcing this by default results in many, some would say irrelevant, changes when applied to code base already using standard
I understand why people like it, but I really don't think it adds enough utility to overcome the aesthetics
I agree that adding options is a path toward "what's the point?" There should be as few options as possible

@jsumners Would you vote for removing the rule or to reverting to forbidding dangling commas?

I think I would vote for removing the rule under the assumption that it would be the most permissive.

Can we leave it as a default-off option similar to semi rules?

People migrating to neostandard are warned about that style change from standard. And as such have implicilty agreed upon.
But I do not see why neostandard could not offer:

modernisation -> neostandard rules
standard -> legacy standard rules

On the implementation side, I do not think making a literal with boolean options to add is a good idea. It will make the life of users and maintainers better if:

a style option is added
style can be:

modernisation ->  neostandard rules (default)
standard -> standard rules

The existing boolean seems to be orthogonal enough to the base style configuration to stay as is. But that can also be folded into the style namespace, such as modernisationsemi.

@jsumners @uzlopak Added a PR that disables the contentious ones: https://github.com/neostandard/neostandard/pull/139

I personally prefer the dangling comma, but projects like undici would be about adding 3211 missing dangling commas. I dont think that this is nice for existing projects, basically pointing the blame to the one who migrates :-P

@Uzlopak Lets find a way to reintroduce them in a less intrusive way: #143

I personally prefer the dangling comma, but projects like undici would be about adding 3211 missing dangling commas. I dont think that this is nice for existing projects, basically pointing the blame to the one who migrates :-P

Given that eslint will add it on document save, this is the only real argument I can make against it. Adding it to projects that have not been using it results in way too many changes.


🐞[Bug]: Different theme slider

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The slider for the theme has different styles on the main page and on the other side pages
Expected behavior
The site should be uniform and have same style of theme toggle on each page
Add ScreenShots

What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hi @aditya-bhaumik which slider is supposed to be on all pages [the top one or bottom one in the issue images]?

@Jasleen1210 top


Feed_dict slow in Google compute engine

_preds = sess.run(preds, feed_dict={img_placeholder: X})
while running in computer it took around 1-2 seconds while running in compute engine cost more than 50 s

Hi @PIRANAVARUBAN, please fill the issue template including an example to reproduce the issue or else we won't be able to properly help you. Thanks!

It has been 29 days with no activity and the awaiting response label was assigned. Is this still an issue?

We are closing this issue for now due to lack of activity. Please comment if this is still an issue for you. Thanks!


Link to github.io documentation

The skeletonframework.github.io page could be linked from the skeletonframework repo. (I usually look in the area immediately at the top of the repo view, where it now says only "A simple responsive framework for mobile friendly development.")

Done... and done.


Remove obsolete packages

Remove the following packages from package.json
async
cheerio
url-regex
xss-filters
gulp-dest

Mind if I take this one?

All yours ✨

Guys I an absolutely new to this. freecodecamp site is just not loading on my macbook air. All other sites are working properly except this one. I am yet to take my first lesson. Apprently this site is loading normally on my android phone. Please Guide !!!!!

https://www.freecodecamp.com Does this link not work for you?

No it takes a minute to execute every click :(
On Aug 31, 2016 12:50 PM, "Steven T Ancheta"<EMAIL_ADDRESS>wrote:

https://www.freecodecamp.com Does this link not work for you?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/10395#issuecomment-243679285,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUW2WAqm-U1Tj-Z41hDDBPVUn30cZRdAks5qlStLgaJpZM4Jwm7p
.

Have you tried opening it in other browsers such as FireFox or Chrome?

I tried with Safari and Chrome….dont have fire fox

On 31-Aug-2016, at 1:05 pm, Steven T Ancheta<EMAIL_ADDRESS>wrote:
Have you tried opening it in other browsers such as FireFox or Chrome?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/FreeCodeCamp/FreeCodeCamp/issues/10395#issuecomment-243682425, or mute the thread https://github.com/notifications/unsubscribe-auth/AUW2WPe1Kra5q4zfMs8bG2FvITi4FGWqks5qlS7UgaJpZM4Jwm7p.

And the site is unresponsive on both... Unfortunately @iprugb, I don't have a macbook so I can't really help you out further. Would you mind asking on the FreeCodeCamp main chat: here?

I really recommends to try firefox as @stancheta prefer.
-- You have a problem? Find the solution. Now you got two problems.


When updating metadata, it should be patched (merged), not overwritten

Describe the bug
In #1287 we have a situation where

an sshnpd program using newest version of dart client SDK was creating keys with a value in the new ivNonce metadata
an older version of the sshnpd program was also creating (updating) those keys and, since it was unaware of new metadata, it did not send it in the batch update request to the server
the server did not merge data appropriately

Steps to reproduce
See #1287
Expected behavior
The Update and UpdateMeta verb handlers should

retrieve the current AtMetadata, if any
set values on it if and only if they have been sent by the client in the update command (i.e. they are present in the verb params)
and that modified AtMetadata object is what should be saved back to the keystore

There is code in the persistence layer which has some intent along these lines; however - it is not possible to do this entirely in the persistence layer, as the persistence layer cannot know the difference between a field which was explicitly set to null by a client and sent as such in the update command, versus a field which was not sent by the client and thus has an implicit value of null
Screenshots
No response
Smartphones
No response
Were you using an atApplication when the bug was found?
No response
Additional context
No response

I will work on this in PR59 if nobody else picks it up, but I would be very grateful if someone else could pick it up as soon as possible

The changes are released into Canary c3.0.30

The changes are released into production in p3.0.30. Closing the issue.


Can't get iOS interactive notification to work

I copied/pasted the code from the README to create actions/categories, then registered like so:
pushPlugin.registerUserNotificationSettings(
    // the success callback which will immediately return (APNs is not contacted for this)
    function() {
        pushPlugin.register(tokenHandler, errorHandler, {
            "badge": false,
            "sound": true,
            "alert": true,
            ecb: ecbHandler
        });
    },
    // called in case the configuration is incorrect
    errorHandler,
    {
            // asking permission for these features
            types: [
                pushPlugin.UserNotificationTypes.Alert,
                pushPlugin.UserNotificationTypes.Badge,
                pushPlugin.UserNotificationTypes.Sound
            ],
            // register these categories
            categories: [
                readCategory,
                otherCategory
            ]
    }
);

The message sent by the server looks something like this:
{"aps": {"alert": "Test alert", "category": "READ_CATEGORY"}}

I receive the notifications but they have no buttons. Can you see anything obvious that I'm doing wrong? I've set breakpoints in the native code and it looks like the categories are getting added. Is there anything else you could suggest I look at while debugging?
Thanks

@EddyVerbruggen Any advice for me?

@brad,
The payload looks correct. You may want to examine the category definition for readCategory and otherCategory and their actions. Also, are you running this on iOS8+?

@EddyVerbruggen I finally got around to revisiting this. I managed to get it working by commenting out lines 260 and 261 in PushPlugin.m. When those lines run my notifications don't have buttons. I must be doing something wrong, right?


Bugfix/tdi 38737 pk chunking different result

What is the current behavior? (You can also link to an open issue here)
PK chunking feature sometimes returns different results on the same data.
https://jira.talendforge.org/browse/TDI-38737
What is the new behavior?
Wait until all batches "Completed", if some of them "NotProcessed" or "Failed" - throw an exception with appropriate message.
Time to wait for "Complete" batches set to 10 minutes with increasing step 5 seconds.
Salesforce gets only 15 API calls for batch status update.
More details can be found in official documentation:
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...


Clarification on completion

As earlier section lists DALL-E model as well, probably makes sense to clarify that "completion" can be either in a text or an image format. Once we'll enable image input for multimodal use, we may need to update similar part on the "prompt" definition :-).

For Cognitive Services content:
#assign: @aahill
#assign: @patrickfarley
#assign: @nitinme
#assign: @mrbullwinkle
#assign: @laujan
#assign: @eric-urban
#assign: @jboback

Hi @LazaUK , I think the term "completion" still refers exclusively to text, as the model's text answer completes the total body of text. For images, we're using "image generation". I think this section should stay as-is because text completion is something that does require a little explanation, and introducing image generation at the same time may confuse its meaning.

Thank you for the update, @PatrickFarley - it seems that we use "image completion" as a term in Microsoft publications as well: https://www.microsoft.com/en-us/research/wp-content/uploads/2017/01/structure_completion_small.pdf, and GenAI tries to complete / polish new images out of noise. But if you believe that the current doc already delivers the message, sure - fine with me as well 😉. Thank you.

@LazaUK Yeah we might want to revisit this when Dalle is capable of in-painting, like in the paper you linked

Closing for now per https://github.com/MicrosoftDocs/azure-docs/pull/109737#issuecomment-1579317196


Webmail: system/classes/webmail class

Add class to generate the webmail views

https://github.com/YaWK/yawk.io/commit/c91b292563f7ebd7149beb911269b591999a1b70: added basic attechment handling (work in progress)

Webmail will be complete reworked during 2023. Some decisions about the framework needs to be made - closed for now.


Add TeachersPayTeachers

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.

[x] Company name
[x] Company description
[x] Company location
[x] GitHub link
[x] How Elixir is used
[x] Sorted alphabetically

Awesome addition @shantiii, thank you!


Presentation: Fix paged request result accumulation

There was a possibility to end up in infinite loop when accumulating result of paged requests if first request returns less items then total and requested count.

Yes I was expanding tree and encountered the case where nodes request return total count - 4 and only 3 items.

Yes I was expanding tree and encountered the case where nodes request return total count - 4 and only 3 items.

Do we have a backlog item for this?

Yes I was expanding tree and encountered the case where nodes request return total count - 4 and only 3 items.

Do we have a backlog item for this?

Yes I have added item to backlog for this.

@mergifyio backport release/3.0.x


Setup docusaurus on master branch

Master branch PR for docusaurus
Will generate docs for v0.4.x (next) release
Details in website/README.md

closing in favor of https://github.com/projectriff/projectriff.io/pull/91


Missing field in macros/src/vertex.rs

latest rust nightly(rustc 1.0.0-nightly (92ff8ea52 2015-01-27 23:08:13 +0000)) complains about the field 'associated_types' missing from the vertex macro definiton at line 14.

i would do a pull request and do it myself, but i'm not familiar enough with git. sorry

Fixed in #400


[5.10 🍒][Explicit Module Builds] Restore prior behavior of consuming .h dependencies of binary module dependencies directly, instead of attempting to load their PCH

Cherry-pick of https://github.com/apple/swift/pull/69109
• Release: Swift 5.10
• Explanation: We will now only record these dependencies in CAS mode, because we require explicit PCH tasks to be produced for imported header of binary module dependencies. In the meantime, in non-CAS mode loading clients will consume the .h files encoded in the .swiftmodules directly.
Followup changes to SwiftDriver will enable explicit PCH compilation of such dependenceis, but for the time being restore prior behavior for non-CAS explicit module builds.
• Scope of Issue: Explicit module builds
• Risk: Minimal, this change affects only code paths for explicit module builds, which are not yet default.
• Origination: Explicit Module Build feature development and addition of CAS-specific functionality.
Resolves rdar://116006619

@swift-ci test

@swift-ci test

@swift-ci test and merge

@swift-ci test and merge

https://github.com/apple/swift-driver/pull/1464
@swift-ci test

https://github.com/apple/swift-driver/pull/1464
@swift-ci test Windows platform


Empty response when service under load

The DelayedOutputStream apparently is not flushed and I get empty response from time to time.
def handle(path: String = ""): Action[RawBuffer] = Action.async(parse.raw(maxRequestSize)) { implicit request =>
val delayedOutput = new DelayedOutputStream
val replyPromise: Promise[Message] = Promise.apply()
dispatchMessage(extractMessage, delayedOutput, replyPromise)
replyPromise.future.map { outMessage =>
  val publisher = StreamConverters.asOutputStream().mapMaterializedValue(os => Future {
    **delayedOutput.flush()**
    delayedOutput.setTarget(os)
  }).runWith(Sink.asPublisher(false))

  Result(
    header = ResponseHeader(200, Map.empty),
    body = HttpEntity.Streamed(Source.fromPublisher(publisher), None, Some(outMessage.get(Message.CONTENT_TYPE).asInstanceOf[String]))
  )
}

}

Fix proposal: https://github.com/margussipria/play-guice-cxf/pull/3

I changed the handle and it resoled the issue. I hope it helps others.
def handle(path: String = ""): Action[RawBuffer] = Action.async(parse.raw(maxRequestSize)) { implicit request =>
val delayedOutput = new DelayedOutputStream
val replyPromise: Promise[Message] = Promise.apply()
dispatchMessage(extractMessage, delayedOutput, replyPromise)

replyPromise.future.map { outMessage =>

  val inputStream: PipedInputStream = new PipedInputStream(chunkSize)
  val outputStream: PipedOutputStream = new PipedOutputStream(inputStream)

  Future {
    delayedOutput.flush()
    delayedOutput.setTarget(outputStream)
    outputStream.close()
  }

  val publisher = StreamConverters.fromInputStream(() => inputStream, chunkSize)
    .toMat(Sink.asPublisher(false))(Keep.right)
    .withAttributes(ActorAttributes.supervisionStrategy(decider)).run

  Result(
    header = ResponseHeader(200, Map.empty),
    body = HttpEntity.Streamed(Source.fromPublisher(publisher), None, Some("text/xml"))
  )
}

}


[Feature] java.lang.NoSuchMethodError occurred when I use pulsar plugin with pulsar client v2.8.1

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
When I use pulsar plugin with pulsar client v2.8.1 in my application. I've got java.lang.NoSuchMethodError such as below.
The  root cause is in pulsar client v2.8.1, org.apache.pulsar.client.impl.MessageImpl has changed the code.
In pulsar client V2.8.1: org.apache.pulsar.client.impl.MessageImpl
private final MessageMetadata msgMetadata;
public static  MessageImpl create(MessageMetadata msgMetadata, ByteBuffer payload, Schema schema) {
//...... other code
}
In pulsar client other version such as v2.7.1
private MessageMetadata.Builder msgMetadataBuilder;
public static  MessageImpl create(MessageMetadata.Builder msgMetadataBuilder, ByteBuffer payload, Schema schema) {
//...... other code
}
ERROR 2021-11-18 22:46:35:070 XNIO-1 task-16 InstMethodsInter : class[class org.apache.pulsar.client.impl.ProducerImpl] before method[sendAsync] intercept failure
java.lang.NoSuchMethodError: org.apache.pulsar.client.impl.MessageImpl.getMessageBuilder()Lorg/apache/pulsar/common/api/proto/PulsarApi$MessageMetadata$Builder;
at org.apache.skywalking.apm.plugin.pulsar.PulsarProducerInterceptor.beforeMethod(PulsarProducerInterceptor.java:75)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
at org.apache.pulsar.client.impl.ProducerImpl.sendAsync(ProducerImpl.java)
at org.apache.pulsar.client.impl.ProducerImpl.internalSendAsync(ProducerImpl.java:292)
at org.apache.pulsar.client.impl.ProducerImpl.internalSendWithTxnAsync(ProducerImpl.java:363)
at org.apache.pulsar.client.impl.PartitionedProducerImpl.internalSendWithTxnAsync(PartitionedProducerImpl.java:191)
at org.apache.pulsar.client.impl.PartitionedProducerImpl.internalSendAsync(PartitionedProducerImpl.java:167)
at org.apache.pulsar.client.impl.TypedMessageBuilderImpl.sendAsync(TypedMessageBuilderImpl.java:103)
at org.apache.pulsar.client.impl.TypedMessageBuilderImpl.send(TypedMessageBuilderImpl.java:82)
at org.apache.pulsar.client.impl.ProducerBase.send(ProducerBase.java:63)
at com.yumchina.payhub.writedb.producer.WriteDataUtils.writeDB(WriteDataUtils.java:69)
at com.yumchina.payhub.core.service.impl.BillOrderServiceImpl.saveBillOrderInfo(BillOrderServiceImpl.java:200)
at com.yumchina.payhub.core.service.impl.BillOrderServiceImpl$$FastClassBySpringCGLIB$$4169bb1a.invoke()
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:750)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:93)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
at com.yumchina.payhub.core.service.impl.BillOrderServiceImpl$$EnhancerBySpringCGLIB$$940b1e43.saveBillOrderInfo()
at com.yumchina.payhub.core.controller.BillOrderController.saveBillOrderInfo$original$eMC0LdiO(BillOrderController.java:98)
at com.yumchina.payhub.core.controller.BillOrderController.saveBillOrderInfo$original$eMC0LdiO$accessor$ioTRKrn1(BillOrderController.java)
Use case
Pulsar plugin can work normally.
It can support pulsar client v2.8.1.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

According to the history, only 2.2 to 2.7 are on the tested list. Check this. https://github.com/apache/skywalking-java/blob/a7a4faabb158ea8322170e3c7cae0210a8c4e7b4/test/plugin/scenarios/pulsar-scenario/support-version.list
@codelipenghui Would you like to take a look here?

I will take a look, please assign to me.

@wallezhang Thanks, please ping me if need help on this part.

@wallezhang Thanks, please ping me if need help on this part.

Pulsar client has changed protocol code generator, so MessageMetadata class doesn't have Builder inner class. I decide to create two new modules, one is called pulsar-common that is used for extracting the same logic between v2.7 and v2.8, and another is called pulsar-2.8.x-plugin that is used for supporting pulsar client of version 2.8.x. Old pulsar-plugin module is only for v2.7. What do you think?

Generally, unless they are really common, we don't recommend adding this kind of package.
This is not about technology, just because users may ignore this package should br included, or confuse about when should exclude, which could cause false bug report.

Generally, unless they are really common, we don't recommend adding this kind of package.
This is not about technology, just because users may ignore this package should br included, or confuse about when should exclude, which could cause false bug report.

The only difference between v2.7 and v2.8 is the logic of adding properties on the producer side. On version 2.7.x we can add properties by MessageMetadata.Builder class, but the class was removed on version 2.8, so we should use other method to add properties.

OK, if this is the only gap, then common module seems making sense.

OK, if this is the only gap, then common module seems making sense.

OK, thanks for your advice.

OK, if this is the only gap, then common module seems making sense.

OK, thanks for your advice.
Hi there, I'd like to know the planned completion time of pulsar-2.8.x-plugin, therefore I can make a upgrade plan for pulsar client(I rollback to pulsar client 2.7.1 for now).

OK, if this is the only gap, then common module seems making sense.

OK, thanks for your advice. Hi there, I'd like to know the planned completion time of pulsar-2.8.x-plugin, therefore I can make a upgrade plan for pulsar client(I rollback to pulsar client 2.7.1 for now).

I think this depends on when skywalking-java releases version 8.9.0. I will finish it in this week and submit a PR.


Compilation Error

Hello it seemed like everything installed correctly, but when I try to compile the "trivial.cpp" file, I get the following undefined reference errors:
/tmp/ccx3BoPz.o: In function main': nn.cpp:(.text+0x83): undefined reference toNabo::NearestNeighbourSearch::createKDTreeLinearHeap(Eigen::Matrix const&, int, unsigned int, Nabo::Parameters const&)'
nn.cpp:(.text+0x10d): undefined reference to `Nabo::NearestNeighbourSearch::knn(Eigen::Matrix const&, Eigen::Matrix&, Eigen::Matrix&, int, float, unsigned int, float) const'
Can you encountered this bug before?
I already had Eigen and Boost installed, so I do not know what else is required

@ramirezaa how do you compile this file? Usually this should be done as part of the normal build process so if you say "everything installed correctly" then I presume the examples were also build. Can you let me know the command you want to use to build the example?

@simonlynen I compile with the following command:
g++ trivial.cpp -o runTrivial

The examples were built succesfully, but when I try to compile the errors pop up. Did I forget to include the name of the library?

You will need to link to the library libnabo too. Prefer to use the cmake
build system which should build the example for you.
On Sun, Apr 19, 2015, 21:53 ramirezaa<EMAIL_ADDRESS>wrote:

@simonlynen https://github.com/simonlynen I compile with the following
command:
g++ trivial.cpp -o runTrivial
The examples were built succesfully, but when I try to compile the errors
pop up. Did I forget to include the name of the library?
—
Reply to this email directly or view it on GitHub
https://github.com/ethz-asl/libnabo/issues/30#issuecomment-94308922.

I can compile trivial.cpp & usage.cpp with Cmake. Although, I'm trying to compile my own program by properly linking to the correct library. I do the following:
g++ myFile.cpp -L/usr/local/lib -lnabo

But I still get errors. What is the best way to compile my own program?

What are the errors you get now?

I actually get a long list of errors, but here since it seems to simply repeat here is the first part:
/usr/local/lib/libnabo.a(kdtree_cpu.cpp.o): In function `std::vector<float, std::allocator<float> >::_M_fill_initialize(unsigned long, float const&)':
/usr/include/c++/4.8/bits/stl_vector.h:1216: undefined reference to `GOMP_loop_guided_start'
/usr/local/lib/libnabo.a(kdtree_cpu.cpp.o): In function `Nabo::KDTreeUnbalancedPtInLeavesImplicitBoundsStackOpt<float, Nabo::IndexHeapBruteForceVector<int, float> >::knn(Eigen::Matrix<float, -1, -1, 0, -1, -1> const&, Eigen::Matrix<int, -1, -1, 0, -1, -1>&, Eigen::Matrix<float, -1, -1, 0, -1, -1>&, int, float, unsigned int, float) const [clone ._omp_fn.2]':
/home/aramirez39/Desktop/libnabo/nabo/kdtree_cpu.cpp:302: undefined reference to `GOMP_loop_guided_next'
/home/aramirez39/Desktop/libnabo/nabo/kdtree_cpu.cpp:299: undefined reference to `GOMP_loop_end'
/usr/local/lib/libnabo.a(kdtree_cpu.cpp.o): In function `Nabo::KDTreeUnbalancedPtInLeavesImplicitBoundsStackOpt<float, Nabo::IndexHeapBruteForceVector<int, float> >::knn(Eigen::Matrix<float, -1, -1, 0, -1, -1> const&, Eigen::Matrix<int, -1, -1, 0, -1, -1>&, Eigen::Matrix<float, -1, -1, 0, -1, -1>&, Eigen::Matrix<float, -1, 1, 0, -1, 1> const&, int, float, unsigned int) const [clone ._omp_fn.3]':
/home/aramirez39/Desktop/libnabo/nabo/kdtree_cpu.cpp:329: undefined reference to `GOMP_loop_guided_start'
/home/aramirez39/Desktop/libnabo/nabo/kdtree_cpu.cpp:334: undefined reference to `GOMP_loop_guided_next'
/home/aramirez39/Desktop/libnabo/nabo/kdtree_cpu.cpp:329: undefined reference to `GOMP_loop_end'

You will need to compile with openmp support or disable openmp in libnabo:
Compile your code with openMP:
g++ myFile.cpp -fopenmp -L/usr/local/lib -lnabo -lgomp

Disable openMP in libnabo
Comment this line: https://github.com/ethz-asl/libnabo/blob/master/CMakeLists.txt#L52

Thank you! That fixed it! I'll compile with openmp.


Development of this library

Are there any plans to expand on this library, for example, to add support for gzip / xz decompression.
Many people (including myself), find libarchive more complicated than it needs to be. I believe that if this library was expanded upon, it could be a suitable alternative.
Regards.

I have no plans to expand this library. I wrote it to practice C. If you would like to expand upon it, feel free to open pull requests.


CRITICAL:autopilot:PreArm: EKF2 still initialising error, can arm using RC controller however

This is a really bizare problem. I put my drone down and let it rest, after trying this python script
from dronekit import connect, VehicleMode, LocationGlobalRelative
import time

print("Connecting to drone...")
vehicle = connect('/dev/serial0', wait_ready=True, baud=57600)
print("Connected.")

while not vehicle.is_armable:
	print("Waiting for drone to be armable...")
	time.sleep(0.5)

print("Arming Motors...")
vehicle.mode = VehicleMode("GUIDED")
vehicle.armed = True

while not vehicle.armed:
	print("Waiting for arming")
	time.sleep(0.5)

print("Armed")

print("Taking off...")

vehicle.simple_takeoff(1)

while True:
	print(" Altitude: ", vehicle.location.global_relative_frame.alt)
	# Break and return from function just below target altitude.
	if vehicle.location.global_relative_frame.alt >= aTargetAltitude * 0.95:
		print("Reached target altitude")
		break
	time.sleep(0.25)

Which is basically taken from their tutorials, i get the error "CRITICAL:autopilot:PreArm: EKF2 still initialising" and cannot arm. When i try arming using an rc connection it works fine, as well as when usb connected to qgroundcontrol. Any suggestions?
I'm using a pixhawk connected via serial port to rasp pi. My pixhawk is connected only to the motors and pi. No gps. I'd post this on the ardupilot forums but i only get this issue with dronekit.

This was solved by using GUIDED_NOGPS


Fixes storage of ExecutionOrder on Update

[1] fixes #1024
Before this commit, when a workitem was updated, the execution_order would automatically get set to 0 because of wrong handling of execution_order. This commit aims to fix it. Now, if a workitem is just updated (and not reordered), its execution_order is not changed.

@baijum do you mean a test case which would update the workitem and test that the execuion order is not changed, right?

@baijum do you mean a test case which would update the workitem and test that the execuion order is not changed, right?

Yes.

@baijum sounds right. I will write the test case.

Codecov Report

Merging #1025 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   61.93%   61.93%
=======================================
  Files          98       98
  Lines        8423     8423
=======================================
  Hits         5217     5217
  Misses       2686     2686
  Partials      520      520

Impacted Files
Coverage Δ

workitem/workitem_repository.go
65.89% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410cde9...cb23768. Read the comment docs.


Allow adding more metadata to user context

Apparently the Bugsnag setUser method only accepts three params: id, name and e-mail. Feature request: allow custom metadata, like the Sentry.setUserContext method.

I believe it's possible on other platforms because I see this image on Custom Filters page and it has a custom subscription_level field:

Stack Overflow question: link

Current solution:
Bugsnag.notify(error, report => {
  report.addMetadata('user', 'hello', 'world')
  return report
})

But it would be much better if it was incorporate on the setUser method.


Notes boxes incomplete

The contents of the two purple Notes boxes on this page need to be fleshed out into complete sentences.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 149712ed-bfe4-9255-5121-b8d105cc9898
Version Independent ID: b51a9f6c-d0c0-fb16-e409-0e59e8c4717b
Content: DShow Bridge implementation guidance for UVC devices - Windows drivers
Content Source: windows-driver-docs-pr/stream/dshow-bridge-implementation-guidance-for-usb-video-class-devices.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @barrygolden
Microsoft Alias: bagold

Updated the first note to clarify that the MJPEG  is only decompressed once in FrameServer and then the uncompressed translated media formats are offered to multiple possible applications.
The second note was removed and inserted as a comment in the sample code.