Fix Quarkus Issue with CRD Registration

There is an issue with de-serialization for conversion hooks with Quarkus:
When a conversion controller is created a based on the mappers the related custom resources are registered using the fabric8 client API:
https://github.com/java-operator-sdk/admission-controller-framework/blob/3a2019cdbcd9783678613b29cb91c066046b458b/core/src/main/java/io/javaoperatorsdk/webhook/conversion/Utils.java#L22-L25
This is called when the controller is created:
https://github.com/java-operator-sdk/admission-controller-framework/blob/3a2019cdbcd9783678613b29cb91c066046b458b/samples/quarkus/src/main/java/io/javaoperatorsdk/webhook/admission/sample/quarkus/conversion/ConversionControllerConfig.java#L16-L20
However this does not seems to be working (/picked up) by Quarkus. To reproduce see tests:
https://github.com/java-operator-sdk/admission-controller-framework/blob/3a2019cdbcd9783678613b29cb91c066046b458b/samples/quarkus/src/test/java/io/javaoperatorsdk/webhook/admission/sample/quarkus/conversion/ConversionEndpointTest.java#L26-L34
which are calling the edpoints:
https://github.com/java-operator-sdk/admission-controller-framework/blob/3a2019cdbcd9783678613b29cb91c066046b458b/samples/quarkus/src/main/java/io/javaoperatorsdk/webhook/admission/sample/quarkus/conversion/ConversionEndpoint.java#L29-L44
The expected behavior would be that in ConversionReview.ConversionRequest.objects are de-serialized properly, not into GenericKubernetesResource  but into MultiVersionCustomResource.
It is not working neither for async and/or sync endpoints. Interesting is if both tests are run, the second one passes. So eventually the configuration is getting picked up.
It works for Spring boot tests:
https://github.com/java-operator-sdk/admission-controller-framework/blob/3a2019cdbcd9783678613b29cb91c066046b458b/samples/spring-boot/src/test/java/io/javaoperatorsdk/webhook/sample/springboot/conversion/ConversionEndpointTest.java#L37-L46

Thanks. I'll try and have a look this week

The problem here is that the test code relies on an ObjectMapper that is likely not the same as the one used by the Kubernetes Client.
Essentially the test is posting to a ConversionReview to REST Endpoint which implicitly means that the default ObjectMapper of Quarkus comes into play (see this).
A simpler test that shows the exact same problem would be the following:
  @Inject
  ObjectMapper mapper;

  @Test
  void jacksonTest() throws IOException {
    ObjectReader reader = mapper.reader();
    ConversionReview cr = reader.forType(reader.getTypeFactory().constructType(ConversionReview.class))
            .readValue(this.getClass().getResourceAsStream("/conversion-request.json"));
    List<HasMetadata> objects = cr.getRequest().getObjects();
    assertThat(objects).hasSize(2).allSatisfy(h -> assertThat(h).isInstanceOf(MultiVersionCustomResource.class));
  }

This test will fail for the exact same reason: Jackson is not configured properly, so the de-serialization results in the the objects field not using the proper deserializer.
My guess as to why the test works the second time, is that your code or the k8s client code registers a deserializer with the default ObjectMapper.
Long story short: There is nothing wrong with the Quarkus code in this case :)

Thing is if I add this it works:
https://github.com/java-operator-sdk/admission-controller-framework/blob/440a0e5f055d647868970cce95837867f3a8893e/samples/quarkus/src/main/java/io/javaoperatorsdk/webhook/admission/sample/quarkus/conversion/CustomResourceDeserializationCustomizer.java#L11-L21
But that calls the same static code that is also called when creating the conversion controller:
https://github.com/java-operator-sdk/admission-controller-framework/blob/440a0e5f055d647868970cce95837867f3a8893e/core/src/main/java/io/javaoperatorsdk/webhook/conversion/ConversionController.java#L29-L30
The Deserializer is set on the class level:
https://github.com/fabric8io/kubernetes-client/blob/f63fa5faf65787ee31841ce5f9d93ccb8af31280/kubernetes-model-generator/kubernetes-model-core/src/main/java/io/fabric8/kubernetes/api/model/KubernetesResource.java#L22-L24
So according to my (limited knowledge) of jackson, this should be picked up, and it is picked up just not in case the static part is extended in the later way.

Thing is if I add this it works:
https://github.com/java-operator-sdk/admission-controller-framework/blob/440a0e5f055d647868970cce95837867f3a8893e/samples/quarkus/src/main/java/io/javaoperatorsdk/webhook/admission/sample/quarkus/conversion/CustomResourceDeserializationCustomizer.java#L11-L21

Yeah, but that is the expected behavior. That's the way users are supposed to customize the ObjectMapper provided by Quarkus.

But that calls the same static code that is also called when creating the conversion controller

Sure, but that likely happens to late

Sure, but that likely happens to late

Hmm but its when the service is initialized that is used by controller.
Ok, will probably end up writing a little extension.
Thank you very much for help! Will close the issue after PR merged.

Thank you very much for help! Will close the issue after PR merged.

Sure thing! Register a  customizer in an extension is definitly the way to go


Invalid access: Can not convert empty value.

I am unable to login using TogglDestop OSX version 7.3.177. I get the error Invalid access: Can not convert empty value.

This is already fixed in master with 98121dc5f4f1d9b7c0b701787f490a0c885755ba but not released. Clearing the local cache would be a temporary fix until this is released. We plan to release it to beta channel today.

Thanks @IndrekV , that fixed it the issue :+1:

For anyone else having this issue follow this guide: Clearing the local data from Toggl Desktop

This is also fixed in the latest stable windows release. (7.3.199)


Error when creating Angular Email Password app

create-supertokens-app (v0.0.23) lets you quickly get started with using SuperTokens!

Choose your tech stack and the authentication method, we will create a working project that uses SuperTokens for you.

? What is your app called? supertokens-test
? Choose a frontend framework (Visit our documentation for integration with other frameworks): Angular
? Choose a backend framework (Visit our documentation for integration with other frameworks): Node.js
? What type of authentication do you want to use? Email Password

✅ Finished setting up folder structure!

⛔ Setup failed!

Error: npm ERR!
 code ERESOLVE

npm ERR!
ERESOLVE unable to resolve dependency tree

npm ERR!

npm ERR!
 While resolving<EMAIL_ADDRESS>npm
ERR! Found<EMAIL_ADDRESS>npm
 ERR! node_modules/react
npm ERR!
<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm
ERR!   node_modules/supertokens-auth-react

npm
ERR!     supertokens-auth-react@"latest" from the root project
npm ERR!

npm ERR!
 Could not resolve dependency:
npm
ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm
ERR! node_modules/react-dom
npm
 ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/supertokens-auth-react
npm ERR!     supertokens-auth-react@"latest" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm
 ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

npm ERR! See /home/david/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/david/.npm/_logs/2023-01-28T08_28_41_694Z-debug-0.log

Error: If you think this is an issue with the tool, please report this as an issue at https://github.com/supertokens/create-supertokens-app/issues

$ npm -v
8.19.2
$ node -v
v19.4.0

Thanks for raising this issue. @nkshah2 can have a look at this.

Hey @davidpanic we updated the boilerplate apps to fix this issue, please try again. Closing this issue for now but feel free to re-open it if the issue persists

Seems to be working now, although the command still reports its version as v0.0.23, you might want to bump that.

The version of the CLI is not affected by the boilerplate code change.


Add notes about negative offsets used in read/write filesystem functions

Should close #3676

Let me know if this should target something other than the v1.x branch. Not familiar with the workflow in this project.


Dynamically generated content - editor not working

I have a web page that has several textareas, each of which use bootstrap-markdown.  This all works fine.  I also have an "Add" button on the page that dynamically generates another textarea.  After the new text area is generated it needs to have bootstrap-markdown too so I call the markdown function:
 insert.find("textarea[id='TemplateActivity_Description']").markdown();

This does attach the markdown toolbar, etc.  So I know it's sorta working.
Unfortunately, most of the functions don't work.  Bold, Heading and Preview (for example) don't work (they do nothing and generate no javascript errors in the console).  Interestingly, some things partly work.  For example, if I click the "link" item int he toolbar it prompts for the URL -- but then doesn't modify the content.
I'm pretty stumped.  Any ideas what might be wrong?

I would assume you haven't load the dependency libraries yet. Check again the doc, especially at note section.

Really?  Even though other instances of the same component work fine on the same page?


Rename library to use "addons" everywhere

Closes #4

Looks like there are some failures at CI, and this needs formatting and a test fix. I also opened up #73, which has it's own quirks, but would replace the Jest test suite with web-test-runner and Mocha (Mocha is quite similar to Jest in application)

Cool. I ran the format and I will merge it after that. I don't fully understand how tests are working and it seems they are going to be replaced anyways with your PR. We can come back to this once we have the suite established.


Component wrapper that IOS can identify as containers

I would love to be able to simply have access to a component that IOS devices could recognize as a component when using that option on the rotor. Not sure if that would be easy to implement with what you have built here, but I'm very interested in your work since IOS screen reader accessibility with React Native is pretty terrible out of the box.

Hello @deggertsen,
I have never worked with a rotor, but I read and got your idea. I am going to check the rotor API, I think there can be a solution or workaround. I guess it takes some days for investigation, and some days for creation. I will write my investigation back, when I found something and try to create a lib.  Aprox estimation is a week.
Thank you for writing the idea here, I really appreciate it. It really helps me to understand what I can add also, and how to improve ReactNative a11y.
Best Regards,
Artur Kalach
By my estimations it can take a week.

Thanks for your kind reply. Just in case it helps, this is the documentation that Apple provides for what I'm talking about.
https://developer.apple.com/documentation/objectivec/nsobject/uiaccessibilitycontainer
It doesn't seem like React Native has a way to use this currently.

Hello @deggertsen ,
I am still researching about UIAccessibilityContainer and roter, and it seems that I have a lack of knowledge about it.
The docs say that we can use UIAccessibilityContainer, but it's not clear what we should it use for, and it seems possible to add UIAccessibilityContainer to RN, but I am not sure about api what/how and where.  If you could describe the issue or provide example it could speed up the process.
Right now I am researching different places, and try to provide a result in some time.
Thank you in advance,
Best Regards,
Artur Kalach

Hello @deggertsen,
I check rotor, read a lot about different things, and probably got your issue.
There is a solution, but I need to improve and publish it. I think it can be posible to do it this week.
I hope you are checking this thread,
Artur Kalach

Sorry I missed your last message. I'm glad to hear you found a potential solution! I look forward to seeing it and trying it out. Let me know!
Thanks!

Hello @deggertsen ,
I finished implementation of UIAccessibilityContainer logic, and can share the results with you: https://github.com/ArturKalach/react-native-a11y-container
NPM package here: https://www.npmjs.com/package/react-native-a11y-container
Could you check if you need exactly this logic?
I am currently uncertain about the release plan for the react-native-a11y library. It's possible that I may include this feature in the next library release. As for now, it makes sense to explore the option of releasing separate libraries dedicated to specific accessibility features.
Thank you in advance for checking, and for the idea
Artur Kalach

I will check it out soon! I've been out on vacation and am just getting back.

It works! This has a lot of potential for making react-native apps more accessible on IOS devices. Thanks so much for your efforts putting this together.

Hello,
I am glad to hear that. If you need any other a11y feature for iOS or Android don't hesitate to share it.
I have some plans, but it would be better to implement something that is needed for someone)
Thanky you for collaboration,

Hello,
I am glad to hear that. If you need any other a11y feature for iOS or Android don't hesitate to share it.
I have some plans, but it would be better to implement something that is needed for someone)
Thanky you for collaboration,


Fix more models

To solve #37521

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-search-documents


i want to disable background

i want to disable background in BlueIndicatorStyle
how can i?

Hi
For example, there is this way.
alpha 0 UIView
addSubView(progressView)

thanks
it works


Adding Centos Support

I'm happy I came across this repo- I recently had to add Consul support for Centos, and found this the best starting point. I'm new to Ansible, and had to make some semi-opinionated choices to get it working, but I wanted to put it out there in case you were interested.

Add support for Centos
Removed NGINX requirement for UI. The franklinkim.nginx doesn't exist on ansible-galaxy (I couldn't install as a req) nor did I need/want NGINX. Instead, the UI option just enables the UI, and I modified the NGINX support to do a config only, assuming NGINX is already installed.
Made Consulate optional (I didn't need this, and seemed to have some install issues)
Added <IP_ADDRESS> to /etc/resolve.conf; otherwise, I couldn't get dnsmasq working out-of-box with consul.

Feedback appreciate, or feel free to disregard if you're not interested.
Mike

:+1:  this PR.

Anyone interested in dusting this off and getting it working?

@savagegus - If I thought I'd ever end up using the role on CentOS, I would be inclined to. Since that's not the case, I'll merely suggest that whomever does pick it up, take advantage of the TestKitchen setup and adds in:
- name: centos66
    driver_config:
      box: chef/centos-6.6
      box_url: https://atlas.hashicorp.com/chef/boxes/centos-6.6

or similar to the platforms list so we can at least determine if the existing test suite passes on CentOS.

I'm picking this back up and seeing how far I can get on CentOS 7 and 6.6 with TestKitchen.

@savagegus and @mhamrah - So, far this is what I've got to add.
https://github.com/trumant/ansible-consul/commits/centos_support
Once I've validated that the CentOS 7 TestKitchen tests are passing and that things look sane, I'll open a PR with just those changes. If/once that is merged, we should be able to add tests/support for CentOS 6.6 or 6.7 as well.
Only major issue I've encountered so far is that the dynamic bind address feature that works in Ubuntu, fails in CentOS 7 due to the differences in interface naming conventions.

I imagine nginx will be a problem as well.
On Nov 10, 2015, at 2:33 PM, Travis Truman <notifications<EMAIL_ADDRESS>wrote:
@savagegushttps://github.com/savagegus and @mhamrahhttps://github.com/mhamrah - So, far this is what I've got to add.
https://github.com/trumant/ansible-consul/commits/centos_support
Once I've validated that the CentOS 7 TestKitchen tests are passing and that things look sane, I'll open a PR with just those changes. If/once that is merged, we should be able to add tests/support for CentOS 6.6 or 6.7 as well.
Only major issue I've encountered so far is that the dynamic bind address feature that works in Ubuntu, fails in CentOS 7 due to the differences in interface naming conventions.
—
Reply to this email directly or view it on GitHubhttps://github.com/jivesoftware/ansible-consul/pull/11#issuecomment-155589331.

Combined the work that was done here with some of my own work to produce #70


Getting the version from the Assembly does not seem to work

I have the following Serilog config:
  "Serilog": {
    "Using": [ "Serilog.Sinks.Raygun", "Serilog.Sinks.File" ],
    "MinimumLevel": {
      "Default": "Information",
      "Override": {
        "Microsoft": "Warning",
        "System.Net.Http.HttpClient": "Warning"
      }
    },
    "WriteTo": [
      {
        "Name": "Raygun",
        "Args": {
          "applicationKey": "<secret>"
        }
      },
      {
        "Name": "File",
        "Args": {
          "path": "./logs/log.txt",
          "outputTemplate": "{Timestamp:yyyy-MM-dd HH:mm:ss} [{Level:w3}] {Scope} {Message}{NewLine}{Exception}"
        }
      }
    ],
    "Enrich": [ "WithHttpDataForRaygun" ]
  }

This works, but the version is reported in the RayGun UI as "Not supplied". The documentation says that the assembly version of the entry assembly should be used by default, but this does not happen.

Appears that I managed to misread the documentation. If I add the ApplicationVersion property, it is sent as expected.
Sorry

Not a problem @erik-kallen. Apologies for missing your question. Indeed by default this SDK will attempt to get the version of the entry assembly, but in some frameworks it can't pick it up. To clarify, have you resorted to specifying the version manually via the ApplicationVersion data field? Feel free to send a code snippet of what you've done if you don't mind. If you're doing this by fetching the version of the entry assembly, then that would make me wonder why the SDK isn't picking that up by default.

We are using .net 5, and it did not manage to get the version from the input assembly. What I ended up doing was
.UseSerilog((builder, config) =>
{
    config.ReadFrom.Configuration(builder.Configuration)
        .Enrich.WithProperty("ApplicationVersion", Assembly.GetExecutingAssembly().GetName().Version.ToString())
        .Enrich.FromLogContext();
    })
}

and that worked

Thanks for the additional details and code snippet, that's much appreciated. I've noted down to explore if this could be picked up automatically in .NET 5+ but don't have a time frame of when this could be done.

It could also be a good idea to amend the documentation with the information that post data will not be sent unless code like the following is added to the startup:
app.Use((context, next) =>
{
    context.Request.EnableBuffering();
    return next();
});


questions about routinator syncs certificates

hello，
I installed routinator on my Ubuntu system，and try to use it to synchronize RPKI repositories. I found that it takes about 10 minutes to synchronize the entire  RPKI repositories and verify the certificates，is 10 minutes normal? I'd like to know how long this software will take to synchronize all RPKI repositories and validate all certificates respectively.
Whether the software will traverse all repositories during an update cycle? Is it traversing all of the RPKI certificates from the five RIRs' root certificates (default trust anchor) to leaf certificates to  synchronize RPKI repositories？

Typically the first validation run will take between 10 and 20 minutes, so what you're seeing is quite normal. In subsequent runs only the deltas will be processed so that is much quicker, typically around a minute or two.
Relying party software will connect to the five RIR trust anchors and traverse the entire RPKI tree, which currently consists of about 25 individual repositories. That means fetching data is the slowest part of the validation process.
You can learn more about this on rpki.readthedocs.io or discuss experiences on our mailing list.


NETOBSERV-397 Kafka TLS

Add API / config
Read certificates / prepare TLS config for HTTP transport
Use in ingester + encoder

Codecov Report

Merging #256 (fe2b0bb) into main (2874b60) will decrease coverage by 1.99%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   61.50%   59.51%   -2.00%
==========================================
  Files          67       68       +1
  Lines        3907     4063     +156
==========================================
+ Hits         2403     2418      +15
- Misses       1353     1491     +138
- Partials      151      154       +3

Flag
Coverage Δ

unittests
59.51% <28.57%> (-2.00%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/api/encode_kafka.go
100.00% <ø> (ø)

pkg/api/tls.go
0.00% <0.00%> (ø)

pkg/pipeline/encode/encode_kafka.go
63.38% <45.45%> (-5.98%)
:arrow_down:

pkg/pipeline/ingest/ingest_kafka.go
77.46% <61.53%> (-2.70%)
:arrow_down:

pkg/pipeline/write/write_stdout.go
59.37% <0.00%> (-40.63%)
:arrow_down:

pkg/confgen/confgen.go
43.47% <0.00%> (-3.40%)
:arrow_down:

pkg/confgen/config.go
42.85% <0.00%> (ø)

cmd/confgenerator/main.go
0.00% <0.00%> (ø)

cmd/flowlogs-pipeline/main.go
0.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2874b60...fe2b0bb. Read the comment docs.

PS: I'm working on adding e2e tests, but they aren't designed to work with podman at the moment, so working on that first


mekanism crash in Infinity lite 1.10

was trying to use a logistical transport pipe to move salt from and extra utilities 2 crafter to a chemical injection chamber.  attempting to break the transport pipe with a pickaxe causes the crash.
https://www.dropbox.com/s/gsvybbha6l6gta2/crash-2016-11-12_11.44.23-client mekanism crash.txt?dl=0

Fixed in dev

ty


The type 'IntPtr Function()' must be a subtype of 'IntPtr Function()' for 'lookupFunction'.

class User32 {
  static final ffi.DynamicLibrary user32 = ffi.DynamicLibrary.open('user32.dll');

  static ffi.IntPtr GetForegroundWindow() {
    return user32.lookupFunction<ffi.IntPtr Function(), ffi.IntPtr Function()>('GetForegroundWindow')();
  }
}

This shows The type 'IntPtr Function()' must be a subtype of 'IntPtr Function()' for 'lookupFunction'.
Any solution please?

The lookupFunction's second type argument should represent the Dart function signature for the corresponding Win32 function. For example, considering that GetForegroundWindow returns an IntPtr, its Dart signature would be int:
static int GetForegroundWindow() {
  return user32.lookupFunction<IntPtr Function(), int Function()>(
      'GetForegroundWindow')();
}

Creating these function bindings manually can be error-prone. An easier alternative is to use the win32 package, which provides access to some of the most common Win32 APIs, such as GetForegroundWindow.
Here's how you can use it:
import 'package:win32/win32.dart';

void main() {
  final handle = GetForegroundWindow();
  // Do something with that handle
}

It was a big help. Thanks a lot. This suggestion also helped me to solve couple of other issues too.


Fix overflow in TimeSpec addition on 32-bit architectures

When Int is 32 bits, converting seconds to nanoseconds overflows. This change uses Int64 explicitly.
The change has been verified on a custom Linux armv7 system. Cross-compilation was used for the armv7 build, so I wasn't able to run the tests for that, but all tests pass on x86_64.

@swift-server-bot add to allowlist

@swift-server-bot test this please

Known flaky test https://github.com/apple/swift-distributed-actors/issues/971 added the log

@swift-server-bot add to allowlist

@swift-server-bot test this please

Really flaky CI today :\ https://github.com/apple/swift-distributed-actors/issues/1076
Need to revisit all those

@swift-server-bot test this please

@swift-server-bot test this please

Thanks for the fix and trying the cluster on other platforms!

No problem and thanks for creating this. Just trying it out now and so far I really like how this all works!


Add instruction to create superuser for admin access.

@KimberlyMunoz

:+1: Honestly this line was all I needed!

You can even shorten it to ./cfgov/manage.py createsuperuser if you really want!


Remove remaining uses of ClassLoadingStrategy.Default.INJECTION

Remove remaining uses of ClassLoadingStrategy.Default.INJECTION in favor of
ByteBuddyUtils.getClassLoadingStrategy which prevents issues with newer java versions.
See #25578 for more details
Fixes #30358

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @Abacn


Plug idea: dead links

Frequently I'll be writing and add in something as a link before there is a page for it. It might be nice to be able to see a page of all the dead links so you can go back and make pages for them. Or associate them to pages you have created, but have slightly different names
Seems like it would be similar to full text search plugin, but just searching for ilnks. Or maybe you could list all links and use something like levenshtein to find ones that are similar to the dead links.

I like the idea!

What is the best way to get all of the space's content?

There's no really efficient way. You'll just have to space.listPages() and then do a space.readPage() for each. Potentially this can be parallelized.

There is a Broken Links: Show command now


Jellyseerr only shows/movies requested and approved statuses

Description
Hi,
First, thanks for this very nice app ;).
I think it would be very usefull to add exactly the same thing as this issue ask, but for jellyseerr : https://github.com/ajnart/homarr/issues/1134
The Jellyseerr app only shows requests as "Pending" and "Approved". However, it would be much more useful if it separated approved requests as "available" and "unavailable" to highlight what requests have not been fulfilled.
Thanks!
Priority
Medium (Would be very useful)

Not applicable, since both have the same API and implementing #1134 will implement it for Jellyseerr too. Jellyseerr is only a fork and has almost the same features.


Improve VPN logging logic

Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f
macOS PR: https://github.com/duckduckgo/macos-browser/pull/2939
BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/877
Description
Improves the logging logic for the VPN.
Testing

Open Console.app and start streaming from your iPhone.
Filter by category:Network Protection.
Start the VPN
Open some sites
Change location
Stop the VPN

Make sure that the VPN works just fine, and that Console.app shows more detailed VPN logs.
Definition of Done (Internal Only):

[ ] Does this PR satisfy our Definition of Done?

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPhone 14 Pro
[ ] iPad

OS Testing:

[ ] iOS 15
[ ] iOS 16
[ ] iOS 17

Theme Testing:

[ ] Light theme
[ ] Dark theme

Internal references:
Software Engineering Expectations
Technical Design Template

I'm going to redirect the iOS PR to main, since it's not as urgent.


hasFieldOrPropertyWithValue can't work with Atomics

Summary
hasFieldOrPropertyWithValue when used against AtomicInteger or( I suspect) any other type from Atomic family fails to compare values and gives non-descriptive message.
Example
public class TestAtomicInteger {

    static class TestClass{
        private AtomicInteger value = new AtomicInteger(42);
    }

    @Test
    public void testAtomicInteger() throws Exception {
        TestClass testee = new TestClass();
        Assertions.assertThat(testee).hasFieldOrPropertyWithValue("value",42);

    }
}

Output:
java.lang.AssertionError:
Expecting
  <TestAtomicInteger$TestClass@d7b1517>
to have a property or a field named <"value"> with value
  <42>
but value was:
  <42>
	at TestAtomicInteger.testAtomicInteger(TestAtomicInteger.java:18)
...

Java 8 specific ?

NO  : create Pull Request from the 2.x branch

The test fails because you are comparing an AtomicInteger with an int, nothing wrong here.
The error message is confusing because both value are represented the same way, for the time being only isEqualTo is smart enough to detect that unequals value are represented the same way and improve the representation to better differentiate them.
Example 1:
@Test
public void compare_atomic_number() {
    AtomicInteger atomic = new AtomicInteger(42);
    // succeeds : we compare AtomicInteger fields, i.e. their internal values
    assertThat(atomic).isEqualToComparingFieldByField(new AtomicInteger(42));
}

Example 2:
@Test
public void compare_atomic_number() {
    AtomicInteger atomic = new AtomicInteger(42);
    // Fail : equals is not overridden for AtomicInteger.
    assertThat(atomic).isEqualTo(new AtomicInteger(42));
}

output : not that the hash and type of objects have been added, it is clear they are not the same
java.lang.AssertionError:
Expecting:
 <"42 (AtomicInteger@180bc464)">
to be equal to:
 <"42 (AtomicInteger@1324409e)">
but was not.

Example 3:
@Test
public void compare_atomic_number() {
    AtomicInteger atomic = new AtomicInteger(42);
    // Fail : AtomicInteger can't be equal to an int.
    assertThat(atomic).isEqualTo(42);
}

output : not that the hash and type of objects have been added, it is clear they are not the same
java.lang.AssertionError:
Expecting:
 <"42 (AtomicInteger@180bc464)">
to be equal to:
 <"42 (Integer@2a)">
but was not.

What we could do is improve the error message for hasFieldOrPropertyWithValue assertion to be behave like isEqualTo error message.
Since 3.5.0 it is easy to register a custom formatter for a type as shown in the (last) example below:
  @Test
  public void compare_atomic_number2() {
    Assertions.registerFormatterForType(AtomicInteger.class,
                                        value -> "AtomicInteger(" + value + ")");
    TestClass testee = new TestClass();
    // FAIL
    assertThat(testee).hasFieldOrPropertyWithValue("value", 42);
  }

output : note the AtomicInteger(42) representation for AtomicInteger :)
java.lang.AssertionError:
Expecting
  <org.assertj.examples.NumberAssertionsExamples$TestClass@5034c75a>
to have a property or a field named <"value"> with value
  <42>
but value was:
  <AtomicInteger(42)>

Thanks for the great explanation. All I cared about is the value. If it's
not really an issue, then OK.
Best regards,
Aleksandr Kravets
2016-07-12 12:28 GMT+03:00 Joel Costigliola<EMAIL_ADDRESS>
The test fails because you are comparing an AtomicInteger with an int,
nothing wrong here.
The error message is confusing because both value are represented the same
way, for the time being only isEqualTo is smart enough to detect that
unequals value are represented the same way and improve the representation
to better differentiate them.
Example 1:
@Testpublic void compare_atomic_number() {
AtomicInteger atomic = new AtomicInteger(42);
// succeeds : we compare AtomicInteger fields, i.e. their internal values
assertThat(atomic).isEqualToComparingFieldByField(new AtomicInteger(42));
}
Example 2:
@Testpublic void compare_atomic_number() {
AtomicInteger atomic = new AtomicInteger(42);
// Fail : equals is not overridden for AtomicInteger.
assertThat(atomic).isEqualTo(new AtomicInteger(42));
}
output : not that the hash and type of objects have been added, it is
clear they are not the same
java.lang.AssertionError:
Expecting:
<"42 (AtomicInteger@180bc464)">
to be equal to:
<"42 (AtomicInteger@1324409e)">
but was not.
Example 3:
@Testpublic void compare_atomic_number() {
AtomicInteger atomic = new AtomicInteger(42);
// Fail : AtomicInteger can't be equal to an int.
assertThat(atomic).isEqualTo(42);
}
output : not that the hash and type of objects have been added, it is
clear they are not the same
java.lang.AssertionError:
Expecting:
<"42 (AtomicInteger@180bc464)">
to be equal to:
<"42 (Integer@2a)">
but was not.
What we could do is improve the error message for
hasFieldOrPropertyWithValue assertion to be behave like isEqualTo error
message.
Since 3.5.0 it is easy to register a custom formatter for a type as shown
in the (last) example below:
@Test
public void compare_atomic_number2() {
Assertions.registerFormatterForType(AtomicInteger.class,
value -> "AtomicInteger(" + value + ")");
TestClass testee = new TestClass();
// FAIL
assertThat(testee).hasFieldOrPropertyWithValue("value", 42);
}
output : note the AtomicInteger(42) representation for AtomicInteger :)
java.lang.AssertionError:
Expecting
org.assertj.examples.NumberAssertionsExamples$TestClass@5034c75a
to have a property or a field named <"value"> with value
<42>
but value was:
<AtomicInteger(42)>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joel-costigliola/assertj-core/issues/707#issuecomment-231986532,
or mute the thread
https://github.com/notifications/unsubscribe/AA9QMjhqKi5f30zPtmojqw3Xyye3s3fmks5qU15NgaJpZM4JJUWJ
.


Tunable parameter to provision nodes with additional capacity

Tell us about your request
We would like to have a tunable provisioner level parameter which if provided, provisions new nodes with some additional capacity than required at that moment of time.
As explained below, we are observing our clusters to have many small sized nodes rather than few big nodes.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
We have Karpenter deployed to quite a lot of Clusters, the issue that we are seeing on our end is that the request of pending pods is Sporadic, 3-4 application pods will become pending at a time and karpenter will provision a Node for them.
Since a small number of pods become pending at one time, Karpenter goes on to create a relatively small node fitting those few pods. This is leading to our clusters having many small nodes rather than few big ones, which causes inefficiencies because each Node will run Daemonsets and we have 10 Daemonsets in our setup so the overhead increases.
As a result, we have 4-5 application pods per Node with 10 Daemonsets (all of which belong to Platform team), which is not an ideal way to run k8s.
Are you currently working around this issue?
We are thinking of removing small sized instances from our provisioners, but will be more interested to see if Karpenter can give a tunable parameter to pre-provision additional capacity to handle the fragmented/sporadic pending pod requests.
Additional Context
No response
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Are you able to enable Consolidation such that Karpenter will be allowed to consolidate your smaller nodes (multi-node consolidation)?  https://karpenter.sh/v0.24.0/concepts/deprovisioning/#consolidation
The knob you're suggesting to overprovision nodes would interact with consolidation if it was enabled since it would notice the free space and move pods around to efficiently utilize the free space on nodes.
If you're not able to utilize consolidation, you may want to adjust the vmMemoryOverheadPercent which is memory reserved for system resources when karpenter performs bin-packing. This would inflate the nodes that Karpenter thinks it needs to launch.

I have a similar setup and I have filtered out nano and small instances from provisioning.


Unable to select a stop that is so close to another stop that the icons overlap at maximum zoom.

Basically the title, an example of this can be shown below at the Devonport ferry terminal in Auckland. I guess a solution is to either allow the user to zoom in further or to make the active stop icon transparent to click and press events. Maybe a more robust solution is to cluster them together into one icon and then you can specify which stop you actually want in a list view or something

Yeah, this is a tricky problem to solve. I think for now, I'll implement some sort of collision detection, and try spread stops further apart - this should work for most cases. But will have to sort something out properly for places like Manukau bus station.

https://github.com/dymajo/waka/pull/148


Integrate new transaction signing flow

User sees "Sign transaction" modal upon initiating transaction signing (see design)
Title is "Sign transaction" if it's a regular transaction, "Deploy contract" if it's a contract deployment, and "Transfer STX" if it's a simple STX transfer
The domain of the initiating app shows up below the title
The address or username (if available) for the current user shows up in the top-right corner of the modal
All post conditions are shown in the middle of the modal with a link to "View details". If there are no token transfers involved, the user sees a message stating as such (see design)
Fees are displayed at the bottom of the modal, with "Sponsored" instead of a numeric value if sponsored (see design)
Selecting "View details", takes the user to a details screen with "x" that takes them back (see design)
User is able to add, remove or edit post conditions from the details screen .
User also sees a Explorer link to the contract, function name and its arguments on the details screen (see design).
The user is taken back to the app immediately upon signing of transaction. The transaction can then be seen immediately as pending under "latest transaction" in the home modal.

@jasperjansz it appears we need a variant here for multi-sig transactions?

I've removed multi-sig transaction from the spec here after @hstove's indication that it's probably a high investment / low return sort of feature for initial release.

One note here is that we'll need to handle the case in which an app triggers a transaction signing flow in the absence of a user session.
I suppose we could either opt for an error message that instructs the user to go back and sign in, or provide an integrated path through authentication, that perhaps even takes them all the way back to the transaction signing view.
cc @jasperjansz


Project status - new steward needed

Draftsman is looking for a new Steward.
I no longer have the time to keep developing it.
Anyone who is interested in taking over please let me know.

Hi 👋  @jmfederico  what exactly would go into taking this over? I'm considering using this for a feature and if I do it would make sense to maintain then. Otherwise, I'm considering using a state machine to implement my own solution as I have some concerns over the publish logic for associated models in this gem
https://github.com/jmfederico/draftsman/issues/84#issuecomment-460271169

Hi 👋🏽 @copasetickid !
Well, to be honest I think all is needed is a person with genuine interest on taking over the project. If you are interested I would transfer ownership immediately.
I would also give you access project in RubyGems: https://rubygems.org/gems/draftsman
I honestly think this is a great gem, and served me well while I needed it. Hopefully you can keep it useful for you and others.
Let me know!

Hello @jmfederico I am interested too. I don't use this gem right now, but I was looking for a ruby project to contribute to and I think this gem is a really good one.
Please note that I may need your help to document few methods in the codebase which I didn't understand what they're doing. Please also note that I have contributed the multiple drafts feature(still not merged).
Thnaks

@jmfederico  Sorry for the delay.  Yes, I'm still interested in taking over the project.
Would you able to provide any guidance while I get up to speed with the codebase? Is there a roadmap of features you were thinking of adding to this project or things that needed to be refactored?
Thanks 😄

@copasetickid is the new maintainer for the project.
@yasser-sobhy I appreciate your interest 👍🏽. @copasetickid came first to the issue, so I gave her priority.

Hello, is this project actively maintained?

Hi @copasetickid
Are you still interested in maintaining this gem?


CR47: Replace '150119_Wiley_Storyboard' with '150619_Wiley_Storyboard' in doc folder

Replaced 150119_Wiley_Storyboard file under Engineering Artifacts.


Turn off extended profile fields for search & facility profiles on Embedded Maps if user hasn't submitted

Overview
Do not show extended fields if an Embedded Map user has not submitted those fields. Additionally, the helper text that shows up on (i) hover and when additional search filters are displayed should not show up on EMs.
Additional Context -
It would be a confusing experience for an Embedded Map if the Embedded Map owner had not contributed Type of Product, but that still appeared as a searchable field on their map.
"The additional work that would be required would be conditionally checking if someone has not submitted the extended profile fields."
Technical Implementation

Add a new endpoint or add data to an an existing endpoint to that returns the names of the extended fields for which the contributor has data

Adding this data to the embed config endpoint may be a good option instead of creating a new endpoint
We can get the list of active extended field names by querying the ExtendedField model filtered by the contributor and getting a distinct, values_list of field names.

Exclude extended profile fields from the sidebar in embed mode if their field names are not returned from the endpoint.

cc @katieashaw

Does this link to #1522 ?

As a related item to this ticket, I want to add that the informational text that displays on (i) hover and when additional filters are displayed should not show up for embedded map users. This is because they are custom selecting the fields they want to display and they have had the ability to add additional custom fields (overlapping with extended field data) for some time now.

This may be more related to #1522 which is closed, but we are still seeing this issue where fields that do not have data (e.g. the contributed list does not include product type) is still showing up on the profile.
See these facilities (both contributed by EM users):
KR2020357B89R59
BD202005316M1V9

I think you'll need the map links to see those examples in action, so I'll add those here:
Look for KR2020357B89R59 in:
https://www.columbiasportswearcompany.com/corporate-responsibility-group/responsible-practices/supply-chain/
Look for BD202005316M1V9 in:
https://www.levistrauss.com/sustainability-report/community/supplier-map/

Noting that the second part of this issue (Fields still displaying on facility profiles in Embedded Maps when they are empty), still persists:
Look for KR2020357B89R59 in Columbia's test map: https://open-apparel-registry.github.io/embeded-map-test-fixed-size.html?host=staging.openapparel.org&contributors=2340.

Thank you for the very specific and helpful test details, @hlennett .
I submitted a quick change for review in #1800 that will remove the explanatory text.  There will be additional pull requests to address the profile display issues.
For engineers:
I traced the Ted Baker example and I believe we are creating showing an empty Parent Company because  Ralph Lauren Corporation has submitted a parent company value for the facility but we are filtering it out on Ted Baker's embedded map.
Embed fields and extended fields have separate data sources but we may be able to share "hide the header if there is no values" code between them.

Some testing feedback:

Confirming that Reformation does not show any additional filters
Levi’s shows parent company and no. of workers  (question for OAR: is Levi’s submitting some points, e.g. product type, anonymously through API but others non-anonymously? E.g.: https://openapparel.org/facilities/GT2019083TBFK70?contributors=25
PST does not show any
RL shows all 5 additional filters
Incorrect → Hylo does not show any (but on their facilities they do have product type, number of workers, and facility type listed)

I see Hylo Athletics as contributor ID 1879 on staging
https://staging.openapparel.org/?contributors=1879
This is there embed test link on staging
https://open-apparel-registry.github.io/embeded-map-test-full-width.html?host=staging.openapparel.org&protocol=https&contributors=1879
When I look at the details of the three facilities I do not see any additional data points
https://staging.openapparel.org/facilities/CN20213075BDSVH?contributors=1879
https://staging.openapparel.org/facilities/CN2021307FP5FE7?contributors=1879
https://staging.openapparel.org/facilities/CN2021307W1C26H?contributors=1879
I also don't see any extended field data in the staging database for that contributor
openapparelregistry=> select * from api_extendedfield where contributor_id = 1879;
 id | is_verified | field_name | value | created_at | updated_at | contributor_id | facility_id | facility_claim_id | facility_list_item_id
----+-------------+------------+-------+------------+------------+----------------+-------------+-------------------+-----------------------
(0 rows)

In our checkin call we determined that the Hylo data was updated before extended profile and so these are contributor fields, not extended fields. The OAR team will let Hylo know that they will need to reupload with the new extended field names.
At this point I do not thing we need additional code changes for this issue.


ATM: Add charge

Many ATMs increasingly have a charge for withdrawals, though others are free. Amounts vary widely. This is useful information if trying to avoid racking up fees.

charge=* is used to specify the exact amount to withdraw cash.
I guess fee=* is what you are actually looking for?

ATMs don't charge for withdrawing money. Banks do. The charge depends on your plan (student/standard/pensioner), card issuer (visa/mastercard), card type (credit/debit/prepaid), the ATM (in-network or out-network) and your bank's terms and condition. How would you fit all of this information in that field? fee=yes;no?

ATMs don't charge for withdrawing money.

That doesn't seem to be my experience, and it's not what is defined on the OSM wiki. Pretty sure an ATM I used today stated that the machine would charge a fee of 1.80 EUR for instance. It was listed as a machine fee, not something from the bank. The bank may also charge a VISA fee for instance.
https://wiki.openstreetmap.org/wiki/Tag:amenity=atm#Tagging

ATMs don't charge for withdrawing money.

Are you sure? That doesn't seem to be my experience, and it's not what is defined on the OSM wiki. Pretty sure an ATM I used today stated that the machine would charge a fee of 1.80 EUR for instance. It was listed as a machine fee, not something from the bank. The bank may also charge a VISA fee for instance.
https://wiki.openstreetmap.org/wiki/Tag:amenity=atm#Tagging
charge=* | Specific of the ATM. | 1.75 GBP (fixed fee)

I assume that you've used Euronet's ATM. Euronet is not a bank, so their ATMs do charge. They are also notorious for having high transaction and exchange fees.
I was referring to ATMs of actual banks. Each bank will charge a different amount based on the conditions above. So for bank A's ATM you would have something along the lines of charge=0 EUR @ customers of Bank A and currency=local;0.5 EUR + 0.25% @ customers of Bank A and currency=USD;1 EUR @ customers of Bank B;max(5 EUR, 0.75%) @ customers of Bank B and card=Visa Platinum|Mastercard Platinum and currency!=local;5 EUR +1.25% @ customers of non-EEA bank. That's not even counting the existence of Bank C, Bank D and so on. For simplicity I ignored most card types and most premium and social packages but you can see where this is going.

Yes, Euronet are 7 EUR here. That presumably would be suitable for charge=7 EUR?
No, the example I gave yesterday was a cash machine on the outside wall of a Banco Sabadell branch, which is a bank. The receipt clearly states ATM fee: 1,80 EUR. Are you saying that 'ATM fee' is actually a banking fee and is customer-dependent?

The wiki suggests that fee is a simpler boolean type field and that charge is the actual amount. (Seems a bit like duplication to me.) Is my reading incorrect?
See also the talk page which implies fee is not an amount field.
https://wiki.openstreetmap.org/wiki/Talk:Tag:amenity%3Datm#fee=*_for_the_actual_amount_of_money_requested_to_operate_the_atm


Is it possible to restore a drawing's state (undo stack and so on)?

I'd like to give my users the option to save the drawing and then keep editing later on. Thanks :)!

Hey,
Besides the web storage feature, which save the current drawing in local or session storage, there is no such feature included currently. So, people can come back to their drawing later on, but they can't undo things after reloading the page because their history is not kept, only the current drawing.


[Bug] Minor - podkrepi.bg/support/"В каква роля искате да ни подкрепите?" the title of the checkbox group is too small and inappropriate color

Describe the bug
At page - podkrepi.bg/support/"В каква роля искате да ни подкрепите?" the title of the checkbox group for ex. "Партньор" is too small and inappropriate color. So it makes it difficult to read. Also it is missing ":" after the title.
To Reproduce
Steps to reproduce the behavior:

Go to  podkrepi.bg/support/"В каква роля искате да ни подкрепите?"
Observe the title of the checkbox group

Expected behavior
The title is clearly visible and bigger then the text of the checkboxes . ALso the title should end with ":" symbol
Screenshots

Desktop (please complete the following information):
OS: Windows 10
Browser Edge
Version Version 98.0.1108.50 (Official build) (64-bit)

The title has font size identical to the other titles in the form.
The color is changed.
@kachar could you please confirm if we could close this ticket?


Partially enable typescript esModuleInterop for migrating towards ESM imports

Helps with #212977
This PR somewhat enables typescript esModuleInterop.
Before fully enabling esModuleInterop, it seems ~600 assert imports would need to be adjusted.
While that's still a lot of changes, it could be done incrementally on a case by cases basis, making the many changes easier.

@SimonSiefke just a quick heads-up that we have started https://github.com/microsoft/vscode/pull/214144. This will replace this PR for which I wanna apologise but is also the whole thing (which we could coordinate within the team) which is very cool. Thanks a ton for kicking this off

Closing in favor of #214144. Thanks! :)


The Mica [Light] Theme Not working properly

Describe the bug
i build Test 2.0.3 version DEMO and 3.0 WPF UI Gallery
the Mica【Light】Theme They are all not working properly on Win11 22H2 22621.1555
But the【Dark】Theme is work normal
To Reproduce
Create A Mica Style Window and Switch To Light Theme
private void NavigationButtonTheme_OnClick(object sender, RoutedEventArgs e)
{
      Wpf.Ui.Appearance.Theme.Apply(Theme.GetAppTheme() == Wpf.Ui.Appearance.ThemeType.Dark ? Wpf.Ui.Appearance.ThemeType.Light : Wpf.Ui.Appearance.ThemeType.Dark, Wpf.Ui.Appearance.BackgroundType.Mica);
}

i try BackgroundType.Auto、BackgroundType.None
they will only make more worse
Expected behavior
Should work be like dark theme.
Screenshots

OS version
Win11 22H2 22621.1555
.NET version
2.0.3 - net6.0-windows10.0.22000.0
3.0 - net7.0-windows10.0.22621.0
WPF-UI NuGet version
2.0.3 and 3.0
Additional context
No response

@FastChen Could you try this on the latest preview (preview-10)?

Hey @lepoco, @pomianowski - You have a couple of issues regarding the Mica effect and theme switching. Might be a few duplicates, but would you be so kind to look into these issues? I see a lot of comments in different repositories about them. Thanks!

Hey @Jay-o-Way, the @Muniwedesu, tried to address some of the backdrop issues here
https://github.com/lepoco/wpfui/pull/1094


Error with vision when running catkin_make

When running catkin_make I received the following error:

-- Could not find the required component 'OpenCV'. The following CMake error indicates that you either need to install the package with the same name or change your environment so that it can be found.
CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
Could not find a package configuration file provided by "OpenCV" with any
of the following names:
OpenCVConfig.cmake
opencv-config.cmake
Add the installation prefix of "OpenCV" to CMAKE_PREFIX_PATH or set
"OpenCV_DIR" to a directory containing one of the above files.  If "OpenCV"
provides a separate development package or SDK, be sure it has been
installed.
Call Stack (most recent call first):
vision/CMakeLists.txt:7 (find_package)
-- Configuring incomplete, errors occurred!
See also "/home/jeramy/Documents/RatM/qubo/build/CMakeFiles/CMakeOutput.log".
See also "/home/jeramy/Documents/RatM/qubo/build/CMakeFiles/CMakeError.log".
Invoking "cmake" failed

Installing opencv from apt did not fix it, so I installed it from source (http://docs.opencv.org/3.0-last-rst/doc/tutorials/introduction/linux_install/linux_install.html)
The error persisted, but I had seen that one of the commits in the vision folder was to take out a line that broke the install.
As per the install instructions this was my install location: CMAKE_INSTALL_PREFIX=/usr/local
So I uncommented the line in .../qubo/src/vision/CMakeList.txt from:

#set(OpenCV_DIR /usr/share/OpenCV/)
to
set(OpenCV_DIR /usr/local/share/OpenCV/)

This corrected the error.

let's keep setting that environment variable in the .bashrc. The reason is that the computer on the physical robot is using different version of OpenCV that lives somewhere else. I would actually advise you actually uninstall the version you built from source just so you're on the same page as the rest of the team (who is using openCV)


space between y axis and begin of line in line chart

The space between y axis and begin of line in line chart is not pretty.

Can I set the padding to 0?

Can you try axis.x.padding = 0? And please ask this kind of question in GoogleGroup https://groups.google.com/forum/#!forum/c3js . Thanks.


Create codeql-analysis.yml

Codecov Report

Merging #85 (44bf253) into master (c39ed69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   86.04%   86.04%
=======================================
  Files           5        5
  Lines          86       86
=======================================
  Hits           74       74
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39ed69...44bf253. Read the comment docs.


Error, couldn't expand pattern:

So, 3.11 on Windows is running too for me as well.

I agree, with the above repro code it works on Windows for me as well. So the fact that my main application does not launch on Windows must be related to something else, which I will report separately when I can isolate it.
Update: That Windows issue was due to me using nuitka-project: --force-stdout-spec="%NONE%" on a pre-factory version of Nuitka without a console attached, so I did not see the error that was raised. No further issue to be reported at this point in time :)

Originally posted by @bersbersbers in https://github.com/Nuitka/Nuitka/issues/2116#issuecomment-1471425871
So I thought. This bug is still in 1.5.3. Will add required information from the issue template in a follow-up comment.

Not reported yet.
Installed via pip
Regression: no
develop version works (so this is kind of invalid, I guess)

# nuitka bug.py && bug.dist\bug.exe
# nuitka-project: --onefile
# nuitka-project: --force-stdout-spec="%NONE%"
print("Done")

fails:
1.5.3
Commercial: None
Python: 3.11.2 (tags/v3.11.2:878ead1, Feb  7 2023, 16:38:35) [MSC v.1934 64 bit (AMD64)]
Flavor: Unknown
Executable: C:\Users\bers\.pyenv-win-venv\envs\project_3.11\Scripts\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10
Version C compiler: C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\cl.exe (cl 14.3).

works:
1.6rc4
Commercial: None
Python: 3.11.2 (tags/v3.11.2:878ead1, Feb  7 2023, 16:38:35) [MSC v.1934 64 bit (AMD64)]
Flavor: Unknown
Executable: C:\Users\bers\.pyenv-win-venv\envs\project_3.11\Scripts\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10
Version C compiler: C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\cl.exe (cl 14.3).

So I guess --force-stdout-spec="%NONE%" is not in 1.5.3 yet. Maybe this feature could be mentioned in the changelog so users know when to expect it working :)

Closing as a duplicate iof https://github.com/Nuitka/Nuitka/issues/2083, which is still open. Sorry for the noise!


Show all steps on ready only mode

Description
Use readOnly flag to allow user to go through all steps without answering the step

A formatting issue, otherwise 👍


Iteration Plan for August 2024

This plan captures our work in August. This is a 5-week iteration. We will ship in early September.
Endgame

August 26, 2024: Endgame begins
August 30, 2024: Endgame done

The endgame details for this iteration are tracked here.
Plan Items
Below is a summary of the top level plan items.
Legend of annotations:

Mark
Description

:runner:
work in progress

:hand:
blocked task

:muscle:
stretch goal for this iteration

:red_circle:
missing issue reference

:large_blue_circle:
more investigation required to remove uncertainty

:black_circle:
under discussion within the team

:black_large_square:
a large work item, larger than one iteration

Accessibility

[ ] :runner: Accessibility issues, see query @meganrogge team

UX

[ ] :runner: Proposal for cleaning up our context menus vscode#225411 @daviddossett

Workbench

[ ] :muscle: Tree: Support contributable find providers vscode#212077 @benibenj

Code Editor

[ ] :runner: Explore GPU rendering of the code editor vscode#221145 @tyriar @hediet
[ ] :runner: Investigation: Use tree-sitter for grammar colorization vscode#210475 @alexr00 @hediet
[ ] :runner: Adopt EditContext vscode@207700 @aiday-mar @hediet
[ ] :muscle: Add setting to control rendering of multi-line inline completions vscode#225399 @hediet
[ ] :muscle: Investigate syntax highlighting for inline completions vscode#225400 @hediet
[ ] :runner: Release Monaco Editor @aiday-mar @hediet

Notebook Editor

[ ] :runner: API proposal for IW/REPL (openNotebookDocument with additional mode: repl) vscode#154983 @amunger
[ ] Review REPL/IW Accessibility vscode#209140 @amunger
[x] Support for toggling comments on cells outside of the viewport vscode#22344 @Yoyokrazy
[ ] :runner: Explore supporting cmd+d across multiple cells vscode#141673 @Yoyokrazy
[ ] :muscle: Proposal for restructuring and cleaning up the context menu in Notebook vscode#219240 @Yoyokrazy
[x] Improve rendering of large code cell editor (e.g., sticky execution count) vscode#209154 @rebornix
[x] Explore hiding/collapsing unchanged cells in Notebook Diff Editor vscode#174152 @DonJayamanne
[x] Support inlinediff/wordwrap/whitespace in Notebook Diff Editor vscode#224759 @DonJayamanne
[ ] :runner: Explore adopting multi file diff editor for notebook diff vscode#224760 @DonJayamanne

Search

[ ] :runner: Prepare FileSearchProvider API for finalization vscode#73524 @andreamah
[ ] :runner: Prepare TextSearchProvider API for finalization vscode#59921 @andreamah

WebAssembly Support

[x] Support Exceptions for result return types #wasm-177 @dbaeumer

Issue Reporter

[x] Finish migrating desktop issue report to auxiliary service approach vscode#213332 @justschen

Languages
TypeScript

[ ] :runner: Investigate performance issues when adding all missing imports vscode#208911 @justschen
[ ] :runner: Investigate folding issues with imports vscode#156675 @justschen
[ ] :muscle: Explore support adding imports via drag and drop from explorer  @justschen

Python

[ ] :runner: Contributions to the Python extension, see plan @karthiknadig team

Language Server Protocol

[x] Support GlobPattern in DocumentFilter lsp#1781 @dbaeumer
[x] Allow a language server to provide a reference content for a specific uri scheme lsp#336 @dbaeumer

Authentication

[ ] :runner: Explore UX for switching accounts for extensions vscode#225943 @TylerLeonhardt

Testing

[ ] Finalize attributable test coverage API vscode#212196 @connor4312
[x] Finalize Call stacks API vscode#214488 @connor4312
[ ] Finalize Related code vscode#126932 @connor4312
[ ] Improve UX of the new call stack widget @connor4312 @daviddossett

Debug

[x] Support find in the debug console vscode#4338 @meganrogge @connor4312

Debug Adapter Protocol

[ ] :muscle: Explore green thread support debug-adapter-protocol#339 @connor4312
[x] Add source locations for variables debug-adapter-protocol#343 @connor4312

Terminal

[x] Finalize shellIntegration API vscode#145234 @tyriar
[ ] :runner: Iterating on pwsh suggest and PromptInputModel vscode#154662 @tyriar
[x] Explore moving to newer conpty version vscode#224488 @tyriar

Tasks

[x] Explore issues with duplicated terminals vscode#216826 @meganrogge

Source Control

[ ] Add SCM accessibility help dialog vscode#203577 @lszomoru @meganrogge
[ ] Support for blame inline decorations vscode#203841 @lszomoru
[x] Support new git reftable format vscode#221642 @lszomoru

API

[ ] :runner: API proposals: query @jrieken @mjbvz
[ ] :runner: API finalization: query @jrieken @mjbvz
[x] Finalize the GetAccounts API vscode#152399 @TylerLeonhardt

Extensions

[ ] :muscle: Make repository signature verification blocking vscode#223942 @sandy081 @isidorn
[ ] :muscle: Investigate different extension update mechanisms vscode#215555 @sandy081 @isidorn

Extension Contributions

[ ] :runner: Improvements to the Remote extensions, see plan @roblourens @chrmarti @connor4312 @joyceerhl
[ ] Create suggestions from working tree changes vscode-pull-request-github#5256 @alexr00

Engineering

[ ] :runner: Explore AMD to ESM migration vscode#160416 @jrieken @bpasero
[x] Investigate moving from yarn back to npm vscode#196795 @deepak1556

Electron

[ ] :hand: V8: Support usage of external array buffers for embedders in sandbox mode chromium#14585 @deepak1556
[ ] Crash when searching in extension preview editor vscode#177046 @rzhao271

Documentation

[ ] :muscle: :runner: Update Getting Started experience doc vsocde-docs#7359 @ntrogh

Deferred

None.

Is there any plan for a Windows 11-inspired UI/UX in VS Code, featuring modern design elements like rounded corners, sleek animations, and subtle shadows? Adding native hover information with rich content previews (e.g., images and links), as well as improved preview features for Markdown and files, would enhance the overall experience. However, these updates should be optimized to avoid impacting performance, especially for developers working on resource-heavy tasks. Additionally, better extension management and a built-in system resource monitor could help maintain a responsive and efficient environment.

August release DATE?


Migrate PolicyResourceTest to use common tests from EntityResourceTest

PolicyResourceTest currently has CatalogApplicationTest as the base class. Extending it from EntityResourceTest can make use of many common tests and a lot of code can be deleted.

This is already done...


Response headers are missing in authenticate middleware

The authenticate middleware function doesnt add the response headers before calling next function.

Isn't needed as scopes are inside res.locals.oauth object. Therefore closing this request.


Update to GraphQL, change submission endpoint

Fixes #1

Hi @SuperGeniusMan ,
Thank you for your effort and contribution! I noticed that your code introduced the dotenv package, which unfortunately isn't compatible with Python 3.13.1. As a result, I couldn't run it successfully on my local MacBook.
I wanted to let you know that another contributor has already addressed this issue, so I’ll be closing your pull request. That said, your work is absolutely appreciated and not at all useless! I'll create a new issue soon, and I'd love to invite you as the first contributor to tackle it if you're interested.
Looking forward to seeing more contributions from you!

No worries, @soulmachine
I am always looking for more work and am open to fixing any issue!
Thank you for your time, I hope to hear from you in the future.


add bazel build

User can depends nlohmann json directly using bazel, but this commit don't support test all cases using bazel.

Coverage remained the same at 100.0% when pulling 4ab991c41bc93211c7c6a1ebf660ef34167bcfad on horance-liu:develop into ee4028b8e4cf6a85002a296a461534e2380f0d57 on nlohmann:develop.

Thanks for the PR! Could you also add a small paragraph to the README file how to use the package?

@horance-liu Can you please have a look at the changes I requested?

@remyabel Thanks for your comments! As the PR got stale and you seem to be familiar with the topic: would you be able to take over the PR or create a new one with all comments (including yours) addressed?


Adding episodes 1, 2 and 3 blog entries

I have read the CLA Document and I hereby sign the CLA

recheck


fix: [M3-7325] Font rendering inconsistencies

Description 📝
Because Safari is significantly less forgiving than Chrome when it comes to font rendering, we can easily spot numerous issues while using web fonts with Safari.
These issues arise from the use of faux-bold (employing fontWeight: 'bold' in our stylesheet). While this isn't inherently problematic, it forcibly emboldens a regular font, and different browsers handle this situation in distinct ways. Applying a CSS bold style to a regular font disrupts the intended font rendering.
To manage font weight with web fonts, we must import the appropriate bold font face. Again, Chrome handles faux-bold more gracefully, whereas Safari is notably less accommodating.
Note: The usage of <strong> and <b> tags is acceptable as they render the correct font weight.
Changes  🔄

replace instances of fontWeight with fontFamily through the codebase
introduce local eslint rules 🎉
add custom noFontWeight eslint rule
cleanup typography in selected components

Preview 📷
This will only show a few examples of how things are rendering now VS after this PR. It is not and exhaustive list of changes.

Before
After

How to test 🧪
Prerequisites

pull code locally
run yarn && yarn up
in VSCode, do Shift-Command-P, find and select ES-lint: Restart ESLint Server

Reproduction steps

Check production in Safari browser (linode detial landing, db detail landing etc)

Verification steps
UI
Navigate localhost on Safari and confirm no instance left of faux-bold
Linter

open any component and try adding fontWeight or 'font-weight' to any CSSinJS (makeStyles,  styled component)
try adding fontWeight to the typography element
==> notice linting error

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[x] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[x] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation (will add this to the wiki in a subsequent PR)
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[x] ♿  Providing accessibility support

this is so cool:

gonna rerequest a review for myself since there were some more changes 👀

@coliu-akamai & @bnussman-akamai Going to put this back in development for a bit to address a few more things

@coliu-akamai @bnussman-akamai @carrillo-erik
This is ready for another pass, thanks for your initial reviews!


Link to imprint from donation page is broken

The Donations wiki page refers to the imprint at https://www.jabref.org/impressum.html but the page does not exist.

Thanks for the hint. In the meantime I added the necessary information from the imprint to the donations page directly.


perf bugfix: only get line number, not col

julia> @time analyze("WinEncoding");
  4.360394 seconds (61.29 k allocations: 26.116 MiB)

still slow, but down from a reported 5 mins

But tests on 1.6 are failing 😕

Sounds like Flux us using syntax not available in v1.6?

This wouldn't error on actual usage btw, but I turn off exception handling for the tests so we aren't silently missing things. I think the fix here is to just choose another package for that test instead of Flux

For the record, on v3.0.1 I get
julia> @time analyze("WinEncoding");
  5.636592 seconds (11.69 M allocations: 814.376 MiB, 2.88% gc time, 78.45% compilation time)

julia> @time analyze("WinEncoding");
  0.457882 seconds (60.69 k allocations: 25.983 MiB)

After compilation (😳) the run seems to be pretty fast.

For the record, I believe the slow parsing before this PR was due to this recursive for loop: https://github.com/JuliaEcosystem/PackageAnalyzer.jl/blob/f7e51cc2d95224da38938cef5f05885744d79ce0/src/LineCategories.jl#L91-L94 Files like https://github.com/testercwt/WinEncoding.jl/blob/3b83ff5d13078bc2daa03f7cfa9e844945daecaa/src/cp936.jl stressed this out very hard.

Ah ok. Semantically we check everything on each line to see if we want to change our categorization of it (eg white space then inline comment then docstring), so it’s not super obvious to me how to optimize that loop but maybe there’s a way to do so. But your 0.5s seems alright, and this is some really weird source code, so maybe it’s fine as-is.


AOT-ReleaseX64 - KBC-INT-ReleaseX64: output divergence

True output divergence:
!DIVERGENCE! 1.2:3721190037 (output=true)

Most modes agree output should be:

throws
42
true
5
0.06401909060427868
&E♥@xv
[-9223372030412324864, 73]
{0: ZeI, 1: ♥QW, 2: #ozF}

But AOT gets:

throws
42
true
4
0.06401909060427868
&E♥@xv
[-9223372030412324864, 73]
{0: ZeI, 1: ♥QW, 2: #ozF}

I was able to make a very small reproducer. JIT runs the following code without exception, while AOT throws:

NoSuchMethodError:: The null object does not have a method '==' with matching arguments.

The null object does not have a method '==' with matching arguments.
bool var1 = true;
int var2 = 4;

bar(List<int> par1, double par2) {
  if (par2 == 123.0)
   return 456.0;
}

bool foo(double par1) {
   return (bar([ 81, 17 ], ((!(var1)) ? double.maxFinite : (var1 ? (80).floorToDouble() : par1))) == (((~(var2))).roundToDouble()).sign);
}

Could be related to https://github.com/dart-lang/sdk/issues/32166


1.18.2 Wireless Booster Not Working

Playing on the modpack Dawncraft with a handful of other mods included that I like for 1.18.2, such as Ice and Fire, Mana and Artifice, Mekanism, Thermal Series and a few others. Added in the AE2 mods, and trying to get the Wireless Crafting Terminal to work. It'll work while I'm anywhere within my base, but if I go to far away it stops working and says "station could not be found" I'm not sure what the actual range is before it says this.
The infinity booster card is suppose to work at infinite range and across dimensions according to the mod page, but I'm getting this message constantly. If I take a waygate it might open once, then it says the station could not be found. I don't know if it is a conflict with another mod, or if its just not working as it should in 1.18.2.
I've also tried the mod AEInfinityBooster, which adds an Infinity/DImension Card, and that one doesn't seem to be working for me either. The Dawncraft modpack has stuff scattered thousands of blocks away, and I'm getting tired of having to haul backpacks with me to do a little bit of exploring and would like to be able to use the wireless terminal at any distance, but it just won't work.

your system has to be chunkloaded, otherwise the infinity booster card won't work


Header Draft

As a proof of concept, rewrite and restyle header.hbs:

Add Google fonts to document_head.hbs
Add MaxMind text logo and link
Remove profile buttons
Add buttons to submit a request or view open requests

i have made the requested changes, and i tried my hand at making some very simple JS to toggle the nav menu when it's on mobile. if there's anything amiss with how i approached the JS, maybe it would be good to pair to talk it over, although i don't think i'll be using JS for anything else on this theme in the interests of keeping it as simple as possible.


Fix compatibility with OptionsResolver <2.6

https://github.com/swarrot/swarrot/pull/94 broke the compatibility with the 2.3 LTS version by using the API introduced in Symfony 2.6.
This adds support back for 2.3 by detecting whether the new API is available or no (based on the existence of another method of the new API as it is faster and easier than using reflection to detect the number of arguments in the method)

See #99 for the remaining issue for the lowest deps

:+1:
Thanks a lot. :)

@odolbeau can you please tag a new version for https://github.com/swarrot/swarrotBundle with the latest version of Swarrot ? Thanks :)

SwarrotBundle does not need any change for that though.


Andrelouis.NokiaInternalTuneEdit version 1.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

portable app

This package installed normally, but errored when launched:

Faulting application name: Nite.exe, version: <IP_ADDRESS>, time stamp: 0x39854106
Faulting module name: Nite.exe, version: <IP_ADDRESS>, time stamp: 0x39854106
Exception code: 0xc000041d
Fault offset: 0x00011b90
Faulting process id: 0x0x266C
Faulting application start time: 0x0x1D97EE55D17F494
Faulting application path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Faulting module path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Report Id: ab9bd053-e06b-47a1-8d42-2447abd4cd21
Faulting package full name:
Faulting package-relative application ID:

This package installed normally, but errored when launched:

Faulting application name: Nite.exe, version: <IP_ADDRESS>, time stamp: 0x39854106
Faulting module name: Nite.exe, version: <IP_ADDRESS>, time stamp: 0x39854106
Exception code: 0xc000041d
Fault offset: 0x00011b90
Faulting process id: 0x0x266C
Faulting application start time: 0x0x1D97EE55D17F494
Faulting application path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Faulting module path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\Andrelouis.NokiaInternalTuneEdit__DefaultSource\Nite.exe
Report Id: ab9bd053-e06b-47a1-8d42-2447abd4cd21
Faulting package full name:
Faulting package-relative application ID:

Is this Windows Sandbox

Is this Windows Sandbox

In a Windows 11 VM.

Try on a normal PC

Try on a normal PC

This also fails to launch for me on Win10 and Win11. I believe this is because it relies on several files in the same directory, which cannot be called through symlink

Try on windows 10 to see if it works

@upintheairsheep - Support for zipped binaries has now been added and is available in the pipelines. This will require you to update your submission to ManifestVersion: 1.9.0 and set ArchiveBinariesDependOnPath: true in the installer node. To keep things clean, this PR is being closed. Please submit a new PR for the latest version of this package. Thank you for your contributions!


add support gradient

Hi @seanghay, is it possible to add gradient into project?
I tried to covert this drawable into SVG, but vd2svg doesn't support gradient 😔

Hi @bmx666! Right now this lib doesn't support gradients however you can open a pull request for that feature if you don't mind. I will merge that as soon as possible. Thanks.

Thank you!
https://github.com/seanghay/vector-drawable-svg/pull/6


Issue with resume option

Description

I did not activate the resume key and the players are not destroyed directly when the bot disconnects from the node
the players are never even deleted except by sending the request for the destroy
Version info
Client used:
lavalink 3.7.3 and Shoukaku #master as Client

fixed in https://github.com/freyacodes/Lavalink/releases/tag/3.7.4


differenciate between integration and unitary tests

the idea is to be able to run unitary or integration tests since we are mixing them and it takes too long to check whether all tests are passing or not.
this guide can be followed https://medium.com/coding-stones/separating-unit-and-integration-tests-in-jest-f6dd301f399c and I would use .test.ts and .it.ts suffixes to differentiate them
This is a integration test case https://github.com/kiegroup/mock-github/blob/main/test/act/act.test.ts where act is not mocked
This is a unitary test case https://github.com/kiegroup/mock-github/blob/main/test/github/github.test.ts since third-party or additional libraries are mocked

By mocking act you mean mock the spawn call where we actually call the act cli tool?

By mocking act you mean mock the spawn call where we actually call the act cli tool?

my mistake for act case, mockapi.test is a right example @shubhbapna

So for Act and ActionCompiler we really can't change anything right?
For MockGithub we have already implemented this.
So this will just impact Moctokit and Mockapi correct?

Not relevant as of now since Act, Mockapi and ActionCompiler were removed


DOT and BOXES game image in README file not visible

In readme file image is not visible pls allow me to edit it and add image and its link as alternate
pls assign me this issue under label gssoc24
thank you

I'D LIKE TO WORK ON THIS ISSUE OF DOT and BOXES game image in README file not visible. PLEASE ASSIGN IT UNDER GSSOC

I'd like to work on this issue. Please assign it under GSSOC.


Type 'Cartesian3' is not assignable to type 'PositionProperty | Cartesian3 | undefined'

Hello,
I have been following the basic introductory example here but the prop position in Entity component is unable to accept an object of type Cartesian3 from the cesium library. Seems like there is some misalignment of types between Cesium's own types and the types from @types/cesium

So if you install the latest version of cesium which is 1.70.0, it appears that the type files are not ready yet. Downgrading cesium to version 1.67.0 works with @types/cesium 1.67.10


add defensive programming for request command

if a request is already empty, tell user it is already empty instead of saying that it's removed.

Codecov Report

Merging #205 (27420fe) into master (cf25491) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #205   +/-   ##
=========================================
  Coverage     69.09%   69.09%
  Complexity      666      666
=========================================
  Files           102      102
  Lines          2288     2288
  Branches        286      286
=========================================
  Hits           1581     1581
  Misses          605      605
  Partials        102      102

Impacted Files
Coverage Δ
Complexity Δ

...edu/cakecollate/logic/commands/RequestCommand.java
87.09% <ø> (ø)
10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf25491...27420fe. Read the comment docs.


1.0.9 Integration with expo

Hey @azesmway, I saw that you merged the expo integration and I'm trying to make it work, but I think that something is missing because the plugin is not getting compiled inside the bundle (I just see the typescript definitions) and I'm guessing that the app.plugin.js should be there too.
At the moment if I just follow the instructions for expo users i get something like

Project with path ':unityLibrary' could not be found in project ':azesmway_react-native-unity'.

which suggest that the plugin didn't run
Thanks!

Hi @fbcarpinato
I haven't dealt with expo and it's hard for me now how it's supposed to work.

Yea, it would be great if @Jpoliachik that wrote the PR could give some help with it

I managed to get a build working by just following the guide as if I didn't have expo.
This is true if I just run npm run android and it works on the simulator.
But if I try to get a eas build with expo i get
[RUN_GRADLEW] Build failed with an exception.
[RUN_GRADLEW] * What went wrong:
[RUN_GRADLEW] Could not determine the dependencies of task ':app:lintVitalReportRelease'.
[RUN_GRADLEW] > Could not resolve all task dependencies for configuration ':app:releaseRuntimeClasspath'.
[RUN_GRADLEW]    > Could not resolve project :unityLibrary.
[RUN_GRADLEW]      Required by:
[RUN_GRADLEW]          project :app > project :azesmway_react-native-unity
[RUN_GRADLEW]       > No matching configuration of project :unityLibrary was found. The consumer was configured to find a component for use during runtime, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release', attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '8.1.1', attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but:
[RUN_GRADLEW]           - None of the consumable configurations have attributes.
[RUN_GRADLEW] * Try:
[RUN_GRADLEW] > Run with --stacktrace option to get the stack trace.
[RUN_GRADLEW] > Run with --info or --debug option to get more log output.
[RUN_GRADLEW] > Run with --scan to get full insights.
[RUN_GRADLEW] > Get more help at https://help.gradle.org. ```

Hi, according to the code example you provided, how can I ensure that my message is successfully sent when I send a message to Unity during RN initialization? How should Unity send messages so that I can receive them in the onUnityMessage callback?

Hi, according to the code example you provided, how can I ensure that my message is successfully sent when I send a message to Unity during RN initialization? How should Unity send messages so that I can receive them in the onUnityMessage callback?

this is ot

Hi, according to the code example you provided, how can I ensure that my message is successfully sent when I send a message to Unity during RN initialization? How should Unity send messages so that I can receive them in the onUnityMessage callback?

this is ot

I don't know Unity, what I get is a package of Unity that has been pre packaged according to the example, and can be displayed normally after using the plugin. However, what I need is communication with each other. I am not sure what Unity needs, or how I can receive messages I send him. Hehe, could you please give me a simple example of Unity that can communicate with each other? I am trying to use it in my practice project. I am a beginner and have not quite understood complex things yet🫠


fix(hooks): running earlier for warmup-plugin support

:tada: This PR is included in version 1.5.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


PQX File Format

Hi,
Trying to figure out a couple details about PQX files. Is a PQX file exactly the same as an MEZ file, except that it is packaged into an Open Packaging Conventions (OPC) zip file, which optionally may be signed per OPC conventions?
If so, do you see any reason why I couldn't skip using MakePQX.exe and instead build my own PQX files directly (i.e. OPC package up the appropriate .m , .png & .resx files, then optionally sign the OPC), like from a custom CI/CD build task?
Thanks,
Ben

Yes, that should work just fine.

Thank you, @CurtHagenlocher!


[BUG] Stats don't work anymore

I have Obsidian Charts  3.6.1 and Spaced Repetition 1.7.2

Hey @superouioui,
SR 1.8.0 doesn't rely on Obsidian Charts anymore, you could confirm if this is still happening

Hi @superouioui
We haven't heard back from you, and no one else has reported this issue.
I'll close this now, but feel free to reopen if this is still an issue.
Cheers
Ronny


Python Multiprocessing Problem

I'm using python 2.7 and opencv 2.4.11 and am having some trouble using the multiprocessing module for a very simple purpose. Here's a sample of my code with a consumer-producer framework employed.
class Consumer(multiprocessing.Process):

    def __init__(self, task_queue, result_queue):
        multiprocessing.Process.__init__(self)
        self.task_queue = task_queue
        self.result_queue = result_queue

    def run(self):
        #Creating window and starting video camputer from camera
        cv2.namedWindow("preview")
        vc = cv2.VideoCapture(0)
        vc.set(cv.CV_CAP_PROP_FRAME_WIDTH, 640)
        vc.set(cv.CV_CAP_PROP_FRAME_HEIGHT, 480)

        if vc.isOpened():
            rval, frame = vc.read()
        else:
            rval = False

        while rval:
            cv2.imshow("preview", frame)
            rval, frame = vc.read()
            key = cv2.waitKey(20)
            if key == 27:
                break
        cv2.destroyWindow("preview")
        return

##################################
#MAIN PROGAM
##################################

#SETTING UP MULTIPROCESSING STUFF
tasks = multiprocessing.JoinableQueue()
results = multiprocessing.Queue()

consumer = Consumer(tasks,results)
consumer.start()
#Rest of main program

However, the process hangs on the line
cv2.namedWindow("preview")
Is this a bug? How do I work around this?

I have debugged the program a bit and the two imports (when commented out) seem to affect the program's functionality.
    import matplotlib.pyplot as plt
    import skimage.io

When both are commented out it works, otherwise, it doesn't.

Possibly related to #5150


Vide doesn't work on Chrome

So strange, I can't get your plugin to work in chrome.
In FF it works fine.
In chrome it generates this code:

    <video autoplay="" loop="" muted="" style="margin: auto; position: absolute; z-index: -1; top: 50%; left: 50%; transform: translate(-50%, -50%); visibility: hidden;">
    <source src="//domain.dev/assets/src/video/xyz.webm" type="video/webm">
    </video>

The fallback jpg works fine
No console errors
If I paste the video url into a new browser tab it works fine.
I converted the video with miro. So this shouldnt be the problem.

What else could this be?

Do you have a MP4 as well? Usually you want to have all 3 videos; webm, mp4, and ogv

Yes. I have all three formats implemented. I stripped out code to circle the problem. I went for webm in this example because it seems to be the prefered format for chrome. Further examination revealed that is  doesn't work on safari either. So it must be a webkit thing?

AFAIK, Chrome prefers mp4 , but I could be incorrect. But we normally make sure that we have all 3 videos accessible.

I'll strip the code to the mp4 then. Let's see what happens then.

It seems to be a problem with autoplay. I embeded the video with the native html5 video tags:
<video autoplay="autoplay" controls="controls" preload="auto">
      <source src="the_video.mp4" type="video/mp4"  />
  </video>

This doesn't work either until I hit play. Does something changed with the autoplay behaviour?

I could get it to work with $('#videContainer video').get(0).play() Not very pretty. But that does the job.

Same problem her.
The video wont play. The strange part is, that all the demo files work just fine in chrome, but as soon as i use it on my owen stuff, the video wont play i chrome/safari.


Add gradle build script

Added Gradle build script for issue #1

Thanks for this. I don't know gradle very well, but this seems very excessive. Should all of this be tracked?
Is this what you had in mind @ftomassetti?

This is pretty standard for Gradle builds. I updated the .gitignore to exclude the necessary files already.
Allow me to elaborate on what the various files do,
The build.gradle file is the actual build script analogous to the pom.xml file in maven.
The gradlew and gradlew.bat files are gradle wrapper scripts, that basically function as embedded gradle distribution which allow contributors to the project to basically use the exact same version of gradle without needing to have a local gradle install. There is something similar available for maven known as the maven wrapper. The other files are simply config files.

Hi David, it seems ok with me. Is indeed typical to include in projects using gradle the gradle wrappers. In practice they are scripts which can install gradle for you, if you do not have it in your system. This is particularly cool because in this way the whole project is self-contained.
I personally prefer Gradle and I like this PR, but it is true that in the project we have the pom (for Maven). Should we have two different distributions? Two separate branches? Or just one repository with both Maven and Gradle?

The gradlew and gradlew.bat files are gradle wrapper scripts, that basically function as embedded gradle distribution which allow contributors to the project to basically use the exact same version of gradle without needing to have a local gradle install.

Thanks, that helps!

I personally prefer Gradle and I like this PR, but it is true that in the project we have the pom (for Maven). Should we have two different distributions? Two separate branches? Or just one repository with both Maven and Gradle?

I'm feeling pretty lazy today, and maintaining two branches is more work... If they can co-exist peacefully in the one branch then I'd rather just merge it as is.

They can coexist without an issue.

It would be nice if we could group it together in a gradle-dir, but I'm guessing that's not possible?

The files are usually in the project root. 😕

The files are usually in the project root. :confused:

Yup. It will be slightly messy, but I think it's okay. Thanks for your work :)


Added docstrings to the main functions.

I thought it may be useful to have some docstrings since it seems some of the issues are of people not knowing what some parameters do.
I am up to go through all the code adding docstrings if it's fine for you. I have seen already some there so I've assumed the numpy doc guide was being followed. If not, my mistake.
Feel free to add/change any description.
I couldn't find the use of xi anywhere, so I left it as [unused] so you could fix it.

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   98.44%   98.44%
=======================================
  Files           7        7
  Lines         385      385
  Branches       39       39
=======================================
  Hits          379      379
  Misses          3        3
  Partials        3        3

Impacted Files
Coverage Δ

bayes_opt/bayesian_optimization.py
99.01% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb28df8...5809e38. Read the comment docs.

Thank you @AlbertAlonso !! This is excellent! If you're good writing more doc string it would be very much appreciated. I'll merge this for the time being so it can go out with the next release (which it's overdue).


the 8.13.0 version will report a error

It seems that the export object is not a function

when i take it back to 8.7.0, it will work!

Hey guys, thank you for reporting this.
I'm afraid I need more information to help you.
Please tell me how you include LazyLoad (npm install? CDN script?) and how you use it.
Show me the code and I will be able to understand what happens.

I include LazyLoad by (npm install):
import Lazyload from 'vanilla-lazyload';
This is the usage:
new LayLoad({})
the lazyload.min.js will report a error;

Hey @fakership,
thanks for reporting it. I'll definitely check and get back to you.

Hey @fakership,
I've created this GitHub test repo in which I call LazyLoad as an ES2015 module, and everything works as expected.
So I think the problem might be related to something else you are using to bundle or minify your code.
What are you using? WebPack 4? Rollup.js? Babel is included in the mix?
Please share more information so I can investigate more.
Thanks

I was able to reproduce the bug using WebPack to bundle LazyLoad in this test repo.
https://github.com/verlok/lazyload-es2015-webpack-test
Now I'm going to fix it. I'm sure it's just a matter of webpack configuration.

yes, I bundle LazyLoad by webpack4.

I found the issue. It was a mistake in my package.json

Just released 8.15.0 and 10.15.0 on npm.
The issue should be fixed now. Let me know!

I've tested it in this repo and checked that now it works correctly.
Thank you @fakership and @massic80 and @l3aconator for reporting your issues!


python39Packages.confluent-kafka: 1.9.0 -> 1.9.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python39Packages.confluent-kafka is: "Confluent's Apache Kafka client for Python"
meta.homepage for python39Packages.confluent-kafka is: "https://github.com/confluentinc/confluent-kafka-python"
meta.changelog for python39Packages.confluent-kafka is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.9.2 with grep in /nix/store/q79gjnd14dv3swilsv7qrd9i1gdj9nn6-python3.9-confluent-kafka-1.9.2
found 1.9.2 in filename of file in /nix/store/q79gjnd14dv3swilsv7qrd9i1gdj9nn6-python3.9-confluent-kafka-1.9.2

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.confluent-kafka
python310Packages.streamz
python39Packages.confluent-kafka
python39Packages.streamz

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q79gjnd14dv3swilsv7qrd9i1gdj9nn6-python3.9-confluent-kafka-1.9.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python39Packages.confluent-kafka https://github.com/r-ryantm/nixpkgs/archive/68878c9e1e73abd83f3120e82445b3dbc63e86df.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q79gjnd14dv3swilsv7qrd9i1gdj9nn6-python3.9-confluent-kafka-1.9.2
ls -la /nix/store/q79gjnd14dv3swilsv7qrd9i1gdj9nn6-python3.9-confluent-kafka-1.9.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

python310Packages.streamz
python39Packages.streamz

2 packages built:

python310Packages.confluent-kafka
python39Packages.confluent-kafka

Maintainer pings
cc @mlieberman85 for testing.

nixpkgs-review build went fine on Linux x64 NixOS 22.05.
Upstream changes note that this is a maintenance release.
Build of Python module streamz fails but I will address this in a separate PR.