Operator: Fix webhooks reconciled by operator are inconsistent with istioctl install's

Please provide a description of this PR:
Fix https://github.com/istio/istio/issues/43893

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test release-notes

integ-pilot-istiodremote_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test release-notes

integ-pilot-istiodremote_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test release-notes

integ-pilot-istiodremote_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-operator-controller

release-notes_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-operator-controller

release-notes_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test release-notes

integ-pilot-istiodremote-mc_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
6922ca4204b38e8c758a8cc5a496876b5da722a6
link
true
/test integ-operator-controller

release-notes_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test release-notes

integ-pilot-istiodremote-mc_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test release-notes

integ-pilot-istiodremote-mc_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

release-notes_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

release-notes_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test release-notes

integ-pilot-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

release-notes_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test release-notes

integ-pilot-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote

integ-security-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

release-notes_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test release-notes

integ-pilot-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote

integ-security-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

release-notes_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test release-notes

integ-pilot-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote

integ-security-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

integ-pilot-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote

integ-security-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-telemetry-mc

release-notes_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

integ-security-istiodremote_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-telemetry-mc

release-notes_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test release-notes

integ-pilot-istiodremote_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
541f2e9f41a871efddc1fb666f3a4fe1534926da
link
true
/test integ-operator-controller

integ-telemetry-mc_istio
5d5c3bee67ff0a62381de068f86408090bbdb4b1
link
true
/test integ-telemetry-mc

release-notes_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test release-notes

integ-pilot-istiodremote_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test release-notes

integ-pilot-istiodremote_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-operator-controller

release-notes_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-pilot-istiodremote-mc

integ-operator-controller_istio
4c22757f386f7064827e79f54be2873cd3616c34
link
true
/test integ-operator-controller

release-notes_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test release-notes

integ-pilot-istiodremote_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test release-notes

integ-pilot-istiodremote_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
58b519de7aa178b5ecb9f1a74559c331ea21dd52
link
true
/test integ-operator-controller

release-notes_istio
add6392fbd709abde552f05a41638c3a95a13c08
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
add6392fbd709abde552f05a41638c3a95a13c08
link
true
/test release-notes

integ-operator-controller_istio
add6392fbd709abde552f05a41638c3a95a13c08
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
add6392fbd709abde552f05a41638c3a95a13c08
link
true
/test integ-operator-controller

lint_istio
a651a096fa0a98c7b2e507b428ac50f51ef25fda
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
add6392fbd709abde552f05a41638c3a95a13c08
link
true
/test integ-operator-controller

lint_istio
a651a096fa0a98c7b2e507b428ac50f51ef25fda
link
true
/test lint

gencheck_istio
a651a096fa0a98c7b2e507b428ac50f51ef25fda
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
266e3d542d240a6d23fb734dcb067dc7300a4ba0
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
266e3d542d240a6d23fb734dcb067dc7300a4ba0
link
true
/test integ-operator-controller

lint_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
266e3d542d240a6d23fb734dcb067dc7300a4ba0
link
true
/test integ-operator-controller

lint_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test lint

gencheck_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test lint

gencheck_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test gencheck

integ-operator-controller_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test gencheck

integ-operator-controller_istio
9f52dd92315ca3d1d51e6aeba254eb6c8af6c323
link
true
/test integ-operator-controller

lint_istio
228612334788d2370afe6d35182d9b2fb8598941
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
886925fac15684f6d0db99c56afc2077dba32088
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
335388d4b0827f3c631bf976190cef8c2246f362
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
cfd66f93e011e614536840b131660706c49a7acd
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-cni

@istio/wg-environments-maintainers PTAL, thanks

@istio/wg-environments-maintainers PTAL, thanks, looking forward to this fix.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

not stale

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote-mc

unit-tests-arm64_istio
3e59a99bac781a5b1878d65a7dfb37686fee42ab
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote-mc

unit-tests-arm64_istio
3e59a99bac781a5b1878d65a7dfb37686fee42ab
link
true
/test unit-tests-arm64

unit-tests_istio
3e59a99bac781a5b1878d65a7dfb37686fee42ab
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote-mc_istio
e2f07884eccc4b9576e5d46cf46130d9825b2c84
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
45a4c9bdcd108685c218582d55e932c72c3bd1e6
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
45a4c9bdcd108685c218582d55e932c72c3bd1e6
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
45a4c9bdcd108685c218582d55e932c72c3bd1e6
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote-mc_istio
45a4c9bdcd108685c218582d55e932c72c3bd1e6
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
4093356b8ea379c42d7fea4c2ea55238facd67f1
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
4093356b8ea379c42d7fea4c2ea55238facd67f1
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
4093356b8ea379c42d7fea4c2ea55238facd67f1
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote-mc_istio
4093356b8ea379c42d7fea4c2ea55238facd67f1
link
true
/test integ-pilot-istiodremote-mc

lint_istio
88314c1c70f6229af7921b6dd1ed521137a4cc70
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

lint_istio
88314c1c70f6229af7921b6dd1ed521137a4cc70
link
true
/test lint

integ-pilot-istiodremote-mc_istio
88314c1c70f6229af7921b6dd1ed521137a4cc70
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

lint_istio
88314c1c70f6229af7921b6dd1ed521137a4cc70
link
true
/test lint

integ-pilot-istiodremote-mc_istio
88314c1c70f6229af7921b6dd1ed521137a4cc70
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
88314c1c70f6229af7921b6dd1ed521137a4cc70
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote-mc_istio
88314c1c70f6229af7921b6dd1ed521137a4cc70
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
5ed442a90e4df7ecc944de517a5ba9c478b27cf0
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
5ed442a90e4df7ecc944de517a5ba9c478b27cf0
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
5ed442a90e4df7ecc944de517a5ba9c478b27cf0
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
5ed442a90e4df7ecc944de517a5ba9c478b27cf0
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
5ed442a90e4df7ecc944de517a5ba9c478b27cf0
link
true
/test integ-pilot-istiodremote-mc

lint_istio
32132f24b93552f5b2b74d3ceb0b490d02ad70bc
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

gencheck_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

gencheck_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test gencheck

lint_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn Could you please take another look, particularly at the last commit https://github.com/istio/istio/pull/43897/commits/788e15b926428c209bb5fc0f69b50eed15166222? In this commit, I added some logic to prevent the operator from pruning the generated webhook resources, as it's not present in the manifest map. Without this change, the generated webhook would be pruned during a new reconciliation cycle. I'm not pretty sure if this approach to resource ignoring is optimal. Aside from this, the rest of the code remains largely unchanged from before.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

gencheck_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test gencheck

lint_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test lint

integ-pilot-istiodremote_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

gencheck_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test gencheck

lint_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test lint

integ-pilot-istiodremote_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

gencheck_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test gencheck

integ-pilot-istiodremote_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote-mc

lint_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote-mc

lint_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test lint

gencheck_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote-mc_istio
788e15b926428c209bb5fc0f69b50eed15166222
link
true
/test integ-pilot-istiodremote-mc

lint_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test lint

gencheck_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test gencheck

integ-pilot-istiodremote_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

lint_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test lint

gencheck_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test gencheck

integ-pilot-istiodremote_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote_istio
b4186526f93b40b8a39f06995599a1cab0462f0b
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
9d36bc764a849b5e8569b287c742a6eb0631a76e
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-pilot-istiodremote-mc_istio
9d36bc764a849b5e8569b287c742a6eb0631a76e
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-istiodremote_istio
9d36bc764a849b5e8569b287c742a6eb0631a76e
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio/wg-user-experience-maintainers PTAL, thanks

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

bookinfo-build_istio
b23b48836cc45d6b1896c2ef3d9f1a7411481288
link
true
/test bookinfo-build

integ-ambient_istio
35d2e6dd8f992aaa93790573e9a77cdbc6fa72d2
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: #43897 failed to apply on top of branch "release-1.18":
Applying: fix operator reconcile missing default validator
Using index info to reconstruct a base tree...
M	operator/cmd/mesh/install.go
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Falling back to patching base and 3-way merge...
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Auto-merging operator/cmd/mesh/install.go
CONFLICT (content): Merge conflict in operator/cmd/mesh/install.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix operator reconcile missing default validator
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #45099

In response to a cherrypick label: #43897 failed to apply on top of branch "release-1.16":
Applying: fix operator reconcile missing default validator
Using index info to reconstruct a base tree...
M	operator/cmd/mesh/install.go
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Falling back to patching base and 3-way merge...
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Auto-merging operator/cmd/mesh/install.go
Applying: fix validation test
Applying: fix again
Using index info to reconstruct a base tree...
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
M	tests/integration/operator/switch_cr_test.go
M	tests/integration/pilot/validation_test.go
M	tests/integration/pilot/webhook_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/webhook_test.go
Auto-merging tests/integration/pilot/validation_test.go
Auto-merging tests/integration/operator/switch_cr_test.go
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Applying: fix lint
Using index info to reconstruct a base tree...
M	tests/integration/operator/switch_cr_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/operator/switch_cr_test.go
Applying: fix controller test
Using index info to reconstruct a base tree...
M	istioctl/pkg/tag/generate.go
M	tests/integration/operator/switch_cr_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/operator/switch_cr_test.go
Auto-merging istioctl/pkg/tag/generate.go
Applying: fix lint
Applying: fix webhook creation, operator is read-only, and cannot create temp files
Using index info to reconstruct a base tree...
M	istioctl/pkg/tag/generate.go
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
M	tests/integration/operator/switch_cr_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/operator/switch_cr_test.go
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Auto-merging istioctl/pkg/tag/generate.go
Applying: fix lint
Applying: use separator const
Applying: revise extra change and fix lint
Using index info to reconstruct a base tree...
M	istioctl/pkg/tag/generate.go
M	operator/cmd/mesh/install.go
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
M	operator/pkg/helmreconciler/reconciler.go
M	tests/integration/pilot/validation_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/validation_test.go
Auto-merging operator/pkg/helmreconciler/reconciler.go
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
CONFLICT (content): Merge conflict in operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Auto-merging operator/cmd/mesh/install.go
Auto-merging istioctl/pkg/tag/generate.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0010 revise extra change and fix lint
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #45100

In response to a cherrypick label: #43897 failed to apply on top of branch "release-1.17":
Applying: fix operator reconcile missing default validator
Applying: fix validation test
Applying: fix again
Using index info to reconstruct a base tree...
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
M	tests/integration/operator/switch_cr_test.go
M	tests/integration/pilot/validation_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/validation_test.go
Auto-merging tests/integration/operator/switch_cr_test.go
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Applying: fix lint
Using index info to reconstruct a base tree...
M	tests/integration/operator/switch_cr_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/operator/switch_cr_test.go
Applying: fix controller test
Using index info to reconstruct a base tree...
M	tests/integration/operator/switch_cr_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/operator/switch_cr_test.go
Applying: fix lint
Applying: fix webhook creation, operator is read-only, and cannot create temp files
Using index info to reconstruct a base tree...
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
M	tests/integration/operator/switch_cr_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/operator/switch_cr_test.go
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Applying: fix lint
Applying: use separator const
Applying: revise extra change and fix lint
Using index info to reconstruct a base tree...
M	istioctl/pkg/tag/generate.go
M	operator/cmd/mesh/install.go
M	operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
M	operator/pkg/helmreconciler/reconciler.go
M	tests/integration/pilot/validation_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/validation_test.go
Auto-merging operator/pkg/helmreconciler/reconciler.go
Auto-merging operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
CONFLICT (content): Merge conflict in operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go
Auto-merging operator/cmd/mesh/install.go
Auto-merging istioctl/pkg/tag/generate.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0010 revise extra change and fix lint
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #45101

@hanxiaop
Hi,
I saw that this has not been merged with 1.18 yet. Will this be merged to 1.18 and released in an upcoming version?


twister: regression : Failures are counted as errors

Describe the bug
Failures are counted as errors. Must be a regression because it was working well before
To Reproduce
Steps to reproduce the behavior:

Create a build error in zephyr/samples/hello_world/main.c
run ./scripts/twister -T samples/hello_world/ -p b_u585i_iot02a
See error:

Impact
The big problem is that as failure and error are inverted, twister return code is not 1 when failure occurs so CI does not pass in failure. As it can be seen in twister script:
if results.failed or (tplan.warnings and options.warnings_as_errors):
        sys.exit(1)

Environment (please complete the following information):

OS: OS: ubuntu 20.04
Toolchain zephyr-sdk 0.13.1
Commit SHA or Version : v3.1.0 TAG

backport fix available, this is 3.1 specific.

https://github.com/zephyrproject-rtos/zephyr/pull/47703 merged


Add support for Chrome Themes like old Firefox for Android [ver 68]

As i said at the title. It would be great to customize browser with the themes! I mean pictured themes, not the Dark or White.
Here's an example from Firefox for Android (ver 68)

(Look at the adress bar, btw it doesn't support dark mode in version 68. I could not find better theme,so this must be explanatory, right?)
So, is it possible to add a feature like this, or impossible? Thanks in advance.

Sorry for my bad english,i've tried my best to explain it correctly.

@kyoyacchi i think you're talking about light themes (former personas) https://blog.mozilla.org/addons/2018/09/20/future-themes-here/

I think we should do that we load an image as background of the toolbar and define a couple of main colors

thats very similar to Firefox light themes toolbar picture and color set ...

@kiwibrowser that's what firefox simple themes allow to change:

it would be nice. men of culture will appreciate it.

Shouldn't we go for full Material You support and decide theme based on homepage background image color tones ?

IMHO these are two different use cases, Material you is for automatic and possibly seamless integration with homepage background (which is black in my case as I don't care/like background images), while individual themes like Firefox  light themes is to customize browser look independent of background image, e.g. better contrast for disabled or individual need
if Material you supports both use cases, adapt on system theme and individual settings for an app, then it make sense to adapt the more flexible one.

@kiwibrowser any thoughts about way to go?

@kiwibrowser any changes about this?


Deprecate BaseRule and state that it will be make sealed - #2365

Codecov Report

Merging #2432 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2432      +/-   ##
============================================
+ Coverage      82.9%   82.93%   +0.03%
- Complexity     2161     2177      +16
============================================
  Files           357      359       +2
  Lines          6148     6206      +58
  Branches       1122     1133      +11
============================================
+ Hits           5097     5147      +50
- Misses          478      480       +2
- Partials        573      579       +6

Impacted Files
Coverage Δ
Complexity Δ

...ain/kotlin/io/gitlab/arturbosch/detekt/api/Rule.kt
94.11% <ø> (ø)
13 <0> (ø)
:arrow_down:

.../kotlin/io/gitlab/arturbosch/detekt/api/RuleSet.kt
27.27% <ø> (ø)
1 <0> (ø)
:arrow_down:

.../arturbosch/detekt/cli/runners/SingleRuleRunner.kt
97.22% <ø> (ø)
8 <0> (ø)
:arrow_down:

...otlin/io/gitlab/arturbosch/detekt/core/Detektor.kt
66.07% <ø> (ø)
8 <0> (ø)
:arrow_down:

...otlin/io/gitlab/arturbosch/detekt/api/MultiRule.kt
100% <ø> (ø)
8 <0> (ø)
:arrow_down:

...io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../gitlab/arturbosch/detekt/api/internal/BaseRule.kt
100% <100%> (ø)
6 <6> (?)

.../io/gitlab/arturbosch/detekt/cli/Configurations.kt
78.37% <0%> (-0.41%)
0% <0%> (ø)

...sch/detekt/rules/providers/CommentSmellProvider.kt
100% <0%> (ø)
2% <0%> (ø)
:arrow_down:

.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt
92.3% <0%> (ø)
12% <0%> (ø)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8191b95...21d084a. Read the comment docs.

Closes #2365 ?

If you move base rule to an internal package right now you will need to move it outside for 2.0 because all the subclasses of a sealed class should be in the same file.
So I think that it's better to keep baserule in the same place with the depreciation. As soon as we make it sealed it will not be able to be extended so the package will not matter.

@BraisGabin @schalkms  true that. However if not using a typealias I need to suppress every usage of the BaseRule for our -PwarningsAsError=true strategy ...
And it must be top level so the import is also suppressed.
As we are now deprecating more and more stuff should I go further with the typealias + moving strategy or deactivate warningsAsErrors. What do you think?

OK, I understand the reason. I'm a bit concern about the binary compatibility but previous changes broke it already so it doesn't matter now. 👍🏻 For me.

OK, I understand the reason. I'm a bit concern about the binary compatibility but previous changes broke it already so it doesn't matter now. 👍🏻 For me.

Could you elaborate on what is not binary compatible anymore for 1.7?
Imo moving the classes while leaving a typealias behind is binary compatible, isn't it?

I can be wrong here. I'm not a compatibility expert or nothing near. I think that the typealias are just syntax sugar. But I repeat that I don't know this for sure.


MT - Simplimantis

Name: Masharty Tembo
Name of Team: Simplimantis
Student Number: N/A
University: N/A
Location: Cape Town
Target Sector: Software Development
LinkedIn (optional): https://www.linkedin.com/in/masharty-tembo-a4787a2b/
My Interest in the hackathon: Excited to learn more about blockchain technology and its applications.
How I heard about it: A friend via a cryptocurrency WhatsApp group.

Hi! Im a uct computer science student whos interested in knowing more about crypto-currencies. we should have a chat sometime.
www.linkedin.com/in/mzwenhlanhla-hlongwane-6497b661

Hey Thando! Nisa looks really awesome, that is a very, very neat idea with great possibility. Super excited to have you sign up for this and look forward to meeting you down in the Cape next year 😉


fix deadlock when panic in batch function for multiple keys

Hi Nick,
During the usage of the lib in our project, I found it hangs or deadlock when the batch function panic if it loads more than one key. Currently, if panic in batch function, it only send error result to the first request channel, and other request will wait forever.  I created this PR for the fix, can you take a look? Thanks

This change is

it's fixed now :)