Webfont.js Console Error

Issue description:
Even though I have no typography fields on my theme I keep getting this error in console

Version used:
(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
Yup, running latest dev version

Yeah, I know that happens I'm just still unsure if I should fix it or not.
While in the customizer, I use the webfontloader to allow live-updating the preview for typography controls with postMessage.
In order to improve performance I don't check if the selected font is an actual google font or not, so when a font-family is selected in a typography control, it tries to get that font from google fonts by default.
If it fails, then it throws an error in the console.
It's possible to fix it, but I'd have to check if the selected font is a google font or not, and that would require using wp_localize_script to add an object of all googlefonts in the script that handles the postMessage, and then check if the selected font exists in there before enqueueing it. All that extra data and checks would have some impact on performance.
The error in the console doesn't cause any actual issues which is why I didn't bother fixing it until now..

In this case is throwing an error because there's no font at all. You can at least check for that 😉

I believe this one was just fixed, can you please verify? Thanks!

Yes, error gone from the console.

Thanks for testing!

@manuelmoreale I have the similar issue when using kirki to load google font in my site.
GET https://fonts.googleapis.com/css?family=Open+Sans+Condensed&subset net::ERR_ABORTED
It seems that the parameter in above link is missed.
@aristath I think the version we are using is old, but it is difficult to use latest version for us. Can you give us some suggestion to fix it?
Thanks and Merry Xmas.

@kingwinchan hello there and merry Christmas!

I think the version we are using is old, but it is difficult to use latest version for us.

Could you please elaborate? Why is it difficult for you to use the latest version? What exactly is the problem you have with the latest version?
v2.3.7 was released in Oct.2016 and although the inner workings of the plugin have changed a lot since then, I've spent a lot of time making sure it's almost 100% backwards-compatible so it should still work just by updating the plugin... If there's something that prevents you from updating to the latest version I'd rather resolve that than provide support for an old & deprecated version.


ResponseCacheManager Ignores Cache-Control With Multiple Values

Describe the bug
The normal 'Cache-Control' header that is generated in a response by Spring WebMVC when configured to enable default cache controls contains the value "no-cache, no-store, max-age=0, must-revalidate".  Spring Cloud Gateway's LocalResponseCache filtering mechanism doesn't check this value correctly and will apply default cache values to the response rather than skipping caching.
It also appears as if when a WebMVC explicitly specifies the max-age in its ResponseEntity, that Spring Cloud Gateway also ignores this value and uses its own.
Sample
I've created a sample repo with an application and Gateway that show this behavior.
https://github.com/danielshiplett/spring-cloud-gateway
I am also creating a PR that will show a possible fix.  However, it caused several other tests to fail.  This makes me think that either I am on the wrong track, or this was a major oversight that ended leading to invalid tests.  Please let me know which.

closing in favor of #3432


Fix: Data not loading sometimes when paginating on time entry reports page

Notion Card
Notion Card
Description

This is a fix for data not loading sometimes when paginating on the time entry reports page.

Preview

Before

https://github.com/saeloun/miru-web/assets/57438322/e9d018b7-0232-471e-ba9a-dc04ab103865

After

https://github.com/saeloun/miru-web/assets/57438322/b3b8f4c5-4760-46f6-9ed1-b51d4538891e

@mayankagnihotri7 Please update the branch with develop, create an env SEED_DATA_FROM_CSV=true and run timesheet_data.rake file, and then test the time entry reports.

@mayankagnihotri7 @supriya3105 Please watch these loom videos
https://www.loom.com/share/e8275be98dc04af1ab65c42d9df429db
https://www.loom.com/share/1acadee876234670a57dfe5cbd40ac20

Page is becoming unresponsive because it's fetching all entries and showing them on one page if no. of clients are less and grouped by none.
Throwing toaster error when clicking on three dots on pagination.
Pagination not working correctly on using group by project

@mayankagnihotri7 Next button is not visible even though we have 2 pages on the invoices page. Please check this too.

@mayankagnihotri7 What's remaining here?

Fixing test cases and also another bug cropped up

@mayankagnihotri7 Did you fixed the bug in Group by Project?

Yes

@apoorv1316 Please test this on priority.

@mayankagnihotri7 Please work on adding capybara specs for the time entry reports. Add detailed specs for this feature including the filters, group by and pagination.

@mayankagnihotri7 Please see the loom video and fix the bugs mentioned in it.
https://www.loom.com/share/164fd29085f34bd5a3c34d9f171ecbba

@Apoorv I have fixed the pagination issue.
Status filter does works. The reason why non billable and billed filter didnt worked in your case is I think the records created using the csv(seed data) only has unbillable status.
Please set status of some records to non billable and billed this will make the filter work.

@gowsik-ragunath
Few concerns

There should not be multiple pagination dots it will create a bug (see 2nd image ). 2 can be the max number one for moving to the prev pages and another one for the following pages.
No result when group by none is applied

@apoorv1316 I have fixed those issue in this commit but some how these changes are reverted when the develop branch is merged yesterday. I will add them again.

@apoorv1316 I have fixed the group with none, pagination and test issue
Demo: https://youtu.be/_7Qv8X_j6ZE


feature - attached cdroms

added the insert_cdrom into the orchestrator

@gambol99 I like this change, but I think it would be in a better position to merge if the commits were structured and had commit messages explaining the changes. We like to follow the convention that @annashipman sets out in this blog post.

I think this depends on gds-operations/vcloud-core#169.

Closing for now pending an update to gds-operations/vcloud-core#169.


Make stacks.co repo public and link to it from the site

There should be a way for people to submit issues for stacks.co. For example for getting their project listed under resources, or as a stacking service, or for general updates or feature requests.
Once that repo is public I would add links from stacks.co to create issues. For example at the Resources, I could add "Don't see your resource? Submit an issue."
The reason I think we should have this is because I can't keep up with all the developments in the ecosystem and it's important the site stays up to date.

We can start by linking to the "blockstack/blockstack.org" repository and migrating issues when @andresgalante sets up the new repos per https://github.com/blockstackpbc/devops/issues/603.

It is here: https://github.com/stacksgov/stacks-co
This issue can be closed.


CHANGELOG commit links are broken

I believe it is everywhere, links like:
https://github.com/cyclejs/cyclejs/tree/master/packages/dom/commit/13cb6bc
instead of:
https://github.com/cyclejs/cyclejs/commit/13cb6bc

Fixed

@staltz check the latest link in https://github.com/cyclejs/cyclejs/blob/77f97b1deba51d9353210dbbf5b891f8597f5379/dom/CHANGELOG.md
dom: remove HTML driver from Cycle DOM (8a5aac7)

Yeah, that's the only broken link. I'll see what went wrong

Fixed


Invalid discord invite links.

Hey there, so I just came across this project and it piqued my interest but when I tried joining your discord server the invite was invalid/expired.

All the links provided are invalid.

https://discord.gg/2jfycwXVM3  (https://github.com/cee-studio/orca/blob/master/README.md?plain=1#L11) (https://github.com/cee-studio/orca/blob/master/README.md?plain=1#L195)

https://discord.gg/Q4Ub3wuF (https://github.com/cee-studio/orca/edit/master/docs/CONTRIBUTING.md?plain=1#L9)

I think it would be nice to have a single never expiring invite link rather than multiple ones.

I'm sorry, and thanks for letting us know! I will fix those, in the meantime you can join via this link: https://discord.gg/JjqTVehaY3


youtube: duration field is null in flat-playlist --json output

Checklist

[x] I'm reporting a site feature request
[x] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[x] I've searched the bugtracker for similar site feature requests including closed ones

Description

WRITE DESCRIPTION HERE
The duration field is empty when fetching a YouTube playlist when using the flat playlist JSON output:
$  python -m youtube_dl --flat-playlist -j https://www.youtube.com/user/BostonDynamics/videos

{"_type": "url_transparent", "ie_key": "Youtube", "id": "F843AqfNsaA", "url": "F843AqfNsaA", "title": "Meet Spot Enterprise", "description": null, "duration": null, "view_count": 112689, "uploader": null}
{"_type": "url_transparent", "ie_key": "Youtube", "id": "6Zbhvaac68Y", "url": "6Zbhvaac68Y", "title": "Spot's Got an Arm!", "description": null, "duration": null, "view_count": 1333404, "uploader": null}
{"_type": "url_transparent", "ie_key": "Youtube", "id": "fn3KWM1kuAw", "url": "fn3KWM1kuAw", "title": "Do You Love Me?", "description": null, "duration": null, "view_count": 27911156, "uploader": null}

#25853 was submitted to fix this functionality (among other things) but not merged.  A fix was requested in #25720 but closed.

I already made some quick and dirty changes to get the playlist results right:
https://github.com/Crypto90/youtube-dl-1
I compile it always myself because the patches never got merged...
those changes work with the latest code. maybe someone ca  look over it/improve it/beautify it to get it merged.


Disable broken sphinx-version-warning

The doc build is currently broken because of this dependency:
Exception occurred:
  File "/home/vagrant/.local/lib/python2.7/site-packages/versionwarning/extension.py", line 5, in <module>
    from .signals import generate_versionwarning_data_json
  File "/home/vagrant/.local/lib/python2.7/site-packages/versionwarning/signals.py", line 41
    **{config.versionwarning_message_placeholder: ''},

Related: #6460

This change is

test-docs-please


Update word2vec.py

Makes it consistent with line 516.

Can one of the admins verify this patch?

Jenkins, test this please.

@tensorflow-jenkins: test this please

Can one of the admins verify this patch?

@tensorflow-jenkins test this please (trying to get them all green)


Don't emit trailing semicolon from bail!

This will allow bail! to continue to be used in expression position if
https://github.com/rust-lang/rust/issues/33953 is fixed

This crate isn't gating ci on rustfmt. If it ever does, then https://github.com/rust-lang/rustfmt/pull/4507 will be needed to prevent rustfmt from trying to undo this change.


[feature request] Do not use default config location

Kraken version (use kraken version):1.1.2
What happened:
When failing to pass --config flag before specifying a config file path, kraken will attemt to use a default config file. This behavior appears on both kraken cluster up and kraken cluster update.
What you expected to happen:
Kraken should declare that failing to pass a flag is invalid.
How to reproduce it (as minimally and precisely as possible):

Build kraken
Attempt to run up a cluster without passing --config flag OR attempt to update an existing cluster without passing --config flag

Anything else we need to know:
Currently the docs do not reflect the necessity to pass --config to update action, which will definitely result in the behavior described above.
See also: #173

this is not a bug, this is a feature request and not one that I am sure we should do.  The default configuration file location is where kraken lands a generated configuration file.  Having a default config location is a normal/expected thing for applications to have.
is there a reason we shouldn't have a default config location?

Maybe my example is not clear.
Running
kraken cluster up without anything will attempt to use default config. This is expected.
kraken cluster up --config <path to custom config file location> will use specified config. This is also expected.
However, running
 kraken cluster up <path to custom config file location> or any kraken cluster up <foobar> will attempt to use default config, purely because the user forgot to pass --config. I don't think it should. I have a default config sitting around, and I don't really want kraken to touch it on accident just because I forgot --config, especially since currently the docs don't mention passing --config to update. It would be better if kraken said "this is an unknown command; please do " instead.

Its a feature request. Also there is a few good reasons to do this.

I dont want to encourage customers to keep using a default config file. It should be only a way to generate their config file.
The switch of failure to find a config to using a default one is something that can easily be missed. Leading to time and confusion as to why things didnt happen and they realized it was because of the wrong config file.
No we also have a good example of the error we can see:

Using Kraken config file: /Users/jake.martin/.kraken/config.yaml
Pulling image 'quay.io/samsung_cnct/k2:v0.2' █▒▒▒▒▒▒▒▒▒ ^C
jake.martin@lt-jmart15-mac:kube2az-lab$ cd ..
jake.martin@lt-jmart15-mac:.kraken$ rm -f config.yaml
jake.martin@lt-jmart15-mac:.kraken$ kraken cluster update --config /Users/jake/martin/.kraken/kube2az-lab.yaml -v --update-nodepools clusterNodes
file /Users/jake.martin/.kraken/config.yaml does not exist```
It would be nice to stop full here and concentrate as to why this is occurring.

I don't necessarily want to advocate for doing away with the default config. I just don't want Kraken to translate kraken cluster up foobar to using the default config. Only kraken cluster up with nothing after it should do that.

ahh, yes, if there is extraneous junk kraken should be doing something intelligent with it (nothing and asking the user what they meant, probably) and just carrying on


Sample List & Details Pages

Hello, wondering if you can provide a sample that includes a real world scenario to see how you structure and list things.
One example would be a list of restaurants. When you click on the name of the restaurant you get a details page with: Name, Address, Phone Number, Photos, Lat/Lon, Rating etc.
Just curious how you would do things with your starter and feel it would help people learn by example.
Thanks

You can look at how I handle info for storing the users email, profile pic etc on firebase.  It would be similar to that.  I don't plan to create other examples at this time.  This is mainly just to give users a starting point when building their own app.  There are a lot of videos on youtube that provide tutorials for doing something similar to what you want.

This guy has a lot of good getx videos.  https://youtu.be/PQ_sxDjPUzU

Thanks. Yeah I like those vids, however his models are a bit different than yours. Curious how to handle maps & arrays with your setup but I'll keep chipping away

thanks for that!


Boruvka’s Algorithm in cpp

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Program to find the total weight f MST using Boruvka's algorithm in c++.
Checklist

[yes] I've read the contribution guidelines.
[yes] I've checked the issue list before deciding what to submit.
[yes] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Related issue: #5419

Kindly review this and let me know the feedback.
@HarshCasper @iamrajiv
@bhav09 @siddharth25pandey

@ankitaggarwal23  I have made the requested changes. Kindly review it.

@bhav09  I have made the requested changes. Kindly review it.


 )

Hey, you seem to have the only terminal audio visualizer i can even attempt to understand how to install on windows.
for this to work for me i had to use just " python -m venv. venv " ( idk why python 3 wouldn't work, and don't wanna find out LOL )
now when i try to run " source .venv\Scripts\activate " i get the error " Command 'source' cannot be found. "
is this just like a windows thing ? from what i can tell source is a linux command ? ( or maybe I'm interpreting it wrong )
Im using the Terminal application from the microsoft store to run all this code.

Update: got past that issue, now when running " pip install . " i get the following error,
" ERROR: Directory '.' is not installable. Neither 'setup.py' nor 'pyproject.toml' found. "
Not sure really where to go from here now tho

and this is the error im getting now after building


Add CodeQL configuration

Run automated code quality analysis using CodeQL (formerly LGTM).

Codecov Report

Merging #448 (7d9ca46) into main (6dc7f6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   77.51%   77.51%
=======================================
  Files          12       12
  Lines         636      636
  Branches       43       43
=======================================
  Hits          493      493
  Misses        131      131
  Partials       12       12

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix get_net_worth()

@dzg what kind of account shows up without a current balance? Just curious for better understanding of why this is needed.

@dzg what kind of account shows up without a current balance? Just curious for better understanding of why this is needed.


Firefox/Chrome - Logo doesn't appear on the OpenLayers map

We use the hackspace logo to indicate the location of the hackspace on the OpenLayers map, for some reason it doesn't load on Firefox and Chrome.

Safari

Chrome


new fraud site: secur()hopp()to

I'm getting text messages like the following with links to secur . hopp .to which is definitely a scam.

Thanks Devon @hyder365 I've added this and it goes live in the next release, in a few minutes.
Closing.


More info on the error below.
RaspberryPi 4b
WiFi connection, no ethernet connection
lxd/lxc version
5.8
Kernel
Linux version 5.15.61-v8+ (dom@buildbot) (aarch64-linux-gnu-gcc-8 (Ubuntu/Linaro 8.4.0-3ubuntu1) 8.4.0, GNU ld (GNU Binutils for Ubuntu) 2.34)
sudo lxc info --resources
Error: Failed to retrieve network information: Failed to add device information for "/sys/class/net/wlan0/device": Failed to add port info: Failed to ETHTOOL_GLINK: operation not supported

sudo iwconfig wlan0
wlan0     IEEE 802.11  ESSID:"X"
          Mode:Managed  Frequency:5.18 GHz  Access Point: 74:24:9F:D9:FA:23
          Bit Rate=351 Mb/s   Tx-Power=31 dBm
          Retry short limit:7   RTS thr:off   Fragment thr:off
          Encryption key:off
          Power Management:on
          Link Quality=48/70  Signal level=-62 dBm
          Rx invalid nwid:0  Rx invalid crypt:0  Rx invalid frag:0
          Tx excessive retries:0  Invalid misc:0   Missed beacon:0

ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN group default qlen 1000
    link/ether e4:5f:01:d9:b6:8c brd ff:ff:ff:ff:ff:ff
3: wlan0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether e4:5f:01:d9:b6:8d brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic noprefixroute wlan0
       valid_lft 40640sec preferred_lft 35240sec
    inet6 fd5e:9a9e:c5bd:10::7d5/128 scope global noprefixroute
       valid_lft forever preferred_lft forever
    inet6 fd5e:9a9e:c5bd:10:cb40:e41b:93d9:6b75/64 scope global mngtmpaddr noprefixroute
       valid_lft forever preferred_lft forever
    inet6 fe80::ae29:f6f1:7bc:69e0/64 scope link
       valid_lft forever preferred_lft forever
4: lxdbr0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default qlen 1000
    link/ether 00:16:3e:9b:58:07 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 scope global lxdbr0
       valid_lft forever preferred_lft forever
    inet6 fd42:8a3f:668a:ff03::1/64 scope global
       valid_lft forever preferred_lft forever

ip r
default via <IP_ADDRESS> dev wlan0 proto dhcp src <IP_ADDRESS> metric 303
<IP_ADDRESS>/24 dev lxdbr0 proto kernel scope link src <IP_ADDRESS> linkdown
<IP_ADDRESS>/24 dev wlan0 proto dhcp scope link src <IP_ADDRESS> metric 303

Originally posted by @petermakowski in https://github.com/lxc/lxd/issues/11131#issuecomment-1327195690

Based on @stgraber comment here https://github.com/lxc/lxd/issues/11131#issuecomment-1327787662 we are going to handle this issue by ignoring errors to that call and will be handled by the fix on that issue. Closing this issue as duplicate.

I'll take a look at a fix for this and the original issue today.

Once the original issue is fixed, if you still experience this issue we can reopen.


can you add the ['$scope', '$element',function(){}]

function($scope, $element) is not using explicit annotation and cannot be invoked in strict mode

Not clear on what you mean here. Are you referring to "use strict" or some other linting library?
If you mean it should follow the array format you have specified so it survives minification I would recommend coupling it with ng-annotate.


Slow mo button size adjusted to data size

Made from static size in pixels to a size having as a scale unit 1/35 of the image width


Fix nested query and type conversion in MySQL, remove unused codes

Codecov Report

Merging #4738 into master will increase coverage by 0.16%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #4738      +/-   ##
============================================
+ Coverage     49.87%   50.04%   +0.16%
- Complexity     2641     2647       +6
============================================
  Files           730      730
  Lines         18055    18040      -15
  Branches       1750     1747       -3
============================================
+ Hits           9005     9028      +23
+ Misses         8329     8285      -44
- Partials        721      727       +6

Impacted Files
Coverage Δ
Complexity Δ

...rage/plugin/jdbc/h2/dao/H2AggregationQueryDAO.java
7.69% <0.00%> (ø)
1.00 <0.00> (ø)

...mons/datacarrier/consumer/ConsumerPoolFactory.java
100.00% <100.00%> (+52.00%)
5.00 <0.00> (ø)

...p/server/core/analysis/metrics/PercentMetrics.java
90.90% <0.00%> (-9.10%)
5.00% <0.00%> (-1.00%)

...vider/parser/listener/SegmentAnalysisListener.java
72.72% <0.00%> (-3.04%)
13.00% <0.00%> (-2.00%)

...r/parser/listener/MultiScopesAnalysisListener.java
80.95% <0.00%> (-2.73%)
22.00% <0.00%> (-2.00%)

...er/storage/plugin/influxdb/query/MetricsQuery.java
22.50% <0.00%> (-0.84%)
5.00% <0.00%> (-1.00%)

...r/storage/plugin/influxdb/query/MetadataQuery.java
59.39% <0.00%> (+0.75%)
12.00% <0.00%> (+1.00%)

...walking/apm/agent/core/context/TracingContext.java
49.19% <0.00%> (+1.06%)
24.00% <0.00%> (ø%)

...ing/apm/agent/core/logging/core/PatternLogger.java
58.33% <0.00%> (+1.38%)
18.00% <0.00%> (+1.00%)

...r/storage/plugin/influxdb/query/TopologyQuery.java
64.91% <0.00%> (+1.75%)
15.00% <0.00%> (+1.00%)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33f583...ce42306. Read the comment docs.

Your branch can't be updated automatically.


[5.1] IRGen: Don't emit opaque type descriptors twice

rdar://50500620

@swift-ci Please test

Might want to add "[5.1]" to the title of this PR to distinguish it from its brethren.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 5bdeffb8004254ec82adcbad7921a61598b2ad1e

Build failed
Swift Test OS X Platform
Git Sha - 5bdeffb8004254ec82adcbad7921a61598b2ad1e


Updated Readme

100 days of code
Added #FAQ section

@soham117  you need to fix the README document. It doesn't looks good, try once on some markdown viewer to fix this.
Use hackmd !
Also FAQs will be above the maintainers.


refactor: routes

I refactored the routes part. So it will redirect you to /log or /healthlog depended on if you are logged in. And also it won't allow you to go on some routes if you don't have access to it. Probably we'll need to change callback for blackstack also since I thought it would make sense if login part be on route /log.

This is definitely a good idea and good contribution - it's important we only show relevant data if the user is logged in - but before reviewing / moving forward this seems related to #164 - maybe link up with @fallon7284 who is actively working on that ticket to see if you can share ideas / combine this into one PR?
Going forward I think it's best to only open PRs related to issues, and if there are no issues relating to the PR open an issue first - just to keep things organized 🚀

Thanks for feedback! I will definitely talk to @fallon7284 and next time will open an issue or find one.

Yeah so per issue #164 I made a PrivateRoute component that handles that conditional logic internal: you pass it a component as a prop and if the user is logged in it renders that component, otherwise it renders the login.  I'm just trying to work out some issues with my radiks server before I PR it because I want to make sure that is the source of an issue I'm having, rather than my code.

Hi @fallon7284, sounds good!
So then I just close this PR.


Gracefully degrate to non-APQ if server doesn't support APQ

Use case
In Apollo 2.x, when client has APQ enabled but server doesn't support it, Apollo would eventually fall back to full query with document:

Now, if server doesn't support APQ, Apollo will simply return an error:
https://github.com/apollographql/apollo-kotlin/blob/99126fdf4ebf7330a3dab7a3d7fc1f5b0fa122b7/libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/interceptor/AutoPersistedQueryInterceptor.kt#L52-L58
Describe the solution you'd like
It seems reasonable to fall back (or at least have an option to do so) to a full document query if server is misconfigured and doesn't support APQ. The reasoning is that it's possible, and would avoid client downtime due to e.g. temporary server problems. Clients can then log APQ errors to issue tracker of choice and resolve the issue on the backend while not losing functionality.

Hi! This does sound reasonable to me. Would you be interested in giving it a go? Otherwise I can have a look at it!

I can try!
Would it make sense to expose information about this error through AutoPersistedQueryInfo or a similar mechanism? Unfortunately it only supports val hit: Boolean so I'd need to do
AutoPersistedQueryInfo(
  val hit: Boolean,
  val serverApqEnabled: Boolean,
)

I suppose, wdyt? 🤔 Or I can not expose new information, just add AutoPersistedQueryInfo(hit = false) and let the user get errors via additional interceptors like https://github.com/apollographql/apollo-kotlin/pull/4709, though AutoPersistedQueryInfo is pretty convenient 🙂

Oh yes if you need to get back that information, AutoPersistedQueryInfo is probably perfect for that, and yes adding this field sounds good to me.

I think you can do this quite easily with an ApolloInterceptor you put in front of the APQ interceptor?
val interceptor = object : ApolloInterceptor {
  override fun <D : Operation.Data> intercept(request: ApolloRequest<D>, chain: ApolloInterceptorChain): Flow<ApolloResponse<D>> {
    return (chain.proceed(request).catch {
      if (it is AutoPersistedQueriesNotSupported) {
        // Recover
        emitAll(chain.proceed(request.newBuilder().enableAutoPersistedQueries(false).build()))
      } else {
        throw it
      }
    })
  }
}

It could even be made stateful so that the interceptor remembers a given server does not support APQ

@lwasyl did you end up finding a satisfying solution there? I don't want to leave this hanging so if you have a use case for it, go for it.

Ah, sorry I didn't see notification. No, actually it turned out that the interceptor you suggested is perfectly fine for my use case, even without https://github.com/apollographql/apollo-kotlin/pull/4709 :slightly_smiling_face:


Make NodeInfo API public

Reported by @shesek. Users might find it convenient to manually construct the tree using NodeInfo API
let leaf1 = NodeInfo::from_leaf_with_ver();
let leaf2 = NodeInfo::from_leaf_with_ver();

let root = NodeInfo::combine(leaf1, leaf2);
let spend_info = TaprootSpendInfo::from_node_info(&secp, internal_key, root);

It is a fairly small change, but don't want to add anything else to the already pending rust-bitcoin release.

I think this is needed for this release

ACK

This is good to have, but not mandatory! This can be emulated using the TaprootBuilder API. Don't necessarily want to make it release-blocking if it does have to be.

Well, it's quite trivial and requires just a single ACK more...

Regarding my nits, here and everywhere: I think the main challenge is to get ACKs, so all nits should be better addressed as a follow-up PR(s), if the author agrees with them - and not as a force-pushes discarding existing ACKs and taking reviewers time on non-important stuff once again.

I agree with you that all this re-acking is adding seemingly unnecessary work for reviewers.
Idea: what if we pushed the burden onto the merger instead of the dev or reviewer? By that I mean, merger could decide that changes since ACK where trivial (e.g., docs, non-logic-changing refactor) and therefore the ACK is still valid? That way if reviewer gets to the PR and wants to re-ack, fine, if merger gets to the PR and sees nit-only fixes, then fine too.

Idea: what if we pushed the burden onto the merger instead of the dev or reviewer? By that I mean, merger could decide that changes since ACK where trivial (e.g., docs, non-logic-changing refactor) and therefore the ACK is still valid? That way if reviewer gets to the PR and wants to re-ack, fine, if merger gets to the PR and sees nit-only fixes, then fine too.

This is possible, but I think we should keep this to a bare minimum, comment fixes, variable renames etc. I don't think code move refactors fall here because that has a big diff. I would be okay in doing this if the diff is fairly small(< 10-15 lines) and no code changes.

I really want to get this release out before bitcoin 2022 at Miami

This! @apoelstra do you think we can do this, would be very cool but also even more pressure not to get egg on our face :) I think we can handle it, what do you rekon?

Thanks! That's exactly what I wanted.
I wasn't able to test directly with this PR branch because I'm also using rust-miniscript which isn't compatible with rust-bitcoin's master (Prevouts "expected 1 generic argument"), but I was able to cherry-pick the changes on top of 0.28.0-rc1 and use the new public api in minsc.
With this in place, minsc now allows to construct custom taproot trees like in the first example (previously only huffman trees were supported, like in the second).

Legend @shesek, thank you.

The NodeInfo struct is now public but the fields are private and there are no getters/setters, are users able to use this struct as expected?

I have only made the minimal things pub so that the above example in the PR description works. Thankfully, Shesek is able to confirm that this works.

I noticed that non of the util::taproot types are re-exported out of util, is that what we want?

I don't have super strong opinions about this. But I have a preference that these should be re-exported from util.

I am about to try and do the 'add taproot example' issue, perhaps I'll add a bunch of rustdoc examples to the taproot module to test the public API?

Yes, please. I will also make a point to add rustdoc examples for future APIs. They are really handy.

Force pushed again addressing all the doc-comment nits.

ACK all the docs stuff, I have more docs fixes for the taproot module queued up. From my perspective we can put this one in and I"ll rebase on top of it. FTR I hadn't done that PR this morning when I requested changes on this one :) Thanks.

@shesek I did a PR https://github.com/rust-bitcoin/rust-miniscript/pull/324 that brings miniscript on the version of rust-bitcoin having all RC fixes merged, such that downstream can test and fix all APIs. Even if non-merged RC-fix PRs here will be modified, it will be a very tiny changes.
So, you can add this section to all of your projects:
[patch.crates-io]
bitcoin = { git = "https://github.com/LNP-BP/rust-bitcoin", branch = "canary" }
miniscript = { git = "https://github.com/LNP-BP/rust-miniscript", branch = "canary" }


etcd_log_package_levels for /etc/etcd.env

https://github.com/kubernetes-incubator/kubespray/issues/3699

ci check this
/lgtm

/approve


Rename application directory to hogwatch

Just an example of how to rename the application directory. The hogwatch script has been moved into bin directory, which is pretty common practice for structuring projects. There are other ways to do this of course (e.g. using entry_points in setup.py to have an entry script created automatically) but this is the simplest solution.

I was thinking of something along those lines.
Cheers!


[HOLD] Take the oldestReportAction from Onyx, not from filtered actions

Details
we are seeing an infinite loop in some public rooms on staging and production. This is how it works:

we have 50+ whispers sent to other people in a row
calling GetOlderActions for the oldest reportAction that's not filtered out returns the same 50 whispers, over and over

this PR fixes that by calling `GetOlderActions with the oldest reportAction on the report, even if that reportAction is filtered out.
Fixed Issues
$ n/a - #fireroom-2024-03-06-public-rooms-spamming-getolderactions
PROPOSAL: https://expensify.slack.com/archives/C06NANLJSJ0/p1709749611012229
Tests

Point NewDot dev at staging
Sign into a new account
Open https://dev.new.expensify.com:8082/r/6776919265133947
Verify that you can scroll back in the chat history without hitting an infinite loop.

[x] Verify that no errors appear in the JS console

Offline tests
n/a
QA Steps
same as tests, except with staging instead of dev

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/47436092/2b42a9f1-467c-4dcf-bcf9-7da5f3f462db

MacOS: Desktop

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/9680864/e9833278-6b4a-447c-8e0c-7e2a90978a71

MacOS: Desktop

Implemented alternate solution that may be better for performance, testing it out: https://github.com/Expensify/App/pull/37839

going to close this in favor of https://github.com/Expensify/App/pull/37839, which solves the same problem in a better way (extracting logic out of the Render tree)


Downloading does not work from tensorboard when launched as a vscode plugin

Environment data

VS Code version: 1,87,2
Jupyter Extension version (available under the Extensions sidebar): N/A
Python Extension version (available under the Extensions sidebar): v2024.2.1
OS (Windows | Mac | Linux distro) and version: windows
Python and/or Anaconda version: 3.10.13
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Jupyter server running: Local | Remote | N/A

Expected behaviour
Clicking on file download button downloads a file

Actual behaviour
Nothing happens. Download works perfectly when I start tensorboard from the anaconda environment and use it in a browser.

Same thing here


Provide Updated Guidance for Using Forms

@PaulKinlan @petele @addyosmani @jmadler
Guys,
Jordan had mentioned to me last week that he was interested in contributing on this topic specifically.
https://github.com/google/WebFundamentals/tree/next-version/src/content/en/fundamentals/design-and-ui/input/forms

Great! Would more than welcome help on this.

I would love to see more content on this land. Thanks @jmadler!


ydata wont get extracted - list full of zeros instead

I have a .dat file that follows the FAMOS format. (same as a raw file, as far as i know)
Im trying extract the measurement data from this file into python without the use of the official software since I'm planning on automating this process to compare this measurements with other data.
the first lines of it are as follows:
|CF,2,1,1;|CK,1,3,1,1;
|NO,1,7,1,0,,0,;
|CG,1,5,1,1,1;
|CD,1,32,1.000000000000000E-2,1,1,s,0,0,0;
|NT,1,27, 1, 1,1980, 0, 0, 0.0000000;
|CC,1,3,1,1;
|CP,1,16,1,4,7,32,0,0,1,0;
|Cb,1,49,1,0,1,1,0,23472,0,23472,1,0.000000000000000E+0,0,;
|CR,1,15,0,0,0,1,5,m/min;
|CN,1,25,0,0,0,13,Drahtvorschub,0,;
|CS,1,23474,1,!?í?í?Ý? ... ;

Its a long measurement, and transforming the data bytes as a sequence of 32 bit integers gives me a plot pretty similar to the one from the official software, but the proportions are off.
when i extract it using imcraw=imc_termite.imctermite(b'file.dat') and channel=imcraw.get_channels(True)[0], then channel['xdata'] contains a list with the data for the time (which wast directly stored as a sequence of numbers in the dat file), but channel['ydata'] contains a list full with zeros.
Like this:
channel['xdata']==[0.00, 0.01, 0.02, 0.03, 0.04]
channel['xdata']==[0.0, 0.0, 0.0, 0.0, 0.0]

I know the xdata is actually stored in the dat file, since ive extracted it by reading every 4 bytes of data and transforming them to an int, and plotting them to compare them. but i dont know what values im missing to modify my extracted data to the original data
gas_flow.dat.txt (its actually a .dat file, extension changed to allow upload)
gas_flow_official_export.txt (this is what the stored data should look like)
.

I just published version 1.2.12 that appears to fix this issue. Decoding your files with the new version gives me data that exactly matches your .export.txt file:
[0.0, 0.01, 0.02, 0.03, 0.04, 0.05, 0.06, 0.07, 0.08, 0.09]
>>> channels[0]['ydata'][:10]
[8.123157501, 8.152482986, 8.181808472, 8.093832016, 8.152482986, 8.152482986, 8.152482986, 8.064506531, 8.123157501, 8.093832016]```
It appears the meta-data (in particular the CR block) of the IMC file provides a (wrong?) rescaling factor = 0.0 which effectively annihilates the data. However, from now on, whenever the rescaling factor is zero it'll be reset to 1.0 , i.e. not rescaling the data at all.


missing line of code in get_started tutorial on website

as mentioned by an issue closed 19 days ago https://github.com/tensorflow/tensorflow/issues/11042 there is a line missing in the tutorial code at https://www.tensorflow.org/get_started/get_started#a_custom_model.
this earlier issue was closed, but on the current version of the site that i see, the issue still persists.
the missing line is:
eval_input_fn = tf.contrib.learn.io.numpy_input_fn({"x": x_eval}, y_eval,4, num_epochs=1000)
which should appear after:
input_fn = tf.contrib.learn.io.numpy_input_fn({"x": x_train}, y_train, 4, num_epochs=1000)
please note that these same lines appear in the code above the mentioned block in the "basic usage" section.
also, i hope opening a new issue is the correct action in this case. if i should have done something else, please let me know

@MarkDaoust do you know where it's at?

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/docs_src/get_started/get_started.md
Sir the custom model has been updated but is not being reflected on the website.
Please look through this.

Thanks for tracking that down<EMAIL_ADDRESS>The "root" section of the website is synced to releases, but this fix is already visible in the tf 1.3 docs.
This these docs will become "root" when 1.3 is released.


Can't handle import action in Silverstripe Admin

Hello,
I can't run your extension because of this error:
[01-Feb-2016 12:39:20] Error at framework/forms/gridfield/GridField.php line 678: Uncaught InvalidArgumentException: Can't handle action 'import' (http://tool.local/admin/testing-module/TestingCsv/EditForm/field/TestingCsv?TestingCsv[GridState]={"GridFieldSortableHeader"%3A{"SortColumn"%3A[]}%2C"GridFieldPaginator"%3A{"currentPage"%3A1}}&action_gridFieldAlterAction%3FStateID%3Dd6e5a75d584f2231434211d9f85a944d=Import from CSV)
This is how i'm including module:
    public function getEditForm( $id = null, $fields = null )
    {
        $form = parent::getEditForm( $id, $fields );

        $importer = new GridFieldImporter('before');
        $gridField = $form -> Fields () -> fieldByName ( $this -> sanitiseClassName ( $this->modelClass ) );
        $gridField -> getConfig()->addComponent( $importer );

        return $form;
    }

Could you help me? I don't know if i have some problem or there is some bug in extension.

Best
Przemek

@westwingpl Did you have any luck with this, because I am also experiencing the same issue?

@samwalshnz, I know it's a few years late but did manage to find a solution for this?


refactored a bit!

Hi,
I learned a trick from your code, but I thought I should explore the hack to you I learned it from the Udemy course, hope will use it in the future!
and also added the key inside map.
best regards

Hey, Thanks for the input. I looked up the syntax and I learned something new. Kudos


The plugin keeps re-publishing the same draft & then immediately unpublished it on every cron cycle

I recently launched my first Kirby website and today I realised that the autopublish.log file is larger than expected. So I looked into it, and I saw these in the log:
.
.
[2024-02-16 17:05:02.497627] [info] Auto-unpublished news/test-autopublish-auto-unpublish
[2024-02-16 17:10:01.756671] [info] Autopublished news/test-autopublish-auto-unpublish
[2024-02-16 17:10:01.804146] [info] Auto-unpublished news/test-autopublish-auto-unpublish
[2024-02-16 17:15:01.912729] [info] Autopublished news/test-autopublish-auto-unpublish
[2024-02-16 17:15:01.950906] [info] Auto-unpublished news/test-autopublish-auto-unpublish
[2024-02-16 17:20:01.652764] [info] Autopublished news/test-autopublish-auto-unpublish
[2024-02-16 17:20:01.687352] [info] Auto-unpublished news/test-autopublish-auto-unpublish
[2024-02-16 17:25:02.179824] [info] Autopublished news/test-autopublish-auto-unpublish
[2024-02-16 17:25:02.226582] [info] Auto-unpublished news/test-autopublish-auto-unpublish
[2024-02-16 17:30:02.495575] [info] Autopublished news/test-autopublish-auto-unpublish
[2024-02-16 17:30:02.542977] [info] Auto-unpublished news/test-autopublish-auto-unpublish
[2024-02-16 17:35:01.669064] [info] Autopublished news/test-autopublish-auto-unpublish
[2024-02-16 17:35:01.698959] [info] Auto-unpublished news/test-autopublish-auto-unpublish

It was the test page that I made to test this plugin last month.
The plugin has been publishing and unpublished the same test page again and again.
I assume it's because despite the page has been published/unpublished, the auto-publish and auto-unpublish fields still have a date and time set in it. So on every cron cycle, the plugin will:

found this draft with auto-publish date & time set
publish the page (draft -> listed)
found the page (which was just published) with auto-unpublish date & time is set
unpublish the page (listed -> draft)

Maybe the plugin needs to clear the date & time fields after publishing/unpublish the page.

TBH, I'm not sure the plugin should alter the field... ?
If I understand this correctly, the plugin works as designed and publishes/unpublishes as described in the field, right?

If I understand this correctly, the plugin works as designed and publishes/unpublishes as described in the field, right?

Yes, it seems to be working as you designed.
But because both autopublish and autounpublish fields still have values, the plugin keeps re-publishing the same draft and then immediately unpublish it.
To be clear, this will only happen when the page is set to use both autopublish and autounpublish.
.
I think that was unnecessary behaviour because there is no reason to re-publish the same draft and then immediately unpublish it, especially when the date & time for both autopublish and autounpublish fields already passed a long time ago.
For example, my test page has been auto-published and auto-unpublished last month. I had to manually clear the fields to make sure the page was not included again in the next cron. Or else the plugin will keep trying to re-publish the page until the end of the world~
That one test page also produces about 750kb of autopublish log after 3 weeks of cron every 15 minutes. There's probably someone out there who frequently uses both fields for many pages and didn't realise that their log files are growing bigger.
.
So what I was thinking is if I have to fix it on my own, the quickest solution is probably clearing the autopublish field after successfully auto-publish the page. The same goes for when auto-unpublish the page.

Hmmm. I'm still in dubio about actually altering the content file.
Maybe add a check if there's

both a publish date and an unpublish date
and when unpublish is < now

don't re-publish?

Yeah, maybe something like that should work too. As the issue is caused by drafts that has both publish and unpublish time set, we need extra check to exclude certain drafts from the autoPublishedDrafts collection.
When filtering autoPublishedDrafts collection, don't include the draft if :

The page has both $publishTime and $unpublishTime set
And both time has passed

Something like that?


change max_dns_answers default to 5

a default of 0 (unlimited) caused problems for large deployments

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/717/
Test PASSed.

From experience with customers we typically start Trials (low volume) at 1, new production services at 2.   When we know someone will do sizable volume we go to 3 or 4, but rarely go above 4 unless they are going to hit 250 Gbps or more.  Otherwise the content gets spread out too much among the caches.
Rough Math
200 Gbps / ~25 cache groups = 8 Gbps per cache group
With a setting of 4, each cache in a group would do 2 Gbps at peak
That is the point at which I would consider going to a higher value


Wrong event names after uglify-ing the code

I have an issue with the ldap client.
In one of my build step, the javascript code gets uglyfied. In that step, functions getting renamed etc. Normally that's not a problem, but because the event name in the client is generated off of the message name, a wrong event will be raised.
I think instead of getting the name from msg.constructor.name, getting it with msg.type would fix the problem.
I'll create a PR with my solution.

🔔 Ping @pfmooney 😊

https://github.com/joyent/node-ldapjs/pull/492

I am unclear why one would even need to minify/uglify this library. The intention of this library is to be used in a Node.js environment. Minification does nothing in such an environment.

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.


fix(esp_http_server): prevent concurrent access to socket used in async http requests (IDFGH-13263)

This resolves #13998 with the proposed patch.
With this fix, once a request handler detaches itself from the main http thread with httpd_req_async_handler_begin, the main thread does not read from that socket until the asynchronous handler gives back the session context with httpd_req_async_handler_complete.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@chipweinberger
Can you please take a look at the proposed change?
Thanks!

it's been awhile since i've looked at this code
but looks reasonable

sha=4a7f37105659383e154d38d89fbc89cc26e29d9a


Add "Further Reading" section to documentation.

Completes #1914

Perfect! Thank you @stevenmusumeche !


🚚 Migrate GitHub Actions Runners from DPAT to APC

User Story
As an Analytical Platform Platform Engineer
I want all DPAT hosted Actions Runner workloads to be migrated to APC
So that we can retire DPAT
Value / Purpose
🪦 DPAT
🚀 APC
Useful Contacts
@jacobwoffenden
User Types
Platform Engineering
Hypothesis
If we... [do a thing]
Then... [this will happen]
Proposal
Migrate runners
Additional Information
No response
Definition of Done

[ ] Actions Runners migrated to APC
[ ] Workflow labels updated
[ ] User docs have been updated
[ ] Another team member has reviewed
[ ] Tests are green

Helm chart deployed to APC prod, pull request to CaDeT created and sent to DE


Fix parsing of actions when updating Node in workflow UI.

It looks like something has changed recently and now when WorkflowManager
encodes Node into json it behaves similar to proto3: when 'state' and 'style'
in an action have enum value equal to 0, it's getting omitted from the resulting
json. That caused the javascript code to skip adding the Action object to the
Node. I'm fixing the javascript to account for that and consider missing 'state'
and 'style' as being equal to 0.

We should fix this differently in a couple of ways:

the zero value of an enum should be <enum>_UNKNOWN. In that case, it would be a programming error if the UI sees no field or the zero value
we can change the JSON to not omit the zero value: https://github.com/youtube/vitess/blob/master/go/vt/workflow/node.go#L119 Therefore we must remove the "omitempty" tag

Once these two things are realized, we can remove these existence checks from the UI (unless they're actually part of the UI). For example, the current UI skips actions without a name? Isn't that a programming error as well?

One more note:
The vtctld API endpoints use the "jsonpb" Marshaller for protobuf messages: https://github.com/youtube/vitess/blob/master/go/vt/vtctld/api.go#L87
In that case, we emit fields with zero values as well.
Unfortunately, we cannot use that package for non-protobuf structs. Therefore, it's fine to stick with the default JSON marshaller in the workflow manager. But we should not omit zero fields there as well.

So I had to omitempty flag set for a few values because the code that updates the UI only does so if the value is set. Looking back, this was a mistake: if a value is changed from non-default to 0, it's omitted in the JSON, so the UI won't update it, and keep the default. Not good.
The only place we should have omitifempty is the array of children nodes for a node, where we don't want to update the node sub-tree, but just the node itself.
I like the 0 value being UNKNOWN and a programming error. Would make more sense.
The only remaining question I have is this: do we want to optimize the UI updates, by only sending fields that have changed? This would have an impact on the go side, where we'd need to  somehow know which fields have changed (the current API could allow that, the Modify function could remember the state before, do a diff, send the diff only). That seems to be a lot of work for not much gain, so I vote not to do the diff, and send the full node every time.

+1 on sending the full node
If we do it otherwise, we would need to have an extra field which tells the UI which fields are set and which not.

On Michael's note: no we wouldn't, then we'd use omitifempty, and use the empty value for not setting the parameters, any other value to set it.
But let's not do that. I'll fix the code next week to change the enums, and always assume the fields have values. In the meantime, we can probably submit this PR that fixes a current problem.

LGTM

I almost started to implement the suggestions... So, Michael, should I implement them or merge this as is?

How about merging as is and then creating a new PR for the new changes?

OK. I can do that.


update test description for scorecard

Description of the change:
this PR clarifies that the scorecard test "CRDS have resources" needs to be updated by
the end user after code generation to have the test pass.
Motivation for the change:

/closes #3294


Fix clippy warnings

PR Info
Just fixes the clippy warrnings. I would like to point out that the declared MSVR does not correspond to the functions used, namely:

std::hint::black_box (min MSVR 1.66)
std::thread::JoinHandle::is_finished (min MSVR 1.61)

Oh. Really? I've been using hint::black_box for so long (probably in nightly)

Thank you, first and foremost, for such a rich ecosystem of modules that I use in my projects.
Currently, I am using sea-streamer with Kafka backend with a connection to Redpanda for:

Sending analytical events for subsequent processing and insertion into ClickHouse (requires batching transaction, AutoOffsetReset::Earliest)
Sending push notifications (requires batching transaction, AutoOffsetReset::Earliest)
Implementing Real-Time subscriptions in GraphQL by async-graphql (without transaction, AutoOffsetReset::Latest)

The inconvenience arises when it is necessary not only to accumulate messages, but also to add a minimum waiting time for debounce and a maximum for throttle (for example, like this in this demo with maxWait), deserialize messages, and then process events and commit the identifier to the consumer. At the same time, it is necessary to explicitly handle each type of backend for the identifier commit, which already sounds like the implementation of a first-class abstraction.
I wrote a small helper, the implementation idea of which I borrowed a bit from futures-batch and tokio::time::timeout. It partially eliminates the inconveniences mentioned above, but I am not entirely confident in its reliability. Because committing the identifier to the consumer should only occur after successful execution, otherwise retries should occur with backoff (for example module) and no new events should be received until then.
Maybe it's not really the module's area of responsibility, but I think it would be handy. Otherwise, I am completely fine with the implementation of the module in terms of usability.

Thank you for your input. I think may be we can have a BufferedProducer<P> that wraps a Producer and have some buffering parameters: 1. max batch size 2. min send interval
Speaking of which, I actually have implemented a similar thing somewhere in one of my projects.

So far, it is the batch processing of messages in the consumer that is causing the problem. I currently rely on batching from librdkafka to producer, but it won't work in Redis.


Realtime & historical stock market data API

Addition of Historical and real-time stock market data with given date range in python

please add it under gssoc

Addition of Historical and real-time stock market data with given date range in python

This is an open source API project.
You are not allowed to use any external API.


Simplify import path

Currently:
import { ZetaTokenConsumerUniV2 } from<EMAIL_ADDRESS>
I wonder if it's better to have something like this instead:
import { ZetaTokenConsumerUniV2 } from<EMAIL_ADDRESS>

Hey @fadeev, can you assign this task to me? I am more than interested to work on this!

Has been resolved a while ago. Imports now look like this, which is fine:
import ZRC20 from<EMAIL_ADDRESS>import ZetaEthContract from<EMAIL_ADDRESS>import ZetaConnectorEth from<EMAIL_ADDRESS>import ZetaConnectorZEVM from<EMAIL_ADDRESS>


v-repeat is inverse on safari

JSFiddle here:
http://jsfiddle.net/douso81p/
Expected output:
ONE
TWO
THREE

Output on Mac safari (and Windows safari):
THREE
TWO
ONE

Object repeat does not guarantee the order (same as for ... in in JavaScript, which is not specified in the spec and thus engine-dependent.)

Is the upcoming v-for the same?

@hbrls yes.


Merge refs/heads/refactoring/replaceobjectids into alpha

Merge refs/heads/refactoring/replaceobjectids into alpha

This PR has been merged into alpha and tagged as 1.5.48-alpha-202303052216. Thanks for your contribution!


Pds5 PMID:28343969

decreased histone H3-T3  phosphorylation during vegetative growth
synonym (H3-pT3)
descendent of FYPO:0002593 | decreased histone phosphorylation during vegetative growth
standard def
decreased protein localization to centromeric chromatin during vegetative growth
descendent of FYPO:0002909 | decreased protein localization to chromatin during vegetative growth
standard def
decreased protein localization to centromeric  chromatin  during mitotic metaphase
normal protein localization to centromeric  chromatin  during mitotic metaphase
phew....

decreased histone H3-T3 phosphorylation during vegetative growth FYPO:0006598
decreased protein localization to centromeric chromatin during vegetative growth FYPO:0006599
decreased protein localization to centromeric chromatin during mitotic metaphase FYPO:0006600
normal protein localization to centromeric chromatin during mitotic metaphase FYPO:0006601
edit file: a4cddd3e82506ac5f4ab954066caf47722f57c45
release: d06092d994244c76df2bc9ee50c63a389dd7eb16

i didn't find
decreased histone H3-T3 phosphorylation during vegetative growth FYPO:0006598
under
decreased histone phosphorylation during vegetative growth

typo in xp; fixed


fix: Fix build issues

What kind of change does this PR introduce?
Addresses #901

Summary

[x] This largely addresses the app failing to run as found in #901.
[ ] It also fixes the windows build

Checklist

[x] My code follows the style guidelines of OpenAdapt
[x] I have performed a self-review of my code
[x] If applicable, I have added tests to prove my fix is functional/effective
[x] I have linted my code locally prior to submission
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
[x] New and existing unit tests pass locally with my changes

How can your code be run and tested?
Build the app and run it

Other information

@KIRA009 can I merge this?

@KIRA009 thank you! 🙏
Is this ready to merge?

I am fixing the build as well in this PR

@abrichr This is now ready


change import of prop-types

I updated the import in all files...
Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

👍


onMessage prop is required in some or all environments for injectedJavaScript/injectedJavaScriptBeforeContentLoaded to work

Several users (e.g. in #1260 and #1291) are tripping up on the unintuitive behaviour of an onMessage prop needing to be provided in order for injectedJavaScript to run. It also tripped me up when I first came to use this package.
We currently document the behaviour in docs/Guide.md, in the section The window.ReactNativeWebView.postMessage method and onMessage prop:

However, I see no reason in the first place why lack of onMessage should abrogate JS injection, other than the fact that it's always behaved like this.
Here is what's causing it, in case anyone feels like making a PR:

src/WebView.ios.tsx#L339 messagingEnabled is set to false only if onMessage is defined.
src/WebView.macos.tsx#L320 messagingEnabled is set to false only if onMessage is defined.
src/WebView.android.tsx#L329 messagingEnabled is set to false only if onMessage is defined.
src/WebView.windows.tsx#L235 messagingEnabled is set to false only if onMessage is defined.
ios/RNCWebView.m#L1249-L1254: the injectedJavaScriptBeforeContentLoaded and injectedJavaScript user scripts do not get added if messagingEnabled is false (my own FIXME recommendation appears above these lines).
android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java#L1058-L1062: Addition and removal of JS interfaces are toggled by the state of messagingEnabled.
I can't find references to messagingEnabled in windows/ReactNativeWebView. Maybe I'm just looking in the wrong places, or maybe JS injection isn't supported at all on Windows, yet?

Since #1286 was merged, this issue is solved for iOS, but hasn't to my understanding been addressed for any of the other platforms.
The PR also didn't touch src/WebView.ios.ts, so it may furthermore be incomplete in any case.

if the code is broken, fixing the documentation would be great to save us poor sods from hours of struggle.  the current documentation for injectedJavaScript says nothing of adding an onMessage prop.  granted that is documented below in the section properly concerned with that, but no reader could draw the conclusion the two usecases are interdependent

in any case, the behaviour I see is a little different.  please refer to: https://stackoverflow.com/questions/61582866/why-dont-webview-script-injections-work

yeah, better documentation would certainly help but the behavior definitely changes in the last version or two
We're using the injectedJavaScript prop to add JS to our page that will hide some elements. It just runs this code:
document.querySelectorAll(`${selector}`)
          .forEach(selector => selector.style.display = 'none');

In the current version of our app, this code works correctly on iOS and Android. In a recent beta, I updated the version of react-native-webview that we're using and this function broke on iOS, but not on Android
adding onMessage={() => null} fixes the JS function but it's not obvious that this should be needed as I'm not expecting a message from the injected JavaScript

Still an issue as of 10.3.2.

I am already using 'onMessage'. Still it is not working to inject javascript.
My WebView something like that:
<WebView
onLoadEnd={() => { this._setstatus() }}
onNavigationStateChange={this.on_navigaton_new}
injectedJavaScript={custom_script}
onMessage={x => this.onMessageGet(x)}
javaScriptEnabled={true}
source={{ uri: this.state.url, forceReload: this.state.forceReload }}
allowsLinkPsreview={true}
incognito={true}
domStorageEnabled={true}
ref={(ref) => this.myWebView = ref}/>

still not fixed

Still an issue for me.


Handle empty files in archive, and some additions to chain.rs

Have made a couple of changes, primarily to add some extra functionality to the Chain struct.
The change to add is API-breaking in that it changes the return signature, so not sure how you feel about this - but happy to change that back if you feel strongly (otherwise a bump of version number would be necessary)
Also wasn't 100% sure what kind of error to raise if the unpacked size was zero. An UnexpectedEOF seemed close enough to what could be the problem, but can change that if need be...

Have corrected the compiler warning with latest commit...

Hi, I don't have any more changes in the pipeline for merging, so is it worth bumping the version? Is that all that is needed for crates.io to get updated?

Yes, It's absolutely worth bumping the version. I've been meaning to get this done. Will have it out tomorrow morning.

The version has been bumped to 0.7.0.


New Logs Desgin - Discussion

We all agree that the initial logging is not ideal and we want to change it soon in order to allow people to run their test and contribute more to the project.
Here my suggestion:
./mmt create en it data -e test
Will log only errors

./mmt create en it data -e test -v
Will log errors and warnings

./mmt create en it data -e test -vv
Will log everything inluding translation requests to the api

This should apply also to evaluate, tune etc

structure
logs (not runtime)
-> engine_name
-> api
-> training
-> tuning
-> evaluate
For the user dividing between master and slave does not make to much sense.

After discussions this will go to a future release. @davidecaroselli will reserve some time to add basic logging next week.

This task has been scheduled for this sprint (02/29 to 03/04). Basic logging will be available at the end of this week.


query.cancelQueries is not a function bug

latest update with commit call queryFn cancellation methods if provided (#94)  triggers query.cancelQueries is not a function error for me on component unmount

Yes, I'm experiencing the same.

I'm getting the same issue.

I'm getting the same error with 0.3.24?

Same issue here, it's breaking my build :'(

@davidcostadev the version with this fix has not been released yet. Change to v0.3.23.

@gndelia :point_up_2:

I tried that but I still got the same error.
In this case, it's happening in the context of a test: I am using react-testing-library to test a component tree, and the root of that uses react-query

Released! Thanks everyone!


Speed up typeaheads

I split this out from #13561  to make it a little easier to pick/choose commits for merging.
The first four commits here should be pretty much no-brainers to merge, and they are gonna remain in both PRs.  If we can got those merged, I'll rebase both, and then they'll be independent PR.
The gist of this PR is that we do lots of manipulating of queries inside loops, and it's better to do that outside of loops, particularly when we're doing expensive things like removing diacritics.
Some of the changes here will also speed up other stuff (like search bar search or user search).

I merged the first 4 commits for now to decouple this from #13561.

I just rebased these, moving the three least trivial commits to the end.  The very last commit adds a cache, and the two preceding commits are prep commits for that.  Everything else should be a fairly clear win.

I'm test-deploying this on chat.zulip.org so that we can verify how well it works with production data.

I re-pushed this with defensive code for when full_name === '' (or undefined).

ascii_full_name is a misnomer: remove_diacritics doesn’t return ASCII.
is_ascii = /^[a-z]+$/.test(termlet) is also a misnomer, albeit a preexisting one: it only tests for letters.
I would ask why _has_ascii_full_name takes values true and undefined rather than true and false, but first, why is it needed at all? Couldn’t you encode the same information simply by setting _ascii_full_name = full_name?

These have all been on czo and gotten burn-in, and they're all pretty basic.
Then can you remove the last three from czo?  I want to a) rework them and b) not have them on czo so we can re-measure the remove_diacritics overhead.

I merged a batch from here and pushed back for now since I don't feel ready to dig into the more complex second half of this yet.

Tim, thanks for pushing.  This is the next batch to look at (again excluding the last few commits):
  1 pick 882996f compose typeahead: Do matching/sorting without callbacks.
  2 pick acbf5cc refactor: Have compose_content_matcher return a function.
  3 pick 5910f9b Extract get_emoji_matcher.
  4 pick 88f66e9 Extract get_slash__matcher.
  5 pick 92a5d08 Extract get_language_matcher.
  6 pick 1455e39 Extract get_topic_matcher.
  7 pick b75517a refactor: Extract helpers for user/stream matching.

This is great, I merged all but the lack couple commits, and pushed back to avoid GitHub merge conflicts complaining.
For the get_ascii_full_name commit, maybe get_normalized_full_name would be a reasonable name for the function?

Steve and I were talking in personals about it. My benchmarks suggest that remove_diacritics isn’t actually expensive—I can call remove_diacritics on every name in CZO in 6 ms. If that’s true, it doesn’t seem worth the extra complexity of a cache.
(If we still do want this cache, my earlier comments still apply—the _has_ascii_full_name flag isn’t needed.)

I am closing this for now and renamed it to include 'remove_diacritics' in the title, just in case we want to resurrect it.

Sounds good, thanks for investigating.


Table.selectRow() opens maxTextLength area instead of selecting row

Environment
Masquerade version: 1.0-SNAPSHOT
Cuba version: 6.8.3
Precondition
Table has maxTextLength column.

Actual result
Table.selectRow(byText("Not a text of maxLength cell")) does not select the row but clicks on the maxLength cell and opens the area with the full text.
Expected result
The row selected.

Everything works ok with the latest version


ci: try removing the semantic release token

:tada: This PR is included in version 1.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


API: correctly provide name for cum functions

closes #12021

cc @mrocklin

0.18.0
In [1]: Series.sum.__qualname__
Out[1]: '_make_stat_function.<locals>.stat_func'

this PR
In [1]: Series.sum
Out[1]: <function pandas.core.series.Series.sum>

In [2]: Series.sum.__qualname__
Out[2]: 'Series.sum'

In [3]: Series.cumsum.__qualname__
Out[3]: 'Series.cumsum'

cc @mrocklin
this doesn't solve the cloudpickle issue, but I think makes progress

cc @mrocklin did you have a chance to try this?

Ah, sorry for letting this slip


Add DNX/KRE-specific commands to start code samples.

Add the correct (as far as I know) commands to start the code samples
depending upon whether the user is using DNX or KRE. The current
document seems to assume KRE in step 3 and DNX in step 5.

Hi @adamjames, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSOTBOT;

Closing to submit against dev branch.


[Feature Request]: Apply Now button is not looking good in internship page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
@HimanshuNarware I want to design apply now button in more attractive manner because it is looking so simple.
Use Case
If the apply now button will have some good design it will be well suited according to your website.
Benefits
No response
Add ScreenShots

@ kindly add labels on this issue and assign this issue to me.
I am well suited for this issue and can work on it in a less time.
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@HimanshuNarware please assign this issue to me, I'm excited to work on this issue.

@HimanshuNarware Please assign this issue to me. I'm eager to work on it. I'll change the "Apply Now" button and improve it. Please assign me this issue. I'll do my best to improve it.


remove steps 4&5 docker actions for openwhisk

please review and merge @sefuhrer

@csantanapr i am getting a merge conflict for this because it has already been merged in a different pull request into master.


Flip width and height on rotate

This is a really useful project. Saved myself from a headache with more complicated alternatives. Presently when you rotate the screen the width and the height remain as is despite having been flipped. Would be great if this could detect that so it does not have to be done manually. Not sure how or if that would be possible, but would be very useful if it were.

Yes, I think it would


Update Monokai Extended Light.tmTheme

Hey,
I've made a quick change for the light theme to be more easy on the eyes when using it with "draw_white_space": "all", in the settings.

bump


Plugin not working with Jekyll 3

Unable to activate jekyll-twemoji-1.0.0, because jekyll-3.0.1 conflicts with jekyll (~> 2.0) (Gem::ConflictError)

@josephmilla Thanks Joseph. Released v1.0.1 :heart:


Logon Error Info SESSION ID

Describe the bug
After connecting to our server with the sdl-freerdp command i get this message (see screenshot 1) 3-4 out of 10 times.
It doesn´t matter if i click accept or cancel, the session closes and i get back to the command line, where it seems that the whole process freezes (screenshot 2).
To Reproduce
Difficult because it does not happen everytime.
Expected behavior
It should work, with xfreerdp or wlfreerdp i don´t get this message.
Screenshots

Application details

FreeRDP version (sdl-freerdp /version)
FreeRDP 3.0.0-beta4

Command line used
sdl-freerdp /v:xxx /d:xxx /u:"xxx" /p:"xxx" /kbd:layout:0x00010407 /f /sound:sys:alsa,format:1,quality:high /bpp:32 /gfx:AVC444,thin-client:on

Output of sdl-freerdp /buildconfig
This is FreeRDP version 3.0.0-beta4 (3.0.0-beta4) Build configuration: BUILD_TESTING=OFF WINPR_HAVE_AIO_H=1 WINPR_HAVE_EXECINFO_BACKTRACE=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS=1 WINPR_HAVE_EXECINFO_BACKTRACE_SYMBOLS_FD=1 WINPR_HAVE_EXECINFO_HEADER=1 WINPR_HAVE_FCNTL_H=1 WINPR_HAVE_GETLOGIN_R=1 WINPR_HAVE_GETPWUID_R=1 WINPR_HAVE_INTTYPES_H=1 WINPR_HAVE_JOURNALD_H=TRUE WINPR_HAVE_POLL_H=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIBS= WINPR_HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL=1 WINPR_HAVE_STDBOOL_H=1 WINPR_HAVE_STDINT_H=1 WINPR_HAVE_STRNDUP=1 WINPR_HAVE_SYSLOG_H=1 WINPR_HAVE_SYS_EVENTFD_H=1 WINPR_HAVE_SYS_FILIO_H= WINPR_HAVE_SYS_SELECT_H=1 WINPR_HAVE_SYS_SOCKIO_H= WINPR_HAVE_SYS_TIMERFD_H=1 WINPR_HAVE_TM_GMTOFF=1 WINPR_HAVE_UNISTD_H=1 WINPR_HAVE_UNWIND_H=1 WITH_AAD=ON WITH_ADD_PLUGIN_TO_RPATH=OFF WITH_ALSA=ON WITH_CAIRO=OFF WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CLIENT_SDL=ON WITH_CLIENT_SDL_AVAILABLE=1 WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_CODECS=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_EVENTS=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SCHANNEL=OFF WITH_DEBUG_SDL_EVENTS=OFF WITH_DEBUG_SDL_KBD_EVENTS=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=ON WITH_DSP_FFMPEG_AVAILABLE=1 WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=ON WITH_FREERDP_DEPRECATED=OFF WITH_FREERDP_DEPRECATED_COMMANDLINE=OFF WITH_FUSE=ON WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_INTERNAL_MD4=OFF WITH_INTERNAL_MD5=OFF WITH_INTERNAL_RC4=OFF WITH_IPP=OFF WITH_JPEG=OFF WITH_KRB5=ON WITH_KRB5_NO_NTLM_FALLBACK=OFF WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=ON WITH_LODEPNG=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_NATIVE_SSPI=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSC_PKCS11_LINKED=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PCSC=ON WITH_PKCS11=ON WITH_PLATFORM_SERVER=OFF WITH_POLL=ON WITH_PROFILER=OFF WITH_PROXY=ON WITH_PROXY_APP=ON WITH_PROXY_EMULATE_SMARTCARD=OFF WITH_PROXY_MODULES=ON WITH_PULSE=ON WITH_RDTK=ON WITH_SAMPLE=ON WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SHADOW=ON WITH_SMARTCARD_EMULATE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SMARTCARD_PCSC=ON WITH_SOXR=OFF WITH_SSE2=OFF WITH_SWSCALE=ON WITH_THIRD_PARTY=OFF WITH_UNICODE_BUILTIN=OFF WITH_VAAPI=OFF WITH_VAAPI_AVAILABLE=1 WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_VERBOSE_WINPR_ASSERT=ON WITH_VIDEO_FFMPEG=ON WITH_VIDEO_FFMPEG_AVAILABLE=1 WITH_WAYLAND=OFF WITH_WEBVIEW=ON WITH_WEBVIEW_QT=OFF WITH_WINPR_DEPRECATED=OFF WITH_WINPR_TOOLS=ON WITH_WIN_CONSOLE=ON WITH_X11=ON WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XV=ON Build type:          Release CFLAGS:               -Wall -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -fno-omit-frame-pointer Compiler:            GNU, 12.2.0 Target architecture:

OS version connecting to (server side)
Win Server 2022

Environment (please complete the following information):

OS: [e.g. Linux/Windows/Android/..]
Linux

Version/Distribution: [e.g. Debian 10, Windows 2008, Android 10]
Debian 12

Architecture: [amd64, arm]:
armhf

Additional context
Not sure what causes it, the other two (xfreerdp and wlfreerdp) are working fine.
Cheers

well, some logs would help here?
not sure how to answer the question without these ;)

@akallabeth that´s a good point.
Got those for ya.

[logfile.txt](https://github.com/FreeRDP/FreeRDP/files/13202952/logfile.txt)

@pbuchholz123 [09:46:04:52] [18023:00004669] [INFO][com.freerdp.core] - [rdp_print_errinfo]: ERRINFO_LOGOFF_BY_USER (0x0000000C):The disconnection was initiated by the user logging off their session on the server.

you (or some tool/script) is terminating the session server side?
you might want to drop /bpp:32 /gfx:AVC444,thin-client:on maybe the server does not like some of these?

Hey @akallabeth

Yes, we just logged out our user.
We had some heavy performance issues without theese options, specially without thin-client:on (but i don´t know exactly why).. I tried now without theese options but the root issue still remains. I get the popup from my first post (screenshot 1).

Are there any other logs you maybe wanna have a look at?
Cheers

@pbuchholz123 well, you opened the issue with It doesn´t matter if i click accept or cancel, the session closes and i get back to the command line, where it seems that the whole process freezes (screenshot 2). so might help if you maybe add some details of what you actually mean by that (I assumed it quit the session?)

Hey @akallabeth
got some news for you.
I have to correct myself about the issue and my main point here...
It seems like the session freezes, but what actually happens is that the freerdp session gets minimized.
I wasn´t looking at the taskbar and what happened there but yeah, my mistake..
But i can´t get around why this popup even occours there.
So, here´s my full installation procedure.
Hardware:
Raspberry Pi 4 Model B Rev 1.1 with a 16 GB micro sd card
uname -a:
Linux raspberrypi 6.1.0-rpi4-rpi-v8 #1 SMP PREEMPT Debian 1:6.1.54-1+rpt2 (2023-10-05) aarch64 GNU/Linux
lsb_release -a:
No LSB modules are available.
Distributor ID:	Raspbian
Description:	Raspbian GNU/Linux 12 (bookworm)
Release:	12
Codename:	bookworm
Installation:

Got FreeRDP from github

git clone --depth 1 https://github.com/FreeRDP/FreeRDP.git --branch 3.0.0-beta4

Installed packages

sudo apt install
ninja-build
build-essential
git-core
debhelper
cdbs
dpkg-dev
cmake
pkg-config
xmlto
libssl-dev
docbook-xsl
xsltproc
libxkbfile-dev
libx11-dev
libwayland-dev
libxrandr-dev
libxi-dev
libxrender-dev
libxext-dev
libxinerama-dev
libxfixes-dev
libxcursor-dev
libxv-dev
libxdamage-dev
libxtst-dev
libcups2-dev
libpcsclite-dev
libasound2-dev
libpulse-dev
libgsm1-dev
libusb-1.0-0-dev
uuid-dev
libxml2-dev
libfaad-dev
libsdl2-dev
libsdl2-ttf-dev
libkrb5-dev
libcjson-dev
libpkcs11-helper-dev
liburiparser-dev
libsystemd-dev
libfuse3-dev
libswscale-dev
libcairo2-dev
libavutil-dev
libavcodec-dev
libwebkit2gtk-4.0-dev
libpkcs11-helper1-dev
(without the already mentioned packages, there is one more package i wasn´t able to install the first time i tried it => libfaac-dev. After some researches i installed it with the help of some changes in the /etc/apt/sources.list file.)

Building inside the freerdp folder

cmake -GNinja
-B freerdp-build
-S .
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON
-DCMAKE_INSTALL_PREFIX=/usr/local
-DWITH_SERVER=ON
-DWITH_SAMPLE=ON
-DWITH_PLATFORM_SERVER=OFF
-DUSE_UNWIND=OFF

cmake --build freerdp-build
sudo cmake --install freerdp-build

That´s it, basically.
I have tried it with and without installing the SDL2 / SDL2-TTF things, but the result was the same..
What am i missing?
Cheers

@pbuchholz123 oh, thank you for the update.
regarding the popup, it is a missing check (this message should not be shown, xfreerdp ignores it)


Discoverd heartbeat jitter

Each heartbeat should happen 3-5 seconds after the last successful one or 200-400ms after the last failing heartbeat.
Closes #823
Closes #2361
Refs #2638

LGTM


Pva/csl1307 dont take lock

don't take lock during wallet syncronization
added Buildable instance for MapModifier and CAccModifier
fix staging script

Shit, most logic in merge commit.

PACANI EST TUT KTO JIVOY? REVIEW TO BUDET?

It's better to do PR in master


Client should not shutdown provided executor

Description
#1844 introduced a new API that allowed creating Clients with an external Executor.
Multiple Clients can now share the same executor.
However, when a Client is closed it shuts down its executor no matter whether it was provided or created by the client itself.
That affects multiple clients sharing the same executor, reusing the executor for a client that had to be restarted, and lots of other scenarios where users assume control over their executor.
Steps to reproduce

Create two Clients with the same external executor
Close one Client
Continue using the second Client

Additional context
No response
Hedera network
other
Version
2.39.0
Operating system
Linux

Hi Oleg, you could use client.closeChannels();, which will not shutdown the executor.

This is counterintuitive from the API point of view and I expect every developer to fall for it. I'll update my client code as suggested. However, the point that SDK should not close user provided executor is still valid.

so a solution would be to track if the executor was user-provided or not, and in the former case, do not close it?

@steffenboe Yes, we could do that. If you feel like doing this, I don't have any problems with that.


Removal of network_state going to telemetry

@tomaka has agreed that prometheus is the better place for network metrics (See #5235). As such we can remove the network state column from telemetry and avoid sending the non-trivial amount of data across the wire.

(network_state is only sent on non-default telemetry verbosity levels.)

Telemetry server accepts network_state as an optional value already (since it doesn't appear on every interval message, or at least didn't use to), so it being absent won't break anything. Removing it will actually make things much simpler since I had to jump through some hoops to make sure we don't parse the whole JSON and bloat the memory, so happy to get rid of it.


UP-5001:(fix) Replace broken validation query resolver with simple va…

…lue.

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

https://issues.jasig.org/browse/UP-5001

Nice change -- simpler.  :+1: