DX and Clean Code: Peer review by valtat

Upon opening the project, it is very quickly clear what the project is about. The name and the readme indicate it's about a tabletop RPG helper application made with Python, all in one sentence. The features described after are easy to understand and concise. When looking at the code itself, it is apparent that the project is in very early stages and there is barely any functionality implemented yet.
Code structure and quality
The code is organized well for all intents and purposes. There is a src folder which contains the actual python file, which as flask initialized and one endpoint for the home page. It returns 'This will be a fine application' and doesn't do anything else yet. In the root folder of the project there is a readme and license files, which are clear and easy to read. At this stage of the project, there is not much else to comment.
Commit analysis
There are three commits so far, and they have some minor changes to the project, such as updating readme.md and adding the license.txt file. However, the commit messages are clear and I believe they follow good commit rules.
Communication and Documentation
The documentation is pretty solid. It lays out the foundation for the application, which seems to be well thought. The features included (Account management, character creation and management, game map & game notes) are a good starting point for building the application.
Suggestions for Improvement
The only suggestion I can give at this point is to work hard and make a good project =) But since we are at the beginning of creating projects in this course, I wouldn't worry too much.

Thanks for the review! It seems like Jontsu gave you the link to my main branch. The actual work is underway in the account_management branch and there is also a pull request.


Helm Chart; Auditing not working. "the server could not find the requested resource"

Describe the bug
When installing Falco through the helm chart, this issue falcosecurity/falco#1026, that relates to a wrong setting in the Auditsink, still persists. After setting this to the correct format, as described in this issue, my Kubernetes API log file is full with Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource errors. Tried generating some Kubernetes audits, that should trigger an alert for Falco as described on the Falco  documentation site, but no alert is given. This probably indicates that Falco is not receiving any audit logs.
How to reproduce it
Add the following to the Kubernetes API server:

--audit-dynamic-configuration
--feature-gates=DynamicAuditing=true
--runtime-config=auditregistration.k8s.io/v1alpha1=true

Set "auditLog", and "dynamicBackend" to true in the values.yaml, provided by the Falco Helm chart.
Install Falco with the Helm Chart with the command: helm install Falco -f values.yaml stable/falco. Used Helm 3.2.1, so the original commands on the Falco Chart Github site won't work anymore.

Expected behaviour
Audit logs from the Kubernetes API server getting received and inspected by Falco.

Screenshots
2020-05-11T11:05:24.005466424Z AUDIT: id="0b967b34-9750-4dcd-905c-cacf392c16c7" stage="ResponseComplete" ip="xx.xx.xx.xx" method="get" user="system:kube-controller-manager" groups="\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="kube-system" uri="/api/v1/namespaces/kube-system/endpoints/kube-controller-manager?timeout=10s" response="200"
E0511 11:16:46.538374       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:08:12.927495363Z AUDIT: id="d031c5b4-101e-4ba9-964f-fb8cc0b9b402" stage="ResponseComplete" ip="xx.xx.xx.xx" method="update" user="system:kube-controller-manager" groups="\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="kube-system" uri="/apis/coordination.k8s.io/v1/namespaces/kube-system/leases/kube-controller-manager?timeout=10s" response="200"
E0511 11:16:46.581997       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:02:22.342627937Z AUDIT: id="ec410dc7-8173-4528-aef6-d66a753524df" stage="ResponseStarted" ip="xx.xx.xx.xx" method="watch" user="system:node:workernode1" groups="\"system:nodes\",\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="default" uri="/api/v1/namespaces/default/secrets?allowWatchBookmarks=true&fieldSelector=metadata.name%3Dfalco-token-6z6x6&resourceVersion=33914&timeout=8m14s&timeoutSeconds=494&watch=true" response="200"
E0511 11:16:46.677243       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:15:01.198249466Z AUDIT: id="0046feb5-dea3-4361-b9e2-3472e01537e9" stage="ResponseComplete" ip="xx.xx.xx.xx" method="get" user="system:kube-controller-manager" groups="\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="kube-system" uri="/api/v1/namespaces/kube-system/endpoints/kube-controller-manager?timeout=10s" response="200"
E0511 11:16:46.880651       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:01:40.478150167Z AUDIT: id="12f28d4c-4e36-40a5-b3e0-faabb666b17d" stage="ResponseComplete" ip="xx.xx.xx.xx" method="get" user="system:serviceaccount:kube-system:generic-garbage-collector" groups="\"system:serviceaccounts\",\"system:serviceaccounts:kube-system\",\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="<none>" uri="/apis/apiextensions.k8s.io/v1beta1?timeout=32s" response="200"
E0511 11:16:46.903637       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:12:18.187986702Z AUDIT: id="e53e4dad-9a1d-49d3-95de-f2e26de39259" stage="ResponseComplete" ip="xx.xx.xx.xx" method="update" user="system:kube-scheduler" groups="\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="kube-system" uri="/api/v1/namespaces/kube-system/endpoints/kube-scheduler?timeout=10s" response="200"
E0511 11:16:46.908830       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:02:00.904053739Z AUDIT: id="e0b80922-c48c-4cbf-86ac-a5e545a5e2dc" stage="ResponseComplete" ip="xx.xx.xx.xx" method="get" user="system:kube-controller-manager" groups="\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="kube-system" uri="/apis/coordination.k8s.io/v1/namespaces/kube-system/leases/kube-controller-manager?timeout=10s" response="200"
E0511 11:16:46.959913       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:05:43.536143494Z AUDIT: id="855dcc7e-0fad-4d3f-bb8e-e7035adf48e4" stage="ResponseStarted" ip="xx.xx.xx.xx" method="watch" user="system:kube-controller-manager" groups="\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="<none>" uri="/apis/rbac.authorization.k8s.io/v1/clusterroles?allowWatchBookmarks=true&resourceVersion=33914&timeout=9m1s&timeoutSeconds=541&watch=true" response="200"
E0511 11:16:47.060695       1 metrics.go:109] Error in audit plugin 'dynamic_webhook' affecting 1 audit events: the server could not find the requested resource
Impacted events:
2020-05-11T11:08:30.947512433Z AUDIT: id="4c2b9bd7-c162-496b-af08-50e3744a0c5c" stage="ResponseComplete" ip="xx.xx.xx.xx" method="get" user="system:kube-scheduler" groups="\"system:authenticated\"" as="<self>" asgroups="<lookup>" namespace="kube-system" uri="/apis/coordination.k8s.io/v1/namespaces/kube-system/leases/kube-scheduler?timeout=10s" response="200"

Environment

Falco version: 0.22.1

System info:
{
"machine": "x86_64",
"nodename": "falco-b8kjr",
"release": "4.18.0-147.8.1.el8_1.x86_64",
"sysname": "Linux",
"version": "#1 SMP Thu Apr 9 13:49:54 UTC 2020"
}

Cloud provider or hardware configuration: Kubernetes 1.18.2
OS:
NAME="CentOS Linux"
VERSION="8 (Core)"

Kernel: 4.18.0-147.8.1.el8_1.x86_64

Installation method: Helm Chart

Additional context
Tried installing Falco as a host-based installation via the script on the Falco documention site. By using this method and configuring the Kubernetes API server, Falco works as expected and no issues appear in the Kubernetes API log.
Added this issue couple of days ago. When I looked at it agian, it was moved to the contrib section? Why? This is not a contribute report.

Since this proposal the helm chart has no the "official support" status, so it will be adopted by the contrib.
Please, unless you're sure that this issue relates to Falco and not to the helm chart, close this and reopen the discussion on https://github.com/falcosecurity/contrib/issues/16

Will try without the Helm chart, and report back!

Thanks @loetn let us know

Well, I just wanted to try to install Falco without the helm chart by following the documentation site describing the 'DaemonSet Manifests", but there is no Integration folder anymore. It also appears, that the "k8s-using-daemonset.yaml" is no longer on the master branch. Is this placed somewhere else now?
In response to @leogr answer, that the helm chart has not the 'office support' status; The Falco documentation site says: "Helm is one of the preferred methods for installing Falco on Kubernetes" and "The default method to run Falco on Kubernetes is to use a DaemonSet".
I hope you guys could enlighten me if this is still the case. If not, is the host-based installation then the preferred method? The host-based installation worked perfectly.

Thanks @loetn
Although the proposal mentioned above has been approved, we're still in the migration phase and the documentation needs to be updated. I agree with you that the current state may be confusing, sorry :(
Btw the /integrations directory was moved to the contrib repo too, you can find it here :point_right: https://github.com/falcosecurity/contrib/tree/master/integrations
Anyhow, I believe the host-based installation will be the preferred method once every action indicated within the proposal will be done (more context here).
Finally, if the host-based installation worked - I'm assuming the auditing too -, you confirm this issue relates to the helm chart only, correct?

Hi @leogr
Thank you for the clarification! We'll use a host-based installation then, and yes correct, the auditing worked here.
Also thank you for pointing out the integration folder. I found it, cloned it, and deployed the daemonset manually. Also deployed the auditsink as described in the README.md.
Everything worked! No errors in the Kubernetes API log file, and the Falco daemonset was receiving and monitoring the Audit logs. After a while, my Falco instance logs were full of Warnings K8s activities:)
So yes, I think this problem is related to the helm chart, which is a bit strange since, at least the auditsink, was the same as I used now..


Prevent MeshDataTool from crashing due to invalid bones/weights arrays

Fixes https://github.com/godotengine/godot/issues/49027.

Thanks!


Add KeyedModelHandler content to the multi-model ML page

Add KeyedModelHandler content to the multi-model ML page.
Also made some small edits to the existing content.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damccorm

Will merge once checks complete


Fix: typescript, eslint, and build-warnings

Summary
Now the ESLint works properly.
So all lint error with TypeScript now block the building process and show lots of warnings.
I'm trying to fix it all, but I'm not familiar with aptos and it also affect wagmi connector.
Can @mordochi please help me and take a look if I'm doing right on aptos sdk.
@q20274982 also check wagami part is right.
Related Links

Asana:
Checklist

[ ] Pasted Asana link.
[ ] Tagged labels.

Prerequisite/Related Pull Requests

wagmi-connector is processing well, but there are some warnings about ts-eslint. Do you mind if I push the changes to this PR after fixing them?

@q20274982 Sure, don’t mind

Looks good


how do I create a new recurring task

Hi everybody,
how do I create a new recurring task with todoman. I understand that I cannot edit the recurrence of an item with the edit dialogue. But how do I create a new item via command line with an recurrence?
Sorry if this has been answered in the docs, but I somehow can't figure this out.
Cheers
aga

Creating recurring events is also not supported (although completing one will automatically create the next one in the series).
I usually create recurring events on my phone, and keep in sync via vdirsyncer. Another option is to manually copy the RRULE into the file, but that's really a big hack and prone to breakage.
Gonna leave this open, since this needs to be implemented at some point.

Creating recurring events is also not supported (although completing one will automatically create the next one in the series).
I usually create recurring events on my phone, and keep in sync via vdirsyncer. Another option is to manually copy the RRULE into the file, but that's really a big hack and prone to breakage.
Gonna leave this open, since this needs to be implemented at some point.

Ah, many thanks then for the clarification. The workaround via phone works obviously.

Ah, many thanks then for the clarification. The workaround via phone works obviously.

This is a duplicate of #305


Fixed syntax error in code sample

It's not a syntax error: https://www.npmjs.com/package/lodash.assign

Ugh, right. Sorry to waste your time.

No worries! You now know about the awesomeness that is modular lodash :)


Proper special symbols encoding in windows

Resolves https://github.com/gophercloud/gophercloud/issues/1572

@jtopjian ready for review


Updating NW Policy to have notebook pod connect to DSP APIServer

The issue resolved by this Pull Request:
Resolves RHOAIENG-1689
Description of your changes:

Updating the DSPA network policy to have notebook pod connect to DSP APIServer, so that the notebook pods could connect to the DSP API Server without OAuth token interference.
Testing instructions

Deploy DSPO and a DSPA instance based on these changes.
Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-556

mostly lgtm at this point, but I want someone who knows more about NewtworkPolicy and overall kubernetes security to review this. I want to know if there are any risks to bypassing oauth this way. Could an attacker easily bypass DSP authentication by adding a label to the attacking pod? (I suppose if someone has priveleges to set a label on a pod in the namespace, they could probably directly access the DSP pod anyway?)

@strangiato wouldn't mind your opinion on this. You seem knowledgeable about stuff like this.


Install Issue

Hi,
I am very new to this field and attempting to set up a new environment using conda to replicate the TFold pipeline and AlphaFold processes as described in the documentation. However, I encountered an error when trying to create the environment with the provided yml file.
(base) C:\Users\Desktop>conda env create --file tfold-env.yml
Channels:

conda-forge
defaults
bioconda
Platform: win-64
Collecting package metadata (repodata.json): done
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

bioconda::kalign2==2.04

Current channels:

https://conda.anaconda.org/conda-forge/win-64
https://repo.anaconda.com/pkgs/main/win-64
https://repo.anaconda.com/pkgs/r/win-64
https://repo.anaconda.com/pkgs/msys2/win-64
https://conda.anaconda.org/bioconda/win-64
https://conda.anaconda.org/bioconda

To search for alternate channels that may provide the conda package you're
looking for, navigate to
https://anaconda.org

and use the search bar at the top of the page.

Hi! I think the issue is this: "Platform: win-64". You will not be able to install kalign2 or AlphaFold under Windows. You need Linux


KeyError: 'rgbs' when training

Thanks for your excellent work. When I train the datasets following Usage in Readme, A bug occurs:
=> logs/
Epoch 1 (1/300)
Learning rate: 1e-05
Epoch 1 (1/300)
BN momentum updated to: 0.1
Learning rate: 1e-05
BN momentum updated to: 0.1
0%|                                                                                | 0/3481 [00:00<?, ?it/s]Exception in thread Thread-2:
Traceback (most recent call last):
File "/share/home/yjs001/miniconda3/envs/gputest_py3.7/lib/python3.7/threading.py", line 926, in _bootstrap_inner
self.run()
File "/share/home/yjs001/names/zyx/code62/VITACADTransformer/utils/utils_model.py", line 267, in run
for item in self.generator:
File "/share/home/yjs001/miniconda3/envs/gputest_py3.7/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 521, in next
data = self._next_data()
File "/share/home/yjs001/miniconda3/envs/gputest_py3.7/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 561, in _next_data
data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
File "/share/home/yjs001/miniconda3/envs/gputest_py3.7/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 49, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/share/home/yjs001/miniconda3/envs/gputest_py3.7/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 49, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/share/home/yjs001/names/zyx/code62/VITACADTransformer/dataset.py", line 132, in getitem
return self._get_item(index)
File "/share/home/yjs001/names/zyx/code62/VITACADTransformer/dataset.py", line 112, in _get_item
rgb_info = np.load(rgb_npy_path, allow_pickle=True).item()['rgbs']
KeyError: 'rgbs'
I have searched the rgbs in code:
dataset.py:112:            rgb_info = np.load(rgb_npy_path, allow_pickle=True).item()['rgbs']
Is the code in CADTransformer completed?

change config to skip

Hi what did you change on the config file?

@pangchunhei in default.py I've set rgb_dim to 0


[Feature] clock skew

implement clock_skew parameter
update unit test

This PR introduces the clock skew parameter, that allows to account for time differences between servers.

Could you also update the LcobucciJWSProvider class? I can do it otherwise.
Thanks for proposing this feature

I needed this for a project I'm working on, so why not share the implementation 😄
I'll update the other provider class in the next days.

Finally had the time for it, also updated the corresponding tests.

Thanks @patrickjDE for working on this feature, this is much appreciated.


Editor: Qt6 compatibility

When this gets merged, I want to add Qt6 building from source to the FreeBSD part of the CMake build chain. That way all package builds are built against the same library versions. Keeping dependencies consistent will help with testing and hopefully prevent platform package updates from breaking everything. I love how much of your build system is completely detached from system dependencies and now that FreeBSD SDK builds are starting to come down the pipeline in a consistent way, once this gets merged, I can focus on FreeBSD port parity and you can keep upgrading the engine and tools and fixing bugs that are not platform dependent.


fix: allow optional params instead of requiring explicit undefined param

I'm using typescript with synpress
my IDE was complaining about the required argument when I called cy.acceptMetamaskAccess()
and it only accepted cy.acceptMetamaskAccess(undefined)
This change will allow cy.acceptMetamaskAccess() to be used in .ts files

@fionnachan released with<EMAIL_ADDRESS>Thanks!


GH Actions: update for the release of PHP 8.3

... which is expected later today.

Builds against PHP 8.3 are no longer allowed to fail.
Add allowed to fail build against PHP 8.4.

Note: the branch protection settings will need an update for this PR.

Note: the branch protection settings will need an update for this PR.

@jrfnl did you remove the branch protection? Because I can merge the PR 🤷🏼♂
Or is it because we're maintainers?

Note: the branch protection settings will need an update for this PR.

@jrfnl did you remove the branch protection? Because I can merge the PR 🤷🏼♂
Or is it because we're maintainers?

I had not, but I have now. It wasn't that the PR would be blocked, but we'd want to block future PRs if builds against PHP 8.3 don't pass, so I've added the two 8.3 builds to the required checks now.


⚠ ClamAV has degraded performance

In 4c6b945, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: ClamAV performance has improved in 9908b8e after 5 minutes.


Game 2 pyaudio error

I got the following error on python3.6.8 running game 2:
Traceback (most recent call last):
File "Game2.py", line 75, in
cocos.director.director.init(caption="Pikachu Go Go Go")
File "C:\Users\mik\AppData\Local\Programs\Python\Python36\lib\site-packages\cocos\director.py", line 356, in init
cocos.audio.initialize(audio_settings)
File "C:\Users\mik\AppData\Local\Programs\Python\Python36\lib\site-packages\cocos\audio_init_.py", line 58, in initialize
music.set_control('dummy')
I asked around and someone said the audio needs to be initialized and gave the docs: http://python.cocos2d.org/doc/api/cocos.director.html#cocos.director.Director.init .
I'm a beginner to cocos so I don't know how to fix this. Help please.

you need to install the specified cocos version.


[5.3] [WIP] Convert rule objects to array

That way there is no need to convert the rule object in a string and then parse the string. In theory it should make the rule parsing faster, but anyway since we already have an object it kind of makes more sense to work with it directly.
This is just a proposal and a work in progress to discuss.
I'm also thinking I should have committed this one  for Laravel 5.4?

What bug does this fix?

@taylorotwell it does not solve any bug in particular, this is a proposal to reduce the amount of parsing:
Instead of: new Rule -> __toString -> parseRule -> parseParameters -> validate
Do: new Rule -> toArray -> validate.
If the final rule does not depend upon a string we could clean/reduce the amount of code and it theory it should run faster.
Also in a future we could enhance the validation functionality, allowing developers to create their own rules without the need to register them in the validator class, etc.

Going to hold off on this since we don't really have any profiling data to tell how much of a performance improvement it is. I would like to have that kind of data for any performance related PRs.


[Create New Issue]: Can Add a contributor count in readme

Calculator Functions
Description
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

./assign

/assign


how to do one to many and one to one in ER diagram?

System information:

Operating system (distribution) and version
DBeaver version
Java version
Additional extensions

Connection specification:

Database name and version
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)?

Describe the problem you're observing:
Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

I am using 6.24

Is it still actual for you? Could you give more info?

there is no update on issue for a long time. if it is still actual for you - feel free to reopen the ticket.
BR


Documentation

This is just a reminder for me to add a docs skeleton.

http://readme.io/ might be an alternative

Docs are failing; we should figure out why and remedy this.

Docs aren't actually failing, but the badge seems to be broken:

Oh... ok, I'll fix the badge then

This badge was just not synced.


Add method to OscFunctionLibrary to remove sendTargets

This PR adds a method to OscFunctionLibrary (and OscSettings) to remove one or all of the sendTargets at runtime.
I'm wanting to use this in my own code to allow my OSC device to send a "Sync" message, and have UE4-OSC automatically set up its own sendTarget. If the device disconnects, or is swapped out with another, I want to be able to remove the existing sendTargets before registering a new one.

Thanks for the contribution!
After giving it some thought, I'm not sure about it:
As you know, the AddSendTarget() function dynamically creates a new sender and returns an index that you can use to actually send a message to it. The returned index is basically the position in the _sendAddresses array.
If one removes an item from the middle of it, all previously returned indices become invalid. If the index is stored, as it should be, the next message will arrive to the bad recipient. And there is no obvious way to know that something bad happened.
(that could be managed using an indirection table, but...)
If I understand correctly, you are afraid to accumulate too many senders, when clients connect/disconnect.
Alternatively, you could use the GetOrAddSendTarget function, which adds a sender only if it's not known already.


panlex_lite installation

Hello All,
I know this issues is raised in other threads as well, sorry for a new threads as i did not got answer of what i am looking for
System : Mac,
OS        : OS X, 13F1911
Python Version : 3.5.2
Nltk Version : 3.2.1
Downloaded all packages. Command Used
python3

import nltk
nltk.download()

panlex_lite download get stuk
Tried downloading few time
Tried downloading panlex_lite.zip independently
In both of the above cases got a file of 2.34 GB
When i replaced the corrupted file in nltk_data/corpora/ folder
tried >>>nltk.download() again no luck
Tried with zip file and also after unzipping it
output of suggested code
import zipfile

plzip = '/Users/nishkarsh/nltk_data/corpora/panlex_lite.zip'
[zifo.CRC for zifo in zipfile.ZipFile(plzip).infolist()]
[0, 448887900,<PHONE_NUMBER>]

The python popup is showing out of date only.

Can any one plz help the way forward

@kamholz: would you please advise?

@stevenbird panlex_lite was recently regenerated. Probably the checksum in the index.xml is wrong. How can we make sure it's always up to date?

I had the same issue. I used nltk.download('all') and got timeout error at panlex_lite

I've made the panlex corpus point to a dated version (currently panlex_lite-20170401.zip) and updated the checksums. Please try again, and open a new issue if the problem persists.


Issue in indentation when formatting consecutive objects

There's a very annoying issue when hitting "format code" in a TS file. Here's an example:
[{
}, {
}]
// or
fn({
}, {
})

becomes:

[{
}, {
  }]
// or
fn({
}, {
  })

This gets really annoying when you have large nested objects containing things like functions etc...

I guess this needs to be reported against TS.

So all code formatting is done in the tsserver? There are a couple of other issues as well.

This issue was moved to Microsoft/TypeScript#6339

Setting verified label. Issue got moved to TS.


Npm Update

Can you update npm package?
For me fill method not work, it's color only with blue

This fork has the issue fixed:
https://github.com/protobi/msexcel-builder
If you want to install from NPM website:
https://www.npmjs.com/package/msexcel-builder-protobi


JW-281 JW-299 Added support for multiple enable/disable in extension. This should fix the crash

Please update jenkins job


Fix author affiliation for CDN change article

Fix author @haubles affiliation in the upcoming article.

@nate-double-u , for your attention.


Squashed image in iOS Safari

Hi,
I'm using this library for a project to orientate the images correctly. So far so good.
But the canvas created in iPhone 6 (iOS Safari) is squashed to fit the horizontal bounds in portrait mode.
        const image = await loadImage(
          selectedMedia?.user_media,
          function (img, data) {
            alert("Original image width: " + data.originalWidth);
            alert("Original image height: " + data.originalHeight);

            alert(img.width + " - " + img.height);

            console.dir(img);

            setMediaContent(mediaRef.current);

            console.log("orientation", orientation);

            if (orientation === "portrait") {
              mediaRef.current.style.setProperty(
                "--media-captured-align-items",
                "center"
              );
            } else {
              mediaRef.current.style.setProperty(
                "--media-captured-align-items",
                "flex-start"
              );
            }

            mediaRef.current.appendChild(img);
          },
          {
            orientation: 1,
            maxWidth:
              orientation === "portrait"
                ? window.innerWidth
                : window.innerHeight,
          }
        );

Hi @gippea,
thanks for your report.
Unfortunately your code snippet is not sufficient to identify the issue.
Could you provide more information please, including the following:

iOS version used
Sample image provided via URL

Also, could you confirm if you can reproduce the issue on the demo?

Closing as non-reproducible.


Update animation-transmog to v2.1.0

Refactored deprecated AnimSpot related code.
Decoupled animation effect timer from client FPS.
Made overriding default client animations more reliable.
Added lastUpdated field to database records to allow for pruning old/unused database entries.
General cleanup and removing unused code.

Noting additional commit that fixed previous build check failure https://github.com/ArtimosPenguidor/animation-transmog/commit/0c76d8fe3bfafca69a7d30ff8643584bbfe90e23


Add support for azurerm_monitor_diagnostic_setting

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/monitor_diagnostic_setting
This is especially important now because it's possible to add a diagnostic setting to a resource, then that resource can get deleted without the diagnostic setting. Need to be able to generate random names for the diagnostic settings as a workaround until the azure monitor team fixes it.

added the resource in pr #63

Closing as merged in #pr63


WebSocket`CallBack  should synchronized?

What kind of issue is this?

[ ] Question. Should I synchronized WebSocket` CallBack? or OkHttp has prcoessed?

It’ll always get called back on the same thread. Unless you’re making multiple web socket connections simultaneously.

thx


New version: zhanglun.Lettura version 0.1.12

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

This manifest contains a term that is blocked:

Created with YamlCreate.ps1 v2.2.12 $debug=QUSU.CRLF.7-4-0.Win32NT # Created with YamlCreate.ps1 v2.2.12 $debug=QUSU.CRLF.7-4-0.Win32NT # Created with YamlCreate.ps1 v2.2.12 $debug=QUSU.CRLF.7-4-0.Win32NT # Created with YamlCreate.ps1 v2.2.12 $debug=QUSU.CRLF.7-4-0.Win32NT

(Automated response - build 510.)


Why didn't this work in CPP files?

I can use it on json but not in cpp for no reason, I used to be able to use it but I can't now, anyone help? I have tried restarting and unistalling the extension for the 100th now

This extension uses VSCode api to work with any language. .json file name (in tab) on your first screenshot highlighted in red. And it shows squiggly underline => Error Lens can work with that.
Second screenshot shows that .cpp file doesn't have errors that VSCode knows of. I do not write .cpp so you have to search how to do that somewhere else.


The filetype is empty instead of no-neck-pain

Description
When executing the set filetype command in the windows generated by no-neck-pain, the filetype used to be 'no-neck-pain', but now it is empty.
Additionally, I confirmed that this change was caused by the commit at https://github.com/shortcuts/no-neck-pain.nvim/commit/ba7475920e0de811768728589f6c1c7df156c803.
Steps to reproduce

Open any file.
Move to the window generated by no-neck-pain.
Execute the set filetype command.

Then displays
filetype=

Expected behavior
filetype=no-neck-pain

Environment

Neovim version: v0.10.1
no-neck-pain.nvim version: 1.16.0 4b099238b3518bfc669cf09df90cbad11540176c

Hey @tadashi-aikawa thanks for opening the issue and using the plugin
I thought I had a test case for that, great catch!
I'm currently working on the new major but will also ship the fix on the v1 branch, tagged as 1.4.2 ASAP!
In case you want to avoid those potential bug fixes, you can target de 1.4.1 version safely

ohhh it's you that owns https://minerva.mamansoft.net/Home? I usually look for "no-neck-pain.nvim" last month searches in google and always see your website :D

@shortcuts
Thank you for your prompt response! I've confirmed that the issue has been fixed. 👍
I'm not sure what changes will be made, but I'm looking forward to the next major version update. :)
Yes, Minerva is a site where I publish what I've created with PKM. No-neck-pain.nvim is an amazing plugin that solved the problems I had with my ultrawide monitor, so I've featured it on several pages. 😊


Update bower.json

You should make this compatible with the latest ionic framework

@darmie I have tried the new slides in Ionic 1.3.2. But it doesn't work correct. So I won't upgrade to Ionic 1.3.2 right now.

@twinssbc  Oh I see, It worked for me though.


Fixes most common complaints about map, color contrast

This still needs the challenge block time estimates and the nonprofit project / interview practice sections added to the bottom of the accordion.
I can add these in a subsequent commit but I have to do some baby stuff real quick.
The sooner we get these fixes into production the better.

Two major usability issues:

It does not retain your position after a screen refresh. This essentially trades a "I have to scroll a lot" for a "I have to click a lot" problem
No "Expand all" button - if you don't know where you are, you can't scan/search for it.
Minor issues:
It's not at all obvious that these are accordians until you click on them. I at first thought there was a bug or error.
Long challenge titles (IE: many of them) wrap unappealingly
While the color is a better muted green, plain black would be better.
The indent may be a bit much. We're losing a lot of horizonal space for that indent.

There is also a bit of a "hitch" after the expansion where the elements that are expanding pop up vertically about 5-10px after the animation is done.
It might also make sense to have different levels have different colors. Maybe the same green for the top-most layer and then black for the lower levels - this gives a bit of an accent color
Not in love with the animation, actually. Maybe just remove the animation delay entirely?
Can we add little expandy triangles to the left of the menu elements? I don't know that the Accordian has that by default, so maybe not. Some sort of visual indicattion that things are expandy?

:+1:


can you expalin the result of DHVR in Tab1?

DHVR has not released the code, how did you measure his result?
original words from your paper:The results of DHVR we tested have some difference with the original results, so we also report the results in their paper (DHVR-Origin in Tab. 1).

The code of DHVR is available here: https://github.com/POSTECH-CVLab/DHVR

thank you!
------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2022年10月30日(星期天) 晚上11:01
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [ZhiChen902/SC2-PCR] can you expalin the result of DHVR in Tab1? (Issue #7)
The code of DHVR is available here: https://github.com/POSTECH-CVLab/DHVR
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Add license

There is no License file, nor does the Readme specify under what license this code is published. Could this please be added?

Thanks @angerman - good call, I've added a licence.


Convert CompendiumBrowser to ApplicationV2

Plus some general enhancements.

Move browser settings to a separate Application
Add "Settings" button to browser window controls
Move roll table buttons to browser window controls
Move individual listeners on result items to global listeners on the list
Leverage HandlebarsApplication part rendering
Use gsap for the drag fade animations
Fix (or implement?) setting the level filter in the crafting tab of the character sheet
Fix up dark mode styling
Probably more

Everything should look/work (nearly) the same as before.
Controls:

Light:

Dark:

yeah I wanted to wait for svelte support initially but the version 5 release has taken so long that I thought it made sense to convert to the handlebars renderer first. Switching out the renderer later should be relatively straight forward.

But if that isn't something you want to do I can keep this in a stash until svelte is ready. It definitely helped me to better understand ApplicationV2 so it wasn't for nothing.

I'll yoink the basic svelte stuff from the other PR and try it out for this. Converted to a draft in the meantime.

I've pushed the svelte browser and updated the description with new infos and current screenshots. The changed file count just kept rising, sorry. 🙃


pkeyutl documentation on ECDSA wrong?

Applies to OpenSSL-1.0.2r and OpenSSL-1.1.1-stable (haven't checked 1.1.1-dev).
Problem
Man page for openssl pkeyutl is misleading/incorrect. It states:

The EC algorithm supports sign, verify and derive operations. The sign and verify operations use ECDSA and derive uses ECDH. Currently there are no additional options other than digest. Only the SHA1 digest can be used and this digest is assumed by default.

Thankfully, ECDSA does support SHA256, SHA384, SHA512 - so the above text is wrong.
Illustration:
$ openssl version
OpenSSL 1.0.2r  26 Feb 2019
$ openssl rand -out t.dat 48
$ openssl pkeyutl -engine pkcs11 -keyform engine -sign -inkey "pkcs11:manufacturer=piv_II;object=SIGN%20key;object-type=private" -pkeyopt digest:sha384 -in t.dat -out t.dat.sig
engine "pkcs11" set.
Enter PKCS#11 token PIN for Uri:
$ pkcs11-tool -r -y pubkey -d 02 > t-pub.der
Using slot 0 with a present token (0x0)
$ openssl pkeyutl -engine pkcs11 -keyform engine -verify -pubin -inkey "pkcs11:manufacturer=piv_II;object=SIGN%20pubkey;object-type=public" -pkeyopt digest:sha384 -in t.dat -sigfile t.dat.sig
engine "pkcs11" set.
Signature Verified Successfully
$ openssl dgst -engine pkcs11 -keyform engine -sign "pkcs11:manufacturer=piv_II;object=SIGN%20key;object-type=private" -sha384 -out t.dat.sig1 t.dat
engine "pkcs11" set.
Enter PKCS#11 token PIN for Uri:
$ openssl dgst -keyform DER -verify t-pub.der -sha384 -signature t.dat.sig1 t.dat
Verified OK
$

Documentation (pkeyutl.1) should be edited, removing from the EC ALGORITHM section the part about SHA-1 digest, as it's clearly not the only one supported.

Fix in #8432.

Thank you! Should this fix apply to 1.0.2 as well?

Closing, as the fix has been submitted, hopefully merged soon.


chore: update QuestDB version for stocks example

Removign commit lag setting as it won't be needed for QuestDB 6.6

This is replaced by https://github.com/questdb/kafka-questdb-connector/pull/6


Added Alert for ControlPanel and ChartContainer

Done:

Add alert for Control Panel when fetch_datasource_metadata failes
Add alert for Chart Container when update_explore query fails

Control Panel alerts:

Chart Container alerts:

needs-review @ascott @bkyryliuk @mistercrunch

this looks great! nice work!
i wonder if we should use the yellow alert here rather than blue? i'm not a big fan of the red/danger alert, but i think the yellow works well for these type of fetching errors/user feedback.

Changed color :) @ascott

LGTM once tests are passing :ship:


[USABILITY] Improve Grammar in Status Update String

The Status Update panel (see screenshot below) has an ungrammatical sentence:

You were required an action by health authorities

I believe this line is a string in the app.
Screenshots

To Reproduce
This screen appears automatically when a user opens their app for the first time after their health status has changed.
Change Text To

Health authorities require you to take an action.
(please include the period)

Fixed.

Fixed.


Add option of CAD currency in received amount field

Describe the bug
The finance manager is not able to select currency except INR and USD while creating an invoice or received any payment.
To Reproduce
Steps to reproduce the behavior:

Go to the Invoice module
Click on Any invoice
Change status to paid
Click on Amount currency
See an error

Expected behavior
It should show all the currency added to the database's country table.
Screenshots

@rathorevaibhav It is working fine on UAT.


Move "redirect to" and "manual url" from advanced to standard settings

There is a permission to allow or disallow staff users the access to advanced settings.
We don't want regular staff to be able to add/edit app hooks. We do however want them to be able to edit the redirect to and manual URL attributes.
I propose moving those two fields to the standard settings since they are more commonly used and not necessarily "advanced".
Or as an alternative provide more granular permissions for the various fields.

Moved to https://groups.google.com/forum/#!topic/django-cms-developers/-FI7jb5DQr4


Ability to append style/script elements inside of a shadow-root

Description
Vue started to support mounting app inside of a shadow-root element within this PR.
With the following code, I can mount my Vue app under a shadow-root node
import App from './App.vue';

const shadowHost = document.querySelector('#my-host');
const shadowRoot = shadowHost.attachShadow({ mode: 'open' });

createApp(App).mount(shadowRoot);

However, Vite loads style/script elements under the document head element because of the following function and since style elements are getting appended outside of the shadow-root scope, style definitions are not getting applied to HTML elements under the shadow-root.
https://github.com/vitejs/vite/blob/356ddfe2e534800c1fd59fa502a2c4c8945f4f92/packages/vite/src/node/plugins/importAnalysisBuild.ts#L63-L119
As a use case, I need to mount a multiple apps to DOM under a shadow-root to avoid scope related collisions.
Suggested solution
Mentioned function can support different parent element to append style/script elements
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

There is an open PR that should address this issue https://github.com/vitejs/vite/pull/12206. I added it with higher priority to discuss the addition of a new option. Let's use this issue to track the feature.

Any workaround for now?

@RogierdeRuijter Can you expand on what you mean by the connectedCallback? Is the connectedCallback part of Vue?

@seahindeniz Do you have any updates on this issue? I feel that this is a crucial part of building Microfrontends with Vue. ShadowDOM is probably the best a least hacky way to encapsulate styles within micro-frontends.
Perhaps you know a workaround that is not too hacky? I feel that manually moving styles from the document head into the shadow DOM is brittle.

Hi @Oumar96, I totally agree with you and unfortunately no solution so far

+1, same request here.

+1. do we have any solution for this?

+1 - looking for a way to apply Vite generated CSS into a shadow root

try this

@gs-rpal Could you share the vite config file instead of the screenshot?

+1, it would be great to have this option as some kind of vite's configuration or plugin.
@gs-rpal please share that config 🙏 ❤

The only workaround for this for now is to query the document for <link> or <style> elements, then add them to your ShadowRoot.
StylesSheets can be added to this.shadowRoot.adoptedStyleSheets in all modern browsers.
const styleElements = document.documentElement.querySelectorAll('..... select all the <link>s and <style>s you want ...')
const sheets = Array.from(styleElements).map(el => el.sheet)

// Apply the desired style sheets to your custom element (via the shadow root):
this.shadowRoot.adoptedStyleSheets = [...sheets]

If you cannot support adoptedStyleSheets because you support older browsers, then you can clone elements and place them in the root:
const styleElements = document.documentElement.querySelectorAll('..... select all the links and styles you want ...')
const styleClones = Array.from(styleElements).map(el => el.cloneNode(true))

// Append clones of the desired style elements to your custom element (via the shadow root):
this.shadowRoot.prepend(...styleClones)

[!Note]
prepend() instead of append() so that they will be above your shadow roots existing styles, if any, so that your own root's styles override the shared ones that you bring in.

i would also like the element that are created to be not document.createElement but shadowroot.createElement... current way is copy whole internals to add a custom renderer in place...

vue just needs to give webcomponents some serious love

This is the vite repo tho.

yea true

I'd like to share my current workflow for building and serving CSS in development with shadow-root.
I use Vite to build the CSS in development mode, which means that I can see the changes I make to my CSS files immediately.
in package.json
"scripts": {
    "serve": "vite",
    "build:watch": "vite build --emptyOutDir false -- watch",
 },

Then, I insert a link to the CSS file into the shadow root of my component.
const link = document.createElement("link");
link.rel = "stylesheet";
link.href = import.meta.env.PROD ? "<the css path after you build, like './app.css'>" : "../dist/app.css";
document.querySelector(".shadow-root").appendChild(link);

I'm not sure if this is the best way to do it, but it works for me.

FYI I’ve created a plugin that does just what I was looking for. Please try it out and let’s see whether it fits your use cases too. I’m pretty sure it’s very specific to my specific usage scenarios, so it’ll not fit anyone’s needs, but nothing stops us from using it as a starting point for a more adaptable plugin.
Link here:
https://www.npmjs.com/package/vite-plugin-shadow-style

 try this

@gs-rpal Any updates? Could you share the config file?

Hello, this feature would be really great to support injection into Shadow roots! Is there already a nice workaround for this?

Hello, this feature would be really great to support injection into Shadow roots! Is there already a nice workaround for this?

Hi, probably my solution I linked above can help you with style injection into shadow roots: https://www.npmjs.com/package/vite-plugin-shadow-style

Hello @hood thanks for your comment, but somehow for the dev mode it deactivates the shadow root and for build mode it gives me the warning:
rendering chunks (141)...[vite-plugin-shadow-style] Multiple CSS files found in the output bundle. This plugin currently only supports handling a single css output.
A question to the "vite" team: is it possible to add a feature where it is possible to configure where to inject the styles? Right now only "head" is possible...
The code for it is here:
https://github.com/vitejs/vite/blob/bb79c9b653eeab366dccc855713369aea9f90d8f/packages/vite/src/node/plugins/importAnalysisBuild.ts#L125-L137

I also tried the solution from @gs-rpal but it only seems to work for dev mode.

Hello guys, is there any progress for this feature? Thank you 🙏
cc: @bluwy

 try this

work for me! But need create Shadow Dom in Vue and after this code put in ShadowRoot css code
create shadowdom main.js:
`import vue from 'vue';
import MyComponent from 'src/MyComponent';
let treeHead = document.querySelector(".container");
let holder   = document.createElement("div");
let shadow   = treeHead.attachShadow({mode: 'open'});
shadow.appendChild(holder);
let app = new Vue({
el: holder,
render: h => h(MyComponent, {})
});`

I would need this feature so bad for my current project!
A custom target, where the Styles should be inserted would be so great - with it we would be totally flexible!
Is there any progress on this feature? 🙏🙏🙏🙏

Something else to consider is SSR Declarative Shadow DOM. Link tags will be hoisted to the head ignoring the template and waiting for client code to append the tags results in FOUC.

Is there any updates on this? I ended up importing the styles using 'style.css?inline' and adding them manually inside the shadow dom.  But it feels quite hacked.

FYI it is impossible to add fonts and icons to shadow dom because @font-face isn't supported there yet:
https://issues.chromium.org/issues/41085401

my currently working solution (both with serve and build commands) is:
in vite.config.ts
import { defineConfig } from "vite";
import cssInjectedByJsPlugin from "vite-plugin-css-injected-by-js";

export function defineConfig(() => {
  const globalStylesIdentifier = "__myStylesIdentifier";

  return {
    plugins: [
      cssInjectedByJsPlugin({
        injectCode: (cssCode, _options) => {
          return (
            `try{` +
            `var s = document.createElement('style');` +
            `s.appendChild(document.createTextNode(${cssCode}));` +
            `window.${globalStylesIdentifier} = window.${globalStylesIdentifier} || []; window.${globalStylesIdentifier}.push(s);` +
            `}catch(e){` +
            `console.error('${globalStylesIdentifier}', e);` +
            `}`
          );
        },
        dev: {
          enableDev: true,
          removeStyleCodeFunction: function removeStyleCode(_id) {
            // The 'id' corresponds to the value of the 'data-vite-dev-id' attribute found on the style element. This attribute is visible even when the development mode of this plugin is not activated.
          },
        },
      })
    ]
  };
};

in app.ts or where in my application code I want to inject the styles
const myShadowDomRoot = myDiv.shadowRoot;

if (myShadowDomRoot) {
  const styles = window.__myStylesIdentifier || [];
  while (styles.length) {
    (myShadowDomRoot).prepend(styles.pop() || "");
  }
}


terminate inside slax:while leads to infinite loop

The following code:
version 1.2;

match / {
    <op-script-results> {
        while ( true() ) {
            terminate "doa";
        }
    }
}

turns into:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:slax="http://xml.libslax.org/slax" version="1.0" extension-element-prefixes="slax">
  <xsl:template match="/">
    <op-script-results>
      <slax:while xmlns:slax="http://xml.libslax.org/slax" test="true()">
        <xsl:message terminate="yes">doa</xsl:message>
      </slax:while>
    </op-script-results>
  </xsl:template>
</xsl:stylesheet>

It's processing the terminate, but then it continues
to "skip" over the rest of the entries, thinking that it's a set
of nodes instead of a condition.  So it really, really, quickly
loops forever.  slax:while needs to notice the libxslt terminate flag.

Fixed in 'develop' branch


feat: add basic ignore subpaths argument

Add a basic ignore subpaths argument. just checks if paths include it, no regex/glob/etc yet. Closes #102.

@CanadaHonk
Your PR was merged and included in the v3.12.0 release.

As reported in https://github.com/tcort/markdown-link-check/issues/297, markdown-link-check is now failing. It seems it crashes if there is no option --ignore specified in the CLI command line.
Can you take a look and decide if there is an easy fix or if the PR needs to be reverted?

@CanadaHonk
Thanks for fixing the crash!
Did you consider also updating the README > Usage section?  It currently does not mention the --ignore option.
Usage: markdown-link-check [options] [filenameOrUrl]

Options:
  -p, --progress              show progress bar
  -c, --config [config]       apply a config file (JSON), holding e.g. url specific header configuration
  -q, --quiet                 displays errors only
  -v, --verbose               displays detailed error information
  -a, --alive <code>          comma separated list of HTTP code to be considered as alive
  -r, --retry                 retry after the duration indicated in 'retry-after' header when HTTP code is 429
  -h, --help                  display help for command
  -V, --version               display version string (e.g. `1.2.3`)
    , --projectBaseUrl <url>  the URL to use for {{BASEURL}} replacement


[WIP] security/acme-client: release 1.12

New features

TBD: compatibility with HAProxy plugin version 2.0 (refs #330)

Bugfixes

fix missing fields for Hurricane Electric (#334)

@fraenki I need to wrap up 17.7.7 till noon. you want this in?

@fichtner As discussed on IRC I need more time for testing, so this will be rescheduled for 17.7.8.

Successfully tested HAProxy integration with the updated model code: it successfully validates an existing config and is still able to setup a new HAProxy integration.


Encoding Max Type Variables in manifest2proto

Adding a flag to indicate if a type variable is was resolved to max type.
CC @bgogul

Nice quick turn around BTW!

Closing in favor of #5893, it includes these changes.


BUG: Clicking the 'Home' link in the navigation bar doesn't redirect to the homepage.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Clicking on the nav link home is not redirecting anywhere!
Video Screen1728724667317.webm
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

can you assign me the issue @dwivedishrey
I want to work on this!


API returns 407 Session expired but the app does not send you to the login screen.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1725564118248469
Action Performed:

Go to staging.new.expensify.com

Expected Result:
No loading skeletons or no other issues
Actual Result:
API returns 407 Session expired but the app does not send you to the login screen.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Just calling out that the Slack thread(s) have some initial investigation into this one - https://expensify.slack.com/archives/C05LX9D6E07/p1725564162189379 and https://expensify.slack.com/archives/C05LX9D6E07/p1725564118248469 . The only thing I can think of is that the token returned from RestoreAuthToken is not a "normal" token but it certainly appears to be.
I believe there IS an issue with not returning to the default account if a delegated access token expires (which would be nice to fix) but this seems separate, it happened AFTER @coleaeason returned to his actual account.

Based on the linked threads it seems like:

Something is wrong with the front-end that is preventing us from calling Authenticate correctly when we get the 407 response.
This isn't entirely related to the issue, but the back-end is returning the expected authToken to the front-end when we switch from co-pilot to normal account.

@puneetlath @dangrous Is there a way that we can reliably reproduce this issue? I'm having trouble doing so by hardcoding our API to return the 407 response.

hm, I'm not sure - you could maybe:

Log into an account as a copilot
Adjust https://github.com/Expensify/Auth/blob/5b1b0990bc92b6a345e28df466d8548dc672fdc5/auth/lib/AuthToken.cpp#L1021 to have a very short expiration time
Return to the original account

And then see what happens?
Otherwise, in terms of actual use I think it's just log into copilot and back to original and just wait, which I realize is not helpful.

@dangrous Thanks for those reproduction steps, I'll try them out and see if that yields any different results.

Hmm I'm unable to reproduce the issue following those reproduction steps, here's what I did:

Create two accounts, one main account and one copilot account.
Using the main account, set the copilot as the delegate via OldDot.
Sign into the copilot account and copilot into the main account.
Update the authToken created here to expire in a very short amount of time.
Exit copilot access.
Switch to NewDot.
Nothing happens?

Gonna try to look at logs now since I'm unable to reproduce.

These ReconnectApp requests are from around the same time that this issue was reported.
They all seem to be throwing here, which indicates that the token we were sending with ReconnectApp was either expired or not associated with an account.
I've omitted screenshots since this is a public repo.

@dangrous Added some logs and it seems we never get to pushing Authenticate onto the queue after getting a 407 response (this is from me hard-coding the user's authToken to expire in 2 seconds).
It seems the reason we don't reauthenticate is because we're failing the requireParameters check here. Namely it appears from my logs that we're missing the partnerUserID and partnerUserSecret parameters.

Maybe we're failing to set these parameters again when the user restores their session when coming back from copilot access? Is there an easy way to check that?

Not overdue just waiting on a response above cc @dangrous

bump @dangrous on above 🙇

Oh hm interesting - maybe we need to add a call to createTemporaryLogin inside of UserAPI::delegateDisconnect if the request is coming from newDot - so that we appropriately send the partnerUserID and partnerUserSecret? It looks like you're right and those should be being sent but are not.

@dangrous Thanks for the context, I'll look into returning those with the response.

After some more investigation it seems that the real issue is that we're setting the locally stored autoGeneratedLogin/Password to null at some point. I still think we should send back a new temporary login, but we also need to figure out where it's being cleared out.

Noticed some other issues during the delegate access flow that were related and needed to be addressed, so I pushed some more changes and a new PR.

@eVoloshchak was pullerbear'd on the linked PR

PRs still under review, @eVoloshchak please prioritize this review!

PR was merged

@eVoloshchak can you complete the checklist please?

@eVoloshchak bump on the checklist so that we can pay you out and close this issue. Thanks!

@puneetlath, I'm not owed any payment here, I didn't review https://github.com/Expensify/App/pull/49375 since it wasn't possible for C+ (need someone in ring1, more details here)

Ah ok, I see. Thanks @eVoloshchak. @jasperhuangg do you think we need a regression test here. Is there a way Applause could manually test this?

@puneetlath Absolutely, I can create an issue to get a regression test added to the testing suite.

Ok that'd be great thanks! Feel free to close this issue once you have.


Issue

Hello, I have an issue. When I do -remind  , it says "No matching assignment. Please check your search criteria.". Why does it say that?

This error occurs when the bot found the course you were searching for, but none of its upcoming assignments
matched the assignment's name you passed in the command.
All arguments are automatically separated by spaces, so please check if you need double-quotes which are required to encapsulate multiple words.
(i.e. -remind 6h CSE30 "Programming Assignment 1", where the bot tries to find an assignment that has Programming Assignment 1)
If the arguments were correct, the bot only searches for upcoming assignments as specified by Canvas which are assignments assigned to you, with a due-date.
If the problems above don't seem to apply, it would be great if you could describe the command you used and the assignment and I'll look into the problem a bit further! 👍

So I tried what you did and it worked, but now it's giving me this error:

Nevermind, I fixed it.

I have another issue, when I do ;subscribe , it gives "2020-09-18T15:28:54.056Z [warn]: Unable to fetch courses from subscribe:  course is not defined" error.

subscribe requires a course name, which is the course you will get updates for. Currently the command checks for new updates every 6 hours for each subscribed course at once, but you must manually subscribe to each course.
Did you try something like ;subscribe French?

Yes I have tried ;subscribe French but it did not work.

Thank you for letting me know about this issue.
The subscribe command is sort of experimental, but the issue should be corrected now. 👍

It works now, thanks a lot.


⚠ Bofrost.be has degraded performance

In ef6a2ec, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1879 ms

Resolved: Bofrost.be performance has improved in 3ae9f71.


Making pcapgo Writer routine safe

Calling write from parallel routines will cause the pcap file to corrupt.
Using a mutex ensure we don't corrupt the file by delaying concurrent writes.
An alternative method would be to use a buffered channel but requires an additional routine

hey mate, can you move this to gopacket/gopacket and raise it there. I'll merge it over there.


Added code coverage section and refreshed code quality section.

Removed broken GitBook status checks, should be able to merge normally now


std::hash is not specialized for entt::hashed_string

Hi there,
as far as I can tell, there is no specialization of std::hash for entt::hashed_string, making the simple construction of an std::unordered_map<hashed_string, T> impossible without defining a custom hash functor. Is this an oversight or intended? And if it is the latter, why?
Thanks in advance,
Scarabytes

Hello!
Note, that entt::hashed_string doesn't store the string data - it only references it. I don't know if it's important for your use case or not. I would just use entt::hashed_string::value() as a key in the dictionary.

It's intended actually. hashed_string converts to entt::id_type, that is, an integral type.
So, you should rather use std::unordered_map<entt::id_type, T> and generate the integral representation both at compile-time or runtime according with your needs.
@Innokentiy-Alaytsev

doesn't store the string data
Probably the time is come to undertake also this part but it would mean strcmp or similar. Not sure I want that all over since in 90% of cases I don't even need to use the string once hashed.

Alright, thanks for the clarification!


documentation updates for interactive and interactive-on-error

Tests passed for this pull request.
Refer to this link for build results: http://jenkins.ceph.com/job/teuthology-pull-requests/777/


Fixed bug:  wrong year  in Last Start Time

Wrong year for Last Start Timewas shown on VMDV Summary screen
https://bugzilla.redhat.com/show_bug.cgi?id=1339612
BEFORE:

AFTER:

@miq-bot add-label bug

@gtanzillo could you review


Game Initiator - Arena - Create Arena & Generate Arena Code

relates to #52
Background
Currently, arenas can be created by entering a username and a non-existing arena code. Rather than having a game initiator create an arena code to start an arena, they should be able to click a button/link to create an arena and have an access code generated for their arena. The purpose of this ticket is to add a link to "Start Arena" and generate an arena code.
Scenario: Create Arena
Given I am a game initiator

[ ] When I am on the Start or Join an Arena page (currently pointed at /home)
[ ] Then I can click a link/button that says Start Arena
[ ] And clicking that will create a new arena

Scenario: Generate Arena Code
Given I am a game initiator

[ ] When I have created a new arena
[ ] Then an arena code is generated
[ ] And I can give the arena code to players to access my arena

deployed

looks good, moving to UAT


Update gltf Pipeline and support KHR_techniques_webgl and KHR_blend

Part of (fixes?) https://github.com/AnalyticalGraphicsInc/gltf-pipeline/issues/330

Update ThirdParty/gltfPipeline files to use the 2.0 branch
Support the KHR_techniques_webgl extension
Support the KHR_blend extension
Fixes https://github.com/AnalyticalGraphicsInc/cesium/issues/5776, removes added pipeline extras.

Ran through the Sandcastle examples to check the new updates, and the one issue I see is with classification (in this sandcastle demo). The classification model is still based on glTF 1.0, and the indices seem to be wrong. Any ideas?
Incorporates #6803 to fix bounding spheres, merge that first.
TODO:

[x] Include fix from https://github.com/AnalyticalGraphicsInc/cesium/pull/6857#discussion_r206157642
[ ] Fix Specs
[ ] Additional Specs
[ ] Update CHANGES.md

Thanks for the pull request @ggetz!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Changes to third party files were made.

Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

@ggetz when this is ready can you publish a new version of the power plant tileset to ion?
I checked that upgrade converts it correctly and it loads in this branch. That's really good because it uses pretty complicated glTF techniques and shaders.

Related to https://github.com/AnalyticalGraphicsInc/cesium/pull/6805#discussion_r204415943, since gltf-pipeline no longer adds pipeline extras to everything there is now a bug when a model has an unused material. A few areas of the code try to access material.extras._pipeline.primitive when extras._pipeline doesn't exist.
CUBE.gltf.txt
This model reveals another bug related to primitive.material being undefined. I'll open a gltf-pipeline fix for that.

@lilleyse Other than specs which I'm working on now, this should be updated. I handle ALPHA_MASK and have the latest build of gltf-pipeline here.
I removed pipeline extras where applicable, but they are needed for updateVersion. Also fixed the bug related to material.extras._pipeline.primitive
Tested the sample models as well as Polly.

Thanks @ggetz, I hope to look at this later today.

The updates look good and I haven't seen any issues besides the Cesium Air ones.
I think this will cut it too close to the release and we should merge right after the release instead.

Just checking that I've read correctly here, is this PR intended (among other things) to let glTF-Pipeline convert from glTF 1.0 shaders to glTF 2.0 with KHR_techniques_webgl and KHR_blend? That's awesome if so, and would be very helpful to me as well. 🙂

@donmccurdy Correct, we also move render states to KHR_BLEND.

Is this far enough along that it could be used locally for testing output of an exporter writing KHR_techniques_webgl, or are there some known issues left to iron out?

@donmccurdy This should be usable for the most part. There's one bug that's causing Cesium_Air not to render which we are investigating, see https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/421

@lilleyse, this should be ready for another look. I've incorporated the changes made via gltf-pipeline, fixed a bug I noticed with model caching and the forward axis, fixed the current specs, and added additional specs for loading 2.0 models and 2.0 models using the techniques extension.

Thanks @ggetz, I will do some final testing later today.

I'm seeing three test failures:

Scene/ModelInstanceCollection renders rigged figure
Scene/ModelInstanceCollection renders with animations when instancing is disabled
Scene/Model renders with a silhouette

The last two pass when run individually.

I think that's it from me. Besides those edge cases I haven't seen any other issues. 👍

Thanks @lilleyse! Tests are all cleaned up, and your feedback has been addressed.

Thanks @ggetz. Awesome to get this in!

Congrats @ggetz, @OmarShehata, and everyone involved.  It's great to have the PBR shader generation moved into core Cesium like this.


Bullet point turns to oval on smaller screen sizes when the label text is longer

Prerequisites

[ ] I have checked the open Issues to see if this has already been raised
[ ] I have searched the closed Issues to see if a similar bug has been fixed in the past

Description
This bug affects:

[ ] Component -  lg-radio-button

Steps to Reproduce

Use a long text inside the lg-radio-button tags
Select a small screen size (tablet or phone)
You can see that the radio button turns into an oval and the selection styling is off-center

Expected behaviour:
The radio button stays round and selection styling stays in the center.
The radio button should align to the first row of a longer label.

Recurrence frequency:

[ ] Occurs every time

Package version

[ ] Unsure

Configuration and environment

[ ] This pertains to local development
[ ] This pertains to Storybook

Additional Information

I also have another question. Does the bullet point always be positioned at the center or should it be positioned at the top?


very easy to mix up to.eventually.equal and should.eventually.equal

I had a test passing and I had no idea why. It turns out I had accidentally written expect(promise).to.eventually.equal(string).
My promise could resolve(anything) or even resolve() and the above assertion came back clean. Worse yet, my promise could reject() and the above assertion came back clean.
Clearly this was a problem between the keyboard and chair, as the correct syntax is expect(promise).should.eventually.equal(string). However, this seems a very easy mistake to make while allowing tests to erroneously pass.

I just realized I'm mixing up TDD and BDD. expect(promise).to.eventually.equal(string) should actually be the correct notation, yet it seems to be doing nothing.
Anyway, this ticket is erroneous in its current form. If I nail down the problem better I'll open a new ticket.


Integration test script troughs an error that is not catched

In the logs of the TravisCI build, the following error occurs:
ERROR: Found image
  }docker.io/keptnexamples/carts:0.10.1 but expected docker.io/keptnexamples/carts:0.10.1  in deployment carts in namespace sockshop-dev

Issue: the image name contains a } at the beginning. This should be removed to pass the check in the test script.
Definition of Done:

[ ] The naming issue of the image is fixed

I will take on this issue!

Extension of the issue:
Wrong negative error codes are being thrown in some test utility functions that need to be replaced by valid error code e.g. -1 with 1.
Issue: Since the error codes are invalid the script doesn't exit when the error is thrown.
Definition of Done:

[ ] Invalid error codes are replaced by valid ones and script exits when the error is thrown


what is the math formula behind getAmountIn ?

I am struggling to figure out how can we deduce the formula used in  getAmountIn. Basically here if we want to maximize our profit those two pools must have almost the same price at final stage. Hence we have:
(x1 + delta_x1) / (y1 - delta_y1) = (x2 - delta_x2) / (y2 + delta_y1)

Also we know how the pair pool is updating accordingly after swap:
(x1 + 0.997 * delta_x1) (y1 - delta_y1) = x1y1
(x2 - delta_x2)(y2 + 0.997 * delta_y1) = x2y2

Based on equations mentioned above, i just have no clue how can i simplify it to the formula in the code.  Do i miss anything here ?
https://github.com/flashbots/simple-blind-arbitrage/blob/62582059a26f3852949e71a49821ee3c613f2f27/src/blindBackrun.sol#L83

See section 2.1 of this paper. Then it's a matter of calculus!
https://arxiv.org/pdf/1911.03380.pdf

Hey handsome, I understand calculus, but I've looked through the link you gave me three times and still can't find the derivation process of the calculation formula in the BlindBackrun contract. This article is about the arbitrage process from the Uniswap market to a related market with infinite liquidity, while the calculation formula in your BlindBackrun contract refers to two identical Uniswap markets, such as the arbitrage between the currency pairs of Uniswap and Sushiswap. Would you be able to update an article showing how to derive the calculation formula inside the GatAmountIn method? This would be very helpful for us to research new arbitrage methods. Thank you very much!

See section 2.1 of this paper. Then it's a matter of calculus!
https://arxiv.org/pdf/1911.03380.pdf

Hey handsome, I understand calculus, but I've looked through the link you gave me three times and still can't find the derivation process of the calculation formula in the BlindBackrun contract. This article is about the arbitrage process from the Uniswap market to a related market with infinite liquidity, while the calculation formula in your BlindBackrun contract refers to two identical Uniswap markets, such as the arbitrage between the currency pairs of Uniswap and Sushiswap. Would you be able to update an article showing how to derive the calculation formula inside the GatAmountIn method? This would be very helpful for us to research new arbitrage methods. Thank you very much!

Suppose pair1 has reserve $x_1,y_1$ and pair 2 has reserve $x_2,y_2$ and $x_1, x_2$ corresponds to WETH. Give $\Delta x_1$ to pair1 as WETH, we can get $\Delta y_2$ (or $\Delta y_1$, whatever). Then swap $\Delta y_2$ for $\Delta x_2$ WETH in pair2. Our profit is $\Delta x_2 - \Delta x_1$. If we take derivate of profit with respect to $\Delta x_1$ and set it to 0, we can get the formula behind getAmountIn.
To derive the exact formula for profit in terms of $\Delta x_1$, we can refer to Section 1 of https://raw.githubusercontent.com/runtimeverification/verified-smart-contracts/uniswap/uniswap/x-y-k.pdf, which gives the formula concerning how much $\Delta y$ if we give $\Delta x$ to a pair:
$\Delta y = \frac{\alpha\gamma}{1 + \alpha\gamma}y, where \ \alpha = \frac{\Delta x}{x}, \gamma=1-\rho$
and $\rho$ is the fee.
So we have $\Delta y_2 = \frac{\alpha\gamma}{1 + \alpha\gamma}y1, where\ \alpha=\frac{\Delta x_1}{x_1}$ and profit is $\frac{\alpha'\gamma}{1 + \alpha'\gamma}x2-\Delta x_1, where\ \alpha'=\frac{\Delta y_2}{y_2}$. Here the profit can be simplified as a function of $\Delta x_1$. To find the maximal profit, take the derivate and set it 0, solving the $\Delta x_1$.
Python code to solve the mathematical equation is below. It gives two solution, one solution is exactly what getAmountIn does (the other is a negative value).
import sympy as sy
deltaX1 = sy.Symbol('x')
x1,y1,x2,y2 = sy.symbols("x1,y1,x2,y2")
rho = 0.003
gamma = 1 - rho

alpha = deltaX1 / x1
deltaY2 = alpha * gamma / (1 + alpha * gamma) * y1

pair2_alpha = deltaY2 / y2
profit = pair2_alpha * gamma / (1 + pair2_alpha * gamma) * x2 - deltaX1
derivate = sy.diff(profit, deltaX1)
solution = sy.solve(derivate, deltaX1)
sy.pprint(solution[0])
sy.pprint(solution[1])

Here I only consider the case when token0 in both pairs is WETH. It should be similar if token1 is WETH.


Milestone 3

There is no link on GitHub or in the README.md to ReadTheDoc - -2 reasoning

added the readthedoc badge on readme.md


feat: hide styled details marker if no children are in group

Implemented changes
This PR supersedes https://github.com/EOX-A/EOxElements/pull/604. It hides the details marker for layer groups with no child layers. As this is a styling "opinion" it only applies to the "EOX styled" version (not to the unstyled one).
To trigger this, all child layers need to have the layerControlHide property set to true; it automatically hides the expand/contract icon on the parent group, this way it looks like a layer (but with a "group" icon).
Screenshots/Videos

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added a test related to this feature/fix
[ ] ~For new features: I have created a story showcasing this new feature~
[x] All checks have passed
[x] The PR title follows conventional commit style and reflects the type of change (major/minor/patch, breaking)
[x] The PR title describes the change within this element (each merged PR equals one entry in the element's changelog!)

In the screenshot "background layers" appears nested beneath "data layers". Should be at the same indentation level as "background layers", even though there is no collapse arrow.

In the screenshot "background layers" appears nested beneath "data layers". Should be at the same indentation level as "background layers", even though there is no collapse arrow.

@StefanBrand this might be a general styling issue (not connected to this PR), it is might be more clear in this case - see example where "Group 2" has no children:

But I agree, this should be generally improved.


Idea: auto fix for fmt and codegen

Just an idea, simply close the issue if it does not make sense to you or its overkill :smiley:
In order to make sure that the generated files are always up to date without any ping-pong in the pull requests, this project could configure an auto fix workflow using github actions - the same goes for fmt if this is ever an issue or any other automatable tasks.
This can be done using the autofix github app which also works on PRs from forks.
Here is an example for a workflow fixing golang PR: https://autofix.ci/setup#go
Since you seem to squash PRs on merge anyway, the potential extra commits fixing the PR should not matter to the history.
The downsides of this approach are that some people might be confused about automated commits on their PRs and  that the app needs to be installed in the github org - although it can be scoped to single repositories, I'm not sure how flexible google is which such things.

Thank you for the suggestion, @spalberg.
I'm a big fan of automation and would normally want to try this out.
However, this repo is a bit unusual in that I'm the primary maintainer but have no permissions to actually administer the repo settings myself.
I don't know if you have noticed, but we have had an ongoing Codecov issue in this repo where we are relying upon getting support from the organization that actually owns this repo and has the ability to update its token secrets.
So although I think this is an idea we might want to try out, this repo is probably not a good fit for it and I'll close the issue.
Thanks again, though, @spalberg. Your ideas and contributions are greatly appreciated.


Latest version isn't on assetlib

Hey, kind of an amateur to Godot, but when downloading your plugin on the assetlib, it still has the error of @icon being below the extends. Idk if this is something on your end or theirs.

Sorry, when I posted this plugin it wasn't yet a syntax error.  I will fix it soon.  Thank you for reporting this!

Hey, kind of an amateur to Godot, but when downloading your plugin on the assetlib, it still has the error of @icon being below the extends. Idk if this is something on your end or theirs.

Sorry, when I posted this plugin it wasn't yet a syntax error. I will fix it soon. Thank you for reporting this!

Sorry @protodrew, when I posted this plugin it wasn't yet a syntax error.  I will fix it soon.  Thank you for reporting this!

I updated the commit hash in the asset library. After a while, the change will be reviewed and made available.


Use SASL external for router and broker management

Type of change

Enhancement

Description

Generate operator certificate for each infra signed by the infra CA
Scope management ports to localhost for router and broker
Switch to go module fork from interconnect

Fixes #4460
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[x] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[x] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests profile=isolated-shared-infra

:x: Test Summary :x:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 39
PASS: 30
FAIL: 3
SKIP: 6
BUILD_NUMBER: 830
BUILD_ENV: oc cluster up
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testInfraStaticScalingStrategy in io.enmasse.systemtest.sharedinfra.MessagingInfrastructureTest
testSelectors in io.enmasse.systemtest.sharedinfra.MessagingTenantTest
testMultipleMessagingTenants in io.enmasse.systemtest.sharedinfra.MessagingTenantTest

@enmasse-ci run tests profile=isolated-shared-infra

@enmasse-ci run tests profile=isolated-shared-infra

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 43
PASS: 37
FAIL: 0
SKIP: 6
BUILD_NUMBER: 838
BUILD_ENV: oc cluster up

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 43
PASS: 37
FAIL: 0
SKIP: 6
BUILD_NUMBER: 835
BUILD_ENV: oc cluster up


Why do I get "_TypeError: unsupported operand parent(s) for : .....“ after running* "load('main.py')" in a Sage interactive shell?

Why do I get "TypeError: unsupported operand parent(s) for : 'Abelian group of points on Elliptic Curve defined by y^2 = x^3 +<PHONE_NUMBER>624666631860092489128939059944978347142292177323825642096x +<PHONE_NUMBER>343380547144152006776653149306466138012730640114125605701 over Finite Field in an of size<PHONE_NUMBER>3985034465755506450771565229282832217860390155996483840017^6' and 'Rational Field' " after running "load('main.py')" in a Sage interactive shell?

SageMath Version : 9.3
Using Python: 3.9.2.
Looking forward to your answer！！！

I found that in ”keygen.py" file, "while (g*ord).is_zero():"  is not supported, where "g" and "ord" cannot be used with operation "*". How to solve it?

I found that in ”keygen.py" file, "while (g*ord).is_zero():" is not supported, where "g" and "ord" cannot be used with operation "*". How to solve it?

Have you tried updating your Sage version? It should work fine for 9.6 and above.


(PUP-5949) Load Resource Types from Pcore based Resource Type description

Work in progress on environment isolation and loaders.

CLA signed by all contributors.

Will merge as this now contains the required functionality. More tests needs to be added for the "bigger picture".


[WIP] Implement client native object reference fetching

Motivation
One of the ways custom resources are declaring dependency on each other, is by providing and ObjectReference field. Having one, still requires to manually prepare an appropriate client/api setup, extract namespace and name and validate the kind, api_version fields. This PR allows to make ObjectReferences native to client, and simplify their use.
Solution
Implement a client.fetch method, allowing for the use of the following syntax:
// Actual ObjectReference content is intended to come from a CR
let svc: Service = client.fetch(&Ref::new(ObjectReference::default())

Marking this a WIP, as I’m trying to expand it to OwnerReferences, and impl Into<Option<smth>> is not cooperating with linter or Option into Option (generally looks like is not needed).


About view

@elizlalala  Can you take a look?  I added a page placeholder for the about us.  I also removed the geolocation in resources as it was throwing red. We can add it back later once the backend works.  Thanks

Removed geolocation code:
componentDidMount() {
navigator.geolocation.getCurrentPosition(
(position) => { console.log(position) }
)
this.fetchData();


[Question] Is tests/tictactoe abandoned?

I noticed this while i was validating the fix of https://github.com/coral-xyz/anchor/pull/3381
For test/tictactoe, it hasn't been updated on its logic for approximately 2 years. it's also not included in github workflow. it's like an uncompleted projects with many issues remaining.
Meanwhile, there is another tictactoe under docs, https://github.com/coral-xyz/anchor/tree/master/docs/programs/tic-tac-toe
this is also introduced in docs.
So, if the first one, test/tictactoe is no longer used, can it be cleaned out?

The program doesn't seem to be testing anything important, but it'd probably be better to include it in CI rather than removing it because of its history as an example program.


How to inference with the converted GGUF using llama-cpp?

I would appreciate if anyone can help with the following problem when using the converted GGUF for inference.
I found that inferencing with llama-cpp generates a different result from inferencing with the saved LoRA adapters. I am using both Q4 quantized model.
For inferencing with LoRA, I kept the alpaca_prompt format:
if False:
    from unsloth import FastLanguageModel
    model, tokenizer = FastLanguageModel.from_pretrained(
        model_name = "lora_model", # YOUR MODEL YOU USED FOR TRAINING
        max_seq_length = max_seq_length,
        dtype = dtype,
        load_in_4bit = True,
    )
    FastLanguageModel.for_inference(model) # Enable native 2x faster inference

# alpaca_prompt = You MUST copy from above!

inputs = tokenizer(
[
    alpaca_prompt.format(
        instruct, # instruction
        description, # input
        "", # output - leave this blank for generation!
    )
], return_tensors = "pt").to("cuda")

outputs = model.generate(**inputs, max_new_tokens = 8000, use_cache = True,temperature=0)
tokenizer.batch_decode(outputs)

For inferencing with llama-cpp, I used its chat completion since I didn't find a way to retain the alpaca_prompt format:
llm = Llama(
      model_path=SAVED_PATH,
      n_gpu_layers=-1, # Uncomment to use GPU acceleration
      seed=1, # Uncomment to set a specific seed
      n_ctx=2048, # Uncomment to increase the context window
      # tokenizer=LlamaHFTokenizer.from_pretrained(SAVED_PATH) # is this necessary???
)
...
output = llm.create_chat_completion(
      messages = [
          {"role": "system", "content": instruct},
          {"role": "user","content": description}
      ],
      temperature=0,
      max_tokens=8000
)

Is it necessary to retain the alpaca_prompt format or to convert the tokenizers from unsloth to llama-cpp?
In #(https://github.com/abetlen/llama-cpp-python), it is mentioned that:
"Due to discrepancies between llama.cpp and HuggingFace's tokenizers, it is required to provide HF Tokenizer for functionary. The LlamaHFTokenizer class can be initialized and passed into the Llama class. This will override the default llama.cpp tokenizer used in Llama class. The tokenizer files are already included in the respective HF repositories hosting the gguf files."
I don't quite understand if such descrepancy exist since the Unsloth demo notebook doesn't seem to mention.
Thanks!

A good idea to use llama-cpp's Python module - ill make an example


Error loading extension

Hello, I'm having issues trying to get the extension to work.
Godot version:
Godot_v4.1.4-rc1_linux.x86_64
Steps to reproduce:

Download Godot Whisper from AssetLib
Error

I tried downloading latest 1.0.4 version from Github, extracted addon folder to project, still same error.
Restarting produces the same error.
Error message:
Error loading extension: res://addons/godot_whisper/godot_whisper.gdextension
Terminal error log:
...
     at: _editor_init (modules/gltf/register_types.cpp:73)

ERROR: Can't open dynamic library: /Data/PROGRAMMING/godot/try_whisper/addons/godot_whisper/bin/libgodot_whisper.linux.template_release.x86_64.so. Error: /Data/PROGRAMMING/godot/try_whisper/addons/godot_whisper/bin/libgodot_whisper.linux.template_release.x86_64.so: undefined symbol: clBuildProgram.
   at: open_dynamic_library (drivers/unix/os_unix.cpp:650)

ERROR: GDExtension dynamic library not found: /Data/PROGRAMMING/godot/try_whisper/addons/godot_whisper/bin/libgodot_whisper.linux.template_release.x86_64.so
   at: open_library (core/extension/gdextension.cpp:455)

ERROR: Failed loading resource: res://addons/godot_whisper/godot_whisper.gdextension. Make sure resources have been imported by opening the project in the editor at least once.
   at: _load (core/io/resource_loader.cpp:273)
...

Hi. Thanks for reporting. So far only tested build on windows and mac. Linux isnt that well tested, just that build passes.
@fire you wanna take a look or should i try?


Cannot read property 'ConsumeGenerator' of null

Environment
Highland: 3.0.0-beta.2
Node: v6.3.1
OS: Linux

Example (CoffeeScript)
Stream = require "highland"

fn = ->
	Stream Promise.resolve([])
		.map (data) ->
			console.log "map", data
			Stream Promise.resolve([])
		.parallel 1
		.consume (err, data, push, next) ->
			push null, Stream.nil

Stream([
	Stream([["data"]])
	fn().collect()
])
	.parallel 2
	.tap (data) -> console.log "tap", data
	.collect()
	.each (data) -> console.log "each", data

Error
/home/user/highland-bug/node_modules/highland/lib/index.js:1280
        if (gen.__ConsumeGenerator__) {
               ^

TypeError: Cannot read property '__ConsumeGenerator__' of null
  at Stream._runGenerator (/home/user/highland-bug/node_modules/highland/lib/index.js:1280:16)
  at Immediate.<anonymous> (/home/user/highland-bug/node_modules/highland/lib/index.js:791:26)
  at runCallback (timers.js:570:20)
  at tryOnImmediate (timers.js:550:5)
  at processImmediate [as _immediateCallback] (timers.js:529:5)

Does only happen when Promise are in use.
Substituting Promise.resolve([]) to [[]] works without error.

Replacing .parallel 1 with .series() or .flatten() also resolves the problem.

Replacing .parallel 1 with .series() eliminates the error.

I think this is an easy fix. The call to _runGenerator here needs to check if the generator still exists. It could have been destroyed by downstream.
I'm away from my computer for the new week or so though, so I won't be able to get around to this until then.

@vqvu Like here?

Yeah.

I'm having trouble reproducing this, I translated it into ES5 here to create a failing test case but it passes for me. Is there something wrong with my code here?
var fn = function() {
        return _(Promise.resolve([]))
            .map(function (x) {
                return _(Promise.resolve([]));
            })
            .parallel(1)
            .consume(function (err, data, push, next) {
                push(null, _.nil);
            });
    };

    _([_([['data']]),
    fn().collect()])
        .parallel(2)
        .collect()
        .each(function(ys) {
            console.log(ys);
        });

Here's a more explicit test case.
var _ = require("highland");

// Code path is this:
// - push(...) causes s.destroy() to be queued.
// - next2 is queued.
// - next1 is executed, which queues _runGenerator
// - destroy() runs and clears the _generator.
// - next2 runs and sets the _generator_requested flag.
// - _runGenerator runs and is allowed to be executed because _generator_requested
//   was set.
var s = _(function (push, next) {
    setTimeout(function () {
        push(new Error("error"));
        _.setImmediate(next); // next2
        next(); // next1
    }, 0);
});

s.pull(function (err, x) {
    // This pull is required to un-pause the stream.
    s.pull(function () {
        // Ignore.
    });

    _.setImmediate(function () {
        s.destroy();
    });
});

I thought about this more and I think the correct fix is to check for _explicitly_destroyed at the start of _next_fn and immediately return if it's true. I believe this also needs to be done in _writeOutgoing.

Ah yes, this causes failures for me now too. I'll raise a PR in the morning.

@pavel, since we're not testing against the test case that you provided, can you verify that #521 fixes the issue for you?

@vqvu I've verified, and the fix does resolve the problem.

#521 was merged, so I will close this.


Incorrect rendering of embedded API structure hover cards

Hello, @erickzhao ! I'm kinda new to Electron. Could you let me know how the hover cards are actually supposed to be rendered and if any extra input on the same will be further required?

Hi @kaushik7kk,
For example, see what the Point object is supposed to look like: https://www.electronjs.org/docs/latest/api/structures/point
For some reason, the document title is being rendered with a  portion and we apparently can't render it using the react-markdown library.
The component that we use to render this text is located here: https://github.com/electron/website/blob/main/src/components/APIStructurePreview.tsx

@kaushik7kk unfortunately it looks like I solved this one as part of a PR solving an unrelated bug. Thanks for writing in to ask about the issue, though!

Thanks for informing me @erickzhao . I'll catch up with the PR to get some more info on what fixed it.

Looks like one of the Docusaurus updates changed the rendering of the title there from to be wrapped in a . I believe we could fix it by adding header to this list of allowed elements, or it will be fixed once #690 is merged.
https://github.com/electron/website/blob/fc2c6b5e9827e56682cb2c0994612b447757f6f9/src/components/APIStructurePreview.tsx#L107


Simple usage example? (eg. MNIST)

Hi, thanks for making this! Is there a simple training example, perhaps with MNIST or another small dataset?

+1 , that would be really cool !

Any updates on this?

Maybe it helps:
from dataclasses import dataclass

import grain.python as pygrain

@dataclass
class MyDataset:
    data: list

    def __len__(self):
        return len(self.data)

    def __getitem__(self, idx: int):
        return self.data[idx]

data_source = MyDataset(list(range(6)))

sampler = pygrain.IndexSampler(
    len(data_source),
    shuffle=True,
    seed=2,
    shard_options=pygrain.NoSharding(),
    num_epochs=3,
)

batch_size = 3
dl = pygrain.DataLoader(
    data_source=data_source, sampler=sampler, operations=[pygrain.Batch(batch_size)]
)

for sample in dl:
    print(sample)

"""Prints:
[0 4 1]
[2 3 5]
[4 3 0]
[1 2 5]
[5 0 4]
[3 2 1]
"""

There is another example of grain using with tensorflow_datasets (or tfds) here: TFDS with Jax.

This new tutorial explores different data loading strategies including Grain for a simple image classification task based on the MNIST dataset.


BUG Allow non-seekable buffer inputs to file_to_civis

… for a seekable file object
Included an additional check beyond HAS_TOOLBELT in civis.io.file_to_civis to ensure the file object is streamable (buf.seekable()). This should enable zip file objects to be uploaded using file_to_civis even when the requests_toolbelt is installed.

Latest commit 6d792be:

Moved entry in CHANGELOG to the [unreleased] section and re-worded it
Updated comment block in civis.io.file_to_civis to also comment on new seekable criteria
removed change to version in _version
added tmp.seek(0) to test_file_to_civis prior to calling civis.io_file_to_civis

We need to make JIRA tickets for this stuff in the future, @jkulzick

@beckermr @stephen-hoover
Thanks for the jira examples @beckermr! I filed this jira. Hopefully it looks good
https://civisanalytics.atlassian.net/browse/CIVP-12081

LGTM on the JIRA! Thanks!


Extend source file cache invalidation granularity to vanilla .scala files

Mill's current cache has cache invalidation which has build file granularity.
If you have two files build.sc and other.sc and build.sc imports other.sc, changes in build.sc don't invalidate caches for targets defined in other.sc.
This works only with .sc since they explicitly state dependencies via import $file imports.
It would be nice to extend this to vanilla Scala files.
acyclic can track dependencies between vanilla Scala files. We could use something like it to implement the same support we currently have for *.sc files to *.scala files in the mill-build/src directory.

Superseded by https://github.com/com-lihaoyi/mill/pull/2417, which implements fine grained method-level code change invalidation that works the same for .sc files and .scala files alike (and .java files too)


Make python client an actual package

Just restructuring the python client more like a python package so that setup.py finds it. As noted in #223 installing the package from pypi doesn't work, and this should fix that.
@Primer42 @maddalab @byxorna

Thank you! LGTM

:cake:


missing file added

@v-hearya,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

patterns-practices/reference/unityregionnavigationcontentloader-methods-mspp-unityextensions-regions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


target node [(15.0, 2.355), (15.0, -2.636), (4.167, -30.0), (-15.0, 15.813), (0.284, -30.0)] not in graph

When I prepare nuscenes datas with 'python tools/maptrv2/custom_nusc_map_converter.py --root-path ./data/nuscenes --out-dir ./data/nuscenes --extra-tag nuscenes --version v1.0 --canbus ./data' then it cause following error:

This is a bug from MapTRv2, please refer to https://github.com/hustvl/MapTR/issues/93. It seems you need to update networkx.