Add some capabilities to the Unix wait subsystem

Abandon mutexes on thread exit
Capabilities for thread pool:

Added APIs to WaitSubsystem that work directly on WaitableObjects
Added ability to do an uninterruptible wait. Thread pool infrastructure waits cannot be interruptible.
Added ability to prioritize a wait such that the waiter is registered at the front of the queue of threads to be released. This will be used with a semaphore by the thread pool to release worker threads waiting for work in LIFO order to keep cold threads cold and allow them to time out.

Fixed the check and reset of a pending interrupt

Previously, the checks were done outside the global lock, so a pending interrupt may get recorded for the about-to-wait thread after the check and before it acquires the lock to do the wait. This would result in the waiting thread not being interrupted and it may go into a long wait while an interrupt is pending.
The check for a pending interrupt was previously done before any parameter validation to match the exception order in CoreCLR. This is not strictly necessary and it should be fine to do parameter validation first. Now, the synchronization for the pending interrupt is done mostly using the global lock, with Sleep being a special case. See comment on _isPendingInterrupt in ThreadWaitInfo.

Tests with multiple threads will be coming later

@jkoritzinsky


[Proposal]: Maintaining release pipeline

Greetings,
Hope you are doing well, I am a software engineering student at McGill University and along with 5 other students I am working on improving the release pipeline (Code integration, build, deployment and monitoring) of existing open-source software.
I came across your repo on GitHub and found it interesting, and was wondering if you would be willing to coordinate with us regarding this. For our first sprint, we plan to report on the existing release pipeline for the software and identify limitations in areas of integration, build, and deployment.
Will be looking forward to a reply from you!
For future sprints, we will be working on improving the release pipeline by overcoming the identified limitations.
If this is not the correct platform to discuss this, can you please provide the maintainer's email?

Reached out on Discord to no response; closing for inactivity


[SPARK-19542][SS]Delete the temp checkpoint if a query is stopped without errors

What changes were proposed in this pull request?
When a query uses a temp checkpoint dir, it's better to delete it if it's stopped without errors.
How was this patch tested?
New unit tests.

Test build #72680 has started for PR 16880 at commit 22e02b9.

Test build #72682 has started for PR 16880 at commit e5fa7d7.

Test build #72680 has finished for PR 16880 at commit 22e02b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72680/
Test PASSed.

Merged build finished. Test PASSed.

Test build #72682 has finished for PR 16880 at commit e5fa7d7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72682/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. I left one question, but then checked and found the answer.

Test build #72721 has started for PR 16880 at commit cae981f.

Test build #72721 has finished for PR 16880 at commit cae981f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72721/
Test PASSed.

LGTM! Merging to master and 2.1.


ultrawide suddenly stopped working?

I play on Steam Deck and this was working perfectly fine yesterday but then today when I launched the game it had the black bars again. The intro skip still works though. This is very confusing as I didn't even touch anything after I got it to work. I use python er-patcher -us -- %command% in the properties. When I launched it today and it broke I tried  running it without er-patcher then running it with it and that didn't work. I tried using --all instead but that didn't work either. Then I tried reinstalling er-patcher but that didn't work either.

So the game still runs when using er-patches and only the ultrawide patch is not working properly? That is strange indeed.
The patch should still work as of Elden Ring v1.10, so something else is not right.
Did you check the correct resolution is set in Elden Ring? Other than that I'm not sure what could be causing it.

The resolution was the problem. I feel silly now that I didn’t even consider that.


Temperature Converter[GSSOC'23]

Project title
Temperature Converter Website
Project Description
Hello Sir/Ma'am👨💻 ,I am Arpan Chowdhury, a aspiring Web developer.🤖 Here is the project of the front-end Web Development. All of us use many websites or other platforms to check the conversion between Celsius-Fahrenheit-Kelvin-Rankine. Why waste your time in so much searching🔎?Just use this website to check the results within seconds.
Video
https://github.com/apu52/Temperature_Converter/assets/114172928/266bcd52-a059-4875-89f4-50bbac58aed9
Please assign me the issue under GSSOC'23.

@Shreyaar12 @cleveranu @Dharmesh177 Please assign me the issue


TF v2.12 and misc. bug fixes

@anuprulez and @bgruening,
I attempted to update this image (and the tool ). Mostly due to old lib versions, I was unable to use it for a project due to errors here and there (lib missing, permission denied, file not found...) .
I also tried to address https://github.com/usegalaxy-eu/issues/issues/450 by forcing GPU version of TF to be used if an NVIDIA GPU is detected during the startup.

Nice! I think we should add CI testing here and automatic pushes. You can get inspiration from the normal jupyter notebook I think, if you have time to work on it.

I will work on it.
Question, likely beyond this PR: why do we have 2 separate jupyter notebooks?
Would it not be possible to combine ML and normal jupyter notebooks into 1 xml only and switch between them, if necessary, by choosing from a drop menu?

Would it not be possible to combine ML and normal jupyter notebooks into 1 xml only and switch between them, if necessary, by choosing from a drop menu?

That is a great idea. But I don't know how to do that yet. Requirements (that is the container) are fixed and can not be changed at runtime yet.
(History: the previous iteration called IEs had this feature)

Oh sorry, I had hoped we had something more recent in the other repo: https://github.com/bgruening/docker-jupyter-notebook/blob/master/.travis.yml
But I was wrong. I guess you need to start from scratch :(

I added GH workflow for merges and PRs, also set the logins as secrets. Though as if it does not take into effect immediately?

Please feel free to create a new dummy PR, changing a whitespace, see if it turns green, merge and tag a release. I'm going to bed here :-)

Thanks a lot @tuncK this looks very cool!


Network nodes without a reference - as a feature, not an error!

We encounter instances of network nodes without a node number. We had them down as errors, but they are used systematically by some operators.
These are actual switch points with the arrow shields pointing to different directions/nodes, they just do not carry a number and are not end points of any route. At least one direction is common to two routes.
I think this setup should be accommodated.
Proposal
I propose to tag these nodes as regular nodes, with the (to be) reserved rwn_ref=*
Analysis should allow middle nodes tagged rwn_ref=* in the routes. Comparable to how nodes with the same number as one of the end nodes are allowed.
This should in principle give applications the information they need for rendering, planning and exporting the routes.
I think the handling for Planner also resembles the way that nodes with the same number as one of the end nodes are handled.
Status
The problem is recognised and I am told for bicycle routing a similar solution is already in use.
There is no broad consensus about the proposed solution.
For the discussion, it would help to know if the assumptions in the above are correct. Maybe a better solution springs to mind?

https://knooppuntnet.nl/nl/analysis/node/354906288 is my test node

Following changes have been done in release 3.0.3:

routes with star-nodes (rwn_ref=*) no longer receive fact RouteRedundantNodes (OvertolligKnooppunt)
the star-nodes are displayed with a small circle without node name in the planner map
star-nodes cannot be used to plan a route (cannot click the node, or use as drag target)
it is still possible to ctrl-click the star-node in the planner map to navigate to the node details page

Looks fine for walking!
Does it also apply to cycling and to the other modes of transport?

Yes, this should also work for cycling, horse-riding, motorboat, canoe and inline-skating.

I'll bring it to the forum.


Err:  runtime error: invalid memory address or nil pointer dereference

I restarted the Threadfin binary today and received the following error:
user@localhost:~$ ./Threadfin
For help run: ./Threadfin -h

2024/05/17 08:23:40 [Threadfin] Version:                1.0 Build: 27
2024/05/17 08:23:40 [Threadfin] Database Version:       0.5.0
2024/05/17 08:23:40 [Threadfin] System IP Addresses:    IPv4: 3 | IPv6: 2
2024/05/17 08:23:40 [Threadfin] Hostname:               localhost
2024/05/17 08:23:40 [Threadfin] System Folder:          /home/user/.threadfin/
2024/05/17 08:23:40 [Threadfin] Load Settings:          /home/user/.threadfin/settings.json
2024/05/17 08:23:40 [Threadfin] Temporary Folder:       /tmp/threadfin/2019-01-DEV-Threadfin!/
2024/05/17 08:23:40 [Threadfin] GitHub:                 https://github.com/Threadfin
2024/05/17 08:23:40 [Threadfin] Git Branch:             Beta [Threadfin]
2024/05/17 08:23:40 [Threadfin] SSDP / DLNA:            true
2024/05/17 08:23:40 BRANCH:  Beta
2024/05/17 08:23:40 FILE:  https://github.com/Threadfin/Threadfin/releases//download/Threadfin_linux_amd64?raw=true

* * * * * FATAL ERROR * * * * *
OS:   linux
Arch: amd64
Err:  runtime error: invalid memory address or nil pointer dereference

panic.go:838 runtime.gopanic
panic.go:220 runtime.panicmem
panic.go:219 runtime.panicmem
version.go:369 github.com/hashicorp/go-version.(*Version).String
version.go:369 github.com/hashicorp/go-version.(*Version).String
version.go:116 github.com/hashicorp/go-version.(*Version).Compare
version.go:298 github.com/hashicorp/go-version.(*Version).GreaterThan
update.go:125 threadfin/src.BinaryUpdate
threadfin.go:191 main.main
proc.go:259 runtime.main
asm_amd64.s:1572 runtime.goexit

* * * * * * * * * * * * * * * *

I redownloaded the binary and received the same error. I then built it from source and still received the same error. I can start it with -dev fine, which seems like it starts because it doesn't try to download the file?

You need to manually update to the latest version please.


Prepare all configuration dependencies as part of vermin binary

related to dawidd6/homebrew-tap/pull/192


Fix broken link from the documentation of SmartForm to its API reference

The current link ends with an erroneous ".html" suffix, leading to an empty page.

Hi @dstork  , thanks for your contribution. We appreciate it and will look into this.

Hi @dstork, I have adapted the documentation for 1.113. Thanks again for spotting this!

https://people.sap.com/storkd


Externaly saved settings files

📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
Basically just have the option to load/save a settings file in a location of my choosing. The way I'd personally use this, is to have that file in a cloud folder and thus synced across all of my Windows devices.
If you'd like to see this feature implemented, add a 👍 reaction to this post.

dup #3381
see https://github.com/microsoft/PowerToys/issues/3381#issuecomment-632307445

Duplicate of #3381


Feature/batch communication

Codecov Report

Merging #9 (0637667) into main (76d0d18) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   88.19%   88.26%   +0.06%
==========================================
  Files          53       53
  Lines        2567     2582      +15
==========================================
+ Hits         2264     2279      +15
  Misses        303      303

Impacted Files
Coverage Δ

evosax/__init__.py
100.00% <100.00%> (ø)

evosax/subpops/protocol.py
96.66% <100.00%> (+2.91%)
:arrow_up:


Bring fish shell wherever you go through the SSH

xxh project is to bring fish shell wherever you go through the SSH:
xxh myhost +s fish

@anki-code Hey! 👋
This doesn't seem to be written in fish, but https://github.com/xxh/xxh-plugin-fish-example is, so we might consider adding that to this list.

Hi @jorgebucaran ! xxh allows you to use fish anywhere you use ssh. We made:

xxh/fish-portable - portable version of fish
xxh/xxh-shell-fish - entrypoint for portable fish
xxh/xxh-plugin-fish-ohmyfish - Oh My Fish plugin for xxh-shell-fish
xxh/xxh-plugin-fish-fisher - Fisher plugin for xxh-shell-fish

The main xxh tool written on python and fish used in xxh-shell-fish and the plugins.
As you can see we made some ecosystem to use fish during ssh sessions. Or the pure fish scripting is required and xxh repo can't be mention?

@anki-code May be create separate section for this kind of solutions?

Yes, you're right, we may need a new section—let me think about this one. In the meantime, submit your utility (which looks pretty cool btw) to other similar lists like:

https://github.com/alebcay/awesome-shell
https://github.com/herrbischoff/awesome-command-line-apps
https://github.com/sintaxi/awesome-cli

@anki-code I appreciate the work you've put into your project, but I've concluded this falls in the "not a fish project" category and I want projects written exclusively in fish here. Sorry.
Please consider submitting xxh to other similar curations like:

https://github.com/alebcay/awesome-shell
https://github.com/herrbischoff/awesome-command-line-apps
https://github.com/sintaxi/awesome-cli

@anki-code May be create separate section for this kind of solutions?

I'll consider it, but I can't promise whether I'll add one. I'll let you know if I do, though.


Document suds client configuration

Document how to configure http via proxy.  Fixes https://github.com/jzempel/stamps/issues/11

I figure this is worth documenting because the stamps.com testing api used during development is whitelisted by ip address.  So if you are developing offsite or mobile it is convenient to use a proxy so your requests originate from an allowed ip.


Query timestamp field problem

CrateDB version:
4.2.3
python-crate : 0.21.1
Environment description:

Docker: 19.03.12
Problem can be reproduced without docker:

[x] yes

Problem description:

Steps to reproduce:

Table definition:
CREATE TABLE test.compositekey (
        ts TIMESTAMP,
        path STRING,
        PRIMARY KEY ("ts", "path")
    )

Insert row:
INSERT INTO test.compositekey (ts, path) VALUES ('2017-06-21T00:00:00.000000Z', 'c1')

When I use python-crate for query:
with connect() as conn:
    cur = conn.cursor()
    cur.execute("""SELECT ts, path FROM test.compositekey WHERE ts = '2017-06-21' AND path = 'c1'""")
    print(cur.fetchall()) # returns the row
    cur.execute("""SELECT ts, path FROM test.compositekey WHERE ts = ? AND path = ?""", (datetime(2017, 6, 21), "c1",))
    print(cur.fetchall()) # returns the row
    cur.execute("""SELECT ts, path FROM test.compositekey WHERE ts = ? AND path = ?""", ('2017-06-21', "c1",))
    print(cur.fetchall()) # doesn't return the row
    cur.execute("""SELECT ts, path FROM test.compositekey WHERE ts = ?::TIMESTAMP AND path = ?::TEXT""", ('2017-06-21', "c1",))
    print(cur.fetchall()) # doesn't return the row

The first two queries just return the inserted row.
Note: with CratedDB 4.0.12, everything is fine and all the above 4 query works fine.

Thank you for the report, we'll have a fix for this in 4.2.5


[nmstate-1.2] Backport vlan tag python fixes

Codecov Report

:exclamation: No coverage uploaded for pull request base (nmstate-1.2@a2b2e48). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             nmstate-1.2    #1862   +/-   ##
==============================================
  Coverage               ?   57.76%
==============================================
  Files                  ?       87
  Lines                  ?     7231
  Branches               ?        0
==============================================
  Hits                   ?     4177
  Misses                 ?     3054
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b2e48...d155f6a. Read the comment docs.


feat(actor): introduce module support

This is the first step in addition of a "transitional" module support to wasmcloud_actor crate. When module feature is enabled, wasmcloud_actor relies on legacy wasmbus API. The module-based API mimics functionality exposed by component model-based support, meaning, that switch to components will be a breeze for users.
Related Issues

#317
Release Information

Consumer Impact

All traits are now good-old sync, that may change in the future depeding on how the component model API will shape up, TBD. It seems that sync is actually, explicitly, desired
No direct wasmbus-rpc usage in actors
Fail in builtin execution will result in runtime panic on the actor side, since component model API for these functions does not provide a way to handle errors. That's fine, since users should transition to component model anyway and that's what we're facilitating here
No code generation, i.e. no custom interfaces (yet?). We probably should not support custom interfaces using Smithy at all as part of this effort as by the time we're done, users should be transitioning to WIT and component-model

Testing

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[ ] x86_64-windows

Tested on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[ ] x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

Unit tests

Note the similarities between
https://github.com/rvolosatovs/wasmCloud/blob/e792ef48090008ed1c5ee0c56c256e3e9a8c83f8/tests/actors/rust/http-log-rng-module/src/lib.rs
and
https://github.com/rvolosatovs/wasmCloud/blob/feat/actor-sdk/tests/actors/rust/http-log-rng-component/src/lib.rs
The two are nearly identical, although the former is a usual Wasm module, whereas the latter ulitizes component model APIs generated via WIT


Update incognito session initialization

With https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5, the values being registered in a session were changed from an exclusion (ex: which values to NOT put in OverlayUserPrefStore) to an inclusion (ex: which values to PERSIST, even in an incognito profile)
Fixes https://github.com/brave/browser-laptop/issues/15191

I renamed the variables/methods to match the renaming done upstream:
AddOverlayPref => RegisterPersistentPref
overlay => persist
overlay_pref_names => persistent_pref_names_

See https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5^!/#F4 for more info


Is possible add a marker without Native INFO WINDOW?

Hello,
Im trying to add a list of markers, but i want to hide the INFO Window (onclick) i already hide using the (marker.hideInfoWindow();) on MARKER_CLICK but the behavior is a little bit strange.
How i can add the marker and set the default value for the INFO Window?
Best Regards.

let marker = map.addMarker({
     position : ...,
     myValue : "something"
});

console.log(marker.get("myValue"));

Hi @wf9a5m75, thanks for the fast reply.
My question is how to hide the
 when i click on the marker.

Add title property

Please check the document for more information
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.6.0/README.md

What do you mean of without Native INFO WINDOW?

The infoballon with the information about the marker.

I asked what are you pointing "without"?
If you write like this,
let marker = map.addMarker({
   'title': 'something'
});
marker. showInfoWindow();

the native info window will be displayed.

But you asked without native infoWindow.
I'm not sure what you want to know.

There are two types InfoWindow in this plugin.
Using title and/or snippet properties, you can show the native info window, which is provided by Google, and you can not use HTML tags.
HTMLInfoWindow is provided by this plugin, and you can use HTML tags.

I asked what are you pointing "without"?
If you write like this,
let marker = map.addMarker({
   'title': 'something'
});
marker. showInfoWindow();

the native info window will be displayed.
But you asked without native infoWindow.
I'm not sure what you want to know.

If i dont fill the title and/or snippet, the native info window will not be shown?

Yes that's it 👍 thank you.

Yes that's it 👍 thank you.

That's not true my dear, removing title and snippet does not remove the infowindow.
You have to add  :
const marker: Marker = this.map.addMarkerSync(point);
marker.hideInfoWindow();


README doesn't expand on project description or give examples of usage

While the project description gives the purpose of cfdot, I can't really imagine what it does.

@jchesterpivotal We've added more to the README about the current BBS-API-focused capabilities of cfdot. Is there anything else you'd like to see?
Thanks,
Eric


Cannot read property 'releaseMouseMoves' of undefined

Hello,
I have a small issue with the fixed data table that is causing me some severe problems.
Essentially I have a fixed-data-table and when I navigate away with react-router I get an error and my app stops working :-1:
Scrollbar.react.js:180 Uncaught TypeError: Cannot read property 'releaseMouseMoves' of undefined
Is the error...
I wondered if it is because of this line:
delete this._mouseMoveTracker;
I'll create a testcase later but I'll add this bug as a placeholder just in case it's been spotted and fixed (I did search first)!  Thanks so much for fixed data table it's really amazing.

This seems to only occur when I call .refresh() on a ref to the table.  Very strange.

This lovely bug is caused by having react inside a react modules npm.  Somehow webpack includes it twice.  Nice.

Hey, I am having the same issue. When I navigate to another route, I see this error in FixedDataTableColumnResizeHandle.react.js L109
Still don't know how to resolve this issue.


TensorFlow and TensorFlow Lite to TOSA Legalizations

This constitutes the current base of stable and tested legalizations from TensorFlow and TensorFlow Lite MLIR dialects to the TOSA dialect. Includes MLIR tests and a document describing the functional operation of the legalizations .
Currently does not have conditional build rules for integration - this was only tested locally to a limited extent and was not pushed. We would like guidance on how to ensure we can smoothly build this with the rest of TensorFlow MLIR infrastructure.

FYI - I have pre-created the directory for you and included a boiler-plate BUILD file. You will need to rebase against master and resolve the small conflict this creates. (this was necessary to opt the project out of the CIs, which we want to do until stable)

Yes I am working on this. I've rebased and have mostly resolved the conflict. I may need to also incorporate the conditional build flag requested in another piece of feedback here.

Thanks for the contribution! This is very exciting to see the connection coming there :)
Skimming quickly through it this looks great!
There are many pieces that are independent here and that would be easier to integrate/review in a sequence of PRs.
For example, an easy first split is to leave off the TFL path for now and add it later. A gradual integration would add the basic structure, and follow a "one PR per pass" path roughly, keeping the PR size to ~400-600 lines of source code (not counting BUILD files and similar boilerplate). Let me know if you'd like to discuss the plan in more details! We can also GVC if it is more convenient for you.

I personally find this master PR quite useful to see the whole scope, but I do agree that reviews are going to be unwieldy on this size (GitHub's UI makes this especially hard). I would also like to find a way that reduces your overhead in getting these things landed.
How about this as a process, biased purely towards having digestible review chunks (I'm open to any arrangement and the following is just how I would do it with git):

We take a pass through and comment on this master PR for structural nits (file names, etc) that impact how the patch is put together.
You keep this master PR and create child branches for the chunks, either one at a time or pre-factored into all chunks. I'm fine/would prefer a pass or logical chunk/file at a time, even if quite large. And I specifically know that I will be spending quite some time reviewing the TFL pass and would value that more. (The others are more formulaic)
When we land a chunk, you rebase the branch and push the update for this PR until we've landed everything.

If I were doing this in git, I would create a branch off of your current tosa-lowerings-v4 for the first chunk. Then run something like git reset HEAD~1 to move all of the files back to the working set. Then delete the things not in the chunk you want to review first, create a new commit and push to a new branch/PR, referencing this one in the description. If you're very good at juggling, you can create the whole stack like this, but I am not that good at juggling and usually prefer to slice out one at a time when using such a workflow.

I also noticed you are handling the TF functional control flow, but we're moving away from this. I rather see you handling "CaseRegionOp", "IfRegionOp", and "WhileRegionOp" here. You can use tf-functional-control-flow-to-regions as a pre-step in the pipeline to convert the functional ops to the region equivalent: the plan is to have this be the default when importing TF in the future.

I also noticed you are handling the TF functional control flow, but we're moving away from this. I rather see you handling "CaseRegionOp", "IfRegionOp", and "WhileRegionOp" here. You can use tf-functional-control-flow-to-regions as a pre-step in the pipeline to convert the functional ops to the region equivalent: the plan is to have this be the default when importing TF in the future.

Yes we haven't kept up with the state of the art in TF and MLIR control flow structures. We can unstage these passes, review what's needed and restore them in a later patch.

If I were doing this in git, I would create a branch off of your current tosa-lowerings-v4 for the first chunk. Then run something like git reset HEAD~1 to move all of the files back to the working set. Then delete the things not in the chunk you want to review first, create a new commit and push to a new branch/PR, referencing this one in the description. If you're very good at juggling, you can create the whole stack like this, but I am not that good at juggling and usually prefer to slice out one at a time when using such a workflow.

Yes the current plan is to separate out the control flow passes and a few more things, and send a new update early next week once these updates have cleared IP review.

I just force pushed an update to tosa-lowerings-v4 after rebasing and resolving against upstream master .

The latest update has:

Removed the control flow passes.
Renames and updates behavior of prior tosa-combine as fuse_bias, as Kevin describes.
Removes the tosa_compiler binary entirely
Adds macro based conditional building of TOSA libraries.

We'll submit an update with the resolutions above once IP review clears.

@sjarus Can you please address Ubuntu Sanity errors? Thanks!

@sjarus Can you please address Ubuntu Sanity errors? Thanks!

Ubuntu Sanity is entirely Bazel BUILD indent formatting feedback, though it didn't trigger a command-line failure. Apparently it doesn't like our default editor bazel-mode.
@stellaraccident is currently in the process of making some changes based on internal copybara checks, and I want to avoid making a conflicting push. Is it possible for this file indenting be easily addressed within your editor, @stellaraccident  ?


Support timestamp for Span.addEvent()

We need this to have the OT bridge - related to #22 it seems to be ;)

Allowing users to set a timestamp for any event (start, event, end) will make hard for implementations to use a monotonic clock that can ensure ordering of events (you cannot control how the timestamp is retrieve when the user can provide it). Also allowing this functionality you cannot ensure that all the events timestamp are in the interval [start, end].
Can you give me some examples where this is needed?

@carlosalberto I heard that this was resolved.

Closing this one.


Add Electroman Edventures (Metal Remix) by Mr.CriperMusic

Song Name
Electroman Edventures (Metal Remix)
Artist Name
Mr.CriperMusic
Source
Youtube
Youtube Link
S0T4SuGB2oos8ZZe
Direct File Link
No response
Song ID
12
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 428765

reject
invalid YouTube link


fix(search): have search bar ignore blank searches

Followups:

we should provide some guidance to users who attempt to do blank searches
we should refactor search code so that we don't have search logic in 3 places.

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

lgtm! thanks gabe!


ObserverLocator assumes OoPropertyObserver when getObserver is called for an undefined property

When getObserver is called for an undefined property an instance of OoPropertyObserver is returned.
When the property later becomes defined and is not a primitive property (has a getter/setter), the incorrect observer type has already been returned to the templating system so property change events cannot be observed.
I'm thinking we should return an instance of a new class: UndefinedPropertyObserver.  This new class would listen for the property to become defined using Object.observe.  When this happens it would do the following:

call ObserverLocator.getObserver to retrieve the correct "actual" observer.
delegate the subscribe, getValue and setValue methods to the "actual" observer.
funnel any existing callbacks into the "actual" observer via it's subscribe method.

note: UndefinedPropertyObserver's setValue method would need to have special handling to ensure the appropriate observer is created and change events are published.
Edit
specifically talking about cases where Object.getOwnPropertyDescriptor returns undefined.  (As opposed to cases where it returns {value: undefined, writable: true, enumerable: true, configurable: true})

How should we handle this if Object.observe is not present?

I think that would continue to fall through to SetterObserver


Angular4

There is a waring in angular 4:
Template parse warnings:
The
<ng-content *ngIf="!componentRef">
"): ng:///UIRouterModule/UIView.html@1:4

Thank you.  This should be fixed in https://github.com/ui-router/ng2/pull/68/files


Updated TeamViewer Host to 15.10.5

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

I seem to be having trouble accessing the URL


ValueError in Interpolation with large samplesize/dimension

Hi! I was trying to use the library and ran into the error that reads "ValueError: left interp size (torch.Size([20000, 1, 1])) is incompatible with base lazy tensor size (torch.Size([20000, 20000])). Make sure the two have the same number of batch dimensions".
This only happens when I run on data with high-sample size/ dimension. I've modified the code in notebooks/bi_gp_ls.ipynb to replicate the error though the error occurs with different kernel settings. Is there an easy way to fix this, or are there extra steps when dealing with larger datasets? Thanks!
from tqdm.auto import tqdm
import torch
import gpytorch as gp
import altair as alt
import pandas as pd
import numpy as np

from gpytorch_lattice_kernel import RBFLattice as BilateralKernel

class BilateralGPModel(gp.models.ExactGP):
    def __init__(self, train_x, train_y):
        likelihood = gp.likelihoods.GaussianLikelihood()
        super().__init__(train_x, train_y, likelihood)
        # self.mean_module = gp.means.ConstantMean()
        # self.covar_module = gp.kernels.ScaleKernel(BilateralKernel(ard_num_dims=train_x.size(-1)))
        self.mean_module = gp.means.ZeroMean()
        self.covar_module = BilateralKernel()

    def forward(self, x):
        mean_x = self.mean_module(x)
        covar_x = self.covar_module(x)
        return gp.distributions.MultivariateNormal(mean_x, covar_x)

def train(x, y, model, mll, optim):
    model.train()

    optim.zero_grad()

    output = model(x)

    loss = -mll(output, y)

    loss.backward()

    optim.step()

    return { 'train/ll': -loss.detach().item() }

def test(x, y, model, lanc_iter=100, pre_size=0):
    model.eval()

    with torch.no_grad():
#        gp.settings.max_preconditioner_size(pre_size), \
#        gp.settings.max_root_decomposition_size(lanc_iter), \
#        gp.settings.fast_pred_var():
        preds = model(x)

        pred_y = model.likelihood(model(x))
        rmse = (pred_y.mean - y).pow(2).mean(0).sqrt()

    return { 'test/rmse': rmse.item() }

def train_util(model, x, y, lr=0.1, epochs=100):
    mll = gp.mlls.ExactMarginalLogLikelihood(model.likelihood, model)
    optim = torch.optim.Adam(model.parameters(), lr=lr)

    for _ in tqdm(range(epochs), leave=False):
        train_dict = train(x, y, model, mll, optim)

    return train_dict

n = 20000
d = 4
x = 2. * torch.rand(n, d) - 1.

with torch.no_grad():
  covar_module = gp.kernels.ScaleKernel(gp.kernels.RBFKernel())
  params = covar_module.state_dict()
  params['raw_outputscale'] = torch.tensor(1.0).log()
  params['base_kernel.raw_lengthscale'] = torch.Tensor([[1.5]]).log()
  covar_module.load_state_dict(params)

  covar = gp.distributions.MultivariateNormal(torch.zeros(n), covariance_matrix=covar_module(x))

rperm = torch.randperm(n)[:n//2]
train_x = x[rperm]
train_y = (covar.sample() + 0.1 * torch.randn(x.size(0)))[rperm]

for _ in tqdm(range(10)):
  bigp = BilateralGPModel(train_x, train_y).float()

  with gp.settings.max_root_decomposition_size(50):
    train_dict = train_util(bigp, train_x, train_y)

  for name, p in bigp.named_parameters():
    results[name].append(p)
  results['kind'].append('Bilateral GP')

  for k, v in train_dict.items():
    results[k].append(v)

Hello just wanted to mention that I am experiencing this exact issue in my testing as well for large datasets past roughly 1500 data samples.
I have been able to fix this problem by manually evaluating the kernel in the forward pass of my GP class and adding noise to retain PSD,
 K =  covar_x.to_dense();
return MultivariateNormal(mean_x, K + noise* torch.eye(K.shape[0]).to(self.device))
However, this likely scales poorly and looses the benefits of the LazyTensor abstraction.

hmm @activatedgeek is this because of a change in gpytorch perhaps? Do we need to put version restrictions on it if we have not done so already?

I had a look into it. I think it may be from some implicit assumptions LazyTensors being extendible to batch objects with bs (1) with _unsqueeze_batch in the GPyTorch internals but I'm checking with those folks now.
It appears that making the following changes to SquareLattice in bilateral_kernel.py at least get the code to run (reshapes in case x has a batch dimension). (Note that with the dimensional assert statements commented back in, the error is caught in the unsqueeze_batch functionality).
class SquareLazyLattice(LazyTensor):
    def __init__(self,x,dkernel=None):
        super().__init__(x,dkernel=dkernel)
        #assert x.ndim==2, f"No batch (even of size 1) inputs supported, got {x.ndim} with shape {x.shape}"
        self.x = x.reshape(*x.shape[-2:])
        self.orig_shape = x.shape
        self.dkernel=dkernel

    def _matmul(self,V):
        #assert V.ndim<=2
        out = LatticeFilterGeneral.apply(V.reshape(*V.shape[-2:]),self.x,self.dkernel)
        return out.reshape(V.shape) # unflatten if there were batch axes
    def _size(self):
        return torch.Size((*self.orig_shape[:-1],self.x.shape[-2]))
    def _transpose_nonbatch(self):
        return self
    def diag(self):
        return torch.ones_like(self.x[...,0])

Once we figure out what's really going one we can push out an update. Let me know if this band aid solves the problem for you guys.


Changing the MessageInfoAndMetadataListSerde version to 6

Changing the MessageInfoAndMetadataListSerde's AutoVersion to version 6. In the new version, we can send out the lifeVersion in the message info so the other server can replicate based on the lifeVersion.
This has to be merged after the deployment of server 16.1.399 on both frontend and server.

Codecov Report

Merging #1443 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1443      +/-   ##
============================================
+ Coverage     73.13%   73.18%   +0.04%
- Complexity     7648     7703      +55
============================================
  Files           552      552
  Lines         42385    42385
  Branches       5318     5315       -3
============================================
+ Hits          30998    31019      +21
+ Misses         9841     9824      -17
+ Partials       1546     1542       -4

Impacted Files
Coverage Δ
Complexity Δ

...mbry.protocol/MessageInfoAndMetadataListSerde.java
88.14% <100.00%> (ø)
47.00 <1.00> (?)

...java/com.github.ambry.store/CompactionManager.java
89.88% <0.00%> (-2.39%)
25.00% <0.00%> (ø%)

...rc/main/java/com.github.ambry.store/BlobStore.java
89.56% <0.00%> (-0.19%)
109.00% <0.00%> (-1.00%)

...ain/java/com.github.ambry.router/PutOperation.java
91.57% <0.00%> (-0.17%)
114.00% <0.00%> (-1.00%)

...n/java/com.github.ambry.store/PersistentIndex.java
90.07% <0.00%> (+0.11%)
244.00% <0.00%> (+1.00%)

...in/java/com.github.ambry.store/BlobStoreStats.java
71.25% <0.00%> (+0.62%)
104.00% <0.00%> (+1.00%)

...m.github.ambry.replication/ReplicationMetrics.java
94.48% <0.00%> (+1.14%)
46.00% <0.00%> (+1.00%)

...va/com.github.ambry.replication/ReplicaThread.java
87.33% <0.00%> (+1.51%)
94.00% <0.00%> (+2.00%)

.../main/java/com.github.ambry.store/ScanResults.java
82.81% <0.00%> (+1.56%)
17.00% <0.00%> (+1.00%)

.../com.github.ambry.network/BlockingChannelInfo.java
84.12% <0.00%> (+3.17%)
16.00% <0.00%> (ø%)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4c360...490f3ed. Read the comment docs.

Any reason not to merge this now?


88_Merge Sorted Array

This PR has been excluded, it is saying this repository did not follow the hacktoberfest guidelines. Why ?

This PR has been excluded, it is saying this repository did not follow the hacktoberfest guidelines. Why ?

Because nobody is solving issues, everyone copy paste code for the t-shirt.


Normalize format of config file

This will let us script changes to it with less noise in the diffs.

I'm going to go ahead and merge this.


How to play reterraforged 1.20.1

Can you make a dowloadable jar file?

Yeah jar files under github releases would be useful, I don't want to download java build tools just to play this mod.

https://discord.com/channels/687310840915165240/726158888717517094/1219689499198754886


Provide the khiops-env script for all packages

The script khiops-env is designed to be used by pyKhiops to run Khiops with the proper settings concerning java and mpi. It appears that it is not usable in conda environments. It would be "healthy" to use khiops-env in all environments and then we have to provide khiops-env in all khiops packages (conda included).

For windows the problem is that khiops-env is generated by the nsis script  during the install process.
There are two main issues:

the jre path is discover by scanning the registry
the process number is set by a nisis function

The first one is no longer a problem because the jre is now vendored with khiops.
For the second one, we can get the process number directly in khiops-env by using  wmic. Unfortunately, It is a bad solution because  wmic is deprecated.
Another solution is to build a little binary to get the process number (in the stdout). Then to package this binary within khiops and to call this binary in khiops-env.


fix logical error

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

(No change) If the service DOES support deleting a service-linked role, you should always do the deletion using that service's published method. However if a service does NOT support deletion, you can use IAM as an alternative.


Use two-digit hour in exports

This string not being a predictable length for every entry caused problems for Excel and Tableau to automatically read the data as timestamps. This changes it to always print a two-digit hour, prepending with a 0 as needed.
https://github.com/civiform/civiform/issues/6464

@nb1701 @avaleske Matthew confirmed that he's good with using an ISO format

@nb1701 @avaleske Matthew confirmed that he's good with using an ISO format

just said the same on the issue! https://github.com/civiform/civiform/issues/6464

Oh please also update the api docs:

https://github.com/civiform/docs/blob/main/docs/it-manual/api/program-applications.md#create_time
https://github.com/civiform/docs/blob/main/docs/it-manual/api/program-applications.md#submit_time


Add local and global rotation for sprite and mesh

@Foxar please describe the feature if you could.

The behavior is well described here:
https://www.youtube.com/watch?v=q0jgqeS_ACM&ab_channel=Udacity
As of now, tyra allows only for flawed rotation of 3d models because of usage of Euler angles. This means they can only rotate around their own axes. This behavior can be noticed in the dolphin sample, in develop branch:

Intended behavior would be that while submerging, the dolphin's tilted forwards (relative to himself), no matter what his z-rotation (yaw/heading).

Resolved in Tyra 2.0.0


regChksum and verifyChksum not accessible in pep_api_data_obj_copy_* PEPs

In the iRODS rule language version of the pep_api_data_obj_copy_* PEPs, the *DATAOBJCOPYINP input parameter KV map has an entry regChksum when icp was called with the -k flag and an entry verifyChksum when icp was called iwth the -K flag. In the Python version of the PEPs, the corresponding DataObjCopyInp object doesn't have a condInput property where entries for regChksum and verifyChksum would likely be stored.

Similarly, the python version cannot access dest_resc_hier like the iRODS rule language can. This is the resource hierarchy path to the storage resource where iRODS will write/wrote the physical copy.

Never mind.  All of this information can be found through the destDataObjInp property of DataObjCopyInp.


[#60 ] remove override of input & select styles within a Table

Currently our Table is overriding our input & select styles; cause inputs and selects within a table to appear as such:

Not sure if we intentionally want our native selects to not include their default styling; selectively only keeping input styles (but not on the native select) would look as such:

In my opinion, it is better UI for the user to clearly see the input or select within the table, such as:

I, personally, completely agree with you and think that the table as is in the 3rd screenshot provides a better UX.

I agree with the third screenshot as well


Added link for Edabit

Edabit is a free tool for practicing / learning to code.

Merged as 73a4fb5e


Allowing empty segments with kafka consumption

We have a fairly unique consumption pattern that leads to consumption issues in Pinot.

our Pinot table is set to consume topic T across P partitions.
topic T has many different shapes of events, but at ingestion time we filter out any events that do not meet criteria C
topic T has a high number of events per second
for some Partitions P, there may be 0 events for days that match our criteria

What ends up happening is Pinot never seals those segments but continues extending their lease. When we go to restart Pinot servers, they then restart consuming from days ago. This leads to a huge amount of data being consumed just to be filtered out again, throttling from the kafka side, and waiting hours for the server to go healthy again.
I believe kinesis already has a way to seal "empty segments" that we would need here as well to get Pinot to continue advancing offsets correctly.

This is a fair ask. Since we introduced filtering during ingestion, if the offset moves but no record ingested, we should commit an empty segment and move the offset. cc @npawar @mcvsubbu


10 build demo slot component

What type of PR is this? (check all applicable)

[X] Feature
[ ] Refactor
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Other (please specify here: )

Description of what this Pull Request does
Generates Demo list of students and allows instructor to change their status and update the database with that change.
Related Tickets & Documents

Closes #10
Related Issues: (enter ticket numbers here)

QA Instructions, Screenshots, Recordings
Please look over logic and update styling per David's choices.
Also please note, I had merge conflicts when pulling from main, they should have been resolved, but wanted whomever reviews to be aware.

Added/updated tests?

[ ] Yes
[X] Not Yet, and here is why: tests being generated still
[ ] I need help with tests
[ ] No, and here is why: explain here

@dagaither we don't have to try and pull up the next student name, I stopped before doing that, I wanted to be sure it was working well and met the MVP criteria. Please feel free to remove that portion, thanks. Also, could you let me know when the PR is merged, that way I can put something in our channel. TIA!

@nekablair Checking now

Looks good 👍 .  For styling I can probably reuse code and format it like /rollcall/ using similar color coding (green - complete, grey - todo, yellow/orange - on deck) then also implement similar sorting function.  Does that sound good?

That actually sounds great @dagaither thanks

Great, NP!


fix: status callback performance AB#9202

@RubenGeo this is then supposed to be the fix, to merge in master. It is copied from this commit on 'refactor-halfway', which also involves the extension of Twilio-mock.
If you agree that (1) this solution will work / not break anything, and (2) that this is for now the best we can do and hope that this solves it, then we should merge this and get it deployed to production before Tuesday.


4 rectangular shapes

local files were messing around with the commit so I updated the files and the .gitignore

LGTM


Add a test confirming comment for the contribution

This repository has travis. So, all test passed is required to build/merge.
https://travis-ci.org/yuki24/did_you_mean

Updated. Could you confirm?

Could you squash the commits into a single commit? Other than that, it looks good!

@yuki24 , Now it's a single commit. Please check :)

Thanks! :heart: :yellow_heart: :blue_heart:


Failed assertion: 'url != null': is not true.

'package:flutter/src/painting/image_provider.dart': Failed assertion: line 451 pos 16: 'url != I/flutter ( 1542): null': is not true.

When the exception was thrown, this was the stack:
I/flutter ( 1542): #2      new NetworkImage (package:flutter/src/painting/image_provider.dart:451:16)
I/flutter ( 1542): #3      new Image.network (package:flutter/src/widgets/image.dart:213:16)
I/flutter ( 1542): #4      HomePage.image (package:news/main.dart:34:20)
I/flutter ( 1542): #5      HomePage.dataList.<anonymous closure> (package:news/main.dart:90:17)
I/flutter ( 1542): #6      SliverChildBuilderDelegate.build (package:flutter/src/widgets/sliver.dart:397:15)
I/flutter ( 1542): #7      SliverMultiBoxAdaptorElement._build.<anonymous closure> (package:flutter/src/widgets/sliver.dart:1000:67)
I/flutter ( 1542): #8      _HashMap.putIfAbsent (dart:collection/runtime/libcollection_patch.dart:143:29)
I/flutter ( 1542): #9      SliverMultiBoxAdaptorElement._build (package:flutter/src/widgets/sliver.dart:1000:26)
I/flutter ( 1542): #10     SliverMultiBoxAdaptorElement.createChild.<anonymous closure> (package:flutter/src/widgets/sliver.dart:1013:55)
I/flutter ( 1542): #11     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2266:19)
I/flutter ( 1542): #12     SliverMultiBoxAdaptorElement.createChild (package:flutter/src/widgets/sliver.dart:1006:11)
I/flutter ( 1542): #13     RenderSliverMultiBoxAdaptor._createOrObtainChild.<anonymous closure> (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:274:23)
I/flutter ( 1542): #14     RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:1730:58)
I/flutter ( 1542): #15     PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:799:15)
I/flutter ( 1542): #16     RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:1730:13)
I/flutter ( 1542): #17     RenderSliverMultiBoxAdaptor._createOrObtainChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:263:5)
I/flutter ( 1542): #18     RenderSliverMultiBoxAdaptor.addInitialChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:341:5)
I/flutter ( 1542): #19     RenderSliverList.performLayout (package:flutter/src/rendering/sliver_list.dart:78:12)
I/flutter ( 1542): #20     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #21     RenderSliverPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:182:11)
I/flutter ( 1542): #22     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #23     RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:405:13)
I/flutter ( 1542): #24     RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1316:12)
I/flutter ( 1542): #25     RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1234:20)
I/flutter ( 1542): #26     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #27     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #28     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #29     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #30     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #31     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #32     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #33     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #34     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #35     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #36     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #37     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #38     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #39     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #40     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #41     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #42     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #43     MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:142:11)
I/flutter ( 1542): #44     _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:339:7)
I/flutter ( 1542): #45     MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:212:7)
I/flutter ( 1542): #46     RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:356:14)
I/flutter ( 1542): #47     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1509:7)
I/flutter ( 1542): #48     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:768:18)
I/flutter ( 1542): #49     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:281:19)
I/flutter ( 1542): #50     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:677:13)
I/flutter ( 1542): #51     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:219:5)
I/flutter ( 1542): #52     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
I/flutter ( 1542): #53     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
I/flutter ( 1542): #54     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:842:5)
I/flutter ( 1542): #55     _invoke (dart:ui/hooks.dart:154:13)
I/flutter ( 1542): #56     _drawFrame (dart:ui/hooks.dart:143:3)
I/flutter ( 1542): (elided 2 frames from class _AssertionError)
I/flutter ( 1542): ════════════════════════════════════════════════════════════════════════════════════════════════════

NetworkImage requires a non-Null URL to be passed.
You can use something like url != null ? Image.network(url) : Container()
Please consider asking support questions in one of the other channels listed at http://flutter.io/support .

Just uninstall the app on emulator or real device.
Close IDE and restart then resync the project and then run your app.
This works for me.

'package:flutter/src/painting/image_provider.dart': Failed assertion: line 451 pos 16: 'url != I/flutter ( 1542): null': is not true.

When the exception was thrown, this was the stack:
I/flutter ( 1542): #2      new NetworkImage (package:flutter/src/painting/image_provider.dart:451:16)
I/flutter ( 1542): #3      new Image.network (package:flutter/src/widgets/image.dart:213:16)
I/flutter ( 1542): #4      HomePage.image (package:news/main.dart:34:20)
I/flutter ( 1542): #5      HomePage.dataList.<anonymous closure> (package:news/main.dart:90:17)
I/flutter ( 1542): #6      SliverChildBuilderDelegate.build (package:flutter/src/widgets/sliver.dart:397:15)
I/flutter ( 1542): #7      SliverMultiBoxAdaptorElement._build.<anonymous closure> (package:flutter/src/widgets/sliver.dart:1000:67)
I/flutter ( 1542): #8      _HashMap.putIfAbsent (dart:collection/runtime/libcollection_patch.dart:143:29)
I/flutter ( 1542): #9      SliverMultiBoxAdaptorElement._build (package:flutter/src/widgets/sliver.dart:1000:26)
I/flutter ( 1542): #10     SliverMultiBoxAdaptorElement.createChild.<anonymous closure> (package:flutter/src/widgets/sliver.dart:1013:55)
I/flutter ( 1542): #11     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2266:19)
I/flutter ( 1542): #12     SliverMultiBoxAdaptorElement.createChild (package:flutter/src/widgets/sliver.dart:1006:11)
I/flutter ( 1542): #13     RenderSliverMultiBoxAdaptor._createOrObtainChild.<anonymous closure> (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:274:23)
I/flutter ( 1542): #14     RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:1730:58)
I/flutter ( 1542): #15     PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:799:15)
I/flutter ( 1542): #16     RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:1730:13)
I/flutter ( 1542): #17     RenderSliverMultiBoxAdaptor._createOrObtainChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:263:5)
I/flutter ( 1542): #18     RenderSliverMultiBoxAdaptor.addInitialChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:341:5)
I/flutter ( 1542): #19     RenderSliverList.performLayout (package:flutter/src/rendering/sliver_list.dart:78:12)
I/flutter ( 1542): #20     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #21     RenderSliverPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:182:11)
I/flutter ( 1542): #22     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #23     RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:405:13)
I/flutter ( 1542): #24     RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1316:12)
I/flutter ( 1542): #25     RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1234:20)
I/flutter ( 1542): #26     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #27     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #28     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #29     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #30     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #31     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #32     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #33     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #34     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #35     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #36     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #37     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #38     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #39     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #40     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #41     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
I/flutter ( 1542): #42     RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
I/flutter ( 1542): #43     MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:142:11)
I/flutter ( 1542): #44     _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:339:7)
I/flutter ( 1542): #45     MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:212:7)
I/flutter ( 1542): #46     RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:356:14)
I/flutter ( 1542): #47     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1509:7)
I/flutter ( 1542): #48     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:768:18)
I/flutter ( 1542): #49     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:281:19)
I/flutter ( 1542): #50     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:677:13)
I/flutter ( 1542): #51     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:219:5)
I/flutter ( 1542): #52     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
I/flutter ( 1542): #53     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
I/flutter ( 1542): #54     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:842:5)
I/flutter ( 1542): #55     _invoke (dart:ui/hooks.dart:154:13)
I/flutter ( 1542): #56     _drawFrame (dart:ui/hooks.dart:143:3)
I/flutter ( 1542): (elided 2 frames from class _AssertionError)
I/flutter ( 1542): ════════════════════════════════════════════════════════════════════════════════════════════════════

Are u solve it

Sorry, Not working on this anymore

did you find any solution?


SE scenario's line overlapping with the background

Description of Problem or Question
Notice the red text above the list which overlaps the background. In the previous versions of the app (before valkyrie-windows-2.2.01b) only expansions' icons were like that but now it looks a bit silly and bad.

I think the element has too large 'z-index' number so it is put over other elements.
Valkyrie Version
From 2.1.5 onwards

Yes this has always been there.
It's not a problem of Z index but the behaviour of Unity scroll list shows the full item even if there is only one small pixel visible in the scroll area.
I can add a mask component on top of the scrollbar to avoid that.
In my opinion this one is minor : cosmetic.


Too many tags - graphic problem on Publish

Bug
When you edit claim and it have too many tags it out of the window :)
Screenshots

System Configuration

LBRY Daemon version: 0.45.0
LBRY App version: 0.37.2
LBRY Installation ID: 7LEseQpAWJXBDuRfGh8gUVRmUGwKVgvLqybVzVwdSr6EA19bubwnAv7p3Q1RFnNpgj
Operating system: Windows 10

Additional context
Add any other context about the problem here.


Remove unused variables

Requirements
The escape argument for inlineDiff() and unifiedDiff() in Base.list() is always false.
inlineDiff() and unifiedDiff() are only used in Base.list() .
I think the escape argument is unnecessary.
https://github.com/mochajs/mocha/blob/9f204ba2b27e254e70e88ab353e8c4cedc7b67f6/lib/reporters/base.js#L188-L220

Coverage increased (+0.07%) to 89.868% when pulling f8a26f174311107e56d2b222bd85528b4752a7c1 on 38elements:patch-3 into 9f204ba2b27e254e70e88ab353e8c4cedc7b67f6 on mochajs:master.

good catch btw--it looks like this variable became useless somewhere around when inline diffs were added

Thank you for reviewing.
Since errorDiff() is only used in inlineDiff(), I removed type and escape  arguments.

Coverage increased (+0.06%) to 89.859% when pulling 6862867f2f9ad3bde1bc4f45f55cdf4895aa4ec6 on 38elements:patch-3 into 9f204ba2b27e254e70e88ab353e8c4cedc7b67f6 on mochajs:master.

Coverage increased (+0.1%) to 89.9% when pulling eee2fec197b20328c8c3a70e86892db2280aa1c3 on 38elements:patch-3 into 9f204ba2b27e254e70e88ab353e8c4cedc7b67f6 on mochajs:master.

@38elements thanks!


[material-ui][docs] Fix sign in side image

[x] I have followed (at least) the PR section of the contributing guide.

closes https://github.com/mui/material-ui/issues/42649
Replace the outdated Unsplash image with a static image.

old
new

@siriwatknp could you help me with the failing tests here?


feat(engine-api): Shanghai support

closes #1297

Codecov Report

Merging #1445 (feb2ecc) into main (5c2f96e) will decrease coverage by 56.44%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1445       +/-   ##
===========================================
- Coverage   76.19%   19.75%   -56.44%
===========================================
  Files         357      357
  Lines       41040    41177      +137
===========================================
- Hits        31270     8135    -23135
- Misses       9770    33042    +23272

Flag
Coverage Δ

integration-tests
19.75% <0.00%> (-2.61%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/rpc/rpc-api/src/engine.rs
0.00% <ø> (ø)

crates/rpc/rpc-engine-api/src/engine_api.rs
0.00% <0.00%> (-95.72%)
:arrow_down:

crates/rpc/rpc-engine-api/src/error.rs
0.00% <ø> (-100.00%)
:arrow_down:

crates/rpc/rpc-engine-api/src/lib.rs
0.00% <ø> (-100.00%)
:arrow_down:

crates/rpc/rpc-engine-api/src/message.rs
0.00% <0.00%> (ø)

crates/rpc/rpc-types/src/eth/engine.rs
0.00% <ø> (-82.15%)
:arrow_down:

crates/rpc/rpc/src/engine/mod.rs
0.00% <0.00%> (ø)

crates/storage/provider/src/traits/header.rs
0.00% <ø> (-88.89%)
:arrow_down:

bin/reth/src/lib.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

crates/rlp/src/lib.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 245 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Wrong week number.

Description of the Issue and Steps to Reproduce:
console.log(moment('2017-01-01').startOf('week').format('W/YYYY'));

The expected output is either 1/2017 or 52/2016.
The actual output is 52/2017, which is a combination of both.
Maybe the start of week is different when setting it and when calculating the week number?
I'm running moment.js with TypeScript in an Angular 2 application, but I've reproduced this issue without TypeScript too. Using Windows 10 x64 and Chrome.
If you are reporting an issue, please run the following code in the environment you are using and include the output:
console.log( (new Date()).toString())
Tue Dec 20 2016 18:38:30 GMT+0100 (Mitteleuropäische Zeit)
console.log((new Date()).toLocaleString())
12/20/2016, 6:38:30 PM
console.log( (new Date()).getTimezoneOffset())
-60
console.log( navigator.userAgent)
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36
console.log(moment.version)
2.17.1

My bad, the uppercase W is for ISO week, while startOf('week') isn't setting the ISO week. startOf('isoWeek') should have been used.

Also, GGGG is the token for ISO week year -- YYYY is always the calendar year, which may not match the ISO week number from W.


Update outdated instructions

Update inferTraceBugs with infer-explore. See also: https://github.com/facebook/infer/issues/881
Please see CONTRIBUTING.md for how to set up your development environment and run tests.

Thanks!


great_expectations_action build docker image is failing with incompatible Node.js version

I am trying to use great_expectations_action to run a simple checkpoint. I found that the action is failing while building Docker image.
The error is:
Step 1/9 : FROM greatexpectations/great_expectations:python-3.7-buster-ge-0.12.0
---> e5c5ee9ede63
Step 2/9 : RUN apt-get update && apt-get install curl nodejs -y
---> Using cache
---> ecb9bf2e6646
Step 3/9 : RUN curl -L https://npmjs.org/install.sh | bash
---> Running in c749f0012987
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100  3755  100  3755    0     0  17224      0 --:--:-- --:--:-- --:--:-- 17224
**fetching: https://registry.npmjs.org/npm/-/npm-8.9.0.tgz
removing existing npm
ERROR: npm is known not to run on Node.js v10.24.0
You'll need to upgrade to a newer Node.js version in order to use this
version of npm. You can find the latest version at https://nodejs.org/
failed!
The command '/bin/sh -c curl -L https://npmjs.org/install.sh | bash' returned a non-zero code: 1
Error: Docker build failed with exit code 1**

I fixed this issue by upgrading Node.js to the latest LTS version.
PR: https://github.com/great-expectations/great_expectations_action/pull/80


Support for escape characters

@pdbaines (wise.io) requested this feature be moved up in priority.
The following escape characters are supported:

\n: newlines
\t: tabs
\r: carriage returns
\b: backspace
\f: form feed
\xYY: a byte represented by hex digits YY
\uYYYY: a unicode literal represented by hex digits YYYY
\0: null character

Null characters are converted to spaces for security reasons.

Awesome! I see tests pass, did you want me to do any additional testing, or is this ready to merge?


DHCPv6: When Router Advertisements is set to managed, there is no default gateway sent

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When a user decided to utilize manual config of DHCPv6 and Router Advertisements, and sets RA to Managed to indicate DHCPv6 usage, router advertisement nor DHCPv6 sends out an router address/default route.
To Reproduce
Steps to reproduce the behavior:

Setup IPv6 with DHCPv6 and Managed RA's
Check that there's no default route being sent
See that you cannot access IPv6 things due to it

Expected behavior
I expected it to send out the router's IPv6 address as the default gateway or better yet it's link-local address.
Describe alternatives you considered
Manually creating the default routes but that's not how it's supposed to work.
Relevant log files
tcpdump of DHCPv6 request:
02:17:36.497020 IP6 (hlim 255, next-header ICMPv6 (58) payload length: 32) fe80::6e4b:90ff:fe2d:a7dd > 2001:14ba:16d1:9605::15a: [icmp6 sum ok] ICMP6, neighbor solicitation, length 32, who has 2001:14ba:16d1:9605::15a
          source link-address option (1), length 8 (1): 6c:4b:90:2d:a7:dd
            0x0000:  6c4b 902d a7dd
`.... :.........nK...-.. ..............Z..i..... ..............Z..lK.-..
02:17:36.497091 IP6 (hlim 255, next-header ICMPv6 (58) payload length: 32) fddf:f7bc:9670:6::bc6 > fe80::6e4b:90ff:fe2d:a7dd: [icmp6 sum ok] ICMP6, neighbor advertisement, length 32, tgt is 2001:14ba:16d1:9605::15a, Flags [solicited, override]
          destination link-address option (2), length 8 (1): 02:11:32:29:a4:d2
            0x0000:  0211 3229 a4d2
`.... :......p..................nK...-......`... ..............Z....2)..
02:17:44.454796 IP6 (flowlabel 0x4259a, hlim 1, next-header UDP (17) payload length: 120) fe80::11:32ff:fe29:a4d2.546 > ff02::1:2.547: [bad udp cksum 0xd41c -> 0x7a84!] dhcp6 confirm (xid=c126ef (client-ID hwaddr/time type 1 time 742049938 02113229a4d2) (option-request DNS-server DNS-search-list Client-FQDN SNTP-servers) (elapsed-time 0) (IA_NA IAID:841589970 T1:0 T2:0 (IA_ADDR 2001:67c:1104:e08d:5488:3105:c35a:96c1 pltime:0 vltime:0) (IA_ADDR 2001:14ba:16d1:9605::1b2 pltime:0 vltime:0)))
`.%..x............2..)...................".#.x....&.........,:....2)...........'...........D2).............. ..|....T.1..Z.............. .......................
02:17:44.456002 IP6 (hlim 64, next-header UDP (17) payload length: 92) fe80::227c:14ff:fea2:7144.547 > fe80::11:32ff:fe29:a4d2.546: [udp sum ok] dhcp6 reply (xid=c126ef (client-ID hwaddr/time type 1 time 742049938 02113229a4d2) (server-ID hwaddr/time type 1 time 749869441 207c14a27144) (status-code NotOnLink))
`....\.@........"|....qD..........2..)...#.".\V...&.........,:....2)..........,... |..qD...(..Some of the addresses are not on link.
02:17:44.478583 IP6 (flowlabel 0x4259a, hlim 1, next-header UDP (17) payload length: 64) fe80::11:32ff:fe29:a4d2.546 > ff02::1:2.547: [bad udp cksum 0xd3e4 -> 0x9ab7!] dhcp6 solicit (xid=13c320 (client-ID hwaddr/time type 1 time 742049938 02113229a4d2) (option-request DNS-server DNS-search-list Client-FQDN SNTP-servers) (elapsed-time 0) (IA_NA IAID:841589970 T1:3600 T2:5400))
`.%<EMAIL_ADDRESS>........,:....2)...........'............2)..........
02:17:44.479500 IP6 (hlim 64, next-header UDP (17) payload length: 127) fe80::227c:14ff:fea2:7144.547 > fe80::11:32ff:fe29:a4d2.546: [udp sum ok] dhcp6 advertise (xid=13c320 (IA_NA IAID:841589970 T1:0 T2:0 (IA_ADDR 2001:14ba:16d1:9605::1b2 pltime:4500 vltime:7200)) (client-ID hwaddr/time type 1 time 742049938 02113229a4d2) (server-ID hwaddr/time type 1 time 749869441 207c14a27144) (DNS-server 2001:14ba:16d1:9605:227c:14ff:fea2:7144) (DNS-search-list skylab.fi.))
`......@........"|....qD..........2..)...#."...?... ...(2).............. ...................... ........,:....2)..........,... |..qD.... ......."|....qD.....skylab.fi.
02:17:45.550472 IP6 (flowlabel 0x4259a, hlim 1, next-header UDP (17) payload length: 110) fe80::11:32ff:fe29:a4d2.546 > ff02::1:2.547: [bad udp cksum 0xd412 -> 0x2a47!] dhcp6 request (xid=f626c1 (client-ID hwaddr/time type 1 time 742049938 02113229a4d2) (server-ID hwaddr/time type 1 time 749869441 207c14a27144) (option-request DNS-server DNS-search-list Client-FQDN SNTP-servers) (elapsed-time 0) (IA_NA IAID:841589970 T1:3600 T2:5400 (IA_ADDR 2001:14ba:16d1:9605::1b2 pltime:7200 vltime:7500)))
`.%..n............2..)...................".#.n....&.........,:....2)..........,... |..qD.........'...........(2).............. .................. ...L
02:17:45.551528 IP6 (hlim 64, next-header UDP (17) payload length: 127) fe80::227c:14ff:fea2:7144.547 > fe80::11:32ff:fe29:a4d2.546: [udp sum ok] dhcp6 reply (xid=f626c1 (IA_NA IAID:841589970 T1:0 T2:0 (IA_ADDR 2001:14ba:16d1:9605::1b2 pltime:3794 vltime:6494)) (client-ID hwaddr/time type 1 time 742049938 02113229a4d2) (server-ID hwaddr/time type 1 time 749869441 207c14a27144) (DNS-server 2001:14ba:16d1:9605:227c:14ff:fea2:7144) (DNS-search-list skylab.fi.))
`......@........"|....qD..........2..)...#."...@..&....(2).............. ......................^........,:....2)..........,... |..qD.... ......."|....qD.....skylab.fi.

Environment
OPNsense 23.7.5 (amd64, OpenSSL).
Intel® Atom C3758 (8C/8T)
Network Intel® X533

Are we trying to fix a client here? On OPNsense for example dhcp6c doesn't know about a router either and requires the router to be communicated over router solicitation instead.
Cheers,
Franco

To be honest I'm not sure about this specific case, but the lack of bug reports regarding this has me wondering if expectations are wrong. Perhaps @maurice-w knows more in this case.
I don't mind it being a bug to fix, but the triage question is which setting is missing from radvd.conf if there is a configuration mistake.
On a quick google search I found this (German) page: https://www.elektronik-kompendium.de/sites/net/1902141.htm
It says: "DHCPv6 hat noch einen weiteren Makel, weshalb Router Advertisements unverzichtbar sind.   "DHCPv6 Route Options" würde es erlauben, DHCPv6 ohne Router Advertisements zu betreiben. Allerdings ist es fraglich, ob das jemals so zum Einsatz kommen wird.
Deshalb gilt, dass jede IPv6-Konfiguration mit DHCPv6 auch immer parallel mit Router Advertisements erfolgen muss."
Google translate: "DHCPv6 has another flaw, which is why router advertisements are essential. The original DHCPv6 specification did not provide for the configuration of a default gateway. There is only the suggestion “DHCPv6 Route Options”, which allows the address of the default gateway to be configured via DHCPv6, as is usual with DHCPv4. “DHCPv6 Route Options” would allow DHCPv6 to be operated without router advertisements. However, it is questionable whether this will ever be used in this way.
Therefore, every IPv6 configuration with DHCPv6 must always be carried out in parallel with router advertisements."
Cheers,
Franco

PS: I've always used assisted mode and it does what you want.

PS: I've always used assisted mode and it does what you want in terms of giving out routes via RA.

Yeah, but SLAAC is not what I want. :)

So you are using a static IPv6 WAN and LAN configuration?

No. I'm using DHCPv6-PD from WAN, and track6 on LAN

Hmm, okay maybe I had misunderstood the usefulness of that flag with changing prefixes but mine doesn't change every 24 hours or so at least and instead it's quite stable delegated prefix.
I think I should be getting an /64 route for the whole IPv6 range on my LAN, but I'm not and as a result of that, the gateway address is also unreachable?

The gateway address will be a link-local as per RA requirement.

It should be but it doesn't appear to be the case, as it will advertise the router's GLOBAL address instead and not insert it as it doesn't have a route for the /64 it's part of.

IPv6 default routes are advertised by sending Router Advertisements with a Router Lifetime > 0. The router address to be used by the hosts is the link-local source address of the RAs. That's all there is to it. Advertising (default) routes via DHCPv6 is not a thing in the real world.
If you could show that OPNsense doesn't send such RAs under certain circumstances, we would have a case to look into. You might want to perform a packet capture. Otherwise, your issue is somewhere else.

I have an empty house today so I changed from assisted to managed and macOS and iOS devices still work as expected. I'm also inclined to say this is a client issue.
Cheers,
Franco

I have an empty house today so I changed from assisted to managed and macOS and iOS devices still work as expected. I'm also inclined to say this is a client issue.
Cheers,
Franco

Seems to be the case that for whatever reason Debian 12 will just decide to have an weird client behaviour when Ubuntu 22.04 does get it right.

Close then? :)

P.S Mac environment is not the best candidate for testing these as 99% of the time it works there but doesn't in an Android / Linux environment.

BSD derivates is always a good sanity check IMO.

@samip5 Android doesn't support DHCPv6 at all and many systems don't support it out of the box. A vanilla FreeBSD installation e.g. only supports SLAAC.
That's why "Managed" isn't recommended for general purpose networks, but should work of course if all hosts support it and are configured correctly.

@samip5 Android doesn't support DHCPv6 at all and many systems don't support it out of the box. A vanilla FreeBSD installation e.g. only supports SLAAC.
That's why "Managed" isn't recommended for general purpose networks, but should work of course if all hosts support it and are configured correctly.

Besides the point, as I had thought Debian and Ubuntu both would behave normally but that wasn't the case. Kubernetes vlan w/o SLAAC was the goal.


Stream Error Status<PHONE_NUMBER>

Hi, I meet a stream error, the error code is<PHONE_NUMBER>, can you tell me the meaning of the error code?
Below is log:
streamErrorReportHandler(51): Reproting stream error. Errored time code:15725092270720000, status<PHONE_NUMBER>

Hi @Xiaoron
1375731837 corresponds to the status code 0x5200007d .
0x5200007d | STATUS_ACK_ERR_FRAMES_MISSING_FOR_TRACK | Frames missing for a track.
Ref: https://docs.aws.amazon.com/kinesisvideostreams/latest/dg/producer-sdk-errors.html
Could you tell us more about your streaming setup and the sample you are using to ingest media into KVS cloud?


Feature Request - Cache Failure should be Non Fatal

If the cache fails that should be not fatal and only result in degraded performance. Deepstream should try to reconnect to the cache.
Related to: https://github.com/deepstreamIO/deepstream.io/issues/207

How would this work in terms of data consistency? We only consider a record update to be successful when it is written to the cache so this would cause a big bottleneck and risk all the data in process to be lost since it would be in a in-memory queue.
Ideally you would use a cache connector with multiple nodes in a cluster and the cache driver should automatically switch. This is covered I believe in the 'ioredis' driver that redis is now using.

This is covered I believe in the 'ioredis' driver that redis is now using.

Will have to read a bit more about this:

We only consider a record update to be successful when it is written to the cache...

I believe this is a dangerous assumption in general. A record update should only be considered successful once written to storage? What are the implications of that?

How would this work in terms of data consistency?

Not sure...

@yasserf: Given redis. What if items are evicted (due to e.g. LRU) before it's written to the storage? Isn't that the same scenario, from deep streams perspective, as when redis dies?
https://github.com/deepstreamIO/deepstream.io/issues/278

-> write to cache ( resets LRU )
-> if write to cache successful, write to storage
If the write to cache fails, then user gets notified that the write failed by a storage_error, meaning he should revert changes or present some other mechanism to resend updata.

-> write 1 to cache
-> written 1 to cache
-> write 1 to storage
-> write 2...100 to cache
-> evict 1 from cache
-> failed write 1 to storage
Although, such a scenario is probably unlikely

Write to cache fails, client recieves a RECORD_UPDATE_ERROR
Write to storage fail, it currently just logs an error.
Your scenario is perfectly valid!
This does present an issue, I thought the client received a storage write error but by the time the storage is written the handlers to the sender is already cleared and hence just the log. I'll raise this with the core team and discuss how this plans out in robustness.
Will add a new label for robustness issues.


Fix DropdownButtonFormField edge alignment

fixes https://github.com/flutter/flutter/issues/101575
Currently, there is an assertion to avoid the menu being cut off at the edge as a result menu shifted to Offset.zero, which is way off.
So my fix is keeping the menu in the position but overriding y position so that menu doesn't get cut off.

minimal code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: SafeArea(
          child: SingleChildScrollView(
            padding: const EdgeInsets.all(20.0),
            child: Column(
              crossAxisAlignment: CrossAxisAlignment.start,
              children: [
                const SizedBox(height: 20),
                Column(
                    crossAxisAlignment: CrossAxisAlignment.start,
                    children: const [
                      Text("Title",
                          style: TextStyle(
                              fontSize: 20,
                              fontWeight: FontWeight.bold,
                              color: Colors.blue)),
                    ]),
                const SizedBox(height: 20),
                Center(
                  child: Container(
                    padding: const EdgeInsets.only(top: 20),
                    decoration: BoxDecoration(
                        border: Border.all(color: Colors.grey),
                        borderRadius:
                            const BorderRadius.all(Radius.circular(10))),
                    child: Column(
                      children: [
                        Container(
                            width: double.infinity,
                            height: 80,
                            color: Colors.green),
                        Container(
                            width: double.infinity,
                            height: 1000,
                            color: Colors.yellow),
                        tablePaging(),
                      ],
                    ),
                  ),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

Widget tablePaging() {
  double fs = 12;
  Color color = Colors.blueAccent;
  FontWeight fw = FontWeight.bold;

  List<String> list = [for (int i = 1; i <= 10; i++) (i * 10).toString()];
  List<DropdownMenuItem<String>> items = [
    for (String i in list) DropdownMenuItem(child: Text(i), value: i)
  ];

  return Container(
    padding: const EdgeInsets.all(10.0),
    height: 40,
    decoration: const BoxDecoration(
        color: Colors.blue,
        borderRadius: BorderRadius.vertical(bottom: Radius.circular(10))),
    child: Row(
      mainAxisAlignment: MainAxisAlignment.end,
      children: [
        Container(
          width: 100,
          color: Colors.white.withOpacity(0.5),
          child: DropdownButtonFormField<String>(
            value: int.parse(list.first).toString(),
            items: items,
            onChanged: (String? value) {},
            icon: Icon(Icons.arrow_drop_down_outlined, color: color, size: 18),
            style: TextStyle(color: color, fontSize: fs, fontWeight: fw),
            decoration: const InputDecoration(
                isDense: true,
                contentPadding: EdgeInsets.all(0),
                border: InputBorder.none),
          ),
        ),
      ],
    ),
  );
}

Bug
https://user-images.githubusercontent.com/48603081/166472100-87628366-e574-4a2f-9d81-298d28295d01.mov
Fixed
https://user-images.githubusercontent.com/48603081/166472135-348df5bb-693a-4d20-a360-000cfaf84279.mov
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Please address comments

Thanks for the ping, looks like this PR fell under my radar, updating ASAP.

DropdownButton and DropdownButtonFormField has a lot of related issues, I keep running into an issue where going around the core design to fix the problem and where fixing one issue isn't enough to address existing problems.
I'm gonna refactor a large part of its code and address these problems from the top.
Given https://github.com/flutter/flutter/issues/10157 is not really active, I will close this PR for now and address these issues in the best way possible.


👀 Domain Validation With .NET

https://www.youtube.com/watch?v=KgfzM0QWHrQ&t=208s

Exceptions: Add specific domain exception for each validation error.  This is the most explicit, but also the most verbose.

Pros

Defensive
Stack Trace
Easier Debugging

Cons

Performance

Result Object: Wrapper containing Error message, code, success/fail, etc

Pros

Expressiveness
Performance
Self-documenting errors

Cons

Verbose
Need to sprinkle error handling code throughout your application
Messy for Deeply nested code
No stack trace


Language Spec - Types - Typos

Hello,
In the language grammar's section on Types, I've run across a few typos:

The first bullet contains a list of primitive types which does not include anynonnull; however, the list of primitive types given later on includes this type. Based on this, it seems like anynonnull should be added to the list in the first bullet (if this is incorrect, then anynonnull probably should be removed from the list given later on).

Immediately after the first bulleted list, the following sentence appears to be missing a word or phrase:

The set of primitive types includes the types of primitive values a number of abstract types, types that do not uniquely classify any values: function, table, any, and none.

Maybe it should read something like:

The set of primitive types includes the types of primitive values and a number of abstract types, which are types that do not uniquely classify any values ( function, table, any, anynonnull, and none ).

The next paragraph states that "All types that are not members of the closed set of primitive types are collectively referred to as custom types." -- shouldn't this be "not members of the closed set of nullable primitive types"? Verbiage later in this section (e.g. in the discussion of Type equivalence and compatibility implies that nullable primitive types are not custom types).

In the list of Primitive Types, the second sentence in last bullet should be its own bullet item, as it describes a separate type.
.

Sincerely,
Ben

Please ignore (I'm using bot automation to add labels). #please-open

This issue is pending PR #13 which is in review.
#please-open


Support external monitor

iPad allows an external monitor to be used as a separate display.

I have recently implemented external screen support in my app, Present Anything. I can make it happen for UTM app, but I have a few questions. The iOS external screen API (including on iOS 14) is UIKit based, you basically provide a UIWindow to the external screen to display. It is possible to change the resolution of the ext. screen (iOS defaults to the max supported by the device and screen).

Which View or ViewController renders the VM screen?
Is it possible to remove this view from the window and move it to the external UIWindow? (might need to find that out myself)
How is the touchscreen feature implemented? Like, is it the same view that does the VM rendering or another one? (that would be better)

I see a couple of main steps mostly from reading https://www.spice-space.org/multiple-monitors.html which gives a high level view of how SPICE handles multiple monitors.
CSDisplayMetal is the interface between libspice-gtk and the Metal rendering. So here, we have to handle notifying SPICE server that a new display arrived with some dimension. This is also where the pixel framebuffer is copied to a Metal texture. That would have to be extended to handle multiple textures representing each display and/or a mapping of texture to displays if we support display mirroring. We also need some sort of syncing with CSInput which handles the cursor position.
UTMRenderer does the Metal rendering which renders both the display and cursor through delegate calls to CSDisplayMetal and CSInput. A MTKView uses UTMRenderer. VMDisplayMetalController hosts the MTKView. VMDisplayMetalController also does the touch inputs, keyboard handling, etc. So VMDisplayMetalController (or VMDisplayTerminalController) would be good candidates to move to UIWindow.
Without SPICE agent installed, the only thing we can do is mirror or move the display to the external display. For extending the display, the guest has to be aware of the SPICE protocol. I think in the case of tablet/pencil mode cursor, it is fine to not be able to input on the external display.
Also, for new files and features, I would prefer moving to Swift from this point on.

I have added experimental iOS external screen support, with new files written in Swift. I need help with the external VMDisplayMetalViewController to get mirroring and (potentially) multiple displays working. See my pull request.
Additionally, currently the aspect ratio of the VM display becomes distorted when it moves back from external to internal screen.
Here'a a very short video demoing Windows XP on an external screen connected to my iPad Pro. 😄


[BAT] add project test case

Coverage increased (+0.04%) to 56.767% when pulling 62de0bdae26e883285ea253bd7727f6f36294499 on wy65701436:drone-test into 7ee8a7a5045fb9028c1038e8bc712b889948fbd2 on vmware:drone.

Coverage remained the same at 56.722% when pulling 50391b0ea78c795f7f4c26d36d07b6d9212cacb2 on wy65701436:drone-test into 7ee8a7a5045fb9028c1038e8bc712b889948fbd2 on vmware:drone.

Coverage remained the same at 56.722% when pulling 3f14816c88ef5007d403f6b801c0e5962c6cfd8a on wy65701436:drone-test into 7ee8a7a5045fb9028c1038e8bc712b889948fbd2 on vmware:drone.


Cannot call endDrag while not dragging

i guess that ur using uglifyjs-webpack-plugin...

I have the same problem, invariant violation.  Turns out it only happens with the uglify enabled.

Recently ran into this exact same issue while trying to copy the tutorial with some minor modifications, (working on a nested component, using useState instead of the observer file), and I ran into this error as well.
Also running the example given on the project website gives me the same error after dragging/dropping the knight.
As far as I can tell I am running the latest version of every package. Is there some other solution for this?
Repo is here


[cxx-interop] Emit default expressions in symbolic interfaces

This makes sure we print = cxxDefaultArg for parameters that have a default expression on the C++ side.
Note that we can't run the safety heuristic that we use during normal compilation, since we don't know all of the types involved.
rdar://121440191

@swift-ci please smoke test


Text in post and archive pages cannot be marked

This is a regression due to the gesture swiping feature.

ba0d71b330df5ddaef929eef8831382429c7d9b0

It's working for me both on PC and phone