Model Animation

Hello
I think Skeletal animation is not for pixel art or voxel art
Frame Based animation allow designer to keep the model consistant, each voxel still in its voxel space (grid)
Would be nice to add that feature
Thanks

I'd be interested to discuss different animation ideas here. How would frame based animation work? Would you define each frame yourself or would each frame be auto generated?
There are numerous ways for how to deal with animation. Some examples:
(a) https://www.youtube.com/watch?v=b2_cV6XbVBQ (moving individual voxels dynamically)
(b) https://www.youtube.com/watch?v=rF6eWvmi_j0 (building keyframes and cycling through them)
(c) https://www.youtube.com/watch?v=lEI_sWPytp4 (chopping the voxels into parts, e.g. arms, legs, torso and moving those relative to each other)
(d) http://imgur.com/gallery/Yavy5ru (rigged animation)
The way that this currently works in my mind is as following:

We chop the object into multiple parts by using layers
We create a skeleton joining the parts which you can already do in animation mode
We then define keyframes by moving the bones. There will be an option to "keep the same distance" from any adjacent joints as to not distort any voxels.

Why do we use a skeleton? This allows more flexibility than just moving the different parts.  Basically this approach combines (c) and (d).
Let me know what you think!

@simlu

We chop the object into multiple parts by using layers
We create a skeleton joining the parts which you can already do in animation mode
We then define keyframes by moving the bones. There will be an option to "keep the same >distance" from any adjacent joints as to not distort any voxels.

I think this is totally the right idea. Voxelshop already has a great layer system that the flow would leverage. I'm pretty much doing this workflow at the moment:

Chop the object into multiple parts by using layers
export layers to blender as individual meshes
rig attach meshes to skeleton in blender and animate

Now that magica voxel has frame based animation I don't think VoxelShop needs to duplicate that...

I really like C! That would be a great way to animate voxels and to be able to do it in the same program you used to create them would be amazing.

I'm for C too. But if i can build animation inside voxelshop, it will be nice to be able to export them. In this matter I Am for FBX. FBX is widely supported and contain all important data.
Ps. MagicaVoxel has terrible animation system unable of exporting to anything useful... besides, MagicaVoxel has something like B and we re here for C.

Thanks for the reply @Garrom - I'm still working on this project. However some other things have taken priority. I still plan on picking this up, however not sure on a time line at this point.

@simlu  I think it will be better to give high priority to this. Animations are important both in game dev and art. If i think about it, A look awesome too. It will be good to have both C and A and be able switch between them. Theoretically it can work in same system. In C mode whole part is moving but in A mode is whole part moving too, only is rowed to keep voxels in grid.


Codec option to encode Uint8Array like ArrayBuffer

Currently, with the binarybuffer option, ArrayBuffer instances are converted to bin bytes.
>>> msgpack.encode(Uint8Array.of(1,2,3,4).buffer, { codec: msgpack.createCodec({ binarraybuffer: true }) })
Uint8Array [ 196, 4, 1, 2, 3, 4 ]

However, when passing an Uint8Array directly, it gets converted to a map (or to an extension type when turning on the preset):
>>> msgpack.encode(Uint8Array.of(1,2,3,4), { codec: msgpack.createCodec({ binarraybuffer: true }) })
Uint8Array [ 132, 161, 48, 1, 161, 49, 2, 161, 50, 3, … ]

Could you maybe add an option to treat an UInt8Array like an ArrayBuffer when encoding?

Advanage of properly handling Uint8Array as bin type: When you have a Uint8Array which is a view into an ArrayBuffer, then you cannot simply pass u8a.buffer to msgpack, since then the byteOffset and byteLength will be lost. The only way to properly encode the data is to copy it into a new ArrayBuffer like so:
const start = decryptedBytes.byteOffset;
const end = start + decryptedBytes.byteLength;
return decryptedBytes.buffer.slice(start, end);

This copying is unnecessary. It would be better if a Uint8Array (which is a view into a buffer) could be serialized directly.

In addition, the decoding function could hand out a view into the original buffer which will also be much more efficient.


fix bugs for cropping masks in RandomCrop

results['gt_masks'] is a python list that cannot be sliced using bool values.

Thanks for the fix!


my game was problem

I trained part of the level at -10 speed, then I forgot to remove this speed and left the game
now when I try to enter the game with a cheat it takes forever to load, please help
I already reinstalled both the game and the cheat, even geode nothing helped

Go to %localappdata%\GeometryDash\geode\mods\tobyadd.gdh and remove config.json file


Fix for Issue 'English app download buttons on German page #2431'

Fix for Issue 'English app download buttons on German page Issue #2431'
Added german google and apple svg badges and renamed bad translated label 'App mit!' to 'App herunterladen!'

Internal Tracking ID: EXPOSUREAPP-11892

@Crystalskulls Thanks for the PR! Please see comments from @MikeMcC399 above!

@dsarkar I submitted the suggestion from MikeMcC399

@Crystalskulls @MikeMcC399 Thanks!


updated hipchat (4.0.5-574)

Thank you for the contribution. It was merged directly as b2423c2253934ffe94001a2033155562646a629c to keep commit history cleaner. Your contribution is still credited to you.

appcast looks dead, do you see any other sources?

I don't see any other sources for appcast.
Better to clean up the app cast + checkpoint?

Previous conversation regarding the appcast.

Thanks for the info.


Changing README

Added CPU comparison image to README

This PR shouldn't have the collision define changes in it. Just the README change and the two images. The two changes will both be there together after they are separately merged into Development. Thanks :)

This was unintentional. I'll try to clean that up soon.


form action - should be optional

https://www.w3.org/TR/html50/forms.html#attr-fs-action
The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces.

I'm fine with the change with making it optional. However - there is zero need to change all of the URL's. Revert that change and I'll merge.

Why there is no need to change URL's? Are you writing about that ones in FormHelperTest.php?
As for now  form_open('foo/bar') returns action="foo/bar" instead of "http://example.com/index.php/foo/bar" so... if I revert that change travis won't pass anymore.
If you are thinking that foo/bar as the first parameter of form_open($action = 'foo/bar') should produce "http://example.com/index.php/foo/bar" as it was before then we should create solution which allows us to generate just foo/bar as the form's action attribute cuz it is correct value for this attr.

Actually - I missed that you deleted the portion that generated a full URL from a relative url. That's in there as a security precaution, as a way of allowing coding as relative but the SEO, etc benefits from full urls, and more. And that's how it's been for a long time.
Looking closer I can't accept this. It already allows you to not pass a URL. Whether it displays a URL in the generated code really is nothing anyone should worry about, and the method we have had in places for years is safer.


<EMAIL_ADDRESS>fixed shim creation. Closes #11893 and #11894

Closes #11893 and #11894

[x] I have read the Contributing Guide.

/verify

#11964


check indentation of Django templates

If check-templates, we suppress indentation checks for all Django templates due to many legacy files having unusual indentation.
We should do two things:

Only set check_indent to False for existing files with issues.
Clean up the legacy files over time.

I'm going to start to work on the first item for now.

Plan sounds great!

Part 2 of this ticket is still open for any volunteers.  Cleaning up the HTML should be straightforward in some cases, but there may be a few things to clarify in terms of style guidelines, etc.

Updated the labels to make that clear.  If anyone wants to work on this, I'd recommend doing one commit per file so it's easy to merge incrementally.

0b7788be6bb66989082d7df6b707fde1eaa784e3 and d424813687a781504836bb7a78f940001ba27913 are some good examples of doing this.

I assume we no longer need to put the
 tag on the end to cut off trailing whitespace, correct?

We don't for that, but we do need to be careful with things like code blocks (and actually I noticed a small bug in my deactivated refactoring where I lost the . at the end of the sentence)

I tried removing our 500 pages from "bad indentation" list, but I think those templates are actually correct, and the checker just doesn't handle a multi-line  tag block correctly.

It has some limitations.  Can you excerpt the HTML?

Yep it's this:

Well oops. This one's probably our fault. Sorry about that! Updates on
service availability are posted to
@ZulipStatus on Twitter.

I changed the title to reflect that we now do check indentation of Django templates (except the ones in our "exempt" list), and also there are some non-Django templates related to 404 type messages that are raw HTML.

@adnrs96 you should probably claim this issue since you've been working on it.

@zulipbot claim.
Yes kind of started before zulipbot exited so forgot.

@zulipbot i am still working on it.

I merged a few commits today that removed a bunch of things from our lists that still needed work, and adding comments on which ones are ready for further work.  @adnrs96 if you have time, doing the 3 that are ready to update should be pretty fast and would be awesome: https://github.com/zulip/zulip/blob/master/tools/check-templates#L103

Sure, I can update them today with a PR.


Circular DMA does not handle wrap around correctly

Someone brought this up in the matrix room but circular DMA transfers don't handle wrap around properly. Just thought I'd create an issue so other people know about it as well.
In the RX case, wrap around happens when the user doesn't read fast enough and the DMA runs out of space to write data to, causing the DMA to go through all the descriptors and coming back to the start (over and over again, since we don't enable check_owner).
In the TX case, it happens when the user doesn't write fast enough, and the DMA runs out of data to transmit. In practice, the DMA just resends old data over and over again, since we don't enable check_owner.
Once this happens, the user has to drop and restart the transfer, but the current code doesn't do this.
Each peripheral will have its quirks.
This is the code that needs updating on the RX side.
https://github.com/esp-rs/esp-hal/blob/61bb24016651425e1535e71860973fb0097605eb/esp-hal/src/dma/mod.rs#L1046-L1065
There are a couple of ways to fix this, using the check_owner bit, using the IN_DSCR_EMPTY interrupt, or better bookkeeping.
I'm not sure which way is right, and it's likely the answer will depend on the peripheral (and use case) in question.

cc @Noxime


Build for Solr 8.1?

Hi, I tried to install this plug-in on Solr 8.1 but was unable to get it to run.  Do you have advice for how to build/use this plug-in on Solr 8.1?   Thanks!

Nevermind, I found this JIRA issue which does a nice job of chronicling the integration of SKG into Solr proper:  https://issues.apache.org/jira/browse/SOLR-9480


Added safety measures

Currently, simulationPeriodic() doesn't check if users are calling it on the real robot, which can lead to it being accidentally ran on the real robot. This PR prevents it from being run on the real robot(triggering a wpilib alert if so).

Thanks, and nice work!
I've moved it to getInstance() so that the instance is not even created.


Finish internationalization and translate mod into German

This PR (hopefully) completes the internationalization by cleaning up the strings (spelling, grammar fixes), making the strings more suitable for translation, collecting the strings which are not in S already and updating template.txt.
Also, German translation is added.
As a bonus, award descriptions have now automatic line breaks so translators don't have to worry too much about too long translations anymore.
Oh, and #18 should be decided sooner or later to stop confusing translators. I don't really care which word you choose, just that it's consistent.

Rebased and merged


PHP 8.0 not supported despite composer file

The composer.json file says it supports php ^8.0 but if you run composer using version 8.0 if fails with:
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Your lock file does not contain a compatible set of packages. Please run composer update.
Problem 1
- symfony/console is locked to version v6.1.5 and an update of this package was not requested.
- symfony/console v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 2
- symfony/css-selector is locked to version v6.1.3 and an update of this package was not requested.
- symfony/css-selector v6.1.3 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 3
- symfony/deprecation-contracts is locked to version v3.1.1 and an update of this package was not requested.
- symfony/deprecation-contracts v3.1.1 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 4
- symfony/error-handler is locked to version v6.1.3 and an update of this package was not requested.
- symfony/error-handler v6.1.3 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 5
- symfony/event-dispatcher is locked to version v6.1.0 and an update of this package was not requested.
- symfony/event-dispatcher v6.1.0 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 6
- symfony/event-dispatcher-contracts is locked to version v3.1.1 and an update of this package was not requested.
- symfony/event-dispatcher-contracts v3.1.1 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 7
- symfony/finder is locked to version v6.1.3 and an update of this package was not requested.
- symfony/finder v6.1.3 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 8
- symfony/http-foundation is locked to version v6.1.5 and an update of this package was not requested.
- symfony/http-foundation v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 9
- symfony/http-kernel is locked to version v6.1.5 and an update of this package was not requested.
- symfony/http-kernel v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 10
- symfony/mailer is locked to version v6.1.5 and an update of this package was not requested.
- symfony/mailer v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 11
- symfony/mime is locked to version v6.1.5 and an update of this package was not requested.
- symfony/mime v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 12
- symfony/process is locked to version v6.1.3 and an update of this package was not requested.
- symfony/process v6.1.3 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 13
- symfony/routing is locked to version v6.1.5 and an update of this package was not requested.
- symfony/routing v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 14
- symfony/service-contracts is locked to version v3.1.1 and an update of this package was not requested.
- symfony/service-contracts v3.1.1 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 15
- symfony/string is locked to version v6.1.5 and an update of this package was not requested.
- symfony/string v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 16
- symfony/translation is locked to version v6.1.4 and an update of this package was not requested.
- symfony/translation v6.1.4 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 17
- symfony/translation-contracts is locked to version v3.1.1 and an update of this package was not requested.
- symfony/translation-contracts v3.1.1 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 18
- symfony/uid is locked to version v6.1.5 and an update of this package was not requested.
- symfony/uid v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 19
- symfony/var-dumper is locked to version v6.1.5 and an update of this package was not requested.
- symfony/var-dumper v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
Problem 20
- symfony/http-foundation v6.1.5 requires php >=8.1 -> your php version (8.0.22) does not satisfy that requirement.
- spatie/flare-client-php 1.3.0 requires symfony/http-foundation ^5.0|^6.0 -> satisfiable by symfony/http-foundation[v6.1.5].
- spatie/flare-client-php is locked to version 1.3.0 and an update of this package was not requested.

I removed the lock file and did a composer install running on php 8.0 and that seemed to allow the packages to install without a problem. If the intention is for people just to be able to run composer install, maybe it would help to specify that the current lock file requires php 8.1. I have to used php 8 so that's not an option for me without additional steps.

If you check the master branch, there is no composer.lock file present in it!


how to update to the newest version

Gitea version (or commit ref):
Git version:1.8.3
Operating system:ubuntu18.04
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
my gitea is deployed by docker, and i can't find a way to upgrade to the newest version.
no docs about upgrade can find from docker page or from site https://docs.gitea.io/zh-cn/
...

Try the english docs, as our documentation isn't very up-to-date in other languages. :slightly_frowning_face:


tests: radomized order

What does this PR do?
random test execution to prevent accidental test depenency

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Pytorch
FAILED core/test_metric_result_integration.py::test_metric_result_respects_dtype[floating_dtype0] - Failed: DID NOT WARN. No warnings of type (<class 'UserWarning'>,) were emitted.
The list of emitted warnings is: [].

Fabric
FAILED loggers/test_csv.py::test_file_logger_no_name[] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pytest-of-runner/pytest-0/test_file_logger_no_name__0/version_0'
FAILED loggers/test_csv.py::test_file_logger_log_hyperparams - Failed: DID NOT RAISE <class 'NotImplementedError'>
FAILED loggers/test_csv.py::test_file_logger_log_metrics[10] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pytest-of-runner/pytest-0/test_file_logger_log_metrics_10/lightning_logs/version_0/metrics.csv'
FAILED loggers/test_csv.py::test_file_logger_named_version - AssertionError: assert [] == ['2020-02-05-162402']
  Right contains one more item: '2020-02-05-162402'
  Full diff:
  - ['2020-02-05-162402']
  + []
FAILED loggers/test_csv.py::test_flush_n_steps - AssertionError: Expected 'mock' to have been called once. Called 0 times.
FAILED loggers/test_csv.py::test_file_logger_no_name[None] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pytest-of-runner/pytest-0/test_file_logger_no_name_None_0/version_0'
FAILED loggers/test_csv.py::test_file_logger_log_metrics[None] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pytest-of-runner/pytest-0/test_file_logger_log_metrics_N0/lightning_logs/version_0/metrics.csv'
FAILED test_wrappers.py::test_fabric_module_method_lookup - Failed: DID NOT WARN. No warnings of type (<class 'UserWarning'>,) were emitted.
The list of emitted warnings is: [].

App
FAILED tests_app/utilities/test_network.py::test_lightning_client_retry_enabled - Failed: Timeout >300.0s
FAILED tests_app/utilities/test_logs_socket_api.py::test_cluster_logs_socket_api - Failed: Timeout >300.0s
FAILED tests_app/core/test_lightning_api.py::test_app_state_api - Failed: Timeout >300.0s
FAILED tests_app/core/test_lightning_api.py::test_app_state_api_with_flows - Failed: Timeout >300.0s

Signing now to @awaelchli and @ethanwharris if they have validated the remaining failing tests, but no pressure :rabbit:

seems Fabric is solved, just App holds


ubuntu-latest no postgresql-server-dev-13

Description
The ubuntu-latest runner has recently begun failing to find postgresql-server-dev-13 via apt-get (see this step).
The ubuntu-latest runner is documented to provide PostgreSQL 13.2 from the PGDG Apt repo (see this step and the associated doc).
The runner does indeed report that PostgreSQL 13.2 (Ubuntu 13.2-1.pgdg20.04+1) is the server version installed (see this step).
That server version should have come from the PGDG Apt repo and that repository does indeed contain the postgresql-server-dev-13 package (see its Packages index).
Any idea why apt-get is reporting failure to find the package? Only my recent runs have shown this problem; earlier runs (from, e.g., March 28) were successful, same ubuntu-latest runner spec, same PostgreSQL 13.2 version (but an earlier image version).
I notice in the failing job that apt-get update does not report fetching the PGDG repo metadata. Has that repo somehow been lost from the runner configuration, even though the installed PostgreSQL version is from it?
(related ticket opened with GitHub Actions support)
Area for Triage:

Databases
Packages
Question, Bug, or Feature?:

Bug
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[x] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Image version

Environment: ubuntu-20.04
Version: 20210510.0
Expected behavior
apt-get should successfully install postgresql-server-dev-13 from the same repo that the already installed PostgreSQL 13 server came from.
Actual behavior
apt-get reports E: Unable to locate package postgresql-server-dev-13
Repro steps
A description with steps to reproduce the issue. If your have a public example or repo to share,
please provide the link.
Run the ubuntu-latest/amd64 CI actions from this branch.

Hello @jcflack,
In order to keep our images safe from possible untrusted and harmful packages, we made a decision to remove all repositories except ubuntu default. In order to add PostgreSQL repository back please follow the steps below:
echo "deb $REPO_URL `lsb_release -cs`-pgdg main" | tee /etc/apt/sources.list.d/pgdg.list
apt update

It should help to resolve the issue. Could you please try to apply this solution in your workflow?
We are looking forward to your reply.

@jcflack I'm going to close the issue.
In case of any questions, feel free to contact us.

For anyone else stumbling upon this issue, I was able to install the packages I needed from postgre repository by doing this
      - name: psycopg2 prerequisites
        shell: bash
        run: |
          curl https://www.postgresql.org/media/keys/ACCC4CF8.asc | sudo apt-key add -
          echo "deb http://apt.postgresql.org/pub/repos/apt `lsb_release -cs`-pgdg main" | tee /etc/apt/sources.list.d/pgdg.list
          sudo apt update
          sudo apt install libpq-dev cmake -y

It took me a long time to get back to this, but Darleev's suggestion worked for me, and I did not need the additional step of fetching the key first.
That seems ok if it means the key is already in the image. I hope it does not mean the apt-get was done without signature checking. As I did not say --allow-unauthenticated, I should be confident it would simply fail without the key, right?


Custom format of validation error response

Is it possible to change default format of validation error?
E.g. I have this validation setup:
module.exports.login = vandium.createInstance({
  validation: {
    schema: {
      body: vandium.types.object().keys({
        email: vandium.types.email().required()
          .error(new UserError('Parameter email is required and should have ' +
          'format of email address')),
        password: vandium.types.string().required()
          .error(new UserError('Parameter password is required')),
      }),
    },
  },
})

And when I break it, API Gateway returns something like this
{
    "errorMessage": "validation error: Parameter email is required and should have format of email address",
    "errorType": "Error",
    "stackTrace": []
}

But I would like to change it, e.g. remove stackTrace completely.
In addition I am trying to adapt lambda-proxy integration using Serverless and API Gateway fails completely with internal server error and saying Execution failed due to configuration error: Malformed Lambda proxy response in the log.

Few suggestions for API Gateway:

Use the Vandium configuration parameter stringifyErrors: true. This will force all exceptions to be converted into a string and stored in the "errorMessage" field. In addition, you can return more fields from the exceptions (and you'll have to set stripErrors: false to see them).

Use a response template to transform the message:

#set ($errorMessageObj = $util.parseJson($input.path('$.errorMessage')))
#set ($bodyObj = $util.parseJson($input.body))

{
#if( $errorMessageObj.errorMessage != "" )
    "type" : "$errorMessageObj.errorType",
    "message" : "$errorMessageObj.errorMessage",
#else
    "type": "error",
    "message": "$bodyObj.errorMessage"
#end
}

This mapping will decode the "stringified" exception from the errorMessage field OR work with the existing message if a timeout/process exit case.

Thanks for your suggestions but I'm not sure I can use them. We have the integration request of API Gateway set as lambda proxy with "Lambda Proxy integration". Which means that I cannot edit integration response and the result of lambda function must have this format:
{
    "statusCode": httpStatusCode,
    "headers": { "headerName": "headerValue", ... },
    "body": "..."
}

(see http://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-set-up-simple-proxy.html#api-gateway-simple-proxy-for-lambda-output-format)
Unfortunately I can't change this APIG settings because it would break other things in our app. Do you support it or do you plan to support it anytime soon?

We need to add this functionality - I will add this to the 3.3 branch (hope to release sometime next week)

Would be interested in hearing how you think it should look from the user's viewpoint.

That's great, thank you. Well, there are two steps. First is simple and needs just one configuration parameter saying that Vandium should encapsulate current output with the required envelope (i.e. it would look like { "statusCode": x, "body": JSON.stringify({ "errorMessage": "validation error: ...", "errorType": "Error", "stackTrace": [] }), "headers": {} }. Plus it would be nice to be able setup headers.
Second step is customization of the body. Our API formats errors like { "error": "message", "errorType": "validation", "requestId": "aws-request-id" } and it is not consistent nor nice that Vandium formats them otherwise. But so far I'm not sure how the configuration should look like, I'm afraid that API Gateway won't help us like with response templates, right?

Well, maybe it could be simple too, what about something like:
{
  validation: {
    schema: {...},
    errorFormat: (msg) {
      return JSON.stringify({ error: msg, errorType: "validation" });
    },
  }
}

Or the callback could return object which would be stringified by Vandium, I'm not sure what's better.
Probably I would not be able to put there aws request id anyway but it would be still much better then now. ;o)

I've added support for the lambda proxy in the 3.x branch - several ways to use it (using your login example):
simple proxy with no headers
module.exports.login = vandium.createInstance({
  validation: {

     // as normal
  },

  lambdaProxy: true
});

simple proxy with custom headers
module.exports.login = vandium.createInstance({
  validation: {

     // as normal
  },

  lambdaProxy: {

    headers: {
      "x-my-header": "whatever"
    }
  }
});

Custom implementation
class MyLambdaProxy extends vandium.LambdaProxy {

  constructor() {

    super();
  }

  onError( event, context, error ) {

     let proxyObject = {};

     proxyObject.statusCode = error.status || error.statusCode || 500;
     proxyObject.headers = { };

     let body = {

       type: error.name,
       message: error.message,
       bad: true
    };

    proxyObject.body = JSON.stringify( body );
    return proxyObject;
  }
}

module.exports.login = vandium.createInstance({
  validation: {

     // as normal
  },

  lambdaProxy: new MyLambdaProxy()
});

Give it a try (npm install vandium-io/vandium-node) and let me know if it works for you.

It's looking great, thanks! I hope to get to it soon

Will also be adding the ability to simplify validation when lambda proxy support is enabled.
Validation will look like:
{
  validation: {
    schema: {

      GET: {
        // validation for GET requests
      },
      POST: {
        // validation for POST request
      }
    }
  },
  lambdaProxy: true
}

Resolved in 3.3.0


Update device_selector.hpp

Existing Sample Changes
Description
remove cl namespace
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes Issue#
make code compile
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Implement fixes for ONSAM Jiras

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Command Line
[X] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Delete this line and everything below if this is not a PR for a new code sample
Delete this line and all above it if this PR is for a new code sample
Adding a New Sample(s)
Description
Please include a description of the sample
Checklist
Administrative

[ ] Review sample design with the appropriate Domain Expert:
[ ] If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager

Code Development

[ ] Implement coding guidelines and ensure code quality. see wiki for details
[ ] Adhere to readme template
[ ] Enforce format via clang-format config file
[ ] Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
[ ] Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
[ ] Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

[ ] OSPDT Approval (see Project Manager for assistance)
[ ] Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
[ ] Bandit Scans (Python only)
[ ] Virus scan

Review

[ ] Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
[ ] Review readme with Tom Lenth(@tomlenth) and/or Project Manager
[ ] Tested using Dev Cloud when applicable

@guoci Can you please submit to the development branch?

@jimmytwei done

@praveenkk123 Can you take a look at this and approve? It LGTM


NSLocationWhenInUseUsageDescription ios

Is this a bug report?
no, it is incomplete important info documentation.
<key>NSLocationWhenInUseUsageDescription</key> 	<string></string>
if description is left empty Apple review will reject.
you must fill a description

This is still an issue, can this be re-opened please @alvelig

@Billy- @ma96o @DanGDroid what would be the solution for this issue? Can anyone make a PR for it?


External Link icon is prefixed instead of suffixed when using a PVA bot

Is it an issue related to Adaptive Cards?

[ ] Yes, this is an Adaptive Card issue but it is specific to Web Chat.

Do you have any screenshots?

What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
NPM
Which hosting environment does this issue primarily affect?
SharePoint
Which browsers and platforms do the issue happened?
Browser: Edge (latest)
Which area does this issue affect?
Chat history
Is this an accessibility issue?

[X] Yes, this is an accessibility issue.

Please describe the bug
External Link icon is prefixed instead of suffixed when using PVA
Do you see any errors in console log?
No response
How to reproduce the issue?

Host a PVA bot on a webpage (I hosted it on SharePoint using the SP Framework)
Trigger a response from the bot that contains links
Observe that the link has a prefixed external link icon

What is the expected and actual behavior?
Expected: External link icon should be suffixed
Actual: External link icon is prefixed
Adaptive Card JSON
No response
Additional context
No response

We have some tests that verify the "open in new window" icon is appended to the link. Such as:

/__tests__/html/markdown.rel.html

The image snapshot of the test is here, markdown-rel-js-markdown-must-have-rel-noopener-noreferrer-1-snap.png

This is the DOM tree generated by the test and the icon is appended correctly.

We are not seeing anything wrong here.
On your side, did you spot any CSS styles that may interfere the position of the icon?

@compulim , yes, I've figured out when this happens.
If you bold the text then the link icon appears before the text.
Also if you don't add the protocol i.e. https:// then the link icon doesn't show up.

@compulim can you clarify whether this is an issue in the product code or the application?

This is most likely an issue with markdown-it

We are using the a custom markdown-it to postfix the link text with the icon. However, it does not look like we have any logic to handle styled text.
https://github.com/microsoft/BotFramework-WebChat/blob/359ce8ec7863e4bb5dadb397be4274e11b5fa9bd/packages/bundle/src/renderMarkdown.ts#L128

Closing this one due to inactivity, if further problems are encountered, please submit a new issue


Assignment pattern copied to param without necessary info

Let's say we have a logic param which we initialize with a struct which is initialized by an assignment pattern. Example:
module Mod1 #(parameter logic [31:0] PARAM = '0) (output logic [31:0] x);
   assign x = PARAM;
endmodule

module Mod2;
   typedef struct packed { logic[31:0] x; } Struct;
   parameter Struct STRUCT = '{ x: '0 };
   logic[31:0] x;
   Mod1 #(.PARAM(STRUCT)) mod1(.x(x));
endmodule

UHDM generated by Surelog:
 |uhdmtopModules:
 \_module: work@Mod2 (work@Mod2) bug.sv:5:
   ...
   |vpiModule:
    \_module: work@Mod1 <EMAIL_ADDRESS>bug.sv:9: , parent:work@Mod2
     ...
     |vpiParamAssign:
     \_param_assign: , line:1<EMAIL_ADDRESS>       |vpiRhs:
       \_operation: , line:9
         |vpiOpType:75
         |vpiOperand:
         \_tagged_pattern:
           |vpiTypespec:
           \_string_typespec: (x), line:7
             |vpiName:x
           |vpiPattern:
           \_constant: , line:7
             |vpiConstType:3
             |vpiDecompile:'b0
             |BIN:0
       |vpiLhs:
       \_parameter: (work@Mod2.mod1.PARAM), line:1<EMAIL_ADDRESS>         |vpiName:PARAM
<EMAIL_ADDRESS>         |BIN:0
         |vpiTypespec:
         \_logic_typespec: (PARAM), line:1<EMAIL_ADDRESS>           ...

The assignment pattern { x: '0 } gets assigned directly to PARAM. The problem is, PARAM is of type logic[31:0], so it doesn't contain member x. From what I see, there isn't a way to figure out what typespec is being 'used' by the pattern (there's no link between PARAM and STRUCT anywhere in the UHDM).

We can use the typespec member of expr

Fixed by #1492, check the typespec of the expression


feat: add python realization of ProduceOutput and RecordMetadata

This is a WIP pull request addressing issue #389.
It adds two python representations ProduceOutput and RecordMetadata allowing to retrieve metadata for records sent by the TopicProducer. The implementation tries to mimic the existing rust interface. However, the PyO3-wrapper ProduceOutput places the inner (native) ProduceOutputinto a Cell because its only method mainconsumes self, which can not be realized with a PyO3-wrapper.
This means that a subsequent call to the wait method will find a Defaultversion of the object and result in a ProduceError::GetRecordMetadata(None) (in pure Rust, such a subsequent call is impossible as the underlying ProduceOutput would not exist anymore after the first call).
I would like to hear your suggestions regarding this realization using Cell and if you have some good idea to avoid such a construction.

Added a comment in parent issue about maybe using PyO3 IntoPy trait for this?

I am not sure that it would help here (but I may have a wrong understanding of its working.
Using the IntoPy trait, would let the ProduceOutput appear like a RecordMetadata to the python world, if I understand it correctly.
But this is not really the intended effect, is it? It should be up to the user to decide whether they want to wait for the RecordMetadata or not (in particular, if it is a blocking call). So the call to wait should be explicit. And in order to be able to execute such a call, it needs some object to be bound to (the ProduceOutput). This in turn means that a ProduceOutput object needs to be available in python land.
But my understanding may be wrong.

Another option instead of using Cell<ProduceOutput> for the inner part and produce errors on subsequent calls would be to use an Option and return None for subsequent calls to wait.

Using an option for the inner wrap would be a way to avoid the Cell and I think read a little clearer in the intent.

I updated the async send variants and added an asynchronous async_wait. I also added tests for waiting on RecordMetadata both for sync and async variants. I also added docstrings.
If the CI/CD goes through, the PR is ready from my perspective.
I do have a failing test, though it is not mine and I am not sure if it is related: test_fluvio_python.TestFluvioAdminTopic.test_admin_paritions. Also, there is a typo in the test's name: I suppose that is shall be called test_admin_partitions.

I think this looks good to me code wise.  The CI all passed, so is the failing test on your system?

It is a test failing locally on my installation, yes. To be honest, I don't quite understand, what that test is supposed to do. It connects to the cluster, does nothing and then expects there to be are topics available (where should they come from?).
I would actually assume there to be no topics, so instead of assertNotEqual I would expect a assertEqual. And I wonder, why the test does not fail in the CI/CD pipeline.
I could misunderstand the test, though. I am certainly not familiar with the whole module.

The commits are now squashed into one.

I've run the tests on my system and they all pass.  The test could fail if you don't have a currently operable fluvio profile that connects to a running cluster.  The CI sets that up separately (and I have one by default too ).  The simplest way is to make sure a local fluvio cluster is started first fluvio cluster start.
Merging the PR though, and thanks for the work and attention!

Thank you for the merge.
I do have a running cluster. I believe that the test fails if the original state of the fluvio cluster does not contain any topics (i.e. it is an empty cluster).
Could you check, if your test also passes when you start the tests on a cluster with no topics existing in the beginning?

Yes it seems to need a topic. and fails withoug.  Seems like a temporary topic should be created as part of the test (as happens in many other tests already)

Keeping an eye on maybe needing to revert this temporarily. Looks like CI runs are sometimes taking a long time as well as build errors that when integrated w/ a dev build PR (https://github.com/infinyon/fluvio-client-python/pull/396)
https://github.com/infinyon/fluvio-client-python/actions/runs/8361426988/job/22890298839


Medium severity vuln found in<EMAIL_ADDRESS>introduced via<EMAIL_ADDRESS>

🐛 Bug Report
? Medium severity vuln found in<EMAIL_ADDRESS>introduced via<EMAIL_ADDRESS>- desc: Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:mem:20180117
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>
More details here.
Expected behavior
No vulnerabilities in Jest.
Link to repl or repo (highly encouraged)
Screenshot, Vulnerability details.

Fixed on master and in v24-alphas. Will be fixed in v24.


Europe 25 meter DEM

http://www.eea.europa.eu/data-and-maps/data/eu-dem#tab-metadata

License: CC-BY

Geographic coverage:

Albania Austria Belgium Bosnia and Herzegovina Bulgaria Croatia Cyprus Czechia Denmark Estonia Finland France Germany Greece Hungary Iceland Ireland Italy Kosovo (UNSCR 1244/99) Latvia Liechtenstein Lithuania Luxembourg Macedonia (FYR) Malta Montenegro Netherlands Norway Poland Portugal Romania Serbia Slovakia Slovenia Spain Sweden Switzerland United Kingdom

Format: Looks similar to SRTM

A mirror of these files is in s3://mapzen-eudem/
Transcoded versions are in s3://mapzen-dynamic-tiler-test/EU-DEM/0/

Listing files
curl -s https://www.eea.europa.eu/data-and-maps/data/eu-dem \
  | grep -o '<a href=['"'"'"][^"'"'"']*['"'"'"]' \
  | sed -e 's/^ eudem_listing.txt

Mirroring files to openterrain S3
cat eudem_listing.txt \
    | xargs \
      -I {} \
      -P 24 \
      -n 1 \
      sh -c 'export f="{}"; export s3="s3://elevation-sources-prod/eudem/`basename $f`"; curl -s $f | AWS_DEFAULT_PROFILE=openterrain aws s3 cp - $s3; echo $s3' \
    tee eudem_s3_objects.txt

… This seems to fail because the download site isn't responding. I'll come back in a bit. …

They're looking into the down-ness:
https://twitter.com/EUEnvironment/status/872430176298303488

Looks to be back up, so I'm doing the mirroring step now.

Transcoding started:
aws s3 ls s3://elevation-sources-prod/eudem/ --recursive | \
grep tif$ | awk '{print $4}' | \
while read filename; do
    bn=$(basename ${filename%.*})
    make submit-job job=aws/transcode-job.json.hbs input=s3://elevation-sources-prod/${filename} output=s3://elevation-sources-transcoded/$(dirname $filename)/${bn} name=${bn:0:50}
done

Some of these jobs are failing because they run out of memory. These are the failures. I'm cloning the jobs through the Batch console and giving them 3GB of memory:

[x] eudem_dem_5deg_n65e015
[x] eudem_dem_5deg_n60e025
[x] eudem_dem_5deg_n50w005
[x] eudem_dem_5deg_n40e025
[ ] eudem_dem_5deg_n40e000
[ ] eudem_dem_5deg_n35w005
[ ] eudem_dem_5deg_n35e040
[ ] eudem_dem_5deg_n35e035
[ ] eudem_dem_5deg_n35e030


Allow selectPagingItem to be called before viewDidAppear

Previously, selectPagingItem had to be called before viewDidAppear in
order to show the menu items with the correct item selected. This
update fixes this issue.

Hey, @rechsteiner
I think I am having issues with this commit
'unbalanced calls to begin/end appearance transitions'
I have a tabbar controller, one of the tabs contains viewController with segments, after switching tabs I am getting the above error and corrupted views in pager

Dammit. Sorry about that. Are you using FixedPagingViewController or a custom subclass? And are you calling selectPagingItem anywhere? I will try to publish a fix later today.

Yep, I am using 'FixedPagingViewController' and not calling 'selectPagingItem' from anywhere. If you wish, I can try to make a sample, to demonstrate the problem.

No worries, I managed to reproduce it. Looks like EMPageViewController has a bug if you select the same view controller twice, which happens since I select the current view controller in viewDidAppear.

Should be fixed now! Let me know if you still have any issue 🙏

Works great, thank you!

Hey, @rechsteiner
I've found another issue. This time I've embeded calendar example into UITabBarController
Check the video attached
https://dl.dropboxusercontent.com/u/5593170/bug_pager.mov

Ah, I know what going on. When viewDidAppear is called it triggers viewControllerForPagingItem: which actually create a new instance of the view controller, causing my previous fix to fail. We really don't want to create a new instance each time viewDidAppear is called, so this should definitely be fixed. Will have something ready shortly.

@AYastrebov alright, pretty sure it should be fixed now ✌ Sorry about all these silly issues btw. I'll look into adding some UI tests to avoid issues like this in the future.

@rechsteiner It's all good, no worries ;)
The lib is awesome


Add E2E test: [Trigger] Flood extent legend is visible when flood extent layer is active

### Tasks
- [ ] Add E2E automation script

Moved to Dev Ops


Collect and use columns' mayHaveNulls info for RowContainer

Description
Collect and use columns' mayHaveNulls info for RowContainer.
Problem
We found non nulls columns' mayHaveNulls information would be changed from false to true after they are handling by inner join, aggregation and sort. This is because dependent columns of join, key columns of aggregation and all key / dependent columns of sort are considered as containing null values by default in the row container. If the related columns' mayHaveNulls is false, this assumption would cause extractValuesWithNulls is used for data extraction, which triggers unnecessary null buffers allocations and null bits reading.
Proposed solution
Collect mayHaveNulls information from input vectors and store them for each column. If the column's mayHaveNulls is false, extractValuesNoNulls is used to extract the values from the row container.
We observed several queries in our TPCDS runs benefited from this. For example:
Query14b
Before

After

Query47
Before

After

Query65
Before

After

Query72
Before

After

Query95
Before

After

Hello @mbasmanova  and @Yuhta,
Could you please help to check, https://github.com/facebookincubator/velox/pull/10775?
Thanks.

@zhli1142015 Thank you for sharing these findings.

We observed several queries in our TPCDS runs benefited from this. For example:

I see multiple screenshots, but I find it hard to get the big picture of the improvement. Would you update PR description to summarize the performance gains you observed?

Updated, thanks.


Data Races

yarf appears to have several data races, some of which seem to be part of the framework's API.
Note the documentation of http.Serve (Which is called by http.ListenAndServe among others.)(Emphasis mine):

Serve accepts incoming connections on the Listener l, creating a new service goroutine for each. The service goroutines read requests and then call srv.Handler to reply to them.

I created a new test on my fork that can surfaces data races in yarf.ServeHTTP, simulating the way Server behaves by spawning many goroutines to handle many requests. The output of go test -race with this test is at the bottom of this issue. The post on the Go Blog, Intoducing the Go Race Detector may be an insightful read.

The first is a race on the cache itself. The first goroutine is reading from it at the same time as another is writing to it. As a stop-gap it could use a sync.RWMutex to serialize access to it. But since the current cache implementation is quite simplified, it might be better off removed from yarf completely and implemented at a different layer.
The second race is on routeGroup.lastMatch. This could result in one goroutine overwriting lastMatch between another goroutine's write of lastMatch and call of Dispatch, causing the same Route to be dispatched to twice with two or more completely different contexts, and the other routes ignored completely. To fix this, I would put the last match in a new Dispatchee field of Context, and remove it from RouteGroup.
The third race is on a Route's Context field (via embedded RequestContext). This means that two goroutines could call SetContext before either calls Dispatch, resulting in both routes getting the same context. Since this is part of the yarf's API, I doubt this could be fixed without breaking things. One change would be to change ResourceHandler http method handlers to take *Context as an argument instead of being passed underneath in the struct with RequestContext.

This issue doesn't come with a pull request just because applying these changes would alter the API and I'd like your feedback first.
==================
WARNING: DATA RACE
Read by goroutine 39:
  runtime.mapaccess2_faststr()
      C:/sdk/Go/src/runtime/hashmap_fast.go:281 +0x0
  github.com/yarf-framework/yarf.(*yarf).ServeHTTP()
      go/src/github.com/yarf-framework/yarf/yarf.go:83 +0x23a
  github.com/yarf-framework/yarf.TestYarfParallel.func1()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:131 +0xc1

Previous write by goroutine 38:
  runtime.mapassign1()
      C:/sdk/Go/src/runtime/hashmap.go:411 +0x0
  github.com/yarf-framework/yarf.(*yarf).ServeHTTP()
      go/src/github.com/yarf-framework/yarf/yarf.go:98 +0x564
  github.com/yarf-framework/yarf.TestYarfParallel.func1()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:131 +0xc1

Goroutine 39 (running) created at:
  github.com/yarf-framework/yarf.TestYarfParallel()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:133 +0x4f9
  testing.tRunner()
      C:/sdk/Go/src/testing/testing.go:456 +0xe3

Goroutine 38 (finished) created at:
  github.com/yarf-framework/yarf.TestYarfParallel()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:133 +0x4f9
  testing.tRunner()
      C:/sdk/Go/src/testing/testing.go:456 +0xe3
==================
==================
WARNING: DATA RACE
Read by goroutine 40:
  github.com/yarf-framework/yarf.(*routeGroup).Dispatch()
      go/src/github.com/yarf-framework/yarf/router.go:158 +0x60
  github.com/yarf-framework/yarf.(*yarf).dispatch()
      go/src/github.com/yarf-framework/yarf/yarf.go:135 +0x1bc
  github.com/yarf-framework/yarf.(*yarf).ServeHTTP()
      go/src/github.com/yarf-framework/yarf/yarf.go:88 +0x30d
  github.com/yarf-framework/yarf.TestYarfParallel.func1()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:131 +0xc1

Previous write by goroutine 38:
  github.com/yarf-framework/yarf.(*routeGroup).Match()
      go/src/github.com/yarf-framework/yarf/router.go:146 +0x2a5
  github.com/yarf-framework/yarf.(*yarf).ServeHTTP()
      go/src/github.com/yarf-framework/yarf/yarf.go:95 +0x459
  github.com/yarf-framework/yarf.TestYarfParallel.func1()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:131 +0xc1

Goroutine 40 (running) created at:
  github.com/yarf-framework/yarf.TestYarfParallel()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:133 +0x4f9
  testing.tRunner()
      C:/sdk/Go/src/testing/testing.go:456 +0xe3

Goroutine 38 (finished) created at:
  github.com/yarf-framework/yarf.TestYarfParallel()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:133 +0x4f9
  testing.tRunner()
      C:/sdk/Go/src/testing/testing.go:456 +0xe3
==================
==================
WARNING: DATA RACE
Write by goroutine 39:
  github.com/yarf-framework/yarf.(*MockResource).SetContext()
      <autogenerated>:83 +0x64
  github.com/yarf-framework/yarf.(*route).Dispatch()
      go/src/github.com/yarf-framework/yarf/router.go:63 +0x81
  github.com/yarf-framework/yarf.(*routeGroup).Dispatch()
      go/src/github.com/yarf-framework/yarf/router.go:175 +0x2e5
  github.com/yarf-framework/yarf.(*yarf).dispatch()
      go/src/github.com/yarf-framework/yarf/yarf.go:135 +0x1bc
  github.com/yarf-framework/yarf.(*yarf).ServeHTTP()
      go/src/github.com/yarf-framework/yarf/yarf.go:88 +0x30d
  github.com/yarf-framework/yarf.TestYarfParallel.func1()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:131 +0xc1

Previous write by goroutine 38:
  github.com/yarf-framework/yarf.(*MockResource).SetContext()
      <autogenerated>:83 +0x64
  github.com/yarf-framework/yarf.(*route).Dispatch()
      go/src/github.com/yarf-framework/yarf/router.go:63 +0x81
  github.com/yarf-framework/yarf.(*routeGroup).Dispatch()
      go/src/github.com/yarf-framework/yarf/router.go:175 +0x2e5
  github.com/yarf-framework/yarf.(*yarf).dispatch()
      go/src/github.com/yarf-framework/yarf/yarf.go:135 +0x1bc
  github.com/yarf-framework/yarf.(*yarf).ServeHTTP()
      go/src/github.com/yarf-framework/yarf/yarf.go:102 +0x599
  github.com/yarf-framework/yarf.TestYarfParallel.func1()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:132 +0x12c

Goroutine 39 (running) created at:
  github.com/yarf-framework/yarf.TestYarfParallel()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:133 +0x4f9
  testing.tRunner()
      C:/sdk/Go/src/testing/testing.go:456 +0xe3

Goroutine 38 (finished) created at:
  github.com/yarf-framework/yarf.TestYarfParallel()
      go/src/github.com/yarf-framework/yarf/yarf_test.go:133 +0x4f9
  testing.tRunner()
      C:/sdk/Go/src/testing/testing.go:456 +0xe3
==================

Thanks for finding this. It's a big one!

We'll figure out something, as you said, being super simple we can think on another way to handle this, i'd like to keep the route cache as it's a nice performance improver.

I'm already working on a fix for this one based on your proposal. I'll let you know.

The idea of not passing the Context around was to simplify development and it's something i'd like to keep (as is mentioned on the Readme file. But now i see this, i'm not sure that's possible, but let's think about it.

Proposals for the cache layer are welcome.
If you have any idea on how to handle the Context object without having to pass it around methods please send it over. I guess we may implement a custom ResponseWriter and insert the Context there (not sure if that will work though) but also it's a bit weir to have the Context in the Response object.
Lets think about that, this is getting fun!
Thanks again for all your contributions. I hope you like the framework and let me know if you are thinking on using it on some project.

Fixed on https://github.com/yarf-framework/yarf/commit/ddd49168504cdf8be6221dadb4417918ede9d0f4

Implemented the sync.RWMutex as you suggested. Found the implementation very simple and the performance benefits are still there.

Also following your proposal, moved the route group last match to the Context object.

After trying several approaches, I found that the most convenient solution was your proposal to set the Context object as a parameter to all Resource methods. This removed some code overhead about the context (i.e. RequestContext object), and changed the API (as well as the version number).

Check that i did several other commits after this one that fixes some errors and improves some other things along with the update on the docs to match the new API.
Examples are also updated.
I wrote a test for the race conditions you mentioned, a bit different from yours to replicate the behaviour of the http server without using the sync package. The outcome should be the same and i've also checked your test to confirm that both are passing OK.
Thanks again for bringing this up!

Wow, thanks for the quick turn around! I'll think about that alternate
cache implementation.
On Oct 25, 2015 10:33 AM, "Leonel Quinteros"<EMAIL_ADDRESS>wrote:

Closed #12 https://github.com/yarf-framework/yarf/issues/12.
—
Reply to this email directly or view it on GitHub
https://github.com/yarf-framework/yarf/issues/12#event-444881191.


asd work with psd?

i use psd for profile sync and it works well,
but although asd  p output this:
Anything-sync-daemon v5.76 on Arch Linux

 Systemd service is currently active.
 Systemd resync service is currently active.
 Overlayfs v23 is currently active.

Asd will manage the following per /run/asd.conf settings:

 owner/group id:     smallst/1000
 target to manage:   /srv/http/
 sync target:        /srv/http/.-backup_asd
 tmpfs target:       /tmp/asd-smallst/srv/http/
 dir size:           522M
 overlayfs size:     0
 recovery dirs:      none

ls -a /tmp/asd-smallst/srv/http/ shows:
.  ..  -rw

and -rw directory is emtpy.
because overlayfs size is 0, i think asd not run correctly.
does i think too much?

Stop asd
Remove the trailing slash you have in the WHAYTOSYNC array
Post the output of asd p

yes. after remove trailing slash, there are files in /tmp
this is output now.
Anything-sync-daemon v5.76 on Arch Linux

 Systemd service is currently active.
 Systemd resync service is currently active.
 Overlayfs v23 is currently active.

Asd will manage the following per /run/asd.conf settings:

 owner/group id:     smallst/1000
 target to manage:   /srv/http
 sync target:        /srv/.http-backup_asd
 tmpfs target:       /tmp/asd-smallst/srv/http
 dir size:           522M
 overlayfs size:     0
 recovery dirs:      none

Please update to 5.77 (adds a check for this condition).  Does asd now work as expected?

i want to say yes but..
i find localhost in browser get a 404-not found for index.html in /srv/http

Stop psd
Try to browse

Does that work?  I do not believe that /srv/http should be owned by your user... I believe that is root:root, no?

oh, so sorry for .. i chown /srv/http to myuser:http.. i know it is'n recommanded but i do it for convenient..
stop psd works well.
but
even i chown(-R) /srv/http to root:root or root:http , when i ([sudo] systemctl) start asd.service , there is 404-not found.. so sad..

wait.. stop psd? let me try

anyway.. stop asd doesn't help

Sorry, I didn't mean psd, I meant asd.  In other words, stop asd.  Try to browse, does it work?  If it works try disabling the overlayfs mode and start asd.  Does it work?  Trying to figure out where the problem is:

With your http server?
With asd overlayfs + your http server
With asd (normal mode) + your http server

actually  3) asd(normal mode) + http server bring the problem.
without asd i can visit my http server.
i use lighttpd (i think it is in http group?)
➜ smallst@ArchMiniQ /tmp > ps -ef |grep httpd                                                                                [19:12:03]
root      1684     1  0 18:33 ?        00:00:00 /usr/bin/lighttpd-angel -D -f /etc/lighttpd/lighttpd.conf
http      1687  1684  0 18:33 ?        00:00:00 /usr/bin/lighttpd -D -f /etc/lighttpd/lighttpd.conf
smallst  13436  1500  0 19:14 pts/1    00:00:00 /usr/bin/grep httpd

So to summarize, the server works under only 1 condition:

without psd

It does not work with asd under:

normal mode
overlayfs mode

Is this correct?
By contrast, I am using lighttpd with asd (normal mode) just fine :/

seems lighttpd cannot find symbolic link 'http'
it is so strange that i create a soft link in /srv/http/ (root:root , without asd) and server can find the link and follow it. but if i start asd and change my doc-root directory to /srv/, i will find there is no 'http' link anywhere.
i think i cannot solve it by myself. or when i know more about linux permission and httpd behavior.
anyway , thank you for response.

Again, I used the wrong term.  Psd should have nothing to do with it.  More likely, it is something to do with the symlink.

i think the problem is 'http' group has no permission to enter /tmp directory.
but my /tmp 's permission is drwxrwxrwt . can't understand why http has no permission entering /tmp..
i think 't' only control the delete permission, or it also control the 'x' permission?

finally i change asd target directory to /run (just as psd)and everything is well.
is there anything wrong?

Is your /tmp setup in /etc/fstab or else where in a non-standard way or with non-standard settings?

no, i do nothing for tmpfs or /tmp directory (if swap is related and it looks like this:
# /dev/sdb6
UUID=48465fe5-df20-40d8-8195-728903c3e8d5	none      	swap      	defaults  	0 0

i think /tmp is setup by systemd

I am not sure what the problem could be ... I am using lighttpd with asd (not using overlayfs mode) and serving up basic content just fine.  Do you have any special requirements with your server that might fail as a function of the permissions?  Are any logs available that would help pin point the problem?

after one day testing i 	summarize some point：

with asd running, lighttpd (with php) not work. without php not work. lighttpd log shows /srv/http not found.
without asd running, create a  symlink (replace /srv/http) can work almost everywhere except /tmp
change volatile = '/run' , and everything works well. (using overlayfs)

i guess maybe this is a point https://wiki.archlinux.org/index.php/Tmpfs#Opening_symlinks_in_tmpfs_as_root_fails


CASMINST-4501

Summary and Scope
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
Install the latest docs after rebooting into the new LiveCD.
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
No.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CASMINST-4501
Change will also be needed in release/1.2

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
None.
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

/backport release/1.2


chore: distribute most fun_prop tagging of measurability lemmas into …

…the respective files
So fun_prop can be used without breaking existing assert_not_exists statements.

Aside. The module docstring for Constructions/BorelSpace/Basic is outdated, Measurable.add is not mentioned there any more.

Why didn't you redistribute all the attributes? And didn't remove the file Mathlib/Tactic/FunProp/Measurable.lean ?
Otherwise the PR is good with me.

Thanks for taking a look! This is the smallest change I needed to make the dependent PR go through. But I'm happy to redistribute the remaining tags also... this might happen only later this week.

I moved the remaining attributes in Measurable and AEMeasurable; this is ready for review again.

Looks good to me!

bors merge


new methods Worktree.[AddGlob|RemoveBlob] and recursive Worktree.[Add|Remove]

Fixes: https://github.com/src-d/go-git/issues/456

@orirawlings PTAL

@orirawlings PTAL

@orirawlings PTAL

Hi 😄
can't understand if this is adding the support for recursive deletion of not empty folders, I am trying to do it with
worktree.Filesystem.Remove(path) where path is a folder containing some files and I'm getting error remove /tmp/path: directory not empty (using the clone with OS storage)
I looked a bit into billy's code and there is a RemoveAll function mimicking the standard lib's os.RemoveAll but it looks like in worktree.go it's only used in the rmFileAndDirIfEmpty function...
Any ideas?
Thanks


The django.forms.util module has been renamed.

Under django 1.8 I got warning:
/usr/local/lib/python2.7/dist-packages/bootstrap3_datetime/widgets.py:2: \
RemovedInDjango19Warning: The django.forms.util module has been
renamed. Use django.forms.utils instead

This has been fixed in master. What's the time line for a new release on pypi?
Also can I suggest tagging releases in github so it's easy to compare what's released to master.

bump.
@nkunihiko are there any plans to release a new version to pypi any time soon?
I'm getting really bored of warnings when running django locally.
Thanks for the package, sorry to hassle.

:+1:

:+1:

please update, these warnings are very annoying

:thumbsup:

please push it to pypi already :P

I have a fork of this project which is released on pypi as django-bootstrap3-datetimepicker-2 which fixes this problem
https://github.com/samuelcolvin/django-bootstrap3-datetimepicker
It's made a few other fixes and changed how static files are handled but it should be pretty easy to switch to.

please push to pypi

+1
please push to pypi

It has been almost year and this is still not pushed to pypi 😢

Any hope?

Dear Friends,
I am using django version 1.8.18 and I get the same error as follow:
/usr/local/lib/python2.7/dist-packages/django_facebook/api.py:1: RemovedInDjango19Warning: The django.forms.util module has been renamed. Use django.forms.utils instead.
from django.forms.util import ValidationError
Please fix the issue. It'll be a good move :)


Malformed URL for finalized datapackage

A malformed url to the datapackage.json is created here:  https://github.com/openspending/datapackage-pipelines-fiscal/blob/5388e8f1bbf7ed239b479ffac97d647b130a89ef/datapackage_pipelines_fiscal/flows/finalize_datapackage.py#L83
Bear in mind when fixing this that the domain might not be AWS, but an AWS-compatible service.

What is the malformed URL that was generated?
It is assumed that the bucket name also serves as a domain name that's mapped to the bucket (regardless of provider). For openspending the name of the bucket is 'datastore.openspending.org'.

I see. In my local instance the bucket name isn't a domain, so it breaks. Can the assumption be documented.

Ah, ok.
In this case we should probably add an 'S3_ENDPOINT' env var and construct the url in a more compatible way (we also need to change https -> http while we're at it):
http://{S3_ENDPOINT}/{BUCKET}/...

To get the local instance working with a S3-like datastore I had to add the S3_ENDPOINT_URL env var to os-conductor container (so it's available for dpp-fiscale/boto3). E.g. S3_ENDPOINT_URL: http://fakes3:4567. Otherwise boto will default to the AWS domain.

Related to this: there is a certificate error for https://datastore.openspending.org/blahblah. Previously, datastore urls had the aws address and bucket name e.g. https://s3.amazonaws.com:443/datastore.openspending.org/338513c686c7da2f6f0553d8a0bfa3f8/leeds-council-spending-dec-2017/datapackage.json
Packages can't be edited with the current url schema, as either there is a certificate error with https, or an insecure 'Mixed Content' page error with http.
See: https://gitter.im/openspending/chat?at=5ae9b2a453ceca3604a6e118


[Feat] Successors and Predecessors methods out of the box

@Tochemey thank you for creating the issue. Could you please add a description? it would be great if you add method names, inputs, and expected output with example.


164048143 show splash until wallet ready

This fixes a bug that if reloading a url it doesn't wait for wallet to be ready which then throws exception on dashboard when it tries to read balances
In the process I found what seems like a bug in react navigation. reloading AppNavigation/Dashboard/Claim doesnt go to Claim but to Dashboard

@sirpy, I'm not being able to navigate away from the signup screen.
Route changed to Signup/Name, but the screen remains in in Auth.

@fernandomg this no longer waits on splash screen, had some issues with AppSwitch logic.
so it waits for wallet+gundb storage to be ready before even rendering react

@sirpy, now it's working fine


After opening a file multiple times two, instances are opened at the same time.

After opening a file multiple times two instances are opened at the same time.
The problem "resets" if i go out of the folder and back in. But after 2-3 opening procedures of the same file the bug returns.
Issue observed with pictures and text files. Not reproducible with windows media player classic.
Desktop (please complete the following information):

OS Version: [e.g. Windows 10 1903 18362.175]
App version: [v0.5.0]

By instance do you mean a separate window?

No,i am referring to multiple instances of the program i use to open that file. For photos, two Photos apps will open at the same time.

Hmm... I cannot reproduce this one in v0.10.2 .
It may be because I'm running a Windows Insider build

@ChelaruCatalin Is this still an issue in v0.20?

Thanks again for your feedback.
Since we didn't hear from you on this topic for 6+ days, we'll assume everything is worked out and close this feedback item. If you had more feedback to provide, please re-open this and help the owners by describing the current status and any steps taken to troubleshoot this.


Localization namespaces, reloaded.

Should I pull #864 first or this first?

That should not be a problem since the two pull requests affect different parts of the backend. If merge conflicts arise, however, let's pull this one first.


nixos/pipewire: add systemWide option

Motivation for this change
Allow multiple users to simultaneously access PipeWire, similarly to how PulseAudio can be configured using hardware.pulseaudio.systemWide.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I've marked all from my perspective tackled conversations as resolved.

Question: this PR is using the audio group for the pipewire user, but according to https://pipewire.org/ (I haven't tested it myself), it also supports video, so maybe we do want to use a dedicated group after all, i.e. pipewire like it is done in the upstream unit files?

do want to use a dedicated group after all

I'm interpreting the :+1: as a yes, we want :) so I'm going to do that and add audio and video to pipewire's extraGroups...

  Note that for pipewire-pulse there
are only user units, which work in both cases.

these work as a user, e.g. nix-shell -p pulseaudio --command pactl info accesses  the user-pipewire-pulse.socket and spawns pipewire-pulse.service…
however a system service (e.g. spotifyd) trying to use pulseaudio just doesn't do anything. How would one configure that?


Automated Package Upgrade

:tada: This PR is included in version 25.3.87 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added maintainers and contribution text to README

I want to keep the README with these two sections.

Hey @haf & @danieldreier - please confirm that you're comfortable with being noted as maintainers and authors. Thank you for this incredible work.

+1

@mjbrender you should list yourself, too.

:blush: why thank you - I will!


A head option

It would be nice to have a head option, where we can specify the head character (Ex =>).
downloading [=====>            ] 29% 3.7s

It defaults to complete char
downloading [=====             ] 29% 3.7s

Happy to review a PR!

@thebigredgeek
Here's the PR

@thebigredgeek Can you review my PR ?


functional shortcut for array_reduce?

Hi,
I don't see a function tha wrap array_reduce (like map for array_map).

reduce_left and reduce_right should have you covered 👍


Clarification on the "Renewable" column

Can you clarify if the "Renewable" column of the eligibility table indicates the number of times that the resource can be used within each one month period?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f79453c-3962-2f0c-5b99-4fbde91972f8
Version Independent ID: c845c29e-dfd7-316e-81b2-ebe288a384c1
Content: Technical Support Benefit
Content Source: subscriptions/vs-tech-support.md
Product: vs-subscription
GitHub Login: @evanwindom
Microsoft Alias: jaunger

@nickpainter  - Thanks for your question.  The "renewable" indicates whether the benefit renews if the subscription is renewed.  For the technical support benefit, the number of incidents provided depends on the subscription level.  The incidents can be used at any time during the term of the subscription, but if they are used, they are not replaced until the subscription is renewed.  So, for example, if you purchase an annual subscription with four incidents, you can use those four at any time, but once they're used, you will need to purchase additional incidents directly from Customer Service and Support if you need additional assistance.  When you renew your annual subscription, you will once again have four incidents available.


List of planned features

This doc holds proposed features kn-event should implement: https://docs.google.com/document/d/11luj2wqajEsiaNXHjnGNBgc5viHdObCpqEwCAYnYbE8

Not able to access the doc. Would be great to see the response event in case services support that option :)

I've updated the link.
I think there is no concept of response event. But, I think your use case could be achieved by using the planned event listening feature.


ENHANCEMENT Allow composer require for 3.x minor versions

Hey @camfindlay glad you managed to solve the strange issue preventing you from forking and making a PR. I've cherry picked your PR commit (b3aa435) as we use gitflow and prefer our changes to be made to the develop branch. Sorry for all the hassle.

No worries... that will learn me for not reading the contributing.md :facepalm:


trinucleotide expansion up to 19.02 --> inframe deletion in 19.04

Genetic evidence linking HTT to huntington disease has changed from trinucleotide expansion to inframe deletion.
From Entrez Gene: "Huntington's disease, a neurodegenerative disorder characterized by loss of striatal neurons. This is thought to be caused by an expanded, unstable trinucleotide repeat in the huntingtin gene, which translates as a polyglutamine repeat in the protein product. A fairly broad range of trinucleotide repeats (9-35) has been identified in normal controls, and repeat numbers in excess of 40 have been described as pathological"
This data comes from ClinVar via EVA. Has anything changed in the JSON from EVA between 19.02 and 19.04 for HTT and Huntington?
Some notes:

some past conversations: https://github.com/The-Sequence-Ontology/SO-Ontologies/issues/399#issuecomment-302463868

I'd have thought that inframe deletion is actually wrong, it could be inframe insertion but not deletion

we list the variant as rs71180116 (rather than RCV000032098) in the second (mutation) column in the genetic associations page. Using the rs ID  instead of RCV ID, we now point to Ensembl (instead of pointing to ClinVar ), which calls this "inframe deletion". Is that why we've changed from trinucleotide expansion to inframe deletion? Can we override the VEP results? VEP consequence term for rs193922926 is overridden for this example:

https://www.targetvalidation.org/evidence/ENSG00000124788/Orphanet_98755?view=sec:genetic_association
(trinucleotide repeat expansion in the Platform, coding sequence variant in Ensembl)

many other repeat expansion disorders in the Platform have their variants still "trinucleotide repeat expansion" e.g. FMR1 in Fragile X syndrome, ATXN7 in Spinocerebellar ataxia type 7, ATXN1 in Spinocerebellar ataxia type 1, DMPK in Steinert myotonic dystrophy

Is this relevant: https://github.com/opentargets/data_release/wiki/OT007-SNP2GENE-Pipeline#adding-trinucleotide-disease-annotation-eva-only ?

This does not look like an "issue" to me, just a data update. EVA evidence data has changed substantially for the 19.04 release because ClinVar added many new rsIds in January. In this particular case, although RCV000032098 is still associated with HTT in Huntington's disease, it seems that priority is given to the rsID, which is new:
19.02_cttv012-29-01-2019.json
{
  "alleleOrigin": "germline",
  "phenotype": "http://www.orpha.net/ORDO/Orphanet_399",
  "gene": "ENSG00000197386",
  "clinvarAccession": "RCV000032098",
  "variant_id": "RCV000032098"
}

19.04_cttv012-10-04-2019.json
{
  "alleleOrigin": "germline",
  "phenotype": "http://www.orpha.net/ORDO/Orphanet_399",
  "gene": "ENSG00000197386",
  "clinvarAccession": "RCV000032098",
  "variant_id": "rs71180116"
}

This is probably something we should discuss with EVA.

I think itis an issue, in that VEP does not accurately call the consequence of rs71180116 because the polarity of the alleles is wrong. The disease associated allele is the trinucleotide expansion allele (erroneously represented as an insertion) rather than the smaller "deletion" allele. The 'normal' is the deleted/non-expanded allele. I think this is why we have the over-ride file that adam points to above which corrects these consequences for certain mutations. As a temporary fix we should include rs71180116 in that file, and also talk to EVA about how mutations are represnted in Clinvar - we may not be able to do anything about that

Out of the 23 trinucleotide expansions in the ot_trinucleotide.txt file, only 12 appear in the 19.04 EVA evidence file and three of them have the wrong functional consequence annotated (see rows in bold):

ClinVar Accession
Variant id
Gene id
Phenotype
Functional Consequence

RCV000011272
rs193922937
ENSG00000155966
FRAXE intellectual disability
trinucleotide_repeat_expansion

RCV000003729
rs193922928
ENSG00000066427
Spinocerebellar ataxia type 3
trinucleotide_repeat_expansion

RCV000004184
RCV000004184
ENSG00000165060
Friedreich ataxia
trinucleotide_repeat_expansion

RCV000009015
RCV000009015
ENSG00000141837
Spinocerebellar ataxia type 6
trinucleotide_repeat_expansion

RCV000019124
RCV000019124
ENSG00000169714
Proximal myotonic myopathy
trinucleotide_repeat_expansion

RCV000191939
rs1555397179
ENSG00000066427
Spinocerebellar ataxia type 3
trinucleotide_repeat_expansion

RCV000483474
rs3032358
ENSG00000169083
Kennedy disease
inframe_deletion

RCV000005352
RCV000005352
ENSG00000104936
Steinert myotonic dystrophy
trinucleotide_repeat_expansion

RCV000008537
rs193922926
ENSG00000124788
Spinocerebellar ataxia type 1
trinucleotide_repeat_expansion

RCV000032098
rs71180116
ENSG00000197386
Huntington disease
inframe_deletion

RCV000032099
rs71180116
ENSG00000197386
Huntington disease
inframe_deletion

RCV000162201
rs193922936
ENSG00000102081
Fragile X syndrome
trinucleotide_repeat_expansion

I'm in touch with Kirill in EVA team to get this sorted for the next release.

After talking to EVA, it has been found that the issue is caused by the approach used to pair ClinVar records with the mapping provided:

Try pairing using rsID
Or, if not present in the mappings file, use nsvID
Or, if not present, use full variant description (e. g. 10:100749815-100749815:1/A)
Finally, if none of the above worked, use ClinVar RCV ID

RCV000032098 and RCV000032099 are masked by rs71180116 and the following entry in the mapping file:
rs80357575    1    ENSG00000012048    BRCA1    frameshift_variant    0

Similarly, the entry masking RCV000483474 is this:
X:67545318-67545320:1/-    1    ENSG00000169083    AR    inframe_deletion    0

Those two rows have been manually removed from the mapping file returned to EVA and now the functional consequence of those variants is trinucleotide_repeat_expansion as expected. However, they still have an associated rsID, so the link may still point to an Ensembl website with the wrong function annotation. This will be furter discussed with EVA.

Manual correction has been repeated for the 19.09 release.

Manual correction has been repeated for the 19.11 release.
In addition, two of the trinucleotide expansions (RCV000005966, RCV000006518) have been missing in the EVA evidence files at least since 19.11, I'll ask them about it.

Fixed: back to trinucleotide expansion.

I'm afraid this isn't fixed @deniseOme. The functional consequence in the data and UI is correct because I manually fix the output of the snp-to-gene mapping. EVA are working on a permanet solution for it.

Manual correction has been repeated for the 20.02 release.
Kirill has been working on a new way to process trinucleotide variants and on re-implementing the variant-to-gene mapping but I need to ask them the status of this work.

This is now handled by EVA

In the 20.04 release two trinucleotide repeat expansions (RCV000005352 and RCV000162201) were annotated with different functional consequences. The following was Kirill's (EVA) explanation:

The change you are observing is caused by migrating to the new VEP pipeline. Under the new approach, the pairing of variant records is first attempted using full variant description (CHROM:POS:REF:ALT), and in case this fails, using an RCV ID (intended for manual trinucleotide repeat mappings only).
While for almost all trinucleotide repeats ClinVar does not provide an explicit variant description, for those two variants which you mentioned this is not the case, and there are full descriptions. For example, for RCV000005352, it is provided as 19:45770204:C:CCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAGCAG. When you run this through VEP, it returns a consequence of splice_region_variant. This is why it is in the evidence strings.

These two have been left as they are for 20.04. They will be checked again for 20.06 and they can be corrected manually if needed.

Fixed in 20.06


Year selector missing from team pages

On any given team page, the year selector to switch between seasons is missing.

Not sure if it's related, but rookie years are also showing up as "0"

Yes that is what is causing the issue and should be fixed when we do the next team import at the beginning of next week

This has been resolved with the latest data sync from FIRST


NumPy 2.0 compat problems in doc build

There are (only!) two NumPy 2.0 compatibility problems showing up in our CircleCI builds:
../examples/io/read_neo_format.py failed leaving traceback:

Traceback (most recent call last):
  File "/home/circleci/project/examples/io/read_neo_format.py", line 18, in <module>
    import neo
  File "/home/circleci/python_env/lib/python3.10/site-packages/neo/__init__.py", line 15, in <module>
    from neo.core import *
  File "/home/circleci/python_env/lib/python3.10/site-packages/neo/core/__init__.py", line 35, in <module>
    from neo.core.block import Block
  File "/home/circleci/python_env/lib/python3.10/site-packages/neo/core/block.py", line 12, in <module>
    from neo.core.container import Container, unique_objs
  File "/home/circleci/python_env/lib/python3.10/site-packages/neo/core/container.py", line 13, in <module>
    from neo.core.spiketrain import SpikeTrain
  File "/home/circleci/python_env/lib/python3.10/site-packages/neo/core/spiketrain.py", line 27, in <module>
    import quantities as pq
  File "/home/circleci/python_env/lib/python3.10/site-packages/quantities/__init__.py", line 273, in <module>
    from . import quantity
  File "/home/circleci/python_env/lib/python3.10/site-packages/quantities/quantity.py", line 10, in <module>
    from .dimensionality import Dimensionality, p_dict
  File "/home/circleci/python_env/lib/python3.10/site-packages/quantities/dimensionality.py", line 333, in <module>
    p_dict[np.core.umath.clip] = _d_clip
  File "/home/circleci/python_env/lib/python3.10/site-packages/numpy/core/__init__.py", line 31, in __getattr__
    _raise_warning(attr_name)
  File "/home/circleci/python_env/lib/python3.10/site-packages/numpy/core/_utils.py", line 10, in _raise_warning
    warnings.warn(
DeprecationWarning: numpy.core is deprecated and has been renamed to numpy._core. The numpy._core namespace contains private NumPy internals and its use is discouraged, as NumPy internals can change without warning in any release. In practice, most real-world usage of numpy.core is to access functionality in the public NumPy API. If that is the case, use the public NumPy API. If not, you are using NumPy internals. If you would still like to access an internal attribute, use numpy._core.umath.

../tutorials/inverse/50_beamformer_lcmv.py failed leaving traceback:

Traceback (most recent call last):
  File "/home/circleci/project/tutorials/inverse/50_beamformer_lcmv.py", line 316, in <module>
    morph = mne.compute_source_morph(
  File "<decorator-gen-489>", line 10, in compute_source_morph
  File "/home/circleci/project/mne/morph.py", line 262, in compute_source_morph
    shape, zooms, affine, pre_affine, sdr_morph = _compute_morph_sdr(
  File "/home/circleci/project/mne/morph.py", line 1147, in _compute_morph_sdr
    from dipy.align.imaffine import AffineMap
  File "/home/circleci/python_env/lib/python3.10/site-packages/dipy/align/__init__.py", line 26, in <module>
    from dipy.align._public import (syn_registration, register_dwi_to_template, # noqa
  File "/home/circleci/python_env/lib/python3.10/site-packages/dipy/align/_public.py", line 15, in <module>
    from dipy.align.metrics import CCMetric, EMMetric, SSDMetric
  File "/home/circleci/python_env/lib/python3.10/site-packages/dipy/align/metrics.py", line 7, in <module>
    from dipy.align import vector_fields as vfu
  File "vector_fields.pyx", line 1, in init dipy.align.vector_fields
ImportError: numpy.core.multiarray failed to import (auto-generated because you didn't call 'numpy.import_array()' after cimporting numpy; use '<void>numpy._import_array' to disable if you are certain you don't need it).

(the second one also occurs for examples/inverse/morph_volume_stc.py)
This PR handles the deprecation coming from neo -> quantities (also reported upstream).
The DIPY problem has also been reported upstream but I don't think can be fixed worked around in our code other than pinning to lower NumPy :(

I rolled the dipy workaround for Azure into https://github.com/mne-tools/mne-python/pull/12670

... and for the PySide6 error

ok will wait for #12670, merge main, then pin numpy in the CircleCI config

Backported manualy


[WIP] test(cmd/cli): add test for proxy get run cmd

Description:

Affected area:

Functional Area

New Functionality
[ ]

Documentation
[ ]

Install
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Ingress
[ ]

Egress
[ ]

Networking
[ ]

Observability
[ ]

SMI Policy
[ ]

Sidecar Injection
[ ]

Security
[ ]

Upgrade
[ ]

Tests
[x]

CI System
[ ]

Demo
[ ]

Performance
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? No

Did you notify the maintainers and provide attribution?

Is this a breaking change? No

Codecov Report

Merging #3684 (a174ac8) into main (dda6324) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3684      +/-   ##
==========================================
- Coverage   67.51%   67.45%   -0.06%
==========================================
  Files         181      181
  Lines        8757     8772      +15
==========================================
+ Hits         5912     5917       +5
- Misses       2812     2822      +10
  Partials       33       33

Flag
Coverage Δ

unittests
67.45% <ø> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/configurator/methods.go
68.49% <0.00%> (-0.96%)
:arrow_down:

...icate/providers/certmanager/certificate_manager.go
87.09% <0.00%> (-0.81%)
:arrow_down:

cmd/osm-controller/osm-controller.go
13.51% <0.00%> (-0.78%)
:arrow_down:

pkg/configurator/client.go
84.48% <0.00%> (ø)

pkg/envoy/registry/services.go
95.36% <0.00%> (ø)

pkg/configurator/mock_client_generated.go
0.00% <0.00%> (ø)

pkg/kubernetes/util.go

pkg/kubernetes/announcement_handlers.go

pkg/kubernetes/client.go

pkg/kubernetes/events/event_pubsub.go

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda6324...a174ac8. Read the comment docs.

Instead of writing a unit test for the CLI commands that rely on network connectivity to an endpoint (port-forward to a remote pod and executing http.GET in this case), there is a lot more value in writing an e2e test and verifying these commands work as expected. The unit test will partially increase coverage, but by no means will actually test the expected behavior. To unit test this, you would need to set up an http server (could be a fake server using httptest) mimicking the Envoy admin endpoint on port 15000 that implements http handlers, and get the portforward to work with a fake.

@shashankram that makes sense -- I haven't been having much luck with trying to unit test the http get bit and the code coverage increases for the rest of the lines here are minute

stale PR, closing


Add configurable logging level

Description
What this PR does / why we need it:
As part of plugin development, I'd like to be able to turn on some DEBUG logs so I can see what's actually being passed into my plugin, but I don't want to spam users with verbose info at runtime. Ratify currently defaults to the INFO log level, and it's not configurable. Other folks have asked for this as well in the issues

Implements configurable log levels via RATIFY_LOG_LEVEL, with the default to the current INFO level
Adds tests for the above
Adds a new "usage" docs page that documents the RATIFY_* environment variables
Adds debug logging for plugin executables

Note: I believe it could be valuable to have Cobra-generated markdown docs, and/or add robust documentation for the other env vars that are in use, particularly around auth stores (ex: AWS_REGION, AZURE_TENANT_ID, etc). Will track in a separate Issue/PR

Fixes #348
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[x] Unit tests
[x] Verified that env vars / STDIN data is omitted by default, and is correctly logged with RATIFY_LOG_LEVEL=DEBUG

Checklist:

[x] Does the affected code have corresponding tests?
[x] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[x] Do all new files have appropriate license header?

I opted not to wire this all the way into the Helm chart yet but I'm happy to do so if ya'll see value in it

thanks Noel, the changes looks good to me. The CRD controllers uses the "sigs.k8s.io/controller-runtime/pkg/log" logger as it provides the crd ctx, do you have suggestion on how do we unify the loggers but also keeping the custom resource context?

Ah! Didn't realize we had 2 logging libraries going on
I've updated to use logrus in the CRD controllers, and still pass in .WithContext(ctx), as it did before
The manager must use a logr instance, and that uses a different scheme for tracking levels - ex: +v, +vv, +vvvvv rather than levels like INFO/DEBUG/etc. So that particular path won't get log level set, but everything else will, which I've manually tested
I looked around, saw that there are libraries that convert logrus -> logr, or we could write our own adapter as something to be handled in a future issue?

Ah! Didn't realize we had 2 logging libraries going on
I've updated to use logrus in the CRD controllers, and still pass in .WithContext(ctx), as it did before
The manager must use a logr instance, and that uses a different scheme for tracking levels - ex: +v, +vv, +vvvvv rather than levels like INFO/DEBUG/etc. So that particular path won't get log level set, but everything else will, which I've manually tested
I looked around, saw that there are libraries that convert logrus -> logr, or we could write our own adapter as something to be handled in a future issue?

thanks for much for the investigation, i ve created tracking item at issue 503


Can't open project on Debian

$ tmuxinator monitor
/var/lib/gems/1.8/gems/tmuxinator-0.6.9/lib/tmuxinator/project.rb:22:in windows': undefined method with_index' for #Array:0x7f1dbb068918 (NoMethodError)
from /var/lib/gems/1.8/gems/tmuxinator-0.6.9/lib/tmuxinator/project.rb:103:in windows?'         from /var/lib/gems/1.8/gems/tmuxinator-0.6.9/lib/tmuxinator/config.rb:82:in validate'
from /var/lib/gems/1.8/gems/tmuxinator-0.6.9/lib/tmuxinator/cli.rb:50:in start'         from /var/lib/gems/1.8/gems/tmuxinator-0.6.9/bin/tmuxinator:13         from /usr/local/bin/tmuxinator:23:in load'
from /usr/local/bin/tmuxinator:23
here's the layout that I tried to use, which works on MacOS: http://paste.debian.net/136248/

Same issue here. Just updated to ruby 1.9.3, still won't work

@verganis Passes CI on Ruby 1.9.3 so it might something localised. Feel free to open another issue if you've got problems. Closing this one for now.


[DataSync] Indexing lastUpdatedAt field?

I believe this would make for much faster sync queries, and remove the step of in-memory sorting when ordering by lastUpdatedAt, if one chooses to do it in a findBy query

Automatically generated comment to notify maintainers
/cc @craicoverflow, @machi1990, @wtrocki

+1, makes sense to me. This will mean adding the @index annotation by default right? @ssd71

Aren't we doing it now 🙈

+1, makes sense to me. This will mean adding the @index annotation by default right? @ssd71

Yep

Aren't we doing it now :see_no_evil:

Nope :smile:

🤦

This is low hanging fruit. I kind of have my eyes in the codebase that does this, I am grabbing this issue in order to leave @ssd71 focused on interesting issues. WDYT?

@machi1990 This is not longer up to date. We have separate _lastUpdated field now for datasync.

@machi1990 This is not longer up to date. We have separate _lastUpdated field now for datasync.

Yes, that's the one that's indexed automatically in the patch I opened.


If grass can't exist on top of non-full toppings it probably shouldn't be able to sit on top of other grass sub-layers

Only one grass sub-layer per super topping, then.


[IAC-1735] - update spec tests

The tests related to classes or defines which are using ensure_packages function from stdlib needs to be updated accordingly to this PR https://github.com/puppetlabs/puppetlabs-stdlib/pull/1196

Ah, I now see this was added because it's actually used in spec/unit/defines/server/default_privileges_spec.rb. https://github.com/puppetlabs/puppetlabs-postgresql/pull/1267/files#r689125725 was wrong to begin with.

I opened https://github.com/puppetlabs/puppetlabs-postgresql/pull/1291 which takes most of this commit, but fixes the broken unit test separately with let blocks.


community: Spider integration

Added the Spider.cloud document loader. Spider is the fastest and cheapest crawler that returns LLM-ready data.
- **Description:** Adds Spider data loader
- **Dependencies:** spider-client
- **Twitter handle:** @WilliamEspegren

@baskaryan any idea why this is failing?

The docs build failed because the API reference link was missing a URL. Our docs will automatically populate API reference links so I just removed the cell.


Start Message "An error occured while checking for software update"

Actual behavior:
When starting Defi Wallet this message is displayed every time, although I have already installed the latest version.
Even if I download and install again message will come again.

Expected behavior:
Message should not be displayed if latest version is installed
How to reproduce it (as minimally and precisely as possible):
Launch the app after manual install

DeFi Wallet Version: 2.5.2
Operating System (OS): Win 10 Pro
– Current free storage capacity: 500GB

Anything else we need to know?
There was an issue with automatic update so I had to install it manually.
log.zip

Hi @Darkman-Q-Tester , can you send your binary log too please? In the mean time, you can try to replace the app manually.

Backup wallet first

Go to the latest app release

Download DeFi-Wallet-Setup-2.5.2.exe

Replace the app icon only

Kindly ensure that your firewall is turned off and internet connection is stable.

Thank you, I did already manually.
See attached the binary log.
binary.zip

Hi @Darkman-Q-Tester , there could've been an outage on GitHub when you had this error, hence the app kept checking if there's an update available. Do you still encounter it?

Issue is gone. Thank you


Stable

I wanted to use lean-smt in a stable project, and noticed it's pinned to v4.2.0-rc1.
In case you're interested in a PR, I made a stable version here which was relatively straightforward. There are a few changes that would need to be reviewed (here, here, and here at least), but nothing major.

Hi @AdrienChampion! Thank you for the helpful note. The last two commits move the pin to v4.4.0.

Awesome!