Document "How do I add Student Insights?" for district IT staff

Just saw this looking back at issues @alexsoble
Looks like we've got a few district staff that can't get into Insights because they are not assigned to a specific school.  In the past, we'd just assign them to Healey and then give them district-wide access.
Two in particular, Christine Trevisone (SPED director) and Sarah Davila (ELL director) are looking to gain access, but can't.  Should I just change their school name in Aspen or is it the right time to make a change to bring in all staff regardless of school? @alexsoble

Hey @snoopyuri! This issue actually had a typo in its title, should say "Document "How do I add Student Insights?" for district IT staff". The idea is to provide a guide to John Breslin-type staff at other districts.
That said, to answer your question — the way the system's set up right now, all folks with roles like Data Analyst, Superintendent, Assistant Superintendent, are assigned to the PIC. Do you think that would be a good solution for Christine and Sarah?

That would work….shall I assign them to PIC and then it’ll pick them up?
From: Alex Soble<EMAIL_ADDRESS>Sent: Tuesday, November 7, 2017 1:33 PM
To: studentinsights/studentinsights
Cc: Harel, Uri; Mention
Subject: Re: [studentinsights/studentinsights] Document "How do I add Student Insights?" for district IT staff (#1157)
Hey @snoopyurihttps://github.com/snoopyuri! This issue actually had a typo in its title, should say "Document "How do I add Student Insights?" for district IT staff". The idea is to provide a guide to John Breslin-type staff at other districts.
That said, to answer your question — the way the system's set up right now, all folks with roles like Data Analyst, Superintendent, Assistant Superintendent, are assigned to the PIC. Do you think that would be a good solution for Christine and Sarah?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/studentinsights/studentinsights/issues/1157#issuecomment-342578225, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeOaNu1jc1bciZhyFuHpp7ik49MI9f0kks5s0KJqgaJpZM4P4vgr.

Yep!
On 7 November 2017 at 13:35, snoopyuri<EMAIL_ADDRESS>wrote:

That would work….shall I assign them to PIC and then it’ll pick them up?
From: Alex Soble<EMAIL_ADDRESS>Sent: Tuesday, November 7, 2017 1:33 PM
To: studentinsights/studentinsights
Cc: Harel, Uri; Mention
Subject: Re: [studentinsights/studentinsights] Document "How do I add
Student Insights?" for district IT staff (#1157)
Hey @snoopyurihttps://github.com/snoopyuri! This issue actually had a
typo in its title, should say "Document "How do I add Student Insights?"
for district IT staff". The idea is to provide a guide to John Breslin-type
staff at other districts.
That said, to answer your question — the way the system's set up right
now, all folks with roles like Data Analyst, Superintendent, Assistant
Superintendent, are assigned to the PIC. Do you think that would be a good
solution for Christine and Sarah?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
studentinsights/studentinsights/issues/1157#issuecomment-342578225>, or
mute the thread<https://github.com/notifications/unsubscribe-auth/
AeOaNu1jc1bciZhyFuHpp7ik49MI9f0kks5s0KJqgaJpZM4P4vgr>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/studentinsights/studentinsights/issues/1157#issuecomment-342596886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADD5HbYra9Gwqsbjo4azxMi4PHSPgPOIks5s0LEagaJpZM4P4vgr
.

Ok, they’re now assigned to PIC.  Hopefully, they’ll get picked up this afternoon.
From: Alex Soble<EMAIL_ADDRESS>Sent: Tuesday, November 7, 2017 3:00 PM
To: studentinsights/studentinsights
Cc: Harel, Uri; Mention
Subject: Re: [studentinsights/studentinsights] Document "How do I add Student Insights?" for district IT staff (#1157)
Yep!
On 7 November 2017 at 13:35, snoopyuri <notifications<EMAIL_ADDRESS>wrote:

That would work….shall I assign them to PIC and then it’ll pick them up?
From: Alex Soble<EMAIL_ADDRESS>Sent: Tuesday, November 7, 2017 1:33 PM
To: studentinsights/studentinsights
Cc: Harel, Uri; Mention
Subject: Re: [studentinsights/studentinsights] Document "How do I add
Student Insights?" for district IT staff (#1157)
Hey @snoopyurihttps://github.com/snoopyuri! This issue actually had a
typo in its title, should say "Document "How do I add Student Insights?"
for district IT staff". The idea is to provide a guide to John Breslin-type
staff at other districts.
That said, to answer your question — the way the system's set up right
now, all folks with roles like Data Analyst, Superintendent, Assistant
Superintendent, are assigned to the PIC. Do you think that would be a good
solution for Christine and Sarah?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
https://github.com/> studentinsights/studentinsights/issues/1157#issuecomment-342578225>, or
mute the thread<https://github.com/notifications/unsubscribe-auth/
https://github.com/notifications/unsubscribe-auth/> AeOaNu1jc1bciZhyFuHpp7ik49MI9f0kks5s0KJqgaJpZM4P4vgr>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/studentinsights/studentinsights/issues/1157#issuecomment-342596886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADD5HbYra9Gwqsbjo4azxMi4PHSPgPOIks5s0LEagaJpZM4P4vgr
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/studentinsights/studentinsights/issues/1157#issuecomment-342603862, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeOaNuBRzLsB2iYWJxzVcXJUTW-6pxqgks5s0LbHgaJpZM4P4vgr.

It seems that PIC people aren’t getting picked up.   I tried checking on a few of them including Sarah Davila again and they’re not showing up in my permissions page.  Can you check it out?
From: Harel, Uri
Sent: Wednesday, November 8, 2017 9:02 AM
To: 'studentinsights/studentinsights'; studentinsights/studentinsights
Cc: Mention
Subject: RE: [studentinsights/studentinsights] Document "How do I add Student Insights?" for district IT staff (#1157)
Ok, they’re now assigned to PIC.  Hopefully, they’ll get picked up this afternoon.
From: Alex Soble<EMAIL_ADDRESS>Sent: Tuesday, November 7, 2017 3:00 PM
To: studentinsights/studentinsights
Cc: Harel, Uri; Mention
Subject: Re: [studentinsights/studentinsights] Document "How do I add Student Insights?" for district IT staff (#1157)
Yep!
On 7 November 2017 at 13:35, snoopyuri <notifications<EMAIL_ADDRESS>wrote:

That would work….shall I assign them to PIC and then it’ll pick them up?
From: Alex Soble<EMAIL_ADDRESS>Sent: Tuesday, November 7, 2017 1:33 PM
To: studentinsights/studentinsights
Cc: Harel, Uri; Mention
Subject: Re: [studentinsights/studentinsights] Document "How do I add
Student Insights?" for district IT staff (#1157)
Hey @snoopyurihttps://github.com/snoopyuri! This issue actually had a
typo in its title, should say "Document "How do I add Student Insights?"
for district IT staff". The idea is to provide a guide to John Breslin-type
staff at other districts.
That said, to answer your question — the way the system's set up right
now, all folks with roles like Data Analyst, Superintendent, Assistant
Superintendent, are assigned to the PIC. Do you think that would be a good
solution for Christine and Sarah?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
https://github.com/> studentinsights/studentinsights/issues/1157#issuecomment-342578225>, or
mute the thread<https://github.com/notifications/unsubscribe-auth/
https://github.com/notifications/unsubscribe-auth/> AeOaNu1jc1bciZhyFuHpp7ik49MI9f0kks5s0KJqgaJpZM4P4vgr>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/studentinsights/studentinsights/issues/1157#issuecomment-342596886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADD5HbYra9Gwqsbjo4azxMi4PHSPgPOIks5s0LEagaJpZM4P4vgr
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/studentinsights/studentinsights/issues/1157#issuecomment-342603862, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeOaNuBRzLsB2iYWJxzVcXJUTW-6pxqgks5s0LbHgaJpZM4P4vgr.

@snoopyuri Checking it out now! You're right, it looks like the PIC is not included in the default data import list — fixing that now. My mistake.

@snoopyuri The data for students/educators associated with the PIC is pretty interesting! I'll send around an email summary with details.

Awesome, thanks!
From: Alex Soble<EMAIL_ADDRESS>Sent: Thursday, November 9, 2017 1:36 PM
To: studentinsights/studentinsights
Cc: Harel, Uri; Mention
Subject: Re: [studentinsights/studentinsights] Document "How do I add Student Insights?" for district IT staff (#1157)
@snoopyurihttps://github.com/snoopyuri The data for students/educators associated with the PIC is pretty interesting! I'll send around an email summary with details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/studentinsights/studentinsights/issues/1157#issuecomment-343249238, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeOaNhajxxIxOocvRuLMGCVvsP5ksly4ks5s00YqgaJpZM4P4vgr.

some of the mechanics have changed since then, but we addressed the specific user issues, and have docs describing onboarding work.


Add tests for method calls that have a space between method name and parentheses.

This looks like it could be a parser limitation; do you know if it's intentional?

Yes, in fact m () is not a method call without parameters. It's method call without parentheses that takes a single block argument (like wrapped with begin;end). It was made to resolve cases like:
m (a.nil? ? 1 : 0)
# (which is equivivalent to
arg = (a.nil? ? 1 : 0)
m arg

@eregon And you can pass only one parameter because it's not a regular parentheses, it's a block of code, you cant' write something like
a = (b + 1, c + 2)

Sometimes Ruby is weird :smile:

Thanks for explaining the rationale, makes sense now :)


[BUG] Hyperf\Flysystem\OSS\Adapter 文件不存在

Execute the command and paste the result below.
Command: uname -a && php -v && composer info | grep hyperf && php --ri swoole
Linux 59a37c03e093 5.15.0-105-generic #115-Ubuntu SMP Mon Apr 15 09:52:04 UTC 2024 x86_64 Linux
PHP 8.1.25 (cli) (built: Nov  8 2023 22:42:57) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.25, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.25, Copyright (c), by Zend Technologies
hyperf/cache                                  v3.1.15   A cache component for hyperf.
hyperf/code-parser                            v3.1.15   A code parser component for Hyperf.
hyperf/codec                                  v3.1.15   A codec component for Hyperf.
hyperf/collection                             v3.1.7    Hyperf Collection package which come from illuminate/collections
hyperf/command                                v<IP_ADDRESS> Command for hyperf
hyperf/conditionable                          v3.1.0    Hyperf Macroable package which come from illuminate/conditionable
hyperf/config                                 v3.1.15   An independent component that provides configuration container.
hyperf/constants                              v3.1.16   A constants component for hyperf.
hyperf/context                                v3.1.15   A coroutine/application context library.
hyperf/contract                               v3.1.2    The contracts of Hyperf.
hyperf/coordinator                            v3.1.7    Hyperf Coordinator
hyperf/coroutine                              v3.1.15   Hyperf Coroutine
hyperf/crontab                                v3.1.16   A crontab component for Hyperf.
hyperf/database                               v3.1.15   A flexible database library.
hyperf/db-connection                          v3.1.15   A hyperf db connection handler for hyperf/database.
hyperf/devtool                                v3.1.15   A Devtool for Hyperf.
hyperf/di                                     v3.1.14   A DI for Hyperf.
hyperf/dispatcher                             v3.1.0    A HTTP Server for Hyperf.
hyperf/engine                                 v2.10.5   Coroutine engine provided by swoole.
hyperf/engine-contract                        v1.9.1    Contract for Coroutine Engine
hyperf/event                                  v3.1.15   an event manager that implements PSR-14.
hyperf/exception-handler                      v3.1.15   Exception handler for hyperf
hyperf/filesystem                             v3.1.15   flysystem integration for hyperf
hyperf/framework                              v3.1.15   A coroutine framework that focuses on hyperspeed and flexible, specifically use for build m...
hyperf/guzzle                                 v3.1.15   Swoole coroutine handler for guzzle
hyperf/helper                                 v3.1.15   A function helper package that could help developer solved the problem quickly.
hyperf/http-message                           v3.1.15   microservice framework base on swoole
hyperf/http-server                            v3.1.15   A HTTP Server for Hyperf.
hyperf/ide-helper                             v3.1.15   IDE help files for Hyperf.
hyperf/logger                                 v3.1.15   A logger component for hyperf.
hyperf/macroable                              v3.1.15   Hyperf Macroable package which come from illuminate/macroable
hyperf/memory                                 v3.1.15   An independent component that use to operate and manage memory.
hyperf/model-cache                            v3.1.15   A model cache component for hyperf.
hyperf/model-listener                         v3.1.15   A model listener for Hyperf.
hyperf/pipeline                               v3.1.15   Hyperf Macroable package which come from illuminate/pipeline
hyperf/polyfill-coroutine                     v3.1.0    This component provides features added short functions.
hyperf/pool                                   v3.1.15   An independent universal connection pool component.
hyperf/process                                v3.1.15   A process component for hyperf.
hyperf/redis                                  v3.1.15   A redis component for hyperf.
hyperf/serializer                             v3.1.15   A serializer component for Hyperf.
hyperf/server                                 v3.1.15   A base server library for Hyperf.
hyperf/signal                                 v3.1.15   A signal library for Hyperf.
hyperf/stdlib                                 v3.1.0    A stdlib component for Hyperf.
hyperf/stringable                             v3.1.13   Hyperf Stringable package which come from illuminate/support
hyperf/support                                v3.1.15   A support component for Hyperf.
hyperf/tappable                               v3.1.15   Hyperf Macroable package which come from illuminate/tappable
hyperf/testing                                v3.1.15   Testing for hyperf
hyperf/translation                            v3.1.0    An independent translation component, forked by illuminate/translation.
hyperf/utils                                  v3.1.0    A tools package that could help developer solved the problem quickly.
hyperf/validation                             v3.1.15   hyperf validation
hyperf/view                                   v3.1.15   A view library for Hyperf.
hyperf/view-engine                            v3.1.15
hyperf/websocket-server                       v3.1.16   A websocket server library for Hyperf.
sy-records/think-template                     v2.0.11   use think template engine for hyperf.

swoole

Swoole => enabled
Author => Swoole Team<EMAIL_ADDRESS>Version => 5.0.3
Built => Nov 10 2023 03:11:11
coroutine => enabled with boost asm context
epoll => enabled
eventfd => enabled
signalfd => enabled
spinlock => enabled
rwlock => enabled
openssl => OpenSSL 3.1.4 24 Oct 2023
dtls => enabled
http2 => enabled
json => enabled
curl-native => enabled
pcre => enabled
c-ares => 1.19.1
zlib => 1.2.13
brotli => E16777225/D16777225
mutex_timedlock => enabled
pthread_barrier => enabled
async_redis => enabled
coroutine_postgresql => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => Off => Off
swoole.unixsock_buffer_size => 8388608 => 8388608

Description:
本次升级了3.1以后，oss上传文件报错，
<?php

declare(strict_types=1);
/**
 * This file is part of Hyperf.
 *
 * @link     https://www.hyperf.io
 * @document https://hyperf.wiki
 * @contact<EMAIL_ADDRESS> * @license  https://github.com/hyperf/hyperf/blob/master/LICENSE
 */

namespace Hyperf\Filesystem\Adapter;

use Hyperf\Filesystem\Contract\AdapterFactoryInterface;
use Hyperf\Filesystem\Version;
use Hyperf\Flysystem\OSS\Adapter;
use Xxtime\Flysystem\Aliyun\OssAdapter;

class AliyunOssAdapterFactory implements AdapterFactoryInterface
{
    public function make(array $options)
    {
        if (Version::isV2()) {
            return new Adapter($options);
        }
        return new OssAdapter($options);
    }
}
并不存在Hyperf\Flysystem\OSS\Adapter;

这个isV2()，源码如下
use League\Flysystem\FilesystemAdapter;

class Version
{
    public static function isV2(): bool
    {
        return interface_exists(FilesystemAdapter::class);
    }
}

我本地是有FilesystemAdapter这个接口类的，所以执行到return new Adapter($options);就报错

### Steps To Reproduce:

？？？为啥后面写的东西没了
报错Hyperf\Flysystem\OSS\Adapter不存在，
代码如下
class AliyunOssAdapterFactory implements AdapterFactoryInterface
{
public function make(array $options)
{
if (Version::isV2()) {
return new Adapter($options);
}
return new OssAdapter($options);
}
}

这个isV2()
use League\Flysystem\FilesystemAdapter;
interface_exists(FilesystemAdapter::class);
我本地是存在这个接口的，所以走进了if 执行return new Adapter($options);报错

这个处理了么

额 只看升级指南了   没注意到这个


Add MD follow accessors and support for follows in models

Needs feedback

Aside from a bit of clean up. The PR should be functional and ready to merge

Anymore clean up planned?  if not will merge

Not that I can thing of. It should be ready


Godot 3.4.x breaks all prior versions of Area2D because it changes body from int to RID

Godot version
3.4.2
System information
Linux
Issue description
In all version of Godot the signature for body entered is this:
func _x(_body_id: int, _body: Node, _body_shape: int, local_shape: int) -> void:

In 3.4 it has changed to using RID
func _x(_body_id: RID, _body: Node, _body_shape: int, local_shape: int) -> void:

i.e. now using RID. This then fails to trigger any signals because the parameters do not match, so all signals fail to trigger.
I suspect everywhere that also changes to RID will also break too.
Observe the video.
https://user-images.githubusercontent.com/12863685/147861566-965a8414-7fab-41f2-9aa7-db5b5acccc5c.mp4
If this is known/documented, where is it and is there a list of all places where this/similar change will also break?
Steps to reproduce

Use a body entered area2d from 3.3
Debug and the method never calls
Change to RID manually and it works

Minimal reproduction project
No response

Now that the compatibility breakage has been done, I'm not sure if it's worth reverting and breaking people's projects yet again…

Now that the compatibility breakage has been done, I'm not sure if it's worth reverting and breaking people's projects yet again…

For reference it was changed in #42742 (#42743 for 3.x >= 3.4).

Got to be honest, the most fundamental principle of public API is don't change the interface, but if you do, make sure it's telegraphed loudly ;-)
Anyway, so it only affects Area2D, RigidBody and only area_shape_entered, area_shape_exited, body_shape_entered and body_shape_exited methods? My project has hundreds of scenes and signals :(
Two things really then:

It would be nice for the changelogs/public notices to have a section (even if it says 'none') at the top to state what, if any, breaking changes are being made?

I guess this shows one of the failing points of a lack of GDScript lint tool, or perhaps a suggestion could be that it should be possible for IDE created code to detect errors, i.e. given the signals are defined in the tscn file and the IDE highlights signals it should be fairly easy to show project warnings for this and similar errors?

It would be nice for the changelogs/public notices to have a section (even if it says 'none') at the top to state what, if any, breaking changes are being made? This would give confidence to people upgrading.

While this sounds like a good idea on paper, my issue with this is that it prevents all changes from being nicely contained within a section (unless I repeat compatibility-breaking changes at the top, which can be confusing).

I guess then with 1 it was just overlooked because I defo checked the whole
changelog to check for breaking issues. As for 2, I guess given nobody else
has noticed signals failing completely on migrating, I must be the only
person who has enabled type hints and/or thinks they're useful ;-)
On Sun, 2 Jan 2022 at 16:16, Hugo Locurcio @.***> wrote:

It would be nice for the changelogs/public notices to have a
section (even if it says 'none') at the top to state what, if any, breaking
changes are being made? This would give confidence to people upgrading.

While this sounds like a good idea on paper, my issue with this is that it
prevents all changes from being nicely contained within a section (unless I
repeat compatibility-breaking changes at the top, which can be
confusing).
—
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/56410#issuecomment-1003739692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCERRLRODDNKXBM4OSMAVTUUB26XANCNFSM5LC56SSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I noticed, I thought it was an intentional change for 3.4.

It's not a bug and was indeed changed intentionally.
It's listed in the changelog for 3.4 in the Changed section, which includes things which changed and might indeed impact compatibility for existing projects. That's the section to look at if you're concerned about potential changes that might affect your project:
https://github.com/godotengine/godot/blob/3.4-stable/CHANGELOG.md#physics-1
Now it's indeed annoying that the type hints don't actually work here, as there should be one of two things in theory:

Either the engine should report that the callback has the wrong signature
Or it should report that the signal's callback doesn't exist at all (since changed signature == different method)

If it doesn't do that, it's a bug with GDScript, which might be fixed in 4.0 (type hints in 3.x are very barebones).

@akien-mga, It took a while but I found the entry stating the change you mentioned. Wasn't very clear it would break code, which was more my point about making breaking changes more prominent.
btw, you're right:
E 0:00:30.310   emit_signal: Error calling method from signal 'body_shape_entered': 'Camera2D(Flip_CameraFlip.gd)::_on_RoomNavigation_body_shape_entered': Cannot convert argument 1 from RID to int..
<C++ Source>  core/object.cpp:1236 @ emit_signal()
I just never checked there, probably mainly because a combination of never noticing the error section and I'm that used to the errors all being benign as 99.9% of the time caused simply by a node being deleted then called in a yield. I think from my perspective I'd just like a lot more up-front static checking done, which I know is more difficult given the language.
btw, digressing one thing that always annoys me (another 4 fix I hope) is unless you have a scene file open and selected, when you have a script open you lose all '.' context help and all signal information like signal hints is gone. Would also be nice when inside a script to open the scene (or view list of scenes) that import this script to counter this problem. But I'm digressing :)

I'm that used to the errors all being benign as 99.9% of the time caused simply by a node being deleted then called in a yield.

FYI, that's definitely not a benign error, this would crash on release. Errors are usually things that you really need to fix before shipping a game. Godot does its best to recover from errors on debug so that you can fix them, but it won't be forgiving in an optimized release build.

3. Bonus! don't be helpful in signal generation by putting in data type hints, leave them as generic ;-)

Yeah, I know that the usage of GDScript type hints is heavily advertised (likely prolifirated by GDQuest tutorials), but you don't have to provide type hints for everything. I've previously stumbled upon similar errors in the past when updating Godot. By doing so, you can improve cross-compatibility.
My personal recommendation is to use type hints only when there's a definite ambiguity that must be resolved. Other than that, there's no benefit as of now. Using type hints won't improve performance either in 3.x (maybe in 4.0), otherwise I'd also recommend using type hints for performance critical parts of code after profiling it.

Adding type hints in the function signature helps with autocompletion, though.

Adding type hints in the function signature helps with autocompletion, though.

Yeah, but this may lead to situations where you find yourself using type hints for more than you actually need. I usually refer to documentation instead. Of course this is a personal preference, 🙂
I just wanted to convey that one should not blindlessly use type hints unless one really needs it. Typed GDScript is optional and should stay that way.

FYI, that's definitely not a benign error

@akien-mga I'm sure you know a lot more than me ;-), and maybe I wasn't explicit enough, but I'm just referring to the well known messages from Godot when a node is deleted but the code tries to resume back from yield. Godot just ignores this whether release or debug mode. It can't do anything else really because you can't code around a return to a yielded bit of code...


Sl date picker tests

@azizpunjani - What issue is this work against?

@juwara0 This issue closes https://github.com/softlayer/sl-ember-components/issues/581

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 12 unresolved discussions, all commit checks successful.

addon/components/sl-date-picker.js, line 316 [r1] (raw file):
Nice catch!

tests/integration/components/sl-date-picker-test.js, line 44 [r1] (raw file):
Instead of doing this assertion here, instead move it to the test where you verify that disabled is wired up correctly. Verify that without passing it in is is not set and then go into the part of the test where you pass it in and verify that it is set.

tests/integration/components/sl-date-picker-test.js, line 61 [r1] (raw file):
Instead of doing this assertion here, instead move it to the test where you verify that placeholder is wired up correctly. Verify that without passing it in is is not set and then go into the part of the test where you pass it in and verify that it is set.

tests/integration/components/sl-date-picker-test.js, line 66 [r1] (raw file):
Let's remove this assertion.

tests/integration/components/sl-date-picker-test.js, line 72 [r1] (raw file):
I did not see integration tests to verify that things are wired up correctly for:
autoclose
calendarWeeks
clearBtn
daysOfWeekDisabled
endDate
forceParse
format
inputs
keyboardNavigation
language
minViewMode
multidate
orientation
startDate
startView
todayBtn
todayHighlight
weekStart

tests/integration/components/sl-date-picker-test.js, line 185 [r1] (raw file):
Lets remove this test and restore the unit test that covers this functionality. For the integration test, what I would like to see is the behavior tested when startDate is passed in and the user types a value into the input field that is before the startDate value.

tests/integration/components/sl-date-picker-test.js, line 213 [r1] (raw file):
Lets remove this test and restore the unit test that covers this functionality. For the integration test, what I would like to see is the behavior tested when endDate is passed in and the user types a value into the input field that is after the endDate value.

tests/integration/components/sl-date-picker-test.js, line 243 [r1] (raw file):
Lets remove this test and restore the unit test that covers this functionality. For the integration test, what I would like to see is the behavior tested when startDate is passed in and the user types a value into the input field that is before the startDate value and the supplied placeholder text is displayed.

tests/integration/components/sl-date-picker-test.js, line 272 [r1] (raw file):
Lets remove this test and restore the unit test that covers this functionality. For the integration test, what I would like to see is the behavior tested when endDate is passed in and the user types a value into the input field that is before the endDate value and the supplied placeholder text is displayed.

tests/integration/components/sl-date-picker-test.js, line 314 [r1] (raw file):
I had to do something similar for the sl-date-range-picker integration tests but I approached this test differently. I want to talk with you and Jeremy and decide which approach we like better. My thought about the test was to test the behavior from a user interacting with the component instead of setting the values programmatically. So, for instance, to set the date, I would set the monthView/yearView to freeze the calendar so I could use jQuery to select a date, then I would do a click() on that to set that value for the input.

tests/integration/components/sl-date-picker-test.js, line 324 [r1] (raw file):
I had to do something similar for the sl-date-range-picker integration tests but I approached this test differently. I want to talk with you and Jeremy and decide which approach we like better. My thought about the test was to test the behavior from a user interacting with the component instead of setting the values programmatically. So, for instance, to set the date, I would set the monthView/yearView to freeze the calendar so I could use jQuery to select a date, then I would do a click() on that to set that value for the input.

tests/unit/components/sl-date-picker-test.js, line 167 [r1] (raw file):
Are you sure that a this.render() is not needed here and also wrapping the component.trigger( 'willClearRender' ) in an Ember.run() loop? In other tests where we are verifying setting and removing event handlers we do: https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/unit/components/sl-input-test.js#L42-L60 and https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/unit/components/sl-date-range-picker-test.js#L101-L116

Comments from the review on Reviewable.io

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

tests/integration/components/sl-date-picker-test.js, line 72 [r1] (raw file):
The reason for no integration tests for those is that we would affectively be testing bootstrap functionality.

tests/unit/components/sl-date-picker-test.js, line 167 [r1] (raw file):
this.render() is not needed because this.$(  'input.date-picker' ).get( 0 ) will call render. Basically any call to this.$() will cause a render. https://github.com/switchfly/ember-test-helpers/blob/ae46af8788122b62b11bf0aaaceab58cfe16a5e8/lib/ember-test-helpers/test-module-for-component.js#L115

Comments from the review on Reviewable.io

We don't need integration test cases to assert Start and End dates are correctly set on the date picker?
Do not see any unit test case assertions for dependent keys of computed properties

Reviewed 1 of 3 files at r2.
Review status: 1 of 3 files reviewed at latest revision, 29 unresolved discussions, some commit checks pending.

tests/integration/components/sl-date-picker-test.js, line 45 [r2] (raw file):
Testing for the non-presence of something is a never-ending possibility.  Why only look for label?  Why not buttons?  H1s?  The point is if we are testing the default rendering then I would only expect to see assertions for things we expect to see.  Other test cases will exercise the functionality that causes additional, optional items/functionality.   As an aside, the help block was not asserted - only the label.

tests/integration/components/sl-date-picker-test.js, line 201 [r2] (raw file):
Support for action is not listed in the documentation.  Please create an issue regarding this.

tests/integration/components/sl-date-picker-test.js, line 301 [r2] (raw file):
I spoke with Jeff about this approach and it seems it may be missing the mark.  Please reach out to him.

tests/integration/components/sl-date-picker-test.js, line 337 [r2] (raw file):
Jeff may be able to provide some guidance on the approach of this test case as well.

tests/unit/components/sl-date-picker-test.js, line 25 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 31 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 37 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 49 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 61 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 67 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 73 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 79 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 85 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 91 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 97 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 103 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 109 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 115 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 121 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 127 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 133 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 139 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 145 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 151 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 157 [r2] (raw file):
https://github.com/softlayer/ember-style-guide/blob/master/ember-testing.md#specificity

tests/unit/components/sl-date-picker-test.js, line 164 [r2] (raw file):
Shouldn't this test case go further and spy that sendAction() is what is called on the changeDate event?

tests/unit/components/sl-date-picker-test.js, line 184 [r2] (raw file):
Between the assertions against default property values and passing any of the option properties into the component, is this test needed?  Seems the combination of these other two groups of tests cover this scenario.

Comments from the review on Reviewable.io

Reviewed 1 of 3 files at r2.
Review status: 2 of 3 files reviewed at latest revision, 29 unresolved discussions, some commit checks pending.

Comments from the review on Reviewable.io

Review status: 2 of 3 files reviewed at latest revision, 29 unresolved discussions, some commit checks failed.

tests/unit/components/sl-date-picker-test.js, line 167 [r1] (raw file):
The render in https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/unit/components/sl-date-range-picker-test.js#L101-L116 is not needed because of the use `this.$()' while it is needed in https://github.com/softlayer/sl-ember-components/blob/EmberCli-1.13.8/tests/unit/components/sl-input-test.js#L42-L60 because of the lack of it.  Should we standardize this approach, at least between the 3 of these examples?  As it stands right now don't know which one the first one should be changed to as the other 2 references are difference patterns.

Comments from the review on Reviewable.io

Reviewed 1 of 3 files at r2.
Review status: all files reviewed at latest revision, 29 unresolved discussions, some commit checks failed.

Comments from the review on Reviewable.io

Linting is failing

Review status: all files reviewed at latest revision, 29 unresolved discussions, some commit checks failed.

Comments from the review on Reviewable.io

Reviewed 3 of 3 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

tests/unit/components/sl-date-picker-test.js, line 167 [r1] (raw file):
To standardize a pattern, this.render() should only be called when we do not use this.$(). So the first example, we should remove the superfluous this.render call.

Comments from the review on Reviewable.io

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

tests/unit/components/sl-date-picker-test.js, line 167 [r1] (raw file):
I understand when we do and do not need this.render().  What I'm saying is that do we always want to force use of this.$() instead of component.getInput().get( 0 ) for example.

Comments from the review on Reviewable.io

tests/unit/components/sl-date-picker-test.js, line 167 [r1] (raw file):
Ah ok. Looks like we have a mix of .getInput() and this.$( 'input' ) in that test. I think we should be consistent and always use this.$( ).

Comments from the review on Reviewable.io


Use fetch events in parsers for events that are not related to parsing and are related to getting the content of the file

Parsers currently have custom parse events for some actions that can be covered by fetch events.
For example instead of events like parse::<something>::error::not-found or parse::<something>::error::not-specified, we can just have  fetch::missing::<something>.
In general I think the following events should cover most cases.

fetch::end::<resource-type>
fetch::error::<resource-type>
fetch::missing::<resource-type>
fetch::start::<resource-type>

I think having this (or adding these events in parsers) will not only reduce the need to introduce new custom events, and thus, new types, but also make more rules possible and easier to implement.
Also, in some cases as with the web app manifest, it will make things backward compatible with what we have right now

See also: #930

This is now fixed.


Delete associated roles_users rows when user is destroyed

Fixes #8843.
Please include a description of your change & check your PR against this list, thanks!

[x] There's a clear use-case for this code change
[x] Commit message has a short title & references relevant issues
[ ] The build will pass (run npm test)

More info can be found by clicking the "guidelines for contributing" link above.

Thanks will review asap 😇


Restore "CrystalDewWorld.CrystalDiskInfo.KureiKeiEdition 8.15.2 (#124090)"

Reverts #124090
See #167173

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -2145844746
2024-08-11 11:56:01.198 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(267)\WindowsPackageManager.dll!00007FF8BD48A384: (caller: 00007FF8BD48AD01) Exception(1) tid(1c08) 80D02002
2024-08-11 11:56:02.013 [CORE] Download request failed. Returned status: 502
2024-08-11 11:56:02.014 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(148)\WindowsPackageManager.dll!00007FF8BD4843D6: (caller: 00007FF8BD485C49) Exception(2) tid(1c08) 801901F6 Bad gateway (502).
2024-08-11 11:56:02.015 [CLI ] Failed to download, waiting a bit and retry. Url: https://osdn.net/frs/redir.php?m=ipconnect&f=crystaldiskinfo%2F76716%2FCrystalDiskInfo8_15_2KureiKei.exe
2024-08-11 11:57:02.695 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\DODownloader.cpp(267)\WindowsPackageManager.dll!00007FF8BD48A384: (caller: 00007FF8BD48AD01) Exception(3) tid(1c08) 80D02002
2024-08-11 11:57:02.966 [CORE] Download request failed. Returned status: 502
2024-08-11 11:57:02.966 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(148)\WindowsPackageManager.dll!00007FF8BD4843D6: (caller: 00007FF8BD485C49) Exception(4) tid(1c08) 801901F6 Bad gateway (502).

Automated error analysis suggests 80D02002 may mean The operation timed out.
(Automated response - build 887.)


Allow pgcrypto extension to preexist

The CREATE EXTENSION query requires superuser privileges, which means that the Firezone container may not be allowed to execute it when accessing an externally hosted database, resulting in the database failing to initialise properly.
One potential workaround to this problem is to have the database admin ascertain that the pgcrypto extension is already present and ready for use, prior to starting the Firezone container for the first time.
Unfortunately, however, this currently fails in the following manner:
14:42:44.731 [info] execute "CREATE EXTENSION pgcrypto"
** (Postgrex.Error) ERROR 42710 (duplicate_object) extension "pgcrypto" already exists

Adding the IF NOT EXISTS condition to the CREATE EXTENSION query should allow it to succeed.

Pull Request Test Coverage Report for Build c35a9ef1d507ba33bc5be02f7aca39453c14971e-PR-1114

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.125%

Totals

Change from base Build a994f3f3503510da58a4f1fd52e27f2afb562f26:
0.0%

Covered Lines:
1181

Relevant Lines:
1786

💛  - Coveralls


RSA file generation & Self-Destruction

R5: Deposit of Keys in a temporary Directory
Keys should be generated in a file, and should self-destruct after a period of time.

Not sure about the self-destruction thing... We'll see how it goes. In order to make something like that work, I'd need to start a background thread of some nature and set a timer for it to close. Come to think of it, it seems doable, but how does multithreading work in C++ ????

Not sure about the self-destruction thing... We'll see how it goes. In order to make something like that work, I'd need to start a background thread of some nature and set a timer for it to close. Come to think of it, it seems doable, but how does multithreading work in C++ ????

Moving this into a separate ticket...


Remove gem eco

Gem eco hasn't been maintained since 2015 however Peatio has several important templates which are used on the "Trade" page. I believe the best solution will be to migrate eco to ejs.


TypeScript interface

Is there any plan to ship a TypeScript interface with the package?

My PR to fix this issue - #42


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.8 to before v5.15.11",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d8355240cf8fb8b9e002b5c8458578435cea85c2",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4f4a353f6fe033807cd026a5de81c67469ff19b0"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "d8355240cf8fb8b9e002b5c8458578435cea85c2",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "4f4a353f6fe033807cd026a5de81c67469ff19b0",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: hns3: fix use-after-free bug in hclgevf_send_mbx_msg\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.11 by commit 4f4a353f6fe033807cd026a5de81c67469ff19b0, it was introduced in version v5.8 by commit d8355240cf8fb8b9e002b5c8458578435cea85c2. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002741


SparkSQL should use PyHive SQL generation if available

SparkSQL officially speaks Hive.  I think we're currently sending it MySQL and possibly through the wrong method.  If we have pyhive install we should probably use that instead.

Whoops, this should be a Blaze issue.

closing as a blaze issue


Add CLIPPER_INPUT_TYPE to k8s environment

It was always using the default "doubles" input_type
p.s. we are now able to successfully serve predictions using clipper on AWS using kops k8s!

Can one of the admins verify this patch?

Jenkin's test this please

jenkins test this please

That's great to hear! Will merge once the tests pass.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/761/
Test PASSed.

jenkins okay to test

jenkins test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/763/
Test PASSed.


[Bug Report] dropdown.d.ts lacks hide-timeout and show-timeout

Element UI version
2.12.0
OS/Browsers version
windows10
Vue version
2.6.10
Reproduction Link
https://jsfiddle.net/w1qxdfrc/1/
Steps to reproduce
hover link
What is Expected?
showTimeout,hideTimeout补全
What is actually happening?
https://github.com/ElemeFE/element/blob/dev/types/dropdown.d.ts 无showTimeout,hideTimeout

@ac88 pe welcome.


[Storage] [STG93] Missing docstring for upn

When we moved it to _get_path_properties for 1000IQ code re-use, I 0IQ forgot to add the docstring (and forced merge since it was only a docstring change between last change 😄 )

/check-enforcer override


Handling 401 on GET and/or manually re-queueing

I'm trying to handle login timeouts (and idling) by prompting an unlock screen overlaid to the page that's shown through an HttpInterceptor on 401 requests
I've also queued the failed requests to send them again manually since your plugin doesn't do that for GET but I must've missed something cause the resent request doesn't seem to trigger the plugin to update the data/promise/whatever I've linked to it... how can I handle this?

Hi @TheMdk!
I have not contributed at to this repository, but I'd like to try to help. Can you recreate this problem in a jsfiddle (or any other service) so we can see how you are hooking up angular-cached-resource with a manual queue for failed requests to be sent as soon as the user re-logins?


Feature request: namecheap_nameserver resource to register new nameservers

I'd like to also manage custom nameservers w/ terraform, i.e. use the following API: https://www.namecheap.com/support/api/methods/domains-ns/create/.
However, this provider does not yet support this. Are there any plans to add this?

I do not mind taking this. will open a PR in the coming days.
can somebody assign this to me?

Thanks for your feature suggestion!
We'll consider this request in our next discussion round. While I can't provide a definitive timeline right now, please know that l make sure to keep you updated with the status here.

I added full support over the last couple of days for nameservers in the namecheap go sdk.
I will take a look in the coming days into implementing this resource.
@vetal2409 feel free to assign me.


check_on_pr.py fails with KeyError: 'token'

Traceback (most recent call last):
  File "tools/profiling/ios_bin/binary_size.py", line 150, in <module>
    check_on_pr.check_on_pr('Binary Size', '```\n%s\n```' % text)
  File "tools/profiling/ios_bin/../../run_tests/python_utils/check_on_pr.py", line 116, in check_on_pr
    'summary': summary,
  File "tools/profiling/ios_bin/../../run_tests/python_utils/check_on_pr.py", line 67, in _call
    'Authorization': 'Bearer %s' % _access_token(),
  File "tools/profiling/ios_bin/../../run_tests/python_utils/check_on_pr.py", line 57, in _access_token
    'token': resp.json()['token'],
KeyError: 'token'

https://source.cloud.google.com/results/invocations/04352595-7beb-4d90-9393-719ccfc95f33/targets/grpc%2Fcore%2Fpull_request%2Fmacos%2Fgrpc_ios_binary_size/log

CC @lidizheng

I'm betting this was a transient error on Github's side. We should probably add a call to raise_for_status for a more descriptive error message.

@rmstar  Thank you for pointing out. I checked latest failures of grpc/core/pull_request/macos/grpc_ios_binary_size, and check_on_pr does introduce flakiness into the test.
https://source.cloud.google.com/results/invocations/04352595-7beb-4d90-9393-719ccfc95f33/targets/grpc%2Fcore%2Fpull_request%2Fmacos%2Fgrpc_ios_binary_size/log
https://source.cloud.google.com/results/invocations/89e0c5d4-fb5c-4408-974e-2600450565bc/targets/grpc%2Fcore%2Fpull_request%2Fmacos%2Fgrpc_ios_binary_size/log
https://source.cloud.google.com/results/invocations/6ca1d1e5-98cb-4586-ae9c-1ce6874e1940/log
It might due to Github API error as suggested by @gnossen. I think I will add a retry mechanism to make it more robust, also add more logging.


Clone tables instead of creating blank temporary tables for engines that support it

When iterating in development environment today, the platform creates temporary tables for new snapshots that reuse previous versions to avoid affecting tables that can be used in prod environment.
Temporary tables help ensure isolation but provide a limited preview to a user.  To ensure support for complete previews we can use the table cloning feature available in some engines (eg. Snowflake, Delta Lake, etc.)
For new snapshots, Instead of creating new temporary tables, we should instead clone the existing tables while updating their schemas to match the schemas of these new snapshots.
There's still an open question of how to keep clones that fell behind up to date in various development environments.

implemented


[CT-3456] Add additional attributes to RelationConfig for use in adapter implementations

RelationConfig is used to configure create_from method, as we did this against postgres the fields in the class are applicable to that adapter. We need to analyze other adapters and identify missing fields we need.


Implement a check on RedditBase for unset STR_FIELD attribute values

Fixes # (provide issue number if applicable)
Fixes #1552
Feature Summary and Justification
This feature provides a check for unset STR_FIELD attribute values. It also adds a few private parameters, which are mentioned in the commit for RedditBase.
References

#1583
https://github.com/praw-dev/praw/pull/1583#issuecomment-729027347

This approach looks great assuming all the tests continue to pass.

@iamsharmaapoorv do you think this is an optimal way to ensure that empty strings aren't passed through?

There's still a few pending comments I left yesterday that look like they haven't been addressed.

There's still a few pending comments I left yesterday that look like they haven't been addressed.

I only see two comments from you, and three from @LilSpazJoekp.

I guess it was just the one I pinged you about.

@PythonCoderAS  sorry for the delay, I only get to touch my personal laptop at weekends. This looks like a good upstream solution. Thanks for keeping me in loop.


Semantic block delimiter should allow braces on procedural one-liners

I've seen lots of Ruby code that uses braces around one-line blocks even when the code is not using the result of the block, i.e., when it's "procedural" rather than "functional".  It's often appeared in code that was otherwise great, and I've never seen anybody object to this.
Except Rubocop.  :-)
The choices of block delimiter style seem to be:

line_count_based: One-liners have braces; everything else has do-end, even if functional.
semantic: Functional has braces; everything else has do-end, even if one-liner.
braces_for_chaining: Chained functional blocks, and one-liners, have braces; everything else has do-end, even if functional (when not chained).

There does not seem to be a choice that means "functional blocks (whether chained or not), and one-liners, have braces, even if procedural, and everything else has do-end."  That is my preferred style.
What I'd like to see is that semantic allows procedural one-liners to have braces.  This may be controlled by another configuration option, or always.
Again, I'll try to Make It So myself, ideally this month to count towards a Hacktoberfest shirt.  :-)

I've started working on this.  In the interests of keeping semantic mode purely semantic, at least as an option, I'm taking the tack of making "allow braces on procedural oneliners" an additional config option.

Heads up that I roundaboutly forked and implemented this behavior in the standard gem here: https://github.com/testdouble/standard/blob/master/lib/standard/cop/semantic_blocks.rb
Would love for this (and any other) cops standard shakes loose to wind up upstream in rubocop, though

This would be really great. Here are examples that the semantic style that should probably use { }:
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

# a factory_bot factory:

factory :user do
  name { |n| "James#{n}" }
end

@jherdman Yes, I believe that's how StandardRB behaves currently


Describe best practices for testing

Maybe the style guide should name some best practices for (integration) testing?
I found particularly the following things very helpful:

official documentation
validate sys.exit()
simulate command line arguments in sys.argv
validate content written to stdout and stderr based on contextlib.redirect_stdout and contextlib.redirect_stderr which are part of the std since 3.4, 3.5
In case you want to create integration tests for cli applications, consider prysk

As discussed with @ckunki, this will be closed. A potential other location for this information is being looked for.


readme: Updating README

[IN PROGRESS]
I would like to propose a new README page on Github. The current one is a big wall of text which is already covered in the documentation.
I think we can do something smaller and cleaner just by following some examples online.
Sure, it's a visual thing but I personally think this can help attract more people and gives a "cleaner" look!
Here's what I propose, following these repos as reference: link 1, link 2, link 3
Put the NuttX logo on top
Add badges showing status of build, docs, version, etc
Quick intro to what NuttX is
Topics on contributing, documentation and getting started
I would love to hear some more ideas from the community, please feel free to add them here.

+1 for simplifying the readme. The big wall of text is not inviting for new users.
If we change nuttx/readme then nuttx-apps/readme should also be changed to a similar look. But for nuttx-apps/readme I think not everything is in Documentation now

There's a chain icon on the NuttX logo appearing for me. Does anyone know why it's there? I can't see it on the PNG.

There's a chain icon on the NuttX logo appearing for me. Does anyone know why it's there? I can't see it on the PNG.

@fdcavalcanti try with
`

`

There's a chain icon on the NuttX logo appearing for me. Does anyone know why it's there? I can't see it on the PNG.

@fdcavalcanti try with

Thanks, it worked! Really starting to look good.

I think we can include a field about the license
for example:
## License
The code in this repository is all under either the Apache 2 license, or a
license compatible with the Apache 2 license.  See the  [LICENSE file](https://nuttx.apache.org/docs/latest/introduction/licensing.html) for more
information.

@fdcavalcanti should we move the original README.md to the related documentation section?

@fdcavalcanti should we move the original README.md to the related documentation section?
Do you mean something like nuttx/Documentation/legacy_README.md? Maybe an actual page?
I mean, its all versioned anyway. Not sure what is available on the README that can't be found on the actual documentation.

I think we can include a field about the license for example:
## License
The code in this repository is all under either the Apache 2 license, or a
license compatible with the Apache 2 license.  See the  [LICENSE file](https://nuttx.apache.org/docs/latest/introduction/licensing.html) for more
information.

I think we can improve this text. Maybe more details regarding other licenses that we see on menuconfig? Updated with this text for now.

Please check this new commit. Added the legacy README file to Documentation/ and it is available in Introduction/Resources.
I'm not sure I like this format very much.. would appreciate some feedback.

Please check this new commit. Added the legacy README file to Documentation/ and it is available in Introduction/Resources. I'm not sure I like this format very much.. would appreciate some feedback.

it's better than remove the old readme directly at least.:).

This PR introduced new warnings to the doc build:
/home/raiden00/git/RTOS/nuttx/nuttx/Documentation/legacy_README.md:684: WARNING: duplicate label introduction/resources:installation, other instance in /home/raiden00/git/RTOS/nuttx/nuttx/Documentation/introduction/resources.rst
/home/raiden00/git/RTOS/nuttx/nuttx/Documentation/legacy_README.md:684: WARNING: duplicate label legacy_readme:installation, other instance in /home/raiden00/git/RTOS/nuttx/nuttx/Documentation/legacy_README.md
looking for now-outdated files... none found
pickling environment... done
checking consistency... /home/raiden00/git/RTOS/nuttx/nuttx/Documentation/legacy_README.md: WARNING: document isn't included in any toctree


ML-270 Implementing Yinyang K-Means Clustering Algorithm

Project : Implementing Yinyang K-Means Clustering Algorithm in HPCC
Contributor : Lily Xu
This project is implementing Yinyang K-Means Clustering Algorithm in ECL and added to the HPCC-Systems Machine Learning Library.  The Yingyang algorithm is an exact and thus 'drop-in' replacement for the standard k-means clustering measure.
The abstract from the principle paper by Ding, Zhao, Shen, et al. follows:
"This paper presents Yinyang K-means, a new algorithm for K-means clustering. By clustering the centers in the initial stage, and leveraging efficiently maintained lower and upper bounds between a point and centers, it more effectively avoids unnecessary distance calculations than prior algorithms. It significantly outperforms prior K-means algorithms consistently across all experimented data sets, cluster numbers, and machine configurations. The consistent, superior performance—plus its simplicity, user-control of overheads, and guarantee in producing the same clustering results as the standard K-means does—makes Yinyang K-means a drop-in replacement of the classic K-means with an order of magnitude higher performance."[1]
For the detail  of Yinyang K-Mean algorithm, please refer to the paper.
[ 1 ] Ding, Y., Zhao, Y., Shen, X., Musuvathi, M., & Mytkowicz, T. (2015). Yinyang k-means: A drop-in replacement of the classic k-means with consistent speedup. In Proceedings of the 32nd International Conference on Machine Learning (ICML-15) (pp. 579-587).
JIRA Ticket : ML-270
Link: https://track.hpccsystems.com/browse/ML-270?jql=text ~ "yinyang"

@johnholt Please review

Hi Richard and John,
I am wondering shall I update the commit that I made month ago?
I am testing on the implementation these days and made few changes to
improve the performance.
Best,
Lily
On Wed, Sep 21, 2016 at 10:16 AM, Richard Chapman<EMAIL_ADDRESS>wrote:

@johnholt https://github.com/johnholt Please review
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hpcc-systems/ecl-ml/pull/251#issuecomment-248625572,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKkCEaQwEatdboNQmH1eHRndCxldcrclks5qsTwzgaJpZM4Jin1q
.

@lilyclemson Yes, please do

Updated the code and pushed.
Commit Message -- ' add dPass'.
SHA: f9df576
https://github.com/hpcc-systems/ecl-ml/pull/251/commits/f9df5762b1c7b6719919f20bfb3ad28b6720beee
Thanks.
On Thu, Sep 22, 2016 at 7:11 AM, Richard Chapman<EMAIL_ADDRESS>wrote:

@lilyclemson https://github.com/lilyclemson Yes, please do
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hpcc-systems/ecl-ml/pull/251#issuecomment-248873091,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKkCETGDPIB_rqnsCMWuZkPyFvnmbCP_ks5qsmJzgaJpZM4Jin1q
.

All the experiment dataset are supposed been pre-processed/cleaned. So
there should be no duplicate records in the Gt.
On Mon, Jan 9, 2017 at 9:03 AM, johnholt<EMAIL_ADDRESS>wrote:

@johnholt commented on this pull request.
In ML/Cluster.ecl https://github.com/hpcc-systems/ecl-ml/pull/251:

SELF := input;

END;

//Add an offset number to id if necessary to make sure all ids are different

SHARED iOffset:=IF(MAX(d01,id)>MIN(d02,id),MAX(d01,id),0);

// Convert the input centroid dataset to our internal structure, then

// iterate as many times as requested by the user.
// NOTE: Values will stop being added once convergence is determined
// to have been reached.
d02Prep:=PROJECT(d02,TRANSFORM(lIterations,SELF.id:=LEFT.id+iOffset;SELF.values:=[LEFT.value];SELF:=LEFT;));

// set the current centroids to the results of the most recent iteration

dCentroid0 := PROJECT(d02Prep,TRANSFORM(Types.NumericField,SELF.value:=LEFT.values[1];SELF:=LEFT;));

//***********************************************Start OF Gt*****************************************************

//To Do :Put the Group concept into consideration for future impelemenation ( t >1 )

Gt := DEDUP(PROJECT(dCentroid0, TRANSFORM(Mat.Types.Element,SELF.x := LEFT.id; SELF.y :=1; SELF.value := LEFT.value;)),x);

@lilyclemson https://github.com/lilyclemson This definition requires
that the records with the same x value that are to be eliminated are
adjacent to each other. Is it ever correct to have two records in the Gt
recordset with the same x and y values?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hpcc-systems/ecl-ml/pull/251, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKkCER-RIljHi2jXNQNLYnOjcqHtSL1cks5rQj4xgaJpZM4Jin1q
.

How difficult or unlikely is it that the data will not have duplicate records?
If it is unlikely (usually because it is difficult to make happen) to have duplicates, you will just need to fix the conflicts.
If it is likely (usually because the user needs to do something unusual to prevent the duplicates), you need to either perform an initial check and raise an error (use an ASSERT function with a fail clause) or handle the duplicates in an appropriate manner.

Actually the definition of 'Gt' is not fully implemented.  Below is the
full implementation of the initialization of Gt:
//run Kmeans on dCentroid to get Gt
nt := n; // the maximum number of iterations
tConverge := nConverge; // the converge threshold
KmeansDt :=ML.Cluster.KMeans(dCentroid0,dCentroidGroup,nt,tConverge);
//the assignment of each centroid to a group;
Gt := TABLE(KmeansDt.Allegiances(), {x,y},y,x); //the Allegiances()
function is to aggregate all the data points belonging to each centroids.
On Tue, Jan 10, 2017 at 1:02 PM, johnholt<EMAIL_ADDRESS>wrote:

How difficult or unlikely is it that the data will not have duplicate
records?
If it is unlikely (usually because it is difficult to make happen) to have
duplicates, you will just need to fix the conflicts.
If it is likely (usually because the user needs to do something unusual to
prevent the duplicates), you need to either perform an initial check and
raise an error (use an ASSERT function with a fail clause) or handle the
duplicates in an appropriate manner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hpcc-systems/ecl-ml/pull/251#issuecomment-271650042,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKkCEUxFbjDWQe9VZ0dhCROb0ZvkTuQBks5rQ8fRgaJpZM4Jin1q
.


Add cli_arguments operation to the Application CE

Adds the cli_arguments operation to the Application CE.
These flow into CreateDefaultBuilder(args) and enable default functionality like --urls and the CommandLine configuration source.
Another road to take could have been to let application return string array -> IWebHostBuilder and pass the args into it through run. However as that's a breaking change I thought to keep it like this.

LGTM


ERR unknown text editor: 415ed667-a322-4c86-8b8c-c2e159083856

open a notebook
f1 > restart extension host
click inside the notebook cells
💥  the error below happens

ERR unknown text editor: 415ed667-a322-4c86-8b8c-c2e159083856. known editors:  : Error: unknown text editor: 415ed667-a322-4c86-8b8c-c2e159083856. known editors:
	at ExtHostNotebookController.$acceptEditorPropertiesChanged (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebook.js:333:23)
	at RPCProtocol._doInvokeHandler (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:348:27)
	at RPCProtocol._invokeHandler (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:333:45)
	at RPCProtocol._receiveRequest (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:260:32)
	at RPCProtocol._receiveOneMessage (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:188:26)
	at /Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:69:52
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:490:38)
	at BufferedEmitter.fire (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:375:35)
	at /Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/extensionHostProcessSetup.js:146:41
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:490:38)
	at BufferedEmitter.fire (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:375:35)
	at PersistentProtocol._receiveMessage (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:654:41)
	at /Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:510:83
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:490:38)
	at ProtocolReader.acceptChunk (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:189:37)
	at /Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:158:61
	at Socket.listener (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/node/ipc.net.js:33:40)
	at Socket.emit (events.js:315:20)
	at addChunk (internal/streams/readable.js:309:12)
	at readableAddChunk (internal/streams/readable.js:284:9)
	at Socket.push (internal/streams/readable.js:223:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

@jrieken is it expected for the notebook tab to just close upon running the command to restart the extension host?

Yeah, that's the new thing. We don't know when (iff ever) the extension returns so we play save and close all notebook editors from that extension


[Video] Make compress/upload cancelable

Adds an abort controller so that the upload/compression is cancellable

Noting this doesn't cancel uploads at least on native. Can handle separately.


Close autofill survey

Task/Issue URL: https://app.asana.com/0/608920331025315/1207370057643957/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4576  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite


how to train casanovo v4 on huge dataset like massive-kb from scratch?

Hi,
I remeber that you mentioned you trained casanovo on massive-kb dataset with 1 epoch only, which gets the massive-kb pre-trained model.

If I also want to train on a huge dataset like massive-kb from scratch (I only need a subset of modifcations from massive-kb), is it also best to train only 1 epoch?

What is your suggestion to adjust the config.yaml parameters to train this 1 epoch? I assume it should be quite different from current setting for training multiple epoches until convergence.
e.g.
warmup_iters: 100_000,
max_iters: 600_000,
train_batch_size: 32,
learning_rate: 5e-4,
weight_decay: 1e-5,
train_label_smoothing: 0.01
What is your strategy of training huge dataset on casanovo? Is it possible to provide the config.yaml for this strategy (or at least your values for the above 6 variable combinations)?

Thanks a lot in advance!
Best regards

Rather than a specific number of epochs (or iterations for such a large training dataset), I recommend that you determine how long to train based on a sequence-disjoint validation set. That's also what we did when training on MassIVE-KB, and based on the validation performance we empirically noticed that the model converged already prior to having gone through a single full epoch.
No, these are the settings that we consistently use to train the various models. No special change needed.

Thanks a lot for your advice!
If I would like to fine-tune your massivekb pretrained model for my specific data, I simply need to continue train casanovo with your model and my own data (my data might be slightly different from massivekb) until it performs best on my own validation set?

Yes, that's right.


Video resolution

How do I set the video resolution when recording with the record function? I know that there is an optional parameter resolution  for the scene, but it does not have an effect on the video resolution.
For example:
using Makie

 scene = Scene(resolution = (1000,1000)) # Does not effect the video resolution
 f(t, v, s) = (sin(v + t) * s, cos(v + t) * s)
 time_node = Node(0.0)
 p1 = scatter!(scene, lift(t-> f.(t, range(0, stop = 2pi, length = 50), 1), time_node))[end]
 p2 = scatter!(scene, lift(t-> f.(t * 2.0, range(0, stop = 2pi, length = 50), 1.5), time_node))[end]
 points = lift(p1[1], p2[1]) do pos1, pos2
     map((a, b)-> (a, b), pos1, pos2)
 end
 linesegments!(scene, points)
 N = 150
 record(scene, "interaction.mp4", range(0, stop = 10, length = N)) do i
     push!(time_node, i)
end

Resizing the window during the recording gives weird artefacts.

Can you give some additional details on how you run this? If I execute this (and also if I change the resolution), it does get reflected in the output!

Ah okay, if I run it through a normal terminal the set resolution does indeed make a difference.
I was running in in Atom and the same plot was shown in the plot pane as well as in a seperate window. I guess the plot pane restricted the size to whatever is the maximal size of the plot pane.


Bug #39

Field components now assert validity (and update their state) of values passed to them through props.value every time.

Coverage increased (+0.001%) to 99.469% when pulling 463a9648c361025028b640ce527b558a8d36e902 on bug-#39 into 1af6e8af0a76ab63785ad11d8e034ceb2e711c79 on release-1.2.1.


Add button to reset passcode

I did some work on #63:
The PR adds a new button to the <TeamDisplayCard />.
Clicking it will generate a new passcode, patch the teams juice-shop deployment with the new hash and return the passcode to the user. The passcode will then be displayed via the old but modified <PasscodeDisplayCard />.
Looking forward to your feedback!

Wow nice 🚀
Will have a closer look later 👍

Merged and released with v3.8.0
Thanks again, much appropriated 🙌
(I've added the hacktoberfest-accepted label to the pr in case you are participating in that)

Great, thanks! I started to extend the reset-password endpoint for the admin user too. However, I couldn't really find space in the admin table to display the new code 😄
Perhaps we can track that in #63


ValueError: invalid literal for int() with base 10: '3 (Ubuntu 10' when connecting

Here the full stack trace:

Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.6/dist-packages/postgresql/init.py", line 94, in open
c.connect()
File "/usr/local/lib/python3.6/dist-packages/postgresql/driver/pq3.py", line 2427, in connect
self._establish()
File "/usr/local/lib/python3.6/dist-packages/postgresql/driver/pq3.py", line 2559, in _establish
self.version_info = pg_version.normalize(pg_version.split(sv))
File "/usr/local/lib/python3.6/dist-packages/postgresql/versionstring.py", line 28, in split
vlist = [int(x or '0') for x in v[:-1]]
File "/usr/local/lib/python3.6/dist-packages/postgresql/versionstring.py", line 28, in
vlist = [int(x or '0') for x in v[:-1]]
ValueError: invalid literal for int() with base 10: '3 (Ubuntu 10'

This issue has already been reported here: https://github.com/python-postgres/fe/issues/93
The problem is that on Postgres 10 Ubuntu adds the Ubuntu Version to the Postgres Version string which py-postgresql can't handle.
My version string looks like this:
10.3 (Ubuntu 10.3-1)
I have a fix ready and will attach it here.

Already fixed in this PR: https://github.com/python-postgres/fe/pull/94

I think this issue is best handled using a patch managed by the packaging system that made the changes to the server software.

@jwp
Your explanation about "packaging system" is vague. What a database user can do in case of this error? The problem happens on client side. Patching the database is not available to users.

Simple fix: Use psycopg2-binary :-(

@ThomasChr I use it in some projects, but this library has several advantages which are very useful and missing in psycopg2.

Thats leaves only the choise to manually patch the library everytime you install it. Or maybe we can convince @jwp to patch it!


backend: config/loaders.yaml

When I run poetry run generate I get
FileNotFoundError: [Errno 2] No such file or directory: 'config/loaders.yaml'
Where can I find information on this file?

config/loaders.yaml is usually generated by create-llama - what configuration did you use?

I created the project without any example data.

the loader.yml config file is generated dynamically depending on the data source you pick. If you select no data source then you don't need to run poetry run generate


Create a library for the segment calculator

The aim of this PR is to convert the implementation into a nodeJS package that can be integrated in server side script. This can be used to check the number of segments before sending the message, in order to contain costs.
This PR includes:

Move the docs to the docs folder
Move the implementation of the SegmentedMessage class to src and change it to typescript
Add script for transpile and release of the package to npm
Add test scripts in tests
Add scripts to transpile the package code for browser (through webpack)

Fix #7

@HugoCrd this is a first draft of the implementation. I added a minimal README to document the main class.
I like the idea of the getIncompatibleEncodingCharacters method, and I'm going to work on it next.
It'd be good if you could have a look at this and let me know what you think.

That's great! I love that you could divide the lib into simpler TS classes. Way easier to read.
@vernig yes getIncompatibleEncodingCharacters is very handy on our side, it helps our customers understand why they're suddenly using 3 segments instead of 1. I totally get why you'd like to add that later on though.

Thanks @HugoCrd @micaswyers. I merged the PR. I'll work to publish the package on npm as well as adding the getIncompatibleEncodingCharacters and the Twilio Smart Encoding option.


mxnet/tensorRT docker image coredumps

Description
The docker image mxnet/tensorrt which integrates mxnet with tensorrt core dumps. docker image has TRT 4.0, python3.5, cuda9 and MxNet 1.3.
Environment info (Required)
AWS base DLAMI on G4 instance. DLAMI version is 19.2 and OS is ubuntu. Installed docker 19.2 and nvidia docker on top of it.
first install docker:
https://docs.docker.com/install/linux/docker-ce/ubuntu/
there is one issue with a workaround: https://github.com/docker/for-linux/issues/813
sudo apt-get install runc=1.0.0~rc7+git20190403.029124da-0ubuntu1~16.04.4
sudo apt-get install docker-ce
then install latest nvidia docker (which requires docker 19.03)
https://github.com/NVIDIA/nvidia-docker
then pull the image
$ docker run --gpus all -it mxnet/tensorrt bash
$ cat /proc/cpuinfo | grep flags
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc aperfmperf tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single kaiser fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx avx512f rdseed adx smap clflushopt clwb avx512cd xsaveopt xsavec xgetbv1 ida arat pku
I can provide more details if needed.
Error and steps to reproduce
I followed the python scripts on this page for mxnet/tensorRT integration.
https://github.com/apache/incubator-mxnet/blob/8004a027ad6a73f8f6eae102de8d249fbdfb9a2d/docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
[01:51:10] src/c_api/c_api_executor.cc:464: TensorRT not enabled by default.  Please set the MXNET_USE_TENSORRT environment variable to 1 or call mx.contrib.tensorrt.set_use_tensorrt(True) to enable.
Warming up MXNet
Segmentation fault (core dumped)

Who owns the Docker images at https://hub.docker.com/u/mxnet ? The tensorRT hasn't been updated since a year.

@lanking520 assign @larroy
Pedro, please add to the backlog for CI enhancements to build the docker containers

ok

It should be possible to fix this by extending https://github.com/apache/incubator-mxnet/pull/16547 ?


Ui fix search

Fix #227 :

In home page: allign left right dashboards with top nav
Add logout and show profile option in topnav user image.

Live version at: http://<IP_ADDRESS>:3001/

Still now timeline for me.

[x] Adds logout and show profile options
[x] Left right dashboards aligned
[ ] Missing content of tweets from people you follow (waited for 10 minutes to load the data)

Reviewed.


Default config change with proxy.config.http.negative_revalidating_enabled

Since @randall is out, I am making the documentation change for #4123

[approve ci docs]

[approve ci autest]


Autohide for popup should be changed

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Currently if label selected in dropdown is inside of bounds of popup, popup stays open allowing annotator to choose labelling method pressing [Shape] or [Track] buttons:

But if selected label is beyond bounds of popup, it hides. Annotator has to open popup once again to choose labelling method by pressing [Shape] or [Track] buttons.:

Expected Behaviour

In both cases popup should not hide allowing annotator press [Shape] or [Track] buttons.
Current Behaviour

Popup hides unexpectedly. Annotator has to open popup again.
Possible Solution

Possible solution: if selected labels is inside bounds of popup, behaviour stays the same - popup hides. If selected label is beyond bounds of popup, it stays open until user presses [Shape] or [Track] buttons or until user moves mouse so that mouse pointer goes beyond right edge of popup (mouse y coordinate become greater then popup's greatest y coordinate).
Steps to Reproduce (for bugs)

Look gifs attached.
Context

Your Environment

Git hash commit (git log -1): 226c2f2
Docker version docker version (e.g. Docker 17.0.05): 20.10.2
Are you using Docker Swarm or Kubernetes? n/a
Operating System and version (e.g. Linux, Windows, MacOS): n/a
Code example or link to GitHub repo or gist to reproduce problem: n/a
Other diagnostic information / logs: n/a

Next steps
n/a

Duplicate of #2230

Duplicate of #2230

Duplicate of #2230

Yes, but #2230 is about different popups.

Duplicate of #2230

Yes, but #2230 is about different popups.

Any plans to fix?

Any plans to fix?

Yes, we have plans to fix it.

Yes, we have plans to fix it.

Yes, we have plans to fix it.

Create! Does it fit next release?

Yes, we have plans to fix it.

Create! Does it fit next release?

We will try to implement it earlier than in next release. It will be available in develop branch

We will try to implement it earlier than in next release. It will be available in develop branch


Add Profiles, Relationships and Subspaces CosmWasm bindings handlers

Once we have the first, stable version of the Desmos-bindings (FKA desmos-std) rust packages we then can add the necessary bindings handlers that will take care of correctly routes the desmos messages and queries coming from contracts.
This is a binding example in one of our actual branches dedicated to smart contracts:
https://github.com/desmos-labs/desmos/blob/leonardo/contracts-tests/x/profiles/wasm/querier.go

Close this because it has been implemented


Introduce new base layer for instrumentation.

Primary goal is to enable timer profiling of pFIO.  This layer should have no external dependencies except possibly gFTL and gFTL-shared.   In particular, we do not want to induce a dependency in pFIO on ESMF.

Closing.   Partially completed in other ticket that integrated new timers in v2.1


add sample IAM permission

add sample IAM permission needed for the controller while Restricted the permissions where ever possible.
TODO: the permissions can be further scoped down when the vpcID / clusterName can be provided, we should document how to further scope down permissions.

Do we have write up on how to further scope down when vpcID / clusterNam ?


Fix: MD023 Doc: exception for lists

Fix
Subject
MD023 Documentation
Object
Should state the exception for lists
Exemple
- ## this header still complies with MD023

Comment Reply from @DavidAnson:

What exception for lists are you referring to?

See this issue's description  @ Object/Exemple

Thanks for the edit. It's the same if they are nested in a blockquote. I can clarify that in the documentation.

Comment Reply from @DavidAnson:

⋯ It's the same if they are nested in a blockquote ⋯

Can you provide an example?

Yes, this is not reported as an error:
> # Heading


Make it display correctly in firefox 72.0.1 and chrome 79.0

To address issue #107

Thanks @hchiam 👍


fix: return only public properties for form

Summary | Résumé
There is no issue for this PR.
The getTemplateByID request being made for the forms page was returning non-public form config data. This change sanitizes the data by calling onlyIncludePublicProperties() on the form, returning only the properties that can safely be sent to the browser when being requested by an unauthorized user (ie: someone filling out the form).

Test instructions | Instructions pour tester la modification

Load any form into the browser, as if you were going to fill it out.
Observe in the browser Developer Tools / Network tab, that the data being sent from the server does not include non-public properties, such as submission, or internalTitleEN, among other such properties.
It should include default values for displayAlphaBanner and securityAttribute, even if they are not present in the formConfig saved in the database

Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[x] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[x] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[ ] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[ ] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[x] Have you modified the change log and updated any relevant documentation?
[x] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

The Cypress tests were failing because getServerSideProps was passing an undefined object to onlyIncludePublicProperties which caused the server-side code to crash.
I refactored and added in Typescript declarations so it would be easier to see.


Update Arch Linux install scripts

Do we think it would be a good idea to make this into a custom ISO builder via a b script tool?


Enable getting chart for specific date

Maybe !"chart TSLA -date 2020-01-01

Great suggestion, were you thinking of having this date to be the middle (time axis) of the chart?

I was thinking the chart would end at the specified date.
The date specified would be the rightmost bar in the chart.


Wrong JQuery import

In "Backbone.js Dependencies" section index.html  should import jquery-2.1.4.js, not jquery.js.

@skrushinsky I see jquery.js in the code and in the text so jquery.js is more correct.


Error when annotation is enabled

Issue
I tried enabling annotations, however, I get the following error. Please could you let me know what I can do to make annotations work. Thanks.
Log entries
(node:1) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'stringToGlyphs' of null
at Object.t.measureText (/home/node/app/bundle.js:544:24375)
at Object.t.processTextPath (/home/node/app/bundle.js:544:23398)
at fillText (/home/node/app/bundle.js:702:199457)
at /home/node/app/bundle.js:702:190245
at Array.map ()
at Object. (/home/node/app/bundle.js:702:190152)
at /home/node/app/bundle.js:702:189268
at Object.next (/home/node/app/bundle.js:702:189373)
at o (/home/node/app/bundle.js:702:188087)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)
(node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
Installation details

Running in Docker on QNAP TS-451+
Running the latest release 3.0.0

Docker Compose
deepstackai-trigger:
container_name: deepstackai-trigger
image: danecreekphotography/node-deepstackai-trigger:latest
hostname: deepstackai-trigger
networks:
- qnet-dhcp-eth0-3d3dab
ports:
- 4242:4242
environment:
- TZ=Europe/London
volumes:
- /share/CCTV/AI_Input:/aiinput
- /share/Containers/DeepStackAI_Trigger/config:/config
- /share/Containers/DeepStackAI_Trigger/node-deepstackai-trigger:/node-deepstackai-trigger
restart: always

I thought I already had a closed bug for this but I guess not. This is fixed as part of my work for #260, but hasn't made it out to the latest build yet. I'm glad you hit it though, I thought I was the only one!
Would you mind testing the fix to see if it resolves the issue? Change your docker-compose.yaml to point to danecreekphotography/node-deepstackai-trigger:issue260 instead of danecreekphotography/node-deepstackai-trigger:latest, do a docker-compose pull, then docker-compose up. That should fix it.

I came across the same issue.  It only appeared once I added the "annotateImage": true, into the telegram configuration (in triggers.json).  I'm was the danecreekphotography/node-deepstackai-trigger:dev image.
I have tested with danecreekphotography/node-deepstackai-trigger:issue260 and this has worked OK.  Images come through to telegram correctly annotated.

trigger_1       | 2020-06-21T16:28:44+10:00 [Annotations] Annotating /aiinput/garagehd.20200621_142306873.jpg
trigger_1       | (node:1) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'stringToGlyphs' of null
trigger_1       |     at Object.t.measureText (/home/node/app/bundle.js:564:24389)
trigger_1       |     at Object.t.processTextPath (/home/node/app/bundle.js:564:23412)
trigger_1       |     at fillText (/home/node/app/bundle.js:721:199545)
trigger_1       |     at /home/node/app/bundle.js:721:190333
trigger_1       |     at Array.map ()
trigger_1       |     at Object. (/home/node/app/bundle.js:721:190240)
trigger_1       |     at /home/node/app/bundle.js:721:189356
trigger_1       |     at Object.next (/home/node/app/bundle.js:721:189461)
trigger_1       |     at o (/home/node/app/bundle.js:721:188175)
trigger_1       |     at processTicksAndRejections (internal/process/task_queues.js:97:5)
trigger_1       | (Use node --trace-warnings ... to show where the warning was created)
trigger_1       | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

This fix is now available in the latest image. Thanks!

Thanks for fixing this. I pulled the latest version and tried it again and it works perfectly!

It was driving me crazy. I'd hit it all the time during development and couldn't figure out why. Finally found a random comment on a random issue about the library from 2018 and gave it a try and... phew!


resize problem when using flex

Bug report
charts are too slow to fit the resized window
Codepen
Codepen
Explanation

Shrink the window, you can see the two charts redrawed many times to fit the window
Delete 'display: "flex"' from the first div, the two charts respond instantly when resize the window

Interestingly, if I set the width of the chart to "80%"  with flex style, the two charts redraw much more faster. Or delete one chart, the left one with width="99%", also works fine.

This is the struggle with flexbox and how it calculates resizing. I've seen similar behavior.
Try wrapping the chart in a some container.
.container {
    display: flex;
    flex-direction: column;
    height: 100%;
    width: 100%;
    box-sizing: border-box;
    overflow: hidden;
}

.chart {
    flex: 1;
    box-sizing: border-box;
    padding: 0;
    height: 100%;
    min-height: 0;
    width: 100%;
    overflow: auto;
}

chart-wrapper {
    width: 100%;
    height: 100%;
    display: block;
    overflow: hidden;
}

Great, thank you very much

I had a problem similar to the card element of the bootstrap. When assembling the graph he did not respect the size of the parent div. Researching I realized that it was something with the rendering time and then I updated the width after rendering and it worked for me.

   <apexcharts
        type="pie"
        :width="width"
        height="100%"
        :options="options"
        :series="series"
   <apexcharts />

data() {
        return {
            width: '500',
            /* options,series*/
        }
}

mounted() {
        setTimeout(() => {
            this.width = '100%'
        }, 1)
}

I had a problem similar to the card element of the bootstrap. When assembling the graph he did not respect the size of the parent div. Researching I realized that it was something with the rendering time and then I updated the width after rendering and it worked for me.

   <apexcharts
        type="pie"
        :width="width"
        height="100%"
        :options="options"
        :series="series"
   <apexcharts />

data() {
        return {
            width: '500',
            /* options,series*/
        }
}

mounted() {
        setTimeout(() => {
            this.width = '100%'
        }, 1)
}

@thallesdaniell I spent a day trying to work this out, redrawOnParentResize: Boolean, didn't worked, chart.destroy() and chart.render() created an visual bug, ApexCharts.exec() nothing... using setTimeout fixed all my problems xD.
  useEffect(() => {
    setTimeout(() => {
      ApexCharts.getChartByID('events-chart').updateOptions({ ...EventsChart });
    }, 1000);
  }, [opened, theme]);

I needed to handle drawer open/close and theme change. Looks like when useEffect runs, my parent div is not updated yet.
Obs: I'm updating using the same options that are already running in my svg. This is a workaround to re-render and don't use destroy(), render().

In my scenario, after many hours trying to fix this, i just added overflow: hidden in the parent tag of the chart.
.average-production {
    flex: 0 0 50%;

    &__container {
        margin-right: .25rem;
        background-color: var(--chart-background-color);
        border-radius: .2rem;
        border: var(--border-line);
        height: 100%;

        &--chart {
            overflow: hidden;
            height: 7rem;
        }
}

Why? I don't know too :)

@guirms solution also worked for me! IMO, a much better solution, than forcing an update using a timeout.


Outdated line reference

The number reference here appears to be outdated. Will file an issue and fix separately to keep this PR focused as it's already large.
Originally posted by @Youssef1313 in https://github.com/dotnet/docs/pull/23132#r598063683

Also in https://github.com/dotnet/docs/blob/main/docs/csharp/tour-of-csharp/tutorials/numbers-in-csharp-local.md

Thanks @Youssef1313 I'll watch for the PR.


Avoid stack inspection on pytest

Description
Problem noted in review of my old code: https://github.com/adamchainz/django-perf-rec/pull/537#discussion_r1209735218
Currently django-perf-rec finds the current test name by stack inspection, looking for the pytest request object. This is fragile and slow.
Instead, the pytest plugin could store the request object, from which all the requisite "current test" details can be found.

Hello @adamchainz
I was able to reproduce the potential issue with request (now no potential)
@pytest.mark.parametrize("query_param", VALUES)
def test_request_factory_with_parametrize(query_param):
    request = RequestFactory()
    with record():
        run_query("default", f"SELECT {query_param}")

Here the request is not the one expected in request = frame.f_locals.get("request", None)
I ran the test_auto_name_with_request to check what request is expected and found following:
>>> type(request)
<class '_pytest.fixtures.SubRequest'>

Hope it will help and looking for the fix!


Use vars in pipeline

use yaml aliases (https://yaml.org/spec/1.2.2/#3222-anchors-and-aliases) to have pipeline vars
read more
TODO:

[x] apply to own pipeline config
[x] update pipeline schema
[ ] document it

Codecov Report

Merging #1026 (1f14b04) into master (061596d) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   51.19%   51.27%   +0.08%
==========================================
  Files          81       81
  Lines        6157     6157
==========================================
+ Hits         3152     3157       +5
+ Misses       2822     2817       -5
  Partials      183      183

Impacted Files
Coverage Δ

server/logging/log.go
54.65% <0.00%> (+5.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cbd63...1f14b04. Read the comment docs.

Can environment variables be used in variable values?

of course, this variables are a yaml feature and so all things we parse or extend come afterwards

this pull just document it and extend the schema to not complain

@6543 just to clarify: This is not released, yet, is it? I couldn't find this piece of information about anchors & aliases in the official documentation.
Will it only be released with version 1.0.0?


Dont depend on web sdk unless running tests on chrome

Fixes https://github.com/flutter/flutter/issues/34448

Landing to fix build


Completion removes the rest of the line

If we start with the following text, where "|" is the cursor:
("|")

and start typing:
("H|")

The completion will delete the the rest of the line starting from the cursor, in this case the ")
("H|ello, World!

This is highly undesirable especially when smartparens or lispy mode are used, and the parentheses balance are ruined.

The issue appears to be a result of Copilot, and unfortunately I have not been able to find a solution within copilot.el itself.
See also #116 #27 https://github.com/orgs/community/discussions/50038 https://github.com/orgs/community/discussions/46277


Upgrades to Basics.ipynb tutorial

Changes include:

Added Python 3 compatibility using future imports.
Refactored Markdown blocks with updated descriptions.
Made numerous grammatical/typo fixes in Markdown blocks.

As a heads up, this is my first pull request to Caffe2, as I am a newly hired part-time tech. writer. These changes were requested by @orionr

@caffe2bot test this please

And let's wait to merge until tests finish! Forgot that you wouldn't have them run automatically.