Reconsider Rakudo build structure

Current Rakudo build process still suffers from early single-core times when nobody was thinking about new language releases yet. Most notable problem is 6.c core being a special case in many locations: from Makefile to language version support code.

Proposed solution:

core directory is getting renamed into core.c
CORE.setting becomes CORE.c.setting.
BOOTSTRAP.nqp and EXPORTHOW.nqp are migrating into release-specific subdirs.
Perl6::BOOTSTRAP module becomes Perl6::BOOTSTRAP::v6<rev>, similar to CORE::v6<rev> pseudo-package.
Revisions d and e receive their own Perl6::BOOTSTRAP::v6<rev> modules.

The last two items are needed to support proper overriding of revision cores. I have stumbled upon a problem with Grammar class which clearly demonstrates the issue. BOOTSTRAP.nqp sets default parent and GrammarHOW for the class. But it does so exclusively for Grammar for revision c. The one defined for e remains with a usual ClassHOW. Besides, class code refers to HLL::Compiler which is only available if core is loading Perl6::BOOTSTRAP. use NQPHLL:from<NQP> doesn't work due to problems with serialization (sorry, didn't go deeper into this direction). For this reason e-specific BOOTSTRAP is the best solution for the problem.
This separation would also allow for things like the one proposed by @jnthn : redefinition of EXPORTHOW with revision-specific classes; and use of revision-specific HOWs. The latter actually means that Metamodel might get it's own .<rev> subdirectories.

Reference implementation is in rakudo/rakudo#3138.

core directory is getting renamed into core.c
CORE.setting becomes CORE.c.setting.

These seem reasonable.

BOOTSTRAP.nqp and EXPORTHOW.nqp are migrating into release-specific subdirs.
Perl6::BOOTSTRAP module becomes Perl6::BOOTSTRAP::v6, similar to CORE::v6 pseudo-package.
Revisions d and e receive their own Perl6::BOOTSTRAP::v6 modules.

How do these relate to each other? For example, the increasing core versions have a lexical nesting relationship; I'm guessing that's now how it is in this case, but what is it?

BOOTSTRAP.nqp and EXPORTHOW.nqp are migrating into release-specific subdirs.
Perl6::BOOTSTRAP module becomes Perl6::BOOTSTRAP::v6, similar to CORE::v6 pseudo-package.
Revisions d and e receive their own Perl6::BOOTSTRAP::v6 modules.

How do these relate to each other? For example, the increasing core versions have a lexical nesting relationship; I'm guessing that's now how it is in this case, but what is it?

No, there is no relation between them. It makes no sense. Each bootstrap is only bound to its corresponding CORE which kind of use it (World.nqp, line 768). The only purpose of Perl6::BOOTSTRAP::v6e for now, for example, is to provide HLL::Compiler for CORE.e.

OK, that sounds sensible. Thanks. Aside from my point about the curious versioning of the NULL "setting" on the PR (I think there should be just one NULL, which really means "no setting"), I'm fine with this.


Question about pbc ewald part.

Dear contributors,
Glad to see open-source code of electron gas system. When I go through pbc code, I get a problem about ewald summation and I cite it below.https://github.com/deepmind/ferminet/blob/main/ferminet/pbc/hamiltonian.py#L142
phase_prim_ae = phase_ae % 1
If I understand correctly this line is used to calculate the energy between elecrtrons and their images. And the summation should be done following minimal-imag conventions.
Let's assume we are working in a simple cubic and two electrons are seperated by 0.6 L where L is the length of this simple cubic in one dimension. So the minimal imag between these two electrons should be -0.4L, while the code above will give 0.6 L instead which may lead to some problems.
Although this problem can be easily masked if large enough truncated limit is used, it still needs to be corrected for potential problems.
I'm afraid the correct code should be
phase_prim_ae = (phase_ae + 0.5)  % 1 - 0.5
Then the minimal imag between 0.6 L electron pairs will be -0.4L, which seems correct.

Hi Xiang, thanks for your interest in the release and for taking a careful look at the code!
You are absolutely correct that if we were applying a minimum image convention, that code would be wrong. However, these lines are only there because as walkers move far from the origin, they move outside the region of physical space where we are actually taking the Ewald sum. We only need to move the walkers 'close' (by some definition related to the truncation length) to the origin, and so an electron occasionally being one image over from the minimum image does not cause a problem.
To lay your mind at ease: I have calculated the potential of two electrons separated as you suggested by a distance of 0.6 units  with/without your suggested edit (here I am using NumPy only, no JAX, and double precision):
without edit: -2.75527802498627
with edit: -2.7552780249862696
(simple cubic lattice, lattice constant 1 bohr, no atomic potential, include_heg_background=True)
I'm not sure this -needs- to be fixed, however, it cannot hurt and might save someone anxiety about the same problem in future. I would like to lay any readers' minds to rest thought that this does not cause the code to give 'wrong answers' as far as I can tell.

Dear Gcassella,
Thanks for the quick response. I agree that the difference is quite small and won't affect the correctness of present work. I just worry that this difference might lead to some problems at extremely special cases and that's why I raise the issue.


added steps for loading custom plugin

added steps for loading a custom plugin into Lemur once the files have been put into place (/www/lemur/lemur/plugins/) and the setup.py file (/www/lemur/setup.py) has been modified.

Coverage remained the same at 66.236% when pulling 74ff89c5021e8f335877d0d848108c4d0fa2684f on RickB17:patch-3 into 522e1826946e8e5b0f661a5ffb637838827f7cec on Netflix:master.

Coverage remained the same at 66.236% when pulling 74ff89c5021e8f335877d0d848108c4d0fa2684f on RickB17:patch-3 into 522e1826946e8e5b0f661a5ffb637838827f7cec on Netflix:master.

Thanks!


feat(nuxt): forward layout component ref to NuxtLayout

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR allow the same thing as https://github.com/nuxt/nuxt/pull/19403 but for NuxtLayout : allow using ref .
However this ones use a prop exposed to tranfer data since the LayoutLoader's setup is async.
todo:

[x] manual test for memory leaks
[x] fix tests

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

@danielroe It seems that this also solves another issue. On the current main branch, this line is not triggered
And this test should be throwing since with-props layout does render a Fragment or multiple root nodes.
I fixed the CI by setting a single root node within with-props.vue, should I add another test to make sure we get a warning if a layout has multiple root nodes  ?

Added a comment here that is also relevant, I think: https://github.com/nuxt/nuxt/pull/19403#pullrequestreview-1473366308


Add option to use codeformer?

It is generally the standard for improving faces in stable diffusion, last time I looked anyway.

codeformer is available to use, just place it in upscale models folder link here
https://huggingface.co/bluefoxcreation/Codeformer-ONNX/resolve/main/codeformer.onnx
more here
https://github.com/harisreedhar/Swap-Mukham/tree/5a16f91f4dbe08322b2322e47640bafcfa284a24#download-models


Timeout setting does not work

I've set
         timeout-minutes: 3

and it does not seem to work out. Cancelled it manually after 7 minutes:
Tue, 04 Oct 2022 14:03:25 GMT
Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.
Tue, 04 Oct 2022 14:03:26 GMT
Workflow status: Pending
...
Tue, 04 Oct 2022 14:10:28 GMT
Workflow status: Pending
Tue, 04 Oct 2022 14:10:35 GMT
Workflow cancelled, closing issue.
Tue, 04 Oct 2022 14:10:37 GMT
Error: The operation was canceled.

Did you check that the timeout-minutes located outside of the with: block? See #48.
      - uses: trstringer/manual-approval@v1
        timeout-minutes: 5

Thanks for helping, @sheeeng! @alexkuklin, did that work for you?

Thanks for helping, @sheeeng! @alexkuklin, did that work for you?

not yet, will do, thanks

I seem to have a problem using timeout-minutes too. I'm trying to pick it up from an environment variable but get the following error when the pipeline is executed. It still runs without a timeout, but this is logged:
An error occurred when attempting to determine the step timeout.

 Unexpected value '60'

I have this at the top of my yml
env:
  MIN_APPROVALS: 1
  TIMEOUT_MINUTES: 60

and this in my step
uses<EMAIL_ADDRESS>timeout-minutes: ${{ env.TIMEOUT_MINUTES }}
with:

I seem to have a problem using timeout-minutes too. I'm trying to pick it up from an environment variable but get the following error when the pipeline is executed. It still runs without a timeout, but this is logged:
An error occurred when attempting to determine the step timeout.

Hi @devszr, sorry to hear that you still experiencing the issue.
Could you share with us a minimal working GitHub Actions workflow file that reproduce the issue?
It will help us to understand the issue.

Apologies for the delayed response. I recently installed a YAML syntax checker in VS Code and it seems to mark my timeout-minutes line with an error and provides this message.
Incorrect type. Expected "number".yaml-schema: GitHub Workflow

Could this mean that the timeout-minutes cannot be passed as an env variable like
timeout-minutes: ${{ env.TIMEOUT_MINUTES }}

Hi everybody, same problem here. Even when I setup a timeout option it's not work.
  - name: Manual Approve
    uses: trstringer/manual-approval@v1
    with:
      timeout-minutes: 3
      secret: ${{ steps.generate_token.outputs.token }}
      approvers: my-team
      minimum-approvals: 1
      exclude-workflow-initiator-as-approver: false

Is anybody that could solve the problem?

Hi everybody, same problem here. Even when I setup a timeout option it's not work.
  - name: Manual Approve
    uses: trstringer/manual-approval@v1
    with:
      timeout-minutes: 3
      secret: ${{ steps.generate_token.outputs.token }}
      approvers: my-team
      minimum-approvals: 1
      exclude-workflow-initiator-as-approver: false

Is anybody that could solve the problem?

In your case, try moving the timeout-minutes out of with:, like this:
 - name: Manual Approve
     uses: trstringer/manual-approval@v1
     timeout-minutes: 3
     with:
       secret: ${{ steps.generate_token.outputs.token }}
       approvers: my-team
       minimum-approvals: 1
       exclude-workflow-initiator-as-approver: false

Hi everybody, same problem here. Even when I setup a timeout option it's not work.
  - name: Manual Approve
    uses: trstringer/manual-approval@v1
    with:
      timeout-minutes: 3
      secret: ${{ steps.generate_token.outputs.token }}
      approvers: my-team
      minimum-approvals: 1
      exclude-workflow-initiator-as-approver: false

Is anybody that could solve the problem?

In your case, try moving the timeout-minutes out of with:, like this:
 - name: Manual Approve
     uses: trstringer/manual-approval@v1
     timeout-minutes: 3
     with:
       secret: ${{ steps.generate_token.outputs.token }}
       approvers: my-team
       minimum-approvals: 1
       exclude-workflow-initiator-as-approver: false

It's work perfect here after change the timeout-minutes outside 'with' block. Thanks

If you use composite runs, the timeout-minutes won't work: https://github.com/actions/runner/blob/main/docs/adrs/0549-composite-run-steps.md#composite-run-steps-features
Open issue: https://github.com/actions/runner/issues/1979


Rename requiesments.txt to requirements.txt

Thanks for uploading the training code! I was struggling with it XD

Thanks!


updated deps

Manually picked up the latest of everything so we have the latest testing with the Playwright fix.

Lol I've been doing the same thing in https://github.com/BrightspaceUI/core/pull/4012

Oops, didn't see that! I can close this one, not sure if you want to apply the change here to remove the install-deps call to yours.


WIP: Implement PGP encrypt and PGP decrypt operations

This is for #6, implemented using Async and OpenPGP.js.
It adds two operations:

PGP encrypt [Public key]
PGP decrypt [Private key, [Private key password]]
And 6 tests

The test file includes 4 key pairs which were generated for the sole purpose of testing CyberChef's PGP operations.

1024 with password and without password
4096 with password and without password (These keys and associated tests are commented out to make tests run faster)

(A project for the future would be test skipping so we don't have to comment out long running tests).
Screenshots (4096 RSA):

I added a rather hacky setTimeout before app.chef.bake (in HTMLApp.js) so the UI has time to update the baking status. I think it is sufficiently hacky that a less bodged solution should be found in the future but for now it seems to suffice.

Thanks for catching all the careless errors above, I will be more scrupulous from now on.
I completely agree about the setTimeout... and will endeavour to find a better (if temporary) solution (i.e. without resorting to web workers, I think we have enough going on at present).
I hadn't noticed the size of OpenPGP.js but I agree it would be a waste to not include all possible functionality if we are "paying" for it anyway. I had some questions about the new functionality before I pushed my changes:
1. Output format of "PGP Verify".
I was going to go with the following (when verification succeeds)
Verified: true

Key ID: a9510d8fd7e352f5

message-goes-here

and (when it fails)
Verified: false

Key ID:

message-goes-here

This seems consistent with other text producing operations: e.g. Extract email addresses (displaying a total as the first line and then the results afterwards).
2. Exclusion of methods for looking up and uploading to key server.
I am under the impression that we do not want (at present) to include any operations involving network connectivity (for security, portability, reproducibility, etc).
I think if what you are alluding to in #79 gets implemented then perhaps a module system or similar could be built and there could be a "networked operations" module which would include such things. Right now I think it is best left for another day.
3. Input and output format of "PGP Generate".
For input I am currently using the arguments:
Password: string,
Key size: [1024, 2048, 4096],
Name: string,
Email: string.

For output I have currently implemented $publicKey\n\n$privateKey:
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: OpenPGP.js v2.3.6
Comment: http://openpgpjs.org

etc
-----END PGP PUBLIC KEY BLOCK-----

-----BEGIN PGP PRIVATE KEY BLOCK-----
Version: OpenPGP.js v2.3.6
Comment: http://openpgpjs.org

etc
-----END PGP PRIVATE KEY BLOCK-----

This operation is quite odd because it completely ignores any input and seems to just be providing a convenience (which is fine). I wondered if you had any insight in if it should take arguments. E.g. Password is input.
Further at-length discussion of this topic may lead into the "pipe output as argument" rabbit-hole which this PR is probably not the place for.
4. Non-Armored operations.
Currently all operations deal with Armored-strings instead of bytes, which (in my limited experience), seems to be the preferred format for all things PGP.
Instead of having multiple operations (for armored output and raw output) I was going to attempt to create two operations:

PGP Remove ASCII Armor (string -> byteArray)
PGP Add ASCII Armor (byteArray -> string)
So that operations can all have armored input/output and if the raw bytes are necessary then an operation can be chained to add/remove the armor:

[PGP Encrypt]
[PGP Remove ASCII Armor]

And
[PGP Add ASCII Armor]
[PGP Decrypt]

Although I think the jury is out on whether people actually do use non-Armored, you and your colleagues probably know more than I do.
There is probably an additional debate whether to use "Armored" or "Armoured" too :)

I do think the Web Workers are a good idea, but like you say, there are a number of big changes going through at the moment so let's wait until we're a bit more stable before we introduce another major architectural redesign.
In answer to your questions:
1. Output format for "PGP Verify".
Are you suggesting that this operation will also decrypt the message? I would personally leave that to the "PGP Decrypt" op and just use this one to list something along these lines:
Verified: [true or false]
Signed on [date]
Signed by [signer]
Signed with [algorithm]

If it's not valid, you could display the hash that actually gets produced as well as the above information.
2. Exclusion of methods for looking up and uploading to key server.
Yes, you're absolutely correct that we don't want anything like this at the moment. Perhaps at some point in the future, but for now we can leave it out.
3. Input and output format of "PGP Generate".
The arguments and output you have suggested look ideal. There is currently one other operation that also completely ignores the input: Generate UUID. I'm fine with this model if it makes sense, which I think it does in this case. It would be more confusing to the user to expect them to know to enter the password in the input or have to read the description to find out how to use the operation.
Piping output into arguments is another thing that we'll tackle at some point. It's definitely a really good idea, but we'll need to think carefully about the best way to design it. There is an issue for it here: #26.
4. Non-Armored operations.
Armoured strings should be the default but, as you've suggested, it might be nice to offer the ability to change the input and output formats to also support raw byte arrays and hex. I would prefer that this be an option argument for any relevant operations as well as a pair of separate operations. There is precedent for this. The Parse X.509 certificate operation includes the option to specify the output format, but there are also separate operations to convert PEM to Hex and Hex to PEM. I think this model works well as it offers the freedom to play around with the formats, but keeps things simple if someone wants to just modify the settings on a single operation.
Regarding the spelling, it doesn't bother me a huge amount, but considering that the rest of CyberChef uses British English spelling (see "Favourites" and "Parse colour code" for example), it makes sense to stick to that convention and use "Armour". Perhaps at some point we can offer language packs ;)

Just updating this with my progress after the most recent commit (still a WIP).
I separated out Sign / Sign Cleartext and Verify / Verify Cleartext because I think they are sufficiently different both in terms of the function they provide and from a usability perspective.
I've operations are currently as follows:
PGP Encrypt
Arguments:

Plaintext input
Recipient's public key

Outputs: ----- BEGIN PGP MESSAGE -----...
PGP Decrypt
Arguments:

Encrypted input (----- BEGIN PGP MESSAGE -----...)
Recipient's private key
[Recipient's private key password]

Outputs: plaintext
PGP Sign
Arguments:

Plaintext input
Recipient's public key
Author's private key
[Author's private key password]

Outputs: ----- BEGIN PGP MESSAGE -----...
PGP Verify
Arguments:

Encrypted input (----- BEGIN PGP MESSAGE -----)
Author's public key
Recipient's private key
[Recipient's private key password]
Display message in output (checkbox)

Outputs:
Verified: true
Key ID: a9510d8fd7e352f5
Encrypted for: CyberChef nopw 1024<EMAIL_ADDRESS>Signed on: // currently unimplemented
Signed by: CyberChef nopw 1024<EMAIL_ADDRESS>Signed with: // currently unimplemented

$message-goes-here-if-displayed

PGP Sign Cleartext
Arguments:

Plaintext input
Author's private key
[Author's pirvate key password]

Outputs:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

$message-goes-here
-----BEGIN PGP SIGNATURE-----
Version: OpenPGP.js v2.3.6
Comment: http://openpgpjs.org

$pgp-bytes
-----END PGP SIGNATURE-----

PGP Verify Cleartext
Arguments:

Clearsigned input (----- BEGIN PGP SIGNED MESSAGE -----...----- BEGIN PGP SIGNATURE -----...)
Author's public key
Display message in output (checkbox)

Outputs:
Verified: true
Key ID: a9510d8fd7e352f5
Signed on: // currently unimplemented
Signed by: CyberChef nopw 1024<EMAIL_ADDRESS>Signed with: // currently unimplemented

$message-goes-here-if-displayed

PGP Generate Key Pair
Unchanged from above
PGP Add ASCII Armor
Arguments:

byteString input (PGP bytes)
Armor type ("Message", "Public key", "Private key")

Outputs:
The armored message, so one of the following:

----- BEGIN PGP PUBLIC KEY -----
----- BEGIN PGP PRIVATE KEY -----
----- BEGIN PGP MESSAGE -----

Currently clearsigned messages don't work (see PGP Remove ASCII Armor).
PGP Remove ASCII Armor
Arguments:

PGP Armored input

The PGP Armored input can currently be anything in PGP Armor:

Public key
Private key
Message
Clearsigned message (this will only output the PGP signature bytes [essentially a detached signature] and will not contain the message text).

Outputs: byteString of the raw PGP bytes.
Summary of todo list

Ensure ASCII Armor operations for cleartext signatures
Tests for above
Renaming of "Armor" -> "Armour"
Possibly enable output of raw bytes (from operations) depending on how well ASCII Armor operations go
Gauge if implementation of "Signed on" and "Signed with" in "PGP Verify" and "PGP Verify Cleartext" is doable (i.e. is it implemented in OpenPGP.js), if so, implement it.

Progress update

Because PGP clearsigs are so different from other ASCII operations I have created a separate operation for detaching clear signatures: "Detach PGP Cleartext".
Still on the to-do list

[ ] Operation descriptions and JSDoc
[ ] Tests for "Detach PGP Cleartext"

I think it's time to merge this into feature-async-ops. The only outstanding thing now is the setTimeout hack and the correct way to handle that is by using web workers which I'd like to work on myself.
Next steps:

Update this PR to work with the new ES6 imports/exports
Merge it into feature-async-ops
@n1474335 to work on web workers on feature-async-ops branch
Merge feature-async-ops into master
Increment major version

Okay, sounds good. When I fetch and merge I'll remove the setTimeout. Most likely I will get this done on 04/01 or 04/02.

Just an update on where I am right now. I started working on merging upstream changes (node/webpack/babel) a while ago although I haven't had much time.
I have run into a couple of issues:

One of the flow control tests seems to be causing me some trouble (can someone else have a look, does it terminate or give you any OOM errors?)
Using import "openpgp" or import * as openpgp from "openpgp"; (Or var openpgp = require("openpgp");) causes the following code to be generated in the build:

/***/ }),
/* 15 */
/***/ (function(module, exports, __webpack_require__) {

var __WEBPACK_AMD_DEFINE_RESULT__;!(__WEBPACK_AMD_DEFINE_RESULT__ = function() {
    "use strict";

    return window.document;
}.call(exports, __webpack_require__, exports, module),
                __WEBPACK_AMD_DEFINE_RESULT__ !== undefined && (module.exports = __WEBPACK_AMD_DEFINE_RESULT__));

And the window.document then causes problems (running the tests under node which doesn't have a window global).
If anyone has encountered this before (or similar situations) I'd love to know how you resolved it.
Additionally thanks to @graingert I have realised that a lot of the code involving promises that I have written is subpar/redundant. I will rewrite that code after merging the upstream node changes, then we can get this merged (finally).

Hey @tlwr, cheers for the update. Don't worry about holding anything up, I have a long list of other things to work on in the meantime!
If you commit what you've got so far, I'll see if I can fix your tests. The import problems can potentially be fixed using the imports-loader, although this is clearly a workaround rather than a long-term solution. The OpenPGP.js library does claim that it supports Node, so there much be a way of doing this correctly.

Committed where I got up to with integrating my work with your work on node/babel/webpack.
I've also taken the liberty of rewriting my old code using promises to use best practices. More suboptimal stuff remains but as it is not related to PGP it is probably outside the purview of this PR.
I did see the imports-loader solution but I am surprised if it is necessary. I'm quite sure it is a mistake on my part.

You should rebase and clean up your commits

I've cleaned up Recipe.js by using async/await. I'd love a second look though.
I also had to increment the ecmaVersion config param in eslint so we can use async function.
Still banging my head against openpgp + webpack. It definitely feels like something trivial that I am overlooking.

@tlwr
I've just spent about 5 hours trying to sort out this bug. I've got to the stage where it successfully compiles, but the test suite then hangs, even if I comment out all the PGP tests. It could be something to do with the changes you've made to Recipe.js, although it seems to work fine in the browser... Either way, I haven't investigated any further. I don't really want to push my "fix" as it isn't actually complete yet. I'll explain the steps I've gone through in the hopes it will help someone else fix it properly.

The cause of the return window.document; bug is jQuery. When I set up webpack in #95 I included a resolve alias for jquery (jquery: "jquery/src/jquery") so that it would import the uncompiled version. This is recommended as it means webpack can more easily deduplicate common modules elsewhere in the project. However, if you remove this resolve alias, it no longer loads the offending code (node_modules/jquery/src/var/document.js) as its own module, so it doesn't get executed. I still haven't worked out quite why it's only causing a problem now when it has been there ever since I pushed #95.

Once this bug is fixed, you'll hit another one complaining that it can't load the crypto module. This is caused by webpack overriding the require keyword using variable injection when it inlines the openpgp module. When OpenPGP detects that it's running in a node environment rather than a browser, it tries to load native modules like crypto using require and fails because require is now undefined. This is what really stumps me. I can't work out why webpack is overriding require and I can't find a way to stop it. When the webpack target is set to node, it should allow modules to use require. The only solution I have is to import the source version of OpenPGP rather than the compiled distribution version (ironically the exact opposite of the solution/workaround for the previous bug). The source version is all written using ES6 modules and doesn't include the stub at the top which tries to detect which module system you're using (CommonJS, AMD, ES6 etc.) and then load your modules for you. With this stub missing, it loads successfully. You will need to npm install --save asmcrypto-lite rusha es6-promise for the uncompiled version to work.

So in short:
Gruntfile.js
                 resolve: {
                     alias: {
-                        jquery: "jquery/src/jquery"
+                        openpgp: "openpgp/src/index"
                     }
                 },

package.json
   "dependencies": {
+    "asmcrypto-lite": "^1.1.0",
+    "es6-promise": "^4.1.0",
+    "rusha": "^0.8.5",

As I said, once this is done the tests will still hang, so there's clearly something else wrong as well but I think I'll call it a night.

For node you need to configure externals or it will prevent require working
On 16 Apr 2017 02:15, "n1474335"<EMAIL_ADDRESS>wrote:

@tlwr https://github.com/tlwr
I've just spent about 5 hours trying to sort out this bug. I've got to the
stage where it successfully compiles, but the test suite then hangs, even
if I comment out all the PGP tests. It could be something to do with the
changes you've made to Recipe.js, although it seems to work fine in the
browser... Either way, I haven't investigated any further. I don't really
want to push my "fix" as it isn't actually complete yet. I'll explain the
steps I've gone through in the hopes it will help someone else fix it
properly.

The cause of the return window.document; bug is jQuery. When I set up
webpack in #95 https://github.com/gchq/CyberChef/pull/95 I included
a resolve alias for jquery (jquery: "jquery/src/jquery") so that it
would import the uncompiled version. This is recommended as it means
webpack can more easily deduplicate common modules elsewhere in the
project. However, if you remove this resolve alias, it no longer loads the
offending code (node_modules/jquery/src/var/document.js) as its own
module, so it doesn't get executed. I still haven't worked out quite why
it's only causing a problem now when it has been there ever since I pushed
#95 https://github.com/gchq/CyberChef/pull/95.
2.
Once this bug is fixed, you'll hit another one complaining that it
can't load the crypto module. This is caused by webpack overriding the
require keyword using variable injection when it inlines the openpgp
module. When OpenPGP detects that it's running in a node environment rather
than a browser, it tries to load native modules like crypto using
require and fails because require is now undefined. This is what
really stumps me. I can't work out why webpack is overriding require
and I can't find a way to stop it. When the webpack target is set to
node, it should allow modules to use require
https://webpack.js.org/configuration/target/#target. The only
solution I have is to import the source version of OpenPGP rather than the
compiled distribution version (ironically the exact opposite of the
solution/workaround for the previous bug). The source version is all
written using ES6 modules and doesn't include the stub at the top which
tries to detect which module system you're using (CommonJS, AMD, ES6 etc.)
and then load your modules for you. With this stub missing, it loads
successfully. You will need to npm install --save asmcrypto-lite rusha
es6-promise for the uncompiled version to work.
So in short:
Gruntfile.js
resolve: {
alias: {-                        jquery: "jquery/src/jquery"+                        openpgp: "openpgp/src/index"
}
},
package.json
"dependencies": {+    "asmcrypto-lite": "^1.1.0",+    "es6-promise": "^4.1.0",+    "rusha": "^0.8.5",
As I said, once this is done the tests will still hang, so there's clearly
something else wrong as well but I think I'll call it a night.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gchq/CyberChef/pull/89#issuecomment-294327258, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZQTAbqrngL3qn1yWW6_nju9j9AcUotks5rwWu-gaJpZM4MV1SY
.

@graingert Unfortunately that doesn't seem to work, webpack still overrides require for the openpgp module.
/* 604 */
/***/ (function(module, exports, __webpack_require__) {

/* WEBPACK VAR INJECTION */(function($) {var require;var require;(function(f)...

Where (frunction(f)... is the beginning of openpgp.js.

It shouldn't even emit any contents of that module
On 16 Apr 2017 12:41, "n1474335"<EMAIL_ADDRESS>wrote:
@graingert https://github.com/graingert Unfortunately that doesn't seem
to work, webpack still overrides require for the openpgp module.
/* 604 //*/ (function(module, exports, webpack_require) {
/ WEBPACK VAR INJECTION */(function($) {var require;var require;(function(f)...
Where (frunction(f)... is the beginning of openpgp.js.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gchq/CyberChef/pull/89#issuecomment-294347369, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZQTLF_JL8m-LIUbL3iGT93YWKxe_Eoks5rwf5egaJpZM4MV1SY
.

When in node mode
On 16 Apr 2017 12:50, "Thomas Grainger"<EMAIL_ADDRESS>wrote:

It shouldn't even emit any contents of that module
On 16 Apr 2017 12:41, "n1474335"<EMAIL_ADDRESS>wrote:
@graingert https://github.com/graingert Unfortunately that doesn't seem
to work, webpack still overrides require for the openpgp module.
/* 604 //*/ (function(module, exports, webpack_require) {
/ WEBPACK VAR INJECTION */(function($) {var require;var require;(function(f)...
Where (frunction(f)... is the beginning of openpgp.js.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gchq/CyberChef/pull/89#issuecomment-294347369, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZQTLF_JL8m-LIUbL3iGT93YWKxe_Eoks5rwf5egaJpZM4MV1SY
.

@n1474335 your effort sounds pretty heroic. I've implemented your suggested changes and got the same results as you: progress!
I'm curious what node --version you are running. As I understand it, webpack resolve aliases aren't touched by plugins (babel) which causes syntax errors due to new ES syntax (in OpenPGP.js), which does defeat the point of transpiling. I am on v4.2.6. Looking into how to solve this now.
Also if you comment out the FlowControl tests do the tests still hang? (I believe Jump: skips negatively is the specific test).

Closing, will reopen with a cleaned up and separate PR (just for the PGP operations) once #117 is merged.


Initial setup

Initial Setup

In this branch, I have made the following changes:

Add basic structure of a react app.
Add configuration for linters of React & Redux.
Fix linter errors for the default React app.

Hi @TheLuisAbarca,
Your project is complete!  There is nothing else to say other than... it's time to merge it ╰(°▽°)╯
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


(bug) (types) Skip mas account for the short term

As a workaround for https://github.com/mas-cli/mas/issues/417
https://github.com/borksh/bork/blob/f7fdc7603e70731eecfa6391fba6251a38ef28e0/types/mas.sh#L17-L18
We could check if the version of macOS >= 12, and skip the mas account step.
The consequences of this would be that, if a user is not logged in to the App Store, bork could erroneously report STATUS_MISSING. But until the mas-cli issue above is fixed, this may be an okay compromise.
It does however set a precedent for adding workarounds to bugs in dependencies.
Oh great leader @skylarmacdonald , how would you like to approach this one?

I don't necessarily see anything wrong with working around a bug in an upstream dependency ourselves. This looks like it's going to be a thorny issue to fix and will probably trip up a handful of people.
I reckon we do as you suggest. I would be in favour of still running bake mas account, just in case it magically starts to work again, but only then returning $STATUS_FAILED_PRECONDITION if we are on a version of macOS where that command works. Something like this (pseudocode):
bake mas account
[ "$?" -gt 0 ] && [ "$macos" -lt "12" ] && return $STATUS_FAILED_PRECONDITION

(Obviously, the $macos variable there is made up, but if we can figure out a way to do that check then that's how I would tackle it.)

So the annoying thing is we'd not actually be checking against "12"
Because the operating system branded as macOS 12, is actually... Darwin 21 😂
https://en.wikipedia.org/wiki/Darwin_(operating_system)
I'm on 12.3, and...
$ uname -r
21.4.0

But the concept holds.
And I do like your version better, where it's future-compatible with when the mas-cli devs are able to fix that bug.

here:
https://github.com/borksh/bork/blob/main/lib/helpers/system.sh#L39-L50
Something like...
get_baking_platform_release() {
  bake uname -r
}

That's not a bad approach. baking_platform is for future-proofing — the "baking platform" is the target system, whereas the platform is the source system on which you are running your script. Right now these are one and the same, but they might not be some day. So in this case, you should check what the baking platform's release is, as that's where you will be running mas.

        [ "$?" -gt 0 ] && [[ get_baking_platform_release < "21" ]] && return $STATUS_FAILED_PRECONDITION

✔ strawb@HashiBook ~/git_src/github.com/borksh/bork/lib/helpers [main|✚ 2]
$ bork check ok mas 441258766 Magnet
Error: This command is not supported on this macOS version due to changes in macOS. For more information see: https://github.com/mas-cli/mas#known-issues
error (failed precondition): mas 441258766 Magnet

✘-33 strawb@HashiBook ~/git_src/github.com/borksh/bork/lib/helpers [main|✚ 2]
$ ~/git_src/github.com/borksh/bork/bin/bork check ok mas 441258766 Magnet
Error: This command is not supported on this macOS version due to changes in macOS. For more information see: https://github.com/mas-cli/mas#known-issues
ok: mas 441258766 Magnet


Error: Building package openblas:x64-windows failed with: BUILD_FAILED | vcpkg in a non-space path

Host Environment
OS: [Windows]
Compiler: VS2017

To Reproduce
Steps to reproduce the behavior:
..\vcpkg\vcpkg\vcpkg.exe install openblas:x64-windows
Failure logs
PS D:\work\install\OpenMVS> ..\vcpkg\vcpkg\vcpkg.exe install openblas:x64-windows
..\vcpkg\vcpkg\vcpkg.exe: The term '..\vcpkg\vcpkg\vcpkg.exe' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
PS D:\work\install\OpenMVS> .\vcpkg\vcpkg\vcpkg.exe install openblas:x64-windows
Computing installation plan...
The following packages will be built and installed:
    openblas[core]:x64-windows -> 0.3.10
Warning: The following VS instances are excluded because the English language pack is unavailable.
    C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise
Please install the English language pack.
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\Users\pgjgg\AppData\Local\vcpkg\archives\fb\fb399411d1a006f8b105761aa8ff3768fecb5b71.zip
Starting package 1/1: openblas:x64-windows
Building package openblas[core]:x64-windows...
-- Using cached D:/work/install/OpenMVS/vcpkg/vcpkg/downloads/xianyi-OpenBLAS-63b03efc2af332c88b86d4fd8079d00f4b439adf.tar.gz
-- Cleaning sources at D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/work/install/OpenMVS/vcpkg/vcpkg/downloads/xianyi-OpenBLAS-63b03efc2af332c88b86d4fd8079d00f4b439adf.tar.gz
-- Applying patch uwp.patch
-- Applying patch fix-space-path.patch
-- Applying patch fix-redefinition-function.patch
-- Applying patch fix-pkg-config.patch
-- Applying patch fix-uwp-build.patch
-- Using source at D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:108 (message):
    Command failed: ninja -v
    Working Directory: D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/x64-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      D:\work\install\OpenMVS\vcpkg\vcpkg\buildtrees\openblas\config-x64-windows-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:319 (vcpkg_execute_required_process)
  ports/openblas/portfile.cmake:68 (vcpkg_configure_cmake)
  scripts/ports.cmake:136 (include)

Error: Building package openblas:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: openblas:x64-windows
  Vcpkg version: 2020.11.12-nohash

config-x64-windows-out.log
how to fix it? Thx.

vcpkg in a non-space path
D:/work/install/OpenMVS/vcpkg/vcpkg/

I check this issue, I got a CMake targets to set.
But, I don‘t know to select which flle to set.
such as these files:

And these code,directly to set in CMakeLists.txt ?Thx
find_package(OpenBLAS CONFIG REQUIRED)
target_link_libraries(main PRIVATE OpenBLAS::OpenBLAS)

issue linker:

issue related

    FAILED: cmTC_0b1f8.exe
    cmd.exe /C "cd . && D:\software\CMake\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_0b1f8.dir --rc=rc --mt=CMAKE_MT-NOTFOUND --manifests  -- C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\link.exe /nologo CMakeFiles\cmTC_0b1f8.dir\testCCompiler.c.obj  /out:cmTC_0b1f8.exe /implib:cmTC_0b1f8.lib /pdb:cmTC_0b1f8.pdb /version:0.0 /machine:x64  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
    RC Pass 1: command "rc /fo CMakeFiles\cmTC_0b1f8.dir/manifest.res CMakeFiles\cmTC_0b1f8.dir/manifest.rc" failed (exit code 0) with the following output:
    系统找不到指定的文件。

Did you installed the anti-virus?

@JackBoosY
Thx, I don't have any anti-virus.
I turned off the firewall, try again, but error again.
Now my firewall status:

I got more log information.
    [2/2] Linking C executable cmTC_f4710.exe
    FAILED: cmTC_f4710.exe
    cmd.exe /C "cd . && D:\software\CMake\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_f4710.dir --rc=rc --mt=CMAKE_MT-NOTFOUND --manifests  -- C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\link.exe /nologo CMakeFiles\cmTC_f4710.dir\testCCompiler.c.obj  /out:cmTC_f4710.exe /implib:cmTC_f4710.lib /pdb:cmTC_f4710.pdb /version:0.0 /machine:x64  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
    RC Pass 1: command "rc /fo CMakeFiles\cmTC_f4710.dir/manifest.res CMakeFiles\cmTC_f4710.dir/manifest.rc" f**ailed (exit code 0) with the following output:**
    系统找不到指定的文件。
    ninja: build stopped: subcommand failed.
  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:6 (project)
-- Configuring incomplete, errors occurred!
See also "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/x64-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/x64-windows-dbg/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

CMakeError.log
CMakeOutput.log

By learning the issue, I try to adjust the CMakeLists.txt in the dir of 'D:\work\install\OpenMVS\vcpkg\vcpkg\buildtrees\openblas\src\0f4b439adf-917c2f6847.clean'
issue related
##added information 2020/12/28
message("CMAKE_SIZEOF_VOID_P is ${CMAKE_SIZEOF_VOID_P}")
the cmakelists.txt
CMakeLists.txt
After I add the message command, it happened new error, and the dir of CMakeLists.txt is cleaned.
[1/2] cmd /c "cd .. && "D:/software/CMake/bin/cmake.exe" "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean" "-DBUILD_WITHOUT_LAPACK=ON" "-DCMAKE_MAKE_PROGRAM=D:/work/install/OpenMVS/vcpkg/vcpkg/downloads/tools/ninja/1.10.1-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:/work/install/OpenMVS/vcpkg/vcpkg/packages/openblas_x64-windows""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "D:/software/CMake/bin/cmake.exe" "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean" "-DBUILD_WITHOUT_LAPACK=ON" "-DCMAKE_MAKE_PROGRAM=D:/work/install/OpenMVS/vcpkg/vcpkg/downloads/tools/ninja/1.10.1-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:/work/install/OpenMVS/vcpkg/vcpkg/packages/openblas_x64-windows""
CMake Error: The source directory "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
[2/2] cmd /c "cd ../../x64-windows-dbg && "D:/software/CMake/bin/cmake.exe" "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean" "-DBUILD_WITHOUT_LAPACK=ON" "-DCMAKE_MAKE_PROGRAM=D:/work/install/OpenMVS/vcpkg/vcpkg/downloads/tools/ninja/1.10.1-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=D:/work/install/OpenMVS/vcpkg/vcpkg/packages/openblas_x64-windows/debug""
FAILED: ../../x64-windows-dbg/CMakeCache.txt
cmd /c "cd ../../x64-windows-dbg && "D:/software/CMake/bin/cmake.exe" "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean" "-DBUILD_WITHOUT_LAPACK=ON" "-DCMAKE_MAKE_PROGRAM=D:/work/install/OpenMVS/vcpkg/vcpkg/downloads/tools/ninja/1.10.1-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/work/install/OpenMVS/vcpkg/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg" "-D_VCPKG_INSTALLED_DIR=D:/work/install/OpenMVS/vcpkg/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=D:/work/install/OpenMVS/vcpkg/vcpkg/packages/openblas_x64-windows/debug""
CMake Error: The source directory "D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/src/0f4b439adf-917c2f6847.clean" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
ninja: build stopped: subcommand failed.

I clean vcpkg, try to build again to avoid the cache influence.
Downloading ,I will check it tomorrow.
PS D:\work\install\vcpkg> .\vcpkg.exe install openblas:x64-windows
Computing installation plan...
The following packages will be built and installed:
    openblas[core]:x64-windows -> 0.3.10
Warning: The following VS instances are excluded because the English language pack is unavailable.
    C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise
Please install the English language pack.
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\Users\pgjgg\AppData\Local\vcpkg\archives\fb\fb399411d1a006f8b105761aa8ff3768fecb5b71.zip
Starting package 1/1: openblas:x64-windows
Building package openblas[core]:x64-windows...
-- Downloading https://github.com/xianyi/OpenBLAS/archive/63b03efc2af332c88b86d4fd8079d00f4b439adf.tar.gz...

In the vcpkg dir, I don't have the vcpkg\downloads\tools*cmake-3.14.0-windows*.
Maybe, it is a cause.

There are several possibilities here, but they have nothing to do with cmake:

D:\software\CMake\bin\cmake.exe cannot be accessed.
C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\link.exe cannot be accessed.
D:\work\install\OpenMVS\vcpkg\vcpkg\buildtrees\openblas\x64-windows-dbg\CMakeFiles\CMakeTmp\CMakeFiles\cmTC_f4710.dir\testCCompiler.c.obj does not exist.

Can you confirm that and run command maunally D:\software\CMake\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_f4710.dir --rc=rc --mt=CMAKE_MT-NOTFOUND --manifests  -- C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\link.exe /nologo CMakeFiles\cmTC_f4710.dir\testCCompiler.c.obj  /out:cmTC_f4710.exe /implib:cmTC_f4710.lib /pdb:cmTC_f4710.pdb /version:0.0 /machine:x64  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib in directory D:/work/install/OpenMVS/vcpkg/vcpkg/buildtrees/openblas/x64-windows-dbg/CMakeFiles/CMakeTmp using Visual Studio x64 Native Tools Prompt for VS 2017?
Thanks.

If you are worried about cmake, please uninstall the manually installed cmake and try again.

Thanks, I get it, it works good.
more details
Building package openblas[core]:x64-windows... done
Installing package openblas[core]:x64-windows...
Installing package openblas[core]:x64-windows... done

Elapsed time for package openblas:x64-windows: 5.818 min
Total elapsed time: 5.856 min
The package openblas:x64-windows provides CMake targets:
    find_package(OpenBLAS CONFIG REQUIRED)
    target_link_libraries(main PRIVATE OpenBLAS::OpenBLAS)


Troubleshoot AzureOps Guide: grpc: error while marshaling: string field contains invalid UTF-8

Error: Error: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8 after running python .mlops-setup-scripts/terraform/bootstrap.py and being prompted for region.
Fix: this seems to be a problem with Azure CLI and how it interacts with Terraform. Please see this Terraform GitHub issue for fixes.

Closing this issue since as of https://github.com/databricks/mlops-stack/releases/tag/v0.1 we replaced Terraform.


Ducalis force to use update in migrations in old rails versions

Ducalis force to use update in migrations even in rails <4 (c)

@hellgirl thanks. Fixed in version 0.5.14.


Our use case of this tool is to load images and POST crop coordinates to the server which will crop the original image using those coordinates.
It works fine for larger landscape images, but it looks like if a large image with portrait EXIF orientation gets loaded, then the canvas gets shrunk to a max of 1000px.  That makes the cropImageWidth etc coordinates inaccurate.  Is there a way to be able to get accurate crop coordinates even though the canvas got shrunk?

You can resize image to 19201080 max (ex 17951080 or 1920*1071) and use that image on cropper and after crop get points for actual crop on the server.

That will not work.  That would reduce the quality of the source image, resulting in a lower quality cropped area.
I do not know how to do a pull request, but this is what I did:
I added an additional field called "downScale" to cropject.  That number will be 1, unless the "[3, 6, 8].indexOf(orientation) > -1" in setNewImageSource is hit, in which case downScale will be what the "p" variable is there".
With the downScale number, then I can get the original image width in my controller doing something like:
origWidth = Math.round(vm.cropper.cropImageWidth / vm.cropper.downScale)

if you have fixed your issue then you are ok. My solution is working, i am actually using it on my projects.

I am unclear on what your solution is.  Are you saying that you resize the source image to 19201080 max on your computer before uploading it to crop?

no no, javascript. You keep scale of the image and make max 1920 width and max 1080 height. In that way you get smooth cropping tool. After that you send to the server the original image alongside with object from cropobject and handle the cropping inside back-end as you wish. I am using ImageMagick on back-end which do a bit better work from canvas.

If you wish i can drop here the code of that resize, actually i have other service doing it, which i build my self. I can share resize code.

Yes please, that would be awesome!  I am also using ImageMagick on server.  In my case the server already has the source image (for the crop tool i am using like image="'http://myserver.com/someimage.jpg"), then i am just passing to the server the area i want to crop for the image that is already there.

So you simply have to send cropobject to server, i will add code for resize soon.

var reader = new FileReader();
reader.onload = function (loadEvent) {
	var ratioToFloat = function(val) {
		var r = val.toString(),
			xIndex = r.search(/[x:]/i);
		if (xIndex > -1) {
			r = parseFloat(r.substring(0, xIndex)) / parseFloat(r.substring(xIndex + 1));
		} else {
			r = parseFloat(r);
		}
		return r;
	};
	var canvasElement = document.createElement('canvas');
	var imageElement = document.createElement('img');
	imageElement.onload = function() {
		var ratioFloat = ratioToFloat(1920/1080);
		var imgRatio = imageElement.width / imageElement.height;
		if (imgRatio < ratioFloat) {
			width = 1920;
			height = width / imgRatio;
		} else {
			height = 1080;
			width = height * imgRatio;
		}
		canvasElement.width = width;
		canvasElement.height = height;
		var context = canvasElement.getContext('2d');
		context.drawImage(imageElement, 0, 0 , width, height);
		var dataURL = canvasElement.toDataURL('image/png', 1);
		scope.$apply(function () {
			// here you have dataURL of the resized image
		});
	};
	imageElement.src = loadEvent.target.result;	// loadEvent.target.result it's the src of the image
};

Hope this will help you out.

fantastic, thank you!


Update to @actions/artifact 2.0 and use new artifact upload API

This change updates the action to use the new Artifacts v4 upload mechnism (via @actions/artifacts 2.0). For details about GitHub's Artifacts v4 release see: https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/
This is a breaking change because artifacts uploaded using this new mechanism cannot be downloaded using the older actions/download-artifacts action.
I also added the new compression-level input to match what the new actions/upload-artifact action provides.

I'll create a new branch because it is a breaking change, and I am not sure that everyone uses a fixed version as said in the note in README.


File header tweaks, add CSS helpers

replace two instances of fontawesome with octicons
add new "class" optional argument to "svg" helper
add many new CSS helpers and move their import to the end for increased precedence

Changes look OK, unsure about failing tests?

🚀


update: begin porting over branch logic

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#221  👈
#220
#219
#218
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite

Merge activity

Aug 10, 5:36 PM EDT: @rphmeier started a stack merge that includes this pull request via Graphite.


npm shrinkwrap results in extraneous package errors

when running npm shrinkwrap on my project that depends on le_node I get an extraneous package error and it fails to generate a valid npm-shrinkwrap.json. Here is the output of the shrinkwrap command:
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\mitm
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\winston
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\bunyan
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\tap-spec
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\tape
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\gobble
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\gobble-babel
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\project\node_modules\le_node\node_modules\gobble-cli
it looks like there are extra packages in the npm-shrinkwrap.json that are not included in the package.json as dependencies.

Hi there, does running npm prune resolve the issue for you?
The inclusion of devDependencies in the npm-shrinkwrap would seem to be the culprit here.

running npm prune does fix the issue and allows me to successfully shrinkwrap the application.

I'm going to see if I can sort out the shrinkwrap issue later this week. I'd like to get it out of there now.

Any movement on this issue? I am now getting errors when even when I prune and shrink wrap:
npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! invalid: have<EMAIL_ADDRESS>(expected: 0.1.4) D:\services\catalog\node_modules\le_node\node_modules\codependency
npm ERR! extraneous<EMAIL_ADDRESS>D:\services\catalog\node_modules\le_node\node_modules\codependency

I'm using node v5.5.0 and npm v3.3.12

+1

@bathos Have you been able to look into this issue. We are trying to update our applications to use the latest version of le_node since the version we are on uses some packages with known vulnerabilities, but this is blocking us from updating. Thanks.

Should be fixed now with the latest release.


Fix querying the latest comment of progress issues

Fix assertion error we see in pipline runs which happens when trying to
find the latest comment for a progress ticket (and there was no comment
when initializing the Issue object)
Support redmine tickets when querying the last comment
See https://progress.opensuse.org/issues/102440

In the second git commit message s/pipline/pipeline/

I'm wondering in which case this actually happens.
Both last_comment_date and last_comment_text should be set to something in case of redmine, so when is the line
if not self.last_comment_date or self.last_comment_text is None: actually triggered?
        self.last_comment_date = datetime.datetime.strptime(self.json["updated_on"], "%Y-%m-%dT%H:%M:%SZ")
        self.last_comment_text = ""

Good question. Maybe that's actually only the case when the bugref is an invalid one?

No - that isn't it. If the issue type isn't set, last_comment would not be called in the first place.

The actual problem is the condition itself. That's basically the problem:
>>> foo = None
>>> bar = None
>>> not foo or bar is None
True
>>> not foo or bar
True


Wrong uses in examples

I tried using this changelog generator recently, and figured out both this and this example usage use changelog-generator as the repository name, instead of changelog-generator-action, causing the action to fail loading.

Thanks for letting me know about the typo! I'll fix that now


[Animation] For existing animations, iterating to next/previous step does not update 'frame' or 'animation' properties of Animated Sprite

Godot version
4.2 rc1
System information
Windows 11
Issue description
In projects with existing animations, cycling through next/previous steps in an animation, IN the editor, does not update the 'frame' or 'animation' properties for 'AnimatedSprite'.
The issue goes away if you create a new animation with duplicate functionality.
Steps to reproduce

Minimal reproduction project
Needs a project with existing animations made in the previous version.

CC @TokageItLab

I can't figure out what you are talking about as there is no MRP or video, but from the description I would guess that https://github.com/godotengine/godot/pull/83399 may be related. I don't know more than that.

The description is pretty clear.
But here:
Uploading Scavenger.tscn - Energy - Godot Engine 2023-11-20 15-41-19.mp4…

I can still repro this in latest godot master.

Uploading AnimatedSpriteBug.zip…

AnimatedSpriteBug.zip

Repro steps:
Go to animation 'test' in AnimationPlayer
Click on different 'steps' in the animation test. The animated sprite 'frame' property will not update consistently.

@LakshayaG73 Your related: https://github.com/godotengine/godot/issues/85483


Old device id buffering

There have been many problems with the fact that device id is saved in the database. Two options to fix the issue:

Clear database when device id is changed
Do not save id in the database

I think the option 2 is better.

Depends... If you change the ID, means that you assign the tracker to
someone/something else. If you don't save the ID, you will send data on the
wrong device ID..
No data may be better.
Maybe it would be better to enhance the client so taht it sends all the
data even if the server does not accept the device ID.
I already reported this issue some time ago:
https://github.com/tananaev/traccar-client-android/issues/151
Redge
On Thu, Dec 17, 2015 at 1:30 AM, ivanfmartinez<EMAIL_ADDRESS>wrote:

I think the option 2 is better.
—
Reply to this email directly or view it on GitHub
https://github.com/tananaev/traccar-client-android/issues/171#issuecomment-165299241
.

But if you are changing an android device to someone else, normally all data will be purged when you change the google account.

I changed the ID without changing the account..... I use a single google account for all my trackers.

For now I decided to remove old data if device id has changed.


Fix some initializations in PathFollow2D's unit test

adds the changes that @Xrayez requested while reviewing #46341

Thanks!


Custom caption & tool bar

Is there any way to make the caption bar and tool bar not fade away and for them not to overlap the image?
Such a great piece of code.

I have the same question...re. changing caption bar to not overlap the image.  @roary86: to get tool bar to be persistent, set captionAndToolbarAutoHideDelay: 0 in the .css file.

I have the same question...re. changing caption bar to not overlap the image.  @roary86: to get tool bar to be persistent, set captionAndToolbarAutoHideDelay: 0 in the .css file.

Excuse me...not the .css file, but in the Photoswipe .js file.

Excuse me...not the .css file, but in the Photoswipe .js file.

ps.toolbar will position bottom:0. In my opinion ps.toolbar should first of all display: static and absolute positioning disabled. (bottom, left, z-index is not aplicable anymore). ps-toolbar is sibling of div.ps-carousel (which holds the images). Maybe this is a startingpoint.

Thanks @Bravoflix and @myradon I got the toolbar to not hide but still can't get it to not overlap the image.

Dive in the stylesheet and check if some properties on ps-toolbar are set by JS on the element.


Slices and Strings comparisons

This PR introduces the ability to compare both slices and strings via == operation.
For slice comparison, their hashes (calculated using HASHSU) can be compared directly.
As for strings, they are essentially slices and can be compared similarly. However, there's a consideration with strings due to their potential for various serializations (e.g., a string can be split in the middle and continued in a subsequent reference, still constituting a valid string). Upon reviewing the implementation of the String type in Tact, it was determined to be deterministic: all slices in a 'snake' representation are completely filled, except for the last one. Therefore, the same slice comparison method is applicable to strings as well.

Hash is not the most gas efficient way to do this. There's a native opcode for this:
int equal_slices(slice a, slice b) asm "SDEQ";

Hash is not the most gas efficient way to do this. There's a native opcode for this:
int equal_slices(slice a, slice b) asm "SDEQ";

SDEQ is, essentially, an abbreviation for Slice Data Equal. It does not account for refs at all. Use of hash covers both long (multi-cell) and short (single-cell) strings correctly.


Add test for null String

Add a simple test for java String is null from Rust None Option.

We'll need to hold off on this. After I updated the test to //@run I'm seeing some runtime failures. I'll try to take a look soon.
    let java = take_null_record.to_java().assert_not_null().execute()?;
    let is_null = java.is_null().execute().unwrap(); // <- `Error: attempted to deref a null Java object pointer`
    assert!(!is_null);

So is this fixed by https://github.com/duchess-rs/duchess/pull/182 ?

Yup fixed by https://github.com/duchess-rs/duchess/pull/182


HBASE-27897 ConnectionImplementation#locateRegionInMeta should pause …

…and retry when taking user region lock failed

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
branch-2 passed

+1 :green_heart:
compile
3m  8s
branch-2 passed

+1 :green_heart:
checkstyle
0m 56s
branch-2 passed

-1 :x:
spotless
0m 38s
branch has 23 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 20s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
0m 36s
hbase-server: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m  2s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

37m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5258

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 09aa37b7a7b1 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 282d2a7cf9

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/artifact/yetus-general-check/output/branch-spotless.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 26s
branch-2 passed

+1 :green_heart:
compile
0m 50s
branch-2 passed

+1 :green_heart:
shadedjars
4m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 24s
the patch passed

+1 :green_heart:
compile
1m 11s
the patch passed

+1 :green_heart:
javac
1m 11s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
7m 55s
hbase-client in the patch passed.

-1 :x:
unit
203m  6s
hbase-server in the patch failed.

234m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5258

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0cd8ac0dc055 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 282d2a7cf9

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/testReport/

Max. process+thread count
4504 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 46s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 48s
branch-2 passed

+1 :green_heart:
compile
1m  9s
branch-2 passed

+1 :green_heart:
shadedjars
4m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
4m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m 10s
hbase-client in the patch passed.

-1 :x:
unit
215m 14s
hbase-server in the patch failed.

249m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5258

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ff5517ba424e 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 282d2a7cf9

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/testReport/

Max. process+thread count
4482 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 35s
branch-2 passed

+1 :green_heart:
compile
3m  8s
branch-2 passed

+1 :green_heart:
checkstyle
0m 55s
branch-2 passed

-1 :x:
spotless
0m 37s
branch has 23 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 24s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

+1 :green_heart:
checkstyle
0m 19s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
0m 33s
hbase-server: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 56s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

36m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5258

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 970decd85c0f 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 282d2a7cf9

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/2/artifact/yetus-general-check/output/branch-spotless.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The spotless issue is not relevant to this PR.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 44s
branch-2 passed

+1 :green_heart:
compile
3m 10s
branch-2 passed

+1 :green_heart:
checkstyle
0m 53s
branch-2 passed

-1 :x:
spotless
0m 38s
branch has 23 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 20s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
0m 36s
hbase-server: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m  7s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

37m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5258

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux b1061c8ab331 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0121eeb0f5

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/artifact/yetus-general-check/output/branch-spotless.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
branch-2 passed

+1 :green_heart:
compile
1m  7s
branch-2 passed

+1 :green_heart:
shadedjars
5m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 10s
the patch passed

+1 :green_heart:
compile
0m 52s
the patch passed

+1 :green_heart:
javac
0m 52s
the patch passed

+1 :green_heart:
shadedjars
4m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
7m 52s
hbase-client in the patch passed.

+1 :green_heart:
unit
201m 39s
hbase-server in the patch passed.

233m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5258

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b791911e878f 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0121eeb0f5

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/testReport/

Max. process+thread count
4668 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 37s
branch-2 passed

+1 :green_heart:
compile
1m  8s
branch-2 passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 41s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
4m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m 14s
hbase-client in the patch passed.

+1 :green_heart:
unit
215m 23s
hbase-server in the patch passed.

248m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5258

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 710ef9e67f17 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0121eeb0f5

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/testReport/

Max. process+thread count
4544 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5258/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


AWS getting started depends on non namespaced env vars

fluent/docs/getting-started-aws.md states that it requires NAME and KOPS... env vars
These env vars could
a) conflict with existing setups on a dev machine
b) If found without context they might not be identifiable to the code that uses them
Proposal:
Migrate these to a namespaced (and more descriptive) variable, say FLUENT_NAME or similar

Closed by #116.


Shebangs should be parsed correctly

Shebang support is not a thing, which is incorrect. However, supporting shebangs is pretty easy, a SHEBANG token kind already exists, so all that needs to be done is add a handler for it in the lexer, the logic is already there in Lexer::strip_shebang, so just add something in the lookup table which checks #, then in the match simply match for the dispatch then peek for !, you must also check if the current position is 0.  Then for the parser:

Add a field to Script and Module in xtask/src/ast.rs:

struct Script {
+    T![shebang],
     items: [Stmt],
  }

struct Module {
+    T![shebang],
     items: [ModuleItem],
}

regenerate the definitions with cargo xtask syntax
add a simple p.eat(T![shebang]); after let m = p.start(); in rslint_parser/src/syntax/program.rs in script and module
log the change in the rslint_lexer and rslint_parser changelogs, as well as add lexer tests for it

Could I work on it?

Sure! go ahead


JBPM-4650: Add deploymentId to CaseInstance

@mswiderski please have a look.

+1 once the build completes


Visual design: add some padding to areas of the sidebar

Currently, many areas in the sidebar have no padding, which makes them slightly stressful to look at and use, especially if the window is full screen and these are right on the edge of my clickable area.

A very simple and effective improvement would be adding padding: 0.5 rem to the divs inside each panel:

This is actually achievable with just a couple lines of CSS:
.panel>div {
    padding: 0.25rem 0.75rem;   /* 4px of space at top & bottom, 12px space on left & right */
    box-sizing: border-box; /* prevents width of div from exceed width of parent */
}

Thanks. There’s some crufty hard-coded element widths in there that I need to fix first, and then the padding can be sorted out. Some panels are bit tight (e.g. I want to leave decent space for the axis name in the Axes panel to stop it cropping or line-breaking).

Some panels are bit tight (e.g. I want to leave decent space for the axis name in the Axes panel to stop it cropping or line-breaking).

Understandable! Fitting in this much complexity is not an easy task, and you’ve done this quite nicely so far. My three thoughts on this challenge are:

This is a desktop-only application, so you could probably make the sidebar somewhat wider without much negative impact
The sidebar is scrollable, so if lines are breaking a lot, you could split them into more lines from the start
People probably mostly know the axis names they are inspecting, and for things that do get cropped, you could perhaps show the full name on mouse hover

I think @cadars’ excellent updates fix this. Comments welcome of course. Closing.


feat: BbsBlsSignature2020 LDP suite for VC

closes #2221
Signed-off-by: Dmitriy Kinoshenko<EMAIL_ADDRESS>

@kdimak public_key_verifier_test.go is probably missing, code coverage is low

@kdimak public_key_verifier_test.go is probably missing, code coverage is low

yeah, I had to write two extra tests for this :)


Azur - Re-Installation validation of config.yml task is missing

While doing latest code re-installation in azur
Issue: Missing Config.yml file successfully validated

@chetandg123 modified code for validation of config.yml, unit test also done.
please pull the latest code and test.

@ayesha-siddiq123 sure

@ayesha-siddiq123 Re-tested the defect is working as expected


Fixing codebase links in readme files

Just fixing 2 of the links, when you click on them it doesn't take you to the files:

They redirect to invalid pages, I just pointed them to the correct files/urls in your github.

thanks!


feat(PNat/interval): add two lemmas

Two lemmas supporting Icc in combination with sub

[ ] depends on: #12454

Depends on an unnecessarily large commit which I want to split, so I'll resubmit this PR later.


flow/string-format: Don't crash if precision is 0

Another one found with the fuzzer.
@glima, could you please take a look here, since you wrote this code?

Merged with slight difference after ack from@glima.


Enabling basic HTTP node instrumentation

Adding basic response time-based instrumentation to HTTP nodes.

Coverage increased (+0.02%) to 89.55% when pulling 8115fef8f75173e3760e66e6a362117ffbbbe30b on zobalogh:html-node-instrumentation into 5e5a220f68521a398b95c35704b1257bdb15cdbd on node-red:master.

Coverage increased (+0.02%) to 89.55% when pulling 01bda9c94f59e949c5b24a49db33abdd9436f78c on zobalogh:html-node-instrumentation into 5e5a220f68521a398b95c35704b1257bdb15cdbd on node-red:master.

Coverage increased (+0.02%) to 89.55% when pulling 9ea19e272251afc3224fa98f092c70fba1ac5282 on zobalogh:html-node-instrumentation into 5e5a220f68521a398b95c35704b1257bdb15cdbd on node-red:master.

Coverage increased (+0.02%) to 89.55% when pulling 9ea19e272251afc3224fa98f092c70fba1ac5282 on zobalogh:html-node-instrumentation into 5e5a220f68521a398b95c35704b1257bdb15cdbd on node-red:master.

Doing some research around how this, I think I've found a better way of capturing this.

there is the on-headers module that allows you to register a callback when response headers are about to be written to the network. In other words, after all the processing has been done on the request.

the approach taken by the generic responseTime middleware is to add a middleware function that records current process.hrtime() and then registers a callback using on-headers to calculate the elapsed time. This middleware adds it as an http header, where as we would want our version to call node.metric with the details. We would also benefit from the fact the content-length header is pretty much guaranteed to be set by this point, so we can grab its value rather than have to do any processing ourselves.

once we have such a middleware, we would add it to the list that get called for a registered HTTP In node here and the following lines. Our middleware should be first in the list, although after this.url. If metrics is disabled, we either handle that in the middleware itself, or insert a no-op middleware in its place (see how we do that for corsHandler just above).

Using middleware seems like a good idea to me. :-P

@hindessm indeed - I only just twigged it could be contained in the HTTP node code, and not have to be added to the base node-red express app.

Coverage increased (+0.02%) to 89.55% when pulling 702af0dce3b6dbd21e10d486fe4957f8b8ce8294 on zobalogh:html-node-instrumentation into 5e5a220f68521a398b95c35704b1257bdb15cdbd on node-red:master.

Coverage increased (+0.02%) to 89.55% when pulling 82cfeba096a94f6d7e7a219974c2130a2ecbfcd6 on zobalogh:html-node-instrumentation into 5e5a220f68521a398b95c35704b1257bdb15cdbd on node-red:master.

@knolleary ready for review, as discussed. Thanks

Coverage decreased (-0.04%) to 89.21% when pulling 537b5b018acc26b1b9437aacd0cffb9b4bdef69e on zobalogh:html-node-instrumentation into a08b29dbd1bef1dd737161709d3ac58732b3a416 on node-red:master.

Committed, with a couple tweaks, via f2d464838412ce5c25c37a31d03371fedec158ec


HeroComponent does not implement OnInit

thanks :)
works with it there because it does not generate js, but still a good catch!

Thanks! tsc wouldn't compile without removing that. Once again, great talks this week!

Add imports for lifecycle
import { Component, OnInit, ViewEncapsulation } from '@angular/core';

Code Snippet
export class AppComponent   implements OnInit{
title = 'The App Still Works!';

  ngOnInit() {
  // Do initializaing/service call
  this.title = 'Updated from onInit!';
  }
  //Angular creates, updates, and destroys components as the user moves through the application.
  //Your app can take action at each moment in this lifecycle through optional lifecycle hooks,
  //like ngOnInit() declared above.
}


Fix for https://github.com/PowerShellOrg/cChoco/issues/54

Updated cChocoSource.psm1 to run choco in Test-TargetResource

@kcighon thanks for the bugfix. I'll merge this in.


Merge back Marathon patches.

The Marathon team invested some work to make Shakedown a simple library for pytest.
Please note, this is a breaking change. We probably should bump Shakedown to 2.0.
The change:

Removes the logging wrapper.
Introduces the eventually matcher.
Pulls in all DC/OS client code from the CLI 0.4.
Replaces the spinner with retrying or eventually.
Replaces http.py with clean requests calls.
Drops all unit tests since Marathon's system test would rest all changes implicitly.
Authenticates with the same environment variables the CLI uses.
Tries the CLI session for authentication.

JIRA issue: MARATHON-8101
Co-authored-by: Alena Varkockova<EMAIL_ADDRESS>Co-authored-by: Aleksey Dukhovniy<EMAIL_ADDRESS>

Won't do I guess


Remove video entries

Hi y'all,
Hopefully an obvious question, but I don't see a way (without adding tags to every image on instagram) to just return latest posts that are only images, as in no video entries.
The problem is the images generally have black bars top and bottom as they are snapshots from the videos, which look terrible in amongst the wall to wall images. So if I could filter them out it would be perfect.
Any help much appreciated.
Thanks

@KebiainWoods Yes, you can remove videos using the following filter option:
var feed = new Instafeed({
  // other options
  filter: function(image) {
    return image.type === "image";
  }
});
feed.run();


Add support to the compiler for musl and the LINUX_STATIC SDK.

This is really just about setting appropriate defaults (such as making sure that the static Linux triple causes us to use lld).
rdar://123506306

@swift-ci Please test

Explanation: We need to make sure the compiler picks the correct linker and build settings.
Original PR: #71844
Risk: Low. This changeset is additive and really only affects the static SDK.
Reviewed by: @MaxDesiatov
Resolves: rdar://123506306
Tests: There are no tests in the repository for the static Linux SDK (because it isn't built by the Swift repo itself). We will be building out CI for it, at which point we will have tests for this. There are already tests for Linux and WASI, which are the two things that might be affected by these changes.


Aether2 is the moon or the moon is Aether2?

Version of Advanced Rocketry
AdvancedRocketry 1.12.2-1.4.0-84-UNSTABLE build -84 for 1.12.2
Have you verified this is an issue in the latest unstable build
this is currently the latest build, if you are asking weather or not it is specific to this build, I believe not
Version of LibVulpes
LibVulpes-1.12.2-0.2.8-32-universal
Version of Minecraft
1.12.2
Crash report or log (if applicable)
N/A
Description of the problem
The dimension # 3 is being used by aether2 while in this dimension low gravity is experienced (I have atmospheric effects off but I suspect I would get a vacuum warning too). Once while entering the game while in the aether2 the aether chunks started being replaced by moon like terrain chunks, after logging in and out the chunks replaced themselves with their correct aether variant. I found a DIM 3 in my save's advRocketry folder. I understand there is a conflict over who's dimension it is what should I do? Is it safe for me to delete the DIM 3 folder assuming there is nothing important there?
EDIT: I am renaming folder to DIM12, and modified xml Doc in advRocketry folder to say that "Luna" has the dimension number of 12, I'll let you know how it goes

what I tried didn't work, but exiting the aether2, launching the game without aether2, and then relaunching with aether2 with config options changing what dimension the aether2 is fixed this, and let me keep all progress made within the aether world


WIP: Fix travis

Let's see if this helps

[Current coverage][cc-pull] is 86.66%

Merging [#3431][cc-pull] into [master][cc-base-branch] will decrease coverage by <.01%

@@             master      #3431   diff @@
==========================================
  Files           339        339
  Lines         58243      58243
  Methods           0          0
  Messages          0          0
  Branches       8870       8870
==========================================
- Hits          50483      50479     -4
- Misses         5080       5083     +3
- Partials       2680       2681     +1

[][cc-pull]

Powered by Codecov. Last updated by [3efd6f8...2b288bc][cc-compare]
[cc-base-branch]: https://codecov.io/gh/mne-tools/mne-python/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/mne-tools/mne-python/compare/3efd6f8b411571c481f45d03028c6fb9b83d43b1...2b288bcaa30a595ff865cf77e502b2fcd87a1c5a?src=pr
[cc-pull]: https://codecov.io/gh/mne-tools/mne-python/pull/3431?src=pr

I'll take it


Fix Package Version: IObit.DriverBooster 11.1.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: https://github.com/microsoft/winget-pkgs/tree/master/manifests/i/IObit/DriverBooster is the name of the directory containing the manifest you're submitting.

The present version number for IOBit Driver Booster in the Winget manifest includes an extra build number, leading to the application incorrectly detecting updates. During a manual installation, a winget list displays the version as 11.1.0, whilest the manifest specifies <IP_ADDRESS>. This pull request addresses the inconsistency by removing the unnecessary build number, ensuring accurate update detection, and aligning the installed\displayed version with the manifest.
I've also expanded the list of tags to enhance its comprehensiveness.
Regards
Tom
Microsoft Reviewers: Open in CodeFlow

Apologies at this continuing error.

Sequence contains no elements


First Contribution: I added a circle to the confetti, I think

Also for future reference, your pull requests should contain the following


BoundPods should have field -- ListMeta, instead ObjectMeta

BoundPods is a list of Pods bound to a common server, it should have ListMeta field, like other List type object, instead of ObjectMeta.

This is obsolete, close it.