Using NSwag with .NET Core requires import of PCL profile

When referencing NSwag.AspNetCore you need to import PCL profile in your project.json:
    "netcoreapp1.0": {
      "imports": [ "portable-net45+win8" ]
    }
  },```

Please add netstandard1.0 target framework to nuget packages. As far as i know, netstandard1.0 is equivalent to PCL 259 profile.
https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md

Should be added to all PCL packages... (NSwag & NJsonSchema), please check and reopen if this is still an issue

Thank you! Removed imports - restore works now as expected.


Remove Cargo.lock

Description of change
Libraries don't have their Cargo.locks checked in: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
This PR removes all Cargo.locks and adds it to .gitignore.
Links to any relevant issues
None.
Type of change
Enhancement (a non-breaking change which adds functionality).
How the change has been tested
cargo test

It should pass.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that new and existing unit tests pass locally with my changes

While the Cargo.lock is not checked in for libraries by convention, we include it so that builds are reproducible across CI and development environments. It also helps with caching (https://github.com/iotaledger/wallet.rs/pull/258). @Thoralf-M @laumair what are your thoughts?

For caching it should also work without it I think, but we need to change the workflows so the lock files aren't hashed there and maybe store the target folder after every build (don't know if we have limitations there)

Unless we do have pre-built binary users I would still propose removing it; it's the binary (executable) developers who are responsible for keeping the build reproducible (by including their Cargo.lock in their repository).
For workflows I will take some time to look into it to ensure nothing breaks.

Unless we do have pre-built binary users
For the bindings the binaries are created from our state (for nodejs and python in the workflows), so should we keep them there? For wallet.rs itself I don't see a problem with removing it

We do have people using the prebuilt binaries, so we should at least keep the lockfiles for the bindings.

@rajivshah3 I also thought that, but at the end they will use the released version and there they can just use a fixed version?

Hmm, I guess they could. If the prebuilt binary does not work for some reason though, there's no guarantee that they will build their own binary with the same dependencies as the prebuilt one.

I think I need some more investigation. Before this, please don't merge.

I think I closed the PR by accident, but this is what I intend now.
I did my own research (tm) and it turns out to be necessary to keep Cargo.lock in the repository and it doesn't actually cause any trouble:

Our users won't use Cargo.lock anyways (neither won't it be published to crates.io).
We publish binary build ourselves, so Cargo.lock is helpful for our deterministic builds.
"It also helps with caching (#258)" -- in CI workflows; including the hash of .lock files in the cache keys looks like a common practice.

Closing this for now (oh it's been closed, nevermind).


Usability for a translatable field of a model?

First of all, amazing work with this package @dimsav !
I'd like to ask if you (or anyone else) believe that it can be helpful in a case of having a translatable field.
In specific, I have got a a movies table which has a title field among the other fields but the only translatable is actually the latter.
Then, I have got a movie_translations table with translated_title and locale fields.
Does it worth from your point of view the package or it will be an overkill?
Many thanks again for this package!

This package does the same like your example - you have a second table with all translations.
For a single field this adds an overhead cause you everytime need a join and/or second query.
There is a package by @spatie that does it by using the MySQL5.7 JSON column: https://github.com/spatie/laravel-translatable
If you met all requirements I would recommend you to use this package. By the way: spatie creates awesome and outstanding packages! 😉

@Gummibeer Many thanks for the insights! I am sure that spatie also creates awesome packages. 🙂


issue with clangd and spacemacs on Catalina 10.15.7

Hi,
I have been trying to debug an executable on 10.15.7 written in C11. I loaded the executable and tried to run but I got an error message from the debug server a couple of seconds later saying that:
error: Attach failed: "Not allowed to attach to process.  Look in the console messages (Console.app), near the debugserver entries when the attached failed.  The subsystem that denied the attach permission will likely have logged an informative message
I checked the console app and I got a couple of entries of that:
error: MachTask::TaskPortForProcessID task_for_pid failed: ::task_for_pid ( target_tport = 0x0103, pid = 10984, &task ) => err = 0x00000005 ((os/kern) failure)
Then that:
error: MachTask::StartExceptionThread (): task invalid, exception thread start failed.
That:
error: MachProcess::AttachForDebug failed to start exception thread: unable to start the exception thread
and finally I got the first error message again.
I am assuming that there is a security thread by the debugserver process?
If I run it standalone on the lldb it is working fine.
Thanks for your help!

I don't understand how this is related to clangd. Clangd deals with powering editor language features (like go-to-definition, semantic highlighting, find-references etc.) only, not debugging.

the debugserver needs to be codesigned, or if you're using gdb, gdb needs to be code signed.
usually, tell your debugger front end to use the system debugserver.
but certainly nothing to do with clangd.

Alright, thanks for your help though and sorry for the irrelevant issue. Ill close this thread.


Add Utility Functions to Base New Colors on Existing Colors

I wrote a few utility functions that complement that ansi-colors branch to manipulate ANSI codes and color maps.  These functions make it possible to mix in new attributes to existing colors, which lets you make things visually distinct while preserving the original theme. If you think library users would benefit, feel free to incorporate these somewhere.
(defn merge-colors [a b]
  (cond
    (and (sequential? a) (sequential? b)) (into (vec a) b)
    (sequential? a) (into (vec a) (vector b))
    (sequential? b) (into (vector a) b)
    :else [a b]))

(defn cmap [color-map]
  {:color-map
   (merge-with merge-colors (:color-map (get-options)) color-map)})

(defn kcol [key-color]
  (let [{kw :keyword, :keys [number string]} (:color-map (get-options))]
    {:key-color
     (into {} (map (fn [[k v]]
                     (cond
                       (keyword? k) [k (merge-colors kw v)]
                       (string? k) [k (merge-colors string v)]
                       (number? k) [k (merge-colors number v)]
                       :else [k v]))
                   key-color))}))

(defn cstyle [ckeys style]
  (cmap (into {} (for [ckey ckeys] [ckey style]))))

(defn kstyle [mkeys style]
  (kcol (into {} (for [mkey mkeys] [mkey style]))))

Here's a short REPL session using cmap and cstyle. Both functions apply additional styling to selected elements in the current color-map. cmap accepts a color-map as its input. cstyle takes two sequences: a sequence of color-map keys and a sequence of ANSI codes to apply to those elements.

More REPL interaction using kcol and kstyle. These work analogously to cmap and cstyle.

I managed to sort of miss this when I was putting together 1.0.1.  Do you see these functions as something that would still be useful, given that I've taken all of your pull requests (pretty much as is)?  Thanks!

I'm fine with closing this issue if you like. I think the idea behind these functions still has some validity, but I'm not entirely happy with their implementation. I've iterated them a time or two but don't yet have a result I'm completely satisfied with. With the changes you've folded in, I can now use these with the official zprint instead of just my fork, which is nice! You can always reopen if more users request similar functionality. For now, I think things are fine as is.

Thanks!


How do I use the test DC to test auth flow?

I am following the instruction on https://core.telegram.org/api/auth#test-accounts
I am definitely setting my useTestDc parameter to true
My test number is<PHONE_NUMBER>
I entered OTP 222222
The Phone Code is invalid.
What am I doing wrong?

The code was changed back to "22222" (5 digits).

Thank you. That worked


maximizing velocity

Is there way to make sure that the optimizer maximizes velocity? I want to get a trajectory that allows me to reach the destination as fast as possible.

Basically you want to minimize trajectory time. Please try the recently developed nonlinear optimization techniques to minimize segment time. See https://github.com/ethz-asl/mav_trajectory_generation/blob/devel/time_allocation/mav_trajectory_generation_ros/src/time_evaluation_node.cpp#L359-L383 for an example of Mellinger's relative time segment minimization.

Update, the code is now in master. https://github.com/ethz-asl/mav_trajectory_generation/pull/73


Remove this._placeholder usage

Fixes #80
The test suites are in vaadin/vaadin-dropdown-menu#116
For better CR experience, please use ?w=1: https://github.com/vaadin/vaadin-overlay/pull/85/files?w=1

This change is

The build is failing because of stylelint, related PR: https://github.com/vaadin/stylelint-config-vaadin/pull/2

After https://github.com/vaadin/vaadin-date-picker/pull/542 has been merged, the build is green and the PR is ready for review.

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

src/vaadin-overlay.html, line 476 at r1 (raw file):

      _detachOverlay() {
        // The detaching overlay is happening after closing animation is finished.

The source code doesn't need long explanations like this if the element is tested properly. Not a blocker.

Comments from Reviewable

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 3 of 3 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


When invalid value is passed to memory parameter for acorn run command, pods get deployed with only the numeric part of the memory string.

acorn version v0.5.0-rc3-18-gfbe46a2+fbe46a25
When running this command , all the pods in the app deployed with Memory limit and request set to 100.
acorn run -m 100a -n test4 .
Expected Behavior:
User should be presented with an error message about the invalid memory value passed.

Directly tied to our use of cuelang under the hood, so not fixing now. Could get fixed as part of AML rewrite


Logo, Search, and Block Hero Annotations Not working

the el selectors don't seem to correlate to the pattern html. PR issued.
https://github.com/pattern-lab/starterkit-mustache-demo/pull/1

@justinlevi -
Great catch. I'll merge this to dev tonight on my local machine and push out an update. We really appreciate the PR.

This has been merged and v4.0.1 of the demo has been released.


[Bug] Unused External Parameters when quantizing Command-R-Plus

🐛 Bug

To Reproduce
Steps to reproduce the behavior:

Download Command-R-Plus (either variant)
Attempt to quantize with convert_weight
Get above warning

Expected behavior
Should load and quantize the weights like normal
Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA): CUDA
Operating system (e.g. Ubuntu/Windows/MacOS/...): Ubuntu
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...): L40
How you installed MLC-LLM (conda, source): pip
How you installed TVM-Unity (pip, source): pip
Python version (e.g. 3.10): 3.10.12
GPU driver version (if applicable): Unknown
CUDA/cuDNN version (if applicable): CUDA 12.1
TVM Unity Hash Tag (python -c "import tvm; print('\n'.join(f'{k}: {v}' for k, v in tvm.support.libinfo().items()))", applicable if you compile models):

Any other relevant information:

Additional context
Normal Command-R works, only Plus has the warning

@TNT3530 Thank you for reporting this. Looks like the q_norm/k_norm is yet to be supported.

@tlopex Hi Shushi, I wonder if you have bandwidth to look into this? We already have the Cohere model in https://github.com/mlc-ai/mlc-llm/blob/main/python/mlc_llm/model/cohere/cohere_model.py but it doesn't support the q_norm and k_norm in attention when a config value use_qk_norm is true. So likely it's only the matter of supporting this.
Reference:

https://github.com/huggingface/transformers/blob/main/src/transformers/models/cohere/modeling_cohere.py#L264-L269
https://github.com/huggingface/transformers/blob/main/src/transformers/models/cohere/modeling_cohere.py#L305-L307

@MasterJH5574 Okay! I'll try to support this later.


Swift 3 adaptions (⚠NOT READY⚠)

Hello there,
I really need to use this framework with Swift 3 so I tried to convert it, the framework itself runs and compiles perfectly, however when using it in my app it crashes when I try to invoque it, similar to issue #49.
Here's the code just in case it servers of any help.
Thank you,
tiferrei

Hey,
I fixed this crash changing the line 190 to the shown on the image.

Well, I know it's not that applicable, because this line would receive the NSFontAttributeName automatically from the TextView.
But for me it's working fine now.

Hey @alissonbarauna, thank you so much, but my code is still crashing, I must have gone wrong somewhere else, do you mind if I take a look at your version of the code?
Thank you so much!
tiferrei

Tiago,
My JSAlert.swift is attached. I have made some changes on fonts and colors. But the rest is about the same.
If you have any question, please let me know.
Thanks.
JSSAlert.swift.zip

That's perfect @alissonbarauna, thank you so much!


Feature/remove estimates

Short Description
Removing estimates (depth/width) during implementation selection. Closes #22 .
Proposed Changes

remove estimates
adapt prolog queries

Fixes:

LGTM


Training your own model

As I can see, the model is downloaded from some remote server. Can I train my own model from a dataset (containing Java programs, I suppose?). Can you provide some instructions?

The batch DOM driver module could not be used to generate the sketches.
When I calling the target/batch_dom_driver-1.0-jar-with-dependencies.jar package, it prints out the first line of file.txt, and there's no movement left. But I can call the DOM driver module to generate sktech.
In addition, I have two questions:

The config.json of batch module could refer to DOM driver module. So, should I add as much API -packages and API -classes to config of batch module as possible?
When the module does not respond, I wonder if there is something wrong with the format of my file.txt. The first line of my file.txt is: /home/zyt/workspace/bayouData/java_file/DisjointSet.java


Zero values for impact metrics

Tried using the scenario of rain-induced landslides for Nablus. Impact metrics show zero values. Could be an issue with loading the full content of exposure database. Input data and analysis log are attached.
test_nablus_landslide.zip

Hi Karim,
Short version:
If you remove the last two fields in "expstr" of landslide fragility, it will work.
For instance:
Original version:

New version:

Long version
Source of the problem:
The problem is related to the incompatibility between "expstr" is landslide fragility and "expstr" in building layer.  The "expstr" in landslide fragility is composed of material type and code level such as "Adb+LC" or in your case  "CR+CIP/LDUAL+DUL+HC".   However, in you landslide fragility excel, you specify height and occupancy type.
Why:
You may wonder why we don't create a 1-to-1 mapping between expstr columns of building and landslide fragility. The reason is that, it will require to include all unique exposure strings in the fragility. This means lots of repetitions. In Rapti study, the team suggested that the susceptibility only depend on material and code level. So we decided to use "material type + code_level" in expstr of landslide.
There is some explanation here but they are not clear enough.
Quick solution
The fast solution is to get rid o the last two fields (height and occupancy) in landslide fragility. In this way, without and change in webapp, you can run landslide computation.
Another solution
We can change the engine so that the expstr of building and landslide fragility must match.  In this case Rapti landslide fragilty data should be regenerated.
My suggestion
You go for the quick solution. In the meantime let keep this issue open, and discuss this further in future.

And make sure the combination of  expstr and susceptibility in landslide fragility is unique . Added @jamaldabbeek

Added a new pre-compute check related to this issue: https://github.com/TomorrowsCities/tomorrowscities/pull/38

Can you try with this fragility:
vulnerability_landslides_update.xlsx

thanks it is working


[CU-8688cu5e0] Requests images with explicit width and fallback to original

This change prevents requesting download when opening images in a separate tab

Task linked: CU-8688cu5e0 Don't offer original image in the image details panel


no disk caching

closes #19 (good enough for now).  by adding xmlschema.__version__ and ome_types.__version__  to cache key, and using shelve instead of pickle directly.  That has the potential to make the cache big for local development, so added clear_schema_cache function that gets called on import when the cache is >30MB.

Codecov Report

Merging #20 into master will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   95.20%   95.46%   +0.26%
==========================================
  Files           1        1
  Lines         396      419      +23
==========================================
+ Hits          377      400      +23
  Misses         19       19

Impacted Files
Coverage Δ

src/ome_autogen.py
95.46% <100.00%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4012024...7170d61. Read the comment docs.

@jmuhlich thoughts?  I removed all disk caching, moved the 2016-06 schema into source and use it in the special case that the url matches... and use lrucache for within session caching.

Where does this stand? Do you want to change anything or should I look it over one last time?

lemme have one more look.  I think I was convinced about something (:smile:) previously and needed to go back and implement it.

ok, have another look.  I didn't quite hardcode it, but I made sure that no network requests are happening (fully turned off internet and tests still pass...) and prevented the potential KeyError for identities.
Tests actually now run 3x faster without all the requests!  thanks for pushing on that.

And whoa do those tests fly now!

Shouldn't the namespace be checked with == not in? Also we should only have that literal URL string written one place in the code

both changes made, thanks!  merging


Update README.md

[Current coverage][cc-pull] is 63.59%

Merging [#16][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #16   diff @@
==========================================
  Files            13         13
  Lines           596        596
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            379        379
  Misses          217        217
  Partials          0          0

Powered by Codecov. Last updated by [f40fe6d...e20400c][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pranavtbhat/ParallelGraphs.jl/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pranavtbhat/ParallelGraphs.jl/compare/f40fe6d68841e24afc730efaa307bdb7378ccccf...e20400c55bc73b2c6dd9d4d0dc3558b7284bb60d
[cc-pull]: https://codecov.io/gh/pranavtbhat/ParallelGraphs.jl/pull/16?src=pr


AWS CDK provider

Describe the solution you'd like
Currently Amplify only supports direct CloudFormation as a provider, and does so by using JSON templates. I read somewhere that other providers can be implemented, and that a future goal is to support multiple providers. It would be great to have an AWS CDK provider, that constructs similar features, but in CDK code.
I feel like this would make it easier to implement new features in Amplify, leveraging common usecases and improvements (eg. asset upload, AWS SAM transformations, YAML output, etc)
Currently I wasn't able to find much of any information/documentation on what is required to implement a custom/new provider, so maybe documenting that/making it easier to discover would be useful as part of this also.
Describe alternatives you've considered
Using AWS CDK / SAM separately, and/or consuming externally generated resources through exports.
Additional context
See also: https://github.com/aws-amplify/amplify-cli/issues/160

any update on this one? any feedback from amplify/cdk teams?

First off, @hassankhan really nice break down.
To build off of this issue, I've worked enough with both amplify and cdk now be considering converting an app (which is currently in development) to using cdk instead of amplify's environment building. I need more flexibility which is more of a me problem than an amplify problem but I'm finding myself doing really tricky operations to get things to work like I need it to.
One thing I'd like to propose is, why can't both of these tools live separately but compliment each other better? This might be the easiest path forward.
Couple things to consider here:

(reiterating a couple point from @hassankhan) Amplify/CDK team can create an amplify solution/pattern similar to aws-ecs-patterns. This proposed Amplify pattern would create the Amplify app/branches/etc with cloudformation. Asset support for resolvers and pipelines for AppSync would be awesome
Decouple cloudformation template generation and deployment from the amplify cli. For my team this means:

Being able to generate the GraphQL typescript/javascript code (which I think we can currently do as long as we have the GraphQL schema).
Allow amplify mock to work with an app that's not completely controlled by the amplify cli. If you have any suggestions on how to make this currently work.

Deployment could work completely thru cdk, at least, until the addition of the cdk provider makes sense.

I'd love to see a cdk + amplify partnership/crossover/something in the near future. Love what has been said so far. Right now, I am starting another project and am going to use the cdk exclusively. I am finding I miss the way amplify made things easy for the initial setup of an app, specifically api + auth + lambda + dynamodb. If there were a few simple cdk stacks you could generate with amplify that would be really helpful.

+1

Would love to see this! I think it would also solve https://github.com/aws-amplify/amplify-cli/issues/3068 and https://github.com/aws-amplify/amplify-cli/issues/4800, because the generated cfn templates would not need to be committed to the repo.

any update?

Any news?

Just noticed this article, it may help: https://docs.amplify.aws/cli/custom/cdk/

Hello as noted above we have integrated CDK into Amplify CLI last year and introduced override behavior:
https://docs.amplify.aws/cli/custom/cdk/
https://docs.amplify.aws/cli/migration/override/
https://docs.amplify.aws/cli/graphql/override/
https://docs.amplify.aws/cli/restapi/override/
We're also investigating some of the other sub-functionalities embedded in this issue such as drift detection and change sets. For now we will close this feature request but please open a new issue if you have additional feedback around these areas.


fix: prevent chain supply attack via compromised ua-parser-js 0.7.29

Closing as changes are already made in main


Add original transaction field to transaction

Refund transactions contain a field called: <original_transaction href="">, which links to the original debit transaction.
This PR adds a OriginalTransactionUUID field to the Transaction struct.
OriginalTransactionUUID field value is an empty string for transactions that do not have an <original_transaction> field.

Hey there 👋 @cristiangraz
I wanted to see if I could get this on your radar sometime for an initial review before Thanksgiving break!
Haley

Thanks @haleychen!


Validate validator addresses in delegation

Better error handling in this case. Both in the virtual staking contract and the whole Rust logic (handling said errors)
Also, share more info to the provider chain to prevent this in the first place. Let's think more.

🤔 There are some different layers where the validation can happen

Frontent
Provider contracts
Consumer contracts
Consumer chain - contains this logic already

IMHO: for fast feedback and best UX the validation should happen as close to the user as possible. The frontend has already the "problem" where it get's the validator data to display it. Adding a quick check there would be low effort.
The check on the consumer chain is mandatory for safety and built into the staking module already. Nevertheless bringing this closer to the provider can be beneficial to remove complexity in the contracts.
Checking for valid addresses in the entrypoint of the consumer contracts should be still within reasonable gas costs. The contract could either check with the chain data on every request or maintain a persistent accept list. That would add more complexity there though.
Validating on the provider side requires some data replication. Probably the simplest thing would be a bech32 check to reject random strings. A full validator set comes with some cost to maintain it proper. Options are push or pulling the data via IBC.


holoviews 1.10 no longer respects the order of coordinates of an xarray dataset

There is a change of behaviour between holoviews 1.9.5 and 1.10 with the way to build kdims from coordinates of an xarray dataset.
I noticed this because I have an images stack with coordinates (x,y,time) ; let's call it ds.
It is handy to visualize it with hv.Dataset(ds).to(hv.Image) because holoviews nicely infers that x and y are the kdims of the image and uses a menu for the time. With 1.10 though, the kdims become (time,x,y) and the inference is no longer what we could expect.
Here is a small exemple to reproduce this :
import numpy as np,holoviews as hv,xarray as xr
from collections import OrderedDict
data = np.zeros((3,4,5))
coords = OrderedDict(b=range(3), c=range(4), a=range(5))
dataset=xr.Dataset(coords=coords)
dataset['value']=([*dataset.coords.keys()], data)

The output is an xarray with dimensions (a,b,c) and coordinates (b,c,a) as we can check with print([*dataset.dims],[*dataset.coords]).
This command hv.Dataset(dataset).kdims gives:

output of 1.9.5 : [Dimension('b'), Dimension('c'), Dimension('a')]
output of 1.10 : [Dimension('a'), Dimension('b'), Dimension('c')]

Has it something to do with changes in the XArrayInterface?

I guess line 132 of core/data/xarray.py
kdims = sorted(kdims, key=lambda x: (xrdims.index(x) if x in xrdims else float('inf'), x))
is when the reordering happens so this relates to this commit.

Thanks for reporting this. It does seem to be a significant change in behavior and I think we should return to the old behavior for 1.10.1.

I'm no longer sure this is something we can do. It seems xarray does not guarantee a fixed coord ordering at the Dataset level even when given an OrderedDict of coords, which is why we switched away from that originally.

Additionally, it seems your example doesn't even seem to work in python 2. When I run this in python 2:
import numpy as np,holoviews as hv,xarray as xr
from collections import OrderedDict
data = np.zeros((3,4,5))
coords = OrderedDict(b=range(3), c=range(4), a=range(5))
dataset = xr.Dataset(coords=coords)
dataset['value']=(list(dataset.coords.keys()), data)
dataset

I get the following error:
ValueError: conflicting sizes for dimension 'a': length 3 on 'value' and length 5 on 'a'

Okay ignore my last message, that was simple down to the fact that in Python 2 and earlier versions of Py3 the OrderedDict constructor does not respect the order of keywords.

So the real reason I think supporting this is problematic is that unless you remember to use an OrderedDict to specify the coords then the order of dimensions will be arbitrary and if you want a specific order then you declare that using the kdims.

If there was some way to tell whether the coord order was defined explicitly or was just decided implicitly by the dictionary ordering I'd be happy to make use of that but as it is I'm inclined to stick with the new behavior for consistency.

I think that is a very reasonable decision. Perhaps one thing to do is to mention this in the docs?

Ok, I'm not sure to understand what is the new behavior ; is it to infer kdims based on dataset.dims?
Do you mean that we cannot rely on consistent coordinates ordering from xarray.dataset (coords could come from a dictionary) but we can rely on the ordering provided by dimensions (because it is sorted). So if holoviews is to infer kdims it should do this by using dataset.dims rather than dataset.coords.
I would agree if dataset.coords behaved like a dictionary but it acts as an OrderedDict (see dataset.coords.variables). And this is expected I guess since a dataset is supposed to be an in-memory representation of a netCDF file.
So dataset.coords.variables could act as a consistent source for holoviews.
What causes the potential inconsistency is that xarray allows the coordinates to be defined with a dictionary which can lead to incompatible corresponding netCDF files and so different inferences of kdims (with holoviews 1.9.5). But this inconsistency is within xarray, not holoviews.
The way people create xarray.datasets is not the responsibility of holoviews, and I'm not sure it should drive decisions about what holoviews does with datasets.
So this inconsistency should rather be reported and treated by xarray, no?
In my opinion, it is worth exploring the options here because I don't think that defining kdims as the lexicographic order of dimensions is that useful ;  it would most of the time need an explicit reindexing.

Ok, I'm not sure to understand what is the new behavior ; is it to infer kdims based on dataset.dims?

That's correct, it currently respects the dims ordering.

But this inconsistency is within xarray, not holoviews. The way people create xarray.datasets is not the responsibility of holoviews, and I'm not sure it should drive decisions about what holoviews does with datasets.

I think that's a good point. I'm also persuaded by the fact that dictionary will be ordered in future and support for Python 2 will be dropped. Also not making use of the specified coordinate ordering would be a shame.
I'll reopen a PR to address this shortly.


Added Syntax Highlighting support for Notepad++

I added in formatting for all the regex criteria from the sublime file  and from the documentation, including hex prefixes and numerical suffixes.
As for the style, I used the clean highlighting scheme in code from "Young Person's Guide to Bond" page:
https://microsoft.github.io/bond/manual/bond_cpp.html#idl-syntax
Let me know if I'm missing anything.

Could you please rebase squash into a single commit and change the commit title to Add syntax highlighting support for Notepad++ (for consistency).
One thing that doesn't work is map keys don't get highlighted. I don't know N++ lang syntax so I don't know why.

@sapek
Done! Yeah the process is a bit convoluted.
Added in missing keyboards, removed number suffixes and ignorecase, map should be highlighting now as well.

Thanks. However something went wrong in the rebase. Your commit now has changes in two files that were modified in other commits: appveyor.yml and cs/src/io/unsafe/StreamCloning.cs.

@sapek
Ah, got it all figured out now. Good to go.

Thanks. Merged manually @4bea59d783 (renamed Notepad to Notepa-plus-plus).


CPU temperature in monitoring

Could be great !
@Sikahalv

The psutil library we use to monitor system don't know anything about sensors, as it's probably not something consistent on every systems.
Seems there are some tricks, but again not consistent through every system, have to check http://stackoverflow.com/questions/2440511/getting-cpu-temperature-using-python

found on the french wiki :
cat /sys/class/thermal/thermal_zone0/temp and divide by 1000
source : https://github.com/recalbox/recalbox-os/wiki/Commandes-linux-(FR)


(feature): Automate the deployment of terraform changes

The process is currently too manual and could be automated.
Because of the above it is also prone to errors and I have found myself being in the wrong Terraform workspace with the wrong tfvars, which (depending on what you change) can be damaging.
Could have done a Terraform plan but since running apply without -auto-approve always provides a prompt to check planned changes it does the same job of giving the user a final confirmation step incase the terraform change might be dangerous.

Thanks @rjw1, shellcheck is happy now and I made the other 2 suggestions.


Error: [introspection-engine\connectors\sql-introspection-connector\src\introspection_helpers.rs:188:64] called Option::unwrap() on a None value

Command: prisma introspect
Version: 2.21.2
Binary Version: e421996c87d5f3c8f7eeadd502d4ad402c89464d
Report: https://prisma-errors.netlify.app/report/13243
OS: x64 win32 10.0.19042
JS Stacktrace:
Error: [introspection-engine\connectors\sql-introspection-connector\src\introspection_helpers.rs:188:64] called `Option::unwrap()` on a `None` value
    at ChildProcess.<anonymous> (D:\PJ\fym2\node_modules\prisma\build\index.js:39953:28)
    at ChildProcess.emit (events.js:315:20)
    at ChildProcess.EventEmitter.emit (domain.js:467:12)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)

Rust Stacktrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: <unknown>
  17: <unknown>
  18: <unknown>
  19: <unknown>
  20: <unknown>
  21: <unknown>
  22: <unknown>
  23: <unknown>
  24: <unknown>
  25: <unknown>
  26: <unknown>
  27: BaseThreadInitThunk
  28: RtlUserThreadStart

A possible duplicate of: https://github.com/prisma/prisma/issues/6982

Trace is exactly the same, I will close this one and reference it there.


chore(docs): docker-setup guide

@ericallam, Kindly take a look.
One more thing, I'd love to be assigned to good first issues so I can become more familiar with the codebase as time goes on. Which ones can you recommend?

Hi @ericallam,
In case you missed this and the latest update here 👉🏽 #175


Migration fails when solution and project file are in the same directory

We assume that the backup folder will not be put in the same directory as a project.json/.xproj project. However, for solutions where the solution file and project file are in the same directory, this doesn't hold true, and causes migration failure. We ask CLI to migrate the directory, and since we've already backed up the project.json/xproj, it will find and migrate two projects. This in turn breaks invariants, and causes silent failures.

Fixed with https://github.com/dotnet/roslyn-project-system/pull/1400.

can you check if that alaos fixes the case when the project is associated with multiple sln \mlangfs1\public\Jinuj\IPA\Multisln , open Multisln\ClassLibrary2\src\ClassLibrary1\ClassLibrary1.xproj


Are there supposed to be blank lines between each line output?

More a question than an issue.  This screenshot shows the output I see from a test runner, and each log entry written using logger.LogInformation() has an extra blank line:

Everything seems to work fine, but the output files are twice as long as they need to be, and lots of scrolling up and down ensues.
Is the extra blank line intended, is it configurable to remove it?

I actually prefer the whitespace because I like the visual break between log messages. It shouldn't however be there OOTB and people can write their own formatter if they want that whitespace in there.


cmake: linker: Use the same linker for cmake checks and final build

Currently, the linker that is used when performing various cmake checks (check_c_compiler_flag, for example) may be different than the linker that will be used during the actual build. This happens as we currently specify '-fuse-ld' to force the appropriate linker a) after many such checks have already happened and b) in a way which is not automatically propagated to check_c_compiler_flag (and friends). As a result, the toolchain's default linker will generally be used for such checks regardless of which linker was selected in Zephyr.
This can lead to a number of surprises when building Zephyr, particularly when building with clang. For example:

If the linker is misconfigured, where the build will fail can vary depending on whether the linker is the toolchain's default. When the configured linker happens to be the toolchain's default, the build (helpfully) fails quickly on the checks for a basic working toochain. When the configured linker isn't the default, the build won't fail until the final link steps.
The build can fail due to issues with a linker other than the one configured by the user in Zephyr. For example, LLVM toolchains without lld will generally fail to build Zephyr (the checks for a basic working toochain will fail) for targets where lld is the default in LLVM even if GNU ld is configured in Zephyr and would otherwise be used in the final build.
Flags which are only added if check_c_compiler_flag (or similar) succeeds may be unexpectedly omitted during the final build if the flag is supported in the configured linker but is unsupported in the toolchain's default linker (as check_c_compiler_flag will test using the default one).

Note that this isn't limited to clang--even when we are building with Zephyr's SDK and force ld.bfd, we seem to use the 'ld' variant during the cmake checks (though this generally seems fairly harmless compared to mixing ld/lld or other proprietary linkers).
To fix this, ensure the appropriate 'fuse-ld' is set early enough and in such a way that the same linker will be used throughout the entire build.

@jonathonpenix I've taken this cleanup PR, adjusted it a bit to adopt to the changes from #77887 and included the changes in #78320 as 789b9df

Sounds good, thank you! I'll close this PR for now


Heading and LaTeX in callout title not displayed correctly

Describe the bug
> [!quote] Callout with `code`, **emphasis** and a formula in the title: $\frac{\sqrt{k}}{A \cdot B}$
> Callout content with `more code` and another formula: $\frac{\sqrt{k}}{A \cdot B}$

> [!quote] ## Heading 2 in a callout
> Callout content with `more code` and another formula: $\frac{\sqrt{k}}{A \cdot B}$

Result:

To Reproduce
Use above markdown, see rendering
Expected behavior
Like Obsidian renders it:

Screenshots and Source
See above
Desktop (please complete the following information):

Quartz Version: [e.g. v4.2.3]

On my side I actually was able to properly render a LaTeX formula in callout title with the exact code you provided. Not really sure if it matters, but I am using KaTeX to render.

For a heading in callout title, I think a workaround is to use HTML tags, i.e.,

> [!quote]
Heading 2 in a callout

renders


After update to 2.8: sending private mails sometimes doesnt work

I updated on my debian oldstable (jessie) server from 2.6.3 to 2.8. There is one user of hubzilla who now can't send me private mails using hubzilla any. He can write the mail, but when he presses the send button, nothing happens. The user is using some ipad (~ 4 years old).
I don't know yet how I shall debug it, if it is related to some browser stuff, the ipad or not. My main question so far therefore is the following:
Does anyone else have problems sending private mails with hubzilla after the update? -- with which devices?

Nobody else reported such issue. Closing for now...


Snowflakes freeze when page loading is taking too long

They don't fall and only move left and right until page is loaded

can you get an example of this somewhere?

can you get an example of this somewhere?

https://user-images.githubusercontent.com/43725099/205515640-cd4e54fa-f254-4ca9-8e89-30a295214166.mp4

can't fix that, it's something inherent to css i think. there's nothing im doing which would cause that, all the animations are through CSS

:pain:


refactor(docs): generate documentation with Material for MkDocs

Remove previous Jekyll based GitHub pages and replace those with MkDocs based solution that uses Material for MkDocs theme with few custom overrides.
Also adds custom logic for markdown command reference generation to:

list command aliases in markdown files,
present command options in tables for increased accessibility,
display only long or short command description similarly than in --help outputs,
and use *cobra.Command instead of output filename as input to file prefix function.

To test this:
git fetch
git checkout gh-pages
python3 -m http.server 8000 # or any other command that starts static HTTP server

After merge:

Update GitHub pages settings to use gh-pages branch as is instead of Jekyll from main
Add link to GitHub pages to repository website setting

Good catch! I'll update Documentation section in README before merging this


ReplaceMessages RegExp is not allowing to escape *, (, [ etc..

If I try to replace ** with <b> using ReplaceMessages=[ ["\*\*","<b>"] ] I get:
invalid escape character '*'; only the following escape characters are allowed: \b, \t, \n, \f, \r, \", \\, \uXXXX, and \UXXXXXXXX

You need to escape the \ because of toml
Try ReplaceMessages=[ ["\\*\\*","<b>"] ]


NS-CACHE: Eviction from the cache

Explain the changes
Cached chunks are evicted when a namespace bucket with cache starts to fill up.
The tier ttf worker will periodically perform the eviction.
When bucket reaches a predefined limit, entries are no longer cached
Any in transit objects/chunks are also dropped.
Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

Another note was about the call to usage_aggregator.get_bandwidth_report() in the worker here:
https://github.com/noobaa/noobaa-core/blob/0f732250b83ce4581fe73639e70bbc51140db32b/src/server/bg_services/tier_ttf_worker.js#L74-L79
@nb-ohad suggested to use lower time_range and sum up the results.

@jackyalbo Please review and change your review to approved if you have no additional comments - we are trying to complete this PR this week. Thanks


How do I trigger my function on-demand so I can test it?

When testing, it's inconvenient to wait for the timer to trigger. How can I trigger the function on-demand? It would be nice for the documentation to cover this for both local deployments and Azure deployments.
For functions deployed in Azure, from a lot of searching, I learned that this can be done on the "Code + Test" page for the Azure Function.
Perhaps this can be solved by including a link to the page Manually run a non HTTP-triggered function
Adam Comella
Microsoft Corp.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5527c3b-a5da-c73d-66c2-20d96003ff7c
Version Independent ID: 42154c7b-b0e0-26db-79bc-3f1673c48e40
Content: Timer trigger for Azure Functions
Content Source: articles/azure-functions/functions-bindings-timer.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hi @rigdern Thanks for reaching out. We will review and update as appropriate.

@rigdern There is a already a public doc which you have already mentioned.
https://docs.microsoft.com/en-us/azure/azure-functions/functions-manually-run-non-http
To be more precise this one is even more beneficial.
https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-scheduled-function
I don't think there is a doc change required at this moment. For now will proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@DixitArora-MSFT I believe this issue should be reopened.
My feedback was about the page Timer trigger for Azure Functions.
My suggestion is that the page Timer trigger for Azure Functions should link to Manually run a non HTTP-triggered function. This will make it easier for developers to find this information.
Rationale for My Suggestion
This suggestion comes from a pain point in my personal experience using Azure Functions. I thoroughly read the doc pages related to the Timer trigger trying to figure out how to run them on-demand. I couldn't figure it out. It was only days later that I accidentally came across the doc page Manually run a non HTTP-triggered function. I believe my suggested doc change will save future developers from experiencing this pain point.

@rigdern I have assigned this to content author for further review and update as appropriate.

Thanks, @rigdern - The link is now added to the page. The public version will update during our next content refresh.
#please-close


[BUG] Could not fix trailing comma in jsconfig.json file

Describe the bug
How to reproduce the bug:

use pnpm create vite to create a vue+javascript project
pnpm add -D @sxzz/eslint-config eslint
add

{
  "eslint.experimental.useFlatConfig": true
}

to .vscode/settings.json file
4. when I press cmd + s to save and fix my code, eslint can't fix trailing comma in jsconfig.json file, besides, I found out that eslint cant't fix App.vue as well. However it's working for HelloWorld.vue. It's so weird!
I can't find out the reason 😢 If you need more help information, I'm glad to help debug.
Reproduction
https://github.com/Alkaidcc/js-repro
System Info
System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M2
    Memory: 58.58 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/Library/Caches/fnm_multishells/9789_1706523927230/bin/node
    Yarn: 1.22.19 - ~/Library/pnpm/yarn
    npm: 10.2.4 - ~/Library/Caches/fnm_multishells/9789_1706523927230/bin/npm
    pnpm: 8.14.0 - ~/Library/pnpm/pnpm
    bun: 1.0.25 - /opt/homebrew/bin/bun
  Browsers:
    Chrome: 121.0.6167.85
    Safari: 17.2.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

// jsconfig.json
{
  "compilerOptions": {
    "baseUrl": "./",
    "paths": {
      "@/*": ["src/*"], // when I press `cmd + s` to fix it, the comma won't disappear, and the error will still exist
    },
  },
  "include": ["src/**/*"],
  "exclude": ["node_modules", "dist"],
}

Your project has no uno.config.ts, but you used all preset. Try to use sxzz() preset instead.
It'll detect your installed dependency and enable necessary features automatically.

import { sxzz } from "@sxzz/eslint-config";

export default sxzz([], {
  vue: true,
  prettier: true,
  markdown: true,
});

When I update my eslint config, vue files work well, but jsconfig.json still has trailing comma warning. Did I miss something?

Cannot reproduce. Please hover on warning and see which extension emitted the warning.

Not relate to ESLint, but VSCode settings. Maybe you can check https://github.com/microsoft/vscode/issues/102061


visualization - 2D keypoints with input image

Thank you for sharing your work.
I just wanted to visualize the input image with 2d pose estimation using the 3DPW test data set to see if the 3d estimation is correct.
I found the below code for visualization but strangely the 2d pose and image are severely misaligned. This code is not available?
https://github.com/hongsukchoi/Pose2Mesh_RELEASE/blob/master/data/PW3D/dataset.py#L216

Hi,
There are some things to check

Is the gt 2d pose aligned with the image?
Does the scale of data['pred_pose2d'] match the image's width and height?

I think the visualization code in get_item should work ok, could you provide your visualization?

This command I used for testing
"python main/test.py --cfg asset/yaml/posenet_cocoJ_test_3dpw.yml"
One example looks like this. The 2D pose and image are not aligned. However, I checked the 3D pose looks fine.

and also I found that the evaluation result is strange. It seems like something is wrong.
MPJPE: 263.8583
Evaluation start...
COCO MPJPE (mm)    >> tot: 263.87
COCO PA-MPJPE (mm) >> tot: 114.80

Hmm, I recently changed the 3dpw annotation files and maybe that's the problem.

I see. Can you share the previous one?

I got the previous annotation file here.
https://github.com/kasvii/GATOR/issues/2

@moonsh  Sorry for the late reply. I updated the annotation files and checked the visualization. And thank you for letting me know.


Rancher restart loggers and change config back on fluentd (containerd)

What kind of request is this (question/bug/enhancement/feature request):
Question/bug:
Why does Rancher reset my fluentd config and restart loggers after 1 hour?
I am trying to get around the problem of fluentd loggers not being able to parse containerd logs due to not being in json (pattern dont match) and therefore not sending logs to Elasticsearch. Found solution but Rancher resets config and restart logs after 1 hour.
Steps to reproduce (least amount of steps as possible):
Rancher 2.3.5 running containerd
Enable cluster logging
Logs does not match pattern since it is not json
Change fluentd config in system/secrets source to:
`
<source>
@type  tail
path  /var/log/containers/.log
exclude_path ["/var/log/containers/rancher-logging-fluentd.log"]
pos_file  /fluentd/log/fluentd-cluster-logging.pos
time_format  %Y-%m-%dT%H:%M:%S.%N
tag  cluster.*
<parse>
@type regexp
expression /^(?.+) (?stdout|stderr)( (?.))? (?.*)$/
time_format %Y-%m-%dT%H:%M:%S.%L%z
</parse>
</source>

`
(potentially change elastic document type to _doc)
Restart logs.
Logs work. After one hour Rancher resets the config and restarts the loggers. Logs dont work anymore.
Result:
Logs send for one hour and returns to faulty state
Other details that may be helpful:
Environment information

Rancher version 2.3.5:
Installation option (single install/HA): Both (test env: single, prod HA) happens on both systems

I have a same issure

Same issue here!

Same issue!

Got the same Problem on 2 indenpendent rancher 2.6.3-patch2 Instances.
First I ran into the problem, that the resource limits were hilariously low, which I fixed by editing the yml.
Now I have the problem that i could not figure out how to edit the rancher-logging-fluentd-app secret so that it persists.
On 1 of these instances i managed to achieve this, but I can't reproduce what I did.

same here , i only want to add that i checked the Kubernetes API server audit log and i found out that the "cluster agent" is the one updating the secret back, i am not sure what triggers it though !
the kubelet is watching (sending watch requests) the secret too (not sure if this is normal )


feat: Draft Drilldown POC

🏆 Enhancements
Draft Drilldown POC

@zhaoyongjie and @villebro,
Any news on this? It would be great to have this implemented.

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: https://github.com/apache/superset/issues/13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.


License blacklist

From the README and looking at https://npmjs.com/packages/spdx-expression-parse it's not clear whether we can have a license blacklist, e.g. NOT GPL.
This could be useful, especially for existing projects where creating and conforming to a whitelist could take some time. It could be simpler to start with "no GPL" (for example) and go from there.

licensee does not currently support a blacklist, only an SPDX expression for approved licenses and a package-version whitelist.
I'm open to different experiences, but when I've seen rigorous license checks, they've almost always been whitelist-based.  Part of the issue is that a license-based blacklist doesn't save you much work when you're talking in terms of specific licenses, by SPDX identifier.  Which is what good package.json metadata does, and what we want to do when auditing.
Take your GPL example.  There are three versions of the GPL, as well as variants---LGPL, AGPL---in their own versions.  If what you're really concerned about is "copyleft", the GPL family alone doesn't cover it.  You also need to worry about MPL, EPL, OSL, and so on.  If you're just concerned about "strong copyleft", well, there's no standard definition or list of licenses for what comes in that category.
In the past, where I've used licensee for my own projects, I've often created an initial whitelist like so:
cd project
licensee | fgrep Terms: | cut -d ' ' -f 4- | fgrep -v Invalid | sort -u | tee list-of-licenses

That gives me some idea what I already have, so I can write a rule, run licensee again, and attend to any packages with invalid metadata.  Usually by reviewing them and whitelisting most.  When licensee passes, I check in the configuration , add an npm script to run it, and add the npm script to configuration for whatever CI service I may be using.  That way if I install a dependency with a license that isn't on the list yet, later, I'll see a failed build, and consider whether to add it to the rule.
If I build up a configuration for one project and start up a related project, I can reuse the config.

Thanks for the very quick reply! The comments about copy-left make sense. The workflow you describe sounds great, I will probably start using that for personal projects.
The use case I had in mind was scanning a very large number of repositories, and being able to know "do we depend on copyleft packages". For example: notLicense: (GPL OR AGPL OR MPL OR EPL OR OSL). I understand your point of view though, so happy to use the whitelist approach instead.

Thanks for your note.  I'll go ahead and close this one.
Just a quick tip in parting: Even the example you provided isn't a valid SPDX expression, since none of those strings are valid SPDX expressions.  You'll need to provide versions as well, like GPL-3.0.


v4

https://github.com/oekazuma/svelte-meta-tags/issues/1015

@ryoppippi
Svelte 5 support is complete!
Please create a pull request against this branch and continue working on https://github.com/oekazuma/svelte-meta-tags/pull/1145


Hue logging

Description:
Log some extra data to see why some people are seeing unavailable Hue lights.
Related issue (if applicable): #16689
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

HI,
where do you want us to report on the logging? Here, or in the community?

Let's keep it in #16689


Failure to connect to storage backends should fail readiness probe

Feature request
one of the basic functionalities of chains is to sign and attest workloads and push these somewhere which is defined by the storage backends like tekton, oci, gcs, docdb, grafeas.
when chains cannot connect to these storage backends to push signatures, attestations, etc, that violates one of the fundamental guarantees that chains provides and the readiness probe (or liveness???) should fail in such a case.
Use case
2 users have reported that they use mongo DB as a storage backend (via artifacts.taskrun.storage: docdb) but when the creds to connect to mongo DB were rotated, they expected chains to fail a probe and start restarting the chains controller pod so they could do remediation - instead chains continued throwing errors that it was not able to connect to mongo but did not start failing while not pushing any signatures, etc to mongo DB.

+1 this would be a great feature. I believe this was already done for KMS: https://github.com/tektoncd/chains/pull/936


Load Error

When loading a sav.josn I'm getting errors for all my boxed Pals. Saying "BOSS_JetDragon" "BOSS_Anubis" and "BOSS_Umihebi_Fire" if anyone knows how to fix.

Hey, it seems that BOSS creatures are coded differently from Normal Pals; I'll have a look at this and hopefully implement a solution by this evening.

Just rolled out an update that seems to fix the issue, let me know if it's not working.

That fixed it! You're awesome thank you!

Computers do be funny like that sometimes. Is it safe to close this issue?

Yea should be


add a kubernetes pod runner

adds a kubernetes runner.
this runner is unique in 2 meaningful ways:

it's a remote runner, and uses WorkspaceTar to retrieve the workspace post build

this involved re-introducing WorkspaceTar to the build flow, and nooping the existing local builders (docker and bwrap) implementation of WorkspaceTar

it's a more configurable runner, and relies on it's own config init semantics. this PR keeps things simple and only loads the config from a .melange.k8s.yaml file, but future PRs will expand this with more loaders

I'd like to get this in, even if we don't use it in wolfi yet, just so I can use it myself and put some miles on it. Is there anything major blocking this? An e2e test that uses KinD could also be pretty valuable, to guard against regressions.

I'd like to get this in, even if we don't use it in wolfi yet, just so I can use it myself and put some miles on it. Is there anything major blocking this? An e2e test that uses KinD could also be pretty valuable, to guard against regressions.

I spent some cycles cleaning this up end of last week, I'll update this PR and bring it out of draft today. I'd also like to get people playing with it, and we can make it pretty and iterate before using it in wolfi

@imjasonh is there plan to remove ttl.sh? it looks kinda sketchy here.

yes, we don't currently use the k8s runner anywhere serious yet, but as we plan on rolling it out more broadly we'll definitely force a default instead of falling back to ttl.sh

@imjasonh is there plan to remove ttl.sh? it looks kinda sketchy here.

yes, we don't currently use the k8s runner anywhere serious yet, but as we plan on rolling it out more broadly we'll definitely force a default instead of falling back to ttl.sh

is there anything specific about that melange image on ttl.sh? why can't we just use one from chainguard?

that config is the location of where the build workspaces are pushed by the client and fetched by the builder. there's no significance to ttl.sh/melange other than the repo where things are pushed, it just simplified the dev flow a bit during these early stages

we don't currently use the k8s runner anywhere serious yet

I'm currently using the k8s runner in both Rancher Desktop & AWS EKS, for an extra bullet point. I absolutely agree on making ttl.sh configurable, even if it's just to point to your own internal ttl.sh instance.


[Improvement][common] get application id in SHELL scripts

Describe the question
For now, if we execute a yarn job in a SHELL script, we find the application IDs in the logs by regex 'application_\d+_\d+'.
I think it's so ugly and has performance issues. So I suggest that we register an aspect when executing 'yarn jar' command,
we can weave a join point to org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.submitApplication, where we can get the submitted application id and the tracking URL, and output them into one local file
What are the current deficiencies and the benefits of improvement

deficiency:
need the aspectjweaver-1.9.6.jar file, which size is about 2MB
benefit:
no need to retrieve the whole log with the regex 'application_\d+_\d+'.
no need to restrict yarn client log level to INFO

Which version of DolphinScheduler:

all version

Describe alternatives you've considered
add the following two env to global envs
export YARN_CLIENT_OPTS="-javaagent:/pathto/aspectjweaver-1.9.6.jar"
export YARN_USER_CLASSPATH=/pathto/Aop2YarnClient-1.0-SNAPSHOT.jar
Then when submitting applications to the yarn cluster, the aspect in Aop2YarnClient-1.0-SNAPSHOT.jar will be registered, and we can get the submitted application id and the tracking URL
This is an example, I just output the application id to console

Here is the sample code

The solution is suitable for Hive, Spark, Flink, and other tools running the yarn cluster. 'hive -e 'hive sql'' test passed

I think this is a good idea

This is a public repo which can achieve this function, https://github.com/gabrywu/Aop2YarnClient

it will not be able to  fetch the applicationId in the case of use  HiveServer2 submitting the SQL,  should we consider storing the appId information in public storage? @gabrywu

it will not be able to fetch the applicationId in the case of use HiveServer2 submitting the SQL, should we consider storing the appId information in public storage? @gabrywu

Do you have any good ideas to resolve it?

it will not be able to fetch the applicationId in the case of use HiveServer2 submitting the SQL, should we consider storing the appId information in public storage? @gabrywu

Do you have any good ideas to resolve it? @xiejiajun

I thought about writing the appId to a public storage such as Mysql, but it will introduce additional  third-party service configuration such as JdbcUrl , so we still need to think about it carefully.

it will not be able to fetch the applicationId in the case of use HiveServer2 submitting the SQL, should we consider storing the appId information in public storage? @gabrywu

Do you have any good ideas to resolve it? @xiejiajun

I thought about writing the appId to a public storage such as Mysql, but it will introduce additional third-party service configuration such as JdbcUrl , so we still need to think about it carefully.

Yes, so the example project just put it to local file

@caishunfeng


Fix for the non-determinism issue on Command handler and Outgoing Commands

Adding changes to the zap templates such that the incoming and outgoing commands are generated with determinism. Using the upto date helpers in the *.zapt templates

Currently pointing to a zap repo which has new helpers as well. These changes have not been merged into the github zap repo
gihub#342
Problem
What is being fixed?

Github issue #342
This should fix the regen diff across regens
Fixes the generation for incoming and outgoing command handling

Change overview
Changes to ZAP generation templates: CHIPClusters.*zapt, im-cluster-command-handler.zapt to generate code accurately.
This PR depends on the following ZAP PR:
https://github.com/project-chip/zap/pull/388
Testing
How was this tested? (at least one bullet point required)
Regened multiple times to check that the CHIPClusters and im-cluster-command-handler generated files did not change across regens.

This PR requires the helpers added in https://github.com/project-chip/zap/pull/388 PR

It seems like the contents of CHIPClusters.* files are changed to contains codegen for command responses, which is not the intent there.
I'm also curious to understand why TestSpecific has dissapeared from the generated I'm-cluster-command-handler file.

I have responded to this in some form in the below comments as well. Any reason we do not have code gen for command responses? Also, are we sure that we are not excluding any outgoing commands from server to client which are not command responses?

This PR seems to change generated output. For a "Remove non-determinism" I would expect just that: do not alter output, just make it deterministic.
Why do the generated files change? If the change is needed, we should split PRs into 'change output' and 'remove determinism'

Got it cleaning it up based on determinism

R+ assuming Boris's comment is answered.

Note that at this point https://github.com/project-chip/connectedhomeip/pull/14581 will remove some (but not all!) of the bits being changed in this PR....

Note that at this point #14581 will remove some (but not all!) of the bits being changed in this PR....

Seems like the CHIPCluster and CHIPClientCallback templates are going away. Those are still non deterministic. Should I continue looking into fixing that?


Declare content-type for file uploads

There are web servers which like to have a valid content-type header defined for requests.
We would therefore expect that file uploads like we do in https://github.com/oss-review-toolkit/ort/blob/main/utils/ort/src/main/kotlin/storage/HttpFileStorage.kt declare the media type of the body. E.g. for ZIP file upload "application/zip".

As a work-around, you could configure / hard-code the content-type as a custom header, I guess.

Agree, that's what we have already implemented as a workaround 👍

I guess the challenge here could be that storages, esp. with https://github.com/oss-review-toolkit/ort/pull/5516, could be shared across users with different storage needs / content-types. So the content-type should not be stored per storage, but per user. Or even be made an argument in the FileStorage interface.

@vw-anton is this still a topic for you?

We have a workaround in place so no urgent need anymore.


The object check on subscribe() is to restricting and doesn't allow functions

Summary
While RsJS and zen-observable allow the object passed to subscribe() to be an object or a function, most.js specifically checks for typeof object which excludes functions.
Expected result
subscribe(f) where f is a function object is accepted
Actual Result
subscribe(f) where f is a function object throws an exception
Versions

most.js: 1.3

Steps to reproduce

create a function with a next() method
pass it to subscribe()

Code to reproduce
function f () {}
f.next = function (value) {}
most.from([1, 2, 4]).subscribe(f);

Fix
Change the line in subscribe() from:
if (subscriber == null || typeof subscriber !== 'object') {
to the style of check zen-observable does:
if (Object(subscriber) !== subscriber) {
or just check for a function directly:
if (subscriber == null || (typeof subscriber !== 'object' && typeof subscriber !== 'function')) {
Why allow functions?
I'm actually discussing with the knockoutjs team how they could keep backward compatibility of knockoutjs while providing interoperability with the TC39 Observable spec proposal. Knockout 'observables' are functions which we can extend to support the Observable and Observer specifications but only if an Observer is allowed to be a function. The spec. is not entirely clear but as RxJS and zen-observable appear to allow it and it offers a way for other libraries such as knockout to interop I wanted to request the change.

The knockoutjs discussion is here: https://github.com/knockout/tko/issues/22

Hey @far-blue, thanks.  It does seem like both zen-observable and rxjs allow it, so it seems like most should line up with that.  Would you be up for sending a PR that switches to the Object(subscriber) check?

There you go :)

Thanks @far-blue!  I'll release an update soon.
Fixed by #448


chore: reduce vscode extension bundle size

Description
reduce vscode extension bundle size
Checklist

[x] The base branch of this PR is dev, rather than main
[ ] The relevant docs, if any, have been updated or created

Screenshots
If your updates include visual changes, please share screenshots below.

very nice!


Inspecting data from the shell!

Description of Problem:

https://forum.rasa.com/t/inspecting-data-from-the-shell/20607
Overview of the Solution:

Examples (if relevant):

Would it be very hard to inspect original data from the shell. Let me give example :

/show intent greet
hi
hello
howdy
....

#pipe is grep

/show i greet | he
hello

look in the forum for more ...
Blockers (if relevant):

Definition of Done:

Thanks for submitting this feature request 🚀@amn41 will get back to you about it soon!✨

It sounds like you are suggesting to extend the cli command to add functionality for exploring training data. I'm not sure what this would add beyond opening a text editor and running control+F ?


Verify certificate failed in Openssl 3.0.0 When I didn't use default context.

Hi Openssl Team
It seems there is a bug when I try to use non-default context to verify certificate.
I used official released version(Openssl 3.0.0).
My compile flag is "perl Configure VC-WIN64A no-asm no-shared no-autoload-config no-pinshared enable-fips"
Following is my certificate verification fuction.
void verifyCert(OSSL_LIB_CTX* libctx, const char *propq = NULL)
{
	auto * xstore = X509_STORE_new();
	if (xstore == NULL)
	{
		printf("new x509 store failed.\n");
		return ;
	}

	auto * trustCert = readCert("turstcert.crt");
	if (nullptr == trustCert)
	{
		X509_STORE_free(xstore);
		return;
	}
	else
	{
		X509_STORE_add_cert(xstore, trustCert);
	}

	auto * xstore_ctx = X509_STORE_CTX_new_ex(libctx, propq);
	if (nullptr == xstore_ctx)
	{
		X509_STORE_free(xstore);
		X509_free(trustCert);
		printf("new x509 store context failed.\n");
		return ;
	}

	auto * verifiedCert = readCert("verifiedCert.crt");
	if (nullptr == verifiedCert)
	{
		X509_STORE_free(xstore);
		X509_free(trustCert);
		X509_STORE_CTX_free(xstore_ctx);
		return;
	}

	int iret = X509_STORE_CTX_init(xstore_ctx, xstore, verifiedCert, NULL);
	if (iret == 0)
	{
		X509_STORE_free(xstore);
		X509_free(trustCert);
		X509_free(verifiedCert);
		X509_STORE_CTX_free(xstore_ctx);
		printf("init x509 store context failed.\n");
		return;
	}

	iret = X509_verify_cert(xstore_ctx);
	if (iret == 0)
	{
		auto errcode = X509_STORE_CTX_get_error(xstore_ctx);
		printf("verify certificate failed, error [%d].\n", errcode);
	}
	else
	{
		printf("verify certificate success.\n");
	}

	X509_STORE_free(xstore);
	X509_free(trustCert);
	X509_free(verifiedCert);
	X509_STORE_CTX_free(xstore_ctx);
}

Here is my calling fuction. Because I don't want to use default context, so I load a "null" provider in default context.
	auto* nonfipslibctx = OSSL_LIB_CTX_new();
	if (nonfipslibctx == nullptr)
	{
		return;
	}

	OSSL_PROVIDER *def;
	def = OSSL_PROVIDER_load(nonfipslibctx, "default");
	if (def == NULL) {
		printf("Failed to load base provider\n");
		exit(EXIT_FAILURE);
	}

	OSSL_PROVIDER *defctxnull = NULL;
	defctxnull = OSSL_PROVIDER_load(NULL, "null");

	{
		EVP_default_properties_enable_fips(nonfipslibctx, 0);
		verifyCert(nonfipslibctx, "fips=no");
	}

	OSSL_PROVIDER_unload(def);
	OSSL_LIB_CTX_free(nonfipslibctx);

**In this scenario, it wll get a return code 0 in X509_verify_cert, X509_STORE_CTX_get_error(xstore_ctx) will return 1.
So when I commit //defctxnull = OSSL_PROVIDER_load(NULL, "null");, it can verify success.**
Can you help to check if it's matched with "https://www.openssl.org/docs/manmaster/man7/fips_module.html#Programmatically-loading-the-FIPS-module-default-library-context".
Best regards
forston

Firstly it will be helpful to see the OpenSSL error stack to see what hints it might give to the problem. For example after the failing call you could call ERR_print_errors_fp(stdout); to dump the error stack to stdout.
I suspect the problem is related to how readCert loads the certificates. My guess is the certificate being read is not being associated with the correct libctx and this is subsequently causing problems. Can you share the code behind readCert?

Hi Mattcaswell
I add the ERR_print_errors_fp(stdout);, it shows the following information:
E06C0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto\evp\evp_fetch.c:346:Global default library context, Algorithm (SHA1 : 96), Properties (<null>)
E06C0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto\evp\evp_fetch.c:346:Global default library context, Algorithm (SHA1 : 96), Properties (<null>)```

It seems that it still used the default context.

Following is the code of ```readCert```, I didn't find any new interface to set context in this scenario.

X509 * readCert(const char* filename)
{
FILE * fp = fopen(filename, "r");
if (fp == NULL)
{
printf("open certificiate file fail\n");
return NULL;
}
X509 * x = PEM_read_X509(fp, NULL, NULL, NULL);
if (x == NULL)
{
	fclose(fp);
	printf("read certificiate file fail\n");
	return NULL;
}

fclose(fp);

return x;

}

By the way, the "Signature algorithm" of my certificiate is md5RSA and "Signature hash algorithm" is md5. So in no-fips mode ,it should be verified success with default provider. And in fips mode,it should be verified failed with fips provider.

Please help to check this.

Best regards
forston

Following is the code of readCert, I didn't find any new interface to set context in this scenario.

From the man page for PEM_read_X509:
https://www.openssl.org/docs/man3.0/man3/PEM_read_X509.html

Some operations have additional variants that take a library context libctx and a property query string propq. The X509, X509_REQ and X509_CRL objects may have an associated library context or property query string but there are no variants of these functions that take a library context or property query string parameter. In this case it is possible to set the appropriate library context or property query string by creating an empty X509, X509_REQ or X509_CRL object using X509_new_ex(3), X509_REQ_new_ex(3) or X509_CRL_new_ex(3) respectively. Then pass the empty object as a parameter to the relevant PEM function. See the "EXAMPLES" section below.

So, basically you need to change your readCert function to create an empty X509 object with associated libctx using X509_new_ex(), and then pass that object as the second parameter to your PEM_read_X509 call.

Hi Mattcaswell
Thanks for your help.
After change the code of readCert , it can get expected result.
Following is new code of  readCert :
X509 * readCert(const char* filename, OSSL_LIB_CTX* libctx, const char *propq = NULL)
{
	FILE * fp = fopen(filename, "r");
	if (fp == NULL)
	{
		printf("open certificiate file fail\n");
		return NULL;
	}
	X509 * x = X509_new_ex(libctx, propq);

	if (PEM_read_X509(fp, &x, NULL, NULL) == NULL)
	{
		fclose(fp);
		printf("read certificiate file fail\n");
		return NULL;
	}

	fclose(fp);

	return x;
}

Best regards
forston

After change the code of readCert , it can get expected result.

Great. So can this issue be closed now?

yes, thanks


Added Simon Game to Projects section

This PR solves issue #9
Here's the demo video:
screencapture.webm
Please review this PR.
Thanks

good work @harmeetsingh11 . I am closing this issuse.

Hi @cleveranu. Can you please add GSSoC23 label to PR. Otherwise my PR won't count.


Added Ivan name. Yes, that's my name!

Thanks Ivan!
And @mustafa1453  - Thanks to you too :)
megred #1


Specified sinon version

Non-specified version leaded to confusion when API is changed

Great! I added package-lock.json to make dep versions are consistent.


(fix)[db] Fix create database and create table data race

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
There may be a race condition between CREATE DATABASE and CREATE TABLE. When CREATE DATABASE is being executed, the edit log may get stuck, while fullNameToDb in getDbNullable can still return the database. As a result, the CREATE TABLE process continues, which may ultimately lead to a strange order in the edit log of BDBJE, where CREATE TABLE appears before CREATE DATABASE.
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[x] This is a refactor/code format and no logic has been changed.
[x] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall


Hevon Family Application

name: Hevon
key: Hevon
color: blue
emblem: heart_04
info:
description: >
The Hevon Clan Family is a war family, consisting of 6 clans. Players are involved in Discord and CR activities!
social:
- discord: https://discord.gg/qsxKepCM3z
clans:

name: GrannyPunchers2
tag: L9UPCUGY
name: TEAM KNOCKOUTS
tag: YQJPR2V9
name: Indian Helix
tag: QQRYRP8G
name: Hevon
tag: GVVCUP9P
name: Hevie
tag: QYPV9LPQ
name: Shogun
tag: GGU29GLQ


Optimize queries which use bitmap indexes

There are two changes as follows.

decompress the bitshuffle-encoded pages in advance to fit the page cache
replace read with range_read to reduce function calls

@sevev
Could you split this PR into two or more PR?
This PR is somewhat big, a smaller PR will be more focus and is easy to review.

@sevev Could you split this PR into two or more PR? This PR is somewhat big, a smaller PR will be more focus and is easy to review.

ok，i will split this PR and resubmit soon


Create vtx.json

F - Fatshark
E - Boscam_e/DJI
A - Boscam_a
B - Boscam_b
R - Raceband
On Fri, Oct 30, 2015 at 10:31 AM, Nathan Nichols<EMAIL_ADDRESS>wrote:

Merged #1 https://github.com/natsn/freqman/pull/1.
—
Reply to this email directly or view it on GitHub
https://github.com/natsn/freqman/pull/1#event-450643198.

I like it! That makes things easier. And great Idea putting all the data in as json

So far we are splitting the profits 50/50 ;)

haha, that's the goal :)
On Fri, Oct 30, 2015 at 10:41 AM, Nathan Nichols<EMAIL_ADDRESS>wrote:

So far we are splitting the profits 50/50 ;)
—
Reply to this email directly or view it on GitHub
https://github.com/natsn/freqman/pull/1#issuecomment-152597742.

do you see a benefit to keeping the ID field? it's a pain to edit and I
don't see any reason we need it.
On Fri, Oct 30, 2015 at 10:42 AM, Lucas Crownover<EMAIL_ADDRESS>wrote:

haha, that's the goal :)
On Fri, Oct 30, 2015 at 10:41 AM, Nathan Nichols<EMAIL_ADDRESS>
wrote:

So far we are splitting the profits 50/50 ;)
—
Reply to this email directly or view it on GitHub
https://github.com/natsn/freqman/pull/1#issuecomment-152597742.

No need to have the ID field.
This is a great plugin though for dealing with the pain you describe: https://github.com/yulanggong/IncrementSelection

btw - should be able to create feature branches and push to this repo now - i added you as a collaborator.

coolio
On Fri, Oct 30, 2015 at 10:51 AM, Nathan Nichols<EMAIL_ADDRESS>wrote:

btw - should be able to create feature branches and push to this repo now

i added you as a collaborator.

—
Reply to this email directly or view it on GitHub
https://github.com/natsn/freqman/pull/1#issuecomment-152600620.

I'm assuming you've heard of framework7?
http://www.idangero.us/framework7/#.VjQnjIpHanM
On Friday, October 30, 2015, Lucas Crownover<EMAIL_ADDRESS>wrote:

coolio
On Fri, Oct 30, 2015 at 10:51 AM, Nathan Nichols<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

btw - should be able to create feature branches and push to this repo now

i added you as a collaborator.

—
Reply to this email directly or view it on GitHub
https://github.com/natsn/freqman/pull/1#issuecomment-152600620.


Update setup-miniconda action

See https://github.com/conda-incubator/setup-miniconda/issues/101

Codecov Report

Merging #682 (365e4e6) into master (f894595) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #682   +/-   ##
=======================================
  Coverage   82.52%   82.52%
=======================================
  Files          48       48
  Lines        7634     7634
=======================================
  Hits         6300     6300
  Misses       1334     1334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f894595...365e4e6. Read the comment docs.

Thanks for this fix to the GH actions @MaxGhenis!
Merging.


Inconsistent Syntax Highlighting for CMakeLists.txt

The syntax highlighting for CMakeLists.txt does not display correctly if one of the following valid cmake lines are included in the file:
#--------------------------------------------------
###################################################

See examples:

working:
https://github.com/wilkpio/test/blob/master/good/CMakeLists.txt
not working:
https://github.com/wilkpio/test/blob/master/bad/CMakeLists.txt

Please see Zendesk ticket 34391 (link not included) for reference.
Thanks,
Veesa

Linguist only selects the grammar to use for highlighting. For CMake, GitHub uses textmate/cmake.tmbundle. You should open an issue there if there isn't already one ;)


isPlaying takes on the wrong value if there is no next track

If next-track is activated but there is no next track, the music continues, but isPlaying is set to false.

Yes


Updated Geodesic and Goldberg Polyhera

@sebavan, @RaananW, @Popov72 this is a tidied up version. Have solved the import problem by switching from a Goldberg Mesh class to using a mixin.
Here are some very rough drafts of of it working (my workshop tests).
https://relaxed-varahamihira-799310.netlify.app/
https://relaxed-varahamihira-799310.netlify.app/test2.html  upto test7.html
Code https://github.com/BabylonJSGuide/Goldberg

Awesome!
The package-lock is still here, would you be able to revert this commit?
Also the linting warnings and errors are still there - https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=15370&view=logs&jobId=32e2e1bb-a28f-5b18-6cfc-3f01273f5609&j=32e2e1bb-a28f-5b18-6cfc-3f01273f5609&t=2bf39655-ae43-5ae7-fe00-6e76c9bf09b6

@RaananW The package-lock is still here, would you be able to revert this commit?
No idea how to do this. If I do find out how do I leave all subsequent commits. Help much appreciated here.

@RaananW Also the linting warnings and errors are still there
Sorry about this they did not come up with gulp typedoc-check. It seems I have forgot a step because I now remember getting a listing like this for a previous PR a couple of years back.

Could you also remove most of the any and replace with proper types ?
This looks better and better :-)

Will have another look. Did try when I was doing it but stuck with  any when VSCode objected to my attempt at a type when using the variable. Any suggestions gratefully received.

Sorry about this they did not come up with gulp typedoc-check. It seems I have forgot a step because I now remember getting a listing like this for a previous PR a couple of years back.

You can check the linting by doing: gulp core-tsLint

@sebavan, @RaananW, @Popov72 thank you for your guidance. I have (hopefully) changed everything that needed changing and everything is now fit for use. My Goldberg repo now contains the latest version of babylon.max.js as compiled by this PR.
Please review and let me know id further work is needed.

@sebavan re - I am still seeing a submodule being added into the repo, the babylon serializers js being modified and the ToGoldberg function on the mesh class.
No idea how the submodule or serialized change happened. I can delete the submodule and edit the serialized file back to what it should be. Is this the way to go?
Do not understand the problem with ToGoldberg. It is needed since if you export a Goldberg mesh and re-import it  it imports as a mesh without the added properties and methods needed to manipulate a Goldberg mesh should a user wish to use the extended version of the mesh.

about the first 2 comments yes removing the submodule and editing back the serializers should work.
About ToGoldberg let s check what @RaananW thinks ?

Looks good to me!
A few comments:

There is no need to add the CreateFunctions to mesh. we are slowly moving out of this, and extending the mesh class is not needed.

I am more than happy to remove CreateGeodesic and CreateGoldberg from Mesh.ts
What I struggled with is a Goldberg mesh has added properties and methods in addition to the usual mesh ones. When exporting a Goldberg mesh the property values are stored in the mesh's metadata. When this is then imported it's imported as a mesh which of course does not have the additional properties and methods. Using JavaScript I could easily write a function that just adds the properties and methods on the fly. As far as I found out this is not possible with Typescript. Using a mixin I wrote a function ToGoldberg that takes a mesh and adds back the missing properties and methods. This function does  this by dynamically creating the Goldberg mesh from the mesh parameter and then disposing of the passed mesh. If I could find a way of just adding the extra properties and methods

You commited a built version of babylon.seralizers.js. is there a reason for that?

As @sebavan pointed out, though I do not know how, but I had a commit that changed a serialized and the only way I could think of that I was submitting a correct version was to copy and paste the one on Babylon/babylon.js

The code is from line 300 of https://github.com/BabylonJSGuide/Babylon.js/tree/master/src/Meshes.

Sorry - what file in this directory? couldn't find it in mesh.
I assume the code is already in the framework itself? otherwise it should also be included in this PR. Or I might be misunderstanding (which is more than likely :-))

There is no need to add the CreateFunctions to mesh. we are slowly moving out of this, and extending the mesh class is not needed.

Removed
Also renamed ToGoldberg as ExtendToGoldberg

I can not help help wondering if we should keep extending prototypes or classes in new code. Everything is accessible on the individual classes so I wonder if extending VertexData, MeshBuilder or Mesh is bringing a lot of value ?
We had to do it for back compat in the past but as this is brand new, I am wondering ?

I can not help help wondering if we should keep extending prototypes or classes in new code. Everything is accessible on the individual classes so I wonder if extending VertexData, MeshBuilder or Mesh is bringing a lot of value ?
We had to do it for back compat in the past but as this is brand new, I am wondering ?

In adding the Geodesic and the Goldberg I followed the pattern for creating the other meshes. If you are suggesting there is a different pattern because these are new classes I am totally lost as to where to go.

@BabylonJSGuide the comment was not about your current code :-) but more in general for me an @RaananW .
I merged it as is so you can document it and @RaananW will review the pattern later so that we could enhance it for 5.0. And then you ll have some new examples to follow :-)
Thanks a lot for your contribs.

@sebavan, @RaananW, @Popov72 thank you all for your reviews and suggestions. I am working on the documentation.


bug: Ionic React hardwareBackButton still not working

Hey,
I appreciate your work on this, really. But the Android hardwareBackButton is essential for Android App Development. We can still not navigate back / catch the hardwareBackButton event on Ionic React.
There are several issues from over a year ago, yet no fix (#16611). The issue was even unpinned a few days ago - why? Is there a workaround we missed?
We will not consider adding commercial support if these basic features are still not implemented into Ionic React.
I would really appreciate information on the progress of this issue :)
Thanks!

I opened a forum post regarding this. It can be achieved but not reliably.
To catch the hardwareBackButton  event, you have to use capacitor in ionic react. See here.

Thanks for the feedback! There are some known issues with hardware back button support, and we are collecting them in https://github.com/ionic-team/ionic/issues/16611. This issue was unpinned to make room for other issues we needed to pin temporarily, but the back button issue was never re-pinned. I have re-pinned the issue.
Improved hardware back button support is something we are actively looking into. For further updates, feel free to follow the thread I linked to. Thanks!


Pass the request context instead of a fresh root context

Change code generation to pass the request context into the handler instead of a fresh root context. This allows us to use middleware which modifies the context.

Related to https://github.com/owncloud/ocis-settings/issues/12


New release ?

@jarro2783 we use your project to manage the options in a Jupyter cell with https://github.com/QuantStack/xeus-cling.
We would like to package your application in order to install cxxopts with conda and to manage the dependencies of our xeus-cling project. But to be able to do that, we need a new release with the fix https://github.com/jarro2783/cxxopts/issues/61.
@SylvainCorlay will do the packaging for conda.
Could you do a new release ?

Yeah sure, can't do it right now, but I'll get to that today.

I was trying to fix the OSX build on travis, but I couldn't, so I've disabled it for now and made a tag.

@jarro2783 it does not seem that you have pushed your tag.

Ah, it certainly doesn't. I did git push --all, I thought that included tags. I will push that shortly.

FYI cxxopts is on conda-forge!


Add changes to block calls in cat shards, indices and segments based on dynamic limit settings

Add changes to block calls in cat shards, indices and segments based on dynamic limit settings

Description

Introduced a new class RequestLimitSettings to maintain dynamic settings for 3 actions - cat indices, shards and segments and method to evaluate if circuitLimitBreached for an action.

cat.indices.response.limit.number_of_indices (The limit will be applied on number of indices)
cat.shards.response.limit.number_of_shards (The limit will be applied on number of shards)
cat.segments.response.limit.number_of_indices (The limit will be applied on number of indices)

Introduced isRequestLimitCheckSupported method defaulting to false in AbstractCatAction so that we can override this if an action extending AbstractCatAction can define if it supports limit or circuit breaker checks introduced in RequestLimitSettings class. This value can be passed to respected transport action as param e.g. TransportCatShardsAction

If circuit limit breached, CircuitBreakingException will be raised which is mapped to 429 error code.

Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/15954
(Outdated) ### Functional Testing
Action 1 :  /_cat/shards/
Step 1 - Run OS cluster locally
Step 2 - PUT 2 index
Step 3 - Perform /_cat/shards/
curl -XGET "http://localhost:9200/_cat/shards/"
index3 0 p STARTED    1 4.7kb <IP_ADDRESS> runTask-0
index3 0 r UNASSIGNED
index2 0 p STARTED    1 4.7kb <IP_ADDRESS> runTask-0
index2 0 r UNASSIGNED
Step 4 - Update setting cat.shards.limit to 2
curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.shards.limit" : 2
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"shards":{"limit":"2"}}}}%
Step 5 - Perform /_cat/shards/
curl -XGET "http://localhost:9200/_cat/shards/"
curl -XGET "http://localhost:9200/_cat/shards/"
{"error":{"root_cause":[{"type":"circuit_breaking_exception","reason":"Too many shards requested. Can not request shards beyond {2}","bytes_wanted":0,"bytes_limit":0,"durability":"TRANSIENT"}],"type":"circuit_breaking_exception","reason":"Too many shards requested. Can not request shards beyond {2}","bytes_wanted":0,"bytes_limit":0,"durability":"TRANSIENT"},"status":429}%
Step 6 - Update setting cat.shards.limit to 5
curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.shards.limit" : 5
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"shards":{"limit":"5"}}}}%
Step 7 - Perform /_cat/shards/
curl -XGET "http://localhost:9200/_cat/shards/"
index3 0 p STARTED    1 4.7kb <IP_ADDRESS> runTask-0
index3 0 r UNASSIGNED
index2 0 p STARTED    1 4.7kb <IP_ADDRESS> runTask-0
index2 0 r UNASSIGNED
Action 2 :   /_cat/indices/
Step 1 - Using cluster started in previous section
Step 2 - Perform /_cat/indices/
curl -XGET "http://localhost:9200/_cat/indices/"
yellow open index3 jNmxVJy-RMqBit-p271yDQ 1 1 1 0 4.7kb 4.7kb
yellow open index2 u_tHJQiQSd6S-BvNhIAQeA 1 1 1 0 4.7kb 4.7kb
Step 3 - Update settings
curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.indices.limit" : 1
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"indices":{"limit":"1"}}}}%
Step 4 - Perform /_cat/indices/
curl -XGET "http://localhost:9200/_cat/indices/"
{"error":{"root_cause":[{"type":"circuit_breaking_exception","reason":"Too many indices requested. Can not request indices beyond {1}","bytes_wanted":0,"bytes_limit":0,"durability":"TRANSIENT"}],"type":"circuit_breaking_exception","reason":"Too many indices requested. Can not request indices beyond {1}","bytes_wanted":0,"bytes_limit":0,"durability":"TRANSIENT"},"status":429}%
Step 5 - Update settings
curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.indices.limit" : -1
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"indices":{"limit":"-1"}}}}%
Step 6 - Perform /_cat/indices/
curl -XGET "http://localhost:9200/_cat/indices/"
yellow open index3 jNmxVJy-RMqBit-p271yDQ 1 1 1 0 4.7kb 4.7kb
yellow open index2 u_tHJQiQSd6S-BvNhIAQeA 1 1 1 0 4.7kb 4.7kb
Action 3 :  /_cat/segments/
Step 1 - Using cluster started in previous section
Step 2 - Perform /_cat/segments/
curl -XGET "http://localhost:9200/_cat/segments/"
index3 0 p <IP_ADDRESS> _0 0 1 0 4.5kb 0 true true 9.12.0 true
index2 0 p <IP_ADDRESS> _0 0 1 0 4.5kb 0 true true 9.12.0 true
Step3 - Update settings
curl -X PUT "localhost:9200/_cluster/settings" -H 'Content-Type: application/json' -d'
{
"transient" : {
"cat.segments.limit" : 1
}
}'
{"acknowledged":true,"persistent":{},"transient":{"cat":{"segments":{"limit":"1"}}}}%
Step 4 - Perform /_cat/segments/
curl -XGET "http://localhost:9200/_cat/segments/"
{"error":{"root_cause":[{"type":"circuit_breaking_exception","reason":"Segments from too many indices requested. Can not request indices beyond {1}","bytes_wanted":0,"bytes_limit":0,"durability":"TRANSIENT"}],"type":"circuit_breaking_exception","reason":"Segments from too many indices requested. Can not request indices beyond {1}","bytes_wanted":0,"bytes_limit":0,"durability":"TRANSIENT"},"status":429}%
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for 27440d2: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Reason - failed for task ':server:spotlessJavaCheck'.
Pushed fix post running ./gradlew :server:spotlessApply

@gargharsh3134 @rajiv-kv Resolved comments. You can refer this for diff https://github.com/opensearch-project/OpenSearch/pull/15986/commits/ab80b7fb1f81f40c08c9e06610c066a36616f392 commit resolving comments.

❌ Gradle check result for 69289c0: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Fixed org.opensearch.ExceptionSerializationTests.testExceptionRegistration

Looks good to me.
Can you also add manual testing details on the Response format for ResponseLimit breached ?

I have already in PR description, all the steps. Sample:
curl -XGET "http://localhost:9200/_cat/indices/"
{"error":{"root_cause":[{"type":"response_limit_breached_exception","reason":"Too many indices requested. Can not request indices beyond {1}"}],"type":"response_limit_breached_exception","reason":"Too many indices requested. Can not request indices beyond {1}"},"status":429}%

❌ Gradle check result for 09492e1: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Existing flaky tests are failing.

@sumitasr we will need documentation PR for new settings

Helping with merge as it is already approved by @backslasht & @rajiv-kv

@sumitasr we will need documentation PR for new settings

Tracking documentation updates here https://github.com/opensearch-project/documentation-website/issues/8460


Feature/organize imports function

:tada: This PR is included in version 2.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: