Filtering operations by tags

OpenAPI specification allow adding tags to operations.
tags:
- pet
summary: Updates a pet in the store with form data
operationId: updatePetWithForm
parameters:
- name: petId
  in: path
  description: ID of pet that needs to be updated
  required: true
  schema:
    type: string
...

It would be great to filter on these tags to get a subset of cases.
Something like:
@schema.parametrize(tags=['pet'])
def test_no_server_errors(case):
    # do something with the case
    pass

Hello @hlobit !
It is a great feature proposal :) Thank you for bringing it

Adding info for the future reference.
To implement this we need to:

extend all relevant functions in loaders.py with the new tags argument of Optional[Filter] type and pass it further down;
add a new tags attribute to schemas.BaseSchema similar to method & endpoint
add tags to lazy.LazySchema.parametrize and lazy.get_schema in a similar way
add -t (tags) option to CLI in cli.__init__ and pass it down to runner via loader_options
in schemas.SwaggerV20.get_all_endpoints add a check for tags on the line 105.

Not sure if it will be better to use case insensitive check from should_skip_method or add a separate one or reuse should_skip_endpoint. The latter has re.search type of check, which could be convenient. However, most probably it will be better to rename these functions sho they are not bound to method or endpoint but to the way they implement comparison

Let me take this :-)

Sure thing :)

Hej @mnalband ! Let me know if you need any support from our side :)

Done via #165


Initiate review request

Template: https://github.com/pyOpenSci/software-review/blob/main/.github/ISSUE_TEMPLATE/submit-software-for-review.md

Finished.


Agent send error to layer on error

Agent now sends error encountered back to layer for better UX when bad times happen.
Part of #912

bors r+


Make an exporter

What this issue says, basically.
https://github.com/thegreenwebfoundation/grid-intensity-go/issues/4

@mrchrisadams I've added a Helm chart and integration test for Kubernetes support in https://github.com/thegreenwebfoundation/grid-intensity-exporter/pull/4
After this I'd like to add a Nomad task and integration test but I need to figure out how to test that so I did K8s first.
@ofpiyush I haven't added you as a reviewer as there isn't actually any Go code. But if you would like to review it just let me know. 🙏

@rossf7  I'm thinking through how you might replicate the approahc you took with k8s, and apply it to nomad.
As I understand it with the k8s case the CI workflow is something along the lines of:

sets up a kind cluster
adds the container into this cluster
sets up a helm chart to set up the deployment
exposes a port for the metrics
from the outside, hits the port to see the metrics

right?
I think the equivalent, minimal setup for nomad would be

set up the nomad in client and server mode (it can run in as both for development and testing)
submit a job to the nomad server, which would the figure out which client to run it on (in our case they would be the same machine)
figure out the port it exposes
hit that port for the same info

Is that what you had in mind?

@mrchrisadams Thanks, yes that's what I was thinking and running the nomad agent in dev mode sounds ideal.
For the job the metrics need to be available on port 8000. As the integration test connects to http://localhost:8000/metrics. But that looks doable so I think this will work great.

Sup @rossf7  - there's some more notes here that might help:
https://discuss.hashicorp.com/t/local-development-workflow-with-nomad-consul-and-docker/3641/5
Ah… that points to a vagrantfile in the nomand repo too, showing how they set it up. That nomad set up  is pretty extensive, and we might not need it all. In our case,  if we follow the example of the integration tests you put together for kubernetes, this would, I suspect the key thing we'd need would be somewhere to fetch the generated grid-intensity image from to run
https://github.com/hashicorp/nomad/blob/master/Vagrantfile

hey @rossf7 I think with #5 and #4  merged in, I think the main outstanding bit before we can merge in might be some docs for this, and maybe some sketch of how it works.
For a sketch, I could put together something with Plant UML, to demonstrate the configuration for it for the three configurations running on some cluster (i.e. docker, nomad, k8s).
Anything else?

Hi @mrchrisadams,
thanks, a sketch would help a lot. 👍  For the docs I'm happy to help as a reviewer or author.
Then I agree I think we can close this.

Hi @rossf7 !
As I mentioned in thegreenwebfoundation/grid-intensity-go/issues/4, I think there's a way to consume these metrics so that the Nomad scheduler can take them into account when making scheduling decisions.
As you mentioned before the Nomad autoscaler can consume this exporter data. You can see it referred to in the check stanza of a policy like this - by the APM. In the example below, this check is run regularly to decide whether to change the size of the pool of nodes in available to allocate jobs to:
# check for this dynamic value and use it as a criterion when making an auto scaling decision
check {
  source = "prometheus"
  query  = "avg((haproxy_server_current_sessions{backend=\"http_back\"}))"
}

However, I'm not sure if the APM plugin would be the ideal place for us experimenting, as that would be used for continuously updating jobs to auto scale to a set target.
You might use this at a nomad server level, to run a query every N minutes to see if a value is in a threshold, and then decide to trigger an auto scaling event.
So a policy applied to a job might look like this. :
job "important-but-not-urgent-job" {
  # we want to run it to completion then stop
  # we might be okay with it being prempted and delayed
  type        = "batch"

  # we need a full list of datacentres as candidates for placement, and these
  # could be in different regions with different grid intensities
  datacenters = ["dc1", "dc2", "dc3", "dc4"]

  group "machine_learning" {

    task {
      driver = "docker"

      config {
        image = "greenweb/computationally-expensive"
      }
    }

    scaling {
      min     = 0
      max     = 10
      enabled = true

      # low carbon compute policy - actively look for client nodes with a carbon intensity close
      # to this level
      policy {
        # check every 30 mins
        evaluation_interval = "30m"

        # after a reshuffle, don't reschuffle again for at least an hour
        cooldown            = "1h"

        check "target_carbon_intensity" {
          source = "prometheus"
          query  = "scalar(local_carbon_intensity)"

          # when carbon intensity of compute goes above 85 on the index (I think)
          # trigger an autoscale event and reschedule.
          strategy "threshold" {
            upper_bound = 90
            lower_bound = 00
            delta = 5
          }
        }
      }
    }
  }
}

However, I think the APM stuff is designed to see when to trigger a re-evaluation, but it still wouldn't know about how to choose the right nodes to bin pack onto, because any carbon intensity metrics would need to be visible to the scheduler, and I don't think this would result in switching nodes off.
For that, I think we'd need a way to influence the ranking phase of the scheduling, and be able to actively filter them out o the ranked list. This monster function seems to be the part that that ranks nodes, when choosing which nodes to run jobs on:
https://github.com/hashicorp/nomad/blob/main/scheduler/rank.go#L193-L527
You'd probably need a way for that function to query a node's stats during the ranking phase, to query for local carbon intensity for the node, and use that as a criterion.
This here looks like a sample test you might use to see if ranking candidate nodes returns them in the order you'd expect.
I think we might be able to make a test demonstrating querying for a node property there, and ask the folks in the nomad community form to see how you might satisfy that test for carbon awareness.
https://github.com/hashicorp/nomad/blob/main/scheduler/rank_test.go#L136-L251
## Other related links
This post by Bill Johnson largely explains how they tried something related with k8s. I hadn't realised before that they use the same Watttime API that I had been checking out this week.
https://devblogs.microsoft.com/sustainable-software/carbon-aware-kubernetes/
See also this new paper - they reckon you can get 20% carbon savings through thoughtful scheduling of work that doesn't need to be done right away.
https://arxiv.org/abs/2110.13234

Hey @mrchrisadams
I think we would need to use both APM and Target plugins for this.

However, I think the APM stuff is designed to see when to trigger a re-evaluation, but it still wouldn't know about how to choose the right nodes to bin pack onto,

The APM plugin is used to store the metrics. Using Prometheus for that makes sense to me. We already have the carbon intensity exporter and adding new metrics or running more exporters is easy to do.
When carbon intensity is high we will want to scale down or to zero. The target plugin can be used for horizontal cluster autoscaling which is the term used for nomad adding or removing nodes. For cloud this is straightforward e.g. on AWS you can use the auto-scaling-group target plugin.
For onprem the nomad target plugin might be useful. As it would allow scaling the number of containers. If there is an API for the physical nodes then a target plugin could be written and used to decide which nodes to shutdown.
Its also cloud but for example this is a target plugin for Digital Ocean. The downside is a target plugin is needed per infra provider but that seems to be the architecture they are going for.
This is pretty much identical in kubernetes. The cluster-autoscaler is used for scaling nodes and there are plugins for multiple providers. I just saw that this includes Hetzner https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider
We can see but I don't think they would want this logic in the nomad scheduler. It's up to the cluster operator to decide how many nodes the cluster should have. The scheduler then does the bin packing of containers to nodes.

Ah, so if I understand correctly: the key difference is that the scheduler would never make any decisions about how big, or small the pool of compute might be - it would just take care of distributing the load onto the available nodes with the lowest carbon intensity, right?
That would leave any scaling or scaling plugin to be responsible for changing the size of some combo of the pool of nodes (be these cloud VMs, physical machines) , the resources allocated to each job (i.e. the size of the tasks inside a job, as controlled by the task drive - be they containers, regular isolated for exec, firecracker microVMs and so on).
If that's the case, I can see how this might have a measurable impact even if you were just looking at the scheduler in isolation:

I think dynamic of various processors (i.e. how much the power changes between states of low and high usage ) is wide enough for this to be measurable now. The way this is measured in cloud carbon footprint, you could even have numbers change fast for it to appear in a dashboard, as their carbon calculations (and I think project carbon figures forward).
if the bin packing is smart enough to free up a node entirely, and it's consistently shown to be surplus to requirements, then it's easier to make the argument that it ought to be removed from the pool

I think this would also leave room for the operator to make a decisions or have strategies that either:

let some work queue up in anticipation of a period of low carbon compute in the near future (see the paper above) or
accept the higher emissions and increase the resources allocated to the pool, based on other criteria.

In both cases, I think this would support using something like a internal carbon price, or internal carbon budget over a set period - you'd track cumulative CO2 emissions for a given service against it, and you could have useful discussions about the strategies you might employ like the two above to get the work done, whilst staying inside the budget (cumulative CO2 as part of an SLO, for example).
Thinking through how you'd split this work.
Based on what you just shared, I now think there's two possible parts of this idea.

having the scheduler able to use carbon intensity on the host/node as a criterion when deciding where or (when) to run jobs
extending an autoscaler to have an awareness of the carbon intensity of different regions, so when a check is run, the pool of resources is expanded in the region with the lowest carbon intensity, assuming other criteria about latency, hardware requirements, cost, data protection are equal

My guess would be that of these two, the first is the more interesting one to do technologically, and would require less domain knowledge around carbon emissions - we figure out how to add another scalar value to be used in the scheduler, and then we rely on manual decisions to add or remove resources from a pool used for bin packing.
The second one is would involve adding or removing from a pool of resources, and if there is freedom to choose between different regions with a single provider doing so. I figure we'd do this looking at the carbon intensity of each region and picking the lowest one, assuming it still fits the other criteria for the job.
As a starting point, you could use data like this for google cloud project:
https://github.com/GoogleCloudPlatform/region-carbon-info/blob/main/data/yearly/2020.csv
Or this for Amazon:
https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/blob/trunk/packages/aws/src/domain/AwsFootprintEstimationConstants.ts#L144-L171
Which one would you be more interested in?

Hey @rossf7 I'm gonna close this as things have moved on a bit now :)
Let's look at the first thing:

having the scheduler able to use carbon intensity on the host/node as a criterion when deciding where or (when) to run jobs

Nomad now has a carbon aware scheduler in an experimental branch:
https://github.com/hashicorp/nomad/blob/h-carbon-meta/CARBON.md
It currently consumes data from a couple of providers, and but I can't remember if it's using any of the libraries we've worked on.

extending an autoscaler to have an awareness of the carbon intensity of different regions

I think the idea of extending an autoscaler to grow and shrink the pool largely relies on having access to data that changes frequently enough to make autoscaling decisions worthwhile.
While there is access on an individual basis to specific countries, I'm not aware of a handy feed where you would use this, so to make these calls, you'd likely need to use the electricity map provider (I think we have API keys for experimenting here) or us to implement a Wattime provider (we have keys for this too, for experimenting)

Actually @rossf7 - would you mind closing this issue once you've had a chance to re-read this thread, and if you see the need to create any new issues in the respective libraries, you have created them?
We covered quite a lot in this issue, and I didn't want to close it until we've both had a chance to revisit some of the ideas here in 2022...

Hi @mrchrisadams, back to this. I've done another pass through the issue.

I think the idea of extending an autoscaler to grow and shrink the pool largely relies on having access to data that changes frequently enough to make autoscaling decisions worthwhile.

Yes, I agree without frequent fresh data an autoscaler can't make effective decisions. https://github.com/thegreenwebfoundation/grid-intensity-go/issues/25 you created for the Watttime marginal intensity API looks the best option for this right now.
For autoscaling a first step would be having Prometheus metrics including the more frequent data. We could then look at things like KEDA scalers or cluster-autoscaler support if needed but without frequent data they are not that useful.
For the carbon branch for Nomad it isn't using grid-intensity-go directly but the data sources are the same. It's using ElectricityMap, gridintensity.org.uk plus climateiq.io
https://github.com/hashicorp/nomad/blob/h-carbon-meta/CARBON.md
Once the Watttime API is integrated we could add it there too. Or even create a fork of that branch to experiment with. But again https://github.com/thegreenwebfoundation/grid-intensity-go/issues/25  is needed for that.
So I'm going to close this but I'll post in the Watttime issue about possible next steps so we don't lose this.


0.9.5-dev-009: Intermediate version output

While testing the dev version I noticed that many in-between versions are now outputted compared to earlier versions of the plugin, i.e.
version.org.mockito..mockito-android=3.1.0
##                       # available=3.2.0
##                       # available=3.2.4
##                       # available=3.3.0
##                       # available=3.3.1
##                       # available=3.3.3
##                       # available=3.4.0
##                       # available=3.4.2
##                       # available=3.4.3
##                       # available=3.4.4
##                       # available=3.4.6
##                       # available=3.5.0
##                       # available=3.5.2

is printed, while I'd have expected only a single
version.org.mockito..mockito-android=3.1.0
##                       # available=3.5.2

Is this on purpose? This is not restricted to stable versions:
version.org.slf4j..log4j-over-slf4j=1.7.25
##                      # available=1.7.26
##                      # available=1.7.27
##                      # available=1.7.28
##                      # available=1.7.29
##                      # available=1.7.30
##                      # available=1.8.0-alpha0
##                      # available=1.8.0-alpha1
##                      # available=1.8.0-alpha2
##                      # available=1.8.0-beta0
##                      # available=1.8.0-beta1
##                      # available=1.8.0-beta2
##                      # available=1.8.0-beta4
##                      # available=2.0.0-alpha0
##                      # available=2.0.0-alpha1

Yes, it's on purpose. It allows you to upgrade to newer but non latest versions with ease, handy when an API evolved incrementally, providing migration facilities that might have been removed in latest versions.
It also enables you to visualize at a glance how much "behind" your project is.

I'd still love to have some filtering there. People might not be interested in every alpha / beta version upstream provides, this spams the file quite a bit. For kotlintest for example roughly 40 subsequent snapshot versions are printed, all of which I'm not interested.

I've been thinking about wrapping intermediate version with a region so the IDE can fold them.
What are your thoughts regarding that idea?

Well, won't make much of a difference. Imagine you're on the latest stable version, but the plugin still happily shows you dozens of snapshot and alpha versions, that then also pop up in code reviews (where you can't fold them away).
So personally no hard feelings, if you want to keep the complete output, keep it verbatim as-is.
Am 19. August 2020 16:58:23 MESZ schrieb Louis CAD<EMAIL_ADDRESS>
I've been thinking about wrapping intermediate version with a region so
the IDE can fold them.
What are your thoughts regarding that idea?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/jmfayard/refreshVersions/issues/220#issuecomment-676478723

--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.


Allow to customize docker image name

During build process there might be situation when one needs to
assign custom docker names to calico/build and calico/test images,
e.g. to push to some custom repos, etc:
make calico/build BUILD_CONTAINER_NAME=mycustomrepo/calico/build:customTag

This change implements such functionality.

Also variable SOURCE_DIR added, which points to the root of the
project and allows to get rid of pwd
Clean target should also remove calico/build:latest-wheezy image
A little bit clean-up on trailing spaces

hi, @tomdee could you please check this patch. Thank you

LGTM


Ruby: exclude all GAPIC files from rubocop until style issues are fixed

What
GAPIC files have rubocop violations (tracked in #1120 and #1536). Until these are fixed, GAPIC files should be excluded from the rubocop check so as not to cause CI failures.

Closed by #1660


actually parse with zod schema so we can get the .strip() behavior

Looks like the zodResolver just validates the form but doesn't pass the result of a zod parse on the data to onSubmit. Would be nice to actually parse before submitting to strip out extra fields that may have come along with say a GQL query that aren't updateble: ala https://github.com/colinhacks/zod#strip

Hmm I think zodResolver does pass the results of parse? I just tried it in code sandbox, seems to remove extra fields (https://codesandbox.io/s/react-ts-form-example-6gkuyx?file=/src/App.tsx)
Slightly related to this - There is an issue with the lib internally at the moment where it's actually running the validation twice, once via the zodResolver and then again after removing undefined values (see the submit function in createSchemaForm).
I added this as part of a workaround to allow setting values to "undefined" but it does make it seemingly impossible to support schemas who's parsed type is not the same as it's input type (because validation will fail). So this is making it so .transform() etc don't work.
I'm curious how often do you use react-hook-forms APIs directly with this library @scamden?
I'm starting to think it might be better long term to maybe remove the dependency on react-hook-form because it seems to be causing issues over time. For example idk how to even begin to fix this since it's happening because of this library and react-hook-form not playing nicely: https://github.com/iway1/react-ts-form/issues/92
Any thoughts on maybe starting to move off of react-hook-form? could also reduce the bundle size quite a bit

Oh that's odd. I specifically had to add a parse in my submit handler to remove extra fields.. I wonder what I'm missing.
I actually do use the react hook form stuff a fair bit. We use the useWatch and the submitting state.  I'll double check what else but those things should be pretty easy to replace I would think. It does seem like hook form is pretty nice apart from the undefined thing tho. Idk wdyt?

Oh sorry lol, just reread and saw the bug you referenced. Maybe there are some other downsides. I did notice that things in general don't always rerender in field value changes without use a useWatch but not sure if that related

@scamden yeah I totally agree having all the RHF apis are really nice but also IDK if we can fix some of those bugs without doing more hacky stuff as long as we're using it.

I did notice that things in general don't always rerender in field value changes without use a useWatch but not sure if that related

You mean components aren't rerendering on value change sometimes without a useWatch?

You mean components aren't rerendering on value change sometimes without a useWatch?

that's right, the CustomChildComponent specifically. like if i just read values instead of useWatch it doesn't work


Failed to load resource: the server responded with a status of 404 ()

Hi,
I can run the experiment but the data is not saved and this error in console: Failed to load resource: the server responded with a status of 404 ()
How can this issue be solved? Is there anybody to help?

Hi @python2020-maker,
We'll need more information to be able to help. Where are you running your experiment? How is the data being saved? What file is the 404 error referencing?


Access the terminal environment

Is there any way to suspend app to run shell command or at least run code on the server side?
Like
@on(w.Button.Pressed, '#ping-key')
def on_button_pressed(self, event: w.Button.Pressed) -> None:
    with self.app.suspend():
        code = system(...)

Not with a UI. But you can use subprocesses to run commands.
https://docs.python.org/3/library/asyncio-subprocess.html

I partially did this, but still it works only in one way direction with endless output cmds like ping. SSH or any user input relying cmds causes to break textual, which causes a glitches of overlapping console request input.
So, hope somebody found this usefull.
import textual.widgets as w
from textual.screen import ModalScreen
from textual.reactive import reactive
import asyncio

class ConsoleEmulator(ModalScreen):

    view_stdout = reactive(b'')
    BINDINGS = [("ctrl+e", "close", "Exit")]

    def __init__(self, cmd='ping localhost'):
        super().__init__()
        self.initial_cmd = cmd

    async def stdout_handle(self, source):
        while 1:
            self.view_stdout = await source.read(1)

    async def on_mount(self):
        self.log_view: w.Log = self.query_one(w.Log)
        self.proc = await asyncio.create_subprocess_shell(
            self.initial_cmd,
            stdout=asyncio.subprocess.PIPE,
        )
        self.stdout_handle_task = asyncio.create_task(
            self.stdout_handle(self.proc.stdout))

    def watch_view_stdout(self):
        self.log_view.write(self.view_stdout.decode('utf-8'))

    def compose(self):
        yield w.Log(auto_scroll=True)
        yield w.Footer()

    def action_close(self):
        try:
            self.stdout_handle_task.cancel()
        except asyncio.CancelledError():
            ...
        self.proc.kill()
        self.app.pop_screen()


chore: (kernel) submission cascade delete

Remove cascade delete on mappingset ==> submissions

Another point, what happens with the entity extraction if the submission has no mappingset? :scream:

@obdulia-losantos a mappingset is required on submission create only

Have you tried to update a submission without mapping set?


Mac build 6.8 not working

SRC/mongodb.cpp:23:10: fatal error: 'bson.h' file not found
#include "bson.h"
         ^
1 error generated.

bson.h is located in SRC/mongo/bson/

faced a similar issue when making mongo server on linux. The problem was "bson" and "mongoc" files have to come from the linux file system itself and not from the SRC folders. bson comes along with mongoc, so probably you need to install bson and mongoc on your proper mac folders.
That worked for us on linux.


return number of input and output tokens with the model

We would like to request a new feature to track and report token usage when using OpenAI models with ScrapeGraphAI. This would allow users to monitor costs associated with API calls.
Proposed Functionality:
Track prompt tokens used (completion.usage.prompt_tokens)
Track completion tokens used (completion.usage.completion_tokens)
Provide a method to access these token counts after each scraping operation
Suggested Implementation:
Add a token_usage attribute to the scraper object that stores a dictionary with keys for 'prompt_tokens' and 'completion_tokens'
Update this attribute after each API call to OpenAI
Implement a get_token_usage() method that returns the current token usage
Example Implementation
scraper = SmartScraperGraph(prompt="Extract product information", source="https://example.com", config=graph_config)
result = scraper.run()
token_usage = scraper.get_token_usage()
print(f"Prompt tokens: {token_usage['prompt_tokens']}")
print(f"Completion tokens: {token_usage['completion_tokens']}")

Look at this example https://github.com/ScrapeGraphAI/Scrapegraph-ai/blob/main/examples/openai/smart_scraper_openai.py at line 45


WslRegisterDistribution failed with error: 0x8007007b

Windows Build Number
Microsoft Windows [Versione 10.0.19042.928]
WSL Version

[X] WSL 2
[X] WSL 1

Kernel Version
Stock downloaded from https://wslstorestorage.blob.core.windows.net/wslblob/wsl_update_x64.msi
Distro Version
Ubuntu-20.04
Other Software
No response
Repro Steps
I have followed the steps shown in the following guide
https://docs.microsoft.com/en-us/windows/wsl/install-win10
Expected Behavior
That I could install wsl2 correctly
Actual Behavior
After the installation of WSL goes through without problems I have problems in converting to WSL2 through the command ' wsl --set-version   ', which remodeled for my needs becomes ' wsl --set- version Ubuntu-20.04 2 '.
But I get the following error: https://prnt.sc/11spu4w
Executing the following command I don't get any errors: https://prnt.sc/11spvio
At this point I have uninstalled Ubuntu and reinstalled, I get the following error: https://prnt.sc/11sr6j1
Diagnostic Logs
No response

Can you please include logs?

Can you please include logs?

I don't have any logs, I just reported what I see, if you tell me how to capture them I could try ..

Can you please include logs?

https://mega.nz/file/FYwSUCbK#uJfVM1lbanZnAQnxaRLwKaO0fJGk7zkpKb6yIZJJmRM

I'm also seeing this error on 2 different machines that I upgraded to build 21364.  My existing FedoraRemix WSL2 instance fails to launch with "The parameter is incorrect", and a new Ubuntu instance installed from the store fails with the error in the title.
Feedback here: https://aka.ms/AAc106k

@Threefish4096 thanks for reporting this and providing logs. At least from what I am seeing in the traces, Hyper-V is not able to open the kernel. Could you confirm that it's present under C:\Windows\system32\lxss\tools? Was the kernel installed prior to attempting these commands?
@cshei, thanks for collecting logs. I couldn't see any data in that link, unfortunately; your machine may need to be configured to allow diagnostics to go through (Windows Error Reporting in particular needs to be turned on). Also, can you confirm the error code you are seeing? If it is indeed ERROR_INVALID_PARAMETER (0x80070057) as you mentioned, then I suspect this is a potentially-different issue on 21364 which is being investigated in #6839 .

Even though you have the correct MSI, the kernel itself is not being updated. That kernel file is definitely outdated.  To get back into a good state, you can remove the kernel file (or move it to another location), remove the kernel MSI packages, and then download the current MSI from https://wslstorestorage.blob.core.windows.net/wslblob/wsl_update_x64.msi.  That is currently kernel version 5.4.72.
You can also turn on MSI logging by creating the following reg key (with that on, all MSI operations create a log file in the %TEMP% directory):
Path:HKEY_LOCAL_MACHINE\Software\Policies\Microsoft\Windows\Installer
Type: Reg_SZ
Value: Logging
Data: voicewarmupx

Even though you have the correct MSI, the kernel itself is not being updated. That kernel file is definitely outdated. To get back into a good state, you can remove the kernel file (or move it to another location), remove the kernel MSI packages, and then download the current MSI from https://wslstorestorage.blob.core.windows.net/wslblob/wsl_update_x64.msi. That is currently kernel version 5.4.72.
You can also turn on MSI logging by creating the following reg key (with that on, all MSI operations create a log file in the %TEMP% directory):
Path:HKEY_LOCAL_MACHINE\Software\Policies\Microsoft\Windows\Installer
Type: Reg_SZ
Value: Logging
Data: voicewarmupx

In the meantime, thank you very much!
I deleted the contents of the folder, uninstalled the MSI, downloaded the one you proposed and 2 new files appeared in the tools folder.
I started Ubuntu and the following error appeared:

There is already something more online than the original error, I will try to solve it later, if I can publish how I solved it.
If you know how to fix it or it has already been talked about, suggestions are welcome.

Even though you have the correct MSI, the kernel itself is not being updated. That kernel file is definitely outdated. To get back into a good state, you can remove the kernel file (or move it to another location), remove the kernel MSI packages, and then download the current MSI from https://wslstorestorage.blob.core.windows.net/wslblob/wsl_update_x64.msi. That is currently kernel version 5.4.72.
You can also turn on MSI logging by creating the following reg key (with that on, all MSI operations create a log file in the %TEMP% directory):
Path:HKEY_LOCAL_MACHINE\Software\Policies\Microsoft\Windows\Installer
Type: Reg_SZ
Value: Logging
Data: voicewarmupx

In the meantime, thank you very much!
I deleted the contents of the folder, uninstalled the MSI, downloaded the one you proposed and 2 new files appeared in the tools folder.
I started Ubuntu and the following error appeared:

There is already something more online than the original error, I will try to solve it later, if I can publish how I solved it.
If you know how to fix it or it has already been talked about, suggestions are welcome.

I follow this mini guide and obtain another error..

Again...
So i return to C:\Windows\system32\lxss\tools , inside the latter I found old files when instead I had previously emptied it leaving only the kernel and license files.
I again removed everything and left the previous 2 files, but nothing, I keep getting: WslRegisterDistribution failed with error: 0x80004005

Could you please record logs again and attach them to this thread?
/logs

Could you please record logs again and attach them to this thread?
/logs

Sorry I'm late but I was busy with an exam.
So, since I could not use the 'recreate my problem' feature I had to proceed manually using 'Windows Performance Recorder', I added the wsl.wprp profile, I started Ubuntu-20.04, the problem occurred and I stopped the tool.
Here the link to the file .etl

Hi, any update on this. Having the same problem.


Create Main Lit-Graph Component

Create the container element that will be the entry point to the lit-graph component. It will have the main SVG element that everything will render in. Its job will be to orchestrate and render the subcomponents. It will  also analyze the data to be graphed and generate the X and Y coordinate increments. Subcomponents will include:

Graphing Grid
X and Y axis with increments
X and Y axis labels
Data plots

Component signature should look like:
<lit-graph     data="[{ x: 1, y: 1 }, { x: 2, y: 2 }, { x: 3, y: 3 }]"    y-label="Y label"    x-label="X label"  />

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Rearrange metadata into layout and include Twitter card

Motivation
Disclaimer: I say metadata a lot in this pull request.
The metadata for blog posts were not implemented correctly so it was defaulting to the overall site metadata. This meant that when you share a blog post, the description in the preview would be the description of Frontside and not the description of the blog post. And while fixing this I thought I might as well refactor all the other pages with the new metadata layout too.
Approach
The blog posts' metadata was being passed into the blog post template as a prop but wasn't actually being utilized so I brought it up one level (while still in the blog template) which fixed the issue. But while refactoring the other templates, I thought it would be tidier by allowing the layout component to accept title and description props (as opposed to importing Helmet to each template that needs it) so that templates can simply choose to either use its own title/description or have it default to the site's title/description.
The format in which this works is if you pass in a title prop, the metadata for that page will be generated as ${prop.title} | Frontside, and if no title is passed in it'll just be Frontside.
The Frontside logo has also been added to the site's metadata. So on iMessage it looks like this:

I've given it the same treatment for Twitter's meta tags (in layout) where it just borrows the same argument from the site's metadata:

TODO?

[x] Update the following templates:

[x] About
[x] Contact
[x] Services
[x] Podcast

[x] [Episodes]

[x] Blog

[x] [Posts]

[x] People

[x] [Persons]

[x] Tag

[x] [Tags]

[ ] Update Frontside logo file?

@jorgelainfiesta Is there a cleaner version of the Frontside logo? See image above with the white specks around the logo on Twitter.

Can we make it possible to pass an optional image to the metadata? For instance, in the blog post I'd use the image that is already included in the md file for the article.

@minkimcello can you please add blog page number to the title. Page 1 should just be Blog | Frontside and Blog - page 2 | Frontside for all other pages

@taras @jorgelainfiesta
This is what it would look like if we used blog post image for the preview card:

Is that what we would prefer? Or for marketing purposes would the Frontside logo be better?
And also, is there something about remark (internally) that automatically detects the difference between author and authors? Because some posts use authors and some use author. When I try to make any changes to the way the markdown fields are queried, it all of a sudden gives me errors for the author.

Yeah I think that's what we would prefer, because we will be increasing the amount of content that we produce
For example, let's say somebody shares a link to Article A on #random or twitter. Then somebody else, days later, publishes Article B. People don't put a lot of attention, and scroll through things dumped there. If they see Frontside's logo twice, it seem like duplicated content and perhaps not even an article but a corporate page about Frontside rather than content that they'd be interested in.

@jorgelainfiesta Done and done.
The image of the new logo still has the white specks in the preview cards:

Do you know why that might be?

Excellent Min!
(Interesting that Twitter doesn't support ~Facebook Graph~, I mean 'Open' Graph, but I like their stance somehow.)


modernize Elastic Search  controller

in the GH crawler.

This seems like a tracking issue for work in the kustomize repo.  Closing here.


dokku container randomly crashes

I have noticed a few times that the dokku container just wasn't running anymore.
docker ps lists all running containers. Redis always seems to be running, but our app is suddenly gone and we need to run dokku rebuild crafatar to restart the app.
The last time this happened I checked both output and error logs, but nothing special there. It just stopped.
This is very confusing to me because even if the (currently 1) worker thread crashed, it would be respawned. If that fails too and the whole app crashes, forever should restart it as well, like this:
error: Forever detected script exited with code: 1
error: Script restart attempt #1

We're often running close to the Memory limit, but there's another GB of swap -- I don't think that would cause a crash like this.

If you're using file-based logging, or anything other than stderr for logging, exceptions will not necessarily be caught in the log as your app may halt before the error is finished being written.
You'd want to listen for an uncaughtException in your app. Log the exception, and ensure it actually is logged before shutting down the process.

This doesn't seem to be happening anymore, I'll reopen if it does.


loads the tokenizer for each checkpoint, to solve the reproducability…

Hi
I observed that if you run "run_glue" code with the same parameters in the following ways:

run with both --do_train and --do_eval
run without --do_train but only --do_eval, but set the modelpath to use the trained models from step 1

The obtained evaluation results in these two cases are not the same, and to make the results reproducible it is needed to reload tokenizer from checkpoints.
Thanks.

Codecov Report

Merging #1026 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1026      +/-   ##
=========================================
- Coverage   79.22%   78.9%   -0.32%
=========================================
  Files          38      34       -4
  Lines        6406    6192     -214
=========================================
- Hits         5075    4886     -189
+ Misses       1331    1306      -25

Impacted Files
Coverage Δ

pytorch_transformers/file_utils.py
71.01% <0%> (-3.09%)
:arrow_down:

pytorch_transformers/tokenization_bert.py
93.2% <0%> (-1.95%)
:arrow_down:

...transformers/tests/tokenization_transfo_xl_test.py
96.42% <0%> (-0.55%)
:arrow_down:

...rch_transformers/tests/tokenization_openai_test.py
96.77% <0%> (-0.45%)
:arrow_down:

...ytorch_transformers/tests/tokenization_xlm_test.py
96.77% <0%> (-0.45%)
:arrow_down:

...orch_transformers/tests/tokenization_xlnet_test.py
97.05% <0%> (-0.45%)
:arrow_down:

...torch_transformers/tests/tokenization_gpt2_test.py
96.87% <0%> (-0.43%)
:arrow_down:

pytorch_transformers/tests/optimization_test.py
98.57% <0%> (-0.41%)
:arrow_down:

pytorch_transformers/optimization.py
96.29% <0%> (-0.34%)
:arrow_down:

...torch_transformers/tests/tokenization_bert_test.py
98.38% <0%> (-0.13%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7b4cfe...3d47a7f. Read the comment docs.

Ok, looks good to me, thanks @rabeehk

Hi Thomas
There is really some reproducibility issue in the codes, and this solves it
only
for the case when I think one does not evaluate on all the checkpoints,
please
undo this commit just to be sure not to break the codes, I will send you a
new
pull request soon when it is test for both cases.
thank you.
Best regards,
Rabeeh
On Fri, Aug 30, 2019 at 2:16 PM Thomas Wolf<EMAIL_ADDRESS>wrote:

Merged #1026
https://github.com/huggingface/pytorch-transformers/pull/1026 into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/huggingface/pytorch-transformers/pull/1026?email_source=notifications&email_token=ABP4ZCFNY7Y4FNDVAV6CWK3QHEFQBA5CNFSM4ILSUUMKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTLFNQXI#event-2596984925,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABP4ZCBELPM2QN44SHXIZMTQHEFQBANCNFSM4ILSUUMA
.


Error message when running from docker-container.

compose file:
  southwest-alerts:
    image: xur17/southwest-alerts
    container_name: southwest-alerts
    environment:
      - MAILGUN_DOMAIN=XXX.mailgun.org
      - MAILGUN_API_KEY=XXX
      - USERNAME1=XXXXXXX
      - PASSWORD1=XXXXX
      -<EMAIL_ADDRESS>
compose log:
dietpi@DietPi:/$ dcp logs southwest-alerts
Attaching to southwest-alerts
southwest-alerts    | standard_init_linux.go:190: exec user process caused "exec format error"
dietpi@DietPi:/$

Was running on aarch64 device.  Realize now this was my issue.


Phi3 support

Feature request
Microsoft's new phi3 mode, in particular the 128K context mini model, is not supported by Optimum export.
Error is:
"ValueError: Trying to export a phi3 model, that is a custom or unsupported architecture, but no custom export configuration was passed as custom_export_configs. Please refer to https://huggingface.co/docs/optimum/main/en/exporters/onnx/usage_guides/export_a_model#custom-export-of-transformers-models for an example on how to export custom models. Please open an issue at https://github.com/huggingface/optimum/issues if you would like the model type phi3 to be supported natively in the ONNX export."
Motivation
Phi3-mini is potentially very significant as it has a large context but a small size. This could be used in lots of scenarios if it has good performance.
Your contribution
Unlikely I could do a PR as ONNX work is not my forte.

https://github.com/huggingface/optimum/blob/56aabbebd0ce532f82f566a2a946769cee3bb36b/optimum/utils/normalized_config.py#L254
Add phi3 in this list and you seem to be all set for phi3-mini

Although I had following patch applied, it still cann't export Phi-3 ONNX model.
commit db6db6fc6a0690bce501569ab384f1bf10a2c7da
Author: kunal-vaishnavi<EMAIL_ADDRESS>Date:   Thu May 9 02:12:55 2024 -0700
Add Phi-3 mini to Optimum (#1841)

* Load config from folder

* Add Phi-3 to normalized config

My command is as follows:
ptimum-cli export onnx -m ./phi3_128k_lora_sft --monolith --task text-generation  --trust-remote-code --framework pt ./phi3_128k_lora_sft_onnx_3
The output and error are as following:
Loading checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 4/4 [00:07<00:00,  1.85s/it]
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
Traceback (most recent call last):
File "/usr/local/bin/optimum-cli", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.9/dist-packages/optimum/commands/optimum_cli.py", line 163, in main
service.run()
File "/usr/local/lib/python3.9/dist-packages/optimum/commands/export/onnx.py", line 265, in run
main_export(
File "/usr/local/lib/python3.9/dist-packages/optimum/exporters/onnx/main.py", line 352, in main_export
onnx_export_from_model(
File "/usr/local/lib/python3.9/dist-packages/optimum/exporters/onnx/convert.py", line 1048, in onnx_export_from_model
raise ValueError(
ValueError: Trying to export a phi3 model, that is a custom or unsupported architecture, but no custom onnx configuration was passed as custom_onnx_configs. Please refer to https://huggingface.co/docs/optimum/main/en/exporters/onnx/usage_guides/export_a_model#custom-export-of-transformers-models for an example on how to export custom models. Please open an issue at https://github.com/huggingface/optimum/issues if you would like the model type phi3 to be supported natively in the ONNX export.

With the PR #1841 submitted by the ORT team, we will be able to load onnx checkpoints(eg. microsoft/Phi-3-mini-4k-instruct-onnx) of phi3 uploaded by the ORT team. But for exporting the model we would need to add an onnx config for phi3. I will open a PR today.
For phi3 small, the team will wait until it becomes a part of a stable transformers release (it is using remote code now).


fix(table): use combineLatest as mapper for FakeDataSource

@josephperrott I have https://github.com/angular/material2/pull/8811 that seems to fix the same issue.


Put the images in a directory that's private to the app.

I don't think we generally want to be creating a public SlyceMessaging directory on people's phones.

@jchunchar @MatthewPageCS what do you think?

So, Hangouts throws them in a folder called "Hangouts". And FaceBook Messenger just saves it to a folder called "Pictures". Either way, the directory is visible to the user, which is where I got the idea from.

Right, but this isn't hangouts, it's just a library that could be in any old app. I don't want to assume that people are going to want these pictures to be visible outside the app, and even if they do they won't want the folder to be called "SlyceMessaging" :)

Right, fair enough.


Remove legacy tray icon for GNOME

My Setup

My OS name and version: Ubuntu 17.04
My current app version: 2.7.0 (installed via Snappy)

[x] I have tested with the latest application version
[x] I can simulate the issue easily

Description

Start Rocket Chat desktop in GNOME

Current Behavior

Icon appears in legacy icon tray

Expected Behavior

No icon in the legacy tray.
Still receive notifications through GNOME notifications. (This works.)
Closing the app with the X button should instead minimise it.

This is more in line with expected app behaviour on the GNOME desktop.

"Add option to hide tray icon" #343 did this, but only for mac.  I would like the ability to hide the tray icon for Linux as well.
Other chat programs only show a tray icon when there is an active notification.

Removed "Closing the app with the X button should instead minimise it." from the original description, because this is not expected behavior for a GNOME app. X always closes. The user can minimise in the usual way.

Other GNU/Linux shells still use legacy tray icons for notifications. You could make appearance of this icon optional/configurable.

i'd like to inform you that legacy tray will be removed with gnome 3.26, i'm running gnome beta now, and electron apps starting in "tray" mode as pushbullet-for-desktop for an example now have no possibility to be displayed to the user. popular topicons-extension (moves icon inside the legacy tray to the panel area in the upper-right corner) also doesn't help here or works at the moment, as it is depending on the legacy tray functionality


[Persistence] TreeStore Refactor

Description
Refactors the stateTrees component behind the TreeStore interface.
Issue
Part of a refactor effort towards implementing #562
Part of a series of refactors in the persistence package, with #736 being the first.
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Pulls the stateTrees component down into its own component behind a dedicated interface for managing the SMT store.

Testing

[x] make develop_test; if any code changes were made
[ ] Docker Compose LocalNet; if any major functionality was changed or introduced
[x] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@dylanlott Do you plan on adding any unit tests to this?

Yes, was planning on future PRs with more test coverage. This PR was meant to bring the refactor online and achieve test parity.

My only concern/question is along the lines of a comment made by @Olshansk. I think I may have a slight misunderstanding on the role of the TxIndexer and why it is being used as the store for the transaction tree?

It's the source of truth for transaction data. The tree only reflects what is persisted into the TxIndexer. If we didn't get them from the TxIndexer then we'd have to keep them in memory and pass them through from the Unit of Work module, IIRC. Instead, they're persisted to the TxIndexer.

Other than that the work looks great so far! I see the TODO test placeholders and if this is to be done in another PR then everything seems to be making great progress with the refactors!

@h5law also yes the test placeholders will be addressed in the near future, I'm working on those while I'm spiking out the savepoints implementation


Device details blank for some devices in modern interface

Describe the bug
Some (in this case MT90) devices are returning white page when accessing details of device in modern interface. Other devices (in my case Teltonika and Traccar Client) are working just fine and displaying the details of the device.
To Reproduce
Login to modern interface
Select MT90 device
Click Info
Expected behavior
Device details shown as in other devices.
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser Edge + Chrome
Version  103.0.1264.37

Smartphone (please complete the following information):

Device: Samsung S21 Ultra
OS: Android
Browser Chrome
Version

Additional context
In database I can fetch location with ID 482430 (select * from tc_positions where id = 482430;)
Console from Chrome:
Failed to load resource: the server responded with a status of 404 (Not Found)
serviceWorker.js:85 Content is cached for offline use.
maplibre-gl.js:31 Image "-11" could not be loaded. Please make sure you have added the image with map.addImage() or a "sprite" property in your style. You can provide missing images by listening for the "styleimagemissing" map event.
O @ maplibre-gl.js:31
maplibre-gl.js:31 Image "convenience-11" could not be loaded. Please make sure you have added the image with map.addImage() or a "sprite" property in your style. You can provide missing images by listening for the "styleimagemissing" map event.
O @ maplibre-gl.js:31
react-dom.production.min.js:216 Error: Minified React error #31; visit https://reactjs.org/docs/error-decoder.html?invariant=31&args[]=object%20with%20keys%20%7BradioType%2C%20considerIp%2C%20cellTowers%7D for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at _o (react-dom.production.min.js:140:47)
    at react-dom.production.min.js:150:265
    at Ia (react-dom.production.min.js:176:171)
    at Us (react-dom.production.min.js:268:385)
    at Ol (react-dom.production.min.js:250:347)
    at xl (react-dom.production.min.js:250:278)
    at _l (react-dom.production.min.js:250:138)
    at pl (react-dom.production.min.js:243:163)
    at react-dom.production.min.js:123:115
    at t.unstable_runWithPriority (scheduler.production.min.js:18:343)
os @ react-dom.production.min.js:216
482512:1          Failed to load resource: the server responded with a status of 404 (Not Found)

Console in Edge:
react-dom.production.min.js:216

       Error: Minified React error #31; visit https://reactjs.org/docs/error-decoder.html?invariant=31&args[]=object%20with%20keys%20%7BradioType%2C%20considerIp%2C%20cellTowers%7D for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at _o (react-dom.production.min.js:140:47)
    at react-dom.production.min.js:150:265
    at Ia (react-dom.production.min.js:176:171)
    at Us (react-dom.production.min.js:268:385)
    at Ol (react-dom.production.min.js:250:347)
    at xl (react-dom.production.min.js:250:278)
    at _l (react-dom.production.min.js:250:138)
    at pl (react-dom.production.min.js:243:163)
    at react-dom.production.min.js:123:115
    at t.unstable_runWithPriority (scheduler.production.min.js:18:343)
os @ react-dom.production.min.js:216
482430:1

       Failed to load resource: the server responded with a status of 404 (Not Found)

What version are you using? Have you tried master?

Using 5.0. Haven't tried from master compiling myself.

This should already be fixed on master.


Launcher crash

Windows Event Viewer:
Incorrect application name: launcher.exe_unknown, version: <IP_ADDRESS>, timestamp: 0x5ed17a47
Bad module name: launcher.exe, version: <IP_ADDRESS>, timestamp: 0x5ed17a47
Exception code: 0xc0000005
Error distance 0x0000000000050b53
Incorrect transaction ID: 0x1898
Application start time: 0x01d635fe68cb681f
Incorrect application path: D:\CSO2\Bin\launcher.exe
Bad module path: D:\CSO2\Bin\launcher.exe
Report ID: 8256ef1b-00dc-44c4-a47a-5355a1124ec7
Bad package full name:
Application ID related to the faulty package:

I built new, I did everything right, successful, but there is a problem

any 0.3.0 or newer launcher can not running at Win7, if you encounter such problems on Win7, please use 0.2.2 instead.

i already use windows 10 i get the same error

I am not using windows 7 and it gives error when I build a new launcher

@yusuflq @ExplosionMagicMegumin can you try this build?

It works well.
where is the source code?

where is the source code?

It's literally built from this commit:
https://ci.appveyor.com/project/L-Leite/cso2-launcher/branch/master/job/2r1imum82sahh8md

I downloaded the latest version again
when you rebuild it, the launcher crashes again.
Errorbundle1877964671019050001,type4
EventName:APPCRASH
Answer:Notavailable
CabinID:0
Problemsignature:
P1:launcher.exe_unknown
P2:<IP_ADDRESS>
P3:5ee7586c
P4:launcher.exe
P5:<IP_ADDRESS>
P6:5ee7586c
P7:c0000005
P8:0000000000050d73
P9:
P10:
Attachedfiles:
C:\ProgramData\Microsoft\Windows\WR\Temp\wer509c.tmp.dmp
C:\ProgramData\Microsoft\Windows\WR\Temp\wer510b.tmp.werınternalmetadata.xml
C:\ProgramData\Microsoft\Windows\WR\Temp\wer513b.tmp.xml
C:\ProgramData\Microsoft\Windows\WR\Temp\wer514c.tmp.csv
C:\ProgramData\Microsoft\Windows\WR\Temp\wer517c.tmp.txt
Thesefilescanbefoundhere:
C:\ProgramData\Microsoft\Windows\WR\reportarchivto\appcrash_launcher.exe_unk_cd6c11b572ccf5e2db9b5e8ddc06c8c8d1c46_e3ec412f_6208a751-5e87-4736-88cf-252f354bf20b
Analysisicon:
Recheckforsolution:0
ReportID:6c027af3-fb97-4189-93aa-5b34d5b8128b
ReportStatus:268435456
Hashbunch:aad80643e4934910ba0fdeeb1cd2e411
CabinGuid:0
@L-Leite  @YuRaNnNzZZ  @dounai2333

which compiler are you using?


Make library more generic

I think some changes would make this library suitable for more use cases. The changes are:

Exporting array instead of object in configuration JSON to accept one than more selectors.
Renaming blockSelector to selector.
Renaming collection property to union.
Accepting schema property alongside the selector to allow parse single type instead of union types.

closed in favor of #8


Remove dataloader countfile dependency

Original version of the dataloader uses a metadata file of documents per fileshard, to determine fractional file ownership without loading any of the actual files. This was important when we were pulling files from a mounted COS bucket, and opening the file would trigger a multi-GB file download. However, having to generate a new count file for every dataset we support is... annoying, especially as we move to upstream this and also support wider varieties of input formats.
This PR changes the countfile logic to instead search for the countfile, and if it does not exist, each worker will count up manually, by touching only the shard files that it owns. For datasets on disk this actually greatly accelerates setup (.046s setup to .0033s for 3.7Tb fineweb on vela, lol), as we no longer have to iterate through each line of the countfile, and length metadata is easily available for pyarrow/parquet/etc. formats. In future, we may be able to remove countfile logic entirely.
Preserves backward compatibility. Builds on #99

I think we should, fully tested this PR for regression accuracy (remove count file + use this PR vs. having count file w/o this PR), and completely remove the count file dependency.  i.e. instead of "use count file when exist", we just always assume no count file.
I don't think any of our data pipeline generate count file automatically (we always had to ask for it), and other data sources does not have this file either.

@daviswer  so if we are to compare:
a. this PR + remove count file
b. using count file
should both yields exactly same order of data retrieval ?

Yes data loading behavior should be identical in both cases. I left in the countfile option in case we ever need to support COS streaming again but I could see it either way


add php 7.3 to travis

Duplicate of #7428

The referenced issue has now landed in 2.7 and master too, thanks.


Sync Mod Order not working

Whenever I try to sync mod order I get this error message in MO (using latest version 2.2.0):
'charmap' codec can't encode character '\ufeff' in position 14: character maps to
Any idea what that means?
edit: after "to" it should say "undefined" but with smaller than/greater signs than instead of "". apparently it got removed by the formatting here

Can you send me your modlist.txt?

https://pastebin.com/ZrdwEpkq

I was getting the same error.
Fixed my local install by editing line 145 in: data/deorder/syncModOrder.py
and changing:
with open(modListPath, 'w') as modListFile:
To:
with open(modListPath, 'w', encoding='utf-8') as modListFile:
Works again!

I was getting the same error.
Fixed my local install by editing line 145 in: data/deorder/syncModOrder.py
and changing:
with open(modListPath, 'w') as modListFile:
To:
with open(modListPath, 'w', encoding='utf-8') as modListFile:
Works again!

Thanks, this saves me some time


New package: Dionysos v0.0.2

Registering package: Dionysos
Repository: https://github.com/dionysos-dev/Dionysos.jl
Created by: @adrienbanse
Version: v0.0.2
Commit: 21167e5f3b8fa0696868c36c5340db05f8d20283
Git reference: v0.0.2

close

Closing in favor of https://github.com/JuliaRegistries/General/pull/102067


Remove unnecessary pauses after pressing keys with GuiRobot #459

Part of #459.
Proposed merge commit message:
guiRobot#type(...) and guiRobot#push(...) internally pauses after
pressing the given keys.

We do not need to call guiRobot#pauseForHuman() for such cases.

Let's remove such redundant pauses.

v1
@yamgent submitted v1 for review.

[v1 1/3] MainMenuHandle: Inline openHelpWindowUsingAccelerator()
[v1 2/3] CommandBoxHandle#enterCommand(): Remove pause after pressing Enter
[v1 3/3] CommandBoxTest: Remove pause after pressing A

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/572/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

The rest LGTM. Verified that all redundant pauses are removed.

v2
@yamgent submitted v2 for review.

[v2 1/3] MainMenuHandle: Remove pause after pressing F1
[v2 2/3] CommandBoxHandle: Remove pause after pressing Enter
[v2 3/3] CommandBoxTest: Remove pause after pressing A

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/572/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.


#fix: 107491

This PR fixes #107491
Behavior

Select multiple colors and changing color in ColorPicker changes every selected colors with respecting its color representation.
Select multiple colors and changing color which is not selected will changes hovered color but will not changes selected colors.
Non-color selections will be ignored.

Hi @orange4glace thank you for your PR. In order for this PR to be considered for a merge into VS Code, could you resolve the merge conflict and address the review comments for polishing the code? Thank you.

Hi @orange4glace, due to the inactivity on this PR, it will be closed. Thank you for your understanding.


[Loggable] - Since Sf 4.4 - Username is always null in log entries

Hi,
Since migrating to Symfony 4.4.+, username is always null in log entries.
I fixed it with adding this line to DoctrineExtensionSubscriber::onKernelRequest():
$this->loggableListener->setUsername($this->tokenStorage->getToken()->getUser()->getUsername());
I hope it will help someone.
Maybe the doc/symfony4.md should be updated too?

Extensions didn't change anything that 4.4 would've broken. Perhaps your kernel listener wasn't registered or something to that effect.
This is documented in the Extension Listener Services part of the Symfony 4 docs.


Create Index fails because of 42P01: relation "core.new_search_objects" does not exist

The Aggregator Create Index task fails due to:

30/08/2024 : 21:15 :   **** SETUP ****

30/08/2024 : 21:15 :   transfer data =  False
30/08/2024 : 21:15 :   create core =  False
30/08/2024 : 21:15 :   create json =  False
30/08/2024 : 21:15 :   do statistics =  False
30/08/2024 : 21:15 :   do iec =  False
30/08/2024 : 21:15 :   do indices =  True
30/08/2024 : 21:15 :   FTW tables recreated

30/08/2024 : 21:15 :   **** SETTING UP STUDY SEARCH TABLES ****

30/08/2024 : 21:15 :   **** CREATING JSON STUDY DATA ****

30/08/2024 : 21:15 :   **** UNHANDLED EXCEPTION ****

+++++++++++++++++++++++++++++++++++++++
30/08/2024 : 21:15 :   ***ERROR*** MDR_Aggregator application aborted

42P01: relation "core.new_search_objects" does not exist

POSITION: 76

   at Npgsql.Internal.NpgsqlConnector.<ReadMessage>g__ReadMessageLong|222_0(NpgsqlConnector connector, Boolean async, DataRowLoadingMode dataRowLoadingMode, Boolean readingNotifications, Boolean isReadingPrependedMessage)
   at Npgsql.NpgsqlDataReader.NextResult(Boolean async, Boolean isConsuming, CancellationToken cancellationToken)
   at Npgsql.NpgsqlDataReader.NextResult(Boolean async, Boolean isConsuming, CancellationToken cancellationToken)
   at Npgsql.NpgsqlDataReader.NextResult()
   at Npgsql.NpgsqlCommand.ExecuteReader(CommandBehavior behavior, Boolean async, CancellationToken cancellationToken)
   at Npgsql.NpgsqlCommand.ExecuteReader(CommandBehavior behavior, Boolean async, CancellationToken cancellationToken)
   at Npgsql.NpgsqlCommand.ExecuteReader(CommandBehavior behavior)
   at Npgsql.NpgsqlCommand.ExecuteDbDataReader(CommandBehavior behavior)
   at Dapper.SqlMapper.ExecuteReaderWithFlagsFallback(IDbCommand cmd, Boolean wasClosed, CommandBehavior behavior) in /_/Dapper/SqlMapper.cs:line 1066
   at Dapper.SqlMapper.QueryImpl[T](IDbConnection cnn, CommandDefinition command, Type effectiveType)+MoveNext() in /_/Dapper/SqlMapper.cs:line 1094
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Dapper.SqlMapper.Query[T](IDbConnection cnn, String sql, Object param, IDbTransaction transaction, Boolean buffered, Nullable`1 commandTimeout, Nullable`1 commandType) in /_/Dapper/SqlMapper.cs:line 734
   at MDR_Aggregator.JSONStudyDataLayer.FetchObjectDetails(Int32 study_id) in C:\Users\ecrinadmin\RiderProjects\MDR_Aggregator\SearchStudyHelpers\JSONStudyDataLayer.cs:line 273
   at MDR_Aggregator.JSONStudyProcessor.CreateStudySearchResult(JSONFullStudy st) in C:\Users\ecrinadmin\RiderProjects\MDR_Aggregator\SearchStudyHelpers\JSONStudyProcessor.cs:line 427
   at MDR_Aggregator.SearchHelperJson.LoopThroughStudyRecords(Int32 offset) in C:\Users\ecrinadmin\RiderProjects\MDR_Aggregator\SearchHelpers\SearchHelperJSON.cs:line 95
   at MDR_Aggregator.CoreSearchBuilder.CreateJSONStudyData(Boolean create_table, Int32 offset) in C:\Users\ecrinadmin\RiderProjects\MDR_Aggregator\SearchHelpers\CoreSearchBuilder.cs:line 35
   at MDR_Aggregator.Aggregator.AggregateData(Options opts) in C:\Users\ecrinadmin\RiderProjects\MDR_Aggregator\TopLevelClasses\Aggregator.cs:line 244
   at Program.<Main>$(String[] args) in C:\Users\ecrinadmin\RiderProjects\MDR_Aggregator\TopLevelClasses\Program.cs:line 62
+++++++++++++++++++++++++++++++++++++++

30/08/2024 : 21:15 :   **** CLOSING LOG ****

Currently successfully re-run:

Aggregate IEC data    (source\repos\MDR_Aggregator\bin\Debug\net7.0\MDR_Aggregator.exe -l)

Still to be re-run:
2. Aggregate Study and Object data   (source\repos\MDR_Aggregator\bin\Debug\net7.0\MDR_Aggregator.exe -D)
3. Create Aggregation Statistics      (source\repos\MDR_Aggregator\bin\Debug\net7.0\MDR_Aggregator.exe -S)
4. Create Core MDR DB        (source\repos\MDR_Aggregator\bin\Debug\net7.0\MDR_Aggregator.exe -C)
5. Create Indexes (this step)  (source\repos\MDR_Aggregator\bin\Debug\net7.0\MDR_Aggregator.exe -X
Logs
a. Aggregate IEC data    (source\repos\MDR_Aggregator\bin\Debug\net7.0\MDR_Aggregator.exe -l)
AG -I 2024-08-30 211744.log

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

[conversation locked due to spam/phishing reasons]

After re-run
two errors are there
30/08/2024 : 21:20 :   ----------------------------------------------------------------------
30/08/2024 : 21:20 :   AGGREGATING CTG DATA
30/08/2024 : 21:20 :   ----------------------------------------------------------------------

+++++++++++++++++++++++++++++++++++++++
30/08/2024 : 21:21 :   ***ERROR*** In ExecuteSQL; Exception while reading from stream,
SQL was:  Insert into ad.study_iec_null (source_id, sd_sid, seq_num, iec_type_id, split_type, leader, indent_level,
        sequence_string, iec_text )
                             select 100120, t.sd_sid, seq_num, iec_type_id, split_type, leader, indent_level,
        sequence_string, iec_text
                             from ctg_ad.study_iec_null t
                             inner join ctg_ad.studies s
                             on t.sd_sid = s.sd_sid
+++++++++++++++++++++++++++++++++++++++

30/08/2024 : 21:23 :   **** ADDING STUDY DATA ****

30/08/2024 : 21:23 :   Transferred 92518 study record data, from aggs DB to IEC DB, ids 1 to 100000
30/08/2024 : 21:23 :   Transferred 100000 study record data, from aggs DB to IEC DB, ids 100001 to 200000
30/08/2024 : 21:23 :   Transferred 19190 study record data, from aggs DB to IEC DB, ids 200001 to 300000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 300001 to 400000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 400001 to 500000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 500001 to 600000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 600001 to 700000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 700001 to 800000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 800001 to 900000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 900001 to 1000000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1000001 to 1100000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1100001 to 1200000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1200001 to 1300000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1300001 to 1400000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1400001 to 1500000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1500001 to 1600000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1600001 to 1700000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1700001 to 1800000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1800001 to 1900000
30/08/2024 : 21:23 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1900001 to 2000000
30/08/2024 : 21:23 :   Transferred 99991 study record data, from aggs DB to IEC DB, ids 2000001 to 2100000
30/08/2024 : 21:23 :   Transferred 99984 study record data, from aggs DB to IEC DB, ids 2100001 to 2200000
30/08/2024 : 21:23 :   Transferred 99949 study record data, from aggs DB to IEC DB, ids 2200001 to 2300000
30/08/2024 : 21:23 :   Transferred 99926 study record data, from aggs DB to IEC DB, ids 2300001 to 2400000
30/08/2024 : 21:23 :   Transferred 92497 study record data, from aggs DB to IEC DB, ids 2400001 to 2500000
30/08/2024 : 21:23 :   Transferred 99839 study record data, from aggs DB to IEC DB, ids 2500001 to 2600000
30/08/2024 : 21:23 :   Transferred 99997 study record data, from aggs DB to IEC DB, ids 2600001 to 2700000
30/08/2024 : 21:23 :   Transferred 62151 study record data, from aggs DB to IEC DB, ids 2700001 to 2762213
30/08/2024 : 21:23 :   Transferred 966042 study record data, from aggs DB to IEC DB, in total

+++++++++++++++++++++++++++++++++++++++
30/08/2024 : 21:24 :   ***ERROR*** In ExecuteSQL; Exception while reading from stream,
SQL was: update ad.studies k
               set display_title = s.display_title,
               brief_description = s.brief_description,
               iec_level_id = s.iec_level,
               study_start_year = s.study_start_year, study_start_month = s.study_start_month,
               study_type_id = s.study_type_id, study_enrolment = s.study_enrolment,
               study_gender_elig_id = s.study_gender_elig_id,
               min_age = s.min_age, min_age_units_id = s.min_age_units_id,
               max_age = s.max_age, max_age_units_id = s.max_age_units_id,
               datetime_of_data_fetch = k.datetime_of_data_fetch
            from aggs_st.studies s
            where k.study_id = s.id  and k.id >= 1 and k.id < 25001
+++++++++++++++++++++++++++++++++++++++

But the process terminated with Exit code 0.
AG -I 2024-08-30 211744.log
Re-running now.

Second run only the update.ad.studies k appeared again.
31/08/2024 : 12:11 :   **** ADDING STUDY DATA ****

31/08/2024 : 12:11 :   Transferred 92518 study record data, from aggs DB to IEC DB, ids 1 to 100000
31/08/2024 : 12:12 :   Transferred 100000 study record data, from aggs DB to IEC DB, ids 100001 to 200000
31/08/2024 : 12:12 :   Transferred 22667 study record data, from aggs DB to IEC DB, ids 200001 to 300000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 300001 to 400000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 400001 to 500000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 500001 to 600000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 600001 to 700000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 700001 to 800000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 800001 to 900000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 900001 to 1000000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1000001 to 1100000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1100001 to 1200000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1200001 to 1300000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1300001 to 1400000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1400001 to 1500000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1500001 to 1600000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1600001 to 1700000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1700001 to 1800000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1800001 to 1900000
31/08/2024 : 12:12 :   Transferred 0 study record data, from aggs DB to IEC DB, ids 1900001 to 2000000
31/08/2024 : 12:12 :   Transferred 99991 study record data, from aggs DB to IEC DB, ids 2000001 to 2100000
31/08/2024 : 12:12 :   Transferred 99984 study record data, from aggs DB to IEC DB, ids 2100001 to 2200000
31/08/2024 : 12:12 :   Transferred 99949 study record data, from aggs DB to IEC DB, ids 2200001 to 2300000
31/08/2024 : 12:12 :   Transferred 99926 study record data, from aggs DB to IEC DB, ids 2300001 to 2400000
31/08/2024 : 12:12 :   Transferred 92497 study record data, from aggs DB to IEC DB, ids 2400001 to 2500000
31/08/2024 : 12:12 :   Transferred 99839 study record data, from aggs DB to IEC DB, ids 2500001 to 2600000
31/08/2024 : 12:12 :   Transferred 99997 study record data, from aggs DB to IEC DB, ids 2600001 to 2700000
31/08/2024 : 12:12 :   Transferred 62151 study record data, from aggs DB to IEC DB, ids 2700001 to 2762213
31/08/2024 : 12:12 :   Transferred 969519 study record data, from aggs DB to IEC DB, in total

+++++++++++++++++++++++++++++++++++++++
31/08/2024 : 12:12 :   ***ERROR*** In ExecuteSQL; Exception while reading from stream,
SQL was: update ad.studies k
               set display_title = s.display_title,
               brief_description = s.brief_description,
               iec_level_id = s.iec_level,
               study_start_year = s.study_start_year, study_start_month = s.study_start_month,
               study_type_id = s.study_type_id, study_enrolment = s.study_enrolment,
               study_gender_elig_id = s.study_gender_elig_id,
               min_age = s.min_age, min_age_units_id = s.min_age_units_id,
               max_age = s.max_age, max_age_units_id = s.max_age_units_id,
               datetime_of_data_fetch = k.datetime_of_data_fetch
            from aggs_st.studies s
            where k.study_id = s.id  and k.id >= 1 and k.id < 25001
+++++++++++++++++++++++++++++++++++++++

AG -I 2024-08-31 120650.log


_curses.error: addwstr() returned ERR

Hello developer! ASCII artist Chzz Chatman again. I ran TERM=xterm-256color python3 ./main.py per the guidance and I was grateful to finally be greeted by the asciishade editor main screen. However, I then reduced the window height by moving its tile to a different position in my Tiling Window Manager and the asciishade application instantly terminated with the following backtrace:
Traceback (most recent call last): TERM=xterm-256color python3 ./main.py
  File "./main.py", line 160, in <module>
    wrapper(main)
  File "/usr/lib/python3.8/curses/__init__.py", line 105, in wrapper
    return func(stdscr, *args, **kwds)
  File "./main.py", line 153, in main
    draw_hud(s)
  File "./main.py", line 54, in draw_hud
    s.addstr(max_y-1, 0, f'x: {x:3} | ', color_pair(hud_color))
_curses.error: addwstr() returned ERR

Any ideas how to move forward? I am using xterm on gentoo Linux with Python 3.8.12 and i3 Window Manager, if that matters.

same issue on debian, crashes on resize

At present, the recommended way to run asciishade is to first decide your terminal size, and then run python3 main.py. Resizing of the terminal / canvas will be handled in a future release, sometime after saving/loading. Thanks for bringing this up. Closing this issue for now.


[Network] application-gateway rule: Support --priority option

Description

Close https://github.com/Azure/azure-cli/issues/15050
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

Network


k8s: update k8s libraries and tests to 1.17.17

Signed-off-by: André Martins<EMAIL_ADDRESS>

test-backport-1.7

The upstream tests were already failing https://github.com/cilium/cilium/pull/14868#issuecomment-777743793


Ref-count the call op sets

Otherwise the sneakyOpSet may come back on the completion queue after the response reader is destroyed.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

The entire struct (ClientAsyncResponseReader) is allocated inside an arena belonging to the grpc_call in the non-deprecated case. If the sneaky call op set comes back, wouldn't that mean that there's a use-after-free? If something needs to be ref-counted, shouldn't it then be the call where this struct lives?

Yes, it is a use after free.
When the ResponseReader is destructed, the init_buf is destructed as well but it may not have come back from the cq.
The memory is not released but the object is destructed anyway, so reffing the call would not help.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

This is wrong because I missed the default_delete...
Will send the right one in another PR.


Fix the computation of unitsPerEm when the fontMatrix has some negative coefficients

It's a follow-up of #18253.

/botio test


Automatically strip/ignore domain in login form

I understand it is essentially needed that a username may not contain any characters that can't be used in a Unix login name. This would include the @ sign, being part of an email address.
When using (Azure) Active Directory authentication, the parameter User naming attribute cannot be set to userPrincipalName (UPN) but would need to stay with sAMAccountName.
However, living in the Azure AD Hybrid and Office 365 world, end-users have been told to use their e-mail address to login (which in turn should always match the userPrincipalName for that reason, to ensure identity related featured like AIP will work properly).
Also, sAMAccountName will likely be the same as the e-mail prefix today with only old accounts having a last century so called "pre-Windows 2000 login" in a cryptic naming convention a company had defined in the world before e-mail.
TL;DR
Long story short: End-users who would like to login to OPNsense to consume some self-service applications (e.g. download OpenVPN configuration - see #3748) should be able to use their Active Directory UPN (e-mail address) to login.
The idea is to let the user enter any e-mail address but simply strip the @domain.tld part before further processing. This is not a big change but make end-user communication much easier as you don't need to train users when to use their full e-mail address and when to leave out the domain part.
Surely this would not allow any multi-tenant setups by handling domains differently. However, OPNsense itself is not fully multi-tenant capable anyway, due to mutually exclusive Unix user names.

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


Add code coverage calculation

to help steer our efforts for #49

[ ] The coverage deps should be added to setup.py:extras_require:dev list.
[ ] The code coverage should be generated while running tests in a GitHub workflow job.
[ ] The coverage report should be hosted somewhere (SonarCloud, Codacy, codecov, etc., see #53).
[ ] The coverage report hoster should also have a coverage badge which should be added to this repos README.

[ ] The coverage deps should be added to setup.py:extras_require:dev list.
[ ] The code coverage should be generated while running tests in a GitHub workflow job.
[ ] The coverage report should be hosted somewhere (SonarCloud, Codacy, codecov, etc., see #53).
[ ] The coverage report hoster should also have a coverage badge which should be added to this repos README.

Limit to unit tests only

Limit to unit tests only

Coverage was added in #142


IGNITE-16615 TopologyService should be moved to ignite-api module

https://issues.apache.org/jira/browse/IGNITE-16615

This has been merged to main in fe0c86c044b0ab81b8c0aa7feb821479130e0d7a


Allow to load/generate types from configuration

possibly more condensed configuration
language independent configuration
(if generated) no need to manually write @property-read docblock tags

Additional thoughts:
By generating a schema for the configuration, IDEs may support suggestions and on-the-fly validation of the configuration file.
E.g. the PHP TypeConfig classes could be generated from the entities, which is already implemented.
The developer could optionally extend those generated PHP files manually to add additional properties for potential usage.
Then from a PHP TypeConfig class a schema file could be generated, e.g. an XSD, defining all properties and "capabilities" (readable, filterable, …) that can be used in the configuration.
With that XSD the IDE can support the developer when writing the actual XML configuration (where XML is still just an example for a possible format).
Unclear is if paths into the entities (for usage in aliases) should be defined in the schema file as well, which may result for many entities in a very big file.
Also, allowing to write custom-read/custom-update PHP code in the config file (e.g. XML) does not seem sensible.
Interpreting PHP code from an XML file would not necessarily be a security concern in itself in this specific case, but it definitively mixes two areas together that should remain separated.
Assuming no customization of the behavior or aliases are needed, this approach as a whole would allow for a completely non-programmatic way to define the API, as it would just require to invoke commands and writing the configuration file.
Such configuration files would also be independent from the PHP implementation, though there are currently no specific plans to implements the EDT concepts in other languages.


SceneObjectBase: Add utility function getAncestor

After developing the data trails https://github.com/grafana/grafana/pull/77019https://github.com/grafana/grafana/pull/77019
I found myself needing to get a parent object of a specific type a lot.
I think a utility function like this could be useful.
From a model callback or activation handler
function buildLayout() {
   const trail = this.getAncestor(DataTrail);
}

or from a react component render to subscribe to state of some parent.
function MyComponentRender(model: ComponentProps<MyComponent>) {
   const {showQuery} = model.getAncestor(DataTrail).useState();
}

Agree with @dprokop but this will be really useful!


Can't add api (mac os)

Okay so this is what I did.
Installed Kong through the homebrew method.

Added an api and returned:
{"public_dns":"google.com","id":"32152cfb-2d82-473c-c768-c17ec65b5594","created_at":1431420742000,"name":"loc","target_url":"localhost:9999"}

made sure I got an API running on localhost:9999

tried to run a cURL
curl -i -X GET --url localhost:8000 --header 'Host: google.com'

and I get:
HTTP/1.1 500 Internal Server Error
Date: Tue, 12 May 2015 18:14:38 GMT
Content-Type: text/html; charset=UTF-8
Transfer-Encoding: chunked
Connection: close
Server: kong/0.2.0-2

Why is the target URL missing a protocol? Like mentioned in the docs, it should start with http(s). Related to #149.
Can you try?

Given:
{"public_dns":"google.com","target_url":"http:\/\/localhost:9999","id":"163b2187-ff2f-49f5-c969-1145420d5cd5","created_at":1431507384000,"name":"lol"}

Tried and got this:
HTTP/1.1 502 Bad Gateway
Server: openresty/<IP_ADDRESS>rc0
Date: Wed, 13 May 2015 08:58:32 GMT
Content-Type: text/html; charset=UTF-8
Content-Length: 182
Connection: keep-alive
Via: kong/0.2.0-2

<title>502 Bad Gateway</title>

502 Bad Gateway

openresty/<IP_ADDRESS>rc0

Can you please trigger the error again and parse the logs at /usr/local/kong/logs/error.log ?

When trying to install with brew the new version:
Error: Failed installing dependency: https://luarocks.org/multipart-0.1-3.rockspec - Permission denied make: *** [install] Error 1

It's your computer, if you have to use sudo, it's not our issue.

It's not my computer - it's because of having installed the earlier PKG file has messed up the whole configuration with luarocks.
I give up on Kong OS X and move onto docker.

Can you use the new Kong package and let me know if it works?


Program became completely unresponsive (but under just what conditions I do not know)

I opened the program. I looked through some of its menus. I looked at the 'about' window. I discovered a little later that the program had become completely unresponsive - even the taskbar menu's 'quit' did not work. I have been unable to reproduce the problem (and, I am afraid, I have removed the program).

Yes, I knew there is a UX problem where the 'About' modal dialog window is easily lost. Once the window is covered by some other window, you need to find the window by the Alt+Tab shortcut key because you can't find it from the taskbar (as ShowInTaskbar of the window is set false).
I think I found a solution for this issue and will add the fix to the next release.
Thank you for reminding!


Overriding pre-loaded value from v-model

When I have a pre-loaded value on the model, it is changed by the component. Example:
...
    data () {
        return {
            time: '00:00:00:00'
        }
    },
...

<masked-input v-model="time" mask="+ 11:11" />

It doesn't load the value from the time model, instead it overrides with empty value. The only way I made it work was to reset the time variable on mounted() method:
mounted () {
    this.time = '00:00:00:00'
}

Fixed in 0.3.1. Please update

Fixed! Thanks


CORA Dashboard deployment with CloudFormation

Hello,
I don't see a parameter in the cid-cfn.yaml to deploy the CORA Dashboard, the only way to deploy it is via CLI.
Is this feature going to be supported through CFN anytime soon?
Thanks a lot.

On the way


openbullet.store

https://openbullet.store

Why are you doing this?  If no one cares about your site there MUST be a reason. Go away.


Django 4.0 compitability

in views.py there is:
from django.utils.http import is_safe_url

ImportError: cannot import name 'is_safe_url' from 'django.utils.http'

is_safe_url is outdates in django 4.0. it should be something like:
from django.utils.http import url_has_allowed_host_and_scheme as is_safe_url
once again, there is:
from django.conf.urls import url
in newer django versions, there is no url but from django.urls import path.

It seems you're not using the latest version, which is compat with Django 4.0.x:
See #317


Editor window - flash elements name

It would be nice if all flash elements have a * after there name
By Ronald van Loenen

If this refers to properties in the editor that only apply to older projects then this has been looked at. properties have either been deprecated or set as flash only


Compiling Detours on MinGW

I'm pretty close to getting this to work. I had to remove some MSVC-specific cruft from the header file to work around some duplicated typedefs when _MSVC_VER is undefined.
The only remaining sticking point is dealing with SEH calls. MinGW does not port these, and I'm unsure what the workaround might be.
For reference, these are the errors:
detours.cpp: In function 'bool detour_is_imported(PBYTE, PBYTE)':
detours.cpp:44:5: error: '__try' was not declared in this scope
     __try {
     ^~~~~
detours.cpp:68:5: error: '__except' was not declared in this scope
     __except(GetExceptionCode() == EXCEPTION_ACCESS_VIOLATION ?
     ^~~~~~~~
detours.cpp:68:5: note: suggested alternative: 'accept'
     __except(GetExceptionCode() == EXCEPTION_ACCESS_VIOLATION ?
     ^~~~~~~~
     accept

I'm trying to compile under MinGW to support interoperability with Kotlin, which can only compile under MinGW. Although MinGW has some support for interoperability with binaries compiled under MSVC, there are still issues with undefined symbols if you go that route.
Has anyone successfully compiled Detours with MinGW? If so what was your workaround for this?

I'm at the point of trying to use Detours with MinGW g++ and my immediate hunch is that it will work to use Visual C++ to create a DLL that will be usable from g++.

Compilation issues were fixed in #108, so it should compile cleanly for you now.
We can't claim to support this configuration though.

Compilation issues were fixed in #108, so it should compile cleanly for you now.
We can't claim to support this configuration though.


Try and fix failing CI

Codecov Report

Merging #229 (f911cc4) into master (fbde0b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   98.14%   98.14%
=======================================
  Files          40       40
  Lines        1022     1022
  Branches      147      147
=======================================
  Hits         1003     1003
  Misses          6        6
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbde0b2...f911cc4. Read the comment docs.

Codecov Report

Merging #229 (f911cc4) into master (fbde0b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   98.14%   98.14%
=======================================
  Files          40       40
  Lines        1022     1022
  Branches      147      147
=======================================
  Hits         1003     1003
  Misses          6        6
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbde0b2...f911cc4. Read the comment docs.


Change auth condition

Pull Request Test Coverage Report for Build 839320966

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 83.019%

Files with Coverage Reduction
New Missed Lines
%

src/composer.php
4
83.02%

Totals

Change from base Build 839196521:
0.0%

Covered Lines:
44

Relevant Lines:
53

💛  - Coveralls


Selecting invalid class

Currently it is possible to select an invalid class after how many classes has been asked and then what the file(s) is/are called.
-Create a try for the error.
Example:
How many classes do you have? 1
What is your file called? class4
Which class would you like to see the data for? class4
Traceback (most recent call last):
File "C:\Users\Laffy\Desktop\Task 3\StudentAnalysis.py", line 102, in
analyse()
File "C:\Users\Laffy\Desktop\Task 3\StudentAnalysis.py", line 43, in analyse
file = open('%s.csv' %classchoice)
FileNotFoundError: [Errno 2] No such file or directory: 'class4.csv'

Sorted by setting up a try so that it restarts if it can't open the file. Looking for a better fix ASAP. Had to add an additional layer of a defined function.


supports external schema files based on filename

(posted as Work in Progress to get feedback on the approach)
This fixes #26 by reading a new entry in ~/.atom/config.cson:
"linter-autocomplete-jing":
  rules: [
    {
      testPathRegex: ".cnxml$"
      outcomeSchemaProps: {
        lang: "rng"
        path: "/path/to/cnxml-jing.rng"
      }
    }

Additionally, if your file extension is not recognized by Atom as an XML file then you will need to add an entry similar to:
"*":
  core:
    customFileTypes:
      "text.xml": [ "index.cnxml" ]

Screenshot

Install Instructions
git clone https://github.com/philschatz/linter-autocomplete-jing`
cd linter-autocomplete-jing
git checkout external-schema-file
apm link .
npm run-script watch
# restart atom

TODO

[ ] clean up the JavaScript code
[ ] discuss how to obtain the namespace of the root element (to support the rootNs: option discussed)

Hi Phil, thank you for the PR! You don't have to worry about rootNs -- there's already an implementation of a rule processor at https://github.com/aerhard/linter-autocomplete-jing/pull/25 which takes path regex, rootNs etc into account and also supports pre-parsing / caching the rules. Would you like to merge that branch into yours? What's missing is that the rules from the config need to get fed into the rule processor. You could achieve that in src/main.js by inserting something like this
if (key === 'rules') {
  parsedRules = ruleProcessor.parse(value);
  return;
}

at the start of setLocalConfig (https://github.com/aerhard/linter-autocomplete-jing/blob/feature/validation-config/src/main.js#L45). Would that make sense?
That's a nice graphic -- should we add the animated GIF file to README.md?

I'm going to publish version 0.6.0 of the package (containing a couple of bug fixes and new features) so in order to include both config and external package based approaches I've merged your changes with the other commits, see https://github.com/aerhard/linter-autocomplete-jing/tree/external-schema-file -- do you have any additions or comments?

🎉  Thanks! that should work for our use-case (and hopefully others)

great, thanks!


feat: make homepage

So I have made the homepage using Chara UI and will fix bugs later.
Please comment down the bugs.

AHH gonna start working on this again.

closing due to inactivity


Add a complete test for AddUserCommand

This adds a simple test for AddUserCommand that creates a user non-interactively and interactively.
Fixes https://github.com/symfony/symfony-demo/issues/473.

Thanks @dmaicher.


withdraw popup text update

on the withdraw popup, please update the following texts (and logic on how to display them):

warning text (orange text).

check, IF user withdraw BNT position:
current text:
Important
You still haven’t reached full coverage. There is a risk for impermanent loss.
updated text:
Important
You still haven’t reached full protection. There is a risk for impermanent loss and you might receive less than your original stake amount as a result.
check, IF user withdraw TKN position:
current text:
Important
You still haven’t reached full coverage. There is a risk for impermanent loss.
updated text:
Important
You still haven’t reached full protection. There is a risk for impermanent loss and you might receive less than your original stake amount as a result.

new gray text
IF withdraw BNT: BNT withdrawals are subject to a 24h lock period before they can be claimed
IF withdraw TKN and breakdown includes BNT: Part of your output is in BNT.
This amount will be locked for 24h before it can be claimed
IF withdraw TNN and breakdown DOES NOT include BNT: no text.

https://www.figma.com/file/3yED7o7TgoLwoEjV2EkRLL/Bancor-V2?node-id=1044%3A858

updated text. On staging for review @ashachaf