Fix mapping Microsoft SQLServer dialect

Fix mapping of StringType to NVARCHAR(MAX)
Fix mapping of BooleanTypeto BIT

Can one of the admins verify this patch?

(I think it would be even nicer if this PR follows https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark)

the problem is if it is run with no fix throws an exception and causes the following error:
-"Cannot specify a column width on data type bit."
The problem stems from the fact that the "java.sql.types.BIT" type is mapped as BIT[n] that really must be mapped as BIT.
This concerns the type Boolean.
As for the type String with maximum length of characters it must be mapped as VARCHAR (MAX) instead of TEXT which is a type deprecated in SQLServer.
Here is the list of mappings for SQL Server:
https://msdn.microsoft.com/en-us/library/ms378878(v=sql.110).aspx

some updates about ?

@meknio the description in you last comment should be in the first comment in the PR (so that it ends up in the git history).
ok to test

Test build #3479 has started for PR 13944 at commit 8e51e45.

Test build #3479 has finished for PR 13944 at commit 8e51e45.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@meknio if you'll update as Marcelo says, I'll merge this. Change the description here to contain your comment at https://github.com/apache/spark/pull/13944#issuecomment-229395810

This looks like a nice fix and seems like @meknio is missing in action, so I'll just fix the commit message myself.
Merging to master.


Fix compliance direct communitcation

Description
This is rebase of #63. Thanks to @jeremymv2 for this great work. This fixes the refresh_token authentication which wasn't working correctly. It has been tested with ubuntu 14.04 and windows 2012R2
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Kudos @jeremymv2 and @chris-rock !!


Added Heiman HS1CG-M Combustible Gas Sensor

http://www.heimantech.com/product/76.html
I believe it's the successor of the HS3CG but I'm not entirely certain

Thanks!

Hi @WoLpH,
I have the same sensor but the model on it is HS1CG-E and it identifies by Zigbee model 'GASSensor-EM'.   Would be great if you can add it to the model list.
Thanks!

@Filipok-A I can add it if you can give me some debug logs while adding the device. Just to be sure it's the same thing with the same support :)
Alternatively, it's just a few lines to change/copy so you can easily test if it works for you by changing 2 lines: https://github.com/Koenkk/zigbee-shepherd-converters/pull/543/files#diff-6c9a6acf22f90d1c6e524d9f3c5c1745R3443-R3444

I have been using it by adding this model to the config of HS3CG, and it works fine.  And from what I see the config is identical to HS1CG.


chore: [FX-4004] Replace Quill with Lexical

FX-4004
Description
This PR aims to replace the Quill rich text editor with the Lexical Editor. The Lexical Editor is a powerful, feature-rich text editor that provides superior performance, better support for various content formats, and improved integration capabilities with other tools.
How to test
— Alpha Package of NPM Packages: You can install the alpha version of the new packages from npm and integrate them into your local environment. Test the functionalities and provide us with your feedback.
— Storybook Temploy: A temploy is also available to test the new version. This interactive UI provides a comprehensive way to visualize and test the components.
Development checks

[x] Add changeset according to guidelines (if needed)
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Ensure that deployed demo has expected results and good examples
[x] Self reviewed
[x] Covered with tests
[x] test alpha package of Picasso in the existing project

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run package:alpha-release

@toptal-anvil ping reviewers


Some structs from std::sync not appear in autocomplete

Just try input Arc or Once. In autocomplete list it must appear under std::sync, but nothing here from that module.

Could extern crate alloc as alloc_crate; in std/lib.rs be handled incorrectly?

@bjorn3
Maybe. But Mutex is imported correctly. Condvar too.

Arc and Once are defined in liballoc and re-exported in libstd. Mutex and Condvar are defined in libstd.

std::sync::$0 does complete Arc and Once, but typing them without the path doesn't

I think the reexport is the culprit indeed, my guess is that we're either ignoring them when populating ImportMap or somehow do not consider the reexported path afterwards, when doing the search.
The path prepending "fixing" the problem is explained by the fact that we use different logic to complete in this case (not from the flyimport.rs module, but from the qualified_path.rs one)

I've debugged it using the  current master branch and looks like the issue is not with the item lookup, but with the search limits and the way we store the associated items.
If you bump the
https://github.com/rust-analyzer/rust-analyzer/blob/342bf41022fa78856a48560b521ea32aa76f6f06/crates/ide_db/src/imports_locator.rs#L18
constant to, say, 100, Arc starts to pop-up in the results.
(we cannot remove the limit entirely or keep it very high, because it reduces the imports lookup speed)
Interesting to note, that on a zero-dependency project and bumped constants, I get 19 results in total:

So, even the default limit should suffice, but it does not.
The code that triggers the search is here: https://github.com/rust-analyzer/rust-analyzer/blob/09c11054a1b4886fdfd8f0bbb119aae0f264af1a/crates/ide_db/src/helpers/import_assets.rs#L183-L195
and the code that does the actual search, taking the limit into account is here: https://github.com/rust-analyzer/rust-analyzer/blob/af4e75533f2c071330e740e2fa94b131e3a2b538/crates/hir_def/src/import_map.rs
Right now, we exclude associated items from the fuzzy search ((AssocItemSearch::Exclude, Some(DEFAULT_QUERY_SEARCH_LIMIT))), but I'll include them in https://github.com/rust-analyzer/rust-analyzer/pull/7873 and 100 won't work anymore, you'll need 200 for that for a zero-dependency project and presumably way more for "real" projects.
So we cannot just bump the limit and hope for the best, we need to search for the dependencies in a more clever fashion somehow, maybe split the associated items from the rest of the items and search those separately?

@asv1 , could you recheck the situation after https://github.com/rust-analyzer/rust-analyzer/pull/8131 lands?
That adds case-aware lookup into the completions, can help in your workflow.

@SomeoneToIgnore
Looks like ok now.


populate some more legacy checkpoints

What does this PR do?
adding some more legacy checkpoints, followup on #5223
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified
[x] Check that target branch and milestone match!

Did you have fun?
Make sure you had fun coding 🙃

well not sure why the newly added ckpt fails, locally it works fine...

well not sure why the newly added ckpt fails, locally it works fine...

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4
and it includes also the later PL versions such as 1.1.3
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.3]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.4]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.5]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.9.0]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.0.8]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.0]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.1]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.2]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.3]

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4
and it includes also the later PL versions such as 1.1.3
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.3]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.4]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.5]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.9.0]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.0.8]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.0]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.1]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.2]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.3]

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4
and it includes also the later PL versions such as 1.1.3

what's the error?

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4
and it includes also the later PL versions such as 1.1.3

what's the error?

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4 and it includes also the later PL versions such as 1.1.3

what's the error?

PT somehow states that the ckpt is an archive...
                if _is_zipfile(f):
                    # .zip is used for torch.jit.save and will throw an un-pickling error here
>                   raise RuntimeError("{} is a zip archive (did you mean to use torch.jit.load()?)".format(f.name))
E                   RuntimeError: /home/runner/work/pytorch-lightning/pytorch-lightning/legacy/checkpoints/1.1.3/epoch=4-step=319.ckpt is a zip archive (did you mean to use torch.jit.load()?)

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4 and it includes also the later PL versions such as 1.1.3

what's the error?

PT somehow states that the ckpt is an archive...
                if _is_zipfile(f):
                    # .zip is used for torch.jit.save and will throw an un-pickling error here
>                   raise RuntimeError("{} is a zip archive (did you mean to use torch.jit.load()?)".format(f.name))
E                   RuntimeError: /home/runner/work/pytorch-lightning/pytorch-lightning/legacy/checkpoints/1.1.3/epoch=4-step=319.ckpt is a zip archive (did you mean to use torch.jit.load()?)

this seems to be very similart issue:

https://github.com/pytorch/pytorch/issues/25214

so the problem is that we cannot save checkpoints with and load with lover version, the breaking change is in 1.7 so for creating legacy checkpoints we have to use the lowest supported version...

this seems to be very similart issue:

https://github.com/pytorch/pytorch/issues/25214

so the problem is that we cannot save checkpoints with and load with lover version, the breaking change is in 1.7 so for creating legacy checkpoints we have to use the lowest supported version...

ok, seems that there is some problem with v0.8.5 and v0.9.0 so I would leave it for another PR...
eventually, we may consider making some workaround to transform archive to loadable format or use torch.jit

ok, seems that there is some problem with v0.8.5 and v0.9.0 so I would leave it for another PR...
eventually, we may consider making some workaround to transform archive to loadable format or use torch.jit


implemented airdrop handler with no interaction with airdrop registry

simplified version of https://github.com/lidofinance/lido-terra-contracts/pull/125 with no airdrop contract refactoring

i absolutely hate to say this, but the PR would probably be even smaller if we just provided the withdrawal account as an argument to the handler, right? we might also want to claim airdrops to different withdrawal accounts, by the way, which makes global configuration less attractive


Explicitly allow a blank space at beginning of a method

The guide has never forbidden this, but it would be nice to explicitly allow a line of whitespace to separate a method's name and body.

Personally, I find this practice pretty odd. Even with long method names, the separation creates an asymmetry that I find perplexing:
- (void)doAReallyWordyThing:(NSString *)thing withAnotherThing:(NSString *)anotherThing thirdThing:(NSString *)third {

    NSLog("Hi");
}

To my eyes, that looks unfinished, untidy , and quite odd.

Woah. :zap: fast merge from @Twigz.

Said another way, I’m not sure why long method name + additional line of whitespace “providing visual separation before the method’s body” is a good thing.

Because it makes it much easier to spot the method name if it is separated from the code. Especially in the case of multiline method names.

So here, in light of discussion around #101, we wanted to make clear that this is allowed; it was never disallowed by the style guide. To discuss disallowing this line of whitespace, we can open that discussion if someone were to send a PR explicitly disallowing this practice.

@paulbruneau Mind providing an example so I can wrap my head around this? I feel like a dummy for not having considered / run into this before.

I will note that while I don't typically add this line, it can be helpful to provide visual separation:
- (instancetype)initWithSomeLongListOfParameters:(id)parameter1 parameter2:(id)parameter2 parameter3:(id)parameter3 parameter4:(id)parameter4 parameter5:(id)parameter5 {

    NSParameterAssert(parameter1);

    if (parameter3) {
        doSomeWorkWithParam3(parameter3);
    }
    else {
        doOtherStuff();
    }
    // …

vs. here, where the assertion gets visually lost below the method's name:
- (instancetype)initWithSomeLongListOfParameters:(id)parameter1 parameter2:(id)parameter2 parameter3:(id)parameter3 parameter4:(id)parameter4 parameter5:(id)parameter5 {
    NSParameterAssert(parameter1);

    if (parameter3) {
        doSomeWorkWithParam3(parameter3);
    }
    else {
        doOtherStuff();
    }
    // …

Or how about:
- (void)methodWithParameter1:(id)parameter1
                               parameter2:(id)parameter2
                               parameter3:(id)parameter3 {
    NSParameterAssert(parameter1);

vs.
- (void)methodWithParameter1:(id)parameter1
                               parameter2:(id)parameter2
                               parameter3:(id)parameter3 {

    NSParameterAssert(parameter1);

Yep. Here's my example:
+ (void)requestFreePuzzlesForPackIdentifier:(NSInteger)packIdentifier
                                 completion:(void(^)(NSArray *))completion {
    AFHTTPClient *client = [XWDCommunicator sharedHTTPClientCurrentEndpoint];
    NSString *puzzleRequestPath = [NSString<EMAIL_ADDRESS>packIdentifier];
    NSString *path = [[XWDCommunicator crosswordsV2Path] stringByAppendingPathComponent:puzzleRequestPath];

vs
+ (void)requestFreePuzzlesForPackIdentifier:(NSInteger)packIdentifier
                                 completion:(void(^)(NSArray *))completion {

    AFHTTPClient *client = [XWDCommunicator sharedHTTPClientCurrentEndpoint];
    NSString *puzzleRequestPath = [NSString<EMAIL_ADDRESS>packIdentifier];
    NSString *path = [[XWDCommunicator crosswordsV2Path] stringByAppendingPathComponent:puzzleRequestPath];

of course my personal, illegal favorite, is:
+ (void)requestFreePuzzlesForPackIdentifier:(NSInteger)packIdentifier
                                 completion:(void(^)(NSArray *))completion
{
    AFHTTPClient *client = [XWDCommunicator sharedHTTPClientCurrentEndpoint];
    NSString *puzzleRequestPath = [NSString<EMAIL_ADDRESS>packIdentifier];
    NSString *path = [[XWDCommunicator crosswordsV2Path] stringByAppendingPathComponent:puzzleRequestPath];

And Matt I would think you would have run into this before when you were reviewing my pull requests in 2012/2013 because I often added the line of whitespace then :)


Provide a github plugin to auto-apply versionCode/versionName

So users don't have to paste something in their CI.
Also, allow them to upload builds from their CI to Tramline from the same.

This is getting covered in #535.


[Auto-generated] Check & update dependencies (pyproject.toml)

Update dependencies (pyproject.toml)
Automatically created PR based on the 'CI - Check pyproject.toml dependencies' workflow in SINTEF/ci-cd.

Same as before - these version updates either support only pydantic v2 or do not work with OTEAPI OPTIMADE


Incorrect portrait poster size saved

Bug Description
When a story is saved, the poster-portrait-src is incorrectly using the medium size instead of the actual portrait poster size we generate.
This will raise warnings in Search Console.
Why does this happen?
In Stories_Base_Controller and Stories_Autosaves_Controller we set featured_media_url like this.
In the story provider, the URL is then used as-is without further ado.
Then, in the Story_Renderer, we actually do get the poster, but only for the landscape & square sizes. The portrait poster is not overridden though because it's already available.
To fix this:

Override portrait poster in Story_Renderer
Use correct portrait poster image size for featured_media_url

Expected Behaviour
The portrait poster should use the correct image size.
Steps to Reproduce
Add featured image, preview story, check the source code.
Screenshots

Additional Context
User reports: #3401, #3409
Image sizes need updating: #3297

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Note that #3435 partially addresses this (it was a 1 line change to Story_Renderer)


Cluster-autoscaler: store scale down state in a struct.

cc: @fgrzadkowski @piosz @jszczepkowski

This change is

LGTM
Consider adding unittests for TryToScaleDown method (in a subsequent PR).


Better error messages for invalid vs. nonexistent method versions

Thanks for submitting your feedback to Dockstore.
Please fill in the appropriate section depending on whether you want to submit a feature request or a bug report.
Bug Report
Expected behaviour
When trying to hit the GET WDL descriptor endpoint, if we get a 404 we want error messages to be specific to the cause of the of the 404. We want the user to know if the 404 was the result of the method version is invalid or doesn't exist at all.
Actual behaviour
Currently, the user can't tell why they're getting a 404.
Steps to reproduce the behavior
This is a method version that is invalid: https://dockstore.org:8443/api/ga4gh/v1/tools/%23workflow%2Fgithub.com%2FHumanCellAtlas%2Fskylab%2FHCA_SmartSeq2_wdl_checker/versions/10x_v0.1.0/WDL/descriptor
This is a method version that doesn't exist:
https://dockstore.org:8443/api/ga4gh/v1/tools/%23workflow%2Fgithub.com%2FHumanCellAtlas%2Fskylab%2FHCA_SmartSeq2_wdl_checker/versions/doesnt_exist/WDL/descriptor
Both error pages look the same.

https://staging.dockstore.org/api/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2FHumanCellAtlas%2Fskylab%2FHCA_SmartSeq2/versions/10x_v0.1.0/plain-WDL/descriptor//pipelines/smartseq2_single_sample/ss2_single_sample.wdl  not found.
https://staging.dockstore.org/api/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2FHumanCellAtlas%2Fskylab%2FHCA_SmartSeq2/versions/potato/plain-WDL/descriptor//pipelines/smartseq2_single_sample/ss2_single_sample.wdl also not found
Don't see a linked PR. wrong column?

shows Not Found : version found, but file not found (bad filename, invalid file, etc.)
and
Not Found : version not found now


Make a full text index on a field

Actually this may be something we want to do on the fly in the workshop. Maybe one dataset can have it pre-made but another can do it on the fly


Redirect to any page

Hi @master-atul, Is that possible to redirect any page instead of Restart? I'm using router-flux and assigned couple of page declaration got done in the App.js file and since we are setting the SetExceptionHandler in Index.js page. I could'nt able to redirect the user to the home page or any other page and can able to only restart. Please suggest your inputs here ASAP and it would be great. Thanks.

Hi @shivsuthanm-odhub
For JS Exceptions
This can be made to work with some hacks I think. Although need to see.
For Native Exceptions:
In short:  NO
Redirect to any other pages cant be done because. When an uncaught exception occurs the entire JS Engine shuts down. As a result you wont be able to use the routes you wrote in Javascript. But instead if you wish to write a custom screen. You can do so by creating a custom native view. See Creating Custom native exception handler screens section in the readme for more details.

@master-atul Thank you so much for the quick reply. can you please suggest how can handle this activity at least in Js crash? Like, redirect any pages which are having in the application instead of doing the restart? Thank you!


Investigate steps required to become the official FMOD plugin for Godot

Unity is already featured on the FMOD page: https://www.fmod.com/resources/documentation-unity?version=2.02&page=welcome.html
Investigate what we'd need to do to transform this project into an official FMOD plugin for Godot.
This could allow us to legally access the FMOD binaries and sign them, for example, and then bundle that up for people to use. This repository here would not contain the bundle but instead, the plugin would be available on the FMOD asset store.

Here is an existing thread about godot integration: https://qa.fmod.com/t/how-does-fmod-integrate-with-godot/16130
Also answer from fmod sales about distributing dynamic libraries:
Hi Pierre,

You are able to redistribute the fmod dlls, but typically not the headers/libs, which I assume doesn’t help your case and I’m guessing you want those included as well.

The only issue we have with distribution like this is something in a store is typically not updated in line with our releases, and the binaries get stale.  This can lead to old versions being used which possibly known bugs, which can reflect badly on the product from our side.

So it seems it is "we will not support it if it is not made by us".

Hi, FMOD developer (not sales) here. I just wanted to clarify - where would you like to distribute the plugin? The first comment above says "on the FMOD asset store" - would you want users to download it from the FMOD website?

Hello @benbatt
@bitbrain idea was to try to make it an official fmod plugin, downloadable from fmod website, on this I can understand this can be not compatible with your company rules.
On my side few years ago I wanted to be able to distribute the fmod dynamic libraries within our plugin, so that we can distribute an addon on Godot store without the need to copy those dll for developers.

OK, I have asked around, and unfortunately to host it on the FMOD website we would need to be able to test and maintain the plugin on a regular basis, which is not something we currently have the resources for. Sorry!
Is there an issue with the FMOD .dylib files being unsigned? Game developers usually sign them along with the rest of their game, but perhaps that is not possible in this case?

Fmod libraries being unsigned is not a problem, Godot exports will sign them.
What I’d like is to be able to deliver those dynamic libraries in our releases. This would enable us to deliver a plug and play addon for Godot.

@benbatt for context: currently, people cannot just simply "plug & play" FMOD with Godot. They can download this extension here but they'd need to grab the FMOD dynamic libraries themselves and compile this extension themselves.
Our idea is to do that for them somehow, however, due to licensing we cannot simply download and package these dynamic libraries for them. If there was a way or exception for us specifically to do this, that would already be a massive step forward.


[ENH] - Ability to deploy on digital ocean with a project

Feature description
Title says it all. We should be able to deploy on digital ocean within a single project.
Value and/or benefit
This will make it easier to account for resource usage.
Anything else?
No response

Closing this for now, feel free to reopen if you feel otherwise


iOS supported?

Reference to iOS supported? #36!!
It's working on IPhone XS, IPad etc but not on IPhone X.
After the recording is stopped, not error, but the wav file it's not playing and it's invalid.

I don't have this device. Feel free to send PR.

I can confirm it. It's seems a bug recently with iOS (iPhone 8). The recording is well but after recording is stopped it can't playback. If I minimize browser to tray and open after some time (~10 sec) playback is work well. Seems like iOS can't play audio when device is busy with capturing.

I’ve just update iOS from 13.1.3 to 13.2.3 and now all works fine.

got same issue on 13.1.3. but it works on demo page.
would you mind provide the source code of demo page?

i'm just trying call navigator.mediaDevices.getUserMedia({ audio: true }).then() on random page, only your demo page will show the red microphone icon in navbar. 🤔

i've tried call navigator.mediaDevices.getUserMedia({ audio: true }) on random page, only your demo page would show the red microphone icon on nav bar.
that's weird cause you are not rewrite the behavior right? (navigator.mediaDevices.getUserMedia)

If you are trying on mobile in develop mode (using your IP instead of localhost), you have to make sure that HTTPS is enabled. Otherwise, navigator.mediaDevices will be undefined


Fix regression "X.matches is not a function" in v3.16.6

What:

I fixed the regression caused by #209 and described here: https://github.com/kentcdodds/dom-testing-library/pull/209#issuecomment-463217859

After this was merged, I'm getting container.matches is not a function using cypress-testing-library. Any ideas why this could be?
Update: I can confirm it was this change. I edited my package json to force it to resolve dom-testing-library to v3.16.5 (the version prior to this being released) and my tests passed.
My cypress test's use of this library is a mere cy.getByLabelText('User name').type('john') (it's a new project and I'm just starting to write tests to it).

Why:
I want my Cypress tests to pass with the latest dom-testing-library :smile:

How:
I first added a failing test case, running in CI, to demonstrate the existence of a regression.
Then the next commit will fix that by testing first that we can use .matches function as described here: https://github.com/kentcdodds/dom-testing-library/pull/209#issuecomment-463309607

Checklist:

Documentation added to the docs site N/A
Typescript definitions updated N/A
[x] Tests
[ ] Ready to be merged
[x] Added myself to contributors table

Actually #215 seems to highlight yet another issue with this same code branch. I'll see if I can fix that, too

Thanks for working on this @valscion! I'll wait until you give me the :+1: before merging :)

I think that I'm too confused on #215 currently that I'd feel better if we'd merge this PR to fix the regression raised in #209 and then if this won't resolve #215, I'll create another PR to tackle that.
So let's merge this as it currently stands, just to get the fix for Cypress out the door at least.

Thanks!

:tada: This PR is included in version 3.16.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Spi rw squence

This pr is to correct the r/w bit logic for SPI devices.
Fixes #3

I have published this in version 0.1.2


PageMatch: Expand #find_versions tests

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

This is a follow-up to #11888, where I modified the early return conditions for PageMatch#find_versions to allow a strategy block to [temporarily] act as a substitution for a regex. That PR was a fix for an issue affecting some casks that don't follow established patterns, so I wanted to get it merged quickly. This PR contains related changes that I would have handled in #11888 if I had more time.
This adds a test to ensure that PageMatch#find_versions works when a block is provided but a regex isn't. I've added comments to explain that this is temporary and the pattern in the test shouldn't be followed.
Similarly, I've updated related method signatures and documentation comments to reflect that the regex parameter is technically nilable for now. The method signature changes were required for this to pass.
Looking forward
Existing cask livecheck blocks that don't use #regex to establish a regex and pass it into a strategy block should be updated to do so. This has long been the pattern in homebrew/core and homebrew/cask should be brought up to standard (in many other ways as well).
One challenge is that there are some cask strategy blocks that require more than one regex but #regex currently only works with one regex. With some of these strategy blocks, there's a clear primary regex that can be established using #regex and any secondary regexes can be inlined in the strategy block. We do this with a few complex strategy blocks in homebrew/core (e.g., bash).
The issue is that some of the cask strategy blocks with more than one regex don't have a primary regex that can be reasonably extracted into a #regex call. These exceptions would prevent us from eventually getting to a point where we standardize on always establishing regexes using #regex and passing it into a strategy block.
One solution to this could be to modify the #regex DSL to allow either a hash with Regexp values or an array of Regexps. These would both achieve the same purpose but there are benefits/detriments to each.
Either way, we would only allow a non-Regexp value when a strategy block is present (as the strategy wouldn't know what to do with a non-Regexp value by default). However, we want #regex to appear before #strategy in a livecheck block (to make it clear that it's the same regex being passed into the strategy block), so this would need to be enforced somewhere outside of the #regex DSL method.
Allowing for multiple regexes when using #regex would also let us avoid having to determine which regex is a primary regex and which are secondary. This is currently a bit subjective, so it would be nice to avoid this question entirely.
This shouldn't be difficult to implement, so I'll investigate it and work on creating a PR.

Review period will end on 2021-08-20 at 15:21:16 UTC.

Review period skipped due to critical label.

I'm labeling this as critical, since this is a continuation of #11888 and I didn't have time to thoroughly test that change. I'm going to do comparative runs across homebrew/core and homebrew/cask using the commit before #11862 was merged and the commit in this PR, to ensure everything is working as expected.

Having checked all the first-party formulae/casks, everything appears to be working as expected. Since #11888 wasn't thoroughly tested but this was, I'm going to go ahead and merge this as a continuation of #11888.
That should be it for critical bug fixes and I'll be returning to the usual PR review format for forthcoming changes.


[T6A3][W13-C4] Hee Han Xiang

@fisherhx
Some comments added. Please ack & close the PR after reading comments.


Problem with rendering diacritic in SVG mode

Issue Summary
There are problems with the display of some diacritcs. I have tested this directly on the MathJax website under the #demo section.
Steps to Reproduce:

Go to https://www.mathjax.org/#demo
Insert the Formula: <math xmlns="http://www.w3.org/1998/Math/MathML" display="inline"><mi>Ĥ</mi></math>
May press "Render HTML"

Here you can see that the "H" and the "^" part are not displayed correctly one above the other, but overlap
Technical details:

MathJax Version: 3.0.5 (See Website MathJax.version)
Client OS: Windows 10 (Latest)
Browser: Chrome 81.0.4044.122

Screenshot

Your example uses the two-character sequence U+0048 U+0302 (an H with a combining circumflex accent), but this is not how accented characters are meant to be specified in MathML.  The MathML specification indicates that these should be formed with <mover> elements; see the documentation on combining characters:

there are many combining characters that are intended to be used for the many accents of numerous different natural languages. Some of them may seem to provide markup needed for mathematical accents. They should not be used in mathematical markup. Superscript, subscript, underscript, and overscript constructions as just discussed above should be used for this purpose. [bold added]

The mover documentation gives examples of how this should be done.  For instance, your expression would be
<math xmlns="http://www.w3.org/1998/Math/MathML" display="inline">
  <mover>
    <mi>H</mi>
    <mo stretchy="false">^</mo>
  </mover>
</math>

It is also possible to use the single-character accented letter from the Latin Extended-A Unicode block, U+0124.  For example
<math xmlns="http://www.w3.org/1998/Math/MathML" display="inline">
    <mi>Ĥ</mi>
</math>

Note, however, that this character is not in the MathJax fonts, so it will be taken from a system font, and so may not match the rest of the math quite so well.
The reason that your version doesn't work well in MathJax is that the combining circumflex (U+0302) is designed to work with lower-case letters, so doesn't fit properly with upper-case ones.  That is why it is not high enough.  Since MathML suggests that you use the <mover> construction for such characters, MathJax doesn't include code to try to reposition the combining character.


Anybody managed to run YAWIK on nginx or h2o?

Whatever I try with these two servers, I don't manage to make it work.
Installation of YAWIK seems to work fine. But after that I am thrown into a redirect loop:
http://mydomain.org/ -> http://mydomain.org/en/error
http://mydomain.org/en/error -> http://mydomain.org/en/error
http://mydomain.org/en/error -> http://mydomain.org/en/error
etc. etc.
until the browser gives up.
I tried various configurations for zf2 apps on nginx, which I found on the internet. They work quite differently, but each of them ends up with this problem.  I can't believe I am the only one who tried it. Did anyone manage to find a working configuration?

I went back to Apache. But encountered the same problem here. Note: In each case I was using PHP as a stand-alone fcgi-server (php-fpm). Maybe this is the reason? But shouldn't it work.
NB: If you ask, why I did not use Apache with mod_php? I am trying to find something a little more modern/performant. mod_php is not thread-safe and this it cannot be used with Apache's newer MPM-models (I am testing "event" but "worker" would be the same).

I now even went so far as to use the non-threaded Apache MPM-module (pre-fork) with mod_php.
But the result is always the same: I can reach the install page. I can create the yawik database and user. But when I want to continue to yawik, I end up in an indefinite redirect loop (302).
My  vhost.conf looks exactly like in the documentation (and it works on my local machine). What else could cause this behaviour?

OK, solved it... had nothing to do with the specific web server. I just had to install a handful additional php modules, such as tokenizer, xml and session... the installation documentation only covers a small subset of the actually required ones. I started with a fresh install of FreeBSD 10.2 and ended up with these (some of them were required by composer, when I installed the dependencies - they might actually not be need to run YAWIK). Be aware that a few of them are named differently from e.g. Debian packages:
mod_php56-5.6.14               PHP Scripting Language
php-composer-1.0.0.a10         Dependency Manager for PHP
php56-5.6.14                   PHP Scripting Language
php56-ctype-5.6.14             The ctype shared extension for php
php56-curl-5.6.14              The curl shared extension for php
php56-dom-5.6.14               The dom shared extension for php
php56-filter-5.6.14            The filter shared extension for php
php56-hash-5.6.14              The hash shared extension for php
php56-json-5.6.14              The json shared extension for php
php56-mbstring-5.6.14          The mbstring shared extension for php
php56-openssl-5.6.14           The openssl shared extension for php
php56-phar-5.6.14              The phar shared extension for php
php56-session-5.6.14           The session shared extension for php
php56-simplexml-5.6.14         The simplexml shared extension for php
php56-tokenizer-5.6.14         The tokenizer shared extension for php
php56-xml-5.6.14               The xml shared extension for php
php56-zlib-5.6.14              The zlib shared extension for php
pecl-intl-3.0.0_2              PECL extension to support Internationalization(ICU)
pecl-mongo-1.6.11              PECL classes for Mongo Database Driver


Add abort-on-container-exit option to compose.up

Related issue: #166

@gabrieldemarmiesse any idea why the flake8 command fails?

Going at the bottom of the logs, a bit hidden, I see
./python_on_whales/components/compose/cli_wrapper.py:267:72: W291 trailing whitespace
#13 2.285 ./python_on_whales/components/compose/cli_wrapper.py:270:25: W291 trailing whitespace

I believe this is the reason

I fixed those lint issues but the ci still fails on my local machine.

We use the balck formatter on this codebase, this is why the ci is complaining.
Could you do isort ./ && black ./ and push again? This should fix those formatting problems. Thanks!

@gabrieldemarmiesse  I run the test I added on my local machine (MacBook Pro), any ideas why it fails in CI?

I will take a look today, thanks again for the pull request!

I see the problem, but I don't know the root cause.
In the CI, during the test, we see:
alpine_1  | 5 packets transmitted, 0 packets received, 100% packet loss

locally, I have
alpine_1  | 5 packets transmitted, 5 packets received, 0% packet loss

I wonder if we're just unlucky and that's a temporary network issue in the CI, I'll restart the job.

It's not luck it seems. I'll try to find out how we can fix this test.

Thanks a lot for helping with debugging the issue, I will make the required changes regarding the docs.

It seems there is an issue on master, the CI doesn't pass suddently. Very likely something was updated and it caused the various issues we saw in your pull request. You can consider that this pull request is done (it was approuved). I'll work on the CI to make it work again. Thanks for your patience :)

Thank you for your help.


Introduce IPRangeBucket type for IpRange aggregation

The current RangeBucket implementation ignores "from" and "to" for an ip_range aggregation, by looking at the JSON token type when deserializing, and only deserializing when it is a number:
https://github.com/elastic/elasticsearch-net/blob/28f37744d388df46139b9fe92a8b3c20a18c4692/src/Nest/Aggregations/AggregateJsonConverter.cs#L576-L587
This ignores "from" and "to" string values for ip_range aggregation, an example response being
{
  "took" : 39,
  "timed_out" : false,
  "_shards" : {
    "total" : 2,
    "successful" : 2,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : 1100,
    "max_score" : 0.0,
    "hits" : [ ]
  },
  "aggregations" : {
    "ip_range#ip_ranges" : {
      "buckets" : [
        {
          "key" : "*-<IP_ADDRESS>",
          "to" : "<IP_ADDRESS>",
          "doc_count" : 52
        },
        {
          "key" : "<IP_ADDRESS>-*",
          "from" : "<IP_ADDRESS>",
          "doc_count" : 48
        }
      ]
    }
  }
}

Introduce an IpRangeBucket type or make RangeBucket a generic type, i.e.
public class RangeBucket<TRangeValue> : BucketBase, IBucket
{
	public RangeBucket(IReadOnlyDictionary<string, IAggregate> dict) : base(dict) { }

	public long DocCount { get; set; }
	public TRangeValue From { get; set; }
	public string FromAsString { get; set; }

	public string Key { get; set; }
	public TRangeValue To { get; set; }
	public string ToAsString { get; set; }
}

An IpRangeBucket type is probably better here, since FromAsString and ToAsString are not properties of the response.

This is now merged into 7.x in #3647


Ddded missing dependency for microprofile

Jira card:  TOMEE-2731
This fixes a missing dependency for microprofile.  This was discussed in the dev email list.
I added:
<dependency> <!-- Added in for backwards compatibility with the move to Jakarta EE coordinates -->
        <groupId>com.sun.activation</groupId>
        <artifactId>jakarta.activation</artifactId>
        <version>1.2.1</version>
</dependency>

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I will fix and make a new pull request.

You could just make the change in your branch, commit and push again (which will update the PR here). Alternatively we could merge this, and you follow up with the refactor - that's also fine. New PR is also good. Shout if you get stuck, and thanks for giving this a go.


WinGet Download presents error when it should be a warning.

Brief description of your issue
When downloading a store app, the user is presented with the following if they do not have admin access to the license.
Failed to retrieve Microsoft Store package license
An unexpected error occurred while executing the command:
0x80190193 : Forbidden (403).
Given this is targeting a user or ITPro.  For the user, they can run the app and the license will come down from the store. Therefore not an error.
For the ITPro, they can pass in the --skip-license to avoid this case.
Steps to reproduce
winget download 9WZDNCRFJ3PZ -d c:\temp\deleteme\9WZDNCRFJ3PZ
Expected behavior
To be told the package was successfully installed and not error.
Actual behavior
Failed to retrieve Microsoft Store package license
An unexpected error occurred while executing the command:
0x80190193 : Forbidden (403).
Environment
Windows Package Manager (Preview) v1.9.1792-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26255.5000
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.1792.0

I have the same issue , but it seems not affect to download completed.

You can use "--skip-license" to avoid downloading the license file. It's only necessary if the intended use is for "offline" installation on another host that isn't able to connect to the licensing server.


Revert "Revert "Revert "Eliminate SWIFT_SYNTAX_ALWAYS_SINGLE_THREADED"""

Seems to be failing again https://ci.swift.org/job/oss-swift-incremental-RA-macos-apple-silicon//2207/console
Reverts apple/swift-syntax#1068

@swift-ci Please test


Promise 3.x compatibility

This project can be marked as compatible with react/promise 3.x and 2.x by addressing a depreciation with FulfilledPromise and RejectedPromise classes.
These internal classes were marked as depreciated in 2.8.0 and to be removed in 3.0.0.
They are the only depreciated pieces of code that was removed in 3.0.0.
These changes have been tested with the latest version of opensearch-project/opensearch-php on PHP 8.1

As FutureInterface extends PromiseInterface which has additional methods in 3.x, this should probably be a new major version (supporting only 3.x) so that the signature of FutureInterface for a given version of ringphp does not depend on the installed version of react/promise.
And implementations of FutureInterface need to be updated to implement the new methods as well.

These changes have been tested with the latest version of opensearch-project/opensearch-php on PHP 8.1

have you actually checked that your tests were using react/promise 3.x ? This is weird as the behavior would have been a fatal error normally

Yep you're right it was still 2.x
Broken on 3.x

Closing this PR as I do not have the skill to fix this for 3.x


Monstra rebranded to Flextype!

Dear Friends!
Project Monstra was rebranded to Flextype!
Flextype is Open Source, fast and flexible file-based Content Management System. That's Easy to install, upgrade and use. Flextype provides amazing API's for plugins, themes and core developers! Content in Flextype is just a simple files written with markdown syntax in pages folder. You simply create markdown files in the pages folder and that becomes a page.
FEATURES
Simple
Easy to install, upgrade and use.
No installation needed, just copy files to your server!
Fast
Flextype is realy fast and lightweight!
No database required, flat files only!
Flexible
Flextype provides amazing API for plugins, themes and core developers!
Markdown Syntax
Use your favorite editor to write your content with plain Markdown syntax.
Dynamic Content Types
The flat-file nature of Flextype lets you define custom fields for any of your pages.
Open Source
Flextype is an open-source project licensed under the MIT LICENSE to set the world free!
REQUIREMENTS
PHP 7.1.3 or higher with PHP's Multibyte String module
Apache with Mod Rewrite
INSTALLATION
Using (S)FTP
Download the latest version.
Unzip the contents to a new folder on your local computer, and upload to your webhost using the (S)FTP client of your choice. After you’ve done this, be sure to chmod the following directories (with containing files) to 777, so they are readable and writable by Flextype:

site/

Using Composer
You can easily install Flextype with Composer.
composer create-project flextype/flextype

Also you may need to install node_modules libs for default Simple Theme
cd /flextype/site/themes/simple
npm install
gulp

COMMUNITY
Flextype is open source, community driven project, and maintained by community!

Forum
Github Repository
Gitter

NO LIMITS
With Flextype you can create any project you whant.

Business site
Landing page
Personal site
Portfolio
Product site
Documentation
Personal resume
Blog

CONTRIBUTE
Flextype is an open source project and community contributions are essential to its growing and success. Contributing to the Flextype is easy and you can give as little or as much time as you want.

Help on the Forum.
Develop a new plugin.
Create a new theme.
Find and report issues.
Link back to Flextype.
Donate to keep Flextype free.

LINKS

Site
Forum
Documentation

LICENSE
See LICENSE
Check it!

Please stop SPAM.

@marktopper As I see you follow Monstra Project. I am informing you about big project update - is it a problem ?

@marktopper Good Luck, Mark :)

This is good news, and the author is happy to tell all contributors. I don't mind being mentioned (maybe spam), but not for some people.
I feel lucky to get this information, because there is no update since two years ago. Congratulation @Awilum - Flextype!

 This is wrong way to build community.

Yep plain stupidity. I received like 20 mails related to this project.

 This is wrong way to build community.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

This is spam, plain and simple. I only Starred the repo so I could find it again in the future; I specifically did not Watch it so that I would not receive emails.
I did not give you permission to email me for marketing purposes. In fact, I have not given you permission to email me at all, which is pretty critical now GDPR is in effect.

@Ultrabenosaurus please unfollow project if you don’t want to recive notifications about its BIG INFRASTRUCTURE UPDATES

This is a marketing update. You open by saying it was rebranded, no mention of other changes, and no comparison between the two versions in the entire post at the time I'm writing this. Do not lie about the purpose of the thread. I specifically did not Watch this repo and I was never asked for consent to be contacted for marketing. Any European citizen can report you for breaching GDPR for forced contact. It's not like I signed up to your newsletter or otherwise asked for updates, I only Starred the project in case I ever needed to self-host a CMS.

Do you just delete comments you don't like?
This is a marketing update. You open by saying it was rebranded, no mention of other changes, and no comparison between the two versions in the entire post at the time I'm writing this. Do not lie about the purpose of the thread. I specifically did not Watch this repo and I was never asked for consent to be contacted for marketing. Any European citizen can report you for breaching GDPR for forced contact. It's not like I signed up to your newsletter or otherwise asked for updates, I only Starred the project in case I ever needed to self-host a CMS.
http://web.archive.org/web/20180609152854/https://github.com/monstra-cms/monstra/issues/448

Do you just delete comments you don't like?
This is a marketing update. You open by saying it was rebranded, no mention of other changes, and no comparison between the two versions in the entire post at the time I'm writing this. Do not lie about the purpose of the thread. I specifically did not Watch this repo and I was never asked for consent to be contacted for marketing. Any European citizen can report you for breaching GDPR for forced contact. It's not like I signed up to your newsletter or otherwise asked for updates, I only Starred the project in case I ever needed to self-host a CMS.
http://web.archive.org/web/20180609152854/https://github.com/monstra-cms/monstra/issues/448
http://web.archive.org/web/20180609154107/https://github.com/monstra-cms/monstra/issues/448

wow!
another russian that doesn't get what common sense is.

Deleting this kind of comments shows how you deal with other people ideas

@Shuunen what is your question about ?

Why deleting people critics about your spamming behaviour ?

@Shuunen please read again the issue, you are flooding now, should I keep your comment here ?

Please, forget me and never send such letters to me as well.
If I want to introduce a new project, use Product Hunt for that.

@astappev seems you not read the issues.
If you not agree about getting notifications from GitHub about project update, please unfollow it.
Thanks!

Мне вот одного не понятно, откуда у людей столько желчи? Ну пришло лишних 10 писем и что теперь? Конец света? Пенисы прислали и дети прочитали? Деньги сняли? В чем проблема то??? Никогда спам не получали? Ну нужная информация... почему бы  не получить? Блин, будьте добрее.... развели проблему на пустом месте!!!!!


does netcode.io handle crc32 checking?

I noticed that netcode.io does have a protocol id, wondering if it also does crc based integrity checking, or is this expected to be built at a higher level in the application?

It does even better!
netcode.io uses a cryptographically secure hash, which incorporates the protocol id and the packet contents.
It also securely encrypts the packet contents so they can’t be read.
Finally, it has replay protection so an attacker can’t record a packet and attempt to replay it to break your protocol.
Cheers
Sent from my iPhone

On Mar 24, 2018, at 5:47 PM, Mike Reinstein<EMAIL_ADDRESS>wrote:
I noticed that netcode.io does have a protocol id, wondering if it also does crc based integrity checking, or is this expected to be built at a higher level in the application?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

very nice, thanks 👍


Bintray will be shut down, any plans on moving to Maven Central?

Bintray will be shut down soon, and Github Code Quality action already reports https://dl.bintray.com/gantsign/maven as well as https://jcenter.bintray.com/ as a soon-to-be-deprecated repository. So I was wondering if there are any plans to deploy the library to Maven Central and can we expect a new release in the nearest future?

The problem I have is org.jetbrains.dokka:dokka-fatjar, it's not available on Maven Central. I partially convert it to a skinny jar so it works better with Maven (https://github.com/gantsign/kotlin-maven-plugin-tools/tree/master/dokka-embeddable). But there's still various dependencies mixed in under various licenses (in some cases I've had trouble identifying licenses - JetBrains appears to have forked some of the dependencies). To deploy to Maven Central I have to declare the licence for each artifact, which I can't accurately do for dokka-embeddable.
There are a couple of solutions to this:

The easiest one is to move the artifact from BinTray to GitHub. I expect this will be the short term solution.
I think the latest Dokka version has a skinny JAR I can use. But, Dokka has undergone significant refactoring and it's going to take a significant effort for this project to migrate to the new version (These APIs were never really intended for use outside Dokka). Frankly, I haven't had time. Assuming there's a skinny jar I can use, and assuming Dokka is deployed to Maven Central, I should be able to deploy this to Maven Central, it just may be a while until I find the time.

Thanks for reply and for explanation! Your reasons are understandable. Moving to github packages seems like a reasonable solution  that at least won't break existing pipelines in dependent projects. I might try to look into helping with API migration myself, but I as well can't be sure about the free time.

@petertrr as of version 0.9.26 new releases are now deployed to GitHub Packages, note that authentication is required to download from GitHub Packages (any valid GitHub token will do) - details in the README.

Thanks @freemanjp! I've switched to the new version in our project, it works good. We use kotlin-maven-plugin-tools only in release maven profile, so I only needed to add authentication in our CI job, and using GITHUB_TOKEN is fairly straightforward.

@freemanjp  : org.jetbrains.dokka:dokka-fatjar seems now available on Maven Central: https://repo1.maven.org/maven2/org/jetbrains/dokka/dokka-fatjar/


Use golang:1.12-alpine3.9 for buildtool-alpine

I remember last attempt to use newer golang version in buildtool caused some crashes in on-prem software.
@vasily-chertkov knows details.

For now NGP team (ATC team too - for PE and ATC-API projects) is using buildtool-alpine:latest based on golang:1.11.0-alpine3.8 w/o any issues.
Upgraded version from the PR has tag buildtool-alpine-3.9:1.12 instead buildtool-alpine:latest,
i.e. any project must set buildtool version explicitly (not latest).

@dkamenda Could you please merge the PR and build the image?

@dkamenda Could you please merge the PR and build the image?

Unfortunately I could not push the image: requested access to the resource is denied


Suggestion : New Port? - In regards to previously closed 409

That one was closed, but I'd like to continue the discussion. Just on the off chance my setup is wrong, or maybe it's a bug?
I have a new reactor running with only 1 port. I have an ender io item conduit set to in/out, and it is not pulling the cyanite out. I get what you are saying when there are two ports, but in the case of having only 1, it still isn't functioning correctly. It defeats the purpose of using conduits if it doesn't work both ways as you are indicating. If I have to use buses to get it to push/pull items in and out, I may as well just use 2 ports. Thoughts?

I'm not entirely clear on what you mean. When you say "it is not pulling the cyanite out", do you mean that the EnderIO item conduit does not pull the cyanite out of the access port? That sounds like a bug with EnderIO.

Sorry it took a bit to get back. The only way 1 port works is to constant switch it between import, and export. Which if I'm doing that, I may as well use 2 ports. The ender io cables work if I switch it to export, but a lone port isn't enough to operate both ways, unless there is some way to toggle it between the two without opening the interface? Even with applied energistics, it is the same way.
In closing, the ports pull out, but only if it's set to export, it doesn't operate bidirectionally.
Any guesses?

Ah, now I see. Yes, the inventory code only permits either the inlet or outlet inventory slots to be exposed at once.
I'll think about adding a bidirectional mode in 0.5. Until then, you'll have to work around it by using two access ports.

Fair enough. Where is version 0.5 expected, and will it be for 1.7.10? I know we're on 0.4.1 currently.

0.5 will be out "when it's done" and is still in fairly heavy development. It will be for 1.7.10.


pcl: 1.8.1 -> 1.9.1

https://github.com/PointCloudLibrary/pcl/releases/tag/pcl-1.9.1
Closes #51573

@GrahamcOfBorg build pcl

fix hash mismatch

Please fix this, not able to at this time.

Fixed in master, thanks


Update linear stratification example

This PR makes examples/linear_stratification_constant_fluxes.jl identical to examples/three_layer_constant_fluxes.jl except for the initial condition and adds mode = "c" as a keyword argument to all of the NetCDFOutputWriter constructor calls (thanks Ali for this solution!) in both scripts.

Cool! If many of the lines to these scripts are identical, should we figure out how to share the code rather than copy/pasting?

Yeah I agree with @glwagner that it would be nice to add a command line argument to the script to change the stratification between linear, three-layer, and three-layer cubic (maybe there would be too many command line arguments though). But I'm also happy to merge this since it updates and improves existing scripts/examples.

I think the keyword arguments and their defaults are different enough that it probably makes sense to leave the two scripts separate for now, so I'll go ahead and merge, but we can always change in the future!


CI -> add pan.dev prev and release PRs

Description
Add to the existing CI following features:

PR CI:

create a preview PR to pan.dev if any documentation get's updated
close that preview PR when that PR get's closed or merged (new hook?)

Release CI:

create a PR to pan.dev when:

a release is made
there are changes to documentation

The changes part can be probably handled by Peter Evans' PR action.

for the moment there are problems with PR creation from forks in side an ORG, reported here

PR pending


Handle case where there is no user .yamlrc.yml file present

When adding support for .yarnrc files in a previous commit a use case was missed.
This duplicates the logic of .npmrc where the user profile .yarnrc file is initialized empty if not present or if present the actual default hard-coded feed registration is removed to ensure compliance with Microsoft Security (SFI) requirements

Not sure why GH decided to close the PR when I accidentally pushed the code to a repo-branch :(
New PR: #56


SAK-31174

Resolved the merge conflicts with merging to 11.x

This code is already in trunk with star imports I'm just doing the merge to 11.x as a pull request because there were merge conflicts that I had to manually resolve.
I know your point about star imports, personally I don't have a problem with them. There's both sides of the discussion http://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad
But I think it would be good for Sakai to have a style guide so that people don't fight over this.

Ah, no worries. Star imports (just like tabs and hanging braces) are one of my many development pet peeves. :)
LGTM!


Feature/indicators trend line

Trend line for indicators in esp scenario show page

[x] Add provider for Indicators trend
[x] Render all indicator trendlines
[x] Filter by location

Hi Álvaro there seem to be some conflicts that will prevent the merge, can you check it, please?

Nice, I really like the trendlines. =) Good job. Ed can you check the code bits and merge if you're happy with it? tks!


Expose docs for classes under Microsoft.Quantum.Simulation.QCTraceSimulatorRuntime

Currently there are only three QCTraceSimulatorRuntime classes documented on the dotnet/api pages. However, there many more public classes not documented (https://github.com/microsoft/qsharp-runtime/tree/main/src/Simulation/QCTraceSimulator).
The QCTraceSimulatorRuntime is specifically called out in the _filter.xml file, which excludes namespaces and classes from publishing.

Should more, or all, of the QCTraceSimulatorRuntime classes be exposed?
Should the other namespaces in the _filter.xml be evaluated as well?

(From Bettina) The classes in that namespace are largely not intended to be public APIs, but are made public due to technical requirements imposed by assembly boundaries. From that perspective, we should likely not expose everything, but make sure only those public APIs that are directly user-facing should be exposed.

Then I think we can close this, right?
@Bradben


Add to queue command

Thanks for this extension! I enjoy using it and would like to believe it has made me a bit more productive 😆
SUMMARY
I may just have musical ADHD, but in the midst of playing a playlist, I get the urge for a specific track. With the spotify desktop I usually satisfy this craving by adding the track to my queue so it plays next while preserving my playlist playback:

With your extension, my ADHD kicks in, and I search for a song using the extension quick search and click enter when it shows up in the Recommendations view:

While this is great, it does switch the playlist as well. Would be great if I could instead hit another shortcut and add the song to the active queue instead of switch the entire playlist. Possible 🥺 ?
ISSUE TYPE

Feature Request

ADDITIONAL INFORMATION
🙇

This is a great idea.   We can look into it.    No promises on timing, but I agree that this feature would be very useful.  Adding to queue is one of my favorite ways to keep my music going too.


compatibility changes to enable python 3.10 and updated package versions

This issue is dependent on PR #112 being merged in and available to ALL team members. After this issue is resolved, the old codebase written for Python 3.7 and older packages won't work with the Python 3.10 environment. We'll need all team members to update their local systems before codebase development can proceed.
Codebase

Status
File
Line number
Error or Warning

done
Designs
389
FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.

done
Designs
390
FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.

done
Designs
391
FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.

done
Designs
404
FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.

done
Designs
406
FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.

done
Investments
145
FutureWarning: Using the level keyword in DataFrame and Series aggregations is deprecated and will be removed in a future version. Use groupby instead. df.sum(level=1) should use df.groupby(level=1).sum().

done
Investments
161
FutureWarning: Using the level keyword in DataFrame and Series aggregations is deprecated and will be removed in a future version. Use groupby instead. df.sum(level=1) should use df.groupby(level=1).sum().

done
Investments
211
FutureWarning: Using the level keyword in DataFrame and Series aggregations is deprecated and will be removed in a future version. Use groupby instead. df.sum(level=1) should use df.groupby(level=1).sum().

done
Investments
232
C:\Users\rhanes\GitHub\tyche\src\tyche\Investments.py:232: FutureWarning: Using the level keyword in DataFrame and Series aggregations is deprecated and will be removed in a future version. Use groupby instead. df.sum(level=1) should use df.groupby(level=1).sum().

summary = metrics.set_index(

done
Evaluator
121
FutureWarning: The default value of numeric_only in DataFrameGroupBy.mean is deprecated. In a future version, numeric_only will default to False. Either specify numeric_only or select only columns which should be valid for the function.      ).aggregate(

done
Evaluator
121
FutureWarning: Dropping invalid columns in DataFrameGroupBy.agg is deprecated. In a future version, a TypeError will be raised. Before calling .agg, select only columns which should be valid for the function.    ).aggregate( See https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.3.0.html#deprecated-dropping-nuisance-columns-in-dataframe-reductions-and-dataframegroupby-operations

done
EpsilonConstraints
1044
FutureWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning.     y = pd.Series(None, name="Value",

Analysis Notebooks
All are checked and warnings resolved; see individual commits for details.

There are additional warnings to resolve before closing this issue - see commit 41b522f

The utility_pv analysis notebook, block 14, has the current VisibleDeprecationWarning:

The same call (designs.evaluate_scenario()) in other notebooks does not throw this warning. May be because this decision context has no scenarios defined.


move disklru to libkb

unfortunately leveldb is not separable from libkb and will be using disk_lru for the dbcleaner state

closing for now, https://github.com/keybase/client/pull/16033 did not end up using this


Inherit from ABC to make sure abstractmethod takes effect; Modiy comment

What does this PR do?

We have to inherit from ABC in order to make abstractmethod to take effect. Make Accelerator inherit from ABC
Update docstring to better describe the function

The failed test case means that ABC takes effect.

Thank you for the quick fix @chunyang-wen <3


Bug fix function in get wrong result when input const column

Proposed changes
fix function in get wrong result when input const column
mysql [test]>SELECT  (abs(1)=1) IN (null) FROM t0;
+------------------------+
| (abs(1) = 1) IN (NULL) |
+------------------------+
|                   NULL |
|                      1 |
|                      1 |
+------------------------+
3 rows in set (0.12 sec)

Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


0.8 breaking changes are a little bit obscure

I am using fluent-templates in several projects with 400+ keys overall and tried to upgrade to 0.8.0.
The issues are related to the #32 changes which add a Result return to all lookup functions.
I think that there should definitely be a function to query the existence of a key, but the change works against the practical usage.
Or in other words, I have not needed such a return value once.
This is also easily explained, why do I need a default handler for a fallback handler?
I don't want to hardcode an additional default value for every case.
So I wrote a wrapper that works but I realized that it doesn't work for the tera/rocket handler because the static_loader can't be referenced easily. After two hours I gave up because I didn't want to write complicated code that does something that already worked perfectly.
With the new behavior the application panices every time a key can't be found.
This is great if you write a new template and use placeholders.
I would like to change this again but the question is should the old behavior be restored and the result functions added under a new name or vice versa?

Thank you for your issue! I would lean towards adding a try_ prefix to the new fn names, and have those return Results.


Better README

Added a basic example and options reference.

See https://github.com/izimobil/dpeges/tree/patch-2 for a preview.


Upgrade aes-gcm to 0.10.

Merged in https://github.com/SergioBenitez/cookie-rs/commit/c51aeec6b9a151754827fae14d91faedfe0b6a42. Thank you!


actions/cache : permissions error for /github/home/.cache/pip : parent directory is not owned or is not writable by the current user

Hi,
I am trying to use cache pip dependencies using the python pip example. However I receive the following the permissions error:
WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.

Can anyone help?
On further investigation it seems to work if I do not run the job in a container. If I run the job in a container I get the error message given above. Is there a way to change the working directory of a container and configure the pip cache or a virtual environment there?
name: Test

on:
  pull_request:
    types: [opened, synchronize, reopened]
    paths:
      - pyproject.toml
      - poetry.lock
      - "src/**"
      - "tests/**"
      - ".github/workflows/pytest.yml"
  push:
    branches:
      - master
      - feat/*
    paths:
      - pyproject.toml
      - poetry.lock
      - "src/**"
      - "tests/**"
      - Dockerfile
      - ".github/workflows/pytest.yml"

jobs:
  test_job:
    runs-on: ubuntu-latest
    container: python:3.10

    steps:
      - name: Check out repository
        uses: actions/checkout@v3

      - name: Set up python
        id: setup-python
        uses: actions/setup-python@v4
        with:
          python-version: "3.10"

      - name: Cache dependencies
        uses: actions/cache@v2
        with:
          path: ~/.cache/pip
          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
          restore-keys: |
            ${{ runner.os }}-pip-

      - name: Virtual environment
        id: cache
        run: |
          python -m venv ./.venv && . ./.venv/bin/activate
          python -m pip install --upgrade pip
          python -m pip install -r requirements.txt
          if: steps.cache-venv.outputs.cache-hit != 'true'

Looks related to #629?


"export minimal" for resource variables

Issue description:
A while back I posted a topic on the clutter that could be exporting an array of Resources...
When editing a given resource in the inspector there is a "Resource" category (Local to Scene, Path...) that can (and does) cause clutter. It would be great if we could have a way to create minimal exports in order to hide parts of the data shown in the inspector.
Right now _get_property_list() allows to edit somethings but can only add to the list instead of removing from the pre-existing one.

we could have a _get_property_list(dictionary) that would have a pre filled dictionary allowing to remove unwanted entries.

My concern is that _get_property_list might be used for something else other then inspector export... so messing with it (removing entries) would make something in the game break. If that is the case we could have an inspector dedicated virtual functions

_get_inspector_property_list(dictionary) this would make it possible to remove entries without breaking other parts of the engine.

Another practical example would be:
What if I need to export an automatically managed array, the array size depends for example on the number of tiles in a TileSet so array "size" property should be hidden from the inspector in order to prevent manual changes... or the same idea but for dictionaries. I don't know what would be the best way to make this work but it would be open to discussion to get to the best implementation possible.

In 3.1 this is already better since categories are closed by default:

In 3.1 this is already better since categories are closed by default:

When inside of an array custom resources don't have a collapsable resource category (at least in the version I'm using... which is d16ce4a)

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Assert because MGLAccountManager.setAccessToken is ignored by Directions class

This assert occurs when you specify the access token via MGLAccountManager.setAccessToken, but not in the plist:
"A Mapbox access token is required. Go to https://www.mapbox.com/studio/account/tokens/. In Info.plist, set the MGLMapboxAccessToken key to your access token, or use the Directions(accessToken:host:) initializer."
The code specified access token appears to be ignored here:
/**
 The shared directions object.

 To use this object, a Mapbox [access token](https://www.mapbox.com/help/define-access-token/) should be specified in the `MGLMapboxAccessToken` key in the main application bundle’s Info.plist.
 */
@objc(sharedDirections)
open static let shared = Directions(accessToken: nil)

This library doesn’t depend on the map SDK, so it has no access to MGLAccountManager. As the assertion message states, you can either set the access token in your Info.plist or by creating a custom Directions object using Directions(accessToken:host:). You can only use Directions.shared if you put the access token in your Info.plist.


[BUG]

I used the upload-a-photo.py exmaple (but with my infos) but i get this error mesage and i have no idea what it means or how to fix it.
Here's the error message :
[IG] not found cookie/cookie_file >> login as default
ClientError URLError <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1056)> (Code: 0, Response: )
And here's my code (with my info hashtagged) :
from instapy_cli import client
username = '#########'
password = '########'
image = 'downloads/what.png'
text = 'My profile pic' + '\r\n' + 'You can use hashtags! #hash #tag #now'
with client(username, password) as cli:
cli.upload(image, text)
I'm with python 3.7 on macOS with the lastest version on instapy (downloaded this morning with pip install)

I have the same issue! Any idea on how to fix this?

I have the same issue!

I also have this issue. same version and OS as well as OP. not sure what is causing it at this moment.

this bug is an issue with instagram_private_api library: https://github.com/ping/instagram_private_api/issues/157
The Fix is to add the following at the top of the code you are running:
import ssl
ssl._create_default_https_context = ssl._create_unverified_context

not working again


Question: How to change currently viewed month range for DateRangePicker?

Like many other users, I am trying to add a Year dropdown to my DateRangePicker. However, I am not sure which prop I can set to update the currently viewed dates.
In the example below, I want to use the dropdown I created to update the month that is being shown to February 2018.

Appreciate your help in advance!

@lainermeister I suppose renderMonthElement prop is what you need.
        <DayPickerRangeController
          ...
          renderMonthElement={({ month, onMonthSelect, onYearSelect }) => (
            // your custom caption
          )}
        />

https://airbnb.io/react-dates/?path=/story/daypickersingledatecontroller--single-month-custom-caption

@mmarkelov Thanks for getting back to me. I used renderMonthElement to change the tops of the calendars to display the drop down via custom captions. However, I’m not sure how I can change the actual calendar view’s month?

@lainermeister sorry I just can't understand what exactly do you want. :( Do you want to change end date to February  2018 in your example?

@mmarkelov Yes, I want the actual calendar dates in the two calendars to change to correspond to Feb 2018 and Mar 2018 when I select 2018 in the dropdown.

@lainermeister may be this help?

That's awesome, thank you so much!


Add Concourse chart repo

🌿 Added helm chart repo for Concourse CI.

Hi @mattfarina,
I am going to close this PR, because I've created a new PR for this.
Here is the link of the new PR: https://github.com/helm/hub/pull/174