Move "update" function from flutter component to client

In line with Apollo, we should add an update function as well as a refetchQueries array within the MutationOptions of QueryManager's mutate function,

update logic exists but needs to be moved from graphql_flutter
We should also add refetchQueries - but only the part they don't want to deprecate
Right now all "safe" queries are re-resolved from the cache on mutation, so there's that 😅

@mainawycliffe Do you have any guidance on this?

@smkhalsa At first I didn't understand what you meant, but now I see the difference between our own implementation and React Apollo implementation. Our Update method is outside mutation options, which makes it only accessible to users using graphql_flutter and not regular graphql. I think it is possible to move the update the method, to allow users of graphql to use the option too. @micimize what do you think?

Thanks @mainawycliffe. My use case requires that I initiate a mutation from my store in response to state changes as opposed to something directly initiated by a user in the UI. As such, I'm using the graphql library directly, not graphql_flutter.

Yeah we should move the callback logic involved into graphql, and just pass through the current update callback. This applies to pretty much all logic - graphql_flutter shouldn't really have much logic in it

@mainawycliffe it sounds like this is a change we want to make. Any further thoughts?

@smkhalsa yea, this is a change we should make, the question is the best approach to achieve this. It will definitely be a breaking change, but if we move the update call back alone, I think we could introduce some API inconsistencies, the best approach, I believe, is to move all the callbacks to MutationsOptions - onError, onComplete, update which is more consistent with Apollo React.

@mainawycliffe yeah that's what I think as well - all functionality should be in graphql and merely exposed in an idiomatic flutter way in graphql_flutter

I will work on this and bundle it with the #435

@mainawycliffe any update on this?

@smkhalsa I have moved the update and other callbacks up to the MutationOptions am just trying to figure the best way to call the callbacks when calling the mutate method directly from the client. That's the only section and updating documentation and adding some tests if any are required.

@smkhalsa can you test the PR (#435) and see if it works as expected

@mainawycliffe I added a few initial comments to the PR.

@smkhalsa Sorry, I had a week packed with conferences I will look into those changes when I am back on Monday.

This issue was resolved by #435


Parse tampermonkey userscript

We have to parse tampermonkey scripts.

https://github.com/cagataycali/parse-tampermonkey-script


RxJava 3 support

It would be great to have support to RxJava3

At the very least, I don't want to do any conversion until a 3.0 final is released. I do not want to maintain two versions.

And what about a SNAPSHOT? To make it easier to test RxJava3 meanwhile the API is not freezed?

A snapshot comes with the same problem because it still requires the source
to be maintained twice. For example, if we had done this and the ViewPager2
stuff landed last week how would it get migrated to 3? I'm not ready to
maintain two versions until 3.0 is much closer to release, and even then
I'm not excited about the prospect as the value proposition of 3.0 is
extremely low to the point where it feels like it's actually harming the Rx
ecosystem.
On Tue, Oct 29, 2019 at 7:15 AM Brais Gabín<EMAIL_ADDRESS>wrote:

And what about a SNAPSHOT? To make it easier to test RxJava3 meanwhile the
API is not freezed?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/RxBinding/issues/531?email_source=notifications&email_token=AAAQIEIBUKTLAOWJHQZZUQDQRALM5A5CNFSM4JFSJRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQDUUA#issuecomment-547371600,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAQIEMDKHF4W53YZUT5WRDQRALM5ANCNFSM4JFSJRLQ
.

RxJava 3 has been released. :)

Any news here?
The binding-library is great and we use excessively. During the migration to RxJava3 I figured out, that it does not support the RxJava3 dependencies, or am I wrong?
For example a call to the following still returns an io.reactivex.Observable instead of io.reactivex.rxjava3.core.Observable:
onReadingChangedObservable = RxTextView.textChanges(myEditText)
                .subscribeOn(io.reactivex.rxjava3.android.schedulers.AndroidSchedulers.mainThread())

So it's not compatible with the rest of my RxJava3-code and stopped me from migration to RxJava3 for now...

You can use https://github.com/akarnokd/RxJavaBridge meanwhile (if it's worth it the intermediate step)


Firestore rules??? And storage rules??? Please share

Hi, @Rahulbinod555 , how are you?
Please, see this issue: #6
Certainly can help you.
Good luck, and if I can help you, I'm available.


Timeout settings

Created timeout settings to Seamless in "Pharo/Settings/Tools/Seamless"

ping

Hi Alex.
I made tests pass finally :))
According to PR I would like to not make the timeout a global variable. The
setting can define the default value but it should be a network
configuration, the instance variable of SeamlessNetworrk.
I will try to propose it tomorrow.
сб, 11 апр. 2020 г. в 20:22, oliveiraallex<EMAIL_ADDRESS>
ping
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/pharo-ide/Seamless/pull/34#issuecomment-612495543,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6FVIAN6QDYKLE7NAK4VYDRMC7OTANCNFSM4MCK4Q7Q
.

see #39


GenerateTypes() not working without calling GenerateFile() first

According to #514, I should be able to use GenerateTypes() instead of GenerateFile(). I have noticed, using version ~9.10.42~ 9.10.45, that the first doesn't work without calling the latter. In that case, the list of artifacts is empty.
This is the piece of code I am using. It works whenever I uncomment generator.GenerateFile().
// Generate class from schema file.
var schema = await JsonSchema4.FromFileAsync(options.Schema);

var settings = new CSharpGeneratorSettings
{
    ArrayType = "System.Collections.Generic.IEnumerable",
    ClassStyle = CSharpClassStyle.Poco,
    Namespace = options.Namespace,
    TypeNameGenerator = new TypeNameGenerator(),
    GenerateJsonMethods = !options.Cleanup
};

var generator = new CSharpGenerator(schema, settings);

// generator.GenerateFile();
var types = generator.GenerateTypes();

// Generate code for each artifact. However, types.Artifacts is empty if GenerateFile isn't invoked first.
foreach (var artifact in types.Artifacts)
{
    // Something with artifact.Code.
}

It should be possible... maybe we need to improve the design or document it better.

So, I discovered this issue while looking into another issue I'm having. It turns out if you write the code using JsonSchema4, then you have this issue. If, instead, you use a SwaggerDocument, the code generation works properly for GenerateTypes(), while GenerateFile() fails with a cast exception. There is an issue with the signature of the constructor for CSharpGenerator in that it accepts an object type rather than something a little more specific.


Fix to mttr

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

184 of 201 (91.54%)  changed or added relevant lines in 25 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.2%) to 80.646%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/DevOpsMetrics.Core/DataAccess/ChangeFailureRateDA.cs
24
25
96.0%

src/DevOpsMetrics.Core/DataAccess/DeploymentFrequencyDA.cs
15
16
93.75%

src/DevOpsMetrics.Core/DataAccess/MeanTimeToRestoreDA.cs
23
24
95.83%

src/DevOpsMetrics.Function/Processing.cs
8
9
88.89%

src/DevOpsMetrics.Service/Controllers/ChangeFailureRateController.cs
1
2
50.0%

src/DevOpsMetrics.Core/DataAccess/LeadTimeForChangesDA.cs
36
41
87.8%

src/DevOpsMetrics.Core/DataAccess/PullRequestsDA.cs
3
10
30.0%

Files with Coverage Reduction
New Missed Lines
%

src/DevOpsMetrics.Core/DataAccess/TableStorage/TableStorageCommonDA.cs
3
87.93%

src/DevOpsMetrics.Core/Models/Common/Build.cs
3
90.77%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
2566

Relevant Lines:
3137

💛  - Coveralls


xSPVisioServiceApp does not work on PowerShell 4

xSPVisioServiceApp will not work on machines that have PowerShell 4 (only PowerShell 5, using the PsDscRunAsCredential attribute) as it does not have an InstallAccount property in its schema. This should be added to allow the backwards compatibility to work correctly.

I'll look a this tonight

Hey. Can you also add the $Ensure please?
[Required, Description("Present ensures the URL is set for this zone on this web app, Absent ensures it is removed"), ValueMap{"Present","Absent"}, Values{"Present","Absent"}] string Ensure;
[Write, Description("POWERSHELL 4 ONLY: The account to run this resource as, use PsDscRunAsAccount if using PowerShell 5"), EmbeddedInstance("MSFT_Credential")] String InstallAccount;

@caadam @camiloborges Leave the ensure parameter, I'm doing that in a big run through for issue #148 - just get the install account in as its own change for this one thanks

Changes made @BrianFarnhill , time for a good'ol fashion code review.

This one is in #227 just pending review

Merged in to dev, closing this issue


chore(http): do not require auth on /health endpoint

This makes it easier to determine the health of the server using http.
closes #822

Everything looks good to me, thank you!
Could you just rebase on master please?

 Reopened it.

Can you add the meilisearch-http label @Kerollmops? Plus, it involves changes in the docs if i'm not wrong. @bidoubiwa?


Unable to specify stacks that don't have app- prefix

E.g. govuk-content-schemas:
$govuk-docker startup
Unknown stack: app.

Available stacks:

lite

$govuk-docker startup lite

Unknown stack: app-lite.

Available stacks:

lite

Have tried passing --stack=lite which used to work but has now been removed from govuk-docker.

This is intentional, albeit slightly confusing. If the service doesn't have an app- prefixed stack, then it can't be run using the startup command. Instead you would use the normal run command.
This is to make a distinction between apps where "starting up" is meaningful (such as a web application) and apps where this makes less sense (such as the content schemas).
The error message could definitely be improved though...

Cool, thanks for explaining 👍 perhaps we can check if an app has no app- prefixed stacks, and throw a more helpful error message if the dev tries running startup.


How to zip multiple file and directory into one?

I'm trying to zip some files and directories into a single zip file.
I don't want to zip them inside another directory cause I need them to be at the root of the zip.
[newArchive updateEntries:
         [newArchive.entries arrayByAddingObject:
          [ZZArchiveEntry archiveEntryWithFileName:fileName
                                          compress:NO
                                         dataBlock:^(NSError** error)
           {
               return data;
           }]]
                            error:&error];

Tried this but this only take NSData but I have no clue how to get NSData for entire directory.

I'm trying to zip the 4 files "_rels", "[Content_Types]", "deoProps", "word" as one zip file which they will be the root.

Here's a rough outline of what you want:

Create an NSMutableArray<ZZArchiveEntry>.
Add a ZZArchiveEntry for each file you want in there. The filename should include any subdirectory name.
Call updateEntries: with this array.

Most unzip utilities are OK with a zip file that doesn't have directory entries as I've suggested. If you need a directory entry, insert the directory entry before you insert the file entries.
You can look at this for guidance for a suitable recursive routine although it talks about unzipping instead.


Error fetching analysis_by_component

{
  "errorMessage": "Response payload size exceeded maximum allowed payload size (6291556 bytes).",
  "errorType": "Function.ResponseSizeTooLarge"
}

@mainawycliffe - How do we reproduce this? Is this not perhaps a paging issue of trying to return all rows?

I can't seem to be able to reproduce this again, happened a couple of times, will keep an eye on it, may be add a limit on rows for the components.

@moshloop This seems more like an error rather than a response with large number of rows. I don't think we'd have that many results for analysis_by_component.
Azure: 10
AWS: 0


No local caching of files/chunks on fuse mount

Describe the bug
When using "./weed mount", the system does not seem to use local caching of the files/chunks only the metadata is cached. Meaning no matter how many times I load/access the same file back-to-back it takes the same time as opposed to only having to pull it from the network once, and after that having fast access from some local on disk cache.
This happens with all files I have tried (the range was from 1kb all the way to 10GB), so I do not think it is only a file size issue.
Looking at the cacheDir, it looks like only metadata is being downloaded or kept as even when accessing several files over 1GB the files in cacheDir are only in the kilobytes.
System Setup

List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".
OS version: Redhat Enterprise Linux 7.9
output of weed version: version 30GB 3.29 1ffb1e696e1f651c6294fc34c86b9abb6db1985d linux amd64
if using filer, show the content of filer.toml:  using Filer, but did not make a "filer.toml"
security.toml: exactly as in wiki, certs made with certstrap
'3 masters set up with: ./weed server -dir=/seaweedFS/ -master.defaultReplication=010 -filer -master.peers=s2.seaweed.swf.local:9333,s3.seaweed.swf.local:9333 -ip.bind=<IP_ADDRESS> -ip=s1.seaweed.swf.local -rack=rack01 -dataCenter=dc1 -master.volumePreallocate &
one test mount set up with:
sudo  ./weed  mount -filer=s1.seaweed.swf.local:8888,s2.seaweed.swf.local:8888,s3.seaweed.swf.local:8888 -dir=/seaweed-vol/ -filer.path=/  -cacheCapacityMB=25000 -cacheDir=/var/tmp &

Expected behavior
Remote file that have been recently accessed should be cached for faster access, and subsequent access attempts should be near to the speed of local disk access.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I am testing seaweedfs to see if it can be a good replacement for NFS but with added redundancy and security.
looking at my data

I can not reproduce this.
If possible, can you reproduce it with a docker compose file similar to this? https://github.com/seaweedfs/seaweedfs/blob/master/docker/compose/local-mount-compose.yml

Hi, Chris! I'm facing the same issue. Here are the steps to reproduce it:

git clone https://github.com/seaweedfs/seaweedfs
cd ./seaweedfs/docker/compose/
sed 's/seaweedfs:local/seaweedfs:3.42/g' local-mount-compose.yml > local-mount-compose-with-corrected-repo-tag.yml #:local tag doesn't exist. Replacing it with :3.42
sed 's/-cacheDir/-cacheCapacityMB=10000\ -cacheDir/g' local-mount-compose-with-corrected-repo-tag.yml > local-mount-compose-with-corrected-repo-tag-and-cache-capacity-set.yml # Adding -cacheCapacityMB
docker-compose -f local-mount-compose-with-corrected-repo-tag-and-cache-capacity-set.yml up -d
docker exec -it compose_mount_1_1 sh
ifconfig eth0 | grep 'RX bytes' # RX = 0 MiB
cd t1
dd if=/dev/urandom of=./10MB.bin bs=10M count=1
ifconfig eth0 | grep 'RX bytes' # RX = 0 MiB
cat ./10MB.bin > /dev/null
ifconfig eth0 | grep 'RX bytes' # RX = 10 MiB
cat ./10MB.bin > /dev/null
ifconfig eth0 | grep 'RX bytes' # RX = 20 MiB
cat ./10MB.bin > /dev/null
ifconfig eth0 | grep 'RX bytes' # RX = 30 MiB

Result: the file isn't cached on the disk.

@User-26 did you find a solution for this? I'm noticing the same issue with cache not being used

If Fuse cache is working for @chrislusf we should be able to figure this out. If fuse cache is working for you (anybody who sees this), what commands are you using for setup and mounting?

Hi, I would like to resurect the discussion.
Caching does not work for me either. I pinpoint it to         wfs.ReleaseHandle(FileHandleId(in.Fh)) at https://github.com/seaweedfs/seaweedfs/blob/ff3d46637d7adaf364f6384c3d631d16c9741363/weed/mount/weedfs_file_io.go#L99
I observed it in the following scenario: moun wfs via fuse, read a file, observe the
volume servers hit with request, do the read again. The expectation that everything will be read from the cache, but it is easy to see that volume servers are hit again.
The reason is that ReleaseHandle, deletes the mapping between inodes and filehandles, and filehandles themselves keep the maps of cachers. If the map is destroyed, the cacher had to be recreated again and thus chunks are redownloaded.
There are other strange things:

only 1st chunk is cached in a multi chunked files
and even that 1st chunk get unmapped on the 2nd read, i.e. cache works only once.

Q: Why we cache only 1st chunk? There is a comment about it at
https://github.com/seaweedfs/seaweedfs/blob/ff3d46637d7adaf364f6384c3d631d16c9741363/weed/filer/reader_pattern.go#L14
Yet one more comment. Generally, speaking I would think that kernel should just reread file from the OS cache directly without talking to wfs (at least on short time intervals) but it also does not happen.

Added a fix f23015ac5ba04f3b5b9f2efbadf4919f76066e79
Please help to see whether it is working for you.

I think we can close this issue, PR #6009, seem to fix all raised concerns.


code for finding hyperparameters

where is the file for finding the hyperparameters that you explained in Readme?

You can find it in 'hyperparameters_tuning.py' file.


BUG: special: some fixes for lambertw

This:

Cleans up the code for lambertw to make it more readable. In particular, special cases are moved to the beginning of the function and the branch cut logic for the initial guess is simplified
Fixes the lambertw mpmath tests, which were not actually checking the majority of the test points (nan_ok = True strikes again).
Prevents overflow in the Halley iterations by being careful about exponentials

one failing doc example

Ok, went ahead and did the initial guess for W(z, 0) correctly (implemented Pade approximation, series expansion around branch point). There's _precompute/lambertw.py for exploring the decision boundaries between the methods. Also here's a gist exploring one of the old high-error areas:
https://gist.github.com/person142/7d585322ec919689b2be439e955b48e7
W(z, -1) and W(z, 1) TBD.

And just to be clear, by "TBD" I mean not in this PR (which seems large enough already).

Thanks, read it through and looked ok (indeed I thought this was in WIP stage).


Support --fix Flag for  "slate-tools lint"

Problem
Cannot pass --fix flags to eslint through ./node_modules/.bin/slate-tools lint --fix or in the starter-theme proper doing npm run lint --fix to enable auto-fixing of simple errors.
Replication steps

Make some JS lint errors in your code (spaces between brackets, etc)
run slate-tools lint --fix
Notice it says errors are fixable with --fix but passing the flag is ignored.

More Information
Being able to fix minor alignment errors through the script instead of by hand would greatly speed development and is already a built in feature of ES Lint, it just needs mapping through the slate-tools commands.
Sample Output:
NOTE: Project is a vanilla starter-theme : https://github.com/Shopify/starter-theme
user$ ./node_modules/.bin/slate-tools lint --fix

shopify-theme/src/assets/scripts/templates/product.js
   8:2   error  Mixed spaces and tabs                              no-mixed-spaces-and-tabs
   8:4   error  Unexpected tab character                           no-tabs
   9:2   error  Unexpected tab character                           no-tabs
   9:3   error  Expected indentation of 4 spaces but found 2 tabs  indent-legacy
  10:2   error  Unexpected tab character                           no-tabs
  10:3   error  Expected indentation of 4 spaces but found 2 tabs  indent-legacy
  10:19  error  Missing trailing comma                             comma-dangle
  11:2   error  Unexpected tab character                           no-tabs
  11:2   error  Expected indentation of 2 spaces but found 1 tab   indent-legacy

✖ 279 problems (279 errors, 0 warnings)
  190 errors, 0 warnings potentially fixable with the --fix option.

Hi!
You need to run slate-tools format to fix the errors. More informations here


Running "run.sh" takes too long, logs show multiple timeouts

Run run.sh and stuck at "infer network start!!!", log shows "Waiting web service... from <IP_ADDRESS>" and "qemu-system-mips: terminating on signal 2 from pid 105098 (timeout)"
I have referenced other issues and fail to solve the problem.
Thank you in advance for your help.

I have the same problem, have you found a solution?


can this firmware be used for win10

Hello
I want to use a USBtoI2C dongle on win10, can this firmware support to work on Win10 OS?
Thanks.

This was my first-ever C build.  the learning curve on this one was nuts (mostly environment variable issues and code not playing well with mkdir -p.  solved problem by following directions.  Got it to compile, produce the ic2 firmware, renamed it and transferred it to pico. pico lights up with GPIO 2 & 3 active, but USB device cannot start. "This device cannot start. (Code 10)...A request for the USB BOS descriptor failed." devman (Win 10/11 tested 2 separate computers) regardless of driver.  Try to build, please tell me if it works for you


Added a test for saving a new attachment to an existing doc

What
Added a test for saving a new attachment to an existing doc
How
Create a document and save it.
Then create an attachment and save it to the document.
Assert that the attachment is correctly saved.
Testing
Ran new test against CouchDb and Cloudant service.
reviewer @alfinkel

+1


Update the flutter script's locking mechanism and follow_links

Description
Update the flutter script's locking mechanism and follow_links function to be more robust and support more platforms.
This adds support for using mkdir as a fallback if the system doesn't have shlock.
It also fixes a problem in the follow_links function where it failed when the link resolved to the root directory.
Related Issues

https://github.com/flutter/flutter/issues/57512

Tests

no tests yet.

Breaking Change

[X] No, this is not a breaking change.

I did consider using the mkdir method for all platforms, simply because then we would be able to not be limited to locking for a single host if the flutter tree is on a file share, but the downside is that if someone kills a running script with kill -9, the flock file descriptor will be closed, whereas the exit trap won't run, leaving a lock directory around.
This is a tradeoff, but I think a file-shared repo is a less common situation than killing a running script on a single host, so I preferred flock where it exists.
I've switched the flock call to be in a loop though, so that we can immediately print the "Waiting for another flutter command..." prompt: as it is now, it doesn't print that until the Dart snapshot is built and runs, so if you don't have it built, it takes a while to say why it's waiting (like 10-20 seconds).

After looking into it some more, I think I'm just going to use the mkdir method on all platforms.  I found out that shlock doesn't work on file shares with macOS (I tried it locally, and it says "operation not permitted" when trying to lock), and I tried killing the process with -9, and it still was able to remove the lock directory, and that was the one advantage that I thought flock had over the mkdir method.

The advantage of using mkdir is that it works on network shares and (nearly all) NFS volumes.
I did find after fixing this, though, that the locking that the flutter tools use internally also doesn't work over a network share (at least on an AFP-over-TCP share mounted on a macOS machine), so I'm not sure that this is a real fix to a problem anyone has right now: they already couldn't use Flutter from that kind of share, even if the bash script worked perfectly.

Even more data! :-) Actually, if I kill -9 the subshell that is doing the upgrade, then it will leave around the lock directory, and flock won't (because it's just a file descriptor).
So I guess I'm going to leave it using flock for systems that have it. Which is too bad: it made the code a lot simpler to just have one way of doing things.

Even more data! :-) Actually, if I kill -9 the subshell that is doing the upgrade, then it will leave around the lock directory, and flock won't (because it's just a file descriptor).
So I guess I'm going to leave it using flock for systems that have it. Which is too bad: it made the code a lot simpler to just have one way of doing things.

We need to link to this PR in the code, lest someone end up going through the whole thing again in a few years :P

Well, the PR is implicitly linked, since it's in the history for the file.

OK, I've updated this to HEAD, and I think this is ready for review "for reals".

Thanks so much for doing this @gspencergoog!


update Lenia to work with torch version >1.7

Main incompatibility seems to be: https://stackoverflow.com/questions/71515439/equivalent-to-torch-rfft-in-newest-pytorch-version
This will make Mac M1 development/builds much easier, as they do not have torch versions this old.

Closed by commit fbd5822


[suggestion] Option to rename caught pokemon to their iv values or potential

Adding the option the rename pokemon to their IV values would greatly help pokemon inventory management. The catch and release thresholds are great but this would add another level of pokemon bag management.

Duplicate of https://github.com/PokemonGoF/PokemonGo-Bot/issues/452
/closed


fix(audit) : readOnly audit alerts

Purpose of PR?:
There was no check for readOnly audit events where we set matchedFlags to true.
Fixes #1397
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[x] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

Please rebase and squash. Thanks 🙌🏽

@Prateeknandle could u rebase, then we'll merge


Feature/update rubocop 1.5.0

https://github.com/rubocop/rubocop/releases/tag/v1.5.0

rubocop/rubocop#9098: Update Metrics/BlockLength and Metrics/MethodLength to use IgnoredMethods instead of ExcludedMethods in configuration. The previous key is retained for backwards compatibility.

https://github.com/rubocop/rubocop/releases/tag/v0.78.0

rubocop/rubocop#7542: (Breaking) Move LineLength cop from Metrics department to Layout department.

@CAMOBAP don't forget to merge https://github.com/CAMOBAP/oss-guides/pull/1 once this one will be approved

@ronaldtse could you please have a look

Ping @abunashir

@ronaldtse should be ready for merge now

BTW We may need to update Hound to actually use Rubocop 1.5 in this file: https://github.com/riboseinc/oss-guides/blob/master/.hound.yml. I'll take care of that.


minor bug in @Builder documentation

see https://projectlombok.org/features/Builder.html
 public BuilderExampleBuilder occupation(String occupation) {
37       if (this.occupations == null) {
38         this.occupations = new java.util.ArrayList<String>();
39       }
40
41       this.occupations.add(occupation);
42       return this;
43     }
44
45     public BuilderExampleBuilder occupations(Collection<? extends String> occupations) {
46       if (this.occupations == null) {
47         this.occupations = new java.util.ArrayList<String>();
48       }
49
50       this.occupations.addAll(occupations);
51       return this;
52     }

Isn't there an else missing?
 public BuilderExampleBuilder occupation(String occupation) {
37       if (this.occupations == null) {
38         this.occupations = new java.util.ArrayList<String>();
39       }
40       else {
41         this.occupations.add(occupation);
           }
42       return this;
43     }
44
45     public BuilderExampleBuilder occupations(Collection<? extends String> occupations) {
46       if (this.occupations == null) {
47         this.occupations = new java.util.ArrayList<String>();
48       }
49       else {
50         this.occupations.addAll(occupations);
           }
51       return this;
52     }

No, we always need to add the occupation or occupations to the list, even if we just created the list.

Those semantics are bizarre, though. What it means is that a null value (unlike non-null values) causes the list to be cleared... and instead of an empty list, you get a list containing a null value.

OH -- never mind, this was a case of programmer dyslexia on my part. I misread the lazy initialization as
public BuilderExampleBuilder occupation(String occupation) {
37       if (occupation == null) {
38         this.occupations = new java.util.ArrayList();
39       }
40
41       this.occupations.add(occupation);
42       return this;
43     }
44
45     public BuilderExampleBuilder occupations(Collection<? extends String> occupations) {
46       if (occupations == null) {
47         this.occupations = new java.util.ArrayList();
48       }
49
50       this.occupations.addAll(occupations);
51       return this;
52     }
My mistake!


Add linter

Codecov Report

Merging #13 (ce3a468) into main (bdf8f27) will increase coverage by 1.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   15.38%   16.66%   +1.28%
==========================================
  Files           3        3
  Lines          13       12       -1
  Branches        1        1
==========================================
  Hits            2        2
+ Misses         11       10       -1

Impacted Files
Coverage Δ

src/reportWebVitals.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf8f27...ce3a468. Read the comment docs.


Add ShiftLeft build rules

This pull request enables build rules. You can read more about build rules here. The build rules are controlled by the shiftleft.yml file in the repository.
Visit app.shiftleft.io to see the security findings for this repository.
We've done a few things on your behalf

Forked this demo application
Generated a unique secret SHIFTLEFT_ACCESS_TOKEN to allow GitHub Actions in this repository to communicate with the Qwiet (Shiftleft) API
Committed a GitHub Action that will invoke Qwiet preZero's Static Application Security Testing (SAST) on all future pull requests on this repository
Created this pull request that demonstrates build rules. It also adds a status check that displays the result of the GitHub Action

Questions? Comments? Want to learn more? Get in touch with us or check out our documentation.

 Checking analysis of application shiftleft-ts-demo.
querying scans/check: API returned status 404, with code: 'APP_NOT_FOUND' message: 'The specified application was not found'.

 Checking analysis of application sl.
Checking findings on ]8;;https://app.shiftleft.io/apps/sl/summary?scan=71\scan 71]8;;.
Results per rule:
❌report: FAIL
(171 matched vulnerabilities; configured threshold is 0).
First 5 findings:
ID  CVSS  Rating  Title

─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
]8;;https://app.shiftleft.io/apps/sl/vulnerabilities?branch=master&expanded=true&findingId=580&scan=71\580]8;;\   5.0  medium  Invalid Certificate Validation: Certificate Validation is Disabled in New
]8;;https://app.shiftleft.io/apps/sl/vulnerabilities?branch=master&expanded=true&findingId=492&scan=71\492]8;;\   3.0   low    Race Condition: Check Followed by Read or Write Operation on Same File Path in loadPolicy
]8;;https://app.shiftleft.io/apps/sl/vulnerabilities?branch=master&expanded=true&findingId=493&scan=71\493]8;;\   3.0   low    Race Condition: Check Followed by Read or Write Operation on Same File Path in analyzer.standaloneJava2CPGAnalysis
]8;;https://app.shiftleft.io/apps/sl/vulnerabilities?branch=master&expanded=true&findingId=494&scan=71\494]8;;\   3.0   low    Race Condition: Check Followed by Read or Write Operation on Same File Path in analyzer.createOutputFolder
]8;;https://app.shiftleft.io/apps/sl/vulnerabilities?branch=master&expanded=true&findingId=495&scan=71\495]8;;\   3.0   low    Race Condition: Check Followed by Read or Write Operation on Same File Path in slApp.getLanguage
Severity rating  Count
────────────────────────
critical             0
high                 0
medium               1
low                170
Category                        Count
───────────────────────────────────────
Race Condition                     87
Sensitive Data Usage               81
Sensitive Data Leak                 1
Invalid Certificate Validation      1
Crypto                              1
Command Injection                   1
OWASP 2021 Category                             Count
───────────────────────────────────────────────────────
A01-Broken-Access-Control                         169
A07-Identification-And-Authentication-Failures      1
A03-Injection                                       1


chore: setup release v0.0.29

https://github.com/google/kythe/releases/tag/untagged-5523978996d80caf68d7


[misc] Bugfix: importing Visit Information forms may lead to exceptions

Visits completed flag now gets set when expected. Should we worry about this one - patient logs in to SUBMIT completed surveys:

Should we worry about this one - patient logs in to SUBMIT completed surveys

I'll look into it separately.


added ucPack-mpy

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update kentico cloud SDK

Motivation
Upgrade to the newest Kontent SDK for PHP.
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

Currently blocked by https://sourceforge.net/p/simplehtmldom/support-requests/49/


Incomplete Setup Using npx create-remix@latest

Description
While following the Getting Started guide, I ran npx create-remix@latest to create a new Remix application. However, I noticed that several steps, including the Prisma setup, were missing.
Steps to Reproduce
Follow the Getting Started guide using MacBook Pro with M1 chip.
Run the command: npx create-remix@latest.
Expected Behavior
The setup should include all necessary configurations, including Prisma setup and other essential steps, to get the application running easily.
Actual Behavior
The setup was incomplete and did not include Prisma setup, among other necessary configurations.
Workaround
I tried the following command and was able to get the complete (expected) boilerplate set up:
SKIP_SETUP=false SKIP_FORMAT=false SKIP_DEPLOYMENT=false npx create-epic-app@latest
This command ensured that all required setup steps were executed correctly.
Could you please update the Getting Started guide and the npx create-remix@latest command to ensure that all necessary setup steps are included by default?
Thank you!

What @kiliman said 👆
Let us know if there's anything else :)


Tips for upgrade in new version

Add checkbox (and select/deselect all) on assests screen for multiple changes: start and end datetime, delete, active/inactive.

Add players groups - example: Dining rooms[player1,player5], All[player1,player2,player3,player4,player5], Firt floor[player1,player2], Second floor [player3,player4,player5]
its for better managment and for "add asset to multiple device".

Add option active/inactive, start, end, for new created asset - before upload. "Inactive" is important! .

Hello @JurakZdenek
thanks for your feedback!
1 - need time to implement but I guess it would be easy
2 -  sound like a small function but in the background I must check if it is possible at the moment
3 - I can implement this is V4.0 as well
1 and # 2 maybe in the following versions - I will add this to the projects board

is implemented now

1. is implemented now

Perfect, you work quickly. Can I try it? or when will the new version be released?

Hey,
I am currently testing the system completely. If you want to have a look at it already, you can install it like this.
However, I can't guarantee that something won't break at the moment! - Maybe I release this year or in the next. It depents on the free time that I have 😉
bash <(curl -sL https://git.io/JL3vh)

1. is implemented now

Hi, can you add this option to Multi Uploader? Thank you :-)

Oh what? - I forgot it 🙉
I think you must update your system hust 😉

Hi!
First of all congratulations on the update of the tool, I installed it on my cloud server, did the multi-upload tests, groups and users.
I wanted to share a suggestion. In the dashboards screen, the ideal would be to show only information of the players that the user manages. what do you think?
I'm going to do some tests and give you feedback. but this is very show! congratulations one more time!

Hello @c4rv88,
thanks for your feedback but create a new issue for one topic in the future, please - It's easier to handle that in the project plan!
Your suggestion is implemented. 😉
@JurakZdenek - I close the Issue now! - I copy your ideas into the upcoming project plan: https://github.com/didiatworkz/screenly-ose-monitor/projects/4

Hello @c4rv88,
thanks for your feedback but create a new issue for one topic in the future, please - It's easier to handle that in the project plan!
Your suggestion is implemented. 😉
@JurakZdenek - I close the Issue now! - I copy your ideas into the upcoming project plan: https://github.com/didiatworkz/screenly-ose-monitor/projects/4


Copy sql dll to extension bundle during Integration tests

Moving this step from the pipeline to IntegrationTestBase so that we don't have to manually copy the dll to the bundle when running integration tests locally.
I couldn't find a way to specify the extension bundle path when running func start. The instructions for testing local extension bundles also use the copy method: https://github.com/Azure/azure-functions-extension-bundles#test-an-extension-bundle

I want to say that I believe this would be quite beneficial to local development. As I am currently having to run the script constantly every time I make changes to the C# code. Would like to know why we would not generally test the latest dll version for non-C# languages? Having this would just enhance our developing experience while the core tools team may potentially add an environment variable.

I think the concern is for folks who are unaware of the extension bundle being modified while running tests and causing confusion with behavior differences between their local sql dll and the sql dll shipped with the bundle.

Correct. And since we don't revert it (and couldn't 100% guarantee it would be reverted) this could mean that people running the tests end up with a potentially broken version of the extension in their bundle forever until they manually fix it.
My ideal scenario would be that the func CLI allow specifying a custom location for the bundle package so that we could use a temp one during tests. But that isn't currently supported unfortunately.


Docs out of sync

The current published documentation is out of sync and does not match the API as it stands in the latest release. It also points to an old cats version where several combinators and imports seem to have changed.

It'll be fixed by #91


ARM (32-bit) SIGILL

I was able to get everything cross-compiled to armv7 32-bit (beaglebone cortex8) fine from the meta-flutter recipes after making a few small changes (https://github.com/flutter/buildroot/pull/499). I am testing out the wayland client but its SIGILL'ing in the flutter lib after the flutter-client is booted and threads are running. Any ideas where to go from here? I am not sure how the performance is going to be once its running, but it would be great to see how it performs on the beaglebone with the PowerVR GPU + Weston8 compositor.
FWIW - I have tried libflutter cross compiled and in debug mode to see if i could step through and figure out what the instruction is that its not liking, but I am unsure of the steps to create an .AOT file that is also in debug mode. When i try and run swap the release libflutter for the the debug libflutter its not able to load (I think a previous issue mentioned how to work around that, but for the desktop linux version).
root@migraine:~/pkg# gdb --args flutter-client --bundle=/usr/share/flutter/examples
GNU gdb (GDB) 9.1
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "arm-poky-linux-gnueabi".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from flutter-client...
Reading symbols from /usr/bin/.debug/flutter-client...
(gdb) br main.cc:41
Breakpoint 1 at 0x5a2a0: file /usr/src/debug/flutter-wayland-client/1.0-r0/git/examples/flutter-wayland-client/main.cc, line 41.
(gdb) r
Starting program: /usr/bin/flutter-client --bundle=/usr/share/flutter/examples
warning: Unable to find libthread_db matching inferior's thread library, thread debugging will not be available.
[New LWP 1256]
[New LWP 1257]
[New LWP 1258]
[New LWP 1259]
[New LWP 1260]

Thread 1 "flutter-client" hit Breakpoint 1, main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/flutter-wayland-client/1.0-r0/git/examples/flutter-wayland-client/main.cc:41
41      /usr/src/debug/flutter-wayland-client/1.0-r0/git/examples/flutter-wayland-client/main.cc: No such file or directory.
(gdb) info thread
  Id   Target Id                 Frame
* 1    LWP 1253 "flutter-client" main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/flutter-wayland-client/1.0-r0/git/examples/flutter-wayland-client/main.cc:41
  2    LWP 1256 "io.flutter.ui"  0xb6dae75e in ?? () from /usr/lib/libflutter_engine.so
  3    LWP 1257 "flutter-client" 0xb6447af8 in ?? () from /lib/libpthread.so.0
  4    LWP 1258 "io.flutter.io"  0xb65545a4 in epoll_wait () from /lib/libc.so.6
  5    LWP 1259 "io.worker.1"    0xb644aecc in pthread_cond_wait () from /lib/libpthread.so.0
  6    LWP 1260 "flutter-client" 0xb65545a4 in epoll_wait () from /lib/libc.so.6
(gdb) c
Continuing.

Thread 2 "io.flutter.ui" received signal SIGILL, Illegal instruction.
[Switching to LWP 1256]
0xb5424b8c in ?? ()
(gdb)

vbox$ readelf -A ./deploy/images/dorado/p2/usr/bin/id.coreutils
Attribute Section: aeabi
File Attributes
  Tag_CPU_name: "7-A"
  Tag_CPU_arch: v7
  Tag_CPU_arch_profile: Application
  Tag_ARM_ISA_use: Yes
  Tag_THUMB_ISA_use: Thumb-2
  Tag_FP_arch: VFPv3
  Tag_Advanced_SIMD_arch: NEONv1
  Tag_ABI_PCS_wchar_t: 4
  Tag_ABI_FP_rounding: Needed
  Tag_ABI_FP_denormal: Needed
  Tag_ABI_FP_exceptions: Needed
  Tag_ABI_FP_number_model: IEEE 754
  Tag_ABI_align_needed: 8-byte
  Tag_ABI_align_preserved: 8-byte, except leaf SP
  Tag_ABI_enum_size: int
  Tag_ABI_VFP_args: VFP registers
  Tag_CPU_unaligned_access: v6
  Tag_Virtualization_use: TrustZone

vbox$ readelf -A ./sysroots-components/cortexa8hf-neon/flutter-engine/usr/lib/libflutter_engine.so
Attribute Section: aeabi
File Attributes
  Tag_CPU_name: "7-A"
  Tag_CPU_arch: v7
  Tag_CPU_arch_profile: Application
  Tag_ARM_ISA_use: Yes
  Tag_THUMB_ISA_use: Thumb-2
  Tag_FP_arch: VFPv3
  Tag_Advanced_SIMD_arch: NEONv1
  Tag_ABI_align_needed: 8-byte
  Tag_ABI_align_preserved: 8-byte, except leaf SP
  Tag_Virtualization_use: TrustZone

@HidenoriMatsubayashi Thanks so much for the response, I was able to get symbols loaded. After trying many things I was convinced there were no issues with the libflutter-engine.so and focused on the VM snapshot side of things. After much digging I found this issue mentioned on the arm7 pi with dart:
https://github.com/dart-lang/sdk/issues/24466
I added both the flags to then gen_snapshot that were mentioned and now everything is working. It is actually quite performant after things get loaded.  I need to dig in and understand things a little better. As a side note for reference, you can see all VM options with clang_x64/gen_snapshot  --verbose
Feel free to close this issue.

@mc-appl
Great! Also, I welcome to accept your PR (yocto-recipe) to add flutter-engine 32bit build support in https://github.com/sony/meta-flutter, if you want.


⚠ Bofrost.be has degraded performance

In 75a4d87, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1589 ms

Resolved: Bofrost.be performance has improved in fd36640.


Enhancing Booking Page

🖥 Frontend Issue
Description
The booking page needs some styling.
Steps to Reproduce

Go to Footer
Click on Bookings

Kindly assign this issue to me
Expected behavior
Its should be appealing and attractive aligning with website theme
Screenshots or Video

Are you participating in GSSoC?

[x] Yes
[ ] No

make it responsive also @Bhum-ika


arrow-cpp: disable some potentially failing s3fs tests

Motivation for this change
These tests can hang or fail, disable them when running arrow-cpp tests.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Also, at this point we can drop minio dependency?

@veprbl Unfortunately we can't remove the minio dependency. Without it, arrow-s3fs-test will fail to start at all.

@veprbl Unfortunately we can't remove the minio dependency. Without it, arrow-s3fs-test will fail to start at all.

Thank you for checking!


How to get nuScenes test data results? (not v1.0-trainval)

does anyone know how to get nuScenes test data's results? (not valid data)

@daeunni Hi, I'm having the same problem, do you know how to solve it? I want to use my own model to get the prediction result in nuscenes test dataset and save it, then submit it to nuscenes official website, do you know how to do it?

I think you should submit your results to nuScenes websites(like kaggle)


Whitelist got

See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43453

It's now in the production branch, so Definitely Typed's CI will get the new whitelist next time it runs.


Possibility to get properties of native elements

Suggested here: https://github.com/leancodepl/patrol/discussions/1071
We want to have an opportunity to get ie. text from an element found by native selector. Now it's only possible with Patrol finders.

also requested in #1403

This is already possible with $.native.getNativeViews (but only on Android).
I see two steps to resolve this issue:

make $.native.getNativeViews() work on iOS
think up a better, more sleek API than getNativeViews. Currently, it's quite clunky:final views = await $.native.getNativeViews(Selector(resourceId: "resource-id"));
expect(views.length, equals(1)); // I understand that only one view with such resourceId exists
final view = views.first;
// now you can access properties of `view`


Fix san bare suffix, ca CN effective time, subCA EKU

Updates three lints:

Uses util.ICANNPublicSuffixParse for the SAN bare suffix test
Uses the correct EffectiveDate for the commonName test for CAs
Reduces the error to a notice if EKU is missing in subCA, required only for technically constrained CAs.

@zakird fixes the outstanding bugs.

I haven't quite been able to follow all the changes around the public suffix list. I suspect that @titanous or Rob are going to be in a better spot to take a look.


Highlight difference between steps

This might be quite a bit more trouble than it would be worth (implementation-wise), but it would be nice if you could turn on an option to highlight the difference between the results of each consecutive pair of steps in a script:

($) ▲ ▲ send
    (($) ▲ ▲ loop
         ((>>=) ▲ $fMonadR ▲ ▲ (buttonE (I# 0))
                (λ r →
                   (>>=) ▲ $fMonadR ▲ ▲
                         ((λ x → return ▲ $fMonadR ▲ (unLit x)) r)
                         (λ b →
                            (>>) ▲ $fMonadR ▲ ▲ (ledE (I# 0) (lit b))
                                 ((>>) ▲ $fMonadR ▲ ▲
                                       (ledE (I# 1) (lit (not b)))
                                       (wait (I# 100)))))))
[Done]

($) ▲ ▲ send
    (($) ▲ ▲ loop
         ((>>=) ▲ $fMonadR ▲ ▲ (buttonE (I# 0))
                (λ r →
                   (>>=) ▲ $fMonadR ▲ ▲
                         ((λ x → return ▲ $fMonadR ▲ (unLit x)) r)
                         (λ b →
                            (>>) ▲ $fMonadR ▲ ▲ (ledE (I# 0) (lit b))
                                 ((>>) ▲ $fMonadR ▲ ▲
                                       (ledE (I# 1) (notE (lit b)))
                                       (wait (I# 100)))))))
[Done]

This would also work together with #30 well, if we decide to implement that.

The old shell had the command diff for this. If you gave it two AST ids (the number printed in the hermit prompt... hermit<30> means you are transforming AST id 30), it would show the diff between the pretty printed output. If you want this always, you could use set-pp-diffonly True.
It's not the greatest diff (it diffs by line), but I used it quite a bit. I have an idea for using the fold machinery to do semantic diff, but haven't gotten around to it yet.

We have a plan here. Because we (will) return the HDoc by default to the Shell, there can be a function
diff :: HDoc -> HDoc -> IO HDoc


Branch out 4.8 and use master for 4.9

Code freeze for 4.8 happened and rc bits are available. For snc side it is time to branch 4.8 and use master for 4.9 development phase.

A release job also need to be added for 4.8 branch on https://github.com/openshift/release/blob/master/ci-operator/jobs/code-ready/snc/

https://github.com/openshift/release/pull/19527 for release job.

This means we'll have 3 active branches in parallel. Is it required that we does that switch now, or can we delay this until crc switches to 4.8?

This means we'll have 3 active branches in parallel. Is it required that we does that switch now, or can we delay this until crc switches to 4.8?

We do need to switch eventually and it's better to do it now since rc bits are released instead waiting. There is no issue with having 3 branches we will file an PR to remove 4.7 when 4.8 is part of crc release since we don't require to maintain 4.7 branch.

This is fixed now.
/close


Handle draft stages for IWA

We need to handle the IWA draft stages.
 How should I convert it to URN and PubID?

@mico AWI is not NP stage. AWI = "Approved Work Item". NP = "New Work Item Proposal".
https://www.metanorma.org/author/iso/ref/document-attributes/#document-type-and-stage

@mico AWI is not NP stage. AWI = "Approved Work Item". NP = "New Work Item Proposal".
https://www.metanorma.org/author/iso/ref/document-attributes/#document-type-and-stage

How can I know is it stage 10.99 or 10.98?
These identifiers are at stage 20.00:
https://www.iso.org/standard/61118.html
https://www.iso.org/standard/50073.html
https://www.iso.org/standard/79649.html
Is AWI stage or copublisher here?

@mico AWI is stage.

These identifiers are at stage 20.00:

Good find... then we need to update that AWI is 20.00...
Ping @opoudjis for comment.

I'll need to review the ISO documentation.

@mico just use AWI as 20.00. No need to wait for @opoudjis , there is no ISO documentation on the stage codes mapping to document stages.

This is actually not completed at all! What was handled in #21 is "AWI" (Approved Work Item). Not "IWA". Reopening.


Implement optional flood protection

Hello, I bring an enhancement we're implementing in discord-irc: flood protection. I figure it might make more sense to have upstream for other consumers of the library.
It's possible for clients to, say, naively chunk up a 4000 character input message in a for loop and get kicked from the IRC server when using the library. This provides a solution to that problem that is simple to apply in configuration.
This option utilizes the Queue library and is disabled by default.
All tests pass with a small change to allow the queue to process messages in the mock environment.
Documentation updated.
Tested and working as expected with discord-irc.

Hello, thank you for contributing.
Some first impressions/questions:
1/ I see this feature is restricted to PRIVMSG, would it make sense to push all outgoing IRC messages in the queue (rather than only PRIVMSG)?
2/ Need some tests/thoughts but I wonder if we could implement it "as a plugin" with something like:
// plugins/antiflood.ts

// `hookCall` is roughly like a patch function
client.hooks.hookCall("send", (send, command, ...params) => {
  if (command === "PRIVMSG") {
    return queue.push(async () => {
      const raw = await send(command, ...params);
      await delay(floodDelay);
      return raw;
    });
  } else {
    return send(command, ...params);
  }
});

the only reason would be to keep the core part easier (and secondly free from third party library). WDYT?

For the first part, I initially tried all messages and found it made the client quite slow to connect and register in a situation where those messages don't need to be restricted. I think there's a limited subset of IRC messages that should be rate limited but I'm not sure what all members in that set are. We noticed this when trying to send long split messages from Discord to IRC and were getting kicked from Libera in our tests.
For the second part, pushed the change. Much cleaner, I like the pattern you have established. This reveals we need some tests for the plugin, so I'm working on that next.

Tests pushed and passing, and application working as expected in my discord-irc integration tests.

I think it's ready to be merged now.
Let me know when you are OK to merge.

I ran through my integration tests with the updated changes on my end and everything passes.
OK to merge.


Plug cowboy plugin

Adds a Plugin for Plug.Cowboy metrics
What problem does this solve?
New Plugin listening for Plug.Cowboy :telemetry events
Dashboard is pretty much a carbon copy of the phoenix dashboard at this point (minus the channel stuff). Rationale is to have something similar for projects that use a plug only setup.
Example usage
Basic setup
def plugins do
    [
      ...
      PromEx.Plugins.PlugCowboy
    ]
end

Ignore some routes
def plugins do
    [
      ...
      {PromEx.Plugins.PlugCowboy, ignore_routes: [prom_ex_metrics: "/metrics"]}
    ]
end

Additional details and screenshots
Checklist

[ ] I have added unit tests to cover my changes.
[ ] I have added documentation to cover my changes.
[ ] My changes have passed unit tests and have been tested E2E in an example project.

Pull Request Test Coverage Report for Build abe134db9bc794943ec6f1390d199d2fa47ba139-PR-80

15 of 17 (88.24%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0009%) to 82.315%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/prom_ex/plugins/plug_cowboy.ex
15
17
88.24%

Totals

Change from base Build 0bc739a1524bb71f15485ec8b1448afa22309878:
0.0009%

Covered Lines:
633

Relevant Lines:
769

💛  - Coveralls

@akoutmos I've been seeing this error repeatedly
Run mix format --check-formatted

** (Mix) mix format failed due to --check-formatted.
The following files are not formatted:

  * lib/mix/tasks/prom_ex.dashboard.publish.ex
  * lib/prom_ex/dashboard_uploader.ex

Error: Process completed with exit code 1.

But running mix format --check-formatted does not raise any formatting issues on my end, do you know what might be issue?

Thanks for the PR!!
My guess is that you are on Elixir 1.12? CI uses 1.11 https://github.com/akoutmos/prom_ex/blob/master/.github/workflows/main.yml#L23

that was it 😄 1.11 catches the formatting issue

Nice! I'll take a look at this over the weekend and get back to you with feedback if I have any. Thanks again for the awesome work!!


wrapQtAppsHook broken on macOS

Describe the bug
The convenience function wrapQtAppsHook does not work on macOS. The calls patchelf like so:
            patchelf --print-interpreter "$file" >/dev/null 2>&1 || continue

If the calls succeeds wrapQtApp is called with$file as argument. Since patchelf is not installed, this always fails, skip all files, and binaries are not properly wrapped – and hence fail to execute.
As a work-around I had to call wrapQtApp manually in the preFixup phase. It did it's thing, wrapped the binary properly and I could run the binary without issues.
To Reproduce
Steps to reproduce the behavior:

Build an arbitrary Qt app on macOS (for example gpxlab or glogg, but really any Qt app works …)
Compile and install under Linux, to see wrapping working
Disable manual call to wrapQtApp
Compile and install under macOS to see wrapping via the hook doing nothing
Verify that the app under macOS is indeed not wrapped and fails to execute

Expected behavior
Properly wrapped application. Wrapping itself works, as evidenced by a manual call to wrapQtApp, but have the hook not depend on patchelf on macOS or at least ** give a warning **  and give a warning in the manual.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
nix-shell -p nix-info --run "nix-info -m"
these paths will be fetched (0.01 MiB download, 0.03 MiB unpacked):
  /nix/store/12pkkc7l378r75xz1kvh39wlk1p4gw7w-DarwinTools-1
  /nix/store/zvir75d0b5swjva0xkyxcidpagf7jpdv-nix-info
copying path '/nix/store/12pkkc7l378r75xz1kvh39wlk1p4gw7w-DarwinTools-1' from 'https://cache.nixos.org'...
copying path '/nix/store/zvir75d0b5swjva0xkyxcidpagf7jpdv-nix-info' from 'https://cache.nixos.org'...
 - system: `"x86_64-darwin"`
 - host os: `Darwin 19.6.0, macOS 10.15.7`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.7`
 - channels(hannesweisbach): `""`
 - channels(root): `"nixpkgs-20.09pre242465.bd649f4f55c"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

This must have been broken for over a year then, when c6d516dfc49c1d84ef03605e0d2b8aa3ea8ae431 as part of https://github.com/NixOS/nixpkgs/pull/68513 was merged.

Is patchelf part of the stdenv for Darwin? Could you run
$ nix-shell --pure -p --run patchelf

Is patchelf not part of the stdenv for Darwin? Could you run
$ nix-shell --pure -p --run patchelf

Yes, sure:
% nix-shell --pure -p --run patchelf
/private/var/folders/gy/ngbl8v6s24gb86kc6lbjg9rr0000gn/T/nix-shell-30699-0/rc: line 1: patchelf: command not found

This must have been broken for over a year then, when c6d516d as part of #68513 was merged.

Hm, did I f*** something up?

Okay, so either the commit i pointed to is responsible for this, or
sometime since then patcheld got removed from darwin stdenv or at least the
builder.
On Mon, 2 Nov 2020, 09:24 hannesweisbach<EMAIL_ADDRESS>wrote:

Is patchelf not part of the stdenv for Darwin? Could you run
$ nix-shell --pure -p --run patchelf
Yes, sure:
% nix-shell --pure -p --run patchelf
/private/var/folders/gy/ngbl8v6s24gb86kc6lbjg9rr0000gn/T/nix-shell-30699-0/rc: line 1: patchelf: command not found
This must have been broken for over a year then, when c6d516d
https://github.com/NixOS/nixpkgs/commit/c6d516dfc49c1d84ef03605e0d2b8aa3ea8ae431
as part of #68513 https://github.com/NixOS/nixpkgs/pull/68513 was
merged.
Hm, did I f*** something up?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/102044#issuecomment-720317651,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQHZ33MY33JYL7EOFJM4WTSNZUDPANCNFSM4TDW5DPQ
.

Thanks for looking into this.
Does this help:
pwd
/Users/hannesweisbach/.nix-defexpr/channels/nixpkgs
hannesweisbach@MBP nixpkgs % ack -i patchelf ./pkgs/stdenv/darwin

Would patchelf availability even fix anything in that check? Darwin binaries aren't ELF files, they're Mach-Os.

Different question, is the patchelf check even needed? wrapGAppsHook just finds all executable files in a list of paths and wraps them.
https://github.com/NixOS/nixpkgs/blob/d600f006643e074c2ef1d72e462e218b647a096c/pkgs/build-support/setup-hooks/wrap-gapps-hook/wrap-gapps-hook.sh#L65-L69

I don't know. patchelf itself probably isn't needed itself, only the fixup/wrap in paths. However, I'm not really qualified to give an answer.
I also don't have/use nix anymore. While its proposition was good, it was just too time consuming to get stuff working on macOS (compile time-wise, bug finding-wise and getting feedback on patches on issues).

Just to confirm I'm also running into this (in my case it's causing pkgs.octaveFull binaries not to be wrapped for Qt).  I don't use darwin often, but I can confirm this issue wasn't present in a previous build I did from nixpkgs master from 25 Aug 2020 which already contains the patchelf --print-interpreter change, so I think it's more likely patchelf was removed later somehow on darwin.

@OPNA2608 I agree, in my testing patchelf will fail on the executable I care about wrapping (octave) anyway.  I think we need to do something different on Darwin (either wrap everything executable, or use something else like file to detect Mach-O executables - I'd probably lean towards just wrapping all executables for simplicity).  Does anyone know a good way to detect Darwin inside the hook?

The above PR would not close this, I wrote "should help fix " and GitHub took the "fix" string as closing this. I've updated the PR comment with better wording.


STORM-3524 create complete blobstore path in case parent directory ge…

…ts deleted
Based on the exception I saw on a supervisor, I think a race condition existed between a cleanup of the localizer for an older topology and a new one starting where a parent directory was deleted right before a download.
Files.createDirectory() then throws an exception because the parent directory does not exist and can never succeed.
Files.createDirectories() should guarantee the directory gets created.  Also added logging for removing the user to better debug in the future.

@Ethanlm - made the requested changes.


Setting scanning interval

Hello
i am able to scan the beacons without duplicates, but i want to scan the beacons for every 10secs, even if there are same beacons  i want to console log them for every 10 sec
for example
Bleacon.startScanning(); //setting interval for this
or chage in onDiscover event

like
Bleacon.startScanning(); setting interval for this

@karthikbnd what have you tried so far?
This should be possible using the startScanning and stopScanning API's in conjunction with setTimeout.

var interval = setInterval(Beacon_scanning, 10000);
console.info('Started Scanning........');
function Beacon_scanning(){
Bleacon.startScanning();
}

@karthikbnd what about the stopScanning API I mentioned in my previous comment?

Closing due to lack of activity.


feature: support xxl-job version 2.3.0

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

You need to add test to that version. Also, in the new version if the argument is removed, how to get the job name?

Actually,I have  test to 2.3.0 and 2.2.0. The removed argument is 'JobParam',not the job name and just as a tag, useless.

Why job param useless? Even though, I am not using java agent or this plugin, I feel this parameter matters about how this job gets triggered.

Then this is typical case you should use witness class or method to identify versions, then use different interceptor and instructions for different versions. Then the core could choose the right plugin in the runtime.

Actually, according to "allArguments.length" can identify version,2.2.0 work as before

Then, you should fill the logic for 2.3.0 too. Let's keep them consistent

OK, I will do it

@xiaoxiongmao-liu Are you still working on this?

Yes, I will do it as soon as possible.But I am busy my official work.


Fix compilation with OpenSSL 1.1.0 (broken in #327)

This patch fixes an OpenSSL 1.1.0 compilation problem introduced in #327.

Thank you very much for the quick fix. The commit has been squashed into master. We really need those travis-ci builds


Task missing at service update

When I update image of a service, the tasks may go down and come up. But in most cases some tasks disappear in this period. I'll have to refresh visualizer to get them back.
In this example, 4 tasks from service test are running but only 2 are shown.
ubuntu@ip-172-19-241-144:~$ docker service ls
ID            NAME  REPLICAS  IMAGE                      COMMAND
ikbylntzf1a8  test  5/5       dongluochen/simpleweb:2.0
itaigkgu9o4h  viz   1/1       manomarks/visualizer

ubuntu@ip-172-19-241-144:~$ docker service ps test | grep -i running
test.1.aepqd3xweezqtgbcqtwrq26f4      dongluochen/simpleweb:2.0  ip-172-19-241-144  Running        Running 35 seconds ago
test.2.maqa2woorz8g7erg0nuok31wl      dongluochen/simpleweb:2.0  ip-172-19-241-145  Running        Running 12 seconds ago
test.3.t3e0npr9f9mimrqaa5dfrby86      dongluochen/simpleweb:1.0  ip-172-19-241-146  Running        Running 4 minutes ago
 \_ test.4.shrsqrcnosli2cjo0ek21frop  dongluochen/simpleweb:1.0  ip-172-19-241-146  Shutdown       Running 3 minutes ago
test.5.z4uclx3cc9c8x98d2fvfacf3y      dongluochen/simpleweb:1.0  ip-172-19-241-145  Running        Running 4 minutes ago

This project is awesome!

@dongluochen Can you give me some steps to recreate? I'm not showing this problem.

@ManoMarks I have viz setup in AWS with 3 machines cluster. I access viz thru public IP of the manager:8080 with port 8080 allowed to my IP. Here are the steps to repro.
$ uname -a
Linux ip-172-19-241-144 4.2.0-22-generic #27-Ubuntu SMP Thu Dec 17 22:57:08 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

$ docker node ls
ID                           HOSTNAME           STATUS  AVAILABILITY  MANAGER STATUS
4ianz3jxl171eqh137b2ic11k    ip-172-19-241-146  Ready   Active
5x3kjyttddq67kln5pvocaclj    ip-172-19-241-145  Ready   Active
8gpmadjgkqbpuanctojbfkosp *  ip-172-19-241-144  Ready   Active        Leader

# create viz
$ docker service create   --name=viz   --publish=8080:8080/tcp   --constraint=node.role==manager   --mount=type=bind,src=/var/run/docker.sock,dst=/var/run/docker.sock   manomarks/visualizer

# create a service
$ docker service create --name test --replicas 3 dongluochen/simpleweb:1.0

$ docker service ls
ID            NAME             REPLICAS  IMAGE                      COMMAND
i3d05j4973ao  test             3/3       dongluochen/simpleweb:1.0
qrruwcvm69nq  viz              1/1       manomarks/visualizer

# validate container counts are correctly shown in viz interface

# scale the service
$docker service scale test=10

# the container counts are not properly shown in viz interface

$ docker version
Client:
 Version:      1.13.0-dev
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   89ef0f2
 Built:        Mon Nov  7 18:06:13 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.13.0-dev
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   89ef0f2
 Built:        Mon Nov  7 18:06:13 2016
 OS/Arch:      linux/amd64
 Experimental: false

If I do a refresh on the viz interface, it'll update to show the correct containers in each machine.

Same problem with image manomarks/visualizer:beta. It looks like automatic refresh doesn't go thru. Force a refresh on chrome would fix the problem.
Here is info of visualizer.
ubuntu@ip-172-19-241-144:~$ docker service inspect viz --pretty

ID:		qrruwcvm69nq9f33vpz1to18l
Name:		viz
Service Mode:	Replicated
 Replicas:	1
UpdateStatus:
 State:		completed
 Started:	2 hours
 Completed:	2 hours
 Message:	update completed
Placement:Contraints:	[node.role==manager]
UpdateConfig:
 Parallelism:	1
 On failure:	pause
 Max failure ratio: 0
ContainerSpec:
 Image:		manomarks/visualizer:beta@sha256:3a9fcc9d1f905d384b8b15f47d99aa1eeacbf65426f2c467d2abbb4f0a6c1378
Mounts:
  Target = /var/run/docker.sock
   Source = /var/run/docker.sock
   ReadOnly = false
   Type = bind
Resources:
Endpoint Mode:	vip
Ports:
 PublishedPort 8080
  Protocol = tcp
  TargetPort = 8080

I am able to replicate the problem using Docker for AWS. What seems to happen is that the node stack doesn't show always show up if it involves changing a node that already has a service running on it. I'll dig deeper into this.

Any update on this? I ran into this on my swarm setup on DigitalOcean. @ManoMarks I realize this is not production, but this is such an awesome tool when someone wants to see how the deployment works :-)

I have taken some time to look at it, but it's pretty complex. The original code wasn't mine so I'm having to track the lifecycle of a task through the swarm, it's a little complicated :-)

fixed in #53 and #54


Small fix to Callback guides to enhance understanding

Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>
Description: This is a small fix to enhance the understanding of this feature with a few links, plus a decorative image.
There are two small bugs in the gRPC guide that I also fixed in this PR.

Please make sure that your PR meets the following requirements:

[x] You have read the contributions doc
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[ ] The nav.adoc file has a link to this guide in the proper category
[ ] The index.adoc file has a card to this guide in the proper category, with a meaningful description

How to setup automatic cherry-pick to another branch ?

The cherry-pick action allows to setup automatic cherry-pick from main to a specific branch.
To allow it, you will need to add the corresponding label with pattern: backport-{RELEASE_BRANCH}.
For example, if a backport to branch 1.26.x is needed, then the label should be backport-1.26.x.
Once the PR is merged, the action will retrieve the commit and cherry-pick it to the desired branch.
NOTE: You can still add label after the merge and it should still be cherry-picked.

The way the workflow call the extenal service can be through an event, htpp request or any other mean, while message seems to indicate we can only sent an aync message (an event)

@fjtirado Good catch! I was with the Loan Broker use case in my mind. Take a look now, please. I've also removed the envelope icon.


Gzip and Brotli support for the dev server

Description
Hello,
I know there are 3rd party plugins, but they are outdated and riddled with security vulnerabilities.
Is there a planned feature to include official support for Gzip and Brotli compression for the dev server? So, when we run dev or preview, we would get compression for static files such as js, css, svg, png, etc.
I am using Serve from Vercel as a workaround for previewing, but it would be nice to have this functionality in Vite itself.
Thank you!
Suggested solution
Add configurable Gzip and Brotli supprot directly to Vite.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Is there a reason why you need brotli and gzip in dev? It's mainly a production optimisation so it's not done in dev.

Is there a reason why you need brotli and gzip in dev? It's mainly a production optimisation so it's not done in dev.

I do a lot of perf testing in DevTools, including throttling emulation (slow and fast 3g). It is much more realistic with compression than without it. I rely on the dev server, so I don't have to deploy every build to my hosting provider.
So, I have been using Serve, but it's an extra step/dependency.

You shouldn't be testing perf with the dev server. It's serving files in a different way than prod and won't yield accurate results. If you mean the preview server, it already has the compression middleware.

You shouldn't be testing perf with the dev server. It's serving files in a different way than prod and won't yield accurate results. If you mean the preview server, it already has the compression middleware.

Yes, I do mean the preview server. I didn't realize it was a different server (I assumed it was the same, just running without the HMR scripts, etc.). Is there a setting to enable compression for the preview server? It does not seem to compress by default, at least not with Astro which uses Vite 3.
Thank you.

It's enabled by default using this middleware. Looks like it enables gzip by default only. Not sure why brotli is disabled.

gzip takes short time, so the time it reduces networking time wins the time it takes compressing. But brotli only decreases file size a bit from gzip and takes much more time. So brotli is not suitable for on-the-fly compression.
It is recommended to turn on on-the-fly gzip. But for brotli, doing compression on-the-fly is not recommended and the compression should be done before hands.
(compression middleware does the on-the-fly compression)
About testing with precompressed file serving, I think this is out of scope of vite because vite core does not provide such feature (it is possible by plugin). So I think this should be covered with plugin using configurePreviewServer.

I agree with @sapphi-red too. Since this is only a preview server, it also won't correctly reflect the performance in production, e.g. files are served locally leading to faster server response time. Anything else would be done in configurePreviewServer too. Closing this for now.

It's enabled by default using this middleware. Looks like it enables gzip by default only. Not sure why brotli is disabled.

Gzip only would be fine. However, it does not seem to be enabled by default as you stated, otherwise I would not be opening this issue. So, is there a way to control this through configuration? The configurePreviewServer seems to be for plug-in authors.

I guess since you closed this before I got the answer I'll have to stick with Serve.
Thank you anyway.


CLI for creating templates with scaffolder

Feature Suggestion

Something like:
backstage-cli template --vars

Possible Implementation

Context
I want to run tests against my project to make sure that it works after templating. Like how you could with the cookiecutter CLI.
Originally https://github.com/backstage/backstage/issues/6568, it was closed prematurely in my opinion.
There's two main usecases I see.

Iterating while developing a template, https://github.com/backstage/backstage/issues/6568 likely helped with that
Continuous integration of a template, no great solution that I can see, maybe https://github.com/jeremyben/nunjucks-cli or one of it's forks can be used in the meantime.

Also relates to https://github.com/backstage/backstage/issues/11853 but this is a specific feature rather than a broader issue

Hmm, so we've looked at this before, and maybe the scope was a little too big. There was the idea of being able to run the entire template.yaml including custom actions from CLI, but that's a little tricky unfortunately, as you need all of the customActions, and templateFilters. Which is hard without having the whole source checked out too. So then we're left of the idea of calling a running Backstage instance and Scaffolder backend plugin but then I think it's going to be running untrusted template.yaml which can do anything so that's a big security implication and needs some thought.
If we were just to slim that down and basically offer a wrapper around nunjucks, we'd still need to have the ability to wrap up the additionalTemplateFilters somehow and be able to grab those which is kind of a similar problem to the whole custom actions part.

go away bot

Hello!  We also need this feature, because if we can not build templates locally it would be impossible to have an automation to test them

Noting briefly that this is partially blocked also by #15999

seriously...

@timja that should stop the stalebot :)

+1 - would make our end-to-end testing automation a lot simpler for one of our use cases at Adobe.

+1 Would make our template development a lot faster!

+1 once you have a significant amount of templates it takes forever to re-create them manually on a fresh environment - automation is the key and necessary - security will come on top of it

Yeah this is unfortunately still blocked by the upcoming work around authentication, specially CLI tokens that we can use to communicate with the running scaffolder-backend API to create jobs.
Should hopefully get around to starting some of this auth work early in the new year 🤞

I'm wondering why this needs authentication as from my point of view an ideal workflow wouldn't require a running backstage instance.
Ideally in the CI of a repository with templates I could just do a backstage-cli template --vars a=b to render the templates  and run some checks on the output afterwards.

@johanneswuerbach all the actions are defined in the scaffolder-backend. What you're asking for is basically a wrapper around the fetch:template action, which of course maybe useful on it's own, but if you're also defining things like additionalFilters they're not going to be available in the CLI without hitting a deployed instance.
Effectively, this CLI would dryRun a template for you, and then get you back the workspace output. So it solves a much broader use case than just fetch:template. It's going to run templates end to end, and be more respective of a real template rather than just an isolated bit. Does this make sense?

We solved this at volvo-cars by adding a yarn generate [template-name] command to our central software-templates repository.
Each template has a "test-data.json" file that is used when generating the template, to make it easier to run.
Each template also have a github action that renders the template and runs the application tests, ie for java it will run mvn test on each PR.
If this sounds like a good aproach, we could try and get our generate script into backstage-cli? Or do you prefer to wait for the auth changes.

Another +1 for this, would very much like to see this in place as it would greatly help testing Software Templates 👍

We solved this at volvo-cars by adding a yarn generate [template-name] command to our central software-templates repository. Each template has a "test-data.json" file that is used when generating the template, to make it easier to run. Each template also have a github action that renders the template and runs the application tests, ie for java it will run mvn test on each PR.
If this sounds like a good aproach, we could try and get our generate script into backstage-cli? Or do you prefer to wait for the auth changes.

do you share that code somewhere (generate [template-name]) ? the lack of a way to test templates is a pretty big blocker for us as well and such a workaround would really help us

We solved this at volvo-cars by adding a yarn generate [template-name] command to our central software-templates repository. Each template has a "test-data.json" file that is used when generating the template, to make it easier to run. Each template also have a github action that renders the template and runs the application tests, ie for java it will run mvn test on each PR.
If this sounds like a good aproach, we could try and get our generate script into backstage-cli? Or do you prefer to wait for the auth changes.

do you share that code somewhere (generate [template-name]) ? the lack of a way to test templates is a pretty big blocker for us as well and such a workaround would really help us

@awanlin @mryan43 we have just started working on a scaffolder-cli that we hope to contribute to the project 😄 Will get back to you when we have something that you can try out!!

Hi @SaraJendeberg, that's great! I highly recommend you attend one of the Scaffolder SIG meetings and speak with the Scaffolder maintainers to make sure your CLI aligns with their plans. I know the CLI modularization BEP is still in the PR phase and they have indicated that would be a blocker for any CLI work.

Hi @SaraJendeberg, that's great! I highly recommend you attend one of the Scaffolder SIG meetings and speak with the Scaffolder maintainers to make sure your CLI aligns with their plans. I know the CLI modularization BEP is still in the PR phase and they have indicated that would be a blocker for any CLI work.

Hi! @awanlin Thanks. Yes, it was mentioned in discord when we brought up the idea and it was suggested to start on a scaffolder-cli separately and merge.

Hi @SaraJendeberg, thanks for that link to the chat on Discord, that helps me out a lot. I know that a large portion of the Community would like this feature and I want to make sure it lands in a way that works well for everyone. Looks like Ben is good with this and he would know all the moving parts best. 🚀

@Rugvip @benjdlambert @awanlin I have created a PR here that I think covers everything you mentioned except from the scaffolder-cli login part.


Tools help on self-hosted agent shows an incorrect URL

When trying to use UsePythonVersion on a self-hosted agent with missing tools the log displays the following error message:

If this is a self-hosted agent, see how to configure side-by-side Python versions at https://go.microsoft.com/fwlink/?linkid=871498.

This URL redirects to the main Microsoft page, in my case https://www.microsoft.com/sv-se/?ref=go.
Agent version 2.168.2 is affected.

This looks like it has been corrected.


[menu] integrate elevation

dark theme design of menu miss elevation

All tough it is still using surface and not elevation- the ui problem was solved:
https://vivid.vonage.com/?path=/story/components-menu--with-vwc-list-item.


Patch 5.5 opcodes

I have trouble reading the log windows and how to find the opcodes. Could someone help with this?

Been trying to work it out myself, but i have no idea if i have the right codes, the tutorial could be clearer about what part of the responses in the log we are looking for

Made it for yall, but next time you can try to enable the option "Use All IPC Message Logger" and you will find it way easier
"ActorCast": "0x03c0",         "ActorControl": "0x03b5",         "ActorControlSelf": "0x03c0",         "AlwaysOnTop": false,         "GameServerIpRange": "<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/12,<IP_ADDRESS>/16,",         "GameServerPortRange": "10000,10001-65535",         "RequestUseAction": "0x03b0",         "ShowControlWindow": false,         "ShowLoggingWindow": false,         "SkillResultResponse01": "0x0204",         "SkillResultResponse08": "0x01c7",         "SkillResultResponse16": "0x032a",         "SkillResultResponse24": "0x035c",         "SkillResultResponse32": "0x0d20",         "UseHighLatencyMitigation": true,         "UseOpcodeFinder": false     }

Made it for yall, but next time you can try to enable the option "Use All IPC Message Logger" and you will find it way easier
"ActorCast": "0x03c0", "ActorControl": "0x03b5", "ActorControlSelf": "0x03c0", "AlwaysOnTop": false, "GameServerIpRange": "<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/12,<IP_ADDRESS>/16,", "GameServerPortRange": "10000,10001-65535", "RequestUseAction": "0x03b0", "ShowControlWindow": false, "ShowLoggingWindow": false, "SkillResultResponse01": "0x0204", "SkillResultResponse08": "0x01c7", "SkillResultResponse16": "0x032a", "SkillResultResponse24": "0x035c", "SkillResultResponse32": "0x0d20", "UseHighLatencyMitigation": true, "UseOpcodeFinder": false }

yeah i was trying, i got
		"ActorCast": "0x00b6",
		"ActorControl": "0x03b5",
		"ActorControlSelf": "0x03c0",
		"AlwaysOnTop": false,
		"GameServerIpRange": "<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/12,<IP_ADDRESS>/16,",
		"GameServerPortRange": "10000,10001-65535",
		"RequestUseAction": "0x03b0",
		"ShowControlWindow": true,
		"ShowLoggingWindow": true,
		"SkillResultResponse01": "0x0204",
		"SkillResultResponse08": "0x01c7",
		"SkillResultResponse16": "0x032a",
		"SkillResultResponse24": "0x035c",
		"SkillResultResponse32": "0x02c5",
		"UseHighLatencyMitigation": true,
		"UseOpcodeFinder": true

Made it for yall, but next time you can try to enable the option "Use All IPC Message Logger" and you will find it way easier
"ActorCast": "0x03c0", "ActorControl": "0x03b5", "ActorControlSelf": "0x03c0", "AlwaysOnTop": false, "GameServerIpRange": "<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/24,<IP_ADDRESS>/8,<IP_ADDRESS>/8,<IP_ADDRESS>/12,<IP_ADDRESS>/16,", "GameServerPortRange": "10000,10001-65535", "RequestUseAction": "0x03b0", "ShowControlWindow": false, "ShowLoggingWindow": false, "SkillResultResponse01": "0x0204", "SkillResultResponse08": "0x01c7", "SkillResultResponse16": "0x032a", "SkillResultResponse24": "0x035c", "SkillResultResponse32": "0x0d20", "UseHighLatencyMitigation": true, "UseOpcodeFinder": false }

Thank you, will give these a shot. I did enable the IPC thing but I am a little dumb at reading the log window

Updated the configuration in release file. Also, RequestUseAction2 would be 0x01a9.

howcome my config file didnt have requestuseaction2 in it?

It's pretty possible that I forgot to put it in the previous release file. It should work now!

It's pretty possible that I forgot to put it in the previous release file. It should work now!

cool I updated mine, thank you very much!

Actually download again, or edit ActorCast to 0x00b6. I copy and pasted wrong...


fix: add files property to restrict files in npm package

Adds files property to package.json
Addresses https://github.com/nearform/get-jwks/issues/213
This change adds a files property to package.json to restrict the files added to the published npm package/tar.

@simoneb how do I get this change published to npm?


NO-JIRA: Fix unit tests

What this PR does / why we need it:
Adds the Service type to a few unit tests that are failing since Service is now required in the API.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/hold
/lgtm

/hold cancel

/lgtm

/test e2e-aws-4-17


General QA fixes

Closes #427
Tooltip changes are being worked on in #407
Preview

Can't QA until we resolve the account issue I reported in slack.

JK. Created a separate account. tACK on #1-3 outlined in issue #427.


Use relative/full path instead of just file name

As a feature I'm used to coming from NvimTree, I often find it difficult to see exactly which directory I'm adding a file to (especially since it depends on whether my cursor is on a directory or a file). Is it possible to do something like below for the default prompt, where the "default" text can also be edited, to quickly add a file to a parent directory for example?
NvimTree:

neo-tree:

Sounds like a good idea. The question is: What happens if you edit that path so that the new file or directory is outside of the current working directory? If the new file is inside of the current directory, it will refresh and reveal that file in the tree. If it isn't, should we:

Just not be allow the action, make the root dir part of the prompt that is not editable.
Automatically re-root to make the new file/dir visible
Prompt you to change working directory or not
Do nothing other then echoing a success message

Oo those are some great points! I reckon everyone's gonna have their own preferences regarding this behaviour so it might be great to expose a config option for this creation-change-dir behaviour or something. Not sure if it's possible to distinguish between a complete working directory change (i.e. cd) and just changing the directory displayed (without affecting the current working directory).
Personally, I would prefer the directory view to be updated (so I can open the file if necessary), but my current working directory (controlled by a rooter plugin such as project.nvim) will be left as is. Not sure if you remember from my previous issues, but this is why I wanted specific behaviour when opening Neovim to a directory to display that directory, whilst my main neo-tree sidebar respects the cwd from the rooter plugin.

I actually did this a few days ago in the use-full-path-in-create-new branch but I haven't merged it because I don't think I like it. It seems confusing to have all of that extra text in my prompt.
I think I'll try some more options here. I'm thinking of making the path relative to the current working directory to make the path shorter, and a different highlight for the path as long as it is unedited.

Hmm maybe it would be nice for a user to select whether they want absolute, relative or no path in input display. Having a test with your branch, the absolute path makes sense for me since I use use_popups_for_input = false, but this is too chonky for popups.

I've adjusted the back-end code so that it can be configurable. The question now is what to name that option? Is this intuitive?
require("neo-tree").setup({
  include_path_in_add_command_prompt = "none" -- or "absolute" or "relative_to_root"
})

I can also just make separate commands for each variation:
require("neo-tree").setup({
  window = {
    mappings = [
      ["a"] = "add",
      --["a"] = "add_with_full_path",
      --["a"] = "add_with_relative_path",
    ]
  }
})

The latest version in this branch is using the relative path right now, but I think I'll go back to no path as the default. BTW - That branch was force pushed so you'll need to reset if you are just cloning the repo manually.

Love the changes!! 😍😍
Perhaps something like add_path_format is a bit simpler.

I just had another idea... Instead of adding all these different variations on builtin commands, and all of these separate config options that might affect commands, I should just add configuration directly to the mapping declarations, like so:
require("neo-tree").setup({
  window = {
    mappings = [
      -- simple version still works and uses default config:
      -- ["a"] = "add",
      -- or optionally use a more verbose syntax that adds config options:
      ["a"] = { "add", show_path = "none" },
      -- ["a"] = { "add", show_path = "relative" }
      -- ["a"] = { "add", show_path = "full" }
    ]
  }
})

That's actually a brilliant idea!! Will you use "full" instead of "absolute" though?

That's actually a brilliant idea!!
I'll go ahead and do that then. I don't think it should be all that complicated.

Will you use "full" instead of "absolute" though?
I'm not married to it. If you think absolute is more obvious I'll go with that.

Ahh ok. I reckon absolute path makes more sense conventionally than full path, especially with relative path as an options.

This has been added and the branch has been merged to main. I actually forgot that I already supported the table syntax for mapping-options, so I added a special config key to that syntax.
You can now specify your desired config like this:
    require("neo-tree").setup({
      window = {
        mappings = {
          ["a"] = {
            "add",
            nowait = true
            config = {
              show_path = "none" -- "none", "relative", "absolute"
            }
          },
        }
      }
    })

Thanks again for the amazing feature!


[SPARK-27410][MLLIB] Remove deprecated / no-op mllib.KMeans getRuns, setRuns

What changes were proposed in this pull request?
Remove deprecated / no-op mllib.KMeans getRuns, setRuns
mllib.KMeans has getRuns, setRuns methods which haven't done anything since Spark 2.1. They're deprecated, and no-ops, and should be removed for Spark 3.
How was this patch tested?
Existing tests.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9741/
Test PASSed.

Test build #104410 has started for PR 24320 at commit ac28a20.

Test build #104410 has finished for PR 24320 at commit ac28a20.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104410/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9746/
Test PASSed.

Test build #104415 has started for PR 24320 at commit af650df.

Test build #104415 has finished for PR 24320 at commit af650df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104415/
Test FAILed.

Test build #4698 has started for PR 24320 at commit af650df.

Test build #4699 has started for PR 24320 at commit af650df.

Test build #4699 has finished for PR 24320 at commit af650df.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

The "does not merge cleanly" error is spurious and I'm sure this can't affect any logic; the methods are unused and no-ops. Merging to master