Clarification of datamodel for metadata

We currently have the following data model for a described Identifier, which has a label and uri.
label: string
uri: string

However, we are using the Uri field to provide a link out from the user interface. Should this be set as a URL instead? This would enable us to use the isURL validator built into the framework

For example, the following is acceptable as a Uri, but we would need to recognize that it is taxon and maintain a mapping.
label: Homo Sapiens
identifier: NCBI:txid9606

Instead, we could require that the property be a URL like follows:
label: Homo Sapiens
identifiers:  https://identifiers.org/taxonomy/9606

Good point. I overlooked this important detail.
RDF uses URIs. URIs just need to be unique. They don't necessarily have to be resolvable as URLs. Furthermore, its ok for a URI to look like a URL, but not actually point to a resolvable address. As a result, we can't use a regular expression pattern to detect which URIs are URLs; we'd have to make HTTP requests to the URI to determine whether its resolvable. This is something we could validate, but we'd have to submit jobs to do this validation since it could take some time.
As a result, in the general case, we can't equate URIs and URLs.
One partial solution is to recognize some specific patterns of URI as URLs such as below. I don't love this because it would be limited to specific patterns that we enumerate.

Things that begin with https://github.com, https://identifiers.org, etc.

One alternative is to recommend that OMEX metadata files explicitly define a URL for each URI (and then parse this information out). This could be similar to how we're recommending users put human-readable labels into metadata files because we don't know how to resolve this information in the general case. This would also provide flexibility to users to point to useful information about a URI rather than to the official definition of the URI. For example, a KiSAO term could be directed to an OLS page for the term, rather than http://www.biomodels.net/kisao/KISAO#KISAO_0000064, which redirects to the less helpful https://raw.githubusercontent.com/SED-ML/KiSAO/deploy/kisao.owl#KISAO_0000064.
Thoughts on this?
For now, I think we can equate URIs with URLs, getting the platform working, and then come back and refine this.

I agree with the recommendation of always providing resolvable URLs in the metadata file. Perhaps we can go a little bit further with our recommendation and specify that the URL be from identifiers.org? Then we can treat anything that starts with identifiers.org as a URL, or otherwise as a URI.
https://identifiers.org/biomodels.kisao:KISAO_0000057 for example points to the more useful bioportal page. Are there currently any identifiers that we are using for the "curated" list of metadata fields that do not have identifier.org ids?
For the "custom" metadata fields, we can include both a URL and URI field. I feel that a centralized mapping for the whole file would be harder to maintain that adding them to each term individually

Perhaps we can go a little bit further with our recommendation and specify that the URL be from identifiers.org?

Yes, I've already tried to steer URIs to identifiers.org where possible. This has the additional advantage of being able to use identifiers.org to validate ids (against regular expression patterns registered with identifiers.org). BioSimulators-utils is already doing this. I meant to put a recommendation for identifiers.org in the documentation (https://biosimulators.org/conventions/metadata).
Unfortunately, not everything we want to use is registered with identifiers.org. One option is to ask our EBI collaborators to register additional namespaces which we don't own.

GitHub: links to repos
Linguist: programming languages
SIO
FunderRegistry
Physiome model repository
SED-ML URNs

I separated creating additional identifiers.org prefixes to #2766

One possibility for github repos is to have a DOI assigned. For example we have https://identifiers.org/doi:10.5281/zenodo.5057108
for this repo

I got identifiers.org prefixes approved for all of the above.
Here's a GitHub example: https://identifiers.org/github/biosimulations/biosimulations
I think identifiers.org is simpler because it doesn't require the submitter to register their repo with zenodo. Of course, Zenodo can still be used to save a snapshot of something.

Oh that's great. I did not realize that you could register a prefix  for an organization that you don't own. Using the GitHub prefix directly is definitely much better and simpler.

I wasn't sure either. They approved it. They have a webform. Its easy to request more if needed.
Identifiers.org mainly keeps track of the owner of the namespace (e.g., GitHub Inc), rather than the person who submitted the namespace request.


Changes on expired subscription shoul be disabled

Version Info
the version of your demo system, 8th of May 2019
Describe the bug
If I try to modify the configuration of a subscribed service which has already expired, there is no warning, nothing is disabled on the UI and the status of the service shows still ready.
It seem like everything is ok until I press the SAVE button, then I get an error message telling me that teh service has been deactivated due to expiration.
How to Reproduce
Steps to reproduce the behavior:

Go to 'account/subscriptions/edit service/configuration'
Perform same changes
Scroll down to 'SAVE button'
See error (subscription should be expired!)

Observed behavior
A clear description of what was observed to happen.
Expected behavior
It would be better to prevent users from doing useless things like modifying a deactivated service. The status should be adjusted accordingly.
Screenshots
If applicable, screenshots to help explain your problem.
Additional context
Any other context about the problem here.

Hi @cklitscher
I fully agree. Actually, there is an expiration handler that is invoked by a timer and that is supposed to clean up those expired subscriptions.
According the design, the subscription is expected to be removed from the marketplace. On event of expiration, an email should be sent out to the customers with respective termination notice. For technology managers the expired subscriptions are still accessible in the administration portal. The experation details are also shown there.
Well, probaly this handler has has failed at some point. We will check this deeper and find if this can be fixed quickly.

Hello @cklitscher
Unfortunately, we can not reconstruct the error you described. Is it possible that you send us more information?
In our case, OSCM do what is your expected behavior (see the screenshot).

@cklitscher
Thanks for your feedback. After revisiting your issue description I came to wonder if this really was an expiration use case you have digged in here. As long as the subscription is editable and in ready state, it seems to me that it hasn't expired. Are you sure the subscription should be in such state? Did you specify a number for "Number of days after which the subsription will be deactivated"? Please also note that this platform parameter is available only for services with access type 'login'.
Does the issue still persist?

Dear Lorenz,
I did enter a value of 1 day into „Number of days…” field, and the problem arrised after a period of more than 24 hours. But I will check again when I will work with OSCM next time, I will keep you updated…
Best Regards,
Christian
From: Lorenz Goebel<EMAIL_ADDRESS>Sent: Friday, May 17, 2019 5:39 PM
To: servicecatalog/oscm-app-shell<EMAIL_ADDRESS>Cc: Klitscher, Christian<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [servicecatalog/oscm-app-shell] Changes on expired subscription shoul be disabled (#67)
@cklitscherhttps://github.com/cklitscher
Thanks for your feedback. After revisiting your issue description I came to wonder if this really was an expiration use case you have digged in here. As long as the subscription is editable and in ready state, it seems to me that it hasn't expired. Are you sure the subscription should be in such state? Did you specify a number for "Number of days after which the subsription will be deactivated"? Please also note that this platform parameter is available only for services with access type 'login'.
Does the issue still persist?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/servicecatalog/oscm-app-shell/issues/67?email_source=notifications&email_token=AJSV7IRUA47MPAXC76BVIQDPV3GTDA5CNFSM4HLRWMXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVDJ4Q#issuecomment-493499634, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSV7IUZ2NIY25EZJLODUTTPV3GTDANCNFSM4HLRWMXA.


Unify OS detection logic between Grpc.Core.PlatformApis and Grpc.Tools

Tentative fix for https://github.com/grpc/grpc/issues/24529.
also unify the ways OS is detected (mostly under .NET Framework, under .NET Core it's very straightforward).

Adhoc package build: https://g3c.corp.google.com/results/invocations/ad8d91cb-5598-4c9b-9980-49b1944b206e/targets (will post results later)

@tmarkovski Can you please test the adhoc build of Grpc.Tools on MacOS big sur and confirm it works?
https://storage.googleapis.com/grpc-testing-kokoro-prod/test_result_public/prod/grpc/core/master/linux/grpc_build_packages/14742/20201116-102419/github/grpc/artifacts/Grpc.Tools.2.34.0-dev202011161834.nupkg
(I am optimistic due to your comment https://github.com/grpc/grpc/issues/24529#issuecomment-728166376).

Based on https://github.com/grpc/grpc/issues/24529#issuecomment-728166376 there's a good change this PR will fix the issue and the unification of the platform detection logic is useful in itself.
I'm going to process and merge.
@tmarkovski getting a confirmation would still be useful.

@jtattermusch Apologies, yes the fix works with the package you submitted.


L.DomEvent.disableScrollPropagation returns nothing

How to reproduce

Leaflet version I'm using: 1.1.0
Browser (with version) I'm using: Chrome Version 59.0.3071.109
OS/Platform (with version) I'm using: Mac OS X 10.11.6

I came across this problem when using a modified version the Rrose Plugin.
I reduced the code as much as possible for a reproduction example:
http://playground-leaflet.rhcloud.com/bijew/edit?html,console,output
The part of the code that causes the Problem is this:
L.DomEvent
    .disableClickPropagation(wrapper)
    .disableScrollPropagation(this._contentNode)
    .on(wrapper, 'contextmenu', L.DomEvent.stopPropagation);

Changing it to
L.DomEvent
    .disableClickPropagation(wrapper)
    .disableScrollPropagation(this._contentNode);
L.DomEvent.on(wrapper, 'contextmenu', L.DomEvent.stopPropagation);

fixes the Problem.
Prior to 1.1.0 this worked and the Documentation states that disableScrollPropagation should return this (which should be L.DomEvent).

Looks like we missed a return this during the rewrite to ES2015 modules, see https://github.com/Leaflet/Leaflet/blob/v1.1.0/src/dom/DomEvent.js#L182 and disableClickPropagation a few lines below.
This looks like an easy fix. @Eschon would you like to submit a pull request?

@IvanSanchez Thanks for the quick reply!
Sure I can try to make a PR.

Thanks for the PR :-D
I think there is a bigger issue here - in a ES2015 module, this doesn't have any meaning as far as I recall. Chaining stuff will not be possible using modules :-/

@IvanSanchez not sure I follow - when do we / would we want to chain using modules? Chaining seems to me to be something you do with an object's methods, where this has meaning, but I guess I'm missing some possible new feature here?
Anyway, I hope it's ok to close this and open a new issue if module chaining (or the lack of it) is something we need to discuss further.

@IvanSanchez disregard my comment above. Reviewing #5601, it dawned on me what you mean, since DomEvent is not really a class any more, but actually a module with exported functions. This is indeed something to think about going ahead.

https://github.com/yafred/leaflet-responsive-popup
This issue breaks responsive.popup plugin.


Inline QPDFObjGen methods

ABI breaking change

A 3% to 4% improvement is a pretty big deal, so this is definitely worth it. I had some slight hesitation over QUtil.hh being included since this basically means it's going to be included everywhere, but a quick inspection of the code revealed that nothing that includes QPDFObjGen.hh doesn't also include QUtil.hh.


feature request: shard size in stats

would be nice to see a file size vs. having to stat file in file system

We report disk bytes in the shard stats now. Closing this issue.
> show stats for 'shard'
name: shard
tags: database=stress, engine=tsm1, id=1, path=/Users/mr/.influxdb/data/stress/autogen/1, retentionPolicy=autogen, walPath=/Users/mr/.influxdb/wal/stress/autogen/1
diskBytes fieldsCreate seriesCreate writeBytes writePointsDropped writePointsErr writePointsOk writeReq writeReqErr writeReqOk
--------- ------------ ------------ ---------- ------------------ -------------- ------------- -------- ----------- ----------
46885120  173990       80000        0          0                  0              1600000       160      0           160

name: shard
tags: database=test, engine=tsm1, id=4, path=/Users/mr/.influxdb/data/test/autogen/4, retentionPolicy=autogen, walPath=/Users/mr/.influxdb/wal/test/autogen/4
diskBytes fieldsCreate seriesCreate writeBytes writePointsDropped writePointsErr writePointsOk writeReq writeReqErr writeReqOk
--------- ------------ ------------ ---------- ------------------ -------------- ------------- -------- ----------- ----------
97        1            1            0          0                  0              1             1        0           1

name: shard
tags: database=test, engine=tsm1, id=5, path=/Users/mr/.influxdb/data/test/autogen/5, retentionPolicy=autogen, walPath=/Users/mr/.influxdb/wal/test/autogen/5
diskBytes fieldsCreate seriesCreate writeBytes writePointsDropped writePointsErr writePointsOk writeReq writeReqErr writeReqOk
--------- ------------ ------------ ---------- ------------------ -------------- ------------- -------- ----------- ----------
93        1            1            0          0                  0              1             1        0           1


Build Failure when upgrading to Latest Shopify API

Issue summary
After upgrading from Shopify API 8.1.1 to 9.7.1, the following errors occur while building the application.
node_modules/@shopify/shopify-api/runtime/crypto/crypto.d.ts:1:23 - error TS2688: Cannot find type definition file for '@cloudflare/workers-types'.

1 /// <reference types="@cloudflare/workers-types" />

node_modules/@shopify/shopify-api/runtime/http/types.d.ts:1:23 - error TS2688: Cannot find type definition file for '@cloudflare/workers-types'.

1 /// <reference types="@cloudflare/workers-types" />

However, no issues with "npm run dev". The application runs without any issues.

[x] Upgraded to the latest version of the relevant packages

"@shopify/shopify-api": "^9.7.1"
"@shopify/shopify-app-express": "^4.1.1"
"@shopify/app": "^3.58.2"
"@shopify/cli": "^3.58.2"
Node version: 18.8.2
Operating system: Windows 10

Are there any changes needed when upgrading to the latest version? We could not find any documentation for the same,

Hi there 👋
Could you share what your package.json looks like?

I've attached the package.json file below. Kindly let me know if you need anything else. Thanks!
package.json

They seem to break everything every time they upgrade their libraries. Look at their libraries, its barely production grade.

I upgraded to 9.7.2 and this issue is not found now. But from the changes, I could not see what fixed this.


Azure AD B2C Application redirect url edit failure issue once the app is deleted and restored

Customer accidentally deleted their B2C app registration, and upon restoring when they try to edit the Redirect url getting internal sever error. When we do the process in Azure AD tenant it works as expected.

Steps to reproduce the issue.

Create a new application and any redirect url (permission/scopes optional)

Deleted the created application
Restore the deleted application with below commands
Get-AzureAdDeletedApplication
Restore-AzureADDeletedApplication  -ObjectId  ****
After restoring successfully try to update the existing redirect url

When we do the same process in the Azure AD tenant it work fine and able to edit the urls in restored app.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 670bf490-966b-e72e-ab6c-1d189f9a1f58
Version Independent ID: a55b7372-87e9-c760-1a37-57728171395d
Content: Tutorial: Register an application - Azure AD B2C
Content Source: articles/active-directory-b2c/tutorial-register-applications.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@raghava1147
Thanks for your feedback! We will investigate and update as appropriate.

@raghava1147
Thank you for your time and patience!
I was able to reproduce your issue and have reached out to our PG teams regarding this potential bug.

@raghava1147
Since you're internal, I've looped you into an email with our PG teams and we'll continue working through this bug using the ICM I linked.
Thank you for your time and patience!


Add skeletal "user profile" section to DG

Close #54
Adds a skeleton to the corresponding sections of the DG. Will be updated soon.

Codecov Report

Merging #93 (78ac81b) into master (3b59107) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #93   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


model_history -> save_best_model_per_estimator

if save_best_model_per_estimator is False and retrain_final is True, unfit the model after evaluation in HPO.
retrain if using ray.

User need to specify save_best_model_per_estimator in every test; redundant?

Not every test. Only if you need to save the best model per estimator.


Merge missing changes in master to dev

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

/area rules

/area deployment

/area integrations

/area examples
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Mistakenly merge to master in #511, make sure things are now on dev

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

e00181d Merge pull request #174 from draios/dev
d1b6b2b Merge pull request #229 from draios/dev
b0ae29c Merge branch 'dev'
809d20c Merge pull request #246 from draios/dev
74556e5 Merge branch 'dev'
e8aee19 Merge remote-tracking branch 'origin/dev', 0.8.1
3ee7663 Merge branch 'dev'
94df00e Merge branch 'dev'
2a0911d Merge branch 'dev'
b496116 Don't make driver compilation fail when kernel is compiled with CONFIG_ORC_UNWINDER or CONFIG_STACK_VALIDATION. (#362)
6acb13e Merge branch 'dev'
4707103 Merge remote-tracking branch 'origin/dev'
5e38f13 Merge remote-tracking branch 'origin/dev'
ff299c1 Merge remote-tracking branch 'origin/dev'
bd7a973 Merge branch 'dev'
ddf55d3 Merge remote-tracking branch 'origin/dev'
62c1a04 Merge remote-tracking branch 'origin/dev'
44e88f2 Merge remote-tracking branch 'origin/dev'
e546555 fix k8s install issue (#506)
f4b0b3c falco.yaml: change default program_output action (#507)
36a095c Merge remote-tracking branch 'origin/dev'
db41945 Merge remote-tracking branch 'origin/dev'
807c00b Merge remote-tracking branch 'origin/dev'
ff376d3 Merge remote-tracking branch 'origin/dev'
194a017 Merge remote-tracking branch 'origin/dev'
75b816d Merge remote-tracking branch 'origin/dev'
670736d Merge remote-tracking branch 'origin/dev'

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mstemm
If they are not already assigned, you can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kaizhe: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.
In case you do not know which kind this proposal is please mention the maintainers using @team/maintainers.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Closing for now, will discuss the best way to handle merged to master offline.


Group the request and report the call-chain by the request group.

Which module is your feature request related to?
ALL
Is your feature request related to a problem?
NO
Describe the solution you'd like
I found that the requests are grouped by the business in some apm product for example the dynatrace.
For example when the target app is based on spring mvc.
The requests are grouped by the handler methods which has RequestMapping annotations.
And report the call-chain data by the group.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

hi guys, I am a java developer and I am interested in pinpoint. If pinpoint plan to accept my suggestion, I can contribute my code. thanks guys.  looking forward for your final decision.

@xiaoshao Hi
I do not know what call-chain means.
Does this feature mean URL statistics?
Example Screenshot
https://github.com/slanatech/swagger-stats/raw/master/screenshots/methods.png?raw=true

sorry, we named the call stack in pinpoint with call-chain.
Yes, I suggest to group the call stack with URL statistics.
For example there is some code in the Spring MVC as following.
@Controller
public class SecondController {

    @GetMapping("/address/{name}")
    @ResponseBody
    public List<String> address(@PathVariable("name") String name) {
        List<String> address = new ArrayList<>();
        address.add("first");
        address.add("second");
        return address;
    }
}

We can group the callstack all the request which is handled by the annotation of the method address, even more we can report the callstack by this to avoid that some handler is missed.
what do you think about it.

We welcome your suggestions
I agree with your idea.
We have plans to aggregate statistical data into the RequestMapping annotations,
but we do not have enough time to develop.
Below is our idea.

Use RequestMapping annotation.
    - When using real url, it is difficult to aggregate rest style url
       - eg: /book/{id}/
Unable to handle annotation in bytecode api
   - We will add API.

If the annotation data can be extracted to the runtime, API addition is unnecessary

Aggregation plan
    1. agent memory
    2. collector
      - Use the Table.incrementColumnValue() API of hbase
    3. flink
    Not determined
  4. Data type
    1. Histogram
        - Counts 1s, 3s, 5s
     2. total reponse time
    Not determined


continue-examples options

Provide an option to continue example lists from one source to another

Just to note that it needs to handle the references to the examples too.

Mmmm that won't be possible, unfortunately. See the json:
{"pandoc-api-version":[1,22],"meta":{},"blocks":[{"t":"OrderedList","c":[[1,{"t":"Example"},{"t":"TwoParens"}],[[{"t":"Plain","c":[{"t":"Str","c":"This"},{"t":"Space"},{"t":"Str","c":"is"},{"t":"Space"},{"t":"Str","c":"a"},{"t":"Space"},{"t":"Str","c":"good"},{"t":"Space"},{"t":"Str","c":"example."}]}]]]},{"t":"Para","c":[{"t":"Str","c":"As"},{"t":"Space"},{"t":"Str","c":"(1)"},{"t":"Space"},{"t":"Str","c":"illustrates,"},{"t":"Space"},{"t":"Str","c":"…"}]}]}

The reference @good has already been converted to (1). The problem is that numbered lists don't have identifiers. The only thing the AST has is the type (Example) and the starting number (1). Hopefully that's fixed in future versions of the AST, there's talk of allowing identifiers to any/most elements.
Given this, not sure it's worth implementing the option.

I think that's right.
For reference, it might be possible to get such lists by using this instead of Pandoc's support for examples: https://github.com/cysouw/pandoc-ling.

Yes this is much better.
One use for numbered examples in a Dialectica paper was for someone who had continuously numbered items throughout their paper, where the items where sometimes several blocks long (including a table, an indentend argument, and the like!). It kind of almost works with numbered examples (though it looks as if we've got a blank line where the item starts with a Div). I wonder if pandoc-ling (and whatever LaTeX it uses) can handle that too, or is restricted to one-block items. If yes we might use it instead of Pandoc's internal mechanism in all cases.


Custom model binder not triggered after 1.1 update

Hi, as stated in the title, my custom model binder stopped working after updating to core 1.1. I couldn't find any anouncement for changes on model binding, am I missing a new package or something?
Here is my startup file :
services.AddMvc(options =>
{
   options.Filters.Add(new AuthorizeFilter(defaultPolicy));
   options.ModelBinderProviders.Insert(0, new TemplateSectionModelBinderProvider());
});

Thanks!

I have two custom binders and they continued working with 1.1.
So probably it is a problem in the implementation of either your specific Provider or your specific ModelBinder that creates the problem. Add a breakpoint in the provider to verify it is called, and if ita actually returns your binder, or for if for some reason it aborts its normal path.

I was probably not specific enough : as soon as I update the packages to their 1.1 version, the model binder does not get called at all. Breakpoints do not trigger in the provider neither.

My model binders are part of a library so I add them  after services.AddMvc(.. with a services.AddMy Library() So I add them with :
services.AddTransient<IConfigureOptions<MvcViewOptions>, MyCustomSetup>();
public class MyCustomSetup: IConfigureOptions<MvcOptions>
    {
        public void Configure(MvcOptions options)
        {
          ....

Try the same, maybe putting them in AddMvc is to early and the option object has not been already populated with the "standard providers". So when they are populated the collection is preliminarly cleared.
This is the only explanation coming to my mind...since my software works properly also with 1.1

@pierre-weceipt can you share more of your app? Or perhaps upload it to GitHub so we can take a look? We're not aware of any changes in this area that could cause this.

As migrating to 1.1 was not a priority for us I delayed dealing with the issue. After runing more tests the model binder is now correctly called (I don't know what changed since before holidays). What is surprising is that I detected an issue that should have prevented the binder to work before but was not..
One last thing is strange though, the project can run but VS and CLI is telling me packages can't be restored. Here is the message :
log  : Restoring packages for tool 'Microsoft.VisualStudio.Web.CodeGeneration.Tools' in C:\Users\Pierre\Documents\Visual Studio 2015\Projects\nao\src\Thelos.NAO\project.json...
error: Package Microsoft.Composition 1.0.27 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package Microsoft.Composition 1.0.27 supports: portable-net45+win8+wp8+wpa81 (.NETPortable,Version=v0.0,Profile=Profile259)
error: One or more packages are incompatible with .NETCoreApp,Version=v1.0.

my global.json :
{
  "projects": [ "src", "test" ],
  "sdk": {
    "version": "1.0.0-preview2-1-003177"
  }
}

and my project.json :
{
  "buildOptions": {
    "emitEntryPoint": true,
    "preserveCompilationContext": true
  },

  "dependencies": {
    "Microsoft.AspNetCore.Authentication.Cookies": "1.1.0",
    "Microsoft.AspNetCore.Diagnostics": "1.1.0",
    "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore": "1.1.0",
    "Microsoft.AspNetCore.Identity.EntityFrameworkCore": "1.1.0",
    "Microsoft.AspNetCore.Mvc": "1.1.0",
    "Microsoft.AspNetCore.Server.IISIntegration": "1.1.0",
    "Microsoft.AspNetCore.StaticFiles": "1.1.0",
    "Microsoft.EntityFrameworkCore": "1.1.0",
    "Microsoft.EntityFrameworkCore.Design": "1.1.0",
    "Microsoft.EntityFrameworkCore.SqlServer": "1.1.0",
    "Microsoft.EntityFrameworkCore.SqlServer.Design": "1.1.0",
    "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.1.0",
    "Microsoft.Extensions.Configuration.Json": "1.1.0",
    "Microsoft.Extensions.Configuration.UserSecrets": "1.1.0",
    "Microsoft.Extensions.Logging": "1.1.0",
    "Microsoft.Extensions.Logging.Console": "1.1.0",
    "Microsoft.Extensions.Logging.Debug": "1.1.0",
    "Microsoft.Extensions.Options.ConfigurationExtensions": "1.1.0",
    "Microsoft.VisualStudio.Web.BrowserLink.Loader": "14.1.0",
    "Microsoft.VisualStudio.Web.CodeGenerators.Mvc": "1.1.0-preview4-final",
    "Microsoft.WindowsAzure.ConfigurationManager": "3.2.3",
    "ncalc": "1.3.8",
    "Newtonsoft.Json": "9.0.1",
    "Sendgrid": "8.0.5",
    "WindowsAzure.Storage": "8.0.0"
  },

  "tools": {
    "Microsoft.AspNetCore.Razor.Tools": "1.1.0-preview4-final",
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": "1.1.0-preview4-final",
    "Microsoft.EntityFrameworkCore.Tools": "1.1.0-preview4-final",
    "Microsoft.Extensions.SecretManager.Tools": "1.1.0-preview4-final",
    "Microsoft.VisualStudio.Web.CodeGeneration.Tools": "1.1.0-preview4-final"
  },

  "frameworks": {
    "net461": { }
  },

  "publishOptions": {
    "include": [
      "wwwroot",
      "Views",
      "appsettings.json",
      "web.config"
    ]
  },

  "scripts": {
    "prepublish": [ "npm install", "bower install", "gulp clean", "gulp min" ],
    "postpublish": [ "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%" ]
  }
}

What is surprising is that I detected an issue that should have prevented the binder to work before but was not..

As a follow up, in my view
@{
    var ModelType = @Model.GetType().FullName;
}
<input asp-for="@ModelType" type="hidden" />

is generating with 1.0.1
<input name="Type" id="Type" type="hidden" value="RatioContentBlock">

and for 1.1
<input name="ModelType" id="ModelType" type="hidden" value="RatioContentBlock">

So I had to change a line in the binder to catch ModelType instead of Type

@pierre-weceipt generating the name / id "Type" with 1.0.1 looks like a straight-up bug. Alternatively, something else changed in your app when updating to the 1.1.0 packages. (It's not clear where MVC could get that name.)
Are you suggesting there's a problem with the new HTML?

@dougbu no, the only change is that now the name is correctly ModelType instead of previously Type. I think it was a bug in 1.0.1, as I understood razor should be using the var name for input name but was changing ModelType in Type (the previous code was all in a razor view).
But this part is fine for me now, I just had to change a string in my model binder to match the new var name. I'm more interested in understanding why the cli is launching the error message but project is still managing to launch.

Since expression like @Model.MyProperty must generate names like  MyModel,  prefix "Model." is removed, probably in 1.0.1 also "Model" prefix were errously removed in some circumstances (I suspect when there are no dots in the total name)

@pierre-weceipt we would like more info to try and reproduce the problem. Can you show the implementation of your model binder and provider?
@dougbu can you start taking a look at this?

@Eilon here is my code :
The model binder :
using Microsoft.AspNetCore.Mvc.ModelBinding;
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using Thelos.NAO.Models.Templates.AccountingTables;
using Thelos.NAO.Models.Templates.Sections.Conditions;
using Thelos.NAO.Models.Templates.Sections.ContentBlocks;

namespace Thelos.NAO.Binders
{
    public class TemplateSectionModelBinder : IModelBinder
    {
        private readonly IModelMetadataProvider _metadataProvider;
        private readonly Dictionary<string, IModelBinder> _binders;

        public TemplateSectionModelBinder(
            IModelMetadataProvider metadataProvider,
            Dictionary<string, IModelBinder> binders
            )
        {
            _metadataProvider = metadataProvider;
            _binders = binders;
        }

        public async Task BindModelAsync(ModelBindingContext bindingContext)
        {
            var typeResult = bindingContext.ValueProvider.GetValue(bindingContext.ModelName + ".Type");
            if (typeResult == ValueProviderResult.None)
            {
                bindingContext.Result = ModelBindingResult.Failed();
                return;
            }

            IModelBinder binder;
            if (!_binders.TryGetValue(typeResult.FirstValue, out binder))
            {
                bindingContext.Result = ModelBindingResult.Failed();
                return;
            }

            // Now know the type exists in the assembly.
            var type = Type.GetType(typeResult.FirstValue);

            if (!typeof(ContentBlock).IsAssignableFrom(type) && !typeof(Condition).IsAssignableFrom(type) && !typeof(Row).IsAssignableFrom(type)
                || (!typeResult.FirstValue.StartsWith("Thelos.NAO.Models.Templates") && !typeResult.FirstValue.StartsWith("Thelos.NAO.Models.AccountingTables")))
            {
                throw new InvalidOperationException("Bad Type");
            }

            var metadata = _metadataProvider.GetMetadataForType(type);
            var model = Activator.CreateInstance(type);
            var result = bindingContext.Result;
            bindingContext.Model = model;

            using (bindingContext.EnterNestedScope(
                metadata,
                bindingContext.FieldName,
                bindingContext.ModelName,
                model: model))
            {
                await binder.BindModelAsync(bindingContext);
            }

            bindingContext.Result = ModelBindingResult.Success(model);
            return;
        }
    }
}

and the provider
using Microsoft.AspNetCore.Mvc.ModelBinding;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;
using Thelos.NAO.Models.Templates.AccountingTables;
using Thelos.NAO.Models.Templates.Sections.Conditions;
using Thelos.NAO.Models.Templates.Sections.ContentBlocks;

namespace Thelos.NAO.Binders
{
    public class TemplateSectionModelBinderProvider : IModelBinderProvider
    {
        public IModelBinder GetBinder(ModelBinderProviderContext context)
        {
            if (context == null)
            {
                throw new ArgumentNullException(nameof(context));
            }

            if (context.Metadata.ModelType == typeof(ContentBlock) || context.Metadata.ModelType == typeof(Condition) || context.Metadata.ModelType == typeof(Row))
            {
                var binders = new Dictionary<string, IModelBinder>();
                foreach (var type in typeof(TemplateSectionModelBinderProvider).GetTypeInfo().Assembly.GetTypes())
                {
                    var typeInfo = type.GetTypeInfo();
                    if (typeInfo.IsAbstract || typeInfo.IsNested)
                    {
                        continue;
                    }

                    if (!(typeInfo.IsClass || typeInfo.IsPublic))
                    {
                        continue;
                    }

                    var metadata = context.MetadataProvider.GetMetadataForType(type);
                    var binder = context.CreateBinder(metadata);
                    binders.Add(type.FullName, binder);
                }

                return new TemplateSectionModelBinder(context.MetadataProvider, binders);

            }
            return null;
        }
    }
}

declared in the startup file
services.AddMvc(options =>
             {
                options.ModelBinderProviders.Insert(0, new TemplateSectionModelBinderProvider());
            });

the views contain
@{
    var ModelType = @Model.GetType().FullName;
}
<input asp-for="@ModelType" type="hidden" />

@pierre-weceipt it's still not clear how your model binder could work. The view should submit the type in a field named ModelType and the binder is looking for Type. Have you updated your binder to expect the correct name?
If the field name is not the problem, have you debugged and found the provider or binder is not invoked at all?

@dougbu I agree with you, this shouldn't work, yet it does. Razor is generating the field as 'Type' instead of 'ModelType' when in 1.0.x (this code is for 1.0.x).
However it seems that it is solved in 1.1 and I had to change the model binder to listen to 'ModelType' as it should have since the beginning.

@pierre-weceipt I'd appreciate a small repro for the problem in 1.0.x. Do you still have a sample showing the wrong name generation? Ideal is a small project in a public GitHub repo.

@dougbu Here is the project, page "Bug" in the navbar.

I've confirmed this issue and found it repros when using HTML helpers, including HTML helpers in MVC 5.2.3. Surprised nobody found the issue before; problem has been in the code forever.
Bug is an overly-accepting StartsWith() in ExpressionHelper, line 105. ASP.NET Core MVC 1.0.2 code shown below as well.
Problem does not repro in MVC 1.1.0-preview1 and later because we rewrote ExpressionHelper. The new lastIsModel approach uses string.Equals() instead.
if (text.StartsWith(".model", StringComparison.OrdinalIgnoreCase))
{
    // 6 is the length of the string ".model".
    builder.Remove(0, 6);
}

Updated issue title and cleared labels other than bug.
@Eilon I'm torn on this one. It can be worked around with new variable names and it appears our customers haven't been impacted over the years. On the other hand, the generated names break model binding, there's no indication where the problem lies, and the fix is simple.
Either way, let's do this all-or-nothing: If we patch Core 1.0.x, I suggest we also patch 5.2.4.

Proposing this for next 1.0.x patch. But is not an issue in 1.1.x.

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

fa710e6 in rel/1.0.3
cherry-picked test changes as a5c7a7e into dev
did not merge rel/1.0.3 branch into dev because this product code change does not apply and branches have diverged significantly


Add blog article “Init Containers”

Hi @OualidZejli, just checking in -- have you gotten a chance to read the article that @sftim suggested and consider some revisions to this post?

Hi @OualidZejli, as this article needs to be more in-depth for the Kubernetes site, and we have not had any follow-up, I will close this PR.
Please keep writing, and if you revise this article, please feel free to open a new PR.
/close


Update README.md to include 3 books

Hi,
I was wondering if you would consent to adding 3 books to your book list, all from Manning Publications: Spark in Action, Kafka Streams in Action, and Big Data. I believe that they are appropriate for your list.
Thank you for your consideration.

Thanks!


[QUESTION] developing on mac with torch > 2.0.0

❓ Questions and Help
I installed Comet from source successfully on Linux with pip install .
On MacOS (for local development), I got the following errror:
ERROR: Could not find a version that satisfies the requirement torch<2.0.0,>=1.6.0 (from unbabel-comet[dev]) (from versions: 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.4.0)
ERROR: No matching distribution found for torch<2.0.0,>=1.6.0

Could I install torch>2.0.0 and use it with Comet?
I am using torch 2.1.1 on my MacBook with an M2 chip without any problems

probably my bad ... I haven't used the latest master


types/known: one home for the WKTs (Well Known Types)

How are the .pb.go files going to end up in one home.
Continuing this discussion in https://github.com/golang/protobuf/issues/143
Ok so the idea is that all the code generated in ptypes will move to https://github.com/google/go-genproto
So each user of proto3 wkts will now also have to import this new package.
Also unlike ptypes which has each proto and pb.go in its own package go-genproto has all the protos and .pb.go files in one package called protobuf.
What is the eventual plan for this?
Is moving all these pb.go files into one home really depending on this very contentions issue:
https://golang.org/issue/16339
Or is there a backup plan?
What would you have done if you could have done this from scratch?

Adding type aliases is not a hard blocker for moving WKT to one home, but it certainly would help.  I mention it to raise awareness of the problems it solves.  If we had type aliases, instead of rolling out one breaking change after six months of announcement (as per our new compatibility promise), we could make the announcement and folks could migrate their import paths well ahead of the deadline and not face issues.  Both options have their own tradeoffs.
An alternative approach would be to just add the generated protos in go-genproto repo — this would mean they exist in both places.  This would be unfortunate because if part of a large codebase uses the type as it exists in go-genproto and another part of a large codebase uses the type as it exists in ptypes, the types would not be interoperable.  We've rejected this approach because it's confusing to end-users and the path to resolution is not obvious.
@okdave and I are still thinking about this.  If we were starting from scratch, we would have them all in the new go-genproto repository.  That is the direction we want to move toward.  The implementation plan is still fuzzy at the moment, but we agree it's a problem that should be tackled.

Interesting.  Thanks for you explanation.  I really appreciate it :)
I guess I'll still have to make my own fork of gen-proto and then it might as well live in gogoprotobuf/types.
Either way the user of protoc will always have to use a lot of import path remapping with the M parameter.  Do you see any way around this in future?
Do you know why the googleapis folder also has to live in go-genproto
It seems like to things that should probably be kept separate?

Fixed with https://github.com/protocolbuffers/protobuf-go/commit/81db48ad09ccc6ee1fcae434baa4bb1b7a7a7a72


HA 2023.8.0b0 causes OCPP addin to fail

Describe the bug
Addin fails to load at all
To Reproduce
Steps to reproduce the behavior:

Just update to the new Beta version of HA and try to use the addin

Expected behavior

It should work I guess ^^

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS] Windows 11
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22] 117

Smartphone (please complete the following information):

Device: [e.g. iPhone6] Pixel 7
OS: [e.g. iOS8.1] Android 14 Beta
Browser [e.g. stock browser, safari] Chrome Beta
Version [e.g. 22] ?

Additional context
Add any other context about the problem here.
Logger: homeassistant.config_entries
Source: helpers/device_registry.py:162
First occurred: 26. Juli 2023 um 22:04:57 (1 occurrences)
Last logged: 26. Juli 2023 um 22:04:57

Error setting up entry central for ocpp
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 388, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/ocpp/__init__.py", line 84, in async_setup_entry
    dr.async_get_or_create(
  File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 500, in async_get_or_create
    device_info_type = _validate_device_info(config_entry, device_info)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 162, in _validate_device_info
    raise DeviceInfoError(
homeassistant.helpers.device_registry.DeviceInfoError: Invalid device info {'default_model': 'OCPP Charge Point', 'identifiers': {('ocpp', 'evbox')}, 'name': 'evbox', 'via_device': ('ocpp', 'e3e34b48b1f328e6666c85df3085125d')} for 'ocpp' config entry: device info needs to either describe a device, link to existing device or provide extra information.

Try changing model=boot_info.get(om.charge_point_model.name, None), to model=boot_info.get(om.charge_point_model.name, "Unknown"),

Looks like issue is Hass adding default_model to device registry entry which causes the error. Hopefully they'll fix in their beta testing.

That now looks good indeed. Everything back online.

So this fixes it! Thanks for the quick help.


TagGroup accessibility issue: removing tags with keyboard alone

Provide a general summary of the issue here
To remove a tag with keyboard alone, the user has to press Backspace/Delete while the tag is focused. This is not an expected interaction for keyboard users. A keyboard user will expect the x/delete button to receive focus and to press Enter or Spacebar to activate it, as they would for any other  element.
🤔 Expected Behavior?

Tag does not receive keyboard focus, because it is not an interactive element.
x/delete button is an HTML button element, therefore:
-- receives keyboard focus
-- can be activated via Enter or Spacebar keys.

😯 Current Behavior

Tag receives keyboard focus.
x/delete button does not receive keyboard focus.
To delete a tag with keyboard, user has to bring focus to the tag, and press Backspace/Delete.

💁 Possible Solution

Remove tabindex attribute from  and
Remove aria-labelledby attribute from
Update aria-label value on  to be clear.

Current HTML:

    Shopping
    ⓧ

Suggested HTML:

    Shopping
    ⓧ

🔦 Context
This component is unusable for a keyboard user unless they are able to guess the keyboard interaction.
🖥 Steps to Reproduce

Visit https://react-spectrum.adobe.com/react-aria/TagGroup.html#removing-tags using any browser.
Use keyboard alone (no screen reader, no mouse, no touch screen) to attempt to remove a tag.
Notice the delete button does receive focus and cannot be activated with Enter/Return or Spacebar.

Version
1.5
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
If other, please specify.
No response
What operating system are you using?
Mac. Same issue happens on Windows.
🧢 Your Company/Team
Thomson Reuters / The Insurer
🕷 Tracking Issue
No response

This is working as expected, using Enter or Space would conflict with Selection.
https://react-spectrum.adobe.com/react-aria/TagGroup.html#selection

@snowystinger Are you saying that because Adobe doesn't want to change the way this component works, that justifies not solving an accessibility issue?

That’s not what I’m saying. I’m saying it’s not an accessibility issue, that’s too broad a claim.
Pressing Delete to delete or remove something is a common pattern.
An AT user would also hear an announcement describing how to delete a tag.
The remove button isn’t additionally focusable because that introduces another focus stop for every tag, making navigating them tedious for a keyboard or screen reader user.
That’s not to say we couldn’t change it or add a different mode, but stating that it’s breaking accessibility is not correct.

@snowystinger I double-checked with the rest of our Accessibility team today and we agree that this is an accessibility issue for keyboard-only users. We're focused on all users, not just AT users. In this case, keyboard-only users who are not using AT may not know to press Delete/Backspace. If the users were instructed how to delete tags, that would alleviate some pain. But since there are no visible instructions or hints, keyboard users will expect the x/Delete button to get focus and then be able to press Enter or Spacebar to activate it. Since it sounds like Adobe will not be taking any action, we will have to look into adding visible instructions on our end.

Do you have user research showing this is an actual issue and not just a theoretical one? I think it's pretty common that when you want to delete something you press the Delete key on your keyboard. This is used across tons of applications that most users and especially keyboard users will be familiar with, e.g. deleting files, deleting emails, etc. If you have research showing that users are actually having problems using the UI that's one thing, but I don't think we should assume that users only know how to press the Tab and Enter keys and nothing else.
By your logic, users might also not know that they need to press the arrow keys to move between tags. Perhaps if your users are unfamiliar with keyboard interfaces it might be best to add visible instructions for all of these interactions not just Delete, but I think we need to assume a baseline level of understanding in order to make the keyboard interface as intuitive as possible (following common patterns) while also not making it inefficient for experienced users.

@devongovett You're correct; the Delete key is used to delete things. In the examples you provided - file & emails - there is an alternative method to delete, usually a Delete button within the application. We haven't performed user research on the Backspace key. We had accessibility testers, accessibility specialists, and software engineers didn't know to press the Delete key on the tags to delete them. Does Adobe have research showing that users do know how to delete tags?
Pressing arrow keys to navigate through long lists of content is standard, and I didn't say it wasn't. It's not the same logic at all. There are plenty of components that use arrow keys on the web.

We had accessibility testers, accessibility specialists, and software engineers didn't know to press the Delete key on the tags to delete them

I do think looking at this as an auditor is different from looking at it as a user (you know how it's implemented technically, you're actively looking for potential issues, etc.), but I appreciate the feedback.

Does Adobe have research showing that users do know how to delete tags?

Not exactly, but it has worked this way for many years and we haven't heard any negative feedback from our users that I'm aware of.

There are plenty of components that use arrow keys on the web.

I'd argue that this is true of delete as well. Microsoft's tag component works similarly to ours for example.
All that being said, perhaps we could make TagGroup follow a similar pattern to our other grid components while retaining support for the Delete and Backspace keys as shortcuts. We recently introduced support for a mode in the GridList component where you arrow key navigate between items, and press tab to access buttons inside an item (#6486). After tabbing through the focusable elements inside an item, you're taken out of the list. This allows efficiently navigating the list with arrow keys, and accessing the child focusable elements of an item when needed.
Now that we have this mode in the underlying hooks, we could potentially apply it to TagGroup as well. Would that work for you?

I agree that it's different testing with Accessibility testers and specialists vs. real users. In this case though, I'd argue that our Accessibility testers and specialists are more technically advanced than average users. So the fact that we couldn't figure out the Backspace/Delete key until looking at the RA documentation says something. I think the potential solution you've suggested sounds promising!

In that case I'll reopen this issue. If you're interesting in contributing, I think it would be pretty straightforward. Essentially adding keyboardNavigationBehavior: 'tab' here: https://github.com/adobe/react-spectrum/blob/b37f2790b77543a447fb0dc1833b5d0cfa8d7da5/packages/%40react-aria/tag/src/useTagGroup.ts#L78-L84
and removing these two lines:
https://github.com/adobe/react-spectrum/blob/b37f2790b77543a447fb0dc1833b5d0cfa8d7da5/packages/%40react-aria/tag/src/useTag.ts#L60
https://github.com/adobe/react-spectrum/blob/b37f2790b77543a447fb0dc1833b5d0cfa8d7da5/packages/%40react-aria/tag/src/useTag.ts#L103
and adding some tests.
We'll also likely need to update our Spectrum implementation to add a focus ring on the button, but we can handle that part once the react-aria changes are made.

I'm an Accessibility Specialist, but I'll check with some of our Software Engineers next week to see if anyone can help with the contribution. Thanks @devongovett!


Backing up raw Google Form-input to a second location

At the moment, the intake form directs data to Form Responses 1, and we edit it directly from there.
In particular, we are editing the "address" field directly, and we're doing it to every row. If the initial information is lost, we will never get it back.
Is there a way to save a copy of the raw form-output as it lands in Form Responses?

A few ways we might do this using App Script:

onFormSubmit would fire every time a new form is added. We could append these to another sheet.
https://stackoverflow.com/questions/17992718/how-to-get-onformsubmit-to-trigger-automatically
onEdit could trigger anytime a sheet cell is changed, so that you could capture the old value and new value. We could append both to another sheet so that all changes were searchable and attributed to the editor.  https://developers.google.com/apps-script/guides/triggers/events

This is done. All entries land in en, which backs things up. Turns out, the Google Form also backs this up.
All is well. Also, the autobackups preserve Sheet state.
Bug is tostada.


Application hosted Emoji support

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[ ] Internal code
[x] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
Supersedes #2706 with a cleaned up commit list and implementation of freya022's addition of createApplicationEmoji(String, Icon)

@Andre601 are you still working on this? I would really like this being in the master.

Yeah, I can't find motivation to continue working on this, so I would be happy if someone could take over the changes, so that I can close this PR...


build images using cloudbuild

Part of https://github.com/kubernetes-sigs/prow/issues/113
Part of https://github.com/kubernetes/k8s.io/pull/6740
Right now, our postsubmit job runs in a pod which breaks our trusted cluster build policies.
I tested this build at https://console.cloud.google.com/cloud-build/builds;region=global/ce637e5c-b605-490f-b104-589b7dca23c6?project=k8s-infra-ii-sandbox
@BenTheElder @ameukam

To my understanding, #113 states that we should attempt to promote prow components to registry.k8s.io ?

#113 requires Prow maintainers to start versioning prow and promote the release images to registry.k8s.io. In the meanwhile, we need to be able to publish and consume unversioned prow images from an AR registry called us-docker.pkg.dev/k8s-infra-prow/images

Also a regional AR would be more sustainable and cost-effective.

Pricing is the same for both storage and bandwidth. https://cloud.google.com/artifact-registry/pricing#storage

prow and we specially don't need to co-locate a AR registry and a GKE cluster.

I'm doing this for convenience. Prow images are a special case and will need to be stored for more than 60 days(how long is TBD) and AR has a good security boundary, unlike GCR which interacts with GCS so a dedicated staging project makes no sense.

/approve
/lgtm
/hold please remove hold as needed

Pricing is the same for both storage and bandwidth. https://cloud.google.com/artifact-registry/pricing#storage

currently

Prow images are a special case and will need to be stored for more than 60 days

They shouldn't be. Which other projects would we special-case?
The only special case I know currently is registry.k8s.io because we would have a circular dependency problem.

/cc @droslean @matthyx
I would like to get this merged soon, thanks

/approve
/lgtm
Please remove the hold if @BenTheElder comment is addressed.

/hold cancel


MultiControlledPauli doesn't decompose if len(cvs) == 1.

from qualtran.bloqs.multi_control_multi_target_pauli import MultiControlPauli
import cirq

mcp = MultiControlPauli((1,), cirq.Z)
mcp.decompose_bloq()

ValueError: junk register must of shape (-1, 1) but is of shape (0, 1)

We should either assert cvs > 1, or return a CX/Y/Z and exit the decomposition early.

@tanujkhattar did you fix this?

Yup, the code snippet above works now


Is there a method to copy td_api objects?

I need to send update to several handlers, it would be convenient if there is a method can deep copy objects.

There is no method for deep copy of the objects, but you can use object.release() and create a std::shared pointer from the returned pointer.

got it, thx for your advice!


Veetle - stream: Unknown tag type

Livestreamer disconnects from veetle with " Unknown tag type! ".  Livestreamer will play the stream anywhere from 3 minutes to over an hour.  Video stream is stable no lag.  But livestreamer will eventually terminate the stream within 2 hours of play.  I've tried different veetle channels with the same result.  I'd appreciate it if someone else can verify.
Tried file/network caching but same problem.  I don't think it's a video player problem.
'C:\Program Files (x86)\VideoLAN\VLC\vlc.exe' --file-caching=5000 --network-caching=5000'
Here is my setup:
OS: Win7 64bit
Players: VLC 2.2.1 (32bit) and MPC 1.7.8 (32bit)
Livestreamer: latest stable 1.12.1 and nightly 1.12.1-18-g6060865.
==4 minute stream then stopped==
livestreamer-v1.12.1-18-g6060865> livestreamer.exe http://veetle.com/v/821b05058ed2982b9f34bbb75fe69c3c live
[cli][info] Found matching plugin veetle for URL http://veetle.com/v/821b05058ed
2982b9f34bbb75fe69c3c
[cli][info] Available streams: live (worst, best)
[cli][info] Opening stream: live (flv_playlist)
[cli][info] Starting player: 'C:\Program Files (x86)\VideoLAN\VLC\vlc.exe'
[cli][error] Error when reading from stream: Unknown tag type!
[cli][info] Stream ended
==1 hour stream then stopped==
livestreamer-v1.12.1-18-g6060865>livestreamer.exe -l debug http://veetle.com/v/ef0f1ec300150f2754a63d866e72134c live
[cli][info] Found matching plugin veetle for URL http://veetle.com/v/ef0f1ec300150f2754a63d866e72134c
[cli][info] Available streams: live (worst, best)
[cli][info] Opening stream: live (flv_playlist)
[cli][debug] Pre-buffering 8192 bytes
[stream.flv_playlist][debug] Opening substream: <HTTPStream('http://<IP_ADDRESS>:80/flv/5285079c2c9e5/testat123')>
[cli][info] Starting player: 'C:\Program Files (x86)\VideoLAN\VLC\vlc.exe'
[cli][debug] Writing stream to output
[cli][error] Error when reading from stream: Unknown tag type!
[cli][info] Stream ended
livestreamer-v1.12.1-18-g6060865>
==45 minute stream then stopped==
livestreamer-v1.12.1>livestreamer.exe -l debug http://veetle.com/v/ef0f1ec300150f2754a63d866e72134c live
[cli][info] Found matching plugin veetle for URL http://veetle.com/v/ef0f1ec300150f2754a63d866e72134c
[cli][info] Available streams: live (worst, best)
[cli][info] Opening stream: live (flv_playlist)
[cli][debug] Pre-buffering 8192 bytes
[stream.flv_playlist][debug] Opening substream: <HTTPStream('http://<IP_ADDRESS>
8:80/flv/5285079c2c9e5/testat123')>
[cli][info] Starting player: 'C:\Program Files (x86)\VideoLAN\VLC\vlc.exe'
[cli][debug] Writing stream to output
[cli][error] Error when reading from stream: Unknown tag type!
[cli][info] Stream ended
livestreamer-v1.12.1>

Tested on a new i7 PC and had the same problem with the latest release.  I don't think the "Unknown tag type!" error is specific to my setup.
livestreamer-1.12.2 (2015-05-02)
== 30 minute stream then stopped ==
C:\Program Files (x86)\Livestreamer>livestreamer.exe http://veetle.com/v/30a5e7afa1a905929ce0ba73c21a7da9 live
[cli][info] Found matching plugin veetle for URL http://veetle.com/v/30a5e7afa1a905929ce0ba73c21a7da9
[cli][info] Available streams: live (worst, best)
[cli][info] Opening stream: live (flv_playlist)
[cli][info] Starting player: 'C:\Program Files (x86)\VideoLAN\VLC\vlc.exe'
[cli][error] Error when reading from stream: Unknown tag type!
[cli][info] Stream ended

The error message indicates that the stream payload read from the stream was invalid. FLV (flash video) only has 3 valid tags, audio/video/metadata. Livestreamer throws the above error if it receives any other tag value. More Info on FLV tags: http://superuser.com/a/502462
My guess: This is either a problem with the site's stream itself or the plugin for livestreamer. There's probably nothing wrong at your end.


Limit namespaces listed in HNCConfig namespaceConditions

Only list the first three affected namespaces in each condition in
hncconfig.status.namespaceConditions. Update the 'namespaces' field
description to reflect this change in the CRD schema. Add
'numAffectedNamespaces' field to show the total number of affected
namespace to provide full context of the namespace conditions.
Create a new conversion test case with four affected namespaces.
Tested manually on GKE and by 'make test' and 'make test-conversion'.
Part of #868
Fixes #1226

/assign @adrianludwin
/assign @rjbez17

High level comment: maybe we should get rid of namespaceConditions and just have this as a regular condition? Eg something like type=NamespaceCondition, reason=<the namespace condition type, like ActivitiesHalted> and then the message just indicates the first N namespaces affected by that condition and why?

High level comment: maybe we should get rid of namespaceConditions and just have this as a regular condition? Eg something like type=NamespaceCondition, reason=<the namespace condition type, like ActivitiesHalted> and then the message just indicates the first N namespaces affected by that condition and why?

sgtm and they will show up in k hns config describe too (see #1222).

The message of 4, 3, 2, 1 affected namespace would look like this:
status:
  conditions:
  - lastTransitionTime: "1970-01-01T00:00:00Z"
    message: 4 namespaces "b", "c", "d" ... are affected by "ParentMissing"
    reason: ActivitiesHalted
    status: "True"
    type: NamespaceCondition

status:
  conditions:
  - lastTransitionTime: "1970-01-01T00:00:00Z"
    message: 3 namespaces "c", "d", "e" are affected by "ParentMissing"
    reason: ActivitiesHalted
    status: "True"
    type: NamespaceCondition

status:
  conditions:
  - lastTransitionTime: "1970-01-01T00:00:00Z"
    message: 2 namespaces "d", "e" are affected by "ParentMissing"
    reason: ActivitiesHalted
    status: "True"
    type: NamespaceCondition

status:
  conditions:
  - lastTransitionTime: "1970-01-01T00:00:00Z"
    message: Namespaces "e" is affected by "ParentMissing"
    reason: ActivitiesHalted
    status: "True"
    type: NamespaceCondition

/lgtm

/lgtm
/hold cancel


another small state fix

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 7 (71.43%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 58.881%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

goalc/compiler/compilation/State.cpp
5
7
71.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
40166

Relevant Lines:
68215

💛  - Coveralls


Handle the edge case

Handle the edge case when the response is null or response.data undefined

Thanks for the PR! Please have an issue filed before submitting the PR :)
Also I believe the edgecase is handled in the catch block.


xmldoc for System.Linq.Async

Would it be possible to add xmldocs for System.Linq.Async? Currently Visual Studio does not show any intellisense for these methods, which makes it tricky to tell exactly what some of them do.

There isn't any docs in the source at all.
@onovotny can you setup System.Linq.Async to have VS complain about missing docs on public members as well as ensure the build does generate XML?

We can have it complain about missing docs, the bigger issue is time. We need someone to create the method docs first.

Indeed there are a lot of methods and probably dozens of PRs worth of changes. I have some free time this week to start working on them. Btw, which sln is for System.Linq.Async Ix.NET or Ix.Async.NET now?

It looks like Ix.Async.NET is a subset of Ix.NET that only has the main libraries and tests. Ix.NET has the benchmark tests and the reference assembly projects too.

Closing via #1098 & #1099.


Support certificate chain and private key via PFX/PKCS12

Allow customers to provide Envoy with a TLS certificate via PFX/PKCS12 file.
This would create a new DataSource field on the TlsCertificate message called pfx_file. This field will be functionally mutually exclusive with the certificate_chain and private_key field, since it cannot be marked oneof for API compatibility reasons.
Not sure on how to interact with the watched_directory field; I prefer not doing filesystem monitoring for pfx_file, since my read of the documentation is that watched_directory is only for SDS, which doesn't use PFX/PKCS12.
The existing password field would be used to provide the password for decrypting the PFX/PKCS12 file, if it is encrypted.
This enables a specific customer scenario on Windows, as well as simplifies the distribution of the certificates and private keys on all supported platforms, since it's a single file, instead of multiple.

I don't know too much about this area, but a couple of thoughts:

Could we just auto detect whether it's PFX/PKCS12 and have it "just work" without any other API changes? IMO this would be optimal.
If not I wonder if instead of a new file field, would we want some type of cert_chain_type field that would say whether it's of this type?

Both of those seem better than adding a new file field specifically for this, but I don't feel too strongly about it. cc @lizan @ggreenway for further thoughts.

@mattklein123
Regarding 1) that's possible, but because the PFX/PKCS12 contains both a private key and certificate (and potentially also a certificate chain), does it belong in the certificate_chain field, or the private_key field?
The only way I know to do this would be to trial call the API for reading the PFX/PKCS12 and on failure go on to the existing API calls.
Regarding 2) This would make it much easier to reuse the existing field, IMO, because then the specific type is specified, and there's no need for trial API calls.
I don't feel strongly about either approach as long as the support is added in a way consistent with the rest of the API. To me, that seemed like a new field, but I'm new to the Envoy project, so maybe a type field is more consistent with the design.

Not strong opinoins, but we could solve (1) above by pointing both certificate_chain and private_key at the same PFX/PKCX12 file, and the semantics would be that Envoy extracts the relevant part of the file when this happens with this format.

I'm not a fan of that approach because PKCS12_parse returns both, which means part of the result would be discarded for each field and the work duplicated, and it still requires a trial call of d2i_PKCS12_bio before trying the other formats.

I'm fine with a new field. Do you want to just do the API and docs first and we can discuss in a PR?


docs(syntax): more comments for ReferenceFlags

Add more docs to ReferenceFlags, mainly to include the runtime test in https://github.com/oxc-project/oxc/issues/5165#issuecomment-2488333549.

#7392  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Nov 21, 6:16 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 21, 6:16 AM EST: A user added this pull request to the Graphite merge queue.


Do we need to normalize input value?

For example, we have parameter x1 within range(-10, 10) and x2 within range(-0.1, 0.1), do we need to normalize both x1 and x2 to e.g. range(-1.0, 1.0) for better performance?
I found that some parameter stuck on an ending point in the very beginning and never change after that, is this an outcome of different scale of input paramters?

I'm trying to optimize deep autoencoders and I had the following issue. After evaluating 150 random parameter setups, I used optimizer.suggest(utility) to get the next point to probe. What then happened was that I almost always got either the lower or upper limits for each parameter. I've used UCB and with kappa = 5,10,15.
I did some quick research about Gaussian Processes(GP) and found out that the data should be either standardized or normalized. I don't know the underlying maths behind this, but for the moment, my answer would be 'Yes, parameters with different scales need to be in the same range'.

Data is already being normalized before given to internal GP. The obsession with the edges happens sometimes and is often mitigated by increasing UCB's kappa, GP's alpha, adding more random iterations steps, changing the range, or a combination of all above.

@fmfn, "Data is already being normalized before given to internal GP."
I see that only y (output) is normalized in GaussianProcessRegressor.
So, input isn't normalized, right?


Add blog post for OTel Operator Q&A

Added blog post for OTel Operator Q&A

Preview: https://deploy-preview-4359--opentelemetry.netlify.app/blog/2024/otel-operator-q-and-a/

/fix:refcache


Add support for pessimistic mutations happening at the same time

Add the keyword ::pm/mutation-response-key that will play the same role as ::pm/mutation-response so we can have multiple pessimistic mutations happening at the same time.

So, is this ready for merge, or is there more to do?

@awkay Close, still missing the returning fix, should be ready soon.

Now it should be ready, please let us know if its all good @awkay

Cool, looks good.


Show link to docs when any "unauthorized" notification errors appear

If we find the word "unauthorized" in a notification error, let's add a message at the top saying:
We're sorry, it looks like you're not authorized to connect to this cluster.
Please take a look at our
[troubleshooting guide for cluster connections in our documentation](https://kubeshop.github.io/monokle/cluster-issues/)
for steps on how to resolve this issue.

Error:
<replace with the actual error>

Hi @devcatalin, I've tried to fix this issue in the PR #3017


feat(data-mapping): Implement Async Records Mapping Mechanism for MARC Migration (Process Chunks)

Purpose
Implement Async Records Mapping Mechanism for MARC Migration (Process Chunks)
Approach

Implement spring batch job with async step for chunks processing
Read chunk entities from db
Write step entities to db
Read records for chunks
Map records
Update chunk/step entities in db
Write data to local files
Upload local files to minio after all batches processed

Changes Checklist

[x] API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
[x] Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
[ ] Interface Version Changes: Indicate any changes to interface versions.
[x] Interface Dependencies: Document added or removed dependencies.
[x] Permissions: Document any changes to permissions.
[x] Logging: Confirm that logging is appropriately handled.
[x] Unit Testing: Confirm that changed classes were covered by unit tests.
[x] Integration Testing: Confirm that changed logic was covered by integration tests.
[x] Manual Testing: Confirm that changes were tested on local or dev environment.
[x] NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues
MODMARCMIG-7
MODMARCMIG-12 - Task to support parallel migration operations processing for different tenants
Testing
Testing was performed using docker-compose, two tenant setup, 4 threads for batch step execution, following env variables:
RECORDS_CHUNK_SIZE=10
CHUNK_FETCH_IDS_COUNT=20
CHUNK_PERSIST_COUNT=50
Data was pre-populated using testing sql scritps.

3 migration operation were submitted almost at the same time: 1 for 1'st tenant, then one for 2'nd tenant, 1 for 1'st tenant
All operations executed sequentially and finished successfully.
In a scope of operation - batches processed in parallel, confirmed by adding thread sleeps for even threads and thread name to logs.

Other tables for second tenant:

Minio for 2'nd tenant job:

Great job! It's hard to follow logic, but I think it's due not much experience with spring batch. Will it be easy to extend this to instance/bib records?

I believe yes, classes are not authority dependent, except ChunkStepPreparationProcessor, which could be splitted to have smaller interchangable part for auth/bib, or additional job parameter could be used to define service to be used for retrieving appropriate entities


(php) Fallback to archive url for v5.3.x, v5.4.x, v5.5.x

The PHP installation should fallback to http://windows.php.net/downloads/releases/archives/ instead of http://windows.php.net/downloads/releases/ if the version cannot be found there.

Based on the helper function that should be happening, maybe something is not correct with the AddArchivePathToUrl() function...
https://github.com/chocolatey/chocolatey-coreteampackages/blob/master/automatic/php/tools/helpers.ps1#L15-L22

I guess it works for newer releases then, but not old ones? The one I'm specifically having issues with is PHP 5.5 installations for CI purposes. https://github.com/amphp/dns/blob/master/appveyor.yml#L39
cinst --ignore-checksums -r -y php --version ((choco search php --exact --all-versions -r | select-string -pattern 5.5 | Select-Object -first 1) -replace '[php|]','')

With archived versions Select-Object -first 1 might be the wrong choice
I also wonder if choco needs to take into consideration nts vs ts versions of php in the archive (I believe iis needs the nts version as it's not thread safe where as apache can us the ts version of php)

With archived versions Select-Object -first 1 might be the wrong choice

Why?

Look at the php 5.5 items in the archive, which minor version will select object first pick? That's what I see might be a possible problem.

I don't care about the actual minor version being used for CI purposes, but the one that's chosen doesn't install, because it can't find it.
https://ci.appveyor.com/project/kelunik/dns/build/job/9k7sfw429rea1lh7 doesn't show that exact error currently, but did before and also locally I get that http://windows.php.net/downloads/releases/php-5.5.16-nts-Win32-VC11-x64.zip either doesn't exist or is unauthorized, server returned 404 Not Found.

@kelunik I looked through the existing versions of the php package, and it seems the fallback to using the archives url was implemented in version 5.6.2.
Unfortunately I don't believe there will be added any fixes to any versions earlier than that one, as it's no longer supported by the developers.
As such, I'm also going to close this issue as it will not be implemented for earlier versions.

@AdmiringWorm for ci purposes it doesn't matter if php no longer supports the version being tested against. I work with projects that still have php 5.3 as a supported version to run their package on. Usually it's corporate intranets that still run those old versions. It will be another 2 years before we completely stop supporting/writing code that runs on php 5.3 and we only have a code base running on php 5.6+.
Like I said it's not about php supporting fixes it's about us verifying our code runs on a particular version of php.

@AdmiringWorm Thanks for checking, I'm glad it works on all newer versions. While PHP 5.5 has reached its EOL and even 5.6 being already in security-only mode, there are still a lot of packages supporting it. Whether that's good or bad is another discussion. We (amphp) will completely drop PHP 5 support in the next version, as does Symfony and other major frameworks, but I think it's still important to run tests for the older still supported majors on all supported versions. That said, our major CI platform is Travis, so I can live without PHP 5.5 on Windows.

it's still important to run tests for the older still supported majors on all supported versions.

So much this comment. I've lived this in Ruby land, so I completely understand and support this idea.

@AdmiringWorm could we give it another look?

Like I said it's not about php supporting fixes it's about us verifying our code runs on a particular version of php.

Ah yes, sorry didn't think of it that way, guess I closed this a little too soon without taking that into consideration.

@AdmiringWorm could we give it another look?

Certainly, we can take another look at this.
I'm not entirely sure how we should handle this though.
Just reusing the current script with the necessary url changes, or create a new one just using the archive url?

I'll look into providing some updated packages for the old versions.
For now I only plan to add the latest 5.5.x version, but if there is any other versions anyone would like then please let me know.
/cc @kelunik @photodude @ferventcoder

I'm fine with having one version, which ever it is.

For Joomla-CMS we would like just the last version of 5.3, 5.4, and 5.5.
On a side note, like @kelunik and amphp we also primarily test with Travis CI. Additionally, our next major version will only support PHP 5.6+. Our current version nearing release 3.7 will be supported for 2 years and has a minimum php of 5.3, so any older PHP versions we can bring into Appveyor with choco for CI testing on windows is helpful but we can make do if it can't be done.

@photodude 👍
I'll look into adding updated versions of 5.3.x and 5.4.x as well.

@photodude Am I correct to asume that php v.5.3.x doesn't support 32bit?
Perhaps v5.4.x as well?

At least there aren't any builds for it. I guess we could just fall back to x86 there.

As far as I'm aware even in php 5.5 and 5.6 the x64 support is experimental. all of those versions should all default to x86.
the following is from http://windows.php.net/

The x64 builds of PHP 5 for Windows are experimental, and do not provide 64-bit integer or large file support.

Looking at the archive list php 5.5 is the first version to have a x64 package included
Additionally if your using IIS on windows you need the NTS version as only Apache is TS
see this note from http://windows.php.net/

If you are using PHP as FastCGI with IIS you should use the Non-Thread Safe (NTS) versions of PHP. With Apache you have to use the Thread Safe (TS) versions of PHP.

@kelunik said

At least there aren't any builds for it. I guess we could just fall back to x86 there and error out in case of a --force-x64 or what ever the flag is called.

as far as I know, by default a package uses 64bit unless a --forcex86 is used (on a 64bit OS)
@photodude

As far as I'm aware even in php 5.5 and 5.6 the x64 support is experimental. all of those versions should all default to x86.

Unfortunately the existing 5.5 and 5.6 packages defaults to 64bit, and I want to keep them consistent so that's what I'm going to do as well.

Additionally if your using IIS on windows you need the NTS version as only Apache is TS
see this note from http://windows.php.net/

The existing packages already uses the NTS version, so i'm going to keep using that.

@AdmiringWorm I'm all for consistency in default settings, especially when there are options to override with --forcex86. So defaulting to NTS is fine, I hope that there is is a way to force the TS version of PHP if that is needed (we are focusing on testing with IIS on windows so NTS is fine for us especially as a default)

@photodude Currently there is no way to foce the TS version.
But I can certainly look into that as well.

@AdmiringWorm I was just looking at choco list php --exact --all-versions seems PHP 5.4 is missing from the list and PHP 7.0.9 is the last php7 version listed although the package list says 7.0.13 is available and PHP 7.0.15 is available in the win releases http://windows.php.net/downloads/releases/
any tips on how to get the correct latest minor version of the packages that is available on http://windows.php.net/downloads/releases/ or http://windows.php.net/downloads/releases/archives/

@photodude Thanks, I'm aware of it.
Both of those are on my TODO list, but want to complete #548 before I do.

Perhaps I'm overlooking something and need to look closer, but the issue appears to be that the downloadInfo.csv file is generating all of its URLs from the main releases page. Then if it doesn't exist there it attempts to use the archive URL, but the value it passes to that method will never work because it wouldn't be in the downloadInfo if it is already in the archive.

Basically the logic is currently as follows.

Read the main release page urls from downloadInfo.csv
Test if installer is located at that url

If it doesn't exist, change it to the archive url

Pass the url to the package arguments.

The reason it's not working for the existing package is because they used a non-existing url variable, this is fixed in the latest version in this repo (not pushed) and awaiting review to fix it in existing packages.
@ChadSikorra

@kelunik @photodude
v5.3.29, v5.4.45 and 5.5.28 have just been pushed and should be available on chocolatey.org soon.
the latest v5.6.x and 7.0.x will come later.

Forgot about closing this one, all requested versions should be available now.
Let me know if there are any remaining

@AdmiringWorm I'm now seeing PHP 7.1 always installing in a versioned directory, previously all php would default to /tools/php see this appveyor build https://ci.appveyor.com/project/joomla/joomla-cms/build/1.0.643/job/2b5vfkcwoofnp618
nothing has changed on our side, just the recent chocolatey changes

@photodude yes, that's intentional to allow side-by-side installation.
If you absolutely need for it to install to the /tools/php directory you can pass `--params '""/InstallDir:C:\tools\php"""' when calling choco install

@AdmiringWorm this is the script for the install with cinst on appveyor which installs correctly for php 5.6 and php 7.0 to C:\tools\php it's only php 7.1 that is installing to a different directory C:\tools\php71.
  - php_ver_target: 5.6
  - php_ver_target: 7.0
  - php_ver_target: 7.1
    - ps: >-
        If ($env:php_ver_target -eq "5.6") {
          appveyor-retry cinst --ignore-checksums -y --forcex86 php --version ((choco search php --exact --all-versions -r | select-string -pattern $Env:php_ver_target | Select-Object -first 1) -replace '[php|]','')
          $VC = "vc11"
          $PHPBuild = "x86"
        } Else {
          appveyor-retry cinst --ignore-checksums -y php --version ((choco search php --exact --all-versions -r | select-string -pattern $Env:php_ver_target | Select-Object -first 1) -replace '[php|]','')
          $VC = "vc14"
          $PHPBuild = "x64"
        }

@photodude they all are supposed to install to a versioned folder, and I can see why 5.6.x and 7.0.x isn't.
For 5.6.x you're installing the 5.6.9 version while the latest is 5.6.30 (you're using default sorting, instead of version sorting)
For 7.0.x you're install the 7.0.9 version while the latest is 7.0.16 (same sorting problem).
As I said, you'll need to specify the InstallDir: parameter if you wish to continue installing them to C:\tools\php (when sorting is fixed, that is)

Ok, I'll make the install dir change. What do I change to use version sorting?

If i remember correctly, then it should be enough to add
| sort { [version]$_ } -Descending

right before you have | Select-Object.
You'll need to test that though, as I'm not completely sure.

thanks @AdmiringWorm I'll give it a go. I hope that kind of detail can be added to the documentation.

just tested out sorting by version,
you'll need to swap out the choco search command with the following:
choco search php --exact --all-versions -r | select-string -pattern $env:php_ver_target | sort { [version]($_ -split '\|' | select -last 1) } -Descending | Select-Object -first 1

regarding the documentation, do you mean mentioning it now installs to versioned directories?

both that php now defaults to install to versioned directories, and choco search with sorting by version

I'm not sure about adding the sorting by version, but I'll see if I can't get around to adding a note about versioned directories.

thanks @AdmiringWorm the changes have solved my problems


:ambulance: Fixed issue with /v4/manga/{id}/characters endpoint

Fixes #460
Fixes #463

NOTE: You will need to drop the manga_characters collection in order to fully resolve https://github.com/jikan-me/jikan-rest/pull/464 and rebuild its index.


Importing/Exporting PSLGs

New feature planned

this will be implemented once CG:SHOP 25 published their instance format

added buttons in ce52db452abd1f54d41bba0a1d9a765652caf15a

added some basic structure in 7142fd5bdb960048ff637cf2faf2d5eea84e1a56

please make sure that after importing the graph should only be analyzed if autoanalyze is enabled #6

Implemented imports in #18

Need to make imported edges a different color or implement fixed edges to prevent accidental deletion. Note that fixed edges come with a problem regarding segment splitting where the new split point is movable

not sure how exactly the solution format is supposed to look like, will implement exporting once thats been published


PRChecker: add flag --warn-commits.

Added flag warn-commits that defaults to 3.  Documented the flag in readme.

CI looks Green:
https://travis-ci.org/nodejs/node-core-utils/builds/301146913
https://ci.appveyor.com/project/joyeecheung/node-core-utils/build/168.${patch}

Appveyor: https://ci.appveyor.com/project/joyeecheung/node-core-utils/build/201.master


CSS Issue with the hamburger

There is a CSS issue, when we click on the hamburger menu. There is a small gap.

Issue is fixed by commit id 64827489ddb43d540f472951661430582ef7b230


Add custom status support for bots

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[x] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
Implements support for custom status in bots. This was rolled out about an hour ago on the API side and I have tested it with my own bot.

docs PR: https://github.com/discord/discord-api-docs/pull/6345


Introduce LiveChat as oauth2 provider

This PR introduces LiveChat as an oauth2 provider. This will allow people to build LiveChat applications with a PocketBase backend instance.

Thank you. I'll review it a little bit later.
Could you add godoc comments to tools/auth/livechat.go (similar to the other providers) and if possible - link to the LiveChat users API reference?

@ganigeorgiev just updated the ui build.
Please let me know if you need help reviewing this.

@mariosant I've squash merged it in the develop branch in https://github.com/pocketbase/pocketbase/commit/55c6bed57fe3c526d9eabf7b99746600d38b589f
(I've applied some minor format nitpicks and added check for the email_verification field).
The provider will be available with the next v0.12.0 release.


Bionic website very big in mobile devices

Hey @shajin-sha the bionic website is a little two big for mobile devices .
Picture:

It should be fixed! Thank for letting me know 😀


Inherit header type in BlockchainProvider2 impl

Describe the feature
Replace concrete type Header/SealedHeader with reth_node_types::HeaderTy<N> in impl of BlockchainProvider2 where possible.
https://github.com/paradigmxyz/reth/blob/f8d683e80ee08412e19cc212a4c2bf8ebeca245b/crates/storage/provider/src/providers/blockchain_provider.rs#L47-L756
To do this, probably the generic N on BlockchainProvider2's type definition, will have to be passed to CanonicalInMemoryState first.
https://github.com/paradigmxyz/reth/blob/f8d683e80ee08412e19cc212a4c2bf8ebeca245b/crates/storage/provider/src/providers/blockchain_provider.rs#L58
Additional context
No response

blocked by https://github.com/paradigmxyz/reth/pull/12723

can I take this?

I think we can hold off on this for bit longer until we have an abstraction for block bodies

Is it okay if I take this?

Resolved by https://github.com/paradigmxyz/reth/pull/13030


Allow using keywords as relation, type and condition names

An example test that would need to work:
For now, we'll keep the following as reserved:
and
or
from
relations
define

as reserved, but allow
model
schema
type
relation
condition

# dsl-syntax-validation-cases.yaml
- name: a valid model with type names doesn't conflict with built-in keywords
  dsl: |
    model
      schema 1.1
    type user
    type model
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
        define condition: [user] or model or schema or type or relation
    type schema
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
        define condition: [user] or model or schema or type or relation
    type type
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
        define condition: [user] or model or schema or type or relation
    type relation
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
        define condition: [user] or model or schema or type or relation
    type condition
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
        define condition: [user] or model or schema or type or relation

This can be done rather simply, but one issue I've found is that condition is currently used to change states.
To support condition we'd either need to blend the two grammars together and no longer use pushMode, or change the trigger token to trigger pushMode.
We can do the others listed like with a minimal change (https://github.com/openfga/language/pull/172);
- name: a valid model with type names doesn't conflict with built-in keywords
  dsl: |
    model
      schema 1.1
    type user
    type model
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
    type schema
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
    type type
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]
    type relation
      relations
        define model: [user]
        define schema: [user]
        define type: [user]
        define relation: [user]

@d-jeffery let's do the others and keep condition till someone asks for it


Table widget

Just a humble small feature request for a table widget, something like;

with a possible API of (inherits from Box);
var table = blessed.table({
  columns: ['uid', 'oid', 'tid'],
  rows: [
      [1,0,1],
      [2, 1, 1],
      [3, 1, 1]
  ]
});

table.addRow([4, 1, 3]);

Is this a good idea ? I could work on a PR.

You may find the following interesting:
https://gist.github.com/OhJeez/2474fdcafbfa2fbf70da
It is basically something like a table, but still being a list.


Disable analyzers which we aren't planning to implement

SA1301 (ElementMustBeginWithLowerCaseLetter)
SA1645 (IncludedDocumentationFileDoesNotExist) (Closes #165)
SA1646 (IncludedDocumentationXPathDoesNotExist) (Closes #166)
SA1647 (IncludeNodeDoesNotContainValidFileAndPath) (Closes #167)

:+1:


Pessimistic disconnection handling. Resolves #375

See issue #375.

This needs tests and docs before merging.  I'm also not sure if this needs to be merged/supported here.  If someone needs this, it's trivial to implement, they just copy paste the recipe from the docs.

@davidism:

It might be trivial to you. But it is far from trivial for me.
This is an issue that comes up again and again on SO and on the sqlalchemy-mailinglist. It's sad that there is no out-of-the-box solution.
Just adding this to every project increases the amount of boilerplate needed for using sqlalchemy with flask.
Testing is difficult: You need to somehow make the connection fail without sqlalchemy noticing it.

I'm closing this for now until there is a decision how to approach this. This PR was just a way to show goodwill anyway.


Update Import-CsOnlineAudioFile.md

Adjusted example sub-headers to bring them in-line with other docs and improve display in low-resolution/high-zoom cases

Docs Build status updates of commit 0e4fecd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Import-CsOnlineAudioFile.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

If this pull request is confirmed and merged, I might prepare a bunch of similar changes to other docs, as the differences in example sub-headers can be found in multiple places

@dariomws @get-itips @tseward

@tseward

@tiburd Please merge this PR. Thanks


Faster MSA computations with chunked DBs on Colab

There is a stark difference in the time taken to compute MSA on Colab vs through AlphaFold's actual implementation through docker. I was trying to figure out the differences, and the most obvious seems to be that jackhmmer runs on chunks of the original dbs.
I have the whole dataset downloaded with me already, and I find that for the proteins I tested, there are almost the same number of sequences found in both approaches. However, in the Colab version MSA takes merely 20-30 min and through the docker it takes 7-9 (mostly jackhmmer on uniref90 and mgnify, and even when I get a total of <200 sequence matches for a protein with only 77 amino acids)
I am running on AWS notebook instance ml.g4dn.4xlarge, all the data being on the SSD.
I have some questions:

Why is the 7-9 hour approach suggested?
Is this the only reason MSA computation is so fast on Colab?
Might there be something wrong with my implementation if jackhmmer on Colab is taking less time than local implementation?
jackhmmer chunking currently is only supported over internet, will it work as fast/faster if it is implemented locally (by myself)?

Here are relevant timing logs for comparison. I believe jackhmmer is the slowest, and I have ran 3-4 proteins through to get similar time benchmarks.
I0419 09:01:46.545762<PHONE_NUMBER>49984 run_docker.py:255] I0419 09:01:46.545098<PHONE_NUMBER>04032 utils.py:36] Started Jackhmmer (uniref90.fasta) query
I0419 13:09:40.188118<PHONE_NUMBER>49984 run_docker.py:255] I0419 13:09:40.186011<PHONE_NUMBER>04032 utils.py:40] Finished Jackhmmer (uniref90.fasta) query in 14873.641 seconds
I0419 13:09:40.283886<PHONE_NUMBER>49984 run_docker.py:255] I0419 13:09:40.283068<PHONE_NUMBER>04032 utils.py:36] Started Jackhmmer (mgy_clusters_2018_12.fa) query
I0419 17:24:10.802730<PHONE_NUMBER>49984 run_docker.py:255] I0419 17:24:10.802150<PHONE_NUMBER>04032 utils.py:40] Finished Jackhmmer (mgy_clusters_2018_12.fa) query in 15270.519 seconds
I0419 17:24:11.070103<PHONE_NUMBER>49984 run_docker.py:255] I0419 17:24:11.069362<PHONE_NUMBER>04032 utils.py:36] Started HHsearch query
I0419 17:31:10.780151<PHONE_NUMBER>49984 run_docker.py:255] I0419 17:31:10.779571<PHONE_NUMBER>04032 utils.py:40] Finished HHsearch query in 419.710 seconds
I0419 17:31:11.022377<PHONE_NUMBER>49984 run_docker.py:255] I0419 17:31:11.021669<PHONE_NUMBER>04032 utils.py:36] Started HHblits query
I0419 18:09:46.100788<PHONE_NUMBER>49984 run_docker.py:255] I0419 18:09:46.100168<PHONE_NUMBER>04032 utils.py:40] Finished HHblits query in 2315.078 seconds
I0419 18:10:14.906161<PHONE_NUMBER>49984 run_docker.py:255] I0419 18:10:14.905608<PHONE_NUMBER>04032 pipeline.py:234] Uniref90 MSA size: 6040 sequences.
I0419 18:10:14.906352<PHONE_NUMBER>49984 run_docker.py:255] I0419 18:10:14.905785<PHONE_NUMBER>04032 pipeline.py:235] BFD MSA size: 1328 sequences.
I0419 18:10:14.906456<PHONE_NUMBER>49984 run_docker.py:255] I0419 18:10:14.905830<PHONE_NUMBER>04032 pipeline.py:236] MGnify MSA size: 248 sequences.
I0419 18:10:14.906560<PHONE_NUMBER>49984 run_docker.py:255] I0419 18:10:14.905873<PHONE_NUMBER>04032 pipeline.py:238] Final (deduplicated) MSA size: 6010 sequences.

As far as I can tell, Colab is not using jackhmmer but MMseqs2