fix: Corrects the events passed into each day

Ok, so what I think the problem here was, there were two places where the events for the day were being calculated, rather than just sticking to one. I've moved things around a little so that there is a single source of truth for events for the day, and that's calculated in the CalendarProvder, which is where I think it should be done. As such, I have removed some of the code from the EventIntersectionProvider, because that code seemed primarily to be about showing/hiding events, rather than what events it had.
I've tested this with my own consuming project and with these changes, everything works as expected when I filter events out.
Fixes: https://github.com/bruceharrison1984/Schedulely/issues/95

I've moved things around a little so that there is a single source of truth for events for the day, and that's calculated in the CalendarProvder, which is where I think it should be done.

That is a good call. I noticed that when I was reworking some stuff for the start of week changes. Nearly all the logic could be pulled up into the calendar provider and calculated there instead of within the components.
To be honest, the eventing was added as sort of an after thought so it's good to see it getting some attention.

I'm unsure why the dateAdapter tests are failing, they run just fine for me locally. Perhaps it's a timezone thing for where the tests are being run?

I'm unsure why the dateAdapter tests are failing, they run just fine for me locally. Perhaps it's a timezone thing for where the tests are being run?

Perhaps it's a timezone thing for where the tests are being run?

That may be the case. The tests failing during CI are correctly failing based on the criteria. There hasn't been an issue with tests regularly failing previously.
https://github.com/bruceharrison1984/Schedulely/actions/runs/5630688949/job/15256926107#step:6:32
If you look. at the test case you added, you explicitly defined a Zulu time. The other test cases utilize new Date, which makes them native to whatever TZ they are created. You might try changing your test and see if that fixes the issue.

a Zulu time

Never heard of this before, so just looked it up 😄 I've always just called it a UTC time :)

It's still UTC, but a specific format. I once worked on a project that dealt with TZs and the confusion between general UTC and a Zulu formatted one wasted hours of time in meetings 🤣 so now it just stuck with me.
If I can find some time today or tomorrow I'll check this out and hopefully get it merged in.
Thanks!


Create super basic BlueInk bar for accessing new _list/_show and pages tree

Based on the commercial/production BlueInk's UI, but all in HTML5 and CSS3:
http://demo.blueinkcms.com/

Long done.


Merge ZK ASM related changes to up-to-date upstream main

This PR is built by pulling the latest main from bytecodealliance/wasmtime and rebasing all ZK ASM changes on top of it.
The thinking is to switch to using the main branch of our repo for reviewed and ready-to-go code to help with code-search, discoverability, and other tools (CI/CD).

This makes sense to me. We can build a workflow that would do such a rebase for us nightly and/or create an issue if it can't be done – that way we're sure we're not lagging too far behind the upstream.

Unfortunately, I think you will need to
git push fork origin/zkasm-main-rebase:main

or somesuch as github does not allow fast-forward merges.

This makes sense to me. We can build a workflow that would do such a rebase for us nightly and/or create an issue if it can't be done – that way we're sure we're not lagging too far behind the upstream.

That would be pretty nice, would help us to discover any rebase issues much earlier!


Add support for adapting Bean values in list and map properties

BeanAdapter currently wraps nested Bean property values but not Beans returned from nested lists or maps. These values should be adapted as well.

This has been implemented but unit tests still need to be added.

This feature has been tested. RequestDispatcherServlet now uses BeanAdapter#adapt() to return the service's method descriptor list.


Problems after using pacman-optimize with the last pacaur update

Version
pacaur -v
4.7.8

Description
After using sudo pacman-optimize
/var/lib/pacman/local/libxrender-0.9.10-1/desc is -rw-r--r-- 1 root root 335 25 mar 22.28 /var/lib/pacman/local/libxrender-0.9.10-1/desc and pacaur is trying to open it every time i need to update or need to  install something, and of course raising a permission denied error
sudo ls -lah /var/lib/pacman/local/libxrender-0.9.10-1
totale 92K
d---------    2 root root 4,0K 25 mar 22.28 .
drwxr-xr-x 1358 root root  76K 14 mag 17.03 ..
-rw-r--r--    1 root root  335 25 mar 22.28 desc
-rw-r--r--    1 root root  421 25 mar 22.28 files
-rw-r--r--    1 root root  841  5 ott  2016 mtree

I'm not sure if this is and issue relative to last pacaur update behaviour or pacman-optimize so let me know if this is the wrong place
I fixed the problem manualli giving the permissions to /var/lib/pacman/local/libxrender-0.9.10-1

Not pacaur related.


pyodbc.ProgrammingError: ('42000', "[42000] [Microsoft][ODBC SQL Server Driver][SQL Server]Sintaxis incorrecta cerca de 'Mª'. (102) (SQLExecDirectW)")

Hello!
How can i deal with the "ª" character? thank you so much
Regards
Python 3.7 and pydobc 4.0.X

I'm not exactly sure what your scenario is, @manel00 , but here are some examples:
cnxn = pyodbc.connect(your_connection_string, autocommit=True)
crsr = cnxn.cursor()
print(crsr.execute("SELECT 'ª' AS col").fetchall())  # unicode character
print(crsr.execute("SELECT '\u00AA' AS col").fetchall())  # python unicode literal
print(crsr.execute("SELECT NCHAR(0x00AA) AS col").fetchall())  # SQL Server NCHAR() function
c = '\u00AA'
print(crsr.execute("SELECT '{}' AS col".format(c)).fetchall())
print(crsr.execute("SELECT ? AS col", c).fetchall())

for reference:
http://www.fileformat.info/info/unicode/char/00aa/index.htm
https://realpython.com/python-encodings-guide/#python-string-literals-ways-to-skin-a-cat
https://docs.python.org/3/howto/unicode.html


what is the Python.framework?

the Python.framework don't Open Source ???

Yes - it's open source. See the companion project Python-iOS-support. It's distributed as a binary because it's a lot easier to use, but you can compile it yourself if you want.


Filling up shuffle buffer (this may take a while): 4298 of 50000？

why？？？？？？？
tensorflow/core/kernels/data/shuffle_dataset_op.cc:135] Shuffle buffer filled.

You can see the document about tf.data.TFRecordDataset.
This method is just to set a buffer for shuffling the data.
The value of buffer_size can be set by yourself.


Ruby 3 compatibility

Jira story: https://doximity.atlassian.net/browse/SREP-199

Makes compatible with ruby 3.x
Replaces kwargs with positional args in middlewares

wrong base branch, closing


[Website] : Image is not showing on the website

Current State of the Meshery.io site

On this page meshery.io/catalog the image is not showing up.

Desired State of the Meshery.io site

The image should be properly loaded on the website.
Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Closing this in favor of #1972


Info icon has wrong indent

Actual Behavior

Environment
https://github.com/novasamatech/nova-spektr/commit/023df867e4ea11596d331f02f572caada4bbeaf6

Still reproduce in some additional places:

Your Delegation

Multisig operations - info button

Status verification: ✅


snyk 2.1

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

master on mochajs/mocha already has even newer versions debug 3.1.0 and growl 1.10.3.


chore: Bump Rust dependencies and GitHub Actions

Description
Bumps Rust dependencies and GitHub Actions based on what Renovate reported.
Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Reviewer
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

Should we also bump to Rust 1.78.0 in this PR?

LGTM, will you do the release and tagging in a separate PR, or update the changelogs to have the new release versions and tag once merged?

Yes. I just wanted to release stackable-operator and leave all other crates as is. Any objections?

Should we also bump to Rust 1.78.0 in this PR?

Sure thing. I will bump it.

LGTM, will you do the release and tagging in a separate PR, or update the changelogs to have the new release versions and tag once merged?

Yes. I just wanted to release stackable-operator and leave all other crates as is. Any objections?

Since they all share the same workspace lock file, we probably need to release all?

LGTM, will you do the release and tagging in a separate PR, or update the changelogs to have the new release versions and tag once merged?

Yes. I just wanted to release stackable-operator and leave all other crates as is. Any objections?

Since they all share the same workspace lock file, we probably need to release all?
Edit: I see, they will just be unreleased changes in the other crates. Which could only pose a problem if they are used together where there are conflicting types?

Yeah it is a hard topic to handle. @nightkr touched on this as well today. I guess we should have a discussion about that at some point int time.
For now, I can release all of them to avoid any conflicts.

Monorepo with polyversioning: the simplicity and predictability of polyrepo and the flexibility of monorepo.. :P

I think https://github.com/Byron/gitoxide might be a good repo to look at on how to handle versioning.

I'm a bit surprised that we released this as 0.67.1 instead of 0.68.0, as we do a minor (thus breaking change) bump of re-exports such as kube and k8s-openapi. E.g. an product-operator building a Volume or a PodSecurityContext itself will break.
No need to do anything and it will probably be fine, just wanted to make sure we are on the same page going forward :sweat_smile: And yes I'm being pessimistic here :D


What is channel for .net 5.0

doesn't work
./dotnet-install.ps1" -Channel 5.0 -InstallDir C:\dotnet
./dotnet-install.ps1" -Channel preview/5.0 -InstallDir C:\dotnet

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2e484a9-5e0c-eb3e-1413-7b507c4fa07d
Version Independent ID: 5bc7caa5-f1c2-d7d5-fe02-80c65cca9672
Content: dotnet-install scripts - .NET Core CLI
Content Source: docs/core/tools/dotnet-install-script.md
Product: dotnet-core
Technology: dotnet-cli
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

works with
./dotnet-install.ps1" -Channel master -InstallDir C:\dotnet
./dotnet-install.ps1" -Channel release/5.0.1xx-preview3 -InstallDir C:\dotnet


Issue with JTE (also migrated to 2.0?)

@casid could you have a look?

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project javalin-rendering: Compilation failure: Compilation failure:
Error:  /Users/runner/work/javalin-rendering/javalin-rendering/src/test/kotlin/io/javalin/jte/precompiled/JtetestGenerated.java:[3,32] package io.javalin.TestTemplates does not exist
Error:  /Users/runner/work/javalin-rendering/javalin-rendering/src/test/kotlin/io/javalin/jte/precompiled/JtetestGenerated.java:[9,121] cannot find symbol
Error:    symbol:   class JteTestPage
Error:    location: class io.javalin.jte.precompiled.JtetestGenerated

Tests work fine locally.

That's odd, I'll check out the repo and have a look at it.
Also, yes, there was bump to version 2.x, because of a breaking change how to call other templates. There's some details here: https://github.com/casid/jte/releases/tag/2.0.0 Migration of existing templates is semi-automatically, the engine detects old templates and spits out code to migrate them, so it's not too bad.
Can do a PR to the latest version if you want to. Is this a separate repo, where you're moving the template integrations to?

Can do a PR to the latest version if you want to. Is this a separate repo, where you're moving the template integrations to?

Thank you! For Javalin5 all template engines will be found in the javalin-rendering artifact, which will live in this repo :)

Thanks @casid !


Update dcos test utils

High-level description
What features does this change enable? What bugs does this change fix?
Flaky Test for Metronome on Looking at Job Run History
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4294 Flaky Test for Metronome on Looking at Job Run History

Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review


update readme

i tried to use the default
import { YouTube } from 'react-youtube';
This did not work for me.
Not exactly sure why.
Probably something with the default export.
This PR should fix the issue for now for most people to get started better.
If you can figure out how to make the default import statement work that would be great too.
Either way should be a good pr to merge to get people that don;t want to look into it started quicker.
Great work btw.

We use
export default YouTube;

https://github.com/troybetz/react-youtube/blob/master/src/YouTube.js#L307
So your import should look like:
import YouTube from 'react-youtube';

(without {} brackets)
as you can see in the example application that is included in this repository: https://github.com/troybetz/react-youtube/blob/master/example/example.js#L3
The import { ... } from '...'; syntax is used when importing non default exports.
I like the addition to the sample code in the readme but I'd prefer you change the require().default to the import YouTube syntax.

Great! 👍
Thanks for your contribution.


update istio proxy sha

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GregHanson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test istio-unit-tests

prow//e2e-simpleTests-minProfile.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test istio-unit-tests

prow//e2e-simpleTests-minProfile.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-multicluster-e2e.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Review the full test history for this PR.
/lgtm cancel will stop retrying.

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Review the full test history for this PR.
/lgtm cancel will stop retrying.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-multicluster-e2e.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
559a1a39d76e58f582509fa0f1d00fb105afbad2
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Assemblies in the DLLs folder are not loaded properly

Assemblies in the DLLs folder are not loaded properly. This only occurs for .NET Core since the assembly probing occurs differently.
Changing InitializeExtensionDLLs to use AddReferenceToFile loads the assembly into memory (as I tried in https://github.com/IronLanguages/ironpython2/pull/523), however when the sqlite3 module calls AddReference("IronPython.SQLite") the assembly still fails to resolve.

I read around that you have to use AssemblyLoadContext.Default.LoadXXX from System.Runtime.Loader have you tried that?

Haven't tried it, but it's something I'd like to avoid since it appears to be a .NET Core specific API and I'd like to be able to switch to .NET Standard 2.1 assemblies eventually.


Disable switch blocks when inserting multiple random blocks in storage

Fixes #2947
This PR adds a test method to Block to force it to be a non-switch block.
This is used in storage tests where multiple random blocks are generated and inserted into storage. Storage rejects a block if it's a switch block and it already has one for that era, which is undesired behavior for the failing test in #2947 and others.
The original test which surfaced the issue, should_restrict_returned_blocks, previously used the storage block generation function random_block_at_height, which in turn used Block::random_v1, which generates switch blocks ~50% of the time. Since the issue was created, this specific test has moved to Block::random_with_specifics, which allows users to specify if they want the block to be a switch block or not, and so the issue was fixed. In this PR, tests which are still using random_block_at_height and insert multiple blocks into storage are modified to ensure at most one switch block is inserted. This is done regardless of the EraId generated for simplicity, but if need be, we could also test for the EraId and disable switch blocks only when ids match, but at that point we should be looking at a function which generates multiple semantically-correct blocks.

bors r+


Add missing dmspeak doc page

This was missed out from #278 (sorry).

@Wynndow looks like that bit was missing too, good spot. Fixed up in https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/279/commits/2a1351734c25c6d4cfc4bb0306eee7ed574b3608.

👍


I need to get access to youtube api, so how can I set scope?

Hi, i've downloaded your asset, and it's working for me, but I need somehow set scope, as example from google:
GoogleSignInOptions gso = new GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)
				.requestServerAuthCode(getString(R.string.server_client_id))
				.requestEmail()
				.requestScopes(new Scope("https://www.googleapis.com/auth/youtube.readonly"))
				.build();

Like in example above I need set scope, so user could give me access to youtube.
Could you please help me and write how could I do it?

@loukaspd as I see here:
android-google-signin-unity/AndroidLibrary/app/src/main/java/gr/loukaspd/googlesignin/GoogleSignInFragment.java you didn't add the ability to set scope somehow? Am I right?

You are correct, you'll need to edit GoogleSignInFragment.java, rebuild and replace the jar inside Plugins/Android folder.
What exactly do you want to do with youtube api? Can do that from Unity, or you will have to add all the functionality inside GoogleSignInFragment?


breaks when padding strings with weird characters

Unicode has characters that take up 2/+ spaces, zero spaces, half spaces, and even some that take up multiple lines like 𒐫. For example, "操作类型".length == 4, but it takes up 8 columns when rendered.
This breaks the pad function when you're using it for visual alignment, which I think is a pretty common use-case. You can mostly fix this by getting the visual length of the string with wcwidth and using that for all calculations in the function... wcwidth isn't perfect, but it seems to fix most of the issues that affect Chinese characters.
Also, I'm not sure how you'd work around the usage of multi-column wide pad characters.

OK, interesting issue, it took me a second look at your description to really understand its topic. I didn't know some character, like in chinese, take more than one column to display. Here are the pros and cons:

Using wcwidth for all length calculation will introduce a new and first dependency to this lib
It will slow performances
It could be made optional, concerned users like chineses, would have to install the dependency and pass an option, perfermances will be preserved for others but it will much less convenient for the concerned crowd

What's your opinion on this ?

I don't think there's a good way to solve this because character width in Unicode introduces some really ugly problems. However, I do think pad should "just work" to the greatest degree possible, especially with characters that users are likely to run into. Adding a way to pass in a custom length function just means that users need to learn about this Unicode issue on their own and solve the problem themselves, rather than having it work automatically. I could see how disabling wcwidth usage could be desirable, but for the average user, I think they want to pad strings to the width that the string will be displayed at.
I found out about this issue after getting bug reports from users of tidy-markdown who were trying to format tables that had Chinese characters. That project uses pad to handle table alignment, so removed it for now: https://github.com/slang800/tidy-markdown/commit/afba38be39d814ef5df1a16bbefd7b3f078960cf.
Normally, I don't work with Chinese characters, so I would have never noticed this on my own and only fixed it because someone who does write in Chinese started using my software. So, I don't think that only Chinese users will have to worry about this - my software could end up being used by anyone.
Side note: implementations elsewhere,  like rjust / ljust in Python also don't handle Chinese chars correctly.

I agree with your reflexion. Fixed with #639d57a17339a1727cc33e8a564c009d72023ea4. I also am not concerned with multi column chars so let's hope this commit fix it right.


Constant problem with line endings

No amount of git reset or brew/cask commands seem to able to fix this persistent problem.
OS X 10.11.5
$ brew -v
Homebrew 0.9.9 (git revision 2cd8; last commit 2016-06-05)
Homebrew/homebrew-core (git revision b13e; last commit 2016-06-06)

$ brew cask --version
0.60.0 (git revision 35aa; last commit 2 hours ago)

$ brew cask update
==> warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.
==> The file will have its original line endings in your working directory.
==> Cannot rebase: You have unstaged changes.
==> Please commit or stash them.
==> warning: CRLF will be replaced by LF in test/support/binaries/2_app_caffeine
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/2_app_subdir.z
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/GMDesk-1.01.ai
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/NestedApp.dmg.
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/caffeine.zip.
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/caffeine_suite
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/sheldonmac.sit
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/transmission-2
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/2_app_caffeine
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/2_app_subdir.z
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/GMDesk-1.01.ai
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/NestedApp.dmg.
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/caffeine.zip.
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/caffeine_suite
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/sheldonmac.sit
==> The file will have its original line endings in your working directory.
==> warning: CRLF will be replaced by LF in test/support/binaries/transmission-2
==> The file will have its original line endings in your working directory.
==> Cannot rebase: You have unstaged changes.
==> Please commit or stash them.
To restore the stashed changes to /usr/local run:
  'cd /usr/local && git stash pop'
To restore the stashed changes to /usr/local/Library/Taps/caskroom/homebrew-cask run:
  'cd /usr/local/Library/Taps/caskroom/homebrew-cask && git stash pop'
Already up-to-date.
warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.pcap.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.png.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.pcap.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in Library/Homebrew/test/fixtures/test.png.
The file will have its original line endings in your working directory.
Cannot rebase: You have unstaged changes.
Please commit or stash them.
warning: CRLF will be replaced by LF in test/support/binaries/2_app_caffeine.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/2_app_subdir.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/GMDesk-1.01.air.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/NestedApp.dmg.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/caffeine.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/caffeine_suite.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/sheldonmac.sit.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/transmission-2.61.dmg.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/2_app_caffeine.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/2_app_subdir.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/GMDesk-1.01.air.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/NestedApp.dmg.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/caffeine.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/caffeine_suite.zip.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/sheldonmac.sit.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in test/support/binaries/transmission-2.61.dmg.
The file will have its original line endings in your working directory.
Cannot rebase: You have unstaged changes.
Please commit or stash them.

Please see https://github.com/Homebrew/brew/issues/326 (most likely related)

This has nothing to do with us, as brew cask update is just an alias for brew update. Likely you need to change your core.safecrlf or core.autocrlf git config either globally or in your Homebrew repository.


Implement Rojo-like folder-as-module support

Lemur should support the same sort of file structures that Rojo does.
In Roact, I wrote code to do this in the benchmark and spec scripts, which seems non-ideal. Essentially every project I've started brings in that function or something equivalent to it.
Rojo is (currently) the standard tool for syncing code into Roblox from the filesystem, so lining up with its conventions makes sense. Rojo also happens to line up with how stock Lua loads folders as modules.

Closed by https://github.com/LPGhatguy/lemur/commit/74286fdacd7ba01024d18839371d6b8aa4b8ff96.
The optional loadFromFs option loadInitModules, which is enabled by default, controls this feature.


I need a short written course on how to use it.

This database is very good, however, there are some things that I do not understand. If you could give me a fragment of the code of musicium or milrato with these databases it would be very good.
If not, I need an explanation of how it works written. Advanced codes, use of the database, etc.

I wait much for u response :v


Ratings 2

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d1d045b-7d92-acd8-0df5-d1d53992febb
Version Independent ID: 22c56721-c08c-fd8f-b940-92b834233f74
Content: Age ratings - UWP applications
Content Source: windows-apps-src/publish/age-ratings.md
Product: uwp
Technology: publish
GitHub Login: @hickeys
Microsoft Alias: hickeys

No details provided.


Improving root level readme

Improving readme

@rhlsthrm plz provide some feedback. This will be updated more in the near future, but this is just to get a basic update out asap

updated copy as per comments

Weird that builds are failing...

Might be bc of fork. Merged anyways.


Wait for center on next unit when issuing commands to settlers

Again some nitpicking....
Basically when you issue orders to a settler (to e.g. build a road), the icon R (or I for iirigation etc.) should first be visible on the settler, and only then can you center in to the next waiting unit.  Similarly if this settler finishes building a road (or irrigation ...) in this same turn when you issued the command, then this road should first be visible and only then can the next unit be shown.
Basically now CivONE switches to the next unit immediately and you cannot see the icon on the settler.

I will have a go at this soon... but not high priority at the moment...

Is this possibly linked to the turn-ordering and popups/sidebar info issues?

This issue has already been resolved.


qownnotes: 23.6.0 -> 23.6.3

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from repology.org.
meta.description for qownnotes is: Plain-text file notepad and todo-list manager with markdown support and Nextcloud/ownCloud integration
meta.homepage for qownnotes is: https://www.qownnotes.org/
meta.changelog for qownnotes is: https://www.qownnotes.org/changelog.html
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 23.6.3 with grep in /nix/store/bcsn2c6ynz1hrpv380w1m361bqzn84ch-qownnotes-23.6.3
found 23.6.3 in filename of file in /nix/store/bcsn2c6ynz1hrpv380w1m361bqzn84ch-qownnotes-23.6.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
qownnotes

Instructions to test this update (click to expand)

Build yourself:
nix-build -A qownnotes https://github.com/pbek/nixpkgs/archive/906a174cd9dbdca5910e6f40a49bd3296215960d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bcsn2c6ynz1hrpv380w1m361bqzn84ch-qownnotes-23.6.3
ls -la /nix/store/bcsn2c6ynz1hrpv380w1m361bqzn84ch-qownnotes-23.6.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

qownnotes

Maintainer pings
cc @pbek @totoroot for testing.

Result of nixpkgs-review pr 236699 run on aarch64-darwin 1

1 package built:

qownnotes

Closed in favor of https://github.com/NixOS/nixpkgs/pull/236844.


channel,ui: Add the 'Releases' tab to the channel view

These are separate from the channel playlists, and are usually much more nicely structured in e.g. music channels.

Very good, thank you for this PR. This will be merged after testing.

This PR is accepted, but won't be merged directly only due to being slightly nocompat with the new commits that are about to be pushed. However, I have adapted your patch to the new tree, and it will be pushed to remote shortly.
Many thanks, this PR will be closed.

The commit is here, for your reference: https://github.com/darkhz/invidtui/commit/3b9f50abe8f2287ac972748bd42f3b6b34f48abe


Group metrics by label

It should be possible to specify a label (optional) for each metric so that groups of metrics are plotted separately on the PR comment.

What does label mean? From your description it sounds like multiple metrics can share the same label. If that's the case I find it confusing. Why not "group"?

Group sounds more accurate, you are right.

@letmaik I think the idea is to have either multiple pictures or maybe multiple sections of subplots that contain all the metrics in each group. “Micro-benchmarks”, “Distributed Tests on DC8”, that sort of thing. Same in monitoring issues.

It looks like matplotlib now supports subfigures (https://matplotlib.org/devdocs/gallery/subplots_axes_and_figures/subfigures.html), so this might be a good way to go. It opens up a bunch of questions about layout, I think the simplest would be to have a vertical array of subfigures, each full-width, containing a matrix of subplots like now, but with a fixed number of horizontal elements to keep the plots the same size and aligned across labels.
I also wonder if "category" would be a better name than "label" because it less obviously implies the ability to have multiple values and sounds more hierarchical.

It looks like matplotlib now supports subfigures (https://matplotlib.org/devdocs/gallery/subplots_axes_and_figures/subfigures.html), so this might be a good way to go. It opens up a bunch of questions about layout, I think the simplest would be to have a vertical array of subfigures, each full-width, containing a matrix of subplots like now, but with a fixed number of horizontal elements to keep the plots the same size and aligned across labels.
I also wonder if "category" would be a better name than "label" because it less obviously implies the ability to have multiple values and sounds more hierarchical.

Tried quickly swapping in sub-figures in #126, but it doesn't seem work at all with add_subplot(). Instead, examples pre-create static subplot matrices, and many of the calls are renamed (eg. supxlabel()) or perhaps not available.

We will probably refine this, but there is now basic support for grouping metrics visually, which I think is good enough to use.


Propose to define processor types

Currently we all call them processors, but as you know, processors can be sightly different. Here are the types I see:

Only has outputs, no inputs (data source)
Only has inputs, no outputs (data sink)
Has both inputs and outputs

If this terminology makes sense, it will help user to understand the infrastructure of an application more clearly. And dashboard can use processor types to do:

Render DAG nodes in different colors
Filter particular processor types for inspection

What is your thoughts on this?

+1
See #1383 which was never merged. I think this will be a requirement to handle upcoming integration challenges with TAP, ATK. Also, perhaps now within the context of akka-streams this now makes more sense.

PR to add nifi operators to apex's malhar library. This is their way to add new operators to the malhar repo. Similar concept: how to easily add different types of processors and make them available.

+1 on the general idea.
@stanleyxu2005, what the expected behavior to tell processor type? subclass?

Currently dashboard check the number of inputs and outputs. Subclasses is a good idea.

Pickle has a particular way of conveying subclasses. I think different JSON serialization libraries do it in different ways. Having icons specific to source, sink based on inputs, outputs seems conservative and safe. When I did the scalajs classes related to metric types I encoded the class type in the serialization so the javascript side could build the correct Map[type, list] subcategories.

Moved to JIRA. See https://issues.apache.org/jira/browse/GEARPUMP-84


[TACHYON-417] Move TachyonURI to Common

https://tachyon.atlassian.net/browse/TACHYON-417

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/3130/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/3131/
Test FAILed.


Server hosted documentation

Documentation should be served by your own BitPal instance, to keep it always available and updated to your specific version.
Closes https://github.com/bitpal/bitpal/issues/66

Some documentations I like:
https://documentation.divio.com/
https://docs.djangoproject.com/en/dev/#how-the-documentation-is-organized
Grouped in general groups:

Tutorials
How-to guides
Explanations
References
FAQ
Introduction (probably goes into the main bitpal.dev site instead)

While this doesn't contain anything near full documentation, it does generate a decent looking doc endpoint from markdown files that we can start filling in.


Implemented DI in backend

There's DI in the Functions now, according to #1  .
All the tests still seem to work, so I'm expecting I didn't break anything. 🤓
This is the same PR as this one, now targeting the new backend repo. Thanks for the comment @cecilphillip!

closes #3

closes #1


Increase runloop spin frequency

We probably waste a lot of time waiting on conditions that resolve very quickly. Instead of waiting for this every second we can still be prudent in terms of system resources (by not checking the condition continuously) but also resolve conditions faster by setting this to 100ms instead

lgtm


Template expressions only work if they start and end the line

This was an ongoing GitHub discussion for a while. The current (Oct 2018) implementation of template expressions only work if the entire line is wrapped in a template expression. If the line doesn't start with a template expression then it won't be evaluated as such.
This has been resolved in an update that is supposed to go out soon and should be available for all accounts from what the GitHub poster says. https://github.com/Microsoft/azure-pipelines-agent/issues/1772

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6724abea-bbdc-bf66-ed5e-3214fa6c3e66
Version Independent ID: 4f8dab21-3f0e-da32-cc0e-1d85c13c0065
Content: Job and step templates - Azure Pipelines & TFS
Content Source: docs/pipelines/process/templates.md
Product: devops
GitHub Login: @vtbassmatt
Microsoft Alias: alewis

Thanks! This change is coming soon enough that I don't want to document the current (poor) behavior.


Flash messages bumping footer

Expected behaviour:
Body resizes accurately regardless of how much content is on a page.
If there is less content than can fit the screen, the remaining space will remain empty while the footer is in the bottom of the screen.
If there is more content than can fit the screen, the footer will be bumped down and will only be fully visible by scrolling down.
Current behaviour:
Body resizes correctly, unless there is a flash message present on the page.
The body is assuming enough space to have the footer on the bottom of the page, but the footer is bumped down the same amount of pixels as the flash messages are taking up.
Potential fixes:

Use js/python to keep track of how many flash messages are queued up, and adjust the body height accordingly.
Make the footer sticky and add extra bottom margin on the body to ensure the footer won't cover up any content on full pages.

Issue caused by inherent margin to h3 tag used in flash messages, imported by materialize.
issue fixed by overwriting the margin in CSS file


Add names to SudokuDetailProcessors + first stab at docs

Sudoko detail processors (actors) didn't have custom names: added them.
Started updating exercise READMEs

LGTM


Adding custom sorting for column

I dont see an option to set a custom sorter function to the column meta data? Is it possible? If not, is this in pipeline?

Thanks @ryanlanciaux . Love the simplicity of griddle though, eagerly waiting for 1.0 :+1:

Thanks @ryanlanciaux . Love the simplicity of griddle though, eagerly waiting for 1.0 :+1:

One way in which I was able to workaround this problem - noting if it helps someone else. I added some meta information to the column text so that sorting by ascending/descending order works. I also added a custom formatter for that column so that I show just the stuff I want.

@ragebiswas Could you elaborate more on how you did this? My Custom Components are not sorting correctly, instead they sort on another column when the header is clicked, for some reason.

@ADanilychevJr Suppose you want to sort on column foo, but wish to modify the logic to something other than the default alphanumeric sort offered by griddle. What you have to do is:

use a custom renderer that shows the data that you want
map each value of your column to a "sortable" string/number.

For example, if you want to sort by a field called status, where the values should be sorted as Open < Active < Closed. The default griddle sorting would give this order: Active < Closed < Open.
To fix this, map each status to an int value (open -> 1, active -> 2, closed -> 3). Use this as the column value in griddle, and for rendering use a custom renderer that renders the strings. Since griddle would sort on the values, you would get the correct sorting order.

@ragebiswas Thanks so much! That was exactly the solution I was looking for. I didn't realize that columnName was what the table sorted on for custom Components (thought it was the plaintext in your custom render)

Sorry about the delay on this one but we have released Griddle 1.0 -- custom sorting methods can be passed in on columnDefinitions now. Please see customization documentation and the code here for supplying customSort. Closing this one for now but please feel free to open a new issue if there are any problems :+1:

@ryanlanciaux custom sort link is broken

@harishmohanani custom sort link has been fixed.
GitHub tip: to turn any link into a permanent link (with SHA instead of branch/tag name), press y.


reference-manual: boards: Added am64xx-sk flashing instructions

This provides the flashing instructions for the Texas Instruments AM64x SKEVM board.
Signed-off-by: Tim Anderson<EMAIL_ADDRESS>

Docs for 5f064c62b88ef209938b9bb7282dcbdc60ed9fb6 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/893/docs/artifacts/html/index.html

@MatthewCroughan can you please look at this and comment/approve? thanks in advance

Docs for a5f59fa7b69393aea84418bf34463c06988e14c3 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/896/docs/artifacts/html/index.html


Ukrainian font

Many games have a problem with the Ukrainian font, namely with the symbols Ї, є and i. The fonts arialuni_sdf_u2019 and arialuni_sdf_u2018 rarely help. Can you fix them?

You have to use a custom font, check the readme for font overriding.

I read the readme. If I understood correctly, I use custom fonts by default.
MaxCharactersPerTranslation=750
IgnoreWhitespaceInDialogue=False
OverrideFontTextMeshPro=arialuni_sdf_u2019
FallbackFontTextMeshPro=arialuni_sdf_u2018

Если игра моно у меня есть решение для melon loader
Если l2cpp то тоже для melon loader но только для 0.5.7

It was originally on reipatcher. Now I managed to put melon 0.5.1 & XUnity.AutoTranslator-MelonMod-5.3.1. what recommendations?

update melon loader to 0.5.7
MaxCharactersPerTranslation=2200
IgnoreWhitespaceInDialogue=False
OverrideFontTextMeshPro=
FallbackFontTextMeshPro=

It was originally on reipatcher. Now I managed to install melon 0.5.1 & XUnity.AutoTranslator-MelonMod-5.3.1. what recommendations?

update melon loader to 0.5.7
MaxCharactersPerTranslation=2200
IgnoreWhitespaceInDialogue=False
OverrideFontTextMeshPro=
FallbackFontTextMeshPro=
TemplateAllNumberAway=True
https://github.com/bbepis/XUnity.AutoTranslator/issues/628#issuecomment-2495539132
download the archive that I have in the link and take it from there
mods/Font/*
mods/FontOverride.dll
mods/FontOverride.ini
and put it in your game along the same paths

The game does not run if the melon version is higher than 0.5.1.

The game does not run if the melon version is higher than 0.5.1.

then try the same thing without updating Melon download and place the font mod file fix the configs

The game does not run if the melon version is higher than 0.5.1.

then try the same thing without updating Melon download and place the font mod file fix the configs

only this

MaxCharactersPerTranslation=2200
IgnoreWhitespaceInDialogue=False
OverrideFontTextMeshPro=
FallbackFontTextMeshPro=
TemplateAllNumberAway=True

download the archive that I have in the link and take it from there
mods/Font/*
mods/FontOverride.dll
mods/FontOverride.ini
and put it in your game along the same paths

The game runs only on the plugin version 0.5.1, or 0.6.5. Version 0.6.5 does not load the library System.dll. After transferring your files, then there is an error at startup. I tried also with the full archive changing the settings according to the readme, but then it saw node.js but did not load the library. Sometimes it did not even see the node_GoogleTranslator_server folder. I also tried the latest version of BepInEx, but it just doesn't see it. All in all, I'm tired and will just use LunaTranslator.
Thanks for your help.

the game is built on a very old engine and the tmPRO library
It's also old and doesn't support dynamic fonts...
In general, the font correction mod will not work with this game

It's sad. Thanks for your help, anyway.


Read GeoTiff with adequate projection and numeric values

Currently .tif files which contain spatial coordinates with respect to a CRS are being read as an image losing information about he coordinates and also the values do not need to be colors. We can fix it by reading the file with ArchGDAL.jl and make the conversion to Meshes.jl.

Thank you @ErickChacon , I think we can use TiffImages.jl directly to read geotiff in pure Julia.
Related: https://github.com/tlnagy/TiffImages.jl/issues/100

Interesting! I already have a code using ArchGDAL.jl. However it might be interesting to set it up using TiffImages.jl and just include it inside GeoIO.jl?

@eliascarv just finished a code using ArchGDAL.jl as a workaround until TiffImages.jl supports geotiff metadata. We should be reviewing a PR this afternoon (BRT).

Sounds good!


[Production] Icons in Configure Notifications widget are incorrect

Steps
Log in to osf.io
Navigate to a project
Go to the settings page for that project and scroll down to the Configure Notification widget
Look at icons next to project/components
Expected
I expect that the icons displayed would be the same as the ones on the project organizer and the file grid on the project dashboard page.
Actual
The icons are all folders
.
Screenshots

I'll fix this.

Fix is merged; will be released in 0.41.0


⚠ linktree/kiondaga has degraded performance

In 99d0140, linktree/kiondaga (https://linktr.ee/kiondaga) experienced degraded performance:

HTTP code: 200
Response time: 173 ms

Resolved: linktree/kiondaga performance has improved in 20f1206 after 16 minutes.


Add !timestamp command

This command extracts the timestamp of a message from a given Discord snowflake ID.
Two formats allowed (i.e. overloaded arguments):

!timestamp <snowflake ID>

Defaults to Pacific Time

!timestamp <Canonical Olson Database Name> <snowflake ID>

e.g. !timestamp Asia/Seoul<PHONE_NUMBER>37445673
Works with a provided timezone

Dependency Changes

New dependency added: dateutil (python-dateutil==2.8.1)

LGTM!


After upgrade Ubuntu Gnome from 16.04 to 16.10 dock station reconnect is required to get evdi working

After upgrade Ubuntu Gnome from 16.04 to 16.10 dock station reconnect is required to get evdi working, both after reboot and after cold boot.
Lenovo ThinkPad Helix 1gen
Lenovo ThinkPad USB 3.0 Dock (model DU9019D1)
Driver version: 1.2.65
Ubuntu Gnome 16.10 x86_64
Linux 4.8.0-22 (generic build)
intel DDX instead of modesetting DDX
evdi messages in dmesg at boot:

[   10.389803] evdi: [I] Initialising logging on level 5
[   11.345813] evdi: [D] add_store:195 Increasing device count to 1
[   11.350148] evdi: [D] evdi_crtc_init:312 drm_crtc_init: 0
[   11.353880] evdi: [W] evdi_painter_crtc_state_notify:377 Painter does not exist!
[   11.353884] evdi: [D] evdi_detect:72 Painter is disconnected
[   11.353889] evdi evdi.0: No connectors reported connected with modes
[   11.354764] evdi evdi.0: fb1: evdidrmfb frame buffer device
[   11.354768] [drm] evdi: evdi_stats_init
[   11.354773] [drm] Initialized evdi 1.2.64 20161003 on minor 1
[   17.337795] evdi: [W] evdi_painter_disconnect:478 (dev=0) An unknown connection to ffff91558d6bde00 tries to close us
[   17.337797] evdi: [W] evdi_painter_disconnect:479  - ignoring

I assume that between 11 and 17 seconds user enter password in gdm and perform login.
After dock station reconnect external screen get enabled.
Booting with Linux 4.4.0-43 left from Ubuntu 16.04 does not workaround this issue - I still get same error message with Linux 4.4.0-43.

Hi @RussianNeuroMancer
Thanks for report. This looks like problem in DisplayLinkManager so please raise this on DisplayLink Linux Forum; take a look at our support page.

Thanks for answer! Issue is reported on forum.


[ownership] Update sil-combine for OSSA.

@gottesmm I'll hold off reviewing this for now because is may be out-of-date

This was done in a different PR and is stale. Closing!


[crypto/bn] constant-time modular inversion

This is joint work with @sohhas. We did some work in NSS for CT inversion last year, and this patch is roughly half porting that work, and half new code due to differences in inversion strategies between the libraries.
The diff is not really useful to review here. Take out the BN_gcd function, and the rest of the code is almost all new.
In master, there are essentially three algorithms to compute the same thing using different ways; none are completely constant time (see e.g. Sec. 6.5).
The new code also has three algorithms:

CT inversion with an odd modulus
CT inversion with a power-of-two modulus
CT inversion with a power-of-two modulus where stuff fits in words

For generic even modulus, there's some CRT stuff to compute the result with (1), either (2) or (3), followed by some short math. A short discussion on that follows. For random even modulus, the typical flow is (1,3,3). Outside the artificial KATs added in this PR, I never hit the (1,2,2) case in make test. So that is why (3) exists, even if it is functionally redundant given (2): it is faster and cleaner.
For (EC)DSA stuff and in general ECC, all that matters is (1) above.
RSA-related inversions are really the only other concern here. For a "random looking" even modulus, the flow through this code will be mostly (1) with a large modulus and (3) with an overwhelmingly small modulus. It means that, performance wise, there shouldn't be much of difference between an odd modulus and a random even modulus.
For the even modulus case, this code assume the power-of-two (i.e., the output of "count trailing zeros" given the modulus) is public. I claim this is OK in the context of RSA in the (rare) case of using any secret composite moduli; consider these two scenarios.

I am a side-channel capable attacker. I use a lot of measurement effort and somehow learn the (fixed) power-of-two, perhaps with repeated measurements and profiling. I use this information in some super special attack.
I am not a side-channel capable attacker. I guess the (fixed) power-of-two, and run the same super special attack with that. For a b-bit modulus, there are only b powers to check. So at most I run b instances of my attack, and the probability of the correct b is negligible in b.

This is the end of me whining that it's hard to protect the power-of-two.
We generated the unit tests deterministically with a python script; we can provide that upon request.
Tagging @cpereida for (unofficial) review.

I don't think it will be a surprise that this is post 3.0 :)
The test generating script would be interesting I think.  Perhaps in the openssl/tools repository?  We've other test generation there in Python.

The CI failures on Windows builds are relevant.

The CI failures on Windows builds are relevant.

I don't know how to make those false positives go away without stuff like this ... any tips?
(at least, I am pretty sure they are false positives ...)

That kind of pragma mess is the best way I think.  We don't have BN_LONG to cast to.
The only other thing is to emulate the 2s complement negation -x <=> 1 + ~x which is worse.  I'm pretty sure we rely on 2s complement arithmetic in various places.

I can't believe that that fix worked....

I can't believe that that fix worked....

It sounds ridiculous, doesn't it! Untested, so let's see what the CI says ..

I forgot to say -- this PR makes the function oblivious to the BN_FLG_CONSTTIME flag.
(Which, I think by my count, means only modular exp left!)

I opened #16232 to discuss within OTC the option to remove support for BN_mod_* operations with negative moduli; in the meantime should we add KAT for negative moduli? Otherwise the negative modulus codepath goes untested, right?

should we add KAT for negative moduli? Otherwise the negative modulus codepath goes untested, right?

Good point! Can't believe I missed that. Fixed in 0274ffd6a208174c320550a8524a32d88dfbb1f8
Maybe I should sanity check with master just in case.

For the even modulus case, this code assume the power-of-two (i.e., the output of "count trailing zeros" given the modulus) is public.

Other than setting up Montgomery contexts (which only inverts a single word), the one place I can think of with a secret even modulus is in RSA key generation, to compute d = e^1 (mod totient).
You're probably right that the output of count trailing zeros can be assumed public here, but this is also not a performance-sensitive part of RSA keygen. The primality tests dominate by far. Rather than worry about this, I adapted the binary GCD algorithm. It's not particularly fast, but it doesn't matter for this.
https://boringssl.googlesource.com/boringssl/+/refs/heads/master/crypto/fipsmodule/bn/gcd_extra.c#169
Unless I've forgotten one, I believe all other inversions in cryptography use either a public prime modulus, or a public near-prime modulus (RSA n). The former we do with FLT, and the latter we do with a blinding trick:
// May fail if n has too many factors, but n = p*q, so it is as likely as
// accidentally stumbling on p or q.
mod_inverse(a, n):
  r = random(1, n)           // May leak n, but n is public. Does not leak secret r.
  b = mod_mul(a, r, n)       // Montgomery reduction, so no leak of a or r.
  inv = leaky_mod_inv(b, n)  // Leaks b, but b can be public. Note inv = a^-1 * r^-1 (mod n)
  return mod_mul(inv, r, n)  // Montgomery reduction, so no leak of r

You're probably right that the output of count trailing zeros can be assumed public here, but this is also not a performance-sensitive part of RSA keygen

@sohhas and I added some hardening in 537f242bb9bc027a7b4236d7a2be2e7091c1e405
It now leaks the position of the least significant non-zero word. Since the code inherently diverges based on that position, it doesn't make sense to try any harder than that (with this approach).

the one place I can think of with a secret even modulus is in RSA key generation

Yes computations modulo the totient is also all we had in mind, too. So the above will leak fixed information for roughly one key in every 2**BN_BITS2 keys, which is not significant IMO. (Again, an attacker can just assume that and run the attack with no side-channel information.)

It now leaks the position of the least significant non-zero word.

Yeah, that'll require addressing the ever-present #6640. I can report it is indeed possible to solve that problem.
But I don't think that commit addresses idx_o. Even computed constant-time, it's leaked in all the other operations. BN_rshift, for instance, will access memory differently depending on the amount you shift by. (We have a bn_rshift_secret_shift that conditionally shifts by powers of two for the couple of places this matters. Both, I believe, in RSA key generation.) bn_mod_inverse_pow2  also appears to treat the modulus as public. And, of course, by shifting bits away, you change the size of the input and, in turn, means #6640 kicks in further.
(One of these days I should write up what it took to get to constant-time RSA keygen. It's doable but takes quite a lot of bashing on the problem. There are a tons of operations unique to RSA keygen.)

bn_mod_inverse_pow2  also appears to treat the modulus as public

Thanks! Made some adjustments in 1077f3137eed8f7ba7255fdb9ab9deb73d2ec160, considering the overwhelming codepath through bn_mod_inverse_pow2 is to take the early exit to bn_mod_inverse_pow2_word.

The Windows CI is failing after 1077f31 and I have no idea :man_shrugging: at this point I'm just trying things and querying the CI. Could use some help since I'm a linux-only dude.
I thought it was undefined behavior because of the shift, but it seems that's not the case or a52f5d20dca8c2068d805136f161b8d9410ff150 would've fixed it.
Any ideas?

Mkay I'm a bit baffled that BN_MASK2 isn't defined with ULL, but anyway f2cc5d5119508df5a33832375bf180062ce37dc7 fixes it.

It seems this still treats the power of two as public:

It leaks whether we took bn_mod_inverse_pow2 or bn_mod_inverse_pow2_word
bn_mod_inverse_pow2 calls BN_set_bit(t0, e) which touches a different word depending on e. Likewise with BN_mask_bits.
bn_mod_inverse_pow2 counts up to e

FWIW, I don't disagree with your assessment that leaking the power of two is probably fine. If the strategy is to leak e on grounds that it's probably benign, then leak e. I believe it's possible to avoid it (the link I gave above), but it does seem this particular algorithm is resisting attempts to avoid it.
(There may even be cases you want to leak e, if e is public and it's perf-sensitive. For BoringSSL, we have several different modular inversion functions, since different places have different secrecy and performance requirements, and different assumptions on the inputs. Some are tailored to a particular public EC prime. Some work for arbitrary public primes. Some assume a secret modulus, some don't. One specifically inverts mod 2^64. And so on. To go down that route, I think the first step is to take inventory of the places where you need to compute modular inversions.)

It seems this still treats the power of two as public

Not within the word :) That's what I meant by "It now leaks the position of the least significant non-zero word". I hope that's clear.

* It leaks whether we took `bn_mod_inverse_pow2` or `bn_mod_inverse_pow2_word`
* `bn_mod_inverse_pow2` calls `BN_set_bit(t0, e)` which touches a different word depending on `e`. Likewise with `BN_mask_bits`.

Yes -- and that's "up to word".

* `bn_mod_inverse_pow2` counts up to `e`

Indeed; for random inputs, that counting will happen with probability 2**-BN_BITS2.

Hello @bbbrumley nice work!
This PR is marked as post3.0.0 however, it seems to be simple to back-port to the 1.1.1 branch.
I would like to ask if I may add your PR to my openssl-111-features branch, see #11900

Hey Bernd,
Thanks for the interest!
Hmm yea in general, I don't see why not.
I still think I'm missing a little due diligence on this one. I didn't do any performance analysis at all.
Unrelated: much obliged for this patch of yours! Everyone on this thread is witnessing a tiny miracle: two (al)pine S/MIME users meeting in the wild.

Right so ... after mulling this one over for some time ... I've decided to close it.
I think @davidben is right.
At a high level, this PR

Removes some non-CT inversion code that leaks in certain known small ways that nobody knows how to exploit.
Replaces it with some non-CT inversion code that leaks in certain known small ways that nobody knows how to exploit.

No matter how much explaining away I try to do about how this PR leaks in better ways than the code it is replacing,

There's no guarantee that's true -- I am some random dude on the Interwebs.
There's certainly no guarantee that will hold moving forward, as more features / use cases get added to OpenSSL.

In summary, the code this PR attempted to replace was a crutch at the time, a very long time ago (2007ish?). I feel it is unwise to trade one crutch for another. At this point, do it properly, or don't do it at all.
Anyway, it was fun to implement :) I felt like a PhD student again, for a very brief moment. I'll go back to something incredibly boring like grant writing now.


json -> structs + speaker information

Codecov Report

Merging #7 (b86fc84) into master (0e5a09c) will decrease coverage by 7.42%.
The diff coverage is 82.50%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   93.85%   86.43%   -7.43%
==========================================
  Files           3        4       +1
  Lines         114      199      +85
==========================================
+ Hits          107      172      +65
- Misses          7       27      +20

Impacted Files
Coverage Δ

src/JuliaCon.jl
100.00% <ø> (ø)

src/schedule_structs.jl
72.97% <72.97%> (ø)

src/schedule.jl
94.69% <97.82%> (+0.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e5a09c...b86fc84. Read the comment docs.


Localize contributor cheatsheet in Indonesian

Contributor cheatsheet content in the below link:
https://github.com/kubernetes/community/tree/master/contributors/guide/contributor-cheatsheet
Translation result will needs to be put into the community repo as well.
/kind feature
/language id
/cc @kubernetes/sig-docs-id-owners

/assign
/assign @girikuncoro

@chenrui333 Is this also implemented in other localization as well?

Yeah, currently it seems only korean got translated:
https://github.com/kubernetes/community/tree/master/contributors/guide/contributor-cheatsheet

@chenrui333 got some error regarding service account hmm


Encryption / Decryption as default behaviour

React-native counterpart for https://github.com/blockstack/blockstack-ios/pull/79

👍 looks fine!


[eas cli] Surface Apple contract messages

Why
When Apple has contract messages, things tend to break in cryptic and unfortunate ways. Contract messages are hard to test against because they come at unexpected times. Often the issue is resolved when the user gives up and goes to app store connect manually, at which point they see the warning messages, resolve them, and get back to business.
This PR implements our new ITCAgreements module and surfaces the contractual warning messages to the user directly so they can quickly resolve any new Apple issues. This also helps users know that we're aware of contract changes and account for them gracefully.
How

Assert contract errors when the user creates an app, or when bundle ID queries fail due to security reasons.
The contract messages are returned in HTML format, we use a best-effort approach to convert them to ASCII.
If an unknown contract state is returned (and no contract messages are present), the program will attempt to create the app, and fail with whatever Apple returns.

Currently we account for paid, and free contracts being active or outdated, and expired accounts (can only see states based on my accounts).
This helps prevent false positives in case there's a non-fatal contract message that apple chooses to show.

Added an extra part to the app creation error informing the user to check ASC just in case we missed something (unlikely).

Test Plan

Testing is difficult because it depends on the state of a paid apple developer account. Right now if you have an account with an expired license you can run eas submit -p ios on a new app (new bundle id), it should fail with the following:

Before, the message was:
✖ Failed to create App Store app HackerWebby
    UnexpectedAppleResponse: An attribute value is invalid. - Apps of this type cannot be created.

If you have an expired Apple developer account (after 1 year you don't pay the membership or your card fails to process), running eas submit -p ios should show the following:

✖ Failed to register bundle identifier com.bacon.fastapp2

Contract messages from App Store Connect:

› Payment Returned
Your payment was returned by your bank. The reason your payment was returned is:

Your bank account number is formatted incorrectly.

You can review your banking information and make any necessary changes in Agreements, Tax, and Banking
(https://appstoreconnect.apple.com/agreements/#) for:
CHASE BANK - \*\*\*\*1234
Bank Payment Reference Number: 123456789

› Developer Program Membership Expired
Your membership has expired, and your apps have been removed from the App Store until you renew your membership. To renew, a user
with the Account Holder role must sign in (http://developer.apple.com/membercenter/index.action) and renew the
membership on the Apple Developer website. Learn More (https://developer.apple.com/support/renewal/).

    Error: App Store Connect has contract issues that must be resolved before apps can be created

Before, the message was:
✖ Failed to register bundle identifier com.bacon.fastapp2
    UnexpectedAppleResponse: This request is forbidden for security reasons - Team ID: '7T5636VC39' is not associated with an
    active membership. To check your teams membership status, sign in your account on the developer website.
    https://developer.apple.com/account/

@brentvatne I've added an error log to prevent false positives, if a code that we don't expect is found, then it'll prompt the user to report it as an issue, show the messages, and continue with the process regardless.


The [Bug Report] el-table v-loading state opens the el-dialog Z-index problem

Element UI version
1.4.2
OS/Browsers version
win7/chrome 59.0.3071.86
Vue version
2.4.2
Reproduction Link
https://jsfiddle.net/vynp2e2b/
Steps to reproduce
demo链接中点击打开Dialog按钮
What is Expected?
el-dialog 的弹出层应在el-loading-mask之上
What is actually happening?
el-loading-mask在el-dialog 的弹出层之上

这种情况需要自己覆盖下样式，https://jsfiddle.net/vynp2e2b/4/

Ran into the same issue today, any reason this z-index: 1000; is not the default?

@Korri Because there are scenarios where Loading needs to go above Dialog, e.g. when some operations in a Dialog triggers a Loading (maybe a fullscreen one).
It's difficult, if not impossible, for us to decide which one should be on top. So you may have to handle it yourself.


comparison with SOTA

Hi, great work!
However, I am little confused about your comparison against SOTA methods. For instance, wrt cityscapes, why don't you compare against STEGO? Is it because you are computing scores on cityscapes val set while STEGO on test set? If yes, would you then compare against this method: https://paperswithcode.com/sota/unsupervised-semantic-segmentation-on-1? Also, do you have results on cityscapes test set?
Thanks.

We submitted our HSG (CVPR 2022, November 2021) before STEGO was put on the arxiv (March 2022).
To compare with these methods on Cityscapes, you can use our code and released model to perform inference on the test set.


Configuring ollama build with redis results in an error

Configuring ollama build with redis results in an error.
   llama stack run ollama-stack --port 5000

   Resolved 8 providers in topological order
    Api.models: routing_table
    Api.inference: router
    Api.shields: routing_table
    Api.safety: router
    Api.memory_banks: routing_table
    Api.memory: router
    Api.agents: meta-reference
    Api.telemetry: meta-reference

  Initializing Ollama, checking connectivity to server...
  [faiss] Registering memory bank routing keys: ['vector']

  ...

  AttributeError: 'RedisKVStoreConfig' object has no attribute 'url'
  Error occurred in script at line: 42

  version: v1
  image_name: ollama-stack
  docker_image: null
  conda_env: ollama-stack
  apis_to_serve:
  - shields
  - safety
  - memory
  - memory_banks
  - inference
  - agents
  - models
  api_providers:
    inference:
      providers:
      - remote::ollama
    memory:
      providers:
      - meta-reference
    safety:
      providers:
      - meta-reference
    agents:
      provider_type: meta-reference
      config:
        persistence_store:
          namespace: llama-stack
          type: redis
          host: localhost
          port: 6379
    telemetry:
      provider_type: meta-reference
      config: {}
  routing_table:
    inference:
    - provider_type: remote::ollama
      config:
        host: localhost
        port: 11434
      routing_key: Llama3.1-8B-Instruct
    memory:
    - provider_type: meta-reference
      config: {}
      routing_key: vector
    safety:
    - provider_type: meta-reference
      config:
        llama_guard_shield: null
        enable_prompt_guard: false
      routing_key:
      - llama_guard
      - code_scanner_guard

Just had the same issue. It is not related to ollama. In general it's the issue if you choose Redis as a persistence store. I just submitted a PR to fix this. Locally it works, just not sure if this it he preferred approach of just build Redis client differently. Let's see what maintainers think.

Had the same issue couple of days before. Need to add self.config.url = http://{host}:{port} in llama_stack/providers/utils/kvstore/redis/redis.py under RedisKVStoreImpl.


add open graph image tag

this should fix the image tag issue.
We should really think about to use another theme for out blog.

I'll merge it - can be changed afterwards


Split trace implementation in two

One implementation is intended to be used on fetched repositories, and will always write DataFrames to disk
The other one is intended for inline code usage, and will return built DataFrames to the callee

Is only applicable to  @trace now, updating

Not necessary for our evaluation, moving to Future Work milestone


Support for createContext

The React 16.3 API now has a way to add “context”, the createContext function:

Context provides a way to pass data through the component tree without having to pass props down manually at every level.

Please implement this same behaviour and API in Preact.

There is a PR #963 to track this.

On 05-May-2018, Yao Ding wrote:

There is a PR #963 to track this.

Great, thank you.
So should we leave this issue open, until the feature is implemented
in a release?
--
\     “I must say that I find television very educational. The minute |
`\       somebody turns it on, I go to the library and read a book.” |
o_)                                                    —Groucho Marx |
Ben Finney<EMAIL_ADDRESS>

I don't see leave this issue open any good. The PR has all the implementation info(which you can review as well) and discussions, also Jason said currently Preact prefer context as a dedicated module. Also one wonderful contributor already published a module. Keeping this issue open would only cause distraction.


Actor Refactoring

Summary

Actor refactoring with John De Goes at SBTB
Changes to tests to accomodate refactoring
Added Config management using ciris for settings the default mailbox size

Notes

Will replace ciris with scalaz-config once its available. Issue created for this.

@mijicd Thanks for great feedback just pushed the changes you suggested:

Removed ciris dependency and just left a Default value for mailbox size that can be overriden by client
correction to gitattributes (good catch I was silly)

Thanks.


MySQL error adding homepage section

Bug Report
Expected behavior/code
On a page, adding a Section would put it on your page for editing.
Actual Behavior
A Server Error 500 occurred adding sessions. Logs showed the error was:
richie_1            | [pid: 7|app: 0|req: 33/280] <IP_ADDRESS> () {54 vars in 2232 bytes} [Thu Dec 16 17:45:52 2021] GET /en/static/css/ckeditor.css/ => generated 57335 bytes in 142 msecs (HTTP/1.0 404) 11 headers in 538 bytes (1 switches on core 0)
richie_1            | (1364, "Field 'attributes' doesn't have a default value")

Steps to Reproduce

Create a page (or use one that already exists)
Edit the page (?edit at end of URL)
Add a Section component
Fill in all fields and submit

Environment

Richie version: 2.9.1
Platform: tutor-richie

Possible Solution
This was resolved locally by updating the section_section table in MySQL:
mysql> alter table section_section modify column attributes longtext null;
Query OK, 0 rows affected (0.02 sec)
Records: 0  Duplicates: 0  Warnings: 0

mysql> desc section_section;
+------------------+--------------+------+-----+---------+-------+
| Field            | Type         | Null | Key | Default | Extra |
+------------------+--------------+------+-----+---------+-------+
| cmsplugin_ptr_id | int(11)      | NO   | PRI | NULL    |       |
| title            | varchar(255) | YES  |     | NULL    |       |
| template         | varchar(150) | NO   |     | NULL    |       |
| attributes       | longtext     | YES  |     | NULL    |       |
+------------------+--------------+------+-----+---------+-------+

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

@sion42x Wow this is not how it's done in Django :astonished: You're not supposed to tweak your database directly, unless you're not planning to use the migration framework. It's most probably a configuration issue in https://github.com/overhangio/tutor-richie.
But I will try to reproduce this problem in richie and propose a solution.

@sion42x Wow this is not how it's done in Django 😲 You're not supposed to tweak your database directly, unless you're not planning to use the migration framework. It's most probably a configuration issue in https://github.com/overhangio/tutor-richie. But I will try to reproduce this problem in richie and propose a solution.

Understood: please no one do what I did above. I do not know the proper procedure for doing things in Django.
If I can figure out how to use the migration framework to do it properly I will.

I believe that you nailed the issue @sampaccoud. The tutor-richie Dockerfile does run makemigrations and migrate, so when I upgraded to 2.9.1 it SHOULD have added the features. However, I had the same issue with course run migrations and thought something must have been missed. I had to bash into the Docker container (tutor local run richie bash) and run this to fix it:
openedx@51181737b595:~/richie/sandbox$ python ./manage.py makemigrations
Migrations for 'courses':
  /app/richie/src/richie/apps/courses/migrations/0033_auto_20211220_0153.py
    - Remove field enrollment_count from courserun
    - Alter field effort on course
Migrations for 'glimpse':
  /app/richie/src/richie/plugins/glimpse/migrations/0004_alter_glimpse_variant.py
    - Alter field variant on glimpse
Migrations for 'section':
  /app/richie/src/richie/plugins/section/migrations/0007_remove_section_attributes.py
    - Remove field attributes from section
openedx@51181737b595:~/richie/sandbox$ python ./manage.py migrate
System check identified some issues:

WARNINGS:
?: (dockerflow.health.W001) Unapplied migration courses.0033_auto_20211220_0153
?: (dockerflow.health.W001) Unapplied migration glimpse.0004_alter_glimpse_variant
?: (dockerflow.health.W001) Unapplied migration section.0007_remove_section_attributes
Operations to perform:
  Apply all migrations: admin, auth, cms, contenttypes, courses, djangocms_googlemap, djangocms_link, djangocms_picture, djangocms_text_ckeditor, djangocms_video, easy_thumbnails, filer, glimpse, html_sitemap, large_banner, lti_consumer, menus, nesteditem, plain_text, section, sessions, simple_text_ckeditor, sites, social_django
Running migrations:
  Applying courses.0033_auto_20211220_0153... OK
  Applying glimpse.0004_alter_glimpse_variant... OK
  Applying section.0007_remove_section_attributes... OK

I'm on holidays but can you open an issue to @regisb on tutor-richie? Running migrations in the Dockerfile is a bad idea imo. I don't even know how can the production db be connected when you're building the Docker image? 🤯  In Richie we handcraft migrations to ensure smooth migrations between minor versions and delay breaking changes for the next major release. This will be broken by the current installation in tutor-richie.
@regisb I would strongly recommand not running Richie in Tutor. The preferred way to run Richie is classic Django as demonstrated in https://github.com/openfun/richie-site-factory. The Tutor plugin should take care of the openedx side. Both applications can be connected by configuration.

I'm on holidays but can you open an issue to @regisb on tutor-richie? Running migrations in the Dockerfile is a bad idea imo. I don't even know how can the production db be connected when you're building the Docker image? 🤯 In Richie we handcraft migrations to ensure smooth migrations between minor versions and delay breaking changes for the next major release. This will be broken by the current installation in tutor-richie.
@regisb I would strongly recommand not running Richie in Tutor. The preferred way to run Richie is classic Django as demonstrated in https://github.com/openfun/richie-site-factory. The Tutor plugin should take care of the openedx side. Both applications can be connected by configuration.

Sure, I will submit an issue there. And I may be totally wrong on how it's being done in Docker, but I'm going based on what I saw last time I ran 'tutor local quickstart' to build richie in. Richie in this case is a plugin of Tutor, and is run in its own container alongside all of the OpenEDX, MFE, MySQL, ES, etc. containers.


[Edge browser] With URL.revokeObjectURL no message is received in the worker

V1.2.1 no longer working in Edge browser.
V1.2.0 works fine.

@cnsdato Thanks for the report.  I guess maybe Edge is loading the worker source asynchronously?  Not exactly sure.  Ways we could deal with this:

Since there's now an options param, the revokeObjectURL behavior could be controlled by an option.
Since bare: true lets you do the object URL creation and Worker construction yourself, we could just remove the revokeObjectURL stuff from here, recommending instead that, where needed, people can do it themselves more safely by waiting until they've heard back from their worker before revoking.
We could stick a releaseURL function onto the worker before returning it, so that people can decide when to release the url without having to use the bare: true version of the api.

@substack preferences?

Going with (IMO) the simplest approach, which is to just attach objectURL to the returned worker so that user code can decide if/when to revoke it.

@cnsdato Just pushed what I believe should be a fix for this and published as 1.3.0.  It would be great if you could confirm?

@anandthakker Thanks for fixing this, I will give it a try in the next few days and will give you response on this.

This was fixed.


fix CVE-2021-43565

The related issue: https://github.com/stolostron/backlog/issues/18876
Signed-off-by: Yang Le<EMAIL_ADDRESS>

/lgtm


Migrate greatest common denominator algorithm

Migrate greatest common denominator algorithm to header file (as described in #163).

[x] Read the contribution guidelines
[x] Added unit tests (or unit tests have already been added)
[x] Updated the Contents

I haven't heard/read about greatest common "denominator" before. "Divisor" is the commonly used term for a number that divides another number. So we should stick to it.
From Wikipedia, other common terms used for GCD are:

[...] greatest common factor (gcf), highest common factor (hcf), greatest common measure (gcm), or highest common divisor.

Works for me, and shorter too. Will update and commit right now.


MWPW-159028: MAS merch-card technical documenation

inline-price custom element.

As part of this PR some changes have been introduced to the api and existing MAS doc have been updated.
merch-card: https://mwpw-159028--milo--adobecom.hlx.page/libs/features/mas/docs/merch-card.html
inline-price: https://mwpw-159028--milo--adobecom.hlx.page/libs/features/mas/docs/inline-price.html
Resolves: MWPW-159028
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/ilyas/merch-card?martech=off
After: https://mwpw-159028--milo--yesil.hlx.page/drafts/ilyas/merch-card?martech=off

@yesil Regression covered , waiting for approvals

@npeltier  At your time , plz check why this is not getting picked up for merge thanks


Calendar title in Portuguese

Hi sir
Calendar don't have a good Portuguese translation, I can help you
If you want .
Good work
Regards
Estima

Hi please add a pull request with the translated strings. Thanks!


[5.2][SourceKit] Fast code completion within function bodies

Cherry-pick  #28727 into swift-5.2-branch originally reviewed by @benlangmuir
rdar://problem/20787086

@swift-ci Please test


phylocanvas SVG output broken on retina display

Not easy for me to test this without a retina  display, but I'll take a look

fixed in 44cadff but it's not perfect and sometimes there is weird (i.e. hard to reproduce) behaviour
On retina screens, after printing to SVG, the tree redraws in a different position. Sometimes this happens on non-retina screens as well.


Introduce virtctl display

Today we need to either use virtctl spice or virtctl vnc.
In order to make it more convenient - and intention focused - it would be nice to just expose virtctl display (eventually witha flag to enforce a certain connection method), which auto-detects what options are available (vnc/spice) and choose the best option.
Th emain reason is that a user must not worry about the correct lower-level protocol to conncet to a virtual machine display.

I am sceptical about this. It is something different to choose between spice, vnc, rdp, than choosing between  different shells in a container in the context of kubectl exec, compared to these protocols which need  client-side support to work properly. Further a lot of different flags may apply to different types.

There is a difference between vnc, spice and rdp.
vnc and spice are part of the backend. rdp is a guest supported one.
The system can decide whether the VM offers vnc or spice, thus the client also knows about it and can make the right decision, without requiring the user to make a decision.
I was thinking along the lines of:
virtctl display testvm
virtctl display --vnc testvm
virtctl display --spice testvm

Actually, for the last two there is no reason, as if the vm is configured with spice or vnc, then the other will not work.

Actually, for the last two there is no reason, as if the vm is configured with spice or vnc, then the other will not work.

Technically there is no reason to not have both at the same time: https://bugzilla.redhat.com/show_bug.cgi?id=975751.

There is a difference between vnc, spice and rdp.
vnc and spice are part of the backend. rdp is a guest supported one.

So why making it for the built-in ones intransparent which one will be used? Further there may be different override-flags appropriate for different types and I would want to keep it consistent for all access types that they are explicit:
virtctl vnc
virtctl spice
virtctl ssh
virtctl winrm
virtctl console
virtctl scp
virtctl rdp

Even if it's technical possible, I doubt that we want to permit to enable VNC and spice at the same time. (Further more the question is if both can be connected at the same time!)
In general we can pretty much take the decision off the user whenever we control something. This is true for all backend configurations.
We can not make the decision when it's a guest sided configuration.
With this in mind we can split your list:
Under our control:
vnc
spice
console

Not under our control:
ssh
winrm
scp
rdp

Thus for the latter we need to keep it explicit, as we have no sane way to decide whether the guest has that feature enabled or not.
Because it is a guest feature I'd actually tend to say that we might move it to a dedicated verb, i.e.
virtctl guest rdp
virtctl guest winrm
virtctl guest ssh
virtctl guest scp
virtctl guest http
virtctl guest https

I pretty much completely disagree but it is not important enough for me to spend more time on this.

I doubt that we want to permit to enable VNC and spice at the same time.

we can, and it's actually quite helpful as it gives you more freedom to choose appropriate client.

I would agree with separation of "out of band" protocols vnc/spice/serial from guest protocols rdp/ssh/etc.
But I indeed do not believe we can make some automated choice

I would agree with separation of "out of band" protocols vnc/spice/serial from guest protocols rdp/ssh/etc.

I still don't see why I would always want to write an extra guest verb when I want to e.g. use ssh.

I think it would be helpful to clearly separate out-of-band consoles which always work from guest cooperation protocols.
Not necessarily by additional verb. Maybe just a clarification in help string is enough.
Though if we'd ever add guest VNC (why not, it's the same as RDP) you would probably want to differentiate from qemu's VNC.

If we have native vnc and spice guest-vnc and guest-spice would probably be the least used options. Therefore I would simply give them explicit more clunky names (e.g. guest-vnc or guest-spice) and keep the commandline short for the more-popular ones.

we can, and it's actually quite helpful as it gives you more freedom to choose appropriate client.

Good point. I was more thinking about using them at the same time :)

I think it would be helpful to clearly separate out-of-band consoles which always work from guest cooperation protocols.
Not necessarily by additional verb. Maybe just a clarification in help string is enough.

Yes ... Maybe - and in addition good error messages.
Still, there are so many verbs that would pop up which are guest specific that it's also not valueable.
I wonder if we could have verbs for the most prominent ones (ssh, rdp) and hide the others behind a guest verb?

if we add too many verbs it will clutter "help" and autocompletion.
how about the following:
virctl vnc
virtctl spice
virtctl console
virtctl ssh
virtctl rdp
virtctl guest winrm
virtctl guest scp
virtctl guest http
virtctl guest https
virtctl guest vnc
virtctl guest spice
another option, would be to scope out the "guest xxx" options from this enhancement. maybe add them later if there is need?

I wonder if we could have verbs for the most prominent ones (ssh, rdp) and hide the others behind a guest verb?

We should clearly separate out-of-band from guest protocols. SSH and RDP are still in-guest protocols, no matter how prominent they could be, and we should not mix them up with those which are independent on guest

if we add too many verbs it will clutter "help" and autocompletion.

That should really be the least of our problems. Did you ever run kubectl --help? It has a lot and it is still very informative. We can follow the same patterns and it kubectl also supports autocomplete. I never found it confusing.

We should clearly separate out-of-band from guest protocols. SSH and RDP are still in-guest protocols, no matter how prominent they could be, and we should not mix them up with those which are independent on guest

We can have list them as separate types in the help page. E.g. like kubectl does:
[...]
Advanced Commands:
  apply          Apply a configuration to a resource by filename or stdin
  patch          Update field(s) of a resource using strategic merge patch
  replace        Replace a resource by filename or stdin
  update         Replace a resource by filename or stdin
  convert        Convert config files between different API versions

Settings Commands:
  label          Update the labels on a resource
  annotate       Update the annotations on a resource
  completion     Output shell completion code for the specified shell (bash or zsh)

[...]

I really can't understand the issue. Also kubectl has commands like proxy or port-forward on the same command level although they are for completely separate things. Also there port-forward depends on the pod content and it is still not behind kubectl pod port-forward or something.

IIUC it doesn't depend on the actual POD content - or does it? The fact that you forward a port is something you set up in infra and let app talk to a port. Whether there is any useful service running on that port inside the container is irrelevant. With guest rdp/ssh you presume that it's running and ready. That's why I wouldn't mix it up with things which do not depend on whether anything is running in guest or not.
As I said before, separating them in documentation is fine

ok. trying to converge on the requirements. will add the following CLI verbs:
MUST:
virtctl vnc
virtctl spice
virtctl console
virtctl ssh
virtctl rdp

SHOULD (may split to a different issue):
virtctl winrm
virtctl scp
virtctl http
virtctl https
virtctl guest-vnc
virtctl guest-spice

these will be spread under two different documentation sections:

host supported: vnc, spice, console
requires guest support: ssh, rdp, winrm, scp, http, https, guest-vnc, guest-spice

virtctl http
virtctl https

What are these for? I would prefer having a port-forward command instead if that is for forwarding ports.

not sure about priority, but this (or subset of it) is probably still needed.


For each build variant, add regexp to filtering files for build-on-save.

Each build-variant can attach a
regexp to filtering files that should trigger build when those files
are modified and saved.

I'm not sure how this would work. Only .atom-build.json allows for any use specification. All the other build tools work as is.
What is this in regard to? Is it .coffee files you want to "build" to .js files?
This issue seems very close to what is asked in #50.

Closing due to no response. Also likely dupe of #50


new template marketing channels

I don't know which icon to use in repository since the whole purpose of this template is to use at least one marketing channels and it can be one of:
Change is planned and it will be possible to define more icons at the template level, the UI will draw an arrow between them.
It will probably be part of the next sprint.


Add more example

Hi,sometimes I'am confused by the docs because there some code w/o example.Can you add more example in the docs please?

Thanks for your issue, we are sorry to hear you are having trouble. Unfortunately, we are unable to provide general support via this feedback channel that isn’t related to specific documentation issues.


 I hate to those times.
I'll loose a life or two to roll back and not be frustrated by this ;)

You could use this feature as a "joker", like making it available once every game. Besides "big finger" misclicks, it could be a real value thorough the game :)

I still hope for this feature to come, not as a joker. In fact, a game session is so long that sometimes, I pause and come back to finish. I often loose the context and my first few move are quite poor. The ability to get back can help find a better solution. I'm still 100% confident it would help the players :)

Would you see this as a new action in the pause screen?

No, I would offer this on the main screen... but I'm not sure where. A new challenge for the responsiveness :+1:

There are already a few things I'm not happy with in some screen ratios, do you want me to have a seizure? :-p


Adds addAttributesToSVGElement to default plugins list.

Allows use of the addAttributesToSVGElement by adding to defaults plugins list.

Addresses #583

Coverage remained the same at 89.005% when pulling 1e7306f570aaadafd9e7433fb0cb27a4535e9670 on gjjones:allows-use-of-addAttributes-plugin into 975a9ff223b562a440ccd919715092275024c950 on svg:master.


Training file setup issues

Hi, I'd like to start by asking some questions about the training file settings.
First, I would like to ask if there is a problem with the number of iterations inside the scheduler settings, which is 1600K instead of 160K.
Also, I found that you use MultiStepLR in the loss function setting instead of CosineAnnealingRestartLR as the paper says, which setting should I use better?
Looking forward to your reply!!!

It is a mistake and should be 160k. In terms of schedule, both CosineAnnealingRestartLR and MultiStepLR would work. In our setting, we adopt the former while the latter is widely used in some other frameworks like HAT. We will correct the iter number and thanks for your comment.

ok, thanks for your reply!


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in host
ERROR: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:1: missing_python_build_tool: Python packages require a python build tool such as setuptools.
ERROR: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:37: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:37: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:37: missing_dev_url: The recipe is missing a dev_url
WARNING: /tmp/abs_37imx5fr1w/clone/recipe/meta.yaml:37: missing_description: The recipe is missing a description
Errors were found