Error  java.net.ProtocolException: expected 6682 bytes but received 7154

Hi to all,
when in my java application I try to send a file to PHP server, in logcat I see:
12-06 16:09:41.050 * W/System.err: java.net.ProtocolException: expected 6682 bytes but received 7154 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http1.Http1Codec$FixedLengthSink.write(Http1Codec.java:284) 12-06 16:09:41.070 * W/System.err:     at okio.RealBufferedSink.close(RealBufferedSink.java:229) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.java:49) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:45) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:93) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:120) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) 12-06 16:09:41.070 * W/System.err:     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) 12-06 16:09:41.090 * W/System.err:     at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:179) 12-06 16:09:41.090 * W/System.err:     at okhttp3.RealCall.execute(RealCall.java:63)
But file Is successfully sended to server.
Another problem is that multiple errors cause app to crash. How can I solve this issue?

You’re specifying the wrong content-length in your request body. If you continue to have problems please provide an executable test case that demonstrates the problem.

I record audio and encode it to mp3 using lame in another thread,when reach 60s,I send the file automatically,sometimes I get this error

How can I know if the file is written completely?

Hello, I'm encountering the same error when uploading video.
java.net.ProtocolException: expected 660 bytes but received 2048.
here is my code:
`public static void uploadVideo(Context context, File file) {
    ServiceGenerator serviceGenerator = new ServiceGenerator(context, Constants.SERVER_URL, HttpLoggingInterceptor.Level.BODY);
    CommandAPI commandAPI = serviceGenerator.createService(CommandAPI.class);

    User user = User.getUserFromSharedPreferences(context);

    RequestBody videoBody = RequestBody.create(MediaType.parse("video/*"), file);
    MultipartBody.Part archiveFile = MultipartBody.Part.createFormData("video", file.getName(), videoBody);

    RequestBody accesscode = serviceGenerator.createPartFromString(user.getAccessCode());
    RequestBody accel = serviceGenerator.createPartFromString("");
    RequestBody alert_battery_level = serviceGenerator.createPartFromString("");
    RequestBody alert_gps_files = serviceGenerator.createPartFromString("");
    RequestBody alert_media_files = serviceGenerator.createPartFromString("");
    RequestBody alert_speed = serviceGenerator.createPartFromString("");
    RequestBody course = serviceGenerator.createPartFromString("");
    RequestBody direction = serviceGenerator.createPartFromString("");
    RequestBody elevation = serviceGenerator.createPartFromString("");
    RequestBody event_id = serviceGenerator.createPartFromString("1");
    RequestBody lat = serviceGenerator.createPartFromString(String.valueOf(user.getLat()));
    RequestBody lng = serviceGenerator.createPartFromString(String.valueOf(user.getLon()));
    RequestBody level = serviceGenerator.createPartFromString("");
    RequestBody location_now = serviceGenerator.createPartFromString("");
    RequestBody online_status = serviceGenerator.createPartFromString("");

    HashMap<String, RequestBody> map = new HashMap<>();
    map.put("accesscode", accesscode);
    map.put("accel", accel);
    map.put("alert_battery_level", alert_battery_level);
    map.put("alert_gps_files", alert_gps_files);
    map.put("alert_media_files", alert_media_files);
    map.put("alert_speed", alert_speed);
    map.put("course", course);
    map.put("direction", direction);
    map.put("elevation", elevation);
    map.put("event_id", event_id);
    map.put("lat", lat);
    map.put("lng", lng);
    map.put("level", level);
    map.put("location_now", location_now);
    map.put("online_status", online_status);

    Call<ResponseBody> call = commandAPI.uploadVideo(archiveFile, map);

    try {
        Response<ResponseBody> response = call.execute();
        ResponseBody responseBody = response.body();

        Log.d("MIKE", "responseBody: " + new Gson().toJson(responseBody));

    } catch (Exception e) {
        e.printStackTrace();
    }

}`

@Multipart     @POST("upload/video")     Call<ResponseBody> uploadVideo(             @Part MultipartBody.Part video,             @PartMap() Map<String, RequestBody> partMap     );
whats wrong with my code? please help.

@MichaelReyes i got the same error； check  the video file is modified by other thread when uploading

it did not happen again after move the file to External Storage from Application Cache.

Occurring when uploading an image captured from the camera

same here when uploading file which is an image just captured from the camera and saved to context.getExternalFilesDir(Environment.DIRECTORY_DOWNLOADS

and this is the answer why (my fault):
https://stackoverflow.com/a/45033270

After studying for a while the problem I've realized that the content of the file was always changing (as it is the output of a sensor).

It means that the file that is checked for the HEAD and the file for the BODY may not contain the same data (therefore different length), which caused the mismatch.
I solved this creating a copy of the file and sending it (the copy) instead of the original file.

没有人告诉我有啥解决方案嘛？


[Bug] FATAL Rendering entity in world

Minecraft Version: 1.16.5
OptiFine Version: G8
Forge Version: 36.2.8
CraftTweaker: <IP_ADDRESS>5
Mod Version: lootbeams-1.16.5-release-sept0621.jar
I use crafttweaker to change the rarities / color of items and I think that could be the problem.
Config:
https://gist.github.com/zndrmn/9dc4332b3258f1d654a034d1fd9cc960
Logs:
Latest.log
https://gist.github.com/zndrmn/bb71b63eaedea510e9ee6d4cf1143aca
crafttweaker.log
https://gist.github.com/zndrmn/292ce7dcd3bdfa0cc918dd25a872517c
Crash Report:
https://gist.github.com/zndrmn/eb7d30eef45441e86cf9ce780010d533

yeah using non-vanilla rarities seems to cause real weird crashes with lootbeams. newest update renders the beam as white instead of fully crashing the game. ill try to find a fix when i get the time


question: how do we represent the transformation between a CloudEvent and a CDEvent?

The use case here is I want to map a CloudEvent with ce-type X to a CDEvent dev.cdevents.artifact.packaged.v1, would it be worth to have a utility to create a CDEvent from a CloudEvent, where the target CDevent embeds the CloudEvent as data?
Is this covered already?

We discussed a lot about how to support situations where only some producers / consumers natively understand CDEvents. There is no perfect solution, but at least we can allow embedding vendor data in CDEvents. I need to add this to the spec and SDK - see https://github.com/cdevents/spec/issues/60.  I will be working on this soon.
With that field available, what you'll be able to do it:

un-marshal your cloudevent from the wire into a CloudEvent object
render your CloudEvent object into json using CloudEvent structured mode
create a new CDEvent of the type you need
set the CDEvent data to the json blob from the original CloudEvent
render your new CDEvent as CloudEvent and forward it over the wire

The latest SDK supports custom data now!

@salaboy is this addressed by the SDK now, were you able to parse received CloudEvents into CDEvents structs?

@salaboy I hope this helps:
var cloudEventAsJson []byte
// render your cloudevent as JSON into cloudEventAsJson
event, _ := NewArtifactPackagedEvent()
event.SetCustomData("application/json", cloudEventAsJson)

Closing this for now, feel free to re-open if needed


'dynatrace_kubernetes' object appears to require 'scope' option, even when attempting to create a net-new cluster configuration

Describe the bug
Today, we use Dynatrace OSS to create new external-API integrated 'dynatrace_kubernetes' (i.e. the Connect Manually equivalent on the Dynatrace UI
Using the older Dynatrace provider, this can be done fairly easily, however with this setting it appears that the Dynatrace OSS provider requires providing the Kubernetes dynatrace entitiy ID
This is normally not an issue, but if you're creating a net-new K8s integration, this ID cannot be provided, and is created by dynatrace itself
To be specific, im referring to this setting: https://registry.terraform.io/providers/dynatrace-oss/dynatrace/latest/docs/resources/kubernetes#scope
Ideally; keeping the option as optional should solve this

Hi @Forcebyte,
Thanks for the feedback. It looks like at some point Settings 2.0 introduced an option to omit the scope on creation of an object if the schema supports scope generation. Tested and confirmed that scope can be set to optional and undefined with a successful result for dynatrace_kubernetes. The fix will be included in the next release.
Thanks!


fix: encoding batch with no columns

Which issue does this PR close?

Rationale for this change

When encoding a RecordBatch with no columns, the FlightDataEncoder will return an error:
Arrow(InvalidArgumentError("must either specify a row count or at least one column"))

This PR fixes this problem.
What changes are included in this PR?

Use RecordBatch::try_new_with_options to allow constructing a batch with no columns.
Are there any user-facing changes?

No

Thank you

Thank you!


[hmac,dv] Save & Restore DV cleanups

This PR builds on the changes from #23116. Only the final 4 commits are new, and will rebased once the first PR is merged in master.

Thanks a lot @hcallahan-lowrisc !


[Docs] Fix View Example Modals Link

the previous url gave a 404. This is a simple documentation update so none of the before submit check marks are relevant.
Before submitting the PR:

[ ] Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
[ ] Did you update and run tests before submission using npm run test?
[ ] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
[ ] Did you update documentation related to your new feature or changes?

What does your PR address?
It fixes a link that was incorrect.

@hahn-kev the effort is appreciated but please see our contribution guidelines on our documentation site:
https://www.skeleton.dev/docs/contributing/requirements
We do NOT accept PRs targeting master branch, as this would auto-deploy to production. Production releases happen once every two weeks. Changes should target the dev branch only. However this change has already been reported, fixed, and is queued for the next release.

Oh I see. I read the guidelines but they were all about contributing code and not updating existing documentation. Glad to hear the link will be fixed though!


[release-v0.5] Update golang.org/x/net to 0.17.0

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/approve

/lgtm


When I yank, the copied text has not been added to system clipboard

Looks like the plugin does not copy text to '+' register.
OS Ubuntu 18.04.3 LTS
Neovim

The plugin should yank to the + register if you have unnamedplus in your 'clipboard' setting, so something like this:
set clipboard=unnamedplus

If you want to yank to both + and * clipboards, you could even put this in your configuration instead:
set clipboard=unnamed,unnamedplus

However, this will make Vim paste from + by default, not from *. To make it possible to control this, I've just pushed a setting called g:yankwin_yank_clipboard that you can set instead of the the global clipboard. You should be able to find more info in the documentation.

However, if you do have unnamedplus in your 'clipboard' setting (or the new plugin setting) and the plugin is still not yanking to +, there must be a bug. Could you let me know if that's the case?

I've added set clipboard=unnamedplus and everything works now, thank you!)


add multi-thread renderer support

Multi-threaded command buffer recording

Internals are already threaded. Do you mean calling bgfx::submit (and other draw API functions https://bkaradzic.github.io/bgfx/bgfx.html#draw) from multiple threads?

Yes

Why do you need this?

will it improve performance under multi-core platform?

bgfx already has some sort of command objects. I think it would be useful to expose it. I could think of a scenario where one could do culling and animation on multiple threads while pushing commands to a thread local queue. When all threads are done, they will push the commands to bgfx render queue and one thread (the main one?) will call bgfx::frame().
It's already doable now but there would be a lot of duplicated work.

Thanks, I have found CommandBuffer in bgfx_p.h.

will it improve performance under multi-core platform?

Depends on your threading model. bgfx::submit calls are very light, they basically do filling structure that's getting used later on other thread to render it.


Adding fix for transformation issue and support for importing texture parameters from assimp for FBX

Please review the changes.

It's good to try to support fix texture wrapping in GVRf. However, please try to keep assimp header files unchanged if possible. I believe wrapping parameters are already supported by assimp. There is also a function GVRTexture.updateTextureParameters (or in native code, Texture::updateTextureParameters) to set wrapping. It would be very nice to get them to work. Thanks.


issue#346 Added clear_shell feature

#346

@charliesome - Any Idea how to fix the CI failure?
Thanks.

Any updates on this pls ?

@sagarbommidi You may want to rebase this on to master, since it looks like the travis-ci issue is resolved in it.

@yjukaku -  Done rebasing with master branch. -Thanks


Update repository path

[Current coverage][cc-pull] is 75.96%

Merging [#83][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #83   diff @@
==========================================
  Files             2          2
  Lines           129        129
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             98         98
  Misses           31         31
  Partials          0          0

Powered by Codecov. Last updated by [38d127b...8bdb7f2][cc-compare]
[cc-base-branch]: https://codecov.io/gh/stackcss/sheetify/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/stackcss/sheetify/compare/38d127b2fa09458f42e128d0227793b42db5605a...8bdb7f23795a592981aa98ad0c93772766d48e00?src=pr
[cc-pull]: https://codecov.io/gh/stackcss/sheetify/pull/83?src=pr

hey thanks @casr


Wrong browser product

Hey mate you are using product="chrome" but dockerfile installs firefox. Is chrome working better?
I am also getting protocol errors when trying to use headers. Maybe related to firefox?
2020-07-16T07:52:51.594Z DEBUG REQ-2 Adding custom headers: {
  "Referer": "https://google.com",
  "X-Requested-With": "XMLHttpRequest"
}
Error: Protocol error (Fetch.enable): Fetch.enable RemoteAgentError@chrome://remote/content/Error.jsm:25:5
UnknownMethodError@chrome://remote/content/Error.jsm:108:7
execute@chrome://remote/content/domains/DomainCache.jsm:96:13
receiveMessage@chrome://remote/content/sessions/ContentProcessSession.jsm:86:45
......
.....

Yeah, I had to switch to Chrome because puppeteer doesn’t support request interception with FireFox yet. I also noticed that Chrome loads a lot faster so I’m not sure why the original author switched to FireFox in the first place.
I’ll fix the Docker file when I get home, I forgot to update it when I switched to FireFox. Just update it manually for now.
Sent with GitHawk

ok cool, will try Chrome

Works fine on desktop OS but on some hoster I get this error:
2020-07-16T09:02:02.826335+00:00 app[web.1]: Error: Failed to launch the browser process!
2020-07-16T09:02:02.826345+00:00 app[web.1]: [0716/090202.318900:FATAL:zygote_host_impl_linux.cc(116)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux/suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.

changing launch options to contain --no-sandbox fixes it though:
LaunchOptions = {
    product: 'chrome',
    headless: true,
    args: ['--no-sandbox', '--disable-setuid-sandbox']
  }

Interesting... I'm not sure why that would work...
Anyways I fixed the Dockerfile.


Liveness Probe and Readiness Probe with Defaults

For issue #105 . @regadas can I get your review? This is my first time contributing with golang (usually coding with Java).

Thank you for supporting the project @regadas !


header/core: Put Blocks into the eds.Store in Listener

Context
Right now, the Listener stores the block data into ipfs.Blockservice during ExtendedHeader and EDS construction. As per #1099, we are now migrating to new storage for blocks - eds.Store and Listener should store the EDS/Block there.
This will likely require changes to the header.MakeExtendedHeader and likely simplify it by removing dependency on ipfs.Blockservice

Completed as part of ShrEx implementation


Feature suggestions

First off, thanks for this awesome tool 👍
I've started to enjoy working with Sourcery, and begun to explore some possibilities of how it could be used to enhance other libraries. I've come upon two features that would IMO help push the framework in this direction:
Inline Xcode error messages
Basically enable templates (swift templates at least) to raise errors which would be displayed as inline errors (warnings ?) in Xcode, in similar fashion as is done for example by SwiftLint. This would AFAICS require

Some mechanism of propagating these errors from templates to main process (custom throwable error, or method for "logging" this information ?)
Source code location (file/line) information for scanned identifiers. I'm not sure how/if this would be feasible.

Accessing external code from templates
Writing more complex logic directly in (Swift) templates is not ideal - if nothing else, than language options are quite limited due to the fact that the template code runs inside TemplateContext.generate method.
I would love to see an option, which would enable me to declare which source files I want to be compiled along with the template, or possibly even frameworks I want to be linked with the template executable.
Is this something that would be a viable addition to the library? If so, do you have any ideas / suggestions how might one go about implementing these?

Errors are also ready propagated into the main process, but depending on what templates (stencil, swift or ejs) you use they may be more or less helpful. For Stencil template there is a long standing pr to improve this https://github.com/stencilproject/Stencil/pull/167, but as you can see the project is pretty stale for quite some time already.
EJS probably are the best here because template engine takes care already of printing errors, but I still can imagine them being not very accurate, especially if they happen at runtime.
In swift templates propagating errors seems to be more complicated as they run as a separate process and it's harder to get concrete information about line of error, so it should be implemented inside swift template "engine", similar to EJS.
For source code location we store this information in a property, which can be actually accessed in a template as it is public, but it's not documented as it is used privately for some implementation. Problem with that might be extensions as they are merged together into type they extend, but we can still keep origins of their declarations (methods and properties). I don't see though how much useful this information can be for regular code generation tasks, unless you are trying to use Sourcery as a tool to facilitate some other task, like docs generation, which is out of scope of Sourcery.
Executing arbitrary code in swift templates can be achieved with #509 , but in my practice I never needed it, creating helper methods was enough.

Including external code is now possible with include tag supporting swift files. Regarding errors from swift template don't think we can improve them a lot right now without rethinking how they are compiled/executed.


Improve Document this code action to be suggested when a function is highlighted

Description:
$Title
Describe your problem(s)
When highlighted a function, we do not get Document this code action.
https://user-images.githubusercontent.com/46120162/177692017-e83f254f-ed44-4edb-86fb-175f5de235e9.mov
Describe your solution(s)
With the support of range based code actions by https://github.com/ballerina-platform/ballerina-lang/pull/36850 we can improve document this code action to get suggested when we highlight a function.

Closing this as a low-priority task with the Icebox label might reopen in the future.


SQ Error searching 3pax

flightplan search -w SQ -f MEL -t SIN -c business -s 2019-01-15 -e 2019-12-31 -q 3 -h
...
[SQ] DEPARTURE [MEL -> SIN] - 2019-06-02 (3 Passengers)
[SQ] ARRIVAL   [SIN -> MEL] - 2019-06-05
[SQ] error Unexpected error occurred while parsing!
Error: Invalid award mileageCost: 38666.666666666664
at new Award (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/Award.js:54:13)
at module.exports.parseAward (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:204:14)
at Node.rows.each (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:148:31)
at initialize.exports.each (/usr/local/share/.config/yarn/global/node_modules/cheerio/lib/api/traversing.js:300:24)
at module.exports.parseFlights (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:72:10)
at module.exports.parseResults (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:54:28)
at module.exports.parse (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:30:15)
at Results._parseAwards (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/Results.js:249:20)
at Results.get awards [as awards] (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/Results.js:221:12)
at main (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/bin/cli-search.js:382:28)
[SQ] DEPARTURE [MEL -> SIN] - 2019-06-03 (3 Passengers)
[SQ] ARRIVAL   [SIN -> MEL] - 2019-06-06
[SQ] error Unexpected error occurred while parsing!
Error: Invalid award mileageCost: 38666.666666666664
at new Award (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/Award.js:54:13)
at module.exports.parseAward (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:204:14)
at Node.rows.each (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:148:31)
at initialize.exports.each (/usr/local/share/.config/yarn/global/node_modules/cheerio/lib/api/traversing.js:300:24)
at module.exports.parseFlights (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:72:10)
at module.exports.parseResults (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:54:28)
at module.exports.parse (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/engines/sq/parser.js:30:15)
at Results._parseAwards (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/Results.js:249:20)
at Results.get awards [as awards] (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/src/Results.js:221:12)
at main (/usr/local/share/.config/yarn/global/node_modules/flightplan-tool/bin/cli-search.js:382:28)
[SQ] DEPARTURE [MEL -> SIN] - 2019-06-04 (3 Passengers)

Interesting... SQ parser is dividing the total mileage by passenger quantity (3 in this case) to get the "per passenger" mileage, but based on those numbers it seems the value it's being passed is already per-passenger. I'll remove the division operation.

Fixed in 0.3.48.


Confusing, unclear where to put the code

[Enter feedback here]
Confusing, unclear where to put the code.
For all the pages about loading related data it is not clear where the code should be placed in which program.
I seem to be puting it in the wrong places because of all the errors I get attempting to add to my site

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cc261727-1ecd-5dcb-fb88-1b1762263789
Version Independent ID: a15c2f82-ebb7-9867-50ad-35f80366528f
Content: Explicit Loading of Related Data - EF Core
Content Source: entity-framework/core/querying/related-data/explicit.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @roji
Microsoft Alias: avickers

@hcprobst can you be more specific, and possibly show a program of yours where you're putting the code in the wrong place? The code samples in that page can generally be used anywhere where one wants to execute a database query with EF Core.

Sorry, I think I have it now.
Thank you
Carey
Carey Probst  |  Application Developer
Information Technology Department
Lock Haven University
Smith Hall, B 2
401 North Fairview Street, Lock Haven, PA   17745
Phone:<PHONE_NUMBER> |<EMAIL_ADDRESS>|  www.lockhaven.eduhttp://www.lockhaven.edu/
From: Shay Rojansky @.>
Sent: Thursday, October 6, 2022 1:23 PM
To: dotnet/EntityFramework.Docs @.>
Cc: Probst, Carey (hcp244) @.>; Mention @.>
Subject: Re: [dotnet/EntityFramework.Docs] Confusing, unclear where to put the code (Issue #4073)
This email originated from outside of LHU.
@hcprobsthttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhcprobst&data=05|01|hcp244%40lockhaven.edu|b743fb9ef5d140b40ce808daa7bf6edf|db0889bee72146d48e6d106992633b33|0|0|638006737897290013|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=jLyXwRrCsC35CHf0HPiOiZgQUZ0qCH3oljOz6nAMuoM%3D&reserved=0 can you be more specific, and possibly show a program of yours where you're putting the code in the wrong place? The code samples in that page can generally be used anywhere where one wants to execute a database query with EF Core.

Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FEntityFramework.Docs%2Fissues%2F4073%23issuecomment-1270438049&data=05|01|hcp244%40lockhaven.edu|b743fb9ef5d140b40ce808daa7bf6edf|db0889bee72146d48e6d106992633b33|0|0|638006737897446249|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=HzNP2h2qFgDQUyxnuOU2x1ObvXR1mgRm1Kc0IcKIWh8%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA2AMMDGCQB35DUXQNCUMX7LWB4DHVANCNFSM6AAAAAAQ6ZN42Y&data=05|01|hcp244%40lockhaven.edu|b743fb9ef5d140b40ce808daa7bf6edf|db0889bee72146d48e6d106992633b33|0|0|638006737897446249|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=hh2sfymPQu6H8sYNrFAaWx2R7P1Ea%2BFNmLoYV4CM1U4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Add option to swap default Alt+scroll zooming behavior in 2D editor

Looks good! Could you squash the commits? See PR workflow for instructions.
For the record the CI error is not related to this issue, a new build attempt should hopefully solve it.

done

Thanks!


ccl: add MacOS version

ccl: add MacOS version to nixpkgs

changed derivation to be able to build for MacOS.
changed /bin/sh for ${stdenv.shell}

cc: @muflax @tohl @7c6f434c
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[X] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

In general, you might want to know that there is lib.optionalString, so it is also sometimes possible to have a common list of commands (for example, replacements) concatenated (via +) with optionalString-guarded platform-specific commands.

Thanks. I'll nook at lib.optionalString closely.


haskellPackages: Add maintainer shlok

Thanks!

I've reverted this PR in a6bb2cc2d4024219afabf6a1deca5a769777298e. Maintainers need a corresponding entry in maintainers/maintainer-list.nix before they can take over maintainership of any package. Please re-create this PR which also adds such an entry.

@sternenseemann Ah, good catch!  Sorry for that.

@sternenseemann Thanks for the feedback. Here is the new PR: https://github.com/NixOS/nixpkgs/pull/229647


I believe I can write in logic when a plugin is unloaded to garbage collect the references before i stop tracking it.

Python does not support this behavior.
Shouldn't be a huge issue since the stack does not grow with each successful reload


Cut a new release

I'm going to do one last bit of testing for these updates tomorrow, and then I should release a new version!

Resolved in #403


fix(codegen): print quote correctly for directive

#7735  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Implement Segment replication Backpressure

Description
This PR is a re-cut of https://github.com/opensearch-project/OpenSearch/pull/6520 that includes implementing backpressure and removes the addition of these metrics to NodeStats API.  This is to make it easier to see in this PR how this will be used to implement pressure.  The metrics additions will be in a separate change.
This PR adds backpressure for index operations when Segment Replication is enabled.
This PR implements backpressure mechanisms for segment replication to prevent lagging
replicas from falling too far behind. Writes will be rejected under the following conditions:

More than half (default setting) of the replication group is 'stale'.  Defined by setting MAX_ALLOWED_STALE_SHARDS.
A replica is stale if it is behind more than MAX_INDEXING_CHECKPOINTS, default 4 AND its current replication lag is over
MAX_REPLICATION_TIME_SETTING, default 5 minutes.

This PR intentionally implements rejections only for index operations,
allowing other TransportWriteActions to succeed, TransportResyncReplicationAction and RetentionLeaseSyncAction.
Blocking these requests will fail recoveries as new nodes are added.
Issues Resolved
https://github.com/opensearch-project/OpenSearch/issues/4478
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

force pushed a rebase from main.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12431/
CommitID: f6c861a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Spotless check failure.


output: add generic wlr_output_export_dmabuf implementation

When wlr_output manages its own swap-chain, there's no need to
hook into the backend to grab DMA-BUFs. Instead, maintain a
wlr_output.front_buffer field with the latest committed buffer.

LGTM, thanks !


Promoting TokenBalance trait outside of test

We have implemented a trait for fetching the token balance of a specific account within the context of a test.
The trait definition is as follows:
impl<M: Middleware> TokenBalance<M> for MockERC20<M> {
    fn get_token_balance(&self, account: Address) -> ContractCall<M, U256> {
        self.balance_of(account)
    }
}

It is sensible to promote this trait implementation to live outside the test, making it a part of the backend codebase.

There is no more fetch balances in V1.


🌱 Adding Github Action to verify title

Description
Add Github Action to verify the title so that we can generate the release notes
Closes: https://github.com/operator-framework/audit/issues/133

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.894%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
18

Relevant Lines:
2014

💛  - Coveralls


[ServiceBus] az servicebus namespace: Add new commands private-endpoint-connection and private-link-resource commands to manage private endpoint connection and private link resources

Description

Added zone-redundant parameter to namespace create command
Added disable-local-auth parameter to namespace create and update command
Added new private-endpoint-connection and private-link-resource commands for namespace

Testing Guide

private-endpoint-connection Commands
Approve

az servicebus namespace private-endpoint-connection approve
example:
az servicebus namespace private-endpoint-connection approve -g myRg --namespace-name mynamespace --name myconnection

Delete

az servicebus namespace private-endpoint-connection delete
example:
az servicebus namespace private-endpoint-connection delete -g myRg --namespace-name mynamespace --name myconnection

Delete

az servicebus namespace private-endpoint-connection reject
example:
az servicebus namespace private-endpoint-connection reject -g myRg --namespace-name mynamespace --name myconnection

show

az servicebus namespace private-endpoint-connection show
example:
az servicebus namespace private-endpoint-connection show -g myRg --namespace-name mynamespace --name myconnection

private-link-resource Commands
show

az servicebus namespace private-link-resource show
example:
az servicebus namespace private-link-resource show --namespace-name mynamespace -g MyResourceGroup

History Notes

[ServiceBus] az servicebus namespace create/update: Add --disable-local-auth to enable or disable SAS authentication
[ServiceBus] az servicebus namespace private-endpoint-connection/private-link-resource: New command groups

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

ServiceBus

/azp run

Hi @wangzelin007 and @evelyn-ys  can you please review the PR and help in in understanding the failure of test in latest profile.

@yonzhan , can you add the May release build label to this PR ?

/azp run

/azp run

/azp run

@evelyn-ys , the pipelines point to a certain azure/cli/command_modules/network/tests/latest/test_network_commands.py::NetworkVirtualApplianceScenarioTest::test_network_virtual_appliance and asks us to push the recording although it doesn't use service bus in the test. Do you happen to know why this is the case? Thanks.

@necusjz Can you help with the network test failure?

/azp run

Hey @evelyn-ys, could we please merge this PR ? Thanks.


Image files with locale data break upload/site.

I'm kinda new to ImageKit so bear with me.
We have a site that allows images to uploaded and displayed on the site. We somehow gained a large following of people from Brazil. Many of the image files they upload contain accent characters in the file name. ImageKit seems to upload them fine but I don't see a way to filter these names out or have ImageKit automatically strip the accents and rename the file. When the rest of the site tries to use an image with an accent character, it breaks entirely, throwing errors about not being able to read the non utf8 characters.
I know this problem encompasses more than ImageKit, but wonder if I missed something about the upload process. Can ImageKit filter these names and rename them?

ImageSpecField (ImageSpec in the 1.X series) accepts a cache_to keyword argument that lets you name the file whatever you want. (ProcessedImageField uses upload_to—the same as Django's ImageField).  @bryanveloso is trying to figure out why the docs aren't building correctly on rtd, but in the mean time, the in-source documentation might be helpful.

Thank you very much, I'm thinking I'd just have to run the cache_to or upload_to through a filter to strip the accented characters out..or name every image something generic in sequence, that'd probably work.

Cool. I'm going to close this up then. If the error is actually being thrown by IK, though, that's another matter (it shouldn't be happening). If that's the case, please post the error/stack and we'll try to look into it more.

Ok thank you!


DNS resolving only works for the node coredns pod is on

Summary
Thank you for checking. I am deploying a 2-master cluster with metallb and dns already enabled. Following the documentation here: https://kserve.github.io/website/0.11/get_started/first_isvc/#5-perform-inference, I know I should be able to curl using host header across different nodes, but the request times out. Looking further I found

only the node with coredns sending curl request to a pod within the same node works. It sending to the other node will timeout, also the other node sending request to any pods will fail.

using kubectl exec -it and running nslookup I found only the node with coredns can resolve domain names.

What Should Happen Instead?
curl requests in both direction work, and pods in both nodes able to resolve domains.
Reproduction Steps

I followed this guide up to the "Kserve" step to set up cluster.
I check whether machine with coredns can curl pods on the other machine. the two nodes: one with ip ends in .137, the other .142:

On ..*.137: (transformer-a-model confirmed on the same machine, while transformer-controller on the other)
 minghao@savi-gpu-1:~$ export INGRESS_HOST=$(kubectl -n istio-system get service istio-ingressgateway -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
~$ export INGRESS_PORT=$(kubectl -n istio-system get service istio-ingressgateway -o jsonpath='{.spec.ports[?(@.name=="http2")].port}')
~$ SERVICE_HOSTNAME=$(kubectl get inferenceservice transformer-a-model -o jsonpath='{.status.url}' | cut -d "/" -f 3)
~$ echo $INGRESS_HOST
<IP_ADDRESS>
~$ echo $INGRESS_PORT
80
~$ echo $SERVICE_HOSTNAME
transformer-a-model.default.example.com
~$ curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Content-Type: application/json" "http://${INl:predict" -d @./iris-input.jsonodels/transformer-a-mode:predict" -d @./iris-input.json
Warning: Couldn't read data from file "./iris-input.json", this makes an empty
Warning: POST.
*   Trying <IP_ADDRESS>:80...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> POST /v1/models/transformer-a-model:predict HTTP/1.1
> Host: transformer-a-model.default.example.com
> User-Agent: curl/8.1.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 0
>
< HTTP/1.1 400 Bad Request
< content-length: 105
< content-type: application/json
< date: Sun, 18 Feb 2024 20:10:03 GMT
< server: istio-envoy
< x-envoy-upstream-service-time: 13
<
* Connection #0 to host <IP_ADDRESS> left intact
{"error":"Unrecognized request format: Input is a zero-length, empty document: line 1 column 1 (char 0)"}   <-- error means request reached

<---------- here the requst to other node times out ---------->
~$ export SERVICE_HOSTNAME=transformer-controller.default.example.com
~$ curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Content-Type: application/json" "http://${INGRESS_HOST}:${INGRESS_PORT}/v1/models/opt-controller:predict" -d @./iris-input.json
Warning: Couldn't read data from file "./iris-input.json", this makes an empty
Warning: POST.
*   Trying <IP_ADDRESS>:80...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 80 (#0)
> POST /v1/models/opt-controller:predict HTTP/1.1
> Host: transformer-controller.default.example.com
> User-Agent: curl/8.1.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 0
>
< HTTP/1.1 504 Gateway Timeout
< date: Sun, 18 Feb 2024 20:13:50 GMT
< content-length: 25
< content-type: text/plain; charset=utf-8
< x-envoy-upstream-service-time: 100011
< server: istio-envoy
<
* Connection #0 to host <IP_ADDRESS> left intact
activator request timeout

Introspection Report
information for namespace i'm using:
namespace.txt
inspection-report-20240218_151321.tar.gz

Some additional information:
My use case is with kserve inference graph, and my graph is composed of one pod in the same node as the coredns and one that's not. I looked into the logs for the inference graph pod, and the inference graph router requested the correct domain name for both of them:

solved, the problem was that our pods were deployed across two subnets (from checking logs of calico pod), plus (for a reason yet unknown) vxlan wasn't deployed successfully.
We then enabled BGP protocol instead of Vxlan for the cluster (session Configure Calico in BGP mode under https://microk8s.io/docs/change-cidr), and all issues resolved.


Crash

Geode Issue

[X] I confirm that this crash is NOT related to a mod but directly to Geode Loader itself.

Platform
Windows
Geode Version
v1.3.5
Mods Installed
Crystal Client
Steps to Reproduce
I did use a macro for deadlocked
Crash Report
Geode 15 Oct 11.59.12.log
Additional Information
No response

Crystal Client issue, please read the checkbox before checking it

Please read the checkbox you just checked that says "NOT related to a mod"


Fix issue #15: ImportError: cannot import name 'DocVersion'

2 changes to fix issue #15

Expose DocVersion api in the package level for backwards compatibility

Add sphinx.html_themes entry points, so sphinx can load extension themes from them.

The theme entry points were intentionally removed in 44e69e8db2b631997c0a4b5e62d65c0cd48b46d6. Adding pallets_sphinx_themes to extensions is required so that certain callbacks can be registered in time.
The version stuff is still internal, so I'm not concerned with backwards compat yet.


Fix token type for onAuth room method

Change token type to string instead of Client to match onAuth type from @colyseus/core

Thank you @avatus 💙


Update launcher icon to newly designed icon

Related to #6
Missing edits to /app/src/main/res/mipmap-*/ic_launcher.png
Want to do this or shall I merge and generate them myself?
Thanks for the icon. It looks sweet :)

The shadow could be cleaned up a bit. It falls off the circle on the right hand side.


Review permissions for proper tool functioning

We're giving the "apache" user pretty broad permissions (ownership of the whole tool) in our installation documentation, but more restricted permissions may also work, and be more appropriate from a best practices perspective.
Investigate by restricting permissions significantly and adjust documentation accordingly.

For the tool to work and log printing, apache user should have read and write permissions and for the binaries to work, it should have execute permissions. The most we can do is remove sudo permissions which it already doesn't. What else could be done?

At first glance, I think only the data_files/ directory really needs to be writable by the apache user since that's what is being modified, but we'll need to test that. A separate stduser (which we have in production) that is unrelated to the web server should probably own most of the files instead.
The vulnerability we want to protect against here is a security flaw in the web server itself (which the entire world has access to), so restricting how much damage the web server can do on the file system is a best practice.

Now that the web server user should not require write access to the file system to do data file updates, we should do a thorough re-evaluation of ownership in our installation documentation, and probably have a specific sdt user set up to own these files instead.


per_page -1 == show all results

Coverage remained the same at 93.396% when pulling e99e4b592c05d1d22757f4231dd3a1353c452eb2 on all_pages into c7ec3a61016be4069a5263ba216d21112d005bbf on master.

Coverage remained the same at 93.396% when pulling e99e4b592c05d1d22757f4231dd3a1353c452eb2 on all_pages into c7ec3a61016be4069a5263ba216d21112d005bbf on master.


feat: add transfer ownership feature to dao module

Closes: #XXX
Description

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added  relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

[ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
[ ] Reviewers assigned
[ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 60.93750% with 25 lines in your changes missing coverage. Please review.

Files
Patch %
Lines

app/app.go
58.33%
10 Missing :warning:

x/ucdao/keeper/keeper.go
47.05%
6 Missing and 3 partials :warning:

x/ucdao/keeper/msg_server.go
60.00%
4 Missing and 2 partials :warning:

:loudspeaker: Thoughts on this report? Let us know!


Question: How to programmatically assign a value to the TreeView's SelectedItem property?

I want to programmatically assign a value to the TreeView's SelectedItem property. I assumed that TreeView.SelectedItem = myObject would work, but it seems to crash. Here's a blank UWP project I just created, and it crashes when I assign a string. Am I doing something wrong?

Can you provide more of the repro? Is "hello world" an object in your ItemsSource?
Is your expectation that the call would silently do nothing since the item isn't present?

Looks like the discussion moved to #386.


How to import go-micro package with latest code in master branch?

Or else, if I want to develop on go-micro, how to deploy the environment. Just some hints would help

Solved. git clone go-micro repo the subdirectory of the project, and add replace go-micro.dev/v4 => ./go-micro to go.mod, then it works. please close the issue

Use Go Workspace in your local environment maybe the best solution.

Use Go Workspace in your local environment maybe the best solution.

thanks, I will try that

this issue can be closed, thanks


flir_camera_driver: 0.2.4-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository flir_camera_driver to 0.2.4-1:

upstream repository: https://github.com/ros-drivers/flir_camera_driver.git
release repository: https://github.com/ros-drivers-gbp/flir_camera_driver-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.2.3-1

flir_camera_description

No changes

flir_camera_driver

No changes

spinnaker_camera_driver
* Fixed typo in arm64 arch.
* Contributors: Tony Baltovski

Closing in favor of https://github.com/ros/rosdistro/pull/35778


[ENH] - Implement OTEL

Feature description
OTEL
Value and/or benefit
observing is good
Anything else?
No response

Closed in favor of #811.


Support ESLint 7.x

ESLint v7.0.0 is released 🎉
It would be awesome to have official ESLint 7 support. 👊
I'm happy to help where I can of course 🙂

Closed by 2df66e4


Update Meta “authors”

Automatically generated by Netlify CMS

👷 Deploy Preview for adorable-griffin-3834b6 processing.

Name
Link

🔨 Latest commit
ed1cba5bcf5ad9c04894b1dbee0867d056f91517

🔍 Latest deploy log
https://app.netlify.com/sites/adorable-griffin-3834b6/deploys/64612d34a4d91d00086df212


switch to pubilc release of bigqueue:0.7.0 so that we can run test in jenkins build

NetflixOSS » suro » suro-pull-requests #22 SUCCESS
This pull request looks good

suro-pull-requests #191 FAILURE
Looks like there's a problem with this pull request


[FEATURE REQUEST] Also visualize standard tf show output

(Love this project btw. I've been looking for something like this for a while...)
In addition to visualizing tf plan output, could you also just allow for the terraform show -json output as well? Visualize the resources in a tree just like it does now, but show current state instead of the plan.

@neil-wwt thanks for liking the project 👍
I gave that a thought before but found terraform graph has already provided the state graph. I'm wondering if it fits your needs or there are additional values to put it into Terraform Visual?

Hi @hieven. Yeah, graph is helpful in some cases but leaves at least two big things to be desired for me.

Not a very attractive visualization with zero interactivity. It just outputs the DOT file which you need another tool (like graphviz) to visualize, and even when you do it's static, not pretty and can be tough to navigate for projects of a certain size.

Not very informative. It just shows names and dependencies, but does not make it any easier to view the code or attributes of a given resource.

terraform graph is great for basic dependency mapping, but does not do much for resource exploration and visualization of a large, complicated state file.

Hi @neil-wwt, thanks for the comments. Those comments totally make sense to me and I'd love to consider including visualizing TF state in the next step.
Before that, I've just made a CLI and published it to NPM, would you mind to give it a try and see how it feel like?
If everything works well, I might include this feature into the CLI too
https://www.npmjs.com/package/@terraform-visual/cli

Hi @hieven , great tool you've made. I would also be interested for the app to show the output of terraform show as well.

+1 on this! Amazing tool and would be really cool if we could also show the output of terraform show with it


Added Enumerable#each_slice

Thx! I did the same recently (I love this method) but it was postponed because it should return an enumerable, not an array, which crystal doesn't yet support —but would be incredible to.

Scratch that, you actually invoke a block.

Thanks!!
Some notes before we accept this:

In Ruby Enumerable#each_slice returns nil. I think creating the Array(Array(T)) is unnecessary and will slow down things, so I would return nil too.
Instead of cloning the slice, I would create a new slice each time a new one is needed. Otherwise you end up creating an extra unnecessary copy of the array.
I just documented the difference between dup and clone. We won't be using neither of these here because of point 2, but dup would have been more appropriate, otherwise you end up creating deep copies of the enumerable's values.

Sorry for the delay, just now I see you made those changes. Thanks!

I added this here. Sorry, automatic merge wasn't possible and I'm not very good with git :cry: (I tried but it became a mess so I reset it)


Present license notices from command line

/kind feature

Which functionality do you think we should add?
The odo cli should have a command to dump all copyright notices associated with the open-source software built into the binary.
Why is this needed?
odo is commonly distributed in binary form without any of the license notices required by the open-source code used to build odo.  See, for instance, https://mirror.openshift.com/pub/openshift-v4/clients/odo/latest/ .   The single binary distribution is convenient, but there's also a requirement to distribute copyright license notices with the software.   My suggestion is to collect those licenses at build-time and provide a new odo command to show them.  To be clear, odo is just of many cli tools in the k8s ecosystem for which this should be done (oc, helm, etc).   The alternative is to change how these tools are distributed so they also include copyright notices bundled in an archive.

/area release-eng

/lifecycle frozen

@atgreen How should output look like? I guess that just listing license names won't make sense.
Maybe something like:
$odo license

* odo is licensed under Apache License 2.0
   Apache License
                           Version 2.0, January 2004
                        http://www.apache.org/licenses/

   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

   1. Definitions
...
...
...

* 3rd. party libraries licensed under Apache License 2.0:
- github.com/openshift/api
- github.com/spf13/cobra
- .....
    Apache License
                           Version 2.0, January 2004
                        http://www.apache.org/licenses/

   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

   1. Definitions
...
...

* 3rd. party libraries licensed under MIT license:
- github.com/onsi/ginkgo
- github.com/onsi/gomege
- ...

Copyright (c) 2013-2014 .....

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
...
...

Or it would be safer to list full licenses for every library?
Is it ok to just the list libraries that we use directly or should we also include nested dependencies? It might become a huge list if we do that.


c3c: add version check

Description of changes
Adds a simple testers.testVersion test to ensure this package's binaries function, hopefully enabling for quicker updates and better quality assurance for this package.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build c3c

Latest push fixes the merge conflicts, as well as migrating the package to the finalAttrs pattern.


Convert all tables in monitor to DataTables

This ticket serves to track the progress of converting the tables in the monitor to DataTables. The table below will be edited as progress is made.

Table id
is a DataTable

tableList
:heavy_check_mark:

bulkListTable
:heavy_check_mark:

bulkPerServerTable
:heavy_check_mark:

compactionsList
:heavy_check_mark:

compactorsTable
:heavy_check_mark:

runningTable
:heavy_check_mark:

gcActivity
:heavy_check_mark:

trace
:heavy_multiplication_x:

logTable
:heavy_check_mark:

managerStatus
:heavy_check_mark:

recoveryList
:heavy_check_mark:

problemSummary
:heavy_check_mark:

problemDetails
:heavy_check_mark:

replicationStats
:heavy_check_mark:

scansList
:heavy_check_mark:

tServerDetail
:heavy_check_mark:

opHistoryDetails
:heavy_check_mark:

currentTabletOps
:heavy_check_mark:

perTabletResults
:heavy_check_mark:

traceSummary
:heavy_multiplication_x:

participatingTServers
:heavy_check_mark:

badtservers
:heavy_check_mark:

deadtservers
:heavy_check_mark:

tservers
:heavy_check_mark:

Originally posted by @DomGarguilo in https://github.com/apache/accumulo/issues/2286#issuecomment-1119970204

There was discussion regarding the trace tables issue (mentioned above) and it seems like its best to just remove them and their supporting code from the project. I'll go ahead and work on a PR for that now.


run e2e after new image is pushed to staging

Description
E2E tests were running before the new image was pushed to staging. Therefore, we weren't actually testing against the new code. This fixes that.
It also makes sure that we're running the tests and executing commands in the order we save by making use of selenium's async/await functionality.
Reviewer Notes
Should e2e be moved before cache is saved?
Review the following for description of async/await in selenium webdriver: https://github.com/SeleniumHQ/selenium/wiki/WebDriverJs#moving-to-asyncawait
Verification Steps

[ ] The CI tests pass.
[ ] On Sauce, expect to see passing tests in order they were given.

References

Pivotal story

"Should e2e be moved before cache is saved?" - I am not sure. Probably? Does @brainsik have an opinion?

Rebecca and I will be chatting about this a little later today. There's some changes that need to happen, but I want to walk through things instead of just dropping some comments about what to do.


Messages collection

Log each incoming request, and how Gambit responds.

_id
client -- 'mobilecommons'
client_message_id -- Mobile Commons message_id
client_sender_id-- Mobile Commons profile_id
client_broadcast_id -- Mobile Commons broadcast_id, set when User is responding to a broadcast message
phone
incoming_message
incoming_image_url -- Media url?
response_message_type
response_message
user -- DS Northstar User ID
current_campaign -- DS Campaign ID we save to User upon sending response

This issue came out of our data sync on last Friday. I'd imagine we could get this data by querying the Mobile Commons API -- but it could make sense to store our own messages collection to track incoming messages and how Gambit responds, especially if we ever add FB Messenger support to Gambit.
Not sure if this is necessary to implement, but wanted to create the issue to document #quasar concerns in our sync from Friday. My $0.02 would be to create a collections to store all sent CampaignBot messages and replies, vs storing a timestamp property on the User.

@sheyd -- This collection will start populating upon our deploy of a new 3.2.0 release today. It's going to be super helpful for Gambit messaging analytics -- but also super important to not run expensive queries on production, esp with #704 still open and unknown.
Any way we can start feeding data from the Gambit DB into our DS data warehouse? This bot_requests collection will provide answers for how many Signups result from a Mobile Commons Signup Broadcast.

@aaronschachter This would have to be out of band work for this sprint. I'd have to setup a new pipeline from Gambit into our DS warehouse, which we're in the process of migrating into a new environment this sprint. I think the priority should be to get this in on our next sprint.

Sounds good @sheyd. It does bring to mind the ol' extra information on the Signups table conversation we had a tech team meeting about a while back. The incoming Mobile Commons broadcast_id would be nice to store on the Signup as well.


Add a permanent focus border to the focussed window

As mentioned in #226 it would be helpful to have an option to see all the time which window is currently in focus. A permanent border with a configurable width and color would be nice for this.
The FocusIndicator which is currently used to indicate the focus of a window is controlled by a timer only and not suitable for this.

@josteink I believe this issue can now be closed 😅

Indeed!


pianobar: 2019.02.14 -> 2020.04.05

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pianobar/versions.
meta.description for pianobar is: "A console front-end for Pandora.com"
meta.homepage for pianobar is: "https://6xq.net/pianobar/"
Updates performed:

Version update

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2020.04.05 with grep in /nix/store/c6vjhblzhrbkbbgnylm31w864x7hhg0z-pianobar-2020.04.05

directory tree listing: https://gist.github.com/cbda8ff030fa557fbc8cab290212e857

du listing: https://gist.github.com/c4cdcc3220b04ad9bb107c413f7a3fd9

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
pianobar

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c6vjhblzhrbkbbgnylm31w864x7hhg0z-pianobar-2020.04.05 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pianobar https://github.com/r-ryantm/nixpkgs/archive/4da86981e67d04cf80d8997ebe522d3ea2a9e879.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c6vjhblzhrbkbbgnylm31w864x7hhg0z-pianobar-2020.04.05
ls -la /nix/store/c6vjhblzhrbkbbgnylm31w864x7hhg0z-pianobar-2020.04.05/bin

This built, but couldn't be well tested as I didn't log in.


The example website is searching indefinitely and I cannot get a good grasp of the example

Challenge Build a Nightlife Coordination App has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

I get:
{
    "statusCode":403,
    "data":"{\"error\": {\"text\": \"The OAuth credentials are invalid\",
    \"id\":"INVALID_OAUTH_CREDENTIALS\"}}"
}


Nuget errors

Getting the below errors when I try to build the solution. I have the most recent NuGet client installed, it seems the problem is the commited binary in .nuget. I also can't find where command (last error line) is executed, some build script? Is there a reason
why the NuGet client is in the repository? Isn't it better to rely on the users locally installed one?
Edit: I should add that I can fix the errors by right clicking the CommandLine.Tests project then Manage NuGet Packages... and then clicking Restore. I only get the errors if I Build solution right after opening a fresh clone.
Error	23	The schema version of 'xunit' is incompatible with version 2.2.40207.9053 of NuGet. Please upgrade NuGet to the latest version from http://go.microsoft.com/fwlink/?LinkId=213942.	CommandLine.Tests
Error	24	The schema version of 'xunit.abstractions' is incompatible with version 2.2.40207.9053 of NuGet. Please upgrade NuGet to the latest version from http://go.microsoft.com/fwlink/?LinkId=213942.	CommandLine.Tests
Error	25	The schema version of 'xunit.assert' is incompatible with version 2.2.40207.9053 of NuGet. Please upgrade NuGet to the latest version from http://go.microsoft.com/fwlink/?LinkId=213942.	CommandLine.Tests
Error	26	The schema version of 'xunit.core' is incompatible with version 2.2.40207.9053 of NuGet. Please upgrade NuGet to the latest version from http://go.microsoft.com/fwlink/?LinkId=213942.	CommandLine.Tests
Error	27	The schema version of 'xunit.extensibility.core' is incompatible with version 2.2.40207.9053 of NuGet. Please upgrade NuGet to the latest version from http://go.microsoft.com/fwlink/?LinkId=213942.	CommandLine.Tests
Error	28	The schema version of 'xunit.extensions' is incompatible with version 2.2.40207.9053 of NuGet. Please upgrade NuGet to the latest version from http://go.microsoft.com/fwlink/?LinkId=213942.	CommandLine.Tests
Error	29	The command ""D:\dev\commandline\.nuget\NuGet.exe" install "D:\dev\commandline\src\CommandLine.Tests\packages.config" -source ""  -RequireConsent -o "D:\dev\commandline\packages"" exited with code 1.	CommandLine.Tests```

Hi @mizipzor,
yes you're right adding .nuget to source control was an oversight and was removed with last commit.
I think that this should solve also your build problems. If you fetch the very last sources, I've recently fixed build.fsx (it had problems with test task).
Unfortunately we can't run unit tests on Mono because xUnit console runners (recently upgraded to right version), currently work only on Windows. There's an (already open) issue on their GitHub repo, where I've posted my terminal output.
Please let me know, if this solved.

Exactly what I was looking for, thank you.

@mizipzor, you're welcome!
More things we fix, more rapidly I can promote pre-release to alpha.


Ensure Headers::setHeader preserves original case

Coverage increased (+0.02%) to 96.211% when pulling d15f86416e394cea16ce606516f8bbabc0b71231 on l0gicgate:SetHeadersPreserveCase into 61594b081c4cdc519d2a39ba36f0ab13f9ef8cd4 on slimphp:master.


Prepend base_path to links in Navigation()

See #280

Nice. 👍

Also caught two bugs:

the Macro would previously match any part that started with the designated root path, so if you wanted to list all pages under Gondor, all pages under Gondorlongerpath would also match.
the Macro was substituting out all the dots in the displayed filenames, because it was removing all instances of toc_root_path in the filename -- so when toc_root_path is '.' it was subbing out the dots.

Also added tests for this macro.


Fix TranslationProblem and xy being set when alpha is 1 then improve tests

I did thes things in this PR:

Fix and test https://github.com/theislab/moscot/issues/687
Add another error case for https://github.com/theislab/moscot/issues/680 i.e. throw error when xy is given and alpha is 1
Test that these fail when they have to

merge after #686

@giovp can you have a look? after this I will switch to sparse geodesic


ConvertibleToInputStream returns Future

As we prefer this over a Try.

Closes https://github.com/wellcometrust/storage-service/pull/71

Closes https://github.com/wellcometrust/storage-service/pull/71


SPM doesn't work with Xcode 11

Glad to see there is now SPM support!
... except it doesn't seem to work with Xcode 11's UI. I actually don't know what the problem is, whether it's with Xcode or with the library, and I've asked on SO as well with no answers. So I'm opening an issue here in case anyone has an idea.
Does anyone else have the issue or it's just me?

Started to work today...


Fix/package exports

Fixes #770.

Looks good. Can you please add a line in the CHANGELOG @prichodko ?

Will test and merge.

I have published this PR on<EMAIL_ADDRESS>so it can be tested.

It seems it impacts node application, I need to do more investigation first.

new version with the default fix published at<EMAIL_ADDRESS>

Same error encountered...

I am aiming for the next js-waku version to be ESM only so I won't spend more time on this PR and instead focus on ESM migration which should fix this.

To move forward on this I'd like to confirm js-waku would still work with NodeJS. I used the waku-tests repo as one example but a simpler example is fine too.

@prichodko @felicio please try<EMAIL_ADDRESS>See https://github.com/status-im/js-waku/pull/786#issuecomment-1157324872

superseded by #803


error callback of google map in not defined in withGoogleMap

Google Map is not accessible in China, we got google is not defined every time try to load the map. So, whether can provide an error callback when this happen to enable us to catch this error? Otherwise the app always crashed.

@Symous
The repo of this project is unmaintained more than a year, and we had build new version https://www.npmjs.com/package/@react-google-maps/api
We had rewrite it to TypeScript, and updating it frequently: https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api
You can enjoy autocomplete.
You can see our docs: https://react-google-maps-api-docs.netlify.com/
Also a lot of examples: https://react-google-maps-api-gatsby-demo.netlify.com/ https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api-gatsby-example/src/examples
The bundle size is much smaller: https://bundlephobia.com/result?p=<EMAIL_ADDRESS>Our Spectrum community: https://spectrum.chat/react-google-maps
Enjoy!


tf.math.sign() gives inconsistent output for the same input values for small complex numbers

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS Catalina 10.15.7
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: X
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.5.0-rc3-213-ga4dfb8d1a71 2.5.0
Python version: 3.6.12
Bazel version (if compiling from source): X
GCC/Compiler version (if compiling from source): X
CUDA/cuDNN version: X
GPU model and memory: X

Describe the current behavior
The function tf.math.sign() gives inconsistent results for tf.complex64 values with small magnitudes.  When passing tf.math.sign() two slices of the same Tensor, one of which wholly includes the elements of the other, the same numerical inputs result in different values.
Referencing the code example below:
tf.math.sign(z[23:26]) -> [1.+0.j, 1.+0.j, 1.+0.j]
tf.math.sign(z[23:27]) -> [nan+nanj, nan+nanj, nan+nanj, nan+nanj]
I've also demonstrated this behavior when using the docker image tensorflow/tensorflow:2.5.0
Describe the expected behavior
Referencing the code example below:
tf.math.sign(z[23:26]) -> [1.+0.j, 1.+0.j, 1.+0.j]
tf.math.sign(z[23:27]) -> [1.+0.j, 1.+0.j, 1.+0.j, 1.+0.j (or some other value)]

Do you want to contribute a PR? (yes/no): no

Standalone code to reproduce the issue
import tensorflow as tf
print(tf.__version__)
x = tf.constant([10 ** -n for n in range(47)], dtype=tf.float32)
z = tf.complex(x, 0.0)

q0 = tf.math.sign(z[23:26])  # result: [1.+0.j, 1.+0.j, 1.+0.j]
q1 = tf.math.sign(z[23:27])  # result: [nan+nanj, nan+nanj, nan+nanj, nan+nanj]

@pawlick2  I can able to replicate the issue in TF 2.5 version but in TF -Nightly 2.7 i am getting different output instead of nan. Please check it once.

Yes, looks like this doesn't happen when using 2.7 nightly.

@pawlick2 Seems the issue is resolved in TF nightly version. Please feel free to re-open the issue if needed . Thanks!


Move into argon2 away from rust-argon2

rust-argon2 got a new update which makes  it very slow, impacting performance and UserEx.
Refer: https://github.com/sru-systems/rust-argon2/issues/52

We still have to work on moving to other algorithm but we now use v1 of rust-argon2 to improve load times.


Photos: photo popup has different layout

It should be the same, more info here:
https://una.io/page/view-discussion?id=1090

These are images from different modules (Photos and Timeline module), this is the reason layout is different.


Generate MAC address for network interfaces and allow to specify MAC

It seems to me like the MAC address used for the virtual network interface changes when UTM is restarted. This causes guests to "forget" their previous network configuration, which is very annoying in the long term. I was able to reproduce this with Windows 10 and Ubuntu 20.04 guests, using multiple network adapters.
Current workaround is to disable networking in the Config, then add the needed network parameters as extra QEMU arguments, and include a MAC address there. The following arguments add a RTL8139 device with a fixed MAC address. The downside of the workaround is that the port forwarding UI is unavailable if networking is disabled.
-netdev user,id=net0
-device -device rtl8139,netdev=net0,mac=XX:XX:XX:XX:XX:XX

It would be great if a fixed MAC address could be auto-generated and if it could be changed from the Network configuration.

I don't see a reason for changing the MAC address for now (I hesitate to put too much options into the GUI which could be confusing). Can revisit if a need arises.


Fix logging & maintenance tasks

coming up

The fix for the macOS issue in on nixpkgs master: https://github.com/NixOS/nixpkgs/commit/c9f0c6f115f4369b5047c3c3086518294541d0bf

@uri-canva ah, nice, let’s see how we can integrate it into CI.

Merging this for now, since it would just bit-rot otherwise


[WIP] taylor log2/exp2/sin

sin and exp2 passing ops tests locally
need to cleanup sin code

resolving precision issues

Closing to work through more precision issues


🚀 [Illustration] - Clusck 2.0

Link of the Illustration
https://www.ls.graphics/illustrations/clusck-2-0-illustration-kit
Category of The Illustration
Paid
Formats Available
Format

Sketch
Adobe Illustrator
Adobe Xd
Figma
SVG
Affinity
PNG

Author
LS Graphics
Code of Conduct

[X] I follow Contributing Guidelines of this project.

Hi Anmol, can I start on with this Issue ?

Sure, go ahead. Every contribution is appreciated.

Hey Anmol can i know how you upload the screenshots of your illustrations inside your README ? I dont think copying screenshot works here

Read the guidelines here.

As stated, just drag the screenshot in your readme when you are editing and use the
https://user-images.githubusercontent.com/...  link for your contribution.
You can use this link in the src attribute as: <img src="the_link"

Hi Anmol, can you visit this branch and assess the changes

If  all's good then I will start by raising a PR

Raise PR, if any changes would be required. I will ask you for the same.
Don't worry, i will review the code.


Remove Pilot's sidecar

Use the TLS/GRPC port configured by pilot for ADS instead of envoy proxy.
Once v1 is out, remove the sidecar and old ports, since it'll no longer be used.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sbezverk
Assign the PR to them by writing /assign @sbezverk in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram No, I'm not sure.
Just examining what's affected and so far it indeed seems like tls grpc is the only issue.

So I am all in favor of removing this if we add mTLS to the gRPC port in pilot. The pilot agent has code to do mTLS to pilot. So could use same code

@ymesika
The issue at stake is putting mixer out of the loop for pilot telemetry. We have multiple telemetry backends (including GCP one) that depend on receiving data from mixer, and the pilot sidecar produces this data. Prometheus/grafana is only one option, and not necessarily the best one. Note that the tests in this repo may not even check for this any longer (lots of tests are still in semi-disabled state). Everything that the proxy does can be done in a library in pilot (duh), but we would need to align on the form of the telemetry, and how to consume it in mixer. You can start a document on direct API to mixer from pilot for this purpose, and probably how to integrate with citadel as well with a "library envoy".

/assign @douglas-reid

/hold

This seems like quite a large change. I'm sure that I've been out of the loop on the motivations, but are those documented somewhere (with discussion) ? The issue referenced appears to be just a reiteration of the PR description.
As @kyessenov relates, removing the proxy entirely drastically reduces any ability to monitor Pilot through existing Istio mechanisms. There obviously can be workarounds implemented, etc., but I'd like to have that thoroughly understood and committed to before jumping.

The description has been taken from a list of work items in a pilot dev planing that @rshriram has put together and shared in a dedicated Slack channel. To be honest I might have misinterpreted the text in this PR's description and opened this PR today merely to investigate the effect of the change on the tests until getting further details.
This indeed seems like a major change which I'm not entirely sure what are the benefits beside simplification and smaller cpu/mem footprint. This led me to the thought that I didn't understand what was the work item about.

@rshriram can we use an issue to track the work required here (with full discussion)? I was not part of the slack discussion -- and I imagine there are others like me that would like to be able to understand the whys, hows, and whens of these changes.

We are not using the sidecar today. There is no support for extracting streaming gRPC metrics from mixer filter in Envoy. So all you see is just rudimentary metrics, thats not helpful to debug/monitor pilot in any manner.
I do agree that we can stream metrics directly to mixer but thats purely additional work. Removing this proxy is not going to cause loss of pilot metrics as there are no metrics (for envoyv2) to start with. And we are already doing TLS in pilot. So, calling mixer over TLS should not be a big deal. There is no need to have any "citadel" library. Its just mTLS.
While there was some passing mention of extracting streaming gRPC metrics via Envoy, its not implemented nor do I see any PRs doing this. A far more useful option here would be to simply import the metrics proto and make calls to mixer to stream the metrics from Pilot. You will get a lot more richer metrics than what you have today.

@rshriram in what way does a sidecar in front of pilot prevent you from adding side-metrics to pilot?

It doesn’t. But what’s the point of adding another moving part to the mix when the task can be accomplished with just pilot server ?

We are trying to get rid of the pilot-agent, not  add more functionality to it. SDS is coming and pilot agent will become less useful, so we can move to having a single process by container, whose lifecyle is controlled by kubelet. The fact pilot-agent controls envoy's lifecyle  is an anti-pattern.
Other than that, this exactly the kind of change we should not be making before cutting 1.0 in two weeks from now. There is no clear benefit, not a thorough design, and too much churn.

Well, pilot-agent is needed for other things and there are plans to use it for more ( for the future firewall,
for secure tproxy, etc).
This is the kind of change to make for 1.0 - the envoy in front of pilot was a feature for v1 and we removed that. In v2 it does nothing of value - but adds overhead and complexity.
Keeping some code that provides no value just because it may be do so in future is not a valid reason
to block this PR. Once the 'direct' mixer API are available we can use them.

This is P1, and by far should not be high on anyone's list. By undoing the work we put in 0.8 for self-monitoring, you are just making the end goal that much harder.

There is no self-monitoring in v2 - all the interesting data is exported directly by pilot and is not visible in envoy. It is just complexity and wasted CPU/memory with no benefit.

Please update the conveniently disabled dashboard tests for istio components.

I agree that streaming gRPC metrics are not going to provide a ton of value, especially in their current state. And I'm all in favor of developing a better app-local monitoring and finding an appropriate way to hook that up through Mixer.
However, I want to stress that the proxy was Reporting to Mixer for more than just metrics. Whatever solution is developed for replacing the metrics integration should include full Report integration.
My primary concern with this entire transition (from v1 with full Reporting to v2 with no reporting) is that it has happened without the replacement being ready. And that represents a loss in functionality -- a minor one in the grand scheme, perhaps, but one nonetheless.
A secondary concern is more about optics and "eating our own dogfood" but that is more philosophical and less tangible.
FWIW, I expect that in the 1.1 timeframe, we will have an improved, periodic reporting capability for streaming scenarios. When that is ready, Pilot will not be able to benefit from those improvements directly if the proxy is removed entirely.
In any case, I appreciate the discussion. I hope that we can quickly work towards a proper integration with Mixer in the near term. We should have at least two examples of writing a client for Mixer in golang at this point, so hopefully that work can be tackled without issue.

My primary concern with this entire transition (from v1 with full Reporting to v2 with no reporting) is that it has happened without the replacement being ready. And that represents a loss in functionality -- a minor one in the grand scheme, perhaps, but one nonetheless.

We lost most of metrics and reports when we moved to Envoy ads, even with the proxy in front. My point is that removing does not change this state in any way. To get the full set of metrics back, we can wait for 1.1+ and do nothing in pilot in the interim.
Btw eating our own dog food does not imply we need to use a sidecar for applications that are capable of adhering to the mixer report protocol to send a set of metrics

@douglas-reid  I think we are on the same page and in strong agreement on the goals.
The current plan for pilot is to use direct mixer APIs as soon as they are ready, and this PR is moving
into this direction by removing the non-functional metrics from envoy. Even if Envoy did have grpc
streaming - we believe direct mixer api will allow us to report richer metrics.
And it is going to 'eat our dogfood' as you say.
Right now mixer and pilot are only components using sidecar - if you believe more components
should eat the sidecar dogfood it would be great to add sidecar (and MTLS) to some of the
others (prometheus, graphana, etc). Even Istio-CA, which I believe doesn't have one and is not
reporting anything ( and is not using streaming grpc ). It would be far more useful then trying to force
a particular solution (that no longer works) for pilot.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
Assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kuat:

citadel is a service, it exposes grpc cert renewal for mesh expansion
we are not removing any functionality - in v2 the sidecar doesn't provide useful metrics,
just overhead. For 0.8 and v1 the sidecar provided metrics - for v2 it doesn't.

Yes, we did lose some metrics functionality when switching to v2 - but now v1 is gone
and we'll gradually add back anything that is missing.

I would reiterate that prometheus, graphana, zipkin, etc are all suitable for use with envoy, they don't use streaming grpc and currently don't have mtls.

@ymesika: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

We can discuss this in the next networking WG meeting - probably ok to ship 1.0 without this, and merge it in master as we'll have more time to test and add any metrics that are identified by Kuat.
Kuat: please include a list of metrics that envoy provides in 1.0 that would be lost, and we'll add them for 1.1 ( and please remove the hold).

I added this topic to the agenda for July 19.

closed as duplicate


Values are not updated when typing

Using the provided example in the usage documentation the value in Input aren't updated when a user types.
Action
User types abc
Expected behavior
Input value equals abc and the onChange event is fired
Actual behavior
Input value is empty and the onChange event is not fired.
Tested on react 16.0.0 and 15.6.1, with library 2.0.8
See example.

Sorry about this, messed up in the tests, assumed target.checked was null or undefined if an input isn't a checkbox. But that is not true. https://codesandbox.io/s/54roklyr9p Install 2.0.10!

@zackify Thank you for the quick reply and fix!


METRON-1986 Batch Profiler Fails to Resolve Stats Stellar Functions

The Batch Profiler does not seem to see the STATS_* functions. When I attempt to run a profile using any of those functions, it fails. It is able to 'see' a limited subset of functions, but not all those that I would expect.
Root Cause
The ClassIndex library is used to create an index of all Stellar functions at compile-time. This index is packaged in the JAR as META-INF/annotations/org.apache.metron.stellar.dsl.Stellar.
When creating a shaded jar using the Maven Shade Plugin, the index files created by ClassIndex are overwritten by default. ClassIndex provides a special transformer for Maven which merges the index files instead of overwriting them.
Without using this transformer, the index files are overwritten and Stellar function resolution will not work. This is why Stellar function resolution is not working.
https://github.com/atteo/classindex#making-shaded-jar
Testing

Spin-up this profile in the Batch Profiler.  It should write successfully to HBase.

{
  "profiles": [
    {
      "profile": "profile-using-stats",
      "foreach": "ip_src_addr",
      "update": { "s": "STATS_ADD(s, length)" },
      "result": "STATS_SUM(s)"
    }
  ],
  "timestampField":"timestamp"
}

Pull Request Checklist

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?
[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
[x] Have you included steps or a guide to how the change may be verified and tested manually?
[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
[x] Have you written or updated unit tests and or integration tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

FYI - I added an integration test for this just to try and help avoid future issues like this.  Unfortunately though, the integration test will not catch this issue.  Our integration tests do not run from the shaded jars that we build.  That is a gap in our testing capabilities currently.

As a side note, I found that this plugin has issues if not placed last in the plugins list while working through the ES REST client migration.
https://github.com/apache/metron/pull/1242/files#diff-1f250467ce2f882bfb71cc0928813df8R301

This looks good, thanks for the fix @nickwallen. +1 by inspection.


Potential Memory Leak

I've noticed in nss_http.c on line 55.
data = malloc(NSS_HTTP_INITIAL_BUFFER_SIZE);
if (!data) goto error;

data is returned to the calling functions and never free'd. This looks like a memory leak unless I'm missing something subtle.

I have fixed this issue.


Installation of APK on Alpine fails with error 127

I tried to install the release APK on a fresh installed Alpine container but it failed with error 127. The post install script "postinstall.sh" uses the shebang /bin/bash which is not available on Alpine images. It doesn't make much sense that the script first action is to check if /bin/bash exists. I created a pull request to change the shebang to /bin/sh.
I tested the script on Alpine, and it worked as expected.

thanks @andi-blafasl
I wonder if it makes sense to also change the script to be POSIX compatible by replacing &> with an explicit redirect -- https://www.shellcheck.net/wiki/SC3020
I used shellcheck.net

had a quick minute and addit it to the PR

any chance to get a release with this fix?


Same Variant appears in both TP sets and in FN or FP set.

Version :
4.0.0
Describe the bug :
I am investigating low recall/precision values (compared to benchmark with HapEval) comparing Sniffles calls agains GIAB reference.
TP-Base: 18437
TP-Comp: 18437
FN: 10151
FP: 2713
For some variants I found that it appears in both TP sets and in FN or FP.
How is this possible? In my understanding of the program, every variant should be classified either in the TP or the FN/FP sets.
If required I could also upload the datasets but first want to make sure that I get the concept right.
I used Truvari with default parameters.

Here are the input VCF and the truvari results.
https://cloud.imgag.de/s/AiyFwXWKWqMqt3C
Thanks for looking into it!

Here's what I looked at:
truvari consistency truvari_output/fn.vcf.gz truvari_output/tp-base.vcf.gz
bcftools query -f "%CHROM\t%POS\t%REF\t%ALT\n" truvari_output/fn.vcf.gz | sort > f.txt
bcftools query -f "%CHROM\t%POS\t%REF\t%ALT\n" truvari_output/tp-base.vcf.gz | sort > b.txt
echo "Pulling shared lines"
comm -1 -2 b.txt f.txt

Consistency does essentially the same thing as the bcftools queries and comm command. It shows that there are 5 variants found in both fn and tp-base.

Consistency report

#
# Total 28583 calls across 2 VCFs
#
#File	NumCalls
truvari_output/fn.vcf.gz	10151
truvari_output/tp-base.vcf.gz	18437
#
# Summary of consistency
#
#VCFs	Calls	Pct
2	5	0.02%
1	28578	99.98%
#
# Breakdown of VCFs' consistency
#
#Group	Total	TotalPct	PctOfFileCalls
01	18432	64.49%	0% 99.97%
10	10146	35.50%	99.95% 0%
11	5	0.02%	0.05% 0.03%

Looking at the 5 variants in detail with the comm command:

"repeated" variants

chr1	211111841	GCTGTACTGTCTGGGAAGTGAGGAGCACCTCTGCTTGGCTGCCCACCATCTGGGAAGTGAGGAGTGCCTCTGCCTGGCTACTGCACCGTCTAGGAAGTGAGGTGCCCCTCTGCCTGGCCA	G
chr10	132852325	T	TTAAGAATTCTCAGATCCTGATCCACAGACGTAGTATGTTCCTCCAGTTACTTAGGAATTCTCAGATCCTGATCCACAGACGTGGTATGTTCCTCCATTTACTTAAGACTTCTCAGATCCTGATCCACAGACGTGGTATGTTCCTCCATTTACGTAGGAATTCTCAGATCCTGATCCACAGACGTGGTATGTTCCTCCATTTACTTAGACATTCTCAGATCCTGATCCACAGACGTGGTATGTTTCTCCATTTACTTAGACATTCTCAGATCCTGATCCACAGACGTGGTATGTTTCTCCATTTACTTAGACATTCTCAGATCCTGATCCACAGACGTGGTATGTTCCTCCAGTTACTTAGGAATTCTCAGATCCTGATCCACAGACGTGGTATGTTTCTCCATTTACTTAGACATTCTCAGATCCTGATCCACAGACGTGGTATGTTCCTCCATTTACG
chr10	1473941	A	AGGGGGCCGGGTAGTTTCTAGTGCAGGAGACACGCCTTTCCTTGCTGAGCCCCCGGATCATGGGGGAGGCCTCGACG
chr19	404269	TCCTGAGGGGTCTGAGGGGGGGACGGGGTCCTGCCCTGAGGGGGTGTGGGGGGGACGGGGTCCTGCCCTGAGGGGTGTGGGGGGGGGACGGGGTCCTGC	T
chr2	2884197	ATAAATACTTTATATATGTGTATATGTAAATACTTTATATATGTGTATATGTAAATACTTTATATATGTGTACATG	A

Pulling any of those POS via e.g. zgrep 211111841 GRCh38_HG2-verrkoV1.1-V0.6_dipcall-z2k.vcf.gz shows:
chr1	211111841	.	GCTGTACTGTCTGGGAAGTGAGGAGCACCTCTGCTTGGCTGCCCACCATCTGGGAAGTGAGGAGTGCCTCTGCCTGGCTACTGCACCGTCTAGGAAGTGAGGTGCCCCTCTGCCTGGCCA	G	30	.	REPTYPE=CONTRAC;BREAKSIMLENGTH=425;REFWIDENED=chr1:211111730-211112273	GT:AD	1|0:1,1
chr1	211111841	.	GCTGTACTGTCTGGGAAGTGAGGAGCACCTCTGCTTGGCTGCCCACCATCTGGGAAGTGAGGAGTGCCTCTGCCTGGCTACTGCACCGTCTAGGAAGTGAGGTGCCCCTCTGCCTGGCCA	G	30	.	REPTYPE=CONTRAC;BREAKSIMLENGTH=425;REFWIDENED=chr1:211111730-211112273	GT:AD	0|1:0,1

You  can see that the differences are only the phase of the genotype, which is why truvari and the bcftools; comm commands are saying they're the same variant, but they're actually two different variants... Or... the same variant on different haplotypes.
Presumably this is a reporting error where the vcf should make this a 1|1 variant. But as is, and given default parameters, I believe Truvari is working as expected. Having said that, I think you may  be interested in the --pick parameter. By default, each variant representation gets to participate in a single match. In this case, if you were to allow variant to match up to ac times, the FN would be become TP since the TP's counterpart at chr1:211111841 (found through MatchId=1288.1.0) is...
chr1	211111842	Sniffles2.DEL.87AES0	N	<DEL>	60	PASS	PRECISE;SVLEN=-119;SVTYPE=DEL;SUPPORT=73;END=211111961;STDEV_POS=12.349;STDEV_LEN=0.777;COVERAGE=77,76,74,73,70;STRAND=+-;RNAMES=<truncated>;AF=0.986;PctSeqSimilarity=0.9537;PctSizeSimilarity=1;PctRecOverlap=0.9917;SizeDiff=0;StartDistance=-1;EndDistance=-1;GTMatch=1;TruScore=98;MatchId=1288.1.0	GT:GQ:DR:DV	1/1:60:1:73

... a homozygous variant. Have fun benchmarking!
p.s. You may be interested in truvari refine. Basic bench has a known limitation with 1-to-1 variant matching which explains part of the difference between truvari and hapeval reports. refine overcomes that limitation via variant harmonization. It's currently only built to be used with a bed-file with fairly tight boundaries around  regions that could benefit from being harmonized. If you're interested in exploring refine, let me know because my development roadmap includes building a way to help users make their 'tight boundaries' bed file.

Just wanted to follow up and let you know that I've finished the feature that 'hooks' truvari bench with truvari refine for whole genome data and finds the closest estimate of benchmarking performance. It's currently available in the develop branch of the repository. I'll cut an official Truvari v4.1 release next week. Documentation on how to run it is available in the wiki.


Allow subclass DjangoCRUDObjectType

I need to handle users permissions on mutate, create, update and delete methods, but I dont want to define those methods for each type.
Instead, I thought about subclassing DjangoCRUDObjectType and add some fields to the Meta class (create_perms, update_perms, ...). Then in my CustomCRUDObjectType(DjangoCRUDObjectType) I could declare the mutation methods and do something like this:
@classmethod
def create(cls, parent, info, instance, data, *args, **kwargs):
    authorized = all(info.context.user.has_perm(perm)
                     for perm in cls._meta.create_perms)
    if not authorized:
        raise GraphQLError('not authorized')
    return super().create(parent, info, instance, data, *args, **kwargs)

And use this class instead of DjangoCRUDObjectType.
However, this is not currently possible, because DjangoCRUDObjectType does not accepts a _meta param on its __init_subclass_with_meta__, and instead creates one from scratch.
Solution
I believe it is possible to do a minor refactor on __init_subclass_with_meta__ to receive a _meta param, and then do something like this:
if not _meta:
    _meta = DjangoCRUDObjectTypeOptions(cls)

Do you think that this is possible? I'm willing to open a PR if time is an issue, although this seems to be a pretty quick fix.

Thank you for your contribution
I agree that the inability to have a subclass is a problem.
I like your way, I would like your PR.
Best regards