Bug Report (metadata) Tornado issue with Gremlin python client

Running the latest version of amundsen-metadata, i.e. tak latest or 3.8.1 as they seem to be the same, I get the below error:
2021-07-26T12:05:18+0000.682 [ERROR] app.log_exception:1761 (1:Thread-8) - Exception on /tags/ [GET]
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1813, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python3.7/site-packages/flask_restful/__init__.py", line 467, in wrapper
    resp = resource(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/flask/views.py", line 87, in view
    self = view.view_class(*class_args, **class_kwargs)
  File "/app/metadata_service/api/tag.py", line 31, in __init__
    self.client = get_proxy_client()
  File "/app/metadata_service/proxy/__init__.py", line 47, in get_proxy_client
    client_kwargs=client_kwargs)
  File "/app/metadata_service/proxy/neptune_proxy.py", line 117, in __init__
    driver_remote_connection_options=driver_remote_connection_options)
  File "/app/metadata_service/proxy/gremlin_proxy.py", line 874, in __init__
    **_properties_except(self.driver_remote_connection_options, 'url'))
  File "/usr/local/lib/python3.7/site-packages/gremlin_python/driver/driver_remote_connection.py", line 45, in __init__
    password=password)
  File "/usr/local/lib/python3.7/site-packages/gremlin_python/driver/client.py", line 76, in __init__
    self._fill_pool()
  File "/usr/local/lib/python3.7/site-packages/gremlin_python/driver/client.py", line 92, in _fill_pool
    conn = self._get_connection()
  File "/usr/local/lib/python3.7/site-packages/gremlin_python/driver/client.py", line 105, in _get_connection
    self._transport_factory, self._executor, self._pool)
  File "/usr/local/lib/python3.7/site-packages/gremlin_python/driver/connection.py", line 40, in __init__
    self.connect()
  File "/usr/local/lib/python3.7/site-packages/gremlin_python/driver/connection.py", line 45, in connect
    self._transport = self._transport_factory()
  File "/app/metadata_service/proxy/gremlin_proxy.py", line 873, in <lambda>
    transport_factory=lambda: TornadoTransport(read_timeout=None, write_timeout=None),
TypeError: __init__() got an unexpected keyword argument 'read_timeout'

I didn't see it before, metadata service worked and my code is not adding anything tornado or gremlin related. I'm using AWS Neptune but I'm not sure if it's related, as it seems that the code and tornado/gremlin client has a version mismatch.
Expected Behavior
Gremlin client should work fine.
Current Behavior
As above.
Possible Solution
Going back to 3.5.0 fixes it. I've only noticed it as we had previously latest tag used in our deployment.
Steps to Reproduce

Deploy metadata service from Docker Hub image tag 3.8.1.
Send get on \tags\ endpoint; you should get status code 500.
See logs for error.

Note that if you have pods on k8s running, you need to delete them to pull new images.
Screenshots (if appropriate)
NA
Context
Metadata service doesn't work after version update.
Your Environment

Amundsen version used: 3.8.1 (metadata-service
Data warehouse stores: AWS Neptune as metadata service database
Deployment (k8s or native): k8s
Link to your fork or repository:

@jsnowacki should be fixed now, feel free to reopen if it is not the case.

@feng-tao Not sure if this was confirmed to be fixed by @jsnowacki. Appears to still be an issue as of 3.9.0. I cloned and update my metadata/requirements.txt to use amundsen-gremlin>=0.0.12 and gremlinpython==3.4.12 and it seems to fix the issue.

Yeah I'm experiencing that same thing, this issue should probably be reopened.

I am getting the same error while using AWS Neptune as metadata service.

I didnt because I used Neo4j.

Hi @feng-tao, after several tests, I realized that this error happens because /app/metadata_service/proxy/gremlin_proxy.py
is trying to generate a TornadoTransport(read_timeout=None, write_timeout=None) with parameters that gremlinpython==3.4.3 doesn't support.
Running a pip install gremlinpython==3.4.13 in the amundsendev/amundsen-metadata:3.10.0 image solves the error, but while building this new modified image, the following error appears:
amundsen-metadata 3.10.0 requires gremlinpython==3.4.3, but you have gremlinpython 3.4.13 which is incompatible.
I haven't really seen any other dependencies/issues appearing on the image after the change but I might be missing something..
Do you think it could be possible to change the gremlinpython requirement or at least change the version for a new one that implements the parameters used on the TornadoTransport call? (I think the first one that implements these parameters is  gremlinpython==3.4.9
Would it be enough to change the setup.py gremlinpython requirement (line 30/31), or should we change it somewhere else?

This is still a problem when using the last amundsen metadata docker image (3.10.0) with neptune proxy.

The same issue is still available on the master branch. The official amundsendev/amundsen-metadata:3.11.0 is not shipping amundsen_gremlin package, thus this happens. Building a container with installed installs gremlinpython==3.4.3 which suffers the same issue as mentioned on this issue.


Is it possible to reset child stack only?

Version
Tell us which versions you are using:

react-native-router-flux v3.39.1
react-native v0.44.0

Expected behaviour
I now have several scenes and would like to keep the root scene alive while shutting down some specific child scene in the stack.
This is my router configuration.
root -> A -> B -> C
When move from B to C, is it possible to entirely remove both A and B from the stack, so my navigation stack would become as follow:
root -> C
There will be a time where user will pop the scene from C to root without going through either A or B.
If we keep A and B in the stack while presenting C, will there be a performance trade-off?
Rex.

Unfortunately it is not supported (by react-navigation), but it is possible to implement - just define reset action without react-navigation, PR is welcome...


Snapshot ingestion procedure for CSI Unity Driver misising

Document update/addition for Snapshot ingestion procedure in CSI-Unity driver
https://jira.cec.lab.emc.com/browse/KRV-21815
Operating System
any Operating system,
Container Orchestrator
Kubernetes any version
Storage Platform
any
Protocol
Other
Relevant log output
Need to add the Snapshot ingestion procedure for CSI Unity Driver in csm - docs

Additional Details
No response

/sync


Salmon results compressed and the updated samplesheet for "test_salmon" configuration

ERR188383.tar.gz
ERR188428.tar.gz
ERR188454.tar.gz
ERR204916.tar.gz
samplesheet_salmon.csv

I'm guessing this PR wasn't meant to be done on master


Internal: implement tool to construct changelog

At the moment each pull request is expected to have its own edit of CHANGES.txt - the PR template encourages this. The problem is after a PR sits for a while, there are inevitably conflicts to resolve in that file. This hits you when you need to rebase, for example - you have to perform a relatively useless merge edit because two PRs each added a line in a similar place and git sees a conflict. We would like to implement something to handle keeping these separately and producing a changelog for a release at release time.
For illustration, the CPython project has a system where with each merge, a new file is created with the potential changelog entry, these are then stitched together by a homegrown blurb tool when it comes time to make a release (and the directory of changes-since-last-release is cleaned out).  You can see this in action at https://github.com/python/cpython. Look in Misc/NEWS.d.  That directory contains past version-specific changelogs, while the subdirectory next containss categorized snips that are candidates for inclusion. The needs of CPython are not the same as SCons, so directly lifting it doesn't entirely make sense, but it serves to illustrate the idea.

https://github.com/twisted/towncrier also looks pretty good.
Buildbot project uses that. among others.

https://github.com/twisted/towncrier also looks pretty good.
Buildbot project uses that. among others.

I don't have any biases here, just pointed to python.org as a sample of what could be done, to get this recorded.

I don't have any biases here, just pointed to python.org as a sample of what could be done, to get this recorded.

Okay, towncrier seems fine for this purpose.  To put it into use, I guess we need some dev guidelines, to answer these questions plus I'm sure ones I didn't think of.

Who: does a PR submitter write the entry? If so, when?  The "convention" suggested by towncrier is to use an issue number, we don't always have an issue for every PR and you don't know the PR number until you've submitted it, which makes a little bit of a chicken and egg if you say "created with the PR".  Or does a project maintainer create it when merging?
Categories: predefined are .feature, .bugfix, .doc, .removal, .misc but you can also create your own.
Content: is the policy "only interesting to users"? So less detailed than CHANGES.txt?  Would it replace or complement CHANGES.txt. Do you make entries that aren't necessarily interesting to users? (.misc is defined for that in the project page).

Here's buildbot's README.txt on such..
https://github.com/buildbot/buildbot/tree/master/master/buildbot/newsfragments

Yes. PR submitter
maybe add .deprecation ?
hmm. not sure. let me ponder and respond later.

thanks... maybe I should have made item 1 two questions, as there is an interesting chicken-and-egg problem (I don't know how Python handles it with their setup): how to use the issue for the news clip name if you don't have the number until you submit?

O. IC.  No need to have PR # IMHO.. Only an issue # if the PR's fixing it..

So towncrier (and the Python blurb system, and one other I looked at) don't have a way to order entries. They do use the issue # in the fragment name. Python uses the date as well, for example NEWS.d/Library/2021-01-16-18-36-00.bpo-33809.BiMK6V.rst to fix bugs.python.org #33809.
So in the absence of mandating an issue number as the fragment name (or part of name), we'd need a "naming convention". Which could just be "make up something unique", or maybe we could provide a tool that adds a random number to the chose name as apparently Python is doing.
We don't have a way to associate the PR submitter (or author if someone else submits the PR) with the fragment contents like the current CHANGES.txt does - but RELEASE.txt does not.
Do we still need CHANGES.txt? we do have git log though it tends to be noisier than what's gone into CHANGES.txt. On the whole, this seems better suited to the model that towncrier seems written to: "news for users".

So with 4.2 released, what do we do here?  Keep the status quo? Implement this to replace RELEASE.txt? Or CHANGES.txt? Or both? If both, do we need to keep two separate ones?

Interesting.. so you can specify alternative output template files. (jinja2 format?)
From their git repo:
https://raw.githubusercontent.com/twisted/towncrier/master/src/towncrier/templates/hr-between-versions.rst

In the example repo I did up, I had to comment out the template thing because I couldn't figure out how to make it work.  But possibly that is part of the answer.


Would like a description of "AuthN and AuthZ API changes (Async, Challenge)"

I have authored an OAuth1 middleware, and when I pulled a recent package everything was broken.  I can kind of see what's happening in the code (3a8ea672eae590785a78d74777abb76bb9664130), but it would be helpful is someone could go through the design choices involved as well as their motivations.  "Async and challenge" kinda-sorta tell me where to look, but there was already support for async in the parts that seemed to need it the most, and I have no idea why challenge would have needed changing.
I don't need a book, just a short clue-in ;-)

/cc @HaoK @loudej @Tratcher

Sure, I'll give short brief overview, feel free to ask for more details:

Why Async?  Prior to making all of auth Async, there was a separate callstack for both Sync/Async, with parallel methods and virtual methods in the auth handlers.  This was both cumbersome and error prone so we decided to just eliminate the sync path for simplicity.

ChallengeBehavior: this was basically where we landed as a result of the 401/403 thrashing https://github.com/aspnet/Security/issues/273: which explains the motivations/changes a bit

As a result of all these changes, we made auth handler more opinionated with less virtuals and only a few extensibility endpoints as its now intended do more stuff i.e. Challenge and auth handlers should only need to override the appropriate HandleXyz when they actually need to change the behavior.


FLINK-13524 [docs] Fixed typo in Builder method name from Elasticsearch example

What is the purpose of the change
Fix typo in Builder method name from Elasticsearch example
Brief change log
The Builder method name from class ElasticsearchSink has got a typo (missing 'd') in the Elasticsearch connector section for Scala (ES version 6.x).
new ElasticsearchSink.Builer[String](
should be:
new ElasticsearchSink.Builder[String](
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@a-romero Thank you for fixing this, could you please rebase your branch to remove the merge commit.

@a-romero Thank you for fixing this, could you please rebase your branch to remove the merge commit.

@sjwiesman yep sorry, rebased now


Enable CI test metrix for openvswitch 2.11 and 2.13.

A dedicate pytest marker ovs could helps for this case.

Currently we are testing 2.11 with tier1.
Add a travis build test for 2.13 with ovs test cases only could be sufficient for this issue.


With recommended configuration uncaught exceptions are logged twice

The readme suggests configuring Laravel to log uncaught exceptions and then call parent::report on the exception too.
But the parent report method also logs the message. This means it gets reported twice.
They are reported with different messages, which I'll talk about in a different ticket.

It seems to me it would be better not to suggest adding anything to the report method at all, and have it logged just once.

Yeah, that's what I was hoping for.
Your suggestion above only works around the other issue, since both branches of your conditional above do essentially the same thing, just with different formatting.


$divfloor not supported by write_smt2

$divfloor isn't supported by write_smt2, apparently it was forgotten though $modfloor does work.
Steps to reproduce the issue
Compile commit 0b1a1a576 (git master when issue was created)
Run the following yosys script:
read_verilog -icells -formal <<EOF
module uut;
    wire [7:0] a = $anyconst, b = $anyconst, y;

    \$divfloor #(
        .A_WIDTH(8),
        .B_WIDTH(8),
        .Y_WIDTH(8),
        .A_SIGNED(0),
        .B_SIGNED(0),
    ) divfloor (
        .A(a),
        .B(b),
        .Y(y)
    );

    always @* begin
        assume(b == 4);
        assert(a >> 2 == y);
    end
endmodule
EOF
prep
write_smt2 -wires

Expected behavior
generate smtlib2 code
Actual behavior
...
; SMT-LIBv2 description generated by Yosys 0.17+33 (git sha1 0b1a1a576, gcc 9.4.0-1ubuntu1~20.04.1 -fPIC -Os)
Creating SMT-LIBv2 representation of module uut.
ERROR: Unsupported cell type $divfloor for cell uut.divfloor.

I don't think SMT-LIB has an operator for that (bvsdiv is truncating division: https://smtlib.cs.uiowa.edu/logics-all.shtml), so it'd have to be implemented by hand - that's why I left it out in #1885.


AWS database & network cards

This adds the AWS database & network services cards. And some refactoring to allow filtering to be applied generically across all overview tabs.
Note: The network card uses "Load Balancer-Network" as the product family for now.
@chargio will see if the price list identifies networking as something different. If so, I'll update the product family via another PR -- a one line change.
Fixes https://github.com/project-koku/koku-ui/issues/596
Fixes https://github.com/project-koku/koku-ui/issues/597
Network card:

Database card:

Codecov Report

Merging #609 into master will decrease coverage by 0.91%.
The diff coverage is 64%.

@@            Coverage Diff            @@
##           master    #609      +/-   ##
=========================================
- Coverage   82.22%   81.3%   -0.92%
=========================================
  Files         194     194
  Lines        2993    3001       +8
  Branches      496     499       +3
=========================================
- Hits         2461    2440      -21
- Misses        474     494      +20
- Partials       58      67       +9

Impacted Files
Coverage Δ

src/api/awsQuery.ts
80% <ø> (-20%)
:arrow_down:

src/store/ocpDashboard/ocpDashboardWidgets.ts
100% <ø> (ø)
:arrow_up:

src/store/awsDashboard/awsDashboardReducer.ts
100% <ø> (ø)
:arrow_up:

...tore/ocpOnAwsDashboard/ocpOnAwsDashboardWidgets.ts
100% <ø> (ø)
:arrow_up:

src/api/ocpQuery.ts
80% <ø> (-20%)
:arrow_down:

src/api/ocpOnAwsQuery.ts
80% <ø> (-20%)
:arrow_down:

src/store/ocpDashboard/ocpDashboardCommon.ts
100% <100%> (ø)
:arrow_up:

src/store/awsDashboard/awsDashboardWidgets.ts
100% <100%> (ø)
:arrow_up:

src/store/awsDashboard/awsDashboardCommon.ts
100% <100%> (ø)
:arrow_up:

...store/ocpOnAwsDashboard/ocpOnAwsDashboardCommon.ts
100% <100%> (ø)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf698fa...98f9dfa. Read the comment docs.

Shouldn't the top services tab show Load Balancer-Network? it is showing EC2

I am trying to visualize the price list, but I can't open it in an excel


Google search preview showing title as 'undefined' until the 'Title (Override)' field is edited

Fresh install of the plugin on existing page blueprints with listed pages. If I type something in the 'Title (Override)' field, then delete it, the preview correctly picks up the title of the page from the Kirby page title.

I'll try to reproduce this locally and report back as soon as I know more. Thanks for bringing up this issue.

Maybe this is the same issue as above: I just tried out the plugin in a new Starterkit (kirby <IP_ADDRESS>) and I can't override the title.

The output stays the default:
<title>Home - Mægazine</title>

Should be fixed in 1.1.1. Can you give it a try on your end and confirm that everything works as expected?


docs: add Windows image release notes for 2024-6B

What type of PR is this?
/kind documentation

What this PR does / why we need it:
add Windows image release notes for 2024-06B. Reference: #4505
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[x] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.969%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3458

💛  - Coveralls


Fix $FlowFixMe issues

As mentioned in #38 there is still one outstanding issue with Flow and that is that it doesn't recognize the alias for grommet-cms.  I've attempted to fix it following the guide, located here, to no avail.  We need to get this resolved and remove the workaround comments // $FlowFixMe.  With this workaround, the Flow typechecking should be totally working.

Still a work in progress, but I will dig into it today.

Got this fixed in the fix_flow_fix_me branch and am going to merge into my latest PR.

See #64


[CELEBORN-1077] Support to apply base legend format for all grafana metrics

What changes were proposed in this pull request?
Apply basic legend format for all grafana metrics.
Why are the changes needed?
Before, the metrics dashboard is not readable easily.

Does this PR introduce any user-facing change?
Yes. A variable introduced.
How was this patch tested?
Local Test.
Now, I can modify the variable value to {{pod}}_{{cluster}} and have a better insight.

cc @FMX could you help review this pr?


Show help when ran with no arguments

Methadone simply errors out when no app_name is supplied. Change to show error
and output help, then exit like normal.

This is now available in 0.4.0.  Thanks for the patch!


Non-sequential label

Hello, can I change the label value of the SynthSeg segmentation result? For example, from the original {0,2,3,4,5,7,8...58,60} to the continuous {0,1,2,3...30,31}.
Best
Kim

Yes sure!
for that you can replace
seg_patch = labels_segmentation[post_patch_seg.argmax(-1).astype('int32')].astype('int32')
by
seg_patch = post_patch_seg.argmax(-1).astype('int32')
in line 721 in predict_synthseg.py .
Otherwise, you can also directly modify the output segmentation themselves.

Thanks for your quick and clear reply! It helps me a lot!


fix(rpc): return notification results

Fixes #156
vim.lsp.rpc.notify() should return true when the notification was successfully sent. Without this, this line is always nil, LspNotify autocommands aren't executed, and then inlay hints aren't refreshed.

Nice catch, thanks for searching for issue and fixing it!


Deprecate python 3.7

Start supporting python 3.11

Dependencies:

https://github.com/tiran/pysha3/issues/30

There's still some stuff that needs to be fixed so we will merge this when that's sorted out

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 12 (100.0%)  changed or added relevant lines in 10 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 84.196%

Files with Coverage Reduction
New Missed Lines
%

gnosis/util/util.py
3
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
3303

Relevant Lines:
3923

💛  - Coveralls


see more deets on what differs

Just trying to debug on why we keep seeing diffs.

So, the file is being deleted, 🤷
~/work/eventing-rabbitmq/eventing-rabbitmq/src/knative.dev/eventing-rabbitmq ~/work/eventing-rabbitmq/eventing-rabbitmq
Found diffs in: :100644 100644 ae03631ac1da03cd3ee6fff126895ae8fe18deed<PHONE_NUMBER>000000000000000000000000000000 M	go.sum
:100644<PHONE_NUMBER>49b6ee28c28d7a4463af9cbd534922533ced<PHONE_NUMBER>000000000000000000000000000000 D	third_party/VENDOR-LICENSE/github.com/containerd/continuity/pathdriver/LICENSE
knative-sandbox/eventing-rabbitmq is out of date. Please run hack/update-codegen.sh


Import / Export layer data

Import and Export can be achieved with a custom post query.

Download layer data as geojson implemented.

Can you check whether the spooling, ie turning json into a file can be done in the client instead of the serverless function. We are trying to have serverless functions to process as little as possible. What can be done in the database should be done in the database and what can be done in the client should be done in the client.
With the file creation in the client it should also be possible to use the existing geojson endpoint without the need for the data endpoint which is almost identical to the geojson endpoint.
Can you also test whether it is possible to have the download / create file in a module a la cluster panel? This way we can customise the download per use case without having to ever change and test any core library code. This can also be an excellent showcase for client modules. I'll look at the client modules documentation today.

I moved geojson download in the geojson endpoint. I made it straightforward but when we get client requirements for custom import/export this should be developed as a plugin.

I have amended the layer download method. This should not require the geojson endpoint, changes to the geojson endpoint, or an infoj.
The download function should be based on the query method as it is used for dataviews. _xyz.query returns a response from query. _xyz.query supports viewport, filter, roles, etc.
All which was needed was spooling the response from _xyz.query to a file (blob).
Definition for the download should be as follows.
"download": {
"query": "blueprint_json",
"format": "json"
}
The download object is passed to the query method and supports viewport, filter, roles, etc.
The download link can be created like so:
    _xyz.query(layer.download).then(response => {

      const blob = layer.download.format === 'json' && blobJson(response) || blobCSV(response)

      const link = _xyz.utils.html.node`<a
        href=${URL.createObjectURL(blob)}
        download=${`${layer.key}.${layer.download.format || 'csv'}`}>`

      link.click()

    })

And the blob functions for CSV and JSON are like this:
  function blobJson(response) {

    const rows = response.map(record=>{

      const feature = {
        type: 'Feature',
        properties: record
      }

      feature.geometry = JSON.parse(record.geometry)

      delete feature.properties.geometry

      return feature

    })

    const json = JSON.stringify({
      type: 'FeatureCollection',
      features: rows
    })

    return new Blob([json], {type: 'application/json'})
  }

  function blobCSV(response) {

    const rows = response.map(record=>{

      return Object.values(record).map(record => {

        return isNaN(record) && `"${record}"` || record

      }).join(',')
    })

    const csv = rows.join('\r\n')

    return new Blob([csv], { type: 'text/csv;charset=utf-8;' })
  }

note: The geometry field for the geojson must be defined as geometry in the query.
eg.
"blueprint_json": {
  "template": "SELECT id, name, address, st_asgeojson(geom_p_4326) as geometry FROM mapp.points WHERE true ${viewport}",
  "dbs": "MAPP"
}


Add methods: groupBy, chunk, splice, find, findLast, any, every

I'll add chunk, splice, find, any and maybe groupBy to IterableValue after merge of this PR and IterableValue

@dazet Will you merge this on today's midnight? :)


SimpleAudioSample ListenTo is not working after reboot

Building and installing the SimpleAudioSample works on Windows 10 and Windows 11.
The capture generates a sine wave, which I can listen to using "Listen To" in mmcpl.sys and selecting my speakers.
However, after rebooting the computer, I can hear nothing, but I see the VU meters moving, and a recording works.
Stopping the "Listen To" and setting it back restores the normal hearing.
So, the driver seams to work properly : the capture generates the sine, I can see it on VU meters and while recording.
My guess is that there is a single capture running, which is shared between all listeners (VU, recorder and Listen To) by the audio engine, and in this case the wave RT Stream is working.
What is preventing the ListenTo to work after a reboot ?

I noticed also that restarting the "Windows Audio" service puts back the normal hearing.

I finally found that the problem is only on Windows 11, and probably only since 22H2, as others have the same problem.
So this is an OS problem, not the driver.


Nityaravi patch 1

Added region tags to pull in snippets for cl/508160127

I reviewed and it looks good to me.

Approving, but Nitya will update all region tags to use prefix: cloudbuild_

@psimakov Can you follow these instructions to approve this PR https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews?

One test failed above:
https://console.cloud.google.com/cloud-build/builds/685db1c6-62d9-4080-a82f-defbc9037ac7?project=786554430557
I reviewed the logs and retriggered the test as the error was transient. This has succeeded:
https://console.cloud.google.com/cloud-build/builds/da7240fc-6b46-4fcf-8f99-7cd6257ec979?project=786554430557
So we are good to merge.


In HARK/cstwMPC do we need cstwMPCold?

I'm guessing from the "old" suffix that it can be removed?

I keep meaning to look into that. I know it doesn't run anymore, but
haven't deleted it in case there's an odd bit of code that didn't get moved
to the new version. Maybe some robustness checks and figures?
On Sat, Jul 28, 2018, 10:36 AM Christopher Llorracc Carroll <
<EMAIL_ADDRESS>wrote:

I'm guessing from the "old" suffix that it can be removed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/179, or mute the thread
https://github.com/notifications/unsubscribe-auth/ANUQFUpJZotJYvE1G0p_V7mK6S87ayGzks5uLHbogaJpZM4VlEDx
.

This can be closed I think


Edit box - Text scroller appears if the edited text contains a emoji

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
Edit comment should not have a scrollbar if there's a emoji in a single line text.
Actual Result:
Scrollbar appears when adding a emoji to the edited text.
Action Performed:

Go to staging.expensify.cash
Log in with any account
Navigate to a conversation
Send a single emoji
Edit the message

Workaround:
Unknown
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.43-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Similar to https://github.com/Expensify/Expensify.cash/issues/2599 but it's affecting only the edit comment box.

Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @RachCHopkins (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Ummm. I @isagoico have no way to send a message on staging. There is no message box whatsoever:

Yep it's a weird issue, sometimes reloading the app or refreshing the page solves it https://github.com/Expensify/Expensify.cash/issues/2804

Ok, no scrollbar for me on MacOS / Chrome

What OS/Browser combo are you using @isagoico ?

Issue reproducible during today's KI retests

What OS/Browser combo are you using @isagoico ?

This is definitely an issue with Windows if it isn't reproducible on Mac.

Ok, based on that I'll add the label!

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Issue reproducible today during KI retests

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Seems like the engineering assignment was removed accidentally, pulling the trigger again for review.

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Jumping in to post on Upwork now.

If you are interested in working on this issue, then post directly here in GH with a proposal with the technical explanation of the changes you will make. Somebody from Expensify will review your proposal in GitHub, and if your proposal is accepted, you will be hired in Upwork for the job. Thank you!

Upwork job posting for reference: https://www.upwork.com/jobs/~01db49fd6e066d5af8

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

PROPOSAL
We can achieve this by updating the style here
https://github.com/Expensify/Expensify.cash/blob/b4e07c60df0c1edf7f48c320c7ec36609648a3d6/src/pages/home/report/ReportActionItemMessageEdit.js#L99
<View style={[styles.chatItemComposeBox, styles.flexRow, styles.chatItemComposeBoxColor]}>
    <TextInputFocusable
        multiline
        onChangeText={this.updateDraft} // Debounced saveDraftComment
        onKeyPress={this.triggerSaveOrCancel}
        defaultValue={this.props.draftMessage}
        maxLines={16} // This is the same that slack has
        style={[styles.textInputCompose, styles.flex4]}
        onFocus={() => {
            scrollToIndex({animated: true, index: this.props.index}, true);
            toggleReportActionComposeView(false);
        }}
        autoFocus
    />
</View>

NOTE: above used styling object already used in-app for new comment <TextInput>.

Managed to reproduce the issue on Windows (no issue on Linux). It looks like emojis have higher line-height on windows.
linux, no issue, emoji is inside textarea:

windows, emoji is a few pixels higher than textarea:

The line-height for textarea is set to normal by default, which should be fine but causes this weird behavior.
Setting textarea line-height to any of these fixes the issue:

inherit
unset
any number like 1, 1.2. Even If I put 0 there is no scroll bar

My proposal is to add lineHeight: 'unset', here:
https://github.com/Expensify/Expensify.cash/blob/main/src/styles/styles.js#L319-L333
It's going to look like this on windows:

and like this on linux(I would assume mac too):

Won't affect native because native implementation of TextInputFocusable doesn't use that style.

Nice thank you for the proposals and yes I'm leaning towards the one by @aliabbasmalik8 since it will just affect this component.
@aliabbasmalik8 feel free to create a PR to solve this.

Oh also @aliabbasmalik8, i dont see your proposal for this issue in upwork. Please post your proposal there too so that we can hire and pay you for the work 🙂

@JmillsExpensify, feel free to accept Ali's proposal in Upwork whenever you get the chance.

Jumping in now!

Issue reproducible today during KI retests


Update README.md

Hello, this is my first time contributing to an open source project. I noticed that your contribution link does not link to the correct contribution page. I have made changes to fix the url

Thank you @WaiChungK !


Animated: useNativeDriver was not specified. This is a required option and must be explicitly set to true or false

Hei,
I'm getting this warning
A possible fix: https://reactnative.dev/blog/2017/02/14/using-native-driver-for-animated#how-do-i-use-this-in-my-app

+1 on this. Getting this too.

+1

+1

+1

+1

+1


copy update: contact us page

Trello 351 - Update the copy on the Contact us page.

Web Copy // Contact us

Notes

The JD for the internship positions might not be finalized, I will get confirmation before merging, but that is not blocking to review.

 Implement copy changes in Web Copy // Contact us


how do i move just one area

how do i just move that one piece

Cut it with the cut tool to clipboard and place back on mouse position with ctrl+v


Fix manageViewSubcription when there isn't any view attached

I found a strange behaviour during my implementation of #54 (and the follow up issue #55 (2)).
We can actually send a viewSubscription to the SubscriptionHandler even when there isn't any view attached.
This PR will fix that issue.

I'm fine with throwing an exception when calling manage*() and the presenter is in the wrong state


Getting "Super expression must either be null or a function, not undefined" when extending a Phaser class

First, just want to say I love the work you've done here and I've been using your generator exclusively for my Phaser projects.
I've just begun setting up a new project and encountered this error while extending a Phaser class in the same way that I have previously using this generator.  Thinking it may have been something that I did, I set up a fresh project and created a new file extending the Phaser.Tilemap class and sure enough I immediately encountered the same error.  Extending something like Phaser.Group works fine.  Difference seems to be that I'm using the latest version of your generator for this project.  Any help you could provide would be greatly appreciated.
Edit: Looks like the issue was fixed with a recent update

Hi, @pparke. Sorry for the late reply and thanks for choosing slush-phaser-plus.
Just to be sure if the issue is with the generator or the template project, I have a few questions.

What updated? The generator or the created project dependencies?

When running the generator, which option did you chose? I'm sure that at least the “no physics” option lacks Tilemap support, besides it having nothing to do with physics engines but Tilemaps were coupled to Arcade Physics in the past.

Sorry for the lack of details, I had thought it was resolved after updating the generator but it turns out that the issue is still occurring. I think that you're right about the "no physics" option being the cause since I am able to get it working when starting a new project and selecting arcade physics.  Thanks for getting back to me :)


[e2e] TopicTests.clearMessagesForPartition : Clear Messages for partition

Autotest implentation for:
https://app.qase.io/project/KAFKAUI?view=1&suite=5&case=19
Description:
Checking Messages clearing for the selected Partition within Topic/Overview
Preconditions:
Login to Kafka-ui application
Open the 'Local' section
Select the 'Topics'
Open the Topic profile which has messages for different partitions
Stay in 'Overview' tab
Steps:
1  Click on Menu icon for partition
2  Press 'Clear messages'Expected resultSuccess message about clearing should displayAll the messages for selected partition should be deleted

Bug found
https://github.com/provectus/kafka-ui/issues/2778


Implement filtering puzzles by status

For the "All Puzzles" view of a Hunt, the built in Search functionality for Datatable searches on all text associated with the Puzzle object. This means that searching for "Stuck" returns all puzzles regardless of whether their status is "Stuck" or not, because "Stuck" is present in each of their dropdown menus.
I expect filtering the puzzle list by status will be a very common use case during the hunt (e.g., if we want to find all unsolved puzzles), so we should figure out a way to override the Search to only query based on the selected Status - or even add special filtering (checkboxes, if we'd want to see multiple at once, like solving/stuck/pending - aka unsolved?) for the status.

I'll work on this.
Relevant reading material:
https://stackoverflow.com/questions/27852497/jquery-datatables-search-within-input-and-select?utm_medium=organic&utm_source=google_rich_qa&utm_campaign=google_rich_qa
https://datatables.net/reference/api/column().search()

I fixed the status-search problem -- now it will only search based on the currently selected status. Using the Datatable built-in searching for "pending" or "solved" will correctly yield puzzles with matching statuses.
Is this sufficient? Or do we also want column-level search/filtering. It's doable but I worry it will clutter the UI.

I like the idea of column-level search/filtering. I think it will be useful for the Tags, Puzzle, Answer, and Status fields. You could put the column search/filter box at the bottom of the columns to make it less clutter-y in the UI.

Sounds good -- I actually prototyped exactly what you said yesterday and then changed my mind.


Feature/flow support

Purpose
To Enable flows to be enabled during the release we are not going to rely solely on the status on source control. It can very often be extracted and turned off. We would like more granular control than this by automatically activating all flows in the solutions that are being deployed, Also we give you the option to disable certain flows by using the following configuration
<flowstodeactivate>     <flowtodeactivate>Account Creation Trigger -> Terminate</flowtodeactivate>   </flowstodeactivate>
Approach
This enables all flows for the deployed solutions
TODOs

[x] Automated test coverage for new code
[x] Documentation updated (if required)
[x] Build and tests successful

Other areas:
Added a separate solution for the flows and also changed the uninstall method to be able to delete multiple in the future if the solution gets larger.

@markcunninghamuk I can see we've got the connection references config in this pull request - if we're going to merge just the deactivation of workflows separately then is it worth taking that configuration out to avoid confusion?

@markcunninghamuk I can see we've got the connection references config in this pull request - if we're going to merge just the deactivation of workflows separately then is it worth taking that configuration out to avoid confusion?

Thanks for the contribution @markcunninghamuk! A really welcomed feature. There are some minor comments just for readability in the future.
Could I ask you to also include the unmanaged solution you have in case we wish to make future changes.
😄

WIll do Tom in the next update (I will merge them all back into one single solution probably), I was wondering if we should use the "Release" section to hold the solutions.

Thanks for the contribution @markcunninghamuk! A really welcomed feature. There are some minor comments just for readability in the future.
Could I ask you to also include the unmanaged solution you have in case we wish to make future changes.
😄

WIll do Tom in the next update (I will merge them all back into one single solution probably), I was wondering if we should use the "Release" section to hold the solutions.

Thanks for the contribution @markcunninghamuk! A really welcomed feature. There are some minor comments just for readability in the future.
Could I ask you to also include the unmanaged solution you have in case we wish to make future changes.
😄

WIll do Tom in the next update (I will merge them all back into one single solution probably), I was wondering if we should use the "Release" section to hold the solutions.

Personally, I don't see why the release section is the place for the solution as they're only test resources. Merging them would be useful but not essential.

Thanks for the contribution @markcunninghamuk! A really welcomed feature. There are some minor comments just for readability in the future.
Could I ask you to also include the unmanaged solution you have in case we wish to make future changes.
😄

WIll do Tom in the next update (I will merge them all back into one single solution probably), I was wondering if we should use the "Release" section to hold the solutions.

Personally, I don't see why the release section is the place for the solution as they're only test resources. Merging them would be useful but not essential.

Just a reminder to use appropriate prefix to the squash commit i.e feat:

Just a reminder to use appropriate prefix to the squash commit i.e feat:


Feature: read package name from composer.json

It would be nice to read the package name from composer.json if it's omitted.
Instead of doing this:
$ keep-a-changelog tag --package zendframework/<package_name> x.x.x

You would do this:
$ keep-a-changelog tag x.x.x
$ keep-a-changelog release x.x.x

I've been somewhat reluctant to do this, as that makes it primarily useful to PHP developers. But... it's written in PHP, so that's not necessarily a bad assumption to make. Essentially, if no package is provided, it could look through a list of potential files in order to discover the value, with composer.json being the first we develop support for.
The main problem is that what is now an explicit argument becomes an option, which would mean different syntax, which is a BC break; we'd have to target a future 2.0 version.
Marking as "help wanted", if anybody wants to pick this up.

As of 2.0.0, you can now configure the package name using one of:

Local configuration file (<project root>/.keep-a-changelog.ini)
Autodiscovery using composer.json
Autodiscovery using package.json


Allow to customize "selected day label" in dialog

Is your feature request related to a problem? Please describe.
format attribute allow to customize the "selected date" format in field, but I can't find any way to customize the selected date in dialog:

Note: this screenshot is based on dateFns implementation
In that case, the default format is absolutely NOT understandable for this locale (french).
Describe the solution you'd like
Add a dedicated "format string" and/or a function to customize this label.

https://material-ui-pickers.dev/guides/formats

My bad, I missed this documentation.
Thanks.


perf: simplify join order to use multiple order keys instead of string.

Change-Id: I8c37e9296b2e4e0ea87f6a7e836d48988d161d37
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Question from  @tswast

Can we remove string_encoded now? Or is it still used elsewhere?
We still use string_encoded for concat. I can remove that next, but it will be a bit tricky, so leaving out of this pr.


Adds missing block of code to diplo ribbon.

The merge missed an important block of code related to the relationship tooltips. This corrects the issue.

hmm 🤔 I thought I moved all of this inside leadericon.lua with the summer patch (https://github.com/Azurency/CQUI_Community-Edition/commit/eb426d2668181c3dc181d567d57351e6073d46b9) , what exactly is not working ? I'll check tomorrow. I might have missed some things or yes deleted too much

tooltips disappeared with every call to Updateleaders(), which was called by almost every possible event. Result was that the tooltip was not there most of the time, and that was not the intended behavior nor the behavior previous to the Summer patch. With this update it works as it did before, and the tooltip is ON all the time.

I think I found why: apparently, setting the tooltip works on the INSTANCE but not on the LEADERICON class, which is what you call to inside Leadericon.lua... why? Firaxis.
So, inside the code, the extended relationship tooltip works fine as long as it called for the instance of the icon.

Sorry but, I tested it and I don't get what's not working ?
When UpdateLeaders() is called, even in the firetuner, I still have the extended relationship tooltips shown correctly on hovering the relationship icon of the leader. Is it that the number are not correct ?

Whenever I enter any diplo screen, and then go back out to main screen, tooltips are not there anymore until I use the other ribbon function to enforce it (CTRL Mouse Over any leader). It might be that I am testing with an ongoing game, but I doubt it. Can you try doing what I said? Enter a diplo screen, get out and check if the tooltips are still there.

They're still there when I enter a diplo screen and exit. I'm also in an ongoing game. I'll  try to start a new one and ask other people to test it too.

I cannot reproduce the issue either, tried with and without the changes in this branch, first without restarting the game, then after restarting the game. I am playing in windowed mode however, maybe that makes a difference.

I just tested with a new game, and the problem is there. So it's not the ongoing game, it's the code. Why it behaves differently for you, no idea. But the old code is faultproof, so I would just re-add it now for quicker release, and then we can try and find out why it behaves inconsistently.

Just to be clear, we are talking about the relationship tooltips that should appear when hovering over the attitude face at the bottom left of a leader icon (the list of diplo modifiers in red/green...

Tested once again, still not working.
Basically, when I load the game, the tooltips are not there. By default, with the new code, they just don't show up. Only after I CTRL-mouse over any leader icon, they start working because the code for that function uses the call to instance. As soon as an UpdateLeaders() is called, the tooltips disappear again.
Please merge this PR to make the tooltip work consistently until we find the cause of the inconsistency.

I was just able to reproduce this in a multiplayer game hosted by a friend.

After 16 test games i can confirm in 1 game i did reproduce this. Its not common but it still exists

I have the same issue in all my games.

Merging this change fixed it.

Multiple confirmations, yet it is not being merged... explain please?

@ricanuck - azurency is most likely really busy with work and family mate.

"explain please?" 🤔 It was a very busy week and I was hoping to have more time to try to figure out what happens with the leader icon but anyway I will merge this...

Thanks for explaining. I explained myself a lot at the beginning of this request. Specifically, I suggested that if we have a working version of anything, we should always prioritize merging it into the master, and only then, and if time allows it, search for a more "elegant" solution. The mod working 100% should always be well above any "perfect", technical solution; this was one good case to show just that.
That's all. No need to be offended.


fetchcontent instructions might require an update

I am attempting to follow the setup instructions that say to use lines such as the following:
FetchContent_Declare(
dlib
GIT_REPOSITORY https://github.com/davisking/dlib.git
GIT_TAG        v19.18
)
FetchContent_MakeAvailable(dlib)
however, when I attempt to compile the project, I receive a message stating that I should not put the dlib folder in the include path, which presumably cmake is doing automatically as a result of these commands. What can be done to avoid this?

ah, I was toying around with including visible headers, and it turns out the iostream header was a strategically placed error-catcher rather than an actual feature-providing header.
Perhaps that should be made more obvious.

How could it be made more obvious?


Added discovery and d2c ports as parameters.

Added d2c_port as a parameter. That change should solve the problem with multiple bebops connection (socket permission denied error). Also added bebop discovery port as a parameter.

Thanks @GduM for the patch. I will make my comments about the code inline.

How can someone use your changes to connect to multiple drones? How is it different from the solution proposed in #15?

The CI build is not green and the log is not helpful. Could you please rebase your changes on top  of  the latest changes in indigo-devel?

Thanks @mani-monaj for the time you spent on reviewing my pull-request.

Fortunately, the problem was solved with the new version of Bebop SDK (3.10). The solution presented in the topic you mentioned didn't help me with my problem since i didn't face the case with connecting multiple bebops using multiple network adapters. Instead i connected 2 bebops to AP using
this guide (https://github.com/Parrot-Developers/Samples/wiki/Convert-Bebop-to-client-instead-of-access-point) with a minor tweaking, MAC filtering and static ip assignment on router side. I faced a problem when Bebop SDK reserves a static port (for Bebop SDK v3.9 it was 43210) on sever side for communication with Bebop. When I tried to connect 2 Bebops to the same network and launch bebop_driver, the first Bebop's initialization worked fine but the second one failed with error (socket permission denied) since the socket was already reserved by the first Bebop. According to verbose of Bebop SDK v3.10, Parrot implemented a new mechanism which reserves the first available (probably random) socket instead of the static one (43210).

Fragment of bebop_driver's output:
https://gist.github.com/GduM/14231d44e89c978c7622226247245047

Solution presented in this pull-request worked for me until Bebop SDK 3.10 release and bebop_autonomy update. At the moment, everything works as intended with recent version of bebop_autonomy and 2 Bebop Drones (firmware version 3.3.0). This solution is out-dated now and this pull-request should be closed.

@GduM Thank you for your comprehensive answer to my questions. I will go ahead and close this PR. Would it be possible for you to write a step-by-step documentation on how to achieve a multiple drone setup? (Currently I do not have access to multiple Bebops). You can either email me the documentation and I will add it to the docs or you can contribute the documentation by sending a PR? Thank you!


So what will happen to the proxy setting in the setting page?

I was thinking about this but Chrome has this feature already... In the settings page "Open your computer's proxy settings" so why do we need one more proxy option?
further more will users have an option to use other servers than "google servers"? Will APIs be available to manage this from a plugin should someone want to offer a custom server?

Existing proxy configurations will remain supported. Users will be able to configure their own custom proxies as before.

So this is a redundant project proposition? The functionality already exists what does adding this one offer different than the existing one? Could Google not simply set up a proxy infra and have a button on the proxy page that says "use Google proxy"? This would make less work for Google.  (opt-in only) This feature would have a greater acceptance rate among the community.
I fail to see why a whole feature new feature is needed in the browser for something that's existing. If people need this service they already know how to use it. Would energy not be better spent making a few YouTube videos explaining why you would want to use a proxy in general and explaining the pros and cons?
unless I'm missing something please let me know but it sounds like you're looking for a reason to use your RFC for proxies over HTTP.  If this is the case why not add the feature on the page like everything else and allow users to opt-in?


Export both CJS and ESM sub-modules properly

Problem
problem statement
Closes: #37
Solution
Updated packaging scripts to properly export for use by both ESM and CJS projects.

Closed as fixed by #36


Added support for pagination in get_transactions

This PR allows transactions to be be automatically filtered based on their date on Monzo's server.

Nice. In terms of testing, I guess we would need to mock responses from the server? I find it strange that the API provides limit, but not offset. How are we to go about pagination? I guess use the last transaction id as before for the next page?

Nice. In terms of testing, I guess we would need to mock responses from the server?

I'm beginning to think this is going to be needed soon as well. The current tests don't sit that well with me at the minute and I'm planning on giving them some love.

How are we to go about pagination? I guess use the last transaction id as before for the next page?

Yup, that seems to be the way to go about it. Although now you mention it, I should probably have a look at attaching an easy way to call the next page to the returned list of transactions.

Great stuff.
(I just realised that transactions are returned from oldest to newest, so where I said before above it should actually be since)

The function to get the next page is now included in the response and can be evaluated as
nextpage = page['next_page']()

This is a bit ugly, I've done a little work on some subclasses of dict to improve the functionality of various responses so I'll probably make something like a TransactionList.nextpage() class and method in a different PR to hide this.

Neat solution  - clever use of partial. Thanks also for the usage example - we should start collecting these for the docs (though let's wait for an update on #4 before starting).

@Solije @samdobson great work on this. I'm looking into updating a bunch of the pagination and tests in general too :)

@Solije I'm giving myself homework this weekend to add tests to this.


Enable ebpf build for ppc64le

Description

Related issues/PRs
Requires toolchain update from https://github.com/projectcalico/go-build/pull/564.
Address https://github.com/projectcalico/calico/issues/8744.
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Will move this to a fork.


making it more generic

Hi, this is really great! I wanted to use your project as a base for normal calibre server with built in Kindle Previewer(in wine).
How could make it more generic? Similar to this one: https://hub.docker.com/r/linuxserver/calibre
With only difference, that it has Kindle Previewer in wine.

Hello,
Glad to hear it's useful for you!
Can you please elaborate your use case more? I haven't used the mentioned image, so no idea what are the limitations of my image compared to it.
Also, note that Kindle previewer will only work on a 64 bit system.

Thank you for your response:)
I have the following use case. I am running calibre server in docker container. Here is how my current yml looks like:
version: '3.3'
services:
    linuxserver:
        container_name: calibre
        ports:
            - '8080:8080'
            - '8081:8081'
        environment:
            - PUID=1026
            - PGID=100
            - TZ=Europe/Berlin
            - CUSTOM_USER=something
            - PASSWORD=something
        volumes:
            - '/volume1/calibre/data:/config'
        restart: always

        image: ghcr.io/linuxserver/calibre

I typically use calibre on my pc to convert epub to kfx, but I would like to run calibre on my home server and access it through web ui(it looks exactly the same as desktop app) and for that I need Kindle previewer in docker container. The problem is that the image that I am using is different from what you are using. It would be great to have this ghcr.io/linuxserver/calibre extended by Kindle Previewer in Wine.

I think my question is similar to the original poster, can this be used as a drop-in replacement for the 'regular' docker calibre? I also use ghcr.io/linuxserver/calibre image, similar to above. As in, can I still access calibre webui, etc. with your image?

This enhancement was requested from the LinuxServer team, but they don't have a desire to add Wine to their image and rejected it.  They suggested customizing their image instead, as recommended above.  Rebasing this effort on top of their image would be fantastic as it would allow for automation around the KFX plugin, such as offering up automatically generated versions of news sites from the web UI that can be downloaded onto a Kindle from the experimental browser.


Space being added after defaulted function parameters.

Let's consider the following example:
let f = (x = 0 , a = 1) => x === 0 ? a : f(x - 1, a * x)

There should be no space after x = 0 right; there should be no space before a comma? ESLint configured with Standard is also marking this as an error.
But I didn't add that space, it keeps being added by standard-formatter, but only if I specify a default value succeeded by a comma. No space is added after the first x in the following example, or indeed after either example's a = 0:
let f = (x, a = 1) => x === 0 ? a : f(x - 1, a * x)

Is this intended behavior?

Thanks for reporting.  This Atom package relies on the standard-format npm package to handle the transform, so you probably want to open the issue on that repo so it gets the proper attention: https://github.com/maxogden/standard-format

I didn't realize that, oops. I'll go report it there.


Closing file after reading

Adds a context to close the model file after reading it

This is actually not necessary, as CPython will close the file handle as soon as the reference count becomes zero.


golang.org\x\crypto\ssh\terminal

golang.org/x/crypto/ssh/terminal
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:44: undefined: windows.ENABLE_ECHO_INPUT
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:44: undefined: windows.ENABLE_PROCESSED_INPUT
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:44: undefined: windows.ENABLE_LINE_INPUT
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:44: undefined: windows.ENABLE_PROCESSED_OUTPUT
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:45: undefined: windows.SetConsoleMode
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:64: undefined: windows.SetConsoleMode
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:69: undefined: windows.ConsoleScreenBufferInfo
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:70: undefined: windows.GetConsoleScreenBufferInfo
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:86: undefined: windows.ENABLE_ECHO_INPUT
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:87: undefined: windows.ENABLE_PROCESSED_INPUT
..\src\golang.org\x\crypto\ssh\terminal\util_windows.go:87: too many errors

Is this a bug report for godoc.org? What is the problem?

This error was received the first time when attempting to install a 3rd party application using go get. In seeing where the problem exists I attempted to install it directly with the same error report being returned. I checked the file in question and it confirmed that the constants are not recognized

I see. This issue tracker is for tracking bugs related to the github.com/golang/gddo project, but your problem is with installing the golang.org/x/crypto/ssh/terminal package via go get. I'll close it, because this isn't the right place for it.
Please see https://golang.org/wiki/Questions for a better place to ask about your situation.


Css file

Hello,
I tried to insert a css file to my mail instead of writing all the css at the end of the cshtml page.
The name of the css is Mail.css and it's in the folder Content/Mail.css
i tried using

@Styles.Render("~/Content/css").
And also, in the css file, I am using a small image to display. It is not displayed in the email.
background: url("../Images/image.png") no-repeat;
Can you help me in some way ?

Was anoyone lucky with solving this problem?

You cannot add external style sheets to an email, all css has to be inside the page.

Ou... And did you find solution how to transform stylesheet reference such ass: @Styles.Render("~/Content/css") to transforming it to include css styles directly into html elements inside email?

http://lmgtfy.com/?q=+inline+css+online


dopamine: Fix url, Fix checkver, and Fix autoupdate

Closes #9838

[x] I have read the Contributing Guide.

/verify


not fixing

i downloaded last brdc file, i use ANT500, i wait 50 min but gps not fixed, please help me
./gps-sdr-sim -b 8 -e brdc1700.19n -l 37.808880,-122.410167,216 -o StaticLocation.bin
hackrf_transfer -f<PHONE_NUMBER> -s 2600000 -a 1 -x 10 -R -t StaticLocation.bin
$ hackrf_info
hackrf_info version: git-509c8f4c91
libhackrf version: git-509c8f4c91 (0.5)
Found HackRF
Index: 0
Serial number:<PHONE_NUMBER>00000087c867dc2b98885f

This might solve your problem: https://github.com/osqzss/gps-sdr-sim/issues/198

Hello, I posted #240 that might help you.


WIP: Patient Record - start new encounter

#76
#97

@mariano-dagostino
Please review. Majority of files are simple a to span change, so it's not as big as it looks.


Can't debug plain text data within eyaml files

Hi,
We keep all of our Hiera data in *.eyaml files. Most keys are encrypted, but some are not. I would like to use the hiera command line tool to debug plain text values inside our *.eyaml files.
hiera.yaml:
---
:backends:
  - eyaml

:hierarchy:
  - common

:eyaml:
  :datadir: /etc/puppetlabs/code/hiera/data # for use with Puppet v4 Puppet masters
  :gpg_gnupghome: /home/puppet/.gnupg

common.eyaml:
---
dhcpd::ensure:       'running'

When I want to test this on the command line, I get this error:
$ hiera -d -c /etc/puppetlabs/code/hiera.yaml 'dhcpd::ensure'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/hiera/config.rb:78:in `rescue in block in load_backends': Cannot load backend eyaml: cannot load such file -- hiera/backend/eyaml_backend (RuntimeError)
        from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/hiera/config.rb:75:in `block in load_backends'
        from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/hiera/config.rb:74:in `each'
        from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/hiera/config.rb:74:in `load_backends'
        from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/hiera.rb:51:in `initialize'
        from /opt/puppetlabs/bin/hiera:232:in `new'
        from /opt/puppetlabs/bin/hiera:232:in `<main>'

As a workaround, I know I could rename all the files to *.yaml and add a yaml backend, but I'm trying to avoid that. I just don't know if I'm trying to do something that is impossible. Any ideas?

Is there any movement on this? I'm getting the same error in Puppet 4


Fixing namespace land apiVersion the default rbac template

While trying to follow the documentation and install the chart/pod-reaper I got the errors below.
❯ helm install --dry-run pod-reaper --namespace=default chart/pod-reaper
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(ClusterRoleBinding): unknown field "namespace" in io.k8s.api.rbac.v1.ClusterRoleBinding
❯ helm install --dry-run pod-reaper --namespace=default chart/pod-reaper
Error: unable to build kubernetes objects from release manifest: [unable to recognize "": no matches for kind "ClusterRole" in version "rbac.authorization.k8s.io/v1beta1", unable to recognize "": no matches for kind "Cl
usterRoleBinding" in version "rbac.authorization.k8s.io/v1beta1"]
For the first I change the namespace location in the template and I changed the apiVersion in the rbac template.
after those changes I was bale to install the chart w

Closing since it does not work in minikube, but it works in a regular v1.20.4 kubernetes server


Error writing file to shared private folder

Tried a few times without luck to add a relatively small file (11.7 MB) to a shared private folder. Got several Keybase warnings about the write operation before getting a Mac OS error code -36 (IoErr). Had to relaunch Finder and restart Keybase to recover.
Adding a much smaller file (30 bytes) to the same private folder worked fine.
my log id: a5d8f42594fd4ddfe76c781c

@javbotero: thanks for the report. Believe it or not your client is having trouble uploading 8MB to our server within the file system timeout allowed by your OS (19 seconds).  We are actively working on fixes that makes writes not depend on your network connection speed; those should be out next month.  Sorry for the inconvenience.

Version 1.0.20 has architectural changes that should greatly improve the large write experience.  If you're still seeing problems, please open a new issue.

@strib Awesome. Thanks so much for letting me know and for the great work.


logging: Add name and PID fields

Add a name= and pid= field to the log entries for consistency with the
runtime.
Fixes #148.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

hmm, this doesn't look like the kill.go failure does it? (from the 16.04.logs)
••••Running command '/usr/local/bin/cc-runtime [cc-runtime --log /tmp/bundle689249077/log run --bundle /tmp/bundle689249077 --pid-file /tmp/bundle689249077/pid oLlNn4lAgdkB2cpHYP3r]'
Killing process timeout reached '15' seconds
Running command '/usr/local/bin/cc-runtime [cc-runtime list --quiet]'
[cc-runtime list --quiet]
Timeout: 15 seconds
Exit Code: 0
Stdout: oLlNn4lAgdkB2cpHYP3r

Stderr:
Running command '/usr/local/bin/cc-runtime [cc-runtime delete --force oLlNn4lAgdkB2cpHYP3r]'
command failed error 'exit status 1'
[cc-runtime delete --force oLlNn4lAgdkB2cpHYP3r]
Timeout: 15 seconds
Exit Code: 1
Stdout:
Stderr: Can not move from stopped to stopped

------------------------------
• Failure [15.853 seconds]
run
/home/jenkins/go/src/github.com/clearcontainers/tests/functional/run_test.go:103
  container
  /home/jenkins/go/src/github.com/clearcontainers/tests/vendor/github.com/onsi/ginkgo/extensions/table/table.go:96
    without '--console' option [It]
    /home/jenkins/go/src/github.com/clearcontainers/tests/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:46

    Expected
        <int>: -1
    to equal
        <int>: 0

    /home/jenkins/go/src/github.com/clearcontainers/tests/functional/run_test.go:94
------------------------------
••••••••

Summarizing 1 Failure:

[Fail] run container [It] without '--console' option
/home/jenkins/go/src/github.com/clearcontainers/tests/functional/run_test.go:94

Ran 27 of 27 Specs in 82.570 seconds
FAIL! -- 26 Passed | 1 Failed | 0 Pending | 0 Skipped --- FAIL: TestFunctional (82.57s)
FAIL


Sending signal when skip-jvm-stack could cause target process to exit

#2 introduced critical bug that jbm sends SIGPROF to target JVM process even when --skip-jvm-stack is passed (i.e. async-profiler doesn't run so no signal handler is installed), ended up with causing target JVM process to exit (default SIGPROF action)

oops, thx for the follow-up.


View -> Lock All Wallets isn't always greyed out when all wallets locked.

A fix for issue #506 where the 'Lock All Wallets' menu option was never greyed out was made and the fix looks like it made it into 1.6.4. I've gone on to test this in 1.6.4 and Sparrow now seems to grey out the menu option only some of the time.
If I go to each wallet individually and select 'View -> Lock Wallet' then on locking the last wallet the option to 'Lock All Wallets' does indeed get greyed out.
However, having one or more wallets unlocked, if I select the 'Lock All Wallets' option then all wallets do indeed get locked. But the 'Lock All Wallets' menu item isn't always set to greyed out. I've had a play with this and one way I've found to consistently reproduce this error is:

Have two wallets open and both unlocked
Select the first wallet tab and click 'Lock Wallet'
Select the second wallet tab and click 'Lock Wallet'
Keeping the second wallet tab selected and click 'Unlock'
Select the first wallet tab
Click 'View -> Lock All Wallets'
See that all wallets are locked but the 'Lock All Wallets' option is not greyed out

A second way which appears repeatable:

Have two wallets open and both unlocked
Select 'View - Lock All Wallets'
Select the second wallet tab and click 'Unlock'
Select the first wallet tab
Click 'View -> Lock All Wallets'
See that all wallets are locked but the 'Lock All Wallets' option is not greyed out

Thanks for the bug report, fixed in 33a61e3.


Unable to register OVA template when properties are prepend with "ovf:" in the ovf file

When trying to register an OVA format template in VMware, template installation is failing.
The reason for that is a couple of properties inside the ovf file are prepended with "ovf:" Eg. Property, File, Item, Disk, etc.
The corresponding error in the cloud.log of SSVM is
2021-09-08 02:13:48,611 ERROR [storage.template.DownloadManagerImpl] (pool-1-thread-1:null) Template process exception
com.cloud.exception.InternalErrorException: getTemplateVirtualSize: Unable to parse OVF XML document /mnt/SecStorage/54efe74a-bb32-3f6e-9d91-22cfcb27a30b/template/tmpl/2/202 to get the virtual disk fe146945-66c1-3dd7-9e75-e508bd94b098.ova size due to java.lang.NullPointerException
at com.cloud.storage.template.OVAProcessor.getTemplateVirtualSize(OVAProcessor.java:159)
at com.cloud.storage.template.OVAProcessor.process(OVAProcessor.java:104)
ISSUE TYPE

Bug Report

COMPONENT NAME

Template

CLOUDSTACK VERSION

4.13, main

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

1. Register a OVA template having an OVF file which has some  properties prepended with "ovf:" Eg. Property, File, Item, Disk

EXPECTED RESULTS

Template installation should be successful and ready

ACTUAL RESULTS

Template installation is failing. We can check it under the zones section of the template.

@nvazquez  LGTM :+1:


Tell me how to get script from P2SH Hash.

Hi. I have a question.
How do I get the bitcoin script from the variable pubParams below?
Use P2SH.
var pubParams = PayToScriptHashTemplate.Instance
    .ExtractScriptPubKeyParameters(new Script(BTCAddress.ScriptPubKey.ToString()));
// pubParams is "eebe246b4ec0075a8dc145de96f6fd799151dc79"

I want to get OP_CODE from this hash value.

Please read https://programmingblockchain.gitbooks.io/programmingblockchain/content/
Your question show too much misunderstanding about what you want to achieve.


Fix font sizes, line heights, colors, backgroundColors

It's very inconsistent

[ ] Drawer in Dark mode

[x] Pre Hukamnama Text on mobile

[ ] Hover state for nitnem baani

[ ] line-height on author/raag

[ ] selection of translation (Solving #81 via HammerJS config can help)

[x] Search Text field's padding, and search results not in center

d85dc42 made some relevant changes


Add maxDepth(1) to walkTopDown()

Groovy version uses eachDir which visits only child directories. Kotlin's walkTopDown() visits an entire tree unless max depth is specified.

Thanks for merging!
One more thing that I noted after submitting this PR (sorry for confusion):

walkTopDown() includes the main dir too (i.e. "subprojects")
it's not a serious problem because there's no subprojects.gradle.kts there so we don't get a :subprojects subproject; however, it's still inconsistent with Groovy's eachDir

I, after all, switched to Java's File.listFiles():
https://github.com/tlinkowski/tlinkowski-superpom/blob/47c239b2e89ad3ff6e3bfde3745a3403f6205ffb/src/main/kotlin/pl/tlinkowski/superpom/TLinkowskiSettingsPlugin.kt#L76


More edits to Burgers

I added a bit more to Burgers about characteristics in particular, and the spreading of the rarefaction fan.
I still like having this notebook first, also because it shows the converging characteristics and shock formation right up front while in Traffic_flow it starts with an animation of the shock wave moving and a plot that shows vehicle paths, but characteristics aren't shown until later.
I also added in links to the github pages for the .py files, is this ok?

It looks good to me.

Looks good to me too.  Thanks.


HHH-11614 - Wrong result for @Lob column with postgresql DB since 5.2.9

https://hibernate.atlassian.net/browse/HHH-11614

@vladmihalcea I talked also with @gbadner about this solution and we agree the best solution is just to revert the changes introduced by https://github.com/hibernate/hibernate-orm/pull/1790 and to add, in the migration guide and the release announcement, an explanation of the necessity to update PostgreSQL db records corresponding to @Lob String fields before upgrading from version >= 5.2.9 to 5.2.11

Closing because the fix for HHH-11477 will be reverted instead.

Superseded by https://github.com/hibernate/hibernate-orm/pull/2001


feat:Editorconfig

First draft of editorconfig. Most of the items are configured as suggestion/silent.

Merging now.


Convert all icons to XPM

In order to remove reliance on the Qt framework I'm converting all the icons to .xpm format, that way the Qt resource file is unnecessary.

See commit 5c135a35ab1c0496b4e43bcaf0748b2eef793a9a


Add autogen to avoid code analysis

Fixes #174
Modified the build script to add // <auto-generated/> to the top of the .pp files to avoid problems with Roslyn analysers in consuming projects.
Using the build script avoids having to update all the .cs files and ensures future files are covered as well.
I removed the existing // <auto-generated/> from LogProvider.cs for consistency; I think it used to be that this file could be included separately (?) but I no longer believe that would work so this should not be a problem?
Also bumped the version to 5.0.3.

Looks good. Thx for PR.

@damianh Hi, would you be able to push this to Nuget when convenient?
Thanks,
Frans


[RDY] Add support for proper deletion, raising KeyError where appropriate

Fixes https://github.com/neovim/pynvim/issues/402
TODO:

[x] rebase after https://github.com/neovim/pynvim/pull/408
[ ] squash, rebase after https://github.com/neovim/pynvim/pull/412

Thanks for the approvals, please review https://github.com/neovim/pynvim/pull/412 also.
I'll then rebase and merge this one here after.


Adds the ability to get a Recognizer from a Manger using the base name or and the value from event.type

If accepted, this would resolve #745

@arschmitz this represents a departure in intentional behavior.  I like it, but it should be at a min a minor version bump and a warning.

This needs cleaned up, changes not related to the feature at hand need to be removed or explained.
This is definitely a candidate feature for minor release.

@RyanMullins do you plan on coming back to this?

Unfortunately I'm unable to see a point in time when I will be able to come back to this.


Getting attribute error trying to use with Stable Diffusion

I followed the instructions to use ImageReward with Stable Diffusion's webui, but I get the following error:
AttributeError: module 'ImageReward' has no attribute 'load'

Same issue for me and the issue persist on a fresh install of Automatic1111 too

Thank both of you so much for the issues! Let's resolve it together 😀
I'm sorry I don't have enough information to reproduce this error with just this line of error AttributeError: module 'ImageReward' has no attribute 'load'
Could any of you provide more information, for example, the complete error message in terminal?

Thank both of you so much for the issues! Let's resolve it together 😀 I'm sorry I don't have enough information to reproduce this error with just this line of error AttributeError: module 'ImageReward' has no attribute 'load' Could any of you provide more information, for example, the complete error message in terminal?

Of course !
Error completing request
Arguments: ('task(b99ytqs0h3thvof)', 'RAW, photography, masterpiece, sfw, 1cat mainecoon, (detailed fur, realistic grey fur), laying under a cherry tree, cherry blossom, detailed background ', ' easynegative, verybadimagenegative_v1.3, deformityv6, animal ears, nudity, nude, naked, anthro, human', [], 40, 16, False, False, 4, 1, 7, -1.0, -1.0, 0, 0, 0, False, 904, 512, False, 0.7, 2, 'Latent', 0, 0, 0, [], 2, True, False, 1, False, False, False, 1.1, 1.5, 100, 0.7, False, False, True, False, False, 0, 'Gustavosta/MagicPrompt-Stable-Diffusion', '', <controlnet.py.UiControlNetUnit object at 0x00000180BE80B8B0>, False, '', '', '', '', '', '', '', '', '', '', '', '', '', [], 0.5, 'All Frames', 'Loop', False, '0', False, False, 'positive', 'comma', 0, False, False, '', False, False, 100.0, True, '', '', 1.0, 0.1, '', 3000.0, True, 1, '', [], 0, '', [], 0, '', [], True, False, False, False, 0, '', 5, 24, 12.5, 1000, '', 'DDIM', 0, 64, 64, '', 64, 7.5, 0.42, 'DDIM', 64, 64, 1, 0, 92, True, True, True, False, False, False, 'midas_v21_small', None, False, 50) {}
Traceback (most recent call last):
  File "I:\stable-diffusion-webui\scripts\image_reward.py", line 56, in run
    shared.image_reward_model  # if loaded, do nothing
AttributeError: module 'modules.shared' has no attribute 'image_reward_model'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "I:\stable-diffusion-webui\modules\call_queue.py", line 57, in f
    res = list(func(*args, **kwargs))
  File "I:\stable-diffusion-webui\modules\call_queue.py", line 37, in f
    res = func(*args, **kwargs)
  File "I:\stable-diffusion-webui\modules\txt2img.py", line 53, in txt2img
    processed = modules.scripts.scripts_txt2img.run(p, *args)
  File "I:\stable-diffusion-webui\modules\scripts.py", line 408, in run
    processed = script.run(p, *script_args)
  File "I:\stable-diffusion-webui\scripts\image_reward.py", line 63, in run
    shared.image_reward_model = reward.load(
AttributeError: module 'ImageReward' has no attribute 'load'

Thank both of you so much for the issues! Let's resolve it together 😀 I'm sorry I don't have enough information to reproduce this error with just this line of error AttributeError: module 'ImageReward' has no attribute 'load' Could any of you provide more information, for example, the complete error message in terminal?

Of course !
Error completing request
Arguments: ('task(b99ytqs0h3thvof)', 'RAW, photography, masterpiece, sfw, 1cat mainecoon, (detailed fur, realistic grey fur), laying under a cherry tree, cherry blossom, detailed background ', ' easynegative, verybadimagenegative_v1.3, deformityv6, animal ears, nudity, nude, naked, anthro, human', [], 40, 16, False, False, 4, 1, 7, -1.0, -1.0, 0, 0, 0, False, 904, 512, False, 0.7, 2, 'Latent', 0, 0, 0, [], 2, True, False, 1, False, False, False, 1.1, 1.5, 100, 0.7, False, False, True, False, False, 0, 'Gustavosta/MagicPrompt-Stable-Diffusion', '', <controlnet.py.UiControlNetUnit object at 0x00000180BE80B8B0>, False, '', '', '', '', '', '', '', '', '', '', '', '', '', [], 0.5, 'All Frames', 'Loop', False, '0', False, False, 'positive', 'comma', 0, False, False, '', False, False, 100.0, True, '', '', 1.0, 0.1, '', 3000.0, True, 1, '', [], 0, '', [], 0, '', [], True, False, False, False, 0, '', 5, 24, 12.5, 1000, '', 'DDIM', 0, 64, 64, '', 64, 7.5, 0.42, 'DDIM', 64, 64, 1, 0, 92, True, True, True, False, False, False, 'midas_v21_small', None, False, 50) {}
Traceback (most recent call last):
  File "I:\stable-diffusion-webui\scripts\image_reward.py", line 56, in run
    shared.image_reward_model  # if loaded, do nothing
AttributeError: module 'modules.shared' has no attribute 'image_reward_model'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "I:\stable-diffusion-webui\modules\call_queue.py", line 57, in f
    res = list(func(*args, **kwargs))
  File "I:\stable-diffusion-webui\modules\call_queue.py", line 37, in f
    res = func(*args, **kwargs)
  File "I:\stable-diffusion-webui\modules\txt2img.py", line 53, in txt2img
    processed = modules.scripts.scripts_txt2img.run(p, *args)
  File "I:\stable-diffusion-webui\modules\scripts.py", line 408, in run
    processed = script.run(p, *script_args)
  File "I:\stable-diffusion-webui\scripts\image_reward.py", line 63, in run
    shared.image_reward_model = reward.load(
AttributeError: module 'ImageReward' has no attribute 'load'

It seems that you are experiencing the same problem as this issue.
You could try the possible solution described below:

A possible workaround for you (and other Windows users experiencing similar problems) is that: if you only wish to use ImageReward in SD Web UI, then you can choose to install the ImageReward into the models directory of SD Web UI. Specifically, in your image-reward.py, you need to replace the
shared.image_reward_model = reward.load(
    "ImageReward-v1.0",
) # using shared to make the model object global among modules

with
shared.image_reward_model = reward.load(
    "ImageReward-v1.0",
    download_root=Path.cwd().parent / "models" / "ImageReward",
) # using shared to make the model object global among modules

If you wish to use ImageReward elsewhere than in the SD Web UI, feel free to inquire further.

We're sorry that since the user who raised the issue above did not provide feedback on whether the solution we had suggestted worked, we have not yet updated the repository with the corresponding improvements.
If any of you can confirm the validity of the solution, we'd appreciate it!

Thanks for the support to get started :)
I made the modification of the script but the problem remains the same with exactly the same error.
I can only consider a bad installation since the script doesn't seem to find the files it needs. However my ImageReward folder is located in the same folder as stable-diffusion.
Could the fact that the whole thing is installed on disk I: instead of C: be the cause?

Thanks for the support to get started :)
I made the modification of the script but the problem remains the same with exactly the same error.
I can only consider a bad installation since the script doesn't seem to find the files it needs. However my ImageReward folder is located in the same folder as stable-diffusion.
Could the fact that the whole thing is installed on disk I: instead of C: be the cause?

Sorry for my earlier lapse in judgment, your errors are not the same. I have experimented with Windows 10 and reproduced your error.
If you started SD Web UI with the webui-user.bat or webui.bat script, your error is probably caused by failing to install the "image-reward" pip package in venv's Python environment.
To resolve this error, you need to make sure that "image-reward" is installed in venv Python environment. To do this, try:

In the stable-diffusion-webui\venv\Scripts directory, run activate or activate.bat (if you are using cmd) or activate.ps1 (if you are using PowerShell) from . If you see the prompt (venv) appear at the far left of the command line, you have successfully activated venv created by the SD Web UI.
Run pip show image-reward to check if "image-reward" is exactly not installed in your venv.
Then run pip install image-reward to install "image-reward" in your venv.

Not bad ! There is better.
I had to change the script back to default.  There is better.
I had to change the script back to default.  I'm sorry that I failed to reproduce it in my own environment.
To resolve this error, could you kindly provide the image generation settings when you encountered this error? For example, a screenshot of the entire SD Web UI interface would help.
In addition, you might want to try the following modification in the image_reward.py file:
Replace the existing code:
            img.info["parameters"] += f"\n ImageReward Score: {score:.4f}"

with the following:
            if img.info.get("parameters") is None:
                img.info["parameters"] = f"ImageReward Score: {score:.4f}"
            else:
                img.info["parameters"] += f"\n ImageReward Score: {score:.4f}"

This modification tries to ensure that the ImageReward Score information is properly added to the img.info["parameters"].
Please let us know if this resolves the issue.

I have a similar error, tried the fixes here, imagereward is installed and showing when running pip show, but still get this error...
"image-reward" package is successfully installed! Error loading script: image_reward.py Traceback (most recent call last):   File "C:\SD_NewInstall\stable-diffusion-webui\scripts\image_reward.py", line 21, in <module>     import ImageReward as reward ModuleNotFoundError: No module named 'ImageReward'
Tried various fixes nothing seems to work.
My SD is installed to C; but my image directories are in D; could this cause the issue?

I have a similar error, tried the fixes here, imagereward is installed and showing when running pip show, but still get this error...
"image-reward" package is successfully installed! Error loading script: image_reward.py Traceback (most recent call last): File "C:\SD_NewInstall\stable-diffusion-webui\scripts\image_reward.py", line 21, in <module> import ImageReward as reward ModuleNotFoundError: No module named 'ImageReward'
Tried various fixes nothing seems to work. My SD is installed to C; but my image directories are in D; could this cause the issue?

Thank you so much for the issue! Let's resolve it together 😀
Usually, I guess that the path of image directory makes little difference. There might be other problems.
Could you please provide the full error message printed in the terminal?

Thanks for the support to get started :)
I made the modification of the script but the problem remains the same with exactly the same error.
I can only consider a bad installation since the script doesn't seem to find the files it needs. However my ImageReward folder is located in the same folder as stable-diffusion.
Could the fact that the whole thing is installed on disk I: instead of C: be the cause?

Sorry for my earlier lapse in judgment, your errors are not the same. I have experimented with Windows 10 and reproduced your error.
If you started SD Web UI with the webui-user.bat or webui.bat script, your error is probably caused by failing to install the "image-reward" pip package in venv's Python environment.
To resolve this error, you need to make sure that "image-reward" is installed in venv Python environment. To do this, try:

In the stable-diffusion-webui\venv\Scripts directory, run activate or activate.bat (if you are using cmd) or activate.ps1 (if you are using PowerShell) from . If you see the prompt (venv) appear at the far left of the command line, you have successfully activated venv created by the SD Web UI.
Run pip show image-reward to check if "image-reward" is exactly not installed in your venv.
Then run pip install image-reward to install "image-reward" in your venv.

Hi :) Please consider the following, add this instructions to https://github.com/THUDM/ImageReward#integration-into-stable-diffusion-web-ui or directly from image_reward.py:
import pip
pip.main(['install', 'image-reward'])

Thanks for the support to get started :)
I made the modification of the script but the problem remains the same with exactly the same error.
I can only consider a bad installation since the script doesn't seem to find the files it needs. However my ImageReward folder is located in the same folder as stable-diffusion.
Could the fact that the whole thing is installed on disk I: instead of C: be the cause?

Sorry for my earlier lapse in judgment, your errors are not the same. I have experimented with Windows 10 and reproduced your error.
If you started SD Web UI with the webui-user.bat or webui.bat script, your error is probably caused by failing to install the "image-reward" pip package in venv's Python environment.
To resolve this error, you need to make sure that "image-reward" is installed in venv Python environment. To do this, try:

In the stable-diffusion-webui\venv\Scripts directory, run activate or activate.bat (if you are using cmd) or activate.ps1 (if you are using PowerShell) from . If you see the prompt (venv) appear at the far left of the command line, you have successfully activated venv created by the SD Web UI.
Run pip show image-reward to check if "image-reward" is exactly not installed in your venv.
Then run pip install image-reward to install "image-reward" in your venv.

Hi :) Please consider the following, add this instructions to https://github.com/THUDM/ImageReward#integration-into-stable-diffusion-web-ui or directly from image_reward.py:
import pip
pip.main(['install', 'image-reward'])

Thank you very much for the suggestion! We have actually added similar code to image_reward.py as follows:
https://github.com/THUDM/ImageReward/blob/9e96d39662876d579f9ed0982a1cc6b422e29691/sdwebui/image_reward.py#L20-L31


Initial implementation

This initial implementation, I believe, provides the functionality that was requested from previous discussions regarding a common way to implement global defaults for linting python projects. I did try using in code calls to both libraries, which worked, but ended up overly complex when compared to subprocess.Popen calls.
The README.md provides usage instructions, but in short, it provides default configurations for pylint and flake8 which can be completely overridden by using local .pylintrc and .flake8 files.
The values and contents of those default files are up for discussion.
Once the defaults are agreed and this PR is complete I will push this to PyPi. I would also like to add an optional capability to also run mypy which would slot in nicely to projects which support static type declarations.

I am not testing that the libraries are returning specific codes or messages (i.e. are they doing their jobs) I intentionally avoided that. I am just testing what my function does with the fails or successes that are returned (at this point x2 booleans).
It was just an easier to pass them a fixture file (good.py or bad.py) to infer failure or success for testing rather than getting into mock spaghetti for a few tests.

(currently updating elife-libraries--ci after the merge of the token configuration)

(done)


Change git repos paths

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Before all tasks are stored in data/{tid}/*
Now they are stored in data/tasks/{tid}/* and data/data/{tid}/*.
But if I create a task with a repos, all repos data are still saved in data/{tid}.
Probably we should save them somewhere else to escape confused repository structure.

@azhavoro , need to fix for beta

@azhavoro , please confirm that it was resolved.


Hard to see markdown tags.

When using markdown and set bold the user see no difference.
Also the code block have only small changes so it is hard to see for the user if it is a code example.

I updated bold tag. I'll have a look at code block later this weekend.
Old

New

rolled out


[OverlapBlocker] Fixes rem_stop_words attribute in block_candset() to run stop word pruning conditionally

Proposed solution which fixes #46. Some testing on my machine shows that block_candset() now uses the rem_stop_words attribute as promised, but more testing recommended. Feel free to kill this pull request and fix as needed, just thought I would share solution our group came up with and used, if only to highlight main source of problem.

Sample test:
When rem_stop_words is false (with overlap size = 1), we see that the names "ID: The Identity Game" and "Great Composers, The" matched.

When true, we don't see them matched (not in rest of table either):

Thanks. This is really useful.
But in order to pull this, we need to add more tests to this. If you are interested you can add them.
Else, I will add them later and pull it.

Added in release 0.1.0


Separate shading into a separate project

Include all dependencies as part of the shaded jar and have 0 dependencies on other projects.

Could you give a bit of context on when you expect this to be used and not used? It doesn't seem very safe in general usage so I assume it's for something very specific. If it is for something specific, perhaps changing the artifact id (e.g., bigtable-hbase-mvm)

The context here is for any place where we'd want to use a shaded artifact.  This should work for bdutil or mvm.
There are 2 objectives here:

create a jar with all of the dependencies bundled
create a pom with no other dependencies.

Running:
$ mvn clean package && jar tf bigtable-hbase-shaded/target/bigtable-hbase-shaded-0.1.10-SNAPSHOT.jar
leads me to believe this will have classloader / resource issues.
How are different HBase versions handled handled?

RE: How are different HBase versions handled handled?
I think we should only support a single version of HBase for the shaded jar.

RE: leads me to believe this will have classloader / resource issues.
Can you clarify please?

OK - to start:
Bare references to org.slf4j, org.codehaus, jcodings, and org.apache.log4j mean that anyone trying to use this shaded artifact will be required to use these versions, but we won't actually be telling them that those are the versions in use so instead they'll just start getting weird NoSuchMethod errors that they can't debug.
The generated HBase protos were generated with proto 2.5. gRPC requires proto 3. There are class incompatibilities between the two. In the present versions, we shade proto 3, include grpc and don't include HBase classes and as a result HBase classes properly load proto 2.5.

I see.  Good points.  I'll re-add the bigtable-hbase-1.x shaded jars.
I still would like to support MVM and dataflow.  Something like an uber shaded jar/pom seems useful in those cases.  It would have to be for cases where hbase access wasn't a factor.  I'd still need to figure out what to do with slf3j, codehause, jconings and log4j; one possibility is package renaming.  This would be similar to hbase's shading rules: http://central.maven.org/maven2/org/apache/hbase/hbase-shaded/<IP_ADDRESS>/hbase-shaded-<IP_ADDRESS>.pom

I re-added the hbase-1.0 and hbase-1.1  shading.  I'm also referencing the shaded classifier from hbase-1.0 in the -shaded project.  We need to shade 2 different versions of guava/protobuf and etc.  It's a bit of a mess, but it seems like the mess is mostly due to needed multiple versions of the same jar.
PTAL.  I'm sure that there is room for improvement.

@lesv: This produces a pom.xml file with no dependencies and a single jar that gets imported.  PTAL

I'm not convinced creating this is a good idea, nor am I sure of when it would be a good idea to use this. If users are programming against HBase interfaces contained in HBase artifacts, they should be referencing HBase artifacts, not our artifacts.
I think that a larger discussion of what problems this is solving would be good so that we can explore other options. Do we have bugs for each issue? I've seen a FR about creating an hbase api interface + POJO jar upstream which would be awesome (but also probably not as simple as it seems with Filters, etc), but otherwise just random emails for everything else.

I agree w/ Angus's view, though it's fairly easy just to have a single dependency, however, if we are going to have a bunch of  anyway, then why not switch from default scope to something else, and add all the hbase stuff back in?

@lesv: I'm not sure what you mean.

@AngusDavis: One issue is that we have to exclude too much right now from hbase-1.0 and hbase-1.1 even with the classifier=shaded.  We need a reduced dependency pom.xml when using the shaded classifier.  Right now, we either use the non-shaded jar, which brings in a version of protobuff and guava which will either be inconsistent with hbase or with bigtable.  Or, we can use the shaded jar and pull in bigtable-hbase, bigtable-grpc-interface and bigtable-protos which will conflict with the shaded jar.

closing this for now.  We need a different solution.