PyGanja not working in VSCode Jupyter

VSCode can directly open jupyter notebooks (https://code.visualstudio.com/docs/python/jupyter-support). However PyGanja's draw doesn't show up in them.

Possibly related: https://github.com/microsoft/vscode-python/issues/3429
When I try to use the notebook feature my VSCode just becomes a dead shell around a jupyter notebook, and then I have to terminate vscode in order to open any other file.

It's something to do with these lines:
https://github.com/microsoft/vscode-python/blob/6abd30e50a36283b97f25418c357738021d2e9c8/src/datascience-ui/interactive-common/transforms.tsx#L92-L95
I can't work out where the code they reference lives, but VSCode is doing something unexpected with our IPython.display.Javascript output.
You can attach an inspector via the Developer: Open Webview Developer Tools command in VS Code. It fails with an error like:
Failed to load resource: net::ERR_FAILED
require.js:143 Uncaught Error: Script error for "Algebra"
https://requirejs.org/docs/errors.html#scripterror
    at makeError (require.js:168)
    at HTMLScriptElement.onScriptError (require.js:1738)

It seems that our require("Algebra") is doing something weird, and not finding the local definition.

Alright, so what's happening is

Our code is being eval'd here: https://github.com/nteract/nteract/blob/v0.12.3/packages/transforms/src/javascript.js#L8-L25
ganja.js is detecting a module.exports, which is defined as:

It uses this instead of the normal requireJS define. This means it replaces the @nteract/transforms package with itself!
pyganja uses requirejs, which does not know about module exports, and so blows up on a URL fetch of Algebra.js.

We can fix this either by:

Getting nteract to clear module before calling eval. No good can come of letting eval'd code have access to it.
Having ganja.js specifically ignore module.exports if it is already populated, and fall back on define.
Set var module = null in pyganja.

Since I'm a bit suspicious that the upstream code no longer exists, I think we have to pick option 2 or 3. @enkimute, do you have a preference?

Just to prove option 3 works:

Concluded that option 3 was the right way to go, because really we want to force ganja.js to operate in requirejs mode


InvalidRequestError: Could not reflect: requested table(s)

Summary
We are trying to get data from Databricks into a pandas dataframe. We were able to get the list of all the tables but when we try to actually query the data on one table, it fails.
We are actually able to make it work using only databricks-sql-connector, but we'd prefer to use sql_alchemy if possible.
Data
The tables are in Databricks under hive_metastore.my_schema which we access through a SQL warehouse.
Code and Error
The code below correctly returns all the tables (schema_name = "my_schema")
from databricks import sql
from sqlalchemy import *
from sqlalchemy.engine import create_engine

engine = create_engine(
    f"""databricks+connector://token:{databricks_token}@{databricks_server_hostname}:443/{schema_name}""",
    connect_args={ "http_path": f"{databricks_http_path}",},
)
sql_query = "show tables"
df = pd.read_sql(sql_query, engine)

However when we change the line before last to:
sql_query = "select * from my_table limit 100"

We get the following error:
InvalidRequestError: Could not reflect: requested table(s) not available in Engine(databricks+connector://token:***@****.azuredatabricks.net:443/my_schema): (select * from my_table limit 100)
We tried to replace my_table by my_schema.my_table, hive_metastore.my_schema.my_table and we get the same error.
Libraries
Python 3.10.8
pandas 1.5.1
sqlalchemy-databricks 0.2.0
sqlalchemy 1.4.39
databricks-sql-connector 2.0.2
Please let me know if I need to provide more details. Thanks for the help.

The issue is actually with pandas. For some reason it is misinterpreting the sql_query as a table name or something like that. By doing:
df = pd.read_sql_query(sql_query, engine)

that prevents pandas calling read_sql_table instead and everything works!
Thanks for providing this library!


Assignment 8 numbers and variables

Hey @hallt4, looks like you opened this PR into the main Bloc repo instead of your fork.
You can select the base fork on the screen when you open a pull request:

"Base fork" is where you want the changes to go. If you select your own repo, the option to select other forks will disappear (this is what you want). So if you're doing it correctly, it will look like this:


Exercise 4

Our review: https://github.com/Systems-Development-and-Frameworks/SCP-Foundation/pull/5#pullrequestreview-548145909


[Help] Failed to resolve requirements from PEX environment

I am trying to build a .pex file and then have it run on an EMR cluster. I am getting the following error: Failed to resolve requirements from PEX environment
I am creating a .pex file using the following commands;
export virtual_environment="my_application_env"

python3.7 -m venv $virtual_environment --copies
source $virtual_environment/bin/activate
pip install -U pip

pip download -r requirements.txt \
    --dest ./build/wheelhouse

pip install pex

pex . -r requirements.txt \
    -o ./$virtual_environment.pex \
    --no-index \
    -f ./build/wheelhouse

rm -rf ./build/wheelhouse
deactivate

Full stack trace:
PEXWarning: PEX_ROOT is configured as /home/.pex but that path is un-writeable, falling back to a temporary P
EX_ROOT of /tmp/tmp_vltgti0 which will hurt performance.
pex.environment.ResolveError: Failed to resolve requirements from PEX environment @ /mnt/yarn/usercache/hdfs/filecache/1/24059176/connect_cl
oud_base_dq_env.pex.
Needed manylinux_2_26_aarch64-cp-37-cp37m compatible dependencies for:
 1: MarkupSafe>=0.23
    Required by:
      Jinja2 2.11.3
    But this pex had no 'MarkupSafe' distributions.
 2: pyrsistent>=0.14.0
    Required by:
      jsonschema 3.2.0
    But this pex had no 'pyrsistent' distributions.
 3: numpy
    Required by:
      altair 4.1.0
    But this pex had no 'numpy' distributions.
 4: pandas>=0.18
    Required by:
      altair 4.1.0
    But this pex had no 'pandas' distributions.
 5: pyzmq>=13
    Required by:
      jupyter-client 6.2.0
    But this pex had no 'pyzmq' distributions.
 6: tornado>=4.1

Was the pex . intentional? I suspect you only wanted pex -r requirements.txt.

Eric's question is good. Another set of diagnostics to help debug remotely:

You should have pex-tools in your venv by dint of having installed pex. If not, re-run pex building adding --include-tools as an argument.
Run and report the full output of pex-tools ./my_application_env.pex interpreter -avi4 - this will reveal the interpreters PEX is selecting amongst when starting up (If you didn't have pex-tools you run PEX_TOOLS=1 ./my_application_env.pex ...).
Run and report the full output of pex-tools ./my_application_env.pex repository info -i4.

@Eric-Arellano @jsirois thank you both for your quick feedback!
@Eric-Arellano omitting the first . changes nothing when I try run it on the EMR cluster.
@jsirois Should I run pex-tools ./my_application_env.pex interpreter -avi4 & pex-tools ./my_application_env.pex repository info -i4 on the machine creating the .pex file or the machine running the .pex file?

@JeroenSchmidt for ease of debugging, both would be great.

 Pex has no magic up its sleeves. To build for arm on an intel host you'll need two things:

Tell Pex the exact platform you'll be running on via --platform
Make sure you have pre-built wheels for the target platform available for Pex to see when building your PEX file.

For 1, you can find out the correct platform string by running PEX_TOOLS=1 ./my_application_env.pex interpreter -v on the target host (you'll need to have built the PEX file with --include-tools. You'll get something like:
$ pex-tools  ./my_application_env.pex interpreter -v
{"path": "/home/jsirois/.venv/pex/bin/python3", "requirement": "CPython==3.9.3", "platform": "manylinux_2_33_x86_64-cp-39-cp39"}

You want to use the "platform" value as the argument to --platform when building your PEX.
For 2, you can use switches similar to those you already have, like --no-index and --find-links pointing to the pre-built wheelhouse.

Oh, I see you've already found the correct target host platform string. Yeah, so you just need to build the PEX file with:
pex . -r requirements.txt \
    -o ./$virtual_environment.pex \
    --no-index \
    -f aarch64-wheelhouse \
    --platform=manylinux_2_26_aarch64-cp-37-cp37m

@JeroenSchmidt I'm going to close this issue as an answered question. Please re-open if this does not solve your problem or you have more questions about setting up wheelhouses for your target hosts where your build hosts are different platforms.

Thank you @jsirois & @Eric-Arellano! This has been stumping me for awhile but it never occurred to me to look at the underlying host architecture.
As a final question (and slightly unrelated to pax), would you know who I can download the aarch builds using pip within the command;
pip download -r requirements.txt \
    --dest ./build/wheelhouse

I am working within an environment which uses a private package index and from my understanding using pip download -> wheelhouse is the only work around at the moment when using pax?

To be clear, the issue here is not Pex. In an exactly analogous way, you cannot build a venv for aarch64 on x86_64 using Pip either.
So the scenario is this: You are trying to build a PEX file that will be run on a foreign platform. For each distribution needed to build the PEX environment that is platform specific you must have a pre-built wheel for that platform available since you cannot build a wheel for that foreign platform from an sdist (Pex has no cross-build capability).
Now, if there are pre-built wheels for the correct target platform already available and you point Pex to those and use an appropriate --platform, everything will just work. If pre-builts aren't all available then you must build them on the target architecture. There are lots of ways to do that. One is to use pip wheel --wheel-dir wheelhouse/ [requirements] (not pip download). That will download the transitive closure of distributions needed to satisfy X and build wheels as needed from sdists when there is no pre-built wheel available.


close #1136

Issue https://github.com/channelcat/sanic/issues/1136

Can you provide a more descriptive PR title?

@seemethere voila


Add target=“_blank” to all external links

Scrub entire site for external links that do not have  on href's and add the snippet.

complete


Add ability to set up deployment annotations

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution @evgkrsk
Could you please add the annotations key to the custom-values.yaml so it will be tested in the CI.


[7.x] Add plain text only notifications

The ability to add a plain text version of a notification alongside the html version was introduced in https://github.com/laravel/framework/pull/33725 which was released in 7.23.0.
In this PR I've added two small fixes that will allow to send plain text only notifications.

Sent in https://github.com/laravel/framework/pull/33816 to revert this.


disabled prop on submit button

Details
Submit button for setting password is now disabled when the form is not valid
Fixed Issues
https://github.com/Expensify/App/issues/4731
Tests
https://user-images.githubusercontent.com/47184118/131693575-04888d5c-71ac-43e4-ac3d-560484727044.mp4
QA Steps

log out
set LS key "credentials"<EMAIL_ADDRESS>navigate to:
https://localhost:8080/setpassword/123/123
verify the submit button is disabled
enter passwords into the boxes that are valid and match
verify the submit button is enabled and works

Tested On

[x] Web

@anthony-hull please test on all platforms in the future. There is a PR template for a reason.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-10.  :confetti_ball:

🚀 Deployed to production by @roryabraham in version: 1.0.92-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@anthony-hull Thank you for your contribution here 🎉
I just wanted to bring to you attention this post from Slack about how to format the linked issues in your PRs. Please, keep that in mind for I hope many more PRs to come 😄 🎉


Cannot install to VSCode 1.63.2

Getting message "is not compatible with the current version".
Linux:
Red Hat Enterprise Linux Workstation release 7.4 (Maipo)
VSCode:
Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:39:46.686Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 3.10.0-693.el7.x86_64

Fix has been uploaded


Messages with links not selectable

Messages with auto-linked text can not be selected by tap over the text, any text not only link. Tapping over empty area successfully selects message.

Maybe this https://medium.com/@Saketme/a-better-way-to-handle-links-in-textview-27bb70b2d31c (https://github.com/saket/Better-Link-Movement-Method) is a solution.

Fixed in https://github.com/binwiederhier/ntfy-android/commit/4771ccc6c0e98892299b50f3eeef3a92acfba8c0
I also tried the link movement method above, which highlights links nicely when they are clicked and allows for long-click options. However, the long click does not work properly because the long-click-select-row logic interferes with it. So for now I won't add this. It'd be nice though to open a menu to "copy" or "open" the link on long click


Fix BatchRandTransform & PitchShift

Resolves #23.

@warner-benjamin I tested this on Kaggle and it works as expected:
# installing from the transfom_fixes branch
!pip install colorednoise primePy git+https://github.com/warner-benjamin/fastxtend.git@transform_fixes -qq

auds.summary(df) runs successfully when the DataBlock has PitchShift as batch_tfms:

Ran auds.summary with batch_tfms equal to VolumeBatch, PitchShiftTA, TimeStretch and PitchShiftOrTimeStretch and it works. Also trained a resnet18 for a few epochs just to make sure and it trains successfully.

My first preference was to test it locally on my machine so I got fastxtend installed (w/ pip install -e .) but I have macOS 11.6 so I was getting the error when running auds.summary(df):
RuntimeError: The MPS backend is supported on MacOS 12.3+.Current OS version can be queried using `sw_vers`

Which I don't think can be resolved until I upgrade to 12.3+.

@vishalbakshi thanks for testing the fix. I wouldn't expect fastxtend to work on MPS. I've coded everything with Cuda or CPU in mind, and don't have a modern mac to do any testing on.


reverted dpytest and pysqlcipher3 back to using version numbers instead of git

Previously used git+URL@commit, reverted back to library==version within requirements.txt

version 0.1.0 or 0.0.24 of dpytest is being released soon with the fix for #77 's error. This should allow dependabot to find it when it comes out and make a PR


Add homebrew recipe for buildifier

It would be great to be able to install buildifier via Homebrew.

Sounds good to me.  Are you volunteering?
On Fri, Feb 10, 2017 at 6:12 AM, David Z. Chen<EMAIL_ADDRESS>wrote:

It would be great to be able to install buildifier via Homebrew.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/buildifier/issues/48, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALF-0gzkgeC8BayzjyRPq2LIqIqzYuB_ks5rbEYlgaJpZM4L9RDb
.

This seems to have been done.  I just updated homebrew and buildifier was available.

Indeed it has: Homebrew/homebrew-core#10325

It seems there is a problem with the homebrew packaging of buildifier.
See the discussion on this PR where I was trying to fix the version string: https://github.com/Homebrew/homebrew-core/pull/12413
Apparently downloading pre-built Go binaries rather than depending on the brew go formula is a violation of the homebrew packaging guidelines.


Fixes #25917

add handling for adin in jitter rng (issue #25917)

IMO this is outside of what is acceptable with CLA: trivial. Could you please sign a CLA? https://openssl-library.org/policies/cla/index.html

Could you please amend the commit message to remove CLA: trivial?

I've updated the commit message to replace author with my email address but see the cla-check is still looking for the previous name

I still see:
Author: jsondevers<EMAIL_ADDRESS>Date:   Fri Nov 15 11:12:58 2024 -0800

on the commit. Did you use --reset-author option?

Was missing that, thanks!

This pull request is ready to merge

Merged to the master branch with a tweaked commit message. Thank you for your contribution.

This was unfortunately seriously wrong with quite big impact. Fortunately it was catched in CI. Fix in https://github.com/openssl/openssl/pull/26112

Apologizes for the mistake, thank you for letting me know!
Is there a certain test it was failing in CI? I wasn't able to find where it was caught.
I took a look at the fix and see that to add in the additional input, it was xor'd into the output, similar to that of jitter_get_seed(),

https://github.com/openssl/openssl/actions/runs/12152102840/job/33887870809 - this build failed


support sealer upgrade

Describe what this PR does / why we need it
Support sealer upgrade
Does this pull request fix one issue?

Describe how you did it
Distribute materials by sealer & Upgrade cluster by plugin。
Describe how to verify it
sealer upgrade ack-agility-registry.cn-shanghai.cr.aliyuncs.com/ecp_builder/ackdistro:v1-22-15-ack-upgrade-lyk-test

Special notes for reviews

Codecov Report
Base: 18.33% // Head: 18.19% // Decreases project coverage by -0.15% :warning:

Coverage data is based on head (89fc3b7) compared to base (147d994).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2047      +/-   ##
==========================================
- Coverage   18.33%   18.19%   -0.15%
==========================================
  Files         101      102       +1
  Lines        9227     9301      +74
==========================================
  Hits         1692     1692
- Misses       7304     7378      +74
  Partials      231      231

Impacted Files
Coverage Δ

cmd/sealer/cmd/utils/cluster.go
28.27% <0.00%> (-3.88%)
:arrow_down:

pkg/cluster-runtime/hook.go
3.72% <ø> (ø)

pkg/cluster-runtime/upgrader.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feature: alternative window style

Solution
A minimized window, clean and concise UI.
Showed on screen :

Counter (% or min)
Start/Stop counter
Escape minimized UI

Hi,
I'll have a look at this if you're happy with the following mockup:

You are doing an amazing job !
It looks awesome 😍
Go for it !

Thanks @KeziahMoselle! You've made an awesome app, I'm just trying to help out where I can.

Thank you 😊


How can i access public address, loginUser callback not working

I added the glaip on my project, and call the loginUser function but, this function callback does not work,  I want to access public address
glaip.loginUser(type: .WalletConnect) { result in
print(result)        // not work
}
please help me

Thanks for your question. Please update your package (right click, update) and add the following to your code
.         glaip.loginUser(type: .WalletConnect) { result in               switch result {                 case .success(let user):                   print(user.wallet)                 case .failure(let error):                   print(error)               }             }

Thanks for your question. Please update your package (right click, update) and add the following to your code
       glaip.loginUser(type: .WalletConnect) { result in
          switch result {
            case .success(let user):
              print(user.wallet)
            case .failure(let error):
              print(error)
          }
        }

thank you, i access public address

I have the same problem, here is my code. Help me please))
 let glaip = Glaip(title: "Test", description: "Test descr", supportedWallets: [.MetaMask])
        glaip.loginUser(type: .MetaMask) { result in
            switch result {
            case .success(let user):
                print(user.wallet.address)
            case .failure:
                break
            }
        }

@eugeniychepelev your problem is that you never get a call back in either success or failure?

@maurovz Yes, in any case, call back does not work

@maurovz I found the reason, but I don't know why it works like this
in this method in closure self = nil
 public func loginUser(type: WalletType, completion: @escaping (Result<User, Error>) -> Void) {
    switch type {
    case .MetaMask:
      metaMaskLogin(completion: { [weak self] result in
        guard let self = self else { return }

        switch result {
        case let .success(user):
          DispatchQueue.main.async {
            self.userState = .loggedIn(user)
          }
          self.currentWallet = .MetaMask
          completion(.success(user))
        case let .failure(error):
          completion(.failure(error))
        }
      })

@eugeniychepelev try installing Glaip from this branch: bugfix/self-nil-reference
You can switch to the branch as follow:

let me know if that works. If so, I'll merge that branch into main


Start migration of retorch-orchestration tool

I've reviewed the current status of the RETORCH orchestration tool, and I believe it’s almost ready to migrate the first version to this repository and make it publicly available. I’m beginning to outline the next steps we should take (tentative list):

Create the module structure and organize different packages.
Migrate the entity and phase packages (grouping, deployment, resource identification, scheduling), along with DTOs and base configuration files.
Migrate the test cases and integrate them with GitHub Actions.
Set up the repository to create the library and make it publicly accessible.
Integrate the tool with the EshopContainer and Fullteaching repositories.

Let’s discuss any changes to these steps and how best to proceed, @javiertuya.

@augustocristian @ClaudiodelaRiva I think that a big-bang approach and let the tests for the end is not the best approach. Migration should be incremental, starting by the module with less dependencies (ochestration) as we discussed before, and including everything of it (code, tests, doc and packaging). After migrating everything, publish the release (v2.0.0)

Once the Resource Identification is migrated, should we proceed with the Grouping and scheduling package? @javiertuya

@augustocristian @ClaudiodelaRiva Remember, after the orchestration module, the next to migrate is the generation of the jenkinsfile, just this, anything about profiles, costs, etc.

The Generation of Jenkinsfiles is under migration in  https://github.com/giis-uniovi/retorch/tree/ft_migrateschedulerorchestrator


Auto gofmt on completion not working with custom GOROOT

Gofmt on save no longer works, and I believe this happened when I moved GOROOT away from /usr/local. I saw on a different issue that there can be problems with multiple go installations, so I deleted the old one. I tried reinstalling GoSublime, changing only the "env" variable. Goimports is not working either, so I'm guessing it's something with the save integration. There are no MarGo warnings on startup (which do occur if I have an incorrect GOROOT variable). I'm not sure what else to try. Thanks.
 I have 2 SublimeText3 windows open. One of them correctly executes goimports when saving a file. The other show this in the log:
** 2016-01-28 16:58:03.882521 **:
GoSublime
cannot fmt file. error: `Blocking Call(sh): Timeout'

NEVERMIND! Sorry. If I have any syntax errors in the file, goimports won't get called. It's strange: to test if goimports is 'working' I just delete one of the imports -- that would give the error. Now it doesn't.


Features/setup junit and example

Setup JUnit tests that run whenever the project is built and added a quick example.
Also added the Rev Robotics libraries

Wondering if we use a non-motor junit example to start, and see where the team goes with that?
We will need to present it either way
Found this:
https://firstmncsa.org/2019/09/02/simple-unit-tests/
Seems like a good explanation

Wondering if we use a non-motor junit example to start, and see where the team goes with that? We will need to present it either way
Found this: https://firstmncsa.org/2019/09/02/simple-unit-tests/
Seems like a good explanation

I was looking at that same site for Unit testing subsystems/commands using Mockito to "mock" any objects needed in the test that aren't available in simulation. A few example for each 'type' of test might be a good approach. Subsystem, command, and generic method.
Unit Testing Subsystems
Unit Testing Commands


datasource: Allow setting smaller static strings

There are cases when an operator needs to change the value of a static string (coming from ebpf for instance). This commit ipt improves the logic to allow the operator calling the PutString() method with a string that is smaller than the buffer size.

I found this issue / limitation when trying to update the name field in wasm in #2823. That PR implements a workaround for it, but IMO it needs to be handled directly in the accessor.
@flyth any opinions on this one?

Hmm...
I think we need to add errors from the Put* functions to do these kind of things, otherwise it could lead to (from the developer) unexpected behavior (e.g. some Puts would work, some wouldn't (if the string is too long)). To be fair, it's already the case if you'd try to write a string with the exact length of the field vs. another length right now.
IMHO this isn't best practice in the first place (editing a statically sized string), but if we allow it, we should at least make sure it's reported if it didn't succeed.

I think we need to add errors to the Put* functions to do these kind of things, otherwise it could lead to (from the developer) unexpected behavior (e.g. some Puts would work, some wouldn't (if the string is too long)). To be fair, it's already the case if you'd try to write a string with the exact length of the field vs. another length right now.

I totally agree. What do you think about the "Get()" methods? Should we return errors instead of default value when something goes wrong?

IMHO this isn't best practice in the first place (editing a statically sized string), but if we allow it, we should at least make sure it's reported if it didn't succeed.

I don't see any reason why we should block this. I feel there are use cases where this is valuable.

I think we need to add errors to the Put* functions to do these kind of things, otherwise it could lead to (from the developer) unexpected behavior (e.g. some Puts would work, some wouldn't (if the string is too long)). To be fair, it's already the case if you'd try to write a string with the exact length of the field vs. another length right now.

I totally agree. What do you think about the "Get()" methods? Should we return errors instead of default value when something goes wrong?

Yeah, let's do it - better now than later. I was a bit worried about returning two values, because it might not be compatible with all languages that would compile to WASM - but I think it's better to have a clean implementation on the host and let the guest APIs worry about getting it right there.

IMHO this isn't best practice in the first place (editing a statically sized string), but if we allow it, we should at least make sure it's reported if it didn't succeed.

I don't see any reason why we should block this. I feel there are use cases where this is valuable.

I agree, we shouldn't block this.

Updated the PR to return errors. The code is not as clean as before, but we need it.


UI should accept featurecollections with one polygon feature

I don't think we really need feature collections (or its "properties" can be simply ignored). However the export tool still needs a valid geometry which can only be one or more "Polygon" or just one "MultiPolygon" containing all of them (as the coordinates in "MultiPolygon" in geoJSON, is just a simple array of coordinates in a "Polygon", you just concatenate the arrays separated by comma and surrounded by [])


Adding CONTAINERS WIP doc

First cut at documenting our container efforts

Hi @deitch -- thanks for spotting the typos/etc. I fixed those. As for your comment:
I am concerned about using rkt, as it appears to be be rapidly losing any market share. runc works, but it doesn't have any "stage1-path" option, since it is built entirely differently.
No disagreement there. We started with rkt because it is very selfcontained, small, easy to package and, most importantly, already had stage1 Xen support.
However, interestingly enough, @sstabellini mentioned that he may look into runc support as well. At any rate -- replacing rkt with runc should be trivial if/when we decide to do it.

Yes, porting stage1-xen to the runc interface is pretty easy, and it is in the plans. In fact, I even have a PoC already. Stay tuned ;-)


Unknown error when typing argument

Tern settings
{
  "tern_argument_hints": true,
  "tern_output_style": "tooltip",
  "tern_argument_completion": true,
  "tern_arguments": ["--no-port-file"],
  "tern_command": ["tern"]
}

.tern-project
{
  "ecmaVersion": 7,
  "libs": [],
  "dontLoad": [
    "node_modules"
  ],
  "plugins": {
    "complete_strings": {},
    "node": {},
    "modules": {},
    "jsx": {},
    "es_modules": {},
    "doc_comment": {
      "fullDocs": true
    }
  }
}

Can you reproduce this without the jsx plugin? If so, can you give me a source file that triggers it?

I can't now reproduce it, but it appears regularly. I'll send you a file when get this bug again.

I can reproduce with ST4, when typing a space at the end of the string or line(in script area of .vue file), it continuously popup the empty message.

And this might be the error log:
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/Lib/python33/sublime_plugin.py", line 893, in on_query_completions
    norm_res(callback(v, prefix, locations))
  File "/Applications/Sublime Text.app/Contents/MacOS/Lib/python33/sublime_plugin.py", line 129, in profiler
    return event_handler(*args)
  File "/Users/brownsugar/Library/Application Support/Sublime Text 3/Packages/tern_for_sublime/tern.py", line 68, in on_query_completions
    pathFirstCh = pathPrefix[0]
IndexError: string index out of range

Can you find any .tern-port file in the project?

@othree No, there is no config file for Tern in the project.

@brownsugar Can you provide a sample code and steps to reproduce(including configs you added). And AFAIK latest official release of Sublime Text is version 3. How do you use ST4?

@othree
The only config I have is:
{
  "tern_argument_hints": true,
}

I think is not about the code, it happens randomly, I tested by same code in two files, one happened and the other not.
You can download ST4 from ST official Discord server.

I believe it’s crashed or don’t have any request then it stopped itself. If
it is crashed we have to find out why.
Lay<EMAIL_ADDRESS>2020年6月4日 週四，下午5:44寫道：

@othree https://github.com/othree
The only config I have is:
{
"tern_argument_hints": true,
}
I think is not about the code, it happens randomly, I tested by same code
in two files, one happened and the other not.
You can download ST4 from ST official Discord server.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ternjs/tern_for_sublime/issues/147#issuecomment-638742259,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAEAWSXQTOOKLMW55QDSXDRU5UI7ANCNFSM4CVZPC3A
.

--
OOO

@othree OK, I'll reply if there are more info I can provide.


Fix Broken Link to Token Program TypeScript Docs

Just found the broken link and it looks like I found the correct path. :)

Thanks!


asn: move to by-name

Description of changes
I'll make a start slowly moving my packages to the new by-name structure. I hope this is the right way of doing it.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

According to the docs, this PR isn't the right way: https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#manual-migration-guidelines
(Just kidding, as I wouldn't put this off for a PR that's been stalled since its introduction last year.)

According to the docs, this PR isn't the right way: https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#manual-migration-guidelines
(Just kidding, as I wouldn't put this off for a PR that's been stalled since its introduction last year.)

You nearly gave me a heart attack. Well played, sir. 😆


spring-cloud-config-client cannot locate spring profiles active

application.properties:
spring.application.name=hello
spring.profiles.active=prod

bootsrap.properties
doesn't override name and profile with spring.cloud.config.name and profile
from the startup log info, spring-cloud-config-client had located the spring.application.name Environment, but NOT the spring.profiles.active Environment, it used the "default" profile.
later on the log, the Spring Boot application was using the right configed active profile, "prod"
Give me some tips?
thx in advance.

Please learn how to format code on GitHub.
Is the application.properties coming from the config server?

Is the application.properties coming from the config server?

No.
before connecting to config server,  config client will first locate the application name and profile local, right ?
If i override profile setting in boostrap.properties
spring.cloud.config.profile=prod

config client will use this profile to get back configuration for config server.
i expect config client will use spring.profiles.active property in application.properties

Config client cannot read anything from application.properties only bootstrap. properties

Config client cannot read anything from application.properties only bootstrap. properties

but config client had read spring.application.name from application.properties
i think it should read spring.profiles.active too.
defining name and profile property  in application.properties is more natural for me anyway...

From our documentation

If your application needs any application-specific configuration from the server, it is a good idea to set the spring.application.name (in bootstrap.yml or application.yml).

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Add total backend members metric

Currently HaProxy exposes only active members per backend (act metric). It would be nice to expose total amount of members in the backend. This would be useful to calculate percentage of members active for eg. monitoring system.

I am having some troubles to get this done using Pandas. I will give it another try early next week.

Here is a pandas code which can provide the total amount of servers in a backend
Filter only server type rows from pandas dataframe
is_server = data_frame['type'] == 2
servers = data_frame[is_server].loc[:,['pxname', 'svname']]

Group by pxname, so by backend name
server_groups = servers.groupby(['pxname'])

Aggregate per unique row, as a single server appears multiple times (where haproxy is configured withh nbproc >1)
total_servers_per_backend = server_groups.agg({'svname': pandas.Series.nunique})

Print counter per backend
for _, row in total_servers_per_backend.iterrows():
        print(_, row[0])


Fixed Reference Images

4.3 messed with my loading so now there is no await for the import, instead it is just connected to a function.

Thanks!


only go to 99.9

hey nice work i'm having issues making the chart show numbers over 100
it only show data values to 99.9 how to make it go over 100.0..??
thanks

Hi, I'm not sure if I understand, a dataset with over a 100 pieces or a value over a 100?
I can show values over a 100 without a problem

ya okay might be my file formater then that dont pas numbers over 100 Hmm..


Mapping Simple Object to  Complex Type

Hello,
I came back with some questions, i try to mapping a
Simple To Complex Type or Complex Type To Simple
The following code :

Class Person

public class Person {
 public int Identity { get; set; }
 public string Code { get; set; }
 public string Name { get; set; }
 public string Address { get; set; }
 public string Phone { get; set; }
}

Class PersonDto

public class PersonDto {
 public int Identity { get; set; }
 public string Code { get; set; }
 public string Name { get; set; }
 public AddressDto Address { get; set; }
}

Class Address

public class AddressDto {
 public string Address { get; set; }
 public string Phone { get; set; }
}

I try to Bind & Mapping like this

TinyMapper.Bind<SimpleToComplexEntity.Person, SimpleToComplexEntity.PersonDto>(
 config => {
  config.Bind(source => source.Address, target => target.Address.Address);
  config.Bind(source => source.Phone, target => target.Address.Phone);
 }
);
var personDto = TinyMapper.Map<SimpleToComplexEntity.PersonDto>(person);

when tyr to map person to personDto, i get an some error : Unable to cast object of type 'System.String' to type '[Name Space].AddressDto'.
What should I do ? so that mapping from person to personDto can be done.
Without the use of custom mapping example
Best regards,
Eric Santoso

You can create a [TypeConverter] (https://github.com/TinyMapper/TinyMapper/wiki/Custom-mapping) between Person and PersonDto. Unfortunately,  TinyMapper can't jump thru several dots (I mean types), like this one target.Address.Address, but I can add this behavior if it's necessary.

Dear GSerjo,
sorry, I was late to respond, I think this will be a feature that is quite helpful
Best regards,
Eric Santoso

Hi GSerjo
I would appreciate the "several dots" feature as well
Kind regards
Pieter


PDF generation

This commit is regarding PDF generation. The PDF generation is working on linux. We should also make sure that its working as expected on windows and mac platforms.
(I assign @vnagaraju14 for mac @vshekar for windows). Please install Latex tools on your machine before checking this.

@arhik I am not sure what do you mean it's working on linux. Because, when I download the code and run locally on my machine, all the functionalities are working. However, the problem is the plot and table saving options are not working on the website.

When you are testing the tool make sure you are downloading the PDF generation branch. And then test it on your local machine. This is a test to make sure that the tool is platform independent. I can update the server any time soon when i feel confident.


bugfix: Weird Unmovable scroll bar in the tablist section #2293

Fixes #2293
There is an unnecessary "overflow: scroll" and "-webkit-scrollbar {display: none }" on tabs, and scrollbars appear when a more recent version of electron is used, where -webkit-scrollbar was removed
And as discovered by @Its-treason the nix build overwrite the electron version, that explain why some users see the scrollbars

I looked into the Nix build file: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix and the electron version in indeed overwritten:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix#L100-L112

The scrollbars don't appear with the current electron version thanks to :
&::-webkit-scrollbar {
      display: none;
    }

But it can be removed if "overflow: scroll" is removed
Description
Here is the demonstration that the overflow: scroll is causing the problem
https://github.com/usebruno/bruno/assets/139650490/1c2934a3-aa76-4dc7-979a-79576e7c28d9
This second video shows that removing overflow: scroll does not change anything with the current electron version, so there is no regression.
https://github.com/usebruno/bruno/assets/139650490/2edec105-f59e-41fc-931d-670648cc2f91
Contribution Checklist:

[X] The pull request only addresses one issue or adds one feature.
[X] The pull request does not introduce any breaking changes
[X] I have added screenshots or gifs to help explain the change if applicable.
[X] I have read the contribution guidelines.
[X] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Hi @helloanoop I fixed the conflicts and retested.
Could we please have this PR merged ?

@busy-panda I think you are missing a side effect here, the overflow scroll was supposed to make the entire tab bar scrollable (using the arrow buttons or horizonal wheel). With the removal of the overflow: scroll the entire response pane becomes scrollable. This PR also does not fix another related issue. Look how ugly the vertical scrollbar is now present in the nav menu to the left, when I open enough folders.
https://github.com/usebruno/bruno/assets/2108093/dfdf5d6c-9d3e-42c9-a03c-8255a971e78f
I think the proper fix would be to remove the scrollbar style overwrite in /globalStyles.js:169
https://github.com/usebruno/bruno/assets/2108093/201810cb-83d2-448c-b91f-2a1df874e258
The newer electron seems to handle it internally.

Thanks for taking the time to help debug and provide a fix for this issue @end3rbyte !
We have updated the electron version which has resolved this issue. The latest version of Bruno should not have this issue.
Closing this PR.

Closing this PR as the fix for the issue has already been made and the v1.26.2 release contains the fix.


Added bottom to up button in the index file.

Fixed issue : #76
The bottom to up button is added with easy css,js,html. This is very helpful as it helps to go to top of the page with just clicking a button.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jobara ?

@aashimgarg I mentioned on the Issue that we need to think about the design more. First to determine if it is something that is needed for this site, and, if so, what the intended design for it is.

 All committers have signed the CLA.

Stale and inactive PR. It requires more discussion. May or may not be closed.

This PR won't be merged as we are currently beginning a redesign process. Thanks for your contribution!


Include the Locomotive JS-For smooth scrolling

I saw that the website is not smooth in scrolling so I thought of using the Locomotive js which can enhance the website smoothness and make the user feel good. So I would like to work on this issue. So please assign this to me under @GSSOC'24
@khushi-joshi-05

Hey, I am a frontend developer who creates stunning and modern websites.
I completed the internship as a frontend developer.
I create websites with HTML, CSS, JS, and React, and I use JS libraries for animation and smooth scrolling.
The following are the works where I used lgsap animation and locomotive js :
https://exoape-clone-parth.netlify.app/
https://ochi-clone-parth.netlify.app/


Computed, mixing plugins, routing is not working anymore for an unknown reason.

Version
v2.8.1
Reproduction link
http://nolinksorry
Steps to reproduce
Actually, there is not step to reproduce as I do know it what circumstance this bug appears.
What is expected ?
No bug expected.
What is actually happening?
Global mixins doesn't work anymore.
Computed doesn't work anymore
If I use my own router with @nuxtjs/router, it doesn't work anymore
https://stackoverflow.com/questions/56494179/global-mixins-to-nuxt-v2-4-undefined
About computed data :
These picture is showing pagination of data.
After clicking on page 2, it should show 4 rows. Nothing changes.

About router :
This picture show what happens if I set "keepDefaultRouter" to false

Error alert
TypeError: Cannot read property 'name' of undefined
    at VueComponent.getRouteBaseName (app.js:3436)
    at VueComponent.switchLocalePath

Line that error come up.
function getRouteBaseNameFactory(contextRoute) {
  var routeGetter = contextRoute ? function (route) {
    return route || contextRoute;
  } : function (route) {
    return route || this.$route;
  };
  return function getRouteBaseName(route) {
    route = routeGetter.call(this, route);

    if (!route.name) {
      return null;
    }

    return route.name.split(routesNameSeparator)[0];
  };
}

Additional comments?

If I change something, or build for deployment. It breaks.
node v8.14.1
yarn 1.15.2
nuxt : 2.8.1
@nuxt/router : 1.3.2
If I delete my @nuxtjs/router , error still show up.

This bug report is available on Nuxt community (#c9334)

Thanks for the report. Although your issue clearly shows there is an issue within your project, it doesnt help us to re-create your environment to reproduce and then debug the issue. So we would appreciate if you could setup a minimal reproduction of the issue. Help us help you :)

Thank you for your reply!!
I will do that as soon as possible

It was a mistake from my side...
Everything is fine...
my buildDir directory was inside a firebase's functions directory (function/nuxt/ssr)
There was a conflict between the app's node_modules and the functions's node_modules...
Anyway, thanks for your time:)


Revert "Installing Snowflake driver"

Reverts MicrosoftDocs/powerbi-docs#2143
replaces it with
https://github.com/MicrosoftDocs/powerbi-docs-pr/pull/3845

@maggiesMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[TEST] Install certifi for SSL

Trying to fix azure testing...

Okay! Setting a new VM image seems to have done the trick 🤷♂ (I don't think the certifi package helped at all...)
Debugging Windows errors is incredibly annoying, but once the test suite finished we should be back up and running! 🙌


Telework: Update "ADM" text to "ADM (or delegate)" anywhere it appears on the form

User Story
As a user, I want it to be clear that my ADM or a delegate can action my request, so that my request is not waiting for an ADM specifically.
Tasks

[ ] Confirm with Business (Sean Gadsby) that this change is approved
[ ] Change text anywhere it says "ADM" to "ADM (or delegate)"
[ ] Test

Acceptance Criteria

[ ] I can see "ADM (or delegate)" anywhere on the form that was referring to "ADM" previously

Related: Given we want to ensure consistent language in the tool and in the Careers & MyHR content, I have asked Josh/team to:

look for any instances of "ADM" in FAQs or content
replace as "ADM or delegate"

The wording changes are completed on the form. The pop-up wording on the form generated when the supervisor accepts the telework form however needs to be updated. I've sent the request to Josh to see if he can update the wording. Chris

good catch Chris the confirmation messages where build by DEV/Dave we need to reassign to Bhumin or Iman

@Stella-Archer
Update text on the confirmation screen.
FYI:
I have updated "ADM" to "ADM (or delegate)" in the form itself too.
In the "manager/supervisor signoff" section -> "agreed by manager" -> "the employee has requested for 3 or more days" -> "Here there are 3 bullet points".
update text in these bullet points.

I tested the communication screen and can confirm the ADM (or delegate) has been updated successfully.
I'm closing this ticket. Chris


Python Flask App as stand alone module

Removing the python flask app consumer from the machine learning with jupyter module. Would need to create this as a stand alone module which can then be added to the workshop as optional.

We separated out the ml deployment (rest endpoint, curl testing, and python app)


Kibana api update

The API that we're currently using for the kibana_alert module is deprecated. This PR contains changes to update endpoints and parameters to match the current API.
Some things of note:

The endpoints for create, update and delete functions have changed.
The naming conventions for some parameters have changed from camel case to snake case.
"alerts" are now called "rules" in Kibana-land. Added a note to the module docs to help with confusion.

Rebased on main due to newly merged and unrelated PR

All Reviewers approved. Merging


[BUG] Changing bots from Job detail resumes the job without updating the UI

Describe the bug
When we change the bots from Job detail, the job resumes but the buttons still shows Resume, Stop & Abort
To Reproduce
Steps to reproduce the behavior:

Create a New Job (Multi-Run or Proxy Check)
Start it
Pause it
Change bots from Job detail
The Job resumes but buttons still remain same

Expected behavior
Either it shouldn't resume the job or it should update the UI showing Pause, Stop & Abort buttons
Additional Request
When we Pause the job, Abort button isn't available when its pausing. Suppose there's a situation when all things goes to BAN and we accidentally press Pause then we aren't able to stop/abort the Job and need to close OB from terminal.
If possible please show Abort button when pausing also.
Also the timer for Elapsed & Remaining time doesn't stop on Pausing any Job

@AtlasZ-PM I would really appreciate if you opened 2 separate issues for the other 2 things you asked

When we Pause the job, Abort button isn't available when its pausing. Suppose there's a situation when all things goes to BAN and we accidentally press Pause then we aren't able to stop/abort the Job and need to close OB from terminal.
If possible please show Abort button when pausing also.
Also the timer for Elapsed & Remaining time doesn't stop on Pausing any Job

Okay sure @openbullet . Sorry for lumping all into one.
I think someone already opened an issue for first point here #140 .
I will create separate issue for the second point. Thanks!


Discussion Boards

What would you like to be added:
Github Discussions for this repository.
Why is this needed:
While similar it's less formal than Github Issues and can promote forum and conversations which will be easier to search and catalog than Slack messages. Worst case you can just turn them off later if they don't work out, right?

I haven't used GitHub discussions very much, do we know if we're using them anywhere else for k8s projects? Is there any overlap with discuss.kubernetes.io? For example Cluster API seemed to use that for some time: https://discuss.kubernetes.io/c/contributors/cluster-api/23.
/cc @mrbobbytables @bowei

They aren't being used too much - but there are a few groups that are using them:

https://github.com/kubernetes/sig-release/discussions
https://github.com/kubernetes-sigs/kubebuilder/discussions

The general issue is that they can't be labeled, if you want to apply any sort of taxonomy on top of them, or assign someone a follow up they should be issues.

How do we arrive at a decision to move this forward or not?

Probably talk about it in a meeting? I think it seems like it might be useful. and if we do turn it on, either it's useful and we keep it, or noone uses it and we turn it off.

Added to agenda for Monday's meeting.

In the Monday meeting, we discussed this, and there's no objections to doing this, but none of us have the bandwidth to set things up properly.
If anyone wants to figure out:

what we need to do to enable
how we should manage the discussions

Then please feel free.
I suggest
/lifecycle frozen
but I'm not sure if I have perms.

what we need to do to enable

Under the repository "settings" simply checking the checkbox to enable discussions is enough to turn everything on.

how we should manage the discussions

I suggest a light handed approach: let it happen organically but we can write an welcome message to remind people that if someone feels a discussion needs further attention they are welcome to put it on the community sync agenda, and/or transferring it to issues for normal grooming (Github has a link on each discussion to do this if desired).
I'm happy to write up the Welcome message.

@robscott, would you mind doing the honors and turning on the setting?

I don't think I have enough access, maybe @bowei does? If not, maybe there's some yaml we need to change somewhere

maybe there's some yaml we need to change somewhere

😂

I will enable it
On Fri, Aug 6, 2021, 1:46 PM Harry @.***> wrote:

maybe there's some yaml we need to change somewhere
😂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/gateway-api/issues/708#issuecomment-894509701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMLKT7CDZWQD3CSVLD5PTT3RCZJANCNFSM5ABPFQUQ
.

The discussion boards are open :+1:


Make Github wiki publically editable

As mentioned in #2131, it is a very simple task to make the wiki editable by the public. There are a number of users that have expressed a strong desire to improve the documentation and this would allow them to do so.
I know we are waiting for the new community website, but this is a promise made long ago and there is no clear timescale for when it eventually emerges.
Making the wiki editable would be a good stop gap measure, any work done will be moved over to the new site when it emerges.

What Fiona said!

wiki will be moved to the new site very soon, which will be editable by the
community
On Tue, Jun 23, 2015 at 7:13 AM, ScyDev<EMAIL_ADDRESS>wrote:

What Fiona said!
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/2161#issuecomment-114430738.

Yes but as I said, that was a promise made a long time ago and we have no idea when it will be in reality. I'm of the opinion that even if it's only a month away, a lot of good can be done to improving the docs even in that amount of time.
Come on Juan, it's just one click.

True, true, true.
I've heard that before, so long ago, in a galaxy far, far away.

Btw. for all who come along here, I forked the Godot wiki and made it public: https://github.com/ScyDev/godot/wiki
But it would be so much better to directly edit the official Godot wiki.

Merging new wiki changes is just extra work for me, now when most of the wiki pages are already converted to a different markdown. I recently got extra work to do when we've decided to move away from azure to a new VPS, so I updated CMS to the latest version and put changes on git.
There is one last bug left to fix that prevents me from moving the entire forum, but trust me, it's worth waiting :)

Okeeee :(

There's been many cases of project wikis trolled by anonymous users when
the wiki is this open, and GitHub does not have finer control on this. We
need to be able to have a wiki where users are given editing permissions
upon request, which will be possible in our new website
On Tue, Jun 23, 2015 at 12:55 PM, Fiona Burrows<EMAIL_ADDRESS>wrote:

Closed #2161 https://github.com/okamstudio/godot/issues/2161.
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/2161#event-337978765.

--
OkamStudio


Request is considered done, when data is downloaded instead when data is processed

Here is the example
var html = @"<html>
  <head>
     <title>test title</title>
     <link href='http://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/css/bootstrap.min.css' rel='stylesheet'>
    </head>
    <body>
    </body>
</html>";

var config = new Configuration().WithDefaultLoader(l => l.IsResourceLoadingEnabled = true).WithCss();
var loaded = await BrowsingContext.New(config).OpenAsync(m => m.Content(html));
await Task.WhenAll(loaded.Requests);
Console.WriteLine(loaded.StyleSheets.Count()); // outputs 0, sometimes might be 1
await Task.Delay(5000);
Console.WriteLine(loaded.StyleSheets.Count()); // outputs 1

The problem is that css is parsed after
await Task.WhenAll(loaded.Requests);

and there is no way to figure out when document is actualy ready.

Hm, how to do you want it to be changed? Obviously the name is requests, and not "tasks" or something more generic. It is really about the requests. I could, maybe, abstract the provided tasks more and have like an internal statemachine. But then the code just keeps on growing and I am heavily thinking about splitting up the library already (http://www.florian-rappl.de/News/Page/299/anglesharp-future-plans).
What is your proposal?

Since downloaded data is useless untill it is interpreted, there is no big point to split request and processing tasks in api level: I can't find a scenario in scope of AngleSharp where you would need get request result without it's parsing - if you want to do this you don't need AngleSharp, HttpClient would work :)
It would seem fine to me to include data downloading and processing under single term of "request", but if you think that this is too ambiguous, "ChildTasks" may work.

I disagree. I had many requests (pun intended) to measure resource loading times and make it as fine grained as possible. Of course in your application domain you do not care about the request, but only about the result of a request. So let's try to figure out a solution that remains fine grained, but allows you to focus on specifics as well.
I therefore propose the following: The current Requests will remain unchanged, however, I'll add the missing load event to the HtmlLinkElement and you can then just await that. That way you will also know the specific IHtmlLinkElement instance.

It is ok to have load event in HtmlLinkElement, but we still need an easy way to continue code execution after document is fully loaded (this should be really common scenario). So, in addition, I propose to have separate "ChildTasks" property in document which would include all tasks executed during loading.

I will provide an extension method that collects for things you are interested (its just a 1-liner and you could easily write it yourself - you already have AwaitEvent etc.). It will look similar to
await document.AwaitLoadingAll<IHtmlLinkElement>();

For a specific element you can already do
await element.AwaitEvent("load");

which will also work for the HtmlLinkElement once the event is implemented / triggered.

Still there is a bug:
var html = @"<html>
                    <head>
                        <title>test title</title>
                        <link href='http://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/css/bootstrap.min.css' rel='stylesheet'>
                    </head>
                    <body>
                    </body>
                </html>";

            var config = new Configuration().WithDefaultLoader(l => l.IsResourceLoadingEnabled = true).WithCss();
            var loaded = await BrowsingContext.New(config).OpenAsync(m => m.Content(html));
            await Task.Delay(2000);
            await loaded.WhenLoadFired<IHtmlLinkElement>();

await loaded.WhenLoadFired(); never returns, because link is already loaded before calling it.
PS: some thoughts to consider: current solution seems to be too counter-intuitive. Maybe it would be possible to expose Task Load() method for loadable elements (links, images, iframes, etc.), so that one could select manualy elements that need to be loaded and await when loading tasks will be done.

Of course - awaiting an event that is not fired will always wait. The same is true with the (underlying) AwaitEvent - so there is no bug. Also the documentation states this. It is, as said, only a helper.
If you want to be sure in your code - then make sure by getting the specific link element, checking if the sheet has been loaded and if not - await loading.

No bug because of inner workings and because it is documented? :) You sound like Microsoft, maybe worked there for a while? :)
To be seriuous, by calling WhenLoadFired() right after OpenAsync you cannot be sure if it will exit or not, sometimes it exits, sometimes it doesn't, depending on how fast link contents are loaded. Sounds like a bug to me :) If this is not fixable, the helper itself is useless and there is no point of having it in api.
By the way, checking if link is loaded and then awaiting it's task is just decreasing the problem, not solving it: what would happen, if style is loaded between the check if it is loaded and awaiting the task? The task will not return...
To remind you the whole point of this: I need a way to figure out when document with it's resources is loaded, so that document examination could be continued.

Sounds like somebody who complains about "a bug" in floating point arithmetics when he looks at 0.1 + 0.1 + 0.1.
Nevertheless all you need for your scenario is already available ... The load event was the only missing thing prior to that issue.

If you want to be sure in your code - then make sure by getting the specific link element, checking if the sheet has been loaded yet and if not - await loading.

I can't seem to find such methods on the IHtmlLinkElement to check if it's loaded and await if it's not. Can you give an example of how I'd do that?

The IDocument has a property called Requests. However, I will most probably remove this property in one of the next versions. It will be replaced by a more powerful (yet reliable) way, which lets you access all (past + current) requests (not only limited to their tasks, but with full information, i.e., request, response, status, ...).
The await loading mechanism is using AwaitEvent("load"). This will give you a task that fires once the load event has been triggered. Please note that I do not advise using the mechanism with load, since the event may not be fired in some cases (error while loading, problem with Internet connection, has already been fired, ...). If you use it, make sure to check first if a stylesheet has been loaded, and then use it similar to the following code:
// ...
var loadTask = link.AwaitEvent("load");
var errorTask = link.AwaitEvent("error");
await Task.WhenAny(loadTask, errorTask);


2D Bones are not selectable

Selecting (clicking) should always pick 2D bones before anything else (they need to be always visible on top, and always get priority for selecting).

Create 2D bones over a sprite
Try to select bones
Sprite is selected instead

+1. would be a life savior instead of having to lock the node, or selecting it via tree


Closes #605 (R1705)

Let's wait for #654 to be merged so we don't have to refactor it

The travis tests have passed on this one, even though only one of the two copies of the travis badges turned green. Not sure why the other one is stuck yellow.
This should be safe to merge. It won't cause merge conflicts because it edits only a comment in .pylintrc. It doesn't edit any .py files or the conflict prone "disable=" line of .pylintrc.


Type and badge

This adds a dropdown to settings to select between the v2 checkbox and v2 invisible captcha. In addition, this also adds a badge dropdown when selecting the invisible captcha, so you can customise placement on the captcha, as per https://developers.google.com/recaptcha/docs/invisible#config
Doing all safety checks for backwards compatibility, and will render the checkbox by default.

Badge proposal in this PR: https://github.com/barrelstrength/craft-sprout-forms-google-recaptcha/pull/7

@engram-design Can you clarify the use case for the "Include API Code" setting?

Yep, so last time I looked at this, it wasn't working correctly. I think it needs a bit more of a rethink into how the required JS is injected.
And the API code was whether to actually include the https://www.gstatic.com/recaptcha/releases/eQmzkx3d5dtuXlLOA4pEID3I/recaptcha__en.js code. We were finding that if we have multiple forms on the page (in hidden modals), each form was making a request to fetch this. There was also some Page Speed complaints about unused CSS.
Closing for now.


Remove word 'navigation' from footer

Remove word 'navigation' from footer nav - this causes screen reader repetition.

Nice work, remember to add yourself as a contributor in the _all.yml file :)


Auto-update on user-initiated song change

Expected behaviour: auto-refresh when user changes songs (b using cmus), reload & display lyrics
What happens: Program hangs for indefinite amount of time. Will occasionally update lyrics for playing song, though usually continues to display lyrics for the last song played.

Hello @JettScythe,
Auto-refresh lyric view upon a song change requires constant monitoring (0.5 seconds to 1.0 seconds) and this constant watch utilises system resources. This is the reason why I've not implemented this feature in cmus-lyrics thus far. You might have noticed following line at the bottom of lyric view,
PRESS "Q" TO REFRESH THE VIEW & DISPLAY NOW PLAYING LYRICS.
In my view it's simpler and more efficient to press Q manually to fetch-view the current lyrics upon a song change than the non-stop polling required to monitor a song change. Auto-refresh can be implemented but is it necessary? Let me know what you think.
Cheers!!!

@JettScythe And yes sorry for the belated response!
Cheers!!!

I also believe auto-update would be useful (not only for user-initiated song changes), maybe as a command line option to keep the default behaviour with lighter resources use.
This would make cmus-lyrics a good competitor to lyvi. lyvi aims at doing more things (chords, lyrics, artist bio, and covers although I never understood how to enable it) while cmus-lyrics is meant to be lightweight and minimal, but still I think the comparison is not irrelevant. I believe having lyrics always up to date without user input would suit several users' needs. Artist bio is also an interesting option, but that would probably be difficult and a bit out of scope for cmus-lyrics.

@JettScythe @Kabouik
How can one ignore popular demand?!? Here is an experimental version that refreshes lyrics automatically when a song changes in CMus,
cmus-lyrics-auto-refresh
I've also updated the README file to reflect this information.
Cheers!!!

Awesome, thanks for considering this! I will try it later tonight. Can you elaborate why it is recommended to stick to the base version, is there any security concern with the auto-refresh hack?

@Kabouik No security risks just that it was untested! But all that is a history now as I've updated main version of cmus-lyrics and it should now refresh lyrics for normal song change as well as user initiated song change. Please try it and let me know.
@JettScythe Thanks for inspiring this change!
Cheers!!!

This works exactly as I was expecting! Thank you for the quick addition :)

That's perfect!

@JettScythe and @Kabouik Thanks for your feedback and suggestions!
Cheers!!!

I found two songs that make it hand though, instead of displaying that no lyrics can be found Then it stays stuck in that state even when changing song. Do you want me to send you those songs over email if you are interested in checking what is not handled correctly by the script?

Sure. That'll be fine.

@Kabouik I think I have fixed the problem described by you. Please test the updated version and let me know. Thanks again for your help in improving cmus-lyrics.
Cheers!!!

No, thank you for making it and improving it!
Unfortunately I have bigger issues with the latest version:
$ cmus-lyrics
/tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
grep: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
cat: '/tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX'$'\n''A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ'$'\n''N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH'$'\n''E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF'$'\n''OJWWC3TO': File name too long
/usr/local/bin/cmus-lyrics: line 253: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
/usr/local/bin/cmus-lyrics: line 254: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
/usr/local/bin/cmus-lyrics: line 255: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
cat: '/tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX'$'\n''A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ'$'\n''N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH'$'\n''E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF'$'\n''OJWWC3TO': File name too long
/tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
grep: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
cat: '/tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX'$'\n''A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ'$'\n''N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH'$'\n''E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF'$'\n''OJWWC3TO': File name too long
/usr/local/bin/cmus-lyrics: line 253: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
/usr/local/bin/cmus-lyrics: line 254: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
/usr/local/bin/cmus-lyrics: line 255: /tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX
A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ
N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH
E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF
OJWWC3TO: File name too long
cat: '/tmp/cmus_lyrics//IRSXM2LMEBHXEICBNZTWK3CMN52SARDPNFWGY33OHMQMHCLUNFSW43TFEBCGC2DPHMQFA2DJNRUX'$'\n''A4DFEBCW45DSMVZXGYLOM5WGKOZAJVQXEY3FNRWG6ICHNF2WY2LBNZUTWICGOJQW5Q5HN5UXGICQ'$'\n''N5TWO2LPHMQEC3DFPBUXGICBNZSXE2LMNRSXGOZAJRQXK4TFNZ2CAQTBOJSGC2LONZSTWICGMFRH'$'\n''E2LDMUQE2YLSORUW4ZL2HMQFI2DPNVQXGICEMUQFA33VOJYXKZLSPE5SARDBNZUWK3BALJUW23LF'$'\n''OJWWC3TO': File name too long
^C

@Kabouik The problem you described here happened because ext family (ext2, ext3 & ext4) file systems limit maximum filename  length to 255 bytes and filenames created by cmus-lyrics in your case were longer than that limit. I've updated cmus-lyrics to fix this issue. Thanks for your valuable feedback.
Cheers!!!

Thanks for the quick fix again @hakerdefo! I can confirm the issue with long file names no longer occurs with the same files, and files which were initially making it hang (with no output) no correctly report that no lyrics were found. I don't know what was wrong with the later files, because some other files with no lyrics found were just showing it in cmus-lyrics' output.
I have many files for which no lyrics can be found unfortunately, but I assume it's a limitation of the makeitpersonal database. I was previously using [lyvi](https://github.com/ok100/lyvi) which relies on [glyr](https://github.com/sahib/glyr) to find lyrics, and it probably used a different datatabase.

@Kabouik I've updated cmus-lyrics and this update should result in a slight performance enhancement, hopefully. Do test this one and give your valuable feedback please. And you are right about missing lyrics, there is nothing I can do there. You can contact @febuiles on the issue of missing lyrics. A great guy, he'll sure help you.
Cheers!!!

Will test, thanks again @hakerdefo.

@Kabouik thanks for bringing glyr to my attention.
makeitpersonal uses a single source to fetch the lyrics. I opened an issue to investigate running glyr as a service, but I haven't really worked in this codebase for years now. If I end up doing something about this, I'll make sure @hakerdefo is aware of the changes :)

Oh that would be truly awesome @febuiles, thanks for considering it!


Feature/and not

I think we should open the PR from the refactoring branch what do you think?

Closing this since everything has been merged in the refactoring branch and it is ready for the big replacement.


Allow client to set boltdb timeout

also in case of no persistent connection
Also fixing CI by bumping go version in .travis.yml

Related to https://github.com/docker/docker/issues/26251
Related to https://github.com/docker/libnetwork/issues/1374
Supersedes #135
Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM


fix ginkgo version

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y
fix #158

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

fix e2e test ginkgo version
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 73.733%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/parser/parser.go
3
75.0%

pkg/kusionctl/cmd/destroy/options.go
7
83.25%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4539

Relevant Lines:
6156

💛  - Coveralls


Add histogram chart to frequency of instruction page

This fixes #780. (no names in the chart, though, @gvwilson)

thanks - :+1: to merge


chore: update windows platform for flutter apps

#662  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Remove unused out-of-date file.

Does it make sense to remove other files too? Namely

local.properties
test-jars.xml
build-test.xml

If we want to go big, we could remove the whole test/java part and then flatten the structure from test/native to test.

Does it make sense to remove other files too? Namely

local.properties
test-jars.xml
build-test.xml

If we want to go big, we could remove the whole test/java part and then flatten the structure from test/native to test.

We should have a discussion for cleaning  those up or updating. But this deletion is out of that scope, these instructions are purely out of date and useless.

Ok.

Thanks @jajik


chore/MM-37187 : Upgrade only definetlyTyped packages without respective parent package updates

Summary
Updates all those type definition packages without their parent updates.
i.e
@types/foo -> updated
foo -> no new version

Ticket Link
https://mattermost.atlassian.net/browse/MM-37187
Related Pull Requests
~Has server changes (please link here)~
~Has mobile changes (please link here)~
Screenshots
none
Release Note

/release-note-none


azure: Add mutex to azure mock

Add mutex to avoid race condition in concurrent map writes.

I would just add the following to the start of every function in fakeClient
mutex.Lock()
dever mutex.Unlock()

Right now you're trying to do fine-grained locking which is going to lead to mistakes, just shove it around everything.

That was very silly mistake I made. Thanks for the tip. That's a much better idea..


Traffic Policy Mappings display N/A for Failure Policy

Description
Traffic Policy Mappings display N/A for Failure Policy whereas the Bind Page displays FAIL_OPEN.
QA manager suggested that we should be seeing FAIL_CLOSE instead of N/A on the Traffic Policy Mappings page.
Expected Behavior
User should see a consistent display of Failure Policy across Bind and Traffic Policy Mappings page.
Actual Behavior
Steps to Reproduce
Additional Information
Merged DE2958
Environment

OSC Version/Build: v2.5B4025
https://rally1.rallydev.com/slm/attachment/78766329308/Failure-Policy-NA.JPG
https://rally1.rallydev.com/slm/attachment/78766329400/Failure-Policy-FAIL-OPEN.JP
https://rally1.rallydev.com/slm/attachment/78766329532/Failure-Policy-NA-NSM.JPGG

Cloud Provider Info:

Plugin Info:

Other:

Status

[ ] Reproduced
[ ] In Progress
[ ] Validated     =>    Verified in Version/Build:

@alin2k please add the screenshots into github we cannot link to internal tools like rally or bugzilla etc

Here are screenshots from old Rally:

Updated screenshots, please close Triage/more-info.


updated Slovak translation

Hello. I updated Slovak translation. Can you please merge this? Thank you.

Thanks!


dnase_bias_estimator.py argument names

Hi Jason,
Thanks for putting together these excellent tools and making them so accessible. I've just downloaded pyDNase. When attempting to run dnase_bias_estimator.py I get a "namespace has no attribute genomesize" error. I believe the argument variable name is stored as "genomesize" (line 89) and then referred to as "genome_size" (line 96).
Best,
Drew

Thanks for this! Fixing in #17


docs: move cheatsheet *.md files to site-webdev

As agreed to with @kwalrath.
https://github.com/dart-lang/site-webdev/issues/571 is the corresponding webdev-side issue.

We'll do this after v3 goes gold.

@chalin @kwalrath Can this be closed? Still relevant?

Sorry, I forgot to link the PR: this issue is fixed by #373

Fixed by #373, which is now closed, so closing this issue too.


merger raises IndexError if zero sources

When the block methods generate zero sources, the merging step fails:
   Traceback (most recent call last):
    test_block_methods.py line 43 in test_sima
      model = strategy.fit(data, size=(30, 30))
    /home/patrick/code-checkouts/thunder/python/thunder/extraction/block/base.py line 77 in fit
      model = self.merger.merge(sources, keys)
    /home/patrick/code-checkouts/thunder/python/thunder/extraction/block/mergers.py line 21 in merge
      return SourceModel(sources)
    /home/patrick/code-checkouts/thunder/python/thunder/extraction/source.py line 235 in __init__
      elif isinstance(sources, list) and isinstance(sources[0], Source):
   IndexError: list index out of range

Fixed by https://github.com/thunder-project/thunder/commit/02709720604cf0b37ca167e71cd317c144535070


 I'd really appreciate some guidance.
How can I insert one or more blank lines between paragraphs in the PDF export?
If I do something like:
Lorem ipsum dolor sit amet

consectetur adipiscing elit

In the PDF export, those appear on consecutive lines with the second line indented. This is fine, but how I can manually insert a blank line between these?
I tried <br />, \\, \newline and half a dozen other things but nothing worked. Is this possible to do?
Thanks!

Thanks for your question. This is actually a LaTeX question since Softcover’s PDF output is processed directly with LaTeX. You can try something like this to see if it works:
\noindent Lorem ipsum dolor sit amet

\medskip

\noindent consectetur adipiscing elit

Thanks for replying so quickly! That indeed did the trick; I went with \bigskip but thanks so much for pointing me in the right direction.


Error 1071: Specified key was too long; max key length is 1000 bytes

Hello,
When trying to bootstrap a new cluster, I got an error 1071 : Specified key was too long; max key length is 1000 bytes .
I am using MySQL has backend : --storage-endpoint="mysql://"
Any suggestion ?
Regards,

I got the same error when using MariaDB 10.0.38 but once I upgraded to 10.4.12 it worked without issue.

Same after upgrading to MariaDB 10.4 no more issue

I'm seeing two versions reported, how does this compare to yours @mattmattox and @adi90x? This is from the Linode marketplace.
mariadb --version
mariadb  Ver 15.1 Distrib 10.1.48-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

I think 10.1.48-MariaDB is the key version there.


Make Portal and Vaults support Optional

Could you add a config option for whether one wants to use the Portals and Economy functionality? Or even better, just automatically test if those plug-ins are installed. And if not then could you please properly list those plug-ins as dependencies so that I don't get an error every time I start up my server? Thanks.

Economy can be disabled by setting cost to zero and portals doesn't require any dependencies

My bad the economy is needed I will fix this in a new update

Download the latest dev build from the target folder on the git repo main page


Changes to Cargo.toml don't trigger cargo check

Not sure if it's always the case, I have a workspace and Cargo.toml is manifest of subpackage. When I remove a dependency there, compilation errors don't appear until I make a noop edit to any *.rs file.

Triggering a check on any save to cargo.toml seems the simplest thing to do at first - that at least makes things less confusing because at the moment you edit cargo.toml and then have to edit and save a .rs file to trigger it currently.

That's leave rust-analyzer itself in an inconsistent state though --
completion won't work for new deps, etc.
The minimal useful change here is

detect that we might need a reload
show message to the user that a reload is required.

On Tue, 25 Feb 2020 at 12:02, Squirrel<EMAIL_ADDRESS>wrote:

Triggering a check on any save to cargo.toml seems the simplest thing to
do at first - that at least makes things less confusing because at the
moment you edit cargo.toml and then have to edit and save a .rs file to
trigger it currently.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/2868?email_source=notifications&email_token=AANB3M7CL5CWPGTE6K3DWMLRET3EHA5CNFSM4KIH6QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM3RAMQ#issuecomment-590811186,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3MYPPRJ4E5DC5GKZHDLRET3EHANCNFSM4KIH6QOA
.

I'm all for that - that's better than me guessing when I should invoke analyzer reload. :-)

Sorry, is this implemented or closed for other reason? I tried to track commits but couldn't see anything related...

this is implemented


export excel with style

hi , how do i export to excel and remain the style?  thanks in advance

you can use a third-party plugin for that.
https://sheetjs.com/


Develop new functions and add new samples for GridDB Node-api

Develop function to support MultiPut, MultiGet, FetchAll, QueryAnalysis, Null
Add samples to check functions above.

Thank you so much for your enhancement.
I'll confirm it.

Your enhancement is very useful.
So, I'll merge it.


.calledWith() returns true when no arguments are passed

Not sure if it works as design, but it doesn't seem like a consistent behavior, see the following code:
var sinon = require('sinon');

var obj = {
    fn: function () {
        return 1;
    }
};

var stub = sinon.stub(obj, 'fn');

obj.fn(3);

console.log(stub.calledWith(3));         // true
console.log(stub.calledWith(5));         // false
console.log(stub.calledWith(undefined)); // false

// all calls make sense but this one
console.log(stub.calledWith());          // true

Is it expected to work like this?

Well, it is supposed to match the specified arguments, bot requiring you to specify all of them. Taken to the extreme, this means that passing no arguments always returns true.
For exact argument matching, there is calledWithExact. It requires all the arguments to match.

Interesting, that makes sense to me. Feel free to close this then.
Thanks.


⚠ [IMPORTANT][Announcement] YARP devel branch freeze

TL;DR YARP DEVEL BRANCH FREEZE, DO NOT USE YARP DEVEL UNTIL FURTHER NOTICE
Hello all,
we are going to do some very important changes on the YARP repository, therefore all the PRs containing new features will have to wait until this is over, and will have to be rebased. Any unauthorized commit on YARP devel branch will be removed (using force push) therefore do not push anything on the devel branch, since you might lose your work.
PRs on the master branch (bug fixes) are still allowed, but please don't merge the master branch into devel (CC @pattacini).
Due to the undergoing changes, the devel branch might be temporarily broken, or missing some important feature, therefore I strongly suggest to switch all robots and all your clones to YARP master. Since we released YARP 2.3.72 a couple of days ago, master and devel are aligned, and new features are currently not allowed, therefore using master you are not missing any feature.
Please note that this is only a temporary issue, and that we are not planning to break the compatibility with previous versions.
I will add a comment and close this issue as soon as the freeze is over.

robotology/yarp#1551 was merged, this means that 3b2c4a3bccf4db0d926fc3c77e01ccb0d0b88a4e was the last "safe" commit if you are still using devel.

All functionalities should be restored, and the repository is no longer frozen. Sorry if it took so long.
If you have open pull requests for yarp devel, please rebase them over the latest commit.


Finish "easy" deduplication of builders

This abstracts the last of the "easy" functions in builders. Some builders (e.g. text classification and ABSA) now only define feature functions, which is nice.
FYI: my next steps are:

Doing some of the more non-trivial deduplication (where there are branching cases depending on the evaluation metric or single-metric vs. multi-metric, etc.)
I think now that the builders for each individual class are much simpler, the "processors" and "builders" can be merged together, so there's only a single file that users need to look at to understand how to implement a new task.
Code style: https://github.com/neulab/ExplainaBoard/issues/125

"I think now that the builders for each individual class are much simpler, the "processors" and "builders" can be merged together, so there's only a single file that users need to look at to understand how to implement a new task."

Sounds good to me!

It seems that these lines have been removed: https://github.com/neulab/ExplainaBoard/blob/650319fcc22d31591c9cd15ee055173637b14434/explainaboard/builders/kg_link_tail_prediction.py#L190
Not sure if this your intention or something unexpected.


Question

Will smooth boot becoming to 1.17?

Fabric release on Forge (1.16.5) works for 1.17.

The fabric 1.16.5 release also works for 1.17.1

Really? Great! Thanks for the info.

Could you maybe update the Forge version to 1.18 ? :(
I don't like it to load a ~400 mods pack without smooth boot. :(


drop instance_init per IsImplementable changes

@GuillaumeGomez The same might also be needed for gtk3-rs.

@GuillaumeGomez The same might also be needed for gtk3-rs.

I checked already and it's not needed


feature: Allow people to set their desired language via SMS

Overview
Language is set by an admin. This presumes that we know it, and that the translations are all of even quality. It also makes testing harder.
Scope
Add an additional command that allows listing and setting languages
Acceptance Criteria

[ ] I can do a command to see available langauges
[ ] I can set my language via SMS

Questions/Assumptions
Is this going to get really silly for SMS lengths if we add a dozen languages?

Do we want to send the list of languages in English? Or the member's current language?  Or the language's language?
Should we accept the chosen language in multiple languages?
We need some example text and commands to work against here.

Yeah OK this is a complicated ticket.
Maybe for v1 we just accept the country code?
So add this to the list (will need to do #87 first) "LANG: update your language"
Sending LANG then says
To set your language, send LANG followed by your country code.

For example: 'LANG ar'

Available languages are:

- Arabic (ar)
- English (en)
- French (fr)

A couple things:

we should treat the languages like postcodes -- first part match is fine if we only have one
is it possible to autogenerate the list of langauges in the language this gets translated to?
i think flag emojis would make this more readable esp if you get out your language but then what flag would we use for arabic?

let's talk it out a bit more before we get stuck in with others too