The evaluation function is read in an inconsistent way

I notice that h5py reads the dimensions [time,sz,sx,sy], while mat73, sigpy, and matlab read the dimensions [sy,sx,sz,time](in reverse order).If the read function uses h5py, why does the evaluation function use the last two dimensions as time and sz?

Also, here is my feedback after uploading the results. You can see that the docker code is evaluated using scio.loadmat, while the public GitHub code uses h5py.
STDERR: 2023-06-13T14:23:33.253508784Z 	Traceback (most recent call last):
STDERR: 2023-06-13T14:23:33.253513429Z 	  File "/app/Main_Score.py", line 1041, in
STDERR: 2023-06-13T14:23:33.253518744Z 	['MultiCoil', 'SingleCoil']
STDERR: 2023-06-13T14:23:33.253522667Z 	    main()
STDERR: 2023-06-13T14:23:33.253531669Z 	  File "/app/Main_Score.py", line 317, in main
STDERR: 2023-06-13T14:23:33.253535730Z 	    flag_folder_lax_04_Single, missing_folders_lax_04_Single, submit_folders_lax_04_Single, flag_file_lax_04_Single, different_sizes_lax_04_Single, missing_files_lax_04_Single, openfail_files_lax_04_Single, complete_folders_lax_04_Single, num_file_lax_04_Single = check_mapping_data(
STDERR: 2023-06-13T14:23:33.253540713Z 	  File "/app/Main_Score.py", line 216, in check_mapping_data
STDERR: 2023-06-13T14:23:33.253545633Z 	    flag_file, different_sizes, missing_files, openfail_files, complete_folders, num_file = check_mat_files(gt_dir, target_dir,
STDERR: 2023-06-13T14:23:33.253550506Z 	  File "/app/Main_Score.py", line 195, in check_mat_files
STDERR: 2023-06-13T14:23:33.253555171Z 	    dataset2 = loadmat(mat_file_path2)
STDERR: 2023-06-13T14:23:33.253560262Z 	  File "/app/loadFun.py", line 16, in loadmat
STDERR: 2023-06-13T14:23:33.253564910Z 	    mat_file = scio.loadmat(filename)
STDERR: 2023-06-13T14:23:33.253570258Z 	  File "/usr/local/lib/python3.9/site-packages/scipy/io/matlab/_mio.py", line 226, in loadmat
STDERR: 2023-06-13T14:23:33.253575446Z 	    MR, _ = mat_reader_factory(f, **kwargs)
STDERR: 2023-06-13T14:23:33.253580816Z 	  File "/usr/local/lib/python3.9/site-packages/scipy/io/matlab/_mio.py", line 74, in mat_reader_factory
STDERR: 2023-06-13T14:23:33.253585856Z 	    mjv, mnv = _get_matfile_version(byte_stream)
STDERR: 2023-06-13T14:23:33.253590881Z 	  File "/usr/local/lib/python3.9/site-packages/scipy/io/matlab/_miobase.py", line 251, in _get_matfile_version
STDERR: 2023-06-13T14:23:33.253596779Z 	    raise ValueError('Unknown mat file type, version %s, %s' % ret)
STDERR: 2023-06-13T14:23:33.253602206Z 	ValueError: Unknown mat file type, version 0, 0

And the evaluation code reads the mat field saying 'img4ranking', but the GitHub example reads only the 'data' field and doesn't specify it. Probably because of the first competition, these small problems delayed us a lot of time.
STDERR: 2023-06-13T15:18:30.968167600Z 	  File "/app/Main_Score.py", line 317, in main
STDERR: 2023-06-13T15:18:30.968169968Z 	    flag_folder_lax_04_Single, missing_folders_lax_04_Single, submit_folders_lax_04_Single, flag_file_lax_04_Single, different_sizes_lax_04_Single, missing_files_lax_04_Single, openfail_files_lax_04_Single, complete_folders_lax_04_Single, num_file_lax_04_Single = check_mapping_data(
STDERR: 2023-06-13T15:18:30.968172487Z 	  File "/app/Main_Score.py", line 216, in check_mapping_data
STDERR: 2023-06-13T15:18:30.968174704Z 	    flag_file, different_sizes, missing_files, openfail_files, complete_folders, num_file = check_mat_files(gt_dir, target_dir,
STDERR: 2023-06-13T15:18:30.968176925Z 	  File "/app/Main_Score.py", line 195, in check_mat_files
STDERR: 2023-06-13T15:18:30.968179067Z 	    dataset2 = loadmat(mat_file_path2)
STDERR: 2023-06-13T15:18:30.968181119Z 	  File "/app/loadFun.py", line 18, in loadmat
STDERR: 2023-06-13T15:18:30.968183216Z 	    dataset = mat_file['img4ranking']
STDERR: 2023-06-13T15:18:30.968185255Z 	KeyError: 'img4ranking'

We suggest you to run the demo recon code we provided to better know the requirement.
Besides, we will provide the directory structure and data dimensions of all gold standard data for the validation phase as a reference soon.
https://github.com/CmrxRecon/CMRxRecon/tree/main/CMRxReconDemo
[CMRxRecon.png]
CMRxRecon/CMRxReconDemo at main · CmrxRecon/CMRxReconhttps://github.com/CmrxRecon/CMRxRecon/tree/main/CMRxReconDemo
github.comhttps://github.com/CmrxRecon/CMRxRecon/tree/main/CMRxReconDemo
Best regards,
CMRxRecon Team
2023年6月13日 22:43，Breeze. @.***> 写道：
I notice that h5py reads the dimensions [time,sz,sx,sy], while mat73, sigpy, and matlab read the dimensions [sy,sx,sz,time](in reverse order).If the read function uses h5py, why does the evaluation function use the last two dimensions as time and sz?
—
Reply to this email directly, view it on GitHubhttps://github.com/CmrxRecon/CMRxRecon/issues/3, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3LGS632GLDL2H3HKJM6NQLXLB4BXANCNFSM6AAAAAAZE7ZJPM.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

The issue has been resolved. Please try resubmitting the task.
Best regards,
CMRxRecon Team
2023年6月13日 22:44，Breeze. @.***> 写道：
Also, here is my feedback after uploading the results. You can see that the docker code is evaluated using scio.loadmat, while the public GitHub code uses h5py.
STDERR: 2023-06-13T14:23:33.253508784Z Traceback (most recent call last):
STDERR: 2023-06-13T14:23:33.253513429Z File "/app/Main_Score.py", line 1041, in
STDERR: 2023-06-13T14:23:33.253518744Z ['MultiCoil', 'SingleCoil']
STDERR: 2023-06-13T14:23:33.253522667Z main()
STDERR: 2023-06-13T14:23:33.253531669Z File "/app/Main_Score.py", line 317, in main
STDERR: 2023-06-13T14:23:33.253535730Z flag_folder_lax_04_Single, missing_folders_lax_04_Single, submit_folders_lax_04_Single, flag_file_lax_04_Single, different_sizes_lax_04_Single, missing_files_lax_04_Single, openfail_files_lax_04_Single, complete_folders_lax_04_Single, num_file_lax_04_Single = check_mapping_data(
STDERR: 2023-06-13T14:23:33.253540713Z File "/app/Main_Score.py", line 216, in check_mapping_data
STDERR: 2023-06-13T14:23:33.253545633Z flag_file, different_sizes, missing_files, openfail_files, complete_folders, num_file = check_mat_files(gt_dir, target_dir,
STDERR: 2023-06-13T14:23:33.253550506Z File "/app/Main_Score.py", line 195, in check_mat_files
STDERR: 2023-06-13T14:23:33.253555171Z dataset2 = loadmat(mat_file_path2)
STDERR: 2023-06-13T14:23:33.253560262Z File "/app/loadFun.py", line 16, in loadmat
STDERR: 2023-06-13T14:23:33.253564910Z mat_file = scio.loadmat(filename)
STDERR: 2023-06-13T14:23:33.253570258Z File "/usr/local/lib/python3.9/site-packages/scipy/io/matlab/_mio.py", line 226, in loadmat
STDERR: 2023-06-13T14:23:33.253575446Z MR, _ = mat_reader_factory(f, **kwargs)
STDERR: 2023-06-13T14:23:33.253580816Z File "/usr/local/lib/python3.9/site-packages/scipy/io/matlab/_mio.py", line 74, in mat_reader_factory
STDERR: 2023-06-13T14:23:33.253585856Z mjv, mnv = _get_matfile_version(byte_stream)
STDERR: 2023-06-13T14:23:33.253590881Z File "/usr/local/lib/python3.9/site-packages/scipy/io/matlab/_miobase.py", line 251, in _get_matfile_version
STDERR: 2023-06-13T14:23:33.253596779Z raise ValueError('Unknown mat file type, version %s, %s' % ret)
STDERR: 2023-06-13T14:23:33.253602206Z ValueError: Unknown mat file type, version 0, 0
—
Reply to this email directly, view it on GitHubhttps://github.com/CmrxRecon/CMRxRecon/issues/3#issuecomment-1589455783, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3LGS66QE5ELE6NKWSCSAFTXLB4D7ANCNFSM6AAAAAAZE7ZJPM.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

You mentioned above that you will
"[provide] data dimensions of all gold standard data for the validation phase as a reference soon.
Are the dimensions of the gold standard data used in validation after cropping for each file already listed somewhere?
It would be nice to have access to one of the validation ground truth files to check if we are cropping the data correctly...


Tearsheet Statistics needs time-scale

Hi,
The tearsheet should have an axis label and ticks (years) for the "Cumulative Returns" and "Drawdown %" charts.
That would make reading the charts much easier.
Thanks in advance!
Dirk

Thanks - maybe I should have said this differently:
In the top 2 charts, I don't see the days/dates/months.
Example: The drawdown starts in which month according to the 2nd chart from the top?
Or am I looking at this all wrong?

You're right @DirkFR , those two charts should have it.


Errors while running tests

I am getting an error after running this step: pip install -e .

Also after running this step: python -m unittest

This is part of JOSS Review

The error with editable install is because Python requires the bundled C++ code to be compiled using Microsoft c++ build tools.
My intention for the unittests was to run the tests as follows. That way you don't need the compiler. I haven't worked out a good way of distributing the unittests through pip, so this seemed like the most sensible way to do it, given that most people won't be running unittests (unless you have any other suggestions?).
pip install patato
git clone https://github.com/BohndiekLab/patato
cd patato/tests
python -m unittest

P.s. I don't really recognise the ImportError that you get in your second screenshot, so please let me know if this doesn't solve the problems :)

@ASK-DataScience do you think this is an acceptable way to do this?

@tomelse I agree with you that most people won't be running unittests, but as a reviewer I should check if it is working correctly for me. Any suggestion on how to make it work? I followed your steps in the documentation.

Did you try the instructions in my previous comment? I.e. installing but not editable (pip install patato), then separately git checkout the repo and run the tests on that code

Otherwise you'd need to install the Microsoft C++ tools to compile the internal C++ code used for one of the algorithms

@tomelse I just tried the instructions in your previous comment (not editable) and I got the following error:

So looks like the first error is resolved, but we are still stuck with the second one.

What version of Python are you using?

patato is imported but still cannot run unittest

OK. Tests are finally working for me. But I had to install and run patato on the "base" environment instead of its own environment.

I suggest you add the option to run patato as not editable on the documentation page as well.

Thanks, I'll add that to the documentation.


[BUG]

Hello, I'm doing an npm install and I'm getting the following error:
error An unexpected error occurred: "https://codeload.github.com/WhiskeySockets/Baileys/tar.gz/07742e651e14ae481cc192051fa59b9c50c42bbb: Hostname/IP does not match certificate's altnames: Host: codeload.github.com. is not in the cert's altnames: DNS:dns.google, DNS:dns.google.com, DNS:*.dns.google.com, DNS:8888.google, DNS:dns64.dns.google, IP Address:<IP_ADDRESS>, IP Address:<IP_ADDRESS>, IP Address:2001:4860:4860:0:0:0:0:8888, IP Address:2001:4860:4860:0:0:0:0:8844, IP Address:2001:4860:4860:0:0:0:0:6464, IP Address:2001:4860:4860:0:0:0:0:64".
Can anyone help me?

BUG?????????????????????????????????????????????????????????

Yes!


Unavailable to install by Node v7.0.0 - node-inspector dependency cannot be installed

> node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(404): https://node-inspector.s3.amazonaws.com/debug/v0.7.7/node-v51-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v51 ABI) (falling back to source compile with node-gyp)
...

Seems like node-inspector issue only. Btw latest commit was on 9 April.
Is it possible to add this package as optional dependency?
My temporary solution:

rollback to Node v6.9.1
install node-inspector dependency globally
install electron-vibrancy

Anyway it's not working on Node v7.0.0 yet.

We actually don't need node-inspector for now so I've removed them in f237c11 on dev branch. Builds seem fine on both Travis and my machine. I can publish a new release. Does this look ok to you?

Just released v0.1.1. It should work on node v7.0.0 now. Let me know if there is a problem

I've tested on both machines - macbook pro and desktop pc - here is new issue seems (old issue gone)

Travis build for macOS on node v7.0.0 passes and on my Windows 10 too. Can you cd into 'electron-vibrancy` and  try running these in following order:
npm run conf
npm run rebuild
npm test

So I did it. It's works if you clone your project separately and will do  npm install  and / or
npm run conf
npm run rebuild
npm test

But I still get issue when I run like
npm install electron-vibrance
Let me try repeat and test this on my Windows 10. I will write here little bit later.

I see I actually didnt try on electron-quick-start yet.I think I know why it fails, I will look at it tomorrow. Sorry for the troubles.

First of all thank you very much for your work. I'm appreciate it. :)
About example of colored vibrance - please look airmail app
https://rink.hockeyapp.net/apps/84be85c3331ee1d222fd7f0b59e41b04
It's free for beta builds. Left sidebar looks like little different than default dark material view.

Hey, hopefully this is fixed now, can you verify?

Yep. Fixed. Thanks.

does this work on latest electron 14 build,  im getting this error
npm ERR! code 1
npm ERR! path /usr/local/lib/node_modules/electron-vibrancy
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! CXX(target) Release/obj.target/Vibrancy/src/Vibrancy.o
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using<EMAIL_ADDRESS>npm ERR! gyp info using<EMAIL_ADDRESS>| darwin | x64
npm ERR! gyp info find Python using Python version 3.7.0 found at "/Library/Frameworks/Python.framework/Versions/3.7/bin/python3"
npm ERR! (node:75753) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
npm ERR!  In file included from ../src/Vibrancy.cc:25:
npm ERR! In file included from ../src/./Vibrancy.h:28:
npm ERR! In file included from ../src/./Common.h:41:
npm ERR! In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:8:
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:503:1: error: expected unqualified-id
npm ERR! @class NSString, Protocol;
npm ERR! ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:505:9: error: unknown type name 'NSString'
npm ERR! typedef NSString * NSExceptionName NS_EXTENSIBLE_STRING_ENUM;
npm ERR!         ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:506:9: error: unknown type name 'NSString'
npm ERR! typedef NSString * NSRunLoopMode NS_EXTENSIBLE_STRING_ENUM;
npm ERR!         ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:508:19: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT NSString *NSStringFromSelector(SEL aSelector);
npm ERR!                   ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:509:44: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT SEL NSSelectorFromString(NSString *aSelectorName);
npm ERR!                                            ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:511:19: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT NSString *NSStringFromClass(Class aClass);
npm ERR!                   ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:512:53: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT Class _Nullable NSClassFromString(NSString *aClassName);
npm ERR!                                                     ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:514:19: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT NSString *NSStringFromProtocol(Protocol *proto) API_AVAILABLE(macos(10.5), ios(2.0), watchos(2.0), tvos(9.0));
npm ERR!                   ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:514:50: error: unknown type name 'Protocol'
npm ERR! FOUNDATION_EXPORT NSString *NSStringFromProtocol(Protocol *proto) API_AVAILABLE(macos(10.5), ios(2.0), watchos(2.0), tvos(9.0));
npm ERR!                                                  ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:515:19: error: unknown type name 'Protocol'
npm ERR! FOUNDATION_EXPORT Protocol * _Nullable NSProtocolFromString(NSString *namestr) API_AVAILABLE(macos(10.5), ios(2.0), watchos(2.0), tvos(9.0));
npm ERR!                   ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:515:61: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT Protocol * _Nullable NSProtocolFromString(NSString *namestr) API_AVAILABLE(macos(10.5), ios(2.0), watchos(2.0), tvos(9.0));
npm ERR!                                                             ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:519:30: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT void NSLog(NSString *format, ...) NS_FORMAT_FUNCTION(1,2) NS_NO_TAIL_CALL;
npm ERR!                              ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:519:53: error: format argument not an NSString
npm ERR! FOUNDATION_EXPORT void NSLog(NSString *format, ...) NS_FORMAT_FUNCTION(1,2) NS_NO_TAIL_CALL;
npm ERR!                              ~~~~~~~~~~~~~~~~       ^                  ~
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:98:49: note: expanded from macro 'NS_FORMAT_FUNCTION'
npm ERR!         #define NS_FORMAT_FUNCTION(F,A) __attribute__((format(__NSString__, F, A)))
npm ERR!                                                        ^                    ~
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:520:31: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT void NSLogv(NSString *format, va_list args) NS_FORMAT_FUNCTION(1,0) NS_NO_TAIL_CALL;
npm ERR!                               ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:520:63: error: format argument not an NSString
npm ERR! FOUNDATION_EXPORT void NSLogv(NSString *format, va_list args) NS_FORMAT_FUNCTION(1,0) NS_NO_TAIL_CALL;
npm ERR!                               ~~~~~~~~~~~~~~~~                ^                  ~
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:98:49: note: expanded from macro 'NS_FORMAT_FUNCTION'
npm ERR!         #define NS_FORMAT_FUNCTION(F,A) __attribute__((format(__NSString__, F, A)))
npm ERR!                                                        ^                    ~
npm ERR! In file included from ../src/Vibrancy.cc:25:
npm ERR! In file included from ../src/./Vibrancy.h:28:
npm ERR! In file included from ../src/./Common.h:41:
npm ERR! In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:10:
npm ERR! In file included from /System/Library/Frameworks/Foundation.framework/Headers/NSArray.h:5:
npm ERR! In file included from /System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:8:
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSZone.h:9:1: error: expected unqualified-id
npm ERR! @class NSString;
npm ERR! ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSZone.h:19:63: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT void NSSetZoneName(NSZone * _Nullable zone, NSString *name)NS_SWIFT_UNAVAILABLE("Zone-based memory management is unavailable");
npm ERR!                                                               ^
npm ERR! /System/Library/Frameworks/Foundation.framework/Headers/NSZone.h:20:19: error: unknown type name 'NSString'
npm ERR! FOUNDATION_EXPORT NSString *NSZoneName(NSZone * _Nullable zone) NS_SWIFT_UNAVAILABLE("Zone-based memory management is unavailable");
npm ERR!                   ^
npm ERR! In file included from ../src/Vibrancy.cc:25:
npm ERR! In file included from ../src/./Vibrancy.h:28:
npm ERR! In file included from ../src/./Common.h:41:
npm ERR! In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:10:
npm ERR! In file included from /System/Library/Frameworks/Foundation.framework/Headers/NSArray.h:5:
npm ERR!  System Darwin 17.7.0
npm ERR! gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /usr/local/lib/node_modules/electron-vibrancy
npm ERR! gyp ERR! node -v v16.1.0
npm ERR! gyp ERR! node-gyp -v v7.1.2
npm ERR! gyp ERR! not ok

npm ERR!      /Users/mac/.npm/_logs/2021-09-16T07_37_34_745Z-debug.log


Changed idea to project

@melanierichards
In the inspired by table, you have the Author column displaying a link. What should the users be linking to? Their github profile? Website? The Project column already links to the project. Perhaps that could be fine tuned a bit.
I think this inspired by page is a good idea. I was going to recommend having something like this but you beat me to it. I used the Spectrum color picker on a project and they have a similar page, which is what gave me the idea. The only downfall to something like this is maintenance, if you choose to maintain it. As time goes on, some of the user links will no longer be valid. Anyway, it's a good way to help people get exposure to their projects so that's a win in my book!

@thadseaver thanks for this language update! Based on your suggestions, I also clarified what the author name can link to.


Spark - improve test logging

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.70%. Comparing base (a97dae9) to head (3ed10b8).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3108   +/-   ##
=======================================
  Coverage   85.70%   85.70%
=======================================
  Files          54       54
  Lines        3112     3112
=======================================
  Hits         2667     2667
  Misses        445      445

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"Problem" drawer disappears on the Project Settings page when you collapse it

Describe the bug
Problems drawer disappears instead of collapses on the Bot Projects settings page. It also seems to return to the default height when you navigate from page to page.
Version

Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[x] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Collapse the Problems drawer by clicking on the down chevron. Here's the drawer open

When it is closed, it disappears altogether:

For the drawer height, on the other pages, it seems to return to the default height.

Go to the design page.

Expand the drawer:

Drag the top bar down to reduce its height:

Navigate to another page. The drawer seems to return to its default height:

Expected behavior
I expected the drawer height to persist across pages.
Screenshots

Additional context

Version:  1.3.1-nightly.219396.61c944a
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Assigning to @benbrown as its going to be resolved with the dashboard refactor.

Resolved by #6121


Remove the multivariate test of the alternate "report-a-problem" design

The test has now run for several weeks and has generated more than enough data to allow us to judge the goodness of the new design.
This is a direct revert of the two PRs that added the new design.
/cc @fofr

@fofr should some of the improvements that you made to the original RaP in these two PRs be carried across?

I don't see any improvements to the original in these PRs other than some whitespace in the stylesheets.


Search extension shouldn't be installed automatically

The search extension is installed automatically. This is an issue, as this means the extension will not work if Chrome gets modified to automatically remove that extension (side-loading extensions is not supported by Chrome, see: https://blog.chromium.org/2013/11/protecting-windows-users-from-malicious.html).
If somebody intentionally installs the extension, they will lose access to the extension when Chrome gets updated to automatically remove the extension as Chrome will have no idea whether somebody did install extension intentionally or not.
This means that even businesses that want to install the Bing extension won't be able to.
Please don't apply extension automatically, this is very likely to break the extensions for companies that actually want to use it.

Based on customer feedback, we're making some changes to the plan to roll out the extension for Microsoft Search in Bing. For information about the changes, read this announcement. This article will be updated when more details are available.


Change IE 8 / 9 Fullscreen tooltip text

Hello,
I opened a stackoverflow question (http://stackoverflow.com/questions/18063189/mediaelements-change-ie8-overlay-text) for this but got no answer so I thought I try it through an Issue.
The way to open the fullscreen mode in IE8 is not very clear and I wanted to change the text that is displayed to something like "Click here for Fullscreen". However the text seems to not be changeable by the i18n features of mediaelements.
Is there a way to change this text from the javascript code or is this part of the flash player and can only be changed there? If so is this easily possible?
Thank you for your help.

@cedrics Closing old issues. If you'd like to reopen this, let us know. Thanks!


Apply window unit tests

Codecov Report

Merging #19 into master will increase coverage by 3.69%.
The diff coverage is 99.52%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   88.68%   92.38%   +3.69%
==========================================
  Files          13       13
  Lines         884     1077     +193
==========================================
+ Hits          784      995     +211
+ Misses        100       82      -18


branch_protection_rule event type not available

I was looking into the event - https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#branch_protection_rule
and couldn't find an associated event type under -
https://github.com/google/go-github/blob/master/github/event_types.go
Is it missing ?

Yes, I believe you are correct. We have GetBranchProtection but we don't appear to support the event type.
Would you like to add it, or would you like me to open up this issue to other contributors to this repo so that they will add it?

Thank you @gmlewis. I'll submit a change for it!


fix(test/e2e/kubernetes): Bring k8s e2e tests to parity with bash tests

closes #1278
add tests for heapster, kube-addon-manager, kube-apiserver, kube-controller-manager, kube-scheduler, tiller
adds logic for dynmamically running the linux and windows agent tests
assertions made about node count use the cluster definition to determine the expected count

@jchauncey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


CBOR.me indicates a type error for payload type

18(
   [
      h'A301384C...4A392330',
      {},
      64(h''), // payload is not a typed array.... it should be just h''
      h'0766FF02...661F9393'
   ]
)

fixed this a while ago


Friendly Validation Error Message W/ Nodebalancer

update createNodeBalancerConfigSchema object with friendly validation
error message surrounding HTTP Path and or HTTP Body RegEx
update UpdateNodeBalancerConfigSchema object with friendly validation
error message surrounding HTTP Path and or HTTP Body RegEx

Resolves: fix/nodebalancer-validation-errors-msg
Description
First let me give huge kudos!  Getting this project up and running was a breeze and super phenomenal!  I also really enjoyed scratching a bit of my old-skool JavaScript dev itch, so much has changed with the introduction of typescript, react, plus just in general a ton of other really neat things!  I also dig how the OAuth Apps pattern works with the .env file, like really, this was a blast to get running from fork-to-local-dev, it's so rare to have that - PROPS!
Currently in Prod, when there is a given error surrounding a missing field validation on the HTTP Path and/or HTTP Body Regular Expression the validation message error is echoed as:
# For HTTP Path
configs[0].check_path is a required field
# For HTTP Body
configs[0].check_body is a required field

This PR Allows for a more friendly way to echo errors back out surrounding Active Health Checks on Nodebalancer either via creation or updating a given Nodebalancer.  This removes the given configs[0] based array/list lookup at first index check_path or check_body reference that currently is echoed out in prod as validation error message.  The text replacement exists as:
# For HTTP Path
An HTTP Path is required
# For HTTP Body
An HTTP Body RegEx is required

How to test
Visually audit via attached pictures or feel free to spin up branch, this is a text change, no function impact

@bnussman good catch!  I'll push up a commit to lowercase things to follow the pattern :)

@bnussman , I've adjusted the casing and closed the validation error message with a "." (period) much like how all the others are within the update and create schemas - re-requested review if ya wanna take a peek :) - you had a great point and I hope these changes help follow the pattern a little cleaner


Use poetry

Poetry will allow us to lock dependencies so we can automatically produce the security manifests that the security team requires for the platform.

Bonfire failure keeps the test from passing. Other tests within pr_check worked


Sidebar shows on mobile even when showSidebar: false

What happens?
Sidebar shows on mobile even when showSidebar: false
What did you expect to happen?
Header and sidebar to not show on mobile when showSidebar: false
How can we reproduce the issue?
set showSidebar: false, and open on mobile
Swagger/OpenAPI Example
No response

Hey @paulmeller I'll take a look at that right now

hi @paulmeller I was unable to get the sidebar to show up when you set it to false, could you show me an example and which versions you were using? I did however fix the header not showing

It I just the header, but, the hamburger made it look like it sidebar too. Thanks!


fix: require binary upload before binary download

Signed-off-by: Asra Ali<EMAIL_ADDRESS>This is causing me failures: https://github.com/asraa/slsa-example/actions/runs/2502778013
build / upload-assets
Unable to find an artifact with the name: binary-linux-amd64
This is because binary-upload is not required for the upload-assets job.

Yep: This run https://github.com/asraa/slsa-example/actions/runs/2502778013

unless the testing framework has some configuration to avoid the problem.

There is a testing SetEnv that does cleanup after each test run, let me see if I can update the tests here to use that
https://cs.opensource.google/go/go/+/go1.18.3:src/testing/testing.go;l=1280

Oh, it is between tests too :/

unless the testing framework has some configuration to avoid the problem.

There is a testing SetEnv that does cleanup after each test run, let me see if I can update the tests in another PR to use that https://cs.opensource.google/go/go/+/go1.18.3:src/testing/testing.go;l=1280

Awesome!


Firestore crash when setting a document

[REQUIRED] Step 2: Describe your environment

Xcode version: 9.4.1
Firebase SDK version: 5.3.0
Firebase Component: Firestore
Component version: 0.12.4

[REQUIRED] Step 3: Describe the problem
App crashes upon setting a document to firestore. Xcode logs the following error:
2018-08-08 14:04:23.002244-0700 sesh[11461:139254] *** Assertion failure in -[GRPCHost setTLSPEMRootCerts:withPrivateKey:withCertChain:error:], /Users/alexic/react-native/sesh/ios/Pods/gRPC/src/objective-c/GRPCClient/private/GRPCHost.m:179
2018-08-08 14:04:23.026151-0700 sesh[11461:139254] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not read gRPCCertificates.bundle/roots.pem. This file, with the root certificates, is needed to establish secure (TLS) connections. Because the file is distributed with the gRPC library, this error is usually a sign that the library wasn't configured correctly for your project. Error: Error Domain=NSCocoaErrorDomain Code=258 "The file name is invalid."'
*** First throw call stack:
(
	0   CoreFoundation                      0x0000000116af41e6 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x000000011557e031 objc_exception_throw + 48
	2   CoreFoundation                      0x0000000116af9472 +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x00000001109b5652 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 193
	4   sesh                                0x000000010f0ac968 -[GRPCHost setTLSPEMRootCerts:withPrivateKey:withCertChain:error:] + 744
	5   sesh                                0x000000010f0ad650 -[GRPCHost newChannel] + 192
	6   sesh                                0x000000010f0ac399 -[GRPCHost unmanagedCallWithPath:serverName:timeout:completionQueue:] + 281
	7   sesh                                0x000000010f0aff71 -[GRPCWrappedCall initWithHost:serverName:path:timeout:] + 417
	8   sesh                                0x000000010f0a967f -[GRPCCall startCallWithWriteable:] + 223
	9   sesh                                0x000000010f0a9a99 -[GRPCCall startWithWriteable:] + 601
	10  sesh                                0x000000010ec9e936 -[FSTStream resumeStartWithToken:] + 1478
	11  sesh                                0x000000010eca69da ___ZZ31-[FSTStream startWithDelegate:]ENK3$_0clEN8firebase9firestore4util8StatusOrINS1_4auth5TokenEEE_block_invoke + 42
	12  sesh                                0x000000010ebac6d4 _ZZ51-[FSTDispatchQueue dispatchAsyncAllowingSameQueue:]ENK3$_2clEv + 36
	13  sesh                                0x000000010ebac69d _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZ51-[FSTDispatchQueue dispatchAsyncAllowingSameQueue:]E3$_2EEEvDpOT_ + 45
	14  sesh                                0x000000010ebac469 _ZNSt3__110__function6__funcIZ51-[FSTDispatchQueue dispatchAsyncAllowingSameQueue:]E3$_2NS_9allocatorIS2_EEFvvEEclEv + 41
	15  sesh                                0x000000010eba8b7b _ZNKSt3__18functionIFvvEEclEv + 123
	16  sesh                                0x000000010eb4516c _ZN8firebase9firestore4util10AsyncQueue15ExecuteBlockingERKNSt3__18functionIFvvEEE + 476
	17  sesh                                0x000000010eb47af7 _ZZN8firebase9firestore4util10AsyncQueue4WrapERKNSt3__18functionIFvvEEEENK3$_0clEv + 39
	18  sesh                                0x000000010eb47abd _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZN8firebase9firestore4util10AsyncQueue4WrapERKNS_8functionIFvvEEEE3$_0EEEvDpOT_ + 45
	19  sesh                                0x000000010eb47879 _ZNSt3__110__function6__funcIZN8firebase9firestore4util10AsyncQueue4WrapERKNS_8functionIFvvEEEE3$_0NS_9allocatorISB_EES7_EclEv + 41
	20  sesh                                0x000000010eba8b7b _ZNKSt3__18functionIFvvEEclEv + 123
	21  sesh                                0x000000010eb559f1 _ZZN8firebase9firestore4util8internal13DispatchAsyncEPU28objcproto17OS_dispatch_queue8NSObjectONSt3__18functionIFvvEEEENK3$_0clEPv + 33
	22  sesh                                0x000000010eb559c8 _ZZN8firebase9firestore4util8internal13DispatchAsyncEPU28objcproto17OS_dispatch_queue8NSObjectONSt3__18functionIFvvEEEEN3$_08__invokeEPv + 24
	23  libdispatch.dylib                   0x000000011833b7ec _dispatch_client_callout + 8
	24  libdispatch.dylib                   0x0000000118343be5 _dispatch_queue_serial_drain + 1305
	25  libdispatch.dylib                   0x00000001183444fa _dispatch_queue_invoke + 328
	26  libdispatch.dylib                   0x0000000118340344 _dispatch_queue_override_invoke + 726
	27  libdispatch.dylib                   0x000000011834736c _dispatch_root_queue_drain + 664
	28  libdispatch.dylib                   0x0000000118347076 _dispatch_worker_thread3 + 132
	29  libsystem_pthread.dylib             0x0000000118866169 _pthread_wqthread + 1387
	30  libsystem_pthread.dylib             0x0000000118865be9 start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Relevant Code:
Setting any document results in this error and crashes the app.

You've managed to build gRPC without including its certificate bundle. This has nothing to do with Firestore specifically, but how your Xcode project is configured. If you're using Cocoapods this should just work.
If you're building with Carthage, you should follow our instructions here: https://github.com/firebase/firebase-ios-sdk/blob/master/Carthage.md

I am using Cocoapods, any idea as to how it could have been misconfigured? I tried deleting my pods folder and reinstalling my dependencies and it still doesn't work.

or--how can i configure it correctly

In general with cocoapods you shouldn't have to do anything. Make sure you're using the workspace and not your original project and everything should be good to go. Within the workspace and in the Pods project you should see that the gRPC target has a build phase that includes copying the bundle.

Mine actually doesn't have that phase:

I was so happy to see that you are in the exact same state as I am...
Was so disappointed to see no response :(
I've been searching all day long to make that gRPC's gRPCCertificates.bundle build in the directory with the other Pods...

@TwistedMinda For static library pod installations, the resource copy happens in the app build phase instead of the Pod build phase -

Yes I know that for sure!
But still the file "$(PODS_CONFIGURATION_BUILD_DIR)/gRPC/gRPCCertificates.bundle" can't be found because it is created in my : Staging-iphoneos/ instead of Release-iphoneos/, and this is the only file doing that, all my other Pods build as I want in my Release-iphoneos/
therefore "$(PODS_CONFIGURATION_BUILD_DIR)", which points towards my Release-iphoneos/, won't find the Staging-iphoneos/gRPC/gRPCCertificates.bundle...
And i'm stuck here. I have no way to choose where GRPC will "pop" the certificate.bundle
Help me please

@TwistedMinda This sounds more like an issue with your particular project or perhaps CocoaPods usage or installation than with Firebase. Your description might be sufficient to get an answer on stackoverflow.
Either way, you may to share a reproducible example to get more help.

Well, finally I got it to work, I was missing the part of creating a new scheme, I was only creating a new build configuration and was not enough, but I still have the same problem as the creator of this conversation had...
It crashes whenever i call firebase.firestore(), but NOT when i call firebase.messaging(), this must be a Firebase issue, no?
Thanks again for your answers, i feel less alone in this desperate situation!


LP Workbench (Owner undefined) / Deepbit share count doesnt reset itself

Deepbit share count doesnt reset despite being recognised as a deepbit Block.
LP Workbench doesnt recognise the owner.
http://i.imgur.com/s5rdG.jpg
03:54:40|lp: New Block:<PHONE_NUMBER>000019257e811e879a2d9d0bcc45f295d9ffa962e6d060eb45d0ba
03:54:40|lp: Block Owner deepbit
Traceback (most recent call last):
File "/home/ivan/bitHopper/lp.py", line 144, in add_block
hook_start.notify(self, block, work, server)
File "/home/ivan/bitHopper/peak/util/plugins.py", line 58, in notify
for hook in self.query(*args, **kw):
File "/home/ivan/bitHopper/peak/util/plugins.py", line 68, in query
yield hook(*args)
File "/home/ivan/bitHopper/plugins/lpdump/lpdump.py", line 41, in on_block
fd = open(self.file_name, 'brwa+')
ValueError: mode string must begin with one of 'r', 'w', 'a' or 'U', not 'brwa+'
03:54:41|lpbot: New Block: {deepbit} -<PHONE_NUMBER>000019257e811e879a2d9d0bcc45f295d9ffa962e6d060eb45d0ba

Disable lpblock for now. Its dieing and breaking the setup stream. I'll take a look and try and fi xit.

This should be fixed. I changed the file write mode.


Service account support (JWT signing with RS256)

To call Google Cloud APIs, it would be very useful to have a way to get OAuth tokens for Google Cloud service accounts.
The authentication process is described here, but so far I have not found appropriate Swift libraries to use for this or for the key step of signing the request JWT token using RSA SHA-256.
In other contexts, Google engineers have strongly discouraged implementations of this for client-side authentication because clients are unable to effectively protect service account private keys.
But this would be primarily to support server-side Swift.

Initial support for this is in the rs256 branch.

Merged in PR #3.


Request: Make Normalize Size gaze work as stated.

Normalize Size (Aeon Gaze) states that it keeps ally's size bonuses (except reach and visual size change), but removes size penalties. I find that it erroneously suppresses spells like Enlarge/Reduce Person and Legendary/Microscopic proportions, getting rid of both the penalties AND bonuses on allies. On enemies, I've not yet tested if it works similarly and would thus erroneously remove their size penalties from being Enlarged, or their strength+CMD penalties from being Reduced.

Can you clarify what the issue is? This worked in my experence
On Fri, Jun 10, 2022, 11:50 PM FrijDom @.***> wrote:

—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/448, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWSQPF2GEQ5RJJ2VU6R2U3VOQLINANCNFSM5YPPH2JQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Normalize size is not supposed to remove the strength and constitution boosts from Legendary Proportions. It does as of now.


Tags not selectable when starting a timer in another web app

OS version: Mac OS 12.6
Browser version: Chrome 106.0.5249.119
Extension version: 2.0.17

Relevant integration (if any):
I have tested this with Slack due to a user report, but also tested with Asana to see if it is app-specific, but the issue is the same.
🐛 Describe the bug
Tags are greyed out and can not be selected:
https://user-images.githubusercontent.com/36152180/197731254-d486fdb7-a07c-40c0-bc30-c9cccca56584.mov
Expected behaviour
Users should be able to select tags
Steps to reproduce
Steps to reproduce the behavior:

Enable an integration with another app, for example, Slack or Asana
Start a timer from the app you enabled the integration with
Try selecting a tag

case reference


Please make 2022 edition layman friendly!

Hi,
I really loved the concepts in this book, but the only thin which stopped me from using it was creating a one big game rather than small chunks of games which use these patterns, as well if possible, please remove the namespaces it confuses newcomers alot.
Could this be updated in upcoming 2022 edition ?

Hello, thank you for the feedback; it's very appreciated.
May I ask how the namespaces cause you confusion exactly?
And could you show me an example of how the namespaces were a blocker for you and the project you are working on?

Hi,
I really loved the concepts in this book, but the only thin which stopped me from using it was creating a one big game rather than small chunks of games which use these patterns, as well if possible, please remove the namespaces it confuses newcomers alot.
Could this be updated in upcoming 2022 edition ?

A single name space, as if its a real-world project. But when you were naming them as per namespace Chapter.xyz it was becoming confusing and how one should continue with it in next chapter.
Maybe if you could name them in such way:
Scripts

XyzFolder -> namespace xyz
newFolder -> namespace newFolder

Im not sure if this works, but my intention is Keep a same namespace and continue it till the end, and not chapter wise.

To be honest I'm not too sure I understand the issue. But I'll think about it.
But are you having issues because you are trying to build your own project directly on top of the codebase that's in the repo?


nix-prefetch fails:  experimental Nix feature 'flakes' is disabled

https://github.com/m15a/flake-awesome-neovim-plugins/actions/runs/8952064248/job/24589055860#step:5:1952
update.fnl: extra hash (cargoSha256): github.com/michaelb/sniprun
warning: unknown setting 'upgrade-nix-store-path-url'
warning: unknown setting 'upgrade-nix-store-path-url'
error:
       … <borked>

         at «none»:0: (source not available)

       … in the left operand of the update (//) operator

         at /nix/store/dxrf39afi5ijvlyrfymjg3b18vqj7irn-nix-prefetch-0.4.1/lib/nix-prefetch/prelude.nix:3:46:

            2|
            3| let prelude = with prelude; import ./lib.nix // {
             |                                              ^
            4|   fetcher = if orig.fetcher == null || elem orig.fetcher.type [ "file" "attr" ]

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: experimental Nix feature 'flakes' is disabled; use '--extra-experimental-features flakes' to override
Error: fnl: [ERROR] failed to run nix-prefetch

It still fails: https://github.com/m15a/flake-awesome-neovim-plugins/actions/runs/9020922496/job/24787121024#step:5:1939


throwing exception on h2c upgrade

I occasionally see a failure when I'm doing an h2c upgrade, although not very frequently.
The exception looks like:
WAR [20171004-22:30:36.811] twitter: Unhandled exception in connection with /<IP_ADDRESS>:40092, shutting down connection
WAR [20171004-22:30:36.811] twitter: io.netty.handler.codec.http2.Http2Exception: Attempting to return too many bytes for stream 0
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2Exception.connectionError(Http2Exception.java:85)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2Exception.streamError(Http2Exception.java:128)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.DefaultHttp2LocalFlowController$DefaultState.returnProcessedBytes(DefaultHttp2LocalFlowController.java\
:432)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.DefaultHttp2LocalFlowController$DefaultState.consumeBytes(DefaultHttp2LocalFlowController.java:441)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.DefaultHttp2LocalFlowController.consumeBytes(DefaultHttp2LocalFlowController.java:190)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2FrameCodec.consumeBytes(Http2FrameCodec.java:315)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2MultiplexCodec.onBytesConsumed(Http2MultiplexCodec.java:384)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2MultiplexCodec$DefaultHttp2StreamChannel$Http2ChannelUnsafe.doRead0(Http2MultiplexCodec.java:947)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2MultiplexCodec$DefaultHttp2StreamChannel.fireChildRead(Http2MultiplexCodec.java:734)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2MultiplexCodec.onHttp2StreamFrame(Http2MultiplexCodec.java:286)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2MultiplexCodec.onHttp2Frame(Http2MultiplexCodec.java:221)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2FrameCodec$FrameListener.onDataRead(Http2FrameCodec.java:527)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.InboundHttpToHttp2Adapter.handle(InboundHttpToHttp2Adapter.java:67)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http2.Http2FrameCodec.userEventTriggered(Http2FrameCodec.java:250)
WAR [20171004-22:30:36.811] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:329)
WAR [20171004-22:30:36.811] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:315)
WAR [20171004-22:30:36.811] twitter:     at io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:307)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler$1.operationComplete(HttpServerUpgradeHandler.java:329)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler$1.operationComplete(HttpServerUpgradeHandler.java:318)
WAR [20171004-22:30:36.811] twitter:     at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:507)
WAR [20171004-22:30:36.811] twitter:     at io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:481)
WAR [20171004-22:30:36.811] twitter:     at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:420)
WAR [20171004-22:30:36.811] twitter:     at io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:163)
WAR [20171004-22:30:36.811] twitter:     at io.netty.channel.DefaultChannelPromise.addListener(DefaultChannelPromise.java:93)
WAR [20171004-22:30:36.811] twitter:     at io.netty.channel.DefaultChannelPromise.addListener(DefaultChannelPromise.java:28)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler.upgrade(HttpServerUpgradeHandler.java:318)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler.decode(HttpServerUpgradeHandler.java:239)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler.decode(HttpServerUpgradeHandler.java:40)
WAR [20171004-22:30:36.811] twitter:     at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88)
WAR [20171004-22:30:36.811] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)

And it comes from here:
        private void returnProcessedBytes(int delta) throws Http2Exception {
            if (processedWindow - delta < window) {
                throw streamError(stream.id(), INTERNAL_ERROR,
                        "Attempting to return too many bytes for stream %d", stream.id());
            }
            processedWindow -= delta;
        }

Any idea what's going on here?  Is the issue that the client isn't respecting flow control?

Also what stream has stream id 0?

It looks like ConnectionStream has stream id 0 trying to figure out what that means in context of everything else.

OK, so it looks like that means it's not an error specific to a single stream, but instead an error with the overall connection?
     * @return If the {@code id} is not
     * {@link Http2CodecUtil#CONNECTION_STREAM_ID} then a {@link Http2Exception.StreamException} will be returned.
     * Otherwise the error is considered a connection error and a {@link Http2Exception} is returned.

I think I've figured out the problem.  In the http/2 upgrade, we upgrade the http/1.1 message to http/2
InboundHttpToHttp2Adapter.handle(ctx, connection(), decoder().frameListener(), upgrade.upgradeRequest().retain());

However, I don't think the h2c upgrade message, which is an http/1.1 message with the upgrade:h2c header, should not be eligible for flow control.  The spec isn't super clear here however.
@normanmaurer @Scottmitch @ejona86 any idea what we should do here?

Yeah, the request is fully received (half closed) and so doesn't need any flow control. The response follows flow control like normal.
This problem would happen reliably with PUT/POST, but wouldn't be triggered by the GET/OPTIONS that we typically see.
This seems to be a problem with the InboundHttpToHttp2Adapter abstraction: it doesn't work with consumeBytes, but it does correctly throw away the onDataRead return value which is the simpler form of flow control. Worst-case, I guess we could hack Http2FrameCodec.consumeBytes to do nothing when it's the upgrade stream, say, with logic like streamId == 1 && stream.getProperty(upgradeKey) (we'd create upgradeKey; it doesn't exist now). Doing it "right" looks pretty ugly; if we leave InboundHttpToHttp2Adapter as-is it deserves a warning.

Cool, what do you think the next step should be?  Adding this hack?  And right now the only work-around I can think of is extending Http2MultiplexCodecBuilder . . . anything else I could plausibly do?

I've also found
WAR [20171006-20:49:51.503] twitter: java.lang.IllegalArgumentException: Invalid value for te: deflate,gzip;q=0.3
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http2.HttpConversionUtil.toHttp2Headers(HttpConversionUtil.java:423)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http2.HttpConversionUtil.toHttp2Headers(HttpConversionUtil.java:399)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http2.InboundHttpToHttp2Adapter.handle(InboundHttpToHttp2Adapter.java:61)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http2.Http2FrameCodec.userEventTriggered(Http2FrameCodec.java:250)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:329)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:315)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:307)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler$1.operationComplete(HttpServerUpgradeHandler.java:329)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler$1.operationComplete(HttpServerUpgradeHandler.java:318)
WAR [20171006-20:49:51.503] twitter:     at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:507)
WAR [20171006-20:49:51.503] twitter:     at io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:481)
WAR [20171006-20:49:51.503] twitter:     at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:420)
WAR [20171006-20:49:51.503] twitter:     at io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:163)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.DefaultChannelPromise.addListener(DefaultChannelPromise.java:93)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.DefaultChannelPromise.addListener(DefaultChannelPromise.java:28)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler.upgrade(HttpServerUpgradeHandler.java:318)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler.decode(HttpServerUpgradeHandler.java:239)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.http.HttpServerUpgradeHandler.decode(HttpServerUpgradeHandler.java:40)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:438)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
WAR [20171006-20:49:51.503] twitter:     at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:253)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
WAR [20171006-20:49:51.503] twitter:     at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
WAR [20171006-20:49:51.503] twitter:     (...more...)

Which makes it seem like we should be stripping more headers here.  The only valid TE header is "trailers".

Adding the hack sounds good to me. It's quick and easy. We can fix it up better if/when we figure out an alternative.
As far as workarounds... If patching Netty isn't an option, then yeah, extending Http2MultiplexCodecBuilder is probably about the only option.

@mosesn ping

@normanmaurer I've been busy with shipping something, haven't had a chance to look at this yet, but I'm still happy to add the hack when I have time.  I was able to work around this by extending the bejeezus out of Http2MultiplexCodecBuilder.

@mosesn could you be more specific how did you extend Http2MultiplexCodecBuilder to workaround this issue?  Thanks.

@ximyu sure, I have an open source copy you can take a look at: https://github.com/twitter/finagle/blob/develop/finagle-http2/src/main/scala/io/netty/handler/codec/http2/UpgradeMultiplexCodecBuilder.scala

Ah, I see. Thanks a lot for sending the code snippet.  Having to put this class under package io.netty.handler.codec.http2 is really annoying :)

@mosesn so you think this is also what we should do in netty ?

@normanmaurer yep, but we should have something nice around it so we only do it for the h2c upgrade (and not the prior knowledge or alpn upgrades).

I have most of a fix here, but I need a bit more help with testing it: https://github.com/netty/netty/pull/7400


[bug]: Accessibility/A11y: Heading with Subheading should not be recognised as 2 separate headings by screenreader.

Describe the bug
When using a heading with subheading, NVDA recognises the main heading and subheading as 2 separate headings. It seems, that there are e.g. 2x h1 headers, or 2x h2 headers and so on.
To Reproduce
Steps to reproduce the behavior:

Go to https://design-system.post.ch/?path=/docs/7ecd87f1-de96-4e39-a057-ba1798eb6959--docs#heading
Activate Subheading
The example code will show up like this:

 Heading

  Subheading

Expected behavior
If you create the heading with subheading as following (in this example bootstrap css classes are used, but if you want to get independent of bootstrap, then use a background css equivalent for the structure of all hx-variants maybe?) then it looks the same as before, but a screen-reader does recognise the main- and sub-heading as one hx-tag.

Paketetiketten Inland
Erstellen Sie Etiketten für den Paketversand innerhalb der Schweiz

Note the optional h2 css-class on the second span. It is necessary, if one uses the same h2 css-class on the h1 tag, otherwise it would show up bigger than the main-heading. (h2-class would be used to make both together look different, for hierarchical reasons)

Hoi @aedu-hostettler, thanks for submitting this bug. Indeed, the
 is the culprit here. As a workaround, I would propose to use

  Heading
  Subheading

While we're trying to remove bootstrap as a dependency, we're also trying to keep the breaking changes to a minimum. Utility classes like the one you used here will most likely be provided as is.
I can't reproduce the issue where the subheading is bigger if the .h2 is only used on the parent element. Without any other influence, the span with .fw-light should inherit other font properties like font-size.


Issue Number: #34 Adding suitable icons for different sections in the navbar

Added Suitable icons for different sections such as about, blogs , home etc:-

@Suchitra-Sahoo  I have made the pull request . Kindly review it

Mention your issue number

@Suchitra-Sahoo  mentioned

Mention you issue number in comments to avoid confusion in issue no/ PR no


Update request: ArmCord 3.2.8 → 3.3.0

Package name: armcord
Latest released version: 3.3.0

Current version on the unstable channel: 3.2.8
Current version on the stable/release channel: 3.2.7

[x] Checked the nixpkgs pull requests

Notify maintainers

@wrmilling

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Unstable is currently waiting on Electron 32 to be added to nixpkgs to be able to update to 3.3.0.
We may be able to update Stable before then since it is using the compiled packages.
@SelfMadeSystem Which are you running currently (Stable vs Unstable)?

I'm currently using unstable.

Got it, once we have electron 32 available it should be a fairly quick package / release.

I attempted to package this using Electron 31 since that's available, and it seems to be working stably. I looked at the ArmCord source and it doesn't look like it relies on anything Electron 32-specific, so I'll try to put out a PR.


fix(android-studio): delete symlink in removescript

On a side note, should this package be called "android-studio-bin"? Since it is not compiled but only binaries installed.

No. -bin packages contain a single binary, and sometimes a desktop file. This is more complex, so it is not a -bin package.

No. -bin packages contain a single binary, and sometimes a desktop file. This is more complex, so it is not a -bin package.

I see. Thank you for the explanation


gh: updates from v2.55.0

How do you manage to notice such small wording difference?
A new option will be documented in the changelog. But this?

I've got a couple Scrapers for various frameworks.
GitHub CLI is open source and uses cobra.
Same as carapace so in this case all I have to do is:
add carapace as dependency
carapace.Gen(rootCmd)

compile and generate the yaml spec
gh _carapace spec > new.yaml

compare it with the current version using a diff tool to see which files changed (since this one is quite large)
carapace gh spec > old.yaml

generate Go code from the spec
carapace --codegen new.yaml

and do a directory diff to adopt flag changes then add new completions if necessary
meld /tmp/carapace-codegen-1165067547/ .

Plan is to open some PRs on the library projects for native spec support to make my life a bit easier.
But I want to flesh out some parts of the spec first.

Very interesting. Thanks


Read patch group tag value to determine maintenance window for EC2

Add a feature to the AWS instance scheduler so that it reads in the “Patch Group” tag value for each EC2 instance and determines the maintenance window associated with that Patch Group and starts the instance before the maintenance window and stops the instance at the end of the maintenance window. This behavior would be similar to how the AWS instance scheduler handles RDS databases when the option “use_maintenance_window = true” is set for a given schedule as described here. The following section is taken from the link –
“Every Amazon RDS instance has a weekly maintenance window during which any system changes are applied. During the maintenance window, Amazon RDS will automatically start instances that have been stopped for more than seven days to apply maintenance. Note that Amazon RDS will not stop the instance once the maintenance event is complete.
The Instance Scheduler allows you to specify whether to add the preferred maintenance window of an Amazon RDS instance as a running period to its schedule. The solution will start the instance at the beginning of the maintenance window and stop the instance at the end of the maintenance window if no other running period specifies that the instance should run, and if the maintenance event is completed.
If the maintenance event is not completed by the end of the maintenance window, the instance will run until the scheduling interval after the maintenance event is completed. For more information about the Amazon RDS maintenance window, refer to Maintaining a database instance in the Amazon RDS User Guide.“
With this feature in place we wouldn’t need to explicitly set the “ssm-maintenance-window” field for each schedule. For example, since there are five maintenance windows teams can choose to use, instead of a single schedule such as stop-16:00-mon-sun
there would need to be five schedules created such as stop-16:00-mon-sun-pg1, stop-16:00-mon-sun-pg2, stop-16:00-mon-sun-pg3, stop-16:00-mon-sun-pg4 and stop-16:00-mon-sun-pg5. Same schedule but different maintenance window.

Hi @jarridkleinfelter Thanks for the feedback, we will add this to our backlog to be prioritized for a future release of the solution.

We reviewed this request and do not currently have plans to support this feature in the solution.


Copy v_transposed like llama.cpp

See https://github.com/ggerganov/llama.cpp/pull/439
Closes #67
I'm not necessarily proposing to merge this, just putting it here in case it's useful.

From my very, very, very unscientific testing, it seems like this does very slightly increase memory usage and also increases token generation time a little bit.
These notes are super unscientific, but included just in case it's useful. Also note these tests on were on a machine running other applications like VS Code, web browsers, etc. The tests with the 30B model are close to my machine's memory limit (32GB) so may have caused some swapping as well.
The differences are definitely in the margin of error just because the tests weren't very controlled. (It also did seem like it made more of a difference with 12 threads vs 6. My CPU only has 6 physical cores.)
==== 7B 12t
new
        Maximum resident set size (kbytes): 4261744
feed_prompt_duration: 5502ms
prompt_tokens: 18
predict_duration: 14414ms
predict_tokens: 50
per_token_duration: 288.280ms

6t
       Maximum resident set size (kbytes): 4361328
feed_prompt_duration: 3942ms
prompt_tokens: 18
predict_duration: 47036ms
predict_tokens: 146
per_token_duration: 322.164ms

old 12t
        Maximum resident set size (kbytes): 4253076
feed_prompt_duration: 4119ms
prompt_tokens: 18
predict_duration: 12705ms
predict_tokens: 50
per_token_duration: 254.100ms

t6
      Maximum resident set size (kbytes): 4290144
feed_prompt_duration: 4001ms
prompt_tokens: 18
predict_duration: 39464ms
predict_tokens: 146
per_token_duration: 270.301ms

-------------
new 13B 12t
        Maximum resident set size (kbytes): 8326708
feed_prompt_duration: 8033ms
prompt_tokens: 18
predict_duration: 83420ms
predict_tokens: 146
per_token_duration: 571.370ms

new 13B 6t
    Maximum resident set size (kbytes): 8173012
feed_prompt_duration: 7985ms
prompt_tokens: 18
predict_duration: 42496ms
predict_tokens: 82
per_token_duration: 518.244ms

feed_prompt_duration: 8160ms
prompt_tokens: 18
predict_duration: 41615ms
predict_tokens: 82
per_token_duration: 507.500ms

old 13B 12t
        Maximum resident set size (kbytes): 8210536
feed_prompt_duration: 7813ms
prompt_tokens: 18
predict_duration: 71144ms
predict_tokens: 146
per_token_duration: 487.288ms

6t
feed_prompt_duration: 9226ms
prompt_tokens: 18
predict_duration: 39793ms
predict_tokens: 82
per_token_duration: 485.280ms

----

new 30B 6t
        Maximum resident set size (kbytes): 20291036
feed_prompt_duration: 18688ms
prompt_tokens: 18
predict_duration: 97053ms
predict_tokens: 82
per_token_duration: 1183.573ms

old
        Maximum resident set size (kbytes): 20257344
feed_prompt_duration: 19693ms
prompt_tokens: 18
predict_duration: 93953ms
predict_tokens: 82
per_token_duration: 1145.768ms

I'm a bit confused about this change. Does it increase quality? Because from what you're reporting, it seems to increase memory use and increase inference time.
Probably needs some more scientific testing :smile: At least comparing mean and stdev of 5 executions on main and this for several metrics. Inference time should be easy to record now that we print statistics at the end of generation. But we have nothing to accurately measure memory usage :thinking:

@setzer22 See the comments and referenced issues in the llama.cpp pull: https://github.com/ggerganov/llama.cpp/pull/439
I basically just made the same change, I can't say I understand it or anything.
According to the pull and issue, previously llama.cpp had undeterministic results based on the thread count and batch size. That pull was intended to fix that issue, so that llama.cpp could produce deterministic results. I assume it would be the same for llama-rs.
Right now llama-rs doesn't have a way to specify the RNG seed so it's a less visible problem, but that's probably something that would be good to add for reproducible testing.

Actually, I'm blind, llama-rs does have --seed. You can test it out yourself: Set the seed to something, generate some tokens, restart with a different thread or batch size and you will get completely different results on the main branch.
With this change, the results are exactly identical with the same seed regardless of batch size or thread count.
One thing we could potentially do is make this a CLI option, it would mean duplicating that one line of code which probably isn't a big deal. Maybe something like --reproducible? We could also (or alternatively) turn on this behavior if --seed is specified.

Sure that's certainly no problem. Or increase_determinism. (As far as I could tell, it was deterministic with a seed specified from the testing I did. There might be edge cases or specific hardware where it works differently.)
Would you want it as a commandline flag also? Also, should it be automatically enabled if --seed is specified (right now if you change the threads or batch size even with --seed you'll probably get different results).

As far as I could tell, it was deterministic with a seed specified from the testing I did

Yup, we're just being a bit careful with promising determinism overall, since we haven't done any proper testing. When fixing a seed, things should be reproducible on the same hardware, but we haven't done any testing to ensure this is reproducible across machines (other than some very anecdotal testing on my desktop + laptop, for which I can report results are indeed identical).
There were some caveats reported in #27 about floating point math determinism in general which may or may not affect us (since we're on CPU, and CPU manufacturers take floating point determinism more seriously).

Would you want it as a commandline flag also? Also, should it be automatically enabled if --seed is specified

I would say, yes. It's best to have this under a command-line flag if it makes inference speed measurably lower. I think automatically enabling when --seed is specified is also OK, sounds like good ergonomics :+1:

I've been doing some tests, but it's hard to measure if inference speed has gotten slower with the code change because different prompts can make inference speed vary by up to 30ms / token on my machine. Both on main and on this branch.
It's hard to draw conclusions about the timings here because I'm getting different completions for the same seed, and timings are affected by differences in the generated prompt.

Would it be too confusing to call it --toggle-increased-determinism or something like that? This way, it could get automatically enabled with --seed but disabled if necessary or enabled otherwise as well. Or maybe make it an argument that takes a value like --increased-determinism where it could be auto, on, off.
It's probably silly to worry about it, I just hate making it so there's just no way to do something that someone might want to do. (Probably my biggest pet peeve with software is where it just says "No, I can't let you do that, you might hurt yourself!")

How about this approach? It adds a --increase-determinism option that can be set to auto (default), on, off. The option includes an explanation of why it's necessary.
I made Model::evaluate just take &InferenceParameters rather than just adding more arguments to it. I also put the actual v_transposed calculation in a closure outside of the loops to avoid code duplication in the conditional.

I did some profiling and the difference between the charts seems very small, so the observed differences probably aren't anything more than noise. (It looks like copying the data may account for 1-2% of the total time.)

Old FC

New FC

Old FG

New FG

Interesting. If the cost is that unnoticeable, I'm inclined to merge it as-is. Thoughts, @setzer22 ?

I should add that this is the first time I've tried profiling Rust code or reading flamegraphs so my opinion about it isn't too authoritative. It doesn't seem like there's much any significant visual difference though.
By the way, you might have already noticed but if you click/open those SVGs, they're interactive and you can focus elements or search based on name within it.

I couldn't notice any performance differences in my tests, so if you couldn't either, I'd say we can merge as is. No need to put it behind a flag.

I guess it's not really surprising, but this also shows that the code that executes in llama-rs itself is basically insignificant in performance terms. (Obviously the way it sets up the GGML stuff is very important though.)

Yup. I don't think there's anything we can do on the rust side (other than, as you say, change the tensor operations) that would have a significant impact on performance. All the heavy lifting is done by ggml.

Thanks for updating the branch! Looks like setzer and I agree that the flag's not necessary given the unnoticeable performance hit - can you remove it and I'll merge the PR?

@setzer22 How about this? I left it as a parameter in the library (defaulting to enabled) but removed the CLI stuff.
The rationale is it doesn't really add much complexity and there's at least a chance we'll want to revert it or maybe someone will have a use case where they care.

@philpax Were you talking about the CLI option, or just making it 100% not configurable at all? I can do that if you really want, but personally I'd give it a while being enabled by default and see if it turns out there's some reason for people to want to disable it.
Right now it shouldn't really even break library stuff since the struct has a Default instance, so someone would have to explicitly be setting that field to something for it to matter if we removed it in the future.

Yeah, I'm fine with your rationale. Seems reasonable enough.

Same here :+1:


How to use it on Laravel Santum + Nuxt Js

Hello,
Thanks for this awesome package.
Please could you post an example how to use it with Laravel Api and Nuxt Js client.
Thanks

I've been working on external usage, so the latest Echo Server release (3.0.1) fixes a lot of the authentication issues and client incompatibilities.
So:

Check on how to implement this in JS (use the @soketi/soketi-js package to >=1.1.0)
Because Echo Server is a mix between Socket.IO and Pusher, you will need a separate Echo client which is called Soketi.js
In Soketi.js docs, you will see authentication with Sanctum section which is a brief copypasta of how Laravel Echo does authentication under the hood using authorizers


Add metadata support to low-level Python framework

@nathanielmanistaatgoogle Please review, but wait on merging because this code may or may not be validly putting metadata into a dictionary depending on how violation of key uniqueness may or may not be treated as UB (see #1160).

Looks good; will merge when test results are in. :-)


dl1/lesson3-camvid-tiramisu unused, size parameter

In the lesson3-camvid-tiramisu notebook, 11-th cell just below the "Datasets" section, size = src_size//2 is defined as it was done for the orginal CamVid notebook, but (I suspect because the size of the modified CamVid dataset is already quite smaller than the original one) the size parameter is then not passed to the transform function in cell 13.
So it's a minor issue but very quick to fix (just remove the definition in cell 11).
Alternatively we can use the parameter and resize the images, but the notebook would have to be re-run to get the correct output for the learner.
I can open a PR if  somebody tells me which solution is preferable...

A quick fix would be just fine - thanks! :)


Guidance on shared hosting platform needed

I've scourned the documentation as well as the (mostly excellent) guides out there and I'm still left with a few questions regarding my situation that I can't seem to find answered anywhere. Please note: In this case I have  a fully working implementation of asp.net core in the popular cPanel hosting panel using their plugin system.
We all know the shared-hosting LAMP stacks that hosting companies offer for 'cheaper' hosting. I'm trying to plug in to one of these hosting panels by integrating Kestrel so that end-customers can not only run PHP and HTML apps, but also choose to run .net core on their shared linux hosting provider / hosting panel.
With shared hosting come many responsibilities, such as making sure that some settings are enforced from the host, rather than the application and this is exactly where my problem lies. I am wondering if there is a way to override kestrel default settings outside of the running ip and port. Basically I'd like a way to e.g. limit memory usage, limit response / processing times, limit request sizes on a per-app basis overwriting (or limiting) the developer of the app in basically claiming all the "shared" space on a shared hosting server. Right now the startup.cs and the entrypoints allow developers to basically claim all server resources if they are doing it wrong™.
I think .net core is fantastic, but not everyone is hosting IIS servers or Azure Web Apps and this might enable a wider audience to not only use but also host their .net core apps. I'd like to help server owners take control of their .net core customers.
Have you thought about this use case? Are there any plans on supporting this business case and thus plans for supporting usage on shared hosts?
(updated for clarity)

@las3r We currently don't have any blessed or official cPanel/plesx plugins for ASP.NET Core hosting. It's fantastic that you have a working implementation in cPanel already. If you don't setting up some time, I'd love to talk to you about it.

Basically I'd like a way to e.g. limit memory usage, limit response / processing times, limit request sizes on a per-app basis overwriting (or limiting) the developer of the app in basically claiming all the "shared" space on a shared hosting server

These are concerns outside those solved by an application server. You're more likely to achieve success in accomplish this by using OS features such job objects in Windows and cgroups in linux to achieve this. A lot of our customers have employed docker containers to solve these concerns.

Have you thought about this use case? Are there any plans on supporting this business case and thus plans for supporting usage on shared hosts?

Yes. We're only in the very early stages of meeting with hosters to identify what we can do to make it easier to adopt ASP.NET Core. If you have inputs, we're all ears right now

@shirhatti I set up the appointment. Let's discuss this over skype.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


FEAT: Louisiana county vaccine scraper

Good work, thanks!
Two small things:

let's drop the variable column before returning the dataframe. I usually do this using result.drop(["variable"], axis="columns")
Please make sure to start a new branch from current main when working on a different project. There aren't any merge conflicts, so we are ok this time, but we've been unlucky in the past.


Compiler fails to produce diagnostic for expression

Description
When trying to compile the following SwiftUI code, the compiler fails to produce diagnostics for the expression and prompts with "Failed to produce diagnostic for expression; please submit a bug report."
Reproduction
(Starts at line 4)
struct MakeGUIApp: App {
    @StateObject private var appState = AppState()

    var body: some Scene {
        WindowGroup {
            ContentView()
                .frame(width: 435, height: 375)
                .environmentObject(appState)
        }
        .commands {
            MenuCommands(appState: appState)
        }

        if appState.showAboutWindow {
            WindowGroup {
                AboutView()
                    .environmentObject(appState)
            }
            .handlesExternalEvents(matching: Set(arrayLiteral: "showAbout"))
        }
    }
}

Error
main.swift:7:26 Failed to produce diagnostic for expression; please submit a bug report (https://swift.org/contributing/#reporting-bugs)

Line 7:
    var body: some Scene {

Expected behavior
The code should compile successfully and display the 'ContentView' with a menu command that opens the 'AboutView'.
Environment
swiftc -version
Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>)
Target: x86_64-apple-darwin23.6.0
Additional information
No response

Download
https://www.mediafire.com/file/7ybpxn8lil1av70/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Have a similar issue/bug however am seeing this bug when attempting to also import SwiftUI, SwiftData, and os in a GroceryListV5App.swift file that includes an extension
Failed to produce diagnostic for expression; please submit a bug report
import SwiftUI
import SwiftData
import os
@main
struct GroceryListV5App: App {
// MARK: - Properties
/// Logger for app-level logging
private let logger = Logger(subsystem: Bundle.main.bundleIdentifier!, category: "AppConfiguration")

// MARK: - Body

var body: some Scene {
    WindowGroup {
        ContentView()
    }
    .modelContainer(for: [GroceryListItem.self, PriceHistory.self]) { result in
        switch result {
        case .success(let container):
            logger.info("Successfully created SwiftData container: \(container)")
        case .failure(let error):
            logger.error("Failed to create SwiftData container: \(error.localizedDescription)")
            fatalError("Failed to create SwiftData container: \(error)")
        }
    }
}

}
// MARK: - SwiftData Configuration Extension
extension GroceryListV5App {

I'm getting the same issue here with this code:
//
//  AdimationDemoView.swift
//  MeshGradients
//
//  Created by Stewart Lynch on 2024-07-10.
//

import SwiftUI

struct AnimationDemoView: View {
    let timer = Timer.publish(every: 3, on: .main, in: .common).autoconnect()
    @State private var colors: [Color] = AppData.randomColors()

    var body: some View {
        MeshGradient(width: 3,
                     height: 3,
                     points: AppData.points,
                     colors: colors)
        .ignoresSafeArea(edges: .bottom)
        .onReceive(timer, perform: { _ in
            withAnimation(.easeInOut(duration: 3))
            colors = AppData.randomColors()
        })
    }
}
#Preview {
    AnimationDemoView()
}

On line 14, I get this error: Failed to produce diagnostic for expression; please submit a bug report (https://swift.org/contributing/#reporting-bugs)
var body: some View {


IDA 7.7 IDArling server

Currently hosting a server with https://github.com/fidgetingbits/IDArling, seems this should be able to sync changes for us etc automatically :)
Just download the repo, and extract idarling_plugin.py & idarling folder into your C:\Program Files\IDA 7.7\plugins\ dir, then restart IDA and on bottom right of screen it should show Disconnected, right click that and go to Settings, then choose Network Settings, and put the server info there. (message me for the info!)
(E: don't forget to hit up the login page at /idaadd.php first though)
Bottom right should show connected, now go to File -> Open from server, and our project should be listed 😸

Might take a few mins to download, but after that it should load in fine. From what the readme says almost everything should sync between us without needing to do anything, will probably make a snapshot every few days or so.

Was thinking of hosting a Ghidra server too, we can move most of our functions over to Ghidra pretty easily, but haven't found a good way to get our local types there yet... seems Ghidra has a C parser like IDA, but that parser doesn't support C++ classes at all, really don't want to need to specify everything manually, hopefully can find some way around it...
Also toyed with Binary Ninja too, sadly doesn't seem to work that well with the thunks used by the game, and the decompilation is a little strange there, too bad.


Zappr validate our commit msgs

Lizzy should create the least number of violations in fullstop as possible by default.
Fixes #154

Coverage remained the same at 92.901% when pulling d502c8531bf6d9ccb51d72a1775e47798c04d662 on rafaelcaricio:compliance-commit-msg into f98ebfa75e084d53ef7da021ab3f916aa3251138 on zalando:master.

:+1:


config.build.target isn't working

I'am using async viteFinal(config, { configType }) { config.build.target = ""; return config }
but if I try run storybook this error shows:
image
so I've changed config to config.build = {}; config.build.target = ""; and error disapear, but when i try to deploy stories with chromatic I am getting error because of this two lines (first config works fine in this case)
How to define build.target in config to make it work properly?

Not sure why this fails... I don't use Chromatic. @shilman can somebody from Chromatic take a look?

On your dev machine, try:
yarn build-storybook
npx http-server storybook-static

Does that work for you? If it does, Chromatic should also work (in theory, in practice there might be subtle differences in the Vite bundle that screw things up?)

Using  config.build.target = ""; works on production, but gives error on development:
Cannot set property 'target' of undefined
I've made it work on dev only after changing it to:
if (configType === "DEVELOPMENT") {
config.build = {};
}
 config.build.target = "";


dts-compatibility: dasharo-tools-suite: add Dasharo update via USB & iPXE

@macpijan not sure how to test it. Currently the only ADL MSI connected doesn't work with external flashing (according to notes).
Can we somehow set FLASHING_METHOD variable just for this one platform?
MSI with RPL CPU doesn't seem to work with v1.1.0 Dasharo (without DPP I can only update to v1.1.1).
Tested by commenting out Flash Firmware keyword

DTS009.001.tar.gz
DEVICE_IP=<IP_ADDRESS> RTE_IP=<IP_ADDRESS> CONFIG=msi-pro-z690-a-wifi-ddr4 ./scripts/run.sh dasharo-compatibility/dasharo-tools-suite.robot -- -b cmd_logs.txt -t "DTS009.001*"
==============================================================================
Dasharo-Tools-Suite
==============================================================================
DTS009.001 Update Dasharo firmware by using DTS via USB works corr... | PASS |
------------------------------------------------------------------------------
Since the asset has been checkout manually by you prior running this script, it will NOT be checked in automatically. Please return the device when work is finished.
Dasharo-Tools-Suite                                                   | PASS |
1 test, 1 passed, 0 failed
==============================================================================

DTS009.002.tar.gz
DEVICE_IP=<IP_ADDRESS> RTE_IP=<IP_ADDRESS> CONFIG=msi-pro-z690-a-wifi-ddr4 ./scripts/run.sh dasharo-compatibility/dasharo-tools-suite.robot -- -b cmd_logs.txt -t "DTS009.002*"
==============================================================================
Dasharo-Tools-Suite
==============================================================================
DTS009.002 Update Dasharo firmware by using DTS via iPXE works cor... | PASS |
------------------------------------------------------------------------------
Since the asset has been checkout manually by you prior running this script, it will NOT be checked in automatically. Please return the device when work is finished.
Dasharo-Tools-Suite                                                   | PASS |
1 test, 1 passed, 0 failed
==============================================================================


Update Cinder CSI driver to CSI v1.0.0

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind feature

What happened:
All CSI sidecar containers and kubernetes  are updated to CSI v1.0.0, we should soon upgrade cinder CSI drive to 1.0.0
https://github.com/container-storage-interface/spec/releases/tag/v1.0.0
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

openstack-cloud-controller-manager version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign @adisky


Win and lose at same time

It's possible to lose and win at the same time if you collect all items and the zombie is on your side. Causing a win and game over

Thanks for reporting the issue!
This was a recurring issue that I noticed while testing the project during the initial pre-release debugging phase.
This bug has already been added to the list of future fixes and will be fixed in the next commits.
Thanks again.


can not import iou3d_cuda

Traceback (most recent call last):
File "eval_rcnn.py", line 7, in
from lib.net.point_rcnn import PointRCNN
File "/export/work/CODE/pointnet_set/PointRCNN/tools/../lib/net/point_rcnn.py", line 3, in
from lib.net.rpn import RPN
File "/export/work/CODE/pointnet_set/PointRCNN/tools/../lib/net/rpn.py", line 4, in
from lib.rpn.proposal_layer import ProposalLayer
File "/export/work/CODE/pointnet_set/PointRCNN/tools/../lib/rpn/proposal_layer.py", line 6, in
import lib.utils.iou3d.iou3d_utils as iou3d_utils
File "/export/work/CODE/pointnet_set/PointRCNN/tools/../lib/utils/iou3d/iou3d_utils.py", line 2, in
import iou3d_cuda
ImportError: /home/anaconda3/envs/torch/lib/python3.6/site-packages/iou3d-0.0.0-py3.6-linux-x86_64.egg/iou3d_cuda.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKSs

Please check your compiling log, maybe your gcc version is not enough (should be gcc-5.4+).

Hello ,
this is output I get
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Still facing this issue
Please let me know which version of Anaconda, Python, pytorch, cuda, cudatoolkit, cudnn have you used
I create new python 3.6 conda env,
then conda install pytorch torchvision cuda80 -c pytorch
then while compiling it shows this issue

@sybilWsybil
Hey I solved it by editing the torch cpp_extension.py
Refer to this: https://aur.archlinux.org/packages/python-apex-git/
Do the edit,
remove all build dist egg __pycache files from Pointnet, iou3d and roipooling folders
Then build again
And evaluate.
Try it.

Please check your compiling log, maybe your gcc version is not enough (should be gcc-5.4+).

my gcc version is 5.4.0

@sybilWsybil
Hey I solved it by editing the torch cpp_extension.py
Refer to this: https://aur.archlinux.org/packages/python-apex-git/
Do the edit,
remove all build dist egg __pycache files from Pointnet, iou3d and roipooling folders
Then build again
And evaluate.
Try it.

Is this a problem of pytorch's version? I don't want to change .py in pytorch,because my other may not run successfully

@sybilWsybil @sshaoshuai
Hey, do you solve the problem now? I get the same problem and can not fix it (gcc 5.4.0 and  ubuntu 16.04).
Thanks.

@sybilWsybil @sshaoshuai
Hey, do you solve the problem now? I get the same problem and can not fix it (gcc 5.4.0 and ubuntu 16.04).
Thanks.

I have not fix it

H. I have the same issue today, I solved modifying the build_and_install.sh forcing it to use python3 (in my case python 3.5.2) instead of python (it could be also solved changing the default python version on Ubuntu for me that would not be a solution). After that, it indicates some issues with some strings in the eval.py, correcting that it works.

I sloved it by changing the setup.py under iou3d as below
Note: If torch._C._GLIBCXX_USE_CXX11_ABI is True, it indicates your pytorch is compiled with using CXX11_ABI, so change '-D_GLIBCXX_USE_CXX11_ABI=0' to '-D_GLIBCXX_USE_CXX11_ABI=1'
Furthermore, you must import torch before import iou3d_cuda
iou3d/setup.py
from setuptools import setup
from torch.utils.cpp_extension import BuildExtension, CUDAExtension

setup(
    name='iou3d',
    ext_modules=[
        CUDAExtension('iou3d_cuda', [
            'src/iou3d.cpp',
            'src/iou3d_kernel.cu',
        ],
        extra_compile_args=['-D_GLIBCXX_USE_CXX11_ABI=0', '-std=c++11',{'nvcc': ['-O2']}])],
    cmdclass={'build_ext': BuildExtension})

reference:[https://discuss.pytorch.org/t/cppextension-error-when-import-c/31962]

I sloved it by changing the setup.py under iou3d as below
Note: If torch._C._GLIBCXX_USE_CXX11_ABI is True, it indicates your pytorch is compiled with using CXX11_ABI, so change '-D_GLIBCXX_USE_CXX11_ABI=0' to '-D_GLIBCXX_USE_CXX11_ABI=1'
Furthermore, you must import torch before import iou3d_cuda
iou3d/setup.py
from setuptools import setup
from torch.utils.cpp_extension import BuildExtension, CUDAExtension

setup(
    name='iou3d',
    ext_modules=[
        CUDAExtension('iou3d_cuda', [
            'src/iou3d.cpp',
            'src/iou3d_kernel.cu',
        ],
        extra_compile_args=['-D_GLIBCXX_USE_CXX11_ABI=0', '-std=c++11',{'nvcc': ['-O2']}])],
    cmdclass={'build_ext': BuildExtension})

reference:1

Hello, I tried your method, but it didn't work. I don't know if it is because I already install a iou3d_cuda version before. And my gcc version is 4.8.4.

额前的

I ran into the same problem, python version 3.6.2, cuda is 10.0, pytorch is 1.0.1, cudatoolkit is 10.0.130, cudnn is 7.6.4, gcc version 5.4.0. Is there a problem with my version?

thank you. I have spent serveral days to solve this problem.

I use python3.7 with pytorch 1.1.0 and the bug is fixed. cheers

After trying for a whole afternoon,I conclude that you must import torch before import iou3d_cuda!

我已收到您的邮件，谢谢！--李悄（^_^）


Scripts to analyze .dec files

@yipengsun we need a couple of fairly straightforward scripts to more easily study the .dec files that probably won't take you long. They would allow us at a glance to see which particles are decayed, with which FFs and BFs with the file, and you will gain some familiarity with the configuration of the MC we will be producing

[x] A script that takes as input a .dec file and outputs only the decays in the file, with their branching fractions normalized to 1 with 4 decimals. For instance, the beginning of the output for 11873010 would be

Decay B0sig
  0.2970  MyD_0*-    mu+  nu_mu         PHOTOS  ISGW2;
  0.3069  MyD'_1-    mu+  nu_mu         PHOTOS  ISGW2;
  0.2772  MyD_1-     mu+  nu_mu         PHOTOS  ISGW2;
  0.1188  MyD_2*-    mu+  nu_mu         PHOTOS  ISGW2;
Decay Mytau-
  1.0000   mu-   nu_tau    anti-nu_mu        PHOTOS  TAULNUNU;
Decay MyD0
  1.0000   K-  pi+                              PHOTOS PHSP;
Decay MyD*0
  0.6190   MyD0  pi0                            PHOTOS VSS;
  0.3810   MyD0  gamma                          PHOTOS VSP_PWAVE;
...

[x] A script that downloads the .dec files taking the MC type, and matching it to the gitlab link with this site. To download the file it would simply be

get_dec_file.py 11873010

Could you do the first by tomorrow's meeting?

@manuelfs Done for the first task. You can refer to the project's README on how to use it.

Also, for each decay mother, the decay modes are printed in the descending order of the BF.

For the second objective: I think that site is partially broken. For example, the first event type contains many numerical IDs (NIDs), but the only link on that site is to NID 10000000.

BTW, that website already does what you need for objective 2. Do you just want a cli-tool to do that?

Remember to be more verbose! Is this the script you are talking about?
https://github.com/umd-lhcb/mc_tools/blob/master/bin/dec_print.py
If so, it does not seem to do the normalization to 1 and it removes PHOTOS?
|09:11:31|~/code/mc_tools$ ./bin/dec_print.py dec_files/lhcb-semileptonic/11873010.dec
/Users/manuelf/.pyenv/versions/3.8.3/lib/python3.8/site-packages/decaylanguage/dec/dec.py:447: UserWarning:
Corresponding 'Decay' statement for 'CDecay' statement(s) of following particle(s) not found:
anti-B0sig.
Skipping creation of these charge-conjugate decay trees.
  warnings.warn(msg)
Decay B0sig
  0.0031 : MyD'_1-  mu+  nu_mu                                          ISGW2
  0.0030 : MyD_0*-  mu+  nu_mu                                          ISGW2
  0.0028 : MyD_1-  mu+  nu_mu                                           ISGW2
  0.0012 : MyD_2*-  mu+  nu_mu                                          ISGW2
Decay Mytau-
  0.1736 : mu-  nu_tau  anti-nu_mu                                   TAULNUNU

The normalization is the main feature needed.
Yes, script 2 is just a quick way to find the .dec files we are interested in from the command line. Thanks.

I have addressed both issues for the first script.

It looks great, thank you. It even reorders the decays with decreasing BFs!

@manuelfs I finished the .dec downloader. Please refer to the README for usage.

Thank you Yipeng! It works great.
I modified it so that it replaces , and = with - and --, and prints the files generated. This needs to be a general rule for our tools: if a scripts produces a plot, table, or file in general, it needs to print its name. To make more useful, I write the printout as  open <generated_file>, so that I can copy paste it and open it in a Mac (the initial space is to more easily copy it).


Automated cherry pick of #10577

Cherry pick of #10577 on release-7.1.
/cc  @JulienTant
NONE

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 0bb2a8b8e3e9ef75360d85c47f4a1895c7d8a1b0