qrenderdoc causes GPU hang while replaying captured frame on ANV

When switching which events I'm viewing in qrenderdoc on a Vulkan frame capture, I often see the Intel HD Graphics 530 GPU hang.
This might not be a bug in renderdoc. If this appears to be driver bug I can report it to the DRM/Intel project on bugzilla.freedesktop.org instead.
Steps to reproduce:

Launch qrenderdoc using an ANV (the Intel Linux Vulkan driver) ICD: VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/intel_icd.x86_64.json qrenderdoc
On the Capture Executable tab, set the Executable Path to the path of vulkan-smoketest, for example /usr/bin/vulkan-smoketest.
Press Launch
Press F12 to capture a frame
Press the escape key to exit vulkan-smoketest
Select the captured frame
Switch to to the Texture Viewer tab
Expand the Colour Pass and vkCmdExecuteCommands rows in the Event Browser
Press the end key to select the last event (vkQueuePresentKHR())
Press the up and down arrow keys to repeatedly scroll through the last 6 events of the trace
After a few iterations, the device is lost.  (There doesn't seem to be a specific call that causes the GPU hang in a trace every time it is viewed, but flipping through them like this for less than minute is enough to hit the bug

Alternatively, you can load a previously captured frame such as this one:
vulkan-smoketest_2017.10.10_17.55_frame68.zip,  instead of steps 2 to 6.
Results
This appears on the terminal that launched qrenderdoc:

Log     - QRenderDoc - renderer created for "/tmp/RenderDoc/vulkan-smoketest_2017.10.11_12.46.17_frame70.rdc"
vulkan/anv_queue.c:46: execbuf2 failed: No such file or directory (VK_ERROR_DEVICE_LOST)
vulkan/anv_queue.c:216: vkQueueSubmit() failed (VK_ERROR_DEVICE_LOST)
Error   - Assertion failed: 'vkr == VK_SUCCESS' (vkr=VK_ERROR_DEVICE_LOST, VK_SUCCESS=VK_SUCCESS)

The last line is repeated several times. It is printed more times if you interact with the UI.
The textures shown in the texture viewer stop updating, but the status bar still contains the text "No problems detected.".
Sometimes a GPU crash dump is saved to /sys/class/drm/card1/error. Here is one:
error.txt.
Expected results
The texture Viewer should represent the state of the Vulkan images at the selected event whenever possible, and be clear if there was an error. A GPU hang might be acceptable if the capture executable was risking a GPU hang, but ideally qrenderdoc should be resilient in the case of capture executable bugs as it is used as a debugger. I'm not convinced vulkan-smoketest or other applications that cause this have such bugs however, in which case renderdoc shouldn't hang the GPU.
System
I can reproduce this on this system:

Parameter
Value

Renderdoc version
commit 2f728480566e4cfdd81de5435ba5c57c0e5d4525 (v1.x branch), with a #pragma GCC diagnostic ignored "-Wformat-truncation" added before an intentionally dodgy snprintf call at renderdoc/serialise/utf8printf.cpp:1441 (GCC 7.2 warns the buffer is too small for the format string, and it is compiled with warnings as errors enabled.)

Processor
Intel® Core™ i7-6700K CPU @ 4.00GHz × 8

Graphics
Both an Intel® HD Graphics 530 (Skylake GT2) and an AMD RX 480 (I'm not using the AMD GPU for Vulkan when reproducing the bug, by setting a VK_ICD_FILENAMES that doesn't include the radeon ICD)

Graphics Driver
Mesa 17.2.2

OS
Fedora 26

I don't see any similar problems when using the AMD GPU.

Thanks for the detailed report! that's a lot of good info. My intel machine has a Broadwell chip but I'll test to see if I can get it there anyway. I do have that exact chip but no easy way to test mesa. Though maybe I can just boot off a portable install...
Can you try one thing - are you able to reproduce this hang on a capture that doesn't use secondary command buffers? There's a lot of things that this could be due to, but I'd like to know if I can eliminate that as it reduces the scope a fair amount. E.g. testing with any of Sascha's demos.

are you able to reproduce this hang on a capture that doesn't use secondary command buffers?

No - I tried a few of Sascha's demos, but saw no GPU hangs.

Just to let you know I've repro'd this on mesa 17.2.3 with my HD 6000, so I'll continue to investigate.

There's something funny going on here - it looks like the precise repro was to select an event part-way through a vkCmdExecuteCommands so that a special partial-recorded primary command buffer would execute the secondaries in the capture, then select an event after it (like vkQueuePresentKHR) so that they are replayed on the original command buffer. Doing this seems to break.
However I'm not entirely sure that's illegal, I'm a little unclear on the spec implications of omitting USAGE_SIMULTANEOUS_USE_BIT and when you're allowed to re-execute the same buffer. For now, I've added that bit since it's a conservative and at worst a bit less efficient. Let me know if that fixes the problem for you, in the meantime I'll see if I can determine for sure if it's a driver bug or not.

That change works for me.

Thanks for verifying!


⚠ ClamAV has degraded performance

In 6e1f9d5, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 453 ms

Resolved: ClamAV performance has improved in c00e205.


Dropdown mobile rendering

How I can disable mobile rendering? I use WinCC Unified system to show dropdown, but it's showing in mobile mode.

It's still showing in mobile rendering.


Investigate HIP 5.2.0 error with Kokkos 4.0

HIP 5.2.0 error:
fatal error: error in backend: Cannot select: 0x559739e39148: i32,ch =
AtomicLoadAdd<(load store syncscope("agent-one-as") monotonic (s32) on %ir.161,
addrspace 5)> 0x5597327b0b68, 0x55972efc81a8, Constant:i32<1>,
/opt/rocm-5.2.0/include/hip/amd_detail/amd_hip_atomic.h:141:10 @[
/opt/kokkos/include/desul/atomics/Fetch_Op_HIP.hpp:48:159 @[
/opt/kokkos/include/desul/atomics/Generic.hpp:327:3 @[
/opt/kokkos/include/Kokkos_Atomics_Desul_Wrapper.hpp:121:44 @[
test/tstQueryTreeRay.cpp:146:28 @[
src/details/ArborX_DetailsTreeTraversal.hpp:438:7 @[
/opt/kokkos/include/HIP/Kokkos_HIP_Parallel_Range.hpp:58:5 @[
/opt/kokkos/include/HIP/Kokkos_HIP_Parallel_Range.hpp:73:22 @[
/opt/kokkos/include/HIP/Kokkos_HIP_KernelLaunch.hpp:80:3
] ] ] ] ] ] ] ]
  0x55972efc81a8: i32 = add 0x55973360e200, Constant:i32<104>
    0x55973360e200: i32 = add FrameIndex:i32<0>, 0x55972c2dc648
      0x5597348aba68: i32 = FrameIndex<0>
      0x55972c2dc648: i32 = shl 0x559735c47df0, Constant:i32<2>
        0x559735c47df0: i32 = truncate 0x5597285b60a0
          0x5597285b60a0: i64 = AssertSext 0x559735c47d88, ValueType:ch:i32
            0x559735c47d88: i64,ch = CopyFromReg 0x5597327b0b68, Register:i64 %11
              0x55972efc8b00: i64 = Register %11
        0x55972c2dc8b8: i32 = Constant<2>
    0x55973360de58: i32 = Constant<104>
  0x55972b981710: i32 = Constant<1>
In function: _ZN6Kokkos4ImplL32hip_parallel_launch_local_memoryINS0_11ParallelForIN6ArborX7Details13TreeTraversalINS3_28BasicBoundingVolumeHierarchyINS_8HIPSpaceENS3_3BoxEvEENS4_12PermutedDataI28BoxesIntersectedByRayOrderedINS_6DeviceINS_3HIPES7_EEENS_4ViewIPjJSE_EEELb0EEE19InsertIntersectionsISE_ENS3_12Experimental26OrderedSpatialPredicateTagEEENS_11RangePolicyIJSD_NSO_11OneLeafTreeEEEESD_EELj1024ELj1EEEvT_
clang-14: note: diagnostic msg: Error generating preprocessed source(s).

Corresponding code: https://github.com/arborx/ArborX/blob/0136f9683051a298b5cbeeb2a940133f279042c9/test/tstQueryTreeRay.cpp#L146
Originally posted by @aprokop in https://github.com/arborx/ArborX/issues/834#issuecomment-1454172350

I can reproduce the problem on Crusher

Basically I get the error even using a single int if it's a member variable. If I define the integer locally to the kernel (which obviously is useless in practice), it also works. I modified the struct to use a Kokkos::View<int[2]> and it works. Do you want me to change the test?

Anything in the 5.2 to 5.3 changelog that could indicate what the problem was that was fixed?

No I couldn't find anything


⚠ Processors has degraded performance

In 075c297, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 59 ms

Resolved: Processors performance has improved in 9973cf9.


Show kubernetes services

Hey, I just made a Pull Request!
First part of #4064: adding support for Service manifests in the k8s plugin.
If it looks good to you, I'll add some tests and then open another PR for ingresses.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

Rebased and added support for Service + Ingress manifests. Should be ready for review now :)

Rebased and added support for Service + Ingress manifests. Should be ready for review now :)


Updated some research.csc.fi links

To fit with the newest structure of Pricing & Resources, research.csc.fi, I updated to new links:

Billing units (with billing models and calculator)

Quotas

Purchasing

Pricing & Resources

Looks good!
One tiny comment is that in docs/computing/usage-policy.md, would we rather want to link to BUC?
billing unit calculator -> https://research.csc.fi/billing-units#buc

Looks good! One tiny comment is that in docs/computing/usage-policy.md, would we rather want to link to BUC? billing unit calculator -> https://research.csc.fi/billing-units#buc

I added this and a few others as suggestions.


Dependency trees not hashed correctly

When there is a chain of files requesting each other, for example a JavaScript file A requesting a file B that requests C, then the plugin currently naively adds hashes to each URL, but does not resolve the dependency tree. This is a problem, because if I make a change in file C, then its hash changes, but B's hash does not. That means A will request the same version for B that it did before, which includes the old hash for C.
In a nutshell, the plugin needs to hash files after having replaced all the URL they reference have been processed. The hashes need to be hashes of the files that already include URLs with hash parameters.

This issue has been partially resolved. The issue as outlined has been fixed, but circular dependencies are currenntly not handled correctly. They are hashed twice, which works for when the dependency loop is of size 2, but not beyond that. Instead, dependency loops should be identified and hashed as a whole; all files in a dependency loop should get the same hash, since all depend on one another. However, the loops need to be distinguished; that is, two separate dependency loops should not get the same hash, just the files within one loop do.


Synthstraw Boater hats

About the PR
Following complaints by a certain Diona, Nanotrasen has decided to add synthstraw boater hats to quickthreads machines across the sector.

Why / Balance
There aren't enough hats for the crew to wear, compared to the jumpsuit count
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:
add: Synthstraw boaters hat in Quickthreads

Tests say there is a merge conflict?


Switch to OCI artifacts

This changes the implementation to create/use artifacts on an OCI repository.
Work left:

[ ] Fix/add acceptance tests.
[ ] Decide if file storage support is to be retained - make changes accordingly.

We may want to require a type prefix for --store, e.g. --store=oci:quay.io/org/repo:tag, or --store=file:/workspaces/foobar.
There's a bit of work required to support for both file and oci storage.

There's a bit of work required to support for both file and oci storage.

Do we see a future where we would support more than one implementation?
Right now I don't think we need both, we can decide on one and go forward with it... (Preferably OCI-based storage)

There's a bit of work required to support for both file and oci storage.

Do we see a future where we would support more than one implementation?
Right now I don't think we need both, we can decide on one and go forward with it... (Preferably OCI-based storage)

Yeah. We should probably just switch over to using OCI. Let's see how the perf tests go before doing so.

Dropping this in favor of https://github.com/konflux-ci/build-trusted-artifacts/pull/85.


[DS-6931][fix] swagger failed to start due to improper use of request param annotation

Purpose of the pull request
swagger failed to start due to improper use of request param annotation
Brief change log

ExecutorController
ProcessTaskRelationController

Verify this pull request
This pull request is code cleanup without any test coverage.

Codecov Report

Merging #6933 (e09af7e) into dev (4bec792) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #6933      +/-   ##
============================================
+ Coverage     33.01%   33.06%   +0.04%
- Complexity     1624     1626       +2
============================================
  Files           433      433
  Lines         14362    14362
  Branches       1437     1437
============================================
+ Hits           4742     4749       +7
+ Misses         9168     9158      -10
- Partials        452      455       +3

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (ø)

...he/dolphinscheduler/common/enums/SqoopJobType.java
88.88% <0.00%> (+88.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bec792...e09af7e. Read the comment docs.

#6931

#6772


rename repo to prometheus-eaton-ups-exporter

This will follow common norms in the Prometheus community, and will also make clear that only Eaton UPSs are targeted.

As I merged your last change on that, I will close this issue.

You merged my PR which renamed the library and the script name. The repo (which is what this issue is about) needs to be renamed by you. ;-)

LMAO I misunderstood this

Done

:-D


Is it possible to check for mixed content when using https?

Hey!
I would want to use this driver to check for mixed content errors.
I already did similiar check for resources which are 404:
# 404 check
RSpec::Matchers::define :have_missing_assets do
  match do |page|
    page.driver.network_traffic.each do |request|
        request.response_parts.uniq(&:url).each do |response|
            # Check if any of the urls has mixed content
             return true if response.status == 404
        end
    end
    return false
  end

  failure_message_when_negated do |page|
    errors = []
    page.driver.network_traffic.each do |request|
        request.response_parts.uniq(&:url).each do |response|
            # Check if any of the urls has mixed content
             errors.push(response.url) if response.status == 404
        end
    end
    "Expected not to have any 404 requests but these were missing: \n\n#{errors.map{|w| "- #{w}"}.join("\n")}\n"
  end
end

Phantomjs is so clever that it won't even load http:// resources from https:// protected pages so inspecting the page.driver.network_traffic won't help me here.

While PhantomJS (2.1.1 is what I tested) does output a warning to the console about the page running insecure content, the http URL does still appear in the request url of  `page.driver.network_traffic' for me.
page.driver.network_traffic.each do |request|
  puts "insecure content" if request.url.match?(/http:\/\//)
end


No sound with ogg

I run the current version from github on Debian Jessie. Some videos appear to play without sound. The --debug told me that it's reproducable when:
-> Video type: video/webm;+codecs="vp9"
-> Audio type: audio/webm;+codecs="vorbis"
Strange thing is that these videos are playable when i hand over the video url directly to mpv. Tried other players as well - they refuse to play the videos completely. Videos with other audio encoding work well.

This is a codec problem.


How to send a gmail using this node app ? THIS IS NOT AN ISSUE

Hi Team,
Could you please let me know how to send a GMAIL using this API? IT would be of great help.
Thanks

you would use the gmail.users.messages.send function

Hi Tyler,
Thank you so much for the response. Do you have any sample code on how you
are able to send the GMail using the above API.
Thanks in advance !
Regards,
Vivin
On Wed, Feb 10, 2016 at 10:58 PM, Tyler Harden<EMAIL_ADDRESS>wrote:

you would use the gmail.users.messages.send function
—
Reply to this email directly or view it on GitHub
https://github.com/google/google-api-nodejs-client/issues/514#issuecomment-182731943
.

Hi Vivin,
Here is a Node.js quickstart for the Gmail API. The example shows gmail.users.labels.list, but like @barca mentioned, you could substitute that for gmail.users.messages.send as you try the quick start.
Cheers!

Closing as this does not appear to be an issue. If you are convinced that this is really a bug, please feel free to re-open the issue and add more information such as:

Expected behavior
Actual behavior
Code samples
Version numbers
References docs or other links

Or, consider opening a Pull Request.
Otherwise, support questions are handled on Stack Overflow.


fix(cisco_ftd): When cisco FTD wrong source type

When cisco FTD is sending mostly compliance (RFC3164) syslog instead of the normally broken cisco_syslog the source type is wrong for IDS events

:tada: This PR is included in version 1.79.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Design for hibernating clusters with Hive

Something else to consider, we do the "delete-after" annotation, something similar would be great to have Hive hibernate it at a certain time. "after" doesn't work in this case it would be more like "at 5pm every day"? Or should this just be a separate tool?
I want to link this up with ClusterPool once it's ready so you can specify to hibernate all clusters in the pool until they're requested.

Something else to consider, we do the "delete-after" annotation, something similar would be great to have Hive hibernate it at a certain time. "after" doesn't work in this case it would be more like "at 5pm every day"? Or should this just be a separate tool?

I would propose we handle that in a separate tool/controller that is separate from the scope of this controller.

@dgoodwin @staebler thanks for your comments so far, I've now updated the doc.
Naming is hard, so if you have better suggestions for API variable names/types, they're very welcome :)

Updated to use PowerState as the field in the ClusterDeployment that says whether a cluster is running or hibernating.

good to merge this, since we started coding?

@gregsheremeta updated the actuator interface to reflect reality. Other than that, it should be good to go.

/lgtm


Need some help some missing DLL

Hi
I very new to Mediapipe.There some DllNotFoundException?
DllNotFoundException: mediapipe_c assembly: type: member:(null)
Mediapipe.UnsafeNativeMethods..cctor () (at Packages/com.github.homuler.mediapipe/Runtime/Scripts/PInvoke/UnsafeNativeMethods.cs:29)

It seems that the dynamic linking libraries are not compiled yet. Have you compiled the mediapipe? If not, you can refer to the installation guild to compile the source code first.


Assistant Voice volume level is no longer adjustable via alsamixer/the gui

I've just installed the latest image aiyprojects-2018-02-21.img.xz on my Voicekit.
In the past I have adjusted the assistant's voice level by using either the alsamixer or the little loudspeaker GUI control on the desktop. That no longer works - instead I have adjusted the volume level by asking the assistant to increase/decrease it by x percent.
I've noticed that alsamixer shows "PulseAudio" as the soundcard
If I go back to my previous installation by swapping over SD cards and go into alsamixer the soundcard is shown as snd_rpi_googlevoicehat_soundcar
Is this deliberate????

My Voice kit (aiyprojects-2018-02-21.img.xz) has same problem.
Mixer volume is too loud to listen to music (sound noisy and distorted)
When I changed volume at amixer or at GUI, actual speaker volume does not change at all. Even I muted the sound at GUI, I hear still loud sound.

Same for me, can't adjust the volume ... the guy or amixer doesn't affect the volume, and in assistant_grpc_demo.py, every command i try doesn't affect it ... when asking what's the volume, the answer is always 50% ...

Thanks for the report! The switch to PulseAudio is intentional, but disabling the volume control was not intentional. We're working on a new image that will fix this.

How do I update to a working volume control if I'm on the 2018-02-21 img?

Experiencing similar issues, and this is a school project for me... Has this been fixed yet? Is there an alternative way to control audio that could bypass this?

Really appreciate it, drigz.
Would you guys mind releasing a fix rather than a new "image"? or an alternative to choose "not an image"?
I have done many times re-image... and everytime I have to sacrifice losing the work on top of the existing image.... : (

We now install https://freedesktop.org/software/pulseaudio/pavucontrol/ by default.

Changes to Pulse Audio in gui have no impact on the speaker. It remains painfully loud. In the interim, I'm just going to toss a potentiometer inline with the speaker and manually drop the volume that way.


Support for bond charge corrections

It's very easy to add support for forcefield-defined bond charge corrections, so I'm going to do that now, since it will enable dielectric corrections (timely with @cfennell's visit).
API Proposal
I propose to extend the API of ForceField.createSystem() to add a chargeMethod argument, which can take one of the following values:

'BCC' will apply bond charge corrections if the ffxml file had a <BondChargeCorrections> block. This first applies a semiempirical method (specified in the method attribute of the <BondChargeCorrections> XML block) and then applies bond charge corrections. If no <BondChargeCorrections> section is specified, the charges specified in the OEMol molecules are used.  (default)
Any of the charge methods in openeye.oequacpac can be specified as a string (e.g. 'OECharges_AM1BCCSym'), and this charge model will be used.
None forces the charges from the provided OEMol molecules argument to be used. (useful for testing)

XML specification
Rules:

Later definitions that match the same bond override earlier definitions. This is needed to ensure the definitions scheme is hierarchical, like other parts of SMARTY.
Multiple definitions can be sequentially applied to the same atom.

<BondChargeCorrections method="AM1">
  <BondChargeCorrection smirks="[#6X4:1]-[#6X3a:2]" increment="+0.0073"/> <!-- tetrahedral carbon bonded to aromatic carbon correction -->
  <BondChargeCorrection smirks="[#6X4:1]-[#6X3a:2]-[#7]" increment="-0.0943"/> <!-- tetrahedral carbon bonded to aromatic carbon (bonded to a nitrogen) -->
</BondChargeCorrections>

Example usage
Current scheme remains default: Take charges from molecules:
system = forcefield.createSystem(topology, molecules)

Use ffxml-defined bond charge corrections:
system = forcefield.createSystem(topology, molecules, chargeMethod='BCC')

Use recommended AM1-BCC from oequacpac:
system = forcefield.createSystem(topology, molecules, chargeMethod='OECharges_AM1BCCSym')

Update: Proposal tweaked so that any bond charge corrections in the file are automatically applied.

Proposal above has been updated to reflect a change in default behavior.

This looks viable to me, though we'll need @cbayly13 's eyes on it.

Also, what best practices should we be following in assigning charges for different chargeMethod choices?
For OECharges_AM1BCCSym, is there a recommended conformational expansion that proceeds it? What about for other schemes, such as just applying AM1 charges prior to assigning bond charge corrections?

I'll go over what I think we need to do with @cbayly13 early in the week to confirm and then let you know (or submit a PR to implement). For now I suggest you just conformationally expand using omega with default parameters and plunge ahead

@jchodera - I showed this to @cbayly13 ; he seems to think it is good. Not sure if he'll have any more detailed feedback but so far so good.
He's looking at the charge/conformational expansion issue shortly.

I think the API proposal looks. I note that the application of the increment ( ie +increment to the first atom and -increment to the second) puts an order-dependence on the SMIRKS specification, but I think that is OK because atom:1 is specified and its label can't change. We should watch that.

@jchodera : Regarding conformational expansion, YES, we need to add a conformational expansion:

For OECharges_AM1BCCSym, is there a recommended conformational expansion that proceeds it?

Yes! This only charges the provided conformer if it's given a single-conformer molecule; if it's given a multi-conformer molecule it does ELF1, per Christopher, which is currently the best available. So, we need to pass it a multi-conformer molecule, and the conformer generation should be done exactly as following this recipe: http://docs.eyesopen.com/toolkits/cookbook/python/modeling/am1-bcc.html
A side note is that ELF10 is better for large, flexible molecules with substantial conformational dependence in their charges, but this will not be available until the February toolkit release. At that time, there will also be a major change to the charging functionality where it will switch from being OEAssignPartialCharges to OEAssignCharges or something along those lines. So we'll know when it becomes available because our code will break with the latest toolkits.

Did you want me to implement this, @jchodera ?

Please do!
I think we want to encapsulate this in the _assignPartialCharges() method which was intended to encapsulate whatever best practices go into charge assignment given the oechargemethod provided.
Thanks!

This was all implemented; closing.


Update ELK to version 6.3.0 and Search Guard accordingly

Upgrading to latest Search Guard version on ELK 6.3

Thanks @yorch :raised_hands:


pinentry uses X11

When I call this program, it uses pinentry-gtk2 even when my session is Wayland. This means the pinentry has no DPI scaling (and just general Xwayland issues). Is there a way to tell rofi-rbw to use a different pinentry, such as pinentry-gnome3?

rofi-rbw is only the frontend, the actual decryption and management is done by rbw. According to its documentation, you can configure a different pinentry binary.

Oops, thank you! Indeed setting the config fixed it.


#1239 AWS::Serverless::Api Tags are not visible in the API Gateway co…

…nsole under "Configure Tags"
Issue #, if available:
#1239
Description of changes:
Done the changes as advised
Description of how you validated changes:
Tests were updated and make pr ran
Checklist:

[x] Write/update tests
[x] make pr passes
[ ] Update documentation
[x] Verify transformed template deploys and application functions as expected
[ ] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lskrajny Thank you for contributing this. Could you please resolve merge conflicts and update the PR?

Codecov Report

Merging #1244 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1244      +/-   ##
===========================================
+ Coverage    94.45%   94.46%   +<.01%
===========================================
  Files           78       78
  Lines         4332     4334       +2
  Branches       854      855       +1
===========================================
+ Hits          4092     4094       +2
  Misses         114      114
  Partials       126      126

Impacted Files
Coverage Δ

samtranslator/model/apigateway.py
97.89% <ø> (ø)
:arrow_up:

samtranslator/model/api/api_generator.py
95.25% <100%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbccae9...020a06b. Read the comment docs.

In testing this feature, it seems like it works to add tags to an ApiGateway Stage resource but not to an ApiGateway RestApi resource. The template deploys fine, but the CLI does not return any tags on the RestApi resource.
The template configuration looks correct, however, in this PR. I think we can approve this then follow up with ApiGateway about why tags don't work on RestApi resources.
---
AWSTemplateFormatVersion: '2010-09-09'
Resources:
  ServerlessRestApiDeploymentb9a4f42ab9:
    Type: AWS::ApiGateway::Deployment
    Properties:
      RestApiId:
        Ref: ServerlessRestApi
      Description: 'RestApi deployment id: b9a4f42ab99dd8b0342de400beae778b6162cb0f'
      StageName: Stage
  MyFunction2:
    Type: AWS::Lambda::Function
    Properties:
      Handler: index.handler
      Code:
        ZipFile: |
          def handler(event, context):
              print(event)
              return {'body': 'Hello World 2!', 'statusCode': 200}
      Role:
        Fn::GetAtt:
        - MyFunction2Role
        - Arn
      Runtime: python3.7
      Tags:
      - Value: SAM
        Key: lambda:createdBy
  ServerlessRestApiProdStage:
    Type: AWS::ApiGateway::Stage
    Properties:
      DeploymentId:
        Ref: ServerlessRestApiDeploymentb9a4f42ab9
      RestApiId:
        Ref: ServerlessRestApi
      StageName: Prod
  MyFunction2Role:
    Type: AWS::IAM::Role
    Properties:
      ManagedPolicyArns:
      - arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
      AssumeRolePolicyDocument:
        Version: '2012-10-17'
        Statement:
        - Action:
          - sts:AssumeRole
          Effect: Allow
          Principal:
            Service:
            - lambda.amazonaws.com
  MyFunction2ApiPermissionProd:
    Type: AWS::Lambda::Permission
    Properties:
      Action: lambda:invokeFunction
      Principal: apigateway.amazonaws.com
      FunctionName:
        Ref: MyFunction2
      SourceArn:
        Fn::Sub:
        - arn:aws:execute-api:${AWS::Region}:${AWS::AccountId}:${__ApiId__}/${__Stage__}/GET/
        - __Stage__: "*"
          __ApiId__:
            Ref: ServerlessRestApi
  ServerlessRestApi:
    Type: AWS::ApiGateway::RestApi
    Properties:
      Body:
        info:
          version: '1.0'
          title:
            Ref: AWS::StackName
        paths:
          "/":
            get:
              x-amazon-apigateway-integration:
                httpMethod: POST
                type: aws_proxy
                uri:
                  Fn::Sub: arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${MyFunction2.Arn}/invocations
              responses: {}
        swagger: '2.0'
      Tags:
      - Value: SAM
        Key: lambda:createdBy

Add in the docs that these tags will get applied to the RestApi resource
https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessapi

It looks like this feature deploys, but doesn't actually work as intended. See https://github.com/awslabs/serverless-application-model/issues/1239#issuecomment-562763620 for full details.
Thank you for submitting this PR, and sorry for the back and forth for something that ultimately doesn't accomplish the end goal of adding tags to this resource.


SDK: integration tests

Fixes #82

NOTE: the failing tests may be due to the test's misuse of the API (false positive?), or they may be exposing some actual underlying issues that we would want to address.

I've addressed the feedback from @fbogsany (thanks! :smile:) thus far, and will watch #150 for changes that should help with that one last failing test.

It looks like #150 is slightly complicated. Should we consider commenting out (or not including) the child count test for the time being?

consider commenting out (or not including) the child count test for the time being

I'd be ok with that.


add link to blog post "Collecting OpenTelemetry-compliant Java logs from files"

If it's worth linking to the blog post from the docs, I wonder if we shouldn't just incorporate the example into the documentation itself. @open-telemetry/docs-approvers, WDYT?

Yeah, I would prefer to pull it in if it's still relevant content that's intended to be permanent.

yes, blog posts become outdated over time and we do not intend to keep them updated. So the portions of the blog post that need to be updated should live in docs.

@zeitlinger, if you agree, I'll create an issue for the transfer of the example in the blog to the docs and we can close this PR. Thanks!

@jack-berg adding a complete example on this page would increase the size too much
do you have an idea where we could add examples like this?

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷
Its a bit niche but probably not any more niche than examples we already have in there.

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷
Its a bit niche but probably not any more niche than examples we already have in there.

that would be my preferred place as well, we can then either point to it from docs, or code-excerpt some of it eventually into the docs.

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷
Its a bit niche but probably not any more niche than examples we already have in there.

I already have an executable, tested example - maybe we can use it as a starting point: https://github.com/grafana/docker-otel-lgtm/tree/main/examples/java/json-logging-otlp

Full k8s setup
sends data to loki
uses OATS for tests - which queries loki

Testing up to the collector would be sufficient - but I don't know which tool does this.
WDYT?

do you have an idea where we could add examples like this?

opentelemetry-java-examples? 🤷
Its a bit niche but probably not any more niche than examples we already have in there.

I already have an executable, tested example - maybe we can use it as a starting point: grafana/docker-otel-lgtm@main/examples/java/json-logging-otlp
1. Full k8s setup

2. sends data to [loki](https://github.com/grafana/loki?rgh-link-date=2024-12-16T10%3A44%3A57Z)

3. uses [OATS](https://github.com/grafana/oats/tree/main/yaml?rgh-link-date=2024-12-16T10%3A44%3A57Z) for tests - which queries loki

Testing up to the collector would be sufficient - but I don't know which tool does this.
WDYT?

Sure, if you bring that into the opentelemetry-java-examples repo we can link it from there.
TIL about OATS, do you want to add that to the registry? This might also be interesting for https://github.com/open-telemetry/community/pull/2427/

Sure, if you bring that into the opentelemetry-java-examples repo we can link it from there.

@svrnm here's the PR: https://github.com/open-telemetry/opentelemetry-java-examples/pull/547

do you want to add that to the registry?

https://github.com/open-telemetry/opentelemetry.io/pull/5819


Correct commands displayed in PR

Clicking to view the commands to enter in the console to integrate the PR should display the commands according to the selected integration method.

As far as I know, the repo settings only affect the actions you can take in a PR via the button.
You are allowed to merge however you want via CLI, as that's up to the repo owner (or someone with write permissions).

The purpose here is not to show how to replicate how gitea does merging - the instructions would not be concise otherwise - the purpose is to show one method of merging.

However, if say you wanted the instructions to change with the selected merge option you'd need to look at several files.
Gitea's merging methods are demonstrated here:
https://github.com/go-gitea/gitea/blob/0a9a484e1e2c082f7ebd747837e9c9557b3bacac/services/pull/merge.go#L241-L367
and would need to be turned into clear and understandable instructions.
You would need to change:
https://github.com/go-gitea/gitea/blob/0a9a484e1e2c082f7ebd747837e9c9557b3bacac/templates/repo/issue/view_content/pull.tmpl#L393-L406
probably to have the various options tabbed but have it change with the results of:
https://github.com/go-gitea/gitea/blob/0a9a484e1e2c082f7ebd747837e9c9557b3bacac/templates/repo/issue/view_content/pull.tmpl#L372-L390
likely keeping the current text as the default is there are no merge options set.


Couple of improvements to BlogSettingsViewModel.cs

improved async implementation behind API discovery BlogSettingsViewModel.cs removing unecessary synchronous blocking while trying to locate the RDS file via a
fixed RDS XML parsing implementation, was using incorrect (for root) or no (for descendants) namespace for elements (should be http://archipelago.phrasewise.com/rsd according to spec)

Cool stuff, didn't think about using TaskCompletionSource and then unwraping. Nice idea! Good renames too


Document coding style rules

 Issue by fbiville
Friday May 28, 2021 at 15:48 GMT
Originally opened as https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/1936

Target: CONTRIBUTING.md.
Ideally, automate it. Possible options for that:

https://editorconfig.org/
IntelliJ settings JAR
...

Ideally, the automated coding style generates as little change as possible in the codebase.

Resolved in commit dfcbbea


Suggestion: Introduce a CLI to allow synchronization and easy maintenance of project binaries

I found your project and thought it was a nice solution for managing standalone tools for golang projects. One case we have in our project is compiling SQL to Go using sqlc. This binary requires pinning. If one developer has a different version than another then  building the project could cause unnecessary or unintended changes to project files.
Currently we install sqlc inside a Justfile using go install .... We also use air and golangci-lint. What'd I'd like to do is make an easy way to manage these external dependencies. I currently use direnv to construct an ignored directory .bin in the project. Your tool fit right into this as I can just use curl to install the binaries into the .bin directory and update the PATH accordingly. The only problem I have is automatically installing updates when we bump the version.
I figured there was a solution to this with some scripting. I put together a little CLI script to download binaries via Goblin and keep track of what's installed with a .goblin and .goblin.lock files. I wrote it in python so I can slap it together relatively quickly to test out the idea. I'm happy to port it over to Go or some other language. I figured I'd drop by here, let you know my use case, and see if this project is interested in expanding its footprint by including something like this. I can surely maintain this separately on my own, so please feel free to tell me this doesn't belong here.
It's a bit hacky at the moment as it extracts the resolved version from the shell script returned by goblin.run. Should this be something more official or relied on, I'd probably want to add an API endpoint to return this information to improve stability. Here's the a brief setup for a project with this configured.
I dropped my tool into a GitHub repository here: https://github.com/brian-dlee/goblin-cli.

I like the idea of goblin maintaining the versions but it’s a slightly more bigger in scope and might take time. I consider it a valid feature and have thought of doing so myself but with a tad bit more functionality where if the builds are already available for a app it would download instead of build.
As for the version extraction, the resolution part of goblin can be exposed as an API if needed, it’s easier to add that and i’ll do that first

As for the version extraction, the resolution part of goblin can be exposed as an API if needed, it’s easier to add that and i’ll do that first

This should be closed by https://github.com/barelyhuman/goblin/pull/25 and will be a part of the next nightly docker build. I'll deploy that evening tomorrow (28th Sep, IST)


minimal deps CI

Add something to catch missing selectors.

since there's a bugfix (albeit obscure), be good to get this in.


Text on multiline or HTML

So I would like to have a more complicated toast msg than just a text...
How can I do a multiline msg? like
toast.success("Your registration was successfull!\n\nYou can log-in now")
I would not actually do that, but it's an example... I have many occasions to use multiline msg
also sometimes I would like to use some HTML inside like
toas.success("You have topped-up your account\nYour new balance is 10,000 sausages");
Is  there a way to do it?

version 0.0.5.
toast.info("Hello World.\n I am Tom", { dangerouslyHTMLString: true });

docs:
https://vue3-toastify.netlify.app/usage/render-html-string.html


Why is /self_destruct not working

Why is freeze_keyboard
freeze_mouse doesn't respond
Is it because of this
destroy = False keyboardFrozen = False mouseFrozen = False curr_window = None

No

Can I ask what does .idea do?

It was pycharm's preferences for the project. Removed, thank you for noting.


Increase Api version of Apex and VF to 43

Increase the Salesforce API version for Apex, Visualforce, and non-Managed Household Lightning Components to v43.0.
Required Changes:

Update some getter methods to explicitly define a setter.
Update SLDS page header component to use <svg aria-hidden="true" class="slds-icon"> for the icon instead of an <img> tag. This also required all pages that referenced the component to use a different icon name (removing the _120 portion).
Update the Nonprofit_CRM.app definition to use <tabs> instead of <tab>
Other minor updates

Critical Changes
Changes

All apex and visualforce metadata has been updated to the Summer '18 API (v43) Version. You may notice some minor color and visual styling changes to NPSP Settings, Payment Wizard, Manage Allocations and other custom pages in NPSP as these now all use the built-in Salesforce Lightning Design System (SLDS) styles. Note that the Manage Household page has not been restyled in this release.

Issues Closed
New Metadata

UTIL_SLDS_Icon Visualforce Component

Deleted Metadata

SLDS Static Resource. This component can be safely deleted from customer orgs.

Tracking W-017877

**lurch: attach W-025679

Tracking W-025679

@davisagli This PR removes the sdls static resource since it's no longer in use. However, given the recent issues we had with removing the UTIL_JobProgress VF Component, I wonder if it's better to leave the static resource in the repo (at least for now) and just change the file description to state that it's Deprecated. What do you think?

@force2b I think it is probably okay to remove -- https://help.salesforce.com/articleView?id=packaging_packageable_components.htm&type=5 lists static resources as developer deletable and https://help.salesforce.com/articleView?id=design_your_app.htm&type=5 doesn't mention any special considerations for them. Also, the package's "Deleted Components" shows another static resource that was previously deleted.

@davisagli Thanks for confirming.

@sam-knox Would you mind reviewing the PR description above?

@force2b - I made a couple of minor changes. In the description though, you have "Required Changes". Are those a summary of changes customers would need to make in any way, or a summary of changes that we've made?

Good questions @sam-knox. Required Changes meant changes I had to make as part of the api version change, but nothing customers have to make.

@force2b - Ok, thanks. My updates are all in now.


toEmit to accept matcher along exact values

Hi!
nice little utility.
I am wondering if it would be possible to extend toEmit to accept a matcher function as a first parameter (ie I want to test the a list of length of 2 is emitted).

Thanks! You can already use Jest Extended's toSatisfy for arbitrary checks, otherwise I have the same questions as here - what test would you write, if you could magically make it work?


Replace 'off' state with 'unavailable'

Fully match next alarm sensor state format.
Fixes #114.

Thank you

@KapJI let's just use one of the labels here, cause both of those are used for release-drafter. patch only bumps up x.x.Y while minor x.Y.x. This is probs patch IMHO

I think I misclicked it 🙂

I would have preferred the 'off' state tbh. I was using this integration (thank you btw, it's awesome) to trigger a morning automation. If the sensor went from "<<some_timestamp>>" to "off", that meant I stopped the alarm and I'd get out of bed.
The problem is, sometimes my speaker/the integration goes unavailable throughout the day or in the middle of the night.
That means: if this happens while an alarm is set, my morning automation will trigger and wake up everyone in the house (news starts playing on all of the speakers). The difference between "off" and "unavailable" is thus quite big for me.
Sad thing is that this integration has now become useless to me :(

Why can't you just check if it is unavailable instead of off? 🤔

I think if device is really unavailable, the state should be unknown. If it's not, it's a bug.

Why can't you just check if it is unavailable instead of off? 🤔

Because then if my speaker/integration goes unavailable because it's actually unavailable instead of me turning off the alarm, the automation could trigger randomly 😄

I think if device is really unavailable, the state should be unknown. If it's not, it's a bug.
Unfortunately, with device class timestamp, we can't use off.

Alright, I'll check! Thanks 😄

@r0667002 Right, that makes sense 😄 Hope you find a solution


Not Rendering in Game or Scene View

I've tried this with new and old versions of this project. How do I see the render output correctly? In the image you can see that some of the code is working in the margins of the inspector but there is clearly something wrong.

@DonnerTech Wow, this is really strange behaviour of the feature, something unexpected happened.
I've tested feature only on MacOS and it works correct, I need to check it on Windows.
I believe, smth went wrong with Blit function.
For better understanding, can you provide your pc specs?

@DonnerTech Found out that render pass attachments was messed up on Windows, looks like URP's Deferred pass bug 🫠
Forced set correct ones, should works.
Can you please check the last commit on master branch?

Appears to be working smoothly now! Great job and thank you.


WIP rework sync to not block initial return value

partially fixes #1238
TODO:

[ ] figure out if we can and want to emit the initial snapshot as part of blockStorageOperations$, and if not, see if we can add back in the log expectation

replaced by https://github.com/latticexyz/mud/pull/1315


Pause/resume inbound signal along with inbound op queue

Fixes AB#3430

Can you add some description on why this is needed. The bug link in internal only :-);


fix user_followers freeze

fix user_followers, user_followers does not work if you pass amount ( cl.user_followers(12345678, 5) )
https://github.com/adw0rd/instagrapi/issues/1280
tried it now and its ok

@SaeidB fixed https://github.com/adw0rd/instagrapi/commit/a43762488481cf97e2a64de3977eaaabff7bdf5e

New api does not have "count" in the params

I suspect this will probably also fix #1292, maybe also #1253

@SaeidB to me it appears as if only the user_following() function gives a 400 error, while the user_followers() function worked fine:

https://github.com/adw0rd/instagrapi/issues/1253#issuecomment-1518109329
#1292
https://github.com/adw0rd/instagrapi/issues/1050#issuecomment-1517630044

Has the API changed for both, though?


[RN][Android] Address New Architecture performance regressions by properly setting NDEBUG

Summary
It looks like we're not properly setting NDEBUG for "non debug" builds with CMake (the name is terrible but that's what Buck uses originally).
This configures NDEBUG correctly so that is set only for release variants, so that also REACT_NATIVE_DEBUG is set correctly (and we don't fire asserts on release builds).
This should address several performance regression we saw for New Architecture on some release scenarios (credits to @sammy-SC for spotting it).
Changelog
[ANDROID] [FIXED] - Address New Architecture performance regressions by properly setting NDEBUG
Test Plan
I've tested this by checking the ninja output for the debug/release builds for the YogaLayoutableShadowNode.cpp file
Debug (does not contain -DNDEBUG)
build ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/YogaLayoutableShadowNode.cpp.o: CXX_COMPILER__rrc_view_Debug /Users/ncor/git/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp || cmake_object_order_depends_target_rrc_view
  DEFINES = -Drrc_view_EXPORTS
  DEP_FILE = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/YogaLayoutableShadowNode.cpp.o.d
  FLAGS = -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -stdlib=libc++ -g  -fno-limit-debug-info -fPIC -Wall -Werror -std=c++17 -fexceptions -frtti -Wpedantic -Wno-gnu-zero-variadic-macro-arguments -DLOG_TAG=\"Fabric\" -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1
  INCLUDES = -I/Users/ncor/git/react-native/ReactCommon -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/folly/. -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/glog/exported -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/double-conversion/. -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/boost/boost_1_76_0 -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/fmt/include -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/fbgloginit/. -I/Users/ncor/git/react-native/ReactCommon/jsi -I/Users/ncor/git/react-native/ReactCommon/logger/. -I/Users/ncor/git/react-native/ReactCommon/react/renderer/graphics/platform/android -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/fb/include -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/yogajni/jni -I/Users/ncor/git/react-native/ReactCommon/yoga/. -isystem /Users/ncor/.gradle/caches/transforms-3/ebdfaf25aad9044f80de924d25488688/transformed/fbjni-0.3.0/prefab/modules/fbjni/include
  OBJECT_DIR = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir
  OBJECT_FILE_DIR = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir
  TARGET_COMPILE_PDB = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/
  TARGET_PDB = /Users/ncor/git/react-native/ReactAndroid/build/intermediates/cxx/Debug/193k1y15/obj/arm64-v8a/librrc_view.pdb

Release (does contain -DNDEBUG)
build ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/YogaLayoutableShadowNode.cpp.o: CXX_COMPILER__rrc_view_RelWithDebInfo /Users/ncor/git/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp || cmake_object_order_depends_target_rrc_view
  DEFINES = -Drrc_view_EXPORTS
  DEP_FILE = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/YogaLayoutableShadowNode.cpp.o.d
  FLAGS = -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -stdlib=libc++ -O2 -g -DNDEBUG -fPIC -Wall -Werror -std=c++17 -fexceptions -frtti -Wpedantic -Wno-gnu-zero-variadic-macro-arguments -DLOG_TAG=\"Fabric\" -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1
  INCLUDES = -I/Users/ncor/git/react-native/ReactCommon -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/folly/. -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/glog/exported -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/double-conversion/. -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/boost/boost_1_76_0 -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/fmt/include -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/fbgloginit/. -I/Users/ncor/git/react-native/ReactCommon/jsi -I/Users/ncor/git/react-native/ReactCommon/logger/. -I/Users/ncor/git/react-native/ReactCommon/react/renderer/graphics/platform/android -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/fb/include -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/yogajni/jni -I/Users/ncor/git/react-native/ReactCommon/yoga/. -isystem /Users/ncor/.gradle/caches/transforms-3/ebdfaf25aad9044f80de924d25488688/transformed/fbjni-0.3.0/prefab/modules/fbjni/include
  OBJECT_DIR = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir
  OBJECT_FILE_DIR = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir
  TARGET_COMPILE_PDB = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/
  TARGET_PDB = /Users/ncor/git/react-native/ReactAndroid/build/intermediates/cxx/RelWithDebInfo/53pv2v65/obj/arm64-v8a/librrc_view.pdb

Does this PR work?

bundleReleaseAar on https://github.com/facebook/react-native/commit/8486e191a170d9eae4d1d628a7539dc9e3d13ea4

$ git clone https://github.com/facebook/react-native
$ cd react-native
$ git checkout -b ndebug 8486e191a170d9eae4d1d628a7539dc9e3d13ea4
$ yarn install
$ ./gradlew :ReactAndroid:bundleReleaseAar

result in build.ninja-8486e19.zip

bundleReleaseAar on pre-commit https://github.com/facebook/react-native/commit/40c687c132ffc75f9db7dd4c42378ba676da2ea1

$ git checkout -b pre-ndebug 40c687c132ffc75f9db7dd4c42378ba676da2ea1
$ git clean -xdf
$ yarn install
$ ./gradlew :ReactAndroid:bundleReleaseAar

result in build.ninja-40c687c.zip
the only diff is hermes_executor_common gets one more -DNDEBUG, while it has got one
diff --git a/build.ninja-40c687c b/build.ninja-8486e19
index 3d18ff5..803f174 100644
--- a/build.ninja-40c687c
+++ b/build.ninja-8486e19
@@ -2313,7 +2313,7 @@ build cmake_object_order_depends_target_hermes_executor_common: phony || cmake_o

 build ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir/HermesExecutorFactory.cpp.o: CXX_COMPILER__hermes_executor_common_RelWithDebInfo<EMAIL_ADDRESS>|| cmake_object_order_depends_target_hermes_executor_common
   DEP_FILE = ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir/HermesExecutorFactory.cpp.o.d
-  FLAGS = -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -stdlib=libc++ -O2 -g -DNDEBUG -fPIC -Wall -Werror -std=c++17 -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1
+  FLAGS = -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -stdlib=libc++ -O2 -g -DNDEBUG -fPIC -Wall -Werror -std=c++17 -DNDEBUG -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1
   INCLUDES =<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>-isystem<EMAIL_ADDRESS>-isystem /Users/sunbreak/.gradle/caches/transforms-3/66320240bbe75de87a836edd5ab4b056/transformed/fbjni-0.3.0/prefab/modules/fbjni/include
   OBJECT_DIR = ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir
   OBJECT_FILE_DIR = ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir
@@ -2322,7 +2322,7 @@ build ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir/HermesEx

 build ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir/JSITracing.cpp.o: CXX_COMPILER__hermes_executor_common_RelWithDebInfo<EMAIL_ADDRESS>|| cmake_object_order_depends_target_hermes_executor_common
   DEP_FILE = ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir/JSITracing.cpp.o.d
-  FLAGS = -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -stdlib=libc++ -O2 -g -DNDEBUG -fPIC -Wall -Werror -std=c++17 -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1
+  FLAGS = -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -stdlib=libc++ -O2 -g -DNDEBUG -fPIC -Wall -Werror -std=c++17 -DNDEBUG -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1
   INCLUDES =<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>-isystem<EMAIL_ADDRESS>-isystem /Users/sunbreak/.gradle/caches/transforms-3/66320240bbe75de87a836edd5ab4b056/transformed/fbjni-0.3.0/prefab/modules/fbjni/include
   OBJECT_DIR = ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir
   OBJECT_FILE_DIR = ReactCommon/hermes/executor/CMakeFiles/hermes_executor_common.dir

the only diff is hermes_executor_common gets one more -DNDEBUG, while it has got one

The Android NDK already adds NDEBUG for release builds. The problem we were facing is that, due to some NDK toolchain issues, the NDEBUG flag is not always added for all the targets. So we re-added to be sure every target has it. I'll revisit this after NDK 25

Release (does contain -DNDEBUG)
build ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/YogaLayoutableShadowNode.cpp.o: CXX_COMPILER__rrc_view_RelWithDebInfo /Users/ncor/git/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp || cmake_object_order_depends_target_rrc_view
  DEFINES = -Drrc_view_EXPORTS
  DEP_FILE = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/YogaLayoutableShadowNode.cpp.o.d
  FLAGS = -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -stdlib=libc++ -O2 -g -DNDEBUG -fPIC -Wall -Werror -std=c++17 -fexceptions -frtti -Wpedantic -Wno-gnu-zero-variadic-macro-arguments -DLOG_TAG=\"Fabric\" -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DFOLLY_HAVE_RECVMMSG=1 -DFOLLY_HAVE_PTHREAD=1 -DFOLLY_HAVE_XSI_STRERROR_R=1
  INCLUDES = -I/Users/ncor/git/react-native/ReactCommon -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/folly/. -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/glog/exported -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/double-conversion/. -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/boost/boost_1_76_0 -I/Users/ncor/git/react-native/ReactAndroid/build/third-party-ndk/fmt/include -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/fbgloginit/. -I/Users/ncor/git/react-native/ReactCommon/jsi -I/Users/ncor/git/react-native/ReactCommon/logger/. -I/Users/ncor/git/react-native/ReactCommon/react/renderer/graphics/platform/android -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/fb/include -I/Users/ncor/git/react-native/ReactAndroid/src/main/jni/first-party/yogajni/jni -I/Users/ncor/git/react-native/ReactCommon/yoga/. -isystem /Users/ncor/.gradle/caches/transforms-3/ebdfaf25aad9044f80de924d25488688/transformed/fbjni-0.3.0/prefab/modules/fbjni/include
  OBJECT_DIR = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir
  OBJECT_FILE_DIR = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir
  TARGET_COMPILE_PDB = ReactCommon/react/renderer/components/view/CMakeFiles/rrc_view.dir/
  TARGET_PDB = /Users/ncor/git/react-native/ReactAndroid/build/intermediates/cxx/RelWithDebInfo/53pv2v65/obj/arm64-v8a/librrc_view.pdb

And the CMAKE_BUILD_TYPE is always RelWithDebInfo, as the path of TARGET_PDB indicated

Which means only hermes_executor_common's CMakeLists.txt work
# ReactAndroid/src/main/jni/first-party/fb/CMakeLists.txt
if(${CMAKE_BUILD_TYPE} MATCHES Release)
        add_compile_options(-DNDEBUG)
endif()

# ReactCommon/hermes/executor/CMakeLists.txt
else()
        target_compile_options(
                hermes_executor_common
                PRIVATE
                -DNDEBUG
        )
endif()

@Sunbreak can you clarify what you're reporting?

The Android NDK already adds NDEBUG for release builds. The problem we were facing is that, due to some NDK toolchain issues, the NDEBUG flag is not always added for all the targets. So we re-added to be sure every target has it. I'll revisit this after NDK 25

If another NDEBUG is necessary for some NDK toolchain, then we should use RelWithDebInfo
if(${CMAKE_BUILD_TYPE} MATCHES RelWithDebInfo)
        add_compile_options(-DNDEBUG)
endif()

Ah I see. Can I ask you why are you reporting this? Have noticed some regressions? The NDK should already add NDEBUG correctly, but yes we can update the matches from Release to RelWithDebInfo

Yep. We have been using Fabric in our APP for several versions. Hanging around and find this PR.

New Architecture performance regressions, is there any regression?
How could we measure the regressions, e.g. Systrace section in ReactInstanceManager?

The Android NDK already adds NDEBUG for release builds. The problem we were facing is that, due to some NDK toolchain issues, the NDEBUG flag is not always added for all the targets. So we re-added to be sure every target has it. I'll revisit this after NDK 25

https://stackoverflow.com/a/73185101
Just found out Release is moved since r23b, with which I tested locally
Maybe we should use Release for pre-r23b NDK

Maybe we should use Release for pre-r23b NDK

I actually prefer the current setup which checks NOT 'Debug' so we don't need to check which flavor of Release we're using


FS-4916 add workflows support

Coverage decreased (-0.3%) to 94.979% when pulling 05909c575c63316d725be25d0ed99decef945d71 on feature/fs-4916_add_workflows into e1773e2254d2a451216e13ce8ecb4f69f863ac82 on develop.

Coverage decreased (-0.3%) to 94.979% when pulling 05909c575c63316d725be25d0ed99decef945d71 on feature/fs-4916_add_workflows into e1773e2254d2a451216e13ce8ecb4f69f863ac82 on develop.

Coverage decreased (-0.3%) to 94.979% when pulling 05909c575c63316d725be25d0ed99decef945d71 on feature/fs-4916_add_workflows into e1773e2254d2a451216e13ce8ecb4f69f863ac82 on develop.


put dummy_forced_read inside a SANITY ifdef

branch builds are failing due to unused function dummy_forced_read.  Calls to this function are inside a SANITY ifdef.  This PR wraps the function definition inside a SANITY ifdef.

I have exactly same PR and am waiting for an approval from somebody from a different company.
https://github.com/apache/trafficserver/pull/11848

duplicate PR


[DOCS] Add explanation for deduplicate command

Change Logs
Add explanation for deduplicate command to the docs.
I've also updated the example in the docs to have a temp path for the repaired_output_path to avoid confusion.
Impact
None. No code changes involved
Risk level (write none, low medium or high below)
Low
Documentation Update
Contributor's checklist

[X ] Read through contributor's guide
[ X] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@yesemsanthoshkumar Thanks for the contribution.  I've backported your changes to the docs of older releases too.


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Minor Changes

Adds the ability for users to delete their own accounts, as long as they have permission to do so (#1307) by @jescalan

Patch Changes

Password, first name & last name fields will be disabled if there are active SAML accounts. (#1326) by @yourtallness

Updated dependencies [9651658c, 4e1bb2bd, eed73021, a23a3cc8]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Adds the ability for users to delete their own accounts, as long as they have permission to do so (#1307) by @jescalan

Introduce nb-NO localization (#1376) by @Richard87

Patch Changes

Fix "Sign in" text for the Korean localization (#1371) by @perkinsjr

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Adds the ability for users to delete their own accounts, as long as they have permission to do so (#1307) by @jescalan

Patch Changes

Password, first name & last name fields will be disabled if there are active SAML accounts. (#1326) by @yourtallness

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [9651658c, 4e1bb2bd]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Need well defined user stories.

This project needs at least one user story describing who would be using the output of DECOY and for what purpose.

One goal that came up in chatting with @rwaitman is verification of tools to convert to CDM.
Suppose

di() loads DECOY data into i2b2,
oi() loads DECOY data into OMOP, and
g() transforms i2b2 to PCORnet CDM, and
h() transforms OMOP to PCORnet CDM.

Then given DECOY data d0, we (developers of conversion tools) could test that queries against g(di(d0)) give the same answers as h(oi(d0)).
And any time we find a bug or issue in g(), we should be able to represent it in DECOY and test whether it shows up in h(). And vice versa.
TODO: migrate this user story to DECOY docs.

Do we use OMOP for anything? As far as I know, we only use di(d0) and g(di(d0))
Also, what format is raw d0 going to be in? Clarity?

d0 is going to be in CSV format. That's the DECOY data.
GPC currently has no requirements to use OMOP, but OMOP has come up in the inter-CDRN ModelMashUp discussion as far back as Apr 2014, and as we expand our focus from GPC to the larger PCORnet community, its relevance increases.
The evolution of OMOP is OHDSI (pronounced like "odyssey"). The OHDSI Guiding Principles, especially the bits about transparency and open source, are pretty enticing. It's a community I'm interested to collaborate with.

d0 is going to be in CSV format. That's the DECOY data.

I guess I meant, what is the native data model of the DECOY data? I.e. how are patients, visits, and facts represented? In one CSV file or in several? What columns will exist? Does anything except DECOY emit data structured in that manner?

Those questions represent a large part of the design space of DECOY; none of them is settled.

Well, if we're going to write an ETL for a completely new datasource none of us use, I nominate the OpenEMR data model. In fact, IIRC they may already have simulated data that will save us the trouble.

Good idea; merits its own issue.
I think the github workflow might help if you open it. I'll stand by, and if you don't get around to it, I can do it.

Do you mean OpenMRS?

Sure, them too, why not?
Looks like they have a standalone dataset.

And then there's VistA (the VA EMR, which is also open-source). Took a while to find the useful page, but here it is:
https://www.osehra.org/content/distributions-vista
Apparently a bunch of forks to choose from, yay.

DECOY came up in a chat with @russwaitman and he elaborated on motivation; see ETL cross-checking.
It's similar to the g(di(d0)) discussion above, but more clear I think.


Monsters can walk through walls

Hi, I have mentioned it in my previous issue, but this might be separate problem.
So we have a tiles (foundations), that have flag "bridge", these are used mainly in static stairs, and allow you to walk stairs into the next level in static houses.
These tiles are also used in many places like dungeons etc....
The problem is, that the monsters can walk through walls that are placed on such foundation with flag "bridge".

https://i.gyazo.com/9dd33ae276b02ba58199500ef74422b0.mp4

Is it a specific location or custom location? If it's exists on map I'd like to get it's coordinates for checks.

yes its terathan keep, 5336,1743,5 or 5336,1692,5

May you have different muls on server and client? Because for me at the location there is only normal dungeon for me but I see that stones used at terathan keep and seems like players can pass on it, seems a bit silly but I wonder if it's client-side or sphere-side issue.  Need to check how sphere works on other half blocks before make a decision.

check the video
its in terathan, yes normal dungeon
https://i.gyazo.com/9dd33ae276b02ba58199500ef74422b0.mp4

this is where I tp when I enter the coordinates you gave, this is why I asked

OH OMG sorry, I didnt realised that i have moved the dungeons to other places.
Its out here.

No no, I am exactly the location you shown on the map, but seems like your map files not comes from original uo (or changed in time), because I am using original muls just update them couple of days ago, if they are custom, there could be some issues, you may need to check the wall flags, because they can be wrong or missing. Even I asked position because it seems buggy for me while the left wall starts middle of the block.
For the issue, to check I can probably do some tests to see if npcs walk through walls if they are on slabs.

I did some test on my own, but none of them walk through walls for me honestly, I also think walking on that slabs so stupid but other that that, npcs acting normally while moving around.

I removed but there were more than 10 enemies from different types around but none of them goes in, and wrym never leave the area, I don't know what happens on your map but probably can be caused from broken mul files. I can't tell it's on mul-base issue, but honestly everything working fine on my latest build.

Im using original files too, I just copied the black part of map where the dungeons are from different one.
I dont think that Fiddler would bug that. Also no changes to walls or anything else.
Let me try more.

Well I guess the solution is in tiledata, removing the flag "bridge" and setting height to 5 so you can still walk on it.
Then the Monsters cant walk through. 😫


Use sys.path.insert(1, v_path) instead of sys.path.append(v_path)

Packages under pipenv/vendor should be used than that installed by pip.
This will resolve package conflict issues like https://github.com/kennethreitz/pipenv/issues/355.
pipenv/vendor  will be inserted into sys.path after the script directory.
cf. https://docs.python.org/3/library/sys.html#sys.path, http://stackoverflow.com/a/10097543
Before
$ pip3 install click==0.4
$ pipenv
Traceback (most recent call last):
  File "/usr/local/bin/pipenv", line 11, in <module>
    load_entry_point('pipenv==4.0.1', 'console_scripts', 'pipenv')()
  File "/usr/local/lib/python3.5/dist-packages/pkg_resources/__init__.py", line 560, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/local/lib/python3.5/dist-packages/pkg_resources/__init__.py", line 2648, in load_entry_point
    return ep.load()
  File "/usr/local/lib/python3.5/dist-packages/pkg_resources/__init__.py", line 2302, in load
    return self.resolve()
  File "/usr/local/lib/python3.5/dist-packages/pkg_resources/__init__.py", line 2308, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python3.5/dist-packages/pipenv/__init__.py", line 14, in <module>
    from .cli import cli
  File "/usr/local/lib/python3.5/dist-packages/pipenv/cli.py", line 955, in <module>
    def shell(three=None, python=False, compat=False, shell_args=None):
  File "/usr/local/lib/python3.5/dist-packages/click/decorators.py", line 108, in decorator
    return _make_command(f, name, attrs, cls)
  File "/usr/local/lib/python3.5/dist-packages/click/decorators.py", line 82, in _make_command
    callback=f, params=params, **attrs)
TypeError: __init__() got an unexpected keyword argument 'context_settings'
zsh: exit 1     pipenv

After
$ pip3 install click==0.4
$ pipenv
Usage: pipenv [OPTIONS] COMMAND [ARGS]...

Options:
  --where          Output project home information.
  --venv           Output virtualenv information.
  --rm             Remove the virtualenv.
...

Hey @nonylene, thanks for this! This seems like an appropriate fix for the path conflicts :)


Room member details: display matrix id when user taps on display name

The display name and the matrix id should not be displayed at the same time.
The same label is used for both.
The text of this label switches between display name and matrix id at each user tap.

It has been fixed.


Add support for iscsi vlan tagging

Referenced the PR https://github.com/hpe-storage/python-3parclient/pull/30 and made changes on
"from hpe3parclient import showport_parser" and "return {'iSCSIPortInfo' : {'vlan' : vlan}}"

@shaik-gousa-khaja-asif Please check https://github.com/hpe-storage/python-3parclient/blob/master/hpe3parclient/client.py#L3748  as it has return body. But it will throw error for variable not defined, if removeFromTarget is set to true.

@shaik-gousa-khaja-asif  Also please add unittests.

@shaik-gousa-khaja-asif Also please add unittests.

Unit tests are there in test/test_HPE3ParClient_ShowportParser.py


(maint) Merge up 3.13.x to master

* upstream/3.13.x:
  (packaging) Updating the FACTER.pot file
  travis
  (FACT-2054) Facter::Core::Execution.execute expands shell builtins
  (maint) Bump leatherman to 1.6.3 on travis and appveyor
  (maint) Bump leatherman to 1.4.9 in appveyor
  (maint) bump leatherman to 1.4.9 in travis

Conflicts:
.travis.yml
appveyor.yml

CLA signed by all contributors.


Python filesystems rewrite?

Description
:warning: This is a rough draft for now, since I want to make sure this new approach makes sense.
This PR would deprecate the existing DeltaStorageHandler that subclasses pyarrow.FileSystem in favor of a DeltaFileSystem that has a to_pyarrow() method to get the equivalent PyArrow filesystem. The idea is that for reading and writing data files we should use the PyArrow ones, while the delta log is read by the delta-rs one.
The other approach I looked at initially is just filling in the methods
Some notes on each filesystem:

S3: PyArrow's S3 filesystem is more optimized than what we'd be able to write here and is already complete, so for S3 it's a clear win.
GCS: PyArrow doesn't have GCS bindings yet, but the C++ implementation is done and the Python bindings are in progress. So we should expect that soon 🤞.
ADLS: ADLS is held up in PyArrow because the C++ library uses C++ 14 while Arrow is strictly C++ 11, at least for another year or so 😞 . However, there is a community-supported fsspec implementation of ADLS, which could be combined with PyArrow's fsspec handler.

So if we went with this, we'd soon have 2 of 3 file systems already supported in the writer, and one that could be supported if another library is added as an optional dependency.
Related Issue(s)
For example:

closes #570

Documentation

Alternatively, maybe what we should do is create a FileSystem Rust object that can wrap any pyarrow.FileSystem object, and impl StorageBackend for that. You could even support any arbitrary fsspec filesystem through that too, and that's likely what Python users would want. Only hard thing there is making sure we don't get deadlocks with the GIL 😬

I think the interface we'd like to aim for is having filesystem parameters that can accept any pyarrow.FileSystem and fsspec filesystem. We don't want to use these as is, at least by default, since they don't support rename_obj_noreplace and that's required for concurrent writers. (Not all users may need this, but I think there's a strong case this should be supported by default.)
I think there's three different solutions we can implement:

For the main pyarrow.FileSystem ones (S3 and soon GCS), we should automatically map them internally to their associated StorageBackend, and use that for delta log interaction. The other benefit of using these two separate filesystems is that they can each operate without the Python GIL and thus use multiple threads.
For any other fsspec filesystem, we write a SafeDeltaFileSystem abstract mix-in that users could implement to add a rename_noreplace method and create a StorageBackend implementation that can wrap classes that use that mixin. This allows concurrent writers, but would be less performant than (1) since the GIL would preclude multi-threaded reads of the delta-log (though I honestly have no idea how noticeable that would be).
For users that don't care about concurrent writers, we could also implement a wrapper around fsspec filesystems that just used it's move method for rename_noreplace. We would obviously want to document the caveat, but I imagine there are use cases where users would be fine with that.

Personally I think your approach makes a lot of sense.
There may be however an opportunity to support files systems not supported by pyarrow out of the box without the need to have users provide a custom implementation. Once #573 lands  we should be able to write RecordBatches to the delta table using the storage backends from this crate. Obviously this will initially only support simple updates, but there are some experiments about (#523) using the datafusion query engine that could be extended to also support spark-like delta SQL syntax for more complex updates.
Haven't really thought about it yet, if this could be fully transparent to the python users, but thanks to arrow moving record batches across language boundaries should be very cheap :).

Alternatively, maybe what we should do is create a FileSystem Rust object that can wrap any pyarrow.FileSystem object, and impl StorageBackend for that.

This would require ser/de between rust bytes and python bytes across language runtime on every write isn't it? The current storage backend abstraction in Rust core is not very well designed because it requires reading the whole object into memory before passing the data down to the caller. Ideally, the abstraction should support streaming read so we can parse json/parquet in a streaming fashion. So this is another thing to consider in the future if we want to go this route.

Ideally, the abstraction should support streaming read so we can parse json/parquet in a streaming fashion.

@houqp I'm now thinking it might be better to simply work on improving the delta-rs filesystems and continue wrapping those in the Python module. For streaming reads and writes, is there a particular trait we should be implementing?
It's unclear to me what the parquet crate accepts. datafusion has an ObjectStore and ObjectReader traits, but that create is also an optional dependency.

For streaming reads and writes, is there a particular trait we should be implementing?

I think the ObjectStore trait in datafusion is a good one to adopt. I have been pushing datafusion to move the object store abstraction out of the core so we can reuse it in delta-rs ;)
async read/write has been added to the parquet2 create a long time ago. async read has been added to parquet-rs recently, see https://github.com/apache/arrow-rs/pull/1154. I have been working on parquet2 migration on and off at https://github.com/delta-io/delta-rs/pull/465. We likely will need to support both parquet crates with a feature flag for some time until we are confident that parquet2 can cover all our use-cases. It's supposed to be the fastest parquet implementation out there, so I am hoping that we will get a decent performance boost from the migration.


[zh] Sync multiple-zones.md

Sync with en text
Fix minor errors about newline char
Add anchors

content/zh-cn/docs/setup/best-practices/multiple-zones.md

/lgtm

Just rebased with main to resolve the conflicts.

/lgtm
/approve


Electron starts up more slowly than equivalent node version in RUN_AS_NODE mode

Is there more that could be done to remove Electron specific startup from the ELECTRON_RUN_AS_NODE code path?
$ node -v
v5.1.1
$ time for i in {1..500}; do node -e "process.stdout.write('$i ');"; done
1 ... 500

real	0m47.700s
user	0m39.759s
sys	0m7.419s

$ export ELECTRON_RUN_AS_NODE=1
$ dist/Electron.app/Contents/MacOS/Electron -v
v5.1.1
$ time for i in {1..500}; do dist/Electron.app/Contents/MacOS/Electron -e "process.stdout.write('$i ');"; done
1 ... 500

real	0m39.813s
user	0m28.434s
sys	0m9.674s

The size of Electron's binary is much larger than Node, and Electron links with much more system libraries, so it would start slower.


Switch to GCC 10 as the default compiler

Scope & Purpose
(Please describe the changes in this PR for reviewers - mandatory)

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[x] No backports required
[ ] Backports required for: (Please specify versions and link PRs)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket number:
[ ] Design document:

Testing & Verification
(Please pick either of the following options)

[ ] This change is a trivial rework / code cleanup without any test coverage.
[ ] The behavior in this PR was manually tested
[x] This change is already covered by existing tests, such as (please describe tests).
[ ] This PR adds tests that were used to verify all changes:

[ ] Added new C++ Unit tests
[ ] Added new integration tests (e.g. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

[ ] There are tests in an external testing repository:
[ ] I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:
Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

[ ] Added entry to Release Notes
[ ] Added a new section in the Manual
[ ] Added a new section in the HTTP API
[ ] Added Swagger examples for the HTTP API
[ ] Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

Although the error message indicates that pthread.h was not found, what actually fails is the following:
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_0f8df.dir/link.txt --verbose=1
/usr/lib/ccache/bin/gcc -fpic -fPIC -fpie -fPIE -static-pie -fno-stack-protector  -Wl,--build-id -fpic -fPIC -fpie -fPIE -static-pie -fno-stack-protector -static  CMakeFiles/cmTC_0f8df.dir/CheckIncludeFile.c.o -o cmTC_0f8df
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a PIE object
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/crtend.o: relocation R_X86_64_32 against `.ctors' can not be used when making a PIE object; recompile with -fPIE

/ # echo "int main() { return 0; }" > test.c
/ # gcc -static test.c
/ # ldd a.out
/lib/ld-musl-x86_64.so.1: a.out: Not a valid dynamic program
/ # gcc  test.c
/ # ldd a.out
        /lib/ld-musl-x86_64.so.1 (0x7feec7c40000)
        libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7feec7c40000)
/ # gcc -fPIE -static test.c
/ # gcc -fPIE -fPIC -static test.c
/ # gcc -fPIE -fPIC -static-pie -static test.c
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a PIE object
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/crtend.o: relocation R_X86_64_32 against `.ctors' can not be used when making a PIE object; recompile with -fPIE
collect2: error: ld returned 1 exit status
/ # gcc -fPIE -fPIC -static-pie test.c
/ # ldd a.out
        /lib/ld-musl-x86_64.so.1 (0x7f3645c16000)
/ # gcc -fPIE -fPIC -static test.c
/ # ldd a.out

Looks like static-pie is the problem here. 😞


chore(nexus): add context management and wait groups to connection, clean up

copilot:summary

Closing in favor of #23


feat(clerk-js,types): Support connecting Coinbase Wallet via

Description

Allow users to connect their Coinbase Wallet to their account via <UserProfile />
https://github.com/user-attachments/assets/6989682b-a938-4b2f-9ddb-e76e52cbd92c

Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Doesn't look like it would be included in this PR, but highlighting that the logo - name spacing is a bit off here. The logo is almost touching the name coinbase.

Can we add a UI ticket to follow up and improve here?

Sure we can do that. Which team should handle such improvements/tickets?

Doesn't look like it would be included in this PR, but highlighting that the logo - name spacing is a bit off here. The logo is almost touching the name coinbase.

Can we add a UI ticket to follow up and improve here?

@alexcarpenter it was an easy fix so i went ahead and fixed that as well as part of this PR. That's how it looks right now:


Add Amazon block storage refresh worker class

Specification of this class is required for MiQ to be aware of the new
refresh worker supporting Amazon block storage refresh parser.
This PR is required by https://github.com/ManageIQ/manageiq-providers-amazon/pull/101.
@miq-bot add_label providers/amazon

@gberginc

This PR is required by  ManageIQ/manageiq-providers-amazon#101.

You mean this PR requires ManageIQ/manageiq-providers-amazon#101, don't you?

@roliveri honestly, I thought it is "required" by the other PR. If these classes are not registered, the refresh worker is of course not started. However, I didn't think about the other way around.
Unfortunately, I don't know how best to approach such commits that span across multiple repositories.

@roliveri dependent PR(https://github.com/ManageIQ/manageiq-providers-amazon/pull/101) has just been merged by @Ladas.

@gberginc close&open the PR, it will restart the CI, it should pass now

@miq-bot add_label euwe/no

Closing in favour of https://github.com/ManageIQ/manageiq/pull/13569


why does it keep source file extension?

Hi,
I wonder if it the most logical behavior to keep the source file extension in the rendered file name.
ex:
if i give boo.md as source file
i will have the file boo.md.pdf created
wouldn't it be more logical to have boo.pdf ?
PS: gg for the nice work !

We could replace pdfbuilder.py l.78
from
self.pdf_name = file.strip('\\/') + ".pdf"

to
self.pdf_name = os.path.splitext(file)[0] + ".pdf"

Since i don't understand either why there is such split here.
It prevents to give an absolute path as argument
ex:
if i give /this/is/an/absolute/path as source file
it will try to create file this/is/an/absolute/path.pdf
which will likely fail


Medical Wall Locker Hotfix

Changelog:

Fixes locker names (After the last fix, this was still wrong.)

Before:

After:

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Why is the filled one called medicine but the non-filled is medical?

Why is the filled one called medicine but the non-filled is medical?

The non-filled is just the generic department locker that the others inherit from. Each dept has one.


Implement Homepage

What would you like to be added:
Design Link to be seen here
Sections include the ff:

Search
Dashboard Information
Blocks and Transactions
Liquidity Pool Pairs

Why is this needed:
Use as landing page for Defiscan

Prototype can be seen here

I assigned the entire issue to @aikchun instead for easier management of code.

Total DFI burned is indicated in billions (207.50 B) on homepage. I believe it should be in millions :)

Total DFI burned is indicated in billions (207.50 B) on homepage. I believe it should be in millions :)

Thanks @RomanShumkov for catching the error! The fix has been made in #394.


[DUOS-482][risk=no] Revert some changes that are already on dev

Fix up branch for https://github.com/DataBiosphere/duos-ui/pull/329

Closing ... will submit in a different format.


Kotlin DSL generated accessors for precompiled scripts should have normalized line endings

Expected Behavior
Generated source code for Kotlin DSL accessors for precompiled scripts have normalized line endings, maximizing build cache reuse.
Current Behavior
Generated source code for Kotlin DSL accessors for precompiled scripts have platform dependent line endings.

Fixed in https://github.com/gradle/gradle/pull/16001


fix: only test against 7.x and 8.x

"8.x" doesn't work yet since 8.0.0 is not released yet. We just implemented "N.*" with bazelisk, which will also fetch rc.

"8.x" doesn't work yet since 8.0.0 is not released yet. We just implemented "N.*" with bazelisk, which will also fetch rc.

Thank you.


CI: use same version of golang in build and test steps

CI is really flaky, I dont understand. I hope this will help.


Add Alexa Video Preamble Option

Proposed changes
Add the ability for Alexa to read a preamble message before starting a video by adding a fourth parameter to the showVideo() method:
Original method:
this.alexaSkill().showVideo('https://www.url.to/video.mp4', 'Any Title', 'Any Subtitle');

Optional preamble:
this.alexaSkill().showVideo('https://www.url.to/video.mp4', 'Any Title', 'Any Subtitle', 'Get ready to watch your video!');

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

Thanks Oscar!


Write installation instruction and general use instructions

[x] Usage guide
[x] Installation guide

Fixed here https://github.com/Warthunder-Open-Source-Foundation/wt_custom_lang/commit/4040d588efa4a19ef5164ddc1bdf037957fe37c3


GUI: panics if bitcoind connection lost for 60 seconds

When using Liana with an already-installed wallet, if bitcoind stops for 60 seconds, the GUI panics and closes with:
ERROR liana:55: panic occurred at line 433 of file /home/jp1ac4/.cargo/git/checkouts/liana-efb3a908181ef2cf/85d470d/src/bitcoin/d/mod.rs: Some("We must not fail to make a request for more than a minute: Server(Transport(Minreq(IoError(Os { code: 111, kind: ConnectionRefused, message: \"Connection refused\" }))))")
   0: liana::setup_panic_hook::{{closure}}
   1: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/alloc/src/boxed.rs:1999:9
      std::panicking::rust_panic_with_hook
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:709:13
   2: std::panicking::begin_panic_handler::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:597:13
   3: std::sys_common::backtrace::__rust_end_short_backtrace
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/sys_common/backtrace.rs:151:18
   4: rust_begin_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:593:5
   5: core::panicking::panic_fmt
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/panicking.rs:67:14
   6: core::result::unwrap_failed
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/result.rs:1651:5
   7: liana::bitcoin::d::BitcoinD::chain_tip
   8: <liana::bitcoin::d::BitcoinD as liana::bitcoin::BitcoinInterface>::chain_tip
   9: <alloc::sync::Arc<std::sync::mutex::Mutex<dyn liana::bitcoin::BitcoinInterface>> as liana::bitcoin::BitcoinInterface>::chain_tip
  10: liana::bitcoin::poller::looper::new_tip
  11: liana::bitcoin::poller::looper::updates
  12: liana::bitcoin::poller::looper::looper
  13: std::sys_common::backtrace::__rust_begin_short_backtrace
  14: core::ops::function::FnOnce::call_once{{vtable.shim}}
  15: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/alloc/src/boxed.rs:1985:9
      <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/alloc/src/boxed.rs:1985:9
      std::sys::unix::thread::Thread::new::thread_start
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/sys/unix/thread.rs:108:17
  16: start_thread
             at ./nptl/pthread_create.c:442:8
  17: clone3
             at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

Perhaps there should be an indication in the GUI that the connection has been lost so that the user can try to restart bitcoind.

Yes, we need lianas daemon to not panic and to return errors in its API when failing to connect to bitcoind

We've got the interface to do that already, i can PR a patch.

Ah, I see. Shall I leave this open pending those other issues being completed?

I think this can be closed.
------- Original Message -------
On Friday, September 1st, 2023 at 12:05 PM, jp1ac4 @.***> wrote:

Ah, I see. Shall I leave this open pending those other issues being completed?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


fix(module:popconfirm): add nzOkDanger option for nz-popconfirm

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
nzOkType="danger" is not applied to the ok button
Issue Number: #6864
What is the new behavior?
adding new property as nzOkDanger to apply Danger style to the ok button
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

I guess, same as for the Modal Footer component, maybe the migration steps needed here ?

Other information

Hi, could you please make danger still work? We do not want to introduce this breaking change in the next version but rather see this as a bug. This seems more user-friendly IMHO. Thanks for your work!

Hi, could you please make danger still work? We do not want to introduce this breaking change in the next version but rather see this as a bug. This seems more user-friendly IMHO. Thanks for your work!

Sure I can adjust, the question is how :)
Should I adjust NzButtonType to add back the danger or just locally this component accepts NzButtonType | 'danger' values ? I feel adding back to the NzButtonType type, would make uneasy, as it means everywhere should accept this value, but without it, seems more like a patchwork which should be resolved.

It looks better to me to patch it in the popconfirm component, since this approach would not introduce new API. We can see if it is necessary to add a new API in the future. But for now this simple workaround is adequate now.