When uploading: error doing PATCH request to data gateway

Describe the bug
File uploads via the web ui fail and the server has a high CPU usage without any user activity.
Steps to reproduce
Try to upload a file via the web ui.
Expected behavior
The upload succeedes and the file is available.
Actual behavior
Upload fails with Unknown Error. For other users, the upload seemes to have succeded, but the file is grayed out and not available.
The log the contains entries like this:
{"level":"error","service":"ocdav","name":"com.owncloud.web.ocdav","traceid":"8ff9c83be64eddf7f24fc1f19a3c2769","request-id":"6dde09b8-4611-4743-a38e-bd8605657e00","path":"/public/POcnTlUcNrxpUXb/<redacted>","error":"Patch \"https://cloud.catboy.house/data/<redacted>\": context canceled","time":"2024-09-25T06:49:43Z","message":"error doing PATCH request to data gateway"}

Also, this log keeps popping up
{"level":"error","service":"postprocessing","uploadID":"da362552-3dfb-4952-a535-89226a610a0f","error":"Failed to delete data: nats: timeout","time":"2024-09-25T07:27:18Z","message":"cannot delete upload"}

Setup
The server is managed via Ansible.
The container setup is this:

- name: 🚀 Starts container
  community.docker.docker_container:
    name: "{{ owncloud_container_name }}"
    image: owncloud/ocis
    state: started
    restart_policy: unless-stopped
    ports:
      - "{{ docker_gateway }}:{{ owncloud_service_port }}:9200"
    entrypoint:
      - /bin/sh
    command: ["-c", "ocis init || true; ocis server"]
    env:
      OCIS_INSECURE: "false"
      OCIS_URL: "https://{{ owncloud_domain }}"
      PROXY_HTTP_ADDR: "<IP_ADDRESS>:9200"
      PROXY_TLS: "false"
      OCIS_LOG_LEVEL: "warn"
      OCIS_ADD_RUN_SERVICES: "notifications"
      NOTIFICATIONS_SMTP_HOST: "{{ smtp_server }}"
      NOTIFICATIONS_SMTP_PORT: "{{ smtp_port }}"
      NOTIFICATIONS_SMTP_SENDER: "{{ owncloud_smtp_sender }}"
      NOTIFICATIONS_SMTP_USERNAME: "{{ owncloud_smtp_user }}"
      NOTIFICATIONS_SMTP_PASSWORD: "{{ owncloud_smtp_password }}"
      NOTIFICATIONS_SMTP_INSECURE: "false"
    user: "{{ owncloud_uid }}:{{ app_gid }}"
    volumes:
      - "{{ owncloud_volume_config }}:/etc/ocis"
      - "{{ owncloud_volume_data }}:/var/lib/ocis"

The reverse proxy (caddy) has this setup for owncloud:

cloud.catboy.house {
    reverse_proxy <IP_ADDRESS>:28946 {
        request_buffers 256k
        response_buffers 256k
    }
}

The complete setup is here: https://github.com/yuri-becker/catboy-house/tree/main/roles/owncloud
Additional context
I assume this is some kind of permission issue. Is OCIS having issues with changing the user?
Uploading via the client seems to work, or seemed to have worked.

@yuri-becker I guess we need more information

What ocis release are running
Where are you uploading to? Is that a public link share? Or is that a user uploading to the home space? (the logs you pasted look like it's uploading to a public link)
Please set OCIS_LOG_LEVEL=debug and attach the logs if possible

I assume this is some kind of permission issue. Is OCIS having issues with changing the user?

If that user has write permissions on the volumes/directories it shouldn't.

@rhafer Thanks for your reply.

I'm running 5.0.7 and the web client says it is on 8.0.5.
In this case, it's uploading to a space with a public link, but it also happens when uploading to my personal files.
My current logs are attached owncloud_logs.txt
The user has write permissions and other read/write operations work fine.

Hm, there's tons of nats related errors in the logs (timeout,  warning about dropped messages). Something seems to be really weird there. Is that server under constant high CPU load or just when you're trying to upload?
Also, can you check what ocis storage-users uploads sessions says? Are the any sessions stuck? Maybe it helps to clean them up. (See https://doc.owncloud.com/ocis/5.0/deployment/services/s-list/storage-users.html#sessions-command for details).
Could you by chance try if a clean setup of ocis 6.4.0 (using separate volumes) shows the same behavior on your system?
BTW, was the behavior broken from the beginning? Or could you sucessfully upload files at some point before?

Yea, OCIS is producing a high CPU load, possibly because of re-trying to delete uploads over and over. ocis storage-users uploads sessions outputs me a ton of sessions. Clearing them didn't help.
On a fresh install, the upload worked after a few tries.

Yea, OCIS is producing a high CPU load constantly without user interaction, possibly because of re-trying to delete uploads over and over. ocis storage-users uploads sessions outputs me a ton of sessions. Clearing them didn't help.

Does that mean the sessions are still visible after ocis storage-users uploads sessions --clean?
To get the nats servcie back into a sane state you could try to clear the nats folder in you data volume while ocis is stopped. And then restart ocis, that will re-initialize the nats directory.

On a fresh install, the upload worked after a few tries.

What does "after a few tries" mean here? Which release is that fresh install using?
Also what kind of machine is this running on? How much RAM what kind of CPU, storage, etc.

Does that mean the sessions are still visible after ocis storage-users uploads sessions --clean?

The table was empty afterwards.

To get the nats servcie back into a sane state you could try to clear the nats folder in you data volume while ocis is stopped. And then restart ocis, that will re-initialize the nats directory.

That seemed to have fixed it temporarily. Once i try to upload a "larger" file (19MB), it goes back to being broken again.

What does "after a few tries" mean here? Which release is that fresh install using?

Fails twice, then upload succeeds on the third try. Then fails twice again and succeeds on the third try once more. That was only a <1MB file tho.

Also what kind of machine is this running on? How much RAM what kind of CPU, storage, etc.

I have 43 TB free storage, 126GB of RAM (of which 14GB is used) and a Xeon E5-1650 v3 (6 cores at 3.8 Ghz).

EDIT: The fresh install was using the same release, I'm running OCIS in Docker and it should pull the latest version daily.

We've recently introduced the so-called rolling releases which we publish roughly every 3 weeks (see  https://owncloud.dev/ocis/release_roadmap/#release-types) . They go to a different docker repo: https://hub.docker.com/r/owncloud/ocis-rolling it might be helpful to check if the issue still appears with that  latest release from there (which is 6.4.0)

The issue still persists on 6.4.0.

Ok, thanks for trying.
Could you please set OCIS_LOG_LEVEL=debug, start a clean ocis (ideally 6.4.0)  instance, reproduce the upload issue and then attach the full log of that?

Done, funnily enough, on this install, I wasn't able to upload even small files.
owncloud_logs_fresh_install.txt

Ok. I think that gets us a bit further I think. I can see a couple of successful uploads. But there is also at least one upload failing:
2024-09-25T15:16:38Z INF access-log | service=proxy proto=HTTP/1.1 request-id=a1c6abd7-29be-454b-9a52-3d26fac34430 traceid=b48f7713426e8f72d7e28fb5f67ef253 remote-addr=<IP_ADDRESS> method=POST status=502 path=/remote.php/dav/spaces/c6d8a02e-77f9-409c-93e2-12b72659fa41$b69dbc42-e8bd-4e24-a626-4d6aae354d64 duration=56.566584 bytes=0 line=github.com/owncloud/ocis/v2/services/proxy/pkg/middleware/accesslog.go:34
2024-09-25T15:16:38Z DBG Decomposedfs: built session info | service=storage-users pkg=rgrpc traceid=b48f7713426e8f72d7e28fb5f67ef253 session={} line=github.com/cs3org/reva/v2@v2.24.1/pkg/storage/utils/decomposedfs/upload.go:305
2024-09-25T15:16:38Z INF file upload | service=storage-users pkg=rgrpc traceid=b48f7713426e8f72d7e28fb5f67ef253 data-server=http://localhost:9158/data/simple/26ae9dd0-ea47-4ef3-bbeb-0538c052aa56 fn=./small_file.stl xs=map[md5:100 unset:1000] line=github.com/cs3org/reva/v2@v2.24.1/internal/grpc/services/storageprovider/storageprovider.go:470
2024-09-25T15:16:38Z INF file upload | service=storage-users pkg=rgrpc traceid=b48f7713426e8f72d7e28fb5f67ef253 data-server=http://localhost:9158/data/tus/26ae9dd0-ea47-4ef3-bbeb-0538c052aa56 fn=./small_file.stl xs=map[md5:100 unset:1000] line=github.com/cs3org/reva/v2@v2.24.1/internal/grpc/services/storageprovider/storageprovider.go:470
2024-09-25T15:16:38Z DBG unary | service=storage-users pkg=rgrpc traceid=b48f7713426e8f72d7e28fb5f67ef253 user-agent=Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 from=tcp://<IP_ADDRESS>:49880 uri=/cs3.storage.provider.v1beta1.ProviderAPI/InitiateFileUpload start=25/Sep/2024:15:16:38 +0000 end=25/Sep/2024:15:16:38 +0000 time_ns=61016562 code=OK line=github.com/cs3org/reva/v2@v2.24.1/internal/grpc/interceptors/log/log.go:69
2024-09-25T15:16:38Z DBG unary | service=gateway pkg=rgrpc traceid=b48f7713426e8f72d7e28fb5f67ef253 user-agent=Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 from=tcp://<IP_ADDRESS>:51788 uri=/cs3.gateway.v1beta1.GatewayAPI/InitiateFileUpload start=25/Sep/2024:15:16:38 +0000 end=25/Sep/2024:15:16:38 +0000 time_ns=62587837 code=OK line=github.com/cs3org/reva/v2@v2.24.1/internal/grpc/interceptors/log/log.go:69
2024-09-25T15:16:38Z ERR error doing PATCH request to data gateway | service=ocdav name=com.owncloud.web.ocdav traceid=b48f7713426e8f72d7e28fb5f67ef253 request-id=a1c6abd7-29be-454b-9a52-3d26fac34430 spaceid=c6d8a02e-77f9-409c-93e2-12b72659fa41$b69dbc42-e8bd-4e24-a626-4d6aae354d64 path=/ filename=small_file.stl error=Patch "https://cloud.catboy.house/data/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZXZhIiwiZXhwIjoxNzI3MzYzNzk4LCJpYXQiOjE3MjcyNzczOTgsInRhcmdldCI6Imh0dHA6Ly9sb2NhbGhvc3Q6OTE1OC9kYXRhL3R1cy8yNmFlOWRkMC1lYTQ3LTRlZjMtYmJlYi0wNTM4YzA1MmFhNTYifQ.25taQcy58gE_SF8KzQzInVeAeaptFimE2u_gWLHoJy8": context canceled line=github.com/cs3org/reva/v2@v2.24.1/internal/http/services/owncloud/ocdav/tus.go:298

As part of the TUS upload processing ocis needs to send a PATCH request to the so-called data gateway. It's sending that to the public ocis URL currently. So that request will go through your reverse proxy (caddy, I believe). For some (yet unknown) reason. The request is never received by ocis for this specific upload, at least there is no correlating access-log message for the PATCH request with a matching request-id. So it somehow got lost between ocis and the reverse proxy.
Do you have any logs from your reverse proxy from around that time? If not, you might wanna increase the log level of the reverse proxy and reproduce the issue once more.

I havn't been logging but enabled logging and re-tried uploads. Here you go. Thanks again for all your help.
cloud.catboy.house-access.log

@yuri-becker Which caddy release are you using? And why are you setting:
        request_buffers 256k
        response_buffers 256k

Does it work without those, by chance? (The docs say those should only be used if really really needed)

@rhafer Without these, everything seems to work as it should. Thank you for your help. I would be curious if the same issue exists on nginx, but I might also have not set something in Caddy that I should have with this.


MRG event_id

Currently the only way to map several triggers to one event is by combining them. This posts a problem when the trigger has different meanings. For instance, if you are doing a priming study and each word is uniquely identified [1:8]. for the priming condition, unprimed is (3,4) and primed is (5,6) and you varying whether it is a word (1,3,5,7) or nonword (2,4,6,8). It is possible you want to look only at whether it was primed or not primed for a contrast or whether it is a word or nonword.

can you explain what this code is doing with a snippet example?

Teon are we doing redundant things here? #1975

We not only have probelm apparently with not knowing abou the exisistence of functions in our code base but also with the existence of PRs. @teonlamont maybe you should turn on again your notifications ;-)

@jona-sassenhagen it would be complementary. so if you combine the two PRs, using the example above, you would be able to label all the words in a list with my PR, and do the intersection of words and primed with yours.
@dengemann I actually turned back on this morning before I sent my pr, but the other pr had already been posted ;)

Coverage decreased (-5.49%) to 84.7% when pulling 97b9b85d9e30d2926f9e2ae96104ddbfd10b7f45 on teonlamont:events into dc7d754ca41279559253b58c20a1cb4c32703a07 on mne-tools:master.

Coverage decreased (-0.26%) to 89.92% when pulling 186582d70c07d5c32a1bc8bfe1cc477b61f3ed50 on teonlamont:events into dc7d754ca41279559253b58c20a1cb4c32703a07 on mne-tools:master.

Ah, I get it now. Nice.

need tests

The example chould also expose the functionality proposed in #1975 later.

Looks good otherwise!

test added and example updated. #1975 will be able to extend the utility of the example in its pr.

@teonlamont I should be able to get #1990 in today and then you can combine examples as necessary

@agramfort any conclusion on this? We should decide for 0.9 or not.

i think i convinced @teonlamont that we can avoid this and make it work with the / things

okay, I'll close for now and we can resurrect if we hit a use case in the future

so, I realized that this is still needed. in order to keep all the triggers, you will need to make them fully specified and hierarchical. simple example, if you have a task where you play sounds in either left or right ear, they're listening to standards 'beeps' and detecting deviants 'boops'. left side is encoded on bit 3, right is encoded on 2, and the error on task on bit 1. you end up with some interactions.
event_id = {
'left': [4, 5],
'right': [2, 3],
'errors': [3, 5],
'goods': [2, 4]
}

in this example you could specify it completely in the hierarchical tags but we were to make the experiment more complex, say, have a more diverse set of standards, beeps, peeps, heeps, etc., each encoded on bit 4-8 then you have a very complex tagging problem.

That event_id actually looks like a good case for rERPs - who can probably also handle your beeps and peeps.
(linear_regression_continuous actually allows lists in its event_id dicts.)

hum...
what's wrong with?
event_id = {
'left/good': 4],
'left/errors': 5,
"right/good": 2,
"right/errors": 3
}

@teonlamont and this one?

Closing, feel free to reopen (again) if it's still an issue

sure, sure. i think i will need to share a real world example instead of the toy examples so we can see if that would make a good case. no time now for it.


[APIView][Feature Request] Consolidate review comments and send one email notification

Currently, an email notification is sent for each comment on the APIView. It would be nice to provide an option to consolidate all comments into a single notification and then submit the review.

We are running out of our free email monthly quota. This change will help us reduce email usage.


[Question] Vue2 data watch

Vue.component('foo', {
  props: {
    initValue: {
      default: 'Hello world!'
    }
  },
  data() {
    return {
      value: this.initValue
    };
  },
  watch: {
    initValue: {
      immediate: true,
      handler(value) {
        // Fires, all fine
        console.log('initValue');
      }
    },

    value: {
      immediate: true,
      handler(value) {
        // Not fires
        console.log('value');
      }
    }
  }
});

It is normal behavior?

Can't reproduce - https://jsfiddle.net/10eLvwyg/1/

Hello ...,
thank you for your filing this issue.
Please follow the guidelines on how to report an issue. In particular, provide an example on www.jsfiddle.net (or a similar service) that reproduces the problem.
Thank you.

Oh, after update to alpha.8 everything worked as it should :)


Why does the memory increase after paired (CON-396)

ESP32C3 , matter plug + wifi mesh
commit 9bb410d995b6ae81e2025467e5d5bbf494c1e6b1 (HEAD -> release/v1.0, origin/release/v1.0)

poweron : W (16270) main_logic: current free heap:21.75K inter free heap:15.50K min free heap:13.90K
after paired : W (18280) main_logic: current free heap:80.34K inter free heap:74.08K min free heap:12.41K
log:
I (13460) chip[DL]: Done driving station state, nothing else to do...
E (13460) chip[DL]: Long dispatch time: 128 ms, for event type 49152
I (13470) chip[DL]: WIFI_EVENT_AP_STOP
I (13470) chip[DL]: WiFi AP state change: Deactivating -> NotActive
I (13480) phy: chan:1,max_power:80
I (13480) phy: chan:2,max_power:80
I (13490) phy: chan:3,max_power:80
I (13490) phy: chan:4,max_power:80
I (13500) phy: chan:5,max_power:80
I (13500) phy: chan:6,max_power:80
I (13500) phy: chan:7,max_power:80
I (13510) phy: chan:8,max_power:80
I (13510) phy: chan:9,max_power:80
I (13520) phy: chan:10,max_power:80
I (13520) phy: chan:11,max_power:80
I (13530) phy: chan:12,max_power:80
I (13530) phy: chan:13,max_power:80
I (13530) phy: chan:14,max_power:80
I (13540) chip[DIS]: Advertise operational node BDB661861EBF7F51-00000000D5154FCB
I (13550) chip[DIS]: CHIP minimal mDNS configured as 'Operational device'; instance name: BDB661861EBF7F51-00000000D5154FCB.
I (13560) chip[DIS]: mDNS service published: _matter._tcp
I (13560) chip[SVR]: Operational advertising enabled
I (13570) chip[DL]: Updating advertising data
I (13600) chip[DL]: Confirm received for CHIPoBLE TX characteristic indication (con 1) status= 14
W (13670) main_logic: current free heap:28.57K inter free heap:22.31K min free heap:14.02K
W (13780) wifi:idx:0 (ifx:0, c8:bf:4c:3e:a3:41), tid:6, ssn:2, winSize:64
I (14470) chip[DL]: IP_EVENT_GOT_IP6
I (14470) chip[DL]: IPv6 addr available. Ready on WIFI_STA_DEF interface: fe80:0000:0000:0000:7edf:a1ff:fec1:d880
I (14470) app_main: Interface IP Address changed
I (14480) chip[DIS]: Updating services using commissioning mode 0
I (14480) chip[DIS]: CHIP minimal mDNS started advertising.
I (14490) chip[DIS]: Advertise operational node BDB661861EBF7F51-00000000D5154FCB
I (14500) chip[DIS]: CHIP minimal mDNS configured as 'Operational device'; instance name: BDB661861EBF7F51-00000000D5154FCB.
I (14510) chip[DIS]: mDNS service published: _matter._tcp
I (14620) esp_netif_handlers: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (14620) chip[DL]: IP_EVENT_STA_GOT_IP
I (14620) chip[DL]: IPv4 address changed on WiFi station interface: <IP_ADDRESS>/<IP_ADDRESS> gateway <IP_ADDRESS>
I (14630) chip[DL]: IPv4 Internet connectivity ESTABLISHED
I (14640) app_main: Interface IP Address changed
I (14640) chip[DIS]: Updating services using commissioning mode 0
I (14650) chip[DIS]: CHIP minimal mDNS started advertising.
I (14660) chip[DIS]: Advertise operational node BDB661861EBF7F51-00000000D5154FCB
I (14660) chip[DIS]: CHIP minimal mDNS configured as 'Operational device'; instance name: BDB661861EBF7F51-00000000D5154FCB.
I (14680) chip[DIS]: mDNS service published: _matter._tcp
I (14680) ROUTE_HOOK: Hook already installed on netif, skip...
W (14700) wifi:idx:1 (ifx:0, c8:bf:4c:3e:a3:41), tid:0, ssn:0, winSize:64
I (14700) chip[EM]: >>> [E:43789r M:42237911] (U) Msg RX from 0:453B2DB24F89FD9B [0000] --- Type 0000:30 (SecureChannel:CASE_Sigma1)
I (14710) chip[IN]: CASE Server received Sigma1 message. Starting handshake. EC 0x3fc9c560
I (14720) chip[IN]: CASE Server disabling CASE session setups
I (14720) chip[EM]: <<< [E:43789r M:138685889 (Ack:42237911)] (U) Msg TX to 0:0000000000000000 [0000] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (14740) chip[IN]: (U) Sending msg 138685889 to IP address 'UDP:[FE80::1CD0:3056:6AA4:235B%st1]:54069'
I (14750) chip[SC]: Received Sigma1 msg
I (14750) chip[SC]: CASE matched destination ID: fabricIndex 1, NodeID 0x00000000D5154FCB
I (15240) chip[EM]: <<< [E:43789r M:138685890 (Ack:42237911)] (U) Msg TX to 0:0000000000000000 [0000] --- Type 0000:31 (SecureChannel:CASE_Sigma2)
I (15240) chip[IN]: (U) Sending msg 138685890 to IP address 'UDP:[FE80::1CD0:3056:6AA4:235B%st1]:54069'
I (15250) chip[SC]: Sent Sigma2 msg
E (15250) chip[DL]: Long dispatch time: 556 ms, for event type 3
I (15520) chip[EM]: >>> [E:43789r M:42237912 (Ack:138685890)] (U) Msg RX from 0:453B2DB24F89FD9B [0000] --- Type 0000:32 (SecureChannel:CASE_Sigma3)
I (15520) chip[EM]: <<< [E:43789r M:138685891 (Ack:42237912)] (U) Msg TX to 0:0000000000000000 [0000] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (15530) chip[IN]: (U) Sending msg 138685891 to IP address 'UDP:[FE80::1CD0:3056:6AA4:235B%st1]:54069'
I (15540) chip[SC]: Received Sigma3 msg
E (15550) chip[SC]: The device does not support GetClock_RealTimeMS() API: 6c.  Falling back to Last Known Good UTC Time
I (16220) chip[EM]: <<< [E:43789r M:138685892 (Ack:42237912)] (U) Msg TX to 0:0000000000000000 [0000] --- Type 0000:40 (SecureChannel:StatusReport)
I (16230) chip[IN]: (U) Sending msg 138685892 to IP address 'UDP:[FE80::1CD0:3056:6AA4:235B%st1]:54069'
I (16240) chip[SC]: SecureSession[0x3fc9adf0]: Moving from state 'kEstablishing' --> 'kActive'
I (16240) chip[IN]: CASE Session established to peer: <1E2BC527C2DB3FA5, 1>
I (16250) chip[IN]: CASE Server enabling CASE session setups
E (16260) chip[DL]: Long dispatch time: 744 ms, for event type 3
I (16270) CHIP[DL]: Write request received for CHIPoBLE RX characteristic con 1 12
W (16270) main_logic: current free heap:21.75K inter free heap:15.50K min free heap:13.90K
I (16280) chip[EM]: >>> [E:43790r M:133822336] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:08 (IM:InvokeCommandRequest)
I (16300) esp_matter_command: Received command 0x00000004 for endpoint 0x0000's cluster 0x00000030
I (16300) chip[FS]: GeneralCommissioning: Received CommissioningComplete
I (16310) chip[FP]: Metadata for Fabric 0x1 persisted to storage.
I (16320) chip[TS]: Committing Last Known Good Time to storage: 2023-04-03T11:23:15
I (16330) chip[ZCL]: OpCreds: Fabric index 0x1 was committed to storage. Compressed Fabric Id 0xBDB661861EBF7F51, FabricId<PHONE_NUMBER>000001, NodeId 00000000D5154FCB, VendorId 0x1349
I (16350) chip[FS]: GeneralCommissioning: Successfully commited pending fabric data
I (16350) chip[FS]: Fail-safe cleanly disarmed
I (16360) esp_matter_attribute: ********** Endpoint 0x0000's Cluster 0x0030's Attribute 0x0000 is ld **********
I (16370) chip[EM]: <<< [E:43790r M:69914668 (Ack:133822336)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:09 (IM:InvokeCommandResponse)
I (16380) chip[IN]: (S) Sending msg 69914668 on secure session with LSID: 10482
E (16390) chip[DL]: Long dispatch time: 108 ms, for event type 3
I (16400) chip[EM]: >>> [E:43789r M:42237913 (Ack:138685892)] (U) Msg RX from 0:453B2DB24F89FD9B [0000] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (16410) chip[SVR]: Commissioning completed successfully
I (16420) chip[DIS]: Updating services using commissioning mode 0
I (16420) chip[DIS]: CHIP minimal mDNS started advertising.
I (16440) chip[DIS]: Advertise operational node BDB661861EBF7F51-00000000D5154FCB
I (16440) chip[DIS]: CHIP minimal mDNS configured as 'Operational device'; instance name: BDB661861EBF7F51-00000000D5154FCB.
I (16450) chip[DIS]: mDNS service published: _matter._tcp
I (16460) chip[SC]: SecureSession[0x3fc9ad38]: Moving from state 'kActive' --> 'kPendingEviction'
I (16470) chip[BLE]: Releasing end point's BLE connection back to application.
I (16470) app_main: Commissioning complete
I (16480) esp_matter_core: Commissioning Complete
I (16480) app_main: Commissioning window closed
I (16490) chip[DL]: Write request/command received for CHIPoBLE TX CCCD characteristic (con 1 ) indicate = 0
I (16500) chip[DL]: CHIPoBLE unsubscribe received
I (16500) chip[DL]: BLE GAP connection terminated (con 1 reason 0x213)
E (16510) chip[BLE]: no endpoint for unsub recvd
W (16520) BTDM_INIT: esp_bt_mem_release not implemented, return OK
I (16520) esp_matter_core: BLE deinit successful and memory reclaimed
I (16530) chip[EM]: >>> [E:43790r M:133822337 (Ack:69914668)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (16550) chip[EM]: >>> [E:43791r M:133822338] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:02 (IM:ReadRequest)
I (16560) chip[EM]: <<< [E:43791r M:69914669 (Ack:133822338)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:05 (IM:ReportData)
I (16570) chip[IN]: (S) Sending msg 69914669 on secure session with LSID: 10482
I (16600) chip[EM]: >>> [E:43791r M:133822339 (Ack:69914669)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (16650) chip[EM]: >>> [E:43792r M:133822340] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:02 (IM:ReadRequest)
I (16650) chip[EM]: <<< [E:43792r M:69914670 (Ack:133822340)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:05 (IM:ReportData)
I (16660) chip[IN]: (S) Sending msg 69914670 on secure session with LSID: 10482
I (16710) chip[EM]: >>> [E:43792r M:133822341 (Ack:69914670)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (16710) chip[EM]: >>> [E:43793r M:133822342] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:02 (IM:ReadRequest)
I (16730) chip[EM]: <<< [E:43793r M:69914671 (Ack:133822342)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:05 (IM:ReportData)
I (16740) chip[IN]: (S) Sending msg 69914671 on secure session with LSID: 10482
I (16790) chip[EM]: >>> [E:43793r M:133822343 (Ack:69914671)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (16790) chip[EM]: >>> [E:43794r M:133822344] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:02 (IM:ReadRequest)
I (16810) chip[EM]: <<< [E:43794r M:69914672 (Ack:133822344)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:05 (IM:ReportData)
I (16820) chip[IN]: (S) Sending msg 69914672 on secure session with LSID: 10482
I (16950) chip[EM]: >>> [E:43794r M:133822345 (Ack:69914672)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (16960) chip[EM]: >>> [E:43795r M:133822346] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:02 (IM:ReadRequest)
I (16970) esp_matter_attribute: ********** Endpoint 0x0001's Cluster 0x0006's Attribute 0xFFFC is 1 **********
I (16980) chip[EM]: <<< [E:43795r M:69914673 (Ack:133822346)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:05 (IM:ReportData)
I (16990) chip[IN]: (S) Sending msg 69914673 on secure session with LSID: 10482
I (17010) chip[EM]: >>> [E:43795r M:133822347 (Ack:69914673)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (17020) chip[EM]: >>> [E:43796r M:133822348] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:02 (IM:ReadRequest)
I (17030) chip[EM]: <<< [E:43796r M:69914674 (Ack:133822348)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:05 (IM:ReportData)
I (17040) chip[IN]: (S) Sending msg 69914674 on secure session with LSID: 10482
I (17070) chip[EM]: >>> [E:43796r M:133822349 (Ack:69914674)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
I (17260) chip[EM]: >>> [E:43797r M:133822350] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:0a (IM:TimedRequest)
I (17260) chip[EM]: <<< [E:43797r M:69914675 (Ack:133822350)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:01 (IM:StatusResponse)
I (17270) chip[IN]: (S) Sending msg 69914675 on secure session with LSID: 10482
I (17300) chip[EM]: >>> [E:43797r M:133822351 (Ack:69914675)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:08 (IM:InvokeCommandRequest)
I (17300) esp_matter_command: Received command 0x00000000 for endpoint 0x0000's cluster 0x0000003C
I (17310) chip[ZCL]: Received command to open commissioning window
I (17320) chip[DIS]: Updating services using commissioning mode 2
I (17330) chip[DIS]: CHIP minimal mDNS started advertising.
I (17340) chip[DIS]: Advertise operational node BDB661861EBF7F51-00000000D5154FCB
I (17340) chip[DIS]: CHIP minimal mDNS configured as 'Operational device'; instance name: BDB661861EBF7F51-00000000D5154FCB.
I (17360) chip[DIS]: mDNS service published: _matter._tcp
I (17360) chip[DIS]: Advertise commission parameter vendorID=65521 productID=32768 discriminator=2740/10 cm=2
I (17370) chip[DIS]: CHIP minimal mDNS configured as 'Commissionable node device'; instance name: 6C042797FAD65741.
I (17390) chip[DIS]: mDNS service published: _matterc._udp
I (17390) chip[ZCL]: Commissioning window is now open
I (17390) chip[EM]: <<< [E:43797r M:69914676 (Ack:133822351)] (S) Msg TX to 1:1E2BC527C2DB3FA5 [7F51] --- Type 0001:09 (IM:InvokeCommandResponse)
I (17410) chip[IN]: (S) Sending msg 69914676 on secure session with LSID: 10482
E (17420) chip[DL]: Long dispatch time: 118 ms, for event type 3
I (17420) app_main: Commissioning window opened
I (17440) chip[EM]: >>> [E:43797r M:133822352 (Ack:69914676)] (S) Msg RX from 1:1E2BC527C2DB3FA5 [7F51] --- Type 0000:10 (SecureChannel:StandaloneAck)
W (18280) main_logic: current free heap:80.34K inter free heap:74.08K min free heap:12.41K
W (20280) main_logic: current free heap:80.34K inter free heap:74.08K min free heap:12.41K
W (22280) main_logic: current free heap:80.34K inter free heap:74.08K min free heap:12.41K

@sidhoo2 By default, BLE is only used for commissioning, therefore we deactivate the BLE functionality and recover all the memory allocated to it, as shown in the following code. https://github.com/espressif/esp-matter/blob/3a65dfc75398bb3e4ce58418011499cd794a0586/components/esp_matter/esp_matter_core.cpp#L859-L891
If you want to use the BLE even after commissioning then you can disable CONFIG_USE_BLE_ONLY_FOR_COMMISSIONING and free memory won't go up.

@sidhoo2 By default, BLE is only used for commissioning, therefore we deactivate the BLE functionality and recover all the memory allocated to it, as shown in the following code.
https://github.com/espressif/esp-matter/blob/3a65dfc75398bb3e4ce58418011499cd794a0586/components/esp_matter/esp_matter_core.cpp#L859-L891
If you want to use the BLE even after commissioning then you can disable CONFIG_USE_BLE_ONLY_FOR_COMMISSIONING and free memory won't go up.

@shubhamdp you are right , but the func not implemented,  and  who spend the ram before paired ?
esp_err_t esp_bt_controller_mem_release(esp_bt_mode_t mode) {     ESP_LOGW(BTDM_LOG_TAG, "%s not implemented, return OK", __func__);     return ESP_OK; }

you are right , but the func not implemented, and who spend the ram before paired ?

For ESP32, esp_bt_mem_release() API releases memory, but for other SoCs, call to deinit does that work. On BLE initialization it allocates the memory it require.

In addition，just run the matter plug app, there is only 68K free heap left , did anybody meet this issue

If you see, the observations are pretty old, almost 9 months back, and since we are continuously making changes, its hard to update it regularly.

@shubhamdp  i see, and is there any method to optimize the RAM usage?

You can perform the configuration optimizations, few are listed here.
You can also refer the IDF docs.

Closing as the original question is answered.


Saving file causes [TypeError: Cannot read property 'apply' of null]

0.2.2 of the extension installed as well as ghc-mod version <IP_ADDRESS> compiled by GHC 7.10.3.

Can you give me more information?
I haven't seen this error. Do you have a set of steps to consistently reproduce this issue?

All I can see is the output of the console.
Is there a debug mode or something to see what commands are failing?

You can set "Haskell.ghcMod.logLevel": " log" to get the most verbose output.
Also, does this happen for every file? Or just certain ones?
And are you on Windows, Linux, osx?

Each time I hit save I get the error message out twice:
[TypeError: Cannot read property 'apply' of null]
[TypeError: Cannot read property 'apply' of null]
Same behaviour on OSX or Windows.  It happens in Turtle scripts or normal project files.
My settings are (on OSX):
// Place your settings in this file to overwrite the default settings
{
"haskell.ghcMod.executablePath": "/Users/blah/.local/bin/ghc-mod",
"haskell.ghcMod.logLevel": "log"
}
Windows:
// Place your settings in this file to overwrite the default settings
{
"haskell.ghcMod.executablePath": "C:/Users/blah/AppData/Roaming/local/bin/ghc-mod.exe",
"haskell.ghcMod.logLevel": "log"
}
ghc-mod --version gives:
ghc-mod version <IP_ADDRESS> compiled by GHC 7.10.2

I should have mentioned: the log output shows up in the chrome dev tools within the window. If you open the vs code command palette and type "developer tools" it should give an option to open that. Then the logging shows up in the console.
Another backlog item is seeing is output channels are available to language services to make them easier to find and read.

Thanks and maybe success then - I think the error is:
[Extension Host] ghc-mod stderr: : cannot satisfy -package-id base-<IP_ADDRESS>-bfcc6de9ee2962ae54db40ece3022dc5
(use -v for more information)
With a quick search points to:
https://github.com/DanielG/ghc-mod/issues/607
So looks like a problem with ghc-mod.

Cool, hopefully you can get it solved.

This is apparently a classic ghc-mod error - the version of GHC for the project (defined in stack.yaml) vs the version of GHC for the global.  Make sure version agree and it works!

Glad you got it sorted out. So you just added the oath to the local ghc-mod in workspace settings and it worked?

Yeah.  The User settings now looks like:
{
"haskell.ghcMod.executablePath": "/home/andrew/.local/bin/ghc-mod",
"haskell.hlint.executablePath": "/home/andrew/.local/bin/hlint",
"stylishHaskell.commandLine": "/home/andrew/.local/bin/stylish-haskell"
}


dns: de-dup returned entries

This was raised here: https://github.com/lyft/envoy/issues/431
If DNS returns the same entry multiple times, we will keep adding a host and effectively leak. Either the DNS impl itself should dedup, or the dymamic cluster add/remove code should do it.
cc @htuch

To what extent does order and multiplicity matter? Could we just pass a set to ResolveCb instead of a list in DnsResolver? Might the upper level cluster code use multiplicity to influence weight or order to determine preference?

Order doesn't currently matter, but the code in:
https://github.com/lyft/envoy/blob/master/source/common/upstream/upstream_impl.cc#L273
Does not correctly handle duplicates.
IMO, it would be better to fix the above code since that will cover not only DNS, but SDS, etc. also, and dealing with duplicates is really an envoy "problem" and not a DNS problem.


bug 2117374: add message about working with restricted, but not restricted-v2

add message about working with restricted, but not restricted-v2
/assign @stlaz

/hold cancel
added unit test.

Looks good. I believe we only wanted this to be present in 4.11, please edit the PR to merge to the 4.11 branch instead of master.

/cherrypick release-4.11
/cherry-pick release-4.11


New aimage settings: width, height, checkpoint, adetailer, auth

width and height are bounded to 256 and 768
checkpoint has no autocomplete like loras, as I don't know how those are handled exactly
adetailer depends on the extension of the  same name, it greatly improves quality of faces when enabled at the cost of a few seconds
auth lets you add --api-auth username:password to your webui launch settings for security reasons

ty :)


Make use of the new downcast_ref()

Can it be used in gtktest.rs too?

Bad.
Then be only one change.
Thanks and 👍

Thanks!


Yaml2JsonNode fails json->yaml->json roundtrip

Environment

Nuget Package: Yaml2JsonNode
Nuget Version: 1.2.0
OS: Linux
.Net Target: .NET 7

Describe the bug
When converting JSON string it's always converted to Any-style of Yaml Scalar.
Converting a JSON with a number within a string prevents roundtripping to yaml and again JSON, because a string (that looks like a number) in original JSON becomes an actual JSON number scalar when converting back from YAML.
Additionally, when creating repro, I've discovered that json.ToYamlNode doesn't handle null values within JSON.
To Reproduce
See fiddle: https://dotnetfiddle.net/FfxJlu
using System;
using System.Linq;
using System.Text.Json.Nodes;
using Yaml2JsonNode;

var jsonText = """
  {"foo":123,"foz":"123","bar":1.23,"baz": "1.23"}
  """;
var json = JsonNode.Parse(jsonText);
var yaml = json.ToYamlNode();
var yamlText = YamlSerializer.Serialize(yaml: yaml);

var jsonRoundtripped = YamlSerializer.Parse(yamlText).Single().ToJsonNode();
var jsonRoundText = jsonRoundtripped.ToJsonString();

Console.WriteLine("# jsonText:");
Console.WriteLine(jsonText);
Console.WriteLine();
Console.WriteLine("# yamlText:");
Console.WriteLine(yamlText);
Console.WriteLine("# jsonRoundText:");
Console.WriteLine(jsonRoundText);

Expected behavior
A json converted into YAML and back to JSON keeps the scalar types. That'd mean that the YAML scalar nodes are created as single- or double-quoted string-scalars for decimal- or bool- parsable strings.
Additional context
Generally, the conversion from YAML to JSON handles type differentiation quite well, but opposite direction isn't as thorough.

And also thank you for that package in general. I've found it very useful!

Thanks for the reproduction.  That helps a lot.  In the future, could you also add the output you get vs the output you expect, please?
I'll get to work on this.

Added output vs expected!

I see what you mean.  Numbers are interpreted as strings from the YAML back to JSON.
This is actually a consequence of YAML and hwo YamlDotNet handles parsing more than anything with this library.  With YAML in general it's not always possible/efficient to tell if a value is intended to be a string or a number.
I'll see if I can do anything about it.  Ultimately, I'm limited to how that project is parsing the YAML.

I think this is probably the best match to what you're wanting.
https://github.com/aaubry/YamlDotNet/issues/315
You might try the workaround.  You can configure the serializer as part of the .Serialize() method:
var text = YamlSerialize.Serialize(yaml,
    builder => builder.WithEventEmitter(nextEmitter => new QuoteSurroundingEventEmitter(nextEmitter)));

I'm not sure this is something that I'm ready to put in this lib, though.

Couldn't setting YamlScalar.Style to Quoted work when mapping from JSON ode to YamlNode?

Yep.  That worked!  I didn't even know that was a thing I could set.  Nice call.
I'll have an update out soon.


feature: test with flashing

Closes #13
Improved version of installation scripts.
Added test scripts for verification of the build including flashing.
Right now it's using esptool from branch.
The build is using --feature native by default.

Please, review the change. I welcome comments for improvement.


Changes to move code to open-ce-builder

Checklist before submitting

[x] Did you read the contributor guide?
[x] Did you update any affected documentation?
[x] Did you write any tests to validate this change?

Description
Changes needed to move the Open-CE build tools to the new open-ce-builder repo.
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

This won't pass tests until the environment files are moved to the open-ce repo.

This looks good!


Update macrocycle bounds calculation

Summary
In a system with conjugated double bonds, the single bond in the middle can be either "trans" (180 degrees) or "cis" (0 degrees). In a non-cyclic system, the trans configuration is preferred. In a small ring (like benzene), the single bond needs to be cis. However, in a macroycle both options should be possible. However, ETKDG previously only generated the "cis" conformer.
Changes

Previously, C=C([#1])C([#1])=C groups in a macrocycle were always cis because of a bug in the bounds calculation. Although the bounds within the main chain (carbon-carbon) allowed cis or trans, the 1-4 bounds of the H atoms were always set to trans, which forces the carbons into the cis position. This change fixes this behavior to allow cis or trans conformations.
Furthermore, the useMacrocycle14config flag could only be used from Python by creating an ETKDGv3 object, and defaulted to False otherwise. This change adds the flag to EmbedMolecule, EmbedMultipleConfs, and the EmbedParameters Python interface.
This also adds a test case for the changed behavior. The test uses the molecule C1/C=C/C=C/CCCCCCCCC1 (fails with the old code, but succeeds with the new one)
I also updated the docstring in EmbedMolecule according to https://www.rdkit.org/docs/RDKit_Book.html#parameters-controlling-conformer-generation (copying the description of useMacrocycleTorsions and useMacrocycle14config)

I made the default useMacrocycle14config=True in EmbedMolecule, to be consistent with the default for useMacrocycleTorsion. However, it was previously False, so this could change the behavior of existing scripts. How should we deal with this?
To-do

I only made a test case from the C++ side, but if you want, I could also add a test case with the same content for the Python side to test the useMacrocycle14config flag.
Run the macrocycle conformer generation test set.

I just saw that there was recently a commit that made useMacrocycle14config=True the default. In my testing, it seemed like this is not the case, but I am not sure why this was the case...

We've also checked these changes against our macrocycle validation set and made sure that they don't adversely impact the performance of the conformer generator when it comes to reproducing crystal conformers.

Thanks for the fix @fwaibl !

changing the milestone on this one since it makes more sense together with the changes to make ETKDGv3 the default (#6985)


Sometimes go test inside delve/proctl will fail on TestNextGeneral and/or TestNextGoroutine

Most of the time all tests pass, sometimes TestNextGeneral or TestNextGoroutine (or both) fail:
--- FAIL: TestNextGeneral-4 (2.57s)
proctl_test.go:248: Program did not continue to correct next location expected 23 was testnextprog.go:40

(this always seems to happen after the message "thread context changed from X to X")
--- FAIL: TestNextGoroutine-4 (0.74s)
proctl_test.go:54: failed assertion at proctl_test.go:244: Next() returned an error : process 9596 has exited with status 0

--- FAIL: TestNextGoroutine-4 (0.23s)
proctl_test.go:54: failed assertion at proctl_test.go:234: Continue() : process 10201 has exited with status 0

I'm using the latest revision of delve, compiled with go version 1.4.2 under Ubuntu 14.04.2

@aarzilli Can you try and reproduce this again with the latest master build? Lots of work has been done around this area recently.

Perhaps I wasn't clear, my test failures were with the latest revision of master as of yesterday (i.e. 19a98fb49c9d1110da83008342c827ef0db5a083). But I can still reproduce the errors even with the current master (i.e. f9c64d30c205c3b869bf8bad4fe6ed92cf799115):
--- FAIL: TestNextGoroutine-4 (0.74s)
    proctl_test.go:54: failed assertion at proctl_test.go:244: Next() returned an error : could not get registers: no such process

--- FAIL: TestNextGoroutine-4 (0.25s)
    proctl_test.go:54: failed assertion at proctl_test.go:234: Continue() : process 29222 has exited with status 0

--- FAIL: TestNextGeneral-4 (2.42s)
    proctl_test.go:248: Program did not continue to correct next location expected 23 was testnextprog.go:40

--- FAIL: TestNextFunctionReturn-4 (0.25s)
    proctl_test.go:54: failed assertion at proctl_test.go:234: Continue() : process 29824 has exited with status 0

I have done some personal investingation of this bug.
It seems to be caused by an interaction between clone(2) and hardware breakpoints. Either setting GOMAXPROCS=1 or disabling the code that sets hardware breakpoints gets rid of those errors.
I should probably have mentioned that I had GOMAXPROCS set to 4 in my original error report but I had forgotten.
Further investigation reveals that resetting hardware breakpoints on DebuggedProcess.addThread with this loop:
for i, v := range dbp.HWBreakPoints {
	if v != nil {
		setHardwareBreakpoint(i, tid, 0)
		setHardwareBreakpoint(i, tid, v.Addr)
	}
}

gets rid of some errors. I have no idea why this actually works, btw.
The errors that remain are like this:
--- FAIL: TestNextGoroutine-4 (0.51s)
proctl_test.go:54: failed assertion at proctl_test.go:243: Next() returned an error : process 32501 has exited with status 0
(line numbers may not match, I have local changes). If u_debugreg happens to be thread local (which seems plausible) this would be completely expected, Next() sets a temp breakpoint for the current thread (did I read the code wrong?) but TestNextGoroutine expects the call to Next to break into a goroutine different than the current one and this could happen on the same os thread or not.

@aarzilli great catch, I definitely agree that's likely the issue. Can hopefully have a fix up today.


[Core][Extension Manager]:  Extensions under Available tab cannot show if click available tab while loading the extensions.

Steps:

Launch Brackets.
Click Extension Manager icon on the right sidebar.
On the Extension Manager dialog, click tab Available while the extensions are loading.
Waite several seconds until the extensions are loaded, then observe the extension dialog.

Results:
No extension list under tab Available.
Expected:
Available extensions should show on the dialog.
ENV: Mac 10.8 and Win8.1 English OS
Build: 0.34.0-10242(win) and 0.34.0-10251(Mac)
Notes:
There is no extension installed on my mac and VM. After step4, if I click tab Installed, then back to tab Available, extensions could list on the dialog.
Snapshots:
Please refer to snapshots for details:
Step3:

Step4:

@julieyuan @peterflynn This is now hopefully fixed on master.

Closing as fixed


Load Shedding Stage Unknown

Hi!
I see that my load shedding stage has been unknown for a few days. The rest of the data seems to be updating just fine.
Any ideas on how to fix this?
Thanks in advance!

Same happening my side. All other values updating and pulling through fine.

Me too ...

I see there is a dev release with a bunch of changes, I switched to give it a go and so far its working better.
Hopefully Werner gets to releasing it soon

Just released v1.1.0-dev.9.  Hopefully the last dev release.

I used to have this problem , but because we were constantly on Stage 2, it always showed as Unknown, but now that we have been informed for Stage 3 coming, It is working just fine with v1.1.0 release

Just released v1.1.0-dev.9. Hopefully the last dev release.

Thanks for all your efforts! Working perfectly now.

✅ Fixed.
Please consider buying me a coffee to support my work.


User/aeloros/get args

Implement the first set of functionality for the AppLifecycle and ActivationRegistrationManager objects.
Support in this change is scoped to implementation of the LaunchActivatedEventArgs and ProtocolActivatedEventArgs scenarios for unpackaged Win32.
Sample APIs were removed from the tree.
Testing was done by adding basic launch tests, and testing protocol scenarios with a basic sample app.  A later PR will contain protocol tests, and a move to the new test framework.

@aeloros please change the title of this PR to have a human-readable one-line-description of this PR (Use the "Edit" button on the top right of the PR page)


Q:Some compilation errors in Eclipse, however maven build works fine

I imported the source code in eclipse. I see many compilation errors. For example
The class
org.estatio.dom.budgeting.budget.Budget
the method following methods are not defined.
getItems(), getProperty()
And so many other similar cases.
Still mavn works and I was able to run the app in standalone mode.
Any idea how to fix these compilation issues?

Sounds like the project didn't import correctly. Try using maven>update
project. I think there's some guides on the Isis website with more hints
/suggestions.
On 29 Feb 2016 4:01 am, "Amr ElAdawy"<EMAIL_ADDRESS>wrote:

I imported the source code in eclipse. I see many compilation errors. For
example
The class
org.estatio.dom.budgeting.budget.Budget
the method following methods are not defined.
getItems(), getProperty()
And so many other similar cases.
Still mavn works and I was able to run the app in standalone mode.
Any idea how to fix these compilation issues?
—
Reply to this email directly or view it on GitHub
https://github.com/estatio/estatio/issues/29.

I tired update several times, from command prompt and from eclipse.
For the class org.estatio.dom.budgeting.budget.Budget
The two missing methods are not in the class not up to any super.
Also this is not compiling
getLeaseTerm().getAuditedTurnover()

Um, well if it builds from the command line but not in the IDE then the
issue must be in the project import somewhere or other. We've all moved
over to using IntelliJ, which we find (having got used to its own quirks)
to generally be more reliable. Perhaps you might try that out,  also?
On 29 Feb 2016 8:11 am, "Amr ElAdawy"<EMAIL_ADDRESS>wrote:

I tired update several times, from command prompt and from eclipse.
For the class org.estatio.dom.budgeting.budget.Budget
The two missing methods are not in the class not up to any super.
Also this is not compiling
getLeaseTerm().getAuditedTurnover()
—
Reply to this email directly or view it on GitHub
https://github.com/estatio/estatio/issues/29#issuecomment-190087781.

I understand your point.
Just for the sake of integrity. The type LeaseTermForTurnoverRent should have the method getAuditedTurnover()
Where can I find it?
This is only defined in the type  LeaseTermForTurnoverRentLineItem

We use Lombok [1] to reduce boilerplate and annotate private fields with
@Getter and @Setter which magically creates getters and setters behind the
scenes.
[1] https://projectlombok.org/
On 29 February 2016 at 10:53, Amr ElAdawy<EMAIL_ADDRESS>wrote:

I understand your point.
Just for the sake of integrity. The type LeaseTermForTurnoverRentshould
have the method getAuditedTurnover()
Where can I find it?
This is only defined in the type LeaseTermForTurnoverRentLineItem
—
Reply to this email directly or view it on GitHub
https://github.com/estatio/estatio/issues/29#issuecomment-190130256.

Wow, first time to heat about lombok.
Why Not using Groovy for such thing (Getters and Setters)?
I think that README.MD should be updated to install lombok.  Even if IntelliJ is used.


Add a README

Please add a README that explains what your tool is doing and how to invoke it (usage info).

Well, this tool has no longer been maintained for almost a decade, and is expected unworking and indeed sandboxing and Stack make this app almost useless. I will freeze this repo soon.


[WIP] Fix #3011: Matrix representation of a circuit enabled.

Summary

#3011 [Matrix representation of circuit] enabled through the use of Operator.
Tests added.

Hi @rafamartinc ! Still working on this?

Yep, I still am, @1ucian0. I just couldn't find more time to work on it, but I'll continue today. I think I only have to fix a circular dependency for it to be ready for review.

This [WIP] is not having updates for some days already. Should it be closed? It can be open back whenever you have the bandwidth for it.

This one’s on me. I wanted to open an issue to make a plan for how data conversion gets done in general. I’ll do that today. The reason I held this up is that there needs to be some consistency between how different objects are converted to each other (circuit, instruction, operator, ...)

On Oct 24, 2019, at 9:43 AM, Luciano<EMAIL_ADDRESS>wrote:
This [WIP] is not having updates for some days already. Should it be closed? It can be open back whenever you have the bandwidth for it.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.

Agreed, @ajavadia. I've been trying to finish this, but I always end up with a circular dependency, because Operator already imported QuantumCircuit, but this fix would need QuantumCircuit to import Operator to work. I think the hierarchy between these classes, and Instruction and so on, should be reviewed before this can be done properly. We can close it for now, @1ucian0, and I'll keep an eye on @ajavadia's updates to see if I can be of any help. Thank you both.

closing as requested. Thanks!


Contribute page should not list options whose sessions are disabled

Describe the bug
Disabling sections hides them from collective profile page but 'some' are still accessible via the menu (Contribute/All ways to contribute)
For example 'projects' are hidden on the main collective -
https://opencollective.com/drupal-contribution
But visible via the 'Contribute' menu item -
https://opencollective.com/drupal-contribution/contribute
And since the collectives on https://discover.opencollective.com/ link to the same /contribute, projects are easily accessible

Expected behavior
Disabled/hidden sections should not appear on any pages

Triage Template (core team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

Not really a bug; the settings let you customize your profile page, but you're not really disabling features when editing things there. I do agree that confusion is easily made, and hiding the corresponding contribute cards doesn't cost much.
In https://github.com/opencollective/opencollective-frontend/blob/7e4b138c58e3c6360ec8d6acc08bf6666b097ed0/pages/contribute.js, we want to look at the collective settings and do something like:
const hideProjects = !hasSection(collectiveSections, Sections.PROJECTS);

Following this example, if URL is /projects, we should display a PageFeatureNotSupported.

Well... it'll be great when sections intended to be hidden weren't so easily accessible. Ideally, admins would be able to hide/disable individual tiers or projects within a section.


Documenting file name limitations

Can't find anywhere in lfs.h, but do the filenames have any limitations other than their size? I'm guessing that because many functions take paths that the filename should not contain '/' and with the names being null-terminated there likely should not be nulls inside them either, but are all other char values acceptable?

I've been looking for the same information.  I've not read every document in full, but I did find a reference in the SPEC.md file that says for "0x0xx LFS_TYPE_NAME" that "The data contains the file name stored as an ASCII string (may be expanded to UTF8 in the future)."  As @Xywzel suggests, I also guess that a filename cannot contain a '/' or a null, but what about other characters like '', '*', control characters or whole filenames like ".", "..".  It would be create if this detail could be specified somewhere.

If I'm reading the lfs_dir_findcorrectly in the lfs.c, then "." and ".." are indeed special cases. There also seems to be root directory for the file system, but it is hard to say if one would open that for reading with path "/" or with empty path.

I'll make a note to add documentation on this. littlefs follows Linux/Unix tradition with '/' and NULL being the only illegal characters, and '.' and '..' being the only reserved filenames. "/" is the proper way to reference the root directory. If there's anything I've missed littlefs will try to follow Linux/Unix.
The fact that the empty string is also accepted for the root directory wasn't really intended, checking with Linux it should probably be an LFS_ERR_NOENT. But at this point it shouldn't be changed unless there is a major revision.
Also UTF8 in paths is fine, that line of the documentation should be changed. UTF8's use of the high bit for continuation bytes means that it's not possible to introduce NULL bytes without a true NULL character.
This scheme has the unfortunate downside of requiring base64 or hex encoding to use raw data for filenames, but it's a tradeoff for directories and OS portability.

Thanks @geky,
I've been implementing a virtual file system to sit above littlefs, which is why I've been looking at the issue of paths fairly closely, and in particular the POSIX specification.  (I understand that you are not trying to claim full compliance with POSIX, but those guys have had to think closely about some of these things, so I've found them a useful reference). When you consider the documentation, please could you also consider a few corner cases:

I think I am right in saying that littlefs interprets sequences of "/" characters the same as a single "/" (e.g. line 1339 in lfs_dir_find);
I think I am right in saying that all paths are absolute, whether prefixed by (possibly multiple) "/" characters or not (afterall, there is no working directory to be relative to :-);
POSIX makes a special case in §3.271 and elsewhere of paths starting with "//", but I don't think littlefs does anything different in this case;
POSIX makes some comments about (possibly multiple) trailing "/" characters in §4.13 para 4.  My internet searches on trailing "/" characters in paths seems to indicate that some folk think it is a good idea and others who think it is a very bad idea. Any significance to littlefs of trailing "/" character(s) might be worth a sentence in the documentation.

Cheers, Steve

I think matching the POSIX specification is a good goal, if anything to avoid surprises. But this is sometimes in conflict with backwards compatibility. I probably won't introduce a breaking change for POSIX compatibility alone for example.
And good comment on these, I overlooked some of the nuances. Goes to show even "simple" specs can hide some unexpectedly complex interactions.

I think I am right in saying that littlefs interprets sequences of "/" characters the same as a single "/" (e.g. line 1339 in lfs_dir_find);

Yep

I think I am right in saying that all paths are absolute, whether prefixed by (possibly multiple) "/" characters or not (afterall, there is no working directory to be relative to :-);

Yep, if anything littlefs may add a set of lfs_file_openat/lfs_mkdirat/lfs_statat/etc APIs, leaving this implementation of the cwd up to OSes/virtual layers. But I'm not sure adding the statefulness of the concept of cwd to embedded systems would be very popular...

POSIX makes a special case in §3.271 and elsewhere of paths starting with "//", but I don't think littlefs does anything different in this case;

If I'm reading this correctly, in §4.13 the spec says '//' is implementation defined. So in a sense, littlefs is POSIX conforming here, by doing the implementation defined thing of treating '//' the same as '/', which I would argue is the least surprising option. :)
Of course this doesn't stop OSes/virtual layers from intercepting '//' and giving it special meaning.

POSIX makes some comments about (possibly multiple) trailing "/" characters in §4.13 para 4. My internet searches on trailing "/" characters in paths seems to indicate that some folk think it is a good idea and others who think it is a very bad idea. Any significance to littlefs of trailing "/" character(s) might be worth a sentence in the documentation.

There is actually an in-progress PR to improve this: https://github.com/littlefs-project/littlefs/pull/679.
The intention is to allow trailing '/' for directories only, which I think matches the text in §4.13.
I know this behavior is at least nice for ensuring cp a.txt b/ fails if b does not exist, but that doesn't translate directly to any littlefs API.


Need tests for draft-23 version

Commit 840667b provided Quant tests for draft-23

Maybe enough now, with tests now also for Picoquic in commit 1376243


fix The PID_DIR variable in the Doris stop script does not follow the conf file

Proposed changes
Issue: #20784

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

@morningman Could you please review it.


add load from yaml interface for training_config

config training_config with yaml

Codecov Report

Merging #577 (1c7e1c5) into training (2fdbafd) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           training     #577      +/-   ##
============================================
+ Coverage     59.36%   59.96%   +0.59%
============================================
  Files           152      152
  Lines          5970     6054      +84
  Branches        867      867
============================================
+ Hits           3544     3630      +86
+ Misses         2196     2195       -1
+ Partials        230      229       -1

Impacted Files
Coverage Δ

towhee/trainer/training_config.py
87.95% <100.00%> (+14.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fdbafd...1c7e1c5. Read the comment docs.

/lgtm


Does 'RetrainPredictor' start the training from scratch?

Does 'RetrainPredictor' start the training from scratch or does it mean 'finetuning'?
If yes. Is it possible to train a base predictor and finetune another model from this starting point on another dataset?

Hi, RetrainPredictor start from scratch.


enabled initalDelaySeconds on StartupProbe

Enabled initalDelaySeconds on StartupProbe to avoid needless spamming of warnings by adding initialDelaySeconds of '5' seconds inside StartupProbe which is present in https://github.com/cilium/cilium/blob/main/install/kubernetes/cilium/templates/cilium-agent/daemonset.yaml and https://github.com/cilium/cilium/blob/main/install/kubernetes/cilium/templates/cilium-envoy/daemonset.yaml
Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #28574

/test

@jignyasamishra There are some CI failures that I believe are caused by your branch being slightly out of date with main. Could you git rebase you branch on origin/main? Thanks!

@jignyasamishra There are some CI failures that I believe are caused by your branch being slightly out of date with main. Could you git rebase you branch on origin/main? Thanks!

@gandro I have updated my branch is it  good to go?

Thanks! Please use rebase, not merge. We cannot merge branches with merge commits unfortunately.

Thank you so much!! Sorry for the delay. Is it good to go?

/test

@gandro  can we merge this PR? Or some changes are needed?

@gandro can we merge this PR? Or some changes are needed?

There are failing tests, which is why the "ready-to-merge" label is not automatically added. I've however triaged the required tests, and the failures are unrelated:

ci-ginko failed provisioning the VM
ci-runtime also seemed to have troubles provisioning the VMs

I'll restart all failed tests and once CI is green, this is ready to merge.


NuxtPage doesn`t work in Nuxt 3.7.3

Environment
`------------------------------

Operating System: Darwin
Node Version:     v19.9.0
Nuxt Version:     3.7.3
CLI Version:      3.8.3
Nitro Version:    2.6.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      experimental, runtimeConfig, app, dev, debug, telemetry, css, plugins, modules, tailwindcss, image, imports, vue, vite
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

👉 Report an issue: https://github.com/nuxt/nuxt/issues/new                        5:33:40 PM
👉 Suggest an improvement: https://github.com/nuxt/nuxt/discussions/new
👉 Read documentation: https://nuxt.com
`
Reproduction
<NuxtPage :page-key="shop-${shop.slug}" />
Describe the bug
After updating to version 3.7.3 NuxtPage stopped working in the entire project
Uncaught (in promise) Error: Page Not Found
    at createError (index.mjs?v=2a803633:78:15)
    at createError (null:31:16)
    at index.vue:37:11

Additional context
No response
Logs
No response

@danielroe sent

It doesn`t work in Nuxt 3.7.2 too

I had the same problem so he's what I did

I first created a blank layout
Created a new page and added the blank layout
Than tested, it was working fine
Then I thought it must be something to do with middleware then I disabled all the middlewares
But still I had this problem
So finally I was able to identify the problem, definePageMeta
I need to add proper name to definePageMeta
And this fixed all my issues
I hope this helps

@danielroe Here is the reproduction of the issue:
Nuxt 3.7.3 (bugged) https://stackblitz.com/edit/github-wym2sa?file=app.vue
Nuxt 3.7.0 (working properly) https://stackblitz.com/edit/github-yk3aog?file=app.vue

@danielroe Here is the reproduction of the issue:
Nuxt 3.7.3 (bugged) https://stackblitz.com/edit/github-wym2sa?file=app.vue
Nuxt 3.7.0 (working properly) https://stackblitz.com/edit/github-yk3aog?file=app.vue

Hello, we have the same bug but with the layouts. When we change the page and the layout we dont change the page. We need to force reload on the good url for change the layout and get the new page.

@danielroe there is a solution?

Hello,
I suspect this might also be the cause of the bug I am experiencing after upgrading from v.3.7.1
After updating from v.3.7.1 my index.vue page witch has a  component does not render or load data when navigating to a nested page. I am loading some data in users/index.vue and passing this data to the  component as a prop. This worked fine in v.3.7.1, but the props are undefined in v.3.7.3.
v.3.7.1 (working) => https://stackblitz.com/edit/nuxt-starter-m5rkvz?file=pages%2Fusers%2Findex.vue
v.3.7.3 (bugged) => https://stackblitz.com/edit/github-t75rcc?file=pages%2Fusers%2Findex.vue
In version v.3.7.1 navigating to users/all would also render any content inside the users/index.vue file as it contains a  component.
In v3.7.3 navigating to users/all does not render the contents of users/index.vue and does not care if the  component is present or not. It only renders the contents of all.vue.

Hello it's not fix for layouts.

@TartanLeGrand Do you use setPageLayout function to change your layouts?
https://nuxt.com/docs/guide/directory-structure/layouts#changing-the-layout-dynamically

I am encountering an issue where I don't want to alter the layout of my current page, but rather change it when navigating to a new page. I am transitioning from the default layout to a custom layout using definePageMeta. The first page employs the default layout, and the second one uses the custom layout. However, when I switch from the first page to the second page, the layout doesn’t switch. Here is my directory structure:
pages/
  - index.vue
  custom
    - index.vue

If you're having an issue with layouts, would you perhaps open a new issue with a reproduction? The root cause of this one was incorrectly nesting child routes, and not related to layouts.

@TartanLeGrand look here - https://stackblitz.com/edit/github-4tumnt?file=pages%2Fcustom%2Findex.vue
Layouts work as expected

Hi @KamilBeda and @danielroe,
Thanks for your quick replies! With @TartanLeGrand, we figured out the issue in our project. It turns out, the Headless UI Dialog component was causing the problem when switching pages with a different layout.
Here's the comment that helped us pinpoint the issue: https://github.com/tailwindlabs/headlessui/issues/1496#issuecomment-1657222089

Hello @danielroe,
I've encountered a persistent issue while setting up Nuxt for several e-commerce and media streaming projects. This challenge arises across various environments, including Docker, Bun (as our Node.js runtime), and Nuxt, tested on macOS, Linux, Windows, and WSL 2.0 setups. Initially, I suspected Docker might be the culprit since I used docker-compose to streamline our development setup, aiming to mitigate dependency-related setup issues. However, my investigations have led me to reconsider.
The issues manifest in two main areas:
Page Views: Components created within the /pages directory behave as expected as components but fail to serve as pages, resulting in a 404 error. Temporarily, restarting the development server mitigates this issue, but it's far from a practical solution.

Server Components: Similarly, API routes defined under /server don't reflect changes until after a server restart. This necessitates frequent recompilation and server restarts upon any modification, which significantly hampers our development workflow.

Our stack includes Headless UI, UNOcss, and various Tailwind presets. In an attempt to isolate the issue, I transitioned from a Docker-based setup to a local development environment across Windows, macOS, and Linux Mint 21.3 Cinnamon, suspecting OS-related discrepancies might be at play. However, this change did not resolve the issues.
Further experimentation led me to believe the issue might stem from our package manager. However, substituting Bun with npm, pnpm, and Yarn yielded no difference. Starting a new project with the latest version of Nuxt did not eliminate the issues either. Interestingly, issue #2 behaves slightly differently in a local setup; after the initial server restart, subsequent API route changes under /server are recognized without needing further restarts, offering a temporary workaround.
Upon closer examination, it seems issue #1 is intricately linked to our layout logic. Our strategy involves a singular app.vue that incorporates NuxtPage and NuxtLayout, along with a custom layout comprising basic components like headers, footers, and a slot. Integrating new or updated routes from /pages into our header component (which utilizes NuxtLink) triggers the 404 errors, whereas directly using routes within page components like index.vue does not cause any issues.
To summarize, the root cause appears to be unrelated to the package manager, operating system, or Docker setup; instead, it hinges on how layout management is handled within Nuxt. This revelation steers us away from incorporating such logic within layouts, despite its appeal.
Regarding issue #2, I have yet to find a workaround for recognizing file changes within Docker (e.g., /api/example.ts) without a complete server restart.
I hope this detailed account aids in diagnosing and addressing these concerns. Thank you for your attention to these matters.


[ReactNative] fix Markdown link text render error

Related Issue
[#7478 ]
Description
The markdown link pattern [([^[].*?)] cannot handle the link text which contains '[', it will render error
The markdown link pattern should be (.*?)
Sample Card
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"version": "1.0",
"body": [
{
"type": "TextBlock",
"text": "This is some bold text"
},
{
"type": "TextBlock",
"text": "This is some italic text",
"spacing": "medium"
},
{
"type": "TextBlock",
"text": "- Bullet \r- List \r",
"wrap": true,
"spacing": "medium"
},
{
"type": "TextBlock",
"text": "1. Numbered\r2. List\r",
"wrap": true,
"spacing": "medium"
},
{
"type": "TextBlock",
"text": "Check out test [Adaptive] Cards",
"spacing": "medium"
}
]
}
How Verified

open ReactNative TextBlock.MarkDown
before

fixed

Microsoft Reviewers: Open in CodeFlow

Please open this PR in the BigThinkCode/AdaptiveCards repo, as that's where active development on the ReactNative renderer happens. Thanks!


Re-connect when telemetry is unresponsive during dialing

FIX #3276

Not sure if this is what you had in mind, so please take a look @tomaka
What would be the correct way to test this by the way?

Not sure if this is what you had in mind, so please take a look @tomaka

No, we already have a timeout for connecting:
https://github.com/paritytech/substrate/blob/c63ee7ad8fef5aba30930e56b82e282e2f14d1d5/core/telemetry/src/worker.rs#L112
What I mean is: once a connection is open, we don't detect if the telemetry server doesn't send back ACKs.
The way we should do that is adding a timeout when sending data, so:

Here: https://github.com/paritytech/substrate/blob/c63ee7ad8fef5aba30930e56b82e282e2f14d1d5/core/telemetry/src/worker/node.rs#L212
And here: https://github.com/paritytech/substrate/blob/c63ee7ad8fef5aba30930e56b82e282e2f14d1d5/core/telemetry/src/worker/node.rs#L196

Once async/await are stable, it will be very easy to add timeouts. In the meanwhile, thought, I don't know how clean it's possible to do that.
Maybe using MaybeDone can make it easier to implement, I'm not sure.

Can we not just add a timer that is reset each time we receive an ack? If the ack is not received in the expected time frame, we close the connection? (This assumes we send regular ping messages)

We can't detect ACKs and we don't ping the connection. A timeout when writing is an indirect way of doing that.

Yeah okay, then a timer should still be do-able. Just reset the timer each time we can send something. If we don't send data, we will timeout.

@tomoka what do you want to do with pending messages when we timeout?

Just throw them away. This are just telemetry messages. But as we don't further poll the channel, we drop the messages automatically.

Ok here is another try. Any ideas on how to test this?

Ok, this may be more like it.

This will never resolve since you're recreating a new Delay every time we poll.
There should be an Option<Delay> stored in the struct, that gets set to something (if necessary) whenever we start sending, and reset whenever we successfully send.

@tomaka Ok, this might be better, testing locally...

I think this will trigger a timeout if we don't send any message to the telemetry for more than 500ms.
Really what we need is the timeout when sending data and flushing.

@tomaka Ok I think this might be better. One thing I noticed is that I get a Poll::Ready(Ok(())) from the call to Sink::poll_flush even if I turn off the wifi. Any ideas on how to test this?

Flushing doesn't necessarily do anything. If everything has already been sent out, I expect that flushing simply returns Ok() even if in reality you're not connected anymore.

@tomaka Ok, ready for review then.

@maciejhirsz is this code useful?

@tomaka the original issue is yours, so it's your to review :-P

The behaviour looks good to me, but I'd like connection_timeout to be in NodeSocketConnected.

@tomaka A question in order to move the logic to inside NodeSocketConnected: when the timeout fires, and the socket is still writing data, presumably the right thing to do would be to return an error, so that the outer loop would reconnect. How can I manually return the right error type for TSinkErr?
All the other code just forward errors otherwise, and I can't quite make out how to manually create such an error.

the right thing to do would be to return an error, so that the outer loop would reconnect.

Yes!

How can I manually return the right error type for TSinkErr?

The right thing to do would be to create a custom enum, of either "timeout error" or "sink error", and use it as the return type instead of TSinkErr, similar to this:
https://github.com/paritytech/jsonrpsee/blob/076122d9d6e053c33bcdb24b785cb0ba79c854cc/ws/src/client.rs#L79-L108

@tomaka worth continuing to review this?

It's still quite far away from being perfect in terms of logic.
To be fair, this issue is way more complex than it looks.
I opened #3916 instead.


Why ExpirableSemaphore does not expire?

@mrniko, could you take a look at this question: https://stackoverflow.com/questions/59073355/is-there-some-kind-of-lock-semaphore-with-idle-ttl?
Redis version
3.2
Redisson version
3.11.6
Redisson configuration
singleServerConfig:
  address: redis://<IP_ADDRESS>:6379
  timeout: 300
  connectTimeout: 1000
  keepAlive: true
  pingConnectionInterval: 3000
  pingTimeout: 300
  connectionMinimumIdleSize: 8
  connectionPoolSize: 16

zset contains timeout doesn't expire when object expiration was set.

Please provide the test code to reproduce the issue

Actually, when I specify TTL, the semaphore key is removed after a while, but not the "{some-key}:timeout".
How to reproduce:
  val semaphore = redisson.getPermitExpirableSemaphore("some-key")
  semaphore.trySetPermits(1)
  semaphore.expire(30, TimeUnit.SECONDS)
  val permitId = semaphore.tryAcquire(10, 10, TimeUnit.SECONDS)

Check in redis-cli:
<IP_ADDRESS>:6379> keys *
1) "{some-key}:timeout"
2) "some-key"
<IP_ADDRESS>:6379>

After a while:
<IP_ADDRESS>:6379> keys *
1) "{some-key}:timeout"
<IP_ADDRESS>:6379>

Note: I do not delete the semaphore intentionally.

Fixed

@mrniko when do you plan to release 3.11.7 version?


Could you add box feature where you can add sub-items inside of that box?

It would be nice to have div wrapper that you can add sub items inside of the boxes.
For instance, there is new snippet item call div with empty div box.
If you drag box creates simple div tag that can hold input fields, textareas for that box only aka subitems.
Something like this.

No, this project is too simple for this.


chore: update aws-sdk-go version

Checklist:

[X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[X] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My builds are green. Try syncing with master if they are not.
[X] My organization is added to USERS.md.

Can I please ask what problem this resolves?

There is no issue. I was troubleshooting an issue with aws IRSA and was looking at this package. We solved the issue and while this was not the problem, I noticed the version is about 6 months old.


key modifier with expression as handler breaks build

Version
3.4.1
Reproduction link
https://github.com/jonaskuske/vue-cli-issue-modifier-expression
Environment info
Environment Info:

  System:
    OS: Linux 4.4 Ubuntu 16.04.5 LTS (Xenial Xerus)
    CPU: (8) x64 Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
  Binaries:
    Node: 10.13.0 - /usr/bin/node
    Yarn: 1.13.0 - /usr/bin/yarn
    npm: 6.8.0 - ~/.npm-global/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0-beta.2
    @vue/babel-plugin-transform-vue-jsx:  1.0.0-beta.2
    @vue/babel-preset-app:  3.4.1
    @vue/babel-preset-jsx:  1.0.0-beta.2
    @vue/babel-sugar-functional-vue:  1.0.0-beta.2
    @vue/babel-sugar-inject-h:  1.0.0-beta.2
    @vue/babel-sugar-v-model:  1.0.0-beta.2
    @vue/babel-sugar-v-on:  1.0.0-beta.2
    @vue/cli-overlay:  3.4.1
    @vue/cli-plugin-babel: ^3.4.0 => 3.4.1
    @vue/cli-service: ^3.4.0 => 3.4.1
    @vue/cli-shared-utils:  3.4.1
    @vue/component-compiler-utils:  2.6.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    vue: ^2.6.6 => 2.6.7
    vue-hot-reload-api:  2.3.2
    vue-loader:  15.6.4
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.6.7
    vue-template-es2015-compiler:  1.9.0
  npmGlobalPackages:
    @vue/cli: 3.4.1

Steps to reproduce

Use a key modifier that inserts a conditional into the resulting event handler function, like .exact or .shift
Use an expression as handler, e.g.  @click.exact="$emit && $emit('click')"
Build the project, doesn't matter if for development, production or testing
Failed to compile.

What is expected?
The project compiles and runs.
What is actually happening?
The compiled render function has a Syntax Error and the project fails to compile.

The template
<div @click.exact="$emit && $emit('✅')">Modifier bug</div>

results in the following error:

If we prettify the compiled function it looks like this:
var render = function() {
  var _vm = this;
  var _h = _vm.$createElement;
  var _c = _vm._self._c || _h;

  return _c(
    'div',
    {
      on: {
        "click": function($event) {
          if ($event.ctrlKey || $event.shiftKey || $event.altKey || $event.metaKey) {
            return null;
            _vm.$emit && _vm.$emit('✅')
          }
        }
      // ! WE'RE MISSING A CLOSING BRACKET HERE!
    }, [_vm._v("Modifier bug")])
}

As I highlighted in the code, the Syntax is invalid because a closing bracket is missing. But the actual issue is the botched if-statement that's causing this.
The following
if ($event.ctrlKey || $event.shiftKey || $event.altKey || $event.metaKey) {
  return null;
  _vm.$emit && _vm.$emit('✅')
}

needs to be
if ($event.ctrlKey || $event.shiftKey || $event.altKey || $event.metaKey) return null
_vm.$emit && _vm.$emit('✅')

otherwise the user code will never run...

Note that this issue doesn't affect Vue's runtime compiler, you can copy-paste
import Vue from 'https://unpkg.com/vue/dist/vue.esm.browser.js'
new Vue({
  el: document.body.appendChild(document.createElement('div')),
  template: `<p @click.shift="$emit && $emit('click')">✅</p>`
})

into a Codepen and it works without a hitch.
This is also the reason why I filed the issue here and not in the repository for Vue itself, hope this was right. (or is this an issue with Vue Loader?)

Thanks for reporting, this is fixed in<EMAIL_ADDRESS>see details here: https://github.com/vuejs/vue-template-es2015-compiler/releases/tag/v1.9.1.

Ah, perfect!
Didn't know the ES2015 compiler is a separate package, that's why I didn't find the already existing issue 😅


Duplicated interceptors

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior

I have an HttpClient service that "wraps" HttpService by initializing axiosRef with some interceptors to add some logging.
This HttpClientService is imported by several modules that have to do API requests or have their own client.

The result of this is that a single request is logged as many dependencies on HttpClient I have.
How can I avoid this duplication?
Minimum reproduction code
https://gist.github.com/matiasgarcia/53d2aa20acecec511b285efd86525279
Steps to reproduce
No response
Expected behavior
Single interceptor added
Package version
0.1.0
NestJS version
9.0.11
Node.js version
v16.17.0
In which operating systems have you tested?

[ ] macOS
[ ] Windows
[X] Linux

Other
No response

@micalevisk sorry but I am not following you
Gien the gist from above, and these modules:
@Module({
  imports: [HttpClientModule, ConfigurationModule],
  providers: [CryptocambiosService],
  exports: [CryptocambiosService],
})
export class CryptocambiosModule {}

import { Module } from '@nestjs/common';
import { ApexService } from './apex.service';
import { ConfigurationModule } from '../configuration/configuration.module';
import { HttpClientModule } from '../http-client/http-client.module';

@Module({
  imports: [HttpClientModule, ConfigurationModule],
  providers: [ApexService],
  exports: [ApexService],
})
export class ApexModule {}

This is not achieving what you mentioned?

if you want to use the same instance of that service everywhere, don't import the service multiple times. Instead, import it only once in some module, export it from there, and then import this new module multiple times whenever you need to use the HttpClientService provider

oh I thought you were importing the service multiple times, not the HttpClientModule module.
Check out if HttpClientService's constructor has been invoked multiple times.

Please, use our Discord channel (support) for such questions. We are using GitHub to track bugs, feature requests, and potential improvements.


tidyup a little with the latest golang.org/x/tools/cmd/vet

client_test.go:165: ExampleUpdateLeaseTSIG should be niladic
client_test.go:165: ExampleUpdateLeaseTSIG refers to unknown identifier: UpdateLeaseTSIG
parse_test.go:572: ExampleZone refers to unknown identifier: Zone
parse_test.go:802: ExampleGenerate refers to unknown identifier: Generate
exit status 1
example_test.go:34: ExampleDS should be niladic
exit status 1
idn/punycode.go:202: unreachable code
exit status 1

is there a way to re-trigger Travis CI build?

[ Quoting<EMAIL_ADDRESS>in "Re: [dns] tidyup a little with the ..." ]

is there a way to re-trigger Travis CI build?

Can't you just click the button on the PR? Otherwise push some whitespace
changes as a commit...?
/Miek
--
Miek Gieben


Use backticks on some field names.

This will basically fix #531, since it doesn't look like backticks are really doable for enum and message names.


Update Caesar.java

Describe your change:

[ ] Add an algorithm?
[ ] Fix a bug or typo in an existing algorithm?
[ ] Documentation change?

References

Checklist:

[ ] I have read CONTRIBUTING.md.
[ ] This pull request is all my own work -- I have not plagiarized.
[ ] I know that pull requests will not be merged if they fail the automated tests.
[ ] This PR only changes one algorithm file.  To ease review, please open separate PRs for separate algorithms.
[ ] All new Java files are placed inside an existing directory.
[ ] All filenames are in all uppercase characters with no spaces or dashes.
[ ] All functions and variable names follow Java naming conventions.
[ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
[ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

CodeScene PR Check

Warnings
Degrades in Code HealthCaesar.java degrades from a Code Health of 9.33 -> 4.0

Code Health Delta Descriptions
Caesar.java Improvements: Large Method - no longer an issue Degradations: Lines of Code in a Single File(total of 3963, recommended next goal: 1000 lines of code) - new issueConstructor Over-Injection (the constructor ZooKeeperServer has 8 arguments, threshold = 5 arguments) - new issueBrain Method (Change with -27 lines of code and increase with 16 conditional complexity (cc) in processConnectRequest: cc = 17, cc threshold = 9) - new issueNumber of Functions in a Single Module - new issueExcess Number of Function Arguments (checkACL has 6 arguments, threshold = 5 arguments) - new issueBumpy Road Ahead (processPacket has 4 logical blocks with deeply nested code. Threshold is 1 (one) single block per function) - new issueCode Duplication (functions with similar structure: ZooKeeperServer,authWriteRequest,checkACL,dumpConf and 9 more functions) - new issueDeep, Nested Complexity (Increasing with 5 nesting levels in checkACL: depth  = 5 levels, threshold = 4 levels) - new issuePrimitive Obsession - new issue


Documentation EXTERNAL_COMPONENTS

Add documentation for the feature added in https://github.com/zowe/zowe-install-packaging/issues/1022

Demo apps:
Demo Sample Trial App - iframe app plugin for Zowe Desktop
https://github.com/zowe/sample-trial-app/pull/5
Demo API registration behind API/ML
https://github.com/zowe/sample-node-api/pull/7

@stevenhorsman @Joe-Winchester
Made EXTERNAL_COMPONENT scenario master branch so it can be easily shared, its first draft, feel free to verify readme, it can be improved.
https://github.com/zowe/sample-node-api
https://github.com/zowe/sample-trial-app


add CI pipline

copy CI pipeline from https://github.com/snakemake-workflows/snakemake-workflow-template/tree/main/.github/workflows
implement and test

Add: coda envs to rules (None for no conda).

no input given for linitin:
needs test data, chain main.yml

Resolved with #90.


Toggle Clickable

There is no ability to toggle the clickable state of a marker/layer. You can toggle dragging on/off, but clickable has no such feature.

Closed in favor of #5442


Scheduling commands handled by laravel

this pr will make schedule command calls handled by laravel.
please test this before merging (if you want to merge at all).

@llabbasmkhll Thanks for considering to contribute.
This can be handled by a cronjob that is already explained in the Readme. however, If you want to add it to the Laravel schedules you can simply add the schedule to your app/Console/Kernel.php.
I think it would be better to mention this on the Readme instead of complicating the codes by adding it to the Provider.


endRefreshing animates scrollView to top inset instead of zero

To use a ScrollView and RefreshControl with a translucent navigation bar you have to set the top inset to the height of that bar, allowing the content to scroll underneath. After changes to RCTRefreshControl in  v0.22, endRefreshing always animates the offset to 0, hiding content behind the navigation bar. What you'd expect on iOS is for it to return to the bottom of the bar.
Test plan
To see this in action, refer to the UIExplorerApp. In RefreshControlExample.js if you set the ScrollView's contentInset={{top: 100}} you'll see the refresh control UI is where you'd expect, and after refresh the list returns to the correct position.

Thanks for this, I also hit this issue and applied my own fix but yours is much cleaner :)

LGTM
cc @corbt @nicklockwood

@facebook-github-bot shipit


It wont send to client

I have both Minecraft and the app on one computer to test it to see if it would work but when i interact with the settings it doesn't appear on Minecraft.

Hi, i have made a new release that hopefully fixes your issue. If it doesn't work, feel free to reopen this issue.
https://github.com/dsinkerii/messedup-settings/releases/latest


[INLONG-4824][Agent] Print line numbers in log info

Add line numbers to Agent module log output

Fixes #4824

@Greedyu please check the log4j configurations for the DataProxy and Manager at the same time, thanks.

configurations

resolve


Col-x with more than one class

It seems, like it's required to add additional classes behind the col-x class.
If you write a col-div this way:

Some content

the grid is destroyed and doesn't work as intended.
If you switch the classes everything works fine.

Some content

BR

Thanks @eTomate
This is a bug, nice catch! For now just use custom classes after col-x, and it should work fine. I don't know what is causing this, but I will try to figure it out :)
Thanks again :+1:

I just submitted a bugfix for this problem.
The problem was the [class^='col-] selector for row. By adding a "*=' col-' selector, we catch col-x elements within a  list of classes.

@eTomate Thanks!
I merged the PR, the bug should be fixed now :+1:


GLXT Server connection

On app open I receive a "Could not connect to GLXT Electrum Server" error
Version: alpha 13
OS: win 10
Errors: below
Severity: Medium

Thanks for reporting, this is an issue on the GLXT end though not related to HyperDEX, we use the official GLXT electrum servers:
electrum1.glx.co
electrum2.glx.co
https://github.com/atomiclabs/hyperdex/blob/4b9d39737a514c0aa11b4d951feb1f9d8d6e96b8/app/marketmaker/supported-currencies.js#L995-L1009
Could you report the issue to GLXT if the issue persists?


Song not found

I keep getting an error when I try to queue a music by name
https://f.lewd.se/ALv151_28262707.png
But it works when I try with a link, any ideas how to fix it?

Yes, you're missing a google api key. You must have a google api key with youtube data api enabled (and a few more for other commands) Refer to the guide, part about api keys


Clear log window

Hi,
when debugging or testing something I'ld like to have only the specific part for this action in the log window instead of searching through everything what is there to find the relevant part.
Now I was told just to push the -Serial Debug Output- button again which should clear the window.
Funnily enough it does, but the flasher also tries to open the COM port again while he did not disconnect it before.
Following error message appears:
Unexpected error: could not open port 'COM7': PermissionError(13, 'Zugriff verweigert', None, 5)
and of course things do not work any more. I have to close the flasher application and open it again.
OS: MS Windows
XeAtari

Can you test the attached build and let me know if this is still an issue for you? On my windows 11 system I get the "could not open port" error, but serial debug output is printed
FujiNet-Flasher_win-x64.zip

Latest release adds some serial port closing fixes https://github.com/FujiNetWIFI/fujinet-flasher/releases/tag/v1.4.2
Please reopen if it's still a problem


Text-search for Threads posts: Is it feasible?

Can the text search feature be implemented for searching Threads posts?

Currently, no, even the official Threads application itself does not support it yet.


Consider evaluating calc before seek_before

Consider evaluating calc/try_calc before seek_before, which would enable the following setup:
#[bw(stream = st)]
struct Main {
	// need to write textures offset at 0xC...

	// write other fields

	// ...but we don't know the offset until we're here.
	// It would be nice if we could get the texture offset this way:

	#[bw(try_calc = st.stream_position())]
	#[br(temp)]
	#[brw(seek_before = SeekFrom::Start(0xC), restore_position)]
	textures_offset: u32,

	// textures written here...
	textures: Textures,
}

Currently, try_calc is evaluated after seek_before, so the value of st.stream_position() is always 0xC.
I think it would make sense to switch the order of operations here, considering the argument to SeekFrom is either a constant or a field (it wouldn't make sense to use the old stream position, you'd use SeekFrom::Current instead), so it shouldn't break existing use cases.

Hi, thanks for your report!
This is related to the general problem of writing offsets, #4.
Other than actually fixing #4 so there is a simple blessed way to handle this case, I am not really sure what to do, and I am struggling to think through the ramifications of making a change here. From a logical perspective, the current order of operations is correct: value calculation replaces reading/writing, and reading/writing occurs after seeking in the file, so calculation also occurs after seeking.


Throw an error if the event listening class is annotated with @Startup

If a class is annotated with io.quarkus.runtime.Startup, it will be made a bean.
We do not want the event listening class to be a bean as it will be subclassed and it's the subclass that should be a bean.
Typically, this can lead to unexpected behavior when having a @PostConstruct annotation.

Hi @gsmet I would like to take a look on this issue.
Is this the class and method to do the check
https://github.com/quarkiverse/quarkus-github-app/blob/main/deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java#L264
Is it an IllegalArgumentException to be thrown if the annotation is found?

Hi @shinusuresh .
Yeah that would have been the class.
But I think what we should do instead to solve this issue is implement https://github.com/quarkiverse/quarkus-github-app/issues/109 . It should solve the problem in a far better way.
I'll add some information to #109 so that you have some guidance.
Will close this one!


Register!

Can you register the package? 🔥

Oh oops it's already registered! I was confused because of the readme instructions


Implement TaskServlet::doGet to list tasks lexically.

Tasks are logged on startup but aren't easily accessible otherwise. Implement TaskServlet::doGet to print tasks lexically by name.
Example:
$ curl http://localhost:8081/tasks
echo
gc
log-level

TaskServlet is mapped on "/tasks/*" and any GET request not matching root
will yield 404 or 405.
404: Task name is unknown.
405: Task name is registered but must be invoked with POST.

Coverage increased (+0.1%) to 84.899% when pulling 75a93cdf9857944a0d5f029138449315bf9dd026 on aaanders:list-tasks into e823137be416aac5344f42c7b50379ffa03b4b97 on dropwizard:master.

Coverage increased (+0.1%) to 84.905% when pulling 75a93cdf9857944a0d5f029138449315bf9dd026 on aaanders:list-tasks into e823137be416aac5344f42c7b50379ffa03b4b97 on dropwizard:master.

Coverage increased (+0.04%) to 84.807% when pulling 4c2659ac1c940fa2eaaed3521db1890b7f195c45 on aaanders:list-tasks into 5ece5072e1e78a0a78053e6c800a410bb8954ec5 on dropwizard:master.

Coverage increased (+0.04%) to 84.807% when pulling 4c2659ac1c940fa2eaaed3521db1890b7f195c45 on aaanders:list-tasks into 5ece5072e1e78a0a78053e6c800a410bb8954ec5 on dropwizard:master.

Thanks for reviewing @joschi


Feat: Terms, Privacy Policy, Credits

Research, write, and implement a terms of use, privacy policy, and credits
Requirements

[ ] Produce a legally valid terms and privacy policy
[ ] Correctly attribute contributors in a credits page
[ ] Host these pages somewhere, then add links to them in the footer

Also adding disclaimer (from PvPoke): Pokémon and Pokémon GO are copyright of The Pokémon Company, Niantic, Inc., and Nintendo. All trademarked images and names are property of their respective owners, and any such material is used on this site for educational purposes only.

Also adding disclaimer (from PvPoke): Pokémon and Pokémon GO are copyright of The Pokémon Company, Niantic, Inc., and Nintendo. All trademarked images and names are property of their respective owners, and any such material is used on this site for educational purposes only.

Github public projects extend the Github TOS. Instead I'll like the Github and MIT License in the footer. Still working on privacy policy

Github public projects extend the Github TOS. Instead I'll like the Github and MIT License in the footer. Still working on privacy policy

Previous startup I worked at recommended Cooley. Cooley is a well respected law firm that often works with tech companies. Their privacy policy generator is down for maintenance, but I will keep watch for when it comes back up.

Previous startup I worked at recommended Cooley. Cooley is a well respected law firm that often works with tech companies. Their privacy policy generator is down for maintenance, but I will keep watch for when it comes back up.


Raise a warning when there is no ctor and a method has the same name as the class

Pursuant to this Stack Overflow question it would be desirable to raise a warning when a class has no explicit constructor but does have a method with the same name as the class. This probably indicates that the coder has used C# ctor syntax. Because this is legal Typescript method syntax, the "constructor" does not raise any errors or warnings except indirect ones like members not being initialised in the constructor.
A warning "This class has no explicit constructor but has a method with the same name as the class. Have you used C# constructor syntax?" would save time and embarrassment.

Sorry, wrong repo.


Feature/issue 86 tasks states

I'd actually like to write a couple tests outlining assumptions around task states .. moving to in progress.