Command "npm run build:e2e" doesn't work for Windows

Describe the bug
Command npm run build:e2e doesn't work for Windows
To Reproduce
Steps to reproduce the behavior:

Go to 'opencollective-frontend' folder
run command npm run build:e2e
In files build_next.sh and build_server.sh see error  Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

Expected behavior
Expect build in dist folder
Screenshots

Desktop (please complete the following information):

OS: Windows 10 Pro 19044.2486
Browser Google Chrome
Version 110.0.5481.78

Additional context
Related https://github.com/opencollective/opencollective/issues/5836

Triage Template (core team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

That's not really an issue since this command is only used by our CI, which runs on Linux. We can eventually merge if there's an easy fix that doesn't break our current setup.


windows_task is not idempotent on non-English versions of Windows

Description
windows_task resource converges each time as user property is not SYSTEM or any other from https://github.com/chef/chef/blob/master/lib/chef/resource/windows_task.rb#L119.
Task is created successfully but running under система or СИСТЕМА user. I think that similar problem exists on different versions of Windows (non-English).
https://github.com/chef/chef/blob/2c4f13a14d762a306dbe051c658cb9b848b670b6/lib/chef/provider/windows_task.rb#L330
def task_needs_update?(task)
          flag = false
          if new_resource.frequency == :none
            flag = (task.account_information != new_resource.user ||

task.account_information != new_resource.user is always true because account_information is in different language and therefore not SYSTEM.
How we can workaround this use case?
Chef Version
13.9.4
Platform Version
Windows Server 2016 Datacenter Evaluation Russian Edition
PS C:\Users\vagrant> get-winsystemlocale

LCID             Name             DisplayName
----             ----             -----------
1049             ru-RU            Русский (Россия)

Replication Case
include_recipe 'chef-client::task'

Client Output
[2018-09-07T10:39:49-07:00] DEBUG: Providers for generic windows_task resource enabled on node include: [Chef::Provider::WindowsTask]
       [2018-09-07T10:39:49-07:00] DEBUG: Providers for generic windows_task resource enabled on node include: [Chef::Provider::WindowsTask]
       [2018-09-07T10:39:49-07:00] DEBUG: Provider for action create on resource windows_task[chef-client] is Chef::Provider::WindowsTask
       [2018-09-07T10:39:49-07:00] DEBUG: Provider for action create on resource windows_task[chef-client] is Chef::Provider::WindowsTask
       [2018-09-07T10:39:49-07:00] DEBUG: Looking for existing tasks
       [2018-09-07T10:39:49-07:00] DEBUG: Looking for existing tasks
       [2018-09-07T10:39:49-07:00] DEBUG: windows_task[chef-client] task exists.
       [2018-09-07T10:39:49-07:00] DEBUG: windows_task[chef-client] task exists.
       [2018-09-07T10:39:49-07:00] DEBUG: Finding system date format
       [2018-09-07T10:39:49-07:00] DEBUG: Finding system date format
       [2018-09-07T10:39:50-07:00] DEBUG: running:
       [2018-09-07T10:39:50-07:00] DEBUG: running:
       [2018-09-07T10:39:50-07:00] DEBUG:     schtasks /CREATE /TN "chef-client" /F /SC "minute" /ST "10:37" /SD "07.09.2018" /MO "30" /RU "SYSTEM" /RL "HIGHEST" /TR "cmd /c 'C:/opscode/chef/bin/chef-client -L C:/chef/log/client.log -c C:/chef/client.rb -s 300' "
       [2018-09-07T10:39:50-07:00] DEBUG:     schtasks /CREATE /TN "chef-client" /F /SC "minute" /ST "10:37" /SD "07.09.2018" /MO "30" /RU "SYSTEM" /RL "HIGHEST" /TR "cmd /c 'C:/opscode/chef/bin/chef-client -L C:/chef/log/client.log -c C:/chef/client.rb -s 300' "
       [2018-09-07T10:39:50-07:00] DEBUG: looking for existing tasks
       [2018-09-07T10:39:50-07:00] DEBUG: looking for existing tasks
       [2018-09-07T10:39:50-07:00] DEBUG: Removing former execution_time_limit if any
       [2018-09-07T10:39:50-07:00] DEBUG: Removing former execution_time_limit if any
       [2018-09-07T10:39:50-07:00] DEBUG: Setting execution_time_limit as PT72H
       [2018-09-07T10:39:50-07:00] DEBUG: Setting execution_time_limit as PT72H
       [2018-09-07T10:39:50-07:00] DEBUG: running:
       [2018-09-07T10:39:50-07:00] DEBUG: running:
       [2018-09-07T10:39:50-07:00] DEBUG:     schtasks /DELETE /TN "chef-client" /F
       [2018-09-07T10:39:50-07:00] DEBUG:     schtasks /DELETE /TN "chef-client" /F
       [2018-09-07T10:39:50-07:00] DEBUG: running:
       [2018-09-07T10:39:50-07:00] DEBUG: running:
       [2018-09-07T10:39:50-07:00] DEBUG:     schtasks /CREATE /TN "chef-client" /RU "SYSTEM" /XML "C:\Users\vagrant\AppData\Local\Temp/windows_task.xml"
       [2018-09-07T10:39:50-07:00] DEBUG:     schtasks /CREATE /TN "chef-client" /RU "SYSTEM" /XML "C:\Users\vagrant\AppData\Local\Temp/windows_task.xml"

             - windows_task[chef-client] task created

We will be looking into this meanwhile could you please try this out with newer version of Chef ?

[2018-09-09T22:57:05-07:00] DEBUG: Running Ohai with the following configuration: {:logger=>Chef::Log}
       Starting Chef Client, version 14.4.56

chef_client_scheduled_task[Chef Client] action add[2018-09-09T22:57:13-07:00] INFO: Processing chef_client_scheduled_task[Chef Client] action add (chef-client::task line 37)

           * windows_task[chef-client] action create[2018-09-09T22:57:13-07:00] INFO: Processing windows_task[chef-client] action create (C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/cookbooks/chef-client/resources/scheduled_task.rb line 55)

             - windows_task[chef-client] task updated

Also
* windows_task[client] action create[2018-09-09T23:05:08-07:00] INFO: Processing windows_task[client] action create (chef-client::test line 1)

           - windows_task[client] task updated

with following recipe:
windows_task 'client' do
  run_level :highest
  command 'ipconfig.exe'
  user 'SYSTEM'
  frequency :hourly
  frequency_modifier 20
end

We also tried running particular recipe share by you. But in that case also I am unable to reproduce the issue.
windows_task 'client' do
  run_level :highest
  command 'ipconfig.exe'
  user 'SYSTEM'
  frequency :hourly
  frequency_modifier 20
end

First run output:
PS C:\Users\manik> chef-client
Starting Chef Client, version 14.4.56
[2018-09-11T12:01:41+03:00] INFO: *** Chef 14.4.56 ***
[2018-09-11T12:01:41+03:00] INFO: Platform: x64-mingw32
[2018-09-11T12:01:41+03:00] INFO: Chef-client pid: 2604
[2018-09-11T12:01:41+03:00] INFO: The plugin path C:\chef\ohai\plugins does not exist. Skipping...
[2018-09-11T12:01:45+03:00] INFO: Run List is [recipe[starter]]
[2018-09-11T12:01:45+03:00] INFO: Run List expands to [starter]
[2018-09-11T12:01:45+03:00] INFO: Starting Chef Run for manik-russian
[2018-09-11T12:01:45+03:00] INFO: Running start handlers
[2018-09-11T12:01:45+03:00] INFO: Start handlers complete.
[2018-09-11T12:01:46+03:00] INFO: Error while reporting run start to Data Collector. URL: https://api.chef.io/organizati
ons/msys_manik/data-collector Exception: 404 -- 404 "Not Found"  (This is normal if you do not have Chef Automate)
resolving cookbooks for run list: ["starter"]
[2018-09-11T12:01:46+03:00] INFO: Loading cookbooks<EMAIL_ADDRESS>Synchronizing Cookbooks:
  - starter (1.0.0)
Installing Cookbook Gems:
Compiling Cookbooks...
 Skipping...
[2018-09-11T12:02:00+03:00] INFO: Run List is [recipe[starter]]
[2018-09-11T12:02:00+03:00] INFO: Run List expands to [starter]
[2018-09-11T12:02:00+03:00] INFO: Starting Chef Run for manik-russian
[2018-09-11T12:02:00+03:00] INFO: Running start handlers
[2018-09-11T12:02:00+03:00] INFO: Start handlers complete.
[2018-09-11T12:02:01+03:00] INFO: Error while reporting run start to Data Collector. URL: https://api.chef.io/organizati
ons/msys_manik/data-collector Exception: 404 -- 404 "Not Found"  (This is normal if you do not have Chef Automate)
resolving cookbooks for run list: ["starter"]
[2018-09-11T12:02:01+03:00] INFO: Loading cookbooks<EMAIL_ADDRESS>Synchronizing Cookbooks:
  - starter (1.0.0)
Installing Cookbook Gems:
Compiling Cookbooks...
Welcome to Chef, ManikConverging 1 resources
Recipe: starter::default
  * windows_task[client] action create[2018-09-11T12:02:02+03:00] INFO: Processing windows_task[client] action create (s
tarter::default line 9)
[2018-09-11T12:02:02+03:00] INFO: windows_task[client] task does not need updating and force is not specified - nothing
to do
 (up to date)
[2018-09-11T12:02:02+03:00] INFO: Chef Run complete in 2.087767 seconds

Running handlers:
[2018-09-11T12:02:02+03:00] INFO: Running report handlers
Running handlers complete
[2018-09-11T12:02:02+03:00] INFO: Report handlers complete
Chef Client finished, 0/1 resources updated in 06 seconds
[2018-09-11T12:02:02+03:00] INFO: Sending resource update report (run-id: 6785b541-8adb-47a0-a533-6f2cad0f9b0e)

@Vasu1105 Can you run
 Get-WMIObject win32_group -filter "SID='S-1-5-32-544' AND LocalAccount=True" | select -ExpandProperty Name

The output should be in Russian, not English.

@jugatsu Could you please verify your recipe has the same values setup when you are running the recipe second time for the particular task name.

@Vasu1105 You are running on English system with russian UI and locale. In this case windows_task resource works as expected because user that task is running is SYSTEM.
When the system is true Russian version, user that task is running is СИСТЕМА.

@jugatsu its giving me output in English. I am getting that as Administrator
But the output for below is same as you told so I am not sure what I am missing in settings.
PS C:\Users\manik> Get-WinSystemLocale

LCID             Name             DisplayName
----             ----             -----------
1049             ru-RU            Русский (Россия)

@Vasu1105 To reproduce this issue i can make repo with test recipe and build vagrant boxes. But it gonna take some time.

OS: Windows Version 2016 Russian
ISO: http://download.microsoft.com/download/0/D/4/0D41501C-EEBC-4481-8A37-14A56A64BFDA/14393.0.161119-1705.RS1_REFRESH_SERVER_EVAL_X64FRE_RU-RU.ISO (Russian version)
Idempotent: NO

OS: Windows Version 2016 English but with Russian UI and locale (in your example)
ISO: http://care.dlservice.microsoft.com/dl/download/1/4/9/149D5452-9B29-4274-B6B3-5361DBDA30BC/14393.0.161119-1705.RS1_REFRESH_SERVER_EVAL_X64FRE_EN-US.ISO (English version)
Idempotent: YES

In both examples Get-WinSystemLocale returns
LCID             Name             DisplayName
----             ----             -----------
1049             ru-RU            Русский (Россия)

But user (also known as Principal) that task is running IS DIFFERENT because of localization!
First example it's СИТЕМА. It's not idempotent and running over and over again because of
https://github.com/chef/chef/blob/2c4f13a14d762a306dbe051c658cb9b848b670b6/lib/chef/provider/windows_task.rb#L330
Second (your example) - SYSTEM. It's idempotent as
https://github.com/chef/chef/blob/2c4f13a14d762a306dbe051c658cb9b848b670b6/lib/chef/provider/windows_task.rb#L330
in desired state.
@Vasu1105 correct me if I'm wrong.

@jugatsu Thank you for detailed information and the image provided. Yes you are correct and we able to reproduce that with given image. We will update you once we have a fix for this.


Please provide a Visual Studio installer for TypeScript 3.7.3

https://github.com/microsoft/TypeScript/releases
There are a bunch of fixes by @sheetalkamat that we'd like to check to see whether it fixes some persistent intellisense failure in Visual Studio.
Thanks!

I believe it has got shipped today: https://github.com/microsoft/TypeScript/issues/32729#issuecomment-563323490
Thanks for the issue

Still not linked from http://www.typescriptlang.org/#download-links :-(


Why aren't certain assemblies available by default (System.Xml)

I found that in a simple script the intellisense noticed that System.Xml.XmlReader and System.Xml.XmlDocument weren't directly available. I found that I had to use the nuget tool which inserted the #r references directly in the code.  Other assembly references are present by default eg System.Diagnostics and wondered why such common libraries such as those in System.Xml are not.

I added the assemblies I thought were most useful for everyone. Loading assemblies has its costs, and System.Xml is a large one. If others vote for this issue, I'll add it to the default.
Once #20 is done, you'll be able to configure your own defaults.

Closing for now.


Initiate a battle when running other file and dir commands

this is awesome; i love this project
i have long dreamed that something like this would exist!
it would be really cool to have a feature where you can start a battle that, if you win, results in the file being deleted!

I like this idea, it would work as a replacement for rm much like the default works as a replacement for cd. I'll think about this, thank you!

And if you ask to delete a dir it walks it recursively and you have a battle per file to be deleted

My current thinking on this one is that the same concept should apply to other file-modifying commands, not just rm: rmdir, mkdir, mv, cp, touch. If you attempt one of those commands a battle is initiated (perhaps not always but a % of the times); if you win, the command is executed as usual, if you lose, it doesn't (and the hero dies, of course).
Obviously attempting to reimplement all those commands (with their flags and variants) would be crazy, so what we should do instead is to have a generic command (rpg-cli --alias perhaps) that can be put in front of those in shell functions or aliases to achieve this "battle and proceed on win" behavior.

rpg-cli --alias could be implemented via return codes.
Then we dont need do do anything with the actual command.
So we return 0 if:

No monster is found
The monster was bribed
The hero wins

And we return not 0 if

The Hero ran away
The Hero died

Examples
Bash:
rpg-cli --alias && your-command --your-option

Fish
rpg-cli --alias ; and yourcommand --your-option

This should be possible with the new additions, documented in the shell readme


[BUG]: Ranking of questions in FAQ does not work

Describe the bug
Ranking questions for the FAQ via the Admin app does not reflect any changes in the end user app.
To Reproduce
Steps to reproduce the behavior:

Go to Admin App
Click on FAQ
Change ranking of existing questions
Check the end user app. Ranking of questions does not change.

Expected behavior
Ranking of questions in end user app should reflect the configuration in the admin app.
Screenshots
Admin app:

End user app:

Interface(please complete the following information):

Browser: Microsoft Edge
Version date: Version 82.0.446.0 (Official build) dev (64-bit)

Hi @jackhammer84 ,
The next version will include a fix for this. So that you're unblocked, here's a one line fix you can make:
https://powerusers.microsoft.com/t5/Building-Power-Apps/Crisis-Communication-solution-feedback/m-p/501588#M152519

Hi @jackhammer84 ,
Versions after V2.20200323 include a fix to this issue with the FAQ.


Fix examples in the usage text of namespace create

What was changed

Fixed examples of "temporal operator namespace create" to include the missing namespace argument.
Why?

The examples were incorrect and would fail if used. The namespace argument is not documented anywhere.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


all_matches returning 400

Does this new endpoint require any additional information? I keep getting a 400 error code

Did you fix it?
I cant get my matches either

no I did some investigating and it doesn't even seem to have a valid
endpoint.
any ideas on how troubleshoot it?
On Sun, Sep 15, 2019 at 5:53 AM Oshcat<EMAIL_ADDRESS>wrote:

Did you fix it?
I cant get my matches either
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fbessez/Tinder/issues/82?email_source=notifications&email_token=AELAOW7L6V3BUZYDIB7YKJTQJYAZ5A5CNFSM4IMP4232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XNKZI#issuecomment-531551589,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELAOW626URTSE6BOLZRNOTQJYAZ5ANCNFSM4IMP423Q
.

Passed the header below through the recommendations function. The x-auth-token can be found if you log in on the browser. Just search for 'x-auth-token' in the network transactions.
headers = {
'app_version': '6.9.4',
'platform': 'ios',
"content-type": "application/json",
"User-agent": "Tinder/7.5.3 (iPhone; iOS 10.3.2; Scale/2.00)",
"Accept": "application/json",
'X-Auth-Token': tinder_auth_token
}
def get_recommendations():
'''
Returns a list of users that you can swipe on
'''
try:
r = requests.get('https://api.gotinder.com/user/recs', headers=headers)
return r.json()
except requests.exceptions.RequestException as e:
print("Something went wrong with getting recomendations:", e)
print(get_recommendations())

Many authentification answers can be foud on this blog post: https://hackernoon.com/auto-tinder-train-an-ai-to-swipe-tinder-for-you-dw23c3zj7

i still don't understand how to fix this

Its not that difficult, just visit endpoint and specify headers.  You shouldn't have to change the headers though, just use the current tokens and it should work.
endpoint = "https://api.gotinder.com/v2/matches?count=60&is_tinder_u=false&locale=en"
headers:
:authority: api.gotinder.com
:method: GET
:path: /v2/matches?count=60&is_tinder_u=false&locale=en&message=1
:scheme: https
accept: application/json
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9
app-session-id: _insert yours
app-session-time-elapsed: 88309
app-version: 1021900
origin: https://tinder.com
persistent-device-id: _insert_yours
platform: web
referer: https://tinder.com/
sec-fetch-mode: cors
sec-fetch-site: cross-site
tinder-version: 2.19.0
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36
user-session-id: _insert_yours
user-session-time-elapsed: 827
x-auth-token: insert yours x-supported-image-formats: webp,jpeg

Great help, thank you

I wrote exactly the same headers, however It didn't work for me.
Any suggestions?

what happens when your curl the request?
On Sun, Apr 12, 2020 at 6:50 PM ec<EMAIL_ADDRESS>wrote:

I wrote exactly the same headers, however It didn't work for me.
Any suggestions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fbessez/Tinder/issues/82#issuecomment-612688069, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AELAOW27FHDJAD5SVVKDL4LRMJAT5ANCNFSM4IMP423Q
.

what happens when your curl the request?
…
On Sun, Apr 12, 2020 at 6:50 PM ec @.***> wrote: I wrote exactly the same headers, however It didn't work for me. Any suggestions? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELAOW27FHDJAD5SVVKDL4LRMJAT5ANCNFSM4IMP423Q .

It replies with code 400 and error 50000

Just visit that actual Tinder WebApp its using the same API.Then look
into the request and then copy and curl and see whats different.
On Sun, Apr 12, 2020 at 9:00 PM ec<EMAIL_ADDRESS>wrote:

what happens when your curl the request?
… <#m_-4079900996908870659_>
On Sun, Apr 12, 2020 at 6:50 PM ec @.***> wrote: I wrote exactly the
same headers, however It didn't work for me. Any suggestions? — You are
receiving this because you authored the thread. Reply to this email
directly, view it on GitHub <#82 (comment)
https://github.com/fbessez/Tinder/issues/82#issuecomment-612688069>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AELAOW27FHDJAD5SVVKDL4LRMJAT5ANCNFSM4IMP423Q
.
It replies with code 400 and error 50000
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fbessez/Tinder/issues/82#issuecomment-612703652, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AELAOW3FC5FSCOXCADTOWXTRMJP4JANCNFSM4IMP423Q
.

Just visit that actual Tinder WebApp its using the same API.Then look into the request and then copy and curl and see whats different.
…
On Sun, Apr 12, 2020 at 9:00 PM ec @.> wrote: what happens when your curl the request? … <#m_-4079900996908870659_> On Sun, Apr 12, 2020 at 6:50 PM ec @.> wrote: I wrote exactly the same headers, however It didn't work for me. Any suggestions? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#82 (comment) <#82 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELAOW27FHDJAD5SVVKDL4LRMJAT5ANCNFSM4IMP423Q . It replies with code 400 and error 50000 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELAOW3FC5FSCOXCADTOWXTRMJP4JANCNFSM4IMP423Q .

I don't understand.

@DustinTheGreat Can you please help, It returns {'meta': {'status': 400}, 'error': {'code': 50000}} everytime, doesn't matter what I change.

send me your request
On Mon, Apr 13, 2020 at 6:29 AM ec<EMAIL_ADDRESS>wrote:

@DustinTheGreat https://github.com/DustinTheGreat Can you please help,
It returns {'meta': {'status': 400}, 'error': {'code': 50000}} everytime,
doesn't matter what I change.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fbessez/Tinder/issues/82#issuecomment-612845054, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AELAOW2AQEZOMRVMESMZGLTRMLSPBANCNFSM4IMP423Q
.

Just visit that actual Tinder WebApp its using the same API.Then look into the request and then copy and curl and see whats different.
…
On Sun, Apr 12, 2020 at 9:00 PM ec @.**> wrote: what happens when your curl the request? … <#m-4079900996908870659_> On Sun, Apr 12, 2020 at 6:50 PM ec @.**_> wrote: I wrote exactly the same headers, however It didn't work for me. Any suggestions? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#82 (comment) <#82 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELAOW27FHDJAD5SVVKDL4LRMJAT5ANCNFSM4IMP423Q . It replies with code 400 and error 50000 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELAOW3FC5FSCOXCADTOWXTRMJP4JANCNFSM4IMP423Q .

I don't understand.
And also, It was working perfectly 30 minutes before the problem occurred.
It returned this:
content-type: application/json; charset=UTF-8
content-length: 46
date: Mon, 13 Apr 2020 03:01:41 GMT
x-envoy-upstream-service-time: 11
x-request-id: 8addf4c7-6bf7-4d66-80ee-01655fd0da0b
x-cache: Error from cloudfront
via: 1.1 9349ae4f82564896b96f5303b030d189.cloudfront.net (CloudFront)
x-amz-cf-pop: ZRH50-C1
x-amz-cf-id: cDC_UxtV1s2O3aiphm4TU0G-wE3OgQzx7yqyMPkitoUCI6s_Rjw3rA==

if it was working and code stayed the same then you probably need a new token

I think if your Auth token is valid, You just need to pass the required parameters to the matches url i.e
r = requests.get('https://api.gotinder.com/v2/matches?count=50', headers=headers)


DRP Bad Pixel Recheck

Is your feature request related to a problem? Please describe.
Just wanted to document the email discussion from a while back concerning what was on the old FDD so that it isn't forgotten:  "Run additional recheck post-correction to see if any of the bad pixels from cosmic-ray flagging are no longer bad–e.g. warm pixels that were well-subtracted."  This is currently not implemented in the DRP and is supposed to be removed from the FDD (if it hasn't been already).
Describe the solution you'd like
Email discussion:
Kevin:
"Interesting thought.  The cosmic masking is designed to statistically exclude these one-off warm or hot pixels because it applies a median filter, meaning in a given row, a cosmic is only flagged if the median of n pixels in a row meet the chosen cosmic threshold value, and the case of n>1 excludes one-off warm pixels that may have been below the threshold used to calibrate the bad-pixel map, which is supposed to catch hot pixels.  However, with the TVAC data that was taken for obtaining noise maps for CIC, FPN, and dark current, I had to choose n=1 to remove all traces of cosmic rays on the noise maps, regardless of how low my chosen cosmic threshold value was.  (And perhaps there are warm pixels in a region that may beat a n>1 filter length anyways?)
My gut tells me this scenario where a warm pixel not caught by the bad-pixel map that pushes the corresponding pixel in a non-dark frame over the cosmic masking threshold is unlikely, but it is theoretically possible.  Plus I haven't actually examined actual data post-dark-subtraction for residual cosmic rays to know how "likely" this scenario is, and I'd rather be over-rigorous than under-rigorous.
From cosmic masking to dark subtraction, we have these steps:
-cosmic mask made
-nonlinearity correction
-convert from DN to e-
-divide by EM gain
-subtract master dark (which has already been EM gain-divided and is in e-, and the frames used to construct it were cosmic-corrected)
If we did the post-dark-subtraction check, the nonlinearity correction would change the effective cosmic threshold value per pixel relative to what was used originally in the cosmic masking function, so I would rather see this check done in the cosmic masking function itself.  We could do this check in the following way:

Take the master dark (in e- by default) corresponding to the given exposure time and EM gain for the frame at hand, and convert it to DN and multiply by EM gain.
Then apply the inverse of nonlinearity correction to that master dark since the cosmic masking function happens before nonlinearity correction (and it should).  The nonlinearity correction step function does an interpolation on the nonlinearity table, so an interpolation can be done to find the inverse map.
Then subtract that modified master dark from the frame at hand and perform the cosmic masking algorithm on the resulting frame."

Vanessa:
"My take aways for R3.0.1 are (and please let me know if you all disagree) …
Implementing a second BP check as written in the TDD FDD is not advised; we need to update the FDD.  It’s possible that by reordering L1/l2a/l2b calibration steps, we might produce a cleaner l2b image. However, we don’t have evidence that an improvement is necessary now, and we don’t know how much the improvement might be. My proposed course of action is to file this away in the “ideas to research later” category (for R3.1 or later), and simply update the TDD FDD to remove the 2nd round of BP checks.  I plan to prepare the FDD change request after I return from vacation.
My other take away is that we may want to use different default settings for cosmic ray removal for noise calibration data than for regular observation data. But the underlying CR algorithm could stay the same" ...
...since the keyword arguments in the CR algorithm can be tuned as needed.
Additional context
Low priority; just documenting this

For what it's worth, @nasavbailey's action was completed and this was removed from the TDD FDD in ECR 224639.

Thanks for documenting that, @ecady-jpl . I suggest labeling this as a "won't fix" and closing the issue. It could be re-opened if we find evidence in the future that it's needed.

marking as "won't fix" and closing the issue


Possible typo in type inference

From https://github.com/dotnet/csharpstandard/blob/draft-v7/standard/expressions.md#12632-the-first-phase, after an introduction which sets the scene with:
Tₑ M<X₁...Xᵥ>(T₁ p₁ ... Tₓ pₓ)

we have this text:

For each of the method arguments Eᵢ:

If Eᵢ is an anonymous function, an explicit parameter type inference (§<IP_ADDRESS>) is made from Eᵢ to Tᵢ
Otherwise, if Eᵢ has a type U and xᵢ is a value parameter (§<IP_ADDRESS>) then a lower-bound inference (§<IP_ADDRESS>) is made from U to Tᵢ.
Otherwise, if Eᵢ has a type U and xᵢ is a reference (§<IP_ADDRESS>) or output (§<IP_ADDRESS>) parameter then an exact inference (§<IP_ADDRESS>) is made from U to Tᵢ.
Otherwise, no inference is made for this argument.

Should the xᵢ in the second and third bullets be pᵢ?
I'll probably just create a PR for this, but it was easier to file an issue to start with...

Well a parameter has the grammar:

attributes? parameter_modifier? type identifier default_argument?

Matching Tₑ M<X₁...Xᵥ>(T₁ p₁ ... Tₓ pₓ) to this the Tᵢ are the type and pᵢ the identifier. Neither of these determine whether the parameter is value or reference parameter, that is down to the parameter_modifier. So it seems the writer is using xᵢ as the whole parameter spec but does not define it as such, so the xᵢ are neither pᵢ or Tᵢ…
We could try:

Otherwise, if Eᵢ has a type U and the ith parameter is a value parameter (§<IP_ADDRESS>) then a lower-bound inference (§<IP_ADDRESS>) is made from U to Tᵢ.
Otherwise, if Eᵢ has a type U and the ith parameter is a reference (§<IP_ADDRESS>) or output (§<IP_ADDRESS>) parameter then an exact inference (§<IP_ADDRESS>) is made from U to Tᵢ.

Which skirts introducing another letter and requires HTML <sup> tags to the source :-)

Fixed in #975


Add Dublin location

This year we want to organize the GDCR in Dublin for the first time so I added the location.

Welcome @gabrielmoral , have a good one! 💯


Partial reading of CSV file results in RuntimeError

Sample code:
import asyncio
import aiocsv
import aiofiles

async def main():
    async with aiofiles.open('/tmp/test.csv', mode='w', encoding='utf-8', newline='') as fobj:
        writer = aiocsv.AsyncDictWriter(fobj, fieldnames=['foo', 'bar'])
        await writer.writeheader()
        await writer.writerow({'foo': '1', 'bar': '1'})
        await writer.writerow({'foo': '2', 'bar': '2'})
        await writer.writerow({'foo': '3', 'bar': '3'})

    async with aiofiles.open('/tmp/test.csv', mode='r', encoding='utf-8', newline='') as fobj:
        row = aiocsv.AsyncReader(fobj)
        print(await anext(row))  # I want to read header only

asyncio.run(main(), debug=True)

Output:
['foo', 'bar']
unhandled exception during asyncio.run() shutdown
task: <Task finished name='Task-2' coro=<<async_generator_athrow without __name__>()> exception=RuntimeError("can't send non-None value to a just-started coroutine") created at /usr/lib/python3.10/asyncio/events.py:80>
RuntimeError: can't send non-None value to a just-started coroutine

This is an issue with Cython 0.29.*. I have regenerated the parser code with 3.0.0b2, seems to be fixed in 1.2.4.


[C API] Multiple probe batches in a simulator can cause pathing simulation exception

Adding multiple probe batches to a simulator, and later running iplSimulatorRunPathing(...) sometimes causes an access violation exception.
I'm not sure if this requires the probe batches to overlap or not, but adding the same probe batch twice to the scene is an easy way to reproduce the exception (at least in my scenario). Once multiple pathing probe batches are added to a scene, it can crash almost instantly once the simulation starts, or once the listener has moved to a certain spot in the scene. This same spot can be later used to trigger the exception again.
This issue stops you from being able to dynamically load & unload probe batches in a scene, as you might hit the unknown conditions for the exception. Instead, all probes in a scene have to be loaded in a single batch, no matter how big the scene.
I'm using a custom C-API integration, with baked pathing only. If the developers are unable to duplicate this exception, I can try to prepare some data for testing.

Crashes also happen with only a single probe batch. This might have something to do with overlapping probes, or probes with too big reach, or a combination of both. I'm able to reproduce the crash pretty consistently, and it tends to happen with the listener in a similar spot each time.
With the inclusion of the debugging symbols (thank you for those!), I'm at least able to point out the offending call stack:

@lakulish, the bot reconfiguration is reaaally needed. E.g., it can be configured to not close issues marked with some label and/or opened by the repository committers (from Valve)


No option to refetch song from newgrounds.

If a song was replaced with a nong, there should be an option to download it from newgrounds and make that the default again.

so basically "delete" the default song and allow a redownload?

Yes.
On Wed, Mar 13, 2024 at 4:38 PM Fleeym @.***> wrote:

so basically "delete" the default song and allow a redownload?
—
Reply to this email directly, view it on GitHub
https://github.com/Fleeym/jukebox/issues/26#issuecomment-1995722607, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ATTCB2N7FFT4RHQ5JEUJ6SLYYC2MTAVCNFSM6AAAAABETKOLYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJVG4ZDENRQG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I implemented this a while ago, closing.


create_keystore-#{instance} needs to start service[#{instance}]

the recipe creates a service under the variable name #{instance} -- which might be the string 'tomcat' but often isn't. This change causes the service name used for the restart after generating a key to match the name of the service created but the recipe.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

Merging under the obvious fix policy


Add checks for invalid URLs in orchestra

This is the orchestra side fixes related to: https://github.com/measurement-kit/measurement-kit/issues/1685

This is now deployed on https://orchestrate.ooni.io/


fix code examples in readme

Just updated the code examples to use sync when appropriate and I removed the [] brackets from the load() methods because I believe that loadPath is required, not optional.

@davidtheclark Do you think we should do a patch release to update the documentation on npm?

Sure, @sudo-suhas 👍

Released<EMAIL_ADDRESS>:tada:


pkg_rpm to pkg_tar contains duplicated rpm files

I noticed inconsistent behaviour when we feed pkg_deb and pkg_rpm to pkg_tar:

pkg_deb to pkg_tar contains only a single file that matches package_file_name attribute
pkg_rpm to pkg_tar contains two files in tarball: one named after the rule, the other one that is named after package_file_name

While putting a single tarball may not have much sense, there are use-cases where one need to ship additional files along with deb/rpm package (i.e. instructions). My initial thought was the difference is lack of OutputGroupInfo in pkg_rpm, but I think the problem is DefaultInfo.files return value. pkg_deb returns only the output file, while pkg_rpm contains two output files:  the default output file and output file.
Minimum reproducible example:
# //tests/deb_rpm_tar/BUILD
load("//pkg:deb.bzl", "pkg_deb")
load("//pkg:tar.bzl", "pkg_tar")
load("//pkg:rpm.bzl", "pkg_rpm")
load("//pkg:mappings.bzl", "pkg_files")

genrule(
    name = "gen_foo",
    outs = ["usr/bin/foo"],
    cmd = "touch $@",
)

pkg_tar(
    name = "deb_input",
    srcs = [":gen_foo"],
)

pkg_deb(
    name = "test_deb",
    data = ":deb_input",
    description = "Some package",
    maintainer =<EMAIL_ADDRESS>    package = "debpackage",
    package_file_name = "debpackage-0.0.0.deb",
    version = "0.0.0",
)

pkg_tar(
    name = "deb_tar",
    srcs = [":test_deb"],
)

pkg_files(
    name = "rpm_input",
    srcs = [":gen_foo"],
)

pkg_rpm(
    name = "test_rpm",
    srcs = [":rpm_input"],
    description = "Description",
    license = "Apache 2.0",
    package_file_name = "rpmpackage-0.0.0-0.rpm",
    release = "1",
    summary = "Summary",
    version = "0.0.0",
)

pkg_tar(
    name = "rpm_tar",
    srcs = [":test_rpm"],
)

$ tar tvf bazel-out/k8-fastbuild/bin/tests/deb_rpm_tar/deb_tar.tar
-r-xr-xr-x 0/0           10662 2000-01-01 00:00 debpackage-0.0.0.deb
$ tar tvf bazel-out/k8-fastbuild/bin/tests/deb_rpm_tar/rpm_tar.tar
-r-xr-xr-x 0/0            6254 2000-01-01 00:00 rpmpackage-0.0.0-1.rpm
-r-xr-xr-x 0/0            6254 2000-01-01 00:00 test_rpm.rpm

I think the root cause is reallypackage_file_name = "rpmpackage-0.0.0-0.rpm".
That will give you an implicit output of a real file "rpmpackage-0.0.0-0.rpm"
and a default output of the symlink "test_rpm.rpm".   This is an intentional behavior:

the physical file has a name containing the right (possibly dynamically determined) version numbers
rules depending on the rule name can pick up the rpm at a well known name.

The same kind of thing happens for pkg_deb(). Anyone depending on just the name gets all output files.
If you need to get a specific single file, you can do the file_group+output_group redirection as seen here.
https://github.com/bazelbuild/rules_pkg/blob/edd4d3d643f01e6ac5cb529fc9d7e01dc8c9367e/examples/where_is_my_output/BUILD#L45
So in #684 you have the core of a correct change, except the tests don't test the right thing - the number of files is variable, not fixed. What it should be is that the expected output groups are created in particular situations.  That should be an analysis test or two. I can comment more about how do to that later. But now I ran out of time on rules_pkg for the week.

I think this is still inconsistent behaviour between pkg_deb and pkg_rpm rules. If the output should contain both package_file_name.rpm and symlink to rule_name.rpm, then the pkg_deb should be fixed to include the symlink as well - not just the package_file_name.deb. See the return value implementation here: https://github.com/bazelbuild/rules_pkg/blob/main/pkg/private/deb/deb.bzl#L168
That being said: can I piggy back it on #684 or do we want another change to address this?
As for the testing part I'll update my change to test it correctly.

I stand corrected. The DefaultInfo for the other rules is to have only the single file, not both.
Forget the tests, they should fold into the existing file naming tests and or be analysis tests.
Changing RPM to agree with the other rules should be a separate change.

Is this fixed by #684

Fixed in #692


[fix] Fix the  SERIAL_DISCARD execution_type not working

Purpose of the pull request
I found the SERIAL_DISCARD execution_type always stops the process instance, even if there were no running process instances.
After diving into the code, It seems like some logic error. Before the fix, the ProcessServiceImpl will stop the current process_instance, if running_instances is empty.
Now make some fixes, if running_instances is not empty, mark the current process_instance as stop (discard it). if running_instances is empty, submit the current process_instance.

Brief change log
fix SERIAL_DISCARD not working

Verify this pull request

Hi @SbloodyS
Already changed unit test. Please re-run ci workflows 🙏

Hi @SbloodyS
Already changed unit test. Please re-run ci workflows 🙏

I rerun it.

Codecov Report

Merging #10258 (2be97eb) into dev (4c1ef0a) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev   #10258      +/-   ##
============================================
- Coverage     41.25%   41.24%   -0.02%
+ Complexity     4760     4758       -2
============================================
  Files           854      854
  Lines         34579    34582       +3
  Branches       3821     3821
============================================
- Hits          14265    14262       -3
- Misses        18944    18948       +4
- Partials       1370     1372       +2

Impacted Files
Coverage Δ

...nscheduler/service/process/ProcessServiceImpl.java
30.62% <50.00%> (-0.08%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (-1.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1ef0a...2be97eb. Read the comment docs.

@caishunfeng Do you have time take a look?


Ignore file privately doesn't work when using worktrees

Description
When trying to ignore file privately in worktree which isn't the "main" one, Neogit fails on the assumption that .git/info/exclude exists, but that's not the case - this file exists only for the "main" instance
Neovim version
NVIM v0.10.2
Build type: RelWithDebInfo
LuaJIT 2.1.1731601260
Operating system and version
Arch linux (2024.11)
Steps to reproduce

Create repo
create new worktree
create some file
try to ignore it privately (ip in the Neogit UI)

Expected behavior
given file is ignored in the main worktree
Actual behavior
excepetion about no such file
Minimal config
-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit

125edf6fca5bed2ab8ecebfc3bc9b0b5968baeb4 fixes this :)


Rename COREModuleAddDef to COREModuleSetDef

Reflects change to Module API, python bindings should be updated as well

[x] coreir-c.{h,c}
[x] __init__.py

This should be fixed in dview commit https://github.com/rdaly525/coreir/commit/a197386b6d5eee11eea236d1d90a3a1b9a9bff72


Several calls of task_wdt_init starve the application as soon as a sleep is used

Description
When the watchdog task initialization is done multiple times (multiple calls to task_wdt_init) then a sleep is called after that, the application hangs.
The application hangs in change_cpu_state_and_wait (file /zephyr/scripts/native_simulator/common/src/nce.c) on line 158:

Before, we used Zephyr 3.5.0 and called task_wdt_init multiple times, where everything worked well. Now we wanted to update to Zephyr 3.6.0 and our code didn't work anymore. There the following commit was done in Zephyr where we think the issue comes from:
https://github.com/zephyrproject-rtos/zephyr/commit/fdea8518783a5d8c4421595341f8332ac5714167
For sure, it's not best practice to initialize the watchdog multiple times (multiple calls to task_wdt_init). We would expect that task_wdt_init would return an error in case of multiple calls (since this would have an influence on the running application).
Here is a sample project where we reproduced the bug:
multiple_calls_to_task_wdt_init.zip
How to Reproduce
Steps to reproduce the behavior:

build the attached multiple_calls_to_task_wdt_init project
Set breakpoints on the task_wdt_init calls.
If you passed the second task_wdt_init call. Run the application and do a stop after some time, then you will see, that during the sleep the code get stuck in change_cpu_state_and_wait.

Expected behavior
Either, multiple calls to task_wdt_init are possible, and the application will execute successful OR repeated calls to task_wdt_init will return an error.
Environment:

OS: Linux
Toolchain Zephyr SDK Version 0.16.5
Zephyr Version 3.6.0 as well as 3.7.0

Additional context
We solved the problem in our application by removing the second call to task_wdt_init. But the behavior is not really user-friendly like it's implemented.

CC @arbrauns

16fc8f5295cc666923dabfff9d268d8e16dd8259/#73699 might also be relevant. It's a weird error behaviour, but I don't think calling task_wdt_init multiple times is inteded behaviour, it should have a check and return -EBUSY or something.

16fc8f5/#73699 might also be relevant. It's a weird error behaviour, but I don't think calling task_wdt_init multiple times is inteded usage, it should have a check and return -EBUSY or something.

Yes, I completely agree.

@bfa8 Just as side info
What you see in that line you pointed at is just the HW models thread waiting for the CPU to go to sleep.
The CPU does not sleep in this case because there is an infinite loop in the systick timer interrupt handler calling into task_wdt_trigger() and that function setting the deadline again to the same instant.


Progress message stucks at "Initializing..." when opening a single .js(or .ts) file with typescript-language-server.

When I open a single .js file (which is not belonging to a project) like nvim index.js，the progress message always stucks at "Initializing...".

After I viewed the :LspLog, I found that typescript-language-server never send $/progress notifications (which is not mandatory according to the specification) in such simple cases, and since the plugin updates progress messages only when LspProgressUpdate event is triggered, the progress message stucks forever.

Yes, I've filed #12 to fix this issue. Until that issue is resolved you should place this server in the hide configuration list.
I should be able to deal with this over this coming weekend. Thanks for the report.

Hi, @BurningLutz . I believe this issue should be resolved. If you have placed tsserver in hide you should be able to remove it fro that and it should show 'initializing' followed by disappearing from the status line over the next few seconds (by default 3 seconds).

It works now :D, thanks!


Introduce AttributeRelay class

This pull request extracts common logic from the existing RangeAttributeRelay,  RegularExpressionAttributeRelay and StringLengthAttributeRelay classes to a new concrete class, called  AttributeRelay<T>. The existing classes are modified to reuse the new class in their implementations of the ISpecimenBuilder.Create method.
Motivation
Implementations of the ISpecimenBuilder.Create method in the three existing classes contain complex logic for finding custom attributes applied to a code element (a parameter, a property, etc), creating a relayed request based on a well-known attribute and resolving it from the ISpecimenContext. Most of this logic does not depend on the specific attribute type or the code element to which it is applied and thus could be reused by the existing classes.
The new AttributeRelay<T> class can also be reused by the SubstituteAttribute, which was previously submitted in pull request #421 and will be re-submitted in a separate, smaller pull request. The SubstituteAttribute is a major motivation for this refactoring, because without the AttributeRelay<T>, one would need to create yet another copy of the attribute relay boilerplate code, brining the total number of nearly identical copies to 4. The effort required to extract existing duplicate logic into a reusable component is comparable to re-implementing another copy, but unlike the latter, it reduces the overall amount of code in AutoFixture and improves test coverage.
Usage
In addition to using AttributeRelay<T> when implementing the ISpecimenBuilder.Create method, the new class could also be used directly, without the need to introduce a separate ISpecimenBuilder class. Here is an example of how it could be used to support the upcoming SubstituteAttribute.
public class AutoSubstituteCustomization : ICustomization
{
  public void Customize(IFixture fixture)
  {
    // ...
    fixture.Customizations.Insert(0, new AttributeRelay<SubstituteAttribute>(SubstituteRequest.Create));
  }
}

public class SubstituteRequest
{
  public static object Create(ICustomAttributeProvider codeElement, SubstituteAttribute attribute)
  {
    return new SubstituteRequest(/* ... */);
  }
}

Out of scope
The following changes may be worth considering in the future. They were not included in this pull request to keep it small and speed up the code review.

Moving the private CreateRelayedRequest method from the existing AttributeRelay classes to their respective Request classes and making them public would allow to significantly simplify tests. Because these methods are private today, testing them requires stubbing and mocking the ISpecimenBuilder and ISpecimenContext interfaces. Simply making them public in the Relay classes would feel like exposing internal implementation details. However, if they were defined on the respective Request classes, they would be fairly typical factory methods and making them public would be natural.
Eliminating the existing AttributeRelay classes and using the new AttributeRelay<T> directly would help to reduce the amount of product and test code. With ISpecimenBuilder.Create implemented by the AttributeRelay<T> and the CreateRelayedRequest methods moved to their respective Request classes, the existing AttributeRelay classes would become empty shells with 2 lines of code(excluding declarations) per class, but still require a significant amount of test infrastructure. This would constitute a breaking change and have to wait until v4.

I agree that creating a new type can be considered as added cost from the standpoint of maintaining existing code. However, it's absence also adds cost from the standpoint of creating new "auto" attributes.
I may not be a typical user of AutoFixture, but here is my specific scenario.

I want to use AutoFixture and NSubstitute in one of my projects.
I feel that using the Fixture class directly in my tests makes them more obscure, so I prefer using the [Theory] and [AutoData] attributes
This approach doesn't allow me get partial substitutes for non-abstract classes I want to use as SUT and test doubles in my tests.
I want to have a [Substitute] attribute that I can apply to parameters in my tests to force creation of a partial substitute instead of a regular instance of a non-abstract class.
I look at the AutoFixture code and find three separate existing examples of attribute-based relays.
I could create another copy of the relay code, but it's about the same size as the actual feature code I'd need to write to support partial substitutes. I'd rather not write, test and maintain a separate copy of the boilerplate code.

I included a code example of how I'd want to use the AttributeRelay<T> is in the Usage section of this pull request. Without it, I'd have to write about 50 lines of product and 100 lines test code instead of about 1 and 10 lines respectively. These are total lines, including declarations and comments, but I'd still rather write fewer of them.
Code reuse is important to me in this case because I would prefer using specific attributes instead of global test conventions to keep my test fixtures minimal, so I expect I'll need more attributes like [Substitute]. If that assumption turns out to be wrong and AttributeRelay<T> is used only with these 4 attributes, the cost of maintaining it will be no different than maintaining 4 separate copies of attribute relay logic, because this code hasn't changed since 2012 so there is no reason to expect that it will have to in the future.

IIRC, RangeAttributeRelay, RegularExpressionAttributeRelay, and StringLengthAttributeRelay, didn't introduce an AttributeRelay<T> for the exact reason that @ploeh described:

The proposed AttributeRelay<TAttribute> may benefit the developers of AutoFixture, but does it benefit the users?

@olegsych, wouldn't it be possible to define an AttributeRelay<T> outside the AutoFixture codebase?

Technically? Yes. However, what I really need is a SubstituteAttribute in Ploeh.AutoFixture.NSubstitute (#132, #421). It could use the AttributeRelay<T> as described in the Usage section of this PR or introduce a new SubstituteAttributeRelay class, essentially a copy & paste of the RegularExpressionAttributeRelay product and test code. Do you see the latter as the better option?

Yes, it can be a lot easier with a hypothetical SubstituteAttributeRelay class. @ploeh do you also agree?

An open source library like AutoFixture is different than the software most people write. Most people I've met write some sort of software where they control the environment in which it's running: web sites, intranet apps, web services, microservices, etc. In such environments, the cost of making a mistake in the public (C#) API isn't too big, because you can just fix the mistake by changing the API again and redeploy the software.
This becomes even more pronounced the more towards Continuous Deployment you get.
Thus, in such environments, the cost of duplication tends to outweigh the cost of making an API design mistake.
On the other hand, when it comes to a library with an unknown body of users, the cost of making a mistake in the public API of the library is much bigger: you'll have to deal with it for years.
If we were considering removing duplication from an area of the code base where we'd seen a lot of bugs, I'd be more ready to accept that the duplication should be addressed. In this case, though, there's no evidence that the duplication is costly, so I don't think the added complexity introduced in this pull request is warranted.
For this reason, I'm sorry to decline the pull request.

I understand. Are you still open to the introduction of the SubstituteAttribute, which is the other half of the original pull request #421?

Where would you put such an attribute?

I would implement the SubstituteAttribute in the Ploeh.AutoFixture.NSubstitute assembly. Please see #421 for details.

Ah, OK, for a moment I though you had in mind deriving from CustomizeAttribute from AutoFixture.Xunit, but I now understand that that's not the case.
Go for it :+1:


Make text < 1.3 instead of 1.2

Please make a release afterwards :) Thanks!

@jfischoff hi! Could you please make a hackage release of file-command-qq with this change? Since that was the main intent, basically. Thanks!

I should be able to do it tomorrow. I just moved across the country so I have been busy.

Done

Thank you!


Graphics.show + Signal not working in Firefox

This seems like a bug to me in Elm core.
http://share-elm.com/sprout/5626bc20e4b0966c193ddb6f
import Graphics.Element exposing (..)
import Keyboard
import Char

characters : Signal Char
characters =
  Signal.map Char.fromCode Keyboard.presses

main : Signal Element
main =
  Signal.map show characters

This works fine in Chrome, but in Firefox it only shows the initial value. Tested in Firefox 41.

I'm closing this as a duplicate of https://github.com/elm-lang/core/issues/326.
Please always look through existing issues first before opening a new one.
In this case, just using GitHub's issue search feature on the core repo with search phrase "Keyboard.presses" would have directly led you to the pre-existing issue.


Add license to the repository

Add Apache-2.0 license file to the repository.

Thanks for your advice, Sarah. I have just added the license file.


Calendar isn't interactive on ID4

Split from #279, @masteralarm reports that the Calendar app is not interactive in their ID4 BMW.
screenshot missing a selection cursor
calendar logcat
videos of official BMW calendars functioning

I have the same problem here with the latest play store release (1.3.2 22.01.2022).
It is not possible to select anything in the calendar app.:

Thank you for the assistance and patience!
I peeked in a network trace to see if there was anything I'm missing, and I only saw one missing setData that seemed to be unnecessary in my ID5+ car but might be needed in ID4.
Please try out this build from this branch and see if it helps!

Hi,
ok great. I'll try it out and report back.
Thank you

Good find, @hufman!
The date selection seems to be working now 👍
Unfortunatly, when opening a date, no appointments are shown (just the default message "No appointments available"). In the app, my appointments are visible. Checked it with different calendars.

Hmmm that's very interesting! I see that it does update the title of the DayView with the selected date, and so it should be using the same logic to find events in that day as finding the events to highlight each day in the month view.
Thank you for the testing and patience!

That little fix has made it to the Play Store release, can anyone else with ID4 confirm if it helped them, and whether the Day View shows any information?

Can you try this debug build which enables some extra logging to Logcat? You should find some interesting logcat lines with the tag CalendarApp from when you navigate through the car's Calendar screens, and there should be stdout lines showing extra calendar search details (the changes show the expected output). I'd be curious if there are any clues there!

I tested the debug version but could not find anything unusual in the logs.
Anything in particular I should look for?
The most interesting location should be this, I suppose:
https://github.com/BimmerGestalt/AAIdrive/blob/49b9a193d71143199f4472133cf4c868ff3a36b8/app/src/main/java/me/hufman/androidautoidrive/carapp/calendar/views/CalendarDayView.kt#L79
But according to the logs, AAI finds the correct calendar entries. Could there be a problem with how the return value of the update() function is used? Or perhaps the data send to the car need to be structured differently for ID4?

Thank you for testing! Do you see the Log.i() calls in that function, in particular found ${events.size} that match the selected DayOfMonth with a non-zero found events.size?
That function doesn't return anything, it sends the data directly to the car here. If it does appear to be getting there, then something in the format must be wrong, indeed. In my car, even with invalid data, it would at least show the events all starting at midnight, but hmmmm!

Please try the latest build: It uses a slightly more correct method (which matches what is used by BMW Calendar) to attach the icon ID to each day's appointment, which ID4 might require. There's also a lot of code in BMW Calendar to ensure that the day's appointments do not overlap, so try checking in any days with a single event as a base test.

Great work, @hufman! Thank you!
Calendar entries can now be successfully viewed.
But the view itself is different from the Connected and Connected Classic apps.
I will post a video of the behaviour as soon as possible.


Preferred quote character fails

Adding a single quotation mark in the settings for "preferred quote character" does not remove the warnings that single quotes should be double quotes.

@DonSanto Do you have more details (screenshot, error message, etc) for this? It sounds like this is coming from a linter, and not from atom-typescript.

@blakeembrey Thanks, nice one. Indeed it was a linter issue. linter-tslint seams to not approve single quotes characters.

There's a configuration option for that in tslint. Take a look at the README (https://github.com/palantir/tslint) and usage (https://github.com/typings/cli/blob/master/tslint.json#L72).

I'm seeing this in 10.1.7 using typescript 2.0.3 installed globally.


Add periodic messages

A channel admin should be able to set a period message to be sent every N minutes.
/periodic [N minutes] My message

Discontinue
/periodicstop

A secondary request for this was adding CTA buttons.  This may need to be split off into a separate issue.

This is pretty straight forward for simple messages, but adding the CTA is a little... weird.  It would probably need to be a secondary command entirely.  That would require something like this to assemble the whole message:
/periodic 60 OUSD is cool and you should check it out!
/periodic_cta https://ousd.com Buy OUSD!


Single-use, non-recursive common table expressions (CTEs) - WITH clause

Background: https://airtable.com/tblD3oZPLJgGhCmch/viwINAgXA5on9pr2T/reclGbRZtI6TME4JT
RFC: https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/20171206_single_use_common_table_expressions.md
PRs:

sql: single-use common table expression support

If that's OK, I'd like to take this over and complement #2762 with this new feature. Does this work for you?

@knz - that's fine with me, as long as @jseldess is ok with it. i haven't started writing anything yet, but have been getting familiar with the topic so i can be the reviewer on this. @jseldess, is that ok? if so, i can take over a different topic.

Fine with me, too. Thanks, @knz!
@lhirata, let's sync on another 2.0 project you can help with.


Support ignoring API versions of more ResourceManager resources when used as test dependencies

Ignore the api-version of the operation to query resource providers in ManagementRecordedTestBase.
Ignore the api-version of the TagNames and TagValues operations in SubscriptionManagementTestBase as they are only used in the Subscription SDK.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


how to use destroy method?

Destroy method was not in the documentation of this plugin.
I checked the js code and I found that there is a destroy method but, how can I use it? I already tried this though "$('#mytbl').jexcel('destroy')" but no luck.
Hope you can help me with this.

https://bossanova.uk/jexcel/docs/how-it-works (second topic).
$('#my').jexcel('destroy'); is correct. Please, bear in mind to update your repository from master.


Avoid flickering on light turn on with a configurable delay

I've found that often, when Adaptive Lights is enabled, my lights will flicker when turning on, rather than the smooth fade in transition they would normally have. This seems to be caused by Adaptive Lights trying to update the light state as soon as possible when it detects the lights coming on, resulting it in adapting the lights before the fade in transition completes, causing it to reset half of the way through, and thus making a visual flicker.
To work around this issue, I've added and option to have Adaptive Lights wait a configurable amount of time between light on and when the lights are actually adapted. This gives the lights time to do their normal fade in transition, and then adaptive lights can apply its changes as needed after the lights are fully turned on.
This of course means that Adaptive Lights will be less responsive to turn on events, so it is set to no delay by default.
Let me know if there is a better way to solve this problem other than what I've done here, and I will update this PR accordingly. This is mostly a quick hack I threw together, so it might not be ideal.

This blended with Issue 255 would reduce this problem, at least for automation that are turning on your lights.
https://github.com/basnijholt/adaptive-lighting/issues/255

@MangoScango, sorry for the delay in reviewing and merging this. Thanks a lot for your contribution!


Country code ignored when specifying location and PNG format.

I live near Newmarket, UK. The geolocation works fine, unless I want an image. wttr.in/.png puts me in Germany. But that's another issue.
This one is for noting that wttr.in/newmarket gives me info for Newmarket, Canada. wttr.in/newmarket_uk correctly gives me info Newmarket, UK. The problem is that wttr.in/newmarket_uk.png gives me results for Canada again, ignoring the country specifier part of the request.

Looks like parse_wttrin_png_name() in wttrin_png.py is splitting by underscores. As per the README.md, options are specified after the first underscore, not country codes. For PNG images, if I specify the location with some other character (eg. '-' or '+'), it works fine: wttr.in/newmarket-uk.png.
I can still specify options with underscore.

Exactly. You can also use , for that. Also, you can use enhanced location resolution method (specify ~ in front of the location name):
wget https://wttr.in/~newmarket,uk.png

In this case, you will get exact location information in the footer (below the forecast).


Improve rabbit.auth_backends documentation

E.g. it surely should be explained well in the Access Control document. See this mailing list thread, for instance. There are similar ones, people are confused by the docs we have.

Pushed live, still not entirely satisfied with it but it is already a significant step in the right direction.


Proposal: reusing context basic auth result in git http implementation

current basic auth flow
In the current implementation, when cloning/committing private repo over http/https using basic auth header, for each request, Gitea tries the following workflow

treating basic auth token as password and attempting to sign in user when creating context in middleware (modules/context/context.go).

treating basic auth token as password and attempting to sign in user AGAIN in routers/repo/http.go

validating it as token and verifying access to repo.

Each sign in operation involves hashing provided token and comparing it with the record retrieved from db. These are two wasted cycles in each request to perform git operations on private repo over http/https.
The proposed basic auth workflow
If basic auth header is present, in context middleware, we will first attempt to validate the header as application token, then treat it as password. we can set a flag in ctx.Data to indicate whether it is plain text password. The decision can be made in routers whether to accept/reject auth by plain text password using the current logic.
If a valid token is provided (for example when Drone clones a private repo using token from a netrc file), then there will only be one validation cycle needed.
The reason behind is that there are potentially more git operations over http than login requests from users.
In order to keep existing integration with Drone, we will look for token both in username and password, using the same logic as it is done now.
Are there any concerns to this approach?

I'm in favour of removing duplicate DB calls, however I think that the concern of token vs basic in regards to performance of hashing can be dismissed due to the other ticket of potentialy hashing tokens too. Please let me know if I understood your proposal correctly as I am in a timezone that is ~10hours different from mine and may be a touch jetlagged.

@techknowlogick Thanks for the prompt response. I was not referring to hashing token. I meant a token in basic auth header should first be treated as token instead of a password. It is far more common to have a token in basic auth header in daily operations. Taking the default Drone integration for example, a user may log into to Drone once in a while using Gitea password, but every build will trigger a cloning request using access token from netrc file.
The current  basic auth flow is barking at the wrong tree when Drone provides a valid token for cloning private repo. It assumes the token is a password, tries to sign in user and fails. Then it tries to sign in user again and fails again. Then it finally gets smarter, treating a token as a token, and succeeds. This happens to every valid cloning request, no matter token is hashed or not.
I am proposing to validate basic auth header content as token first, then validate it as a password if it is not a token. We can do this in one go in context module, save the result in context, and apply the accept/reject logic in routers. what do you think?


[Unity][Relax] Add global symbol to PrimFuncs introduced by in-place transformation

This is a temporary fix that assigns a global symbol to PrimFuncs introduced by the in-place transformation. The issue this addresses is that FuseTIR currently removes all PrimFuncs that are not marked public other than those that can be handled in fusion. The permanent solution to this issue would be to handle these PrimFuncs in FuseTIR and FuseOps, which I am planning to attempt, but that should not be a blocker on using in-place PrimFuncs with those passes (which are part of the compilation pipeline).

Would it be easier to fix the underlying issue in FuseTIR?  It looks like it should be doable by having this loop maintain a copy of every function in funcs_to_keep, rather than a subset, then adding DeadCodeElimination() to this list of passes.  That way, FuseTIR keeps around all the original unfused functions, and it gets cleaned up by the dedicated pass afterwards.

I'm working on getting fusion for in-place cases working in PrimFuncs. These PrimFuncs will not be dead code either, since they will actually be called in the final program. I'll see if it will be just as easy as putting them in the funcs_to_keep set, though.

Now this checks for the in-place calls in FuseTIR (only temporary, I hope, as I plan to handle fusion for in-place PrimFuncs correctly soon). We can decide which way we prefer.

No longer necessary thanks to 16487


Windows File Path Fix

This fix allows for a windows machine to build the adapter and for it to run properly on non-windows servers which the majority of cloud systems run as.
I tested this locally on my windows machine and it worked with build, preview, and serverless deploy and they all worked fine.
I understand if no one else cares for this, my own plan is to use CICD for my deployments and that would be from a linux VM of some sort but at least for now this would help me and possibly others.
Related issue: https://github.com/yarbsemaj/sveltekit-adapter-lambda/issues/12

Hi @nboehret Thank You for your interest in my project! Iv reviewed your PR and think there may be a cleaner way of going about what your trying to do. Could you take a look and see if my suggestions work. :)

@yarbsemaj You were right! I was looking for something like this but I missed it originally, thank you. This is much simpler and cleaner, imo. Let me know what you think.

@yarbsemaj any chance we could get a new release?


docs example error

Hi am using pex latest version on python 3.7.
I tried running your example  pex sphinx sphinx_rtd_theme -c sphinx -o sphinx.pex.
The result I get is: pex.pex_builder.InvalidExecutableSpecification: Could not find script 'sphinx' in any distribution...

Thanks for pointing this out @assafgi. I finally got around to see this and the example, as well as others, are now updated and fixed. A preview of the fixed docs are here: https://jsirois.github.io/pex/buildingpex.html.  The next Pex release, which should happen before the end of this week, will contain those updates at https://docs.pex-tool.org/buildingpex.html.


Fix step order and num classes

Fix coffee recipe order to match
https://docs.google.com/document/d/1jkF9Nht_-I6RFqJNLoEujPNkBzPY52jhKQqn4aCi9vY/edit#heading=h.maomtoit1ceh
Also has a few step name changes to match the activity detector label names. Tested this version of the task monitor with the latest activity detector and was able to step through the whole recipe by hacking the activity detector predictions a bit...

@Purg, where should I put the labels file I used? I feel like that should be checked in somewhere since it's tied so closely to the task monitor right now.

@Purg, where should I put the labels file I used? I feel like that should be checked in somewhere since it's tied so closely to the task monitor right now.

I'm not sure tightly coupling the activity model label list (which is activity detector implementation-specific) to the task monitor. Maybe we have this task monitor read in a config file (let's say, JSON) that maps detector labels to task steps indices. The content of the configuration file will be detector model specific and coffee task specific, but will at least be a configuration file that we can change.

@Purg, where should I put the labels file I used? I feel like that should be checked in somewhere since it's tied so closely to the task monitor right now.

I'm not sure tightly coupling the activity model label list (which is activity detector implementation-specific) to the task monitor. Maybe we have this task monitor read in a config file (let's say, JSON) that maps detector labels to task steps indices. The content of the configuration file will be detector model specific and coffee task specific, but will at least be a configuration file that we can change.

Ok, I added in a config file with the mapping from activities to step index. I also found a way with the transitions package to advance to the next step without needing the to_state and activity_action dicts with the trigger function, so that's why I removed those dictionaries. I tested it on my end and it looks OK (both timer steps and regular steps).


Update to clang-format-16

It has been a while since we updated the clang-format style. This PR adds the rules added to clang-format since the last overhaul and removes those which are deprecated. I tried to follow the existing (manual) alpaka style where possible but we should vote on the changes.
New rules (value after name = current proposed setting):

AlignArrayOfStructures (Left) - Link
BreakAfterAttributes (Never) - Link
BreakBeforeConceptDeclarations (Always) - Link
BreakBeforeInlineASMColon (Always) - Link
EmptyLineAfterAccessModifier (Never) - Link
EmptyLineBeforeAccessModifier (Always) - Link
IndentAccessModifiers (false) - Link
IndentRequiresClause (false) - Link
InsertBraces (true) - Link
InsertNewlineAtEOF (true) - Link
IntegerLiteralSeparator (Binary: 4, Decimal: 3, Hex: 4) - Link
LambdaBodyIndentation (Signature) - Link
PenaltyBreakOpenParentheses (2) - Link
PenaltyIndentedWhitespace (2) - Link
PPIndentWidth (-1) - Link
QualifierAlignment (Custom) - Link
QualifierOrder (['friend', 'inline', 'static', 'constexpr', 'type', 'const', 'volatile', 'restrict']) - Link
ReferenceAlignment (Pointer) - Link
RemoveBracesLLVM (false) - Link
RemoveSemicolon (true) - Link
RequiresClausePosition (WithPreceding) - Link
RequiresExpressionIndentation (Keyword) - Link
ShortNamespaceLines (0) - Link
SeparateDefinitionBlocks (Always) - Link
SpaceAroundPointerQualifiers (Default) - Link
SpaceBeforeSquareBrackets (false) - Link
SpacesInLineCommentPrefix (Minimum: 1, Maximum: -1) - Link

Replacements:

AlignTrailingComments (Never) - replaces old-style AlignTrailingComments (false) - Link
LineEnding (DeriveLF) - replaces DeriveLineEnding - Link
PackConstructorInitializers (CurrentLine) - replaces AllowAllConstructorInitializersOnNextLine and ConstructorInitializerAllOnOneLineOrOnePerLine - Link

New project-specific options:

AttributeMacros - Link
IfMacros - Link
WhitespaceSensitiveMacros - Link

BreakBeforeInlineASMColon: I would go with Never or OnlyMultiline until we find a problem.
InsertBraces: I am super strongly against this one, because it just creates textual noise. Even worse, because alpaka already places each brace on a separate line.
IntegerLiteralSeparator: that's a fun one. I am curious how this will turn out.
PenaltyBreakOpenParentheses and PenaltyIndentedWhitespace: how do you come up with these numbers? why not just leave the defaults?
PPIndentWidth: again, just leave the default (which is -1).
RemoveBracesLLVM: as much as would like to see this as true, I know that older nvcc versions sometimes have parse errors when braces are missing on the else branch of an if constexpr.
RequiresExpressionIndentation: I am leaning towards OuterScope here

BreakBeforeInlineASMColon: I would go with Never or OnlyMultiline until we find a problem.

I find inline ASM statements already hard to parse because we don't use them very often. Having them in multiple lines makes them easier to read IMO.

PenaltyBreakOpenParentheses and PenaltyIndentedWhitespace: how do you come up with these numbers? why not just leave the defaults?

It isn't documented what the default is here. I just used the value from PenaltyBreakAssignment since that seams to work well.

PPIndentWidth: again, just leave the default (which is -1).

Just making the default explicit here.

InsertBraces: I would prefer true. I had already the problem in the past, that I add a second line to a if body and forgot to add the braces. Have fun to find the strange behavior.

But only, if you integrated it in your IDE. No one is running clang-format manually after code change.

But only, if you integrated it in your IDE. No one is running clang-format manually after code change.

I actually do both. CLion formats while a type, but sometimes I also do changes inside the diff viewer, or from the command line, in which case I run git clang-format :)

I'm a bit conflicted on the brace issue. I dislike it for this:
if(cond)
    one_liner_expression;

but would want it for this:
while (i--)
  for (auto *A : D.attrs())
      handleAttr(A);

Unfortunately we cannot configure this beyond true or false so I'm slightly for inserting braces...

@j-stephan given the two examples you listed, inserting braces will

if(cond)
    one_liner_expression;

double the screen space required for this piece of code. And for

while (i--)
  for (auto *A : D.attrs())
      handleAttr(A);

We add even more noise, since we turn 3 lines to 7.

I am against adding braces for single-line expressions. I know that there is the possibility to introduce errors during refactoring but adding braces is easily adding many lines per file.

Okay. So we are leaning towards InsertBraces: false. If there are no other wishes by the majority I'll change the line and then go ahead and merge this PR.

BreakBeforeInlineASMColon: I am for OnlyMultiline
IntegerLiteralSeparator I do not like it or do not see why we need it.
RequiresExpressionIndentation' I am for OuterScopebecause the other option looks like an alignment and we decided in the past to indent always and never align but optionKEyword` is aligning with the keyword.

I made the following changes:

AlignArrayOfStructures: None - this is currently too buggy, especially in constructors
BreakBeforeInlineASMColon: OnlyMultiline
InsertBraces: false
IntegerDecimalSeparator: added DecimalMinDigits and set it to 7, otherwise this is too intrusive IMO
RequiresExpressionIndentation: OuterScope
RemoveSemicolon: false - detected false positives in alpaka which led to compilation failures
SortUsingDeclarations: Lexicographic instead of true (I guess the latter was deprecated at some point)
New project-specific options:

ForEachMacros - Link
NamespaceMacros: Link
StatementMacros: Link
TypenameMacros: Link


[Sprint: 53] XD-3218 Handle deployment status recalucation failures

If the admin fails to load the stream/job (mostly if the module registry isn't in sync)
when recalculating the deployment status, then set the stream/job deployment unit status
to unknown and logs error message
This way the admin leader election would still happen but the stream status will
notify the user to act on.

Merged as 845636657d485773382c1f4b6ce76ea639692000


net: app: Notify peers properly when DTLS connection is closed

The peers were not informed about DTLS connection close because
we removed DTLS context. The fix is to notify peers before we
remove the DTLS connection.
Fixes #8605
Signed-off-by: Jukka Rissanen<EMAIL_ADDRESS>

Codecov Report

Merging #9731 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9731   +/-   ##
=======================================
  Coverage   52.23%   52.23%
=======================================
  Files         212      212
  Lines       25945    25945
  Branches     5591     5591
=======================================
  Hits        13552    13552
  Misses      10159    10159
  Partials     2234     2234

Impacted Files
Coverage Δ

subsys/net/lib/app/net_app.c
41.07% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8d429...dab37d3. Read the comment docs.


Sea Lions

You are being overly harsh on people you call sea lions. Today's "sea lion" can be tomorrow's friend. In most cases they are trying to help. You can close this issue now. I just got upset when reading the "us" vs "them" mentality on the page.
With some irony,
Lawrence

I agree with the "us vs them" comment here, and see it also in this statement on this page: https://inclusivenaming.org/language/implementation-path/

We encourage you to take a stance of banning/blocking as quickly as possible.

It's critical that everyone keep front-of-mind at all times that this project is about compassion and making the world better, not about winning, scoring points, or driving metrics.
In both cases, I understand the reason for the remarks. Wow, do I ever. There are absolutely some bad players out there. But as soon as we divide up the world into us and them, we are in danger of becoming the very thing we are working against.
Always assume good intent.


Added webview

added webview using both https://github.com/react-native-webview/react-native-webview & https://github.com/react-native-web-community/react-native-web-webview
Webpack needs to be configured for it to work though, see the changes in the example app.

Was this working for you on the web? I get this error:

I was taking a look at Expo AV and how they handle createElement, you might have to do something like this:
import createElement from 'react-native-web/dist/exports/createElement';

https://github.com/expo/expo/blob/master/packages/expo-av/src/ExponentVideo.web.tsx

It was working for me. Will take a second look, maybe I missed something

It works for me on web and android. Here is a screenshot from web. The same error your getting I got when webpack wasn't configured correctly, so make sure it matches and try again.


Gitlab merge ratio

Fixes #88
Only the grafana changes here on the dashboaard

Cherry-picked into this PR: https://github.com/merico-dev/lake/pull/119


fix inefficient usage of batch_save

It seems that original PR was about changing behaviour of KVStoreCheckpointer.batch_update but I see that you have changed a bit more. I think it will be reasonable to split PRs.
I think that KVStoreCheckpointer.batch_update seems a reasonable change, I'll test it on Friday.

we will split the fixes into separates PRs


Documention of do is incorrect regarding error handling.

There is inconsistency in how do() method handles errors.
RxJS version: 5.2
Code to reproduce:
Rx.Observable.of(1, 2, 3)
    .do(i => {
        if (i > 1) {
            throw new Error(i + ' > 1')
        }
    })
    .subscribe(
        i => console.log(i),
        e => console.error('Why? do() gave me different sequence. Initial one did not contain error. Initial one contained 3 values')
    );

Expected behavior:
Should produce the following console output:
1
Uncaught Error: 2 > 1
2
Uncaught Error: 3 > 1
3

Actual behavior:
Output is as follows:
1
Why? do() gave me different sequence. Initial one did not contain error. Initial one contained 3 values

Additional information:
Documentation states that method do():

Perform a side effect for every emission on the source Observable, but return an Observable that is identical to the source.

but in next paragraph it states that

Any errors that are thrown in the aforementioned Observer or handlers are safely sent down the error path of the output Observable.

Shouldn't it be considered as inconsistent statements? Initial observable can actually be modified in observer, passed in do() method. If that observer throws an error, the output observable will not be the same as initial. It will emit error, and it will not emit values after that error.

TL;DR: we need to fix documentation. PRs welcomed.

I think the problem here is in documentation

Perform a side effect for every emission on the source Observable, but return an Observable that is identical to the source.

We should say "identical to the source as long as errors don't occur" or "closely resembles the source".
The reason is, given
const a$ = Rx.Observable.of(1, 2, 3);
const b$ = a$.do(i => {
        if (i > 1) {
            throw new Error(i + ' > 1')
        }
    });

a$ emits no errors. b$ is an Observable that emits an error. This is because of:

[do()] Any errors that are thrown in the aforementioned Observer or handlers are safely sent down the error path of the output Observable.

When b$ emits an error, b$ terminates. This is the typical observable contract. If an error goes to the observer.error handler, that means it is forbidden for observer.next/observer.error/observer.complete to be called after that.

Seems that the issue may be closed now.

Seems so. closed via #2543.


Error when extracting POIs

The issue tracker is for reporting bugs and feature requests. Before you proceed, please read the contributing guidelines in this repo's CONTRIBUTING.md.
If you installed OSMnx via conda and are experiencing installation problems, please open an issue at https://github.com/conda-forge/osmnx-feedstock/issues
If you're having trouble with OSMnx, first search the previously opened issues to see if the problem has already been noted. If not, fill in the template below:
Problem description (what did you do, what did you expect to happen, and what actually happened)
I was running a simple extract POIs for Bamako and encountered the following error - for which I am proposing a solution
What operating system, architecture, Python version, and OSMnx version are you using?
Windows, Python 3.7, OSMNX 0.8.2

Code snippet that independently and completely reproduces the issue
>>> df = ox.pois_from_polygon(polygon = self.bbox, amenities = self.current_amenity)

I have identified the error, and I updated a solution in my local OSMNX install, if you want to incorporate it into the code. At line 255(ish) of pois.py there is a check of relation tags that causes the error below
if  relation['tags']['type'] == 'multipolygon':
    try:
        # Parse member 'way' ids
        member_way_ids = [member['ref'] for member in relation['members'] if member['type'] == 'way']

### PROPOSED CHANGE

try:
  relType = relation['tags']['type']
except:
  relType = ''
if relType == 'multipolygon':
  try:
    # Parse member 'way' ids
    member_way_ids = [member['ref'] for member in relation['members'] if member['type'] == 'way']

###Error Encountered
>>> df = ox.pois_from_polygon(polygon = self.bbox, amenities = self.current_amenity)

  File "testing_pois.py", line 15, in <module>
    temp = current.GenerateOSMPOIs()
  File "C:\Users\WB411133\OneDrive - WBG\AAA_BPS\Code\Code\Github\GOST_PublicGoods\Market_Access\OSMNX_POIs.py", line 67, in GenerateOSMPOIs
    df = ox.pois_from_polygon(polygon = self.bbox, amenities = self.current_amenity)
  File "C:\WBG\Anaconda\envs\gbdxtools\lib\site-packages\osmnx\pois.py", line 434, in pois_from_polygon
    return create_poi_gdf(polygon=polygon, amenities=amenities)
  File "C:\WBG\Anaconda\envs\gbdxtools\lib\site-packages\osmnx\pois.py", line 357, in create_poi_gdf
    gdf_ways = parse_osm_relations(relations=relations, osm_way_df=gdf_ways)
  File "C:\WBG\Anaconda\envs\gbdxtools\lib\site-packages\osmnx\pois.py", line 252, in parse_osm_relations
    if relation['tags']['type'] == 'multipolygon':
KeyError: 'type'

Can you provide a complete code snippet to independently reproduce the issue?
Secondly, if you've found a solution, would you like to open a PR?

Hi @gboeing first of all thanks for such an amazing package! However, this issue still persists, and even after trying the changes suggested by @bpstewar, there's no improvement, can you please suggest a fix around the same?
Thanks

If someone provides a complete code snippet to independently reproduce the issue, I can take a look.

Hi @gboeing! Yes, thank you for this really great package! I would like point that this issue still persists. My code is:
import osmnx as ox NYC_pois = ox.pois_from_place('New York City')
I get the same error described by @bpstewar. And as mentioned @rbhatia46, @bpstewar's fix does not solve the problem. I have used this function (and "pois_from_polygon" as well) for several cities around the world, with no problems. The error happens only with NYC. Any idea of what may be causing the problem?
Thank you!

Should be fixed in #431

@lnicoletti the fix has been merged into master and tested using your MWE. Thanks!

Thanks @gboeing !


Blog title for a specified blog

kasper is very good;
however,
for example,http://qiukeren.github.io/segmentfault/2015/05/01/welcome-to-jekyll.html
if it is better that set the page.title the same as post.title?

Oh, i modified the default.html as follows my self so it worked.
<title>{{page.title}} - {{ site.name }} - {{ site.description }}</title>


change SoftAP default password in IoTOnboardingTask

Hi @nicogbg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


Implement cross contract check to validate equipping child

Before equipping an asset ensure that token_can_be_equipped_with_asset_into_slot
This will break part of unitests for equip.

[ ] Make cross contract call in equip() function to call ensure_token_can_be_equipped_with_asset_into_slot()
[ ] Fix part of the unit test that will be broken with this PR
[ ] Introduce missing e2e test to cover equip. Perhaps new file tests/equip.spec.ts

We don't need to make it possible for an already existing PSP34 to be equipped. It would open doors to non sense equippings. If we can assume that child is always an implementer of equippable, then we can check safely.

@Maar-io Is this free to work on? If so I would like to implement this.

@boyswan Have you started on this? If not, Sergej can take it

Haven't looked at this yet, @Szegoo feel free to go for it!


deploy: get end-to-end deploy pipeline working

On a day-to-day basis, assuming no changes in the core infrastructure, new guides require an updated gen_guide_structures.cue file to be deployed to the backend. This file tells cmd/controller what guides it should know about, their structure, presteps to execute etc. This could become a part of a deploy step on in a GitHub deploy workflow (we already need to deploy pages).
As we start to make improvements to PWG, the SDK, write guides etc, we should look to deploy as regularly as we can. Because by that point we will have alpha tests who will be giving feedback.
This is a tracking issue to capture issues and work required in getting that pipeline in place.

Who should be able to deploy?
What is involved with deploying?
...

cc @marcosnils - see in particular the updated description about the need to deploy a new gen_guide_structures.cue file for new/updated guides.

Not critical for go-live, but something we need to fix so that there are no manual steps involved.


Fix my typo of my name from Fazkeas => Fazekas

Hey, I can't deploy this fix right now because there's work in master that we prefer to rethink a bit, but will be published eventually!

sure it's nut urgent for sure, thanks!