New rule: member should not return created and cached disposables.

This issue was moved to DotNetAnalyzers/IDisposableAnalyzers#33


Backend  - filteration

See internal docs: https://github.com/bithyve/internal-docs/issues/172

@Arpanjainson @antuz123 What are we supposed to do here?

@cakesoft-shashank  has closed this issue that closes this issue


Files nested inside content/content-script doesn't auto reload on browser

Im having such file structure. All the other file successfully refetch the latest version on browser except content/freightPage/nswex/NswexInjecteds.
Inside freightPage/index.ts
ive already import like this
import '@pages/content/freightPage/nswex/NswexInjected'

But I can clearly seen vite rebundle everytime i have changes on file, just it is not reflected on browser straight away. Am I missing something?

But I can clearly seen vite rebundle everytime i have changes on file, just it is not reflected on browser straight away. Am I missing something?

Did you also refresh your browser?

Hi, I need to refresh the extension and also refresh the browser, usually I don't need to for other files.. Only if its nested then it lost all capabilities to refresh. Does it work for you?

@tngflx Are you able to test it, and give us response? :)


DF-513:Make record attributes consistent with API response

Related ticket(s):
https://national-archives.atlassian.net/browse/DF-513
About these changes
Some record attributes are inconsistent with the API response attribute. This change is to make them consistent and apply them to the templates.
Making them consistent enables easier debug and maintenance.

created_date
access_condition
summary_title
delivery_option

How to check these changes
As mentioned in the ticket.
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer.
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
[x] Ensured that PR includes only commits relevant to the ticket.
[x] Waited for all CI jobs to pass before requesting a review.
[x] Added/updated tests and documentation where relevant.

For Reviewer/Developer

Before merging PR
main branch :
  - check PR merge tile begins with `release/<major.minor.patch>:<default/custom description>`
  - check PR merge tile begins with ticket number Ex `DF-XXX: Ticket name / short description`
  - select `Create a merge commit`

develop branch:
  - check if merges into base branch are `not to be kept On Hold` and then proceed.
  - check PR merge tile begins with ticket number Ex `DF-XXX: Ticket name / short description`
  - select `Squash and merge`

After merging PR:

check and arrange to deploy on platform-sh.
update status on JIRA ticket on deployment.
update slack on deployment progress of the JIRA ticket once deployed.

These looks great, thanks! I just had a couple of questions on whether we should be replacing title completely, or whether we just need to pull out a different value
Any inputs from API which was not brought into the details page will be approved from here https://national-archives.atlassian.net/browse/DF-417, in this case Title


PACT-575 Investigate existing options for ordering of columns in lists of results in the Web Application

TODO:
[ ] numeric cell types as well string types, these should right align: https://design-system.service.gov.uk/components/table/

The solution is partially inspired from this sortable table example from W3C:
https://www.w3.org/WAI/ARIA/apg/example-index/table/sortable-table
However, that solutions uses javascript.
I've included the aria-sortattribute on the sortable column, however the W3C table has a few more features:

Hover css classes to indicate the headers are clickable and to highligh which headers are selectable only using keyboard
A hidden span caption element for screenreaders:

      Students currently enrolled in WAI-ARIA 101

        , column headers with buttons are sortable.

    ....


Assignment completed

@Radhasingh95, please check that you have deleted Assignment 1 from the submissions folder of Python-session. Also, I can't see any other changes that you have made or any notebook that you added.


allow shared/slave flags for docker volumes

@cjellick - This allows passing in mount flags other than rw and ro

Please add tests

LGTM


HDX-9910 remove openapi_examples

removed OpenAPI examples from:

code in the currency endpoint
acronym and name in the org endpoint
code and description in the org-type endpoint
update_date_min and update_date_max  in the resource endpoint
code and name in the sector endpoint

Does this mean all the openapi_examples have been removed?

That's right!


Map texture Error on Cache

When I try to watch my cache demo through HLAE, (which is fine watching it regularly), the map has missing or distorted textures and there are various red and black "ERROR" block around the map. I dont have any of the anti cheats, I restarted my game and verified game cache, I uninstall/reinstalled even with older versions. Only happens on the map Cache and only happens through HLAE. I just had a pistol headshot ace I want to edit/record :(((((((((((((((

Please provide the demo.

Now what recently started happening, whenever I load up my other demo of ANOTHER clip i want to record, my game closes after a few seconds. Im not running as an admin, and I've tried uninstalling/reinstalling and even trying older versions. But here is the demo link for the Cache clip
steam://rungame/730/76561202255233023/+csgo_download_match%20CSGO-7L9sj-PdD7v-ps6Ru-VdUE4-hBnUE

Im trying to make my first frag movie and HLAE hates me :(((((((((

I can confirm there are indeed some problems with mirv_streams, not sure if related to your problem, but I need to fix them and then we will see if your problem is fixed too.

Does it still crash for you, since the latest 27th March 2017 CS:GO update?

yes it does

If possible, please email me a crash dump / link to it, my email is on my GitHub profile page now (please use some subject that allows to know that it's from you).
I recommend to not link it publicly, since it sometimes can contain sensitive information.

Make sure to use the latest HLAE version if possible, currenlty 2.25.2, please mention in your email which HLAE version you used, so I can check with the right symbol files for HLAE.
Please make sure the crash dump is actually from the time where the crash happened, since there might be multiple crash dumps.
The crash dump files are either in the folder where csgo.exe is (as .mdmp files) or in the C:\Program Files (x86)\Steam\dumps folder as .dmp files, please check both folders.

I sent 3 dmp files in an email with the name HLAE from Benb727 (or something like that). thanks!

I had a look at the crash dumps, they all crash in the same place.
The problem is, it might be surprising, but I am not sure if it's HLAE related at all, because the place they crash in, is actually for decoding network data from the demo stream, in "RecvTable_Decode" in engine.dll.
Please do the following:

Please check if you have any mirv_streams edit streamNameHere attachCommands
or detachCommands in your config. If you have such a stream and have it in preview while loading a new demo, all sort of weird things can happen actually. The solution would be to end the preview of the stream (mirv_streams previewEnd) before loading a new demo for now.

Please describe the steps you do to load a new demo (commands you use etc.).

I just found out that your CS:GO is actually outdated / not properly updated:
[...]
Build: 6661
[...]
version : <IP_ADDRESS>

This build is from February or older.
This is a hint that your CS:GO installation is in an inconsistent state:

Make sure that you have updates enabled in Steam for CS:GO (right click in Steam library -> properties -> Updates Tab, make sure that "Always keep this game up to date" is enabled)

Verify the files of your installation: right click CS:GO in Steam library -> properties -> Local Files Tab -> Verify Integrity Of Game Cache button (let it verify and download files if required, will take a few minutes).

Make sure you are not using outdated addons (like SourceMod / ... ) for your CS:GO, rename or delete any "addon(s)" folder in C:\Program Files (x86)\Steam\steamapps\common\Counter-Strike Global Offensive\csgo

Last but not least, you might need to make sure you have the latest HLAE, because there was a CS:GO update today, and I yet need to check if s.th. is broken / try to fix newly broken things / make a new release.

i did all you said, redownloaded hlae and all, and still crashes.

i dont have a movie making config, hlae used to work fine and now it crashes any demo i try to look at.

This is really weird, I can offer to have a look through AnyDesk or TeamViewer, please add me in Steam: https://steamcommunity.com/id/ripieces

Hey I added you on Steam, my name is BennyS
Sent from my iPhone

On Apr 18, 2017, at 2:32 AM, Dominik Tugend<EMAIL_ADDRESS>wrote:
This is really weird, I can offer to have a look through AnyDesk or TeamViewer, please add me in Steam: https://steamcommunity.com/id/ripieces
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@Benb727 I think someone else had the same problem like you and we figured it out:
https://twitter.com/dtugend/status/865913794970734592
CS:GO bug (old): Start game with multicore rendering disabled, enable it, join a game or load a demo -> crash.
May not seem like a big deal at first, but if someone has mat_queue_mode changed through console / a config only, they will always crash.
Solution: Either enter mat_queue_mode 0 into console before loading a demo or fix mat_queue_mode to -1 in your video.txt (the one in userdata or if you use mmcfg folder the one in mmcfg folder).

For solution see my previous comment.
Closing since you said earlier on Steam you don't bother anymore.
If that doesn't solve your problem, feel free to contact me in Steam or here.


Document check in process for attendees and prepare registration sheet

What
Check-in process for attendees to capture who has attended the event.  (Eventbrite)
Why
Reception people and back-up team members need to be made aware of the process to capture attendees
Who needs to work on this
Ciandelle, Nora
Who needs to review this
Done when

[x] Ciandelle to set up a meeting with team members on reception and any further volunteers
[x] Everyone is aware of the process
[x] Answer any questions for the reception check-in process

Unable to do via the app - Ciandelle will follow up for future events (Eventbrite for Organisers - rejected by Information Assurance in 2019)
Ciandelle will set up Eventbrite show-and-tell

This was done in the show and tell, check in team can have a secondary session if the team feels this is necessary? @kellylee-gds @Kam-Nijjar

@Ciandelle as suggested - can we do a session during one of our L & D sessions

I think this ticket is something different to the eventbrite. It's how we'll manage the check in and registration at the front desk on the day.

Full attendee list is also on the Access needs / Dietary Requirements spreadsheet, most up to date export has been added 30/8

export attendee sheet Tuesday 3/09

completed


How can the Table component control the sorting trigger without clicking on any position of the corresponding TH

What problem does this feature solve?
How can the table component control the sort trigger without clicking on the corresponding th position which will cause the drag and drop to change the column width to trigger the sort event
What does the proposed API look like?
If you throw a controllable property, true, you can click on any position of the current th to trigger sorting. If you throw false, you can click only text or sort icon on th to trigger sorting, leaving some space for other properties on th

巴嘎


fix: remove clippy warning

Removing pub(self) as suggested by Clippy

this is fixing the warning from this PR: https://github.com/0xPolygonMiden/miden-base/actions/runs/5422443131/jobs/9919561413?pr=148


Replace failure with a custom error type

Thank you for this crate. I have been using it in a JSON-RPC networking server for a couple of years.
This PR replaces the failure dependency with a custom error type and implementation for WpaError (moved from src/wpactrl.rs to src/error.rs).
With the custom error type, total build dependencies are reduced from 46 to 17 and the release build compilation time drops from 8.94 seconds to 3.27 seconds on my local machine. I think this offers a great improvement for a low-level library such as wpa-ctrl-rs.
The other changes in the diff are a result of cargo fmt.
I welcome your feedback. Thanks again.

Yeah, failure is outdated now. Did you look at thiserror or did it blow compile times or dependencies up?

The other API-breaking change I could see making now to modernize the crate is to make it async. In that case I'd probably want to make your error change at the same time as my async change so there's only one breaking version. How would that work with your use case?
Though to be fair, constraints on my time being what they are, I might want to just update the error so it doesn't get held up on asnyc.
There's some other additions I've thought about making to the crate, eg make it so that there's a higher-level interface where the commands are functions so that there's more type-safety, but that will be a longer process to write a function handler for each command that I don't see happening soon. But if you are doing something similar, feel free to contribute that too, even if it's a partial impl (yay open source).

Did you look at thiserror or did it blow compile times or dependencies up?

I did not. It was simple enough to implement the custom error and I've generally been avoiding using error crates in libraries lately.
Out of interest, I just created a crate with thiserror as the only dependency to test a cargo build --release run: it requires 11 dependencies and 3.51 seconds to compile on my machine.

I'd probably want to make your error change at the same time as my async change so there's only one breaking version

I can understand this desire. Since the crate has not been actively developed for quite some time, perhaps it's expedient to merge the error update now and bundle the async & function handler refactor in a future release? I may have a crack at implementing the function handlers at some point but I'm focused on another project for now.

Thanks for checking that. I'll go ahead and merge this in, like you say the other stuff can wait until a future release.

I went ahead and bumped the package versions, migrated to rust 2021, and dropped nix in favor of just libc. Give it a whirl if you have time, note that new() is now builder() to try and make clippy happy (and match with eg reqwest convention). Assuming there's no objections I'll try to remember to push a new version.

@spease
Great work! There are now 8 total build dependencies and a release build takes 1.22 seconds on my machine; a major improvement. I'm also happy to see that clippy is now satisfied.
Today I realised that I should have reexported the error type. Could you add that before pushing a new version?
In src/lib.rs, line 21 should have the pub keyword added:
pub use crate::error::WpaError
Then library users can match on this type in their code.


feat: [FC-0047] Calendar synchronization

https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=7368-44459&t=DjohnYrzKkt6Oipi-4

Light Theme
Dark Theme

https://github.com/openedx/openedx-app-android/assets/141041606/1b21439c-6fb8-4435-9a60-1aee6320aa12
https://github.com/openedx/openedx-app-android/assets/141041606/5e0f2d42-a176-461d-a7d4-f25a45c81627

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

Thanks @PavloNetrebchuk! At a glance, this looks great to me from the design side.

@HamzaIsrar12 @k1rill, Kindly review the changes made in this pull request.
Thank you 🙌

Since this is a complex PR, lets wait for approvals from TouchApp and Axinite both before merging this PR, thanks!

@volodymyr-chekyrta The newly introduced enrollment status API returns the following response:
[
  {
    "course_id": "course-v1:OpenEdX+aiforbegginers1+2024_T1",
    "course_name": "AI For Beginners",
    "is_active": true
  },
  ...
]

How is the value of is_active determined?

@volodymyr-chekyrta The newly introduced enrollment status API returns the following response:
[
  {
    "course_id": "course-v1:OpenEdX+aiforbegginers1+2024_T1",
    "course_name": "AI For Beginners",
    "is_active": true
  },
  ...
]

How is the value of is_active determined?

is_active: false means that the course (xblocks) has not been used by this user for more than 30 days.
The basic idea is to exclude inactive courses from synchronization.

Preferably, is_active should also be false if the course access has expired or the course hasn't started yet. In both cases, the course dates aren't available, leading to a Sync Failed call.

The "Syncing X Courses" view does not appear during the initial sync.

There are a couple of issues with this flow:

"Demo Course 7" was never synced, but it was placed on the Synced side.
"Demo Course 8" wasn't synced initially but appeared after unsyncing other courses.

https://github.com/openedx/openedx-app-android/assets/71447999/84fa8f9c-d674-4f1d-832e-724662fd91d4

The "Syncing X Courses" view does not appear during the initial sync.

The user will see "Syncing 0 Courses" if we show that button before initialisation. This can be confusing, so we hide the button.

The Syncing isn't working properly once the course is unsynced externally.
https://github.com/openedx/openedx-app-android/assets/71447999/97c49d7a-d40d-4ab2-b254-24745c976525

@PavloNetrebchuk That makes sense for the initial view but it should be visible once the state is changed to sync.

There are a couple of issues with this flow:

"Demo Course 7" was never synced, but it was placed on the Synced side.
"Demo Course 8" wasn't synced initially but appeared after unsyncing other courses.

Calendar.Syning.Issue.mp4

We synchronize all courses that can be synced. The situation in the video looks as if "Demo Course 8" did not synchronize due to an error during the initial sync. We can see this from the synchronization indicator. Therefore, the application synchronized on the second attempt.

@PavloNetrebchuk That makes sense for the initial view but it should be visible once the state is changed to sync.

We show the button as soon as it becomes possible. Before showing it, we need to check the state of all enrolled courses one by one.

The Syncing isn't working properly once the course is unsynced externally.
Calenday.Sync.Change.Date.Issue.mp4

As far as I know, this was not part of our scope of work. @volodymyr-chekyrta Am I right?

The Syncing isn't working properly once the course is unsynced externally.
Calenday.Sync.Change.Date.Issue.mp4

Actually, I think if the user made changes, they have reasons for that. As for me, it's the correct flow.

I have marked the issues for easy reference. 😄
Issue 1: When an API error occurs during sync, the view is not visible. However, this should not happen. We should still display the synced courses and move the others to the unsynced state.
Issue 2: A course should not be in the Synced state if we are not receiving the course dates Or if we encounter an error on it.
Issue 3: From the logs, it appears there was never a call for Demo Course 8, meaning the execution stopped after encountering an error on Demo Course 7. We should ensure the process continues to pass all syncable courses.
Issue 4: I apologize if my hardcoded example was confusing. I was referring to the mobile option "Reset Course Dates," which updates the course dates (also available on the web). In this case, the calendar and course dates will be in an unsynced state and will never be synced with the current logic.

Issue 5
The "Change Sync Options" feature creates a new calendar instance with every change. I think the intended implementation was to replace the existing instance instead.
https://github.com/openedx/openedx-app-android/assets/71447999/8b96c469-7f7a-4d0a-99c2-08867b177044

Issue 6
App Crashes on Calendar Permission Revoked.
Steps to Reproduce:

Allow Calendar Permission
Sync Courses
Remove Calendar Permission from App Settings
Navigate to Calendar View and the app will crash

Issue 7
Some UX changes were suggested by the iOS team for the Design Team:

It would be nice to have a Snackbar on Sync Complete
In case of an empty list in Synced or UnSynced state we should show an Empty State.
Just to point it out, The "Relative Dates" section is also missing.

@HamzaIsrar12
Issue 6 has been resolved.
Regarding the other issues mentioned, we understand these concerns. While they are not critical, we are open to considering improvements and will incorporate them into the next pull requests as necessary.

Can we find a way to split out suggestions for improvements from gaps in functionality or bugs? It is a bit difficult to follow here what needs to change versus what can be a future enhancement. I will try to re-read this from the top to gather the list of open issues as identified, but if anyone else has a clearer sense of the recap / the latest let me know.

Issue 1 - The "Syncing X Courses" view does not appear during the initial sync.
Update: The user will see "Syncing 0 Courses" if we show that button before initialization. This can be confusing, so we hide the button.
Result: No change required here I think
Issue 2 & 3 - There are a couple of issues with this flow: "Demo Course 7" was never synced, but it was placed on the Synced side. "Demo Course 8" wasn't synced initially but appeared after unsyncing other courses.
Question 2a: I had a hard time understanding exactly what was happening in the shared video, I didn't catch / see when we triggered the unsync option. Can this be clarified? I'm curious to understand how often we expect this will happen / what triggers this.
Question 2b: Is the broader issue that syncs fail / break when we attempt to change sync settings mid-sync?
Question 2c: Does the system automatically attempt resync (I think that's the csae but want to confirm.
Question 2d: Is the issue of a course that is synced vs unsynced being inaccurately labeled only a problem in the sync settings view or do the course dates tab for those courses also show the wrong status. Is the wrong status shown temporarily while the resync happens or it is permanently incorrect once broken the first time?
Result: Not clear what the impact / scope of this and whether we need to fix ASAP. Questions included above for next steps.
Issue 4 - The Syncing isn't working properly once the course is unsynced externally.
It sounds like we don't properly override any edits you may have made to calendar events edited from the calendar app when you rejoin the app / resync dates. Is that a fair assessment of the impact of this? If so, we can make a ticket for future cleanup of this case, but I dont expect it to be common for someone to edit these calendar events.
Result: Created backlog ticket for this case, not worried about this causing issues in the short term. https://github.com/openedx/openedx-app-android/issues/365
Issue 5 - The "Change Sync Options" feature creates a new calendar instance with every change. I think the intended implementation was to replace the existing instance instead.
Question 5a: I agree we generally want to rename an existing calendar instead of creating a new calendar if possible. If this isn't a simple fix we should create a separate ticket as with issue 4 above. Will wait for development clarity on this. I know in certain cases (ex: renamed calendar outside of application) we can't detect this and would need to "resync" again, but for renames of the calendar name within the app I would expect to have full knowledge of this and be able to simply edit the existing calendar, or delete the old and replace with the new.
Result: pending Question 5a
Issue 6 - App Crashes on Calendar Permission Revoked.
Result: Sounds like this has been fixed in a follow-up.
Issue 7  - Some UX changes were suggested by the iOS team for the Design Team:
It would be nice to have a Snackbar on Sync Complete
In case of an empty list in Synced or UnSynced state we should show an Empty State.
Just to point it out, The "Relative Dates" section is also missing.
Result: I will flag these items to @sdaitzman for future review / updates but I think the first two items above we should consider out of scope of this (snackbar + empty state for synced / unsynced).  I think the Relative Dates work might be in a separate PR.
Second list of issues included below as well
Issue 1: When an API error occurs during sync, the view is not visible. However, this should not happen. We should still display the synced courses and move the others to the unsynced state.
Question: Which view isn't visible when an API error occurs? Trying to understand where the user impact is here. Is this only within the sync options view or within the dates tab for a given course as well?
Issue 2: A course should not be in the Synced state if we are not receiving the course dates Or if we encounter an error on it.
Question: A course that isn't synced can be marked unsynced, but is this temporary between attempted resyncs or a permanent issue? This is similar to my question in "issue 2+3" above.
Issue 3: From the logs, it appears there was never a call for Demo Course 8, meaning the execution stopped after encountering an error on Demo Course 7. We should ensure the process continues to pass all syncable courses.
Question: Similar question about resync to other issues above.
Issue 4: I apologize if my hardcoded example was confusing. I was referring to the mobile option "Reset Course Dates," which updates the course dates (also available on the web). In this case, the calendar and course dates will be in an unsynced state and will never be synced with the current logic.
Question: I'm not sure I follow this - Does this mean that when you reset / update course dates we don't automatically trigger an update to the course dates calendar? If not we should create a ticket for this.

Issue 1: To double-check. It’s okay that we don’t show the count while syncing, but an API error shouldn’t interrupt the flow.

@HamzaIsrar12, thank you for identifying this tricky case 🙌 . We have confirmed that this is a bug that interrupts the flow.
It will be fixed.

Hello @HamzaIsrar12,
Issue 1: Fixed. Synchronisation wouldn't stop if one of the courses encountered an exception.
Issue 5: Fixed.
Issue 7:
a) An empty state was added to the list.
b) Relative dates will be added in the next PR.
c) It was decided not to add a Snackbar on Sync Complete. I confirmed this with the iOS team.
Let me know if there's anything else you need!

Hey @marcotuts, Thank you for looking into this. To simplify, Issues 1 to 6 were bugs, and Issue 7 was a UX suggestion.

Let's address your questions. To keep it simple, I will skip over the items that have been fixed based on recent comments. 😄
Issue 1: Fixed based on Volodymyr message 🚀
Issue 2 & 3:
The issues should hopefully be resolved with the solution for Issue 1. I only conducted a manual review, so @PavloNetrebchuk , please assist Marco with the followup questions.

Question 2a: I had a hard time understanding exactly what was happening in the shared video, I didn't catch / see when we triggered the unsync option. Can this be clarified? I'm curious to understand how often we expect this will happen / what triggers this.
Question 2b: Is the broader issue that syncs fail / break when we attempt to change sync settings mid-sync?
Question 2c: Does the system automatically attempt resync (I think that's the csae but want to confirm.
Question 2d: Is the issue of a ....

Issue 4:
I will add details in the Ticket once free from the MVP or will close it if not needed. 👍🏻

Result: Created backlog ticket for this case, not worried about this causing issues in the short term. https://github.com/openedx/openedx-app-android/issues/365
...
Question: I'm not sure I follow this - Does this mean that when you reset / update course dates we don't automatically trigger an update to the course dates calendar? If not we should create a ticket for this.

Issue 5 & 6: Fixed based on Pavlo message 🚀

Thanks you @PavloNetrebchuk for addressing the feedback. ✨  Due to the high priority of our MVP release, I won't be able to verify the changes myself at the moment. 🏎
@volodymyr-chekyrta , could you please verify the addressed changes so we can proceed with merging this PR?
To answer some of your questions: I compared the Android build with iOS for Issue 2, and it appears they were moving the courses to the unsynced state. You might want to compare both apps on a similar user to see the results.

Explanation regarding the synchronisation of Demo Course 7 and Demo Course 8. (Issue 2 & 3)

The normal case, the course with dates
Sync course that has not yet started

https://github.com/user-attachments/assets/5783bb8c-60df-4c44-8d26-eec02af64256
https://github.com/user-attachments/assets/5ef15c8a-b645-4908-a03c-f35a5c644096

We apologize for the confusion, we did not point this out earlier.
At the moment there is a known issue on the backend with not being able to access course dates on a course that has not yet started.

@PavloNetrebchuk 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

I created tasks for these API Start Date issues fyi @PavloNetrebchuk , @volodymyr-chekyrta ^
Great to see this merged!


Update ReadME (+ Documentation)

Hello, I have added some additional information as a small Documentation.

With all due respect, This seems more of that digital ocean spam.


Avoid spread-first scheduling policy for EACRuntime's workers

Signed-off-by: dongyun.xzh<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Avoid spread-first scheduling policy for EACRuntime's workers. Currently EAC prefers binpack-first scheduling policy to spread-first scheduling policy. Set PreferredDuringSchedulingIgnoredDuringExecution to empty to avoid using spread-first scheduling policy.
Note：This is a temporary fix and should be removed when EAC is ready for spread-first scheduling policy
Ⅱ. Does this pull request fix one issue?

fixes #2581
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/lgtm
/approve


BUG: All numeric types during export should be double

Quoting https://github.com/mne-tools/mne-python/issues/11031 :
Reading a file exported by MNE on MATLAB
EEG.trials

ans =

  int64

   105

The type is int64 instead of double. This can cause all kinds of problems (I was trying to use the number of trials to calculate a ratio, and it was always returning the wrong value for example). This might be the case as well for other fields.

@arnodelorme I will cast this to double. Should all scalar fields be double (e.g. nbchan, srate, etc.)?

Yes, all numerical fields should be double.
Arno

@arnodelorme I will cast this to double. Should all scalar fields be double (e.g. nbchan, srate, etc.)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

This should be fixed in the latest code

Should be fixed in v0.0.2.post3.


Add Copyright to Response

We should add the copyright to the response like:
copyright: "© OpenStreetMap-Contributors"

We should make this also configurable in the .yml

Fixed in #8


Evaluate com ports using pyserial

Thanks for creating this. Just yesterday I had a requirement to log some data on my N56FU and of course the original software no longer works, good luck compiling QtDMM2, and Sigrok doesn't support it, so I'd resigned myself to writing something until I found this. I work with both Linux and Windows so I needed this code to be able to connect to devices on both. Seems PySerial already has this covered. This PR (hopefully) allows this to work on both Linux & Windows. I've tested on Ubuntu and on Windows 10.

Hi Ian, thanks for the contribution.  I'm currently working out how to deal with pull requests and reviewing code, I'm a github noob.  Windows capability is a very useful addition, thanks. I haven't touched a windows machine in a decade, but now have a laptop that will boot to it.  I'll get python going on it and try it there too.

It tested fine on Linux, but I can't get it to work on windows 10 on my Lenovo ThinkPad.  It runs but reports "No meter found.", because serial.tools.list_ports.comports() always returns an empty list.   It works on Ubuntu on the same machine.  I lack much experience of windows OS in the last 10years, but did try as administrator too.

I guess the good thing is that it still works on Linux & there's no regression. For Windows, did you look in device manager to see if it's recognised it? To get there, right click the windows icon at bottom left and choose "device manager". You should see it beneath the "Ports (COM & LPT)" entry.

Also, if it helps, I found my original CD and uploaded the Windows app here https://archive.org/details/N56FU. It still works on Windows 10 after all, provided the com port number is low. I didn't test exactly what the limitation is, but it didn't work when my com port was COM14 but did when I set it to COM3.

Ah. Not as a com port, but as the CP2102 USB to UART Bridge - without a  driver, so that would explain that.  It couldn't find a driver on the machine.  I'll have to leave this for now. I'll investigate further.

I'll check that out, thanks. That will have the driver I presume.

You can download the driver from Silabs website. https://www.silabs.com/developers/usb-to-uart-bridge-vcp-drivers?tab=downloads. I didn't upload the driver to Archive.org because the packaged one was for WinNT or Win98! I figure they would be a little out of date :D

Thanks for your help and patience, that is working now with the driver from your link.   I intend to merge your contribution, and will update the comments and readme. (I presume I do that with another commit after merge?)  I'm minded to acknowledge your contribution in the comments, are you ok with that?

I'm ok with you acknowledging but it's not really necessary to do it explicitly. Github will show me as a contributor anyway.

Ok, thanks for the info.

Now works with Windows (if CP2102 driver installed), thanks to Ian Cass.


rangy.getSelection().toString() does not maintain new lines

I noticed that using the rangy selection api does not return a string that preserves new lines while the native selection api does. Is this intentional? I'm using it for a Firefox innerText polyfill

Yes, it's intentional. Browsers don't agree, the spec has changed at least once and at present says nothing and emulating the innerText-like behaviour of either Gecko or WebKit is extremely complicated, so I chose the simplest option of concatenating the result of calling toString() on each range in the selection, which is what an older version of the HTML5 spec said and is what Internet Explorer does.
Rangy does have an innerText implementation now as part of the TextRange module.
rangy.innerText(element);

Great, thanks for the response


Improve usability of dependency locking docs

Issue type
Missing information
Problem description
https://docs.gradle.org/8.1.1/userguide/dependency_locking.html#generating_and_updating_dependency_locks
I find it difficult to understand how to set up dependency locking. I would expect to be able to visit the docs page and see a simple practical guide of what commands I should run to create, update, or migrate locks. For example:

To enable dependency locking, run
./gradlew dependencies --write-locks

This will generate locks...
To update the locks, run
./gradlew ...

At the moment I'm confused about to practically set up and use the dependency locks.
These commands all exist in the current doc, but they are scattered and difficult to skim through. A practical 'how to use' guide with a set of commands that shows typical use-cases would be very helpful.
Recommendations
I would find the docs more useful if they were more opinionated, or gave more guidance about which options I should choose. For example, the lock mode is documented and details are given, but I'm not sure which one to pick. The same is true for which configurations I should lock.
Demonstrate effects with a tree diagram
It would also be helpful to see a basic before/after file tree to demonstrate:

Here's a project without lock files. There are two subprojects, and a single included-build project.
subproject-alpha/ (a regular subproject)
build.gradle.kts
subproject-beta/ (a regular subproject)
  build.gradle.kts
external-project-one/ (an includedBuild project)
  build.gradle.kts
build.gradle.kts
settings.gradle.kts

Now let's generate the lock files by running ./gradlew dependencies --write-locks
subproject-alpha/ (a regular subproject)
  build.gradle.kts
  gradle.lockfile
subproject-beta/ (a regular subproject)
  build.gradle.kts
  gradle.lockfile
external-project-one/ (an includedBuild project)
  build.gradle.kts
build.gradle.kts
settings.gradle.kts
gradle.lockfile

Lock files have been generated in the root project and all subprojects, but lock files aren't generated for included-builds - see $link-to-explain.

Custom task
The docs contain a custom task, resolveAndLockAll, but it's really confusing why this is necessary. When I read the description, it says it "resolves all configurations", which implies the dependencies task doesn't? But then the task filters out non-resolvable configurations, so  what's the difference? In which situations should I use the custom task? Why isn't it included in Gradle as standard?
Also, the require() check could be improved to add more information to users.
require(gradle.startParameter.isWriteDependencyLocks) {
  "Cannot run $name - it must be run from the command line with the `--write-locks` flag"
}

Multi project set up
It is also highly confusing about how to generate lock files for subprojects. The docs indicate that it's just not possible?

Note that in a multi project setup, dependencies only is executed on one project, the root one in this case.

When I read this I think "I have multiple subprojects, so I want to generate lock files for all subprojects - but the docs emphasis that the dependencies task only works on the root project and doesn't explain any workaround - I'm confused!"
Or is this supposed to describe intended usage? So I shouldn't run ./gradlew :subproject-alpha:dependencies for some reason?
Does 'multi project' mean a single project with subproject? Or a project with composite included builds?
Missing documentation for error messages
I tried enabling locking in buildSrc/build.gradle.kts
// buildSrc/build.gradle.kts

plugins {
    `kotlin-dsl`
}

dependencies {
    implementation("org.jetbrains.dokka:dokka-gradle-plugin:1.8.20")
    implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.21")
    implementation("org.jetbrains.kotlinx:kover-gradle-plugin:0.7.1")
}

dependencyLocking {
    lockMode.set(LockMode.STRICT)
    lockAllConfigurations()
}

I then generated a lock file.
However, now I get an obscure error
FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':buildSrc:testCompileClasspath'.
Locking strict mode: Configuration ':buildSrc:testCompileClasspath' is locked but does not have lock state.

* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Exception is:
com.intellij.openapi.externalSystem.model.ExternalSystemException: Could not resolve all dependencies for configuration ':buildSrc:testCompileClasspath'.
Locking strict mode: Configuration ':buildSrc:testCompileClasspath' is locked but does not have lock state.
	at org.jetbrains.plugins.gradle.model.ProjectImportAction.addBuildModels(ProjectImportAction.java:439)

I'm really not sure what this error is about. It would be helpful if the error message had a link to a section the docs that described this problem.
Context (optional)
No response
Page with the problem
https://docs.gradle.org/8.1.1/userguide/dependency_locking.html#generating_and_updating_dependency_locks

When I read this I think "I have multiple subprojects, so I want to generate lock files for all subprojects - but the docs emphasis that the dependencies task only works on the root project and doesn't explain any workaround - I'm confused!"

There's so much confusion in the dependency locking docs around multi project builds. The most common case I've seen is that people want to generate one lockfile for the whole project to keep subproject dependencies consistent and don't actually care about the subproject-specific lockfiles. The docs do not do a good job explaining whether the root project lockfile is for the whole multi-project build, or just the root project, and so most people I talk to end up using Palantir's consistent versions plugin instead.
And then you get into composite builds, where people want to share versions between all their included builds...


[wip] Some improvements to the Properties panel

Closes https://github.com/scenerygraphics/sciview/issues/334
Hopefully we can also close: https://github.com/scenerygraphics/sciview/issues/509

@skalarproduktraum do you know where these funky borders came from? They appeared recently, i think when the Transfer Function Editor was merged:

For the PointCloud changes see this upstream issue: https://github.com/scenerygraphics/scenery/issues/590

I'm closing this because @skalarproduktraum fixed some of these issues in a different PR.


A way to manually progress a failing async call

Prereq: async based features showing up in console
Use cases:

I have a async call that has failed a number of times and will retry in a frustratingly long time for now. I have fixed the underlying issue, and i want to trigger the retry now.
I have an async call that is failing and it will continue to fail until the full retry policy is expired which will take a frustratingly long time due to the defined policy. I want to mark the call as failed so that the subscription/fsm can progress.

Would the catch verb be called in this case?

partner project had a use case for this today where they wanted to try their newly deployed code but were waiting on a previously long retry policy


MySQL connection failure

prior to updating my spigot server to use the 1.8 patch I have been able to use the MySQL function for a couple of years.
However, PEX is unable to retrieve read or write permissions from the MySQL server.
I know that the login that PEX uses has read and write permissions for the tables, as I have multiple plugins that take use of the same database.
I deleted the permission tables, to see if PEX could generate new ones. Instead, it gave me a similar permission error.
Server: spigot-1.7.10 (#1649) - latest spigot 1.8 patch
Here is my PEX configuration
Plugin: PEX
Configuration: http://pastebin.com/DNpHBeMh
Here is a configuration of another one of my plugins that has database perms
Plugin: LogBlock
Configuration: http://pastebin.com/ajxxQfSc
I can't produce a log without crashing my server, and java using 100% of all 4 of my servers physical CPU Cores.
I'm using the file based system for the time being, until I am able to sort out this issue in some way.

Make sure you're running the mysql 5.6+ (I'll try to work around this issue in a future version)


Add support for \Illuminate\Validation\Validator::each() to be passed a string as $rules

\Illuminate\Validation\Validator::each() function documents $rules to be either array or string. But currently only array is supported. This PR fixes this behaviour. Fixes #7145.
	/**
	 * Define a set of rules that apply to each element in an array attribute.
	 *
	 * @param  string  $attribute
	 * @param  string|array  $rules
	 * @return void
	 *
	 * @throws \InvalidArgumentException
	 */
	public function each($attribute, $rules)

5.0 is closed for new features now. Please send this to 5.1.

We're focusing on bug fixes for the final 5.0 release.

Replaced by #9074.


BLYNK_WRITE(Vx) not firing when using write node

I've just noticed that when triggering the write node it updates the mobile app element but not the hardware side, if I Blynk.syncVirtual(Vx) it sync's the status - is it possible to update both hardware and app without sync?
As per the RESTful API: http://blynk-cloud.com//update/V4?value=1

Hi chinswain,
at the moment there is no node implementing the hw_sync call.
Certainly it could be one thing to implement in the future.
I did not understand if it is to be implemented in the write node or if it is implemented with another node.
If you have any information on how to implement it or if you have any other requests let me know.
Greetings

With version 0.5.0 I implemented the "syncAll" and "syncVirtual" commands in the Sync node


[BUG] Failed to delete model

What is the bug?
Undeploy Response is successful with state as "undeployed" and when we try to delete the model, It is throwing an error saying model cannot be deleted in deploying or deployed state. The calls were within milliseconds.
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

What is the expected behavior?
If undeploy API return successfully, it should mean the model deployed and model state flushed to index correctly.
What is your host/environment?

OS: [e.g. iOS]
Version [e.g. 22]
Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

@b4sjoo Can you help take a look ?

Ok, let me try if I can reproduce it. I think it is a little bit flaky.

According to our investigation, this is because when we return the undeploy response the cluster might still be executing syncUpUndeployedModels task. The above PR should fix the issue by wrapping it with the listener.

Seems #1986 has the same root cause

[Catch All Triage - 1, 2]


Fixed duplicated generation on types and inputs

On Apollo Graphql type definition, is not possible to use same name for inputs and types, they detect inputs and types like the same type(a least on the definition, not for use on like put inputs on querys or unions).

To fix this error I simply added a  notation on the input generator.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[DS-3145] Configure rootpath in REST Reports (/handle, /xmlui/handle, /jspui/handle)

See https://jira.duraspace.org/browse/DS-3145
If this solution looks good, I will update the following page to recommend that a user set ROOTPATH in restReport.js to match their installation.
https://wiki.duraspace.org/display/DSDOC6x/REST+Based+Quality+Control+Reports

Documentation updated to correspond to this feature.  https://wiki.duraspace.org/display/DSDOC6x/REST+Based+Quality+Control+Reports#RESTBasedQualityControlReports-ConfigureItemhandleresolution

+1 This seems reasonable to me. It does seem like it's best to pull this path out into a configuration to make it easier to tweak

+1 by inspection.  Eventually we need to move this out of code into configuration.


Extract TomcatCP as a separate module #48

PR includes:

Extract TomcatCP as a separate module #48

leave Jdbc module purely abstract
introduce polymorphic config #56

Auto detection of an available connection pool #62

Note: the PR depends on the bootique core  issue #193

Applied. I made some cleanup and refactoring. The most relevant change is d48d5961, that goes to the heart of the abstract modules concept. Namely:

Abstract root configuration must be declared in the abstract module provider (bootique-jdbc), not in the concrete module (bootique-jdbc-tomcat).
Implemented subclass resolving via Bootique metadata layer instead of TypesFactory, which seems a better abstraction.
The previous item allowed to mapping subclasses by symbolic name ("type:tomcat"), not by Java class name ("class:io.bootique...").


Add data

Add all the data files and update the README file.

I think I've addressed all your comments @jchodera. some followup questions on my end:

there doesn't seem to be any registration_SMILES field in CDD or in the dataset in https://github.com/asapdiscovery/COVID_moonshot_submissions. is this the same as shipment_SMILES or is there something missing?
some of the SMILES are CXSMILES, should I strip out the extra information (converting them to just standard SMILES), or leave in the extra info?
some of the SMILES have disconnected compounds (ie there are . in the SMILES string), should I leave this as containing all the compounds, or just keep the largest (or some other method)?


strange error in SickRage log

getting this on every post process
2015-06-29 10:01:17 INFO     POSTPROCESSER :: Processing succeeded for /volume1/downloads/Complete/TVShows/Ready/Falling.Skies.S05E01.1080p.WEB-DL.DD5.1.H.264.HKD.mkv
AA
AAValueError: No JSON object could be decoded
AA    raise ValueError("No JSON object could be decoded")
AA  File "/usr/local/python/lib/python2.7/json/decoder.py", line 384, in raw_decode
AA    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
AA  File "/usr/local/python/lib/python2.7/json/decoder.py", line 366, in decode
AA    return _default_decoder.decode(s)
AA  File "/usr/local/python/lib/python2.7/json/__init__.py", line 338, in loads
AA    **kw)
AA  File "/usr/local/python/lib/python2.7/json/__init__.py", line 290, in load
AA    refresh = json.load(urllib.urlopen(settings.getRefreshURL(tvdb_id)))
AA  File "/var/services/homes/sickrage/scripts/mp4_automator/postConversion.py", line 55, in <module>
AATraceback (most recent call last):
AA2015-06-29 10:01:14 - mkvtomp4 - INFO - Relocating MOOV atom to start of file.
AA2015-06-29 10:01:14 - mkvtomp4 - INFO - /volume3/media/TVShows/Falling Skies/Falling.Skies.S05E01.Find.Your.Warrior.1080p.WEB-DL.m4v created.
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Starting conversion.
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Creating subtitle stream 0 from source subtitle stream 2.
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Subtitle detected for stream #2: srt [eng].
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Reading subtitle streams.
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Creating audio stream 1 from source audio stream 1.
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Creating audio stream 0 from source audio stream 1 [iOS-audio].
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Audio detected for stream #1: ac3 [eng].
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Reading audio streams.
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Video codec detected: h264
AA2015-06-29 09:59:41 - mkvtomp4 - INFO - Reading video stream.
AA2015-06-29 09:59:41 - SickbeardPostConversion - INFO - Processing /volume3/media/TVShows/Falling Skies/Falling.Skies.S05E01.Find.Your.Warrior.1080p.WEB-DL.mkv.
AA
AAAttributeError: 'Home' object has no attribute 'api/********************************'
AA    method = getattr(self, route)
AA  File<EMAIL_ADDRESS>line 241, in get
2015-06-29 09:59:39 INFO     POSTPROCESSER :: Executing command [u'/var/services/homes/sickrage/scripts/mp4_automator/postConversion.py', u'/volume3/media/TVShows/Falling Skies/Falling.Skies.S05E01.Find.Your.Warrior.1080p.WEB-DL.mkv', u'/volume1/downloads/Complete/TVShows/Ready/Falling.Skies.S05E01.1080p.WEB-DL.DD5.1.H.264.HKD.mkv', '205281', '5', '1', '2015-06-28']
2015-06-29 09:59:35 INFO     POSTPROCESSER :: Processing /volume1/downloads/Complete/TVShows/Ready/Falling.Skies.S05E01.1080p.WEB-DL.DD5.1.H.264.HKD.mkv (None)

any ideas what is causing it, it does not seem to be doing any harm, everything seems to run ok.

I see multiple instances in the log that suggest your autoProcess.ini settings that provide the information for Sickrage aren't correct, perhaps the username or password, or maybe an HTTPS issue. The script seems to be failing to pass the final notice back to Sickrage, which isn't really an important step other than for tidying up the final path so Sickrage is informed of the file extension change, which is probably why it seems to work.
I would go back and verify this information in the config and see if it resolves

i had it sietup with no user / pass i have just added a user/[ass will let you know the result.

just the same result, could you so me sample of a sickrage setting block so i can check against mine

here is output
2015-07-02 15:40:56 INFO     POSTPROCESSER :: Processing completed
2015-07-02 15:40:56 INFO     POSTPROCESSER :: PostProcessing Path: /volume1/downloads/Complete/TVShows/Ready
2015-07-02 15:38:31 INFO     POSTPROCESSER :: [Bonus.rar : Nothing was unpacked (file permissions?)]
2015-07-02 15:38:31 INFO     POSTPROCESSER :: I did encounter some unprocessable items:
2015-07-02 15:38:31 INFO     POSTPROCESSER :: Processing completed
2015-07-02 15:38:31 INFO     POSTPROCESSER :: Deleting folder (if it's empty): /volume1/downloads/Complete/TVShows/Ready/Luther.S01E04.UNCUT.720p.BluRay.X264-iNGOT
2015-07-02 15:38:31 INFO     POSTPROCESSER :: Processing succeeded for /volume1/downloads/Complete/TVShows/Ready/Luther.S01E04.UNCUT.720p.BluRay.X264-iNGOT/luther.s01e04.uncut.720p.bluray.x264-ingot.mkv
AA
AAValueError: No JSON object could be decoded
AA    raise ValueError("No JSON object could be decoded")
AA  File "/usr/local/python/lib/python2.7/json/decoder.py", line 384, in raw_decode
AA    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
AA  File "/usr/local/python/lib/python2.7/json/decoder.py", line 366, in decode
AA    return _default_decoder.decode(s)
AA  File "/usr/local/python/lib/python2.7/json/__init__.py", line 338, in loads
AA    **kw)
AA  File "/usr/local/python/lib/python2.7/json/__init__.py", line 290, in load
AA    refresh = json.load(urllib.urlopen(settings.getRefreshURL(tvdb_id)))
AA  File "/var/services/homes/sickrage/scripts/mp4_automator/postConversion.py", line 55, in <module>
AATraceback (most recent call last):
AA2015-07-02 15:38:24 - mkvtomp4 - INFO - Relocating MOOV atom to start of file.
AA2015-07-02 15:38:24 - mkvtomp4 - INFO - /volume3/media/TVShows/Luther/Luther.S01E04.Episode.4.720p.BluRay.m4v created.
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Starting conversion.
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Creating subtitle stream 1 from source subtitle stream 3.
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Subtitle detected for stream #3: srt [eng].
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Creating subtitle stream 0 from source subtitle stream 2.
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Subtitle detected for stream #2: srt [eng].
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Reading subtitle streams.
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Creating audio stream 1 from source audio stream 1.
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Creating audio stream 0 from source audio stream 1 [iOS-audio].
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Audio detected for stream #1: dca [eng].
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Reading audio streams.
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Video codec detected: h264
AA2015-07-02 15:36:16 - mkvtomp4 - INFO - Reading video stream.
AA2015-07-02 15:36:16 - SickbeardPostConversion - INFO - Processing /volume3/media/TVShows/Luther/Luther.S01E04.Episode.4.720p.BluRay.mkv.
2015-07-02 15:37:40 INFO     TORNADO :: User logged into the SickRage web interface from IP: <IP_ADDRESS>
2015-07-02 15:36:15 INFO     POSTPROCESSER :: Executing command [u'/var/services/homes/sickrage/scripts/mp4_automator/postConversion.py', u'/volume3/media/TVShows/Luther/Luther.S01E04.Episode.4.720p.BluRay.mkv', u'/volume1/downloads/Complete/TVShows/Ready/Luther.S01E04.UNCUT.720p.BluRay.X264-iNGOT/luther.s01e04.uncut.720p.bluray.x264-ingot.mkv', '159591', '1', '4', '2010-05-25']
2015-07-02 15:36:04 INFO     POSTPROCESSER :: Trying to clean any empty folders under /volume3/media/TVShows/Luther
2015-07-02 15:36:04 INFO     POSTPROCESSER :: Processing /volume1/downloads/Complete/TVShows/Ready/Luther.S01E04.UNCUT.720p.BluRay.X264-iNGOT/luther.s01e04.uncut.720p.bluray.x264-ingot.mkv (None)

Try updating to the latest commit and see if you're getting the same error. This still looks like an issue of the refresh command not working with Sickrage (its possible they've changed this and it no longer functions the same way the Sickbeard refresh command works)

Actually I think I know what's wrong. Do the update and also try putting your same Sickrage settings (host port api user pass) into the SickBEARD section of autoProcess.ini
I think that will likely be what fixes it

just same
2015-07-03 15:17:09 INFO     POSTPROCESSER :: Processing succeeded for /volume1/downloads/Complete/TVShows/Ready/Graceland.S03E02.Chester.Cheeto.1080p.WEB-DL.DD5.1.H.264-GL/Graceland.S03E02.Chester.Cheeto.1080p.WEB-DL.DD5.1.H.264-GL.mkv
AA
AAValueError: No JSON object could be decoded
AA    raise ValueError("No JSON object could be decoded")
AA  File "/usr/local/python/lib/python2.7/json/decoder.py", line 384, in raw_decode
AA    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
AA  File "/usr/local/python/lib/python2.7/json/decoder.py", line 366, in decode
AA    return _default_decoder.decode(s)
AA  File "/usr/local/python/lib/python2.7/json/__init__.py", line 338, in loads
AA    **kw)
AA  File "/usr/local/python/lib/python2.7/json/__init__.py", line 290, in load
AA    refresh = json.load(urllib.urlopen(settings.getRefreshURL(tvdb_id)))
AA  File "/var/services/homes/********/scripts/mp4_automator/postConversion.py", line 55, in <module>
AATraceback (most recent call last):
AA2015-07-03 15:17:09 - SickbeardPostConversion - ERROR - Couldn't refresh Sickbeard, check your autoProcess.ini settings.
AA2015-07-03 15:17:06 - mkvtomp4 - INFO - Relocating MOOV atom to start of file.
AA2015-07-03 15:17:06 - mkvtomp4 - INFO - /volume3/media/TVShows/Graceland/Graceland.S03E02.Chester.Cheeto.1080p.WEB-DL.m4v created.
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Starting conversion.
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Creating subtitle stream 0 from source subtitle stream 2.
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Subtitle detected for stream #2: srt [eng].
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Reading subtitle streams.
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Creating audio stream 1 from source audio stream 1.
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Creating audio stream 0 from source audio stream 1 [iOS-audio].
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Audio detected for stream #1: ac3 [eng].
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Reading audio streams.
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Video codec detected: h264
AA2015-07-03 15:16:10 - mkvtomp4 - INFO - Reading video stream.
AA2015-07-03 15:16:10 - SickbeardPostConversion - INFO - Processing /volume3/media/TVShows/Graceland/Graceland.S03E02.Chester.Cheeto.1080p.WEB-DL.mkv.
2015-07-03 15:16:09 INFO     POSTPROCESSER :: Executing command [u'/var/services/homes/********/scripts/mp4_automator/postConversion.py', u'/volume3/media/TVShows/Graceland/Graceland.S03E02.Chester.Cheeto.1080p.WEB-DL.mkv', u'/volume1/downloads/Complete/TVShows/Ready/Graceland.S03E02.Chester.Cheeto.1080p.WEB-DL.DD5.1.H.264-GL/Graceland.S03E02.Chester.Cheeto.1080p.WEB-DL.DD5.1.H.264-GL.mkv', '260338', '3', '2', '2015-07-02']

might have been have i had '/home' in web_root, i have removed will let you know when i post process the next file.

seems that was it :)
2015-07-04 13:05:43 INFO     POSTPROCESSER :: Processing completed
2015-07-04 13:05:43 INFO     POSTPROCESSER :: Deleting folder (if it's empty): /volume1/downloads/Complete/TVShows/Ready/Defiance.S03E05.1080p.WEB-DL.DD5.1.H.264-ECI[rarbg]
2015-07-04 13:05:43 INFO     POSTPROCESSER :: Processing succeeded for /volume1/downloads/Complete/TVShows/Ready/Defiance.S03E05.1080p.WEB-DL.DD5.1.H.264-ECI[rarbg]/Defiance.S03E05.History.Rythmes.1080p.WEB-DL.DD5.1.H.264-ECI.mkv
AA
AA2015-07-04 13:05:40 - mkvtomp4 - INFO - Relocating MOOV atom to start of file.
AA2015-07-04 13:05:39 - mkvtomp4 - INFO - /volume3/media/TVShows/Defiance/Defiance.S03E05.History.Rhymes.1080p.WEB-DL.m4v created.
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Starting conversion.
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Creating subtitle stream 0 from source subtitle stream 2.
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Subtitle detected for stream #2: srt [eng].
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Reading subtitle streams.
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Creating audio stream 1 from source audio stream 1.
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Creating audio stream 0 from source audio stream 1 [iOS-audio].
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Audio detected for stream #1: ac3 [eng].
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Reading audio streams.
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Video codec detected: h264
AA2015-07-04 13:04:14 - mkvtomp4 - INFO - Reading video stream.
AA2015-07-04 13:04:14 - SickbeardPostConversion - INFO - Processing /volume3/media/TVShows/Defiance/Defiance.S03E05.History.Rhymes.1080p.WEB-DL.mkv.
2015-07-04 13:04:12 INFO     POSTPROCESSER :: Executing command [u'/var/services/homes/********/scripts/mp4_automator/postConversion.py', u'/volume3/media/TVShows/Defiance/Defiance.S03E05.History.Rhymes.1080p.WEB-DL.mkv', u'/volume1/downloads/Complete/TVShows/Ready/Defiance.S03E05.1080p.WEB-DL.DD5.1.H.264-ECI[rarbg]/Defiance.S03E05.History.Rythmes.1080p.WEB-DL.DD5.1.H.264-ECI.mkv', '255326', '3', '5', '2015-07-03']
2015-07-04 13:04:01 INFO     POSTPROCESSER :: Processing /volume1/downloads/Complete/TVShows/Ready/Defiance.S03E05.1080p.WEB-DL.DD5.1.H.264-ECI[rarbg]/Defiance.S03E05.History.Rythmes.1080p.WEB-DL.DD5.1.H.264-ECI.mkv (None)
2


Nukies need their own uplink

Some of the riskier traitor items are very strong on nukies (e.g. holoparasite) and need to be balanced differently.

Fixed by #10201


pull request for e2e test at 12/07/2016 14:26:01

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Telegram

Telegram has this nice python bot-API, might be interesting (and easy) to add this to the notification stack!

Yes!
Good point! Some people I talked to pointed that out.
I'll work on it today or this weekend. In the meantime, if you feel like opening a PR, you are more than welcome!
Victor

Telegram notifications are now possible with commit 017437d99cb042b9f7975c0023e47dea36b14190 !! 🎉

that was quick!! awesome!


ui: Close Create network form from Zones -> Physical Network (Guest) -> Traffic Type view

Description
From the Zones -> Physical Network (Guest) -> Traffic Types View, when we attempt to create a network, Cancel / Creation of network operation doesn't close the form. This PR fixes the issue.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
Attempted creating a network from the Zones View and observed that the form closes on completion of action

@blueorangutan ui

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4993 (SL-JID-126)


Update hello_starknet.cairo

Removed the dormant 0 at the end of the get_balance function

This change is

Already fixed at main.


chore: Update crypto version for CVE fixes

It also bumps the helm version to use a newer crypto version.
b/383636497

/retest

/retest


Remove Microsoft.AspNetCore.SpaServices.Extensions dependency on Microsoft.AspNetCore.SpaServices

Most of the functionality in Microsoft.AspNetCore.SpaServices is superseded by the functionality in Microsoft.AspNetCore.SpaServices.Extensions. We'd like to obsolete the bulk of the functionality in Microsoft.AspNetCore.SpaServices, but currently Microsoft.AspNetCore.SpaServices.Extensions has a dependency on it. We should look into breaking his dependency.

Fixed by #12892.

actually I didn't want to hijack the thread, but after trying out rc1 I came across this issue. Basically we have an application that used the webpack dev middleware and there is no replacement from SpaServices. I'm not sure what SpaServices.Extensions does replace, but definitv there is no way to have a simple webpack script that works as nicely as before (scss only or scss and custom js, no react, angular, etc...)
in no way is SpaServices.Extensions a replacement or better than the simple WebpackDevMiddleware.

I've run into this also @schmitch.
How'd you proceed?


Using xr.set_options(keep_attrs=True) and Units Parsing Issue

xclim version: 0.23.2b0
Python version: 3.8.3
Operating System: Win 8.1 and Win10 64-bit

Description
Using xr.set_options(keep_attrs=True) causes an exception in indicator call(s). See script below. If removed, no exception.
Is this expected and, as far as you know, will removing xr.set_options(keep_attrs=True) produce proper results?
Please download this file and put into same folder as script:
https://code.dented-planet.net/pr.nc
import xarray as xr
import xclim as xc

xr.set_options(keep_attrs=True)

ds = xr.open_mfdataset(['pr.nc'], engine='netcdf4')
da = xc.atmos.wetdays(ds.pr, thresh='1 mm/day', freq='YS')

Result: Exception

Thanks for pointing this issue!
Short answer : It is indeed a bug. As xclim.atmos takes care of setting all appropriate attributes, you can safely remove xr.set_options(keep_attrs=True), all indicator-related attributes will be set. However,  any other attributes that xclim doesn't know of will not be kept. On your example data I see no attribute of pr that should be kept, so, at least with this dataset, removing the line is perfectly safe.
Bug explanation : The indice function (here xc.indices.wetdays) should explicitly take care of setting the units on its output. Here, with keep_attrs=True the precipitation units have been kept even if the data is now days. Our decorator would patch the correct unit if it was missing, but it raises an error (as it should) when an incorrect unit is seen.
We can easily push a bug fix for xclim 0.24, we'll need to see if this happens in other indices as well.

Thanks for pointing this issue!
Short answer : It is indeed a bug. As xclim.atmos takes care of setting all appropriate attributes, you can safely remove xr.set_options(keep_attrs=True), all indicator-related attributes will be set. However,  any other attributes that xclim doesn't know of will not be kept. On your example data I see no attribute of pr that should be kept, so, at least with this dataset, removing the line is perfectly safe.
Bug explanation : The indice function (here xc.indices.wetdays) should explicitly take care of setting the units on its output. Here, with keep_attrs=True the precipitation units have been kept even if the data is now days. Our decorator would patch the correct unit if it was missing, but it raises an error (as it should) when an incorrect unit is seen.
We can easily push a bug fix for xclim 0.24, we'll need to see if this happens in other indices as well.


spring-cloud-kubernetes-client-config-it move to test-containers

@ryanjbaxter if you do not mind, I'd like us to move to testcontainers one module at a time.

for example right inside an IDE...

yes, in the long run this is my goal. For the time being I want to first move to testcontainers for all modules - once that is done, I'll take a closer look on how to automate everything. If you do not mind, I'll take this effort in separate issue, because otherwise the files and work piles up badly... As such, run.sh is going to be here for a while.

I think it would be useful to add a README to the integration test parent module describing how these integration tests work.

absolutely. I did not think about this, but this is indeed a good idea.
P.S. Sorry for answering so late, I am from rep. of Moldova (and now everybody knows about us), and I am a little involved in the refugee crisis, time is sparse lately.

@ryanjbaxter this is ready to be reviewed. I'd like to split this work in two phases : k8s-native client and fabric8. If you look closely in run.sh, there will not be any k8s-native projects, everything is in the new phase in config.yaml. Which means :

we will no longer need run.sh once I move fabric8 projects to testcontainers
you have the option to run everything locally, as you requested (I loved the idea)

The number of files is big, but the core changes are not that big. Mainly move away from RestTemplate, re-write some paths because of the change to traefik instead of nginx and a bunch of testcontainer related changes. I also slightly (where I could) moved yaml files to separate folders, to make this easier to read and maintain.

I can't believe this took so much, but in the end, there is a PR... let me know if you have any questions what-so-ever

I am converting this back to a Draft as it seems that spring-boot 3.0.0-SNAPSHOT introduces some checks that are now failures instead of warning. When I figure out what is going on and how to fix it - this shall stay a draft.

I saw some failure in the build on Friday, I was going to try and look at it on Monday

yeah... I am struggling with this one for a week so far, I am getting closer and closer to understand what is going on, I think :)

@ryanjbaxter this one has been updated to the latest main also, and as such is ready for review too

@wind57 I spent some time messing around with this branch.
First off this is great stuff!  Thanks so much!
There was a small problem with the fabric8 configmap test you converted to config data, we need to remove the bootstrap dependency.  I made a fix and committed that.
The other issue I ran into is the istio test.  It assumes that you have the istio cli installed locally at /tmp/istio/istio-bin right?

It's not just running locally but we do builds and releases from Jenkins internally, so we need it to run there as well.
I mean we already managing the dependency by installing a specific version of Istio ourselves, now we are just keeping the cli along with the code

@ryanjbaxter thank you for fixing that issue, I was blind and could not realize to use getAbsolutePath :) I've merge main into this branch


refactor JIT exec to differentiate mutable bufs

I think JITRunner should know what its outputs are, this is a prereq for multioutput.

We can discuss that, but I think that CompiledASTRunner should have info about output buffers or kernels. This info is also needed to build hsa graph deps

The approach here is to do this at exec because that is when the Buffers for the outputs are created.
@nimlgen does the hsa graph need the info before exec is called?

I thought maybe CompiledASTRunner can have bitmask/positions of rawbufs which are used as output? hsagraph needs to know which buffers of CompiledASTRunner are read-only to build an optimal dependency chain.

Hmm, I don't like adding more variables here. What is this more generically? Maybe something like types on all the buffers.


[Feature Request] Allow comma as a tag separator

I was writing a script to apply tags to my downloaded images, and the script requires the tags to be separated by commas. When I did %all,separator=,%, it didn't work because it took the comma as a parameter separator rather than my input for the field. I tried cancelling it with a backslash which resulted in the tags being separated by backslashes. I also tried different combinations of using quotes, which led to the tags being separated by quotes xD
I also looked up available metacharacters (ex. \r \n \w \d etc.) hoping there would be something for commas, but there wasn't that I could find.

It's quite surprising this bug never popped up before, given how "basic" is the comma separator. Maybe it can be worked around in the meantime by setting the separator in the options instead, and overriding it in the filename?

Nice, I didn't even realize there was an option for this. Not sure how I missed it! That worked to just set it here as you said: Options->Save->Filename->Tags separator


[CIBUILD] Upgrade cibuild docker images to ubuntu22.04 with cuda11.7.

Hold, python3.8.6 introduce some compatibility issue such as spicy, wait UT all pass firstly.


Ignore images from embedded html when pasting, paste plaintext instead.

Details
When pasting some HTML containing images into Composer, it will cause an error modal. This is because of the server's Content Security Policy, which prevents those images from being fetched separately. This PR prevents the images from being fetched, instead it will paste the plaintext that is copied.
Fixed Issues
$ https://github.com/Expensify/App/issues/18583
$ https://github.com/Expensify/App/issues/18583#issuecomment-1598515619
Tests

Copy a web document which contains both text and images. (e.g. https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_image_test)
Log in with any account.
Go to any chat
Paste the contents into the composer
Verify that no image attachments are being created.
Verify that the correct contents are within the composer box.
Verify that no error modals are appearing upon paste.

[x] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps

Copy a web document which contains both text and image. (e.g. https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_image_test)
Log in
Go to any chat
Paste the contents into the composer
Verify that the correct contents are within the composer box.
Verify that no error modals are appearing upon paste.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/31749903/21079b2a-ecc6-4f14-bc56-5e5f453725d6

Mobile Web - Chrome
https://github.com/Expensify/App/assets/31749903/44bdf909-4ef6-440d-965a-dfecb456a30d

Mobile Web - Safari
https://github.com/Expensify/App/assets/31749903/a31a1cfd-454b-4495-a2bb-7ac4c96509b8

Desktop
https://github.com/Expensify/App/assets/31749903/7af5aaaf-ab1f-4503-bfc2-b775ae854ce7

iOS
https://github.com/Expensify/App/assets/31749903/0e904d2b-df71-48c1-9c4a-c953baf0e37d

Android
https://github.com/Expensify/App/assets/31749903/a3f7e7b9-251c-4b43-9ca0-86fa4b6c0b89

OK, @parasharrajat I'm happy to wait until that PR is merged before we test this again - we might not need further changes in that case. Is that ok?

@parasharrajat I have just updated the PR to reinstate the logic for emojis. Please let me know if any other changes are required.

https://github.com/Expensify/expensify-common/pull/555 PR is merged, so I think we can move forward with thoroughly testing this PR now, right?

@techievivek I've just tested it. Unfortunately, it appears to have the same behaviour, still creating an empty link. I'm using a test branch based on main with this PR's updates.
Do we need to revise ExpensiMark again? @parasharrajat

In lib/ExpensiMark.js:
{
                name: 'link',
                process: (textToProcess, replacement) => this.modifyTextForUrlLinks(MARKDOWN_LINK_REGEX, textToProcess, replacement),
                replacement: (match, g1, g2) => {
                    if (g1.match(CONST.REG_EXP.EMOJIS) || !g1.trim()) {
                        return match;
                    }
                    return `<a href="${Str.sanitizeURL(g2)}" target="_blank" rel="noreferrer noopener">${g1.trim()}</a>`;
                },
            },

If this is the relevant rule, I think we need to update the part !g1.trim() to strip new lines as well in addition to just whitespaces. It's the new line causing the empty link to appear, I believe.

@parasharrajat I'm OOO until Monday - but essentially you can recreate it on any website with an image wrapped in a link.

@parasharrajat
Here's an example I found, which creates an empty link, even without a new line:
<meta charset='utf-8'>
The image below is a link. Try to click on it.

You can copy the contents from here: https://www.w3schools.com/html/tryit.asp?filename=tryhtml_links_image
This is the result:

Hi @parasharrajat, it wasn't clear to me, but did you want me to make a PR in expensify-common? Or shall I wait until you have tested it?

@parasharrajat, any updates here?

@parasharrajat Gentle bump to keep this moving, also QA reported that this was not reproducible https://github.com/Expensify/App/issues/18583#issuecomment-1649115793 🤯, haven't verified it myself tho.

@parasharrajat, Can you please prioritize this PR, as it has been open for some time now? Thanks

@parasharrajat From our last conversation, we were discussing some proposed changes to ExpensiMark. We already established that this PR alone also isn't fixing the issue. I think you were going to review something before I tried to make a PR there.

@parasharrajat Main is merged in now. Let me know if you need anything else.

Sorry, I was ooo on Friday, taking a look now. Thanks.

@qispark Linting seems to be failing, can you please fix that, thanks.

@techievivek Just updated lint.

@techievivek Just updated again due to prettier failing.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add PHP example

This blog post details out a PHP approach to the 1brc with a good walk through of step by step iterative improvements: https://dev.to/realflowcontrol/processing-one-billion-rows-in-php-3eg0

Hey @jcbhmr 🖖
I added a GitHub Repo with the PHP solution: https://github.com/realFlowControl/1brc
Would be awesome if you could add it, I could also provide you a PR in case it helps.


[rv_dm, testutils] Refactor testutils to return status_t for all rv_dm

Description
No response

There are no testutils for this module, so can close.


Set isOnline flag in MyUplinkService

Hmm.. I tested this and committed some changes to the PR branch. Thought they should show up here? Can you merge them to this if you can see them?
There was still an issue that the IsOnline state was not transferred outside the service. Did quite an ugly fix for that and while I was at it, noticed that we have the same enum x2 but with different numbers. I guess this was due to numbering differences on the units -> Ugly fix on that. Noticed also that the MyUpway Service was still trying to use the old _login method in a few places and fixed those.

I don't really know how github should handle this situation when another contributor (of upstream) pushes changes to a PR branch of a fork...
But apparently there are 2 branches now on your own repository, maybe you noticed already (maybe you pushed your changes there?).
I suppose you can create additional PRs from those branches on your own repo (set-isonline-flag-in-myuplinkservice and lobstaj-set-isonline-flag-in-myuplinkservice).

Yeah, I merged this and did the additional fixes straight.
I need to lookup at some point how GitHub handled that and what I did wrong, multiple times 😅 I have a strong feeling that I've encountered a use case like that previously, never done it myself though.


Toolbar: Hide "View published" and "Edit" buttons for app hook pages?

Summary
A customer of ours is confused by the "View published" and "Edit" buttons in the toolbar that are also present on "apphooked" pages which are controlled by the respective app more than by django cms.
Is there a way to hide those for app hook pages (other than using brute force CSS)?
Expected behaviour
On "apphooked" pages that are controlled by the respective app more than by django cms, I would expect the "View published" and "Edit" buttons to disappear.
Actual behaviour
The buttons are present but seem functionless.
Environment

Python version: 3.6
Django version: 1.11
django CMS version: 3.5

Never mind.
I came to realise that the buttons do have an effect on the app hook pages, namely toggling the ability to edit the placeholder(s)... a bit misleading maybe, but after all with functionality.


Undefined offset 0 at GDUtils.php

I run gd_info() on my server and the result is:
[
     "GD Version" => "2.2.5",
     "FreeType Support" => true,
     "FreeType Linkage" => "with freetype",
     "GIF Read Support" => true,
     "GIF Create Support" => true,
     "JPEG Support" => true,
     "PNG Support" => true,
     "WBMP Support" => true,
     "XPM Support" => true,
     "XBM Support" => true,
     "WebP Support" => true,
     "JIS-mapped Japanese Font Support" => false,
   ]

Unfortunately the regex is only can handle the gd_info with () like this
[
     "GD Version" => "bundled (2.1.0 compatible)",
     "FreeType Support" => true,
     "FreeType Linkage" => "with freetype",
     "GIF Read Support" => true,
     "GIF Create Support" => true,
     "JPEG Support" => true,
     "PNG Support" => true,
     "WBMP Support" => true,
     "XPM Support" => false,
     "XBM Support" => true,
     "WebP Support" => true,
     "JIS-mapped Japanese Font Support" => false,
   ]

So, the regex not match in my server because of this
        $re = '/\((.*?)\s/';
        $gdinfo = self::getGDInfo();
        preg_match_all($re, $gdinfo["GD Version"], $matches, PREG_SET_ORDER, 0);
        return doubleval($matches[0][1]);

This has been fixed in version 1.0.1


GetxController are not mockable

Describe the bug
On tests when you try to mock a GetxController and then try to put it on Get.put it throws a null call exception.
To Reproduce
Run a flutter test
Expected behavior
Should work fine. We wer using version 3.4.x and it was working fine.
Now on 3.6.1 it does not work anymore.
Trace Exception
The method 'call' was called on null.
Receiver: null
Tried calling: call()
dart:core                                                                   Object.noSuchMethod
package:get/src/instance/get_instance.dart 178:16                           GetInstance._startController
package:get/src/instance/get_instance.dart 152:7                            GetInstance._initDependencies
package:get/src/instance/get_instance.dart 219:7                            GetInstance.find
package:get/src/instance/get_instance.dart 86:12                            GetInstance.put
package:get/src/instance/extension_instance.dart 72:12                      Inst.put
test/main_getx_test.dart 5:7                                                main
===== asynchronous gap ===========================
package:test_api                                                            RemoteListener.start
/tmp/flutter_tools.DJSWUH/flutter_test_listener.IZBBRF/listener.dart 16:25  serializeSuite
/tmp/flutter_tools.DJSWUH/flutter_test_listener.IZBBRF/listener.dart 42:36  main
Flutter Version:
Flutter 1.20.2
Get Version:
GetX 3.6.1
Describe on which device you found the bug:
On Testing - flutter test ...
Minimal reproduce code
import 'package:get/get.dart';
import 'package:mockito/mockito.dart';

void main() async {
  Get.put<Sample>(MockSample());
  print('done');
}

class Sample extends GetxController {}

class MockSample extends Mock implements Sample {}

Here is the fix
You need to check if onStart exists on get_instance.dart
(line 174)
  void _startController<S>({String tag}) {
    final key = _getKey(S, tag);
    final i = _singl[key].getDependency();
    if (i is DisposableInterface) {
      if (i.onStart != null) i.onStart();
      GetConfig.log('"$key" has been initialized');
    }
  }
``

Thanks I'll update now

Fix on 3.7


Add FCAlertView to Alerts section

Added FCAlertView to the Alerts section.
Project URL

https://github.com/k9101/FCAlertView
Description

FCAlertView is a Flat Customizable AlertView for iOS.
Why it should be included to awesome-ios (optional)
It's awesome
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 8 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

  :no_entry_sign:
  Found 2 link issues

Link issues by awesome_bot

Line
Status
Link

1351
301
https://github.com/jaydee3/JDFlipNumberView redirects tohttps://github.com/calimarkus/JDFlipNumberView

1447
301
https://github.com/jaydee3/JDStatusBarNotification redirects tohttps://github.com/calimarkus/JDStatusBarNotification

  Generated by :no_entry_sign: danger

@yoha amazing README with the images!! 👏 👏
Thanks for contributing! 😃

@lfarah Glad to contribute back! 👍

@lfarah I have a question; I want to include a project that's written in obj-c but the contribution guideline specifies that project not written in swift 3 is ineligible. So, shall I just ignore the swift 3 support checkbox when doing pr?

@yoha That rule is only for Swift projects. Objective-C projects are more than welcome in AwesomeiOS, so please send a pull request! 😃 👍


Incorporate metrics information into DocService

DocService currently shows the list of the available operations, structs, and their debug forms. We could also:

display the metrics of the related operations,
add a page about global metrics (and settings) and
rename DocService to something that fits better

https://twitter.github.io/twitter-server/Admin.html


PivotTableWidget does not work on Mendix 6

PivotTableWidget does not work on Mendix 6. I get a blank page after logon. When I don't use the widget on any page, application functions well. As soon as I use the widget, i get a blank page. Widget does not seem adapted for mendix 6. When will this be?

Hallo ,
Krijgt u ook een melding over cacheburst?
If you get an empty page use the index-console.html to double check if non of the widgets are blocking. The cacheburst itself shouldn't be a problem. But when upgrading Mendix versions, widgets often break, which can result in odd javascript behaviour and empty pages..
For users affected by the js alert and white screen, I've found no other solution than to instruct them to clear their cache.
Vriendelijke groet,
Marco Groenenberg
Van: mkrouwel<EMAIL_ADDRESS>Verzonden: dinsdag 21 juni 2016 15:31
Aan: synobsys/mendix-PivotTableWidget<EMAIL_ADDRESS>Onderwerp: [synobsys/mendix-PivotTableWidget] PivotTableWidget does not work on Mendix 6 (#5)
PivotTableWidget does not work on Mendix 6. I get a blank page after logon. When I don't use the widget on any page, application functions well. As soon as I use the widget, i get a blank page. Widget does not seem adapted for mendix 6. When will this be?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/synobsys/mendix-PivotTableWidget/issues/5, or mute the threadhttps://github.com/notifications/unsubscribe/AMbdfMllpaVN0wIqK-H8LnwjKwxWQIsHks5qN-d7gaJpZM4I6vDD.

Hi,
heb cache geleegd en in zowel IE als Chrome geprobeerd, zonder succes.
Bijgaand de melding in Chrome
[image: Inline image 2]
On Tue, Jun 21, 2016 at 4:57 PM, Marco Groenenberg<EMAIL_ADDRESS>
wrote:

Hallo ,
Krijgt u ook een melding over cacheburst?
If you get an empty page use the index-console.html to double check if non
of the widgets are blocking. The cacheburst itself shouldn't be a problem.
But when upgrading Mendix versions, widgets often break, which can result
in odd javascript behaviour and empty pages..
For users affected by the js alert and white screen, I've found no other
solution than to instruct them to clear their cache.
Vriendelijke groet,
Marco Groenenberg
Van: mkrouwel<EMAIL_ADDRESS>Verzonden: dinsdag 21 juni 2016 15:31
Aan: synobsys/mendix-PivotTableWidget <
<EMAIL_ADDRESS>Onderwerp: [synobsys/mendix-PivotTableWidget] PivotTableWidget does not
work on Mendix 6 (#5)
PivotTableWidget does not work on Mendix 6. I get a blank page after
logon. When I don't use the widget on any page, application functions well.
As soon as I use the widget, i get a blank page. Widget does not seem
adapted for mendix 6. When will this be?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<
https://github.com/synobsys/mendix-PivotTableWidget/issues/5>, or mute
the thread<
https://github.com/notifications/unsubscribe/AMbdfMllpaVN0wIqK-H8LnwjKwxWQIsHks5qN-d7gaJpZM4I6vDD>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/synobsys/mendix-PivotTableWidget/issues/5#issuecomment-227466825,
or mute the thread
https://github.com/notifications/unsubscribe/ARC8wVbxNBvxFkn3u_08pS8HynZ7Y4M2ks5qN_vmgaJpZM4I6vDD
.

This release is working now. Tested it in MX6.5


RBAC - Configure privileged access group settings (preview) in Privileged Identity Management

Documentation states that a user in the Privileged Role Administrator role should have access to edit a group role settings.  The only way i can get the EDIT button to activate is to elevate to a higher privileged role (GA).

My permissions:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b7cb16c2-c407-cf67-0d5b-ab7f7690cd37
Version Independent ID: a8d7a914-cb7e-01f6-285a-6786666fbbf1
Content: Configure privileged access groups settings in PIM - Azure Active Directory
Content Source: articles/active-directory/privileged-identity-management/groups-role-settings.md
Service: active-directory
Sub-service: pim
GitHub Login: @curtand
Microsoft Alias: curtand

FYI @curtand

@felickz Thanks for your feedback! We will investigate and update as appropriate.

Hi @felickz
Thanks for your dedication to our documentation! Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. I have contacted the team again for this issue, but the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close